Fix OpenSSL, curl and AWS SDK for Android

Describe the pull request
Adds toolchain chaining to external builds

What does your PR fix? Fixes #
Fixes Android builds. Same solution can be used in the future for any cross-platform builds.

Which triplets are supported/not supported? Have you updated the CI baseline?
x64-Android

Does your PR follow the maintainer guide?
Yes

Done

Done

CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:63 (message):
  Applying patch failed.  error: corrupt patch at line 70

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:145 (vcpkg_apply_patches)

CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:63 (message):
  Applying patch failed.  error: corrupt patch at line 70

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:145 (vcpkg_apply_patches)

CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:63 (message):
  Applying patch failed.  error: corrupt patch at line 70

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:145 (vcpkg_apply_patches)

I'm struggling to fix it but I don't understand why it works in some envs and not in others!

CMake Error at scripts/cmake/vcpkg_apply_patches.cmake:63 (message):
  Applying patch failed.  error: corrupt patch at line 70

Call Stack (most recent call first):
  scripts/cmake/vcpkg_extract_source_archive_ex.cmake:145 (vcpkg_apply_patches)

I'm struggling to fix it but I don't understand why it works in some envs and not in others!

@ahmedyarub Is my patch correct?

@ahmedyarub Is my patch correct?

@ahmedyarub Is my patch correct?

Yes! I've just tested it. Thank you very much.

@ahmedyarub Is my patch correct?

Yes! I've just tested it. Thank you very much.

Need test all features.

Need test all features.

When building aws-sdk-cpp[*]:x86-windows:
[391/413] "C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
FAILED: aws-cpp-sdk-transfer/CMakeFiles/aws-cpp-sdk-transfer.dir/source/transfer/TransferManager.cpp.obj
"C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): error C2220: warning treated as error - no 'object' file generated
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): warning C4244: 'initializing': conversion from 'const _Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(777): warning C4244: 'initializing': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(927): warning C4244: 'argument': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(66): warning C4244: 'argument': conversion from '_Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(258): note: see reference to function template instantiation 'T *Aws::New<T,const _Ty&,unsigned __int64>(const char *,const _Ty &,unsigned __int64 &&)' being compiled
        with
        [
            T=Aws::Utils::Stream::PreallocatedStreamBuf,
            _Ty=unsigned char *
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(827): note: see reference to function template instantiation 'std::unique_ptr<Aws::Utils::Stream::PreallocatedStreamBuf,Aws::Deleter<Aws::Utils::Stream::PreallocatedStreamBuf>> Aws::MakeUnique<Aws::Utils::Stream::PreallocatedStreamBuf,const RESOURCE_TYPE&,uint64_t>(const char *,const RESOURCE_TYPE &,uint64_t &&)' being compiled
        with
        [
            RESOURCE_TYPE=unsigned char *
        ]

When building aws-sdk-cpp[*]:x86-windows:
[391/413] "C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
FAILED: aws-cpp-sdk-transfer/CMakeFiles/aws-cpp-sdk-transfer.dir/source/transfer/TransferManager.cpp.obj
"C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): error C2220: warning treated as error - no 'object' file generated
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): warning C4244: 'initializing': conversion from 'const _Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(777): warning C4244: 'initializing': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(927): warning C4244: 'argument': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(66): warning C4244: 'argument': conversion from '_Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(258): note: see reference to function template instantiation 'T *Aws::New<T,const _Ty&,unsigned __int64>(const char *,const _Ty &,unsigned __int64 &&)' being compiled
        with
        [
            T=Aws::Utils::Stream::PreallocatedStreamBuf,
            _Ty=unsigned char *
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(827): note: see reference to function template instantiation 'std::unique_ptr<Aws::Utils::Stream::PreallocatedStreamBuf,Aws::Deleter<Aws::Utils::Stream::PreallocatedStreamBuf>> Aws::MakeUnique<Aws::Utils::Stream::PreallocatedStreamBuf,const RESOURCE_TYPE&,uint64_t>(const char *,const RESOURCE_TYPE &,uint64_t &&)' being compiled
        with
        [
            RESOURCE_TYPE=unsigned char *
        ]

When building aws-sdk-cpp[*]:x86-windows:
[391/413] "C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
FAILED: aws-cpp-sdk-transfer/CMakeFiles/aws-cpp-sdk-transfer.dir/source/transfer/TransferManager.cpp.obj
"C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): error C2220: warning treated as error - no 'object' file generated
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): warning C4244: 'initializing': conversion from 'const _Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(777): warning C4244: 'initializing': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(927): warning C4244: 'argument': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(66): warning C4244: 'argument': conversion from '_Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(258): note: see reference to function template instantiation 'T *Aws::New<T,const _Ty&,unsigned __int64>(const char *,const _Ty &,unsigned __int64 &&)' being compiled
        with
        [
            T=Aws::Utils::Stream::PreallocatedStreamBuf,
            _Ty=unsigned char *
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(827): note: see reference to function template instantiation 'std::unique_ptr<Aws::Utils::Stream::PreallocatedStreamBuf,Aws::Deleter<Aws::Utils::Stream::PreallocatedStreamBuf>> Aws::MakeUnique<Aws::Utils::Stream::PreallocatedStreamBuf,const RESOURCE_TYPE&,uint64_t>(const char *,const RESOURCE_TYPE &,uint64_t &&)' being compiled
        with
        [
            RESOURCE_TYPE=unsigned char *
        ]

This is not related at all to my changes. The current VCPKG version has this bug: https://github.com/aws/aws-sdk-cpp/issues/1512
My version makes changes to Android only. Do you want me to update to the latest AWS version?

When building aws-sdk-cpp[*]:x86-windows:
[391/413] "C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
FAILED: aws-cpp-sdk-transfer/CMakeFiles/aws-cpp-sdk-transfer.dir/source/transfer/TransferManager.cpp.obj
"C:\PROGRA~2\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\Hostx64\x86\cl.exe"   /TP -DAWS_CHECKSUMS_USE_IMPORT_EXPORT -DAWS_COMMON_USE_IMPORT_EXPORT -DAWS_EVENT_STREAM_USE_IMPORT_EXPORT -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=8 -DAWS_SDK_VERSION_PATCH=83 -DAWS_TRANSFER_EXPORTS -DENABLE_BCRYPT_ENCRYPTION -DENABLE_WINDOWS_CLIENT -DPLATFORM_WINDOWS -DUSE_IMPORT_EXPORT=1 -DUSE_WINDOWS_DLL_SEMANTICS -Daws_cpp_sdk_transfer_EXPORTS -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-s3\include -IG:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include -IG:\15725\vcpkg\installed\x86-windows\include /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /GR /EHsc /MP  /MP /bigobj /WX /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /showIncludes /Foaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\source\transfer\TransferManager.cpp.obj /Fdaws-cpp-sdk-transfer\CMakeFiles\aws-cpp-sdk-transfer.dir\ /FS -c G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): error C2220: warning treated as error - no 'object' file generated
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(772): warning C4244: 'initializing': conversion from 'const _Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(777): warning C4244: 'initializing': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(927): warning C4244: 'argument': conversion from 'uint64_t' to 'size_t', possible loss of data
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(66): warning C4244: 'argument': conversion from '_Ty' to 'size_t', possible loss of data
        with
        [
            _Ty=uint64_t
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-core\include\aws/core/utils/memory/AWSMemory.h(258): note: see reference to function template instantiation 'T *Aws::New<T,const _Ty&,unsigned __int64>(const char *,const _Ty &,unsigned __int64 &&)' being compiled
        with
        [
            T=Aws::Utils::Stream::PreallocatedStreamBuf,
            _Ty=unsigned char *
        ]
G:\15725\vcpkg\buildtrees\aws-sdk-cpp\src\1c85d0a8c9-4ee9b543a6.clean\aws-cpp-sdk-transfer\source\transfer\TransferManager.cpp(827): note: see reference to function template instantiation 'std::unique_ptr<Aws::Utils::Stream::PreallocatedStreamBuf,Aws::Deleter<Aws::Utils::Stream::PreallocatedStreamBuf>> Aws::MakeUnique<Aws::Utils::Stream::PreallocatedStreamBuf,const RESOURCE_TYPE&,uint64_t>(const char *,const RESOURCE_TYPE &,uint64_t &&)' being compiled
        with
        [
            RESOURCE_TYPE=unsigned char *
        ]

This is not related at all to my changes. The current VCPKG version has this bug: https://github.com/aws/aws-sdk-cpp/issues/1512
My version makes changes to Android only. Do you want me to update to the latest AWS version?

@ahmedyarub  No need to update in this PR, can you open an issue to report this?
Thanks.

@ahmedyarub  No need to update in this PR, can you open an issue to report this?
Thanks.

@ahmedyarub No need to update in this PR, can you open an issue to report this?
Thanks.

Issue opened
Please hold on merging this one as I found that some dependencies are not built automatically

@ahmedyarub No need to update in this PR, can you open an issue to report this?
Thanks.

Issue opened
Please hold on merging this one as I found that some dependencies are not built automatically

Building dependencies fixed. You can merge.

Building dependencies fixed. You can merge.

Thanks for the PR!
This looks like it's vendoring these dependencies (zlib, openssl, curl) -- this is against the vcpkg maintainer policy. Instead, it'd be much better to fix these common dependencies so others can benefit as well!

I completely agree. But all the previous AWS ports in VCPKG were already done this way. Do you want me to completely rewrite something that has been used for a year or more here?
I'd be glad to do that but this is not something that I added, it has always been like this in AWS SDK's port for VCPKG....

Thanks for the PR!
This looks like it's vendoring these dependencies (zlib, openssl, curl) -- this is against the vcpkg maintainer policy. Instead, it'd be much better to fix these common dependencies so others can benefit as well!

I completely agree. But all the previous AWS ports in VCPKG were already done this way. Do you want me to completely rewrite something that has been used for a year or more here?
I'd be glad to do that but this is not something that I added, it has always been like this in AWS SDK's port for VCPKG....

Still working on this it's very complicated....

Still working on this it's very complicated....

@ahmedyarub  Please ping me if this PR is ready for review.

@ahmedyarub  Please ping me if this PR is ready for review.

@ahmedyarub Please ping me if this PR is ready for review.

This will take me at least one more day. Their CMake scripts are very hard to deal with...

@ahmedyarub Please ping me if this PR is ready for review.

This will take me at least one more day. Their CMake scripts are very hard to deal with...

Seems all test passed, is this PR ready for review?

Seems all test passed, is this PR ready for review?

Seems all test passed, is this PR ready for review?

I'm making major changes to the implementation which should be ready by today.

Seems all test passed, is this PR ready for review?

I'm making major changes to the implementation which should be ready by today.

@ras0219-msft @JackBoosY ready for final review finally!

Looks like the only pipelines failing are due to a port not related to me at all which is rate-limited by Source Forge

Wait for #16270 merge.

Wait for #16270 merge.

Merged it into my branch and now ktx is failing!!

Waiting for merge https://github.com/microsoft/vcpkg/pull/16289.

Wait for #16270 merge.

Ready :)

@JackBoosY changes done :)

I fixed everything but I can't understand these weird errors!

@ahmedyarub  Don't worry, I will take a look.

Please note we should only bump the single port version once in one PR.

Please note we should only bump the single port version once in one PR.

Thank you very much for the help. Next I'll do iOS and WASM.

@ahmedyarub Please make that changes in another PR.

Solved merge conflicts and retested everything. Ready for merge.

@JackBoosY none of the errors are related to my changes, I think. I just updated to solve merge conflicts unrelated to me.

@JackBoosY when is this PR scheduled for merging?

@ahmedyarub Tomorrow.

OMG...more and more regressions appear.

OMG...more and more regressions appear.

Where are these coming from? I did merge in the latest master branch and I can build without any problem on my machine.

/azp run

Need wait for #16837 merge first.

Need wait for #16837 merge first.

Merged

@JackBoosY ready for final review

/azp run

Now osgearth is failing!!! @JackBoosY

Guys if you don't mind this PR has been open fr months already and it has many many commits. I made every change that you requested so far. I really want to make other contributions based on this one but it seems like it will never be merged..
@ras0219-msft @JackBoosY

@ahmedyarub  Because the pipeline test results always fail.

@vicroms Ping for merge this PR.

Can you please merge from master?
Thanks.

Done

Ping @ras0219 @ras0219-msft for review again.

Something is really wrong with the pipelines. Here it says that the pipelines are still in progress but here https://dev.azure.com/vcpkg/public/_build/results?buildId=52107&view=results all the tests passed successfully hours ago!

@ahmedyarub it was an issue with the oauth token we think


Move recommendation engine to server.py

Need to start incorporating the python to a user friendly environment

fixed via pull request #38


Login test behave (based on @monikakrawczak's PR)

@adamgajzlerowicz @w1stler

Can we merge?
Do we need a ticket for integrating behave into CI/CD pipeline?


Cost minimal debugger (Run-By-Line) without datatip support

The MVP for a Run-By-Line experience does not require datatips to be available.  This issue just represents the costing for that experience.

Costing is done so validated.


Addition of flag -s

Added flag -s to the bend commands to display interactions, time, and other information provided by bend as shown in the image below.

0.1.92 has been released

thanks for this pr


Parse error with function defined inside package

When reading a package file I get a parse error, the file contains:

package img_gfx_std_func_pack_;
localparam IMG_CLK_GATE_FANOUT = 32;
function automatic integer img_log2(integer d);
integer tmp, COUNT;
tmp  = 1;
for (integer COUNT = 0; COUNT < 31; COUNT++) begin // N.B. Synopsys requires static loops.
if (tmp >= d)
return COUNT;
tmp = tmp*2;
end
// Should never get here, but add return statement to avoid spyglass warning
return d;
endfunction : img_log2
endpackage
This produces a parse error but the code is valid:

Executing Verilog-2005 frontend: img_gfx_std_func_pack_.sv
Parsing SystemVerilog input from img_gfx_std_func_pack_.sv' to AST representation.
img_gfx_std_func_pack_.sv:43: ERROR: syntax error, unexpected TOK_FUNCTION

I now have a PR open which adds support for tasks and functions declared within packages. However, the example provided here also depends on #2693 and #2684.


Properties/setget do not offer clickable links

Godot version
4.0 beta 10
System information
Linux
Issue description
When you set a property to point to a function it should offer a clickable link to the function. I know you can create anonymous/inline methods but distinguishing the two should be easy enough...

Steps to reproduce
Create a setter/getter and try to use it to get there
Minimal reproduction project
n/a

This appears to work as expected (Godot 4.2.stable, MacOS 13.6.1 [Ventura]).

Tested too, I can reproduce the bug in 4.0-stable, it was fixed in 4.1-stable.


Update whatis-azure-ad-connect.md

Fixed a grammatical error in the documentation

@sphill Thanks for catching this.
#sign-off


Bluetooth: Mesh: Remaining pieces of persistent storage support

This is a follow-up PR to #7368
TODO:

[x] Offload storing/clearing to system workqueue
[ ] IV Update state handling
[ ] Model publication
[ ] Model subscription
[ ] Model binding
[ ] Any other Configuration Server model states
[ ] Proper testing (also against the PTS)

Fixes #7073 once GATT CCC storage has been implemented as part of #7417

Codecov Report

Merging #7428 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7428   +/-   ##
=======================================
  Coverage   55.26%   55.26%
=======================================
  Files         467      467
  Lines       51641    51641
  Branches     9886     9886
=======================================
  Hits        28541    28541
  Misses      19190    19190
  Partials     3910     3910

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31afd18...cac0942. Read the comment docs.

CC @trond-snekvik @thomasstenersen

For #BluetoothMesh, is all persistence data storage going to based on FCB ?
Will it use #NVS:6391, once it merged in future ?
What is going to be final ? & why ?

For #BluetoothMesh (or #Bluetooth), is all persistence data storage going to based on FCB?

No, it's based on the settings API, and the settings API currently supports FCB and NFFS as backends. I've enabled FCB in the sample app configuration since I needed to choose one or the other, and FCB is more light-weight.

Will it use #NVS:6391, once it get merged in future ?
What is going to be final ? & why ?

Nothing is final, Zephyr is a continuously evolving project :)  NVS wasn't merged (and still isn't) when I started working on this, and persistent storage is something we want for 1.12 for which the merge window closing is coming up very soon. Once we have one working solution, we can look at refactoring it to let NVS be one possible storage option, either directly or as a backend to settings.

Another note in favor of settings over NVS: if there's only a partition and some other subsystem requires a file system, doing settings over NFFS will work as a solution both for settings and that other subsystem, whereas with NVS you'd need to redo the partitioning to have two partitions.

Is Model subscription address get stored?
Because in case of #meshctl, for unprovisioned node I execute
discover-unprovisioned on
security 0
provision xxxx
menu config
target 0100
appkey-add 1
bind 0 1 1000
bind 0 1 1001
bind 0 1 1002
bind 0 1 1003
sub-add 0100 c000 1000
sub-add 0100 c000 1002
pub-set 0100 c000 1 0 5 1001
pub-set 0100 c000 1 0 5 1003
Then reset the board, & execute only
connect 0000
menu config
target 0100
pub-set 0100 c000 1 0 5 1001
pub-set 0100 c000 1 0 5 1003
But my on board LEDs do not react.  So have to execute,
sub-add 0100 c000 1000
sub-add 0100 c000 1002

@vikrant8051 please try with the latest version of patches in this PR (just a few minutes old). At least in my own tests restoring both subscription and publication works now.

Ok

I did but facing same condition...
I executed following command ..

cd $(zephyr_base)
git fetch origin pull/7428/head:BluetoothMesh
git checkout BluetoothMesh
git rebase BluetoothMesh

@vikrant8051 it really sounds like you might not have the latest patches, since both subscription and publication works for me (I'm using samples/bluetooth/mesh for testing). Can you confirm if you have "Bluetooth: Mesh: Support for storing model publication persistently" as part of your tree?

"Bluetooth: Mesh: Support for storing model publication persistently"
Is it another PR ?

yes

--> git log
commit 02bceccd86e47d7cca6104874a75e3e3d59a84fa
Author: Johan Hedberg<EMAIL_ADDRESS>Date:   Wed May 9 21:34:52 2018 +0300
Bluetooth: Mesh: Support for storing model bindings persistently

Add support for storing the bound App Keys for each model
persistently. The bindings are stored under the settings key
bt/mesh/s/<mod id>/bind for SIG models and bt/mesh/v/<mod id>/bind for
vendor models.

Signed-off-by: Johan Hedberg<EMAIL_ADDRESS>
commit 7d545d8121fe755fd8670f019d359244ab8b98b2
Author: Johan Hedberg<EMAIL_ADDRESS>Date:   Tue May 8 21:18:55 2018 +0300
Bluetooth: Mesh: Redesign element and storage info for models

Keeping the model struct same sized, change the element pointer to two
indexes, and add a flags member that will be used to track pending
storage actions.

Signed-off-by: Johan Hedberg<EMAIL_ADDRESS>
commit 2c8e70b30acce6e21b1eb5b4642853fc68d64187
Author: Johan Hedberg<EMAIL_ADDRESS>Date:   Wed May 9 09:21:54 2018 +0300
Bluetooth: Mesh: Perform storage clearing also through delayed work

In order not to have a Node Reset consume more stack than other
operations, also perform the related storage writes through the same
delayed work as all other storage updates.

I think latest things have merged in my local repository.
But I've observed strange behavior. Now I've to only execute

connect 0000
menu config
target 0100
sub-add 0100 c000 1000

@jhedberg
Now I directly modified sample/bluetooth/mesh demo example & edit gen_onoff_set_unack() to control LED1 on #nRF52840_PDK board. Let it be Board A.
For provision & configure Board A, I used this commands
discover-unprovisioned on
security 0
provision xxxx
menu config
target 0100
appkey-add 1
bind 0 1 1000
sub-add 0100 c000 1000
For testing, use Generic_OnOff_Client which is executing on another board (Let it be B). If I don't reset Board A then it works as expected but as soon as I reset then have to execute following commands
connect 0000
menu config
target 0100
sub-add 0100 c000 1000

Now I realized that publish addresses are getting saved but same is not happening in case of subscription addresses.

@vikrant8051 you're completely right, sorry. I've forgotten to add the appropriate calls to bt_mesh_store_mod_sub() to cfg_srv.c. I'll update this PR in a moment with the fix.

@vikrant8051 the PR has now been updated and module subscription should be properly stored. Please test.

Ok ..

HI @jhedberg,
This is today observations based on following configuration in case of Node A & Node B,
(Each Node have -

Gen. OnOFF Server, {LED 1}
Gen. OnOFF Client, {Button1 : ON & Button 2: OFF}
Gen. Level Server,  {LED3... if (Level  < 50) LED3: OFF ...if (Level > 50) LED3: ON }
Gen. Level Client, {Button3: publishes Level = 25 .....Button4: publishes Level = 75 }
)

I configured node A with following commands,

sub-add 0100 c000 1000
pub-set  0100 c000 1 0 5 1001

sub-add 0100 c000 1002
pub-set 0100  c000 1 0 5 1003

& Node B as

sub-add 0101 c000 1000
pub-set  0101 c000 1 0 5 1001

sub-add 0101 c001 1002
pub-set 0101 c001 1 0 5 1003

If I press Button 1/2 on any Node, then LED1 should turn ON/OFF on both Node.
This is because Generic OnOFF server on both NODEs has same subscription address i.e. 0xC000.
(This is happening as expected)

If I press Button 3/4 on any Node, then LED3 should react only on that particular node.
(since NODE A Gen. Level server subscription addr = 0xC000 &
NODE B Gen. Level server subscription addr = 0xC001 )

But if I pressed Button 3/4 on NODE A, then LED 3 on NODE B are also reacting...which is strange.

This is not happening in case of NODE B. Here if I pressed  Button 3/4 then LED 3 on only NODE B are reacting. (This is happening as expected)

I would like to re-test it to confirm my observations.

Yes !! I've confirmed my observation.

@vikrant8051 is what you're describing related to the persistent storage? Could you try the latest version of this PR - there was a fix to locally originated messages and the RPL which might be related.

Ok..

Now I disable,
#CONFIG_BT_SETTINGS=y
#CONFIG_FLASH=y
#CONFIG_FLASH_PAGE_LAYOUT=y
#CONFIG_FLASH_MAP=y
#CONFIG_FCB=y
#CONFIG_SETTINGS=y
#CONFIG_SETTINGS_FCB=y
& commented
/*
if (IS_ENABLED(CONFIG_SETTINGS)) {
settings_load();
}
*/
Even after that, facing same observation.
That means it has nothing to do with Persistent storage.

@jhedberg
I've already share my customized version of samples/bluetooth/mesh project (via Google Drive Link) with you which I am using for testing. Could you please quickly check it so that I can use it without any hesitation for testing purpose ?

Thanks @carlescufi
I'll merge this now, and we can then work out any remaining issues or missing features in follow-up PRs.


perf: minify

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

46 of 46 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 97.137%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
412

Relevant Lines:
417

💛  - Coveralls


fix(ecs): grant drain-hook policy container-instance permissions

UpdateContainerInstanceState and ListTask APIs require permissions on
a container-instance resource, rather than a cluster resource. This
change updates the policy to:

remove the cluster as the resource restriction
add the cluster as a resource condition

More info on ECS Resource-Level permissions can be found here:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-supported-iam-actions-resources.html
Fixes #3190

Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Good buddy @pkandasamy91 - mind taking a look? :)

@kohidave welcome!
Was this closed intentionally?

@eladb the build was failing so i pulled it in and updated it https://github.com/awslabs/aws-cdk/pull/3199


Method for renderSuggestions is called twice on every input causing flicker in the rendering

First, thank you very much for this very clean and well thought out library, it is very nice to work with.
One thing: When passing a render function to renderSuggestions, fx:
partTypes={[
  {
    trigger: '@',
    renderSuggestions: renderSuggestions,
  },
]}

the renderSuggestions method is called twice every time the value prop passed <MentionInput> changes, with the keyword argument passed to renderSuggestions being undefined in the first call followed by the correct value in the next call.
So when we use the logic if (keyword == null) to check if the suggestions element should be rendered or not, it first thinks it should not render, and then it renders right after, causing an unwanted quick visible flicker:
const renderSuggestions = ({keyword, onSuggestionPress}) => {
  console.log(keyword) // undefined on the first call, the correct string (fx "ma") on the second call

  if (keyword == null) {
    return null;
  }

  return (
      ...
  );
}

This only happens when the value prop is changed by the user typing an extra character, if the user deletes a character renderSuggestions is still called twice, but the keyword argument is correct in both calls.
Is there something we can do to avoid this behaviour? It happens in our code and also if you run the example code provided with this library.

Check for undefined as well
let query = keyword;
  if (keyword == null) {
    if (lastKeyword == null) {
      return null;
    } else {
      query = lastKeyword;
    }
  }

const filteredMention = mentions.filter((one) =>
    one.name.toLocaleLowerCase().includes(query.toLocaleLowerCase()),
  );

This solved my flicker issue.

@Punit-Vajpeyi where do you store lastKeyword? In your local state? This feels like something that should be prevented in the library (the first call with the empty keyword).

Hi there,
We're reproducing the exact same thing as @krismeld has described - the renderSuggestions is called twice every time <MentionInput> value changes. To me it's  unclear why this happens even after digging into implementation of this lib and its use of renderSuggestions.
A temporary workaround we're using is to throttle the incoming keyword. Works like a charm 🙈
const renderSuggestions = ({keyword, onSuggestionPress}) => {
  // BUG: undefined on the first call, the correct string (fx "ma") on the second call
  console.log(keyword)

  // FIX: Throttling the value of `keyword` into `calmKeyword` and using it later in the function
  const [calmKeyword, setCalmKeyword] = useState(keyword);
  useEffect(() => {
    const timeout = setTimeout(() => setCalmKeyword(keyword), 10);
    return () => clearTimeout(timeout);
  }, [keyword]);

  if (calmKeyword == null) {
    return null;
  }

  return (
      ...
  );
}

This is still an issue. @domasn workaround fixed it for me temporarily. However, this is not ideal.

Just leaving this here. Don't have time for a pull request at the moment but the bug is caused by the double dependency on parts and plainText here:
const keywordByTrigger = useMemo(() => {
return getMentionPartSuggestionKeywords(
parts,
plainText,
selection,
partTypes,
);
}, [parts, plainText, selection, partTypes]);
Changing this to a single dependency on the value prop (which in turn is based on the combination of parts and plainText) fixes it.

Just leaving this here. The bug is caused by the dependency on selection here:
const keywordByTrigger = useMemo(() => {     return getMentionPartSuggestionKeywords(       parts,       plainText,       selection,       partTypes,     );   }, [parts, plainText, selection, partTypes]);
Selection is maintained in the state so by the time selection updates the parts dependency may not have been recalculated, which causes getMentionPartSuggestionKeywords to return undefined.
An ugly but working solution is:
const keywordByTrigger = useMemo(() => {     if (selection.end <= plainText.length) return getMentionPartSuggestionKeywords(       parts,       plainText,       selection,       partTypes,     );   }, [parts, plainText, selection, partTypes]);

Just leaving this here. The bug is caused by the dependency on selection here:
const keywordByTrigger = useMemo(() => { return getMentionPartSuggestionKeywords( parts, plainText, selection, partTypes, ); }, [parts, plainText, selection, partTypes]);
Selection is maintained in the state so by the time selection updates the parts dependency may not have been recalculated, which causes getMentionPartSuggestionKeywords to return undefined.
An ugly but working solution is:
const keywordByTrigger = useMemo(() => { if (selection.end <= plainText.length) return getMentionPartSuggestionKeywords( parts, plainText, selection, partTypes, ); }, [parts, plainText, selection, partTypes]);

Will this work if the trigger is in the middle of the sentence for example .
"This is my example sentence" and i want to enter # at the middle of it before example like "This is my #example example sentence" In this case selection.end < plaintenxt.length . Any workaround for this would be appreciated

@domasn - Don't do that...timers are evil man 🤣
@vegerot12 I have the same concern...
Here is how it should have been written (selection with a ref)...reduce one state change which will also be more performant depending how big the component is that it's sitting in, and double renders vanish!

https://gist.github.com/Aryk/a1699136cda19cfc730f0e7e8023a5c1
PS Looking to hire a Sr. React Native dev.

Thank you all for the productive discussion and ideas. Indeed, we are observing a double render because we handle the change in state of both the text and selection, which can be critical in some cases. For example, when the user does not change the text, but instead just moves the cursor to another place, and we need to show relevant suggestions (see video). In such a case, the truly ingenious solution from @Aryk of storing the selection state in useRef won't work.
https://github.com/dabakovich/react-native-controlled-mentions/assets/20565227/ecdd58e1-2904-402d-992a-d35b0c67b159
To make matters worse, in TextInput on iOS with the multiline prop, there is an issue that the onSelectionChange fires BEFORE the onTextChange event. Whereas on Android, or on iOS without multiline, this event behaves as expected—after onTextChange. This makes the keyword undefined for a split second. As far as I know, this issue remains unresolved, so alternative solutions need to be sought.
A compromise might be to use the custom useThrottledKeyword hook. Since more often than not we are receiving suggestions from the backend anyway, adding a throttle wouldn't hurt, and in our case, it will even help avoid flickers. Here's an example of such a hook:
const useThrottledKeyword = (keyword: string | undefined, delay = 10) => {
  const [throttledKeyword, setThrottledKeyword] = useState(keyword);

  useEffect(() => {
    const timeout = setTimeout(() => {
      setThrottledKeyword(keyword);
    }, delay);

    return () => {
      clearTimeout(timeout);
    };
  }, [keyword]);

  return throttledKeyword;
};


Adding extra constraint to WithEndpoint

Fixes #4059
Some of the WithEndpoint overloads were not constrained. This PR adds the appropriate constraint. There is some splash damage to the Orleans-specific resource types here. It seems strange to require IResourceWithEndpoints for something that is being configured as being an orleans client, although practically anything that is a client would be a resource that has this interface, so I don't think the constraint is a problem here.
Microsoft Reviewers: Open in CodeFlow

This is a breaking change. Do we obsolete?

I don't think we can in this case because they would be ambiguous.

Closing in favor of #4071


Add a sort module

It's now possible for a theme using the sort extra to let users configure the sort order.
Currently supported criteria are group, file, line and access.
The configuration is done with a sort context key. It's an array of strings, representing a sort criteria plus an optional sort order. The sort order is determined if the last character is either > or < (respectively desc and asc).
Example:
{
  "sort": [
    "access",
    "line>",
    "group",
    "file"
  ]
}

See SassDoc/sassdoc#239

No unit tests though ?

Nope. :/


Network error: HTTP status code: 502.

With some series this error is showing:
I tried with this link: https://www.crunchyroll.com/rezero-starting-life-in-another-world-
NetworkException: HTTP status code: 502
at Request. (/media/sdc1/theruleof4/lib/node_modules/cr-dl/src/ListDownloader.js:92:36)
at Request.emit (events.js:203:13)
at Request.onRequestResponse (/media/sdc1/theruleof4/lib/node_modules/cr-dl/node_modules/request/request.js:1059:10)
at ClientRequest.emit (events.js:208:15)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:575:27)
at HTTPParser.parserOnHeadersComplete (_http_common.js:116:17)
at TLSSocket.socketOnData (_http_client.js:449:22)
at TLSSocket.emit (events.js:203:13)
at addChunk (_stream_readable.js:295:12)
at readableAddChunk (_stream_readable.js:276:11)
events.js:180
throw er; // Unhandled 'error' event
^
Error: ENOENT: no such file or directory, open 'tmp_hluucb/VodVidData/seg-124-v1-a1.ts'
Emitted 'error' event at:
at errorOrDestroy (internal/streams/destroy.js:107:12)
at WriteStream.onerror (_stream_readable.js:744:7)
at WriteStream.emit (events.js:203:13)
at internal/fs/streams.js:289:12
at FSReqCallback.oncomplete (fs.js:153:23) {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: 'tmp_hluucb/VodVidData/seg-124-v1-a1.ts'

Can you try again? I assume that they just had some server problems.


Home Assistant 2023.8.0 - Error adding entities for domain switch

Sorry folks, Error when updated to 2023.8.0
Logger: homeassistant.components.switch
Source: helpers/entity_platform.py:619
Integration: Switch (documentation, issues)
First occurred: 21:47:58 (2 occurrences)
Last logged: 21:47:58
Error adding entities for domain switch with platform toshiba_ac
Error while setting up toshiba_ac platform for switch
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 510, in async_add_entities
await asyncio.gather(*tasks)
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 619, in _async_add_entity
device = dev_reg.async_get(self.hass).async_get_or_create(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: DeviceRegistry.async_get_or_create() got an unexpected keyword argument 'account'

Wrong thread, I think


Tomophantom plugin

closes #826

closes #831

https://github.com/vais-ral/CCPi-Framework/issues/831 We should add it to the DataOrder class as CIL_IG_LABELS and CIL_AG_LABELS

Thanks @gfardell it looks much better now.
I'll add the AcquisitionData and a few tests and we're there.

Some progress here:
I create am acquisition and image geometry. I create the shepp logan phantom with the tomophantom plugin and then reconstruct with FPB and FISTA+TV.
Now the boilerplate code around tomophantom is gone and only 2 lines are required.
The 2 reconstruction methods take about 10 lines! 5 lines are used to set up the geometries.
So far I completed the get_ImageData (2D, 3D and multichannel) and only the 2D part of the get_AcquisitionData.

Obtained with this code
from cil.plugins import TomoPhantom
from cil.framework import ImageGeometry, AcquisitionGeometry
from cil.plugins.tigre import FBP, ProjectionOperator
import numpy as np
from cil.utilities.display import show2D
from cil.optimisation.algorithms import FISTA
from cil.optimisation.functions import TotalVariation, LeastSquares

if __name__=='__main__':

    N=256
    ig = ImageGeometry(N,N, channels=1)
    model = 1
    print("shape", ig.shape)
    phantom = TomoPhantom.get_ImageData(model=model, geometry=ig)

    angles = np.linspace(0, 360, 50, True, dtype=np.float32)

    ag = AcquisitionGeometry.create_Cone2D((0,-100000), (0,100))
    ag.set_panel(N)
    ag.set_angles(angles, angle_unit=AcquisitionGeometry.DEGREE)
    print ("AcquisitionGeometry shape ", ag.shape)
    data = TomoPhantom.get_AcquisitionData(model=model, geometry=ag, fill_factor=1.)
    data.reorder(order='tigre')
    ig = ag.get_ImageGeometry()
    arec = FBP(ig, ag)
    arec.set_input(data)
    recon = arec.get_output()

    A = ProjectionOperator(ig, ag)
    f = LeastSquares(A, data)
    alpha = 0.5
    g = alpha * TotalVariation(lower=0)

    algo = FISTA(initial=A.domain.allocate(0),
          f=f, g=g, max_iteration=100, update_objective_interval=10)
    algo.run(verbose=1)
    show2D([phantom, data, recon, algo.solution], title=['phantom', 'phantom data', 'FBP recon' , 'FISTA TV'])

Notice that on this dataset, on my computer it takes 1s/iter with TotalVariation while it takes 0.5s/iter and 1.2 s/iter with the regularisation toolkit with gpu and cpu backend respectively.

There's no example on usage.


chore: bump selenium-java from 4.1.2 to 4.1.3

Updates org.seleniumhq.selenium:selenium-java from 4.1.2 to 4.1.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.seleniumhq.selenium", artifactId = "selenium-java" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #211.


octoprint.python.pkgs.costestimate: 3.3.0 -> 3.4.0

Motivation for this change
update
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

How did you test this?

octoprint.plugins.costestimation

That's not a valid attribute exposed by the octoprint package.
Furthermore octoprint currently pins click 7, because it's development is rather slow, so we get
ERROR: Could not find a version that satisfies the requirement click<9.0,>=8.0 (from celery) (from versions: none)
ERROR: No matching distribution found for click<9.0,>=8.0
error: builder for '/nix/store/ly64116lw25h8n30zxdjn1pr4vifghj7-python3.9-celery-5.2.1.drv' failed with exit code 1;

So I wonder how you got this to build on aarch64-linux, as you claimed. Can you enlighten me?

I tested it around 5. of december, when the package celery was not broken.
Testing can be done by setting: services.octoprint.plugins = "plugins: with plugins; [ costestimation ]"

The PR currently does not fulfil the requiremenents of CONTRIBUTING.md.

The attribute name is invalid, try nix-build -A <attribute>, won't. work. The correct attribute is octoprint.python.pkgs.costestimate, which you can easily see when browsing the Git history.

Also celery was bumped to 5.2.0 mid november (see d45b0b0f05cd04f00c4f18b0ae3d44492c2a3992), which is when it started requiring click>=8.0. As it is, unless OctoPrint itself does not support click>=8.0, we'd need to downgrade celery via packageOverrides.

I remember now. I build it on release-21.05 and rebased it without checking.

@mweinelt  octoprint is fixed with #151577.


traceback error

I keep getting this message after installing the latest release on blender 4.0.
I have tried reinstalling multiple times.

Fixed by extracting, renaming and readding to the ZIP file


Add dependencies' environment configuration

What does this pull request do?
Adds COMMUNITY_API_URL and INTERVENTIONS_SERVICE_URL to the deployment configuration.
Also removes unused HMPPS_COOKIE_NAME and REDIS_ENABLED.
What is the intent behind these changes?
These are required to boot the application up in Kubernetes.

deploy worked
$ helm upgrade hmpps-interventions-ui hmpps-interventions-ui --install --wait --reset-values --timeout 5m --history-max 10 --values values-dev.yaml --set image.tag="2020-12-03.342.1b55882"
Release "hmpps-interventions-ui" has been upgraded. Happy Helming!


Feature/supple space base

To make the framework more userfriendly $supple-space is replaced with $supple-space-base.
Pros:

Searching and replacing variables is easier
Searching and replacing variables is uberhaupt possible
pLEASE we just want to be able to search and replace our variables 😭

PR is merged to develop branch. When milestone 2.2 is ready this will be released. 🚀


New reminder features

Hi, this PR add :

reminder name and timedelta in the confirmation message
jump url to the message where the reminder was set in the deliver message

I marked this PR as draft because I don’t have my test environment setup yet so theses changes aren’t tested for now.
This PR closes #241.
The PR python-discord/site#277 need to be merged before this one.

Now tested and ready to go ! The only problem is that the jump_url is never added to the database, gdude said it is apparently because there is no jump_url in the model.

I opened python-discord/site#277 to had the jump_url field to the reminder model.

https://github.com/python-discord/site/pull/277 was closed. So this is blocked until that change is made.
@Akarys42 did you at least open an issue on the site repo so that someone else can make this change if you don't intend to make it yourself?

I didn’t opened a issue because I want to do it myself, I’m with my family this weekend, so I will probably do it next week is it okay for you.

This PR add the jump_url field to the reminder model : python-discord/site#288. This PR need to be merged first.

This doesn't pass lint. Please address.

Updated.


Currency converter - add a swap currency button/link

Problem Statement
Most users will use the same 2 currencies in their calculations, but the direction will change. It would be much easier to just swap the currencies than to have to pick them out of a list.
Evidence or User Insights
Well in a lot of European countries we deal with different currencies and swapping between them is common. But you're either receiving or paying, usually the same 2 currencies.
There is also no memory in the list of currencies, so trying to find the same 2 currencies just to swap them is an excercise in patience.
Proposal
By giving a swap button a person would cut out the time of even having to open the list, let alove get aggrivated trying to find their specific currency. (memorising last used would also help here)
Goals
Quicker and more painless use of currency conversion.
Requested Assignment
I'm just suggesting this idea.  I don't want to implement it.

Hi Mika76! A similar feature already exists in the Calculator, although I have to admit that it is not easy to find.
If you click on the second unit:

The conversion will be done from this unit to the first one:

I would admit, we can probably make this feature easier to discover.
In addition, a feature request is currently opened to automatically flip From & To fields when users select the same unit than the other field, more information here: https://github.com/microsoft/calculator/issues/266
Let us know what you think about these 2 features.

🤦♂ I can't believe I missed that! Thanks a million. So the functionality is pretty much there, just a little hidden. It works great so I'm happy to close this. Thanks for the help.

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.


Investigate performance issues - long living page (frequent update)

/cib

partial fix in: 305-from-dev2311-Investigate_performance_issues](https://github.com/ix-ax/AXOpen/tree/305-from-dev2311-Investigate_performance_issues)


Production container

As a researcher, I want to be able to deploy my experiment as simply as possible, without needing to know too much about DevOps, so that I can focus my effort on the part of the toolset that is enabling science, not the parts that are just overhead.
I want to be able to:

build a container and push it to the Github Container Registry as a Github Action (https://github.com/Watts-Lab/deliberation-empirica/pkgs/container/deliberation-empirica)
Deploy the container
View and store container logs
View server resource use
Persist data across server restarts
Reset everything sometimes

Old "solution"
So far, I have been using DigitalOcean's App platform, which takes a dockerfile plus some environment variables and handles almost everything else. This is easy to set up and manage, and has been great for:

developing in containers
setting up data storage scripts
making sure I have a clean environment each time
connecting to GH Actions for CI/CD

Unfortunately, DO App Platform limits the disk space of the container to 2GB, which has caused some problems in production. Ideally, we'd just attach an external file system volume, but DO only lets you attach S3-like "spaces" or a managed database, and we need true file storage for Empirica V2's file-based data storage model.
What i'd love is something with the simplicity of DO's App platform, but just with the ability to mount an arbitrarily large file volume.
What I've tried
I've tried to move the app to Azure App Service which is the same sort of PAAS model, where you provide a container and they handle most of the rest. The major annoyance with this is that you can't mount a volume to a path with a . character in it and empirica V2 uses the directory /.empirica/local to store the data. This effectively means that I can't mount a volume where I need it on Azure either.
Can you help me

Work out if I can get DO or Azure to do what I need? or...
Set up something easily manageable on AWS? or...
Figure out another service I could use that does what I need?

In all honesty, I'm a little wary of AWS, because every time I try and use their stuff, I end up spending a couple days figuring out how to navigate their system, and I don't want to have to employ/be a full-time dev-ops expert to be able to manage and debug the system.

Some potential steps:

If in Amazon, likely will need Elastic Container Service (ECS)
Managed cluster - Fargate; don't have to manage underlying VMs
Meet with Amazon solutions architect to help with this
Shawn is going to reach out for ECS consultation with solutions architect. Will join because he's building an experiment with Empirica as well.
Amazon is offering trainings for small groups mostly targeted to the Wharton computing team; They have done one on ML. If lab is interested we could probably attend
Terraform - Shawn can send over more info on how they've used it


feat(taiko-client): make p2p-sync required

@RogerLamTd @k-kaddal I think we don't need to trigger the Bridge UI CI in the taiko-client feature PR like this. Maybe we can optimize the workflow.

@RogerLamTd @k-kaddal I think we don't need to trigger the Bridge UI CI in the taiko-client feature PR like this. Maybe we can optimize the workflow.

@YoGhurt111 Not sure why its triggering to be honest, I don't see changes to packages/bridge-ui... will investigate.


General Discussions & Project Status

TheOnlyRealTodd commented 18 days ago
Hello. How is this project going? I want to get on it! I am an ASP.NET MVC/Web API Jr. Dev looking to get on a project like this. I'll pull it down and add myself in shortly. I'm seeing last changes as months ago, is the project still alive?

coni2k commented 17 days ago • edited
Hi TheOnlyRealTodd,
Thanks for your interest in the project.
Yes, hopefully the project will be alive till I can make something out of it. My current item is to upgrade front-end part to Angular2. That takes some time, plus I'm on a trip at the moment. I will be back to full-time work around two weeks.
I have lot of plans for the project, big and small, however mostly I keep them as my personal notes. So, if you have something specific on your mind about the project, let me know. Otherwise I can try to find something suitable for you?

TheOnlyRealTodd commented 17 days ago
coni2k great yeah that sounds good. I read over the instructions to add myself and will probably do that tomorrow when I have some time. I do not know Angular2 yet, but I do have experience with MVC/Web API/Entity Framework.

coni2k commented 16 days ago
Sure, please try to add your name to the list, so you can see whether the project runs on your computer without any issues.
Angular is not a necessity, your backend knowledge totally fits.
I'm hoping to achieve, initially, an embeddable (to other websites) dynamic survey/simulator kind of application, by retrieving and saving the data through WebApi.
After angular2, I'd like to focus on Asp.Net Core by the way, did you have time to look at that?

TheOnlyRealTodd commented 16 days ago
coni2k I have looked at .NET Core. I have not really "tackled" it yet though, as I was trying to get more experience with the previous version just so that I didn't confuse myself... However, I do get the gist of it plus I have a Pluralsight account where they have several courses on it which are beneficial.
Seems to be a lot more modular which could make for a better development experience. One thing I was experimenting with too was setting up Role and Claims-based authentication with OAuth, which was no easy task, lol. Ok I'm going to get started right now.

TheOnlyRealTodd commented 16 days ago
Alright so I got it on my machine and I can add myself and modify the files no big deal, but I can't get it to run because it's basically saying there is no start point. It is saying "A project of type Class Library cannot be started directly" which is obvious, but please excuse my ignorance. I tried to start the nGClient project.

coni2k commented 16 days ago
No problem, in Getting Started, check step 8 - in your solution, you need to tell to start both of the projects at the same time;
https://github.com/forCrowd/WealthEconomy/wiki/Getting-Started
This is one of the things that I'd like to get rid of, but Visual Studio doesn't save this setting on the project level, but keeps it on the user level, so everyone has to do this himself, bummer!

TheOnlyRealTodd commented 16 days ago
coni2k ahhhh. awesome, got the servers running! This is helpful to know, in the past I just manually started them all up.

coni2k commented 14 days ago
Good to hear that the instructions help you :) Did you manage to handle the rest?

TheOnlyRealTodd commented 12 days ago • edited
coni2k yup! Just sent in the Pull Request finally. I ran the unit tests as well.

coni2k commented 11 days ago
Todd hi,
Yep, I saw it, it's merged and published :)
https://wealth.forcrowd.org/_system/content/contributors
If you would like to update your info later on, feel free to send me a new request.
Again, thanks for your interest in the project and if you see some other parts that you can contribute, let me know, I'd happy to discuss.

angelfeliz commented 11 days ago
Hello i am in to contribute to this project, i liked the stack you are using to build up the project and also the economy context of the project. I did all the step to make the first pull request and is only expecting the approve. So looking forward to keep coding 👍

coni2k commented 10 days ago
Angel hi,
Thank you for your interest in the project, also that you mention economy context, it's good to hear.
I will try to merge your PR tonight. And afterwards we can discuss how to continue.

angelfeliz commented 10 days ago
About the project:
How is going to be the input of the data (user input, read from RSS, get
the info from public API, read public data source)
I will be checking the project on this weekend and see if i can upload to
angularjs2 if i need any help i will contact you
Keep in touch, goodbye

coni2k commented 9 days ago
Two good points Angel;
1- About data input:
a. User input, as it is now but of course needs to be improved.
b. Read from a public API.
c. And of course whatever we can add, import & parse XLS files etc.
About reading from a public API, I was hoping to read license data from this endpoint:
https://api.opensource.org/licenses/
And create a similar example to this:
https://wealth.forcrowd.org/sample/Knowledge-Index-Popular-Software-Licenses
The only problem, in my case, I need EULA (Microsoft license) in the list and of course that's not in open source license list. So, the data from API needs to be merged (extended) etc. A small detail but something to mention.
If this sounds interesting, just let me know and we can dive into details?
2- Upgrading to angular2: This is what I was working at the moment, and I was studying ng2. However, currently I'm on a trip and not working full-time. If you think you can quickly upgrade it, that would also be a huge help for me.
In case you would like to work on it, create a new Web Application project and give it a name ng2Client, so we can have both ngClients at the same time for a while and we can compare.
Let me know your thoughts.

TheOnlyRealTodd commented 9 days ago
Let me know if I can jump into this anyhow as well angelfeliz . Unfortunately, I do not know Angular but I do know MVC/Web API.

angelfeliz commented 9 days ago
Ok i will start the update of angularjs2 on saturday my time zone is UTC -4
if anyone is available.
About the data input check out this post
https://medium.freecodecamp.com/with-open-data-you-finally-get-what-your-taxes-already-paid-for-6f1990d98e9#.1vs9dy5pz
it reference to some open data source page like the govermment here a
example you are going to find in the post
Think about all the economic benefits of open source software. 75% of smart
phones run on Android. 80% of servers run on Linux. And this is just the
tip of the open source iceberg.
with that data we can suggest or know about one part of the tech economy

angelfeliz commented 9 days ago
https://medium.com/turning-lids/some-interesting-datasets-to-work-with-8abfafb16d76#.1tnt5idph

coni2k commented 7 days ago
angelfeliz, thanks for the articles, especially Quincy Larson has a good point, as usual. It's good to see open data also becomes a norm.
And the whole idea behind Wealth Economy project is how could we speed this process up? If a company decides to use an open source license, or shares its data as open data, then this company must have more income (should become financially stronger), than its competitors that do otherwise.
As I said earlier, I am on a trip and I will return to full-time work after next week. So, if you can work on upgrading to ng2 or any other items, just let me know the progress.
TheOnlyRealTodd, one of the items that I'd like to focus on is unit testing. Backend almost has no proper unit testing code, which means if someone add a new code, it's not clear whether the existing code breaks or not. Do you have any experience with that?

TheOnlyRealTodd commented 6 days ago
coni2k I'm actually learning/studying unit testing right now. I have been taking a course on Pluralsight as well as reading the book "The Art of Unit Testing" by Roy Osherove.
Yeah, I looked through the project and noticed that a lot of the unit tests are not complete (there are no assertions). I should be able to help out with this soon. I'm still getting my feet wet with unit testing but I'm headed in the right direction. For example, I recently unit tested a controller in a Web API 2 Project of mine and discovered that you have to get comfortable with mocking repositories and unit of work, etc... The mocking has a little bit of a learning curve as well and I am also going through that with moq.

coni2k commented 5 days ago
TheOnlyRealTodd, this sounds really good. Even if you could create couple of examples and say what kind of cases should be tested etc., that would be a great help. I believe from there I could complete the rest by myself.

TheOnlyRealTodd commented 3 days ago
coni2k Ok great. I'll see what I can do soon. Might have to do it next week because I've been made very busy this week with a few other projects.

angelfeliz commented 18 hours ago
I created the ng2client project, starting to set up the angular2js
environment. Could't finish the pass weekend, I am scheduling time on the
week to finish

@angelfeliz, sounds great. Did you publish your latest update to github?
I found this in your repositories, but there is not much in it at the moment?
https://github.com/angelfeliz/WealthEconomy/tree/master/ng2Client
@TheOnlyRealTodd, of course, whenever you have time.
And since our conversations are becoming useful and might give some idea about the project to others, I wanted to move our messages to a new issue, we can continue under this one.

As a general info, my trip is over. So hopefully starting from tomorrow I will start working on it full-time again.
By the way, got curious, do you both have full-time jobs at the moment?

I do have full time work at the moment, i thinking to schedule a amount of
hours at the beginning of every week.
On Sun, Oct 16, 2016 at 7:05 AM, Serkan Holat<EMAIL_ADDRESS>wrote:

As a general info, my trip is over. So hopefully starting from tomorrow I
will start working on it full-time again.
By the way, got curious, do you both have full-time jobs at the moment?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/forCrowd/WealthEconomy/issues/106#issuecomment-254040439,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHXuJgc8_0dzl5cO7ygvRoxe10cSHJ5dks5q0gULgaJpZM4KX8PK
.

--
Ángel Eduardo Rodriguez
Ingeniero en sistema
Gmail<EMAIL_ADDRESS>Cel.:<PHONE_NUMBER>
"You don’t write code just to be there."
[image: Códigos QR / Qr Codes]

@coni2k after checking the pull request and accept, one of the issue to  create is pass the view that are in ngClient to ng2Client using angular2.

ok cool, let me know if anything comes up

@angelfeliz By the way, last time we were talking about upgrading to Angular2. That upgrade took longer than I expected, almost two months but now front-end is Angular 2 (actually on my branch it just upgraded to Angular 4, with my next merge it will on Main).
And I'm busy with introducing Karma+Jasmine to front-end at the moment.

@coni2k Hi, there! I would like to help work on this project too. If there is anything specific you'd like me to help with, please let me know. I've been working with .NET MVC and relearning JavaScript (working on the foundations of it.) :)

@sblasa Hi, there! Thank you for your interest in working this project. In the following days I'm hoping to work on preparing a plan/map for the project. I can let you know during that time and we can see what we can do together. Sounds good?

@coni2k Yes, that sounds good to me! Thanks! 😄

Backbone is our active project at the moment, please visit:
https://github.com/forCrowd/Backbone/
https://backbone.forcrowd.org


TypeError: Cannot read property '0' of undefined

I am testing the module with my RXV775. At first it works as expected, but after several hours deployed the flow, node red start crashing when the a/v receiver sends any event. Still sends the "last" command triggered by the flow, but crashes when the receiver sends the response event.
2 Dec 12:22:21 - [red] Uncaught Exception:
2 Dec 12:22:21 - TypeError: Cannot read property '0' of undefined
at /data/node_modules/node-red-contrib-avr-yamaha/avr-yamaha.js:371:55
at Parser. (/data/node_modules/xml2js/lib/parser.js:303:18)
at emitOne (events.js:96:13)
at Parser.emit (events.js:188:7)
at Object.onclosetag (/data/node_modules/xml2js/lib/parser.js:261:26)
at emit (/data/node_modules/sax/lib/sax.js:624:35)
at emitNode (/data/node_modules/sax/lib/sax.js:629:5)
at closeTag (/data/node_modules/sax/lib/sax.js:889:7)
at Object.write (/data/node_modules/sax/lib/sax.js:1436:13)
at Parser.exports.Parser.Parser.parseString (/data/node_modules/xml2js/lib/parser.js:322:31)
at Parser.parseString (/data/node_modules/xml2js/lib/parser.js:5:59)
at exports.parseString (/data/node_modules/xml2js/lib/parser.js:354:19)
Removing the AVR-YAMAHA-IN node and deploying it again without any configuration change, only selecting the proper avr already configured, solves the problem until it start crashing again.

Thanks for the report. Seems like the incoming event data has a format, that I do not expect. I've updated the nodes and tried to catch the error. Please have a look at version 0.8.1.
I also added a warning. If you enable debug mode in the config node, then the unexpected event data is logged in the node-red debug output.
Would be happy if you could post the data here, as I would be curious what data arrives.
Cannot reproduce your error here with my AVR.

f5c6eedf9ecc98133aa46c967f123bcdba76b66a

Thanks for the support. I tried the new version and after a while it started failing again. I modified the line #335 to print the received event:
3 Dec 00:48:11 - [info] Server now running at http://<IP_ADDRESS>:1880/
3 Dec 00:48:11 - [info] Starting flows
3 Dec 00:48:15 - [info] Started flows
3 Dec 00:48:15 - [info] [avr-yamaha:yamaha receiver] STARTING event listener
3 Dec 00:48:15 - [info] [avr-yamaha:yamaha receiver] UDP client listening on <IP_ADDRESS>:1900
3 Dec 00:48:25 - [info] [avr-yamaha:yamaha receiver] sending PUT command:<YAMAHA_AV cmd="PUT"><Zone_2><Power_Control>On</Power_Control></Zone_2></YAMAHA_AV>
3 Dec 00:48:26 - [info] [avr-yamaha:yamaha receiver] UPnP Event from [<IP_ADDRESS>] --> NOTIFY * HTTP/1.1
Host: <IP_ADDRESS>:1900
NT: urn:schemas-yamaha-com:service:X_YamahaRemoteControl:1
NTS: yamaha:propchange
USN: uuid:::urn:schemas-yamaha-com:service:X_YamahaRemoteControl:1
PowerPlay_Info
3 Dec 00:48:26 - [red] Uncaught Exception:
3 Dec 00:48:26 - TypeError: Cannot read property '0' of undefined
at /data/node_modules/node-red-contrib-avr-yamaha/avr-yamaha.js:382:37
at Parser. (/data/node_modules/xml2js/lib/parser.js:303:18)
at emitOne (events.js:96:13)
at Parser.emit (events.js:188:7)
at Object.onclosetag (/data/node_modules/xml2js/lib/parser.js:261:26)
at emit (/data/node_modules/sax/lib/sax.js:624:35)
at emitNode (/data/node_modules/sax/lib/sax.js:629:5)
at closeTag (/data/node_modules/sax/lib/sax.js:889:7)
at Object.write (/data/node_modules/sax/lib/sax.js:1436:13)
at Parser.exports.Parser.Parser.parseString (/data/node_modules/xml2js/lib/parser.js:322:31)
at Parser.parseString (/data/node_modules/xml2js/lib/parser.js:5:59)
at exports.parseString (/data/node_modules/xml2js/lib/parser.js:354:19)
at Socket. (/data/node_modules/node-red-contrib-avr-yamaha/avr-yamaha.js:365:13)
at emitTwo (events.js:106:13)
at Socket.emit (events.js:191:7)
at UDP.onMessage (dgram.js:548:8)

After several tests, the node works as expected if you are working with the main zone. If you want to control another zone, it crashes when the first response event is received:
{"YAMAHA_AV":{"$":{"cmd":"EVENT"},"Zone_2":[{"Property":["Power","Play_Info"]}]}}
I think the problem is line #374 looking for Main_Zone in result... it is in a try, it fails, mainZone is set to "undefined" and this is the reason why it crashes in #382.
A dirt way to avoid this is to check if mainZone is undefined after the try and try again with the next zone...
if (mainZone == undefined){   try{     mainZone = result.YAMAHA_AV.Zone_2; }catch (e){     if (node.debug) {       node.warn('Unknown event message format: ' + JSON.stringify(result));     }     return; }

Thanks for the help. Your're right. It crashed when events other than from the Main_Zone were received. Good point. I tried to fix it in a way, that also the event data of the correct zone is ouput. Should also work for zone 3 + 4 now.
Please have a look at v0.8.2.

Thank you, every flow I have are working without crashes now.

Thanks for the feedback.


mr: Don't set minimum number of args

The commands use parseArgsWithGitBranchMR() to parse non-flag arguments,
which will return the MR id associated with the current branch if no
id is specified.
That behavior makes a lot of sense, but can only work if the option parser
doesn't enforce the id to be specified.

LGTM.


beacon.dropbox.com

Hey!
Why is this beacon.dropbox.com is blocked? seem to be part of the Word/office plugin for macOS.
Thanks!

Thanks Luis @luispuerto.
Ping Daniel @lightswitch05.

Users can add Dropbox integration in Office 365 for Mac OSX, then create and eventually share files.
The URL in this issue appears as one of the Dropbox URLs used to host user data.

@Atavic that's a very nice list.  Props to Dropbox for publishing it.  And hopefully maintaining it.

The files can only be in Word, Access or Excel format. If the files are personal there's no issues; but office files can actually hide some malicious macro actions. There are various cases: a tool like this may help in mitigating non-hardened systems.

@Atavic maybe I'm blind - but I do not see beacon.dropbox.com anywhere in that list.
@luispuerto are you experiencing trouble with that host being blocked? I have dropbox on my mac and I haven't noticed any problems with it being blocked. Could you provide steps to reproduce the issue so that I can verify it causing issues?

@lightswitch05
$ ack -l beacon.dropbox.com
alternates/fakenews/hosts
alternates/fakenews-gambling/hosts
alternates/fakenews-gambling-porn/hosts
alternates/fakenews-gambling-porn-social/hosts
alternates/fakenews-gambling-social/hosts
alternates/fakenews-porn/hosts
alternates/fakenews-porn-social/hosts
alternates/fakenews-social/hosts
alternates/gambling/hosts
alternates/gambling-porn/hosts
alternates/gambling-porn-social/hosts
alternates/gambling-social/hosts
alternates/porn/hosts
alternates/porn-social/hosts
alternates/social/hosts
data/lightswitch05/hosts    <----------
hosts

Sorry Steven, yes it is in my list, I meant to say that I do not see it anywhere in URLs used to host user data.

@lightswitch05 I started to experience the issue yesterday and it continued this morning. Every time beacon.dropbox.com was blocked dropbox app disconnected and reconnected after 20” or so. I had Word open with the Dropbox plugin. I’ve closed it and the issue stopped. I have to investigate further.

I opened word again and problem is there again.

I opened a different word document (I created a new one and put it in dropbox).

Every time it tries to connect to beacon.dropbox.com dropbox disconnects for 20-30 segs. It tries to connect every 5-4 mins.

@lightswitch05 there are service providers I'm willing to trust by default.
Github is certainly one of them.
Dropbox is another.

@lightswitch05 there are service providers I'm willing to trust by default. ...

@StevenBlack yeah I think the same. For that reason I was asking why in particular is that sub domain blocked.

@luispuerto thank you for the detailed explanation. A lot of beacon domains are used for tracking, looks like this one is being used for connectivity checking. I’ll remove it as soon as I have time. I’m sorry for my delayed responses, I’ve been having some difficulty with my email provider- not related to hosts blocking 😆

This is fixed in the latest release which is live and online now.
Thanks everybody!
Closing.


Enable CD for digicert-software-trust-gpg-sign-plugin

Link to GitHub repository
[]https://github.com/jenkinsci/digicert-software-trust-gpg-sign-plugin
When modifying release permission
If you are modifying the release permission of your plugin or component, fill out the following checklist:

### Release permission checklist (for submitters)
- [ ] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [ ] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [ ] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)
Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.
Link to the PR enabling CD in your plugin
https://github.com/jenkinsci/digicert-software-trust-gpg-sign-plugin/pull/1
### CD checklist (for submitters)
- [x] I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

#3386 enables CD permission only for https://github.com/jenkinsci/digicert-software-trust-code-sign-plugin
Since this is a different plugin, I created another PR to enable CD for https://github.com/jenkinsci/digicert-software-trust-gpg-sign-plugin

#3386 enables CD permission only for https://github.com/jenkinsci/digicert-software-trust-code-sign-plugin Since this is a different plugin, I created another PR to enable CD for https://github.com/jenkinsci/digicert-software-trust-gpg-sign-plugin

I see, I don't mind one PR enabling CD for multiple components, though.


Keybindings.json - cannot read property length of undefined

Open keybindings.json
Do some modifications -> notice exception in dev tools

TypeError: Cannot read property 'length' of undefined
    at MacLinuxKeyboardMapper._generateResolvedKeybindings (macLinuxKeyboardMapper.js:812)
    at MacLinuxKeyboardMapper.resolveUserBinding (macLinuxKeyboardMapper.js:882)
    at CachedKeyboardMapper.resolveUserBinding (keyboardMapper.js:30)
    at WorkbenchKeybindingService.resolveUserBinding (keybindingService.js:346)
    at KeybindingEditorDecorationsRenderer._getDecorationForEntry (keybindingsEditorContribution.js:180)
    at KeybindingEditorDecorationsRenderer._updateDecorationsNow (keybindingsEditorContribution.js:152)
    at RunOnceScheduler.KeybindingEditorDecorationsRenderer._updateDecorations._register.async_1.RunOnceScheduler [as runner] (keybindingsEditorContribution.js:133)
    at RunOnceScheduler.doRun (async.js:500)
    at RunOnceScheduler.onTimeout (async.js:495)

In case you can not repro, here are the contents of my keybindings.json  at the time of the exception
// Place your key bindings in this file to overwrite the defaults
[

{
    "key": "cmd+t",
    "command": "workbench.action.files.newUntitledFile",
    "when": "watchExpressionsFocused"
},
{
    "key": "cmd+g",
    "command": "workbench.action.tasks.terminate"
},
{
    "command": "workbench.files.action.collapseExplorerFolders",
    "key": ""
}

]

Good catch! Thank you!


Do not notify env sink about base constructor (fixes #3699)

The inner env produced for the base type constructor was preferred in TypeCheckInfo.GetBaseEnvForPos due to having a nested range making parameters from the primary constructor unavailable in the base constructor call and do expressions.
The completion tests code is awfully repeated, should I clean it up in a separate PR or doing it in this PR would be OK?

The completion tests code is awfully repeated, should I clean it up in a separate PR or doing it in this PR would be OK?

Separate PR

@dsyme Is this approach correct in general? I'm concerned if there're other cases where an FSharpSymbol is created with AddFakeNamedValRefToNameEnv that we should prevent.


Fox Page: Use Boardroom API key

Overview
Boardroom API currently doesn't need an API key but will need one at some point: https://docs.boardroom.info/boardroom-api/boardroom-api/api-keys.
Our requests to the Boardroom API to get Governance data will fail as soon as this is a requirement.
@SS-FOX-McCloud  has requested a Boardroom API key and as soon as we have it, we should add it as a parameter to our requests.
References and additional details
https://github.com/shapeshift/web/blob/1ed6c6ff4a587cf5a8f5ee2ac8cb5e039ba1ad3c/src/plugins/foxPage/hooks/getGovernanceData.ts#L46-L48
Acceptance Criteria

The API key should be added in sample/env config
Boardroom API requests should use the provided API key

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Hello,
Thank you for your interest in using the Boardroom API.
Your Boardroom API key is: e98eb1a6fc0902539efed404048623ec
To use the api key include it as a query parameter at the end of your requests.
Example: https://api.boardroom.info/v1/protocols?limit=10&key=your-api-key
If you have any questions you can reach out on discord in our support channel https://discord.com/invite/CEZ8WfuK8s

The Boardroom Team

this has become a wart - we're talking about moving away from boardroom anyway, and the fox page is functioning fine without this


Add missing content to Go API reviews

Primary goal here is to ensure reviews show a module's complete public surface. A secondary goal is to make revisions less noisy; symbol order should now be stable across revisions. New review content includes:

subpackages
user-defined types with simple underlying types: type Foo string
exported variables
fields and parameters having multiple names: type Foo struct { A, B int } and func Frobulate(a, b string)
type parameters

Also, definitions of re-exported types are now hoisted into public packages which re-export them. For example, TokenCredential is defined in azcore/internal/shared, which isn't part of the module's public API, but it's then exported from azcore with an alias. With this PR, APIView will show the type's definition in azcore.
Closes #2615, closes #2640, closes #2969, closes #3045

/check-enforcer override


Reimplement bump command for advanced users

As an advanced user of dodgem
I would like to use dodgem without user input
So that I can trigger dodgem via .bat file

Suggested solution is to reimplement the bump command with target and interval arguments, which was removed in favour of new user friendly, wizard driven start command.
Bringing back the bump command as an additional command for more advanced users, whilst keeping the new start command for less advanced users seems like a good solution.

Any news?

I haven't had time to work on dodgem recently, this will be the first issue I resolve when I do.
In the meantime, I'm open to pull requests if someone else wants to pick this up.

@Carje4cs sorry for the wait, but I've just pushed v0.4.0 which reimplements this feature 🎉

Great, thanks for that!


atom_feed() sets wrong update timestamp for the feed with :preserve_order => true

atom_feed tries to set the <updated></updated> element for the whole atom feed to the <published></published> date of the youngest feed element, relying on the feed list being sorted descending by date. This assumption may fail when :preserve_order is set to true.
Steps to reproduce

The <updated></updated> element is set on line 112 of lib/nanoc/helpers/blogging.rb:

xml.updated(attribute_to_time(last_article[:created_at]).__nanoc_to_iso8601_time)

last_article is set on line 71-73 to the first element of the feed (after sorting the relevant articles):

def last_article
    sorted_relevant_articles.first
end

That works fine in the default case where all articles are sorted by their publishing date descending, as the youngest article will always be the first one.
But that is not necessarily the case when :preserve_order is set to true. The articles may e.g. be sorted ascending by date, so the first article is the oldest. In this case the feed may contain elements published e.g. at 2016-11-01 and 2016-12-01, but the feed itself will have its latest update wrongly set to 2016-11-01.
See sorted_relevant_articles on line 61-69.

Expected behavior
The <updated></updated> element of the feed should not be older than the publishing date of the newest feed element.
It could even reflect the latest update time of any feed element, not just the publication time.
Actual behavior
The <updated></updated> element of the feed will be set to the publication date of the first feed element, whether that may be the newest, oldest or any other element.

Ah, I see it's documented:

:preserve_order (Boolean)
Whether or not the ordering of the list of articles should be preserved. If false or unspecified, the articles will be sorted by created_at. If true, the list of articles will be used as-is, and is assumed to end with the most recent article.

Anyway, it would be nice if that restriction could be lifted.

Fixed in #1014.


Fix 1.7 istioctl

The translateConfig files had a   at the end, so they were not
properly recognized
$ ./istioctl manifest apply
This will install the default Istio profile into the cluster. Proceed? (y/N) y
Error: failed to apply manifests: error creating values.yaml translator: could not read translate configs: Asset translateConfig/reverseTranslateConfig-1.7.yaml not found

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
3599404529ef9724ca9bc69313a96c5b8443dd62
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
3599404529ef9724ca9bc69313a96c5b8443dd62
link
/test gencheck_istio

unit-tests_istio
3599404529ef9724ca9bc69313a96c5b8443dd62
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Small RISC-V spike demo improvements

Small RISC-V spike demo improvements
Description

Put XLEN into .o files. This makes it easier to work on RV32 and RV64 binaries side-by-side.
Let the debugger disable HTIF use by making its use conditional on a global volatile int.
Makefile now links the binary at BASE_ADDRESS. I need this so I can easily generate the appropriate binaries for riscv-tests/debug. Unfortunately there doesn't seem to be any good mechanism to externally define values for lds files, so I'm running it through the C preprocessor.

Test Steps
Tested RV32 and RV64 against spike as part of riscv-tests/debug. (Those changes have not yet been submitted.)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks for responding so quickly!


License

I want to give you credit for this, are you OK with releasing it as BSD 3 clause. Using it here for an embedded environment without stl: https://github.com/PX4/Firmware/pull/6045

Hi James,
Of course, thanks for giving a heads up. I've updated the license of the repository to be under Apache 2.0 license, which I hope is permissive enough. If it doesn't work, please let me know.

Awesome, thanks!


Bug: Wraping  tag with  breaks slider

For example:
<slide>
    Link
</slide>
<slide>
    Link
</slide>

If you click and drag, as soon as you let off, it activates the link. I would think the expected result would be if the slide was initiated, the  would cease to function.

Hey @tetshi, haven't seen this happen before, and am currently using the slide as pictures above in production. Do you mind sending a jsfiddle or a link to this happening live somewhere? Will be easier to debug from there

<carousel :per-page="1">
     @foreach($featuredArticles as $a)
          <slide>
               id}}">

thumbnail)}}');">
                         {{$a->title}}

         </slide>
     @endforeach
</carousel>

Now this is being done in Laravel, but the end-markup is the same. For whatever reason though, if I click and drag and left off over the same slide, it'll activate the link.

Hi guys, I have the same problem. Do you have any idea how to solve it, even with some hack?

I have the exact same probleme with an <img tag. As soon as you click on the slider, the image appears. But at the beginning, there is nothing to see.

Hey @tetshi , have you tried to preventDefault when clicked on ? Though it's still going to fail in mobile devices.
I think maybe issue #174 is related to this issue. We're working on this problem.

@stop2stare I did not try that, no. I don't mind the console warns temporarily, and I'm pumped you guys were able to figure out the issue. Thanks for the update. I'll try the preventDefault for now. Thanks!

@tetshi Haha, don't be in such a hurry. I've pushed a PR which is going to solve this problem. Maybe the maintainers will release a new version. Just wait a day.😄

Just released now!

The current version has not been resolved, need fix please

Hey @matamune94 this was resolved quite a while ago, what version of the carousel are you using?

final version sir

@quinnlangille Im use nuxtjs with vuetify and vue-carousel .

@matamune94 final version meaning 0.18.0-aplha?

@quinnlangille i use npm install maybe is true ?

@quinnlangille
https://www.jsdelivr.com/package/npm/vue-carousel
I think is last version

this my https://jsfiddle.net/matamune94/okbj871y/6/ when u click on numbers on sides and drag. it will have bropblem

check please

Hey @matamune94, I'm not able to recreate using the jsFiddle you sent above. Perhaps its a browser setting or something else on your end causing the issue?

Hey @matamune94, I'm not able to recreate using the jsFiddle you sent above. Perhaps its a browser setting or something else on your end causing the issue?

If I actually click the link the redirect to google happens, but that seems expected to me. Lemme know if I'm missing something

i said you click on numbers not slide sir

@quinnlangille https://jsfiddle.net/matamune94/okbj871y/26/ , im fixed example , please try again

This is still working exactly as I would expect, no different from my video posted above. If I explicitly click on the slide, it opens the link, otherwise the dragging works as expected.

This is still working exactly as I would expect, no different from my video posted above. If I explicitly click on the slide, it opens the link, otherwise the dragging works as expected.

tôi đã thử trên nhiều máy tính khác nhau và nó có cùng vấn đề như vậy , you should consider this issue carefully. I really like this carousel

This is still working exactly as I would expect, no different from my video posted above. If I explicitly click on the slide, it opens the link, otherwise the dragging works as expected.

I tried on many different computers but it had the same problem that I gave, You should thoroughly examine this issue sir, I really like it

Sorry @matamune94 but we are not able to do anything about an issue that we cannot reproduce. I'm going to close this issue now, as from what I can tell this issue has been resolved since 0.7.1, as stated above.

Hi. I am running into the same issue as the OP.
I was able to reproduce the issue on @matamune94 's example (https://jsfiddle.net/matamune94/okbj871y/26/), on Windows 10, Chrome 75.0.3770.142, Firefox 68.0 and Microsoft Edge 44.18362.1.0 (Microsoft EdgeHTML 18.18362).
When releasing the mouse button from drag the link will be opened.

Hello,
I am have the same issue currently. I tried to reproduce it as good as possible in this CodePen:
https://codepen.io/dervondenbergen/pen/d1669fa528de1438c9990db79a6b1f55
When releasing the mouse, the link or button gets triggered. When releasing the mouse outside of the view or on another element, it won't get triggered.

I am running<EMAIL_ADDRESS>on Ubuntu 18.04.3 in Firefox 69.0.1 (64-Bit)

Still relevant

Still happens. If you drag the mouse outside of the carousel it doesn't seem to trigger. Latest Chrome and carousel.

Any solutions ?


Can't run autoconf

autoconf throws some errors on my ubuntu box:
configure.ac:15: error: possibly undefined macro: AC_ENABLE_SHARED
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure.ac:16: error: possibly undefined macro: AC_ENABLE_STATIC

I ran autoreconf --force --install
Then I got: configure: error: cannot find the flags to link with Boost filesystem
So I installed libboost-all-dev
Now it's ok.