KW41Z crash on echo apps (ieee802154)

KW41Z with Echo Server|Client hard faults
To Reproduce
Just flash a kw41z with echo-server or client @ master zephyr and look at console
cmake -GNinja  -DBOARD=frdm_kw41z -DCONF_FILE="boards/frdm_kw41z.conf prj.conf" ../
cp zephyr/zephyr.bin /media//FRDM-KW41ZJ/
Expected behavior
Should work out of the box.
Impact
Showstopper to test 802154 between devices on KW41Z
Toolschain
SDK 0.9.5 and 7.3.1
master

cc @MaureenHelm

cc @dleach02
@ekarlso, it always makes sense to include the exact HEAD revision of the master you used.

Just flash a kw41z with echo-server or client @ master zephyr and look at console

And people will start with looking at this bug, and it doesn't provide enough info on what happens...

@pfalcon because this not more info that what he says in the beginning "hard faults". Directly. I tried and there is nothing but the hard fault.

@pfalcon basically what @tbursztyka says, it goes nuclear and faults (Nothing really useful in the console)

@mnkp @chrta Do we have a overview of what MCU's support DCDC?

Thanks @MaureenHelm for looking into this. This is indeed a surprising issue since all attributes in this struct are all pointers thus 4 bytes each so I would have assumed linker would not have much to do here for alignment.

I'm not sure this is the right fix though. @SebastianBoe, could some of the recent build system and linker changes have caused this?

I'm not aware of any changes that can affect this. A git bisect from someone with a KW417 (or any M0 board with enough RAM) would be helpful.

I may have found the root cause. As we know any variable or constant of type struct ieee802154_radio_api may be placed at an unaligned memory address (even if all the members are aligned at 4 bytes).
When we access the API via the predefined inline functions
static inline int ieee802154_set_tx_power(struct net_if *iface, s16_t dbm)
{
        const struct ieee802154_radio_api *radio =
                net_if_get_device(iface)->driver_api;

        return radio->set_txpower(net_if_get_device(iface), dbm);
}

the access will be slow but should work. However that does not hold true for the first field struct net_if_api iface_api;. As the comment suggests
	 * Mandatory to get in first position.
	 * A network device should indeed provide a pointer on such
	 * net_if_api structure. So we make current structure pointer
	 * that can be casted to a net_if_api structure pointer.
	struct net_if_api iface_api;

the iface_api is accessed directly by the networking code and ultimately the __packed is 'casted away'. I didn't track down the exact place where it happens though.
As far as I can tell the __packed for struct ieee802154_radio_api is not required. We could simply remove it.

while I agree that the structure definition doesn't need the __packed directive I don't quite understand how its presence affects the alignment of instances of this structure? Is this because the __packed directive causes GCC to believe the natural alignment of the structure is 1 byte aligned?
The __packed directive has been on this structure for a long time so why is this just now showing up?

The __packed directive has been on this structure for a long time so why is this just now showing up?

Source code stays, compilers come and go, acquiring crazier and crazier features...

__packed is indeed useless here (probably a c/p left over when I started this api... hum). That said, the new behaviour is indeed suspicious, well I am going to send a patch removing this. Thanks @MaureenHelm and @mnkp for looking at this.

My fear is that we don't really know what is causing this alignment problem and taking __packed off doesn't really explain why it fixes the problem. The result is that this problem may crop up someplace else..

I for one 100% sure that it's caused by __packed and 100% sure that it was the right fix (in general, there should be no __packed on any structure which contains a pointer).

I understand. Just not sure why this just now popped up. Maybe this is a new compiler vs old compiler.
My understanding of packed structure is to pack the contents of the structure but this setting seemed to carry to the alignment of the whole structure which seems problematic. I did see a long running bug in the gcc bug database about packed and bus faults with unaligned access but it wasn't directly because the base structure was put on an unaligned address.

We didn't remove __packed because we noticed that it solved the issue but because it shouldn't be there in the first place. There is no use for this __packed, also as @pfalcon mentioned 'in general, there should be no __packed on any structure which contains a pointer'. The redundant attribute was overlooked during the code review.
With __packed not only structure fields but also the structure itself can be unaligned. Looking at the map file of 'echo_server' sample application compiled for frdm_kw41z board we have
 .data.kw41z_radio_api
                0x000000002000ad59       0x28 zephyr/libzephyr.a(ieee802154_kw41z.c.obj)

so kw41z_radio_api variable holding struct ieee802154_radio_api is at unaligned address.
If the initial check-in happened to place kw41z_radio_api variable after some other which size was multiple of 4 it would take a very specific, random modification of code to have linker shuffle variable locations and place kw41z_radio_api at an unaligned address. This bug could have gone unnoticed for a long time despite multiple code changes.
The observed hard fault might have been caused by the gcc bug as @dleach02 suggested but most likely it happened when networking stack was trying to access iface_api field. Most of the accesses to the struct ieee802154_radio_api are done in a safe way via API wrapper functions with the exception of struct net_if_api iface_api field which is accessed directly by the networking stack in a way that assumes an aligned address. E.g. here:
subsys/net/ip/net_if.c:	const struct net_if_api *api = net_if_get_device(iface)->driver_api;

Only a person having the board could verify it for sure though, I reckon, there is no need to dig into this issue any further.

Fair enough. I've just never seen the packed modifier affect the alignment of the variable. Just the internal fields of the structure.


Added handling of the .play() promise errors to native_hls player

I was still getting 'Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause().' errors when playing HLS streams with the native_hls renderer.
I looked through the source and saw that this was being handled for the native_dash renderer in /src/js/core/mediaelement.js, so I included a simple change to add the handling for native_hls renderer as well.
This has removed those errors for me and playback seems to work fine.
Long-term, this will all likely be solved by the feature-request from issue #2414 which will allow the promise to be returned to the user for proper handling. But for now, this appears to eliminate these errors.
One issue is that I didn't build the final JS files (e.g. /build/mediaelement-and-player.js) so in my pull request those files don't reflect the code changes. I wasn't sure how you build those files, so I just made the change manually in my local copy :-)
If you merge this PR, you'll need to build the final files yourself, or if you can tell me how to do that, I'll be happy to do so and submit a new PR.
Anyway, please let me know if there are any problems with this PR. Thanks for all your work on an awesome piece of software! :-)

Coverage remained the same at 74.487% when pulling 56c87c2d84676420dfcecfdff585df5a7eb87f09 on hashcutdev:master into 6d665634da067ac075cd49631e646c7b16f25510 on mediaelement:master.

@hascutdev: Thank you so much for this PR . Sorry for the delay, the project has been sleepy for some month. I took over the maintenance part of it.
Merging to master branch right now, and asking for feedback before release 4.2.11

@hashdev: by the way, build/ should not be included in the PR, cause indeed, we rebuilt it when publishing a new release. May I ask you to remove it from the PR ? I'll see if I can remove it myself, but I doubt it.

Ok just added commit to master via git command line
commit 04b48c60ed468e758879c49bb0e07fedf8198afb
Author: Murali Raju<EMAIL_ADDRESS>Date:   Wed May 23 17:10:53 2018 +0000
Added handling of the .play() promise errors to native_hls player


⚠ ClamAV has degraded performance

In f9af0d6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 78 ms

Resolved: ClamAV performance has improved in d386a9f.


Possible to unlock more graphic settings?

I realize the tool's main focus may be visual mods, but just in case, is it possible by unpacking everything, to reveal more graphics settings not available by default?
Settings like, Shadow, Post-Process, Ambient Occlusion, View Distance, AA to name a few. I'm also keen to make visual mods, so if there's anyway I/we can contribute, please do let us know. I saw the filelist.txt and used v0.1.0 to list the files but it's all a blur atm.

I wouldn't know personally as I have yet to get the actual game; only have the necessary files to understand the whole archive that were provided to me.
The current file list should contain most core/critical files considering they were dumped at runtime by somebody else.
If I had to guess, maybe somewhere in the system folder?


Add way to convert vanilla nether and end portals

I was doing this in the style of your todos, but it's quite impolite. I would understand if this feature wasn't interesting to you.

I am going to make a system to convert vanilla and all other mod's portals automatically

The automatic conversion feature is already implemented. https://github.com/qouteall/ImmersivePortalsMod/wiki/Datapack-Based-Custom-Portal-Generation#convert_vanilla_nether_portaljson-convent-vanilla-nether-portals-into-see-through-portals-if-the-shapes-are-compatible
However, that does not support converting end portals. Automatic end portal conversion is not being planned.

The automatic conversion feature is already implemented. https://github.com/qouteall/ImmersivePortalsMod/wiki/Datapack-Based-Custom-Portal-Generation#convert_vanilla_nether_portaljson-convent-vanilla-nether-portals-into-see-through-portals-if-the-shapes-are-compatible
However, that does not support converting end portals. Automatic end portal conversion is not being planned.

Hi qouteall, sorry to necro this old issue but I was curious as to the reasoning behind not supporting end portal conversion? It would certainly be helpful for mods like End Remastered that add their own end portal.

You can use imm_ptl:one_way, see https://qouteall.fun/immptl/wiki/Datapack-Based-Custom-Portal-Generation#other-examples

@qouteall I appreciate this but I'm not sure I can.

The new portal is made out of multiple different blocks.
Each block needs to be filled with a different item.

I'm not sure if the parameters present allow for me to check for that.

@Brittank88  Unfortunately the custom portal system does not allow that.

I'm just surprised there's no way to tell IP to check if there are actual portal blocks at the location where somebody was, right before they changed dimensions, and then just replace them.

Apologies, that came off a bit rude. I appreciate features take time - it was a genuine expression of surprise, not an expectation that it exists. This mod is lovely regardless.


Implement batching with optimized preprocessing

Currently very memory intensive to use numba or cupy preprocessor

Preprocessing has been updated and is now much faster in V1 than in V0


is it possible to set the toolchain version?

Problem Description
I saw that it is possible to only run a task conditionally on the toolchain.
Is it possible to set/pin the toolchain? e.g. with an ENV or something?

initial commit pushed to 0.15.2 to support toolchain selection in task level.
you can see the draft docs
if you can give it a try and provide feedback, it would be really helpful.
right now toolchain support is only for command in crate/rustup component installations but not for scripts or install_scripts as I prefer people to use the more structure way to invoking rust related commands.

hi, i'm using nixos atm rather than cargo-make, but sounds good :D

pushed to master and will be officially released today


Update ref-arch BOMs with title and description

[ ] 160
[ ] 165
[ ] 170

I'm inclined not to make this change because of #114. We are planning to delete the files in ref-arch/ because they are duplicates of the content in the automation-solutions. @NoeSamaille Can you make sure these changes are applied to these BOMS there?

@seansund sure it should be there in automation-solutions I'll double check

done


Uploading image: unknown error occurred

Yesterday I edited some pages on my BookStack setup, even uploaded an image as a "cover image" for a "book". Everything ran smoothly.
Then I noticed that I was running BookStack version 0.30.7, which has been succeeded by a number of updates since I installed that one, so I updated to v21.04.
Even updated the underlying Apache and PHP packages while I was at it. Now running Apache 2.4.46 and PHP 7.4.16.
Today, I logged in again, added and edited some pages again. Everything seemed to work fine still.
Until I tried to upload an image as a "cover image" for another "book". It responded with:
"An unknown error occurred".
In the system logs I can find little more than "... POST /bookstack/books/<booktitle> HTTP/1.0" 500 12374", which is listed in the Apache access log.
I've tried again with a smaller image file, another file format (jpg vs png) and even the very same file that upladed nicely the day before, but all to no avail.
Any ideas what might be broken or where I should start digging to get more details out of my system?
Thanks for any pointers!
Cheers,

Hi @cautiouscoyote,
You can get more details via the methods described here, most notably the log file:
https://www.bookstackapp.com/docs/admin/debugging/
The first thing to check would be that your .env file has an APP_URL set that exactly matches the top-level base URL that you're intending to access BookStack on.

Hi @ssddanbrown! Thanks for the quick reply.
First I verified the APP_URL setting, as you pointed out, but surely there's nothing wrong with that: I can access my BookStack setup just like before the upgrade to v21.04, can edit pages and what not. So I wouldn't expect anything broken there.
However, you pointing me at the debugging setting in the .env file put me on track for the laravel.log (I've seen it before, but totally forgot that THAT is the actual BookStack log file).
Anyway, even without setting APP_DEBUG=true, I looked at that log file just as it is, and indeed it shows some clear errors, which I can reproduce when uploading a file and watching the log file live. It immediately - and only - dumps this error:

production.ERROR: Method Illuminate\Validation\Validator::validateImageExtension does not exist. {"userId":1,"exception":"[object] (BadMethodCallException(code: 0): Method Illuminate\Validation\Validator::validateImageExtension does not exist. at /opt/local/share/httpd/htdocs/BookStack/vendor/laravel/framework/src/Illuminate/Validation/Validator.php:1308)

Followed by 52 lines of stacktrace which I deem unnecessary to dump here now.
Armed with that new info, I googled again and found this rather short dialogue:
https://www.gitmemory.com/issue/BookStackApp/BookStack/2458/755727903
Before, I couldn't find any similar reported issues, at least not within this github issues collection. But apparently you have been supporting on different discussion platforms as well ;-)
The questions now are, I think:

what package do I need to add, to get that "Image Extension" in place?
why is it suddenly missing while it worked fine - and thus, I suppose, the package was there - before I upgraded BookStack to v21.04?

To give you maybe a little context as to the first question: I'm running OmniOSce (https://www.omniosce.org), a Solaris descendant, where I use the pkgsrc-repository (https://pkgsrc.joyent.com) to provide Apache, PHP and such.
Right now, I have the following PHP 7.4 packages installed to support the BookStack installation:
$ pkgin search php74 | grep =
ap24-php74-7.4.16nb5 = Apache (apache24) module for PHP7.4
php74-bcmath-7.4.16 = PHP extension for bc-style arbitrary precision math
php74-composer-2.0.12 = Dependency Manager for PHP
php74-curl-7.4.16nb9 = PHP extension for curl functions
php74-fpm-7.4.16nb5 = FPM interface for PHP7.4
php74-gd-7.4.16nb1 = PHP extension for GD graphics library
php74-intl-7.4.16nb5 = PHP extension for i18n
php74-json-7.4.16 =  PHP extension for JSON serialization support
php74-ldap-7.4.16nb1 = PHP extension for LDAP database access
php74-mbstring-7.4.16 = PHP extension for multibyte characters support
php74-mysqli-7.4.16 = PHP5 extension for MySQL 4.1 and later databases
php74-opcache-7.4.16 = PHP extension for opcode caching
php74-pdo-7.4.16 =   PHP extension for PHP Data Objects (base)
php74-pdo_mysql-7.4.16 = PHP extension for PHP Data Objects (MySQL)
php74-pear-1.10.12nb3 = PEAR Base System for PHP
php74-pecl-mcrypt-1.0.4 = Bindings for the libmcrypt library
php74-soap-7.4.16nb2 = PHP extension for SOAP functions
php74-tidy-7.4.16 =  PHP extension for tidy functions
php74-xmlrpc-7.4.16nb2 = PHP extension for XML-RPC support
php74-xsl-7.4.16nb2 = PHP extension for XSLT functions
php74-zip-7.4.16nb4 = PHP extension for ZIP archive handling
=: package is installed and up-to-date
I must admit that, when looking a the package requirements for BookStack ("Required Extensions: OpenSSL, PDO, MBstring, Tokenizer, GD, MySQL, SimpleXML & DOM"), there are some that I have a hard time finding in the available packages on pkgsrc (e.g. OpenSSL, Tokenizer, SimpleXML, DOM), but again: uploading an image worked before! So even if some PHP-extensions are missing, the setup has proven that it could digest an image file.

Hi @cautiouscoyote,
Did you have any errors when running the composer install --no-dev step of the update?
The error you're getting generally reflects that some files are out of date or not found. It's either the composer install --no-dev step is not working as expected or the service files are cached. If no errors on the above, you can try the following:
Beware, I'm not familiar with OmniOSce/Solaris at all, so backup and run at your own risk.
# Go to your BookStack install dir
cd my_bookstack_install_dir

# Delete any system cached service files
rm ./bootstrap/cache/*.php

# Double check there's no files in the bootstrap/cache folder within your BookStack install
ls -l ./bootstrap/cache/ | grep php

Hi there again, @ssddanbrown,
It looks like you nailed it. No, there were no errors during the composer install --no-dev step, but I just looked at the ../bootstrap/cache/ directory like you suggested, and there were three *.php files:
config.php
packages.php
services.php
I moved all three out of there, rebooted the BookStack zone (that's Solaris terminology for what is roughly comparable to a container or light VM) for a proper test, logged in again and at least at that point in time everything looked OK: at least the system was not broken due to moving the php files out of the cache.
Then I tried uploading the same cover image onto the exact same page again and behold: it popped in place nicely!
I then looked at the cache folder again and it now holds only two *.php files:
packages.php
services.php
So apparently, the cached config.php file had been screwing up the updated system.
Also, I do understand that I'm somewhat on my own with this OmniOSce-system, but since BookStack uses dependencies that are rather widely available, while in this case via the OS-independent pkgsrc repo, I figured I should be able to run it natively and not need a full-blown Linux VM on top of it. And up until now at least, that works fine indeed. This hiccup could happen on any platform, I suppose.
Thanks a bunch for sorting this out so quickly!
Cheers!

Thanks for confirming that got things going @cautiouscoyote, Glad to hear it's now working. Will therefore close this off.

Also, I do understand that I'm somewhat on my own with this OmniOSce-system, but since BookStack uses dependencies that are rather widely available, while in this case via the OS-independent pkgsrc repo, I figured I should be able to run it natively and not need a full-blown Linux VM on top of it. And up until now at least, that works fine indeed. This hiccup could happen on any platform, I suppose.

Yeah, That's true. From my perspective I like to keep BookStack fairly operating system abstract, I just won't be able to offer a good level of support for any systems I don't have access to or are not familiar with.


The /docs merge creates empty commits

I'm closing this. I've had some head scratching moments about this, and even if I could probably fix the history for these empty commits for the 0.123.0 release, I notice that the problem is older. I'm going to fix it upstream and leave the history as is. This repo has a rather long and ugly Git history even without these, I guess, so I suggest that when we finally get to the v2 of the hugoDocs, we should start over in a new repo.
https://github.com/gohugoio/hugo/issues/12430

OK, I closed wrong issue ... reopen this.


Alert user when the action could lead to the restart of the notebooks

Description

Closes #847
How Has This Been Tested?

Check the following page/modals:

Editing workbench
Add/Edit storage modal
Add/Edit data connections modal

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Waiting for final reviews from the UX for the wording in the alert.

@andrewballantyne I agree. If we have the ability to only show the alert when it is actually going to be in effect, it will give it more impact, and also allow users to make a better informed choice about how to proceed.

/retest


[QUESTION] Custom Content - Adding more material

What is the context of your question?

[ ] Installation
[ ] Administration
[X] Custom Content
[ ] M365 learning pathways web part

What is your question?
I'm looking to install in a set of curated playlists and asset, still based on the Microsoft support material, as you have done for the pre-installed curated content. Ideally, i am starting to deploy to clients where id like to focus the content on activities relevant to them.
For example, i have a list of content about the modern editing experience with SharePoint Online, so wanted to create a playlist and select the support articles based on that subject. Ideally, i would like to install these by script (i'm quite familiar with PnP PowerShell) rather than manual, to make this reproducible and repeatable.
From what i understand of the solution the JSONData column contains all the metadata for CustomAssets and CustomPlaylists, just needs to have these items added/correctly configured in order to include them?
Is that the best way of doing it? Or do you have any guidance around this? Or any details around the schema info for the JSONData column?

So if I understand you correctly you want to create the custom playlists and/or custom assets by PowerShell so that anyone that runs the PowerShell would have those playlists and assets added to their implementation of learning pathways? If that's what you're saying then yes, you can use PowerShell to do this, however each of the "support articles" you link to must be custom assets unless they're already included in the assets.json file.  If they're not you're going to need to make sure you add the query string parameters so that they appropriately iFrame themselves and then also make sure that you capture the IDs of the assets as you add them so you can update the JSON payload of your playlist.  It's not impossible to do but there's work there.  As far as the structure there is documentation now in the partner section: https://docs.microsoft.com/en-us/office365/customlearning/custom_partnerguide_contint

This is perfect, thank you!

@pkbullock  -- is there a reason you reopened this?

Hi @juliemturner,
Sorry, went into impromptu meeting...
https://docs.microsoft.com/en-us/office365/customlearning/custom_partnerguide_contint
I've been reviewing the docs and its not straight forward to get he associated GUIDs for the associated categories e.g.

AudienceId
TechnologyId
SubjectId
etc

Just wondering if this could be added to the docs or are they likely to change often?
I wrote a quick PS script to list these out which i could add to blog or share. Just thinking of making the process easier for the next person.

I'm not sure I follow you on what you mean by it's not straight forward to get the associated GUIDs, they're plain text in the metadata.json file... you can get them by either going to the github repo or by looking at the network tab when the file is downloaded while using the admin web part. I'm not sure why you'd need PowerShell.  Maybe I'm not understanding the issue?

I think its just me just not connecting the dots and not applying enough thought into how this hangs together and reading through more carefully the manifest.json.
I have however, managed to get the content pack setup and hooked into my fork and pulling into my  tenant now 😊. I will close this as i have managed to achieve what i was after. Thank you for coming back to me, sorry for the scatty responses.


Improvement - Typing @in the group DM should suggest only the members of the group at the top

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.55-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710878688977429
Action Performed:

Open any group chat
Type @ to mention
Look at the suggestion list

Expected Result:
Should suggest the group DM members at the top then unrelevant users
Actual Result:
Shows unrelevant users
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/2f0899e7-0519-4d93-9e55-f5cb85090b34

View all open jobs on GitHub

We have an issue for rooms too https://github.com/Expensify/App/issues/24436

@mallenexpensify should we close this one and focus on https://github.com/Expensify/App/issues/24436?

I don't think so, I'll take this over as BZ.  I'm unsure what the next best steps are right now.

Added to #vip-vsb because the feature request doesn't involve money

Going to wait on status and we might want to deal with this more holistically

Checking on here

Unsure of status, no action on the post in #expensify-bugs from two weeks ago

Not an immediate priority

I think Search is getting addressed so this might be rolled into that?

Gonna close cuz we just paused all features, will reopen if/when needed.


Configurable Resources in Dapr Control Plane Deployment

Is there a way to adjust the manager.yaml deployment for the control plane component such that we can manage the resources? The current configuration is causing us issues and we are currently forcing the resources by quickly modifying the deployment spec after it's deployed. Based on usage, this pod is continually going into OOMKilled state unless we do these changes. IT would be fantastic if we could provide the resource configuration in the COntrol Plane spec.
Here is where the resources are currently being set:
https://github.com/dapr-sandbox/dapr-kubernetes-operator/blob/4c252bd773f8221365b606c749cdf4704729a742/config/manager/manager.yaml#L98

an option is to tweak the subscription to let OLm alter some parameter of the deployed pods https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/subscription-config.md

Thanks. I will look into this OLM and see if I can adjust the pod to increase the resources. The only way I can think to replicate it is to deploy a bunch of pods that utilize the operator including adding things like components and HTTPEndpoints. Once the issue occurs, you will notice that the dapr sidecar goes into a crashloop and when you look at the logs you can see that the pod was not able to communicate with the control plane and states that it's shutting down. WHen we looked at the operator, we found it running out of memory causing it to be killed.
Do you have an example by chance of how to use OLM to modify the control plane pod by chance?

but it looks like what crashes is not the dapr-kubernetes-operator but one of the deployed pods, can you post what actually is crashing ?

Under the hood,  the dapr-kubernetes-operator deploys a dapr instance using the regular dapr helm chart so you will end up with the following pods:
➜ kubectl get pods
NAME                                     READY   STATUS    RESTARTS      AGE
dapr-operator-699595bbdd-tcmph           1/1     Running   1 (58s ago)   79s
dapr-placement-server-0                  1/1     Running   2 (67s ago)   79s
dapr-sentry-5956f7cd98-z8p58             1/1     Running   0             79s
dapr-sidecar-injector-6fdfb49dfc-xmsfw   1/1     Running   0             79s

If the pods that crashes is the dapr-operator(or any of those listed above), then you can tweak the related resources using helm values, as described in the dapr helm chart readme: https://github.com/dapr/dapr/blob/master/charts/dapr/README.md#resource-configuration
So if you want to change the dapr-operator memory configuration, then you can apply a resource like:
apiVersion: operator.dapr.io/v1alpha1
kind: DaprControlPlane
metadata:
  name: "dapr-control-plane"
  namespace: "dapr-system"
spec:
  # This object provides access to values passed into the Dapr Helm chart
  # https://github.com/dapr/dapr/blob/master/charts/dapr/README.md
  values:
    dapr_operator:
      resources:
        requests:
          memory: 200Mi

Yah that's what we tried however in this case it's the dapr control plane pod that's crashing as it runs out of resources. From what I can tell it's hardcoded along and deployed using kustomize as shown here: https://github.com/dapr-sandbox/dapr-kubernetes-operator/blob/4c252bd773f8221365b606c749cdf4704729a742/config/manager/manager.yaml#L98. If this can be modified via OLM though then we just need to figure out how to setup the subscription to do this modification. :)

can you please confirm what pod is crashing ?

I have done some further investigation into the issue with our team and confirmed now that it is in fact dapr-operator that is crashing with OOMKilled. We will leverage the dapr-control-plane to modify the resources assigned to this operator going forward. Thank you for your assistance!


login when company uses third party

My company requires me to log into azure by means of okta. In other words, azure portal opens okta and then we return to azure portal.
When following the instructions for az login, I got errors at the browser level. I decided it couldn't launch okta. Not sure of this.
So I entered portal.azure.com, logged in, then did az login at the command line and got success.
Perhaps a suggestion should be added to the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1c268a98-afcb-d2c2-87c7-880d52900533
Version Independent ID: 4c835da4-38bc-22a8-67b4-dd522adcc0e3
Content: Get started with Azure CLI
Content Source: docs-ref-conceptual/get-started-with-azure-cli.md
Service: azure-cli
GitHub Login: @dbradish-microsoft
Microsoft Alias: dbradish

@edgreenberg Thank you for bringing this to our attention!  We'll look into this and get back to you shortly.

@edgreenberg It looks like Okta uses the same command in their documentation with a reference to this page:
https://help.okta.com/oag/en-us/Content/Topics/Access-Gateway/deploy-msa-cli.htm

There's also another reference on their developer blog:
https://developer.okta.com/blog/2020/09/02/10x-development-azure-cli-dotnet
It's possible the error you are encountering is related to how Okta has been configured for your environment.

In my case, I believe I am squared away since I can just log into portal
via okta before using CLI commands.
I think that will work for me.
I was reporting this more so you could consider putting some sort of
warning in the documentation for others who use third party authentication.
Thanks for your attention.
On Tue, Aug 3, 2021, 21:01 kobulloc-MSFT @.***> wrote:

@edgreenberg https://github.com/edgreenberg It looks like Okta uses the
same command in their documentation with a reference to this page:
https://help.okta.com/oag/en-us/Content/Topics/Access-Gateway/deploy-msa-cli.htm
[image: image]
https://user-images.githubusercontent.com/37556655/128105190-af4aa41c-79d6-4588-b162-3e849563d9c8.png
There's also another reference on their developer blog:
https://developer.okta.com/blog/2020/09/02/10x-development-azure-cli-dotnet
It's possible the error you are encountering is related to how Okta has
been configured for your environment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs-cli/issues/2679#issuecomment-892277276,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABE637SN3MQ3LQFJ7DBZYTT3CGN5ANCNFSM5BPLMVFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@edgreenberg Good to hear!  Third party documentation is a bit tricky because there are extra criteria for verification and it's easier for information to become outdated (making it less frequent as a result).  This thread is viewable for all readers of the documentation, however, and serves as a great resource for others who may run into this issue.  Thank you for helping to improve the docs!

@edgreenberg Thank you again for helping to improve the docs.  We are going to close this thread as resolved but if there are any further questions or comments regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Channel Delays

Another feature request 🙈
Would it be possible to add the delay setting plus a variable?
We sometimes run into unfortunate lipsync issues, due to our wireless mics and admittedly cheap equipment, which we need to fix during a stream.
So having a delay +XXms and delay -XXms button would make it easier for us to fix this on the fly

Added an issue in the connection lib which has to support this first: https://github.com/fmalcher/soundcraft-ui/issues/64

The connection library supports channel delays in the next release.


Envoy should bind in IPv4/v6

Hi,
I'm trying Contour (and envoy too) in my Kubernetes cluster, but I'm not able to make it work due of Envoy that bind in IPv4 only in the pod.
It would be awesome if all services can bind in IPv6 too, by default ?
/ # netstat -lptn
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:8000          <IP_ADDRESS>:*               LISTEN      -
tcp        0      0 <IP_ADDRESS>:8001          <IP_ADDRESS>:*               LISTEN      -
tcp        0      0 <IP_ADDRESS>:9001          <IP_ADDRESS>:*               LISTEN      1/envoy
tcp        0      0 <IP_ADDRESS>:8080            <IP_ADDRESS>:*               LISTEN      1/envoy

By looking the code, it seem that it need a small change in internal/contour/json.go (l147) :
		Listeners: []envoy.Listener{{
			Name:    "ingress_http",
-			Address: "tcp://<IP_ADDRESS>:8080", // TODO(dfc) should come from pod.hostIP
+			Address: "tcp://[::]:8080", // TODO(dfc) should come from pod.hostIP

			Filters: []envoy.Filter{

What do you think about that ?

Good point. This should really be configurable from the command line.

Bumping to 0.3

Thanks Dave.


return an error when Envoy fails to start

test setup errors can be obscured otherwise.
mixer and backend should also do this, but that involves slightly more
work. added TODOs for those.

/ok-to-test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: nmittler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: costinm, qiwzhang
Assign the PR to them by writing /assign @costinm @qiwzhang in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/test/client/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@utako: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
cc7f42988a0a642fd817d0efbbbb309eb6cce2df
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@utako: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
cc7f42988a0a642fd817d0efbbbb309eb6cce2df
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
cc7f42988a0a642fd817d0efbbbb309eb6cce2df
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Forbid unsafe code

#![forbid(unsafe_code)] annotation makes rustc abort compilation if there are any unsafe blocks in the crate.
Presence of this annotation is picked up by tools such as cargo-geiger and lets them ensure that there is indeed no unsafe code as opposed to something they couldn't detect (e.g. unsafe added via macro expansion, etc).
This also adds a badge advertising that unsafe code is forbidden. Being 100% safe is a desirable property for a crate and should be advertised. The badge currently links to Secure Code WG's community outreach repo, but I'm fine with changing the link or making the badge non-clickable.

Seems reasonable to me! I'd prefer to not update the README now though. Also mind dropping a comment near #![forbid] to explain why it's there?

@alexcrichton done. Sorry for the delay.

👍


Improve code documentation using ruff

Using ruff, we will check the docstrings of the public code. If docstrings are not present or do not follow "google style" then it will raise an error and fail the test.

This is can be enabled in the pyproject.toml file using the ruff lint configuration. See the ruff docs for more info.

Here are the pydocstyle rules used by ruff for checking docstrings:
https://docs.astral.sh/ruff/rules/#pep8-naming-n

Processing ruff checks with linelength=100:

[ ] deephyper.analysis @Deathn0t
[ ] deephyper.core @wigging
[ ] deephyper.ensemble @Deathn0t
[ ] deephyper.evaluator @wigging
[ ] deephyper.hpo @Deathn0t
[ ] deephyper.predictor @wigging
[x] deephyper.skopt (IGNORED for now)
[ ] deephyper.stopper @Deathn0t


Termux: If installed via install script, code-server cannot find the ~/.local/lib/.../node executable it downloads

OS/Web Information

Web Browser: N/A
Local OS: Android 11
Remote OS: Android 11 (Termux 0.117)
Remote Architecture: aarch64 (I believe; file ~/.../node worked fine)
code-server --version: 3.12.0

Steps to Reproduce

Use the given curl command in the README.md file to download and install code-server on most recent version of Termux from F-Droid.
Attempt to start code-server by navigating to the directory of the code-server executable and executing the command ./code-server.

Expected
Code-server starts in the background.
Actual
Program immediately quits with error ./code-server: 36: exec: /data/data/com.termux/files/home/.local/lib/code-server-3.12.0/lib/node: not found
Logs
(Seemingly no logs were generated, at least by code-server itself.)
Screenshot
https://ibb.co/9Nb1Jtg
Notes
The issue does not occur on either of the two versions of code-server I tried via yarn installation. One was the most recent version, and the other one was, I believe, around 3.11; since the yarn versions have the problem that they claim to be incompatible with the Jupyter extension (which has been documented elsewhere, and I believe will be fixed in the next release), I thought I would give the standalone install a try.
This issue can be reproduced in VS Code: No
(Regular VSCode is not available on Termux)

I think this is intentional? Or rather, it's expected. It sounds like you already know that we suggest using yarn to install via Termux, but maybe, we should detect that you're running the install script in Termux and automatically use yarn.
Is that what you're saying?

I found out about the yarn method through Termux's own documentation as I recall, I did not think this was expected behavior and thought that the install script method was also supported for Termux. But that is likely my own error. If Termux support was never intended for the install script, I suppose there is nothing else to be said. Perhaps this could be clarified somewhere (or the script automated to use yarn instead on Termux, as you said).

Well, I agree, the install script should handle this case.

Perhaps this could be clarified somewhere

It is documented here but clearly we're lacking somewhere else. Is there another place you suggest we add it?


Data Integerity Checks

write some checks to ensure data is compelete before moveing data from hold to production tables

Re-Index all hold tables

re-index all production tables

now using node.j  based solution.  This also re-creates the cache of spatial searches.  Looks to take about the same amount of time as the old job.


Delete src files

Delete src files and keep only one copy of the files at index.html for now

Dont solve this issue. No work to be done....


ViTDet object detection

🚀 The feature
ViTDet achieves very interesting results on COCO and, given that ViT is already implemented, it seems relatively straightforward to implement this in torchvision.
Motivation, pitch
The best performing object detection network in torchvision is currently FasterRCNN with a resnet50 backbone (46.7 mAP). ViTDet reports an mAP 51.6 with ViT-B backbone, 55.6 with ViT-L and an impressive 56.7 mAP with ViT-H. Similarly impressive results have been obtained with the instance aware segmentation implementation.
Alternatives
Detectron2 implements ViTDet. It could be decided that torchvision will not provide its own implementation and instead redirects users that want to use ViTDet to Detectron2.
Additional context
Implementing ViTDet opens the door to other implementations, such as EVA-02. EVA-02 achieves even better results compared to ViTDet.
I have previously implemented RetinaNet for torchvision (later merged in https://github.com/pytorch/vision/pull/2784). I might be interested in implementing ViTDet, but I would first like to see if there is interest by the maintainers.

This is actually cool. Given that we have SwinTransformer and ViT a are being offered stably. Both of these can be used as backbones for ViTDet.
A major challenge would be actually reproducing the metrics with torchvision reference scripts. It's not best idea to port weights. (we have done that for SwinTransformer I guess, but it's better if we can train)
Bandwidth might be something @NicolasHug can answer :smile:

@fmassa is there any interest for this?


Why is "onUpdating" not supported for appcache?

I was previously using
window.applicationCache.addEventListener(
  "downloading", this.handleDownloading, false
)

I guess we could use this too for the same event?

Saying that because of this https://github.com/NekR/offline-plugin#onupdating where I can see
"onUpdating
Not supported for AppCache"
But is seems it's supported https://github.com/NekR/offline-plugin/blob/251973e92745506170d04f7ed19fb9feac2098b3/tpls/appcache-frame.tpl#L59

So maybe it's just a doc issue :D

So maybe it's just a doc issue :D

Nope. It's supported, indeed, but is commented away here: https://github.com/NekR/offline-plugin/blob/251973e92745506170d04f7ed19fb9feac2098b3/tpls/appcache-frame.tpl#L125
The reason for that is that we cannot distinguish between downloading being fired for updated or for the initial install. At least it's very hard with current registration approach: via iframe.
Even if it's possible by doing checks inside runtime.js instead of iframe .html file, it's too much work for deprecated technology. Interesting thing is that I spend a lot more time on AppCache implementation here, than on ServiceWorker one. So I kind-of not interested in that feature (I personally believe AppCache shouldn't be used at all).
So I see 2 ways to handle this:

Expose onUpdating as is (with false positives)
Someone implements detection between install downloading and update downloading

Nevermind, I agree that Appcache is the past. Your explanation is fine.

I think I can add reference to this issue in readme after the note about
AppCache. Just to prevent other confusions.
On Sep 28, 2016 11:05 PM, "Maxime Thirouin"<EMAIL_ADDRESS>wrote:

Closed #111 https://github.com/NekR/offline-plugin/issues/111.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/NekR/offline-plugin/issues/111#event-806024956, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABIlkYacNJ3MxHd_8SG7VcPQlw4edJreks5qusiIgaJpZM4KJPWx
.


Time series Forecasting example with test pattern strategy

Hello, thank you for your excellent work.
I would like to try time series forecasting using the test pattern strategy described in the paper.
Are there any the example code on github?

Hi, sorry for the late reply.
I have updated the repo for time series forecasting. Please see the new codes.

Thank you! This will help me.


Update pygame get and put clipboard functions

Currently pygame uses get and put functions instead of get_text and put_text.
Source: https://www.pygame.org/docs/ref/scrap.html

Hello,
This library uses pygame-ce where scrap.get() and scrap.put() are deprecated functions. See:
https://pyga.me/docs/ref/scrap.html


does rasa_nlu support chinese?

does rasa_nlu support chinese?
if not, can it be trained for chinese? if it is possible, can anyone teaches me to do this?
--great thanks!

There was some progress on supporting Chinese when Rasa still had a MITIE pipeline component:
https://github.com/RasaHQ/rasa_nlu/pull/477
Some users are trying to tackle it themselves, but it involved training your own spacy model:
https://github.com/RasaHQ/rasa_nlu/issues/705
Since MITIE support has been deprecated we know have to wait/watch for someone to get Chinese working with spacy before it will work with Rasa. Though it looks like it is being pursued by the spacy team:
https://github.com/explosion/spaCy/issues/1523
https://github.com/explosion/spaCy/pull/1210
Let me know if those don't help you get started and we can re-open the issue!

just an update: MITIE is getting added back in #980


OpenTSDB README page not found

The README link return a 404 page.
URL for relevant page?
https://docs.influxdata.com/influxdb/v1.7/supported_protocols/opentsdb/
What products and version are you using?
1.7
Where did you look before opening the issue?
https://github.com/influxdata/influxdb
https://docs.influxdata.com/influxdb/v1.7/supported_protocols/opentsdb/

thank you, @kebe7jun!


fix(core): 注释拼写问题

Please change the title of the PR to conform to the conventional commits specification.

Thank you for your PR. Since comments should be in English, we have changed the comment here in #1469


Update the additionalRegistrationParameters when update messages are received

Hi all!
Here I come with a PR to update the additionalRegistrationParameters of the registration object when they are included in the update message. This is, among other applications, useful to use with Queue Mode to update the client awake time.
I have basically treated the additional parameters as they are treated regarding the Registration, so the code is very similar to the one present in those classes. Now the Map containing this parameters has changed from the type Collections.unmodifiableMap to Collections.synchronizedMap. Then, when new parameters arrive in the update message, using the method putAll() the already present attributes are updated with the new values, and the new ones are added.
Regarding the serialization used in the cluster, I'm not very familiar with this, but I have implemented the same code as in the serialization of the registration object, and it seems to pass correctly the JUnit test. But please check this in detail.
All feedback is welcomed :-)

Honestly, I don't see the reason to use a mutable map instead of the immutable one, as I remember, each time a request is send, all additional attributes are sent and you should be able to use the immutable map.

I'm not very familiar of how the Map classes work in Java, but when I was implementing it if I tried to apply the methods put or putAll to the unmodifiableMap it throwed an UnsupportedOperationException. So I think you cannot use this methods with this kind of Maps, and that's why I changed it to a synchronized map.

the reason is that one an unmodifiable map has been created, you are not allowed to modify it, you can create an immutable map from a mutable map, something like this: Collections.unmodifiableMap(mutableMap);

I made a new commit with the changes that you pointed in the immutable Map.
Anything else to be done in the PR? @sbernard31 you mentioned to add a test... but what kind? Only to test the updated parameters? Like create a registration object with some random parameters, update them with a registration update, and check if they are the ones expected?

It sounds good.
Except Registration is now modified only about formatting issue. I would prefer to not change it just for that.
About tests, something like that yes.
If you are (or want to be) familiar with git, could you squash all commits in one, else I could quickly do that before to merge.

It's true, Registration.java does not need any changes in this PR.
I can add some tests in this PR before integrating it if you want, and yes I'll squash all commits in one, I think I know how to do it :-)

I can add some tests in this PR before integrating it if you want

Adding tests was a suggestion, I think this could be useful to ensure your modification behave as expected and this could be a way to familiar yourself with that. But do it only if you think this makes sense :).

Yep, I think it totally does and it was very quick. So I think everything is done now :-)

Perfect!
What should be the next step in the Queue Mode implementation? Integration tests? Adding the queue for the requests?

I would prefer to go with integration tests.

Sorry to discuss this here but I don't know where...
I have taken a look on the integration tests and regarding the client behavior how should we proceed? Now it sends an update message every lifetime-10%... which is not what it should do in Queue Mode, it should send an update message when it is awake. But tuning the Lifetime parameter I think we can have the expected behavior in the client. So my question is basically if I can do the tests like this or if I should make small changes in the client's implementation (basically in the LeshanClient and RegistrationEngine classes). I would go for the first approach to make it simpler and not spend too much time on this.

I you want better control on update event you can increase life time for Queue mode test.
You can also use LeshanClient.triggerRegistrationUpdate()


Support Pagination on ListMicrogridDispatches

What's needed?
Google advises to use pagination by default on all list requests. If not being done early on introducing this later would be a breaking change.
Proposed solution
Extend ListMicrogridDispatches rpc to use pagination by default:
// Service providing operations related to dispatching microgrid components.
service MicrogridDispatchService {
  // Returns a list of all dispatches
-  rpc ListMicrogridDispatches(DispatchListRequest) returns (DispatchList);
+  rpc ListMicrogridDispatches(DispatchListRequest) returns (DispatchListResponse);

// Message for listing dispatches for a given microgrid, and an optional filter
message DispatchListRequest {
  // The microgrid ID
  uint64 microgrid_id = 1;

  // Additional filter parameters
  DispatchFilter filter = 2;

+ // maximum number of results to be returned
+ int32 page_size = 3;

+ // identifies a specific page of the list results
+ string page_token = 4;
}

// A list of dispatches
- message DispatchList {
+ message DispatchListResponse {
  // The dispatches
  repeated Dispatch dispatches = 1;

+ // The pagination token to retrieve the next page of results.
+ // If the value is "", it means no further results for the request. Pass the value of response's
+ // next_page_token in the subsequent ListMicrogridDispatches method call in page_token field.
+ string next_page_token = 2;
}

Use cases
No response
Alternatives and workarounds
No response
Additional context
No response

closing, duplicate of https://github.com/frequenz-floss/frequenz-api-dispatch/issues/165


quota list is empty when not in english

hi,
We have the very same issue as :
https://github.com/virtualmin/authentic-theme/issues/1494
We have the very same issue in french the quota is empty. Clearing the cache via the theme menu do not change anything.
Restarting webmin and emptying the browser cache do not change the issue the quota bar is still empty.
Version Webmin | 1.974 |
Version Virtualmin | 6.16
Version de thème authentique | 19.80
Système d'exploitation | Debian Linux 10

as the previous issue is closed i open a new one and comment on the old one :)
best regards,
Ghislain.

Hi,
Thanks for the heads up. Fixed https://github.com/virtualmin/virtualmin-gpl/commit/3c7204d073c041927429bca1613d27990306e948


Tear-off syntax and named constructor

There is the following text in the specification (16.18.3 General Closurization) :
"Evaluation of a property extraction i of the form e#m proceeds as follows
...
The static type of i is:
...
• The static type of function T.m, if T is Type, e is a constant type literal
and the class corresponding to e declares an accessible static member or
constructor named m."
Why "constructor named m" is mentioned here? Tear-off syntax doesn't support named constructor extraction. The following code fails
class C {
  C.m() {
  }
}

main() {
  var i = C#m;
}

@sgrekhov : The below version seems to do what you want. It appears that the language specification was not clear?
main() {
  var i = new C#m;
  print(i);
  var o = i();
  print(o.runtimeType);
}

Now its clear, thank you.

I think this syntax may be deprecated. It doesn't seem to work for me.

@StokeMasterJack yes, the generalized tear off syntax was deprecated and removed from the Dart language.


Ubuntu 18 Network config view GUI does not work as suggested by DOCU

Describe the bug
Docu 4.2.2. Multicast routes GUI describes how to configure eCAL multi-cast with Ubuntu GUI.
I followed these steps, and provided the values on the "IPv4" tab. However Ubuntu did not accept it.
No other routes have been configured before.
To Reproduce
Ubuntu 18.04

I followed the steps on the linked docu.
I finally clicked "Apply".
I opened this configuration/options dialog again.
Clicked on "IPv4" tab again.
Error:
The "Gateway" field, (where <IP_ADDRESS> was provided following the docu), is display red, which indicates that Ubuntu did not accept this route. See attached screen-shot.

Expected behavior
Fixed docu which shows how to do GUI-based configuration successfully.
Screenshots

Desktop (please complete the following information):

OS: Ubuntu
Version: 18.04

Additional context
Running in VirtualBox VM.
Maybe this is a bug in Ubuntu GUI...

This unfortunatelly is a bug in the Ubuntu GUI. It does safe the gateway, but it will display it empty again when you want to edit the settings and you will have to type the "<IP_ADDRESS>" manually every time.

But it would be good to indicate this in the eCAL docu, because it took a lot of time for me to figure out what's going on , while I was trying to fix something which could not be fixed. I think other eCAL users experience the same, and will think the eCAL docu is wrong, or they did something wrong...


Parser for iosxe/show_ap_dot11_5ghz_summary

convert to folder structure, then create PR

PR: https://github.com/CiscoTestAutomation/genieparser/pull/252 created


Docs: Added connect to zulip upstream.

Adds documentation instructing to connect to Zulip upstream in places previously uninstructed.

Implemented and squashed the changes.

this looks pretty close!  I posted a few more comments; probably we should wait for @gnprice's thoughts on the text before finalizing this; I feel like it needs a bit of wordsmithing.

@timabbott I have went with "connecting the Zulip upstream repository" and changed
git remote add upstream https://github.com/zulip/zulip.git git fetch upstream to
git remote add -f upstream https://github.com/zulip/zulip.git

Merged, after changing s/commands/command/ in the last hunk (where there was only one command suggested).  Thanks for cleaning this up @gooca!


How to convert count graphs to E^2 dN/dE graphs

Hey there, while doing the analysis using easyFermi, I am able to generate counts v/s energy graphs but in recent literature they have plotted E^2 dN/dE v/s Energy graphs. Can you please suggest me how can I convert the graph.

Dear @siddcodes11 ,
The SEDs generated by easyFermi are already in E^2 dN/dE v/s Energy. You can give a look here in the YouTube tutorial: https://www.youtube.com/watch?v=OPMOsheCId8&ab_channel=easyFermi
For instance, the SED is shown in the minute 8:30 already in the desired parameters.
Let me know if it helps you.

Thank you so much... yes..I got it..
On Mon, 30 Jan, 2023, 15:14 ranieremenezes, @.***>
wrote:

Dear @siddcodes11 https://github.com/siddcodes11 ,
The SEDs generated by easyFermi are already in E^2 dN/dE v/s Energy. You
can give a look here in the YouTube tutorial:
https://www.youtube.com/watch?v=OPMOsheCId8&ab_channel=easyFermi
For instance, the SED is shown in the minute 8:30 already in the desired
parameters.
Let me know if it helps you.
—
Reply to this email directly, view it on GitHub
https://github.com/ranieremenezes/easyFermi/issues/4#issuecomment-1408287743,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3Z4IDSIGPTBQOPVKD35UXTWU6ERTANCNFSM6AAAAAAUKZXS5I
.
You are receiving this because you were mentioned.Message ID:
@.***>


iPhone does not display images from Azure Blob Storage

Describe the bug
There are seemly random images that do not display on an iPhone when viewing the images that were uploaded to Azure blob storage via the Any Cloud module.
To Reproduce
Steps to reproduce the behavior:

Go to https://exhibits.sos.ca.gov/s/exhibits/item-set/7 on an iPhone
Scroll down to view the items
See that only 3 thumbnails are visible

Expected behavior
Following the same steps on a desktop or android and you'll see that all the thumbnails render as expected
Screenshots

See a thumbnail that renders and one that doesn't
Smartphone (please complete the following information):

Device: iPhone 11 Pro
OS: iOS 16.5
Browser: Safari
Version 16

Can you check the following for me please:

Does your Azure blob directory have the correct permissions to publicly show the images?
Are the missing images actually in the directory?
Do these images show up when using a desktop or other browser?

There’s a chance this is a bug with Omeka-S and the theme you are using so I’m trying to rule that out before digging deeper.

Yes the blob directory has Blob access (anonymous read access for blobs only)
The images are verified in the directory
The images show up fine on Android, Mac, and Windows. I tried using Chrome for iPhone and that didn't work either

I'd like to note that even though the images cannot be viewed on iPhone, holding and selecting "download linked file" allows the user to download the image and then view it in the iPhone file explorer. Additionally I used the iPhone debugging feature by connecting an iPhone to a Macbook and there are no console errors. The network tab shows that the images are being downloaded fine, but still the iPhone will not render certain images.

If the images are being uploaded to the blob and being served to the browser then the AnyCloud module is working correctly. This is likely a browser bug or a bug with the way the theme is rendering the content. Or a bug with Omeka-S itself in displaying the images.
I will leave this open for a couple more days but will likely close it unless we can find a reason to believe it is a problem with AnyCloud.


fixed user managed forwarder rule cleanup issue

Why
This PR address a few issues in HLF controller

When CLF is deleted, then need to clean up existing user-managed forwarder rules from CLF and update it  : ref
Earlier, CLF controller processed through not-found resources. This may cause to throw Reconcile errors. Anyway, there is no need to handle the not-found resources since the deletion is handled via finalizers
Cleanup Info log messages

/lgtm


Class local variable references do not work anymore

Given the following class
---
names:
  state_resource_group: "rg-${target_name}-terraform"
  state_storage_account:
    name: "${target_name}terraformstate"
    container_name: ${names:state_resource_group}

Using the state_storage_account.container_name value results in <nil>.
Absolute referencing still works.

Update: I was actually not referencing this correctly. The correct local reference would've been ${state_resource_group}.
But it turns out that also allowing the 'full local reference' (including the class root key) is something which we can easily support.


Unsafe non-atomic config file creation.

https://github.com/emissary-ingress/emissary/blob/b2b54f10ee38ff8068454b91b2676d762b6ed570/python/ambassador_cli/ambassador.py#L503 generates envoy.json  (or whatever path is given) non-atomically.
This leads to envoy reading empty or partially written config files, dropping all incoming traffic as having no upstream temporarily, for a few ms, then recovering.
(If the Python path isn't in use anymore, this is the error we were debugging)
time="2022-09-05 17:52:03.3138" level=warning msg="/ambassador/envoy/envoy.json: proto: syntax error (line 1:1): unexpected token " func=github.com/emissary-ingress/emissary/v3/pkg/ambex.update file="/go/pkg/ambex/main.go:393" CMD=entrypoint PID=1 THREAD=/ambex/main-loop

Some thoughts on solutions.
If the fs is posix / we're on the top layer, we can write to {output_json_path}.tmp, then rename to {output_json_path}.
If it is not, then we can take out a read lock to exclude other readers, write new contents, then release the read lock.

(Oh and using a tempname is safer, or be sure to set O_EXCL and handle the tmp file already existing (e.g. a crashed writer can leave stuff behind)

For the go version, note that os / ioutil .WriteFile is non-atomic. Its not safe when writing to a file that another process will read. https://pkg.go.dev/os#WriteFile

I think https://github.com/emissary-ingress/emissary/blob/d93fd4ee3630b8bfc37cd8cfd4f66d777f4d0b9d/pkg/ambex/main.go#L404 is the current build line that would show this message - the protobuf decode of content.

We're not 100% sure that this analysis is correct - we have several smoking guns (the log message, observed 0-length envoy,json files (using a high frequency watch, we see them go from size X, to 0, to X again), and the log-but-continue Go code.
However its not clear what the constraints are (is a temp file that gets renamed atomically [combined with an ignore filter on the naming pattern for temp files]), or must the write be done in place; and we're not sure that the identified python code is whats actually doing the truncation: there are multiple unsafe-if-observed places in the code.
So, we'd love it if you fixed this, but we're not really positioned to say more than we have so far. Sorry!

We're also running into this issue and I'd be happy to put up a pull request to address it. From what I can tell, the issue is because the write to the envoy configuration file is non-atomic AND the Go server will log but continue when it encounters an invalid file. So making the write atomic OR updating the Go server to skip updates when it can't decode a file should both address the issue I think. My inclination would be to make the write atomic by writing the configuration to a temp file and then renaming it (this is technically only atomic on Unix systems but maybe fixing it for Unix systems is an okay start?).

@AliceProxy sorry for the direct ping, just curious if you have any thoughts on this issue?


Blank white screen when opening it.

OS: Windows 10
Issue Descriptions: When I open it, the window is blank (white with a lovely orange border). This happened as part of the recent update. As soon as the updated player opened itself when done updating, it was blank. The changelog was there, just not anything else.
Steps to Reproduce: Update to latest version from previous version. Click on Google Play Music Desktop player shortcut in my start menu.

Can you try removing your settings temporarily by renaming them? %appdata%\Google Play Music Desktop Player\json_store\.settings.json rename to .settings.old.json and open the player and see if it's fixed.

I'm having the same issue on Linux Mint 18. Renaming the file /home/[username]/.config/Google Play Music Desktop Player/json_store/.settings.json doesn't appear to change anything.

White screen on linux may be a GPU issue. Have you tried launching with --disable-gpu?

--disable-gpu loads with the blank white screen as well.

Any console errors? Does ctrl + shift + g show a location dialog?

Any console errors?

How do I open the console? F12 and ctrl+shift+i don't seem to do anything in this case.

Does ctrl + shift + g show a location dialog?

Yes. ctrl+shift+l also opens the lyrics screen with the error message "No song is currently playing"

How do I open the console?

Control + Shift + G
Type in DEV_MODE and click Go
Then the standard console shortcuts from chrome should work 👍

Adding in that I just did a fresh install of v4.5.0 on Win10 and have run into the same issue so it's not necessarily an update issue.
Tried removing the settings file as suggested above with no improvement.

Interestingly, I no longer see the blank white screen. As such, I won't be able to help with continued console debugging. I don't think that I downloaded a new version or anything, so I'm puzzled as to why it would suddenly start working.

As soon as I typed at that I restarted my computer and it seems to have fixed the issue.
(Should have tried that before anything else.)

Sounds like everyone is fixed

Having the same problem, and it turned out to be a certificate error.
We have an inline web-filter that does SSL inspection.  This requires us to have a trusted root certificate for our organization.  Mine had gone walkabout, which quickly became evident when opening chrome, but GPMDP didn't show anything.  Resolving my cert issue, fixed the problem.


Request: Documentation on using Eta compiled code from Java

You have some good documentation on using Java code from Eta, but I cannot find any documentation on using Eta code from Java (or Kotlin in my case). I can include the compiled jar on the classpath, but I cannot figure out how to call this code properly, since the methods I get seem to require a lot of plumbing from the runtime. I'm sure there's a simple way to do it, but I can't find anything in the docs. Could you help me out?
Thanks!

Hi, i am afraid that use directly automatic generated classes by eta in java is cumbersome. There is a way to export classes/methods documented here (including java examples!).
Besides that, there is plans to export eta types automatically to java, tracked in this issue.
Hope it helps!

Thanks for the answer and the link! I don't know how I missed it.

Well, maybe the docs for exporting eta methods should be in its own section (like imports) to make it more relevant


Allow top-level functions to be annotated

Is your feature request related to a problem? Please describe.
I have many files that define HttpClients like so:
// FooHttpClient.kt
fun buildFooHttpClient(config: FooConfig) = HttpClient(CIO) { /* ... */ }

// BarHttpClient.kt
fun buildBarHttpClient(config: BarConfig) = HttpClient(CIO) { /* ... */ }

// ...etc

...and a module like so:
val httpClientsModule = module {
	singleOf(::buildFooHttpClient) { named("Foo") }
	singleOf(::buildBarHttpClient) { named("Bar") }
	// ...etc
}

I am porting the codebase to use Koin annotations.
Describe the solution you'd like
Analogous to how class definitions work, it seemed logical that I would just annotate the builder functions with @Single(binds = [HttpClient::class]) @Named("Foo"), and then @Module @ComponentScan(...) class HttpClientsModule would pick them up.
This is not the case. Annotating free standing functions generates no code.
Describe alternatives you've considered
I could put all the builder functions as methods to a single class and annotate it as @Module, which works but requires me to keep all the definitions in a single file. There is no way to split that class without involving a lot of boilerplate code, the very kind I try to avoid by using koin-annotations.
Target Koin project
koin-annotations

@arnaudgiuliani I'm not sure what you mean. Could you provide an example?

I mean, you can declare functions from a class:

@Module
class HttpModule {

    @Single
    @Qualifier("foo")
    fun buildFooHttpClient(config: FooConfig) = HttpClient(CIO) { /* ... */ }

    @Single
    @Qualifier("bar")
    fun buildBarHttpClient(config: BarConfig) = HttpClient(CIO) { /* ... */ }
}

@arnaudgiuliani Yes, I'm aware, I mention this in the issue description. This approach won't let me keep the project structure, I would need to move all the functions to a single file. I could also create a module per each function, but then I'd still need to list all the modules somewhere, defeating the point.
I'm convinced no elegant approach is possible at the moment and that implementing the proposal would be helpful.

Ok interesting. If I wrap up your case here, is to tag a function as a Koin component directly. No module class needed.

@arnaudgiuliani Yes. It would behave analogically to annotated classes (ending up in a @ComponentScan module or the defaultModule).

will be in next milestone: 1.2.0 👍


Make sure core schema is present and valid

The last refactoring of the validation removed the ability to validate
the schema of scim users and groups, i.e. It was possible to provide
users and groups with a wrong or no schema present.
This commit fixes it by providing a custom validator and annotation to
validate the provided schemas.
This closes #142

Why did you close this one?

Äh

Haha :D

I really don't like, that you made Resource#schemas protected and Resource#getSchemas abstract. I'd prefer that you override Resource#getSchemas, but delegate to super.getSchemas.
And doesn't get the validation annotations inherited? Then you could leave the @NotEmpty on Resource#schemas.

Validations get inherited, I'm not sure about your dislike of the abstract method. I need to think about it.

So, did you think about it? :)

I did and I picked up your idea.

Please rebase.

The new classes are missing the correct license header now. Please rebase and fix the header.

Yes. Updated.


Add Get a single gist and Get a specific revision of a gist APIs

Add files property to domain.Gist

Closes #237
Signed-off-by: Aleksandr Vinokurov<EMAIL_ADDRESS>

I've made progress with #238 also, please check #240 combined PR.

@aleksandr-vin I guess this can be closed, correct? Thanks!

Closed as everything was done in #240

Thanks @aleksandr-vin!


baseline ndmg docs

m2g.io is pretty much obsolete - let's to at least v0.01 move stuff over to md on the main docs site so that we have a nice landing point for people.
I need this for a meeting this week.

great job!


upgrade sample apps

Upgraded following Sample Apps to RNW .65

Calculator
CalculatorNuGet
CameraDemo
rssreader

Apps that still need to upgrade

TodosFeed
NativeModuleSample

Microsoft Reviewers: Open in CodeFlow

Revert all the changes to rssreader sample. As it also needs to support react-native-macos, which is on a different release schedule than us, and since we don't have the hardware to validate it, I'd rather @qmatteoq take a look at it and decide if/how/when to upgrade it.

@jonthysell is right, I never upgraded this project because it was created as a showcase for an event with the goal to showcase the same codebase running on all platforms. Unfortunately, at the current stage, MacOS is still a bit behind the Windows implementation, so upgrading the project to 0.65 would break the MacOS version. I'll be happy to upgrade it once the release schedule between the two versions will be aligned.


Update (Credit: 0x7ff)

This fixes support for Apple Silicon MacOS.

Apologies, merging into the wrong repo.


Diffview resets after version control checkin

Describe the bug
When using version control, if a diffview was opened before doing the check in, it is close, and we have to redo the diff analysis all again.
To Reproduce
Steps to reproduce the behavior:

Open a binary
Do modification
Save it as another program
Open the first one again
Enable version control on the first one
use "Tool > Program differences"
apply a change
Check in

What happens
The diff view disapears, only the listing of the program is visible
Expected behavior
The main window should stay as is, keeping the diff result
Environment (please complete the following information):

OS: any
Java Version: any
Ghidra Version: 10.2.3
Ghidra Origin: Archlinux community/ghidra

This is not something we will be fixing for the foreseeable future.  For now, we recommend you do not commit to source control a binary that is being used in a diff session.


Add more epitope databases to datasets

List adapted from #54.

[ ] The MAIT reference database with invariant CDR3
[ ] huARdb https://academic.oup.com/nar/advance-article/doi/10.1093/nar/gkab857/6381136?rss=1
[ ] McPAS-TCR
[ ] PIRD
[ ] The Adaptive Biotechnology database, used to identify (and exclude) public clonotypes shared between unrelated individuals (Dean et al., 2015)
[ ] There might be quite some SARS-COV-2 TCR-epitope resources as well (e.g., Grifoni et al. 2021)
[x] VDJDB
[x] IEDB

@ausserh, how about adding your code for IEDB to scirpy directly?

am on holiday, but will address this once i am back. mcpas is included in the adapters we did at the hackathon. cc @dbdimitrov

Here's a preprint where they compiled a unified database: https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>0398v1
Maybe also a good starting point for the knowledge graph.


reform LogCodes to support multi files

Your question
describe your question clearly

we can support multi files to support this, so users can add their configs if they need to define codes
Your scenes
describe your use scenes (why need this feature)
Your advice
avoid duplicate, if there are two same codes, we need a special order in the first line  to allow they override this config.
so the
Environment

SOFARPC version:
JVM version (e.g. java -version):
OS version (e.g. uname -a):
Maven version:
IDE version:

now we can init multi times to achieve this


More objective fixes

ObjectiveData can be null in GetConversationEntry for some quests. Added check for that.
Added transpiler to fix the hardcoded quest count in the Quests.GetQuest for loop

Fixed offering shrines only spawning 1 of our custom items instead of the total qty
Changed CustomObjectives and CustomItems to partial classes to match the others
Reorganised some patches and their locations
Added a helper reverse patch to Helpers for Interaction.OnInterect (it's used in the shrine fix, so may as well make it re-usable)

Good to go!


operators t8c (42.0.0)

Signed-off-by: esara<EMAIL_ADDRESS>

/merge possible

This looks good to me.  Approved.

/merge possible


Make the interface a nuget, or c# library on its own, so other people can utilize it easily as well

Exactly what the title says.

What "interface" specifically?


WIP: lerna build

Fixes #107

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Added very rough lerna build, still lots to do, but packages are split and building. Instructions are:
yarn install
lerna bootstrap
lerna run build:ts
node package/ethql/dist/index.js

Things still to do (non-complete list):

[ ] move tests into packages and ensure they're working
[ ] move package lifecycle scripts into packages
[ ] move dependencies into packages
[ ] make global lifecycle scripts working (like building docker image)
[ ] document all changes made to actual source code: I've had couple of issues, mostly related to TypeScript types and imports, which are resolved now, but I wan't someone to check if these are ok.

Implemented lerna build in the best way possible (I hope :smiley:):

It uses new TypeScript feature (build mode and project references), this allows to run complete build and watching across all packages at once (also replaced nodemon with tsc-watch, as it's much simpler wrapper around tsc and more suitable to work in build mode).
It uses "global" tsconfig.json which is not used for actual build, but used for jest. This allows to run one instance of jest to execute all tests across packages (including watch mode and coverage mode).

This combination allows running tests or dev/debug build in watch mode for easier development and is producing loosely coupled dist folders for distribution.

Fixed docker build, but not sure what's with circleCI.

Technically everything should be complete, but CircleCI tests are timing out for some reason (work locally and don't take too much time). Cannot troubleshoot this as output is truncated.

Cause for failure was that it was requesting too many workers and correspondingly allocating too much memory. Fixed by limiting workers to 2.

Are there any changes I need to implement here?


Some questions about coefficients in GeneralizedAlpha2Solver

Hi.
In class GeneralizedAlpha2Solver, the coefficients $\beta$ and $\gamma$ is defined as: $\beta = \frac{1}{4}(1.0+\alpha_m - \alpha_f)^2$ and $\gamma =0.5+\alpha_m -\alpha_f$. However, in paper "A Time Integration Algorithm for Structural Dynamics With Improved Numerical Dissipation: The Generalized-α Method",  the coefficients $\beta = \frac{1}{4}(1.0-\alpha_m + \alpha_f)^2$ and $\gamma =0.5-\alpha_m +\alpha_f$.
Why are there differences between code and reference article?

If I remember correctly the definition of both \alpha_m and \alpha_f in the original paper of Hulbert and Chung is awkward -- it goes in the other direction then usual.
I choose to use the standard convention: \alpha = 0 corresponds with t=t^n and \alpha =1 corresponds with t=t^n+1.
Consequently the formulas for \beta and \gamma.


TouchLib simple example

Is there any corresponding example about TouchLib，thanks.

TouchLib is still in the closed beta stage. You can refer to this link for an example.
https://github.com/Xinyuan-LilyGO/T-Display-S3/tree/main/example/touch_test


Address info() performance issue

Address performance issue discuss in https://github.com/dask/s3fs/issues/320.
Update info() method to use list_objects_v2(maxKey=1) to determine whether a particular path is a directory not.
It will try to avoid calling super.info(), this will result pretty expensive operations.

In term of self._ls_from_cache(path) check. It has been checked by this line:
https://github.com/dask/s3fs/blob/master/s3fs/core.py#L536
And I believe this line should cover the case whether it is a file or dir. Should i check it again?

Should i check it again

Right; that line gives the condition where we certainly want to (re)check HEAD; but if the listing is in the cache, your new version doesn't give a way to retrieve it.

I believe that super.info(path) will use the cache information to retrieve the information.

Yes you are right, but this only happens now after you try to list to see if the path is a directory.

I don't follow the comment for changing. Would you mind pesocode how you want to change it based on current version. Thanks.

On second thoughts, I think should_fetch_from_s3 does exactly what I had in mind - so all looks good!


Consume location suggestion API endpoint to populate location autocomplete

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-961
Changes in this PR:
Consume location suggestion API endpoint to populate location autocomplete
To try it out locally, update your environment variables to include the Google Places Autocomplete API key (see Keybase).

just going to update the descriptions in the tests created/refactored in this PR as i forgot and they dont really describe anything at the moment...


Correction for raw affiliation UMR 1208 IATE Agropolymers Engineering and Emerging Technologies , Université Montpellier 2 , Montpellier , France

Correction needed for raw affiliation UMR 1208 IATE Agropolymers Engineering and Emerging Technologies , Université Montpellier 2 , Montpellier , France
raw_affiliation_name: UMR 1208 IATE Agropolymers Engineering and Emerging Technologies , Université Montpellier 2 , Montpellier , France
new_rors: 051escj72;0000n5x09
previous_rors: 051escj72
works_examples: W2007939883
contact: becaf118f793861684669572f1653d16:fcf538db843511c7c60b72cd7022575ef0d4 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Wallet.sol: change to onlymanyowners modifier breaks administrative functions

I think the most recent change to wallet.sol broke all of the administrative functions (i.e., those with the onlymanyowners modifier).
See relevant commit + line: https://github.com/ethereum/dapp-bin/commit/2849dab39f874797ba65557378c8dc2e1a76e448#diff-ed99a3039a35a9961cc9c6735a7099baR49
confirmAndCheck returns either true or false depending on whether or not the function call has been approved by M-of-N owners.  However, regardless of return value, it makes important state changes that count the confirmations received thus far.  The new implementation of onlymanyowners reverts state changes (via require) any time confirmAndCheck returns false, making it impossible to hit the confirmation threshold for any function.  No tallying ever happens.
This makes it impossible to change any of the wallet's properties such as ownership, required confirmations, etc.

I can PR a fix if someone on your team can confirm the bug

You guys don't have any unit tests?...


Add undo script functionality

Taking inspiration from Flyway, this commits adds the undo subcommand to the application, with the --step <n> flag.
Undo scripts will have the U prefix, with the same name and version as their corresponding versioned script. It will attempt to undo  amount of versioned scripts until it finishes, or no corresponding undo script is found.
Under the hood, the application is removing the V script from the change history table, so when the deploy command is ran, the versioned script can be applied again.

IF V migration has no U migration, process stops
Apply U script
Delete V script from the change_history_table related to U

This commit closes issue #19

Couldn't add you as a reviewer, so I'll tag you for visibility @sfc-gh-jhansen @MACKAT05
Let me know if you'd like me to change something. Looking forward on enhancing this useful project

Hi @sfc-gh-tmathew. Would it be possible for this PR to be reviewed?

@eaguilera23 Some thoughts.
not all operations are undoable.
For this methodology / functional pattern,  an undo file is required for every V file created.  philosophically the expectation would be that those would be prepared at the same time as the original V file... creating double work, and double testing since it would be poor practice not to test the undo script as well as the deploy scripts.
There is some agreement with my initial sentiments on SO:
https://stackoverflow.com/questions/4959299/how-to-roll-back-migrations-using-flyway
Also It looks like flyaway has some special spice to allow it to interpret scripts and generate an undo script automatically.
Currently schema change throws the whole rendered file at it and does not interpret scripts statement by statement.  so little issues like a comment at the end of a file breaks deployment.
for this functionality there are a couple of alternative approaches. instead of a U script for v1.1.1 and v1.1.2 just create a v1.1.3 that does the functional equivalent and only when needed... the v1.1.1 and v1.1.2 files can be cloned and re versioned to  v1.1.4 and 5 to go down the other branch in the repository so history is preserved.  Or per the documentation of fly away maintain a clone of the repository at key points to rollback to as part of a robust recovery plan.
Is there something process wise  in your experience that would not allow that alternative (and some what standard if not archaic feeling) pattern.
I had some architecture level thoughts about gathering some of the script ordering functionality into another class to make it exposable for other projects for the purpose of wrapping a UI or web interface around this for interactive deployment and debugging, along with a script to statements splitter and creating two simultaneous connections ( one for applying scripts and one for logging)
It would seem at the point we can interpret the scripts statement by statement we could do a much more robust version of this feature that would not create a burdensome patterns.
When I get some time this weekend I can take a closer look.

@eaguilera23 Catching up on open items and PRs. As @MACKAT05 pointed out, the Undo script will create more work than if we train users to follow the change forward approach.. aka alter from current state to next instead of trying to rollback. creating clones as milestones for rollback purposes in lower environments would be the recommended approach rather than support Undo scripts.
Thoughts?

@sfc-gh-tmathew  - I've been exploring some similar ideas.  I think Snowflake as a tech stack presents a unique solution for this.
What I'd like my team to implement is this: If any migration fails, rollback the entire impact of that schemachange run to its state just prior to the schemachange process starting.  As long as we know the start timestamp for the first schemachange script to be executed as a part of a run, it would be simple to use Snowflake's time travel to just reset the entire schema to that point in time.
I haven't explored the ideas fully, but here are some considerations:

A new column on the change history table could be used to track a "start" timestamp (so the timestamp prior to it executing the script)
If we implemented the first item, then my team would still need to try to figure out how which migration was the first migration for that particular schemachange invocation
Alternatively, my team orchestrate the "time start" logic via of CI/CD (track the time we invoked schemachange)
Overall this general approach seems super solid for downtime deploys and deployments within pre-defined windows - however, it would not be a safe approach for a zero-downtime deploy scenario, as it would lose any data that was generated during the deploy window.

Would love any feedback on my thinking above.

@podung
Changing the structure of the change history table will require careful consideration for those who have established pipelines to not break. Consider the default value that will be set before the column existed in the table. This will have to be part of a major release and carefully considered.
checkout the original discussion #19 where one of the comment talks about leveraging the root folder switch  = /.rollback and have the rollback scripts in there and apply it as conditional step in the orchestration process. Still apply the change forward but effectively rollingback changes using timetravel in snowflake.
I am not in favor of removing the entry from the Change history table. We would want to capture the undo operation as much as the apply operation without loosing the activity on the database. By deleting the record from change history, we loose the history.

Thank you for your patience and contributions. We have decided not to pursue this functionality at this time.


Massage the acknowledgements

I have resisted including the NEUP graphic, although that is their preference...

Looks great! Thanks @gonuke !


Diagnostics from open files sometime not cleared up when file is closed.

open single folder in vscode
and do FAR on Path - https://github.com/microsoft/pylance-release/blob/main/testing/single/src/findallreferences.py#L6
and click all files references are found

Expected: diagnostics are cleared as new file is opened and old files are automatically closed.
Actual: diagnostics are left in problems tab for long time (but it eventually goes away)
...
this repro with 2023.12.1 so must be existing bug.
it eventually goes away so it could be a perf issue. (such as even if a file is closed, we don't cancel pending request such as semantic token or checker requests running in BG so BG is staled or something like that)

I think this might be a VS code issue.
We get this during find all references for a file that isn't open:
2024-04-18 16:26:11.415 [info] [Trace - 4:26:11 PM] Sending notification 'textDocument/didOpen'.
2024-04-18 16:26:11.415 [info] Params: {"textDocument":{"uri":"file:///c%3A/Users/rchiodo/source/repos/pylance-release/testing/single/src/lib/__init__.py","languageId":"python","version":1,"text":"# this file conatins references used by other test files.\r\n\r\nfrom findallreferences import FindConstructor\r\n\r\n# object instantiation reference\r\nFindConstructor()\r\n\r\nxx"}}

Which then causes us to show diagnostics for a file that isn't open.

I can reproduce this with typescript code too. It's not just python.

See this:
https://github.com/microsoft/vscode/issues/205790
It seems we need to switch to a pull model if we want this to work correctly. It has to do with hidden tabs.

In fact the documentation for pull mentions that textDocument/didOpen didClose are not a consistent method to actually tell what files are visible in the editor:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics

Did open specifically says this:
DidOpenTextDocument Notification (:arrow_right:)
The document open notification is sent from the client to the server to signal newly opened text documents. The document’s content is now managed by the client and the server must not try to read the document’s content using the document’s Uri. Open in this sense means it is managed by the client. It doesn’t necessarily mean that its content is presented in an editor.

Switching to a pull method can sort of work, but I believe there's a bug in vscode-language-client:
https://github.com/microsoft/vscode-languageserver-node/issues/1464


Latest vitest and happy-dom with useFakeTimers - Test runner is stuck forever

Describe the bug
Test runner is stuck with the most recent versions of both Vitest (1.2.x) and HappyDom (13.x). If one of the version is reduced (Vitest to 1.1.3 or HappyDom to 12.x), then the test is running fine.
Reproduction

Install vitest 1.2.x
Install happy-dom 13.x
Use "vi.useFakeTimers()"
Run the test (vitest run)
The test is stuck and never return to the command line

Repo to reproduce the issue: https://stackblitz.com/edit/vitest-dev-vitest-bhbpda?file=src%2Findex.ts
This issue may have been introduced by this recent PR: https://github.com/vitest-dev/vitest/pull/4931
I tried to play around with this PR, and by just changing this line,
from
await win.happyDOM.abort()

to
win.happyDOM.abort()

it does lift the block... however win.happyDOM.abort returns a Promise, so it does not seem right.
cc @capricorn86
System Info
System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M2
    Memory: 102.05 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 4.0.2 - ~/.nvm/versions/node/v20.11.0/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.216
    Edge: 120.0.2210.133
    Safari: 17.2.1
    Safari Technology Preview: 17.4
  npmPackages:
    @vitest/coverage-v8: 1.2.0 => 1.2.0
    @vitest/ui: 1.2.0 => 1.2.0
    vitest: 1.2.0 => 1.2.0
    happy-dom: 13.0.6

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

This seem to be related to vi.useFakeTimers(). Removing that statement makes the tests run through.
await win.happyDOM.abort() is trying to abort ongoing timers, but perhaps it collides with the internal logic inside Vitest.

I have found the issue and will soon have a fix in Happy DOM.
Task https://github.com/capricorn86/happy-dom/issues/1210 created.

@aversini this has been fixed now in the latest version of Happy DOM:
https://github.com/capricorn86/happy-dom/releases/tag/v13.0.7

@capricorn86 the issue is indeed gone with your recent fix, thanks for the speedy attention and the amazing work you do on Happy DOM ✨

Thank you @aversini!


Function results in attrs should not be overridden by component instance attributes

This issue emerged from the spectrum.chat discussion.
I believe the current attrs behaviour regarding props precedence is wrong.
Vanilla react component declarations have final say on how they interpret props coming from component instances.
I can merge a component instance attributes giving them a higher precedence:
const PliableDiv = props => {
  const style = {
    ...props.style,
    backgroundColor: "green"
  };

  return
{props.children}
;
};

<PliableDiv style={{color: "red", backgroundColor: "blue"}}>Hello</PliableDiv>

I can merge a component instance attributes giving them a lower precedence:
const OpinionatedDiv = props => {
  const style = {
    backgroundColor: "green",
    ...props.style
  };

  return
{props.children}
;
};

<OpinionatedDiv style={{color: "red", backgroundColor: "blue"}}>Hello</OpinionatedDiv>

Or I can completely ignore what a component instance is trying to impose:
const CarelessDiv = props => {
  const style = {};
  return
{props.children}
;
};
< CarelessDiv style={{color: "red", backgroundColor: "blue"}}>Hello</CarelessDiv>

Contrary to a standard component's behaviour, function results in styled component attrs' are always overridden by component instance attributes:
// I want to get rid of the inline style, but I can't!
const CarelessStyledDiv = styled.div.attrs({
  style: props => ({})
})``;

<CarelessStyledDiv style={ color: "red" } />

Initially, I stumbled upon this issue when dealing with children in attrs, but it applies to any props; I use inline style here because it's easier to see - check out the codesandbox demo.
It can be worked around by assigning a different props name, like this: const Div = styled.div.attrs({style: props => props.instanceStyle}). But I'd prefer to align the behaviour with ordinary react components.

Vanilla react component declarations have final say on how they interpret props coming from component instances.

This isn't an equivalent comparison. attrs is essentially a second layer of props that are akin to defaultProps, with the added bonus of being able to inspect other sibling props at runtime and adjust itself as desired. As such, explicitly passed props will always take priority over attrs because they are not a fallback.