Fixing test errors

Description
Workaround applied for altair, fastai, and matplotlib issues
Related to: fix test errors
Any expected test failures?
Tests might fail on python 3.11

Add a [X] to relevant checklist items
❔ This change

[ ] adds a new feature
[X] fixes breaking code
[ ] is cosmetic (refactoring/reformatting)

✔ Pre-merge checklist

[ ] Refactored code (sourcery)
[X] Tested code locally
[X] Precommit installed and run before pushing changes
[ ] Added code to GitHub tests (notebooks, scripts)
[ ] Updated GitHub README
[ ] Updated the projects overview page on Notion

🧪 Test Configuration

OS: Windows
Python version: 3.8
Neptune version: 0.16.15
Affected libraries with version: fastai==2.7.0, matplotlib==3.4.3, altair==4.2.0

* Few seem to be dependency error (mostly on 3.11)

We can ignore these. Many libraries still don't support 3.11

* Few seem to be `NameError: name 'null' is not defined`

I'll check this. Seems to be a notebook format issue

Maybe it would be tractable and simpler to fix one tool at a time. Wdyt?

Agree.. Will do that going forward.
We also see a few matplotlib installation errors on windows. Will park those for a future fix


Basic docker-based development environment

Usage:
./dev.sh

dev.sh creates a standalone local development environment in an ephemeral
docker container.
The container will operate as your UID and mount in your local mr-provisioner
source path to /work. It will install mr_provisioner, set up and start
postgresql, run all database migrations, run tests, run linters (javascript and
python), run mr_provisioner on localhost:5000 in the background, and also
return a bash shell.
From the docker shell, interactively run "make test", "make lint", etc while
editing files in real-time.
Log into the web interface with username admin, password linaro @
http://localhost:5000/
Signed-off-by: Dan Rue<EMAIL_ADDRESS>

This was discussed and rejected previously, but I'd like to resubmit. It is greatly simplified and improved since the last review, and I think it really simplifies the development process, especially for new contributors. Lastly, I'm tired of cherry-picking it into my development branches and accidentally committing it :monkey_face:

Not entirely sure how I feel about this sort of abuse of containers (it's the polar opposite of how containers tend to be used) - and I would have personally erred on the side of Vagrant or similar - but fine by me.

On second thought, maybe it'd be somewhat less of a hack if you at least pulled out postgres and used docker compose or similar?

I agree that it could be done better, and that breaking the components out into their own containers using compose would be an improvement. I just haven't done it yet, and without this in the tree for others to work off of, they would have to start from scratch if they were interested in doing that work.
As far as abuse of containers - I don't share your view of container usage. Clearly their biggest usecase is in distributing and deploying applications. But their use in development and testing should not be dismissed. Is it abusive when travis uses containers to test this application? I could have done this in vagrant - I've used both vagrant and docker extensively - but it would have been slower and more complicated to run, with no real benefit.
This isn't designed for use in running mr-provisioner in production. That's why it's called "dev.sh" and uses /dev/. It is a hack in so far as it is merely a development solution. I think it could be iterated on and become an actual deployable docker application using docker compose, but I don't think that's a good reason to keep it out of the project.
There is a lot of value in a shareable, reproducible from scratch, ephemeral development environment. Maybe the next person could just take it and use it to make actual improvements to mr-provisioner, rather than spending all the time I had to getting a development environment set up in the first place.
If you have a better solution, I'd love to use it. I'm offering what I use, because I think it works pretty well and has helped me confidently and quickly make changes to mr-provisioner without a lot of overhead. It is well isolated to its own "./dev*" namespace, and does not impact the rest of the project in any way.


Add flutter getting started

Hi @leisim,
I just started to use Hive in my own flutter project and noticed that the readme part of getting started in flutter could have more details which dependencies are required besides hive. I have added these. Feel free to merge.
Best
Christian

Thanks for this pull request. Something seems to have gone wrong with one of your commits. The two benchmark pngs have been corrupted.

wups... did not notice that. I'll check it what went wrong.

The problem should be solved. It was an issue with the autodetction for crlf and lf conversion in the .gitattributes for windows. Should be solved.

Perfect, thanks!


Cant perform Add-Migration

When I try to perform Add-Migration command, I get the following:

PM> add-migration InitialMigration
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.TypeInitializationException: The type initializer for 'BuildCast.DataModel.LocalStorageContext' threw an exception. ---> System.TypeLoadException: Could not load type 'System.Threading.Tasks.Task' from assembly 'System.Runtime, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
at BuildCast.DataModel.LocalStorageContext..cctor()
--- End of inner exception stack trace ---
at BuildCast.DataModel.LocalStorageContext..ctor()
--- End of inner exception stack trace ---
at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor, Boolean& bNeedSecurityCheck)
at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, StackCrawlMark& stackMark)
at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, StackCrawlMark& stackMark)
at System.Activator.CreateInstance(Type type, Boolean nonPublic)
at System.Activator.CreateInstance(Type type)
at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.<>c__DisplayClass12_3.b__13()
at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.CreateContext(Func1 factory)    at Microsoft.EntityFrameworkCore.Design.Internal.DbContextOperations.CreateContext(String contextType)    at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)    at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigrationImpl(String name, String outputDir, String contextType)    at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigration.<>c__DisplayClass0_1.<.ctor>b__0()    at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_01.b__0()
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Exception has been thrown by the target of an invocation.

Do you have repaired?


Enhancement in container runtime + Dockerfile issue with SSL certs

Allow to set -Dconfig flag via env CONFIG_FILE on startup.  …
This allows us refer to another CONFIG_FILE during startup.  I've kept the
default which refer to secor.prod.partition.properties if not set.
In kubernetes we can simply control which config is used by volume mounting the
correct config map, but this keeps backwards compatibility and provides the
possibilities to:

All environments in one config map
A given environment in one config map.

Fixes missing cacerts bug currently happening in openjdk:8 image  …
This patch can be reverted once Debian Stable (Stretch) has backported the fix
mentioned in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894979 .
See docker-library/openjdk#145 (comment)

Thanks for the contribution.


Limit bulk delete to messages sent within two weeks

After https://github.com/hammerandchisel/discord-api-docs/issues/208 the bulk delete endpoint cannot delete messages sent more than two weeks ago. Discord.Net should detect messages sent more than two weeks ago and throw an exception when this occurs.

The endpoint will fail with a bad request later, so it will just end in an HttpException anyway. Checking the timestamps before making the request should be handled by the bot developer and not by the library imo.

Intercepting a request that Discord would reject is part of a library's job.
I would suggest handling this by generating a pseudo message ID for a message created 2 weeks ago. Comparing one ulong against a maximum of 100 ulongs is the cheapest way of handling this that I can think of.


support tsconfig path aliases

It seems that esbuild-dev doesn't recognize path aliases.
For example, consider tsconfig.json
{
	"compilerOptions": {
		"target": "esnext",
		"module": "esnext",
		"moduleResolution": "node",
		"strict": true,
		"esModuleInterop": true,
		"lib": ["esnext"],
		"baseUrl": "src",
		"paths": {
			"@/*": ["./*"]
		}
	}
}

and two files:

src/main.ts doing import "@/foo"
src/foo.ts doing console.log("I am foo")

The app will crash:
❯ yarn esbuild-dev src/main.ts
yarn run v1.22.17
$ /Users/semenov/work/xxx/node_modules/.bin/esbuild-dev src/main.ts
Error: Cannot find module '@/foo'
Require stack:
- /Users/semenov/work/xxx/src/main.ts
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (/Users/semenov/work/xxx/node_modules/@cspotcode/source-map-support/source-map-support.js:679:30)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/semenov/work/xxx/src/main.ts:19:29)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.require.extensions.<computed> [as .ts] (/Users/semenov/work/xxx/node_modules/esbuild-dev/src/child-process-registration.ts:68:14)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/Users/semenov/work/xxx/src/main.ts' ]
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For comparison, esbuild-runner will work just fine:
❯ yarn esr src/main.ts
yarn run v1.22.17
$ /Users/semenov/work/xxx/node_modules/.bin/esr src/main.ts
I am foo

I thought the esbuild-dev you installed is not mine. Mine is @hyrious/esbuild-dev. You can post the issue there.

About the tsconfig support, It will be really a lot of code to implement it in plain js because it could contains extends and comments and trailing comma.
None of us esbuild wrappers (@hyrious/esbuild-dev, esbuild-dev, esbuild-register, esno (esbuild-node-loader)) would support it in transform only mode. For example, using require.extensions or --experimental-loaders.
So the support for tsconfig paths are just from using the esbuild bundle mode. This is what esbuild-runner does when not using --cache according to its source code. This is also what @hyrious/esbuild-dev current does since I didn't use the transform mode.
One possible implementation for tsconfig in --experimental-loaders, is using esbuild to really bundle once to resolve the correct path, which is implemented in esno.

My apologies for confusing a different esbuild-dev with yours! 🙈
I didn't pay attention to the different modes (transform vs. build) indeed, that explains it now. Here's the related issue in esbuild for reference: https://github.com/evanw/esbuild/issues/394
What I've noticed however, is that esbuild-runner --cache (transform mode) works with tsconfig-paths/register, but esbuild-dev still doesn't:
~/work/testing master* ⇡
❯ yarn esr --cache src/main.ts
yarn run v1.22.17
$ /Users/semenov/work/testing/node_modules/.bin/esr --cache src/main.ts
Error: Cannot find module '@/foo'
Require stack:
- /Users/semenov/work/testing/src/main.ts
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/Users/semenov/work/testing/src/main.ts:1:8)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Module._compile (/Users/semenov/work/testing/node_modules/source-map-support/source-map-support.js:547:25)
    at Module.mod._compile (/Users/semenov/work/testing/node_modules/esbuild-runner/src/hook.ts:53:22)
    at Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Object.Module._extensions.<computed> [as .ts] (/Users/semenov/work/testing/node_modules/esbuild-runner/src/hook.ts:56:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

~/work/testing master* ⇡
❯ NODE_OPTIONS="-r tsconfig-paths/register" yarn esr --cache src/main.ts
yarn run v1.22.17
$ /Users/semenov/work/testing/node_modules/.bin/esr --cache src/main.ts
I am foo
✨  Done in 0.36s.

~/work/testing master* ⇡
❯ NODE_OPTIONS="-r tsconfig-paths/register" yarn esbuild-dev src/main.ts
yarn run v1.22.17
$ /Users/semenov/work/testing/node_modules/.bin/esbuild-dev src/main.ts
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@/foo' imported from /Users/semenov/work/testing/node_modules/.esbuild-dev/src/main.ts.js
    at __node_internal_captureLargerStackTrace (node:internal/errors:464:5)
    at new NodeError (node:internal/errors:371:5)
    at packageResolve (node:internal/modules/esm/resolve:884:9)
    at moduleResolve (node:internal/modules/esm/resolve:929:18)
    at defaultResolve (node:internal/modules/esm/resolve:1044:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:422:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:222:40)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
    at link (node:internal/modules/esm/module_job:75:36) {
  code: 'ERR_MODULE_NOT_FOUND'
}
✨  Done in 0.43s.

I'm not asking anything here — just sharing my experience.


[Package Request]: Chitubox resin slicer

How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

What's the type of your software?
exe
Please provide the following information
Download Page Url: https://www.chitubox.com/en/download/chitubox-free
Install Options:
Publisher: Chitubox
Publisher Page: https://www.chitubox.com
Package Page:
Package Name:
Description:
Package Version:
Installer URL: https://download.chitubox.com/17839/v1.9.5/CHITUBOX64Install_V1.9.5.exe?auth_key=1690727593-fjcjlhf5jpqu4t2nstjebnti1zax7unp-0-66f691d1386a8d4df3b84d3d86929e1b
License:
License Page:
Copyright:

There's an auth_key parameter in your InstallerUrl, it will change each time when you ask for downloading action.
winget.exe only supports STATIC installer URL. Sorry, we are unable to achieve this.


when opening a file with a line number, atom should scroll down to display that line number at the top of the view

Description
When opening atom from the command line, to a specific file and line number, atom does not scroll the content in the most desirable manner...
Steps to Reproduce

atom text/someFile.txt:115

Expected behavior: I expect Atom to scroll so that line number 115 is at the top of my editor
Actual behavior: Atom scrolls to the line number, but only far enough for it to be presented at the bottom of the screen. Furthermore, plugins like JSHint that are displayed at the bottom will cover the desired line number. Therefore, the user still has to scroll the content to view the line number, defeating the entire purpose of this feature.
Versions
$ atom --version
Atom    : 1.8.0
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1

I think this is a regression – this (and most other actions that are supposed to scroll a line into view) is supposed to vertically center that line.

Any updates on this?

One year later, asking for updates again!

Another year, another hopeful request...

I think this is a regression – this (and most other actions that are supposed to scroll a line into view) is supposed to vertically center that line.

Thanks for this clarification, @mnquintana.
#19272 restores the previous behavior. With the changes in #19272, when opening a file at a specific line, Atom will now:

Attempt to scroll the editor as needed so that the specified line is centered vertically
If the file is already open and the requested line is hidden by a fold, unfold so that the line is visible

This change is slated for inclusion in the Atom 1.38.


Module not found: Error: Can't resolve '@carbon/ibm-products'

I am getting the above error when I am importing the below line.
import { PageHeader } from "@carbon/ibm-products";
I am using React 18. Kindly help me.

Yes. I'm using react 18 and that's why it is causing the issue

Ahhh, we don’t support that yet but it’s in our backlog. Closing this issue for now since this will hopefully be addressed by #2895 🤞


Implement RettiwtFactory

A factory class may be added to create new Rettiwt with rotating config.
Rate limit is currently 500 requests / 10 minutes / 1 ip. Rotating config will extend this limit.
Config for the factory could look something like this:
[
  {
    "twitterApiKey": "exampleWithProxy1",
    "proxyConfig": {
      "proxyHostname": "host1",
      "proxyPort": "3000",
      "proxyUsername": "user1",
      "proxyPassword": "pass1"
    }
  },
  {
    "twitterApiKey": "exampleWithProxy2",
    "proxyConfig": {
      "proxyHostname": "host2",
      "proxyPort": "3000",
      "proxyUsername": "user2",
      "proxyPassword": "pass2"
    }
  }
]

It might not be necessary to rotate the api key. Currently, the account rate limit is unknown. There are no known cases of blocked accounts due to rotating ip.
In the factory, a couple of strategies can be applied to create Rettiwt:

Store last used config index in Redis (cache). Users should provide their Redis details
If the user does not provide Redis details, take random config.

Randomness may lead to the same config being used over and over again, resulting in exceeded rate limit for the config. Errors may start appearing before all configs have their rate limits exceeded.
Cached index would ensure configs are used one after another. Errors would only appear if rate limit has been exceeded for all configs.

I have a question though. Is it okay if we leave the job of rotating the proxy to the user? That we they will have the freedom of choosing their rotation strategy. All this library will do is work with the given proxy. What are your thoughts?

Is it okay if we leave the job of rotating the proxy to the user?
Whether you want to include this feature is for you to decide. I think it might be useful for many users . The package could be easier to use.

I raised this issue because you left a question here: https://github.com/Rishikant181/Rettiwt-API/pull/372#issuecomment-1729879153

I was wondering if instead of taking a single proxyUrl, we might use a list of them to implement a rotating proxy. What do you think?

If you want to implement rotating proxy, then this may be a solution. If it is not needed, the issue may be closed.

It was implemented at one point, long before this package was made public. And then I scraped it off to relieve the package of any functionalities, that can be added by the users themselves.
Upon some thought, I think it will be better to leave the rotation to the user as it's implementation is trivial. The package provides and option to use proxy and the rotation be left to user.

Have you, by any chance, already started working on it?

A little bit, but I haven't done much

Let's put it aside for now, since this can be implemented by the user by instantiating different Rettiwt instances with different proxies and rotating through them according to whichever strategy they decide.


Can MarcelloDB create an in-memory database?

If not, I guess this is a feature request.

Hi there,
Yes, MarcelloDB can work as an in memory database.
You can achieve this by implementing a specific Platform object which doesn't use the file system, but works on memory streams directly.
Take look at this code:
https://github.com/markmeeus/MarcelloDB/tree/master/MarcelloDB.Test/TestStream
I you copy those 2 files in your project and initialize your Session with the TestPlatform (or rename it as you want) you'll end up with a fully function in-memory MarcelloDB.
new Session(new TestPlatform(), "/path/does/not/matter");

It's a bit undocumented since I want to keep the freedom to change the IPlatform interface.
thanks for asking!

Thank you! That's really helpful. I copied those files and credited them to you.


Update flake.nix

Implement fix to locate the desktop options in the home-manager folder, as it is not in the modules folder any longer.

Thank you @Br0kenTh0rax !


Description
need an mind gauging logo for OpenLMS project.
Suggested Solution
a figma logo, or any format with no copyright infrigments
Alternatives
Anyone open to contribute with this is welcomed!
Additional Context
No response

Sir, I am interested in this . So, assign me this issue @Bhanu-code .


Map interaction from search

User story

As a user,
I need to be able to select a location from the search results,
So that it can be automatically shown on the map.

Acceptance criteria

Selecting a location from the search results immediately focuses the map on the selected location.
The map zooms in to a predefined level that best displays the selected location.

Definition of done (DoD)

User feedback on this feature is consistently positive in usability tests.

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

currently only with default values

flyto by lucas, actual coords from suggestions is from celine

So your part is done, @Lucas-Nan? Now only the rest is on @CelineMP?

@dancingsushii
@Lucas-Nan implemented a function that is called when a search result is entered to fly to a coordinate. I expanded on it to also fly to areas within their bounds. So this is done.
This ticket is for displaying the area even better: https://github.com/orgs/amosproj/projects/42/views/1?filterQuery=celine&pane=issue&itemId=64937245

Oh, okay, then I am closing this issue.


is_CNF semantics

The is_CNF method has (at least) two uses:

Figuring out whether a sentence is in CNF as described by the KCM, where variables can't occur more than once in a clause
Figuring out whether a sentence can be fed into a SAT solver

These are at odds with each other. Near-CNF sentences with duplicate variables in a clause are safe for SAT solvers, but because we use is_CNF() internally, they're not used for those.
I'm working on caching sentence properties, and marking sentences as having properties in advance. The sentences produced by nnf.tseitin can safely be marked as CNF, but the sentences produced by dimacs.load (in CNF mode) can't be.
So a looser alternative to the current is_CNF would be useful, if only for internal purposes. (It would also be faster even without caching.)
The reason for the strict definition in the KCM seems to be to make DNF a subset of DNNF and keep CNF symmetrical with DNF. But outside the KCM, the looser definition of CNF (and DNF) seems to be the common one, e.g. Wikipedia, MathWorld.
I think people would expect is_CNF to use the looser definition after all, at least by default. Could the looser behavior give problems?
Would it be a good idea to give is_CNF and is_DNF a strict=False argument so you need to opt in to the KCM definition?

I think that's viable. If there are places in the code that require the stricter KCM interpretation, then it could use the strict=True directive to ensure that things are as they should be.


Bumps flax to 0.4.0

Updates flax to the most recent version. This currently breaks the
current implementation and way in which rng keys of  dropout is being
handled.
Currently have disabled one of the dropout equivalence tests as I am not
fully aware if there is a method of directly affecting the value of
next_key within a treex module.

Hey @ptigwe! Thanks a log for this :)

Currently have disabled one of the dropout equivalence tests as I am not
fully aware if there is a method of directly affecting the value of
next_key within a treex module.

Yeah, trying to simulate the rng key splits is tricky (I've fought with it in the past). Managed to figure it out though so I pushed the fix + also applied pre-commit which was failing.
I think this is good to go once CI passes.


Handle spaces in working path gracefully

It looks like port_compiler chokes on spaces in paths. I have executed rebar3 compile in the current directory ~/workspace/CBOX - Dialyzer and this is what I have found in the debug output:
===> Port Cmd: cc -c -m64  -Ic_src -Wall -fPIC  -I"/usr/lib/erlang/lib/erl_interface-3.7.18/include" -I"/usr/lib/erlang/erts-6.2/include"   /var/lib/jenkins/workspace/CBOX - Dialyzer/_build/default/lib/bcrypt/c_src/async_queue.c -o /var/lib/jenkins/workspace/CBOX - Dialyzer/_build/default/lib/bcrypt/c_src/async_queue.o
...
===> cc: error: Dialyzer/_build/default/lib/bcrypt/c_src/async_queue.c: No such file or directory
cc: error: Dialyzer/_build/default/lib/bcrypt/c_src/async_queue.o: No such file or directory

Hmm, this ought to be easy to fix. I'm on the last day of a vacation but I'll try to tackle this on the plane trip back.
Thanks for the report!

@KaiHa, I failed to provoke a failure with rebar 2.6.4 and rebar 3.3.1 + pc 1.4.0. Do you have an example project to reproduce the fault?

Sorry @blt, I have no project at hand and I am currently not working with Erlang.

I cannot reproduce it here. @ferd, @tsloughter, is it possible this was a general issue in rebar3 that has since been corrected?

Resolved by https://github.com/blt/port_compiler/pull/31

@tsloughter this issue is still giving problems, after processing the files  using escape_chars the newly added \ is not handled well by the filelib:wildcard function resulting in an empty list and nothing gets compiled.
6> filelib:wildcard("/Users/agustin/Documents/with spaces/erlscrypt/c_src/*.cpp").
["/Users/agustin/Documents/with spaces/erlscrypt/c_src/scrypt.cpp",
 "/Users/agustin/Documents/with spaces/erlscrypt/c_src/scrypt_nif.cpp",
 "/Users/agustin/Documents/with spaces/erlscrypt/c_src/scrypt_port.cpp",
 "/Users/agustin/Documents/with spaces/erlscrypt/c_src/sha256.cpp"]
7> filelib:wildcard("/Users/agustin/Documents/with\\ spaces/erlscrypt/c_src/*.cpp").
[]

Maybe I am missing something ?.


Update homepage meta description

https://artsyproduct.atlassian.net/browse/FX-2236
Problem
Our current meta description on the homepage is too long and Google's crawlers do not read it, leading to bad SEO.
Solution
Shorten the meta description for our homepage.

I believe this same piece of copy is used in a few places including a Metaphysics fallback? May want to project search around. 👍

Good catch @dzucconi, found one other instance.


wsProvider -> rpcProvider for getTransaction

Dapp change checklist:

[ ] Code reviewed by 1 reviewers.
[ ] CI passes

Fixes https://github.com/factor-finance/xusd-dapp/issues/41


MaterialPageRoute incorrectly applies CupertinoPageRoute’s transition animation on iOS

If you use MaterialPageRoute, Flutter automatically adapts the transition animation depending on the platform: on Android it uses a transition from  MaterialPageRoute, and on iOS from CupertinoPageRoute. It's a good idea, but the implementation needs to be improved.
Although MaterialPageRoute adapts the transition animation depending on the platform, it uses the wrong animation speed for transition from CupertinoPageRoute: instead of 400 ms animation speed required for CupertinoPageRoute, it uses 300 ms animation speed which is only suitable for MaterialPageRoute. It seems to be no big deal, but this makes CupertinoPageRoute's behavior feel completely different than it should. It doesn't feel like a native transition animation.
I have a question: is it normal MaterialPageRoute behavior on iOS or is it a bug? What was the point of using a transition animation from CupertinoPageRoute in MaterialPageRoute on iOS?
By the way, in one of the next releases there will be an improvement CupertinoPageRoute’s transition animation. Issue: #95511, PR: #95537. Briefly, the CupertinoPageRoute transition animation will have a new barrierColor like in native iOS. With the current implementation of how the transition animation works depending on platform, I guess those developers who are using MaterialPageRoute for both platforms won't be able to notice these improvements.

That certainly looks like a fidelity issue - PageTransitionsTheme does specify transition builders, but not durations and other parameters of these transitions.

This will be a weird one to figure out. After a short bit of pondering, I can't imagine a way of doing this that both 1) wouldn't suck, and 2) wouldn't break some public APIs folks out there are using to configure durations.
I think the core problem is that the current API for configuring durations on routes is not straightforward, and not consistent:

You can define transitions as properties on the route
You can also override createAnimationController on certain routes to provide custom values, and if you do that, then the required-to-define transitionDuration fields become irrelevant, and you can't make the implementation of createAnimationController dependent on stuff like the platform on the Theme without manually injecting that info into the route
And then there are the imperative methods for pushing dialogs and modals—sometimes these don't make transition durations configurable, and sometimes they do, but sometimes they do by taking in durations as parameters, and sometimes they do by providing a whole AnimationController for the route to use.

I feel like the ways this could be solved would be to either:

Build a custom solution for MaterialPageRoute that allows this to be configurable, which I think would necessarily further fracture the APIs for how to configure transition durations for routes, or
Take this as an opportunity to decide on a flexible and consistent path forward that all TransitionRoutes can use to make durations easily configurable. And to make things clearer for devs, we may be able to do so in a way that feels similar to how other platform-specific transition configuration is done, hopefully making the whole transitions system easier to understand, document, and maintain.

I'm blocked on some other stuff I was working on atm so I'm gonna put some thoughts together on the options we have.

I haven't looked closely at it, but it seems, we could just add more properties to PageTransitionsTheme, which MaterialPageRoute already uses

I haven't looked closely at it, but it seems, we could just add more properties to PageTransitionsTheme, which MaterialPageRoute already uses

Well yes, and that probably is going to be what makes sense to do, but we'd also have to expose some part of the route where we can actually build the animation controller with access to a context from which you can pull the theme values. This would be the path of least resistance:
@override
Duration get transitionDuration {
  final ThemeData theme = Theme.of(navigator!.context);
  return theme.pageTransitionsTheme.something.duration(theme.platform);
}

@override
Duration get reverseTransitionDuration {
  final ThemeData theme = Theme.of(navigator!.context);
  return theme.pageTransitionsTheme.something.reverseDurations(theme.platform);
}

@override
Color? get barrierColor {
  final ThemeData theme = Theme.of(navigator!.context);
  return fullscreenDialog ? null : theme.pageTransitionsTheme.something.barrierColor(theme.platform);
}

The null checks on the navigator! here feel bad to me, in terms of how understandable the code is in the long term. It's not super clear how these values are used or why we can be sure that the null checks are safe (I'm not actually sure if the null check on barrierColor would be safe).
The alternative I was imagining would be worth considering, would be something more like:
@override
AnimationController buildAnimationController(BuildContext context, TickerProvider vsync) {
  // Routes that currently take in a custom animationController could just return it here
  // The context here is the navigator context, but this method would only get called once during `install`
  final ThemeData theme = Theme.of(context);
  return AnimationController(
    duration: theme.pageTransitionsTheme.something.duration(theme.platform),
    reverseDuration: theme.pageTransitionsTheme.something.reverseDuration(theme.platform),
    vsync: vsync
  );
}

@override
Color? buildBarrierColor(BuildContext context) {
  final ThemeData theme = Theme.of(context); // This would be the `ModalScope`'s context, which feels more correct to me
  return fullscreenDialog ? null : theme.pageTransitionsTheme.something.barrierColor(theme.platform);
}

After doing some more digging, I've found that the navigator! calls should probably be fine. Gonna take a crack at this the simple way 👍🏻


code block wrapping

Ideally you don't want to wrap code-block text, instead preferring horizontal scroll since formatting matters.
I solved this with CUSTOM_CSS
pre {
  overflow: auto;
  word-wrap: normal;
  white-space: pre;
}

Perhaps this (or another solution) could be activated with a new option CODE_OVERFLOW or something like that.

+1

Hi!
First of all, thanks for your interest in this theme! It's with heavy heart that I have decided that I can no longer maintain this theme due to lack of time and changing interests. To makes sure the theme lives on however and not goes to waste, I've donated it to the Pelican community. It can now be found in the official pelican-themes repository. I'd suggest you re-submit your issue  there.
Sorry for the inconvenience!


using separate input/output vocabularies

Hi all,
I was trying to keep the input/output vocabularies separated (to have an additional datapoint and check performances).
I took inspiration from wsj_parsing_tokens_16k - basically by using a similar token_generator function.
This technically worked, but when decoding it was clear to me that I was only using the input vocabulary.
So I also changed feature_encoders, to return a different vocabulary for encoder and decoder.
This works in data preparation (t2t-datagen), but it crashes in training because - I have a feeling - training is using the wrong dictionaries, and given one is shorter than the other, there is an out of index error:
ValueError: Variable symbol_modality_28_512/shared/weights_0 does not exist, or was not created with tf.get_variable(). Did you mean to set reuse=None in VarScope?
Do you know if I am supposed to change some parameters to make this work?
Thanks,
Mirko

Check the wmt_zhen_tokens_8k example with separate source and target vocabulary.

Your crash, I believe, is due to this hyperparameter setting:
https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/models/transformer.py#L296
Try running with `--hparams="shared_embedding_and_softmax_weights=0"' -- then we're not forcing the model to share source and target weights, which is impossible if vocabularies are different (and so it crashes). I'm closing for now, but please reopen if the problem still appears!

Thanks @lukaszkaiser !
that fixed it.

Check the wmt_zhen_tokens_8k example with separate source and target vocabulary.

This reply solves my problem, thank you :)


Update setup.py

Current setup fails because redis-py._compat no longer exposes b()

This repo is deprecated. Please use the official Redis library.


Errors loading annotation JSON

It looks like the annotations hashes are being loaded into Cassandra with an extra set of quotation marks around them as in, so calling json.loads parses the JSON into a string and calling json.loads a second time actually parses it into an annotation object.

In aggregation_api.py, the commands that migrate the annotations from postgres to cassandra are:
params = (project_id, user_id, workflow_id,created_at, json.dumps(annotations), updated_at, user_group_id, user_ip,  completed, gold_standard,  subject_ids[0], workflow_version,json.dumps(metadata))
statements_and_params.append((insert_statement, params))
Since Cassandra doesn't support json - I've just converted the annotations into a string with json.dumps. No idea why that should result in an extra set of quotation marks.

I was wondering if it was because they were being read as strings from Postgres by the Python Postgres driver.

I would have thought that the annotations would be kept as a dictionary (since that is what they are stored as) but the updated code should help with that check

Thanks. I'll give it another try soon.

According to @edpaget , this seems to be working now


Warning on data when props exists is broken

According to this discussion, http://forum.vuejs.org/topic/600/how-to-properly-pass-props-values-to-constructor, passing data for properties in the constructor is safe and warning should be ignored.
In Vue.js 1.0.15, doing so break the app. Here is a fiddle illustrating it: https://jsfiddle.net/noirbizarre/msz8okm1/

My bad, this the warning stack trace.


feat(typescript-effect-schema): support<EMAIL_ADDRESS>

Context (-, typescript-effect-schema)

Input Format: -
Output Language: typescript-effect-schema
Description
With the effect v3.10.0 release, effect-schema became a stable version within the core effect package and @effect/schema should not be used anymore as newer effect versions are incompatible with it.
It already had the issue with the Schema.Record API moving from Schema.Record(key, value) to Schema.Record({key, value}) this PR addresses that one as well
Current Behaviour / Output
quicktype currently supports the usage of<EMAIL_ADDRESS>to generate the schemas which is deprecated as now effect/schema is part of the core effect library.
import * as S from "@effect/schema/Schema"
// ...
S.Record(S.String, S.Number)

Proposed Behaviour / Output
import {Schema as S} from "effect"
// only other api change is how records are done:
S.Record({ key: S.String, value: S.Number })

Solution
Changed import to use effect instead of @effect/schema for the imports and fixed the behaviour of Records
Alternatives
No Alternatives
Context

Cancelling in favour of: https://github.com/glideapps/quicktype/pull/2646

#2646


Flag --site and --base add params

What kind of changes does this PR include?

New or updated content

Description

Flag --site and --base add params

Straightforward improvement, thanks!

Love it! Perfect. Matches the help command display exactly.


Fix FateCommand cancel message

This will be obsolete if #2914 is merged.

Closing in favor of #2914


Jinja Templated queries not working in master branch code

A jinja templated query is not working in superset compiled from source but is working in 0.36 version of pip installed superset
Python version:- 3.7
OS: Ubuntu 20.04
Superset Version master branch code and 0.36
I am adding  screenshots for reference.

@abhishekkumaresan We've turned jinja templating off by default due to security concerns. You can re-enable it by setting the feature flag ENABLE_TEMPLATE_PROCESSING
this is covered in https://github.com/apache/incubator-superset/blob/master/UPDATING.md

Sorry for posting a new issue, Thanks


travis build fails after eject - path to polyfills is broken

The builds were successful before the eject command, but now they are not passing and I get this error:
><EMAIL_ADDRESS>test /home/travis/build/razvanilin/depomo/client
> node scripts/test.js --env=jsdom
 FAIL  src/containers/App.test.js
  ● Test suite failed to run
    ENOENT: no such file or directory, stat '/home/travis/build/razvanilin/depomo/client/\config\polyfills.js'

      at Object.fs.statSync (fs.js:907:18)
      at Object.statSync (node_modules/graceful-fs/polyfills.js:297:22)
      at process._tickCallback (internal/process/next_tick.js:103:7)
Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        0.62s
Ran all test suites.
npm ERR! Test failed.  See above for more details.

The path to polyfills.js seems to be broken. My guess is that I build this app on windows environment and travis uses unix type OSes. My knowledge in how travis works are quite limited and I might be missing something really basic.
I also tried to find where the path is being used in the settings files but couldn't find anything on this matter.
Can somebody shine a light on this?
npm: 3.10.9
Windows 10
travis settings:
language: node_js
node_js:
  - "7"
cache:
  directories:
    - server/node_modules
    - client/node_modules
services: mongodb
script: cd server && npm install && npm test && cd ../client && npm install && npm test

I think the issue is that if you run eject on Windows, then it hardcodes Windows paths separators into package.json Jest config. You can fix locally by changing the separators in package.json.
The issue itself is tracked in https://github.com/facebookincubator/create-react-app/issues/1498. You can help by submitting a PR fixing it.

Could you please describe how the package.json should be corrected? I'm not sure what to do with multiple slashes, e.g.:
    "testPathIgnorePatterns": [
      "<rootDir>[/\\\\](build|docs|node_modules)[/\\\\]"
    ],

I tried replacing {2} with / and + with / but both approaches are wrong and cause npm test not to discover any test cases in test files (although the test files are found).


README Update Do Not Use Intended Cache

The changes introduced in https://github.com/Casper-Guo/F1-Data-Visualization/commit/3b77090ad1097820188bd399ad1c15edf7667ce1 causes a regression where the OS-default cache is used.

No fixes needed as all automation workflows now cache to the default destination


ARROW-8097: [Dev] Comment bot's crossbow command acts on the master branch

It changes the previous behavior to clone the repository and branch referenced by the pull request as arrow and execute its crossbow command with its configuration files.

Tested at https://github.com/kszucs/arrow/pull/17


windows server 2012 iometer get io error when virtio-scsi driver

So many io retry，and iometer get io errors, but vhost scsi in storage doesn't  have any abnormal messages, even no io timeout, anyone who has seen this？

Event 153 usually  indicates that a request was timed out in the adapter. IIUC you are using SAN, right. Please make sure that it works properly, otherwise every time when it takes more 30 sec to complete a request storport will trigger an error.
Best,
Vadim.

Thank you so much! It‘s true that there is something wrong with the storage，I have checked it out.
Best,
MacroSAN, Luo.


Gap between results grid and messages

SQL Operations Studio Version: master

Steps to Reproduce:

Run a query with several rows in the resultset

Expected: Result grid is full with messages
Actual: There's a gap between results and messages

@anthonydresser could you verify your recent style updates fixed this?

@kburtram that was there intentionally to separate between grids

do you want me to remove it from every grid?

@anthonydresser personally I prefer it without the space, and probably would optimize around the single resultset case, since that is the most common.
Though for minor issues like this I'm fine either way.  If possible it would be great to ask Smitha's opinion since I'm only going based on what "looks good" to me.


UX Assurance - Date Format Display

User feedback at the last sprint demo indicated a strong preference to have all dates in the application displayed in MMM DD YYYY format (i.e. DEC 12 2021)

[x] Update date format in Intake Team queue
[x] Update date format on Ministry Queue
[ ] Update date format on Request view for Ministry users

Intake Team Queue:

Ministry Queue:

Ministry Request View:

Updated to remove any date pickers, bug ticket is to make consistent displayed dates only

@arielleandrews Wanted to confirm that the date format this ticket was supposed to update to is MMM DD YYYY (ie, FEB 09 2022)

As discussed on Feb 14th, dates in Queues have updated to MMM DD YYYY format (FEB 14 2022). All areas where dates windows have a date picker have not been updated as they will need to be changed across the whole system and this will require a dedicated task with a larger estimate
Great work on the update @jadmsaadaot


Origin/application hooks 3

This is a second stab at the application hooks. This tries to address the issues you raised with the set_connection_sender_transportfile and activating a sender. You were quite correct that this was an issue.
This new version has all the sample resources generated and managed in main.cpp. The sample resources have been added to so that both audio and video examples are created. They are managed so that the sender activations can be done and get the correct information for the sender being activated instead of just always generating hard-coded information which works ok for a single sender/receiver but not in anything more general.
This version uses function pointers which can be lambdas instead of specific function names. Actually, a structure with a number of function pointers is passed in since this seemed cleaner than listing all the functions.
I think this version is current with your most recent changes.

@jwpwh, this doesn't look like a trivial conflict, is there any chance you could update this branch? Thank you.
Regards,
PK

Hi @pkeroulas, I bear responsibility for conflicts here really, as @jwpwh has been kind enough to rebase and make some changes base on feedback on his original PR, but I haven't had time to invest in evaluating how much of this we want to take to master. It is still on my list of things to do...

I am looking at making another update to this and wanted to make sure you were not starting to look at this yourself or if you had any comments you wanted to pass along.
Thanks.

@jwpwh, correct me if I'm wrong, this feature would allow to hook a st2110-ready player/transcoder (like ffmpeg) in order to build a NMOSified video receiver. That would be really really appreciated. Let me know if I can help anyhow. Thanks.

The purpose of this change was to reorganize the example node so that example specific code like the creation of the example resources would be compartmentalized in "application hook" functions. By doing this, it would make it easier to provide a different sent of application hooks which would provide real resources based on, in my case, real signals from an existing system. There is still considerable work to write the alternate set of hooks. The hoped for advantage was that additional changes could be made to the example node, and it would be easier for my application to pick up the new changes. And the changes made would be more obvious as to whether they are just specific examples (code in one of the hook functions) or something more generic like the implementation thread.
A similar set of changes was suggested for the CMake files and those changes were incorporated. (thank you) And it has been much very easy to pick up new changes to the CMake files. These changes are a bit messier so I understand why there is hesitation to pick them up.
Making these changes up-to-date with the current master involves adding some changes for the event/tally examples and probably adding one new hook for processing events. The changes are not real complicated but I need to run the test suites and I am not real adept with Git so it takes a bit more time than I would like. I expect to be done with this latest update around the middle of next week.

Superseded by #77.


Nested multiple transclude fails

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
I like the idea of multiple transcluding, but it seems I've run into a possible bug when transclusion happens from a parent component. The provided error is as follows:
Required transclusion slot 'titleSlot' was not filled.
Minimal reproduction of the problem with instructions
https://plnkr.co/edit/BrPCuekwwbBQARcCmodo?p=preview
Expected behavior
I expect the Plunker to work as expected because I don't understand the difference between using only the ng-child component with its multiple transclusion slots or "sending" the transclusion slots down to the child using another transclude. Did I miss something here?
What is the motivation / use case for changing the behavior?
The code I'm writing would be much more DRY if this works because it allows me to combine/wrap some of my components into bigger components.
Another solution I had is to replace the templateUrl using attributes, but that didn't work out (#11144).
Environment

Angular version: 1.6.1 (but the Plunker is using 1.6.6)

Browser:
- [x] Chrome (desktop) version Version 59.0.3071.115 (Official Build) (32-bit)
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

Unfortunately, this is currently not supported. See https://github.com/angular/angular.js/issues/8914#issuecomment-111457286 for some more details on what is going on under the hood.
I will close this as a duplicate of #8914, which has more context.

I think I understand, thanks for the clarification. The solution I'm doing right now is not a pretty and DRY, but it works nonetheless.
Does Angular 2 have this feature?

Yes, this should work in Angular. Its projection (that's what transclusion is called in Angular) is quite differently implemented and more flexible.

Sounds good! I was indeed very surprised it wasn't working the way I expected because it sounds essential to the whole purpose of transclusion.
In a few months we're going to attempt to migrate to Angular 2 because I feel like especially large applications benefit from it. So I can't wait to be blown away by all the good things I hear about it ;)
Thanks for the information/support.


CON-4756: CrossSelling infos get synced

Coverage increased (+0.4%) to 39.796% when pulling<PHONE_NUMBER>54c855234e89532095400991e894a7 on CON-4756 into 9f6b80369cdfa02167a99961d91c31f282057048 on master.

Coverage increased (+0.4%) to 43.38% when pulling 43244f8fede2abb0603e39be18ad7fd6bc06077e on CON-4756 into 385c90d6a1451822f2098af9f55d8c05f4ef8d19 on master.

Coverage increased (+0.4%) to 43.434% when pulling b9ed63723c840d00898a37252e968e532211c59d on CON-4756 into 937d214e96236221c56d2f56881eed807b4769ef on master.

Coverage increased (+0.4%) to 43.476% when pulling 97d92767c366695600eae9ab33da5076b2e1eae8 on CON-4756 into a9592099c03d0d77c5c9d05202d6e47b7fd7cce8 on master.


remove non-functional phedex inject override

Set and get methods are useless because the underlying functionality has been removed long ago.

Ok, let me fix that one unit test.


Revise content

changes:

Update the repository url
Correct tips of  in geyser/setup
Change text to hyperlink in geyser/api

Thank you!


Delete a few little-used tags

There is no point in having tags only used by one or two products, except for category tags and tags linked to company names. This removed or replace some little-used tags:

Removed managed-mysql and managed-postgresql, which was only used by Amazon RDS products (with little chance to be used elsewhere).
Removed configuration-management, which was really long and only used by cert-manager and puppet. It could be replaced in the future by something like an infra-as-code tag that have more chance to be used on more products.
Replaced api-gateway, which was only used by Kong, by the more general tag web-server.
Replaced library by framework. It which was only by React, which is indeed a library, but using framework makes sense in the context of endoflife.date.
Replaced package-manager, which was used by yarn, by the more generic build-tool tag.

Also:

Set up redirects for removed tags.
Clarify a bit the documentation about tags.

:rocket:


Add Session TTL with Remember me feature

@atamano @Charlesdoiron maybe need some adjustments on CSS for this checkbox

@ottaviano Perhaps the checkbox should be checked by default


error not file found import "./StandardToken.sol";

What folder do I put the Standard Token.sol file to import by the solidity code in the ethereum wallet?

If you want to import this into the Ethereum Wallet (Mist) and deploy it from there, you'll have to copy all of the code without the imports in them. It is then one big piece of code. No imports. :)


Pin someone without video, but see someone else

Describe the bug
I pinned a speaker who had no cam on. But when someone else spoke (as a dominant speaker), I saw their video, but still the name of the pinned person. So it was incorrect.
To Reproduce
Steps to reproduce the behavior:

Join a room with 3 people. The other 2; 1 has a cam on, 1 doesnt
Pin the camless person
Ask the cam person to speak
You now see the label of camless person, but video of cam person.

Expected behavior
See black screen only, with pinned persons name showing always
Screenshots
Again I'm sorry no images yet
Environment (please complete the following information):

OS: [e.g. Ubuntu 18.04] windows 10 x64
Browser: [e.g. Chrome 80, Firefox 72] chrome windows latest
App Version: [e.g. 0.1.0] latest (master)
SDK Version: [e.g 2.1.0] latest
Node.js version: [e.g. 12.14.1] >12.14.1

Additional context
It was a busy room

Thanks for the bug report @binary64!
I tried the steps that you provided and I could not reproduce the issue. Is it possible to provide a screen recording to demonstrate the issue? A Room SID (window.twilioRoom.sid) could also be helpful. Thanks!

Closing due to inactivity. Happy to reopen with more information.


test: Add coverage for past purchase-related 'is fetching' actions

Codecov Report

Merging #75 into master will decrease coverage by 0.9%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   94.03%   93.12%   -0.91%
==========================================
  Files         207      204       -3
  Lines        5754     5560     -194
  Branches      711      699      -12
==========================================
- Hits         5411     5178     -233
- Misses        250      292      +42
+ Partials       93       90       -3

Impacted Files
Coverage Δ

...nt/flux-capacitor/src/core/reducers/is-fetching.ts
56.25% <ø> (-31.75%)
:arrow_down:

...ont/flux-capacitor/src/core/reducers/data/query.ts
0% <0%> (-100%)
:arrow_down:

...ux-capacitor/src/core/reducers/data/collections.ts
20% <0%> (-80%)
:arrow_down:

...apacitor/src/core/reducers/data/infinite-scroll.ts
33.33% <0%> (-54.17%)
:arrow_down:

...t/flux-capacitor/src/core/reducers/data/history.ts
25% <0%> (-51.93%)
:arrow_down:

...efront/flux-capacitor/src/core/reducers/session.ts
50% <0%> (-50%)
:arrow_down:

...ront/flux-capacitor/src/core/reducers/data/page.ts
50% <0%> (-45%)
:arrow_down:

...apacitor/src/core/reducers/data/personalization.ts
55.55% <0%> (-44.45%)
:arrow_down:

...ont/flux-capacitor/src/core/reducers/data/sorts.ts
50% <0%> (-40.91%)
:arrow_down:

...ux-capacitor/src/core/reducers/data/navigations.ts
60.86% <0%> (-39.14%)
:arrow_down:

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7276992...db15fc7. Read the comment docs.


Proposal to add a label dataserver to metric wmo_wis2_gc_downloaded_errors_total

Currently it is not possible to see from the metrics whether the download error occurred at the originator centre or at one of the caches, so I would suggest adding a label dataserver to the metric wmo_wis2_gc_downloaded_errors_total

This seems appropriate and wouldn't be a huge lift


Openshift fails to create clear-container when crio is configured with cgroupfs

CRI-O configured with systemd:
From /etc/crio/crio.conf
cgroup_manager = "cgroupfs"
E0922 13:56:44.262405   14775 kuberuntime_gc.go:123] Failed to remove container "d0af1882ed72a26066dd0c6b82d1d8f270366a224a270633846645365b411aa2": rpc error: code = 2 desc = failed to delete container d0af1882e
d72a26066dd0c6b82d1d8f270366a224a270633846645365b411aa2: `/usr/local/bin/cc-runtime delete --force d0af1882ed72a26066dd0c6b82d1d8f270366a224a270633846645365b411aa2` failed: Container ID does not exist
  (exit status 1)
E0922 13:56:44.265858   14775 kubelet.go:1669] Failed to check if disk space is available for the runtime: failed to get fs info for "runtime": ImagesFsInfo: unknown runtime: remote
I0922 13:56:52.036731   14775 operation_generator.go:609] MountVolume.SetUp succeeded for volume "kubernetes.io/secret/d9866282-9f9d-11e7-96a2-525400123456-default-token-vrh7j" (spec.Name: "default-token-vrh7j")
 pod "d9866282-9f9d-11e7-96a2-525400123456" (UID: "d9866282-9f9d-11e7-96a2-525400123456").
I0922 13:56:52.309831   14775 kuberuntime_manager.go:458] Container {Name:hello-openshift Image:openshift/hello-openshift Command:[] Args:[] WorkingDir: Ports:[{Name: HostPort:0 ContainerPort:8080 Protocol:TCP H
ostIP:}] EnvFrom:[] Env:[] Resources:{Limits:map[] Requests:map[]} VolumeMounts:[{Name:tmp ReadOnly:false MountPath:/tmp SubPath:} {Name:default-token-vrh7j ReadOnly:true MountPath:/var/run/secrets/kubernetes.io
/serviceaccount SubPath:}] LivenessProbe:nil ReadinessProbe:nil Lifecycle:nil TerminationMessagePath:/dev/termination-log TerminationMessagePolicy:File ImagePullPolicy:IfNotPresent SecurityContext:&SecurityConte
xt{Capabilities:&Capabilities{Add:[],Drop:[MKNOD SYS_CHROOT],},Privileged:*false,SELinuxOptions:&SELinuxOptions{User:,Role:,Type:,Level:s0:c3,c2,},RunAsUser:nil,RunAsNonRoot:nil,ReadOnlyRootFilesystem:nil,} Stdi
n:false StdinOnce:false TTY:false} is dead, but RestartPolicy says that we should restart it.
E0922 13:56:52.705302   14775 remote_runtime.go:86] RunPodSandbox from runtime service failed: rpc error: code = 2 desc = cri-o configured with cgroupfs cgroup manager, but received systemd slice as parent: kube
pods.slice/kubepods-besteffort.slice/kubepods-besteffort-podd9866282_9f9d_11e7_96a2_525400123456.slice/
E0922 13:56:52.705410   14775 kuberuntime_sandbox.go:54] CreatePodSandbox for pod "hello-openshift_default(d9866282-9f9d-11e7-96a2-525400123456)" failed: rpc error: code = 2 desc = cri-o configured with cgroupfs
 cgroup manager, but received systemd slice as parent: kubepods.slice/kubepods-besteffort.slice/kubepods-besteffort-podd9866282_9f9d_11e7_96a2_525400123456.slice/
E0922 13:56:52.705450   14775 kuberuntime_manager.go:619] createPodSandbox for pod "hello-openshift_default(d9866282-9f9d-11e7-96a2-525400123456)" failed: rpc error: code = 2 desc = cri-o configured with cgroupf
s cgroup manager, but received systemd slice as parent: kubepods.slice/kubepods-besteffort.slice/kubepods-besteffort-podd9866282_9f9d_11e7_96a2_525400123456.slice/
E0922 13:56:52.705593   14775 pod_workers.go:182] Error syncing pod d9866282-9f9d-11e7-96a2-525400123456 ("hello-openshift_default(d9866282-9f9d-11e7-96a2-525400123456)"), skipping: failed to "CreatePodSandbox" for "hello-openshift_default(d9866282-9f9d-11e7-96a2-525400123456)" with CreatePodSandboxError: "CreatePodSandbox for pod \"hello-openshift_default(d9866282-9f9d-11e7-96a2-525400123456)\" failed: rpc error: code = 2 desc = cri-o configured with cgroupfs cgroup manager, but received systemd slice as parent: kubepods.slice/kubepods-besteffort.slice/kubepods-besteffort-podd9866282_9f9d_11e7_96a2_525400123456.slice/"
E0922 13:56:54.307614   14775 kubelet.go:1669] Failed to check if disk space is available for the runtime: failed to get fs info for "runtime": ImagesFsInfo: unknown runtime: remote
I0922 13:56:59.975948   14775 reconciler.go:201] UnmountVolume operation started for volume "kubernetes.io/empty-dir/d9866282-9f9d-11e7-96a2-525400123456-tmp" (spec.Name: "tmp") from pod "d9866282-9f9d-11e7-96a2-525400123456" (UID: "d9866282-9f9d-11e7-96a2-525400123456").
I0922 13:56:59.976333   14775 reconciler.go:201] UnmountVolume operation started for volume "kubernetes.io/secret/d9866282-9f9d-11e7-96a2-525400123456-default-token-vrh7j" (spec.Name: "default-token-vrh7j") from pod "d9866282-9f9d-11e7-96a2-525400123456" (UID: "d9866282-9f9d-11e7-96a2-525400123456").
I0922 13:56:59.977084   14775 operation_generator.go:684] UnmountVolume.TearDown succeeded for volume "kubernetes.io/empty-dir/d9866282-9f9d-11e7-96a2-525400123456-tmp" (OuterVolumeSpecName: "tmp") pod "d9866282-9f9d-11e7-96a2-525400123456" (UID: "d9866282-9f9d-11e7-96a2-525400123456"). InnerVolumeSpecName "tmp". PluginName "kubernetes.io/empty-dir", VolumeGidValue ""
I0922 13:56:59.999257   14775 operation_generator.go:684] UnmountVolume.TearDown succeeded for volume "kubernetes.io/secret/d9866282-9f9d-11e7-96a2-525400123456-default-token-vrh7j" (OuterVolumeSpecName: "default-token-vrh7j") pod "d9866282-9f9d-11e7-96a2-525400123456" (UID: "d9866282-9f9d-11e7-96a2-525400123456"). InnerVolumeSpecName "default-token-vrh7j". PluginName "kubernetes.io/secret", VolumeGidValue ""
I0922 13:57:00.076861   14775 reconciler.go:363] Detached volume "kubernetes.io/empty-dir/d9866282-9f9d-11e7-96a2-525400123456-tmp" (spec.Name: "tmp") devicePath: ""
I0922 13:57:00.077010   14775 reconciler.go:363] Detached volume "kubernetes.io/secret/d9866282-9f9d-11e7-96a2-525400123456-default-token-vrh7j" (spec.Name: "default-token-vrh7j") devicePath: ""

@chavafg What is kubelet configured with ? If you have kubelet using systemd while you configured CRI-O to use cgroupfs, this will rightfully fail.

I was not specifying any cgroup-driver, and thought the default one was cgroupfs as stated here: https://kubernetes.io/docs/admin/kubelet/
Anyway, by adding these lines, it worked correctly:
kubeletArguments:
  cgroup-driver:
    - 'cgroupfs'

Will update my test with this change.

Openshift most likely will turn systemd as the default cgroup manager by default.
I think we can close that issue as running with a different cgroup manager for kubelet and CRI-O is known to not be working (and will not be supported).

Agree, closing this issue.


Label PRs that change anything in the repo EXCEPT dependabot only PRs.

Ticket
N/A
Changes

What was added, updated, or removed in this PR.

Add support for https://github.com/actions/labeler
Copy a Github CI job to auto-label PRs

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

This PR adds a CI job to auto-label PRs that make changes to any file in the repo using the engineering label. Ideally, we don't label dependabot PRs, which will let us do some smart filtering on PRs based on whether the PR is human-created or dependabot-created.
Testing

Screenshots, GIF demos, code examples or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

I don't think think this PR is relevant anymore. Closing.


Custom dialog icons don't have the correct color tokens

These all have the Info/Warning/Error icons and used the respective colors.
cc @sbatten

I pushed a proper fix. As the dialog is in base it should get all colors as arguments.
What's done in SeverityIcon is a hack. All these rules should go to the corresponding components

To verify:

set "workbench.dialogs.customEnabled": true
close an editor with unsaved content


Some extra features was added to FormElement !

Some extra features was added to Formelement that are => Change Title of AlertDialog for FormElement.TYPE_SPINNER_DROPDOWN and FormElement.TYPE_PICKER_MULTI_CHECKBOX

setDropdownTitle() => Type : FormElement.TYPE_SPINNER_DROPDOWN
setCheckboxTitle() => Type : FormElement.TYPE_PICKER_MULTI_CHECKBOX

Yeah, great. Thanks

Sorry, I don't have them. How to handle plz?

 Anyhow, I'll be starting to maintain this repo again from now onwards.
I really like the features you added, but the code really doesn't match up with the coding standard we have in this repo now. Nevertheless, all the features that you wanted and added here, I will gradually add them here. I'm actually working on a different structure for the project, you can have a look at it in the branch named 'experiment'. That's why I'll be closing this pull request now. I hope you understand.
Thanks a lot for supporting the library and using it.


dim function as in the hue app

Is it possible to dim only that lamps in a group which are on = true or brightness >= 0 (like in the Hue App)

Same discussion as https://github.com/Zefau/ioBroker.hue-extended/issues/16.
I think I will add an option for this then.

https://github.com/Zefau/ioBroker.hue-extended/commit/bb79b4dc66aff991bc661d2fc23d939a0dc4ebfd

@dercaptainbc please test v1.3.0 from Github, which provides an option to only set devices which are on already

@daniel1v regarding our discussion in https://github.com/Zefau/ioBroker.hue-extended/issues/16 I have now added an option. Though, it is only very simplified.

Where I can find the option to actived the function or is it "hard coded"?
Anyway it doesnt work for me. And It doesnt matter if I use _commands, brightness or level the lamps which are off are also set to the brightness value

If you cant see the option please upload the Adapter, do
iobroker upload hue-extended

@Zefau
for me all tests worked perfectly. thank you for adding this option. this makes the whole thing much more useable for me. :)

Unfortunately, it doesn't work for me at all. When I change the DP 'on' or 'level' I can see in the log that the command arrives but the lamps in the groups are not switched. Single Lamps can be switched.
I already tried with upload command.

Delete the states and restart the adapter. Does that help?

@dercaptainbc have you had the chance to delete the states, restart the adapter and test again?
If not, please set the instance to debug and provide the log when setting a lamp. Thanks!

@dercaptainbc

Hi @Zefau sorry for the delay I'll test it today. I'll give my feedback tomorrow.

  Ich muss erst jede einzelne Lampe einschalten.

@dercaptainbc Kannst du nochmal die neue Version 1.3.4 von Github probieren, ob es damit geht?

@dercaptainbc

@dercaptainbc


Utils::pathPrefixedByLanguageCode doesn't detect homepage with prefix without trailing slash

A URL like /en, without trailing slash (which you get automatically from the initial language redirect and also from the language switch plugin) will not be detected by Utils::pathPrefixedByLanguageCode. /en/ works as expected.

I fixed the issue in #2512

Thanks for the fix, however I'm not sure this specific thing is really fixed - I see you fixed the session issue (in a different, probably better way than I did), but I can't see how you fixed Utils::pathPrefixedByLanguageCode, am I missing a commit?


Add super_feature list to SpecialCoverage model

@benghaziboy @mparent61 this creates a separate super_feature json list for SpecialCoverage

Coverage decreased (-0.02%) to 86.248% when pulling 8249c09cc86b63e5cd0440688b3f72905017763d on sf-sc into 2f12e6d92e4c27ec0c919f4df6deda16aab35e85 on master.

Coverage decreased (-0.2%) to 85.988% when pulling b844ff1accc2878c07ceb1d860f59114c523de58 on sf-sc into f8c2b0fb382a9b5cefac57b0472f7581b06a6ec8 on master.


Can you Scan 1D Barcodes

Hi, Thanks for such a useful barcode scanning utility for Blazor.
I dont seem to be able to scan 1D barcodes using the tool, is that something possible as a lot of applications still depend on 1D symbology barcodes.
if yes, can you guide how?

In Readme.md has a gif

Same issue. QR Code works fine, but cannot scan barcode (1D).

Ok, yes it scans. I think my barcode was bad or something. I tried some others from the web and it worked.


Handle stateful restart of ovs network driver

restore ovs driver's oper state on a stateful restart to preserve port-number information
On getting endpoint create check if an oper state for the endpoint already exists. If it exists and doesn't match the received config then unprogram the stale info before proceeding with handling the create. The CreateEndpoint call becomes a noop if the configuration matches the oper state.
This enables the stateful restart of the driver but following condition is not yet handled:

changing the host binding of the endpoint while the driver was down, which may leave stale state on the previous host.

Added tests for this change.

Fixes #47
Signed-off-by: Madhav Puri<EMAIL_ADDRESS>

ping @jainvipin
I have incorporated the comment and rebased the change. PTAL


"Create shortcuts here" on drag & drop doesn't work.

Description
With classic file explorer I would drag&drop a .exe from anywhere with the right click to the desktop and I would select "create shortcuts here".
With Files the right drag&drop doesn't work, but the left drag&drop offers something similar

However clicking on "create shortcut here" doesn't work.
Simply no shortcut is added to my desktop.
Steps To Reproduce

left drag&drop any file from a folder to the desktop
select "create shortcuts here"

Steps to fix
use file explorer
Files Version
Version : <IP_ADDRESS> OS Version: 10.0.19044.2251
Windows Version
10
Relevant Assets/Logs
I emptied the debug.log, did the create shortcut and it was still empty after.

Noticed this as well. My current workaround in 2 steps: create the shortcut in the current folder and then move the shortcut per drag&drop

I tried that too but somehow the shortcut created this way didn't work.
My workaround is copying the path of the parent folder from address bar, paste it in File Explorer and use that to make the desktop shortcut.


Consider copying test project to this repo

Right now, the project that's used for testing is in another repository. That's a nice separation for now. But if there's a straightforward way to store the project in this repo and test against it, that would be much better.
I imagine this would involve cloning this repo, and then cp/rsync to the temp testing directory.

See #12.


Changing connectionStringName dynamically

Hi!
Type: Bug
NLog version: (e.g. 4.3.5)
Platform: .Net 4.6
Current NLog config (xml)
<?xml version="1.0" encoding="utf-8" ?>
<nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:schemaLocation="http://www.nlog-project.org/schemas/NLog.xsd NLog.xsd"
      autoReload="true"
      throwExceptions="true"
      internalLogLevel="Debug" internalLogFile="C:\logs\App\nlog.txt" >

  <variable name="myvar" value="myvalue"/>

<targets>
    <target name="file"
        xsi:type="File"
        fileName="C:\logs\App\log.log"
        layout="
-------------- ${level} (${longdate}) --------------${newline}
${newline}
Call Site: ${callsite}${newline}
Line Number: ${callsite-linenumber}${newline}
Exception Type: ${exception:format=Type}${newline}
Exception Message: ${exception:format=Message}${newline}
Stack Trace: ${exception:format=StackTrace}${newline}
Full Exception: ${exception}${newline}
Additional Info: ${message}${newline}" />

    <target name="database"
      xsi:type="EntityFramework"
            connectionStringName ="ConnectionStringA"
            commandText="exec InsertLog
                @userName,
	              @logType,
	              @details,
	              @exceptionType,
	              @exceptionMessage,
	              @exceptionStackTrace,
	              @exceptionInnerInfo
            ">
      <parameter name="@userName" layout="UserName"/>
      <parameter name="@logType" layout="${level}"/>
      <parameter name="@details" layout="${message}"/>
      <parameter name="@exceptionType" layout="${exception:format=Type}"/>
      <parameter name="@exceptionMessage" layout="${exception:format=Message}"/>
      <parameter name="@exceptionStackTrace" layout="${exception:format=StackTrace}"/>
      <parameter name="@exceptionInnerInfo" layout="${exception:method:maxInnerExceptionLevel=5:innerFormat=shortType,message,method}"/>
    </target>
  </targets>

  <rules>
    <logger name="*" minlevel="Trace" writeTo="file" />
    <logger name="database" minlevel="Trace" writeTo="database" levels="Warn,Error" />
  </rules>
</nlog>

Configuration of the connectionStringName using the API:
public void ChangingConnectioniStringName(string connectionStringName, Exception e)
        {
            var config = LogManager.Configuration;
            var dbTarget = (EntityFrameworkTarget)config.FindTargetByName("database");
            dbTarget.ConnectionStringName = connectionStringName;
            LogManager.ReconfigExistingLoggers();
            logger.Error(e, message);
        }

My code uses Nlog and Entity Framework.
I  am trying to edit the connection string name dynamically, the DBs share the same table's schema.
The connectionStingName should change after using my "ChangingConnectioniStringName" function, that uses the API. I could see that the connectionStringName in the target is changed to the new connectionStringName, but the logger.Error line is saving the message and the exception details in the hard coded (old) connectionStringName database.
I was expecting to see that the data will be written in the new connectionStingName database.
Thanks

I think the connection is kept open. We need a force close I guess

I checked the code and this should work
See
        private void EnsureConnectionOpen(string connectionString)
        {
            if (this.activeConnection != null)
            {
                if (this.activeConnectionString != connectionString)
                {
                    InternalLogger.Trace("DatabaseTarget: close connection because of opening new.");
                    this.CloseConnection();
                }
            }

            if (this.activeConnection != null)
            {
                return;
            }

            InternalLogger.Trace("DatabaseTarget: open connection.");
            this.activeConnection = this.OpenConnection(connectionString);
            this.activeConnectionString = connectionString;
        }

Please check the internal log

Thank you so much for the quick response!
What does the this referred to?

See link in text of https://github.com/NLog/NLog/issues/new

Is this still an issue?
I'm pretty sure it should work but too bad I haven't found time to debug stuff

Hi,
Yes, this is still an issue.
The code in the EnsureConnectionOpen is not working since I cannot access all of these methods,
and my code is not changing the connection properly.

this is strange as before every write, we rebuild the connectionstring:
https://github.com/NLog/NLog/blob/8ec0bf3593c208bbe2eddf669b7f48046461cc63/src/NLog/Targets/DatabaseTarget.cs#L492
and it's using the ConnectionString property: https://github.com/NLog/NLog/blob/8ec0bf3593c208bbe2eddf669b7f48046461cc63/src/NLog/Targets/DatabaseTarget.cs#L540-L545
So, only changing ConnectionString would be enough

Please fill in these texts:

Hi! Thanks for reporting this feature/bug/question!
Please keep / fill in the relevant info from this template so that we can help you as best as possible.
Type (choose one):

Bug
Feature request
Question

NLog version: (e.g. 4.2.3)
Platform: .Net 3.5 / .Net 4.0 / .Net 4.5 / Mono 4 / Silverlight 4 / Silverlight 5 / Xamarin Android / Xamarin iOs
Current NLog config (xml or C#, if relevant)
<nlog>
  <targets>
  </targets>
  <rules>
  </rules>
</nlog>

In case of a BUG:

What is the current result?
What is the expected result?
Did you checked the Internal log?
Please post full exception details (message, stacktrace, inner exceptions)
Are there any work arrounds? yes/no
Is there a version in which it did worked?
Can you help us by writing an unit test?

in case of a FEATURE REQUEST:

Why do we need it?
An example of the XML config, if relevant.

We should not to discuss the problem on DatabaseTarget. Because @danaERadwin is using EntityFrameworkTarget.
If I found true source code, there are some differences between our DatabaseTarget . @danaERadwin  check and verify the repository.
It does not work as our DatabaseTarget:

It does not build connection string before writing a log.

It uses the same connection once it instantiate one.

It also set KeepConnection to true by default. So that connection does not close  after writing log. Therefore, probably, it continue to use the same connection even if you reconfig.

What can you do:

Configure KeepConnection to false explicitly and test again.
If there is not any specific reason to use EntityFrameworkTarget, retry with DatabaseTarget.

Indeed, this question is wrong here. We don't supply the entity framework target and so we can't support it.


exclude/tag strings that match expert patterns

For collecting community knowledge it should be easy to add raw entries by just adding to a file for example:
string; explanation; tags
...
too many length or distance symbols; GZIP text exception; gzip
```

Would also be cool to capture and explain multi-line strings, like:
<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
  <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
    <security>
      <requestedPrivileges>
        <requestedExecutionLevel level='asInvoker' uiAccess='false' />
      </requestedPrivileges>
    </security>
  </trustInfo>
</assembly>

should enumerate all the Windows API functions (and DLLs) so that they can be reasoned about (e.g., API not part of the import table).


Remove CSVConfig and use CSV Generator for configurable inputs and output

Description of the change:
Continuation of #2407 to implement the CSV generator.

cmd/operator-sdk/olmcatalog: remove config flag, add include flag, use CSV and package manifest generators

internal/generate/olm-catalog: implement CSV generator, moving most of the code from internal/scaffold/olm-catalog verbatim. Also removed CSV config

doc: remove CSVConfig documentation, update CLI docs

Currently this gets #2407 rebased with the master and breaks up the internal/generate/olm-catalog pkg changes, and the internal/generate/testdata/ manifests changes into separate commits for ease of reviewing.
TODO:

Change --include flag to --inputs to allow configuring the CSV generator Inputs field for Deploy and API directory paths  e.g:
--input deploy=./deploy/production/...,apis=./pkg/apis
Remove Filters field from generator config since its UX was ambiguous
Add flag --outputDir to set CSV Generator Output field to set the output root directory for the olm-catalog bundles directory.

Motivation for the change:
Resolves #2493

@estroz No need to review until I finish the TODOs but a quick sanity check over the first commit would be helpful to ensure I've carried forward the necessary changes from #2407
Had to untangle that PR a bit to rebase and split up the commits since quite a few changes from that had already gone into master.

Yeah I'll remove the Helm tests from this. I initially split it up as a separate commit but a follow up would be easier to review.

@estroz I've done some manual tests and have this mostly working.
I still need to clean up a couple of things plus update the unit tests, but I've got a couple of questions that came up as I was refactoring.
I've marked them as TODO comments if you could take a look at those. Just the 2nd commit which has my changes to your old PR.

@estroz That should be most of the refactoring done in the last two commits.
I've tested it manually so this should be good for a round of review if you want to take a look at the last two commits.
I'm working on more proper unit test cases specifically for configuring inputs and outputDir for the CSV and package manifest generators but I'll add that in a  separate commit.

@estroz Some updates as requested and other comments. PTAL.
Still working on the new unit tests.

@estroz Ready for a full review.
This last commit adds tests for both the CSV and Package Manifests generators to generate files from a non-standard project layout with Inputs and OutputDir specified.
These tests should also be more complete in that they test the full path for each generator by calling g.Generate()
Also I've removed the requirement of projutil.MustInProjectRoot() for the cmd as discussed above.

@aliok I think we have most of the design changes sorted out.
It would be really helpful if you could give this a try for your use case with the knative eventing operator.
Note that we've changed --include to --inputs where you can pass in the path to your "deploy or operator manifests" directory.
You can also specify the path for the apis directory as well if needed.
See the CLI docs for this change:
https://github.com/operator-framework/operator-sdk/blob/459e9db87f96e83d7937fa088f01e1164b92793b/doc/cli/operator-sdk_generate_csv.md
Also note, --output-dir is back except now it's only the root directory where the entire bundle tree olm-catalog/... will be scaffolded. The default is deploy/.
So from your previous example this should be something along the lines of:
GO111MODULE="on" operator-sdk generate csv            \
  --inputs       "deploy=config" \
  --from-version  "0.11.0"       \
  --csv-version   "0.12.0"       \
  --operator-name knative-eventing-operator \
  --csv-channel   alpha                     \
  --default-channel                         \
  --verbose

And the generator won't check for build/Dockerfile anymore in the project directory.
Let us know if you spot any issues.

@hasbro17
Just gave it a try. Looks like the command is not really using the previous CSV file.
CSV for 0.11.0: https://gist.github.com/aliok/47a5c393e034395e5981aeb7c1a0d979
CSV for 0.12.0, generated by the command: https://gist.github.com/aliok/2d954f480e1952638cf732072f6fa0db

Pretty much everything that should come from the previous CSV doesn't exist in the new CSV file.
I see lots of files are skipped in the logs.

These make me wonder if I am doing something wrong.
Let me know what I can do to help resolving this issue.
Just in case you needed, here's how I do my tests:

Checkout https://github.com/aliok/eventing-operator/tree/operator-sdk-tests-for-hasbro
Execute the command
Compare with 0.11.0 CSV file in that branch
Compare with proper 0.12.0 file (in master)

Command
GO111MODULE="on" operator-sdk generate csv            \
  --inputs        "deploy=config,apis=pkg/apis" \
  --from-version  "0.11.0"       \
  --csv-version   "0.12.0"       \
  --operator-name knative-eventing-operator \
  --csv-channel   alpha                     \
  --default-channel                         \
  --update-crds                             \
  --verbose

Logs:
DEBU[0000] Debug logging is set
INFO[0000] Generating CSV manifest version 0.12.0
INFO[0000] Skipping manifest /v1, Kind=ConfigMap
WARN[0000] No WATCH_NAMESPACE environment variable nor reference to "metadata.annotations['olm.targetNamespaces']" detected in operator Deployment. For OLM compatibility, your operator MUST watch namespaces defined in "metadata.annotations['olm.targetNamespaces']"
INFO[0000] Skipping manifest rbac.authorization.k8s.io/v1, Kind=RoleBinding
INFO[0000] Skipping manifest rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding
INFO[0000] Skipping manifest /v1, Kind=ServiceAccount
INFO[0000] Directory for API operator.knative.dev/v1alpha1, Kind=Eventing does not exist. Skipping CSV annotation parsing for API.
INFO[0000] Directory for API operator.knative.dev/v1alpha1, Kind=KnativeEventing does not exist. Skipping CSV annotation parsing for API.
INFO[0000] Fill in the following required fields in file knative-eventing-operator.v0.12.0.clusterserviceversion.yaml:
        spec.description
        spec.keywords
        spec.provider
DEBU[0000] CSV generator writing deploy/olm-catalog/knative-eventing-operator/0.12.0/knative-eventing-operator.v0.12.0.clusterserviceversion.yaml
DEBU[0000] Package manifest generator writing deploy/olm-catalog/knative-eventing-operator/knative-eventing-operator.package.yaml
DEBU[0000] Skipping non CRD manifest config/config-logging.yaml
DEBU[0000] Skipping non CRD manifest config/config-observability.yaml
DEBU[0000] Skipping non CRD manifest config/operator.yaml
DEBU[0000] Skipping non CRD manifest config/role.yaml
DEBU[0000] Skipping non CRD manifest config/role_binding.yaml
DEBU[0000] Skipping non CRD manifest config/service_account.yaml

Hi @aliok,
The scenario described by you in https://github.com/operator-framework/operator-sdk/pull/2511#issuecomment-586178022  shows has no relation with this PR and added in https://github.com/operator-framework/operator-sdk/pull/1396. See here. And then, by looking in your CSV I understand that it happens because your operator has not this ENV VAR since is a non-SDK one. I think that to test this PR with you can just add it for now.
Hi @estroz,
Shows that this scenario is a breaking change. Could we not just add  the WATCH_NAMESPACE  as :
              - name: WATCH_NAMESPACE
                 valueFrom:
                   fieldRef:
                     fieldPath: metadata.namespace

in this scenario in order to be compatible with the non-SDK projects as well?
c/c @hasbro17

The scenario described by you in #2511 (comment) shows has no relation with this PR and added in #1396

@camilamacedo86 There's more changes incoming so please hold off further reviews at the moment.
And @aliok's use case is pretty much what this PR is for. Turns out I forgot to account for an upgrade from an existing CSV in my unit tests and there was a subtle bug in the generator in not using the OutputDir for the expected olm-catalog location.
So I've just pushed a bug fix for that but I'm adding more unit tests to cover the upgrade path from existing csv bundles in a different output dir scenario.
@aliok Thanks a lot for trying this out. Looks like I can get your csv upgraded with all the correct metadata from the previous one now.
https://gist.github.com/hasbro17/758a62f3b49de6df89cb98c7e296091b
However I still need to figure out why it's not populating your spec.customresourcedefinitions.owned field from your existing CRDs.
The spec and status descriptors would have to come from the CSV annotation comments defined in your pkg/apis/... types but I have to debug why it's not populating the bare minimum for your owned CRDs.
I'll update this once I have that sorted out.

The scenario described by you in #2511 (comment) shows has no relation with this PR and added in #1396.

@camilamacedo86 that's from 6+ months ago and in all my trials I had that env var missing. I don't think it is really related, but I might be wrong.
@hasbro17 Just gave it a try again. Looks much better: installModes and all metadata are there but as you said no spec.customresourcedefinitions.owned.
Thanks for the hard work!

@aliok I figured out why your apis directory was being skipped when parsing for CSV annotation comments, which results in an empty spec.customresourcedefinitions.owned field.
Your API types are located in pkg/apis/eventing/v1alpha1. However your actual group name is operator.knative.dev.
The CSV generator will use the group name found in your CRD manifest to look for the associated type definition in pkg/apis/operator/v1alpha1. So that's why it was skipping when it couldn't find the types in the expected directory.
However I think we should be able to relax this restriction for single group APIs so that you can have some/random/path/... for your api types directory. That's your current case.
But for multi-group apis I think the CSV generator might require <api-dir>/<group>/<version>. I'll have to double check this with @estroz

@estroz @camilamacedo86 After lots of misadventures with gengo and much hand wringing over how to sidestep them, this should be ready for another review now.
Noticeable updates:

Refactored internal/generate/olm-catalog/descriptor/descriptor.go quite a fair bit to allow the CSV generator to parse api directories with different layouts. Previously it was hardcoded to only look at <api-dir>/<group>/<version>. I've expanded this to add <api-dir>/<version>  and to recursively look for <version> as well. We'll need this for kubebuilder's multi and single group layouts. @estroz PTAL at this in particular.
Added quite a few unit tests for the descriptor and csv tests to cover different cases for multi/single group pkg layouts, different input/outputs and upgrades from existing CSVs. You might want to ignore the additional test manifests.
Replaced the key/value --inputs flags with --deploy-dir --apis-dir --crd-dir. @camilamacedo86 This was per our earlier discussion so we can better maintain individual flags.
A subtle bug where the CSV generator did not error out when it failed to walk the deploy directory for manifests. Fixed and added a specific test for this.
TODOs and caveats marked for later.

@aliok If you still have time to give this another shot I think I've handled all the issues from before.
Note that the --input flag has been replaced with --deploy-dir --apis-dir for specifying the api and deploy directories. See the CLI reference for that update.
Based on the branch you've provided earlier the following should work.
operator-sdk generate csv \
--csv-version="0.12.0" \
--from-version="0.11.0" \
--deploy-dir=config \
--operator-name=knative-eventing-operator \
--csv-channel=alpha \
--default-channel \
--update-crds

Although as I mentioned before, your existing metadata in spec.customresourcedefintions.owned such as spec/status descriptors won't be generated since you need to add the CSV annotation comments in your type definitions for that.
Lastly while the CSV generator should work for your case, my earlier comment on the layout of the API types directory still holds:

Your API types are located in pkg/apis/eventing/v1alpha1. However your actual group name is operator.knative.dev.
The CSV generator will use the group name found in your CRD manifest to look for the associated type definition in pkg/apis/operator/v1alpha1. So that's why it was skipping when it couldn't find the types in the expected directory.

The CSV generator normally expects a layout of <api-dir>/<group>/<version> for multiple groups or <api-dir>/<version> for single group APIs.
The layout in the knative eventing-operator is neither since it has the wrong group name in the layout.
So the CSV generator makes a best effort to find the right API types package for v1alpha1 but this will be prone to collisions if you add multiple groups which also have the same version.
So it's okay for now but ideally you might want to correct the pkg layout in the future if possible.

@camilamacedo86 The linter in CI is complaining about maligned structs:
$ golangci-lint run --disable-all --enable=maligned
internal/generate/olm-catalog/descriptor/descriptor_test.go:43:16: struct of size 120 bytes could be of size 112 bytes (maligned)
	subTests := []struct {

Have you seen this before and how to fix this when you first turned on this flag?

@hasbro17
I think we're in a very very good shape. I now can use operator-sdk to generate CSV for upstream Knative eventing operator.
Thank you very much for your hard work!

Although as I mentioned before, your existing metadata in spec.customresourcedefintions.owned such as spec/status descriptors won't be generated since you need to add the CSV annotation comments in your type definitions for that.

That's fine. Nothing you need to worry about. Thanks for the heads up.

Your API types are located in pkg/apis/eventing/v1alpha1. However your actual group name is operator.knative.dev.

Same as above. Thanks!
From my point of view, we can merge this PR and I can start using it. Thanks very much!

@estroz I've addressed your comments above. Plus as I was refactoring I realized one case where the owned CRD description updates were being silently skipped if the project type wasn't determined as Go type for some reason (e.g different layout).
I've refactored updateDescriptions() to make that case more clear and add a log for when that happens. You can see the commit just  for that.

@camilamacedo86 PTAL as well. The csv generate cmd should now have separate flags for its inputs per our earlier discussion.

@hasbro17 let me know if you need another test drive when you make changes. I will be happy doing that

@estroz @camilamacedo86 PTAL again.
I had to rebase again to fix the CHANGELOG but you can take  a look at just the last commit.
I've added the cobra cmd example for default and custom inputs paths.
@camilamacedo86 I've reduced the flag help text verbosity by moving all the extra caveats and info for each flag to the Long section.
Also added a warning if the command is not running from project root. Not error-ing out like we did before because not all projects have "build/Dockerfile" at the root.
@aliok Thanks for offering to test this again but I think this should be alright. It's mostly the same from when you last tested it. Just added the finishing touches for docs etc and we should hopefully have this merged very soon.

Missed this comment: https://github.com/operator-framework/operator-sdk/pull/2511/files#r396573444
Going to address the issue of --crd-dir flag only being used to copy CRD manifests but not being used to source those manifests for when we actually populate the CSV's spec.customresourcedefinitions.owned.

@estroz PTAL.
I've removed the overlap between --deploy-dir and --crd-dir so that now updateCSVFromManifests() will use the path from --crd-dir to parse the CRD CR manifests.
And we're no longer doing recursive filepath.Walk()s for either deploy or crds directories.
Side-note: This brings up another issue for me on the kubebuilder integration side where CRD and CR manifests are separate directories, and so are Deployment and RBAC manifests.
But I'm leaving that for later.
I've added TODO's to allow multiple paths for --deploy-dir and --crd-dir in the future.

@hasbro17 to fix the unit test error:
$ mkdir -p ./internal/generate/testdata/go/emptydir
$ touch ./internal/generate/testdata/go/emptydir/.keep

I had to do this in #2729.

Sigh
@estroz Any clue why the scorecard test for bundle validation might be failing? I'm not sure if after rebasing from master if the scorecard now relies on any testdata manifests that I've modified/moved around in this PR.
https://travis-ci.org/github/operator-framework/operator-sdk/jobs/669505119#L1244
olm:
	Bundle Validation Test
	CR: example-memcached
	Labels:
		"necessity":"required"
		"suite":"olm"
		"test":"bundlevalidationtest"
	Errors:
		unable to find the OLM '\''bundle'\'' directory which is required for this test
	Provided APIs have validation       pass
	CR: example-memcached
	Labels:
		"test":"crdshavevalidationtest"
		"necessity":"required"
		"suite":"olm"

Or if scorecard is using generate csv to generate the bundle directory and somehow failing to.
Going to dig into this a bit.

@estroz Thanks for the fix 🙏
Had to reset CI a few times to get marker to play nice but all clear in the end.


Outdated dependency repo

The dependency repo has changed location, so the pod install fails
https://github.com/GNOME/libxslt.git is the new repo

Thanks! Looks like GNOME officially moved to GitLab, so I've updated the URL to https://gitlab.gnome.org/GNOME/libxslt.git.


update motion images

close #4

As all issues are resolved, I think that we can release new version.


Hue High Availability?

This service gives the ability to install Hue on multiple hosts I assume like the other Ambari services, but does it provide the ability to load balance them via Nginx, for example?
I know Cloudera Manager provides the option to setup a load balancer, but could this be done in Amabri?

http://gethue.com/using-nginx-to-speed-up-hue-3-8-0/
https://www.cloudera.com/documentation/enterprise/latest/topics/cdh_hag_hue_config.html

In a Jinja template for Nginx, you could so something like
upstream hue {
  ip_hash;

  # List all the Hue instances here for high availability.
  {% for server in serverlist %}
    server {{ server }}:8888 max_fails=3;
  {% endfor %}
}

Hi cricket007:
At present,this service dosen't provide the ability to load balance on multiple hosts. But I will update this service based on the information given. Thank you!

Cool. I'd consider making a pull request, but haven't had the opportunity to learn about making Ambari services yet.


Add harvest level modifications

Add the ability to modify harvest levels of blocks:

Set harvest level of tools
Remap existing harvest levels (1 -> 3, 2 -> 5, etc)
Change harvest level of specific blocks.

Also need to modify TiCon materials (done) and harvest level names (not done)


AV-75643 Removing depends_on from appservices

Jira

AV-75643

Description
Removed the depends_on from appservices.tf as it isn't necessary anymore.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
[ ] New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
[ ] This change requires a documentation update
[ ] Documentation fix/enhancement

Manual Testing Approach
How was this change tested and do you have evidence? (REQUIRED: Select at least 1)

[x] Manually tested
[ ] Unit tested
[ ] Acceptance tested
[ ] Unable to test / will not test (Please provide comments in section below)

Testing
Tested as part of this ticket AV-75406
Required Checklist:

[x] I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
[x] I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
[x] I have added any necessary documentation (if required)
[x] I have run make fmt and formatted my code

Further comments

Can you please add the validation proof

closing as stale, please reopen whenever we are ready for a review. thanks


Why not add industrial trains?

Suggestion Type
Train simulation mechanics
Suggestion
Hey,
I know that the mod is a lot in the direction of passengers but I was thinking,
Is it possible to add a train for transports items and being able to insert/get from them using hopper or another block ?
Assets
.
Implementation Details and References
.

通过货物装载器。
plz translate

By train cargo loader and train cargo un loader.

I never saw this item in the item list sorry, gonna check right now ^^'

Oh I never saw them, thanks ^^'


why not imagenet also?

do you need machines to test?

I have only 4 Titan X cards, takes a long time to train anything