maintain history of past search and replace

Issue Type: Feature Request
A comparative editor slickedit maintains a history of past regex used in the current session.  This is missing from vscode in that if I start editing a new file I don't have the regex history of edits on other files immediately available for the current file.  slickedit's feature in this regard is imperfect in that updating a past regex for a new search/replace will replace the previous... the history of regex could be more carefully managed for a user.   regex are an extremely powerful and fast way to perform consistent updates within and across files.
Best regards,
Ted
VS Code version: Code 1.62.2 (3a6960b964327f0e3882ce18fcebd07ed191b316, 2021-11-11T20:56:38.428Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No
Remote OS version: Linux x64 3.10.0-1160.24.1.el7.x86_64

You can access history by using the up/down arrow keys

I can easily open a new file and have no past regex search and replace to chose from via up/down arrows in which case I have to retype the regex from memory and hence the original ticket.


jadibot.localplayer.dev

##
Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] You have put a full stop (.) at the end of each of the CNAME, MX and NS records.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.

Description

Link to Website

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

Please make a new PR with the domain you want, which doesn't delete any other domains.


Archiving github issues within the Modernisation Platform project

User Story
There is a limit in the number of tickets we can have within a github project - which is 1200. We are around this number now. When we hit the limit we are no longer able to raise tickets.
Tickets can be archived within the project. There is currently a beta version that might solve the problem, but there are limitations to the beta version - meaning it doesn't appear to be suitable.
This ticket is to look at how we can address this in the short term - while we are waiting for the beta version to be fully implemented.
This ticket is to identify and implement an archiving process.
We will still need to be able to view these tickets at a later date.
Value / Purpose
If we don't do this people will be unable to raise new tickets
Useful Contacts
No response
Additional Information
No response
Proposal / Unknowns
No response
Definition of Done

[ ] Archiving option developed and tested
[ ] Process implemented
[ ] Documentation created

This is resolved now (archived 10 sprints worth of issues manually)


update cloud-provider-openstack tests to use block storage v3

Currently, all the cloud-provider-openstack tests use block storage
version v2 which is deprecated. This commit updates to use latest
version v3 instead.

/assign @adisky @dims

approve

approved


bevy_lint: release.md could be slightly clearer

I left some comments/questions on #163 post-merge that I think could be addressed. They're mainly just requests for improved clarity.
I'll list them out here:

Is this freeze automatic or is this something maintainers just need to be aware of? https://github.com/TheBevyFlock/bevy_cli/blob/bf0d951d89131668d487ad73701b410db39f6659/bevy_lint/docs/release.md?plain=1#L11

Should we change the phrasing to read Paste and fill out/Paste and modify? https://github.com/TheBevyFlock/bevy_cli/blob/bf0d951d89131668d487ad73701b410db39f6659/bevy_lint/docs/release.md?plain=1#L18

It might help to more clearly identify parts that need to be filled out/replaced. Maybe like <One-sentence summary of changes> or [One-sentence summary of changes].
If we want to make use of comments, we could also do something like <!-- One-sentence summary of changes -->. This has the benefit of not rendering in case it's accidentally missed, and doesn't clutter up the preview as you work on it.
Not a big deal for this tiny snippet, but might be worth setting a style now for the future (e.g. issue templates). https://github.com/TheBevyFlock/bevy_cli/blob/bf0d951d89131668d487ad73701b410db39f6659/bevy_lint/docs/release.md?plain=1#L21

How do we determine what toolchain and Rust version to put here? Is it just the one from rust-toolchain.toml and the MSRV? https://github.com/TheBevyFlock/bevy_cli/blob/bf0d951d89131668d487ad73701b410db39f6659/bevy_lint/docs/release.md?plain=1#L23

Is this freeze automatic or is this something maintainers just need to be aware of?

As I started saying in https://github.com/TheBevyFlock/bevy_cli/pull/163#discussion_r1823590313, it's something maintainers need to be aware of. The only two things that are required to occur during the feature freeze is publishing the Github release and making the post-release PR, which should take less than an hour, so this is unlikely to ever become a problem.

Should we change the phrasing to read Paste and fill out/Paste and modify?

I like Paste and fill out! Good call, since it signals that things need to be changed in the template.

It might help to more clearly identify parts that need to be filled out/replaced. Maybe like <One-sentence summary of changes> or [One-sentence summary of changes].

I considered this, but wasn't sure what format to use. Do you know if the Bevy engine has a specific style?

How do we determine what toolchain and Rust version to put here? Is it just the one from rust-toolchain.toml and the MSRV?

bevy_lint will eventually have a README.md with a table of linter versions corresponding to Rust versions. You can find the toolchain version from there are rust-toolchain.toml.


[FEATURE] Lucene Based k-NN search support

Is your feature request related to a problem?
Recently Lucene started building in-house Approximate k-NN search in Java based on HNSW algorithm. k-NN plugin already has support for HNSW based out of C library namely NMSlib. By having the Lucene based HNSW support, we will be able to provide AKNN functionality independently outside of k-NN plugin with out having to rely on the NMSlib or FAISS. This will unlock the platform dependency issues because of C based libraries.
As a prerequisite we need to introduce new data type dense_vector in OpenSearch core and build Field Mappers to index data from this field to Lucene graphs.

I added the roadmap label since this is on the project roadmap.

Demo feedback (8/3/22):
Outcome:
Approved, ship it.
Action Items/Follow up:

Connect with documentation team to document limits and approaches.
Follow up on performance and scale.
Begin exploring opportunities to leverage UI to drive insights/run searches.


use boolValue to set usesGCM and gcmSandbox

When testing push notifications in a production ad-hoc build on iOS, i noticed that the gcmSandbox option was being set to YES even though the javascript was passing false.
Upon debugging it looks like the return values were NSStrings @"1" or @"0" for true and false, both of which when casted directly to BOOL return YES (since they are both non-nil).   Using boolValue seems to set the value correctly.
i.e.
(BOOL) @"1" = YES
(BOOL) @"0" = YES

[@"1" boolValue] = YES
[@"0" boolValue] = NO

That seems to be correct, good catch @maeldur. Thanks.


Add bootOptions to cp/md tinkerbellmachine template, fix unit-tests

Issue #, if available:
Description of changes:
Latest release of CAPT, supports bootOptions in the TinkerbellMachineSpec. In EKS-A this translates to tinkerbellMachineTemplate having those fields configurable for Control-Plane and MachineDeployment. Default bootMode to netboot in this change. I will follow up with the conditional logic to toggle between netboot and isoboot in a different PR that'll introduce L3 provisioning changes to EKS-A.
Also, update Smee flags as all smee flags start with SMEE_ prefix and the previous  BOOTS_KUBE_NAMESPACE was invalid. Remove PUBLIC_SYSLOG_IP  as it is not a valid flag in the latest version.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Improve benchmark script

Rename run_all_benchmarks.sh -> run_benchmarks.sh as "all" in the name implies that this script runs benchmarks for all pallets and doesn't have selective pallet support. Maybe misleading to some developers. Perhaps the old run_benchmarks.sh can be removed or deprecated as this new script seems to do its job already.

Instead of creating a new make target for each pallet (just think of 1000s pallets), we can create one universal target that passes pallet name as an argument. Something like this:
.PHONY: benchmarks
benchmarks:
  ./scripts/run_benchmark.sh -p $(pallet)

Then call it with:
$ make benchmarks pallet="<pallet_name>"

A few comments:

make doesn't work that way; you can't pass parameters to targets like a standard command-line. You could, perhaps, do this:

PALLETS=<pallet_name[,pallet_name]> make benchmarks

and change the target command to be:
.PHONY: benchmarks
benchmarks:
   ./scripts/run_benchmark.sh $(PALLETS)

You could also write a rule like:
benchmarks-%:
   ./scripts/run_benchmark.sh $*

However, we should consider that doing so would mean auto-complete for shells would not list the available benchmark targets in this case. If we want to preserve auto-complete for command shells, we could do something like this:
BENCH_TARGETS=benchmarks-messages benchmarks-msa benchmarks-schemas. benchmarks-stateful-storage benchmarks-overhead

$(BENCH_TARGETS):
   ./scripts/run_benchmark.sh ${@:benchmarks-%=%)

@JoeCap08055 Hm... 🤷🏻 It works for me in the linked PR: #1241:
# Run benchmarks for msa pallet
$ make benchmarks pallet="msa"
./scripts/run_benchmark.sh -p msa
    Updating git repository `https://github.com/paritytech/substrate`
    Updating git repository `https://github.com/paritytech/cumulus`
    ...

# Run benchmarks for schemas pallet
$ make benchmarks pallet="schemas"
./scripts/run_benchmark.sh -p schemas
    Updating crates.io index
    ...

Unless I am missing something here.

What I mean by "preserving CLI auto-complete" is that the way you have it now, if the user types make bench<TAB> in a properly configured shell, they'll see:
benchmarks

as this is the only configured target. There is no assistance provided to the user to indicated valid pallet names to add to the command. But if we create individual targets as I've listed above, typing make bench<TAB> yields:
benchmarks-messages benchmarks-msa benchmarks-overhead benchmarks-schemas benchmarks-stateful-storage

Yes, please close.


Add hours-minutes-converter extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

A simple extentions for converting hours and minutes to decimals and vice versa.

It's also possible directly in Raycast, maybe you can just use that

Does this mean my extension has been denied? Thanks for your reaction!


[Automation] Generate Fluent Lite from customer-insights#package-2017-04

[Automation] Generate Fluent Lite from customer-insights#package-2017-04

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-customerinsights


ember-cli-deploy

Just wanted to ping about ember-cli-deploy to make sure we're sharing as much work as possible. Are there some fundamental differences to your approach?

@achambers @LevelbossMike Any updates on the direction this is going to go?  We're planning on using this approach to deploying and I'd love to know if there is a particular bandwagon I should be jumping on ;-)  Thanks!

Hi @acorncom. Yep, there will be some updates shortly. We've got a few things to sort out first. Glad you're interested in the approach. More details to come shortly.

@achambers Appreciate it.  We had been thinking of putting that in in the next week or so, would you recommend we hold off for now?

@acorncom Depends on how soon you want to get it in. If you want to move forward now, I'd suggest using this repo (Mike's ember-deploy) for the time being. This should put you in good stead for the path forward.

@achambers That's quite helpful.  And yes, we were thinking of starting work on it in the next few days.  Looking forward to what you guys cook up!

@achambers  I second the helpfulness of your comment.
You currently own top search position for a number of different versions of trying to deploy ember do you think you could put a note in your readme to point new people towards this version / mention the future collaboration.

Yep. Will be doing this shortly. We were only discussing yesterday about the way forward.


Add Search Component

Please look over cheers - screenshots here:

Coverage decreased (-0.8%) to 96.901% when pulling 7266243ae37eb2e2718f14ca361da46a2d1cc74f on search into da8bfeb60e6bfce04c1127ce094a71ea681eef39 on master.

All fixes done

Coverage decreased (-1.2%) to 96.755% when pulling ec24944913eeba8ac8bb2fd09a9d6aa74beb7242 on search into b4a47193b37c0398ebb13d7e21d3e3b549405686 on master.

Coverage decreased (-1.0%) to 96.951% when pulling d0ea2b1aad2a9c02a83893312815110e2e197c48 on search into b4a47193b37c0398ebb13d7e21d3e3b549405686 on master.

Coverage decreased (-0.5%) to 80.058% when pulling 8855bf0697ba11a530e12fa32534c5b5a181731e on search into e1d49ac96a7e47be34c1f7f0e67b2b8ef9e0eff1 on master.

Have had to skip 3 tests on this so please look over what I've done so far - the rest are passing. It's just the classnames issue again. Have required the direction and passed this in as as the defaultProps on the tests and on individual prop specific unit tests. Not sure if we need to go more indepth on this so let me know what you think cheers.

Coverage increased (+0.2%) to 80.73% when pulling bbd3e73d9dd7feacf7af1de0304f930b0ecfa9be on search into e1d49ac96a7e47be34c1f7f0e67b2b8ef9e0eff1 on master.

Changes Unknown when pulling cf648adf60c2b80925e534e47ba3a6555e16cbb5 on search into ** on master**.

Have refactored please look over

Changes Unknown when pulling d50061b6cd3edb737c254027a84886d4c3bb82c0 on search into ** on master**.

Changes Unknown when pulling a334b7c40976cf894ae470802fec4cf3c950c988 on search into ** on master**.

Rob can you have a look over the this and see if I'm going in the right direction please? Other fixes done. Cheers

Changes Unknown when pulling 0e9ba597ab31643ebd22859524d6f63f5b6b9564 on search into ** on master**.

Have done some more changes please can you see if what I am doing is correct thanks

Changes Unknown when pulling 0e9ba597ab31643ebd22859524d6f63f5b6b9564 on search into ** on master**.

Coverage decreased (-0.7%) to 79.337% when pulling 156824af623769f05ba29a8c8f5708f5621c6cf6 on search into a7a51e51951d07315b0f17ae558e37b0a92192e4 on master.

Coverage decreased (-0.7%) to 79.337% when pulling be5e4230419300077be07ddc597a585401938f18 on search into a7a51e51951d07315b0f17ae558e37b0a92192e4 on master.

Coverage increased (+0.3%) to 80.364% when pulling 3a620ca5a221b3da48a29ad2397dfb09cdbd8d37 on search into a7a51e51951d07315b0f17ae558e37b0a92192e4 on master.

Coverage increased (+0.3%) to 80.364% when pulling 3a620ca5a221b3da48a29ad2397dfb09cdbd8d37 on search into a7a51e51951d07315b0f17ae558e37b0a92192e4 on master.

Coverage increased (+0.4%) to 80.443% when pulling 2e1ae9a2df87001244b75ff46c3e4de44fafa444 on search into a7a51e51951d07315b0f17ae558e37b0a92192e4 on master.

Coverage increased (+0.4%) to 80.443% when pulling db7fbb3da7446c48e75a3e2bb78c4dab7c787a56 on search into a7a51e51951d07315b0f17ae558e37b0a92192e4 on master.

Please can you have a look over my feedback thanks

Coverage increased (+0.4%) to 80.443% when pulling 06f505df691da1ac597cd5e460b33a4ebc353f73 on search into a47a815ca36c32dad2eb4af8130d7868506c79e8 on master.

Coverage increased (+0.05%) to 92.897% when pulling 83095019c2c05e225b91681e2ce027fa5168faa7 on search into a36ad004cd2d1e735b1aa36963b5a2b035cbe872 on master.

Coverage increased (+0.2%) to 93.017% when pulling 981591b31c03704dd6a932eec8f130e3d0266f4a on search into a36ad004cd2d1e735b1aa36963b5a2b035cbe872 on master.


Clicking '#branch-mobile-action' refreshes SPA when banner is iframe

https://github.com/mrblueblue/branch-iframe-test
When the banner is an iframe, the clicking the "branch-mobile-action" <a/> will refresh a Backbone application when:

The mobile action href is set to "#" and its target is set to "_parent"
The banner iframe src is set to "about:blank"
The Backbone application has made at least one route change, giving history a state

I don't fully understand the dynamics of number three: the refresh does not happen when you are on the first application route.
Clicking the mobile action on the first route will just append a '#' to the route name, but on subsequent routes, a page refresh is triggered because the route is set to '/#' which is the root of the application.
This refresh behavior goes away when you:

Don't use an iframe; or,
Delete the href attribute of the mobile action; or,
Delete the target attribute of the mobile action

Please let me know if this is the expected behavior of the iframe banner for single page applications.
For now,  I will just use the non-iframe banner.

For my project, I have to use the iFrame. Having the href in a link is usually to get the automatic cursor: pointer from the browser on hover. There is no hover in mobile. DELETE THE href. Please :)

My last comment wasn't helpful. This one is for those of you that have to use the iframe.
`var didShowBannerListener = function () {
var iframe = document.getElementById("branch-banner-iframe");
var iframeDocument = iframe.contentDocument || iframe.contentWindow.document;
iframeDocument.getElementById('branch-mobile-action').removeAttribute('href');
};
			branch.addListener('didShowBanner', didShowBannerListener);`


chore: Move Bernoulli's inequality

The first versions for ordered semirings do not need to import so much but:

they have no obvious place to go
nobody needs them that early (in particular, it seems nobody needs them without also needing the ordered field version)

Part of #9411

they have no obvious place to go

Why can't they just stay where they are? Is it such a bad place?

They could, but all other lemmas in Algebra.GroupPower.Lemmas are going to move to more appropriate places, and then Algebra.GroupPower.Lemmas is a weird name for the file containing them. I did consider moving them to a file called Algebra.Order.Ring.Bernoulli instead, but it would miss one of the Bernoulli inequality statements. What do you think?

New files are cheap, IMO

Okay but what do I put in this new file? the three Bernoulli inequalities for rings and I leave the field one in Algebra.Order.Field.Power? all inequalities and the file imports Algebra.Order.Field.Power?

Okay but what do I put in this new file? the three Bernoulli inequalities for rings and I leave the field one in Algebra.Order.Field.Power? all inequalities and the file imports Algebra.Order.Field.Power?

I would go for

the three Bernoulli inequalities for rings and I leave the field one in Algebra.Order.Field.Power

and add some comments pointing back and forth.


Change profile name and info

Hi guys is possible change profile name and info??

Is it available on WhatsApp web?
On Tue, 26 May 2020, 7:47 pm David Mart<EMAIL_ADDRESS>wrote:

Hi guys is possible change profile name and info??
[image: image]
https://user-images.githubusercontent.com/10666050/82927303-1cec5980-9f46-11ea-8022-97992bad491c.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Rhymen/go-whatsapp/issues/375, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDLT2ZQRZPCHZWWPBVYAO3RTPXBNANCNFSM4NKUWO7A
.

Is it available on WhatsApp web?
…
On Tue, 26 May 2020, 7:47 pm David Mart, @.***> wrote: Hi guys is possible change profile name and info?? [image: image] https://user-images.githubusercontent.com/10666050/82927303-1cec5980-9f46-11ea-8022-97992bad491c.png — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#375>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDLT2ZQRZPCHZWWPBVYAO3RTPXBNANCNFSM4NKUWO7A .

Yes it's available on web


[elb] Enable Monitoring and Alarms for ALB Metrics

From customer:
I have an ALB+Fargate Coral stack, and i’d like to have a CW Dashboard and Alarms for when my ALB is seeing spikes in 5xx errors. I see the monitorFargateApplicationLoadBalancer, but I don’t think it monitors ALB metrics, just the targets of the ALB
Specifically, HTTPCode_Target_5XX_Count (backend) and HTTPCode_ELB_5XX_Count (LB) would be good to monitor/alarm.
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-cloudwatch-metrics.html

I think this is a duplicate of !328


Upgrade dependencies

I suggest to create an action where dependencies of this package are automatically upgraded.
For instance this uses React v18.2.0 where the current version is v18.3.1
I see this on other repos, where some bot auto checks current package versions and creates PRs.

Hi! I just updated the dev dependencies, but having auto-updates might be a good idea. That said, react-hot-toast only has goober as actual dependency, since React is just a peer dependencies.


Other relevant flags to consider inclusion

Please consider adding also:

Basque Country
Catalonia
Galicia
Kurdistan
Tibet
Veneto
Occitania
Quebec
Esperanto
Arab League

Flagpack uses the officially assigned ISO country codes as the source of truth. Because of this some flags might not be included in Flagpack. Please refer to the officially assigned country codes on the ISO website to see which Flags should be included in Flagpack.
We would like to note that the flag(s) you're suggesting do not align with the officially assigned ISO country codes and therefore will not be added to Flagpack. We're sorry for the inconvenience this may cause.


Serve legacy bundle to Edge, use native classes in modern bundle

Edge is generally ~1% of traffic, but class transpilation is costly, especially in class-heavy code.
This PR adds a UA check to serve the legacy bundle to Edge and removes class transpilation from the modern bundle

👍


linux hexagon: add missing defines

This commit defines blksize_t, ETIMEDOUT, SIGSTKSZ.

r? @JohnTitor
(rust_highfive has picked a reviewer for you, use r? to override)


Grid guides for development

Only visible in development
Stores state in local storage
Configurable columns count (default 12)

Created setup function so we can stop calling react's lifecycle methods. Used utils/devtools.js for all tools we will be including.
Also used same styling for the toggle button as mobx devtools.
But,, what an awesome devtool!! :)


Consistent input validation

Reference Issues/PRs
Fixes #98
What does this implement/fix? Explain your changes.

consistent input checks

Any other comments?

different input checks for forecasting?

@mloning this now has some conflicts, maybe because of the forecasting merge? Sorry


Kellyroach/fix warnings

This pull request fixes assorted Xcode 9.4.1 compiler warnings in TwitterCore, TwitterKit, and DemoApp of the twitter-kit-ios SDK .  We've gone to some lengths to get Analyze / "iPhone X" to be equal to "No issues" on all 3 of these projects and also check unit tests are still passing and DemoApp functions plausibly.  We would encourage Twitter software engineers, who are the experts, to review the pull request carefully due to the size and complexity.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

TEST: TwitterCore
Test Suite 'TwitterCoreTests.xctest' passed at 2018-07-14 16:09:34.429.
	 Executed 350 tests, with 0 failures (0 unexpected) in 0.979 (1.160) seconds
Test Suite 'All tests' passed at 2018-07-14 16:09:34.431.
	 Executed 350 tests, with 0 failures (0 unexpected) in 0.979 (1.162) seconds

TEST: TwitterKit
Test Suite 'TwitterKitTests.xctest' passed at 2018-07-14 16:08:11.718.
	 Executed 821 tests, with 0 failures (0 unexpected) in 7.398 (8.064) seconds
Test Suite 'All tests' passed at 2018-07-14 16:08:11.722.
	 Executed 821 tests, with 0 failures (0 unexpected) in 7.398 (8.069) seconds

TEST: DemoApp
A MIA Config.xcconfig is resolved for us by copying Config.xcconfig.example to Config.xcconfig .
The DemoApp built, ran, and exercised on "iPhone X" simulator.  We explored various of the view controllers.  There is plausiblity in what we saw.  We leave it to the judgement of Twitter software
engineers whether or not everything is actually working here.
Our feeling is that there probably should not a lot of difference, if any, due to the nature of our
P.R., which is to fix static code lint issues detected by Xcode Analyze on the three projects TwitterCore, TwitterKit, and DemoApp of the twitter-kit-ios SDK .

@kellyroach I was trying to pull in your git version of this in cocoapods but it is not working, any idea why? I receive "[!] Unable to find a specification for 'TwitterKit'.".

RE: CocoaPods .  I think "I just downloaded the zip and added the framework locally"
is probably best for now.  My P.R. really can't and so doesn't modify Twitter's *.podspec
contents nor their locations in Twitter's repo.

I understand, thank you for getting back to me.


What is blocking daisy v4?

Just curious if it's an architectural problem or a time problem.

Hi there. I would say mostly of a time problem atm. Currently I'm quite busy with some other stuff and trying to support v4 would need a considerable investment of time. I had gone through the daisy v4 changelog before and had some ideas that could make it work, but that was some time ago.
That said, I will try to find some time to check on v4 support, but that will most likely not be soon :c

PRs welcome btw! 😁


Enable Github Action Publish Unit Test Results

https://github.com/marketplace/actions/publish-unit-test-results

Or https://github.com/marketplace/actions/golang-test-annotations


[TS] Document how to on-board with preview packages

And requirements around same (e.g. version selector?). Docs currently link to the on-boarding form but could say more about what the requirements are for preview package on-boarding.
See also: 56bc304f7f8722bd90d35bb2529e5a815474308f.
/cc @mmacy

I'm thinking this is going to be covered by a combination of the preview release guidelines and the release guidelines (both of which are owned by @maggiepint )

https://github.com/Azure/azure-sdk/blob/master/docs/engineering-system/releases.md


Movement Refactoring

This issue will be updated with further information on how the movement-related code should be refactored.

This issue will be updated with further information on how the movement-related code should be refactored.

... or not 🙄


empty shapes returned in RNN example

Following the code in example/rnn/rnn_cell_demo.py, I create a RNN symbol like this:
data = mx.sym.Variable('data')
rnn_h_init = mx.sym.SwapAxis(mx.sym.Variable('LSTM_init_h'), dim1=0, dim2=1)
rnn_c_init = mx.sym.SwapAxis(mx.sym.Variable('LSTM_init_c'), dim1=0, dim2=1)
rnn = mx.sym.RNN(data=data, num_layers=5, state_size=512, mode='lstm', state=rnn_h_init, state_cell=rnn_c_init)
print rnn.list_arguments()
# ['data', 'rnn0_parameters', 'LSTM_init_h', 'LSTM_init_c']
print rnn.infer_shape(data=(15, 10, 1024))[0]
# [(15L, 10L, 1024L), (11554816L,), (), ()]

The returned shape of rnn_h_init and rnn_c_init are both empty tuple "()" and produce an error when initializing the parameters in FeedForward model.
If I change the code to
rnn_h_init = mx.sym.Variable('LSTM_init_h')
rnn_c_init = mx.sym.Variable('LSTM_init_c')
# [(15L, 10L, 1024L), (11554816L,), (5L, 10L, 512L), (5L, 10L, 512L)]

the returned shapes seem to be right now. But according to the instructions in rnn_cell_demo.py, both c and h are time major rather than batch major.
I am not familiar with RNN symbol in mxnet, can anyone provide some help about this? Should I define h and c without using SwapAxis?

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Typing number of children in TSX

Imagine a component which requires some exact number of children passed.
Can it be currently expressed in TypeScript? Tuple doesn't work here.
Code
import React from 'react'

interface ResizablePanelProps {
  children: [React.ReactNode, React.ReactNode]
}

class ResizablePanel extends React.Component<
  ResizablePanelProps, any> {}

const test = <ResizablePanel>

</ResizablePanel>

Expected behavior:
Pass.
Actual behavior:
Type '{ children: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<ResizablePanel> & Readonly<{ children?: ReactNode;...'.
  Type '{ children: Element[]; }' is not assignable to type 'Readonly<ResizablePanelProps>'.
    Types of property 'children' are incompatible.
      Type 'Element[]' is not assignable to type '[ReactNode, ReactNode]'.
        Property '0' is missing in type 'Element[]'.

Code
import React from 'react'

interface ResizablePanelProps {
  children: [React.ReactNode, React.ReactNode]
}

class ResizablePanel extends React.Component<
  ResizablePanelProps, any> {}

const test = <ResizablePanel>

</ResizablePanel>

Expected behavior:
Fail, provided 3 nodes instead of 2.
Playground Link:
https://stackblitz.com/edit/react-ts-8tttua

@weswigham I think we can just force tuple inference for the JSX children array and this should work automagically. Thoughts?

At least it should be doable to make the tupleness propegate via contextual type like it does elsewhere.

@weswigham amazing, thanks!


Tag releases 0.1.0 (and release 0.2.0)

I believe only version 0.1.0 is released and would be great to tag the version (https://github.com/fetlife/rollout-ui/commit/18623736c38eaae4da5732248afd468e7a75db25 ? )

I made to sure to tag commits for 0.2, 0.3 and released latest state of the code as 0.4

Thx!!


Create basic structure for Rockets - Setup

Create a route and a view component. Use for the page navigation links and style active class to indicate which section/page the user is currently on (underline active navigation link).
Create a directory for all Redux state slice files.

Thanks for the review @jerryowusu


[tests-only] [full-ci] Trigger CI

to see if anything is failing
I am seeing this failure all the time in PR #3576
https://drone.owncloud.com/owncloud/ocis/10876/48/9
runsh: Total unexpected failed scenarios throughout the test run:
webUISharingPublicBasic/publicLinkCreate.feature:172

See issue #3581


Added 'keys' method

A lot of cache libraries provide a "keys" method which I find very useful.

Thanks for the update @phillip-hall!
I've merged the changes and released it as 1.0.3
https://www.npmjs.com/package/js-cache


Update README to show users how to apply bar theme

Even though themes are availabe and are awesome, I was pretty confused on how to apply bar theme,  and I guess it's the same with new users so just putting a little snippet in README about bar theme

I've covered it in the wiki :smile: : https://hyprpanel.com/configuration/theming.html#button-styles

And let's move it out of the instructions section and into the configuration section.

OK

Closing this, as it seems redundant


cluster-administration-overview.md: Change the translation for logging to "journalisation des évènements"

/assign @oussemos

/lgtm

@oussemos could you approve this PR by commenting /approve if the PR is ok to merge?

/approve


Readme has wrong package links.

The readme file has incorrect package names. easy fix.

Thank you very much for your interest in the Toolkit!  We will be releasing the official initial version on December 14, which will resolve your issue.  This will coincide with the release of Esri's new ArcGIS Maps SDK for Swift.
Feel free to take  look at the v.next branch for a full list of components available in the initial release.

Hey thanks. I’m mainly interested in the import export functions. I work developing guidance system for ag aviation and aerial firefighting and we have a lot of customers who use would like to use exports of our data in arc-gis.

On Dec 9, 2022, at 10:17 AM, Mark Dostal @.***> wrote:
Thank you very much for your interest in the Toolkit! We will be releasing the official initial version on December 14, which will resolve your issue. This will coincide with the release of Esri's new ArcGIS Maps SDK for Swift.
Feel free to take look at the v.next branch https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/tree/v.next for a full list of components available in the initial release.
—
Reply to this email directly, view it on GitHub https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/issues/211#issuecomment-1344559953, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE4TFSPL42MP4724Z6TNMDWMNSS3ANCNFSM6AAAAAASZO53RQ.
You are receiving this because you authored the thread.

Hi Jeff, the beta for our new Swift SDK and the associated Toolkit (this repo) is available as of today. See here for more info. The package should now work correctly as expected.
If you'd like to provide a little more info on the import/export functionality you need, we can point you in the right direction.
We hope you enjoy working with the new SDK!


Add effects to Impedrezene, Heartbreaker toxin and Mindbreaker toxin

About the PR
I added hallucination effects to Impedrezene, Heartbreaker toxin and Mindbreaker toxin
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Added effects to Impedrezene, Heartbreaker toxin and Mindbreaker toxin
remove: None

Yea this is just turning them into identical copies of space drugs.

I can add blindness effect and alcohol effect

I add new effect to Impedrezene

There is no interest in these if they use already existing effects.

okay


base_fuel calculations if all tech_specs bases are False

This needs to calculate a base_fuel technology, with the weighted average parameters of all technologies.

This needs to be disaggregated by urban/rural

We need to move this information from the Prep_files to the Technical_specs:

Technology
Share
Data type

Urb_Cook_Biomass
0.07089
float

Urb_Cook_Charcoal
0.153005
float

Urb_Cook_Coal
0
float

Urb_Cook_Electricity
0.03696
float

Urb_Cook_Gas
0.68971
float

Urb_Cook_Kerosene
0.02041
float

Rur_Cook_Biomass
0.07089
float

Rur_Cook_Charcoal
0.153005
float

Rur_Cook_Coal
0
float

Rur_Cook_Electricity
0.03696
float

Rur_Cook_Gas
0.68971
float

Rur_Cook_Kerosene
0.02041
float

This will make it easier to loop through all technologies and calculate the weighted average of the parameters.

We would need the following properties from all technologies, which will then be used to calculate eh weighted averages:
['carbon', 'pm25', 'total_time_yr']

If the carbon or total_time_yr have not been calculated fora technology, then the function should call .carb() and .total_time() for the technology.


fix: asynchronous initialize-deinit bug

Description
Fix for #56
Doing some more testing on the deinit(), the bug was seen in test4() when trying to use unawaited initialize() and suddenly deinit(). Not happening with await initialize(). This caused a failed test.
Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

My question is whether we even need shutdown(). If deinit() calls SoLoud::deinit() and just kills the isolate, maybe there is no reason to wait for anything?

I think that deinit() does its job without waiting, just to be sure you also approved this change.

In that case, I think we can just remove shutdown() altogether?

(I can do that in a follow up PR.)

No problem, I'll do in this PR


Include Protos.proto in nuget again - or how to reference actor.PID in proto message?

In the current version of the nuget the Protos.proto file is not included anymore.
If one wants to send a PID over a proto message it's not possible (or i dont know how??).
In the chat example the Protos.proto file from the .git source code is referenced, but this is not possible when using the nuget.
Is there any easy way?
Currently i define my own PID class (for messages) and a C# extensions method to convert between these two

If anyone want to give this a go, feel free to grab this task.
If you can make it so that the protos.proto file in the main proto.actor project is included in the nuget reference, as a file which gets added to the project referencing proto.actor, this would be fantastic.
I know it is possible as others include readme files and similar things.
I just don't know how to myself

I make a sample for including the proto files to nuget package and import it in the chat example instead of local reference
https://github.com/asynkron/protoactor-dotnet/commit/c4b9b49bb6e93b7093c45d9105d7b1976acd10ea
It's not auto-generated, require adding  GeneratePathProperty="true" property to nuget reference and adding the proto path to imports AdditionalImportDirs=".; $(PkgProto_Actor)\Protos"
I suggest collecting all proto files in single nuget without using Protobuf code generation and reuse this package in different packages.
so user could just import single package instead of the need for multiple AdditionalImportDirs
If you find this is a good solution, I could start working on it.
Reference: https://www.asystad.net/sharing-message-types-between-grpc-services-in-net/


ci: split jobs

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   80.78%   80.78%
=======================================
  Files          22       22
  Lines         432      432
  Branches       56       62    +6
=======================================
  Hits          349      349
  Misses         73       73
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583da2b...07b6af0. Read the comment docs.


Feature : Deepdive Charts expanded view

Is your feature request related to a problem? Please describe.
A feature request to be incorporated, allowing charts to expand in a modal for better and bigger view.
Describe the solution you'd like
When viewing the deepdive page, i suggest providing an option to view the corresponding Chart as expanded.

Describe alternatives you've considered
None
Additional context
Added package react-modal to accomplish this, created a new component modal-wrapper in "src/components/Charts" . There are few things remaining to work just like adding support for Dark mode etc
Let me know if there are any suggestions and we should proceed with this or not.

@vishwac09
This looks good, but, any thoughts on mobile view?
Because I think most of the users use mobile to view this and adding a modal view will look the same as it is right now(as there is not enough width in portrait mode).

@saberprashant yes i did thought about this and in mobile view i am hiding this. Checking the screen width and deciding whether it is a desktop or not.


Unable to run create-env from darwin

Even though there is a darwin golang package, when packaging the bosh-google-cpi it always uses the linux version.
This used to work, because the golang package would actually switch to using the correct version, but that functionality was removed due to problems with vendoring packages.
The job bin template has a similar problem, but correctly determines the platform and calls the correct cli depending on the platform.
We should probably do something similar in the packaging script.

Fixed by https://github.com/cloudfoundry/bosh-google-cpi-release/pull/347


Make TX timestamp reading attempts and timeout configurable

Summary: We had them constant while ptp4u was the only user. With sptp client running on different HW we have to make timeout and the amount of attempts configurable
Reviewed By: leoleovich
Differential Revision: D43501343

Codecov Report
Base: 56.69% // Head: 56.69% // No change to project coverage :thumbsup:

Coverage data is based on head (a41121e) compared to base (65062b7).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   56.69%   56.69%
=======================================
  Files         125      125
  Lines       11267    11267
=======================================
  Hits         6388     6388
  Misses       4346     4346
  Partials      533      533

Impacted Files
Coverage Δ

timestamp/timestamp.go
76.74% <ø> (ø)

timestamp/timestamp_linux.go
60.62% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


docs(readme): update to better reflect design and philosophy of Combo

Summary
Updating the README.md to better reflect a comment that @njhale left on #4 which outlined a much better structure for it. On top of his suggestion, I added some changes to tie it all together.
Additions

Description of what Combo is
Example of using on/off cluster
Alternatives and why you may not want to use them

Closes #5

Looking good!
@tylerslaton what do you think about adding a checklist of planned/implemented features?

I like that idea! Let me draft out what that looks like and put it up with this PR.


MD025 no effect even with it being set to false in .markdownlint.json

Exactly as above. Inside .markdownlint.json I have:
{
single-title: false;
}

and no effect whatsoever.

@nschonni even with your corrections there is no result.

This works in general. What are you expecting to happen? Can you point to an example repo?

@DavidAnson sure, here you go:
What Im expecting to happen? I expect your software to work. I mean: upto this day, when I editted my .markdownlint.json file, my editor ( Visual Studio Code Insiders ) applied changes automatically upon saving ( closing tab in my case ). This had been working for me for.... ever since I switched to VSC completely ( circa 3 years ago ).
Today when I opened VSC, it updated, and autoapplying stopped working. I may be wrong, but I think that todays update has something to do with this.

I have not published a new version of the markdownlint extension for a couple of months. It is possible a recent update to VS Code has broken things, but that would not be my first guess. If you could please outline specifically what steps and configuration are not behaving as you expect, that would be helpful. As it is, I don't have enough information to try to reproduce your scenario myself.

One thing would be to please try the official build rather than the Insiders build. The Insiders build gets less testing and they may have introduced a bug in the nightly release.


awk program and /24 CIDR and other netblocks

worked somewhat at one stage, but tampering with the programs mean it requires work.
mostly likely splitting larger netblocks into another ip set.

at the very least, pipeline shows linear scaling with doubling of runtime with doubling addresses.


chore: github issue template #2088

closes #2088

v13.4.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


Clean up old issues

Currently we have 110 open issues on the project, but we don't have that many tasks, this task aims to review the issues and close them as necessary.
These are some of the cases it may occur:

Duplicated issue
Closed wrongly
Solved by another fix
Resolved to live-with

For any question related to an issue, talk directly with the person who created it.
Definition of Done:

[ ] All issues analyzed
[ ] Closed the ones who are not necessary/done already

All issues have been taken care of, thanks folks!


Replacement of RenderAsyncDelegate in asp net core 2.0

It seems in asp net core 2.0, RenderAsyncDelegate lose its TextWriter
What is the replacement?

@NTaylorMullen @rynowak - any thoughts on this?

Inside your delegate you can now utilize PushWriter(TextWriter writer) and PopWriter() to render your content to something different.
If you'd like to shim your old delegate you can do something like this:
@using Microsoft.AspNetCore.Mvc.Razor
@using System.IO

@functions {
    RenderAsyncDelegate CreateOldDelegate(TextWriter writer, RenderAsyncDelegate oldDelegate)
    {
        RenderAsyncDelegate newDelegate = async () =>
        {
            PushWriter(writer);
            await oldDelegate();
            PopWriter();
        };

        return newDelegate;
    }
}

@{
    var temporaryWriter = new StringWriter();
    var oldDelegate = CreateOldDelegate(temporaryWriter, () =>
    {
        WriteLiteral("
Hello World
");

        return Task.CompletedTask;
    });
}

Oh is this the change that @ajaybhargavb made?

Did we have an announcement on it?

Yes https://github.com/aspnet/Announcements/issues/242. But I missed adding this to the announcement because this change was done much earlier by @rynowak. I've now updated it.

Thanks! Closing this bug. If there are still issues, please reactivate or log a new issue.

Is this efficient?
Now I have to create new StringWriter, previously I just need to pass it to single pipe of TextWriter

https://github.com/aspnet/Razor/issues/702
public static void AppendSection(this RazorPage page, string key, Func<dynamic, dynamic> text)
        {
            if (!page.SectionWriters.ContainsKey(key))
            {
                page.SectionWriters.Add(key, async () =>
                {
                    using (var textWriter = new StringWriter())
                    {
                        await text("").WriteAction(textWriter);
                        page.WriteLiteral(textWriter.ToString());
                    }
                });
            }
            else
            {
                page.SectionWriters[key] += async () =>
                {
                    using (var textWriter = new StringWriter())
                    {
                        await text("").WriteAction(textWriter);
                        page.WriteLiteral(textWriter.ToString());
                    }
                };
            }
        }

Usage
@{
    this.AppendSection("js",@
        );
    }

Now I have to create new StringWriter, previously I just need to pass it to single pipe of TextWriter

We take care of setting the appropriate writer for you. So assuming your text method returns something that can be written append section code could look like:
page.SectionWriters[key] += async () =>
{
    page.Write(await text(""));
};

Much simpler 😄

This is working, notice no await
page.SectionWriters.Add(key, async () => page.Write(text("")));

These are not working
page.SectionWriters.Add(key, async () => await page.Write(text(""))); // Exception thrown

page.SectionWriters.Add(key, () => page.Write(text(""))); // Exception thrown

While page.Write is working, it use async lambda without await
The Write also working without html encoding
Something is not right

Your text method should definitely be awaitable. Razor in intrinsically async which means if you're not awaiting the underlying method or .Resulting it then something's going wrong.

It doesn't work

@andrew-vandenbrink my apologies. I re-looked over how you're establishing your text delegate and found I was incorrect.
Does the following work for you:
page.SectionWriters.Add(key, () =>
{
    page.Write(text(""));
    return Task.CompletedTask;
});

While it works, the page.Write write not encoded html text.... where it should be right?


dploy without GIT

I really like this tool and I like using it. But, does anyone know if it's possible to deploy from the file system directly instead of git? I know that git is better but I just wanted to ask if it's possible or if there is some other tool available?
Thanks,
Philip

I might just use gulp-git to commit automatically before right before deploying. But still let me know if dploy could ever support deploying from the local file system.

+1
I'd love to be able to deploy my build. My source is already tracked in git and I would rather not track the build files.

I use git but use this solution for build folder which is in gitignore:
dev:
    scheme: ftp
    host: host
    port: 21
    user: user
    pass: pass
    check: true
    path:
        local: dist/
    include:
        "dist/**/*": "/"

There is one essential problem, every deploy copy all dist folder :(


Three enhancements and one minor change.

Draw symbol along line string or polygon
Add control line and road closure point
Use two export buttons, one for GeoJSON, the other for GeoPackage
Add notes for Fire Boundary, Custom Line, and Custom Polygon tools

This change is

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


per-browser "download" instructions

When user hits download and see download screen, add per-browser pictures of the "SAVE" bar.

[ ] IE 11

[ ] Edge

[ ] Firefox

[ ] Safari

[ ] Chrome

[ ] fix doc page https://codethemicrobit.com/device/usb

The screenshots on this page are also of microbit.co.uk opposed to codethemicrobit.com

https://github.com/Microsoft/pxt-microbit/pull/239 fixes the documentation page.


Custom type convertToJSValueSQL method is not used when calling find method with fields option

Describe the bug
Method convertToJSValueSQL from custom type is not used when calling find method with fields option.
Stack trace
export class PointType extends Type<Point | undefined, string | undefined> {
  convertToDatabaseValue(value: Point | undefined): string | undefined {
    if (!value) {
      return value;
    }

    return `point(${value.latitude} ${value.longitude})`;
  }

  convertToJSValue(value: string | undefined): Point | undefined {
    const m = value?.match(/point\((-?\d+(\.\d+)?) (-?\d+(\.\d+)?)\)/i);

    if (!m) {
      return undefined;
    }

    return new Point(+m[1], +m[3]);
  }

  convertToJSValueSQL(key: string) {
    return `ST_AsText(${key})`;
  }

  convertToDatabaseValueSQL(key: string) {
    return `ST_GeogFromText(${key})`;
  }

  getColumnType(): string {
    return 'geography';
  }
}

const data = await this.repository.find(where, {
  fields: ['location'],
});

// With fields
select "a0"."id", "a0"."location" from "ad" as "a0" order by "a0"."id" asc limit 50

// Without fields
select "a0".*, ST_AsText("a0"."location") as "location" from "ad" as "a0" order by "a0"."id" asc limit 50

To Reproduce
Steps to reproduce the behavior:

Create custom type
Use custom type in the Entity
Get data with find method and use fields option which contains field which has the custom type

Expected behavior
Custom type method convertToJSValueSQL  should be used when explicitly selecting fields
Additional context
N/A
Versions

Dependency
Version

node
20.3.1

typescript
5.1.6

mikro-orm
5.7.14

pg
8.11.1

I am able to reproduce this on properties that have different property name and column name, e.g. when you map extendedPoint to extended_point. When the names match (as with location) it seems to be working fine - so if that's the case, I will might need to see a complete repro - but maybe the fix will work for you, so be sure to first try the dev version once its out.

Thanks, just ran into this myself. Is there any further reason why this happens? And, is there a way to fix it? Currently, I've got two fields which are now underscored in my entity definition, instead of camelCased.

This has been fixed in v5.8, if you have a similar problem that is reproducible with the latest version, please provide a complete repro.


Add HTTP result header to file result types

The HTTP headers include interesting entries like X-Dropbox-Request-Id and
Dropbox-Api-Result for certain calls. This commit adds a Header field to the
output structs.

hmm maybe we should normalize those header fields into individual struct fields, seems a little hacky to just pass the http headers as-is IMO

I pondered that but Google's Drive API uses a similar approach for the headers (it includes the servers status code as well but with Dropbox this is not really necessary). A helper method to unmarshal the data from the Dropbox-Api-Result might be worth considering, though, as not every user might need that data.

I think that would be pretty useful, haven't needed it myself but I like the idea of having access to the download metadata etc from Dropbox-Api-Result instead of just a header

What about embedding the metadata struct into the regular output so we can unmarshal it for the user? I think that'd be a little better API-wise than having to manually unmarshal, then we can ditch exposing the Header


Flex: add dataTestId

This is a common request from folks, and often either results in people using Box instead, or wrapping Flex in an additional Box just to set the id (resulting in DOM bloat).
This could be implemented as a passthrough prop (similar to Box), but I think that's a leaky abstraction. Though it is a passthrough component under the hood, we don't treat Flex as such. And we shouldn't expect our users to know how Flex is implemented. Therefore, I implemented this as an "official" new prop, dataTestId. This matches our other non-Box test ids.
Future work
I need to update the existing prefer-flex lint rule to accommodate this new prop.
I'll also look at ways of finding and refactoring Boxes that wrap Flexes only for the test id.

I'm ok with the change. So, in the past we had proposed creating a Testable component. Wrapping Flex with  is basically the same approach. Why are we concerned here about DOM bloat but not with Testable?

in the past we had proposed creating a Testable component. Wrapping Flex with is basically the same approach. Why are we concerned here about DOM bloat but not with Testable?
If we go this route, seems like we might need to start adding more datatestid to more components.

@AlbertCarreras  Ultimately I don't think a Testable component will scale well. In addition to the DOM bloat, that approach won't work for many of our sub-components, necessitating adding dataTestId props to them explicitly (as we've done with Dropdown.Item and Dropdown.Link already). I think we will need to add dataTestId props to many/most of our components at some point.

For consistency, I'd also add it to Box, although this is OOO for this PR.

For consistency, I'd also add it to Box, although this is OOO for this PR.

Agreed — its availability as a passthrough prop is a leaky abstraction there as well, and is not intuitive. I'll throw together a quick follow-up PR


Added Bubbles CSS Animation

Title and Issue number
Successfully added a css animation of floating bubbles in background for Issue #3560
Preview

Close #3560

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

@MohitGupta121  @TusharKesarwani  sir, kindly review my PR


Upgrade turndownschedules CRD to apiextensions v1

This PR addresses https://github.com/kubecost/cluster-turndown/issues/40.
Changes
apiextensions.k8s.io/v1beta1 is removed as of K8s v1.22 [1], so all CRDs
have to be updated to apiextensions.k8s.io/v1. This commit does the
upgrade for the turndownschedule CRD.
As part of the API updates, K8s is enforcing things grouped under
*.k8s.io to be approved [2] because they are actually supposed to be
Kubernetes community-managed APIs [3]. So this commit also changes the
CRD from:
turndownschedules.kubecost.k8s.io
to
turndownschedules.kubecost.com
This is in-line with K8s rules and links to our main domain.
Testing
Tested by applying cluster-turndown-full.yaml and example-schedule.yaml
successfully (with updated container image from this commit) as instructed
by the README.
Notes
We did a similar change in https://github.com/kubecost/cost-analyzer-helm-chart/pull/1429 but didn't do all of the necessary steps, like changing the CRD group to kubecost.com and similar changes. Once this PR has been approved, merged, and a new version of cluster-turndown is released, we'll have to update cluster-controller (because of the regenerated code for turndownschedules.kubecost.com) and the turndownschedule CRD in the main Kubecost Helm chart.
[1] https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-22
[2] https://github.com/kubernetes/enhancements/pull/1111
[3] https://github.com/kubernetes/enhancements/pull/1111#issuecomment-507834574

Does this break existing resources?

Yes, unfortunately it does. This requires a major version update and a breaking change notification in the release notes.


[Enhancement]: Epic Games Lauchner support

Describe the new feature or enhancement
Support Bloons TD6 from Epic Games.

no. thats on someone to develop a mod for, not the mod loader itself


fix(kit): support previews using a route prefix strategy

Types of changes

[ ] Chore (a non-breaking change which is related to package maintenance)
[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This PR updates the existing @prismicio/svelte/kit preview functions and components to support a new, cleaner method of integrating Prismic previews.

redirectToPreviewURL() now prefixes routes with /preview/ (configurable), which enables server rendering.
<PrismicPreview> now adds a special navigation handler to prefix links with /preview/ (configurable), which enables server rendering.

Documentation on the recommended SvelteKit app setup and @prismicio/svelte/kit's API will be published soon.
Checklist:

[x] My change requires an update to the official documentation.
[x] All TSDoc comments are up-to-date and new ones have been added where necessary.
[x] All new and existing tests are passing.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (b88da24) 98.00% compared to head (776b359) 98.00%.

:exclamation: Current head 776b359 differs from pull request most recent head 2508778. Consider uploading reports for the commit 2508778 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   98.00%   98.00%
=======================================
  Files          11       11
  Lines         600      600
=======================================
  Hits          588      588
  Misses         12       12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Formatter like coc-sql

Hi, is there a feature to format sql statements?

Formatting is out of the scope of this plugin.
I'm using https://github.com/sql-formatter-org/sql-formatter with setlocal formatprg=sql-formatter\ -l\ postgresql for sql buffers.


Sort projects by last updated goals

PR includes

[x] Feature

Related issues
Resolve #1229
Related issues #1319
QA Instructions, Screenshots, Recordings

Why raw sql and not a prisma query builder?

@tsumo  prisma query builder does not allow to sort projects by last updated goals


Need annotation documents to be visible by default

It's very tedious to click on the "eye" icon every time a slide is opened. This is especially important for review of slides with numerous annotations.

This is pretty easy to do.  Would it be better to show all be default or add a "Show all" button?

@jbeezley I think it would be better to have a "show all" button, if possible. This way it easy to toggle on-and-off, and also makes it faster to initially load the slide without having to load all the boundaries at the same time.

Is there an estimate of when this feature would be available. I think this is one of the more important things to have especially as expert reviewers have already started looking through people's annotations. Thank you for the support.


Adding Ctrl+V / Ctrl+C functionality

I was wondering if you could add control copy + paste functionality into this class? I have some base code that would work to a degree, however I am not experienced enough to add it to your class. I've left the example of how to do so below.
pygame.scrap.init()
pygame.scrap.set_mode(pygame.SCRAP_CLIPBOARD)
#event loop
events = pygame.event.get()
    for event in events:
        if (event.type == pygame.QUIT):
            pygame.quit()
        if (event.type == pygame.KEYDOWN):
            # checking for ctrl + V
            if event.key == pygame.K_v and event.mod & pygame.KMOD_CTRL:
                 # adding text to a text box called promptBox, where .text is the thing that holds the text
                pasted_text =  pygame.scrap.get("text/plain;charset=utf-8").decode()
                promptBox.text = promptBox.text[:-1]
                promptBox.text += pasted_text

I did this using a different inputBox class, which is why i did .text, however I don't know how I could apply this functionality to your class, so I was wondering if you had any ideas?

Actually, never mind I dug through and found out how to do the functionality. Perhaps you could add this as an example or potentially even still add this to your class? I've linked below the github repo so you can check it out yourself https://github.com/frankvp11/openAItesting

Though your code is correct. It is giving so many bugs like after pasting if I press up or down key or page up and down, backspace does not work sometimes and sometimes crashes due to this. Also remove that -1 from your code as it copies last letter again. So it should look like this
promptBox.input_string = (                             promptBox.input_string[:promptBox.cursor_position]                             + pasted_text                             + promptBox.input_string[promptBox.cursor_position:])
I tried to add this functionality into my class but it creates bugs like I mentioned above and tried to fix but cannot do. So I guess I will not add.
Btw nice use of api, haha

Thanks, haha. The reason I had that -1 in the code at the time was because when you do Ctrl+V it gets read as a unicode thing.

Now you can paste text.
Actually bugs were caused when you copy multiple lines. Clipboard adds /r at the end of the line. So I had to remove that in every line of pasted text.
Also if you kept the Ctrl + V pressed, it crashes due to attribute error.
So I asked ChatGPT by giving that code and error to fix it. And it fixed it hahahahaha.
By replacing event.mod by pygame.key.get_mods()
So it looks like this
elif event.key == pygame.K_v and pygame.key.get_mods() & pygame.KMOD_CTRL:

Nice! I love to see it.


Roll Flutter Engine from aac09195688d to 5d1b713784a7 (13 revisions)

https://github.com/flutter/engine/compare/aac09195688d...5d1b713784a7
2023-05-21<EMAIL_ADDRESS>Roll Skia from a60bfcb01af9 to 7c7dff949a27 (1 revision) (flutter/engine#42195)
2023-05-20<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from c_fRDyBVZX-MwW5fS... to gQ989rlKAuTJHQR-C... (flutter/engine#42194)
2023-05-20<EMAIL_ADDRESS>Roll Skia from f3e9cb7d37fd to a60bfcb01af9 (1 revision) (flutter/engine#42193)
2023-05-20<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from sfLkc5VBFU6UkljF6... to 868_67npyO8nD_JCx... (flutter/engine#42191)
2023-05-20<EMAIL_ADDRESS>Move SkSurface::MakeNull to SkSurfaces::Null (flutter/engine#42158)
2023-05-20<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from TWjmvLCOnYAUgAzvT... to c_fRDyBVZX-MwW5fS... (flutter/engine#42189)
2023-05-20<EMAIL_ADDRESS>Roll Skia from b4a4782cf89d to f3e9cb7d37fd (1 revision) (flutter/engine#42188)
2023-05-20<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from pwdDQgM88sqLmZczj... to sfLkc5VBFU6UkljF6... (flutter/engine#42187)
2023-05-20<EMAIL_ADDRESS>Roll Skia from 7202b405f061 to b4a4782cf89d (19 revisions) (flutter/engine#42185)
2023-05-20<EMAIL_ADDRESS>[Impeller] avoid creating multiple concurrent message loops for Andorid Vulkan (flutter/engine#42146)
2023-05-20<EMAIL_ADDRESS>Implement ImageFilter/ColorFilter/MaskFilter in Skwasm (flutter/engine#42088)
2023-05-20<EMAIL_ADDRESS>[Impeller] Made other vulkan objects cleanup properly. (flutter/engine#42113)
2023-05-19<EMAIL_ADDRESS>[Impeller] Fix the issue that 'coverage_coords' is incorrectly calculated in 'FillPathGeometry::GetPositionUVBuffer' (flutter/engine#42155)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TWjmvLCOnYAU to gQ989rlKAuTJ
fuchsia/sdk/core/mac-amd64 from pwdDQgM88sqL to 868_67npyO8n
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


For the second example, it has a typo.

[Enter feedback here]
// Add a using directive for System.Runtime.InteropServices.

[System.Runtime.InteropServices.StructLayout(LayoutKind.Explicit)]
struct TestExplicit
{
    [System.Runtime.InteropServices.FieldOffset(0)]
    public long lg;

    [System.Runtime.InteropServices.FieldOffset(0)]
    public int i1;

    [System.Runtime.InteropServices.FieldOffset(4)]
    public int i2;

    [System.Runtime.InteropServices.FieldOffset(8)]
    public double d;

    [System.Runtime.InteropServices.FieldOffset(12)]
    public char c;

    [System.Runtime.InteropServices.FieldOffset(14)]
    public byte b;
}

The two integer fields, i1 and i2, share the same memory locations as lg. This sort of control over struct layout is useful when using platform invocation.

You should modify the FieldOffset of i2 to 0. The correct code is below
[System.Runtime.InteropServices.StructLayout(LayoutKind.Explicit)]
struct TestExplicit
{
    [System.Runtime.InteropServices.FieldOffset(0)]
    public long lg;

    [System.Runtime.InteropServices.FieldOffset(0)]
    public int i1;

    [System.Runtime.InteropServices.FieldOffset(0)]
    public int i2;

    [System.Runtime.InteropServices.FieldOffset(8)]
    public double d;

    [System.Runtime.InteropServices.FieldOffset(12)]
    public char c;

    [System.Runtime.InteropServices.FieldOffset(14)]
    public byte b;
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab1403b2-952d-dac3-adff-963ed667363c
Version Independent ID: c84ca78b-f578-bc74-fc37-8023f9e1aa5f
Content: How to create a C/C++ union by using attributes (C#)
Content Source: docs/csharp/programming-guide/concepts/attributes/how-to-create-a-c-cpp-union-by-using-attributes.md
Product: dotnet-csharp
Technology: csharp-fundamentals
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

@gewarren
I've submitted PR to fix this: #25870
Please review 🙂


Add generics attribute for collection.

Due to the potential confusion, I think it'd be better to expand this into a small section showing a couple of examples with/without the generic.

@billinghamj Make sense, I make a little change.


Documentation: Is this only GCE specific?

Will this perform bare metal provisioning and how does this work with Ironic or any other bare metal provisioning layer?

This is about a Bosh CPI to provision Bosh releases to Kubernetes, not install Kubernetes itself. You might want to have a look at https://github.com/cloudfoundry-incubator/kubo-release
If provisioning Bosh releases to K8S is of interest I would recommend to have a look at https://github.com/bosh-cpis/bosh-kubernetes-cpi-release


Adjust WASI implementation to build for Android

Fixes #2099.

I've smoke tested this target by running YoWASP with wasmtime-py installed inside Termux. Yosys seems to run fine, except that instead of gracefully terminating, it just segfaults after a pretty large delay. Not sure what's up with that.

would it make sense to add O_RSYNC there too, so that in the future we can remove the cfg_if here?

I didn't realize we can do that! https://github.com/rust-lang/libc/pull/1997


JUnit extensions for integration tests

This PR adds a set of annotations that can be used to generate one or more Kafka clusters for integration testing. The primary motivation for this is to reuse existing integration tests for both Zk and Raft based Kafka clusters. A secondary motivation is to refactor the complex test hierarchy that exists and instead provide reusable functionality to tests through helper classes.
Annotations
A new @ClusterTest annotation is introduced which allows for a test to declaratively configure an underlying Kafka cluster.
@ClusterTest
def testSomething(): Unit = { ... }

This annotation has fields for cluster type and number of brokers, as well as commonly parameterized configurations. Arbitrary server properties can also be provided in the annotation:
@ClusterTest(clusterType = Type.Zk, securityProtocol = "PLAINTEXT", properties = {
  @ClusterProperty(key = "inter.broker.protocol.version", value = "2.7-IV2"),
  @ClusterProperty(key = "socket.send.buffer.bytes", value = "10240"),
})
void testSomething() { ... }

Multiple @ClusterTest annotations can be given to generate more than one test invocation for the annotated method.
@ClusterTests(Array(
    @ClusterTest(securityProtocol = "PLAINTEXT"),
    @ClusterTest(securityProtocol = "SASL_PLAINTEXT")
))
def testSomething(): Unit = { ... }

A class-level @ClusterTestDefaults annotation is added to provide default values for @ClusterTest defined within the class. The intention here is to reduce repetitive annotation declarations and also make changing defaults easier for a class with many test cases.
Dynamic Configuration
In order to allow for more flexible cluster configuration, a @ClusterTemplate annotation is also introduced. This annotation takes a single string value which references a static method on the test class. This method is used to produce any number of test configurations using a fluent builder style API.
@ClusterTemplate("generateConfigs")
void testSomething() { ... }

static void generateConfigs(ClusterGenerator clusterGenerator) {
  clusterGenerator.accept(ClusterConfig.defaultClusterBuilder()
      .name("Generated Test 1")
      .serverProperties(props1)
      .ibp("2.7-IV1")
      .build());
  clusterGenerator.accept(ClusterConfig.defaultClusterBuilder()
      .name("Generated Test 2")
      .serverProperties(props2)
      .ibp("2.7-IV2")
      .build());
  clusterGenerator.accept(ClusterConfig.defaultClusterBuilder()
      .name("Generated Test 3")
      .serverProperties(props3)
      .build());
}

This "escape hatch" from the simple declarative style configuration makes it easy to dynamically configure clusters.
JUnit Extension
One thing to note is that our "test*" methods are no longer tests, but rather they are test templates. We have added a JUnit extension called ClusterForEach which knows how to process these annotations in order to generate test invocations. Test classes that wish to make use of these annotations need to explicitly register this extension:
@ExtendWith(value = Array(classOf[ClusterForEach]))
class ApiVersionsRequestTest {
   ...
}

JUnit Lifecycle
The lifecycle of a test class that is extended with ClusterForEach follows:

JUnit discovers test template methods that are annotated with @ClusterTest, @ClusterTests, or @ClusterTemplate
ClusterForEach is called for each of these template methods in order to generate some number of test invocations

For each generated invocation:

Static @BeforeAll methods are called
Test class is instantiated
Non-static @BeforeEach methods are called
Kafka Cluster is started
Test method is invoked
Kafka Cluster is stopped
Non-static @AfterEach methods are called
Static @AfterAll methods are called

@BeforeEach methods give an opportunity to setup additional test dependencies before the cluster is started. For example, in SaslApiVersionsRequestTest, a MiniKDC is started before Kafka comes up (in order to provide a SASL backend). As seen in the example @BeforeEach (and other places) can have parameters which are provided through JUnit dependency injection.
Dependency Injection
A few classes are introduced to provide context to the underlying cluster and to provide reusable functionality that was previously garnered from the test hierarchy.

ClusterConfig: a mutable cluster configuration, includes cluster type, number of brokers, properties, etc
ClusterInstance: a shim to the underlying class that actually runs the cluster, provides access to things like SocketServers
IntegrationTestHelper: connection related functions taken from IntegrationTestHarness and BaseRequestTest

In order to have one of these objects injected, simply add it as a parameter to your test class, @BeforeEach method, or test method.

Injection
Class
BeforeEach
Test
Notes

ClusterConfig
yes
yes
yes*
Once in the test, changing config has no effect

ClusterInstance
yes*
no
yes
Injectable at class level for convenience, can only be accessed inside test

IntegrationTestHelper
yes
yes
yes
-

@ExtendWith(value = Array(classOf[ClusterForEach]))
class SomeTestClass(helper: IntegrationTestHelper) {

  @BeforeEach
  def setup(config: ClusterConfig): Unit = {
    config.serverProperties().put("foo", "bar")
  }

  @ClusterTest
  def testSomething(cluster: ClusterInstance): Unit = {
    val topics = cluster.createAdminClient().listTopics()
  }
}

Gradle
In order to overcome some compilation issues, the core module test compile phase is now using the Scala compile for both Java and Scala sources. This is because the new annotations and JUnit extension are written in Java, but depend on some Scala classes in "core".
    test {
      java {
        srcDirs = []
      }
      scala {
        srcDirs = ["src/generated/java", "src/test/java", "src/test/scala"]
      }
    }

Since most of the core module test sources are Scala already, this should have little impact on build time.
KIP-500
As mentioned above, one of the main motivations of this work is to allow for easy reuse of test code between Raft and Zk modes. This will be accomplished using the clusterType field on the annotations. For example:
@ClusterTest(clusterType=Type.Both)
def testSomething(): Unit = { ... }

would generate two invocations: one for Zk and one for Raft.
Once more of the KIP-500 code is merged into trunk, we will add a Raft-based test invocation context. The prototype version can be seen on the original prototype PR
Gotchas

Test methods annotated with JUnit's @Test will still be run, but no cluster will be started and no dependency injection will happen. This is generally not what you want
Even though ClusterConfig is accessible and mutable inside the test method, changing it will have no affect on the cluster

https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9986/1/testReport/kafka.server/ApiVersionsRequestTest/

https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9986/1/testReport/kafka.server/ApiVersionsRequestTest/

LGTM.  Thanks, @mumrah

looks like there is a checkstyle issue:
[2021-02-08T23:40:02.927Z] [Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9986/core/src/test/scala/unit/kafka/server/ApiVersionsRequestTest.scala:20: Unused import
[2021-02-08T23:40:02.927Z] [Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-9986/core/src/test/scala/integration/kafka/api/AdminClientWithPoliciesIntegrationTest.scala:91: @nowarn annotation does not suppress any warnings


Raise if requests are not performed as expected

I expect from my testing tools to detect inconsistencies and unpredictable behaviour.
This is why I would like that responses helps me to detect request that has not been performed unlike it should.
I implemented it in a way that is backward compatible, but I'm in favour of enabling this behaviour by default.

Looks really good.
I think it should be on by default.

I agree this changes looks good. I want to clean up some language, but I'll try to get this merged in later this week.

@dcramer I can simplify the implementation if you agree to introduce this incompatible backward change.
up to you.


C++20 compatibility for print_log_value<>

operator<<(std::ostream&, const wchar_t*) has been removed from C++20 [1].
Remove the corresponding print_log_value<> specialization.

I see some automated checks failed, but as far as I can tell these failures are not related to my changes.

The question is rather to know if this change is relevant: print_log_value is the entity that prints any type to the logger. Removing this would mean that we are not supporting anymore logging wchar_t const*.
While the current implementation is incorrect (we just print the address of the string) it still does not prevent something like BOOST_TEST(a == b) to compile.
This is a recurrent topic now, and it needs to be addressed. The "how" is unclear to me but my approach would not be the one you are proposing.

I see some automated checks failed, but as far as I can tell these failures are not related to my changes.

Yes this is also a recurrent topic :) I restarted some of those Appveyor is not yet working.

The question is rather to know if this change is relevant: print_log_value is the entity that prints any type to the logger. Removing this would mean that we are not supporting anymore logging wchar_t const*.
While the current implementation is incorrect (we just print the address of the string) it still does not prevent something like BOOST_TEST(a == b) to compile.
This is a recurrent topic now, and it needs to be addressed. The "how" is unclear to me but my approach would not be the one you are proposing.

Actually the bug was already fixed in 8ac88c62dcc809d42daf8b6bef10f7adecc46dd1. I copied my hack without noticing that the code already changed. Sorry about the noise.

Thanks for the quick update!


Registering MetricRegistry with Application during run()

migrated from https://github.com/Berico-Technologies/Fallwizard/pull/16
DW 0.7.1 fixed the issue of 0.7.0 in which the internal DW MetricRegistry wasn't easily accessible
Enabling to access it in the run()
by that removing the need for calling the super() on your own initalize method - which is a "gotcha! "

arrrr.... wrong repo...


[new]: added functionality to the login button

Issue 18 📐

I @deeksharungta have worked for #18

Guidelines 🔐
I agree that before requesting a review :

[x] I have performed a self-review of my code
[x] Tested on web-browser
[x] Tested on mobile

Issue to be closed 🛅

My pull request closes #18

Screenshots 📷
Here are the screenshots of changes that I have made 🔽

Great work. Thanks for contributing. Do keep an eye on repo if you want to contribute more. New challenges coming in future.


manual.py -a error: AttributeError: 'module' object has no attribute 'guessit'

Here is the output if I attempt to run the manual.py using the -a flag on a movie.
Manual processor started.
/usr/bin/python
Python 64-bit 2.7.16 (default, Oct  9 2019, 14:10:52)
GCC 4.8.4].
Guessit version: 1.0.3.
Traceback (most recent call last):
  File "{mypath}/sickbeard_mp4_automator/manual.py", line 395, in <module>
    main()
  File "{mypath}/sickbeard_mp4_automator/manual.py", line 386, in main
    tagdata = getinfo(path, silent=silent, tvdbid=tvdbid)
  File "{mypath}/sickbeard_mp4_automator/manual.py", line 91, in getinfo
    tagdata = guessInfo(fileName, tvdbid)
  File "{mypath}/sickbeard_mp4_automator/manual.py", line 129, in guessInfo
    guess = guessit.guessit(fileName)
AttributeError: 'module' object has no attribute 'guessit'
Environment:
Linux Mint 17.2 Rafaela x86_64 (ubuntu 14.04 trusty)
$>python -V
Python 2.7.16
$>/usr/bin/env python -V
Python 2.7.16
$>pip --version
pip 20.0.2 from /usr/local/lib/python2.7/dist-packages/pip (python 2.7)
$>guessit --version
+-------------------------------------------------------+
+                   GuessIt 1.0.3                       +
+-------------------------------------------------------+
|      Please report any bug or feature request at      |
|       https://github.com/wackou/guessit/issues.       |
+-------------------------------------------------------+
I tried upgrading to guessit 2, but then subliminal wouldn't run/errored out, so went back to guessit 1.0.3
If I use manual.py with the -imdb flag, it runs ok, so it's just in the usage of guessit, it seems.  Any ideas as to what the fix might be?

This is fixed, you need to use latest version of all of these things, guess it and subliminal
See the readme, all the packages supported should all be the latest versions (this was all updated a few weeks ago)

Thanks, that's the direction I needed to get this working again!
For anyone else who finds this, upgrading subliminal to 2.0 (which upgraded guessit to 3.1.0) fixed the module & dependency errors.
$>pip install subliminal==2.0.0
$>subliminal --version
subliminal, version 2.0.0
note: $>guessit --version is still displaying 1.0.3, but when used or in showing pip freeze, it's displaying as 3.1.0, and working.


Document matlabroot output

It would be convenient to have an option to export the configured MATLAB install directory as an environment variable. It's useful when linking against MATLALB when developing an add-on. AFAICT, right now you kinda have to guess (on Linux at least).
MATLAB 2023b is located at /opt/hostedtoolcache/MATLAB/2023.2.999/x64

Thanks @mcafaro, that's exactly what I'm looking for!


Docker compose

Still to do (future PR):

elasticbeanstalk setup and docs

worked for me, although I believe Nathan had problems installing docker via self-service

Would be good to know what the pre-requisites are for this with respect to running the above commands as step 1 "install docker: it's in the self service" is not even an option, even after speaking with Calum.  More notes to follow once i've worked it out.

:+1:

:shipit: :ship: :rocket: :100: :metal:


Change the func type of Accessor::access() to std::function

Currently, the func parameter type of the access() api is a function pointer.
std::unique_ptr<Picture> access(std::unique_ptr<Picture> picture, bool(*func)(const Paint* paint)) noexcept;

There are limited ways to pass user data to the func function. So to support this we can add void* userData or use std::function.
Existing APIs should be deprecated and new APIs should be added.
ex)
std::unique_ptr<Picture> access(std::unique_ptr<Picture> picture, const std::function<bool(const Paint* paint)>) noexcept;

yes i think std::function sounds reasonable.

Added new beta api. User can use std::function with this api.
std::unique_ptr<Picture> set(std::unique_ptr<Picture> picture, std::function<bool(const Paint* paint)> func) noexcept;


GM Longitudinal: Display personality in instrument cluster

Displays Longitudinal Personality with 1st, 2nd, and 3rd bar.
Requires

https://github.com/commaai/openpilot/pull/31760

@Verylukyguy can you try this?


Exceptional not available in Extension Manager

I am running VS2019 and ReSharper 2019.2

I find this is regularly an issue, resharper is updated almost weekly at some stages so it means 75% of the time I cannot use exceptional as your releases lag theirs. Is there anyway we can automate exceptional being ready for the new resharper releases?

@patrickweegen and I have taken over the maintenance of this project (See #92). We hope to get rid of the huge delay.


Add functionality for placing markups only on the Hepatic or Portal veins

The heading is a bit confusing for me, but from our discussion I assume the wanted functionality is:
Add separate centerline segments for the same segment for the same territory ID.
This is possible with the current implementation:

Add control points and press "Add Vessel Centerline" as normal
Delete the markup control points before adding the new points. This can be done with the arrow beside the trash bin button.
Add new control points, and add the new centerline. You may have to press the "Place control point" button, and turn on visibility with the "..." button
Now two separate centerline segments should be created

@dalbenzioG, could you check this?

This is possible with the current implementation:
* Add control points and press "Add Vessel Centerline" as normal

* Delete the markup control points before adding the new points. This can be done with the arrow beside the trash bin button.

* Add new control points, and add the new centerline. You may have to press the "Place control point" button, and turn on visibility with the "..." button

* Now two separate centerline segments should be created

@dalbenzioG, could you check this?

This is possible with the current implementation:
* Add control points and press "Add Vessel Centerline" as normal

* Delete the markup control points before adding the new points. This can be done with the arrow beside the trash bin button.

* Add new control points, and add the new centerline. You may have to press the "Place control point" button, and turn on visibility with the "..." button

* Now two separate centerline segments should be created

Yes, sure.

I enabled the drop down for adding more point lists. Now it should be possible to keep adding new point lists to make new disconnected centerline segments: https://github.com/ALive-research/Slicer-Liver/pull/170


Texture TrimColor/BackgroundColor

Hey guys,
when you normally use texture.trim, it adds a padding to the texture so that it is positioned and sized in the same way as before trimming the excess transparent space off the original image.
It would be nice, however, to also be able to trim off other colors than fully transparent ones, and get the texture to display the same way the original image would.
I think the most straight forward way to realize this, is to add a backgroundColor or trimColor to the texture and let the WebGL/CanvasRenderer draw some rectangles.
It might be something you could add to v4, since Trim/Crop are getting reworked a bit afaik.

I think that's possible if @GoodBoyDigital approves my #2465 and it will required some tinking after. That way all that logic wont appear over all pixi (ParticleRenderer, CanvasSpriteRenderer) but only in one place


Please add model and server info

Can you please add what model this uses and which server? If it's privacy protecting, this is crucial info to be transparent about

Hi, yes you are 100% correct and I apologize!
I will add it soon (with the new version)


Stuck in sign in

Issue Type: Bug
Unable to log in in Live Session even after Github  or Microsoft is authenticated
Extension version: 1.0.1123
VS Code version: Code 1.40.0 (86405ea23e3937316009fc27c9361deee66ffbf5, 2019-11-06T17:09:34.601Z)
OS version: Darwin x64 19.0.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
8, 3, 1

Memory (System)
16.00GB (5.15GB free)

Process Argv

Screen Reader
no

VM
0%

Hi @lbaquerofierro- can you please provide more information on what you experienced. This sounds similar to the issue we are working on https://github.com/MicrosoftDocs/live-share/issues/2926
If you see a stalled signing in notification in your editor, you can try the following workaround:
you can  try signing in with the user code that's given to you when you see the success page.
On that page, you can click "Having trouble? Click here for user code directions" and copy the 16 digit code that's displayed. Once it's copied to your clipboard, you can open the command palette (ctrl or cmd + shift + p), then type "user code", select "Live Share: Sign In With User Code", then paste the code.

Dup: https://github.com/MicrosoftDocs/live-share/issues/2982


ModelFactory.php seeding users cant not login

Since User model has setPasswordAttribute method,   when create a user it will hash the password automatically. But in ModelFactory.php it was been already hashed
`
// ModelFactory.php
'password' => $password ?: $password = bcrypt('password'),
// User.php
public function setPasswordAttribute($value)
{
$this->attributes['password'] = Hash::make($value);
}
`

Remove the setter if not necessary, the extra code I provide is just an utility :) closing this, thanks


Additional context
No response
Environment
System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (4) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
  Binaries:
    Node: 18.14.2 - /usr/local/bin/node
    Yarn: 1.22.15 - /usr/bin/yarn
    npm: 9.6.2 - /usr/local/bin/npm
  npmPackages:
    jest: ^29.5.0 => 29.5.0

I don't have access to the repo so can't remove the label.

Jest does not use tap.
Could you provide a reproduction?


problem to run app

hi
I face a few problems while running the app though i use Windows Docker and docker-compose branch
After running, Eureka shows 4 services but no websites is launched on localhost:80
what is the solution to fix this

On Windows you can have a problem with running our solution using Docker.
If you run services from IDE/manually, all works great or not?

To running manually, i have to install many dependent softwares such as postgres and ... .
I changed network-modes in docker-compose  and mapped all service ports to local ports and it worked for me

@Erffun I added to master branch version where docker works using network_mode: host.
Maybe can you create a pull request with your version? :)

With pleasure
I'm too busy now
but I'll do it asap


Catch Forge's MissingAttributeError on FuelError

Description
Some how, Forge Error didn't catch property on FuelError.
Type of change
Check all that apply

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (a change which changes the current internal or external interface)
[ ] This change requires a documentation update

How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, if necessary
[x] My changes generate no new compiler warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Inspect the bytecode viewer, including reasoning why

Since you are on this, can you also help bump up the version to  as well?

NICE!! approve!


Agent does not learn from actions

As far as I understand it there is a typo in the following line: https://github.com/sachink2010/AutomatedStockTrading-DeepQ-Learning/blob/424e58dc0a84fac07db3f624bb6f0bd3b96d3792/agent/agent.py#L50
minibatch is used instead of mini_batch so the for-loop is not called and thus the model.fit method will never be called

hello, thanks for your comment. I don't know how it was missed, probably copy-paste error. I have updated it.


Update for julia 0.6

I've updated REQUIRE so it should be ready to push a new version to METADATA, too.

Superseded by #5


User should be able to connect to an LDPoS node using a passphrase

User should be able to connect to an LDPoS node using the REPL client. During the connection phase, the user should be prompted for their passphrase. There should be an option to launch the client without providing a passphrase, but in this mode, the user will not be able to sign transactions (only verify transactions and operations to read the blockchain state).
Ideally, the client should come with some default URLs (or ip:port list) to use as seed nodes for convenience but the user should also be able to point to a custom node based on a URL (e.g. ip:port).
Because the client (and signatures) are stateful, the user needs to connect to a node first before they can start to issue commands interactively.

@jondubois this is done
There are three ways to use the cli, both interactively ldpos which prompts some info to connect to the node that can be saved in home dir of the user (Not tested on Windows/Mac). passphrase will always be prompted. ldpos <command> and ldpos <ip:port> <command>


[for discussion] Call cancellation.

#fixes https://github.com/square/okhttp/issues/7164

This form is safer than supporting some blocking operation, since a call may never actually get executed or cancelled.

I won't try to rush this in, but I'll create some tests with the current code so as we discuss the right options we can see how it affects those.

We could also support it now but minimise the blast radius, by putting it on Chain.onCancel(), so it's Jvm only.

@swankjesse what do you think about minimising the blast radius of the change, a new method on chain, would be usable for Interceptors, without a new public API for call cancellations for all clients.
Most clients can use the Callback.onFailure to check for cancellation.


Add support for the anonymous-function feature and allow calling results of expressions

Should close #103.

I marked the pull request as a draft because I mistakenly thought that this code isn't valid in Vimscript:
let persons = [#{name: 'Jackson', gender: 'F'}]
func persons[0].full_name() abort
	const honorifics = #{M: 'Mr.', F: 'Ms.'}
	let honorific = get(honorific, self.gender, 'Mx.')
	return printf("%s %s", honorific, self.name)
endfunc
echo "I'm sorry" persons[0].full_name()

In the process of adding support for that feature, I had to make a change which on the call_expression rule, which happened to fix a bug where calling a funcref returned by an expression results in an incorrect syntax tree.  I have added test cases for this.

LGTM


Decide how to set nomad job ID and how it corresponds to the Broccoli instance ID

Problem
Right now, each template needs to have the job ID to be exactly {{id}}, so that the mapping between an instance ID and a job ID works. Right now, the two are equal.
Solution
It is not clear and we should think about it, whether to set the instance ID based on the complete Nomad job ID instead of only the {{id}} variable.
Example:
job "zeppelin-{{id}}" {
  # ...
}

Here it might make sense to set the Broccoli instance ID to zeppelin-frank instead of frank, if ID = "frank".

Another way would be to have the templates without the job ID and set the ID automatically. This also avoids conflicts in Nomad if your job name is already taken. Problem is that the ID also helps to have the docker container name unique etc. so is it still very useful to put in different places. So maybe the ID stays a parameter but it cannot be set but is set from Broccoli?


Switch to the directory of the clone before beginning the test

https://issues.apache.org/jira/browse/SOLR-XXXXX
Description
The crave tests need to be run from the location of the clone, not the default start directory.
Solution
Change the directory to the appropriate one.
Tests
Have not been able to test this locally, but the creation of this pull request should result in it being tested.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[ ] I have created a Jira issue and added the issue ID to my pull request title.
[ ] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Notwistanding the one test that failed, are the results good to you @uvatbc ?

Notwistanding the one test that failed, are the results good to you @uvatbc ?

Yes. The most important part was that the directory of execution was /crave-devspaces/pipeline/runs/7105372116_3656/solr
See: https://foss.crave.io/app/#/build/info/74271?team=5
The one where it wasn't right was:https://foss.crave.io/app/#/build/info/74270?team=5 /crave-devspaces/actions-runner1/_work/solr/solr


Add information on the wiki on how to modify DEFAULT_PROCESSING_DELAY_IN_SECONDS

The situation is that the plugin by default checks every two minutes if a build has new errors that can be assigned. It would be nice to change that, as builds can take several hours to complete, and it is not needed to check up on the build every two minutes.
Have modified Internal Properties but it is not clear if a server restart is also needed.

Excellent, thank you!

@Sharken03, thank you for you suggestion.