AssignmentTargetRest should have argument field in JSON AST

@ArnaudBarre said on https://github.com/oxc-project/oxc/pull/2652#issuecomment-1987009066 (relevant to #2463):
The manual AssignmentTargetRest should be updated to use argument field.

The manual AssignmentTargetRest should be updated to use argument field.

Thanks for spotting this. Damn! I thought I'd got it all correct in the end (and it was a bit of a battle).
I struggled a bit because I wasn't sure what AST type was our target for what we're trying to match. I was comparing to Acorn's output as produced by https://ast.sxzz.moe/ but that doesn't include the TS-related fields. What parser are we comparing to, and is that parser's output available on any playground/AST explorer?
On this specific one, could you possibly provide some source code which produces the incorrect AST? From looking at the Serde impls, it should already be renaming the target field to argument.
https://github.com/oxc-project/oxc/blob/32303b20fb54aafa60138c7133e31429d2421df5/crates/oxc_ast/src/ast/js.rs#L1040-L1045
Probably I'm missing something...

For now I'm trying to match @typescript-eslint/parser because it's the default prettier parser. It's almost identical to Babel with typescript & estree plugins, but I found some subtitle variations like for #2654 & #2574. In both cases, I think the TSESLint team have done a good job at making an ESTree version that follow the TS syntax updates. I'm using https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/ast-spec to look at type definitions. I'm also using https://ast.sxzz.moe/ now

@ArnaudBarre Ah I think I get it now. To confirm: You were saying the TS type for AssignmentTargetRest is wrong, not the actual JSON AST node?
If so, then #2668 should fix that. But if not please let me know.

Yep sorry for the confusion, it was only types that were wrong, not actual tree. This was just this one line change this why I didn't want or interfer with your work on rest elements.
The other type issue a bit more complex is that the type property is missing in the types (but present in the AST) for:

ObjectPattern
ArrayPattern
FormalParameters
ArrayAssignmentTarget
ObjectAssignmentTarget

Fixed in #2668.


Update kind-projector to 0.13.0

Updates org.typelevel:kind-projector from 0.12.0 to 0.13.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.12.0).
You might want to review and update them manually.
CHANGES.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "kind-projector" } ]

labels: library-update, semver-minor, old-version-remains

Codecov Report

Merging #971 (e7bdf60) into develop (10bfc34) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #971      +/-   ##
===========================================
+ Coverage    89.62%   89.65%   +0.03%
===========================================
  Files          119      119
  Lines         9871     9871
  Branches       511      511
===========================================
+ Hits          8847     8850       +3
+ Misses        1024     1021       -3

Impacted Files
Coverage Δ

...src/main/scala/com/twitter/algebird/Interval.scala
78.26% <0.00%> (-3.48%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
97.00% <0.00%> (+0.64%)
:arrow_up:

.../main/scala/com/twitter/algebird/BloomFilter.scala
94.24% <0.00%> (+0.88%)
:arrow_up:

...a/com/twitter/algebird/immutable/BloomFilter.scala
95.90% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10bfc34...e7bdf60. Read the comment docs.


Merge parent data with child data (like dust.js, velocity etc)

I can create a patch - but would like to know if this has any chance. I am working in a project that is undergoing a change towards DOMly and would really like to have this in the default distribution. Maybe only as a per-template option or as new data variable 'merged' maybe (total would be: 'data', 'this', 'parent', 'merged').
Moustache works different I know, but seriously, I never understood this:

{{data.i18n("major_heading")}}

  <foreach data.items>

parent.i18n(data.type): data.text
  </foreach>

Why can't this just be:

{{data.i18n("major_heading")}}

  <foreach data.items>

data.i18n(data.type): data.text
  </foreach>

In the moustache case if an extension requires another iteration to be added I also needn't add all those extra parent references:

{{data.i18n("major_heading")}}

<foreach data.groups>

data.name

    <foreach data.items>

parent.parent.i18n(data.type): data.text
    </foreach>

</foreach>

I would love to look at this from a design perspective, maybe I am missing something that supports the   moustache case.

@georgkoester if this is looking right to you, let's merge this and release a new version of DOMly.

Apologies for the issue reference barf due to all the rebasing, performance statistics are in for the various branches I've put together to close this issue. Note that the output of issue/22 is identical to master and any variation seen between master and issue/22 is due to environmental factors on the test machine:

See the spreadsheet here for the detailed numbed.
You can run the tests yourself:
git checkout master
grunt bench:domly
git checkout issue/22
grunt bench:domly
git checkout issue/22-no-vars
grunt bench:domly

Here is the build output that is being benchmarked:

master
issue/22 (identical to master)
issue/22-no-vars

You can see that Firefox and Safari don't have any statistically meaningful variation between the branches, but Chrome has some different results for the Markup and Variables benchmarks.
I can't get this result consistently, so I assume it may be due to GC pauses happening at odd times.
The main point is that issue/22-no-vars is using an array inside of the template, and that master/issue/22 are not.
I think the benchmarks are acceptable for either branch, I'm going to do some testing on iOS and see what I can find.


[WIP] dependency updates

Update scalaJS 0.6.16 -> 0.6.17

Update HikariCP 2.6.1 -> 2.6.3

Update h2 in tests 1.4.195 -> 1.4.196

Update finagle-mysql 6.44.0 -> 6.45.0

[x] Unit test all changes

[x] Update README.md if applicable

[x] Add [WIP] to the pull request title if it's work in progress

[x] Squash commits that aren't meaningful changes

[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@golem131 Will you finish this PR?


Fixed download issues

Thanks for working to fix the problems with the original code!
I found that it was unnecessary to use wget -O and ?download=true. The only change needed for that was changing "raw" to "resolve" in the URL.
There was also a problem with the file size checker and it would error after the first file.
Hopefully, if you merge this PR it will reflect in your PR in the main repo. I've never done a PR on a PR before.

thanks! my PR was done a bit too quickly and after a big day of work :)


feat: support latest React version (17 and above)

What is the issue
This plugin has a peerDependency for react set to version 17.0.2. It is not compatible  with the latest version of react, which is the version 18.
It throws the following error :
Could not resolve dependency:
peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>node_modules/vite-plugin-svgr-component
dev<EMAIL_ADDRESS>from the root project

Proposed solution
This solution intend to specifically state the peerDependencies for react, and allow everyone to use this plugin with the latest version of React.

Hi! Thanks for the PR, I have updated the peerDependencies to allow to use a different/higher version of vite and react as well. I have added several keywords for the package search too, so this PR is not needed because it's already done!.
Thanks again!


chore: make MorphismProperty.RespectsIso a typeclass

Most of the properties of properties of morphisms should be made typeclasses. For example, IsMultiplicative, HasTwoOutOfThreeProperty are already typeclasses (because it is convenient for the localization of categories). In this PR, MorphismProperty.RespectsIso is made a typeclass. One of the reasons to do so is that it should ease the development of the notion of "representable" morphisms of presheaves #14208. Another is that most of the reasonable properties of morphisms which we encounter satisfy this property: we should not have to remember the names of lemmas which assert this trivial property!

The main changes are in the file CategoryTheory.MorphismProperty.Basic.

!bench

Thanks a lot!
maintainer merge

Thanks!
bors merge


Example:
At the beginning of test.lua, add call to the garbage collection after requiring gurobi:
local gurobi = require 'gurobi'
collectgarbage()
collectgarbage()

Results:
$ th test.lua
Running 5 tests
1/5 SmallLP ............................................................. [WAIT]/home/rudy/workspace/torch/install/bin/luajit: symbol lookup error: /home/rudy/workspace/torch/install/lib/lua/5.1/libgurobi.so: undefined symbol: GRBloadenv

Cause:
The symbols loaded here are garbage collected and therefore can not be found.

Corrected in your PR #5.


Textfield backspace remove character not working on wsl

Summary:
Backspace not removing characters in TextField on wsl console.
I did a bit of debugging and it looks like the MapCursesKey function (https://github.com/migueldeicaza/gui.cs/blob/master/Terminal.Gui/Driver.cs#L545) maps the backspace key to Key.Unkown on wsl. Confirmed to also be broken on a native Linux box.
It does work as expected on windows cmd or powershell console.
Verified in dotnet core 2.1.0 and mono <IP_ADDRESS>
Environment:
Windows:
Microsoft Windows [Version 10.0.17134.1]
WSL:
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.4 LTS
Release:        16.04
Codename:       xenial
Linux:
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04 LTS
Release:	18.04
Codename:	bionic

Thanks for this patch!    I had not tried this key!

Ok this does break the Mac bindings, so I submitted a slightly different version, can you try it?

Works like a charm thanks 👌. Sr I didn't test it on a mac, don't have one at hand and I was struggling to figure out what the difference was between Delete and DeleteChar.

Thanks, closing!


Move pandas to polars for better performance

We have a set of large-scale datasets:
40'719'166 PXD017052-DIA-features.tsv
When you have more than 40M features. The current normalization tool needs more than 900GB for loading the Matrix. @timosachsenberg suggested in some of our python tools to use the Polars library (https://pola-rs.github.io/polars/py-polars/html/reference/index.html)

:rocket:

We are using parquet an and stream API which looks really nice now and we can compute on really large datasets.


[question] book upgrade

Are there plans to upgrade que book to the current version?

Please see https://forums.manning.com/posts/list/38344.page.

ok


ci: cleanup and remove 3.9 restrictions

A bit experimental, now that numba is available this should work, perhaps?
Dropping flake8 since it's already tested in in a more controlled environment in pre-commit.
Do we need every combination of 32 bits and 64 bits on every supported Python for the tests on Windows? Couldn't a sampling be used?

Do we need every combination of 32 bits and 64 bits on every supported Python for the tests on Windows? Couldn't a sampling be used?

It has sometimes been just a sampling, but then we needed more tests for something, so the full matrix was put back in. It can be reduced again. The main thing that it catches are integer width mismatches in C++, which are sometimes just a warning and sometimes an error. (I haven't checked for warnings in a while.) It can also catch Numba errors, as some generated code works with numba.intp versus numba.int64. Neither of these have been in active development recently, so the matrix can be scaled back, especially as Python 3.9 is being added.
I've managed to get a 32-bit Linux Docker image working on my local machine to diagnose 32-bit errors once they've been found by the Windows builds. It would be nice to integrate that someday, but not something I want to do right now.

I think it's a good idea to have a couple of 32 bit tests, just not for every Python version. :) Is this ready to merge, or would you like me to scale it back a bit in this PR?

Cleaned up one of them (32-bit 3.8), that should be fairly comprehesive but a little faster

Somehow, GitHub hasn't gotten the message that Windows 32-bit Python 3.8 isn't included, but maybe it will after merging. I think it's fine to merge now. I'll do so if I don't hear back after a while.

It needs to be removed from the required checks. It thinks it will eventually show up.

I dropped it from the required checks.

Great, thanks!


Why not use servo project's CSS parser + Selector?

Hi,
There's a servo project rust-cssparser that implements CSS 3 features.
Why not use that + make a thin selector on top of it?
That would make implementation of new features faster and more stable.

Unless you dont want to add another dependency?

rust-cssparser is a very heavy dependency. That's the main and only issue.

While i understand your concern, please think about it.
It would be awesome if you can focus on supporting more features in resvg (which by the way is used in everything these days, and i am really a fan of that software)
Thank you for your Interest in this.

Add rust-cssparser is half of the problem. the second half is to properly apply it to SVG. Which is far from trivial.
It wouldn't magically solve all our CSS support problem.
I will look into it when I would have time, but no idea when.


Create find-the-trace-of-a-matrix.py

Closes #4603
What's being changed:
Added find-the-trace-of-a-matrix.py into find-the-trace-of-a-matrix folder

Closes #4181  too
Changes:
Added find-the-maximum-sum-of-a-contiguous-subarray.py


feat(evento): allow to subscribe from last event

:tada: This PR is included in version 0.7.0 :tada:
The release is available on:

GitHub release
v0.7.0

Your semantic-release bot :package::rocket:


[Visual Requirements- Fancy Zones-Launch Zones-Create New Custom]: Luminosity ratio of 'Custom' tab item text with its white background is 1.72:1 which is less than 4.5:1

[Fancy Zones-Launch Zones -Utility-Create New Custom]
User Experience:
Low-vision users will be affected here as they will not be able to see the control and hence will not be able perform the desired action if the luminosity ratio of the control's text element is less than required.
Test Environment:
OS Version: 20221.1000
App Name: Power Toy Preview
App Version: v0.23.0
Screen Reader: Narrator
Repro Steps:

Open Power Toys App
Navigate to Fancy Zone Button and activate it.
Navigate to Launch Zones Editor and activate it.
Navigate to Custom tab in  Choose your layout for this Desktop dialog and  verify the text luminosity ratio

Actual Result:
'Luminosity ratio of 'Custom' tab item text with its white background is 1.72:1 which is very less than 4.5:1
Expected Result:
'Luminosity ratio of 'Custom' tab item text with its white background should be greater than or eqaul to 4.5:1 for a clear and proper visibility of the control
MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}
Create a new custom-MAS1.4.3- Luminosity ratio of 'Custom' tab item text is less.zip

Shipped with 0.27 release. https://github.com/microsoft/PowerToys/releases/tag/v0.27.0


Simplify email export for mailing list purposes

note: this has the same ends / purpose as #554. Try that first, and if that fails, try this one instead.
Right now you can click around the backend to get a full csv of users with all their info. It's nice.
But then to upload to mmblanche, you have to strip out the header and all the other info, and produce just one column of emails. This is doable with a csv editor, but it takes an annoying amount of manual effort every time.
Simplify by having (an option for) the exported csv just having email addresses and no header if doable. Alternatively I guess an external python script works.

Probably mutually exclusive with #554. Which do we prefer?

would strongly pref #554. although I'm not actually sure that one is viable, so let's leave this open as a fallback?

On the contrary, I'd strongly pref this, because I'm very wary of tangling siarnaq up with MIT emailing systems.

This would have little value. Turns out, we don't use our competitor email lists much (and not at all in IAP 2024!), especially with other alternatives like Discord and the website, and we did fine. Also, the burden to tell competitors things isn't on us -- if competitors miss something, that's not our "fault" and not necessarily our "burden"/guilt/etc.
(I do wonder how many more competitors we'd have if we did email all the time too. But, we don't think there's many competitors that we're missing out on. Serious competitors would be checking announcements anyways. And there would be relatively few competitors who signed up and forgot would see their email, be reminded, and thus play fully.)
Also, this would be nontrivial code, and be code that specifically has a small niche too. Would be a lot of responsibility to create and maintain.
And, the entire workflow to build an email list is already a long process to do.
So choosing to not make improvements here, and work on better things instead.
We can keep the previous systems around, but not sink time into improving them.
(we = me Serena Evan, who have worked w these lists a lot; also Maggie and Lowell heard and didn't object)


typings for xml2json

I am developing a mobile app using Ionic2 framework. I need to convert a xml file to json format.
For this I have installed "xml2json" using command "npm install xml2json --save".
This has saved a module named "xml2json" in "node_modules" folder.
I can also see it under dependencies in "package.json" file as "xml2json": "^0.9.1"
Now when I declared it in the .ts file as "import * as xml2json from "xml2json";", I am receiving the following error: "can not find module xml2json"
I guess I need to install the typings for this module. I have tried all the possible typings commands but could not install it. I received errors like
typings ERR! caused by https://api.typings.org/entries/dt/xml2json/versions/latest responded with 404, expected it to equal 200
Please let me know how can I install typings for xml2json OR how can I use xml2json in my project. Thanks.
My system information:
typings version - 1.3.2
Cordova CLI: 6.3.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.11
Ionic CLI Version: 2.0.0-beta.36
Ionic App Lib Version: 2.0.0-beta.19
OS: Distributor ID:	Ubuntu Description:	Ubuntu 16.04 LTS
Node Version: v6.3.0

It's irregularity from DefinitelyTyped.
You can install it by this command:
typings i xml2json=dt~x2js/xml2json -SG
Let me know if that works for you. 🌷

Thanks for your answer but NO it did not work...still receiving error "Cannot find module xml2json"
However this command did not result in an error and below is the output after executing this command
xml2json
└── (No dependencies)

Interesting
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/x2js/xml2json.d.ts
It is a global file without declare module "xml2json" {
Also I realize it wouldn't work anyway because global typings can't use alternative name.
@blakeembrey any suggestion?
Since it is a simple typings, I think the best way is to just create the typing repo for it.

@unional To be honest, I don't think that's the same project.

It's entirely probable the typings you want have not been created. You can make a request for them, or create them yourself for now.

I see. Sorry about the wrong information.

All good. @pritpalchahal the typings you want don't exist yet. You can help contribute them or workaround the issue by declaring it locally as a workaround.

as a result, I created it:
https://github.com/types/npm-xml2json

Added https://github.com/typings/registry/pull/676
It should be there in minutes: typings install xml2json --save

Thanks @unional , much appreciated. Can you also let me know how to install typings for X2JS. I have tried following commands..
npm install x2js --save
npm install --save-dev retyped-x2js-tsd-ambient
typings install dt~x2js --global --save
but none of them worked!

Have you try:
typings i x2js=dt~x2js/xml2json -SG

No this command does not work either..

Um..........then the simplest is to port it over, as said before, it is s small typings anyway. 🌷

Will you be able to implement it if you have time..I am very new to Typescript. Thanks.

How have you been using that? I'm trying to install xml2json to my ionic2 project and always I get
src/providers/backend.ts(6,23): error TS2307: Cannot find module 'xml2json'.
I tried:
typings install xml2json --save
typings install dt~x2js --global --save
typings i x2js=dt~x2js/xml2json -SG
typings install dt~xml2json --global --save
typings install xml2json --global --save
typings install xml2js --save
typings install dt~xml2js --save
typings install dt~xml2js --global --save


simultaneous image creation

While several people are trying to create same image simultaneously often due to internal docker reasons (simultaneous building by several independent processes) some of them get 'error 500'
Everware should track progress of image creation and

there is no sense in creating same image for different people (as long as github repo and commit hash are the same)
if image has been created by previous user, everware should just create container from that image for all the following creation attempts
if image is being created, eveware should notify user and ask for some patience until image is created or failed

I had hoped these kinds of race conditions would be taken care of by the dockerd. Should definitely investigate and fix these.

Fixed by #45


How to achieve two way binding in custom tag

Take a example of Input tag.
This code is not reactive
import IInput from './input'

var state = {
    input: 'test'
}

Imba.mount <IInput[state:input] type='text'>

// input tag
export tag IInput
    prop type

    def render
        <self>
            <input[data] type=@type>

I know if I pass whole object & operate on object property then it will be reactive. But I wanna know can I achieve something like two way binding with specific object property.

The way you have it set up, the IInput is receiving a string 'test' as data. So it cannot update the state object. It's like saying:
def foo x
    x = 'test'

foo state:input

You need to pass the whole state object and bind <input[data:input]>.
Alternatively, you can reshape the state like this:
var state = {
    input: {
        value: 'test'
    }
}

And bind <input[data:value]>.


Mode questions

I have some questions on ottawa.csv.  What are these modes for?
Mode155:
It is enabled only on linux_390-64 and linux_aarch64 configurations.
https://github.com/adoptium/TKG/blob/232682673cdbd1a4b818b2b7e13bf4ea39f844c3/resources/modes.xml#L1076
https://github.com/adoptium/TKG/blob/232682673cdbd1a4b818b2b7e13bf4ea39f844c3/resources/ottawa.csv#L62
Mode198 and Mode199:
These modes use the -Xaggressive option, and are enabled only on win_x86-64 and linux_aarch64 configurations.
https://github.com/adoptium/TKG/blob/232682673cdbd1a4b818b2b7e13bf4ea39f844c3/resources/modes.xml#L1945
https://github.com/adoptium/TKG/blob/232682673cdbd1a4b818b2b7e13bf4ea39f844c3/resources/modes.xml#L1966
https://github.com/adoptium/TKG/blob/232682673cdbd1a4b818b2b7e13bf4ea39f844c3/resources/ottawa.csv#L91-L92

It seems that I enabled these modes on linux_aarch64_cmprssptrs by mistake when I added the platform by https://github.com/adoptium/TKG/pull/40.
I opened PR #531 as a fix.

PR #40 enabled Modes 158 and 159 by mistake.
PR #528 fixes Mode158, and #531 fixes Mode159.

What are these modes for?

The mode is a short name for a list of jvm options. We inherited the old logic from vmfarm.
As you listed above,

TKG/resources/modes.xml - defines the list of jvm options for each mode
TKG/resources/ottawa.csv - defines what mode can or cannot run on which platforms. The complexity escalates when it needs to support non-cmprssptrs, cmprssptrs, and mixed JVM using one file.

I think I should have been more clear.
I know what modes.xml and ottawa.csv are used for.  I wanted to know the purposes of Modes 155, 198, and 199 specifically.
I am disabling those modes on AArch64 Linux by #531 any way.


Chapters for some Manga\Manwa download more than once and I can not figure out how to stop it

Describe the bug
Chapters for some Manga\Manwa download more than once and I can not figure out how to stop it.
I lodged the issue in the Kaizoku issue lodger but oae said:

The Comick mangal scraper seems to have problems separating the scans.

https://github.com/oae/kaizoku/issues/51

Reproduction steps
In Kaizoku:

Select Add new manga
Select Comick then click next step
Search for then add "The Male Lead's Little Lion Daughter"4.

Expected behavior
Kaizoku would download only one copy of each chapter of the manga\manwa.
Additional context
This appears to be similar to the following issue
https://github.com/metafates/mangal/issues/100
Perhaps some more logic could be added to determine if a chapter is already downloaded so that when a source has multipe versions it just downlads the highest quality version and records that chapter as downloaded?
Operating System
Linux

The reason for that is that these chapters has different names due to different scanlation groups. I'll take a look on how I can avoid such situations

That would be awesome! Happy to help however I can.


DBFlow Transaction  does not  support  operation of roll back

DBFlow Transaction does not support operation of roll back
DBFlow Version:
All
Bug or Feature Request:
There is no Operation of roll back support.
Description:
Roll back is part of the Transaction operation,  But DBFlow doesn`t support it.

rollback is not supported other than if you throw an exception within the Transaction itself. that will not set the transaction as successful.


Enhancement: Use connection pooler to manage flight client

if changing the connection pooler lib, make sure it's working for postgres too.
Goal-State/What/Result
A clear and concise description of what the enhancement is and the target goal-state.
Why/Purpose
Clear and concise answer to why this should be done now.
By When
A target date for done-done completion of the entire enhancement.
Issue/Spec written and reviewed:
Done-Done:
Done-Done

[ ] First Principles Driven
[ ] The Algorithm
[ ] PM/Design Review
[ ] UX Review
[ ] Threat Model / Security Review
[ ] Tests
[ ] Documentation
[ ] Samples/Quickstarts/Tutorials
[ ] Release Notes

The Algorithm

[ ] Every requirement questioned?
[ ] Delete (Scope) any part you can.
[ ] Simplify.
[ ] Break down into smaller iterations/milestones.
[ ] Opportunities for automation.

Spec
Basic specification of the enhancement.
How/MAP
A clear and concise plan of how this should be implemented.
Implementation (issues)

QA

We don't need a connection pool for flight, but it can definitely be improved to be more efficient.


Can't install voyager-frontend?

when i do composer require pvtl/voyager-frontend  I get an error:
C:\Users\Gebruiker\Desktop\php frmework\Laravel Projects\voyagerfrontend>composer require pvtl/voyager-frontend
Using version ^0.7.0 for pvtl/voyager-frontend
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- pvtl/voyager-frontend 0.7.0 requires spatie/laravel-sitemap 3.3.1 -> satisfiable by spatie/laravel-sitemap[3.3.1].
- Installation request for pvtl/voyager-frontend ^0.7.0 -> satisfiable by pvtl/voyager-frontend[0.7.0].
- Conclusion: remove laravel/framework v5.6.20
- Conclusion: don't install laravel/framework v5.6.20
- spatie/laravel-sitemap 3.3.1 requires illuminate/support ~5.5.0 -> satisfiable by illuminate/support[5.5.x-dev, v5.5.0, v5.5.16, v5.5.17, v5.5.2, v5.5.28,
v5.5.33, v5.5.34, v5.5.35, v5.5.36, v5.5.37, v5.5.39, v5.5.40].
- illuminate/support 5.5.x-dev conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.0 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.16 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.17 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.2 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.28 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.35 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.36 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.37 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.39 conflicts with laravel/framework[v5.6.20].
- illuminate/support v5.5.40 conflicts with laravel/framework[v5.6.20].
- don't install illuminate/support v5.5.33|don't install laravel/framework v5.6.20
- don't install illuminate/support v5.5.34|don't install laravel/framework v5.6.20
- Installation request for laravel/framework (locked at v5.6.20, required as 5.6.*) -> satisfiable by laravel/framework[v5.6.20].
Installation failed, reverting ./composer.json to its original content.
How can I resolve this problem?

Hi @protected22
That one is a composer error caused by unmet dependencies.
Double check that your current project meets the dependency requirements (composer.json) for Voyager Frontend - also keep in mind that we're locked to Voyager 1.0.x at the moment which does not support Laravel 5.6 yet.

maybe then is the Voyager version the problem because I use the most recent one. How can I downgrade to  Voyager 1.0.x?

@protected22 I'm not 100%. You could try changing your composer.json and composer install'ing, although php artisan voyager:install does move files, create DB migrations etc - so I don't know if going backwards is possible.

@protected22 is because you are using Laravel 5.6. You have to use Laravel 5.5. for the voyager-frontend
Best of luck!

Now I tried it with Laravel 5.5 and Voyager.
My cmd log when i used composer require pvtl/voyager-frontend:
C:\Users\Gebruiker\Desktop\php frmework\Laravel Projects\voyager-frontend>compos
er require pvtl/voyager-frontend
Using version ^0.7.0 for pvtl/voyager-frontend
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 18 installs, 0 updates, 0 removals

Installing laravel/scout (v4.0.3): Downloading (100%)
Installing teamtnt/tntsearch (v1.3.1): Downloading (100%)
Installing teamtnt/laravel-scout-tntsearch-driver (v3.0.6): Downloading (con
Downloading (100%)
Installing spatie/temporary-directory (1.1.4): Downloading (100%)
Installing spatie/phpunit-snapshot-assertions (1.2.1): Downloading (connecti
Downloading (100%)
Installing spatie/image-optimizer (1.0.14): Downloading (100%)
Installing league/glide (1.3.0): Downloading (100%)
Installing spatie/image (1.5.1): Downloading (100%)
Installing spatie/browsershot (2.4.2): Downloading (100%)
Installing nicmart/tree (v0.2.7): Downloading (100%)
Installing guzzlehttp/promises (v1.3.1): Loading from cache
Installing guzzlehttp/guzzle (6.3.3): Downloading (100%)
Installing symfony/dom-crawler (v4.0.9): Downloading (100%)
Installing spatie/crawler (2.7.1): Downloading (100%)
Installing spatie/laravel-sitemap (3.3.1): Downloading (100%)
Installing pvtl/voyager-blog (0.1.0): Downloading (100%)
Installing pvtl/voyager-pages (0.1.2): Downloading (100%)
Installing pvtl/voyager-frontend (0.7.0): Downloading (100%)
laravel/scout suggests installing algolia/algoliasearch-client-php (Required to
use the Algolia engine (^1.10).)
Writing lock file
Generating optimized autoload files

Illuminate\Foundation\ComposerScripts::postAutoloadDump
@php artisan package:discover

In PageController.php line 10:
Declaration of Pvtl\VoyagerFrontend\Http\Controllers\PageController::edit(I
lluminate\Http\Request $request, $id) should be compatible with TCG\Voyager
\Http\Controllers\VoyagerBreadController::edit($table)
Script @php artisan package:discover handling the post-autoload-dump event retur
ned with error code 1
C:\Users\Gebruiker\Desktop\php frmework\Laravel Projects\voyager-frontend>
What does that error on PageController mean?

I think it's the latest version (1.1) because idk how to install an other/previous version of Voyager

Try the answer from here: https://github.com/pvtl/voyager-frontend/issues/11#issuecomment-386481429


Encounter a problem when using class binding together with js dom class operation

Version
2.2.5
Reproduction link
https://jsfiddle.net/98b0cgxs/
Steps to reproduce

click button toggle，the background color changed
click button toggle2

What is expected?
excepted result is，only toggled the font color
What is actually happening?
the background color reseted to the initial value

I think, class binding should only affect itself ...

You should not be manually manipulating the DOM controlled by Vue. Use Vue's binding system instead.


Todo: Game JSON

Work out a way of having game list JSON in a seperate file to declutter the html. Can't access a json file but could make a js file and insert the game list as a var

We should be able to access the json. Will have a look and try update

Json file added by @WillGr-dev  but not yet implemented

Implemented json file


[SPARK-28152][SQL][FOLLOWUP][2.4] Add a legacy conf for old MsSqlServerDialect numeric mapping

What changes were proposed in this pull request?
This is a follow-up for https://github.com/apache/spark/pull/25248 .
Why are the changes needed?
The new behavior cannot access the existing table which is created by old behavior.
This PR provides a way to avoid new behavior for the existing users.
Does this PR introduce any user-facing change?
Yes. This will fix the broken behavior on the existing tables.
How was this patch tested?
Pass the Jenkins and JDBC integration test.

Test build #116601 has started for PR 27184 at commit 6b92a9f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21382/
Test PASSed.

cc @shivsood , @HyukjinKwon , @maropu , @srowen , @gatorsmile , @zsxwing

Thank you for review and approval, @HyukjinKwon !

Test build #116601 has finished for PR 27184 at commit 6b92a9f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116601/
Test FAILed.

All Scala/Java test passed and the PySpark failure is due to a known test_memory_limit (pyspark.tests.test_worker.WorkerMemoryTest) flakiness. I also verified this in JDBC integration test manually. I'll merge this PR.

Late LGTM.


fpm docs

The fpm link in the readme points to M_strings

The evils of cut-and-paste!  Thanks; I corrected it.


Allow for one Polly recording that can be reused across multiple tests

I'd like to know if it's possible to create 1 Polly recording that can be reused across multiple tests. Right now each test creates it's own har file which is expected but we'd like to know if Polly allows or has options to record all tests into just 1 file.

You can change the recording name via polly.recordingName = 'Whatever you want'. You can also change it on a per route basis via the recordingName() server method

@jaboulos feel free to open another issue if this isn't what you had in mind.


Issues with TypeScript

Issue 1:
In TypeScript,
import vhCheck from "vh-check";
Will result in the error:
Could not find a declaration file for module 'vh-check'.
Adding the following in package.json will resolve the issue:
  "typings": "dist/vh-check.d.ts",
Issue 2:
Compiling the app with vh-check will result in the error:
ERROR in xxx/node_modules/vh-check/dist/vh-check-types.d.ts
A rest parameter must be of an array type.
> 1 | export declare type Callback = (...arg: any) => void;

Modifying the first line of vh-check-types.d.ts as below fixes the issue:
export declare type Callback = (arg: any[]) => void;
Versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS>

@apptaro Thanks for the insights, I'll fix it promptly
I'm still a typescript newbee :bee:

@apptaro can you check the updated master if everything in order?

Looks good to me. I see types in package.json has been already added four days ago. I will wait for the new release.

ok published.
Let me know if everything's fine

@Hiswe I have updated the library, and everything is fine. Thank you!


fix: Clear EndpointStatuses for PodMonitoring without endpoints

Clear EndPointStatuses when PodMonitoring does not have an endpoint.
This fixes a bug where PodMonitorings without any endpoints have a stale list of endpoints.

Note that this PR also fixes a misconfigured test that was silently failing (https://github.com/GoogleCloudPlatform/prometheus-engine/issues/1097 adds support for a nodepool format with caadvisor)


[stable/coredns] Properly indent pod annotations

Is this a new chart
No.
What this PR does / why we need it:
Currently, only the first podAnnotation is properly indented.  Attempting to add more than one pod annotation results in a yaml parsing error during deploy.  This PR uses the indent function to properly indent pod annotations.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

@azenk  can you bump the chart version here again?

/ok-to-test
/lgtm


[Run] Updated tooltip styling and fixed casing

Summary of the Pull Request

Alignment in tooltip styles: now following the UWP tooltip styling for all themes. (#4711)

Dark theme

Light theme

Fixed casing issue (#4842)

PR Checklist

[X] Applies to #4711 #4842
[X] CLA signed. If not, go over here and sign the CLA

Regarding changing the case of Run As Administrator, it is also present in the indexer plugin. Can that be modified as well?

Can we have generally strings for such reused functions used in all plugins instead have one string for every plugin?

Regarding changing the case of Run As Administrator, it is also present in the indexer plugin. Can that be modified as well?

Happy to update it, but I can't seem to find it. I searched on all strings and think I updated them everywhere. Let me know which file I'm still missing and I'll fix it.

Regarding changing the case of Run As Administrator, it is also present in the indexer plugin. Can that be modified as well?

Can we have generally strings for such reused functions used in all plugins instead have one string for every plugin?

These are strings listed in separate plug-ins. Let's keep it that way, since these are plug-ins they can be easily added, removed or updated.

@niels9001
Is the code from #4807 missing in your PR?

@niels9001
Is the code from #4807 missing in your PR?

Ah, missed that! Thanks for the headsup!
@alekhyareddy28 I have updated Indexer strings with the correct casing as well.

Regarding changing the case of Run As Administrator, it is also present in the indexer plugin. Can that be modified as well?

Can we have generally strings for such reused functions used in all plugins instead have one string for every plugin?

I'm not sure off the top of my head, but I think we can look into that. It would be nice to remove duplicate strings.


View rotation center is incorrect with WebGl renderer

After switching to the webgl map renderer (by adding renderer : 'webgl', in my map construction), I noticed that the rotation center does not match with the view center.
I have also checked this is issue does not occur when renderer is set to either DOM or Canvas.
OS: iOS 8.4
Browser:  a UIWebView, in a native app.

https://github.com/openlayers/openlayers/blob/master/changelog/upgrade-notes.md#drop-of-support-for-the-experimental-webgl-renderer


JWDJ throws syntax error when in DEBUG=0 mode

I've configured a JWDJ instance and am running 207d90f94b7862f996dc5fff1dd042ceaca9612b using docker-compose with sqlite as a backend and no authentication. When trying to run in DEBUG=0 mode in my .env, JWDJ stops working (does not display polls and can't create new ones). The reason seems to be that during the build the polls.js file is instead an HTML file (index page?), leading to this error:
Uncaught SyntaxError: Unexpected token '<' (at poll.5da8590b.js:1:1)

Because the minified polls.js file is:
<!doctype html><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="viewport" content="width=device-width,initial-scale=1"><meta property="og:type" content="website"><meta property="og:title" content="JaWannDennJetzt"><meta property="og:description" content="JaWannDennJetzt is an easy to use, free polling solution."><meta property="og:image" content="/jwdj.png"><meta property="og:url" content="/"><link rel="icon" href="/favicon.svg"><title>JaWannDennJetzt</title><link href="/css/app.f7991ed3.css" rel="stylesheet">We're sorry but JaWannDennJetzt doesn't work properly without JavaScript enabled. Please enable it to continue.

I.e., obviously an HTML file.
My first step was to try to debug this by setting DEBUG=1 in my container and to my great surprise then everything started working again. Please advise if this is an error on my part or a bug in the build. Thanks!

 For some reason my browser AGGRESSIVELY cached the HTML file that was apparently erroneously served before. The issue has nothing to do with JWDJ. Sorry for the disturbance. Cheers!


Docker build

looks like this is breaking the netlify preview somehow, mind looking into this? I rely on it pretty heavily to review PRs so don't want to merge this until that's in a good state :)

I merged your main into my branch and the the build ran successfully this time. The original error message makes it seem like a flaky test could be the culprit:
"Uncaught exception: Error: 'expect' was used when there was no current spec, this could be because an asynchronous test timed out"

Thanks for fixing it -- yeah the tests have some asynchronous calls so unfortunately they can be flaky, but it usually passes locally for me.
I'll go ahead and merge this, but do you want to expand in the readme section about requiring powershell? Just don't want folks to get surprised by that requirement. And maybe a sentence on what advantages this has over building locally :)
thanks a bunch!

(also going to wait on the last checks to run)


Remove developer user from sudoer cluster role

/lgtm
docs needs to be updated in crc. Some examples say the user can do --as system:admin.

@guillaumerose yes I will put PR on crc side for same.

https://github.com/code-ready/crc/pull/2098 PR.

/cherry-pick 4.7


Fail import if unsupported entries exist

We don't yet support merging PlaylistItem, PaylistItemChild,  PlaylistMedia, and InputField entries (I couldn't find a use-case for them yet, so they are probably there for a future feature). To not risk the loss of data, the import should fail if any of these tables contain data.
Also see: https://github.com/AndreasSko/go-jwlm/issues/35

Coverage decreased (-0.05%) to 84.01% when pulling 68707f6d2204ea880025545d04570f5681f36a32 on playlist_check into 5eadb57b7966b0e8fe464e5e8e8557666b94b41b on master.


AutoSizer grows but doesn't shrink in certain conditions

This can be seen on the demo page. :(
I'm not clear of how to fix this. I could use a relatively positioned placeholder (with a height of 0) and a nested, absolutely positioned div that grows to fill the height- but this might cause problems with flex layouts.
For inspiration check out...

https://github.com/nkbt/react-height/blob/master/src/ReactHeight.js
https://github.com/nkbt/react-collapse/blob/master/src/Collapse.js

Might also evaluate using something like this instead of our current resize detection code:

https://github.com/marcj/css-element-queries/blob/master/src/ResizeSensor.js

Current element resize code also causes an occasional RTE to be logged in the console:
Uncaught TypeError: Cannot read property 'firstElementChild' of undefined

what was the conditon where it didn't shrink ?


build: add config to render app in pull requests

The canonicalUrl in environment config is not the proper one when using Cloudflare Pages previews in pull requests. In order to fix that, a new Angular environment is introduced to contain the canonicalUrl for this case.

Current dependencies on/for this PR:

main

PR #48   👈

This comment was auto-generated by Graphite.


Account UX feedback

Refs: #93799
Login to your Microsoft account

Clicking on the account thing shows my account and an option to sign in to another account. I do not find it obvious that if I want to logout I have to click on my account which will give me options. Consider adding word "manage" to the end or start of the account name
Once the account is cliked there is no placeholder text in the quick pick. I suggest to put some placeholder text so it is easier for users to understand what is going on, especaily screen reader users
If sync is not turned on, once I click on my acount offer me a third option to start syncing

Agreed with 1) I didn't realize I could click on my "account" and then getting the quick pick to log out is an extra step. I would have thought there was an option to "sign out of current account" under "sign in to another microsoft account" in the account icon.

Closing, since we now show a submenu instead of having to click the account to bring up a quick pick


Adding KrishnamuthyNumber.java (hacktoberfest)

Adding a program to check if a number is a Krishnamurthy number or not.
A number is a Krishnamurthy number if the sum of the factorials of the digits of the number is equal to the number itself.
For example, 1, 2 and 145 are Krishnamurthy numbers.

hacktoberfest 2021


Add secret name to error log for baseplate

Open JIRA ticket requested more info for this type of error. 👓 @rram  @spladug

👓 @bsimpson63

💅

💇

💇  per convo with @spladug, testing this with onevm would require writing a new authtype for fetch_instance_identity. not in scope for this change.
did make fix to readability.
also, i don't have permissions to restart drone, appears to be failing on a random number test.


[REVIEW] @snitin315 GitHub Sponsor profile

GitHub Sponsor profile link
https://github.com/sponsors/snitin315/

Reviewed on live stream https://www.youtube.com/watch?v=He9lBSlTvhQ
Looks great! Suggestions

limit featured repos to 4 (always an even number)


Spaces are converted into

@TarekRaafat  inside autocomplete dropdown results, all the spaces between words getting converted into   is this known issue? because of this behavior words doesn't break into the next line.

Hello @mufaddalmw,
I've checked the demo and found empty spaces but were not converted into   and without any line breaks as well.

If you could help me replicating your issue that would be great! :)


Failed to submit frame to Kinesis Video client. status: 0x30000005

As shown bellow
DEBUG - Wrote 1756 bytes to Kinesis Video. Upload stream handle: 1

on_new_sample(): kinesis_video_flags=0 pts=4289336818 dts=4289336818
ERROR - Failed to submit frame to Kinesis Video client. status: 0x30000005 decoding timestamp: 42893368 presentation timestamp: 42893368

on_new_sample(): kinesis_video_flags=0 pts=4256005091 dts=4256005091
ERROR - Failed to submit frame to Kinesis Video client. status: 0x30000005 decoding timestamp: 42560050 presentation timestamp: 42560050

on_new_sample(): kinesis_video_flags=0 pts=4322673351 dts=4322673351
ERROR - Failed to submit frame to Kinesis Video client. status: 0x30000005 decoding timestamp: 43226733 presentation timestamp: 43226733

on_new_sample(): kinesis_video_flags=0 pts=4489341597 dts=4489341597
DEBUG - Wrote 1180 bytes to Kinesis Video. Upload stream handle: 1

on_new_sample(): kinesis_video_flags=0 pts=4422676498 dts=4422676498
ERROR - Failed to submit frame to Kinesis Video client. status: 0x30000005 decoding timestamp: 44226764 presentation timestamp: 44226764

on_new_sample(): kinesis_video_flags=0 pts=4389344719 dts=4389344719
ERROR - Failed to submit frame to Kinesis Video client. status: 0x30000005 decoding timestamp: 43893447 presentation timestamp: 43893447

on_new_sample(): kinesis_video_flags=0 pts=4456012928 dts=4456012928
ERROR - Failed to submit frame to Kinesis Video client. status: 0x30000005 decoding timestamp: 44560129 presentation timestamp: 44560129

Some frames don't get saved to KVS, is this because of how the movie was encoded? Because I have other samples where I don't have any issues.
I'm asking to be sure where to look, and also to better understand your producer app.

Pl. refer the details on the status code here: Status Codes Reference for Producer SDK integration with Media pipeline (camera and other video stream sources)

@davidgatti , as @unicornss mentioned, Status Codes Reference doc is a great source of information when it comes to issues like these.
Looking at your case, please ensure you have a stable encoder. We could try to help a little more if you describe what your scenario is, what's your setup - media pipeline (GStreamer? what kind of elements, etc...). What's your end-to-end scenario?

OO, cool that page is on point, thanks for the tip @unicornss. @MushMal regarding your proposition. Right now I'm doing R&D for a client and see how to take advantage of KVS. This is my test setup:
VLC Server - no transcoding
vlc -loop -vvv bunny.mp4 --sout '#rtp{sdp=rtsp://:8554/}'

Then I paste the RTSP URI, to the C++ app, and of it goes to KVS.
VLC Server - with transcoding
vlc -loop -vvv blender.mov --sout '#transcode{vcodec=h264,scale=Auto,acodec=mpga,ab=128,channels=2,samplerate=44100}:rtp{sdp=rtsp://:8554/}'

Then I paste the RTSP URI, to the C++ app, and of it goes to KVS, while some time missing some frames.
VLC Server - with transcoding and image resize
vlc -loop -vvv blender.mov --sout '#transcode{vcodec=h264,scale=Auto,width=640,acodec=mpga,ab=128,channels=2,samplerate=44100}:rtp{sdp=rtsp://:8554/}'

Then I paste the RTSP URI, to the C++ app, and of it goes to KVS, while some time missing some frames.
My additional questions
This are some questions that I have after reading the error page.

The encoder produces a burst of encoded frames, and their time stamps are smaller than the intra-frame durations.

Is this sentence trying to imply that the VLC in this case is sending frame faster then the playback itself?

The stream is configured to use SDK time stamps, and the frames are sent faster than the frame durations. To help with some "jitter" in the encoder, specify a smaller frame duration in the StreamInfo.StreamCaps structure. For example, if the stream is 25FPS, each frame's duration is 40 ms. However, to handle the encoder jitter, we recommend that you use half of that frame duration (20 ms). Some streams require more precise control over the timing for error detection.

This "jitter" situation is bit strange, let me explain: from the AWS materials what I got is that KVS will set its own time stamp to the frames, this way "I" don't have to worry about that. So the data is saved correctly.
Based on the above quote it seams that there is more granular control, and either I set a time stamp or you do. Is this the correct assumption?
Why should KVS care about the speed?
Why should KVS care if the frame are coming faster or slower? Can't KVS just buffer them, and save them in a FIFO manner?

@davidgatti thanks for the details.
Some encoders/muxers might delay the frames based on the complexity of the encoding resulting in smaller intra-frame delays. In your case its possible that the VLC does transcoding and produces burst in frames. KVS stream can be configured to use the provided frame timestamps or timestamp it directly as the frames are pushed into the KVS. StreamDefinition.frame_timecodes is set to "true" by default which means that the KVS will use the frame timestamp. If we drop a frame with the "overlap" error this means that the encoder upstream has produced timestamps which overlap with the previous frames timestamp + the previous frames duration. If the "jitter" is small, you can attempt to shorten the frame duration (I haven't experimented with the VLS server with transcoding).
Some encoders do produce bursts of frames with no timestamps so the KVS based application would use StreamDefinition.frame_timecodes = false (so the KVS will timestamp on arrival of the frame) and have a temporal buffer of a few frames deep that would accumulate the frames and release to KVS in a delayed order. Others, would use very small frame durations to handle the jitter. The default in the sample application is 20 ms. (create_kinesis_video_frame())
In either case, KVS will utilize the internal buffer.
We are working on adding some heuristics to the sample application that would select the frame durations based on the FPS and more resilient to the jitter.

OK, interesting, thanks for the extra information - i'll take the time to process it :)

@davidgatti , as @unicornss mentioned, Status Codes Reference doc is a great source of information when it comes to issues like these.
Looking at your case, please ensure you have a stable encoder. We could try to help a little more if you describe what your scenario is, what's your setup - media pipeline (GStreamer? what kind of elements, etc...). What's your end-to-end scenario?

@davidgatti , as @unicornss mentioned, Status Codes Reference doc is a great source of information when it comes to issues like these.
Looking at your case, please ensure you have a stable encoder. We could try to help a little more if you describe what your scenario is, what's your setup - media pipeline (GStreamer? what kind of elements, etc...). What's your end-to-end scenario?

I am trying with rtsp rtsp://<IP_ADDRESS>/vod/mp4:BigBuckBunny_175k.mov and still getting 0x30000005 issue
any idea?

@davidgatti , as @unicornss mentioned, Status Codes Reference doc is a great source of information when it comes to issues like these.
Looking at your case, please ensure you have a stable encoder. We could try to help a little more if you describe what your scenario is, what's your setup - media pipeline (GStreamer? what kind of elements, etc...). What's your end-to-end scenario?

@davidgatti , as @unicornss mentioned, Status Codes Reference doc is a great source of information when it comes to issues like these.
Looking at your case, please ensure you have a stable encoder. We could try to help a little more if you describe what your scenario is, what's your setup - media pipeline (GStreamer? what kind of elements, etc...). What's your end-to-end scenario?

I am trying with rtsp rtsp://<IP_ADDRESS>/vod/mp4:BigBuckBunny_175k.mov and still getting 0x30000005 issue
any idea?

have you make it work? i'm having the same error in a android emulator

@guillermoAlv I didn't do Android development for over 10 years now, but I'm 99.99% sure Google didn't improve it much ;) and way back when it was super slow, and hardware acceleration was not a thing Google was aware of ;) I'm sure they didn't improve much with it.
Meaning you'll never have a good stream - but if they maybe updated the emulator (haha), search for an option for hardware acceleration (good luck), and that should improve things (lol).
Sorry for the sarcasm, I had to do it :D


8-Forbid creating a new order if user doesn't have enough money

Related

#8
#14
#5

Useful

https://github.com/janis-rullis/pr1/wiki

Due date

March 2, 2020.

#18 Evaluate @lauris-printify code against requirements in the MVP
This is combined with Order #11. Works for MVP.


Apply logarithm to score in hostdb output

It is hard for humans to operate with numbers which are in scale from 1e-16 to 1e+08.

I don't want to do a logarithm because users will get confused about their score. They might see that they are at score '75', and that the top 50 hosts are at score '85', and think that they are pretty close. But in a logarithm, 75 and 85 are very, very far apart.
Instead we can probably replace anything below 1 with '0' or '<1', and we can probably replace anything above 100k with '100k+'
The majority of useful hosts will fall within the range 1 to 100k.


Document redirect problems with --pretty (refs #1008)

Codecov Report

Merging #1025 (98eecff) into master (0401d7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   95.35%   95.35%
=======================================
  Files          57       57
  Lines        3766     3766
=======================================
  Hits         3591     3591
  Misses        175      175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0401d7b...98eecff. Read the comment docs.

Codecov Report

Merging #1025 (98eecff) into master (0401d7b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   95.35%   95.35%
=======================================
  Files          57       57
  Lines        3766     3766
=======================================
  Hits         3591     3591
  Misses        175      175

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0401d7b...98eecff. Read the comment docs.

Thanks, @Almad. It’s bit more nuanced:

That issue relates specifically to colors, which can be enabled with both --format=all and --format=colors
It is specific to Windows.
It may have to do more with how colors are represented on Windows than with an encoding mismatch.

I’d find out what actually gets written to the file when colors are applied. And then see if it even makes sense to allow non-terminal coloured output on Windows: does cat ./output correctly reproduce the coloured output?  Perhaps the best solution will be simply disabling colors on Windows unless the output is a terminal.

Thanks, @Almad. It’s bit more nuanced:

That issue relates specifically to colors, which can be enabled with both --format=all and --format=colors
It is specific to Windows.
It may have to do more with how colors are represented on Windows than with an encoding mismatch.

I’d find out what actually gets written to the file when colors are applied. And then see if it even makes sense to allow non-terminal coloured output on Windows: does cat ./output correctly reproduce the coloured output?  Perhaps the best solution will be simply disabling colors on Windows unless the output is a terminal.

It makes sense to not pollute the docs—this should be sufficiently googleable for people looking for workaround. Closing until we do a real fix, which is to research coloring on Windows and potentially disable color output when on Windows and redirecting to a file.


Sidecar injection: Include the admin-http port

Judging from the code, at some point the jaeger-agent accepted metrics scrapes on the other HTTP port (config-rest), but that is no longer the case.  So this change exposes the admin-http port, which does accept metric scrapes.
(It appears that the 1.12.0 release changed this port, see https://github.com/jaegertracing/jaeger/pull/1442 )
I am actually confused as to why any of the other ports are exposed; the idea of the sidecar is that these ports only show up to other containers in the pod on <IP_ADDRESS> and it would be somewhat harmful if other applications started sending traces to the pod address.  But they're there, so I didn't touch them.

Looks like GitHub CI is having some problems at the moment. I tried to re-run the jobs, but it kept failing. Would you be able to run a git commit --amend and update this PR? Hopefully this would bypass GitHub's issues...

I did that, let's see how it goes!

Thanks for your PR!


pkg_resources module causes a delay of between 0 and many seconds every time bst starts up

See original issue on GitLab
In GitLab by [Gitlab user @samthursfield] on Dec 14, 2017, 19:00
We currently use the pkg_resources module from setuptools to do 3 things:

operate the /usr/bin/bst and /usr/bin/bst-artifact-receive hooks generated by setuptools
report the BuildStream version number
discover plugins installed with Pip

Importing pkg_resources causes a scan of every installed Python module, which can take be a significant slowdown. On my system it typically takes 0.3 seconds to run python3 -c 'import pkg_resources'; running bst --help typically takes 0.5 seconds, of which more than half is spent in the pkg_resources module. The upstream bug report shows that pkg_resources can take 2 seconds or more to import in some scenarios.
Upstream bug: https://github.com/pypa/setuptools/issues/510

In GitLab by [Gitlab user @samthursfield] on Dec 14, 2017, 19:08
mentioned in merge request !196

In GitLab by [Gitlab user @samthursfield] on Dec 14, 2017, 19:13
changed the description

In GitLab by [Gitlab user @samthursfield] on Dec 14, 2017, 19:13
changed the description

In GitLab by [Gitlab user @gokcennurlu] on Jan 15, 2018, 14:00
mentioned in merge request !231

In GitLab by [Gitlab user @gokcennurlu] on Jan 15, 2018, 14:34
mentioned in merge request !232

In GitLab by [Gitlab user @gokcennurlu] on Jan 15, 2018, 15:27
mentioned in merge request !234

In GitLab by [Gitlab user @gokcennurlu] on Jan 31, 2018, 14:44
closed via commit<PHONE_NUMBER>a9ba8f461e302d2852c54023356826

In GitLab by [Gitlab user @juergbi] on Jan 31, 2018, 14:44
closed via merge request !231

In GitLab by [Gitlab user @samthursfield] on Jan 31, 2018, 14:46
reopened

In GitLab by [Gitlab user @gokcennurlu] on Feb 2, 2018, 11:30
If this issue is limited to pkg_resources only, I think this can be closed now as the points mentioned in the description are handled by !231, !234 and !232 respectively.

In GitLab by [Gitlab user @samthursfield] on Feb 6, 2018, 10:25
Yes, looks fixed to me. Thanks :-)

In GitLab by [Gitlab user @gokcennurlu] on Feb 19, 2018, 13:39
mentioned in commit<PHONE_NUMBER>a9ba8f461e302d2852c54023356826

In GitLab by [Gitlab user @samthursfield] on Feb 20, 2018, 12:52
closed

In GitLab by [Gitlab user @samthursfield] on Feb 20, 2018, 12:55
This is fixed now.
This benchmark run shows the improvement in startup time:

bst 1.0.0: 0.44-0.48 seconds to run bst --help, 32MB of RSS
bst 1.0.1: 0.43-0.47 seconds to run bst --help, 32MB of RSS
bst commit 0f430622e4: 0.22-0.3 seconds to run bst --help, 22MB of RSS


Inheritance hierarchy improvements, reduced dependencies to Disk class

The host services and host bridge devices are not a subclass of Disk anymore
Duplicate code was removed

@akuker Any chance to get this PR reviewed soon? ;-) I would like to work on https://github.com/akuker/RASCSI/issues/664, https://github.com/akuker/RASCSI/issues/663, https://github.com/akuker/RASCSI/issues/660 next or https://github.com/akuker/RASCSI/issues/619, but this PR should be merged first.

@akuker Any chance to get this PR reviewed soon? ;-) I would like to work on #664, #663, #660 or #619 next, but this PR should be merged first.

@uweseimet - Done!

@akuker Cool, thank you!

@rdmark You might want to add support for the SCHS device to the web UI. This device does not have any special properties, so essentially all that can be done is attaching and detaching it.

@uweseimet Thanks for the heads-up. I'm thinking of adding a new class of devices, STANDALONE, and add a new UI flow for attaching this kind of device.

@rdmark I'm not sure whether STANDALONE is an appropriate name. IMO the best way to attach the host services device is to use a LUN > 0, in order to not use up a device ID. It is unlikely that somebody would use RaSCSI just for the host services. Usually you will attach one or more mass storage devices, and would add the host services on top. Using the host services requires matching (new) client drivers anyway, and these drivers should support LUN > 0 for highest flexibility.

@uweseimet Apologies, I haven't really been following the development of this new device type closely! While attaching to LUN >0 is recommended, it still will work on LUN 0, right?
You haven't documented the usage of the Host Service anywhere yet, have you? I wonder if for future improvements, having a blurb in the manpage would be helpful (perhaps a bullet point for each supported device type, actually.) Thoughts?

@rdmark Yes, it will work with any LUN. (Remember that the protobuf interface returns information on which LUNs are supported by which device type.) But the more devices you attach, the more important it becomes to avoid using up device IDs, because some existing/old drivers only support LUN 0.
The usage from a developer's perspective is documented in host_services.cpp. A regular user only needs to know how the client drivers work, which is platform dependent. This means that user documentation has to be part of client software making use of this features.
My realtime clock client for the Atari, for instance, is usually put into a special folder, so that it is automatically launched when booting. This is similar to a Mac extension (I think that's how they are called), which is launched when the Mac is booting. My client automatically detects the device ID and LUN of the realtime clock device, gets date and time from it, and then sets the Atari clock accordingly. So the instrucitons for the user basically say: Just put the tool into this folder, and your clock will automatically be set when booting.

@uweseimet Here is a first attempt at a Web UI for attaching the Host Service. Rather than "Standalone", here I'm using the term "Support Device" for the category of devices that the Host Service is (the only) member of. Do you agree that this is a better description?
BTW, are you planning to distribute your Atari host service software? I was curious if you had thought about discoverability for other Atari users of RaSCSI? For instance, the Web UI section for DaynaPORT points back to the RaSCSI wiki for more information on how to install the drivers on Mac and Atari.

@rdmark Yes, I am going to distribute my Atari client software, but not before there is an official RaSCSI release with these features. And because I also want to support printing from the Atari with the new SCSI printer device I may wait even longer, because the printer may not be part of the next RaSCSI release.
Users of my driver software should not have any problems finding the RaSCSI site. There is even a special RaSCSI-related area in my forum.

@uweseimet Well noted on your roadmap and plans to publish the software.
I've tweaked the help text and heading to make it clear that the functionality is experimental at this point.


look at scale transformation on iframes / html images for table view

this seems to be working correctly for the raster dataset


Make it work for users without translation tiers or badges

For users without translation tiers or badges, createDWP cannot find anywhere relevant to put the dwp-progress element.

Thanks. Sorry for taking so long to merge.


Fix for ISSUE-24: Order issue with Object.Assign in getInitialState

In the componentWillRecieveProps method, the newProps are spread across the existing state using Object.Assign. The order that the properties are assigned causes new props to be overwritten by existing ones if they are already present in the state. Rearranged these so that the new props are always assigned last, thus overriding existing values in the state.
Address Issue https://github.com/DominicTobias/react-image-crop/issues/24

Gong to close this since


How to use this TORCS in reinforcement learning ?

I notice that image is available through shared memory with C/C++.
But for reinforcement learning, I also need to send control instruction to it. What's more, it's better to get image via python, since python is more popular in RL.
Regular version of gym-TORCS only supports 64 * 64 image, which size is too small .

hi @18605973470 , sorry for my late reply. Please refer to https://github.com/xinleipan/py_TORCS for a version of driving environment compatible with python, it's more flexible than this one.

hi @xinleipan
I can run py_TORCS without crash only under a few tracks (eg. michigan). Many tracks may cause a segmentation fault. I don't konw why.
/usr/local/bin/torcs: line 53: 13327 Segmentation fault      (core dumped) $LIBDIR/torcs-bin -l $LOCAL_CONF -L $LIBDIR -D $DATADIR $*

@18605973470 that is because we want to be able to provide the segmentation for that environment. We didn't do this for other environments, only the michigan way environment now. If you want to provide the segmentation for other environments, you will need to modify the code accordingly, I'll try to provide the instruction on how to modify the code

@xinleipan
I am looking forward to the guidance to add more customized tracks 👍
I really need it ! :)

By the way, how can I disable segmentation if I don't need it ?

@xinleipan @XiaoZzai
I want to implement the experiment "virturl to real-RL".I found the above version link is invalid.Is there any open source code for reinforcement learning of image input?
Thanks.

@lingyunli1994 sorry about that, the environment was (not sure why) set to private. Now it is public!

@xinleipan
Thank you very much for your answer.
I notice that you have selected 1762 images in the 45k real images, how to selected? Is it randomly selected? Is the selected image associated?

@lingyunli1994 since segnets was originally trained on another driving data, their performance on the driving data I got was not very satisfying, so we picked up the best data with high quality segmentations. Ideally you should have humans label the data to make sure the training data you get is clear enough.

@XiaoZzai we didn't try with DDPG with continuous control and you are more than welcome to give a try! If you are also interested in model-based continuous control, our new paper open sourced here provide the code to train a continuous control policy: https://github.com/ucbdrive/spc


cmake: Pass -DENABLE_FUZZERS=ON to enable building fuzzers

Fuzzer build is now based on an argument passed to cmake.
With this, macos builds can now be verified for each pull request.

@DichenZhang1 with this cmake builds on macos will also be verified.
Can you please review?
Thanks.


Keep warm

Zappa by default keeps the function warm, it seems: https://github.com/Miserlou/Zappa/blob/3ccf7490a8d8b8fa74a61ee39bf44234f3567739/zappa/cli.py#L1169
But we are still seeing long cold starts. Why could that be?

Because it only keeps one instance warm?

Since it's one of the fundamental downsides to Lambda there's not much we can do for low-traffic services. Maybe display a "please stand by" banner in the client.

Because it only keeps one instance warm?

If it's low traffic, then it shouldn't be an issue that it only keeps one instance warm.
Relevant issue here: https://github.com/Miserlou/Zappa/issues/851

Because it only keeps one instance warm? Terracotta pretty much always fires at least a couple of requests at once, so during a cold start only the first request hits the warmed-up instance, while the others trigger a cold start of one new instance each.

Wrote my previous comment before you edit @dionhaefner, I see the issue there.

This guy has a custom keep-alive script that he uses to keep 10 containers warm https://www.zrzka.dev/2016/10/30/aws-journey-api-gateway-lambda-vpc-performance.html

If you keep too many containers warm it just becomes a more expensive version of EC2. Don't know how much there's to gain.

If you keep too many containers warm it just becomes a more expensive version of EC2. Don't know how much there's to gain (10 might be fine though).

I think it would have to be quite a lot of containers we would be keeping warm, for it to be more expensive than EC2? According to the blog post i just linked, we only have to fire n requests about every 15 minutes, where n is the number of containers to keep alive. Remember that the first million requests per month are free and that we are talking about low-traffic services here.

For 10 containers, we are talking ~30000 requests per month

But I don't think that this should be a Terracotta feature? Seems more like something you would set up on the side. Maybe we can mention it in the docs.

Yep. It would be cool if you could do some testing with that.

Yep. It would be cool if you could do some testing with that.

Will do.

I thought once there was one warm container, spinning up more was comparatively cheap because they just clone the existing one (rather than cold-starting new instances from scratch). So all you would need is a seed. But maybe cloning is still too expensive (we are talking many concurrent requests for TC) or my understanding was wrong.

If there is such as thing as cloning (and this is the first time I hear about it) it's not effective enough 😕

A Microsoft guy talked about that the other day. Aparently Azure Functions do that. I took it for general practice.

That was also how I understood it, that once the first container was running, they basically just did a memcpy to spawn the others.

see also an attempt here #1790

https://read.acloud.guru/how-to-keep-your-lambda-functions-warm-9d7e1aa6e2f0


Metriql cannot find parent models of dbt metrics

I have a (valid) dbt metric defined as follows:
  - name: orders
    label: Orders
    model: ref('orders')
    description: The number of orders

    type: count

    timestamp: order_date
    time_grains: [day, week, month, quarter, year]

    dimensions:
      - status
      - customer_id

When running metriql serve I get the following error:
May 26, 2022 1:36:06 AM com.metriql.dbt.DbtManifestParser parse
INFO: Parsing 30 nodes, 0 sources and 4 metrics
Exception in thread "main" Unable to find `orders` metric's parent model `ref('orders')`

I have a model named orders, ran dbt compile just before running metriql serve, and confirmed the orders model is in my manifest.json.
Changing quotation styles and including the package name did not help.
Version/environment
This is using Docker with docker pull buremba/metriql:latest

Hmm, I believe that it's because your dbt model doesn't have meta.metriql property and since Metriql ignores these dbt resources, it's not able to resolve the reference. I just added a warning here: https://metriql.com/reference/dataset/
That being said, it seems to be an edge case that we need to think about. What do you think about the best approach? Maybe we can allow other entities to resolve references but don't map them as datasets?

Oh I see, I didn't realize I needed to add that. Thank you!
To me, it would make sense to parse the dependencies but not expose them, like you say.
FYI that it looks like your warning isn't being rendered correctly.


hero image has to be configurable per page

This is now done, now we just need to specify which page has which hero image. If none specified then the site wide image will be applied.


ReadOnlyAPIDataVolumes feature gate missing

This is a Bug Report

Problem:
It seems that Kubernetes previously had a feature gate named ReadOnlyAPIDataVolumes; however, Feature Gates (removed) does not mention that feature gate.
Proposed Solution:
Update Feature Gates (removed)  to mention ReadOnlyAPIDataVolumes.
Page to Update:
~https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/~
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/

A web page that mentions the former feature gate: https://stackoverflow.com/questions/54321991/mount-kubernetes-secret-as-a-file-with-rw-permission

/assign

/triage accepted
/language en

/sig storage

According to CHANGELOG:
CHANGELOG/CHANGELOG-1.12.md:* The feature gates `ReadOnlyAPIDataVolumes` and `ServiceProxyAllowExternalIPs`, deprecated since 1.10, have been removed and any references must be removed from command-line invocations. ([#67951](https://github.com/kubernetes/kubernetes/pull/67951), [@liggitt](https://github.com/liggitt))

According to CHANGELOG:
CHANGELOG/CHANGELOG-1.12.md:* The feature gates `ReadOnlyAPIDataVolumes` and
`ServiceProxyAllowExternalIPs`, deprecated since 1.10, have been removed and any references
must be removed from command-line invocations.
([#67951](https://github.com/kubernetes/kubernetes/pull/67951), [@liggitt](https://github.com/liggitt))

Hi @tengqm @sftim so from this reference we don't need to add ReadOnlyAPIDataVolumes feature gate? and if so can we close this issue ?

/priority important-longterm

@PriyanshuAhlawat I don't see any updates; so unassigning you. Please feel free to assign, if you come back here again and are willing to work on 🙂
/unassign @PriyanshuAhlawat

/assign @sreeram-venkitesh

@sreeram-venkitesh How's this work going?

i would like to work on it.
/assign

Thanks @tamilselvan1102


AppLovin <IP_ADDRESS>.3

Context: https://zng-commons.slack.com/archives/C041VM54C3U/p1695391687290069.
Essentially making the AppLovin SDK instance static in order to be reused by the settings setters.

Should we link to channels that won't be accessible by anybody else? 🤔

Should we link to channels that won't be accessible by anybody else? 🤔

It's just for us actually so it's fine

@bichenwang check again. thanks.


jQuery code doesn't work in visual builder

Problem Description
I am working on a module which will have jQuery/JS code, I am putting the js inline with the code HTML output. It works fine on the front-end but doesn't work at all within in visual builder. I am working on 'partial' support module first so I have no jsx file at all.
Module Code
I have actually created a small test module to get help, this is just a simple module which outputs some text and has a button to hide text on click with jQuery. This even doesn't work.
class ET_Builder_Custom_Button extends ET_Builder_Module {
function init() {
	$this->name       = esc_html__( 'Custom Button', 'et_builder' );
	$this->slug       = 'et_pb_custom_button';
	$this->vb_support = 'partial';
	$this->main_css_element = '%%order_class%%';

	$this->custom_css_fields = array(
		'main_element' => array(
			'label'    => esc_html__( 'Main Element', 'et_builder' ),
			'no_space_before_selector' => true,
		),
	);

	$this->settings_modal_toggles = array();

	$this->advanced_fields = array(
		'borders'               => false,
		'button'                => false,
		'margin_padding' 		=> false,
		'text'                  => false,
		'text_shadow'           => false,
		'background'            => false,
		'fonts'                 => false,
		'max_width'             => false,
	);

}

function get_fields() {
	$fields = array(

		'button_text' => array(
			'label'            => esc_html__( 'Button Text', 'et_builder' ),
			'type'             => 'text',
			'option_category'  => 'basic_option',
			'description'      => esc_html__( 'Input your desired button text.', 'et_builder' ),
			'toggle_slug'      => 'main_content',
		),

	);

	return $fields;
}

function render( $attrs, $content = null, $render_slug ) {
	$button_text = $this->props['button_text'];

	// Render module output
	$output = sprintf(
		'
This is a paragraph.

This is another paragraph.

		<button>%1$s</button>

		',
		$button_text
	);

	return $output;
}
}

new ET_Builder_Custom_Button;

Front-END gif

Visual Builder gif

QA Checklist
Reporter

[ ] Helpful title used

Helpful title format: Scope(s) :: One Sentence To Describe The Issue
Example: VB :: Floating Toolbar :: Jumps To Top Of Page

[ ] Detailed description

Description should usually be 150+ characters.

[ ] Steps to reproduce included
[ ] Support Ticket URL included
[ ] Image and/or gif

Developer

[ ] Steps to reproduce proven solved
[ ] Test included and coverage acceptable and all Tests passing?
[ ] PR description has layman's description of problem and solution and "Areas Affected" listed/explained?
[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Estimated points on issue
[ ] Proper code documentation and conventions?
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Peer Review

[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Steps to reproduce proven solved
[ ] Affected areas are tested and ok
[ ] Proper code documentation and conventions
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Quality Assurance

[ ] All tests passed on CircleCI.
[ ] Steps to reproduce passed, the fix works.
[ ] No errors in console or output
[ ] Affected areas are tested and ok
[ ] The fix does not change a customer's website in any surprising or unintended way

[ ] If Divi's design is adjusted, settings are migrated gracefully and invisibly

Design Review

[ ] UI is to spec
[ ] UX is to spec
[ ] Design is to spec
[ ] No surprising visual changes to a customer's website will be experienced after updating

[ ] Any/all visual changes are migrated gracefully

Dev Review

[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?
[ ] i18n used if applicable
[ ] Implementation acceptable, DRY, Scaleable, future safe
[ ] Best practices used, cleverness and grokage, ES6 use, etc.

I think the problem is that you use document ready to register a click listener. This means that the listener is registered only once after the document loaded. Since your module output is renered using a ajax call it is added later to the page. Therefore your listener is then not registered to the button and a click does nothing.

what about needing a registered enqueable js file?  It seems that partials are rendered after docready and, thus, do not necessarily get listeners, etc., associated with that module output.
Since I'm getting the notion that you've licked this, how do you enqueue registered js files in a react component?

Simply enqueue it. The visual builder is running on the frontend so wp_enqueue_script should do fine. Just make sure not to depend on document ready

My first comment was about how to get registered js to fire again after an ajax call for partial compatibility.
My second was concerning fully compatible modules.  So, when the js is enqueued in this instance by the php module def, then it's ready when the VB renders?  No need to declare dependency of any kind in the jsx?

No, you have to enqueue the script in the plugin file or somewhere else I believe. At least not in the render() function of the php module. You JS is problematic as it waits for the document to be ready and then registers itself to listen for clicks on the "button" selector. If you add your button later after the doc has been loaded already, there will be no listener added to that new button. Check out the stackoverflow article.
When making your react module, you could for exampel use a ref="mybutton" attribute on your button in the render() function and then use the componentDidUpdate() function to re-add your JS code using const button = findDOMNode(this.refs.mybutton); and then use simple jQuery to add the listner like $(button).click(...). In this scenario you have to import jQuery and findDOMNode like
import $ from 'jquery';
import { findDOMNode } from 'react-dom';

Same here but I have my jQuery code (very simple like yours) in the frontend.js file (as recommended). It doesn't work when using the visual builder.
(the code just finds a element and when is hovered shows/hides other element content)

So, if I need salvattore.js, which is registered by Divi and enqueued in the Blog.php class render function, to work in VB in partial or on compatibility, how do I get that to fire again after ajax for partial or even to work in full VB?  I haven't gotten that far, yet, with the case in using the js lib in full mode, but I assuming I'll have a similar problem.
Sorry to be a bonehead, but if I want to use a Divi provided asset, there should be a standard for incorporating it.

In full VB mode its easy. You can use componentDidUpdate() which is called after your render() function has finished. In it you can use a combination of findDOMNode() and usual jQuery to setup what you need.
In partial mode it is a bit more complicated as you don't really know when your module is added. One trick you could try would be to observe the body tag with a MutationObserver.
If the library you depend on is only enqueued in one of the modules, it would be a good idea to enqueue it yourself on plugin level (so always, not on a module level because it would not get enqueued on pages where this module is not present). I'd even go so far and make the library a depenency of your own JS.

Thnx, Jan.  You've opened my eyes a little.  I DO enqueue that library in the same manner as Blog.php.  In the interim until ET makes their change in the BB (Nick's first comment in dividevs.slack), it would be helpful to know what the ajax call does.  Of course, I'm not asking what ajax is ;^)

I believe the ajax call simply calls the render function of your module and returns the output back to the VB where it is then put inside a wrapper or so. I'd wish the documentation was a bit better :P

Hey @xxtesaxx
Thank you so much for being so helpful and I guess the best way is to go with full VB support as things may get easy there as compare to partial support workaround.
I will head in that direction now, I hope we get more examples by ET soon.

I've taken some of this dialogue and have found a possible "work-around." Since partial compatibility causes those modules to be rendered after the full page renders, some js, generally those scripts without listeners, etc., do not fire.
From xxtesaxx's contributions, I looked for a way to get js like the above to fire after an ajax call. I haven't perfected what I need to happen, but what I mentioned earlier here is less of a problem. In essence, you can create an event handler to listen for when ALL ajax has completed and then execute code. It would go something like this when placed in a "custom.js" file, probably in a docready segnment:
$( document ).ajaxStop(function() {
...put your code here...
});
This works even after making a settings change in a partial module.

True enough; there appears to be a timed ajax call from something that occurs every 60secs, but not of my doing.  Having found that, I included a test in my script to bounce under a certain condition.


Measure code coverage only for unit tests

Summary

Measure code code coverage only with unit tests.

How to test

Checklist

[ ] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Codecov Report
Base: 83.93% // Head: 78.15% // Decreases project coverage by -5.78% :warning:

Coverage data is based on head (83e80fa) compared to base (3aa4742).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #806      +/-   ##
===========================================
- Coverage    83.93%   78.15%   -5.78%
===========================================
  Files          174      174
  Lines        22941    22941
  Branches      4973     4973
===========================================
- Hits         19255    17930    -1325
- Misses        2559     3950    +1391
+ Partials      1127     1061      -66

Flag
Coverage Δ

macos-11_Python-3.10
?

macos-11_Python-3.7
?

macos-11_Python-3.8
?

macos-11_Python-3.9
?

ubuntu-20.04_Python-3.10
78.10% <ø> (-5.75%)
:arrow_down:

ubuntu-20.04_Python-3.7
77.70% <ø> (-5.84%)
:arrow_down:

ubuntu-20.04_Python-3.8
78.05% <ø> (-5.75%)
:arrow_down:

ubuntu-20.04_Python-3.9
78.06% <ø> (-5.75%)
:arrow_down:

windows-2019_Python-3.10
?

windows-2019_Python-3.7
?

windows-2019_Python-3.8
?

windows-2019_Python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

datumaro/cli/__main__.py
0.00% <0.00%> (-88.78%)
:arrow_down:

datumaro/cli/util/project.py
23.61% <0.00%> (-70.84%)
:arrow_down:

datumaro/cli/commands/commit.py
29.62% <0.00%> (-70.38%)
:arrow_down:

datumaro/cli/commands/transform.py
19.04% <0.00%> (-67.86%)
:arrow_down:

datumaro/cli/commands/describe_downloads.py
19.23% <0.00%> (-65.39%)
:arrow_down:

datumaro/cli/commands/detect_format.py
21.42% <0.00%> (-64.29%)
:arrow_down:

datumaro/cli/commands/merge.py
20.20% <0.00%> (-61.62%)
:arrow_down:

datumaro/cli/commands/info.py
17.24% <0.00%> (-60.35%)
:arrow_down:

datumaro/cli/contexts/util.py
30.95% <0.00%> (-59.53%)
:arrow_down:

datumaro/cli/commands/generate.py
34.37% <0.00%> (-59.38%)
:arrow_down:

... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Dropdown validation issues

isValid state is different from props in the following example:
initialState = {active: true}

handleToggle = () => {
    setState({ active: !state.active })
};

handleChange = (value) => {
	state.active = value === "none" ? false : true
    setState({ active: state.active})
};

  <Dropdown isValid={state.active} onChange ={(value) => this.handleChange(value)} customLabel="dropdownlabel">

    Bird
    Cow
    Cow Bird Pick Cat Dog Monkey Human
    Monkey
    eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee
  </Dropdown>

  <Button primary onClick={handleToggle}>Toggle State: {state.active.toString()}</Button>

Replication:
Change value to "none", the blank value.  It should invalidate, and you'll see the state change to FALSE
Change value to anything else, the state will change to TRUE
Button is only there for a visual representation of the state


Search feature

As django admin does search_fields are available, and you can filter using doble underscore (__) to search across objects.
split_space_search split search text in parts using the string provided, this can be usefull to have better results but have impact in search performance, if split_space_search is True then ' ' is used
    class Myclass(CRUDView):
        model = Customer
        search_fields = ['description__icontains']
        split_space_search = ' ' # default False

NOTE: icontains is not set by default as django admin does, so you need to set if not equal search is wanted

I've fixed a couple of things in dfa74ce94bb59634acdaebaa9d8a980aab8d988e. @luisza please take a look to see if it's ok with you.


Update notification-hubs-tags-segment-push-message.md

Typo fix in the example at the end: "Red Socks" --> "Red Sox"

@elitree : Thanks for your contribution to the Azure documentation! The author, @ysxu, has been notified to review your proposed change.

#sign-off

@Erikre: Only the author, @ysxu, can sign off on this pull request.

@: Only the author, @ysxu, can sign off on this pull request.

@: Only the author, @ysxu, can sign off on this pull request.


Manage Command Completed

Current UI:

Current UI:

A suggestion: For 'Selected Event To Manage: 1', could we include the event name as well? For example - 'Selected Event To Manage: Blood Donation Drive 2018 [1]'. Just the index seemed a little misleading at first.

Coverage decreased (-1.2%) to 85.768% when pulling 057169fd43034febc609090d9c6899b91645575e on iMarbles:dev into bc34ab1d4042f1da8324b101ee3155d715712586 on CS2103-AY1819S1-W16-2:master.


Move defer outside of if statement

Previously this defer would fire at the end of the if statement when it
likely should have been firing at the end of the dispatch_async.

Thanks for this. We had merged this as you may have noticed https://github.com/uber/swift-concurrency/pull/25


Rename Gradle Enterprise to Develocity

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other guidelines?
[x] Does your project/product name match the text on the logo?
[x] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?

@caniszczyk please hold off on merging the PR. We would also like to update the description.

@caniszczyk – updated. Everything is good to go. Thanks! 🚀


Edit the guide and search for any of those taxa. None appear, thus they can't be removed from the guide.

I just played around with this for a bit as I was curious.
It looks like viewing by tag doesn't also filter by the current guide - so taxa from other guides come up if they also have the same tag.
Clicking into these incorrect taxa shows they are from other guides.
Interestingly the badge number against each tag seems to be correctly filtered for the current guide.
For example, this California Wildflowers guide has a bird in the color:violet tag because the Ivvavik National Park has a bird tagged that way.


pyenv 20151105 can't load "~/.pyenv", PATH be set  by "/usr/local/opt/pyenv/shims"

After updating new version of pyenv, command "which python" is "/usr/bin/python". And PATH be set by "/usr/local/opt/pyenv/shims", ever I add "eval "$(pyenv init -)" " to zsh setting file. Actually I don't change anything, but pyenv can't work after updating.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28138472-pyenv-20151105-can-t-load-pyenv-path-be-set-by-usr-local-opt-pyenv-shims?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github).

On the old version, the path is "~/.pyenv/shim" and work well, can't work after update. It change the path to brew path, and  eval "$(pyenv init -) add another brew path at the head of the path list. It's the bug or change the setting way in new version?

Nothing changed at least in recent releases, and no one encountered similar issues. It would indicate that broken part is just your sustem. Try uninstall and reinstall pyenv with using brew.

I reinstall the pyenv with brew, and relaunch the shell after install. Delete eval "$(pyenv init -)in .zshrc.
And my path is "/usr/local/opt/pyenv/shims /usr/local/opt/pyenv/bin", not "~/.pyenv/shim/" as before, I haven't do anything.

Somewhere PYENV_ROOT gets set to /usr/local/opt/pyenv.

The PYENV_ROOT exactly is /usr/local/opt/pyenv. I don't know why, I never change that.
When I add export PYENV_ROOT="$HOME/.pyenv"  to .zshrc. The PATH become "/Users/Myname/.pyenv/shims /usr/local/opt/pyenv/shims /usr/local/opt/pyenv/bin"
When eval "$(pyenv init -)" in .zshrc. The PATH including three pyenv paths, one PYENV_ROOT and "/usr/local/opt/pyenv/shims /usr/local/opt/pyenv/bin"
When eval "$(pyenv init -)" not in .zshrc. The PATH including only two pyenv paths, "/usr/local/opt/pyenv/shims /usr/local/opt/pyenv/bin"

And  no matter what I do for pyenv or shell config, which python always show "/usr/bin/python". I remember it might be "~/.pyenv/shim" before.

It might be something done by brew?
You might want to try the manual installation method, which is quite trivial after all.

I will try it and send email to brew too, thank you

All are expected behavior and no bugs in it. I'll close this anyways.

I found where the problem is, [oh-my-zsh pyenv plugin]https://github.com/robbyrussell/oh-my-zsh/blob/master/plugins/pyenv/pyenv.plugin.zsh do something for the pyenvdirs. I turn off this plugin then the pyenv work well.
Thanks guys