feat: whitelist and unwhitelist SPL tokens

closes #42
Add whitelisting function to SPL tokens to be deposited into the program PDA.
Right now the authority are authorized to whitelist/de-whitelist SPL token.
The integration tests are also refactored somewhat to increase code reuse.
Only deposit_spl_token*() instructions need to provide evidence of whitelisting.
withdraw_spl_token is not encumbered by whitelisting for the following reasons:

when the SPL token has never been whitelisted, there is no way to deposit into the program therefore
no way to withdraw; there is no need for witheraw_spl_token to respect whitelisting;
when the SPL token was whitelisted and later de-whitelisted, the desired behavior would be to
pause deposit, and allow withdraw otherwise the deposited SPL tokens will be stuck.

Whitelisting is implemented as a special PDA for each mint account (SPL token id).
#[derive(Accounts)]
pub struct AddToWhitelist<'info> {
    #[account(
        init,
        space=8,
        payer=authority,
        seeds=[
            b"whitelist",
            whitelist_candidate.key().as_ref()
        ],
        bump
    )]
    pub whitelist_entry: Account<'info, WhitelistEntry>,
    pub whitelist_candidate: Account<'info, Mint>,

    #[account(mut, seeds = [b"meta"], bump, has_one = authority)]
    pub pda: Account<'info, Pda>,
    #[account(mut)]
    pub authority: Signer<'info>,

    pub system_program: Program<'info, System>,
}

Whitelisting creates a PDA derived from the mint_account of the whitelisted SPL token.
When a user deposits the whitelisted token, she must provide evidence, i.e. provide the PDA whitelist entry
in the accounts:
#[derive(Accounts)]
pub struct DepositSplToken<'info> {
    #[account(mut)]
    pub signer: Signer<'info>,

    #[account(seeds = [b"meta"], bump)]
    pub pda: Account<'info, Pda>,

    #[account(seeds=[b"whitelist", mint_account.key().as_ref()], bump)]
    pub whitelist_entry: Account<'info, WhitelistEntry>, // attach whitelist entry to show the mint_account is whitelisted

    pub mint_account: Account<'info, Mint>,

    pub token_program: Program<'info, Token>,

    #[account(mut)]
    pub from: Account<'info, TokenAccount>, // this must be owned by signer; normally the ATA of signer
    #[account(mut)]
    pub to: Account<'info, TokenAccount>, // this must be ATA of PDA
}

This way, the existence of the PDA whitelist_entry is the evidence of the mint_account being whitelisted.
De-whitelisting closes the PDA whitelist_entry so that deposit spl token will error with AccountNotInitialized.
query whitelisted status
To query whether a SPL token is whitelisted by the program off-chain, derive the whitelist_entry PDA account
from seeds [b"whitelist", mint_account.key().as_ref()] and access the PDA account. The existence of this
PDA account means whitelisted; otherwise not whitelisted.
To query whether a SPL token is whitelisted by the program on-chain, add  evidence whitelist_entry
 #[account(seeds=[b"whitelist", mint_account.key().as_ref()], bump)]
    pub whitelist_entry: Account<'info, WhitelistEntry>, // attach whitelist entry to show the mint_account is whitelisted

    pub mint_account: Account<'info, Mint>,

to the accounts of the instruction. Anchor constraints ensures that whitelist_entry must exists (and initialized)
which means the referenced mint_account must be whitelisted.
testing
both positive and negative tests are in the integration test suite.
$ anchor test

Codecov Report
Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 9.30%. Comparing base (b0d3184) to head (b7a4d63).

Files with missing lines
Patch %
Lines

programs/protocol-contracts-solana/src/lib.rs
60.00%
2 Missing :warning:

Additional details and impacted files
@@                    Coverage Diff                    @@
##           enhance-pda-validation     #41      +/-   ##
=========================================================
+ Coverage                    8.30%   9.30%   +1.00%
=========================================================
  Files                           1       1
  Lines                         253     258       +5
=========================================================
+ Hits                           21      24       +3
- Misses                        232     234       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

removed the console logs in the next PR. Don't want to create merging issue later so maybe let's put the console logs aside for this one.


Can this train on 360-view dataset?

Really, cool works!
I have a question about this project.
Can this train on 360-view dataset?

Currently, we only support the LLFF dataset. However, the dataloader can be modified for the 360-view dataset as in Blender and Mip-NeRF.


Duration

I would like to be able to do 10.seconds.toNanos to emulate what I can do with the Scala/Java Duration class.
However, because DurationSyntax produces a Duration and not a Finite, there is method toNanos available unless I pattern match on 10.seconds.
I can see why Infinite does not have toNanos but it does make the syntax a bit hard to use in this case...
Edit: toScalaDuration and toJavaDuration would also be very useful!
Edit2: Why not allow negative durations?

Idea: Create a macro for seconds, minutes etc.
That should be able to return Finite for positive Int and Duration for negative Int, no?
Naturally, this only works at compile time, which is generally what these methods are used for anyways.


feat: import segment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
Support user imported segment by adding a new page and import api. User can import segment user to database manually later. For simplicity, import segment only supports CREATE and DELETE operations.
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[x] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @jingnanl on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/2/2024, 04:55:29 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @zxkane on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.60
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/2/2024, 05:25:17 (UTC+0)

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @jingnanl on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.70
< 80

Duplicated lines density
:white_check_mark: OK
8.50
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
9
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 7/2/2024, 10:30:34 (UTC+0)


Reload a specific module

Hi! I'm interested in a use case where I only want to reload a particular library that I am developing, but I could change any function or file within that library. Would one of the following snippets achieve this, inside of IPython for example?
import jurigged
jurigged.watch(mymodule.__file__)

import pathlib
import jurigged
mydir = str(pathlib.Path(mymodule.__file__).parent)
jurigged.watch(mydir)

And if so would it make sense to add jurigged.watch(mymodule) as syntactic sugar?

That should work, yes. I haven't paid much heed to the jurigged.watch interface since I rarely use it, but I like your suggestion, it is good sugar.


What happened to Android binary?

Can't find it on Google Play anymore nor anywhere. Why?

Thank you for bringing this problem to our attention. We've resolved the issue and the game should be available again on Google Play.

Great job! Thank you and thanks for the great game!!!


v1.7 alpha release No error being displayed

Hi,
using v1.7 alpha release when I upload picture bigger then  the lfm config file :  'max_image_size' => 500,
Server response is OK like there is no problem and there is no error displayed for the user.
Of corse the picture was not uploaded because it's bigger than 500kb

Is there any error in console? If there is a 413 error, check your nginx setting.

Im using Apache not Nginx .
The response was "OK"  but the file was not uploaded.
The file was 3mb size and File limit size 1mb

This is because when hitting the error, it return trans() where it's a message with HTTP 200 OK.
I think this is a bug, we must mapping these errors to proper HTTP response codes.

This is not a bug, I think it is about web server configuration.
When uploading larger files like photos taken by smartphones, Apache responses 200 OK and Nginx responses 413 request too large, before reaching PHP.

I meant in the php codes, we should not return 200 ok when error happens. This is nothing to do with nginx nor apache.

This only happens on mobile browser? @g0110280

Considering multiple files, uploading process should not be interrupted by validation. Files that passed the validation should be uploaded, and inform user that some files are not uploaded. Thus the filemanager will 200 OK with error message.

The situation I mention above is tested on Windows machine with Apache. Tested on PC browser and didn't test on mobile browser.

@g0110280 got your point, thanks :)
@TnCoders would you provide some relative apache and php configs.
Ex,
post_max_size and upload_max_filesize
Also, what is the http status code while you get the "OK" response?

I am not sure if this is also server related but I see a similar issue but using Laravel Homestead on Vagrant on a Win10 machine using Firefox or Chrome. In my case I can see that an error is generated but it does not output onto the screen.
E.G.

I tried uploading the same file twice. The second time it failed to upload (as expected) but no error displayed

in UploadController line 96ff  I changed
if (File::exists(parent::getCurrentPath($new_filename))) {
return $this->error('file-exist');
}

TO
    if (File::exists(parent::getCurrentPath($new_filename))) {
        echo $this->error('file-exist');
    }

and now the error outputs on the screen in a popup, followed by the word OK.

Error messages should be displayed. Thank you @stormhillmedia .

Please follow the upgrade document and upgrade to v1.7.1.


It is March 4, build 1902 soon?

According to this page 1902 will be out by end of February but according to https://docs.microsoft.com/en-us/officeupdates/update-history-office365-proplus-by-date it still isn't out? Any timeline updates?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7936ca5e-c658-4956-b174-99eaf1eb67d4
Version Independent ID: 9ecc0b61-a941-f5e1-96c3-d32fae59eacd
Content: Deploy Microsoft Teams with Office 365 ProPlus
Content Source: DeployOffice/teams-install.md
Service: o365-proplus-itpro
GitHub Login: @DHB-MSFT
Microsoft Alias: danbrown

@hoyty76 -- Version 1902 was released to Monthly Channel this afternoon. The table in the article has been updated accordingly.


how to use?

please give me more information on how to use this tool .
what language is that? javascript?
I have a website clash royale and would like to use

It´s currently under development, as soon as I finish with it I will upload docs explaining how to use it correctly.
It´s written in nodejs, and it´s a REST API so you can get all the information relative to Clash Royale.
I will close this issue, please check in the next couple of days for news and explanation on how to use.
Thanks!


How to obtain bbox file?

Hi, could you tell me how to generate bounding box file?
Or, could you provide the bounding box files you used?

Hi @qiuzhongwei-USTB,
for Human3.6M, follow the instructions in here for ground truth boxes, or see this Mask R-CNN boxes;
for CMU Panoptic, the bounding boxes are not yet ready, as is the whole pipeline, sorry for that.

Thanks，
could you tell me what's the difference of using undistort images and origin image?

Please read about camera models, for example, here. With original images, the ground truth 3D points will project to slightly inaccurate locations in images (still may be OK, but the quality will be lower). Undistortion corrects this.

Thanks for your reply! I met some problems again.

I found that it's very slow when I evaluate your pre-trained model(about 70 s/img, one V100 GPU).
Could provide your train times and test times on Human3.6 dataset?

There is an error  that when I set 'retain_every_n_frames_in_test=5 or 64'.

error information：
Experiment name: eval_human36m_ransac_RANSACTriangulationNet@08.11.2019-13:24:58
5it [06:07, 73.45s/it]
/root/v-helzhe/zw/h36m/data/learnable-triangulation-pytorch/mvn/datasets/human36m.py:222: RuntimeWarning: invalid value encountered in true_divide
action_scores[k] = v['total_loss'] / v['frame_count']
/root/v-helzhe/zw/h36m/data/learnable-triangulation-pytorch/mvn/datasets/human36m.py:222: RuntimeWarning: invalid value encountered in double_scalars
action_scores[k] = v['total_loss'] / v['frame_count']

Not sure. Let us look into this this after the weekend.

@qiuzhongwei-USTB did you close the issue because you worked around those problems? If yes, how did you solve them?

@qiuzhongwei-USTB did you close the issue because you worked around those problems? If yes, how did you solve them?

Yes, v['frame_count'] could be zeros. I change the code like the follows:
for k, v in action_scores.items():
if v['frame_count'] > 0:
action_scores[k] = v['total_loss'] / v['frame_count']
else:
action_scores[k] = 0

How about the long evaluation time?

I didn't solve these. I can bear the evaluation time when I use 8 GPU with distributed testing.
Can you provide your evaluation time?

Hi @qiuzhongwei-USTB!
It's very strange that you get such big evaluation times. I've just checked our evaluation times on full Human3.6M validation dataset:

Algebraic: 1 hour 29 minutes
Volumetric: 2 hours 1 minute

We use single Nvidia Tesla P40 GPU for evaluation.
Could you provide full bash command, which you used for evaluation?


Make drawGrid/drawCells order the same everywhere

In implementing.md, drawGrid/drawCells is reversed compared to all other cases throughout the tutorial. This results in slightly different rendering when interacting—the lines will be slimmer when drawing the cells after the grid—if you forget to change this order in the render loop later on.

[x] 👯 This PR is not a duplicate
[ ] 📬 This PR addresses an open issue
[ ] ✅ This PR has passed CI

okay ! updated, now it first draws the grid, then the cells everywhere:
src/game-of-life/implementing.md:  drawGrid();
src/game-of-life/implementing.md-  drawCells();
--
src/game-of-life/interactivity.md:  drawGrid();
src/game-of-life/interactivity.md-  drawCells();
--
src/game-of-life/interactivity.md:  drawGrid();
src/game-of-life/interactivity.md-  drawCells();
--
src/game-of-life/time-profiling.md:    drawGrid();
src/game-of-life/time-profiling.md-    drawCells();


how to do test via model.ckpt

Hi,
I did everything on facenet. i did trained and i have models. but how i will test i dont know? So can you help me ?

You can refer to this wiki: Validate on LFW.  The code is in validate_on_lfw.py. You can take a look at it. You need to pay attention to these parameters in function parse_arguments and their descriptions.

@xf4fresh i want to do when i give a person image, it need to find who is. for example there is a poets.
python /tf_files/label_image.py /tf_files/flower_photos/daisy/21652746_cc379e0eea_m.jpg
it is saying this image is which flower.
I want to do this for face.

@busrakb
My current task is to verify whether the two images belong to the same person, not to identify who the image belongs to. So it is different from your identified task.
I do not know if you understand the concept of embedding. Of course, it would be better if you understand.The current code can be used to compare the embedding distance of the two images.
I think the way to achieve your goal depends on the loss function you are using. There are multiple loss functions in facenet.py. What do you need to know which one you are using?
For example, if you use the loss triplet function, you can achieve by comparing all the target classes. Each target class can be determined by an embedding of an image or multiple images. If the center loss function is applied, you can get the center of each class by the code
centers = tf.get_variable('centers', [nrof_classes, nrof_features], dtype=tf.float32,
    initializer=tf.constant_initializer(0), trainable=False)

and then compare the distance between the current image and all classes. The smallest is the classification of your forecast.

@xf4fresh i couldnt do prediction code. i tried every test code in test folder, i tried to change something but i couldnt :(

I think you did not understand the task of this project. This is a verification task, not a classification. If you want to use this project to do the classification, you need to modify a lot of code.
You can think of this model to learn a mapping that maps a face image to a discriminant feature vector. When given two face images, we can judge whether they belong to the same person.
If you want to do classification, that is, give you a face image, you judge who this is
So, can you think about how to use the current model?

Hi,
Now there is a script 'classifier.py' that trains a classifier using facenet featured and makes it possibly to run classification on new images. Please check the wiki for details.

@davidsandberg  Thank u. Can u share the models? (model-20170216-091149.pb)

Hi, I will not share the frozen model right now but you should be able to
freeze the model your self by running something like
python src/freeze_graph.py ~/models/20170216-091149/ ~/models/ model-20170216-091149.pb
2017-05-08 8:00 GMT+02:00 busrakb<EMAIL_ADDRESS>
@davidsandberg https://github.com/davidsandberg Thank u. Can u share
the models? (model-20170216-091149.pb)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/davidsandberg/facenet/issues/228#issuecomment-299779951,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOd2IraSM6ir4ORwj-LNNVeBKZWf6Hxwks5r3q96gaJpZM4MvSco
.

--
David Sandberg
Näckrosvägen 28
16937 Solna
+46 76 149 7472

ok. thank you so much :)

When I try to freeze the model, getting error:
Metagraph file: model-20170216-091149.meta
Checkpoint file: model-20170216-091149.ckpt-250000
WARNING:tensorflow:The saved meta_graph is possibly from an older release:
'model_variables' collection should be of type 'byte_list', but instead is of type 'node_list'.
Traceback (most recent call last):
File ".../src/freeze_graph.py", line 101, in
main(parse_arguments(sys.argv[1:]))
File ".../src/freeze_graph.py", line 57, in main
output_graph_def = freeze_graph_def(sess, input_graph_def, 'embeddings')
File ".../src/freeze_graph.py", line 68, in freeze_graph_def
for index in xrange(len(node.input)):
NameError: name 'xrange' is not defined

@shivamms , 'xrange' was renamed to 'range' in python 3.


Grab focus only works on input nodes.

Godot version:
3.0 beta 2 x64
OS/device including version:
windows 10 x64
Issue description:
only control nodes such as buttons, text fields , sliders, etc are able to grab focus. All other control nodes will return false if you do a check.
Steps to reproduce:
have multiple control nodes that do not take any input from the user try to gain focus will result in failure. Trying to use any other form of input except a mouse without knowing which control is in focus leads to disaster when say using a game-pad.
Minimal reproduction project:

Not a bug. If you want a node to be able to get focus, use the set_focus_mode() function.
Closing.

Added a warning, to avoid this from happening again.

Added a warning, to avoid this from happening again.

It comes now always after the editor start.


"After pinning to undefined..."

Quote:
After pinning to undefined your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.
https://github.com/OperationCode/front-end/issues/205#issuecomment-427231079
No idea how this happened 😅
Wanted to bring it to your attention.

For some reason, the enzyme version was missing instead of 3.7.0.


Update yamllint rules

Set empty-values rules level to warning
The reason for this patch is the openshift/release pr: https://github.com/openshift/release/pull/5674
Signed-off-by: Nikhil Thomas<EMAIL_ADDRESS>

/retest

/lgtm
/approve
/meow
Thanks 🙇🏽♂😻


Add ability to request a custom address

Following discussion in #6.

Couple of css color things that I’m sure you’re aware of.

What are you thinking here? I intentionally kept things simple for this first pass.

[...] have you considered showing a pretty HTML error if the user asks to register an address that already exists?

Should I address that in this PR, or should there be a broader effort to make errors throughout the app prettier?

Couple of css color things that I’m sure you’re aware of.

What are you thinking here? I intentionally kept things simple for this first pass.

Yeah sorry this was just to acknowledge that you weren't yet finished.

Should I address that in this PR, or should there be a broader effort to make errors throughout the app prettier?

This is a good point and something that is on the todo list. I also haven't researched any error displaying solutions. I think just a simple text error will be absolutely fine for the moment.

@cdubz hey. Are you still interested in fixing those small things up? If not I'll merge this pr in as is and fix them.

Let’s get this merged in. Sorry, short on time for a bit here.

Let’s get this merged in. Sorry, short on time for a bit here.

No problem. Thanks for your help.


Set edge thickness of outline effect

Is your feature request related to a problem?
I'm trying to set the thickness of outlines and can't find a related property. Is there a way to set the thickness?
Describe the solution you'd like
The OutlinePass from three.js, for example, has an edgeThickness property.
Describe alternatives you've considered
I could go back to using the threejs/examples effect, but I'm trying to convert my effects over to this.

Edge thickness is just an alias for the blur kernel radius in three's implementation. You can control the outline edge thickness in postprocessing via the  OutlineEffect constructor parameters kernelSize and edgeStrength, for example:
const effect  = new OutlineEffect(scene, camera, {
	blendFunction: BlendFunction.SCREEN,
	kernelSize: KernelSize.SMALL, // Edge thickness
	edgeStrength: 10.0,
	pulseSpeed: 0.0,
	visibleEdgeColor: 0xffffff,
	hiddenEdgeColor: 0x22090a,
	height: 480,	// Also influences edge thickness
	blur: true,	// Enable blurring
	xRay: true
});

It's also possible to change the kernel size and edge strength later:
effect.blur = true;
effect.blurPass.kernelSize = KernelSize.LARGE
effect.uniforms.get("edgeStrength").value = 123.4;

Aha, the piece I was missing was that blur must be set to true. If it's set to false the strength and kernel size have no effect: it remains a tiny thin line.


Camperbot fails to give points if there is a bracket before a "thanks"

https://gitter.im/FreeCodeCamp/FreeCodeCamp?at=57edcc09d56b91170dfc75cd

Looks like now we're expecting a whitespace character on either side of the thanks but we really just need a non-word character.

adding |\W to first capturing group in this line will fix it I think

word breaks created a lot of problems. Please don't use \W or \b

@abhisekp just curiosity , how would using non-word metacharacter create problems?

@Dave1089 You may check the history https://github.com/FreeCodeCamp/camperbot/commits/6013edabcb34159501270cce4fec5b2f64f76133/data/rooms/RoomMessages.js
Previously, the regex was using \b which had many false positives leading to falsely giving out points to known and unknown campers (unintended). https://github.com/FreeCodeCamp/camperbot/commit/94e2558e94720dcb28417db33aa3ecc6f7bde2c9#diff-df3e5eba3a8c0d8a1bc5b0899e09041a
I fear the regex in the PR https://github.com/Dave1089/camperbot/pull/1/files#diff-df3e5eba3a8c0d8a1bc5b0899e09041aR48 might create the same issues.

@abhisekp I would like to get input from you how we should approach this issue of not validating non-word characters then

@Dave1089 I suggest to not complicate the regex more than it already is.
Using anything other than whitespace is not so common case. There might be more false positives if any character other than a whitespace is used.

Okey

Closing as stale and possible wontfix


The blob is not deleted when retrying 'Deleted blobs with snapshots' with one of the source items is selected on 'Retry AzCopy' dialog

Storage Explorer Version: 1.20.1
Build Number: 20210715.14
Branch: hotfix\1.20.1
Platform/OS: Windows 10/ Linux Ubuntu 20.04/ MacOS Big Sur 11.4
Architecture: ia32/x64
How Found: From running test cases
Regression From: Previous release (1.18.1)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload two blobs.
Create snapshot for the two blobs -> Try to delete the two blobs.
There is a warning activity log -> Click 'Retry...' next to the activity log.
Only check one item under the 'Source' column on the 'Retry Azcopy' dialog.
Select 'Delete blobs with snapshots' -> Click 'Retry Selected'.
Check whether the selected blob is deleted.

Expected Experience
The selected blob is deleted.
Actual Experience
The selected blob is not deleted.

Fix merged into hotfix branch for release.


read ISD files

Add functions to read files from the Integrated Surface Database (ISD) .
One possible approach is to port pvl_getISDdata.m and pvl_readISH.m from PVLib Matlab.
A parser is in rOpenSci at CRAN.
A older python reader could be used, but it is questionable if the code is being maintained. It uses many classes and may not fit well with pvlib's style.

Porting from PVLib Matlab would probably be fastest. It looks like NOAA now discourages the ftp access route and recommends the http archive with proper csv files, so the port might end up being fairly independent.
What do you think about putting the code in siphon instead? The ISD is more general purpose than most of the datasets accessible in pvlib.iotools.
I agree with your assessment of the older ish_parser.

What do you think about putting the code in siphon instead? The ISD is more general purpose than most of the datasets accessible in pvlib.iotools.

Certainly. Or metpy
I'd rather import the code from a maintained library than maintain it ourselves.

I would also like to see a reader for NOAA NCDC GSOD, especially for rainfall (see ftp see #668

I had raised a feature request in Siphon and metpy long ago, for which I got a response.  The author feels that ISD reader function suits Siphon more than metpy.
But I'm not sure by when they will implement the function.

Seems like the responses are "PR welcome" and put get_ functions into metpy and read_ functions into siphon.
Having looked into it, I'm -1 on eeweather. Although that package has nice functions, it primarily serves a particular workflow, so maintaining a general interest function to read ISD is not likely a priority.
@wholmgren do you see a downside for pvlib users if the ISD functions live in siphon/metpy rather than native in pvlib?

No, I don't see a downside. You'd have to install another package or two, but their base requirements are not difficult to manage. @nappaillav I'm sure that the siphon/metpy maintainers would welcome a pull request.

@wholmgren and @cwhanse Can this issue be closed (based on the above discussion it seems so)?

@AdamRJensen I think so. We can always re-open.


feat: makes inference server details link clickable

What does this PR do?
When the service is running, makes the url link clickable. It will open the default browser
Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

[x] unit tests has been provided

manually
Go to inference service details, click on the link

I'm worry this change is making the use of the inference server with other tool (application code, other LLMs tools) harder.
As a developer, I'd like to be able to very quickly copy the base URL of the inference server so I can paste it in my code. If I need documentation on the API end points, then, I'd like to have a direct access to the API documentation.
As a result, I'd be in favor of having a different button to access the documentation and let the user still be able to "copy" the URL of the inference server.

Thanks to https://github.com/containers/podman-desktop-extension-ai-lab/pull/1443 inference server have a labels property, which is used to have an optional api or docs label.


chore: Update GH Actions for release

Codecov Report
Base: 73.00% // Head: 73.00% // No change to project coverage :thumbsup:

Coverage data is based on head (86cc9bf) compared to base (43d44ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   73.00%   73.00%
=======================================
  Files           7        7
  Lines         515      515
=======================================
  Hits          376      376
  Misses        109      109
  Partials       30       30

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Inline Copilot Chat with code selection incorrectly aborts when hitting "```"

VS Code Version: Version: 1.79.0-insider
OS Version: macOS 13.4 Beta (22F5027f)
Logs:

Reproduction:

Select code block with "```" in a string.
Converse with Copilot.

Presumably, Copilot will interpret the input text as markdown and incorrectly interpret the sequence as end-of-code-block.

Seems to be working by now (this issue is kinda old)
Steps

have the code below
ask it to rename source to code

export function asCodeBlock(source:string):string {
    return '```' + source + '```';
}

https://github.com/microsoft/vscode-copilot-release/assets/1794099/2952ee6f-b42d-4fac-b379-cc2a7b72e6f2


Horizontal line not showing in subchart [BUG]

Expected Behavior
I have added a horizontal line in subchart with macd lines.
Current Behaviour
But the horizontal line doesn't showed up.
macd lines are showing only.
Reproducible Example
chart = Chart(width=1400, height=800, title="BANKNIFTY", inner_height=0.7)
chart2 = chart.create_subchart(height=0.3, width=1, sync=True)

chart.set(df1)

sma_data = calculate_sma(df1, 20)
line = chart.create_line(name="sma")
line.set(sma_data)

chart2.horizontal_line(43200, color="white")

macd_data = calculate_macd(df1)
macd_line = chart2.create_line(name="macd", color="purple")
signal_line = chart2.create_line(name="signal", color="yellow")
macd_hist = chart2.create_histogram(name="histogram")
macd_line.set(macd_data)
signal_line.set(macd_data)
macd_hist.set(macd_data)

chart.show(block=True)

Environment
- OS: ubuntu 22.04
- Library: lightweight-charts  1.0.20

@louisnw01 and also histogram is not aligned with y-axis it is floating
watch this video

Hey @alloc7260 ,
You are setting the horizontal line value on chart2 to a value of 43,200, whereas the MACD value only goes up to around 40-50.
Louis

@louisnw01  it not showing the line, tried this also.
chart2.horizontal_line(0, color="white")

Hey @alloc7260 ,
You are setting the horizontal line value on chart2 to a value of 43,200, whereas the MACD value only goes up to around 40-50.
Louis

43200 is just example, not working any of value

Ah I see the issue now; you want to use the horizontal_line method on the macd line object.
Let me know if you still have any issues!
Louis

@louisnw01 yes louis,
it is not showing the horizontal line on subcharts, i tried a lot.
please help me.

@louisnw01 yes louis,
it is not showing the horizontal line on subcharts, i tried a lot.
please help me.

Can you show me the current code you are using? Should be something like macd.horizontal_line(...)

@louisnw01 yeah, sure
chart = Chart(width=1400, height=800, title="BANKNIFTY", inner_height=0.7)
chart2 = chart.create_subchart(height=0.3, width=1, sync=True)

chart.legend(True)
chart2.legend(True)

sma_data = calculate_sma(df1, 20)
line = chart.create_line(name="sma")
line.set(sma_data)

chart.set(df1)

macd_data = calculate_macd(df1)
# macd_ndj = ta.macd(df1.close, 12, 26, 9)
macd_line = chart2.create_line(name="macd", color="purple")
signal_line = chart2.create_line(name="signal", color="yellow")
macd_hist = chart2.create_histogram(name="histogram")
macd_line.set(macd_data)
signal_line.set(macd_data)
macd_hist.set(macd_data)

chart2.horizontal_line(0, color="white")

chart.show(block=True)

def calculate_macd(
    data: pd.DataFrame,
    short_period: int = 12,
    long_period: int = 26,
    signal_period: int = 9,
    source: str = "close",  # open / high / low / close
):
    short_ema = data[source].ewm(span=short_period, min_periods=1).mean()
    long_ema = data[source].ewm(span=long_period, min_periods=1).mean()
    macd_line = short_ema - long_ema
    signal_line = macd_line.ewm(span=signal_period, min_periods=1).mean()
    macd_histogram = macd_line - signal_line
    macd_data = pd.DataFrame(
        {
            "time": data["time"],
            "macd": macd_line,
            "signal": signal_line,
            "histogram": macd_histogram,
        }
    )

    return macd_data

You're still putting the horizontal line on the chart object, not the macd object.

@louisnw01 can you give me the corrected code.


feat(core): adding extra information and logging surrounding exceptions

Closes #42

This review just expands on the exception functionality. Now when an invalid response is returned, it return more data associated with the failure.


DNN Platform Documentation Fixes

Summary
This PR is a clean up of various bits of documentation included in the repositories.

The listing of approvers
Usage of the "on-hold" tag and Draft PR's
Updated versioning policy

@mitchelsellers I'm curious if the rules around merging pull requests with only one approval was bypassed for any specific reason. I've seen quite a few pull requests approved with only a single approval, or even merged by the author, which isn't allowed but it seems to be ignored as of late.

@ohine for the protected branches (develop & master) the only PR's that should be getting merged without 2 approvals are those in support of release management activities, typically done by myself of @valadas.  This does include the creation of release branches, merges to master to trigger releases & RC's and related items.  For this particular PR, I'm not 100% sure what happened but I will follow-up with @donker. As a documentation update, I'm not as concerned, but we should be following processes.
We are using Mergeable to enforce most of those rules, so items getting by without 2 approvals should be a very limited situation.  We do have a few "special branches" out there that are not following these rules, such as the one for the updated file manager.
I am contemplating further updates to remove the "Not Merged by Submitter" rule as there is a bit of practicality that makes that process a bit harder to manage considering the number of approvers, required approvers, and who helps to manage/flow the releases.
If we have issues here that I've missed (which we have a LOT of activity) I'll gladly review PR's of concern.
As with the initial rules we are not

The irony does not escape me on this 😆  - great catch @ohine!!!

My suggestion above was discussed by voice and I vocally approved, I forgot to come by here and approve it. As for this being a many pull request, many of them are for the new file manager and we agreed in meetings this would be merged quick with a single approval so we can move forward and since this is a feature branch, we are just a few collaborating on, it is acceptable since it will come in as another PR to merge into our actual develop branch.
I don't see that this is a concern and a habit on master and develop the only ones I am aware where merged with a single approval are PRs related to release management as I believe was your idea @ohine

My suggestion above was discussed by voice and I vocally approved, I forgot to come by here and approve it.

I figured it was something along those lines, but without the transparency and just seeing items merged without full approval is a huge issues for security and the integrity of the project, and when the owner themselves merge (which isn't the case with this PR), that's an even bigger red flag. I've looked a few times for meeting notes, and I believe they're not public anymore? or if they are they're in a very obscure place.

I don't see that this is a concern and a habit on master and develop the only ones I am aware where merged with a single approval are PRs related to release management as I believe was your idea @ohine

Correct, release management tasks are a totally different story. I sat around for days waiting and pinging people begging for approvals back when I was part of the team and that caused releases and RCs to be delayed. Each time however, I've seen the disclosure as to why the policy was being bypassed. That transparency piece is huge.

I am contemplating further updates to remove the "Not Merged by Submitter" rule as there is a bit of practicality that makes that process a bit harder to manage considering the number of approvers, required approvers, and who helps to manage/flow the releases.

I really don't recommend that one bit, as stated above, allowing the PR owner to merge their own pull requests and when they also have the security rights to bypass the approval chain is very very dangerous. This shouldn't be removed under any circumstance and should be enforced on the first violation.

I really don't recommend that one bit, as stated above, allowing the PR owner to merge their own pull requests and when they also have the security rights to bypass the approval chain is very very dangerous. This shouldn't be removed under any circumstance and should be enforced on the first violation.

While I can truly understand the Ivory Tower approach to this, and we do strive to follow the process as much as we can.  As you have noted, we have a limited number of approvers and wrangling those approvers together in coordination can be very hard.  With current live/COVID situations this is exacerbated.
I do believe that 2 approvals is an absolute, after 2 unique approvals, merging by the initial submitter with those approvals although not great isn't catastrophic.  Merging your own, without 2 unique approvals, that would be a different story.

I do believe that 2 approvals is an absolute, after 2 unique approvals, merging by the initial submitter with those approvals although not great isn't catastrophic. Merging your own, without 2 unique approvals, that would be a different story.

When approvers have the security rights to bypass the required approval chain and the system also allows them to self merge their own changes, it's a huge security risk. That's why requiring multiple approvals and requiring a 3rd party to merge was put into place. This helps prevent anything malicious from getting snuck into the platform. This allows the reviewers time to actually review changes. Violations to these policy's shouldn't just be ignored, as it puts the entire ecosystem at state.

@ohine to reiterate, this PR

Is a small documentation change.
Does not affect the product code.
Is mainly related to release management.
Was approved by me by voice, I just forgot to come back here and click the button.

I do agree here with @mitchelsellers that although not ideal as long as we have 2 approvers, merging by the initial submitter (which by the way is not any random person but is also a reviewer) is not something we do recommend but at the same time, who clicks the button does not mean much, it does not change the number of approvers. We only have 6 approvers that where chosen very carefully, that are all very busy and spend a lot of their very limited free time maintaining this project for free. At the same time, most of the contributions also come from these 6 approvers, which only leaves 5 other busy individuals to actually review.

This helps prevent anything malicious from getting snuck into the platform

Correct. If your concern is security and you do believe you saw any other PR that got merged without 2 approvals that does not fall in these situation:

Is on a feature branch (not develop or master).
Is related to release management.
Does not affects the product.

Please point that out for double-check. If you cannot find any, then this discussion is moot, we are all in agreement here about our policy and we all care a lot about the platform security.

We only have 6 approvers that where chosen very carefully, that are all very busy and spend a lot of their very limited free time maintaining this project for free.

Correct, I was one of those original approvers. I helped craft these rules with @mitchelsellers and the original group of code reviewers back from the corp days. I was one of the top contributors for multiple years, and I've jumped through all those hoops, multiple times. I also stood up for both you and @david-poindexter to get into the group after quite a few internal discussions as we were struggling with the workload and we desperately need additional help. As always, I'm willing to jump in and help out, but it appears that my help is just completely unwanted from the team.
However, when it comes to the platform code, and the policies around who should be merging changes, and when those policies can be skipped, is of upmost importance. While most documentation changes are trivial, and do not require a strict policy, as they're documentation, this PR addresses the code review policy and the list of approvers, which should require a bit more than a single review. All I'm asking for is transparency. It takes 2 seconds to type why you're checking the admin privileges' required checkbox to bypass the required 2 approval merge policy. Providing transparency is important, as is being accountable when issues arise.

Please point that out for double-check. If you cannot find any, then this discussion is moot, we are all in agreement here about our policy and we all care a lot about the platform security.

I've sent @mitchelsellers quite a few of these troubling pull requests over the years, each time I was told it will be handled and it wouldn't happen again. Yet it does. Continually. This was before the feature branches were even allowed too. I wasn't aware that the policy didn't apply to feature branches, as the policy wasn't current.
I'm raising the concern here, because Mitch said he was thinking about relaxing that policy even further, which is why I continued the discussion on this thread.
If you need me to dig back through the history and provide links again this issue to the pull requests which bypassed this policy since it was instated, I can, it'll just take some time. It's not an easy thing to query. That's why I'd always send them directly to Mitch as I was reviewing pull requests, which stopped about a year ago when my access was revoked.

I've sent @mitchelsellers quite a few of these troubling pull requests over the years, each time I was told it will be handled and it wouldn't happen again. Yet it does. Continually. This was before the feature branches were even allowed too. I wasn't aware that the policy didn't apply to feature branches, as the policy wasn't current.

Honestly, I'm not getting into yet another war, especially one in a public channel where there continue to be undertones of personal vendettas.  I will confirm that ONCE I was provided an example and it was discussed and reviewed.  You have continually accused this abuse of power, yet after asking for the examples they were never provided.
So yes, I'd love a listing of them.

Honestly, I'm not getting into yet another war, especially one in a public channel where there continue to be undertones of personal vendettas.

Just to be perfectly clear, in public, and on the record. I never once started any war. I don't think of this as a war. I never had. I don't have personal vendettas. It's pretty sad that I'm still getting attacked when the only thing I care about is the security of the platform and it's source code. That's it.
I know for a fact I've sent you MULTIPLE, as you requested that I resend them before I was removed from the approvers groups. I will dig that thread back up and post it here, and I'll review the pull requests since I left to see what else might of occurred. I've only reviewed the major ones that have a direct effect on our clients sites, but I'd be happy to dig back in and provide the MULTIPLE examples yet again in a public channel if that's how you'd like to proceed.

This isn’t something that has to be big in public, but if you have examples send them. As I informed you I did not receive before.
Feel free to copy the other approvers on that email as I know you know how to reach us all.

This isn’t something that has to be big in public, but if you have examples send them. As I informed you I did not receive before.
Feel free to copy the other approvers on that email as I know you know how to reach us all.

Actually, It needs to be public, because my name is continually dragged into the mud. I know you did receive them because it was a direct chat on Skype. We had a full conversation about it, multiple times.

It needs to be public

Agreed, please do provide links to the PRs you mention for the team to double-check publicly.

because my name is continually dragged into the mud

If you do believe anyone has been dragging your name in the mud, please do report that content, we abide to the .NET Foundation Code of Conduct https://dotnetfoundation.org/about/code-of-conduct


Added checking hasPrice for child products

This PR will solve this issue when we run this indexing command: bin/magento indexer:reindex vsbridge_product_indexer
Vsbridge Product Indexer indexer process unknown error:
Notice: Undefined index: price in vendor/divante/magento2-vsbridge-indexer/src/module-vsbridge-indexer-catalog/Model/Indexer/DataProvider/Product/ConfigurableData.php on line 251

Thanks for your PR.
Fix with pull request: #166 - I am closing this one.
In general variants (configurable children products) should have a price..  in what cases child product doesn't have a price ?
Do you have multistore? What Magento do you use ? If you have a price in magento panel, but is not exported to ES please create an issue.


Visual Challenge - Trello Boards

Good time, Xamarin community.
I tried to make boards like in Trello.
Here is a screenshot from Trello app that was on Android and an source shot

And actually, my impressions of using Visual.Material:
- Tabbar Items doesn't stack into a dropdown element (and no matter what it primary or secondary);
- Label, in LineBreakMode = Word Wrap, add one unnecessary empty line to the end;
- I'm taking some time to change the colour of the action bar. Why colour that in the AppShell.xaml not inherited by default to VisualChallengePage.xaml. Also, ActionBar on iOS looks very pale (it is possible that I missed something from attention). I had to change the colour of the navigation bar I needed through AppDelegate.cs;
+ Finally cool floating entry`s
+ Amazing ink ripple effect on the buttons and in the addition to that ability to attach images with text and without it.
- Button text is the only uppercase. As well the distance between the letters is very large in my opinion;
What would you like to see in the next updates:
> CardView that contained in self - ink ripple effect. Either tie this effect under TapGestureRecognizer that was on view;
> Also will be cool to add ripple effect in the nested scroll view not only child of content view;
> Add please Checkboxes with Material style;
> It would also be great to add the ability to change the settings of the shadow.
And actually the result: Source shot of Android and Source shot of iOS

Thank you @Agerathum! Very nice result.

Tabbar Items doesn't stack into a dropdown element (and no matter what it primary or secondary);

You're referring to the upper right button to the right of the search button? Would you expect the dropdown element always, or only when you've chosen to use Material?

I'm taking some time to change the colour of the action bar.

Yes, this is something we need to address. There's a color blending happening b/c of how Apple does the navigation bar. This is an issue with Shell that I believe is already open. If not, I'll note it again. Thx.

Button text is the only uppercase. As well the distance between the letters is very large in my opinion;

When we enable some styling properties, this will be something you can control. The distance between letters may be more a function of the font, but we do have an open PR for letter spacing.

Add please Checkboxes with Material style;

Once we have a Checkbox,

It would also be great to add the ability to change the settings of the shadow

Agree, this is similar to the the Button text issue. It'll be possible once we can expose more properties.
Thanks again, great notes!

@davidortinau thank you for feedback

You're referring to the upper right button to the right of the search button? Would you expect the dropdown element always, or only when you've chosen to use Material?

Yes, that's right 3 small dots in the upper right corner of the navigation bar, but apparently, this refers to the Shell, the Material does not affect this. Everything works fine in Material.
And also, there are differences in the default font colour between the Android platform and iOS. Same a font size. But I think that this is not essential since the colour can be corrected by changing TextColor Property.


chore: update link to previous post

Just happened to catch this while reading — let me know if anything needs to be changed!

Thanks @benlaverriere!!!

Thanks @benlaverriere!!!


fixes drag and drop

closes issue #155

Thanks! I've merged it so we can all see it in our builds and in 0.4. Given that this is pre-production that seems like the best way to go.


Prevent pagespeed from removing line breaks in JS

I have a site which relies on a JS snippet which must be a certain format, meaning each value must be on a new line. Unfortunately this is a limitation required by a 3rd party.
example of good snippet:
<script type="text/javascript">
  client_email =<EMAIL_ADDRESS>  order_id = '245323';
</script>

However, with pagespeed enabled the output becomes this:
<script type="text/javascript">client_email='user@github.com';order_id='245323';</script>
This renders the snippet invalid by the 3rd party. Disabling pagespeed fixes the problem immediately. How can I prevent this from happening while keeping the rest of pagespeed working for me?

Ideally you could blacklist the particular script block, but we don't
currently have a way to do that.
The next best best thing is to disable rewriting any inline JavaScript:
ModPagespeedDisableFilters rewrite_javascript_inline
ModPagespeedEnableFilters rewrite_javascript_external
On Jul 26, 2017 7:48 AM, "Benji"<EMAIL_ADDRESS>wrote:

I have a site which relies on a JS snippet which must be a certain format,
meaning each value must be on a new line. Unfortunately this is a
limitation required by a 3rd party.
example of good snippet:

However, with pagespeed enabled the output becomes this:

This renders the snippet invalid by the 3rd party. Disabling pagespeed
fixes the problem immediately. How can I prevent this from happening while
keeping the rest of pagespeed working for me?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pagespeed/ngx_pagespeed/issues/1443, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AB2kPUdUx-DTsBzeCcU2MD3EG6K9JiNnks5sRyd5gaJpZM4OjzuZ
.

pagespeed DisableFilters rewrite_javascript_inline;
Fixed the issue. Thank you @jmarantz


Add RBI definition for Delegator#initialize

Motivation
The definition is missing.
Test plan
See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HOVoZ3zcDczaTq


upgrade to latest dependencies (#1153)

bumping knative.dev/eventing ff55a45...39eef14:

39eef14 upgrade to latest dependencies (# 6341)
073af74 Ensure the clean up will remove installed elements (# 6338)

Signed-off-by: Knative Automation<EMAIL_ADDRESS>

OCF Webhook is merging this PR


Add a link to the Docker Hub page at the front page

.. so that our Docker Hub page gets more attention.

Codecov Report

Merging #80 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   49.03%   49.19%   +0.16%
==========================================
  Files         212      212
  Lines        9851     9851
  Branches     1327     1327
==========================================
+ Hits         4830     4846      +16
+ Misses       4277     4259      -18
- Partials      744      746       +2

Impacted Files
Coverage Δ

...internal/storage/repository/git/GitRepository.java
75.45% <0%> (+0.6%)
:arrow_up:

...erver/internal/thrift/CentralDogmaServiceImpl.java
69.36% <0%> (+1.35%)
:arrow_up:

.../linecorp/centraldogma/client/AbstractWatcher.java
50.42% <0%> (+7.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76671b4...dbbf60c. Read the comment docs.


Monster button in conversation email notification

@alanna could you forward me the email?

This is happening on more notifications:

I forwarded the emails to ben.


rivalcfg not found

After following instructions and a seemingly successful install, running rivalcfg with any option gives me the output rivalcfg:command not found.  Any ideas what went wrong?

Just needed a restart.

I do not know why a restart was needed but if it works... :D

On second note, I have a SteelSeries Rival 310 PUBG Edition (ID = 1038:1736).  This mouse is not listed as compatible, but I took a chance because the only difference is the color compared to the regular Rival 310. I first tried normal commands for Rival 310, and then I tried to load the profile for RIval 310 and write to 1038:1736, but it did not work.
adam@Adam-PC:~$ RIVALCFG_PROFILE=1038:1720 RIVALCFG_DEVICE=1038:1736 rivalcfg -c black
[DEBUG] Rivalcfg 3.11.0
[DEBUG] Python version: 2.7.17
[DEBUG] OS: Linux
[DEBUG] Forced profile: 1038:1720
[DEBUG] Targeted device: 1038:1736
W: The following mouse was found but rivalcfg was not able to open it:

mouse: SteelSeries Rival 310 (Experimental) (1038:1720)
error: Unable to find the requested device: 1038:1720:00

Please check that no other application is controlling this mouse and try to:

unplug the mouse from the USB port,
wait few seconds,
and plug the mouse to the USB port again.

[DEBUG] Selected mouse: None
Usage: rivalcfg [options]
rivalcfg: error: no such option: -c
Any suggestions?

Please open this as a new issue, I will add the support for your mouse ;)

Released iin rivalcfg v3.12.0.
Thank you for the report, and welcome to Github ;)

Thank you for the great support.  I found the following with 3.12.0 :
adam@Adam-PC:~$ lsusb | grep Steel
Bus 001 Device 008: ID 1038:1736 SteelSeries ApS
adam@Adam-PC:~$ rivalcfg
W: The following mouse was found but rivalcfg was not able to open it:

mouse: SteelSeries Rival 310 PUBG Edition (Experimental) (1038:1736)
error: open failed

Please check that no other application is controlling this mouse and try to:

unplug the mouse from the USB port,
wait few seconds,
and plug the mouse to the USB port again.
...

Any suggestion?

The udev rules are probably not up to date.
Try to copy the content of this file to /etc/udev/rules.d/99-steelseries-rival.rules
and then tel udev that you updated the rules with the following command:
sudo udevadm trigger

It should work then :)

Thank you, it now works.


Add external documentation

For now it will be fair to say that the initial version if fully completed.


setup project

Create a repo
install additional tools
setup django project

first to-do
this is a demo only


Device power status is not correct

I have a few Sonoff S31 devices flashed to run Tasmota. They were running 11.0.0 and 11.1.0, but were updated to 12.0.2 to attempt to resolve this issue.
The devices are recognized by the plugin, but the status always shows as "Off." If I click the item in the Accessory list, the outlet turns on, however the state is not reflected in the Accessory list. If I click the item again the state does not change, i.e., the device does not power off.
From the status log + debugging I see these contradictory messages:

[07/08/2022, 16:50:59] [tasmotaControl] Device: <IP_ADDRESS> Prusa i3 MK3S+ MMU, get state: OFF
[07/08/2022, 16:51:04] [tasmotaControl] Device: <IP_ADDRESS> Prusa i3 MK3S+ MMU, debug response: {
"POWER1": "ON"
}
<<
Note that no events for the state change are logged, as indicate and expected. Perhaps the try block at 215 may not be being satisfied?
I have attached a log which I hope provides useful guidance: tasmota_s31_debug.txt
I'm not sure what additional details you require. but please let me know how I can assist in resolving this.
~ Tony

Thanks,
can you try 0.4.5-beta.0 and let me know

I installed the update but experienced no difference in behavior. I recreated the switches to make certain there wasn't something somehow amiss in the config file and also changed the plugin to run as a child bridge as recommended.
As above, clicking on the accessory in the list will turn the device on. The state is not reflected in the log (i.e. no "set state" log message as expected) nor is the UI updated with the correct state. As such, there is no ability to toggle the power off again.
Looking at it, I suspected the dependency to axios was not satisfied. My modules list did not list axios, so I attempted to install it but borked the install in the process ("added 8 packages, removed 1171 packages"). Doh! I haven't yet had a chance to reinstall homebridge,.
erhaps you could comment on whether I might have been on the right track? Should I not see axios in the modules list? (Sorry, I'm a bit out of my element here, but I am trying to learn.)
Thanks again!

Please get the full log

Please try also 0.4.6 beta

Apologies for the delay.
I was able to confirm that the latest beta 0.4.6 has resolved the issue. The accessory page now shows the proper state and controls the device as expected (on and off).
Thank you!


Display Multiple SoSs

[ ] -Display multiple SoSs on details page
[ ] - Update PDF print out to handle multiple SoSs

@emjohnst - This could make the details page quite long. Do you want the SoS section to be hidden by default?

@bferguso That's okay, please do not hide the SoS section. I think there will only be a couple cases where this applies.


First version of Dutch Lang

I've created a Dutch version, it's just not totally clear to me what's the purpose & specific requirements to the keys of the language arrays. I figured they're just references but they may have something to do with 'normalizing'(?) Not sure, hope they're OK like this.

@micschk are you ok if we finish your PR in order to get it merged?

@rvanlaak That'd be great, thanks!


Draft: Add #VC handler

This is a draft for the implementation of #14, which is implementing a #VC handler to handle NAE events.
NAE events have to be handled early, so we also set and load the IDT in stage 2.
At this point, interrupt handling in stage 2 doesn't work. I mostly moved and debug code to try to call the VC handler from a stage 2 cpuid, which fails. The IDT setup in this PR still handles interrupts in the SVSM kernel, but not in stage 2. My guess goes that IDT entries should be different because stage2 is a different binary (with different GDT entries?), but I'm still debugging. That's where my lack of system programming background hits.

My guess goes that IDT entries should be different because stage2 is a different binary (with different GDT entries?)

I'd say you at least need to set up a GDT with a CPL0 code segment.

I'd say you at least need to set up a GDT with a CPL0 code segment.

GDT is set and loaded in src/boot_stage2.rs
         * Load a GDT. Despite the naming, it contains valid
         * entries for both, "legacy" 32bit and long mode each.
         */
        movl $gdt64_desc, %eax
        lgdt (%eax)

So I guess no need to set and load it again, right? Just ensure that the IDT fields match the correct GDT entries

So I guess no need to set and load it again, right? Just ensure that the IDT fields match the correct GDT entries

The only GDT entry that is referenced from the IDT is the TSS, which contains the IST stacks for #DF handling, as far as I can tell. This is not set up until bsp_percpu.load() is called (which ends up calling load_tss()), followed by idt_init() (which calls init_ist_vectors()). So, by the time early_idt_init() is called, I don't think any entries should be different in the GDT. Have you tried calling load_gdt() in stage2?

The only GDT entry that is referenced from the IDT is the TSS, which contains the IST stacks for #DF handling, as far as I can tell. This is not set up until bsp_percpu.load() is called (which ends up calling load_tss()), followed by idt_init() (which calls init_ist_vectors()). So, by the time early_idt_init() is called, I don't think any entries should be different in the GDT.

That was my conclusion too, that's why I was struggling finding what could possibly go wrong.

Have you tried calling load_gdt() in stage2?

I didn't, but I just tried and it worked :) VC handler gets called by cpuid in stage 2 and in the SVSM kernel as well (depending where you put the instruction of course). Thanks Carlos! I still have to clearly figure out happens

In general this looks good to me. The question is how we organize the code sharing of the IDT handlers between stage2 and SVSM kernel. The SVSM needs more complicated handlers for some things (e.g. #PF) than stage2, and we want separate handlers for both.
We can divide that by introducing features, or just include different sub-modules for SVSM and stage2. Other suggestions are also welcome.

I didn't, but I just tried and it worked :) VC handler gets called by cpuid in stage 2 and in the SVSM kernel as well (depending where you put the instruction of course). Thanks Carlos! I still have to clearly figure out happens

Exception handling needs a GDT to be set up, because raising the exception will reference the GDT to load the handlers code segment, and the IRET also references the GDT to jump back to the original code segment.

In general this looks good to me. The question is how we organize the code sharing of the IDT handlers between stage2 and SVSM kernel. The SVSM needs more complicated handlers for some things (e.g. #PF) than stage2, and we want separate handlers for both.
We can divide that by introducing features, or just include different sub-modules for SVSM and stage2. Other suggestions are also welcome.

I think the feeature approach will only work if we separate things into different crates. As far as I know, there is no way to do conditional compilation depending on the binary being built (e.g. stage2 or SVSM kernel).
I'd say the best way is to separate both into different sub-modules and include them based on what's needed, as you suggest. Maybe something like src/cpu/idt/stage2.rs and src/cpu/idt/svsm.rs? And perhaps a third file for any common code and structures needed.

I'd say the best way is to separate both into different sub-modules and include them based on what's needed, as you suggest. Maybe something like src/cpu/idt/stage2.rs and src/cpu/idt/svsm.rs? And perhaps a third file for any common code and structures needed.

This looks good to me too

Does it make sense to have two different IDT handler arrays, one for stage 2 handlers and one for SVSM? Or would it be better to just refill idt_handler_array after stage 2 with the SVSM handlers?

PR is almost ready to be reviewed. I left some TODOs were I asked opened questions to me and reviewers, but here is a new one: do we need to already check CPL before the #VC handling (especially for IOIO) or should we wait for CPL-3 support to be working? Maybe @joergroedel

PR is almost ready to be reviewed. I left some TODOs were I asked opened questions to me and reviewers, but here is a new one: do we need to already check CPL before the #VC handling (especially for IOIO) or should we wait for CPL-3 support to be working? Maybe @joergroedel

I think there is no need to check CPL right now. For CPUID it doesn't matter and CPL-3 will not be able to do IOIO directly. For that an IO permission bitmap is needed which we are not planning to implement.

+pub fn cpuid() {

let mut _rax: u64 = 0;
let mut _rbx: u64 = 0;
unsafe {

   asm!(

   "

       mov $2, %rcx

       mov $0xD, %rax

       cpuid

       mov %rax, {rax}

       mov %rbx, {rbx}

   ", rax = out(reg) _rax, rbx = out(reg) _rbx, options(att_syntax)

   );

}
+}

Just from inspection, I'm worried that the compiler doesn't know that this assembly is modifying registers, so the compiler will assume they are unchanged and emit incorrect code. Additionally, llvm doesn't let you clobber %rbx even if you try to tell it, so that needs special care. Checking the emitted assembly should be able to confirm or deny this theory.
There's a core function for cpuid which should resolve both those issues: https://doc.rust-lang.org/stable/core/arch/x86_64/fn.__cpuid_count.html
I will try out your new version when you push it. I broke my own setup, though, so I'm trying to resolve that 😅

I ran tests with your new version and it passes the tests for cpuid, 8-bit port IO and 16-bit port IO.

Just from inspection, I'm worried that the compiler doesn't know that this assembly is modifying registers, so the compiler will assume they are unchanged and emit incorrect code. Additionally, llvm doesn't let you clobber %rbx even if you try to tell it, so that needs special care. Checking the emitted assembly should be able to confirm or deny this theory.
There's a core function for cpuid which should resolve both those issues: https://doc.rust-lang.org/stable/core/arch/x86_64/fn.__cpuid_count.html
Just from inspection, I'm worried that the compiler doesn't know that this assembly is modifying registers, so the compiler will assume they are unchanged and emit incorrect code. Additionally, llvm doesn't let you clobber %rbx even if you try to tell it, so that needs special care. Checking the emitted assembly should be able to confirm or deny this theory.

Good catch. I checked the disassembly and I couldn't find any obvious issue. The function deals with registers without saving anything on the stack. That maybe leaves registers in an inconsistent state, but nothing stroke me about incorrect stack management. Anyway, I tried with __cpuid_count() and I everything runs fine. Thanks!
I pushed a new version with IOIO handling in stage 2. If your tests still pass, I will remove the Draft tag :)

Good catch. I checked the disassembly and I couldn't find any obvious issue. The function deals with registers without saving anything on the stack. That maybe leaves registers in an inconsistent state, but nothing stroke me about incorrect stack management. Anyway, I tried with __cpuid_count() and I everything runs fine. Thanks!

The generated assembly might not make it obvious. Very likely what was happening was that CPUID was modifying registers that the compiler assumed unchanged because they were not marked out() or inout().

I pushed a new version with IOIO handling in stage 2. If your tests still pass, I will remove the Draft tag :)

I tried the new version and the previously-passing tests still pass (also IOIO for 32-bit operands, which was failing before due a bug in the test). I don't have them running in stage 2 yet, though.
There's also some IO tests that are still failing when the port is encoded in the instruction, e.g:
fn outl_to_testdev_echo(value: u32) {
    unsafe { asm!("outl %eax, $0xe0", in("eax") value, options(att_syntax)) }
}

it looks like this happens when the opcode is 0xe4, 0xe5, 0xe6, or 0xe7. I'm not sure if you care about supporting this case, but I thought I'd mention it.

I pushed a new version with IOIO handling in stage 2. If your tests still pass, I will remove the Draft tag :)

I tried the new version and the previously-passing tests still pass (also IOIO for 32-bit operands, which was failing before due a bug in the test). I don't have them running in stage 2 yet, though.

As we said, I don't expect different behavior in stage 2 and SVSM kernel, but if it's possible for you to test in stage 2, that would be safer. Let me know if there's anything I can do :)

There's also some IO tests that are still failing when the port is encoded in the instruction, e.g:
fn outl_to_testdev_echo(value: u32) {
    unsafe { asm!("outl %eax, $0xe0", in("eax") value, options(att_syntax)) }
}

it looks like this happens when the opcode is 0xe4, 0xe5, 0xe6, or 0xe7. I'm not sure if you care about supporting this case, but I thought I'd mention it.

Indeed, port specified in an imm8 is currently not supported. We'll add support later if needed.

I added testing support to stage2 and the cpuid tests pass there as well.

I added testing support to stage2 and the cpuid tests pass there as well.

Great. I'll remove the Draft tag of my PR then, and make it open for review. Your testing code looks good to me :)

Okay, so there have been some suggestions included by me on-top. Can you nuke this commit and rebase the base-PR to latest main branch, please? Please also address Carlos' comments when updating.

Rebased on main, and added Carlos' proposals

By the way your commit messages seem to be strangely line wrapped. I suggest wrapping lines at 70 or 72 columns.

@p4zuu Can you please work in the suggestions from @00xc and rebase to latest main branch? This should fix the CI failure too.


exited by signal SIGKILL on extract

I use docker image on Raspberry Pi 3.
The initial import is failed by SIGKILL.

cli.spawn Cli extract --index /data/config/Pictures.idx --storage /data/storage --exclude *.mp4 --exclude *.MOV --exclude *.mov exited by signal SIGKILL

how to solve this?
$ gallery --version
1.10.0

Hi @inajob
maybe it is an issue with the your cpu und sharp? See https://github.com/xemle/home-gallery/issues/81#issuecomment-1595175119

I used that option, but below error occurred.

cli.spawn Cli extract --index /data/config/Pictures.idx --storage /data/storage --exclude *.mp4 --exclude *.MOV --exclude *.mov --use-native vipsthumbnail convert ffprobe ffmpeg exited by signal SIGKILL

@xemle I see.
My raspberry pi 3 runs other softwares, so I try to stop these processes, and try extract again.

As I said, this Raspberry Pi runs other softwares, so free memory is few...
$ free -h
               total        used        free      shared  buff/cache   available
Mem:           922Mi       396Mi       185Mi       5.0Mi       340Mi       469Mi
Swap:           99Mi        99Mi       0.0Ki

Result of below command.

/app/gallery.js -l trace extract --index /data/config/Pictures.idx --storage /data/storage --exclude *.mp4 --exclude *.MOV --exclude *.mov --use-native vipsthumbnail convert ffprobe ffmpeg

<--- Last few GCs --->

[1:0x741f3070]  3462962 ms: Scavenge 193.7 (218.6) -> 193.3 (218.6) MB, 1.2 / 0.0 ms  (average mu = 0.986, current mu = 0.988) allocation failure;
[1:0x741f3070]  3463606 ms: Scavenge 193.7 (218.6) -> 193.3 (218.6) MB, 1.3 / 0.0 ms  (average mu = 0.986, current mu = 0.988) allocation failure;
[1:0x741f3070]  3471456 ms: Mark-sweep 263.5 (288.4) -> 255.3 (282.4) MB, 3755.7 / 110.4 ms  (average mu = 0.968, current mu = 0.950) allocation failure; scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory

I'll stop other software, but I want the way for few memory.
In my case some photo extract succeeded. Are some photos too big? or  does nodejs process make big for the sake of garbage?

Hi @inajob thank you so much for the investigation. Currently I can not tell what requires such amount of resources. It would need a profiler to catch these hotspots. An I would recommend to do such investigation on a desktop environment.
While in theory it should be possible to run the media conversion on a low powered device such Rasperry Pi 3 it might not be the best solution to do so.
You can also create the gallery on a powerful desktop machine and fetch the final gallery from your Pi. See the (fetch command)[https://docs.home-gallery.org/cli/index.html#fetch-command]. The server part should require less resources. The gallery can be also served as read only gallery (no tagging) via a static export and requires even less resources. See the (export command)[https://docs.home-gallery.org/cli/index.html#export-command].
Regarding a remote data repository there is no solution so far. One idea is to use (rclone)[https://rclone.org/] as docker remote storage. Should work but I have not tested it yet.
Hope these ideas are helping.
And thanks again for your time and valuable input.

Closing it due inactivity. Please do not hesitate to reopen it if required.


Fix viewer error while trying to replay a bag file with confidence stream

Can be tracked on [RS5-8431]


Correct state-transfer timeout default value in server xsd

As changed in 67e188b4f32a0639f5a0978c665f01597f0a41ac, which updated the default value in org.jboss.as.clustering.infinispan.subsystem.StateTransferResource.java from 60000 to 240000 to match the default state transfer timeout in Infinispan core.
Again, I'm not sure if you'd prefer an ISPN for this sort of change. Please advise and I'll create one.

Pushed, thanks (no need for a Jira for such trivial things)


Integrate Sourcecast and Sourcereel components

Add table to store Sourcecast entries
Support uploading and retrieving of binary data
Relevant to source-academy/cadet-frontend#707

Pull Request Test Coverage Report for Build 2531

2 of 33 (6.06%)  changed or added relevant lines in 6 files are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-4.1%) to 91.73%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/cadet/course/upload.ex
2
3
66.67%

lib/cadet_web/router.ex
0
1
0.0%

lib/cadet/course/sourcecast.ex
0
4
0.0%

lib/cadet_web/views/sourcecast_view.ex
0
4
0.0%

lib/cadet/course/course.ex
0
5
0.0%

lib/cadet_web/controllers/sourcecast_controller.ex
0
16
0.0%

Files with Coverage Reduction
New Missed Lines
%

lib/cadet/course/query.ex
1
0.0%

lib/cadet/course/upload.ex
1
50.0%

lib/cadet/course/course.ex
6
56.0%

Totals

Change from base Build 2528:
-4.1%

Covered Lines:
843

Relevant Lines:
919

💛  - Coveralls


Litecoin Support

Currently we don't really support LTC. We only use Bitcoin icons, only convert to BTC price, etc. I think it would be valuable if we supported Litecoin and allowed the user to pick which chain they'd like to launch on during onboarding.

Agreed! How can we make this a priority? 😀
Let me know how I can help. I can tweet about it and ask for volunteers to help, but it would be good for it to be easy to figure out what needs to be changed.

@coblee Currently we connect to BTCd nodes that support Neutrino. Does Litecoin support neutrino?

Please don’t don’t make crap coins a priority.

@coblee @losh11  I've made a few minor modifications in order to better support Litecoin.
This can be tested here https://github.com/LN-Zap/zap-desktop/pull/1081
This mostly amounts to adding better support for litecoin currency subunits, using dynamic values for things like chain and network names, and ensuring that our address and invoice parsing can correctly detect litecoin addresses and lightning network payment requests.
This currently only works with connect ting to a remote lnd instance that is on the litecoin chain. We can't support local wallets until litecoin support Neutrino

Fixed via #1081


merge BuildableElement and Element

There are no classes that extend Element other than BuildableElement at this point, and BuildableElement and Element aren't really that distinct. For example, "dependencieChanged" exists in Element just so Buildable can override it.

If we're going to do this, we should do it. If we think this split makes sense for documentation purposes, let's close the bug.


there is error in calculating positions of joints

i parsed some 'CMU mocap dataset'(http://www.mediafire.com/file/nj2mtzj4ymm/cmuconvert-max-01-09.zip)
and extracted positions of joints by your pyMO
and the values of position on some frames are very strange.
for example, the 'y-value of right toe' increase to 24 (normally it is in range 0~5)
when i visualize it, the skeleton figure spin and fly in impossible manner.
some position values r totally abnormal.
when i visualize original bvh file by 'bvh hacker' there is no problem. i think it is parser(pyMO) issue

I made a pull request.
https://github.com/omimo/PyMO/pull/7


(feat) Show messages' timestamp in UI

Short description of the problem this fixes or functionality that this introduces. This may be used for the CHANGELOG
Added timestamp display for each chat message.

Give a summary of what the PR does, explaining any non-trivial design decisions

chat-related UI components and tests extended to take timestamp into account
aria-label for chat messages with translations for screen readers, like Message from Assistant
tweaks in backend for consistent datetime handling

TODO?

the date format of the user's browser or system should already be used, need confirmation from other regions
is extra styling needed? is the frontend code meeting standards?

Link of any specific issues this addresses

How come the pre-commit doesn't run prettier on changed frontend files, but the workflow errors on them? grrr

Thanks for all your expert advice, @amanape ! 🏅


Add Databend to landscape

Pre-submission checklist:
Please check each of these after submitting your pull request:

[x] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[x] Is your project closed source or, if it is open source, does your project have at least 300 GitHub stars?
[x] Have you picked the single best (existing) category for your project?
[x] Does it follow the other guidelines from the new entries section?
[x] Have you added your SVG to hosted_logos and referenced it there?
[x] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[x] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~30 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

It looks like crunchbase needs to be set up correctly (including headquarters and LinkedIn) , I've marked it as a draft for now.

LGTM


CommonLogFactoryExtensions.UseCommonLogging couse StackOverflow

UseCommonLogging(this IAppBuilder app, Func<ILog, TraceEventType, bool> isLogEventEnabledFunc)
and
UseCommonLogging(this IAppBuilder app, Action<ILog, TraceEventType, String, Exception> writeLogEventFunc)
call them themselves

Yikes, that was an oversight.


warning issued by NBP - written to log:  WARNING [org.netbeans.api.actions.Savable]: Savable class uk.org.rlinsdale.nbpcglibrary.node.nodes.TreeNodeRW$NodeSavable is not in Savable.REGISTRY! Have not you forgotten to call register() in constructor?

Not seen an any latest build - assume that it was a problem with one particular build which has been removed in later builds

can replicate problem if I cut and paste a node from one parent entity to another.

fixed by commit 9a32fc80e0bd66d98b4bed205088903b68616513  (moving savable to entity)


Declaring the "fuzzy-search" plugin after "graphql", produces Strapi throw an error.

Hi all,
as the title says when I declare fuzzy-search plugin after the graphql, cause an error.

Instead, when declaring the plugin before all works as expected.

Hey @Sunny-Pirate ,
thanks for bringing this to my attention! I will have a look as soon as I have some time 👍

Fixed in 1.9.5

@all-contributors please add @Sunny-Pirate for bug


Error on GetGroupParticipants

I have a error on window.WAPI._getGroupParticipants, somebody else?
How can I fix?
Thanks!

we did these changes at wapi.js and it works now


scan quietly exits if repo path doesn't exist/not readable

Hi @mgrajesh1 ,
Can you please specify how can I reproduce this issue?
Thanks.

@mgrajesh1, I have opened a PR for resolving the bug.
Please check it out and let me know if there is anything to improve.

#17

Issue fixed, thank you


[T4A2][W11-B3]Tang Kai Ling

Ready for review

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


tests failing on linux64

81% tests passed, 18 tests failed out of 94
Total Test time (real) =  50.28 sec
The following tests FAILED:
77 - xeigtstz_nep_in (Failed)
78 - xeigtstz_sep_in (Failed)
79 - xeigtstz_svd_in (Failed)
80 - xeigtstz_zec_in (Failed)
81 - xeigtstz_zed_in (Failed)
82 - xeigtstz_zgg_in (Failed)
83 - xeigtstz_zgd_in (Failed)
84 - xeigtstz_zsb_in (Failed)
85 - xeigtstz_zsg_in (Failed)
86 - xeigtstz_zbal_in (Failed)
87 - xeigtstz_zbak_in (Failed)
88 - xeigtstz_zgbal_in (Failed)
89 - xeigtstz_zgbak_in (Failed)
90 - xeigtstz_zbb_in (Failed)
91 - xeigtstz_glm_in (Failed)
92 - xeigtstz_gqr_in (Failed)
93 - xeigtstz_gsv_in (Failed)
94 - xeigtstz_lse_in (Failed)
Errors while running CTest

@alanjt Got the same exact test failures as you when I was building CLAPACK 3.2.1 32-bit static debug libraries using the source with CMake config. I looked at the CMake test log and all the failures seem to be due to a stack overflow.
Steps to reproduce:

cd into clapack-3.2.1-CMAKE top-level dir
Build: cmake -S . -B build_windows_x86 -A Win32 && cmake --build build_windows_x86 --config Debug
Test: ctest --test-dir build_windows_x86 -C Debug

Note that this also produces the same test failures when building for 64-bit as well. Compiler is Visual Studio 2019.
We probably should bring this up to the LAPACK mailing list or the official GitHub repo for Netlib LAPACK. At the same time, however, it's probably better to use LAPACKE over CLAPACK when possible. CLAPACK has not been updated in a while and LAPACKE, which provides a more natural C interface to LAPACK, is the preferred way to use LAPACK from C nowadays.

Anyways, I have filed an official issue in the Netlib LAPACK repo and did some digging to see if I could fix the issue.
Turns out 12 MB seems to be sufficient stack space to reserve for each test program, which can be specified to the MSVC linker via the /STACK parameter, e.g. with /STACK:12000000. I think in the past the CLAPACK folks ran into this issue before as the following lines from TESTING/CMakeLists.txt show that there was an attempt to increase the stack size reserved:
https://github.com/openmeeg/clapack/blob/543e60b09fde5ea3329f1f0b597c8951e3858533/TESTING/CMakeLists.txt#L1-L6
This is ineffective, however, as at least for Visual Studio 2019 and Visual Studio 2022 I tried, no /STACK parameter is passed to the linker by default. It's easy to fix this, however, by just modifying CMAKE_EXE_LINKER_FLAGS, e.g. replace above with
if(MSVC)
  set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /STACK:12000000")
endif()

At least for me this worked and all the tests reporting stack overflow pass now.


Allow specifying nodes as a tree

Where the nodes literally nest under their parents with an implied edge type, and then cross-links are done manually across branches.

Related to #18


Default colors only last for one print

This is a bit strange, but I'm noticing that the default colors I have configured work on the first print, but then they revert  back to the default colors. I have a black background and the default blue for numbers is hard to see, so I've changed it to cyan:

Here I am loading the same object twice, and the first time the numbers are cyan, but the second time they are blue:

Stranger still is that when I print out the defaults, the first time the colors are "right" but the defaults are not the ones I set, and the second time the color goes back to blue:

On further inspection I think this might be because I put the AmazingPrint.defaults in a rails initializer, not ~/.aprc. Putting it in ~/.aprc works, but I'd prefer to version this with my app. Is that not possible?

Today, each new instance of AmazingPrint::Inspector loads settings from .aprc so I think what's happening is that the first time your Rails initilizer is running the first inspector loads and sets the new defaults but then invoking ap again reloads the settings.
This is definitely not efficient but allows or "hot reloading" settings that could change while pry session is open. This would be a major change but I think we should consider not reloading these settings so often and instead provide some command like AmazingPrint.reload!
@paddor what do you think?

Today, each new instance of AmazingPrint::Inspector loads settings from .aprc so I think what's happening is that the first time your Rails initilizer is running the first inspector loads and sets the new defaults but then invoking ap again reloads the settings.
This is definitely not efficient but allows or "hot reloading" settings that could change while pry session is open. This would be a major change but I think we should consider not reloading these settings so often and instead provide some command like AmazingPrint.reload!
@paddor what do you think?

I definitely think that .aprc should be loaded only once. I believe, years ago, I even used to have monkey patch in place that prevented this because it was too much IO. AmazingPrint.reload! would be perfect. PR welcome.

@HarlemSquirrel I am absolutely swamped with work right now, so I probably won't be testing this out any time soon. Happy to hear of updates if they come though..


Possible bug in tpfp_default function

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help. Yes
I have read the FAQ documentation but cannot get the expected help. Yes
The bug has not been fixed in the latest version. Not sure

Describe the bug
A possible bug in the tpfp_default function
Reproduction

What command or script did you run?

det_bboxes = [np.empty((0,5),dtype=np.float32),
 np.array([[ 10.883263  ,   7.913588  ,  50.09307   ,  41.983116  ,
           0.9999995 ],
        [ 10.935097  ,  62.953075  ,  50.253815  ,  97.011185  ,
           0.9999994 ],
        [ 66.63542   ,  63.00221   , 105.61375   ,  97.05599   ,
           0.9999994 ],
        [ 48.879272  ,  61.791405  ,  96.49773   ,  98.70493   ,
           0.05674577]],dtype=np.float32),
 np.empty((0,5),dtype=np.float32),
 np.array([[ 10.5680065 ,   8.000481  ,  50.01112   ,  42.11482   ,
           0.09419172],
        [ 11.049884  ,  62.87168   ,  50.32121   ,  97.09515   ,
           0.07246841],
        [ 66.53909   ,  63.025635  , 105.549904  ,  97.01488   ,
           0.0505808 ]],dtype=np.float32),
 np.empty((0,5),dtype=np.float32),
 np.empty((0,5),dtype=np.float32),
            ]

gt_bboxes = [np.empty((0,4),dtype=np.float32),
np.array([[ 66.008,  63.   , 105.   ,  97.   ],
        [ 10.992,   7.992,  50.   ,  41.992],
        [ 10.992,  63.   ,  50.   ,  97.   ]],dtype=np.float32),
np.empty((0,4),dtype=np.float32),
np.empty((0,4),dtype=np.float32),
np.empty((0,4),dtype=np.float32),
np.empty((0,4),dtype=np.float32)
]

tpfp_default(det_bboxes[1][:,:4],gt_bboxes[1],np.empty((0, 4), dtype=np.float32))

Output get
(array([[1., 1., 0., 1.]], dtype=float32),
 array([[0., 0., 1., 0.]], dtype=float32))

when I expect
(array([[1., 1., 1., 0.]], dtype=float32),
 array([[0., 0., 1., 0.]], dtype=float32))

Did you make any modifications on the code or config? Did you understand what you have modified?
No
What dataset did you use?
NIL

Environment

Please run python mmdet/utils/collect_env.py to collect necessary environment information and paste it here.
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source]
Other environment variables that may be related (such as $PATH, $LD_LIBRARY_PATH, $PYTHONPATH, etc.)

sys.platform: linux
Python: 3.8.5 (default, Sep  4 2020, 07:30:14) [GCC 7.3.0]
CUDA available: True
GPU 0,1,2,3,4,5,6,7: Tesla V100-SXM2-32GB
CUDA_HOME: None
GCC: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
PyTorch: 1.9.0+cu102
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - C++ Version: 201402
  - Intel(R) Math Kernel Library Version 2020.0.2 Product Build 20200624 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v2.1.2 (Git Hash 98be7e8afa711dc9b66c8ff3504129cb82013cdb)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 10.2
  - NVCC architecture flags: -gencode;arch=compute_37,code=sm_37;-gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_70,code=sm_70
  - CuDNN 7.6.5
  - Magma 2.5.2
  - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=10.2, CUDNN_VERSION=7.6.5, CXX_COMPILER=/opt/rh/devtoolset-7/root/usr/bin/c++, CXX_FLAGS= -Wno-deprecated -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -fopenmp -DNDEBUG -DUSE_KINETO -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wno-narrowing -Wall -Wextra -Werror=return-type -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-unused-local-typedefs -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-psabi -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=1.9.0, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON,

TorchVision: 0.10.0+cu102
OpenCV: 4.2.0
MMCV: 1.3.13
MMCV Compiler: GCC 7.3
MMCV CUDA Compiler: 10.2
MMDetection: 2.16.0+a7a16af

Error traceback
If applicable, paste the error trackback here.
A placeholder for trackback.

Bug fix
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!

I think it is an error in this line
# sort all dets in descending order by scores
    sort_inds = np.argsort(-det_bboxes[:, -1])

and additional  - in front of det_bboxes[:.-1] which causes the dets scores to be sorted by ascending order instead.

Spotted an error in my input. Apologies for the mistaken error.


Change 'make fmt' to be inline with 'make verify-format'

[x] Change 'make fmt' to be inline with 'make verify-format'
[x] Change from 'go fmt' to 'gofmt'
[x] Test that 'make fmt' still changes files as expected

/lgtm


WIP: Stress test timing

Got the data: https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/organizations/jenkins/pmem-csi/detail/PR-335/1/pipeline/73


Modifier -> SwiftUI -> Input events: touchBarItemPrincipal(_:)

Doc: https://developer.apple.com/documentation/swiftui/view/touchbaritemprincipal(_:)

[ ] Swift implementation
[ ] Elixir implementation

We won't support this for now


fix typos

Dear Nicki, I will attend the MLOps Jan 2025 and, doing some pre-reading, I found some typos in the material. Please find some suggested minor edits in this pull request, if helpful. The suggested changes are up to M6. Kr, Sebastian

I @segiITU (Sebastian)
Thanks for your fixes! keep sending them if you like to in the future!
Cheers, Nicki


build version to 3.2.4 as needed for pynfft

The last release of pyNFFT needs version 3.2.x of this library. This PR rebuild 3.2.4 using the new compilers.
Only releases 3.3+ are on GitHub, so I had to switch the download location.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin , please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.