API server should support audit logging options

The service catalog api server should support the same generic audit log options as a normal k8s server to support integration in environments that use existing audit logging support in k8s.
For reference:
--audit-log-maxage int                                    The maximum number of days to retain old audit log files based on the timestamp encoded in their filename.
--audit-log-maxbackup int                                 The maximum number of old audit log files to retain.
--audit-log-maxsize int                                   The maximum size in megabytes of the audit log file before it gets rotated. Defaults to 100MB.
--audit-log-path string                                   If set, all requests coming to the apiserver will be logged to this file.  '-' means standard out.

My understanding is much of this should come in the generic machinery today once we enable it.

yay generic machinery!


Updated deceased datetime in FHIR exporter

Updated FHIR exporter to handle the rare case when a patient's death date exists as an event but still occurs in the future (the patient hasn't actually died yet). This is typically seen for patients with lung cancer and is a rare occurence (1-3 in 10k records). Also added the deceasedBoolean field to the FHIR records that are exported to make it easier to query FHIR for living or deceased patients using the Patient?deceased=true/false query.

You cannot have both deceasedBoolean and deceasedDateTime -- it is consider a choice in the FHIR. You can have one or the other, but not both.

I don't actually this this is as simple as asking if the patient is dead as of Time.now because you'll also have to remove the cause of death from the record, if it is present, among other things.
You probably need to pass a date (default to Time.now if you want) into the export -- and passed down the stack -- that will filter out all items in the record that occur after the given date.

Ah, I didn't know the [x] properties in the spec had that rule. Seems silly to me but I'll fix it. Reference: http://hl7.org/fhir/2016Sep/formats.html#choice

I followed your recommended approach above and added an end_dateargument to the FHIR and CCDA exports (defaults to Time.now) that is combined with is_alive? to test if a patient's deceasedDateTime property should be recorded. This is also used in filter_for_export().

Based on conversation with @jawalonoski, if an entity in the patient's record ends in the future it's end time is now removed before that entity is exported, but that entity is still kept in the patient's record. I decided to do this for MedicationOrders as well so we're consistent with how we're handling things.


Match jshintrc indent size to editorconfig

.editorconfig specifies four space indent.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

Hmm, the checker will pick up me having now signed the CLA, right?

Thanks!


Error while handling packets with no template

Greetings.
I used a mikrotik generated netflow and found there is a problem when the full template is not send with every packet.
i.e
Listening on interface :2055
Starting the NetFlow listener
Received data from <IP_ADDRESS>, length 204
Processed ExportPacket with 2 flows.
Received data from <IP_ADDRESS>, length 1268
Exception happened during processing of request from ('<IP_ADDRESS>', 2055)
Traceback (most recent call last):
  File "/usr/lib/python3.4/socketserver.py", line 305, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python3.4/socketserver.py", line 331, in process_request
    self.finish_request(request, client_address)
  File "/usr/lib/python3.4/socketserver.py", line 344, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python3.4/socketserver.py", line 673, in __init__
    self.handle()
  File "main.py", line 72, in handle
    export = ExportPacket(data, self.TEMPLATES)
  File "/home/stelios/projects/netflow/python-netflow-v9-softflowd/src/netflow/collector_v9.py", line 266, in __init__
    dfs = DataFlowSet(data[offset:], self.templates)
  File "/home/stelios/projects/netflow/python-netflow-v9-softflowd/src/netflow/collector_v9.py", line 146, in __init__
    fkey = field_types[field.field_type]
KeyError: 225
Received data from <IP_ADDRESS>, length 204
Processed ExportPacket with 2 flows.

The first packet contains a complete template flow for two templates (with id;s 256 and 257)
256 is for ipv4 traffic and id 257 is for IPV6.
Since the IPV6 has different fields when a data packet arrives for IPV4 it does not have the fields.
According to the specs, the sender does not have to send the entire template everytime  and the recipient has to cache the template and use it, till it expires or its resend.
softflowd sends only one template with id 1024 so probably this is why you haven't seen it.
i.e
https://www.cisco.com/en/US/technologies/tk648/tk362/technologies_white_paper09186a00800a3db9.html

Hello, thanks for your bug report!
I see two things:

The persistence of templates is an issue, yes. I thought about solving it by using a unique identifier for each template and save it to disk, so it could be reloaded later if the collector is restarted and loses state. But:

Your tracelog indicates a KeyError with key 225 because the template seems to use a field identifier which is not found in the hardcoded list of field types. I'd like to debug this further, but my guess is that your NetFlow sender uses custom fields which are not defined in the specs.

The best solution would be to catch this error and produce debugging output. Maybe you find the time to narrow down the issue, it would improve the lib greatly to catch another edge-case :wrench:

I think you are right on 2.
There are 4 field types 225,226,227 and 228 which are not in the list.
These, as i found out, are not custom fields but an extension to the V9 spec by Cisco to handle the ASA
https://www.cisco.com/c/en/us/td/docs/security/asa/special/netflow/guide/asa_netflow.html
It also defined a few other types namely in the XXXXX range which are custom defined by manufacturers
PaloAlto networks defines 346,56701,56702
https://www.paloaltonetworks.com/documentation/80/pan-os/pan-os/monitoring/netflow-monitoring/netflow-templates
I can assume others define also their own (Don't you love standards :D)
For 1. I have not looked into how the code handles the templates

This is the error when the template is now known (i.e collector (re)started in the middle of the stream)
In my case the router will resend the templates after 20 packets and it syncs without an issue
Listening on interface :2055
Starting the NetFlow listener
Received data from <IP_ADDRESS>, length 508
Exception happened during processing of request from ('<IP_ADDRESS>', 2055)
Traceback (most recent call last):
File "/usr/lib/python3.4/socketserver.py", line 305, in _handle_request_noblock
self.process_request(request, client_address)
File "/usr/lib/python3.4/socketserver.py", line 331, in process_request
self.finish_request(request, client_address)
File "/usr/lib/python3.4/socketserver.py", line 344, in finish_request
self.RequestHandlerClass(request, client_address, self)
File "/usr/lib/python3.4/socketserver.py", line 673, in init
self.handle()
File "main.py", line 72, in handle
export = ExportPacket(data, self.TEMPLATES)
File "/home/stelios/projects/netflow/python-netflow-v9-softflowd/src/netflow/collector_v9.py", line 271, in init
dfs = DataFlowSet(data[offset:], self.templates)
File "/home/stelios/projects/netflow/python-netflow-v9-softflowd/src/netflow/collector_v9.py", line 141, in init
template = templates[self.template_id]
KeyError: 256

are not custom fields but an extension to the V9 spec by Cisco to handle the ASA

It also defined a few other types namely in the XXXXX range

Thanks for the research! It won't be a problem to add these IDs to the list, since the field_type struct can hold up to 65535 identifiers. I'll add them in the next days if possible! (also adding a try-except block…)

This is the error when the template is now known (i.e collector (re)started in the middle of the stream)

Did you mean is not known?

Templates periodically expire if they are not refreshed. Templates can be refreshed in two ways. A template can be resent every N number of export packets. A template can also be sent on a timer, so that it is refreshed every N number of minutes. Both options are user configurable.
If a collector (i.e python netflow) connects to the stream after the template is send it has no way of knowing what the flow data in the packets mean, until the template is resend.
From my little experimentation some devices collect and aggregate data for longer periods of time (i.e softflowd has a default of 5 minutes) and others like mikrotik send packets every few seconds.
Those that aggregate data for longer periods (usually) send the templates also before the data, while the ones that send more frequent packets send several data flow packets before the template is resend, probabably to save on bandwidth.
I guess the best way to handle this to have a message that says something similar to "Data received but no know template exists" and continue operations waiting for the template

I have added the referenced additional field types, if you'd like to test it out!

Tested it and works fine. You can close the ticket


Fixes #264 , Issue with overlapping events

Description

Checklist

[x] The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
[x] I have followed the [Contributor Guide] when preparing my PR.
[x] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?
] No, this PR is not a breaking change.
Related Issues
Closes #264

LGTM


[OSPP]The proposal for Unknown Task Recognition Algorithm Reproduction based on Lifelong Learning of Sedna

What type of PR is this?
/kind feature
What this PR does:
This PR is a proposal that project aims to reproduce the CVPR2021 paper "Learning placeholders for open-set recognition" in the Semantic Segmentation dataset. This paper proposes placeholders that imitate the emergence of new classes, thus helping to transform closed-set training into open-set training.

@Xxllj834738992

Delete binary files.
Combine multiple commit messages into one.
Add a signature to each commit.
watch https://github.com/kubeedge/ianvs/pull/13/checks?check_run_id=7729376932


[BCEL-297] Fix NPE in BCELComparator concrete implementations.

This PR fix the potential NPE.

Hi @zhangminglei and thank you for your patch.
Can you redo your patch on top of our current SVN trunk please?
Thank you,
Gary


Try increased test coverage

Codecov Report

Merging #184 (d525764) into main (1c4487c) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #184     +/-   ##
=======================================
+ Coverage   97.3%   97.3%   +0.1%
=======================================
  Files         44      44
  Lines       2838    2847      +9
=======================================
+ Hits        2759    2769     +10
+ Misses        79      78      -1

Impacted Files
Coverage Δ

test/test_decwide_t_algebra_edge.cpp
99.0% <100.0%> (+0.2%)
:arrow_up:

math/wide_decimal/decwide_t.h
96.8% <0.0%> (+0.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4487c...d525764. Read the comment docs.


Builtins, multiple versions, and new installs

Trying to (require-package 'project '(0 5 3)) doesn't work, because 'project is builtin, and even though the version isn't sufficient, (package-install 'project) will just choose the builtin. The package-desc needs to be passed in. Along with that, I try to select the highest version.
The return value from (package-install package) is sometimes nil if the package was not previously downloaded, so I've changed the return value of (require-package) to be whether the package is actually installed. (I tested this by rm -rf the package-user-dir and then starting up emacs.)

I'm not sure my comment above was entirely clear. As an example, in init-selectrum.el, there is the form (when (maybe-require-package 'selectrum). maybe-require-package returns the value of require-package, and if the package is not already installed, returns the value of package-install, which sometimes return nil if the package is not already downloaded, even if the install is later successful.

Thanks for tracking this down.
I committed a slightly more concise version of this in https://github.com/purcell/emacs.d/commit/18816a9ffbc4b607d9b2409fa6775996573b3c76, which I believe is equivalent, but please correct me if I'm mistaken.

I like yours better. Thanks!


net/freeradius: quotes missing when setting password

The FreeRADIUS-plugin does not save the password using single quotes in the config file (/usr/local/etc/raddb/mods-enabled/ldap). This leads to issues if a user password contains non-alphanumeric characters.

Created PR #1239

Solved by #1239


UI is not working / chatbot-ui does not start

Hello!
Sorry for the dump question maybe, I just found llama-gpt, and this is the very first try to run a gpt model locally.
Trying it on my M1 Pro macbook
I run run-mac.sh, it downloaded everything, and I run the server successfully:

Uvicorn running on http://localhost:3001

If I go to localhost:3001/docs# - I can see API interface
When I go to localhost:3001 itself, I have a response

{"detail":"Not Found"}

And in log

INFO:     ::1:55660 - "GET / HTTP/1.1" 404 Not Found

I tried to install chatbot-ui externally, but was not able to connect it with this server.
From the documentation I suppose that chatbot-ui should be installed, but I can't find it running anywhere.
So how I can see it running actually ?

On my machine, using the run-mac.sh script, the API runs on port 3001 while the UI is on port 3000

Getting the same issue.
Logs:
INFO:     Started server process [16475]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://localhost:3001 (Press CTRL+C to quit)
INFO:     ::1:64888 - "GET / HTTP/1.1" 404 Not Found
INFO:     ::1:64888 - "GET /favicon.ico HTTP/1.1" 404 Not Found

The chatbot-ui is running on http://localhost:3000 not http://localhost:3001

The chatbot-ui is running on http://localhost:3000 not http://localhost:3001

It is not getting up during the run-mac.sh script running

I have the same issue no UI

I tried port3000, not working. I modified run-mac.sh, set port number to 3003 or whatever. It doesn't help.
The error message is
INFO:     Uvicorn running on http://localhost:3002 (Press CTRL+C to quit)
INFO:     ::1:64735 - "GET / HTTP/1.1" 404 Not Found
INFO:     ::1:64735 - "GET /favicon.ico HTTP/1.1" 404 Not Found

I tried port3000, not working. I modified run-mac.sh, set port number to 3003 or whatever. It doesn't help. The error message is
INFO:     Uvicorn running on http://localhost:3002 (Press CTRL+C to quit)
INFO:     ::1:64735 - "GET / HTTP/1.1" 404 Not Found
INFO:     ::1:64735 - "GET /favicon.ico HTTP/1.1" 404 Not Found

getting the same error

Same issue

I think it is related to https://github.com/abetlen/llama-cpp-python/issues/520
There is name space conflict and one of the depending containers exit with an error code so the current version is broken right now.

Make sure your have Docker installed and running. I initially overlooked that, once I started Docker, chatbot-ui is running in a container fine.

brew install homebrew/cask/docker
brew install docker-composer
open run-mac.sh, replace all the " docker compose" words to "docker-compose"
sudo chown [your mac login user]:staff /Users/yee/Library/Caches/pip
Still unable to work
{"detail":"Not Found"}

@labolado
What happens when you run docker ps in Terminal?
You should see something similar to this output:
CONTAINER ID   IMAGE                        COMMAND                  CREATED      STATUS      PORTS                    NAMES
21b91af3d69a   llama-gpt-llama-gpt-ui-mac   "docker-entrypoint.s…"   2 days ago   Up 2 days   <IP_ADDRESS>:3000->3000/tcp   llama-gpt-llama-gpt-ui-mac-1

If you don't see it running, check out this https://www.docker.com/blog/how-to-fix-and-debug-docker-containers-like-a-superhero/

What may be happening:
@ericpardee  I have managed to get it going, whilst the initially having the same issue. My steps were:

Create "server-mac.sh" bash file, which will contain the server starting script and all needed variables in it
Run the shell script with ./server-script.sh model=code-13b
Debug all incoming errors (All of them consisted of modules not found)

My thoughts on what is happening might be that install_llama_cpp_python(){} block doesn't break the run-mac.sh execution on encountering errors. Also, the script is either not installing all the needed packages or it is intalling them to incorrect location, when python is installed via pyenv in brew  (i.e. brew install pyenv ---> pyenv install python).
I am not skillful in shell scripting, so I am not able to PR the possible solution to the discoverings.
My computer:

MacOS Sonoma 14.0 on MacBook Pro M2 Pro (16 cores)
Warp terminal with zsh 5.9v
Docker version 20.10.22, build 3a2c30b

Outputs of which:

/opt/homebrew/bin/python3
/opt/homebrew/bin/pip3
/usr/local/bin/brew
llama-cpp-python in /opt/homebrew/lib/python3.11/site-packages (0.2.13)

@mayankchhabra Could you please take a look into it? git blame shows you as the main contributor to run-mac.sh

@labolado  It is actually a normal response of the server when accessing it via localhost:3001. When the server responds with anything - the ui shows the dropdown select to choose between available models.


Incorrect parameter count detection

SqlUtility.GetParameterNames returns 2 parameter names ( : and :00 ) for the following SQLite query
CREATE VIEW IF NOT EXISTS ListIDs_24h AS
SELECT
  EPC,
  substr( EPC, 15, 4 ) AS Type,
  substr( EPC, 19 ) AS ID,
  strftime( '%Y-%m-%d %H:%M:%S', Timestamp ) AS Timestamp
FROM LogEntries
WHERE Timestamp > datetime( 'now' ) - time( '24:00' )
ORDER BY Timestamp DESC

This causes an exception when you try to execute it with session.Advanced.Execute because it "misses" 2 parameters. Providing two empty parameters lets the query run without issues or negative effects.
As far as I understand this, the colon is used in some databases like Oracle as an identifier for parameters, but not in others.
Maybe IDbDriver or ISqlDialect could provide the GetParameterNames method to allow for differences.

SqlUtility is used because there are times where we need to match/re-number parameters when the IDbDriver isn't known. It's also one of the oldest parts of the current code base so I'll review how it's used as I work on 6.2 and see if it's possible to be more dialect specific without duplicating that logic in numerous places.


Please, make it possible to use also more modern and expensive models

Please please plese. gpt-3.5 in the end of 2024? seriously? we need opportunity to request a bigger AI budget for the next year.

I need this feature to secure VC Funding for my startup ✨

I have an upcoming board meeting next week and need to make sure that we integrate AI into our core modules. Would love this feature as well, to just say yes


Docs about NoExecute taint don't clarify that PDBs are ignored

This is a Bug Report

Problem:
This is in regards to this page: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
There, one can read Normally, if a taint with effect NoExecute is added to a node, then any pods that do not tolerate the taint will be evicted immediately [...]
A quick with a a pod covered by a PDB that allows zero disruption quickly shows that PDBs are not respected and that thus the eviction api is not actually used.
Proposed Solution:
Reword the passage to then any pods that do not tolerate the taint will be _deleted_ immediately as it doesn't seem that any kind of eviction is happening.
Page to Update:
https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/

I tested this using these manifests and then tainting the node using kubectl taint nodes $nodename key1:NoExecute
/sig scheduling

I think the docs are accurate. SIG Scheduling can confirm.
We might want to explain specifically that taints, which represent involuntary disruptions, trigger eviction regardless of PDBs.
For example, if your network goes offline in a zone, all the Pods that don't tolerate the taint get evicted. You can't prevent the network error by specifying a PDB.

So what is the difference between "triggering an eviction regardless of PDB" and straight up deleting a pod? I think it would be good if we wouldn't use the term eviction for both of these situations.

Maybe we could reword https://kubernetes.io/docs/concepts/scheduling-eviction/#pod-disruption
I don't know whether the taint based eviction process uses the eviction subresource or a Pod delete. However, we (Kubernetes project) definitely call that Pod removal action an eviction.

Possibly https://kubernetes.io/docs/concepts/scheduling-eviction/api-eviction/ should clarify that a DELETE on a Pod is a non graceful eviction.
However, the DELETE at the API level doesn't mean that the Pod immediately stops running. We'll need to think about how we make that clear.

How about using "graceful eviction" for "Eviction subresource" and "non-graceful eviction" for "Pod object gets deleted directly"?

I don't actually know what control plane component (or maybe the kubelet) honors the NoExecute tainting and removes the running Pod. Would be good to clarify and document that.

/assign


Jesse: Watch carsremovals.com.au

Jesse requests the watch of the watch_keyword carsremovals\.com\.au. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

carsremovals\.com\.au has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Jeff Schaller in Charcoal HQ. Reason: 'duplicate of PR #9818 - https://github.com/Charcoal-SE/SmokeDetector/pull/9818'


Error "error creating conversation: timeout calling chat server"

Not sure if this is a client error, or a temporary infrasture unavailability.
Trying to start a chat session with another user.
Once the chat panel (on the Desktop client) or the complete chat page (on Android) appears, sending the first message goes into that error after about one minute timeout.
The user I am contacting is not followed by me, is not following me, and was found by its twitter handle. The chat session in both cases was started from the "Start a chat" button.
Could not get a screenshot in Android (it is not allowed by the app), and did not manage to have the error on the desktop reappear. In both clients the text entered dissappears once sent, and never gets into the chat transcript.
The Desktop client chat panel is left in a weird state: "New conversation" is kept highlighted, and can select other chats, One can keep sending messages, and nothing happens.
With the failing chat session selected:

Selecting another chat:

Desktop client info (stuff that looked line PII mangled with ...):
user@pablo-keybase:~/.cache/keybase$ keybase status
Username:      pdinoto
Logged in:     yes

Device:
    name:      ...
    ID:        e36...918
    status:    active

Session:       no session
    is valid:  yes
    keys:      unlocked

Key status:
    stream:    not cached
    secret:    stored
    dev sig:   cached
    dev enc:   cached
    paper sig: not cached
    paper enc: not cached
    prompt:    show
    tsec:      not cached

KBFS:
    status:    running
    version:   1.0.2-20171120211059+9eb24b3e
    log:       /home/user/.cache/keybase/keybase.kbfs.log

Service:
    status:    running
    version:   1.0.36-20171120211059+9c5671ec9
    log:       /home/user/.cache/keybase/keybase.service.log

Updater:
    log:       /home/user/.cache/keybase/keybase.updater.log

Platform Information:
    OS:        linux
    OS vers:   Linux 4.9.56-21.pvops.qubes.x86_64 x86_64-Debian GNU/Linux 9.2 (stretch)
    Runtime:   go1.9
    Arch:      amd64

Client:
    version:   1.0.36-20171120211059+9c5671ec9

Desktop app:
    status:    running
    version:   1.0.36-20171120211059+9c5671ec9
    log:       /home/user/.cache/keybase/Keybase.app.log

Config path:   /home/user/.config/keybase/config.json
Default user:  pdinoto
Other users:

command-line client:
    keybase status [pid: 1876, version: 1.0.36-20171120211059+9c5671ec9]

desktop:
    /opt/keybase/Keybase --type=renderer --no-sandbox --primordial-pipe-token=71B...09E --lang=en-US --app-path=/opt/keybase/resources/app --node-integration=true --webview-tag=true --no-sandbox --enable-pinch --num-raster-threads=1 --content-image-texture-target=0,0,3553;0,1,3553;0,2,3553;0,3,3553;0,4,3553;0,5,3553;0,6,3553;0,7,3553;0,8,3553;0,9,3553;0,10,3553;0,11,3553;0,12,3553;0,13,3553;0,14,3553;0,15,3553;1,0,3553;1,1,3553;1,2,3553;1,3,3553;1,4,3553;1,5,3553;1,6,3553;1,7,3553;1,8,3553;1,9,3553;1,10,3553;1,11,3553;1,12,3553;1,13,3553;1,14,3553;1,15,3553;2,0,3553;2,1,3553;2,2,3553;2,3,3553;2,4,3553;2,5,3553;2,6,3553;2,7,3553;2,8,3553;2,9,3553;2,10,3553;2,11,3553;2,12,3553;2,13,3553;2,14,3553;2,15,3553;3,0,3553;3,1,3553;3,2,3553;3,3,3553;3,4,3553;3,5,3553;3,6,3553;3,7,3553;3,8,3553;3,9,3553;3,10,3553;3,11,3553;3,12,3553;3,13,3553;3,14,3553;3,15,3553;4,0,3553;4,1,3553;4,2,3553;4,3,3553;4,4,3553;4,5,3553;4,6,3553;4,7,3553;4,8,3553;4,9,3553;4,10,3553;4,11,3553;4,12,3553;4,13,3553;4,14,3553;4,15,3553 --disable-accelerated-video-decode --service-request-channel-token=71B...09E --renderer-client-id=6 --shared-files=v8_natives_data:100,v8_snapshot_data:101 [pid: 1109, version: 1.0.36-20171120211059+9c5671ec9, description: Main Renderer]

KBFS:
    kbfsfuse -debug -log-to-file /keybase [pid: 1054, version: 1.0.2-20171120211059+9eb24b3e]

desktop helper:
    /opt/keybase/Keybase --type=renderer --no-sandbox --primordial-pipe-token=39B...D9B --lang=en-US --app-path=/opt/keybase/resources/app --node-integration=true --webview-tag=true --no-sandbox --enable-pinch --num-raster-threads=1 --content-image-texture-target=0,0,3553;0,1,3553;0,2,3553;0,3,3553;0,4,3553;0,5,3553;0,6,3553;0,7,3553;0,8,3553;0,9,3553;0,10,3553;0,11,3553;0,12,3553;0,13,3553;0,14,3553;0,15,3553;1,0,3553;1,1,3553;1,2,3553;1,3,3553;1,4,3553;1,5,3553;1,6,3553;1,7,3553;1,8,3553;1,9,3553;1,10,3553;1,11,3553;1,12,3553;1,13,3553;1,14,3553;1,15,3553;2,0,3553;2,1,3553;2,2,3553;2,3,3553;2,4,3553;2,5,3553;2,6,3553;2,7,3553;2,8,3553;2,9,3553;2,10,3553;2,11,3553;2,12,3553;2,13,3553;2,14,3553;2,15,3553;3,0,3553;3,1,3553;3,2,3553;3,3,3553;3,4,3553;3,5,3553;3,6,3553;3,7,3553;3,8,3553;3,9,3553;3,10,3553;3,11,3553;3,12,3553;3,13,3553;3,14,3553;3,15,3553;4,0,3553;4,1,3553;4,2,3553;4,3,3553;4,4,3553;4,5,3553;4,6,3553;4,7,3553;4,8,3553;4,9,3553;4,10,3553;4,11,3553;4,12,3553;4,13,3553;4,14,3553;4,15,3553 --disable-accelerated-video-decode --service-request-channel-token=39B...D9B --renderer-client-id=4 --shared-files=v8_natives_data:100,v8_snapshot_data:101 [pid: 1106, version: 1.0.36-20171120211059+9c5671ec9, description: Menubar]

Android version:
1.0.34-20171027214850+c5ade4b91
(handtyped, could not screenshot)

Did keybase log send with this issue as feedback.
Success! Your log ID is:
  39af9d4eac528d644043de1c

we had a small downtime this morning, can you try again?
sorry about that

Checked my connectivity and retried with no changes.
Rebooted the VM that hosts keybase client, started afresh and voilà: it worked.
Sorry for the noise.


Age Verification Video

I guys, i receive an error:

i find this error is related to "AGE VERIFICATION". Exist any way to bypass this or to add an option to "confirm" the AGE UP and to continue download?
I find this type of error, for example, in this :
https://www.youtube.com/watch?v=arONMWblvG8
Thanks for any suggestions.
Gimmy

Related: https://github.com/Tyrrrz/YoutubeExplode/issues/503

Thanks 👍


Old tokens are displayed when Refreshing in ConsoleClientWithBrowser sample

In the ConsoleClientWithBrowser sample, the method NextSteps allows the tokens to be refreshed (which works correctly), however the original tokens are written to the console instead of the new ones.
https://github.com/IdentityModel/IdentityModel.OidcClient2/blob/181a7f45e8d1ff890aa855d98f5f1e0230b8426f/clients/ConsoleClientWithBrowser/Program.cs#L109-L114
This should display the values of currentAccessToken and currentRefreshToken  instead.  I'd be happy to raise a pull request fixing this if you like?

yes please!


Bring "Team Editor" outside of "Team Settings" popup

Currently the character selector strip across the top is redundant. Since you can still swap to the different characters within the team via the Team Buffs tab like we've always done. So adding this new selector strip/tabs in the loadout feature without some additional function just adds clutter to the interface.
Why not allow people to add/remove/order characters via this selector strip?
This then keeps the "Team Settings" and "Loadout Settings" popups consistent with eachother - existing to just name/describle the contents.

Here is an idea for the proposed layout: (forgot to add a button to represent swapping/changing a team mate)

But perhaps use nicer UI elements like these within the character strip:

This also includes the loadout selection dropdown directly inside the Team Buffs tab above the associated character so you can see which "version" of that character you have selected - down to what conditional buffs they're providing and can quickly swap between them once you've realised you've got the wrong version of them.

Different approach to this would be folding the "team settings" and "team buffs" into 1 new "Team" tab. (leaving the top character selector strip as-is)

Removing the team buff stats allows for a 4th column to put all characters in this new "Team" tab, that now gives the ability to select/remove characters from each slot, and select their loadout. (the functions of the "team settings" popup)
Character lvl/talents/cons are not really relevent here so can be removed to tidy the interface.
Also if 4 characters are not present, can remove the placeholder(s) from the character selector strip.
The removed team buff stats would then be present on the optimize tab where they are more relevent.

And is also where the "bonus stats" appear anyway. So it makes it consistent.

In the above example could put the "Team Resonance" information to the top strip as this section now serves to indicate things that are at "Team Level" (enemy config for example)


Cannot find module '@create-nft-dao/shared' or its corresponding type declaration

Hi Guys,
Also getting a VS Code linting error from every file that uses @create-nft-dao/shared:
Cannot find module '@create-nft-dao/shared' or its corresponding type declaration
Most likely this is related with the prebuild error we noted in issue 24.  Yes?
Going down the rabbit hole, here are some questions and findings:

Looking at your package.json file it appears  that ts-node is a dependency.  Although a very bad practice, do you recommend we install it globally?

Here are excerpts of package.json after completing step 4

  "scripts": {
    "wizard": "yarn workspace @create-nft-dao/wizard dev -p 3000",
    "wizard:build": "yarn workspace @create-nft-dao/wizard build",
    "wizard:start": "yarn workspace @create-nft-dao/wizard start",
...
  "devDependencies": {
    "prettier": "^2.4.1",
    "prettier-plugin-solidity": "^1.0.0-beta.18",
    "//": "added ts-node here to overcome the bug with HH and yarn where hardhat throws HH13 when ts-node is only installed in the hardhat package.",
    "ts-node": "^10.4.0"
  },

yarn add ts-node typescript gives this warning:

 $
yarn add v1.22.17
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

@davidbrai thanks for suggestion.
Will try running again inside vscode'd PowerShell terminal as well as through Windows command prompt

Makes sense
I will close this one out


Parse gantt chart

https://mermaid-js.github.io/mermaid/#/gantt?id=syntax
Add support for mermaid's gantt format.

[ ] What datastructure to use?
[ ] Write parser
[ ] Tests

This is something I actually have an usecase for
   The book Deep Work talks about scheduling one's day ahead in terms of 'blocks', and I currently do this using mermaid-js in Emanote. It'd be great to write a CLI program that parses this diagram, so I can display the 'current' block in KDE desktop, as well send a reminder if that 'active' block reaches the end of its time (reminding me to adjust the gantt chart).

Celestia Airdrop - Claim Your Free TIA Tokens Now!

Don't Miss Out on Your Share of 60 Million $TIA Tokens!
Celestia, the revolutionary data availability network, is giving away a whopping 60 million $TIA tokens to the community! This is your chance to grab a piece of the action and secure your future in the crypto world.
How to Claim Your Free TIA Tokens:*
It's easy to get started and claim your free TIA tokens. Follow these simple steps:

Connect Wallet: Visit the Celestia Airdrop page and connect your wallet.
Claim: Click the Claim button to receive your tokens.
Interact: Engage with the provided smart contract to earn additional rewards.

Why Wait? Start Earning Today!
With Celestia, the sky's the limit. Don't let this opportunity slip through your fingers. Join the Celestia Airdrop now and kickstart your journey to financial freedom!gocassie, @cyberbhoi, @4rgon4ut, @baoanhvu96, @ngobao554982, @thuquynh344737, @peradise2021, @korometm99, @domnicaparis63, @agungkrishna-code, @Abhinav-vengala, @vivek-consensys, @maingockien01, @indus26, @yamamoto9288, @duong-fear, @miraist, @MrUstun, @zubairking786, @cherbert0123


uart_wait_tx_done hangs forever when used with portMAX_DELAY (IDFGH-3139)

Environment

Module or chip used:  ESP32-WROOM-32
IDF version: v3.2.3-264-g0c7abb897
Build System: Make
Compiler version: xtensa-esp32-elf-gcc.exe (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a5) 5.2.0
Operating System:     Windows
(Windows only) environment type: MSYS2 mingw32

Problem Description
After a few hours working, a call to uart_wait_tx_done(UART_NUM_2, portMAX_DELAY) never returns.
Expected Behavior
It should return once the tx has been completed.
Actual Behavior
The function call never returns.
Steps to reproduce
(Updated) This code triggers the issue, tested on v3.2.2-407-g0c7abb8978
#include <stdio.h>
#include <string.h>
#include <driver/uart.h>

#define UART (uart_port_t)UART_NUM_2

static void init_uart() {
  uart_config_t uart_config = {0};
  uart_config.baud_rate = 115200;
  uart_config.data_bits = UART_DATA_8_BITS;
  uart_config.parity    = UART_PARITY_DISABLE;
  uart_config.stop_bits = UART_STOP_BITS_1;
  uart_config.flow_ctrl = UART_HW_FLOWCTRL_DISABLE;
  uart_config.use_ref_tick = true; // Needed for power management

  ESP_ERROR_CHECK(uart_param_config(UART, &uart_config));
  ESP_ERROR_CHECK(uart_driver_install(UART, 2*1024, 0, 0, NULL, 0));
  ESP_ERROR_CHECK(uart_set_pin(UART, 27, 26, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE));
}

const char *TEST_MSG = "Hello World!";
volatile int64_t max_bussy = 0;
volatile int64_t bussy;
void test() {
  for (;;) {
    bussy = max_bussy;
    uart_write_bytes(UART, TEST_MSG, strlen(TEST_MSG));
    while (bussy--) {};
    uart_wait_tx_done(UART, portMAX_DELAY);
    printf("Max bussy %lld\n", max_bussy);
    max_bussy++;
  }
}

void app_main() {
  init_uart();
  test();
}

With my current configuration, it stops at about 4900 (With the CPU at 80Mhz it stops at about 2400).

I've added the IDF version where I saw the problem for the last time (v3.2.3-147-g287bee03b). I haven't seen any commit that may fix this.

After 40 hours I can confirm It has happened on the latest IDF version.

I think something like this solves the issue, but I'm not sure about the implications:
diff --git a/components/driver/uart.c b/components/driver/uart.c
index f5e76644d..5c0a678c0 100644
--- a/components/driver/uart.c
+++ b/components/driver/uart.c
@@ -1032,12 +1032,13 @@ esp_err_t uart_wait_tx_done(uart_port_t uart_num, TickType_t ticks_to_wait)
     }
     xSemaphoreTake(p_uart_obj[uart_num]->tx_done_sem, 0);
     typeof(UART0.status) status = UART[uart_num]->status;
+    uart_enable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
     //Wait txfifo_cnt = 0, and the transmitter state machine is in idle state.
     if(status.txfifo_cnt == 0 && status.st_utx_out == 0) {
         xSemaphoreGive(p_uart_obj[uart_num]->tx_mux);
+        uart_disable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
         return ESP_OK;
     }
-    uart_enable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);

     TickType_t ticks_end = xTaskGetTickCount();
     if (ticks_end - ticks_start > ticks_to_wait) {

I have written this code to work around the problem, and count the number of times the problem happens:
  esp_err_t r;
  do {
    r = uart_wait_tx_done(SIM800_UART, 1000 / portTICK_PERIOD_MS);
    if (r == ESP_ERR_TIMEOUT) tx_done_errors++;
  } while (r != ESP_OK);

tx_done_errors gets incremented over time (2 times in three days) and I never write more than 1KB so 1 second at 115200 bauds it is more than enough time to not reach a timeout.

Hi, @JosuGZ
Thank you for spending so much time to help debug this issue. Can you provide sample code to reproduce this problem?
thanks !!

It is hard since it is very random.
I think it could be reproduced by initializing UART 2  at 115200 (it will probably happen with other configurations though) and constantly writing nonstop; while at the same time having other tasks perform some random work.

Hi, @JosuGZ
I think the problem is caused by  vTaskDelay() in the uart_wait_tx_done function.
The vTaskDelay() is above of the uart_enable_intr_mask(), so the UART_TX_DONE_INT interrupt was disable and could not give the tx_done_sem while the program was runing delay function.
You can refer to the uart_rx_intr_handler_default ISR in the uart.c:
if(uart_intr_status & UART_TX_DONE_INT_ST_M) {
    uart_disable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
    uart_clear_intr_status(uart_num, UART_TX_DONE_INT_CLR_M);
    // If RS485 half duplex mode is enable then reset FIFO and
    // reset RTS pin to start receiver driver
    if (UART_IS_MODE_SET(uart_num, UART_MODE_RS485_HALF_DUPLEX)) {
        UART_ENTER_CRITICAL_ISR(&uart_spinlock[uart_num]);
        uart_reset_rx_fifo(uart_num); // Allows to avoid hardware issue with the RXFIFO reset
        uart_reg->conf0.sw_rts = 1;
        UART_EXIT_CRITICAL_ISR(&uart_spinlock[uart_num]);
    }
    xSemaphoreGiveFromISR(p_uart_obj[uart_num]->tx_done_sem, &HPTaskAwoken);
}

You can see that tx_done_sem will be gave in ISR and taken in uart_wait_tx_done() while the UART_TX_DONE_INT interrupt is enable.
If you put the vTaskDelay() behind the uart_enable_intr_mask(), the uart_wait_tx_done will return correct value.

Yes, the vTaskDelay is there to make the gap where the problem occurs longer, maximizing the chance that it happens.
The problem still occurs without it.
I'm not sure whether that brief period is, in fact, the cause though, as I think that the patch I provided didn't work.

Ok, I will try to reproduced the problem.

Hi, @JosuGZ
Sorry I have not reproduced your problem. I ran the uart_write constantly with UART2 at  115200 baud rate, but it still ran well.

I had the idea of having a loop writing to the UART and calling uart_wait_tx_done, like I guess you have done, but also with some tasks doing some work and randomly waiting, for example something like this, with a few tasks:
long long counter = 0;
while (true) {
  counter++;
  if (counter % (rand() % 1000)) {
    vTaskDelay((rand() % 1000) / portTickPeriodMS);
  }
}

The idea is to add some entropy to see if the problem arise. I might try it someday but I leave it here just in case you want to try.
It is probably hard to reproduce though.

There was a task that gets random number and prints the tx_done_error when I ran the loop of UART write:
static void random_task(void *param)
{
    while (1) {
        printf("I get random number: %2d, tx_done_errors: %2d\n", GET_RANDOM_NUM, tx_done_errors);
        vTaskDelay(1000 / portTICK_PERIOD_MS);
    }
}

But I will try your idea later.

Hi, @JosuGZ
I had run the uart_write with randomly delay task. But it still ran well. And the waveform of the UART GPIO was correct too.

Hi there,
I encountered into this issue too.
I use UART2 on 921600. On 115200 this issue doesn't occur for me.
Unfortunately, it occurs only on my real application, I can't reproduce it on simple demo.
In my application I found that it occurs 100% when app writes to the flash.
The behavior looks that:

my app gets a command from UART2
my app send an ACK response to UART2 (by another task)
my app writes to the flash

Steps 2 & 3 execute simultaneously, each on separate task.
Task from step 2 hangs forever in uart_wait_tx_done.

I've found a way of reliably triggering this by bussywaiting (on v3.2.2-407-g0c7abb8978):
#include <stdio.h>
#include <string.h>
#include <driver/uart.h>

#define UART (uart_port_t)UART_NUM_2

static void init_uart() {
  uart_config_t uart_config = {0};
  uart_config.baud_rate = 115200;
  uart_config.data_bits = UART_DATA_8_BITS;
  uart_config.parity    = UART_PARITY_DISABLE;
  uart_config.stop_bits = UART_STOP_BITS_1;
  uart_config.flow_ctrl = UART_HW_FLOWCTRL_DISABLE;
  uart_config.use_ref_tick = true; // Needed for power management

  ESP_ERROR_CHECK(uart_param_config(UART, &uart_config));
  ESP_ERROR_CHECK(uart_driver_install(UART, 2*1024, 0, 0, NULL, 0));
  ESP_ERROR_CHECK(uart_set_pin(UART, 27, 26, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE));
}

const char *TEST_MSG = "Hello World!";
volatile int64_t max_bussy = 0;
volatile int64_t bussy;
void test() {
  for (;;) {
    bussy = max_bussy;
    uart_write_bytes(UART, TEST_MSG, strlen(TEST_MSG));
    while (bussy--) {};
    uart_wait_tx_done(UART, portMAX_DELAY);
    printf("Max bussy %lld\n", max_bussy);
    max_bussy++;
  }
}

void app_main() {
  init_uart();
  test();
}

With my current configuration, it stops at about 4900 (With the CPU at 80Mhz it stops at about 2400).

I have updated the issue.

I've found a way of reliably triggering this by bussywaiting (on v3.2.2-407-g0c7abb8978):
#include <stdio.h>
#include <string.h>
#include <driver/uart.h>

#define UART (uart_port_t)UART_NUM_2

static void init_uart() {
  uart_config_t uart_config = {0};
  uart_config.baud_rate = 115200;
  uart_config.data_bits = UART_DATA_8_BITS;
  uart_config.parity    = UART_PARITY_DISABLE;
  uart_config.stop_bits = UART_STOP_BITS_1;
  uart_config.flow_ctrl = UART_HW_FLOWCTRL_DISABLE;
  uart_config.use_ref_tick = true; // Needed for power management

  ESP_ERROR_CHECK(uart_param_config(UART, &uart_config));
  ESP_ERROR_CHECK(uart_driver_install(UART, 2*1024, 0, 0, NULL, 0));
  ESP_ERROR_CHECK(uart_set_pin(UART, 27, 26, UART_PIN_NO_CHANGE, UART_PIN_NO_CHANGE));
}

const char *TEST_MSG = "Hello World!";
volatile int64_t max_bussy = 0;
volatile int64_t bussy;
void test() {
  for (;;) {
    bussy = max_bussy;
    uart_write_bytes(UART, TEST_MSG, strlen(TEST_MSG));
    while (bussy--) {};
    uart_wait_tx_done(UART, portMAX_DELAY);
    printf("Max bussy %lld\n", max_bussy);
    max_bussy++;
  }
}

void app_main() {
  init_uart();
  test();
}

With my current configuration, it stops at about 4900 (With the CPU at 80Mhz it stops at about 2400).

I have updated the issue.

This should shed a lot of light.
The image shows the time bussywaiting before calling tx_done, along with the bits of the interrupt that are set (I'm using an extern variable for this). In purple, we can see exactly when it fails: about 1021us. Then the function starts working again, but with no interrupt (tx_done sees the FIFO is empty so it just returns).
As I suspected, the problem happens exactly at the precise moment when the transmission ends so there is no interruption, but for some reason, the FIFO is not empty yet.
The interrupt handler seems complex and I'm not familiar with it so I doubt I will fix it although I might keep looking.

This should shed a lot of light.
The image shows the time bussywaiting before calling tx_done, along with the bits of the interrupt that are set (I'm using an extern variable for this). In purple, we can see exactly when it fails: about 1021us. Then the function starts working again, but with no interrupt (tx_done sees the FIFO is empty so it just returns).
As I suspected, the problem happens exactly at the precise moment when the transmission ends so there is no interruption, but for some reason, the FIFO is not empty yet.
The interrupt handler seems complex and I'm not familiar with it so I doubt I will fix it although I might keep looking.

I think something like this solves the issue, but I'm not sure about the implications:
diff --git a/components/driver/uart.c b/components/driver/uart.c
index f5e76644d..464509432 100644
--- a/components/driver/uart.c
+++ b/components/driver/uart.c
@@ -1032,12 +1032,13 @@ esp_err_t uart_wait_tx_done(uart_port_t uart_num, TickType_t ticks_to_wait)
     }
     xSemaphoreTake(p_uart_obj[uart_num]->tx_done_sem, 0);
     typeof(UART0.status) status = UART[uart_num]->status;
+    uart_enable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
     //Wait txfifo_cnt = 0, and the transmitter state machine is in idle state.
     if(status.txfifo_cnt == 0 && status.st_utx_out == 0) {
+        uart_disable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
         xSemaphoreGive(p_uart_obj[uart_num]->tx_mux);
         return ESP_OK;
     }
-    uart_enable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);

     TickType_t ticks_end = xTaskGetTickCount();
     if (ticks_end - ticks_start > ticks_to_wait) {

The problem with this original fix is this line before enabling the interrupt: typeof(UART0.status) status = UART[uart_num]->status;. It copies the struct, so enabling the interrupt should happen one line early.

I think something like this solves the issue, but I'm not sure about the implications:
diff --git a/components/driver/uart.c b/components/driver/uart.c
index f5e76644d..464509432 100644
--- a/components/driver/uart.c
+++ b/components/driver/uart.c
@@ -1032,12 +1032,13 @@ esp_err_t uart_wait_tx_done(uart_port_t uart_num, TickType_t ticks_to_wait)
     }
     xSemaphoreTake(p_uart_obj[uart_num]->tx_done_sem, 0);
     typeof(UART0.status) status = UART[uart_num]->status;
+    uart_enable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
     //Wait txfifo_cnt = 0, and the transmitter state machine is in idle state.
     if(status.txfifo_cnt == 0 && status.st_utx_out == 0) {
+        uart_disable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);
         xSemaphoreGive(p_uart_obj[uart_num]->tx_mux);
         return ESP_OK;
     }
-    uart_enable_intr_mask(uart_num, UART_TX_DONE_INT_ENA_M);

     TickType_t ticks_end = xTaskGetTickCount();
     if (ticks_end - ticks_start > ticks_to_wait) {

The problem with this original fix is this line before enabling the interrupt: typeof(UART0.status) status = UART[uart_num]->status;. It copies the struct, so enabling the interrupt should happen one line early.

Hi all,
We have a related commit may fix this issue: c801b3a18209ae707d3f8224b0734315cdc99db8.
Could you please have a try and see whether it fix your issue? I have looked into the code, and now all the disable/clearing logic are in the ISR, so that we can easily ensure every time we clear the interrupt, a semaphore will be sent.

The task only enable the interrupt when needed, and waiting for the semaphore. This way we reduce the complexity, and the risk of mis-clearing/disabling the interrupt.
@JosuGZ , @koobest , @Ethan-CYQ , @lexxvir

I can't test your commit right now but you have this app_main() test program to reproduce the issue.
The problem is not that the semaphore is not being sent, the problem happens due to returning before enabling the interrupt: I think that in line 1037 the UART is idle, but the interrupt can happen inside the if statement. That is why in my fix I enable the interrupt mask before checking if the uart is idle, and then I disable it before returning.

Sorry, my previous comment is wrong, what I want to point out is the following:
Lets have PC as program context, and IC as interrupt context.
PC (line 1037): uart_hal_is_tx_idle? -> No -> we dont return
IC: Interrupt happens here
PC: uart_hal_ena_intr_mask -> There won't be an interruption.

@JosuGZ

If the interrupt status is cleared, the semaphore must be sent
If the interrupt status hasn't been cleared, once the interrupt is enabled, the interrupt should trigger. It's not necessary for the interrupt to be enabled before the status is active.

btw, the is_tx_idle is kind of optimization for calling wait_tx_done several times without sending more data.

If the interrupt status hasn't been cleared

There is no interrupt if it is not enabled, which is true until line 1042 in your code. So if uart_hal_is_tx_idle returns false, there is a gap where the transmission can end and the interrupt won't be fired.
At least that is what caused the problem I fixed. That is why I enable the interrupt before checking uart_hal_is_tx_idle, and then I disable it again before returning if it is indeed idle,
As you can see here, when I bussywait less than 1020us before calling tx_done, the interrupt fires and returns. If I wait for more than 1021us, the uart is already idle so it returns. But there is a gap (the purple one) where the uart is not idle but the interrupt never fires so the function returns timeout (purple == timeout) (or never returns if timeout is portMAX_DELAY).

Hi @JosuGZ
Is this testing result based on the latest code, or the commit before https://github.com/espressif/esp-idf/commit/c801b3a18209ae707d3f8224b0734315cdc99db8?

Hello,
We've just tested our software with the latest master, as well as master from about a week ago from before the patch was committed. The issue appears to be fixed following the introduction of the patch. Thanks very much for this work!
-Alan

Ok, so I have tested c801b3a18209ae707d3f8224b0734315cdc99db8 and I can't reproduce it, so it seems that it has been fixed. The previous commit still triggers the issue.
I'm not sure whether this removes the problem or just makes the gap where the problem happens small enough, as now there is a critical zone immediately.

Thanks for your resopnd!
The issue was caused by the disabling of the interrupt under parallel execution. I think it fixes the root of the issue. If you are still able to reproduce the issue after the patch, please open it again.


Add phpunit and coverage to CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@42858ce). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #5   +/-   ##
========================================
  Coverage        ?   100.00%
  Complexity      ?         4
========================================
  Files           ?         4
  Lines           ?         9
  Branches        ?         0
========================================
  Hits            ?         9
  Misses          ?         0
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42858ce...4e2ddfc. Read the comment docs.


Removed refs management fix

#406 introduced issue with refs management 😢
when form model changes and some refs should be removed, it set value null to corresponding refs keys. Original react string refs removes ref key completely from registry in such cases.
It causes issues in some edge cases, like validation of such updated form (because struct uses hasOwnProperty to determine is ref available).
This PR restores original string refs behaviour with new callback refs.

Thanks @gbiryukov, released a patch

thanks @gcanti 🎉


grouping when subdomains are present

Hi there,
this is an awesome extension, which I have waited for since tab groups were released! As I really like the groups, but the creation kind of annoys me, I stumbled on this extension.
The tool works great in general, I just have a small issue, which admittedly could be related to usage.
How can I group based on a pattern like this? Do I need to use some sort of wildcards?
Pattern:
github.com
github.io
Expected grouping:
https://github.com/davidfrantz
https://davidfrantz.github.io/
Only the first one is being grouped.
Cheers,
David

Hey @davidfrantz, glad you like the extension.
Yes, you can use wildcards — more specifically, you can use match patterns.
There should be a linked info button when you focus the URL pattern field, like this:

But just when I checked this, I realized that the info button sometimes only showed in the URL pattern field of the first group — definitely something I should investigate. 🤔
Regarding your concrete case: *.github.com and *.github.io should be the patterns you want. They match all subdomains of github.com and github.io, as well as the domains themselves.

Thanks @loilo !


solitaire.gg logo on the main page

It's such a nice simple logo, maybe it should be present on the main page (https://solitaire.gg/) too.

This will be resolved with the new UI that I'm working on now.

Testable at https://beta.solitaire.gg

Yeah, this corner might be a good place for the logo. Mind you, that in the current form, "A" symbols on the smaller version of the logo are so minuscule, that it does not look too nice. Hmm... this problem might affect to some degree this small logo icon that appears in the browser's tab too. But the look of the logo in the app is much more important.

I've noticed something strange, these tiny "A" symbols look fine on my iPhone 7, but not in Firefox on my iMac...

New simple-as-possible logo on beta.solitaire.gg, thanks for the feedback!


ValueError: URI scheme 'neo4j' not supported

Neo4j Version: 4.1-enterprise
Neo4j Mode: Single instance
Driver version: Python driver 3.8
Lib version: ^4.0.2
from neo4j import GraphDatabase, Driver
from application import config

driver = GraphDatabase.driver("neo4j://neo4j:7687", auth=("neo4j", "changeme"))

Exception:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/neo4j/__init__.py", line 108, in driver
    return Driver(uri, **config)
  File "/usr/local/lib/python3.8/site-packages/neo4j/__init__.py", line 148, in __new__
    raise ValueError("URI scheme %r not supported" % parsed.scheme)
ValueError: URI scheme 'neo4j' not supported```

UPD: the problem was solved via downgrade to 4.0.1

@DrMartiner Hi, the parsing of the "neo4j://neo4j:7687" works fine. The 4.0.x driver throws ConfigurationError for unsupported uri scheme.
example using "xxneo4j://neo4j:7687"
raise ConfigurationError("URI scheme {!r} is not supported. Supported URI schemes are {}. Examples: bolt://host[:port] or neo4j://host[:port][?routing_context]".format(
neo4j.exceptions.ConfigurationError: URI scheme 'xxneo4j' is not supported. Supported URI schemes are ['bolt', 'bolt+ssc', 'bolt+s', 'neo4j', 'neo4j+ssc', 'neo4j+s']. Examples: bolt://host[:port] or neo4j://host[:port][?routing_context]

Next time check your version that you are using with:
python -m pip freeze

thanks


Handle postgres disconnect

When the connection to postgres is interrupted, cow will die with:
events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: connection pointer is NULL

    at Connection.<anonymous> (/var/data/sites/cow/node_modules/pg/lib/native/index.js:184:17)

COW should start polling the connection and retry.
After X retries cow should continue running but give a warning in the form of a status update in the peer object.

Moved issue to superpeer: https://github.com/Geodan/cow.superpeer/issues/8


Implement other commands for dynamodb

Currently only sls dynamodb launch is only implemented. Implement the following commands

stop
relaunch
Note: the basic logic for these functions are already implemented in dynamodb/db.js. The need is to create custom actions in root/index.js and call the relevant functions

Completed :white_check_mark:

Hi there,
I'm on 0.2.36 and stop command is not supported. Which version does this command is supposed to be supported?
Thanks for your effort on this plugin.


Usermin - displaced pop-out window for links/emails

What is your server-side OS and its version?
VPS, Centos 7.2
What is your client-side OS, browser and its versions?
Win7Pro, Firefox
What are the steps to reproduce the issue
Every time when i want to compose email as HTML and use "Link" option, the pop-out window will be placed on the upper part of the browser window.

Before i use "Link" option

Once i highlight the text and press "Link". You can see the position of pop-out window and how bumped entire page up.

This i just discovered when using right-click on highlighted text (cut/copy/paste). Same as with 2. the browser window bounced up.

When you have many things to link, copy or paste it start to be annoying as every time you must scroll up, set everything and then back down to the main text.
Extra: I think the option to link is used in same frequency or even more than cut/copy/paste and it could be integrated with right click on highlighted text.

Hi,
We should all get hottest mail possible on next either 18.40 or 19.00 release.
I will rework mail from scratch.
I will not look in to this issue right now, sorry pal.

Speaking from time perspective are we talking here about few weeks or months?

Months, but my plan to star working on it in January. It depends on how it goes. If I work on the project I just do it. The whole day. It might be by the end of the January or February.


fix: (model) replace @Lob annotation on VariableValue attribute with TEXT column definition

This PR proposes to fix #105 by removing @Lob annotation on VariableValue attribute and augmenting its @Column annotation with TEXT column definition in order to store JSON strings of any length for serialized variable values.
This change will break the compatibility for any existing database schema used to be generated previously with @Lob annotation.
Although the type text is not in the SQL standard, several other SQL database management systems have it as well: https://www.postgresql.org/docs/current/static/datatype-character.html
See for details some performance tests: https://www.depesz.com/2010/03/02/charx-vs-varcharx-vs-varchar-vs-text/

@igdianov I am ok with this change.. why did you close it?

@Salaboy The branch was created from Beta2 tag. I have opened another one #111 from latest develop head.


Launch Issue

Unable to launch Ethiopian Television from add-ons on Kodi 17.1.  Gives error and informs to check log for info

What version are you running? Pre 2.0 versions do not support 17.1 and end up crashing.

kodi-ethiopian-tv/dist/Krypton and Newer/

Can u provide me with your contact info, I don't want to end up in ppls emails and google search

Sure.  Search is how I found you though.  Your comment is confusing<EMAIL_ADDRESS>


check selectionKey.isValid before checking selectionKey.isWriteable

Currently receiving this exception, It looks like occasionally selectionKey gets closed during the handleReads, and it then throws a java.nio.channels.CancelledKeyException error. (not sure why it doesn't get caught by run)
java.nio.channels.CancelledKeyException
    at sun.nio.ch.SelectionKeyImpl.ensureValid(SelectionKeyImpl.java:73)
    at sun.nio.ch.SelectionKeyImpl.readyOps(SelectionKeyImpl.java:87)
    at java.nio.channels.SelectionKey.isWritable(SelectionKey.java:312)
    at net.spy.memcached.MemcachedConnection.handleReadsAndWrites(MemcachedConnection.java:722)
    at net.spy.memcached.MemcachedConnection.handleIO(MemcachedConnection.java:683)
    at net.spy.memcached.MemcachedConnection.handleIO(MemcachedConnection.java:436)
    at net.spy.memcached.MemcachedConnection.run(MemcachedConnection.java:1445)

We ran into this bug as well, and have verified that this patch fixes it in our environment.
The code used to do this, but 7d45580
reviewed by @ingenthr
changed that in a refactor so that isValid() is no longer called
again after isReadable(). http://stackoverflow.com/a/36878410/14558  is a common hit
when searching for the exception name.
@daschl, can you take a look?

@andrewdotn hm, somehow I missed that PR. looks good to me in general, but we need to get this into gerrit
@ggrochow would you mind going through our CLA process and submitting it to our review system? If not I can do it under my name or if you just sign the CLA I can get it through on your behalf.

@daschl I believe I did got it into gerrit, and signed the CLA (never actually used gerrit before, so If I screwed up somewhere feel free to just move this along)
http://review.couchbase.org/#/c/72269/

Hello, I think this got stalled again.
@ggrochow, are you able to update the commit message structure as requested on Gerrit? Do you want @daschl to take care of it for you if he’s still willing?
Please let me know if there’s anything I can do to help get this released.

@ggrochow if you don't mind, I'm happy to drag it over the finish line for you and cut a new release after it

@daschl you finishing it up might be best, not really familiar with gerrit / your practices on it.

@ggrochow sounds good, thanks much for your contribution so far. I'll just amend your change, push it through and cut a release soon.
Thanks!

closed via 2b6e3bbc823aa68d7aa5b7f3bb8ece1b2c284d0e

2.12.2 is released with the change and pending sync to maven central. Can you please close this PR? thanks!

Yep, thanks for finishing this up.


user update authentication

don't verify token corresponding with the given user mail and password, need to change it to password checking with token, then with db

no need in user prespective


Fix: Added "-nk" suffix to 'data' and 'library'

The database names in https://github.com/polyanskiy/refractiveindex.info-database were changed to have the "-nk" suffix. I have correspondingly updated the names in the Python file. This is necessary for the code to work.

Thanks! The only thing, it is now not library-nk but catalog-nk. Should be working when I upload to the PyPi


Implement ProxyProtocol V2

AWS NetworkLoadBalancers use ProxyProtocol V2 which is needed to preserve the original IP address of the game server.
The protocol adds 100 bytes of data to the start of the data received by the master server. The current implementation achieves the bare minimum to get things working.
This issue is a reminder that a full implementation should be done for thoroughness, portability, and to avoid unintended consequences.
Original issue that spawned this:
https://github.com/quakeservices/master/issues/1#issue-545372004
The proxy protocol specification document:
https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
StackOverflow comment that does a very good job of implementing PPV2 in Python:
https://stackoverflow.com/a/53198793
Out of scope:
Version 1 of the proxy protocol

Using proxy-protocol library instead.


chore(package): update kronos-service to version 4.12.0

Coverage remained the same at 69.388% when pulling f99a5ff776177e4933db752a2cd77b15875c5f93 on greenkeeper/kronos-service-4.12.0 into a328eda142aadf71ffdfe15b3a6df7beffa35f04 on master.

Codecov Report

Merging #142 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   69.79%   69.79%
=======================================
  Files           2        2
  Lines          96       96
=======================================
  Hits           67       67
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a328eda...f99a5ff. Read the comment docs.


fix: use factories to ensure services are provided globally

Too many internal NG-related changes in this PR, would be worth to get someone else with more recent angular experience to take a look but LGTM

No worries, as long as there isn't anything obviously wonky with the code ... This is basically just adding back code that was live in v3


Security considerations

What were the security considerations kept in mind while creating this app? Does it access the internet and possibly leak codes to attackers?

The only access to the network it has is at launch it checks for an updated list of known sender formats from this github. You're more than welcome to review the code yourself though!

Gotcha! Thanks :)
Can you also point me to the file with the network access, please?


Make non-contract methods on UpdateSqlGenerator protected

These methods were public on the abstract class even though they do not exist on the IUpdateSqlGenerator contract interface, through which all public access should go. I decided to make them protected to provide full flexibility for provider-specific derivations of the abstract class.

:shipit:

Merged


Remote Desktop client on macOS 10.2.4

There are no feature updates in this doc for 10.2.4
Shouldn't this be posted BEFORE the update is released?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dca80301-5517-3479-c79f-96c7e5e3f4eb
Version Independent ID: f6c2df89-25dc-2d34-ef78-36cbadb4031b
Content: What's new for Remote Desktop on Mac?
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/mac-whatsnew.md
Product: windows-server-threshold
GitHub Login: @lizap
Microsoft Alias: elizapo

David pushed an update today, so I'm going to close this issue. Thank you!


sqlcmd, Named instances with dynamic ports: Can not connect to MS SQL from Debian Error code 0x2AF9

Problem description
Connection from Windows works but not from Linux:
sqlcmd -S x.x.100.102\TESTINST -U sa -P 'mypassword'
Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : Login timeout expired.
Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : TCP Provider: Error code 0x2AF9.
Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : A network-related or instance-specific error has occurred while establishing a connection to SQL Server. Server is not found or not accessible. er is configured to allow remote connections. For more information see SQL Server Books Online..

I saw any call with double back slash, but this gives me other error
sqlcmd -S x.x.100.102\\TESTINST -U sa -P 'mypassword'
Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : TCP Provider: Error code 0x2746.
Sqlcmd: Error: Microsoft ODBC Driver 17 for SQL Server : Client unable to establish connection.

As described here,  The latest release of the ODBC driver (V 17.4) should fix any issues with named instances and dynamic port on Linux
SQL Server version
Microsoft SQL Server 2014 (SP1-CU13) (KB4019099) - 12.0.4522.0 (X64)
Jun 28 2017 17:36:31
Copyright (c) Microsoft Corporation
Standard Edition (64-bit) on Windows NT 6.3  (Build 9600: ) (Hypervisor)
Client operating system
Debian GNU/Linux 10 (buster)
Microsoft ODBC Driver version
$ cat /etc/odbcinst.ini
[ODBC Driver 17 for SQL Server]
Description=Microsoft ODBC Driver 17 for SQL Server
Driver=/opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.8.so.1.1
UsageCount=1
###Setup
As Instruction here.

Backslash needs to be escaped or the shell will interpret it, so either double it or enclose the server name in single quotes.
0x2746 = 10054 "connection reset by peer", check that firewall is not preventing the connection.
Also, are you using PHP driver at all? I don't see any mention of that here.

Thank you for response.
I installed php as descried here
I don't have any firewall rules on Linux.also not on windows server. Access from windows client works.

Thank you. This helped me. Because of old version of sql server, I had to downgrade to MinProtocol = TLSv1 on linux and we use fix port now.


WIP: talian translation: Chapter 3

Italian translation of chapter 3, as per #45

@lewtun I am getting some issues with building the docs that I can't figure out. Can you help me out with this "Unexpected token" error?
Thank you!

Thank you @lewtun! It's been a lot of fun to translate chapter 3 :)

Thank you for the great review @EdAbati !
@lewtun I've marked the PR as WIP in the hope that it won't be merged, please give me a couple of days to implement @EdAbati suggestions. I'll ping you when it's ready again.
Thank you again!

@lewtun I've marked the PR as WIP in the hope that it won't be merged, please give me a couple of days to implement @EdAbati suggestions. I'll ping you when it's ready again.

Sure! Maybe ping @lvwerra when you're as I'll be on vacation for the next couple of weeks :)

Hey @sharkovsky - I'm back from vacation, so happy to review this again whenever you're ready :)

Thank you @lewtun ! Please give me a couple more weeks as I'm currently on vacation , and unfortunately I haven't had a chance to implement @EdAbati 's suggestions !

Thank you @lewtun ! Please give me a couple more weeks as I'm currently on vacation , and unfortunately I haven't had a chance to implement @EdAbati 's suggestions !

No rush - enjoy your vacation 🤗

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @lewtun, I have implemented @EdAbati 's suggestions. (By the way, I had not realized what an epic re-reading effort you had made. Kudos for your attention to detail and thank you so much!)
On my end everything would be ready, but I see I'm failing an automatic check (not sure why). Maybe you could help me sort this out?
Thanks!

On my end everything would be ready, but I see I'm failing an automatic check (not sure why). Maybe you could help me sort this out?

Awesome work with integrating all the suggestions @sharkovsky ! I just ran make style to fix some code formatting and this should be good to merge once the CI is green
Thank you again!

@lewtun sorry to bother you, I noticed my name is missing from italian translators in the front-page README.md .... Is this intended?
Thank you!


fix: gracefully fail charts if columns have changed

Description
fix ZEN-414
This disentangles the fetching of chart data from the chart. The reason behind this is that fetching chart data has some failure cases (e.g. a column for a slice filter does not exist anymore) that should not break charts altogether. It should still be possible to change the chart spec. Furthermore, this adds an error message if the chart data could not be loaded.

Our openapi codegen creates the function for fetching the data twice for some reason and I don't really understand why.

yeah odd it did for me too


Support non NUMA enabled systems

I'm still disastrous in bash so I'm pretty sure implementation is flawed, but that's how you learn right?
The mongodb image is not usable on non-NUMA systems such as boot2docker, or only using --entrypoint=mongod in order to bypass the numactl wrapping. This patch tests for NUMA availability using numactl --show success.

I can't believe the only other opened PR fixes the exact same thing.

Lol, nice work @icecrime :+1:

:disappointed:


Add basic SARIF support

Description
This addresses #1102. SARIF website: https://sarifweb.azurewebsites.net/

This makes ktlint to depend on https://github.com/detekt/sarif4k, which uses kotlinx-serialization to generate the JSON. Schema makes the code safer and less error-prone. If we want to avoid additional dependency, I could change the code to yield JSON using basic string formatting and concatenation.
The level in SARIF report is currently set to ERROR. I believe this fits with the ktlint's strategy of no configuration.

Checklist

[X] tests are added
[X] CHANGELOG.md is updated

Follow-up

[ ] SarifSchema210.runs[0].tool.driver.rules is empty for now. Ideally, this should be a list of rules that were active in the current run. I will address this in a follow-up PR since this requires refactoring.
[ ] I have not yet added other information like autoCorrected or autoCorrectible in the output.
[ ] Potentially we can also add github workflow setup in the documentation. There are other community projects that does this so this is optional to me.

Test

I ran klint --reporter=sarif on the ktlint itself. I also validated the output on https://sarifweb.azurewebsites.net/Validation to make sure that there is no basic warnings.

@chao2zhang apologies for the delay and thanks for the contribution. the CI build is now fixed so if you rebase I can go ahead and merge your change.

Updated the PR, it looks like the PR is pending approval to kick off github actions


What if re-training on pseudo-labeled target images only?

Hi,
After pseudo-labels of unlabeled target images are generated, you re-train the baseline source model jointly on the combined set of source and target images. However, the source images might not always be available. Did you try re-training on pseudo-labeled target images only? What is the expected performance?

@xiaoyong that's an interesting aspect. However, we did not do this -- we assumed batches of perfect-labeled source and pseudo-labeled target data are available at training time. Because the pseudo-labeled target images will have some mistakes/label-noise, we expect some loss in performance if we don't use batches of perfectly-labeled source data during training.
To deal with the situation when source images are not available, there is a cool and very straightforward technique from Derek Hoiem's group called "Learning without forgetting", which you might have a look at: http://zli115.web.engr.illinois.edu/learning-without-forgetting/

I see. Thanks for your info.


Containerized Eval API

Added a containerized eval API using Flask.

Thanks

My pleasure! Will this be merged?


Staging

Includes:

GPU Base Miner 🚀
Hotfix for edge cases in gro_hash
GPU Logging
Ensures that validators call load_state() when they restart so they don't look all of their historical data before setting weights

Logging for RMSD
Short production run on validator side to investigate returned simulations
Check to see if simulations are genuine
Reformatted where energies and rmsd is calculated


Forms: Merge feature-branches/forms into v.next

Related to issue: #kotlin/4238

Description:
Merges feature-branches/forms into v.next
Summary of changes:

Refactored the tests to use a common FeatureFormTestRunner that is responsible for loading a FeatureForm from the given map and feature.
Added tests for AttachmentsFormElement.
Zero sized attachments are blocked from being added and a toast is shown when a user tries to download a zero sized attachment (which will fail).
Updates strings and plurals in strings.xml.
Fixed an issue where a FieldType.Int16 wasn't being cast into a Short type for a RangeDomain.minValue & RangeDomain.maxValue

Pre-merge Checklist

a vTest Job for this PR has been run

[x] link: https://runtime-kotlin.esri.com/view/all/job/vtest/job/toolkit/35/

Unit and/or integration tests have been added to exercise this PR's logic, and the tests are passing:

[x] Yes
[ ] No

thanks @sorenoid @eri9000


Accessing Config values using Python

Hi,
I am trying to access values in my FSM controller's config file using Python, but I am having some issues.
I currently have a mc_control.MCGlobalController object instance called 'mc_gc'. I am trying to access the value associated with the key "TaskCompleted", and I am currently doing this by mc_gc.controller().config()("TaskCompleted"). However, this returns a 'mc_rtc.mc_rtc.Configuration object' and not the value.
I have confirmed that I can access this value from the configuration file using c++ by using ctl.config()("TaskCompleted"), where ctl is a mc_control::fsm::Controller object.
Is there a seperate API documentation that I should follow for Python implementations? I am currently just referencing https://jrl-umi3218.github.io/mc_rtc/doxygen.html.
Thank you in advance for your help.

Hi @jlee1218
The difference between the C++ API and the Python API is explained here
In C++, we rely on implicit conversion to go from mc_rtc::Configuration objects to other types but this is not possible with the Python API so you have to either explicitly provide the type or provide a default value (the desired type is then deduced from the type of the default) so the following would work in your case:
# For readability
cfg = mc_gc.controller().config()
# Throws a RuntimeError if "TaskCompleted" is not in the configuration or if it cannot convert to a bool
value = cfg("TaskCompleted", bool)
assert type(value) == bool
# Only throws if "TaskCompleted" is not in the configuration, if the conversion fails, value will be False
value = cfg("TaskCompleted", False)
assert type(value) == bool


Does this work on the Shopify Starter plan?

Originally posted by cvoadmin March 21, 2023
https://shopify.com/starter

Looking at the landing page + docs, it is not clear if the starter plan supports using Shopify headless.

No, it doesn't. Tried today, when you try to add the Headless App it tells you that you need Basic or higher


⚠ GitLab Server has degraded performance

In e974c45, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11602 ms

Resolved: GitLab Server performance has improved in 36a8707.


Add vcan support for socket_can_client_raw

Adding an option for 'vcan' (virtual socket can) would be very beneficial for running the system in our simulation. We currently use this and would be a great public feature.
The update would only require changing "can" to "vcan" on line 100 shown in figure below.

This could either be set during the build or an additional socket client for virtual busses could be added to the component for this.

@james-goin My understanding is that you would also need to setup/bring up vcan as well right? Anything else you thing of that might needs a change?

Correct.
Example:

@james-goin This is a valid suggestion that can help improve the simulation with canbus module in loop! Through we did not do it this way.  -- Could you help create a PR for this one? You can add another conf in https://github.com/ApolloAuto/apollo/blob/bb72a22bd1fc461c960713cec3c3cdc370b4c53a/modules/drivers/canbus/proto/can_card_parameter.proto#L27 and use it to select between paring in "can" or "vcan" depending on the conf. The new conf can be either string type or boolean type but I would prefer boolean type with name "enable_virtual_can".
I will see what is the best way to setup/bringup vcan in scripts.
Or if you think there is a better way or alternative suggestion, please also post it here.

@Capri2014 It appears rx filters are not supported by virtual CAN.
https://github.com/ApolloAuto/apollo/blob/d547687f8d1e6b37c97421923aa6f507dd6b9e1c/modules/drivers/canbus/can_client/socket/socket_can_client_raw.cc#L76-L89
I am currently not setting this flag when using virtual CAN bus and the system is operating correctly with our simulator / tests. Is there any reason this is needed for vcan (or socket CAN in general)? It doesn't appear to be actually filtering anything.
If not would you prefer it was removed or just not set during virtual CAN?

@Capri2014 Any updates on adding an automated way to bring up / set up vcan? Not sure if this can be added to the docker or done with a flag somewhere?


Update build_rom.sh

you have write access, use pinned post method of push group
dont do git clone, use local manifest for this,


[Enhancement] Allow filtering by talks I have not rated

Current Behavior
On the talks page (/admin/talks), one can filter by "Rated" and "Unrated" talks, but it appears to check whether anyone has ever rated a talk. There is no way to filter by talks that I have rated/not rated.
Suggested Enhancement
Either:
a. Add a filter for "Unrated By Me"
b. Change the current "Rated"/"Unrated" filters to only look for ratings by the currently logged in user, since that is a vastly more useful use case. I'm having a hard time picturing why you'd want to see if anyone had rated/not rated a talk.

I consider this a bug - it's the query that's wrong imo see: https://github.com/opencfp/opencfp/pull/429

@chartjes I think this can be closed with @mwillbanks merge request of #429 .


Improve Usability and UI in Maker v6.1 - Focus on Sidebar, MidJourney Explore, Session Persistence, and Language Selection 改进Maker v6.1的可用性和UI - 侧边栏、MidJourney Explore、会话持久性和语言选择

默认版本：目前，Maker默认选择的是6.1版本。若用户可以选择自己偏好的版本并在会话中记住该选择，将极大提升用户体验。
UI改进：左侧面板（侧边栏）可以更具视觉吸引力且更便于使用。增强其布局和设计将有助于用户更高效地浏览。
MidJourney Explore功能：如果可能，添加MidJourney Explore功能，使用户可以直接从应用内浏览midjourney.com上的所有公开图片。
会话持久性：登录用户在5-10分钟不活跃后会被注销，需要重新登录。若增强会话持久性将极大改善用户体验。此外，意外重置和删除cookies也会中断工作流程，修复这些问题会使体验更佳。
语言选择：可以优化英语语言的选择体验，使其更直观，更便于英语用户使用。
Default Version: Currently, Maker version 6.1 is always selected by default. It would enhance usability if users could select their preferred version, and have the app remember this choice across sessions.
UI Improvements: The left panel (sidebar) could be more visually appealing and user-friendly. Enhancing its layout and design would help users navigate more efficiently.
MidJourney Explore Feature: If feasible, adding an Explore feature for MidJourney would allow users to browse all public images on midjourney.com directly from the app.
Session Persistence: Logged-in users are logged out after 5-10 minutes of inactivity, which requires re-login. Enhancing session persistence would greatly improve the user experience. Also, resetting and deleting cookies unexpectedly disrupts workflow—addressing this would be beneficial.
Language Selection: The English language selection experience could be streamlined and made more intuitive, making the app more accessible to English-speaking users.

Default Version:  You mean MidJourney version?
UI Improvements: Do you have any reference? Otherwise, I don't know how to improve it.
MidJourney Explore Feature: good idea
Session Persistence: It may be related to the browser, I have no restrictions. please retry
Language Selection: The next version will resolve this issue

Session Persistence & Login Timeouts: I’m still experiencing session timeouts after around 5 minutes of inactivity, which requires frequent logouts and re-logins. Reducing the frequency of these timeouts would make the app much smoother to use. Additionally, any solutions to prevent unexpected logouts from cookie resets or timeouts would be appreciated.
Wait Times for Image Prompts: The waiting time between image prompts is currently quite long, which interrupts workflow. If possible, reducing or disabling this delay would significantly improve the experience for users who rely on rapid image generation.
Language Selection, UI Improvements, and Default Version: Thank you for the updates on these areas! Excited to see the improved English language selection experience in the next version, as well as any UI refinements for the sidebar.
MidJourney Explore Feature: Happy to know this is under consideration—an Explore feature would be a fantastic addition!

Session Persistence:  Our authentication is not through cookies, but by storing the key in localStorage.

Session Persistence: While it may partly depend on browser settings, implementing a longer session duration within the app itself could be beneficial. Users being logged out due to brief inactivity disrupts the workflow, so a more robust approach might help. Also, ensuring that unexpected cookie resets or deletions don't impact session persistence would further improve the experience.
UI Improvements: If there are no specific references for the sidebar, I’d suggest a cleaner, more spacious layout that organizes options in a way that’s visually easier to navigate. Perhaps increasing the contrast or adding icons might make it more user-friendly.
MidJourney Explore Feature: Glad you like the idea! This feature could attract more users interested in browsing public MidJourney images within the app.

kidnl just imrpove the Ui and add full english support


[SPARK-19882][SQL] Pivot with null as a distinct pivot value throws NPE

What changes were proposed in this pull request?
Allows null values of the pivot column to be included in the pivot values list without throwing NPE
Note this PR was made as an alternative to #17224 but preserves the two phase aggregate operation that is needed for good performance.
How was this patch tested?
Additional unit test

Test build #74274 has started for PR 17226 at commit 18b74a7.

Test build #74274 has finished for PR 17226 at commit 18b74a7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74274/
Test PASSed.

Test build #74295 has started for PR 17226 at commit a81c062.

@aray, I will close mine as soon as I check https://github.com/apache/spark/pull/17226#discussion_r105322903 can be resolved because that was the point I did not fix the optimized path.

@HyukjinKwon As stated in 17226#discussion_r105322758 I think we should open a second JIRA to have the discussion on whether or not count(1) of no values in a pivot should be filled with 0's.

@aray, this is a regression as I described in my PR that is introduced by this optimization.
Spark 1.6.
+----+----+---+
|   a|null|  1|
+----+----+---+
|null|   0|  0|
|   1|   0|  1|
+----+----+---+

For input/output, this PR does not fully resolve this regression. That's why I proposed to avoid this in the optimization path.
We could leave another JIRA open to support this case in optimization path. It is little bit funny that the output is different by the internal optimization.

There are three things going on here in your one example.

Spark 1.6 [first version with pivot] (and Spark 2.0+ with an aggregate output type unsupported by PivotFirst) gives incorrect answers to when one of the pivot column values is null (only affects the 'null' column) this is fixed by doing a null safe equals in the injected if statement https://github.com/apache/spark/pull/17226/files#diff-57b3d87be744b7d79a9beacf8e5e5eb2R525

Spark 2.0+ with PivotFirst gives a NPE when one of the pivot column values is null. The main thing fixed in this PR.

There is inconsistency between Spark 1.6 and 2.0+ on the result of a pivot with a count(1) aggregate when no values are aggregated for a cell. This is separate from the issues above and it's not clear which version is naturally correct (pandas leaves those values as null, Oracle 11g gives 0, and I need to test others).

BTW for 3 above if we decide it should be 0, we can add an initial value for PivotFirst to make the fix.

Spark 2.0+ with PivotFirst gives a NPE when one of the pivot column values is null. The main thing fixed in this PR.

I meant to say it is not fully fixed because it does not NPE but now introduce a regression.
Why don't we fix NPE and resolve the regression first and then put the optimization for it?
I think we have two options.

Deal with this case in both optimization path and non-optimization path which introduces a regression/inconsistency between them that should be a separate JIRA. - in this case, let me close mine.

Fall back to non-optimization path and leave a JIRA to put this in optimized path - in this case, I think this PR should be closed.

cc @cloud-fan and @yhuai could you pick up one of them? Let me follow.

@HyukjinKwon we're not introducing a regression in this PR by fixing the NPE, the answer given by 1.6 was incorrect under any interpenetration. Again, there is a completely separate issue of what the proper value of count(1) on no values should be in a pivot that does not depend at all on nulls in the pivot column.

we're not introducing a regression in this PR by fixing the NPE, the answer given by 1.6 was incorrect under any interpenetration

Right, if it was a bug, then this PR introduces an inconsistency between optimized one and non-optimized one. We should fix both together or not.

there is a completely separate issue of what the proper value of count(1) on no values should be in a pivot that does not depend at all on nulls in the pivot column.

Then why are we partially fixing a completely separate issue here?

Test build #74295 has finished for PR 17226 at commit a81c062.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74295/
Test PASSed.

@HyukjinKwon There is an inconsistency/regression but its not being introduced in this PR, its already there. Take an example without null as a pivot column value like below. The only difference is for the count(1) aggregate on cells with no values aggregated in the pivot table. Again I don't think it's clear which is "correct" here.
Spark 2.1.0 (and presumably 2.0.x/master)
scala> Seq(1,2).toDF("a").groupBy("a").pivot("a").count().show
+---+----+----+
|  a|   1|   2|
+---+----+----+
|  1|   1|null|
|  2|null|   1|
+---+----+----+
scala> Seq(1,2).toDF("a").groupBy("a").pivot("a").sum("a").show
+---+----+----+
|  a|   1|   2|
+---+----+----+
|  1|   1|null|
|  2|null|   2|
+---+----+----+

Spark 1.6.0
scala> sc.parallelize(Seq(1,2)).toDF("a").groupBy("a").pivot("a").count().show
+---+---+---+
|  a|  1|  2|
+---+---+---+
|  1|  1|  0|
|  2|  0|  1|
+---+---+---+
scala> sc.parallelize(Seq(1,2)).toDF("a").groupBy("a").pivot("a").sum("a").show
+---+----+----+
|  a|   1|   2|
+---+----+----+
|  1|   1|null|
|  2|null|   2|
+---+----+----+

I see. So, count in "Spark 2.1.0 (and presumably 2.0.x/master)" was unexpectedly introduced by the optimization in SPARK-13749 and this behaviour change between 1.6 and master (whether it is right or not) is found now together.
So.. if I understood correctly, several problems are mixed and found here:

counting null problem (for both optimized and non-optimized)

NPE (for optimized)

0 vs null for missing values in count

and this PR tries to fix both 1. and 2.
whereas mine tries to fix 1. and both 2. and few specific cases in 3. (by avoiding optimization as an workaround).
Okay, I am fine with closing mine (honestly, the initial version in my PR was almost identical with this PR..).
Thanks for elaborating it and bearing with me.

For me, LGTM

LGTM, merging to master!


Added default text in Spanish and French

I translated every string in the CookieConsentOptions file to Spanish and French.

LGTM


pubsub - Fix flaky OpenCensusUtilTest.testOpenCensusMessageReceiver()

(cherry picked from commit 8255a9b475c599814d42a6a28eef3d8e11f6b082)
Fixes the OpenCensusUtilTest.testOpenCensusMessageReceiver() test case that (sometimes) fails on Java 8 Windows builds.

CC @dinooliva


Disable a block of variables

Is there any way to disable a block of variables as such:
var (
   ErrorA = errors.New("this error happens on...")
   ErrorB = errors.New("this errors happens on ...")
...
)

technically you can disable them them by appending //nolint at the end of each line but ideally you might want to have the ability to disable the whole block

Same request from me, having ability to switch off linter on block of code will be very useful, as there are such cases as hardware points, symbol tables or simply database columns, and adding comment to each line is some way time burning routine.


Fix compilation issue on ObservableToMessageChannelResultAdapter

This resolves #756

Here is the travis build failure on master: https://travis-ci.org/spring-cloud/spring-cloud-stream/builds/189346497

Travis error happens with jdk1.8.0_31, but compiles fine with jdk1.8.0_45 or jdk1.8.0_111. I tried all combinations so I think PR looks ok.

as a note, afaik, this PR didn't change any functionality, just workaround for older jdk8 compilers not to error out.

Cherry-picked and pushed the change to 1.1.x: c613ee5


Title not updated properly on client side navigations if whole HTML tree got suspended

I've got resource that I'm using to retrieve user's color scheme preference and I'm suspsending whole HTML tree to update the class and styles on root element while SSRing. I noticed that on client side navigations the title is not properly updated. The old one is not removed from the head, hence the new even if appended is not applied. It can probably create more issues than mine.
Reproduction: StackBlitz or repo

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed in mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


WIP: Parse argv

Closes: #7

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines         433    442    +9
=====================================
+ Hits          433    442    +9

Impacted Files
Coverage Δ

ldap2pg/config.py
100% <100%> (ø)
:arrow_up:

ldap2pg/script.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f53e461...fd84ec2. Read the comment docs.


feature: Support dtrace

Contact Details
<EMAIL_ADDRESS>Feature Description
Add dtrace to the managed packages
Why?
It allows you to create static probes
What-should happen?
dtrace should be a package in the index.json
Steps to Test

jq '.packages[] | select(.name = "dtrace")' resources/install/index.json should return the details for managing the dtrace package

Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://askubuntu.com/questions/60940/how-do-i-install-dtrace


update(infra): application dockerization

Here we perform a complete dockerization of the application using docker-compose.
In this dockerization we use resources to connect containers in a network for secure communication.

LGMT

@rafael-dev2021
Good afternoon my friend, apparently you didn't compile the project. You need to compile the project with Maven to be able to run Docker.
Follow the steps below:

You can use the ./mvnw Install -DskipTests command to compile the project.
Build the docker container with the docker-compose build command
Now just start docker normally docker-compose up


droplet_kit Refactor

Initial stage of work for #250
Key listing and sizes listing is pretty low
hanging fruit
The work around searching for nodes is a larger
amount of work, will leave until later.
Hashie warning fix stolen from https://github.com/berkshelf/berkshelf/pull/1668

Re-PR after repo move 😄

Coverage increased (+0.006%) to 98.006% when pulling 5349bca3307674f1078557d87c1639273dd8653c on droplet_kit_refactor into b01dda96d72f28eb6884254eb7f4adeab2a15aa8 on master.

Coverage increased (+0.006%) to 98.006% when pulling 5349bca3307674f1078557d87c1639273dd8653c on droplet_kit_refactor into b01dda96d72f28eb6884254eb7f4adeab2a15aa8 on master.

Coverage increased (+0.006%) to 98.006% when pulling 5349bca3307674f1078557d87c1639273dd8653c on droplet_kit_refactor into b01dda96d72f28eb6884254eb7f4adeab2a15aa8 on master.

Coverage increased (+0.006%) to 98.006% when pulling cac92aeefdd0e68682eed330ecb127b89ebbdcdd on droplet_kit_refactor into b01dda96d72f28eb6884254eb7f4adeab2a15aa8 on master.

Coverage increased (+0.006%) to 98.006% when pulling<PHONE_NUMBER>947b3fad75c8376b29000a17a226f2 on droplet_kit_refactor into f701987e99403aec1aca457360a319f108d1bf78 on master.


Space scroll Terminal in Edge and IE

Expected behavior
Pressing space should only insert space
Actual behavior
The page is scrolled down
Steps to reproduce

Open terminal demo https://terminal.jcubic.pl/
Focus terminal
Press space

Browser and OS
Windows IE and Edge

It seems that also backspace go one page back in history but only in IE, in Edge it work fine.

the problem was that when calling keypress insert was called that was calling redraw that was using visibility: hidden to make rendering faster. In IE and Edge when textarea was hidden it didn't prevent default behavior of scrolling the page. First try was setTimeout 0 but it didn't work (the solution was good but there was bug in debug code that was later removed when looked at diff).
Maybe there is better way to hide the cmd but don't hide textarea so it don't loose focus. In Chrome textarea keep having focus when cmd is hidden.

TODO: remove current code and add wrapper for prompt and lines, hide the wrapper instead of .cmd.


SendCommand -> RunCommand

Pull Request Functional Test Report for #2387 / 488d2f481821515ce1970a76ed170755de7126c5
No tests identified for validation.
Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 20 (45.0%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 48.658%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

topologies/binding/reset.go
0
1
0.0%

topologies/binding/cli.go
9
19
47.37%

Files with Coverage Reduction
New Missed Lines
%

topologies/binding/cli.go
1
55.56%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
1541

Relevant Lines:
3167

💛  - Coveralls