Adapter isn't compatible with Fortune.js 1.4.17

Hi,
the Fortune.js code was recently rewritten to ECMAScript 5.1, and the redis adapter isn't compatible with it anymore:
lib/index.js
import { inputRecord, outputRecord } from 'fortune/dist/lib/adapter/adapters/memory/helpers';
import { applyOptions } from 'fortune/dist/lib/adapter/adapters/common';
import applyUpdate from 'fortune/dist/lib/common/apply_update';

— dist directory doesn't exists. I tried to change these paths, but got another error:
Unhandled rejection TypeError: Cannot convert undefined or null to object
    at keys (native)
    at Object.createTransformers ((...)/node_modules/fortune-redis/dist/utils.js:57:22)
    ...

After some investigation I found, that this.recordTypes is undefined, as well as other injectable properties for the Adapter class.

Ok, thanks for you feedback.
I have to use the latest fortune.js version for a project, I'm currently working on that.
This dependencies is a bad design, I will change that but I don't want to rewrite to ES5.

can you try npm test from your this PR #4

Hello @thibremy, sorry for the delay in replying.
I tried npm test — after some work (fixing some errors, caused by babel), all 55 tests were successfully passed :+1: Moreover, I tested adapter with my test app — everything seems to work ok now :)
More information about my entertaining journey with babel-specific errors:
My environment:
Debian GNU/Linux stretch (testing release)
npm 2.14.7
node 4.2.1 (compiled from sources)
First, I've tested it without the es2015 preset, and got the same babel error, as before in #3 (caused by nonStandard option in the package.json).
After the installing babel-preset-es2015, I got this:
  28 tests
  0 passed
  28 failed

  Failed Tests:   There were 28 failures

    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function
    x TypeError: [undefined,false,(intermediate value),null].includes is not a function

npm ERR! Test failed.  See above for more details.

— so, I replaced es2016's Array.prototype.includes() method with Array.prototype.indexOf() and got all tests passed:
><EMAIL_ADDRESS>lint /tmp/fortune-redis/node_modules/fortune-redis
> eslint lib

/tmp/fortune-master/node_modules/fortune-redis/lib/index.js
   17:36  warning  Missing function expression name  func-names
   23:39  warning  Missing function expression name  func-names
   27:33  warning  Missing function expression name  func-names
   58:35  warning  Missing function expression name  func-names
  102:35  warning  Missing function expression name  func-names
  149:35  warning  Missing function expression name  func-names

✖ 6 problems (0 errors, 6 warnings)

  .......................................................

  55 tests
  55 passed

  Pass!


vue 3 composition api support?

hello, i'm trying to use this with the vue 3 composition api support, which doesn't have the this keyword.
is there any way to implement this?
thankyou

following the composition api support, it does work with this method
App.vue

<template>
    <n-config-provider
        :theme-overrides="{ common: { fontWeightStrong: '600' } }"
    >
        <n-grid x-gap="8" cols="1 900:2">
            <n-grid-item>

                    <button @click="addNewQuestion">Tambah Pertanyaan</button>
                    <button @click="exportData">Export</button>

            </n-grid-item>
            <n-grid-item>

            </n-grid-item>
        </n-grid>
    </n-config-provider>
</template>

NodeClick.vue

<template>

asdasd

</template>

the problem now is, the node can't be dragged vertically only works on drag horizontally. and also when i try to drag the connection, an error printed on the console.

Could it be that the style is missing?

Could it be that the style is missing?

nope. i think it got something to do with the this keyword again

I have created a small test and it works without problem.
App.vue
<template>
  <drawflow/>
</template>

components/drawflow.vue
<template>

</template>

I see that if I remove the property of the "height" automatically I get the error that is arising.
You can try putting the css code.

ah i see, so its because height?
i yesterday i use 100vh on the height but it's also error.
so i'll try to use px this time.
thankyou !

A fixed div height is required.
Maybe I can solve the typescript problem.
Liberia uses vue's "createApp and h" methods.
With:
import { onMounted, shallowRef, createApp, h } from 'vue'

And:
 const Vue = { createApp, version: 3, h };
...
editor.value = new Drawflow(id, Vue);

A fixed div height is required.
Maybe I can solve the typescript problem.
Liberia uses vue's "createApp and h" methods.
With:
import { onMounted, shallowRef, createApp, h } from 'vue'

And:
 const Vue = { createApp, version: 3, h };
...
editor.value = new Drawflow(id, Vue);

thankyou so much for the help!
also this is a great library exists for vue, i hope you have more time to maintain this library :)
and also i'm waiting for #48 to be implemented :D

For #48 auto connect nodes view: https://github.com/jerosoler/Drawflow/issues/216 and https://github.com/jerosoler/Drawflow/issues/255

For #48 auto connect nodes view: #216 and #255

ah sorry my bad i mean #256


[P1] [Stress] [Storage] UploadAsync() throws array index exception

Overview
While running a 60-second perf test of UploadAsync() with 8 parallel uploads and a 1 GB blob, the following exception was thrown.  Out of 3 perf runs, 2 runs failed with this exception and 1 run succeeded.  The exceptions seems to be thrown at the very end of the perf test, when the CancellationToken passed to UploadAsync() becomes canceled.
Root Cause
Skimming the code, the root cause might be a race condition where blockMap is modified during CommitBlockListAsync():
https://github.com/Azure/azure-sdk-for-net/blob/e70ca70406f81781de0edf795170086786555c49/sdk/storage/Azure.Storage.Blobs/src/BlobClient.cs#L989
https://github.com/Azure/azure-sdk-for-net/blob/e70ca70406f81781de0edf795170086786555c49/sdk/storage/Azure.Storage.Blobs/src/BlobClient.cs#L1045
Repro Steps

Create CancellationToken with a 60-second duration.
Call UploadAsync(CancellationToken) in a loop with a 1 GB blob and a maximum of 8 in-flight parallel uploads.
Wait 60 seconds for the CancellationToken to be canceled.

Exception
Unhandled exception. System.ArgumentException: The index is equal to or greater than the length of the array, or the number of elements in the dictionary is greater than the available space from index to the end of the destination array.
   at System.Collections.Concurrent.ConcurrentDictionary`2.System.Collections.Generic.ICollection<System.Collections.Generic.KeyValuePair<TKey,TValue>>.CopyTo(KeyValuePair`2[] array, Int32 index)
   at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source, Int32& length)
   at System.Linq.Buffer`1..ctor(IEnumerable`1 source)
   at System.Linq.OrderedEnumerable`1.GetEnumerator()+MoveNext()
   at System.Linq.Enumerable.SelectIPartitionIterator`2.PreallocatingToArray(Int32 count)
   at System.Linq.Enumerable.SelectIPartitionIterator`2.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Azure.Storage.Blobs.BlobClient.<>c__DisplayClass19_0.<StagedUploadAsync>g__CommitBlockListAsync|6(Boolean async, CancellationToken cancellation)
   at Azure.Storage.PartitionedUploader.UploadAsync[T,P](Func`1 uploadStreamAsync, Func`5 uploadPartitionAsync, Func`3 commitAsync, Func`2 uploadAsSinglePartition, Func`2 getStreamPartitioner, Int64 singleUploadThreshold, Nullable`1 parallelTransferOptions, Boolean async, CancellationToken cancellationToken)
   at Azure.Storage.Blobs.BlobClient.StagedUploadAsync(Stream content, Nullable`1 blobHttpHeaders, IDictionary`2 metadata, Nullable`1 blobAccessConditions, IProgress`1 progressHandler, Nullable`1 accessTier, Int64 singleBlockThreshold, ParallelTransferOptions parallelTransferOptions, Boolean async, CancellationToken cancellationToken)
   at Azure.Storage.Blobs.PerfStress.UploadTest.RunAsync(CancellationToken cancellationToken) in /app/net/Azure.Storage.Blobs.PerfStress/UploadTest.cs:line 32
   at Azure.Test.PerfStress.PerfStressProgram.RunLoopAsync(IPerfStressTest test, CancellationToken cancellationToken) in /app/net/Azure.Test.PerfStress/PerfStressProgram.cs:line 159
   at Azure.Test.PerfStress.PerfStressProgram.Run(Type testType, PerfStressOptions options) in /app/net/Azure.Test.PerfStress/PerfStressProgram.cs:line 101
   at Azure.Test.PerfStress.PerfStressProgram.Run(Type testType, PerfStressOptions options) in /app/net/Azure.Test.PerfStress/PerfStressProgram.cs:line 113
   at Azure.Test.PerfStress.PerfStressProgram.Run(Type testType, PerfStressOptions options) in /app/net/Azure.Test.PerfStress/PerfStressProgram.cs:line 121
   at Azure.Test.PerfStress.PerfStressProgram.<>c__DisplayClass2_0.<<Main>b__1>d.MoveNext() in /app/net/Azure.Test.PerfStress/PerfStressProgram.cs:line 31
--- End of stack trace from previous location where exception was thrown ---
   at Azure.Test.PerfStress.PerfStressProgram.Main(Assembly assembly, String[] args) in /app/net/Azure.Test.PerfStress/PerfStressProgram.cs:line 26
   at Azure.Storage.Blobs.PerfStress.Program.Main(String[] args) in /app/net/Azure.Storage.Blobs.PerfStress/Program.cs:line 10
   at Azure.Storage.Blobs.PerfStress.Program.<Main>(String[] args)

Removing blocking-release as it's not an API breaking change

I see a comment that the blocking-release label was getting removed but it was added back. Is this still blocking?


Add bower.json

Can I add bower.json?

No: https://github.com/rackt/react-router/issues/1864
We deliberately dropped Bower support; what you have there won't work anyway because the built bundles aren't checked in.


Help packages maintainer

Hi!
I added an haskell-ide-engine package to the ArchLinux User Repository. But your git repository has not any tags to fix the version source code state, even if the Cabal package is tagged as <IP_ADDRESS>.
I will be helpful to add a tag even if the version hasn't changed since the beginning of the development. It will help us fix the source code state used for building.

There is a concept of -git packages in AUR. At this point (haskell-ide-engine doesn't have stable releases yet) you should add haskell-haskell-ide-engine-git instead. See (https://aur.archlinux.org/packages/haskell-haskell-src-exts) for why 2 times haskell.
Also I wonder what happened to cblrepo tool? Is it used in any way these days?https://github.com/magthe/cblrepo

In the official ArchLinux repositories, only Haskell libraries are prefixed with haskell. Executable tools are not. This prefix is always used in the ArchHaskell repository.
Concerning cblrepo, I don't see any reason to use it as you use Stack to manage building. So the building process is quite simple. Maybe I'm wrong ?
Concerning the git package, you're right.
Thanks !


Handle multiple entry files

I need to generate three different independent bundle.js files and I'd like to have hot loading for all of them. I would set the entry points like this https://webpack.github.io/docs/multiple-entry-points.html, but how to tell webpack-hot-middleware to handle all the three entry files?

Which part of this doesn't work? If you have a working webpack-dev-server setup, I would expect the configuration to be the same.

I'd like to make it without webpack-dev-server, using just webpack-dev-middleware and webpack-hot-middleware like it's used in https://github.com/gaearon/react-transform-boilerplate.

The configuration should be the same, if you have an example that works in dev-server but not in hot-middleware please let me know.

The thing is that entry property in configuration for webpack multiple entry points is an object, while in examples with webpack-hot-middleware entry is an array. What object key should be then used for 'webpack-hot-middleware' entry?

This came up in the react-transform slack channel, so I now have a useful answer for you!
Each value in the object should be an array containing your intended entry point and the middleware client.

@glenjamin Awesome project. We have been discussing this over on the react transform boilerplate issue for multiple entry points https://github.com/gaearon/react-transform-boilerplate/issues/47
I have what seems to be a working config for multiple entry points using the approach you just described. Can you confirm this is the right approach?
https://github.com/benglass/webpack-hot-reload-config/blob/master/webpack.config.dev.js#L8
I noticed on the README for this project it says to remove all references to client in your webpack config so I am unsure as to whether or not there is another way to do this.
It seems like this is the right repo to add an example of the multiple entry point config, so if you have can confirm this is the right approach I can submit a docs PR.
Thanks for your time

@benglass that looks correct, would love a PR which adds an example / docs to this repo too!
The bit in the readme about removing references to client are for the original webpack-dev-server client - this was replaced with the webpack-hot-middleware client in v2.0.0


Update open-graph extension

Description

Add command that will get the url from the current open tab in your browser and open the Preview Open Graph command with this url

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Love this idea 🙌🏼 Thanks~


Addresable LED support?

Is it possible to modify the software so that instead of the standard RGB LED, the WS2812B can be used?

It should be possible with some adjustments

Have you an example? :)

Maybe this: https://esphome.io/components/light/neopixelbus
It is really best to look at ESPHome for this and search what works, possibly go through the Home Assistant community forum 🤷🏻♂


spec: unnecessary phrase in range loop description

The spec currently says (emphasis added):

The range expression is evaluated once before beginning the loop, with one exception: if the range expression is an array or a pointer to an array and at most one iteration variable is present, only the range expression's length is evaluated; if that length is constant, by definition the range expression itself will not be evaluated.

Arrays always have constant length though, so the second conditional seems redundant.
/cc @griesemer

it is a ; , instead of , before "if". The range expression may be a slice, string or map.

@go101 I don't think that interpretation holds. It says "that length," referring to "the range expression's length," which was predicated on the expression being an array or pointer to array. Also, slices, strings, and maps do not have constant length. Finally, if they're two separate exceptions, the "with one exception" wording is wrong.

Arrays always have constant length though

Arrays do not always have constant length.
“The expressions len(s) and cap(s) are constants if the type of s is an array or pointer to an array and the expression s does not contain channel receives or (non-constant) function calls”.

By definition, an array has a constant length. The expression s may still contain channel receives and function calls, resulting in an array. No matter what, that array has constant length.

Arrays always have constant length:

An array is a numbered sequence of elements of a single type, called the element type. The number of elements is called the length and is never negative.
The length is part of the array's type; it must evaluate to a non-negative constant representable by a value of type int.

The expression len(s) is not always a constant expression though.
The distinction between those two ideas is the crux of this issue.


generate json schema from POJO using jackson with custom serializers

I've a class say, DateBean which contains 3 fields viz. int day, int month & int year.
I have added a custom serializer to represent object of DateBean as a string with format - 'yyyy-MM-dd'
It is working fine during serialization while returning response.
Now, I want to generate schema of a response class which contains DateBean as property with the same custom serializer.
I tried with something like below, but it didn't work.
SimpleModule simpleModule = new SimpleModule();
simpleModule.addSerializer(DateBean.class, new JsonDateBeanSerializer());		mapper.registerModule(simpleModule);
SchemaFactoryWrapper visitor = new SchemaFactoryWrapper();
mapper.acceptJsonFormatVisitor(clazz, visitor);
JsonSchema schema = visitor.finalSchema();
It is even not going into serialize method of my custom serializer class, while generating schema.
In my schema, DateBean property get represented as Object with properties day, month & year.
However I want it should be like "type":"string" with format.
Can you please suggest how could I get JsonSchema of a POJO class with support of Custom Serializer

We use jackson for this functionality, i'd suggest you check there for this i'm afraid


Minor corrections for the RAND_DRBG API documentation

It did not take long until I found the first mistake after merging the RAND_DRBG API documentation (#5461).  Here is the first correction:

add some explaining text to a sentence that lost its context.

Instead of pushing micro-fixes I will let this pull request hang around for a while in case more errors show up. All fixes will finally be squashed into a single commit.
Errata can be posted here, too. I will fix them.
Update:  Squashed and ready for final review.

ping

Merge, thanks!


changes for new colormap libraries

This PR updates the design site to use the changes here and here. Specifically, it adds a new section documenting the new Colorbar component, and it adapts the colormap handling to that library's API changes. I've been testing locally with the two other packages via linking, so the build here will fail. Before merging, we should publish new versions of those and pull them in here.

updated to point to published versions of new packages


Error with khan/aphrodite for CSS when manually reload

// pages/index.js
import React from 'react'
import { StyleSheet, css } from 'aphrodite'

const styles = StyleSheet.create({ h1: { color: 'crimson' } })

const header = () =>
Hola

export default header;

If the document is already open when you apply css(styles.h1) it takes the chages and you see the red text, but if you manually reload the browser or the application is just starting you get a 500 | Internal Server Error.
and the console will give you
Error: Cannot automatically buffer without a document
    at injectGeneratedCSSOnce (/nextApp/node_modules/aphrodite/lib/inject.js:138:23)
    at injectStyleOnce (/nextApp/node_modules/aphrodite/lib/inject.js:156:9)
    at injectAndGetClassName (/nextApp/node_modules/aphrodite/lib/inject.js:232:5)
    at css (/nextApp/node_modules/aphrodite/lib/exports.js:133:54)
    at header (/nextApp/.next/dist/pages/index.js:22:37)
    at /nextApp/node_modules/react/lib/ReactCompositeComponent.js:305:16
    at measureLifeCyclePerf (/nextApp/node_modules/react/lib/ReactCompositeComponent.js:74:12)
    at ReactCompositeComponentWrapper._constructComponentWithoutOwner (/nextApp/node_modules/react/lib/ReactCompositeComponent.js:304:14)
    at ReactCompositeComponentWrapper._constructComponent (/nextApp/node_modules/react/lib/ReactCompositeComponent.js:279:21)
    at ReactCompositeComponentWrapper.mountComponent (/nextApp/node_modules/react/lib/ReactCompositeComponent.js:187:21)

I get the import style from 'next/css' but I already have another project with aphrodite modules that I'd like to reuse.

I guess the error occurs because there is no setting for server rendering of aphrodite.
https://github.com/Khan/aphrodite/issues/33
And since there is no way to add the setting, you wouldn't be able to use the library.
I recommend to convert your code to next/css.

@alexrqs your snippet with next/css looks like this:

// pages/index.js
import React from 'react'
import css from 'next/css'

const styles = { h1: { color: 'crimson' } }

const header = () =>
Hola

export default header;

@nkzawa Aphrodite does support server-side rendering. You need to wrap the server render in Aphrodite's StyleSheetServer.renderStatic instead of using glamour's renderStatic function in server/render.js
See https://github.com/Khan/aphrodite/blob/master/README.md#server-side-rendering for more info and for instructions on how to rehydrate.

We're going to address it with #251. I don't think wrapping is a good API though. I think all SSR modules should expose a "flush" or "rewind" API


Running as a docker container not cleaning up old files

Discussed in https://github.com/ep1cman/unifi-protect-backup/discussions/71

Originally posted by dkarzon January 11, 2023
I am running this as a docker container on an unraid instance syncing from a UDM Pro to OneDrive. The sync up to OneDrive works great. However, I have noticed it doesn't seem to clean up the old files (those that fall outside of the retention period) when the container is left constantly running.
As soon as I restart the container it then cleans up the old files as of the current time but continues to run only uploading.
Is this a known issue with the docker container method of running it or is there something I am missing to have the clean up functionality on an always on docker container?

How old are we talking for those older files? In the latest update I turned down the purge frequency because on certain storage providers that charge per API call, it was incurring unacceptable costs.
Currently the application will check when it starts then once every 24h for files to delete. Is this not happening correctly for you? You can also adjust the purge interval using the PURGE_INTERVAL envrioment variable for the container

I don't think I was seeing it check every 24hours. I will monitor it again over the next few days without a restart to make sure and report back with what I am seeing. It may be happening every 24hours but just feels like it's not, I only noticed it because every time I restart the container I get an email from OneDrive saying lots of files were deleted.
Is there a specific time the purge happens or is it just 24 hours from when it started up? I can see files are being deleted from OneDrive every day as well, either way I will report back after doing some more testing.

I have done some further testing on this and it is working now. It's been running continuously for 12 days now and has been cleaning up correctly, not sure why it was a few days behind before.
This can be closed now 👍


Initiate a GitHub action to deploy to heroku automatically on push or branch merge

Create the steps of GitHub actions such that whenever a new push or merge request is made, it automates the task of deploying.

I'd like to add this feature

Excuse me if I am wrong or don't fully understand the issue, but doesn't heroku already provide this feature? you can connect your GitHub account and select the repo, and heroku will automatically monitor any changes on it ( the selected branch ) and deploy whenever there is a new commit or merge ... etc

Thanks a lot @Dodger23 I had not seen the sync with Github on Heroku previously, I have added that now so it will automatically deploy 🙌

I think the benefit of using GitHub actions would be that you can automate building and running of a test suite whenever changes are made to the main branch. You can also add some things like mandatory code reviews. Then, only if all the test cases pass will the pull request be processed and forwarded to someone to conduct a code review. Then once approved, it can automatically deploy to Heroku, if that makes sense.


Find a 5-minute training video on listening/deliberation

Look on youtube for testing until we get our video

https://www.youtube.com/watch?v=7wUCyjiyXdg

Works for now! The preamble and promotion of his other work is a bit annoying, but we'll at least be able to demonstrate the concept in a reasonable way.


PinJoint2D unpins when parent node moved

Godot version:
3.1.1
OS/device including version:
Windows 10
Issue description:
When moving a node using remove_child + add_child any pin joints that are children of the node get unpinned. The joint copies correctly but detaches from it`s pinned nodes.
Steps to reproduce:
Run the attached minimal project, press enter to move the node in the tree, note that the previously pinned sub-node becomes detached but that the tree looks as expected.
Minimal reproduction project:
unpinbug.zip

Still valid in 6f4384f20


Add util function import_metas_and_vectors() read ids, metadata and vectors

Add util function import_metas_and_vectors() to handle export_dump_streaming() dump files, which will read id, metedata and vectors.

Hey @chuangfengwang we do not plan to actively mantain this repo. If u need this function in an executor, u can implement that in there

Oh, got it.


Handle activity start not found during replication

Handle activity start not found during replication. This could happen when DB has resurrection issue with two activity start event.

Coverage decreased (-0.4%) to 67.787% when pulling e219ccb7484eff72ff61fb7589070b90d165be67 on replicate-activity-start into 9e996b02a1f9698fa7a0224ba649bdc6251fe581 on master.


Remote network drivers in containers can be stopped before containers using them

Test set-up: the driver is running in a container:
$ docker ps
CONTAINER ID        IMAGE                      COMMAND                CREATED             STATUS              PORTS               NAMES
9019147aaacb        weaveworks/plugin:latest   "/home/weave/plugin"   2 days ago          Up 26 minutes                           weaveplugin

There is a network called "weave" that uses this driver, and we attach a container to that network:
$ docker run --net=weave -tdi alpine /bin/sh
6126990c2113a453e3f61db263333d43806bc3b91a24707f4d17c0ed3afc9c03

Then we stop Docker:
$ sudo systemctl stop docker

Syslog excerpts:
Jan 18 10:35:26 host1 systemd[1]: Stopping Docker Application Container Engine...
Jan 18 10:35:26 host1 docker[742]: time="2016-01-18T10:35:26.951460580Z" level=info msg="Processing signal 'terminated'"
Jan 18 10:35:26 host1 systemd[1]: Stopped docker container 9019147aaacb504136ffd05eb39d24440f1f86eae51b11414c0ae17523aba422.
Jan 18 10:35:26 host1 systemd[1]: Stopping docker container 9019147aaacb504136ffd05eb39d24440f1f86eae51b11414c0ae17523aba422.
Jan 18 10:35:36 host1 systemd[1]: Stopped docker container 6126990c2113a453e3f61db263333d43806bc3b91a24707f4d17c0ed3afc9c03.
Jan 18 10:35:36 host1 systemd[1]: Stopping docker container 6126990c2113a453e3f61db263333d43806bc3b91a24707f4d17c0ed3afc9c03.
Jan 18 10:35:36 host1 docker[742]: time="2016-01-18T10:35:36.963974968Z" level=warning msg="Unable to connect to plugin: /run/docker/plugins/weavemesh.sock, retrying in 1s"
Jan 18 10:35:37 host1 docker[742]: time="2016-01-18T10:35:37.964642705Z" level=warning msg="Unable to connect to plugin: /run/docker/plugins/weavemesh.sock, retrying in 2s"
Jan 18 10:35:39 host1 docker[742]: time="2016-01-18T10:35:39.966280735Z" level=warning msg="Unable to connect to plugin: /run/docker/plugins/weavemesh.sock, retrying in 4s"
Jan 18 10:35:41 host1 docker[742]: time="2016-01-18T10:35:41.952494420Z" level=error msg="Force shutdown daemon"

Because the driver was (randomly?) stopped first, the endpoint removal is blocked.

I'm going to close this as plugin-v2 provides a way out.


TSAN error in SignalAction::sigHandler

Description:
The CircleCI TSAN run for one of my pull requests caught what appears to be an existing problem: a signal-unsafe call to new due to string processing within a signal handler.
Repro steps:
This happened at least once by running the integration tests with TSAN. I'm not sure whether it happens deterministically.
Call Stack:
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal (pid=12258)
    #0 operator new(unsigned long) ??:? (ratelimit_integration_test+0x5c1e43)
    #1 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>(char const*, char const*, std::forward_iterator_tag) /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/basic_string.tcc:223 (ratelimit_integration_test+0xc7a0ec)
    #2 std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, unsigned long, std::allocator<char> const&) ??:? (libstdc++.so.6+0x121c04)
    #3 Envoy::Logger::LockingStderrOrFileSink::log(spdlog::details::log_msg const&) /proc/self/cwd/external/envoy/source/common/common/logger.cc:46 (ratelimit_integration_test+0x19df8d2)
    #4 spdlog::logger::_sink_it(spdlog::details::log_msg&) /proc/self/cwd/external/com_github_gabime_spdlog/include/spdlog/details/logger_impl.h:321 (ratelimit_integration_test+0x5d63cc)
    #5 void spdlog::logger::log<char const*, void const*>(spdlog::level::level_enum, char const*, char const* const&, void const* const&) /proc/self/cwd/external/com_github_gabime_spdlog/include/spdlog/details/logger_impl.h:74 (ratelimit_integration_test+0x19d74f9)
    #6 void spdlog::logger::critical<char const*, void const*>(char const*, char const* const&, void const* const&) /proc/self/cwd/external/com_github_gabime_spdlog/include/spdlog/details/logger_impl.h:163 (ratelimit_integration_test+0x19d737d)
    #7 Envoy::BackwardsTrace::logFault(char const*, void const*) /proc/self/cwd/bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:101 (ratelimit_integration_test+0x19d670f)
    #8 Envoy::SignalAction::sigHandler(int, siginfo_t*, void*) /proc/self/cwd/external/envoy/source/exe/signal_action.cc:30 (ratelimit_integration_test+0x19d528b)
    #9 __tsan::CallUserSignalHandler(__tsan::ThreadState*, bool, bool, bool, int, my_siginfo_t*, void*) crtstuff.c:? (ratelimit_integration_test+0x530c49)
    #10 non-virtual thunk to Envoy::(anonymous namespace)::RatelimitIntegrationTest_Ok_Test::TestBody() external/envoy/test/integration/ratelimit_integration_test.cc:? (ratelimit_integration_test+0x5c88af)
    #11 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2401 (ratelimit_integration_test+0x1f08206)
    #12 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2437 (ratelimit_integration_test+0x1eee961)
    #13 testing::Test::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2473 (ratelimit_integration_test+0x1ed723e)
    #14 testing::TestInfo::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2655 (ratelimit_integration_test+0x1ed82f1)
    #15 testing::TestCase::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2773 (ratelimit_integration_test+0x1ed8d37)
    #16 testing::internal::UnitTestImpl::RunAllTests() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:4673 (ratelimit_integration_test+0x1ee455b)
    #17 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2401 (ratelimit_integration_test+0x1f0d916)
    #18 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:2437 (ratelimit_integration_test+0x1ef24d7)
    #19 testing::UnitTest::Run() /proc/self/cwd/external/com_google_googletest/googletest/src/gtest.cc:4281 (ratelimit_integration_test+0x1ee3f6b)
    #20 RUN_ALL_TESTS() /proc/self/cwd/external/com_google_googletest/googletest/include/gtest/gtest.h:2237 (ratelimit_integration_test+0x15fbf27)
    #21 Envoy::TestRunner::RunTests(int, char**) /proc/self/cwd/external/envoy/test/test_runner.h:33 (ratelimit_integration_test+0x15fbde0)
    #22 main /proc/self/cwd/external/envoy/test/main.cc:35 (ratelimit_integration_test+0x15fae52)

@brian-pane I think this is likely a similar flake that we see occasionally w/ the gRPC tests. cc @htuch

I've seen this one before.  It happens anytime a test fails under TSAN, I believe.
I think it is a real error.  It means that we could deadlock in a signal handler if things go wrong in a particular way.
However, I don't know that it is worth spending a lot of time fixing. The fix would be to remove all uses of fmtlib and std::string and c standard library IO from the signal handler logging (including backtrace), and only use the signal-safe functions to write directly to STDERR_FILENO.  See http://man7.org/linux/man-pages/man7/signal-safety.7.html

I think this is worth fixing due to at least one failure mode that would be really bad in a production environment: getting stuck in the signal handler forever. If the implementation of any non-reentrant function called in this signal handler involves waiting for a mutex, for example, it's possible to end up in a situation where the function never terminates.  If that happens, the stack trace won't get printed, and Envoy won't exit. And the rest of the process's threads will still be running, which is probably dangerous, depending on what it was that caused the signal handler to run in the first place.

Maybe we should turn it off by default (except for tests?), and document the risks where the instructions for enabling it are.

SGTM

Is this fixed by https://github.com/envoyproxy/envoy/pull/2568 ?

@ggreenway @mattklein123 where are we heading with this one? Should we close it out or create a separate issue for disabling backtrace in prod? I don't think this is still a test flake.

I would just close it out until someone brings it up again, or open a fresh issue if you like.


Inconsistencies in Contrast Levels of Videos.

Steps to reproduce
Run a Youtube Video from a browser on Windows 11 and the same video from Youtube app running in WSA.
✔ Expected Behavior
WSA Contrast level should be equivalent to the one set by Windows 11.
❌ Actual Behavior
Videos look washed out when viewed inside an app using WSA. Tested the Youtube Android app vs the same video running in a Chrome browser.
Top Video Is Chrome. Bottom Video Is Youtube App In WSA.

Other Software
Youtube Android App 18.05.35
Please specify the version of Windows Subsystem for Android
2301.40000.4.0

duplicate: https://github.com/microsoft/WSA/issues/171
I have this issue as well on rtx 3060. It seems there is no inverse gamma correction being applied.

duplicate of #171


Docker setup for mongodb and api

@jmarin Figured you'd want to give this a once over before merge. Looking forward to your comments. I've based this on develop branch, so once this is merged there, it will need another merge over to master at some point.
A couple of notes:

MongoDB package on Alpine is part of the testing repo, and is not ready to go. It bombs when installed. Since Alpine uses musl-libc, not glibc, this causes a problem when compiling or using the binary distribution of Mongo as well. However, I've found a workaround to use the MongoDB distributed binary, as you can see in comments in mongo-docker/run.sh build script.
As defined, the mongodb image with Alpine comes in at around 138 MB, official mongo image, which is debian wheezy, sits at 261 MB. So definitely worth the headaches of the workaround.
The API container runs node directly, and should probably be linked together with a nginx container in front for performance. I might add support for this in the UI docker, since I'll have to run nginx there anyway to serve up the UI bits since they are static. Will just use a proxy like setup in nginx.

Hopefully I've commented enough that things are easy to follow.

@LinuxBozo Overall this looks good, just a couple of minor comments:

Travis seems to have been unhappy with this change and has a failed check. Not sure if that was just a glitch

I'd like the environment variables to change to something like the following, to better follow our setup for other containers:

HMDA_PILOT_MONGODB_HOST
HMDA_PILOT_MONGODB_PORT

@jmarin

Yeah, it appears that Travis has changed some things since the last time we've run jobs. I'll dig into that and see what's up. It seems to be complaining about running on old infrastructure and not the new containerized version.
The environment variables used follow the naming guidelines set by Docker, which is
<image tag>_PORT_<exposed port>_TCP_ADDR and
<image tag>_PORT_<exposed port>_TCP_PORT .
These are set automatically when you use --link to link containers with exposed ports together, so you don't have to define any env vars yourself. Are you sure you want to break this known convention? Or do you mean you want additional functionality to support both naming schemes?

@LinuxBozo Regarding environment variables, we don't use the Docker convention for using --link as that is assumed to work in the same host (as of this writing at least) and we will potentially run these in different machines. Additional functionality to also understand the format that I proposed would be great

@jmarin Ok, this should be good to go now..

@LinuxBozo When running build-docker-containers.sh I get the following error in the hmda-pilot-api container (fresh clone of the repo, building from your docker branch):
it should install nodejs 0.12.5... fail

@jmarin do you see a failure in the compilation step for node somewhere? I had @doelleri run as well to double check myself, and he didn't see this, so wondering if there is any other output to help solve this for you..

@LinuxBozo Some progress. I cleared all my docker images and am able to build and run the containers. The problem now is that I get a 403 Forbidden when hitting the URL of the hmda-pilot container. I just built and run all 3 containers with the provided scripts. Am I missing something?

@jmarin I'm betting you ran into the same thing that @doelleri did. Make sure that you have nodejs/grunt installed locally for building the hmda-pilot container.. it requires that grunt run the build task to generate the dist folder of the static site setup for running within the docker container.. While the API container doesn't have any local requirements during build, since node is built in the container itself, the pilot container requires it locally during the build..


Verify and separate events tests to work on hw

Add missing mock irq functional tests

fix some formatting

Add review suggestions

Re-arrange code in teardown

Fixed errors

Increase timeout limit

Re-enable j4 flag

Set ctest Timeout for events

Checkpoint 1: Started seperating mock tests

Seperate event tests from mock and hw

Fixed hw tests to work on vm

Seperate out invalid hw event tests to mock only

Remove unused vars

Seperate invalid hw tests to mock only

Verify all event tests work on hw with mcp and dcp

Cherry pick from 8ad4cec off feature/plugin-api.


Why customHTMLRenderer removes src attribute when it starts with "file://"

I have to convert ![](./upload/image.png) into <img src="file://${somePath}/uploads/image.png>, so created a custom html renderer following this: https://github.com/nhn/tui.editor/blob/master/docs/en/custom-html-renderer.md
const imgPlugin = () => {
  const toHTMLRenderers = {
    image(node, context) {
      return {
        type: "openTag",
        tagName: "img",
        attributes: {
          alt: "image",
          src: "file:///somepath/uploads/image.png",
        },
      };
    },
  };
  return { toHTMLRenderers };
};

But it seems tui editor trimmed my src attribute only when it starts with "file://":

Any help would be appreciated.
Env: electron 18
tui.editor: @toast-ui/react-editor

same issue. Have you solve it?

no


Dockerize LINE bot

Update dockerfile

Multi-stage build to make docker image smaller
apply .env file in build process (which is consistent to Heroku build environment)

npm scripts: Move build process to heroku-postbuild

so that it runs on heroku only, not in docker builds
heroku build should still work
.travis.yml updated accordingly

actually we stopped using travis because it always fails on docker-compose up

Categorize env vars into "Build time variables" and "Runtime secrets"

"Build time variables" are used by webpack and will be built into docker image
"Runtime secrets" are given when running docker container

Cofacts API introspection script makes sure data/ folder exist so that it works in docker build

Local data/ folder contains mongodb garbage so it is ignored in docker
Thus we need to build our own data/ folder within docker

README documentation

tmp_image_process does not trigger pm2 watch since it watches only /src folder. Paragraph in README removed.

Github action integration

PR & push: unit test
dev update: build staging image & push to docker hub
release/ tag: build production image & push to docker hub

TODO:

[x] tesseract support
[x] Deploy to staging - https://lin.ee/1QUzEX4nI
[x] automatic build & push in Github Actions with .env as secret (https://docs.docker.com/ci-cd/github-actions/ , https://stackoverflow.com/a/59482124)
[x] README for docker image build
[x] Log drain

Just curious. Why do you pack graphql schema in the bundle pipeline, but not in the development. From my opinion, schema is part of API structure code, which should be the part of codebase.

Just curious. Why do you pack graphql schema in the bundle pipeline, but not in the development? In my opinion, the schema is part of API structure code, which should be part of the codebase.

Good question. I was also thinking the same thing. Including the remote GraphQL schema in the codebase helps developer understand the expected API. It also helps keep track of the API change in LINE bot code base, after API server is changed.
I should include the remote GraphQL schema directly in the codebase in future PRs.

Default branch changed back to dev.


Fix Color#from_hsl, Color#from_hsv error when hue is 360

Changing the private method Color#cylindrical_to_cubic to use an inclusive
rather than exclusive range fixes the NilClass error reported in Issue #85
without changing the public API.

Thanks for fixing this!


Development: fix custom build plan database column for postgres

🚨 DO NOT deploy 🚨 contains database migration

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Changes affecting Programming Exercises

[ ] I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
[ ] I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

This is a bugfix for a bug introduced by me that prevents PE creations if you use Postgres. To fix it we move the json validation from the DB to Java and use the more generic text definition. I am piggybacking another small fix resulting from #7528 that prevented the list of custom actions to show up in the client.
Description

Steps for Testing

Prerequisites:

Artemis with MySQL and Postgres

Log in to Artemis
Create PEs with MySQL and Postgres, both work now
...

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

[ ] I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
[ ] I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Exam Mode Test

[ ] Test 1
[ ] Test 2

I fixed this directly in develop to avoid another database change. Thanks for providing the code


Apply netflixoss plugin to subprojects

This is required for the release process to work.
Also add in required files per internal "OSS Build and Publish" page.

@wmiaw, can you confirm that this is Apache 2.0 licensed?

Yes, MSL is under the Apache 2.0 license.


Support timeout assertions for lambdas

Feature summary
I would find it very helpful if there was a way to assert that a block of code runs (succeeds / fails) within a certain time duration (without having to add extra dependencies such as awaitility).
AssertJ already supports such assertions for java.util.concurrent.Future arguments:
assertThat(myFuture).succeedsWithin(Duration.ofMillis(2000));

One can of course convert a lambda into a Future and then use these assertions.
What this feature request is about is avoiding the boilerplate necessary to do that. It is not nice and often not trivial, especially if the code block throws checked exceptions. Basically, I ask for an analogue to jupiters org.junit.jupiter.api.Assertions.assertTimeout.
I think this could work nicely with assertThatCode, but the exact semantics are of course up to you.
Example
assertThatCode(() -> {
	CloseableHttpClient client = HttpClientFactory.getInstance().create();
	HttpRequestUtils rqUtils = new HttpRequestUtils(client);

	assertThat(rqUtils.isAvailable(new URI("http://www.orf.at"))).isTrue();
	assertThat(rqUtils.isAvailable(new URI("www.____NOTEXISTING___.com"))).isFalse();
}).succeedsWithin(Duration.ofMillis(2000));

Motivation:
I often convert projects from hamcrest/jupiter assertions to exclusively use assertJ. Jupiters assertTimeout was the only case I could find so far where convertion to assertJ was not possible without adding significant boilerplate.

I like the idea but we can't really use assertThatCode as it returns an AbstractThrowableAssert and succeedsWithin does not belong to throwable assertions.
In hindsight, returning an AbstractThrowableAssert from assertThatCode  was not a great idea, it should have return another type (CodeAssert or something alike) which would have exposed assertions like succeedsWithin, throwsException, doesNotThrowAnyException, ...
Having said that maybe we could try introducing this CodeAssert class that you can get with assertThat(ThrowingCallable) .
This needs a bit of exploration to get the API right (this time!) and make sure assertThat(ThrowingCallable)  is not ambiguous in java and other JVM langages.

Thank you very much for the response!
I am just wondering because AbstractThrowableAssert already has a method doesNotThrowAnyException (at least in version 3.26.3 that we use).
Since such "successful" assertions already exist, don't you think that succeedsWithin(Ducation) could also be part of that club?

Oh I understand. It makes sense to not build more uppon a wrong pattern :)
Just an idea: an alternative to waiting for a major release could be introducing a new static generator such as assertThatCodeBlock or so, that will return the new type that you mentioned, and then deprecate the existing assertThatCode. This will result in a smoother transition for users. It is of course a little pitty because the existing assertThatCode() has the coolest and most intuitive name 😢 but the feature could be at least be shipped earlier this way.
Up to you :)

related to https://github.com/assertj/assertj/pull/2519

@alkismavridis as Joel mentioned, in #2519 we're evaluating how to introduce a better assertThatCode(Callable) while remaining compatible with the current usage patterns so that a new major release is not required.
As part of that change, we'll investigate how to have a solution in AssertJ similar to assertTimeout.

Sounds great. Thank you very much guys!


[VEN-1996]: add deployments of agEUR market in Stablecoins pool

Resolves VEN-1996
Checklist

[ ] I have updated the documentation to account for the changes in the code.
[ ] If I added new functionality, I added tests covering it.
[ ] If I fixed a bug, I added a test preventing this bug from silently reappearing again.
[ ] My contribution follows Venus contribution guidelines.

After executing https://app.venus.io/#/governance/proposal/170 the Shortfall and the ProtocolShareReserve contracts in the VToken should be set to the following values:
Mainnet:

Shortfall: 0xf37530A8a810Fcb501AA0Ecd0B0699388F0F2209
ProtocolShareReserve: 0xfB5bE09a1FA6CFDA075aB1E69FE83ce8324682e4

Testnet:

Shortfall: 0x503574a82fE2A9f968d355C8AAc1Ba0481859369
ProtocolShareReserve: 0xc987a03ab6C2A5891Fc0919f021cc693B5E55278

I would change the deployment script of the VToken contracts to consider this change, and I would redeploy the vagEUR contract


Cannot set src field in Docz configuration file

Hi, Thanks for the starter kit, it works smoothly.
Recently I met a problem that all the docs in blog file come into the my docs page. So I tried to  add the src field in .doczrc, but I got the error like the following:
The plugin "gatsby-theme-docz" created a page with a component that doesn't exist. Missing component is /Users/myusername/Projects/coolest-library/Button.mdx

I even tried a new repository, the error comes once I add the src field.
I have checked the createPage file in gatsby-theme-docz, it seems they do not get options from .doczrc, the related code here: https://github.com/pedronauck/docz/blob/master/core/gatsby-theme-docz/src/node/createPages.js#L28-L37
I updated all the related dependencies to latest one, but the problem has not been solved, so I guess it could be some binding problem with Docz and Gatsby, so I think here it the right place to ask the problem.

May we have help ?


[BUG] Sha setup jumps from 16 to 2

Describe the bug
If I do /sha setup and use @ to skip servers, after 16 it jumps back to 2.
To Reproduce
The steps to reproduce

/sha setup
@ in chat 16 times

Expected behavior
I expected it to go to 17 and further
Sledgehammer Bungeecord (please complete the following information):

Version: 0.3.1

Sledgehammer Bukkit (please complete the following information):

Version: 0.3
Server Backend: Mohist

This issue is related to a bug with how bungee cord reports it's servers. I'm using a different system in 0.4 so that's no longer an issue.
The same issue is occurring in 0.4, but likely for a different reason, so I'm keeping this open for now.

Fixed 17a06449f1c0285cf9711b0109a535cd0849f1d7


Template code should Authenticate with Bearer Token

After signing into the client application the Account page is blank.  Looking in the console, I see several errors starting with:
AccountPage.tsx:71          GET http://localhost:3000/api/auth/sessions?page=0&page_size=10 401 (Unauthorized)
If I modify line 73-75 from:
headers: {
  Authorization: `${auth.accessToken}`,
}

to
headers: {
  Authorization: `Bearer ${auth.accessToken}`,
}

The page GET http://localhost:3000/api/auth/sessions succeeds.
This appears to be a result of addressing Issue #87

merged the fix, closing the issue
feel free to re-open if neededd


Add antialiasing

The curtain demo is great but also it demonstrates the need for antialiasing in this framework.

add  Renders with edge antialiasing key to info.plist


translated missing Russian strings

I did this using the translation tool.

Thank you. Do you wish to be credited for the updated translation as "ralienpp" or another name?

ralienpp is fine :-)


Upgrade to JHipster 6.6.X

Upgrade to JHipster 6.6.X
The latest version of this blueprint (1.3.0) provides compatibility with JHipster 6.5.1, but it's not clear whether there are known issues with using v1.3.0 with the latest version of JHipster (currently 6.6.0).
If there are no known issues and/or the blueprint has been tested with JHipster 6.6.X, then it would be helpful to document this and/or upgrade the sample app to the latest JHipster version.
Motivation for or Use Case
I would like to use the latest version of JHipster, but it's unclear whether it's compatible with the latest version of this blueprint.
Related issues or PR

[X] Checking this box is mandatory (this is just to show you read everything)

I just didn't have time to do the upgrade, as all the work is done during our personal time, it's not our day work...
Anyway, the only issue is the CI failed with OAuth2. If you can help to fix it, I can do a release with JHipster v6.6.0
Otherwise, you'll have to wait or use directly master branch.

It's already done, so I'm closing this.
Then, I'm working on the compatibility with v6.7.0


performance: move rules to dictionary

Doing a dictionary lookup should be much faster than the if-else block.
The mechanism to see the languages with rules is more solid just looking at the dictionary keys.
I've applied the same logic to the prefix processing.
My next step is to create a rules folder where each language has its own file exporting the methods to apply the rules and apply the prefixes.
With all this is much easier to add new rules and manage them.
It's also a first step to wrap rules in a class and make them configurable.

Codecov Report

Merging #58 (1194d13) into main (5582eab) will increase coverage by 0.03%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   95.66%   95.69%   +0.03%
==========================================
  Files           9        9
  Lines         484      465      -19
==========================================
- Hits          463      445      -18
+ Misses         21       20       -1

Impacted Files
Coverage Δ

simplemma/dictionary_pickler.py
91.89% <100.00%> (ø)

simplemma/lemmatizer.py
98.01% <100.00%> (+0.46%)
:arrow_up:

simplemma/rules.py
91.00% <100.00%> (-0.59%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Yes, a dictionary is supposed to be more efficient as explained here.
I don't see a speed difference right now but it makes it easier to organize the code, I'd say we can go on with this.

You created an empty file rules/de.py, it the PR ready for a merge or are you still working on it?

Should be good to merge now.
That de.py file would be the next step.

Nice, thanks!


chore: fix api handler used during testing

Motivation
Fix e2e tests on electra branch, see job run
Description
Fix api handler used during testing by supplying api module to call to set as this object
https://github.com/ChainSafe/lodestar/blob/81b6d7a5cc6695c357c55e4c14edc6469b5f966a/packages/beacon-node/src/api/impl/beacon/pool/index.ts#L85-L87

:tada: This PR is included in v1.22.0 :tada:


<EMAIL_ADDRESS>hash check failed

Installing 'microsip' (3.20.6) [64bit]
MicroSIP-Lite-3.20.6.zip (3.9 MB) [===========================================================================] 100%
Checking hash of MicroSIP-Lite-3.20.6.zip ... ERROR Hash check failed!
App:         extras/microsip
URL:         https://www.microsip.org/download/MicroSIP-Lite-3.20.6.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    8dd307714c53d6605c977a271ee26c3658612dec4fb2e68ab50c35fe6e36ee86
Actual:      c9cbcd388f4e9062dcb97820ad56ad3ae56755d424b082406f0a1618d4804381
Please try again or create a new issue by using the following link and paste your console output:
https://github.com/lukesampson/scoop-extras/issues/new?title=microsip%403.20.6%3A+hash+check+failed

0d3d5c32ff23bf49ab2881574fed9f473e31d062


Support RN 0.59.0+ for 64bit

Starting August 1, 2019:
All new apps and app updates that include native code are required to provide 64-bit versions in addition to 32-bit versions when publishing to Google Play.
Extension: Google Play will continue to accept 32-bit only updates to existing games that use Unity 5.6.x or older until August 2021.

But when I build it with React-Native 0.59.0+, the SDK throw so much error of Kotlin code

try 0.59


[enhancement]: Folders by data of output files

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
It would be nice to have one folder by data of generated images
Alternatives
No response
Additional Content
No response

Duplicate of #4147


Outline view contains too many imports

The outline view lists every import my module makes (which are almost entirely uninteresting), followed by the functions if I scroll enough (which has lots of great information). Would be better if the imports were either collapsed by prefix (e.g. Data.* under one tree view), or probably just replaced with the word "imports", or even omitted entirely.
I'm not actually sure if it's Ghcide which is populating this or the Haskell syntax language thing. I hope @shayne-fletcher both knows and knows how to fix it :). If it is the syntax highlighting I suggest the Haskell IDE crew reach out and engage with them about it, and treat that part as part of the whole IDE ecosystem.

It is populated by ghcide, I implemented it. Not too happy with the end result either. Should be a relatively easy fix if anyone wants to give it a go, the only tricky bit would be reading the lsp spec for outline item types and figuring out the right way to describe the grouped imports.

If nobody else wants to tackle this right now, I would like to give it a try later this day. Looks like a good first issue to me.

@pepeiborra I saw it pop up and my reaction was "what's this magic" - Ghcide keeps getting better through your efforts and others like magic. Thanks for the feature!

I just want to say that it is useful for me to have all the imports. If I need to jump to a specific import line I can hit SPC s i (search for symbol in Emacs) and then type imp Cont Mo, which is a fuzzy search for import Control.Monad. I don't use this that often, but just wanted to say there is some value in what currently happens. But maybe that symbol listing is separate from the tree view you get (or also maybe it's coming from Emacs imenu, and not ghcide).


Colour / Animation issues

Hello gang!
I am trying to get this simple animation working (http://recordit.co/iojs4om76c), but I am having a few issues.

The background gets a fill colour and the body of the character becomes transparent.
Bodymovin JSON export doesn't animate at all, just a still image.

Bodymovin export: https://i.imgur.com/9Yz2bKf.png
What am I doing wrong here? :(
Here are the AE files: https://drive.google.com/drive/folders/0B-C01MPW7JVrRngzLVdSUHZRclk?usp=sharing
Thank you!

Hi, in your layer > Contents > Group 12
remove Merge Paths 1, Path 12 and Merge Paths 2
2. Bodymovin doesn't support the wiggle Effect. Not many effects are supported for now.

Thank you!


[SR-10281] URLSession crash while handling basic authentication

Basically the  crash  in URLSession code is due to the invocation of TaskRegistry.remove twice with the same taskIdentifier  from urlProtocolDidFinishLoading. While handling basic authentication,  if the response code is 401 and authentication headers are missing  then   call should fail with error urlProtocol(_ protocol: URLProtocol, didFailWithError error: Error)   which  a is performing the removal of task`` from TaskRegistry. Hence, adding the return``` statement after the above call should resolve the issue.

@swift-ci test

@saiHemak Can you please change the commit message so that it describes the problem/solution from a URLSession standpoint?

@pushkarnk  please review ..

This probably fixes the issue reported here: https://twitter.com/mxcl/status/1111073495017029635

@swift-ci test and merge

LGTM

@swift-ci please test and merge

@saiHemak @pushkarnk Should this be back ported to 5.0?

Yes definitely - PR coming v. soon :)

Should this be fixed in docker image swift:5.0.1-bionic?
I've got an API testing tool that specifically triggers 401s for testing purposes and between 5.0 and 5.0.1 I see some change in the output but I still seem to be getting the same underlying error:
5.0:
🎬  attack_create_contract started ...

Fatal error: Trying to remove task, but it's not in the registry.: file /home/buildnode/jenkins/workspace/oss-swift-5.0-package-linux-ubuntu-18_04/swift-corelibs-foundation/Foundation/URLSession/TaskRegistry.swift, line 76
❌  Error: The operation could not be completed (URLError(_nsError: The operation could not be completed))

5.0.1:
🎬  attack_create_contract started ...

❌  Error: The operation could not be completed (URLError(_nsError: The operation could not be completed))

Raised https://github.com/apple/swift-corelibs-foundation/pull/2063  against 5.0  branch

I guess this isn't the full fix then... @finestructure can you provide your testcase?

I'll try to isolate a test case!

I've created a sample repo here: https://github.com/finestructure/SR-10281 and logged the test results to a file test.log
Something odd seems to be going on (and I hope it's not me ;) ):

macOS-5.0.1 and linux-4.2.1 always return a response
linux-5.0.1 always comes with a nil response
linux-5.0 is jittery but over a few reruns I see it mostly printing both none (i.e. nil response) and an actual response

I hope that helps!

Awesome, thanks so much. @pushkarnk is out today but we'll take a look ASAP.

@finestructure Thanks for the test case.
With swift-5.0-RELEASE the Fatal error is expected.
With swift-5.0.1-RELEASE I do not see the Error: The operation could not be completed message that you mention? May be the test is unable to reproduce the error in my environment. I ran the test more than 500 times, but don't see any failure. I also ran the test on Ubuntu 18.04 and 16.04 boxes, but no luck.
I see that the images swift:5.0 and swift:5.0.1 both use swift-5.0.1-RELEASE, can you please confirm the swift version which causes the Error: The operation could not be completed failure? Also, can you please confirm if you see the Fatal error with swift-5.0.1-RELEASE ?

Sorry, I meant to add to this yesterday and completely forgot:
It appears that 5.0.1 fixes the fatal error that 5.0 introduced (line 50 in the test.log) but it doesn't seem to restore the 4.2.1 behaviour or match the 5.0/5.0.1 behaviour on macOS, which is to yield a response that is not nil.
In other words, I would have expected line 33 in that log not to be none but to show the response, like line 5ff.
Does that make sense?

Regarding your other comment

I see that the images swift:5.0 and swift:5.0.1 both use swift-5.0.1-RELEASE

that doesn't match what I'm seeing:
 ~/P/G/SR-10281  ⎇ master  docker run --rm -it swift:5.0
root@d6cce205a5e4:/# swift --version
Swift version 5.0 (swift-5.0-RELEASE)
Target: x86_64-unknown-linux-gnu
root@d6cce205a5e4:/# exit
 ~/P/G/SR-10281  ⎇ master  docker run --rm -it swift:5.0.1
root@e60c1b0da0ae:/# swift --version
Swift version 5.0.1 (swift-5.0.1-RELEASE)
Target: x86_64-unknown-linux-gnu

I can confirm that I see the fatal error only with swift-5.0-RELEASE

When you say "I also ran the test on Ubuntu 18.04 and 16.04 boxes" it seems like we're running the test differently. It sounds like you're not using docker but running swift run directly on Linux boxes?
I'm running the tests via the official swift docker images. If you've got docker installed, you can run all the tests and recreate my exact scenario if you run make test. It will run the macOS as well as the Linux tests with different versions.

Hi @finestructure I did run with the official docker images using make test. I additionally ran the test on the Linux boxes.

Regarding your other comment

I see that the images swift:5.0 and swift:5.0.1 both use swift-5.0.1-RELEASE

that doesn't match what I'm seeing:
 ~/P/G/SR-10281  ⎇ master  docker run --rm -it swift:5.0
root@d6cce205a5e4:/# swift --version
Swift version 5.0 (swift-5.0-RELEASE)
Target: x86_64-unknown-linux-gnu
root@d6cce205a5e4:/# exit
 ~/P/G/SR-10281  ⎇ master  docker run --rm -it swift:5.0.1
root@e60c1b0da0ae:/# swift --version
Swift version 5.0.1 (swift-5.0.1-RELEASE)
Target: x86_64-unknown-linux-gnu

I can confirm that I see the fatal error only with swift-5.0-RELEASE

Hmm, I see this on running swift --version before the swift run command:
test-linux-5.0.1
docker run --rm -it -v /Users/puskulka/10281/SR-10281:/host -w /host swift:5.0.1 swift --version && swift run -c release | tee -a test.log
Swift version 5.0.1 (swift-5.0.1-RELEASE) <<<<<<<<<<<<<<<<<<<<<< 5.0.1
Target: x86_64-unknown-linux-gnu
Compile Swift Module 'SR_10281' (1 sources)
Linking ./.build/x86_64-apple-macosx10.10/release/SR-10281
Launching ...
Sending request ...
<NSHTTPURLResponse: 0x7f9426d909a0> { URL: https://dev.vbox.space/api/v1/contract } { Status Code: 401, Headers {
    "Content-Length" =     (
        201
    );
    "Content-Type" =     (
        "application/problem+json"
    );
    Date =     (
        "Thu, 02 May 2019 08:15:25 GMT"
    );
    Server =     (
        nginx
    );
    "access-control-allow-credentials" =     (
        true
    );
    "access-control-allow-headers" =     (
        "Accept, Authorization, Cache-Control, Content-Type, DNT, If-Modified-Since, If-None-Match, Keep-Alive, Origin, User-Agent, X-Requested-With"
    );
    "access-control-allow-methods" =     (
        "GET, POST, PUT, DELETE, OPTIONS"
    );
} }
echo "\ntest-linux-5.0" | tee -a test.log

test-linux-5.0
docker run --rm -it -v /Users/puskulka/10281/SR-10281:/host -w /host swift:5.0 swift --version && swift run -c release | tee -a test.log
Swift version 5.0.1 (swift-5.0.1-RELEASE) <<<<<<<<<<<<<<<<<< 5.0.1
Target: x86_64-unknown-linux-gnu
Launching ...
Sending request ...
<NSHTTPURLResponse: 0x7fd4316120c0> { URL: https://dev.vbox.space/api/v1/contract } { Status Code: 401, Headers {
    "Content-Length" =     (
        201
    );
    "Content-Type" =     (
        "application/problem+json"
    );
    Date =     (
        "Thu, 02 May 2019 08:15:27 GMT"
    );
    Server =     (
        nginx
    );
    "access-control-allow-credentials" =     (
        true
    );
    "access-control-allow-headers" =     (
        "Accept, Authorization, Cache-Control, Content-Type, DNT, If-Modified-Since, If-None-Match, Keep-Alive, Origin, User-Agent, X-Requested-With"
    );
    "access-control-allow-methods" =     (
        "GET, POST, PUT, DELETE, OPTIONS"
    );
} }

Sorry, I meant to add to this yesterday and completely forgot:
It appears that 5.0.1 fixes the fatal error that 5.0 introduced (line 50 in the test.log) but it doesn't seem to restore the 4.2.1 behaviour or match the 5.0/5.0.1 behaviour on macOS, which is to yield a response that is not nil.
In other words, I would have expected line 33 in that log not to be none but to show the response, like line 5ff.
Does that make sense?

Ah , ok. So this seems to be the problem. Thanks for clarifying!

The version reports correctly for me:
test-linux-5.0
docker run --rm -it -v /Users/sas/Projects/GitHub/SR-10281:/host -w /host swift:5.0 swift --version && swift run -c release | tee -a test.log
Swift version 5.0 (swift-5.0-RELEASE)
Target: x86_64-unknown-linux-gnu
Launching ...

But after clearing my image I also get 5.0.1 now. Has the official version be retagged in docker hub?!
 ~/P/G/SR-10281  ⎇ master *~  docker rmi swift:5.0
Untagged: swift:5.0
Untagged: swift@sha256:ccaef3f936bd3cabd184a0caf7c2455eb861182b51e77970be4be72bea116a26
 ~/P/G/SR-10281  ⎇ master *~  make test-linux-5.0
rm -rf .build
echo "\ntest-linux-5.0" | tee -a test.log

test-linux-5.0
docker run --rm -it -v /Users/sas/Projects/GitHub/SR-10281:/host -w /host swift:5.0 swift --version && swift run -c release | tee -a test.log
Unable to find image 'swift:5.0' locally
5.0: Pulling from library/swift
Digest: sha256:dc9d8cb34457f9d10035caaefc465812ed387e8dfca506eb49bb5533fd137f0d
Status: Downloaded newer image for swift:5.0
Swift version 5.0.1 (swift-5.0.1-RELEASE)
Target: x86_64-unknown-linux-gnu
[2/2] Linking ./.build/x86_64-apple-macosx/release/SR-10281
Launching ...
Sending request ...

5.0 is the Docker tag for the latest version of the Swift 5.0 release.  So, if you did docker pull swift:5.0 when Swift 5.0 was released, you got Swift 5.0.0.  If you do docker pull swift:5.0 now you get Swift 5.0.1.  So that explains why you are seeing different versions.

Ok, so the problem now is the inconsistency between versions 4.2.1 and 5.0.1, which is easily reproducible with your test case @finestructure . Would you mind filing a bug report on bugs.swift.org? Thanks.

@ianpartridge I see, thanks! Since there is no 5.0.0 image I'd assumed that's the one that's frozen. Maybe there should be one?

Yes probably we should have done a swift:5.0.0 tag when we released the 5.0 Docker image, so people can depend on that if they don't want 5.0.1, 5.0.2 etc. Unfortunately we didn't and that ship has sailed!

Ok, I've filed it here: https://bugs.swift.org/browse/SR-10602


How to point Config-server to a deep nested subfolder of a git repository without reading the whole tree?

Hi,
I have a working Config Server pointed to a small git repository and everything works fine. I am using searchPaths to look for files in subfolders working fine. My problem is that I need to use an existing git repository with huge content where the files I need are placed in a subfolder. If I try to point my config-server to this new git, it tries to read the whole tree folder (including brothers and cousins from the actual folder I need) and produces a timeout.
Is there any way to tell Config Server to work only with a determined subfolder and ignore the rest of the git tree?
Thanks in advance!

That's not really how git works is it? Are these huge files configuration?

No, there is all kind of stuff in the repository, which was created for a legacy application that does not use config-server. We would like to avoid changing the structure of the repository since it is remotely synchronizedwith a CMS. That is also the reason why we did not simply copy the property files to another repository.

That's really a limitation of git. Not sure what else to say.

I guess we will have to go with a uri:file configuration and some how clone/mount the content remote subfolder, just checking if someone had previously faced this problem.
Thanks anyway!


Adjust build config for prod

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   52.16%   52.16%
=======================================
  Files          29       29
  Lines         370      370
  Branches       43       43
=======================================
  Hits          193      193
  Misses        159      159
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b821d5...76e21e0. Read the comment docs.


[Figma] Masthead - icon button refactor

Part 1 of the Masthead refactor. We need to update the icon buttons to use one base, have all interactive states, and have prototyping set up out of the box.

Assigned to Tiffany Tran


Best practice method for accessing variables in subsystem models

Say I have a system model (e.g. aircraft) with a subsystem (e.g. wing) that has a variable (e.g. mass). What is the best practice method for accessing the variable? ac['mass_Aircraft/Wing.1'] is somewhat gross.
EDIT: other subsystems may also have the variable, so ac['mass'] is not an option here.

@mayork @1ozturkbe how do you guys typically access variables in sub-models from the system level model? Or do you always have unique varkeys?

I do what you said above, a better method is probably called for because it can get really ugly.

I think best practice is for ac to have a .wing attribute so that you can do ac.wing["mass"]

That would be super dope

It doesn't require anything on the GPkit end, just python!
As mentioned elsewhere, my hope is still to deprecate square-bracket notation and have that be ac.wing.mass

Ah yeah, dumb, sorry.


Make required_guarantees output to be deterministic

Which issue does this PR close?

Closes #12473.
Rationale for this change
Well explained in the issue.
This PR resolves the issue in display output string level instead of the real literals: HashSet<ScalarValue> data level.
What changes are included in this PR?

Add sorted_literals when displaying LiteralGuarantee to ensure literals part of each guarantee element is deterministic. (Enough for fixing Andy's case)
Add sorted guarantees to make sure the whole guarantees vector is deterministic. (In case we have more than one required_guarantees)

Are these changes tested?
Yes. By adding parquet_exec_display_deterministic.

Ensure EXPLAIN to be deterministic every time (loops 100 times) for the same expr.
Ensure EXPLAIN for two different expr with equivalent filter condition to be deterministic.

Are there any user-facing changes?
No, only if you EXPLAIN and display a physical plan, the results will be deterministic now.

Just add the test. Thanks for reviewing.

🚀


consider switching upstream for better support of cct bulbs

tp-link-tapo-connect upstream seems rather unmaintained (or at least very slowly maintained) currently (last change was a "minor naming improvement" 2 months ago, last change before that was in october, 2 unanswered PRs since december, 2 unanswered issues since january, last closed issue was in december), it might be helpful to temporarily switch upstream to @ccristi9918's version, due to this change actually implementing support for more than 3 settings in CCT bulbs, that doesn't look like it would be merged soon: https://github.com/dickydoouk/tp-link-tapo-connect/pull/18
though i'm not sure how well that would work with npm and all that, if you have an alternative idea how a user might switch over on their end that'd be highly appreciated too. currently i do the really ugly hack of directly editing the js files in node_modules

Hi.
Thank you for using this node-red-contrib-tplink-tapo-connect-api.
The node-red-contrib-tplink-tapo-connect-api is thinking of changing to an active npm package.
please wait until finish.
sanlike0911


Gitleaks ignore new line character in rule regex section

Describe the bug
Trying to use regexp, which contain 'new line' character. Seems Gitleaks can't process it.
To Reproduce
Steps to reproduce the behavior:

Use Regexp to fing credentials in Gradle files: '''(credentials).*?\n*.*?[username|password]\s*[:=]?\s*['\"]([0-9a-zA-Z-_]{3,32})['\"]'''
Full rule description:

...
[[rules]]
    description = "Gradle credentials"
    regex = '''(credentials).*?\n*.*?[username|password]\s*[:=]?\s*['\"]([0-9a-zA-Z-_]{3,32})['\"]'''
...

Use below content of a file to analyze:

repositories {
    maven {
        url "http://repo.mycompany.com/maven2"
        credentials {
            username "user"
            password "pass"
        }
    }
}

Try to find credentials in the file.
Result: No Leaks Found.

Expected behavior
As you may see in regexp online emulation, it had to find such string.
Basic Info (please complete the following information):

OS: OSX 10.15.7
Gitleaks Version: 7.5.0

Additional context
Add any other context about the problem here.
cc @zricethezav

@cyrusmatsumori I do not have any plans to add multi-line support as determining line-numbers numbers is quite the task. If you want to fork and implement this feature yourself I'd be happy to review it.

Thanks for info.
Maybe it should be mentioned in the README.md feature section?


Can I use HTTParty with api_auth

I was wondering if I can use httparty as http client.

There is no request driver currently for HTTParty, but I'd be willing to accept a new driver if someone makes it work. Unfortunately I don't have the bandwidth right now to tackle it. From what I can tell HTTParty is just using net/http under the hood, so hopefully that means a HTTParty request driver would mostly just be passing along work to the Net::HTTP driver.

For anyone who finds it useful, here's the approach I took to patch ApiAuth.sign! in to HTTParty:
Firstly I defined a NetHTTPRequestSigner module to patch the Net::HTTP#request method.
It's job is to sign the request right before it's executed:
module NetHTTPRequestSigner
  def request(unsigned_request, body = nil)
    ApiAuth.sign! unsigned_request, 'my_access_id', 'my_secret_key'
    super
  end
end

Then I created a new subclass of HTTParty::ConnectionAdapter per the docs.
Its job is to patch Net::HTTP returned by HTTParty::ConnectionAdapter, and it uses the singleton_class.prepend trick to ensure we don't pollute the Net::HTTP in general:
class RequestSigningConnectionAdapter < HTTParty::ConnectionAdapter
  def connection
    super.tap do |http|
      http.singleton_class.prepend NetHTTPRequestSigner
    end
  end
end

Now we can specify this adapter whenever we need signing, per the docs:
class MyClient
  include HTTParty
  connection_adapter RequestSigningConnectionAdapter
end

@dukedave thank you for that comment! One alteration is that you need to pass the signed request to your super call.

Do you have any suggestions for passing the API authentication parameters to the RequestSigner module?

@cworsley4 you mean like super(unsigned_request, body) ?

Not quite @TomK32. You take the unsigned request and sign it with this library, then pass the returned, signed, response on to super
super(ApiAuth.sign!(unsigned_request, key, secret))


lint ignores files marked as generated

add comments to lint hand-made expansions
remove client from linter ignores

Experiment complete! Ready to merge!

What is the experiment? I vote for keeping the ignore on generated code, but maybe I'm missing something?

Ah yes, the experiment.
Golang tools now ignore code with a comment  https://golang.org/s/generatedcode
Generated files are marked by a line of text that matches the regular expression, in Go syntax:
^// Code generated .* DO NOT EDIT\.$

k8s gengo generators now add that comment.

I'm still a bit confused. Is this the final PR that you want to merge, or should I just ignore it because you are using it to test stuff out?

final PR ready to go.
experiment is successfull in my mind.
I think this should go in, because I'm all for reducing lines of code when they don't do anything. Includes process stuff like Makefiles.
I can create a followup for investigating the other ignores if that would help, but some I'm not sure will ever change.

/cc @jberkhahn @jeremyrickard

Nice Morgan, LGTM.

/approve


The QAI Submission should be combined into 1 long form

We need to refactor the "QAI Section Submission" process to be one long form, instead of separate submissions.
The Sections have an order property we can use to determine the order to display them.
Mockup -

A new API will be developed for this data -
/api/fm/qaa/submission
Each section submission data should be added to an array when posted to the API.
Example POST body -
{
  "locationId": "123",
  "dateScored": "2022-02-19T04:40:28.389Z",
  "managerOnDuty": "John Doe",
  "fsc": "user1",
  "responsibleAlcoholCert": "lorem ipsum",
  "sections": [
    {
      "sectionId": "string",
      "locationId": "string",
      "status": "DRAFT",
      "answers": [
        {
          "questionId": "string",
          "value": "YES",
          "notes": "string",
          "attachments": []
        }
      ],
      "guestAnswers": [
        {
          "answers": [
            {
              "guestQuestionId": "string",
              "value": "YES"
            }
          ],
          "notes": "string",
          "attachments": []
        }
      ]
    }
  ]
}

Hello @jdbranham ,
i am bit confused here, is it a new screen to create or we need to modify the older one.

Hey @jdbranham
I have created a design like the below image.
I did not find API (/api/fm/qaa/submission), I have taken the latest pull from the main branch.

Here is PR.
https://github.com/savantly-net/franchise-manager/pull/90

That's ok - the users will be taking new pictures for each attachment, and they'll have different names.
I'll create an issue in the backlog to fix that on the backend.


Implement Shipment Detail Component

Description
Implement a Shipment Detail Component in the first theme. So that user can input their details and proceed the payment.
Reference: https://www.figma.com/file/rX1jl4pa04VD9itnzneeih/Webiu?node-id=0%3A1
Changes proposed in the pull request

Implement ShipmentDetail Component
Implement Story for the component
Create documentation for the component

Screenshots (In case of UI changes):

Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests have passed and it does not give any unexpected error for the same.

Steps to test

npm i
npm run storybook (story will be displayed in E-Commerce/ShipmentDetail )

Resolves https://github.com/scorelab/Webiu/issues/246

@charithccmc @dinithminura can you review the PR please :)


Timestamps in console/logs

Hey @Bjornskjald work on other discord bot and see the timestamps in other bot here the link https://github.com/izy521/discord.io


CarStateTransceiver not working

CarStateTransceiver is created, and mode_.isGo_ is true, but car state is not being updated.
Possible causes: bad setup in Unity, bad NeworkViewId, Distance code isn't running CarDirectives read, write, or update properly
Next step: investigate if it's receiving any data at all.

This bug was caused by...

The server would properly receive the car state bits, which is held within a single 32 bit integer
The server would properly assign those bits to the Bits_ property of the CarStateTransceiver
The server would -- actually -- properly compare if cars were idle or not, because that used a direct comparison of the Bits_ property between zero and the car state.
The server would not call Serialize to convert from Bits_ to an actual car state.
The server would stream out by converting the car state properties to bits -- the properties which wee never serialized in from the streamed in bits.

This means that the server had the right bits for the car state, but those bits never became proper values, so the properties were always zero.

In version 0.1.3, this was fixed with a workaround:

Received car state bits do not go into the CircularBuffer for CarDirectives
Received car state is manually streamed in using the main CarDirectives in the CarLogic, instead of using a CarDirectives in the CircularBuffer
CarDirectives.Serialize is manually called to convert the car bits to car state properties.

This in effect assumes that the most recently received car state is the newest and ignores the timestamp attached to the state.
It should be possible to go back to using the CircularBuffer and just call Serialize on the main CarDirectives in CarLogic after running Update. This will bring behavior back to Distance's, where the timestamp matters and the most recently received state is not assumed to be the newest.


Model evaluation script attempts to upload results by default

The model evaluation script attempts to upload results regardless of the value of the --upload-results flag:
https://github.com/argmaxinc/whisperkittools/blob/0999a613c56c462b063b6b25d96260e1fc6ee2de/scripts/evaluate_model.py#L106C35-L106C39

Thanks for the report!


Optimized non-greedy binpacking

Currently, texts are packed into the bins in a fixed order. Allowing texts to be rearranged would increase flexibility in binpacking, which translates to more efficiency.
There are multiple Python implementations of binpacking:
https://github.com/fuglede/numberpartitioning
https://github.com/benmaier/binpacking
https://github.com/coin-or/prtpy
But how will the texts be ordered correctly in the output? Related to #17

Closing because package is in maintenance mode


how to get  the source of tuple

hi guys:
in storm  get the tuple source component and task by tuple.getSourceComponent()  and tuple.getSourceTask(), but in heron i can not do that because of it's not implemented.

Can you check out this search result page?

tuple.getSourceComponent() is implemented, though tuple.getSourceTask() is not implemented.

@daxwang - wondering what is the use case for tuple.getSourceTask()?


Update python support to 3.10, 3.11 and 3.12

This PR drops python 3.9 support and adds python 3.12.
Checklist

[ ] I have performed a self-review of my code.
[ ] I have commented hard-to-understand parts of my code.
[x] I have made corresponding changes to the public API documentation.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] I have updated the changelog with any user-facing changes.

Looks like some dependency requires numpy 1.23.3, which is failing to build on Windows. May have to skip 3.12 tests on Windows for the time being?


Binary datatype changes to Document while sync from mongoDB to mongoDB

I have setup a transporter from mongo to mongo, The mongodb contains the nutch 2.x crawl data of the internet web sites.
My  pipeline.js  file looks like the snippet below:
var source = mongodb({
"uri": "mongodb://user:pwd@localhost:37001/srch"
});
var sink = mongodb({
"uri": "mongodb://user:pwd@localhost:37001/srch"
});
t.Source("source", source, "/^crawl_webpage$/").Transform(pick({"fields":["_id", "baseUrl","content","contentType","title"]})). Transform("ns", otto({filename: "change-ns.js"}), "/./").Save("sink", sink, "/./")
The transformer.js is as below.
module.exports = function(msg)
{
if (msg.ns=="crawl_webpage"){
msg.ns="crawl_intranet";
}
if(msg.data["content"]==null || msg.data["content"]==""){
msg.op = "skip";
}
console.log(JSON.stringify(msg, null, 2));
return msg;
}
System info:
•Transporter version 0.5.0-linux-amd64
•OS  Red Hat Enterprise Linux Server release 6.9 (Santiago)   Linux 2.6.32-696.el6.x86_64
•DB version(s)
mongo - v2.0.4
Reproducible Steps:
transporter-0.5.0-linux-amd64 run
What did you expect to happened?
The datatype(org.bson.types.Binary) of the source mangodb collection field is getting changed to a different datatype(org.bson.Document) on the target mongoDB/Collection during the sync.
What actually happened?
The datatype(org.bson.types.Binary) of the source mangodb collection field should remains same on the target mongodb collection.

I'm guessing this has to do with the version of MongoDB you're using (mongo - v2.0.4). I've tested against mongodb v2.6.9 and the binary data transferred properly. is there any way you can try against a newer version of mongodb?

looking through this a bit more, the issue is likely due to the multiple Transforms being used as we have to unmarshal/marshal the data back and forth for each function.

Thank you for the note. I have completed it using text data instead of
binary as the client is not moved on to latest version.
On Tue, Nov 14, 2017 at 8:29 PM, JP Phillips<EMAIL_ADDRESS>wrote:

I'm guessing this has to do with the version of MongoDB you're using (mongo

v2.0.4). I've tested against mongodb v2.6.9 and the binary data
transferred properly. is there any way you can try against a newer version
of mongodb?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/compose/transporter/issues/429#issuecomment-344285355,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfWIogN8oTiZZJmbhCGc8rjsNloliYurks5s2arjgaJpZM4P8Rb9
.

glad you got things worked out!


GH-34367: [Java] Fix build error from sequential merges

Rationale for this change
I broke main by merging two PRs in quick succession that unfortunately didn't work together.
What changes are included in this PR?
Fix the build error.
Are these changes tested?
N/A
Are there any user-facing changes?
No, test code only

Closes: #34367

@github-actions crossbow submit java


Default Workspace avatar changes color when editing workspace name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to staging new dot
Go to workspace and edit the name
Observe that the default avatarof the workspaces changes color

Expected Result:
Default workspace avatar should remain the same
Actual Result:
Default avatar changes color
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/fb919a4a-c422-414e-993e-2700736a2e35
https://github.com/Expensify/App/assets/43996225/97b96967-b8a8-49e0-b1fd-ee14d6dc32ab
Expensify/Expensify Issue URL:
Issue reported by: @sofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690048384195019
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
The color of the avatar changes when we change the name of the workspace
What is the root cause of that problem?
In Avatar, we use props.name to know which fill color to use here:
https://github.com/Expensify/App/blob/cd851d0fbd901c70a32220472104ffc887639f2a/src/components/Avatar.js#L83
What changes do you think we should make in order to solve the problem?
If we want to keep the same color when we change name, we can use a prop that nevers changes, for example the id that we would pass through a new prop here (and at other places were we render Avatar):
https://github.com/Expensify/App/blob/cd851d0fbd901c70a32220472104ffc887639f2a/src/pages/workspace/WorkspaceSettingsPage.js#L106-L114
Note: For Avatar that are not linked to a workspace we can do the same with other ids, for example the id of users
What alternative solutions did you explore? (Optional)

Just in case it's not intended


Defining Sla Event metadata

@ibuenros @chavdar  can you take a look at this?
Overview

The change defines metadata required in an SLA event. An SLA event must have datasetUrn, partition, originTs and upstreamTs
An SLA event can also have additional optional metadata like completenessPercentage, recordCount etc. See SlaEventKeys.java. Optional metadata is not applicable to all ETL flows.
Any ETL flow can extend the abstract class SlaEvent and implement the getters for datasetUrn, partition, originTs, upstreamTs. The SlaEvent class does not expose the key names for any metadata. This promises a fixed schema for an SlaEvent.
Next, we want to define and Arvo schema for the sla event. This change will still emit a GobblinTrackingEvent.

Compaction changes

Enabled metrics/events for MRCompactor job
emit an SLA event when daily compaction is completed. See CompactionSlaEvent.java

Some high-level description of what's in the PR will be helpful.

@chavdar and @ibuenros
I have made changes as per our discussion this morning. Please take a look.
Changes -

Created an SlaEventSubmitter which is a wrapper around the existing EventSubmitter. This class allows clients to inject sla metadata through state or through a builder. The class is responsible for validating the required fields.
In gobblin-compaction added a helper class to populate the sla metadata required by the SlaEventSumbitter

just one last comment, otherwise LGTM

Other than my comments about swallowing IOExceptions and lombok setup, LGTM.