Reusing existing draft release no longer works in GH org

I just recently moved https://bkimminich/juice-shop into https://juice-shop/juice-shop and noticed a behavior change of my release flow https://github.com/juice-shop/juice-shop/blob/master/.github/workflows/release.yml#L49 as follows:
Precondition
I manually create a draft release named vX.Y.Z where I store all release notes over time until the release gets published.
✅ Before (https://bkimminich/juice-shop)
When pushing tag vX.Y.Z the action would use the existing release and attach build artifacts to it.
❌ After (https://juice-shop/juice-shop)
When pushing tag vX.Y.Z the action will ignore the existing release and create a new release also named vX.Y.Z where it attaches all build artifacts. I can use a workaround of copy-pasting my release notes over to the newly created release and delete the old one, but it'd be nice to get rid of this glitch.

I am at a loss where this behavior might come from. Is it maybe something with lacking permissions of default GITHUB_TOKEN when working in a GitHub org instead of a personal account? Or could this be an actual bug in the action?

I’ll have to take a closer look but when specifying a draft an attempt is made to first resolve an existing draft with the same name before creating a new one
https://github.com/softprops/action-gh-release/blob/58fa4b7a8863f6beaf115a49196308842b8b0f06/src/github.ts#L209

I'm having a similar issue - in my case I'm building two assets in parallel jobs (one for mac, one for windows) and then uploading to create a new release. Oddly enough this behaved as expected 2 days ago, creating a single draft release with two assets attached, and re-running the action resulted in updating the asset on the existing release.
Today it is creating two separate releases with the same tag, each with a single asset, and every time I run the action a new draft release with the same tag is created. Did something change on GitHub's end? I can't see anything different in your action or in my workflow.

We've been hit by the same issue over on https://github.com/starship/starship.
We have a release first be created as a draft by https://github.com/googleapis/release-please, generate our build artifacts, then would use action-gh-release to upload the artifacts and publish the draft with draft = false.
Instead of updating the existing release, a new non-draft one is created.

I had a similar problem, and ended up using actions/github-script to find and update the release. I originally tried:
const tag = "v${{ needs.prepare.outputs.version }}";
const release = await github.rest.repos.getReleaseByTag({
  owner: context.repo.owner,
  repo: context.repo.repo,
  tag: tag,
})
await github.rest.repos.updateRelease({
  owner: context.repo.owner,
  repo: context.repo.repo,
  release_id: release.data.id,
  draft: false,
  body: "Check the [changelog](https://github.com/qutebrowser/qutebrowser/blob/master/doc/changelog.asciidoc) for changes in this release."
})

But ended up getting a 404 for finding the release, even though the tag was correct. That might well be the same underlying issue which also causes this action to create a new one, I suppose?
In the end, I instead used the release ID from this action directly (heavily cut down, untested, but might be a good starting point?):
name: Release

on:
  ...
jobs:
  prepare:
    ...
    outputs:
      ...
      release_id: ${{ steps.create-release.outputs.id }}
    steps:
      - name: Create GitHub draft release
        id: create-release
        uses: softprops/action-gh-release@v1
        with:
          tag_name: v${{ steps.bump.outputs.version }}
          draft: true
          body: "*Release artifacts for this release are currently being uploaded...*"
  ...
  finalize:
    ...
    needs: [prepare, ...]
    steps:
      - name: Publish final release
        uses: actions/github-script@v6
        with:
          script: |
            await github.rest.repos.updateRelease({
              owner: context.repo.owner,
              repo: context.repo.repo,
              release_id: "${{ needs.prepare.outputs.release_id }}",
              draft: false,
              body: "Check the [changelog](https://github.com/qutebrowser/qutebrowser/blob/master/doc/changelog.asciidoc) for changes in this release."
            })
  ...


Bigquery Jobs should match the Futures interface

Presently, bigquery uses a custom Job class (and subclasses) to deal with long-running operations such as queries and data import.
The Job class causes the proliferation of code like this around all of our samples and user code:
def wait_for_job(job):
    while True:
        job.reload()  # Refreshes the state via a GET request.
        if job.state == 'DONE':
            if job.error_result:
                raise RuntimeError(job.errors)
            return
        time.sleep(1)

Which in terms means our samples require a level on indirection to accomplish simple tasks:
client = bigquery.Client()
query_job = client.run_async_query(str(uuid.uuid4()), query)
query_job.use_legacy_sql = False
query_job.begin()

wait_for_job(query_job)

rows = query_job.results().fetch_data(max_results=10)
for row in rows:
    print(row)

However, our gax-based clients share a common "Long Running Operation" strategy that surfaces these types of on-going operations as a class that implements the concurrent.futures.Future interface. This is implemented as gax._OperationFuture. bigquery unfortunately can not use this as it's an http-only API and gax can only currently be used for gRPC APIs.
We should make the _BaseJob class and its subclasses closely conform to the Future interface so that the usage is similar to other API client and so that we can simplify usage to:
client = bigquery.Client()
query_job = client.run_async_query(str(uuid.uuid4()), query)
query_job.use_legacy_sql = False
query_job.begin()

# Wait for the job to finish
query_result = query.result()

rows = query_result.fetch_data(max_results=10)
for row in rows:
    print(row)

When you call .result() does it actually block? The Video Intelligence API sample, which uses that gax OperationFuture, I believe, shows some polling. https://github.com/GoogleCloudPlatform/python-docs-samples/blob/f1934ad309a05148608cec84edaf473843bc6a8f/video/cloud-client/analyze/analyze.py#L49

Yes, result blocks
On Thu, Jun 29, 2017, 5:43 PM Tim Swast<EMAIL_ADDRESS>wrote:

When you call .result() does it actually block? The Video Intelligence
API sample, which uses that gax OperationFuture, I believe, shows some
polling.
https://github.com/GoogleCloudPlatform/python-docs-samples/blob/f1934ad309a05148608cec84edaf473843bc6a8f/video/cloud-client/analyze/analyze.py#L49
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/google-cloud-python/issues/3556#issuecomment-312144777,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUc_YKyUYkPc03VgD0R_yTnfkvOntHks5sJES5gaJpZM4OHHHN
.

Related #3617


Google Season of Docs 2021

Discussion 🗣
Proposal for Accord Project to participate in Google Season of Docs 2021
Context
The Season of Docs Program

Gives open source projects an opportunity to improve their documentation.
Gives technical writers an opportunity to gain experience in open source.
Creates a better understanding of metrics and best practices in open source documentation.

The application form is available in the organization administrator guide during the organization application phase.
Our project proposal should be publicly available. We will include the link to our project proposal in the application form. We will use the project proposal template to help create our project proposal.
After submitting the form, we can continue updating the information on the form until the end of the organization application phase (March 26, 2021).
In addition to the content of the organization's application, the Google program administrators take the following factors into account when selecting organizations:

Open source projects should be active. For example, the Google program administrators may look at the number of contributors and the contribution trends on GitHub.
Season of Docs aims for a diversity of projects. The Google program administrators examine the set of candidate organizations and make a balanced selection to ensure that there's a range of organization types, industries, geographical areas, product types, and organization sizes.
Season of Docs can only accept a certain number of projects. The number of projects accepted depends on the total budget requests of all applying projects.
The open source organization must be eligible to participate in Season of Docs, as described in the program rules.

Detailed Description
If we are interested in having Accord Project participate in Season of Docs, we must first familiarize ourselves with the organization administrator guide and the organization administrator responsibilities.
The following questions will help us understand whether our open source project or organization should participate in Season of Docs. Does our organization or project:

[ ] Believe new or updated documentation would help achieve a goal or solve a problem in your project or community?
[ ] Have an initial understanding of or hypothesis for how you would measure the success of your documentation project?
[ ] Have community members willing to help recruit, evaluate, and onboard a technical writer, and who would be available to answer questions and provide other support during the project (6-8 months, including the application period)?
[ ] Have a community member willing to serve as the organization administrator and coordinate creating the application, responding to questions from the program administrators, and submitting monthly evaluations and the final report and case study? The organization administrator should also be willing to answer followup surveys after the completion of the 2021 Season of Docs.

Organization Application Process
Exploration Phase

Create a project proposal page. The proposal page includes a list of key needs, goals, or problems, possible documentation solutions, and possible metrics. This page should be public, and allow for community contribution and discussion. Include information for technical writers who would like to participate—where should they ask questions, express interest, or go learn more about your project? (See the project ideas list for examples.)
Publicize your proposal page in your community channels and add your organization to the list of interested organizations in the Season of Docs GitHub repository. You may also want to share your link in the #season-of-docs channel in the Write The Docs Slack. The promotion and press page includes logos and other content that you can use when talking about Season of Docs.
For each documentation idea, consider what experience and qualifications a technical writer would need to work successfully with your community and organization. What skills would your community be able to help a technical writer develop (for example, using GitHub or your docs toolchain)? (See the guide for working with technical writers)
Ask for volunteers to help answer questions from interested technical writers.
Begin reviewing any submitted statements of interest from technical writers interested in working with your project.

Application phase

Choose the most promising idea from your proposal page. Each organization may only submit one proposal. Some things to consider:

Which idea has received the most interest from technical writers?
Which idea will help solve your project’s biggest problem? It’s better to choose a riskier idea that would have a bigger impact than an idea for a documentation project that is more likely to be completed but won’t make a significant difference to your project.
Does the idea require participation by specific members of your community? Do they have the time to participate?

Create your proposal, using the proposal template. Make sure you understand and include:

The problem you want to address
The scope of the documentation you want to improve or create
How you will measure the success of your documentation
Your proposal must also include a budget. Incomplete proposals will not be considered.

Submit the Application Form by the application deadline March 26, 2021 at 18:00 UTC. Accepted proposals will be announced on April 16, 2021.

I think this should be closed now.


Any repo to get the program/code to install on docker?

Description
I would like to install the program/code onto some free docker like replit so that I can generate epg from the docker. But don't know the link to the repo of those code, is that github.com/iptv-org/epg.git ? (I am new to those free docker service). Thanks.
Regds
LAM Chi-fung

One has to build the image to get this done. I am trying to do it and it works to fetch the data but I am still having a hard time getting it to start the webserver.


Changed autotile priority picking algorithm

Currently tilemap pushes autotile coordinate in a list [priority] times, but this code does the same but by pushing once, this could be useful for big autotiles which have custom priorities set as big numbers.

I don't know if this will be faster or not but code looks good.

Needs a rebase after #27565.

Thanks!


Modify build/watch-demo scripts to work on windows

This fixes #25

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


IntegrationTest failing due to ServerProperties

Hi,
I noticed that my build was broken after adding
@SpringBootApplication
@EnableDiscoveryClient
public class Application
...

The unit test looks like:
@RunWith(SpringJUnit4ClassRunner.class)
@SpringApplicationConfiguration(classes = { Application.class })
public class myTest

The jar is working.
This is the error that I am getting, when I enable my unittests:
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'consulDiscoveryClient' defined in class path resource [org/springframework/cloud/consul/discovery/ConsulDiscoveryClientConfiguration.class]: Unsatisfied dependency expressed through constructor argument with index 1 of type [org.springframework.boot.autoconfigure.web.ServerProperties]: : No qualifying bean of type [org.springframework.boot.autoconfigure.web.ServerProperties] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {}; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type [org.springframework.boot.autoconfigure.web.ServerProperties] found for dependency: expected at least 1 bean which qualifies as autowire candidate for this dependency. Dependency annotations: {}

Duplicate of #149


DPL-1655 Add schema validation to landing bucket -> raw lambda

Description of changes
https://github.com/ministryofjustice/data-platform/issues/1655

Infer the schema using the infer schema functionality
Check against the registered schema
If it doesn't match, move to fail path in the data bucket
If it does match it will get moved to the raw location (already implemented)

Notification via slack or email would be implemented later.
Note: this is still incomplete as it depends on a schema_path change being added to the path library
Data type handling
We decided to make the schema checks very lenient because there are lots of cases where the registered schema could be a different type to what we can infer from the data. E.g. the data is inferred as integer, but the schema says bigint.
Related

The types Athena supports: https://docs.aws.amazon.com/athena/latest/ug/data-types.html
The types mojap_metadata handles: https://github.com/moj-analytical-services/mojap-metadata/blob/main/mojap_metadata/converters/glue_converter/init.py

I haven't integration tested this on the development environment yet - I'm going to wait until the new landing zone infrastructure is deployed first.


Bootstrap.less - where do you place the @import for responsive.less?

I have placed it within the // Grid system and page structure area but am not getting the desired .thumbnail gutter width in large displays.

It compiles to a separate file: https://github.com/twitter/bootstrap/blob/master/Makefile#L17

If you're going to import it, it'd have to be the last file, otherwise any components defined below it will override the responsive styles.


CDT Cloud Blueprint update to Theia 1.49

Update and release aligned with Theia 1.49.1
Required Steps

[ ] Merge latest Theia Blueprint community release commit
[ ] if required: Update Theia to latest version of said community release
[ ] Update all consumed Theia extensions and VSCode extensions
[ ] Test packaged Electron Blueprint locally
[ ] Test Browser variant locally
[ ] Test Docker variant locally
[ ] Run E2E tests locally (https://github.com/eclipse-cdt-cloud/cdt-cloud-blueprint?tab=readme-ov-file#running-e2e-tests)

After Merge

[ ] Verify that Jenkins pipeline completed successfully
[ ] Download a previous release and check that update to latest version completes successfully

Deploy to try.theia-cloud.io:

[ ] Push docker image with version tag to registry via GH action
[ ] Update deployment file to use newly pushed docker image
[ ] Apply the deployment file to the cluster
[ ] Verify that updated CDT Cloud Blueprint Try Online is available and works

Release announcement:

[ ] Announce release on the cdt-cloud-dev mailing list

@ndoschek will work on this

Hi @sdirix, I opened a PR of the update to Theia 1.49.1 here:
https://github.com/eclipse-cdt-cloud/cdt-cloud-blueprint/pull/90
I completed the first set of tasks from the description (but cannot mark them as done myself), could you check them for me? TIA

@jfaltermeier will have a look at the current Jenkins failures


add crash log for shouldoverride method

Task/Issue URL: https://app.asana.com/0/488551667048375/1204513195956997/f
Description
Add crashlog for crash events inside webview shouldOverride method
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3120   👈

This comment was auto-generated by Graphite.


Android UI Bugs

Description

[x] - chain icon on feed-item is incorrectly shown
[x] - multi-balance above >10k don't fit container
[x] - phone number input lost previous styling after package update
[x] - balance on bridge confirmation screen is not aligned

Supporting data

Verified on QA Android App, waiting for the release to check on prod


Beta version with python 3.8 support

just a wish

I'm closing this issue for now as Python 3.8 is in beta. We'll add support for the final release.


Use TTL from ODSP createBlob response

Description

Trying to solve https://dev.azure.com/fluidframework/internal/_workitems/edit/1318

First thing tackled here is skipping reupload of stashed blobs that were previously successfully uploaded and whose TTL has not expired, meaning that server should still have such blobs. This is done in the constructor addition.

Second thing is on resubmit, reupload blobs whose TTL has expired and about to send a BlobAttach op. BlobManager could think it is safe to send the op to other clients but blob won't be on server anymore.

Reviewer Guidance
Still a PR since I have not yet determined the following:

Still looking into a way to create unit tests for this. I need to be able to set up different TTLs to be included in getStorage.createBlob response. I have tested artifically adding minTTL to localDocumentStorageService but that is not unit testable.

I have taken a look into telemetry added regarding using local or server time and it has been scarce and not conclusive:

Ignore console.logs

First thing tackled here is skipping reupload of stashed blobs that were previously successfully uploaded and whose TTL has not expired, meaning that server should still have such blobs. This is done in the constructor addition.

Second thing is on resubmit, reupload blobs whose TTL has expired and about to send a BlobAttach op. BlobManager could think it is safe to send the op to other clients but blob won't be on server anymore.

Could these be split into separate PRs? I think it would be easier to review that way.

First thing tackled here is skipping reupload of stashed blobs that were previously successfully uploaded and whose TTL has not expired, meaning that server should still have such blobs. This is done in the constructor addition.

Second thing is on resubmit, reupload blobs whose TTL has expired and about to send a BlobAttach op. BlobManager could think it is safe to send the op to other clients but blob won't be on server anymore.

Could these be split into separate PRs? I think it would be easier to review that way.

Changes are not that big. First one is entirely on constructor, second one is related to uploadExpiredBlob method

First thing tackled here is skipping reupload of stashed blobs that were previously successfully uploaded and whose TTL has not expired, meaning that server should still have such blobs. This is done in the constructor addition.

Second thing is on resubmit, reupload blobs whose TTL has expired and about to send a BlobAttach op. BlobManager could think it is safe to send the op to other clients but blob won't be on server anymore.

Could these be split into separate PRs? I think it would be easier to review that way.

Changes are not that big. First one is entirely on constructor, second one is related to uploadExpiredBlob method

I still think we should split. as the changes are independent, and there is no reason to couple them. it also allow them to move at different speeds, one can get in, while the other gets more feedback or something.


Add crate: openvr

The "VR" category lists https://github.com/lucidscape/openvr-rs, which has not seen any updates in 2+ years. There is a more popular and more recently updated crate, simply called "openvr" with high-level OVR bindings at https://github.com/rust-openvr/rust-openvr.

Thanks. This library is not on crates.io?

Fixed in commit dddb767


Using only div's for fabricator html

Hi, We are creating our toolkit and want/have/need to work as semantic as possible. This also means using as less classes as possible and instead using the html elements correctly with their role attribute. Doing this causes trouble for the toolkit itself, as for example, the nav becomes troubled as of our css code for our nav structure. Would it be possible to refactor fabricator to use only div's as this will not interfere with the toolkit css?

Agreed! I think this would be a good feature. Something similar to semantic-ui.com would be ideal.


Unable to run regctl on Mac

Hi Team,
I'm trying to install regctl on my M1 Mac.
OS: MacOS Monterey
I tried to install using the following commands:
curl -L https://github.com/regclient/regclient/releases/latest/download/regctl-linux-arm64 >regctl
sudo chmod 755 regctl

On trying to run regctl or ./regctl, it throws the following error:
zsh: command not found: regctl

Hi @Bhashkarjya. On Mac, you want to pull the Darwin binaries rather than the Linux ones:
https://github.com/regclient/regclient/releases/latest/download/regctl-darwin-arm64

./regctl is working now. Thanks for the help.


Updates on timeseries chart

Summary

Updates in component timeseries chart card

Change List (commits, features, bugs, etc)

Custom line color
Y-axis label format for large/small values
X-axis label format for hour interval in different days
Unit on y-axis labels
New stories for use cases

:tada: This PR is included in version 1.68.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0-beta.9 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.68.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


Error compiling terminal_size in mac

.multirust/toolchains/stable/cargo/registry/src/github.com-88ac128001ac3a9a/terminal_size-0.1.1/src/unix.rs:28:29: 28:39 error: mismatched types:
expected u64,
found i32
(expected u64,
found i32) [E0308]
.multirust/toolchains/stable/cargo/registry/src/github.com-88ac128001ac3a9a/terminal_size-0.1.1/src/unix.rs:28         ioctl(STDIN_FILENO, TIOCGWINSZ, &mut winsize);

I have the same issue.
/Users/Anders/.cargo/registry/src/github.com-0a35038f75765ae4/terminal_size-0.1.1/src/unix.rs:28:29: 28:39 error: mismatched types:
 expected `u64`,
    found `i32`
(expected u64,
    found i32) [E0308]
/Users/Anders/.cargo/registry/src/github.com-0a35038f75765ae4/terminal_size-0.1.1/src/unix.rs:28         ioctl(STDIN_FILENO, TIOCGWINSZ, &mut winsize);
                                                                                ^~~~~~~~~~
/Users/Anders/.cargo/registry/src/github.com-0a35038f75765ae4/terminal_size-0.1.1/src/unix.rs:28:29: 28:39 help: run `rustc --explain E0308` to see a detailed explanation
error: aborting due to previous error
Build failed, waiting for other jobs to finish...
Could not compile `terminal_size`.

Thanks for the report!  I've pushed a fix for this, and published it to crates.io as version 0.1.4 (was previously 0.1.3)

CC https://github.com/hopey-dishwasher/termpix/pull/3


Favicon & Grid Strcutre

Clicking on for web use, there is no favicon on that webpage also I would like to structure the grid which is otherwise not fixed

Sure.


Comparison to Omnivore?

Since I believe this tool lives in the same space, would love to hear your thoughts on how this compares to the Omnivore Obsidian Integration using the obsidian-omnivore plugin.

I built this because Pocket has languished since they were acquired by Mozilla. Based on my quick browse of the Omnivore site, I would say it looks like what Pocket should have become.
Omnivore and Slurp serve similar purposes, though Omnivore is clearly more advanced. The main differences are that Omnivore is a SaaS and Mac/iOS/Android only.
With Slurp+Obsidian, you lose the advanced features like RSS and newsletter support, but gain complete cross platform support and never have to worry about a third party handling your data.
Of course, being open-source and privacy-focused, I'm confident that Omnivore maintainers can be trusted with user data but there's always the chance that the service shuts down suddenly or suffers a data breach or something along those lines. I'm personally more interested in local-first implementations and reducing our reliance on third-parties more generally.
Thanks for bringing this up! I had never heard of Omnivore before and it looks super interesting. Both the product itself as well as the general structure of an open-source by-donation SaaS. I'm going to look more deeply into this and maybe steal some of their ideas to use in Slurp ;)


Exception : "VS402625: Dates must be increasing with each revision"

Hi,
The tool is excellent, but I have some revisions not imported during the migration with the following error message :
[Microsoft.TeamFoundation.WorkItemTracking.Client.UnexpectedErrorException] Microsoft.TeamFoundation.WorkItemTracking.Client.UnexpectedErrorException: TF237121: Cannot complete the operation. An unexpected error occurred.
Technical information (for administrator):
VS402625: Dates must be increasing with each revision.
Could you help me to find a solution, or could you manage this case of error please ? (log in attachments)
wi-import-log-191209-184543.txt

@yfrindel sorry about this. Can you share a scrubbed version of the HEM-907 json file? Also are you using the latest code?

Hi @MOlausson. I've updated the program today, so yes the code is up-to-date. You'll find all the files in attachments.
JiraImport.zip
Thx

For an unknown reason, the "changedDate" value is automatically modified by Azure DevOps after the revision 4. It's maybe due to the workflow. I can fix the problem with these modifcations of code, but with this solution the changedDate are modified and so not correct.

Maybe we could check here if the changedDate of the work item is corresponding to the previous revision :
 and if it's not the case an update could be done to rectify the changedDate value ?

@yfrindel, I investigated and what I noticed right now is that there might be a state conflict that is causing Azure DevOps to modify the "change date" . Looking at the HEM-907.json then the last state change is to "Active" and the root item has the same state which shouldn't be correct. To my knowledge, the first revision should have the previous state which in this case is "Resolved" because I see only two state changes.
What happens if you export this issue once more, do you get the same JSON result that you provided us?

Hi @madkoo ,
thx for your help.
I have not the problem only with 1 work item, but with a lot of work items.
Take a look on this complete report (JSON files also added)
JiraImport2.zip
wi-import-log-191205-153246.txt

And that's the history of the ticket on JIRA :

@yfrindel  is it possible for you to provide your config file?

yes, of course
config-scrum.zip

N.B : the issue happens in the revision 5, not in the last revision

Fixed in v2.3.36.

I've also found this issue occurs if you poke around in the work items as they are being created by the importer. It seems they are updated just by looking at them.
The simple solution is to leave the project alone until the import is completed.

I've also found this issue occurs if you poke around in the work items as they are being created by the importer. It seems they are updated just by looking at them.
The simple solution is to leave the project alone until the import is completed.


refactor prop type of TouchableWithoutFeedback

Summary
I refactored prop type of TouchableWithoutFeedback
Changelog
[Internal] [Fixed] - refactor prop type of TouchableWithoutFeedback
Test Plan

Thanks! As a convention we always use Props as a type and recommend people to import those in their apps and rename them locally. This makes it easier to guess for each file which prop name to use.

Thanks for your review!
I learned it💪


add more variants in options

In general settings you can add second license (-1 in xenia config file)

in display settings add more framelimit than 144 and safe area and I mean the ability to write the fps that you needed

License mask explanation: According to the xenia wiki, you can put it to EITHER -1 or 1.
Framerate limit explanation: I've put it to 144 because I think that's what most people have. For those who want higher framerate, you can use 'Open in Editor' option and put another value, although I doubt you will reach it.

Okay

and for some reason cache and scratch creates here

That's normal

That's normal

later i changed it anyway


[Bug]: fixie-ai/ultravox-v0_4 throws Out of Memory

Your current environment

The output of `python collect_env.py`
PyTorch version: 2.6.0.dev20240918+rocm6.2
Is debug build: False
CUDA used to build PyTorch: N/A
ROCM used to build PyTorch: 6.2.41133-dd7f95766

OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: 18.0.0git (https://github.com/RadeonOpenCompute/llvm-project roc-6.2.0 24292 26466ce804ac523b398608f17388eb6d605a3f09)
CMake version: version 3.26.4
Libc version: glibc-2.31

Python version: 3.9.19 (main, May  6 2024, 19:43:03)  [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-117-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: Could not collect
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: AMD Instinct MI100 (gfx908:sramecc+:xnack-)
Nvidia driver version: Could not collect
cuDNN version: Could not collect
HIP runtime version: 6.2.41133
MIOpen runtime version: 3.2.0
Is XNNPACK available: True

CPU:
Architecture:                         x86_64
CPU op-mode(s):                       32-bit, 64-bit
Byte Order:                           Little Endian
Address sizes:                        48 bits physical, 48 bits virtual
CPU(s):                               16
On-line CPU(s) list:                  0-15
Thread(s) per core:                   1
Core(s) per socket:                   16
Socket(s):                            1
NUMA node(s):                         1
Vendor ID:                            AuthenticAMD
CPU family:                           25
Model:                                1
Model name:                           AMD EPYC 7713 64-Core Processor
Stepping:                             1
CPU MHz:                              2000.000
BogoMIPS:                             4000.00
Virtualization:                       AMD-V
Hypervisor vendor:                    KVM
Virtualization type:                  full
L1d cache:                            1 MiB
L1i cache:                            1 MiB
L2 cache:                             8 MiB
L3 cache:                             16 MiB
NUMA node0 CPU(s):                    0-15
Vulnerability Gather data sampling:   Not affected
Vulnerability Itlb multihit:          Not affected
Vulnerability L1tf:                   Not affected
Vulnerability Mds:                    Not affected
Vulnerability Meltdown:               Not affected
Vulnerability Mmio stale data:        Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed:               Not affected
Vulnerability Spec rstack overflow:   Mitigation; safe RET
Vulnerability Spec store bypass:      Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:             Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:             Mitigation; Retpolines; IBPB conditional; IBRS_FW; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds:                  Not affected
Vulnerability Tsx async abort:        Not affected
Flags:                                fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm rep_good nopl cpuid extd_apicid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw perfctr_core invpcid_single ssbd ibrs ibpb stibp vmmcall fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr wbnoinvd arat npt lbrv nrip_save tsc_scale vmcb_clean flushbyasid pausefilter pfthreshold v_vmsave_vmload vgif umip pku ospke vaes vpclmulqdq rdpid fsrm arch_capabilities

Versions of relevant libraries:
[pip3] mypy==1.8.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] optree==0.9.1
[pip3] pytorch-triton-rocm==3.1.0+5fe38ffd73
[pip3] pyzmq==26.2.0
[pip3] torch==2.6.0.dev20240918+rocm6.2
[pip3] torchvision==0.20.0.dev20240918+rocm6.2
[pip3] transformers==4.46.0
[pip3] triton==3.0.0
[conda] No relevant packages
ROCM Version: 6.2.41133-dd7f95766
Neuron SDK Version: N/A
vLLM Version: 0.6.3.post2.dev116+g55137e8e.d20241029
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
============================ ROCm System Management Interface ============================
================================ Weight between two GPUs =================================
       GPU0         GPU1         GPU2         GPU3         GPU4         GPU5         GPU6         GPU7
GPU0   0            15           15           15           40           40           40           40
GPU1   15           0            15           15           40           40           40           40
GPU2   15           15           0            15           40           40           40           40
GPU3   15           15           15           0            40           40           40           40
GPU4   40           40           40           40           0            15           15           15
GPU5   40           40           40           40           15           0            15           15
GPU6   40           40           40           40           15           15           0            15
GPU7   40           40           40           40           15           15           15           0

================================= Hops between two GPUs ==================================
       GPU0         GPU1         GPU2         GPU3         GPU4         GPU5         GPU6         GPU7
GPU0   0            1            1            1            2            2            2            2
GPU1   1            0            1            1            2            2            2            2
GPU2   1            1            0            1            2            2            2            2
GPU3   1            1            1            0            2            2            2            2
GPU4   2            2            2            2            0            1            1            1
GPU5   2            2            2            2            1            0            1            1
GPU6   2            2            2            2            1            1            0            1
GPU7   2            2            2            2            1            1            1            0

=============================== Link Type between two GPUs ===============================
       GPU0         GPU1         GPU2         GPU3         GPU4         GPU5         GPU6         GPU7
GPU0   0            XGMI         XGMI         XGMI         PCIE         PCIE         PCIE         PCIE
GPU1   XGMI         0            XGMI         XGMI         PCIE         PCIE         PCIE         PCIE
GPU2   XGMI         XGMI         0            XGMI         PCIE         PCIE         PCIE         PCIE
GPU3   XGMI         XGMI         XGMI         0            PCIE         PCIE         PCIE         PCIE
GPU4   PCIE         PCIE         PCIE         PCIE         0            XGMI         XGMI         XGMI
GPU5   PCIE         PCIE         PCIE         PCIE         XGMI         0            XGMI         XGMI
GPU6   PCIE         PCIE         PCIE         PCIE         XGMI         XGMI         0            XGMI
GPU7   PCIE         PCIE         PCIE         PCIE         XGMI         XGMI         XGMI         0

======================================= Numa Nodes =======================================
GPU[0]          : (Topology) Numa Node: 0
GPU[0]          : (Topology) Numa Affinity: -1
GPU[1]          : (Topology) Numa Node: 0
GPU[1]          : (Topology) Numa Affinity: -1
GPU[2]          : (Topology) Numa Node: 0
GPU[2]          : (Topology) Numa Affinity: -1
GPU[3]          : (Topology) Numa Node: 0
GPU[3]          : (Topology) Numa Affinity: -1
GPU[4]          : (Topology) Numa Node: 0
GPU[4]          : (Topology) Numa Affinity: -1
GPU[5]          : (Topology) Numa Node: 0
GPU[5]          : (Topology) Numa Affinity: -1
GPU[6]          : (Topology) Numa Node: 0
GPU[6]          : (Topology) Numa Affinity: -1
GPU[7]          : (Topology) Numa Node: 0
GPU[7]          : (Topology) Numa Affinity: -1
================================== End of ROCm SMI Log ===================================

Model Input Dumps
No response
🐛 Describe the bug
When I try to deploy the model, it throws OOM:
vllm serve fixie-ai/ultravox-v0_4 --tensor-parallel-size 2 --max-model-len 120000 --trust-remote-code

(VllmWorkerProcess pid=35734) INFO 11-06 17:51:01 model_runner.py:1066] Loading model weights took 8.1626 GB
INFO 11-06 17:51:01 model_runner.py:1066] Loading model weights took 8.1626 GB
(VllmWorkerProcess pid=35734) /opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/linear.py:125: UserWarning: Attempting to use hipBLASLt on an unsupported architecture! Overriding blas backend to hipblas (Triggered internally at ../aten/src/ATen/Context.cpp:288.)
(VllmWorkerProcess pid=35734)   return F.linear(input, self.weight, self.bias)
(VllmWorkerProcess pid=35734) INFO 11-06 17:51:06 model_runner_base.py:120] Writing input of failed execution to /tmp/err_execute_model_input_20241106-175106.pkl...
/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/linear.py:125: UserWarning: Attempting to use hipBLASLt on an unsupported architecture! Overriding blas backend to hipblas (Triggered internally at ../aten/src/ATen/Context.cpp:288.)
  return F.linear(input, self.weight, self.bias)
INFO 11-06 17:51:07 model_runner_base.py:120] Writing input of failed execution to /tmp/err_execute_model_input_20241106-175107.pkl...
(VllmWorkerProcess pid=35734) INFO 11-06 17:51:07 model_runner_base.py:149] Completed writing input of failed execution to /tmp/err_execute_model_input_20241106-175106.pkl.
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229] Exception in worker VllmWorkerProcess while processing method determine_num_available_blocks.
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229] Traceback (most recent call last):
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/worker/model_runner_base.py", line 116, in _wrapper
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return func(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/worker/model_runner.py", line 1657, in execute_model
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     hidden_or_intermediate_states = model_executable(
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return self._call_impl(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return forward_call(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 468, in forward
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     audio_embeddings = self._process_audio_input(audio_input)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 420, in _process_audio_input
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     flattened_embeddings = self._audio_features_to_embeddings(
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 380, in _audio_features_to_embeddings
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     audio_features = self.audio_tower(audio_input)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return self._call_impl(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return forward_call(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 320, in forward
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     layer_outputs = encoder_layer(
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return self._call_impl(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return forward_call(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/models/whisper/modeling_whisper.py", line 618, in forward
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     hidden_states, attn_weights, _ = self.self_attn(
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return self._call_impl(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return forward_call(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/models/whisper/modeling_whisper.py", line 545, in forward
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     attn_output = torch.nn.functional.scaled_dot_product_attention(
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229] torch.OutOfMemoryError: HIP out of memory. Tried to allocate 34.33 GiB. GPU 1 has a total capacity of 31.98 GiB of which 10.55 GiB is free. Of the allocated memory 20.23 GiB is allocated by PyTorch, and 784.37 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_HIP_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229] The above exception was the direct cause of the following exception:
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229] Traceback (most recent call last):
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/executor/multiproc_worker_utils.py", line 223, in _run_worker_process
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     output = executor(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return func(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/worker/worker.py", line 223, in determine_num_available_blocks
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     self.model_runner.profile_run()
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return func(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/worker/model_runner.py", line 1304, in profile_run
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     self.execute_model(model_input, kv_caches, intermediate_tensors)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     return func(*args, **kwargs)
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]   File "/vllm-workspace/vllm/worker/model_runner_base.py", line 152, in _wrapper
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229]     raise type(err)(
(VllmWorkerProcess pid=35734) ERROR 11-06 17:51:07 multiproc_worker_utils.py:229] torch.OutOfMemoryError: Error in model execution (input dumped to /tmp/err_execute_model_input_20241106-175106.pkl): HIP out of memory. Tried to allocate 34.33 GiB. GPU 1 has a total capacity of 31.98 GiB of which 10.55 GiB is free. Of the allocated memory 20.23 GiB is allocated by PyTorch, and 784.37 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_HIP_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)
INFO 11-06 17:51:07 model_runner_base.py:149] Completed writing input of failed execution to /tmp/err_execute_model_input_20241106-175107.pkl.
Process SpawnProcess-1:
ERROR 11-06 17:51:07 multiproc_worker_utils.py:116] Worker VllmWorkerProcess pid 35734 died, exit code: -15
INFO 11-06 17:51:07 multiproc_worker_utils.py:120] Killing local vLLM worker processes
Traceback (most recent call last):
  File "/vllm-workspace/vllm/worker/model_runner_base.py", line 116, in _wrapper
    return func(*args, **kwargs)
  File "/vllm-workspace/vllm/worker/model_runner.py", line 1657, in execute_model
    hidden_or_intermediate_states = model_executable(
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
    return forward_call(*args, **kwargs)
  File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 468, in forward
    audio_embeddings = self._process_audio_input(audio_input)
  File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 420, in _process_audio_input
    flattened_embeddings = self._audio_features_to_embeddings(
  File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 380, in _audio_features_to_embeddings
    audio_features = self.audio_tower(audio_input)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
    return forward_call(*args, **kwargs)
  File "/vllm-workspace/vllm/model_executor/models/ultravox.py", line 320, in forward
    layer_outputs = encoder_layer(
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/models/whisper/modeling_whisper.py", line 618, in forward
    hidden_states, attn_weights, _ = self.self_attn(
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl
    return forward_call(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/transformers/models/whisper/modeling_whisper.py", line 545, in forward
    attn_output = torch.nn.functional.scaled_dot_product_attention(
torch.OutOfMemoryError: HIP out of memory. Tried to allocate 34.33 GiB. GPU 0 has a total capacity of 31.98 GiB of which 10.12 GiB is free. Of the allocated memory 20.23 GiB is allocated by PyTorch, and 784.37 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_HIP_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/conda/envs/py_3.9/lib/python3.9/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/opt/conda/envs/py_3.9/lib/python3.9/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/vllm-workspace/vllm/engine/multiprocessing/engine.py", line 397, in run_mp_engine
    engine = MQLLMEngine.from_engine_args(engine_args=engine_args,
  File "/vllm-workspace/vllm/engine/multiprocessing/engine.py", line 147, in from_engine_args
    return cls(ipc_path=ipc_path,
  File "/vllm-workspace/vllm/engine/multiprocessing/engine.py", line 83, in __init__
    self.engine = LLMEngine(*args, **kwargs)
  File "/vllm-workspace/vllm/engine/llm_engine.py", line 352, in __init__
    self._initialize_kv_caches()
  File "/vllm-workspace/vllm/engine/llm_engine.py", line 489, in _initialize_kv_caches
    self.model_executor.determine_num_available_blocks())
  File "/vllm-workspace/vllm/executor/distributed_gpu_executor.py", line 39, in determine_num_available_blocks
    num_blocks = self._run_workers("determine_num_available_blocks", )
  File "/vllm-workspace/vllm/executor/multiproc_gpu_executor.py", line 192, in _run_workers
    driver_worker_output = driver_worker_method(*args, **kwargs)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/vllm-workspace/vllm/worker/worker.py", line 223, in determine_num_available_blocks
    self.model_runner.profile_run()
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/vllm-workspace/vllm/worker/model_runner.py", line 1304, in profile_run
    self.execute_model(model_input, kv_caches, intermediate_tensors)
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/vllm-workspace/vllm/worker/model_runner_base.py", line 152, in _wrapper
    raise type(err)(
torch.OutOfMemoryError: Error in model execution (input dumped to /tmp/err_execute_model_input_20241106-175107.pkl): HIP out of memory. Tried to allocate 34.33 GiB. GPU 0 has a total capacity of 31.98 GiB of which 10.12 GiB is free. Of the allocated memory 20.23 GiB is allocated by PyTorch, and 784.37 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_HIP_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)
[rank0]:[W1106 17:51:08.187078063 ProcessGroupNCCL.cpp:1250] Warning: WARNING: process group has NOT been destroyed before we destruct ProcessGroupNCCL. On normal program exit, the application should call destroy_process_group to ensure that any pending NCCL operations have finished in this process. In rare cases this process can exit before this point and block the progress of another member of the process group. This constraint has always been present,  but this warning has only been added since PyTorch 2.4 (function operator())
Traceback (most recent call last):
  File "/opt/conda/envs/py_3.9/bin/vllm", line 33, in <module>
    sys.exit(load_entry_point('vllm', 'console_scripts', 'vllm')())
  File "/vllm-workspace/vllm/scripts.py", line 195, in main
    args.dispatch_function(args)
  File "/vllm-workspace/vllm/scripts.py", line 41, in serve
    uvloop.run(run_server(args))
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/uvloop/__init__.py", line 82, in run
    return loop.run_until_complete(wrapper())
  File "uvloop/loop.pyx", line 1518, in uvloop.loop.Loop.run_until_complete
  File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/uvloop/__init__.py", line 61, in wrapper
    return await main
  File "/vllm-workspace/vllm/entrypoints/openai/api_server.py", line 552, in run_server
    async with build_async_engine_client(args) as engine_client:
  File "/opt/conda/envs/py_3.9/lib/python3.9/contextlib.py", line 181, in __aenter__
    return await self.gen.__anext__()
  File "/vllm-workspace/vllm/entrypoints/openai/api_server.py", line 107, in build_async_engine_client
    async with build_async_engine_client_from_engine_args(
  File "/opt/conda/envs/py_3.9/lib/python3.9/contextlib.py", line 181, in __aenter__
    return await self.gen.__anext__()
  File "/vllm-workspace/vllm/entrypoints/openai/api_server.py", line 194, in build_async_engine_client_from_engine_args
    raise RuntimeError(
RuntimeError: Engine process failed to start

The model was working on a previous commit (08287ef6751e79a89bf4f060f5f9545560a6de12).
Is it because whisper and llama are trying be placed on the same GPU (this also doesn't work for tensor parallel size 4)? If so, where would be the part that can be tweaked for those to be scheduled to separate GPUs (if that is possible)?
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

@youkaichao would the recent changes to torch.compile affect memory usage?

torch.compile is not enabled by default. we have all the wheels for every commit, and you can bisect to find which one caused the problem, see https://docs.vllm.ai/en/latest/getting_started/installation.html#install-the-latest-code


[PE-D] Some hyperlinks in UG don't seem to work

The hyperlink at marked does not direct users to the right section (opening it in a separate tab leads to the beginning of the UG).

Labels: severity.VeryLow type.DocumentationBug
original: honganhcs/ped#5

header name for mark changed, we gotta fix that


Minikube can also be installed with winget

This is a Feature Request

What would you like to be added

I could not find a way of making a pull request as the pencil on https://k8s-docs.netlify.app/en/docs/tasks/tools/install-minikube/ sent me to a nonexisting ref

Please add that winget install minikube also works as an installation method on Windows and that is probably preferred so winget can keep it up-to-date.
Why is this needed
Make it easier to get it installed
Comments

@per-oestergaard The link shared in the issue appears to be different from the official Kubernetes document site link. The official site has install page at"https://kubernetes.io/docs/tasks/tools/"  which points to an installation guide in the minikube docs "https://minikube.sigs.k8s.io/docs/start/", there I can see it already has option to install via winget.

/priority awaiting-more-evidence


Misc reflection

Lot's of small changes and fixes (mostly reflection).

Name for GenericParameter match .Net (both positional and type) - fix #509
System.Reflection.Runtime* types added.
System.Reflection.RuntimeMethodInfo.GetParentDefinition implemented
Array.Empty(), Array.UnsafeCreateInstance(...)
Implemented hiding for Properties/Events/Constructors (reflection).
SemaphoreSlim added to BclProxies as it was added to javascript implentation
Assembly.Load implemented.
RuntimeType.op_Equality implemented
Thread.MemoryBarrier
MethodInfo.GetBaseDefinition and test added.
MemberInfo.get_IsPrivate
Enum.ToObject fixed and additional signature added.
Type.GetProperty additional override added (still need proper implementation)
Use BCL implementation for System.Attribute with translated BCL (only for .Net, don't work with mono for now. Removed null-returning Attribute method from JS implementation.
Enum.GetUnderlyingType added.
Char.IsNumber added.
JSIL.StringFromCharArray with passed length implementation fixed.
MethodBase.IsConstructor and MethodInfo.IsVirtual added.
Type.EmptyTypes added (with hack - it's property, not field.)
Array marked as IEnumerable (part of #846).
Array objects type is object[] now (fix #847, test added).
Workaround for #844. Still should be investigated more. Test added.
Sting.Length added (reflection compatibility).

Don't understand why it have failed on AppVeyor. Probably threading issue on JSIL.mscorlib translation? It passed in my repo.
@kg, please run AppVeyor tests again.

Yeah, it looks like the codegen for the stubbed mscorlib was wrong somehow? However, it's an erroneous reference to an undeclared var, which is weird for stubbed code...

BTW, if you'll review/merge #859 and register yandex.disk we'll have artifacts after each build for investigation (at least for travis, but I may add same script for AppVeyor also).

Hi, I am new to JSIL and GIT so this could be a rookie question.  I've run into this problem:
The external method 'System.Object ToObject(System.Type, System.Object)' of type 'System.Enum' has not been implemented.
Can you advise if this is meant to be implemented and available?  One of the points in the topmost comment above is 'Enum.ToObject fixed and additional signature added.'

@callanh, you have three options:

Wait until that PR will be merged (I hope not too long)
Checkout any version after 4551dda60a37a1e6f3b1bdc8da79f165ba379183 from my fork
Apply change from 4551dda60a37a1e6f3b1bdc8da79f165ba379183  to version that you have already manually (probably easiest way)


[API] workspace endpoint should allow to filter by folder

Feature description 💡
Since the GitHub Action is based on changed files/dirs, the API should allow to find (get) a workspace by filtering by folder
Anything else?
Currently the API answer is
{"errors":[{"detail":"Invalid query parameter: filter[workspace]\nFilter expression is not in expected format at: folder=workspace/dir/path"}]}

My bad, I checked the wrong URI. Sorry for the noise


Component doesn't render new useAnimatedProps

Hi @JonnyBurger !
I have issue with component and the problem with that when I pass new animated props (which depends from useDerivedValue hook) in component - the changes does not displayed.
The changes displaying only when I update derived value one more time.
Versions:
react native: 0.66
reanimated: 2.7.0
react-native-animateable-text: 0.8.2

Maybe related issue:
https://github.com/software-mansion/react-native-reanimated/issues/3244

By the way:

with redash ReText component everything works fine. I checked.
fresh SharedValue comes every time in useAnimatedProps hook.
There are the same problem with styles which calculated with useAnimatedStyles hook and passed to this component.

So, after a lot of time to debugging I decided that is the problem with this component.
Thanks!

Hi @JonnyBurger !
I have issue with component and the problem with that when I pass new animated props (which depends from useDerivedValue hook) in component - the changes does not displayed.
The changes displaying only when I update derived value one more time.
Versions: react native: 0.66 reanimated: 2.7.0 react-native-animateable-text: 0.8.2

Have you figured out the issue yet? And how to solve? I'm experiencing the same.

@mBarlescu Hi!
I just changed values with setTimeout with 0 timer

I fixed it by not using this package but rather using <TextInput editable={false} ref={textRef}/> and textRef.current.setNativeProps as explained here in the docs.
Also, this package appears to be heavy just animating text, 20MB unpacked size


Applications moves to wrong layout when it opens first time.

Microsoft PowerToys version
0.63.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
I have two monitors with below info:
Monitor 1 - primary - has a layout  (divided on 3) and laptop monitor with a layout of 1 (or no divisions).
I have the option that "Move newly created windows to their last known zone" and have been using this settings for around two months and yesterday the issue started happening.

Open any program and move it outside any layout.
Minimize or close it.
At the time maximize or open, it goes to the LAPTOP screen automatically.

✔ Expected Behavior
The expected behavior is that opened/maximize windows goes to the last know position and not moving to the Laptop Layout.
❌ Actual Behavior
Programs going to the laptop layout at the time of maximize or open any program.
Other Software
none

Is this issue still relevant in v0.73? /needinfo


[ttGlyphSet] Refactor/rebuild class hierarchy

only differentiate between glyf and CFF/CFF2 implementations, not var vs non-var
use collections.abc.Mapping to get a more consistent dict-like object with less code
prefer HVAR metrics over gvar metrics
move some responsibilities from the _TTGlyphSet objects to the _TTGlyph objects
adjust some tests to the changes

I think I'm done fiddling now. I added TTFont.normalizeLocation() as a public method, as I expect it to be generally useful.

This broke a lot of software. Deprecation would have been helpful.


Prepend openapi! in any case

If you run tests with Minitest at the moment, but without the environment variable OPENAPI, you are greeted with an error message.
undefined method `openapi!' for Api::V0::SomeControllerTest:Class (NoMethodError)`

This is because the current code adds the openapi! method only if OPENAPI environment variable is set.
This commit modifies the loading logic, always requiring the minitest hooks class to be loaded if Minitest constant is defined, to avoid issues with RSpec. Then, the openapi? and openapi! methods are always prepended to Minitest::Test, while the modified run method and the after_run hook are only activated when OPENAPI environment variable is set.

Thanks. Makes sense to me.


modem: hl7800: disable format-truncation on snprintk

GCC format-truncation kicks in on this printk whenever the logging configuration transforms the LOG_WRN below into a noop, and the snprintk return argument become unused.
Fix that by explicitly disable the warning, fixes:
zephyrproject/zephyr/drivers/modem/hl7800.c:1786:74: warning: '%s' directive output may be truncated writing up to 53 bytes into a region of size 21 [-Wformat-truncation=]
reproduced with:
west build -p -b mg100 -T samples/net/telnet/sample.net.telnet

I wonder if this has anything to do with the log prints. It's only the snprintk, that produces the warning. And apparently the compiler does not realize that snprint[f|k] (in contrast to sprint[f|k]) makes sure the string does not overflow.
Thus, disabling the warning seems ok. But I'm not sure if I understand the comment and reasoning correctly.

This is what I found: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html:
    Level 1 of -Wformat-truncation enabled by -Wformat employs a conservative approach that warns only about calls to bounded functions whose return value is unused and that will most likely result in output truncation.

so the trigger seems to be the fact that the return value is unused, I don't think it's about the compiler not understanding that the string cannot overflow, it's just trying to make sure that the overflow is handled somehow.

Ah, you are right, the warning is gone if I replace the LOG_WRN with printk. So suppression of the warning seems to be the only viable solution.

Ah, you are right, the warning is gone if I replace the LOG_WRN with printk. So suppression of the warning seems to be the only viable solution.

Yeah, could not think of any more creative way of convincing GCC that that's used.

Change to use an strncpy instead, that's explicit enough to keep the compiler happy, hopefully I got the termination right.

LGTM. So many more lines of code just to outsmart the compiler...

To be honest I'm half thinking of going back to the pragma override, snprintk was doing just what we wanted. Up to you folks really, I just want the build to pass with no warnings.

@rerickson1 what do you think? Trying to get this out before the next CI pass

@rerickson1 what do you think? Trying to get this out before the next CI pass

Ship it!


update meta not working

Hi, I have implemented this into my angularjs app however, the update-meta tag is not working, it does not update my meta tags.
It is weird because update-title works, only the update-meta dosent work.
Help would be much appreciated.
Thanks

@sunnyg1210 — Can you please post your code? Or even better: can you create a plunk on plnkr.co with your code? Thanks!

Here is my code:
The Index file:
<html lang="en" data-ng-app="app">
<head>
	<meta charset="utf-8">
	<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
	<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />
	<meta property="og:title" content="My Blog Post" />
	<meta property="og:type" content="article" />
	<meta property="og:url" content="https://example.com" />
	<meta property="og:image" content="https://example.com/test.jpg" />
	<meta property="og:description" content="Initial Description" />
	<meta name="locale" content="en_US">
	<meta name="description" content="Global Description">
	<title data-ng-bind="pageTitle()">My App</title>

View File:
<div class="landing-page" ng-controller="landingBlogSingleCtrl">
  <!-- START META TAGS -->
  <update-title title="{{post.title.rendered}} | Blog"></update-title>
  <update-meta name="description" content="{{post.excerpt.rendered}}"></update-meta>
  <update-meta property="og:title" content="{{post.title.rendered}}"></update-meta>
  <update-meta property="og:image" content="{{post.better_featured_image.source_url}}"></update-meta>
  <update-meta property="og:type" content="article" /></update-meta>
  <update-meta property="og:url" content="{{post.link}}" /></update-meta>
  <update-meta property="og:description" content="{{post.excerpt.rendered}}" /></update-meta>
  <!-- END META TAGS -->

Thats the major part of the code relating to this plugin. Like I mentioned before, the update-title tag works fine, only the update meta dosent work.
Thanks again for helping.

@sunnyg1210 — I have created a working plunk for you here.
If you inspect the <head> element using Chrome DevTools, you should see something similar to the screenshot attached.

Can you let me know if it works for you? Thanks!

HI,
No it still dosent work, I am getting the same problem as before.
Here is my live site link that I update-meta has been implemented into with the same variables as mentioned above. As you can see the title is updated but not the meta tags.
link to live site

@sunnyg1210 — Which file contains the update-meta elements?
I'm looking at the source of https://go-mac.com/#/app/home but I can't find any update-meta elements.
Thanks!

the update meta is not in the Home page,
it is in this view: https://go-mac.com/#/app/blog/view/0
this is for the blog post when they get shared socially etc.

@sunnyg1210 — Seems to work as expeceted when I inspect it using Chrome DevTools (see how the elements are updated in the animated gif below):

Are you seeing something different?

Thats really wierd, maybe something wrong on my computer. Sorry about that. Will check again on my side

@sunnyg1210 — No problem, I will close the issue for now. Feel free to re-open it if needed. Thanks!


EnableECSCluster -> EnableECS

Change description
Fix enabling ecs cluster
Type of change

[x] Bug fix (fixes an issue)
[ ] New feature (adds functionality)

Testing
See Task DUPLO-9795
Checklists
Development

[ ] Pull requests may not be submitted to the master branch (use develop instead) - or they will be closed.
[ ] Lint rules pass locally
[ ] Application changes have been tested thoroughly
[ ] Automated tests covering modified code pass

Security

[ ] Security impact of change has been considered
[ ] Code follows company security practices and guidelines

Code review

[ ] Pull request has a descriptive title and context useful to a reviewer.
[ ] "Ready for review" label attached and reviewers assigned
[ ] Changes have been reviewed by at least one other contributor
[ ] Pull request linked to task tracker where applicable

Task linked: DUPLO-9795 TF: Enabling ECS post apply does not work


Why did we do 2 req for basically the same thing? FIA_X509_EXT.2.1 &  FIA_X509_EXT.2.2

http://common-criteria.rhcloud.com/operatingsystem/output/operatingsystem-release.html#FIA_X509_EXT.2.1
http://common-criteria.rhcloud.com/operatingsystem/output/operatingsystem-release.html#FIA_X509_EXT.2.2
In the App PP we have 1 req for this and we made it a selection?
The application shall use X.509v3 certificates as defined by RFC 5280 to support authentication for [selection: HTTPS , TLS , DTLS ] .
In OS could we do just 1 requirement that is sel-based on FTP_ITC_EXT.1.1
The OS shall use X.509v3 certificates as defined by RFC 5280 to support authentication for [selection: TLS , DTLS ] connections.
The MDF PP also only has 1 req for this: It is
FIA_X509_EXT.2.1 The TSF shall use X.509v3 certificates as defined by RFC 5280 to
support authentication for EAP-TLS exchanges, and [selection: IPsec, TLS, HTTPS, DTLS]],
and [selection: code signing for system software updates, code signing for mobile
applications, code signing for integrity verification, [assignment: other uses], no additional
uses].

Elements merged.


Added introductory description comments to DSLX adder example

These are just comments, and I checked that this works on google colab. @proppy

@proppy Thanks for the comments. Finished modifications based on them. (sorry that the commits are kind of messy...couldn't squash them further because some merges were mixed...)


Backporting plans

I might plan on backporting the mod to previous patch version of Minecraft if there are enough demands (and I have the time to do so).
Forge port is not possible. I will have to remake this mod for forge eco-system (since there are some build projects still stuck at 1.12.2), if there are demands and I have the time and mean to do so.

Backported to 1.19.2.

1.20.1 ?

1.20.1 ?

Sure, I will look into it.

1.20.1 ?

Could you try updating your version to 1.20.2? 1.20.1 has so much problem that I am unable to fix.

1.20.1 ?

I am unable to port back to 1.20.1 due to technical issues so 1.20.2 is the least version I could backport to.

I won’t be doing any backporting anymore as there are like 2-3 versions to maintain at the moment.
Feel free to fork and do backport yourself if you want to.

More people are requesting for 1.20.1 port so I might need to do it now.

It's impossible anymore! EasyFind has been ported to 1.20.1 now! 🎉


ARROW-86: [Python] Implement zero-copy Arrow-to-Pandas conversion

We can create zero-copy NumPy arrays for floats and ints if we have no
nulls. Each numpy-arrow-view has a reference to the underlying column to
ensure that the Arrow structure lives at least as long as the newly
created NumPy array.

Performance benchmarks confirm that we do not allocate any additional RAM and the time to convert Arrow->Pandas drops by 50% but still seeing a dependency between size and runtime. So it is zero-copy but still not zero non-constant overhead.

Benchmark results for to_pandas. For int64 and float64, we have zero-copy, the other two are copied.
               ========== ========= ========== ============== ==========
               --                             dtype
               ---------- ----------------------------------------------
                  size      int64    float64    float64_nans     str
               ========== ========= ========== ============== ==========
                   1        1.02ms   953.53μs     843.33μs      1.05ms
                 100000     1.01ms    1.02ms       3.33ms      22.15ms
                1000000     3.90ms    3.76ms      26.29ms      179.65ms
                10000000   71.82ms   71.40ms      287.06ms      1.67s
               ========== ========= ========== ============== ==========

Can you rebase? I'll review this soon

lgtm, thank you


Seeking forward issues

Describe the bug
I've noticed this issue in rooms with more than 3 clients. When a client seeks to a position ahead of the other clients. It will revert back. However seeking to a position behind the other clients position doesn't result in the same behavior
To Reproduce
Steps to reproduce the behavior:

Connect 3 participants to the same server.
Load in the same file.
Seek forward in one of the clients. The other clients will seek to that point for a few seconds and then revert back to the original position with the reason being "Re winded due to time difference between X". Then the client that was used to seek in the first place will also return to the same, original position with the same reason.

Expected behavior
When one client seeks, all clients should seek to the same position and play from there
Version and platform:

Windows 10 20H2
Syncplay Version 1.6.8

Additional context
I've noticed the same behavior from my own client, which leads me to believe that the issue lies in the server

I haven't seen this issue at all with 4-6 user sessions I typically have.
From really quite long time ago I recall that something like this did happen when at least one of the people watching had their player react extremely slowly due to very slow disk drive they used. I imagine this could also happen if your video is being streamed over network (youtube, personal server, networked drive etc). Is any of those things applicable to any of the participants?

Hey, sorry about the late reply. And no, Im playing a local file and its stored on an SSD. Is it possible that this might happen when the clients are corrected to the same local network?

Being on the same network should result in lower lateness and hence even lower likelihood of "sticky seeks". Only situation where network could be causing issues is if it's a connection with extremely high jitter like 3g GSM modem on cusp of losing reception.
What video players are you using? Could you test whether the behavior persists if all clients are using mpv? That should help in narrowing down the issue.

I just tested it again with 4 clients. All in their own LANs at different parts of the country. Still facing the same issue. We're all using VLC as the media player. But then again the player does warn about VLC

I guess I'll close this issue then

Yes, I think it's a good guess that it is a VLC issue. Basically, VLC is not very reliable in terms of accurately reporting its position so Syncplay has to make its best guess which is not always current and so sometimes causes problems. We recommend people use mpv because it works better with Syncplay.


Remove unnecessary using declarations.

Signed-off-by: Henner Zeller<EMAIL_ADDRESS>

Codecov Report

Merging #1153 (21ab71f) into master (a3b5bed) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   92.85%   92.83%   -0.02%
==========================================
  Files         337      337
  Lines       22565    22577      +12
==========================================
+ Hits        20953    20960       +7
- Misses       1612     1617       +5

Impacted Files
Coverage Δ

verilog/analysis/verilog_analyzer.cc
96.40% <ø> (ø)

verilog/preprocessor/verilog_preprocess.cc
87.28% <ø> (ø)

common/formatting/layout_optimizer.cc
94.29% <0.00%> (-1.29%)
:arrow_down:

verilog/formatting/formatter.cc
94.07% <0.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b5bed...21ab71f. Read the comment docs.


Update Dockerfile and image for prombench

In addition to some changes done recently, another change that is needed in the prombench Dockerfile is that Makefile now includes Makefile.common which uses the go binary.
https://github.com/prometheus/prombench/blob/7d2e3503af0ea3f47561d4b5c6f4837973146f3e/Makefile#L3
https://github.com/prometheus/prombench/blob/7d2e3503af0ea3f47561d4b5c6f4837973146f3e/Makefile.common#L35
So we probably need to add a base image that has the go binary in it, otherwise install go in the current base image inside the Dockerfile.
Current Dockerfile also do not contain Makefile.common which breaks make but not having go installed in the base image just prints warnings and does not break make

which target requires the go binary?
Also the current Dockerfile looks quite bad. We need to use multistage build to build prombench at one stage and just use the binary in another.
Not even sure why we need these:
https://github.com/prometheus/prombench/blob/7d2e3503af0ea3f47561d4b5c6f4837973146f3e/cmd/prombench/Dockerfile#L8-L10


CHORE: Support python 3.13

Support 3.13
Update main python for ci/cd

@RobPasMue, @ansys/pymechanical-maintainers . Will keep this as draft till pythonnet start supporting 3.13

We should reach out to them..


options changed in AddAuthenticationCookie does not work even placed after AddIdentity

In my project, I need to use AddIdentity, and I want the api to return 401 if not authorized, so in AddAuthenticationCookie I did some configurations as discribed in #389, but it does not working, still using the default cookie autientication schema. But if I don't use AddAuthenticationCookie and use ConfigureApplicationCookie, then it works:
builder.Services.ConfigureApplicationCookie(options =>
{
    options.Cookie.Name = "xxx;
    options.Cookie.HttpOnly = true;
    options.LoginPath = new PathString("/xxxxxx");
    options.Events = new CookieAuthenticationEvents
    {
        OnRedirectToLogin = ctx =>
        {
            ctx.Response.StatusCode = 401;

            return Task.CompletedTask;
        },
        OnRedirectToAccessDenied = ctx =>
        {
            ctx.Response.StatusCode = 403;

            return Task.CompletedTask;
        },
        OnRedirectToReturnUrl = context =>
        {
            context.Response.StatusCode = StatusCodes.Status401Unauthorized;
            return Task.CompletedTask;
        }
    };

    options.SlidingExpiration = true;
});

Is the behavior expected or can be improved?

AddAuthenticationCookie() is simply a wrapper method for quickly configuring basic cookie authentication. it's not meant to be used with identity, as identity sets cookies up in a different manner. so just configure identity as you typically do.


[Bug]: Camera does not animate in expo web app

Mapbox Implementation
Maplibre
Mapbox Version
11.4.0
React Native Version
0.76.1
Platform
Android
@rnmapbox/maps version
10.1.33
Standalone component to reproduce
import React from 'react';
import { Alert, Platform } from 'react-native';
import Mapbox from '@rnmapbox/maps';
import { ButtonGroup } from '@rneui/base';

Mapbox.setAccessToken("pk.eyJ1IjoiZHV...");

const layerStyles = {
  building: {
    fillExtrusionColor: '#aaa',

    fillExtrusionHeight: [
      'interpolate',
      ['linear'],
      ['zoom'],
      15,
      0,
      15.05,
      ['get', 'height'],
    ],

    fillExtrusionBase: [
      'interpolate',
      ['linear'],
      ['zoom'],
      15,
      0,
      15.05,
      ['get', 'min_height'],
    ],

    fillExtrusionOpacity: 0.6,
  },
};

const styles = {
  matchParent: { flex: 1 },
};

class FlyTo extends React.Component {
  static SF_OFFICE_LOCATION = [-122.400021, 37.789085];

  static DC_OFFICE_LOCATION = [-77.036086, 38.910233];

  static ZERO_ZERO = [0, 0];
  static ZERO_TEN = [0, 10];
  static TEN_ZERO = [10, 0];

  constructor(props) {
    super(props);

    this.state = {
      location: FlyTo.SF_OFFICE_LOCATION,
    };

    this._flyToOptions = [
      { label: 'SF', data: FlyTo.SF_OFFICE_LOCATION },
      { label: 'DC', data: FlyTo.DC_OFFICE_LOCATION },
      { label: '0,0', data: FlyTo.ZERO_ZERO },
      { label: '0,10', data: FlyTo.ZERO_TEN },
      { label: '10,0', data: FlyTo.TEN_ZERO },
    ];

    this.onFlyToPress = this.onFlyToPress.bind(this);
    this.onFlyToComplete = this.onFlyToComplete.bind(this);
  }

  onFlyToPress(i) {
    this.setState({ location: this._flyToOptions[i].data, selectedIndex: i });
  }

  onFlyToComplete() {
    Alert.alert('Fly To Animation Completed', 'We did it!!!');
  }

  render() {
    return (
      <>
        <ButtonGroup
          buttons={this._flyToOptions.map((i) => i.label)}
          selectedIndex={this.state.selectedIndex}
          onPress={(i) => this.onFlyToPress(i)}
        />
        <Mapbox.MapView style={styles.matchParent}>
          <Mapbox.Camera
            zoomLevel={16}
            animationMode={'flyTo'}
            animationDuration={6000}
            centerCoordinate={this.state.location}
          />

          {Platform.OS !== 'web' && (
            <>
              <Mapbox.UserLocation />

              <Mapbox.FillExtrusionLayer
                id="building3d"
                sourceLayerID="building"
                style={layerStyles.building}
              />
            </>
          )}
        </Mapbox.MapView>
      </>
    );
  }
}

export default FlyTo;

Observed behavior and steps to reproduce
This is occuring when running a web instance of a react-native/expo app.
I created a brand new react-native/expo app. I then pasted the "FlyTo" example code into index.tsx. The app starts fine, and the map is fully interactive. However, pressing the buttons to fly to a new location has no effect whatsoever.
Expected behavior
I expect the map to animate a change of view when any of the buttons are pressed in the "FlyTo" example.
Notes / preliminary analysis
I originally was having this issue in a more developed app (not an example). After fiddling with it for a long time, I decided to see if one of the examples was even working. It is not.
Additional links and references
No response

It's worth noting that creating a refrence object for the camera via useRef() and then calling the setCamera() method does have the expected behavior.


⚠ Bofrost.de has degraded performance

In c7b87a3, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1505 ms

Resolved: Bofrost.de performance has improved in 85abf7e.


Use default registry remotes if not specified in configuration

If the registry settings are not provided in the configuration, pull them from the anka cli commands.
This addresses a bug where the RegistryRevert action would fail as part of a force push to the registry if you had not specified the URL.
Signed-off-by: Tom Duffield<EMAIL_ADDRESS>

LGTM


Crashing consistently when opening E-Mails on Oneplus 9 Pro

Describe the bug
Crashing consistently when opening E-Mails
To Reproduce
Steps to reproduce the behavior:

Open email
Crash

Expected behavior
A clear and concise description of what you expected to happen.
Environment (please complete the following information):

K-9 Mail version: 5.733
Android version: 11
Device: Oneplus 9 Pro
Account type: Gmail (IMAP) with App password

Additional context
Netguard installed (K9 whitelisted)
Some other Services blacklisted or disabled through system settings

using fdroid Version

Sounds like you're still affected by the WebView crash. See https://www.androidpolice.com/2021/03/23/surprise-app-crashes-are-plaguing-tons-of-android-users-heres-how-to-fix-them/
It it's a different problem please provide a debug log. See https://github.com/k9mail/k-9/wiki/LoggingErrors


added Chanakya's Chakkravyuh

Please check this PR @edm00se

Hello @edm00se so I have fixed the cause of linting error and about the image source in BGM it's was not allowing me to resize the image size in URL itself and there's no existing Wikipedia page for it. So I decided to simply download one put the images in assets folder and link the relative path. It's previewing fine. Hopefully no error come up this time.

I'd love to not need to host the image,  but a quick search led me to the same conclusion. I'll have another look this evening when I have a few minutes and see if I can find another that will do what I'd like first.


increase timeout

How do I increase the timeout? I'm using the Mocha harness so I would assume there would be some way to pass options in to mocha

I think the timeout is specific to the mocha harness, and doesn't apply to this package, so I'm going to close.


Some questions about loot tables.

Could you add an example of multiple items being added to the loot table on the wiki?
If multiple items are added to the loot table, will all those items be dropped on a kill?
Is only one item chosen?
Is there a way to change the chance of a certain item dropping?
The reason I am asking is that I am trying to make it so that dryads from ars magica 2 will drop a random sapling from pam's harvestcraft mod.
Also, as a side note, it might be helpful to add a command that if a spawn egg is held in the hand, to look up the spawn name of that creature and output it to chat.

Here is a pastebin of what I am trying to do:  https://pastebin.com/HQRqKfpL


Add transform struct

Codecov Report

Merging #6 (8799f5d) into master (b403d0f) will decrease coverage by 2.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   85.33%   83.22%   -2.12%
==========================================
  Files          17       18       +1
  Lines        1064     1091      +27
  Branches     1064     1091      +27
==========================================
  Hits          908      908
- Misses        156      183      +27

Flag
Coverage Δ

unittests
83.22% <0.00%> (-2.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/lib.rs
100.00% <ø> (ø)

src/transform/transform_nd.rs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


improvement: Add compatibility with Azure Secret (aka USSec) region.

Problem
This go-common is used by https://github.com/webdevops/azure-metrics-exporter in order to collect metrics from azure and make them available to Prometheus. Today this wrapper around the azure sdk does not support Azure's secret region.
https://azure.microsoft.com/en-us/explore/global-infrastructure/government/national-security
Proposal
This PR attempts to add preliminary support for the secret region. I can't share the exact endpoints but in effort to support this new region we can reuse some functionality already present in this repo for reading in secret endpoints via the AZURE_CLOUD_CONFIG envvar.
Adds support for interpreting azure secret cloud from the AZURE_ENVIRONMENT variable. When using the secret cloud region you will need to additionally pass in AZURE_CLOUD_CONFIG similar to private azure cloud since the secret region endpoints themselves are considered PROPIN by Microsoft.
Notes for reviewer
This only adds support for the Azure secret region. There is a TS region as well but i'm purposefully leaving that out of this PR for now since I'm not sure what the AZURE_ENVIRONMENT envvar for this region is expected to be myself yet.
https://azure.microsoft.com/en-us/blog/azure-government-top-secret-now-generally-available-for-us-national-security-missions/

@mblaschke is it possible to get a review of this contribution PR?


Cleanup: Remove stale comments, increase encapsulation making methods private for specific local replies.

Commit Message: Cleanup: Remove stale comments, increase encapsulation making methods private for specific local replies.
Additional Description:
Stale comments
The &get was originally:
https://github.com/envoyproxy/envoy/pull/12866/files#diff-e91327a311d8130daac76a7c43dca2ae70d5a6a37dc7fdb658cf25b2fde88cc9R785-R790 which has since been cleaned up
The other comments, the ship has sailed for making these breaking changes.
Risk Level: low
Testing:
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/assign @snowp


Feature Request: API rules for files

Hi,
The security issue I'm facing is that every file is accessible via the /api/files/ route with no API rules. I want to be able to restrict access to these files so that anybody who has a leaked URL will be denied access. I could setup an extended pocketbase instance and write a custom API to apply my own access control, but it still doesn't fix the issue that files can be obtained through the default route.
Theoretically (without rate limiting etc.) someone could brute force the id's to find files as well (albeit computationally expensive). Providing API rules for files would remove any possibility of these events occurring and would be a great help to increase security.
Is there any reason why this shouldn't be implemented?

It is already in the roadmap. Will be handled in https://github.com/pocketbase/pocketbase/issues/215 sometime after the v0.8.0 release.


[Feature Request] Form validation status

Existing Component
Yes
Component Name
Form
Description
Hello,
When validation takes time, the user can make other actions (like saving)  before the model has been updated. Is it possible to get the validation status of the form ?

Are you validating the form on the server side?

Yes I do the both. But during the validation process on front side, if the
validation take time, the model can remain at the last value (Wich is a
correct value). So the guy click save, it re save the last value and there
is no way to know it.
It can append on slow computer when the validation of a field is slow.
For instance, I m validating a json textarea with a json schéma.
Le 6 oct. 2017 05:28, "杨奕"<EMAIL_ADDRESS>a écrit :

Are you validating the form on the server side?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ElemeFE/element/issues/7348#issuecomment-334648946,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMSpvN_w4UYpKh3iF3ftKDpIRMyzNbhks5spZ5pgaJpZM4PtV1m
.

I can no more reproduce it. I think i mess with something.


CPP/error/palidromic.cpp

rectify the error in the code.
NOTE:- Screenshot of the code and output is required.

Can you please assign this issue?

Please assign this issue to me !!


ExceptionsManager.js:151 Invariant Violation: ViewPropTypes has been removed from React Native. Migrate to ViewPropTypes exported from 'deprecated-react-native-prop-types

When I introduce the error of Times in the project, please tell me how to solve it

rn 0.70.1
ios


syntax error, unexpected '...' (T_ELLIPSIS), expecting ']'

I get an error like this in LaravelToUML (90)

Hi @ichwanlatif
Either upgrade PHP to 7.4, or apply following changes in Andyabih\LaravelToUML.php (not recommended):
https://github.com/andyabih/laravel-to-uml/blob/1.0.3/src/LaravelToUML.php#L90:
$sources = [$this->getStyling()];
https://github.com/andyabih/laravel-to-uml/blob/1.0.3/src/LaravelToUML.php#L296:
->notPath(array_merge(config('laravel-to-uml.excludeFiles'), $excludes))
Correct me if I'm wrong @andyabih (nice work btw)
Happy Coding ;)

@aurelie-vndl
The return value from getStyling() is an array.
So there is no need to add "[]"
https://github.com/andyabih/laravel-to-uml/blob/1.0.3/src/LaravelToUML.php#L90:
$sources = $this->getStyling();


Unrevert "Bump version to 8"

Reverts #9298.
Unreverts #9258.
WebTools counterpart: https://dev.azure.com/devdiv/DevDiv/_git/WebTools/pullrequest/498945
VS insertions: Razor only, WebTools only, Razor + WebTools

I feel like this should be titled "Revert Revert Revert" 😉

VS insertion looks good. We will probably need to somehow insert both WebTools and Razor at the same time.
@dotnet/razor-compiler for reviews

We need to get assembly redirects into devenv so we don't need to do coordinated insertions with WebTools all the time, or this will be untenable long term. We'll need to update https://devdiv.visualstudio.com/DevDiv/_git/VS?path=/src/ProductData/AssemblyVersions.tt&version=GBmain&line=147&lineEnd=149&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents, and work with Tiger to update these versions automatically with the insertion tool.
Hopefully, with such a change, we won't need to update WebTools at all.

@jjonescz, @jaredpar, @333fred - is this PR still needed or can it be closed after 6 months of inactivity?

is this PR still needed or can it be closed after 6 months of inactivity?

I think we still want to change Razor's version from 7 to 8 or even 9 now. But some infra changes are needed first so the insertions handle such version changes automatically.


Clear/Reset output

What are you requesting?
Make a function that simply clears the output just in case for some reason you need to use the same chain.
How could this be implemented.
Really easy working on PR

This was fixed by #45 which is now merged.


Global . When the popover is opened again, the page should be reset

表单弹出必填项提示文案后，关闭弹窗，再次打开，提示仍存在

resolved


Spotify Playlist Error

Description
I'm trying to stream a Spotify Playlist via a "MySonos" node. The Spotify Playlist is added to "MySonos" and put out on a mysonos.get.items query:
mysonos.get.items : msg.payload : array[3] array[3] 0: object 1: object title: "Kitchen Swagger" ...
My Flow:
I send a msg.payload with 'Kitchen Swagger' via "Inject Node" to 'mySonos.stream.item'. Unfortunately I get an error msg. in return":
"mysonos.stream.item:statusCode 500 & upnpError 714 :: Details: unknown error"
It worked fine with a TuneIn Radio Station.
What node/command (topic)/state (payload)
node:  My Sonos
command:  Kitchen Swagger
In case of a bug: Are you able to reproduce the error
yes
Versions and Infrastructure
what system: CCU3 with Redmatic (6.0.2)
node-red-contrib-sonos-plus version: 4.2.1
Node-RED version: 1.1.3

Hi.
Please try mysonos.queue.item oder use mysonos.export item together with universal node group.play.export.
Stations --> stream, Playlists, Album, ...--> queue

Hej @hklages,
i owe you a beer. mysonos.export together with universal node group.play.export works great.
Thank you!