Refine and automate release process

I walked through the process with @bhuga, @bkeepers, and @michaelansel and there is definitely some tedious points.
See  https://github.com/github/hubot/blob/master/CONTRIBUTING.md#releasing for the current process. Particularly tedious things:

[ ] generating ChangeLog summary from PRs merged
[ ] generating a PR with links to PRs, cc author, etc
[ ] push a prerelease package (hubot@next) and execute functional tests
[ ] promote prelease package (npm dist-tag add hubot@<version> latest)
[ ] update hubot.github.com's submodule of github/hubot docs directory

marginally related: any particular reason why there is a release script when npm has npm version built in?

I guess the general question is why there are so many bash scripts in the first place? Most all of them could be replaced (and simplified) with npm scripts. For instance, nearly every bash script has to mess with modifying the PATH so that node_modules bins are available. That is unnecessary when using npm scripts since npm prepends $(npm bin) to the path automatically.
This is already a node project, and it would be more conventional to have npm test, npm start and see all the other available scripts with npm run.
I would be happy to put together PR illustrating the change, if it would be considered.

any particular reason why there is a release script when npm has npm version built in?

Yes, the reason is we didn't know about it :grin:
For what it's worth, we are currently updating package.json separate from actually pushing it. By doing this, we can do a PR which includes the PR, and then publish it after.

I guess the general question is why there are so many bash scripts in the first place? Most all of them could be replaced (and simplified) with npm scripts. For instance, nearly every bash script has to mess with modifying the PATH so that node_modules bins are available. That is unnecessary when using npm scripts since npm prepends $(npm bin) to the path automatically.

Part of it is conventions used at GitHub for development. Nearly every project has a script/bootstrap for initializing the local environment, script/test for running test, script/server for launching the server process.
Another part is that hubot is old enough that I don't think these conventions were as well established when it was written, and they just haven't been updated.

This is already a node project, and it would be more conventional to have npm test, npm start and see all the other available scripts with npm run.

I'd be amenable to using these conventions. It would be good to keep some of the scripts around though for consistency with our other projects.

Also to be clear, these points don't address any of the pain points I outlined in the original issue, so they aren't as much of a priority for me.

For what it's worth, we are currently updating package.json separate from actually pushing it. By doing this, we can do a PR which includes the PR, and then publish it after.

npm version bumps package.json (it accepts major, minor, patch, premajor, preminor, prepatch, prerelease or an exact version to set); commits the package.json change, and tags it accordingly. It doesn't do git-pushing or npm-publishing automatically. If you want that, I typically do:
"scripts": {
  "release": "npm version",
  "postrelease": "git push && npm publish"
}

but out of the box, npm version only does the bump/commit/tag. (which is what you want, I believe)

Also to be clear, these points don't address any of the pain points I outlined in the original issue, so they aren't as much of a priority for me.

Agreed. I'll open a separate issue/PR for discussion so I don't hijack this thread any further :)

I tried https://github.com/skywinder/github-changelog-generator for https://github.com/github/hubot/pull/1035 with mixed results.
It kind of wants to take over the changelog, which I wasn't ready to do yet. I tried specifying --since-tag v2.15.0, expecting it would only output stuff for the next release, but it basically attributed everything to the next release. It also wants to work with releases that are actually published, so it assumes any changes since are 'unreleased', which doesn't work as well for our PR based release flow.

To get the change list, a partially working solution:
git log latest..HEAD | grep "^Merge"

It isn't great though because it will pick up nested merges. I'm sure there is a way with better git-fu to actually generate the correct list of merge commits against master containing a PR reference.
An addition to the Release PR: Add a compare link between the latest release tag and HEAD and then a link between the latest release tag and the new release tag. e.g. https://github.com/github/hubot/compare/v2.15.0...v2.16.0 https://github.com/github/hubot/compare/v2.15.0...v2.16.0

Per my work on #978, I would love to see the new release process leverage as much OOTB npm functionality as possible. To that end, I'd like to make everyone aware that recent versions of npm have some new functionality. Previously, npm had the npm version command that auto-bumps the version, commits and tags. What's new (as of 2.2 IIRC), there are preversion and postversion lifecycle hooks. Typically preversion is used to run tests, version runs the build and adds the build assets to git index, and postversion would git-push and npm-publish. There are no defaults for preversion and postversion, however, so they could do whatever you like. The `preversion

I could roughly see the scripts broken down roughly:

preversion: run tests
version: build/compile and smoketest if applicable; generate changelog (version has already been bumped at this point, so it can be read from package.json and incorporated into the changelog); git-add changelog and any other build assets to git index
postversion: push to github, publish to npm, update hubot.github.com's submodule of github/hubot docs directory

Obviously, you folks know your desired release process better than I, but the npm's new version lifecycle hooks can be used to eliminate the npm-specific steps from your custom scripts.

The current way I'm generating the changelog is with github-changelog-generator. The invocation is CHANGELOG_GITHUB_TOKEN=secret github_changelog_generator --future-release vX.Y.Z

We've talked about using semantic-release for this.

Closing this proactively, as of v4.0.0 we have automated releases.
There are some other tasks in this issue's checklist from 2015 which IMO best moved to separate issues if they are still something to pursue.


GEODE-6188: Select zone for testing at random to avoid availability c…

…onflicts.
Do not deviate from the us-central1 region, however.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Also @onichols-pivotal, please review.


Fix: bash to sh notation on invalid_challenge() hook

The hook for invalid_challenge still had old notation from bash, I converted the bash notation to sh notation.

Commited that in 81eecedc5af058dc69b14331088aa2f69c60c554 because your pull-request got poisoned by other commits. Please use branches for pull-requests in the future so this doesn't happen again :)


Allow to set max-scan-bytes using Terraform provider.

It should be possible to set the max-scan-bytes (per region) using the Terraform provider. It could either use the existing sneller_tenant_region configuration or use a custom resource. It can only be set, when the sneller_tenant_region has already been set.

Implemented in commit d705d4de896b7d34c5795db546decef762cebd8b.


added forced color to buttons to allow accessibilty in all high contr…

…ast modes

Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[x] Please list the exact browser and operating system versions you tested: Operating System-Windows 11, Browser-Chrome
[x] Please list which assistive technologies [^3] you tested: Tested using Windows Contrast Themes with modes-Aquatic,Desert,Dusk,Night Sky

Please describe additional details for testing this change.
The confirmation buttons that apperaed after clicking on Delete(in Image deleting or document deleting) appeared oddly in contrast themes.
The PR focuses on fixing the issue using forced colors
[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Thank you @thibaudcolas for reviewing the changes. I understand now that how detailed a PR should be and also that this approach for forced-color-adjust : none should be avoided. We can definitely further discuss over approaches well.


Cannot start

I have updated the SDK to version 1.3.5 and when to run the app, it has a problem.
The Discovery State always return PPKPeer2PeerDiscoverySuspended on the delegate function p2pDiscoveryStateChanged. With version 1.3.0, after returning value PPKPeer2PeerDiscoverySuspended, it returns value PPKPeer2PeerDiscoveryRunning quickly
So that I cannot detect any Bluetooth iPhone around

Hi,
PPKPeer2PeerDiscoverySuspended usually means that Bluetooth is suspended.
Can you tel us more about the type of device and operating system version?
Thanks!

My device is iPhone 5s (9.3.1), iPod touch 5 (8.4.1) and iPhone 6s(9.3.2)

Hi,
Has the issue been resolved? if yes, please close it.
Thank you

Hi! I have just started implementing p2pKit into my project, it looks like pretty interesting although I have just found the same issue as this guy. PPKController cannot get initialized, instead, it throws me the "suspended state" notification.
I sure have verified having my bluetooth on. I am afraid it might be something with the app key, because after a few tries I have tried to enable the PPKController with a random string key and it still shows me the same problem. Also, having a look at your youtube video "Get Started..." I have notified how long is the key you use, mine is an alphanumeric 32 elements long (pretty much shorter).
Would appreciate some help, thanks guys

Bundle ID was not set correctly.


Upgrading to 0.12.3 gives "Method getExtendedTypes() was not found in reflection of class Symfony\Component\Form\AbstractTypeExtension"

It seems that, after Rector finishes its first run after upgrading from 0.11 -> 0.12, almost every file in my project is attributed to an error similar to the following:

[ERROR] Could not process "src/Kernel.php" file, due to:
"Method getExtendedTypes() was not found in reflection of class Symfony\Component\Form\AbstractTypeExtension.".
On line: 328

Of course, the source file (Kernel.php) is different in each case, but otherwise the error is the same for every single file. Many of these files do not even appear to be tangentially related to the Form component in any way, so I have no idea what is going on.
This occurs on Symfony 4.4.33.

Thanks for reporting!
That's probably because Kernel contains optional dependency on symfony/forms. That's unfortunate design flaw of Kernel, as Rector does not know this class is optional.
The quick fix would be:
composer require symfony/form --dev

Slow fix would be to fake this class somehow. Could you share minimal reproducible repository on Github? We'll check it

I believe it has nothing to do with the Kernel. It affects almost every file in my project.

I see. Could you share reproducible repository so we can reproduce the bug?

I see. Could you share reproducible repository so we can reproduce the bug?

https://github.com/spras/symfony_4_rector_issue a fresh install of symfony 4.4
rector is installed with SymfonySet up to 4.2

@TomasVotruba Have you had a chance to look at this? Since it's blocking the Rector upgrade, it's quite major for us.

@Bilge I haven't found time yet. Failing CI job would speed it up

The problem here seems that AbstractTypeExtension::getExtendedTypes() is indeed not implemented in the Form component until 5.0, but not using itis deprecated since 4.2.
I have already updated our code to use getExtendedTypes() instead of getExtendedType(), so I see why this could cause the error. Interesting though it also seems to trigger wehn mnot even using ist as in @spras example.

I digged into this, the problematic rector is this one:
new \Rector\Renaming\ValueObject\MethodCallRename('Symfony\\Component\\Form\\AbstractTypeExtension', 'getExtendedType', 'getExtendedTypes')

from the Symfony42 Set.
As far as I understand, the problem is, that rector looks up the class-hierarchy and tries to find the method 'getExtendedTypes'. The hasMethod-Call in ClassChildAnalyzer::hasChildClassMethod returns true, due to the @method Doc-Annotation in FormTypeExtensionInterface.
In the next line, the ClassChildAnalyzer tries to get a MethodReflection-Object for the function, which fails because it does not really exist yet (only the @method Doc-Annotation), and that's what causes the exception.
Here's the code I'm talking about (also see here):
if (!$childClassReflection->hasMethod($methodName)) {  // the hasMethod-Call returns true, due to the @method Doc-Annotation in FormTypeExtensionInterface
     continue;
}
// then this line throws the Exception, because the function does not really exist
$constructorReflectionMethod = $childClassReflection->getNativeMethod($methodName);

@mkrauser Great catch, thank you!
I made PR to fix this one https://github.com/rectorphp/rector-src/pull/1336


[Feature] Allow changing install path

@2meito how would I go about this though? They are installed silently, does the move to ad card not work? Also, you can already install your games anywhere inside of the launcher if that makes sense.


Focus on Future and Founders

Refactors our post-meeting analysis questions to focus on:

The Future.
We want to invest in companies that are building what the future will look like in 5-10 years, not unimportant problems and derivative solutions.

The Founders
Are these people capable of building this future?

The Future.

We want to invest in companies that are building what the future will look like in 5-10 years, not unimportant problems and derivative solutions.
Are there macro trends around us that are changing that showcase this future is going to be true?

The Founders

Are these people capable of building this future?
Are they going to execute with an urgency that will scare their competitors and excite/delight their customers?
Are the founders oriented towards a growth mindset? (Growth of a founder is a leading indicator for the growth of the company)


Image Convolution with PSF Maps

I am currently trying to work out how to convolve an image with eROSITA PSF maps. Does anyone have any tips/experience of working with PSF Maps?

I have done some similar stuffs, we should chat

No experience with eROSITA but some with Chandra.
There is a Chandra thread that goes the other way - convolving a model with the PSF for comparison with observations. See Accounting for PSF Effects in 2D Image Fitting.
But what might be more useful is something like the Chandra tool aconvolve which can convolve an image with a kernel that can also be an image (e.g., the PSF).
There is also a Chandra tool to smooth images by the position-dependent PSF size, although I think that is quite Chandra specific.

At the moment, the eSASS tools do not allow you to produce a single map at a specific EEF
Is this just an interpolation problem? As in, pick an EEF, and interpolate each pixel in the PSF to get an approximate PSF?


Expose OpenSSL.Session internal types

Fixes #61

Just a thought. Since you need it to add some functionality to HsOpenSSL (https://github.com/phonohawk/HsOpenSSL/issues/59), maybe it's better to add this functionality directly without exposing internals? I would better accept a pull request with those 3 functions needed in Session.hsc (like I did myself in https://github.com/vshabanov/HsOpenSSL/commit/79c7b4c343729570f4736a66a9bf262069f37922).

Until the binding is complete it should expose the openSSL objects. This package isn't abstracting the notion openssl, it's a binding to a well known library with a stable api. Hiding these details gains nothing and impedes usage.

Thanks for merging this. My concern with these new bindings is that they are new to Open SSL 1.0.2. Is this too recent of a requirement for HsOpennSSL itself?

Fair enough. Although it would be nice if you could make a pull request with functions you need to make bindings more complete.

Look at my commit https://github.com/vshabanov/HsOpenSSL/commit/79c7b4c343729570f4736a66a9bf262069f37922#diff-0ae2970018a84154878783da2d12fc1bR287
I have a check on a C side for this function. Although it would be better to do this in .hsc file itself.
So with some #ifdef it should be possible to add it to the library.


Remove chatops command

How do you unregister a chatops command? I registered the run remote command from the documentation, which works. However, unregistering does either not work or the process is not straightforward. Removing the file from the my-chatops/aliases and running st2ctl reload --register-all does not work. service st2chatops restart doesn't help either.
Is this a bug or just not documented?
Edit:
I figured out that
st2 run packs.uninstall packs=my-chatops
service st2chatops restart
does the trick. Is there a way to remove single commands from a pack without removing the whole thing?

You can remove individual aliases with st2 action-alias delete


[GLES2] Adds GLES2 renderer support on macOS.

Adds GLAD GL_ARB_framebuffer_object extension binding.
Adds GLES2 renderer support on macOS.

Looks good to me, CC @karroffel.


[security] Fix a panic from an unchecked string slice.

When slicing a string, you get a panic if you do so at any point
other than at a character boundary.  This happened in the
implementation of UTCTime parsing.
This bug was introduced in bc156c36d76d91b77cdf8f1f231e2c554ea0e454,
and appears to affect only version 0.6.0.
I've tried using the clippy::string_slice lint to confirm that there
are not any other string slices in this code.
Fixes bug #27.  Found via fuzzing.

I fuzzed this branch for a couple more hours, but no further problems turned up.

By the way, please let me know if you'd like me to open a RUSTSEC advisory for this, or if you'd rather do it yourself?

Hey, you found it, I think you should get the credit for the advisory :)
I'll put another comment in here with the new version number (which will almost certainly be 0.6.1, but ...).

Published upstream as 0.6.1!

Hello, RustSec maintainer here. Thanks for acting on the issue so quickly!
I'd like to confirm with @acw that you want to treat panics in this crate as security issues. It's reasonable for a format decoder that handles untrusted data to treat panics as a security issue; but we don't want to have an inconsistent coverage where some panics in the crate are tracked but others are not.

After some thinking: yes, I think that makes sense. Especially for something like ASN.1, being able to crash a process remotely could be a significant safety or security concern.

I'm merging the advisory then. Thanks again!


Pylint configuration is busted

See original issue on GitLab
In GitLab by [Gitlab user @cs-shadow] on Nov 13, 2019, 13:23
Summary
It seems like we should be getting certain warnings from pylint about our codebase but we aren't. I think this is happening because we messed up our pylint configuration when we moved sources into a src directory (I can take the blame for that).
We currently invoke pylint as pylint src/buildstream tests. Locally, I tried pylint src tests by accident and got a few warnings on master, which was surprising. Later I realized that my invocation was more correct and the warnings were real things that we need to fix.
Steps to reproduce
# This is what we currentl do - everything's fine!
(lint) root[[Gitlab user @2428e3458936]](https://gitlab.com/2428e3458936):/src# pylint src/buildstream tests

-------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 9.99/10, +0.01)

# This is what I tried and got new warnings
(lint) root[[Gitlab user @2428e3458936]](https://gitlab.com/2428e3458936):/src# pylint src tests
************* Module buildstream.plugins.sources.patch
src/buildstream/plugins/sources/patch.py:83:4: W0221: Parameters differ from overridden 'fetch' method (arguments-differ)
************* Module buildstream.plugins.sources.bzr
src/buildstream/plugins/sources/bzr.py:104:4: W0221: Parameters differ from overridden 'track' method (arguments-differ)
src/buildstream/plugins/sources/bzr.py:118:4: W0221: Parameters differ from overridden 'fetch' method (arguments-differ)
************* Module buildstream.plugins.sources.tar
src/buildstream/plugins/sources/tar.py:83:8: W0201: Attribute '__permission' defined outside __init__ (attribute-defined-outside-init)
************* Module buildstream.plugins.sources.local
src/buildstream/plugins/sources/local.py:78:4: W0221: Parameters differ from overridden 'fetch' method (arguments-differ)
src/buildstream/plugins/sources/local.py:42:0: W0611: Unused utils imported from buildstream (unused-import)
************* Module buildstream.plugins.sources._downloadablefilesource
src/buildstream/plugins/sources/_downloadablefilesource.py:114:4: W0221: Parameters differ from overridden 'track' method (arguments-differ)
src/buildstream/plugins/sources/_downloadablefilesource.py:131:4: W0221: Parameters differ from overridden 'fetch' method (arguments-differ)
************* Module buildstream.plugins.sources.pip
src/buildstream/plugins/sources/pip.py:158:4: W0221: Parameters differ from overridden 'track' method (arguments-differ)
src/buildstream/plugins/sources/pip.py:180:4: W0221: Parameters differ from overridden 'fetch' method (arguments-differ)
************* Module buildstream.plugins.sources.workspace
src/buildstream/plugins/sources/workspace.py:61:4: W0221: Parameters differ from overridden 'track' method (arguments-differ)
src/buildstream/plugins/sources/workspace.py:91:4: W0221: Parameters differ from overridden 'fetch' method (arguments-differ)
src/buildstream/plugins/sources/workspace.py:38:0: W0611: Unused import os (unused-import)
src/buildstream/plugins/sources/workspace.py:40:0: W0611: Unused CasBasedDirectory imported from buildstream.storage._casbaseddirectory (unused-import)
src/buildstream/plugins/sources/workspace.py:42:0: W0611: Unused utils imported from buildstream (unused-import)

-----------------------------------
Your code has been rated at 9.99/10

What is the current bug behavior?
Pylint warnings get hidden.
What is the expected correct behavior?
Pylint warnings are reported correctly.

In GitLab by [Gitlab user @cs-shadow] on Nov 13, 2019, 13:25
changed title from Pylint configuratin is busted to Pylint configurati{+o+}n is busted

In GitLab by [Gitlab user @cs-shadow] on Nov 13, 2019, 13:44
mentioned in commit 405817480a3aab3440086a2d366e5249a2dc107a

In GitLab by [Gitlab user @marge-bot123] on Nov 13, 2019, 15:11
closed via merge request !1708

In GitLab by [Gitlab user @marge-bot123] on Nov 13, 2019, 15:11
mentioned in commit baff3507d2ad5bad2e0a92e3b5ee0805e19504f7


YAML parser quote handling

The Slack thread can be seen here.
When using this in my values.yaml
labels:
  host_external_dns_enable: "true"
  cool_id: "test123"
  better_id: "test123"
  deploy_time: "2017-03-20T17:13:01Z"
  image: "herp:01234567"

And using the spiffy {{ toYaml .Values.labels | indent 8 }} function, I sadly get this back whilst doing a --debug --dry-run
      labels:
        deploy_time: 2017-03-20T17:13:01Z
        host_external_dns_enable: "true"
        image: herp:01234567
        cool_id: test123
        better_id: test123

In this case, I get an error about both the deploy_time and image values and the chart in unsuccessfully deployed.
Error: release herp failed: Deployment.extensions "derp" is invalid: [spec.selector.matchLabels: Invalid value: "2017-03-20T17:13:01Z": must match the regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])? (e.g. 'MyValue' or 'my_value' or '12345'), spec.selector.matchLabels: Invalid value: "herp:01234567": must match the regex (([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])? (e.g. 'MyValue' or 'my_value' or '12345'),spec.selector: Invalid value: {"matchLabels":{"app":"derp","deploy_time":"2017-03-20T17:13:01Z","host_external_dns_enable":"true","image":"herp:01234567","better_id":"test123","cool_id":"test123"}}: invalid label selector.]

From @technosophos

the YAML parser will try to simplify the data to its most basic format. So it will remove quotes around any >strings it thinks it can get away with.

My ask here is that we either make this handling configurable or just double quote everything (probably the better option).

The error you give seems to be from the Kubernetes validator saying that the deployment time does not match the allowed value regular expression. I don't think that adding quotes will fix that.
Kubernetes restricts the contents of a string that is used as a label value. Colons are not allowed in label values, for example.

yup ok you are 100% correct. Not sure why I thought it was actually working with these quoted.
Sorry for wasting everyone's time.


Change proc path

Change proc path to a value that can be passed to newenforcer and also add a check to ensure that we don't launch a enforcer in a host network namespace

Codecov Report

Merging #204 into master will increase coverage by 0.46%.
The diff coverage is 40.42%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   48.93%   49.39%   +0.46%
==========================================
  Files          33       33
  Lines        4230     4241      +11
==========================================
+ Hits         2070     2095      +25
+ Misses       1964     1951      -13
+ Partials      196      195       -1

Impacted Files
Coverage Δ

processmon/processmonmock.go
0% <0%> (ø)
:arrow_up:

cmd/remoteenforcer/remoteenforcer_linux.go
0% <0%> (ø)
:arrow_up:

enforcer/datapath.go
36.92% <100%> (+0.39%)
:arrow_up:

processmon/processmon.go
66.66% <68%> (+3.09%)
:arrow_up:

monitor/linuxmonitor/linuxMonitor.go
72.54% <0%> (+3.92%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867f58e...ade160a. Read the comment docs.

When creating the enforcer proxy// Remote enforcer, the new proc path should be an optional parameter, so that It can be defined on startup.


Run times far from expected

Running the notebook with python 3 on a tx2 with JetPack 3.3. I followed the instructions and I am measuring the inference time as follow
from time import time
start = time()
output = tf_sess.run(tf_output, feed_dict={
    tf_input: image[None, ...]
})
end = time()
print("Inference time: {}s".format(end-start))
scores = output[0]
Using the same examples as the notebook (inception_v1 etc), I got a inference time of 0.8 seconds, pretty far from the 7ms described.
I also used
sudo nvpmodel -m 0
sudo ~/jetson_clocks.sh

Don't know if this is still relevant but the first inference is painfully slow (warmup). Usually you discard the first inference and average the next ten


fix: update dependencies

Description
Update dependencies.
Type of change
Please delete options that are not relevant.

[X] Update dependencies

How Has This Been Tested?

[X] run cargo test with all tests passing

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

Current dependencies on/for this PR:

main

PR #37   👈

This comment was auto-generated by Graphite.


Adding test-database of .sgf files.

Includes 62 high-dan games played on KGS on April 30, 2019. Games were stripped of comments and collated at u-go.net/gamerecords.

You'll need to merge in master changes.


Steps to Assign Dial Plan to Group

Hello,
I have the task of assigning dial plans to various users would like steps to do this via group. The article says you can assign policies in batch or by group but I do not see any way to do that? If it is not possible could you change the text below or add a note that it is not possible so people do not spend time trying to figure out how to do it?

Assign a dial plan to users
You assign a dial plan in the same way you assign policies. You can assign a policy directly to users, either individually or at scale through a batch assignment (if supported for the policy type), or to a group that the users are members of (if supported for the policy type).To learn about the different ways that you can assign policies to users, see Assign policies to your users in Teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 451b44cf-961a-5bf5-e4b3-16b96e008dd7
Version Independent ID: 54e706e1-aaa2-3a03-b8c6-5e96244b85ac
Content: Create and manage dial plans - Microsoft Teams
Content Source: Teams/create-and-manage-dial-plans.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Hello @scrubbles
Have a look at https://docs.microsoft.com/en-us/powershell/module/teams/new-csbatchpolicyassignmentoperation?view=teams-ps for batch assignment
and
https://docs.microsoft.com/en-us/powershell/module/teams/new-csgrouppolicyassignment?view=teams-ps for group assignment
Using the Teams PowerShell
Hope this answers your question,

@scanum


Change to 2-stage docker build and releasing

https://www.johnmiddleton.dev/docker/golang/containers/2019/08/17/docker-and-golang.html
Current build/releasing process can be optimized.

Hi @chrislusf
I'm the author of the above article, can I help with this?
John

Amazing! Yes, please!

Any progress? @jmidd Dockerfile


[CHANGE ME] Re-generated to pick up changes from synthtool.

This PR was generated using Autosynth. :rainbow:
Synth log will be available here:
https://source.cloud.google.com/results/invocations/cc0f0cf0-279c-4f54-a51a-0018dc65e83f/targets

[ ] To automatically regenerate this PR, check this box.

Source-Link: https://github.com/googleapis/synthtool/commit/5de29e9434b63ea6d7e46dc348521c62969af1a1
Source-Link: https://github.com/googleapis/synthtool/commit/d1bb9173100f62c0cfc8f3138b62241e7f47ca6a

Why did you close this?


The execution fails when using .hic file as input

I am running the following code
library(CALDER)

hic_path="inter_30.hic"

bin_size=50000
genome="hg19"
save_dir="./out"
n_cores=1

chrs=c("chr1", "chr2", "chr3")

CALDER(contact_file_hic=hic_path,
         chrs=chrs,
         bin_size=bin_size,
         genome=genome,
         save_dir=save_dir,
         save_intermediate_data=FALSE,
         n_cores=n_cores,
         sub_domains=TRUE,
         single_binsize_only=TRUE)

And I get the following output:

>>>> Begin process contact matrix and compute correlation score at: 2022-06-01 00:18:52
 >>>> Begin compute compartment domains and their hierachy at: 2022-06-01 00:19:05Error in `colnames<-`(`*tmp*`, value = `*vtmp*`) :
  attempt to set 'colnames' on an object with less than two dimensions
 >>>> Correlation between PC1 and reference compartment is : 1
 >>>> Finish compute compartment domains and their hierachy at:  2022-06-01 00:19:26
>>>> Begin process contact matrix and compute correlation score at: 2022-06-01 00:19:26
 >>>> Begin compute compartment domains and their hierachy at: 2022-06-01 00:19:39Error in `colnames<-`(`*tmp*`, value = `*vtmp*`) :
  attempt to set 'colnames' on an object with less than two dimensions
 >>>> Correlation between PC1 and reference compartment is : 1
 >>>> Finish compute compartment domains and their hierachy at:  2022-06-01 00:20:01
>>>> Begin process contact matrix and compute correlation score at: 2022-06-01 00:20:01
 >>>> Begin compute compartment domains and their hierachy at: 2022-06-01 00:20:09Error in `colnames<-`(`*tmp*`, value = `*vtmp*`) :
  attempt to set 'colnames' on an object with less than two dimensions
 >>>> Correlation between PC1 and reference compartment is : 1
 >>>> Finish compute compartment domains and their hierachy at:  2022-06-01 00:20:25Error in { :
  task 1 failed - "task 1 failed - "task 1 failed - "cannot open the connection"""
In addition: Warning messages:
1: In file(con, "r") :
  cannot open file './out/intermediate_data/sub_compartments/50kb/chrchr1_log.txt': No such file or directory
2: In file(con, "r") :
  cannot open file './out/intermediate_data/sub_compartments/50kb/chrchr2_log.txt': No such file or directory
3: In file(con, "r") :
  cannot open file './out/intermediate_data/sub_compartments/50kb/chrchr3_log.txt': No such file or directory
 >>>> Begin compute sub-domains at: 2022-06-01 00:20:25Error in gzfile(file, "rb") : cannot open the connection
In addition: Warning message:
In gzfile(file, "rb") :
  cannot open compressed file './out/intermediate_data/sub_compartments/50kb/chr1_intermediate_data.Rds', probable reason 'No such file or directory'
 >>>> Begin compute sub-domains at: 2022-06-01 00:20:25Error in gzfile(file, "rb") : cannot open the connection
In addition: Warning message:
In gzfile(file, "rb") :
  cannot open compressed file './out/intermediate_data/sub_compartments/50kb/chr2_intermediate_data.Rds', probable reason 'No such file or directory'
 >>>> Begin compute sub-domains at: 2022-06-01 00:20:25Error in gzfile(file, "rb") : cannot open the connection
In addition: Warning message:
In gzfile(file, "rb") :
  cannot open compressed file './out/intermediate_data/sub_compartments/50kb/chr3_intermediate_data.Rds', probable reason 'No such file or directory'
cat: ./out/intermediate_data/sub_domains/chr1_nested_boundaries.bed: No such file or directory
cat: ./out/intermediate_data/sub_domains/chr2_nested_boundaries.bed: No such file or directory
cat: ./out/intermediate_data/sub_domains/chr3_nested_boundaries.bed: No such file or directory

It seems that there is a problem with the calculation of the correlation of the PCs with the reference compartments.

Hi, thank you for such amazing work creating this package and maintaining it.
I am recently using Calder for the first time, and I am having the same issue. For your reference, I install the R package using remotes:
remotes::install_github("CSOgroup/CALDER2.0")
This is my code:
hic_file  <- "./50000.hic"
out_dir <- "./Results"
"./Results/"
sel_chr <- paste0("chr", c(21:22))
CALDER(contact_file_hic=hic_file,
			chrs=sel_chr,
			bin_size=100000,
			genome='hg38',
			save_dir=out_dir,
			single_binsize_only = TRUE,
			save_intermediate_data=TRUE,
			n_cores=1,
			sub_domains=TRUE)

And this is the output I get:
[ chr21 ] Begin process contact matrix and compute correlation score at: 2024-02-05 21:00:10.325759
[ chr21 ] Finish process contact matrix and compute correlation score at: 2024-02-05 21:00:11.028937
[ chr21 ] Begin compute compartment domains and their hierachy at: 2024-02-05 21:00:11.032579
[ chr21 ] Computing compartments
[ chr21 ] Correlation between PC1 and reference compartment is : 0.61291
[ chr21 ] Finish compute compartment domains and their hierachy at:  2024-02-05 21:00:11.711872
[ chr22 ] Begin process contact matrix and compute correlation score at: 2024-02-05 21:00:11.730749
[ chr22 ] Finish process contact matrix and compute correlation score at: 2024-02-05 21:00:12.418951
[ chr22 ] Begin compute compartment domains and their hierachy at: 2024-02-05 21:00:12.422524
[ chr22 ] Computing compartments
[ chr22 ] Correlation between PC1 and reference compartment is : 0.17923
[ chr22 ] Finish compute compartment domains and their hierachy at:  2024-02-05 21:00:13.152469
Warning: cannot open file './Results/intermediate_data/sub_compartments/100kb/chrchr21_log.txt': No such file or directoryWarning: cannot open file './Results/intermediate_data/sub_compartments/100kb/chrchr22_log.txt': No such file or directoryError in { :
  task 1 failed - "task 1 failed - "task 1 failed - "cannot open the connection"""
[ chr21 ]Begin compute sub-domains at: 2024-02-05 21:00:13.191409Warning: cannot open compressed file './Results/intermediate_data/sub_compartments/100kb/chr21_intermediate_data.Rds', probable reason 'No such file or directory'Error in gzfile(file, "rb") : cannot open the connection
[ chr22 ]Begin compute sub-domains at: 2024-02-05 21:00:13.194897Warning: cannot open compressed file './Results/intermediate_data/sub_compartments/100kb/chr22_intermediate_data.Rds', probable reason 'No such file or directory'Error in gzfile(file, "rb") : cannot open the connection
cat: ./Results/intermediate_data/sub_domains/chr21_nested_boundaries.bed: No such file or directory
cat: ./Results/intermediate_data/sub_domains/chr22_nested_boundaries.bed: No such file or directory

Output of sessionInfo() is:
R version 4.3.2 (2023-10-31)
Platform: x86_64-apple-darwin13.4.0 (64-bit)
Running under: macOS Ventura 13.4

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Users/martin/miniconda3/envs/calder_hic/lib/libopenblasp-r0.3.26.dylib;  LAPACK version 3.12.0

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] CALDER_2.0

loaded via a namespace (and not attached):
 [1] Matrix_1.6-5      dendextend_1.17.1 gtable_0.3.4      dplyr_1.1.4       compiler_4.3.2    maps_3.4.2        tidyselect_1.2.0  Rcpp_1.0.12       parallel_4.3.2
[10] gridExtra_2.3     scales_1.3.0      rARPACK_0.11-0    lattice_0.22-5    ggplot2_3.4.4     R6_2.5.1          generics_0.1.3    igraph_<IP_ADDRESS>    knitr_1.45
[19] viridis_0.6.5     iterators_1.0.14  dotCall64_1.1-1   tibble_3.2.1      munsell_0.5.0     pillar_1.9.0      rlang_1.1.3       utf8_1.2.4        xfun_0.41
[28] doParallel_1.0.17 viridisLite_0.4.2 cli_3.6.2         magrittr_2.0.3    digest_0.6.34     foreach_1.5.2     grid_4.3.2        spam_2.10-0       lifecycle_1.0.4
[37] nlme_3.1-164      fields_15.2       vctrs_0.6.5       RSpectra_0.16-1   glue_1.7.0        data.table_1.15.0 strawr_0.0.91     codetools_0.2-19  colorspace_2.1-0
[46] ape_5.7-1         fansi_1.0.6       tools_4.3.2       pkgconfig_2.0.3

Hi Yuanlong,
Thanks for the quick reply!
I did what you recommended, and it works!
Thank you so much, and again, thank you for sharing your work and maintaining it!


Changelog Incorrect : Package Version 13.3.0 drops support for Node.js 14

lint-staged Package Version 13.3.0 drops support for Node.js 14, instead of package version 14.0.0
Package.json file for version 13.3.0
package json version 13.3.0.txt
Current Changelog

Yes, this was an accidental publish and we should deprecate that version from npm.


Supported layer types in documentation

According to the current documentation, only label layers are supported. I recommend updating documentation before #281

[ ] List supoorted layer types
[ ] Explain how to derive measurements for each layer type / list plugins which can do this
[ ] Add at least one screenshot or screencast showing how to process a surface (because that's a cool new feature that should be highlighted)
[ ] Add example data for new layer types so that people can try it out

Hey @zoccoler!
That would be awesome if you could take care of this. I have an example dataset which I created for testing which uses the napari process points and surfaces package which I could send to you. Maybe we could add it as an example notebook? For the points layer I also have a very basic example which I used which just converts cells to points

I have now added some example data for surfaces and points which can be found using the links!

Thanks!! I am working on the docs now


Should isort be included as default lint target?

isort seems having compatibility issues with black https://github.com/psf/black/issues/333 https://github.com/timothycrosley/isort/issues/694
There's a certain config to work around the issue,  and implemented here through https://github.com/mintel/build-harness/pull/27
I want to start this as dicussion of is isort provide enough value that we want to take on the maintenance responsibility for the incapability and potential breaking change in the future?

The whole point of build harness is that we control for potential breaking changes by centralizing all the commands we run in one place. If isort+black end up with a serious issue again in the future (issue #27 was not serious), we can remove isort or adjust the commands as necessary.
That said, I think there's potential to drop isort from the lint target (leave it in the fmt target) with the addition of flake8. I'll investigate #28 before returning to this issue.

Ok, so #31 set the following order-of-operations.
Lint

autoflake - delete unused imports and variables, if possible
isort - clean up imports (ordering, formatting)
black - no opinions allowed, this is the way
flake8 - list style and quality errors that impact readability and/or are the source of bugs

All of these things blend together well and do something the others don't. I limited each to do the bare minimum, where possible, so there's very little duplicate work. (isort and black may try to duplicate each-other, but it shouldn't cause any conflicts in the current configuration)


Change cloudbase to feet - I'm a pilot

I know, New Zealand is a metric country too, but, as a pilot, I just so think of cloud heights in feet and wind speed in knots.
Any chance of a mod that allows for the wind speed to be shown in knots and especially the cloud base in feet?
Thanks!
Love the skin.

The units displayed in the reports are provided by Weewx, which allows you to configure the entire unit system or modify individual values, such as wind speed and cloud base, no matter in which unit they're stored in the database. For tailored adjustments to your preferences, please refer to the Weewx Customization Guide at changing unit systems.
To display wind speed in knots and cloud base in feet in Weewx, you can add the following settings to your weewx.conf file under the [StdReport] section:
[StdReport]
    [[Units]]
        [[Groups]]
            # Set wind speed unit to knots
            group_speed = knot
            # Set cloud base height unit to feet
            group_altitude = foot

Thank you so much.
Sorry for the trouble. I made the changes in weewx.conf and did a reset of the HTML files (as if I was changing to a new skin) and now I have wind speed in knots and cloudbase in feet.
Thanks again!


About the CDC module and LGFI module

Thank you for your hard work , your work helps me a lot . I am a beginner in the field of computer visionI， and have some questions about CDC module and LGFImodule, I hope you can answer them . Why operate the Batch normalization after 3×3 DDWConv  instead of 1×1 point-wise？In the LGFI module, why is Layer normalization performed first, and how do local features and global features interact?

Hi!
CDC: We only use BN on the features after the dilated conv (feature extraction). Here the two 1x1 point-wise convolutions are used to enhance and aggregate the local information, and we didn't consider putting it after the 1x1 convolutions.
LGFI: 1) In the original Vision Transformer paper, the norm layer is also put in front of the attention layers to normalize the input.
2) For local and global feature interactions, the input feature is added to the intermediate outputs.

Thank you to answer me.
The two 1×1 point-wise concolutions in CDC and LGFI are both used to enhance and aggregate the local information? Can I regard the three operations of 1×1 point-wise concolution GELU and 1×1 point-wise concolution as a full connection? Not only can features be enhanced and aggregated, but the number of output channels can also be changed.

In our implementation we use nn.Linear because it is equivalent when the kernel size of nn.Conv2d is 1. We expand the intermediate channel numbers, but the final output channels remain the same as the input.

Q1. The two 1×1 point-wise concolutions in CDC and LGFI are both used to enhance and aggregate the local information?
Q2. In LGFI module ,  is the role of cross-covariance  attention to pay attention to the CDC moduled output's channel?
I'm thankful that you can answer me.

For CDC, it is. For LGFI, I would not use the word "local information". This module is for local/global information fusing.
Yes, it's an attention mechanism focusing on the correlations between channels.

I am now closing this thread due to lack of response. You can reopen it or create a new issue if you have further questions.

I am now closing this thread due to lack of response. You can reopen it or create a new issue if you have further questions.
@noahzn Hello, I would like to ask a question, for dividing the kitti dataset, is there a proper way to select a small portion of it to test the performance of the network, not for the final comparison, but only for evaluating whether the current network is effective or not. Due to the performance limitations of the graphics card it would take too long to run on the full dataset, so if the author has made any similar changes, I hope he can help me!

I am now closing this thread due to lack of response. You can reopen it or create a new issue if you have further questions.
@noahzn Hello, I would like to ask a question, for dividing the kitti dataset, is there a proper way to select a small portion of it to test the performance of the network, not for the final comparison, but only for evaluating whether the current network is effective or not. Due to the performance limitations of the graphics card it would take too long to run on the full dataset, so if the author has made any similar changes, I hope he can help me!

@LLLYLong Hi, please open a new ticket for your new question. It won't take long time to evaluate on the whole evaluation set. But if you are asking if using a small portion of images for training, I would say that it would definitely affect the results.


runtime(java): Update java[CR]_JavaLang type lists

Add to the list of java.lang runtime exceptions two new
types: MatchException (Pattern Matching for switch) and
WrongThreadException (Virtual Threads).
"Demote" Compiler (removed in JDK 21) from the list of
java.lang class types to a new list javaLangDeprecated.

References:
https://bugs.openjdk.org/browse/JDK-8205129
https://bugs.openjdk.org/browse/JDK-8282274
https://bugs.openjdk.org/browse/JDK-8284161

Thanks!


Question regarding enable-script for other cards

Hey,
first of all thanks for the git repo, it sure made making the my rpi 3b+ to a audio receiver much easier than I anticipated!
I don't got a Hifiberry card, but a Allo Digione  card that basically does the same. It's working fine now with the rpi and I've gotten it working for the services I want (Bluetooth receiver and Spotify connect).
I only run a few of the scripts from your git to have better control / try improve my understanding a bit. Obviously one of the scripts I didn't run was the enable-hifiberry.sh script as I don't have any of those cards, but I was thinking maybe I should do something similar but adapt it to the card I got.
I see that our either create or alter the /etc/asound.conf file. On my device (latest Raspbian 10 buster, full dist-upgrade last week) this file doesn't exist (at least not as /etc/asound.conf, but got a similar file in /usr/share/alsa/alsa.conf - are these the same and is this the one that should be edited?).
Does this part of the process have a noticeable effect on the final result? And if so, are the values in the script device-specific for the Hifiberry products or just for the rpi device (I see the comments have different values for rpi zero, i.e.).
The Allo Digione card is enabled using dtoverlay=allo-digione, but when running other commands such as aplay -l or cat /proc/asound/cards it displays slightly modified names for the card, so I'm not sure which would be correct to use if I were to try making my own /etc/asound.conf file. See below for outputs.
pi@raspberrypi:~ $ cat /proc/asound/cards
 0 [sndallodigione ]: RPi-WM8804 - snd_allo_digione
                      snd_allo_digione
pi@raspberrypi:~ $ aplay -l
**** List of PLAYBACK Hardware Devices ****
card 0: sndallodigione [snd_allo_digione], device 0: Allo DigiOne HiFi wm8804-spdif-0 [Allo DigiOne HiFi wm8804-spdif-0]
  Subdevices: 0/1
  Subdevice #0: subdevice #0

Do you think something as simple as changing hifiberry with allodigione in the parts of your script that you output to /etc/asound.conf  would be sufficient?
I know I probably shouldn't tweak more as it's working now, but I just have a feeling I might miss out on something so hard to resist! ;)

The /etc/asound.conf file may not exist in default installations, that's why you need to create it if you would like to change the default config (which is in /usr/share/alsa/alsa.conf).
In the asound.conf provided in enable-hifiberry.sh the hifiberry name is only a name (alias) for the first audio device (type hw, card 0, device 0). So as you already set up your DigiOne correctly, it should work and be available as first audio device. You can use the asound.conf without modifications, this should work. If you want, you can change the hifiberry to anything you want (e.g. allodigione), as long as it's the same in both places.
Hope I could help you!

Ah, that makes sense then. Thanks a lot for the explanation, and again thanks for the scripts!


Proposal - Sapling.ai (Independent Publisher)

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ ] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[ ] I attest that the connector works and I verified by deploying and testing all the operations.
[ ] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[ ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[ ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[ ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hello @fordosa90,
Thank you so much for submitting this new proposal. We are looking forward to seeing your connector artifacts.
Please let us know if you have any questions.
Thank you so much again for your hard work with us.

@Amjed-Ayoub Thank you, actually I have a question, as I have started to work on the connector.
I was able to map most of the endpoints, requests and responses of the service to the custom connector.
However, this API requires the API key to be sent within every request (POST) to the endpoint within the request JSON body, for example:
HTTP POST
....../api/v1/testendpoint
{
"key": <API_KEY>,
"text": "This is a test text",
"sesions_id": 12345
}
I am unable to find any way on how to define this authentication type except making the API Key itself an input parameter available through the user interface. Do you have any suggestions?

@Amjed-Ayoub the only workaround that comes to my mind is adding "Authentication: API Key" to the connector, and the adding a request parameter to every paths (endpoints) defaulting to this, and marking it as "internal".

Hi Andras,
I have seen this authentication method before. In the past, I used no security method and created the connection parameter manually after downloading it with the CLI. The problem I couldn't get past was then using the policy Set Property (https://learn.microsoft.com/en-us/connectors/custom-connectors/policy-templates/setproperty/setproperty) to add the connection parameter, as the policy couldn't at the time reference the connection parameter. I would try this and let us know if it works. You would then not need to set the parameter as internal as it wouldn't be shown to the user as part of the action.

Thank you so much @fordosa90 for reaching out and thank you @troystaylor for your help. Please allow me to add this document (https://learn.microsoft.com/en-us/connectors/custom-connectors/policy-templates/setqueryparameter/setqueryparameter) as well.

@troystaylor  @Amjed-Ayoub
Thank you for the input and suggestions.
I have tried to Set-Property (preview) policy with using the @connectionParameter('...') notation, which does add correctly the property to the HTTP POST body, however does not resolve the connectionParameter to an actual value...
Might be this a bug, or rather the fact that since it is a preview feature, it does not yet support this expression?
Is the above mentioned workaround (defaulting value to connection param, and hiding it as internal) a not suggested solution?

Can you add your apiProperties.json file to the PR so I can check that out? That is where the api_key property needs to be added to give the user the input box.

@troystaylor  sure, updated PR with the file
thanks a lot for the check and any assist

hey @troystaylor  thank you for the quick feedback.
I have actually tried that with both 'key' and 'er', and none of them works.
Both of them sent through the expression without resolving it first.

I'm at a bit of a loss. I've created my own version using the Postman collection (https://app.getpostman.com/run-collection/20248607-4e2eafd4-e941-4d52-88a8-b4bb90c1d26a?action=collection%2Ffork&collection-url=entityId%3D20248607-4e2eafd4-e941-4d52-88a8-b4bb90c1d26a%26entityType%3Dcollection%26workspaceId%3Dcea8d224-5c5e-4604-a8f6-46f228f46f78), downloaded it to add the connectionParameter, then uploaded it, refreshed the connector, added the policy, and tested - didn't get the key. I then went to the policy and added the API key as the value instead of connectionParameters('key') - worked. @jopanchal, can you have someone look at the Set Property policy code?

@fordosa90 if this connector is ready for review, please remove the proposal from the PR title.

@Amjed-Ayoub no, the connector is not yet ready as the question of authentication is still open.
Waiting for input from Microsoft team at the moment

Hello @fordosa90,
if this connector is ready for review, please remove the proposal from the PR title. As I have seen that @troystaylor has given workaround. https://github.com/microsoft/PowerPlatformConnectors/issues/2906

@vmanoharas  the connector is still in proposal, I would prefer to receive an official answer from MSFT before utilising any workaround instead of the supported and suggested solution
@troystaylor  greatly appreciate the additional effort you have invested into this issue

@vmanoharas  I can finally confirm, that the connector is ready for merge 🥳
Based on feedback from product team, the policy template can not be used with the expressions, this is marked in a fairly hidden way on each policy templates first paragraph.
Implemented an alternative workaround with the help of small code, since there is no supported native way (hidden input properties can't reference directly connection parameters either),

Hello @fordosa90, Thank you very much for submitting the PR finally :-).
The validation checkers are failing, could you please close this PR and resubmit with new PR?


Support force reloading configuration (return response without waiting of restartiong of all scrape loops)

#3707
There is a case, when you have some loops which can be executed for large amount of time. If at this time prometheus receive reload configuration request, response will be send only when all loops are restarted.
Adding /-/reload/force endpoint will solve this problem. It will return response after validation rules and prometheus config. Restarting scraping loops will be done in background.

Any updates?

@Chevron94  We are teaming up with CNCF CI to try and build an automated performance tests at scale so I decided to wait and see what happens on that front and test this change there first.

This introduces a race I suspect, what if there's two reloads going on concurrently?

@Chevron94 yep it might be worth checking this with --race enabled.


Tooltip for Mobile Patent Suits! Please help!

Hi,
So I have been working with the Mobile Patent Suits by Mike Bostock’s Block 1153292: http://bl.ocks.org/mbostock/1153292 .
However, I am fairly new to D3 and cannot make the tooltip to work. I need each of the nodes to say something different as a tooltip (basically more details about each of the node).
Also, if it is possible, it would be nice to have an external file source, like a json file from where the data can be drawn rather than from the html file itself (by this I mean the parent/child data).
It would be absolutely great if you could help me out with this as it is kind of urgent.
Thank you in advance!!

Dupe of #262


Improve component discoverability in client build

In Hydrogen architecture, client components are not imported directly in the browser, which means they are not included in the client bundle generated by Vite. However, we still need a mechanism to download client components from the browser on demand (from RSC responses).
Currenly, we rely on Vite's import.glob to discover client components in the client build and bundle a reference to them. This import.glob translates to a map of id: () => import('.../assets/xyz...'). The ids are provided in RSC responses, and are used to find the correct dynamic import for the component. Apart from that, import.glob also tracks each component's dependencies and downloads them in parallel when the component is requested (to avoid waterfall requests).
There are two problems with this approach:

We need to inform Hydrogen of every path where Vite should try to find client components. By default, that's the user project folder and Hydrogen itself (from node_modules). This is not a huge issue right now because there are not many 3P libraries out there that export client components but, as the RSC ecosystem matures, our users would need to add each of those dependencies to our plugin.
The import map included in the client bundle adds a reference to every component in the folders passed to import.glob regardless of wether the components are actually used or not. The references are not too big, but if there are many unused components this adds up in the client build.

Both problems are somewhat related. I think at some point we should run the server build first in order to discover the client components that are actually used and generate some kind of manifest file. This might not be possible because, currently, the server build depends on the client build (for the generated index.html), so perhaps we need an extra processing before building to generate this manifest.
Once we have a manifest or something that indicates all the client components that are used in the app, the client build should use this to generate the import map. Basically, instead of a generic import.glob('/path/**.*.client.jsx'), this would be replaced by specific components like {...import.glob('/path/C1.client.jsx'), ...import.glob('/path/C2.client.jsx')}.

This was done before GA in https://github.com/Shopify/hydrogen/pull/1247


Question about training multiple frames and fusion mechanism

Hi, thank you for your great work.
I have run the code and noticed that the given code only provides for single-frame training and missing the fusion mechanism (MLP, CA). It would be wonderful if you could provide the full version of those functions.
Thank you for this wonderful work.

Hi, thanks so much for your interest in our work!

Fusion Mechanism: The CA (cross-attention) fusion mechanism is actually the default throughout the experiments discussed in the paper and within the repository.

MLP Experiment: You can find the configuration for the MLP experiment in the covr_late-fusion.yaml file. To run it, use the following command: python train.py experiment=covr_late-fusion.

Single Frame and Multi-Frame Configurations: This repository primarily focusses on single-frame queries targeting multiple frames, as outlined in our main paper. The multi-frame query scenario, mentioned in Table A.4 of the Appendix, involves a significant increase in computational overhead. In order to keep the number of target frames constant using the same batch size, we had to pre-extract frame embeddings from the input video and store them in memory. It is necessary to save not just the CLS token but all tokens, each frame's embedding is of size [577, 1024] - IIRC. As you might expect, this can lead to memory requirements in the order of hundreds of GBs. If you're planning to replicate this setup or have further questions, feel free to ask :)

I hope this helps clarify your questions. Feel free to reach out if you need further information.


fix: restrict static middleware fs access

Description
Fix #5345
This PR modifies the fs-serve playground so the allowed folder is not the same as the root, so we can also test the static middleware file access.
@antfu there are two TODO: in the code:
 // TODO: should use ensureServingAccess(fileUrl, server)
 if (!isFileServingAllowed(fileUrl, server)) {
   return next()
 }

We should use ensureServingAccess so an AccessRestrictedError is thrown and catched later to respond with a 403, but when I tried this the program was terminating unexpectedly and I couldn't figure out why. The current code is skipping the url if it isn't allowed, so the response is a 404. We could evaluate merging as is, since this is a security vulnerability. And improve later, but maybe you see what I missed.
Maybe it isn't a bad idea to enqueue this change for the 2.7 beta if we are going to start the process soon.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Guess we could release this as a part of 2.6 before we flip the default in 2.7

@antfu sooner the better.


Update strategy token address for Dracula Protocol to have a correct …

Update strategy token address for Dracula Protocol to have a correct checksum.
We're having an issue with some proposals -- they don't display properly, e. g. https://snapshot.page/#/dracula/proposal/QmXfCrTY5zXFPG4xTMaSQB1iXB8TPTaHzuWkvpsGntCAQh
We think that the strategy token address having invalid checksum might be a reason.

@Carmillap This proposal have a snapshot at block 11180534. Is the contract 0xc88a5D099F7DAF8bb9511323502dAddBda579D28 been created before that block? If not that is the issue. Checksuming the address will not fix that.

Closing this PR for now, feel free to open it again once you've done the changes.


raise ParserError for unsupported datetime formats

https://github.com/crsmithdev/arrow/issues/456

Codecov Report

Merging #483 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #483   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          14     14
  Lines        3189   3199   +10
  Branches      229    232    +3
=====================================
+ Hits         3189   3199   +10

Impacted Files
Coverage Δ

arrow/parser.py
100% <100%> (ø)
:arrow_up:

tests/parser_tests.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33925e...1339553. Read the comment docs.

Hey 	@armando1793, thanks for the contribution, but we have implemented a more general and robust regular expression solution to detecting invalid formats. You can check out the upcoming changes outlined here: https://github.com/crsmithdev/arrow/issues/612.

Oh sure no problem. Thanks for the update! I'll take a look at the changes

Feel free to take on some new issues though :). We are trying to re-invigorate arrow's development and need all the help we can get! As part of that process though, we are cleaning up some old issues and PRs.


Icon hard to see

On Ubuntu dark theme you cannot see the icon unless you hover over

Hi @v0l ! Could you please try this PR #21  to see if it resolves your issue?

The default color is now purple on the Linux and Windows platform, and it supports changing the color in the settings.


Fix export of catalog collator entity transformer

Fix export of defaultCatalogCollatorEntityTransformer.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks! :pray:


Build task is running forever in background and not displaying any message in the output window.

VSCode Version: 0.10.12-alpha
OS Version: Windows10

Steps to Reproduce:

Launch app and open a folder which contains .ts ile.
Press F1 and insert command "Configure Task Runner".
Verify task.json is generated with some default setting.
Update default setting for command args for your .ts file like below:
"args": ["testme.ts"],
Press ctrl+shift+B to build.

Actual:

testme.js is created and task runner icon is showing forever.
No message display in output window.

Expected:

Looks like task is running in background in infinite loop
When build is successful it should display message in the output window so that user can understand task status.

When User try to rebuild again by pressing Ctrl+Shift+B then it is sowing warning message like:
"There is an active running task right now. Terminate it first before executing another task."

I can't reproduce this using the latest alpha build.

Any additional steps / Info

Looks like the issue is with build indicator icon in the task bar. It is keep moving all the time and no clue to the user when build task gets over.
Can you try with the project placed at https://github.com/v-pavanp/ForTestingCode/blob/master/TypeScript.zip  and follow the below repro steps:
Steps:

Update the tasks.json with below args value:
{
// See http://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "0.1.0",
"command": "tsc",
"isShellCommand": true,
"args": ["app.ts"],
"showOutput": "silent",
//"cwd":"${workspaceRoot}/TypeScriptTypes/",
"problemMatcher": "$tsc"
}

Now build it and verify error message in oup-put window.
error TS5007: Cannot resolve referenced file: 'app.ts'.

Now update tasks.json again for args value as below and build it.
{
// See http://go.microsoft.com/fwlink/?LinkId=733558
// for the documentation about the tasks.json format
"version": "0.1.0",
"command": "tsc",
"isShellCommand": true,
"args": ["${workspaceRoot}/TypeScriptTypes/app.ts"],
"showOutput": "silent",
//"cwd":"${workspaceRoot}/TypeScriptTypes/",
"problemMatcher": "$tsc"
}

I could see the build icon is keep moving all the time. No clue when it is going to stop.

Closing the issue. With the new terminal runner I changed the strategy and the spinner is only shown when a build task is active. I tested it and I couldn't break it.


CLIXML deserialization of native commands sensitive to whitespace

Following the suggestion made at #1999, I was attempting to write a native command that outputs serialized PowerShell data and ran across a difference between the how the Windows and Linux versions handle whitespace in the CLIXML payload.
Steps to reproduce
Create a file foo.xml with the following contents:
#< CLIXML
<Objs Version="<IP_ADDRESS>" xmlns="http://schemas.microsoft.com/powershell/2004/04">
    <I32>12</I32>
</Objs>

Use a native command to print the output of foo.xml and pipe to Write-Output.
PS> cmd /c type foo.xml | Write-Output # Windows
PS> /bin/cat foo.xml | Write-Output # Ubuntu

Expected behavior
Each of the two snippets should display 12 to the console.
Actual behavior
The actual output depends on the host OS and PowerShell version:
PS> cmd /c type foo.xml | write-output
12
PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.693
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.693
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

By contrast, on Ubuntu, an error is raised:
PS> /bin/cat foo.xml | Write-Output
/bin/cat : Cannot process the XML from the 'Output' stream of '/bin/cat': Unexpected end of file has occurred. The following elements are not
closed: Objs. Line 1, position 81.
At line:1 char:1
+ /bin/cat foo.xml | Write-Output
+ ~~~~~~~~~~~~~~~~
    + CategoryInfo          : SyntaxError: (/bin/cat:String) [], XmlException
    + FullyQualifiedErrorId : ProcessStreamReader_CliXmlError

/bin/cat : Cannot process the XML from the 'Output' stream of '/bin/cat': Element 'Objs' with namespace name
'http://schemas.microsoft.com/powershell/2004/04' was not found. Line 1, position 6.
At line:1 char:1
+ /bin/cat foo.xml | Write-Output
+ ~~~~~~~~~~~~~~~~
    + CategoryInfo          : SyntaxError: (/bin/cat:String) [], XmlException
    + FullyQualifiedErrorId : ProcessStreamReader_CliXmlError

/bin/cat : Cannot process the XML from the 'Output' stream of '/bin/cat': Unexpected end tag. Line 1, position 3.
At line:1 char:1
+ /bin/cat foo.xml | Write-Output
+ ~~~~~~~~~~~~~~~~
    + CategoryInfo          : SyntaxError: (/bin/cat:String) [], XmlException
    + FullyQualifiedErrorId : ProcessStreamReader_CliXmlError

PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.15
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

On Ubuntu, these errors depend on the whitespace in the CLIXML payload:
PS> /bin/echo "#< CLIXML`n<Objs Version='<IP_ADDRESS>' xmlns='http://schemas.microsoft.com/powershell/2004/04'><I32>12</I32></Objs>" | Write-Output
12

Environment data
See above snippets.

We cannot reproduce this anymore on 7.2.0-preview.3. Please re-activate if you can still reproduce.


chore(main): release sandworm-utils 1.7.0

:robot: I have created a release beep boop
1.7.0 (2022-10-08)
Features

loadDependencies now returns package tree (d31c542)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/sandworm-hq/sandworm-utils/releases/tag/sandworm-utils-v1.7.0 :sunflower:


Pls update luxon to 3.0.1 for @angular/material-luxon-adapter

Feature Description
Please update luxon to v.3.0.1 for @angular/material-luxon-adapter.
Thanks!
Use Case
No response

Duplicate of https://github.com/angular/components/issues/25408.


recreate rag collection instead of falling back to stale version

Bug Report
Description
Bug Summary:
store_data_in_vector_db is used to store web pages after retrieval. Currently, new version of the page is retrieved, split into chunks, but because previous collection exists, new data is dropped. Queries are executed against previous version instead of latest.
Steps to Reproduce:

open a new chat, fetch a web page using '#' prefix, query the content (preferably content changeable by tester)
wait until content changes (or update the content manually)
in a new chat query the same page using '#' prefix
query results will be based on first request although second request was completed

Expected Behavior:

if a page is fetched again, latest version should be available for query

Actual Behavior:

if a page is fetched again, first retrieved version is stuck for all consequent queries

pull-req #1029 deletes the collection if an earlier version exists


[WIP][SPARK-42509][SQL] WindowGroupLimitExec supports codegen

What changes were proposed in this pull request?
Why are the changes needed?
WindowGroupLimitExec should supports codegen
Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
N/A

https://github.com/apache/spark/pull/40159 will replace this one.


Add Windows Mixed Reality support

In addition to Oculus and OpenVR I added Windows Mixed Reality support for UWP. This brings not only support for WMR headsets (which were already supported thanks to SteamVR) but also HoloLens, although testing for the latter would be needed. As the WMR motion controllers have a thumbstick and a touchpad, I made it available to differentiate between the two while they still map to the same on the other platforms.
To use Windows Mixed Reality you just add the API to the list of required APIs and preferably set it at the top of the list so that it won't use OpenVR which would result in an exception. Next you need to start the game from a CoreWindow context and set the optional parameter "isWindowsMixedReality" to true or else it uses the swap chain of the CoreWindow instead of the holographic space. Be sure to not activate the CoreWindow as this must happen after creating the holographic space which is done internally.
Current issues:

No post-processing
No MSAA
Controller movement is still a bit finicky especially when throwing things.
Just-In-Time debugging breaks when the headset looses tracking (just turn it off).

I hope this addition will lead to more titles produced with WMR support and as always please test it if you have a WMR device (or emulate it with the Windows Mixed Reality Portal app).

Will start testing this. Good work :)

@Aminator9000 Please let me know when this is ready for final review/merge (if not already).

@xen2 It is ready now although the above mentioned issues are still there. Those could be fixed later as I am currently not sure how to fix them.

Sorry for the late review, LGTM!
Thanks!

Please, help me to create a minimal WMR application. I do all what neccessary after reading all about VR in docs. I create UWP app, remove XAML Page component and edit App.OnLaunched code to this:
protected override void OnLaunched(LaunchActivatedEventArgs e)
{
	Game = new Game();
	Game.UnhandledException += Game_UnhandledException;
	Game.Run(new GameContextUWPCoreWindow(null, 0, 0, true));
}

WMR portal started, VR controllers visible in simulator, but all around is black. What I do wrong?

I found solution - *.t4 in Xenko sources contain code to create FrameworkView. No action needed :)


Wikey typo and readability

I did a pass through most of the documentation I have read for some minor readability polish.
The biggest additions are in the getting started FTP tutorial where I added a link to the FTP-specific documentation and a note that SFTP will only work with the default cPanel user, not an FTP-specific user, which I learned from the FTP documentation page.

You've been busy! Thanks again for going over all this!

Happy to help! I'm putting together a short course on personal website building using Reclaim for some graduate students I work with so I might have some more time to add things as I continue plotting out the material. Have you considered, or would you be interested in, a page on setting up SSL through cPanel and what that accomplishes?

That's awesome! I've definitely considered an SSL tutorial. Thing is I've also been holding off in hopes that we'll have a better way of integrating Let's Encrypt directly into cPanel in the near future. We're doing it for folks manually right now and I'd love to have a way to just offer free SSL rather than encouraging folks to pay for a cert via the traditional process.

That would be great. It seems like integration should be possible along the lines of the Apache module they packaged up for Debian though, from their various support forums, it looks like the automatic client tools have trouble with python 2.6. What does the manual process require?

We've been using the guide at https://forums.cpanel.net/threads/how-to-installing-ssl-from-lets-encrypt.513621/ that cPanel put together which does support Python 2.6, but it requires root access to provision and install the certs so we handle it by support request for those who ask for it. I assume (hope?) cPanel will be working on a user-facing interface to do the same thing in the future that could be built right in (even better would be firing it off by default when a domain is added to Apache so all domains would support SSL by default, not sure if that's just dreaming though).

Well they have marked the related feature request as "Planned" and the comment thread is full of one user advertising his commercial plugin, so it sounds like integration is indeed possible. In the meantime, I'm going to draft a post on the existing method to create and install a self-signed SSL cert so OwnCloud will stop telling me how vulnerable I am to MITM attacks. You are welcome to whatever I get together, in case it turns out to be useful.


Graph the max value rather than avg if rrdsingle disabled

With rrdsingle the average values are used for graphing. As the
timescale increases (say over a day or month) the average values
progressively reduce.  Using the maximum value over the longer periods
is arguably no less deceptive but it does produce more informative
graphs.
Signed-off-by: Kevin Darbyshire-Bryant<EMAIL_ADDRESS>

I have no objection, @hnyman - whats your take on it? I suppose you do more graphing these days than me

If I read the change correctly, it only handles the creation of the graph, not the actual collection of data.
Do you have a specific graph in mind where the max. value is "more informative" than average? When I think graphs like cpu, ping and interface that are interesting for "average" users, I think that average is more informative than max, as one single spike can otherwise change the shown data rather completely. Abandoning average totally (when not using the default rrdsingle) sounds too drastic to me.
I would go one step further and create an option in statistics/rrdtool page for selecting "max" or "average" to be displayed. That would depend on rrdsingle being disabled and would enable you to switch between showing max. values instead of avg values.
(And minor nitpicking on code, I would like to keep the default rrdsingle case as the default "then" branch, and push the more complex avg/max branch to "else".)

Please bear in mind I don't know lua :-)  The change looks at the 'create only average rra' option in the RRDtool config page, so the graph in theory follows the data being collected.
Ideally I'd like to see 'average' used for short-term timescales (last hour) for the spikes reason you mention.  I'm of the opinion that 'max' should be used for longer timescales as the average inevitably gets reduced - look at 'hour' timescale vs 'day' or 'week'.  Ideally, either some sort of switch (assuming the max data is being collected', or that shorter timescales default to 'avg', longer to 'max'.
Sorry, that's really beyond my lua programming.

I will try to make an attempt for the option that I proposed. (not for the timescale based logic, but for enabling the selection between max/avg.
Ps. I am no lua programmer either, but small changes are rather straightforward.

Fixed the nitpick at least :-)

Thanks, I will use your work as a base for extension with an option.
(I already made the first attempt, but I do not have the time to test it right now. Maybe later today...)

I implemented an option to toggle between max/avg values with https://github.com/openwrt/luci/commit/b213573682460dd395878c7369aba173f00bbb99

Thanks Hannu,
Much appreciated.
Kevin
On 12/05/16 08:32, Hannu Nyman wrote:

I implemented an option to toggle between max/avg values with b213573
https://github.com/openwrt/luci/commit/b213573682460dd395878c7369aba173f00bbb99
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/openwrt/luci/pull/721#issuecomment-218681422


HealthChecks middleware should be configurable as to when the details are shown

From @anurse on Tuesday, October 10, 2017 4:16:24 PM

May have sensitive info and want to expose the non-sensitive (Up, Down) status to a public endpoint, so authorization might be needed around the details
May want to only expose data if the status is Unhealthy, since systems like consul don't like Healthy health checks returning different data.

/cc @Drawaes
Copied from original issue: aspnet/Diagnostics#410

The health checks middleware will output something really simple as text/plain by default. This is fully customizable.


Is RBAC dataplane GA in Azure Search/Cognitive services ?

Under my Azure subscription I have no preview features enabled.
Before I received an error when trying to enable RBAC or Both in Azure search, since it was a preview feature.
Today, I no longer get this error message. But the documentation still states that it is a preview feature.
Not sure if this is the right place to ask, but is the documentation outdated ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2293a04c-2b13-4087-0b20-eebf2278f522
Version Independent ID: 9fc429b6-1f91-74e0-3f35-3b0e54ecd213
Content: Connect using Azure roles - Azure Cognitive Search
Content Source: articles/search/search-security-rbac.md
Service: cognitive-search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

Hi @knuterik91, RBAC is close to GA but not everything is ready yet. As you noticed, the preview stamp is removed from the portal, but the MGMT REST API, CLI and PS modules are still in the queue for release.  When everything is ready, that's when we'll remove the preview labels in the docs and add an entry to the What's New.

#please-close


trigger method's documentation is actually that of off

https://github.com/tgriesser/bookshelf/blob/master/lib/base/events.js#L62-L66
I'm writing a PR to fix it now.

Thanks @cspotcode - please be careful to target src/ folder (not lib/).


Add JMESPath extractor feature

@marklz  I'm creating this to track merging in your stuff.  There's going to be a whole bunch of merge conflicts of course because of all the changes for Python 3 compatibility, and I'll probably trim it down a little bit, but once I get it cleaned up, I'll merge if that's okay
Adds feature from https://github.com/svanoort/pyresttest/issues/78

@svanoort - any idea when you'll be able to get to releasing a new version with jmespath support? I obviously have a self interest - I'd like to use that version internally in our development...

@marklz As soon as this is merged, you'll get the ability to install from source and use the feature (probably this coming weekend, since that's when I'm likely to have a chunk of time).
The overall 1.7 release timeframe is "some time in January" but if you'd like to track the overall release progress, that's visible here: https://github.com/svanoort/pyresttest/milestones/1.7.0 - Python 3 + Unicode Fixes + CI/Testing

Replaced by https://github.com/svanoort/pyresttest/pull/156 with fixups


Unable to use fcl-js with gatsby

Steps to reproduce (create a stock gatsby app and add fcl dependencies):

install gatsby globally npm install -g gatsby
follow command line prompts, any choices from the prompt are fine
cd to created project and run npm install
create new gatsby project npm init gatsby
add fcl dependencies npm install --save @onflow/fcl @onflow/types
start server npm run develop
there's an error seen at http://localhost:8000/

Error seen in terminal:
 ERROR #98123  WEBPACK

Generating development JavaScript bundle failed

/Users/aniket/projects/learning/gatsby-fcl/src/pages/index.js
  20:18  error  'pageStyles' is not defined  no-undef

✖ 2 problems (1 error, 1 warning)

failed Re-building development bundle - 1.320s
ERROR in<EMAIL_ADDRESS>4:11-26
Module not found: Error: Can't resolve 'http' in '/Users/aniket/projects/learning/gatsby-fcl/node_modules/@improbable-eng/grpc-web-node-http-transport/lib'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
	- add a fallback 'resolve.fallback: { "http": require.resolve("stream-http") }'
	- install 'stream-http'
If you don't want to include a polyfill, you can use an empty module like this:
	resolve.fallback: { "http": false }
<EMAIL_ADDRESS>1:864-945 1:11380-11381
<EMAIL_ADDRESS>1:0-30 1:30-254 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714
1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714 1:254-714
1:254-714 1:254-714 1:254-714 1:1314-1315 1:1768-1769 1:2019-2024 1:2255-2267 1:2535-2541 1:2543-2551 1:2563-2569 1:2620-2627 1:2644-2652 1:25335-25336 1:27174-27181 1:27267-27272 1:27344-27351 1:27620-27625 1:29365-29370 1:30130-30137
1:30922-30929 1:31165-31172 1:32825-32826 1:32828-32829 1:32840-32841 1:34719-34731 1:35015-35023 1:35087-35093 1:35095-35108 1:35120-35126 1:35163-35170 1:35180-35190 1:35215-35222 1:35244-35260 1:35300-35308 1:35515-35522 1:35550-35551
1:35652-35653 1:35727-35728 1:35729-35730 1:35891-35892 1:36183-36184 1:36328-36329 1:36388-36389 1:36391-36392 1:36430-36431 1:37246-37251 1:37391-37396 1:40092-40093
 @ ./src/pages/index.js 9:0-37 10:0-35 11:0-6 29:11-36
 @ ./.cache/_this_is_virtual_fs_path_/$virtual/async-requires.js 16:11-18:5
 @ ./.cache/app.js 16:0-52 29:87-33:1 32:29-42 35:27-40 29:0-33:2

Hi @anikets webpack 5 removed node polyfills. We are currently addressing this issue in this ticket and it will should solve your issues in the release following that issue's completion.

@anikets There's a PR open right now in review to address it. The next alpha release after that would have it. You could also polyfill your node requirements in the meantime.

@chasefleming I think this is still not released; can't see any mention in CHANGELOG. Can you please update ETA if possible?

You could also polyfill your node requirements in the meantime.
Can you provide some more details here please? Any doc I can follow? Which functions need to be polyfilled?

@chasefleming I think this is still not released; can't see any mention in CHANGELOG. Can you please update ETA if possible?

You could also polyfill your node requirements in the meantime.

Can you provide some more details here please? Any doc I can follow? Which functions need to be polyfilled?

Add the following to your Gatsby Webpack config:
https://github.com/onflow/fcl-js/issues/982#issuecomment-1050450751

Here are the instructions for updating your Webpack config in Gatsby:
https://www.gatsbyjs.com/docs/how-to/custom-configuration/add-custom-webpack-config/

Thanks @10thfloor. It worked for me. I added gatsby-node.js in the root directory of my project. Installed node-polyfill-webpack-plugin (npm install node-polyfill-webpack-plugin).
Then added this in gatsby-node.js
`const NodePolyfillPlugin = require("node-polyfill-webpack-plugin")
module.exports = {
// Other rules...
plugins: [
new NodePolyfillPlugin()
]
}`
There are other approach as well as mentioned in this article :https://namespaceit.com/blog/how-fix-breaking-change-webpack-5-used-to-include-polyfills-for-nodejs-core-modules-by-default-error

Closed with the release of 1.0.0


Error when running  ansible-playbook main.yml

Hello all. I was able to install and its currently running. I made some changes to the config.yml for passwords and ran ansible-playbook main.yml a 2nd time to push updates. i got the following error. I'm running this in a Ubuntu 24.02 anbd python 3.12. i did start with running it in venv but that gave the same  error and went locally.
TASK [Gathering Facts] *********************************************************
fatal: [<IP_ADDRESS>]: FAILED! => {"ansible_facts": {}, "changed": false, "failed_modules": {"ansible.legacy.setup": {"ansible_facts": {"discovered_interpreter_python": "/usr/bin/python3.12"}, "failed": true, "module_stderr": "sudo: a password is required\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}}, "msg": "The following modules failed to execute: ansible.legacy.setup\n"}

i ran as sudo with an error. but then ran without sudo after that and it worked with no issues. idk lol feel free to close this.


Build a data pipeline for running unlabelled papers through the labeller

Get paper data from lens.org
https://docs.api.lens.org/index.html

Transform paper data into the format expected by MATCH. See https://github.com/nasa-petal/PeTaL-labeller/issues/43 for the expected format (the label field will contain an empty array.).

@dsmith111 just created a script that may help convert data into the MATCH format. https://github.com/nasa-petal/PeTaL-labeller/tree/main/scripts/lens-cleaner

@bruffridge do we need any follow-ups/further scripting to this issue? I know migrating to lambda was mentioned

Eventually the plan is for this to run in lambda. For now, we just need a python script that downloads the json on every paper from lens.org, and transforms them into the format expected by MATCH. I meet with lens.org tomorrow morning, the API might not be the best choice for this due to rate limiting, they have a bulk download option that I'm going to ask them about.

Some metrics for consideration:
5000 papers per API request (or it might timeout based on my testing).
~7 seconds per API request
~10.81MB per request.
Total: ~5 hours, ~28gb, and 2600 requests to pull down 13,000,000 biology papers using MAG API.

The papers returned are consistently ordered between requests even without a sortby parameter, which means we can probably use the offset and limit parameters to chunk through the full dataset.
1st API request:
limit: 5000
offset: 0

2nd API request:
limit: 5000
offset: 5000

3rd API request:
limit: 5000
offset: 10000

and so on...


Admin command to reload factorio

This is important because I currently do not reload lua data if factorio was updated.

This hasn't shown to be a big enough issue to matter.  The current workaround is to simply restart blueprint bot, which sounds good enough for me.


Replace boost::system::error_code with std::error_code

Since Boost 1.65.0, boost::system::error_code is implicitly convertible to std::error_code. This takes care of compatibility when the error_code is taken by value or const ref; functions taking the error_code by mutable ref need to be manually mapped.

Do we need/want to retain boost serialization (possibly retain but guard by HPX_SERIALIZATION_WITH_BOOST_TYPES)?

I thought we had gotten rid of Boost serialization a long time ago. Anything still in the code base must be a leftover.

I meant serialization of boost::system::system_error.
It's unclear to me what the goal behind that support is, but it has been special cased alongside standard exception types, and it isn't guarded by HPX_SERIALIZATION_WITH_BOOST_TYPES, so it must have some foundational value. The question is whether that needs to be migrated to std::system_error, extended to std::system_error, or left as-is.
We are not explicitly throwing system_error ourselves (hpx::exception extends it, and it has migrated form boost to std, but that type is also special-cased). These exceptions may be originating from within Boost, likely ASIO (and possibly Filesystem too, before the switch). If that's the scenario the serialization of boost::system::system_error caters to then it needs to stay in its current form (ideally eventually wrapped in hpx::exception if those originate from core). That would suggest that support ought to have been extended to std::system_error already, but I'm not entirely sure.

It's unclear to me what the goal behind that support is, but it has been special cased alongside standard exception types, and it isn't guarded by HPX_SERIALIZATION_WITH_BOOST_TYPES, so it must have some foundational value. The question is whether that needs to be migrated to std::system_error, extended to std::system_error, or left as-is.

The safest way would be to leave it in and guard it with HPX_SERIALIZATION_WITH_BOOST_TYPES. As you said, the only reason it might be needed would be Boost.Asio and/or Boost/Filesystem.

I suppose the question is if we expect those exceptions to be thrown and then serialized from within HPX or if those are just there for convenience for users encountering boost exceptions. If the former I suppose they should not be guarded, but I'm not sure in what situation that would happen. Would e.g. parcel pool ASIO exceptions from a remote locality end up being serialized to the main locality? Writing that I realize that even if they don't they probably should. If it's only the latter, i.e. for exceptions from user code then guarding with that ifdef sounds appropriate.

Would e.g. parcel pool ASIO exceptions from a remote locality end up being serialized to the main locality?

That is indeed the question.

Writing that I realize that even if they don't they probably should.

I think those should be transported as HPX exceptions (if they aren't already). The user needs not know to expect ASIO errors.

I believe this can be removed now as well: https://github.com/STEllAR-GROUP/hpx/blob/master/cmake/HPX_SetupBoost.cmake#L58-L62

We still need to link to Boost.System if ASIO and/or Filesystem internally use it. Filesystem may already be handled at the cmake level, but ASIO doesn't exist as an imported target so it wouldn't pull the usage requirement.

The build failure with syscall is quite mysterious... I'll see if I can figure out what's wrong there.

@K-ballo the thread_mapper.cpp file is missing an #include <unistd.h> next to the syscall include (https://github.com/STEllAR-GROUP/hpx/blob/5c06192914e787230f35be7ccd55b496f6f46ffa/libs/full/runtime_local/src/thread_mapper.cpp#L26). I suppose this must have come as a transitive include before these changes. I think you can include it unconditionally (we have a feature check for it) since the syscall include is already guarded by __linux__ which we know is POSIX.

Thanks @K-ballo! The remaining test failure is definitely unrelated to these changes.


Fix the namespacing and cookstyle violations in validators (Fixes #80)

Description
Moves helpers to their own library and addresses them from the root namespace (since callbacks appear to be in an isolated namespace now that we're using custom resources.
Also, I added a dependency for the compat_resource cookbook so that the cookbook really is compatible with Chef 12.5 as claimed in the metadata.
Issues Resolved

Fixes #80: Default value "*" is invalid for property [...] of resource cron_d. In Chef 13 this will become an error

Check List

[✓] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[NA] New functionality includes testing.
[NA] New functionality has been documented in the README if applicable
[✓] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Thanks for fixing this @eherot

Of course!