HAWQ-405. Fix for handling of pg_temp schema

I think it would be good to add the two cases that failed to installcheck-good. I checked, and there is already a temp test suite (src/test/regress/expected/temp.out, src/test/regress/sql/temp.sql) that can be a good place for them.

+1

Added to installcheck-good

+1 :)


Add a blocklist to Pebble

What this PR does / why we need it:
This is for @maelvls's PR to simulate the blocked domain behaviour in Pebble.
This still needs testing, having kind issues at the moment so there is some delay.
Special notes for your reviewer:
Currently using my fork of Pebble until I tested it, PRed it and is accepted
Release note:

NONE

Oops put too many files in here

/kind feature

/kind cleanup
might be better...

/lgtm


About - Distiny的博客 | 且听风吟

https://distiny-cool.github.io/about/
Actions speak louder than words.

抢占一楼！


MDBE: Adjust the parser to support the new complex type construct

Note: Adjusted the grammar has a PR. Migration team is going to pick it up.


error rolling on loot table

On version 3.5.10
Trying to roll on a loot table generates :
LootProcessor.js:43 Uncaught (in promise) TypeError: this.rawResults is not iterable
[Detected 1 package: lootsheetnpc5e]
at LootProcessor.buildResults (LootProcessor.js:43:35)
at async Function.addLootToTarget (ActorHelper.js:171:17)
at async Function.seedItemsToActors (LootSeeder.js:36:109)
at async SheetListener.inventoryUpdateListener (SheetListener.js:164:62)

Nevermind, apparently this is caused if you don't set a roll method on the loot table itself :)


fix(bar):issues/17754

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

Fixed issues
issues/17754
Details
Before: What was the problem?

After: How does it behave after the fixing?

Document Info
One of the following should be checked.

[x] This PR doesn't relate to document changes
[ ] The document should be updated later
[ ] The document changes have been made in apache/echarts-doc#xxx

Thanks for your contribution. I don't think this is a bug. Please continue the discussion in the issue.


excessive PSF fitting

Even though the bounding box specified is small (just 4 sources), a PSF is being fit a huge number of times...perhaps for every primary source?
$ ./celeste.jl --logging=DEBUG infer-nersc 200.15 200.17 38.15 38.17

23-Mar 09:19:23:INFO:root:1571 primary sources
23-Mar 09:19:23:INFO:root:876 primary sources after MIN_FLUX cut
23-Mar 09:19:23:INFO:root:processing 4 sources in RA/Dec range
...

The program hasn't finished running but it looks like it's already fit 74 PSFs:
jregier@cori05~/Celeste/bin $ grep "Iter 1$" run30 | wc -l
74

Here run30 contains the output. The regex Iter 1$ occurs whenever a new optimization is begun. 74 seems way too high.

Isn't the PSF fit separately for each image for each source? So you would expect more than 4 * Nimages PSF fits.

You're right, thanks, I didn't consider how many run-camcol-fields cover this region. There are 4 fields, each has 5 bands, and there are 4 sources. So up to 80 PSF fits are possible, if all 4 sources are imaged in all 4 fields.


authenticated/unauthenticated

Issue in ./help/c-target/c-visitor-profile/working-with-customer-attributes.md
On the page it says: "If the vst.* parameters are the only thing identifying the visitor, the existing "authenticated" profile will not be fetched as long as authState is UNAUTHENTICATED (0). The profile will only come into play if authState is changed to UNAUTHENTICATED (1)."
Shouldn't it be AUTHENTICATED(1)?

Fixed. Thanks for the catch:
https://docs.adobe.com/content/dam/help/target.en/help/c-target/c-visitor-profile/assets/TargetAudience.png


Small objects

Thanks for your wonderful work. I would like to know how to detect small objects better. The objects on my own dataset are quite small. I have succeeded in training a model without pretrained models, but the result is not satisfactory.

Can you share the environment settings and some key points to train a model on your dataset? Do you encounter bugs in the process, if any how do you fix them?
Appreciate!


Error while parsing wrapped attribute

Hi @dapper91 again :blush:,
I'm trying to use the lib to parse HL7 aECG files.
Let's take this file as an example.
I have the following program:
from typing import Optional
from urllib.request import urlopen
from uuid import UUID

from pydantic_xml import BaseXmlModel, attr, element, wrapped

class EffectiveTime(BaseXmlModel, tag="effectiveTime", search_mode="unordered"):
    center: str = wrapped("center", attr(name="value"))

class Code(BaseXmlModel, tag="code", search_mode="unordered"):
    code: str = attr()
    code_system: str = attr(name="codeSystem")
    code_system_name: Optional[str] = attr(name="codeSystemName", default=None)
    display_name: Optional[str] = attr(name="displayName", default=None)

class AnnotatedECG(BaseXmlModel, nsmap={"": "urn:hl7-org:v3"}, search_mode="unordered"):
    id: UUID = wrapped("id", attr(name="root"))
    code: Code
    text: Optional[str] = element(default=None)
    effective_time: EffectiveTime

    # This is working
    # center: str = wrapped("effectiveTime/center", attr(name="value"))

file_url = "https://raw.githubusercontent.com/FDA/aecg-python/refs/heads/main/src/aecg/data/hl7/2003-12%20Schema/example/Example%20aECG.xml"

with urlopen(file_url) as f:
    xml_doc = f.read()

aecg_o = AnnotatedECG.from_xml(xml_doc)

print(aecg_o)

And I have the following error:
pydantic_core._pydantic_core.ValidationError: 1 validation error for AnnotatedECG
effective_time.center
  [line -1]: Field required [type=missing, input_value={}, input_type=dict]

I can't understand why the error occurs (especially since the commented line, which is equivalent for me, works correctly). What am I doing wrong?

@ghilesmeddour Hi,
Namespaces are not inherited by nested models, so they must be explicitly defined for all models:
from typing import Optional
from uuid import UUID

from pydantic_xml import BaseXmlModel, attr, element, wrapped

NSMAP = {"": "urn:hl7-org:v3"}

class EffectiveTime(BaseXmlModel, tag="effectiveTime", nsmap=NSMAP, search_mode="unordered"):
    center: str = wrapped("center", attr(name="value"))

class Code(BaseXmlModel, tag="code", nsmap=NSMAP, search_mode="unordered"):
    code: str = attr()
    code_system: str = attr(name="codeSystem")
    code_system_name: Optional[str] = attr(name="codeSystemName", default=None)
    display_name: Optional[str] = attr(name="displayName", default=None)

class AnnotatedECG(BaseXmlModel, nsmap=NSMAP, search_mode="unordered"):
    id: UUID = wrapped("id", attr(name="root"))
    code: Code
    text: Optional[str] = element(default=None)
    effective_time: EffectiveTime

    # This is working
    # center: str = wrapped("effectiveTime/center", attr(name="value"))

Thanks @dapper91 for your help. To make it clearer for me, in my first snippet, why does it work for Code without namespace but not for EffectiveTime.

Thank you very much @dapper91 for your help.
I'll take the opportunity to ask another question. The input files can have different namespaces ([None, "urn:hl7-org:v1", "urn:hl7-org:v2", "urn:hl7-org:v3"]) and I want to parse them the same way. Is there any way to do this transparently, to ignore namespaces  completely or to specify a namespace at parsing time (as a from_xml parameter for example) and not at models definition.


Product is Too Buggy and Not Worth the Price

Describe the bug
This company lacks transparency, frequently changing their pricing and removing access to beta features. On top of that, their product is mediocre. After adding just 3-4 functionalities, the system struggles to handle more and introduces bugs everywhere. I constantly have to deal with error messages, which is frustrating. I won’t be using this unreliable tool any longer. Goodbye!"
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-kyep9h
Steps to reproduce
code mess
Expected behavior
following user intentions
Screen Recording / Screenshot
No response
Platform
Browser name = Firefox
Full version = 129.0
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0
performance.memory = undefined
Username = oloho
Chat ID = 4e0809e3b2b3

Additional context
No response

Sorry you had a poor experience. If you need a refund, please reach out to<EMAIL_ADDRESS>Hopefully we can re-earn your business as the product improves!

I have yet to even get one of the demos running without vomiting errors then hanging, and those should be a selling point 😬


siterestrict() AttributeError

Environment details

OS: MacOS
Python version: 3.6.8
pip version: 19.1.1
google-api-python-client version:

Steps to reproduce
Hello,
When I use the following code:
service = build("customsearch", "v1", developerKey=<your_api_key>)
res = service.cse().siterestrict().list(
    q=query_word,
    cx=<your_custom_search_id>,
).execute()

I receive the following error:
    res = service.cse().siterestrict().list(
AttributeError: 'Resource' object has no attribute 'siterestrict'

Strangely, I do not receive this error all the time, but most of the time (unclear of a specific percentage). Without siterestrict(), I do not receive this error at all. Is there any reason why? I do have my CSE set to have fewer than 10 sites in the "Sites to Search section" and "Search the entire web" option set to OFF.
Furthermore, what are some steps to makeTo run a restricted search, is it necessary to include this command, or is it sufficient to have 10 or fewer sites in the "Sites to Search" section, and the "Search the entire web" option set to OFF?

How often do you see the error?
The only way for that error to exist would be the siterestrict resource not existing in the discovery document.

Hi,
Honestly, pretty randomly. Sometimes every 200 calls, sometimes every other call. When I run without siterestrict(), I never receive the error.
I've been going off the documentation from from here. Can you point me to where I should be looking in the discovery document?

Hi @whatsananne,
The Python library pulls a JSON representation of the API from https://www.googleapis.com/discovery/v1/apis/customsearch/v1/rest and constructs a service client. So if a resource is disappearing, it would mean either:

There is something non-deterministic about discovery.build()
The published discovery document itself is changing.

I tested this out with a script that repeatedly builds the service until it encounters the AttributeError. It looks like it is actually the second case - the discovery document sometimes has both cse and siterestrict as top-level resources instead of placing siterestrict under cse.   I am filing a bug with the API team to ask them to investigate.
import json

import requests
from googleapiclient import discovery

DISCOVERY_URL = "https://www.googleapis.com/discovery/v1/apis/customsearch/v1/rest"

for i in range(0, 100000):
    resp = requests.get(DISCOVERY_URL)
    discovery_doc = resp.json()
    service = discovery.build_from_document(discovery_doc)
    try:
      service.cse().siterestrict()
    except AttributeError:
      with open("bad_siterestrict_v1.json", "w") as f:
        f.write(json.dumps(discovery_doc))
        break

As a workaround, you can save a good copy fo the discovery doc from https://www.googleapis.com/discovery/v1/apis/customsearch/v1/rest and use discovery.build_from_document()
import json
from googleapiclient import discovery

with open("customsearch_v1.json") as f:
    document = json.load(f)

service = discovery.build_from_document(document)

When did you start experiencing this behavior?

Googlers, see internal issue 155117315.
The infrequency of the error appearing seems to be a result of new discovery docs being rolled out gradually.

Thank you so much advice, I will try to that workaround. I began using the API about 10 days ago, and this error began occurring right away.

This started happening for me today on a single server.
build('androidpublisher', 'v3') didn't have purchases().subscriptions().
I replaced that line with this, which works for some reason:
DISCOVERY_URL = "https://www.googleapis.com/discovery/v1/apis/androidpublisher/v3/rest"
discovery_doc = requests.get(DISCOVERY_URL).json()
build_from_document(discovery_doc)

@salty-horse Most likely android publisher is rolling out a new discovery doc. Did the failure occur multiple times?

The error occurred consistently for the hour I spent investigating it.
Any idea why my workaround  works? Is the URL I'm downloading "manually" different than the one the library is using?

Discovery docs are rolled out gradually, so it's normal to see two different versions at the same time. When I was debugging the CSE error I only got the newer discovery doc once every ten thousand or so requests.
I've reached out to some folks on the Android Publisher team to ask them if they have any recent discovery doc rollouts.

@salty-horse It looks like that must have been a transient error. I confirmed with the backend folks that they haven't rolled out a new discovery doc recently.
Please open a new issue if you start experiencing problems.


ci: PLT-353: add graceful shutdown script for celery

Commit https://github.com/HumanSignal/infra/commit/bf95df2b304147000d3f4c1a85bfffcd8408b25d is created.

Codecov Report
Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 44.16%. Comparing base (b20edc1) to head (f4a45f4).
Report is 1 commits behind head on master.

Files
Patch %
Lines

server/tasks/queue_terminator.py
0.00%
36 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   45.06%   44.16%   -0.90%
==========================================
  Files          39       40       +1
  Lines        1782     1818      +36
==========================================
  Hits          803      803
- Misses        979     1015      +36

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Commit https://github.com/HumanSignal/infra/commit/3d7df7f49c6bc84603ae927d3f7114474ec0cbed is created.

Commit https://github.com/HumanSignal/infra/commit/64815946414a7cd65938a24c8b3fbcb09bc2c644 is created.


[BUG] Wifi SSID does not show up on MacOS sequoia

Be sure to read the FAQ before submitting a new issue.

General description of bug:

What happened: Wifi SSID is not showing up
What should happen: Show the SSID of the current network
Fastfetch version used: fastfetch 2.23.0 (aarch64)
Did it work in an older version: no idea
Where did you get the binary: homebrew
Does this issue still occur in the latest dev build? It hangs when finding the ssid, then skips displaying it.

Often helpful information:
This only happens on MacOS Sequoia (15)
Screenshot:

The content of the configuration file you use (if any):
{
  "$schema": "https://github.com/fastfetch-cli/fastfetch/raw/dev/doc/json_schema.json",
  "logo": {
    "type": "kitty-direct",
    "source": "~/.config/fastfetch/apple.png",
    "padding": {
      "left": 1,
      "right": 2,
      "top": 1
    },
    "height": 8,
    "width": 16
  },
  "display": {
    "separator": "  ",
    "constants": [
      "─────────────────" // {$1}, used in Custom module
    ],
    "key": {
      "type": "icon",
      "paddingLeft": 2
    }
  },
  "modules": [
    {
      "type": "custom", // HardwareStart
      // {#1} is equivalent to `\u001b[1m`. {#} is equivalent to `\u001b[m`
      "format": "┌{$1} {#1}Hardware Information{#} {$1}┐"
    },
    "host",
    "cpu",
    "gpu",
    "disk",
    "memory",
    "swap",
    "display",
    "battery",
    "poweradapter",
    "bluetooth",
    {
      "type": "custom", // SoftwareStart
      "format": "├{$1} {#1}Software Information{#} {$1}┤"
    },
    {
      "type": "title",
      "keyIcon": "",
      "key": "Title", // Title module has no key by default, so that icon is not displayed
      "format": "{user-name}"
    },
    "os",
    "shell",
    "terminal",
    "terminalfont",
    "icons",
    "packages",
    "uptime",
    "media",
    {
      "type": "localip",
      "compact": true
    },
    {
      "type": "wifi",
      "format": "{ssid}"
    },
    {
      "type": "custom", // InformationEnd
      "format": "└{$1}──────────────────────{$1}┘"
    },
    {
      "type": "colors",
      "paddingLeft": 2,
      "symbol": "circle"
    }
  ]
}

Output of fastfetch -c ci.jsonc --format json:
// relevant info only
  {
    "type": "Wifi",
    "result": [
      {
        "inf": {
          "description": "en0",
          "status": "Power On"
        },
        "conn": {
          "status": "Active",
          "ssid": "<unknown ssid>",
          "bssid": "",
          "protocol": "Unknown (32)",
          "security": "Insecure",
          "signalQuality": 100.0,
          "rxRate": null,
          "txRate": 173.0
        }
      }
    ],
    "stat": 33.83100000023842
  },

Output of fastfetch --list-features:
threads
vulkan
imagemagick7
chafa
zlib
sqlite3

756865855b111d835f1ee1002f88ecf7b83eb5b7

After this bug is fixed, Fastfetch takes around 3–4 seconds to load Wi-Fi information. Is this expected? The command system_profiler SPAirPortDataType -xml -detailLevel basic takes the same time for me, so the delay is likely caused by the System Profiler. If it is not just my system that slows down that bad, maybe there is another way for Fastfetch to obtain that information?

maybe is meaningless. If you know a better method, let me know.

This does require sudo, but takes 238 ms on my machine.
sudo wdutil info | awk '/SSID/ {print $3 | "head -n 1"}'

sudo wdutil info | awk '/SSID/ {print $3 | "head -n 1"}'

I got <redacted>

Interesting, because it worked on my machine.

Are you on macOS 14 or 15?
You can try just running sudo wdutil info to see if wdutil is printing anything useful at all.
If that doesn't work for some reason, maybe run the wdutil info method first, and if it returns <redacted>, then run the slower 3 second command.

I think sudo wdutil info works for SSID in 14.4 and at least also 15.1 beta.
https://community.jamf.com/t5/jamf-pro/collecting-active-ssid-with-macos-sonoma-14-4-and-later/m-p/311680
They say its disabled in 14.5 though.


outdated link in readme

this link from the readme.md goes nowhere currently.
https://github.com/GenomicsStandardsConsortium/mixs/blob/main/release

Thanks @alicemchardy, I have now corrected that link in the readme.


[Improvement]: Support setting the Flink dependency version of the optimizer with the maven profile

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
As discussion #645 describes, the Arctic optimizer is dependent on Flink 1.12 now.
If the user wants to run the optimizer with another version Flink environment, he needs to change the pom manually.
We may support setting the Flink dependency version of the optimizer with the maven profile to simplify the operation.
BTW, I do suggest changing the default build version of Flink to 1.14 or higher.
How should we improve?
Add profiles in optimizer/pom.xml to support setting different Flink dependency versions including 1.12/1.14/1.15.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey, i want to try this out can you assign it to me?

Sure, and thanks a lot for your work!

@tobehardest Are you still following this issue?

、

@tobehardest你还在关注这个问题吗？

I have a lot of things to do recently, and I can't finish it for the time being. Maybe can assign this task to other people?

OK, In that case, I will unassign it, and the issue will remain open for all community developers to contribute.


Cannot build TensorT engine for classification models

Hello,
I tried to reproduce the optimization process you decribed in your Accelerating GPT-2 model notebook demo for optimizing a model for ONNX Runtime and Triton server, but with a classification model (namely facebook/bart-large-mnli which I found on HuggingFace's hub).
However I get a problem when trying to build a TensorRT engine from the corresponding ONNX file: the task fails and the resulting engine is of type NoneType. I also tried using the TensorRT builder's build_engine method but the result is also of type NoneType.
TypeError: deserialize_cuda_engine(): incompatible function arguments. The following argument types are supported:
    1. (self: tensorrt.tensorrt.Runtime, serialized_engine: buffer) -> tensorrt.tensorrt.ICudaEngine

Invoked with: <tensorrt.tensorrt.Runtime object at 0x7ff47c047270>, None

After investigating a bit, I found out that this problem arises when initializing facebook/bart-large-mnli with the BartForSequenceClassification class, but not when initializing it with the BartForConditionalGeneration class, even though the model was specifically fine-tuned for the MNLI classification task.
The whole code is attached in a ipynb file and I ran it using Google Colab.
Could you please help me resolve it ? Thanks in advance for your help !
Versions:

Python: 3.7.13
transformers-deploy: 0.5.0
TensorRT: <IP_ADDRESS>
Onnxruntime (GPU): 1.11.1
transformers: 4.20.1

To reproduce:
model_optimization.zip

Sorry for the delay, I was on vacation.
Can you run the conversion with trtexec and share the logs?
It provides meaningful error message unlike the Python wrapper.

Sorry for the delay, I was on vacation.
Can you run the conversion with trtexec and share the logs? It provides meaningful error message unlike the Python wrapper.

Hello, thank you very much for your reply. I'm sorry for the late answer, I was on vacation as well !
I ran the conversion with trtexec as you requested, and I get the following log:
&&&& RUNNING TensorRT.trtexec [TensorRT v8401] # ./trtexec --onnx=/content/drive/MyDrive/model.onnx --minShapes=input:1x128 --optShapes=input:1x128 --maxShapes=input:1x128 --shapes=input:1x128 --best --workspace=10000 --saveEngine=test.plan
[07/26/2022-04:30:36] [W] --workspace flag has been deprecated by --memPoolSize flag.
[07/26/2022-04:30:36] [I] === Model Options ===
[07/26/2022-04:30:36] [I] Format: ONNX
[07/26/2022-04:30:36] [I] Model: /content/drive/MyDrive/model.onnx
[07/26/2022-04:30:36] [I] Output:
[07/26/2022-04:30:36] [I] === Build Options ===
[07/26/2022-04:30:36] [I] Max batch: explicit batch
[07/26/2022-04:30:36] [I] Memory Pools: workspace: 10000 MiB, dlaSRAM: default, dlaLocalDRAM: default, dlaGlobalDRAM: default
[07/26/2022-04:30:36] [I] minTiming: 1
[07/26/2022-04:30:36] [I] avgTiming: 8
[07/26/2022-04:30:36] [I] Precision: FP32+FP16+INT8
[07/26/2022-04:30:36] [I] LayerPrecisions:
[07/26/2022-04:30:36] [I] Calibration: Dynamic
[07/26/2022-04:30:36] [I] Refit: Disabled
[07/26/2022-04:30:36] [I] Sparsity: Disabled
[07/26/2022-04:30:36] [I] Safe mode: Disabled
[07/26/2022-04:30:36] [I] DirectIO mode: Disabled
[07/26/2022-04:30:36] [I] Restricted mode: Disabled
[07/26/2022-04:30:36] [I] Build only: Disabled
[07/26/2022-04:30:36] [I] Save engine: test.plan
[07/26/2022-04:30:36] [I] Load engine:
[07/26/2022-04:30:36] [I] Profiling verbosity: 0
[07/26/2022-04:30:36] [I] Tactic sources: Using default tactic sources
[07/26/2022-04:30:36] [I] timingCacheMode: local
[07/26/2022-04:30:36] [I] timingCacheFile:
[07/26/2022-04:30:36] [I] Input(s)s format: fp32:CHW
[07/26/2022-04:30:36] [I] Output(s)s format: fp32:CHW
[07/26/2022-04:30:36] [I] Input build shape: input=1x128+1x128+1x128
[07/26/2022-04:30:36] [I] Input calibration shapes: model
[07/26/2022-04:30:36] [I] === System Options ===
[07/26/2022-04:30:36] [I] Device: 0
[07/26/2022-04:30:36] [I] DLACore:
[07/26/2022-04:30:36] [I] Plugins:
[07/26/2022-04:30:36] [I] === Inference Options ===
[07/26/2022-04:30:36] [I] Batch: Explicit
[07/26/2022-04:30:36] [I] Input inference shape: input=1x128
[07/26/2022-04:30:36] [I] Iterations: 10
[07/26/2022-04:30:36] [I] Duration: 3s (+ 200ms warm up)
[07/26/2022-04:30:36] [I] Sleep time: 0ms
[07/26/2022-04:30:36] [I] Idle time: 0ms
[07/26/2022-04:30:36] [I] Streams: 1
[07/26/2022-04:30:36] [I] ExposeDMA: Disabled
[07/26/2022-04:30:36] [I] Data transfers: Enabled
[07/26/2022-04:30:36] [I] Spin-wait: Disabled
[07/26/2022-04:30:36] [I] Multithreading: Disabled
[07/26/2022-04:30:36] [I] CUDA Graph: Disabled
[07/26/2022-04:30:36] [I] Separate profiling: Disabled
[07/26/2022-04:30:36] [I] Time Deserialize: Disabled
[07/26/2022-04:30:36] [I] Time Refit: Disabled
[07/26/2022-04:30:36] [I] Inputs:
[07/26/2022-04:30:36] [I] === Reporting Options ===
[07/26/2022-04:30:36] [I] Verbose: Disabled
[07/26/2022-04:30:36] [I] Averages: 10 inferences
[07/26/2022-04:30:36] [I] Percentile: 99
[07/26/2022-04:30:36] [I] Dump refittable layers:Disabled
[07/26/2022-04:30:36] [I] Dump output: Disabled
[07/26/2022-04:30:36] [I] Profile: Disabled
[07/26/2022-04:30:36] [I] Export timing to JSON file:
[07/26/2022-04:30:36] [I] Export output to JSON file:
[07/26/2022-04:30:36] [I] Export profile to JSON file:
[07/26/2022-04:30:36] [I]
[07/26/2022-04:30:36] [I] === Device Information ===
[07/26/2022-04:30:36] [I] Selected Device: Tesla P100-PCIE-16GB
[07/26/2022-04:30:36] [I] Compute Capability: 6.0
[07/26/2022-04:30:36] [I] SMs: 56
[07/26/2022-04:30:36] [I] Compute Clock Rate: 1.3285 GHz
[07/26/2022-04:30:36] [I] Device Global Memory: 16280 MiB
[07/26/2022-04:30:36] [I] Shared Memory per SM: 64 KiB
[07/26/2022-04:30:36] [I] Memory Bus Width: 4096 bits (ECC enabled)
[07/26/2022-04:30:36] [I] Memory Clock Rate: 0.715 GHz
[07/26/2022-04:30:36] [I]
[07/26/2022-04:30:36] [I] TensorRT version: 8.4.1
[07/26/2022-04:30:37] [I] [TRT] [MemUsageChange] Init CUDA: CPU +0, GPU +0, now: CPU 0, GPU 367 (MiB)
[07/26/2022-04:30:38] [I] [TRT] [MemUsageChange] Init builder kernel library: CPU +0, GPU +2, now: CPU 0, GPU 369 (MiB)
[07/26/2022-04:30:38] [I] Start parsing network model
[libprotobuf WARNING google/protobuf/io/coded_stream.cc:604] Reading dangerously large protocol message.  If the message turns out to be larger than<PHONE_NUMBER> bytes, parsing will be halted for security reasons.  To increase the limit (or to disable these warnings), see CodedInputStream::SetTotalBytesLimit() in google/protobuf/io/coded_stream.h.
[libprotobuf WARNING google/protobuf/io/coded_stream.cc:604] Reading dangerously large protocol message.  If the message turns out to be larger than<PHONE_NUMBER> bytes, parsing will be halted for security reasons.  To increase the limit (or to disable these warnings), see CodedInputStream::SetTotalBytesLimit() in google/protobuf/io/coded_stream.h.
[libprotobuf WARNING google/protobuf/io/coded_stream.cc:81] The total number of bytes read was<PHONE_NUMBER>
[07/26/2022-04:30:55] [W] [TRT] onnx2trt_utils.cpp:369: Your ONNX model has been generated with INT64 weights, while TensorRT does not natively support INT64. Attempting to cast down to INT32.
[07/26/2022-04:30:55] [W] [TRT] onnx2trt_utils.cpp:395: One or more weights outside the range of INT32 was clamped
[07/26/2022-04:30:55] [W] [TRT] onnx2trt_utils.cpp:395: One or more weights outside the range of INT32 was clamped
[07/26/2022-04:30:55] [W] [TRT] onnx2trt_utils.cpp:395: One or more weights outside the range of INT32 was clamped
[07/26/2022-04:30:55] [W] [TRT] onnx2trt_utils.cpp:395: One or more weights outside the range of INT32 was clamped
[07/26/2022-04:30:57] [W] [TRT] onnx2trt_utils.cpp:395: One or more weights outside the range of INT32 was clamped
[07/26/2022-04:30:57] [W] [TRT] onnx2trt_utils.cpp:395: One or more weights outside the range of INT32 was clamped
[07/26/2022-04:31:07] [I] [TRT] No importer registered for op: NonZero. Attempting to import as plugin.
[07/26/2022-04:31:07] [I] [TRT] Searching for plugin: NonZero, plugin_version: 1, plugin_namespace:
[07/26/2022-04:31:07] [E] [TRT] ModelImporter.cpp:773: While parsing node number 3818 [NonZero -> "onnx::Transpose_6418"]:
[07/26/2022-04:31:07] [E] [TRT] ModelImporter.cpp:774: --- Begin node ---
[07/26/2022-04:31:07] [E] [TRT] ModelImporter.cpp:775: input: "onnx::NonZero_6417"
output: "onnx::Transpose_6418"
name: "NonZero_4444"
op_type: "NonZero"

[07/26/2022-04:31:07] [E] [TRT] ModelImporter.cpp:776: --- End node ---
[07/26/2022-04:31:07] [E] [TRT] ModelImporter.cpp:779: ERROR: builtin_op_importers.cpp:4890 In function importFallbackPluginImporter:
[8] Assertion failed: creator && "Plugin not found, are the plugin name, version, and namespace correct?"
[07/26/2022-04:31:07] [E] Failed to parse onnx file
[07/26/2022-04:31:07] [I] Finish parsing network model
[07/26/2022-04:31:07] [E] Parsing model failed
[07/26/2022-04:31:07] [E] Failed to create engine from model or file.
[07/26/2022-04:31:07] [E] Engine set up failed
&&&& FAILED TensorRT.trtexec [TensorRT v8401] # ./trtexec --onnx=/content/drive/MyDrive/model.onnx --minShapes=input:1x128 --optShapes=input:1x128 --maxShapes=input:1x128 --shapes=input:1x128 --best --workspace=10000 --saveEngine=test.plan

It seems that by using the BartForSequenceClassification module to load my model, the NonZero operation, which is not supported by TensorRT, appears somewhere in my model graph.
Do you have any workaround to this so I can use the BartForClassificationModel to load the facebook/bart-large-mnli model ?
Thanks in advance for taking the time to answer !


Improve bulk sending to many contacts

Currently the bulk send loads all contacts into memory even when not deduping them. When not deduping, we should add them to the window manager while loading them rather than storing them in memory.
We also have some more advanced plans for a separate PR:

Perform a paginated contact query and store the continuation key in Redis so that the send can be resumed even if a worker falls over.

Use a Radix tree to determine uniqueness when deduping (this will drastically reduce the storage requirements), using, e.g. https://pypi.python.org/pypi/py-radix. [Edit: py-radix is IP address specific, but maybe we can find something else when we get there].

:+1:

It turns out the the contact look-up does one giant index query, so we're not landing this for now. Keeping it open for a bit in case we decide we want it anyway.

Closing this for now -- we can always resurrect the code if needed.


Security scan

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: cesec321 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Elyra documentation contains a non-functional search page

Describe the issue
A clear and concise description of what the issue is.
see below
To Reproduce
Steps to reproduce the behavior:

Open https://elyra.readthedocs.io/en/latest/search.html
There's nothing a user can do on this page
The "edit on github" link yields a 404

@karlaspuldaro I can look into this

@ptitzler What are you looking for? The ability to search? Have you seen the search field on the top left?

I am looking for a way to remove that page.


updated setup.py pyrodigal version

set a minimum version of pyrodigal as version 2 does not contain GeneFinder

Reviewed in person


hybridreverb2: 2.1.1 -> 2.1.2

Motivation for this change
Src was broken upstream.
See  https://github.com/NixOS/nixpkgs/issues/104048
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 104765 run on x86_64-linux 1

1 package built:

hybridreverb2


What is "workflow_version" in classifications export?

In the classifications export, I see a workflow_version number like 11803.11802. However, in the project builder, my workflow versions show up as 1.1. How do I reconcile these?

We just need to update the way they're displayed in the classifications export.

So this was bug that was fixed recently here https://github.com/zooniverse/Panoptes/pull/918. The workflow version is stored in the classification as is from the client (it round trips from the server when retrieving subjects to understand the state the workflow was in).
Anyway I don't think we'll fix this since in the classification dump as it'll be fixed long term in the production system. @mkosmala the workflow version should only have bumped if you changed the workflow tasks / content. We can provide some data to get a mapping between your id's and the correct worfklow versions. I assume your workflow 1.1 is from the demo site?

@camallen Yes, that's right. And we don't have different versions, so it's not a problem for what we're doing right now. I just had a collaborator ask me what the numbers in the workflow_version column meant and realized I couldn't answer the question.

Right - it's a representation of the tasks in a workflow and the associated content, e.g. tasks_version.copy_version so we can track which classifications link to the state of a workflow and the set of tasks / copy.  http://docs.panoptes.apiary.io/#reference/workflows/workflow-version
The major number changes and classification most likely can't be linked together. Minor number changes most likley can unless the text drastically changes user behaviour / expectations.

Closing as i don't think this needs to be fixed.


[BUG] link is broken in SETUP.md

Description
In ComputerVision/blob/master/SETUP.md
The link in "6. At this point, you should be able to run the notebooks in this repo." is broken.
In which platform does it happen?
How do we replicate the issue?
Expected behavior (i.e. solution)
Other Comments

Thanks. This is fixed now


Using train groups closes SE station list GUI

Interacting with the Train Group button closes SE's station list GUI. This also causes the train GUI to be misaligned.
Can this be fixed here or should I post something in SE forums?

This is a space exploration bug.


CLI: API wizard

Signed-off-by: jasmingacic<EMAIL_ADDRESS>It partially fixes issue described here -> https://github.com/kubeshop/kusk-gateway/issues/328#issuecomment-1203975436
This PR allows user to pick an envoyfleet when using kusk api generate.
# kusk api generate   -i ../../examples/todomvc/spec/todospec.yaml
1. default/default
2. default/test
Please pick a fleet from the list above: 1

---
apiVersion: gateway.kusk.io/v1alpha1
kind: API
metadata:
  name: Todo-Backend API
  namespace: default
spec:
  fleet:
    name: default
    namespace: default
  spec: |
    components:
<redacted>

Also added in this PR is option --apply, -a which allows users to apply the newly generated manifest directly from the CLI
# kusk api generate   -i ../../examples/todomvc/spec/todospec.yaml  -a --name totobackend
Envoyfleets:
1. default/default
2. default/test
Please pick a fleet from the list above: 1
Do you want to proceed apply provide API to your cluster:
api.gateway.kusk.io/totobackend created

Another option added in this PR is option --output or -o which allows users to specify the path where the newly generated manifest will be saved
$ kusk api generate   -i ../../examples/todomvc/spec/todospec.yaml  -o test.yamlEnvoyfleets:
1. default/default
2. default/test
Please pick a fleet from the list above: 1
Successfully saved the API to "test.yaml"

The main reason for adding output option is that funneling output of the CLI command into a file like kusk api generate ... > file.yaml is no longer possible because of the newly added prompts.
This is far from perfect solution so please chime in
Checklist

[x] tested locally
[x] added new dependencies
[x] updated the docs
[ ] added a test

This breaks the initial implementation. I would include a flag or something to use the prompt

Yeah @kylehodgetts something like --interactive

As we decided this is rather pointless.
I'm killing it


Improve hottest method in analysis

In https://upload.clinicjs.org/public/a3637f063864c1f66ee9c393a06129b2683e13acc0492d42cc0213096abf1a73/7528.clinic-flame.html, the hottest method is insertBarrierNode. This is extremely hot because this.nodes.sort() is being called for every insertion.
I would recommend to use a different data structure for this.nodes, I would recommend a Red-Black Tree or a Binary Tree. I got a lot of success in the past with https://github.com/mikolalysenko/functional-red-black-tree, but it's a bit old.

Nice finding! I have some stuff for this somewhere also.

Please share! That module is a classic but a bit old.
Il giorno ven 10 ago 2018 alle 21:51 Mathias Buus<EMAIL_ADDRESS>ha scritto:

Nice finding! I have some stuff for this somewhere also.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nearform/node-clinic-bubbleprof/issues/242#issuecomment-412187693,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADL44U9aeGJgpsmPTfGptboWbQLnpwLks5uPeQpgaJpZM4V342c
.

It's a BTree impl that worked quite well. I'll dig it up.

Actually let me just note that I'm pretty sure aggregateId is a simple incrementing number. Simply allocating a big static array and inserting at aggregateId index might be very fast. I'll investigate.

@mafintosh even if aggregateId is a incremental number it is very likely still better to use a BTree. Arrays do not scale that well and in case an entry has to be inserted in the middle, all following entries will be moved and that is costy. If it's always attached at the end of the array, it should be fast and the sorting could just be removed (it is likely the main issue in that function). However, depending on the size of the array it would still become slow. Huge arrays are not the best data structure in JS.

@BridgeAR the keyword was big static array :) ie new Array(largeNum) and arr[aggregateId] = ... with some tricks

Do we have the original dataset used here? /cc @AlanSl I see your name in the stack

This is fixed by #247 even tough there is probably even more potential left to improve.


Allow STORYBOOK as env var

Description
I am getting this error here:
error during build:
[vike:envVars] [vike][Wrong Usage] import.meta.env.STORYBOOK is used in client-side file /src/sentry/translation/utils.ts which means that the environment variable STORYBOOK will be included in client-side bundles and, therefore, STORYBOOK will be publicly exposed which can be a security leak. Use import.meta.env.STORYBOOK only in server-side files, or rename STORYBOOK to PUBLIC_ENV__STORYBOOK, see https://vike.dev/env
file: /Users/workdigital/work/hybrid-app/frontend2.0/src/sentry/translation/utils.ts
    at /Users/workdigital/work/hybrid-app/frontend2.0/node_modules/vike/dist/cjs/node/plugin/plugins/envVars.js:50:56
    at Array.forEach (<anonymous>)
    at Object.transform (/Users/workdigital/work/hybrid-app/frontend2.0/node_modules/vike/dist/cjs/node/plugin/plugins/envVars.js:36:18)
    at file:///Users/workdigital/work/hybrid-app/frontend2.0/node_modules/rollup/dist/es/shared/node-entry.js:19774:40

I know of the common prefix, however STORYBOOK is injected by the lib itself and I rather not make my own set up to detect if I run in storybook.

How about this:

We whitelist STORYBOOK
We create a new config env.public.

WDYT?

@brillout - so basically all envs in .env.public are available everywhere? And STorybook gets a whitelabled everywhere as well?
I mean this would solve this. For me it would be enough to whitelist STORYBOOK

I meant that STORYBOOK is always available on the client-side. (I.e. treating STORYBOOK as if it were prefixed with PUBLIC_ENV__.)

all envs in .env.public are available everywhere?

Is that a common practice? I ain't familiar with it. I'm slightly reluctant to have a .env.public as it makes it a little easier to mistakenly leak secrets.

@brillout I have seen people do this yes. But I have no fixed way of doing this. I mostly adjust to what the framework wants me to do. I just wasn't sure what you meant by adding a new config env.public

We create a new config env.public.

Ah, I see. I meant a new Vike setting:
// vike.config.js

export default {
  env: { public: ['STORYBOOK'] }
}

(The vike.config.js file is work-in-progress.)
As for .env.public, I'll think about it. In the meantime I'll whitelist STORYBOOK. ETA today.

Okay thank you!

Pre-released as 0.4.177-commit-51d612a.
As for the rest, closing in favor of https://github.com/vikejs/vike/issues/1726.


Stale docs for EndpointSliceTerminatingCondition

This is a Bug Report

Problem:
Because PR #37913 didn't merge for v1.26, the relevant documentation is now stale.
Proposed Solution:
Make a new PR, similar to #37913, but targeting main. And get it reviewed so we merge it in.
Additional Information:
/language en
/sig network

/assign

/triage accepted


drone-runner-docker: 1.8.0 -> 1.8.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/drone-runners/drone-runner-docker/releases.
meta.description for drone-runner-docker is: "Drone pipeline runner that executes builds inside Docker containers"
meta.homepage for drone-runner-docker is: "https://github.com/drone-runners/drone-runner-docker"
meta.changelog for drone-runner-docker is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.1 with grep in /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1
found 1.8.1 in filename of file in /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
drone-runner-docker

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A drone-runner-docker https://github.com/r-ryantm/nixpkgs/archive/fed2a91f4102c5d162b0c37e2621cb77092a2cd0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1
ls -la /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

drone-runner-docker

Maintainer pings
cc @endocrimes @kalbasit for testing.

https://github.com/drone-runners/drone-runner-docker/releases/tag/v1.8.1
1.8.2. is also already out.
Merging since it doesn't seem like this will get any attention soon and changes seem quite safe.


KeyError in collect demos

Thanks for your great work.
When I run examples/1_collect_demos.py exactly as the example usage, I encountered the following error. How can I resolve this?
python 1_collect_demos.py
--scene_path ../tests/acdc_output/step_3_output/scene_0/scene_0_info.json
--target_obj cabinet_4
--target_link link_1
--cousins bottom_cabinet,bamfsz,link_1 bottom_cabinet_no_top,vdedzt,link_0
--dataset_path test_demos.hdf5
--n_demos_per_model 3
--eval_cousin_id 0
--seed 0
Traceback (most recent call last):
File "/data/gaofei/simulator/OmniGibson/tools/code/digital-cousins/examples/1_collect_demos.py", line 295, in
main(args)
File "/data/gaofei/simulator/OmniGibson/tools/code/digital-cousins/examples/1_collect_demos.py", line 207, in main
env = EnvOmniGibson(
File "/data/gaofei/simulator/OmniGibson/tools/code/digital-cousins/digital_cousins/envs/robomimic/env_og.py", line 361, in init
self.env = create_wrapper(env=self.env)
File "/data/gaofei/simulator/OmniGibson/OmniGibson/omnigibson/envs/env_wrapper.py", line 21, in create_wrapper
return create_class_from_registry_and_config(
File "/data/gaofei/simulator/OmniGibson/OmniGibson/omnigibson/utils/python_utils.py", line 286, in create_class_from_registry_and_config
return cls(**cls_kwargs)
File "/data/gaofei/simulator/OmniGibson/tools/code/digital-cousins/digital_cousins/envs/omnigibson/cabinet_open_wrapper.py", line 280, in init
link = cab.links[cab_link]
KeyError: 'link_1'
It seems that the cabinet_4 has no 'link_1'. The keys of its links are ['base_link', 'door1', 'glass1', 'door2', 'glass2'] as I print it.

To add to @RogerDAI1217 's point above, make sure you select the link that actually has the handle attached to it -- likely door1 or door2!

@RogerDAI1217 @cremebrule Thanks! I have solved this problem by switching scene_0 to scene_2 where the cabinet_4 has 'link_1'.


AzureSearch Vector Store: Moving the usage of additional_fields into context of it's definition (bug fix from python error)

Description: Using Azure Cognitive Search as a VectorStore.    Calling the add_texts method throws an error if there is no metadata property specified.   The additional_fields field is set in an if statement and then is used later outside the if statement.  This PR just moves the declaration of additional_fields below and puts the usage of it in context.
Issue: https://github.com/langchain-ai/langchain/issues/8544
Tagging @rlancemartin, @eyurtsev as this is related to Vector stores.
make format, make lint, make spellcheck, and make test have been run

thanks @kevinbuckley!


Add documentation how side is determined of parallel_offset

Expected documentation and actual documentation.
Expected documentation:
object.parallel_offset(distance, side, resolution=16, join_style=1, mitre_limit=5.0)
Returns a LineString or MultiLineString geometry at a distance from the object on its right or its left side.
Distance must be a positive float value. The side parameter may be ‘left’ or ‘right’. Left and right is determined by following the direction of given geometric points of the LineString. The resolution of the offset around each vertex of the object is parameterized as in the buffer method.
The join style is for outside corners between line segments. Accepted integer values are 1 (round), 2 (mitre), and 3 (bevel). See also shapely.geometry.JOIN_STYLE.
Severely mitered corners can be controlled by the mitre_limit parameter (spelled in British English, en-gb). The ratio of the distance from the corner to the end of the mitred offset corner is the miter ratio. Corners with a ratio which exceed the limit will be beveled.
Actual documentation: (link)
object.parallel_offset(distance, side, resolution=16, join_style=1, mitre_limit=5.0)
Returns a LineString or MultiLineString geometry at a distance from the object on its right or its left side.
Distance must be a positive float value. The side parameter may be ‘left’ or ‘right’. The resolution of the offset around each vertex of the object is parameterized as in the buffer method.
The join style is for outside corners between line segments. Accepted integer values are 1 (round), 2 (mitre), and 3 (bevel). See also shapely.geometry.JOIN_STYLE.
Severely mitered corners can be controlled by the mitre_limit parameter (spelled in British English, en-gb). The ratio of the distance from the corner to the end of the mitred offset corner is the miter ratio. Corners with a ratio which exceed the limit will be beveled.
Steps to reproduce the problem.
from shapely.geometry import LineString
import matplotlib.pyplot as plt
def plot_line(ax, ob, color, zorder=1, linewidth=3, alpha=1):
x, y = ob.xy
ax.plot(x, y, color=color, linewidth=linewidth, solid_capstyle='round', zorder=zorder, alpha=alpha)
fig = plt.figure()
ax = fig.add_subplot(121)
base = LineString([(1, 1.2), (1, 1), (0, 1.5), (0, 1.2)])
left_offset = base.parallel_offset(0.1, 'left', join_style=2, mitre_limit=5.0)
right_offset = base.parallel_offset(0.1, 'right', join_style=2, mitre_limit=5.0)
plot_line(ax, base, alpha=0.7, color='green')
plot_line(ax, left_offset, alpha=0.7, color='red')
plot_line(ax, right_offset, alpha=0.7, color='blue')
plt.show()

@Davidswinkels Could you submit this as a merge request?

Done :)


Timestamp is needed in messages field of getThread(id)

please check #d196341 -- should be running.

It works!


Adding HMAC driver

This is the project version for the HMAC driver. It's been tested only on ESP32C3 using a zero key on efuse.
I'd like to hear your feedback on this PR.

Thanks for making those changes, looking better already :). I tried running some of the examples, but sadly they seem to panic with "KeyPurposeMismatch", could you look into that?

Have you set the key in the efuse block ? You need to set the key purpose as well in the efuse block and modify the example with the corresponding key for the SW.

I've tested on my local repo on github to make sure that all workflows works with the last commit : all passed.

Thanks for getting the CI green!

Have you set the key in the efuse block ? You need to set the key purpose as well in the efuse block and modify the example with the corresponding key for the SW.

Oops, working now! Sorry for the noise :D.
This is looking good! Could you rebase the changes to resolve the conflicts?

I can reproduce this with rustc 1.70.0-nightly (4087deacc 2023-04-12) while that didn't happen with e.g. rustc 1.70.0-nightly (39f2657d1 2023-03-09)

I believe the issue is coming from rustc and the embedded-hal-async library. What are the next steps to move forward?

Problem with CI is that the latest nightlies refuse to compile embedded-hal-async - I will create a PR to pin the nightly compiler version in CI for now (until embedded-hal-async got fixed) which should make CI happy again

Rebasing should fix the CI problem (hopefully)

The rebase has fixed the CI in my repo.

All the warnings regarding HMAC and SHA have been cleaned.

When this PR will be merged, I will be adding another PR regarding ECC accelerator.

Looks pretty good to me but since there were also some comments by others let's wait for their review

I've added ECC peripheral support as well and change the name of the PR.
@jessebraham BTW, when I was testing with the esp32c2 board, I had to force the baudrate for monitoring to 74880 because my board has a crystal of 26 MHz. I'm using the version 2.0.0-rc.3 of espflash which has the improvements relating to crystal frequency and serial monitor for the ESP32-C2. Is it a normal behavior to force the baudrate or should I open an issue in espflash ?

I think to get things merged it would be better to split the PR by peripherals. That would make reviewing much easier and it's better to have one merge per peripheral.

Thanks @bjoernQ for bumping this, apologies to @nabilmerk that we've left this to languish for so long.
As already stated, this PR got quite large and deals with multiple peripherals, making it rather difficult to review and test. Breaking this up would make things much easier on our end.
The way I see it this could probably be 3 separate PRs:

Refactoring the SHA driver and alignment helper
Adding the HMAC driver
Adding the ECC driver

Hi. What is the state of this PR? I started working on adding the HMAC driver, before seeing that this PR was opened. Are there any changes needed before merging?
I'm looking forward to HMAC hardware acceleration to be implemented, to implement the digital signature (DS) driver.

@AnthonyGrondin If you want to do a full review of this PR and test each example for each chip you're welcome to, then we could possibly move forward. I don't have the time or energy to do that, because it will take hours probably, which is why we asked for this to be split up.

@AnthonyGrondin did you have any intention of tackling the ECC peripheral as well? No worries if not, just curious. Somebody else (or me) can pick it up if you do not plan on doing so. Just would like to get this closed 😁

Hi,
No, I didn't have any intentions of implementing the ECC peripheral.

I think:

ECC
Digital Signature (DS)
XTS_AES

are the only cryptographic accelerators left that haven't been implemented yet. I mostly did HMAC so that I could implement DS but I found that I might not need it for what I intended to do, so I haven't worked on DS much, except from a mere WIP... If someone wants to do it :grin:


docs: Minor change to fees in yellow paper

This PR contains minor changes to the fees yellow paper
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

Benchmark results
Metrics with a significant change:

note_history_trial_decrypting_time_in_ms (5): 163 (-44%)
note_trial_decrypting_time_in_ms (32): 32.5 (-56%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 187d2f79 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,888
868,100
3,448,088

l1_rollup_execution_gas
841,975
3,595,208
22,203,457

l2_block_processing_time_in_ms
2,073 (-1%)
8,006 (-3%)
33,138 (-1%)

note_successful_decrypting_time_in_ms
310 (-2%)
907 (-4%)
3,333 (-2%)

note_trial_decrypting_time_in_ms
20.4 (-27%)
:warning: 32.5 (-56%)
199

l2_block_building_time_in_ms
20,384
80,818 (-1%)
324,467 (-1%)

l2_block_rollup_simulation_time_in_ms
16,838
66,873 (-1%)
268,499 (-1%)

l2_block_public_tx_process_time_in_ms
3,498 (-1%)
13,797 (-1%)
55,416 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
23,121 (+2%)
45,229 (+1%)

note_history_successful_decrypting_time_in_ms
2,185 (+2%)
4,220 (+2%)

note_history_trial_decrypting_time_in_ms
:warning: 163 (-44%)
231 (+3%)

node_database_size_in_bytes
3,306,344
3,651,758

pxe_database_size_in_bytes
29,748
59,307

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
199
43,077
20,441

private-kernel-ordering
115
25,833
9,689

base-rollup
2,959
664,108
873

root-rollup
89.2 (+5%)
4,072
1,097

private-kernel-inner
259
64,484
20,441

public-kernel-private-input
171
25,203
20,441

public-kernel-non-first-iteration
168
25,245
20,441

merge-rollup
11.1 (+2%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
10,323
25,938


How to define username & password for postgresql connection

Hello, my postgresql uses a username and a password for authentication. How can I set those when defining connection object? { host: 'localhost', port: 5432 }
Is something like this possible ? { host: 'localhost', port: 5432, username: xxxx , password xxxxxxxx }
Thankyou

Please see the example here:
const redis = require('redis');
const redisAdapter = require('socket.io-redis');
const pubClient = redis.createClient(port, host, { auth_pass: "pwd" });
const subClient = pubClient.duplicate();
io.adapter(redisAdapter({ pubClient, subClient }));


Version 11 just crashes on Windows

Description of bug:
Wallets starts briefly, then freezes, database size stays the same

Steps to reproduce the issue:

Nano Milestone 11 on Windows on a fresh start (deleted database files)
Main window hangs and werfault.exe process starts using 100% of CPU (on one core)

Describe the results you received:
Windows Error Reporting starts using 100% (on one core), and is unkillable.

the only way to stop this is forcefully restarting the computer (taskkill can't kill it)

Describe the results you expected:
It works like previous versions
Additional information you deem important (e.g. issue happens only occasionally):
Happened every time, from the 3 times I tried
Environment:

OS information: Windows 10 x64
Node version: Milestone 11

logs
[2018-03-23 17:37:44.065215]: Bootstrap stopped because there are no peers
[2018-03-23 17:37:44.065215]: Bootstrap stopped because there are no peers
[2018-03-23 17:37:44.065215]: Bootstrap stopped because there are no peers
[2018-03-23 17:37:44.065215]: Bootstrap stopped because there are no peers
[2018-03-23 17:37:44.065215]: Exiting bootstrap attempt
[2018-03-23 17:37:44.510075]: Beginning pending block search
[2018-03-23 17:37:44.510075]: Pending block search phase complete
[2018-03-23 17:37:45.515069]: UDP Receive error: No connection could be made because the target machine actively refused it
[2018-03-23 17:37:47.737077]: Beginning pending block search
[2018-03-23 17:37:47.737077]: Pending block search phase complete
[2018-03-23 17:37:49.068256]: Starting bootstrap attempt
[2018-03-23 17:37:49.238260]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.246260]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.246260]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.248260]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.274260]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.276261]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.304261]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.322262]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:49.402263]: Invalid size: expected 64, got 0
[2018-03-23 17:37:49.404263]: frontier_req failed, reattempting
[2018-03-23 17:37:59.094699]: Error initiating bootstrap connection to [::ffff:<IP_ADDRESS>]:10025: The I/O operation has been aborted because of either a thread exit or an application request
[2018-03-23 17:37:59.094699]: Error initiating bootstrap connection to [::ffff:<IP_ADDRESS>]:7075: The I/O operation has been aborted because of either a thread exit or an application request
[2018-03-23 17:37:59.094699]: Error initiating bootstrap connection to [::ffff:<IP_ADDRESS>]:7075: The I/O operation has been aborted because of either a thread exit or an application request
[2018-03-23 17:37:59.350706]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:59.352705]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:59.356701]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:37:59.484704]: Connection established to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:01.985391]: Found a representative at [2001:41d0:8:d85f::1]:7075
[2018-03-23 17:38:02.857584]: Found a representative at [2600:3c03::f03c:91ff:fee5:29e]:7075
[2018-03-23 17:38:04.403929]: Received 303959 frontiers from [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:09.642300]: Found a representative at [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:10.134317]: Found a representative at [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:10.548320]: Completed frontier request, 468710 out of sync accounts according to [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:10.931790]: Found a representative at [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:10.932791]: Found a representative at [::ffff:<IP_ADDRESS>]:7075
[2018-03-23 17:38:11.020796]: Requesting account xrb_33de47sgua1pup78kw4ye8nz7ujdz47oucfgco1zb95n8n7hkbq1x81z3md6 from [::ffff:<IP_ADDRESS>]:7075. 468709 accounts in queue
[2018-03-23 17:38:11.020796]: Error receiving block type End of file
[2018-03-23 17:38:11.021797]: Error receiving block type End of file

Had you run a previous build? Did you remove everything from the data dir or just the data.ldb and could you restart the computer, clear out the data dir and try again if you haven't already

yes, since version 8, but since starting milestone 11 crashed, I decided to wipe the databases and wallet files

Can you try this version instead and let me know what the results, You should uninstall the previous and reinstall with this one.
https://ci.appveyor.com/api/buildjobs/lvlgfxfjamx5cdlc/artifacts/Nano_Installer-11.0.GIT-a22ceb5-win64.exe

sorry for the delay on the response. I'm trying 11.1 right now and will report back. so far, it says it's synchronizing without the lockup, and using my previous seed without any issue

ok, it seems that it's stuck forever on Block 1, even from a fresh start. the block count keep growing, the database file is 1,7GB, but it's just "frozen" in time, although the GUI is responsive.
issue #635 still happens (closed it, and the process is in the background doing nothing, but using more and more memory each time it passes)

what did the unchecked count get to? chances are the blocks needing to be processed to continue with the bootstrapping had not been received yet and as a result would act as a blocker to checking in further blocks. The process still running after exit is still being investigated

it was around 3,8kk and the process is still stuck , and eventually will memory leak until my system crashes

Does the memory leak only start when you exit?

yes, while it was opened, the memory was stable, but the UI wasn't doing anything

also 3.8kk is only about half downloaded, that would explain why you werent getting past 1 if it hadnt downloaded the block yet. You may want to wait for all almost 7.3m blocks to download as it could be the very last block you download that is needed to continue checking in blocks

well, that's really counter productive. anyway, the process is memory leaking and nearing 2GB, I'll have to kill it

It sounds like you’re running it on a machine with slow disk IO. Ignore it can't write to disk fast enough it keeps it in memory.
Improving disk IO is slowly coming to the top of the list of things to work on, there have been other higher priority issues.

I'm on a Samsung EVO 850 👍

Odd, then I haven’t seen a memory spike like that, we’ll have to see what it takes to reproduce.

how much memory does it show as using while its running and stable?

@argakiig this is the usual memory usage

that's why it's a clear indication of a serious memory leak

It’s be interesting to know what it stabilizes to. When I run it on OSX it’s pretty stable around 70-120. I’ve seen it spike on systems that have bad disk IO as it puts blocks in memory until written to disk but with that SSD that’s clearly not the case.

yeah, the I/O isn't high, that's why it's strange, maybe it's an Windows issue, I decided to monitor the disk activity and it seems fine, no crazy reads or writes, it tops around 10MB/s, averaging 2MB/s, so it's clearly not an I/O issue. average response time is 3ms. it's fairly constant as expected, the only issue is when you close the wallet

don't know what else to look for. I'm in a older system besides the SSD though (Core 2 Quad Q9550 and 8 GB of DDR2 800) but have no issues with, for example, Bitcoin Core or other more intensive / aggressive / non-optimized coins, like Ethereum

This should be resolved by the memory leak fixes supplied in V17.0 !  See #1338 for additional details.


[BUG] The "Save" button is inactive on the Edit Profile screen after deleting the phone number

Description:

The user is logged in

Steps to reproduce:

Launch the App
Go to the Edit Profile screen
Delete the phone number
Click on the "Save" button

Expected result:  The "Save" button should be active after deleting the phone number
Actual result: The "Save" button is inactive on the Edit Profile screen after deleting the phone number
Environment:  Android App [Production] 1.26.5 (1443)
Devices list: Xiaomi Mi 8 / Android 9
Note: The "Save" button is displayed active only after changing country on the phone field
Attachment:
https://www.dropbox.com/s/1hq2h7v2c23vkbu/The Save button is inactive on the Edit Profile screen after deleting the phone number .mp4?dl=0

@Zhigamovsky The issue is not reproduced. The "Save" button is active after deleting the phone number.
Checked on the Android App [staging] 1.25.1-7
Device: Xiaomi Mi 8 / Android 9
Attachment: https://www.dropbox.com/s/fdky45of76qern9/How to invite section check on the NAtive.mp4?dl=0

@iLystopad did you manage to save the profile after removing the mobile number?

@omerzam Yes it was saved after removing and clicking on the "Save" button
Sorry, I've uploaded the wrong video of the checking, here is the correct one.
Attachment:
https://www.dropbox.com/s/mfd62r3khdf7lm6/Checking the Save button on the React Native.mp4?dl=0

The issue is not reproduced. The "Save" button is active after deleting the phone number. The Empty phone number field is saved after taping on the "Save" button
Checked on the Android App [PROD] 1.27.1
Device: Xiaomi Mi 8 / Android 9
Attachment: https://www.dropbox.com/s/kng6i7sppot9kl3/Check Save button on the PROD.mp4?dl=0


Fixed exception happening when quitting on MainThreadDispatcher

We have noticed exceptions happening when the app is being shut down. MainThreadDispatcher calls FindObjectOfType from a background thread because the existing instance has already been destroyed by Unity. This is handled somewhat gracefully in the Editor:

However, on iOS (and most likely all platforms that use IL2CPP) this actually results in a crash:
Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Subtype: KERN_INVALID_ADDRESS at 0x00000000000001f8

Triggered by Thread:  14

Thread 0 name:
Thread 0:
[...]
8   yousician                     	0x00000001051c79c4 PlayerCleanup(bool) + 80 (Player.cpp:613)
9   yousician                     	0x0000000104ff5568 UnityCleanup + 84 (LibEntryPoint.mm:215)
10  yousician                     	0x000000010275389c -[UnityAppController applicationWillTerminate:] + 24 (UnityAppController.mm:393)
[...]

Thread 14 name:
Thread 14 Crashed:
0   yousician                     	0x0000000104d90e7c core::hash_set<core::pair<core::basic_string<char, core::StringStorageDefault<char> > const, int, true>, core::hash_pair<core::hash<core::basic_string<char, core::StringStorageDefault<char> > >, core::basic_string<char, core::StringStorageDefault<char> > const, int>, core::equal_pair<std::__1::equal_to<core::basic_string<char, core::StringStorageDefault<char> > >, core::basic_string<char, core::StringStorageDefault<char> > const, int> >::node* core::hash_set<core::pair<core::basic_string<char, core::StringStorageDefault<char> > const, int, true>, core::hash_pair<core::hash<core::basic_string<char, core::StringStorageDefault<char> > >, core::basic_string<char, core::StringStorageDefault<char> > const, int>, core::equal_pair<std::__1::equal_to<core::basic_string<char, core::StringStorageDefault<char> > >, core::basic_string<char, core::StringStorageDefault<char> > const, int> >::lookup<core::basic_string<char, core::StringStorageDefault<char> > >(core::basic_string<char, core::StringStorageDefault<char> > const&) const + 68 (hash_set.h:566)
1   yousician                     	0x0000000104d8e260 MonoManager::GetScriptingClass(char const*, char const*, char const*) + 104 (hash_map.h:175)
2   yousician                     	0x00000001049de99c InitializeCoreScriptingClasses() + 104 (CoreScriptingClasses.cpp:25)
3   yousician                     	0x00000001049de910 GetCoreScriptingClassesPtr() + 28 (CoreScriptingClasses.cpp:1439)
4   yousician                     	0x00000001049de80c GetCoreScriptingClasses() + 12 (CoreScriptingClasses.cpp:1448)
5   yousician                     	0x0000000104d8f5c8 Scripting::GetTypeFromScriptingClass(ScriptingClassPtr) + 64 (Scripting.cpp:649)
6   yousician                     	0x0000000104d8f7ac Scripting::FindObjectsOfType(ScriptingSystemTypeObjectPtr, Scripting::FindMode) + 72 (Scripting.cpp:830)
7   yousician                     	0x00000001040817a8 Object_FindObjectOfType_m67275058 + 92 (Bulk_UnityEngine.CoreModule_1.cpp:15603)
8   yousician                     	0x0000000104683488 Object_FindObjectOfType_TisRuntimeObject_m2027585794_gshared + 164 (GenericMethods18.cpp:61551)
9   yousician                     	0x0000000104026e54 MainThreadDispatcher_Initialize_m2166422574 + 152 (Bulk_UniRx_0.cpp:31695)
10  yousician                     	0x0000000104026308 MainThreadDispatcher_get_Instance_m1146637714 + 84 (Bulk_UniRx_0.cpp:31657)
11  yousician                     	0x0000000104026264 MainThreadDispatcher_Post_m2136125861 + 96 (Bulk_UniRx_0.cpp:31126)
12  yousician                     	0x00000001036cd2c0 VEMNcNB_OnNext_m1885355514_gshared + 128 (Bulk_Generics_87.cpp:31104)
13  yousician                     	0x00000001036cd050 VEMNcNB_Run_m3781630758_gshared + 220 (Bulk_Generics_87.cpp:41)
14  yousician                     	0x0000000104373ffc QueueUserWorkItemCallback_WaitCallback_Context_m2238596144 + 120 (Bulk_mscorlib_16.cpp:25710)
15  yousician                     	0x000000010437088c ExecutionContext_RunInternal_m3256186641 + 348 (Bulk_mscorlib_16.cpp:21576)
16  yousician                     	0x000000010436c198 ThreadPoolWorkQueue_Dispatch_m3092487892 + 572 (Bulk_mscorlib_16.cpp:45400)
17  yousician                     	0x00000001048c0ef4 RuntimeInvoker_Boolean_t97287965(void (*)(), MethodInfo const*, void*, void**) + 32 (Il2CppInvokerTable.cpp:113833)
18  yousician                     	0x00000001053a1210 worker_thread(void*) + 492 (ThreadPoolWorkerThread.cpp:252)
19  yousician                     	0x00000001053d71b0 il2cpp::vm::ThreadStart(void*) + 96 (Thread.cpp:666)
20  yousician                     	0x00000001053a2b34 il2cpp::os::Thread::RunWrapper(void*) + 88 (Thread.cpp:168)
21  yousician                     	0x00000001053ab69c il2cpp::os::ThreadImpl::ThreadStartWrapper(void*) + 36 (ThreadImpl.cpp:104)
22  libsystem_pthread.dylib       	0x0000000184b99220 _pthread_body + 272 (pthread.c:740)
23  libsystem_pthread.dylib       	0x0000000184b99110 _pthread_start + 292 (pthread.c:799)
24  libsystem_pthread.dylib       	0x0000000184b97b10 thread_start + 4

We managed to fix this by performing the isQuitting before attempting to call FindObjectOfType. It made the errors disappear in the Editor too.

I also have this issue.

@neuecc Any chance of getting this merged?

Also I faced same issue. I think that control flow is not changed in this function (messages will be dropped in the same situation), thus this PR makes sense to reduce raising unexpected exceptions.


Implement std::error::Error for Errors

This is handy because it for example makes the Errors type usable with anyhow/thiserror.
Implementing std::error::Error for error types is best practice.
Sidenote: I think it's weird that the enum is named in plural.

Yes, I also got annoyed by this earlier 👍


Support for LiFePO4 48 V

Hello, @Louisvdw, I'm a student at PTI, we have several renewable energy projects, one of them is the communication between the LiFePO4 48 V battery and the Venus OS.
Here's the battery communication protocol
Protocolo de comunicação LFP - MODBUS_ rev.06.pdf.
I'll work on it over the next few weeks, and if it goes well, I'll share the code.
Thanks for your great work.

Is the battery mentioned in the documentation a MasterBattery Upower UE-48Li100-3U? Any Progress so far?

This is not the battery (the pdf has the specifications), so far I'm able to read the voltage, current, SOC, alarms, number of cells and individual cell voltage data.

Okay I was Just thinking it is the same one, since 3U was mentioned in the PDF and Upower ist from Spain. What kind of BMS is this?

Ok, eu estava pensando que é o mesmo, já que o 3U foi mencionado no PDF e o Upower é da Espanha. Que tipo de BMS é esse?

The information I have about the BMS is:

+1 I have a stack do lifepower4 24v EG4 batteries I’d love to support with CerboGX.

May I ask? What Type of BMS is integrated in the batteries UE-48Li100-3U? Is there a possibility to make a firmware update? Software?  Thanks a Lot!


QR-Code Sprite Collection

Only a small gimmick, but theoretically a seed can also be converted into a QR code.

Done


[WIP] Update ORT versions + dependencies

Blocked by https://github.com/microsoft/onnxruntime/issues/22704

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Moved to https://github.com/huggingface/transformers.js/pull/1075


How to add AWS ECR oci repo

Output of helm version: version.BuildInfo{Version:"v3.10.0", GitCommit:"ce66412a723e4d89555dc67217607c6579ffcb21", GitTreeState:"clean", GoVersion:"go1.18.6"}
Output of kubectl version:
Cloud Provider/Platform (AKS, GKE, Minikube etc.):  AWS
============
AWS ECR gives you a way to push helm charts and use it as repo for charts via OCI support.
I am able to push helm charts on ECR, as explained here on their docs: https://docs.aws.amazon.com/AmazonECR/latest/userguide/push-oci-artifact.html.
But unfortunately I am unable to add the ECR as helm repo registry.
I tried different things and I think that this commands, is the closest I got:
> export HELM_EXPERIMENTAL_OCI=1

> aws ecr get-login-password --region eu-west-1 | helm repo add adtech oci://[[AWS_ACCOUNT]].dkr.ecr.eu-west-1.amazonaws.com --username AWS --password-stdin --debug

Error: looks like "oci://[[AWS_ACCOUNT]].dkr.ecr.eu-west-1.amazonaws.com" is not a valid chart repository or cannot be reached: object required
helm.go:84: [debug] object required
looks like "oci://[[AWS_ACCOUNT]].dkr.ecr.eu-west-1.amazonaws.com" is not a valid chart repository or cannot be reached
main.(*repoAddOptions).run
	helm.sh/helm/v3/cmd/helm/repo_add.go:211
main.newRepoAddCmd.func1
	helm.sh/helm/v3/cmd/helm/repo_add.go:82
github.com/spf13/cobra.(*Command).execute
	github.com/spf13/cobra@v1.5.0/command.go:872
github.com/spf13/cobra.(*Command).ExecuteC
	github.com/spf13/cobra@v1.5.0/command.go:990
github.com/spf13/cobra.(*Command).Execute
	github.com/spf13/cobra@v1.5.0/command.go:918
main.main
	helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
	runtime/proc.go:250
runtime.goexit
	runtime/asm_amd64.s:1571

Is this a known bug or is there a way to fix this?
I don't think this is a reachability problem since I am able to perform the push of a chart.

I see that also the issue #10892 has a similar problem, and the root cause may be AWS not providing an index.yaml endpoint as stated in this comment https://github.com/helm/helm/issues/10892#issuecomment-1279544202, and somehow confirmed by this open issue on aws roadmap https://github.com/aws/containers-roadmap/issues/1603.

I am still wondering if there is a workaround 🤔

I know you can helm install asdf https://charts.redpanda.com/redpanda-2.2.1.tgz, can you do the same using oci://...?

The helm install --help says the following:
There are six different ways you can express the chart you want to install:

1. By chart reference: helm install mymaria example/mariadb
2. By path to a packaged chart: helm install mynginx ./nginx-1.2.3.tgz
3. By path to an unpacked chart directory: helm install mynginx ./nginx
4. By absolute URL: helm install mynginx https://example.com/charts/nginx-1.2.3.tgz
5. By chart reference and repo url: helm install --repo https://example.com/charts/ mynginx nginx
6. By OCI registries: helm install mynginx --version 1.2.3 oci://example.com/charts/nginx

So I think the answer is yes. But I perform the installation using helmfile, never tried with helm directly.

I checked. The answer is yes. It looks like the issue you're having a problem with is helmfile support. I'm going to go ahead and close this issue.

helm: 3.12.0
for anyone who's searching how to just pull a chart from AWS ECR repo, from here:
AWS_PROFILE=ss aws ecr get-login-password --region eu-central-1 | helm registry login 123.dkr.ecr.eu-central-1.amazonaws.com --username AWS --password-stdin

helm pull oci://123.dkr.ecr.eu-central-1.amazonaws.com/my-helm-chart

Expect *.tgz file locally


Inspections

(This should be re-evaluated after https://github.com/groundlight/python-sdk/pull/79 is merged in. There may be conflicts, and there is at least one thing that needs to be updated in light of Blaise's PR)
This PR adds several methods to Groundlight that are required for the RPC Server/URCap. They are intended to be released as undocumented features and only used to support the RPC Server/URCap on the SDK (for now at least).
Since the required functionality for these methods is not available in image_queries_api, they use the internal API directly.
New methods include:
start_inspection
update_inspection_metadata
stop_inspection
update_detector_confidence_threshold
There was also some logic added to submit_image_query related to inspections: if an image query is submitted with no inspection_id, the query will be submitted through image_queries_api (as it has been previously), however if submit_image_query is called with an inspection_id, we use the private API client instead.

Sorry I clicked the button early!
My main request is to add some tests that use the new methods -- they should send (a) well-formed input and verify the response is as expected and (b) invalid input and make sure it raises the error as expected.


[BUG] startup on Windows fails because it cannot ssh to the crc VM

General information

OS: Windows
Hypervisor:  Hyper-V
Did you run crc setup before starting it (Yes/No)? Yes

CRC version
PS C:\Users\MarkBuck\bin> .\crc.exe version
crc version: 1.9.0+a68b5e0
OpenShift version: 4.3.10 (embedded in binary)

CRC status
PS C:\Users\MarkBuck\bin> .\crc.exe status
ERRO error: CreateFile C:\Users\MarkBuck\.crc\machines\crc\kubeconfig: The system cannot find the file specified.
 - exit status 1

CRC config
PS C:\Users\MarkBuck\bin> .\crc.exe config view
- http-proxy                            : http://webmon.ao.dcn:80
- https-proxy                           : http://webmon.ao.dcn:80
- no-proxy                              : .internal,localhost,.testing```

## Host Operating System
```bash
PS C:\Users\MarkBuck\bin> systeminfo /fo csv | ConvertFrom-Csv | select OS*, System*, Hotfix* | Format-List

OS Name             : Microsoft Windows 10 Enterprise
OS Version          : 10.0.17134 N/A Build 17134
OS Manufacturer     : Microsoft Corporation
OS Configuration    : Member Workstation
OS Build Type       : Multiprocessor Free
System Boot Time    : 5/3/2020, 11:36:57 AM
System Manufacturer : Dell Inc.
System Model        : OptiPlex 7050
System Type         : x64-based PC
System Directory    : C:\WINDOWS\system32
System Locale       : en-us;English (United States)
Hotfix(s)           : 8 Hotfix(s) Installed.,[01]: KB4230204,[02]: KB4346084,[03]: KB4521861,[04]: KB4523203,[05]: KB4524244,[06]: KB4537759,[07]: KB4540724,[08]: KB4550922

Steps to reproduce

crc config
crc setup
crc start

Expected
Successful startup of VM
Actual
Startup fails:
Cannot SSH to the crc vm (see logs)
ERRO IP not found
Logs
https://gist.github.com/markdbuck/4d539cf9f8b86165a3293d2e242a9588

I miss essential information about the network adapters available, so I can not assess this correctly. I guess you might be on a system that either needs to connect using a VPN. If so, please do not connect while starting and/or using CRC.

INFO Found Virtual Switch to use: Default Switch

Or perhaps, since this is Enterprise, you are using this with the "Default Switch"... but this seems to be intermittent for some reason on this platform. If this is the case, please create an 'External vSwitch' named 'crc'.

This is a corporate PC behind a firewall. I am working from home due to corona virus and remoting into the PC. So, I believe that your reference to Enterprise, meaning Windows is correct.
Can you provide a bit more guidance on what settings to use in creating an External vSwitch named crc?
I found another bugzilla in which you mention "You would have to create a Virtual Switch named 'crc', that is either external, bridged or even internal (not recommended). But you have to make sure you have a working DHCP server that hands out addresses and allowed to attach a DNS server."
I am not familiar with virtual switches and wanting to try and get it correct. Thanks!

Yep, that comment is correct and 'my words' but filed by Radomir I guess?
a vSwitch is a device that acts as a wrapper around an actual device to
provide networking to a VM. The settings "external", "internal" and
"bridged" are the different flavours. Using "external" is the simplest,
which takes an existing 'physical' device and connects the VM to this
network as if the plug was inserted in it's network card. Internal acts as
a means in which the host exposes a virtual networking device, but does not
allow traversal to the outside network unless explicitly configured and
handled. Note that ALL configs need to offer a DHCP server (internal does
not come with this, as it is expected the VM might work with a static
address... but we can't). The external network allows the 'external' DHCP
to realize this... however, when a VPN is involved, this is more
problematic. VPN's often impose an explicit constraint by forcing ALL
traffic to traverse over the remote network by the VPN tunnel. This is
called the route all (0/0). So I hope this explained it a little ... I can
not provide more help as configuration is dependent on the setup.
On Wed, May 6, 2020 at 7:17 PM Mark D Buck<EMAIL_ADDRESS>wrote:

This is a corporate PC behind a firewall. I am working from home due to
corona virus and remoting into the PC. So, I believe that your reference to
Enterprise, meaning Windows is correct.
Can you provide a bit more guidance on what settings to use in creating an
External vSwitch named crc?
I found another bugzilla in which you mention "You would have to create a
Virtual Switch named 'crc', that is either external, bridged or even
internal (not recommended). But you have to make sure you have a working
DHCP server that hands out addresses and allowed to attach a DNS server."
I am not familiar with virtual switches and wanting to try and get it
correct. Thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/1218#issuecomment-624589101,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZXEHR3VCZGDNL4G5SLRQFBL5ANCNFSM4MZ2XK7Q
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

I created an external vswitch called crc using the default options. Looking at the logs, I can see that it was picked up for use but the result was the same, ssh fails due to VM on unreachable network.
See gist for complete log. Any further suggestions?
https://gist.github.com/markdbuck/88619b37665e7d6cc19509247c038605

Are you on VPN? Please disconnect and try

No VPN, as I mentioned this PC is behind a firewall on an internal network. I am remoting into it. FYI, this is what I see when I try to connect to the VM from Hyper-V manager:

And that is what the VM should look like... but, when the crc client can
not communicate with the target properly, it might not be able to start the
OpenShift cluster. I'll check the logs later... and else try to see if we
can set up a call or so. Interested to see what we can do to help.
Note: I am in Asia (Chinese Standard Time/GMT+8). Email me at gbraad@
redhat com
On Wed, May 6, 2020 at 9:33 PM Mark D Buck<EMAIL_ADDRESS>wrote:

No VPN, as I mentioned this PC is behind a firewall on an internal
network. I am remoting into it. FYI, this is what I see when I try to
connect to the VM from Hyper-V manager:
[image: image]
https://user-images.githubusercontent.com/490972/81182967-8945ef80-8f7c-11ea-8b71-102600f4206c.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/code-ready/crc/issues/1218#issuecomment-624652264,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAOZSBYUX7ZR5EU54SJELRQFRLPANCNFSM4MZ2XK7Q
.

--
Gerard Braad | http://gbraad.nl
[ Doing Open Source Matters ]

Thanks, I tried an internal switch too and that resulted in the same error. Appreciate if you have some other ideas. I have googled and don't seem to be able to find info on the specific problem of SSH from host to VM resulting in network unreachable.

Hi gbraad,
I had the same issue as well with Cisco VPN on my laptop. But I was able to work around this issue by running 'crc start' when disconnected from the VPN. So will my CRC only be able to run when I am disconnected from the VPN or can the CRC run even when I am connected to a VPN?
If the CRC won't run when connected to VPN are there any alternatives.
Thanks

OK, so I believe that I have found the source of my problem. The symantec firewall on my PC is blocking the IPV6 traffic to the VM it appears from the logs. Unfortunately, it is locked down by local IT. I need to see if I can get an exception to the rule that is blocking the traffic.

I finally heard back from IT about the firewall configuration and confirmed that it is blocking IPV6 traffic.
Is there a way on Windows to configure the crc VM to use IPV4? If so, I wouldn't need any change to the firewall. Please advise on this. I don't see anything in the docs or via googling on how to change this setting.


feat: withAssignableSyntheticOpaque in assumption

[X] Put an X in this bracket to confirm you have read the
External Contribution Guidelines.

Fixes https://github.com/leanprover/lean4/issues/2361

I don't have permission to push to this branch, but here's a test for tests/lean/2361.lean:
import Lean

-- This worked before issue #2361
example {α : Type} {P : α → Prop} (a : α) (h : P a) : ∃ x, P x := by
  constructor
  assumption

example {α : Type} {P : α → Prop} (a : α) (h : P a) : ∃ x, P x := by
  refine ⟨?m, ?c⟩
  -- `?m` is synthetic opaque, so `assumption` needs to be able to assign such metavariables
  -- for this to succeed.
  case c => assumption

example {α : Type} {P : α → Prop} (a : α) (h : P a) : ∃ x, P x := by
  refine' ⟨_, ?c⟩
  case c => assumption


enhance phpcs rules

This PR has following changes.

updated phpcs rules to cover the existing code conventions
update phpcs rule to split multiple arguments into separate line as per PSR2 which was not taking an effect.
fix StyleCI issue by adding long syntax for list_syntax
disable generation of .php_cs.cache file each time we run php-cs-fixer --diff --dry-run

Added Two new composer scripts.
composer lint
Dry runs php-cs-fixer and shows file that will be changed when we actually run composer fix
composer fix
It will actually fix files that are reported by php-cs-fixer during dry run.

Thank you


InsertTab: one less space when mixing tabs with spaces

Description of the problem or steps to reproduce
Move the cursor to a tab start, and press tab, while tabstospaces=true, and tabsize=4, instead of 4 spaces, 3 spaces are inserted
https://github.com/zyedidia/micro/blob/master/cmd/micro/actions.go#L690
I guess remainder == 1 while it should be remainder == 0
Specifications
Commit hash: b09093f
OS: Debian 8
Terminal: MATE Terminal

I believe this is the intended behavior, unless I'm misunderstanding the issue. See #379.

I think you are. This issue is not about rendering at all. It's about the action of pressing Tab key.
I think the bug originated from commit 187ea0da1c70e6a906596a7538c43f2aea410054
The calculation of remainder variable is problematic I think

Oh I understand what the issue is now. I'll look into this soon.

Is it possible that we you have used v.Cursor.X instead of v.Cursor.Loc.X ?

No, those are the same variable, because Loc is an embedded struct. The issue is that a tab is visually 4 spaces but only one character, so instead of using v.Cursor.X (or v.Cursor.Loc.X) we should use v.Cursor.GetVisualX().

Oh, I see
Thanks :)


Add italian localization

Hi @Falki-git , I've translated the UI in italian, let me know if this is okay for you

Looks good!


Fix the PHP language

This patch is an attempt to fix the PHP language, when it is combined
with markup.
The problem is, that markup has a higher priority than all other tokens.
This leads to weird errors, where HTML tags are highlighted inside of
comments #197. One solution to this was to set the greedy flag for the
comment token, but this leads to far worse errors like #1097.
This patch should fix both issues #197 and #1097, by switching the
grammar to markup on the fly. One potential problem is, that it relies
on the <?php tag to detect if markup is present. So if a PHP file
contains only markup and no PHP code at all, the result will look
broken.

Before (Note: The JavaScript function is erroneously highlighted by PHP. CSS is not highlighted at all. Strings inside comments do not work):

After (Note: The string "px" looks different, because CSS has custom styles for the class token string. JavaScript and CSS are highlighted by the correct language.) :

There is one problem with this PR. If there are no <?php tags, then it assumes, that it is pure PHP code, which could be wrong:

If a <?php tag is present, then markup is also highlighted:

@LeaVerou @Golmote What do you think about this PR?

If there are no <?php tags, then it assumes, that it is pure PHP code, which could be wrong:

I don't think that's a huge problem (they can use markup in those cases), as long as it supports the shortened PHP tags as well (<?= etc). Though I don't see why we can't check if a PHP tag is present and use the markup definition if not.

Though I don't see why we can't check if a PHP tag is present and use the markup definition if not.

Yes that is one option, but I think it is more intuitive to assume that it is all PHP in that case. For example someone could use small snippets of PHP code between paragraphs on a blog to explain a larger file:
$test = "
" . $_SERVER['PHP_SELF'] . "
";

If we switch to markup in that scenario, we would force the users to put PHP tags around every small snippet:
<?php $test = "
" . $_SERVER['PHP_SELF'] . "
"; ?>

If there is no PHP code at all, people should use markup directly.

Ah yeah, excellent point! Completely agree.

@zeitgeist87 Sorry for the looong time before review. This looks ok to me! ;) Feel free to merge.

@Golmote Thanks again for the review! Merging...


Adding manual update option?

Is your feature request related to a problem? Please describe.
in my use case i need to be able to rollback the application, using semver versioning,
i want to be able to rollback to a specific version  in any given time without too much effort
as far as i know, image-updater only update forward and doesn't have the ability to do what i need
Describe the solution you'd like
i image updater is a great project with alot of features
and i think it would be suitable for alot of people if the CLI would support manual operations
and allow the users to run them manually.
for example adding "write-back" as a CLI command and giving me the ability to manually set a version of application
i think letting me write the automation my self and let image update to do the hard work of updating argocd/git
will give people the freedom they need in a more complex projects.

Agreed, this would be an extremely useful feature.

In a couple of discussions I had with people from various orgs, this inability to manually set the version (mainly to rollback quickly) was a top reason why they stopped using image updater.
I realize the point of updater is to set the version automatically and always go forward, but in reality, this just doesn't work all the time, for all cases. Giving up on updater altogether because of this seems less than ideal.
Currently, one way to do a rollback would be to disable autosync of Argo app and manually set the version in cluster directly, but this poses all kinds of problems.
How about if there is some annotation to suspend the image updater on Argo app level, so it can be committed to a repo, along with a fixed version of app itself?

Yes, we need this feature or an equivalent solution.
In reality, we always need to manually select the specific version of image for fulfilling complicated business requirements.
So, if argocd-image-updater could provide this feature that allows operators to select and filter images from a list of an application's image tags, that would be great and wonderful.

+1

+1


Migrating volume auto recovery

longhorn/longhorn#3206

Regression for core tests: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/541/

Regression for core tests: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/541/

How is the regression result?

Regression for core tests: https://ci.longhorn.io/job/private/job/longhorn-tests-regression/541/

How is the regression result?

It seems that the ci failed to init the regression test. I will redo it after updating this PR.

After the regression is ready and comments are resolved, then we should be able to merge this 👍

https://ci.longhorn.io/job/private/job/longhorn-tests-regression/545/

I don't know why all core tests are passed in my dev cluster but failed in the regression... This PR is ready to go anyway.


New suggestion:

Tell us your suggestion
Let us know what your suggestion is: Suggestion is to add emit and off functions.
How will this suggestion improve Gencord?
How will this suggestion change Gencord? Will it be helpful? - Yes it will be helpful, and we can add this in Client.ts.

Wait is this like a template?

Yeah


riscv: Only try to decode compressed instruction in misalign handler  if it's enabled

Summary
riscv: Only try to decode compressed instruction in misalign handler  if it's enabled
Impact
Minor
Testing
CI and local machine

PR does not bring any value since three is #ifdef CONFIG_ARCH_RV_ISA_C already inside the decode_insn_compressed().

@no1wudi @pkarashchenko suggestion: remove the CONFIG_ARCH_RV_ISA_C from inside decode_insn_compressed() and keep this modifications since is it more clean and makes more sense.

Can be solved multiple ways including
#ifdef CONFIG_ARCH_RV_ISA_C
static bool decode_insn_compressed(uintptr_t *regs, riscv_insn_ctx_t *ctx)
{
...
}
#else
#  define decode_insn_compressed(regs, ctx) false
#endif

and keeping dispatching loop.
I'm fine with @acassis 's suggestion, but just want to have PR description and commit message to reflect the actual change.