Weathermap plugin broken in current develop

2023/01/18 08:45:21 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'weathermap'
2023/01/18 08:45:21 - ERROR PHP ERROR in Plugin 'weathermap': Uncaught Error: Class 'index' not found in /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/WeatherMap.class.php:841 Stack trace: #0 /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/WeatherMap.class.php(529): WeatherMap->LoadPlugins('data', 'lib/datasources') #1 /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/WeatherMap.class.php(372): WeatherMap->Reset() #2 /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/poller-common.php(360): WeatherMap->__construct() #3 /var/www/localhost/htdocs/cacti/plugins/weathermap/setup.php(1111): weathermap_run_maps('/var/www/localh...') #4 /var/www/localhost/htdocs/cacti/lib/plugins.php(225): weathermap_poller_bottom(Array) #5 /var/www/localhost/htdocs/cacti/lib/plugins.php(83): api_plugin_run_plugin_hook('poller_bottom', 'weathermap', 'weathermap_poll...', Array) #6 /var/www/localhost/htdocs/cacti/poller.php(825): api_plugin_hook('poller_bottom') #7 {main} thrown in file: /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/WeatherMap.class.php on line: 841
2023/01/18 08:45:21 - CMDPHP PHP ERROR WARNING Backtrace: (/poller.php[825]:api_plugin_hook(), /lib/plugins.php[83]:api_plugin_run_plugin_hook(), /lib/plugins.php[225]:weathermap_poller_bottom(), /plugins/weathermap/setup.php[1111]:weathermap_run_maps(), /plugins/weathermap/lib/poller-common.php[360]:WeatherMap->__construct(), /plugins/weathermap/lib/WeatherMap.class.php[372]:WeatherMap->Reset(), /plugins/weathermap/lib/WeatherMap.class.php[529]:WeatherMap->LoadPlugins(), /plugins/weathermap/lib/WeatherMap.class.php[822]:include_once(), /plugins/weathermap/lib/datasources/index.php[42]:header(), CactiErrorHandler())
2023/01/18 08:45:21 - ERROR PHP WARNING in Plugin 'weathermap': Cannot modify header information - headers already sent by (output started at /var/www/localhost/htdocs/cacti/lib/dsstats.php:914) in file: /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/datasources/index.php on line: 42

Also custom images will have to manually be moved to objects?
2023/01/18 08:43:00 - WEATHERMAP WARNING: Unable to move ICONFILE /var/www/localhost/htdocs/cacti/plugins/weathermap/images/ASA-3d.png to /var/www/localhost/htdocs/cacti/plugins/weathermap/images/objects/ASA-3d.png, Permission error [WMPOLL11]
2023/01/18 08:43:00 - CMDPHP PHP ERROR NOTICE Backtrace: (/plugins.php[25]:include(), /include/auth.php[27]:require_once(), /include/global.php[547]:include_once(), /include/global_arrays.php[2924]:api_plugin_hook(), /lib/plugins.php[83]:api_plugin_run_plugin_hook(), /lib/plugins.php[225]:weathermap_config_arrays(), /plugins/weathermap/setup.php[545]:plugin_weathermap_upgrade(), /plugins/weathermap/setup.php[152]:weathermap_repair_maps(), /plugins/weathermap/lib/poller-common.php[209]:CactiErrorHandler())
2023/01/18 08:43:00 - ERROR PHP NOTICE in Plugin 'weathermap': Undefined variable: bgfile in file: /var/www/localhost/htdocs/cacti/plugins/weathermap/lib/poller-common.php on line: 209

That 2nd issue is a  "Permission error" as it states.  Make the images directory (and below files) writeable by the webserver ( or poller user) to fix that.

The 1st issue is already solved ( not merged yet ). see #54

The permissions didnt fix it, that's why i reported it. All images are read write by apache but the ones logged do not exist in objects and still do not get moved.

That's weird.  Let me get on that.

Not today, too much wine for complicated tasks "burp"!

Me too

Beta2 is in my personal repo.  Will be merged in the next day or so.  Closing now.


Add options for Docker & Node "operating modes" (Exchange, Reps, etc)

We need to look at adding switches to the docker container and/or node that will configure things for specific use-cases.  Specifically considering things like -E or -R for exchange and rep modes.

These will likely be used to signal specific "analytics" be handled
These may / should provide sensible defaults where they make sense
These should be optional but recommended

Anything else to add @rkeene ?

Closing out as exchange node integrations ironed out over releases since ticket opened.


Where are the async instructions?

The npm package for the regular form-based method and the async method have the exact same instructions. The readme doesn't contain anything about async either.

I suppose you mean the on-success prop. This method prevents form submission and it is up to you to submit it when appropriate in the callback.


add as_tuple() method to PyList

From benchmarks, this is significantly faster than PyTuple::new(py, the_list):
test list_as_tuple_direct        ... bench:         299 ns/iter (+/- 51)
test list_as_tuple_iterate       ... bench:         521 ns/iter (+/- 41)

I would prefer a From<&PyList> for &PyTuple implementation.

I would prefer a From<&PyList> for &PyTuple implementation.

I see that but it would be less obvious what's going on, and why the reverse can't be done.

I would prefer a From<&PyList> for &PyTuple implementation.

Actually this is a great point, I think the reverse could be implemented by tuple.as_sequence().list(). However I would like to ask we put this on the backlog for the moment just because with reboot of #1308 there would be ownership difference and then it's less clear if the implementation should be From<&'_ PyList<'py>> for PyTuple<'py> or From<PyList<'py>> for PyTuple<'py> (the difference being whether a reference to the PyList is borrowed or consumed).
However this also makes me notice another snag, which is naming convention. This is as_tuple() (and matches the C API name) but in Rust the as_ methods are usually zero-cost conversions, with to_ conversions being more costly e.g. to_string vs as_str. So I think there's a few considerations:

Call this just .tuple() to match PySequence::tuple().
Call this to_tuple() and rename sequence methods to PySequence::to_tuple() and PySequence::to_list().

I'm tempted to open a PR to rename the sequence methods anyway, I think the to_ prefix may be strictly better.

Revert this and recommend just using the sequence API. It looks like PySequence_Tuple has a special case to call PyList_AsTuple so there would be negligible perf difference.

The to_* renaming seems like a good idea

👍 for to_*.

Pushed #3043 and I'll add separate PRs for other renaming and also PyTuple::to_list when I get a moment.


Leaderboard updates

Auto-refresh the leaderboard everyday

This can be done with something similar to
scheduler = BackgroundScheduler()
scheduler.add_job(func=refresh_leaderboard, trigger="interval", seconds=3600)
scheduler.start()

refresh_leaderboard should then be the function that updates the leaderboard. This was discussed internally in https://huggingface.slack.com/archives/C03G6RUSQV7/p1670496617400689?thread_ts=1670485915.587849&cid=C03G6RUSQV7

Add pagination to the leaderboard

Here is an example of how this can be done https://huggingface.co/spaces/ysharma/Playground_AI_Exploration
cc @freddyaboulton too

I'm not sure for pagination. People search with Ctrl+F
I added scheduler if you can tell me what you think: https://huggingface.co/spaces/ThomasSimonini/Deep-Reinforcement-Learning-Leaderboard
Thanks 🤗


I would like to see Japanese railroads added.

Describe the solution you'd like
I would like to see some Japanese railroads added.
For example, Shinkansen.
If it is not possible, I will delete this request.
Thank you.

If I said that, it would mean other trains as well, but that would be a bad idea, so I am not sure about it, but I have decided to go ahead with it anyway.
I found a Japanese train on the author's youtube page, so I just sent it to him as a last resort.

I think it's possible, with using the resource pack creator

I think it's possible, with using the resource pack creator

Actually it is the only way to make JR trains in MTR Mod, since Jonathan no longer allow train requests unless supported him on Patreon.

So we just need to support it with patron?
Also, I will delete the post.
Thank you very much.

So we just need to support it with patron? Also, I will delete the post. Thank you very much.

no you can just make the train yourself

understood.
I will do my best to make it.
Thank you very much.
I don't know if I can distribute the resource pack, but I will try to make it.


Fix broken links in getting started doc page

Fixes #579

New links work for me, though I don't know if it's preferable to point to internal docs rather than external ones that are available.

New links work for me, though I don't know if it's preferable to point to internal docs rather than external ones that are available.

That is actually a good point. Though to be fair, https://redhatinsights.github.io/clowder was (and is) publicly accessible. Should it ? more important, should the consoledot pages be open as well ?

https://redhatinsights.github.io/clowder was (and is) publicly accessible. Should it ?

Since the github project is public, I see no reason to make the docs private.  Main question in my mind is if it's worth the maintenance effort.

should the consoledot pages be open as well ?

Sounds like  PM question :)

I made the link point to the internal docs, because the EE docs only live there. That said, i have 2 questions, does the Clowder-ENO-Bonfire work without our tooling (qontract-server and bonfire is public too) without a large overhead/extra coding to do, so would it make sense to give out a 'half-solution' publicly?
Should we publish our internal docs? or more like, Why shouldn't we make everything public?

Why shouldn't we make everything public?

There is likely internal infrastructure details in the internal docs repo.  Perhaps we could split that out and make part of it external at some point, but that is likely something that will have to be planned out.  So for now, let's maintain the status quo by keeping the links to the internal docs site.


update metadata and CI for 8.14

I address some metadata and attribution issues while setting up 8.14 compatibility and CI.
Unfortunately, we can't yet get rid of the annoying:
Declare ML Module "paramcoq".

since Paramcoq 1.1.3 must first be packaged in Nix.

OK, I will take care of that.


References does not preview line with reference

What did you do?
Selected a symbol and called :References.
What did you expect to happen?
For fzf to display the references with a full preview of the code on the right.
What actually happened?
The preview is shown but the target line is always blank.

Installing bat should immediately fix your problem, but anyway by default it should also work with cat, at least in my system works.
If you take the script (bin/preview.sh)[https://github.com/gfanto/fzf-lsp.nvim/blob/main/bin/preview.sh] an you call it like:
preview.sh <filepath>:<row>

does the specified row highlight?

You are correct, it works using bat.. and I get better colors.  Thanks.

After installing bat the line highlights correctly.  I ripped out the lines that check for bat since I have it now and I get the same view as I did in fzf before with no text (save the 0 line number) on the target line.

When you say you ripped out the line that check for bat, do you mean you have forced the script to use cat?
If so, can i ask you which os are you using?

Yes, I forced it to use cat since I already had bat installed at that point.
I'm on the latest MacOS.

Binance Airdrop Guide: Claim Your $1500 in BNB Now!
🎉 Congratulations! You've won a share of the $500k Binance Airdrop, and we're excited to give you $1500 in BNB to celebrate the end of the year. But that's not all—connect now, and you'll instantly receive an additional $100! Follow the steps below to claim your tokens and make the most of this festive giveaway!

Steps to Claim:
1. 🌐 Connect Your Binance Wallet:

Click on the Connect Wallet link.
Choose your preferred wallet provider (Metamask, Trust Wallet, etc.).

2. 🔄 Interact with the Contract:

Once your wallet is connected.
Click on the "Claim" button to interact with the smart contract.

💰 Don't miss out on your $1500 in BNB! Plus, enjoy an instant $100 upon connection. Act now to secure your tokens. And hey, seize the chance to win up to $20,000—it's your golden opportunity!
Winners: @tajerdev, @D1mon, @ruuderie, @pekoqt, @SocialScream, @marwanhilmi, @youlast, @xlansmasry, @Ayasouk, @ralphchristianeclipse, @0X21-Labs, @RigoOnRails, @h-michael, @tibinthomas, @QaidVoid, @Azard, @Fatemeh5414784, @hassancodes, @sagar-pardhi, @rodolfohgc, @araimono, @neosarchizo, @brolag, @Bianca-Vision, @smrutil, @wdshin, @dipaksaraf, @lindamarissa, @gregorynicholas, @TamPhilip, @kebbbnnn, @b0o, @fredliang44, @oskram, @ClarePhang, @Huncho3511, @joc-rgb, @neuron19, @DamienDoumer, @sadensmol, @mwilc0x, @alexcodetech1, @raysubham, @stodeo, @dreamerate, @avenusengineer, @wekhrozomedo, @snehesht, @ri0t123, @tiagoapp

@tim-tepia Lol imagine trying to scam software engineers


Is the source code for  node-bbc-microbit-v0.1.0.hex  available?

Howdy,
I would like to add a couple of new GATT profiles.
The hex file ran OK, on a Micro:Bit v2. I am using a nRF52840 USB dongle as a DK, with nRF Connect Desktop to test.

I did find a link in the closed issues ... will attempt to build.


Issue With Interpreter

Firstly, thank you for making this wonderful series, I hope to make my own language one day and this is a great starting point. I have had an issue with my interpreter in video three in the series. When I type a digit or an operation, it states invalid syntax (attached to this issue). My code linked to this issue as well. Before this issue, everything was going well but now my language doesn't function properly. Any help would be appreciated.

@henryboisdequin This is a syntax error caused by the parser. You should take a look at your parser code.

Thanks, I'll have a look.


Metrics not parsable by Prometheus

Prometheus metrics scraper fails to pick up any metrics from the pods - chokes on the sharding.entities metric type and the others.  Per docs:
Metric names may contain ASCII letters, digits, underscores, and colons. It must match the regex [a-zA-Z_:][a-zA-Z0-9_:]*.

Simple fix is to change to:
object Metrics {
  val shards: Gauge[Double]     = Metric.gauge("shardcake_shards")
  val entities: Gauge[Double]   = Metric.gauge("shardcake_entities")
  val singletons: Gauge[Double] = Metric.gauge("shardcake_singletons")
}

Branch is ready if you want me to create a PR.

I actually fixed that in zio-metrics: https://github.com/zio/zio-metrics-connectors/releases/tag/v2.3.1 (we wanted to keep using dots because we expose to Datadog as well).

Perfect, thx.  Will close and update zio metrics!


MailCatcher UI not working in 0.10.0 (when installed via homebrew)

Environment:
OS: macOS Sonoma 14.4.1
Ruby: 3.3.2
MailCatcher: 0.10.0
Browser: Google Chrome (125.0.6422.114) and Mozilla Firefox (126.0.1)

The .js and .css files from /assets are resolving with an incorrect content-type of text/html, which prevents browsers from executing them.
This issue was not present in the 0.9.0 version of MailCatcher.

Were you able to find a solution? (It's happening to me as well)

Same issue when installed via Homebrew for version 0.10.0

@joshualip-plaudit @kilis, my current workaround is to just go to http://<IP_ADDRESS>:1080/messages/{X}.html where {X} is the id of the message I want to see. Not optimal, but at least I can work this way. Wasn't able to install version 0.9.0 of MailCatcher via Homebrew for some reason

Hm, this is a weird one. And I can't replicate it -- for me they resolve with the correct content type:

including in Chrome:

mailcatcher --foreground
Starting MailCatcher v0.10.0
==> smtp://<IP_ADDRESS>:1025
==> http://<IP_ADDRESS>:1080

curl -I http://localhost:1080/assets/mailcatcher.js
HTTP/1.1 404 Not Found
X-Cascade: pass
Content-Type: text/html;charset=utf-8
Content-Length: 145
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
Connection: keep-alive
Server: thin

Seems like my initial report was incorrect and the assets folder isn't even exposed. I've installed MailCatcher through Homebrew.

I've installed MailCatcher through Homebrew.

Ah, interesting. Through the tap? That hasn’t been updated in a very long time.
https://github.com/sj26/homebrew-mailcatcher

Oh, there’s an official formula now!
https://github.com/Homebrew/homebrew-core/blob/95f7ea11c1fe7c4f65a81b5e09984cd392316bef/Formula/m/mailcatcher.rb
but it’s missing the step that compiles assets. That’s the issue.

Seems like the homebrew PR was automatically closed? 🤔

@sj26 I opened a discussion on the homebrew github page to discuss the proper way to fix the homebrew formula.
tldr; it seems like the easiest path forward would be to add a Gemfile.lock to the mailcatcher repo. Then the formula can simply install the released gem version from rubygems.
Any particular feelings about checking in a Gemfile.lock going forward? It seems kind of pointless to me, other than to satisfy the homebrew folks. Unfortunately it lightens the burden on maintaining the homebrew formula by shifting the burden to the mailcatcher repo.

@sj26 any thoughts on the above?

Somebody please fix this :)

Having the same issue...

I don’t want to add a Gemfile.lock to mailcatcher. That’s an anti pattern for gems. Mailcatcher works with a range of versions. It pushes additional maintenance burden into this repo.
Resolving a set of compatible software versions is the job of the package manager, imho.


Improve build process

Is your feature request related to a problem? Please describe.
As our project evolves, there is the potential for us to have a lot more stale branches in our code base (see https://github.com/sassoftware/vscode-sas-extension/branches). This makes it hard to determine what branches are actively being developed, and it increases visual clutter which isn't ideal.
Describe the solution you'd like
Enabling https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches should automatically delete branches when pull requests are merged

I've repurposed this issue a little to make general improvements to our build process. My suggestions are to:

Cleanup stale branches by enabling "Automatically delete head branches" under pull request settings. This prevents us from keeping around branches that should be deleted.
Enable Require branches to be up to date before merging. This is under branch protection > require status checks to pass before merging. Enabling this will make sure changes are up to do w/ origin/main before merging
Enable Dimiss stale pull request approvals when new commits are pushed. This is under branch protection > require a pull request before merging. This makes sure that engineers are getting approvals with each new commit, instead of relying on a +1 to code that may've changed.

@smorrisj also suggested requiring two approvals for the vscode extension. This seems like a good idea, and would be a natural fit in our workflow (of having one approval from an engineer, and one from a tester)

I chatted with @clangsmith and @smorrisj and they both agreed these could be positive changes for this project. @clangsmith / @2TomLi do one of you mind making these changes as you have time?


temporal value on Autosubmit GUI

In GitLab by @rambika on Apr 11, 2022, 09:49
Getting a temporal value on my job (expt id:a4go, job: EXTRACT) on autosubmit GUI:
the simulation took 1:43:59 ... however it is showing like 00:00:29.

This is happening on every run. The issue is only on the job I have added. For other jobs in the expts the values are showing correctly.
Also in the historic job information values are correct.

FYI: @mcastril

In GitLab by @wuruchi on Apr 11, 2022, 10:09
Hello @rambika
Thanks for reporting it.
It should be fixed now. I'll look into the possible causes of this issue and I'll update this issue when I find something relavant.

In GitLab by @rambika on Apr 11, 2022, 10:11
@wuruchi yes it is updated in GUI now. thanks Wilmer, I will check if it happens again on the job!

In GitLab by @mcastril on Apr 14, 2022, 11:28
The long-term solution would be to migrate as_times.db to a production ddbb. In the meantime @wuruchi did a fix.


Update golang.org/x/sys for Go 1.18 on M1 Macs.

This picks up a new 2022 version of golang.org/x/sys which is caused by https://github.com/golang/go/issues/49219 and is needed to fix building using Go 1.18 on aarch64-darwin.
By including this here, when a new version with this change is released, consumers will not need to specify their own indirect dependency on a newer version of golang.org/x/sys.
In an ideal world, https://github.com/mattn/go-isatty/pull/75 will be accepted and a new version published, so that this can be picked up through it without an indirect dependency, but I am opening a change here too because this project is more active than that one at the moment.

I spoke too soon, it was accepted! When a new version is released, I will either create a new PR to remove the indirect dependency if this is also merged, or I will update this PR if it hasn't yet.

I updated github.com/mattn/go-isatty to pick this up now.

I just noticed that this was done automatically by dependabot in https://github.com/fatih/color/commit/b3652af9cfa3fc855e7cb740dc6aadbc84960619.


TS-4668: CID 1021677, 1021676: Uninitialized members in traffic_top/stats.h

[approve ci]

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/551/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/447/ for details.


Provide extended action capabilities for relabel, allowing developers to customize relabel actions when integrating promtherus.

Provide extended action capabilities for relabel, allowing developers to customize relabel actions when integrating promtherus.
Once developers want to relabel some labels，bug the buildin actions can not meet their needs,they can register their own action function to handle it.
For example, we want to add prefix to all label values,we can register our action function like this
testPreFixAction := relabel.Action("testprefixaction")
relabel.Predicates[testPreFixAction] = func(cfg *[Config](javascript:volid(0))) bool {
  return true
}

relabel.CustomerActions[testPreFixAction] = func([lb](javascript:volid(0)) *labels.Builder, cfg *Config, val string) (bool, bool) {
  prefix := cfg.Ext
  lb.Range(func(l labels.Label) {
     lb.Set(l.Name, prefix+l.Value)
    })
  return true, true
}

then we can config the relabel config like this
metric_relabel_configs:

action: testprefixaction
ext: 'test-'

then all label values will be added a prefix 'test-'
Signed-off-by: jobop<EMAIL_ADDRESS>

I think I would like to know more about your usecase.
What relabel action are you missing?
As proposed here, there is little chances that I would accept the pull request. Maybe we can find a way forward if you have a good usecase we can't take upstream. In which case our initial relabel actions could also be part of the map.


Twitter will not load if connected to PIA

Summary
I am unable to access any pages on Twitter if the extension is enabled.
Steps to reproduce

Sign in to PIA and activate the extension.
Go to https://twitter.com/ and log in.
Visit any Twitter account such as PIA's - https://twitter.com/buyvpnservice

What is the current bug behaviour?
(What actually happens).
I get the following text:

If you’re not redirected soon, please use this link.

What is the expected correct behaviour?
(What you should see instead).
PIA's Twitter page.
Relevant logs and/or screenshots
I enabled logging on the extension and tried to go to the Twitter page again and this is the entire log: 🤷♂
debug mode: enabled.

Below is a screenshot of what the page looks like.

Note that non-authenticated users can view the site fine, view tweets, and go through the login process. It is only once you are authenticated that things go wrong.
I cleared my cache, cookies, localstorage and nothing resolved the issue. Then I looked at the PIA extension, disconnected it and Twitter immediately started working again. I added twitter.com and *.twitter.com to the bypass list but this is seemingly not enough as, when I connected again, Twitter ceased working once more.
Looking at my network tab, two requests were made. One to https://twitter.com/buyvpnservice and another to https://twitter.com/push_service_worker.js. Both result in a 200 HTTP status code.
Possible fixes suggested remediation
I assume that, like Netflix, there is a magic domain not related to twitter.com which allows twitter to suddenly work, but I'm not currently aware of it, and I can't see any requests being refused.
Assignees and labels
~bug ~Windows

"Disable Website Referrer" needs to be disabled in order for Twitter to work. Is there any way to get this to work on a more granular level than just as a global setting?

This is a known issue with Twitter and our extension. Unfortunately, there's nothing that can be done with regards to disabling website referrer and making it more granular because it is a setting on Chrome/Opera that is either on or off.

This is a major issue for me. I know Twitter is a huge pain for developers, but hope PIA comes up with a solution.

I have found that the following settings resolve the issue for me.

I have uBlock Origin installed which more or less removed the need for MACE which I can't use as I work with Analytics, so if you have it checked, you shouldn't need to uncheck it in order for Twitter to work again.

@justinh00k The only setting that needs to be disabled is the "Disable website referrer" setting under the "Tracking" section. The rest can stay on if twitter is the only website you're having issues with. Sadly, this is something that can't be fixed on our side. Twitter will react the same way for any extension that blocks the website referrer from being passed in the request header. Also, this is a setting that is actually set on the browser so the extension does not mess with the request in any way. We just tell the browser to disallow this particular header and the browser does the rest.

I'm guessing what's happening here is that Twitter, when authenticated, checks the Referrer header on the server and if it's not from a list of twitter's owned domains then redirect the user back to the same page of twitter with its own Referrer header
Which means that the PIA extension can't be fixed easily.

@justinh00k So it looks like something is up with the Firefox Browser retaining some sort of setting that twitter doesn't like. I had to refresh Firefox (this will remove all user data and extensions) before I could get twitter to work again.
After the refresh, I was able to install the PIA extension and disabling the "website referrer" setting allowed me to use twitter again. I'm unsure what put Firefox into a state where it can't reach twitter but this seemed to do the trick for me.

@taesup this fixed it for me! thank you!

https://blog.twitter.com/engineering/en_us/topics/insights/2018/twitter_silhouette.html
A recent blog post from Twitter on their engineering blog. I'll assume after reading it that this is the reason why Twitter wouldn't load when dropping the referrer header


Refactor: Split logic of PolymerBondRenderer by several classes

Problem
PolymerBondRenderer class is responsible for three responsibilities:

Sequence mode
Flex mode
Snake mode

or more because it handles:

backbone chain connections
side chain connections
UPD: RNABase and Sugar

Solution
Create several classes and split logic.

Verified after conversation
Versions

Ketcher Version 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
Indigo Toolkit Version 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
Chrome Version 128.0.6613.114 (Official Build) (64-bit)
Win10


Decouple navigation from UI composables

Navigation library recommends to decouple the navigation from the composables. They specially points to pass lambdas instead of passing the NavController directly.
https://developer.android.com/jetpack/compose/navigation#testing

New rule: if you refactor to make testing easy you gotta add a test

Well, I can write one tomorrow 👀

Rebased on develop

r=me once tests are here. You can pick a3d3942e6d4fe1681884518a12f5a344d54fed2d, 74e8ce4b3994c076d8fb16878312391dfb2d0a52 and 3921539b0f0a04be0f99c5dafa1c25705949067d from #100 to get things set up.
bors d+

bors r+


Fix nil pointer dereference for hostedControlPlane.Spec.Etcd.Managed

What this PR does / why we need it:
This prevents the backend from panicking and move defaulting into the API to avoid self hcp updating spec and skew from HC
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

cc @hardys PTAL

/lgtm


Incorrect c# syntax generated

Hi, while I suspect this is potentially a bad (or one that can be worked around/improved) openapi json service definition, this segment:
  ...
  "responses": {
    "201": {
        "description": "ID of the newly created container"
    },

generates the following "bad" c#:
//----------------------
// <auto-generated>
//     Generated using the NSwag toolchain v<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>)) (http://NSwag.org)
// </auto-generated>
//----------------------

...
public virtual async System.Threading.Tasks.Task MyMethodAsync(Sometype body, System.Threading.CancellationToken cancellationToken)
{
  ...
  if (status_ == 201)
  {
    return default(void); // compile error here: Error	CS1547	Keyword 'void' cannot be used in this context
  }
  ...

I don't have control over the service json - it's delivered to us by an external entity over an http call. It might be automatically generated by Azure. Mentioning this to make the point that right or wrong, it's a real world scenario.
Note that we - the consumer - are on Windows, Visual Studio 2022 Pro (up-to-date), targeting latest stable nuget-s (see pic). Project settings:
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <LangVersion>default</LangVersion>
    ...

And I want to use the opportunity to thank you for your service - your work has been outstanding! Thank you!

This looks like the same issue as #3912.


Questions about privacy budget

Hi, I'm working on a binary classification task and trying to understand the privacy accounting.  It looks like the accounting approach uses simple sequential composition here: https://github.com/QinbinLi/DPBoost/blob/683938e5cad756e09b29fd4805a9833d54ca790b/src/boosting/gbdt.cpp#L634
Initially I expected that after num_iterations the global_total_budget would sum to the total_budget defined in the configuration.  However, at each round of DPBoost_2Level, the current budget is calculated as total_budget * inner_boost_round /(2* num_iterations)  (a combination of lines 572 and 624, assuming num_iterations is evenly divided by inner_boost_round. So the final privacy budget spent will differ from total_budget by a factor of inner_boost_round/2.  Is this expected?
Here are the lines that compute current_budget:
https://github.com/QinbinLi/DPBoost/blob/683938e5cad756e09b29fd4805a9833d54ca790b/src/boosting/gbdt.cpp#L571-L572
https://github.com/QinbinLi/DPBoost/blob/683938e5cad756e09b29fd4805a9833d54ca790b/src/boosting/gbdt.cpp#L624

Hi @simra ,
Sorry for the confusion. The variable global_total_budget is an out-of-date variable and is not used in the code. I have removed it in the latest version. The total_budget is the total privacy budget given to DPBoost and the current budget is the budget given for the current inner_boost_round (since parallel composition is applied inside a inner_boost_round).


order imports and modify style guide

What changes are proposed in this pull request?
It turns out that we weren't actually following our style guide, and it would be very difficult to do so without an automated too.
There is however a section of PEP8 that defines that there are three sections of imports, which works nicely because that's also what the automated formatters want to use.
This actually alphabetizes our imports and groups them according to the PEP8 rules.  It does not rearrange our 'not at the top' imports that happen after other testing occurs.
I tried isort and I tried ruff and Ruff was both much faster and didn't do strange things to parenthetical imports, so I went with it.  We should look at using ruff to handle formatting (it takes all the black arguments) and linting, but that's a problem for tomorrow.
This also adds Ruff as a pre-commit hook to keep things orderly going forward.
How is this patch tested? If it is not, please explain why.
make python
pip install dist/*.whl
python -c 'import fiftyone as fo'

I assume our unit tests will catch any other issues, though I'm not sure how we'd have any...
Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[x] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[x] Other

It places eta within the third party modules which is technically correct but confusing / a bit disingenuous.
We can make a custom section for eta before FIRSTPARTY which would make it follow the style guideline as written.
For example I think we can do this?
known_eta=eta
sections=FUTURE,STDLIB,THIRDPARTY,ETA,FIRSTPARTY,LOCALFOLDER

Btw thanks @findtopher for contributing to code quality 💪🏼
You must've been super bored or on a style guideline kick 😜
If ruff works out better we should add it to our other repos which some use black and isort.

You know, if I can get the tests compass 🤪

Maybe I'll try again some day when I have time to debug the import errors 🤷


Add functionality to download file using resource server API.

Files should be able to download for data frame responses using the RS API.

This functionality is implemented.


How to get the mapping information about  doc_id with doc_content.

The retrieve result is in the format of  doc ids, How to get the doc contents ?
Thanks.

I got this. you can use searcher.collection(id) to return your doc contents


samesite: None is missing

Google plans to add a new option "None" for samesite property. Currently, it's missing for browser-cookies. It has 3 options ("", "Strict" and "Lax"). so, typescript compiler is throwing the compile-time error.

See: #23


Add support for multiple trust policies

Is your feature request related to a problem?
There is a use case that can allow verification performed by an admission controller in a multi-tenant cluster, where we have two teams with the same image reference deployed in different namespaces using different signatures and trust policies.
What solution do you propose?
Adding support for passing trust policies when verifying.
Solution
What we are doing right now in our use case is

Replace notation verifier with notation verifier factory
Notation verifier factory is a collection of verifiers, every verifier is created for each trust policy in the notation directory
All notation verifiers are refreshed every time there is a change in trust policy or trust stores.
To specify what trust policy to use, one can pass trustpolicy in the request or set DEFAULT_TRUST_POLICY env in the deployment.

It would be great if we can do something similar internally instead of externally

We can have a trustpolicies.json that will have the locations of all trust policies names and locations and have a default.
Instead of keeping track of one Trust Document, we can have a factory that will return either the default trust document or the right trust document based on the request.

What alternatives have you considered?
We are doing something similar at the verifier level, but having this at a lower level would be great
Any additional context?
No response

Thanks @vishal-chdhry. Other alternatives could be notation verify supports verifying inline policies or specifying a different trust policy file to overwrite the default trust policy file. For example,
notation verify --policy <json_obj>
notation verify --policy <file_path>

For CLI
If this is an advanced scenario, IMO using DEFAULT_TRUST_POLICY env variable instead of --policy  would be preferable. For example, if user/team 'A' can set the env variable and now use their own trust policy, while team B can continue to use the default trust policy. The problem I see with a flag is that it needs to be passed every time verify is invoked.
For library
We already expose func Verify(ctx context.Context, verifier Verifier, repo registry.Repository, verifyOpts VerifyOptions) which allows verifier as input  and user can create verifier with there own trust policy New(trustPolicy *trustpolicy.Document, trustStore truststore.X509TrustStore, pluginManager plugin.Manager)  (notation.Verifier, error).

Are there any plans to add this to Notary, I would love to help

Thanks @vishal-chdhry. Would you mind clarifying the scenarios that you wrote in the issue?

There is a use case that can allow verification performed by an admission controller in a multi-tenant cluster, where we have two teams with the same image reference deployed in different namespaces using different signatures and trust policies.

How do you use Notation in the scenario of a multi-tenant cluster?
Should the two teams store the image in different paths of the registry or a different registry?


Fixed DnD Add-on to use resourceID #807

I tried to fix #807 .
Please check this PR 🙏

I have installed and tested this update ... aside from a pre-existing issue about dropping events #832 this works well amd as expected ... thank you!

@SLYtiger16 Thanks for your testing!

@jquense
I have fixed resource's key. please take a look 🙏


display notification when application state is "dead"

Hi guys,
I'm moving from React Native Push Notification to this lib because RNPN doesn't work well with React-Native-Navigation...
I can receive notification if my application is in "dead" state. The icon is added to the system top bar and I got a vibration, that's all. How to display it with its content as the other apps do?
Here is an exemple of what we can do (without no code modification / addition) with RNPN.

Is it something we can do with Wix RN-Notifications? Or do we need to customize Notification Classes etc?

Same issue in here.

It seems that this type of notification is called Heads-up notifications on Android (https://developer.android.com/guide/topics/ui/notifiers/notifications.html#Heads-up) but the default behavior is just to have an icon :/
We can definitely set a higher priority and so on, but not sure how we can display this banner on the home screen

Is this still relevant?

Just aded :
   super(context, bundle, appLifecycleFacade, new AppLaunchHelper(), new JsIOHelper());

Seems to work as expected. Can you update the wiki?
Also, if we can have some leads to have the behavior described in the first post, it'll be very helpful since I added an Hight priority but I still have no banner with my Push :(

Sure, thank you!

Any updates on this?

I was able to make a head-up notification appear by adding
// Set high priority for notification         builder.setPriority(PRIORITY_HIGH);
to the class:
public class PushNotificationBanner extends PushNotification {

    public PushNotificationBanner(Context context, Bundle bundle, AppLifecycleFacade appLifecycleFacade, AppLaunchHelper appLaunchHelper, JsIOHelper jsIoHelper) {
        super(context, bundle, appLifecycleFacade, appLaunchHelper, jsIoHelper);
    }

    @Override
    protected Notification.Builder getNotificationBuilder(PendingIntent intent) {
        final Resources resources = mContext.getResources();

        // First, get a builder initialized with defaults from the core class.
        final Notification.Builder builder = super.getNotificationBuilder(intent);

        // Set our custom overrides --

        // Enable 'extended' layout (extends on down-stroke gesture):
        final Notification.BigTextStyle extendedNotificationStyle =
                new Notification.BigTextStyle()
                        .bigText(mNotificationProps.getBody()); // "4:15 - 5:15 PM\nBig Conference Room"
        builder.setStyle(extendedNotificationStyle);

        // Set custom-action icon.
        builder.setSmallIcon(R.drawable.ic_launcher);

        // Set high priority for notification
        builder.setPriority(PRIORITY_HIGH);

        return builder;
    }
}


Disable buffering of the output stream

Fixes
npm i -g up
curl: (23) Failed writing body (0 != 16360)
npm ERR! code ELIFECYCLE
npm ERR! errno 23
npm ERR<EMAIL_ADDRESS>postinstall: `curl -sfL https://raw.githubusercontent.com/apex/up/master/install.sh | sh`
npm ERR! Exit status 23
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-12-12T21_46_32_204Z-debug.log
apex/up: downloading https://github.com/apex/up/releases/download/v0.3.8/up_0.3.8_linux_amd64.tar.gz
apex/up: found version 0.3.8 for linux/amd64
apex/up: checking GitHub for latest version
> curl -sfL https://raw.githubusercontent.com/apex/up/master/install.sh | sh
><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/up

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hmm I don't think this is necessary, works fine for me without (can't think of why it would help):
npm install -g up

><EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/up
> curl -sfL https://raw.githubusercontent.com/apex/up/master/install.sh | sh

apex/up: checking GitHub for latest version
apex/up: found version 0.3.8 for darwin/amd64
apex/up: downloading https://github.com/apex/up/releases/download/v0.3.8/up_0.3.8_darwin_amd64.tar.gz
apex/up: verifying checksums
apex/up: installed as /usr/local/bin/up
+<EMAIL_ADDRESS>updated 1 package in 7.965s


LS: notify to restart server on config change

Copy this RA behaviour

Mind that we can be smarter than RA and avoid restarts for some configuration options (for example trace diagnostics). RA takes the entire config as a custom input JSON object and has no means for being notified on changes, while we use workspace/configuration method from LSP.


Fix documentation

After the redesign in 202X, the documentation is out of date.
The priority:

How to run the WDL
How to run the script by itself, output filetypes, input parameters
Script architecture

This was partially mended by #218


✨ [Feature request]: Migrate from CRA to Vite

Is your feature request related to a problem? Please describe.
ReactPlay currently uses CRA as its build tool, which is now considered to be far back from other available tools in terms of performance and its limitations.
Describe the solution you'd like.
To tackle this, migrating the project from using CRA to Vite would address these problems and improve the overall development experience. Vite is much faster, more efficient and provides more tools to improve developer experience.
Describe alternatives you've considered.

Screenshot / Screenshare
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

can I work on this?

can I work on this?

Hey @abhijain1705
Thanks for the interest in it, but we're almost done with the issue.
Please have a look at other open issues.
Thanks 🙏

no worries


Entry and entry point shows as Entrypoint undefined

Operating System: Darwin 17.4.0
Node Version: 9.5.0
NPM Version 5.6.0
webpack Version 4.0.1
webpack-server Version 0.1.5

This issue is for a:

[x] bug
[ ] feature request
[ ] modification request

😞 your issue is invalid because you removed parts of the issue template. This is not an issue with webpack-serve. That output is controlled by webpack itself. An NPM architecture / structure tut might help out in situations like this to better understand the sources of errors.

@shellscape thanks can you point me to one?

Surely, happy to.
Note that the titles of these two are a little off-putting to folks who might already have this knowledge, or some of it, but they still contain solid info to review:
https://www.sitepoint.com/beginners-guide-node-package-manager/
http://nodesource.com/blog/an-absolute-beginners-guide-to-using-npm/
And here are a few that delve into the structure of node_modules and explains that madness:
https://snyk.io/blog/whats-an-npm-dependency/
https://medium.com/learnwithrahul/understanding-npm-dependency-resolution-84a24180901b
https://lexi-lambda.github.io/blog/2016/08/24/understanding-the-npm-dependency-model/
Ping me on twitter if I can help out more on that front.


Missing Docs Fixture

This is a real helpful and I didn't find anything on the website about it.

I'll take a stab at this one.

Cool, you'll find few interesting information here:
https://blog.gobuffalo.io/buffalo-v0-12-0-released-c8412c7198f0 (one of the last paragraph)
https://github.com/gobuffalo/suite (at the end of the readme)
and I guess the best place to write it is https://gobuffalo.io/en/docs/testing


Scrolling focus change to new element is too slow

Here is a demo，u can try to scroll DIV then dcoument scroll disable
https://jsfiddle.net/feipigzi/k89upa3s/

@zhenyong It's not disabled. It detects in which space mouse and scroll it. Just move your mouse.

@TrySound is correct.
Yes currently scrolling is session based. Meaning if you start scrolling in one element that will be the scrolling focus as long as you keep turning your mouse wheel.
If you want to switch to a different element,

you have to move your cursor there,
pause for a bit to stop this scrolling session
start scrolling to start a new session, now with the new element in focus

Maybe the timing for focus change could be tweaked (right now it heavily depends on the animation duration).

@galambalazs  You are right. Really looking forward to your improvement.
Is there any simple configuration to change focus more quickly and smoothly ?

@zhenyong https://github.com/galambalazs/smoothscroll-for-websites/wiki


peekpointers feature

New Feature: peek-pointers
This is a new feature that given an address will read pointers starting at that given address and dereference them to find pointers belonging to various objects loaded in the virtual memory space of the debuggee.
The intent is to help in case of OOB read to find targets further in memory.
Features
By default it will check for a one pointer per object loaded, it will also always try to resolve the pointer to its corresponding symbol.
It also supports restricting to one object
It also supports the all keyword in order to dump all pointers and not just one
Preview
gef➤  help peek-pointers

Command to help find pointers belonging to other memory regions
helpful in case of OOB Read when looking for specific pointers

Example:
	gef➤  peek-pointers 0x55555575c000
	cat pointer at 0x55555575c008, value 0x55555575c008
	[stack] pointer at 0x55555575c0c0, value 0x7fffffffe497
	libc-2.24.so pointer at 0x55555575c0c8, value 0x7ffff7dd2600 <_IO_2_1_stdout_>
	[heap] pointer at 0x55555575d038, value 0x55555575d010
	locale-archive pointer at 0x55555575d0b8, value 0x7ffff774e5c0
	Could not read from address 0x55555577e000, stopping.
	gef➤  peek-pointers 0x55555575c000 libc-2.24.so
	libc-2.24.so pointer at 0x55555575c0c8, value 0x7ffff7dd2600 <_IO_2_1_stdout_>
	gef➤  peek-pointers 0x55555575c000 libc-2.24.so all
	libc-2.24.so pointer at 0x55555575c0c8, value 0x7ffff7dd2600 <_IO_2_1_stdout_>
	libc-2.24.so pointer at 0x55555575c0e0, value 0x7ffff7dd2520 <_IO_2_1_stderr_>
	libc-2.24.so pointer at 0x55555575dfe8, value 0x7ffff7ba1b40 <_nl_default_dirname>
	Could not read from address 0x55555577e000, stopping.

Syntax: peek-pointers starting_address <object_name> <all>

I like it, but would you agree not to show the message:
Could not read from address XXXXX, stopping.

Because this looks a lot like an error message, and I already see people complaining about it 😄

Yes please go ahead :)

I rewrote quite a bit your script to use gef functions, let me know if I messed it up 😄

Looks good to me :)


✨ new seo preview card

PR Type

[x] Feature
[x] Refactoring

Context

[x] Closes #4143
[x] Move some readme to /tests
[x] change all card preview

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Had issue bounty label?

[x] Fill up your KSM address: Payout

Screenshot 📸

pay 50
I think it's much better than the current one from the previous stuff, so I guess this one is not perfect, but we will follow up with @exezbcz on it later for a much better v2 for neobrutalism

😍 Perfect, I’ve sent the payout
💵 $50 @ 25.84 USD/KSM ~ 1.935 $KSM
🧗 GemsyWUUtZU5HAiEQJqqgVz4YkekKXnmutYryBhbcVD4YW3
🔗 0xa78a2161f8a515815632f3fe6f175dc614f1ae830f535647ece4b0728ef95c0f
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


MWPW-147289 [Nala] Refine screenshot diff tool

MWPW-147289

Add IT s3 support, including upload, download and compare, clean base on aws s3 v3 SDK
will switch to public s3 later if need to run in github actions
redefine take APIs and move all from visualutil.js to take.js, with this, we can take full page or selector and take for one or two and compare them for diffs
build compare.mjs to compare local files or local vs s3 files
update tests according to new take APIs
add timestamp to show report time
clean take.js to only for taking screenshots, and move others into utils.js

Examples to run them(you need key and secret for s3):
for UAR:
node run.js -c visual -p chrome,ipad,iphone -g uar-screenshots
node libs/screenshot/merge.js screenshots/uar
node libs/screenshot/compare.mjs screenshots/milo
node libs/screenshot/uploads3.js screenshots/uar
for Milo:
node run.js -c visual -p chrome,ipad,iphone -g milo-screenshots
node libs/screenshot/merge.js screenshots/milo
node libs/screenshot/compare.mjs screenshots/milo
node libs/screenshot/uploads3.js screenshots/milo
for Feds:
node run.js -c visual -p chrome,ipad,iphone -g feds-screenshots
node libs/screenshot/merge.js screenshots/feds
node libs/screenshot/compare.mjs screenshots/feds
node libs/screenshot/uploads3.js screenshots/feds
for update base one, use below command to clean and run again, this is example for milo:
node libs/screenshot/cleans3.js milo screenshots/milo
Result website(Need VPN): http://nala-auto.corp.adobe.com/
Add sot screenshots:
http://nala-auto.corp.adobe.com/imagediff/sot
just add more links if you need in data/sot/sot-basic.yml

@JackySun9, I can see that the projects/test names are there on the tiles, the color of the text just needs to be a lighter color so it can be seen. Other than that everything is good.

ok, got it

I will merge this first for fast validating PRs, if any concern, we can handle later


Diablo Clone mod for d2rmm

Is there a Diablo Clone mod for d2rmm?
Something like selling 1 soj or some other item will spawn diablo clone?

This is not an issue related to code. For non-code related conversation, please use the Nexus, not GitHub.


It is better to auto fill the display name after pasting container URL on 'Connect to public blob container' dialog

Storage Explorer Version: 1.15.0-dev
Build: 20200717.1
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 18.04/ macOS Catalina
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one storage account -> Blob Containers.
Select one blob container which 'Public Read Access' is container.
Copy its URL -> Open connect dialog -> Select 'Connect to public blob container' -> Click 'Next'.
Paste the copied URL -> Check the display name is auto filled or not.

Expect Experience:
It would be better to auto fill the display name.
Actual Experience:
Need to manually input the display name.

Verified on build 20200812.2. This issue has been fixed. So close it.


Any plans on supporting Variable Sets?

Hello 👋
Is there any plan to support the concept of Variable Sets like TFE/TFC?
https://registry.terraform.io/providers/hashicorp/tfe/latest/docs/resources/variable_set
It would make handling multiple groups of variables across workspaces easier than using the or workspace variable resources as currently implemented, or having to use  organization variables which requires setting up multiple organizations?

Hello @bateller there is one open issue related to that; we need to implement it first
https://github.com/AzBuilder/terrakube/issues/1146

Thank you. Can't believe I missed it. 🤦


852 color widget

Fixes #852
A basic color widget - it's a version of my color-picker-widget reduced to just use the "chrome" picker, demo here (field 1&2). I could also include more or all color pickers, but I think it's nice to keep it simple as the standard color picker.
It uses react-color for the color picker and validate-color to validate the string for the color swatch and display a "?" if it's not a valid color string.

thanks @erezrokah ... much cleaner that way :)
I realised one little thing from my code I am not happy with. Clicks outside the color picker are handled by the fullscreen "ClickOutsideDiv" to close the color picker. That means if you opened the color picker and want to edit another field, you have to click twice, once for closing the picker, and then for the other field. That is not consistent with other widgets like "select" or "datetime", where you can click immediately from one field to another.
I guess it's quite easy, but I don't have the experience for a quick solution... Would you like to take care of that?

Would you like to take care of that?

Sure, how about opening a new issue for that so we can track it?

... and I think the widget has to be renamed, because netlify-cms-widget-color already exists ... My proposal: netlify-cms-widget-colorstring / ColorString

netlify-cms-widget-color

Damn, forgot about that. Thank you for reminding me.
There are a few already:
https://www.npmjs.com/search?q=netlify-cms-widget-color
so netlify-cms-widget-colorstring makes sense thank you

Would you like to take care of that?

Sure, how about opening a new issue for that so we can track it?

Ah, you merged already. Awesome :) ... ok, i open an issue


Enforce the source format URI-reference via the jsonschema

Changes
The format of the source field is defined as URI-reference https://github.com/cdevents/spec/blob/v0.1.1/spec.md#source-context
This is consistent with the CloudEvents specification. It reflects the fact that not every source will be an URL.
If later on, we decide on a more specific format, we can enforce it then.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has the primer doc been updated if a design decision is involved
[x] Have the JSON schemas been updated if the specification changed
[x] Has spec version and event versions been updated according to the versioning policy
[x] Meets the CDEvents contributor standards

I believe this PR should be seen as the solution to #114


Bump Dependencies #12162456864

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/12162456864

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


refactor and add docker login

It is better to put in Jenkinsfile as any password changes  in secret will take effect automatically.


Unknown error occurred - trying to authenticate integration [BUG]

Describe the bug
The integration had been running flawlessly for me, but had an error pop up with authentication, and as trouble shooting step I deleted the integration and then tried to set it up again. I can enter credentials, and it then sends the 2FA code, once I enter the 2FA code in and press submit, I get an unknown error occurred message
To Reproduce
Steps to reproduce the behaviour:

Go to 'Add Integration'
Click on 'Hive'
Enter Username and Password
Click Submit
Enter 2FA code sent to phone
Click Submit
Error Appears above 2FA textbox

Expected behaviour
Be able to log in and see devices/assign devices to areas.
Screenshots

Desktop (please complete the following information):

OS: macOS
Browser chrome
Version 102.0.5005.61

Additional context
Have tried uninstalling and reinstalling HACS custom component, refresh/rebooting server etc. Cleared Browser/Cache, and changed password to be something without any special characters to ensure nothing would be throwing hissy fit there.
Logs with error are below:
Traceback (most recent call last): File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request resp = await request_handler(request) File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 504, in _handle resp = await handler(request) File "/usr/local/lib/python3.9/site-packages/aiohttp/web_middlewares.py", line 117, in impl return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 79, in ban_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 220, in auth_middleware return await handler(request) File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 137, in handle result = await result File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 205, in post return await super().post(request, flow_id) File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 62, in wrapper result = await method(view, request, *args, **kwargs) File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 109, in post result = await self._flow_mgr.async_configure(flow_id, data) File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 260, in async_configure result = await self._async_handle_step( File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 335, in _async_handle_step result: FlowResult = await getattr(flow, method)(user_input) File "/usr/src/homeassistant/homeassistant/components/hive/config_flow.py", line 91, in async_step_2fa return await self.async_setup_hive_entry() File "/usr/src/homeassistant/homeassistant/components/hive/config_flow.py", line 106, in async_setup_hive_entry self.data["device_data"] = await self.hive_auth.getDeviceData() AttributeError: 'HiveAuthAsync' object has no attribute 'getDeviceData'
Any help would be appreciated!

@KJonline - This may be a duplicate issue of 70465 feel free to link/close if it is the case!

This is fixed in the latest version


New Databases have been added to the concordances we get from CantusIndex

This investigation was prompted by an email from Debra, which said:

I looked at a couple of instances of chants on gregorien.info that we also have in the Cantus Database, and one came up with concordance info below the chant details and the other didn't. Let me know if I should test this further or give you details.

I'm confused by this - I've looked at a couple of chants on Gregorien.info and checked them on CantusIndex, and I don't see them appear in the concordances on the site.
But, what I did notice was a couple of extra databases appearing in the Concordances Summary, including:

Austrian Mediaeval Monastic Music Manuscripts Database (https://austriamanus.org - its abbreviation in the main concordances is "A4M"
Melodiarium Hungariae Medii Aevi Digitale (http://melodiarium.zti.hu - its abbreviation in the main concordances is "MEL")
also, what used to be called "Slovak Early Music Database" (http://cantus.sk) now appears to be called "Cantus Planus in Slovacia" (I think "Slovacia" is an error - the main website uses both " Slovak Early Music Database" and "Cantus Planus in Slovakia". So maybe we use "Cantus Planus in Slovakia", in anticipation of CI fixing their typo?)

We need to update the concordances summary to include these new databases.

I'm working on this right now, and taking the opportunity to refactor how we handle concordances - things are quite nested currently!

Looking at chants on austiamanus, I can't find these chants included in concordances anywhere. I know I didn't hallucinate this when I opened the issue a few weeks ago, so I wonder whether this database has been removed... bonus points to anyone who can find a Cantus ID for which results from this database appear in the concordances on Cantus Index, so I can test this function...

So - chants from A4M and MEL no longer seem to appear in the concordances list, so I'm guessing that Jan implemented this change a month or two and then rolled it back within the past couple of weeks.
I'll open a PR that includes some refactoring of the concordances process, and updates the wording of "Cantus Planus in Slovakia", and leave the first two points from my initial post because they no longer seem to be needed. I'm going to mark this as "on hold" and close it; we can reopen it if/when they reappear in the concordances CantusIndex provides.


feat: add sort package-relation by desc

Summary
Add sort duplicate packages
Old:

New:

Related Links
#469

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@cairon666 thanks for your pr, please check the cla~


Farm's runtime module management

Farm's runtime module management

For discussions before, see: https://github.com/farm-fe/farm/issues/9

Summary
This RFC describes a runtime module management system to load, register and initialize modules in browsers and Node.js for Farm.
Motivation
Since modules need to be bundled when been distributed in browsers, modules from source code have to be merged into a limited number of chunks, besides, native module features are not available in all versions of browsers and Node.js, a emulated module system is required.

More details, please see RFC text.

We may need exta resourceId - resourceUrl map stored in global module system, because we can not use the resource url directly in the resource:

we can not get the content hash when render resource
the content hash changes when content changed, and the content of the dependent resource's content may also change, this is unexpected
if we want to support resource retry, the resourceUrl must be able to be changed programmatically

We may need exta resourceId - resourceUrl map stored in global module system, because we can not use the resource url directly in the resource:

we can not get the content hash when render resource
the content hash changes when content changed, and the content of the dependent resource's content may also change, this is unexpected
if we want to support resource retry, the resourceUrl must be able to be changed programmatically

For avoid inconsistency of resources' ID between different compilation, using first 6 or 8 characters of hash of source code of module as ID is better than numeric ID.
Resource url does need to be computed programmatically, I'll add this as well as how to override public path in runtime.

I am trying to implement a simple demo based on this RFC, to verify all our design work as expected


Additional keyword tests

@Julian as discussed in https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/253#issuecomment-473467955, I've added several tests for keywords. There are more tests for $ref and some other special cases that are not limited to ajv (I will make separate PRs).
What I meant by implementation specific tests, see these two for example:

https://github.com/epoberezkin/ajv/blob/master/spec/tests/rules/oneOf.json#L51
https://github.com/epoberezkin/ajv/blob/master/spec/tests/rules/uniqueItems.json

Ajv has performance optimisation that these tests invoke. They are not in this PR - I don't think they should be here, but let me know what you think.

That's a lot to review :D -- but thanks! Definitely looks super useful. Will see what I can get through.
And yeah I think the performance ones make sense not to include -- FWIW, in my validator what I do is just run performance tests over all the tests that are here, but it definitely sounds reasonable to have large examples to really exercise things -- would agree here is not the best place though (I have some of those, but yeah they are definitely separate from the suite).

OK, but not that bad given it's just the same tests for the 3 drafts more or less.
Cool, lgtm! Merging.

FWIW, in my validator what I do is just run performance tests over all the tests that are here, but it definitely sounds reasonable to have large examples to really exercise things -- would agree here is not the best place though (I have some of those, but yeah they are definitely separate from the suite).

What I mean is that validation code in my case would be different depending on the schema - e.g. uniqueItems is usually O(n2) time, but if items must have scalar types it would use hash with O(n) time... Anyway, I will only submit generic tests.

Wait, did this check in an entire dependency?

@awwright not a new dependency -- this just merged in some additional (edge case) tests that @epoberezkin had in his validator but not upstream. Make sense, or does something look off?

@Julian That makes sense!


Remove a line from Malaria_detection.ipynb

Type
Refactoring
Description
Malaria_detection.ipynb in Steps to solve the problem section we have following steps,
1. Loading the data.
2. Exploratory Data Analysis (EDA).
3. Data preprocessing.
4. Data augmentation.
5. Ploting images and its labels to understand how does an infected cell and uninfected cell looks like.
6. Spliting data in Train , Evaluation and Test set.
7. Creating a Convolution Neural Network function.
8. Wrapping it with Tensorflow Estimator function.
9. Training the data on Train data.
10. Evaluating on evaluation data.
11. Predicting on Test data
12. Ploting the predicted image and its respective True value and predicted value.

Step 5 which is Ploting images and its labels to understand how does an infected cell and uninfected cell looks like. should be removed since its EDA step and need to reorder the other steps after removal.
Tools

Markdown

Have you read the Contributing Guidelines on Pull Requests?
Ya
Motivation
To have better markdown for Notebook by writing more appropriate steps

Is this issue still requires any additions, or can be closed for now? @bhadreshpsavani

Hi @kahanikaar we can close it,
@BALaka-18 can you please close this issue and add points in the leaderboard for the participant


URL with trailing "/"

Current Behavior
"www.example.com/dashboard/mypage"  works but "www.example.com/dashboard/mypage/" does not work.
When nginx is used as a reverse proxy, it adds a trailing "/" , I imagine that the trailing "/" could be an issue with other configurations.
Expected Behavior
Ignore trailing "/".
Steps To Reproduce
No response
Environment

Dashboard version:  1.19.1
Node-RED version: 4.0.5: Maintenance Release Editor
Node.js version:
npm version:
Platform/OS: Linux
Browser: FireFox 132.0.2 (64-bit)

Have you provided an initial effort estimate for this issue?
I can not provide an initial effort estimate

You are right, even when accessing locally. The url
http://localhost:1880/dashboard/testpage
works but
http://localhost:1880/dashboard/testpage/
shows in the browser console:
Failed to load module script: Expected a JavaScript module script but the server responded with a MIME type of "text/html". Strict MIME type checking is enforced for module scripts per HTML spec.
manifest.webmanifest:1  Manifest: Line: 1, column: 1, Syntax error.

Hello,
I'm struggeling with the same problem.
I try to "hide" the /dashboard/page-path to my users by using a traefik middleware that adds the path-prefix.
But it seems to that the addprefix-middleware of traefik always adds a trailing slash.
There was a discussion about but i think they didn't fixed that
https://github.com/traefik/traefik/issues/5799
Using the stripprefix-middleware with "/" does nothing. Don't know how that should be handled.
Thanks!

Got same error today when using Dahsboard behind an nginx reverse proxy.
location / {
        proxy_pass http://<IP_ADDRESS>:1880/dashboard/;
        proxy_set_header Host <IP_ADDRESS>;
		proxy_http_version 1.1;
		proxy_set_header Upgrade $http_upgrade;
		proxy_set_header Connection $connection_upgrade;
		proxy_set_header X-Forwarded-Proto $scheme;
		proxy_set_header Referer "";
		proxy_set_header X-Real-IP $remote_addr;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_cache_bypass $http_upgrade;
}


totally broken on iOS; error: "false"

Hello,
I'm using this plugin with great success on Android, but cannot for the life of me get it to work for iOS.
I ultimately need this to work to invoke WhatsApp on an iPhone, but even when I follow the Twitter example from the documentation, I see the error function called with an error argument of "false".
var sApp = startApp.set("twitter://");
sApp.start(function() {
console.log("OK");
}, function(error) { /* fail */
alert(error);
});
This happens on iOS 10.3, tested on iPhone 5s and iPhone 6s.
Did this ever work this way for iOS? Is this the wrong way to do it? Or did something change in iOS?
Any help greatly appreciated!
Rik

hello  You must configure the LSApplicationQueriesSchemes and URL type properties for your app	 		var sApp = startApp.set("mopdev://"); 		sApp.start(function() { /* success */ 			console.log("OK"); 		}, function(error) { /* fail */ 			alert(error); 		});

@xdengxiaoning
Thank you for your help and the screenshots.
Using iOS 11, I tried to follow your instructions by putting in "whatsapp" at both the URL Types and the LSApplicationQueriesSchemes (via the [ProjectName]-Info.plist file), but to no avail.
var sApp = startApp.set("whatsapp://send?text="Hello");
sApp.start(....); // calls the error function passed in with an argument of "false".

sorry ! my English is poor.i can't formulation for more situation have . you can refer webstie https://code.tutsplus.com/tutorials/ios-sdk-working-with-url-schemes--mobile-6629.
The two application is configured with scheme in the application I've developed, and the plug-in test is completely successful.

Thanks for the pointer, @dengxiaoning!
@RikdeBoer I managed to get this working, just by setting LSApplicationQueriesSchemes as below:

I used this page as a reference, https://developer.apple.com/documentation/uikit/uiapplication/1622952-canopenurl?language=objc. Note the Important notice under Discussion.


Some legacy links are broken.

Some links used in stackoverflow or other forums are broken.
An example is:
http://api.dartlang.org/docs/releases/latest/intl/DateFormat.html

Sorry, but we won't fix this.


Merge master to develop

Description of the Change
merge master into develop

Reopen it after the CI be fixed.


[Snyk] Fix for 6 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `yarn` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

docs/package.json
docs/yarn.lock
docs/.snyk

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

509/1000  Why? Has a fix available, CVSS 5.9
User Interface (UI) Misrepresentation of Critical Information SNYK-JS-NEXT-2405694
No
No Known Exploit

539/1000  Why? Has a fix available, CVSS 6.5
Information Exposure SNYK-JS-NODEFETCH-2342118
No
No Known Exploit

520/1000  Why? Has a fix available, CVSS 5.9
Denial of Service SNYK-JS-NODEFETCH-674311
No
No Known Exploit

696/1000  Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS) SNYK-JS-TRIM-1017038
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
With a Snyk patch:

Severity
Priority Score (*)
Issue
Exploit Maturity

399/1000  Why? Has a fix available, CVSS 3.7
Regular Expression Denial of Service (ReDoS)  npm:debug:20170905
No Known Exploit

399/1000  Why? Has a fix available, CVSS 3.7
Regular Expression Denial of Service (ReDoS)  npm:ms:20170412
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Regular Expression Denial of Service (ReDoS)
🦉 More lessons are available in Snyk Learn

 Quality gate: NA
Details


Support LKSM and LDOT

LKSM (LKSM+taiKSM)
LKSM.zip
Preview

LDOT (LDOT+tDOT)
LDOT.zip
Preview

Display assets in space infomation
Dispay voting weight when hovering over the text

Figma link
Preview


open training and testing code

Hello @BunnySoCrazy
I am interested in your research.
could you please let me know when you are going to open your training and testing code?
Thank you.

Hello, wanted to check in and see if you've made progress on releasing. Looks like very interesting work!


--listen-prometheus is not in the right man section

e.g. datakit-github --help displays:
OPTIONS

 --listen-prometheus=VAL
           Port on which to provide Prometheus metrics over HTTP, of the form
           port or host:port

it should be in the LISTEN OPTIONS section.

I'll move it to its own "MONITORING" section. That way, it can be in the same place for all applications.


Create inheritance

Inheritance example using python
What the program do ?

In what programming language it is written?

This pull request do not contains files in specific folders. Please fix it and reopen


Update to new major version of elm-sha1

Hey,
I was able to do the work this morning. I've tried to split the commits up into as many logical parts as I can, but 11b90b8 is the main one.
I think it's made about a 20% performance increase, from rough testing.
The changes mean that there were a couple of unnecessary dependencies, and also that the type signatures of toHex and toBase64 changed (for the better, I think). I left those changes till the final commits.
As the changes to toHex and toBase64 mean a major version change anyway, I wanted to ask what you think about renaming toIntList? In the rewrite of elm-sha1, @folkertdev went for toByteValues, which I think is good — it describes what the List Int actually represents, so it gives it better meaning.

Man this is awesome!! I see a bunch of improvements, the code is clearer and less deps 👍
Yes, I think it makes more sense to rename that function
Thanks for this

Cool, glad it looks good 😄.
I also wondered if it makes sense adding the ability to make digests from Bytes? And if so, only the message, or the key too? If both, then it raises an interesting design question about how/whether to cater for all 4 combinations (String key + String message, Bytes key + String message, …).

Dropping the Result is exactly what I need. I even started to bug some people that wrote other Elm SHA1 packages to drop Result or Maybe so I can open a PR here as well. Great work @TSFoster! :)

@TSFoster sorry I've been busy
:thinking: though question. To make simpler this package we could leave it as it is. I mean, if someone has the key in bytes it can convert it to string representation? And viceversa. I don't have a lot of experience using hmac but what I've used is everything in string and not so many usages in bytes, being in ruby or JS. I think is not about all the options this package can provide but more about the usage is going to have with the users.
What do you think?

I mean, if someone has the key in bytes it can convert it to string representation?

There is something to consider about String vs. Bytes: not every string of bytes is a valid UTF8 string sequence. If this library wants to suit every use-case for hmac-sha1, having a way to use both key and message as raw-bytes seems necessary.

As custom types are Very Good and encouraged in Elm, I'd suggest exposing an opaque Key type, which could be made using HmacSha1.Key.from{String,Bytes} or HmacSha1.keyFrom{String,Bytes}.
You could do the same with a Message type, but I think it might be best to just have fromBytes : Key -> Bytes -> Digest and fromString : Key -> String -> Digest).
If you make a Key type, one thing to note is that = on Bytes does not work, so it would maybe be best for a Key to be defined as type Key = Key (List Int) as the non-exposed type currently is.

I think HmacSha1.Key.from{String,Bytes} is good. I also agree with fromBytes and fromString, I don't think having a Message module makes sense as we already have the difference in the function type annotation (String and Bytes)

Cool. How do you want to move forward with this? I'm happy to make the refactor and add it to this PR/a new one? Or do you want to do it?
In terms of implementation, I'd imagined something like:
module Internal.Key exposing (Key(..))

type Key = Key (List Int)

module HmacSha1.Key exposing (Key, fromString, fromBytes)

import Internal.Key as Key

type alias Key = Key.Key

That's how I've seen handling types that are opaque externally, but not internally

I would add the refactor on this PR.
And make just one opaque module HmacSha1.Key
module HmacSha1.Key exposing (Key, fromString, fromBytes)

type Key = Key (List Int)

WDYT?

HmacSha1 needs access to the List Int, so HmacSha1.Key would need to (publicly) expose a toByteValues function. By using something like Internal.Key (and not listing Internal.Key as an exposed module in elm.json), the Key data can be shared within the package, but not exposed publicly.
Does that make sense? I don't know how to write it clearly!

Ahh I see! Yes, it makes total sense. I need to learn more on package creation! haha. Thanks for the explanation and discussion

Cool, no problem. You want to do it, or me?

If you have time would be nice, I can do it this weekend if is not done

I've added the functionality using the API we discussed. Some work still needs to be done on the tests and the doc tests

@TSFoster very nice! I'll finish it up, thank you for this


version update 1.0.0 -> 0.23.4

Switching back to 0.23.4. We are experiencing some internal back-end issue with processing data marked as v1.0.0,.

:shipit:


V5 compliance

Packets which do not conform to the V5 specification are discarded
Packets not intended for the current PysolrmanV5 instance are dropped

As for the latter I had a case with two daemons, one connected 24/7 collecting data/metrics and one used for inverter programming started by a timer.service / cronjob. Initially it was a mess when they overlaps.
Credited @Dummy0815 for the idea as a co-author.

Multi-instance test example:
from pysolarmanv5 import PySolarmanV5
from time import sleep
import threading

sol = PySolarmanV5('<IP_ADDRESS>',<PHONE_NUMBER>, auto_reconnect=True, verbose=True)
sol2 = PySolarmanV5('<IP_ADDRESS>',<PHONE_NUMBER>, auto_reconnect=True, verbose=True)

def start_threads():
    thr.start()
    sleep(.05) # allows request consumption by the logger
    thr2.start()

def read_solarman(s, addr, length):
    print(f'Reading from {s}')
    res = s.read_holding_registers(addr, length)
    print(f'{s} {res}')

thr = threading.Thread(target=read_solarman, args=(sol, 60, 120), daemon=True)
thr2 = threading.Thread(target=read_solarman, args=(sol2, 60, 120), daemon=True)

start_threads()

Hi @githubDante, @dummy0815, @barfooos, @smurfy,
I intend to merge this later this week and release a new version.
@githubDante I see you've been working on a frame-reuse branch too. Is that something that you want to include in this PR?
Cheers,
Jon

Hi Jon,
The frame-reuse branch is intended to solve the issues reported by the users of the HA plugin, but yes, I think they can be combined here.

Pushed to main. Thanks all for your contributions.


Make client compatible with change to dockerclient api

The dockerclient api has been updated with a new mandatory parameter - I propose to just default to force=false
Added support for registry authentication

@wilstrup I was just reviewing this and see now that you closed it. Is this change no longer needed?

 My commit tried to apply the authentication to all registries. So I'm rethinking the solution.

ok, that's the same issue I ran up against . . . and why I punted on the authentication stuff for the initial release :smile:
There is already a file that the Docker CLI uses to store those creds (when you do a docker login). I was sort of thinking of trying to leverage that in some way, but didn't put much more thought into it than that.


SPLAT-820: graduate multi-zone API from tech preview

/hold

/cc @jcpowermac

/uncc @derekwaynecarr
/uncc @knobunc
uncc'ing folks to cut down on noise until we are ready for a review

/assign @jcpowermac
/assign @JoelSpeed
Performed an installation with no feature gates with a release image built from this PR and cluster-config-operator#277 and with installer#6782.  My concern about the way that I did this change was that I backed out the Default and TechPreviewNoUpgrade feature definitions from the infrastructure object altogether.  Let me know what you think about this approach but it didn't make sense to be to keep the definitions around since there weren't any tech preview specific changes any longer.
Confirmed that the infrastructure resource contained the topology provided by the installer.  Once this PR is merged, cluster-config-operator#277 will be updated to reference the this change.

API changes look good as far as I'm concerned, can we get some QE validation on this feature before we remove the TP gate? Do we want to get the CCMO changes in first and have those validated?

/hold

/hold cancel

/approve
Can we get QE to check this pre-merge as well? Which team is owning QE for this feature?

/approve
Can we get QE to check this pre-merge as well? Which team is owning QE for this feature?

Sure thing, I'll follow up on this.

@JoelSpeed @sgaoshang tested this https://issues.redhat.com/browse/SPLAT-865 it passed pre-merge testing.

/lgtm

/label docs-approved
/label px-approved
/label qe-approved


Closes #246 | Implement dataloader for Librivox-Indonesia

Closes #246
Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.
Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script nusantara/nusa_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _NUSANTARA_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one NusantaraConfig for the source schema and one for a nusantara schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py.
[x] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

/test dataset=librivox

It looks good. It needs some clean up of the doc and TODO string. It would be also nice to add the streaming functionality and to keep the dataset name "Librivox-Indonesia" as it is in the source dataset. Thanks.

Hello @cahya-wirawan, thank you for the reviews and comments.
I have updated the implementations accordingly.


Update self serve replication SQL to accept daily granularity as interval

Summary

This PR adds support for daily granularity as an valid input in the SQL API for the interval parameter as part of self serve replication.
Now the following SQL is valid and will not throw an exception:
ALTER TABLE db.testTable SET POLICY (REPLICATION=({destination:'a', interval:1D}))

where interval is supported to take daily and hourly inputs.
The validations for 'D' and 'H' inputs will continue to be performed at the server-side level to accept 12H and 1/2/3D inputs. The PR for that can be found here.
Changes

[x] Client-facing API Changes
[ ] Internal API Changes
[ ] Bug Fixes
[x] New Features
[ ] Performance Improvements
[ ] Code Style
[ ] Refactoring
[ ] Documentation
[ ] Tests

For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done

[x] Manually Tested on local docker setup. Please include commands ran, and their output.
[ ] Added new tests for the changes made.
[x] Updated existing tests to reflect the changes made.
[ ] No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
[ ] Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Updated unit tests for SQL statements and tested in local docker:
scala> spark.sql("ALTER TABLE u_tableowner.test SET POLICY (REPLICATION=({destination:'a', interval:1D}))")
res6: org.apache.spark.sql.DataFrame = []

scala> spark.sql("ALTER TABLE u_tableowner.test SET POLICY (REPLICATION=({destination:'a', interval:12H}))")
res8: org.apache.spark.sql.DataFrame = []

Using anything other than h/H or d/D throws an exception:
scala> spark.sql("ALTER TABLE u_tableowner.test SET POLICY (REPLICATION=({destination:'a', interval:1}))")
com.linkedin.openhouse.spark.sql.catalyst.parser.extensions.OpenhouseParseException: no viable alternative at input 'interval:1'; line 1 pos 82

scala> spark.sql("ALTER TABLE u_tableowner.test SET POLICY (REPLICATION=({destination:'a', interval:1Y}))")
com.linkedin.openhouse.spark.sql.catalyst.parser.extensions.OpenhouseParseException: no viable alternative at input 'interval:1Y'; line 1 pos 82
  at com.linkedin.openhouse.spark.sql.catalyst.parser.extensions.OpenhouseParseErrorListener$.syntaxError(OpenhouseSparkSqlExtensionsParser.scala:123)
  at org.antlr.v4.runtime.ProxyErrorListener.syntaxError(ProxyErrorListener.java:41)

Additional Information

[ ] Breaking Changes
[ ] Deprecations
[ ] Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

Thanks for adding the DAY granularity. Description looks incomplete, can you update? Also, can you add example case supporting this case: Using anything other than h/H or d/D throws an exception.?

@rohitkum2506 updated for both 👍


Display deck matches on site

J_meka wanted to know who he'd played against in his league run, and I needed to do a SQL query to find out.
We should either add it to /deck/, or make a /matches/<deck_id>/ page.

Dupe of #517


No correct valencies for iron triad and platinoids

Steps to Reproduce

Choose an element from the list: Fe, Co, Ni, Ru, Rh, Pd, Os, Ir, Pt.
Set any positive charge on it.
Or draw any structure with it, e.g. FeCl3.

Expected behavior
Stable charges and bonds quantity should be ok and shouldn't be marked red.
Actual behavior
All charge values and bonds quantity lead to bad valence error.
Screenshots

Desktop (please complete the following information):

OS: iOS
Browser: Google Chrome 96.0.4664.93, Safari 14.1.2.

the requested behavior actually describes a feature request to support metal-containing molecules. There is a question is me-covalent bond can exist and it is worth to use haptic bonds and/or other types. The Fe+ and Fe2+ seems to be incorrect though

cc: @Alena-Guznischeva


Allow to disable logging

Currently we log every incomming message, this massively polutes the logs and makes it hard to see the logs for devs

Chrome DevTools have really great filtering abilities. Do we really need that?

Chrome DevTools have really great filtering abilities. Do we really need that?

I could not get them filtered out. The logs from the sdk are info and from the same host ... so now my app logs all need to use warn or I need to add a filter with regex ... it is not user friendly. By default I would disable logs or allow to provide a custom logger.

I could not get them filtered out. The logs from the sdk are info and from the same host ... so now my app logs all need to use warn or I need to add a filter with regex ... it is not user friendly. By default I would disable logs or allow to provide a custom logger.


Support for multiple database types

This actually looks... obnoxiously complicated.

yeah it will be, since almost none of the existing code will work for other types :P

#286 might actually make this feasible.


Unable to clear transaction filters

I can't clear the filters on the transactions page. Clicking the X seems to not do anything.

The "clear" action has a confusing UX there, clicking it goes back to the default state - which is everything selected except host fee share. We can update that to unselect everything instead.

I will work on this one.

If we clear all selections we  will end up with no transactions on page, I don't think we want that.

My suggestion is we remove clear icon (the cross icon) because that doesn't make sense to give the user the ability to clear everything and then of course no transactions would show up. Rather my thinking is we should,

Remove the x icon so that user can select and deselect manually. 🤔
The user should not be able to clear everything. If they removed everything but except one transaction kind, then clicking on this final kind should not do anything. 🤔

cc: @Betree

The expectation when nothing is selected would be to have no filter (fetch all kinds).
But I like @SudharakaP's suggestion above, I think removing the x will simplify this.

The expectation when nothing is selected would be to have no filter (fetch all kinds).
But I like @SudharakaP's suggestion above, removing the x will simplify this.

That makes sense, just to make it a bit clearer then the fix should be,

Remove x
When user de-selects all the kind filters it should show everything (fetch all kinds).

@ersachin3112 : Thanks for taking the issue, let us know if you need any help on this. 😄

When user de-selects all the kind filters it should show everything (fetch all kinds).

Out of simplicity, I think we can skip this one and just remove the X as you suggested above.


REST endpoint giving error post extraction of zip to plugin folder

Hi Team,
We've extracted the zip file for 1.0.4 version and moved relevant files to plugin folder and restarted the web server but when tried to hit version GET call, it's showing below response, could you please help what could be the issue? Endpoint we're hitting is <base_url>/admin/rest_api/api?api=version

                       ____/ (  (    )   )  \___
                        /( (  (  )   _    ))  )   )\
                      ((     (   )(    )  )   (   )  )
                    ((/  ( _(   )   (   _) ) (  () )  )
                   ( (  ( (_)   ((    (   )  .((_ ) .  )_
                  ( (  )    (      (  )    )   ) . ) (   )
                 (  (   (  (   ) (  _  ( _) ).  ) . ) ) ( )
                 ( (  (   ) (  )   (  ))     ) _)(   )  )  )
                ( (  ( \ ) (    (_  ( ) ( )  )   ) )  )) ( )
                 (  (   (  (   (_ ( ) ( _    )  ) (  )  )   )
                ( (  ( (  (  )     (_  )  ) )  _)   ) _( ( )
                 ((  (   )(    (     _    )   _) _(_ (  (_ )
                  (_((__(_(__(( ( ( |  ) ) ) )_))__))_)___)
                  ((__)        \\||lll|l||///          \_))
                           (   /(/ (  )  ) )\   )
                         (    ( ( ( | | ) ) )\   )
                          (   /(| / ( )) ) ) )) )
                        (     ( ((((_(|)_)))))     )
                         (      ||\(|(|)|/||     )
                       (        |(||(||)||||        )
                         (     //|/l|||)|\\ \     )
                       (/ / //  /|//||||\\  \ \  \ _)
-------------------------------------------------------------------------------
Node: d706f4fa1e9b
-------------------------------------------------------------------------------
Traceback (most recent call last):
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app
   response = self.full_dispatch_request()
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
   rv = self.handle_user_exception(e)
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
   reraise(exc_type, exc_value, tb)
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
   rv = self.dispatch_request()
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request
   return self.view_functions[rule.endpoint](**req.view_args)
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask_admin/base.py", line 69, in inner
   return self._run_view(f, *args, **kwargs)
 File "/usr/src/venv/local/lib/python2.7/site-packages/flask_admin/base.py", line 368, in _run_view
   return fn(self, *args, **kwargs)
TypeError: secure_check() takes exactly 0 arguments (1 given)

Can you confirm what version of Airflow you're running?

It's v1.9

Dear @vardancse ,
Can you please confirm do you still have the issue? If so, can you please share a few details so that we can try to reproduce the issue.

Do you have any previous versions of the plugin installed?
Have you checked the Plugin logs to make sure the plugin was loaded successfully?
Which OS version and Python version are you using?
Any other relevant details that can help us to troubleshoot the issue.

4. other relevant details that can help us to troubleshoot the issue.

Will get back to you in sometime.


chore: investigate npm dependency issues

Doing a clean install for a new project from scratch by running npm i @astro-reactive/form, then checking the downloaded packages, I see that the installed versions are not the latest:
Our latest versions are<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>But the installed versions are<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Goal for this issue is to figure out how we can make sure users will get the latest versions? Maybe we need to update our docs' instructions?

I can give try on this

Thanks, @Preet-Sojitra! Let us know what you find!

cc @fazzaamiarso since you are also working on some release management task, maybe you have an idea? Let's work on this one together

Let me know if it will help if you also join the NPM organization

@ayoayco we can work together. Will investigate tomorrow.

@ayoayco for this issue, did you do the installation before #241 merged?
I've done the installation on fresh app today and get the latest version for all them.

@fazzaamiarso That's good to know! I did it after, but maybe I did it too soon and npm registry changes was not yet propagated. I will test again.

@ayoayco I also installed fresh app and checked the version. Versions of all the packages are up to Date as mentioned by @fazzaamiarso also.
So we can close this issue.

Alright! Confirmed as well. Let's take note of this, npm needs time to propagate versions before we can test manually. Thanks @fazzaamiarso @Preet-Sojitra 🙏


Add support for resource harbor_config_security

This PR adds support for the resource harbor_config_security which should fix the issue https://github.com/goharbor/terraform-provider-harbor/issues/223.
Please note that at the moment Harbor doesn't have any apis to remove the system-wide cve allow list.

thank you for your contribution, @naitmare01 do you have an idea how we can have an automated test setup?

We can probably write a test that performs all the supported operations on the list. E.g. update the list with strings of our choice. The textbox that stores all the cve-ids accept any strings really.