Error runtime error: index out of range when running query with huge result

Thanos, Prometheus and Golang version used

  build user:       circleci@9ff8295b71d0
  build date:       20180615-13:12:22
  go version:       go1.10.3

prometheus 2.3.0 official docker image is used
What happened
got error receive series: rpc error: code = Internal desc = runtime error: index out of range when running query with huge result(Total time series: 29367) or if i calculate huge number of timeseries on thanos web ui, and not all of result is returned, when i run the same not from thanos all ok. i have only one sidecar and one query without store or any other component configured, because for now i need only HA for prometheus servers. This error not always appear sometime is all ok.
What you expected to happen
i expect to see all metrics
How to reproduce it (as minimally and precisely as possible):
Not sure about it but if you have a lot of metrics generated and stored in prometheus i think toy will have this error too, because i tried different version with different options but no luck for now
Full logs to relevant components
here is sample of log from sidecar
level=error ts=2018-06-20T14:52:11.640568706Z caller=main.go:195 component=store msg="recovered from panic" panic="runtime error: index out of range" stack="goroutine 2260 [running]:\nruntime/debug.Stack(0xf06c20, 0xc4202c7e00, 0xf06c20)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\nmain.defaultGRPCServerOpts.func1(0xd1d8e0, 0x1434e60, 0xc42005e400, 0xb5f948)\n\t/go/src/github.com/improbable-eng/thanos/cmd/thanos/main.go:195 +0x84\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery.recoverFrom(0xd1d8e0, 0x1434e60, 0xc4203020f0, 0x3, 0xc42003c570)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery/interceptors.go:47 +0x43\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery.StreamServerInterceptor.func1.1(0xc4200b2b30, 0xc4435f19d0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery/interceptors.go:35 +0x63\npanic(0xd1d8e0, 0x1434e60)\n\t/usr/local/go/src/runtime/panic.go:502 +0x229\ngithub.com/improbable-eng/thanos/pkg/store.(*PrometheusStore).Series(0xc4202b0e60, 0xc4203b28c0, 0xf19e40, 0xc45fe894a0, 0x0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/pkg/store/prometheus.go:150 +0xb02\ngithub.com/improbable-eng/thanos/pkg/store/storepb._Store_Series_Handler(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45ff0ae20, 0xc42038a730, 0xc420424970)\n\t/go/src/github.com/improbable-eng/thanos/pkg/store/storepb/rpc.pb.go:404 +0x10e\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1.1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45ff0ae20, 0xf086a0, 0xc45fe89490)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:69 +0xe0\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery.StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45ff0ae20, 0xc45ff0ade0, 0xc4203b2820, 0x0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery/interceptors.go:39 +0x89\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1.1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45ff0ae20, 0xc4200d23c0, 0x14)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:72 +0x93\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing.StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45ff0ae20, 0xc45ff0ade0, 0xc4203b2820, 0xc45ff0ae00, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing/server_interceptors.go:46 +0x14c\ngithub.com/improbable-eng/thanos/pkg/tracing.StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18d00, 0xc45ff0ae00, 0xc45ff0ade0, 0xc4203b2820, 0xc4200d2301, 0xc45ff0ae00)\n\t/go/src/github.com/improbable-eng/thanos/pkg/tracing/grpc.go:35 +0x162\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1.1(0xdbea40, 0xc4202b0e60, 0xf18d00, 0xc45ff0ae00, 0x14, 0xc4203b2870)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:72 +0x93\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-prometheus.(*ServerMetrics).StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18fa0, 0xc42024c960, 0xc45ff0ade0, 0xc4203b2820, 0xc420424c40, 0x4108d8)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server_metrics.go:125 +0x12a\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1(0xdbea40, 0xc4202b0e60, 0xf18fa0, 0xc42024c960, 0xc45ff0ade0, 0xe8e960, 0xc4228f2330, 0xc4228f2330)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:75 +0x166\ngithub.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).processStreamingRPC(0xc4200c74a0, 0xf1a1a0, 0xc42040d800, 0xc420208c80, 0xc420302270, 0x1437ea0, 0x0, 0x0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:1060 +0x3bb\ngithub.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).handleStream(0xc4200c74a0, 0xf1a1a0, 0xc42040d800, 0xc420208c80, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:1147 +0x12b1\ngithub.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc420038180, 0xc4200c74a0, 0xf1a1a0, 0xc42040d800, 0xc420208c80)\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:638 +0x9f\ncreated by github.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).serveStreams.func1\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:636 +0xa1\n"
level=error ts=2018-06-20T14:53:39.73453544Z caller=main.go:195 component=store msg="recovered from panic" panic="runtime error: index out of range" stack="goroutine 2270 [running]:\nruntime/debug.Stack(0xf06c20, 0xc4202c7e00, 0xf06c20)\n\t/usr/local/go/src/runtime/debug/stack.go:24 +0xa7\nmain.defaultGRPCServerOpts.func1(0xd1d8e0, 0x1434e60, 0xc420314000, 0xb5f948)\n\t/go/src/github.com/improbable-eng/thanos/cmd/thanos/main.go:195 +0x84\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery.recoverFrom(0xd1d8e0, 0x1434e60, 0xc4203020f0, 0x3, 0xc42003a070)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery/interceptors.go:47 +0x43\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery.StreamServerInterceptor.func1.1(0xc4200b2b30, 0xc4201799d0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery/interceptors.go:35 +0x63\npanic(0xd1d8e0, 0x1434e60)\n\t/usr/local/go/src/runtime/panic.go:502 +0x229\ngithub.com/improbable-eng/thanos/pkg/store.(*PrometheusStore).Series(0xc4202b0e60, 0xc4203748c0, 0xf19e40, 0xc45e69d580, 0x0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/pkg/store/prometheus.go:150 +0xb02\ngithub.com/improbable-eng/thanos/pkg/store/storepb._Store_Series_Handler(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45c124e00, 0xc4203ca030, 0xc420357970)\n\t/go/src/github.com/improbable-eng/thanos/pkg/store/storepb/rpc.pb.go:404 +0x10e\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1.1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45c124e00, 0xf086a0, 0xc45e69d570)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:69 +0xe0\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery.StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45c124e00, 0xc45c124dc0, 0xc420374820, 0x0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/recovery/interceptors.go:39 +0x89\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1.1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45c124e00, 0xc4200d23c0, 0x14)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:72 +0x93\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing.StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18be0, 0xc45c124e00, 0xc45c124dc0, 0xc420374820, 0xc45c124de0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing/server_interceptors.go:46 +0x14c\ngithub.com/improbable-eng/thanos/pkg/tracing.StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18d00, 0xc45c124de0, 0xc45c124dc0, 0xc420374820, 0xc4200d2301, 0xc45c124de0)\n\t/go/src/github.com/improbable-eng/thanos/pkg/tracing/grpc.go:35 +0x162\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1.1(0xdbea40, 0xc4202b0e60, 0xf18d00, 0xc45c124de0, 0x14, 0xc420374870)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:72 +0x93\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-prometheus.(*ServerMetrics).StreamServerInterceptor.func1(0xdbea40, 0xc4202b0e60, 0xf18fa0, 0xc45f31eaa0, 0xc45c124dc0, 0xc420374820, 0xc420357c40, 0x4108d8)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-prometheus/server_metrics.go:125 +0x12a\ngithub.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware.ChainStreamServer.func1(0xdbea40, 0xc4202b0e60, 0xf18fa0, 0xc45f31eaa0, 0xc45c124dc0, 0xe8e960, 0xc45e6cab70, 0xc45e6cab70)\n\t/go/src/github.com/improbable-eng/thanos/vendor/github.com/grpc-ecosystem/go-grpc-middleware/chain.go:75 +0x166\ngithub.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).processStreamingRPC(0xc4200c74a0, 0xf1a1a0, 0xc42040d800, 0xc420209180, 0xc420302270, 0x1437ea0, 0x0, 0x0, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:1060 +0x3bb\ngithub.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).handleStream(0xc4200c74a0, 0xf1a1a0, 0xc42040d800, 0xc420209180, 0x0)\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:1147 +0x12b1\ngithub.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc420038180, 0xc4200c74a0, 0xf1a1a0, 0xc42040d800, 0xc420209180)\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:638 +0x9f\ncreated by github.com/improbable-eng/thanos/vendor/google.golang.org/grpc.(*Server).serveStreams.func1\n\t/go/src/github.com/improbable-eng/thanos/vendor/google.golang.org/grpc/server.go:636 +0xa1\n"

Anything else we need to know
here is my runtime flags for prometheus
      - '--config.file=/etc/prometheus/prometheus.yml'
      - '--storage.tsdb.path=/prometheus'
      - '--storage.tsdb.retention=31d'
      - '--web.enable-admin-api'
      - '--storage.tsdb.max-block-duration=2h'
      - '--storage.tsdb.min-block-duration=2h'
      - '--web.external-url=http://[ip]:9090/'

and here is runtime flags for sidecar
      - 'sidecar'
      - '--log.level=debug'
      - '--tsdb.path=/prometheus'
      - '--prometheus.url=http://localhost:9090'
      - '--cluster.peers=[external ip]:10900'
      - '--cluster.address=[external ip]:10900'
      - '--grpc-address=[external ip]:10901'
      - '--http-address=<IP_ADDRESS>:10902'

Environment:

OS ubuntu 16.04.03
Kernel (e.g. Linux dlukyanchikov-prom-dev-1 4.4.0-127-generic #153-Ubuntu SMP Sat May 19 10:58:46 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux):
Others:

Also i have a question do i need to make max-block-duration and min-block-duration the same and by 2h if i need only HA mode with sidecar near prometheus and query on other server ?

Today i notice that its not always a problem with huge query result sometimes error appear with small result too

Hello! Anyone have any idea?

@Bplotka

Asked on Prometheus-dev IRC channel if that behaviour is right, waiting on response.

For all the wandering around with that log message, from a discussion with @bwplotka in slack, it's clear that Thanos handles it gracefully and it doesn't lead to data corruption or any other negative effects.

But the root cause - is interesting (:

Hm, our sidecars logs are flooded with those messages even with the most recent versions of Prometheus and Thanos so the issue persists.
@bwplotka did you get any response on the IRC or any other place?


update model and contributor

We have updated the contributor list and details regarding the models.

Hello, there were a few errors with the validation checks:

Previously submitted model metadata files must not be removed.  'model-metadata/Stevens-GBR.yml' removed.
Metadata file contents must be consistent with schema specifications.  - /methods must not have more than 200 characters.


chore: jsonfmt managednetwork

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

Automation for azure-sdk-for-go


Pull in title from Sites framework

Adds a context processor so you can {{current_site.name.upper}} in templates:

Fixes #35


CORE-28595 - adding awaitSelector with some DOM utils

Adding a DOM polling utility named awaitSelector along with some DOM helpers.
Description
Personalization module requires DOM polling. IFRAME destinations also requires some logic around DOM polling to figure out when BODY tag is available. awaitSelector tries to cover both use cases.
Related Issue
NONE
Motivation and Context
awaitSelector abstracts away all the logic related to DOM polling. It provides a nice API that plays well with promises. Also it allows some customizations like:

how long to poll
which method to use for polling

How Has This Been Tested?
Unit tests have been added.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@wgamboa since I added some DOM helpers, could you please double check the destinations logic, to make sure I didn't mess it up.

@artur-ciocanu it looks like your changes to destinations make sense, but I used https://gist.github.com/wgamboa/024037380cd6ba4d61178e38266cb2db and I'm getting
alloy.js:962 Uncaught (in promise) TypeError: parent.appendChild is not a function
at appendNode (alloy.js:962)
at createPair (alloy.js:2088)
function createPair(body) {
var iframe = createNode(IFRAME_TAG, IFRAME_ATTRS);
return {
body: body,
iframe: appendNode(body, iframe)
};
}

@wgamboa good catch, I have fixed the issue.

Thanks for the changes @artur-ciocanu. I re-approve!

@wgamboa good catch, I have fixed the issue.

Thanks. I have confirmed the fix.


Burn fuses on Jetson TX2 32.2.1

Hi Everyone,
I trying to burn fuses for the second time (new SBK and new RSA key). Unfortunately I did not succeed
For you information, I already applied the patch fix-uid-check-in-odmfuse.patch.txt provided by Matt Madison
Please see the command line and the traces below:
Command
$ sudo BOARDID=3310 FAB=C04 ./odmfuse.sh -j -i 0x18 -c PKC -k ./my_priv.pem -S ./my_sbk.key jetson-tx2

Traces
Welcome to Tegra Flash
version 1.0.0
Type ? or help for help and q or quit to exit
Use ! to execute system commands

[   0.0032 ] Generating RCM messages
[   0.0040 ] tegrarcm_v2 --listrcm rcm_list.xml --chip 0x18 0 --download rcm /home/ilies/secureboot/mb1_recovery_prod.bin 0 0
[   0.0046 ] RCM 0 is saved as rcm_0.rcm
[   0.0050 ] RCM 1 is saved as rcm_1.rcm
[   0.0050 ] List of rcm files are saved in rcm_list.xml
[   0.0050 ]
[   0.0050 ] Signing RCM messages
[   0.0056 ] tegrasign_v2 --key None --list rcm_list.xml --pubkeyhash pub_key.key
[   0.0062 ] Assuming zero filled SBK key
[   0.0087 ]
[   0.0087 ] Copying signature to RCM mesages
[   0.0095 ] tegrarcm_v2 --chip 0x18 0 --updatesig rcm_list_signed.xml
[   0.0104 ]
[   0.0104 ] Boot Rom communication
[   0.0110 ] tegrarcm_v2 --chip 0x18 0 --rcm rcm_list_signed.xml --skipuid
[   0.0117 ] RCM version 0X13
[   0.3470 ] Boot Rom communication failed
[   5.5740 ]
Error: Return value 3
Command tegrarcm_v2 --chip 0x18 0 --rcm rcm_list_signed.xml --skipuid
Reading board information failed.

Have you guys an idea about the problem with Boot Room communication ?
Best regards,
Ilies

Hi @madisongh
Not yet, still working on that
I'm waiting for the new JetPack 4.4 to do more tests
Please refer to the following link: https://devtalk.nvidia.com/default/topic/1064080/jetson-tx2/secure-boot-odmfuse-programming-step-fail-on-32-2-1/post/5425881/#5425881

Thanks for the pointer.  Since it doesn't look like there's a specific issue with the meta-tegra layer here, I'm going to close this.


Editing: bottom of long issue comment hidden by keyboard

Editing: bottom of long issue comment is hidden by keyboard
Screen

Video
https://imgur.com/a/5bVqVxH

Bug Report Dump (Auto-generated)

Version 1.28.0<PHONE_NUMBER>)
Device: iPhone 6s (iOS 12.3.1)
TestFlight: true

I've found two additional issues with this:

Opening the long text, then toggling the predictive option in the stock keyboard, causes the height to be miscalculated like above. (iPhone 7, iOS 12.2, v. 1.27.2)
Opening the long text outright causes it to be clipped below the textActionsController, with no predictive option enabled beforehand. (iPhone XR, iOS 13, v. 1.28.0)

In your case though, it looks like the height of the entire keyboard isn't being sent properly. In the ScrollViewKeyboardAdjuster, it relies on iOS to send the keyboard frame over, so maybe there's an issue with how it handles third party keyboards?

Is this a dupe then?
Sent with GitHawk

Is this a dupe then?

what makes you say this?


No answer to ICMP Echo requests when using PPP

If NetX uses PPP as network interface, it does not respond to ICMP Echo requests sent from network.
In fact, ICMP Echo requests are received by stack and processed (in _nx_icmpv4_process_echo_request function), but when responses are passed down to PPP stack, _nx_ppp_process_deferred_ip_packet_send function ends up with error when checking for available space for IPCP header, right here:
`        /* Determine if there is room in the front of the packet for the PPP header.  */
if ((packet_ptr -> nx_packet_prepend_ptr - packet_ptr -> nx_packet_data_start) < 2)
{
        /* Error, there is no room at the front of the packet to prepend the PPP header.  */

#ifndef NX_PPP_DISABLE_INFO
        /* Increment the internal error counter.  */
        ppp_ptr -> nx_ppp_internal_errors++;

#endif
        /* Release the NetX packet.  */
        nx_packet_transmit_release(packet_ptr);

        /* An error was detected, simply return a NULL pointer.  */
        return;
    }

`
It seems that higher level functions don't provide needed room for header, hence packet is dropped.
Other than that, PPP interface works OK (at least with UDP traffic).

Hi @marcin-de, interesting, there should be four bytes available for ppp (IPCP header is two bytes), could you debug the code as below? let me know what you find. Thanks.

Set breakpoint here  in _nx_icmpv4_process_echo_request(), then watch
packet_ptr->nx_packet_prepend_ptr and packet_ptr->nx_packet_data_start, check if the value of (packet_ptr->nx_packet_prepend_ptr - packet_ptr->nx_packet_data_start) is 24,

Set breakpoint here in nx_ip_packet_send() to check the logic of adding IP header (20 bytes), watch the same variables and check if the value of (packet_ptr->nx_packet_prepend_ptr - packet_ptr->nx_packet_data_start) is 4,

After adding IP header and before adding IPCP header, no data need to be added into packet, set breakpoint here to check if the value (packet_ptr->nx_packet_prepend_ptr - packet_ptr->nx_packet_data_start) is changed.

Hello, @bo-ms
Regarding above checks:

Difference between packet_ptr->nx_packet_prepend_ptr and packet_ptr->nx_packet_data_start is 20 bytes, not expected 24 bytes.
Difference here is zero bytes
Again, difference here is zero bytes.

Hi @marcin-de Before IP header, there should be five bytes: three bytes (0x7e, 0xff, 0x03) for HDLC, and two bytes for (0x00, 0x21) for IPCP protocol, then move one byte to keep four bytes alignment before calling IP receive, could you set breakpoint to check it and share your data between data_start pointer and prepend_ptr pointer? Thanks.

Hi @bo-ms,
In my case, things look like this:

So there are only three bytes before IP header. Why?
This brings us to another "issue" with PPP stack: if during PPP connection setup remote peer requests LCP option 0x08 (Address-and-Control-Field-Compression), local stack accepts it - but later, when remote peer sends IPCP/IP packets with "compressed" fields (i.e. 0xFF and 0x03 bytes are not present), local stack still assumes that these bytes are present(!) and tries to remove them (it is done here ). This, of course, leads to "misalignment" in payload of IPCP packets and consequently to inability to set up PPP session. This was my first problem with PPP stack - and I solved it by replacing above code with this:
`
        if ((packet_head_ptr -> nx_packet_prepend_ptr[0] == 0x7e) &&
        	(packet_head_ptr -> nx_packet_prepend_ptr[1] == 0xff) &&
            (packet_head_ptr -> nx_packet_prepend_ptr[2] == 0x03)
		) {																	// ** Full HDLC header present - remove
			packet_head_ptr -> nx_packet_prepend_ptr += 3;
			packet_head_ptr -> nx_packet_length -= 3;
        } else {															// ** header not present (IPCP with compression?) - remove only start flag
			packet_head_ptr -> nx_packet_prepend_ptr += 1;
			packet_head_ptr -> nx_packet_length -= 1;
        }

`
This brought PPP stack to work - it can negotiate the connection, gets IP address and IP stack is able to use the connection (UDP communication works OK). However, it seems that there are other places in PPP stack where assumption is made that received PPP frame always begins with 0x7E 0xFF 0x03...

Hi @marcin-de you are right, the Address and Control fields may be compressed, we will fix this issue in next release, you are able to fix it locally for testing, thanks for reporting this issue.

Hi @bo-ms
Thanks for feedback.
However...
As I  dig deeper into PPP specification, I'm getting the feeling that it is not an issue with PPP stack, but with modem itself...
Below is dump of PPP frames during establishment of connection. Lines with "<" show data from CPU to modem, lines with ">" - from modem to CPU.
<7EFF03 C021 01 2C 0008 010405DC 9D8C7E
<7EFF03 C021 01 2D 0008 010405DC 48137E
>7EFF03 C021 01 01 0018<PHONE_NUMBER>00 0304C023 050654FD4A65 0702 0802 A9067E
<7EFF03 C021 04 01 0008 0304C023 2CD47E
>7EFF03 C021 02 2D 0008 010405DC 98997E
>7EFF03 C021 01 02 0014<PHONE_NUMBER>00 05061121D847 0702 0802 111F7E
<7EFF03 C021 02 02 0014<PHONE_NUMBER>00 05061121D847 0702 0802 FA767E
<7EFF03 8021 01 2E 0016<PHONE_NUMBER>00<PHONE_NUMBER>00<PHONE_NUMBER>00 FD317E
>7E 8021 01 03 0004 032C7E
<7EFF03 8021 02 03 0004 75277E
>7E 8021 03 2E 0016 03060A0A2409<PHONE_NUMBER>00<PHONE_NUMBER>00 26007E
<7EFF03 8021 01 2F 0016 03060A0A2409<PHONE_NUMBER>00<PHONE_NUMBER>00 81FD7E
>7E 8021 02 2F 0016 03060A0A2409<PHONE_NUMBER>00<PHONE_NUMBER>00 179E7E

Third line is ConfReq from modem to stack with LCP option 0x08 present. Then stack rejects option 0x03 (auth protocol), so in line six modem resends ConfReq without rejected option and in line seven stack acknowledges rest of options (including 0x08). But, according to RFC, this means that Address and Control Field Compression may be used in direction from stack to modem, not the opposite - but instead modem starts to use compression(!?), which leads to "issues" in PPP stack. And stack itself still sends frames with full header (even if it knows that it can be omitted - but it does not matter). Furthermore, stack never requests LCP 0x08, so modem should not use the compression, in which case everything shall work as expected... Please consider if this is the case.

Quick followup.
If I remove LCP option 0x08 from "known options list" here, so during parsing it falls to default and gets rejected, then modem sends IPCP/IP frames with full header and all, including ping, works as expected...

Hi @marcin-de Thanks for the update. From the spec below. This Configuration Option (ACFC) is sent to inform the peer that the implementation can receive compressed Address and Control fields. If our PPP client (CPU) did not send this option to modem, the modem should not send compressed data to PPP client (CPU).
6.6.  Address-and-Control-Field-Compression (ACFC)
Description
  This Configuration Option provides a method to negotiate the
  compression of the Data Link Layer Address and Control fields.  By
  default, all implementations MUST transmit frames with Address and
  Control fields appropriate to the link framing.

  Since these fields usually have constant values for point-to-point
  links, they are easily compressed.  This Configuration Option is
  sent to inform the peer that the implementation can receive
  compressed Address and Control fields.

  If a compressed frame is received when Address-and-Control-Field-
  Compression has not been negotiated, the implementation MAY
  silently discard the frame.

  The Address and Control fields MUST NOT be compressed when sending
  any LCP packet.  This rule guarantees unambiguous recognition of
  LCP packets.

  When the Address and Control fields are compressed, the Data Link
  Layer FCS field is calculated on the compressed frame, not the
  original uncompressed frame.

Yes, exactly, it looks like an issue with modem's firmware, not the PPP stack in NetX.
I will report this to modem's manufacturer (Simcom), and you can close this issue.
Thanks for support!

closing, @marcin-de feel free to reopen it if you have any issue after discussion with Simcom.


bump jupyter

Includes fix of a recent breaking bug: https://github.com/non-Jedi/emacs-jupyter/commit/5c2469dbe40a3ee82537ecb549ee0b05ef35e194

Thanks!


Update CHANGELOG format and parsing

Renamed test-CHANGLOG/ to bin/

@JakeQuilty let's please move the parse_a_changelog script into the root folder or the bin folder. The test-CHANGELOG isn't so clear and it looks like the folder prefix is being used for test data.


PR Template update

Can you explain what this update entails?

Yep! Make examples visible only when editing.


🐞 Fix About Section Footer: Align Social Media Icons and Remove Repeated Message

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The About section footer currently displays social media icons that are misaligned, making it look unprofessional. Additionally, the message "Stay connected with us" is repeated twice, leading to redundancy and confusion for users.
Expected behavior
The About section footer should display the social media icons in a single line and feature the "Stay connected with us" message only once.
Add ScreenShots

What browsers are you seeing the problem on?
Chrome
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

please assign me i can make ooter look fabulous

hey ! i want to contribute in this project .i can build this has soon has possible


No output given

https://user-images.githubusercontent.com/35371691/129884066-739f634f-ea11-434b-a19a-01644a0f223a.mp4
Hello ,
the tool doesn't provide any output when using it
although all the libraries/requirements installed and everything is alright (and python3 used)
What am I missing and thanks in advance

use dnsgen -


[BUG] Window Appears Off Screen if Second Monitor DCs

If I open the app, move the app to a second screen, close the app, disconnect my monitor from the laptop, and then reopen the app, the app opens off screen.
The window should be opened as default if the last position is considered off screen.
Thanks.

try with fallback-to-primary branch

Buggier.
When the window (not fullscreened) is on the primary monitor, it will always open in the top left corner.
If the window is closed in the second monitor and reopened, it reopens in the second monitor fine.
If the window is closed in the second monitor and reopened when there is no second monitor, it opens off screen.

can you try again with the latest commit

Works perfecting thanks

Actually I think there's a regression. When the second screen is the primary display (I switched up the display port cables when I replugged the cables) and I resize the app on the second display (first screen), the resize is only respected on the primary display and not the extended/second. I'll try reproducing from my laptop tomorrow, but here is the app.
https://github.com/elibroftw/google-keep-desktop-app

Okay so what I figured out is that if you close the app in monitor A and you open the app from the taskbar in monitor B, the app shows up in monitor A without being resized @amrbashir


Add ability to hide cmd window.

On windows when you run opn it opens a new .cmd every time you call it. It would be really nice if there was an option to hide those.

Happy to receive a pull request, but I personally have no idea whether that's possible or how.

...I personally have no idea whether that's possible or how.

This is an old request, but I ran into it myself.
On win32, you are running:
cmd /c start [app] [args]
You need to run:
cmd /c start /B [app] [args]
If you want to make the shell hidden. Curious, why on win32 do you push '""' after start?

To answer your question @ddantzler I'm guessing that the "" is intended to the be title parameter.
I tried looking into this just now, as when I try to launch VS Code using this utility a command prompt window is opened every time on Windows.
After attempting to add in the /b parameter to the start command, I wasn't able to resolve this issue for me. It appears that for most of the cases however, the /c parameter currently being used on cmd terminates the command prompt windows that results, but not in this specific case (no idea why yet, but likely has something to do with VS Code being an electron app).
In summary, I think the existing code covers most use cases and /b doesn't appear to fix my use case so I have not made the update. You can check and see if it will fix yours by going to start -> run and entering cmd /c start "" /b [command/file] where [command/file] is what you'd be opening with opn.

Interesting, what version of Windows are you on? I am in an environment running Windows 7. Same use case for me, desiring to launch VS Code and/or Atom. The /b flag is working for me, so for now I am using my own fork.
Before implementing, I tested using the exact method you described.
cmd /c start /b notepad
https://technet.microsoft.com/en-us/library/cc770297(v=ws.11).aspx

I wonder why the combination of cmd and start?

I mean to say why does opn use both? Additionally in my testing, even running notepad without /b results in a leftover shell, eliminating electron. It’s the combination of cmd with start that makes the /c basically non-effective.

@ddantzler Windows 10 v.1607. You can see how I'm testing the command in the gif below.
It appears not to matter however if I use /b or not, nor if I omit start. Same net result.

Upon further investigation, the issue appears to be that code is actually the alias for bin\code.cmd and appears to do some trickery related to the fact that it is intended to be used in the command line. Launching the exe instead (tested using the full path) seems to work fine as does using VS Code's custom URL scheme.
For my intents and purposes I am going with using the URL handling mechanism so that I may cover Mac and Windows.

Great find!! 👍
I’ll switch to the url mechanism too.
Deron
Sent from my iPhone

On Aug 17, 2017, at 6:48 PM, William Dibbern<EMAIL_ADDRESS>wrote:
Upon further investigation, the issue appears to be that code is actually the alias for bin\code.cmd and appears to do some trickery related to the fact that it is intended to be used in the command line. Launching the exe instead (tested using the full path) seems to work fine as does using VS Code's custom URL scheme.
For my intents and purposes I am going with using the URL handling mechanism so that I may cover Mac and Windows.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

The b flag was added by default in https://github.com/sindresorhus/opn/commit/eb99a736e8b277f16277765aae5241a67962782c so I think we can consider this fixed.


[Android] Configuration with name 'default' not found.

I followed the steps to install it, but when I run react-native run-android I get the following error message:
FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring project ':app'.
> Cannot evaluate module react-native-zip : Configuration with name 'default' not found.

Any suggestions?

I got this problem too.Have u solved this problem?

I got this problem too.Have u solved this problem?

I solved it.The solution is the setting.gradle.
change
project(':react-native-zip').projectDir = new File(settingsDir, '../node_modules/@remobile/react-native-zip/android/RCTZip')
to
../node_modules/@remobile/react-native-zip/android

@chenchongyu  you meet this problem
Error:(25, 0) Project with path ':react-native-cordova' could not be found in project ':react-native-zip'.

I add  compile project(':react-native-cordova') report above error

@amibition521  U need include ':react-native-zip'


Sentry via Monolog

Anyone already figured out how to use Monolog's Sentry support with Slim3?
According to their documentation it should be quite simple, but when requiring Sentry via composer, it still does not find the "Raven_Client" class as expected.

did you try $client = new \Raven_Client(...); ?

You're right, this worked out!


reporter: mark! can optionally take an additional value

Wait, there is a problem on this one...

OK, it works now.


Can't import Pretrained Models

Hello,
I am trying to load a pre-trained model from the NVIDIA model store. From the DIGITS home page, I clicked on "Pretrained Models", then "Load Model" > "Images" > "Retrieve from Model Store" and I tried to download the googlenet pre-trained model.
However, something goes wrong and I am always facing the same issue. The terminal where I started the server (./digits-devserver) is saying :
[ERROR] OSError: [Errno 1] Operation not permitted: '/my_path/digits/digits/jobs/20170420-143919-1205/model.caffemodel'
Is anyone have an idea ?

Hey Drez13,
Did you found out the reason for it? I'm having the same issue here.

Hello MoritzDPTV,
I am not working anymore with Caffe and I finally didn't use "Pretrained Models" for my work. However, this issue might be coming from the path you are using. Make sure that your repository where your model.caffemodel is can be accessible by any user. Also try to launch your command as root.
Drez

Hey Drez,
Thank you for your answer! I guess you're right and it's about the path as I'm saving the jobs on another drive. But to be honest I don't need this function neither right now, I just saw that it didn't work and thought about fixing it in case I need it sometime. But for now I'll leave it as it is.
Cherrs,
Moritz


fix(artwork alerts): update copy for CTA

The type of this PR is: Bugfix
This PR solves FX-3908
Description
Tiny change to artwork alerts CTA (similar piece → similar work), in order to be more consistent with Artsy's copyediting standards.

Ah thanks!


train script missing

Dear @hehefan ,
Please upload the training scripts (as it contains all the training parameters along with network design parameters).
Thanks in advance

Hi,
This project is an extension to PSTNet. Please refer to PSTNet for the training scripts.
Best regards.

Hi,
I have used that and got only 87.45% accuracy.
Can you please suggest how to enable Spatio-temporal hierarchy (hier) and Spatio-temporal decomposition (decom)?
Thanks and Regards,
Shivanand

Hi,
Hierarchy and decomposition are default.  Could you please check whether the environment is aligned with the proposed?
Best.

Hi,
I am on a workstation Ubuntu 20.04, CUDA 11.6, GCC 9.4, Torch 1.11.0 (successfully compiled code in modules 1.8 folders), and cuDNN 8.
However, I used the same environment and was able to recreate the results of the P4Transformer and PSTNet.
Thanks

Hi,
I will try to set up the same environment as you provided and reproduce the problem.
Best.

Hi,
I got 90.59% on PSTNet2 with clip-len = 24.
Still less than the reported accuracy in the paper.
Please help us recreate the results.
Thanks


ci-pipeline task build-sign-artifact fails

Post stack deployment, ran ci-pipeline. Failed with the following error:
Error1
Registry namespace rag-sample-appsample not found
Adding namespace 'rag-sample-appsample' in resource group 'Default' for account geretain-shikha-think in registry us.icr.io...

FAILED
The requested namespace is already in use in registry 'us.icr.io'.
Choose a different namespace.

 === Execution of custom script for stage 'containerize' finished. Exit Code: '1'. ===

Re-ran pipeline with different namespace name. This time pipeline progressed further and all stages are passed except one build-sign-artifact. Error is:
Error2
Using the following defaults for stage "sign-artifact":

sign-artifact:
  image: icr.io/continuous-delivery/pipeline/image-signing:1.0.0@sha256:e9d8e354668ba3d40be2aaee08298d2aa7f0e1c8a1829cca4094ec93830e3e6a
  dind: false
  abort_on_failure: false
  image_pull_policy: IfNotPresent
  skip: false
  runAfter: null
  script: |
    #!/bin/sh

    "/opt/commons/sign-artifact/sign_image.sh"

cat: /config/break_glass: No such file or directory
Proceeding with self signing....
CentOS Linux 8 - AppStream                      114  B/s |  38  B     00:00
Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist
base64: invalid input
Base64 Conversion is successful....
gpg: keybox '/root/.gnupg/pubring.kbx' created
gpg: Total number processed: 0
GPG key import is successfull.
gpg: /root/.gnupg/trustdb.gpg: trustdb created
No key found. Unable to sign

Error 1 is because of not using unique prefix. Do we need to document it somewhere?

@maheshwarishikha In https://github.com/terraform-ibm-modules/stack-retrieval-augmented-generation/pull/93 the default prefix value was removed which should prevent Error 1

signing_key was not provided, hence this error.


Maven Repo

I'm looking into using the MinestomPvP API in my server but can't seem to find a Maven/Gradle repository to do so. What's the recommended way to hook into the API?

I seem to have found the maven repository on jitpack at Bloepiloepi/MinestomPvP
I think it should be listed in the README


[Bug] [UI] table tooltip overflow page view

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

What you expected to happen
keep in page view and word-wrap
How to reproduce
if table column render text to long, tooltip will overflow page view
Anything else
No response
Version
3.0.0
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

it's  seems is the naive-ui bug ,https://github.com/tusen-ai/naive-ui/issues/3766，if want quickly to fixed,  in the global style set  Ellipsis components style max-width. @Amy0104 Do you agree with this method？

answer  likes great， how much width is standard？


AttributeError: 'DiGraph' object has no attribute 'node'

solution explained here,
https://stackoverflow.com/questions/49016596/networkx-digraph-attribute-error-self-succ/49016885#49016885

See https://github.com/victorlei/smop/issues/153.

!pip install networkx==2.0.0 solved my problem. In fact, version <2.4.0 solve the issue so far. On the other hand, if you want to keep latest version of networkx, then just change "node" to "nodes".

I suggest to close it as duplicating #165


Bloggers: Devise

Heyyyy......

In this pull request I and my coding partner:

[x] Removed current_user method in ApplicationController.
[x] Installed and set up devise.
[x] Enable the app to register a new user.
[x] Make the user log in with a combination of email and password.
[x] Store Hashed password in the database.
[x] Make the app ask for confirmation of email.
[x] Enable the user to reset password.
[x] Modifed the views in devise for registration and login to match the wireframes from the Sneak Peek.

Cheers and happy coding!🥂

@Davidosky007, Thank you so much!


[NO-TASK] New Payment Links endpoint signatures

[ ] Await package merge and update package versions


Using mocha programmatically - mocha/lib/runner.js - getting expected and actual results

https://github.com/mochajs/mocha/blob/8cae7a34f0b6eafeb16567beb8852b827cc5956b/lib/runner.js#L47-L57
So in mocha.run().on(eventName, handler), I can listen to many types of events, such as test end, end and so on.
I was wondering if there was a way to emit my own custom event from the mocha test JS.
For example, I want to know about which assertions took place, the values of each assertion (the expected and actual values).
Thank you.

For example, I want to know about which assertions took place, the values of each assertion (the expected and actual values).

The fail event should be provided the test and the error (e.g. assertion failure) as parameters; assertion failure errors are typically populated with the expected and actual properties (although I think that's up to the assertion library). Let me know if that works for you!
As to the more general question: to my knowledge, custom events might be possible in the sense that you could take the runner and emit instead of on in order to communicate to whatever else is listening on that runner, but I don't know of a way to get ahold of this for custom events from within the test run logic instead of from whatever is using the runner, and presumably if you had the information there you probably wouldn't need to emit it as an event... That being said, it's hard to be sure because I haven't dug around too much in the event messaging code -- it's pretty hairy down there and what can or cannot be done isn't always as straightforward as it seems.

Thanks, and is it possible to get the test duration when the test fails?


Needs a readme

This module needs a readme.md file that at least links to documentation elsewhere if not giving some simple usage examples itself.

README is under docs folder. The documentation is generated from there and is available in docs.mbed.com

ARM Internal Ref: IOTCLT-425

There is now a README at github which re-directs to the official mbed-client documentation site. We will be updating more information on this in coming releases.


⚠ Auth has degraded performance

In 124590e, Auth (https://auth.k2lin.com) experienced degraded performance:

HTTP code: 200
Response time: 17656 ms

Resolved: Auth performance has improved in 55600ad.


[zh] sync pod-failure-policy.md

It's duplicated with PR #36765.

#36765

It's duplicated with PR #36765.

[zh-cn]Sync PodDisruptionsCondition to PodDisruptionConditions #36765

I also changed the translation of line 249. I think the original is not very correct. What do you think?

It's duplicated with PR #36765.

[zh-cn]Sync PodDisruptionsCondition to PodDisruptionConditions #36765

I removed the duplicate changes with that PR.


tests for $ref using base URI learned from $id

Oddly enough, the "local" version worked fine with my implementation, while the "remote" version broke it.
This is my first time adding a remote case. I tried to amend the right places in the scripts, but I may have missed some spots.
I put the same tests in draft7 and 2019-09.

Oops! I just remembered that "$defs" is only in 2019-09. For the remote file, should I make that test 2019-09 only?

For cross-checking, the errors returned by the new ref.json tests for my implementation are:
{
  "errors" : [
    {
      "absoluteKeywordLocation" : "/referencing.json#/$defs/referenced/enum",
      "error" : "value does not match",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf/0/$ref/enum"
    },
    {
      "absoluteKeywordLocation" : "/referencing.json#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf"
    },
    {
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf"
    }
  ],
  "valid" : false
}

{
  "errors" : [
    {
      "absoluteKeywordLocation" : "/referencing.json#/$defs/referenced/enum",
      "error" : "value does not match",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf/0/$ref/enum"
    },
    {
      "absoluteKeywordLocation" : "/referencing.json#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf"
    },
    {
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf"
    }
  ],
  "valid" : false
}

{
  "valid": true
}

and the new refRemote.json tests:
{
  "errors" : [
    {
      "absoluteKeywordLocation" : "http://localhost:1234/referencing.json#/$defs/referenced/enum",
      "error" : "value does not match",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf/0/$ref/allOf/0/$ref/enum"
    },
    {
      "absoluteKeywordLocation" : "http://localhost:1234/referencing.json#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf/0/$ref/allOf"
    },
    {
      "absoluteKeywordLocation" : "http://localhost:1234/subSchemas-ids.json#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf"
    },
    {
      "absoluteKeywordLocation" : "http://localhost:1234/#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf"
    }
  ],
  "valid" : false
}

{
  "errors" : [
    {
      "absoluteKeywordLocation" : "http://localhost:1234/referencing.json#/$defs/referenced/enum",
      "error" : "value does not match",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf/0/$ref/allOf/0/$ref/enum"
    },
    {
      "absoluteKeywordLocation" : "http://localhost:1234/referencing.json#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf/0/$ref/allOf"
    },
    {
      "absoluteKeywordLocation" : "http://localhost:1234/subSchemas-ids.json#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf/0/$ref/allOf"
    },
    {
      "absoluteKeywordLocation" : "http://localhost:1234/#/allOf",
      "error" : "subschema 0 is not valid",
      "instanceLocation" : "",
      "keywordLocation" : "/allOf"
    }
  ],
  "valid" : false
}

{
  "valid": true
}

The other files in remotes use 'definitions', and the 2019-09 spec says that that location should be kept reserved for use by refs, so I would just rename $defs to definitions there.

I'm happy to move it, but I am curious: Where does the spec require 2019-09 implementations to handle "definitions"?
I see that the keyword is reserved to prevent redefining it with different behavior, but I can't find where its behavior is actually specified in the 2019-09 spec.

I can't find where its behavior is actually specified in the 2019-09 spec.

'definitions' and '$defs' aren't really keywords of their own -- their behaviour is only useful when in context with '$ref' (and variants like $recursiveRef). You could have a $ref to any json path you like, and a $ref value like "#/properties/foo/allOf/0" is just as legal - https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.<IP_ADDRESS> doesn't limit $refs to any particular path name.
definitions (and now $defs) was set aside as the recommended namespace for that so it would not conflict with any other keywords that someone might want to add.   I don't see anything in the spec that says anything like "only json pointer-containing $refs that use $defs are legal, and an implementation is free to disregard any $refs that use other paths) or anything like that.  And since 'definitions' was already reserved by earlier drafts, it is recommended to not re-use that namespace for a new keyword.

That's how I read the section on references to possible non schemas. Seems like a ref to "definitions" (an unknown keyword) would be undefined behavior.

do we want to be that picky?

For the official test suite? Yes :) If the spec classifies it as undefined behavior, I don't think it's right for the acceptance tests to expect specific behavior there. I'm happy to acknowledge that I might be misinterpreting the spec, but with my current understanding, I'm not comfortable using "definitions" in 2019-09 test cases.
At the very least, I can resolve the issue in this PR by creating two files for this case: one with "$defs", and one with "definitions".

@rjmill sorry for the long delay here -- any chance you're willing to resolve the conflicts for this PR so I can have a look for review?

@rjmill

That's how I read the section on references to possible non schemas. Seems like a ref to "definitions" (an unknown keyword) would be undefined behavior.

Yes, that's correct, we should use $defs in the test suite.  While definitions is basically reserved for implementations that want to support it for compatibility reasons, it is not required and I know of at least one 2019-09/2020-12-only implementation that will not find schemas under definitions, but will find them under $defs.

@Julian

sorry for the long delay here -- any chance you're willing to resolve the conflicts for this PR so I can have a look for review?

I'm willing, but free time may be a bit of an issue :sweat_smile: If someone wants to take this PR over, I won't be offended. Otherwise, I'll try to get to it when I have the time.
The merge conflicts don't look too tricky, from what I can see.
Looks like my bin/jsonschema_suite and index.js changes are irrelevant now. The rest seem like normal merge conflicts? I haven't been following changes in this repo, so it's hard to say at a glance.

@gregsdennis I fixed the merge conflicts and pushed again. Let me know if there's anything else I can do.
btw, I am still the same person. I just changed my last name (got married) and changed my gh handle to match.

@Julian do you think it's worth having this test for draft 4?

We write it's "frozen" in the README. I still personally honestly do try to cover it though when I add tests, because it's still reasonably popular to see in the wild from what I see, regardless of what we hope.
So I'd personally do it, yeah, but I understand if/when others are less willing to put in the effort for it.


Add youtube videos (Fully3D, PyData)

Add youtube links for the Fully3D/PyData  both in CIL and CIL-Demos

closed by #1262


[TIR] Introduce tir::PrimFunc

This PR introduces tir::PrimFunc which will be used as the TIR function
container in the unified IR.
Also streamlined the function attributes a bit further.

All common attributes are under tvm::attr
TIR specific attributes are under tvm::tir::attr and comes with a tir prefix
Use stl_style for attributes for now

cc @zhiics @Hzfengsy @spectrometerHBH @icemelon9 @yzhliu @jroesch

Followup: move LoweredFunc to directly use PrimFunc


TimePicker displays AM even if not requested

Environment

Tech
Version

@material-ui/pickers
3.2.0

material-ui
4.2.0

React
16.8

Browser

Peer library
moment

Steps to reproduce
I used this code:
        <TimePicker
          ampm={false}
          className={classes.nested}
          onChange={this.handleChange}
          name="duration"
          type="time"
          id="duration"
          value={value}
          label={<FormattedMessage id="DurationItem.title" defaultMessage="For" />}
          minutesStep={5}
          InputProps={{
            endAdornment: (
              <InputAdornment position="end">
                <TimelapseIcon />
              </InputAdornment>
            ),
          }}
        />

Expected behavior
I should not see AM or PM in the Time picker
Actual behavior
I see AM.
Live example
https://weweave.org/nearby and click on the pen icon on the map. The Duration should be 00:30 and not 12:30 AM.
Also oddly even on a French localized browser, the DateTimePicker displays UK/US date time!

Cannot reproduce it. Please provide codesandbox if you are thinking this issue is still valid

I used the example from https://material-ui.com/components/pickers/, edited it on codesandbox, added ampm={false} and it's not working.
Use a british-localized Chrome.

Did you manage to reproduce it with these parameters?

What about this? Take this bug on Chrome. IE 11 - fine

Should be fixed in v4

Great thanks!


[release-v0.11] Automated cherry pick of #57: Update golang to 1.21.5

/area dev-productivity
/kind task
Cherry pick of #57 on release-v0.11.
#57: Update golang to 1.21.5
Release Notes:
Lakom application and lakom extension controller are now built with Go version `1.21.5`.

/reviewed ok-to-test


[TVMSCRIPT] Add type definition for preflattened_buffer

Seems like this type annotation was missed with Eric's big PR.
@junrushao1994 @Lunderberg

@tkonolige need to resolve the conflict.


Change Authentication in DocServiceClient.

Coverage decreased (-0.08%) to 86.207% when pulling e7e1a52babe1687e34bfbc64256a4c3317b70a60 on fix_bugs into c9b6e3f525691e9f020a442803b515134eb6ac58 on add_upload.

Coverage decreased (-0.08%) to 86.207% when pulling 58d793234af2308baed6f83ccc2f434e8f7cdf50 on fix_bugs into c9b6e3f525691e9f020a442803b515134eb6ac58 on add_upload.


Cannot download DALL-e image from provided URL

Describe the bug
When using the gem, I can get an URL of a DALL-e image that I can open in a browser. However, when trying to download it locally, I get an error. Is this because of missing SSL connections?
To Reproduce
require 'open-uri
client = OpenAI::Client.new
response = client.images.generate(parameters: { prompt: "Cat", size: "256x256" })
url = response["data"].first["url"]
open(url)

Desktop (please complete the following information):

OS: Mac Desktop (Rails backend)

Turned out that the issue was with the open() method. It actually calls kernel#open. I've switched to using the down gem.


Remove all GATK-SV QC/Metrics sub-workflows

GATK-SV is run using a few top-level WDL files, each of which calls a number of sub-workflows. Many of those workflows which are on by default are not required for production running (QC plots, summary metric file generations).
Once we've obtained some plots, we should deactivate all these workflows which aren't required to generate SV results. We can access these switches through config, so turn them all off in the default config. We can still override the setting to reactivate using config. These are the accessible switches we should set to false (not run):
(see https://github.com/search?q=repo%3Abroadinstitute%2Fgatk-sv+if+(run_module&type=code)
FilterGenotypes
FilterBatch
CleanVcf
GatherSampleEvidence
GenerateBatchMetrics
GatherBatchEvidence
ClusterBatch

Sounds good.  In the Config can we include a sentence summary of what (we think) each workflow does? The names are not great to guess this for.

I can't wait to see how much overall runtime (and potentially cost) this saves us.


🐛  Add support for v1 gguf

It seems that v1 gguf was never supported. This pr addresses that by selectively reading bytes as Uint32 for v1 and UInt64 for v2 and v3.
Fixes https://github.com/huggingface/huggingface.js/issues/568

@julien-c @mishig25 feel free to merge

ping here when this is deployed on the hub @mishig25, this is super cool! Thanks again @madgetr!

Great work. Mada a communication here https://twitter.com/mishig25/status/1770869824312295716?t=OfFLsWee09YYfyjNNkdcyg&s=19


Update zh_cn.json

Just two new strings, and some changes beautifying the tooltips. 🌸

Thanks!

Thanks!


JSON library as a git submodule

In order to use nlohmann/json as a submodule of another project it would be great to have a small subset of the JSON project without unit tests, documentation and benchmarks.
The size of the v3.7.3 is 252MB while the size of the include folder is 800k. It takes time to download the library on CI if you build from scratch.
As a workaround one can download zip file and put include folder only.

This is odd, because we just recently in #2081 removed the test data from the develop branch. A shallow checkout is now just 6 MB:
❯ git clone --depth 1 https://github.com/nlohmann/json.git
Cloning into 'json'...
remote: Enumerating objects: 855, done.
remote: Counting objects: 100% (855/855), done.
remote: Compressing objects: 100% (733/733), done.
remote: Total 855 (delta 121), reused 588 (delta 62), pack-reused 0
Receiving objects: 100% (855/855), 6.45 MiB | 3.93 MiB/s, done.
Resolving deltas: 100% (121/121), done.

I'm not sure if I can configure depth of the clone on CI... Full clone is massive still.
$ git clone https://github.com/nlohmann/json.git                                                        Cloning into 'json'...
remote: Enumerating objects: 124, done.
remote: Counting objects: 100% (124/124), done.
remote: Compressing objects: 100% (81/81), done.
Receiving objects:  11% (5825/50464), 64.34 MiB | 240.00 KiB/s
...

Looks like the repo is huge because of history. The repo size is 11MB while the size of the .git folder is 180MB.

I believe new git tag is needed now instead of 3.7.3.

There will be a new tag once version 3.8.0 is released which should happen this month. I will also investigate how to remove the large files from the git history.

Have you tried using shallow submodules?

No, I haven't. And looks like in git 2.14.1+ it is broken. See "Summary of buggy / unexpected / annoying behaviour as of Git 2.14.1" answer.

It seems that it is discussing two specific cases relating to checking out a custom branch/commit of the submodule. Given the length of discussions (especially the first answer), I understand that shallow submodules are probably brittle and might fail in some cases, but in your use-case it might solve the problem.

I tried to apply git config ... shallow true command to another submodule in my repo. Then I've called git clone --recurse-submodules again but it had changed nothing. Git still downloads entire history.
 Thus git has to download entire history to find that hash. Or I use it incorrectly.

There will be a new tag once version 3.8.0 is released which should happen this month. I will also investigate how to remove the large files from the git history.

There's exactly one way to remove large files from history. Well, two ways if you count "do a shallow clone".
You will need to use the git-filter-branch(1) command (see the EXAMPLES) section of the manpage, to rewrite history, and then force push to overwrite all commits. This will break previous git tags, commit sha1 references, etc. which is obviously not an ideal situation. Some people would argue that for a one-time thing if the reward is great enough (like removing lots of very large files from the history), it makes sense to do this. Other people would argue history should never be removed for any reason whatsoever. Ultimately, this is a personal choice.
If you're interested in doing this, don't hesitate to ping me with questions.

Thanks for letting me know. I did a brief research and also found the mentioned downsides in removing large files from the history. Right now, I am more than hesitant to break existing tags and hashes, and hope that submodule get a nicer support for shallow clones.

I believe the least intrusive way would be to start a new repository on GitHub (e.g. nlohmann/modern-json) and leave this one as is (possibility marking it as read-only/archive/deprecated). This provides a clean history for users who want to adopt the latest version, while keeping the whole history intact for whoever depends on it. I guess it might be even possible to negotiate with GitHub to transfer watch/starred points to the new repository.
Even such a change, which would not be disruptive for the users, needs careful consideration and only might be carried out on a major release (e.g. 4.0.0), if ever.


Create Transformation task for Engraftment_sample_type

As a developer, I want to have a Luigi task that transforms the data/metadata given by providers into a suitable format for the entity Engraftment_sample_type.
Design
Database Schema

Create entry in scripts/init.sql for the creation of the table, pk and fks.
Create entry in etl/workflow/transformer.py with the class TransformModel.
Create entry in etl/jobs/transformation/spark_transformation_job.py
Create job etl/jobs/transformation/engraftment_sample_type_transformer_job.py
Create entry in luigi.cfg
Create entry in etl/workflow/loader.py

Acceptance Criteria

[x] Table model was created according with the designed database schema
[x] The transformation task can be executed and it finishes correctly
[x] Data in the Engraftment_sample_type table is the expected one for the provider(s)

Done. @CsabaHalmagyi

Done.


Added support for min and max (so it doesn't break css calculation)

Hi.
In $config at
https://github.com/hexydec/cssdoc/blob/06da9d0dd7f0dbd806f9e4bbf2b846a0226ddaa0/src/cssdoc.php#L37
spaced needs the keywords: min and max as well, otherwise the * used in min and max (or perhaps elsewhere in css?) breaks.
I say elsewhere, because maybe it is better to declare that * always have surrounding space around it? In min and max, if the * does not have space around it, it breaks the calculation. Which some time ago on a different project, took me a long time to figure out that! Lol - so it didn't take that long this time (whewww)
I added them locally to support this like:
'spaced' => ['calc', 'min', 'max'],

According to MDN, only the + and - operands require a space to be left:
"Make sure to put a space on each side of the + and - operands"
Also the clamp() function will require this upgrade.


Make --stage and option for assign, not argument

close #232

Codecov Report
Base: 80.91% // Head: 80.25% // Decreases project coverage by -0.65% :warning:

Coverage data is based on head (c73e8cc) compared to base (691ca4b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   80.91%   80.25%   -0.66%
==========================================
  Files          16       16
  Lines        1886     1849      -37
==========================================
- Hits         1526     1484      -42
- Misses        360      365       +5

Impacted Files
Coverage Δ

gto/cli.py
69.46% <ø> (-0.11%)
:arrow_down:

gto/config.py
95.65% <ø> (-0.14%)
:arrow_down:

gto/_version.py
36.36% <0.00%> (-45.46%)
:arrow_down:

gto/base.py
84.35% <0.00%> (-1.04%)
:arrow_down:

gto/ext.py
71.05% <0.00%> (-0.75%)
:arrow_down:

gto/ui.py
83.01% <0.00%> (-0.62%)
:arrow_down:

gto/versions.py
88.33% <0.00%> (-0.56%)
:arrow_down:

gto/registry.py
73.04% <0.00%> (-0.24%)
:arrow_down:

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove obsolete warning reference

Ran through the tutorial today and this warning didn't occur on my machine (running MacOS and dotnet SDK 2.2.104).

Can you create an issue from the doc page? That will connect the doc to the issue. Go to the bottom of the page and select the Content feedback issue.

Which tutorial?

@seanknox 	thanks!


⚠ Bofrost.at has degraded performance

In d580a73, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2455 ms

Resolved: Bofrost.at performance has improved in 9fb4ea9 after 26 minutes.


Packaging issue with pyinstaller

-I've packaged python file using pyinstaller in Ubuntu-18.04 LTS containing below mentioned statement only:
import opentaxii
This packaged exe then raised error:
Traceback (most recent call last):
File "libtaxii/common.py", line 34, in parse
File "src/lxml/etree.pyx", line 3424, in lxml.etree.parse
File "src/lxml/parser.pxi", line 1840, in lxml.etree._parseDocument
File "src/lxml/parser.pxi", line 1866, in lxml.etree._parseDocumentFromURL
File "src/lxml/parser.pxi", line 1770, in lxml.etree._parseDocFromFile
File "src/lxml/parser.pxi", line 1163, in lxml.etree._BaseParser._parseDocFromFile
File "src/lxml/parser.pxi", line 601, in lxml.etree._ParserContext._handleParseResultDoc
File "src/lxml/parser.pxi", line 711, in lxml.etree._handleParseResult
File "src/lxml/parser.pxi", line 638, in lxml.etree._raiseParseError
OSError: Error reading file '/tmp/_MEICJe6hi/libtaxii/xsd/TAXII_XMLMessageBinding_Schema.xsd': failed to load external entity "/tmp/_MEICJe6hi/libtaxii/xsd/TAXII_XMLMessageBinding_Schema.xsd"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "test.py", line 3, in
from opentaxii.middleware import create_app
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "/usr/local/lib/python3.7/dist-packages/PyInstaller/loader/pyimod03_importers.py", line 623, in exec_module
exec(bytecode, module.dict)
File "opentaxii/init.py", line 7, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "/usr/local/lib/python3.7/dist-packages/PyInstaller/loader/pyimod03_importers.py", line 623, in exec_module
exec(bytecode, module.dict)
File "opentaxii/server.py", line 4, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "/usr/local/lib/python3.7/dist-packages/PyInstaller/loader/pyimod03_importers.py", line 623, in exec_module
exec(bytecode, module.dict)
File "opentaxii/taxii/services/init.py", line 3, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "/usr/local/lib/python3.7/dist-packages/PyInstaller/loader/pyimod03_importers.py", line 623, in exec_module
exec(bytecode, module.dict)
File "opentaxii/taxii/services/inbox.py", line 10, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "/usr/local/lib/python3.7/dist-packages/PyInstaller/loader/pyimod03_importers.py", line 623, in exec_module
exec(bytecode, module.dict)
File "opentaxii/taxii/utils.py", line 9, in
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "/usr/local/lib/python3.7/dist-packages/PyInstaller/loader/pyimod03_importers.py", line 623, in exec_module
exec(bytecode, module.dict)
File "opentaxii/taxii/bindings.py", line 45, in
File "libtaxii/validation.py", line 148, in init
File "libtaxii/common.py", line 36, in parse
File "src/lxml/etree.pyx", line 3190, in lxml.etree.XML
File "src/lxml/parser.pxi", line 1877, in lxml.etree._parseMemoryDocument
File "src/lxml/parser.pxi", line 1758, in lxml.etree._parseDoc
File "src/lxml/parser.pxi", line 1068, in lxml.etree._BaseParser._parseUnicodeDoc
File "src/lxml/parser.pxi", line 601, in lxml.etree._ParserContext._handleParseResultDoc
File "src/lxml/parser.pxi", line 711, in lxml.etree._handleParseResult
File "src/lxml/parser.pxi", line 640, in lxml.etree._raiseParseError
File "", line 1
lxml.etree.XMLSyntaxError: Start tag expected, '<' not found, line 1, column 1
[20896] Failed to execute script test
My dependencies are:
altgraph==0.17
anyconfig==0.9.11
blinker==1.4
click==7.1.2
Flask==1.1.2
itsdangerous==1.1.0
Jinja2==2.11.2
libtaxii==1.1.116
lxml==4.5.1
MarkupSafe==1.1.1
opentaxii==0.1.12
PyInstaller==3.6
PyJWT==1.7.1
python-dateutil==2.8.1
pytz==2020.1
PyYAML==5.3.1
six==1.15.0
SQLAlchemy==1.3.17
structlog==20.1.0
Werkzeug==1.0.1
If anyone can help me out here?

@tahirshehram did it pack files with extension xsd, like TAXII_XMLMessageBinding_Schema.xsd?

As in aforementioned error, pyinstaller failed to load TAXII_XMLMessageBinding_Schema.xsd

@tahirshehram correct. That's why my question is - was it packaged together with the code?

@traut
No, it wasn't packaged with TAXII_XMLMessageBinding_Schema.xsd because of which the packaged exe raised unable to read error

not sure I understand where the issue is. Do you see this error while installing the package via pip? If so, it might be an issue in libtaxii.

this seems relevant, @tahirshehram - https://github.com/sissaschool/xmlschema/issues/100

The issue is closed because of inactivity. The issue could be open again if additional information is provided to justify it is a OpenTAXII bug. A reproducible way to create the bug would help.
Note: pyinstaller is not officially supported and there is no plan for doing it.


[index] Fix infinite loop while looking at superclasses

While checking for superclasses in isUnitTest, we need to handle
circular inheritance. For good measure, add tests for protocols as well.
The new API is designed to behave the same as walkInheritedProtocols
except that is walks over superclasses.
https://bugs.swift.org/browse/SR-10236
rdar://49434989

@swift-ci please smoke test


[Task] Add RNN-based model apis for session-based recommendation

Description
Currently there is no out-of-the-box api for creating an LSTM, BiLSTM and GRU architectures for a session-based (or sequential) task.

For LSTM , I assume we'd use tf.keras.layers.LSTM api.
For BiLSTM shall we use tf.keras.layers.Bidirectional?
For GRU, can we not port GRU4Rec model code from TF4Rec to Merlin Models?

Looks like there were two tickets before but they were closed without completion:
https://github.com/NVIDIA-Merlin/models/issues/732
https://github.com/NVIDIA-Merlin/models/issues/733

Just a wild suggestion, maybe you can also add SAS4Rec by using tf.keras.layers.MultiHeadAttention. I assume it will be a very similar block structure once LSTM and GRU blocks are done

closing this since we are creating an example for  BiLSTM where we can easily  use tf.keras.layers.Bidirectional?


Documentation Request: Update the Paymaster Bundler experience Guide

Is your documentation request related to a problem? Please describe.
The guide feels disconnected on how the code is now. We need to re-write it in a way the guides helps understand the code inside BOAT.
Update the code to match what's in BOAT as well as the format of the guide.

What's the correct response for this?
Select Onchain App experiences (press space to remove an experience)
│  Paymaster Bundler
│
▲  Base RPC URL
│  https://sepolia.base.org_
└  RPC must be at least 79 characters

I got my RPC URL from https://portal.cdp.coinbase.com/products/node however, I am stuck on the experience as well since the internal API endpoint for api/rpc is telling me
POST /api/rpc 500 in 7ms
Error: TypeError: Request with GET/HEAD method cannot have body.


n-fold duals

Now that Klaudia has an initial version of manifold detection, it's time to think about implementing this into the tool.
For every generator, we should have an option to make it $n$-dualisable rather than invertible. If a generator is $n$-dualisable, the only homotopy moves allowed in dimensions $> n$ are the ones where the singular slice is manifold-like. @jamievicary Is that correct?

Yes this is broadly correct but let's see if we can make a more precise statement.
For an $n$-dualizable $k$-dimensional generator $G$, consider a $d+1$-dimensional homotopy. If $d+1 \leq k+n$, there are no additional checks to perform. Otherwise we examine the $d$-dimensional singular target slice of the homotopy, and consider the locus of $G$. If it is not a $(d-1)$-dimensional manifold then homotopy construction fails.
If anyone thinks some details here might be wrong it would be good to hear that. Otherwise let's implement it and see if it behaves the way we are expecting.


feat: allow to upload firmware in zip files

Ref https://github.com/zwave-js/zwave-js-ui/issues/3983

@AlCalzone About tryUnzipFirmwareFile should I check the file extension first and then use it before guess ?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.095%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/mixins/InstancesMixin.js
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
3946

Relevant Lines:
19894

💛  - Coveralls

Almost correct. If ".zip" use tryUnzipFirmwareFile, otherwise use guessFirmwareFileFormat.
tryUnzipFirmwareFile does the guessing aswell, otherwise the zip file would have to be parsed twice.

Ok so the code I wrote should be correct, right?

Looks good. Just need to wait for 14.1.0 to finish building.


Allow for specifiying the precision when constructing DebyeCalculator

In some scenarios (e.g. fitting GPs and doing BO) it's important to keep double precision. But I've been told double precision can be too costly when computing scattering patterns.
Could you allow for specifying the default torch float type in the constructor of DebyeCalculator?

@AndySAnker

Thank you for your suggestion! We think it makes a lot of sense to allow for double precision as well. From testing, it seems like we are able to support single- and double precision for now. Half precision seems to introduce some instabilities when calculating small values.
Double-precision can be specified using the dtype parameter when initialising a DebyeCalculator object:
calc = DebyeCalculator(dtype=torch.float64)

This feature will be a part of the next release of DebyeCalculator.
I am closing the issue here. Feel free to reopen the issue if you would like to see any further changes made to this.


Windows Test failed because buildkitd not supported

Description
buildkitd only supports linux and openbsd, but we have a windows test and will failed: https://github.com/containerd/nerdctl/actions/runs/7913136153/job/21600170296
maybe we could move the tests to linux or UNIX only?
is so I can submit a PR for it
Steps to reproduce the issue
https://github.com/containerd/nerdctl/actions/runs/7913136153/job/21600170296
Describe the results you received and expected
result:
CI failed: https://github.com/containerd/nerdctl/actions/runs/7913136153/job/21600170296
expected:
CI passed
What version of nerdctl are you using?
master
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

Will take a look at this now that buildkitd.exe is now being released for Windows starting from v0.13.0-rc2.

@zwpaper there's this PR as well to enable nerdctl build for windows

The CI failure in the issue body was in the TestVolumeLsFilter test, and was a flake, since that test doesn't normally fail. A rerun of the same build failed in TestRunEnv instead (a different flake), and a second rerun passed.
The lack of build support skips the build tests on Windows, and so doesn't cause CI to fail, so this ticket is unrelated to the build support on Windows.

@AkihiroSuda I think this should be closed.
As @TBBle stated, the failure was test flakyness - which are likely fixed now by #3285


‘new’ data to international exchange

5.15 E-SOH is going to send ‘new’ data to international exchange and this should be only done in WIS2.0. See the WMO transition principle 4: https://community.wmo.int/en/GTS_WIS2_Transition_Guidance. The national data transition as ftp data exchange from traditional messengers (MSS) on GTS can continue in parallel before the decommission of GTS

@mhuuskonen - what is the question here?

This is a comment that E-SOH should not build any capabilities for sending data to GTS in parallel with WIS2.0. The text behind the link defines the WMO transition principles and new (high-frequent) data should not be sent to GTS


Crash on Survey

Mixpanel version 2.6.2 application crashes:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[UILayoutContainerView mp_snapshotImage]: unrecognized selector sent to instance 0x1703e2a00'
-[Mixpanel presentSurveyWithRootViewController:] (Mixpanel.m:1323)
__43-[Mixpanel showSurveyWithObject:withAlert:]_block_invoke (Mixpanel.m:1371)
If we turn off survey ([Mixpanel sharedInstance].showSurveyOnActive = NO) all good!
In version 2.6.0 also all good.
It is reproduce often on Simulator and iPhone6/iPhone6+ devices

hi @SvenSven2009
Does your mixpanel build include the libMPCategoryHelpers.a file? That file contains the function that it's crashing on trying to find.

Hi Alex,
I cannot answer to you question because i did rollback to version 2.6.0 and all fine (i am using cocoa pods)

Guys, any updates?
Because, now, in version 2.6.0 we have another crash :https://github.com/mixpanel/mixpanel-iphone/issues/207
All fine if we use ([Mixpanel sharedInstance].showSurveyOnActive = NO) but we need "survey"

hey @SvenSven2009 - #207 can be fixed by manually copying the storyboard resource to your main app bundle. take a look at https://github.com/hyperlab/TiMixpanel/issues/4 for detailed instructions - the main issue here is that the Mixpanel library is looking for the XIB in your main app bundle instead of in the pod installed Mixpanel bundle. let me know if this helps!

Hello arittr -    I was added manually storyboards from Mixpanel but, unfortunately, crash still reproduce and reproduce only on iPhone 6 and 6+....And may be it is help:i show UIWindow  after app start

Also encountered this but I fixed this by linking libMPCategoryHelpers.a in build phases

marking this as related to https://github.com/mixpanel/mixpanel-iphone/issues/225

Hi, guys!
I had the same issue.
The reason for that well described here: https://developer.apple.com/library/ios/qa/qa1490/_index.html
So, for me solution was adding -force_load path_to_the_libMPCategoryHelpers.a to the Other linker flags

Nothing above has worked for me, but what did work was commenting out:
controller.backgroundImage = [presentingViewController.view mp_snapshotImage];

in Mixpanel.m :/

I just had the exact same problem. Adding -ObjC in Build Settings > Other Linker Flags for Debug and Release fixed it. Thanks to @malectro for documenting why here: #225

This will be resolved in the next major release.

This should be resolved now if you want to do a pod install.

Hi guys,
I have the same problem on Xcode 6.4, building on iOS 8.
I'm using Carthage (github "mixpanel/mixpanel-iphone" "master")
2015-08-27 09:48:34.384    [4471:524526] -[UILayoutContainerView mp_snapshotImage]: unrecognized selector sent to instance 0x14c528300
2015-08-27 09:48:34.385    [4471:524526] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[UILayoutContainerView mp_snapshotImage]: unrecognized selector sent to instance 0x14c528300'
Any idea why I'm having this crash?
Thanks
Axel


How to build the dmg file for mac

Hi. I am trying to build the dmg file, however, once I build the dmg file, it's not working on Mac.
It doesn't open at all.
Can you please guide me on how to build the dmg file correctly?
Thank you.
Miguel

I'm not responsible for the macOS version but looking at https://github.com/Syncplay/syncplay/blob/master/.travis.yml and https://github.com/Syncplay/syncplay/blob/master/buildPy2app.py might be of assistance. Why do you need to build your own dmg file?

If you want the latest development builds of Syncplay then they are available from: https://bintray.com/syncplay/Syncplay/Syncplay/v1.6.5#files

We do not prov


0.8 array notification

Removes use of ArrayObserve.observe.  Instead, users must use this.push(), etc. on elements to mutate arrays.  Collection is also no longer observable; simply stands as a store of key->item and item->key mappings for arrays.
Renames getPathValue and setPathValue to get and set.
get and set can now take an array of path parts, to avoid needing to concat, e.g. set([items', 4, 'name'], 'bob);, and also does automatic array index-to-key mapping when notifying path (4 in example would be replaced with the key for items[4] when notifying).
Renames _data to __data__ to avoid collision with user data.

What's the motivation for this change? Is Array.observe too heavy-weight, or just not working right?

@arthurevans Prior to this change, we used Array.observe (on Chrome) but on all other browsers overrode array instances with patched push/pop/etc. methods to be able to observe when changes occurred (remember, we're avoiding the observe-js polyfill overhead for Polymer proper).  The patching approach was not only intrusive, but led to a hard-to-explain API w.r.t. making changes to structured data (if you want to set set this.items[4] and have Polymer see it, you need to use this.set, but if you want to push onto this.items, you could just push onto the array).  Now, all mutation of objects/arrays should be done through Polymer.Base API's:

get
set
push
pop
shift
unshift
splice

LGTM


refactor users

In this PR:

Match code to the current library standard.
Improve tests.
Deprecate 'roles' and use 'role' instead, to match the current API.

Merging, but not releasing a new version yet, as I want to work on more changes for the new version.


sourceforge.jp is now osdn / more generic checking for bad url formats

Thank you for handling it, I appreciate it.

Thank you for handling it, I appreciate it.


careless poly fails with cryptic error for stream files

Stream files are not supported in careless poly, because the rs parser doesn't populate the wavelength of each spot. Rather than failing with a cryptic error about "Wavelength" keys, the code should inform the user this isn't a supported mode.

fixed in #174


Making SimulatedEyeGazeDevice public so folks can check for its existence

Overview
Right now, it's basically impossible to check an input device to see whether it's eye gaze or not (#11039 ). This bandages the problem by making the simulated eye gaze device un-internal so at least folks can type check against it.
Changes

Kinda fixes #11039 by un-internaling the simulated eye device

Note
It's recommended to use ControllerLookup.GazeController for now.

should we make all of the simulated devices public?

No, this is unique to the eye gaze device because of the conflict between the OpenXR pose struct and the input system pose struct, which means that users cannot type check against the generic OpenXR EyeGazeDevice.
For other devices, users can.


Legal License Change Issues

I noticed you changed how your software was licensed between a couple of versions. Version 1.0.0 was released under LGPL-3.0, version 2.0.0 was released under no license (automatic copyright), and version 2.0.5 was released under GPL-3.0.
I'm assuming that this wasn't intentional as this has some nasty legal implications that render this project basically unusable until they are resolved. I guess the options would be to...

Revert to the LGPL-3.0 license along with any code not made under that license (2.0.0 - 2.0.4)
Change to GPL-3.0 and provide the written approvals from each contributor, removing code from any contributor that denies permission (approvals would ideally be accessible from the repository as outlined here)
Revert to the LGPL-3.0 license and provide the written approvals from each contributor who made contributions since 1.0.1 to license under LGPL-3.0 as explained above.

The root of the issue is that the developers who contributed to version 1.0.0 - 1.0.1 have not given permission to have the license for their code removed as it was in version 2.0.0 - 2.0.4, and developers who contributed to 2.0.0 - 2.0.4 have not given permission to license their code under GPL-3.0 as in 2.0.5. There's no way to prove that proper permission was granted by contributors since version 2.0.0. This may seem nit-picky, but the issue can result in DMCA takedowns which threaten the usability of the software. People using code from version 2.0.0 - 2.0.5 of this project may also be subject to legal consequences.
There's probably a loophole somewhere in the fact that your README hasn't been updated which you might be able to use as "proof" that the licence change was unintentional. However, I'm not qualified to give legal advice, so I suggest you speak to a lawyer before moving forward.
TL;DR call a lawyer.

Hello @leviem1 thanks for the heads up, we are working on it.

working on #38
Tks @leviem1!

New License is up https://github.com/insidersec/insider/blob/master/LICENSE commit: https://github.com/insidersec/insider/commit/fe5d2febc6cfa8138dc6507b5c0ccbb68f971dd4
Thanks @leviem1 !

New License is up https://github.com/insidersec/insider/blob/master/LICENSE commit: https://github.com/insidersec/insider/commit/fe5d2febc6cfa8138dc6507b5c0ccbb68f971dd4
Thanks @leviem1 !


Exploratory code for Step Changes info box

Addresses #93
This is pretty ugly code, but just showing what the Step Info Box could look like to inform the user what changed in between each step. Not sure yet what I think about, but it works both with and without the "Smart Step" of PR #108. Might be extraneous if we go with Smart Step. Currently it is not implemented, but I'd prefer a URL option a la &stepinfo=1 or something like that. Also, I'd prefer that it vanish if it doesn't have anything to say, but didn't add that yet. Just a draft for now.
Signed-off-by: Scott Johnson<EMAIL_ADDRESS>

There are several PRs lingering, which I don't like since it makes merging tough. We need to decide on these, so weigh in @warrenjp. I'm hoping to finalize tomorrow (Wednesday). Here are my thoughts on this one:
I'm inclined to shelve this one. I think it clutters things up a bit. But we could make it a toggleable and URL option that is not default. But with smart step it is not as pressing IMO.

I like this feature as an option that is normally turned off. I agree that we have bigger fish to fry. Notwithstanding, if we do implement this feature, I'm not super happy about it disappearing after 4 seconds (again, this should be made a labeled constant and not a magic number). I'm not sure how long it should last, but my intuition is that it would be helpful to have it stay visible until the box is clicked on, rather than disappearing on stepTmout.

I'm going to wait for #108 to merge before I tackle this one again, it will be a bear to rebase otherwise


yuv420p & h264_nvmpi missing

I have a Jetson Nano 2Gb and about 5 months ago I successfully ran Viseron - which I think is one of the best NVR programs with facial recognition.
Then I had to uninstall it to make space for new projects.
Now, however, I could use it but whatever version I download tells me I'm missing a decoder.
I haven't followed all the comments, so excuse me for asking a question that has already been asked.
Is there anything I can do to fix this and get it working?
Thanks!
I would like to stay at the moment on the stable and released version, but I wanted to try also the 2.0 out of curiosity
roflcoopter/jetson-nano-viseron:latest
roflcoopter/jetson-nano-viseron:dev
[2022-02-15 15:10:29] [ERROR   ] [viseron.camera.stream.soggiorno] - [h264_nvmpi @ 0x55cca66ff0] Invalid Pix_FMT for NVMPI Only yuv420p is supported
[2022-02-15 15:10:29] [ERROR   ] [viseron.camera.stream.soggiorno] - Error while opening decoder for input stream #0:0 : Invalid data found when processing input
[2022-02-15 15:10:29] [ERROR   ] [viseron.camera.soggiorno] - FFmpeg process has exited

Version 2.0
roflcoopter/aarch64-viseron:modularize
[2022-02-15 11:34:55] [ERROR   ] [viseron.components.ffmpeg.stream.soggiorno] - Unknown decoder 'h264_nvmpi'

I am refactoring the Nano image, as the current one is very hacky and thus unstable.
To solve this temporarily you can add codec: h264 to the camera to run without hardware acceleration.
I need someone to run some tests for me on the new builds, could you be of help?

I need someone to run some tests for me on the new builds, could you be of help?

Absolutely yes, helpful and happy to help you!
As I said, I have an Nvidia Jetson Nano Developer Kit 2gb with the original Jetpack operating system.
Here the Features of my Device: https://developer.nvidia.com/embedded/jetson-nano-developer-kit
Do I have to subscribe to a particular channel/thread ?

Great! Ill just ping you in this issue.
Could you run this and show me the output?
docker run --it -rm --runtime=nvidia roflcoopter/jetson-nano-base:test ffmpeg -hwaccels

Interesting.
What about this?
docker run -it --rm --runtime=nvidia roflcoopter/jetson-nano-base:1.3 ffmpeg -codecs

And this?
docker run -it --rm --runtime=nvidia roflcoopter/jetson-nano-base:1.3 ffmpeg -decoders

is attached  :)
decodecs.txt

wow seems to be working(!)

Any Way to help?
I used to run viseron on Jetson Nano 2G and now i am receiving the similar issues with some of the issues
mainly at the moment :
NvMMLiteOpen : Block : BlockType = 261
NVMEDIA: Reading vendor.tegra.display-size : status: 6
NvMMLiteBlockCreate : Block : BlockType = 261

Any Way to help? I used to run viseron on Jetson Nano 2G and now i am receiving the similar issues with some of the issues mainly at the moment : NvMMLiteOpen : Block : BlockType = 261 NVMEDIA: Reading vendor.tegra.display-size : status: 6 NvMMLiteBlockCreate : Block : BlockType = 261

Sorry you're having issues as well.
dadaloop82 offered to give me access to his Nano so i can run some tests

if it helps i could to the same i guess,
although i would prefer the "ping& pong" approach
like we did in the early stages of the nano developent
where you gave us instructions and viewed to corresponding logs.

Closed in v2, you can use the gstreamer component instead of ffmpeg now


System try icon on windows very small

The system tray icon on windows seems to be much smaller then it needs to be:

Compared to the docker icon its noticeably smaller.

Yup, that was a hasty one :) - Better monochrome or duotone icons, thanks for the example!

Hopefully better, not that happy myself with it, feel free to re-open.


Upgrade to rxjs to 6

This pull request will make library compatible with rxjs6 natively without need of rxjs compat

You are right changed it. Kind of in a rush.


Report time even when block returns

backporting https://github.com/DataDog/dogstatsd-ruby/pull/38 to our fork
r? @nelhage
cc @gphat

👍


api: dma: fix issue of non-implemented reload

reload function is not implemented by every DMA driver.
So, add api's NULL check to make sure it is protected if not
implemented.
Signed-off-by: Jun Li<EMAIL_ADDRESS>

@avisconti @erwango please review. Thank you!

@sathishkuttan can you review? Thanks!

LGTM


How to style pseudo classes for the Adyen input fields

Is your feature request related to a problem? Please describe.
I would like to be able to style a pseudo class in :focus, for the input fields in the AdyenCheckout instance.
Describe the solution you'd like
A way to style pseudo classes, so potentially an onFocus property in the CoreOptions interface or a way to do the same thing inside the styles object, as part of the PaymentMethodOptions generic type.
Describe alternatives you've considered
I've attempted to use the second argument (element) inside the onChange property within the CoreOptions interface, but have not found a way to do so.
Additional context
N/A

Hello @ashrafnazar
What would be the objective here? I ask because we are going to be rolling out CSS variables in V6 and you will be able to customise it that way.
I wonder however if your use case would be covered. Can you share a few more details on what you are trying to accomplish?

Hey @m1aw - it's to match our current designs, so when a user tabs through to an input field, or is on it, then we would like the outline property to change, i.e. it's stroke width and colour. Hope that makes sense

Is it currently not possible just by using CSS?

Hey Antonio,
I believe the input field is inside an iframe which makes it tricky to target using CSS, unless I'm missing something

Hi @m1aw - because the input fields are inside an iframe, I don't think it's as simple as updating the CSS. Unless I'm mistaken?

I've been told that I can style the parent element, i.e. the span with the data-cse attribute, but unless I do some sort of hack, there isn't a clean way to update the :focus state of it

Hey @ashrafnazar,
This may not be the best way, but I was able to overwrite Adyen css for the focus state
.adyen-checkout__field--cardNumber:has(.adyen-checkout__label--focused),
.adyen-checkout__field__exp-date:has(.adyen-checkout__label--focused),
.adyen-checkout__field--expiryDate:has(.adyen-checkout__label--focused),
.adyen-checkout__field__cvc:has(.adyen-checkout__label--focused),
.adyen-checkout__field--securityCode:has(.adyen-checkout__label--focused),
.adyen-checkout__card__holderName:has(.adyen-checkout__label--focused) {
	// your custom css goes here
	background: var(--color-interaction-background-focused);
}

Hope this helps

Hi @DeekshithShetty - are you integrating using Adyen's Drop-in component?

@ashrafnazar Yes. I am using the Drop-in component

@DeekshithShetty - unfortunately, this won't apply in my case, as my input fields are custom

Comment to keep issue open

@ashrafnazar Are you using create.checkout('securedfields') in this case? Which version of the library are you using?

@ribeiroguilherme - I'm using v5 and AdyenCheckout

How are you creating your component? Are you using create.checkout('securedfields')  ? And which version of v5 are you using?

The version we are using is 5.67.1 and the method is .create('securedfields'…

@ashrafnazar
Since you are using the "custom card" integration i.e. .create('securedfields'...) how your UI looks, is entirely up to you.
You can set an onFocus callback example here and do whatever you want to style the elements that act as parents for the iframes.
In this example we add/remove a class that controls the border & outline properties of the element.

Example provided is not easy to follow

I've updated the urls for the 2 examples, above.
In short:

You set a focus handler when you instantiate the custom card component:

 window.securedFields = checkout
        .create('securedfields', {
            ...
            onFocus : setFocus,
            ...

In the focus handler you can inspect the passed object to find the html element to which you want to add css classes that will make the input look focused:

const setFocus = function(pCallbackObj) {
    const inputEl = pCallbackObj.rootNode.querySelector(`[data-cse="${pCallbackObj.fieldType}"]`);

    // Add focus classes
    if (pCallbackObj.focus) {
        if (inputEl.className.indexOf('pm-input-field--focus') === -1) {
            inputEl.className += ' pm-input-field--focus';
        }
        return;
    }

    // Remove focus classes
    if (inputEl.className.indexOf('pm-input-field--focus') > -1) {
        const newClassName = inputEl.className.replace('pm-input-field--focus', '');
        inputEl.className = newClassName.trim();
    }
};

Example css class:
.pm-input-field--focus {
    border: 1px solid #969696;
    outline: none;
}

What if you were using styled components?


Added a possibility to fill message timestamp from a custom MDC property

GelfMessageFactory is looking for MDC key equal to GelfAppender.mdcTimestampProperty and if one is found, then current timestamp is replaced.
I need this so I can track messages as I received them, ane not by the time I've sent them to the graylog server.

Hi,
Did anyone had the time to look at my pull request?

Thank you for the pull request. Your change implements a very specific use case, and I'd prefer a more general mechanism for customizing messages.
Here's a possible alternative design. Add a property to GelfAppender specifying the name of a class extending GelfMessageFactory. If the property is configured, then GelfAppender will create an instance of this class and use it to create messages, otherwise GelfAppender uses GelfMessageFactory by default. Your application provides a class extending GelfMessageFactory which creates messages to suit your use case.