Swift 3 - Can you please deploy 1.4.9 on cocoapods ?

https://github.com/Vaberer/Font-Awesome-Swift/tree/swift-3

Thanks for the tag, but can you deploy for Cocoapods?
Ping @Vaberer

Any update?

None of your spec sources contain a spec satisfying the dependency: Font-Awesome-Swift (~> 1.4.9).
what is this?

Hello guys, thanks for the patience. After tons of errors, I finally could deploy new version 1.5.0. Let me know if all works for you, too.

I'm getting a successful pod install but when I try to use an icon I get:
assertion failed: ****** FONT AWESOME SWIFT - FontAwesome font not found in the bundle or not associated with Info.plist when manual installation was performed. ******: file /Users/wagnc/Documents/Main Dev/fontcheck2/Pods/Font-Awesome-Swift/Source/FAIcon.swift, line 61 2016-10-06 11:27:24.567453 fontcheck2[12149:2216037] assertion failed: ****** FONT AWESOME SWIFT - FontAwesome font not found in the bundle or not associated with Info.plist when manual installation was performed. ******: file /Users/wagnc/Documents/Main Dev/fontcheck2/Pods/Font-Awesome-Swift/Source/FAIcon.swift, line 61

1.5.1 works. thanks


Add missing HIGHLANDER_TSS2 engine f/w

dongle id?

dongle id?

Hmm, for some reason, my original comments didn't make it in.
@jordiejones#6038 2022 Toyota Highlander XLE AWD ICE  DongleID/route 7460df2b42ec374c|2021-11-10--08-42-22


Adds support for including signing time in signedAttrs for CMS signing.

Motivation:
Many CMS signing validations require the inclusion of signing time in signedAttrs (for example Apple Wallet's Pass CMS signing validation)
Modifications:

Adds optional includeSigningTime flag to CMS.sign method (defaults to false)
When includeSigningTime flag is true: includes signing-time (UTCTime ASN1Type), content-type, and message-digest signedAttrs and signs those instead of content bytes (as specified in RFC 5652 section 5.4)
Adds contentType ASN1ObjectIdentifier
Adds CMSSigningError (noTimeZone, invalidSigningDateComponent) for when includeSigningTime is true and unable to get UTC time zone or date components
Adds tests for valid and invalid CMS signature when including signedAttrs

Result:
Providing the includeSigningTime = true flag to CMS.sign will cause signing-time, content-type, and message-digest signedAttrs to be included in the CMS signature and the signature bytes will represent signing those signedAttrs. Using CMS.sign without the flag (defaulting to false) should leave the previous CMS.sign behavior unchanged.
Resolves: https://github.com/apple/swift-certificates/issues/147
Submitted on behalf of Zetetic, LLC

Thanks for the review/feedback. Definitely good suggestions. Using Date.utcDate to construct the UTCTime from date components allows me to remove the previously defined CMSSigningErrors as both of the defined errors were related to DateComponents construction.

Added in the explicit self's for the internal methods calls within CMSOperations.

@swift-server-bot test this please

These failures aren't your fault, our allocation baselines have regressed. I'll update them.

Feel free to rebase on to the new main branch.

I believe that should fix it up with the rebase now.

@swift-server-bot test this please

Just rebased off of main for the latest commit that came in. The last swift-server-bot check had a failure because of the CMS.sign API method signature changing. I believe this is a false positive because of the optional signingTime parameter addition. Let me know if anything else needs to be done on my end.

@swift-server-bot test this please

Merging over the API breakage.

Note that this is in theory an API breaking change as unapplied methods do not take default values into account:
// this fails to compile now but previously compiled successfully
let ref = CMS.sign(_:signatureAlgorithm:additionalIntermediateCertificates:certificate:privateKey:)

We can partially workaround this limitation by keeping the old signature and introducing an overload with the new parameter. The func with the old signature would just call into the new method.
However, this only partially solves the source break as
// error: Ambiguous use of 'CMS.sign'
let ref = CMS.sign

now becomes ambiguous and fails to compile as well.
I personally think this is fine though.
@Lukasa wdyt?

Yeah I don't mind at all. These are also CMS functions so they're not guaranteed to be API stable, so this isn't very egregious.


Having eye-tracking and gaze dwell selection at the same time

Describe the problem
The use-case concerns a UI window for a user who can't make use of his hands (busy doing something else) or voice (assuming voice recognition would not work 100% of time).
I'd like to be able to use a GazeCursor which could dwell on UI buttons to trigger them but I'd also like to use Eye Tracking so the user is also able to scroll over text using ET inside the same window.
As far as I know we can't use both system at the same time right now with MRTK v2

@sostel in case there's been some research in this

Hey @Jordu29, interesting! Is there a reason why you don't want to use the EyeGazeCursor to dwell?
In any case, the question came up a few times to use some form of head gaze + eye gaze: @wiwei Does MRTK support this?

Hey @Jordu29, this is not something that's currently supported in MRTK v2. After speaking with @Zee2, it is something that would be easy to support in MRTK v3. Given that this is an old issue and we haven't heard back from you, I'm going to close this request. Feel free to reopen if you would like to see it in MRTK v3.


Only changing BF's note colors

What is your question?
Is there any way to only apply the note colors to BF only ? Or just detect which character's note is it ?

use the mustPress var in note like this, note.mustPress depending on what you named the note var

Should it be use with an if, or in some different way ?
Since the notes are colored upon being created

yea if statement

I'm guessing the note var is called "this"

It works fine
At least with the notes
Now I kinda need to figure out how to do the same with the Strums

It works fine
At least with the notes
Now I kinda need to figure out how to do the same with the Strums

look in the StrumNote class, and btw, install the Haxe extension for vsc

I'm not sure on what and where to use

This didn't work

I'm not sure on what and where to use  This didn't work

that's just the same thing

what you would do is check if (player == 1)

It works perfectly
Final question, is it possible to only change the colors on specific textures ?

yes, if (texture == 'inserttexturehere')
note it’s case sensitive


docs(contributors): fix typo in the test

Description:
Just a typo in the test
Related issue (if exists):

Coverage remained the same at 96.747% when pulling 13b04caff44510fda34dbe022a5a3f4105418460 on Teamop:fix-typo into 3b290ea76e76ef66f9d0c641d4db0da53a9cbaea on ReactiveX:master.

Thank you, @Teamop!


Running script

If i run the script with "npm run dev" it doens't do anything what did you use to run the bot?

This script is old. And this repo will be archived.


city.py:23: Перенести классы в отдельные файлы 29

The puzzle 899-2849d15c from #899 has to be resolved:
https://github.com/blablatdinov/quranbot-aiogram/blob/512a045fe275c3fe0c3ab6ddd71d6654bb7c40d7/src/srv/prayers/city.py#L23-L23
The puzzle was created by Ilaletdinov Almaz on 09-Jun-24.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

All classes moved #899


Cloud documentation reorganization

Restructuring documentation to add Cloud docs and reorganize admin guide.
Jira: https://mattermost.atlassian.net/browse/MM-29596

@amyblais, this content has all been copied over from our existing content. Minor changes to the content have been made, such as removing reference to "versions prior to 5.12" and some formatting fixes (which I submitted in PRs for this repo. So it's not 45+ files of new content. :)

Some of the pages like cloud billing, cloud reporting, and cloud compliance look a bit empty, but I assume these will be filled in the future? Just want to confirm before approving the PR.

@justinegeffen Let's copy in this page for reporting: https://mattermost.github.io/docs/justinegeffen/administration/statistics.html
@amyblais The PR for the billing page is here: https://github.com/mattermost/docs/pull/4056.  Compliance is filled out for me.

Some of the pages like cloud billing, cloud reporting, and cloud compliance look a bit empty, but I assume these will be filled in the future? Just want to confirm before approving the PR.

We're going to be moving that today so I'll let you know when that's done. :)

@amyblais, I've removed the empty compliance file and we've done some more editing (removing content, and adjusting headings). If you have the bandwidth for a review that'd be great. :) We plan to merge this asap and then continue working on the docs.

I don't see content for /cloud/cloud-administration/create-new-workspace.rst.
Also, a few pages are duplicated such as cloud-incoming-webhooks.rst and incoming-webhooks.rst, and cloud/mobile-apps-faq.rst and cloud-mobile/mobile-apps-faq.rst.

@amyblais  I will edit post merge and ensure we have all the missing pages.


Better render footer, when copyright is set clear author message.

Hi, @ryanfox1985
What is the goal of these changes? They kill designer's copyright when copyright is set in config file, you know? :smile_cat:

Hello @aerohub, yes I'm removing the author sentence when a copyright is set. I think that the resume is serious and I don't want a heard on the bottom.
Anyway I keep the designer html comment.
Regards.

Well, @ryanfox1985  I think everyone who can use git and install Hugo knows many ways how to break designer's heart  :smile: The theme was made for my training and used in official themes showcase as a demo of Hugo features. Nothing else. Let everyone who use it as a resume, deside the heart problem himself. I can't merge your PR but can keep it as an example how to do it in a good way.


xgboost very slow for classification with many classes

Environment info
Ubuntu
Compiler:
gcc
Package used (python/R/jvm/C++):
python
xgboost version used:
0.6
If installing from source, please provide

The commit hash (git rev-parse HEAD)

git rev-parse HEAD
3dcf966bc3e3f0a1484e8ddaf8374cbdb9b032f2

Logs will be helpful (If logs are large, please upload as attachment).

If you are using python package, please provide

The python version and distribution

Python 3.5.2

The command to install xgboost if you are not installing from source

Installed from source
Steps to reproduce
Run the following  self contained code which also creates fake data for classification with 120 classes:
#!/usr/bin/python3

from sklearn.datasets import make_classification
from xgboost import XGBClassifier
from sklearn.ensemble import RandomForestClassifier
from time import time

(trainX, trainY) = make_classification(n_informative=10, n_redundant=0, n_samples=50000, n_classes=120)

print("Shape of trainX and trainY", trainX.shape, trainY.shape)
t0 = time()
rf = RandomForestClassifier(n_estimators=50, n_jobs=-1)
rf.fit(trainX, trainY)
print("Time elapsed by RandomForestClassifier is: ", time()-t0)
t0 = time()
xgbrf = XGBClassifier(n_estimators=50, n_jobs=-1,verbose=True)
xgbrf.fit(trainX, trainY)
print("Time elapsed by XGBClassifier is: ", time()-t0)

What have you tried?
The RandomForestClassifier takes about 15 seconds but xgboost never terminates at all for me even after 10 minutes.

XGBoost uses regression trees, so build 120 (=num_class) trees per iteration.
That issue will be helpfull.
https://github.com/dmlc/xgboost/issues/2926

@marugari
Does this mean xgboost will always be slow for multi class classification?
You accidentally linked back to this issue in your comment (2926). Did you mean to link to another one?

@lesshaste Sorry, I fix the link.

There is an inefficiently in prediction caching that results in nclass^2 complexity https://github.com/dmlc/xgboost/issues/1689#issuecomment-278872489
I didn't yet get to fixing it, as I didn't really have any practical need for so many classes, but I will.

That would be awesome! Thank you.

This recent paper might be another potential solution to increase multiclass speed.


fixed typo

Thank you :) However I'm not merging because I'm going to be removing both the river and alacritty packages.

Thank you :) However I'm not merging because I'm going to be removing both the river and alacritty packages.


Dissmiss Sheet NewBill

Dismiss Sheet when creating new Bill
-> Pass Boolean from List View / Main View to change it in NewView

Fetch all Bills when dismissed


file is too big?

is this a bug or my mistake?

Where do you upload? In admin? In frontend form?
Check form plugin setting: max filesize.

in admin

any tips？

There's a grav config in system: grav.config.system.media.upload_limit

I cannot set this in admin plugin? Why?
In my usr/config/system.yaml the value for media upload_limit is: 2097152. ???
Is this the standard setting?

seems the config is 1G, but the limit still 256Mb, a bug?

Actually the system media.upload_limit option has been removed, even though there's still some places in the code that uses it if set.  There is still a reference in forms for via files.filesize, this defaults to 0 unlimited, but it's possible you have this set?

Still documented as if I could set this in admin panel:

Ok, I've dug into this quite a bit and it gets complicated....
  Not to mention the default PHP values for post_max_size and upload_max_filesize.  These were all used in various places, but ultimately the PHP values are the hard-stop-limits.
Back in October of 2017 (Grav 1.3.7), this was simplified by removing the actual option for system.media.upload_limit, creating a method in Utils to get the system PHP values, and overriding any existing configuration settings for system.media.upload_limit with the smallest value provided by PHP settings. It was done this way to minimize the impact of changing the functionality mid-release cycle, so the old value could still be used, by plugins (admin, form, etc) but would use PHP provided values.
In the Grav 1.6 branch, I've now cleaned this up and completely removed all references to system.media.upload_limit and explicitly used the Utils::getUploadLimit() function to make this clearer going forward.  Admin and Forms plugins have also been updated in their respective RC branches in the same way.
I'm testing all this with Grav 1.6, so there well may have been other fixes between this and Grav 1.5, but as I'm trying to get 1.6 out ASAP, I'm putting my focus there and not in 1.5 at the mo.
The basic rules are:

In Admin plugin, the filesize limit in File and PageMedia fields is limited by the PHP settings alone.
In Form plugin, the filesize limit in File field is limited by the field setting of filesize: if set, then the form.file.filesize if set and not 0, then the PHP settings.

I'm sure this will all be sorted when Grav 1.6 is released.

after updating to 1.6 today file upload in the admin panel doesn't work anymore:  despite the maximum filesize is set to 2048M in the php.ini, which also the info-tab recognices, when trying to upload a file I get a NEGATIVE maximum file size;

how to fix this? never had any problem with 1.5

Strange one, might need to get a copy of you php.ini and your Grav system.yaml

Also is this with a Page media upload or some custom form you have?

Ah, page media sorry not to mention it - form would be easy because there is an option for the upload size (page media worked with 1.5 also without problems when there was the option for it). The file is just a jpg (1920x1440px, 490kb), server is apache with php 7.2 fpm - please find attached the ini and yaml, please let me know if you need anything else.
php.ini.txt
system.yaml.txt

@lorddoumer if you inspect you can fire up your browser developer tools, and inspect the Page Media element, you should see this

 element.  In there is a data-dropzone-options that contain some settings.  One of those is the maxFilesize in megabytes.  What does yours look like?

Yes, there it is - and it has the same strange value:

Where does this coem from?

I think it has something to do with the rounding logic.  can you try replacing the Utils::parseSize() function with this:
    public static function parseSize($size)
    {
        $unit = preg_replace('/[^bkmgtpezy]/i', '', $size);
        $size = preg_replace('/[^0-9\.]/', '', $size);
        if ($unit) {
            return round($size * pow(1024, stripos('bkmgtpezy', $unit[0])));
        } else {
            return round($size);
        }
    }

@rhukster that's it, upload working fine again, thanks! :)

Sweet, should be in the next release later today.

Still having the same issues with Grav 1.6.8 and PHP 7.3
Tried also with a newly installed Grav, so I think the problem is maybe somewhere at my end. Should I take care about a special php setting beside upload_max_filesize or post_max_size?
Thank you in advance!

What values do you have set for those in php.ini?

upload_max_filesize 16G
post_max_size 0

I just can't replicate what you are seeing with those values.  I get "maxFilesize":0
Can you try changing your values to sane ones?  like:
upload_max_filesize = 256M
post_max_size = 512M

Does that fix things? or do you still get weird negative numbers?

Another thing to try.  In user/plugins/form/classes/Form.php, replace the getMaxFilesize() method with this:
    public static function getMaxFilesize($mbytes = false)
    {
        $config = Grav::instance()['config'];

        $system_filesize = 0;
        $form_filesize = $config->get('plugins.form.files.filesize', 0);

        $upload_limit = Utils::getUploadLimit();
        if ($upload_limit > 0) {
            $system_filesize = intval($upload_limit / static::BYTES_TO_MB);
        }

        if ($form_filesize > $system_filesize || $form_filesize === 0) {
            $form_filesize = $system_filesize;
        }

        if ($mbytes) {
            return $form_filesize * static::BYTES_TO_MB;
        }

        return $form_filesize;
    }

See if that helps?

Thank you!
The modded function did not work, but I changed the value of post_max_size from 0 to 512M. Now it is working perfectly!


[FSDE-4561] Migrate Alert component to new Vue documentation

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/1/. :white_check_mark:

You can check this PRs instance in https://3410dd521cd2f3fa7cce0285d1bcca03a3d43bae-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/2/. :white_check_mark:

You can check this PRs instance in https://921bbf6d6d995b2c775688b78c0390db8be10f9f-chi-pr.enterprise.ctl.io

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/3/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/4/. :white_check_mark:

You can check this PRs instance in https://f4e1e9fc19bdf747fc8757f1982325d3a78787c4-chi-pr.enterprise.ctl.io

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/5/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/6/. :white_check_mark:

You can check this PRs instance in https://0541e88223cfd644a4ffa1b17f465a04679ee74c-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/7/. :white_check_mark:

You can check this PRs instance in https://c09b79b3668cd1037c3e305560e5d8d4c1807d52-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/8/. :white_check_mark:

You can check this PRs instance in https://082e2372db87d8c00b9adaf82e1d77c5ffb8d2ac-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/9/. :white_check_mark:

You can check this PRs instance in https://a422a556756693eddd54213ec878974ba11821b2-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/10/. :white_check_mark:

You can check this PRs instance in https://2600c4053d8263bd16f960af4f7ae7ce26c12c8b-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/12/. :white_check_mark:

You can check this PRs instance in https://bc92defa56f637b11a3d0202430882886c23670e-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/13/. :white_check_mark:

You can check this PRs instance in https://790fad9be1b75c26cda99e4cf1b99ce768936d48-chi-pr.enterprise.ctl.io

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/14/. :x:

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/15/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/16/. :white_check_mark:

You can check this PRs instance in https://2770423750c049949df0d82a3425bf9725497bd6-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/17/. :white_check_mark:

You can check this PRs instance in https://32204c30f380f4d8bd90ba5d90ac0e2a1d9543ef-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/18/. :white_check_mark:

You can check this PRs instance in https://d72d91f145ed39471c4279b5625436a45f05c593-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/19/. :white_check_mark:

You can check this PRs instance in https://3458b24fb458c7c32ea241621f8ae0f8a2dd9089-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/20/. :white_check_mark:

You can check this PRs instance in https://71c1ee5e97130dd3f6c47e0e92ac790ab5e132a6-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/21/. :white_check_mark:

You can check this PRs instance in https://419eca8bc19443af05c23d4b0b5b48e726c957da-chi-pr.enterprise.ctl.io

You can check this PRs instance in https://dc0e9d2051960575a02d2a10040287525c092c5e-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/24/. :white_check_mark:

You can check this PRs instance in https://86c1712498d7080dc5d0a569f7bf70db30987dfe-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/25/. :white_check_mark:

You can check this PRs instance in https://6416b16bb3dcbde0a82887a82c9d931ca9671690-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/26/. :white_check_mark:

You can check this PRs instance in https://d856ed78d66b4a5f28b8dfbff752e6023582e0a4-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/27/. :white_check_mark:

You can check this PRs instance in https://c3f8137e12d9597eed45117b0783d5980c3159d0-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/28/. :white_check_mark:

You can check this PRs instance in https://7055430ce9f3b16b4d175a1283d9dcdb1b538ae2-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/29/. :white_check_mark:

You can check this PRs instance in https://af82f110752b3d82511607d8d02f37d43b79aff1-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/30/. :white_check_mark:

You can check this PRs instance in https://b2a5bb5a9ca28c18aa4e0ee1a225432e957e3887-chi-pr.enterprise.ctl.io

You can check this PRs instance in https://6c4c5bce957117b98dc0b96744fea0da7cff9744-chi-pr.enterprise.ctl.io

You can check this PRs instance in https://3a7dbd54ac7a51a2f6a1b668891b1b6ad7442ab0-chi-pr.enterprise.ctl.io

You can check this PRs instance in https://6ca2b8a6b0cc98eced9e4ab1af1fd318c452cc3e-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/39/. :white_check_mark:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/40/. :white_check_mark:

You can check this PRs instance in https://2b075e719cca2585c8c28228d5584b0e3c4e0962-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/43/. :white_check_mark:

You can check this PRs instance in https://343d0c1363d48e8a7f861337813b60169197f8e9-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/45/. :white_check_mark:

You can check this PRs instance in https://f3248e3139f59ede0fdb70c9acc38202750c3925-chi-pr.enterprise.ctl.io

You can check this PRs instance in https://8ef5d579482e1c767ee04eb6c401e4f70d9b2926-chi-pr.enterprise.ctl.io

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/63/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/64/. :white_check_mark:

You can check this PRs instance in https://0f037b7c7ec87754759806de49997e50c3673410-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-171-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/65/. :white_check_mark:

You can check this PRs instance in https://e54a14faf8975674c25eb5b5677023b6b2c84971-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-171-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/66/. :white_check_mark:

You can check this PRs instance in https://e54a14faf8975674c25eb5b5677023b6b2c84971-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-171-ux-chi.kubeodc-test.corp.intranet/ (internal)

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-171/67/. :white_check_mark:

You can check this PRs instance in https://0a127b92dfdb9a8fb59148a7bd3fff928e96e971-chi-pr.enterprise.ctl.io (external) and in https://nginx-pr-171-ux-chi.kubeodc-test.corp.intranet/ (internal)


File Diff Colour

File diff is fabulous; I can see it being one of those essential plugins.  (Previously, I was comparing files outside of Obsidian.)  A minor question: is there any way to adjust the colour of the changes.  I tend to work in a dark theme and blue is washed out.

Thank you very much for your kind words! I released a new update with which you can easily update the colors.
To do this, you need to follow these steps:

Create a new CSS file in the folder .obsidian/snippets, e.g. file-diff.css.
Fill the CSS file with the following and update the colors accordingly:

@media (prefers-color-scheme: light) {
	.file-diff__top-line__bg {
		background-color: #d9f4ef;
	}

	.file-diff__bottom-line__bg {
		background-color: #d9edff;
	}

	.file-diff__button-danger {
		background-color: #b00020 !important;
		color: #ffffff;
	}

	.file-diff__button-danger:hover {
		background-color: #9f0020 !important;
		color: #ffffff;
	}

	.file-diff__action-line {
		color: #919191;
	}
}

@media (prefers-color-scheme: dark) {
	.file-diff__top-line__bg {
		background-color: #25403b;
	}

	.file-diff__bottom-line__bg {
		background-color: #25394b;
	}

	.file-diff__button-danger {
		background-color: #cf6679 !important;
		color: #ffffff;
	}

	.diff__button-danger:hover {
		background-color: #b85a6d !important;
		color: #ffffff;
	}

	.file-diff__action-line {
		color: #919191;
	}
}

Activate the CSS file in the settings under Appearance.

Absolutely fantastic and I discovered it works in real time as I type, so it basically a track changes that is very simple and useful to use. Thanks so much!

I was able do what I wanted with this snippet. Is it OK?
@media (prefers-color-scheme: light) {
.file-diff__top-line__bg {
background-color: #e6f5f2;
border-radius: 0.25rem; /* 4px */
}
.file-diff_top-line__character {
	background-color: #67c9f0;
	border-radius: 0.25rem; /* 4px */
	text-decoration: underline;
}

.file-diff__bottom-line__bg {
	background-color: #ecf6ff;
	border-radius: 0.25rem; /* 4px */
}

.file-diff_bottom-line__character {
	background-color: #f76767;
	border-radius: 0.25rem; /* 4px */
	text-decoration: line-through;
}

}

One last thing. When I run the command file dff: compare and choose a file, in the compare window I see my initial file at the bottom and file I asked to compare at the top. Personally I would prefer to see the file I start the command from at the top and the file I asked to compare at the bottom. Is there any way to achies this?


Test, clean up archive/CleanFilePath, getStrategy

This is a simple changeset removing an excess filepath.ToSlash call from archive.CleanFileName, also bringing over tests from the stdlib filepath package to verify no change happened in that removal.
It also adds tests for archive.getStrategy, and uses a map for archive strategy strings.

:+1: LGTM, merged! Thanks for the contributions :)

I'm seeing some test failures on Linux & macOS, maybe that ToSlash wasn't unnecessary after all :)

Perhaps, I tested on windows.

I pushed a version that doesn't rely on path/filepath at all, so we get behavior that's consistent across platforms 🌟


Automatically run CI test jobs for every pull request.

Objective
Automatically run CI test jobs for every incoming PR.

Details
→ Please read this conversation in PR #394.

Expected Outcome
→ Please see this mock-up PR on martin-chatterjee/Qt.py.

Tests all run. :) Nice, thanks @martin-chatterjee


s3upload giving RangeError

RangeError: Maximum call stack size exceeded
    at clone (/home/<user>/<folder>/node_modules/rfdc/index.js:37:18)

we are facing issue in deploying image upload to s3bucket,
do we need to configure the size limit or any other configuration to upload file directly to s3bucket.

@DanRibbens @jmikrut can you please suggest
we are using node v18.8.0, will that be problem.

Hi @DanRibbens
Thanks for your reply!
Have installed
yarn add @aws-sdk/client-s3
yarn add @payloadcms/plugin-cloud-storage

Current version:
"@aws-sdk/client-s3": "^3.159.0",
"@payloadcms/plugin-cloud-storage": "^1.0.8",

Nodejs v18.8.0
Payload  v1.0.31
In payload.config.ts
import { cloudStorage } from '@payloadcms/plugin-cloud-storage';
import { s3Adapter } from '@payloadcms/plugin-cloud-storage/s3';

const adapter = s3Adapter({
  config: {
    endpoint: process.env.S3_ENDPOINT,
    credentials: {
      accessKeyId: process.env.S3_ACCESS_KEY_ID,
      secretAccessKey: process.env.S3_SECRET_ACCESS_KEY,
    }
  },
  bucket: process.env.S3_BUCKET,
})

  plugins: [
    cloudStorage({
      collections: {
        'media': {
          adapter,
        },
      },
    }),
  ],

after this
https://github.com/payloadcms/plugin-cloud-storage/blob/master/dev/src/collections/Media.ts
Added Media.ts in the collection, and in plugin.config.ts
after that we are getting below error in terminal
    at copyBuffer (/home/<user>/<folder>/node_modules/rfdc/index.js:6:19)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:56:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)
    at clone (/home/ubuntu/cms.r.web/node_modules/rfdc/index.js:58:17)

just guide us if we missed any step or which package version to use

Hi all,
the trick was to pass forcePathStyle = true
const adapter = s3Adapter({
  config: {
    forcePathStyle: true,
    endpoint: process.env.S3_ENDPOINT,
    credentials: {
      accessKeyId: process.env.S3_ACCESS_KEY_ID,
      secretAccessKey: process.env.S3_SECRET_ACCESS_KEY,
    }
  },
  bucket: process.env.S3_BUCKET,
})

What if I don't want have path style URLs for my S3 objects? I doesn't seem a valid solution

This resolved the issue for me but i'm not 100% sure why or what's going on. Does anyone have the time to shed some light and should it be included in the readme?

I got the same issue and I definitely think this should be looked into more throughly. I got a 404 response from the following link in the console - http://localhost:3000/api/media?locale=en&depth=0&fallback-locale=null
Could it be some kind of issue with the callback after the upload?
There was an error while uploading files corresponding to the collection media with filename 3.png:
[09:19:20] ERROR (payload): RangeError: Maximum call stack size exceeded
    at Function.from (node:buffer:301:28)
    at copyBuffer (/Users/user/Desktop/folder/node_modules/rfdc/index.js:6:19)
    at clone (/Users/user/Desktop/folder/node_modules/rfdc/index.js:56:17)

@ktra99 can you please install latest version of payload and @payloadcms/plugin-cloud-storage and try again.


VSCode icon on OS X is not transparent

I notice that the VSCode icon on OS X is not transparent in the center between the lines. I guess this breaks with Apples design line guide for OS X?

I have the same issue on my machine.

When the areas between the lines are transparent, then you cannot click in these areas, which is not desirable.
CC @weinand does this violate Apple's design guide lines?
@bgashler1 fyi.

The HIG says this about icons on OS X: "Use transparency when it makes sense."
On my Mac i can start apps by clicking on the transparent portion of their icons, even if it's in the center like yours.
Examples are the Monogame Content Pipeline app (uses the MonoGame icon) or Kaleidoscope:

The icon is the same across all OS. I think this is designed intentionally like this.

Visual Studio 2015 updated the icon with a white outline, which also included the inner white space. VS Code adapted it.

@Sankra I think it would make sense here. The icon looks kind of strange next to the other programs in my dock (like VMWare Fusion and MonoGame).

Thanks for your concern.  We originally designed the icon this way to match the Visual Studio family (and because transparency traditionally caused problems with clicking the icon--although it's not an issue anymore).
Since this icon doesn't violate Apple's icon design guidelines, and because the scope of this issue is related to Mac OS X (and our icon is shared across all platforms) this issue would be better discussed on UserVoice.  We would definitely want users of Linux and Windows to have their say before we changed anything.  Please feel free to lead a discussion, and we'll be monitoring the feedback.

can't it be png based now? even the windows ico can be. then the insides could just be 99% transparent to retain clicking.
also I have never experienced any os making the transparent parts unclickable.

@bobmajdakjr Thanks for sharing this.  We are addressing this and other icon related issues in an upcoming release.

In case someone still wants this icon with transparency:
Browsing through issue #35783 I found someone has made this icon.
Link to repo containing the file: https://github.com/1l0/logo/tree/master/vscode
Direct link to file: https://raw.githubusercontent.com/1l0/logo/master/vscode/vscode.png
You can follow this SO link to change application icons on mac: https://superuser.com/questions/37811/how-can-i-change-an-application-icon-in-mac-os-x


feature request: adjustable recursive level

Hi Steve,
It will be good if the broken-link-checker has an option to specify the recursive level ranging from 0 to some number. Currently the app seems to run into infinite recursion and sometimes some websites are super big and checking the links in some 100th recursive level doesn't makes sense most of the time because an user mostly never gets such deep into a website. I used the recursive option and for my website(which is huge) and it seems to run for almost 3 days and still haven't finished the job.
Thanks,
Jeb

Interesting. A temporary solution would be to hit your site harder—if it can take it—with options.maxSocketsPerHost.

That makes sense. Thank you!


[4.0] PhysicalBone3D seems to ignore mass

Godot version
4.0.beta3
System information
Windows 11
Issue description
When I attached an object to a PhysicalBone the mass setting on the PhysicalBone seems to be ignored, so if the PhysicalBone hits another physics body with a heavier mass it still sends it flying as if the mass was 0 on the other body
Steps to reproduce
Create a Rigidbody3D character with a Skeleton and attach a PhysicalBone3D to a hand slot, then move the character about and the collision shape on the PhysicalBone will not colide with other objects as with the mass assigned.
I used a KayKit Character for my tests.
Minimal reproduction project
No response

Can you reproduce this in 3.5.1?

ok I have uploaded a basic project, you can use WASD to move the character, if you hit the box with the character the mass works and the box does not move much, if you hit the box with the weapon that is attached as a physical bone the mass does not seem to have any affect?


Grammatical error

[ x] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #fd9f110

LGTM

@MattSchwartzkopf Thanks for the PR.
I prefer inclusion of the word "that". It is more clear non-native English speakers, even though some people may argue that "that" can be omitted. I used to be in this camp, but I now say "so that"


Add /homes to Essentials disabled commands

/homes is rendered useless along with all the other commands from essentials

this is the second PR in 24h I’ve received updating this file in the docs. which is weird. Have you tested this? I think /homes is just an alias of /homelist which is already disabled in this file; hence this PR would have no effect

I'll do some more testing to be sure, but before I added it to the list I would type /homes and it would do /homelist and say I have no homes in essentials even though /homelist was disabled.

This is with /homes not disabled. It runs the essentials /homelist


Potions ending in II

What is your Quests version / build number (do not say "latest")?
5.0.3-b474
Describe the problem and how to replicate it.
Any quest that has a potion with a II (Healing II, Swiftness II, etc.) with the Consume objective will not appear. It appears when tasking to brew, but not other objective types.

Any console errors to share?
n/a

If applicable, can you provide an example quest from quests.yml?
'000168':
    name: Healing Alchemist
    ask-message: '        &x&e&9&9&8&2&0&l⭐ &x&f&f&d&5&7&e&l<quest> &x&e&9&9&8&2&0&l⭐'
    finish-message: '&8&l[&x&7&6&8&b&f&5&lBOT&8&l]&r &fTake another quest with &x&f&f&d&5&7&e&l/quests&f!'
    stages:
      ordered:
        '1':
          items-to-brew:
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:healing
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:strong_healing
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: SPLASH_POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:healing
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: SPLASH_POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:strong_healing
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: LINGERING_POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:healing
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: LINGERING_POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:strong_healing
          start-event: 24HrTimer
        '2':
          items-to-consume:
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:healing
          - ==: org.bukkit.inventory.ItemStack
            v: 3700
            type: POTION
            amount: 9
            meta:
              ==: ItemMeta
              meta-type: POTION
              potion-type: minecraft:strong_healing
          start-event: 24HrTimer
    rewards:
      money: 15000
      quest-points: 1
      custom-rewards:
        req1:
          name: mcMMO Overhaul Skill Reward
          data:
            Skill Amount: '5'
            Skill Type: Alchemy
    planner:
      cooldown: 604800
      override: false
    options:
      allow-commands: true
      allow-quitting: true
      ignore-silk-touch: true
      use-parties-plugin: false
      share-progress-level: 1
      same-quest-only: true
      share-distance: 0.0
      handle-offline-players: false
      ignore-block-replace: true

@HorusApl Please try https://ci.codemc.io/job/PikaMug/job/Quests/498/
You will either need to regenerate your /lang folder or at least update the consumeItem string.


Understanding scopes not up-to-date

ng-view

TBD, but I think it acts just like ng-include.

Shouldn't it be determined already?

It's actually pretty mind-boggling that the Wiki is a parallel docs project to the official docs. We should really try to bring these two together. I'll open a new issue for that.

@Narretz can you link to that issue?

@ilanbiala https://github.com/angular/angular.js/issues/12140
If you want to help, we can work something out.


Update kubernetes objects to v1 APIs

Just got an email from Google Cloud about the fact that with Kubernetes 1.22 some APIs will be deprecated and that we might  be using them for mybinder.org on GKE.
This issue is about finding and then upgrading the objects that still use v1beta or v1alpha versions and moving them to v1.
https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-22 is a list of all the APIs that will be deprecated in v1.22.

We need a K8s equivalent of pyupgrade..... in the meantime https://github.com/FairwindsOps/pluto sounds useful, it's meant to identify files using a deprecated APIs

Our GKE cluster is currently on 1.19. Not as sophisticated as pluto but was quick to do:
$ cd helm-chart/binderhub
$ grep -Ri beta .
./templates/pdb.yaml:apiVersion: policy/v1beta1
./templates/ingress.yaml:{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1beta1" }}
./templates/ingress.yaml:apiVersion: networking.k8s.io/v1beta1
./templates/ingress.yaml:apiVersion: extensions/v1beta1

Looks like the ingress template already has some code to add backwards compatibility/deal with naming differences. v1.22 related changes.
Couldn't find PDBs in the list of deprecated APIs.

We don't need to upgrade all resources to v1, only some.
The resources we use within the binderhub helm chart that may need an update, are the following:

The Beta API version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding is no longer served as of version 1.22. Migrate manifests and API clients to use the rbac.authorization.k8s.io/v1 API version.

The Beta API versions (extensions/v1beta1 and networking.k8s.io/v1beta1) of Ingress is no longer served as of version 1.22.

The pattern of updating them I've applied in z2jh and seen other Helm charts adopt, is examplified by https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/1983.
Catching errors in the CI system if we have a too outdated resource can be done in two ways with native tooling.

helm template --validate
It will render templates, but then send them to the k8s api-server and see if it considers them reasonable. If the k8s api-server is of a version that accepts those templates, then its fine, otherwise it will error. By testing against the newest version, we catch this kind of errors, and by following the kind of practice demonstrated inhttps://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/1983, we avoid causing issues with older versions.
helm lint --strict
Helm lint --strict will error on warnings, and it will warn if we have rendered templates that has been deprecated. But, at the same time, if you are using helm lint to render templates that won't interact with a k8s api-server, the logic added in https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/1983 is influenced and we end up with trouble in practice. Due to that, I've made Z2JH stick to using the helm template --validate approach as I couldn't get the helm lint--strict to work properly.

Issue related action points

[ ] Update all RBAC + Ingress resources to v1 if supported by the current k8s version, as examplified via https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/1983 where one can see some adjustments may be made to the structure of how things are specified within a resource.
[ ] Run tests against the latest k8s version we error on outdated resources being generated by the helm chart.
This was proposed in #1392.
[ ] Run helm template --validate with a config that generates all relevant resources. We currently miss out on generating the Ingress resource as we don't use it, but we should generate one anyhow to catch issues like generating an invalid Ingress resource.


LTD-5014 tidy up denial search strings

Aim
Removed commas from Denials search data as it was creating false positives and seeming to include stop words in the highlighted fields
LTD-5014

closed and put back in to do based on possible changes to search query formview


Supported html placeholder in a transport rule

Hello,
I came cross this article specifically the following parameters:
-GenerateNotification
-ApplyHtmlDisclaimerText
For -GenerateNotification it's clearly mentioned:
This parameter supports plain text, HTML tags and the following keywords that use values from the original message:
%%From%%
%%To%%
%%Cc%%
%%Subject%%
%%Headers%%
%%MessageDate%%
Now for -ApplyHtmlDisclaimerText when I try to add a html code with a placeholder %%From%% or %%FromAddress%% or %%Email%% to generate a disclaimer that is supposed to pull out the sender's address from the original message and add it to a text ( then Prepend the disclaimer) the GUI is returning this error:
System.ArgumentException|The disclaimer text contains an invalid macro name: 'From'.
This is the full error when I try to save the transport rule:

Can you please update the documentation with what is exactly supported for -ApplyHtmlDisclaimerText ?
BR
Ribo

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 11bf4f19-ce5b-b13a-7c93-c627cd49cc35
Version Independent ID: 17e31a5a-7b8f-9139-c2c4-4a819e2cde7e
Content: New-TransportRule (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/New-TransportRule.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@riohedfield, I wouldn't make the leap that because those special tags are OK with GenerateNotification that they're also OK with  ApplyHtmlDisclaimerText, especially since the parameter description makes no such claim. I get the same error when I tried creating the disclaimer rule in the EAC, so those special tags must not be allowed.

@chrisda thanks for replying, what you just mentioned is what I already discovered, but my whole request is about to have the documentation updated with what exactly works so we don't have to guess or waste time on testing whatever comes my mind. Is it feasible?
Thank you :)

@riohedfield, I can confirm that none of those special tags work. Beyond that, I know no more than what the description says:

Disclaimer text can include HTML tags and inline cascading style sheet (CSS) tags. You can add images using the IMG tag.

@chrisda sorry but you're not answering my request.
Let's start from this one that I've tested and works:
%%DisplayName%%
So what else works besides this one? What else can be used as html tags/placeholders ... in ApplyHtmlDisclaimerText when creating a transport rule?
I hope my request is clear now.
It would be really helpful to have it documented.

@riohedfield, I completely understand what you're asking for; I just didn't know where or how to find an answer other than suggesting that you open a support ticket and ask there.
But, thanks to your revelation about %%DisplayName%% (which wasn't even listed as a valid value for GenerateNotification!) through some chicanery and dark arts, I was able to find the following list:

%%City%%
%%Company%%
%%CountryOrRegion%%
%%Department%%
%%DisplayName%%
%%Fax%%
%%FirstName%%
%%HomePhone%%
%%Initials%%
%%LastName%%
%%Manager%%
%%MobilePhone%%
%%Notes%%
%%Office%%
%%Pager%%
%%Phone%%
%%PostalCode%%
%%PostOfficeBox%%
%%StateOrProvince%%
%%StreetAddress%%
%%Title%%
%%UserPrincipalName%%
%%WindowsEmailAddress%%

I was able to create a new transport rule using all of those values.
OK?

@chrisda Awesome! and thanks a lot, can we make that list official and update the documentation with it? Or if they are in a different Microsoft article maybe you can add the reference url in a note or right under the current parameter (ApplyHtmlDisclaimerText) description?
The article will be much better and understandable if we know what that parameter supports.

Yes. Documentation updated in multiple places (see links automatically added to this issue).

Thank you so much @chrisda, have a great day.


Opa on aws plugin

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thanks for adjusting - please make sure to sign your commit:)


Bump expensify-common to fix phone number mention

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/40969
PROPOSAL: N/A
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/88395093/1fa29c25-8751-4b78-a8fe-22d8abafd4be

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/88395093/c3a09734-eabe-451f-9ec0-2eba16dedcc3

MacOS: Desktop
https://github.com/Expensify/App/assets/88395093/7b10be95-d36f-4cc7-8f82-196ac441a8ae

@SzymczakJ why you push Podfile.lock updates, I think this PR shouldn't update it.

It got updated along with updating expensify-common so I automatically added this to this PR, but you are right that it's not the scope of this PR, so I will remove it 😄

Unfortunately when testing iOS I noticed something is broken with expensify-common and I don't have time to look at this today, because I have to go already. What's more, the whole Software Mansion will be OOO at Thursday and Friday because we have bank holiday in Poland. Is it alright with You that I will finish this PR on Monday? It will be my priority to finish this ASAP 😅

@SzymczakJ No problem.

@SzymczakJ Yeah this is correct, we should wait https://github.com/Expensify/App/issues/42161 to fix first before bump expensify-common because our version will push the reverted PR there.
But I think this maybe not block our test steps as our case not use the crash part.

go offline
send a mention
edit it

Are this steps crashed with you? If not, please revert edit Podfile.lock and let me test

This should be ready to test just as you say @ahmedGaber93. I will revert Podfile.lock and make it ready to test tomorrow morning!

@ahmedGaber93 expensify-common was bumped in some other PR and changes fixing phone number mention are already in Expensify App. I'm testing every platform to make sure everything works but I think we can close this PR and https://github.com/Expensify/App/issues/40969 issue

Yeah, it pushed here https://github.com/Expensify/App/pull/42387 to staging. We can close this PR now

@SzymczakJ bump for closing this PR.


[5.2] Fix bug by removing Mailer::setLogger() as it no longer available.

This has been removed since c289f9c but cause a regression bug
Signed-off-by: crynobone<EMAIL_ADDRESS>

Sorry about that. Giving the CI services a kick.

LGTM. :+1:


Add bitwise operations for UnsignedInteger

Description
This PR adds BitOr and BitXor along with BitAndAssign, BitOrAssign, and BitXorAssign implementations. Also a bits method − useful for calculating the integer logarithm of a number.
Type of change
Please delete options that are not relevant.

[X] New feature
[ ] Bug fix
[ ] Optimization

Checklist

[ ] Linked to Github Issue
[X] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

Codecov Report

Merging #423 (9a5c179) into main (dfd0066) will decrease coverage by 0.01%.
The diff coverage is 94.26%.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   94.30%   94.30%   -0.01%
==========================================
  Files          62       62
  Lines        8022     8176     +154
==========================================
+ Hits         7565     7710     +145
- Misses        457      466       +9

Impacted Files
Coverage Δ

math/src/unsigned_integer/element.rs
98.27% <94.26%> (-0.33%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


getActionButtons() fails for CustomTreeItems due to containers being undefined

I try to add a test for my extension that has a tree view. In the tree view I can access the tree and e.g. call getLabel().
But trying to get the action buttons fails with
Cannot read properties of undefined (reading 'isExisting')
imho accessed from here:
https://github.com/webdriverio-community/wdio-vscode-service/blob/54cb76ff746f01948dacca9cef8cd9209e827b42/src/pageobjects/sidebar/ViewItem.ts#L135
Used versions:
mac (arm)
wdio-vscode-service 4.0.5
VSCode v1.70.2 (vscode-darwin-arm64-1.70.2 stable)  and Chromedriver v100.0.4896.60
Any help appreciated!
(I tried the same/similar tests with vscode-extension-tester (just noticed that I tried it there with vscode 1.67.0) and can access the tree-view and trigger the action buttons without issues. But I'd prefer to use wdio-vscode-service as it seems to be magnitudes faster :-)

I tested with vscode 1.67.0 and it doesn't work either.

If I replace the function getActionButtons() with something like
const getActionButtons = async (itemElem: TreeItem) => {
  await itemElem.elem.moveTo();
  const container = await itemElem.elem.$(itemElem.locatorMap.TreeItem.actions as string);

  if (!await container.isExisting()) {
      return [];
  }

  const actions: ViewItemAction[] = [];
  const items = await container.$$(itemElem.locatorMap.TreeItem.actionLabel as string);

  for (const item of items) {
      const label = await item.getAttribute(itemElem.locatorMap.TreeItem.actionTitle as string);
      actions.push(new ViewItemAction(itemElem.locatorMap, label, itemElem));
  }
  return actions;
 };

I can get the ViewItemActions for it.
(They still don't offer a "click()" functionality but at least the label.)

twistie is not available as well. So it might be better to add the locators from TreeItem to CustomTreeItems (merge during constructor/decorator or use an array with [TreeItemLocator, CustomTreeItemLocator]?)

@christian-bromann any idea on this issue? Any hint on how to fix or preference/direction for a PR?

Unfortunately I haven't really used that PO yet so I have no recommendation here. I am happy to review/merge any PR that will make this section actually useable.

Ok. I'll try a PR with:

adding a tree view to the test extension
adding a test for it
adding a fix

Sounds awesome, thanks! Let me know if you have any questions or if I can help somehow.

Fixed in #39


Memory leak (only Windows)

Describe the bug
Memory leak on "Hello World!" infinite test.
To Reproduce
Run any "Hello World!" test on localhost.
Screenshots

Desktop:

OS: Windows 7 64-bit
Python: 3.8.10 64-bit
Version: master branch (2022-03-14)

Thanks for reporting I will take a look!

Checklist to me:

[ ] Check if it occurs on Windows 10 (Python 3.8, 3.9, 3.10, and 3.11)
[ ] Check if it occurs on Windows 11 (Python 3.8, 3.9, 3.10, and 3.11)
[ ] Check if is socketify or uWS leaking

Closed as duplicated https://github.com/cirospaciari/socketify.py/issues/115


Not including sources of libs which are not directly dependent of the app

While running nx run my-app:sonar it only includes libs which are direct dependencies of my-app.
For example if my-app has 2 libs lib-a and lib-b which are directly imported in my-app the command will only detect these 2 libs.
If these two libs further has dependencies scanner is not able to include them as dependent to analyze code. It should scan them too as they are also being used as dependency indirectly by my-app.
In actual application I have configured test to run with deps  when I'm running nx test my-app,  with  it shows 98 deps.
But with sonar I can see it only detect 32 direct Deps. Not detecting libs which are dependent of other libs which are not direct dependent.
```

nx : 14.1.9
@nrwl/angular : 14.1.9
@nrwl/cypress : 14.1.9
@nrwl/detox : Not Found
@nrwl/devkit : 14.1.9
@nrwl/eslint-plugin-nx : 14.1.9
@nrwl/express : Not Found
@nrwl/jest : 14.1.9
@nrwl/js : Not Found
@nrwl/linter : 14.1.9
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/nx-cloud : Not Found
@nrwl/nx-plugin : Not Found
@nrwl/react : Not Found
@nrwl/react-native : Not Found
@nrwl/schematics : Not Found
@nrwl/storybook : 14.1.9
@nrwl/web : Not Found
@nrwl/workspace : 14.1.9
typescript : 4.6.3
Community plugins:
@ngrx/effects: 13.1.0
@ngrx/entity: 13.1.0
@ngrx/router-store: 13.1.0
@ngrx/store: 13.1.0
rxjs: 6.6.7
@ngrx/schematics: 13.1.0
@ngrx/store-devtools: 13.1.0

@ak274 thank you for opening an issue. I will fix this 👍

@koliveira15 Any update on this issue. Without resolving this issue the plugin is not useful.

@ak274 Can you try version 2.0.1

after updating to latest version.
i'm facing this error while execution:--
ERROR: Error during SonarScanner execution
java.lang.IllegalStateException: Failed to parse JSON in SONARQUBE_SCANNER_PARAMS environment variable
at org.sonarsource.scanner.api.Utils.loadEnvironmentProperties(Utils.java:65)
at org.sonarsource.scanner.cli.Conf.loadEnvironmentProperties(Conf.java:88)
at org.sonarsource.scanner.cli.Conf.loadGlobalProperties(Conf.java:95)
at org.sonarsource.scanner.cli.Conf.properties(Conf.java:60)
at org.sonarsource.scanner.cli.Main.execute(Main.java:69)
at org.sonarsource.scanner.cli.Main.main(Main.java:61)
Caused by: java.lang.UnsupportedOperationException: Not a string: false
at org.sonarsource.scanner.api.internal.shaded.minimaljson.JsonValue.asString(JsonValue.java:384)
at org.sonarsource.scanner.api.Utils.loadEnvironmentProperties(Utils.java:61)
... 5 more
ERROR:


SERCOM.h: No such file or directory

Describe the bug
I´ve copy this script exactly as it is to my Arduino IDE, but when a try to upload it to my RTL8720DN, I get a message stating it is missing the library SERCOM.h. I tried all ways to install this library, no progress.
To Reproduce
Just try to compile or to upload this script exactly as it is to the module RTL8720DN through Arduino IDE.
Expected behavior
No compilation error nor any issue to upload the sketch to RTL8720DN.
Screenshots
Picture attached:

Desktop (please complete the following information):

OS: Windows 10
Arduino IDE: 1.8.15
Realtek Ameba Boards library: 3.0.9-build20210520

Smartphone (please complete the following information):
not applicable
Additional context
I´m trying to port some ESP32 codes to RTL8720, but I´m finding difficulties to this. The samples I´m need now are: WPS and SSDP, both of them avaible in Arduino IDE examples for ESP32, but not for RTL8720DN.

@mcavalcante  sorry, we don't have any experience with ESP32


[CXO-LORD] Distant Places T-LORD IGM Script Expander - Unable to load

Module Information

Identifier: CXO-LORD
Module Name: Distant Places T-LORD IGM Script Expander
Version: 1.1A

Describe the bug
MBBSEmu fails to load the module. It does not have a MSG file and fails with System.IO.FileNotFoundException during MCV compilation.
To Reproduce
Steps to reproduce the behavior:

Add Module.
Start MBBSEmu.

Expected behavior
Module loads.
Screenshots
2020-08-23 23:45:28.0158 Info MBBSEmu.Program.Run Loading cxo-lord
2020-08-23 23:45:28.0179 Info MBBSEmu.Module.MsgFile..ctor Compiling MCV from .MSG
Critical Exception has occured:
System.IO.FileNotFoundException: Could not find file '/mbbs/newsys/lorddp/.MSG'.
File name: '/mbbs/newsys/lorddp/.MSG'
at Interop.ThrowExceptionForIoErrno(ErrorInfo errorInfo, String path, Boolean isDirectory, Func2 errorRewriter)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String path, OpenFlags flags, Int32 mode)
at System.IO.FileStream.OpenHandle(FileMode mode, FileShare share, FileOptions options)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options)
at System.IO.File.ReadAllBytes(String path)
at MBBSEmu.Module.MsgFile.BuildMCV()
at MBBSEmu.Module.MsgFile..ctor(String modulePath, String msgName)
at MBBSEmu.Module.MbbsModule..ctor(IFileUtility fileUtility, String moduleIdentifier, String path, MemoryCore memoryCore)
at MBBSEmu.Program.Run(String[] args)
Software Information:

OS: CentOS 7.7.1908 / Case Insensitive FS

Creating a empty file named .msg in the same directory as distant places satisfies MCV compilation and the module loads but is unavailable in T-LoRD's IGM manager (T-LoRD -> (U)se Sysop Options -> (I)GM Manager):

On v6.25 the module shows up after being loaded in MajorBBS:

GM DLL's might be a little tricky.
We'll have to poke into how the DLL's work. They might be dynamically loaded by T-LORD or by the system itself as modules.
Additionally, we'll need to check the relocation table for Imports in the IGM DLL to see if it requires relocation patching including ordinals within RTSLORD.

Looking at a true-blue MBBS installation with T-LoRD and Distant Places, it looks like the Distant Places installer does a couple of things.
During the install process it looks for the MBBS executable, so it's likely throwing the DLL in there somehow. Additionally, it adds two lines to the file IGMLIST.TXT in the RTSLORD subdirectory. The contents of that file are:
CXO-LORD
`0D`9istant `0P`9laces! `7(LORD IGM Expansion by `%M`7ike `%S`7nyder)

CXO-LORD.DLL and CXO-LORD.MDF are in the root MBBS directory. There is a subdirectory, \CXOLIGMS, which appear to contain dozens of IGMs using the Distant Places logic.

I looked at the Imports for CXO-LORD and it APPEARS to be a standalone module. No reason it couldn't be supported. Need to investigate more.

The MSG issue will be fixed in PR #119


[GHSA-cmhx-cq75-c4mj] Regular Expression Denial of Service (ReDoS)

Updates

Affected products
Severity

Affected versions conflict with fixed versions. I don't know enough to make a change, but this should be looked into


Integration Test - Release - 2019/05/28 22:27:44

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Responsive configurations for reusable blocks

Currently responsive configuration is solid, it prevents convenient use of reusable blocks.
It is necessary to implement ability to define responsive configuration for separate block and then include it into main configuration.
For example it can look like this (rc here and below is an acronym for responsive configuration.):
// Define responsive configuration for the block
@include rc-block(block-id, (
  config-id1: ( /* parameters */),
  config-id2: ( /* parameters */),
 // ... some more ...
  config-idN: ( /* parameters */),
));

rc-block mixin should register given configuration map under given id into responsive module so it will be possible to refer it later by id when including into main configuration
// Include block configuration into main configuration
@include r-config(config-id, (
  // ... some configuration ...
  key: rс-block(block-id),
  // ...
));

rс-block inclusion function may be called at any level of configuration, however it should only be allowed to include blocks into default responsive configurations. Attempts to include blocks into non-default configurations should result into error.
It may be good idea to allow passing $ids-map mapping table from block's configuration ids into application's configuration ids because they, obviously, may differ. This mapping table can be detected by comparing map's keys with block's configuration keys and values with application's configuration values.
To allow further flexibility - it is necessary to provide a way to extend block configuration. Something like this:
// Extend given configuration map with provided configuration
//
// @param string|map $block Either Id of registered configuration block or block configuration map
// @param map $override     Map with information to merge over configuration block
// @return map              Extended configuration map
@function rc-extend($block, $override)

It will also require implementation of functions:
// Get configuration of registered configuration block
//
// @param string $block  Id of registered configuration block
// @return map|null
@function rc-get-block($block)

// Remap given configuration block to new configuration ids
//
// @param string|map $block      Either Id of registered configuration block or block configuration map
// @param map $ids-map           Mapping table from block's configuration ids into new ids
// @param boolean $skip-unmapped true to skip block's configurations that are missed into map, false to throw error in this case
// @return map                   Remapped configuration
// @throws error in a case if unknown source id or if there is unmapped configuration and $skip-unmapped: true
@function rc-remap($block, $ids-map, $skip-unmapped: true)

This proposal may conflict with #13 and #14 because it will require either moving block's responsive configuration into separate file (doubling files amount) with intensive imports or will require allowing modifications after call to r-init().

Another possible solution is to treat rc-block() function call during configuration definition as a promise. In this case rc-block() will just define position into responsive configuration will be inserted. Then, later, rc-block() mixin will define actual configuration that will be processed and merged into main responsive configuration.
This approach will allow definition of overall configuration structure while allowing its actual construction block by block as needed.
It is open question how to track calls to not-yet-resolved block promises.

Some more thoughts on this topic:
Block configuration definition can be implemented as a function instead of mixin and will return path within responsive configuration. This path can be then passed to r-with() for further usage.
In this case block configuration embedding function should look like this:
// Include external responsive configuration block into main responsive configuration
//
// @param string|map $block Either Id of registered configuration block or block configuration map
// @param function $transformer    Configuration block transformation function
// @return string
@function rc-include($block-id, $transformer: null)

$transformer parameter is optional name of the function to call to perform configuration transformations that are required to apply to block configuration in order to use it into main configuration. Examples of such transformations are:

configuration ids mapping
adding / removing parameters, changing their values
... etc

Transformation function should receive receive block responsive configuration as argument and return information that should be embedded into main responsive configuration.
It will be also necessary to provide implementations of some standard transformations, such as ones, listed above.
When block configuration will be actually registered - library should call transformation function (if there is any), embed resulted block into main configuration and return path to this configuration, so it will look something like this:
$config-path: rc-block(block-id, (
  // ... some block configuration ...
));

// ... later in code ...

@include r-with($config-path) {
  // Block responsive configuration can be used
}

Another possibility is to allow passing responsive configurations as maps for r-with() and allow passing maps directly to r-each(). There is separate issue #23 for last point.


feat(tutorial): complete step 1

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

@daniel-m-s Looks brilliant 🏆! I've recorded your completion of step 1.


Split partition metadata markers across multiple markers if the partition ID list is too long.

This is the rest of the fix for https://github.com/awslabs/flux-swf-client/issues/33
If the size of the serialized metadata marker exceeds 32000 bytes, the metadata will now be split across multiple markers. The first marker contains the encoded additional attributes map as well as the first subset of partition IDs; the remaining markers each contain a subset of the remaining partition IDs.
On reassembly, the markers are recombined into a single PartitionMetadata object (if all of the markers are present).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixed javadocs and corrected the attribute map size calculation.


Memory Leak on iOS: FastImage not released from memory when callbacks onLoad is set

An engineer at my company noticed a memory leak on iOS when the props onLoad is set on iOS.
FastImage doesn't get released when it should be.
After investigating the source code, I found out that using a strong reference to self to call sendOnLoad  in sd_setImageWithURL.
I suspect this line to be the cause of this memory leaks.
https://github.com/DylanVann/react-native-fast-image/blob/141a4a02931ba9e02ee169ba4543e77d924b6a79/ios/FastImage/FFFastImageView.m#L167
I can submit a Pull Request to transform this strong reference into a weak reference, which should fix the memory leak.

Hello @StevenMasini, I have tried your PR but it does not compile. (as I reported you in the PR)
What should I do?
Thank you,
Marco

@marf Hey sorry for the delay. I am working on it since yesterday. I found a very fast and easy to reproduce memory leaks when you set the onError props in <FastImage>, but it's not really obvious yet what's causing this memory leaks.
Also I am sorry for the fix I submitted earlier, it's been a while that I haven't done Objective C, so I forgot that typeof(self) will actually define it as a pointer already. So the correct syntax for the fix I submitted is __weak typeof(self) weakSelf = self; without the *.
But still that's not enough to fix the memory leak. So I will keep investigating.

HI @StevenMasini , if the onError is not be set, there is no memory leak right?

@truongluong1314520 You can set the onError but just don't try to get any parameters from it.
onError don't pass any parameters.
For instance do
onError={() => {
// your implemention
}}

but don't
onError={error => {
// this will create a memory leak, the same for every callback, just strictly follow the documentation
console.log(error)
}}

I made a new Pull Request here https://github.com/DylanVann/react-native-fast-image/pull/433

I would be happy if people could try my PR #433. It should fix the memory leak on iOS.
Let me know if you it works for you or not ?

Hello @StevenMasini I will try your PR #433 , thank you!
In my case I was not using the onError callback so I do not think that my problem is related to it.
I mitigated the problem by downsizing the images from 1024x1024 to 512x512, in these case with lots of images it takes less memory, but it is a workaround.
I will try your PR #433 hoping memory usage decreases.
Thank you

@marf Actually not only the onError callback is affected, but all callbacks. So even using onLoad will lead to memory leaks.
It's good to reduce the resolution of your pictures, you probably didn't do it for nothing.
I hope that the fix I made will solve your problem, if not I am willing to help you out.

@StevenMasini thank you!

faced the same issue and had to remove the onError callback. Is there a fix coming for this?

@manithin What was your implementation of onError ? Did you try to retrieve a param from it ?
I remember that if you try to do this, it will lead to a memory leak.
onError={(error) => { ... }}

If so then just remove the param. onError does not return the specific error. If not, then that's another bug.

This is how i implement it. Just set an error status for displaying a default image.
onError={() => setImageError(true)}
when this block was disabled, there were immediate changes in the performance.

I would be happy if people could try my PR #433. It should fix the memory leak on iOS.
Let me know if it works for you or not ?

Heyy...@StevenMasini I am also facing same crash issue on ios. I want to user you PR. But don't know how can I use your PR. I don't know much more about git. I just installed fastimage from npm. Can you please tell me how I can use it ?

@kishanbharda
The memory leaks fixes have been merged into the current version of react-native-fast-image.
But if you are experiencing issues with image loading, etc. My branch still fix more issues.
You can modify your package.json to point at my branch with the following line
"@stevenmasini/react-native-fast-image": "^7.0.0"

Also, I keep that branch up to date with the main repository.

Thank you. I will try.


Feature Request: Collection-level Metadata for better execution-environment handling and to keep track of dependencies

Dear maintainers,
Please add and maintain the python requirements (modules: cryptography / packages) of the collection in its "Collection-level Metadata" so that people can more easily use the collection in execution-environments when using it with awx or ansible automation controller.
The Collection-level Metadata makes it more easy to include the collection in execution-environments, since the python dependencies will be automatically installed, when building the execution-environment with ansible-builder.
Furthermore you could track the dependencies in context of a release. At the current state of the collection I can not see which python packages in which version needs to be installed to meet the "is cryptography installed" pre check in your module_utils! So this would help all kinds of users of your collection.
If you need further information about the Collection-level Metadata here is some documentation from the ansible-builder project Documentation.
Thanks in advance

I added code examples in #78 so you can use this as a starting point

Thanks for the PR - we'll keep the requirements up to date as we publish updates.  Feel free to submit issues for any other dependency issues you find.

@dsoper2 you're welcome!
Do you know the supported cryptography versions? My contribution was just a wild guess!


chore: no automatic logout on 401

I tested locally with kratos v0.13 on the backend and it appears to fall into a 403 loop.

I tested locally with kratos v0.13 on the backend and it appears to fall into a 403 loop.

you mean the 401 issue would be fixed with kratos v0.13? I did try and had a 401 (unless I messed up the version)

with v 0.13 , the whoami endpoint appears to throw a 403 now instead of a 401 when the database is down

with kratos v0.13 , the whoami endpoint appears to throw a 403 now instead of a 401 when the database is down

actually sorry, it throws a 403 when both the kratos and postgres containers are down. if just the postgres container is down it still just throws a 401

with kratos v0.13 , the whoami endpoint appears to throw a 403 now instead of a 401 when the database is down

actually sorry, it throws a 403 when both the kratos and postgres containers are down. if just the postgres container is down it still just throws a 401

ok that's what I saw. so we should merge my PR?
until we have clarify on https://github.com/ory/kratos/issues/3250 I think this is the safest way

the modal keeps popping up even after the database comes back up and 200s come back.
steps to reproduce:

Run the mobile app and login
Click receive, generate invoice like normal
Go back to home page
Stop the docker image kratos-pg
Click receive, generate invoice (modal popup stating 401)
Start the docker image kratos-pg
Click ok on the modal, another one pops up

the modal keeps popping up even after the database comes back up and 200 success on a graphql query
steps to reproduce:

Run the mobile app and login
Click receive, generate invoice like normal
Go back to home page
Stop the docker image kratos-pg
Click receive, generate invoice (modal popup stating 401)
Start the docker image kratos-pg
Click ok on the modal, another one pops up again and again

oh yeah need to clear the network value... let me do that


Visual Studio Codespaces: Improve iPad keyboard support

It would be great if the iOS keyboard on the iPad doesn't hide the terminal panel.

Let's track this in https://github.com/microsoft/vscode/issues/108267.


Continue and warn on missing models instead of fail

dbt does not error if a bad model selector is provided (nor does it warn).
These changes will model selectors that do not correspond to models that exist but it will also warn the user: best of both worlds.
We rely on this behaviour in the analytics CI process.

So this was a deliberate different between the two, as missing models cause runtime errors and confusion - quite oftern down to typos. Could we put this behind a flag and default to erroring?

I'll work on that now @DomBlack

🙏 Thanks Theo :)


nuttx: add get_current_dir_name implementation

Summary
add get_current_dir_name API implementation
Impact
has no impact on other module
Testing
has passed ostest

[Experimental Bot, please feedback here]
No. The PR description lacks crucial details required by the NuttX guidelines.  While it mentions the added API, it fails to provide context or justification.  Here's why it's insufficient and what needs improvement:

Insufficient Summary: "add get_current_dir_name API implementation" is too brief.  Explain why this API is needed. What problem does it solve? What use cases does it address? Which part of the codebase is affected (e.g., VFS, libc)? How does the implementation work (e.g., does it traverse the path, use a cached value, etc.)?

Insufficient Impact Assessment: "has no impact on other module" is likely untrue.  Almost any change has some impact.  Consider:

User Impact: Will applications need to be modified to use this new API?
Build Impact:  Are any new dependencies introduced?  Do any build flags need to be set?
Hardware Impact:  Does it rely on specific hardware features?
Documentation Impact: This new API definitely requires documentation.  Where is it documented?
Security Impact: Could misuse of this API lead to security vulnerabilities (e.g., path traversal)?
Compatibility Impact: Does it break any existing code?

Insufficient Testing: "has passed ostest" is inadequate.  Which specific ostest cases were run? What are the actual logs before and after the change?  Just saying "passed" doesn't provide any verifiable evidence.  Provide details about the build host (OS, compiler version) and the target (architecture, board, configuration).  Ideally, test on multiple configurations if possible.  Demonstrate that the function returns the expected directory name under different scenarios (e.g., root directory, subdirectories, relative paths).

Example of an improved summary:
"This PR implements the get_current_dir_name() API within the VFS layer to provide applications with a way to retrieve the name of the current working directory.  Currently, applications have no direct way to obtain this information, requiring workarounds. This API addresses this deficiency by providing a simple function call.  The implementation retrieves the current working directory path and extracts the last component (directory name) using path parsing functions.  This addresses Issue #[NuttX Issue Number]."
By providing more comprehensive information, the reviewer can effectively assess the change and ensure its quality and suitability for inclusion in NuttX.

the description in this PR:
 *   get_current_dir_name() function will malloc an array big enough to
 *   hold the absolute pathname of the current working directory.  If the
 *   environment variable PWD is set, and its value is correct, then
 *   that value will be returned. The caller should free the returned
 *   buffer.

https://linux.die.net/man/3/get_current_dir_name:
get_current_dir_name() will malloc(3) an array big enough to hold the absolute pathname of the current working directory. If the environment variable PWD is set, and its value is correct, then that value will be returned. The caller should free(3) the returned buffer.
to me, they seem identical.
if you haven't copied the text from https://linux.die.net/man/3/get_current_dir_name,
can you make it clear from where you copied it?

the description in this PR:
 *   get_current_dir_name() function will malloc an array big enough to
 *   hold the absolute pathname of the current working directory.  If the
 *   environment variable PWD is set, and its value is correct, then
 *   that value will be returned. The caller should free the returned
 *   buffer.

https://linux.die.net/man/3/get_current_dir_name:
get_current_dir_name() will malloc(3) an array big enough to hold the absolute pathname of the current working directory. If the environment variable PWD is set, and its value is correct, then that value will be returned. The caller should free(3) the returned buffer.
to me, they seem identical. if you haven't copied the text from https://linux.die.net/man/3/get_current_dir_name, can you make it clear from where you copied it?

Sorry, I forgot where I referred to this comment from at that time. I've updated the comment information again to make sure it's different from the man page.  Please help review again.


Edited Tags.tsv to comply with new "Extra column" format

Based on discussion this week, we have decided on the following format for the extra columns in the .tsv files.  The items that would appear as AnnotationProperty in the ontology  will all appear in an column called Annotations.  They will be separated by commas and follow a format like:
dc:comment "xxxx", dc:comment "yyyy
This format translates well into Manchester syntax.
I combined the dc:source and dc:comment columns in the new format under Annotations and removed the others.  I also spotted and corrected a few spelling errors.
@monique2208 please review.
@dorahermes  note the format if you want to add comments.

@monique2208 you can ignore the merge PRs and workflow additions.   You only need be concerned about commit 0fed4a5

I went over the specific commit, it all looks good to me!

Closing and deleting this branch to clean up the commits.


Adds ValueError when user passes invalid active_rules to REOS.

Description
Adds sanity checks in  useful_rdkit_utils.REOS and removes redundant code in REOS.read_rules.
Issues fixed:

useful_rdkit_utils.REOS won't raise any exceptions when passed an invalid list of active_rules. Users might think they are filtering down compounds when they actually are not.
Init already reads CSV. pystow.ensure returns pathlib.Path and initialized rule_path already.

Codecov Report

Merging #22 (52523c7) into master (f7b72d2) will decrease coverage by 0.74%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   77.11%   76.37%   -0.75%
==========================================
  Files           4        4
  Lines         236      237       +1
==========================================
- Hits          182      181       -1
- Misses         54       56       +2

Flag
Coverage Δ

unittests
76.37% <33.33%> (-0.75%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

useful_rdkit_utils/reos.py
73.21% <33.33%> (-3.15%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b72d2...52523c7. Read the comment docs.

Thanks, Jacob


Mm/prc 0 log non axios errors

Currently we drop some errors in the logs, if they don't follow the expected Axios format. This should somewhat help

And as always, don't forget to have the last commit name Release 5.2.2


Explore default Windows 11 print dialog

This might be a good opportunity to finalize any external packages needed to compile our program.
Installed Packages

CsvHelper, 30.0.1
DotNetEnv, 2.5.0
MailKit, 3.6.0

Print document class from @JJakiemiec


Remove #__nuxt div

My nuxt application always has a div with the id __nuxt inside <body>.
Is it possible to remove this div? Why is it needed?
Reason:
For me it was important to add this css to get my divs to 100% height:
#__nuxt {
  height: 100%
}

This wouldn't be needed if the __nuxt div does not exist.

<div id='__nuxt'> is the root node for mounting Vue instance, so you cannot remove it.
If you want to customize styles of __nuxt, you can put them to global css


Figure list stopped updating since June 19, 2021

I'm not sure if this is just me, but there hasn't been updates to the figure selection of the app since a few days ago.
Thank you!

Restarted the server, should work now. Thanks for the report.

Thank you so much! I appreciate it


"min:" and "max:" in apex_config are not working as expected?

Checklist

[ X] I updated the card to the latest version available
[ X] I cleared the cache of my browser
[ X] I verified that I'm really running the lastest version in my browser console
[ X] I checked if there is another issue opened with the same problem

Describe the bug
"min:" and "max:" in apex_config are not working as expected. If I specify a "min:" or a "max:", I shortly see the correct chart representation drawing while the chart is loading, but then it falls back to the settings that one would expect in "auto" mode?
Version of the card
Version: Running 2.0.4 via HACS
To Reproduce
This is the configuration I used:
type: custom:apexcharts-card
header:
  show: true
  title: Tibber Electricity Price / SOC
  show_states: true
  colorize_states: true
yaxis:
  - id: price
    apex_config:
      min: 0
      max: 0.2
      forceNiceScale: true
      decimalsInFloat: 2
      labels:
        show: true
series:
  - entity: sensor.electricity_price
    name: ‘ ’
    stroke_width: 3
    float_precision: 3
    color: cornflowerblue
    yaxis_id: price
    curve: straight

Screenshots
The default yaxis max value i=s 0.15, if I enter a value for max ...

... for example 0.2, you very briefly see the correct yaxis drawing while the chart is loading:

but then it falls back again to max 0.15.

Same again when I change max to 0.3, you very briefly see the correct yaxis drawing at 0.3 while loading:

and then it falls back again to max 0.15.

Expected behavior
The yaxis always shows what I specify in "min:" and "max:"
Desktop (please complete the following information):

Browser: Chrome
Version:120.0.6099.129 (Official Build) (x86_64)

Note: in 2020 there was a bug in apexcharts.js that caused a similar behaviour: https://github.com/apexcharts/apexcharts.js/issues/1578. Not sure if this here is somehow related? Can anyone replicate this behaviour?

min and max should be defined outside of apex_config. (directly in y_axis)

Thanks @RomRider, that was it, the short correct drawing threw me off so it looked like it should work but didn't. Thanks a bunch!


use wordcount() function on newer Vims.

Hi,
please use the wordcount() function instead of the g CTRL-G workaround. This has been included with Vim 7.4.1042 so please consider using this function in newer Vims, as this avoids problems such as this one
Thanks for considering.

I haven't tested this (don't have access to a new vim just now), but here's a preliminary implementation:
https://github.com/somini/vim-airline/tree/wordcount_function


Build on an arm64 Odroid C2

Hello,
I tried to build the MC-Server image with your dockerfile and it stopps at step 15 with this error:

Step 15/17 : COPY *.sh /opt/
COPY failed: no source files were specified

Here is my dockerfile:

FROM debian
ARG ARCH=arm64
RUN apt-get update &&
DEBIAN_FRONTEND=noninteractive apt-get install -y
curl
unzip
jq
&& apt-get clean
EXPOSE 19132/udp
VOLUME ["/data"]
WORKDIR /data
ENTRYPOINT ["/usr/local/bin/entrypoint-demoter", "--match", "/data", "--debug", "--stdin-on-term", "stop", "/opt/bedroc$
ARG EASY_ADD_VERSION=0.5.0
ADD https://github.com/itzg/easy-add/releases/download/${EASY_ADD_VERSION}/easy-add_${EASY_ADD_VERSION}linux${ARCH} /$RUN chmod +x /usr/local/bin/easy-add
RUN easy-add --var version=0.2.1 --var app=entrypoint-demoter --file entrypoint-demoter --from https://github.com/itzg/$
RUN easy-add --var version=0.1.1 --var app=set-property --file set-property --from https://github.com/itzg/{{.app}}/rel$
ARG RESTIFY_VERSION=1.2.0
RUN easy-add --var version=1.2.0 --var app=restify --file restify --from https://github.com/itzg/{{.app}}/releases/down$
COPY *.sh /opt/
COPY property-definitions.json /etc/bds-property-definitions.json
'#' Available versions listed at
'#' https://minecraft.gamepedia.com/Bedrock_Edition_1.11.0
'#' https://minecraft.gamepedia.com/Bedrock_Edition_1.12.0
'#' https://minecraft.gamepedia.com/Bedrock_Edition_1.13.0
'#' https://minecraft.gamepedia.com/Bedrock_Edition_1.14.0
ENV VERSION=LATEST

And my build command:

sudo docker build -t 'minecraft' .

What did I wrong?

That's strange since you do seem to be building it correctly and I double checked that step just now:
Step 15/17 : COPY *.sh /opt/
 ---> 9440b77f7abf
Step 16/17 : COPY property-definitions.json /etc/bds-property-definitions.json
 ---> 1d61df9d4da6

HOWEVER, the Bedrock server download https://www.minecraft.net/en-us/download/server/bedrock/ only provides a Linux version for amd64, so even if the docker build succeeds the final execution step of the binary would have failed :(

...if you want to further debug that COPY, just for curiosity sake, add the following before that line in the Dockerfile to see what files did get brought into the build context:
COPY . /opt/
RUN ls -l /opt