Can't create "no access" ec2.SecurityGroupRule

Troposphere is disallowing my ec2.SecurityGroupRule because it doesn't have a valid FromPort or ToPort.
Cloudformation automatically adds an "all" rule to ingress/egress definitions that are left blank, so if you want to specifically create a rule that disallows access you create a rule against localhost with an IpProtocol of -1 and no to/from port info.
Despite what the http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-security-group-rule.html docs say, FromPort and ToPort are not required when using IpProtocol=-1 from a VPC.
See this example taken from http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-security-group.html#d0e39862 :
"sgwithoutegress": {
  "Type": "AWS::EC2::SecurityGroup",
  "Properties": {
    "GroupDescription": "Limits security group egress traffic",
    "SecurityGroupEgress": [
      {
        "CidrIp": "<IP_ADDRESS>/32",
        "IpProtocol": "-1"
      }
    ],
    "VpcId": { "Ref": "myVPC"}
  }
}

Is the behavior you're talking about discussed anywhere in the docs?  The reason this fails now is because troposphere, traditionally, has tried to stick to what is defined in the docs - and the docs for the SecurityGroupRule property says that ToPort/FromPort are required. (http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-security-group-rule.html)
We run into these undocumented 'features' occasionally, and haven't found a good answer to it.

It's not discussed in these docs beyond the example I referenced.  However, the properties are marked as optional in the ec2 API docs:

http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AuthorizeSecurityGroupEgress.html
http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_AuthorizeSecurityGroupIngress.html

I also haven't been able to find any reference for the default behavior of "if you don't specify a rule, we assume you mean allow all traffic".

All of the AWS Documentation links you guys referenced so far state that ToPort and FromPort are optional. I guess they updated the doc since this discussion started?

@muikrad That does indeed appear to be the case now.  Previously, the page linked to by @phobologic had them listed as required.


Fixed the failure to create statefulset when dataset and runtime resources'name starts with a number.

Signed-off-by: Yanghaihai1020<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
When the name field of dataset and runtime resources'name starts with a number, a DNS-1035 error is reported to events.
Ⅱ. Does this pull request fix one issue?

fixes #2213
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
kubectl describe dataset 300-khbase
Type     Reason              Age                From     Message

Warning  ErrorCreateDataset  4s (x12 over 21s)  Dataset  Failed to create dataset because err: metadata.name: Invalid value: "300-khbase": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is 'a-z?')
kubectl describe alluxio 300-khbase
Type     Reason               Age                     From            Message

Warning  ErrorProcessRuntime  3m31s (x16 over 6m15s)  AlluxioRuntime  Failed to create ddc engine due to error metadata.name: Invalid value: "300-khbase": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is 'a-z?')

BTW，I am wondering is it better to deny user's API request(e.g. create Dataset or Runtime CR) if its name starts with a number? For example, we can use +kubebuilder:validation:Pattern to offer such protection

The impediment to the use of patterns is that the name field is one of the properties of the ObjectMeta struct in the referenced metav1 package. In addition, adding a ValidatingAdmissionWebhook can directly deny user‘s requests, but this introduces additional stability issues.

@Yanghaihai1020 You're right. This PR LGTM now. Thanks a lot!


Hide replace option for the request that cannot edit

Details

We hide replace option in attachment modal of receipt if the request cannot be edited
Fixed Issues

$ https://github.com/Expensify/App/issues/27965
PROPOSAL: https://github.com/Expensify/App/issues/27965#issuecomment-1730733469
Tests

Login with user A and open chat report with user B
Create a scan request with user B
From user A, open the receipt preview and click on three dot item
From user B, pay elsewhere this request
Verify that the replace option is hidden

[x] Verify that no errors appear in the JS console

Offline tests

None
QA Steps

Login with user A and open chat report with user B
Create a scan request with user B
From user A, open the receipt preview and click on three dot item
From user B, pay elsewhere this request
Verify that the replace option is hidden

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/129500732/08d870ee-5f03-4eb7-a884-1fb35cf4d6b0

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/e13b9f62-c3c3-4911-a38e-d5905005a7fe

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/49d74053-ba11-4d5a-ae2a-f55fcf8b1dd1

Desktop
https://github.com/Expensify/App/assets/129500732/25f514c1-3a8f-4789-9a8d-cde1228226a5

iOS
https://github.com/Expensify/App/assets/129500732/5b017b29-5b74-4b5d-b726-0473e0230118

Android
27965.webm

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@dukenv0307 I successfully tested on web but I'm struggling with other devices (ios and android so far) - I'm getting some errors while trying to request money using scan - please take a look at the video below:
https://github.com/Expensify/App/assets/7771498/373d0103-be5b-4594-af1f-f5ee116f0b41
I guess it may not be related to your changes but can you take a look? Maybe syncing with main will help?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.78-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/Li357 in version: 1.3.79-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Last Transaction (Approve Box, History, Delete)

The recency of a transaction is determined by the date on the form submitted by the user (NOT the date the user submitted the form)
Delete most recent transaction from Box_History
Only copy box info from Box_History to Anchor_Box after admin approves a box if the date on the box is the most recent

/cib last transaction

Branch 144-last-transaction created!


Strange Behavior of Navigation

Steps to reproduce

I'm trying to redirect to login when the user's token is expired with the Navigator key and pushNamedAndRemoveUntil method

Expected results

back to login correctly

Actual results

back to login if the navigation stack is
bottom -> home
back to blank page if the navigation stack is
bottom->  home - any page
as though the navigator works well in pop but it doesn't work in push

Code sample
Code sample
// method in api_service file
  void _redirectToLogin(ErrorInterceptorHandler handler, DioException error) {
    navigatorKey.currentState!.pushNamedAndRemoveUntil(
      AppRoutes.login,
      (route) => false,
    );
    handler.reject(error);
  }

// app file
final navigatorKey = GlobalKey<NavigatorState>();

MaterialApp(
   navigatorKey: navigatorKey,
   onGenerateRoute: RouteGenerate().getRoute,
   home: const WelcomePage(),
)

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.24.0, on Microsoft Windows [Version 10.0.19045.4651], locale en-US)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[√] Chrome - develop for the web
[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components
[√] Android Studio (version 2024.1)
[√] VS Code (version 1.92.1)
[√] Connected device (3 available)
[√] Network resources

! Doctor found issues in 1 category.

@ahmeddarafat
Please provide complete runnable and reproducible code sample (without third party package implementation) that we can directly use to verify the reported behavior.


bug: Run viur cloud setup gcloud in an empty project folder generates confusing results

Hello!
I'm currently experimenting with Google Cloud Shell and tried to run a viur cloud setup gcloud command in my home folder, with a fake project.json and no deploy folder.
$ viur cloud setup gcloud
Enter PROJECT_ID: xxx-viur3
Check if user is authorized with gcloud....
Operation "operations/acat.p2-799407658776-5713ecae-5dde-4a55-b286-26f9ab92b842" finished successfully.
Operation "operations/acf.p2-799407658776-fbf62221-ce5e-4f8b-a10b-4e2555e5b9b5" finished successfully.
Operation "operations/acat.p2-799407658776-3f617a3e-55aa-4092-97c0-23d40dba8aaf" finished successfully.
Operation "operations/acf.p2-799407658776-1bf01b22-97a1-4745-b735-d1237862a742" finished successfully.
Operation "operations/acf.p2-799407658776-6756081d-adac-4c44-a0db-973e9554a6ad" finished successfully.
Operation "operations/acf.p2-799407658776-8da2776e-f8f0-4194-94f0-86aa6d6e6acf" finished successfully.
Operation "operations/acat.p2-799407658776-e34a8bae-8f06-417c-9eb9-542858c30dce" finished successfully.
/bin/sh: line 1: cd: deploy: No such file or directory
Error executing command: Command 'cd deploy && gcloud app deploy -q --project=xxx-viur3 cron.yaml' returned non-zero exit status 1.
/bin/sh: line 1: cd: deploy: No such file or directory
Error executing command: Command 'cd deploy && gcloud app deploy -q --project=xxx-viur3 queue.yaml' returned non-zero exit status 1.
/bin/sh: line 1: cd: deploy: No such file or directory
Error executing command: Command 'cd deploy && gcloud app deploy -q --project=xxx-viur3 index.yaml' returned non-zero exit status 1.
Check if app engine default credentials are set...
INFO: All done!
You should now be able to run your project locally with
   viur run
At the first run, it might happen that some functions are
causing error 500 because indexes are not immediately
served. Therefore, maybe wait a few minutes.
Have a nice day.

This result is confusing. Generally, the workflow should in this case be something like viur init to initialize a new, empty base-project. viur cloud setup gcloud should fail immediatelly when there is no deploy folder, with a hint that viur init should be executed first.

viur init is in a separate issue #129

viur init is in a separate issue #129

#129 was replaced by #165, viur cloud setup gcloud should still be fixed either.


400002500003155

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi @Mauricio-sy Looks like you accidentally created this ticket. I'm closing it now, feel free to create a new one when you have something to share.


Support for repositories with multiple GEMs (f. ex. strain collections)

Description of the issue:
So far only singular GEM repositories fit within the standard-GEM template. While some parts can easily be used with multiple GEMs, such as the overall structure, other things fall short when multiple GEMs are hosted in one repository.
Expected feature/value/output:
There are two ways how to approach this:

One could either extend this repository to be applicable to repositories with multiple GEMs
Or create a separate template for multiple-GEM-repositories

A few changes that directly came to my mind are:

the model folder would need to change to models
one model format should be stored in the models folder (f. ex. xml) conversions into other formats could be done via github actions and stored either in subfolders (within the models folder) or different folders in the repository (f.ex. a folder called json for all json models etc.)
the naming convention for the GEMs needs to be adapted
as a possible Memote report, a memote report diff would be preferable over reports for every model

Current feature/value/output:
Not available.
I hereby confirm that I have:

[X] Tested my code with all requirements for running the model
[X] Done this analysis in the main branch of the repository
[X] Checked that a similar issue does not exist already
[X] If needed, asked first in the Gitter chat room about the issue

Just a very minor note: I'd keep the model directory without the plural form. Rationale: When talking about the source code of a program, we also typically refer to multiple source files. Still, it is not called source codes. The singular is appropriate here as an unmarked form.


add controller for setting upgradeable conditions to false if unsupprtedConfigOverrides is set

proven in https://github.com/openshift/cluster-kube-apiserver-operator/pull/304
/assign @mfojtik

lgtm'd in proof pull


MTK Meta smart card not detected error

I am trying to use the MTK Meta application (now called Android Utility), but every time I try to start it it opens a dialogue box telling me to load a valid smart card. I don't really know what a smart card is, but I tried to google and found several videos wherein it works as long as you insert usb stick which I tried to no avail. I downloaded and configured the Microsoft smart card reader driver, and it still did not work. I would remove the code that checks for a smart card but I have no idea where to look for it in the file. Did anyone else experience this problem, and if so how did you resolve it?

check the wiki for new instruction to use autobooter instead of that


Update JS Guidlines

Add ESLint rule recommendations
Remove all the references to Drupal
Remove things that are obsolete in 2021.
Fix inconsistent spacing and brace style that violated the very rules that the document was describing.

I'd also like to propose a bigger change here - that we rewrite this document entirely as just a list of ESLint rule recommendations, with links to the corresponding ESLint pages that already contain very good descriptions of why the rule is a good idea as well as examples of conforming code and violating code.


Improve addCommand for email domain with added test for validity of email domain inputs

Does not allow emails with no periods, and there must be one period in the domain, no more no less: e.g<EMAIL_ADDRESS>is acceptable, example@example and<EMAIL_ADDRESS>is not.

Codecov Report

Merging #153 (26fb9f7) into master (edd551e) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #153      +/-   ##
============================================
+ Coverage     62.61%   62.74%   +0.12%
- Complexity      648      650       +2
============================================
  Files           114      114
  Lines          2394     2394
  Branches        268      268
============================================
+ Hits           1499     1502       +3
+ Misses          817      816       -1
+ Partials         78       76       -2

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/model/person/Email.java
80.00% <ø> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <0.00%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd551e...26fb9f7. Read the comment docs.

Nice fix!


v0.8.1 HA mode, how agent conns to server's lanIPs when not in same lan.

Since v0.7.0 HA mode feature be added. the tunnel to the server's 6443 set by K3S_URL=https://xxx:6443 be unusable.
when agent not in same lan conns error and can't startup.
v0.8.1
node_1  | time="2019-09-13T13:41:23.714868550Z" level=info msg="Starting k3s agent v0.8.1 (d116e74a)"
node_1  | time="2019-09-13T13:41:23.741142094Z" level=info msg="Running load balancer <IP_ADDRESS>:44815 -> [<IP_ADDRESS>:6443 <IP_ADDRESS>:6443]"
node_1  | time="2019-09-13T13:41:32.132137173Z" level=info msg="Using containerd template at /var/lib/rancher/k3s/agent/etc/containerd/config.toml.tmpl"
node_1  | time="2019-09-13T13:41:32.132831982Z" level=info msg="Logging containerd to /var/lib/rancher/k3s/agent/containerd/containerd.log"
node_1  | time="2019-09-13T13:41:32.133486305Z" level=info msg="Running containerd -c /var/lib/rancher/k3s/agent/etc/containerd/config.toml -a /run/k3s/containerd/containerd.sock --state /run/k3s/containerd --root /var/lib/rancher/k3s/agent/containerd"
node_1  | time="2019-09-13T13:41:32.134026077Z" level=info msg="Waiting for containerd startup: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial unix /run/k3s/containerd/containerd.sock: connect: no such file or directory\""
node_1  | time="2019-09-13T13:41:33.139295470Z" level=info msg="module br_netfilter was already loaded"
node_1  | time="2019-09-13T13:41:33.139863988Z" level=info msg="module overlay was already loaded"
node_1  | time="2019-09-13T13:41:33.139935462Z" level=info msg="module nf_conntrack was already loaded"
node_1  | time="2019-09-13T13:41:33.321952615Z" level=info msg="Connecting to proxy" url="wss://<IP_ADDRESS>:6443/v1-k3s/connect"
	node_1  | time="2019-09-13T13:41:36.378084907Z" level=error msg="Failed to connect to proxy" error="dial tcp <IP_ADDRESS>:6443: connect: no route to host"
	node_1  | time="2019-09-13T13:41:36.378213058Z" level=error msg="Remotedialer proxy error" error="dial tcp <IP_ADDRESS>:6443: connect: no route to host"
	node_1  | time="2019-09-13T13:41:41.378720176Z" level=info msg="Connecting to proxy" url="wss://<IP_ADDRESS>:6443/v1-k3s/connect"
	node_1  | time="2019-09-13T13:41:44.442093320Z" level=error msg="Failed to connect to proxy" error="dial tcp <IP_ADDRESS>:6443: connect: no route to host"
	node_1  | time="2019-09-13T13:41:44.442189467Z" level=error msg="Remotedialer proxy error" error="dial tcp <IP_ADDRESS>:6443: connect: no route to host"

<IP_ADDRESS> is the server's lan ip. (agent not in the same lan)

v0.7.0
the tunnel seems still be used by agent. We can use the server's publicIP just chang the code back. ref #727
https://github.com/rancher/k3s/releases/tag/v0.7.0

This release brings limited experimental HA support,
Have a load balancer setup for the master nodes k8s api (port 6443). (requirement of setting up an external load balancer)
HA aware agents should be configured to connect to the master nodes through the load balancer, agents will then watch the kubernetes endpoints and setup a reverse tunnel to each master node

And when I use v081 with kilo:

change k3s's code to use publicIP for first conn when cluster agent startup K3S_URL=https://xxx:6443. ref #727

install kilo, to keep the agent use it's LB to conmmunicate the server's lanIP.

Others works fine. but when i use agola, when it communicate with k3s got this err.
error dialing backend: failed to find Session for client ali-vm1

ali-vm1 is my agent. (diff lan to the server node)
ref: agola-io/agola#114

Related #881

ran into the same issue.  This is how I solved it
create cluster master node:
export K3S_NODE_NAME=${HOSTNAME//_/-}
export K3S_EXTERNAL_IP=xx.xx.xx.xx
export INSTALL_K3S_EXEC="--docker --write-kubeconfig ~/.kube/config --write-kubeconfig-mode 666 --tls-san $K3S_EXTERNAL_IP --kube-apiserver-arg service-node-port-range=1-65000 --kube-apiserver-arg advertise-address=$K3S_EXTERNAL_IP --kube-apiserver-arg external-hostname=$K3S_EXTERNAL_IP"
curl -sfL https://docs.rancher.cn/k3s/k3s-install.sh |  sh -

Get Token  on master node:
echo -e "export K3S_TOKEN=$(cat /var/lib/rancher/k3s/server/node-token)\nexport K3S_URL=https://$K3S_EXTERNAL_IP:6443\nexport INSTALL_K3S_EXEC=\"--docker --token \$K3S_TOKEN --server \$K3S_URL\""

join workers to the cluster:
export K3S_TOKEN=xxxx
export K3S_URL=https://xx.xx.xx.xx:6443
export INSTALL_K3S_EXEC="--docker --token $K3S_TOKEN --server $K3S_URL"
export K3S_NODE_NAME=${HOSTNAME//_/-}
curl -sfL https://docs.rancher.cn/k3s/k3s-install.sh | sh -

Try
And when I use v081 with kilo:
* Change k3s's code to use publicIP for first conn when cluster agent startup `K3S_URL=https://xxx:6443`. ref #727

* Install kilo, to keep the agent use it's LB to conmmunicate the server's lanIP

in this case, the lan-k3s problem resolved.

Result
Others works fine. but when i use agola, when it communicate with k3s got this err:
error dialing backend: failed to find Session for client ali-vm1

vendor/github.com/rancher/remotedialer/session_manager.go  func getDialer:
return nil, fmt.Errorf("failed to find Session for client %s", clientKey)

ali-vm1 is my agent. (diff lan to the server node)
ref: agola-io/agola#114

this was just another problem, agola will use k8s's api to trans big files, then master/node not in same lan, the limited bandwidth will cause agola got such as timeout err.

ran into the same issue. This is how I solved it

thx, I'll try this with the new version.


refactor!: group variables for better overview

Description
Groups variables into objects to

reduce the number of variables (currently 118)
to gain a better overview of all configuration settings

Creates new groups of variables:

runner_manager in case it configures the "main" process which sets the defaults for all runners
runner in case it configures the runner created by the runner manager
runner_worker in case it configures the docker/docker+machine or leave it as it is, if it is a global scope, e.g. common tags, the environment, ...

Migrations required
Yes and a script is provided to do that. It covers 98% of all migrations (see migrations/migrate-to-7-0-0.sh)
Verification
Please mention the examples you have verified.

Branch is based on #757 Commits beginning from here are the relevant ones.

@npalm This one is ready now. It rewrites the complete variables.tf and restructures it. Could you please do a review here? Extensive tests still to be done. But I will do it on the target branch refactor-variables this PR points to. There are some other major changes pending.
#723

Scopting with refactor will not create a new release, and also will not be mentioned int he release note as far I know. Maybe better to just scope it as feat.

The ! should be the solution as it creates a major release. Let me quickly check this.

@npalm The only problem I see, is, how to manually update the release docs. Tried some changes here and there, but Release-Please overwrites them. Any idea how to change the docs manually?
I would like to have a reference to the migration script at a prominent place.

@npalm Rebasing is a pain here. Can we merge to target branch kayma/group-variables to start testing the v7 release?

Merged into the pre-release branch for testing.


bug: Some keys do not show which-key, without mini.icons

Did you check docs and existing issues?

[X] I have read all the which-key.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of which-key.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.2
Operating system/version
MacOS Ventura 13.6.7
Describe the bug

nvim-web-devicons installed
mini.icons not installed

In above environment, some keys do not show which-key, and error occurs.
Steps To Reproduce

vim.g.mapleader = ' '
add 'nvim-tree/nvim-web-devicons' to depencendies of which-key
remove 'echasnovski/mini.icons' from depencendies of which-key
':Lazy' and sync
restart nvim
push my <leader> key or g key
which-key does not appear
Hit next key stroke
keymapping works correctry, but
nvim-notify shows error below

- which-key.nvim
 Something went wrong:
 ...l/share/nvim/lazy/which-key.nvim/lua/which-key/icons.lua:64: attempt to call
 field 'get' (a nil value)

If I add mini.icons to dependencies, which-key is shown correctly, and no error occurs.
I guess these keymaps have mini.icons's icon, so this error occur somehow.
(In my environment, there are no plugins using mini.icons as dependencies, except which-key.)
Expected Behavior
<leader> or g key show which-key without mini.icons.
Because below are written in document.
Note
For full support, you need to install <<either>> mini.icons or nvim-web-devicons

Is this a bug ??
If this is an expected behavior, it would be helpful if you could write it as below.
Note
For full support, you need to install either mini.icons or nvim-web-devicons.
(in some case, you need both of them to correct error)

Thank you
Health
==============================================================================
which-key: require("which-key.health").check()

- OK Most of these checks are for informational purposes only.
  WARNINGS should be treated as a warning, and don't necessarily indicate a problem with your config.
  Please |DON'T| report these warnings as an issue.

Checking your config ~
- OK |mini.icons| is installed
- OK |nvim-web-devicons| is installed

Checking for issues with your mappings ~
- OK No issues reported

checking for overlapping keymaps ~
- WARNING In mode `n`, <m> overlaps with <m3>, <m9>, <m[>, <m0>, <m]>, <m1>, <m4>, <m8>, <m7>, <m6>, <m5>, <m:>, <m2>, <m{>, <m,>, <m}>, <m;>:

- WARNING In mode `n`, <<Space>d> overlaps with <<Space>ds>, <<Space>df>, <<Space>dl>, <<Space>dr>, <<Space>dh>, <<Space>dp>:

- WARNING In mode `n`, <<Space>m> overlaps with <<Space>ml>, <<Space>mg>, <<Space>mn>:

- WARNING In mode `n`, <dm> overlaps with <dm<Space>>, <dm9>, <dm0>, <dm=>, <dm->, <dm1>, <dm4>, <dm8>, <dm7>, <dm6>, <dm5>, <dm3>, <dm2>:

- WARNING In mode `n`, <sd> overlaps with <sdb>:

- WARNING In mode `n`, <sr> overlaps with <srb>:

- WARNING In mode `i`, <<C-Y>> overlaps with <<C-Y>T>, <<C-Y><C-B>>, <<C-Y><C-T>>, <<C-Y>t>:
  - <<C-Y>>: cmp.utils.keymap.set_map
- OK Overlapping keymaps are only reported for informational purposes.
  This doesn't necessarily mean there is a problem with your config.

Checking for duplicate mappings ~
- OK No duplicate mappings found

Log
Trigger(add) Mode(n:1) ` " ' g` g' z= g <C-W> z \ <Space> <C-Y> ] [
on_key: <Esc>
on_key: :
ModeChanged(n:c)
  Safe(true)
on_key: q
on_key: <CR>
ModeChanged(c:n)
  Unsafe(command-mode)
  suspend: Mode(n:1)
  Trigger(del) Mode(n:1) ` [ " ] <C-Y> ' g` g' z= <Space> g <C-W> \ z
Trigger(add) Mode(n:1) ` " ' g` g' z= g <C-W> z \ <Space> <C-Y> ] [
BufEnter(3)
  new Mode(n:3)

Debug Started for v3.15.0
{
  commit = "8ab96b38a2530eacba5be717f52e04601eb59326"
}
new Mode(n:1)
Trigger(add) Mode(n:1) ' " ` z= g' g` \ <C-Y> ] z <Space> [ g <C-W>
BufNew(2)
BufNew(3)
on_key: <Space>
State(start): Mode(n:0) Node(<Space>) { keys = "<Space>" }
  update Mode(n:1)
  continue: <Space> Mode(n:1)
  getchar
  on_key: e
  got: e
  suspend: Mode(n:1)
  Trigger(del) Mode(n:1) g' g` \ <C-Y> ] z ' [ g " <C-W> <Space> ` z=
  feedkeys: Mode(n:1) <Space>e
on_key: <Space>e
BufNew(4)
BufNew(5)
BufEnter(4)
  new Mode(n:4)
Trigger(add) Mode(n:1) ' " ` z= g' g` \ <C-Y> ] z <Space> [ g <C-W>
Trigger(add) Mode(n:4) ' " ` z= g' g` \ <C-Y> ] z <Space> [ g <C-W>
on_key: <Esc>
BufEnter(1)
on_key: g
State(start): Mode(n:0) Node(g) { keys = "g" }
  update Mode(n:1)
  continue: g Mode(n:1)
  getchar
  BufNew(6)
  on_key: g
  got: g
  suspend: Mode(n:1)
  Trigger(del) Mode(n:1) g' g` \ z <Space> [ g <C-W> ' " <C-Y> ] ` z=
  feedkeys: Mode(n:1) gg
on_key: g
on_key: g
Trigger(add) Mode(n:1) ' " ` z= g' g` \ <C-Y> ] z <Space> [ g <C-W>
on_key: :
ModeChanged(n:c)
  new Mode(c:1)
  Safe(true)
Trigger(add) Mode(c:1) <C-R>
on_key: e
BufNew(7)
on_key: <Space>
on_key: w
on_key: k
on_key: .
on_key: l
on_key: o
on_key: g
on_key: <CR>
ModeChanged(c:n)
  Unsafe(command-mode)
  suspend: Mode(n:1)
  Trigger(del) Mode(n:1) g' g` \ z <Space> [ g <C-W> <C-Y> ' " ] ` z=
BufNew(1)
  Trigger(del) Mode(c:1) <C-R>

Can't reproduce with (press g):
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/which-key.nvim", opts = {} },
    "nvim-tree/nvim-web-devicons",
    -- add any other plugins here
  },
})


SCM tree shows absolute path for file in remote

This is a single-folder Remote-SSH window. If I click it, it opens a tab with the full path, even if the file is already open. I can debug some more if you can't repro it. Works fine in local

I get this for "go to definition" as well, it opens a tab with the absolute path. I'm sure it's more fundamental than any one feature but I'm not sure where to start assigning.

I think this was probably due to mixing up the remote authorities, from https://github.com/microsoft/vscode/issues/118683


Feature Request: Add survey:date key to nodes

The key survey:date adds the possibility of mentioning, when the feature was last surveyed. This could help a lot in combination with the already implemented "show icon on old objects" option. It would help with keeping the map up to date.
It could be recommended to the user when adding/editing a node and even be prepolulated with the current date for ease of use, similar to the way the bicycle_parking has the type key already filled in.

You can already to add that with the green button at the bottom right (not in editing mode)
Do you want to add/replace this key for every adding/editing ?

I haven't noticed that, thanks for pointing it out.
It would be nice to have it as an option on every node, instead of only old ones, so users can freely use it when they see fit.

In the new release, the survey:date is added by default for each update or new object.
You can disable this in settings


got an KeyError with the tajima.py

Hi, I got an KeyError report with the tajima.py like this:
Traceback (most recent call last):
File "/lustre/home/gaojie/miniconda3/envs/vcf-kit/lib/python3.7/site-packages/vcfkit/tajima.py", line 148, in
main()
File "/lustre/home/gaojie/miniconda3/envs/vcf-kit/lib/python3.7/site-packages/vcfkit/tajima.py", line 144, in main
for i in tajima(args[""]).calc_tajima(wz, sz, args["--sliding"], extra=args["--extra"]):
File "/lustre/home/gaojie/miniconda3/envs/vcf-kit/lib/python3.7/site-packages/vcfkit/tajima.py", line 82, in calc_tajima
AC = variant.INFO["AC"]
File "cyvcf2/cyvcf2.pyx", line 2133, in cyvcf2.cyvcf2.INFO.getitem
KeyError: b'AC'
Could you please tell me how to fix this. Thank you very much!

Hi @JieGao-XTBG
VCFs normally have an AC INFO tag. I believe your VCF is missing this.
##INFO=<ID=AC,Number=A,Type=Integer,Description="Total number of alternate alleles in called genotypes">

You can calculate the AC by using the +fill-tags plugin from VCF-tools:
bcftools +fill-tags <your VCF> > out.vcf
# Then run vcf-kit


Add port for Nucleo-F767ZI

Related: https://github.com/micro-ROS/freertos_apps/pull/44

Is possible to add this board to the CI?

Also add this board to the README.md tables of supported hardware please.


Markdown card for on the dashboard

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Hello,
Is there any way to create a markdown card or something like that, that fills automaticly with all the tgtg sensors, and displays only the sensors, that are active. Ofcourse i would love to see this with the attributes showen as well.
Example:
(only showen when 'available (status > 0, and not sold-out)', otherwise hidden):

'Happy Snacks (attr friendly_name)'
'10 (attr status)' pcs 'magic snack boxes (attr item_url)'
From: '€20,- (attr original_value)', for: '€5,- (attr item_price)'
Pickup from: '20:00 (attr pickup_start)' - '23:00 (attr pickup_end)'

Describe the solution you'd like
Maybe anybody can do something with auto-entities mod and/or markdown card?
I tried, but can't figure it out. I'm lacking skills for this.
Describe alternatives you've considered
Not have it showen on my dashboard... :-/
Additional context
(only showen when 'available (status > 0, and not sold-out )', otherwise hidden):

'Happy Snacks (attr friendly_name)'
'10 (attr status)' pcs 'magic snack boxes (attr item_url)'
From: '€20,- (attr original_value)', for: '€5,- (attr item_price)'
Pickup from: '20:00 (attr pickup_start)' - '23:00 (attr pickup_end)'

I use two custom cards to see which TGTG boxes are available, the auto-enties card and the multiple-entity row.
type: custom:auto-entities
card:
  type: entities
  title: Beschikbaar
filter:
  template: |-
    {% for state in states.sensor -%}
      {%- if state.state>= '1'  and 'sensor.tgtg_' in state.entity_id %}
      {%- if state_attr(state.entity_id, 'pickup_start') is not none  -%}
        {{
          {
            'entity': state.entity_id,
            'name': state.attributes.friendly_name[5:],
            'type': "custom:multiple-entity-row",
            'unit': false,
            'secondary_info': 'Ophalen op ' + state.attributes.pickup_start[8:10] + "-" + state.attributes.pickup_start[5:7] + ' tussen '+ state.attributes.pickup_start[11:16] + ' en ' + state.attributes.pickup_end[11:16] + ', € '+  state.attributes.item_price[:-3],
            'tap_action': {
              'action': 'url',
              'url_path':  state.attributes.item_url}
            }

        }},
      {%- endif -%}
      {%- endif -%}
    {%- endfor %}

Thanks for the card!
Altho they remain empty, even when i receive a notification when there is something available. What i'm i doing wrong?

I don't know... indentation is very important with this card. I had some trouble with it.
If you copy and paste the code in the template editor, does that work?
By the way, there is an error with the pickup time in the card, it's an hour to early in the card

I don't know... indentation is very important with this card. I had some trouble with it.
If you copy and paste the code in the template editor, does that work?
By the way, there is an error with the pickup time in the card, it's an hour to early in the card

On the template page i get this error:
TypeError: '>=' not supported between instances of 'float' and 'str'

That's strange. I copied the code above in my template editor, no problem. Did you copy all the code?
And if you delete the part with >=?

That's strange. I copied the code above in my template editor, no problem. Did you copy all the code?
And if you delete the part with >=?

This is what i put in the editor:

{% for state in states.sensor -%}
  {%- if state.state>= '1'  and 'sensor.tgtg_' in state.entity_id %}
  {%- if state_attr(state.entity_id, 'pickup_start') is not none  -%}
    {{
      {
        'entity': state.entity_id,
        'name': state.attributes.friendly_name[5:],
        'type': "custom:multiple-entity-row",
        'unit': false,
        'secondary_info': 'Ophalen op ' + state.attributes.pickup_start[8:10] + "-" + state.attributes.pickup_start[5:7] + ' tussen '+ state.attributes.pickup_start[11:16] + ' en ' + state.attributes.pickup_end[11:16] + ', € '+  state.attributes.item_price[:-3],
        'tap_action': {
          'action': 'url',
          'url_path':  state.attributes.item_url}
        }

    }},
  {%- endif -%}
  {%- endif -%}
{%- endfor %}

Ssems like this code is working:
type: custom:auto-entities
card:
  type: entities
  title: Beschikbare boxen TGTG
filter:
  template: |-
    {% for state in states.sensor -%}
      {%- if state.state|float(default=0) >= 1  and 'sensor.tgtg_' in state.entity_id %}
      {%- if state_attr(state.entity_id, 'pickup_start') is not none  -%}
        {{
          {
            'entity': state.entity_id,
            'name': state.attributes.friendly_name[5:],
            'type': "custom:multiple-entity-row",
            'unit': false,
            'secondary_info': 'Ophalen op ' + state.attributes.pickup_start[8:10] + "-" + state.attributes.pickup_start[5:7] + ' tussen '+ state.attributes.pickup_start[11:16] + ' en ' + state.attributes.pickup_end[11:16] + ', € '+  state.attributes.item_price[:-3],
            'tap_action': {
              'action': 'url',
              'url_path':  state.attributes.item_url}
            }

        }},
      {%- endif -%}
      {%- endif -%}
    {%- endfor %}

Thanks, added it to the readme.

This is amazing. I never used auto_entities, but would it be possible to add a filter of entities for pickup today or pickup tomorrow?

where do i paste the code?

You could use this line for displaying the pickup times in your local timezone:
'secondary_info': as_timestamp(as_datetime(state.attributes.pickup_start).astimezone()) | timestamp_custom('%a %d/%m') | lower + ' between ' + as_timestamp(as_datetime(state.attributes.pickup_start).astimezone()) | timestamp_custom('%H:%M') + ' and ' + as_timestamp(as_datetime(state.attributes.pickup_end).astimezone()) | timestamp_custom('%H:%M') + ', € ' +  state.attributes.item_price[:-3],


guide requirements Wordpress

@mburridge I've created this guide so we can use to answer questions in the Community Forum and to reduce noise in the Quick Start Guide (a link to this guide will be enough there)
Please, have a look and let me know if you have any suggestions


Defer class initialization to avoid spamming on Conscrypt errors

Considering as a potential fix for https://github.com/square/okhttp/issues/5760
AndroidPlatform uses ConscryptSocketAdaptor which has
    fun buildIfSupported(): SocketAdapter? =
        if (ConscryptPlatform.isSupported) ConscryptSocketAdapter() else null

The main risk with the change would appear to be that we can load the target class, but not dependencies and thus get to the wrong point.


Move widgets between multiple instances

Hi,
i did not find a example in the demos, which allows the exchange of widgets between multiple gridster instances. Is this already possible. A hint would be great.
For better understanding:
I want to implement a kanban like board that allows dragging tasks to different status lanes.
Thanks!

no there is no concept of that in the code that I have come across.


How to create a custom task that can run against two orgs

I have a unique case where functionality of extract_dataset and load_dataset tasks are not sufficient. So, I started writing a custom task and stuck with this.
Let's assume $ cci org list gives this output:

┌Connected Orgs───┬───────────────────────────────────────────────┬────────────┐
│ Name            │ Default │ Username                            │ Expires    │
├─────────────────┼─────────┼─────────────────────────────────────┼────────────┤
│ UAT             │         │<EMAIL_ADDRESS>       │ Persistent │
├─────────────────┼─────────┼─────────────────────────────────────┼────────────┤
│ devsandbox      │ ✔       │<EMAIL_ADDRESS>       │ Persistent │
└─────────────────┴─────────┴─────────────────────────────────────┴────────────┘

I want to create a custom task which can be run as below:
$ cci task run dummyTask -o baseOrgName UAT
from cumulusci.tasks.salesforce import BaseSalesforceApiTask

class dummyTask(BaseSalesforceApiTask):
    api_version = "46.0"
    task_options = {
        "baseOrgName": {
            "description": "Org to use for querying data from",
            "required": True,
        }
    }

    def doSomething(self):

        # THIS IS WHERE I AM STUCK
        # point self.sf to baseOrgName parameter passed.

        # Query some data
        res = self.sf.query('SELECT Id FROM Account')

        # point self.sf to default org.

        # update some data
        res = self.sf.update(accData)

    def _run_task(self):
        self.doSomething()

I spent hours doing reverse engineering on how to point self.sf to the org I want but with no success.

You don't need to add the baseOrgName option; every task extending BaseSalesforceApiTask can already be used with any org. Run with this command:
cci task run dummyTask --org UAT

and self.sf will be pre-authorized for the UAT org.

@davisagli  Thanks for the reply. But in the same task, I want to switch self.sf to default org. How can I do that?

How are extract_dataset and load_dataset insufficient?

@sfdcale Sorry, I missed that you want to access two different orgs in the same task. I don't think we have any established precedent for this but it should be possible with something like this:
from cumulusci.salesforce_api.utils import get_simple_salesforce_client

base_org = self.project_config.keychain.get_org(self.options["baseOrgName"])
base_org.refresh_oauth_token(self.project_config.keychain)
sf = get_simple_salesforce_client(self.project_config, base_org)

Thanks @davisagli .  I will try this.
@davidmreed  Here is my requirement at very high level:

Query KnowledgeArticleVersion data from UAT sandbox as per mapping.yml -- solved this using extract_dataset(There are few record which I could not retrieve because of issue 1662)
Load KnowledgeArticleVersion data into dev sandbox as per mapping.yml  -- solved this using load_dataset (Ran into bulk batch character limit, posted it on community. In the meanwhile, hacked it by updating batchsize in cumulusci/tasks/bulkdata/step.py to 100  )
Publish 'KnowledgeArticleVersion' records loaded though KbManagement REST API. -- For this I am using a custom task.
Query KnowledgeArticle table from UAT sandbox and get the corresponding KnowledgeArticle Id from dev sandbox(matching with article title and url).
Populate those article Ids in a different table.

I want to implement steps 4 and 5 using a single custom task but stuck on how to switch self.sf between different orgs.

@davisagli   That code snippet you gave worked. Closing the issue.


🐰 group name updated to comply with TL500 🐰

What is this PR About?
In order to make things easier in this section of the enablement, group name should be updated as student/
How do we test this?
Provide commands/steps to test this PR.
Install the chart as it is described in README :)

Cheers Chancer! I guess I can PR it agian to add my yes |  cmds to no autogenerate a passwd 📦


clarify privacy properties of the protocol

As an extension of https://github.com/penumbra-zone/web/issues/1548, we should aim to transparently and concisely communicate the privacy features we currently support (and plan to support in the future). The privacy properties of the protocol can be confusing since they're not immediately clear. Besides refactoring our guide, it’s not entirely clear what the best way to communicate this is. See https://github.com/penumbra-zone/penumbra/pull/4695 for relevant scope.

1. Sealed-Bid Batch Swaps: currently, batch swaps execute all intents within a block and the assets being swapped are public. "Sealed-bid" batch swaps would protect the privacy of the input assets by not revealing them publicly.
2. Flow Encryption: Swap amounts are currently public. "Flow encryption" would hide these values and offer front-running protection by encrypting individual swap amounts. Validators aggregate these encrypted values, decrypt the batch totals, and reveal them publicly. This ensures that individual swap amounts remain private.
In V2, these features would allow only the batch totals to be publicly revealed while keeping the individual assets and values in a swap private.
cc @grod220

Yes, please. Does this more properly belong in https://github.com/penumbra-zone/guide though?

Yes, please. Does this more properly belong in https://github.com/penumbra-zone/guide though?

good point, will move 👍


[Discussion] Client side form validation

Hello, I know that there is builtin html form validation. I am wondering if there are plans for more robust client side form validation? Is the recommendation to just use stimulus and some javascript?

@JonathanLorimer I think you could create a new topic on https://discuss.hotwire.dev/
But I think probably the recommendation will be to use stimulus and some js, since you will need run this same validations on server, right?


Any project generated with CRA is missing modules and/or required files from a variety of dependencies

Describe the bug
Any project generated with CRA is missing modules and/or required files from a variety of dependencies
Did you try recovering your dependencies?

Yes, the issue persists for any new project generated with CRA.
Which terms did you search for in User Guide?

I searched for 'missing modules' in the user guide, but honestly didn't expect to find anything since this issue only began in the past couple days.
Environment

Environment Info:
current version of create-react-app: 3.4.1
running from /Users/jjpiv/.config/yarn/global/node_modules/create-react-app
System:
OS: macOS 10.15.5
CPU: (8) x64 Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
Binaries:
Node: 14.4.0 - /usr/local/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.4 - /usr/local/bin/npm
Browsers:
Chrome: 83.0.4103.97
Firefox: 77.0.1
Safari: 13.1.1
npmPackages:
react: ^16.13.1 => 16.13.1
react-dom: ^16.13.1 => 16.13.1
react-scripts: 3.4.1 => 3.4.1
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce

(Write your steps here:)

yarn create react-app test-app
cd test-app
yarn start

Expected behavior

I expected the app to compile successfully and launch a new browser tab to view the default CRA app.
Actual behavior

The following error appears in the console:
`yarn run v1.22.4

$ react-scripts start
internal/modules/cjs/loader.js:1032
throw err;
^
Error: Cannot find module './CodeNode'
Require stack:

/Users/jjpiv/Development/test-app/node_modules/source-list-map/lib/SourceListMap.js
/Users/jjpiv/Development/test-app/node_modules/source-list-map/lib/index.js
/Users/jjpiv/Development/test-app/node_modules/webpack-sources/lib/RawSource.js
/Users/jjpiv/Development/test-app/node_modules/webpack-sources/lib/index.js
/Users/jjpiv/Development/test-app/node_modules/webpack/lib/Compiler.js
/Users/jjpiv/Development/test-app/node_modules/webpack/lib/webpack.js
/Users/jjpiv/Development/test-app/node_modules/react-scripts/scripts/start.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:1029:15)
at Function.Module._load (internal/modules/cjs/loader.js:898:27)
at Module.require (internal/modules/cjs/loader.js:1089:19)
at require (internal/modules/cjs/helpers.js:73:18)
at Object. (/Users/jjpiv/Development/test-app/node_modules/source-list-map/lib/SourceListMap.js:7:18)
at Module._compile (internal/modules/cjs/loader.js:1200:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
at Module.load (internal/modules/cjs/loader.js:1049:32)
at Function.Module._load (internal/modules/cjs/loader.js:937:14)
at Module.require (internal/modules/cjs/loader.js:1089:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/jjpiv/Development/test-app/node_modules/source-list-map/lib/SourceListMap.js',
'/Users/jjpiv/Development/test-app/node_modules/source-list-map/lib/index.js',
'/Users/jjpiv/Development/test-app/node_modules/webpack-sources/lib/RawSource.js',
'/Users/jjpiv/Development/test-app/node_modules/webpack-sources/lib/index.js',
'/Users/jjpiv/Development/test-app/node_modules/webpack/lib/Compiler.js',
'/Users/jjpiv/Development/test-app/node_modules/webpack/lib/webpack.js',
'/Users/jjpiv/Development/test-app/node_modules/react-scripts/scripts/start.js'
]
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.`

Reproducible demo

https://github.com/jjpiv/test-app

If I'm doing something incorrectly that's causing this issue, I'd be glad if someone could enlighten me. Otherwise, it seems like the CRA team really needs to address this issue because it continues to be a problem.

I found this issue was the result of using yarn to start the development server. After removing yarn and then creating a new project, the instructions say to use npm start. Thankfully, this works successfully. Still need to investigate what about using yarn contributes to this problem.

Still looking into this issue.


Logic apps SQL Connector to on-premise using integrated windows authentication

Hi,
Can someone provide details to my question below?
https://stackoverflow.com/questions/50977534/logic-apps-sql-connector-to-on-premise-using-integrated-windows-authentication

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e190390-dc83-246e-3e69-189f33d67ed7
Version Independent ID: 66132130-9d94-fc33-7bc4-a54ee270efbc
Content: Connect to SQL Server or Azure SQL Database - Azure Logic Apps
Content Source: articles/connectors/connectors-create-api-sqlazure.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@sathishnb4u Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @sathishnb4u - Thank you for your question. Since this Github issue is a duplicate and doesn't address any specific content of this documentation, we will now proceed to close this thread. However, I will also be posting an answer to your question on Stackoverflow today.


Stray < sign in about page

Stray < sign in about page
See team at<EMAIL_ADDRESS>if you have licensing,  at https://www.openhistoricalmap.org/about

Fixed finally!


Refactor 3.11 deployment script

Simplify file globbing logic and adjust exit status to improve user
feedback.
Also add feedback for when no deployment files are found. This scenario
yields exit code 3, avoiding UNIX reserved exit codes.
Signed-off-by: Lucas Caparelli<EMAIL_ADDRESS>Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster

Great, sounds good tome, the only missing thing is the jira :)

Great, sounds good tome, the only missing thing is the jira :)

I told him that opening a JIRA won't be required, @LCaparelli do you mind opening a JIRA? You can assign it to me and I'll fill in the blanks. Thanks!

I told him that opening a JIRA won't be required, @LCaparelli do you mind opening a JIRA? You can assign it to me and I'll fill in the blanks. Thanks!

Sure thing, here it is: KOGITO-1453. :-)
I tried filling some of it the best I could, sorry if something isn't quite right.

Adjusted. @LCaparelli do you mind also reviewing those? I believe they might have some room for improvements using this same technique.
https://github.com/kiegroup/kogito-cloud-operator/blob/master/hack/run-tests.sh#L91
https://github.com/kiegroup/kogito-cloud-operator/blob/master/hack/scorecard.sh#L17
Thanks!

Adjusted. @LCaparelli do you mind also reviewing those? I believe they might have some room for improvements using this same technique.
https://github.com/kiegroup/kogito-cloud-operator/blob/master/hack/run-tests.sh#L91
https://github.com/kiegroup/kogito-cloud-operator/blob/master/hack/scorecard.sh#L17
Thanks!

@ricardozanini pushed a change in scorecard.sh along with some nitpicking on 3.11deploy.sh regex so it matches scorecard.sh.
I didn't modify run-tests.sh similarly as the file array in there will be used to download the file from github using curl. Since the files are not currently in the filesystem it's not possible apply the same technique.
Thanks!


SyntaxTree.LocateOwner at trailing edge of HTML elements produce inconsistent owners in and outside of code blocks

Take the Razor document with cursor at the pipe:
@{
    <div>|
}

If you do syntaxTree.Root.LocateOwner(cursorLocation) you will get back a MarkupTextLiteral representing the newline and the ending curly.
Now lets say it was a void tag:
@{
    <input>|
}

LocateOwner produces a CSharpStatementLiteral for the newline (because there's no Razor error)
If you do the same thing outside of a @{ block:
<div>|

LocateOwner provides the > as the owner.
Overall all of this funky behavior results in huge issues when trying to apply HTML specific interactions at tooling time.

#8956 introduced a new API here, FindToken. This API is much more rigorous than LocateOwner, and much more suited to IDE operations. As an example, we were able to delete the entirety of the workarounds in AutoClosingTagOnAutoInsertProvider in #8979. Closing this out as implemented.


viewmodel translate

viewmodel translate doesnt work

I’m not sure why you would want to use translate, but it works if you change the angle-translate.


How to disable by code "know your location" popup

Hi,
I would like to disable by javascript the popup asking for sharing location.
I read the documentation available: https://developers.google.com/web/fundamentals/native-hardware/user-location
But I didn't find the way to disable it.
Any ideas?
Thanks

There is no way to disable the permission popup.


Formalize component attributes and structure for GUI building

Each component will need to have a GUI-side set of attributes that can set and interface with the SpurCore side of the code. We will need to standardize how those attributes are interfaced with, and how we can construct dialog boxes that allow us to adjust individual component attributes.
It's likely that creating a component will require both adding the code, and then adding a GUI-side dialog or interface that shows the proper components. I'm thinking there will be a widget spot that we can simply point at various custom widgets to update depending on the selected component.

Change of design direction slightly on this, closing for future feature.


Higher-level feature flags for test disablement

This is a start down the road to getting tests passing on CoreCLR.
I think the main thing to discuss is strategy.  In this PR I've done this:

Introduce new feature flags for the high-level MSBuild features that are disabled.
#ifed out tests that touch the high-level features using those flags.
Added the first error in what will be a series that we'll throw when a feature is disabled.

Pros to this approach:

Easy to understand why a test is disabled.
Hopefully easy to enable a feature by setting that feature flag, then tracking down and fixing test failures.
Easy to run tests because expected-to-fail tests aren't even built.

Cons:

Feature flags for tests (based on MSBuild features) are decoupled from the reason features are disabled (based on CoreCLR features).
Compiling out rather than tagging tests means number of tests varies.

Thoughts?

LGTM. Agree with the pros/cons but after discussion at today's stand-up it seems like the right way to go.


Issue with ctx->flags after upgrading to version 1.1.1d

The error I see is:
error: dereferencing pointer to incomplete type
ctx->flags |= (EVP_CIPH_FLAG_LENGTH_BITS);

My code is:
EVP_CIPHER_CTX  *ctx;
ctx = EVP_CIPHER_CTX_new();     // This was not part of my code while using 1.0.2p. Added it for 1.1.1d
EVP_CIPHER_CTX_init(ctx);       // Adding or removing this line makes no difference
ctx->flags |= (EVP_CIPH_FLAG_LENGTH_BITS);
....
....
EVP_CIPHER_CTX_free(ctx);

Is there something wrong with the way I'm updating flags variable?

Side note: that function needs documenting...

EVP_CIPHER_CTX_set_flags(flag_value) adds the flags to the set of flags. Its equivalent to:
ctx->flags |= flag_value;

EVP_MD_CTX_clear_flags(flag_value) clears the flags from the set of flags. Its equivalent to:
ctx->flags &= ~flag_value;

EVP_MD_CTX_test_flags(flag_value) clears the flags from the set of flags. Its equivalent to:
(ctx->flags & flag_value)

Anything you need to do with the flags should be expressible using one of those forms.

Thanks a lot...


Generate nuget package for class library in RC2

Following is my project.json
`{
"version": "Test-1.0.0",
"authors": [ "Alan" ],
"packOptions": {
"tags": [ "Test", "Project" ]
},
"dependencies": {
"Microsoft.AspNetCore.Mvc": "1.0.0-rc2-final",
"Microsoft.AspNetCore.Mvc.Core": "1.0.0-rc2-final",
"Microsoft.AspNetCore.Mvc.TagHelpers": "1.0.0-rc2-final",
"Microsoft.AspNetCore.Hosting": "1.0.0-rc2-final",
"Newtonsoft.Json": "8.0.3",
"System.Collections": "4.0.11-rc2-24027",
"System.Data.Common": "4.0.1-rc2-24027",
"System.Linq": "4.1.0-rc2-24027",
"System.Linq.Queryable": "4.0.1-rc2-24027",
"System.Reflection.Emit": "4.0.1-rc2-24027",
"System.Collections.NonGeneric": "4.0.1-rc2-24027"
},
"frameworks": {
"netstandard1.5": {
"imports": [
"dnxcore50",
"portable-net451+win81"
]
}
}
}
`
.net CLI command "dotnet pubish" does not create nuget package for my class library

You might need to use dotnet pack to generate nupkgs. That said, this would be a question for https://github.com/dotnet/cli


python < 2.7 reports errors on logging.captureWarnings(True) in collector.py

Since we run RedHat EL 6.6 we use python 2.6.6 which should be fine according to the system requirements (python 2.4+). But we get error messages about captureWarnings not being available in line 168 in collector.py:
...
Initialize Logger
logging.captureWarnings(True)
...
Looks like this change was introduced by
commit a2bde9d38bca99e5d71371ac22ea74ea6cae7d83
at 16th Oct. 2014
captureWarnings is only available for python 2.7+, older versions apparently don't have it
I suggest to protect this line enabling it only for python versions 2.7+, e.g.
    if sys.version_info > (2, 6):
        logging.captureWarnings(True)

Maybe somebody else knows a better solution?
Many thanks in advance
Michael

Sorry, I had pushed f4e91e37e04ce6fe56befc0123514a6bf614a529 to my repo, but I forgot to push it upstream. I'll get that sorted out tonight

I have hit this same bug as well in my latest 4.0.57-2 rpm build on CentOS 6.5 and python 2.6.6

Hi Rob,

Many thanks! Have you already pushed your change to the master?

Cheers
Michael

Gesendet: Dienstag, 06. Januar 2015 um 03:26 Uhr
Von: "Rob Smith"<EMAIL_ADDRESS>An: BrightcoveOS/Diamond<EMAIL_ADDRESS>Cc: audimann<EMAIL_ADDRESS>Betreff: Re: [Diamond] python < 2.7 reports errors on logging.captureWarnings(True) in collector.py (#786)
Sorry, I had pushed f4e91e3 to my repo, but I forgot to push it upstream. I'll get that sorted out tonight
—
Reply to this email directly or view it on GitHub.

same issue here :(

this still has not been merged into master: https://github.com/BrightcoveOS/Diamond/blob/master/src/diamond/collector.py#L168

This still appears broken. Can this change please be rolled back or at least a try block put around it.

kormoc appears to be inactive since the beginning of January. Anybody knows how we can get the change merged into the distribution? Who to contact?

This repo has moved to https://github.com/python-diamond/Diamond
Please open a new ticket there if this issue is not resolved with the current code there.
Thanks!


Tests: init module tests

:100:

@peeklondon / @radeklos could you check this when you get a spare min, would be awesome to get this released first thing Monday.

Looks good to me :+1:

:+1:


make torch optional dependency

closes #21
This does NOT make scikit-learn an optional dependency. This is intentional, as this package is used for mock models offered within the package, and will be used for monitoring functions.

Codecov Report

Merging #29 (d05db52) into main (e9b8b6f) will decrease coverage by 0.59%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   94.22%   93.63%   -0.60%
==========================================
  Files          27       27
  Lines         727      738      +11
==========================================
+ Hits          685      691       +6
- Misses         42       47       +5

Impacted Files
Coverage Δ

vetiver/handlers/_interface.py
85.71% <80.00%> (-14.29%)
:arrow_down:

vetiver/handlers/pytorch_vt.py
90.00% <83.33%> (-7.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b8b6f...d05db52. Read the comment docs.


Commits from https://github.com/brown/bazel-mode

Unfortunately, I don't think we can accept the GPL license (the repository uses Apache 2.0, and I think we shouldn't mix).

The problem with an Apache license for Emacs Lisp code is that
all the code that ships with GNU Emacs is covered by the GNU GPL.
If bazel-mode becomes popular, I'd like it to be easy for the
Emacs maintainers to incorporate it into their distribution.


Fix some security issues and add Bandit to our CIs

I ran bandit on our codebase today. This addresses some of the HIGH and MEDIUM severity security issues that it found, and adds TODOs for some that aren't addressed in this PR (yet).  Summary:

wherever we use hashlib.md5 we're using it to hash a file or Python object (not password or other secret) so I've added usedforsecurity=False everywhere
calls to pickle.loads are marked as #noqa B301 when they occur in tests (in all cases we're loading something that we wrote, so the file is known to be safe)
the one call to pickle.loads that is not in a test is marked with a TODO
TODOs added for replacing various xml.etree.ElementTree.parse calls with equivalent calls from defusedxml package, which is the workaround suggested in the stdlibrary docs
TODO added for sanitizing user-passed values that are used to build up a command-line call passed to os.system() (maxfilter)
TODO for _requires_module using exec() --- probably OK as-is since users aren't expected to call _requires_module anyway, but there might still be a safer alternative
one change from eval to ast.literal_eval

There were 7 high and 21 medium issues detected; a couple were false positives (format string misidentified as SQL), some were not exactly false positives but non-issues (like reading pickles that we wrote, in tests), some were genuine (exec, parse, os.system).  There were also >6000 LOW severity issues, which I didn't even look at yet.
I'd be interested to hear other dev's thoughts on this. In particular, whether we should add additional security scanning as part of our CIs. Some options are:

bandit docs
https://github.com/marketplace/actions/pysa-action
https://github.com/marketplace/actions/hcl-appscan-codesweep
https://github.com/globocom/huskyCI
https://github.com/ZupIT/horusec

I haven't reviewed all of these carefully yet.
*note: the # noqa BXXX annotations don't actually work, the right way to do it is with a [tool.bandit] entry in pyproject.toml ... which we can do if we adopt bandit.

We should use https://github.com/marketplace/actions/bandit-check or similar in https://github.com/mne-tools/mne-python/blob/82b2e82e42c5167f30df371f3ca7e18b86a2313a/.github/workflows/tests.yml#L17

OK with me to add bandit-check to CIs. WDYT about adding defusedxml as a dependency?

WDYT about adding defusedxml as a dependency?

Based on the git grep:
$ git grep xml\.etree
mne/channels/_dig_montage_utils.py:import xml.etree.ElementTree as ElementTree
mne/channels/_standard_montage_utils.py:import xml.etree.ElementTree as ElementTree
mne/io/egi/events.py:from xml.etree.ElementTree import parse
mne/io/nedf/nedf.py:from xml.etree import ElementTree

it looks like we more or less just use it for EGI/MFF, nedf, and maybe some dig (possibly also from EGI/MFF). Based on how often people share files for debugging and analysis, it does seem like a good idea to protect against something like read_raw_egi(fname) being a security risk. And it being recommended by the main Python standard library folks (and it being licensed under Python Software Foundation License, which is BSD-compatible it seems) makes it seem worthwhile 👍

@drammock let me know if you want help with CIs. But I think it's okay to get the CI running with however much work you want to do so far (maybe you've already done enough?) and add ignores to pyproject.toml for now. And we tackle the other ones later after opening an issue tagged for 1.6 reminding us to do it

I think adding bandit checks to our CI is a great idea!

OK this is ready for review. Bandit is now running in our CIs: https://github.com/mne-tools/mne-python/actions/runs/6030474031/job/16362411943?pr=11937
Notes: config options are pretty limited. You can exclude files/folders for all checks or you can exclude specific checks for all files but there is no way to exclude certain checks only on certain files. Thus a handful of # nosec comments in our tests, to mark those particular instances of pickle.loads as safe. I also marked a couple # nosec things that are either deprecated (so they'll go away soon) or have associated # TODO comments, just to get things green.
The exception to the "config is limited" statement is assert_used which is apparently important enough to get a special config value (presumably because of pytest). I've gone ahead and configured it to ignore assert usage in test files, but note that the CI is also currently configured only to report vulnerabilities of severity MEDIUM or higher, so that config is redundant / impotent at the moment. I left it in because one day we might make the CI pickier and allow it to fail for LOW severity issues (in which case we'll still want to ignore assert in pytest tests).

Great work, @drammock!

Looks like bandit is not happy with your kwargs fix for 3.8. Maybe make a _safe_md5 function that does this stuff and put it in utils with its own inline ignore, then use this _safe_md5 everywhere we currently hashlib.md5?

@larsoner could you look at the CI errors here? They're assertion errors in the brain tests.

@drammock I pushed a couple of fixes for one or two of the remaining TODOs, marking for merge-when-green, thanks!

Thanks for getting this one over the finish line @larsoner


Add v2 signature presigned get_object tests

This adds tests for get_object presigned URLs
using signature v2.
Also code formatting.
This change depends on [1].
[1] https://github.com/ceph/ceph/pull/59977

@tobias-urdin i was able to remove the formatting changes from that commit while preserving your authorship. i added a second commit of my own with a couple put_object tests

thanks!

cherry-picked to ceph-master


Lightbox opening up at lower left bottom of page

Hi,
I used Bower to install Lity in my Wordpress site but when I click the link, there is no lightbox effect. The video simply opens up and begins to play at the very bottom left part of the page (I have to scroll to see it). It is also about 1/5 the correct size.
Here is my code (I am also using Bootstrap), any help to get this to appear correctly in the center of the page with the darkened background would be greatly appreciated.

Sample Featured Video

Sample Featured Video

That sounds like the CSS is missing. Ensure that the CSS file is loaded.

Thank you, you were right. For whatever reason, Bower was not allowing the CSS to load. I manually installed the CSS and works fine.


PWN-3522 - Upload feature APK and release AAB to slack

Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-3522
Description of Work

upload APK to Firebase AND Slack

minor comments


Upgrade to pants 2.17.0

Looks good, although the CI pants test has the warning about use_rust_parser; could you resolve that before merging?

Oopsie, was supposed to include that change, too! Done.


New ideas about getting a list of coordinates

The only coordinate which is updated regularly is the reference datetime.
All the other coordinates (ensemble members, forecast steps, parameters, spatial coordinates) are only updated every few years.
I'm wondering if the way forwards is to:
reference datetimes
Keep the existing Rust code for updating the list of reference datetimes. This works well already and runs quickly (a few seconds), and could run even faster by shipping the majority of the reference datetimes with hypergrib, and only getting the newest reference datetimes.
all other coordinates
Generate the list of coordinates using a mixture of reading the docs & writing some Python code to grab relevant file listings from S3 & output something like a YAML file. This YAML file would be shipped with hypergrib and read by the Rust code. Users wouldn't have to run the Python code.
How to store the metadata
YAML would be human-readable (and would make for nice diffs).
But something like Parquet would be much faster to load. Perhaps we'd use the filename and directory to specify details, e.g. GEFS/v11/reference_datetimes.parquet.
Or, maybe the best of both worlds is we keep something human-readable in the git repo. For the MVP we read directly from the YAML. Later, the first time the user runs hypergrib, it converts the YAML to Parquet.

Ways forward:

[ ] Move the info in hypergrib/src/datasets/gefs/version.rs into a hand-written YAML file because both Rust and Python will need this info. Maybe include formatting templates for the grib/idx filenames, e.g.:

formatting_template: gefs.%Y%m%d/%h/pgrb2{param_set}/ge{ens_member}.t{%h}z.pgrb2{forecast_step}.idx
parameters:
  - name: Temperature
    abbreviation: TMP
    param_set: a

See the bottom of the new design.md in #29.

Let's do some very hacky Python just to get a feel for what's in GEFS. Just a notebook which lists the contents of the object stores. Don't attempt to load the YAML into Python.
Only consider the latest version of GEFS
Only consider a small subset of coord labels, where there are no missing coord combinations
Write the YAML primarily for consumption into Rust (later, we may also want to load into Python. But it'll be easier to modify the YAML in Python).
Then write a minimal Rust hypergrib that loads the mostly hand-written YAML and pumps glorious GRIB data into xarray!

I've made a start on some Python code to explore the NWP file structure here: https://github.com/JackKelly/explore_nwps

This is very much in-progress over at the explore_nwps repo, so I'll close this hypergrib issue for now


Add coco dataset download script

Motivation
Add a script to download coco2017 dataset
Modification
Add a python file in tools
BC-breaking (Optional)
This script do not link any other files
Use cases (Optional)
You can use command "python tools/download.py --win" to download coco2017 dataset.
Linux for using command "python tools/download.py
You can alse use flag --unzip to unzip the zipfiles
such as python tools/download.py --win --unzip
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Kindly ping @q3394101

@q3394101 Hi, we will take over this PR and support more dataset. This PR will be closed and your commits will be kept in #7015


Allow insertion of null primary keys

According to the SQLite FAQ if you insert NULL as the primary key it will pick it automatically for your but if your INSERT statement inserts the primary key column the generated statement will not allow inserting a null primary key.

Maybe you can create insert query without primary key in it

What I'm trying to prevent is this:
if (existing == null) {
  insert.bind(col1, col2, col3, col4)
  insert.program.executeInsert()
} else {
  update.bind(existing._id(), col1, col2, col3, col4)
  update.program.executeUpdateDelete()
}

and rather have this:
if (existing == null) {
  insert.bind(existing?._id(), col1, col2, col3, col4)
  insert.program.executeInsert()
}

I have a lot of columns and duplicating the code is pretty cumbersome so if I could use INSERT OR REPLACE I would reduce the number of LOC quite a lot.


Problem with run server with installed py-avataaars

I installed packages from requirements.txt but still I have problem with run server. I receive message from screenshot. Do you know what I should do with that?
Best regards, Bartosz.

This solution may help you.


JAV-254, 274. Support seckill query function.

Function list:
JAV-254, grabbed coupons are viewable.
JAV-274, remaining coupon viewable.
Signed-off-by: MabinGo<EMAIL_ADDRESS>

Coverage remained the same at 94.017% when pulling 549184246fc3476c4ac20ab2170f60468e21f5e3 on MabinGo:addQueryService into a6f657fc64e504cb30e5289362cc5a0f0b4ab0cc on ServiceComb:master.

Coverage decreased (-0.3%) to 93.706% when pulling a99c4c5cb374fe9426b2a72187056683072fbe2b on MabinGo:addQueryService into a6f657fc64e504cb30e5289362cc5a0f0b4ab0cc on ServiceComb:master.

Coverage decreased (-3.2%) to 87.171% when pulling 649469d0d84f33feb9083919a9b331723ebeb5b7 on MabinGo:addQueryService into 05b3451f7fe0c16ce9e148d2eff353c76a8bf682 on ServiceComb:master.

Coverage remained the same at 90.385% when pulling d70a22dd3470eb70018803a6f7326cf400763715 on MabinGo:addQueryService into 05b3451f7fe0c16ce9e148d2eff353c76a8bf682 on ServiceComb:master.

Coverage increased (+4.2%) to 94.624% when pulling d96f3a0c44942c691c02093b7ded9018c80299bd on MabinGo:addQueryService into 05b3451f7fe0c16ce9e148d2eff353c76a8bf682 on ServiceComb:master.

Coverage increased (+0.5%) to 95.38% when pulling 8ae60a97914fb7f21b7e7eead3a65231b39f7e13 on MabinGo:addQueryService into 7c0624abd1fc872f2080e7383c92740769310a1f on ServiceComb:master.

Coverage increased (+0.04%) to 94.96% when pulling f58b3d13c6ce6f032a8e78ffe6e2895908255da9 on MabinGo:addQueryService into 7c0624abd1fc872f2080e7383c92740769310a1f on ServiceComb:master.

Coverage increased (+0.04%) to 94.96% when pulling 24de65f9e043228b7be5f62d4615a1ab3bc54b49 on MabinGo:addQueryService into 7c0624abd1fc872f2080e7383c92740769310a1f on ServiceComb:master.

Coverage increased (+0.6%) to 95.491% when pulling 70e8ff28a3f6479725a6328c2819a20628e45bba on MabinGo:addQueryService into 7c0624abd1fc872f2080e7383c92740769310a1f on ServiceComb:master.

Coverage increased (+0.4%) to 95.342% when pulling e811983e31a9d05c6865bbe84da5284b9bf2d5d8 on MabinGo:addQueryService into 7c0624abd1fc872f2080e7383c92740769310a1f on ServiceComb:master.

Coverage increased (+0.5%) to 95.368% when pulling f93f72db317eb9beb12286c4075b8fb9a10ebbec on MabinGo:addQueryService into 7c0624abd1fc872f2080e7383c92740769310a1f on ServiceComb:master.

deprecated by https://github.com/ServiceComb/seckill/pull/10


Show the username for locked pages

Store the lockedBy username when a page is locked. Fixes a bug where the ‘locked’ modal opens but the username is empty, preventing you from seeing who has the page open for editing.

I’m not sure who to ping for a review on this, so I’ve tagged @snblickhan.


Revert "Jvenstad/do unified"

Reverts vespa-engine/vespa#5485
Seems to break integration application change integration test

@aressem FYI

👍

Let me fix instead: https://git.ouroath.com/vespa/hosted/pull/5735


changing keybinding

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as deleting the YoshiCrafter29 folder from AppData) before submitting an issue.
If you're using an older version of the engine, check if the bug haven't been already fixed
PS : the "everything goes black while changing state in developer mode bug" is not a bug, it's been designed this way to refresh all bitmaps between states to allow easier modding.
Which target are you using?

[x] Windows
[ ] Mac
[ ] Linux

What version of the engine are you using (Bottom left of the screen in main menu) ?
1.5.1
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
tying to change the keybinding
Please describe your issue. Provide extensive detail and images if possible.
you cant change the keybinding

ok, i was clicking and all but the 1st time i opened the engine it didn't work, but now i can change my keybinding


Add dropdown menu

closes #2183
I added the dropdown menu and the user avatar, if you have any suggestions of improvements please comment a list and i'll do the adjustements.
Web frontend checklist

[x] Formatted my code with yarn format && yarn lint --fix
[x] There are no warnings from yarn lint
[ ] There are no console warnings when running the app
[ ] Added any new components to storybook
[ ] Added tests where relevant
[ ] All tests pass
[x] Clicked around my changes running locally and it works
[x] Checked Desktop, Mobile and Tablet screen sizes

@lucaslcode

PS: Here is a screenshot of how it's looking, if you know a component that would make the button that wrap the avatar and burger icon looks better, i'd be pleased to know it and make the changes.

I fixed most of the feedback you gave @lucaslcode @darrenvong but there's still two thing that goes wrong and i'm not sure how to solve those.

First i can't replace classes => className as this throws me an error ( Navigation.tsx, lines 426, 280 )
I get an error about refs but not sure i understand it ( see picture below ) ( Navigation.tsx, line 405 )

I get an error about refs but not sure i understand it ( see picture below ) ( Navigation.tsx, line 405 )

I think that's a known "bug" from Material UI using an old/deprecated React API that's outside of our control. Should be fixed when we eventually move to v5 of the library.

First i can't replace classes => className as this throws me an error ( Navigation.tsx, lines 426, 280 )

Yeah I think you're right that this doesn't work with our custom MenuItem unless we remove the Omit<MenuItemProps, 'classname'> on the component's props typing. @lucaslcode what do you think about that? I think you have more experience touching that component than I do to comment more :)

I will have another look later, but I believe I omitted  classNames to avoid customization so we wouldn't have different looking menus in different spots.
In this case, we do want to be able to have a 'title' item and a divider, so add them as props onto our MenuItem to be used whenever we want :) (To be clear, the classNames stuff will the be moved to the component, and in Navigation is will just use the props.)

@lucaslcode @darrenvong i applied every changes you requested, i hope you'll find it good ! Tell me if anything i can change to perfect it and successfully close this issue ^^

@darrenvong @lucaslcode I applied requested changes, and i also removed profile and messages from the header as those are presents inside the menu. If they should remain, i can revert those last changes

@Vincent-Projects Yes leave them there I think, people will be confused. It's okay to have twice for now.


Random error: Unexpected token *

Current Behavior
Obfuscating a large file with code, using max settings can sometimes cause the error: Unexpected token *
This error does not happen always, but sometimes. I assume it's an bug under obfuscation where something might be random..?
Your Environment
I'm using webpack-obfuscator.

Obfuscator version used: 0.27.2
Node version used: v12.16.1

Need more info about how to reproduce this


add dynamic participants

Please check if what you want to add to go-lachesis list meets quality standards before sending pull request.
Please provide package links to:

github.com repo:
godoc.org:
goreportcard.com:
coverage service link (cover.run, gocover, coveralls etc.), example: [![cover.run](https://cover.run/go/github.com/user/repository.svg?style=flat&tag=golang-1.10)](https://cover.run/go?tag=golang-1.10&repo=github.com%2Fuser%2Frepository)

Make sure that you've checked the boxes below before you submit PR:

[x] I have added my package in alphabetical order.
[x] I have an appropriate description with correct grammar.
[x] I know that this package was not listed before.
[x] I have added godoc link to the repo and to my pull request.
[x] I have added coverage service link to the repo and to my pull request.
[x] I have added goreportcard link to the repo and to my pull request.
[x] I have read Contribution guidelines, maintainers note and Quality standard.

@dev10 Any updates?

@dev10 Any updates?

Hi Sam, no updates. From Maxims input

this code is not relevant because we are planning to work with POS

If you can provide some input as to what can be salvaged that would be great.

outdated


Non-Functional Repository

Hi,
Following the instructions in the README do not work in Ubuntu 15.04. There is an error with PIL 1.1.7. Please help.
Thanks!

Hey there, I'm sorry to hear that. I'm no longer working at Twilio and unfortunately I don't have the bandwidth to maintain this repository any longer. I suggest reaching out to Twilio and seeing if you can get connected with someone who could help.


Fix polyline regression with log depth

Cesium's fancy polyline rendering sometimes needs to clip lines at the near plane. But it was still using the depth of the original vertex after clipping.
Fixes  #8663
I had hoped this would fix all the log depth polyline problems, but alas no. There's still something dodgy going on with polyline depth. In any case, this was a clear bug and this fix should go into 1.68.
This PR also includes #8608 (Spector.js shader editor support) because I merged that in in order to help debug this. If anyone has a problem with that, let me know and I'll rebase this PR to remove those changes. But those changes are awesome, so please just merge them too. :)

Thanks for the pull request @kring!

:heavy_check_mark: Signed CLA found.
:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

@lilleyse you're probably the best person to review this, correct?  Also, SpectorJS is really useful too, so I personally don't see a reason not to include it.

Cool I'll check this out tomorrow

The change looks good. @kring do you plan on pushing any other fixes in this PR or is this ready?

This can be merged. I hope to do a another PR today to fix the rest of the polyline/log depth issues.


Add an event tracking callback to allow for inserting custom trackers

Sometimes we have other trackers that we like to 'piggy back' on to GA4 for tracking events.
It would be really cool to be able to do something like this:
tracker.addEventCallback((user_id, eventsParameters, persistentEventParameters, userProperties) => {
// add custom tracker code here
})

And then every time trackEvent is called this is called too

added #10 for this


Create Inbox Reborn Launcher?

This is kind of out there, but I used to use this great little App Launcher for Inbox. It kept my email separate from my usually huge number of Chrome tabs. And, I could close Chrome when it sucked down all my resources without disturbing Inbox.
Looked just like regular Inbox but opened as if it were it's own app. And, I believe it technically showed up as a Chrome App.
Amazing job on what you've done so far, thanks!

@SharonPerp Interesting idea, but unless I'm misunderstanding, you're describing a Chrome app, which Google discontinued a couple years ago. See announcement here
One way to achieve what you're asking for is to create an Electron app that points to the Gmail website, but somehow includes this extension.

Actually, I decided to take a look, and it's still in the Chrome store: https://chrome.google.com/webstore/detail/app-launcher-for-inbox-by/ajjmenfgmbpceneffopmikhahnkeebje?hl=en
Of course, now it launches the ugly gmail interface in its own window instead of actual Inbox.
Hope that helps!

@SharonPerp Yup, that one was last updated on June 30, 2015, long before Google discontinued Chrome Apps. The previously published ones were supposed to be removed from the Chrome web store as of last year, but that date got pushed back a bit more.

Hmmm, well, I don't understand how apps work really, all I know is it was fixed pretty quickly whenever Google changes broke it, and was perfectly useable until just recently.