class_exists() seems to be called on a null value, which causes a deprecation warning in PHP >=8.1

Environment details

OS: N/A
PHP version: 8.1 and up
Package name and version: google/apiclient 2.13.0

Description
In https://github.com/googleapis/google-api-php-client/blob/main/src/Model.php#L296 class_exists() is called on a dynamic property. Looking at the code, the method expects the property to either not exist, or contain a valid class name as a value. However, it seems it is possible the property exists, but with a null value. PHP 8.1 and up now displays the following deprecation notice when class_exists() is called with a null value as the first parameter:
Deprecated: class_exists(): Passing null to parameter #1 ($class) of type string is deprecated

Example code
This piece of pseudo code is based on the code that triggers the warning for me:
use Google\Service\Storage;
use Google\Service\Storage\Bucket;

$bucket = new Bucket();
$bucket->setName('my-test-bucket');
$bucket->setLocation('europe-west4');
$bucket->setStorageClass('REGIONAL');
$bucket->setOwner('user:test@example.com');

/** @var Google\Client $client */
$storageSvc = new Storage($client);
$bucket = $storageSvc->buckets->insert($my_project_id, $bucket);

The last line triggers the deprecation warning.
I'm not too familiar with the inner workings of the Google API client, so I'm not sure whether my assumption is correct (model property can exist, but with a null value, which is not accounted for in the code) or that properties with null values should not exist in the first place. Therefore I can't provide a good suggestion on how the issue could be resolved.

Getting the same warning when testing Google Listings & Ads with PHP 8.1.
I can work around it by replacing the line:
        if (property_exists($this, $keyType) && class_exists($this->$keyType)) {

with the following code:
        if (property_exists($this, $keyType) && ! is_null($this->$keyType) && class_exists($this->$keyType)) {

However it would be nice to get this fixed so we can support "current" PHP versions.


⚠ SceneTime has degraded performance

In 3747e66, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3174 ms

Resolved: SceneTime performance has improved in 4cb6e0a after 9 minutes.


baresip-0.5.4 on openwrt

I am trying update baresip to version 0.5.4 on openwrt. I finished the compile and install process. Now baresip-0.5.4 can run on openwrt and there is nothing wrong with the sound. but video didn't show.
v4l2_codec:  Driver Caps:
    Driver:                     "uvcvideo"
    Card:                       "USB 2.0 Camera"
    Bus:                         "usb-ehci-platform-1.3"
    Version:                   3.0
    Capabilities:             0x84000001
    Formats:
    >   462H:    C  'H.264'

v4l2_codec: Selected Camera Mode:
    Width:      320
    Height:     180
    PixFmt:     462H
    Field:        1

baresip didn't get any video frame from my camera. But baresip-0.5.4 can get video frame from this camera when running on ubuntu.
I don't know if  it has anything to with the little-endian and big-endian.
The system info as follow:
---System info---
 Machine: mips/linux
 Version:  0.5.4 (libre v0.5.4)
 Build:      32-bit big endian
 ......

I inserted some code to print info.
static int open_encoder(struct vidsrc_st *st, const char *device,
			unsigned width, unsigned height)
{
	int err;
	debug("v4l2_codec: opening video-encoder device (device=%s)\n",
	      device);
	st->fd = open(device, O_RDWR);
	...
        err = fd_listen(st->fd, FD_READ, read_handler, st);
	if (err)
		goto out;
out:
	info("err=%d\n",err);     //for print information No.1
        return err;
}

static void read_handler(int flags, void *arg)
{
	......
        debug("i am at read_handler function\n");  // for print information No.2

	if (flags & FD_EXCEPT) {
		warning("v4l2_codec: device error\n");
		return;
	}

	......
	ts = buf.timestamp;
	rtp_ts = (90000ULL * (1000000*ts.tv_sec + ts.tv_usec)) / 1000000;

#if 1   // changed to 1, to output following informaion No.3
	debug("v4l2_codec: %s frame captured at %ldsec, %ldusec (%zu bytes)\n",
	      keyframe ? "KEY" : "   ",
	      buf.timestamp.tv_sec, buf.timestamp.tv_usec,
	      (size_t)buf.bytesused);
#endif
        ......
}

When accepting a calling, infomation No.1 displayed, but infomation No.2 and No.3 didn't display.

did you run baresip with -v (verbose) flag ?
could you also test different polling methods (poll, select, epoll).
also, here is a branch for testing:
https://github.com/alfredh/baresip/tree/v4l2_codec_buffers

Just because the camera. I used another uvc camera, and video had been displayed.
Thanks


[4.2] migrator: handle the composite change of updating raw-representable to type alias and rename the referenced variables simultaneously. rdar://41732485

@swift-ci please test


Cleaning up the use of Boost.Accumulator headers

this is based on initial work done by @K-ballo
replace use of boost/type_trais.hpp

The goal of this is to reduce compile time

LGTM!


ARROW-9901: [C++] Add hand-crafted Parquet to Arrow reconstruction tests

Exercise various cases of nested Parquet schemas and def / rep levels values.
Some of those tests currently fail.

@emkornfield WIP (some more tests need to be written), but this is a start. Feel free to give any feedback.

This is now ready for review. @emkornfield It would be nice if you could take a look at the failing / disabled tests, and see if they are not mistaken. Especially, there are failures in some nested struct tests.
There are probably more possibilities that could be tested (such as list-in-struct-in-list, or struct-in-list-in-struct), but this is a good start IMHO.

I think I've addressed your concerns. Using object notation actually helped me fix a test... which made it fail. So one more bug to fix :-)


Impl TryFrom for JSR/NPM

For #20
Both the JSR and NPM semver structs have methods called from_str with Clippy annotations saying that they should be implemented as a trait. I reimplemented them using the TryFrom trait, and replaced the internal structure of the functions with a call to TryFrom.
 #[allow(clippy::should_implement_trait)]
 pub fn from_str(
   specifier: &str,
 ) -> Result<Self, PackageReqReferenceParseError> {
   Self::try_from(specifier)
 }

I agree that dedicated methods are clearer, though TryFrom might be worth keeping in the background if you want to support more data types in the future. If not, fair enough.

Going to close this one.


Run the flutter pub run auto_updater:generate_keys command to report an error

Hello,
When running the flutter pub run auto_updater:generate_keys command, it prompts this error Unexpected extension byte (at offset 10), how to solve it?

I got the same error, how can I fix it


Re-add direct setter and getter for camera type

We had this feature before, and removed it in favor of using a "scene update" to change the camera type. While technically sufficient and correct, the "scene update" approach is much more cumbersome than a direct setter! Of course we can't add direct setters for every part of the scene, but since we provide direct control over every other aspect of the view (zoom, position, tilt, etc.) it seems reasonable that the camera type should be just as easy to access and modify.

I agree.
The only concern I have is out of all the view calls we allow (zoom, position, tilt, cameraType change) this is the only one dependent on the scene file. If the scene file does not specify these camera types what should be the behavior?

The camera element in the scene file has parameters for position and zoom as well, so this doesn't seem that different. Can you clarify what you mean?

perspective and isometric camera types use different configurations specified in the scene file.
If one does not provide these configuration in the scene file and change the camera type, it will result in bad camera/renders.
Example if one only has isometric camera set in the scene file with apt parameter ('axis') set.. and then camera type is changed from isometric to perspective (with no information of perspective camera parameters (fov, focal_length, etc) available).

All of these parameters have documented default values, so I don't think
one could produce an "invalid" configuration.
On Jun 15, 2016 12:27 PM, "Varun"<EMAIL_ADDRESS>wrote:

perspective and isometric camera types use different configurations
specified in the scene file.
If one does not provide these configuration in the scene file and change
the camera type, it will result in bad camera/renders.
Example if one only has isometric camera set in the scene file with apt
parameter ('axis') set.. and then camera type is changed from isometric
to perspective (with no information of perspective camera parameters (fov,
focal_length, etc) available).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tangrams/tangram-es/pull/793#issuecomment-226242253,
or mute the thread
https://github.com/notifications/unsubscribe/ADNzSjXkcZW43a9w9mb5Hg4tlazJeMTpks5qMCfVgaJpZM4I2hed
.

Note: Update documentation when this gets released with our next release.


[Docs] Language Understanding Topic

https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/concept-language-understanding-draft.md#language-understanding

"Language Understanding (LU) is the process for a bot to understand language naturally and contextually so a bot will decide what to do next in a conversation flow. " - I found the use of "the process for a bot to" to be confusing - maybe "Language Understanding (LU) is used by the bot to understand language naturally and contextually to determine what next to do in a conversation flow".

"on to event hanlders which define" - handlers, or possibly triggers?

"You wire up LU models with dialog" - not sure what this really means

https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/concept-language-understanding-draft.md#intents

"The basic idea behind is quite simple:" - behind Intents?

"When an intent is captured some pre-defined action will fire." - maybe instead reuse the word "trigger"; ie "when an intent is identified, an associated trigger causes an action to fire"

https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/concept-language-understanding-draft.md#entities

"Entities are a collection of objects data extracted " - object data?

"An intent presents the prediction of the entire utterance. "  - this is confusing.  maybe "An intent indicated what the user is trying to do" or something

https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/concept-language-understanding-draft.md#step-one-set-up-a-recognizer-for-specific-dialog

"LU content" - generally; this feels like it shouldn't be an acronym we use everywhere.  Not sure what to replace with though

https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/concept-language-understanding-draft.md#step-three-wire-up-lu-with-handle-an-intent-trigger

"The Handle an Intent trigger is an event handler which defines " - maybe "The Handle and Intent trigger defines"; - "is an event handler" isn't needed IMO

https://github.com/microsoft/BotFramework-Composer/blob/kaiqb/Ignite2019/docs/concept-language-understanding-draft.md#step-four-publish-lu-luis

"and wether it is published or not." - whether

Closing since the content is updated.


Can lidar point clouds be used for further deep supervision in the waymo dataset?

Hi, I am not sure the meaning of 'deep supervision'. Lidar could provide extra dense points.  However, for in the wild videos, the lidar seems inaccessible.

@kcheng1021 Thank you for your reply. What I mean is, will using lidar generated depth maps for depth supervision be better than using SFM and MVS generated depth maps? Because lidar typically has better geometric accuracy, although it has sparsity.

Thanks for your advice. I haven’t tried to compare lidar point clouds yet, because we focus on in the wild scenes, not just autonomous driving. It will be so nice for you to try it and share the results. I believe that the Lidar point cloud will also improve 3DGS. I will also try to add this comparison later.

Thank you！I will try it and share the experimental results！


where is the "test" directory? Should I create it?

Yes, you need to create a 'test' directory and write your test files according to the instructions provided in the README.
https://github.com/WestlakeIntelligentRobotics/ConsensusLLM-code/blob/master/README.md?plain=1#L92-L127

Resolved, closing this issue now. Feel free to reach out if you have any further questions.


controllers: modernize validating webhook controller

This updates to use the new kclient (proper syncing, etc), and updates a lot of the infrastructure to keep up with recent improvements and best practices. No behavioral changes expected.
Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
102bd1bd3fae6967cc082a151bce4aeb45e2e554
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
102bd1bd3fae6967cc082a151bce4aeb45e2e554
link
true
/test unit-tests-arm64

unit-tests_istio
102bd1bd3fae6967cc082a151bce4aeb45e2e554
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
c4ea2697247c8a1f1a3c65557f55ee9a0246e45a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
c4ea2697247c8a1f1a3c65557f55ee9a0246e45a
link
true
/test unit-tests

integ-pilot_istio
c4ea2697247c8a1f1a3c65557f55ee9a0246e45a
link
true
/test integ-pilot

unit-tests-arm64_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
c4ea2697247c8a1f1a3c65557f55ee9a0246e45a
link
true
/test integ-pilot

unit-tests-arm64_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests-arm64

unit-tests_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
c4ea2697247c8a1f1a3c65557f55ee9a0246e45a
link
true
/test integ-pilot

unit-tests-arm64_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests-arm64

unit-tests_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests

integ-pilot-istiodremote_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests-arm64

unit-tests_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test unit-tests

integ-pilot-istiodremote_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-pilot-istiodremote

integ-cni_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-cni

integ-pilot_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-pilot-istiodremote

integ-cni_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-cni

integ-pilot_istio
fb2600d35b67cd5e3b64045e207d5bfa879025ff
link
true
/test integ-pilot

unit-tests_istio
f380662f24b87de5f094a023af7d2a1f04ed5fdc
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f380662f24b87de5f094a023af7d2a1f04ed5fdc
link
true
/test unit-tests

unit-tests-arm64_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f380662f24b87de5f094a023af7d2a1f04ed5fdc
link
true
/test unit-tests

unit-tests-arm64_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test unit-tests-arm64

gencheck_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
f380662f24b87de5f094a023af7d2a1f04ed5fdc
link
true
/test unit-tests

unit-tests-arm64_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test unit-tests-arm64

gencheck_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test gencheck

lint_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test unit-tests-arm64

gencheck_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test gencheck

lint_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test lint

unit-tests_istio
4c6bdff1d4705d660a25a8feae4a8d29d108d4fd
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ambient_istio
018e7ee3b72c9e1391c363311f55546e72748801
link
unknown
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-ambient


[BASE] Get the Dicom VR of a Field Automatically

Currently, the VR of a field is set manually. We need to way to find the VR from the pydicom library for a field and set it accordingly.

https://github.com/pydicom/pydicom/blob/master/pydicom/values.py


Create AuthRequired component

Creates a AuthRequired component that can do the following things:
Check for onClicks on child components and redirect to /auth if not signed in OR
Checks if the user is signed in for the whole page and redirects to /auth if not signed in

I have to run the lint first :mhm:


How to Print Last item of array by dataTemplate?

Help me to Get Last Item of Array.
Bellow code print First Item of Array,
 "dataTemplate": "{\"content\":{{json (index . 0)}}}",
But I want to Print Last Item Of Array.

I don't know how to do that in a template. The data template syntax is the same as the golang template so you can do some search for how to do that in go. As an alternative In the selection, you can use [-1] as the index to get the last item, like SELECT children[-1] FROM demo. Check the doc here

I tried go lang way  also like this
{{json (index .len(json) -1}}
tried with random pattern. but no luck.
Please help me to find a way.

Refer to this doc - https://github.com/lf-edge/ekuiper/blob/master/docs/en_US/rules/data_template.md, you can firstly get the array size and then use add function to get the index of the last element.
{{$len := len .values}} {{$loopsize := add $len -1}}

@jinfahua Thanks for reply. It helps a lot.


num_workers > 1

When num_workers>1  in Dataloader, it doesn’t work anymore.
Error msg: AttributeError: Can't pickle local object 'GraphDataset.pyg..Dataset'
From @claying

To reproduce:
commit
import tempfile
from proteinshake.datasets import AlphaFoldDataset
from torch_geometric.loader import DataLoader

with tempfile.TemporaryDirectory() as tmp:
    dset = AlphaFoldDataset(root=tmp, organism='escherichia_coli').to_graph(eps=8).pyg()
    # 1 worker
    l = DataLoader(dset, batch_size=8)
    for batch in l:
        pass

Traceback:
Downloading AlphaFoldDataset_escherichia_coli.json.gz:
100%|█████████████████████████████████████████████████████████████████████████| 1.39k/1.39k [00:01<00:00, 9.34MiB/s]
Unzipping...
Converting proteins to graphs: 100%|███████████████████████████████████████████| 4363/4363 [00:20<00:00, 216.73it/s]
Traceback (most recent call last):
  File "<..>/Projects/proteinshake/test.py", line 10, in <module>
    for batch in l:
  File "<..>/.venv/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 444, in __iter__
    return self._get_iterator()
  File "<..>/.venv/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 390, in _get_iterator
    return _MultiProcessingDataLoaderIter(self)
  File "<..>/proteinshake/.venv/lib/python3.9/site-packages/torch/utils/data/dataloader.py", line 1077, in __init__
    w.start()
  File<EMAIL_ADDRESS>line 121, in start
    self._popen = self._Popen(self)
  File<EMAIL_ADDRESS>line 224, in _Popen
    return _default_context.get_context().Process._Popen(process_obj)
  File<EMAIL_ADDRESS>line 284, in _Popen
    return Popen(process_obj)
  File<EMAIL_ADDRESS>line 32, in __init__
    super().__init__(process_obj)
  File<EMAIL_ADDRESS>line 19, in __init__
    self._launch(process_obj)
  File<EMAIL_ADDRESS>line 47, in _launch
    reduction.dump(process_obj, fp)
  File<EMAIL_ADDRESS>line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
AttributeError: Can't pickle local object 'GraphDataset.pyg.<locals>.Dataset'

Seems to be the classic problem of pickling custom types.

Ok so the problem is fixed by moving the class Dataset(InMemoryDataset) outside of the GraphDatset class. However this of course would mean a user that does not want to install pyg would get an import error.
I think the simplest solution would be to split up the different frameworks into their own module which subclasses GraphDataset and overrides the convert() function.
e.g.
pyg_data.py (new non-existent file):
import torch
from torch_geometric.data import Data, InMemoryDataset

from proteinshake.representations import GraphDataset

class Dataset(InMemoryDataset):
    pass

class PyGData(GraphDataset):
    def __init__(self):
        super().__init__()
    def convert(self, graphs):
         # convert graphs to a PyG dataset
        graphs = (pdb2pyg(g) for g in graphs)
        return Dataset(graphs)


Fix the default code owner for /cilium-cli

It looks like * does not match files in sub-directories recursively ^1. Remove the * to match all the files under /cilium-cli.

/test

/test


How to build this?

Hi, any chance for some build instructions?
I tried compiling the sln, but getting this error when running the test app.

Do I need to build the asio lib or do anything else?

Please provide the following: Windows version, VS version and which test app you were trying.
You don't need to build the support files (C++), they're included in folder src\Winook\winook.support.

Hi, sorry for the late reply, I am using Windows 11, VS 2019 and was trying to run the Winook.Desktop.Test app.
thanks

Hi Mihai,
I found the problem: in Windows 11, Notepad was replaced by a new application available in the Microsoft Store. It seems that the executables located where the Winook test app points to are stubs that launch the new version of Notepad.
On my machine, it works when I wait a bit for the application to start (and show the main window) before executing InstallAsync(). I use a breakpoint and wait 1 second.

Got it, thanks for the explanation. Indeed it works if I set a breakpoint.
Great project by the way!


Support skip_verify in client config to skip strict TLS verification

Why
Many a times like in case of self-signed certificate and sometimes with letsencrypt certs, TLS verification fails with unknown issuer error. In those cases, it is useful to enable skip_verify.
Error message:
Error: Cannot connect to ClickHouse at tcp://default@<redacted>:9440 (Connections error: `Input/output error: `invalid peer certificate: UnknownIssuer``)

It also maybe useful to add such an alias to the clickhouse itself (not to export all the Poco internals). @chhetripradeep are you interested in this?

BTW for letsencrypt, if cURL works, maybe we can fix this a in a better way (by reading proper root certificates)

Thank you.

It also maybe useful to add such an alias to the clickhouse itself (not to export all the Poco internals).

Yes i am interested. I didn't know that clickhouse doesn't have one.

BTW for letsencrypt, if cURL works, maybe we can fix this a in a better way (by reading proper root certificates)

Agree. In my case, curl was working but somehow chdig wasn't working. I will look deeper into it.

In client there is --accept-invalid-certificate, so I guess it make sense to support it in client's config and in chdig as well

I've created an issue for this - https://github.com/ClickHouse/ClickHouse/issues/59278


Fixed assign request bug

Fixed bug where completed requests can be assigned to healthworkers, causing the request status to revert back to ongoing.

Good job on correcting that bug, it is very necessary to give the administrator the option of making reverts on certain commands, as this is very much reflective of a real-world situation where some seemingly completely tasks may need to reviewed again.


Please give line numbers a border or different background color

Issue Type: Feature Request
Line and editor backgrounds are same color.  This causes me to misplace my cursor when starting a new line.  This issue has been raised years ago.  It seems like an easy fix.   Thank you.
(Yes I have tried the editor.renderwhitespace -> boundary
Kinda hokey don't you think?)
VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:13:36.375Z)
OS version: Windows_NT x64 10.0.17134

"workbench.colorCustomizations": {
    "editorGutter.background": "#ff0000",
}


Working Range example

Changes in this pull request
Adding a working range example to the example app. This example:

Displays a list of images downloaded from unsplash.it
Create 20 uniquely-random sized objects
When section controllers enter the range, create a data task to download the image

When finished, store image in downloadedImage
Set in cell if cell is visible
Don't create task if already downloaded or task created

Cancel task when section controller is destroyed
Show a spinner cell while downloading the image

Fixes #84
Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I have reviewed the contributing guide

Screenshots of the demo:
Downloading images:

Images finished:

nice 🎉


Add MIT/Apache License

Howdy Karim,
Hope you're doing well!
As an open-source project, can this project have a proper license (MIT or Apache) that allows the use and redistribution of this github action?
Best regards,
Aditya

Thanks Aditya!  Done

Thank you, Karim!


Have ability to infer the return type of page endpoint in .svelte

Describe the problem
Having endpoint index.ts we can define get method with a return type of { body: { example: string } } like that:
export const get: RequestHandler = async () => {
    return {
        body: { example: 'value' }
    }
}

And then use it in page index.svelte like that:
<script lang="ts">
    export let example
    console.log(example)
</script>

But the type of example in index.svelte file would be any, and there is no way to infer it even if we import the get method as type and try to use Awaited<ReturnType<get>>, because body is by design are of type any.
This is a problem because return types of endpoints can get complicated at times. For example if it's also a type generated by database ORM for complex query. And basically doubling them in your own interfaces is inefficient.
Describe the proposed solution
Have automatic inference of return type in svelte file. (i have no idea how that could be done)
Alternatives considered
Have sveltekit emit and export the return type of endpoint at generation stage so it could be imported and used wherever needed (especially usefull to type normal fetch() calls)
Importance
would make my life easier
Additional Information
No response

Duplicate of #647 . This request is part of that larger issue of having better generated types.


Timing interval configuration options

motd_updater, chat, server_mapper all have timing intervals for refresh/submission that should be configurable.

I changed my mind.


[Bug]: Existing application Gsheets datasource throws auth error, even though in configuration, the account shows up the authorized acct name

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Existing application Gsheets datasource throws auth error, even though in configuration, the account shows up the authorized acct name
Steps To Reproduce
https://github.com/appsmithorg/appsmith/assets/101863839/2ec484bf-d544-4ce9-892c-c4f9e64ca77f
Public Sample App
No response
Environment
Release
Issue video log
No response
Version
Cloud

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed

Cannot reproduce this with my own app, but I think this may be fixed with #28952

@rohan-arthur  - Reopening this as I am still able to reproduce this on my instance on an existing gsheets datasource.
https://github.com/appsmithorg/appsmith/assets/101863839/f6f83d0e-e49b-45fe-9ae6-0329d310470b


More performant mod1 functions.

@vchuravy suggested using if-else statements instead of
@inline incmod1(a, n) = a == n ? one(a) : a + 1
@inline decmod1(a, n) = a == 1 ? n : a - 1

as it might be faster on the GPU. Also worth checking out Julia's mod1(x, y) function.
I'll test a bunch of different mod1 functions once we have the algorithm fully working on the GPU.
See also: /r/Julia/Efficient wrap-around with 1-based indexing?

Specifically ifelse(a==1, n, a - 1). This should always be faster than mod. In ShallowWaterBench, we consciously choose to use OffsetArrays, to avoid any wrap around and implement ghost cells.

Wasn't this solved?

Yes. Thanks for pointing this out!


Fix memory leak from XQueryTree.

Hi, I wanted to get the process id associated with the window that has focus. I found this stackoverflow and then was like; there must be someone who wrote this... so I found your implementation through github codesearch.
Since it's MIT license I took the liberty of copy pasting the necessary functions into my project. Because it's ffi code I ran it through valgrind and I discovered it was leaking 4 bytes per query. Finding it unfortunately wasn't as easy as I hoped, it didn't show up in the backtrace in valgrind, so I manually had to bisect the code.
The issue is that XQueryTree states the following for the return:

XQueryTree() returns zero if it fails and nonzero if it succeeds.

But the xlib::Success constant is defined as 0. So on success, the memory isn't correctly freed. Maybe this function breaks with convention?
Either way, with this change to the code on my side, the memory leak disappears. This PR makes the identical changes to your original code, I did confirm this builds, but haven't tried running the program.

Hi @iwanders,
Thanks for going into such detail! Apologies for not getting back to you - I just saw this PR.
I suspect you are 100% correct with your change.
I'm also yet to test this on a real machine yet, but I will do so soon and confirm and merge this PR.
Thanks again,
David

Thanks @iwanders, I can confirm that fixes the memory leak!
Great find! It's pretty amazing you found that leak.

:+1:  glad I could help fix this small bug, thanks again for open sourcing the algorithm with a permissive license!


Cherry-Pick Issue #3820 for 1.2.8 patch release

[UWP][Accessability] Use element tag instead of access key for internal tracking.

Related Issue
Fixes #3820
Description
Cherry-Pick Issue #3820 for 1.2.8 patch release
How Verified

Working on local build at the moment. Will try to repro following the issue's repro steps as well.

Microsoft Reviewers: Open in CodeFlow

looks good except for the build failures from areas needing updates :)

@paulcam206 ideas on these -- https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=22443432&view=results ? Restart the build?

azp /run

@paulcam206 ideas on these -- https://microsoft.visualstudio.com/AdaptiveCards/_build/results?buildId=22443432&view=results ? Restart the build?

Apparently a rebuild did it.

@paulcam206 / @RebeccaAnne let me know if this version looks good to go and i'll go ahead and kick off a release build!


-i and --no-server gets ignored with no error when passed as the second option

./mill --help
# (...)
# -i --interactive                  Run Mill in interactive mode, suitable for opening REPLs and
#                                     taking user input. This implies --no-server and no mill server
#                                     will be used. Must be the first argument.
# (...)
# --no-server                       Run Mill in single-process mode. In this mode, no Mill server
#                                     will be started or used. Must be the first argument.

Both -i and --no-server options require to be the first argument, but no error seems to be produced if they're passed elsewhere.
▶ ./mill --disable-callgraph-invalidation --no-server __.fix
# (standard build logs, no errors or warnings, --no-server gets ignored)
▶ ./mill --disable-callgraph-invalidation -i __.fix
# (standard build logs, no errors or warnings, -i gets ignored)

This caused my team a major headache when --disable-callgraph-invalidation has been added to the Scala CLI mill script as the first argument (attempted workaround for #2844), with -i sneakily being ignored everywhere as a result, with no failures.
I'd at the very least expect a warning, and preferably just an error.

This is strange. We had such a warning in 0.10. I thought we removed this requirement (to have them in first position) as we now have a single entry point to Mill (so we can parse the full cmdline), and probably have removed the warning along this way. We need to have a deeper look...

Hm... changing -i back to the first argument spot seemed to fix stuff for our builds, so something seems to still be going on there.
I mean, our CI was then breaking elsewhere, but that's a separate thing 😅
Also, if the first argument spot ends up no longer being enforced for these options, it'd be helpful to remove the corresponding sentence from the --help description.

I completely agree. I'll mark this issue a bug once I have a better idea what's going on.

Looks like the requirement to have it in first position is still there.
https://github.com/com-lihaoyi/mill/blob/c12d0245840a9a521c6e65f99b846ac96939ca10/main/client/src/mill/main/client/MillClientMain.java#L62
So I was wrong. We need to fix the missing warning. Thanks for reporting.

Hm, we have it here: https://github.com/com-lihaoyi/mill/blob/c12d0245840a9a521c6e65f99b846ac96939ca10/runner/src/mill/runner/MillMain.scala#L134-L136

Hm. Then it seems it just isn't being printed for some reason...

Mill should stop right away, when this branch in entered. So I think the condition is no longer true. Most likely the streams.in == DummyInputStream doesn't hold any longer.

I think Mill learned to use the system IN even when in server mode, so we can't no longer detect if if we run in a server or not by checking for a DummyInputStream.

See #1621

Hi @Gedochao / @lefou,
I talked with @lihaoyi this morning;
Y'all can assign this to me 🙂
Sincerely,
R.W.

@alastor1729 I'm happy to help if you need pointers. Feel free to ask here, or we can schedule a call or something if you want to discuss it synchronouslhy

Hi @lihaoyi, I just sent you a "30 mins Google Meeting call" for us to discuss Issue synchronously && ask for pointers:

Please feel free to modify the start-time of this Google Meeting (to better fit your schedule) 🙂

Any news on that topic? Did you decide on any implementation detail?
If not, I see two options, and it's unclear to me, what the envisioned goal of this ticket is

ensure we show a proper warning in all cases where args are used in non-first position
make these args work in all positions, which is more difficult, since we parse / detect these in a shell script (the prepended script in the binary assembly) and if Mill isn't invoked through that script, we also parse it from Java (which starts up faster without loading the full scala library), thus we can't reuse the mainargs parser here.

As a side note, I envision some native launcher instead of the current solutions (which could be either Scala Native or Graal VM) and fall back to some less performant but singleton handling of these options in case we can't use a native launcher. Hopefully reducing the scattered logic in multiple places.
Scala Native looks more straight forward, as it could share code with the non-native runner, but I don't think our current library used for the client-server communication, junixsocket, will work with that.
It looks like junixsocket is already prepared to be used with Graal native images, so this could be the better approach.
Unfortunately, I don't have experience in both of these.

@lefou, due to my work-constraints && work-deadlines (for the near future), and through email communication with @lihaoyi...

I no longer have time to work on this OSS Mill Issue 🙁
However, @wanggang1<EMAIL_ADDRESS>) will be taking this issue from me / expressed interest in this Mill Issue.