update VS CAKE path more clear

tools folder is too common use, ignore tools folder makes more problems.

@gep13 are you cool with this?

@shiftkey sorry for not getting back to you sooner about this.  We have just had our second daughter 😄
I am not sure if this is a good idea.  The typical Cake tools folder looks this this:

Making the suggested change would require multiple separate additions for the various tools that have been included in the project.

This is more of a NuGet issue, right? Or could we use a subfolder to namespace better to isolate these things from other tools the user might have installed?
I don't mind helping to put together some sort of PR for this, just curious if you've already tried and dismissed the idea...

@shiftkey sorry about length of time to reply.  Just getting back to things after arrival of new baby...
By default we call this folder tools, but we are not tied to this.  It is possible through configuration (http://cakebuild.net/docs/fundamentals/default-configuration-values#tools-path) to change the name/location of both the tools and the addins folder.
So I am not sure if there is anything that needs to be done here, is there?

@GhostTW said...
ignore tools folder makes more problems.

What sort of problems are you running into?

@GhostTW waiting on clarification about this:

ignore tools folder makes more problems.

What sort of problems are you running into?

@GhostTW please let us know if you have any questions about Cake functionality in this area.  Happy to help if we can.

Closing due to inactivity. @GhostTW if you're able to answer the questions @gep13 was asking earlier we can revisit whether this change is still required.


How to install Proton-GE to GamerOS? To what directory?

I need to install custom Proton to play Borderlands 3, but i dont know where should place the files...
Directory in steam are different for this OS.

There is nothing special about GamerOS and the Steam directories. It is the same as any other distro.
These instructions should work: https://github.com/GloriousEggroll/proton-ge-custom#native

Yes i fugured it out after some research.
In Ubuntu patch are:
$HOME/.steam/root/compatibilitytools.d/
In GamerOS path are:
$HOME/.local/share/Steam/compatibilitytools.d/


⚠ ClamAV has degraded performance

In 3beffee, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 209 ms

Resolved: ClamAV performance has improved in cf46d8d.


Scroll multiple editors together

VSCode Version: 1.6.0
OS Version: Windows 10 1607

Steps to Reproduce:

Create two editors, one in the left side and one in the right side.
When editing a file comparing with another file, I want to scoll both two editors in the same time .

Related to #5047, which describes a similar feature but for a markdown file and its preview.

@lich1288 Why not just using the "Compare view" which has autoscroll enabled?

@Dominik-K Thanks, that's exactly what I want!


Custom controller shows bread page instead of browse page.

Laravel Version: 5.6.26
Voyager Version: 1.1
PHP Version: 7.1.8
Database Driver & Version:

Description:
After creating custom controller the browse page of the packages is showing me the bread page, instead of the browse page of the packages resource..

Steps To Reproduce:

install laravel 5.6 with voyager 1.1
create a new resource by going to tools->database->create new table->test
add bread to your new resource
visit your new resource by going to menu->test, you should be able to see the browse page..
edit this resource bread by clicking edit on database->bread specifying Voyager\TestController.php
create custom controller by changing config\voyager.php controller namespace to 'App\Http\Controllers\Voyager',
publish controllers by issuing command, php artisan voyager:controllers
now visit your resource again, and it will show you the "bread page"

is this suppose to happen? it should show the browse page of the resource, since I didn't overwrite anything..

Meh, I got it, I was extending the wrong Controller.. instead of BaseController I was extending BreadController..


chore(package.json): update dependencies

used npm-check to update deps
updated to react 15
pointed to fork of react-prism until this pr gets merged or the project is updated to support react 15. (this gets rid of the peer deps warnings).

Coverage remained the same at 100.0% when pulling fd1f66e21a2b513db6f570a36ebac4c3a25c5f48 on update-deps into a550782f6f8bddd19f0905d27ded0f25d685c5ca on master.


look_at_from_position: Up vector and direction between node origin and target are aligned, look_at() failed.

Godot version
v3.4.beta4.official [6a058cbf3]
System information
Windows 10, Nvidia GTX 750Ti
Issue description
I would like to know why the up vector and direction between node origin and target being aligned is considered an error and why I have to add checks to make sure its directly not Vector3.Up and Vector3.Down. This seriously does not make since to me at all. Shouldn't it just be the default rotation of being upwards or downwards? If there is some complex reason why this is like this, can it have some sort of documentation? Thanks!
Steps to reproduce
Note that this is is just a example of a line that would cause the error:
var collision_normal_up = Vector3.UP
var collision_normal_down = Vector3.DOWN

spatial.look_at(collision_normal_up, Vector3.UP) # Returns a error
spatial.look_at(collision_normal_down, Vector3.UP) # Returns a error

Minimal reproduction project
No response

If you tell me to look_at(the_ceiling) in real life, I will naturally use the same yaw as I currently have. This error makes sense probably for some Transform methods, but I think Spatial.look_at is high level enough that having a fallback is reasonable.

It would be nice if there was such a function that assumes the same yaw, or such like alternative. The majority of use cases for "look_at" and "look_at_from_position" use the default up vector (Vector3.UP). When calling "look_at" every physics tick, to avoid the error it's annoying to need a check in GDScript (like 'not up.cross(-target.normalized()).is_zero_approx()') that is already done by the function itself in c++ (see note 1. below), particularly for performance reasons, since I'm happy just keeping the same rotation that tick. Is this not a common use case?
Note 1.:
https://github.com/godotengine/godot/blob/d93b66ad4d6b1dae42cc318c16224d03bd1a1472/core/math/basis.cpp#L1047
https://github.com/godotengine/godot/blob/d93b66ad4d6b1dae42cc318c16224d03bd1a1472/scene/3d/node_3d.cpp#L821
Related issue as mentioned by lawnjelly: https://github.com/godotengine/godot/issues/57457


docs: tweak readme

Tweaked intro
Intro diagram
Clarify requirements
Simplify instructions
Simplify full example
Include small example with each spec
Describe FP <> Spec mappings in tables instead of bulletpoints
Fix coverage badge

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


multiple spaces convert to single space

Hello, I'm encountering an issue where, upon pasting text into the editor, all multiple spaces are reduced to a single space, and I can't use the tab function. Additionally, the bullet list behaves strangely, as it gets converted to a numbered list when inserted into a div. The bullet list is exported as an ol instead of a ul. Previously, I used react-quill v2, where everything worked correctly. What could be causing this problem?
Tab -> single space
Multiple spaces -> single space
bullet list -> ordered list
have text inside a div. After clicking the edit icon, the editor opens, the text is loaded into the editor, and all multiple spaces are replaced by a single space.

in edit mode:

bullet list in edit mode:

bullet list after saving:

I tried using preserveWhitespace={true} and white-space: pre-wrap, but it didn’t help.

it seems that at the moment it is impossible:
https://github.com/KillerCodeMonkey/ngx-quill/issues/1848
https://github.com/slab/quill/issues/4108

@ToktogonovA  This seems to be an issue with quill, and not react-quill. @piotrziolko thank you for linking the relevant quill issue (https://github.com/slab/quill/issues/4108). I'll leave this issue open until quill fixes it and a version of react-quill with the updated downstream package is released


Update common-jvm to 0.28.0.

This also updates cross-media-measurement to world-federation-of-advertisers/cross-media-measurement#438.

This change is

Waiting on https://github.com/world-federation-of-advertisers/cross-media-measurement/pull/438 to be merged so that this can reference a commit of that repo that has been merged into main.


Community org cards: Hover state

Prerequisites

[x] I've searched for existing issues

Describe the bug
For community org cards on the manage engagement page:
- On Firefox, the top band doesn’t change colour to magenta 2 and the stroke doesn’t change to grey 3
- On chrome, the stroke changes but the top band doesn’t change
Expected behavior
Stroke of the card changes to grey 3, 1px.
Top band goes one shade lighter than the inactive state - so magenta 2, in this case.

This is for nested cards (on "Manage engagement" page)


[5.1] Fix Translator::trans(), Translator::choice() and their common dependency Translator::get() for wrong return types

Continuing on from #9610.
As you can see, get() method depends on the result of getLine() which may return array value. Hence the fix in its @return type.
From there on, choice() and trans() methods use get() method which actually can return an array value. However, logically these methods should rather return a translation string, not collection/array of those strings. The current modification I provide here returns the first element of such array, ensuring these methods always return a string value. My fix doesn't really look clean and I strongly believe we need to introduce separate method similar to get() which would return everything (strings and arrays, as get() does right now) and then make it so that get() always returns string, never an array. Ideas are welcome!

I believe getLine() method should be renamed to something else, as it doesn't return lines only - it may be array of those lines as well. So, this method rather should become get() or getTranslationBit() or something similar.
Additionally we need two separate methods, each fetching those line(s) either as a string or an array, depending on the count, but this time with signature similar to that of current get() method: Why? Because it's tricky to get $namespace value which is required by current getLine() and other parameters, in the middle of request, at controller level. Instead of two methods here, simple flag-type parameter maybe introduced in a single new method as well, a flag which would disable array-type return. Whatever way we follow, I believe this actual method should be called getLine() or getLines().
And then, this final method can be used inside trans() and choice().
Of course changing method names means BC implications, as these methods are public and possibly have been used by devs - thus, this PR should go to 5.2 rather than 5.1.

I think if get() returns an array to choice an exception should be thrown. To me that sounds like something the user should be alerted about because you would never intentionally do that.

@taylorotwell : Should we include that in the core code? I mean throwing exceptions.

@taylorotwell : Should we include that in the core code? I mean throwing exceptions. If not, at least I could modify this PR and fix the return type for get(), don't you agree?

Yes we throw exceptions from core code quite a bit.

Shall I fix this PR and add Exceptions into trans() and choice()? If not, may I just fix return type for get() and re-send the PR? In the very least, we should have that return type fixed IMHO.


cUrl SSL peer verification - Bridge returned error 0!

Whenever I upgrade rss-bridge, Facebook and Twitter bridges return "Bridge returned error 0!".
When enabling DEBUG the cause is apparent.
C:\php\rss-bridge\bridges\FacebookBridge.php:512 class <no-class>->getSimpleHTMLDOM - Cant't download https://www.facebook.com/ukparliament/posts?_fb_noscript=1 cUrl error: SSL certificate problem: unable to get local issuer certificate (60)
The solution is to add this line to lib/contents.php
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
Is there any way of handling this issue better? I can understand not wanting to put the above line into rss-bridge since it reduces the effectiveness of SSL but maybe the issue can be better communicated to the user than the usual "Bridge returned error 0!"?
Maybe add an argument to rss-bridge to toggle SSL peer verification?

It would be better to update your system's certificate store instead of disabling verification:
https://curl.haxx.se/docs/caextract.html
The location where you need to place it likely varies depending on your system.

The problem with specifying a static file of root certificates is that it will inevitably become outdated unless steps are taken to manually periodically update it.

Another option is to drop cUrl entirely and use file_get_contents which, on Windows at least, manages to use the system's root certificate store.

The solution is to add this line to lib/contents.php

This is a hack, not a solution. Your problem is your system's certificate store as @ORelio correctly pointed out. It could also indicate a problem with the configuration of your server if it can't access the certificate store.

Maybe add an argument to rss-bridge to toggle SSL peer verification?

Disabling SSL verification is highly discouraged, so this isn't going to happen:

When negotiating a TLS or SSL connection, the server sends a certificate indicating its identity. Curl verifies whether the certificate is authentic, i.e. that you can trust that the server is who the certificate says it is.
-- https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html

The problem with specifying a static file of root certificates is that it will inevitably become outdated unless steps are taken to manually periodically update it.

Depending on your server and what software you use, it might require additional privileges or settings to access the certificate store. If you are using XAMPP maybe this helps: https://stackoverflow.com/a/34883260
If you are unsure that the remote server is properly configured, you can use services like these to make sure: https://www.digicert.com/help/

Another option is to drop cUrl entirely and use file_get_contents which, on Windows at least, manages to use the system's root certificate store.

RSS-Bridge actually used file_get_contents before it got replaced by cURL for various reasons, like being more secure and customizable than file_get_contents.

I understand the downsides of disabling peer verification, but in the context of rss-bridge, I don't consider any of the information sent or received as particularly sensitive (no usernames or passwords). There are also downsides of specifying a static root certificate file which does not automatically update.
Downloading root certificates from a third party site such as "curl.haxx.se" does not strike me as especially secure either, should I trust them?
This issue ultimately lies with cUrl which, on Windows, seems not to use the system root certificates, unlike file_get_contents.
If the decision is to leave the code as it is, perhaps at least some check could be made for cUrl peer verification failure and give a more helpful error message to the user, explaining the issue and suggesting a solution?

It's not just about secure transfer of sensitive data, but also MITM attacks and the likes. Generally speaking, everything on the Internet should enforce secure connections as best practice. At least Chrome and Firefox intend to do so in the future.
That being said, you can always disable SSL on your machine the same as you did before. I agree that is somewhat tiresome to do so on every update, but it prevents most users from "fixing" their instances that way.

Downloading root certificates from a third party site such as "curl.haxx.se" does not strike me as especially secure either, should I trust them?

If you use a secure connection for downloading the file and verify the checksum of the file, you can at least be sure to have downloaded the file they provide on their servers (assuming their servers have not been compromised). In any case their root certificates are more secure than globally disabling SSL.

This issue ultimately lies with cUrl which, on Windows, seems not to use the system root certificates, unlike file_get_contents.

I actually checked this on my machine using Windows 10 (1803), XAMPP with PHP 7.2.12 and the latest release of RSS-Bridge. This is working fine for me, no certificate issues. If your setup is similar to mine, maybe something went wrong during installation or configuration? (you need to install under "C:\xampp" and not "C:\Program Files (x86)\xampp" if UAC is enabled or it probably won't work)

If the decision is to leave the code as it is, perhaps at least some check could be made for cUrl peer verification failure and give a more helpful error message to the user, explaining the issue and suggesting a solution?

Yes, this is a good idea. There should be a way to receive an error message from cURL that can be displayed for those cases.

I'm using a plain-old PHP 7.2 Windows executable, downloaded from php.net. I use it in CLI mode. When I first started using rss-bridge I ran into this exact issue, before I even knew about enabling DEBUG. Although I do code in PHP, I never use cUrl.
XAMPP specifies this line in php.ini by default:
curl.cainfo="C:\xampp\apache\bin\curl-ca-bundle.crt".
Presumably XAMPP keeps this root certificate file up to date for those who download the latest versions of XAMPP. Those who don't bother updating will run into the same issue I did, eventually.
The PHP CLI from php.net is not bundled with any certificates, which is fine for file_get_contents, but not fine for cUrl.
I haven't tested WampServer either, maybe they don't specify curl.cainfo, or it's an outdated version.
Ultimately it would seem to be an upstream issue, but if cUrl were minded to use Windows system root certificates I'm sure it would have happened by now,
I've also seen that none of the guides who give the solution mention curl.cainfo must periodically be updated. They give the impression it's a one-time fix, which it isn't.
So we have the rare case of people like me who run the PHP executable from php.net, but also people who may use a distro with no curl.cainfo, or one which is outdated.
In terms of communicating to the user, the error is already supplied in DEBUG mode (which I pasted in my first post), so it would just be a case of inserting the cUrl error message into the usual RSS feed error output in non-DEBUG mode (unless it's worth explaining what a "local issuer certificate" is, but that's enough to start Googling with).

Is #958 any use?
I don't know if those variables are always valid strings during an error condition, let me know.

Yes, the PR is very helpful and much simpler than I had expected :+1:
Those variables should always be available (either as string or number), I see no issue... (likely breaking something for someone :smile:)

I'm using a plain-old PHP 7.2 Windows executable, downloaded from php.net. I use it in CLI mode. When I first started using rss-bridge I ran into this exact issue, before I even knew about enabling DEBUG. Although I do code in PHP, I never use cUrl.

I see, thanks for sharing!
Are there any good practices for that?
We could detect if the script is running in CLI mode (servers should have valid certificates anyway), check if a certificate store is not defined (i.e. if(ini_get('curl.cainfo') === false) {...}) and opt for file_get_contents. There is a good chance that it won't work on all bridges, but that is something we can figure out later.
Would that work for you?

That would certainly fix the issue for me, yes.
I've always found the HTTP wrapper for file_get_contents to be sufficiently powerful, there are plenty of context options which can be set: http://php.net/manual/en/context.http.php
Additionally, $http_response_header is populated with the headers after executing file_get_contents.
If there's something with implementing file_get_contents I can help with, please let me know.

If there's something with implementing file_get_contents I can help with, please let me know.

Do you have a working implementation of getContents using file_get_contents by any chance?
https://github.com/RSS-Bridge/rss-bridge/blob/5305c405f65826a0cf3bd0050cc10bdfdc4da19c/lib/contents.php#L44
Here is the code before changing to cURL (this would be my reference): https://github.com/RSS-Bridge/rss-bridge/commit/ee78e7613fa6ceeb7cfebf91a2b2fe0a202ad68b
Maybe it still works? (minus the parameters removed in the past)

No, I haven't made a file_get_contents version of getContents .
However, I did substitute contents.php with the one from a4b9611e66d3095c943a5c63306965d4e4cbf839 . Then I changed line 512 in FacebookBridge to this:
			$html = getSimpleHTMLDOM($this->getURI())
It was a bit slow, but it worked without any SSL errors. The speed might be improved by adding headers.

TwitterBridge works too, after I added the getMimeType() function to the old version of contents.php.

PR #962 created, simple change but works for me on both Facebook and Twitter.
Open to suggestions of course.


This function has crashed – TypeError - (0 , import_slicedToArray2.default) is not a function

FYI: Originally started this thread in the Netlify Community: https://answers.netlify.com/t/remix-this-function-has-crashed-typeerror-0-import-slicedtoarray2-default-is-not-a-function/106308
Summary
I recently upgraded a Remix app I have deployed on Netlify from v1 to v2 by following the directions listed here:

Netlify – Upgrading from Remix 1 to Remix 2: https://github.com/netlify/remix-compute/blob/main/docs/upgrading.md 1
Remix – upgrading to v2: Upgrading to v2 | Remix

You can see my related PRs here:

Upgrade to Remix v2: Upgraded to Remix v2 by kevinreber · Pull Request #72 · kevinreber/ai-icon-generator · GitHub
Attempting to fix Netlify build: Hoping this fixes prod 🙏 by kevinreber · Pull Request #77 · kevinreber/ai-icon-generator · GitHub

References

Remix – Netlify Deployed Site: https://icongenn.com/
Github Rep: GitHub - kevinreber/ai-icon-generator: Generate images with the click of a button using Artificial Intelligence!

Looking at the logs it says my build is marked as “Complete”, but when I visit the deployed site I see the following message
This function has crashed

An unhandled error in the function code triggered the following message:
TypeError - (0 , import_slicedToArray2.default) is not a function

Stack trace
TypeError: (0 , import_slicedToArray2.default) is not a function
    at setTwoToneColor (/var/task/.netlify/functions-internal/server.js:1490:128)
    at Object.<anonymous> (/var/task/.netlify/functions-internal/server.js:1501:1)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Module._load (node:internal/modules/cjs/loader:960:12)
    at Module.require (node:internal/modules/cjs/loader:1143:19)
    at require (node:internal/modules/cjs/helpers:119:18)
    at Object.<anonymous> (/var/task/server.js:1:18)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)

Connection details
Netlify internal ID: 01HEYB4Z9T4ZBRKC5GK7SRBZ0F

Build Logs
8:42:02 PM: Netlify Build
8:42:02 PM: ────────────────────────────────────────────────────────────────
8:42:02 PM:
8:42:02 PM: ❯ Version
8:42:02 PM:   @netlify/build 29.26.3
8:42:02 PM:
8:42:02 PM: ❯ Flags
8:42:02 PM:   baseRelDir: true
8:42:02 PM:   buildId: 654f05f6e88e2e000862a54e
8:42:02 PM:   deployId: 654f05f6e88e2e000862a550
8:42:02 PM:
8:42:02 PM: ❯ Current directory
8:42:02 PM:   /opt/build/repo
8:42:02 PM:
8:42:02 PM: ❯ Config file
8:42:02 PM:   /opt/build/repo/netlify.toml
8:42:02 PM:
8:42:02 PM: ❯ Context
8:42:02 PM:   production
8:42:02 PM:
8:42:02 PM: build.command from netlify.toml
8:42:02 PM: ────────────────────────────────────────────────────────────────
8:42:02 PM:
8:42:02 PM: $ remix build
8:42:02 PM:  info  building... (NODE_ENV=production)
8:42:05 PM:  info  built (2.7s)
8:42:05 PM:
8:42:05 PM: (build.command completed in 3.2s)
8:42:05 PM:
8:42:05 PM: Functions bundling
8:42:05 PM: ────────────────────────────────────────────────────────────────
8:42:05 PM:
8:42:05 PM: Packaging Functions from .netlify/functions-internal directory:
8:42:05 PM:  - server.js
8:42:05 PM:
8:42:12 PM:
8:42:12 PM: (Functions bundling completed in 7.1s)
8:42:12 PM:
8:42:20 PM: (Netlify Build completed in 17.9s)
8:42:25 PM: Section completed: building
8:42:33 PM: Finished processing build request in 1m5.639s

Files setup
netlify.toml
[build]
  command = "remix build"
  publish = "public"

[dev]
  command = "remix watch"
  port = 3000

[[redirects]]
  from = "/*"
  to = "/.netlify/functions/server"
  status = 200

[[headers]]
  for = "/build/*"
  [headers.values]
    "Cache-Control" = "public, max-age=31536000, s-maxage=31536000"

package.json
{
  "private": true,
  "sideEffects": false,
  "type": "module",
  "scripts": {
    "build": "remix build",
    "dev": "yarn run check-env-file && remix dev",
    "start": "netlify dev",
    "typecheck": "tsc",
    "check-env-file": "node ./scripts/check-env-file.mjs",
    "postinstall": "prisma generate",
    "stripe:listen": "stripe listen --forward-to localhost:3000/webhook",
    "format": "prettier --write .",
    "lint": "eslint --cache --cache-location ./node_modules/.cache/eslint ."
  },
  "dependencies": {
    "@ant-design/colors": "^7.0.0",
    "@ant-design/icons": "^5.0.1",
    "@aws-sdk/client-s3": "^3.363.0",
    "@netlify/functions": "^2.3.0",
    "@netlify/remix-adapter": "^2.2.0",
    "@prisma/client": "^4.13.0",
    "@remix-run/css-bundle": "^2.2.0",
    "@remix-run/express": "^2.2.0",
    "@remix-run/node": "2.2.0",
    "@remix-run/react": "2.2.0",
    "antd": "4.24.10",
    "cross-env": "^7.0.3",
    "dotenv": "^16.0.3",
    "isbot": "^3.6.8",
    "moment": "^2.29.4",
    "openai": "^3.2.1",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",
    "remix-auth": "^3.6.0",
    "remix-auth-socials": "^2.0.5",
    "stripe": "^12.3.0"
  },
  "devDependencies": {
    "@remix-run/dev": "2.2.0",
    "@remix-run/eslint-config": "2.2.0",
    "@remix-run/serve": "2.2.0",
    "@types/eslint": "^8.44.3",
    "@types/react": "^18.0.35",
    "@types/react-dom": "^18.0.11",
    "eslint": "^8.38.0",
    "eslint-config-airbnb": "^19.0.4",
    "eslint-config-prettier": "^9.0.0",
    "prettier": "^3.0.3",
    "prisma": "^4.13.0",
    "tailwindcss": "^3.3.3",
    "typescript": "^4.9.5",
    "zx": "7.0.8"
  },
  "engines": {
    "node": "20.5.0"
  }
}

remix.config.js
/** @type {import('@remix-run/dev').AppConfig} */
import { config } from "@netlify/remix-adapter";

export default {
  ...config,
  serverDependenciesToBundle: [
    "@ant-design/icons",
<EMAIL_ADDRESS>    /^rc-util.*/,
  ],
  serverModuleFormat: "cjs",
};

This is not fixed yet ? I ended up with the same error. I tried to deploy a freshly created netlify vite template.

This is not fixed yet ? I ended up with the same error. I tried to deploy a freshly created netlify vite template.

i also faced the same issue wi passport js function.. any solution please

@kevinreber We're sorry you never got a response here. I hope you were able to resolve your issue. Since this is quite old, I'm going to close it. @mbsyaswanth @malik991 Please feel free to open new issues or (even better) post at https://answers.netlify.com/ if you're still having issues.


How do i work with GPS and Google Map in tabris

Is there a way i can integrate GPS locator and Google Map using tabrisjs?

I've tried many cordova geolocation plugins and this seems to be the only one that works. https://github.com/Moussawi7/Cordova-GPSLocator
Hope it helps.

Thank you for your response Wilsonna. I have been working with your tuts but i get [0,0] coordinates
from the console.
Below is my source code. Please help me rectify the problem.
https://drive.google.com/file/d/0B_697EAy7ssENDhwQnAtS3BpVTQ/view?usp=sharing

@smila I think you're missing this in your config.xml. Just add it to the end.
<gap:plugin name="https://github.com/Moussawi7/Cordova-GPSLocator" />

Feel free to reopen if you need more help on this issue.

@wilsonna Once the plugin is loaded, how do I access the GPSLocator object?
window.plugins.GPSLocator.getLocation(...)

Did not work for me, even though the tabris online build logs show the plugin is loaded from github


Allow Installation of Chocolatey with script from Chocolatey.Server

Similar to https://chocolatey.org/install.ps1

Holding open until main page has documentation about this.

Completed for 0.2.3


Automated view profile switching based on client's device and orientation

There are rotating curved monitors on the market right now, that can switch from landscape to portrait view. As this market matures, I can see more developers investing in such monitor since lots of developers already purchase 2 seperate monitors anyways, one vertical and one horizontal. Investing in a monitor that can support both orientation is a cost-effective way of achieving the same effect.
To support this, VSCode should implement view profile switching. VSCode can detect the device they're using and display a view layout based on a pre-configured preset that users have set. This is useful when switching from a small display such as a laptop to a bigger one such as a desktop monitor. More space means more flexibility in view configuration.
It's also going to be helpful once VSCode expands their software to mobile as well (as stated on their roadmap)
And of course, support for rotating monitors.
To expand on this idea, VSCode could also implement dual-device support. Developers like to work with both laptops and monitors, maybe there's potential in this area as well, just my 2 cent idea.

cc @sandy081 as this could tie in with general profiles

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Support native-space inputs

Currently, ICA-AROMA only supports standard-space inputs (MNI152 with 2mm3 voxels, I believe). In order to maximize compatibility with other ICA classification methods (e.g., tedana), we need to support native-space inputs as well.
Here are some blockers on this:

The thresholds in the classification procedure are hardcoded and linked to a specific standard space template.
We need methods to derive our masks of interest (brain, edge, csf, and out-of-brain) in native space. I think we need to assume there are tissue probability maps available.

Indeed, we should operate in the native space, perhaps using AFNI commands that do not interpolate the functional data at the resolution of the template, or viceversa.
1- IMO, the thresholds for spatial criteria should be the same because they are defined in terms of percentage.
2- Why not warping the MNI template of the ventricles to the native space instead? Alternatively, if tissue segmentation is available or desired to be computed, we could run FAST (FSL) or 3dSeg (AFNI) and then erode and dilate the CSF mask to keep only voxels in lateral ventricles (i.e. remove csf voxels in edges and sulci).

1- IMO, the thresholds for spatial criteria should be the same because they are defined in terms of percentage.

There are some odd ratios though. For example, csfFract is defined as the sum of z-statistics in CSF divided by the sum of z-statistics in the whole image. In native space, that is directly impacted by the coverage of the scan. Using the same template and masks for everything controls this, but in native space we'll have a problem. I think we need to scale it by the proportion of CSF voxels in the whole brain, maybe. Then we can adjust the classification threshold by that scaling factor.

2- Why not warping the MNI template of the ventricles to the native space instead? Alternatively, if tissue segmentation is available or desired to be computed, we could run FAST (FSL) or 3dSeg (AFNI) and then erode and dilate the CSF mask to keep only voxels in lateral ventricles (i.e. remove csf voxels in edges and sulci).

Depending on what data are available, I think that should work.

1- Relatively. I agree with you that the number of CSF voxels will be different in the native space than in the template space. However, my opinion is that this number should not be very different (of course, using the same voxel size) at least for healthy adult young subjects, maybe not for elderly subjects because they tend to have larger ventricles. I would stick with the same value at the moment, and check whether this ratio of voxels changes considerably. Perhaps, one possibility is that we do a linear interpolation, i.e. compute the ratio of voxels for the MNI template and adapt the csfFract according to the ratio in the native space. Thus, if the ratio is the same, the csfFract would also remain the same.

Now that we're dropping native-to-MNI transforms (#45), we definitely can't warp the packaged standard space masks into native space. Which tissue probability maps do we need to get the requisite masks?

[ ] CSF mask: CSF tissue probability map
[ ] Edge mask: ??
[ ] Brain/out-of-brain mask: ??

I would say the 3 of them:
1- CSF mask for the spatial criterion that computes the amount of variance of the spatial IC map that is within CSF ventricles. This can be computed from the CSF tissue probability map, then erode and dilate 2 voxels (e.g. 3dmask_tool -dilate_inputs -2 2) which should remove the CSF voxels in sulci and leave only the CSF in the ventricles.
2- Edge mask, similarly we need a mask that draws a ring in the borders of the brain. For instance, this can be computed by the EPI mask minus the same mask but eroded 2 voxels.
3- Do you mean a common EPI mask? We need it to constrain the ICA calculation to within brain voxels.

Which tools are you planning to use to compute the masks? Since fMRIprep is also interested in performing ICA-AROMA in native space, we could use the same tools, or the same code for generating masks as Tedana so that we can later incorporate these criteria into it.

Which tools are you planning to use to compute the masks?

One of the main goals is to use pure Python, so I'm planning to use nilearn and nibabel. We can use scipy.ndimage for the erosion and dilation, possibly nilearn.masking.compute_epi_mask for the initial brain and out-of-brain masks.

Edge mask, similarly we need a mask that draws a ring in the borders of the brain. For instance, this can be computed by the EPI mask minus the same mask but eroded 2 voxels.

The EPI mask will have the ventricles filled in, so eroding it won't catch the borders in the edge mask (see below).

Perhaps if we erode it after subtracting the CSF mask from the EPI mask?
If so, then we can create the brain mask from the EPI data, the CSF mask from a CSF tissue probability map, and the edge mask from a combination of the EPI mask and CSF TPM. I don't think we'll need gray matter or white matter TPMs.

The CSF mask is computed from the CSF tissue probability maps

The edge mask is the rim shown in the picture. Maybe we need more than 2 voxels.

The edge mask used by ICA-AROMA isn't just the rim. It's the internal edges too.

Yes, yes, I mean the internal edges too, so maybe dilation of the epi mask by 2-3 voxels, erosion by 2-3 voxels and then subtract the dilated one minus the eroded one.

Oh okay. Yes, I get something pretty good with the following code (4 erosions), using just the provided masks:
csf_img = nib.load('mask_csf.nii.gz')
oob_img = nib.load('mask_out.nii.gz')
brain_img = image.math_img('1 - mask', mask=oob_img)
gmwm_img = image.math_img('(brain - csf) > 0', brain=brain_img, csf=csf_img)
arr = gmwm_img.get_fdata()
temp = ndimage.binary_erosion(arr, iterations=4)
temp_img = nib.Nifti1Image(temp, gmwm_img.affine, header=gmwm_img.header)
edge_img = image.math_img('brain - core', brain=gmwm_img, core=temp_img)

Plotting the resulting edge_img gives me the following, which is slightly different from the original but still pretty close:

If the above approach is good, then we just need a threshold for the CSF tissue probability map for generating the CSF mask. Then, if the user provides a tissue probability map, we use that. Otherwise, we assume the data are in standard space and use the packaged masks.

Ok, I see now. Quoting the ICA-AROMA paper: Edge fraction Head movements will induce strong variations in voxels that are located near intensity edges of the brain, as head motion will shift the location of the brain relative to the voxel location (i.e. voxels do not represent identical brain regions over time). Accordingly, we assessed each IC's representation near the edge of the brain. To this end we defined an edge mask by subtracting an eroded whole-brain mask (in MNI152 2 mm space, eroded using a 10 mm box kernel) from the full MNI152 2 mm mask, hence retaining the edge of the brain. Prior to the erosion we subtracted a CSF mask from the whole-brain mask such that the edges around the CSF would be included in the edge mask. Next, we calculated each IC's edge fraction as the sum of absolute Z-values of voxels overlapping the edge mask or located outside the whole-brain mask, divided by the sum of absolute Z-values of all voxels.
So, yes, that picture is pretty nice

My question is whether we can also give the option of computing the tissue probability map in the program. We could use the same code as fMRIprep, nipype, or this algorithm in dipy. Or do we want to minimize any dependence?

I think I'd prefer to accept a TPM as an argument instead of trying to calculate it within the code- at least for now. If the dipy method is pure Python, though, I think that's reasonable to support in the future. What do you think?

Agree, we will need to look into the code.

Sorry for joining late. Great discussion!

There are some odd ratios though. For example, csfFract is defined as the sum of z-statistics in CSF divided by the sum of z-statistics in the whole image. In native space, that is directly impacted by the coverage of the scan.

Then the problem is not the coverage (except for limited FoV scans). If the resolution is the same and the whole brain is covered, then the ratio should be the same. Probably a simple correcting factor based on the ratio between the volume of the voxels in MNI ([2mm]^3) and the native space would do.

2- Why not warping the MNI template of the ventricles to the native space instead? Alternatively, if tissue segmentation is available or desired to be computed, we could run FAST (FSL) or 3dSeg (AFNI) and then erode and dilate the CSF mask to keep only voxels in lateral ventricles (i.e. remove csf voxels in edges and sulci).

I think this makes sense.

I think I'd prefer to accept a TPM as an argument instead of trying to calculate it within the code- at least for now. If the dipy method is pure Python, though, I think that's reasonable to support in the future. What do you think?

Agreed, I'd leave the responsibility for some other module. Here you really want to test that, given adequate TPMs you get similar (or better, if @tsalo and @CesarCaballeroGaudes are willing to eyeball a lot of data) components to those that the original implementation gives.


files: separate endpoints for flushing inbound and outbound files

This change splits the admin endpoint for "flushing" files into two endpoints (and a third for doing both). The change allows operators to have fine grained control over where files are at any given moment. (Useful for tests and tutorials.)
Issue: https://github.com/moov-io/paygate/issues/239

Codecov Report

Merging #257 into master will decrease coverage by 4.05%.
The diff coverage is 42.42%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   60.87%   56.81%   -4.06%
==========================================
  Files          31       31
  Lines        4595     4636      +41
==========================================
- Hits         2797     2634     -163
- Misses       1259     1481     +222
+ Partials      539      521      -18

Impacted Files
Coverage Δ

cmd/server/main.go
4.37% <0%> (ø)
:arrow_up:

file_transfer_async.go
52.38% <35.71%> (+0.93%)
:arrow_up:

file_transfer_sync.go
53.84% <61.9%> (-46.16%)
:arrow_down:

accounts.go
10.95% <0%> (-69.87%)
:arrow_down:

internal/database/mysql.go
10.66% <0%> (-50.67%)
:arrow_down:

ofac.go
38.65% <0%> (-35.3%)
:arrow_down:

internal/filetransfer/sftp.go
47.08% <0%> (-24.87%)
:arrow_down:

microDeposits.go
64.35% <0%> (-1.44%)
:arrow_down:

internal/filetransfer/config.go
65.12% <0%> (-0.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c90b66...f6c09d2. Read the comment docs.


Published

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Deploy preview for docsdocker ready!
Built with commit e0dc289650ec7845ebe5c37a90fd383266eff44d
https://deploy-preview-8674--docsdocker.netlify.com


Quasi global coverage for "Region"

For "Region" one can currently select different continents or other named regions. However, there are some products (e.g. from satellite) that provide coverage from say -50 to 50 degrees latitude. This is normally called something like "quasi global" coverage.
This might not be possible but it would be nice to be able to specify a text string with the latitude/longitude coverage. e.g. instead of selecting "Global" I could type in "-50 to 50 degrees latitude".

Theoretically is possible to do it already as there's a specific geospatial object in the record metadata itself. However, it's not visualised in the forms and it would be tricky to add a proper query to it. The from date to date temporal range already gives you an idea that querying what falls into a specific region is not trivial. I think someone else eventually might add this feature to the main portal and we'll be able to leverage it. In the meantime we could add more region like the semi-global you pointed out.

Yes a "semi global" or "quasi global" might do for now. It would cover datasets that only go to certain latitudes or as Claire pointed out satellite swaths. And I think this would help narrow down users' searches sufficiently.


Test SlotStateManager

This PR adds tests for the SlotStateManager class. It brings the class-specific unit test coverage from 35% up to 96% of lines.

@usnavi @shintasmith @ChandraAddala @VinnyQ Please review.

Coverage decreased (-0.02%) to 76.745% when pulling 57ccad1d93799bc4f561623e295140eb8a02677c on izrik:test-slot-state-manager-2 into ad9efa671e9a159898068aa7ecc816c96ea42c91 on rackerlabs:master.

Coverage decreased (-0.05%) to 76.722% when pulling 2047f5caa6873eda6b3115e97c9d6b0f0d18b0c8 on izrik:test-slot-state-manager-2 into ad9efa671e9a159898068aa7ecc816c96ea42c91 on rackerlabs:master.

Looks good


A failed get world infomation error

Description:
A failed get world infomation error occurs when calling the world list after creating a character.
I would like to know what causes this error and how to fix it.

Screenshots

Occurs when trying to access a channel in any situation.

did you recently update the server?

I am using the latest server, and it runs well in the local environment. However, when I run the server in the virtual server, the following error occurs.

do you see any errors in the console of your virtual server whenever this error occurs?

No, there are no error logs displayed on the virtual machine console.

Are you accessing the same database or 2 different ones?
On Fri, Jun 2, 2023, 6:51 p.m. Psyke1004 @.***> wrote:

No, there are no error logs displayed on the virtual machine console.
[image: Cap 2023-06-03 07-49-28-790]
https://user-images.githubusercontent.com/20449064/243004921-fd8e6d9b-64eb-445b-9496-e76974262d52.png
—
Reply to this email directly, view it on GitHub
https://github.com/ZeruLight/Erupe/issues/69#issuecomment-1574406831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFUMNXJU5OYGS5GHFLJN3K3XJJU5ZANCNFSM6AAAAAAYSPNRNY
.
You are receiving this because you commented.Message ID:
@.***>

Hello ! I have the same issue. Did you find any solution?

It works for me ! I just had to put my IP address in "host" instead of "localhost"

To solve the problem, simply set the server's public IP in the "Host" field of the config. 🙂


Managing reconnection

@Tryneus brought up a question of what to do if there are disconnections. There are two types of disconnects:

The Fusion client (browser) disconnects from the Fusion server
The Fusion server disconnects from RethinkDB

How do we handle that?
My initial impulse is that in either of those cases, the client-side app should be made aware of disconnections/reconnections, but all event setup should be automatically maintained/recreated if possible (otherwise we're pushing unnecessary boilerplate version on the user).
So:
var ref = new Fusion('localhost');
ref.on('connected', ()=>...)
   .on('disconnected', ()=>...);

However, any feeds the client has created should be maintained and should pick up where they left off. This may be very challenging technically until we add restartable feeds (and even after that, it'll be very hard until we add full-blown restartable feeds), so for now we might want to also issue an "emergency" event in case the feeds have been lost irrecoverably:
// Find better name than `all_is_lost`
var ref = new Fusion('localhost');
ref.on('all_is_lost', ()=>{refresh the whole page});

From @josephg in https://github.com/rethinkdb/horizon/issues/413#issuecomment-220224309

how I've implemented stuff like this in the past is for a reconnecting client to tell the server "I have subscribed to these queries, and am up to date at version X". Then the server replies with either "Here are changes A,B,C to bring you up to date" or "You are too far out of date. Here's a fresh copy of the query result set".

Horizon shouldn't get a library to magic away reconnections.
Some facts:

The open network connection is stateful. The state associated with the connection is the jwt token, any active subscriptions and pending messages (if any).
This state is managed by a server. If the client subscribes to more queries, we need to open more rethinkdb queries. If the client goes away, the rethinkdb queries need to be closed.

If you're using a library which automatically reconnects the client when it comes back, how does that work? Are you putting the client state in a database somewhere? Whats the TTL on that database? By what mechanism does the server re-open queries to rethinkdb? Does it keep them open forever 'just in case'? What about if the server restarts?
No matter what happens you'll need horizon-specific code on the server to handle reconnections (resubscribing to the queries that the client has subscribed to). You can either replicate the client-specific state (what queries, what versions they saw last) in another database, or the client can just tell you that state when it reconnects. The latter is faster and simpler and has fewer moving parts.

Does the client already re-subscribe to the same feeds when it reconnects? It seems like everything after that is just optimization.

@download13 the client doesn't resubscribe automatically, you have to recreate everything. They really should resubscribe though

Hello guys. Some question regarding the client reconnection.
Do I need to create a new instance of the Horizon in case of reconnection attempts?
What is the better way to destroy just disconnected instance with all subscriptions (I guess they all safety clear according to RxJS docs)?
Is is save just delete hzInstance?
I can do all this with the redux-saga but maybe  @deontologician suggest a advice or good practice how to implement a reconnection better.

Right now, I think it's safe to create new queries with an existing Horizon connection after reconnecting. It's not going to handle old queries that are already running correctly (it may re-use request_ids which will be buggy). This can get kind of messy, so I wouldn't blame you if you just created a new Horizon instance on each disconnect.
If you're willing to polish this up a bit, I'm going to suggest something kinda radical. I haven't tested this so buyer beware, but this is an Observable scheme to automatically refresh your queries when you disconnect:
// Each value is a function taking a Horizon instance and returning an Observable
const rawAppQueries = {
    userQuery: hz => hz('users').find(3).watch(),
    birdQuery: hz => hz('birds').findAll({family: 'corvid'}).watch(),
    // ... all other watch() queries in your app
    // fetch() and store() etc are one-shot so they won't need to be refreshed.
  }
}

// An observable that gives an infinite stream of new Horizon instances on each disconnect
const hzReconnector = Rx.Observable.create(subscriber => {
  const reconnector = () => {
    let hz = Horizon(hzOptions)
    hz.onDisconnected(reconnector)
    subscriber.next(hz)
  }
  reconnector() // kick off the chain
}).share() // share the Horizon instances between queries, important!

// Now, map each query into an observable that is resilient to reconnections.
const appQueries = {}
for (const query in rawAppQueries) {
  // when we reconnect, switchMap will unsubscribe from the old stream, and subscribe to the new
  // one, and everything will stay the same.
  appQueries[query] = hzReconnector.switchMap(rawAppQueries[query])
}

// Now in your app you can just use:

appQueries.birdQuery.subscribe(birds => console.log('Birds:', birds))

So one limitation of this, which is fixable but makes the code above a bit more convoluted, is that when we reconnect the query, we'll re-emit the initial state again. Most virtual dom implementation (like React) won't re-render if the state is actually identical, but if you aren't using a virtual dom this may make a difference and you'll want to de-dupe your state events.

I would like to add that to achieve the desired effect with RxJS 5 and my current latest version of horizon (^2.0.0) I had to perform the following modifications:
// Each value is a function taking a Horizon instance and returning an Observable
const rawAppQueries = {
    userQuery: hz => hz('users').find(3).watch(),
    birdQuery: hz => hz('birds').findAll({family: 'corvid'}).watch(),
    // ... all other watch() queries in your app
    // fetch() and store() etc are one-shot so they won't need to be refreshed.
  }
}

// An observable that gives an infinite stream of new Horizon instances on each disconnect
const hzReconnector = Rx.Observable.create(subscriber => {
  const reconnector = () => {
    let hz = Horizon(hzOptions)
    hz.onDisconnected(reconnector)
    hz.onReady(() => subscriber.next(hz));
    setTimeout(hz.connect, 5000);
  }
  reconnector() // kick off the chain
}).share() // share the Horizon instances between queries, important!

// Now, map each query into an observable that is resilient to reconnections.
const appQueries = {}
for (const query in rawAppQueries) {
  // when we reconnect, switchMap will unsubscribe from the old stream, and subscribe to the new
  // one, and everything will stay the same.
  appQueries[query] = hzReconnector.switchMap(rawAppQueries[query]).retry();
}

// Now in your app you can just use:

appQueries.birdQuery.subscribe(birds => console.log('Birds:', birds))

It will, as mentioned, re-emit the initial state, which isn't a problem in my case.


chore: Add check for replicated.app to support bundle specs missing the check

What this PR does / why we need it:
Collect information of whether connection to replicated.app succeeded or not, and analyse the results. The check already existed here but was missing in other specs
Which issue(s) this PR fixes:
sc-113418
Does this PR require a test?
NONE
Does this PR require a release note?
Test connection to replicate.app and analyse results when collection support bundles in non-kURL clusters

Does this PR require documentation?

NONE

Support bundle tests are expected to fail according to https://github.com/replicatedhq/kots/pull/4935#issuecomment-2400599245.


BIGTOP-4021. Upgrade ZooKeeper to 3.7.2.

Description of PR
This PR upgrades ZooKeeper version to 3.7.2.
How was this patch tested?
Ran the following commands on Rocky 8 (x86_64).
$ ./gradlew allclean hadoop-pkg repo -Dbuildwithdeps=true
$ cd provisioner/docker
$ ./docker-hadoop.sh -d -dcp -C config_rockylinux-8.yaml -F docker-compose-cgroupv2.yml -G -L -k zookeeper -s zookeeper -c 1

...

TestZookeeper > testZkServerStatus STANDARD_ERROR
    23/10/15 14:45:04 INFO lang.Object: Running zkServer.sh status
    23/10/15 14:45:04 INFO lang.Object: zkServer.sh status checks out.
Finished generating test XML results (0.007 secs) into: /bigtop-home/bigtop-tests/smoke-tests/zookeeper/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.018 secs) into: /bigtop-home/bigtop-tests/smoke-tests/zookeeper/build/reports/tests/test
Now testing...
:bigtop-tests:smoke-tests:zookeeper:test (Thread[Daemon worker,5,main]) completed. Took 1.095 secs.

BUILD SUCCESSFUL in 29s

For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[x] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

LGTM, +1.


Actions: Add echo workflow command

Why:
Closes #7868
What's being changed:
Add a section about the echo workflow command (::echo::on and ::echo::off) provided by actions toolkit: https://github.com/actions/toolkit/blob/main/docs/commands.md#command-echoing
Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@Simran-B
Thanks so much for opening a PR! I'll get this triaged for review :zap:


sddm language combobox not functional / missing lxqt & lumina entries

Same solution as done for lxdm?

Lumina / LXQt entries are back by edb0deb59c99f5fbe0e64a31af50d45be8f6aa69


Should conditional type evaluation destroy data?

I have an attribute directive I applied to my own decorator to remove data that was in elements hidden by a conditional type evaluation.
Should this perhaps be included in the main angular-schema-form behaviour?
(function(window, angular, undefined) {'use strict';
  angular
    .module('schemaForm.extension',[])
    .directive('destroyHiddenData', ['oySchemaFormUtil', function(oySchemaFormUtil) {
      return {
        link: function(scope, element, attrs) {
          scope.$on('$destroy', function(){
            if(scope.form.key) oySchemaFormUtil.setKeyValue(scope.model, scope.form.key, '');
          })
        }
      };
    }]);
})(window, window.angular);

Note: the oySchemaFormUtil is my own function that just manipulates data based on key, but unlike the built in one it also allows for total deletion which is why I use it instead. Not relevant to discuss in this post thread.

Yes, this might be a good idea... It would make conditional even more useful.
Maybe an option to turn it off if needed?

I would suggest that the option allow for setting the value to a user preferred ( null, undefined, empty string or the current behaviour of do nothing) value, as in many cases it completely depends on how they then save the data to their database.

Upon reflection I would like the default behaviour to set the value to null. It should not delete it as that is not ideal in JavaScript and the back end will need to be able to see changes without relying on every field always having a value.

@Anthropic  I took a stab at this feature in https://github.com/Textalk/angular-schema-form/issues/371. I opted to use undefined instead of null, as that would most closely represent the state of how the user experienced the form (they don't see the question, so it never should come up in the model). However, I did include a check for a formDefaults definition of the destroyStrategy, which would allow for the entire form to use null as the mechanism for destroying data that has been hidden.

@jbsaff great, I will keep an eye on it :)

Completed by #371


Automate ticket creation

See for example missing files error_code_config.yml, e.g. https://github.com/exasol/script-languages-release/issues/719

Closed in favor of https://github.com/exasol/product-integration-tool-chest/issues/57


EPERM operation not permitted fdatasync if backup before save enabled 1.0.4

As the topic says. The backup gets created but the file itself fails to save.
Switching off backup before save fixes this issue.
Please fix ASAP!!!

/cc @nathansobo

this is also happening to me

Glad I made it optional... It would be great to get some more information. What platform? Does this happen always or intermittently? Are there any stack traces available?

In my case, Win 7 x64.
File creation permissions are on - I can save the same file fine with the option off or using 1.0.3. The backup gets created in the same folder, so it's further proof that permissions are on.
Happens always if I have the option on.
As for stack traces, how do I get them?

Windows 7, x64
If 'backup before save' is enabled, it always happens
Yes, I have file creation/editing permissions
It gives this error message: "Unable to save file 'C:\Users\me\file.js    EPERM: operation not permitted, fdatasync"
It creates the backup file in the directory. When I try it three times, it creates three backup files and looks like this:

file.js
file.js~
file.js~~
file.js~~~

Was happening to me to, Win 8.1, turned off Backup before save and it's fine.
Was saving to a network drive that goes to my local Ubuntu VM.
Error was unable to save bla bla, then EPERM: operation not permitted, fdatasync

In my case it was my own HDD, NOT a network drive.

I just want to add that this affects me as well (Windows 10, x64). If 'Backup Before Save' is enabled, the backup file is created but never overwrites the actual file being saved. It ALWAYS happens, and the file is being saved on a local hard drive by a user account that has full file creation/deletion permissions. The problem does NOT occur for me on OS X (Yosemite), so it seems specific to Windows.

@bronson Any insight on these errors or suggestions? Time to start researching fdatasync on Windows I guess.

@nathansobo, no idea if the problem is in Atom, Node's fs binding, the filesystem, or Windows itself.  I'm unhappy to see it's happening with a local HD too.  I was hoping this would be yet-another-network-filesystem oddity.
@Zireael07 what filesystem were you trying to save to?
I googled but can't find much info about the combination of fsync, node, and windows.  I don't have any VMs lying around to try it anymore (stopped keeping up with the upgrade treadmill).
Is it worth extracting this to a small, reproducible test case script and asking the Node community?

Would still love to see a stack trace from someone that can reproduce this issue? I'm wondering if it's caused by our attempt to call FlushFileBuffers with the directory handle.

@nathansobo just tell me how to get one :smile:.  I can repro this.

I think this is because you can't fdatasync a directory on Windows, and we're doing that to ensure the backup file's directory entry is flushed to disk. I need to get a build going again in a VM to see if this is true.

I just did a small test on my Windows VM where I tried to call fdatasync with a directory file descriptor and got this exact error. We're just not going to be able to sync the file entry on Windows. @bronson do you have any clever ideas for alternatives?

Found someone with the same experience: "On Windows… err, there is no clear answer. You can not call FlushFileBuffers() on a directory handle as far as I can see."
Supporting evidence: Lucene still attempts the fsync on the dir and just eats the error: https://issues.apache.org/jira/browse/LUCENE-5588
That might be the best approach...  It would not surprise me if Linux/OSX can mount some network filesystem that also barfs when fsyncing directories.  Might as well attempt a sync but proceed even if it bombs.

Why was this closed? I'm having the same problem and don't see a fix or patch here...

@ejoso The fix is on master, it will be available on the next release (1.0.6).

this is also happening to me. v1.0.4

@johnsonz You're using an old version of Atom - you need to update to the latest version (1.0.9) for the fix.

@mnquintana Thanks


Add context and/or a help link to "Environment not found" error

We could create something like http://melta.no#environment-not-found when folks run into

#6677

We could also give hints such as using the --no-environment flag or running meltano environment add dev.
This could leverage the new MeltanoError class and practices.

@aaronsteers This may not be necessary after the following two PRs:

#6877
#6862

The new error messages from #6862 are fairly clear, and #6877 will make it so that when the user does not have default_environment set in their meltano.yml, they won't be told that the dev environment (which they never made or asked for) cannot be found.


feat(commands): add FlutterSuper and FlutterReanalyze

FlutterSuper respects Spec: https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/tool/lsp_spec/README.md#darttextdocumentsuper-method
FlutterReanalyze respects Spec: https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/tool/lsp_spec/README.md#dartreanalyze-method.

Thanks for the contributions @changyiyao


Using nested NiceModalProvider for new window

Hello, thanks for this good library. I've always used it well.
I'm opening this issue because I have a suggestion.
I found that the dispatch is declared as global variable. In a situation that you have a single provider, this isn't a big deal. But this is problem if you are using more than one provider.
When NiceModal.provider is called, the global dispatch is updated with givenDispatch or new dispatch function that returned from useReducer hook.
const InnerContextProvider: React.FC = ({ children }) => {
  const arr = useReducer(reducer, initialState);
  const modals = arr[0];
  dispatch = arr[1]; // update with new dispatch
  return (
    <NiceModalContext.Provider value={modals}>
      {children}
      <NiceModalPlaceholder />
    </NiceModalContext.Provider>
  );
};

export const Provider: React.FC<Record<string, unknown>> = ({
  children,
  dispatch: givenDispatch,
  modals: givenModals,
}: {
  children: ReactNode;
  dispatch?: React.Dispatch<NiceModalAction>;
  modals?: NiceModalStore;
}) => {
  if (!givenDispatch || !givenModals) {
    return <InnerContextProvider>{children}</InnerContextProvider>;
  }
  dispatch = givenDispatch; // update with givenDispatch
  return (
    <NiceModalContext.Provider value={givenModals}>
      {children}
      <NiceModalPlaceholder />
    </NiceModalContext.Provider>
  );
};

If you use multiple providers, the global dispatch will be updated with dispatch function intended by the last called provider. And every modals will only be rendered under this last provider because all methods in library (like NiceModal.show) use global dispatch.
function SomeApp() {
  return (
    <NiceModal.Provider> // update global dispatch
      <SomeArea />
      <NiceModal.Provider> // update global dispatch again
        // the modal dispatched in 'SomeArea' will be rendered here
      </NiceModal.Provider />
    <NiceModal.Provider />
  )
}

I know that this is not common case.
In our team, we open new window and render components with react portal. In this case we should use multiple providers to render modals in new window.
function NewWindow({ children }) {
  const [container] = useState(() => {
    const newWindow = window.open()
    const container = newWindow.document.createElement('div')
    newWindow.document.body.append(container)
    return container
  })

  return ReactDOM.createPortal(children, container)
}

function SomeApp() {
 return (
    <NiceModal.Provider>
      ...
      <NewWindow>
        <NiceModal.Provider>
          ...
        </NiceModal.Provider>
      </NewWindow>
    </NiceModal.Provider>
   )
}

So I suggest following.

provide dispatch function with contextconst InnerContextProvider: React.FC = ({ children }) => {
  const arr = useReducer(reducer, initialState);
  const modals = arr[0];
  dispatch = arr[1];

  return (
    <NiceModalContext.Provider value={modals}>
      <NiceModalDispatchContext.Provider value={dispatch}
        {children}
      </NiceModalDispatchContext.Provider>
      <NiceModalPlaceholder />
    </NiceModalContext.Provider>
  );
};

use the dispatch from context in showCallback that is returned by useModal hookexport function useModal(modal?: any, args?: any): any {
  ...
  const dispatch = useContext(NiceModalDispatchContext)
  ...
  const showCallback = useCallback((...) => {
    ...
    dispatch(showModal(...))
  }, [...]
}

Thanks for reading.
Please consider and respond.

Hmm, so why you need to use nested provider? To render modals under a new window's DOM?

To render modals under a new window's DOM?

yes!

Nested usage is only a subset of the problem - the same problem occurs with providers in different places in the React tree.
We have this issue in a shadow DOM context. That would usually be a web component, but we're using it for micro-frontends, where parts of the ui are in isolated containers with their own shadow DOMs. I was quite surprised to see modals rendered inside another shadow DOM - I was expecting the NiceModal.Provider context to contain everything, also registered modals etc, so that each provider would work independently from each other.


documentation: Fix "you you" typos in docs/comments/logs.

Noticed the "you you" typo in the documentation for the GitLab integration, and then did git-grep "you you" to fix any other instances of this same typo in docs.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @laurynmm! This is definitely a class of typo that I sometimes generate :)


Fix 'ack-grep' bug for non-ubuntu users

Redirect STDERR along with STDOUT when looking for ack-grep
Fixes #4454
Closes #4456

:+1:
If you put "Fixes #4454" and "Closes #4456" in the body of this PR description at the beginning of a line, it'll auto-close the bugs when this is merged.
@mcornella, this is a trivial change and tests fine; we should merge soon to clear up spurious errors users are seeing with this week's update.

Will do, thanks for the tip!


Fix a bug in get_node_and_resource when the property is set to null

In this project a property is set to null and get_node_and_resource() is unable to get it:
get_node_and_resource_bug.zip
this is because a value of null is used to check for a failed get(), which is not the right way to do it.

Thanks!


Artemis 4187

You defined logDebug which takes a Supplier<String>, and you use it like this, e.g.:
logDebug(() -> String.format("Switch from OVER_SIZE to OVER_ELEMENTS [currentSize=%s, currentElements=%s, lowerMarkSize=%s, maxElements=%s]",
        currentSize, currentElements, lowerMarkSize, maxElements));

However, I don't see how that is preferable to just following the same logging pattern that's used in the rest of the code-base, e.g.:
logger.debug("Switch from OVER_SIZE to OVER_ELEMENTS [currentSize={}, currentElements={}, lowerMarkSize={}, maxElements={}]", currentSize, currentElements, lowerMarkSize, maxElements);

Couple of other issues:

All commits need to be squashed.
Your commit message should conform to the pattern outlined in our Hacking Guide.

The logDebug method confirms to the already present logging construct in the SizeAwareMetrics-class. e.g. in de addSize-method which uses the logger.isDebugEnable-method:
  if (delta == 0) {
     if (logger.isDebugEnabled()) {
        logger.debug("SizeAwareMetric ignored with size 0", new Exception("trace"));
     }
     return sizeUpdater.get(this);
  }

It is a separate method because op the DRY-principle and the supplier is there to "lazy init" the string for performance reasons.
But I'm more than happy to boyscout out the entire logging contruct ??
Futhermore, I will squash and have a look at the commit-message(s).

Since moving to SLF4J and adopting a new logging pattern we've eliminated almost all of the invocations of isDebugEnabled, isTraceEnabled, etc. due to the fact that the new pattern uses invocations like debug(String format, Object... arguments) and this already implements lazy init. As noted in the JavaDoc for SLF4J, e.g.:

This form avoids superfluous string concatenation when the logger is disabled for the DEBUG level.

The reason isDebugEnabled is still used in the instance you cited is that it doesn't follow this normal pattern and furthermore uses new Exception("trace") which is especially costly in terms of performance. If you follow the pattern outlined in my previous comment I think the code will be simpler, more readable, more consistent with the rest of the code-base, and essentially equivalent in terms of performance.
I'm not sure what you mean by "boyscout out".

I change the logging etc.

@jbertram Do you expect anymore work on my part ?

Legit from my POV! Generally good piece of code and improvement.

@Maverick19841972, sorry it took so long to get this merged. Thanks for the contribution!
I added a small test called testConsistency to org.apache.activemq.artemis.utils.SizeAwareMetricTest because I noticed that none of the modified tests actually failed without your fix. This test validates your fix directly.


feat: change key mappings for switching panes

Nice mapping. Definitely simpler. I think next step will be integrating this with tmux as well. So tmux panes/neovim windows can be moved between with same keys.


Fix native package installation issue

The directory /var/log/mysql should be notified to create after
mariadb-server was created. Otherwise, the system cannot find the
user/group mysql:mysql and the folder creation will fail

this is breaking centos 7.1 deploys, any outlook on merging this and getting a new version out?

Please, remove any informations on changelog, or on version from your PR... We will update these based on more than one PR. Thx in advance.

This doesn't seem to be relevant anymore as current CI tests pass on existing master branch.  Feel free to reopen if you would like to discuss further.


[DRAFT] chore(gql): Add DialogToken requirement for subscriptions

Description

Related Issue(s)

#1104

Verification

[ ] Your code builds clean without any errors or warnings
[ ] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

[ ] Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@coderabbit full review


V2 Harmony deployment

Should we make use of freshDeploy instead of silencing out the throw errs ?

Is this deployment method consistent with the one by cannon (via hardhat-cannon)? Looks like they wrote their own CLI-based deployment management system, then somehow decided to abandon it and switch to cannon. So there is a good chance that the scripts here are outdated or inconsistent


Timeline Performance gains

Overview
In applications where there is a lot of manipulation to the timeline with many events the performance degrades.
I first notice that the timeline rerenders the whole tree if the parent component rerenders.
See the profiling screenshot.

This takes on average 200ms to rerender on a 2.2ghz  6 core i7  MacBook Pro  which is decent but does take significantly longer on our low powered devices (seconds)
You man also notice that we applied some memoization components to our app which also did not help.
The reason why is because the context is always a new object on every rerender. So any component that use the TimelineContext will rerender because the context state had change.
With the changes made in this PR and the same optimisations applied in the previous test the render time dropped to <9 ms

Reason
[Why did you do what you did? - feel free to copy from the ticket if the reason is there]
Work carried out
[A list of work you have done, use markdown checklist format, if you leave any boxes unchecked, be sure to set this PR as a WIP]
Example.

[x] A bit of work I completed
[ ] A bit of work I did not complete

Screenshot
[If the work is UI related then paste a screenshot of the update here.]
Developer notes
[Sometimes, extra notes are needed to add clarity to a PR, add them here]

Nice change 🔥
Is there an easy way to cover this with a test?
hmm I'm not sure if there is a elegant way to test that a rerender was skipped using react-testing-library

I would argue that a regression test is enough because the functionality is identical.


Added 'Master Script' base JSON DB

Description
First PR Considering Master Script project, which is a menu-driven script that creates a user-friendly interface that helps navigating in the repo. Added the JSON file DB
Fixes issue #831
(didn't correctly link it, to not automatically close the issue)
Notes

Not all projects are added, some are yet still under discussion on how it should be implemented. - refer to this comment -
It will be appreciated that the next contributor updates the DB while doing his part as the repo adds new projects almost daily.

Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] My documentation follows Template for README.md
[x] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@kaustubhgupta updates?

@kaustubhgupta updates?

Hi, @XZANATOL I will review it in the afternoon as this is a big issue and I think that your script will make the pull request automation too. I will try to update you today

@santushtisharma10 @antrikshmisri this PR needs urgent attention and approval so that we can start working on the automation part

@kaustubhgupta So what is going to happen next is that we are going to import the script into a GitHub action which will get the required inputs of the database from an updated PR template. Am i correct?

@kaustubhgupta So what is going to happen next is that we are going to import the script into a GitHub action which will get the required inputs of the database from an updated PR template. Am i correct?

Yes, you are correct. I am preparing some notes for this and I will share a pseudo implementation soon on the main issue. Then you can modify the script and then we will test it on our forked repos or maybe demo repositories. If it works well then I will instruct all the participants to fix their issue descriptions and merging them will be a real test for us. I hope it goes as expected.

@kaustubhgupta this is getting really interesting. :D
OK, add on these that I've a demo repo where I use to test actions, we can use it for this goal.


Translators needed

I'm almost finished with the internationalization for the entire demo on
https://github.com/valioDOTch/nothing-to-hide-i18n/
If you know anyone who speaks sth else than English, you might be interested to let them translate that
https://github.com/valioDOTch/nothing-to-hide-i18n/blob/master/code/FINAL/locales/translation-en.json
It should contain all the strings now.
For the detailed translation how-to please read
https://github.com/valioDOTch/nothing-to-hide-i18n/wiki
By tomorrow a version which switches nicely between German and English (and probably more languages, if more translations are available until then). This includes a command line script to be executed before deployment, which adapt the graphics in the game and fits the translated scripts into the available space. So no manual editing of graphics required. :)

@AlexTalker just seen this now; I was somehow to stressed back then to read through it.
Sorry for that.
Interesting stuff. If I'd knew that back then I probably would have gone for Transifex. :-/


Fix issues introduced by new versions of matplotlib and scipy

There where API changes with matplotlib=3.5.0 and scipy=1.7.0 that caused issues with virocons plotting module.
See issues #141 and #147 for more details.

Codecov Report

Merging #149 (5f84650) into master (723bebe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   78.28%   78.29%   +0.01%
==========================================
  Files          12       12
  Lines        1745     1746       +1
==========================================
+ Hits         1366     1367       +1
  Misses        379      379

Impacted Files
Coverage Δ

virocon/plotting.py
93.43% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 723bebe...5f84650. Read the comment docs.

Are you suggesting that we update the requirements.txt to matplotlib 3.5.0 then (or an ever newer version)?! I'd suggest that we include this change in this PR too.
Otherwise we should check how this change affects the output of the old matplotlib version (or have you checked this too?).

[ ] update requirements.txt

I can not reproduce this error on my local machine.
FAILED tests/comparison-to-virocon-v1/test_contours.py::test_DirectSamplingContour
E       AssertionError:
E       Not equal to tolerance rtol=1e-07, atol=0
E
E       Mismatched elements: 2 / 144 (1.39%)
E       Max absolute difference: 0.24902724
E       Max relative difference: 0.02702703
E        x: array([[11.139718, 13.076029],
E              [13.051927, 13.076029],
E              [13.117635, 13.07028 ],...
E        y: array([[11.139718, 13.076029],
E              [13.051927, 13.076029],
E              [13.117635, 13.07028 ],...

@ahaselsteiner can you reproduce this error on your local machine with this new requirements.txt?
Should we just increase the tolerance or xfail this test?


Firefox doesn't like our current service worker

Firefox is currently unhappy about something in our service worker script for Phase 3, leading to
Service worker registration failed: TypeError: ServiceWorker script at https://io-webapp-staging.appspot.com/io2016/service-worker.js for scope https://io-webapp-staging.appspot.com/io2016/ encountered an error during installation.

in the JS console in both localhost and the staging server. The production website's SW registration works fine in Firefox.
I'm going to see if there have been meaningful improvements to Firefox's SW debugging tools recently and try to track down what's going on.

TypeError: ServiceWorker script at https://kelvin.mbioq.com/sw.js?v=570 for scope https://kelvin.mbioq.com/ encountered an error during installation.

Yup, this still happens. :/

@marcusklaas How did you solve this mistake?

I didn't.. bug is still open I think.


Clarification of data locations in the three architectural components

Redrafted the wording and location of sections to make it clear that:
customer input - azure AVD objects are to be stored in any of the 4 geographies
customer data - can be deployed in any Azure region with supporting services + Azure Stack HCI (preview)
diagnostic data - comes from customer input location + user connect location
service generated data - scrubbed and sent to USA

@MicrosoftDocs/public-repo-pr-review-team

This article was updated and the information in this pull request is currently out of date. #please-close


Keptn`s bridge: Collection of Enhancements

As a user of the Keptn's bridge, I would like to propose a minor enhancement that would have a great impact on the understandability and in general on the usability of the Keptn's bridge.

Actions:

Please use this issue, to propose an idea that helps achieve a better experience when using the Keptn's bridge.
Feel free to comment on any idea.

It is hard to tell this is a service:

It is not really clear what this item is:

We should think of giving it a better name.

The JSON payload of each event should be hidden and not that prominent. Maybe just show important meta-data of each event.

Getting started with your first project: When no Keptn project is available because the user opened the bridge right after the installation of Keptn, a guide should be provided: how to set up a project and onboard a sample app.

Filter and search option for Problem/Deployment events.

@johannes-b
May I close this issue, since I created a separate issue in github for each request for easier planning?


compute_mask not called when custom layer does not alter inputs and mask is not None

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.0.0-beta
Python version: 3.7.3-2
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
When the layer does not alter the inputs (but alters the mask), if mask is not None, the layer does not execute the compute_mask method.
Describe the expected behavior
Call compute_mask and attach the mask to output regardless.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf
import numpy as np

class RandomMaskingNoAlter(tf.keras.layers.Layer):

  def call(self, inputs):
    return inputs

  def compute_mask(self, inputs, mask=None):
    print('no alter executed')
    if mask is None:
      return None
    random_mask = tf.cast(tf.random.uniform(tf.shape(mask), 0, 1, dtype=tf.int32), tf.bool)
    return tf.math.logical_and(random_mask, mask)

class RandomMaskingAlter(tf.keras.layers.Layer):

  def call(self, inputs):
    return inputs + 0

  def compute_mask(self, inputs, mask=None):
    print('alter executed')
    if mask is None:
      return None
    random_mask = tf.cast(tf.random.uniform(tf.shape(mask), 0, 1, dtype=tf.int32), tf.bool)
    return tf.math.logical_and(random_mask, mask)

x = np.array([[1, 4, 2, 2, 0, 0], [1, 1, 1, 0, 0, 0], [3, 2, 2, 3, 4, 1]], dtype='i4')
y = tf.keras.layers.Embedding(5, 5, mask_zero=True)(x)

z1 = RandomMaskingNoAlter()(x)
z2 = RandomMaskingNoAlter()(y)
z3 = RandomMaskingAlter()(x)
z4 = RandomMaskingAlter()(y)

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@deasmhumhna ,
When tried executing the given code the following output was received
no alter executed  alter executed  alter executed is the same output received from your side also?Thanks!

@deasmhumhna ,
When tried executing the given code the following output was received
no alter executed alter executed alter executed is the same output received from your side also?Thanks!

Yes, that is what I get. The result should be no alter executed no alter executed alter executed alter executed (compute_mask should always be called if implemented by a subclass). I am however curious why it runs when mask=None but not if there is a pre-existing mask. Some kind of optimization?

Issue replicating with TF 2.0beta, kindly find the gist of colab.Thanks!

Issue is replicating with TF nightly version (2.4.0-dev20200902).Please, find the gist here. Thanks!

Issue is replicating with TF nightly version (2.6.0-dev20210416).Please, find the gist here. Thanks!

It seems that the problem still exists in TF 2.5.
Any plans to fix it?

Able to reproduce the issue in TF 2.6 and TF-nightly, and the reported issue still exists. Please find the gist here. Thanks!

Hi @deasmhumhna , Edited your code at this part to resolve the issue.
class RandomMaskingNoAlter(tf.keras.layers.Layer):

  def call(self, inputs):
    return inputs

to
class RandomMaskingNoAlter(tf.keras.layers.Layer):

  def call(self, inputs):
    return inputs+0

providing gist for reference

This is a not-so-nice hack to somehow circumvent the bug.
Definitely, not a solution.

Hi There,
This is a stale issue. As you are using an older version of tensorflow, we are checking to see if you still need help on this issue. Please test the issue with the latest TensorFlow (TF2.7 and tf-nightly). If the issue still persists with the newer versions of TF, please feel free to open it in keras-team/keras repository by providing details about the issue and a standalone code to reproduce the issue. Thanks!
Please note that Keras development has moved to a separate Keras-team/keras repository to focus entirely on only Keras. Thanks!

I would suggest that Keras team will add a unit test to cover this issue (and endless number of other issues). Passing down to the users the task of testing issues in every new release with a hope that the issue is somehow fixed does not look like a good strategy.....

Thanks @mohantym that saved me. I was wondering why mine wasn't working either, and that fixed it for me. I agree, this is a crappy fix though. I'm running TF 2.6.0 installed via Conda and it's an issue there, but I can't check a newer version

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


Add Execution Environment detail page with tabs and actions

@himdel Is it okay to change EE paths to execution-environments/alpine/activity, the old UI is containers/alpine/_content/activity/?

yeah, UI paths will be different in the new UI, that's fine :)
(just make sure it still works when the container is foo/bar instead of alpine)

oh, that's a good point, I have to test what happens with foo/bar format, probably needs to be fixed.

Looks like react router escapes into foo%2Fbar, not sure if that's the desired output

Yeah, as long as foo%2Fbar in the url works, and the rest of the ui works as expected, I think that's close enough for now :)
The old ui implements it as 2 sets of routes, one with /:namespace/:name/, other with just /:name/ but it's a bit of a hack, it could be replaced with optional params now (in the old ui, along the lines of /:namespace?/:name/), but the hierarchical router here may need some work to support that...
We can leave supporting foo/bar in the url as a separate issue, as long as foo%2Fbar works :)


Add a safe mode to the API

Add a safe mode or something similar that blocks out all even just remotely offensive jokes for applications that really cannot allow any slack in the flagging / categories.
This mode will be opt-in, activated by adding ?safe-mode (value-less) to the URL parameters.
Joke objects need to have an additional property safe that can be true or false.
This value is determined when going through the submission prompt and can't be influenced by the client that sent the submission.


Very minor typo in README.md

In quick start, when calculating the gamut volume coverage, the command in the code block is
gamutIntersection = IntetersectGamuts(gamut,srgb);
There is a typo in the function: it should actually read
gamutIntersection = IntersectGamuts(gamut,srgb);

Thanks! I'll get that sorted.


Search friendly name.

I would recommend you to change the project name from "uptodate" to something like "application-updater". as I think it is more likely to come up on search results.

It's not all in the name; I can add unlimited keywords to help search engines.

Actually limited to 20 keywords

So please do something! Don't let it get sleepy!

Anyway, with so many projects out there, don't get your hopes to high up you"ll be getting to much attention on it.

Such projects are good just if you are working with a few coders together, to have everything in one place. Don't be prepared to get a community of contributors for it.


Syncing latest changes from release-v3.10 for ceph-csi

PR containing the latest commits from release-v3.10 branch

I have created this PR manually, because auto-sync (i.e, rebase) isn't feasible anymore as we have switched to an upstream branch that doesn't have few changes that are present in the release-4.15 branch.
I will comment out the ceph-csi branch sync for the time being, and continue with other repos.

/lgtm
/approve


Version the template

If there is a schema to version launchpad and the images, the template should also be versioned.

And where would one normally put that version?

The idea is to move our launchpad to DevTools OSD, and they have their own CI process, as explained here: https://github.com/openshiftio/appdev-planning/issues/37
So as far as I understand, the version should be specified in a IMAGE_TAG env var, but I could be wrong

There's 2 versions really when talking about templates:

The version for the template, so that you can identify at any moment if you have the latest, and if there's changes in the template compatible/incompatible with the software.
The version of the application (image/images).

You can align the version of the template and the images, so that a template x.y.z always deploys versions x.y.z of the application or a fixed combination (a.b.c for app1, and e.f.g for app2 and m.n.o of app3). In this case, if you release a new version of app1 or app2 or app3 or a combination of them, you'll update the template with the new versions for those apps, and version the template.
Another option is to have the template open, so that a user can specify which versions of app1, app2 and app3 wants to deploy.
A middle solution can be using the second approach and limiting in the parameters, which versions can be applied, so that you can for example, deploy different combinations of minor versions (e.g a.b.1, a.b.2, a.b.9) but no (a.x.1)
All this versioning thing needs to be done on the release process, which is what vaclav pavlin does.


Check BMX055 output values for sensebox for all blocks

methods from the sensebox library for bmx055 sensor may return unexpected values
values in general need to be scaled and converted to correct units

accelerometer gives back values from -1 to 1 on each axis, the unit is g.

gyro gives back the rate from -32767 to 32767 on each axis, the unit is deg/s

compass gives back values from -4096 to 4095 on each axis, the unit is uT

gyro and compass do not work unless accelerometer is used, because Wire1.begin() is not called.

gyro and compass will be currently dropped.

Seems to work fine.


Add Visual Regression Testing

https://github.com/mojoaxel/awesome-regression-testing
Regression Testing is an underestimated topic. This list tries to give an overview about the topic.
By submitting this pull request I confirm I've read and complied with the below requirements.

[x] I have read and understood the contribution guidelines and the instructions for creating a list.
[x] This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

[x] Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
[x] Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

[x] Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
[x] It's the result of hard work and the best I could possibly produce.
[x] Non-generated Markdown file in a GitHub repo.
[x] Includes a succinct description of the project/theme at the top of the readme. (Example)
[x] The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
[x] Not a duplicate.
[x] Only has awesome items. Awesome lists are curations of the best, not everything.
[ ] Includes a project logo/illustration whenever possible.

Placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

[x] Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
[x] Has the Awesome badge on the right side of the list heading,
[x] Has a Table of Contents section.

[x] Should be named Contents, not Table of Contents.
[x] Should be the first section in the list.
[x] Should only have one level of sub-lists, preferably none.

[x] Has an appropriate license.

[x] That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
[x] If you use a license badge, it should be SVG, not PNG.

[x] Has contribution guidelines.

[x] The file should be named contributing.md. Casing is up to you.

[x] Has consistent formatting and proper spelling/grammar.

[x] Each link description starts with an uppercase character and ends with a period.Example: - [AVA](…) - JavaScript test runner.
[x] Drop all the A / An prefixes in the descriptions.
[x] Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

[x] Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

[ ] Go to the top and read it again.

If you need to have "visual" in parens, I think that's a good sign you should rename the list to "Visual Regression Testing".

Include a short description about the project/theme of the list. It should not describe the list itself.
Example: - Fish - User-friendly shell., not - Fish - Resources for Fish..

It should be about the topic, not just a repeat of the title.

Includes a succinct description of the project/theme at the top of the readme. (Example)

Not done.

Drop all the A / An prefixes in the descriptions.

Not done.

DalekJS - Not maintained any longer.

Don't include unmaintained stuff. It's supposed to be an awesome list.

All the items in the Online services section needs descriptions.

@sindresorhus OK, Done!

If you need to have "visual" in parens, I think that's a good sign you should rename the list to "Visual Regression Testing".

You need to update the title the readme addition here and the PR title.

General information on regression testing

Too long. "Regression testing" is implied.

Slideshows, Talks and Videos

Inconsistent casing with the rest.

Misc

Use the full word.

BackTrac - Cloud based visual regression tool. Uses headless firefox and proprietary comparison algorithm (detect layout shifts)

Missing a dot at the end here.

Slideshows, Talks and Videos

The items in this section needs descriptions. Could describe what the different tools are; Wraith, Shoov, PhantomCSS, ..

See the Awesome Regression Testing Contribution Guide

Too long. "Contribution guide" is enough.

helpfull

Typo

@mojoaxel ping

@sindresorhus pong

Slideshows, Talks and Videos
Inconsistent casing with the rest.

You also need to update the "Contents" entry.

You also need to update the "Contents" entry.

Great. Thanks for your patience.

Wow, you really spot every little detail! 🏅

Awesome lists should be awesome in every sense of the word.

I will tweet the list later this week from this account: https://twitter.com/awesome__re


Using an arrow function after the keyword return throws an error

I'm using react created from create-react-app and got an error if I write a function like this
const a=()=>{return b=()=>{}}
the error is

'b' is not defined  no-undef

but it'd be all fine if I rewrite like this
const a = () => {
  const b = () => {};
  return b;
}

or like this
const a = () => {
  return function b() {};
}

It is just an eslint error.
b is not defined in const a=()=>{return b=()=>{}}.  Your other examples, b is defined.
You don't need to assign b to () => {} before returning.  You can do just const a = () => { return () => {}}; or const a = () => () => {};.

Ok. I got it. Many thanks