Port MT support to upstream bdw-gc getstackbottom patch

Hello. It is very exciting to hear that 0.31.0 was released with multi-threading preview support.
But I failed to build with preview_mt flag on Arch Linux.
file: main.cr
def main
  channel = Channel(Int32).new(9)

  (1..10).each do |i|
    spawn do
      channel.send(i)
    end
  end

  result = [] of Int32
  9.times do
    result << channel.receive
  end

  puts result
end

main

It is OK to build without the preview_mt flag:
$ crystal build -o main main.cr
$ ./main
[1, 2, 3, 4, 5, 6, 7, 8, 9]

But failed to build with the preview_mt flag:
$ crystal build -Dpreview_mt -o main main.cr
/usr/bin/ld: G-C-.o: in function `set_stackbottom':
/usr/lib/crystal/gc/boehm.cr:202: undefined reference to `GC_set_stackbottom'
/usr/bin/ld: G-C-.o: in function `current_thread_stack_bottom':
/usr/lib/crystal/gc/boehm.cr:194: undefined reference to `GC_get_stackbottom'
collect2: error: ld returned 1 exit status
Error: execution of command failed with code: 1: `cc "${@}" -o '/home/kaizhao/lab/crystal/mt/main'  -rdynamic  -lpcre -lm -lgc -lpthread /usr/lib/crystal/ext/libcrystal.a -levent_pthreads -levent -lrt -ldl -L/usr/lib -L/usr/local/lib`

I have read the great article Parallelism in Crystal and I think the code should be valid. Please correct me if I made mistakes.
Just don't know or this is an issue caused by packaging in Arch Linux or crystal itself. So I create this issue.
The version of crystal which is installed via Arch Linux pacman package management tool:
$ crystal -v
Crystal 0.31.0 (2019-09-23)

LLVM: 8.0.1
Default target: x86_64-pc-linux-gnu

As this is the GC that is failing, it would have made sense to also include the version that is used there. In particular, the missing functions you are seeing comes from very recent versions of the boehm GC (that I think @bcardiff was part of developing, for this purpose).

Maybe the feature hasn't been in a release of libgc yet
https://forum.crystal-lang.org/t/bdwgc-upstream-support-for-green-threads-fibers/733
https://github.com/ivmai/bdwgc/releases
And maybe Crystal's official binaries are bundled with new libgc but Arch doesn't do that

This is likely a won't fix, but calling @anatol here as the package maintainer.

I think what @oprypin says is correct: we used a patched GC that hasn't been released. It's at least like that in the gc we use for homebrew, and I remember @bcardiff saying that for our supported linux distributions.

We use patch that is slightly different from the one merged upstream. We are expected to update it before the next bdw-gc release.
More info at: https://forum.crystal-lang.org/t/bdwgc-upstream-support-for-green-threads-fibers/733
The patch is also used in homebrew since we ended up maintaining that aswell.
Closing, there is no actionable on our side. But we can talk regarding what is the final decision regarding Arch support of preview_mt.

Thank you for the information folks. I am checking what need to be done at Arch side to fix the issue.
I applied https://github.com/ivmai/bdwgc/commit/5668de71107022a316ee967162bc16c10754b9ce mentioned above and some of the crystal compilation issues fixed. Now I see following linking problem:
$ crystal build -Dpreview_mt -o main main.cr
/usr/bin/ld: G-C-.o: in function `current_thread_stack_bottom':
/usr/lib/crystal/gc/boehm.cr:194: undefined reference to `GC_get_stackbottom'
collect2: error: ld returned 1 exit status
Error: execution of command failed with code: 1: `cc "${@}" -o '/home/anatol/tmp/crystal/main'  -rdynamic  -lpcre -lm -lgc -lpthread /usr/lib/crystal/ext/libcrystal.a -levent_pthreads -levent -lrt -ldl -L/usr/lib -L/usr/local/lib`

Is there a separate patch for GC_get_stackbottom function as well?

The patch you applied is what we will target latest after the next bdw-gc release, probably already with Crystal 0.32.
But it's a quite modified version of what we developed initially and target currently. Our original patch and what Crystal 0.31 targets is at https://github.com/crystal-lang/bdwgc/commit/4f0de8a45802a2ba18f664b385e82d1802cf423c

@jhass only if 0.32.0 is soon, otherwise there is a broken crystal package in arch main repo, preview_mt is a very substantial part of this release and people will 100% want to experiment

I really don't think pointing them to the AUR package is too much to ask. We could even patch Crystal to do a quick pacman -Qs on -Dpreview_mt and point people towards it if not installed.

@jhass I agree it would be really great to have -Dpreview_mt working out of the box at Arch Linux.
We can try to bring gc package updates to Arch with the upstream patch https://github.com/ivmai/bdwgc/commit/5668de71107022a316ee967162bc16c10754b9ce  but it is a big no in Arch to patch with non-upstream changes like https://github.com/crystal-lang/bdwgc/commit/4f0de8a45802a2ba18f664b385e82d1802cf423c
Is there any chance you can look at upstreaming https://github.com/crystal-lang/bdwgc/commit/4f0de8a45802a2ba18f664b385e82d1802cf423c? It would make pulling the required change to the official Arch package much more likely.

My vote goes towards 1) or 2). crystal should work with upstream-blessed gc tree.
At the end of the day this issue is not about Arch and we want to see a solution that works for all distros. It will help to avoid using custom patches everywhere. Instead we should use the upstream version of the packages.
Is there a chance you can provide a crystal patch to use https://github.com/ivmai/bdwgc/commit/5668de71107022a316ee967162bc16c10754b9ce that I test locally?

Updating to the upstream patch was expected to happen in the near future. I will let you know how it goes.

This issue needs to be open to track using the correct API.

Actually, my bad, the PR for crystal's support was merged before upstream merged the different API. You can probably ignore the rest of my rant :)

Thank you @RX14. Once you have a crystal patch ready I'll integrate it into the Arch package.

@anatol -> #8225

I have just checked the crystal package in both FreeBSD ports and MacPorts. They have the same issue though they have earlier versions of crystal packages e.g. 0.28.0 in FreeBSD ports, 0.30.1 in MacPorts now. Hope all these and others with the same issue but not mentioned can be fixed soon. Thank you very much! ❤

Arch binary package crystal-0.31.0-2 with the fixes from above just been pushed to [testing] repository. Please check the package and let me know if you see any issues.

@anatol , it builds and link, I don't see any issues while testing it locally.

sudo pacman -U gc-8.0.4-2-x86_64.pkg.tar.xz
sudo pacman -U crystal-0.31.0-2-x86_64.pkg.tar.xz
crystal eval -Dpreview_mt 'p 5'
Tried on a few programs too, seems to work.
For reference, how @anatol applied those patches in gc and crystal.

@anatol Thank you! After synchronizing and upgrading to the latest packages it works on Arch Linux now.
file: main.cr
def main
  channel = Channel(Int32).new(9)

  (1..10).each do |i|
    spawn do
      sleep 1
      channel.send(i)
    end
  end

  result = [] of Int32
  9.times do
    result << channel.receive
  end

  puts result
end

main

$ crystal build -D preview_mt -o main main.cr
$ ./main
[2, 10, 6, 1, 4, 9, 8, 5, 3]

Nice job! :rocket: :100:


Latency Issues in Jupyter Notebook

I am using this model in my jupyter notebook and while doing the translation in jupyter notebook latency (time to generate output) is very high as compare to the latency i get in "https://models.ai4bharat.org/#/nmt/v2" (approx. 2-3 sec) .
When i translate en = ['hi there, my name is x and i live in city y']
in jupyter notebook it takes 17.4sec and while in "https://models.ai4bharat.org/#/nmt/v2" it takes less than 2 sec
Can someone tell me how can i match latency in jupyter notebook

Hi,
i have customized the example.py file to example_1.py

Wait! Are you using a CPU for evaluation? If so, that may be the
reason. To my knowledge, we use GPUs for the website.
PS: Screenshots of code are really unhelpful. Please attach code from next time.
On Thu, Dec 7, 2023 at 12:28 PM Bhanu191 @.***> wrote:

Hi,
i have customized the example.py file to example_1.py
image.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

--
Raj Dabre.
Researcher at NICT, Japan.
Ph.D., Graduate School of Informatics, Kyoto University.
M.Tech., IIT Bombay.

Thank you ,
I was using cpu for evaluation, got comparable latency with gpu


updateRules nullable not working [bug]

hi @btrsco ,
my code :
 PasswordGenerator::make('Password')
                ->onlyOnForms()
                ->creationRules('required', Rules\Password::defaults())
                ->updateRules('nullable', Rules\Password::defaults()),

when i update the user, and leave blank on password field, PasswordGenerator always update the password field value.
i am using nova 4.

Thanks for the bug report,
@jodhaakbar when you update the user is this only visually updating in the PasswordGenerator field and/or saving a new value to the database? In the meantime I'll take a look and see if I can duplicate and fix this issue.

hi @btrsco
i checked on database, password field fill with new value, everytime update the nova form.

@jodhaakbar thanks for double checking for me, I'm working on fixing some old issues and I'll get to this one later tonight. I'll reach out once the package has been updated.

@jodhaakbar this bug has been fixed and also added a new chain method saveAsPlainText() that will disable the hashing of the field value when saving to the database. Enjoy the update!


Engagement Area template Error 500: Item does not have a file

The Engagement Area template at:
https://nsecmini07.esri.com/arcgis/home/item.html?id=189691eccf1b47a2afa220d02e7c0483
is shared with Everybody but not released yet.
When I click the download link for it I get:
Error
Item does not have a file.
Error: 500
I know it isn’t released, which might be why it didn’t get an item, but someone might want to use it.
My other item, the Control Measures LPKX downloads correctly.

@BobBooth It has a portal item; it just doesn't have the associated file. Does the associated item on the dev portal have the file?

@elinz  - yes, NSEC has an item for it.

@BobBooth Check with your product lead if this is really needed for UC. If not, change the milestone to version after next.

@elinz this is an issue for UC. All of the Pro project templates have this issue. There is no file associated with the time.

@conklinbd Roger that.

Added fix to https://github.com/elinz/ops-server-config/tree/v.next repo. Extract portal content from dev server and verified that .aptx files are being downloaded from "Project Template" items. Closing issue.


Named Variables?

Is there any way to name your SQL variables the same as the C# variable name instead of @p0, @p01?
I have a script I'm building up and even though i'm reusing the same variables in multiple parts of the script they appear in the outpoint as different prams, which is hard to verify later. i'm using approval tests to versify the script output.

@ryburn52 C# compiler doesn't provide the names of interpolated variables, so you'd have to provide them as format or wrap under an anonymous object or some other type. As reference check out how it was made in InterpolatedLogging - it extracts names from anonymous objects and also from this NamedProperty wrapper.
You'd have to make this change in InterpolatedStatementParser where you would capture the variable names and then you would have to modify ParameterInfos.Add to receive the variable name that you extracted in the parser. Last, you'd have to fix the MergeParameter methods to avoid name clashes.
I'm not sure if someone is already passing anonymous objects to the library (since Dapper accepts anonymous objects), in this case it could break something.
I don't think this is a priority for now, but I'll leave this ticket open for future TODO.

Thanks,
it would be neat to be able to define them in something like {name:UserName}. For now i noticed that the QueryBuilder has a Parameters prop. It looks like i can hard code the SQL variable name and add the value to the Parameters prop. This means when i check the Sql property the variable names will all match.
Something like this
var query = connection.QueryBuilder();
query.Parameters.Add(new ParameterInfo("asOfDate", context.AsOfDate, DbType.DateTime));

query.AppendLine($"Select * from Users Where ModifiedDate >= @asOfDate");

Approvals.Verify(query.Sql)

It might seem pointless but i'm having to generate the SQL template to use in the QueryBuilder. So i'm probably not using the builder to it's full potential.
I guess what it would look like is something like this
query.AppendLine(FormattableStringFactory.Create($"Select * from {nameof(Users)} Where {nameof(Users.ModifiedDate)} >= @asOfDate"));

DapperQueryBuilder is being deprecated and this repo will be archived soon. The replacement library is InterpolatedSql.Dapper. I'll move this issue to that new repo.


DxDateBox and use of globalize

Hello,
I want to use DxDateBox with a german date format DD.MM.YYYY set as displayformat.
As this didn't work out of box, I contacted DevExpress Support (we have a Universal Subscription).
They told me to include globalize.     https://github.com/jquery/globalize
At the end it is working, but I'm not sure if I did it the best way ...
I installed it via
npm install globalize cldr-data --save

Afterwards I changed the following files
Angular-cli-build.js
vendorNpmFiles: [
  (...)
  'devextreme/dist/js/dx.all.js',
  'devextreme/dist/css/*.css',
  'devextreme/dist/css/icons/*.*',
  'devextreme-angular2/**/*.+(js|js.map)'    ,
  'ng2-bootstrap/**/*',
  'moment/min/**',
  'globalize/dist/**',                <----
  'cldrjs/dist/**'                    <----
]

system-config.js
const map: any = {
    'devextreme-angular2': 'vendor/devextreme-angular2',
    moment: 'vendor/moment/min/moment.min.js',
    globalize: 'vendor/globalize/dist/globalize.js',     <----
    'symbol-observable': 'vendor/rxjs/node_modules/symbol-observable',
    'ng2-bootstrap': 'vendor/ng2-bootstrap',
};

/** User packages configuration. */
const packages: any = {
  'devextreme-angular2':        { main: 'index.js', defaultExtension: 'js' },
  'vendor/ng2-bootstrap': {        defaultExtension: 'js' },
  'symbol-observable': { main: 'index.js', defaultExtension: 'js' }
};

Then I added the following to my index.html
<script type="text/javascript" src="vendor/cldrjs/dist/cldr.js"></script>
<script type="text/javascript" src="vendor/cldrjs/dist/cldr/event.js"></script>
<script type="text/javascript" src="vendor/cldrjs/dist/cldr/supplemental.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize/number.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize/currency.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize/date.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize/message.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize/plural.js"></script>
<script type="text/javascript" src="vendor/globalize/dist/globalize/relative-time.js"></script>

Is there a better way of packaging?
at least the html looks ugly

Hi,
It looks like your question is related to issue #16. Once it is resolved, you'll be able to clear your index.html.

#16 is closed, can you provide a code example in the documentation please?

Globalize requires a specific webpack configuration. At the same time, Angular CLI uses webpack internally but doesn't allow  customizing its config file. We consider our new Intl integration to be a primary way of localizing your Angular 2 applications. If for some reason you want to use Globalize with webpack,, we have a sample, but it's not related to Angular CLI.


Feature request: Add support for 24hour instead of AM/PM

In Norway (and I'm guessing a lot of other countries) we dont really use AM/PM. Any chance you can add an option for 24 hour format in the picker?

I join the problem. Is there any way to use 24-hour time format?

In Norway (and I'm guessing a lot of other countries) we dont really use AM/PM. Any chance you can add an option for 24 hour format in the picker?

Hi! I dug around in the source code looking for templates. I found that you can enable the 24 hour format using a template! Use the function "renderHourSelect(true)". The "true" argument enables it.
My example:
templates: {
    container: `

        <%= renderHeader() %>
        <%= renderCalendar() %>
        <%= renderTimepicker() %>

`,
    timepicker: `

        <%= label %>
        <%= renderHourSelect(true) %>: // THIS
        <%= renderMinuteSelect() %>

    `
  },


Allow placeholders in samediff

Issue Description
From https://github.com/deeplearning4j/nd4j/issues/2094
We need placeholder variables in samediff in order
to allow "empty" variables to exist.
Basic idea:
Have a sentinel value that we track and use
for representing placeholder variables.
Please describe your issue, along with:

expected behavior
encountered behavior

Version Information
Please indicate relevant versions, including, if relevant:

Deeplearning4j version
platform information (OS, etc)
CUDA version, if used
NVIDIA driver version, if in use

Contributing
If you'd like to help us fix the issue by contributing some code, but would
like guidance or help in doing so, please mention it!

Done:  https://github.com/deeplearning4j/nd4j/pull/2226


kie-issues-3314: Add the missing extension information to the kogito-addons-quarkus-microprofile-config-service-catalog

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[X] You have read the contributors guide
[X] Your code is properly formatted according to this configuration
[X] Pull Request title is properly formatted: KOGITO-XYZ Subject
[X] Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
[X] Pull Request contains link to the JIRA issue
[X] Pull Request contains link to any dependent or related Pull Request
[X] Pull Request contains description of the issue
[X] Pull Request does not include fixes for issues other than the main ticket

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this

for a specific pull request check
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests

for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch

for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main

for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts

for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

for native checks
Run native checks
Please add comment: Jenkins run native

for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native

for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts

for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ?

The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.
The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:
jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

Hello @jstastny-cz , it looks like this PR is failing due to changes on the pipeline image. Could you please give a hand on this one?
https://ci-builds.apache.org/blue/rest/organizations/jenkins/pipelines/KIE/pipelines/kogito/pipelines/main/pipelines/pullrequest_jobs/pipelines/kogito-runtimes-pr/branches/PR-3315/runs/2/log/?start=0
$ docker top 34d6cd6d873191451a00503b4c3eac8d022adee953280a814c7d1fba29e7d5f6 -eo pid,comm
ERROR: The container started but didn't run the expected command. Please double check your ENTRYPOINT does execute the command passed as docker run argument, as required by official docker images (see https://github.com/docker-library/official-images#consistency for entrypoint consistency requirements).
Alternatively you can force image entrypoint to be disabled by adding option --entrypoint=''.

@wmedvede I am building a new version of the image which hopefully has this problem solved. I'll retrigger your check, once the image is published.


Remove environment variables to disable protocol detection

After a bit of testing, these flags do not actually work fully -
detection is still enabled. Since we have no testing, no proper API, not
documentation, and no known use cases, seems safe to remove these now.
Put a hold to ensure this gets at least a few approvals first

cc @lambdai @yxue

closing for now, will address in future


chore: block auth during public system tests

Yeah I have no clue what's happening here.  Those tests never pass for me locally, and I am thinking it has to do with my Cloud SDK config.  I am going to keep banging my head on this and trying things 🤷♂

@stephenplusplus @kinwa91 I am going to go ahead and land this for now, since it looks to fix the system tests.  I want to get the bucket lock PR landed here.


nodePackages: Handle change in prepublish semantics

See thread starting at (http://lists.science.uu.nl/pipermail/nix-dev/2013-December/012210.html) and isaacs/npm#3059

Closing this as a lot was changed in buildNodePackages in a meantime and also this was addressed. Also we have simple way to override packages.


Spawning in items fails when in a non-player inventory

When you spawn in an item using EMI while inside a non-player inventory (chest, dropper, etc.) the item vanishes when trying to place it into a slot.

This likely has something to do with creative mode, I'll look into it

Fixed in 1.0.0


[release-v1.10] Add eventshub service port name

Upgrade third_party to latest

/cc @ReToCode

=== CONT  TestKafkaSourceBinaryEvent
    logger.go:130: 2023-07-28T13:15:09.920Z	FATAL	eventshub/resources.go:90	pods "eventshub-sender-esltvpya" is forbidden: error looking up service account serverless-tests/serverless-tests: serviceaccount "serverless-tests" not found	{"test": "TestKafkaSourceBinaryEvent"}


Installing in chrome

If u want to install in chrome u must unpack the zip and select folder "dist", otherwise you will get a notification that "
The manifest file could not be loaded."

Just download from Releases.
https://github.com/Lumm1t/anti-testportal/releases


updated readme for binary bot on deriv

@farabi-deriv
Could you please update your branch to the latest master branch updates
It seems you don't have Vercel config so you don't have the test-link


Fix tests

Our tests are failing. I have found a few problems in the test suite against the development version of the Connexion's dependencies.
This PR does not add or remove any Connexion code. It is only related to the tests.
Changes proposed in this pull request:

Remove six package from the dev test suite (https://github.com/zalando/connexion/commit/7bbed5994c7a8b70f84f6d359a6f63a40e861288)
Use correct repository url of swagger_spec_validator (https://github.com/zalando/connexion/commit/cdaca78e9e273aed5d074bd61449253b25500f3e)
Swagger schema expects required to be true for path parameters (https://github.com/zalando/connexion/commit/c0fa8dd836828c225d07f0e4426916123eb487e2)

Coverage remained the same at 100.0% when pulling 7bbed5994c7a8b70f84f6d359a6f63a40e861288 on fix-tests into 8e10a77b1ac2414506ea8cc5f32d25bbf7239aa1 on master.

:+1:


mat: rename Symmetric method to SymmetricDim

Please take a look.
Closes #1532.

Codecov Report

Merging #1710 (fccf77e) into master (af39aeb) will decrease coverage by 0.08%.
The diff coverage is 60.41%.

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
- Coverage   73.26%   73.17%   -0.09%
==========================================
  Files         510      504       -6
  Lines       60132    59809     -323
==========================================
- Hits        44056    43768     -288
+ Misses      13584    13567      -17
+ Partials     2492     2474      -18

Impacted Files
Coverage Δ

mat/diagonal.go
75.20% <ø> (ø)

mat/symband.go
70.32% <ø> (ø)

optimize/cmaes.go
87.24% <0.00%> (ø)

optimize/functions/functions.go
41.66% <0.00%> (ø)

optimize/minimize.go
71.36% <0.00%> (ø)

stat/distmv/dirichlet.go
82.97% <0.00%> (ø)

stat/distmv/normal.go
56.02% <16.66%> (ø)

diff/fd/hessian.go
93.40% <50.00%> (ø)

stat/distmv/studentst.go
71.77% <50.00%> (ø)

stat/distmat/wishart.go
77.94% <75.00%> (ø)

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af39aeb...fccf77e. Read the comment docs.


More Info needed about permisson settings for data sources

There needs to be more information included about permisson settings for data sources. What level of access does a user need to be able to see the data in the app, to be able to push through edits, etc.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9d3b377-2f9f-67b0-4d7a-87776c96e2ea
Version Independent ID: 9ba08546-4f01-31ec-dc3f-faa1068525db
Content: Understand data sources for canvas apps - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/working-with-data-sources.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @gregli-msft
Microsoft Alias: gregli

Thanks for your comment, @bri-ne. This issue has been assigned to the doc author for review.


feat: use AssetFragment in queries

CYS-3301

Let's wait with this PR until we deploy graph-assessor to prod

We should be merging dev to main, not the feature branch to main

Not in this case. We wouldn't be able to bring in these changes from dev to main since the two branches have diverged. Until we are done with the Azure controls, this is the simplest approach. We discussed this through


[1pt] Create empty My profile - Setup (group task)

Create a route and a view component. Use <NavLink /> for the page navigation links and style active class to indicate which section/page the user is currently on (underline active navigation link).
This view should be empty - you will add content in separate tasks.

https://github.com/Dorcas126/space-travelers/pull/27


Is it really necessary tableName as non static method?

Good day everybody. In previous versions Yii AR::tableName() was a static method and it was conveniently. For example i using it for  some custom complex queries somewhere in console/cron tasks, as part of cache-key for save aggregate heavy data, in custom helpers etc. In current version we must pass ActiveRecordFactory/ActiveRecord for each same cases and create AR instance inside, but that instance may not be needed further or redundant refactor like SomeHelper::someStaticMethod(add ActiveRecordFactory/ActiveRecord there). So - is it really necessary do it as non static? This method just return name of table and I can't think of case where needed $this inside. Thanks

Returning the table name statically won't hurt, plus it's an immutable method.


LOW - Expense - Search results are categorised as Recent and All in report field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.42-1
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
Precondition:

User is an employee of Collect workspace
The Collect workspace has dropdown field set up in "Report and Invoice Fields" on Old Dot.

Go to workspace chat.
Create a request.
Go to expense report.
Click on the report field with the selection list set up from Old Dot
Select an item.
Click on the report field again.
Search for term that will return results in Recent and All sections.
8 .Repeat the search with category list.

Expected Result:
In Step 7, the results will not be categorised. Recent and All sections will not appear in the search results (behavior with category search in Step 8).
Actual Result:
In Step 7, the results are categorised as Recent and All sections.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/e7b86a0d-2f2d-4562-b39d-021c8a9dcda7

View all open jobs on GitHub

I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

This seems expected to me - the report field and categories are two different elements of the report/expense, so it wouldn't make sense to show recent report field items when searching for the category. Going to close this one out.

@bfitzexpensify My apologies for any confusion. We're currently showing the difference in behavior when searching for items in the report field vs the category. Reopening the issue for second chance to review.
Thanks

Thanks for the clarification @kbecciv!
@izarutskaya in your test set-up, are there categories that match the search term "a"? At 0:19, the same Recent / All itemisation is seen, and it only goes away when searching. For the Report Field search, there are a number of matching results, that are then categorised into Recent / All as expected.

discussing in this Slack thread

OK, adding this to #wave06 and prioritising as low for the moment

waiting for proposals

Proposal
Please re-state the problem that we are trying to solve in this issue.
The report field is still categorized when searching.
What is the root cause of that problem?
Currently, we always return the report field as categorized in all cases.
https://github.com/Expensify/App/blob/cfa0ae37156208ebecdc6b2126464ec462271b76/src/pages/EditReportFieldDropdownPage.tsx#L48-L73
What changes do you think we should make in order to solve the problem?

Check if there is a searchValue, filter all field items, and return it in one section only without a title. Otherwise, return it as categorized as below:
if (searchValue) {
    const filteredOptions = fieldOptions.filter((option) => option.toLowerCase().includes(searchValue.toLowerCase()));
    setHeaderMessage(!filteredOptions.length ? translate('common.noResultsFound') : '');
    return [{
        title: '',
        shouldShow: filteredOptions.length > 0,
        data: filteredOptions.map((option) => ({...})),
    }]
}

const restOfOptions = fieldOptions.filter((option) => !recentlyUsedOptions.includes(option));
setHeaderMessage(!restOfOptions.length && !recentlyUsedOptions.length ? translate('common.noResultsFound') : '');
return [
    {
        title: translate('common.recents'),
        shouldShow: recentlyUsedOptions.length > 0,
        data: recentlyUsedOptions.map((option) => ({...})),
    },
    {
        title: translate('common.all'),
        shouldShow: restOfOptions.length > 0,
        data: restOfOptions.map((option) => ({...})),
    },
];

@bernhardoj 's proposal looks good to me.
🎀👀🎀 C+ reviewed

little bump @MonilBhavsar for final review 👀

Looks good to me too! 👍

PR is ready
cc: @hungvu193

I think payment is due for this issue @bfitzexpensify

Thanks for the bump @hungvu193! Seems the automation didn't work. All paid out.


New updates from MQTT 2.0 break the code

Problem:
In the file mqtt_paho.py
when creating a client
self.client = mqtt.Client()

the new mqtt 2.0 version will give a error.
Fix:
from paho.mqtt.enums import CallbackAPIVersion
self.client = mqtt.Client(callback_api_version = CallbackAPIVersion.VERSION1)

Thanks for identifying this! For the time being, I'm going to release a new version that limits the mqtt paho version to be lower than 2.0, so that we first fix existing installs with minimum breaking changes. Afterwards, I will prepare a PR that adds your fix, or ideally try to update to callback version 2.0 directly!

Addressed this temporarily in v0.3.5: https://github.com/compas-dev/compas_eve/releases/tag/v0.3.5


Training Time

Dear Authors,
How long does your method need to train?

It depends. In our experiments (except for vEMDiffuse-a), the diffusion model is unlikely to overfit. So you can train for a longer time (e.g, 1000-2000 epochs).


Build and publish ChoreoLib artifacts from CI

We may still manually push artifacts to the ChoreoLib repo, but we need CI to build C++ artifacts for all supported platforms.

The Actions yml in https://github.com/wpilibsuite/vendor-template/ could be used with names and paths updated.


RFC: Stop using std::net types (TcpStream / UdpSocket)

I'm considering moving away from using std::net types in favor of re-implementing them in Mio. Mio started off using this strategy, then attempted to use std::net types when available. Mio introduced NonBlock<_> in order to differentiate between blocking std sockets and non-blocking std sockets.
I am considering going back to the original strategy in order to achieve a few things.
First, I would like to get mio working on stable. Unfortunately, Error::from_os_error is not stable, which means that it is impossible to create an error value without allocating. This makes me wary of relying on std::net types in the future to be able to support the features that mio wants to.
Second, I have put a lot more though into windows support. My opinions re: windows support have changed over time. I thought that it would be best to leave windows support to a different library, however, I started writing this library and spent a lot of time with the windows IOCP APIs and I believe that it would be possible to support windows equivalently with some minor API tweaks (backwards compatible). However, to do this, all the network types would need to be implemented in mio.
Also, if mio owns all the types, there wouldn't be much use to have NonBlock<_> anymore since all the types in mio could be non-blocking by default, but this is an optional change.
So, the strategy would be:

Move TcpStream & TcpListener into mio
Stop using std::io::Error in favor of mio::Error
Stop using <NonBlock<_>> (optional)

You forgot UdpSocket in your strategy.
Do you think that the Error::from_os_error issue is something that should be discussed upstream? Surely mio will not be the only library with this concern.

@Hoverbear I have mentioned it and I believe they will stabilize it, but not until 1.0 Final would be my guess. If std::io::Error was the only issue, it wouldn't be worth changing anything. However, this change would be required to get Mio running on windows. So, I was hoping to postpone the change, but the std::io::Error issue is bringing it up now.

I would rather stay on nightlies and use the std types with unstable APIs, if that's possible. I don't think it's actually crucial we get this building on stable rust at 1.0, since it is in a highly experimental area of rust development.

Using nightlies after 1.0 would greatly limit mio's audience.

I like the idea of one library that support the same platforms rust itself supports over using the std types.

I'm in favor of this; at the moment lack of Windows support is the only thing keeping me from using mio for a handful of side projects. It would be great to have platform parity with rustc.

We are using mio in a couple of projects. All of them will stay on nightlies after 1.0, at least until compiler plugins are stable. Windows support is not important for us, but I guess it would be nice to have for some people.  (without additional overhead for *nix part).
But there are some things that I would prefer be different. After last mio reform my colleagues asked me a lot of questions about code like this
match sock.read_slice(...) {
                Ok(Some(n)) => { .. },
                Ok(None) => { .. },
                Err(e) => { .. },
            }

It's very confusing and non intuitive. I believe Option is not ideal way of communicating WouldBlock.
Smth like this would be great.
match sock.read_slice(...) {
                Ok(n) => { .. },
                Err(Mio::WouldBlock) => { .. },
                Err(Mio::Eof) => { .. },
                Err(e) => { .. },
            }

Explicit eof instead of n == 0 would be great too.
With Result<_, mio::Error> it will be possible again.

@rozaliev I thought a bunch about how to communicate WouldBlock, and IMO the issue is that, when working with non-blocking sockets, a WouldBlock case is not actually an error. The reason this matters is, if using try!(sock.read_slice(...)), a WouldBlock would  end up returning early from the function.
If all mio sockets are assumed to be non-blocking, NonBlock could be repurposed as it was in 0.2:
match sock.read_slice(...) {
    Ok(NonBlocK::Ready(n)) => { .. },
    Ok(NonBlock::WouldBlock) => { .. },
    Err(e) => { .. },
}

I personally would prefer if we reused Option, as it reduces imports and is more compatible with other code that already operators on Option values.

I think I also personally prefer the Option signature, but it is open for discussion :)
Anyway, got Mio running on Rust 1.0 beta w/o these changes, so there isn't a huge rush now. I think version 0.4.0 will target windows support, which will require some of what I proposed initially. I'll try to post a more in depth windows support plan when I have a moment.

Out of interest, what would TcpStream and friends look like if they were moved into mio? Would it still be possible to read/write to them in a synchronous fashion if needed?

The versions in mio would probably be hard coded to be non-blocking. However, there could be conversions between mio::TcpStream and std::net::TcpStream and the mio EventLoop could support registering std::net::TcpStream (and others), but only on posix systems.

Would this affect Mio's ability to interoperate with openssl crate's SslStream<S> for example?  Actually, is that even possible today for Mio to event on an SslStream type?

@jnicholls It shouldn't make it harder. I believe it would be possible for Mio to work w/ a non-block SSL stream type. We could discuss it further on the #mio IRC channel.

I'm going to close this in favor of #155. Trying to keep things clean...


Pull sanitize crate out of solana-program

Problem
The Sanitize trait is a de facto internal trait that doesn't belong in solana-program, and it makes it harder to move a bunch of other things out of solana-program
Summary of Changes
Move sanitize.rs into a new solana-sanitize crate.

Added, will remove myself as owner once anza-team accepts the ownership invite https://crates.io/crates/solana-sanitize/

@yihau can you accept the crate ownership transfer?


Get error code: 303 with a large rule set

Hi,
First, thanks for sharing this project.
I first come across this project when I was trying to find a js implementation of  forward-chaining rules engine. I really liked it. It is really fast, and it has a very straightforward api.
I used this engine in my project. It worked great when the rule set is relatively small. After I added about 500 rules, it started to fail. There is no output from the engine.
After some digging, I further narrowed it down. With 483 rules, it started to get error code: 303.
With 482 rules, it worked just fine.
/home/van/.nvm/versions/node/v12.11.1/bin/node /home/van/Documents/test/test.js
/home/van/Documents/test/node_modules/durable/libjs/durableEngine.js:305
            return handleResult(r.assertFact(handle, json), json);
                                  ^

Error: Could not assert events, error code: 303
    at that.assertFact (/home/van/Documents/test/node_modules/durable/libjs/durableEngine.js:305:35)
    at handleFunction (/home/van/Documents/test/node_modules/durable/libjs/durableEngine.js:901:33)
    at Object.that.assert (/home/van/Documents/test/node_modules/durable/libjs/durableEngine.js:938:20)
    at Object.assert (/home/van/Documents/test/node_modules/durable/libjs/durable.js:1923:26)
    at Object.<anonymous> (/home/van/Documents/test/test.js:4457:3)
    at Module._compile (internal/modules/cjs/loader.js:945:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:962:10)
    at Module.load (internal/modules/cjs/loader.js:798:32)
    at Function.Module._load (internal/modules/cjs/loader.js:711:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:1014:10)

Process finished with exit code 1

From the source code, the 303 is defined in rules.h as follows:
#define ERR_MAX_STACK_SIZE 303
My knee-jerk reaction is to increase the MAX_STACK_SIZE as defined in events.c. But I still got the same error code.
Further investigation showed that the error code is returned by handleAlpha() defined in events.c.
Specifically, at line 1697:
                            if (match) {
                                if (top == MAX_STACK_SIZE) {
                                    return ERR_MAX_STACK_SIZE;
                                }

Looking back the outer loop at 1671, since increasing the MAX_STACK_SIZE did not help.:
                for (entry = currentProperty->hash & HASH_MASK; nextHashset[entry] != 0; entry = (entry + 1) % NEXT_BUCKET_LENGTH) {
With some additional debugging on the looping variable "entry", it shows that it actually reached the limit of NEXT_BUCKET_LENGTH (current defined as 512 in rules.h) and actually started to roll back. Looks like NEXT_BUCKET_LENGTH is the real limiting factor in this case.
In my project, the total number of rules is projected to be around 1000 to 2000. I am not sure if we should linearly increase NEXT_BUCKET_LENGTH. But for the moment, I increased the NEXT_BUCKET_LENGTH to 2048.
After the change, the engine works for my test case, which is attached here (the file name will need to be changed).
test.js.txt
My question is how many rules can the engine handle with default settings?
What are the implications in increasing NEXT_BUCKET_LENGTH?
Can we increase the NEXT_BUCKET_LENGTH or related settings so the engine can handle more rules? In this way, I don't have to have my custom fork.
Thanks again. It is an amazing project.
jiqi

Hi, thanks for asking the question. The max number of rules under a single ruleset is limited to MAX_BUCKET_LENGTH (512 right now). Increasing the MAX_BUCKET_LENGTH size means increasing the size of the trie for Alpha nodes. I need to run the benchmarks to get a better understanding of the impact on rules evaluation performance and memory footprint. I will post back on this issue with my findings.


Thread 1: "-[_NSCopyOnWriteCalendarWrapper fs_firstDayOfMonth:]: unrecognized selector sent to instance 0x281cd4200"

The following informations are requested in a bug report

A brief bug description.
When initialize the calendar with binding in swiftUI, app crashed
Stack trace.
Exception	NSException *	"-[_NSCopyOnWriteCalendarWrapper fs_firstDayOfMonth:]: unrecognized selector sent to instance 0x281cd4200"	0x000000028118db30
Integration method.(manually/cocoapods/carthage)
manually (tuist)
Full steps to reproduce.
initializing calendar with Binding variable
Device modal and iOS version.
all iOS 16 Devices
Xcode version.
Xcode 14.2
FSCalendar version. on Master branch

i got same issue any solution?

i got solution.
You got to import it as dynamic framework, you might do as a static framework


Fix a small typo in the short name of the extension

There is a small typo in the short name.

@llange Thank you


Added Supervisor and SupervisedWorker structure/interface

The Supervisor launches Actors, and makes it easy to communicate between them using the Message type.
supervisor_test.go shows a sample implementation:
The main areas of interest are:

Defining a new SupervisedWorker:

type newWorker struct {
	SupervisedWorker
	ID string
	... // any other fields you want to add on
}

Sending a message from a worker of type newWorker:

worker.Outbox <- Message{
	From:    tw.ID,
	To:      "worker2", // This can be grabbed from a constants file instead
	Type:    0,
	Content: "Hello from worker1",
}

Waiting to receive a message:

for msg := range worker.Inbox {
	switch msg.Type {
	... // Based on message type, can JSON unmarshal the contents into expected structure
}

Hey @vladopajic ! I've made this PR if you have a chance to take a look. Happy to chat on it


Add BR as default in billing address

Coverage increased (+0.006%) to 80.984% when pulling<PHONE_NUMBER>767dea977f8a9606176d9d4e197cdf on add/br-in-billing-info into 86a912b8c257ba2d21413364d7756a15d4ab68aa on master.


C++/WinRT sample code

Would be nice if all the pieces of sample code changed to C++/WinRT when I select that in the language dropdown.
Currently all the samples remain in C#.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4709c156-9a4d-80f0-4465-8061636a018d
Version Independent ID: 30f6eda3-e38a-628d-e1ac-995879b33019
Content: TextBox Class (Windows.UI.Xaml.Controls) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.UI.Xaml.Controls/TextBox.xml
Product: uwp
Technology: winui
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Hi, @fman028, and thanks for filing this issue. You're right that choosing C++/WinRT from the filter works only if there actually are C++/WinRT versions of the code in the content. What I've tried to do is, whenever there was C++/CX but not C++/WinRT, to add a C++/WinRT version. We haven't yet gotten around to adding C++/WinRT where there was (for example) only C#, but we are aware that that's the situation for a lot of topics. It's on our radar.
Thanks!
Steve

Makes sense.  Thanks for following up!
On Tue, Apr 28, 2020 at 1:57 PM Steven White<EMAIL_ADDRESS>wrote:

Closed #1623 https://github.com/MicrosoftDocs/winrt-api/issues/1623.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/winrt-api/issues/1623#event-3282103152,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARWXYUNLPBRL6CMKHTE42TRO47LTANCNFSM4MQKX5QQ
.


Azure Meetup Torino

Adding files for Azure Meetup Torino

How is it going @alberto-annunziata90 ?

I've done it. Thanks

How is it going @alberto-annunziata90 ?

I add it. Let me know. Thank you for support.

Hello there @alberto-annunziata90. I am missing the index.dm file in this PR! Would you please add one and update the PR!

I've done it.

Looks good to me! Merging!


New IDE for GVim

Hello community,
I have build an IDE for Gvim to make it more mouse friendly. It is similar in features as Atom. Please let me know how to include it as a plugin with next Gvim release. Also report any changes fixes would make it more new user friendly.
Here is the repo to the new IDE plugin: https://github.com/pullelikunju/ide
Pulleli

I looked around quite a bit before resolute to build a new one as I couldn't find any decent one that is complete and frontally to new users of Gvim. This is designed ground up for Gvim and does not interfere with existing keybindings or other features. It would also showcase the capabilities of Gvim and help more use to adapt to vim ecosystem as a whole.
Pulleli

There exist a log of Vim distributions like janus, spf-13, spacevim, (some of those are already obsolete) etc.
You seem to have collected a list of plugins to make a prettier vim, but honestly,  I don't think it makes sense to include this and none of the others.


Quill Editor Disappears when i use Wire Navigate in Livewire V3

Quill Editor Disappears when i use Wire Navigate in Livewire V3

would u put the code so then we can have a better understanding about your problem @victorycodedev


Separate context for keyboard navigation in folder

Currently when you're using the folder it'll cycle out of the folder and your keyboard control dissapears. It should only cycle through the folder contents when it's open, and never when it's closed

Fixed in c4d7660e42cebd589021df8f06d5f689e32b5769


History sorts by oldest first

I think it should sort by newest first instead, so that you don't have to go to the last page in order to see recent changes.

Fixed in referenced commit


Add support to :not selector

Now :not and others css functions works as css rules in the styled.global extension
closes #130

I believe not only in globals, and works in any nested CSS within styled.div as well.
Good job @joseemds


Keyboard strokes should be formatted appropriately

You can format keyboard strokes like so:
DEL
This should be added to the documentation.
This was discussed here.

github supports F1
would this also work with readthedocs markdown?
https://meta.askubuntu.com/questions/707/how-to-use-keyboard-icon-in-markdown

https://discord.com/channels/832282841836159006/969233556788359228/976884979692867594

https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-kbd

https://discord.com/channels/832282841836159006/969233556788359228/976885375463194634

[ ] Update contributing guidelines.

I'm pretty sure that readthedocs will render this correctly. We can check.


Cursor-based paging WIP.

This is just a WIP so we can discuss the changes I'm making informally with a nice diff.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: benmccallum sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@divega to follow up.

I'd love some advice on whether the approach I'm taking is actually the correct one; see the issue for my latest comment on what I've done so far. Thanks team!

@benmccallum - Looking at PR, I would suggest holding off for now. I see that you have added new Queryable operator for Take(Before/After)Match and plumbed it through Relinq parser though there is no translation further. In 3.0, we are going away from Relinq QueryModel hence some of it would be unnecessary and translation would be directly from expression tree. The new pipeline without QM is being worked in #14455. In few weeks it should be ready to be merged and then we can add new features to query.

Awesome, thx for the heads up @smitpatel. Will hold off a bit longer!

Closing as per above.


Document steps to claim a The Things Indoor Gateway via CLI

Summary
Currently, claiming of The Things Indoor Gateway(TTIG) via CLI is not documented.
Why do we need this?
Users can able to claim the TTIG via CLI.
What is already there? What do you see now?
The current documentation consists of claiming TTIG via the Console. Ref: https://www.thethingsindustries.com/docs/gateways/thethingsindoorgateway/
What is missing? What do you want to see?
Steps to claim a TTIG via CLI.
How do you propose to document this?
...
Can you do this yourself and submit a Pull Request?
No. @benolayinka

@KrishnaIyer can you pick this up, or comment here with steps I can document?

I can take this issue.


Allow $select to catch and use string syntax

mongoose allows a string to be passed to the .select() function ie. select('+someExtraField').
Using this syntax allows you to keep all existing fields selected, but select additional fields you might have hidden in your schema by using select: false as a "column/field" option. It's also a more succinct and flexible way of passing the select information IMHO.
I hope that this change will allow the other forms to be used, but allow this use case.
I still need to check/write tests and clean up the code a bit, but getting this out early for concerns/comment.

ok, i've added test for $select on strings, arrays and objects. Works for me! thanks so much for you time and this wonderful codebase!

Can you try this with your tests?
if (filters.$select) {
  // $select uses a specific find syntax, so it has to come first.
  if (typeof filters.$select === 'string' || typeof filters.$select === 'object') {
    q.select(filters.$select);
  } else if (Array.isArray(filters.$select)) {
    let fields = {};

    for (let key of filters.$select) {
      fields[key] = 1;
    }

    q.select(fields);
  }
}

Actually, I don't think the outer if is even needed:
// $select uses a specific find syntax, so it has to come first.
if (typeof filters.$select === 'string' || typeof filters.$select === 'object') {
  q.select(filters.$select);
} else if (Array.isArray(filters.$select)) {
  let fields = {};

  for (let key of filters.$select) {
    fields[key] = 1;
  }

  q.select(fields);
}

@marshallswain I've updated the logic to simplify it, take a look when you have a chance, thanks!
Close to what you had suggested, but I found the array needs to be checked first because an array is an object.

Looks good to me.

Nice, I didn't know this was possible. Released as v3.6.2. Thanks @jamesjnadeau!


Updating test runner breaks tests

Please verify the version of auro-input you have installed
@latest
Please describe the bug
When updating @web/test-runner devDep  0.16.1  ❯  0.18.0
test/auro-input.test.js:

 🚧 Browser logs:
      Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.
      Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
      Element auro-input scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.

 ❌ auro-input > clears the value when clicked
      AssertionError: expected undefined to equal ''
        at Ka.<anonymous> (test/auro-input.test.js:64:25)

Reproducing the error on the docsite
This issue cannot be reproduced on the Auro docsite
Expected behavior
All tests should not fail with updated version of test runners.
What browsers are you seeing the problem on?
No response
Additional context
I feel like this is the root of this very related issue

https://github.com/AlaskaAirlines/auro-datepicker/issues/183

need to verify if this is still an issue in the beta branch, as well as potentially in other repos.

No longer an issue, as confirmed by @jordanjones243


Livebox V4 PRO integration doesnt work

Hello,
i have been so happy to see an integration for the Livebox lol but sadly...it doent work on my Livebox V4 PRO : when i 've been prompt to enter information like IP, Port, username and password, i type the password and i have a "Unknown linking error occurred".
Any idea?
Thanks
Olivier

please check again ?

sorry,  it doesnt work..."unknow error" no change
Le jeu. 30 avr. 2020 à 21:06, Save me<EMAIL_ADDRESS>a écrit :

please check again ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Cyr-ius/hass-livebox-component/issues/5#issuecomment-621982988,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL4SIWIHUXQ6T3VZXZPSWFDRPGV2RANCNFSM4K3PZSGQ
.


on npm.com version 2.2 is missing some files compared to previous vcer

https://www.npmjs.com/package/vue-focus-visible/v/2.1.0        Total 10 files
https://www.npmjs.com/package/vue-focus-visible/v/2.2.0        Total  3 Files

Hi @kennethh72
I fixed this in v2.3.0. Have a great day :)


Key handling

add functions to handle keydowns

handleEnter check if current row has all contents filled if so move to next row
handleBackspace undo default and delete current input then focus on previous input if existent
handle Letter check if key is a letter and add to current input then focus on next input if existent

resolves #13 #11 #14


Mouse wheel scroll too fast

Version:
webview_windows: 0.4.0 (also occur in 0.1.8)

Code to reproduce:
import 'package:flutter/material.dart';
import 'package:memodu/modules/reader/webview_windows.dart';
import 'package:webview_windows/webview_windows.dart';

class TestWebView extends StatefulWidget {
  const TestWebView({Key? key}) : super(key: key);

  @override
  State<TestWebView> createState() => _TestWebViewState();
}

class _TestWebViewState extends State<TestWebView> {
  final controller = WebviewController();

  @override
  void setState(fn) {
    if (mounted) super.setState(fn);
  }

  @override
  void dispose() {
    controller.dispose();

    super.dispose();
  }

  @override
  void initState() {
    super.initState();

    WidgetsBinding.instance.addPostFrameCallback((_) async {
      if (mounted) {
        await initPlatformState();
      }
    });
  }

  Future<void> initPlatformState() async {
    await controller.initialize();

    await controller.loadUrl('https://flutter.dev');

    setState(() {});
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(),
      body: Webview(
        controller,
        permissionRequested: _onPermissionRequested,
      ),
    );
  }

  Future<WebviewPermissionDecision> _onPermissionRequested(
      String url, WebviewPermissionKind kind, bool isUserInitiated) async {
    final decision = await showDialog<WebviewPermissionDecision>(
      context: navigatorKey.currentContext!,
      builder: (BuildContext context) => AlertDialog(
        title: const Text('WebView permission requested'),
        content: Text('WebView has requested permission \'$kind\''),
        actions: <Widget>[
          TextButton(
            onPressed: () =>
                Navigator.pop(context, WebviewPermissionDecision.deny),
            child: const Text('Deny'),
          ),
          TextButton(
            onPressed: () =>
                Navigator.pop(context, WebviewPermissionDecision.allow),
            child: const Text('Allow'),
          ),
        ],
      ),
    );

    return decision ?? WebviewPermissionDecision.none;
  }
}

Flutter doctor -v:
 History restored

[√] Flutter (Channel stable, 3.19.2, on Microsoft Windows [versÆo 10.0.19045.4170], locale pt-BR)
    • Flutter version 3.19.2 on channel stable at C:\Users\dev\.puro\envs\v3192\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (7 weeks ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at C:\Users\dev\AppData\Local\Android\Sdk
    • Platform android-34, build-tools 33.0.1
    • ANDROID_HOME = C:\Users\dev\AppData\Local\Android\Sdk
    • ANDROID_SDK_ROOT = C:\Users\dev\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.4.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.4.33110.190
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code (version 1.88.0)
    • VS Code at C:\Users\dev\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.86.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [versÆo 10.0.19045.4170]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 123.0.6312.107
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 123.0.2420.97

[√] Network resources
    • All expected network resources are available.

• No issues found!

@jnschulze
Change this from 6 to 1 solve the problem on my tests
Maybe in the newer version of flutter the delta already passed as full value, no need to convert ...
But I'm afraid it might stop something else.
Can you check please?

@jnschulze
Change this from 6 to 1 solve the problem on my tests
Maybe in the newer version of flutter the delta already passed as full value, no need to convert ...

I've reduced the scroll multiplier to 1.5 for now (see #314) as 1.0 was too low for me. Looks like it still needs to be calculated so this is just an approximation for now.


Support for Python 3.6

Python 3.6 was released in December 2016. I don't think it should be too difficult to add support (if anything is needed). Add to Travis?
This may be something we need to add support for:
https://docs.python.org/3.6/whatsnew/3.6.html#pep-519-adding-a-file-system-path-protocol

@snorfalorpagus I opened https://github.com/Toblerity/Fiona/pull/405 a few weeks ago and forgot about it.  The Windows build is broken, but hasn't that been the case for a while?

I didn't see the PR before creating this issue. Yes, it looks like Travis is OK on 3.6 but the Windows build is failing (it's testing 3.4 anyway). I'm not sure why without looking into it further. The existing problem should probably be fixed first. I've created #414.

@snorfalorpagus Ah right.  I think I tried upgrading Windows to 3.6 as well and when it failed I reverted.  👍 to the issue tracking Windows failures.


Fixes 151 - Set bower dependencies

Move dependencies that are required by consumers from
devDependencies to dependencies in bower.json.

LGTM


decoded_frame = self.shared_frames.get_decoded_frame_rgb(current_frame)
  File "/src/viseron/domains/camera/shared_frames.py", line 101, in get_decoded_frame_rgb
    return self._color_convert(shared_frame, COLOR_MODEL_RGB)
  File "/src/viseron/domains/camera/shared_frames.py", line 91, in _color_convert
    decoded_frame = self.get_decoded_frame(shared_frame).copy()
  File "/src/viseron/domains/camera/shared_frames.py", line 81, in get_decoded_frame
    return self._frames[shared_frame.name]
KeyError: UUID('1ff83594-8cd2-4c74-920d-da8f2c7eb6d8')
[2024-03-31 15:03:32] [ERROR   ] [tornado.access] - 500 GET /api/v1/camera/frontdoor/snapshot?rand=4bs1h&width=466&access_token=d5f69fff7e47e10c1e3b331739cb8e5f8397c181e89f95aa10f40f794e35de8fe08da5955269e7a9351d4e7b0a53ac1851882b23645414742652a2849fb13e3e (<IP_ADDRESS>) 3.75ms
[2024-03-31 15:03:42] [ERROR   ] [viseron.components.webserver.api.handlers] - Error in API CameraAPIHandler.get_snapshot: UUID('1ff83594-8cd2-4c74-920d-da8f2c7eb6d8')
Traceback (most recent call last):
  File "/src/viseron/components/webserver/api/handlers.py", line 290, in route_request
    getattr(self, route["method"])(*path_args, **path_kwargs)
  File "/src/viseron/components/webserver/api/v1/camera.py", line 141, in get_snapshot
    jpg = self._snapshot_from_memory(camera)
  File "/src/viseron/components/webserver/api/v1/camera.py", line 117, in _snapshot_from_memory
    ret, jpg = camera.get_snapshot(
  File "/src/viseron/domains/camera/__init__.py", line 474, in get_snapshot
    decoded_frame = self.shared_frames.get_decoded_frame_rgb(current_frame)
  File "/src/viseron/domains/camera/shared_frames.py", line 101, in get_decoded_frame_rgb
    return self._color_convert(shared_frame, COLOR_MODEL_RGB)
  File "/src/viseron/domains/camera/shared_frames.py", line 91, in _color_convert
    decoded_frame = self.get_decoded_frame(shared_frame).copy()
  File "/src/viseron/domains/camera/shared_frames.py", line 81, in get_decoded_frame
    return self._frames[shared_frame.name]
KeyError: UUID('1ff83594-8cd2-4c74-920d-da8f2c7eb6d8')

Could you enable debug logging?
logger:
  default_level: debug

Found a similar issue in this thread, could be something wrong with the cameras audio stream?
Can you try to disable sound (if it has any) and see if that works?
https://github.com/seydx/homebridge-camera-ui/issues/159


I am not able to use this package in axios

This is my code in main.js file:
import { createApp } from 'vue'
import App from './App.vue'
import router from './router/web-api'
import axios from 'axios'
import VueAxios from 'vue-axios'
import Pagination from 'v-pagination-3';
import VueProgressBar from "@aacassandra/vue3-progressbar";

const options = {
    color: "#bffaf3",
    failedColor: "red",
    thickness: "5px",
    transition: {
        speed: "0.2s",
        opacity: "0.6s",
        termination: 300,
    },
    autoRevert: true,
    location: "top",
    inverse: false,
};

const app = createApp(App)
app.use(VueProgressBar, options)
app.use(router)
app.use(VueProgressBar, {
    color: 'rgb(143, 255, 199)',
    failedColor: 'red',
    height: '2px'
})
axios.defaults.baseURL = 'http://localhost/my-project/laravue';

axios.interceptors.request.use((config) => {
    this.$Progress.start(); // for every request start the progress
    return config;
});

axios.interceptors.response.use((response) => {
    this.$Progress.finish(); // finish when a response is received
    return response;
});

It produce an error TypeError: Cannot read property '$Progress' of undefined     at eval (main.js?56d7:81)

If you're on Vue 3, use app.config.globalProperties.$Progress.start() instead of this.$Progress.start(). The same applies for finish.

like @LeCodeCo said, you can try with using app.config.globalProperties.$Progress.start()

Yes. It's working with this way. Thanks

nice 🎉


Bugfix/256 latest not returning true latest

Related Issues:

EQ-267

Main Changes:

Fixed a bug where filters could cause the incorrect reporting cycle to be chosen for the latest query.

This was mainly done by removing filters from the sub query, but also by updating the reporting cycle materialized views to also have organization id, region, and state.
As an optimization, I did allow the sub query to be filtered by the region, state, and organizationId filters.

Added code to prevent the reporting cycle filter from using the latest sub query if the user selected something other than latest for the reporting cycle.

Before we were doing something like the following if a user selected 2020 for the reporting cycle: SELECT * FROM <profile> WHERE (organizationid, reportingcycle) IN (SELECT organizationid, max(reportingcycle) FROM <profile> WHERE reportingcycle='2020' GROUP BY organizationid.
Now we do the following: SELECT * FROM <profile> WHERE reportingcycle = '2020'

Updated the Reporting Cycle field to be filtered by region, state, and organization id.

Steps To Test:

Verify envs are pointing to local database
Run the etl
Start the app
Verify the latest reporting cycle filter works as expected

A helpful way to check this is to add console.log('query: ', query.toString()); after line 341 in the app/server/app/routes/attains.js file

Verify selecting a reporting cycle year as the filter works as expected
Verify that selecting a region, state, and or organization id filters the reporting cycle options

Good catch! We definitely don't want to add anymore items to the subquerie's where clause than what the createLatestSubquery function does.

It should be fixed now.


Problems with wheat and sugar cane counting

I have a problem with the payment for plant harvesting (wheat, sugar cane and some tree logs)
Sometimes players who have a farmer or woodcutter profession receive payment for only 1-2 actions, while they perform hundreds of them.
The problem is not manifested regularly and I no longer understand what is wrong.
Already disable the schedule of bonuses and all quests, wheat and sugar cane was excluded from restrictedBlocks, restart the plugin and server, but the problem does not disappear.
By the way, more of other blocks like potatoes-7 works good.

Config:
https://pastebin.com/XLV55r9a
Farmer job:
https://pastebin.com/9JRXnXVk
Woodcutter job:
https://pastebin.com/zq0AZttH

Jobs version: <IP_ADDRESS> (<IP_ADDRESS> was also tested - problem does not disappear)
Server Type (Spigot/Paper/etc): Paper
Server Version (using /ver): 1.18.2
Relevant plugins (Delete if this isn't needed): Valut, xconomy

I've tried with wheat and that was counted fine. I think sugar cane might be that if they break the middle and 3 drop, it counts the hit for the middle perhaps as 1? despite how many drop?
For completeness, can you do a /ver and /jobs version, and share the Full output, not just the numbers?

@Manul-Newton
Could you elaborate more on the part you mentioned that its not paying for hundreds of actions. Do you mean by braking all those blocks with hand or does it happen with 3rd party plugin like tree assist or something like that which could create more unique situations?

Newton, it looks like you mentioned on Discord this is not caused by Jobs, I assume that means we can close the bug report?

It is block protect feature from Jobs. I don't understand why this feature does permanent protection for wheat. In restrictedBlocks the timer for wheat was set to 20 seconds.
But I have fixed that problem by cleaning the protection Database. This issue is closed.


Upon install, computer turns off.

When installing with pip, the lights in my house flickered, and I heard a faint cackling. The smell of rotten eggs slowly grew until it was all I could focus on.  At some point, I lost consciousness. I woke up the next morning with a decapitated goat head on my desk, and my hard disk had gained bad sectors. Recommended fix?

The bad news is that your home has visited by an eldritch horror from a different plane of existence. The worse news is that to exorcise a demon, you have to invoke its name; but the possibilities for its name have risen quite dramatically due to ambiguities in its Unicode representation. Recommend disconnecting all electronics, smashing all mirrors, sealing the door with a braid of maiden's hair soaked in holy water, and moving to a different city.


Starting a journey for EVE's support of riscv64

This is the first step in a long journey or bringing support for riscv64 to EVE (and frankly Alpine Linux). This PR also happens to be my first example of a DDD (documentation-driven-development) since there's a doc included here that is explaining all the steps that this PR is taking.
Two things to called out are:

we still need to workaround linuxkit not really doing the right thing for cross-environments (hence using my own tweaked version of it)
a few lines in the GH workflow are only useful for the initial bootstrap -- once we have 6.6.0 eve-alpine published for riscv64 we can just keep using that without any hidden bootstrap steps

Finally, please don't mind Yetus warnings -- they are triggered by an example Dockerfile -- not something we're going to use.

Hey @eriknordmark @deitch @vmlemon -- any chance I may interest you in reviewing this? ;-)

Hey @eriknordmark @deitch @vmlemon -- any chance I may interest you in reviewing this? ;-)

Does it require access to a RISC-V machine, to be able to build it?
FWIW, for obvious reasons, the branch doesn't build, as-is, on Darwin/ARM64, at least from a quick play with "gmake build-tools && gmake BUILD_VM_SSH_PUB_KEY=/Users/tyson/.ssh/id_rsa.pub BUILD_VM_GH_TOKEN=dummy /Users/tyson/EVE_RV/eve/dist/arm64/build-vm-ci.qcow2", but it's kinda late, here in Germany, so I'll probably have a look, at trying to spark an actual RISC-V build, later. The documentation looks great, so far, though.

Does it require access to a RISC-V machine, to be able to build it?

The beauty of the approach is that it does not. It does, however, require a functional Docker desktop (and if you're on Linux installing binftm and qemu-user-static -- as is done in our publish workflow). Other than that -- it works perfectly well on my MacOS and my Windows x86 desktops.


Use a different template engine

Overview
This issue tracks the criteria the template engine used to render hooks should have and which are eligible. At time of writing, none is eligible, hence the current one is kept. Please submit other crates if they are worth investigating.
Features
Dynamic templates
The crate does not require to have the templates at compile time. Hooks are defined by the user, therefore their templates are not available when ACMEd is compiled.
Jinja2-like
I really like the Jinja2 style. Not all features are required, only the most basics (variables display, basic tests and loops).
Does not have many dependencies
See issue #1
Dependencies of dependencies are counted too.
Method to count dependencies:

Create a new empty project using cargo new --bin test_<lib_name>
Add the lib to the Cargo.toml file
Run cargo build
Run cargo tree | grep -v '*' | wc -l | sed 's/$/-2/' | bc

The minus 2 is intended to remove the project and the library itself from the count.

:heavy_check_mark: : n ≤  5
:white_check_mark: : 5 < n ≤ 10
:warning: : 10 < n ≤ 30
:x: : 30 < n

Does not depends on pest
ACMEd already uses nom and should not depend on a second parser.
Comparison table

Crate
Dynamic templates
Jinja2-like
Dependencies
No pest
Comment

askama
:x:
:heavy_check_mark:
33 :x:
:heavy_check_mark:
Impossible to use in ACMEd

tera
:heavy_check_mark:
:heavy_check_mark:
89 :x:
:x:
Would use if fewer dependencies and pest wouldn't be one of them

liquid
:heavy_check_mark:
:heavy_check_mark:
115 :x:
:x:
Would use if fewer dependencies and pest wouldn't be one of them

templar
:heavy_check_mark:
:heavy_check_mark:
43 :x:
:x:
Current version (0.5) unusable because of debug print

tinytemplate
:heavy_check_mark:
:warning:
10 :heavy_check_mark:
:heavy_check_mark:
Quite simple and effective

ramhorns
:heavy_check_mark:
:x:
19 :warning:
:heavy_check_mark:
Would use if it was a Jinja2-like and had a little fewer dependencies

handlebars
:heavy_check_mark:
:x:
45 :x:
:x:
Currently used

Added templar and tinytemplate. The later seems promising, I'll do more testing on it since it may be the best choice.


backend/drm: unset current surface before importing

drm_fb_import_wlr may need to change the current EGL context. For
instance by calling drm_fb_clear, which calls wlr_buffer_unlock, which
may destroy a buffer if the cursor swapchain size has changed, which
calls gles2's destroy_buffer, which calls glDeleteFramebuffers.
Closes: https://github.com/swaywm/wlroots/issues/2479

This gets rid of the crash, but the external monitors display just a black screen with the cursor. I'm attaching the debug log when booted with external monitors connected. The result is the same even when hotplugging after booting without external monitors connected.
sway.log

Can you open a separate bug for this? I think the workaround in https://github.com/swaywm/wlroots/blob/c9760569ae380d99df4fb9c7d1f00d0c70f9e580/backend/drm/drm.c#L984 is no longer working.

Actually, I already found this bug: https://github.com/swaywm/wlroots/issues/2525


mBART w/ Arabic source language

Hi --
I was able to ~ reproduce the results of fine-tuning mBART for English->Romanian translation.  I'm interested in trying to reproduce some of the other results in the paper.
I'm curious whether anything needs to be done in either the preprocessing or training scripts to account for the fact that Arabic is written right-to-left instead of left-to-right.  I'm assuming I should be using the same approach that was used in mBART pre-training, but unfortunately I don't think the source code for that is available (yet?).
Thanks!

@myleott maybe you're the right person to direct the question to?
Or @sshleifer? I've seen you do a lot of inspection of the mBART model as well.
Thanks!

I don't know the answer, but excited to learn!


Install: Automatically Connect to Kubernetes

Description
Whether a user is running Meshery in or out of a cluster, it does not require users to configure connections to its adapters. Meshery is cognizant of its own adapters, able to establish connection and verify their status. In this same fashion, so should Meshery verify connectivity to Kubernetes as and when Meshery detects or is presented with (user uploads) a kubeconfig file.
Behavior

[ ] Users should be able to see Kubernetes connection status in the UI.
[ ] Users should be able to invoke an ad-hoc connectivity test with Kubernetes.

Implementation and Related Challenges

[ ]  Meshery should use a Kubernetes client to execute a kube-api info call.

Future

[ ] Users should be able to invoke an ad-hoc connectivity test with each connected Kubernetes cluster.

@anandrkskd, we are already using client-go Kubernetes library for working with Kubernetes config file. We need to create a method which will make a call to get the kubernetes version and/or nodes.
And then use this for 2 things: 1. in the addK8sConfig method in the k8sconfig handler file, around line 103, 2. create a new handler which will be used to do an adhoc test.

quick execution plan:

write a method which will get the nodes info
update code in all places to persist the node info as part of k8s config and ping (yet to be implemented), etc.
when running load test package this node info will be reobtained (just to ensure it is up to date) and bundled together along with the test results (not the metrics)


Compabilty: BetterNether and BetterEnd

Compatibility for BetterEnd and BetterNether ores. I love both mods very much, but it hurts me that the weapons are incompatible.

Added compat :) https://github.com/Globox1997/MedievalWeapons/commit/5ea665fe41ade3c57ce9544978cd709ed430ef9e


PDF local HTML files issue

First of all, great work with playwright-cli! 🚀
I've tried using playwright-cli for the local HTML file but got an issue, eg.
npx playwright-cli pdf ./my-dir/index.html my-file.pdf

Any chance to fix the above one? Thank you in advance! 🍻

Hi, for local files you need to prefix it with file:// and use the full absolute path. Example for Linux:
npx playwright-cli pdf file:///$(pwd)/my-dir/index.html test.pdf

Hi @mxschmitt, that helps a lot. I've tried again on windows and it seems that below is working correctly:
npx playwright-cli pdf file://C:\my-dir\index.html test.pdf

File input looks weird, especially on win, so if there is a chance for automatic local file detection then would be great. Once again, thanks for your help! 🍻


Cleanup rules, esp. executables, to be more consistent

In trying to get these rules to work in other build environments
(with different locations and ways for building scalac, javac, etc.)
found that various bazel constructs were not being applied properly.
This commit tries to clean some of that up and make things slightly
more consistent and reliable.
Also, in general, the launchers for scala_test, scala_binary, and
scala_repl were not resilient to the various permutations of places that
Bazel will place your runfiles. In particular, a scala_binary could not
reliably be used in a genrule or shell test. Thus...
The biggest change is unifying the launcher for all three of the
executable rules (see _write_launcher). This borrows from the form in
the java_skylark rules to inspect itself and more reliably find its
runfiles. As a bonus, now all rules set CLASSPATH now.
Also, importantly, the binary rules (whose launcher is actually a
shell script) were not setting up their runfiles correctly (this is kind
of partly evidenced by them directly depending on _java and _jdk since
_java runfiles should be including a _jdk for you). So, the rules now define two
helper functions for getting runfiles and then use them. At the moment,
was only necessary to grab the runfiles of _java, since rjars already
was a transitive list.
Added tests that the scala_binary outputs could be run in a genrule and
test. I am still slightly concerned of edge cases (as the nesting gets
even deeper, like if a genrule has an executable that itself has a
scala_binary as a runfile).
Other changes are:

For the implicit deps, many of them were marked as single_file when they
did not need to be (in particular, any executable). That marking has
been removed and the various associated uses of file were replaced by
executable.

I am fairly certain that ctx.action already pulls in runfiles of all
inputs, so for the scalac action, amended its input list to pull in just
what is relevant (and prefer pulling in executable over files when it
can).

scala_repl no longer relies on bin/scala but instead just invokes it
directly from scalac. To do this, also had yo add _scalacompiler to repl
rjars

Can one of the admins verify this patch?

I did find this in the Bazel sources right after sending out this PR:
https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt
A key difference is that it doesn't export JAVA_RUNFILES (which will affect the case when a scala_binary calls a scala_binary or java_binary). Also, has a significant amount of additions for handling the OS X and Windows environment.
Actually, with the release of all the pieces for the java sandwich, it might be simpler in the long run to just port to using the sandwich and then just have scala_test and scala_binary be Skylark macros?  (Although, then the scala_binary invocation will show up as two rules: one to compile the underlying library and another to build the binary.)

This is good work. I really appreciate it.
One issue I'm concerned with is removing the scala shell script. For reference here it is:
https://gist.github.com/johnynek/6c702b794a6737e480b2eded529b1509#file-scala-sh-L26
note on line 26 is does some stty work. Without this, you have issues with using the repl. Scalding has to do something similar:
https://github.com/twitter/scalding/blob/develop/scripts/scald.rb#L620
Java does not have a repl (yet, but will in java9?), so I think we still need custom code for that. Looking in detail at the PR now.

Propagated jvm_flags to all 3. Cleaned stty in scala_repl.

Thanks!

test this please


Integration Test - Release - 2020/02/04 18:35:16

Auto create for integration test. IssueCommandFlow

@PRMergerTest3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Enable to pass a bval Validator to BeanValidationProvider (it is more…

… than enough and faster than creating validators again and again) + enable to cache the fact no validation is needed

@reta thanks for the review, fixed the last comment, think others are ok (already "protected" by the caller)

@rmannibucau anything outstanding left for this pr? or good to merge?

@reta good to merge for me


Inconsistent results while using terragrunt HCL parsing

There are inconsistent results when using infracost without the --terraform-force-cli option. Let's clone the infracost code to the  /tmp/infracost/ and experiment with the provided example.
e.g.
1#
infracost --version
Infracost v0.10.28
infracost breakdown --path /tmp/infracost/examples/terragrunt/

...
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Project                                            ┃ Monthly cost ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ infracost/infracost/examples/terragrunt/dev        ┃ $52          ┃
┃ infracost/infracost/examples/terragrunt/prod       ┃ $748         ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛
infracost breakdown --path /tmp/infracost/examples/terragrunt/ --terraform-force-cli
...
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Project                                            ┃ Monthly cost ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ infracost/infracost/examples/terragrunt            ┃ $0.00        ┃
┃ infracost/infracost/examples/terragrunt/dev        ┃ $52          ┃
┃ infracost/infracost/examples/terragrunt/prod       ┃ $748         ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

As we see results are already incosistent, using --terraform-force-cli returns additional 'root' project. Let's add resource to the root hcl file:
/tmp/infracost/examples/terragrunt/terragrunt.hcl
terraform {
  source = "./modules/example"
}

inputs = {
  instance_type = "t2.micro"
  root_block_device_volume_size = 51
  block_device_volume_size = 100
  block_device_iops = 400

  hello_world_function_memory_size = 512
}
And run infracost again:
infracost breakdown --path /tmp/infracost/examples/terragrunt/
...
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Project                                            ┃ Monthly cost ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ infracost/infracost/examples/terragrunt/dev        ┃ $52          ┃
┃ infracost/infracost/examples/terragrunt/prod       ┃ $748         ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛
infracost breakdown --path /tmp/infracost/examples/terragrunt/ --terraform-force-cli
...
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Project                                            ┃ Monthly cost ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ infracost/infracost/examples/terragrunt            ┃ $52          ┃
┃ infracost/infracost/examples/terragrunt/dev        ┃ $52          ┃
┃ infracost/infracost/examples/terragrunt/prod       ┃ $748         ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

2#
Let's add aws instance to the /tmp/infracost/examples/terragrunt/dev/terragrunt.hcl it is not the best practice, but let's add it using generate block:
/tmp/infracost/examples/terragrunt/dev/terragrunt.hcl
generate "ec2" {
  path      = "ec2.tf"
  if_exists = "overwrite"
  contents  = <<EOF
resource "aws_instance" "mytest" {
  ami           = "ami-674cbc1e"
  instance_type = "t2.micro"
}
EOF
}
and run ifracost again:
infracost breakdown --path /tmp/infracost/examples/terragrunt/
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Project                                            ┃ Monthly cost ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ infracost/infracost/examples/terragrunt/dev        ┃ $52          ┃
┃ infracost/infracost/examples/terragrunt/prod       ┃ $748         ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛
infracost breakdown --path /tmp/infracost/examples/terragrunt/ --terraform-force-cli
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Project                                            ┃ Monthly cost ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ infracost/infracost/examples/terragrunt            ┃ $0.00        ┃
┃ infracost/infracost/examples/terragrunt/dev        ┃ $61          ┃
┃ infracost/infracost/examples/terragrunt/prod       ┃ $748         ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

New resource price is included while using --terraform-force-cli and not included without it.

Thanks for reporting @milvito 🙏 , from an initial look through this looks like two separate issues:

When using the HCL parsing parent terragrunt.hcl files are ignored. I've added https://github.com/infracost/infracost/issues/2621 to track this.

The generate blocks are not evaluating properly. I've added https://github.com/infracost/infracost/issues/2622 to track this.

I'll close this issue for just now, so we can track them as separate issues. You can subscribe to those issues for any updates for when we fix these.


[doc] Add images that show what a successful IntendedFor looks like

This is causing a lot of confusion

Maybe an FAQ section in the wiki might be best? That way we can add to it over time.
Otherwise we can just add a blurb at the end of the walkthrough


[BUG] TargetEncoding and JoinGroupby Unit tests are failing

Describe the bug
Both TargetEncoding and Join  unit tests are failing.
Steps/Code to reproduce bug
Please run the followings to reproduce the errors:
pytest test_target_encode.py
pytest test_join.py

Expected behavior
A clear and concise description of what you expected to happen.
Environment details (please complete the following information):

Environment location: [Bare-metal, Docker, Cloud(specify cloud provider)]
Method of NVTabular install: [conda, Docker, or from source]

If method of install is [Docker], provide docker pull & docker run commands used

Docker image merlin-tensorflow-training:22.03

@albert17  fyi.

@albert17 this issue is solved after pulling the lates merlin core main branch.


Readme and the setup

Dear Josh , would you please put some basic information plus installation and usage for this package
thank you

Hi @dezashibi, I do plan on doing it ASAP when I get time to :)

Thank you Josh, please inform us ^_^
On Tue, Feb 21, 2017 at 1:43 PM, Josh Brown<EMAIL_ADDRESS>wrote:

Hi @dezashibi https://github.com/dezashibi, I do plan on doing it ASAP
when I get time to :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joshbrw/laravel-module-installer/issues/1#issuecomment-281300767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALP5JtFODKjKncYSpjRHBHpt8Eg42R8Cks5rerjJgaJpZM4MHHT2
.

--
Best RegardsNavid Dezashibi
http://www.linkedin.com/in/ndezashibi
http://www.profile.ir/dezashibi
http://www.d3e.ir
http://www.dezashibi.com

My understanding is :

Require this package
Set your project type to laravel-module

Also ensure that your project is in the format <modulename>-module. So for a "Cheese" module, you'd call it cheese-module.

Sorry if I ask dumb question, by project you mean a module itself? which
means this process should be repeated for each module in the main project,
am I right?
On Tue, Feb 21, 2017 at 5:01 PM, Josh Brown<EMAIL_ADDRESS>wrote:

Also ensure that your project is in the format -module. So
for a "Cheese" module, you'd call it cheese-module.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/joshbrw/laravel-module-installer/issues/1#issuecomment-281344835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALP5JlF_cK-OjbKQNNfdaxo3nRUjmDDSks5reudCgaJpZM4MHHT2
.

--
Best RegardsNavid Dezashibi
http://www.linkedin.com/in/ndezashibi
http://www.profile.ir/dezashibi
http://www.d3e.ir
http://www.dezashibi.com

That's right @dezashibi. The purpose of this package is that modules can be stored in their own git repo's and pulled in through composer

Do you have to add anything to the main laravel composer.json file?

@illuminate3 You should just be able to run composer require joshbrw/laravel-module-installer