Done #14(Sticky sidebar) #3(Chapters, this one still need some improvements aka thumbnails), #32 hamburger in appbar

This pr fixes the issues: #32 #3 #14
Set sidebar to be  sticky at the top on scroll
Added chapters, missing thumbnails (maybe in future)
Moved hamburger to the AppBar instead of body
Preview:
https://github.com/code100x/cms/assets/38940603/e794e2e3-9c84-4b8c-8b23-d721b9cc88d3
Build:
Working on local

Thankyou @siinghd
Do u mind extracting just the sidebar bit in this one?
I merged in chapters from a different PR which we might have to stick to because eventually it'll look similar to tammy ai

Didn't saw #86ccf4bc-1eaf-499e-ab8e-9f3c40fef289 , i think the way i have done looks more cleaner... depends on your preference :)

Thankyou @siinghd Do u mind extracting just the sidebar bit in this one? I merged in chapters from a different PR which we might have to stick to because eventually it'll look similar to tammy ai

Sure :)

Dropdowns might get tricky with it being on the left .
It also saves space tho. Unsure which one I love more

Dropdowns might get tricky with it being on the left . It also saves space tho. Unsure which one I love more

I would prefer my approach hahahha, it's just intuitive don't have to look at multiple things

Some merge conflicts in there could u look at them?

Some merge conflicts in there could u look at them?

looking at them :)

@hkirat should be fine now :)

Also one more thing @hkirat @siinghd instead of sending json for segments, can we send it like how YouTube does it?
Like this:
00:00 Segment 1
04:46 Segment 2
01:04:06 Segment 3
It'll be easier for anyone who's adding the segments instead of adding the json?
We can store the json while hitting the backend the same way,  just changing the input part?
I'd like to work on it if you think that this might be a better way.

Also one more thing @hkirat @siinghd instead of sending json for segments, can we send it like how YouTube does it? Like this: 00:00 Segment 1 04:46 Segment 2 01:04:06 Segment 3
It'll be easier for anyone who's adding the segments instead of adding the json?
We can store the json while hitting the backend the same way, just changing the input part? I'd like to work on it if you think that this might be a better way.

Isn’t this just how you see it in frontend?
I don’t think YouTube does something different in the backend.
You can create the admin section for adding the segments to the backend as that is missing.
From the person imputing the segments you can ask them however you want after that just convert the time format to seconds and it should work fine.
Also adding json is just sending the json payload to the backend via post.

Also one more thing @hkirat @siinghd instead of sending json for segments, can we send it like how YouTube does it? Like this: 00:00 Segment 1 04:46 Segment 2 01:04:06 Segment 3
It'll be easier for anyone who's adding the segments instead of adding the json?
We can store the json while hitting the backend the same way, just changing the input part? I'd like to work on it if you think that this might be a better way.

Isn’t this just how you see it in frontend?
I don’t think YouTube does something different in the backend.
You can create the admin section for adding the segments to the backend as that is missing.
From the person imputing the segments you can ask them however you want after that just convert the time format to seconds and it should work fine.
Also adding json is just sending the json payload to the backend via post.

Yes, the section is already added, you can check it at /admin/userFlow
The existing input asks for a json input, instead of how YouTube asks to add the segments.
Rest all remains the same

@nimit9 Saw it ;)
Yes that can be improved, you can make an array of objects just like the end segments.
Something like:
Input start time, input end time, input title, button add segments
final button -> submit -> here you just pass the array aka json payload ;)

@nimit9 Saw it ;)
Yes that can be improved, you can make an array of objects just like the end segments.
Something like:
Input start time, input end time, input title, button add segments
final button -> submit -> here you just pass the array aka json payload ;)

I feel adding start time and end time both is unnecessary as the starting time for next segment would be ending for the previous one,
so that is redundant input.
Just adding the time in the form of hh:mm:ss/mm:ss(if less than 1 hour) would be good for UX as the admin won't have to keep calculating seconds for every segment (imagine adding start as 3769 and end as 3963)

@nimit9 Saw it ;)
Yes that can be improved, you can make an array of objects just like the end segments.
Something like:
Input start time, input end time, input title, button add segments
final button -> submit -> here you just pass the array aka json payload ;)

I feel adding start time and end time both is unnecessary as the starting time for next segment would be ending for the previous one, so that is redundant input.
Just adding the time in the form of hh:mm:ss/mm:ss(if less than 1 hour) would be good for UX as the admin won't have to keep calculating seconds for every segment (imagine adding start as 3769 and end as 3963)

On frontend to the user you can ask them however you want I think haha ;)

@nimit9 Saw it ;)
Yes that can be improved, you can make an array of objects just like the end segments.
Something like:
Input start time, input end time, input title, button add segments
final button -> submit -> here you just pass the array aka json payload ;)

I feel adding start time and end time both is unnecessary as the starting time for next segment would be ending for the previous one, so that is redundant input.
Just adding the time in the form of hh:mm:ss/mm:ss(if less than 1 hour) would be good for UX as the admin won't have to keep calculating seconds for every segment (imagine adding start as 3769 and end as 3963)

On frontend to the user you can ask them however you want I think haha ;)

Yeah that's what I was asking. Since it'll be an admin (@hkirat or someone from his team), I'm not sure what they prefer, so thought of asking them first)

Yeah we want to crowdsource segments as soon as possible. So might be more convinient for people to do segments similar to youtube.
Before that we need to add a description section below the video where the segments can be put (similar to youtube)
Ideally the closer we can get to YT the better

@hkirat this can be merged and closed i think

Yeah holding in merging until https://github.com/code100x/cms/issues/45 is fixed to avoid re-deployment

Yeah we want to crowdsource segments as soon as possible. So might be more convinient for people to do segments similar to youtube. Before that we need to add a description section below the video where the segments can be put (similar to youtube) Ideally the closer we can get to YT the better

@hkirat
I'd like to work on it, just not sure how could we get the thumbnails for each segment.

There is a thumbnailmosaicUrl in the database.
I think @siinghd built that

Yeah we want to crowdsource segments as soon as possible. So might be more convinient for people to do segments similar to youtube. Before that we need to add a description section below the video where the segments can be put (similar to youtube) Ideally the closer we can get to YT the better

@hkirat I'd like to work on it, just not sure how could we get the thumbnails for each segment.

Hi you can find that here:  https://github.com/siinghd/player-custom-seekbar
If you want to look at the working example https://nextjs-videothumb.hsingh.site
Also the backend is still up here https://api-videothumb.hsingh.site (https://api-videothumb.hsingh.site/video?fileId=1234)
The backend let you generate the thumbnails of a video, normally it will look like so

Thanks @hkirat @siinghd, I'll take a look

@hkirat
I'd like to work on it, just not sure how could we get the thumbnails for each segment.

@hkirat do we really need thumbnails? As they'd be just random points in a video with code which anyways won't be visible in the thumbnail.


docs: refactor example notebooks

Replaces the getting_started notebook with the one Irfan wrote in the H-series documentation
Removes the explicit device list in the Quantinuum examples notebook

@irfankhan10 I'm preparing the example notebooks for Nexus docs here. I'm choosing to keep the WASM and Quantinuum example notebooks around for now so they will be available in the Nexus Jupyterhub, however they won't be listed in the actual documentation pages (but will show up in search)


Correction for raw affiliation Robarts Research Institute, Schulich School of Medicine and Dentistry, Western University

Correction needed for raw affiliation Robarts Research Institute, Schulich School of Medicine and Dentistry, Western University
raw_affiliation_name: Robarts Research Institute, Schulich School of Medicine and Dentistry, Western University
new_rors: 02grkyz14
previous_rors: 05cgtjz78
works_examples: W4387159199;W4317915641;W4389726444;W4389296200
contact: f5e2f650374cf0848644f96d8560c4b8:f9b7f40428ac2b65 @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Added enum switch mode

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.80%. Comparing base (adfad4a) to head (a2900ec).
Report is 1 commits behind head on dev.

Files
Patch %
Lines

ros_bt_py/ros_bt_py/nodes/fallback.py
27.65%
34 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #88      +/-   ##
==========================================
- Coverage   33.85%   33.80%   -0.06%
==========================================
  Files          37       37
  Lines        5461     5508      +47
  Branches     1252     1267      +15
==========================================
+ Hits         1849     1862      +13
- Misses       3552     3586      +34
  Partials       60       60

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Can you please add tests for the node?


We seem to be allowing connections from the same app twice

2015/06/09 17:36:06 collector: got a report from <IP_ADDRESS>:4030
2015/06/09 17:36:09 collector: got a report from <IP_ADDRESS>:4030

2015/06/10 10:44:23 dialing <IP_ADDRESS>:4030 (backoff 4s)
2015/06/10 10:44:23 connected to <IP_ADDRESS>:4030
2015/06/10 10:44:23 incoming connection: <IP_ADDRESS>
2015/06/10 10:44:23 connection initiated: <IP_ADDRESS>:49425
2015/06/10 10:44:23 dialing <IP_ADDRESS>:4030 (backoff 4s)
2015/06/10 10:44:23 connected to <IP_ADDRESS>:4030
2015/06/10 10:44:23 incoming connection: <IP_ADDRESS>
2015/06/10 10:44:23 connection initiated: <IP_ADDRESS>:37157

Problem is connecting on <IP_ADDRESS> makes it look like the connection is coming from <IP_ADDRESS>


chore(deps): update jest

What kind of change does this PR introduce?
Update deps
Did you add tests for your changes?
Existing tests
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing

Looks jest buggy with some of regexp

Issue in jest repo: https://github.com/facebook/jest/issues/9614

@evilebottnawi  but in CI all is ok.. I have already mentioned this problem but did not investigate it..

@vankop https://github.com/webpack/webpack/pull/10443/files  and https://github.com/webpack/webpack/pull/10443/files#diff-683c19e6bbc651ff5c95f16d8915e990R75 are workarounds


Move graph.SetupInitLayer to daemon package where it is used

An inspection of the graph package showed this function to be way out of place.
It is only depended upon by the daemon code. The function prepares a top-level
readonly layer used to provide a consistent runtime environment for docker
images.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

@stevvooe rebase plz

@tiborvass Rebased.

if the init layer setup is only used for !windows, does it make sense for it to live only in daemon/daemon_unix.go?
As far as moving it where it's used, totally agree--this makes sense.

@estesp just fyi it's also used for !exclude_graphdriver_aufs,linux

@stevvooe would you mind putting it in daemon_unix.go like @estesp suggested?

@tiborvass It is also used in daemon_aufs.go. Is putting it in daemon_unix.go sufficient? I assume so, since aufs is available on unix.

@estesp @tiborvass I've moved the function to the bottom of daemon_unix.go. This is assuming that linux is always treated as a unix, which I believe is set when linux is set (although, I cannot find any documentation on this).

LGTM

thanks @stevvooe!
LGTM


Update deps with RUSTSEC advisories

See cargo-deny warning inhttps://github.com/probe-rs/probe-rs/actions/runs/8544348942/job/23410164780?pr=2339

Well, often the upstream crate actually has to be updated to update downstream. But technically you can just update h2 here, indeed :) But can also update insta while we are at it :)


Failure on import

Hi there,
We have migrated across to the new Freshbooks API and thought we would use this sdk. I am experiencing the following issues:

When using python 2.7:

Traceback (most recent call last):
  File "freshbooks_util.py", line 1, in <module>
    from freshbooks import Client
  File "/Users/me/env/lib/python2.7/site-packages/freshbooks/__init__.py", line 10, in <module>
    from freshbooks.builders.filter import FilterBuilder  # noqa
  File "/Users/me/env/lib/python2.7/site-packages/freshbooks/builders/__init__.py", line 3
    def build(self) -> str:  # pragma: no cover
                    ^
SyntaxError: invalid syntax

When using python 3.8:

Traceback (most recent call last):
  File "freshbooks_util.py", line 1, in <module>
    from freshbooks import Client
  File "/Users/me/38env/lib/python3.8/site-packages/freshbooks/__init__.py", line 13, in <module>
    from freshbooks.client import Client  # noqa
  File "/Users/me/38env/lib/python3.8/site-packages/freshbooks/client.py", line 28, in <module>
    with open(os.path.join(os.path.dirname(__file__), "VERSION")) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/me/38env/lib/python3.8/site-packages/freshbooks/VERSION'

I realise that the sdk is still < 1.0; but thought I would report these issues to see if there is a quick fix available.

Hey! Sorry about that. Should be fixed if you grab version 0.3.0 on python 3.6+ (we aren't going to support 2.7).
Thanks for the feedback and bug report!


Verdaccio (Helm) - htpasswd permission denied

Describe the bug
I installed verdaccio helm chart with my custom configuration yaml file. I tried to ssh into the pod and create /verdaccio/storage/htpasswd with user records but I don't have the permission to create a file inside /storage directory.
To Reproduce

Create custom config.yaml

Create configmap:
kubectl create configmap verdaccio-config --from-file ./config.yaml

Install Verdaccio Helm Chart:
helm install verdaccio --set customConfigMap=verdaccio-config verdaccio/verdacio

I ssh into the pod and wanted to create /verdaccio/storage/htpasswd file but I got 'permission denied'. I also tried to run chown command on the folder but I couldn't as I do not have enough privilege.

Configuration File (cat ~/.config/verdaccio/config.yaml)
storage: /verdaccio/storage/data
plugins: /verdaccio/plugins

web:
  title: Verdaccio

auth:
  htpasswd:
    file: /verdaccio/storage/htpasswd
    max_users: -1

uplinks:
  npmjs:
    url: https://registry.npmjs.org/

packages:
  '@my-scope/*':
    access: $authenticated
    publish: $authenticated
    unpublish: $authenticated
    proxy: npmjs

middlewares:
  audit:
    enabled: true

logs:
  - { type: stdout, format: pretty, level: http }

@verdaccio/kubernetes guys do you have any suggestions here ?

@ivj94 hi, how did you 'ssh into the pod'? Are you using kubectl exec?
What user do you run it as? Try to run whoami please. Thanks!

Maybe the chart should pass htpasswd as a secret? Is this feasible? Instead of manually creating the file in the pod.

Maybe the chart should pass htpasswd as a secret? Is this feasible? Instead of manually creating the file in the pod.

definitely, nothing should be created manually in the pod

Yeah @ivj94 it's by design that the user account running the pod has no access to say replace the password file. In general it's an anti-pattern in kubernetes and docker to modify code and configuration files at runtime rather than injecting them via the container image or a volume mounted configmap or secret.
We might still need to review the helm chart flow for managing htpasswd because IIRC it's more complex than it needs to be.

Added a proposed set of chart features to handle this over at https://github.com/verdaccio/charts/issues/23. Let me know if you've got thoughts.

Like @kav is saying, injecting a configmap or secret is typical for Kubernetes and other container orchestration tooling. I added an example of a thing I do in my comment here.
That will unblock you, while discussion of the ideal approach can continue in parallel.

Thanks guys for replying, I considered this answered.


add native shipping-method

I added a feature to the shipping-method system in my personal project,
That is, if it adds a new record to the app shipping models database, It is used as a new shipping-method in the store.
As mentioned on this page, this issue can contain a lot of details, but is it worth it to be added to the core as a feature to meet the needs of users in many cases so that they do not implement themselves again ?
Of course, the maintainer can also say a general point to be observed if it is to be added as a feature .

sounds like you already did some development and it would be useful if you could share your code, e.g. as a fork here on github?

I developed it in the company I work for,
It will take some time to bring it as a separate section on github because it is not the whole open source project, but I will do it soon and share the link.


Remove workaround for gzip/BGZF compressed VCF headers

Remove the workaround here
https://github.com/bigdatagenomics/adam/blob/master/adam-core/src/main/scala/org/bdgenomics/adam/rdd/ADAMContext.scala#L159
for gzip/BGZF compressed VCF headers.  The issue has been fixed upstream
Fix VCFHeaderReader for gzipped and BGZF VCF formats
https://github.com/HadoopGenomics/Hadoop-BAM/pull/97
Note this will require bumping the dependency version of Hadoop-BAM to 7.5.1 (or 7.6.0) which may bring along a transitive dependency version bump of htsjdk to 2.5.0, see https://github.com/HadoopGenomics/Hadoop-BAM/pull/107.

Fixed by #1060


merge staging into master

merge staging into master and push the new production release live.

Deploy preview processing.
Built with commit 552d445752e1d0fecec7323d63fda0cd47072f5c
https://app.netlify.com/sites/fcccolumbus/deploys/59f4f705df9953097e60bbb1

Coverage remained the same at 100.0% when pulling 552d445752e1d0fecec7323d63fda0cd47072f5c on staging into 798dc23102b858212cc6c4d6b72dee18bba79cb9 on master.


Add option to use fixed-width font when composing messages

See #387

Any news on this? Right now, it is not possible at all to have a proper font while composing a message  :-(
Thanks.

Any news about this?

I just checked PR #387, and it is trivial.
Even if it statically links the composition preference to the view preference, instead of creating a separate configuration option, this would most likely solve the problem for most people, without the need of a major design overhaul.
I feel that adding this trivial patch has zero side effects while solving 99 % of the problem.
Please consider applying this patch independently of any redesign efforts!
Bribe: I hereby offer 5 € (broke af, sorry) for inclusion of this patch. If I'm not instructed otherwise, it will be paid to f-droid, as requested on the k-9 mail website.


cuda uninstall leaves app behind

General troubleshooting steps

[x] I have checked the instructions for reporting bugs (or making requests) before opening the issue.

[x] None of the templates was appropriate for my issue, or I’m not sure.

[x] I ran brew update-reset && brew update and retried my command.
[x] I ran brew doctor, fixed as many issues as possible and retried my command.
[x] I understand that if I ignore these instructions, my issue may be closed without review.

Description of issue
After uninstalling Cuda (#33278), I am still presented with the Cuda install / update dialog on each boot.
Gist of mdfind -name cuda before uninstall:
https://gist.github.com/adamlwgriffiths/f647f357d6ec784b4c101ca6755d16c9#file-after-brew-cask-install-cuda
and after uninstall:
https://gist.github.com/adamlwgriffiths/f647f357d6ec784b4c101ca6755d16c9#file-after-brew-cask-uninstall-cuda
Output of your command with --verbose --debug
https://gist.github.com/adamlwgriffiths/f647f357d6ec784b4c101ca6755d16c9#file-brew-cask-uninstall-cuda-verbose-debug
Output of brew cask doctor
https://gist.github.com/adamlwgriffiths/f647f357d6ec784b4c101ca6755d16c9#file-brew-cask-doctor

https://github.com/caskroom/homebrew-cask/pull/33880

Thank you, confirmed working after running brew update-reset && brew update


Update readme.md

I updated it so it the readme.md file shows you have to enter the whoisdigger directory before running npm install.

Thank you for your contribution! merging

closed by mistake and cant reopen due to repo already been deleted. cheers


Review: Expense payment for acgn-stock Collective

Mail from user:

https://opencollective.com/acgn-stock/expenses

I submit and approve 3 expense about 9 days ago, but still not receive until today.
FAQ say it will be paid every Friday.
Anything wrong?

Is this collective under Open Collective, or maybe it's under another organization?

@nicobarretoOC please email to them that we've been having some issue sending the payment to that paypal account. We believe is not on their end, so we are talking with paypal so see what's the issue.  We are working on solving and hopefully we can reimburse them this week.

User says it has no other Paypal account :/

@nicobarretoOC we tried to pay again today and we hit the same error. We are taking with Paypal, trying to see what's going on.

Hey, do you want me to keep this issue open @piamancini ?

yes, it's still unresolved.

fixed and expense reimbursed. @nicobarretoOC user probably knows from seeing his expense paid but just in case shoot them an email.


Update copy for API Keys

📝 Changed routes:

/dashboard/api-keys

(view full size)

Commit 48569a164246c67b22a569f02af518a5b2292ba4 (https://thirdweb-gqv2jntt2.thirdweb-preview.com).


Net timeout error when trying to sign in.

Hello. I used RubyCAS and now I try to migrate to CASino.
I have installed CASinoApp, it runs fine, I can login and logout. So I open my Rails app, it redirects to a Casino, then I type my email and password, and type "sign in". After that, it's loading for something for a long time and then shows an error.
Logs in my Rails app:
I, [2017-02-16T17:46:25.657535 #28572]  INFO -- : Started GET "/users/sign_in" for <IP_ADDRESS> at 2017-02-16 17:46:25 +0300
I, [2017-02-16T17:46:25.659215 #28572]  INFO -- : Processing by DmpCasController#new as HTML
I, [2017-02-16T17:46:25.659672 #28572]  INFO -- : Current user: Anonymous
I, [2017-02-16T17:46:25.667560 #28572]  INFO -- : Redirected to http://auth.mytestapp.com/login?service=http%3A%2F%2Frails.mytestapp.com%2Fusers%2Fservice
I, [2017-02-16T17:46:25.667744 #28572]  INFO -- : Completed 302 Found in 8ms (ActiveRecord: 0.0ms)
I, [2017-02-16T17:46:27.244701 #28572]  INFO -- : Started GET "/users/service?ticket=ST-14872563871889-u80GnDc3lgfz50jSy7Jx3NBcKxvOqn5PFkTop0XK" for <IP_ADDRESS> at 2017-02-16 17:46:27 +0300
I, [2017-02-16T17:46:27.245653 #28572]  INFO -- : Processing by DmpCasController#service as HTML
I, [2017-02-16T17:46:27.245683 #28572]  INFO -- :   Parameters: {"ticket"=>"ST-14872563871889-u80GnDc3lgfz50jSy7Jx3NBcKxvOqn5PFkTop0XK"}
D, [2017-02-16T17:46:27.247939 #28572] DEBUG -- : Requesting CAS response for URI http://auth.mytestapp.com/proxyValidate?service=http%3A%2F%2Frails.mytestapp.com%2Fusers%2Fservice&ticket=ST-14872563871889-u80GnDc3lgfz50jSy7Jx3NBcKxvOqn5PFkTop0XK
I, [2017-02-16T17:46:22.254612 #26220]  INFO -- : Completed 500 Internal Server Error in 60004ms (ActiveRecord: 0.0ms)
F, [2017-02-16T17:46:22.259699 #26220] FATAL -- :
Net::OpenTimeout (execution expired):
  /home/user/.rbenv/versions/2.3.3/lib/ruby/2.3.0/net/http.rb:880:in `initialize'
  /home/user/.rbenv/versions/2.3.3/lib/ruby/2.3.0/net/http.rb:880:in `open'

Casino config:
production:
  frontend:
    sso_name: 'CASino'
    footer_text: 'Powered by CASino'
  authenticators:
    testapp:
      authenticator: "ActiveRecord"
      options:
        connection:
          host: localhost
          adapter: postgresql
          database: testapp_production
          encoding: unicode
          pool: 5
          username: user
          password:
        table: "users"
        username_column: "email"
        password_column: "encrypted_password"
        extra_attributes:
          email: "email"
          fullname: "email"

CasController:
class AuthCasController < Devise::CasSessionsController
  # skip_before_action :redirect_to_sign_in, :only => [:new, :single_sign_out]
  skip_before_filter :redirect_to_sign_in,
  only: [:new, :destroy, :single_sign_out, :service, :unregistered]

  # Skip verify_signed_out_user for Devise >= 3.3.0
  skip_before_filter :verify_signed_out_user
end

Devise config:
  config.cas_base_url = 'http://auth.mytestapp.com'
  config.cas_logout_url_param = "destination"
  config.cas_destination_logout_param_name = "service"
  config.cas_create_user = false
  config.cas_enable_single_sign_out = true
  config.cas_username_column = :email

Is there a way to find a problem? I use Ruby 2.3+, but I think it isn't that different

Ok, I solved this. I had to edit /etc/hosts and add there server's IP and address auth.mytestapp.com


new handler proposal: convert string by POST

I have an use case where I can't give AthenaPDF a file or a url. In this case it's really useful to support PDF creation from an HTML string given by POST in the request body.
The new handler works like this:
$ curl http://<dockerurl>:8080/convert-str?auth=arachnys-weaver -H "Content-Type: application/x-www-form-urlencoded" -d "content=%3Cdiv%3Esom+content%3C%2Fdiv%3E"

Hope this is as useful for others as it is for me!

Hey @flaviamissi, thank you for doing this.
I can see the use, but I'm not entirely convinced since I feel like this is something that should be accomplished by the file handler. Do you have a real world example perhaps?

Hey @MrSaints, thank you for the quick answer.
Yes, I have a real world example:
I have a docker container up and running with AthenaPDF and my backend (which lives in another server) needs to generate a PDF through Athena's HTTP API.
We have an html template, and the data in it is very sensitive. Additionally, the html is dynamically generated and it isn't served by any endpoint.
A few of possible solutions are:

write the html in the filesystem and mount it on athena's container before triggering the generation.
serve the html somewhere where it's only visible internally on the network, since athena doesn't support authentication when requesting the pdf page.
upload the html to some cloud storage and use basic auth in the url when giving the url parameter to athena.

As you can see the above solutions require some overhead. Receiving the html string in the request body is the only way I could think of solving this problem in a simple manner.
But of course I'd be glad to try other solutions if you have some tips.
Hope this was clear enough!

Understandable. But if I'm understanding you correctly, I'm sure what you want to accomplish can be done using the existing file handler endpoint. You just need to encode the dynamically generated HTML in multipart/form-data. It does not need to be written in the file system or served from anywhere. In fact, this is what we're using on our systems.
For example, using the Python requests library:
requests.post(
      'api url',
      params={
        'auth': 'auth key',
      },
      files={'file': ('input.html', raw_data)},
)

The requests library in this case will be using multipart/form-data encoding for the POST. raw_data can be the string output of a render from Django.

Aha, I didn't know that was possible, thank you!
This works with a little extra work in go, here's the code for reference:
func convert() error {
    html = "
my awesome file
"
	var b bytes.Buffer
	w := multipart.NewWriter(&b)
	fw, err := w.CreateFormFile("file", "input.html")
	if err != nil {
		return err
	}
	fw.Write([]byte(html))
	w.Close()

	url := "http://<api>/convert?auth=<authkey>"
	req, err := http.NewRequest("POST", url, &b)
	if err != nil {
		return err
	}
	req.Header.Set("Content-Type", w.FormDataContentType())

	client := &http.Client{}
	res, err := client.Do(req)
	if err != nil {
		return err
	}
}

I'm closing this since this PR is not necessary to accomplish what I need.
It would be nice if there was some documentation about this usage, but maybe it's usually obvious for other people.
Thank you for the help!

That's fantastic @flaviamissi. Glad it worked out.
We're doing something similar for our CloudConvert quick conversion method: https://github.com/arachnys/athenapdf/blob/master/weaver/converter/cloudconvert/cloudconvert.go#L68.
And yea, I agree. The docs needs some cleaning up, and additions 😆

Just popped by to clarify you should not set the ext=.pdf query parameter when doing this, and it works when you remove it. I lost a few hours with the vague errors
Error #01: exit status 1 : libudev: udev_monitor_new_from_netlink_fd: error getting socket: Protocol not supported
Unable to convert an octet-stream, use stdin.

Hopefully this helps someone
https://github.com/arachnys/athenapdf/blob/77d311ae9a02f344825c3884ef2d7c4603fceff3/weaver/handlers.go#L150


Send the correct xclient-version

ServerRequestParameters is currently setting the version field to "msal", this PR fixes this to pass the correct version

Coverage increased (+13.2%) to 95.975% when pulling b38129df9722e009e9e9a8b6a482a272835c3bf9 on send-correct-xclient-version into d5509a061349a67558abe543aa3845cc0d7119cb on dev.


[Metadata Improvement]: healthCondition standardizer not respecting hierarchy of ontologies

Issue Name
healthCondition standardizer not respecting hierarchy of ontologies
Issue Description
The healthCondition normalizer/standardizer should respect a hierarchy of ontologies, such that if a term is found in MONDO, it will be used, if NOT, then it will be searched in the next ontology in the hierarchy.
With this approach, we would hopefully reduce the likelihood of having duplicate terms in different ontologies. Unfortunately, this does not appear to be the case. As seen below, 'Lung disorder' appears twice:

This is because 'Lung Disorder' is being normalized to NCIT: http://purl.obolibrary.org/obo/NCIT_C3198, while 'Lung disorder' is normalized to MONDO: http://purl.obolibrary.org/obo/MONDO_0005275
Ideally, based on the hierarchy, 'Lung disorder' (regardless of capitalization) would all be normalized to the MONDO term since it's higher up in the hierarchy of ontologies used for healthCondition.
Similarly, 'Lung Diseases' (https://id.nlm.nih.gov/mesh/D008171.html) would be mapped to the MONDO term, 'Lung disorder'.
We can potentially use the exact term matches from OLS to identify mappings that should be used, if our current method via the translator KPIs are not working. Example of a term with exact term mappings: https://www.ebi.ac.uk/ols4/ontologies/mondo/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FMONDO_0005275 in OLS
To do:

[ ] Investigate why the hierarchical ontology mapping is not being respected
[ ] Identify the best solution to minimize term duplication across ontologies in the data
[ ] Implement solution and reduce the term duplication in the metadata and subsequently in the filters

Issue Discussion
No response
Please select the type of metadata improvement

[X] Standardization (normalizing free text to an ontology)
[ ] Augmentation (adding values for metadata fields missing values)
[ ] Clean up (addressing redundancy or messy metadata)
[ ] Structure (changing the structuring of the metadata to support front end UI features)

Meta URL
No response
Related WBS task
https://github.com/NIAID-Data-Ecosystem/nde-roadmap/issues/13
For internal use only. Assignee, please select the status of this issue

[ ] Not yet started
[ ] In progress
[ ] Blocked
[ ] Will not address

Status Description
No response
Request status check list

[X] This metadata improvement has yet to be discussed between NIAID, Scripps, Leidos
[ ] This metadata improvement does not need to be discussed between NIAID, Scripps, Leidos
[ ] This metadata improvement has been discussed/reported between NIAID, Scripps, Leidos
[ ] This metadata improvement has been implemented locally to generate data for review
[ ] This metadata improvement has been implemented on Dev
[ ] This metadata improvement has been implemented on Dev and the results have been reviewed and approved for staging
[ ] This metadata improvement has been implemented on Staging
[ ] This page/documentation/change has been approved for Production
[ ] This page/documentation/change has been implemented on Production

Examples of this issue:

Hepatitis B infection (MONDO) vs Hepatitis B (DOID)
HIV infection (NCIT) vs HIV infectious disease (MONDO)
Hypertension (NCIT) vs Hypertensive disorder (MONDO)

@DylanWelzel it looks like MeSH's role in this issue has mostly been resolved. Now it's just a matter of dealing with the duplication between ontologies. One potential approach is to use something like mydisease.info to map terms from the last resort ontology (NCIT) to preferred ontologies (MONDO)? This approach seemed to work for the Hypertension example: https://mydisease.info/v1/disease/NCIT%3AC3117?fields=mondo&size=10


Rerunning composite analysis doesn't work

What is the current behavior?
As reported by @TsafrirA, loading a composite experiment from the cloud service and rerunning the analysis doesn't work properly.
Steps to reproduce the problem
exps_t1 = []
exps_t2 = []
for q in (0, 2):
    exp_t1 = T1((q,), delays=np.linspace(0, 300e-6, 20))
    exp_t2 = T2Ramsey((q,), delays=np.linspace(0, 300e-6, 20))
    exps_t1.append(exp_t1)
    exps_t2.append(exp_t2)

batch = BatchExperiment(
    [
        ParallelExperiment(exps_t1),
        ParallelExperiment(exps_t2),
    ],
    backend=backend,
)

exp_data = batch.run()
exp_data.save()

...

exp_data_2 = ExperimentData.load(exp_id,service=service,provider=provider)
exp_data_2 = batch.analysis.run(exp_data_2)

This populates the main experiment data container but not the analysis results and figures of the child experiments. The current workaround is to turn on flatten_results.
What is the expected behavior?
All child experiment data should be correctly populated.

The cause for problems here is exp_data.save() because save only saves the children that were already added to exp_data, and adding new children is done concurrently. Doing exp_data.block_for_results().save() fixes it; if a major code refactor is on the way, I don't think this specific problem should be handled, but the way in which children are created.

The user wants to save a long experiment without waiting for it to complete and then load it and run the analysis later, so the block_for_results() fix won't work for this workflow. Since turning on flatten_results does work right now, I'm fine with addressing this in the refactor.


write_verilog_testbench is not defined in latest OpenFPGA release

I get the following error when I try to run make runOpenFPGA with the latest OpenFPGA release:
Command line to execute: write_verilog_testbench --file ./SRC         --reference_benchmark_file_path counter_output_verilog.v         --print_top_testbench         --print_preconfig_top_testbench       \
  --print_simulation_ini ./SimulationDeck/simulation_deck.ini         --explicit_port_mapping
Try to call a command 'write_verilog_testbench' which is not defined!
Fatal error occurred!
OpenFPGA Abort

It seems that the command write_verilog_testbench is deprecated.
What is the latest compatible OpenFPGA commit id to be used within SOFA project?

@abdullahyildiz You can find latest commit here: https://github.com/lnis-uofu/OpenFPGA/commit/ef3cbe708c9fd516500c09c22d97f1c6ee07d67d

When I try to run make runOpenFPGA with the OpenFPGA release https://github.com/lnis-uofu/OpenFPGA/commit/ef3cbe708c9fd516500c09c22d97f1c6ee07d67d, I get write_full_testbench is not defined error within openfpgashell.log:
openfpgashell.log

@abdullahyildiz Sorry for the inconvenience. I merged the pull request https://github.com/lnis-uofu/SOFA/pull/123
Now you should be able to use the latest OpenFPGA on master branch.

@tangxifan,
No problem. Thanks also for your support.
This time I get the following error:
 Write autocheck testbench for FPGA top-level Verilog netlist for 'counter'
Will use 78766 configuration clock cycles to top testbench
# Write autocheck testbench for FPGA top-level Verilog netlist for 'counter' took 0.00 seconds (max_rss 59.8 MiB, delta_rss +0.0 MiB)
Write Verilog full testbenches for FPGA fabric
 took 0.00 seconds (max_rss 59.8 MiB, delta_rss +0.0 MiB)

Command line to execute: --reference_benchmark_file_path counter_output_verilog.v         --explicit_port_mapping
Try to call a command '--reference_benchmark_file_path' which is not defined!
Fatal error occurred!
OpenFPGA Abort

Finish execution with 1 errors

The entire OpenFPGA flow took 1.46976 seconds

Thank you for using OpenFPGA!
1

Is something wrong with my setup?

@tangxifan,
I think the problem arises from a typo in L58 in generate_testbench.openfpga: https://github.com/lnis-uofu/SOFA/blob/45184c35ea578daecef76b26557b25fdbf6e8edd/FPGA1212_QLSOFA_HD_PNR/FPGA1212_QLSOFA_HD_task/generate_testbench.openfpga#L58
There should be a backslash at the end of the line.

@abdullahyildiz Thanks for pointing this out. Should fix it asap


Fix frame dragging being blocked when it overlaps another frame

If two faces are close together one face can be successfully tagged but the second face may be blocked because the first tag frame has a higher z-index than the image. This blocks the mouse over event and halts the dragging of the second frame. This can cause other issues, like releasing the mouse button but the frame drags with you.
Proposed fix is to dynamically change the z-index of previously created frames to hide them while the new frame is being drawn. Then revert the z-index after name has been entered.

Fixed this with some CSS magic and the :not selector. This has resulted in the manifestation of some other behaviors that may / may not need fixing. As an example, suppose you take a group photo with the "Work Squad" and you tag all the people in it with their name. Later, for whatever reason, you decide to select the entire group and tag it as Work Squad. Doing this will work and retain the old tags but hovering over the tagged region would only show "work squad". This specific behavior should be fixed by displaying all tag names behind the selector area.
Secondly, you can't start tagging by clicking inside another tag. The overlap area is okay, if you click outside of another frame you can then drag into it and won't be blocked. I'm inclined to leave this behavior as is; if you've got another tag within a tag you've really not using the plugin as intended.


Use new tooling system

┆Issue is synchronized with this Asana task

Yeah, see your point lol.

That should do it, @einari


CB 8438cordova plugin camera translation

CB 8438cordova plugin camera translation: cordova-plugin-camera

This will not be merged here


findspam.py: obfuscated_word(): new rule "obfuscated word"

Simple 1337 decoder for a small set of troll / phone support scam keywords
test/test_findspam.py: test case for the above

I ran an FP scan on some 20,000 old posts and it did not trigger on any of those.

Duh, appease flake8

I commented out the phrases with multiple words in them because this first cut only examines individual words. I also commented out AVG because it's so short as to be excessively FP-prone, and I don't have any samples of it being obfuscated anyway. This could be extended to examine multiple words and variations in what counts as a word delimiter but that will increase the overhead. We could also pull in the Unicode homographs library if we wanted to.

I ran this on my laptop for almost 10 hours and it didn't report any false positives. (Granted, it didn't report much else either. I'm guessing the posts were removed by the main Smokey so quickly that they did not make it to my instance, but there could be something wrong with the rule logic too.)

Rebase to resolve conflicts with master

I'm sorry I didn't get to reviewing this rapidly. At the time, I was quite busy with things which I'd already committed to accomplish. Then, once you merged it, I assigned looking at it a much lower priority.

@Makyen Thanks for the review. I have a more drastic refactoring in progress which addresses several of these concerns. I hope to be able to create a new PR next week.


Rename contribute.md to CONTRIBUTING.md part 1/2

Type of Change

[ ] New feature
[ ] Bug fix
[x] Documentation update
[ ] Refactoring
[ ] Hotfix
[ ] Security patch
[ ] UI/UX improvement

did not know the contributing file could also be saved in the docs folder, nice!

I didn't either @og-mrk told me.


feat: improvement in user dashboard

Related Issue

Closes: #768
Description of Changes

improvement in user dashboard
added pfp in case of new registered user
added booking card

Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Please provide any necessary screenshots to illustrate the changes made.

great work Rishu! You can check hacktoberfest dashboard the pR will be reflected!


Onesync, Script not working

Describe the bug
I have onesync enabled on my server and yes i do have the infinity one.
Everytime i launch my server it tells me, 'Couldn't start resource pma-voice, could not find dependency /onesync for resource pma-voice'
Expected behavior
I tried everything, been googling for a while but can't fix it myself.
Server Info:

Server Version: 4973

Can you double-check your server version to make sure it's actually updated this is only an issue on extremely old builds.


[Examples] Implement gtExamplesContained for RPackageTag

gtExamplesContained
gtExamplesAllContained
gtParametrizedExamplesContained

Wow that's fast! :) That makes sense, thanks.


Allow ScrollContainer to be clicked for focus and border

The SceneTree and FileSystem docks have focus borders automatically since TreeDialog is one of the few classes which provides this, and also offer focus-on-click. In my opinion the style of this works well with Godot and is potentially useful for checking what the user is currently doing - for example, if they are editing the SceneTree then that dock has focus.
In order to make the Inspector dock more consistent with this style, since it has a similar feel and context anyway, I have made it (a) clickable and (b) draw the same border when focused. This is a really useful feature for another PR I'm making soon which needs to recognise what dock the user is working in, but it certainly has other use cases (e.g. for plugins) as well and just looks nice.
Problems:

The border-focus stylebox is drawn underneath elements such as text boxes. I don't know if this matters, but it's something that could be fixed if necessary. This has now been fixed by using a more general and standard method for drawing the focus stylebox.

When doing something like dragging a slider immediately after something else was focused, focus returns to that area and not the Inspector. This probably doesn't matter though and, again, could be fixed. This still occurs but is no longer a problem, since recent updates have made focus changes more stable.

Update 2022-09-01: additionally, the focus border has been made available in ScrollContainer as a whole.

Fullscreen image for reference:

We discussed this in a PR meeting. This is probably good, needs an approving review.

This has now been generalised in order to make the focus border available in any use of ScrollContainer. I hope this is OK as I didn't make a proposal about it, but since this behaviour is consistent with Tree and ItemList (using the focus_bg theme property) I think it's a reasonable expansion that should be useful to Godot users and developers.
As a consequence, many more editor docks/panels now have focus borders which makes the editor more consistent and accessible.

Found a bug in TileSet editor:

Other than that it looks good.
Here's a rebased patch:
0001-scroll.patch.txt

Something went wrong and I became author of the commit.

That's weird, I suppose it was the way I applied the patch. Does it matter?

By the way, I have addressed your issue with the latest push. I thought that part of the TileSet editor was inconsistent with the rest of Godot anyway, and it could be unclear to users what the panel is if they scroll the header out of view. As you can see I have turned it into a proper scrollable sub-panel (separate case for each TileSet tool):

I think the problem is that you are ignoring clipping for the focus style. Even if you fix tile editor, this makes a generic problem with nested scroll containers and there might be other broken places.

this makes a generic problem with nested scroll containers

That's true - as far as I can tell it happens with Tree too, the focus behaviour of which I was replicating, but I haven't tested fully yet because I find Godot's UI nodes hard to use.

I just realised what you meant about ignoring clipping - yes, this is a problem and this solution is more of a hack than a proper fix. I'm not sure how else to get the focus border to show up.

New state of the TileSet editor, with changes to improve the scrolling behaviour:

Please let me know if this is big enough to be separated into its own PR.

The default theme no longer includes borders for ScrollContainers so there should not be a general problem with the slightly hacky method I used.

@ator-dev If it's fine with you, I can try to implement this on master
Of course I'll add you as Co-Author, because most of the code will be yours

Of course, I'd be delighted to see this merged! Go ahead @pafuent :)

Superseded by #97521.


Move Identity and AC to Friday

Excited for the event, thanks for putting this on!
Coincidentally I was already going to Reykjavik for a family trip this week 😄
Friday is the only day I can really participate in full and I would love to be fully part of the Identity & Access Control track. Have a few things and learnings I could share from my work on Ceramic there.
Would it be possible to move the Identity & Access Control to Friday?

Interested yes :) Can you tell me more about what the responsibilities of leading a track would entail?

Apologies for the slow response here. As you may have seen @oed, this track has been renamed to Building Apps on IPFS, and is not being lead by @bmann. Unfortunately we'll be keeping the track on Monday.
I'm going to close this, but would be happy to chat on Discord about your plan to participate 😄

Follow ups:

If you have a talk about ceramic you'd like to give, but can only be there on Friday, let me know.  If you're only in on Friday we could make a point of letting folks know you're around to chat about ceramic

Thanks for the update @b5 Mohsin from our team is giving a talk on the Building apps track: https://github.com/ipfs-shipyard/ipfs-thing-2022/pull/80
I might also submit something for friday.


TS 4.7.4 crashes if tsconfig extends non-existing path

Bug Report
if a tsconfig.json consists solely of an extends clause that extends a non-existing path, Typescript crashes with:
➜  dashboard git:(upgrade-ts-4.7) ✗ yarn tsc --noEmit --project tsconfig.cypress.json
yarn run v1.19.1
$ /Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/.bin/tsc --noEmit --project tsconfig.cypress.json
/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:96888
                throw e;
                ^

Error: Debug Failure. Expected [object Object] === [object Object]. Parameter symbol already has a cached type which differs from newly assigned type
    at assignParameterType (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:64862:26)
    at assignContextualParameterTypes (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:64827:21)
    at contextuallyCheckFunctionExpressionOrObjectLiteralMethod (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:65229:29)
    at checkFunctionExpressionOrObjectLiteralMethod (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:65208:13)
    at checkExpressionWorker (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:66805:28)
    at checkExpression (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:66707:38)
    at checkExpressionWithContextualType (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:66396:28)
    at inferTypeArguments (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:62906:39)
    at chooseOverload (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:63566:53)
    at resolveCall (/Users/gregorybeaver/Documents/GitHub/platform/dashboard/node_modules/typescript/lib/tsc.js:63403:26)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Command failed: node /Users/gregorybeaver/.yvm/versions/v1.19.1/bin/yarn.js tsc --noEmit --project tsconfig.cypress.json
➜

🔎 Search Terms
crash
🕗 Version & Regression Information

This is a crash
This changed between versions 4.4.4 and 4.7.4___
This is the behavior in every version I tried, and I reviewed the FAQ for entries about X___
I was unable to test this on prior versions because available time_

⏯ Playground Link
💻 Code

// We can quickly address your report if:
//  - The code sample is short. Nearly all TypeScript bugs can be demonstrated in 20-30 lines of code!
//  - It doesn't use external libraries. These are often issues with the type definitions rather than TypeScript bugs.
//  - The incorrectness of the behavior is readily apparent from reading the sample.
// Reports are slower to investigate if:
//  - We have to pare too much extraneous code.
//  - We have to clone a large repo and validate that the problem isn't elsewhere.
//  - The sample is confusing or doesn't clearly demonstrate what's wrong.

🙁 Actual behavior

🙂 Expected behavior

Duplicate of #49383.

That’s weird, it’s the same error as #49383 but the repros don’t seem at all related based on the analysis in the other issue.

thank you - I mis-diagnosed the error in my debugging, and this is indeed a dupe.


Question: Changing sequence

I suspect that I am showing my lack of c++ knowledge here so apologies in advance.
How can I update my sequence to a new sequence whilst my program is running?
JLed standard[] = {
    JLed(5).On().DelayAfter(2000),
    JLed(4).On().DelayAfter(1000),
    JLed(5).Off(),
    JLed(4).Off(),
    JLed(14).On().DelayAfter(2000),
    JLed(14).Off(),
    JLed(4).On().DelayAfter(1000),
    JLed(4).Off(),
};

JLed pelican[] = {
    JLed(14).Blink(500, 500).Repeat(3),
    JLed(5).Blink(500, 500).Repeat(3),
};

JLedSequence sequence(JLedSequence::eMode::SEQUENCE, standard);

Thanks

Currently this is not supported, but you could create two different  JLedSequence objects, e.g. sequence1 and sequence2 and mutually call Update() on just one of these.

I figured this would be the work around - Thanks!


Correlation AttributeError

I am struggling to get the Correlation to execute:

Here is the full error:
AttributeError: 'NoneType' object has no attribute 'total_seconds'
Error found at line 1 in cell 2.
AttributeError                            Traceback (most recent call last)
/tmp/ipykernel_35/575343315.py in
----> 1 C = correlation.CorrelationHeatmap(sdl_notebook_url=jupyter_notebook_url)
2 C.run()
~/.local/lib/python3.8/site-packages/seeq/addons/correlation/_seeq_add_on.py in init(self, sdl_notebook_url, df, datasource, seeq_url)
109         self.current_df = self.df_processed.copy()
110         self.current_signals = list(self.current_df.columns)
--> 111         self.coeffs_time_shifts_calc(self.max_time_str, self.time_output_unit)
112         correlation_fig = _heatmap_plot(pickle.dumps(self.coeffs_df), pickle.dumps(self.time_shifts_df),
113                                         time_unit=self.time_unit, lags_plot=False)
~/.local/lib/python3.8/site-packages/seeq/addons/correlation/_seeq_add_on.py in coeffs_time_shifts_calc(self, max_time_shift, time_output_unit)
328         if self.current_df.empty:
329             return
--> 330         lags, coeffs, sampling_time, time_unit, maxlags = lags_coeffs(self.current_df, max_time_shift, time_output_unit)
331         time_shifts = lags * sampling_time
332         self.actual_max_time_shift = None if max_time_shift is None else f"{maxlags * sampling_time} {time_unit}"
~/.local/lib/python3.8/site-packages/seeq/addons/correlation/_cross_correlations.py in lags_coeffs(df, max_time_shift, time_output_unit)
77     """
78     _validate_df(df)
---> 79     grid: float = pd.to_timedelta(to_offset(pd.infer_freq(df.index))).total_seconds()
80     sampling = pd.Timedelta(f'{grid}s')
81
AttributeError: 'NoneType' object has no attribute 'total_seconds'
(To show stack trace by default, set spy.options.friendly_exceptions to False)

what are the versions of SPy and seeq-causality?

I have a similar issue (SPy version <IP_ADDRESS>.1 and Correlation version 0.1.2):
AttributeError: 'DataFrame' object has no attribute 'query_df'
Error found at line 1 in cell 2.
AttributeError                            Traceback (most recent call last)
/tmp/ipykernel_215/575343315.py in
----> 1 C = correlation.CorrelationHeatmap(sdl_notebook_url=jupyter_notebook_url)
2 C.run()
~/.local/lib/python3.8/site-packages/seeq/addons/correlation/_seeq_add_on.py in init(self, sdl_notebook_url, df, datasource, seeq_url)
72                 sdl_notebook_url)
73             self.worksheet_url = get_worksheet_url(sdl_notebook_url)
---> 74             self.df = pull_only_signals(self.worksheet_url)
75             self.worksheet = spy.utils.get_analysis_worksheet_from_url(self.worksheet_url)
76             clear_output()
~/.local/lib/python3.8/site-packages/seeq/addons/correlation/_utils/_sdl.py in pull_only_signals(url, grid)
44     if df.empty:
45         return pd.DataFrame()
---> 46     df.columns = df.query_df['Name']
47     return df
48
/usr/local/lib/python3.8/site-packages/pandas/core/generic.py in getattr(self, name)
5485         ):
5486             return self[name]
-> 5487         return object.getattribute(self, name)
5488
5489     def setattr(self, name: str, value) -> None:
AttributeError: 'DataFrame' object has no attribute 'query_df'

both issues should resolve by upgrading the add-on. The current version is 0.1.4. Thus, you can run pip install seeq-correlation==0.1.4 in a terminal of the SDL project that runs the add-on.
Also, make sure that the SPy module is up-to-date. You will have to determine your specific version that corresponds to the Seeq server version from https://pypi.org/project/seeq/#history

That worked for me, thanks!


---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26605128-put-a-pull-zone-in-front-of-images?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F85909&utm_medium=issues&utm_source=github).

Dropping from Pivot. This isn't essential to that.


Multext reader returns map object

The tagged_sents and tagged_words methods should return a sequence type not a map object.
>>> nltk.corpus.brown.tagged_words()
>>> [('The', 'AT'), ('Fulton', 'NP-TL'), ...]
>>> nltk.corpus.multext_east.tagged_words("oana-en.xml", "universal")
 <map object at 0x10b34dfd0>
>>>

@stieglma: would you please look into this?

This seems to be a problem with Python 3. It can easily be fixed by wrapping the return value of the mentioned functions in list(...). This is also what I would do. But I have a question on this: When executing the tagged_words() function on the brown corpus it only shows the first two elements and not the whole list. With the multext-east reader it will always print the whole list. I couldn't figure out how you achieve this. Is it necessary that it works like that, or is it ok if the whole list is printed?

@stieglma, that's done with the lazy sequence API in http://www.nltk.org/api/nltk.html#module-nltk.util. I think lazy loading should be preferred except for very small corpora.

I created the pull request quite a while ago, did you just forget to merge it, or is something wrong with it?

Thanks @stieglma! I'm getting to it...

Thanks @stieglma


Reducing multiple observations in series: re-cycling previously created sens function

Hi JK,
If you reduce multiple objects in series, PyNOT re-creates the sensitivity function every time. Could you add an option where PyNOT uses a previously created sens function?

This should be the default behaviour. It is handled by the option "force" under "response"... If force = True, then the code will generate a new response function for each target. If False, then the code should use the one already generated. I'll double check that it has been implemented correctly.

This should be updated in the new revamped reduction flow as of version 1.0. Documentation still needs to be updated, sorry, I have been short on time.


IOU issues

Making list of IOU issues that exist on main

https://expensify.slack.com/archives/C049HHMV9SM/p1686833714894589

Going to close this out as these aren't critical to fix now and will follow standard procedure


ChatOpenAI models don't work with prompts created via ChatPromptTemplate.from_role_strings

System Info
LangChain version = 0.0.167
Python version = 3.11.0
System = Windows 11 (using Jupyter)
Who can help?

@hwchase17
@agola11
@UmerHA (I have a fix ready, will submit a PR)

Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[X] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
import os
os.environ["OPENAI_API_KEY"] = "..."

from langchain.chains import LLMChain
from langchain.chat_models import ChatOpenAI
from langchain.prompts import PromptTemplate
from langchain.prompts.chat import ChatPromptTemplate
from langchain.schema import messages_from_dict

role_strings = [
    ("system", "you are a bird expert"),
    ("human", "which bird has a point beak?")
]
prompt = ChatPromptTemplate.from_role_strings(role_strings)
chain = LLMChain(llm=ChatOpenAI(), prompt=prompt)
chain.run({})

Expected behavior
Chain should run

Not completely sure what you want to achieve, but I think you should use HumanMessagePromptTemplate or AIMessagePromptTemplate here.
See the docs for examples how to use this, e.g. https://python.langchain.com/en/latest/modules/chains/getting_started.html.


⚠ Bofrost.es has degraded performance

In fa15888, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1663 ms

Resolved: Bofrost.es performance has improved in 3364906 after 13 minutes.


Das_Geek: Watch dogukantemizlik.com

Das_Geek requests the watch of the watch_keyword dogukantemizlik\.com. See the MS search here and the Stack Exchange search here.

dogukantemizlik\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by double-beep in Charcoal HQ


Dto relation replacement

The DTO naming scheme seems to fit this better. Chose not to put these objects in a new directory since it seems like an antipattern when compared to storing them in the modules folder.

Closes #18


Set shm_size: 512mb so Chrome browser tests run

This PR sets shm_size: 512mb so that browser based tests run correctly (e.g. Jasmine unit tests and Capybara feature specs).
Docker allocates 64mb shared memory to containers by default, but recent versions of Chrome require more than this. Otherwise you'll start to see error messages complaining about an "invalid session id". In a previous discussion on Slack, it was informally agreed that 512mb seems to be the 'right sized' amount to allocate – but this was anecdotal, so other values may work equally well for our needs.
If the shm_size is too small, you'll get error messages that look something like this in your terminal:
NoSuchSessionError: invalid session id
    at Object.throwDecodedError (/govuk/whitehall/node_modules/selenium-webdriver/lib/error.js:522:15)
    at parseHttpResponse (/govuk/whitehall/node_modules/selenium-webdriver/lib/http.js:548:13)
    at Executor.execute (/govuk/whitehall/node_modules/selenium-webdriver/lib/http.js:474:28)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async thenableWebDriverProxy.execute (/govuk/whitehall/node_modules/selenium-webdriver/lib/webdriver.js:735:17)
    at async Object.runSpecs (/govuk/whitehall/node_modules/jasmine-browser-runner/index.js:116:9)
    at async Command.runSpecs (/govuk/whitehall/node_modules/jasmine-browser-runner/lib/command.js:187:5) {
  remoteStacktrace: '#0 0xaaaabaf6b1b0 <unknown>\n' +
    '#1 0xaaaabada13b0 <unknown>\n' +
    '#2 0xaaaabadc7fe4 <unknown>\n' +
    '#3 0xaaaabadc9864 <unknown>\n' +
    '#4 0xaaaabafa75f8 <unknown>\n' +
    '#5 0xaaaabafa9d98 <unknown>\n' +
    '#6 0xaaaabafa9acc <unknown>\n' +
    '#7 0xaaaabaf987e0 <unknown>\n' +
    '#8 0xaaaabafaa500 <unknown>\n' +
    '#9 0xaaaabaf8e080 <unknown>\n' +
    '#10 0xaaaabafc1790 <unknown>\n' +
    '#11 0xaaaabafc1950 <unknown>\n' +
    '#12 0xaaaabafdbbd4 <unknown>\n' +
    '#13 0xffffb0f28628 <unknown>\n' +
    '#14 0xffffb075501c <unknown>\n'
}
error Command failed with exit code 1.

This config needs to be applied to each service that needs to run Chrome. In this commit, I've added it to applications owned by the Publishing service. Other applications (including frontend applications) may also benefit from this config, but I didn't want to make assumptions about which applications need it and which don't.
More information about this problem is covered in this blog post:
https://thecurve.io/dealing-with-cryptic-seleniumwebdrivererrorinvalidsessioniderror-errors/

@KludgeKML FYI - I know we've spoken about this recently.
Another developer on my team (@jyoung-gds) was blocked with this error, so I've applied the config change for Publishing applications only. I didn't want to assume which frontend apps need it (e.g. which ones have browser tests, etc.) so if it's okay I'll leave that with you.
I've also added it to the troubleshooting guide, so hopefully it'll be discoverable for others with the same issue.


Support muti-level logger in azd

For current azd, the logger only has one level: output or not output.

Without "--debug" program parameter, there is no output. Customer will lack necessary information.
WIth "--debug" program parameter, there will be too much (hundreds or even thousands of lines) logs.

It's a reasonable request to support multi-level log in azd. Here are common used levels: info, warn, error.
And I found loggers for go lang:

https://github.com/sirupsen/logrus
https://github.com/uber-go/zap

FYI, In https://github.com/Azure/azure-dev/pull/4635 I am adopting log/slog which is leveled.  I used Info as the level everywhere during my conversion, but we could use other levels as well.
I would strongly prefer we use slog instead of taking a dependency on a third-party package.

Hi, @ellismg
Thanks for telling me this. I plan to adopt this to our feature branch: https://github.com/Azure/azure-dev/pull/4473


add debug build for room8266-wifi

I added a debug section [env:room8266-debug-wifi] to be able to compile it local. The release build section doesn't work local (for me).
Hope I got it right.

Added [env] sections for rack32-debug-wifi and room8266-debug-wifi for completeness. They should be according to your requirements.
room8266-wifi seems to work well.
rack32-wifi shows some strange outputs on serial when the captive portal is shown, but looks like it works.
[ 31834][E][WebServer.cpp:635] _handleRequest(): request handler not found
[ 32106][E][WebServer.cpp:635] _handleRequest(): request handler not found
[ 33026][E][WebServer.cpp:635] _handleRequest(): request handler not found
[ 42828][E][Parsing.cpp:283] _parseArguments(): arg missing value: 0
[ 42829][E][WebServer.cpp:635] _handleRequest(): request handler not found
[ 42855][E][WebServer.cpp:635] _handleRequest(): request handler not found
[ 58429][E][WebServer.cpp:635] _handleRequest(): request handler not found
[ 58727][E][WebServer.cpp:635] _handleRequest(): request handler not found

Not happy with that but have no clue ???


Missing "bg" for player.male and female.

The mod seems to work without a problem if only for the lack of the background "shadow" that the tileset has by default.
I dug around the tile_config.json from MSX++ DeadPeople and it seems to call for the "fg" and "bg" of the player_male and female, but your mod_tileset.json calls from your bodies.png which does not have the "bg" that the tileset has.
I'm not sure if this is what is causing the issue or if I missed something obvious during installation.
Hopefully it's a just a mistake on my end.

Hmm, I got the .png directly from SomeDeadGuy, so not too sure what I'm missing here. Thanks! I'll check with him and see if there is anything to fix :)

I appreciate it , sorry I couldn't be more specific with the issue.


every time I open dbeaver it has an upgrade

Is your feature request related to a problem? Please describe.
delay upgrades or do not push updates as often
Describe the solution you'd like
I want to open dbeaver, not upgrade it.
Describe alternatives you've considered
Have an option to always automatically upgrade, or only notify if n number of versions out of date.
Additional context
I use this program just about every day, and every other day there's an update, it's just too much.

Have you considered turning off the Automatic Updates Check in the Preferences menu?

its kind of annoying, maybe the default could be check off, not check on.. but yeah.. you can switch it.


[5.10] Add -experimental-skip-non-exportable-decls to lazy typechecking emit module jobs

Cherry picks of https://github.com/apple/swift-driver/pull/1465/ and https://github.com/apple/swift-driver/pull/1419.
Resolves rdar://115731361.

@swift-ci please test


EventGrid Trigger support

Hi James,
are you going to add a support of EventGrid Triggers?
If not, I could implement and provide a PR.
Regards,
Alexey

Will push out in beta later today.

I meant Event Grid, not Event Hub :-)
But do not care too much, I will try to add a support for Event Grid as well and provide a PR as soon as it is ready.

That would be awesome thank you!
Get Outlook for iOShttps://aka.ms/o0ukef

From: alexeymarkov<EMAIL_ADDRESS>Sent: Monday, December 23, 2019 2:57:24 PM
To: JamesRandall/FunctionMonkey<EMAIL_ADDRESS>Cc: james<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [JamesRandall/FunctionMonkey] EventGrid Trigger support (#105)
I meant Event Grid, not Event Hub :-)
But do not care too much, I will try to add a support for Event Grid as well and provide a PR as soon as it is ready.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://github.com/JamesRandall/FunctionMonkey/issues/105?email_source=notifications&email_token=AABZVV7RRNFL3R4IOWITGJLQ2C7UJA5CNFSM4J46A2P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRFURQ#issuecomment-568482374, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABZVV4G3C5XDJOF2YDE2QLQ2C7UJANCNFSM4J46A2PQ.


Trigger build through API

I guess this is a feature request vor the v3 API.
Expected Result
I can trigger a build through the API (POST or PUT).
Actual Result
Function as per https://docs.readthedocs.io/en/stable/api/v2.html#builds not (yet) available.

Yes. APIv3 will support many "writable" actions. We are working on the design of it and its implementation.
If you want to give us feedback, ideas or anything that you consider that we should care about when making APIv3, please comment here: https://github.com/rtfd/readthedocs.org/issues/4286 and/or its PR: https://github.com/rtfd/readthedocs.org/pull/4863
I'm closing this issue.

Then I suggest you link directly to those issues at https://docs.readthedocs.io/en/stable/api/v2.html where it says

If there are features you would like in v3, please get in touch in the issue tracker.

Thanks for the pointer. Will take a look.


Added support of dill for resource files

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What is the problem / what does the code in this PR do
Adds support for dill files in resources in get_resource/open_resource functions
Can you briefly describe how it works?
Usage is identical to pickle files
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

Update the docstring(s)
Update the documentation
Tests to check the (new) code is working as desired.
Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

Previously, it was not possible to store some of the scipy objects in pickle. In particular, RegularGridInterpolator. However, I checked now and it looks like now it works with standard pickle. I think it can still be useful, but up to you to decide.

@terliuk , looks fine to me, only codefactor has some security issues (like it has for pickle), would you say we need to worry about these?

In general, it the future it is better if we use dedicated formats, but i am not sure how realistic it is. My understanding is that dill/pickle does full serialization, so technically can contain malicious binary code/class inside. So given that we use pickle already, it shouldn't lead to new concerns in addition to pickle ones.

Right, sure, I think that summarizes it quite nicely. In the file-repos, we highly discourage the usage of such files, however supporting them in principle may not hurt. We should try depending on them as little as possible but e.g. dedicated scripts may benefit from this utility function. Otherwise people just import dill and do it manually.


:rocket: 10.1.0-beta.1

WARNING: Do not merge this PR. This is an automated release PR. It should be released using the "Publish" workflow.
Download release artifacts here
Steps for Publish:
You can update the changelog.md in this branch, run git log to get the latest changes:
git log --no-merges --oneline --pretty=format:'* %s by @%an' --since="<last release tag>" --until="release/10.1.0-beta.1"

When ready to publish, trigger Publish workflow with these variables:

Release version (version): 10.1.0-beta.1

Alternatively, you can trigger the workflow from Github CLI:
gh workflow run release-publish.yml -f version=10.1.0-beta.1 --repo Kong/insomnia

Release notes will be generated automatically based on the commit messages during publish. Remove any unwanted notes manually afterwards.

Conflicts? Merge branch step failed on the publish workflow? Try this...
Run locally:
# Make sure git remote is Kong/insomnia...

git checkout develop
git merge --no-ff release/<replaced with version>

# Solve merge conflicts ...
# If there's package-lock conflicts, run `npm install` and commit the package-lock changes

git push

(rebasing with latest develop)


Error when installing in Mathematica 13.0 for Mac OS X

Loved the package, have been using for years! I tried installing in my new computer and got the following error:
Import["https://raw.githubusercontent.com/jkuczm/\MathematicaTeXUtilities/master/BootstrapInstall.m"]

Installing TeXUtilities:

ProjectInstall::noprjpckg: The project has no package in the top-level directory with the name mathcing the name of the project specified in project's descriptor file (project.m)

$Failed

Version info
"Version" ->  "13.0.0 for Mac OS X ARM (64-bit) (December 3, 2021)",
"ReleaseID" -> "<IP_ADDRESS> (7522561,<PHONE_NUMBER>58)",

Stack trace
{\!\(\*
TagBox[
RowBox[{"Message", "[",
StyleBox[
RowBox[{"ProjectInstall", "::", "noprjpckg"}], "MessageName"], "]"}],
HoldForm]\), \!\(\*
TagBox[
RowBox[{"Print", "[",
RowBox[{"ProjectInstall", "[",
RowBox[{"URL", "[",
TemplateBox[{
        "\"https://github.com/jkuczm/MathematicaTeXUtilities/releases/\
download/v1.0.1/TeXUtilities.zip\""},
"URLArgument"], "]"}], "]"}], "]"}],
HoldForm]\), \!\(\*
TagBox[
RowBox[{
RowBox[{"ProjectUninstall", "[", "\<\"TeXUtilities\"\>", "]"}], ";",
RowBox[{"Print", "[",
RowBox[{"ProjectInstall", "[",
RowBox[{"URL", "[",
TemplateBox[{
         "\"https://github.com/jkuczm/MathematicaTeXUtilities/\
releases/download/v1.0.1/TeXUtilities.zip\""},
"URLArgument"], "]"}], "]"}], "]"}], ";"}],
HoldForm]\), \!\(\*
TagBox[
RowBox[{"<<", \
"\<\"/private/var/folders/51/hzcl27nj5rj75b7nv1l485_40000gn/T/\
m00000358291/BootstrapInstall.m\"\>"}],
HoldForm]\), \!\(\*
TagBox[
RowBox[{"\<\"Get\"\>", "\[Rule]",
RowBox[{"<<", \
"\<\"/private/var/folders/51/hzcl27nj5rj75b7nv1l485_40000gn/T/\
m00000358291/BootstrapInstall.m\"\>"}]}],
HoldForm]\)}

Unfortunately I don't have access to version 13 to troubleshoot this.
Does manual installation work?
Probably I should change installation method from ProjectInstaller to PacletInstall anyway.

Same problem with me. I had to use PacletInstall, which had no problem.

Yes, manual install worked for me
On Sun, Mar 27, 2022, 8:12 PM Jakub Kuczmarski @.***>
wrote:

Unfortunately I don't have access to version 13 to troubleshoot this.
Does manual installation
https://github.com/jkuczm/MathematicaTeXUtilities#manual-installation
work?
Probably I should change installation method from ProjectInstaller to
PacletInstall anyway.
—
Reply to this email directly, view it on GitHub
https://github.com/jkuczm/MathematicaTeXUtilities/issues/7#issuecomment-1080052522,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP22TF23W7IZT7D6BXAOFT3VCEBOTANCNFSM5RSWDBSQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Packages are checked and counted for every project

In a solution with n projects and one outdated package in every project it reports n outdated packages

... and also checked n times, which can be a performance issue.


Anerdw: Blacklist Epitome[\W_]+Hospital

Anerdw requests the blacklist of the keyword Epitome[\W_]+Hospital. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Epitome[\W_]+Hospital has been seen in 6 true positives, 0 false positives, and 0 NAAs.

Rejected by tripleee in Charcoal HQ. Reason: 'good initiative, but we want to blacklist exactly the expression which is currently watched'


Cron support

Amazon's sqsd supports scheduled jobs via a cron.yaml spec file. It looks like this would be pretty easy to support since there are at least a couple of npm packages supporting scheduling jobs according to a cron schedule.
Have the developers considered such a feature? Just wanted to check before I possibly started working on adding it.

This package designed to  receive  messages from queue and forward it to workers,
Probably you  want make  some simple independent project which put  messages to queue by schedule

My understanding was the package was designed to emulate the Amazon SQSD daemon, whose functionality is mostly as you describe but also supports cron.yaml. Hence my thinking that it might be worth supporting not just in a separate project but in this one, for a fuller AWS SQSD emulator.
But you've basically answered my question -- sounds like it's not on your radar. I may try implementing in a fork. You may see a PR at some point.
Thank you!


[FEATURE] AzureAiSearchEmbeddingStore - add "indexName" to the builder

Is your feature request related to a problem? Please describe.

Currently, it's not possible to override the index name without creating the entire index by yourself.
Describe the solution you'd like

I would like to be able to set the index name using AzureAiSearchEmbeddingStore.builder() like
AzureAiSearchEmbeddingStore.builder()
                .apiKey(properties.apiKey())
                .endpoint(properties.endpoint())
                .indexName(myIndexName)
                .dimensions(DIMENSIONS)
                .build();

or
AzureAiSearchEmbeddingStore.builder()
                .apiKey(properties.apiKey())
                .endpoint(properties.endpoint())
                .indexName(indexBuilder -> indexBuilder.name(myIndexName))
                .dimensions(DIMENSIONS)
                .build();

In other words, it would be great to still rely on the default implementation regarding the index settings however, at the same time, be able to override only the index name.

cc @jdubois

Thanks, the PR is available at #1084


fix(esl-core): register checks improvements

:tada: This PR is included in version 4.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ci: zombienet upgrade local

Summary by CodeRabbit

New Feature: Introduced sign_prehashed method for signing operations, enhancing performance and security.
New Feature: Added speed_mode parameter to submit_remote_order function, allowing more flexibility in order submission.
New Feature: Implemented add_remote_order_address function to add a remote order address to a target ID.
New Feature: Added get_remote_order_contract_address function to retrieve the remote order contract address based on the given gateway ID.
Test: Added test cases for verifying ECDSA signatures and adding a remote order address to XDNS.
Chore: Updated version numbers in the runtime configuration.
Refactor: Replaced hard-coded address with dynamic retrieval from Xdns module in verify_sfx_proof call.
Bug Fix: Modified purge_gateway_record function to process a single verifier overview correctly.

Pls include to CI pipeline, or maybe on special label? then good to go!


Merge conflict codelens not clickable

Create a standard git merge conflict
:bug: Open File via SCM resource group inline menu shows option to Resolve in Merge Editor but no codelenses
:bug: closing and reopening the file by clicking on the resource from the SCM view (not the inline menu action), I get the codelenses, but they are not clickable

https://user-images.githubusercontent.com/30305945/217898589-599a6d00-2812-4418-9d39-583f0965c257.mp4

@chrmarti that's no extension has registered the commands

I cannot repro, I'll close for now and reopen if I see it again.


0.6 "roadmap"

aka "things I want to do before releasing 0.6":

[x] Merge all PRs, obviously.
[x] Move the RawBitFlags trait to _internals.
[x] Reexport the proc-macro from the main crate.

[ ] Update documentation to discourage direct dependencies on on enumflags2_derive.
Is there a way to warn about this? Perhaps put internal in the macro name and then remove it when reexporting? #[deprecated] and #[allow(deprecated)] when reexporting? (does that even work?)
[x] Update examples.

[ ] Implement TryFrom as outlined below

A suggestion/question, since the minimum rustc version is being bumped with this release: any interest in implementing the TryFrom fallible conversion traits?

I'm not sure what you're suggesting here? TryFrom<repr_int>? TryFrom<BitFlags<T>> for T?

Seems overkill maybe but you could always deprecate the proc-macro crate and release the new one under a different name.

Actually, the crates.io name and the source code name don't have to be the same. The phenomenon is most commonly seen with hyphens vs underscores, but it's not limited to that.
This could be an opportunity/excuse to drop the 2 in enumflags2 from everywhere but crates.io (and users' Cargo.tomls).

Is there a way to warn about this? Perhaps put internal in the macro name and then remove it when reexporting?

Hm not actually sure, can you rename with #[macro_export()]? pub use macro as something; doesn't even work in 2018 (yet?) :(

It seems to work in 2015, though. See the reexport-derive-internal-in-name branch.

This could be an opportunity/excuse to drop the 2 in enumflags2 from everywhere but crates.io (and users' Cargo.tomls).

Ooh yeah that would be nice.

What do you think about naming the macro itself BitFlags? I might do these two changes, but I'm not quite sure about the potential cons here.

On Wed, Aug 28, 2019 at 09:00:16AM -0700, arcnmx wrote:

Also regarding TryFrom, I tried and failed.

I am currently implementing a workaround with a declarative macro.


Added Send+Sync to stream readers

Implement Send+Sync for stream readers without unsafe code

Codecov Report

Merging #5 (eb7c31f) into master (fd2c316) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   80.99%   80.99%
=======================================
  Files          13       13
  Lines        3220     3220
=======================================
  Hits         2608     2608
  Misses        612      612

Impacted Files
Coverage Δ

src/async_readers/mod.rs
67.23% <ø> (ø)

src/async_readers/ardr_futures.rs
92.32% <50.00%> (ø)

src/async_readers/ades_futures.rs
93.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2c316...eb7c31f. Read the comment docs.


Add option to turn off MSAA antialiasing because it has big fps drop

Anti-aliasing is not enabled in current dev builds of FrogLord, and had only been enabled in previous dev builds of FrogLord for testing purposes. However, I'll consider adding a settings menu with the ability to enable/disable it.

i checked "master", it branch still uses MSAA

it has around 30-60 fps

master does not always reflect the state of FrogLord, as often changes are made on other branches (sometimes taking months at a time) before they get merged into master.