Improve nullability & list API

Motivation
Current API tries to describe nullability & list using booleans.
t.field('foo', {
  nullable: boolean,
  list: boolean | boolean[]
})

Here's how the current API can be used:
import { objectType } from '@nexus/schema'

export const Test = objectType({
  name: 'Foo',
  definition(t) {
    t.string('a') // String
    t.string('b', { nullable: false }) // String!
    t.string('c', { list: true }) // [String]
    t.string('d', { list: true, nullable: false }) // [String]!
    t.string('e', { list: [true] }) // [String!]
    t.string('f', { nullable: false, list: [true] }) // [String!]!
  }
})

This can quickly become very unintuitive. I actually had to quickly jump in a playground to remember the API.
Proposal n°1
Replace the current API with the following two simple constructors: nonNull() & list(), inspired from https://docs.graphene-python.org/en/latest/types/list-and-nonnull/.
While its usage is slightly more verbose, it's also much clearer.
Usage example:
import { objectType, list, nonNull } from '@nexus/schema'

objectType({
  name: 'Foo',
  definition(t) {
    t.field('a', { type: 'String' }) // String
    t.field('b', { type: nonNull('String') }) // String!
    t.field('c', { type: list('String') }) // [String]
    t.field('d', { type: list(nonNull('String')) }) // [String!]
    t.field('e', { type: nonNull(list('String')) }) // [String]!
    t.field('f', { type: nonNull(list(nonNull('String'))) }) // [String!]!
  }
})

The biggest con with this proposal is that it doesn't seem to support the t.{scalars} shorthands at all since the types are now wrapped in list() and nonNull() types. Here's a quick illustration:
t.string('myField', { /*no type property, so we can't express list or nullability*/ })

Did I maybe miss something that would keep this proposal usable with the scalar shorthand? We could enable something like:
t.string('somefield', {
  listOrNullability: list(nonNull()) // [String!] - Please, ignore the terrible `listOrNullability` field name, it doesn't matter here
})

But I'm not sure that's intuitive either...
Proposal n°2
The current API already supports shorthand for list fields, using the t.list.*. We could expand on the previous idea and allow the following expressions:
import { objectType } from '@nexus/schema'

objectType({
  name: 'Foo',
  definition(t) {
    t.string('a') // String
    t.nonNull.string('b') // String!
    t.list.string('c') // [String]
    t.list.nonNull.string('d') // [String!]
    t.nonNull.list.string('e') // [String]!
    t.nonNull.list.nonNull.string('f') // [String!]!
  },
})

I honestly don't like very much the chaining style of this API, which makes the readability fairly hard. But at least it keeps supporting the scalar shorthands which I find very useful to reduce the boilerplate already created by the code-first paradigm.
Proposal n°3
It's very unlikely that we'll want that, but just to be exhaustive, we could as well allow the SDL representations:
import { objectType, list, nonNull } from '@nexus/schema'

objectType({
  name: 'Foo',
  definition(t) {
    t.field('a', { type: 'String' }) // String
    t.field('b', { type: 'String!' }) // String!
    t.field('c', { type: '[String]' }) // [String]
    t.field('d', { type: '[String!]' }) // [String!]
    t.field('e', { type: '[String]!' }) // [String]!
    t.field('f', { type: '[String!]!' }) // [String!]!
  }
})

Cons:

No support for scalar shorthands either
No support for type reference using the actual values (as opposed to references using type names)
Could blow up the union type member threshold very quick (which is around 100k I think)
Cannot type-safely support nested arrays (which could be infinitely nested) without blowing up the union type member threshold even quicker

Let us know if you have better proposals and/or which one you prefer here 🙌

Did I maybe miss something that would keep this proposal usable with the scalar shorthand?

t.list.string('somefield', {}) // [String]
t.nonNull.string('somefield', {}) // String!
t.list.nonNull.string('somefield', {}) // [String!]
t.nonNull.list.nonNull.string('somefield', {}) // [String!]!

Playing with some other vocabulary:
t.guaranteed.string('somefield', {}) // String!
t.list.guaranteed.string('somefield', {}) // [String!]
t.nonNull.list.guaranteed.string('somefield', {}) // [String!]!

t.sure.string('somefield', {}) // String!
t.list.sure.string('somefield', {}) // [String!]
t.sure.list.guaranteed.string('somefield', {}) // [String!]!

Also we'll need an inverse. For example imagine the user has global default to be non-nullable.
Again playing with vocabulary:
t.nullable.string('somefield', {}) // String
t.list.nullable.string('somefield', {}) // [String]
t.nullable.list.nullable.string('somefield', {}) // [String]

t.maybe.string('somefield', {}) // String
t.list.maybe.string('somefield', {}) // [String]
t.maybe.list.maybe.string('somefield', {}) // [String]

t.optional.string('somefield', {}) // String
t.list.optional.string('somefield', {}) // [String]
t.optional.list.optional.string('somefield', {}) // [String]

-- edit haha this is your no.2 proposal 🙈

After a call with @jasonkuhrt, here's all the proposal we've found (some overlapping with the current ones):
// Option 1
t.null.list.nonNull.field('a', {
  type: 'Foo',
  resolve() {}
})

// Option 2
t.field('a', {
  type: nonNull(list(nonNull('Foo'))),
  resolve() {}
})

// Option 3
t.field('a', {
  type: type.nonNull.list.nonNull.ref('Foo'),
  resolve() {}
})

// Option 4 (using proxy)
t.nonNull.list.nonNull.Foo('a', {
  resolve() {}
})

Current preferred choices: 1 & 2 (given the ):

We think option 1 (t.list.nonNull.*) should be what most users should be using so that the API stays symmetrical between scalars shorthand and t.field
Option 2 (list(nonNull(...))) will be kept as lower-level primitives that Option 1 will use and that plugins and/or custom use-cases should be using.

@tgriesser WDYT?

I feel like option 1 starts to get a little confusing / ugly / adds complexity to the builder internals, whereas option 2 is much clearer / explicit.
I almost wish that the t.list. convenience API didn't exist, and we just enforced things always be added as part of the field-level config (similar to #592).

@tgriesser how do you use option 2 with any of the scalar shorthands? eg: t.string('foo')

That's a good point, hadn't considered that. I guess you'd need to be verbose and do:
t.field('foo', {
  type: nonNull(list(nonNull('String')))
})

In that case, if you think it's worth it. I'm fine with option 1, in addition to adding option 2... and so just to clarify t.null.list.notNull.string('foo') would evaluate similar to the fn calls, and be [Foo!], correct?

and so just to clarify t.null.list.notNull.string('foo') would evaluate similar to the fn calls, and be [Foo!], correct?

[String!] I think you mean? If so, yep!

In that case, if you think it's worth it.

The other option is removing scalar shorthands altogether and forcing everyone down .field. Not saying I favour that but it is technically an option here.

We're going to have to decide what this means:
t.null.list.notNull.field('foo' {
  type: notNull(list('Bar'))
})

don't allow .field to be used with shorthands
wrap shorthands around type config: null(list(notNull(nonNull(list('Bar'))))). Notice the doubling of nonNull... pretty confusing, probably a runtime error since that cannot be representing in GraphQL.

This is somewhat off topic but it came up in discussing with @Weakky (my wacky ideas not his! hah): On the other hand, with shorthands, the only remaining use case for explicit type config by humans (programmatic usage is another story) is object type references. Nexus is so close to supporting shorthands for those too though:
t.null.list.notNull.Bar('foo' {
  resolve() { ... }
})

foo: [Bar!]

One nice thing is that it gets the API further away from the problem/criticism I just mentioned above. Further because by not using type mostly users mostly avoid the case of it+shorthands ambiguity.

The other option is removing scalar shorthands altogether and forcing everyone down .field. Not saying I favour that but it is technically an option here.

Yeah, I've definitely thought about it. AFAIK it's what graphql-ruby does. I think it's also reasonable to say that if you need to override the nullability / list(ability)? of a type, you just use t.field and decorate the type.

We're going to have to decide what this means:

don't allow .field to be used with shorthands

Yeah I'd say if we do support this, we'd allow one or the other, not both. Similar to how we currently warn if you do both t.list and list: true

Notice the doubling of nonNull... pretty confusing, probably a runtime error since that cannot be representing in GraphQL.

Don't want to do do this (combining chaining + type), but just fyi wrapping nulls in nulls GraphQLNonNull(GraphQLNonNull(t)) is a no-op in schema definition/construction.

On the other hand, with shorthands, the only remaining use case for explicit type config by humans (programmatic usage is another story) is object type references. Nexus is so close to supporting shorthands for those too though:

it's potentially visually confusing to have t.Bar vs type: Bar. The alias is really only intended for frequently accessed scalars t.date / t.json, or to hide complex logic t.connectionField.
Also, with the alias you lose the jump-to-definition. When you use it on t.Bar you go to this abstract auto-generated thing which is already a source of confusion, vs. jumping on type: Bar which brings you to the object type def.
I'd say I find the jump to definition of the field's type one of the most important ergonomic dev features when creating a schema, and I wouldn't want to use t.Bar. Also, there's many types that are infrequently used types that'd show up in autocomplete, and additionally if you rename the type, you're now calling a non-existent method and things won't run and the types won't update and it becomes a mess.

I'd say I find the jump to definition of the field's type one of the most important ergonomic dev features when creating a schema, and I wouldn't want to use t.Bar. Also, there's many types that are infrequently used types that'd show up in autocomplete, and additionally if you rename the type, you're now calling a non-existent method and things won't run and the types won't update and it becomes a mess.

Yeah great points. Overcoming any of this wouldn't be trivial.

I think it's also reasonable to say that if you need to override the nullability / list(ability)? of a type, you just use t.field and decorate the type.

It feels like creating lists of scalars, or adjusting its nullability, is a pretty common pattern.
I always wonder about this: If a significant part of my codebase is using one style, it has a cognitive cost to be using another style. The fewer use-cases there are for the "sugar" of t.<scalar> the less appeal it seems to hold.
Option 3 held some appeal to me because it allowed for not having to learn two APIs. But I realized that option 3 is a pain for programmatic usage, whereas option 2 is good for that.

I have a different proposition. What about converting the nullable field to:
nullable: boolean | { list: boolean, type: boolean }

Basically, true means both are nullable and if you need fancy stuff you use the object.
You can make it fancier by detecting if list: true in the config and changing the type based on that.
I also agree that the .list should not be a thing. I also think required should be removed.

@Weakky @jasonkuhrt just making sure my previous comment is not forgotten. I am really not a fan of the type wrapping :/

@Sytten Hey, Composable functions are the way this is going to go for type property configuration. I think there's some strong points in its favour that @tgriesser is fond of. IMO the strongest points are its flexibility and simplicity, very amenable to building higher abstractions with.
At the same time the short hand chaining will remain in place.

Hello @jasonkuhrt, how are you doing?
A little question for you, does the required: true or list: true will be deprecated at some point?
Thank you


[REGRESSION]: Gradle V3 build task failure message reports "Code analysis failed" for all failures

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
Gradle
Breaking task version
3.204.0
Last working task version
3.200.0
Regression Description
Any failing build reports "Code analysis failed". PR 16078 attempted to improve the task failure reporting, but as far as I can tell it did not add any new information to the failure, and confusingly reports that "Code analysis failed" even if the build failed for another reason.
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
Windows 11
Relevant log output
> Task :product:GradlePlugin:test FAILED
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':product:GradlePlugin:test'.
> There were failing tests. See the report at: file:///D:/a/_work/1/s/obj/AnyCPU/GradlePlugin/reports/tests/test/index.html

* Try:
> Run with --scan to get full insights.

BUILD FAILED in 23m 11s

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
940 actionable tasks: 940 executed
Error: The process 'D:\a\_work\1\s\_BuildCommon\path1st\gradlew.bat' failed with exit code 1
    at ExecState._setResult (D:\a\_work\_tasks\Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4\3.231.0\node_modules\azure-pipelines-task-lib\toolrunner.js:943:25)
    at ExecState.CheckComplete (D:\a\_work\_tasks\Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4\3.231.0\node_modules\azure-pipelines-task-lib\toolrunner.js:926:18)
    at ChildProcess.<anonymous> (D:\a\_work\_tasks\Gradle_8d8eebd8-2b94-4c97-85af-839254cc6da4\3.231.0\node_modules\azure-pipelines-task-lib\toolrunner.js:839:19)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1100:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:304:5)
Result Attachments will be stored in LogStore
Run Attachments will be stored in LogStore
##[error]Code analysis failed. Gradle exit code: -1. Error: Error: The process 'D:\a\_work\1\s\_BuildCommon\path1st\gradlew.bat' failed with exit code 1

Full task logs with system.debug enabled
N/A
Repro steps
No response

Hi @bannus  thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.


4: Host select nr of questions

As the host, I see a screen that gives me an overview over the different questions types. I can choose how many of each question type we want in the game. Once I have the right amount, I can start the answering-phase according to the question types I have selected.

[x] sopra-fs23-group-24/server#62
[x] sopra-fs23-group-24/client#31
[x] sopra-fs23-group-24/client#52
[ ] sopra-fs23-group-24/client#60
[ ] sopra-fs23-group-24/client#59

dcca233368bd2283e6bd153e9f1f178b16ff7e9f

2765190
a4c8940


Laravel 5.2 Update

Fix #19

+1 To this PR. Had to make the same updates in the src to get it working with 5.2. Would be good if this could be merged for others to use.

A good merge, for a good weekend! :smile:


Bug: console.log() in authentication method

Describe the bug
It looks like a console.log() was left in the convertAuth method here:
https://github.com/surrealdb/surrealdb.js/blob/d4dd76b6d9438023b9639d75c09e50db3f8dee00/src/types.ts#L52
It was added in the following commit:
4fd74e4843c2599865aa7634385499817d334407
Steps to reproduce
Log in and the authentication details will be logged to the console.
Expected behaviour
Authentication details should not be logged to the console.
SurrealDB version
surrealdb-2.0.0-alpha.7
JavaScript SDK version
1.0.0-beta.19
Contact Details
via this github issue
Is there an existing issue for this?

[X] I have searched the existing issues

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry about that! Will get it removed 😅

@ntorrey I added a linting rule which will prevent this from happening in the future!


Check how authentication attributes are restored in addition to user attributes

In the ProfileHelper component...

Hi Jerome, I have create pull request #1110 for this issue. It's for branch 2.2.x. If you find it OK, I can add another one for master later.
I just noticed one thing: The 2.2.x branch now contains version 2.3.0-SNAPSHOT, so we should probably create a new branch after the merge. Or create it before and then target the PR against the new branch. I'll leave it up to you...

The PR is good, see my minor comments to address. Please open a new PR for the master before I merge anything (you don't need to make things backward-compatible for the master branch).
Yes, the 2.2.x is now at 2.3.0-SNAPSHOT as there is already a new backward-compatible change in it. I think I'll cut a 2.3.0 release after I merge and test your changes.

Hi! Thank you for the review, I'll have a look and fix the remaining issues, then make a new PR for master.

Hi Jerome, here is the pull request for master: https://github.com/pac4j/pac4j/pull/1112.
It contains the same changes, ported from 2.2.x, plus removal of the 3 deprecated methods and adequate adjustments in clients (one more parameter).


Simplify info configs

Simplify the configuration file to declare info related settings to be simple strings that can be used as key in plugin function.
This will make it possible to get rid of eval() as well as improve readability of the .ini files.

Complicated return value from gateways like linkedin or vkontakte leads the parsing bloated. Appears current implemented method is simpler.


upgrade to angular 8 and using Ivy

hi,
I got this error after updated my project to angular 8 and enabling Ivy compiler:
ERROR in node_modules/ng2-jalali-date-picker/date-picker.module.d.ts(7,22): error TS-996002: Appears in the NgModule.imports of UserDetailsModule, but could not be resolved to an NgModule class
src/__ng_typecheck__.ts(33,60): error TS2344: Type '"_modal"' does not satisfy the constraint '"onClick"'.

Hi thanks,
I haven't tested it with angular 8 yet
can you provide a demo in stackblitz?

I can't because it wont be compiled and the error I sent, happened on compile time

If you found the problem please create a PR.

it is something about the code,
I think u must update it

We are here to collaborate and improve the project together

I just updated my project to Angular 9 and since Ivy is the default rendering engine and Renderer is no longer available my project doesn't work anymore. As far as I know, migrating from Renderer to Renderer2 is not an issue. Can you please update to Renderer2?

I think this link might help:
https://angular.io/guide/migration-renderer

My project broke too after upgrading to angular 9 I see there is also a pull request to solve this problem it's not much work mostly done by angular cli. can you please update the project to work with angular 9.

It has been fixed through #121 #122 #127
Have you  installed v2.4.2?

Yes, I have.
The problem still exists.
I even checked with a fresh angular 9 project to make sure the problem is not just related to my project.
It also seems the jalali-moment library is broken as well. it gives the below error.
ERROR TypeError: Cannot read property 'calSystem' of undefined
    at isInputJalali (jalali-moment.js:579)
    at makeMoment (jalali-moment.js:590)
    at jMoment (jalali-moment.js:672)
    at UtilsService.getDefaultDisplayDate (ng2-jalali-date-picker.js:432)
    at DatePickerComponent.init (ng2-jalali-date-picker.js:1772)
    at DatePickerComponent.ngOnInit (ng2-jalali-date-picker.js:1696)
    at callHook (core.js:4726)
    at callHooks (core.js:4690)
    at executeInitAndCheckHooks (core.js:4630)
    at refreshView (core.js:12013)

can you maybe clone the empty ng9 project that I created and see if you can get it to work?
you might also want to check out this pull request

sorry I don't use this package anymore and i cant spend enough time for this
but i fixed the problem with jalali-moment
the mentioned PR has too much changes and i couldn't test it completely,
if you can fix the problems please let me know<EMAIL_ADDRESS>

@fingerpich Hey, it seems the problem is solved.  looks like it was jalali-moment package and not the date-picker. Thanks a lot


Add the ability to set a legacy alias for the command with /wss instead of /wsm

Add the ability to set a legacy alias for the command with /wss instead of /wsm in the config file for those who are used to using /wss in the original plugin.

I will fix this tomorrow. In addition, the minecraft community and fawe api's aggressive version requirements for dependent libraries are painful, and I may not be able to simply build this for lower versions (1.16.5), because fawe's maven repository deletes the 1.x archives (https://repo.papermc.io/#browse/search=keyword%3DFastAsyncWorldEdit). I need to check my build magic to make it work on 1.16.5.
By the way, it would be great if you can provide jdk version and server version information

Sure, our server version is currently using:
Minecraft 1.16.5
Java 1.16 JDK
On Thu, Aug 11, 2022 at 12:00 PM Cat Ericka @.***>
wrote:

I will fix this tomorrow. In addition, the minecraft community and fawe
api's aggressive version requirements for dependent libraries are painful,
and I may not be able to simply build this for lower versions (1.16.5),
because fawe's maven repository deletes the 1.x archives (
https://repo.papermc.io/#browse/search=keyword%3DFastAsyncWorldEdit). I
need to check my build magic to make it work on 1.16.5.
By the way, it would be great if you can provide jdk version and server
version information
—
Reply to this email directly, view it on GitHub
https://github.com/CatEricka/WorldEditSelectionManager/issues/8#issuecomment-1212184279,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEH3NEQD2KDN5UO6FDTBCSDVYUPQVANCNFSM56ISRXHQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Builders Horizon
Content Development Building Team
Builders Horizon
e: @.***
discord.gg/Me3wFBe http://discord.gg/Me3wFBe [image: Facebook icon]
https://www.facebook.com/BuildersHorizon [image: Twitter icon]
https://twitter.com/TheMCBuildTeam [image: Youtube icon]
https://www.youtube.com/c/BuildersHorizon
[image: Banner] https://twitter.com/TheMCBuildTeam

Fixed.
https://github.com/CatEricka/WorldEditSelectionManager/releases/tag/1.2.0

I don't have time to test this, feedback is welcome


How can I use custom stub files?

lsp pyright do not support django stubs by default, variables like objects in django model are not recognized. I copied django stub files from vscode directory to sublime lsp-pyright directory, and created a METADATA.toml, It works.
from:
~/.vscode/extensions/ms-python.vscode-pylance-2021.3.3/dist/bundled/stubs/django
to:
~/.config/sublime-text-3/Package Storage/LSP-pyright/14.16.0/language-server/node_modules/pyright/dist/typeshed-fallback/stubs/django/django
The structure is here:
django
|--- django   <------- copied from vscode directory
|--- METADATA.toml
the content of METADATA.toml is:
version = "0.1"
python2 = true
python3 = true

But this is a dirty change to plugin and will be cleaned when the plugin upgrades. I noticed pyright supports stubPath setting, and there is a entry in LSP-pyright.sublime-settings "python.analysis.stubPath": "./typings", so I tried to create a directory typings in my project directory and put the django stub directory which I created in previous step into typings directory, it not works. And I tried create a new directory and set stubPath pointing to it, not works also.
So can you help me to solve this problem? Or support django and some common packages like numpy, pandas, matplotlib directly in the LSP-pyright plugin?

so I tried to create a directory typings in my project directory and put the django stub directory which I created in previous step into typings directory, it not works. And I tried create a new directory and set stubPath pointing to it, not works also.

Did you restart the server or ST?

Yes, I restarted ST.

project root dir
|--- typings
|   |--- django
|       |--- __init__.py
|       |--- ... many other dirs
|--- other project files/dirs

For the default settings, I think the above structure should work.

Great!!! Thank you!


Variable view fixes

variable view will stay as long as you have a notebook open (not necesarily active)
jupyter variables tab will always be named 'Jupyter: Variables'

For #4458, #4562
The new behavior for the Variable View is this:

It will stay as long as you have a native notebook opened, it goes away if you close them all.
It doesn't update if you go to another editor (text, interactive window, data viewer, settings), only when you go to another notebook.

It has some inconveniences:

Open a notebook A, run it and look at the variables
Open the data viewer
Open a notebook B, run it and look at the variables
Go back to the data viewer
You're now looking at the data viewer with a variable from notebook A, while the variable view shows the variables from notebook B

Open a notebook A, run it and look at the variables
Open the interactive window
Open the variable view in the interactive window
You have two variable views open, some users might get confused

The first case feels rare enough to don't matter, and the second one could be done with the previews behavior, but it was less likely.

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[x] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

@joyceerhl I don't get the colon, and do get the tooltip

I checked out your branch and built it, and I get the leading colon even in the terminal panel... wat?

I don't get that either

Codecov Report

Merging #5006 (4fd3844) into main (25e2d48) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #5006   +/-   ##
=====================================
- Coverage     76%     76%   -1%
=====================================
  Files        404     404
  Lines      26772   26775    +3
  Branches    3871    3871
=====================================
- Hits       20461   20445   -16
- Misses      4696    4712   +16
- Partials    1615    1618    +3

Impacted Files
Coverage Δ

...client/datascience/commands/activeEditorContext.ts
90% <100%> (+<1%)
:arrow_up:

src/client/datascience/constants.ts
99% <100%> (+<1%)
:arrow_up:

src/client/common/cancellation.ts
82% <0%> (-4%)
:arrow_down:

src/client/datascience/jupyter/jupyterServer.ts
75% <0%> (-4%)
:arrow_down:

...rc/client/common/process/pythonExecutionFactory.ts
83% <0%> (-4%)
:arrow_down:

src/client/datascience/jupyter/jupyterExecution.ts
70% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/notebookStarter.ts
77% <0%> (-2%)
:arrow_down:

src/client/datascience/jupyter/jupyterSession.ts
83% <0%> (-2%)
:arrow_down:

...lient/datascience/jupyter/jupyterSessionManager.ts
72% <0%> (-2%)
:arrow_down:

...datascience/notebookStorage/nativeEditorStorage.ts
80% <0%> (-1%)
:arrow_down:

... and 3 more

@DonJayamanne that was because of @IanMatthewHuff's comment here:
https://github.com/microsoft/vscode-jupyter/pull/5006#discussion_r586582009

@DavidKutu
I think you have misunderstood @IanMatthewHuff comments.
I think his sugestion was as follows
 private updateNativeNotebookContext() {
        this.hasNativeNotebookOpen.set(this.vscNotebook.notebookDocuments.some(isJupyterNotebook)).ignoreErrors();

I.e. ensure the flag is set only if the notebooks are ones that we opened i.e. viewType === ''jupyter-notebook'`
@IanMatthewHuff please correct me if i'm wrong.

@DonJayamanne I actually did suggesting looking for everything that was 'native' off of the editor provider. Figured that would give us all the native editors that were ours that were open. However your suggestion is better with just checking for jupyter-notebook type off the vsc api. Forgot that we could do that. And I don't want to have to add our own selection on our type.

@DonJayamanne @IanMatthewHuff
Done


Async image loading - need for componentWillUnmount

Is this a bug report or a feature request?
bug report
Have you read the guidelines regarding bug report?
Yes
Have you read the documentation in its entirety?
Yes
Have you made sure that your issue hasn't already been reported/solved?
Yes
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
Both
Is the bug reproductible in a production environment (not a debug one)?
Yes
Have you been able to reproduce the bug in the provided example?
To be honest, haven't tried, hear me out...
Environment
Environment:
React: 16.5.0
React native: 0.57
react-native-render-html: 3.10.0
Target Platform:
Android (multiple)
iOS (12/ 10.3.3)
Steps to Reproduce

have an RenderHTML with multiple images that occupies the JSThread
before all the images are loaded, the user is able to perform actions between image loads (ie unmount RenderHTML)
React throws a warning because RenderHTML tries to setState on an unmounted component

Expected Behavior
The not-yet-fully-rendered component unmounts correctly.
Actual Behavior
RenderHTML tries to set its state after it's unmounted.
"Warning: Can't call setState (or forceUpdate) on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.%s, "

Fix
I could submit a pull request for this, but there might be a better fix I don't know about.

HTML.js needs a state of "mounted"
at componentWillUnmount, set state.mounted to false
in registerDOM, after the async call:

let response = await fetch(uri);
if(state.mounted) return undefined;

Demo
I'll provide a reproducible demo next week
LE (Fix # 2):
Because of React's synchronous nature, it's impossible to setState before the async workload is done, in some cases (haven't tested on react-native-render-html).
What I ended up doing in a similar situation is setting a variable in the component file, where I'm doing async fetches, and just modifying that var at componentWillUnmount.
Not a best practice, but it gets the job done, I guess...
In Html.js's case, this would translate to something like:
let isCancelled = false;

export default class HTML extends PureComponent {
[...]
    componentWillUnmount() {
        isCancelled = true;
    }
    async registerDOM (props = this.props, cb) {
        [...]

                    let response = await fetch(uri);
                    !isCancelled && this.setState({ dom: response._bodyText, loadingRemoteURL: false });
        [...]
    }
}

As promised, I made a snack.
Fortunately, I cannot reproduce it, thus I've updated the react-native-render-html dependency in my project to @4.1.1 and it does not seem to happen anymore.
Thank you!

Glad to know this is working.
If anyone is reading this, this has been fixed since 4.1.0 👍 4fca299


KAFKA-14768: add new configure to reduce the max.block.ms safely

Hi Team:
https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-14768
refer to #13320 . it is another proposal to fix one of the issues.
In brief, It is draft one without unit test which adopt the proposal 2 which solve the issue 2 which I mentioned in the JIRA
(2) can't reduce the send message's block time to wanted value.
Thanks for review.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@showuon here is the another proposal to solve part of the issues. thanks for your comment about this proposal.


parallel loop_tasks

This works with setting parallel=TRUE in the loop tasks example, but is breaking at least some tests right.  I'd like to get another set of eyes on it before I sink a lot of time into fixing the tests, since some of them are just testing for output messages that the added logic to do things in parallel might have affected.
I have only parallelized the first loop for now.

Anything more you want to do before merging?

fixes #81
Nope, should be good to go


MainNavigationItem component issue

Component affected - What is the name of the component or its variation? MainNavigationItem
Error - What is the unexpected behaviour? TypeError e.props.onChangeSub is not a function
Acceptance criteria - What is the correct behaviour? Define onChangeSub function
Owner - Who raised the request? Leandro E. Bravo
Description - What's the background? How to explain the context? The exception occurs in the MainNavigationItem component of the WFP UI kit library because the onChangeSub function from the props isn't provided by default/isn't checked for an undefined value.
Dependencies - Is there any impact on other activities? wfp-ui
Severity - Is the bug a regular fix or a blocker for other activities? Hight
Resources - Is there any related content to attach? Sentry screen attached

Thank you

Hi @leandroezequielbravo, thank you for your ticket! The <MainNavigationItem /> is only working as a a direct child of <MainNavigation>. We released a fix in<EMAIL_ADDRESS>which sets a default onChangeSub prop for each MainNavigationItem now.
Btw. in the next versions the MainNavigation is built differently using the ContextAPI, so this limitation will no longer be a problem (https://www.npmjs.com/package/@un/react).


In the "PerceiverAttention block", the key and value have only one token?

face embeding token as key and value, however, its length is 1.

It doesn't matter. The Resampler module will project the original face embedding into specified dimension and num_tokens.


[BUG] fo.Classifications labels aren't displayed in UI in v1.0.0

Describe the problem
It seems fo.Classifications fields aren't displayed in the UI from v1.0.0 (they were correctly displayed in v0.25.2).

From the code snippet below, we should see "three" and "four" on the sample.
From looking at the release note for v1.0.0, I guess the culprit would be https://github.com/voxel51/fiftyone/pull/4747
Code to reproduce issue
import fiftyone as fo

dataset = fo.load_dataset("tmp_dataset_laurent")
for sample in dataset:
    sample["classification1"] = fo.Classification(label="one")
    sample["classification2"] = fo.Classification(label="two")
    sample["classifications1"] = fo.Classifications(classifications=[fo.Classification(label="three")])
    sample["classifications2"] = fo.Classifications(classifications=[fo.Classification(label="four")])
    sample.save()

System information

OS Platform and Distribution: Ubuntu 24.04 LTS
Python version: Python 3.10.14
FiftyOne version: FiftyOne v1.0.0
FiftyOne installed from: rye (which uses uv)

Willingness to contribute

[ ] Yes. I can contribute a fix for this bug independently
[ ] Yes. I would be willing to contribute a fix for this bug with from the FiftyOne community
[x] No. I cannot contribute a bug fix at this time

Thanks @Laurent2916. This will be fixed in 1.0.1


[PyTorch] add aten::randn

This PR intends to add aten::randn for the pytorch frontned.
cc: @masahi

Failed due to https://github.com/apache/tvm/issues/12012. @tvm-bot rerun

@tvm-bot rerun


How does Localization work?

I'm using @angular/localize for i18n support and building for multiple languages. The example of localization for this library in the README seems to suggest you have to force a specific locale, which seems antithetical to internationalization of the app. Am I missing something? I really just want the month and weekday labels to conform to the locale that is being built-for like how the Angular DatePipe works... is that possible?

Looking into the code, it kind of seems like this is the problematic bit:
export const defaults = {
  DATE_FORMAT: 'YYYY-MM-DD',
  COLOR: 'primary',
  WEEKS_FORMAT: ['S', 'M', 'T', 'W', 'T', 'F', 'S'],
  MONTH_FORMAT: ['JAN', 'FEB', 'MAR', 'APR', 'MAY', 'JUN', 'JUL', 'AUG', 'SEP', 'OCT', 'NOV', 'DEC'],
};

Wouldn't it be better to generate these strings in the templates using the Angular DatePipe with some hard-coded constants for the input dates?


possibility to set position on screen

I wish there was an option in the preference to hard set the position of the notification.
thanks

perhaps add that to the readme...


getProjection returns null on ol.source.Vector with GeoJSON data.

I am trying to get the projection object from the ol.source.Vector after GeoJSON data has been added to it using features property during construction. The vector and map projections may be different and when I try to get the projection for the source after it is instantiated, it returns null.
http://jsbin.com/lekibamune/1/edit?js,console,output
Quick example:
     var source = new ol.source.Vector({
        features: (new ol.format.GeoJSON()).readFeatures(featureCollection, {
          dataProjection: ol.proj.get(featureCollection.crs.properties.name),
          featureProjection: this.attr('map').getView().getProjection()
        })
      });
      console.log(ol.proj.get(featureCollection.crs.properties.name)) //null

How can I get the projection of the vector source, or am I doing something wrong here?

The thing you're missing is that the the feature projection of the source is the view projection. And to get the data projection (i.e. the CRS used in your GeoJSON), use ol.format.GeoJSON#getProjection(). If you load your GeoJSON from a file, you can simplify the above snippet:
var source = new ol.source.Vector({
  url: 'http://path/to/your.geojson'
});

If you have your GeoJSON in memory already, you can also simplify the above snippet:
var source = new ol.source.Vector({
  loader: function(extent, resolution, projection) {
    source.addFeatures(
        new ol.format.GeoJSON().readFeatures(featureCollection, {featureProjection: projection}));
  }
});


Add AWS role as session property

Users could use AWS role to do per-session access.
eg. use AWS role to query some limit-access tables:
./presto --server coordinator:8080 --catalog hive --debug --session hive.aws_iam_role="arn:aws:iam::example:role/access"

The default behavior of every aws sdk is to fall back to instance credentials, I think its expected and shouldnt need extra config.

To be continued in https://github.com/facebook/presto/pull/2640


Last bullet repeated.  Update doc for pod annotation

Description

Documentation: Last bullet repeated.  Update doc for pod annotation

Related issues/PRs
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note
None required

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!
Built with commit 7ab064fb4bd15d71ecc9f93150f01acfe74bc575
https://deploy-preview-3435--calico.netlify.com


update to .NET 9

Updates for .NET 9
This uses AOT and compiled bindings wherever possible.
.NET 8 support in the library is preserved. The Sample app is updated to .NET 9
Unit tests pass. Running the sample app on Windows and Android looks good.

CodeQL will be updated to support .NET 9 in a few days


Fix misc build issues

Added out directory to .gitignore
Fixed self contained Dockerfile's entrypoint
Changed self contained app's osx rid to work with current released CLI version (rel-1.0.0-preview2)
Fixed dev Dockerfile to workaround https://github.com/docker/docker/issues/27545

@richlander, @kendrahavens

Nice! Thanks.


Nest Fullstaq Ruby under Ruby as it's an alternative distribution

And not its own Ruby implementation. Similar to mruby/c.
Remove an explicit list of versions as it's verbose and hard to maintain.

No worries. I trust your judgement.  Thanks for the update. Keep it up and thanks for the great work on Truffle Ruby. Cheers. Prost.


Empty urlsToWatch error doesn't disappear when entering a URL

From @waldekmastykarz
When creating a config file using devproxy-config-file snippet an error is displayed on the urlsToWatch array, however entering a string into the array doesn't remove the error.
Using VSCode Insiders on macOS

Closing as this is no longer and issue and an automated test has been added to test for this scenario which is passing.


App repos disappeared

Here did the ansibl8s app repos go?

Hi,
Sorry, it was a bit rude to move them without notification:
https://gitlab.com/groups/kubespray-ansibl8s
We are working on 'kpm' that will replace ansible to deploy 'applications' in much more easy way.

Why out of github?

Thanks for the path!


No Transformers found

Im trying to use voy within a browser extension with the plasmo framework, but when I try to load a function I get from the wasm module the error No Transformers found. Yet I can't seem to find that message in voy 's source code.

Uh. Sorry about that, it's actually a parcel error, but wasn't indicated that way in the console.


DataType Archives: Capture Function Data Type improvements

Is your feature request related to a problem? Please describe.
1.) A quick way to import function prototypes from one binary to another is via datatype archives (file or project). However, in the use case where we only want to load the prototypes for exported/imported functions, and both binaries have functions with the same name, doing so results in porting potentially incorrect/undesired datatypes.
2.) Extracting function data types with custom storage appears near impossible (might be possible by creating custom calling convention for every such function, but is cumbersome)
Describe the solution you'd like
An additional action to only capture function datatypes from exported functions.
Better support for custom function prototypes/calling conventions.

Managed to script (1) and (2) is related to #3267, closing


Added iOS Link & Presentation Mode

For issues #71 and #72

🙇🏾♂ Great work.
Looks like the presentation mode doesn't work on mobile, I tested on iOS 17 safari browser.
If we can't get it to work on mobile can we hide the button instead?

🙇🏾♂ Great work.
Looks like the presentation mode doesn't work on mobile, I tested on iOS 17 safari browser.
If we can't get it to work on mobile can we hide the button instead?

Oh, okay, I see. It's working for me on Android, so I think the problem isn't mobile in general. Let me try and see what could be the issue

@TinasheMzondiwa so it does indeed seem that Safari on iOS doesn't currently support going fullscreen. I've added a check which only displays the fullscreen button when the user's browser supports it. You should verify whether that works as expected


Make TypeError messages even more useful

I was struck by a TypeError with no information about what went wrong:
TypeError: can't convert into Integer

The backtrace led me nowhere as this was all framework code. The last code that belonged to me was the call to Repository#create. After that, it was all library code. See https://gist.github.com/francois/283f9ee23d268b69aa60 for a sample backtrace.
Now, I get a much more useful error message:
TypeError: can't convert #<Date: 2015-04-20 ((2457133j,0s,0n),+0s,2299161j)> into Integer

Not sure if we want to make #inspect_type_error private or not. Also, if the argument is a collection, it may not be a good idea to inspect it. The collection might contain thousands of elements. I'll be happy to contribute changes if necessary.

@francois do you use lotus-model in your code at all?

I found my issue: I was using a composite primary key for my database table, where the first component of the primary key was a date. Sequel returns the first element of the composite primary key, instead of returning the full primary key.
I have switched my primary key around to a plain surrogate key, and all is good now.
This pull request is still valid, as it helps developers understand what value caused the error.

To answer your question, @joneslee85, I do use the latest released version of lotus-model, as specified by lotusrb.

:+1: errors more useful

@AlfonsoUceda, I cleaned up as you requested, and squashed all three commits as one. The history will be cleaner this way.

@francois perfect ;) good job, :+1:

@francois Thanks for this PR :+1: Helpful error messages are great to have because they helps devs while debugging. Merged. It will be released on tomorrow.


External storage API

https://github.com/LatvianModder/YABBA/issues/35

My recommendation: Capability<IExternalItemStorage>
IExternalItemStorage:
/**
 * @author LatvianModder
 */
@MethodsReturnNonnullByDefault
@ParametersAreNonnullByDefault
public interface IExternalItemStorage
{
	class ItemEntry
	{
		public final ItemStack type;
		public final int count;
		public final int capacity; //Is this even needed?

		public ItemEntry(ItemStack type, int count, int capacity)
		{
			this.type = type;
			this.count = count;
			this.capacity = capacity;
		}
	}

	Collection<ItemEntry> getStoredItems();

	ItemStack insert(ItemStack stack, boolean simulate);

	ItemStack extract(int size, boolean simulate);

	default int getPriority()
	{
		return 0;
	}

	default AccessType getAccessType()
	{
		return AccessType.INSERT_EXTRACT;
	}
}

Tanks dont really need that, since FluidStack doesnt have stack size limitations

No... you are just copying the interface of IStorage here. It will stay an IStorage, but provided through an IExternalStorageProvider. The main difference with IExternalStorageProvider/IStorageProvider will be that a supplier will be given to retrieve the external storage properties like priority and access type.

IStorage doesn't have capacity though, it would be nice to have that


Decide on how to present solved PQIRs in the categorization page.

Bringing this to your attention again... @Linedueo @knudsvik @askbulle What happens in the categorization page?
Originally posted by @SjoenH in https://github.com/equinor/MAD-VSM-WEB/issues/165#issuecomment-977652284

Solved PQIR's should not show in the categorisation page.

Super. Here's the answer @martabenthem. Please filter them away in the categorization page.
@Magos I think it makes sense to do this in the front-end. Let me know if you object.


No (or empty) response form server - Request returns Error Code 403

Hey there,
if been trying to set up the overpass API for Germany.  I did the "docker start overpass_germany" comand and it booted. When i am now querying the server with "http;//<server_ip>:12345/api/  I do get error code 404.
Any ideas how I can fix it?

I fixed it - added the "interpreter" to the url and now I do get an response.
Still it is not working properly since the response itself is empty
{'version': 0.6, 'generator': 'Overpass API <IP_ADDRESS> 8b86ff77', 'osm3s': {'timestamp_osm_base': '2020-02-25T13:44:59Z', 'copyright': 'The data included in this document is from www.openstreetmap.org. The data is made available under ODbL.'}, 'elements': []}
I am sending the following request:
 api.get('area[name="{}"]; way(area)[highway][name]; out'.format(str("Berlin")),responseformat="json")
which should return all streets in Berlin. When I run the request against: https://overpass.kumi.systems/api/ everything works fine... But not on my own system

The startup script doesn't create areas, they are created in background once the instance is started. Due to the fact, that this is second issue in quite recent time regarding this, I'll add step to create areas upfront. This will increase time to run through init phase (it may be like 25-50% longer)


Place publishing 409 error message lacking

Roblox's documentation states that a 409 HTTP error for place-publishing should contain the following message: " Place not part of the universe." However, this error also occurs if the place is open in team create (see #37).
Currently, rbxcloud hard-codes the error message to the same message that Roblox has documented. However, this message is misleading in the case of the aforementioned team create scenario.
Relevant code:
https://github.com/Sleitnick/rbxcloud/blob/main/src/rbx/experience.rs#L91
Questions:

Should the error message be changed to something more generic?
Does the HTTP response from Roblox already contain a correct error message, or is it the same as the documentation?

If Roblox's HTTP response already contains a proper error message, that error message should be used instead of hard-coding a new message.

This might also be relevant to other status codes, not just the 409.


remove duplicate config key "assetManager"

Q
A

Is bugfix?

New feature?
no

Breaks BC?
no

Tests pass?

Fixed issues

Merged. Thanks!


One formal Suggestion

Bro everything on your site is animated and cute, I think if you change the cursor to some cute thing, it will look better as well also add some hover effects with box shadow on hero image,
BTW love your work brother

And also let me know if I can generate a PR for that


Fix documentation for the stream option

The stream option defaults to process.stderr but is shown in the README as defaulting to process.stdout.

thanks @ehmicky


Can't open folder wise view in new version.Please correct it.

VSCode Version:1.15.1
OS Version:Windows 10

Steps to Reproduce:

Reproduces without extensions: Yes/No

@SAJUSJ What is the "folder vise view"?

When I click the open folder option and select folder ,I won't display the selected folder in the left side panel. When I click and select individual files ,it will be shown.

@SAJUSJ could you post a screenshot of what you happens when you try open a folder?
Also check the devtools console for errors (Help > Toggle Developer Tools).

@sandy081 this could be related to hiding files explorer

@SAJUSJ Did you tried hiding the Folder view ?

If so, you can unhide it from the header

Note: This hidden state is per workspace and will not impact other workspaces

I have the same problem on Windows 10 using Visual Code 1.15.1 with no extensions.
A folder, "my_folder" opens in the sidebar and all files and subfolders are visible as normal.
On opening my_folder at some apparently later random occasion my_folder opens but no files or subfolders are visible in the sidebar.
I know my_folder is open, because at the very top of VS code you can see the "VS Code logo - my_folder - Visual Studio Code". But there are no files or subfolders visible in the sidebar.
This behaviour is the same if you right click on my_folder in Windows Explorer and open with VS Code or if you open my_folder from the "File" drop down menu. There is no output in Developer Tools -> Console when opening the folder from the VSCode File dropdown menu.
If I right click on a file inside my_folder in Windows Explorer to open a single file, the file opens in the side bar ok as normal.
If I change my_folder in Windows Explorer to, say, "my_folder_2", then my_folder_2 will open successfully in VSCode and show all the files and subfolders in the sidebar.
If I change my_folder_2 back to my_folder in Windows Explorer, VS Code "remembers" the initial folder, my_folder, and chooses not to display the contained files and subfolders.
However after opening and closing my_folder_2 some number of times, the behaviour of not showing the files and subfolders in the sidebar for my_folder_2 happens again.
Now VSCode "remembers" both my_folder and my_folder_2 and doesn't display the files and subfolders in the sidebar.
This process of renaming folders, temporarily being able to see the contained files and subfolders and VSCode remembering these "invisible" folders can be repeated for new folder names.
Note that the dropdown View -> Toggle Side Bar has no effect on this behaviour.

I had this same "issue", after removing my project from Side Bar I couldn't see it anymore after opening the editor again. The solution is the one mentioned above, there is this filter right clicking in the EXPLORER header. Clicking in Folders show again the folder tree.
Thanks.

This is fixed by #32962


Update dockerfile

This PR includes:

docker-compose rework
New Dockerfile with php image from oficial repository
Some fixes on app.php

Todo ok

All right @JaviSabalete, good job. Merged


Email isn't sending to recipients

I have tried with both the API and directly in the web app, but neither method will send an email.
I have tried with multiple recipient email addresses, too.

Also having this problem :(

Also having the same issue

Im using this configurations, still having problem of sending email . Is there any misconfig inside my configuration?

still a problem :(

Email still not working, just tried via the website.


[11.x] Fix deprecation warning caused by Carbon 3.2

Since running composer update today, I noticed deprecation errors being logged for every Laravel request to my app:

Use the method UTCInRealSeconds instead to make it more explicit about what it does. On next major version, "float" prefix will be removed (as all diff are now returning floating numbers) and "Real" methods will be removed in favor of "UTC" because what it actually does is to convert both dates to UTC timezone before comparison, while by default it does it only if both dates don't have exactly the same timezone (Note: 2 timezones with the same offset but different names are considered different as it's not safe to assume they will always have the same offset). in /Users/jack/Sites/site/vendor/nesbot/carbon/src/Carbon/Traits/Date.php on line 2627

I've replaced diffInRealSeconds with diffInSeconds to fix this, to retain compatibility with the Carbon v2 dependency as well.
Here's the Carbon commit which caused this, released in 3.2 yesterday.

cc @kylekatarnls

As a side note, "Real" alias methods will remain availables for the whole life of 3.x

@driesvints Can this be tagged for release today, or should we downgrade Carbon temporarily? I imagine it'll fill up a lot of logs in the meantime as it hits on every request.

@JackWH not sure why deprecations are hitting you in production?

And of course it's just an annoyance in local development as well, with tools like Ray becoming nearly unusable.

Sorry I don't get this point neither, you have local development tool that check runtime-deprecation notices? 🤔
I would reconsider the plan for deprecation if needed. But I would need to understand exactly which tool complains about what.
Deprecation is a way to offer a notice ahead of later changes. So the whole point is that it's actually not an emergency to be changed in the minute. If a third-party tool defeats this purpose, I think it's worth to check if it has options (such as way of acknowledging a particular deprecation so not to be raised again). If it has not, it would be relevant to open a discussions on with the maintainers of tools.

@kylekatarnls I agree with you and have no issue with how Carbon (or any other dependency) raises deprecation notices 👍  I only suggested releasing this sooner as I know Laravel values a good developer experience, and given this single isolated call to a deprecated function logs on every framework request, it would be nice if we didn't have to work around it for a week before the next release. Thanks for your hard work on Carbon ❤

We released this last Thursday btw 👍


OAuth card text being applied as card title

Versions
What package version of the SDK are you using. 4.17.0
What nodejs version are you using 18.6
What browser version are you using Firefox 104.0
What os are you using macOs 12.3
Describe the bug
Cards created with this.addDialog(new OAuthPrompt(...)) are having their card text applied as card title on desktop, web versions teams channels. This is resulting in text being cut off as it's limited to two lines.
Cards are being rendered as expected on mobile.
To Reproduce

Create an OAuth Card using OAuthPrompt from botbuilder-dialogs
send this dialog in a Team channel using the web or desktop app
Notice that the text passed to the OAuthPrompt is being rendered as the hero card's title

Expected behavior
It's expected that the OAuthPrompt text will be rendered as the card's text, not the title.
Screenshots

This is generated by the following OAuthPrompt:
this.addDialog(
    new OAuthPrompt('OAuthPrompt', {
        connectionName: ConnectionName,
        text: 'You will be prompted to authenticate with your identity provider',
        title: 'Log In & Authorize'
    }),
);

Note the text string is being applied as class="card-title"
Additional context

In one-on-one conversations the cards are being rendered correctly (although the card text is bold it's not being cut off).
In all chats on mobile the cards are being rendered correctly.

Thanks @isweetland, we are investigating.

Hi @isweetland,
I was able to repro, looks like in the Teams channel, the text is displayed more like a title.
Tested using sample 46.teams-auth and added AAD v2 OAuth Connection.
Sharing screenshots for comparison.
Teams:

WebChat:

The same behavior occurs with C# samples.
We will check with the engineers on this and report back soon.
Thanks.

Hi @JuanAr, this issue is reproducible.
In Teams channel, the OAuthPrompt text font is bold and rendered as a title.

Hi everyone,
We reproduced the issue on Teams, and as mentioned, the card is shown correctly in 1-1 conversations while, in a Teams channel, the text is cut off.
BotBuilder-JS is sending the OAuth card correctly. It's Teams who renders the card in different ways depending on the conversation type.
Here we can see the different structures and classes used in the two chats.

Closing as this channel specific behavior.


Could only the first few characters up the first ":" needs to be considered as affected in JIRA

Hi team,
We have faced a problem that , we use "message:%s" as Optionally change the Gerrit search query patterns in jira.But , when our customer commit a message says

The plugin shows this info below the DDE-1 issue,However , the commit message only contains "DDE 1.2" which is different from "DDE-1". Our customer think it is a bug.
Could you please tell us if this plugin can only use the first characters up the first ":".Such as only  "EPC-15329 "  matters for mapping?
BR
SDC Jira Support Team

Can someone follow this ticket ?

This would probably need to be a new feature for the parser.  I don't see why it would be interpreting DDE 1.2: as if it were DDE-1, because it's missing the - that is expected in Jira issue ids.
Unfortunately it looks like this is an artifact of the "Full Text" (secondary index -- e.g. Lucene) searching in Gerrit.  If you type message:DDE-1 into your Gerrit search bar, it will return the commit for EPC-15329 because it doesn't do exact text matching, but instead converts the search criteria to something that can be searched with full-text queries.
I don't know of any way to relax that searching, as it is something done automatically by Gerrit. I don't see any search predicate or operator that enforces an "exact match" like that, as the default search for message: is to use the lucene index, which performs full-text searches (that is, it looks for bare words, not symbols).
The only way I can think for you to resolve this would be to integrate the trackingIds config, and use the tr:%s predicate instead in your Jira configuration for the Gerrit plugin.  The tr: predicate should provide exact matching, because it has to extract the bug id into a separate table.  See system configuration for this option: https://gerrit-documentation.storage.googleapis.com/Documentation/2.14.2/config-gerrit.html#trackingid

I have the same issue. In our case, we are integrating this plugin with a 5 years old convention of commit message such as:
Trackind-Id: US:JIRA-1234

Because of the leading colon, the issue does not get properly recognized. It works if we enclose the ID with square brackets.

As mentioned in the comment above, this isn't something that the plugin is doing. This is how Gerrit search works. The plugin does not itself scan every commit and look for Jira ids - it asks Gerrit to search for the issue id you are viewing. If Gerrit doesn't have a search predicate that works for you, then there's not much more the plugin can do for you.
I would suggest you spend some time with trial-and-error search predicates by typing some search queries into the search box on Gerrit. When you find something that works for your commit message format, then you can update the plugin configuration to use that. For example, you might try searching for message:US:JIRA-1234 and see if that allows it to find your commits. If so, then you can update the configuration to include the US: prefix. If there are other possible prefixes, then you can also use an OR search operator, and replace %s with %1$s (%s just means use the next replacement token; but %1$s means use the first replacement token, and so on). For example, if you have US, GB, DE prefixes, you could try: message:US:%1$s OR message:GB:%1$s OR message:DE:%1$s, and see if that works.
You can test it first in the Gerrit search box, before saving it in the Jira plugin configuration.


'Error' service - kibana failed to build

I get the following error when I attempt to "docker-compose up" on the 5.0 branch:

Any thoughts @jarpy @dliappis ?

@viztastic Are you trying to build a local image of Kibana yourself? If not, you can use our public images; an example can be found in our blog article. If yes, then docker-compose.yml expects an environment variable set to the Kibana version, so you should either:

make build
or

export KIBANA_VERSION=5.0.0-beta1
docker-compose up

Hope that helps.

Closing to keep things tidy. Please re-open if you need any more help.


Broken Link in See Also Section

In the See Also section, there is some formatting issue which is causing the hyperlink  to show as plain text

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 028dd37e-f540-1b9f-a74c-0e0cb94102b3
Version Independent ID: 96998139-7136-8b7c-41ea-621bdd1b6ec5
Content: <compiler> Element
Content Source: docs/framework/configure-apps/file-schema/compiler/compiler-element.md
Product: dotnet-framework
GitHub Login: @mcleblanc
Microsoft Alias: markl

@amaldevv fixed with PR #8492


Commiting and fetching consumer offsets in Kafka

Are you planning to implement this one?
https://cwiki.apache.org/confluence/display/KAFKA/Committing+and+fetching+consumer+offsets+in+Kafka

https://github.com/chingor13/poseidon/ Seems to have implemented this. We've forked the more active https://github.com/Tapjoy/poseidon with a test implementation of this feature at https://github.com/rightsup/poseidon

@gerbal  maybe it would be worth "retrieving" this gem from @bpot  as it seems he's no longer maintaining this one. Also I've noticed that this gem is strongly based on kafka-python that seems to be up 2 date with all Kafka changes.

@bpot is way behind both https://github.com/apptentive-engineering/poseidon and https://github.com/Tapjoy/poseidon
https://github.com/rightsup/poseidon seems to combines both goodness now and looks like a good start, what do you think?
Any suggestion on how to clean all this mess ?

@diegodurs yeah I was thinking about giving it a fresh start by rewriting kafka-python. It's not a big library and it is really well maintained - should not take a lot of time to make it as it should be. If it goes about poseidon it gets more and more behind Kafka

We'll love to follow you on this journey.
But regarding our needs, we'll try to make this feature works in @rightsup
Poseidon :)
Le mar. 26 janv. 2016 à 16:03, Maciej Mensfeld<EMAIL_ADDRESS>a
écrit :

@diegodurs https://github.com/diegodurs yeah I was thinking about
giving it a fresh start by rewriting kafka-python. It's not a big library
and it is really well maintained - should not take a lot of time to make it
as it should be. If it goes about poseidon it gets more and more behind
Kafka
—
Reply to this email directly or view it on GitHub
https://github.com/bpot/poseidon/issues/118#issuecomment-175063349.

@RightsUpIO  thanks! I'm finishing some stuff for https://github.com/karafka/karafka (Kafka high leve Ruby framework) - which is strongly dependent of Poseidon and probably next week @nijikon and I will start working on that.

Implementing consumer offsets in Poseidon requires implementing group management features and a bunch of newer Kafka features.

@gerbal that's why I'm against adding more stuff to Poseidon (based on how it is now) and building a better version of it.

Closing as anyhow it's unmaintained


builder doesn't support leading "/" notation in paths

Using a leading / on paths to specify files should be loaded from the base of a site works in the browser. With the builder I would expect it to use the base path but it just looks for it at file:///file.js (3 dashes because it doesn't try to resolve the dash)

I understand this is a catch, but SystemJS has no concept of the rootURL, only a baseURL.
Also we treat the client and server equally. That is /x.js on the file system really does mean file:///file.js as we use file URLs.
We could potentially amend the error message here to be more useful as well.


jedi-vim plugin not functioning?

New to amix,/vimrc.  Currently attempting to install the jedi-vim plugin.
I have cloned the repo into my_plugins, however still no autocompletion?
An error is generated when attempting to open python file....
jedi-vim: Error when loading the jedi python module (module 'jedi' has no attribute 'version') Please ensure that Jedi is installed correctly.

This isn't related to my vimrc. Please follow the guidelines here:

https://github.com/davidhalter/jedi-vim

For the record, I have this working properly. Most likely, your Python<>Vim bindings are not working properly.


Selecting ForeignObject

ForObjectDemo.zip
Hi i am using the Foreign Object plugin for creating a editable text.
Basically a DIV inside the foreignobject with Contenteditable Attribute set to TRUE for the DIV object.
After creating i wanted the ForObject element to be draggaed and resized.
But when the object is selected for resizing (Selectize() method), the Viewport[Outer Rectangle box] of the element is displayed based on the X=0,Y=0 position of the container irrespective of the ForObject position on the SVG container.
The draggable, selectize and the Resize functions are called on the ForObject element.
Thanks in Advance for the help.

sorry for the long wait.
I read your code and dont understand why there is written this:

				fObj.mouseover(function(event){
					currentX = this.x();
					currentY = this.y();
				});
				fObj.click(function() {
					this.attr("x", currentX);
					this.attr("y", currentY);
					this.resize().draggable();
					this.selectize();
				});

I also dont know why you insert random commands into the source files of svg.resize and svg.select. Doenst make it easier to debug. In fact it works already very well, when you just select the item and deselect it by clicking on the document or so. The call to resize and draggable can be done everywhere in the initialisation. Also there is a reason why there is written: pointer-events:none. You usually dont want emit mouseevents to the overlay

Thanks a lot ulrich master.
Will remove the unneeded code. The above code actually I wanted to put for keeping the x and y position of the forobj element when the content of the text is being edited.
Now I am not using the code anymore since I am using the jquery drag and resize for the text element alone .
For time being I will close this issue and will get back in case of anything new issue arises.


Workaround for WebKit Pointer Event Implicit Capture Bug

Fixes #1962
Also improved event handling on legacy touch/mouse devices
The Problem and the Fix
In the pointer event model, touch (and other "direct manipulation devices") get pointer capture implicitly when a user makes a contact with the device. If a child element doesn't require pointer capture, capture can be released in a pointerdown event handler. When the event bubbles to a parent element, that parent can request pointer capture. The WebKit bug (described in #1962) prevents a parent element from capturing pointers on pointerdown events. The implicit capture at the child isn't released as requested, or held - not sure where subsequent events go at that point. When the parent requests capture it should get all subsequent pointermove and pointerup events targeted at its element's event handlers. On WebKit this doesn't happen, so if the user drags the pointer outside the parent element it stops receiving pointermove events, and more importantly won't receive the pointerup event indicating termination of a gesture. This leaves MouseTrackers pointer tracking in an unstable state, thinking there's still pointer contact.
To fix, on pointerdown events for touch, MouseTracker now checks to see if preventDefault() has already been called for the event (by a child element, which would indicate the child is handling a gesture) and if not, then lets the child keep its implicit capture on the pointer but flags itself as having capture and proceeds with gesture handling on bubbled pointermove and pointerup events as if it has pointer capture. This matches the way legacy touch events work, where pointer capture is ALWAYS given to the target element with no way of relinquishing capture so a parent element can take capture, so it's a reasonable approach and seems to work well - on both pointer events and legacy touch events!
Demo Sites
OpenSeadragon Imaging ImagingHelper Demo
OpenSeadragon Imaging MouseTracker Demo
Legacy OpenSeadragon Imaging ImagingHelper Demo
CodePen
Preview Builds
openseadragon.js
openseadragon.js.map
openseadragon.min.js
openseadragon.min.js.map

@iangilman This was a not so fun one ;-)  Ready for review

Awesome!
I don't see any Safari-specific code, which is great. Still, I'm curious how this fixes the Webkit-specific issue. Could you add a couple notes to the PR about what it's doing, so I understand and for posterity?

@iangilman I've added a note at the lines of code that provides the main fix..as well as a description of the issue and the fix in this PR's description

FYI, and note to self:
05/16/2022 it was announced that this Webkit bug was fixed and "shipped in Safari 15.5"
This should allow for some painful MouseTracker workaround code to be refactored out 😅

@msalsbery Exciting! :)


Share GHT

To share the GHT web app with everyone, there are three blockers:

#375
#374
#376

These should also be the only blockers to then share it publicly.

Done https://twitter.com/creativemaybeno/status/1476696599828992002?s=20.


Using Keiser M3i in gym/multi bikes

Keiser M3i is a fairly common bike in gyms, and I’ve been trying to think of a way that gymnasticon could be used in these locations - With multiple bikes to pair to?
So simplest solution I could think of was to

get gymnasticon to only pair with a M3i with a certain cadence/ or low power perhaps? - was thinking maybe only connect to bike with a cadence of eg less than 20 say??

If you want with qdomyos you can choose the ID in the settings
Il lun 24 mag 2021, 21:35 nealjane @.***> ha scritto:

Keiser M3i is a fairly common bike in gyms, and I’ve been trying to think
of a way that gymnasticon could be used in these locations - With multiple
bikes to pair to?
So simplest solution I could think of was to

get gymnasticon to only pair with a M3i with a certain cadence/ or
low power perhaps? - was thinking maybe only connect to bike with a cadence
of eg less than 20 say??

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ptx2/gymnasticon/issues/84, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALYWDPDG4SZ4QH6MNTP53TPKTB7ANCNFSM45NZRUYQ
.

Don’t want qd, otherwise I’d have used qd thanks…

Ok i was only trying to help you :)
Il lun 24 mag 2021, 21:59 nealjane @.***> ha scritto:

Don’t want qd, otherwise I’d have used qd thanks…
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ptx2/gymnasticon/issues/84#issuecomment-847297469,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAALYWD5XCFEFUR5ARJSAZDTPKV3RANCNFSM45NZRUYQ
.

Hi @nealjane,
Did you try to modify the file gymnasticon.service at path "/etc/systemd/system" to change the parameter "Description=Gymnasticon" to something as "Description=M3i-bike-1" and "Description=M3i-bike-2".....
In theory the Zwift and other apps should see different bikes, you just need to assing the bike number (1,2,3...) at the gym to the corresonding raspberry pi (1,2,3...).
I will test later at home but I think it should work.

@aortizdp - I don’t think that'll work.
I’m assuming whatever needs changing , it needs to be in Keiser.js file - as that’s the file that scans/connects to the bike - prior to forwarding the stats to gymnasticon.

Hi @nealjane,
You were right but finally modifying the
/etc/gymnasticon.json
{
"bike": "keiser",
"server-name": "M3i-1"
}
You may assign one different server-name per bike.
The main problem is how to link the raspberry to one unique bike (in a gym will be several), I've seen on flywheel bike you may link to one unique Bluetooth address but this is not the case for keiser bikes.
I think is needed another parameter to force to search for one selected bluetooth bike address in the configuration file.
Hope it helps,
Alber

I forgot to mention I tested with FulGaz and bike was presented as "M3i-1" instead as previous "Gymnasticon" name.
The question is this is only working at
"APP - Raspberry" side, still needs to be solved "bike - Raspberry" side which solution seems to be to force the Bluetooth lookup to the bike.
Or either to reduce hci0 power to link to closest bike (keiser console) or to force to look to one bike Bluetooth mac both should work.

In my gym each of the Keiser bikes have the bike id set to a unique number (1, 2, 3, 4, 5,.... 25) for the 25 bikes and don't particularly like clients changing them.  If one always uses the same bike one could hard-code the bike id.  But then you might have to kick someone off "your" bike  ;-)
Perhaps a another option would be for the Gymnasticon app on startup to look for an M3i transmitting in "summary" mode versus real-time mode.  Summary mode is activated when one stops peddling (I think you need to peddle for at least a minute before stopping for the summary mode to activate).   The M3i will transmit summary data for about a minute or so and then stop transmitting altogether.  So one could get on a bike, peddle for a minute, start/powerup Gymnasticon and stop peddling.  It is then pretty likely the bike you are on is the only one transmitting summary info.  Gymnasticon could then find the bike transmitting summary stats, connect to it and then start processing real-time data once you start peddling again.

Hi @djwasser sorry but I don't get what you mean.
I was meaning to fit one raspberry per bike assigned to each bike number:
Bike1 - Raspberry1 (server-name bike1)
Bike2 - Raspberry2 (server-name bike2)
..
Bike25 - Raspberry25 (server-name bike25)
When you get into the bike 5, start pedaling, open on your tablet app (ex Fulgaz) and select bike 5 on the list select power and cadence and go.
Ideal would be to get bike Id from the console (you can assign an I'd per bike in m3i console).
My question is how to link each raspberry Bluetooth to only listen to one bike Bluetooth mac address. Maybe reducing power of hci0 and set raspberry very close to m3i console.
I think Intelligence Cycling which is prepared to that without gymnasticon do this as is prepared for gym classes.

@djwasser - yes, that’s the type of thing that would be workable I imagine!
@aortizdp - think what you’re after is having say 25 pis for 25 Keiser bikes setup in a gym,
Ideally I guess you want the gymnasticon.Json file to be edited to allow for ‘say’ - connect to ‘Keiser’ , and then specific bike no ‘001’, next pi to have ‘002’ etc up to 25 in your case.
I guess gymnasticon is currently setup to just find ‘M3’ name which is found in the Keiser broadcast packet, in this packet is the additional info that’s required ‘equipment id’ - see attached. I’m assuming this all needs to be added to the ‘Keiser.js’ in src/bikes - lines 7-17, needs something along lines of
‘Keiser..._equip Id = 5; // equipment Id 000-200’ - this is all beyond me though..! And then this all needs to be connected to gymnasticon.json to control etc...

Thanks @nealjane this is very useful information I was not aware, I will do some tests with that to see if I can add a parameter to force Equipment ID in the gymnasticon.json file.
In the documentation there's also the Data Type attribute which could be 'real' or 'review' modes... I guess this what @djwasser wants with 'summary' mode.

So I thinks it’s pretty clear what we’re needing to be able to use this in a gym environment-
@aortizdp - would like to be able to setup pi’s to connect to a single specific bike number/I’d (using the ‘equipment Id’ which is in the data stream)- this could ideally be stated in the gymnasticon.json file.
Me (nealjane) - thinking more for users who take gymnasticon pi with them to gym (with pi plugged into a usb battery)- trying to connect to a single bike (possibly different Id each time) - @djwasser suggestion of being able to select the bike that’s currently in ‘review’ mode which is also in the data stream sounds like a great solution! This could also be selected on the gymnasticon file as well.
Unfortunately, I have no skills in coding. @chriselsen did all the M3i work (and it looks like he’s busy as he’s not ben around much recently) @ptx2 unfortunately hasn’t been here much either - so I think we’re stuck for now - who knows, maybe they’ll get round to it - I would imagine it’s quite clear what we’re suggesting.

@nealjane I started to looking into code from the information you provided to see if is possible, from what I see it is... but I can do only on my spare time which is not much at the moment.
Let me some time, and to do some tests, I never programmed nodeJS but I did in Javascript in past and is quite similar.
What I see at first sight:

Connect to specific bike: createFilterName(name) (name is just hardcoded to 'M3') function could be easily replaced to createFilter(name, address) (address is bluetooth address) where we can force bluetooth address easily. But I want to assign it from the EquipmentID (no the bluetooth address, much simpler) which is inside the data-stream, a bit more complex to read than bluetooth address which is just in the header.

To detect change between 'review' or 'real' codes and to link only on 'review' mode is possible too but it will take longer as it modifies quite a lot the behavior of keiser.js I will try to do this too but I think it will take longer.


Not able to select text inside Sortable Items.

const SortableItem = SortableElement(({value}) =>

I wan to select this text.

);

How can I differentiate between selecting the text inside vs dragging the container?

Also trying to figure this out

See - #41, Set distance={1} on SortableContainer.

Make sure to remove user-select: none; from the element you want to be selectable (and all parent elements).
I added a drag handle to ensure the UX worked as expected. (see demo here) Note that in this demo they're using user-select: none; on the sortable item (which will disable text selection).
If you don't want a drag handle, you probably would want user-select: none; on the sortable item and add user-select: auto; on the child elements that you want to be selectable.

As mentioned by @AnthonyWhitaker, you can add a drag handle so that only the handle is draggable, or you could also use the pressDelay prop


Text changes on the vortex

Context
This ticket is to make all the text changes recieved as feedback
Requirement

Change the text from "Enter Bank details" to "Continue with Partner"
Change from "Should arrive in 5 minutes" to "Takes 5 minutes"

Closed by https://github.com/pendulum-chain/vortex/pull/233.


Mover to SSD fails due to SSD not configured

Currently, if SSD is not configured, SSM will not give any information/warning until a move to SSD action is triggered. Under this circumstance, all mover actions related to SSD will fail.
Action starts at Thu Aug 17 00:57:59 EDT 2017 : /test/data_10MB -> ALL_SSD java.io.IOException: Mover plan not specified. at org.smartdata.hdfs.action.move.MoverBasedMoveRunner.move(MoverBasedMoveRunner.java:64) at org.smartdata.hdfs.action.move.MoverBasedMoveRunner.move(MoverBasedMoveRunner.java:55) at org.smartdata.hdfs.action.MoveFileAction.execute(MoveFileAction.java:78) at org.smartdata.action.SmartAction.run(SmartAction.java:124) at org.smartdata.server.engine.cmdlet.Cmdlet.runAllActions(Cmdlet.java:95) at org.smartdata.server.engine.cmdlet.Cmdlet.run(Cmdlet.java:109) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748)

it is a form of lazy evaluation, also allows creating rules and SSD configuration in any order. May be the best solution here is just an error message sayign no SSDs configured.


devpi-server: 4.4.0 -> 4.9.0

Motivation for this change
Noticed it was out of date when building a different package.
Bumped the python packages to use 3.7 instead of 2.7.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/771311zs2gmld9xsivg5r0z37h3n2hf1-devpi-server-4.9.0   184.0M

@GrahamcOfBorg build devpi

@FRidh sorry, i forgot to edit the title. The package is listed as devpi-server.

@GrahamcOfBorg build devpi-server


change hashset to linkedhashset for Tag

Coverage increased (+0.04%) to 80.097% when pulling 81c65df93f1f9319866b7c6456b9d2532096d38e on jasonvank:master into f9b26e967094c0acf7332ed78a345854eaaf9155 on CS2103-AY1819S1-T12-4:milestone-v1.4.


Fix broken command in readme

will add localhost as the register if REGISTRY not set, the command will not work as expected
Fixes #31

/ok-to-test


Creating a framework for the Map page

Please do work for this task in a branch named issue-01.

Make a page for the maps integration


quiche.h: use (void) in proto to satisfy picky compilers

Without it, I get this:
include/quiche.h:305:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
  305 | quiche_h3_config *quiche_h3_config_new();
      | ^~~~~~~~~~~~~~~~

Merged, thanks!

Ta!
On Sun, 29 Sep 2019, 22:59 Alessandro Ghedini<EMAIL_ADDRESS>wrote:

Merged, thanks!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/cloudflare/quiche/pull/192?email_source=notifications&email_token=ABSELNKYPIMB4K4PN7MI2G3QMEQLRA5CNFSM4I3UHBMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD737Z2A#issuecomment-536345832,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABSELNIKXC5S2KPQVDUTWOTQMEQLRANCNFSM4I3UHBMA
.


[JS] Add missing .vscode, infra folders and YML files to DevOpsBot

https://github.com/microsoft/teams-ai/pull/996


Translate poses of nested models inside other nested models (sdf6)

When addNestedModel function is called, it processes links and joints to translate the pose accordingly to parent pose. This was not done for nested models inside the SDF being processed by the function, hence they were not aware of parent pose.
This PR includes nested models in the same way that is doing for links and add a test that fails without the change.
The change was proposed by @azeey. If we are not wrong, the change is not present in newer versions of sdformat after the implementation of frame semantics.

This pull request has been mentioned on Gazebo Community. There might be relevant details there:
https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1


Window Borders

When choosing Window.SetBorder(BorderNone) and Window.SetTitleButtons(ButtonDefault), while the border will not be drawn, there is still an empty border which wastes the screen space. Is there a way to avoid that?

What happens if you window.SetPaddings(0,0)? Default is (1,1).  The look may be what you want but it may adds some undesirable issues: e.g, controls on borders(at least top and bottom lines) would not receive mouse events because "mouse" processing method in Window does not check padding size.

hah, window.SetPaddings(0, 0) worked in a way. Seems that it still draws the empty borders, but does the coordinate calculations right. I'll fix it and submit a PR.


Help on display select date in DIV on Modal

Hi @mikecoj
I hope you can help me .. I need to display the Selected Date of the MC Datepicker into a DIV, and I have tried multiple jQuery and native JavaScript ways to do so, that in my lap works with jQuery datepickers and normal input fields, but fails with the MC Datepicker
i.e
<input type="text" name="EndDate" id="EndDate" style="width: 140px;" class="form-control border-left-0" placeholder="vælg slut dato.." onselect="toggle2()"">

My hope is that the date i.e 17-06-2022 could be displayed as Torsdag d. 17 Juni 2022 (Translated to English : Thursday 17th June 2022)
I hope you can help me out :-)
Best Regards
Stig

Have you used the dateFormat, customWeekDays, customMonths when you've set the options of your datepicker (see here MCDatepiker Documentation?
You should then be able to use the getFormattedDate() function to set the name of your dive (see here MCDatepicker Documentation.
I hope this helps

Hi @ashenshugarRET :-)
Great that helps on the format of the output, but my first hurdle is to get it to display in the DIV at all .. can you point me on how to do that? :-)

Assuming you declared your datepicker like this:
const picker = MCDatepicker.create({     disableWeekends: true });
That is you can call the datepicker with picker, you should then be able to use the following to set the contents of your div to the formatted date:
document.getElementById("ConfirmEndDateHolder").value = picker.getFormatedDate();

If the above doesn't work try:
document.getElementById("ConfirmEndDateHolder").innerHTML = picker.getFormatedDate();

Thank you for your great help @ashenshugarRET, I have it now working after some playing around with different methods, and the final solution was a combo of your tips and using Moment JS :
$( document ).ready(function() {
  $('#BtnProceed').click(function() {

        var TheEndDate = document.getElementById("ConfirmEndDateHolder").value = EndCalendar.getFullDate();

        m = moment(new Date(TheEndDate)).format("dddd, Do MMMM YYYY");

        $("#ConfirmEndDateHolder").text(m);

  });
});

If your problem is solved, could you close the issue?


Unity3d native plugins / MultiMake / Find Package Config Mode / Dockercross

Hey @floooh ,
Hope you are all well !
I am having a try with your interesting project because I wanted to manage more easily my cross-platform builds and stacks of c/c++ dependencies. While making some tests, some questions popped from my mind :-) about several topics. Sorry for this long post, but I was wondering if it was worth to chunk it into sub-issues before having your overall point of view on that, so let me know if you want me to split it later on.
Questions:
Each of them starts with the following :-), would it be possible to build or manage it with FIPS ... ?
1. Build Unity3d Native plugins:
Goal: Automate the build of a project or a dependency for several platform builds (eg Android, iOS, PhoneSDK81, SDK81, Linux)
Reference: https://github.com/mixpanel/mixpanel-unity/blob/master/native/build/build_all.py
Output example:
./Assets/Plugins/OpenCV/Android/libs/armeabi-v7a/opencv-sharedlib.so
./Assets/Plugins/OpenCV/Android/libs/x86/opencv-sharedlib.so
./Assets/Plugins/OpenCV/iOS/opencv2.framework
./Assets/Plugins/OpenCV/iOS/libopencv.a (combined armv7/arm64)
./Assets/Plugins/OpenCV/opencv.bundle
./Assets/Plugins/OpenCV/WSA/PhoneSDK81/ARM/.dll
./Assets/Plugins/OpenCV/WSA/PhoneSDK81/x86/.dll
./Assets/Plugins/OpenCV/WSA/SDK81/ARM/.dll
./Assets/Plugins/OpenCV/WSA/SDK81/x86/.dll
./Assets/Plugins/OpenCV/WSA/SDK81/x64/.dll
./Assets/Plugins/OpenCV/x86/.dll
./Assets/Plugins/OpenCV/x86_64/*.dll
One dll per OpenCV module, eg. opencv_xfeatures2d310.dll, opencv_core310.dll ~27 files)
2. Auto generated unsafe bindings for C#/.NET and Mono from C/C++ projects.
Goal: Build bindings (with CppSharp with the IDisposable interface to manage the memory and import some C/C++ libraries into Unity3D projects.
Requirements:

generate  a list of library include files per toolchain with CMake
generate  a list of libraries generated per toolchain with CMake
use CppSharp-CLI to generate those bindings (link to one CMake driven project CppPlug)
copy .cs generated bindings to the Unity3D project

References:

FFmpeg: https://github.com/Ruslan-B/FFmpeg.AutoGen
MonoGame: https://github.com/mono/MonoGame
GLFW3: https://github.com/realvictorprm/GLFW3.NET
CppSharpTizen: https://github.com/kitsilanosoftware/CppSharpTizen
CppPlug: https://github.com/zillemarco/CppPlug
Sugar: https://github.com/ruslo/sugar

Notes:

SWIG is another alternative (eg. link) but CppSharps sounds more active and closer to Mono develop integration.

3. CMake/Fips - Import more easily different external projects with find_package config mode (autotools, autogen-autotools, csprojects).
Goals:

Support of CMake packages (link)
Support of QMake packages (link)
Support of Automake packages (link)
Support of Maven packages (link)
Support of package installation in non-standard location (prefix)
Create a config package file for dependencies targets with a namespace (eg. link Config.cmake.in, CMakeLists.txt)
Create a cache for big projects per toolchains like hunter.

Requirements:

Define specific input variables for the  ExternalProject_Add command per plarform (eg. link)

Example:

Add Tensorflow project more easily into a FIPS driven project by providing dynamic arguments to  ExternalProject_Add per platforms ( compile_android_protobuf.sh, compile_ios_tensorflow.sh, compile_linux_protobuf.sh

References:
multimake: https://github.com/Pelagicore/multimake
hunter: https://github.com/ruslo/hunter/wiki/example.find_package.config
hunter: https://github.com/ruslo/hunter/wiki/example.find_package.config
ExternalProjectMultiPlatform: https://github.com/janelia-flyem/buildem/blob/master/ExternalProjectMultiPlatform.cmake
**4. (Last question but really quick one) Analyse and prepare a project for FIPS compatibility
Goals:

extract from an external project

project tree
all targets list (link)
all options commands

Requirements:

Create a test mode for FIPS and use some of CMake++ commands override (eg on_find_package, add_custom_target, on_add_library, on_install) to gather a external project profile into a yaml file (eg link)

References:
CMake++: https://github.com/toeb/cmakepp
Global idea/intent:

Manage more easily cross-build projects with wider sets of complex dependencies
Prevent duplicate dependencies between projects by creating a package config for CMake and use a namespace
Create stacks of dependencies per platforms with user-managed manifests like hunter (link) or CMake++ (json manifest, cmake manifest parser), I am much more keen to use yaml manifest as you are doing with FIPS
Copy imported packages and projects libraries  (eg. OpenCV+libpng,libturbo-jpeg,Protobuf+Tiny-DNN+Eigen,...) to a Unity3D project

That's all but I am already checking the scope of possibilities with FIPS as before I used to work with Polly as a build wrapper for cross-platform builds.
The suggestions above would make of FIPS a really really useful tool for any students or developers working on C/C++ projects and wanting to try their project on different platfroms.
Have an awesome day ! and thanks if you have read all of that post :-)
Cheers,
Richard

last question ^^, is there any tutorial or wiki page explaining how to wrap an external project with FIPS  ?

Hi, supporting all this in core-fips would introduce quite a lot of 'scope-creep', but it may be possible to do some of those things through project-specific extensions, for instance:

you can put a fips-include.cmake file into a project root directory which is included and evaluated during 'fips gen', it might be possible to use this to include other cmake helper scripts or your own cmake functions
you can write your own fips verbs (in fips-verbs) and fips custom build jobs (in fips-generators directory) in python
you can overwrite the default cmake-toolchain files, or add new toolchains into a directory fips-toolchains in your own project

As for including more different types of external projects I'm thinking about adding support for conan (https://www.conan.io/), this would only support C/C++ dependencies though.
There's not much information for fipsifying projects, because there's so many different ways to do it.
Here are some examples:

this is a typical example, where the actual project is in a git submodule, and a single root CMakeLists.txt file and fips.yml file describes the project for fips: https://github.com/floooh/fips-imgui
BGFX is currently the most complex example: https://github.com/floooh/fips-bgfx
assimp is an example where simply the original project CMakeLists.txt file is included: https://github.com/floooh/fips-assimp/

I am giving a try now, I will let your know tomorrow if you do not mind ^^


feat: add button component

Context

Closes #49.
Changes proposed in this pull request

Extension builds preview

Name
Link

Latest commit
a4e9bf2359f921d9b0c6e8f8a745c11d7df2b128

Latest job logs
Run #7285469730

DownloadDownloadDownloadDownload


#30 be able to load dump with not all columns

Coverage decreased (-0.8%) to 85.698% when pulling 05628b2c73e93db2ad94c92837cab2dfb777bc36 on be-able-load-dump-with-not-all-columns into c54a11053d313c6e1712ee14f78f078bf124ac65 on master.

Coverage increased (+0.8%) to 87.332% when pulling d788cc38ab2d2166d1529f516c70a63fc4933176 on be-able-load-dump-with-not-all-columns into c54a11053d313c6e1712ee14f78f078bf124ac65 on master.

Coverage increased (+1.4%) to 87.974% when pulling 75502c3dc6f43998556bc31dd7a1b952dc5c0ebb on be-able-load-dump-with-not-all-columns into c54a11053d313c6e1712ee14f78f078bf124ac65 on master.

Coverage increased (+2.2%) to 88.715% when pulling 1266f509e31a74c5cc766e8c7f30cc9f20f9f320 on be-able-load-dump-with-not-all-columns into c54a11053d313c6e1712ee14f78f078bf124ac65 on master.

Coverage increased (+2.2%) to 88.728% when pulling 70fc0ce9a514aa204edee16bf7e17d3abf9228f3 on be-able-load-dump-with-not-all-columns into c54a11053d313c6e1712ee14f78f078bf124ac65 on master.


Add CI/CD functionality based on auto

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
This PR adds CI/CD management and should automatically publish to NPM

📦 Published PR as canary version: 0.0.1--canary.2.6aff3c2.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in v0.1.0 :rocket:


error: dist.broadcast(p, 0)

Traceback (most recent call last):
File "train.py", line 292, in
args.warm_start, args.n_gpus, args.rank, args.group_name, hparams)
File "train.py", line 179, in train
model = apply_gradient_allreduce(model)
File "/home/chengt1/workspace/tacotron2/distributed.py", line 135, in apply_gradient_allreduce
dist.broadcast(p, 0)
File "/home/chengt1/anaconda3/lib/python3.6/site-packages/torch/distributed/distributed_c10d.py", line 737, in broadcast
work = _default_pg.broadcast([tensor], opts)
RuntimeError: CUDA error: unknown error (record at /opt/conda/conda-bld/pytorch_1544174967633/work/aten/src/ATen/cuda/CUDAEvent.h:87)
brother! could you help me? thank you

You seem to be running distributed training. Do you have multiple GPUs and are they available?

You seem to be running distributed training. Do you have multiple GPUs and are they available?

yes, multiple GPUs are available，but this project running distributed training, CUDA error: in apply_gradient_allreduce   dist.broadcast(p, 0)

Can you run with a single GPU?

I am also getting this error I am able to run on the single GPU but not on multiple GPUs

Closing due to inactivity.


Mobile Key Issue 1: Error Message

Getting this message when clicking on Mobile Key that has already signed a transaction.

Resolved in 343


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71990

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82969

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/85654

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86152

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/105006

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/116119