Fix isomorphic support / being referenced in Node.js apps

While the Uploader doesn't need to support SSR, it at very least needs to render an empty fragment and not throw an error.
Currently it throws the following:
ReferenceError: document is not defined
    at Object.e.exports [as insertStyleElement] (webpack://upload-website/./node_modules/uploader/dist/main.js?:1:81737)
    at Object.e.exports [as domAPI] (webpack://upload-website/./node_modules/uploader/dist/main.js?:1:81964)

Fixed in https://github.com/upload-js/uploader/releases/tag/v1.32.0


Support for material-ui

care to provide some detail on what exactly you want and why?

Hi I am using material-ui in my project.
I was wondering, any way to support material-ui in this library
http://www.material-ui.com/#/customization/themes

Not really, there was a similar issue raised a little while ago to support 3rd party render options. I think your best bet is to look at the source and just implement in your project from scratch, this isnt a very complex tool
Good luck!


Patch 1

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

If there is a negative-weight cycle, the algorithm shows that no solution exists. If there is no such cycle, the algorithm
produces shortest paths and their weights.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Reason: Since your PR was created, the master branch content has updated making some of your changes unnecessary or need to be reorganized to fit the current version.  Please re-sync your fork so you are looking at the latest version of master and then create a new PR if you find any changes warranted.  There is already an article for the Bellman-Ford algorithm, but you might be able to add some of your content to it if you like.
Thank you and happy coding.


Feature: Dark Mode for Prose

Tailwind CSS currently supports dark mode for prose using prose-invert which makes it pretty easy to use for dark mode. I don't think we have such functionality in Windicss as of(?) this can be really handy. By the time we have it included what can be the workaround for supporting dark mode classes in prose.

Take a look at #290 , I think it might answer your question.

Thanks I did apply the setting but didn't configure the dark mode properly i will make changes.


configuring themeStyle to dark does not work

Hello,
I like the theme very much, so thank you for sharing. :) Below is the description of my issue, but if you need any further details, please tell.
Describe the bug
Configuring dark theme does not seem to work
To Reproduce
In config.toml set
[params]
themeStyle                   = "dark"
Expected behavior
The generated website to be ... dark
Screenshots
N/A
Desktop (please complete the following information):

OS: Windows
Browser: Firefox
Version 84.0

Smartphone (please complete the following information):
Irrelevant
Additional context
N/A

Hi,
I couldn't reproduce the issue with the exsample site. Are the changes in the config.toml saved and is Hugo rebuilding the website?

I'm facing a similar issue, I've set the theme to dark mode, Hugo rebuilding the website too.
All the other changes take place except for this.

I observed this issue with the not extended version of Hugo. Only the extended version can process sass (style) files.
You can check your version of Hugo by running "hugo version". The output string should contain the word extended.
Installing the extended version of Hugo should fix this issue.

I think @MyGiHu is correct. I'm closing this for now, @deyangeor feel free to reopen if your issue is not resolved.

Hello,
I am sorry, but I was away for quite some time.
I am writing this to confirm that having the extended version "renders" the dark mode ... for future readers, you know.
Thanks a lot.
D

Hello,
I am sorry, but I was away for quite some time.
I am writing this to confirm that having the extended version "renders" the dark mode ... for future readers, you know.
Thanks a lot.
D


fix: add previous line hotkey to SQL Lab for macOS

SUMMARY
Adds an extra ctrl+p hotkey for macOS only that navigates to the previous line in SQL Lab editor.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up


hookConfigurationChanged: needs to be done earlier?

minor issue i just saw. don't have time to make a repo to reproduce the issue, if you can't reproduce, let me know.
if you set configurationSection like as in https://github.com/Microsoft/vscode-languageserver-node-example/blob/master/client/src/extension.ts#L32:
refreshTrace:
https://github.com/Microsoft/vscode-languageserver-node/blob/master/client/src/main.ts#L1119
The id being 'Language Server Example', the call to Workspace.getConfiguration is empty. Until the below kicks in:
hookConfigurationChanged:
https://github.com/Microsoft/vscode-languageserver-node/blob/master/client/src/main.ts#L1150

logs
"languageServerExample.trace.server" only
settings.json:
{
	"languageServerExample.trace.server": "verbose"
}

[1130/003946:ERROR:tcp_listen_socket.cc(76)] Could not bind socket to <IP_ADDRESS>:6004
[1130/003946:ERROR:node_debugger.cc(86)] Cannot start debugger server

"language server example.trace.server" & "languageServerExample.trace.server"
settings.json:
{
	"language server example.trace.server": "verbose",
	"languageServerExample.trace.server": "verbose"
}

[1130/004111:ERROR:tcp_listen_socket.cc(76)] Could not bind socket to <IP_ADDRESS>:6004
[1130/004111:ERROR:node_debugger.cc(86)] Cannot start debugger server
[Trace - 00:41:11] Sending request 'initialize - (0)'.
Params: {
    "processId": 0,
    "rootPath": "/Users/mbana/dev/vscode/ms/vscode-languageserver-node-example",
    "capabilities": {},
    "trace": "verbose"
}

[Trace - 00:41:11] Received response 'initialize - (0)' in 40ms.
Result: {
    "capabilities": {
        "textDocumentSync": 1,
        "completionProvider": {
            "resolveProvider": true
        }
    }
}

[Trace - 00:41:11] Sending notification 'initialized'.
Params: {}

[Trace - 00:41:11] Sending notification '$/setTraceNotification'.
Params: {
    "value": "verbose"
}

[Trace - 00:41:11] Sending notification 'workspace/didChangeConfiguration'.
Params: {
    "settings": {
        "languageServerExample": {
            "maxNumberOfProblems": 100,
            "trace": {
                "server": "verbose"
            }
        }
    }
}

[Trace - 00:41:11] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "file:///Users/mbana/dev/vscode/ms/vscode-languageserver-node-example/License.txt",
        "languageId": "plaintext",
        "version": 1,
        "text": "Copyright (c) Microsoft Corporation\r\n\r\nAll rights reserved.\r\n \r\nMIT License\r\n\r\nPermission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files \r\n(the \"Software\"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, \r\npublish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do \r\nso, subject to the following conditions:\r\n\r\nThe above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.\r\n\r\nTHE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF \r\nMERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE \r\nFOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION \r\nWITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\r\n"
    }
}

[Trace - 00:41:11] Sending notification 'textDocument/didOpen'.
Params: {
    "textDocument": {
        "uri": "git-index:/Users/mbana/dev/vscode/ms/vscode-languageserver-node-example/License.txt",
        "languageId": "plaintext",
        "version": 2,
        "text": "Copyright (c) Microsoft Corporation\r\n\r\nAll rights reserved.\r\n \r\nMIT License\r\n\r\nPermission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files \r\n(the \"Software\"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, \r\npublish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do \r\nso, subject to the following conditions:\r\n\r\nThe above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.\r\n\r\nTHE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF \r\nMERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE \r\nFOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION \r\nWITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\r\n"
    }
}

[Trace - 00:41:11] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "file:///Users/mbana/dev/vscode/ms/vscode-languageserver-node-example/License.txt",
    "diagnostics": []
}

[Trace - 00:41:11] Received notification 'textDocument/publishDiagnostics'.
Params: {
    "uri": "git-index:/Users/mbana/dev/vscode/ms/vscode-languageserver-node-example/License.txt",
    "diagnostics": []
}

Looked at the code and this can't be done earlier due to the fact we can only send configuration changes over the wire when the server returned successfully from the initialize method.
Closing. Please ping if you think there is a issue with this assumption.


substation visuals don't work

Description

the screen and light is always on, even when unanchored and not connected. The light meant to represent the charge also never changes from full.

Is this an issue with the sprites, or the code?

to clarify: it's the code side of things. substations need to get a visualizer of some kind hooked up to manage all that stuff. checking how SMES does it would be a good start.

do we have unpowered substation sprites? im basically in the middle of power code after working on emp grenades so i could take a look

All the assets exist the code just doesnt

ok i need to sleep but i can work on it tomorrow if someone else doesnt take it, it'll be a nice change to coincide with emp grenades disabling substations


Let pre-commit run pylint

pre-commit requires less custom scripts to run pylint

Now that we have CI I don't think we need this PR any more.


Undefined constant "CodeIgniter\CLI\STDOUT"

CodeIgniter Version: 4.1.3
PHP Version: 8.0.6
PHP SAPI: fpm-fcgi
Getting Undefined constant "CodeIgniter\CLI\STDOUT" error from vendor/codeigniter4/framework/system/CLI/CLI.php Line Number: 162
This was not an error before upgrading to 4.1.3; downgrading back to 4.1.2 removed this error from my project.

This is a duplicate of #4843 and will be fixed by #4844.

Fixed in 8d09d10.


feat(perception): change detection region

Signed-off-by: badai-nguyen<EMAIL_ADDRESS>Description
This PR to extend the detection region of ground segmentation. As the result, it also extend the region of perception module.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[x] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen I think the computational cost will increase. May I ask you to compare the CPU utilization of ground segmentation and compare map filter, which seems to have a large impact?

Since ground_segmentation is included in component that's quite hard to monitor cpu usage percent, so I compare the processing_time before and after change the detection range.
Before extending:

@miursh
Thank you. I modified here. Could I ask you for review it

@badai-nguyen Thank you! LGTM 👍
Could you resolve the conflict?

@badai-nguyen Thank you! LGTM +1 Could you resolve the conflict?

@yukkysaito Since  ground_segmentation.param.yaml was removed by commit #2539 and I also create PR
for autoware_launch. Shall we close this PR?

@badai-nguyen Thank you!
It's ok 👍

Close because the ground_segmentation.param.yaml was removed.

@badai-nguyen You need to change param in autoware_launch instead of tier4_perception_launch


Landscape-only iPad app briefly shows portrait splashscreen on startup

To repro:

Create a build in Build Service, where only landscape orientations are allowed
Install and start app on an iPad

Expected: Landscape splashscreen is shown on startup and app is locked to landscape mode
Actual result: Landscape splashscreen is shown briefly, followed by the portrait splashscreen. App starts correctly in landscape mode.
Tested on iOS 7.1.2, iOS runtime 3.5.1.

Not really high priority, but any idea when this may be fixed? :)


Confirm if bluemixAppGUID is still necessary in initializing bluemix SDKs on iOS

via email from Roded, we may not need the bluemixAppGUID in our bluemix.plist due to the changes in the services BluePic relies on. This task is to confirm that, remove bluemixAppGUID if necessary, and make sure the Readme is updated.

Looks like app route and appGUID for a Bluemix app are not required to initialize the Bluemix core SDK (BMSCore) as seen in their documentation: https://github.com/ibm-bluemix-mobile-services/bms-clientsdk-swift-push#initializing-the-core-sdk


upgrade to zstd-jni 1.5.6-2

https://github.com/luben/zstd-jni
https://repo1.maven.org/maven2/com/github/luben/zstd-jni/

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (900caf4).
Report is 212 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12797       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2387       -49
  Lines        133233   131166     -2067
  Branches      20636    20279      -357
=============================================
- Hits          82274        0    -82274
- Misses        44911   131166    +86255
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ready for review


wheel for the latest version is unavailable on PyPI and the homepage link is missing

I guess a wheel should be uploaded.

wheels are uploaded https://pypi.org/project/annotated-types/#files


Consider truncating overlong graphemes instead of invoking UB when they are encountered.

This may no be so simple, considering the number of places that 32-CP buffers are used, due to the Safe-Stream format assumption.

This may be accomplished in a roundabout way by changing stream_safe_copy() simply to truncate.

This is not done internally in any of the Text functions, but it is available via stream_safe() and friends.


Normalize defaultWheelDelta

Normalized defaultWheelDelta so that it returns the same scaling speed in Chrome/FF/Edge. IE is still slightly different. Works with all three deltaModes (0 => Pixel, 1 => Lines , 2 => Pages). Also uses event.wheelDeltaY when possible (Chrome and Edge), because it returns the same value on both browsers, while event.deltaY varies widely.
Related: https://github.com/d3/d3-zoom/pull/100

My interpretation is that you are proposing two independent changes to the default wheel normalization behavior, so I’d like to disentangle these changes and discuss them separately.
First, wheel vs. mousewheel. d3-zoom listens to wheel events, which is the recommended standard:
https://github.com/d3/d3-zoom/blob/6f8b119399f1b68183974ae818b9900514a24df0/src/zoom.js#L73)
event.wheelDeltaY is part of the deprecated mousewheel event, which we don’t listen to. While Chrome and other browsers treat the deprecated mousewheel event as an alias for the wheel event and report the deprecated mousewheel properties on wheel events, we shouldn’t use deprecated fields in browsers that support recommended standards. (And even if we did want to use the deprecated wheelDeltaY, it probably doesn’t make sense to apply a multiplier derived from non-deprecated deltaMode.)
Second, this changes the delta multiplier for DOM_DELTA_LINE (deltaMode = 1) from 120 to 40, and the multiplier for DOM_DELTA_PAGE (deltaMode = 2) from 120 to 800. Is that your intention, or was your primary intention just to favor the deprecated mousewheel event? If so, the new discrete multipliers seems reasonable, but I don’t have a discrete mouse to test on.

Here is a list of the values of wheelDeltaY vs. deltaY (albeit a bit older but I sure it is still largely valid): https://stackoverflow.com/a/24595588

Merged as f21cdfdcf4aff65f2bba38f20080bfc9a2985aeb, then adjusted as 30d47e0deb150fdf327f2afca17eafcf0205e24d so that one “page” scroll corresponds to exactly one power-of-two zoom level, and one “line” scroll corresponds to 1/20th of a page.
So, to summarize:
For deltaMode = 0, the multiplier is still 0.002 (1 / 500).
For deltaMode = 1, the multiplier decreased from 0.24 (120 / 500) to 0.05.
For deltaMode = 2, the multiplier increased from 0.24 (120 / 500) to 1.

I see that this was solved by the new multipliers. I still have a problem though: on windows (it seems) my event.deltaY is either 120,108 or 102. Now if I use the default wheelDelta it makes huge jumps. e.g. from 100% to 411% after one "roll". (I need to mention that in my case 1 roll does nothing, but if my wheel rolls 3 "clicks", I have an actual wheelDelta of 306 (probably 3 * 102). And so I land directly at 411% zoom. If I keep going I end up at 1200% directly (which is my max zoom).
I first thought I could just check for
if (Math.abs(event.deltaY >= 102) {
// return a smaller value
}

But (!) if I scroll quickly on an apple magic mouse or if I use a trackpad and scroll very fast, the delta value sometimes goes above 102 as well and in this case it is wanted behaviour. Now google for example must have a solution for their map zooming as well, but I can't really figure out how I could catch this. Do I have to try to check for the OS?
I would be very glad for any ideas!


Updates not Applying when using Version 4.01

I tried the new 4.0.1 version this month to prep updated media for Configuration Manager OSD tasks, and I encountered some issues. I grabbed a screen shot of the PowerShell window while I was trying to patch Server 2019, but I noticed the same behavior for Server 2022 and Windows 11 23H2. A warning appeared with a path that didn't exist, and I think it because it has Unkown Version in the path. I ended up using the script version 3.4.8 to patch the wim's.
Current Behavior

The finished wim is not patched as it didn't apply the updates to the source wim file.
Possible Solution

Not sure how to fix but I think the issue is due to the path having Unknown Version
C:\wimwitch\updates\Windows Server\unknown version\SSU
C:\wimwitch\updates\Windows Server\unknown version\LCU
C:\wimwitch\updates\Windows Server\unknown version\AdobeSu
C:\wimwitch\updates\Windows Server\unknown version\DotNet
C:\wimwitch\updates\Windows Server\unknown version\DotNetCu

Your Environment

Module version used: 4.0.1
Operating System = Windows 10 22H2
PowerShell version:5.1.19041.4123

I have the same issue.  See https://github.com/alaurie/WimWitchFK/issues/26#issuecomment-1979535198


a display bug ,very important

i use codemirror for a editor of some conf file, sometimes load like this:

but sometimes:

and this is the Develop tool capture：

The style you circled is on the hidden textarea and will not impact the display of the editor. If you can provide me with an HTML page, a browser in which this happens, and instructions to reproduce it, I'll gladly try to debug it.


create own repo of govuk-react/icons

split out icons into its own independent repo so can be used on other projects

scoped as @govuk-react/icons

now the project is a monorepo, we have a @govuk-react/icons package that will be published and can be used independently, so separating icons in to a separate repo may no longer be needed.

@marksy should we close this?


State of master - Ready for a new release?

It's been nearly 2 years since the last release.  246 commits later, perhaps it's time for a new one?  Is master stable?

Yes and yes.
As it happens, just this weekend Matthew and I merged or punted most of the issues on the 0.7.0 milestone in preparation for a release.
The blockers are one regression and writing changelog, etc.
After that we can release — and then merge some destabilizing PR's and release 0.8.0-beta1 :-)
Thanks for the reminder!

Update. We just merged a fix for the last significant blocker, #576. Remaining tasks:

[ ] Wait a few days for regression reports. (Considering the weekend and summer holidays, shall we wait until Friday?)
[ ] Fix #623 (test expectations)
[ ] Appoint a release manager
[ ] Release

A regression has been found, #627, so the release will be delayed. (We could tag a 0.7.0-beta1 even now, of course, but I don't know whether we will.)

Haven't forgotten about this, but we are still waiting for someone to step up and volunteer to be the RM.

We seem to be making little progress :(
@phy1729 @nicoulaj I'm starting to wonder if we should release without updating changelog, to reduce the workload. Thoughts?

0.7.0-beta1 has been released.

Just merged a fix to #670.  Unless regressions are reported, we're ready to release.

Released — later than I wanted to, but with the regressions fixed before the release.  (except #677)


Warning: libRCTAMapLocation was built for newer iOS version (10.1) than being linked (8.0)

ld: warning: object file (/Users/jagger/Library/Developer/Xcode/DerivedData/zaiqiuchang-fwykrwmotbpozgegbmtywbczscln/Build/Products/Debug-iphonesimulator/libRCTAMapLocation.a(RCTAMapLocation.o)) was built for newer iOS version (10.1) than being linked (8.0)
Does the builtin lib can work on iOS 8.0?

I'm sorry the lib can only work on ios 10 and newer.

Why? Does it the reason about amap's SDK? And I'm just using iOS 10.2 for testing, but it is still not working.

Can you show me the error message using ios 10.2?


More detailed stats

Proposition to add "stat ecfdetails" which will show how many typed actions of every type is running and how much time it takes.

Done


[ ] - Crop images to size

fixed issues...


Disable row-scope disambiguation syntax for C# hosts

table[@Field] instead of As is curreently still supported in the C# host. We should remove this support before shipping V1.

Luckily this is easy to clean up. returning early from Binder.cs::IsRowScopeAlias() based on a flag would disable this.

Note that just returning false from IsRowScopeAlias will cause us to hit other cases and still attempt to bind the expressions. So we should at just give an error if IsRowScopeAlias  is true.
Or better yet - IsRowScopeAlias is at the binder - can we disable at the parser level?
Should also confirm that intellisense doesn't suggest it.

Do we also disable it in the case of unqualified field name?
e.g. Filter([1,2,3],ThisRecord[@Value]=2)


Display bug crop PDF

Selecting a pdf isn't properly displayed (see below). It also only displays one page (not sure how the feature should work with multiple pages).

A pdf of the page itself as an example.
Also the title on the crop page is "Crop Image" while on main page it is "Crop PDF". Seems like a lack of convention between card naming and tool page name.

The first issue you mentioned is not a bug. You're supposed to select an area (first page is given for reference), and then each page in the pdf is cropped based on that rectangle you selected.
I think the name should be Crop PDF. Good catch!

So it is intentional for the pdf to be more than the viewport? To start under the submit button and go all way on the right outside of viewport? Others like rotate, split; display the pdf in a much nicer way where you can see the whole pdf. Right now it seems like it lacks a css class to it. You have to unzoom the browser which isn't a nice experience. From my pov it should more look like other features with the pdf being centered and take full viewport and not go outside for precise cropping.
Maybe add a little description of how it works? "Select an area on the first page and it will crop the same for all pages"?


PLT-7811 - Error logging machinery to WithTracer.hs; raise error on file write timeout during indexer close

The logging machinery we decided on as a result of https://input-output.atlassian.net/browse/PLT-7809 has been added.
Additionally, when a timeout occurs during async file writing in FileIndexer on shutdown, an error is raised and logged.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense and have useful messages
[ ] Important changes are reflected in changelog.d of the affected packages
[x] Relevant tickets are mentioned in commit messages

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[x] Targeting main unless this is a cherry-pick backport
[x] Self-reviewed the diff
[x] Useful pull request description
[ ] If relevant, reference the ADR in the PR and reference the PR in the ADR
[x] Reviewer requested

Noting that the merge conflicts come from the recent restructuring to migrate the "legacy" marconi-chain-index and keep only the formerly "experimental" version.
So in other words, the conflicts should be able to be resolved by just taking the change in a path marconi-chain-index/src/Marconi/ChainIndex/Experimental/<path> and applying it to marconi-chain-index/src/Marconi/ChainIndex/<path>.


AVT 1 - Form Item: DAP violations related to label

Environment
macOS Mojave version 10.14.2
Chrome version 72.0.3626.96 (Official Build) (64-bit)
Detailed Description
Run DAP with Feb. 2019 ruleset on the Form Item Component
The following violations are reported:

Each form control must have an associated label
H44: Using label elements to associate text labels with form controls
ARIA16: Using aria-labelledby to provide a name for user interface controls
Provide descriptive text in label element
4.1.2 Name, Role, Value

Related to #1932

@snidersd thanks for reporting this!
I appreciate that you took the time to look into this thoroughly!
I am wondering before I start developing this if I get the requirements right. I hope you dont mind explaining to me a little bit more what is to be expected from 1. and 2.

Each form control must have an associated label

regarding

H44: Using label elements to associate text labels with form controls

Please help me to fully understand this before starting implementing! :)
The input item has a label associated with i,  is that label missing some requirements or what one would expect this to have to be according to a11y standards?

ARIA16: Using aria-labelledby to provide a name for user interface controls

I think I get this, input elemtn needs to have aria-labelledby. Correct me if I am wrong! :)

Provide descriptive text in label element
4.1.2 Name, Role, Value

Also I think this is straightforward enough, always feel free to correct me when I get something wrong.
label element needs correct Name, Role, and Value.
Can you please clarify a little bit more what does Name and Value would be by giving a simple example?
T h a n k s @snidersd !

@paschalidi I just ran DAP again this morning and the issue is no longer present so I'm marking this one as closed.  The only thing DAP is reporting now is a false positive due to a known DAP defect with disabled fields.

@paschalidi  Sorry, I closed this issue in error. I retested the Form component rather then the Form item (see the correct screenshot below).


May 2024 PyData Theme audit findings

### Tasks
- [ ] There are two separate hierarchies of headings on the page (section navigation and the main article). Should the "on this page" navigation have headings? Argument against: the area can be reached via landmarks. Argument for: the section navigation has heading so it feels like a inconsistency in UX
- [ ] DEV The light/dark toggle button does not communicate its state
- [ ] DEV Sphinx-togglebutton expand/collapse button does not communicate its state
- [ ] DESIGN Sphinx-copybutton is not visible until hovered or focused
- [ ] DESIGN Sphinx Design Tabs need other hover indicator other than just color change (underlining?)
- [ ] DESIGN Dropdown admonition chevrons hover effect is a little too subtle?
- [ ] DEV (maybe DESIGN) Copy button tooltip (native/browser does not meet criteria, does the other one meet the criteria, do we need both?)
- [ ] DEV (with review from DESIGN) Not enough space between navbar icon buttons
- [ ] DEV (with review from DESIGN) Not enough space between the links in the "on this page" navigation
- [ ] Search input modal allows user to tab away from it without explicitly dismissing it
- [ ] Mobile sidebar modal allows user to tab away from it without explicitly dismissing it
- [ ] Search input modal does not return focus to opener (search button) when modal is closed
- [ ] Read the Docs version switcher is not reachable using only keyboard (tab key)
- [ ] Read the Docs switcher is sometimes on the left below the section navigation, sometimes fixed to the lower right portion of the viewport. From Accessibility Insights audit: Functional components that appear on multiple pages must be identified consistently.
- [ ] Are there any divergent links? Find and fix all divergent links (same name, different URLs)
- [ ] Are there any convergent links? Review on case-by-case basis
- [ ] Some components do not respond to user text spacing adjustment: Version switcher trigger button, Search bar trigger button, Search bar input, More dropdown trigger button
- [ ] Tooltips for the icon links/buttons in nav bar are neither dismissible nor hoverable
- [ ] Needs investigation: does search button (magnifying glass) on mobile meet [WCAG 1.4.11](https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html)? More generally, is it putting our best foot forward?
- [ ] Assistive tech does not have access to the "external link" icon next to external links in the nav bar (such as the "Changelog" link in the PyData Theme docs)
- [ ] All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels)
- [ ] The hover+focus state of the nav bar icon links do not look good
- [ ] The anchor links (next to the headings and only visible on hover) do not have sufficient contrast with the site background
- [ ] Missing hover colors in high contrast
- [ ] H2 and H3 headings too similar visually

Derived from #70 and our shared Google Drive folder where the Accessibility Insights audits were saved

Notes from today's sync (May 23)
Question - other audit checks beyond accessibility insights?

Turn off CSS, what happens?
Turn off JavaScript, what happens?

Tania suggests:

a screen reader audit through Fable. Clarify: after we address our own audit.
check against ATAG

copybutton identified issues:

there is not enough contrast on hover (light mode, dark mode needs checks)
there are two tooltips displayed at all times -> need to remove one
whichever we use need to be visible in high contrast mode
needs check: ARIA should be applied accordingly in which case the SVG is purely decorative (icon)

Derived from #70 and our shared Google Drive folder where the Accessibility Insights audits were saved

Can/should this be made public ?

Accessibility insight is a browser extension. I'll try to move some of the relevant files to this repository and try to add some details on how to use it.


wip: add AppendVecFileBacking

Problem
trying to get rid of mmaps on append vecs.
Summary of Changes
introduce AppendVecFileBacking. This can hold always a mmap, or a rwlock protected enum of mmap or file and buffer.
Fixes #

done as part of a separate pr


https://www.hackerrank.com/challenges/kangaroo/problem

why?

 Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.


Read and Write Logs

Either create a logging method and write a file. Or possible leverage the internal logging mechanisms and simply output to the websocket server.

@ewilliams0305 why don't we take the work you have done here and make it into a serilog custom sink.
That would handle the file storage outwith this project and leverage all of the serilog goodness!
I'd be happy to contribute !

@neilsilver I actually have a pulled this into a private repo for work that I'm not "allowed to share". It's a bit larger now and includes a very rough sink. I'll pull the code back into this soon and see where that leads.

@ewilliams0305 cool let me know, we have most of our code in private repo's but I was encouraged by your OS approach and I think that if we create the sink as an OS and publish to nuget and I (maybe you) and others can consume it in our other softwares then we will have a vested interest in maintaining th OS portion.
I have writen this up as a Serilog sink and have done a few changes to support some auth , dynamic port allocation , encryption and support on device aswell as server. As i say im keen to open source it as much as possible!

@neilsilver thats great, I'm generally in the boat. When it didn't get any traction I pulled a lot of it into our main repo. Working on this now, hopefully it doesn't trash too much of what you did. I created a netstandard 2.0 library and wrapped it on the 4.7.2 Crestron library. This was complete Ed so I could use the same code outside of the Crestron Land. There won't be too many broken public APIs and generally the only change will include a directory parameter in the constructor (removed GetApplixationRootDirectory from inside the library). I'll probably push it up shortly.

@neilsilver separated the projects and created two nuget packages WebLogger and WebLogger.Crestron (need to clean up a bit).  Refactored a bunch of stuff, so sorry that is basically a totally breaking solution change.  Also created a dev branch.  Check it all out.  I also added  params to the Write method to reduce boxing.  There is also a new IWebLogger interface so this can be mocked.  Check it out!

Ill take a look !


[Question] action?library:dialog payload is broken

Pre-flight checklist

[ x ] I have searched the existing issues before logging a new one.

System Information (Required)

Node*
SDK version 3.8.1
**Development environment - localhost **
**Node.js 6.10.3  npm version 3.10.10 **

Issue Description
I'm setting up quick replies using the new          msg.suggestedActions(             builder.SuggestedActions.create(session,arr)         )
when arr is an array of:
builder.CardAction.postBack(session,'action?library:dialog' , 'title')
which supposed to direct to a specific dialog in a library.
when i use it, it does not being redirected to the correct dialog, but to the root dialog
i tried also:

using imback instead

use it with get started facebook button - failed as well

use it with a simple action with beginDialogAction - failed

Tested it once again and i can confirm this issue appeared since  v3.8.0 (works fine on v3.7.0)

@amitbend can you post your complete bot code that reproduces this issue? thx

@nwhitmont this is a very simplified  version
on index.js
bot.library(require('./library1'));
bot.dialog('/',[(session,args,next)=>{      let msg = new builder.Message(session).text(["main dialog"])      msg.addAttachment(new builder.HeroCard(session).buttons([builder.CardAction.imBack(session, "action?library:dialog", "➡")]))     session.endDialog(msg); }])
on library1.js
const library = new builder.Library('library');
library.dialog('dialog', [
 (session, args, next) =>{
    session.send('simple dialog here')
 }])

module.exports = library;
`
clicking on the imBack button does not redirect to the dialog in the library since v3.8.0
the same outcome can be also achieved by defining a get_started button  with the same payload action?library:dialog

@amitbend Here is an example that demonstrates how to use the Library feature to invoke a dialog: https://github.com/Microsoft/BotBuilder/tree/master/Node/examples/basics-libraries
For example, in localeTools.js L33 there is an example starting the dialog by name:
exports.chooseLocale = function (session, options) {
    // Start dialog in libraries namespace
    session.beginDialog('localeTools:chooseLocale', options || {});
}

I'm not sure why you are using action?library:dialog instead of just library:dialog as shown in the example code.
Where did you find the documentation or example that describes prepending action& to library:dialog?

@amitbend For the action bindings that use the "action?" syntax you need to add a "named action" that matches your binding. So in your example library this should work:
 const library = new builder.Library('library');

    library.dialog('dialog', [
     (session, args, next) =>{
        session.send('simple dialog here')
     }]);
     library.beginDialogAction('library:dialog', 'dialog');

module.exports = library;

That should let you push the dialog onto the end of the stack using action?library:dialog. With that said we've started recommending that people use triggerAction() instead, paired with a simple imBack or postBack. So:
 const library = new builder.Library('library');

    library.dialog('dialog', [
     (session, args, next) =>{
        session.send('simple dialog here')
     }]).triggerAction({ matches: /^main dialog/I });

module.exports = library;

This would let you trigger the dialog using builder.CardAction.imBack(session, "main dialog", "➡")

thanks for the example! @Stevenic

Thanks for the answers @Stevenic  and @nwhitmont
So first of all @nwhitmont the most obvious situation to use it is from Persistent menu, using the method you've described requires me to build many dummy dialogs at the root of the bot to redirect to the libraries, and it doesn't seems like a good practice.
I can't remember where i saw exactly an example using this, but In the docs it is written
Can be used anywhere a postBack is valid. You may also statically bind a button to an action for something like Facebooks Persistent Menus. The payload for the button should be action?<action> for actions without data or action?<action>=<data> for actions with data.
which in case of a bot using libraries it makes sense library:action will be possible.
@Stevenic

The first example seems like a good enough solution, but it doesn't work in the global scope - so it is not relevant to a persistent menu for example
Using triggerAction is my workaround right now, but this is also a problematic solution, as it is not a 1:1 routing and also can be very problematic when using a recognizer like LUIS (am i correct?)

Will it be possible to restore the option to route this way?
For 1:1 routing is seems to me the best and the most efficient solution.
What do you think?

@amitbend I'll have to try to reproduce why the action binding isn't working but in the meantime you can create a triggerAction() with a reg ex that looks for something like trigger=library:dialog which should achieve exactly the same thing.

@nwhitmont @Stevenic is it fixed?

@nwhitmont @Stevenic any update?
The issue was closed without specifying a reason.

Not a bug

@Stevenic Suggested this solution, but it seems to be a bug.
` const library = new builder.Library('library');
library.dialog('dialog', [
 (session, args, next) =>{
    session.send('simple dialog here')
 }]);
 library.beginDialogAction('library:dialog', 'dialog');

module.exports = library;`
So currently it is not possible to start an action in a Library(except regex with triggerAction) , i believe this is a bug @nwhitmont

@amitbend I'll have to try to reproduce why the action binding isn't working but in the meantime you can create a triggerAction() with a reg ex that looks for something like trigger=library:dialog which should achieve exactly the same thing.

Hi @Stevenic, so I'm trying to move to triggerAction instead of the beginDialogAction() but I can't seem to find the right regex pattern to match the button click ``action?loadreference-pt=[Invoice Number]".
and the equivalent to:
bot.triggerAction('loadreference-pt', '/loadreference-pt');
I've tried:
.triggerAction({         matches:  /action?loadreference.pt=\w+/     });
But it's not working.
Could you help me out?


Update contactpanelactivatedeventargs_contact.md

Explicitly call out the fact that by default, the provided contact only has its Id property set.  The contact needs to be re-retrieved from the ContactStore before you get access to all of its property data.

@r0bfr,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


seek() method of Video is missing.

<Video> in motion canvas has seek() method so that we can navigate through the timeline. Somehow this method is missing in revideo.  Correct me if I'm wrong, but I couldn't find any other way to do this.

Oh, you're right. We have been optimizing the performance of the seek operation on the <Video> tag a lot which is why there are now three different seek functions with different trade-offs and speed improvements. Somewhere along those changes, it looks like we accidentally changed seek() from public to protected. Will change it back to public, release a new version, and get back to you!

What a quick response! That'll be great. Thank you so much!!

As a workaround, you can just delete the old <Video> tag and create a new one at the time that you want to seek to.

Oh I didn't know that one. I'll try that right away. Thank you!

How would I do that? I'm trying to seek so I can start the video a second after it begins (we have issues where the video recordings start black for a second). Is this possible? I think this is the same issue, but if not, I'll make a new one.


[BUG] Failing to connect to an OpenSearch cluster with a bad username/password gives unhelpful error

What is the bug?
Failing to connect to an OpenSearch cluster with a bad username/password gives unhelpful error:
Exception in thread "main" jakarta.json.stream.JsonParsingException: Jackson exception: Unrecognized token 'Unauthorized': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (ByteArrayInputStream); line: 1, column: 13]
	at org.opensearch.client.json.jackson.JacksonJsonpParser.convertException(JacksonJsonpParser.java:97)
	at org.opensearch.client.json.jackson.JacksonJsonpParser.fetchNextToken(JacksonJsonpParser.java:104)
	at org.opensearch.client.json.jackson.JacksonJsonpParser.next(JacksonJsonpParser.java:131)
	at org.opensearch.client.json.JsonpDeserializer.deserialize(JsonpDeserializer.java:82)
	at org.opensearch.client.json.ObjectBuilderDeserializer.deserialize(ObjectBuilderDeserializer.java:92)
	at org.opensearch.client.json.DelegatingDeserializer$SameType.deserialize(DelegatingDeserializer.java:56)
	at org.opensearch.client.transport.rest_client.RestClientTransport.getHighLevelResponse(RestClientTransport.java:271)
	at org.opensearch.client.transport.rest_client.RestClientTransport.performRequest(RestClientTransport.java:143)
	at org.opensearch.client.opensearch.cluster.OpenSearchClusterClient.getSettings(OpenSearchClusterClient.java:282)
	at org.opensearch.dataprepper.plugins.sink.opensearch.index.AbstractIndexManager.checkISMEnabled(AbstractIndexManager.java:187)
	at org.opensearch.dataprepper.plugins.sink.opensearch.index.AbstractIndexManager.checkAndCreateIndexTemplate(AbstractIndexManager.java:208)
	at org.opensearch.dataprepper.plugins.sink.opensearch.index.AbstractIndexManager.setupIndex(AbstractIndexManager.java:203)
	at org.opensearch.dataprepper.plugins.sink.opensearch.OpenSearchSink.doInitializeInternal(OpenSearchSink.java:174)
	at org.opensearch.dataprepper.plugins.sink.opensearch.OpenSearchSink.doInitialize(OpenSearchSink.java:139)
	at org.opensearch.dataprepper.model.sink.AbstractSink.initialize(AbstractSink.java:39)
	at org.opensearch.dataprepper.pipeline.Pipeline.isReady(Pipeline.java:194)
	at org.opensearch.dataprepper.DataPrepper.execute(DataPrepper.java:93)
	at org.opensearch.dataprepper.DataPrepperExecute.main(DataPrepperExecute.java:42)
Caused by: com.fasterxml.jackson.core.JsonParseException: Unrecognized token 'Unauthorized': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')
 at [Source: (ByteArrayInputStream); line: 1, column: 13]
	at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:2418)
	at com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:759)
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser._reportInvalidToken(UTF8StreamJsonParser.java:3693)
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser._handleUnexpectedValue(UTF8StreamJsonParser.java:2781)
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser._nextTokenNotInObject(UTF8StreamJsonParser.java:907)
	at com.fasterxml.jackson.core.json.UTF8StreamJsonParser.nextToken(UTF8StreamJsonParser.java:793)
	at org.opensearch.client.json.jackson.JacksonJsonpParser.fetchNextToken(JacksonJsonpParser.java:102)
	... 16 more

How can one reproduce the bug?
use opensearch-java client with wrong username or password configured to call any API against a opensearch engine
What is the expected behavior?
A clear error message indicating wrong username or password
What is your host/environment?
macOS.
Do you have any screenshots?

Do you have any additional context?
The bug seems to be at parsing with both RestClientTransport and AwsSdk2Transport

@wbeckler This one seems not so straightforward to fix as the low level response entity is just a string value of Unauthorized which is not valid json. We probably need to modify that message to be more clear. Do you have suggestions where it can be modified?

@chenqi0805 The fix you submitted for this error parsing issue is an improvement. Thank you for these bar-raising issues and PRs. To answer your question above, for issues around the response from the OpenSearch server, one option is to open an issue in the core repo, https://github.com/opensearch-project/OpenSearch/issues


Add K3S Provider in Liqoctl

Description
This pr adds a new provider to allow the liqoctl to retrieve parameters from K3S clusters
How Has This Been Tested?

[x] Manually
[x] Add new unit test

/test

/test

/merge


Issue in

I am getting this error when i run all cells and not able to get the images to refine the model, any help greatly appreciated i followed along with instructions I have changed the robomaker and sagemaker files to the ones i uploaded but i cant get past this error thank you in advance also the kernel version used in the example is no longer available i have used conda_amazonei_pytorch_latest_p37 and conda_tensorflow2_p310 but same error

After running more tests today I was able to determine it was to do with the format of the robomaker file, if I upload your robomaker file it works somewhat but when I ran another training session today and used those new logs in the notebook same error so I am wondering if there was a change to the log format and what it was so i can get this program to run any help greatly appreciated


Test Device: File Size persistence?

This is more of a question than an issue. Should the file size be re-assigned every time Server goes down? Should it be persistent and written in a file somewhere?

This likely needs to be persistent and written on a file. I don't think there's any way to avoid that. Currently you have:
https://github.com/padrezulmiro/segc-035-T1F1/blob/ef60659cfb501f31817b87625126d62bc9190767/iotserver/ServerManager.java#L64-L71
- which will not work if the .class file doesn't exist. And we shouldn't assume it will exist since the server wouldn't usually have access to it in a realistic scenario.

The professor's explanation for this is to have it hardcoded in file or get the file's size through a script. We can handle this later


Switch definitions from lazy vals to vals?

Scala.js 1.11 (news) now removes unused fields.
If I understand correctly, this means that we can have e.g. val div = htmlTag("div") instead of it being a lazy val, and if you never use div-s in your app, div won't be included in the JS bundle, similar to how it works today with lazy vals.
This would be great for us because having a hundred lazy vals for all the tags and properties that you use obviously comes with some overhead, and even if it's not really noticeable, it would be great to simplify.
However, we need to test whether the Scala.js optimizer is smart enough to recognize our implementations of def htmlTag as "pure", and thus removable, otherwise we won't win anything. For Laminar the implementation instantiates a class HtmlTag which inherits from a trait with two public val-s, the constructor doesn't do anything else other than set those vals. For Outwatch and other consuming libraries, I'm not sure, but I suspect it's something similar. I'm hoping all our implementations are pure enough.

Scala DOM Types now leaves this choice to the library starting with 17.x, so I am marking this issue as discussion only, there's nothing actionable in SDT.
If you try any approaches that aren't lazy val in your library, please let me know how it went.


Assertnolog context manager

fixes zulip#16828

This PR is about the assertnoLogs context manager which will keep a watch about unnecessary logging.

In the previous test some test were failing and it was not working as expected so I have proposed new solution please help me if i am missing somewhere.The logging test case class class captures logs if the test passes, the output is thrown away.If the test fails, the output is displayed.Captured_logs tries to capture logs from context manager assertlog. If the logs are there assertlogs throws an assertion error if no logging is written because there could be test cases that do not log anything, this code captures that exception and ignores it.There is context manager assertnologs which will fail if messages are logged within the context manager.Otherwise this context manager will take care about unnecessary logging.
Please let me know why I am failing tests in CI.

In the previous test some test were failing and it was not working as expected so I have proposed new solution please help me if i am missing somewhere.The logging test case class class captures logs if the test passes, the output is thrown away.If the test fails, the output is displayed.Captured_logs tries to capture logs from context manager assertlog. If the logs are there assertlogs throws an assertion error if no logging is written because there could be test cases that do not log anything, this code captures that exception and ignores it.There is context manager assertnologs which will fail if messages are logged within the context manager.Otherwise this context manager will take care about unnecessary logging.
Please let me know why I am failing tests in CI.

fixes #16828
This PR is about the assertnoLogs context manager which will keep a watch about unnecessary logging.
n the previous test some test were failing and it was not working as expected so I have proposed new solution please help me if i am missing somewhere.The logging test case class class captures logs if the test passes, the output is thrown away.If the test fails, the output is displayed.Captured_logs tries to capture logs from context manager assertlog. If the logs are there assertlogs throws an assertion error if no logging is written because there could be test cases that do not log anything, this code captures that exception and ignores it.There is context manager assertnologs which will fail if messages are logged within the context manager.Otherwise this context manager will take care about unnecessary logging.
Please let me know why I am failing tests in CI.

fixes #16828
This PR is about the assertnoLogs context manager which will keep a watch about unnecessary logging.
n the previous test some test were failing and it was not working as expected so I have proposed new solution please help me if i am missing somewhere.The logging test case class class captures logs if the test passes, the output is thrown away.If the test fails, the output is displayed.Captured_logs tries to capture logs from context manager assertlog. If the logs are there assertlogs throws an assertion error if no logging is written because there could be test cases that do not log anything, this code captures that exception and ignores it.There is context manager assertnologs which will fail if messages are logged within the context manager.Otherwise this context manager will take care about unnecessary logging.
Please let me know why I am failing tests in CI.

Hi @dineshssdn-867 I went through the changes you made and testing them in my system does not  gives results as expected, in fact they gave various errors. You can test for your code manually by using it as a context manager in any tests in zerver/tests/ and the using tools/test-backend for running those tests and then check for desired error raised by using this context manager.
You can refer to https://zulip.readthedocs.io/en/latest/testing/testing.html?highlight=backend%20testing#running-tests for more details on running tests.

Regarding CI failure, it shows in the running log that it is due to missing coverage, so here's what coverage means here:
When automated tests are run, they track which lines of code have been executed as part of the test. If lines of code aren't executed during the test run, then they are not really "covered" by the test, which means whatever logic they help implement isn't tested, and that logic might be broken. You can fix it by adding proper tests or by updating existing tests so that they test what code you written. But the code you wrote does not solves the issue at any end so first you should fix that and then you can go for fixing these coverage issue in your newly added/modified code.
You can use /tools/test-backend --coverage to test coverage locally.

It may be that we don't want this change (see the issue thread), but in any case any PR should be rebased in a way that doesn't generate merge commits.
Check out our GitHub guide and commit guidelines for more details.

Because the source repository for this pull request was deleted, this pull request has been automatically closed by GitHub as an unintended side effect of renaming our default Git branch. If this change is still desired, please open a new pull request, referencing this one in the description.


Semistandard over AirBnB for eslint

SRSLY. feel free to add that rule to any project you create from the templates.
Comma management is time you never get back...


fix: views overlap on auth screen

Details

There was a custom styling set on iOS to set the height to a fixed flex: 1, changes are made to make it's min height 100%.
Fixed Issues

$ https://github.com/Expensify/App/issues/7122
Tests

Goto login page enter a registered email.
Enter a wrong password, so that an error appears.
Verify that terms copy text to the bottom does not overlap.

[x] Verify that no errors appear in the JS console

QA Steps

Same as test steps.

[x] Verify that no errors appear in the JS console

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@mdneyazahmad, Great job getting your first Expensify/App pull request over the finish line! :tada:
I know there's a lot of information in our contributing guidelines, so here are some points to take note of :memo::

Now that your first PR has been merged, you can be hired for another issue. Once you've completed a few issues, you may be eligible to work on more than one job at a time.
Once your PR is deployed to our staging servers, it will undergo quality assurance (QA) testing. If we find that it doesn't work as expected or causes a regression, you'll be responsible for fixing it. Typically, we would revert this PR and give you another chance to create a similar PR without causing a regression.
Once your PR is deployed to production, we start a 7-day timer :alarm_clock:. After it has been on production for 7 days without causing any regressions, then we pay out the Upwork job. :moneybag:

So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! :blush:

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @puneetlath in version: 1.1.29-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Communicate Docker changes to users

Background

Communicate Docker changes to users
Approach

TBC
Questions / Assumptions

What do we need to include in comms
Acceptance Criteria

[ ] Comms issued to users

Reference
How to write good user stories

Done


Inaccessibility to the model

Dear Authors,
Thank you for your outstanding work on this project. I truly appreciate the effort and innovation you have put into it.
However, I recently discovered that the inpainting model from RunwayML is no longer available. I need to run this model for my own project, so I would greatly appreciate it if you could suggest any suitable alternatives.
Thank you very much for your assistance and guidance.
This is the error message:
Initializing diffusion model:  runwayml/stable-diffusion-inpainting
Couldn't connect to the Hub: 401 Client Error. (Request ID: Root=1-66e2539e-07d9be71002211260af4affe;8f8397e1-a462-451d-96e7-ce2e99df5ea7)
Repository Not Found for url: https://huggingface.co/api/models/runwayml/stable-diffusion-inpainting/revision/fp16.
Please make sure you specified the correct repo_id and repo_type.
If you are trying to access a private or gated repo, make sure you are authenticated.

Hello Zeinab,
Many thanks for your attention on our work, it's unfortunately that it seems Runway recently closed their diffusion models, including those amazing inpainting models.
Recently, I need to focus on another project, and could you try the inpainting model released by stabilityai (link: https://huggingface.co/stabilityai/stable-diffusion-2-inpainting)?

If you have any further questions, please feel free to open an issue.

Hello,
Thank you very much for the update and the clarification!
Best regards,
On Fri, Sep 20, 2024 at 2:55 PM Yuanze Lin @.***> wrote:

For your convenience, you can set --diffusion_model_path
'stabilityai/stable-diffusion-2-inpainting' in the command. I've also
updated the scripts in the repository, so please use the latest version.
—
Reply to this email directly, view it on GitHub
https://github.com/yuanze-lin/Learnable_Regions/issues/4#issuecomment-2363799939,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BJSBDUGQVJITCDXPJ6DW3LDZXQSLRAVCNFSM6AAAAABOGWLLVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRTG44TSOJTHE
.
You are receiving this because you authored the thread.Message ID:
@.***>


fix: add logic for --ignore-missing sha options

Ignore-missing option is support in shasum command starting in version 6.0.1 and in sha256sum (gnu coreutils) at 8.25
without these changes, I got failures to install on my Mac with the following:
❯ curl --proto '=https' --tlsv1.2 -LsSf https://get.dist.sh | sh
 ____  _     _   _ _ _
|  _ \(_)___| |_(_) | | ___ _ __ _   _
| | | | / __| __| | | |/ _ \ '__| | | |
| |_| | \__ \ |_| | | |  __/ |  | |_| |
|____/|_|___/\__|_|_|_|\___|_|   \__, |
                                 |___/

install binaries as fast and as easy as possible. like homebrew but with less fizz.

distillery setup
https://github.com/ekristen/distillery

Please file an issue if you encounter any problems!

===============================================================================
If you are looking to install on windows use the following command:

iwr https://get.dist.sh/install.ps1 -useb | iex
===============================================================================

Fetching installer.sh for version: latest
Downloading distillery v1.0.5...
Verifying checksums...
shasum: distillery-v1.0.5-darwin-amd64.tar.gz: No such file or directory
distillery-v1.0.5-darwin-amd64.tar.gz: FAILED open or read
shasum: distillery-v1.0.5-darwin-amd64.tar.gz.sbom.json: No such file or directory
distillery-v1.0.5-darwin-amd64.tar.gz.sbom.json: FAILED open or read
distillery-v1.0.5-darwin-arm64.tar.gz: OK
shasum: distillery-v1.0.5-darwin-arm64.tar.gz.sbom.json: No such file or directory
distillery-v1.0.5-darwin-arm64.tar.gz.sbom.json: FAILED open or read
shasum: distillery-v1.0.5-freebsd-amd64.tar.gz: No such file or directory
distillery-v1.0.5-freebsd-amd64.tar.gz: FAILED open or read
shasum: distillery-v1.0.5-freebsd-amd64.tar.gz.sbom.json: No such file or directory
distillery-v1.0.5-freebsd-amd64.tar.gz.sbom.json: FAILED open or read
shasum: distillery-v1.0.5-freebsd-arm64.tar.gz: No such file or directory
distillery-v1.0.5-freebsd-arm64.tar.gz: FAILED open or read
shasum: distillery-v1.0.5-freebsd-arm64.tar.gz.sbom.json: No such file or directory
distillery-v1.0.5-freebsd-arm64.tar.gz.sbom.json: FAILED open or read
shasum: distillery-v1.0.5-linux-amd64.tar.gz: No such file or directory
distillery-v1.0.5-linux-amd64.tar.gz: FAILED open or read
shasum: distillery-v1.0.5-linux-amd64.tar.gz.sbom.json: No such file or directory
distillery-v1.0.5-linux-amd64.tar.gz.sbom.json: FAILED open or read
shasum: distillery-v1.0.5-linux-arm64.tar.gz: No such file or directory
distillery-v1.0.5-linux-arm64.tar.gz: FAILED open or read
shasum: distillery-v1.0.5-linux-arm64.tar.gz.sbom.json: No such file or directory
distillery-v1.0.5-linux-arm64.tar.gz.sbom.json: FAILED open or read
shasum: distillery-v1.0.5-windows-amd64.zip: No such file or directory
distillery-v1.0.5-windows-amd64.zip: FAILED open or read
shasum: distillery-v1.0.5-windows-amd64.zip.sbom.json: No such file or directory
distillery-v1.0.5-windows-amd64.zip.sbom.json: FAILED open or read
shasum: distillery-v1.0.5-windows-arm64.zip: No such file or directory
distillery-v1.0.5-windows-arm64.zip: FAILED open or read
shasum: distillery-v1.0.5-windows-arm64.zip.sbom.json: No such file or directory
distillery-v1.0.5-windows-arm64.zip.sbom.json: FAILED open or read
shasum: WARNING: 15 listed files could not be read

Thanks for the contribution!


Get the right IP for routing tables

https://github.com/rancher/rancher/issues/9978

Since we want to "override" the agent IP detected by cattle, I feel the label should be more obvious: io.rancher.network.per_host_subnet.override_agent_ip, @yasker @niusmallnan What do you think?
That's the only comment I have on this, otherwise LGTM.

@leodotcloud
Done


Update GasVentScrubberComponent.cs (Faster settings for scrubbers)

About the PR:
We all love atmos, don't you love atmos? Of course we all love Atmos. Until the very point where the whole station is flooded with 0.3231 Tritium, the air alarms shut everything down and it takes about one hour for the scrubbers to even pump out half of it.
If we can flood the station with 4500kPa oxygen in 15 seconds, why shouldn't we be able to clear a room of all air in less than an hour?
Default will still be 300 but can be changed to 900 manually at Air Alarms.
Screenshots
https://cdn.discordapp.com/attachments/587233998619541515/988061598553866310/unknown.png
https://cdn.discordapp.com/attachments/587233998619541515/988064039689142312/unknown.png
Changelog
:cl:

change: MaxTransferRate of Scrubbers from 300 (Atmospherics.MaxTransferRate default) to 900

#7708 related

Increase the default to about 450 IMO

re-open when reviews are addressed

What reviews even needed addressing here 🤔


[MRESOLVER-219] File advisory locking based NamedLocks

This PR returns and fixes the removed FileNamedLocks from original PR
https://github.com/apache/maven-resolver/pull/77

https://issues.apache.org/jira/browse/MRESOLVER-219

@michael-o ping

Let me finish 3.8.4 first...

@gnodet @michael-o pls look at this one https://github.com/apache/maven-resolver/pull/134 (to be merged into this PR)

@gnodet @michael-o pls look at this one #134 (to be merged into this PR)

Refactorings not part of file based locks should be a separate PR and JIRA issue. Since I want to test is separately.

Refactorings not part of file based locks should be a separate PR and JIRA issue. Since I want to test is separately.

Sure, once this merged I can retarget that PR against master (currently is easier to review targeting it against this PR)

@michael-o ping

Now we can continue, please rebase and push again. There is only one conflict in maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/synccontext/NamedLockFactoryAdapterTestSupport.java.

@michael-o a bit more :wink: doing it...

@michael-o give me some to refactor this a bit

Radically simplified @michael-o and @gnodet pls review again

Thanks, will chew tomorrow.

@michael-o could you please also let your "test beast" run using this as well (the heavy test you used for other locking verification)?

@cstamas Can you please take a look at the last open comment, as soon as this one is resolved, I will do a final review, check log messages and then we are good to go.

@cstamas Can you please take a look at the last open comment, as soon as this one is resolved, I will do a final review, check log messages and then we are good to go.

Done in<PHONE_NUMBER>b35a7a3b7586b42d58bb24f4e67e00

Exit code: 1 - /home/runner/work/maven-resolver/maven-resolver/maven-resolver-named-locks/src/main/java/org/eclipse/aether/named/support/FileSystemFriendly.java:28: error: unknown tag: apiNote


Submodule changes

Add a way to view submodule changes

They currently show up as file changes and are added strangely


Update repository url after switch to balena

Need to update repository url in instructions and scripts after switch to balena
New repository name: balena-io/wifi-connect

@splitice sorry for this, there is a PR awaiting on this to be merged in, but due to some CI issues it is still not there.

Fixed in v4.2.2.


[Messaging] Allow binary application properties

Summary
The focus of these changes is to update AMQP conversion to remove the validation that disallows byte[] and ArraySegment<byte> values in application properties. These are confirmed to be encoded as binary by Microsoft.Azure.Amqp, making them allowable values according to section 3.2.5 of the AMQP specification.
The Event Hubs documentation for EventData has been updated to reflect this change.  Also riding along is a non-trivial clean-up of the Event Hubs-specific AMQP message converter, which had a number of members that were replaced by the Azure.Core.Amqp converter implementation.
Due to a known bug in the Service Bus service, messages with byte[] application properties result in an error when being sent from the client.  Until this is confirmed fixed, the Service Bus documentation still reflects byte[] as an invalid type for the application properties.  While the client will no longer validate byte[], any use will trigger a service error.  Regrettably, this does change the error behavior when this specific type is used, but this is both short-term (confirmed that the service bug will be fixed this semester) and it is enough of an edge case that I do not believe taking a performance hit on each serialization to maintain the current behavior is justified.  Likewise, I don't believe that this is impactful enough to take on the technical debt required to add a short-term flag to customize serialization behavior.

/azp run net - eventhub - tests


Deregister signal channel

If SignalHandler is being used as a mechanism to exit the program entirely, these resources will be cleaned up naturally. But if not, the signal should be explicitly deregistered.
Make sure the channel is eligible to be garbage collected and that no additional signals should be delivered to the channel after this actor exits.
See also: https://go-review.googlesource.com/c/go/+/219640/2/src/context/context.go#543

Great catch, thank you!


No timeout on socket write.

Observed behavior
There is no timeout when writing to a socket in java. When the edge case happens that a disconnection is not detected by the socket implementation (and an exception thrown), any write will just block until the network is restored.
Expected behavior
Try to detect when this happens, prevent blocking and treat as a normal server disconnection, i.e. go into the retry logic.
Server and client version
Server, N/A. Client, 2.x.x
Host environment
N/A
Steps to reproduce
Maybe with a tcp proxy? Maybe a physical network disconnect? Not sure, will try a few things.

Closed with https://github.com/nats-io/nats.java/pull/1064


Hedera: added mainnet factory address :krypc

added mainnet factory address

Thanks but i have already added a contract address. i think this can be close.


Client-side support for reactive-grpc

It seems like our gRPC client implementation does not work well with the gRPC stubs generated with reactive-grpc, because we have hard-coded checks here:
https://github.com/line/armeria/blob/master/grpc/src/main/java/com/linecorp/armeria/client/grpc/GrpcClientFactory.java#L112-L114
Perhaps we could generalize it a little bit more so reactive-grpc is supported on the client side as well?
/cc @cbornet @anuraaga

Would be great indeed ! It seems you just have to look for newRxStub and fallback to newReactorStub if it's not found, then to the standard stubs if still not found.


Pub test pub/test/hosted/version_negotiation_test times out

However, the test prints all single tests as passing.
See:
   http://build.chromium.org/p/client.dart/builders/pub-linux-be/builds/1316/steps/pub tests failures/logs/stdio
for more info.

This issue has been moved to dart-lang/pub#681.


add cross domain scoping

As described in https://github.com/improbable-eng/thanos/issues/1117

@auhlig you just commented, but didn't actually push the changes

@povilasv github was down this morning -.-

LGTY @povilasv?

@auhlig Sort of yes. Did you look at the tests? Would be amazing if we could add some proper testing here, so that when we change code we don't break things.

Made this a breaking change by dropping tenant_id, tenant_name.
Extracted logic to parseConfig, authOptsFromConfig for easier unit testing.
Added unit tests.
LGTY @povilasv @bwplotka

Netlify doesn't seem to be in the mood to run the tests. CircleCI passed however.

squashed into single commit and force pushed.
giving netlify another chance

Updated the changelog after some merge conflicts. Can this be merged @povilasv @bwplotka?

@auhlig so essentially with this PR we are getting rid of the support of the V2 API? I'm a bit anxious about this since, for example, some companies might still be running old versions of that API (cough not gonna point any fingers). Would it be hard to add some kind of backward compatibility?

@GiedriusS This PR does not drop Identity v2 support. It's still possible to authenticate using project_id or project_name instead of the deprecated terms tenant_id, tenant_name.
We only fix the terminology ( tenant became project with Identity v3) and add support for for authentication if a  user is in a different domain than the project.
In summary, the only breaking change is the terminology.

Ok so this does include a breaking change
tenantID, tenantName -> projectID, projectName.
I think in order not to break users, just fill tenantID to projectID and tenantName to projectName.
We try to avoid breaking changes when possible and in this case it's definitely doable

@povilasv I think breaking here is better that having inconsistent configuration -> users will be immdiately notified by verbose error message.

Waiting for @povilasv final LGTM to merge (:

Thank you guys 🎉


worker_cloud_init does not pick up new changes

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version and Provider Version
terraform {
  required_providers {
    oci = {
      source  = "oracle/oci"
      version = "~> 5.21.0"
    }
  }
  required_version = "~> 1.5.0"
}

Affected Resource(s)
https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/main/modules/workers/cloudinit.tf
Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file.
# Please remove any sensitive information from configuration files before sharing them.

Debug Output

Panic Output

Expected Behavior
module.oke.module.worker[0].null_resource.await_cloudinit ... needed to be refreshed
Actual Behavior
Nothing ... module.oke.module.worker[0].null_resource.await_cloudinit does not exist
Steps to Reproduce
Try to use this and then change it, no changes are picked up. Feels like https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/c23e645d351c9c6e963731854758da616eb073c1/modules/workers/nodepools.tf#L107C11-L107C11 may be involved.
  worker_cloud_init = [
    {
      content_type = "text/cloud-config"
      content = jsonencode({
        runcmd = [
          "echo 'Running custom init...'"
        ]
      })
      filename  = "91-xxx-xxx.yml"
      mergetype = "list(append)+dict(no_replace,recurse_list)+str(append)"
    }
  ]

Important Factoids
module.oke.module.bastion[0].null_resource.await_cloudinit: Refreshing state... [id=8064727544853391624]
module.oke.module.operator[0].null_resource.await_cloudinit: Refreshing state... [id=7638323085362603428]
No changes. Your infrastructure matches the configuration.
References
https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/c23e645d351c9c6e963731854758da616eb073c1/modules/workers/nodepools.tf#L107C11-L107C11

Too much left to be desired, making my own


Some column names need to be removed from 3.0 upload files

Some columns are added into tables where they don't belong.  For example, the specimens table might have 'site' and 'location'.  Those should be removed prior to upload.  This will be a function for new_builder (a method of Contribution).

I've now implemented functionality that does this: 641847bcd
The way this currently works is that all headers that aren't in the 3.0 data model are removed from all MagIC tables prior to upload.  The problem with this approach is that if someone has a slightly incorrect MagIC column, this will be deleted as well. With Rupert's new interface, it's pretty easy to fix a misspelled column name, but a user won't have the option to do that if I chuck that column before the upload.
Some options:

We could warn users about the columns that are being auto-deleted.
We could blacklist instead of whitelisting (drop certain known nuisance columns, but leave ambiguous/potentially misspelled columns in the upload)

Misspelled columns aren't too likely to be a problem for people who are using PmagPy the whole way through their process, since we are pretty consistent.  But if they're mixing and matching with their process, maybe doing some editing by hand, the problem could come up.
@ltauxe, any thoughts about this?

From meeting:  Add a warning, and an are you sure?

My two cents worth is that when creating a MagIC file for upload the
columns that are used internally in the PmagPy programs, but not found in
the data model, should be dropped without a warning. Columns added by the
user, but not in the data model, should be kept with a warning. The user,
as you said, can link an unknown column to the correct one in the data
model when uploading. I'm generally against correcting spelling
automatically and instead like just pointing out the possible problem.
On Tue, May 16, 2017 at 11:11 AM, Lori J<EMAIL_ADDRESS>wrote:

From meeting: Add a warning, and an are you sure?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PmagPy/PmagPy/issues/119#issuecomment-301868166, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABODRe1Korb6rRjx-9zCDiDuos1btB5Rks5r6ebCgaJpZM4LvYeD
.

@njarboe, thanks for your input.  I've implemented a solution that does more or less what you suggest, although the problem with blacklisting PmagPy columns is that I suspect I don't have a complete list of what should be dropped.  I will keep trying to add those (in ipmag.upload_magic3, to RmKeys and extra_RmKeys) as I find them.  Everyone else should feel free to do the same, or let me know what they find.


Support ability to specify ServiceContext in GoogleLogger

Hi,
I have recently added Google.Cloud.Diagnostics.AspNetCore logging into an existing application running in GKE (and it's working great).
My assumption is that I don't need to use the library's error reporting capabilities, as all errors that occur within my application are caught and logged with ILogger.LogError(exception, message). These appear properly in cloud console.
Google Cloud Error Reporting automatically picks up these errors from the logs. However, in cloud console, all errors are reported as coming from "gke_instance", which does not help identify where the errors are coming from.  There is an existing discussion about using resource labels from logs to better identify services, but 3 years on it is not supported yet.
I believe we can provide this information to error reporting by adding serviceContext to the JSON payload of log entries, however GoogleLogger does not expose any capabilities that permit configuring this.
I confess I have not used this library for long, and I might be missing something. But if not, could we potentially add support similar to ILogEntryLabelProvider, but for the JSON payload?
Cheers!

How are you configuring the diagnostics package? If you're calling the UseGoogleDiagnostics extension method, there's a serviceName parameter you can specify at that point. Does that help you?

I am using the ILoggerFactory.AddGoogle extension method. I chose this as Istio is already pushing traces, and error reporting already supports logs I insert with ILogger.LogError.
With regards to UseGoogleDiagnostics, this method only passes the serviceName to error reporting.  serviceName does not make its way into GoogleLogger.

Ah, right - whoops. I'll have a closer look when I get the chance.

You can use Google Error Reporting on its own as shown here. Although I realize that if you are logging other than errors, then you would need to register both the GoogleLogger and Googler Error Reporting. But if you are using the logger to only log errors, then this will solve your problem, without interfering with Istio tracing. ServiceName and Version will be included in the serviceContext field of the json payload.
Still, I see the use case for adding serviceContext for a general log entry, so I think we could add that. We probably wouldn't add anything as general as ILogEntryLabelProvider for the json payload, but we can definetely add ServiceName and Version to LoggerOptions, and include those on the serviceContext field when present.
Let me know if either or both will help, and we can go from there.

Hi @amanda-tarafa, thank you for the suggestion. In this case ILogger is being used for logging all log levels (including errors and warnings with accompanying exceptions); I am integrating Google.Cloud.Diagnostics.AspNetCore into several existing services like this.
The ability to specify ServiceName and Version in LoggerOptions is perfect for this use case and would solve the problem.

The ability to specify ServiceName and Version in LoggerOptions is perfect for this use case and would solve the problem.

Great. I will work on this, but probably late next week, maybe even early the week after.

This has now been released in https://www.nuget.org/packages/Google.Cloud.Diagnostics.AspNetCore/4.1.0-beta01.


useResetAtom in utils

Close #41

[ ] snippet example
[ ] codesandbox example
[ ] docs/utils.md

@italodeandra Could you please try this (the sandbox above), and possibly create an example for docs? (will put the snippet and the link in docs/utils.md)

Hi @dai-shi, thank you very much for doing this.
Later today after work I'll try and create an example for the docs.

If you have any change suggestions, let me know. This was the simplest use case that I could think of.
Snippet
import { useAtom } from 'jotai'
import { atomWithReset, useResetAtom } from 'jotai/utils'

const todoListAtom = atomWithReset([{
  description: "Add a todo",
  checked: false
}])

const TodoList = () => {
  const [todoList, setTodoList] = useAtom(todoListAtom)
  const resetTodoList = useResetAtom(todoListAtom)

  return (
    <>

        {todoList.map((todo) => (

{todo.description}

        ))}

      <button
        onClick={() => setTodoList((l) => [ ...l, {
          description: `New todo ${new Date().toDateString()}`,
          checked: false
        }])}
      >Add todo
      </button>
      <button onClick={resetTodoList}>Reset</button>
    </>
  )
}

Typescript Sandbox
https://codesandbox.io/s/react-typescript-forked-w91cq

Looks great. Thanks!


use divideCeil(_, 8) for bool size like DenseElementsAttr

https://github.com/llvm/llvm-project/blob/main/mlir/lib/IR/BuiltinAttributes.cpp#L980

@jenkins-droid test this please

@jenkins-droid test this please

@jenkins-droid test this please

@jenkins-droid test this please

@jenkins-droid test this please

@jenkins-droid test this please

Jenkins Linux s390x Build #11464 [push] use divideCeil(_, 8) for... started at 10:13

Jenkins Linux ppc64le Build #10513 [push] use divideCeil(_, 8) for... started at 10:19

Jenkins Linux s390x Build #11464 [push] use divideCeil(_, 8) for... passed after 1 hr 28 min

Jenkins Linux ppc64le Build #10513 [push] use divideCeil(_, 8) for... passed after 2 hr 3 min


refactor: 重构趋势分析表条件格式解析逻辑

👀 PR includes

🎨 Enhance

[ ] Code style optimization
[x] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

📝 Description

将趋势分析表原本从  options.style.cellCfg.valuesCfg.conditions  归并至 统一的  options.conditions , 保持逻辑统一
去掉 disabledConditions 判断，条件格式是否生效统一在 mapping 里自行判断就好
一些变量名的变更

🖼 Screenshot

🔍 Self-Check before the merge

[x] Add or update relevant docs.
[x] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.23.0-alpha.3 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.21.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-v1.23.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @antv/s2-react-v1.21.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


New shapes

I am thinking it would be nice to have more shapes :) Rectangles (not just squares), stars and long rectangles maybe (or serpentine streamers)

I'm checking what I can do about this. The goal here is not to create another particle library, there are many others which accomplish this. So I want to keep true to confetti shapes. As you mentioned, variations in rectangles and ideally serpentine streamer would be preferable indeed.
Any pull request is welcome

Hey Daniel, Awesome work! I second this, how are the different shapes coming along?
Would like custom shapes, in best case scenario shapes loaded directly from drawables or XML shapes

@Akshshr I do not have any particular shapes to add right now. Long rectangles would be a nice first to start on because they'll do very well in a confetti particle system like this. Other shapes like serpentines I haven't give a thought on how to accomplish that yet.

Why not just little stars ?

The smartest thing would be to support any drawable

It would be nice if we can set confetti image, so we can add an image of any shape.

I strongly agree with @Akshshr , an option to set any drawable(s) will make this project even better than it already is.
@DanielMartinus we all hope you'll give it some serious consideration. For instance, I need to set hearts and stars, others need snowflakes, emojis, and the list goes on and on... Think how many people wanted to use this great library, but eventually chose some other library (and probably not as good) just because it's missing one simple option...

@DanielMartinus, are you receptive to PRs for this? I have some ideas that won't require many changes to the library.

I've been holding back adding custom shapes to Konfetti due to the reasons mentioned earlier in this Issue. I'm super happy that @mattprecious implemented a way of adding custom shapes which doesn't affect the performance and is also very easy to use. 🎉

It has been merged and released in version 1.2.0 of Konfetti.


Porting Networking additions from Java SDK, mostly App Gateways

(Tests coming next)

@martinsawicki,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Exporting bert model to a saved model format

I have been referring to predicting_movie_reviews_with_bert_on_tf_hub.ipynb  to create a sentiment analyzer on the IMDB dataset.
I need to export it to tensorflow saved model format so that I can integrate it with a separate system.
Can you please guide me to achieve it?

yes, I also fine-tune a classification model use bert hub way. But I don't know how to reload the trained model? Did you solve that?

Is your problem solved? I am having the same problem.

Is your problem solved? I am having the same problem.

Hi, after fine-tuning, just use the saved output file, don't need the hub module.

Is your problem solved? I am having the same problem.

Hi, after fine-tuning, just use the saved output file, don't need the hub module.

Hi, how does your output file look like? what type of file? and how did u export it? also please tell me how to load it into another program.

Maybe take a look at this
https://medium.com/delvify/bert-rest-inference-from-the-fine-tuned-model-499997b32851


brave: 1.27.108 -> 1.27.109

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for brave is: "Privacy-oriented browser for Desktop and Laptop computers"
meta.homepage for brave is: "https://brave.com/"
meta.changelog for brave is: "https://github.com/brave/brave-browser/blob/master/CHANGELOG_DESKTOP.md"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109/bin/brave passed the binary check.

/nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109/bin/.brave-wrapped passed the binary check.

2 of 2 passed binary check by having a zero exit code.

2 of 2 passed binary check by having the new version present in output.

found 1.27.109 with grep in /nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109

found 1.27.109 in filename of file in /nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109

directory tree listing: https://gist.github.com/0a8ce51cf457b1d689bcc0f2d8091b19

du listing: https://gist.github.com/595ad1d8460b44251b520dffa198b162

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
brave

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A brave https://github.com/r-ryantm/nixpkgs/archive/46f19d869e42c3671a0c0e3ef6488b5138592358.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109
ls -la /nix/store/8ky6jhkn4dy9rchjawxbhf43k1hxrv3j-brave-1.27.109/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

brave

Maintainer pings
cc @uskudnik @rht @jefflabonte @nasirhm for testing.

Result of nixpkgs-review pr 131912 run on x86_64-linux 1

1 package built:

brave


The mat-elevation mixin should include z-index

When using mat-elevation, we get correct shadows, but not z-index. For that, it would seem we're on our own. Can the mixin include reasonable z-index values?

I agree it would be great if we could do this conceptually.  We do not do this because not all components live in the same stacking context as they have different ancestor paths, the z-index values would not appear to be consistently respected.

I guess you're right. If the root context has two components with elevations X and X+1, and the component with elevation X is its own context with a child with relative elevation Y (>1), then how does one make the components appear correctly stacked as: X+Y, X+1, X.

I guess that is a problem of implementation.
see stackBlitz
clone of Material Design / Measuring elevation
Conceptually, the div A and C are both at z-index 8dp. but if I use mat-elevation-z8 then the elevation are wrong.
That is because mat-elevation expect the relative elevation instead of displaying the comprehensive z-index...
That is sad to dump the calculation to the developer...


[Feature Request]:  Scroll to top button

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Create an button which go on top smoothly by clicking on thatv button
Use Case
Make good for website
Benefits

Priority
Low
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a WOB contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

assigned to you @YasirKhan231
-- you can also add a circular progress bar that will be dynamically changing depending on scroll for level2

I think circular progress bar not look good
i am making the pull request for the scrool to top button

okay propose your changes in pr

and mention issue no with  # in pr

okay bro


Specifying a font to be used in profile that does not exist causes the app the crash

I added a new profile to the profiles.json specifying a font that is not installed on my system.  When attempting to start the profile the app crashes with the following:

The program '[15980] WindowsTerminal.exe' has exited with code -1073741819 (0xc0000005) 'Access violation'.

Specifying a font that is installed causes the problem to not occur.
The profile definition looks like this:
    {
      "guid": "{e2f9d7d6-369b-4841-9429-61f5b38474cf}",
      "name": "Bash",
      "colorscheme": "Campbell",
      "historySize": 9001,
      "snapOnInput": true,
      "cursorColor": "#FFFFFF",
      "cursorShape": "bar",
      "commandline": "bash.exe",
      "fontFace": "Fira Code",
      "fontSize": 12,
      "acrylicOpacity": 0.5,
      "useAcrylic": false,
      "closeOnExit": true,
      "padding": "0, 0, 0, 0"
    }

Similar to this, specifying a large font name seems to crash as well. I used "Ubuntu Mono derivative Powerline" and it crashes, although the font is installed.

That one is #602.


How to inference on other <midi, text> files using the opencpop phone_set.json?

Hi, thanks for the great work!
I want to inference on my own <midi, text> files. I generated the corresponding meta.json and tried to binarize it. But the binarizer can only generate phone_set.json based on the input files, which will be incompatible with the pretrained checkpoint (since it was pretrained on opencpop with opencpop phone_set.json). A solution is to preprocess the customized testset with the original opencpop meta.json to obtain the full phone_set.json (i.e., the same phoneme dict). However, it is too inconvenient to do that thing.

Check this closed issue and my reply. We will upload this phone_set file to the repo later.
https://github.com/MoonInTheRiver/DiffSinger/issues/15#issuecomment-1041207925

How to binarize the new testset using the existing phone_set.json rather than generating a new phone_set?

Hello, I have issue as I try to use another english dataset. And I'm wondering why Inference from packed test set can work (CUDA_VISIBLE_DEVICES=0 python tasks/run.py --config usr/configs/midi/e2e/opencpop/ds100_adj_rel.yaml --exp_name $MY_DS_EXP_NAME --reset --infer) but inference model from raw input (python inference/svs/ds_e2e.py --config usr/configs/midi/e2e/opencpop/ds100_adj_rel.yaml --exp_name $MY_DS_EXP_NAME) needs same phoneme set size?


Add ConvPerf workflow

I had to modify the docker_run.sh script to run the container with privileges. The benchmark uses numactl for scheduling which needs elevated permissions.


Update download links for pre-processed links for KITTI Dataset

Both the links provided to download the pre-processed KITTI dataset are non-existant. Please update these links.

Please check your own device and network, I seem to be able to download it properly.


NERDTree Bookmark Toogle error

Operating System: Linux Mint
Vim version :7.4 Patches 1-52 NERDTree version: c11affa`
NERDTree settings applied in your vimrc, if any:
ISSUE DESCRIPTION

Error was introduced after updating NERDTree. Did not exist in previous version (Not sure of previous version but most definitley more than a year since I last updated)
Error occurs when I use "B" to open bookmarks (Tested after commenting out customizations in vimrc.)
My vim customization as it relates to NERDtree does the following:
Opens nerdtree with F3 or automaticaly if no args passed to vim
Keep bookmarks menu open by default. Using let NERDTreeShowBookmarks=1
NOTE: (configuration worked fine previously and does not seem to be root cause since commenting them out and manually opening bookmarks using B produces the same error)

STEPS TO REPRODUCE
Pull most up to date version of NERDTree rev-parse version = c11affa
Just hit B when in nerdtree to try open Bookmarks. This issue did not exist before
ERROR
Error detected while processing function nerdtree#ui_glue#invokeKeyMap..73..72..36_toggleShowBookmarks..253..228..249..244..95:
line    1:
E725: Calling dict function without Dictionary: 83
E702: Sort compare function failed

Could you try adding the dict keyword after this line so that it becomes:
function! s:Bookmark.SortBookmarksList() dict

This may fix your problem.
Also, your Vim installation is quite old. A number of bugs have been fixed since 7.4. Have you considered an update?

Friendly nudge to @goodwillhacking...
Do you have any feedback regarding the fix proffered above?

@lifecrisis thank you very much. I simply updated vim and all problems went away. Cheers man