[ldd-img_surface] Move PDS4_IMG_SURFACE_1G00_1280.sch online

Issue Type
unknown
Describe the issue identified (if applicable)
There is an upcoming M2020 release on July 27th. The urn:nasa:pds:mars2020_rover_places:data_maps collection for this release is using this version of the img_surface data dictionary in their labels: PDS4_IMG_SURFACE_1G00_1280.sch, but it doesn't seem to be online yet, giving me validate errors ([https://pds.nasa.gov/pds4/img_surface/v1/PDS4_IMG_SURFACE_1G00_1280.sch].) Is it possible for it to be moved online before the 27th?
Describe the solution you'd like
A clear and concise description of what you want to happen. Where possible please include details like:
The updated dictionary to be moved online
Describe alternatives you've considered
LDD Dictionary Version
PDS4_IMG_SURFACE_1G00_1280
PDS4 IM Version
<IP_ADDRESS>
Need-by Date
7/27/23 (M2020 release 7 goes online)

https://github.com/NASA-PDS/operations/issues/417

@mnhughes @thareUSGS @Myche thanks to @c-suh this LDD has been posted. Sorry for the delay!


Thanhtran/mis 156 customize theme for login UI

Hi anh @lcvinny Does this commit still need to be considered?

no, I'm closing thisn now


Use an annotation to explicitly indicate fields to be logged

This should remove the need to extend a class to be able to log properties. Sensitive fields, such as passwords, won't be exposed unless the annotation is explicitly added to the field.
@LogField(name="Server Name")
private String serverName;

The name parameter should be optional, in which case the field's name would be used.

Closed by pull request #6


fix(cli): 增加terser-webpack-plugin依赖

增加terser-webpack-plugin依赖

Codecov Report

Merging #56 (47bb375) into master (b560b80) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   96.15%   96.15%
=======================================
  Files          15       15
  Lines         234      234
  Branches       34       34
=======================================
  Hits          225      225
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b560b80...47bb375. Read the comment docs.


Hotfix/deprecation cop

Fix deprecation cop message

Thanks,
I don't maintain this repo thought...
@johnhiott can you merge it please?
Also, @ganiutomo do you want push rights over the repo?

I will look @ this this morning and merge. Thanks for the pull request.
On Mon, Mar 23, 2015 at 6:02 AM Pierre Ozoux<EMAIL_ADDRESS>wrote:

Thanks,
I don't maintain this repo thought...
@johnhiott https://github.com/johnhiott can you merge it please?
Also, @ganiutomo https://github.com/ganiutomo do you want push rights
over the repo?
—
Reply to this email directly or view it on GitHub
https://github.com/pierreozoux/solarized-light-ui/pull/3#issuecomment-84924466
.

Yes and thanks @pierreozoux @johnhiott


check all following commands for extra utility and write appropriate parsers for it

qstat_-g_c
qstat_-g_t
qstat_-g_t_-u_*
qstat
qstat_-f
qstat_-F
qstat_-F_-r
qstat_-r
qhost
qhost_-j
qhost_-q

SGE can deliver now all information via qstat -F -xml -u '*', which is great for atomicity of info sources;
so the above is deprecated by now


Fix ModuleNotFoundError and improve start up time

Add a missing sys path to fix ModuleNotFound errors
Delay the controlnet_aux imports to speed up start up time

This should fix #3

LGTM


Badge component renders in wrong location

Steps to reproduce
In up-to-date Flutter, the following code should render a standard Material 3 badge indicator over the action icon:
    Scaffold(
        appBar: AppBar(
          title: const Text('Flutter Demo'),
          actions: [
            Badge.count(
              count: 3,
              child: IconButton(
                icon: const Icon(Icons.inbox),
                onPressed: () {},
              ),
            )
          ],
        ),
        body: const Center(
          child: Text(
            'Hello, Flutter!',
          ),
        ),
      )

Expected results
Per https://m3.material.io/components/badges/overview, the badge should render "Anchor badges inside the icon bounding box, at the upper trailing edge of the icon". It should render correctly (and without additional configuration) at least in the following contexts:
"Badges are most commonly used within other components, such as navigation bar, navigation rail, top app bars, and tabs."
Here is a screenshot from material guidelines:

Actual results
The badge is rendered too high and too far to the right of the icon.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
      ),
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Flutter Demo'),
          actions: [
            Badge.count(
              count: 3,
              child: IconButton(
                icon: const Icon(Icons.inbox),
                onPressed: () {},
              ),
            )
          ],
        ),
        body: const Center(
          child: Text(
            'Hello, Flutter!',
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
N/A

Flutter Doctor output
Doctor output
N/A

Thanks for the report!
I guess the defaultOffset caused this:
https://github.com/flutter/flutter/blob/e92bca3ff5d27b120ed39411c70d0110c21b4afa/packages/flutter/lib/src/material/badge.dart#L192
If I pass a zero offset(Offset(0, 0)), it looks better:

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.19.2, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.2 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (31 hours ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 122.0.6261.94

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.20.0-15.0.pre.45, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.20.0-15.0.pre.45 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ccf375cb1 (40 minutes ago), 2024-02-28 23:17:36 -0500
    • Engine revision 232217f39c
    • Dart version 3.4.0 (build 3.4.0-187.0.dev)
    • DevTools version 2.33.0-dev.11
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.82.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 122.0.6261.94

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

@aran
Please wrap the Icon itself with Badge widget, this is intended. If you wrap the whole widget, there will be inner widget padding between icon and the badge. No need to specify defaultOffset then.
IconButton(
  icon: Badge.count(count: 3, child: const Icon(Icons.inbox)),
  onPressed: () {},
),

Oh, great. Thank you! I would definitely have benefited from an example in the docs. Happy to file a docs issue for that if it would be helpful.

@aran feel free! 🙌


babel@6 plugins whitelist

would be cool to detect the plugins whitelist so that i could make a require hook like:
require('babel-core/register')({
  plugins: require('scrabel').createPluginWhitelist(),
  presets: [
    'stage-0'
  ]
})

let me know how i can help

let me know how i can help

A PR would be awesome, and welcomed. I'm still getting my head around all the changes in babel 6.


address race condition with ingress and CI pipeline

Sample App Config kicks off the CI run. That DA now deploys for longer because it takes a while to provision a public LB and get the cert for it signed. There is about 15 min of wait time. I forgot to add a dependency on ingress config to the webhook trigger - that's why it kicks off before the pipeline property for the ingress subdomain is set.

I will fix the deployment script in the app itself for now - it can fetch the subdomain from the ingress controller

^^ (this part was done in https://github.com/IBM/gen-ai-rag-watsonx-sample-application/pull/24)

This is fixed in RAG stack 2.0.1


Update several lockfile dependencies using npm audit fix

This fixes 154 of the 355 vulnerabilities. Many of the vulnerabilities are in dev dependencies, though it doesn't hurt to clean these up. Otherwise we won't see the important ones when they pop up.

By coincidence I just upgraded npm the other day and spotted this feature.
I'll merge this one now so that dependabot can rebase all the other open dependency bump PRs onto this


Is there a reason why this isn't scripted in AZ cmd line?

Noticed that this page was updated in 2020.  We should be converting everything to AZ commands, not using azure powershell.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa7be494-b0c4-1e92-829e-119b05aadcb5
Version Independent ID: e2032468-6c27-a6a6-6194-591ca21a3c55
Content: Connect to a VNet from a computer - P2S VPN and native Azure certificate authentication: PowerShell - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-howto-point-to-site-rm-ps.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@LarrySmith-1437  Thanks for the feedback! Your feedback  has been shared with the content owner for further review.


Why using meta-epoch training paradigm

Hi,
Thanks to your code, it helps my way on researching alot.
One question comes to my mind when I try to implement cFlow under my code that usually a model is trained by a batch of data where the loss is reduced from the whole batch and backpropagated.
And I found that the loss is backpropagated for each sub-iteration -- only part of the batch is sampled.
This Training paradigm somehow confuses me, does it work better than the normal way ?
Here are points that I surmise why that works:

Only seeing part of the batch randomly makes the gradients move more stochastically which could produce a more robust model
It saves GPU memory for each forward/backward propagation with high batch size

Thanks!

@DonaldRR could you point me to a line of code where "the loss is backpropagated for each sub-iteration -- only part of the batch is sampled"? I don't think, I implemented anything like you described: meta/sub epochs are just to introduce flexibility for train/test phases

@DonaldRR could you point me to a line of code where "the loss is backpropagated for each sub-iteration -- only part of the batch is sampled"?  During each fiber iteration, N(=256) features are sampled for loss computation and backpropagation.
lines starting at 65th line train.py
                for f in range(FIB):  # per-fiber processing
                    idx = torch.arange(f*N, (f+1)*N)
                    c_p = c_r[perm[idx]]  # NxP
                    e_p = e_r[perm[idx]]  # NxC
                    if 'cflow' in c.dec_arch:
                        z, log_jac_det = decoder(e_p, [c_p,])
                    else:
                        z, log_jac_det = decoder(e_p)
                    #
                    decoder_log_prob = get_logp(C, z, log_jac_det)
                    log_prob = decoder_log_prob / C  # likelihood per dim
                    loss = -log_theta(log_prob)
                    optimizer.zero_grad()
                    loss.mean().backward()

@DonaldRR I see. The number of feature vectors (fibers) can be quite large in a feature map (tensor) to fill all memory for a flow model. So, it is better to sample random feature vectors from a number of feature maps. Hence, your original post is on point :)

@PSZehnder yes

Hi,
Need the value of N in train and test be the same ? When I change the value of N only in test phase, I found the inference results will slightly change.
Thanks a lot.

@Howie86 N should not change test results

@gudovskiy Thanks for your reply, I understand.


Piping result of a static call into arg/values of other deployment functions

Implement static calls in the user facing api.
Relevant design doc section
Static calls
A contract might need the result of some other contract method as an input. Ideally, this would be done by the contract itself, receiving the address of the other contract instead of the result of calling it. But if that's not the case, or if for any other reason you need to make a static call to a contract, you can do it like this:
const token = m.contract("Token")
const totalSupply = m.call(token, "totalSupply")

const someContract = m.contract("ContractName", {
  args: [totalSupply]
})

Notice that the same m.call method is used both for sending transactions and for static calls. We use a convention similar to what ethers.js does, where the behavior is different for view and non-view functions. If the user wants to statically call a non-view function, they can do it with some flag in the options.
In this example, totalSupply is called a deferred value. Similar to how a contract binding is a contract that will eventually be deployed, a deferred value is some value that will eventually be available. That means you can't do this:
if (totalSupply > 0) {
  ...
}

Because totalSupply is not a number.
Deferred values are resolved each time they are used. That is:
const totalSupply = m.call(token, "totalSupply")

const foo = m.contract("Foo", {
  args: [totalSupply]
})
const bar = m.contract("Bar", {
  args: [totalSupply]
})

Here there's no guarantee that both deployments will receive the same value. If a user wants that behavior, they can do it with a custom deferred value that caches the result.

We need to make a decision on how we name call given that it has a specific meaning in eth terms i.e. staticcall.


Local app store

Hi @yousefamar
Can you give me a hand with this?
There are a couple of things that need changing for running locally in dev mode:
I'm setting an env var LOCAL_MODE=1 if this is present:
Can you disable the login and remove the need to re-captcha?
Also, would it be easy to move to nedb rather than mongo so save starting another container.
I had a look at implementing this but was foiled by ls once again ;-(

Ah, of course, I'll port to JS while I'm at it. I'll do this before the day is up. Should I push directly to upstream localAppStore branch?
There are also a whole bunch of things we could change about how the remote one works too eventually. I added all that stuff way back when going in blind based on how I imagined it might work, rather than how it should.

Cool thanks,
Just push to this branch Then we can merge it once we are happy.

The autoload option in nedb really helps with modularisation and simplified the code a bunch. Mongo forced async, and module exports had to be sync, hence my original hacks, so that's another plus.
BTW, on localhost, I believe any random reCAPTCHA key works for development anyway, but I agree that it's cleaner to remove login as a whole. I'll make it so that in LOCAL_MODE, you treat all requests as being part of some special admin-type account session.

LOCAL_MODE now brings you straight to dashboard and any manifests you upload are uploaded as a fake user called "localuser" with an _id of -1. Switched to nedb, and for the most part, it seems that the methods are the same as for mongo, but I did notice a few differences (natural order sort, find all needs empty object). If you spot any mongo-ism like that please do quash.
I forgot how much code I wrote for this, so porting to JS is not as super straightforward as I thought it would be. :P I'll take it module by module as we edit stuff, and any new modules we can require as JS. Likely a lot subject to rewriting too.

Looks good, I will give it a quick try and merge it in


Extensions viewlet is broken in Web

I am seeing a blank viewlet when opening
contributions.js:85 Unable to instantiate workbench contribution KeymapExtensions. Error: [createInstance] ExeBasedRecommendations depends on UNKNOWN service TASExperimentService.
    at InstantiationService._createInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:71)
    at InstantiationService.createInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:59)
    at new ExtensionRecommendationsService (:8080/static/out/vs/workbench/contrib/extensions/browser/extensionRecommendationsService.js:38)
    at InstantiationService._createInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:88)
    at InstantiationService._createServiceInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:177)
    at InstantiationService._createServiceInstanceWithOwner (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:165)
    at InstantiationService._createAndCacheServiceInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:156)
    at InstantiationService._getOrCreateServiceInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:113)
    at InstantiationService._createInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:69)
    at InstantiationService.createInstance (:8080/static/out/vs/platform/instantiation/common/instantiationService.js:59)

Broken by https://github.com/Microsoft/vscode/commit/d933c49a5caf7367d0b757bcc5e8d3bb378fe67e

@sbatten added a temporary fix - made the service optional  - to unblock testing.

sticking with this fix for this milestone as we don't need to do any more right now. this code will be removed next milestone based on discussions with @sandy081, @bamurtaugh, @sana-ajani, and @aeschli


Chocolate Chip Cookies

https://joyfoodsunshine.com/the-most-amazing-chocolate-chip-cookies/

Added one extra egg


Create MOM-2024-02-20.md

What type of PR is this?

documentation
subproject management

What this PR does / why we need it:

Share draft MOM of the meeting 2024/02/20

Which issue(s) this PR fixes:

NA

Special notes for reviewers:

None

Changelog input
Additional documentation

Merged.  Sorry for the dealy.


Problem with laravel/datatables-buttons

Hello
i use the "composer require laravel-datatables-oracle"
after install the composer i install composer require yajra/laravel-datatables-buttons:^3.0
but i get the next error:
Problem 1
- Can only install one of: maatwebsite/excel[2.1.x-dev, 3.0.0].
- Can only install one of: maatwebsite/excel[3.0.0, 2.1.x-dev].
- Can only install one of: maatwebsite/excel[2.1.x-dev, 3.0.0].
- yajra/laravel-datatables-buttons v3.0.0 requires maatwebsite/excel ^2.0 -> satisfiable by maatwebsite/excel[2.1.x-dev].
- Installation request for yajra/laravel-datatables-buttons 3.0 -> satisfiable by yajra/laravel-datatables-buttons[v3.0.0].
- Installation request for maatwebsite/excel 3.0 -> satisfiable by maatwebsite/excel[3.0.0].
i need help with this,

Please use yajra/laravel-datatables-buttons:^4.0 for excel v3. Thanks!


Testimonial needs to be updated

As a override in carousel causing testimonial not to be working as expected.
Before

After

Yes, Please fix the layout of it proper @Git21221


[full-ci] update REVA

Description
update REVA

:boom: Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled...


Filter LogBox using a function

Summary:
LogBox.ignoreLogs((message) => loggingisOn);
Matching on strings and regex is handy, but I have a use-case where we want to turn logging on and off for certain features, so that members of one team can listen to logs only on features they are working on. So I thought I would take a stab at this, and since @cipolleschi is giving a talk at #ChainReact2023 about contributing to React Native, there's not better time to propose this upstream! 😏
Changelog:
[GENERAL] [ADDED] - LogBox.ignoreLogs now supports a filter function, (message: string) => true will include the message, and (message: string) => false excludes the message (matching the behavior of [].filter).
Test Plan:
I've run the tests, I haven't tested manually yet. Need to set up a demo app pointing to my fork.
yarn test packages/react-native/Libraries/LogBox/Data/__tests__/
…

Test Suites: 4 passed, 4 total
Tests:       82 passed, 82 total
Snapshots:   0 total
Time:        1.173 s

All tests:
yarn test react-native
…
Test Suites: 1 skipped, 208 passed, 208 of 209 total
Tests:       2 skipped, 3905 passed, 3907 total
Snapshots:   1141 passed, 1141 total
Time:        12.253 s

@colinta, as soon as you have time, could you provide some examples as asked above? 🙏

Sure, I can expand on the use-case that we would use this for. We have a few sources of "noisy" logs in the app: State changes are logged, as well as user actions like button taps. So we've got a central place to decrease the volume of debug logs by feature and source (we can still show parts of the message, or hide it entirely).
In the case of LogBox my original thought was to have the option to hide the popup box but leave them in the console, until we are on the feature we're working on, at which point I'd want to see those warnings again more obviously. As you point out though, we could patch console.warn instead, I hadn't considered that but we're already patching it so that would be easy.

we could patch console.warn instead, I hadn't considered that but we're already patching it so that would be easy

I don't have a super strong opinion here, but I believe that as this was coming for your specific use case @colinta and patching console.warn is even more effective in suppressing your logs along to board, I'd rather close this down and don't introduce yet another API we have to maintain. What do you think?

Less is usually more 👍


[WIP] Tool for log analysis

Proposed changes
This PR introduces a tool for analysing agent logs
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

[ ] Non-breaking fix (non-breaking change which fixes an issue)
[ ] Breaking fix (breaking change which fixes an issue)
[ ] Non-breaking feature (non-breaking change which adds functionality)
[ ] Breaking feature (breaking change which adds functionality)
[ ] Refactor (non-breaking change which changes implementation)
[ ] Messy (mixture of the above - requires explanation!)

Checklist
Put an x in the boxes that apply.

[ ] I have read the CONTRIBUTING doc
[ ] I am making a pull request against the main branch (left side). Also you should start your branch off our main.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have locally run services that could be impacted and they do not present failures derived from my changes

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

I think this looks really cool, it lgtm, but i have not run it. maybe @0xArdi and @Adamantios can confirm?

With the last commit I've added support for several filters and printing the FSM execution path for an agent. The tool currently provides support for following filters
-a, --agent : specify agent ID
--start-time : logs will be filtered out from this timestamp to the end of logs
--end-time : logs will be filtered out till this timestamp
--log-level : only prints out the logs with the given log level
--period : logs for a specific period
--round : logs for a specific round
--behaviour : logs for a specific behaviour

These filters can be used standalone
autonomy analyse logs --from-dir temp/logs/ -a aea_0 --start-time "2023-02-01 11:26:06,000"

Or can be combined to have more specific output
autonomy analyse logs --from-dir temp/logs/ -a aea_0 --start-time "2023-02-01 11:26:06,000" --end-time "2023-02-01 11:30:06,100" --behaviour some_behaviour_name

@angrybayblade What would a failed log analysis look like? It seems that the execution path does not show the events, so in case there is a problem during the path we might miss it.

@angrybayblade What would a failed log analysis look like? It seems that the execution path does not show the events, so in case there is a problem during the path we might miss it.

Not sure what do you mean by a failed log analysis, I can update the output format to include the exit event as well

@angrybayblade What would a failed log analysis look like? It seems that the execution path does not show the events, so in case there is a problem during the path we might miss it.

@dvilelaf Not sure what do you mean by a failed log analysis, I can update the output format to include the exit event as well

I mean when the execution deviates from the happy path. Yes, I think it would be useful to have the events.

@dvilelaf I've updated the command to output the exit event like this
Agent aea_0
|_ Period 0
| |_ registration_startup_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
| |_ registration_startup_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
| |_ reset_and_pause_round | Event.RESET_AND_PAUSE_TIMEOUT
| |_ registration_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
| |_ reset_and_pause_round | Event.RESET_AND_PAUSE_TIMEOUT
| |_ registration_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
|_ End

@dvilelaf I've updated the command to output the exit event like this
Agent aea_0
|_ Period 0
| |_ registration_startup_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
| |_ registration_startup_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
| |_ reset_and_pause_round | Event.RESET_AND_PAUSE_TIMEOUT
| |_ registration_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
| |_ reset_and_pause_round | Event.RESET_AND_PAUSE_TIMEOUT
| |_ registration_round | Event.DONE
| |_ new_tokens_round | Event.DONE
| |_ leaderboard_observation_round | Event.DONE
| |_ image_code_calculation_round | Event.DONE
| |_ image_generation_round | Event.DONE
| |_ d_b_update_round | Event.DONE
|_ End

Nice! Is there a way for us to filter out all the message logs and just keep the logs that come just from the behaviours?

Nice! Is there a way for us to filter out all the message logs and just keep the logs that come just from the behaviours?

Yes, I've added the noise filter


target: clarify which target flags should be available for subcommands

What would you like to be added:
Currently the target flags --garden, --project, --shoot, --seed, --control-plane are available for the target and all of its subcommands.
Clarify if

we want to keep it this way and allow sth. like target project myproject --garden mygarden OR
the target flags should only be available if none of the target-subcommand is used (target --garden mygarden)
only target flags with a higher specificity are allowed. So target project myproject --shoot myshoot would be ok but not target project myproject --garden mygarden would not.

Why is this needed:
follow up for #85

Only target flags with lower specificity should be allowed (1.)


ROR Org selector box refactor

Refactor the org selector box using a local copy of the ROR DB and create an explicit "other" org box to be used if the org does not have an associated ROR ID. This will help make the search faster and in turn, result in fewer duplicate orgs being created.

I think this is working well, but we should look over it together, so I'm sure I've tested all the relevant fields


Docs: Add clarity to the <noscript> part of the source

In reference to: https://github.com/GoogleChrome/application-shell/blob/9f56fd016ced3807b83b1f61a7ec03c97811ed1a/server/views/partials/async-css.handlebars#L28

Folks wondering why they care about noscript in an architecture depending on fetch support
Can we talk about server-rendering the first-request earlier on in the post? Let's figure out where this might make sense.
Primary concern here is the SEO

Responded to the two first bullet points, not sure what to comment on SEO - what was the concern?

Per chat, I think the concern was mostly that we didn't dive too deeply into how and if some of these decisions impact SEO. Imo, what we've added to the readme for this is definitely sufficient. Thanks dude.


Fixes for v1.8

Various fixes pulled into 'arm' branch or 'master' that should go into v1.8

I added the two k6x commits from @mike-scott. They are in #316 but weren't originally in this PR.


Support attributes following a block element

Clear and concise description of the problem
Currently this plugin cannot handle when attributes are on a separate line.
Example use case, where expected result is
* List item
* List item
{.cool-list}

Suggested solution
Plugin markdown-it-attrs supports this syntax, so currently markdown-it-mdc simply errors when encountering this syntax. At a minimum should probably mention in the readme that these two plugins are incompatible.
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

It seems the behavior is a bit unpredictable/confusing to read. I am not very sure if we should support in. Even if we do, I think we'd need to update the MDC spec first before landing the implementation.
/cc @Atinux @farnabaz WDYT?

Does this work? If so, this is the clearest syntax IMO
::ul{.cool-list}
- List item
- List item
::

It will be compiled to this

List item

List item

I guess we might need a bit of special handling for it.

It seems the behavior is a bit unpredictable/confusing to read. I am not very sure if we should support in. Even if we do, I think we'd need to update the MDC spec first before landing the implementation.
/cc @Atinux @farnabaz WDYT?

That's a valid concern. I would either:
a) apply newline attributes based on indentation
b) always apply newline attributes to closest block
Your new solution is neat and in line with general approach, but doesn't solve my use case where the plugin simply dies when trying to parse markdown that uses newline-attributes (for lack of a better term) 😅
Is there a way to make this plugin ignore newline-attributes so that markdown-it-attrs could handle parsing them?

You can disable it with: https://github.com/antfu/markdown-it-mdc/blob/5e34c911d279c04be192199d6cca1367dbd6cbc6/src/index.ts#L19C1-L25C26
Let me know if it doesn't work


fix billing overflow issue during balance transfer

This change looks really good and it is very focused.  We can just run-through the local rebase and test, tomorrow morning, and get this merged.

Rebased & merged


[Possible Bug] Error: pathspec 'refs/pull/5/merge' did not match any file(s) known to git

I'm running into an error:
https://github.com/tharatau/idea-maze/actions/runs/3963315913/jobs/6791006026
Here's my config file:
https://github.com/tharatau/idea-maze/blob/522ae6ec1e6f966276ca4d533cee766652877122/.github/workflows/nw-toolkit.yml
My intuition is I'm configuring it incorrectly. What am I missing?

Okay turns out it was not working on a branch but it worked on main.

Hi @tharatau. Thank you for opening this issue! 👍🏼
It should work as expected, even on different branch, if you run the workflow as you implemented.
A few questions:

Did you try informing the branch as action input?
What was the workflow implementation for pushing and committing the code to another branch?

I'll try to come up with a test case.

Here's what I was initially trying to do:
https://github.com/tharatau/idea-maze/pull/7

Hmm, I forked your repo and made some tests, but didn't understand why the updated file isn't identified yet.
I believe it might happen in the case of a pull_request event, as the when you can create a pull request, Github will execute workflow based on a fake merge branch: refs/pull/:prNumber/merge.

Not sure what you mean?

It's what you did by informing the branch to push to.

I looked into the docs. This might be a limitation of Git/GitHub since:

Github will execute workflow based on a fake merge branch

I'm happy with my current implementation. This can be closed as wontfix or similar. Leaving that up to you.
Thanks!

Ok. Thank you for the return 😄
Let's see if we'll have an opportunity to improve this behavior in the future!


Support WHERE "column" = ANY($1)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
As title, support the following query
SELECT *
FROM "user"
WHERE "id" = ANY($1); -- $1 is array

Currently, I need to achieve this query by using postgres.RawBool().
var ids []uuid.UUID

postgres.
	SELECT(model.User.AllColumns).
	FROM(model.User).
	WHERE(eqAny(model.User.ID, ids))

func eqAny(column jet.Column, values any) postgres.BoolExpression {
	return postgres.RawBool(fmt.Sprintf(`"%s".%s = ANY(#values)`, column.TableName(), column.Name()), jet.RawArgs{"#values": values})
}

Although the above query can be achieved through IN ($1, $2, ...), for dynamic length array, it'll generate numbers of different queries for IN ($1), IN ($1, $2) and so on. For databases there're different queries, that's not a good thing for databases.
I.g.
SQL generated:
For len(ids) = 1:
SELECT *
FROM "user"
WHERE "id" IN ($1);

For len(ids) = 2:
SELECT *
FROM "user"
WHERE "id" IN ($1, $2);

For len(ids) = 3:
SELECT *
FROM "user"
WHERE "id" IN ($1, $2, $3);

And so on.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I hope there's a method .EQ_ANY() for columns.
I.g.
var ids []uuid.UUID

postgres.
	SELECT(model.User.AllColumns).
	FROM(model.User).
	WHERE(model.User.ID.EQ_ANY(ids))

Hi @houten11, I've checked the wiki. It do achieve the WHERE IN. But like I mentioned, this method generate one queries for each length of array. I.g. your array input could have length between 1 to 1000, Table.Column.IN(array...) will generate 1000 different queries. Which means, that's 1000 different queries for database. The database cannot reuse SQL query compile caches.
For array with length 1 (with WHERE IN:
WHERE "id" IN ($1)

for 2:
WHERE "id" IN ($1, $2);

for 3:
WHERE "id" IN ($1, $2, $3);

And so on.
For array with arbitrary length (with = ANY()):
WHERE "id" = ANY($1);

Sorry, skimmed over the issue description on the first read. Yeah, ANY is not supported but you can add a custom support:
func ANY(expr Expression) Expression {
	return Func("ANY", expr)
}

This function now can be used as part of query:
User.ID.EQ(IntExp(ANY(
    Raw("#1", RawArgs{"#1": pq.Int32Array{1, 2, 3, 4}}), // arrays are not supported, so we have to use Raw
))),

or
User.ID.EQ(IntExp(ANY(
    SELECT(...)...
))),

Hi @houten11, thanks for the solution. But is it possible to add a .EQ_ANY() (Or some sort of helper function) for each column type? IMHO, = ANY() is a common operation, it's often used with prepared statement.
With User.ID.EQ(IntExp(ANY())), I need to write XxExp() for each type, I.g. I need to write another one for string type Table1.StrID.EQ(StrExp(ANY())) and so on. I cannot just write Table2.AnyTypeOfID.EQ(ANY()).

Hi @yz89122,

I cannot just write Table2.AnyTypeOfID.EQ(ANY()).

jet is a type safe library, so the types needs to match.

But is it possible to add a .EQ_ANY()

If we add EQ_ANY, we would also need to add, for each of the types, NOT_EQ_ANY, LT_ANY, LT_EQ_ANY, etc... This would lead to number of methods explosion. Also note that ANY can accept either array or subquery.
In some cases we can avoid writing XxxExp, because Go has generics now. But in the case of ANY, it might not be possible because ANY can accept subquery as well.
If you want to avoid XxxExp, you can add additional ANY methods for each type.
func ANYi(exp Expression) IntExpression {
    return IntExp(ANY(exp))
}

func ANYs(exp Expression) StringExpression {
    return StringExp(ANY(exp))
}

You can also wrap array constructor in a new method:
func ARRAY(elems ...any) Expression {
   return Raw("#1", RawArgs{"#1": pq.Array(elem)}),
}

Now you can write:
User.ID.EQ(ANYi(ARRAY(1, 2, 3, 4))

User.Name.EQ(ANYs(ARRAY("John", "Mike", "Tod")))

Hi @go-jet, one additional information, ANY, SOME and ALL seem like they're operators, not function. https://www.postgresql.org/docs/current/functions-comparisons.html
One more question: Is it possible to add postgres.ANY() to this library? I.g.
postgres.
  SELECT(table.User.AllColumns).
  FROM(table.User).
  WHERE(table.User.ID.EQ(postgres.ANY(ids)))

Currently, the postgres.ColumnString contains un-exported methods and interfaces, so I cannot create my own universal ANY() function for all types of columns.

ANY, SOME and ALL seem like they're operators

Actually, Strictly speaking, IN and ANY are Postgres "constructs" or "syntax elements", rather than "operators". In SQL they appear as function, so make sense to model as function.

One more question: Is it possible to add postgres.ANY() to this library?

Eventually it will be introduced as part of array support.


how to open google map in axmap of mapwingis in my desktop application?

how to open google map in axmap of mapwingis in my desktop application?

this question has nothing to do with openlayers


Placeholder for other webhook events implementation.

Current dependencies on/for this PR:

main

PR #36   👈

This stack of pull requests is managed by Graphite.

Does the force closure webhook need to go through remote signing flow? or is it just informational?

Does the force closure webhook need to go through remote signing flow? or is it just informational?

FC webhook is a separate webhook as other, like payment finished, etc. But the url for all webhooks is the same, so this endpoint handler should be able to distinguish other webhooks and handle them separately from signing flow. This why this match added, but also to allow FC webhooks from Sparkcore to resolve and stop bugging me :)

I see. LGTM!

Merge activity

Feb 5, 8:07 PM EST: @yellowred merged this pull request with Graphite.


General cleanups

commit comments explain it i think. But generally just trying to move things about a bit to make it easier to understand exactly whats going on.

@chrismatheson sorry, just getting around to sorting out these PRs- as you can see I at least have Sauce working :) Is there a way of kicking off this build again with Travis?

Oh bugger I just blew it away (read wrong that it was merged allready)
I don't think there was anything important there tho so no great loss :)
Sent from my iPhone

On 8 May 2015, at 17:24, Chris Mowforth<EMAIL_ADDRESS>wrote:
@chrismatheson sorry, just getting around to sorting out these PRs- as you can see I at least have Sauce working :) Is there a way of kicking off this build again with Travis?
—
Reply to this email directly or view it on GitHub.

@chrismatheson No worries, I can pull from your general-cleanups branch myself. Thanks!


CNV on No. of classes greater than 64

I am trying to extend the no. classes to greater than 64 e.g. trying to use CNV with CIFAR-100.
Is there any specific reason why max no. of classes is fixed to 64? Is this related 64-bit bus alignment?
Thanks!

There is no specific reasons about why we set the value to 64, you can increase the number of classes if you want. You can change in the hardware the value L8_MH  in the config file to the needed number of classes.


Adding compactor version in audit info and rci

#150
This commit adds the compactor version in round completion file and audit to allow looking up what version was used and also allows driver to programmatically lookup version to decide whether to run rebase or incremental compaction. E.g., if version changes, a rebase has to be run.

A few small comments but otherwise LGTM


Create email-security.mdx

In a few of our automated customer-facing emails, we include information such as "Concerned about security? If you suspect an unauthorized party is attempting to access or has already accessed your SaladCloud account, contact SaladCloud support immediately. If you want to learn more about how these requests may be made by an unauthorized party, please visit our email security documentation."
Currently, we don't have an email security page to push users towards and describe the processes we have in place. This page creation is meant to solve this!

@shawnrushefsky do you think this is the best place for this article to live? Something doesn't sit right about this living so close to the top of our documentation. I'd rather users be brought to this page versus being so apt to discover it!

I think this should probably live on the security page, in FAQ: https://salad.com/security

@seanwmiller I'm closing this PR. Will you sync up with Scott about getting this on our main security page?


[TS migration] Migrate 'Navigation' lib to TypeScript

Details
Migration of Navigation to Typescript.
Fixed Issues
$ https://github.com/Expensify/App/issues/24934
PROPOSAL: N/A
Tests

[x] Test the app generally, navigating through the app, login screen, settings, report screen.
[x] Verify that deeplinks redirect to the correct pages

e.g. https://dev.new.expensify.com:8082/settings/profile/pronouns should open pronouns settings page
Verify that back button works as expected

[x] On web and desktop, change the size of the window. Verify that screens are displayed correctly

Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android (1).webm

Android: mWeb Chrome
android-web.webm

iOS: Native
https://github.com/Expensify/App/assets/46095609/6c7a206b-1e09-4a08-bb01-0e88d625083c

iOS: mWeb Safari
https://github.com/Expensify/App/assets/46095609/a54b14d0-4ae1-4238-b42b-788ac11f6641

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/46095609/35d7c0d4-7d26-47ad-a296-f27ee1948b64

MacOS: Desktop
https://github.com/Expensify/App/assets/46095609/df6fdf1a-f3da-463d-a4ad-adf6d7fc4a72

@0xmiroslav Expensify & SWM team are working on navigation refactor atm, this migration could speed up things - so please have a look and prioritise reviewer checklist please 🙏

@situchan Thank you for the detailed review from your side! Adjusted the code 🚀

BUG: infinite loading on report screen on desktop app when opened from deeplink
https://github.com/Expensify/App/assets/108292595/ed4c990a-2e9c-46ed-819f-b127bea8fda1
I will confirm if this also happens on main

I didn't know how to test deep links on desktop 😅 - for me the browser was always opened instead..
If it is only reproduced on this branch please describe the reproduction steps precisely.

Confirmed happening on main as well so not blocker.

I didn't know how to test deep links on desktop 😅 - for me the browser was always opened instead..

Please comment this line to test desktop deeplinking:
https://github.com/Expensify/App/blob/e355608a9e0ee107abe06f610031c80f74ed8fa8/src/components/DeeplinkWrapper/index.website.js#L72-L74

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/b744aac5-bc01-40a7-8e58-a0d0df392e6a

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/914a8a5d-b6bc-4829-9b82-0fde3133ca31

iOS: Native
https://github.com/Expensify/App/assets/108292595/2a0c9ae9-b46c-4902-9410-027d410ce8a2

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/627e883b-160a-462a-9861-8c7bbee8e346

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/1d71bb52-dac7-4746-a297-c1192763754a

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/9aeae804-fc7f-4da5-a31e-31d4249cce9d

I think @roryabraham is OOO after Thanksgiving (based on Rory's Slack status). @flodnv could you handle review instead? Thank you in advance 😄

Looks like he'll be back today
On Tue, Nov 28, 2023 at 4:45 AM Błażej Kustra @.***>
wrote:

I think @roryabraham https://github.com/roryabraham is OOO after
Thanksgiving (based on Rory's Slack status). @flodnv
https://github.com/flodnv could you handle review instead? Thank you in
advance 😄
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/pull/31543#issuecomment-1829351398, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7Y2OJ4DMOANBVBA6OWA63YGWQCBAVCNFSM6AAAAAA7SZ3SS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRZGM2TCMZZHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.5-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


add filename as argument for read_forecast

Allow user to specify the filename here...
https://github.com/BigelowLab/pspforecast/blob/master/R/forecast_io.R#L28
... with default being the system file.  Maybe...
read_forecast <- function(
  file = system.file("forecastdb/psp_forecast_2022.csv.gz", package="pspforecast")
  format = FALSE,
  new_only=FALSE) {
  .
  .
  .

read_forecast() now has file argument, but must be passed in as a variable, not the direct url.
default forecast db is still file installed with package locally.
for example, read_forecast(file="https://github.com/BigelowLab/pspforecast/blob/master/inst/forecastdb/psp_forecast_2022.csv.gz")
won't work.
instead, use:
filename = "https://github.com/BigelowLab/pspforecast/blob/master/inst/forecastdb/psp_forecast_2022.csv.gz"
read_forecast(file=filename)


Restart not Working in Preview When Only 1 Page

Bug Description
When previewing a story with only 1 page, the restart button does not work.
Expected Behaviour
Pressing the restart button should restart the 1 page story.
Steps to Reproduce

Add a video to the page so you can tell if it "restarts"
save and preview the story
Press restart when the auto advance is done

Screenshots
Restart button on the far right.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions

Seems like an issue in the AMP story viewer, not something that we could control.
@wassgha perhaps you could confirm?

That's correct, I'll report it on the amphtml side

Filed https://github.com/ampproject/amphtml/issues/27742

Closing since it's an upstream issue


Missing module port for RX

There are no files in ports_module/ for RX processors. The documentation https://docs.microsoft.com/en-us/azure/rtos/threadx-modules/appendix#rx65n-processor mentions sample projects that do not exist.
Is the RX processor not supported by threadx modules or are those files just missing from github?
Thanks

We have an older Modules port for the RX (from our Express Logic days), but this hasn't been updated for Azure RTOS yet. I am not sure when Modules for RX will be available on github.


fix initialization

Description (required)
corrects the initialization of the plugin when there are elements in the select before starting the search
and preserveSelected: true
Screenshots (optional)
If this pull request affects any visual or UI aspects of this project
then you should place them here, preferably in a before/after format.
Closes Issue (optional)
Closes  https://github.com/truckingsim/Ajax-Bootstrap-Select/issues/85
Related Issue(s) (optional)

X-ref https://github.com/truckingsim/Ajax-Bootstrap-Select/issues/152

Merge checklist (required, for maintainers only)
This pull request adheres to the following requirements:

[] JavaScript follows 4 space indentation conventions.
[] JavaScript was written using ES2015 (ES6) features.
[] Features and bug fixes are covered by test cases.
[] All commits follow the AngularJS Git Commit Message Conventions.

These changes resolve the problem for me and looking forward to new version.
Also I think this line must stay as it is
preserved: plugin.options.preserveSelected

Please base PRs agains the dev branch.

@markcarver
Oh. there are conflicts.

Hm. Seem dev was severely outdated. It's fixed now.

@markcarver
i still have conflict.
I need to fix my  pool request
in this line (preserved: plugin.options.preserveSelected,)
or will you fix it when merging?

or will you fix it when merging?

You'll need to fix it prior to merging this PR.

I fixed and resolved conflicts


fix: add ArcElement to getting-started.md

Hi, don't know if it is necessary but in my case I had to add it to work with (before I had to include Arc instead of ArcElement

Did you get an error before including the ArcElement? Line chart?
Maybe we should list all the registrable exports on that page.

by using type="doughnut"yes

All possible imports:
import {
  Chart,
  ArcElement,
  LineElement,
  BarElement,
  PointElement,
  BarController,
  BubbleController,
  DoughnutController,
  LineController,
  PieController,
  PolarAreaController,
  RadarController,
  ScatterController,
  CategoryScale,
  LinearScale,
  LogarithmicScale,
  RadialLinearScale,
  TimeScale,
  TimeSeriesScale,
  Filler,
  Legend,
  Title,
  Tooltip
} from 'chart.js';

Chart.register(
  ArcElement,
  LineElement,
  BarElement,
  PointElement,
  BarController,
  BubbleController,
  DoughnutController,
  LineController,
  PieController,
  PolarAreaController,
  RadarController,
  ScatterController,
  CategoryScale,
  LinearScale,
  LogarithmicScale,
  RadialLinearScale,
  TimeScale,
  TimeSeriesScale,
  Filler,
  Legend,
  Title,
  Tooltip
);

Import everything as in version 2:
import * as ChartJs from 'chart.js';
ChartJs.Chart.register.apply(null, Object.values(ChartJs).filter((chartClass) => (chartClass.id)));

var myChart = new ChartJs.Chart(ctx, {...});

@LeeLenaleee I added all possible import as you provide


Raise on duplicate keys

Recently we had an issue in cuCIM where the same key appeared twice ( https://github.com/rapidsai/cucim/pull/757 ). Unfortunately we didn't realize until something didn't behave correctly
It would be helpful to catch these cases in advance by having RDFG raise if it sees duplicate keys

cc @grlee77 (who caught this issue)

Just ran into another cases of this: https://github.com/rapidsai/rmm/pull/1613#discussion_r1718499266
Alternatively, we could roll out something like yamllint across RAPIDS. It has a rule to prevent duplicate keys: https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.key_duplicates
That could probably be used for some of the other things I mentioned in #103 as well.


Decrease GitHub repository size

Currently, the GitHub repository is quite large (> 100 MB).
This is mostly because of third-party modules such as the Bruker Feature Finder.
It would be beneficial to be able to have a lightweight version and download the additional features on-demand.
Maybe we could link to the extra files and then download them.
The one-click installer should have all modules anyhow.

Moved to suggestions.


Changed logo from layer5 to meshery

Notes for Reviewers
I have changed the logo as described in the issue.

This PR fixes #90
Signed commits

[x] Yes, I signed my commits.

please review this @leecalcote @Chadha93

Thanks for getting this updated


🐞 Use custom create label when editint vmware boot disk

Use custom create label when editint vmware boot disk
"Create new option" should be "Custom path"
Screenshot:

addressed by https://github.com/kubev2v/forklift-console-plugin/pull/1260


Thecodepixi/move required args to session constructor

WHY are these changes introduced?
To fix merge conflict in #169.

@paulomarg Isthe CLA bot broke?
I signed the CLA:

This is no longer needed as #169 was clarified by https://github.com/Shopify/shopify-node-api/pull/169#issuecomment-944554441.


TabBar image for selected controller is not centered vertically

Items in UITabBar are centered vertically on the availabel space. In your control you even slightly move the image to the bottom.
If you think this behaviour is normal then could you allow to customize it? For example by making your private methods public to allow to customize this behaviour by subclassing or via other ways

This issue fixed with the latest release.
Thank you,


Navbar Hamburguer doesn't work on mobile

This makes the users unable to navigate the site through their phones.

a1e111aceb85304b25c68ab22df372762ceb200a


Use SPI instead of Enum for VectorSimilarityFunctions

Description
This PR is to get feedback on the idea and any major changes required in the commit.
In this commit we are using Java SPI instead of ENUM to define VectorSimilarityFunction used for vector search. Current implementation in Lucene tightly couples ENUM to Lucene index i.e. enum values are directly used in field info which are stored in index and later used for reading purpose. This makes adding or removing any similarity function to the ENUM very difficult as removing any function from ENUM can change the ordinal value of the functions and cause mismatch of field while reading fields from the Lucene index. On the other hand Java SPI makes life easier by providing pluggable implementation of the similarity function. With SPI, we can extend or remove similarity function easily without the need for changing things at indexing and searching sides.
For backward compatibility, I have kept ordinals with the similarity functions which can be directly used for writing/reading fields to/from the index. For Lucene version >=10 we can remove ordinal implementation from the code and directly use function name for reading/writing the index.

@benwtrent @uschindler @ChrisHegarty
Could you please take a look, if you get a chance?

+1 on the feature and functionality. I would like to recommend one thing here:
Can we add the reloading the SPIs functionality for VectorSimilarityFunctions just like we have for codecs. Ref: https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/codecs/Codec.java#L126-L137
this will ensure that vector similarity functions which are not inside Lucene can be created if anyone want to put a different similarity functions like l1, linf etc for doing similarity search.

Makes sense. Thanks @navneet1v for the suggestion.

I did kind of change before, and the added complexity and backwards compatibility concerns just didn't seem warranted. This is why the decision to do the scorer pluggability was added to the codecs.
How do you communicate to codecs the similarity kind?
For example, Vector quantization needs to know if the similarity is cosine. Do we do a "cosine".equals(similarity.name())? That is very fragile. What if some one does an "optimized cosine"? Name conflict or they just cant use vector quantization.
What if someone adds an SPI similarity that should be normalized before being quantized?
I don't see a way of doing this without leaking this internal dependency (normalization being required) into the similarity SPI, which is weird to me.
I just don't think this is feasible.

My old PR: https://github.com/apache/lucene/pull/13200

I have some comments, but this is not a final review. Just things that I stumbled upon on first walkthrough.
I will have no time to do a closer review soon, so please give me some time.

Thank you @uschindler for all the comments, I have tried to fix them in the latest commit. Looking forward for more.

I did kind of change before, and the added complexity and backwards compatibility concerns just didn't seem warranted. This is why the decision to do the scorer pluggability was added to the codecs.
How do you communicate to codecs the similarity kind?
For example, Vector quantization needs to know if the similarity is cosine. Do we do a "cosine".equals(similarity.name())? That is very fragile. What if some one does an "optimized cosine"? Name conflict or they just cant use vector quantization.
What if someone adds an SPI similarity that should be normalized before being quantized?
I don't see a way of doing this without leaking this internal dependency (normalization being required) into the similarity SPI, which is weird to me.
I just don't think this is feasible.

Thank you @benwtrent for the feedback and sharing your PR. I didn't know, this attempt was already made before. The main motivation behind this change was to get rid of ENUM implementation which is tightly coupled to field-info. This has caused inconvenience in deprecating the COSINE function from the list. Not sure what's the best approach then. Will take a look at your PR and comments to understand more about this.

The main motivation behind this change was to get rid of ENUM implementation which is tightly coupled to field-info. This has caused inconvenience in deprecating the COSINE function from the list. Not sure what's the best approach then. Will take a look at your PR and comments to understand more about this.

This is not a very compelling reason supporting the proposed change. I agree with @benwtrent, there are several challenges that would need to be ironed out before we could consider moving this forward.
The recent addition of FlatVectorsScorer has certainly improved the extensibility in this area. For now at least, it appears to offer what is needed to plugin in new implementations.

Wanted to touch base on this PR as it seems to have been stalled, mainly by me.
The only format that would support pluggable similarities would be Lucene99HnswVectorsFormat. Any of the quantized codecs would have to throw an exception on an unknown similarity name.
This now complicates a user's mental model support matrix. Having to consider not only codecs, but similarities, all of which are pluggable.
This inherit complexity of making things pluggable is why I think the implication of the "pluggable similarities" is "just make your own format".
However, I am not against moving away from enum and moving towards a nominal/id set of core interfaces. Enums are notoriously painful for BWC as removing one adjusts its "id" and now various edge's have to be smoothed out all over the place.
All this talk of a pluggable SPI for vector similarities spawned out of the complexities of adding fully BWC similarity functions and the difficulty of deprecating and moving on.
So, I propose:

We deprecate cosine (as we already have) and remove it from being writable in v10
Move away from enums to an id/nominal system for the similarities (what this PR could do)


move away from go-git

Summary
We changed the git library in v3.4 to go-git which seems to have a lot of bugs and also is not actively maintained, the last release created for this project was on June 2, 2021, which was more than an year ago. Currently we are maintaining our own fork of go-git at argoproj-labs/go-git. There's a similar package git2go which has go bindings for libgit2 and is also actively maintained and being used widely. Should we consider migrating to that package?

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

+1 to this. go-git does not appear to be as well maintained as would be desirable. Would you be willing to do an evaluation of the alternatives? One thing to consider is that git normally requires a fat (and much less secure) base image (e.g. ubuntu). Does git2go work? Do we need to use CGO? It’s fine to use CGO, just more complex.

The reason for using go-git instead of the git binary is that the git binary was being installed using a package manager and therefore requiring a fat base image.
Can we install the git binary without a fat base image? I.e. standalone/statically linked binary. We would have a properly tested and supported git, without the downsides.
I think we could just have another Dockerfile target that builds a statically linked git from source:
https://stackoverflow.com/questions/11570188/how-to-build-git-with-static-linking
https://www.lyraphase.com/wp/projects/how-to-build-git-for-a-host-with-no-compiler/

I am working on this.

Thanks. Assigned to you.

go-git is back to maintenance and active for a couple of months already so we should contribute any changes back to upstream and switch back to upstream go-git: https://github.com/go-git/go-git
See project status update: https://github.com/go-git/go-git#project-status

One user mentioned another upstream bug https://github.com/go-git/go-git/issues/511


Better way to run a implementation with different expressions

I want to run certain implementation with different expressions.
I have some step which is given step for certain scenario but when step for other scenario
For example:
In one scenario I have
When a user has browsed to the homepage
On the other scenario I might use it in given step
Given the user has browsed to the homepage
I want same implementation to run in both cases,
My current solution looks like this:

But It would be impractical to do this for longer implementations (then I might define a new function an call the same function from both implementations) I don't think this is also a good idea.
So, my question is can we have something like this:

I know the syntax looks funny but there can be a better way.
This is how it's done in PHP Behat.

But I was wondering if I can do something similar in Cypress.

try
const adminLogsInUsingTheWebUi = () => { cy.visit("/") }

Given('the user has browsed to the home page', adminLogsInUsingTheWebUi);
When('the user browses to the home page', adminLogsInUsingTheWebUi)

@lgandecki Yeah, this seems to be the best way. Thank you


Limited recursion and made boz code gfortran compliant

Modified test_derived_type_linked_list to iterate to min(1000, getrecursionlimit()-100).
On my system, getrecursionlimit() returned 1000. I set 100 as a buffer somewhat arbitrarily. 50 was not enough.
Changed the boz test code to be compliant with the Fortran standard. gfortran 12 refused to compile and looks like n1 = B'00000' has not been acceptable since gfortran 10.

Codecov Report

Merging #65 (a77c0e3) into main (1d2025a) will decrease coverage by 0.02%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   91.78%   91.76%   -0.02%
==========================================
  Files          86       86
  Lines       15281    15280       -1
==========================================
- Hits        14025    14022       -3
- Misses       1256     1258       +2

Flag
Coverage Δ

lint_rules
97.35% <ø> (-0.01%)
:arrow_down:

loki
92.01% <ø> (ø)

transformations
86.87% <ø> (-0.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Rules to run opensta to get longest path.

Rules to run opensta to get longest path.
Uses a default "sta.tcl" script that can be overridden.

This was for testing the copybara config (it did catch a couple of issues that I fixed).  I think we then run copybara again "for real" after my CL is merged inside Google.


Mac local postdeploy.yml fails

TASK [install the catalog from the catalog location] ******************
fatal: [ansible]: FAILED! => {"changed": true, "cmd": "./installCatalog.sh
getsockopt: operation timed out\nerror: Package update failed:

@lehoanganh do you know a workaround for this?


Support to create Kube-api server of shoot in Alicloud

What this PR does / why we need it:
Support to deploy shoot kube-api server in Alicloud
Which issue(s) this PR fixes:
Fixes #367
Special notes for your reviewer:

This PR supports to deploy a shoot(Alicloud) till deployKubeAPIServer (in shoot_control_reconcile.go). Kube-api server could be deployed successfully.
Support Alicloud DNS. Please be noted that the terraform DSN record resource structure for Alicloud is quite different with other providers like AWS.

Release note:
NONE

Thanks! This PR will leave the repository with an "incomplete" code-flow (as alicloud cannot be created further than to the kube-apiserver). I'd kindly ask you to only submit complete PR. The DNS part of Alicloud looks OK, but there are also some parts missing, e.g. in the DNSHostedZone admission controller. Please take a look at https://github.com/gardener/gardener/pull/215 and what was needed to integrate openstack-designate as DNS provider. Kindly file a separate PR for the Alicloud DNS if you finished it, and then another one for the Alicloud botanist allowing creation of Shoot clusters.


NEED help how to use SelenideProxyServer without instantiating explicitly any driver, with Selenium Grid ?

The problem
CustomWebdriverWithSelenideProxyTest is using SelenideProxyServer and instantiating explicitly the driver chrome or firefox.
how to have the same behavior of that test without  instantiating drivers.
but just using static Configuration.browser ?

@Tonicku What exactly do you want to achieve?
Using proxy in Selenide is much easier than in CustomWebdriverWithSelenideProxyTest.
Configuration.proxyEnabled = true;
Configuration.remote = "your-grid-url";

open("some://url");

Feel free to reopen if new information arrives.

@asolntsev Thank for your support.
what i wanted is to intercept traffic as depending on my tests, the id of the created object is in the xhr response.
after a upgrade settings on our selenium grid, i was able to use the DevTools in this way
No Activation of your settings
 WebDriver augmentedDriver = new Augmenter().augment(WebDriverRunner.getWebDriver());         DevTools devTools = ((HasDevTools) augmentedDriver).getDevTools();         devTools.createSession();         devTools.send(Network.enable(Optional.of(100000000), Optional.empty(), Optional.empty()));         final String[] responseBody = new String[1];         devTools.addListener(Network.responseReceived(), responseReceived -> {              .... code depending on what we are looking for ...         });         return responseBody;     }
I tried you approach, here is my working progress
    WebDriverRunner.getSelenideProxy()
                   .addResponseFilter("WorkRequest", (response, contents, messageInfo) -> {
                       if (messageInfo
                               .getUrl()
                               .contains("...")) {

                           log.debug("ResponseReceived: " + contents.getTextContents());

                       }
                   });

I don't have a result as i have to play with the host file or if there a way to inject them into SelenideProxy ?

when i activate the proxy ; Configuration.proxy = true., the Web application url is giving a response 400.
i guess it's because it's missing setting in the Selenide Proxy to have response 200.
i guess i need to set up the allow list into the proxy:
WebDriverRunner.getSelenideProxy().getProxy().addAllowlistPattern();

@Tonicku I don't think you need to call addAllowlistPattern(). In all my projects, proxy works without addAllowlistPattern.
You rather need to investigate why your application responses with 400 code. Can you read the application logs?


OG-USA developer meeting agenda, 10/12/20, 12p ET

Agenda for OG-USA developer meeting: 10/12/20
12-1pm ET
Zoom Meeting ID:<PHONE_NUMBER>
Zoom Meeting Password: ogusa
Zoom Meeting URL: https://riceuniversity.zoom.us/j/4073958475
This meeting is open to the public.
Agenda

Follow up on 9/28/20 developer meeting discussion.
Status of @jpycroft's PR #639.
Update on @MaxGhenis and @prrathi's work using OG-USA to study the effect of increasing the capital share of income from its default of gamma=0.35 to something like gamma=0.40.
wealth.py data moments now use SCF 2019 (PR #658)
@jdebacker's PR #629 consolidates tax rate calculation functions (and adds a plot)
Status of beta_j calibration (see Issue #660 and merged PR #655)
@jdebacker's PR #652 adding two new high income groups.
Update initial distribution of wealth using SCF data. @rickecon has some work on this in the https://github.com/rickecon/OGbequests repository.
@rickecon is currently running baselines with various growth assumptions: g_y_annual = 0.035, 0.04, 0.05, 0.06. Test what growth rate needed to stabilize debt at current fiscal policy.

Next meeting: Monday, October 26, 2020, noon-1pm ET

Notes:

@jpycroft's PR #639 was merged. Solution was to just set it to run only on the full_run flag.
@jdebacker's PR #629 was merged. Consolidates ETR and MTR producing functions. Adds 2D tax function plotting.
@rickecon still working on beta_j calibration


In PTM search assigned unimod id dosen't match real unimod id

Metamorphius assigns the modification "Decarboxylation" the Unimod id 914 and the atom count H-2 C-1 O-1. This doesn't match the entry on Unimod. And "Glu to PyroGlu" is assigned to Unimod id 28, but on Unimod it's the description for Unimod 27.

I tracked this down to incorrect hard-coding in the mods.txt file


chore(editorconfig): reenable editorconfig loading

Summary

This was disabled in #2943.

related to: #1724
Test Plan

CI should pass

Ah, ok. I'll mark this as draft until the config gets added.
It's likely emitting diagnostics for this:
[{**.yml,**.md,**.rs,**.mdx,justfile,**.json}]
indent_style = space

Which is intentional, because biome can't parse these kinds of glob patterns. The easy fix for this would be to just separate this override into multiple overrides. Would we want to support this glob pattern syntax?

I've updated this PR to change the editorconfig so that it can be parsed by biome.

Closing this because this conflicts with another PR I'm working on.


LiveKit Server communicating with EC2 instance

Hi community!
I'm using the livekit server and when inspecting the network traffic I found that it was communicating with an instance of an EC2, does anyone know why that happens? I'm just using the dev server with the API key/secret pair suggested in the docs.
Server
.
Thank you very much in advance!

by default livekit points to Twilio and Google's public STUN servers. I believe Twilio is hosted on AWS


User interface for uploading a video from invite page not obvious

It shows the "browse" prompt for a video, which is not particularly good UX on mobile.

Not fixing as transitioning to mobile app invite flow.


refactor: Consolidate symbol formatting code

Consolidates symbol formatting logic to handle escaping etc.
This also avoids most direct accesses to the scratchBuffer,
which is mostly used behind a couple of methods.
This addresses one of the points of feedback from earlier,
with the symbol formatting logic being scattered across
different places. Now is a good time to introduce this, before
adding support for local variables.

Merging this now with some of the suggested fixes, happy to address more follow-up comments with separate PRs.


Writing JPG actually creates PNG file

Writing JPG actually creates PNG file.

Determine if this is still an issue or not.


Make sure PPND will be okay with the latency of Pipeline/ISBService informers

this is based on this comment

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

I came up with at least one case where it wouldn't be good:
once PipelineRollout Reconciler has update the Pipeline spec, it will check to see if the Pipeline is still reconciling in order to know whether it can resume the Pipeline or not. If we get an old copy of the Pipeline spec whose generation still shows the previous generation, then its observedGeneration would in fact match the generation, and then we'd resume the Pipeline prematurely.
For this reason, I think if we currently have the PPND InProgressStrategy (saved in memory), then we should reach out to the K8S API to get the latest spec rather than just using the one from the Informer.


tutorials/logging-modules/log4j2: removal of unnecessary "${sys" file

Description:
I wanted to check log4j tutorial source code and found unnecessary file. This PR removes it.

Thanks @DaliborSkrobak


dataset-selectivity performance regression?

I have seen something in conbench.ursa.dev that I would love to use as an example scenario: do we have a performance regression, or do we have a methodological weakness?
https://conbench.ursa.dev/benchmarks/4fe411bf67a94bc6aa9787fc0394bd03/
That is, around 2023-01-05 07:49 it was measured with https://github.com/apache/arrow/commit/e5ec942075b079964955729761095547f5ff2a70 that benchmark dataset-selectivity with case permutation 10%, nyctaxi_multi_parquet_s3 took almost two seconds in each of three iterations: [1.951955, 1.846497, 1.891674].
In the previous 1-2 weeks it took ~1.2 seconds:

https://conbench.ursa.dev/benchmarks/4fe411bf67a94bc6aa9787fc0394bd03/ does not show a lot of history. It goes back only until 22-12-28.
Manual history extension: https://conbench.ursa.dev/benchmarks/db5ae59ff5944b2180dc73e2c35e2c43/

Data points from 22-12-22: [1.24206, 1.174114, 1.248703].
Summarized observations:

between 22-12-13 and 23-01-04 the duration was around ~1.2 seconds, with the variability being smaller than 0.1 seconds.
on 2023-01-05 the duration changed to ~1.9 seconds, still a small variability.

Returned back to normal in subsequent run:
https://conbench.ursa.dev/benchmarks/a8b86353d80145bb91d1bd2a1125d81e/

timestamp 2023-01-05 10:44
data [1.225894, 1.226221, 1.172097]

Notably, this was executed on ursa-i9-9960x.

Yeah, this is a circumstance that we have observed in a few places even with dedicated runners, we have some benchmark cases that have blips like this that look like regressions initially, but go away on the next run. I was talking to Austin about this the other day and wrote up (some of) what we talked about in https://github.com/conbench/conbench/issues/572 which is a large(r) project, but one I think would be good to spec out and see how much it would take to add.
Of course, like I mention there: that project should not preclude looking at this benchmark code to see if there's something we can do to make it more reliable. One question about the disk I/O interference: I thought you crafted this benchmark so that it was using ram disks to prevent something like that from happening (but I will admit I didn't follow super closely while I was out, so I might be wrong about that), which should make disk I/O not super important, yeah?

I was talking to Austin about this the other day and wrote up (some of) what we talked about in https://github.com/conbench/conbench/issues/572 which is a large(r) project, but one I think would be good to spec out and see how much it would take to add.

Cool, replied there!

that project should not preclude looking at this benchmark code to see if there's something we can do to make it more reliable

Of course, and instead of 'code' I'd more generally say 'method'. Careful thought about what a benchmark is even supposed to measure and whether or not it makes sense to have that affected by disk I/O is I suppose one of the most influential approaches to fight instability.

One question about the disk I/O interference: I thought you crafted this benchmark so that it was using ram disks to prevent something like that from happening (but I will admit I didn't follow super closely while I was out, so I might be wrong about that), which should make disk I/O not super important, yeah?

I did that in 'my' benchmark dataset-serialize. This one here is dataset-selectivity which reads gigabytes of data from disk.

I did that in 'my' benchmark dataset-serialize. This one here is dataset-selectivity which reads gigabytes of data from disk (and measures how long that takes).

AH, right right of course I got those wires crossed, sorry


Error: File 'myImage.png': VipsOperation: class "webpsave_buffer" not found

When I try to create webp images, I get the following error message:
Error: File 'myImage.png': VipsOperation: class "webpsave_buffer" not found
I am able to create jpg and png images successfully.
I'm on:
Windows 10
Node v5.9.1
Here's the configuration I'm using:
{
  width: 200,
  rename: {
    suffix: '-small',
    extname: '.webp'
  }
}

Hi @edtalmadge
Sorry but:

The WebP format is currently unavailable on Windows.

http://sharp.dimens.io/en/stable/install/#windows
@lovell do you have any plans for this feature?

A cross-compiled libwebp v0.4.3 for Windows fails but the new-ish v0.5.0 release should be OK. Once the groundwork laid by https://github.com/jcupitt/build-win64/pull/4 (or similar) is available I'll attempt to introduce it.

@lovell Thank you for clarification.

Ok, sounds good, thanks.

v0.5.0 of libwebp appears to be stable when cross-compiling so sharp v0.15.0 will add support for the WebP format on Windows. Subscribe to https://github.com/lovell/sharp/issues/369 for updates.

Thank you for update!


Shorten mobile number to pass E.164 validation

We will have to introduce a validation on mobile number in core-banking. The fake number used by the idnow-client until now is not valid and had to be shortened.

Needed by: https://github.solarisbank.de/solarisBank/core-banking/pull/303

Looks good to me. +1.

We can merge this because its actually more realistic, but keep in mind that this is a public and generic gem (just github.com)


Support n parameter in Criteria::Chain#first

I recognized we forgot about the optional n parameter in Criteria::Chain#first, such that this PR adds support for it by applying the param to scan_limit respectively record_limit.

Makes sense. Thank you.


Replace deprecated dependencies

Upgrade golang version
Upgrade golang protobuf
Upgrade go-zookeeper due to deprecation
Remove gogo/protobuf  due to deprecation
Update canal entry proto file
Change some naming convention

@gfunc  hi, would you  kindly test this PR?

Thanks @gfunc


allow removing the hintText search icon

This is implemented with either a searchIcon value of null or "none".

Nice! Thanks, David. I'll have a look asap :)


Image auto orientation

Looking for recommendations on auto orientation along with other image processing options. Personally I feel like auto_orient should be a config item that can be applied to all uploading images this would then result in no change of the current helpers and image processing.

Moving this to the refile-mini_magick repo since image processing has been extracted from Refile.


[SYSTEMML-930] Set unlimited result size when call through  MLContext

Its not working in some cases, trying to debug it further.

thanks @asurve - could you also comment on how you tested it (the most important question to answer is how to do this configuration management on an already created spark context that is passed from outside into mlcontext).

It seems setting maxResultSize after SparkContext started does not get reflected. It needs to be set before starting SparkContext. User needs to set it through configuration like
On command line by adding following for unlimited size (which SystemML prefers)
--conf spark.driver.maxResultSize=0

well, in that case, I would recommend to throw a warning if a spark context with maxResultSize < local_memory_budget is passed in.
An alternative would be to automatically lower the local memory budget to the max result size but this has many negative implications for local operations and broadcasts and hence is no real solution.

Requested changes added.

could we please simplify this a little bit (remove redundant copies of the warning code, e.g., by moving it into SparkExecutionContext, remove the redundant setting of unlimited result size, and simplify the warning code, e.g., by using conf.get directly with defaults)

LGTM

Hi @asurve. Is this PR ready to be closed?