Typescript 4.4.2 breaks react-use

Version 4.4.2 of Typescript released on August 27th 2021 breaks react-use with:
node_modules/react-use/lib/usePermission.d.ts:1:54 - error TS2304: Cannot find name 'DevicePermissionDescriptor'.

1 declare type PermissionDesc = PermissionDescriptor | DevicePermissionDescriptor | MidiPermissionDescriptor | PushPermissionDescriptor;
                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-use/lib/usePermission.d.ts:1:83 - error TS2304: Cannot find name 'MidiPermissionDescriptor'.

1 declare type PermissionDesc = PermissionDescriptor | DevicePermissionDescriptor | MidiPermissionDescriptor | PushPermissionDescriptor;
                                                                                ~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/react-use/lib/usePermission.d.ts:1:110 - error TS2304: Cannot find name 'PushPermissionDescriptor'.

1 declare type PermissionDesc = PermissionDescriptor | DevicePermissionDescriptor | MidiPermissionDescriptor | PushPermissionDescriptor;
                                                                                ~~~~~~~~~~~~~~~~~~~~~~~~

All three:

DevicePermissionDescriptor
MidiPermissionDescriptor
PushPermissionDescriptor

seem to have moved to the [webworker lib]:(https://github.com/microsoft/TypeScript/blob/cec2fda9a53620dc545a2c4d7b0156446ab145b4/lib/lib.webworker.d.ts#L147)
The effect is that the build will break for anyone who uses react-use and runs yarn with a "Compatible with" typescript package of  ^4.0.0:
"typescript": "^4.0.0"

For now fixing typescript on 4.3.5 solves this.
Should the usePermissions hook be updated or should a lib definition be added to the tsconfig.json? I'm not sure.

Looks like a duplicate of #2056. Fixed in #2063 but not released yet.

Should be fixed in 17.3.0, please re-open if bug still presists.

Anyone else seeing this error with 17.3.0?
../../node_modules/react-use/lib/usePermission.d.ts(6,11): error TS2430: Interface 'IMidiPermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.

  Types of property 'name' are incompatible.

    Type '"midi"' is not assignable to type 'PermissionName'.

../../node_modules/react-use/lib/usePermission.d.ts(10,11): error TS2430: Interface 'IDevicePermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.

  Types of property 'name' are incompatible.

    Type '"camera" | "microphone" | "speaker"' is not assignable to type 'PermissionName'.

      Type '"camera"' is not assignable to type 'PermissionName'.

node_modules/.pnpm/react-use@17.3.1_react-dom@17.0.2+react@17.0.2/node_modules/react-use/lib/usePermission.d.ts:6:11 - error TS2430: Interface 'IMidiPermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.
  Types of property 'name' are incompatible.
    Type '"midi"' is not assignable to type 'PermissionName'.

6 interface IMidiPermissionDescriptor extends PermissionDescriptor {
            ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/react-use@17.3.1_react-dom@17.0.2+react@17.0.2/node_modules/react-use/lib/usePermission.d.ts:10:11 - error TS2430: Interface 'IDevicePermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.
  Types of property 'name' are incompatible.
    Type '"camera" | "microphone" | "speaker"' is not assignable to type 'PermissionName'.
      Type '"camera"' is not assignable to type 'PermissionName'.

10 interface IDevicePermissionDescriptor extends PermissionDescriptor {
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors.

I see this error with "react-use": "^17.3.1" and "typescript": "^4.3.2".

@fnick851 #2101

node_modules/.pnpm/react-use@17.3.1_react-dom@17.0.2+react@17.0.2/node_modules/react-use/lib/usePermission.d.ts:6:11 - error TS2430: Interface 'IMidiPermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.
  Types of property 'name' are incompatible.
    Type '"midi"' is not assignable to type 'PermissionName'.

6 interface IMidiPermissionDescriptor extends PermissionDescriptor {
            ~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/react-use@17.3.1_react-dom@17.0.2+react@17.0.2/node_modules/react-use/lib/usePermission.d.ts:10:11 - error TS2430: Interface 'IDevicePermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.
  Types of property 'name' are incompatible.
    Type '"camera" | "microphone" | "speaker"' is not assignable to type 'PermissionName'.
      Type '"camera"' is not assignable to type 'PermissionName'.

10 interface IDevicePermissionDescriptor extends PermissionDescriptor {
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors.

I see this error with "react-use": "^17.3.1" and "typescript": "^4.3.2".

I saw it in "typescript": "^4.3.5", and "react-use": "^17.3.1",
Interface 'IMidiPermissionDescriptor' incorrectly extends interface 'PermissionDescriptor'.
Types of property 'name' are incompatible.
Type '"midi"' is not assignable to type 'PermissionName'.  TS2430
4 |     userVisibleOnly?: boolean;
5 | }

6 | interface IMidiPermissionDescriptor extends PermissionDescriptor {
|           ^
7 |     name: 'midi';
8 |     sysex?: boolean;
9 | }

Same two errors here using<EMAIL_ADDRESS>&<EMAIL_ADDRESS>

it still fails for me at 17.3.0

Workaround (if NOT using usePermissions) is to import directly
- import { usePrevious } from 'react-use';
+ import usePrevious from 'react-use/lib/usePrevious';

still seeing this too with  17.3.1 and<EMAIL_ADDRESS>

Same here with with 17.3.1 and<EMAIL_ADDRESS>

still seeing this too with 17.3.2 and<EMAIL_ADDRESS>

still seeing this too with 17.3.2 and<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
Me too. Is there any fix ?

Workaround (if NOT using usePermissions) is to import directly
- import { usePrevious } from 'react-use';
+ import usePrevious from 'react-use/lib/usePrevious';

And yes, this should be re-opened since it's still an issue.

This solution works for me.


Issue regarding fixed radius contiguous

Top Point not being pref_top
        assert((*segment->get_top_point() == point) != prefer_top);
        assert((*segment->get_bottom_point() == point) != !prefer_top);

The first assert is false
Assertion failed: (*segment->get_top_point() == point) != prefer_top
file Trajectory_Hotspots\Trajectory_Hotspots\trapezoidal_map.cpp, line 1069

^^ error message
see attached files for original points (I nudged them Float::fixed_epsilon when they already exist)
points.txt

nudged-points.txt

^^ see above for nudged points (per request)


Ready for 15.

This commit literally changes and fixes everything. Sorry about that, release lockdown :)

Current coverage is 91.01% (diff: 100%)

No coverage report found for master at 8fa7764.

Powered by Codecov. Last update 8fa7764...393d6f5

Current coverage is 91.01% (diff: 100%)

No coverage report found for master at 8fa7764.

Powered by Codecov. Last update 8fa7764...7f77b28

WOW Current coverage is 91.01%


Make supported types protected instead of private

See #461 for details

Closing as per https://github.com/composer/installers/issues/461#issuecomment-740647299


Update dependencies in tox.ini

Feature Summary and Justification
This PR resolves VersionConflict Error (caused by mismatch of dependency section between setup.py and tox.ini) which is thrown when running tox.

Thanks! I don't actually use tox, so it's good to keep it updated periodically.


Fix release workflow

This PR:

Uses specific parameters where possible for package.json
Remove the working-directory parameter where possible

Please note that a version was not released yet.
I would recommend trying to create another bump version pr to see if the actions are behaving as expected.


TypeScript Support

Hey, I'm new to Fastify, TypeScript and even GitHub (this is my first issue ever). This might be a small TS issue, but it would be so much helpful if you could help me resolve it.
I installed your package and is importing it using ESM syntax (because I specified it both in the package.json and tsconfig.json, and if I use commonjs everything starts to break) and the compiler throws an error regarding the type declaration of the module.

Could not find a declaration file for module 'fastify-no-additional-properties'. 'server/node_modules/fastify-no-additional-propertie    s/index.js' implicitly has an 'any' type.
Try npm i --save-dev @types/fastify-no-additional-properties if it exists or add a new declaration (.d.ts) file containing declare module 'fastify-no-addition    al-properties';

And I couldn't find it via npm nor can write a .d.ts file myself. It would be really great if you could help. Thanks.

Just found out about @ts-ignore.
Closing the issue, Thanks anyways.

@mo-shaz I created types locally that you're welcome to add to your project.


chore: clean up TC inference implementation

This PR optimizes the type class search algorithm

We don't want trace messages to slow down type class search when trace is not enabled, so I made sure none of these computations are executed unnecessarily.
#4282

For any new goal, instantiateMVars (← inferType mvar) is computed at least twice in the current implementation. This is fixed.
#4284

When passing around metavariable contexts, the current implementation uses a lot of withMCtx, which is unnecessary. I fixed it so that each MetavarContext only needs to be set once at a time. Additionally, I removed the explicit returning of MetavarContext in tryResolve and tryAnswer, because these can instead be passed more naturally through the MetaM state. #4286

The trace messages for Meta.synthInstance.tryResolve and Meta.synthInstance.resume and the main/outer trace message have the problem that they have instantiated metavariables in their message that have been assigned during the tryResolve or the tryAnswer or instantiating outParams. In isDefEq the same problem arises (you want to see the unification problem before the unification has happened) and there it is solved using withTraceNodeBefore. This has also been fixed, using either withTraceNodeBefore, or an explicit withMCtx. - one of the tests shows this change.
#4285

mkTableKey has a redundant call to setMCtx, which I removed.
#4281

Calls to instantiateMVars in trace messages are redundant, so I removed them.
#4283

The unused function MapMetaM has been removed. #4287

The result is a noticeable improvement of TC search speed in Mathlib: 2.8%

Closing as per reasoning in #4379


flex-basis: 100% becomes 10%

css.txt
body {
	flex-basis: 100%;
}

When run through uglifycss:
> uglifycss css.txt
body{flex-basis:10%}

Thanks for your feedback


Debugging protractor test with patched function causes test to crash

VSCode Version: 1.20.0
OS Version: Windows 10 1709
Works as intended in VSCode Version 1.19.3
Extensions are disabled?: Yes
Node version: 8.9.4

bug.zip
The attached zip contains a project that the issue reproduces in. It's a minimal protractor-tsnode project with a single patched method. ts-node fails to find the patched method, and crashes under the debugger. Note that simply running the project with npm test works fine.
Steps to Reproduce:

Extract the attached zip file .
Do an npm install
Start debugging (F5)

Debugger crashes with protractor_1.browser.element(...).foo is not a function
trace:

      - Failed: protractor_1.browser.element(...).foo is not a function
          at Object.<anonymous> (C:\Users\~\Desktop\bug\index.ts:11:41)
          at step (C:\Users\~\Desktop\bug\index.ts:32:23)
          at Object.next (C:\Users\~\Desktop\bug\index.ts:13:53)
          at C:\Users\~\Desktop\bug\index.ts:7:71
          at new Promise (<anonymous>)
          at __awaiter (C:\Users\~\Desktop\bug\index.ts:3:12)
          at UserContext.<anonymous> (C:\Users\~\Desktop\bug\index.ts:6:16)
          at new Promise (<anonymous>)
          at SimpleScheduler.promise (c:\Users\~\Desktop\bug\node_modules\selenium-webdriver\lib\promise.js:2242:12)
      From asynchronous test:
      Error
          at Suite.<anonymous> (C:\Users\~\Desktop\bug\index.ts:6:5)
          at Object.<anonymous> (C:\Users\~\Desktop\bug\index.ts:5:1)
          at Module._compile (module.js:643:30)
          at Module.m._compile (C:\Users\~\Desktop\bug\node_modules\ts-node\src\index.ts:422:23)
          at Module._extensions..js (module.js:654:10)
          at Object.require.extensions.(anonymous function) [as .ts] (C:\Users\~\Desktop\bug\node_modules\ts-node\src\index.ts:425:12)

@gawicks sorry, but from the stacktrace it appears that not the Debugger is crashing but your test.
What version of node.js are you using?

@weinand I'm on node 8.9.4. Yes you're right that its the test that crashes under the debugger. Sorry i could not make the proper distinction here.
The attached zip can help you re-create the issue. Let me know if you need more info.

I can reproduce the problem only on Windows.
If I remove the ${workspaceRoot}/ from the "conf.js" the test works fine.
    {
        "type": "node",
         "request": "launch",
         "name": "Launch Program",
         "program": "${workspaceRoot}/node_modules/protractor/bin/protractor",
         "args": ["conf.js"],
         "sourceMaps": true,
         "preLaunchTask": "npm: update"
    }

@gawicks does the test work for you as well?

Thanks for the quick response. I can confirm that this works.

I'm happy with this workaround. But should I leave this bug open for you to investigate the regression?

Yes, leave it open. @roblourens should decide.

@weinand Thanks.

I think that @weinand's suggestion is the correct fix. If protractor doesn't like an absolute path here, the debugger can't do anything about that.

@roblourens Any explanation as to why this reproduces only on windows and on >v1.19.3 ? Perhaps there is a path related change that's causing this to break.

No, but that seems unlikely, vscode is just running the command as provided. It might break outside of the debugger if you just run the same command in the terminal.

No it doesn't .
Running node node_modules\protractor\bin\protractor C:\Users\~\Desktop\bug\conf.js (Absolute path) works fine. It's running under the debugger that's causing this.
Also let me re-iterate that this used to work fine before the new release.

I spent some time trying it, and this is pretty weird. It works fine in the terminal, and you can also work around it with "console": "integratedTerminal". But it fails when the debug adapter spawns the process, whether it's in debug mode or not.
The difference between 1.19 and 1.20 is just the casing of the drive letter - ${workspaceRoot} completed with a lowercase letter in 1.19 and uppercase in 1.20. So it works fine if I write in the absolute path with a lowercase letter in args. And it works in the terminal regardless of the path casing.
I wonder whether the command prompt in Windows does anything to normalize paths? I didn't think so but that would explain this.

Is this still an issue? Given my last comment, I'm not sure what we would do to work around this on our end. We aren't going to give a certain drive letter casing just for this library, so I think it will have to be fixed on their end.


Eslint this project.

[ ] Consistent double quotes.
[ ] ... anything else?

Done: 4768bbf4f3c78e8159674863c91aa36bbd7202aa


feat: Add persistent store

Adds persistent store using tauri-plugin-store.
For now, it's only used to store the selected release canal.

Also, I think we need a readme part where we explain difference between different application stores

Also, I think we need a readme part where we explain difference between different application stores

Where should we put it? Add it to the one in src-vue? Cause the readme in repo root is too end-user facing IMO ^^

Well, GitHub is a development platform after all :)
We could put it under the Development section.


Question: when doing chao init, it stuck at defining an experimental method

I use chaostoolkit-kubernetes
when doing chao init, it stuck at defining an experimental method like this:

what should I press to choose this? I see docs about chaos init, but that  is not the same as above.

Hello,
I think discover and init need a solid clean up indeed. Let me try to see if I run into the same problem.
Thanks

Okay, indeed, I have the same behavior.
When the list is shown, remember the number you are interested in and press 'q'. This will leave the menu selection and back to the main menu.
let me if that helps.

Okay, indeed, I have the same behavior.
When the list is shown, remember the number you are interested in and press 'q'. This will leave the menu selection and back to the main menu.
let me if that helps.

it works！thanks
I have another one question：written “press return to use or not set any value” above, but  I press return, it let me input again！

by the way,  tutorials and videos in https://docs.chaostoolkit.org seems too old, making beginner a little confused.
Hope to see new tutorials later

Hey @lcwus2, let's move this to https://github.com/chaostoolkit/chaostoolkit/issues/131 (that you opened) as it's a CLI/docs question, not one about this extension.


Error no game start with hunter enabled

https://i.imgur.com/sQ0bqTK.png

The amount of prices you have in the hunter upgrade has to be the same as the number of tiers for monster samples.

main price: 800
following: 400, 600, 800, 1000
sample string: Hoarding Bug-Centipede, Crawler-Bunker Spider, Baboon Hawk, MouthDog, Flowerman
i dont see no issue with my config yet i get the error

you have 5 prices (base plus 4 for upgrades) but only 3 monster tiers

I thought commas seperated them, fuck.
Please just add a warning for mismatching arguments. ^^


fix(teams): display team members

https://user-images.githubusercontent.com/71545960/195389003-0c60fd07-fb4e-430b-ae42-c67bdae484fd.mp4

@giseleblair @bltarkany


feat: Add pub verify_pub_keys(), verify_keyless_exact_match()

Description

Fix https://github.com/kubewarden/policy-server/issues/99
Supersedes https://github.com/kubewarden/policy-fetcher/pull/77

Add pub functions verify_pub_keys(), verify_keyless_exact_match(). These are shims that translate to an interim VerificationConfig and call verify(), so only 1 codepath exists, no need for tests.
re-export kubewarden_policy_sdk through policy-fetcher for consumption.
Minor refactors and error checking.

I suggest "files-changed" review, given the hard refactors.
TODO: depends on rust sdk work.

Ok, I looked into the PR and I understand your comment. I didn't expect the code to reuse the verification primitives of policy-fetcher. Given the limited API offered to the end user, I was expecting to see something written on top of "pure sigstore", plus some little duplicated code. I understand why you went this way.
At the same time, I think it's just a bit strange to me to have the policy-sdk requirement be moved from policy-evaluator to policy-fetcher. Moreover it's strange for me to look for the implementation details of an exposed callback function not into policy-evaluator, but policy-fetcher.
I also think it would be annoying to implement fixes to the verification APIs, because would have to touch policy-fetcher and then policy-evaluator.
Being pragmatic, for the end user there's no difference. This is definitely a matter of personal taste. I'm fine leaving the code as it currently is. We can always change that in the future without breaking user policies.

We are sharing some code with the policy validation such as FulcioAndRekorData and cosign client creation in Verifier. We could move the two methods verify_pub_keys() and  verify_keyless_exact_match() to the evaluator and still reuse the verify code in the Verifier.
However,  I think it conceptually makes more sense to have all verify functions together in the Verifier struct in policy-fetcher. This would help with refactors or changes in VerificationConfig as @viccuad pointed out.

Still, now we don't need to re-export the SDK through policy-fetcher, nor consume it in evaluator.

@viccuad we still needed here for the CallbackRequestType, KeylessInfo and VerificationResponse

Rebased main, and consumed policy-sdk-rust from Raúl's branch, of the other PR, for now.


[C++] Pass std::string_view by value, not by const-ref

Describe the enhancement requested
See https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/
Component(s)
C++

Hi, I would like to contribute in this

@madhavarora03 You can, feel free to submit a PR!


PR: Mock HELP3O on rtd to fix technical documentation

The technical documentation on RTD is currently not building because of an import error with the module HELP3O.

Hello @jnsebgosselin! Thanks for submitting the PR.

There are no PEP8 issues in the file docs/conf.py !


[Bug/fix] Wire entities to not work when toolgun antispam is enabled

IF "enable toolgun antispam" in antispam options is enabled. Mostly all wire entities fail to work (This includes exploression2.
I did work up a very simple fix which involves editing the sh_hooks.lua file in lua/dpp.
On line 126 I changed debug.getlocal(i, 1) to debug.getlocal(1, i).
This fixes the issue.
My experience with glua is very minor. So please check this.

I added that because wire calls CanTool twice. It tries to detect whatever CanTool was actually called by a toolgun. Will look into that again

Will make chack whatever CanTool was called with WireLib.DummyTrace()

Also you changed debug.getlocal(i, 1) to debug.getlocal(1, i), in case of that, Should would never be true, because of that, no toolgun antispam at all


Added simple reproducible docker_build rule for ubuntu

I have added bash as the entrypoint.  Running the built image appears to work, output below:
$ docker run -it bazel/repro
ducible:ubuntu
root@19145f907b58:/# ls
bin  boot  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
root@19145f907b58:/# ls
bin  boot  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
root@19145f907b58:/# ps aux
USER        PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root          1  0.4  0.0  18236  3260 ?        Ss   20:05   0:00 bash
root         13  0.0  0.0  34420  2864 ?        R+   20:05   0:00 ps aux
root@19145f907b58:/# exit
exit

Have templated structure_test concept in the PR but it is not working currently.  If I run the tests "manually" they work but I am getting the following error running structure_test:
$ bazel run :ubuntu_test
WARNING: /usr/local/google/home/aprindle/.cache/bazel/_bazel_aprindle/94ea7a73245e96603bcb84b183083fc5/external/bazel_tools/t
ools/build_defs/pkg/pkg.bzl:196:9: pkg_tar: renaming non-dict `files` attribute to `srcs`.
INFO: Found 1 target...
Target //reproducible:ubuntu_test up-to-date:
  bazel-bin/reproducible/ubuntu_test
INFO: Elapsed time: 0.196s, Critical Path: 0.00s

INFO: Running command line: bazel-bin/reproducible/ubuntu_test
+ reproducible/ubuntu

cat: reproducible/ubuntu.runfiles/debian_docker/reproducible/ubuntu-layer.tar.sha256: No such file or directory
cat: reproducible/ubuntu.runfiles/debian_docker/reproducible/ubuntu.config: No such file or directory
No JSON object could be decoded
reproducible/ubuntu: line 121: TOTAL_DIFF_IDS[@]: unbound variable
cat: reproducible/ubuntu.runfiles/debian_docker/reproducible/ubuntu-layer.tar.sha256: No such file or directory
Error response from daemon: open /usr/local/google/docker/tmp/docker-import-008956528/sha256:: no such file or directory
cat: reproducible/ubuntu.runfiles/debian_docker/reproducible/ubuntu-layer.tar.sha256: No such file or directory
cp: cannot stat ‘reproducible/ubuntu.runfiles/debian_docker/reproducible/ubuntu.config’: No such file or directory
ERROR: Non-zero return code '1' from command: Process exited with status 1.

structure_tests added correctly, should work for travis now.  Ready for review

I got this confused in the debian image, see https://github.com/GoogleCloudPlatform/debian-docker/pull/99 for the correct way to set path and command.

done: changed env/path to be inline with #99

Yeah, the schema version needs to be 2, but I need to get in the bazel version of structure tests before that will work.
Or it could be 1, and be written in that schema.

I have a PR open against runtimes common to make it work. Once that goes in you should be good.

The test is failing as it cannot find /etc/os-release.  This is strange though as if I run the image in docker I am able to see the file /etc/os-release
$ cat   /usr/local/google/home/aprindle/.cache/bazel/_bazel_aprindle/94ea7a73245e96603bcb84b183083fc5/execroot/debian_docker/bazel-out/local-fastbuild/testlogs/reproducible/ubuntu_test/test.log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
-----------------------------------------------------------------------------
+ reproducible/ubuntu
Loaded image ID: sha256:43090ab88adcaf7291776e346dafb23f6467aa42ea3e5aecead1a610dd9b90d4
Tagging 43090ab88adcaf7291776e346dafb23f6467aa42ea3e5aecead1a610dd9b90d4 as bazel/reproducible:ubuntu
++ pwd
+ ../runtimes_common/structure_tests/go_default_test -image bazel/reproducible:ubuntu /usr/local/google/home/aprindle/.cache/
bazel/_bazel_aprindle/94ea7a73245e96603bcb84b183083fc5/bazel-sandbox/8780106472488050902/execroot/debian_docker/bazel-out/loc
al-fastbuild/bin/reproducible/ubuntu_test.runfiles/debian_docker/tests/ubuntu_test.yaml
Using driver docker
2017/10/10 23:05:05 Running tests for file /usr/local/google/home/aprindle/.cache/bazel/_bazel_aprindle/94ea7a73245e96603bcb8
4b183083fc5/bazel-sandbox/8780106472488050902/execroot/debian_docker/bazel-out/local-fastbuild/bin/reproducible/ubuntu_test.r
unfiles/debian_docker/tests/ubuntu_test.yaml
--- FAIL: TestAll (1.35s)
    --- FAIL: TestAll/File_Content_Test:_Ubuntu_Distro_Check (0.10s)
        structure.go:120: Failed to open /etc/os-release. Error: File /etc/os-release not found in image
        utils.go:29: Expected string .*Ubuntu.* not found in file contents!
        structure_test.go:46: Total tests run: 3
FAIL

$ docker run -it bazel/reproducible:ubuntu
root@0a8a3f56bd2c:/# cat /etc/os-release
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial
root@0a8a3f56bd2c:/#

Unsure how to debug this inside of structure_test.  I have removed the /etc/os-release test for now and with that test removed it is passing.  /etc/os-release does exist in the image but somehow structure_test is not finding it.

LGTM, let's get this in and fix the test later.


stops running if wrong css entered

NPM version (npm -v):  5.3.0
Node version (node -v): 8.2.1
Node Process (node -p process.versions):
{ http_parser: '2.7.0',
node: '8.2.1',
v8: '5.8.283.41',
uv: '1.13.1',
zlib: '1.2.11',
ares: '1.10.1-DEV',
modules: '57',
openssl: '1.0.2l',
icu: '59.1',
unicode: '9.0',
cldr: '31.0.1',
tz: '2017b' }
Node Platform (node -p process.platform): win32
Node architecture (node -p process.arch): x64
node-sass version (node -p "require('node-sass').info"):
node-sass       4.5.3   (Wrapper)       [JavaScript]
libsass         3.5.0.beta.2    (Sass Compiler) [C/C++]
npm node-sass versions (npm ls node-sass):

node-sass stops if an error found in css
i am using vs code, and try to run node-sass to compile .scss file to .css file
what i tried
node-sass scss/main.scss assets/css/main.css --quiet --watch
error
/npm/node-sass: line 14:  3472 Segmentation fault      node "$basedir/node_modules/node-sass/b
in/node-sass" "$@"

{
  "status": 3,
  "message": "File to read not found or unreadable: D:/MAMP/htdocs/wp/wp-content/themes/re/scss/main.scss",
  "formatted": "Internal Error: File to read not found or unreadable: D:/MAMP/htdocs/wp/wp-content/themes/re/scss/main.scss\n"
}

node-sass-chokidar is a pretty good workaround for this.

This is interesting.
File to read not found or unreadable: D:/MAMP/htdocs/wp/wp-content/themes/re/scss/main.scss

Suggests the scss file doesn't exists at the location you've supplied.
/npm/node-sass: line 14:  3472 Segmentation fault      node "$basedir/node_modules/node-sass/b
in/node-sass" "$@"`

Suggests something in the file is invalid and causing LibSass (the engine node-sass uses) to crash. This may be what's causing node-sass to thing the file doesn't exists, or LibSass could be crashing because the file doesn't exist.
Can you please

confirm D:/MAMP/htdocs/wp/wp-content/themes/re/scss/main.scss exists at that location
if so, please create a gist.github.com with the file contents so we can see why it's crashing LibSass


React Native library

Hey @sasza2 how long!
I was wondering if this panzoom core abstraction can be used to build a React Native version of React Panzoom.
That would be great. What do you think?

hi! hmmm, I will check it


[FEATURE] PTO support

Requested Feature
Power Take Off support in the Chassis class

Should be able to dynamically switch motors from other subsystems to the chassis
The extra motors should be included in odometry calculations (if using motor encoder odometry)

Current Implementation
It is not possible to do this.
Motivation
PTOs are becoming increasingly common, and users should be able to make use of them when using LemLib

Assigned to Rocky :)

Waiting on PROS 4 release. It will add the ability to add and remove motors from motor groups, making PTO implementation very simple.

@Rocky14683 PROS 4 is out and used in the refactor right?

PROS 4 is not used in the refactor

Pros 4 is used in the refactor
On Wed, Nov 29, 2023 at 12:45 PM Exortions @.***> wrote:

PROS 4 is not used in the refactor
—
Reply to this email directly, view it on GitHub
https://github.com/LemLib/LemLib/issues/36#issuecomment-1832673559, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A2SQ3WNPCNQVX3QZOBJYYELYG6NFLAVCNFSM6AAAAAAXTGY6BWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZSGY3TGNJVHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

oh my bad, i thought it was still on 3

I should be able to do this during/after exams next week.


Consider putting multiple resources into one single heatmap?

This picture is from douban, which put books, movies and music into one single heatmap with different colors.

So I am thinking that we can put twitter, github, leetcode into one heatmap like this, then from the colors, you would get an idea about where does your time spend on.

Cool.
I'll try to see if I can achieve it, later~

@laixintao
Seems max() resources support up to 3 maybe better.

Done.


Refactor @once logic out of DAG class

Test two. What is I request against master?

Seems to work!


Fill in missing global run config options

This extends the global Run config to match the file-level one.

Results in:

Hi Steve, question,: are the options in both dialog hard coded? If yes would it be possible to reuse the dialog content inside the file level dialog to the one in the config one?, in order to keep things DRY?

@goanpeca, they are hand coded in two places.   I did not see a way to reuse the Editor plugin code in the Preferences Page because the preferences page uses the helper methods to create the widgets and register the config/callbacks.  There could be work done in the future to make Plugins and Preference Panels play better together.

@blink1073 True!, ok I will test this tomorrow :)

BTW thanks for doing this, I've wanted to be able to set those options as default for a while now, but never got around to fixing it myself.

@Eric89GXL, my pleasure.

Other than my minor comments, I think this is ok.
@blink1073 do you have something to say about the question @goanpeca asked in the first comment?

@ccordoba12, I did address his comment (I believe), in the comment following his.

@ccordoba12, @blink1073 did address the comment, for the moment should be good to go, but it really raises the issue of making different parts inside Spyder reusable.
I have some ideas for this, some refactoring would be needed so that we can have the GUI defined as dics with the info of the widget (organization) and set the defaults and signals (as another dic maybe...) so that the GUI elements could be completely recycled without having to code by hand (in different ways...) in two or more places. Or we could start using *.ui files to define this reusable components inside Spyder.
Opinions?

@goanpeca, we have formlayout which creates a GUI based on dicts, so you could start from there.

@blink1073, I will take a look, but  I think it may be worth using QtDesigner and ui files as well, instead of our own baked solution.

@goanpeca, I am personally not a fan of QtDesigner.

@goanpeca, I don't like QtDesigner either. Having our code as pure Python makes it really easy to hack on it.

@ccordoba12 , @blink1073 , I understand :), I am myself not a super fan :p. I will look to what Steven suggests and think of something to allow us reuse GUI components more easily.

@blink1073, is this ready to merge?

Fire away!

Am I the only one to like QtDesigner ? It's very good to quickly build interfaces. But it's very bad at handling lots of custom widgets. :( Btw you can load *.ui files from python without converting them first, and it works as well with both PySide and PyQt. Anyway it makes no sense to switch at this state of the project.
@goanpeca I think that in this case using the DRY principle would do more harm than good. The preferences uses the stadard way of setting global options, and the run dialog doesn't have to use it. If every panel was duplicated we would have to reuse more, but that's just one...

@Nodd I am not a fan of designer but I do not dislike it ;-)
This is maybe a first case, but if a second case shows up... or a third.. well maybe we will have to come back to this one.
The standard way of building stuff for the preferences dialog is not that appealing to me, I know the idea is to have helper functions to add all widgets but at the end it feels that structure is too rigid....

This seems good, merging.


Wrong terminal state at the end of the episode (DDPG, TD3)

After trying DDPG and TD3 on various environments, we find out that the terminal state at the end of the episode is overwritten by the state of the new starting episode. Was this done on purpose ? Will it affect the performance of the model ? or it's just a bug.

P.S: The image represents the replay buffer of 'Pendulum-v0' from Gym.

Duplicate of #400 (and it is in the doc)


Migrate the core-tck-runner for Jakarta EE 11 Core Profile.

@jamezp I have updated the https://github.com/jakartaee/platform-tck/tree/main/core-profile-tck for EE 11. Can you re-verify this against that?

@starksm64 running now

I think I've addressed all the comments and hopefully it's a little more clear now.

There is an 11.0.0.M1 release candidate of the CDI EE TCK in the staged area:
https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee11/staged/eftl/cdi-ee-tck-11.0.0.M1-dist.zip
The artifact has also been staged to the repo and released to maven central using the GAV
jakarta.tck:cdi-ee-tck-dist:11.0.0.M1

Excellent. I'll file an issue and give it a test for the upgrade.


Feat/multiple currency supported

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

73 of 171 (42.69%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 29.574%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/core/ledger.rs
21
25
84.0%

src/core/utils/latest_map.rs
12
16
75.0%

src/core/utils/price_grip.rs
0
8
0.0%

src/core/process.rs
40
122
32.79%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
417

Relevant Lines:
1410

💛  - Coveralls


Jazzy harmonic devel

Attempt to take humble devel and make it run on jazzy using gz-harmonic.
not everything as i like yet, but maybe worth a branch

Hey @Kaiser1401,
Oh wow, I am impressed that someone actually attempted this. Thanks a lot for your effort and for making it public via this PR.
I have not used this repository for quite some time, and I am busy with other things, so I won't have time to try it anytime soon. But I can merge it into a new branch whenever you think it is ready-ish.
Also — by any chance, have you checked if there are any "official" alternatives available by now? This repository was quickly put together when I needed it several years ago, but I hope/thought there would be proper support by now.
Thanks again!

I have mainly looked around for a working example combining GazeboSim, Ros2 and a manipulator arm interacting with something and so far this seemed to be the best starting point :D
I have seen the comment that moveIt now has it's own python api but have not checked it yet.
I'm fairly new to ROS2, GZ and MoveIt (but have quite som experienc from ROS1) so this is a bit my starting point. While somehting running would have been ideal to use it, fixing things also seems to teach me quite a bit.
I'll probably have accompanying changes for the ign_moveit2__examples pkg. I'll let you know when I think it's runnable.

This basically should work, not everything tidied up.


Only Let a Security Group Use the Buttons

It would be awesome if just some group(s) or user could be able to use the buttons. That way I would guarantee only the right people would do the action I want, like approving a change on my system.

When I published this extension, I couldnt find any rest apis for doing membership checks. But now there are rest apis available so I can look into it. I'm planning to work on a v2 of the extension sometime next month. Will add this feature then

Has this been implemented?  It would help to be able to designate a security group that allowed updates to the settings or creation of new rules as well.


Dockerfile error

Hey i just wanted to test ur flik code but:
$docker-compose run flik
Building flik
Step 1/8 : FROM python:2-alpine
 ---> 037e005d160a
Step 2/8 : RUN apk add py2-cryptography
 ---> Running in d1108f4ef064
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
ERROR: unsatisfiable constraints:
  py2-cryptography (missing):
    required by: world[py2-cryptography]
ERROR: Service 'flik' failed to build: The command '/bin/sh -c apk add py2-cryptography' returned a non-zero code: 1
$

regards

seems, i haven't updated that for a while - should be working now
also, there's currently a little bug with calender week using the wrong number (see #11 ) - haven't fixed that yet


[Existing API Name] : Brewery API

Brief Description 🤓
This API enables users to:

Fetch detailed information about breweries, including their name, type, city, state, country, phone, and website URL.
Discover a random brewery every time the "Random Brewery" button is clicked.
Provide a simple and easy-to-use interface for an intuitive user experience.
Search for breweries by selecting a state from the dropdown list.

Provide reference!
https://www.openbrewerydb.org/
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @atul2727🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24

Hey @atul2727 ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Figures not correctly close

When doing a lot of tests, the following error appears:
Figures created through the pyplot interface (`matplotlib.pyplot.figure`) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam `figure.max_open_warning`). Consider using `matplotlib.pyplot.close()`.
  fig1, ax1 = plt.subplots(figsize=(5, 5), dpi=100)

This means that plots are not correctly destroyed.

fixed in commit [824ba1b](https://github.com/UnePatate5010/GUI-White-Black-Box-Models-Mix/commit/824ba1b85aa1dadc67623dbb63ca99acf5a33219). It should come soon to the main branch.


Label leaking of thread metrics

Bug Report
Here we buffered all labels (thread IDs), then labels can not be dropped even if threads have been exited.
https://github.com/tikv/tikv/blob/13db52e63a746f546cdf6fa3c779378f228d907c/components/tikv_util/src/metrics/threads_linux.rs#L25-L40

/found customer


Added Iconizer

Project URL
https://github.com/liamrosenfeld/Iconizer
Category
Development > iOS / macOS
Description
Added the Iconizer app
Why it should be included to Awesome macOS open source applications  (optional)
It's a handy resource that can save people a lot of time
Checklist

[x] Addition in chronological order (bottom of category)
[x] Only one project/change is in this pull request
[x] Appropriate language icon(s) added if applicable
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

Since the title of the app may soon change I'll withhold this pr until renaming is complete.


Set specific tab active dynamically

I'm creating my tabs dynamically and I wanted a way to set a specific tab after creation to be the active tab.
I have access to the tabs but can't find a function to do this.
I tried the following:
tab.yasqe.focus();
tab.yasqe.setSelection();
instance.tabElements._selectedTab = 'new id....'

Is there a simple way to set the active tab dynamically after tabs have been created ?

Found it in the code. Just wanted to update the ticket for others.
instance.tabElements.selectTab(id);

Had to reopen this.
After setting the selectTab with the code above, I log the active tab and I get queryingDisabled = true ( which is good because I set the tab to be disabled when creating it ) but the query button is not showing as disabled until I physically click the active tab then it shows as disabled.
Is there a refresh method I need to call other than yasqe.refresh(); ?


python3Packages.jaxlibWithCuda build failure on x86_64-linux as of 8617a5a3

Issue description
Build of python3Packages.jaxlibWithCuda failed on x86_64-linux as of 8617a5a33639312c7ee59729d13d2ad586b1f67f.
build log
Maintainer cc: @ndl
Other cc: n/a
Steps to reproduce

Checkout nixpkgs at commit 8617a5a33639312c7ee59729d13d2ad586b1f67f
Run nix-build -A python3Packages.jaxlibWithCuda

Technical details
- system: `"x86_64-linux"`
 - host os: `Linux 5.11.0-1028-azure, Ubuntu, 20.04.3 LTS (Focal Fossa)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.6.0`
 - nixpkgs: `/nix/store/f78jqkss0z39h2602xrrigzy6g1skpv6-source`

Misc.
This issue was automatically generated by nixpkgs-upkeep.

CI workflow that created this issue.
Internal tag:<PHONE_NUMBER>638307047

error: unable to download 'https://ploop.cachix.org/nar/483eec346f5248f5c300c9bc91e5a9cae2a5248adc20411217f14988a1f2ce01.nar.xz': HTTP error 200 ('') (curl error: Stream error in the HTTP/2 framing layer)
error: some substitutes for the outputs of derivation '/nix/store/z1z9m052vd3qgmpic432170w58lmskz0-python3.9-jaxlib-0.1.75.drv' failed (usually happens due to networking issues); try '--fallback' to build derivation from source

looks like a network failure. superseded by https://github.com/NixOS/nixpkgs/pull/159099 anyways


convert column name format during migration

Hi,
In Bookshelf, I see that it's possible to override parse() and format() if you want to convert from snake_case to camelCase and vice-versa when fetching or saving. Is there a similar method to do so in Knex? I'm running migrations where my table columns are snake_case, but I'm passing in an object where the properties are camelCase. I do realize that I can just change the property names to snake_case by wrapping it in quotes, but was hoping for something that I may override as can be done in Bookshelf.
Thank you!
James

:+1:

There is currently no support for this in knex. Since there are already wrapping methods for column identifiers it might even be quite easy to implement in a way that it would work everywhere, in queries etc.
Though I'm not sure if this would be out of scope... To me I don't mind having that feature. Actually it would be pretty useful also for our project, which is based on knex.

Is there a better solution to this yet, other than manually transforming the object properties between camel and snake case every time? I'm using ES6 classes to model my tables and everything would work beautifully but for this.

@prashaantt no there is currently no other way and it gets even more nasty than just converting them before inserting and after fetching rows. You would also need to convert all the column names passed to query's where clause.
We ended up just using camelCase column names in our DB.

We ended up just using camelCase column names in our DB.

So I suppose now you quote all your column names when writing raw SQL queries, right? Have you found it to be a fair compromise for most practical purposes?

Knex does quoting itself e.g. knex.raw('?? > ?', ['MyTable.myCol', 1])

Yes, raw SQL in the psql CLI is what I meant. Thanks for your insight.

Closing in favor of #2084 which has some suggestion for initial implementation.

Hi all, sorry to plug but I'm working on an ORM for knex which resolves this issue, PTAL https://github.com/joelmukuthu/knorm

@joelmukuthu looks like it wraps pretty big part of knex API and limits it to use only .where({ obj.. }) style of queries. Does it allow using raw() at all?

@elhigu yeah, it wasn't fun to do that. it could also support raw() but i'd need to wrap it as well. i might have missed it, but is there a low-level method in knex's query builder that i can call or override to transform field-names to column-names (and vice-versa when data comes back from the database)?

I just implemented hook for postProsessingResults read from DB docs are found here https://github.com/knex/documentation/pull/58

@elhigu awesome, thank you! I'll try out the new hooks and provide some feedback, hopefully before 0.14 is out


WIP: Mod docs refactor

@tradej @inoxx03 leaving this WIP until #743 and #744 are merged.  I would look at this by commit for a review perspective.
@Ladicek FYI, this has been a refactor with some very light editing.

I quickly ran through and didn't find anything wrong. LGTM.

As an aside, I'd also recommend considering changing the line 23 in docs/topics/proc_deploying-the-configmap-booster-using-the-oc-cli-client.adoc from
ifdef::configmap-vertx,configmap-spring-boot-tomcat,configmap-nodejs[]

to
ifndef:configmap-wf-swarm[]

for brevity.

@tradej @inoxx03 rebased and cleaned up. Please take a quick look

@tradej refactored, let me know what you think

One more thing, if I may: Please include the following comment in files that use any of the parameter-$SOMETHING attributes:
// This is a parameterized module. Parameters used:
//
//   parameter-$SOMETHING: $DESCRIPTION_OF_THE_PARAMETER
//   parameter-$SOMETHING_ELSE: ...
//
// Rationale: $YOUR_RATIONALE

Thank you.

@tradej fixed per feedback

Thank you, I'll merge it.

merged: cbeed16da


Added Russian translation...

Added Russian language for the program, please add -> LINK
I think you know what you need to put along this path: res/values-ru
Thank!

Please add.... please


Invite users to team

User Story: https://github.com/ContestSubmission/Documentation/issues/14
To avoid having to store invite codes and stuff in the database, JWTs can be used.
Concept

team member invites user in UI
jwt creation containing the user id
e-mail is sent to invited user
link in mail contains JWT
backend verifies JWT & adds the user to the stored team

References

https://quarkus.io/guides/security-jwt-build
https://quarkus.io/guides/security-jwt#examine-the-jakarta-rest-resource

Closed by the linked commit


Check pieces before sending to other peers in swarm

The issue here is that whenever acceptSignedPost is changed to become stricter the old posts (which have been previously accepted into torrents) may fail to pass in the new test. This causes peers to become massively banned by other peers because they try to send invalid pieces.

@Erkan-Yilmaz not related. in fact you noticed a limitation: you cannot RT a promoted post ;-)

the same issue for the favorite posts?
I saw this error also on trying to retwist some posts on the profile review.


performance: reduce the # of open file handles

Installing thousands of bundles within a process can cause undefined behavior if the OS open file limit has been reached. In our use case, we reached this open file limit on Windows.
In order to resolve the issue on Windows and to allow thousands of bundles to be installed into an applications, this solution will close the file handle for the bundle if it only contains a manifest file. The idea is that with only a manifest.json file, clients are unlikely to use another CppMicroServices resource API to read meta-data from the .zip file. If the resource API is used after the bundle is installed, the file will remain open until the bundle is uninstalled.
There are most likely more improvements that can be made to manage the # of file handles CppMicroServices keeps open and this is a small step towards getting to that state.

Codecov Report

Merging #298 into development will increase coverage by 0.01%.
The diff coverage is 87.17%.

@@               Coverage Diff               @@
##           development     #298      +/-   ##
===============================================
+ Coverage        84.21%   84.23%   +0.01%
===============================================
  Files               94       94
  Lines             6539     6577      +38
===============================================
+ Hits              5507     5540      +33
- Misses            1032     1037       +5

Impacted Files
Coverage Δ

framework/src/bundle/BundleArchive.cpp
95.23% <ø> (ø)
:arrow_up:

framework/src/bundle/BundleStorageMemory.cpp
91.66% <ø> (ø)
:arrow_up:

framework/src/bundle/BundleStorageFile.cpp
0% <ø> (ø)
:arrow_up:

framework/src/bundle/BundleStorage.h
100% <ø> (ø)
:arrow_up:

framework/src/bundle/BundleResourceContainer.h
100% <ø> (ø)
:arrow_up:

framework/src/bundle/BundlePrivate.cpp
80.25% <100%> (+0.08%)
:arrow_up:

framework/src/bundle/BundleResourceContainer.cpp
92.5% <80.95%> (-2.5%)
:arrow_down:

framework/src/util/Utils.cpp
70.52% <93.75%> (+4.7%)
:arrow_up:

@CppMicroServices/developers please review as soon as possible. I'd like to submit this within a couple weeks if there are no significant issues. Thanks!

@saschazelzer we did have a conversation about opening / closing the bundle resource container on demand in issue #299.
I will re-factor PR #306 once this PR is merged into development.

@jeffdiclemente Thanks for pointing this out. What is the strategy then? Are you currently looking into changing how the resource container manages file handles or do you rather want to merge this now as is and go ahead with PR #306 ?

@saschazelzer I'd like to merge this PR now and I'll create a follow up issue to change how the resource container manages file handles.

@saschazelzer I'd like to merge this PR now and I'll create a follow up issue to change how the resource container manages file handles.

@jeffdiclemente Sounds good to me.


[PE-D][Tester D] Name cannot be updated despite it only containing alphanumeric

Inputting a long name does not allow the person to be updated despite the name only containing alphanumeric characters and spaces.
Steps to reproduce:

Input ‘update 1 n/Prabhakarna Sriparawardana Attapattu Jayasuriya Laxmana Sivaramakrishna Shivavenkata Rajashekhara Srinivasna Trichipalli Yekyaparampil Perambdur Chinnaswami Muttuswami Venugopal Iyer’

Expected: Able to update patient details (name)
Actual: Error message that "Names should only contain alphanumeric characters and spaces, and it should not be blank" although name only contains alphanumeric charactes and spaces.

Labels: severity.Medium type.FunctionalityBug
original: yuanchengg/ped#12

There is a hidden unicode in your string which is detected by the regex. Once removed, the patient's details can be updated
update 1 n/Prabhakarna Sriparawardana Attapattu Jayasuriya Laxmana Sivaramakrishna Shivavenkata Rajashekhara Srinivasna Trichipalli Yekyaparampil Perambdur Chinnaswami Muttuswami Venugopal Iyer


Provide ipfs command line tools on install

Atom.app provides the apm command when it is installed, as do many other apps. It would be rad if installing IPFS Desktop added the ipfs command to your PATH if it's not already present.
We already bundle the binaries, so it's just a matter of figuring out how to make them available.

Can you tackle this next... it'd really help us with the "easy install" story for https://github.com/ipfs/website/pull/299

Some notes from IRC about PATH on Linux:
Symlinking to /usr/local/bin is possible only during install
After install ipfs-desktop runs under non-root user and cant write to /usr/local/
$ ln -s ./ipfs /usr/local/bin/ipfs
ln: failed to create symbolic link '/usr/local/bin/ipfs': Permission denied

That being said, we should be fine with symlinking to /usr/local/bin/ipfs during install on Linux. Symlink may conflict with plain go-ipfs package, but if desktop user wants to run a different version of go-ipfs than one shipped with ipfs-desktop, they can do it either by  docker run --rm -it --net=host ipfs/go-ipfs:v0.4.18 or pointing at remote node via ~/.ipfs/api
Adding ipfs binary to PATH needs to account for  shell quirks
This is alternative to symlinking which would enable us to add/remove ipfs from the PATH of current user via a checkbox in UI, but comes with a lot of edge cases:

The main difference with shell config files is that some are only read by "login" shells (eg. when you login from another host, or login at the text console of a local unix machine). these are the ones called, say, .login or .profile or .zlogin (depending on which shell you're using).
Then you have config files that are read by "interactive" shells (as in, ones connected to a terminal (or pseudo-terminal in the case of, say, a terminal emulator running under a windowing system). these are the ones with names like .bashrc, .tcshrc, .zshrc, etc.
bash complicates this in that .bashrc is only read by a shell that's both interactive and non-login, so you'll find most people end up telling their .bash_profile to also read .bashrc
– https://stackoverflow.com/a/415444

Thanks for bringing all the thoughts here @lidel. Another thing I want to mention is about Windows: on Windows we actually need to add a directory to the PATH since there's no default folder to put binaries into on Windows. And I'm not yet sure if we need elevated permissions during installation. Windows actually has two PATHs: a system-wide one and a user-specific one. I'll investigate a bit more about that.
On other news, we probably need to take in account #836. If we are going to add it to the PATH, perhaps we should solve both issues at once since they're closely related. Could you please comment on those? /cc @lidel @olizilla

I like the general idea from #836! What if we dont execute node_modules/go-ipfs-dep/go-ipfs/ipfs directly but introduce node_modules/{some-ipfs-wrapper}/bin/ipfs  and add that to the PATH instead?

ipfs would be a small wrapper script that tries to execute ipfs from PATH, and if not there or if entry on PATH point at itself (due to symlink), then the script executes binary currently set as default in ipfs-desktop, eg.  node_modules/go-ipfs-dep/go-ipfs/ipfs instead

JS script run in Node should be more portable than one in Bash
The ipfs wrapper should accept input via parameters and STDIN
(both ipfs swarm peers --latency and echo 'foo' | ipfs add should work)
Cool perk: having this wrapper, when user switched IPFS provider in IPFS Desktop, the ipfs in shell will also reflect that :)

Perhaps instead of creating {some-ipfs-wrapper} from scratch, we could tweak @alanshaw's iim and add this wrapper layer there?

I personally enjoy the idea of having that wrapper around the ipfs binary. Just to make sure I understood: if there is a binary in PATH, we use it. If not, we use our binary.
On the first run, we could add "our" script to the PATH if no ipfs binary can be found. Otherwise, should we ask the user if they want to update (if it's a previous version) or not?

Yes, before adding the bundled ipfs to PATH ipfs-desktop should check if it is already available.
I believe it should at least detect if default ipfs on PATH is in different version than the one shipped with ipfs-desktop. Just a simple warning (with options Continue, Exit) would do the trick: if user has multiple versions on PATH its probably power user that can sort it out  on their own.

Ref for myself: https://nsis.sourceforge.io/Path_Manipulation#Warning

@olizilla did you have the chance of reading @lidel's comments?
Overall I like the wrapper idea, although it adds the complexity of adding a directory to the PATH which is not straightfoward

Great stuff! To check we are on the same page, I don't think we should change the definition of the users PATH. I have mine tweaked and it's manged by git, so having a process change it would be a suprise. I don't think thats what is being suggested here, but I just wanted to check.
I strongly agree that we should keep this simple, and for the default case where ipfs is not on the PATH already, then we should just install it without prompting. I think we should start by looking into what Atom does: https://github.com/atom/atom/blob/cbcad274a7cb68774b9467decc7dee39c13d8e19/script/lib/install-application.js
On first run it attempt to symlink a shell script atom.sh to /usr/local/bin/atom. if it needs priviledges to do so, then it'll prompt the user.
$ ls -la `which atom`
lrwxr-xr-x  1 oli  admin  53 Oct 22 10:07 /usr/local/bin/atom -> /Applications/Atom.app/Contents/Resources/app/atom.sh

I'm in favour of @lidel's suggestion of adding a wrapper that we can use to manage which ipfs is being used, and I agree that we should use some of the logic from iim. Of note Atom also installs apm on first run, and it uses npm to fetch it... https://github.com/atom/atom/blob/cbcad274a7cb68774b9467decc7dee39c13d8e19/script/lib/install-apm.js

So, let's come to an agreement of what we need to do to close this issue.
@olizilla

To check we are on the same page, I don't think we should change the definition of the users PATH

You don't agree on changing the PATH right? I agree we shouldn't change in on macOS and Linux and just add it to /usr/local/bin. On Windows we are required to.

Of note Atom also installs apm on first run, and it uses npm to fetch it...

Does it bundle npm with it? We don't know if the users have it. I agree that once Windows is supported by iim, we should install it if the user has npm installed.

My suggestion for now:

On Windows, add to PATH during installation (only option I can see).
On macOS, symlink to /usr/local/bin during first run if there is no binary in there yet. If there is, ask the user?
On Linux, add it during installation to /usr/local/bin.

Other option I like is: to make iim support Windows. Then, use it as the ipfs dependency manager of IPFS Desktop (do not bundle go-ipfs nor anything) and let the user decide the version through iim. We'd, of course, get the latest first. What do you think?

@hacdias please review the code in atom that does this. You get to decide how it works on windows. I recommend checking how some other apps do it. As much as possible the process should be the same on macOS vs Linux, so there are fewer variations to test.

@olizilla on Windows it seems they just don't add anything to the PATH.
On macOS, they add it on the first run. See here..
On Linux, they add it during installation. See here.
Basically what I've suggested.

As much as possible the process should be the same on macOS vs Linux, so there are fewer variations to test.

As @lidel mentioned, you can't modify /usr/local/bin after installation. And on macOS you can't modify it during installation so it's still different.

What's still to decide is what to put there: the bundled version? Ignore anything that already exists? We could assume that someone using IPFS Desktop doesn't install ipfs from the command line. We could also have a way to install multiple versions through IPFS Desktop afterwards.

Get the simplest thing working first. We're gonna need tests for the 3 different paths. Link to a shellscript that gives us enough indirection to change how it works later / update the binary without needing to update the link.

So, we now have this enabled on all packages we ship except AppImage. It isn't possible with AppImage unfortunately. At least I haven't found a way to do so.
Although I've found an interesting solution that could help us making the process more uniform on Linux and macOS. If we did it on runtime, we could use this package (sudo-prompt) to ask for permissions on Linux. That way, the logic on macOS and Linux could be shared and we'd relieve the pain that the build of installers is.
What do you think @lidel? I believe it's not common on Linux to ask on runtime for permissions, but it'd be much easier and give more flexibility (like reverting the option in the interface). And it would work with all installers.

@hacdias I must agree, unifying everything around sudo-prompt sounds like a neat way to  simplify codebase and remove Linux maintenance burden.
The only ask for Linux runtime would be to remove the "surprise factor" caused by sudo call.
We could

make it opt-in via tray menu (disabled by default on Linux)
explicitly ask during first time app starts ("Do you want to add ipfs to your PATH Y/n?").

Linux context:  we were trying to come up with electron-builder way to add post-install hooks that create symlinks and work the same in every Linux package type and it turned out to be an error prone process and a huge time sink. As noted, in the end it does not work everywhere anyway. We'd have to either drop electron builder or spend significant time on patching it, and I believe the time could be better spent elsewhere given our limited resources.

@lidel yes, the point was to ask first and merge this on #906. What do you think?


Corrected the input to execute the Java JAR file

Corrceted from tempLocation to gcpTempLocation
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Change the documentation for tempLocation to gcpTempLocation while executing self executing JAR

Are not both gcpTempLocation or tempLocation both valid?

tempLocation gives error.

tempLocation gives error.

Both should be valid, what is the error that you are seeing so the underlying root cause could be fixed?


fix typo getSignalQuality()

resolve #21
@key, thanks 🙇

Woohoo! Found new typo that is Deplicate. Correct word is Deprecate ! 😭

😭 fixed 😭


Datepicker options

Hi there,
I don't understand how we can set options for datepicker and datepicker-popup.
And can't find the match with which options are available...
For now, I have find only one options that actually work :
.config(function (datepickerPopupConfig) {
    datepickerPopupConfig.showButtonBar = false;  // working !
    datepickerPopupConfig.dateFormat = 'yyyy-MM-dd'; // not working...
    datepickerPopupConfig.showWeeks = false; // not working...
})

Any clue ? Links ? Full example ?
Thank you !

I'm using the current version 1.3.4 and I still have the issue.
http://plnkr.co/edit/ZEeHe7?p=preview


bug #2341 ClassKeywordRemoveFixer incorrectly leaves leading Backslash

I adjusted the test-case and removed the leading backslashes from the classname.

closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/2341
(for ref. and autoclosing on merge)

@SpacePossum
Should I change my commit to include the "closes"-keyword? I thought maybe bug # is enough in the commit message, because there are other commits, that are missing "closes" in their commit-message...

@rvock no need to change the message.
(commit messages typically don't contain closes refs. in this project anyway)
All good thanks :+1:  lets focus on code changes :)


rpm support

Support rpm builds as layers would include:

Download artifacts and use rpmbuild to  build RPMs;
Each RPM in its own oci layer;
It should be an option rather than making RPM usage  mandatory;
It should be able to generate a repository container image;
...

Will be dealt from cotnainerfiles


[InstagramBridge] No Media in Content Option

Hi,
Here is the suggestion to add an option that removes Media from Content.
Sometimes (e.g. in JSON) you don't need Media in Content, because it already listed in Attachment\Enclosure. This pull reqest adds an option for that.

I get warnings on using this. Here's a fix: https://github.com/somini/rss-bridge/commit/0a882aa945ea165b6ceeb925e51dfb58503493e4
You can apply this with:
git pull "https://github.com/somini/rss-bridge.git" pull/1399


At the very end of #tofix(2) - review and cleanup the code of anything that is unused / uneeded

Prepare the code for PR. Remove unneeded comments, unused code that was added by us, but not needed, etc.
Cleanup history, commit names, etc.

Cleaned up the code in https://github.com/go-gitea/gitea/pull/21820/commits/649da240b260c58a4a20fbf71bcaf17cdaeb62b5


ROG (Run On Gun)

ROG (Run On Gun) is a Shooting Game where users can enjoy the game launched back in the '90s. This Shooting Game is with some more Enhanced features and UI where users can better interact with the game with ease and without getting stuck.
It can be Build in Front end technologies with some sort of Python Codes.

HI @584aditya , please let us know the detailed plan, dummy UI/Video ? make sure you are using react js.

@admindebu sir i want to work on this issue under gssoc'23


Can't mount local volume, its give permission denied.

The problem on docker-compose up:
database    | Initializing database
database    | mysqld: Can't create/write to file '/var/lib/mysql/is_writable' (Errcode: 13 - Permission denied)
database    | 2018-11-28T15:08:33.615511Z 0 [Warning] TIMESTAMP with implicit DEFAULT value is deprecated. Please use --explicit_defaults_for_timestamp server option (see documentation for more details).
database    | 2018-11-28T15:08:33.618209Z 0 [ERROR] --initialize specified but the data directory exists and is not writable. Aborting.
database    | 2018-11-28T15:08:33.618234Z 0 [ERROR] Aborting
database    |
database exited with code 1

My docker-compose.yml
version: '2'
services:
    database:
        image: percona
        container_name: database
        environment:
            - MYSQL_ROOT_PASSWORD=root
        volumes:
            -  ./database:/var/lib/mysql
        ports:
            - "3306:3306"

Docker version
$ docker -v
Docker version 18.09.0, build 4d60db4

$ docker-compose version
docker-compose version 1.23.1, build b02f1306
docker-py version: 3.5.0
CPython version: 3.6.7
OpenSSL version: OpenSSL 1.1.0f  25 May 2017

Selinux is disabled
$ sestatus
SELinux status:                 disabled

Trivia
Folder is created
It's create ./database folder like this;
drwxr-xr-x   2 root  root     6 nov 28 13:04 database
Mysql official works
If instead of Percona I use Mysql its works fine.
version: '2'
services:
    database:
        image: mysql
        container_name: database
        environment:
            - MYSQL_ROOT_PASSWORD=root
        volumes:
            -  ./database:/var/lib/mysql
        ports:
            - "3306:3306"

Poor solution
I make it works creating ./database with 777 permission in advance.
But I'd prefer that works like MySql official image.
OS
cat /etc/os-release
NAME=Fedora
VERSION="29 (Workstation Edition)"
ID=fedora
VERSION_ID=29
PLATFORM_ID="platform:f29"
PRETTY_NAME="Fedora 29 (Workstation Edition)"
ANSI_COLOR="0;34"
CPE_NAME="cpe:/o:fedoraproject:fedora:29"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f29/system-administrators-guide/"
SUPPORT_URL="https://fedoraproject.org/wiki/Communicating_and_getting_help"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=29
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=29
PRIVACY_POLICY_URL="https://fedoraproject.org/wiki/Legal:PrivacyPolicy"
VARIANT="Workstation Edition"
VARIANT_ID=workstation

$ uname -r
4.19.4-300.fc29.x86_64

Your permissions are set drwxr-xr-x where user=7, group=5, other=1. The user in the container is mysql so they only have execute permissions since the owner/group of that folder is root.
The user in the container is mysql. So you could also chown it if you wanted or do a chmod 777 database

@wglambert the folder ./database is created with this set of permission automatically by docker.
As I said before if I created the folder and set its permissions in advanced it will work, but because on Mysql Official Image it was not necessary. It would be nice if in Percona was the same.

The percona official image is no longer maintained in this repository -- please see https://hub.docker.com/_/percona/ for details about the new home of the percona official image source.

@delgod @vadimtk it might be a good idea to enable "issues" on https://github.com/percona/percona-docker, especially since https://github.com/percona/percona-docker/issues is where https://hub.docker.com/_/percona/ is currently pointing users to file issues :sweat_smile:
(Or we should update that to point elsewhere if there's a preferred location for issues with the Docker images.)

first of all, please never run chmod 777 dir, it is insecure, change owner instead chown 999:999 dir.

As I said before if I created the folder and set its permissions in advanced it will work, but because on Mysql Official Image it was not necessary. It would be nice if in Percona was the same.

@roger-russel,
you can find plenty of best practices and recommendations on the internet about non-root user inside a container. It is a huge anti-pattern to have root user inside a container.
So, as a result, without root, we cannot change owner in ENTRYPOINT.
I hope for your understanding. Security is always a hard choice, and it is better to be blamed due to lack of usability than lack of security.

(Closing here given https://github.com/docker-library/docs/pull/1371 and https://github.com/percona/percona-docker/pull/63. :+1:)

Created an issue regarding this on their Jira system: https://jira.percona.com/browse/PS-5111
It would be great if their Github repo would use Github issues and not Jira since this is an Open Source project after all.

@jelovac GitHub is not Open Source project either, so  I am not sure why you prefer it over Jira


Better Logging Interface (Also simplified)

@Alc-Alc In my experience, the interface does not seem accessible (read: not easy) compared to other features of litestar. It seems to be a wrapper around https://docs.python.org/3/library/logging.config.html#logging-config-dictschema. While stdlib logging is not the greatest, I would be happy with a higher abstraction that makes this easier to use, even if it means losing out on some fine-grained config (in which case I would be ok to fallback to the current interface)

https://discord.com/channels/919193495116337154/1182745702942646313/1185461662682206289

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Not sure if I really grasp the logging problem at hand: But I was wondering if loguru could be a nice logging solution for litestar. Comes with a lot of great features out of the box and is my go-to logging solution currently.

I propose we remove litestar.logging, and Litestar.logging_config for v3, and instead either emit our log messages via standard library logging, or let a user pass in a logger object that conforms the stdlib logging interface (or perhaps a combination of both).
My main concern is its unnecessary. We don't need a tight coupling to the user's logging configuration to operate the application, and the convenience payoff doesn't return enough to outweigh the complexity this brings to our code base, and to our user's configurations.

Personally, I would be fine with both, loguru or the standard logging library. I don't care what is used under the hood, but I care how easy and fast I can use it with Litestar. As such, I'm more concerned how it is documented. :smiley_cat:
I've opened https://github.com/orgs/litestar-org/discussions/3482#discussioncomment-9376183 because the documentation couldn't answer my questions.
So please, whatever you implement, take into account that this new feature is only done when it's probably documented. :wink:
Many thanks for all your time and dedication! :heart:

I propose we remove litestar.logging, and Litestar.logging_config for v3, and instead either emit our log messages via standard library logging, or let a user pass in a logger object that conforms the stdlib logging interface (or perhaps a combination of both).
My main concern is its unnecessary. We don't need a tight coupling to the user's logging configuration to operate the application, and the convenience payoff doesn't return enough to outweigh the complexity this brings to our code base, and to our user's configurations.

First of all, I want to thank you for creating such a great library!
However, I believe it would be even better if Litestar allowed working directly with a user-defined custom logger object. This approach would enable managing the logger configuration in one place (SSOT) without splitting the logic of logger creation and initialization into multiple parts.
This is particularly critical for large systems where uniform logging is essential across all service components and services. Unfortunately, this has been a significant challenge for our team with Litestar after FastAPI. I’ve provided MRE, screenshots, and links here.
Currently, Litestar’s initialization overwrites the default logger, even if the user has defined one before application initialization. Under the hood, Litestar’s logger configuration creates a built-in Python logger, which makes it all the more important to allow passing a custom logger object.
I believe this could be introduced as a small feature in an upcoming minor update, without needing to wait for the next major 3.x.x version. The interface could look something like this:
import logging
from litestar import Litestar

custom_logger = logging.getLogger("my_logger")
app = Litestar(logger=custom_logger)

This flexibility would make it easy to implement standard practices like colored structured logging for development and JSON logging for production servers, which have become industry standards.
Thank you 🤖


Debug console uses 'ctrl+click' to follow links.

Debug console uses ctrl+click to follow links. However, everywhere else in vscode we use alt+click to do the same.

No, ctrl is everywhere. Most improtatnly in the explroer.
Where is altr + click for link following? Also on what platform are you?

Forgot to add the info. I am on Windows.
And it is always alt+ click to open files from links (editor, problems panel, termnial, output panel...)
Examples:

Debug Console:

Version: 1.42.1 (system setup)
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:45:59.656Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.16299

You pobably have some setting for this. And it seems like the debug console is not supporting this setting.
I am open for a PR which fixes this.
Code pointer https://github.com/microsoft/vscode/blob/33e78e0978b032d6cddef69bcc650a1d488d7297/src/vs/workbench/contrib/debug/browser/linkDetector.ts#L148

You pobably have some setting for this. And it seems like the debug console is not supporting this setting.

I don't think it is a setting. But looking through the code, I saw somewhere a check if the multiCursorModifier == ctrlCmd.
If that is the case then, alt+click is used instead of ctrl+click.

I am open for a PR which fixes this.

Okay nice. I will give it a go (will be my first time). Can I also make the casing of alt consistent? If yes then should the first letter be capitalized or not?

@psclkhoury let's go with small caps alt. That is more recognizable to users imho.
Thanks!

@isidorn I tried to fix the issue and this is what I have so far.
The keybinding to follow the link depends on the setting of editor.multiCursorModifier as in other parts of the code.
There is one thing that is still missing. If a link is already decorated in the debug console with Follow link (alt+click), then I change the setting editor.multiCursorModifier from ctrlCmd to alt, then the decorated link in the debug console does not change.
In the other views there is some kind of listener to this setting and the tooltip/keybinding is updated accordingly. But I don't know how to do that.
diff --git a/src/vs/workbench/contrib/debug/browser/linkDetector.ts b/src/vs/workbench/contrib/debug/browser/linkDetector.ts
index ff264cc8c2..d09c4ac75c 100644
--- a/src/vs/workbench/contrib/debug/browser/linkDetector.ts
+++ b/src/vs/workbench/contrib/debug/browser/linkDetector.ts

+       private _getModifierKey(): 'alt' | 'meta' | 'ctrl' {
+               const multiCursorModifer = this._configurationService.getValue<'ctrlCmd' | 'alt'>('editor.multiCursorModifier');
+               if (multiCursorModifer === 'ctrlCmd') {
+                       return 'alt';
+               } else {
+                       if (platform.isMacintosh) {
+                               return 'meta';
+                       } else {
+                               return 'ctrl';
+                       }
+               }
+       }
+
+       private _getLinkHoverString(modifierKey: 'alt' | 'meta' | 'ctrl'): string {
+               const tooltipLabel = localize('links.navigate.follow', 'Follow link');
+
+               const tooltipKeybinding = modifierKey === 'ctrl'
+                       ? localize('fileLink.ctrl', 'ctrl + click')
+                       : modifierKey === 'meta'
+                               ? localize('fileLinkMac.cmd', 'cmd + click')
+                               : platform.isMacintosh ? localize('fileLinkMac.option', 'option + click') : localize('fileLink.alt', 'alt + click');
+
+               return `${tooltipLabel} (${tooltipKeybinding})`;
+       }
+
        private decorateLink(link: HTMLElement, onclick: () => void) {
                link.classList.add('link');
-               link.title = platform.isMacintosh ? nls.localize('fileLinkMac', "Cmd + click to follow link") : nls.localize('fileLink', "Ctrl + click to follow link");
-               link.onmousemove = (event) => { link.classList.toggle('pointer', platform.isMacintosh ? event.metaKey : event.ctrlKey); };
+               const modifierKey = this._getModifierKey();
+               link.title = this._getLinkHoverString(modifierKey);
+               link.onmousemove = (event) => {
+                       link.classList.toggle('pointer', modifierKey === 'meta' ? event.metaKey : modifierKey === 'ctrl' ? event.ctrlKey : event.altKey);
+               };
                link.onmouseleave = () => link.classList.remove('pointer');
                link.onclick = (event) => {
                        const selection = window.getSelection();
                        if (!selection || selection.type === 'Range') {
                                return; // do not navigate when user is selecting
                        }
-                       if (!(platform.isMacintosh ? event.metaKey : event.ctrlKey)) {
+                       if (!((modifierKey === 'meta' && event.metaKey) || (modifierKey === 'ctrl' && event.ctrlKey) || (modifierKey === 'alt' && event.altKey))) {
                                return;
                        }
                        event.preventDefault();

Feel free to create a PR. Try to make it elegent, the less code there is the higher chance that we merge it in.
If you do not have time I can look into this in the future. Thanks!

Still a problem. Would be great to see a fix for this!

On my setup (Windows) ctrl-click on a link doesn't work, but alt-ctrl-click does!


Clarification of README file statements in bird-spawner-3000

I already filed [Issue# 1 in pipe-builder-3000
If both pipe-builder-3000 and bird-spawner-3000 are installed on the same server naming.
You can't name each's json file the same name hosts.json since both have different Content & format ??
So what  should we call bird-spawner-3000's file?   And... what directory should it be moved to?

Booth files are json (RFC 8259) even if [ and { is used.
I did not test the pipe-builder config on the bird-spawner however, it should work fine.
I will verify my theory soonTM.

Again, thanks!
However, my question was way more fundamental and I guess related to me being practically json illiterate.
For Bird-Spawner-3000 and for Pipe-Builder-3000 I'm just trying to understand if when installed
they each get installed to their own directory ...
in which case both of them having the same json file name "hosts.json"
because the 2 hosts.json files would be in separate directories.
Is that how  this gets installed?

What?


Insertion of a key, A, that is a complete subset of another key, B, prevents A from being found

Consider 2 key-value pairs:
"tester" => 1
"test" => 2
Inserting both of these in the radix tree, in either order, results in a tree that fails to match on lookups using key "test".
Leaf nodes are always nodes representing the right-most bytes of the key, and a leaf node is regarded as synonymous with a match. However, the node representing the superset key is not split to allow a node representing the end of the subset key (or a "string end" leaf node if the leaf == match semantics are to be preserved).

Just read a comment you made in another thread about full prefixes not being supported, and using terminating characters instead. I'll close as this is obviously intended behaviour.


Select and move objects

If we create two nodes (1, 2) and select and drag node 2 over node 1, then node 2 will lie above 1.
But if we again double click on node 2 and try to drag it, then node 1 is selected and dragged,
not node 2.

Thanks. We will fix it.

I changed select algorithm. Now it selects top object.


[tiff] unused CMake variable CMAKE_DEBUG_POSTFIX

Host Environment

OS: x64-linux (Fedora 34)
Compiler: GCC 11.2.1

To Reproduce
Steps to reproduce the behavior:
./vcpkg install tiff
Failure logs
Building package tiff[core,jpeg,lzma,zip]:x64-linux...
-- Downloading https://download.osgeo.org/libtiff/tiff-4.3.0.tar.gz -> tiff-4.3.0.tar.gz...
-- Extracting source /home/be/sw/vcpkg/downloads/tiff-4.3.0.tar.gz
-- Applying patch cmakelists.patch
-- Applying patch fix-pkgconfig.patch
-- Applying patch FindCMath.patch
-- Using source at /home/be/sw/vcpkg/buildtrees/tiff/src/4.3.0-84bf77f2fa.clean
-- Found external ninja('1.10.2').
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
CMake Warning at /home/be/sw/tenacity/build/vcpkg_installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_configure.cmake:472 (message):
  The following variables are not used in CMakeLists.txt:

      CMAKE_DEBUG_POSTFIX

  Please recheck them and remove the unnecessary options from the
  `vcpkg_cmake_configure` call.

  If these options should still be passed for whatever reason, please use the
  `MAYBE_UNUSED_VARIABLES` argument.
Call Stack (most recent call first):
  ports/tiff/portfile.cmake:42 (vcpkg_cmake_configure)
  scripts/ports.cmake:141 (include)

Please stop opening issues for "unused variables". It is not a failure. It is a new check to support maintainers, to be handled when making changes to a port.
And last not least, CMAKE_DEBUG_POSTFIX is a false positive.

All the variables have prefix CMAKE_ should be ignored.

Fixed by PR https://github.com/microsoft/vcpkg/pull/23864.


Haxe support is broken since version 1.53

Issue Type: Bug
I'm able to use Haxe with no issues in version 1.52.1-1608137084.el7 but as soon as I update with yum, haxe stops working. I just tried version v1.54 and the entire app locked up. I ran the top command and vs code was running at 100%+ cpu. Something is up. I'm using haxe version 4.1.3. You can see the installed extensions I am using below. I am on the latest CentOS 7 as of todays date.
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:32:10.090Z)
OS version: Linux x64 3.10.0-1160.15.2.el7.x86_64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 3140)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 1

Memory (System)
31.01GB (21.74GB free)

Process Argv
--no-sandbox --crash-reporter-id 4d2b94ce-65bd-4cf8-93bc-a21ec77d53bb

Screen Reader
no

VM
0%

DESKTOP_SESSION
mate

XDG_CURRENT_DESKTOP
MATE

XDG_SESSION_DESKTOP
mate

XDG_SESSION_TYPE
x11

Extensions (8)

Extension
Author (truncated)
Version

haxe-hl
Hax
1.1.1

formate
Mik
1.1.6

vshaxe
nad
2.22.1

haxe-debug
vsh
1.2.3

haxe-extension-pack
vsh
1.3.0

hxcpp-debugger
vsh
1.2.4

vscode-meteor
vuh
0.1.1

codedox
wig
1.3.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt678:30270856
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vstry244cf:30256637
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
dockersubset:30270708
pythontbcf:30265426
vspre833:30267464
vsdfh931:30270786

Let's start in the extension issue and go from there. Perhaps the extension author can provide more context as to how the haxe extension uses VS Code APIs.

Maybe because you are on CentOS 7, and starting with 1.53 VS Code is no longer compatible.


Extract score from Scene e.g. use ScoreScene

Introduce a ScoreScene class.

Added ScoreScene class with commit 8019a97c744a5057dbb94e76725b84b0a9beecc2.


How to upload file via HTTP PUT w/?

Hello again to the Crisp team!
In the last week, I tried to use the upload feature. I could generate the signed URL, but my main problem is that I can't upload my file via HTTP PUT w/.
I also tried to upload my file with Postman. I got 200 OK response, but nothing happened and my file didn't get uploaded.
Here is a screenshot of what I do in the Postman:

I double-checked that the name and type of my file are the same as the name and type that I used for generating the signed URL.
I think I did a mistake in setting parameters. Could you please help me?
Thanks a lot!

After uploading your file, can you append a random "?number" as a GET parameter at the end of your file URL and try checking if it is there? Just to make sure that you bypass our CDN cache for tests.
Also, can you please share an excerpt of the code that uploads the file via HTTP PUT?

@valeriansaliou Thanks for the quick response.
Currently, I just try to do PUT request with the Postman and if is correct, I'll try to write a code to do it.
I append a random number at the end of the file URL, but it gives me Oops! This file has been deleted. It may have expired as it was too old, or was removed by our systems because it could be harmful. error.
Are my postman request and parameters correct?
I send my PUT request with these 5 parameters:
file: is a uploader - I click on the browse button and select my file.
content-type: is a string - type of my files is the same as the type that I sent in generateURL request.
name: is a string - name of my files is the same as the type that I sent in generateURL request
type: is a string - type of my file that is the same as the type that I sent in generateURL request
url: is a string - resource URL

What's the file you are trying to upload? We may auto delete some files due to viruses.

@valeriansaliou It's just a jpeg image.

@valeriansaliou Do I have to add any authorization in my parameters? I saw the PUT request has some X-Amz headers to authorize the request. But should I add my identifier:key authorization in order to have a valid request?

No, this is not neeeded. Whenever you HTTP PUT the file, the server replies w/ 200? If so, then this means the file was successfully uploaded.
I'd need to see some of your code handling the upload and (if any) file retrieval to help you more on that.

@valeriansaliou
1) At first, I try to generate a signed URL. So, I use this code:
var data = {
    namespace: "upload",
    from: "plugin",
    identifier: 'my plugin identifier UID',
    id: socket.id,
    file: {
        name: input.file.name,
        type: input.file.type
      }
};

crispClient.bucket.generateBucketURL(data)
.then(function (state) {
    output(state);
}).catch(function (error) {
    output(error);
});

2) After the signed URL was generated, the bucket::url:upload:generated event is called and it gives me some information like resource and signed URL:
crispClient.on("bucket:url:upload:generated", function (bucket) {
    console.info("Upload link generated:")
    console.log(bucket);
    console.log(bucket.url);
});

3) Then I copy signed url and open the Postman application and add paste this URL and set the type of request to PUT.

It automatically adds some params like X-Amz-Algorithm, X-Amz-Credential and etc. to verify my request.
4) Finally, I go to the body tab and add my params as a form-data (like this image):

5) Then I press send and it gives me 200 OK response:

But, if I copy the resource URL and paste it into my browser URL, it gives me just this error:
Oops! This file has been deleted.
It may have expired as it was too old, or was removed by our systems because it could be harmful.

And these are all things that I do.

Ah! It doesn't work like that that's why. You need to upload the actual image binary data to the signed URL. I don't know where you saw that you had to send JSON to this URL, this is not what it expects. You need to send binary data (all your image data, pbb multiple MB of data). Actual file data uploading.

@valeriansaliou Ah, thank you! Finally, I could upload it!
Many many thanks for taking your time and solving my problem!
As you said. I did a mistake because I uploaded my image as JSON. and I should upload it as BINARY.
Thanks again and have a good time!


Add libra config command

New features or issues fixed: Added the config command to Libra.
Purpose of the changes: Improve the implementation of Libra.
Supported functionality:  libra config [--add|--unset|--unset-all|--get|--get-all|--list]  <value(value-pattern)>.

Oh, I'm really sorry. I made a mistake.
Your current plain structure is Okay.
"git config" command does have "--add" arg rather  than subcommand.
Sorry again for my mistake.
---Original---
From: @.>
Date: Wed, Dec 11, 2024 10:38 AM
To: @.>;
Cc: "Qihang @.>;"Review @.>;
Subject: Re: [web3infra-foundation/mega] Add libra config command (PR #732)
@xsrkt26 commented on this pull request.
In libra/src/command/config.rs:
> +    add: bool, +    /// Get a single configuration entry that satisfied key and value pattern from database +    #[clap(long, group("mode"))] +    get: bool, +    /// Get all configuration entries that satisfied key and value pattern from database +    #[clap(long("get-all"), group("mode"))] +    get_all: bool, +    /// Remove a single configuration entry from database +    #[clap(long, group("mode"))] +    unset: bool, +    /// Remove all the configuration entries that satisfied key and valuepattern from database +    #[clap(long("unset-all"), group("mode"))] +    unset_all: bool, +    /// List all the configuration entries from database +    #[clap(long, short, group("mode"))] +    list: bool,
I can't quite understand why using subcommands would be better here. I've read most of the command code and found that most of them don't use subcommands. Is it because subcommands are more intuitive and easier to understand?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: @.***>


amy should track number of "ehhh" leo types

maybe we can get statistics of the number of ehhh's typed according to how many h's there are and then calculate the average number of h's in a leo "eh"

NO

As @Leo10250 proposed, he can handwrite this himself?

good idea

Ok @Leo10250 since I am in agreement with @brilam8 it has been agreed that you will be the storage medium.

Implemented in commit 7354d881be49a14e1f7ec93ce423885ab1c1ea2b. Feature goes live in the next few hours.


Stopping Mockserver-Container takes about 10 seconds

It seems that the Mockserver-Container does not handle the docker stop command properly so that it will be killed (forced) after the default timeout of 10 seconds.

2018-06-20T11:22:40.307436600+02:00 container start c72ad60586f0cfdb1f471bc749634a8ab198bb7ecc43def8d1bfa09bb38df80a (image=jamesdbloom/mockserver, name=gallant_bhaskara)

2018-06-20T11:23:01.652187200+02:00 container kill c72ad60586f0cfdb1f471bc749634a8ab198bb7ecc43def8d1bfa09bb38df80a (image=jamesdbloom/mockserver, name=gallant_bhaskara, signal=15)

2018-06-20T11:23:11.668604500+02:00 container kill c72ad60586f0cfdb1f471bc749634a8ab198bb7ecc43def8d1bfa09bb38df80a (image=jamesdbloom/mockserver, name=gallant_bhaskara, signal=9)

2018-06-20T11:23:11.818113800+02:00 container die c72ad60586f0cfdb1f471bc749634a8ab198bb7ecc43def8d1bfa09bb38df80a (exitCode=137, image=jamesdbloom/mockserver, name=gallant_bhaskara)

2018-06-20T11:23:12.340376000+02:00 network disconnect cc2c936f4a1ecf92d0058fd2110901b94a9c1a72355689df1e81df4733a2a524 (container=c72ad60586f0cfdb1f471bc749634a8ab198bb7ecc43def8d1bfa09bb38df80a, name=bridge, type=bridge)

2018-06-20T11:23:12.443712000+02:00 container stop c72ad60586f0cfdb1f471bc749634a8ab198bb7ecc43def8d1bfa09bb38df80a (image=jamesdbloom/mockserver, name=gallant_bhaskara)

I have seen this before in my Docker containers. It happens when the Docker container runs a script and that script kicks off another process. The Term/Kill signals are received by the bash script but not sent on to the Java process which keeps running. Docker then has a timeout while it is waiting for the process to stop but it will never stop becasue it never got the stop signal!
It is explained better than I can here:
https://veithen.github.io/2014/11/16/sigterm-propagation.html
I fixed it in my own containers by adding code to the bash script which propergated the term signals to my sub processes. I think the same fix will work here.

this is now fixed and will be in the next release of the latest tag (once the build completes)


adding ability modifiers in Effects not working

I do not have any mods, and have tried on a brand new world and have the same effect.
I have yet to host this world.
When activating an effect and try to add for example @abilities.con.mod, it does not add even though i see that the constitution mod is at a +2. it does work for @abilities.con.value
in this example
attribute key:  system.attributes.hp.tempmax
Change  mode: add, upgrade, override
effect value: ( see below)
@abilities.con.mod     - doesn't work
@abilities.con.value    - Works
14   (Any number)      - works
I am currently on version 12 build 330
I am using Dungeons & Dragons Fifth Edition version 3.3.1
Please note: I have just started using Foundry VTT again after a 1+ year Hiatus so also unsure if this feature was removed.

Note that as described in the wiki article on Active Effects, Roll Data is not allowed as an Effect Value for .tempmax; only flat numbers.
Please head over to the #dnd5e channel on the Foundry discord for all followups, and for general troubleshooting of game system mechanics.

This I believe was never a core feature btw. it was and still is a feature of the module DAE. I'm guessing you used to have that module and that gave you the ability to use Roll Data in the past


Updated packages, and binded assembly info to common.props

Binded common assembly info to common.props,
Updated NuGet packages,
Updated build scripts.

@eraydin thanks a lot.

merged @eraydin


Added org page for IBM-DBWKL

IBM-DBWKL contains a project that is used to create workload for the OMEGAMON XE for DB2 project but can be used in other scenarios as well.

merging manually


"Cistia" is listed in the drop-down menu

Description:
"Cistia" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Cistia" in the search bar.

Expected results
The location is listed in the drop-down menu as "Cistia, Brăila (Frecăței)".