Very small maxClusterRadius hangs browser

[x] I'm reporting a bug, not asking for help
[x] I'm sure this is a Leaflet.MarkerCluster code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[x] I've searched through the issues to make sure it's not yet reported

How to reproduce

Leaflet version I'm using: 1.1.0 (also reproduced with 1.2.0)
Leaflet.MarkerCluster version I'm using: 1.1.0
Browser (with version) I'm using: Firefox 57.0b11
OS/Platform (with version) I'm using: Ubuntu 17.10 Artful Aardvark
Create a cluster group with at least one layer (it can even be just a single marker)
Set its maxClusterRadius to 0 or Number.EPSILON
Add it to a map

What behaviour I'm expecting and which behaviour I'm seeing
What I’m looking for is a way to completely disable clustering except for markers with identical coordinates (similar to #399) – that is, I’m only interested in the spidering behavior. I thought setting maxClusterRadius to 0 or Number.EPSILON might achieve this, but instead it hangs the browser.
Note: in Firefox 57.0b11 (aka “Quantum”), the hanging browser is rather recoverable – after about ten seconds, Firefox gives you the opportunity to kill the tab, and in the case of JSFiddle (e. g. the one linked below), it even only kills the iframe containing the map, so you can re-run the JSFiddle to try again. With another browser, YMMV – take care :)
Minimal example reproducing the issue

[x] this example is as simple as possible
[x] this example does not rely on any third party code

https://jsfiddle.net/vjw4fkqw/5/ (note: opening the fiddle will not yet hang your browser, you have to click one of the two buttons in the output first)

haha wow.
Yeah this is a degenerate case, not sure I'm gonna fix it, but glad to have someone else do so.
That 0 ends up being _cellSize, which gets used here:
https://github.com/Leaflet/Leaflet.markercluster/blob/master/src/DistanceGrid.js#L108
and probably means all markers get compared with all other markers, or something else weird.

Thank you very much for the pointer, I think I have a fix coming up :)

@lucaswerkmeister were you able to achieve clustering only for identical coordinates?


Interface file fixes

Includes potential fixes for several issues as well as new tests contributed by @wz1000
I still don't fully understand how much recompilation avoidance is provided by GHC and how much needs to be implemented by the application, so it's possible that further work is needed.

This is a massive performance regression. Not sure how that happened:
version                                    name                         success   samples   startup              setup                experiment           maxResidency
upstream                                   hover                        True      100       10.008805828         0.0                  1.0496357980000002   138MB
upstream                                   edit                         True      100       10.342245301         0.0                  40.515747643000005   137MB
upstream                                   getDefinition                True      100       20.589914577000002   0.0                  0.537914714          324MB
upstream                                   hover after edit             True      100       9.944694886          0.0                  89.364840677         156MB
upstream                                   completions after edit       True      100       9.465573668000001    0.0                  50.609864630000004   148MB
upstream                                   code actions                 True      100       9.376972059          0.6628133180000001   0.96582895           166MB
upstream                                   code actions after edit      True      100       10.779993297         0.0                  41.802328869         171MB
upstream                                   documentSymbols after edit   True      100       9.692719622          0.0                  3.1590869070000003   133MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   hover                        True      100       6.223012398000001    0.0                  10.586891355         197MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   edit                         True      100       5.159852353000001    0.0<PHONE_NUMBER>120001    292MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   getDefinition                True      100       5.306326698          0.0                  10.629264252         198MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   hover after edit             True      100       5.547018304000001    0.0<PHONE_NUMBER>04        279MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   completions after edit       True      100       5.374164883000001    0.0<PHONE_NUMBER>93        287MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   code actions                 False     100       5.434037030000001    0.615423809          1.130345192          32MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   code actions after edit      True      100       5.755494079          0.0<PHONE_NUMBER>65        301MB
d80f24bf4c33e3af3f5a6acb4a67f7d9ac55c025   documentSymbols after edit   True      100       5.709243778          0.0                  3.7647437750000003   19MB

Will investigate, moving it to draft

I have tested this locally and it seems to work as expected. Thanks!

This is ready for review now. Updated benchmark results:
version    name                         success   samples   startup              setup                experiment           maxResidency
upstream   hover                        True      100       5.8482816820000005   0.0                  4.9454744690000005   134MB
upstream   edit                         True      100       5.31275002           0.0                  37.709283213         137MB
upstream   getDefinition                True      100       5.155887724          0.0                  5.071040086          134MB
upstream   hover after edit             True      100       5.644519141          0.0                  43.601127911000006   140MB
upstream   completions after edit       True      100       5.398684477000001    0.0                  46.015129607000006   147MB
upstream   code actions                 False     100       5.466472249000001    0.618790633          0.8490837990000001   34MB
upstream   code actions after edit      True      100       5.246707075000001    0.0                  37.09777081          169MB
upstream   documentSymbols after edit   True      100       5.580899209          0.0                  3.5008937340000004   19MB
HEAD       hover                        True      100       5.149210662000001    0.0                  4.889111615          169MB
HEAD       edit                         True      100       5.018361984          0.0                  37.767128066000005   170MB
HEAD       getDefinition                True      100       5.035206842          0.0                  5.522657187          171MB
HEAD       hover after edit             True      100       5.028756785000001    0.0                  46.070039352         172MB
HEAD       completions after edit       True      100       5.142401647000001    0.0                  48.040290077         176MB
HEAD       code actions                 False     100       5.0633711550000005   0.5794819330000001   0.73311331           102MB
HEAD       code actions after edit      True      100       5.168948583000001    0.0                  39.832205435000006   201MB
HEAD       documentSymbols after edit   False     100       5.080390604000001    0.0                  5.228939e-3          0MB

HEAD       documentSymbols after edit   False     100       5.080390604000001    0.0                  5.228939e-3          0MB

This result seems strange

HEAD       documentSymbols after edit   False     100       5.080390604000001    0.0                  5.228939e-3          0MB

This result seems strange

Benchmarks are failing or succeeding with inaccurate timings because of multiple WorkDoneProgressEnd initialisation. I can confirm that all benchmarks pass for this branch plus #649

We should reuse the benchmark experiments as tests, to make sure they stay running.

Looks plausible but I’m having a hard time figuring out which of the changes are actually the ones fixing the test cases. Could you help me out here?

There's a comment about this in the commit message of the first commit. Reproducing it here:

This started as a pure refactoring to clarify the responsibilities between
ModIface and ModIfaceFromDisk, but ended up having some behaviour changes:

Regenerate interface when checkOldIface returns something other than UpToDate. This was a bug.

Do not generate a diagnostic when regenerating an interface.

Previously we conflated stale interface with other errors,and would regenerate in both cases. Now we only regenerate in the first case.

So previously we were not handling the return value of checkOldIface correctly, which could lead to reusing stale interface files.
Moreover, we were not loading all the transitive dependencies in the Ghc session, only the direct ones, which I think was confusing checkOldIface.

rebased

Thanks for the explanation!


[WIP] [doc] Add docs of node service

What type of PR is this?

/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #162
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @nikola-jokic
/cc @windsonsea
I have prepared documentation for the mock node service, as the functionality is not quite finished yet, it could help to see if there are any problems with the logic and functional description, could you have time to review it?

Let's kick this in except it has some good first issues that can attract contributors.
/lgtm


BUILD-961: use separate dockerfile for using catalog images

Konflux does not support using OpenShift CI images hence use a
modified dockerfile for Konflux

Signed-off-by: Avinal Kumar<EMAIL_ADDRESS>

/label docs-approved
/label px-approved
@avinal this should be linked to the appropriate JIRA issue.

/label qe-approved
No impact on QE

/label acknowledge-critical-fixes-only
This is a zero-risk change to begin onboarding this component to Konflux. Eventually we will remove the shared resource CSI driver from the OpenShift payload.


docs: minor README work, fixes #4

#4

Some minor additions to the readme.

Looks good to me.
I submitted a couple of PRs before I hit the email notification of this PR.
This wraps all the valid points you mentioned in #4 . Thank you!


Pong_game

#8 addresed here!
Description
Give a summary of the change that you have made
Fixes #[ISSUENO]
Dependencies
Mention any dependencies/packages used
Future Improvements
Mention any improvements to be done in future related to any file/feature
Mentions
Mention and tag the people
Screenshots of relevant screens
Add screenshots of relevant screens
Developer's checklist

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-check on my work

If changes are made in the code:

[ ] I have followed the coding guidelines
[ ] My changes in code generate no new warnings
[ ] My changes are breaking another fix/feature of the project
[ ] I have added test cases to show that my feature works
[ ] I have added relevant screenshots in my PR

@bartick
Please explain why this is spam?

You are not assigned to issue #9


restrict network migration mode to techpreview

https://github.com/openshift/api/pull/1546 with gating on the API field.
/assign @pliurh

/lgtm

/retest

/hold


Download zipped plugin from a Dashboard

Sometimes it may come in handy to allow downloading the uploaded plugins through the Dashboard.
This would speed up the process, where we want to promote a version of a plugin running on dev environment to higher environments, like test or prod. Downloading the zip plugin will make sure that exactly the same version would be uploaded to the other places.

I think also adding this option to the CLI makes sense


system.config.js

1

我簽了！
2018-03-19 5:20 GMT+08:00 googlebot<EMAIL_ADDRESS>
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the project maintainer to go/cla#troubleshoot.
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googlecodelabs/cloud-cardboard-viewer/pull/20#issuecomment-374048551,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AjomU2uNNeQYnO0dMNNua-0ZZjZ7EsN3ks5tfs-FgaJpZM4SvYaf
.


Register version v0.1.6

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/70044
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.6 -m "<description of version>" d03cc0d0faaf4b15894f18136b12fa1ab1c42ac9
git push origin v0.1.6


Add support for Hack(#) -style Pipeline Operator

Experiment PR adding Hack-style pipeline operator support to TypeScript. The Pipeline proposal is currently at stage 1 for EcmaScript. Pipeline operator proposal "introduces a new operator |> similar to F#, OCaml, Elixir, Elm, Julia, Hack, and LiveScript, as well as UNIX pipes and Haskell's &. It's a backwards-compatible way of streamlining chained function calls in a readable, functional manner, and provides a practical alternative to extending built-in prototypes."
There's additional Tacit Unary Function Application support through the |>> -operator which behaves exactly like minimal pipelines implementation taking the pipeline input as a sole parameter for the function.
'Pipelines!'
  |> #.length
  |> Math.pow(#, 2)
  |>> console.log; // 100

There's also a PR for minimal implementation pipeline operator.
Code status
This works, but might have some missing features. The TS transformer generates valid JS and there's working type inference. There might be some inconsistencies with specs, insufficient error messages and there's almost no tests. Most of failing tests are not included in this PR since Playground won't get generated with any failures and having faulty baselines is shady. I'm eagerly awaiting feedback, testing and even help with this PR. Even using and talking of these features will help advance them through TC39 proposal process!
Testing
Playground
To test it in your project, add following to your package.json:
{
    "devDependencies": {
        "typescript": "npm<EMAIL_ADDRESS>    }
}

and then run npm install.
PR state
I used @rbuckton 's work on pipelineStage1 branch as a guide.

[ ] There is an associated issue in the Backlog milestone (required)
[X] Code is up-to-date with the master branch
[X] You've successfully run gulp runtests locally
[ ] There are new or updated unit tests validating the change

Why a draft PR for stage 1 proposal?
The TypeScript officially follows EcmaScript / stage 3 proposals. However, I'm opening this draft pull request despite it being only stage 1 so that we get a functional TypeScript environment to gather feedback from developers without having to build typescript itself. Having a playground and npm package will encourage more people to try this fun new feature out and will raise awareness.
Of course, I'm not expecting merging until the proposal reaches stage 3.

@typescript-bot pack this

Personal opinion: The hack-style pipeline operator is bad because it introduces a new context variable, like this, in the form of #. These don't nest in intuitive ways. In addition, the operator doesn't actually save much space for many usages. You could rewrite
'Pipelines!'
  |> #.length
  |> Math.pow(#, 2)
  |> console.log(#); // 100

as
var $$;
($$ = 'Pipelines!',
$$ = $$.length,
$$ = Math.pow($$, 2),
$$ = console.log($$)) // 100

without loss of functionality with very little comparable overhead. (If you use a 1 character variable name, it's a fixed 5 character overhead plus 2 characters per pipeline phase (extra whitespace and comma).
The functional pipeline operator, on the other hand, exists to deliver a point-free style that otherwise is impossible in JS - while some people may hate this style, that is what the true functional pipeline operator truly enables. (Plus, in the common functional style, each pipeline phase saves at least 4 characters, which is a much greater savings than the hack style). Moreover, the functionality of the "hack style" is replicatable (without implicit variables) using the functional style by embedding arrow functions into the pipeline, at a cost of 3-5 (depending on whitespace preferences) characters per pipeline phase which required adapted arguments. (Which shouldn't be too often, as if you find yourself adapting the same function's argument's repeatedly, in the case of either operator form, you should probably wrap it with an adapted form for clarity. For example, if Math.pow(#, 2) appeared more than once or twice, you should probably extract it into a single-argument square function.)
Thanks for coming to my rant. I'm obviously not on the TC39, so my opinion will have absolutely no bearing on which proposal advances.

Update: I've been refactoring the TS PRs for pipelines (both F# #38305  and hack #43617 ) during this week and the commits are a lot cleaner now. The current commit history for hack-style pipelines is just a mess since it builds upon the F# implementation. The newer one will use a common commit.
One big idea I came upon is to have different PipelineExpression types for both a method that itself calls a unary function (F#) and another (hack) that just replaces tokens with the "argument". After all, the way those two pipelines work is different despite the similarities. This will allow for easier support of both F#, hack and even smart pipeline styles at the same time.
I believe that whichever style of F# or hack pipelines will be the default, the next shop would be to add another pipelineish operator for the other one. This is relatively straightforward to implement in TypeScript, so I'm considering adding Tacit Unary Function Application syntax for this Hack-style PR to enable Math.random() |> 1 / # |>> Math.round;.
I've been rebasing my own repos against master, but I still haven't had time to fix the (Missing) errors in Hack-style pipelines. Hopefully I get new versions out before the end of the week.

@typescript-bot pack this

After giving this PR a small trial run, I noticed a pretty big roadblock toward your adoption goal.
The little bits of the feature I could try felt natural and worked correctly in a sandbox but, to get a proper feel for it, I think I would really need to use it in an actual project. Unfortunately, while I would have a great VueJs candidate to test this on, I had to give up on eslint entirely for it to work. With linting enabled in the project, vue cli basically explodes during compilation.
For me, until we can get some experimental eslint support for TS 4.3 and the pipeline operator syntax itself (via @typescript-eslint/parser), I don't think there will be much adoption outside of sandbox testing. There is just too much value in a tool like eslint to warrant ditching it to test a proposal feature in a real world scenario.
I will definitely be back on board the second a version that doesn't crash with this PR gets published, even if it means it only ignores everything in pipelines.

I've been using this PR for a little while on a Discord bot refactor/TypeScript migration project that will be open-source once completed. I greatly enjoy using it to avoid nesting parentheses or avoid declaring variables where function names already communicate intent. I miss it immediately when going back to company code.
Here's a file using small pipelines from my project, it's a Discord message event handler. There're pipelines on lines 30, 42 and 47. It's my first project using TypeScript, so there might be weird stuff. 😖
I've been mostly using the |>> variant because I enjoy point-free style. (If you add partial application to the F# variant, I'll migrate to that one.) It goes very well with curried functions like Ramda's.
Minor feedback on the implementation: the non-null assertion ! post-fix operator can't be used on the # placeholder token. You get [tsserver 18026] [E] '#!' can only be used at the start of a file.

Now at Stage 2
https://twitter.com/leobalter/status/1432741880421257217

@Lonli-Lokli The tweet makes it sound like the proposal already advanced but I don't think it did yet, it was "just" presented today and seeking stage 2 (which is big news too of course). I'm making assumptions based on very little data here but for example "BigInt Math" was scheduled to be presented after pipelines and its advancement has already been updated, unlike pipeline's.

Hey everyone. Let's not rush this.
https://github.com/tc39/proposal-pipeline-operator/issues/203#issuecomment-917493558

I've just post
https://github.com/tc39/proposal-pipeline-operator/issues/202#issuecomment-921433351
Hack-style contains serious problems.
I wish TypeScript users join and I would like to read your insight. Thanks.

This is a new issue to discuss
Impact of Hack pipes on functional programming
https://github.com/tc39/proposal-pipeline-operator/issues/217

This is a new issue to discuss
Impact of Hack pipes on functional programming
tc39/proposal-pipeline-operator#217

I had to move the place, thanks.
https://github.com/tc39/proposal-pipeline-operator/issues/223

Pipelines with operator overloading
https://github.com/tc39/proposal-pipeline-operator/issues/228
We don't want pipe any more. It's redundant over the operator overloading. We no longer support this pipeline-operator proposal as a whole.
RxJS author has just announced he considers the Hack proposal under the standard to adopt, and will ignore.
https://github.com/tc39/proposal-pipeline-operator/issues/228#issuecomment-925465598

@Pokute It looks like there is a transform bug: 1 |> (# |> #) should be rewritten as
var pipelineHackPlaceholder_1, pipelineHackPlaceholder_2;
(pipelineHackPlaceholder_1 = 1, ((pipelineHackPlaceholder_2 = pipelineHackPlaceholder_1, pipelineHackPlaceholder_2)));

and not as
var pipelineHackPlaceholder_1, pipelineHackPlaceholder_2;
(pipelineHackPlaceholder_1 = 1, ((pipelineHackPlaceholder_2 = #, pipelineHackPlaceholder_2)));

I don't think posting Hack vs. F# arguments to these TypeScript pull requests has any productive outcome. There's no good reason why we should fragment the that discussion further by having parallel discussions here, where vast majority of people invested into pipeline operator will not see it.
These kinds of comments, or listing community advocates for one proposal or another have no impact whatsoever on whether this specific implementation of pipeline operator for TypeScript is correct or not.

I have a new version updated against new main ready, that fixes bug reported by nicolo-ribaudo and a couple of other bugs too.
Unfortunately there's no good point in pushing it currently as the master is broken. I'll push it when #46930 is fixed.

Many thanks. Can't wait to test it out!

@typescript-bot pack this

Can this be packed with<EMAIL_ADDRESS>?

Can this be packed with<EMAIL_ADDRESS>?

Ergonomically, that would require force pushing a version that's rebased on an older version. That would be practically undoing some work and it the repo would most probaly not be mergeable to current main branch. It's likely that packing is not possible unless I change the target branch to the 4.5 tag and for that I would have to create a new PR etc. A ton of work and more noise.
@VictorGaiva, what are the reasons you want one for version 4.5 instead of the current main branch? I don't quite understand the reasonings and with them I might be able to help more.

Is this ok, #playground, or have I gone too F#? :grin:
@Pokute Thanks for the work on this! :100:
I have a small issue with VS Code (stable, and insiders), where the TS language server hangs on "starting" after I select the project's TS version npm<EMAIL_ADDRESS>Anyone else? It works fine on Atom :thinking:

Is this ok, #playground, or have I gone too F#? :cowboy_hat_face:
@Pokute Thanks for the work on this! :tada:
I have a small issue with VS Code (stable, and insiders), where the TS language server hangs on "starting" after I select the project's TS version npm<EMAIL_ADDRESS>Anyone else? It works fine on Atom :thinking:

Is this ok, #playground, or have I gone too F#? 🤠

I don't think that there are established hack vs. F# styles yet. The pipeline's main attraction is normalising the direction of data flow. Only through long-term experimentation can we build some best-practices.

@Pokute Thanks for the work on this! 🎉

Thank you! I appreciate testing pipelines out!

I have a small issue with VS Code (stable, and insiders), where the TS language server hangs on "starting" after I select the project's TS version npm<EMAIL_ADDRESS>Anyone else? It works fine on Atom

Interesting. Do extensions and tsconfig.json matter here? I don't think I've had problems recently though I haven't used my own TS build much recently.

Is there any way this kind of features can be handled by plugins?

The proposal is now at Stage 2.


404 jk

Summary of changes
Updated 404 page. See PRODUCT BACKLOG ITEM 70298
Frontend

Updated email to<EMAIL_ADDRESS>Add U of G search page link
Updated page content on 404 page

[x ] My changes are accessible (at minimum WCAG 2.0 Level AA)
[x ] My changes are responsive and appear as expected on mobile and desktop views.
[NA] After merging, I will update the Content Hub documentation and ensure the Content Hub trainer understands how my changes will affect users.
Backend

NA

Test Plan

Request any content that does not exist on the U of G website CH

Insert steps. Include URLs of Netlify test site and Drupal multidev.

updated 404 page for the CH


Email sent to group doesn't support Actionable Message in Office 365 ProPlus client

If the Actionable Email is sent to an Office 365 group, the Actionable Message doesn't appear in Office 365 ProPlus(all versions), only appears in Outlook on the web.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e36738b7-29cb-00c2-30e3-6065addee4c1
Version Independent ID: 57a934d1-7e50-a144-d461-fc55175acfb8
Content: Get started with actionable messages via email
Content Source: docs/actionable-messages/actionable-messages-via-email.md
Product: outlook
GitHub Login: @jasonjoh
Microsoft Alias: jasonjoh

Let me check on this. When you say "Office 365 ProPlus", I assume you mean the Click-To-Run version that is installed from the Office 365 website? Can you add a screenshot of your File->Office Account page in Outlook?
Also, are you using the adaptive card format or the MessageCard format?

You're right, my Outlook version is Monthly Channel with latest update, I can't access the computer that installed the outlook right now.
Both Adpative card and MessageCard can't be displayed if the Actionable Email is send to a group, but can be displayed if sent to a user.

Thanks! I tried this on my side. I've got a newer build of Outlook (yay dogfood!), and for me, the MessageCard format is working in both OWA and Outlook when emailed to a group. Adaptive is not working in either OWA or Outlook when sent to a group.
@tony-zhu do you have any insight here?

Oh I should add though: In Outlook, the card does NOT show up in the reading pane for the message sent to the group, I have to double-click to open the message in a separate window to see the card.

Oh, that's a little tricky, thanks for your finding, it's much better than couldn't display.

I discussed this with the devs, and the problem is that sending actionable messages to groups via email isn't supported in the current implementation. There is some extra work that would have to be done to enable this scenario fully. And yes, that's not in the documentation, I'll fix that shortly.
Currently the only way to get a supported, working actionable message scenario with groups is to use a connector.

Got it, thanks @jasonjoh, I think it's the right way for us to keep using actionable message via email with groups as long as the the actionable email sent to group can  be displayed in a separate window.


Create CODE_OF_CONDUCT.md

Hello i propose to create CODE_OF_PRODUCT.md

Hey @loic5 CODE_OF_CONDUCT.md will be given by us, it's not an issue that can be worked on, thanks!


Fix python_requires in setup.py

It was missing a comma.

At first I saw that issues were disabled, so I read the README and went to the splat (or something) website to register. GitHub login didn't work so I created an account.
In the meantime I've seen in another PR that you don't take PRs here, and you mentioned reviewboard, which seems to be an updated version of the splat website mentioned above. I created an account again, giving personal info and clicking on the Google captcha. I tried to submit a report, but couldn't find how to do so using the web interface. That's way too much effort for a one-character diff, so I'll let you apply this change (if you're interesting in applying it) in the right place 🙂
If you could delete the accounts using the username pawamoy on the splat and reviewboard websites, that would be appreciated.

I happened to try and resolve dependencies for a legacy project with PDM, and it was failing with an InvalidPyVersion: !=3.4.*!=3.5.* error. I guess PDM is a bit less forgiving than pip/other tools.
Thank you for your quick answer and for taking care of this!

Very interesting! Maybe we'll have to incorporate PDM into our testing.
Thanks again, and we'll get that taken care of for the next release :)

I'll close this now, feel free to reopen if it serves as a memo 🙂


Cancel Existing action in button ?

How to cancel existing action on each button ?
Example, when my PC start, streamDeck official application load profile and affet icon et action on each button. But when a change with API , icon and action on buttons, on press two action is launched  : My Action and action profile

Due to the way the streamdeck works, there is nothing we can do on this.
The only way to stop this from happening is to only run one program which interacts with the streamdeck at a time


Swiftmac crashes when reading elisp code

This has been impossible to reliably reproduce, even when I get the log and paste it into a terminal directly into Swiftmac, which makes me think that there is something about the timing of a command that causes the crash, not the order.
Here is the most reliable way I've found to reproduce the issue:

Open some elisp code that has an opening parenthesis in the beginning. The line also needs to be indented, so that Emacspeak would queue indent information. For example, go to line 1830 of dtk-speak.el on latest, which should be    ((dtk-notify-process)                ; we have a live notifier
Now, keep repeating the following steps until you get the main TTS stream to crash: press M-m (which should be bound to back-to-indentation) and then press the right arrow key so that you get to the second opening parenthesis.
Let me know if I can use anything to produce a log with more details if you can't reproduce this.

@parhamdoustdar great report, was able to reproduce.
That said, I have no notion of what the heck might be the cause of it.

What it IS NOT:

Isn't audio icons, happens with them distabled
Isn't a simple form of race condition, happens when I put doSpeak _doSpeak on the MainActor.

It obviously is a race / overlap of some kind.  Annoying on my machine it doesn't actually crash it just stops responding, even when I take all the do/try/catch statements outs.  So, confusing behavior. I too can't get a reproducer in the terminal, trying to double-down on that.
How can it reproduce so reliably via Emacspeak but looking at exact same data to the client by hand does not cause it?!

What if you would add timestamps to the logs? That way we can see how much of a delay causes it to happen? When it doesn't happen in the terminal, makes me think the way to reproduce it is to send those commands at a certain time?Sent from my iPhoneOn 14 May 2024, at 21:35, Robert Melton @.***> wrote:
What it IS NOT:
Isn't audio icons, happens with them distabled
Isn't a simple form of race condition, happens when I put doSpeak _doSpeak on the MainActor.
It obviously is a race / overlap of some kind.  Annoying on my machine it doesn't actually crash it just stops responding, even when I take all the do/try/catch statements outs.  So, confusing behavior. I too can't get a reproducer in the terminal, trying to double-down on that.
How can it reproduce so reliably via Emacspeak but looking at exact same data to the client by hand does not cause it?!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Yep, a good idea.
I thought about it, but would need a custom playback system too.
At this point, worth doing, basically, I am going to created a timed "recording" and a
"playback" system.

On May 15, 2024, at 01:19, Parham Doustdar @.***> wrote:
What if you would add timestamps to the logs? That way we can see how much of a delay causes it to happen? When it doesn't happen in the terminal, makes me think the way to reproduce it is to send those commands at a certain time?Sent from my iPhoneOn 14 May 2024, at 21:35, Robert Melton @.***> wrote:
What it IS NOT:
Isn't audio icons, happens with them distabled
Isn't a simple form of race condition, happens when I put doSpeak _doSpeak on the MainActor.
It obviously is a race / overlap of some kind. Annoying on my machine it doesn't actually crash it just stops responding, even when I take all the do/try/catch statements outs. So, confusing behavior. I too can't get a reproducer in the terminal, trying to double-down on that.
How can it reproduce so reliably via Emacspeak but looking at exact same data to the client by hand does not cause it?!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.>

--
Robert Melton
@.***

Ooh that’s awesome! Would be great to see if you can do that in the testing framework so we can turn issues like these into tests.

On 15 May 2024, at 15:22, Robert Melton @.***> wrote:
Yep, a good idea.
I thought about it, but would need a custom playback system too.
At this point, worth doing, basically, I am going to created a timed "recording" and a
"playback" system.

On May 15, 2024, at 01:19, Parham Doustdar @.***> wrote:
What if you would add timestamps to the logs? That way we can see how much of a delay causes it to happen? When it doesn't happen in the terminal, makes me think the way to reproduce it is to send those commands at a certain time?Sent from my iPhoneOn 14 May 2024, at 21:35, Robert Melton @.***> wrote:
What it IS NOT:
Isn't audio icons, happens with them distabled
Isn't a simple form of race condition, happens when I put doSpeak _doSpeak on the MainActor.
It obviously is a race / overlap of some kind. Annoying on my machine it doesn't actually crash it just stops responding, even when I take all the do/try/catch statements outs. So, confusing behavior. I too can't get a reproducer in the terminal, trying to double-down on that.
How can it reproduce so reliably via Emacspeak but looking at exact same data to the client by hand does not cause it?!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.>

--
Robert Melton
@.***
—
Reply to this email directly, view it on GitHub https://github.com/robertmeta/swiftmac/issues/41#issuecomment-2112512317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACWCGYOHNJFOTEAJMHRJ2TZCNORPAVCNFSM6AAAAABHVT5AVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGUYTEMZRG4.
You are receiving this because you were mentioned.


Resolve thrid party dependency version dynamically

When a rest service is created you can inject dependencies dynamically. If these dependencies are from a thrid party, then the version is not resolved from the BOM.
Reproducer:
Fail:
 @QuarkusApplication(dependencies = {
            @Dependency(groupId = "org.bouncycastle", artifactId = "bctls-fips")
    })
    private static final RestService app = new RestService().withProperties("jsse.properties");

Success:
 @QuarkusApplication(dependencies = {
            @Dependency(groupId = "org.bouncycastle", artifactId = "bctls-fips", version="1.2.4")
    })
    private static final RestService app = new RestService().withProperties("jsse.properties");

Implemented in https://github.com/quarkus-qe/quarkus-test-framework/pull/1359.


Keyboard not registering

This seems to be the main issue with this program at the moment, I'll put it here.
The ML model successfully predicts the state of the game, but does not simulate movement at all. Accessibility and input monitoring are turned on.

Cloning AmongKey and trying to build it reveals an error in Xcode.
Cannot find 'AmongUsClassifier' in scope
This problem is in AmongKeyApp.swift and on line 146.

Cloning AmongKey and trying to build it reveals an error in Xcode.
Cannot find 'AmongUsClassifier' in scope
This problem is in AmongKeyApp.swift and on line 146.

Fixed with Commit #7e25946

I've built it myself, to see if things would change, but AmongKey is not moving among us at all.

@MintStudios https://github.com/andresavic/AmongKey/blob/292b227db19fbec7470e49d1840a6d336a05742f/AmongKey/Keymapping.swift#L12
Add at Line 12 in the Keymapping.swift print(event.keyCode)
In the console you should then see if keys are recognition in general.

Yes, the keys are being recognized. In which part of the code is the character moved (the mouse, really)

https://github.com/andresavic/AmongKey/blob/292b227db19fbec7470e49d1840a6d336a05742f/AmongKey/AmongKeyApp.swift#L85
calculates the joystick position
mouseDown and mouseUp simulates the mouse events.

@andresavic
I've put some print functions in places, and the farthest I've gotten is inside a case in in a simulation of a key press:
case (49, "Ingame"), (14, "Ingame"), (49, "Lobby"), (14, "Lobby"):
            print("Use button")
            simulateClick(pos: USE_BUTTON)
            break;

I've gotten the print function inside the simulateClick() function, but I haven't further tested it. What do you thing?

Aha, I think I have the problem. In simulateClick() the program returns.
func simulateClick(pos: (x: Int, y: Int)) {
    print("Simulating click")
    if (X == 0 && Y == 0) {
        print("Returning in simulating")
        return;
    }

@MintStudios Put a print or breakpoint in here
https://github.com/andresavic/AmongKey/blob/292b227db19fbec7470e49d1840a6d336a05742f/AmongKey/AmongKeyApp.swift#L211
Also remove "Accessibility" permission for AmongKey. Run the app from Xcode and there should be a new entry inside "Accessibility" and mark the checkmark. Then stop the app and run it again.
You can leave Among Us the whole time open inside the Freeplay.

I already have. I think the problem is that in simulateClick(), it never even gets to the code. It returns in the if statement.

Aha, I think I have the problem. In simulateClick() the program returns.
func simulateClick(pos: (x: Int, y: Int)) {
    print("Simulating click")
    if (X == 0 && Y == 0) {
        print("Returning in simulating")
        return;
    }

It should only return when X and Y are zero because then the window position is unknown. But I don't think this is the issue because you told me that the Screen capture is working fine. X and Y are set in the amongusWindow() function.

@andresavic but for some reason, it still returns there. So it must be the problem somehow.

I already have. I think the problem is that in simulateClick(), it never even gets to the code. It returns in the if statement.

Oh. Please debug https://github.com/andresavic/AmongKey/blob/292b227db19fbec7470e49d1840a6d336a05742f/AmongKey/AmongKeyApp.swift#L117
Maybe there is the issue that X and Y is never set properly .

Yep, I was just doing that now. I was printing bounds, and this is what I got:
["X": 0, "Y": 81, "Width": 788, "Height": 619]
["X": 0, "Width": 788, "Height": 619, "Y": 81]
["Width": 788, "Height": 619, "X": 0, "Y": 81]
["X": 0, "Width": 788, "Height": 619, "Y": 81]
["X": 0, "Width": 788, "Height": 619, "Y": 81]
["Width": 788, "Height": 619, "X": 0, "Y": 81]
["X": 0, "Height": 619, "Width": 788, "Y": 81]
["X": 0, "Y": 81, "Width": 788, "Height": 619]
["Width": 788, "Height": 619, "Y": 81, "X": 0]
["Width": 788, "Height": 619, "X": 0, "Y": 81]
["X": 0, "Width": 788, "Height": 619, "Y": 81]
["X": 0, "Y": 81, "Width": 788, "Height": 619]

Printing X and Y reveals this:
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0
341 44
0 0

I do my best to reproduce this issue. Even after running tccutil reset All and rebooting my MacBook Air and without granting any permission I can print valid X and Y values. Very confusing.


I don't know why the dtg it does't work for me

[TIPO-KGen]-|19:04:57|-INFO: Using transformers model KBlueLeaf/DanTagGen-delta-rev2
'HTTPSConnectionPool(host='huggingface.co', port=443): Max retries exceeded with url: /KBlueLeaf/DanTagGen-delta-rev2/resolve/main/config.json (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x000001E5B1131930>, 'Connection to huggingface.co timed out. (connect timeout=10)'))' thrown while requesting HEAD https://huggingface.co/KBlueLeaf/DanTagGen-delta-rev2/resolve/main/config.json
WARNING:huggingface_hub.utils._http:'HTTPSConnectionPool(host='huggingface.co', port=443): Max retries exceeded with url: /KBlueLeaf/DanTagGen-delta-rev2/resolve/main/config.json (Caused by ConnectTimeoutError(<urllib3.connection.HTTPSConnection object at 0x000001E5B1131930>, 'Connection to huggingface.co timed out. (connect timeout=10)'))' thrown while requesting HEAD https://huggingface.co/KBlueLeaf/DanTagGen-delta-rev2/resolve/main/config.json
*** Error running process: F:\AI\sd-webui-aki-v4.8\extensions\z-a1111-sd-webui-dtg\scripts\dtg.py
Traceback (most recent call last):
File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\transformers\utils\hub.py", line 417, in cached_file
resolved_file = hf_hub_download(
File "<enhanced_experience patches.hfmirror.huggingface_hub>", line 47, in hf_hub_download_wrapper_inner
File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\huggingface_hub\utils_validators.py", line 120, in _inner_fn
return fn(*args, **kwargs)
File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\huggingface_hub\file_download.py", line 1291, in hf_hub_download
raise LocalEntryNotFoundError(
huggingface_hub.utils._errors.LocalEntryNotFoundError: Connection error, and we cannot find the requested files in the disk cache. Please try again or make sure your Internet connection is on.
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "F:\AI\sd-webui-aki-v4.8\modules\scripts.py", line 825, in process
    script.process(p, *script_args)
  File "F:\AI\sd-webui-aki-v4.8\extensions\z-a1111-sd-webui-dtg\scripts\dtg.py", line 339, in process
    self._process(prompt, aspect_ratio, seed + sub_seed, *args)
  File "F:\AI\sd-webui-aki-v4.8\extensions\z-a1111-sd-webui-dtg\scripts\dtg.py", line 410, in _process
    models.load_model(target, gguf, device="cpu" if gguf_use_cpu else "cuda")
  File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\kgen\models.py", line 104, in load_model
    text_model = LlamaForCausalLM.from_pretrained(model_name).eval().half()
  File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\transformers\modeling_utils.py", line 2305, in from_pretrained
    config, model_kwargs = cls.config_class.from_pretrained(
  File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\transformers\configuration_utils.py", line 547, in from_pretrained
    config_dict, kwargs = cls.get_config_dict(pretrained_model_name_or_path, **kwargs)
  File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\transformers\configuration_utils.py", line 574, in get_config_dict
    config_dict, kwargs = cls._get_config_dict(pretrained_model_name_or_path, **kwargs)
  File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\transformers\configuration_utils.py", line 629, in _get_config_dict
    resolved_config_file = cached_file(
  File "F:\AI\sd-webui-aki-v4.8\python\lib\site-packages\transformers\utils\hub.py", line 452, in cached_file
    raise EnvironmentError(
OSError: We couldn't connect to 'https://huggingface.co' to load this file, couldn't find it in the cached files and it looks like KBlueLeaf/DanTagGen-delta-rev2 is not the path to a directory containing a file named config.json.
Checkout your internet connection or see how to run the library in offline mode at 'https://huggingface.co/docs/transformers/installation#offline-mode'.

Connection timeout issue. Try use a huggingface mirror to download the model.


Added new configuration

modified README.md for added new feature on year ago.

Coverage remained the same at 100.0% when pulling bc9e331408a64a8484e2594b1f17b1a4bcb45a59 on wataru0225:modified_document into 71dd596500782fd76d5a4a2b2cf2fcc705a3d9a2 on railsbp:master.


Concerns with time format in get-consumption-data response: clarification/disambiguation needed

First of all, thanks to the authors for this very useful and interesting library and API.
Perhaps I'm being dull, but I believe that there might be an issue with the format in which time is expressed, specifically in the get-consumption-data API call response.
Lets consider a response, given in the following format:
{'(...)   'date': '2022/10/01',   'time': '01:00',  (...)}
For a day inside the given period, there are several observations at the hour mark, beginning at the 01:00 mark and ending at 24:00. This makes me doubt whether "24:00" of date "2022/10/01" corresponds to:

00:00 of 2022/10/01

OR

00:00 of 2022/10/02

If the case is the former, why not use 00:00 outright? If it is the latter, the format which is being used can lead to confusion, as the date given inside the response is not the actual date the time value refers to.
Furthermore, most of time-related data types or in most databases that I know of time can only be inputted from "00:00" to "23:59", thus leading to potential compatibility issues.
I've looked through the documentation and haven't found any information regarding this issue.
Thanks in advance! Keep up the good work!

Well, this is actually how Datadis returns the data, I agree it is a horrible design but it goes as follows:
time: 01:00 -> Consumption from 00:00 to 00:59
time: 02:00 -> Consumption from 01:00 to 01:59
time: 03:00 -> Consumption from 02:00 to 02:59
[...]
time: 24:00 -> Consumption from 23:00 to 23:59
And then you have 2 exceptions caused by DST (daylight saving time):

When we set clocks back by one hour that day you have 25 measurements in a day where two of them are "time: 02:00", yes, really, and you have to assume they send you them in order.

And when we set clocks forward by one hour you have 23 measurements in a day, they skip "time: 02:00", that day the consumption from 01:00 to 01:59 goes as "time: 03:00".

Knowing this (which is from poorly to non-documented by Datadis), an API wrapper should not fix this horrible design, its job is to facilitate API calls and give the responses without manipulation. Then it is up to the program that uses this API wrapper to make the necessary transformations.

Thank you for such a quick and well written reply. It seems I was indeed being dull indeed--I lost focus on the fact that the values referred to time periods. In any case, your reply is very clarifying, thanks!
By the way, I don't know what's the contribution policy on the repository, but your reply could be part of the documentation on this particular issue almost verbatim.

By the way, I don't know what's the contribution policy on the repository, but your reply could be part of the documentation on this particular issue almost verbatim.

Anyone is open to contribute in any of my repositories 😄
Added a link to @skgsergio comment on the README


Delete our implementation of env activation

Removes our (Jupyter extension) implementation of Activation of Environments.
The Python extension API is now stable enough to remove the Jupyter extensions version of the activation code.

Codecov Report

Merging #12437 (3a246ee) into main (9a297cb) will decrease coverage by 0%.
The diff coverage is 70%.

@@           Coverage Diff           @@
##            main   #12437    +/-   ##
=======================================
- Coverage     69%      69%    -1%
=======================================
  Files        496      496
  Lines      31452    31225   -227
  Branches    4927     4896    -31
=======================================
- Hits       21967    21784   -183
+ Misses      7637     7603    -34
+ Partials    1848     1838    -10

Impacted Files
Coverage Δ

...ommon/process/environmentActivationService.node.ts
77% <63%> (+8%)
:arrow_up:

...aw/finder/contributedLocalKernelSpecFinder.node.ts
86% <66%> (+<1%)
:arrow_up:

src/platform/common/process/condaService.node.ts
75% <66%> (+6%)
:arrow_up:

src/kernels/raw/finder/jupyterPaths.node.ts
77% <78%> (+<1%)
:arrow_up:

src/kernels/installer/condaInstaller.node.ts
81% <100%> (ø)

...form/common/process/internal/scripts/index.node.ts
21% <0%> (-8%)
:arrow_down:

src/platform/common/process/proc.node.ts
75% <0%> (-6%)
:arrow_down:

src/platform/common/utils/misc.ts
82% <0%> (-4%)
:arrow_down:

src/platform/common/application/workspace.base.ts
74% <0%> (-3%)
:arrow_down:

src/kernels/errors/kernelErrorHandler.ts
53% <0%> (-3%)
:arrow_down:

... and 10 more


[WIP] Allows to refer a Task from different namespace in PipelineRun 🌳🕊

Changes
Sometimes users don't want to copy-paste Task from one namespace to others.
One such use case could be enabling Task from Task catalog. Every time
duplicating the same Task in more than one namespace could become
maintenance nightmare.
This patch allows referencing a Task from a different namespace in TaskRun's
and PipelineRun's spec.TaskRef`. Hence this would allow the user to install the
Task once in the namespace. (Now not sure about its overlap with ClusterTask)
Fixes https://github.com/tektoncd/pipeline/issues/1409

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

Reviewer Notes
Adds the new field in TaskRef fied in PipelineTask and TaskRun specs.
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Users can refer a Task from different namespace in PipelineRun anaskRun spec.
e.g.
apiVersion: tekton.dev/v1alpha1
kind: Pipeline
metadata:
  name: echo-hello-world-pipeline
  namesapce: default
spec:
  tasks:
    - name: hello-world
      taskRef:
        name: echo-hello-world
        namespace: other

Closing this work, as it's not looking the right way to address this issue

@hrishin could you please shed some light into the right way of addressing this issue. i.e I want to share a task definition with few namespaces and not to the entire cluster?

@sthaha we should continue discuss on the issue (#1409). This approach has some issues security wise (or at least rbac related). To bypass those, we may need to look into impersonation, etc… but overall, one of the feedback from the working group call was that it may add more complexity for something that could be handle differently.  Another worry was on updates on the Task definition — if the refered task gets updated, it affect all the TaskRun/Pipeline/… that depends on it, and might break something, where a copy approach does not.
One of the approach that could fix this would is something close to the proposal 1 in the Pipeline Catalog Integration proposal, aka being able to refer a task from "outside" (catalog, …) and thus, this would be copied in the cluster.


Hot reloading not working with React Loadable example?

I've cloned the razzle source and tried running the with-react-loadable example, but it seems like HMR no longer works. I'm not sure what the problem is here, does anyone have an idea how to get it working again?

@olegreznichenko I'm also running into this issue. So basically just changing to koa will solve HMR?

I was able to make HMR work with the with-react-loadable example @dbbk where you able to make it work?

I could not make it work too with a fresh install.

I also did the same thing @hrasoa!

if (module.hot) {
  module.hot.accept('./App.jsx', () => window.main());
}


IntelliJ IDEA complains about not being able to resolve Lumo custom properties

When you use --lumo-* custom properties in a CSS file in IntelliJ IDEA (at least in Ultimate edition), it will highlight the variable with a red underline and a message like:

Cannot resolve '--lumo-success-color' custom property

I did a quick test by manually duplicating the variable declarations to a css file within node_modules/@vaadin/vaadin-lumo-styles and that seems to be enough to let InteliJ properly discover the variables and does not complain about their usage in your project anymore.
I propose that all the styles in this repo would be refactored to *.css source files (to resolve this issue) and then those sources can be used in a build step to generate ES modules (or HTML imports) as needed so that the CSS code doesn't need to be duplicated to several files.
This idea is also mentioned as part of issue #90 but these are 2 different issues which may be possible to solve in different ways too.

If/when this is implemented, it should also be done for vaadin-material-styles (or issue created there).

As a workaround I created this gist which contains a copy of all the Lumo CSS custom properties in a plain CSS file. Just save this as a CSS file somewhere in your project and IntelliJ IDEA should be able to autocomplete the Lumo custom properties and not complain about them being unresolved.


Add kafkactl CLI tool

Thanks a lot! @hpgrahsl and I are planning to do an update to the landscape soon and will get back to this one too.


[DNM] test run

Testing for https://github.com/apple/swift/pull/65459 if it has an issue on main as well

@swift-ci please test Linux


something went wrong, no devices found

Does not work.
s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun broadlink-ac-mqtt (no readiness notification)
s6-rc: info: service legacy-services successfully started
Starting Monitor…
Stopping
something went wrong, no devices found
Starting Monitor…
Stopping
something went wrong, no devices found
Starting Monitor…
Stopping
Here is my addon configuration file:
service:
daemon_mode: true
update_interval: 10
self_discovery: true
bind_to_ip: false
mqtt:
host: addon_core_mosquitto
port: 1883
client_id: ac_to_mqtt
user: mqtt-user
passwd: “mypassword”
topic_prefix: /aircon
auto_discovery_topic: homeassistant
auto_discovery_topic_retain: false
discovery: false
devices:
ip: <IP_ADDRESS>
mac: c8f742348bec
name: Living Room AC
port: 80
ip: <IP_ADDRESS>
mac: a043b008e504
name: Office AC
port: 80
ip: <IP_ADDRESS>
mac: a043b0088f14
name: Home Cinema AC
port: 80

self_discovery: false at the service section should fix that problem


Update README.md

Explicitly describe how the API is exposed as a standalone module with CommonJS.

This text is replicated in all the other D3 modules, so if we change the text here I’d like to change the text everywhere else, too. And since that’s cumbersome, I’d like to understand exactly what the confusion was here that lead to this pull request, so that we can make sure the text is as clear as possible before changing all of it. Can you elaborate more on how the CommonJS usage was unclear?
My take is that the need to require("d3-request") should be self-explanatory given the name of this package and the npm install d3-request statement already in the README. What’s less clear is whether that require returns an object with the exported symbols (it does), or whether it decorates a d3 global (it doesn’t) as might be inferred from the names of the static methods in the API reference.
Not that it justifies confusing documentation, but I wasn’t overly worried about the confusion because running the require in a Node console reveals the answer.
Also, a subtle issue here is that this documentation must also serve (and even primarily serves—given that I expect more people to use the default build of D3 than this module directly) users of D3’s default build. Previously, I documented the API as d3_request.requestJson etc., which makes the expected usage of this module directly more obvious. But, it’s unacceptably confusing to users of the D3 default build. (And, it’s more verbose.)
A possibility I considered was to omit the static prefix (“d3.”) entirely, and just document a requestJson symbol. That’s more consistent with how ES6 imports work. But it’s also a little unclear for users of the default build, and also makes the distinction between static methods (such as d3.requestJson) and instance methods (such as request.get) less apparent.
(Also, this is why I recently changed all the exported symbols in each D3 module to be consistent with their names in the D3 default build.)

Not that it justifies confusing documentation, but I wasn’t overly worried about the confusion because running the require in a Node console reveals the answer.

And that's exactly what I did to find out the API :) so maybe it's not that important of a change.
For context, I was a bit confused with how the require('d3-request') connected to the docs. Even though I used an example of requireJson in my diff, this was the usage I initially attempted:
var request = require('d3-request');
request(url).get(cb);

but what I really needed was:
var request = require('d3-request');
request.request(url).get(cb);

Maybe the right approach is to wait and see if others report similar confusion.

Closing, but we can revisit if other people are confused. It’s hard to have documentation that serves all JavaScript environments well…


Allow Consul api to set default config for addr

As can be seen in https://github.com/hashicorp/consul/blob/91ee7990ccf27ab7fccff746f8df0df65c3c583d/api/api.go#L390 the API also defaults to localhost:8500, however it can also use the environment variable CONSUL_HTTP_ADDR which is useful when fabio is run with nomad.
This change makes sure that the existing default stays working, but it now works better by default in more situations
Related: #773

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@pingiun I think this is a good change, sorry this has taken so long to get back to you.  But if you can get this rebased against master, i'll try to sneak this in with the next release which will likely happy tomorrow.

@nathanejohnson good to hear! I switched from fabio to traefik myself but I'm happy to help out

So the config load tests are failing, I will have to postpone this for a bit when I have more time to dig in, but I believe it's in the parseScheme method for parsing the consul address.


Several Issues with the KFServing MMS Triton README

/kind bug
What steps did you take and what happened:
Following the steps in the README is not a seamless experience. It seems like several commands/instructions are outdated.

README mentions “ You must set Triton's multiModelServer flag in inferenceservice.yaml to true to enable multi-model serving for Triton” -- but MMS only worked for me when the multimodelserver flag was set in the kfserving.yaml file used in installation (eg. install/v0.5.1/kfserving.yaml).

The README mentions “Setup Minio for storing the models as currently model agent sidecar only supports S3 protocol.”, but it looks like gs:// protocol is also supported now as I was able to specify model location in a GCS bucket.

In minio.yaml, the apiVersion is specified as extensions/v1beta1. However, that gives an error:
"error: unable to recognize "minio.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"

From https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ :
“Deployment in the extensions/v1beta1, apps/v1beta1, and apps/v1beta2 API versions is no longer served. Migrate to use the apps/v1 API version, available since v1.9.”
So, in minio.yaml the apiVersion should be updated
apiVersion: extensions/v1beta1 → apiVersion: apps/v1

The README mentions “Setup Minio for storing the models as currently model agent sidecar only supports S3 protocol.”, but it looks like gs:// protocol is also supported now as I was able to specify model location in a gcs bucket

Copying cifar10 model to minio gives the following error:
mc cp -r cifar10 myminio/triton/torchscript
mc:  Failed to copy cifar10/1/model.pt. Bucket triton does not exist.
mc:  Failed to copy cifar10/config.pbtxt. Bucket triton does not exist.
We may need to create a Triton bucket before copying

The command to copy the simple_string model to mc is missing the destination argument.
gsutil cp -r gs://kfserving-samples/models/triton/simple_string

It looks like the model “gs://kfserving-samples/models/triton/simple_string” has moved, or does not exist at that path.
There is a simple_string model at "gs://kfserving-samples/models/tensorrt/simple_string/” -- is this the one to use in this example?

In the section to Deploy the "Cifar10 Torchscript Model", the command provided is the one to start the InferenceService, instead of specifying a TrainedModel:
kubectl apply -f multi_model_triton.yaml
should be
kubectl apply -f trained_model.yaml

For the simple_string Tensorflow model, the framework specified in it's trained_model2.yaml is "pytorch"

Other Suggestions:

It would be great to indicate that the following command should be run from another terminal.
kubectl port-forward $(kubectl get pod --selector="app=minio" --output jsonpath='{.items[0].metadata.name}') 9000:9000

To make the example simpler, is it possible to directly use gs:// instead of minio s3?

What did you expect to happen:
The list of steps provided for the examples should execute without any errors to provide a seamless experience to new users.
Environment:

Istio Version: 1.9.0
Knative Version: 0.18.0
KFServing Version: 0.5.1
Kubeflow version: -
Kfdef:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube version: 1.17.1
Kubernetes version: (use kubectl version): Client: v1.20.4, Server: v1.20.2
OS (e.g. from /etc/os-release): Ubuntu 20.04.2 LTS (Focal Fossa)

Thanks @shashank3959! Will update the doc to use gcs which is much easier for the example.


Dates for checkins & checkouts only

Is your feature request related to a problem? Please describe.
I want to use the Litepicker for a holiday home where there are three options for a specific date:
Checkin & Checkout, Checkin only, Checkout only.
I tried to implement this functionality with the lockDaysFilter option, but it's not the best user experience to get a warning after trying to select a date.
Describe the solution you'd like
The best solution (for my situation) would be three arrays (lockDays, noCheckinDays, noCheckoutDays), but I know that's too specific.
Another good solution would be a live update of the is-locked class to directly show locked days when a specific date1 is selected.
Describe alternatives you've considered
I can use the tooltip event to "warn" the user.
Additional context
If supporting the project would speed up the implementation of a solution, I would be happy to help.

I tried to implement this functionality with the lockDaysFilter option, but it's not the best user experience to get a warning after trying to select a date.

Could you show what you have tried?

I only made a quick test with this code:
lockDaysFilter: function(checkin, checkout, pickedDates){
    if (checkout && checkout.getDate() == 10) {
        true
    } else {
        false
    }

It correctly disallows selecting date2 if that's the 10th, but I get no visual feedback after selecting date1. I just get the error:range feedback after I tried to select a wrong date2.
I found this calendar which initially marks checkin days and marks possible checkout days when date1 is selected. For example: The 16th can't be selected for date1 here:

After I click on the 8th, the 16th can be selected for date2. (There is also some minStay going on.)

It correctly disallows selecting date2 if that's the 10th, but I get no visual feedback after selecting date1. I just get the error:range feedback after I tried to select a wrong date2.

I don't understand your example very well, what is the check-in date in your example? Why disallow 10th ?

After I click on the 8th, the 16th can be selected for date2. (There is also some minStay going on.)

So you want to pick only 7 days?
Or could it be in the range of 1 to 7 days and no more?

After I click on the 8th, the 16th can be selected for date2. (There is also some minStay going on.)

Can you provide a demo on jsfiddle.net?
And great design! Can you also share this in the jsfiddle.net?

I had to implement the same feature: The allowed check-in dates are different to the check-out dates: Only few dates may be allowed for check-in (like only every monday on summer season).
I implemented this with Litepicker by checking whether no date or the start date was selected. When no date was selected, the check-in date restrictions are enforced, when a start date has been selected, the check-out date restrictions were applied instead.
Related: https://github.com/wakirin/Litepicker/issues/116


Allow full screen

Allow full screen, with all the correct scailing and taking different screen sizes into account that comes with that.

Added basic toggling. Probably need to do more work on it, to make it re-set the resolution to whatever's currently playing, instead of expanding the viewport to a wider space. Currently starts running slowly once I zoom out and get too much on screen.

this thread discusses re-setting the height and width on toggling fullscreen, which is what I think I want to be doing
https://love2d.org/forums/viewtopic.php?t=9448

On some thought, prefer opening up the range of view on fullscreen instead of streaching out what's there. Means people with more powerful computers can fullscreen and see more and people with slower conputers can keep it windowed. Need to make sure levels still make sense with larger field of view though.


Users SABT use  “run-docker-validator-network" script that works

Expected Behavior
Fix or remove it from the running-a-validator.md file.
Current Behavior
The “run-docker-validator-network.sh” does not work / bugs.
./run-docker-validator-network.sh: /usr/bin/bash: bad interpreter: No such file or directory

Shebang should be #!/usr/bin/env bash instead of #!/usr/bin/bash

Does not support manually running individual commands:

./run-docker-validator-network.sh pull (OK)
./run-docker-validator-network.sh accounts (OK)
./run-docker-validator-network.sh deploy (FAILS with ./run-docker-validator-network.sh: line 153: CELO_PROXY_ADDRESS: unbound variable)

./run-docker-validator-network.sh pull,accounts,deploy,run-validator,status fails if screen command is not installed

fixed in #1934


Lack of updates and tut for enabling your own visual to make custom extentions

like the title says there is a lack of this i hope you could do some work for this and make some stuff of this clear so that we could work this out, your bot is nice but needs more love from you and from a community.
Chao, The Roaring Lion (AKA berrylee32)

eh is there still support for this?

Not for some time, I have been supporting it for months with thousands of users and I barely got any support back. To keep making free projects and maintaining them support via donations is necessary.
I might come back to this project some day, but I'm currently working on some other things, at the moment that'd be my small pictionary game.


README cleanup

Thanks for cleaning up! Why did you remove the ToC, though? I kind of liked it.

Github has the menu already (top left), and it didn't seem to work on Docker Hub.
Happy to revert if you prefer to have it still.

Oh, I see that this menu is more condensed.
Will revert.

I actually never realized that built-in table contents before, thanks for pointing me there 😄. In that case I'd actually want to remove the one in the README, so feel free to revert your revert again and then just merge yourself :+1:


For Windows WinUI3 windows are always "inactive"

Describe the bug
Unable to scroll any scroller control using mouse wheel if mouse option to scroll inactive windows is OFF.
Steps to reproduce the bug

Go to Windows Mouse settings
Disable scroll of inactive windows on mouse over
Open WinUI 3 Gallery App
Nothing will scroll using mouse wheel, even if focused

Expected behavior
The same that happens for any other software: scroll working when window is active.
Screenshots
No response
NuGet package version
1.1.3
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 21H2 (22000)
IDE
Visual Studio 2022
Additional context
No response

Assigning this over to you @MikeHillberg since this sounds like a WinUI 3 bug. Feel free to move the bug over to the WinUI3 repo.

I'm able to replicate this as well. It's been reported for the PowerToys UIs that use Windows App SDK: https://github.com/microsoft/PowerToys/issues/20961


Next Cache never expires with Pages Router

Hi,
I'm currently attempting to use ISR, without on demand invalidation, where my pages are supposed to expire after 10 minutes.
I can see the cloudfront cache expire and it coming to next, however next never seems to regenerate the page no matter how long I wait.
Deleting all files with the _cache/ prefix in the app bucket seems to force this regeneration to occur.
Additionally, there never seem to be any entries added to the dynmaodb table.
On next 13.5.6 and opennext 2.3.5

App router or Page router ? Page router don't use dynamodb
How are you deploying ? With sst ?
What are the X-Nextjs-Cache, Cache-Control and X-Cache headers for your stale pages ?
You're not building on windows ?

Yeah deploying via SST.
x-nextjs-cache: STALE
Cache-Control: s-maxage=2, stale-while-revalidate=2592000
X-Cache: RefreshHit from cloudfront
Age: 92
Have deployed from local built on windows and from pipeline built on ubuntu, both behave similarly.

From: conico974 @.>
Sent: Wednesday, 20 March 2024 18:01
To: sst/open-next @.>
Cc: Matt Ekron @.>; Author @.>
Subject: Re: [sst/open-next] Next Cache never expires with Pages Router (Issue #389)
Page router don't use dynamodb
How are you deploying ? With sst ?
What are the X-Nextjs-Cache, Cache-Control and X-Cache headers for your stale pages ?
You're not building on windows ?
—
Reply to this email directly, view it on GitHubhttps://github.com/sst/open-next/issues/389#issuecomment-2009930062, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVKHFLGF52QUTOZEKOLKIZ3YZGXHDAVCNFSM6AAAAABE7SQ4H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBZHEZTAMBWGI.
You are receiving this because you authored the thread.Message ID: @.***>

Try adding x-prerender-revalidate to the list of allowed cache policy headers in cloudfront.
There is a PR for that already https://github.com/sst/sst/pull/3713
You can do it in the aws console for testing.
FYI open-next doesn't work on windows https://github.com/sst/open-next/issues/385
If this doesn't solve the issue, you'll need to create a minimum repro

just chiming in. PR is merged. 2.41.3 should have x-prerender-revalidate included in the allowed headers.

I'm going to close this old issue.
If that's still an issue, reopen and provide a reproduction


Improve structure for "Getting Started" section

Related to #3687. Suggesting new structure for "Getting Started" section, which is intended as a starting point for Modin users.
Getting Started/
├─ *Quickstart Guide (minimal install & setup script, 1-line replacement, mini-benchmark to demo speedup, same as updated README)
├─ Installation (pip, conda, source)/
├─ Using Modin/
│  ├─ Using Modin in a cluster
│  ├─ Using Modin locally
│  ├─ *Example (link to 1-2 notebook ex of how Modin is used for XYZ)
│  ├─ *Tutorial (link to tutorial notebooks)
│  ├─ FAQs
│  ├─ Troubleshooting
├─ Why use Modin?/
│  ├─ Out of Core in Modin
│  ├─ Modin vs. pandas
│  ├─ Modin vs. other distributed dataframes (disclaimer/overview)
│  ├─│  ├─ Modin vs. Dask DataFrame (#3779)
│  ├─│  ├─ Modin vs. Koalas

* indicates that the documentation page would have an associated notebook.
Currently, the tutorial notebooks are here, which is not linked in the current docs (see #2412).
Note that this PR will not include new files for:
│  ├─ FAQs
│  ├─ Troubleshooting

given that it will be part of #2635.
@jeffreykennethli @devin-petersohn: Would love to get thoughts on this structure before implementing this change.

In progress:

[ ]  Quickstart Guide
[ ]  Quickstart Guide (ipynb)
[ ]  Installation
[ ] Using Modin
[ ] Notebook Example (ipynb)
[ ] Link to Tutorials

Regarding the "Getting Started" Structure, I think "Using Modin locally" belongs above "Using Modin in a cluster", given that cluster usage is under active development (not as mature). Even Examples and Tutorial could belong above "Using Modin locally", so something like:

Example
Tutorial
Using Modin locally
Using Modin in a cluster

Under "Why Use Modin", I suggest:

Modin vs. pandas
Out of Core in Modin
Modin vs. other

PR #3816 updates the getting started FAQ and is related to this change.

Thanks @jeffreykennethli, agreed that this ordering makes a lot more sense!

I think it would be great to have a similar documentation structure to pandas (see here).
.getting_started/ as @dorisjlee proposes
    .quick_start (minimal install & setup script, 1-line replacement, mini-benchmark to demo speedup, same as updated README)
    .installation (pip, conda, source)
    .why_use_modin (comparison with other distributed dataframe implementations)
.usage_guide/
    .examples (what we have now) # this should include not only Modin operation pipeline, but and how much faster are the operations relative to pandas ones.
    .tutorials (what we have now)
    .optimization_guide/notes (recommendations to users on how to better organize their pipeline, perform an operation, etc.)
.developer_guide # as it is now
.supported_apis # as it is now
.advanced_usage # should probably go in usage guide
.contact # as it is now

@modin-project/modin-core, @modin-project/modin-omnisci, @modin-project/modin-contributors, thoughts?

Many users only visit one or two pages in our current docs on https://modin.readthedocs.io/en/stable/. I don't like the idea of having to navigate two pages to see quick start, or examples/tutorials. Ideally the most critical doc pages would be at the top of the home page for easy accessibility:

I think we should choose what links are at the top of the page first.

@devin-petersohn, our documentation is growing and put everything onto one page probably doesn't look good. In the near months we likely want to add comprehensive examples, which show Modin usage, performance against to pandas, etc., as well as some optimization notes regarding improving/accelerating a generic query pipeline (like put less NPartitions number in case an operations is performed via map operator for a wide dataframe since there is excessive amount of remote partitions, which is much greater than the number of CPUs) and specific operations (like for inner join recommend using a larger dataframe as a left operand and a smaller dataframe as a right operand). I think usage_guide page looks as a good candidate where we would put all examples, tutorials, optimization notes/guide, etc. Does that make sense?

I agree with @YarShev that it might not be a great idea to have too many things on the header, but as @devin-petersohn  mentioned, for something very important like the quickstart, it would be worth putting at the top. Everything else like example and tutorials, it would be worth linking to both in the index.rst (home page) and README, while living nested within the user guide. The navigation to these pages would also be helped if we added a TOC tree on the left panel, as described in #3763.

I issued a draft of the usage guide in #3864. Comments/thoughts on improving/expanding it are welcome.

I issued a draft of the usage guide in #3864. Comments/thoughts on improving/expanding it are welcome.

Thanks @YarShev. Is the usage guide intended to be ready by advanced users of Modin? i.e., after reading Getting Started. If so it would probably to rename this advance usage?

Re: #3864
I like the addition of a section that explains how to use modin better that doesn't dive right into the advanced or experimental features, and I think Usage Guide is a good name for it. It makes me think a lot of the Advanced Features section could be folded into Usage Guide under a usage_guide/advanced section.
Any features in Advanced Usage we deem to be too experimental can go under a usage_guide/experimental.

order it to be before the "Developer" section?

Agree with this - I think the ordering should be:
Getting Started
Usage Guide
Supported APIs
Developer
Contact

I like the addition of a section that explains how to use modin better that doesn't dive right into the advanced or experimental features, and I think Usage Guide is a good name for it. It makes me think a lot of the Advanced Features section could be folded into Usage Guide under a usage_guide/advanced section.

@dorisjlee, @jeffreykennethli' comment makes sense to me.

Agree with this - I think the ordering should be:
Getting Started
Usage Guide
Supported APIs
Developer
Contact

I would rename Developer section to Developer Guide to resemble pandas docs.

This new organization sounds good!

Several thoughts of mine (maybe less for structure but more about content):
https://modin.readthedocs.io/en/latest/getting_started/using_modin.html#apis-supported - not quite clear what APIs are mentioned here
https://modin.readthedocs.io/en/latest/getting_started/using_modin.html#advanced-usage-experimental - this probably should go to our new Advanced usage section

Probably it's worth to structure Getting Started section somewhat similar to Pandas' one
i.e. reduce installation section leaving only main installation channels, add user-level description of Modin as we agreed (some content could be taken from https://github.com/modin-project/modin/blob/master/examples/tutorial/tutorial_notebooks/introduction notebooks) and put links to other noteboosk with more advanced Modin usage (eg along with xgboost or scikit-learn)


chore: bdd-spring-1580728322 to 0.0.1

chore: Promote bdd-spring-1580728322 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Make Local instance for IOLocal public and add law tests

Closes #195
This PR makes the Local instance for IO (backed by a IOLocal) public so users don't have to reimplement it themselves. Hopefully it will be added to Cats Effect but until then users can use this.

Anything I can do to help push this along?

Sorry, I had this open in four browser tabs.  I'm a mess.


Join Open Source Pledge

https://getrector.com/blog/rector-is-joining-open-source-pledge
https://osspledge.com/join/

while I appreciate the concept this project has approximately zero paid developers :)


Add read-only feature

When read-only is true, the cache is only restored and not saved. This allows for sharing the cache with multiple steps even if these steps may change them. I tried to use inputs.read-only in the post-if since just starting the post-job takes precious seconds, but that always seems to be null.
Available as martijnhols/cache@read-only
Fixes #350, #334 and maybe #210

Does this PR have a future or is it best closed?

Seeing as my PRs to the GitHub repos have been ignored for almost a year, I closed all of them. To clean up my workflows I have decided to work on a fork instead with an (in my eyes) cleaner solution. See the repository for documentation: https://github.com/MartijnHols/actions-cache Here is what sharing cache across jobs would look like:
name: Build app

on: push

jobs:
  install:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2

    - name: Restore "node_modules" from cache
      id: cache
      uses: martijnhols/actions-cache/restore@main
      with:
        path: node_modules
        key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock', 'patches') }}
        restore-keys: ${{ runner.os }}-node_modules

    - name: Install dependencies
      if: steps.cache.outputs.cache-hit != 'true'
      run: yarn install

    - name: Save "node_modules" to cache
      if: steps.cache.outputs.cache-hit != 'true'
      uses: martijnhols/actions-cache/save@main
      with:
        path: node_modules
        key: ${{ steps.cache.outputs.primary-key }}

  build:
    needs: [install]
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2

    - name: Restore "node_modules" from cache
      uses: martijnhols/actions-cache/restore@main
      with:
        path: node_modules
        key: ${{ runner.os }}-node_modules-${{ hashFiles('yarn.lock', 'patches') }}
        # Fail when the cache could not be found (this should never happen unless you have a misconfiguration)
        required: true

    - name: Build app
      run: yarn build

Hey all, 👋🏽
We have created a discussion with a proposal that will solve this problem, do let us know your feedback, thanks 😊


Unable to install HockeySDK.WP 4.1.5 into a Windows Phone 8.1 project in a PCL

When trying to install this I get "Install-Package : Could not install package 'HockeySDK.WP 4.1.5'. You are trying to install this package into a project that targets 'WindowsPhoneApp,Version=v8.1', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.". I know it is something to do with the targets but am unsure on what to edit in the package.

@geekatwork It looks like a very old issue. Is this issue fixed or are you still having issues with the installation? I'll close the issue for now but please feel free to open it again if you'd like any help. Thanks!


Automatically detect new test file in test explorer in Python

Feature: Automatically detect a new test file in test explorer
Description
how Explorer defected the new file (paste the new file in the folder) in VS code , the same behavior will implement in test explorer(detect only for a new test file) in VSCode , its good

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

Thanks @karthiknadig , one more I found , If am adding the new test file , Its not reflecting in Test explorer, after restarting its working fine

This is solved in our upcoming test provider.

Hey @brettcannon , I think this needs to be tweaked. As there's no way to run all the tests anymore in a single file from a click. I ran into this issue in my own code. And judging by the gif above, it seems like its not just me. There should be a play button to indicate running all tests, like we could do before with code lens.

@shanewazabbas please open a separate feature request.


chore: Updating to daily runtime for R12 development

Description
During R12 development on the main branch, we should pick up the daily builds of the runtime.  This will help us discover issues earlier.
This also updates to the latest bf-generate library as it uses the latest runtime.
Task Item
#minor
Screenshots
N/A

Coverage remained the same at 55.065% when pulling 74fd06dbab9757cbc61fa00dec887fcad76d29cb on gcox/update-to-daily into 2d28769fb2e59b13368858c762812d0a5e06fd14 on main.

Coverage remained the same at 55.065% when pulling 74fd06dbab9757cbc61fa00dec887fcad76d29cb on gcox/update-to-daily into 2d28769fb2e59b13368858c762812d0a5e06fd14 on main.

@GeoffCoxMSFT do we have plans to move bf-generate to npm? which is probably our last dependency to myget today.

@GeoffCoxMSFT do we have plans to move bf-generate to npm? which is probably our last dependency to myget today.

I found the update-schema script is broken after updating dependencies to 4.12.0-daily...

I found the update-schema script is broken after updating dependencies to 4.12.0-daily...


Link in project secction

Hi, i can't undestand how to insert a url link in projects tagline (in config.toml), i've tried to modify projects.html in layouts/partial  or use differt syntax.

Hi,
urls in the tagline are currently unsupported, but you could try to implement support for yourself by overriding projects.html in the site project (layouts/partials/projects.html) with something like the following:

{{ i18n "projects" }}

                                {{ range .Site.Params.projects.list }}

{{ .title }}

{{ .meta }}

{{ .tagline | safeHTML }}

                                {{ end }}

and then you can add a 'some site' to your tagline. I will try to add support for this in the next version which is coming soon, but until then, this may help you.
Let me know how it goes.
J.K.

Ok i'll try, what sintax i have to use in config file for links?

@Idle42  Just insert the link how you would in an html document (within  tag). More info here:  https://gohugo.io/functions/safehtml/


report holidays in native language as well (not just english)

i'd find it useful if names of german holidays could also be retrieved in german, slovak holidays in slovak, etc. currently all holidays are in english.

The suggestion for .po file might do the trick.
But how would you rename all 'general' holidays that apply to many calendars, such as all the Chrisitan holidays etc?
I'm also afraid that it might conflict an enhancement suggestion, such as #279

I believe this is user's responsibility. Just use gettext. I18n and l10n is serious business, with many gotchas that are hopefully tackled by adequate libraries. It's not Workalendar's job.
In this space, there's a lot of possible user intents that this lib cannot sort out. What if I want to display German holidays in Slovak language? What about multi-lingual countries that (almost) share a single calendar? ...and so on.
At most, Workalendar could provide '.po' files with local translations for every possible holidays in every calendar (languages × holidays. Yeah, it's quadratic), but it's a lot of translation work, maintenance for a feature that is IMHO not really related to the lib's domain.
My suggestion, would be: call cal.holidays(20xx) for the next 50 years and add the resulting English holiday names your projects .po files and you're good for the rest of your career.

I'm not sure I agree. Providing each name in local language + english would useful for a vast majority of cases. What really is debatable (and it doesn't even mean I'm against it) is whether we should support cross translations that are neither in English nor in one of the country's languages.
You're asking interesting questions but with the subtext that it's too complex to handle. I think these are interesting questions to ponder on, and we can find a satisfying solution.


@Wither on Optional field triggers OptionalEquality on error-prone

Example:
import lombok.Value;
import lombok.experimental.Wither;

import java.util.Optional;

@Value
class Example {

    @Wither
    Optional<String> field;
}

This will trigger OptionalEquality rule. Culprit code is (after delomboking):
   public Example withField(Optional<String> field) {
        return this.field == field ? this : new Example(field);
    }

In addition error prone itself will crash due to IllegalArgumentException. But this is more on them I think, it is tracked here: https://github.com/google/error-prone/issues/447
So far only workaround for that is to @SuppressWarnings("OptionalEquality") every time @Wither is used for Optional field or to disable rule all together.
It would be nice if we could automatically add @SuppressWarnings("OptionalEquality") to all wither methods (or just ones for Optional fields).

The line lombok.addLombokGeneratedAnnotation = true in lombok.config should add @lombok.Generated to all generated methods.
Error-prone should ignore such methods (unfortunately, javax.Generated is unusable).

I'm unsure about both points, but I'm convinced, they're the way to go (to be implemented if not done already). Suppressing a single warning is probably too specialized. Adding not needed or not understood  @SuppressWarnings triggers warnings in Eclipse, so it's a fail.
The code as generated uses reference equality intentionally. This has been discussed a lot already.


Wordpressnginx

This changes out Apache for Nginx, and builds Wordpress on top of the LEMP stack.

For readability, let's remove the comments from the Nginx configuration file.

This PR is working now


multiselect not working

Help me, multiselect field not work correctly locally as it appears here: http://demo.onokumus.com/metis/form-general.html

@TojoAntonio
Which one does not work?

thanks for your answer!
not work: 2-3-4-5

@TojoAntonio
Are you trying to make assets work in file or host mode?

I suppose host mode. I followed the building:
$ git clone https://github.com/onokumus/Bootstrap-Admin-Template.git yourfoldername
$ cd yourfoldername
$ npm install
$ npm run build
$ grunt serve

@TojoAntonio
npm install
bower install
npm run build
grunt serve

yes, I've done early

@TojoAntonio
Ok.
Open form-general.html in dist folder with your favorite editor.
change that following rows:
#24
<link rel="stylesheet" href="assets/lib/jquery-inputlimiter/jquery.inputlimiter.1.0.css">

#2083
<script src="assets/lib/jquery-inputlimiter/jquery.inputlimiter.1.3.1.min.js"></script>

#2084
<script src="assets/lib/jQuery.validVal/js/jquery.validVal.min.js"></script>

it works!!! thanks a lot!!! (y)