Small contribution to a good package

Hello. I found your package quite useful, so I decided to contribute to it by fixing the English in both "README.md" and code sample, fixing a minor bug, and developing the example to cover all 3 methods. hope you find it appropriate and acceptable.
Good luck!

Some of these were auto-generated by IDE, I will resolve them.

Hello
I put some comments for you, please fix them and let me know to accept your
merge request.
Thank you.
On Fri, Dec 8, 2023 at 5:12 PM Soroush Beigi @.***>
wrote:

Hello. I found your package quite useful, so I decided to contribute to it
by fixing the English in both "README.md" and code sample, fixing a minor
bug, and developing the example to cover all 3 methods. hope you find it
appropriate and acceptable.
Good luck!
You can view, comment on, or merge this pull request online at:
https://github.com/ms-dehghani/flutter-stack-toast/pull/1
Commit Summary

54cbdc9
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/commits/54cbdc912c651a91f5012a7a07b6b2f39aa7fad1
fixing yellow underline bug and rewriting the sample text
ab83ac7
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/commits/ab83ac7d494c27c92ebd07f33c6fd6c4ec404b37
adding 2 more examples and fixing typos/improving grammar
e264722
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/commits/e264722150d84948ff675f36b9b9361a882108a8
some code refactor and rewriting README.md

File Changes
(7 files https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files
)

M README.md
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(18)
A android/local.properties
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-3ec8252570c7a854d8ec7d1dfe8c9b57d6cf752e819315050b13c32d2bf92f9e
(2)
M example/lib/main.dart
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-72fd825ad17ce7800a2078e06f0dff1e12836ee59760465e78d9a5d222cebd15
(70)
A ios/Flutter/Generated.xcconfig
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-66c8cf9d27a0dde0363c01f1a8db459e89d777865d45e4965e76c043ac9a0ed5
(14)
A ios/Flutter/flutter_export_environment.sh
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-d9be9fda98de35cf918bc8639162e48551fdd4cc2435b39292fb7ceefd479dd4
(13)
M lib/src/lib/stack_toast_view.dart
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-c3e38e56d4084af4407063d72842187f4cf8cdfbb5c430a83e49d28d1bbd26d3
(2)
M lib/src/stack_toast.dart
https://github.com/ms-dehghani/flutter-stack-toast/pull/1/files#diff-64abb7b481776064e7575c6828546ca68999c2b0a0a9b488c83a0e139ba75234
(10)

Patch Links:

https://github.com/ms-dehghani/flutter-stack-toast/pull/1.patch
https://github.com/ms-dehghani/flutter-stack-toast/pull/1.diff

—
Reply to this email directly, view it on GitHub
https://github.com/ms-dehghani/flutter-stack-toast/pull/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFT52I3J4SPW5GQEY7NQCF3YIMKKTAVCNFSM6AAAAABAMVU2TCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTENRXHA2TMNI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Patchelf install

Addresses issue #21.

FWIW, I looked into using BinDeps and while I could get it to compile patchelf from source, there doesn't seem to be a way of finding the built executable for installation.

Lgtm thank you, I did also try Bindeps, but did not manage.


remove invalid entry

What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:
remove invalid entry

Let's try now. @all-contributors add @hichemfantar for contributing in code

fixed by #1187

Let's try now. @all-contributors add @hichemfantar for contributing in code


Util function to solve className issue

This solves the issue #613 by using clsx to handle passing the className. It ensures no blank space or undefined className is passed. The files have been manually checked after the script did the migration. ** The tests would fail because main has some issues **. The tests failing are not related to components changed. Primitives have not been changed

Summary by CodeRabbit

New Features

Added the clsx utility for improved conditional class name management across multiple components.

Bug Fixes

Enhanced class name handling in components, ensuring cleaner and more maintainable code.

Documentation

Updated import statements to include clsx in various components for clarity on class name management improvements.

This wont be merged. Need to make batches of 10 -15 components


feat: Deploy to AWS S3

🤞

[BOT] Preview available: https://embed.typeform.com/8390efed58e1a80b58b9d9da8bc39a14a8de75f6/embed.js

Sorry for the spam. AWS test deploy successful: https://embed.typeform.com/next/embed.js (only 17kB, compared to 164 kB of old embed lib)
Example: https://glitch.com/edit/#!/embed-next-html (the CSS is not injected correctly at the moment)

:tada: This PR is included in version @typeform/embed-v1.0.0-next.7 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version @typeform/embed-v1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[pub] new rule: license-exists

If "pubspec.yaml" exists and contains "version" (and not "publish_to:"), then: "LICENSE" should also exist.
/fyi @jonasfj

Similar to https://github.com/dart-lang/sdk/issues/58245#issuecomment-2517477468 I'd suggest only ignoring it when publish_to: none is present (or version isn't present).

@sigurdm do you agree that this would allow us to remove https://github.com/dart-lang/pub/blob/master/lib/src/validator/license.dart

@sigurdm do you agree that this would allow us to remove https://github.com/dart-lang/pub/blob/master/lib/src/validator/license.dart

Yes, if it is included by default. (basically is this a lint or warning I guess) If you have to opt-in we need a mechanism to ensure that the check is enabled at publication time.


Include DOD installations as named places in community search

This was suggested during Scott's presentation at the SERDP conference. This could be implemented globally (via adding places to the GVV) or just for Arctic-EDS (via ??? - maybe a lookup table that provides DOD installation names and associated lat/lons???)

AK_sites.csv


How to analyze onchain contracts by Mythril

I found the different results between the on-chain contracts with the same Solidity code.
When the target is on-chain contracts, what is analyzed by Mythril?
Solidity code or byte code?
And including arguments and Ether balance?

Mythril uses bytecode, but when analyzing onchain contracts, mythril tries to use the onchain state of the contract (i.e., balance, onchain storage of the contract, etc). Hence the differing results.


一个警告性提示,如果有需要,就修改吧.

刚刚测试了,
4.2.1版本也是有这个现象的..
console的过滤器选择了 Verbose；将输出警告:
chunk-elementUI.9f0679fd.js:1 [Violation] Added non-passive event listener to a scroll-blocking 'mousewheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
可能的解决方案:https://www.jianshu.com/p/5bae6433025f

感谢这个框架哦


MAINT: Make env a required argument to algo.

Remove creation of TradingEnvironment during init, in favor of passing
it explicitly.
N.B, Do not merge before internal branch is compatible.

Talked with @ssanderson and heeding his advice to hold off on this until at least after next release because it is a breaking API change.


Remove Exists from backend

Cleans up some issues with the write flusher and removes the need for the Exists function on the container backend.

ping @calavera

--- FAIL: TestSuccessfulDownload (5.23s)
	download_test.go:288: missing or wrong progress output for id3 (got: 9)```

:cry:

Doesn't seem related to this change, though does seem to indicate some raciness in the test :(

A problem with attach over websocket, I'll have to see what's happening.

Doesn't seem related to this change, though does seem to indicate some raciness in the test :(

Definitely not related.
That test does seem to fail from time to time. I spent some time trying to track it down, but haven't been successful so far. I'll continue trying.

My first reading of the code looks impressive. I need to go through it again, but I like what it looks like so far. I don't think the failing test is related.

And engine-api split broke this :(

Which is ok, because I knew it wasn't the right place -- and now I know how to fix it :)

This is updated

userns failed for some reason; https://jenkins.dockerproject.org/job/Docker-PRs-userns/4563/console
20:31:38 # WARNING! DOCKER_EXPERIMENTAL is set: building experimental features
20:31:38
20:31:38 ---> Making bundle: binary (in bundles/1.10.0-dev/binary)
20:31:38 Building: bundles/1.10.0-dev/binary/docker-1.10.0-dev
20:33:09 # github.com/docker/docker/docker
20:33:09 /usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: exit status 1
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_sym':
20:33:09 (.text+0x18): undefined reference to `dlsym'
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_sym':
20:33:09 (.text+0x31): undefined reference to `dlerror'
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_close':
20:33:09 (.text+0x58): undefined reference to `dlclose'
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_close':
20:33:09 (.text+0x63): undefined reference to `dlerror'
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_open':
20:33:09 (.text+0x9e): undefined reference to `dlopen'
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_open':
20:33:09 (.text+0xb6): undefined reference to `dlopen'
20:33:09 /usr/lib/gcc/x86_64-linux-gnu/4.8/../../../x86_64-linux-gnu/libltdl.a(dlopen.o): In function `vm_open':
20:33:09 (.text+0xc9): undefined reference to `dlerror'
20:33:09 collect2: error: ld returned 1 exit status

Definitely unrelated

Ping @cpuguy83: can you please rebase?

rebased and green.

Oh man, this is going to conflict with 19772. I'd like to get both in so we can get closer to splitting the server side of the api.

LGTM

ping @calavera
Is it ok for you?

@cpuguy83 rebase and hopefully we can get this in.

Job: Docker-PRs-experimental FAILED:

---
 (in bundles/1.11.0-dev/validate-gofmt)
Congratulations!  All Go source files are properly formatted.

---> Making bundle: validate-lint (in bundles/1.11.0-dev/validate-lint)
Errors from golint:
api/types/backend/backend.go:12:1: comment on exported type ContainerAttachConfig should be of the form "ContainerAttachConfig ..." (with optional leading article)

Please fix the above errors. You can test via "golint" and commit the result.

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs-experimental] $ /bin/sh -xe /tmp/hudson2072454376282782170.sh
+ set +x

---

Job: Docker-PRs FAILED:

---
 (in bundles/1.11.0-dev/validate-gofmt)
Congratulations!  All Go source files are properly formatted.

---> Making bundle: validate-lint (in bundles/1.11.0-dev/validate-lint)
Errors from golint:
api/types/backend/backend.go:12:1: comment on exported type ContainerAttachConfig should be of the form "ContainerAttachConfig ..." (with optional leading article)

Please fix the above errors. You can test via "golint" and commit the result.

Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[Docker-PRs] $ /bin/sh -xe /tmp/hudson4614711017133462207.sh
+ set +x

---

Job: Docker-PRs-WoW-TP4 FAILED:

---
79910a.
+ ec=125
+ set +x

----------------------------------
ERROR: Failed to build test binary
----------------------------------

-----------------------------------------------
ERROR: Failed with exitcode 125 at Tue Feb  9 19:27:20 CUT 2016.
-----------------------------------------------

INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Tue Feb  9 19:27:21 CUT 2016 (1m 19s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson914268476870693048.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---

Job: Docker-PRs-Win2Lin FAILED:

---
aking bundle: binary (in bundles/1.11.0-dev/binary)
Building: bundles/1.11.0-dev/binary/docker-1.11.0-dev
# github.com/docker/docker/docker
/usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

---
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :Build timed out  : False
Logical operation result is FALSE
Skipping script  : cd c:\scripts
sh timeout-post-build.sh

END OF POST BUILD TASK 	: 0
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\Jenkins\AppData\Local\Temp\hudson6134498070692562530.sh
+ set +x

---

Job: Docker-PRs-Win2Lin FAILED:

---
aking bundle: binary (in bundles/1.11.0-dev/binary)
Building: bundles/1.11.0-dev/binary/docker-1.11.0-dev
# github.com/docker/docker/docker
/usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

---
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :Build timed out  : False
Logical operation result is FALSE
Skipping script  : cd c:\scripts
sh timeout-post-build.sh

END OF POST BUILD TASK 	: 0
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\Jenkins\AppData\Local\Temp\hudson4543169653633820117.sh
+ set +x

---

Job: Docker-PRs-WoW-TP4 FAILED:

---
e8c765.
+ ec=125
+ set +x

----------------------------------
ERROR: Failed to build test binary
----------------------------------

-----------------------------------------------
ERROR: Failed with exitcode 125 at Tue Feb  9 21:07:09 CUT 2016.
-----------------------------------------------

INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Tue Feb  9 21:07:10 CUT 2016 (1m 16s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson5782584249861580053.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---

Job: Docker-PRs-Win2Lin FAILED:

---
aking bundle: binary (in bundles/1.11.0-dev/binary)
Building: bundles/1.11.0-dev/binary/docker-1.11.0-dev
# github.com/docker/docker/docker
/usr/local/go/pkg/tool/linux_amd64/link: running gcc failed: fork/exec /usr/bin/gcc: cannot allocate memory

---
Build step 'Execute shell' marked build as failure
Performing Post build task...
Could not match :Build timed out  : False
Logical operation result is FALSE
Skipping script  : cd c:\scripts
sh timeout-post-build.sh

END OF POST BUILD TASK 	: 0
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe C:\Users\Jenkins\AppData\Local\Temp\hudson3335724905086617669.sh
+ set +x

---

rebased

Gordon is pretty chatty, eh? I don't know anything about the windows failures. I still like the cleaner attach, among other things.

he will get better :) also comments are deleted if you rebuild and it passes

LGTM


Adding a License of this repository

Hi, @gshigeto.
This information is what I wanted.
But I couldn't find the license information of this repository.
Why don't you do adding a LICENSE file?
Can I use this information for my project?

@ikasoumen, thank you for your suggestion! I am glad that this is what you wanted.
I added a LICENSE and I give you permission to use this for your project.
Best!


Fix issue of no traded options in OptionChainProviderAlgorithm

Description

The OptionChainProviderAlgorithm was modified to trade options at the next time step after subscribing the data for the specified contract with AddOptionContract().
Related Issue

Fixes #1937
Motivation and Context

The algorithm used to submit the order instantly after AddOptionContract(). The orders fails to fill because the data has not been received and the price of the specified contract is zero.
Requires Documentation Change

No
How Has This Been Tested?

Regression test
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/ect)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Initializing the contract with None does not pass the self.Securities.ContainsKey(self.contract). I got error like Runtime Error: ArgumentNullException : Value cannot be null.


Add the new GTP-4o model

Hello,
please add the new GTP-4o model
best regards

gpt-4o model has been added.


Issue 1038

Summary
Adds a note to Contributor Guide intro with link to info for documentation contributors (website/readme.md).
Test plan

Deploy preview for netlify-cms-www ready!
Built with commit 4b22496ac59d4e641574fb1437277f05146b4b09
https://deploy-preview-1631--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 4b22496ac59d4e641574fb1437277f05146b4b09
https://deploy-preview-1631--cms-demo.netlify.com

Did the contributor thing to add myself, hopefully. :)


After Killing the app, the box are empty.
I tried to use Hive.close() to close all openned box or flush.
I saw old Issues talking about this specific problem but none gave me a solution.
I'm using Hive in 2.0.4 but tried with other versions and have the same problem.

When you are going to create an issue, always provide the most relevant information available (code, versions, etc.)
"SAVE" time !  and the element with save() .
void main() async {
Hive.registerAdapter(PersonAdapter());
var persons = await Hive.openBox('personsWithLists');
persons.clear();
var mario = Person('Mario');
var luna = Person('Luna');
var alex = Person('Alex');
persons.addAll([mario, luna, alex]);
mario.friends = HiveList(persons); // Create a HiveList
mario.friends.addAll([luna, alex]); // Update Mario's friends
mario.save(); // make persistent the change,
print(mario.friends);
luna.delete(); // Remove Luna from Hive
print(mario.friends); // HiveList updates automatically
}


A Very Big Sum

In this challenge, you are required to calculate and print the sum of the elements in an array, keeping in mind that some of those integers may be quite large.
Function Description
Complete the aVeryBigSum function in the editor below. It must return the sum of all array elements.
aVeryBigSum has the following parameter(s):

int ar[n]: an array of integers .

Return

long: the sum of all array elements

Input Format
The first line of the input consists of an integer .
The next line contains  space-separated integers contained in the array.
Output Format
Return the integer sum of the elements in the array.
Constraints
1 <= n <= 10
0 <= ar[i] <= 10^10

Sample Input
5
1000000001<PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER><PHONE_NUMBER>

Output
5000000015

Note:
The range of the 32-bit integer is (-2^31) to (2^31 -1) or [-2147483648 ,<PHONE_NUMBER>7] .
When we add several integer values, the resulting sum might exceed the above range. You might need to use long int C/C++/Java to store such sums.
When we add several integer values, the resulting sum might exceed the above range. You might need to use long int C/C++/Java to store such sums.

i would like to provide the solution in java

hiii i have solved using c can u assign this one

I want to solve it using python

@ndrohith09 Hello I have solved this issue using python can you please assign me this one

I would like to solve this problem in c#.

I would like to solve this problem in C++


Step 1 fails; Install-Module doesn't exist on Server 2012R2

The instructions for Step 1 fail on a brand new install of Server 2012R2; I applied all Windows patches.
Installation media was from MSDN, "en_windows_server_2012_r2_with_update_x64_dvd_6052708.iso"
I got this:
Install-Module : The term 'Install-Module' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
again.
I tried the troubleshooting steps from an elevated PowerShell script and got the following error:
PS C:\Windows\system32> (Get-Item C:\Windows\System32\WindowsPowerShell\v1.0\Modules\MSOnline\Microsoft.Online.Administr
ation.Automation.PSModule.dll).VersionInfo.FileVersion
Get-Item : Cannot find path
'C:\Windows\System32\WindowsPowerShell\v1.0\Modules\MSOnline\Microsoft.Online.Administration.Automation.PSModule.dll'
because it does not exist.
I checked the version of powershell (again, fresh install of 2012R2 from patched media, and all windows patches)
PS C:\Windows\system32> Get-Host | Select-Object Version
Version
4.0

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dbb1fe83-c1b3-3176-4d61-fe4f3ce1d598
Version Independent ID: c89f295b-4f00-c2c0-c75f-75fa50ecda65
Content: Connect to Office 365 PowerShell
Content Source: Enterprise/powershell/connect-to-office-365-powershell.md
Service: o365-administration
GitHub Login: @JoeDavies-MSFT
Microsoft Alias: josephd

I tried the troubleshooting steps from an elevated PowerShell script and got the following error:
PS C:\Windows\system32> (Get-Item C:\Windows\System32\WindowsPowerShell\v1.0\Modules\MSOnline\Microsoft.Online.Administr
ation.Automation.PSModule.dll).VersionInfo.FileVersion
Get-Item : Cannot find path
'C:\Windows\System32\WindowsPowerShell\v1.0\Modules\MSOnline\Microsoft.Online.Administration.Automation.PSModule.dll'
because it does not exist.
I checked the version of powershell (again, fresh install of 2012R2 from patched media, and all windows patches)
PS C:\Windows\system32> Get-Host | Select-Object Version
Version
4.0

@jgwinner  - Thank you for submitting feedback.
I will get this issue over to the Enterprise writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@jgwinner As per https://docs.microsoft.com/en-us/powershell/scripting/install/installing-windows-powershell?view=powershell-6, please install PowerShell 5.1 from https://www.microsoft.com/en-us/download/details.aspx?id=54616. The try installing the AzureAD module and let use know if it is successful. Thanks

@JoeDavies-MSFT That isn't listed as a prerequisite on the referring page (Enterprise/powershell/connect-to-office-365-powershell.md). I followed all of the prereq's and it failed. If Powershell 5.1 is required, it needs to be listed on this page and a step added, before the user is directed to perform an activity that fails.
That is the bug.

@JoeDavies-MSFT Whoops, I take that back. Server 2012R2 does have that version installed.
Windows PowerShell
Copyright (C) 2016 Microsoft Corporation. All rights reserved.

PS C:\Users\jgwinner> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14393.3053
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3053
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

PS C:\Users\jgwinner>

Wouldn't Microsoft double check documentation by doing a fresh install of the products being documented?

@jgwinner I just tested this on a fresh Windows Server 2012 R2 virtual machine.
I added a note in the "What do you need to know before you begin?" section to inform readers that they have to have PowerShell 5.1 or later installed and for listed, older versions of Windows, a link to the 5.1 download.
Sorry for the inconvenience. Thanks so much for letting us know.


Location Tool: See Random Record or Multiple on Upload

Problem
When uploading GIS files, the tool will show the first item to help the user understand the contents. However, often one entry is not enough to understand. We need to be able to see more than one.
Solution
Preferred solution: When clicking the view button, display a new random record each time, rather than just the first record.
Alternative solution: Show more than one at once.
Additional context and instructions
Add any other context or screenshots about the feature request here.

Closed for now. May revisit


Add Information about the number of federated external domains limit

It seems that when you used closed federation/external communications where you just allow domains instead of open communications with anyone external, the limit of domains that we can add as allowed is 4000 based on tests that we did.
there's no Public Documentation on that. The only way for us to validate this, was by testing, but, this does not make the information official or documented.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

PR was closed, closing issue for now as it is being discussed internally.


chore: make use of pkg to package the Etcher CLI

This commit replaces our home-grown CLI packaging mechanism based on
browserify + node-static-entry-point with pkg, an open source tool to
package Node.js applications for distribution.
Some highlights:

Removing browserify got rid of a lot of dependencies from
npm-shrinkwrap.json

pkg currently has an issue where macOS binaries can't be code-signed
(https://github.com/zeit/pkg/issues/128), therefore this commit
comments-out the binary signing section for that operating system

pkg currently has an issue where Windows binaries can't be branded
(zeit/pkg#149), therefore this commit
comments-out the branding section for that operating system

See: https://github.com/zeit/pkg
Fixes: https://github.com/resin-io/etcher/issues/1531
Fixes: https://github.com/resin-io/etcher/issues/1450
Change-Type: patch
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Should this PR totally remove the usage of $(BUILD_OUTPUT_DIRECTORY) ?

Done!

Ping @lurch. Lets try to get this merged soon, we can get rid of those "cyclic links" Appveyor issues when using MinGW.

Ping @lurch

We're getting some shrinkwrap issues, exactly like in https://github.com/resin-io/etcher/pull/1539, and I think I got to the bottom if it, and its related to node_modules caches in the CI servers. Here's what's going on on this particular case:

I installed pkg using npm install --save pkg (notice I didn't specify a version)
That resulted in package.json containing:

    "pkg": "^4.1.1"

And in npm-shrinkwrap.json containing:
    "pkg": {
      "version": "4.1.1",
      "from": "pkg@latest",

(notice the from property).

I then manually edited the shrinkwrap file and package.json to eliminate latest and any ranges (which is what npm would have done for me)
See what's inside node_modules/pkg/package.json:

  "_from": "pkg@latest",
  "_id"<EMAIL_ADDRESS>
So my shrinkwrap file says that pkg came from<EMAIL_ADDRESS>but the actual package.json of the pkg installation says it came from pkg@latest.

If I run npm shrinkwrap --dev, this is what I get:

diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
index d32af581..fe0a9c25 100644
--- a/npm-shrinkwrap.json
+++ b/npm-shrinkwrap.json
@@ -8659,7 +8659,7 @@
     },
     "pkg": {
       "version": "4.1.1",
-      "from"<EMAIL_ADDRESS>+      "from": "pkg@latest",
       "resolved": "https://registry.npmjs.org/pkg/-/pkg-4.1.1.tgz",
       "dependencies": {
         "acorn": {

So npm is obeying what's on node_modules, and updating npm-shrinkwrap.json to reflect that.

Of course, the fix is to also update _from from node_modules/pkg/package.json
The problem is gone if I wipe out node_modules and do everything from scratch, since pkg will be correctly installed as what the shrinkwrap says, and there will be no inconsistency
The issue is when the CI services use cached node_modules :)

So.... given that these annoying from: lines seem to be the cause of 90% of our problems with npm-shrinkwrap.json, would it be worth trying to remove them all during clean-shrinkwrap.js, as I've already suggested a couple of times? I think that these lines are only informational (and they're gone in NPM 5), but obviously @jviotti knows NPM much better than I do, so he can better test whether removing these lines actually breaks NPM 3 or NPM 4 ;-)

@jviotti Looks like you might have missed one of my previous comments? https://github.com/resin-io/etcher/pull/1547#discussion_r125349252

Depending on what you do with the Makefile, it looks like you might be able to get rid of the CPRF variable too :)

So.... given that these annoying from: lines seem to be the cause of 90% of our problems with npm-shrinkwrap.json, would it be worth trying to remove them all during clean-shrinkwrap.js, as I've already suggested a couple of times? I think that these lines are only informational (and they're gone in NPM 5), but obviously @jviotti knows NPM much better than I do, so he can better test whether removing these lines actually breaks NPM 3 or NPM 4 ;-)

I think we should try to push it as far as we can before doing non-standard change to this file. We don't know for sure if some npm operations rely on this little tag (even for comparison purposes). If they are removed in later npm versions, then we rather put effort in upgrading our npm version.

Depending on what you do with the Makefile, it looks like you might be able to get rid of the CPRF variable too :)

Done! :tada:

I'm testing that the CLI build pipeline didn't break, and I'll push my latest changes afterwards.


Pattern matching on object keys incorrectly matching

Edit: Perhaps what I'm looking for in this situation is pathItem and not paths?  If so, is there any corresponding way to refer to a model name within a schemas object?
Detailed description
Question/Potential bug: I am making use of the new pattern-matching-on-object-keys feature introduced in v0.8.7.  Having struggled to get my own regexes working, I've instead used the example rule provided with the feature PR as a starting point:
  - name: path-item-lowercased-hyphens
    object: paths
    enabled: true
    description: path items must be lowercase and separated with hyphens
    pattern:
      property: "$key"
      split: "/"
      value: "^{[^}]*}$|^([a-z-\/]*)$"

Using this (specified as a custom rule), the following path passes (as expected):
paths:
  /things:
  ...

Unfortunately, so does this:
paths:
  /Thi___***ngs:
  ...

If I update the value of the pattern to "^things$", no match is found with the original path (but should be).
Context
This is a potential issue with a pre-existing feature.  When functioning as expected, it prevents the need for hand-rolled validation checks.  This is advantageous for everyone.
Possible implementation
As yet, I don't see the correct fix, or whether this is simply a PEBKAC.
Your environment

speccy version: 0.9.0
Node Version: v10.15.3

Hi @colleenhardie-wf,
I made a booboo in this example. It fails as the "$key" of the object paths is actually "paths". The object should be pathItem and then the rule works as expected. I will change this in the examples listed.
So correct value is:
  - name: path-item-lowercased-hyphens
    object: pathItem
    enabled: true
    description: path items must be lowercase and separated with hyphens
    pattern:
      property: "$key"
      split: "/"
      value: "^{[^}]*}$|^([a-z-\/]*)$"

Hey, @pderaaij.  Thanks for this!


Add option for "no-shadowed-variable" to ignore parameter decorators

Problem code:
public foo(
  @request request: express.Request,    // Shadowed name: 'request' (no-shadowed-variable)
  @response response: express.Response, // Shadowed name: 'response' (no-shadowed-variable)
  @next next: express.NextFunction      // Shadowed name: 'next' (no-shadowed-variable)
) {
  // .......
}

The decorators and the argument names are the same, so the rule is triggered.
Options:
:-1: ignore the problem
:-1: disable the rule
:-1: rename the argument (those names are canonical so this is a bad idea)
:+1: add an option to the rule to handle this case

TIL about parameter decorators :)

It's from the inversify-express-utils package.

☠ TSLint's time has come! ☠
TSLint is no longer accepting most feature requests per #4534. See typescript-eslint.io for the new, shiny way to lint your TypeScript code with ESLint. ✨
It was a pleasure open sourcing with you all!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


⚠ SceneTime has degraded performance

In e583973, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 3741 ms

Resolved: SceneTime performance has improved in 1c41704.


added test case for expression having @ and +

Covered test case for: https://github.com/joernio/joern/pull/3135
Expression such as: x+@y

@xavierpinho please have review.

Added one more case for https://github.com/joernio/joern/issues/3199
Case: Code snippet containing unless keyword and regex pattern

Added one more case for #3199 Case: Code snippet containing unless keyword and regex pattern

It would be preferable to have this in another PR, since it's unrelated.

Added one more case for #3199 Case: Code snippet containing unless keyword and regex pattern

It would be preferable to have this in another PR, since it's unrelated.

Added in current PR as pipeline pr / test-scripts (pull_request) is getting failed many times.


Expose configuration for the reva archiver

Description
Expose the reva archiver configuration
Related Issue
https://github.com/owncloud/ocis/issues/2507
Motivation and Context

How Has This Been Tested?

Access ocis with the admin user
Create folder "zzz" and upload some files there
Connect to the archiver service:

Assuming you've started a basic ocis installation with ocis server
In the same host

root@f13b05e8714d:/# curl -v -u admin:admin -JO http://localhost:9140/archiver?dir=/home/zzz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying <IP_ADDRESS>:9140...
* TCP_NODELAY set
* Connected to localhost (<IP_ADDRESS>) port 9140 (#0)
* Server auth using Basic with user 'admin'
> GET /archiver?dir=/home/zzz HTTP/1.1
> Host: localhost:9140
> Authorization: Basic YWRtaW46YWRtaW4=
> User-Agent: curl/7.68.0
> Accept: */*
>
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-Disposition: attachment; filename="zzz.tar"
< Content-Transfer-Encoding: binary
< Vary: Origin
< X-Access-Token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZXZhIiwiZXhwIjoxNjMxNzk4NDYxLCJpYXQiOjE2MzE3MTIwNjEsImlzcyI6Imh0dHBzOi8vb2Npcy5qcC5zb2xpZGdlYXIucHJ2IiwidXNlciI6eyJpZCI6eyJpZHAiOiJodHRwczovL29jaXMuanAuc29saWRnZWFyLnBydiIsIm9wYXF1ZV9pZCI6ImRkYzIwMDRjLTA5NzctMTFlYi05ZDNmLWE3OTM4ODhjZDBmOCIsInR5cGUiOjF9LCJ1c2VybmFtZSI6ImFkbWluIiwibWFpbCI6ImFkbWluQGV4YW1wbGUub3JnIiwiZGlzcGxheV9uYW1lIjoiQWRtaW4iLCJ1aWRfbnVtYmVyIjoyMDAwNCwiZ2lkX251bWJlciI6MzAwMDB9LCJzY29wZSI6eyJ1c2VyIjp7InJlc291cmNlIjp7ImRlY29kZXIiOiJqc29uIiwidmFsdWUiOiJleUp3WVhSb0lqb2lMeUo5In0sInJvbGUiOjF9fX0.jf3Fxy5FGRLLKLss_gi8yxZ1MVof2-S3g17z4xtL_KA
< Date: Wed, 15 Sep 2021 13:21:02 GMT
< Content-Type: application/octet-stream
< Transfer-Encoding: chunked
<
{ [3248 bytes data]
100 6782k    0 6782k    0     0  9566k      0 --:--:-- --:--:-- --:--:-- 9552k
* Connection #0 to host localhost left intact
curl: Saved to filename 'zzz.tar'

The tar file is downloaded and contains the files that were present in the folder.
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[x] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

:boom: Acceptance tests Web-Tests-ocis-ocis-storage-1 failed. The build is cancelled...

there is already a capability, see https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go#L105 and https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/data/capabilities.go#L110
but it seems we are not setting it https://github.com/owncloud/ocis/blob/master/storage/pkg/command/frontend.go#L66-L72 @jvillafanez  you could try setting it in the filesCfg.

there is already a capability, see https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go#L105 and https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/data/capabilities.go#L110

Wrong context? The links point to "favorites", and I don't see any reference to the archiver there. The PR in reva implementing the archiver doesn't have any change around capabilities neither.

Default route to the archiver added to the proxy.
$ curl -u admin:admin -k -OJ -v 'https://my.ocis.server/archiver/archiver?dir=/home/zzz'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying <IP_ADDRESS>:443...
* TCP_NODELAY set
* Connected to ocis.jp.solidgear.prv (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
{ [6 bytes data]
* TLSv1.3 (IN), TLS handshake, Certificate (11):
{ [836 bytes data]
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
{ [264 bytes data]
* TLSv1.3 (IN), TLS handshake, Finished (20):
{ [52 bytes data]
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
* TLSv1.3 (OUT), TLS handshake, Finished (20):
} [52 bytes data]
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: O=Acme Corp; CN=OCIS
*  start date: Sep 16 09:46:40 2021 GMT
*  expire date: Sep 16 09:46:40 2022 GMT
*  issuer: O=Acme Corp; CN=OCIS
*  SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
* Server auth using Basic with user 'admin'
} [5 bytes data]
> GET /archiver/archiver?dir=/home/zzz HTTP/1.1
> Host: ocis.jp.solidgear.prv
> Authorization: Basic YWRtaW46YWRtaW4=
> User-Agent: curl/7.68.0
> Accept: */*
>
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [146 bytes data]
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-Disposition: attachment; filename="zzz.tar"
< Content-Transfer-Encoding: binary
< Content-Type: application/octet-stream
< Date: Thu, 16 Sep 2021 09:56:51 GMT
< Vary: Origin
< X-Access-Token: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJyZXZhIiwiZXhwIjoxNjMxODcyNjExLCJpYXQiOjE2MzE3ODYyMTEsImlzcyI6Imh0dHBzOi8vb2Npcy5qcC5zb2xpZGdlYXIucHJ2IiwidXNlciI6eyJpZCI6eyJpZHAiOiJodHRwczovL29jaXMuanAuc29saWRnZWFyLnBydiIsIm9wYXF1ZV9pZCI6ImRkYzIwMDRjLTA5NzctMTFlYi05ZDNmLWE3OTM4ODhjZDBmOCIsInR5cGUiOjF9LCJ1c2VybmFtZSI6ImFkbWluIiwibWFpbCI6ImFkbWluQGV4YW1wbGUub3JnIiwiZGlzcGxheV9uYW1lIjoiQWRtaW4iLCJ1aWRfbnVtYmVyIjoyMDAwNCwiZ2lkX251bWJlciI6MzAwMDB9LCJzY29wZSI6eyJ1c2VyIjp7InJlc291cmNlIjp7ImRlY29kZXIiOiJqc29uIiwidmFsdWUiOiJleUp3WVhSb0lqb2lMeUo5In0sInJvbGUiOjF9fX0.odeEizJVYCPzJX1uHhl-fmUxEx1NNahGNr_En3GoU7o
< Transfer-Encoding: chunked
<
{ [5 bytes data]
100 3428k    0 3428k    0     0  5879k      0 --:--:-- --:--:-- --:--:-- 5890k
* Connection #0 to host ocis.jp.solidgear.prv left intact
curl: Saved to filename 'zzz.tar'

there is already a capability, see https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go#L105 and https://github.com/cs3org/reva/blob/master/internal/http/services/owncloud/ocs/data/capabilities.go#L110

Wrong context? The links point to "favorites", and I don't see any reference to the archiver there. The PR in reva implementing the archiver doesn't have any change around capabilities neither.

urgh yes ... sorry I was confused. I think a new files capability archives makes sense. But I would strongly prefer a url endpoint value instead of just a boolean flag. That way the capabilities can be used to tell clients which endpoint to use without having to hardcode it in the clients. For example "archiver":"https://localhost:9200/archiver"

capabilities will be tackled in https://github.com/cs3org/reva/pull/2088

Note for future readers. The API endpoint in cs3org/reva seems to be download_archive https://github.com/cs3org/reva/pull/2066
The API endpoint here in oCIS is archiver


Do you have NTU-RGBD trained model weight?

Thanks for your work, i wanna develop my model based on your model and i wanna your NTU-RGBD trained model weight. Does it accessable now? Thanks

I found your weight file in baidu cloud but i dont know which one should i load if i just wanna use the st-gcn backbone network, is the ntuxsub-st_gcn.pt this one? it seems that there are may keys like backbone in this file.

NTU-RGBD has two evaluation protocols, cross-subject (X-sub) and cross view (X-view). So there are two pre-trained models, each for on protocol. You can choose the one you feel more appropriate for your application.

seems that the pretrained models cannot match the current code, but it can match the past version, do you have the current code's pretrained model?

You can then use the previous version. The current version is just to confirm pytorch 0.4 api.


New Maintainer

Hi folks. I did a total rewrite of this library as it does not work at all.
We are using it in production for quite a lot of time and it works great.
See the PR: #8
If you decide to merge it, I could set up as a maintainer of this project.
Suggested by @elia in https://github.com/3scale/capistrano-github/pull/1#issuecomment-147706309
/cc @capistrano

here's the usual :+1:

@kirs Would you be willing to pass this on to a more active maintainer? Many thanks!

Sure. @mikz are you still willing to be a maintainer?

I'm also up to merging the PR and releasing new version of the gem myself. I was never pinged about this issue :neutral_face:

We are still actively using our fork. So I guess why not.  Not really planning new features because it just works, but happy to review and merge stuff if needed.

2017 v 14:49, Kir Shatrov<EMAIL_ADDRESS>

Sure. @mikz are you still willing to be a maintainer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Closing this per https://github.com/capistrano/github/issues/9 in favor of https://github.com/3scale/capistrano-github. Future issues should be sent there.


Add i18n guide

Summary
Add Internationalization Guide section to root README.md. Make consumers easy to start with translations.
Fix #476
In general, this Internationalization section should be the entry guide for any consumers who want to have translations in their application. Prefer to use existing doc resources to describe the each step. By this way, it should be easier to maintain.

I have synced with David Nguyen to see how helpful this guide will be. He's good with it.

I think it would be appropriate to update readme for terra-base documentation at the same time.

I think there's need to be two defining sections internationalization.
A section for, defines how to only internationalize terra components. Then a section for custom internationalization with consumers component using Base vs react-intl directly.
Current documentation makes it seem like we need all of these configurations with react-intl for terra components when in actuality consumers only need Base to encapsulate component with locale defined.

I try to keep it in one section for easy consuming. As you said, there are two cases.

Consumers just want to use DatePicker or DemoBanner. They don't want to provide any translations at the application level.
Consumers want to provide their own translations.

My objective in here is recommending consumers follow the same way(assume if they have the locale set up now, they should use translations in future) and try to get familiar with translations strategy at first.

From looking at Dave's comments, I don't think we should be documenting these concerns in the individual packages. Perhaps we can instead make use of our wiki space on this monorepo to talk about how to setup Internationalization?

From looking at Dave's comments, I don't think we should be documenting these concerns in the individual packages.

Thinking about it now, @JakeLaCombe, internationalization for individual package should live within each component.

We found that approach to be limiting, as it would cause way too many files to be loaded at once. We wanted to ensure that all translations are loaded at once, and that the best work around was to create a webpack plugin that would look for all your translations files, then build out a single translation object that would be passed into the i18n wrapper.

Thinking about it now, @JakeLaCombe, should internationalization for individual package should live within each package?

We found that approach to be limiting, as it would cause way too many files to be loaded at once. We wanted to ensure that all translations are loaded at once, and that the best work around was to create a webpack plugin that would look for all your translations files, then build out a single translation object that would be passed into the i18n wrapper.

Sorry, I should have given more context. I was talking about in regards to documentation. Each individual package documentation should contain, if applicable, how to internationalize the package.


Add governator dependency conflict resolution

The examples require an earlier version of governator, but karyon-admin
pulls in version 1.3 which causes a conflict resulting in a method not
found error on LifecycleInjector.bootstrap()

This was fixed with #140


String: add StringView, similar to VecView

Follow up of #425
This time we need a dedicated sealed module for StringInner, because of the pub mod string in lib.rs. Maybe VecInner should have the same treatment, in case some time in the future the vec module is made public.

Please use a macro to implement the traits, as I did in https://github.com/rust-embedded/heapless/pull/451.

Done. And I added some inline hints similarly to #451

closing in favor of #487


THORN-2435: OpenAPI: query parameter "format" value

Motivation
The MicroProfile OpenAPI specification clearly states that the optional
query string parameter format can have 2 values: YAML and JSON.
Our current implementation defaults to YAML and checks the format
parameter (and the Accept header) if it should switch to JSON.
However, it doesn't check the format parameter correctly. Instead
of checking for JSON, it checks for application/json.
Modifications
Check the format parameter for JSON value as well. The check
is case insensitive.
Result
More conformant to the specification. No breaking change,
as the original behavior is retained.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you created a JIRA and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

I must admit I'm surprised this code is not in SmallRye

Probably because it's Undertow-specific.


Window title regression on Linux

Summary
Mattermost desktop 4.6.0 doesn't have nice compact window border as version 4.5.4 and adds border from my window manager (Gnome).
4.5.4:

4.6.0:

Environment

Operating System: Linux (Fedora 32)
Mattermost Desktop App version: 4.6.0 (both Flatpak and AppImage builds)

Hi @SemaiCZE, thanks for the feedback. This was recently changed as a result of feedback from many users that they prefer having the native window frame wrapped around the tab bar interface in Linux.
With that said, we're looking into improvements to make the tab bar not show if you only have one server connected: https://mattermost.atlassian.net/browse/MM-25961

I rather liked the custom title bar tbh. I would like the option to choose the macos & windows 10 styles for myself on Linux.

Esp, since my theme looks like macOS...

Hi @esethna,
thanks for your clarification. I didn't know that it's intentional, for me it's just useless space on my screen. But I respect what people want and closing this issue 🙂


No sound  in some android, but works in others

I have three android phones and two iphones, nativeaudio plugin works well on one android(4.2.2) and all iphone.  there are two android(4.4.4, 4.2.1) can't hear anything.
I digged internet for whole weekend, found some weird thing. when I add these code in plugin, sounds goes back,then remove them all, compile again, sounds is still there.  I cant expained it.  I lost my incident ground, but something wrong in there.
// setting volume on MediaPlayer doesnt work
mp = new MediaPlayer();
mp.setVolume(volume, volume);

// force set volume on AudioManager, it works. but the code just get/set same value..
    AudioManager audiMgr = (AudioManager)this.cordova.getActivity().getSystemService(Context.AUDIO_SERVICE);
    int currentVolume = audiMgr.getStreamVolume(AudioManager.STREAM_RING);
    audiMgr.setStreamVolume(AudioManager.STREAM_MUSIC, currentVolume, 0);

Another  useful info  http://stackoverflow.com/a/15261422

Calling setVolume after calling prepare fixes this, so that audio is played at max volume. Actually, according to the docs I just quoted, you should call setLooping after prepare as well:
mediaPlayer.setDataSource(context, ringtoneUri);
mediaPlayer.prepare();
mediaPlayer.setLooping(looping);
mediaPlayer.setVolume(1.0f, 1.0f);
mediaPlayer.start();

I haven't inspected things on Android, but this issue might be similar to the how things were on iOS, where faded in playing of sounds gave the impression that no sound was playing
Anyway, a while ago, I tested audio performance at length and found out that the cordova audio performed similar to the audio plugins, so I'm using Media integration on Android - I don't know how things on your end, but you might also benefit from such a change
(I load N Media entity's for a single sound effect and play them in turns, N varies from sound to sound)

I've started inspecting this issue too, turns out the Cordova/Media integration at android is also problematic, after upgrading to android5 on my S4, I've started experiencing sounds that sometimes don't play
Comparatively, this plugin doesn't work at all, the sounds don't initialise, there is no callback etc.
I've tested @janckerchen 's methods, the setVolume doesn't change anything, the audio manager one doesn't compile

I have a similar problem and I think is related to this.
In my case the sounds play fine the first time but not the second, unless I wait a while.
The callbacks are firing whether the sound plays or not.
This only happens on Lollipop, there's no problem on kitkat.

I can confirm this plugin only works (plays) the sound once in Android 5. The second and successive times, the sound is not played at all.
I have switched to a different plugin,
https://github.com/apache/cordova-plugin-media


Mim df edits

Short summary of changes / additions
(summary here!)
A few details:

(detail 1)
(detail 2)

Suggested reviewers:

[ ] @(github-name)
[ ] @(github-name)

Before merging: please run a spell check through your documents!

can you give a quick summary (bullet points and issue numbers) of the changes made here? (keeps everyone in the loop - Thanks!)


Tagging a non-group class with the Hidden attribute doesn't add the check to the commands.

Summary
When you add commands to a class that is not tagged as a command group (doesn't have the Group attribute) and you add the Hidden attribute to it, then 'command.IsHidden' is FALSE for every command that doesn't have the Hidden attribute set manually (add it to every method/command).
Adding it to every method (command) in the class is a valid workaround. But the RequireOwner Attribute is added as a pre-execution check for the command. For all the methods/commands in the class.
Example
namespace MyBestBotYet
{
    [Hidden, RequireOwner]
    class OwnerCommands
    {
        [Command("shutdown"), Aliases("exit")]
        public async Task Shutdown(CommandContext ctx) // this command takes no arguments
        {
                //some super cool code
        }

        [Command("say"),Hidden]
        public async Task Say(CommandContext ctx, [RemainingText, Description("What the bot will say.")] string sayStr)
        {
                 //some even cooler code
        }
}

In the example above the 'say' command will be hidden, but the shutdown command will NOT.
Both commands however will be OwnerOnly.
Note
This issue was found during playing with the custom help formatter provided by emzi. The following line showed the issue. where toplevel is an IEnumerable of commands. IsHidden will be true for 'say' and false for 'shutdown'
...
var sxs = toplevel.Where(xc => !xc.IsHidden);
...
Command object during runtime:
http://prntscr.com/hdwen1

That's what I keep asking for lmao

as far as I know, this is intended. When that class is used as a group, the group will be hidden from help but its subcommands won't be.
Though that's my opinion on that matter. CNext is emziware so he'll be the one to decide.

then you should be able to do Hidden(children: true) to hide including children

Good point 😅

#makeithappen 😆

Checks are inherited, other attributes are not. Iunno, I'll think about it.


Improve readability

PR is finished.
What does this PR do?

Update net6.0 to net7.0
Make use of global modifier improving readability
Add file-scoped namespace to every file
Improve readability in various ways

PR is done

Thanks for the commit, I will do a quick test when I get a chance and them merge once everything is confirmed to be working fine.


minPitch and maxPitch calculation should take zoom level as a parameter

Currently the minPitch and maxPitch restrict the angle of the viewer regardless of the zoom level. i.e. if the minPitch and maxPitch are both set to 0, the viewer center is locked vertically when the viewer zooms in.

That's how the parameters are defined, so of course the view center is locked if minPitch and maxPitch are set to the same value. Implementing the behavior you suggest would be nice, but it's a lot more complicated. Both zoom level and viewer size need to be taken into account, and a behavior needs to be decided on for what happens when the viewer is resized. I though about adding this, but it's not currently high on my list of priorities.

Hi @mpetroff, thanks for the quick reply. I'm very new to pannellum. I just think the current behaviour is unnatural to the users. It's good to know that you plan to work on it. I would like to contribute on it too when I can spare the time, but I haven't worked on computer graphics for 3 years, so it might take a while ;-)

@justin-lau do you want to test?

I just changed the minPitch and maxPitch limits such that they apply to the edge of the viewer instead of the center and take zoom into account.


Prettify stdout

Is your feature request related to a problem? Please describe.
The STDOUT can be full of warnings, it should be more user friendly
Describe the solution you'd like
Make GaNLDF's stdout more user friendly (how?)
Describe alternatives you've considered
N/A
Additional context
Warnings could be useful debugging. Perhaps we can have an organized logging system: current stdout can be split into stdout for users, and debugging logs in a ~/.gandlf_logs file for example.

@sarthakpati Assign this to me

I believe @sylwiamm is still working on this.

Hi guys, I hope you are well.
I have started to check it. I would like to ask some questions.

What do you think about having a config file in YAML format like this. In this way, it can easily modified by other developers without any extra coding.
As @VukW has already mentioned ref. we can use, for example the getLogger(name).  Additionally, a logger with the same name as the module name should exist in the config file. Any thoughts on this ??

Hi @benmalef,

Can you give an example? I am not sure I completely follow this. 😵💫
I don't have any strong suggestions/recommendations. Perhaps @VukW can comment, since he has far more experience with this?

Hi @benmalef,

Can you give an example? I am not sure I completely follow this. 😵💫
I don't have any strong suggestions/recommendations. Perhaps @VukW can comment, since he has far more experience with this?

Hi @sarthakpati,
Here is an example.
The configuration of logging in yaml format can be like this.
version: 1
formatters:
  detailed:
    format: "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
debugHandler:
    class: logging.FileHandler
    filename: gandlf.log
    formatter: detailed
    level: DEBUG
Loggers:
    debug_logger:
    level: DEBUG
root:
  level: DEBUG
  handlers: [debugHandler]

define a def for reading the config file
def logger_setup( logger_name, config_pat):
    with open(config_path, "r") as file:
         logger_config = yaml.safe_load(file)
          logging.config.dictConfig(logger_config)
  return logging.getLogger(logger_name)

We can use the logger directly in the module with this:
logger =  logger_setup("debug_logger")
logger.info("You are the best")

I hope now is more clear.
If @VukW  can provide any comment, it would be very helpful.

Hi folks!

What do you think about having a config file in YAML format like this. In this way, it can easily modified by other developers without any extra coding.

I'm always afraid of yaml logging config files, but if you are able to configure it properly - that's fine solution IMO

As @VukW has already mentioned ref. we can use, for example the getLogger(name).  Additionally, a logger with the same name as the module name should exist in the config file. Any thoughts on this ??

🤔 don't loggers inherit settings from each other? Can we configure just root logger (or some gandlf-main logger), and during logger_setup create a new logger by given name, inherited from this gandlf-main? I mean, declaring each possible logger in the configuration may be error-prone as:

We need to declare/configure a couple of dozens loggers, and in future PRs check that renaming existing loggers in the code align with renaming them in config file
that may lead to different configurations for different loggers (or their config duplication). Of course if some loggers want to use specific configuration they should be declared separately; but most of loggers, I believe, should keep the same configuration

UPD @benmalef I tested your configuration with a logger that is not defined in .yaml. It works well also as it inherits from root logger you've configured. So, no need to explicitly define all possible loggers in yaml config

Hi @VukW, I hope you are well.
Thanks for your response.

Hi folks!

What do you think about having a config file in YAML format like this. In this way, it can easily modified by other developers without any extra coding.

I'm always afraid of yaml logging config files, but if you are able to configure it properly - that's fine solution IMO

Hmm, okay. I believe it is more user-friendly, but it is the first time I have tried to implement logging. If you have any suggestions or recommendations, they are kindly accepted.

UPD @benmalef I tested your configuration with a logger that is not defined in .yaml. It works well also as it inherits from root logger you've configured. So, no need to explicitly define all possible loggers in yaml config

Yes, you are right,  I have tested, too. Thanks for your comment :P.

Done with #893


swift-nio repo takes too long to clone

swift-nio repo takes too long to clone

How long is long?
It very could be a matter of your network, or github specifically.
For reference

time git clone https://github.com/apple/swift-nio
1.77s user 0.53s system 41% cpu 5.523 total # from japan

Is pretty ok

This is a dupe of #1528 -- the gh-pages branch is quite large which causes some slowness.

Ah the docs, makes sense :) +1ing that ticket

More than 5 minutes


Improve Clipping Polygon Performance

Feature
https://github.com/CesiumGS/cesium/pull/11750 added an initial implementation of clipping polygons. However, some users are seeing performance hits depending on usage.
The performance hit is not directly correlated with the number of polygon positions. The geographic extent, concavity, and number of polygons also factor in. For example, the AEC Clipping Example is a particularly concave polygon with many positions shows this performance hit.

The performance hit is not directly correlated with the number of polygon positions.

Certain aspects of the polygon shape may have an additional impact here. (For example, a polygon with 100 points that covers a pole and the IDL may have a larger impact than one that does not). But the performance hit is definitely correlated with the number of polygon points.
I created a sandcastle where you can crank up the number of polygon points from 4 to 500 (and it's a circle - i.e. a as convex as it can be). And one can clearly see the performance hit:

The sandcastle:
https://sandcastle.cesium.com/index.html#c=hVZbU9s4FP4rmrzUWVwlFNi2ITA7DQvtTrswDdsXwoMiK7EGWfJIcqjb4b/vkeRrMG0eYl3O9dO5USWNRTvOHplGZ0iyR7RghhcZ/ubPotWI+v1CSUu4ZHo1itHPlUTI8owJOJmhDRGGxe6MSJ4Ry5XsHhrKJPuiEnbD6QPT3as1MewzKZl+frUVat2R/TQ+XcmVDJZiLxInbF1sl6l6vNQkY+aG6SWjSibgiNUF8wzUO2i5YIZZuCCPhNvaR6oZsexKqa1gN6myCvaCG8vp0cVtYImc3p7WXPOMW75jBpMkiSrRwbxNIalzHwXJC64pSFZcWhMBs2X6s5IxqpbExkiThBcmRrLIAt04oBvszv0RmH13f+pON0qjSIAjHM6mp/CZt5ywPTio2GsBBOg4mnSIurcCLD1DjWHoAH0hNsWGy4igP8Lm5hOs3ozhL5jaF0BsKwDWlQCqzG8FBNdwXpg0uhMOFRB2P/a3T+5PM1toWdHB8dMAwLfM2AtiSZQ/x85Wd2BgBYktc4io1egSWAvNFkoI5qVBTAcKCXHkKBxvc0i1mdUiWiGOtCEBd7TKmbacOdpGDjgwU1s6S9hm5sRcXy1mh/hotvi6fHe8GqGnir/+boJlIOOuFtwofmZ/RzukC1MZs7qcdRlali+FsPxGiXLb8Tb8qFI64RLQdGrvApL39x2ap2Zdr8Lt02nnnWq465dyUUoLrSE23PFSFZq6lBw8X6YkD/lKTCkpap65yBOXR4LnOZfbygETDWWLEgwLtYWK9Z9nQo/cpm3gnwHcB50089oQ4hsUVdUAHgnKWRI9s27cJFVVCJLmymDNMrVjA0x1ouxfQDwWstLVRvtevg/Uj9dvT/DhyZvj6bsYHb3H74//fP/2JEZTfBj33RrW2St8V0z9Y5RsCQA5kkR1vA+llrsL0gdAcIVwEIFBa/xrOyf3LzDsuMshvCOigA+AlESRPy3H6Ow8GLj3XuEa5yE4OobWmBruYglgfeFFvD01P04500TTtMRbZr85O6IxboR0BNO9qOz3z72YbYtN9LMugIGtk+svs0edrG5smbXLNkPH/RQNSFRNCg+YvH9U52+Ilxfy73jcaa4Uip0m15tN6LAdJz4yqPjAxi1NvxK5ZT7CqkvfHKz6CiQERE7xNJg+fP36+KQmOJnCD09XstOafyiV3apo+Gnjnold0x23m0xE3SSaRJqhYzx1c8fLVckzXmqVuVEp6vWeRgzI/bfI1jBINarwXrL+EugerX+XCp4HqeiDKiy2mtCHVrqjq/qfUmJN3FSXKFpkAIsL6L8Fc8sP5SdI91FFsxo5tn3JJM9F+QEyEAwyrYa4lux4/EBS+QwYIy5bTCtEXIVtnU+JuX6UN6FblpFjasvrngV1TDu7r9eG6R1ZC9a1xLM3ZKZYG6r5mkUDD9RMFh7FJZEJJcZCz4Dadau2MAF+KKyFTHNkq9GFQjaFiSYFdEuIH5oCChjjqnkOZyn21ItA7OmakIloymDETfZ9/ZUEl52BK9geh5BfyVE8mhtbCuYL4l88y5WGENIiwnhiWZYL180n6wJ4IemNj575pGaZJ3yHeHI2MNtDOSDG9cpNIcSS/4Ah43w+Afoem2sWYN/1jmlBSkeSHp5/DoeA0XwC2+dcTbB5q+fWPWZV0ed2rZLyvH7JudXnbb2b2+Q8JBFSm6pFzidw2CfpzjRzLvPC+ukHFGtXesC3jEvYubkrI99hBYUE1sayHDaHsHQt7fUaIh72vgPN2kyOkT8Js8UMvfIaXlXODOu17Lt1CgBGp+03Cnqiev7BpsYDlg1SsK4gDFj/Dw
Looking at a performance trace reveals (some of) the (potential) culprit(s):

Apparently, computing that rectangle for the clipping polygon takes a lot of time.
There are a few places where one could consider performance improvements. Computing this rectangle in each and every frame is certainly wasteful: I think that the positions of such a polygon will rarely change dynamically. But it is really important to be able to change them dynamically: We want the possibility to interactively drag around the points and update the clipping (...to eventually hit "Confirm" somewhere, and write some clipped result into a file or so...).
As an experiment, I just created a (hacky!!!) branch that just caches this rectangle, based on the positions.
(Yeah, storing the positions twice is also wasteful, in terms of memory - that's the usual trade-off. There are no fine-grained access controls (as in "information hiding") that would allow detecting modifications of the positions. Throwing in some function like clippingPolygon.updateThatStuff() that the user has to call after updating the positions wouldn't be ideal either. This is just an experiment, and clearly marked as such...)
The main point of this experiment is shown at the end of the GIF above: When using the check box to set that ClippingPolygon.hackyCaching flag (that is used in that branch to enable the caching), the FPS goes back to 60.
Maybe there's a "good" way to avoid recomputing that rectangle in each frame...

This was also reported in https://github.com/CesiumGS/cesium/issues/12258 (and I think that one could be closed as a duplicate of this one)


Support Helm login for V3

Currently you can push a helm chart to an OCI registry in V3.
We need to support a unified way of storing credentials so that the user name and passwords can be used during push to an OCI registry.
Output of helm version:
version.BuildInfo{Version:"v3.0+unreleased", GitCommit:"a32f8ebb377da054d21510671d63729fe6a00f3a", GitTreeState:"clean"}
/cc @jdolitsky @shizhMSFT

Precisely, we need helm login like docker login.
@jdolitsky  @sajayantony  Should we reuse docker credentials in ~/.docker/config.json and docker-credential-* helpers? If we do,  helm can automatically reuse the credentials stored by docker login, az acr login, and many others.
Alternatively, we can have a credential file at $HELM_HOME/chart_auth.json so that we can read credentials from that file first, and then fall back to docker credentials if not exists.

@sajayantony @shizhMSFT I the fallback idea. I think that oras lib should be modified to support a generic "login" method, which takes a array of paths to check. This way it is not specific to Docker or Helm.

closed via #5597


Unexpected typescript result POC

I've been working with reselect & typescript and just stumbled across a runtime error accessing a property on an undefined object. I would have thought typescript would have warned me, so I've created a simplified POC here. Please let me know if there's a better place to post this.
My question's are inline in the diff, but I'm wondering why createSelector doesn't complain that the types of the selector result and the combiner parameter do not match.
Thanks for the great library and for taking a look at this!

You have to enable strictFunctionTypes in your compiler options.
I created a minimal playground example where strictFunctionTypes  is enabled and throws an error at the expected lines.
Unfortunately this flag is not explicitly set in the tsconfig used for the tests so I'm not sure how Travis sets this flag. Maybe the used typings-tester package defaults to strict mode.

Thanks for the info @eps1lon. Our project is still on typescript 2.5.3 so I guess we'll have to update to get this fix.


Show all config errors and warnings on start

Enables support to gather all errors that may be found in the configuration file along with the source of the error for each one of them.  This also adds supports for warning error types that will still allow the server to start, but warning messages will be displayed at the beginning instead.
Examples
Multiple errors, warnings shown first:
$ gnatsd -c server/nats.conf
server/nats.conf:10:1: invalid use of field "write_deadline": write_deadline should be converted to a duration
server/nats.conf:8:1: unknown field "monitoring"
server/nats.conf:20:30: Detected service "bar" but already saw a stream
server/nats.conf:24:5: Not a valid public nkey for an account: "OC5GRL36RQV7MJ2GT6WQSCKDKJKYTK4T2LGLWJ2SEJKRDHFOQQWGGFQL"
server/nats.conf:29:9: Not a valid public nkey for a user
server/nats.conf:39:5: Not a valid public nkey for an account: "ODRZ42QBM7SXQDXXTSVWT2WLLFYOQGAFC4TO6WOAXHEKQHIXR4HFYJDS"
server/nats.conf:44:9: Not a valid public nkey for a user

exit status 1

Can use test mode to check for warnings without starting server, if there are any it returns non-zero exit status.
$ gnatsd -c server/nats.conf -t
server/nats.conf:4:1: invalid use of field "write_deadline": write_deadline should be converted to a duration

exit status 1

No errors or warnings using test mode then is still zero exit:
configuration file server/nats.conf test is successful

Without test mode, collection of warnings are shown at the beginning:
$ gnatsd -c server/nats.conf
server/nats.conf:4:1: invalid use of field "write_deadline": write_deadline should be converted to a duration
[10857] 2018/10/08 02:53:16.442791 [INF] Starting nats-server version 1.3.1
[10857] 2018/10/08 02:53:16.442867 [INF] Git commit [not set]
[10857] 2018/10/08 02:53:16.443053 [INF] Starting http monitor on <IP_ADDRESS>:8222
[10857] 2018/10/08 02:53:16.443106 [INF] Listening for client connections on <IP_ADDRESS>:4222
[10857] 2018/10/08 02:53:16.443110 [INF] Server is ready

[X] Link to issue, e.g. Resolves #NNN
[X] Documentation added (if applicable)
[X] Tests added
[ ] Branch rebased on top of current master (git pull --rebase origin master)
[ ] Changes squashed to a single commit (described here)
[X] Build is green in Travis CI
[X] You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

/cc @nats-io/core

Coverage decreased (-0.1%) to 92.376% when pulling 58392fd16b8741fedf954469cfaa89cfe6087200 on config-report-pos-collect-errors into ac5a91702d395cc18a922ff8a8c01a9d4a526bb5 on config-report-pos-always.


Filip will help working on our OpenSource projects

@didlika Filip will help working on our OpenSource projects

I acknowledge that

[ ] I have read and understood the Open Source Guidelines
[ ] I agree to act accordingly (with due dilligence) to our guidelines
[ ] I have no open questions regarding the topics covered (please delete the "open questions" section)


NOJIRA: add comment in internal controls, add back console module.

Adding Console module back to Platform as it's needed in Profile area. It's dependency on Dotnetnuke.Deprecated.Dll is also being replaced as this DLL will eventually be removed from everywhere.


Get the agent_user_id from the request context if available

Description:
Allow proxyDeviceId to be grabbed from the sync request context. This is required for local installs and if cloud in the future would allow separate sync calls per login user.
Checklist:

[ ] The code change is tested and works locally.
[X] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[X] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

I think i'll merge this into the other pull. they conflict now anyway


Launch demo reported "java.lang.ClassFormatError:Truncated class file"

What happened?
when just clone the repo(develp branch), packaged and deployed the agent plugins, using the router-demo from Sermant-Examples, the program reported a exception after the plugin inited : "java.lang.ClassFormatError:Truncated class file".

but, when I switch to 1.1.x branch, this can get work.
How can we reproduce it (as minimally and precisely as possible)?
1 clone https://github.com/huaweicloud/Sermant.git
2 run mvn clean package, and deployed all the plugin jars to ${dir}/sermant-agent-1.0.0/agent automatically by maven.
3 clone https://github.com/huaweicloud/Sermant-examples.git
4 launch the router-demo(ZuulApplication), using the VM parameter "-javaagent:/Users/Mac/Documents/GitHub/Sermant/sermant-agent-1.0.0/agent/sermant-agent.jar=appName=zuul"
5 when the program start running , this exception will be found
Anything else we need to know?
Something I just found from the source code, is that I am using the "develop" git branch, and there may be a class isolation is being developing. And the PluginManager#loadPlugins class method has some change:
after:

before:

this may cause define progress can't load the correct class bytes, because the ClassUtils#defineClass only search SystemClassLoader and ContextClassLoader.
I guess may be that's reason for this issue.
Sermant version

develop & 1.1.x branch

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

mac os / Apple M2 Max

This is caused by the fact that spring service runs in IDEA. When spring service runs in IDEA, the class loader changes from LaunchedClassLoader to AppClassLoader and cannot get sermant classes which injected through Inject service. Running through jars should avoid this problem.

A solution has been provided. No other problems will occur in the future. Therefore, this issue is closed.


&>> and &<< is the new >> and <<

Swift 4 marked >> and << as obsolete. Since the intent of ALL usage cases were easily understood as masking shifts this was an automated find and replace of >> to &>> and << to &<<.

@swift-ci please test

Are you sure this isnt due to the protocol _IntegerLike in NSScanner.swift? I made the same change in a PR but then closed it as I thought the issue was something else? see my last comment in https://github.com/apple/swift-corelibs-foundation/pull/997

FYI, using a swift playground with latest nightly snapshot, << seems to still be valid

This is a preparation for Swift 4 which marks the bit shift operators as obsolete :(
I was attempting to prep all for all of the incoming naming changes etc.

The offender is in Integers.swift.gyb
  @available(swift, obsoleted: 4) // <--- here
  @_transparent
  public static func ${op.nonMaskingOperator}(
    lhs: Self, rhs: Self
  ) -> Self {

The issue here is due to the integer changes in https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md
To quote: "Shifts and other bitwise operations were moved from FixedWidthInteger to  BinaryInteger" so they were only marked as obsolete in FixedWidthInteger
However because of this in NSScanner.swift:
// FIXME(integers): replace this protocol with just a FixedWidthInteger
internal protocol _IntegerLike : FixedWidthInteger, _BitShiftable {
    init(_ value: Int)
    static var max: Self { get }
    static var min: Self { get }
}

extension Int : _IntegerLike { }
extension Int32 : _IntegerLike { }
extension Int64 : _IntegerLike { }
extension UInt32 : _IntegerLike { }
extension UInt64 : _IntegerLike { }

The Int, Int32 etc are now conforming  to FixedWidthInteger and so are picking up the obsoleted << and >> instead of getting the new ones in BinaryInteger.
I think the correct fix may be something along the lines of:
diff --git a/Foundation/NSScanner.swift b/Foundation/NSScanner.swift
index 3da53c9..8fddb81 100644
--- a/Foundation/NSScanner.swift
+++ b/Foundation/NSScanner.swift
@@ -225,13 +225,13 @@ internal protocol _IntegerLike : FixedWidthInteger, _BitShiftable {
     static var max: Self { get }
     static var min: Self { get }
 }
-
+/*
 extension Int : _IntegerLike { }
 extension Int32 : _IntegerLike { }
 extension Int64 : _IntegerLike { }
 extension UInt32 : _IntegerLike { }
 extension UInt64 : _IntegerLike { }
-
+*/
 private func numericValue(_ ch: unichar) -> Int {
     if (ch >= unichar(unicodeScalarLiteral: "0") && ch <= unichar(unicodeScalarLiteral: "9")) {
         return Int(ch) - Int(unichar(unicodeScalarLiteral: "0"))
@@ -264,7 +264,7 @@ private func decimalSep(_ locale: Locale?) -> String {
 }

 extension String {
-    internal func scan<T: _IntegerLike>(_ skipSet: CharacterSet?, locationToScanFrom: inout Int, to: (T) -> Void) -> Bool {
+    internal func scan<T: FixedWidthInteger>(_ skipSet: CharacterSet?, locationToScanFrom: inout Int, to: (T) -> Void) -> Bool {
         var buf = _NSStringBuffer(string: self, start: locationToScanFrom, end: length)
         buf.skip(skipSet)
         var neg = false
@@ -301,7 +301,7 @@ extension String {
         return true
     }

-    internal func scanHex<T: _IntegerLike>(_ skipSet: CharacterSet?, locationToScanFrom: inout Int, to: (T) -> Void) -> Bool {
+    internal func scanHex<T: FixedWidthInteger>(_ skipSet: CharacterSet?, locationToScanFrom: inout Int, to: (T) -> Void) -> Bool {
         var buf = _NSStringBuffer(string: self, start: locationToScanFrom, end: length)
         buf.skip(skipSet)
         var localResult: T = 0

I can confirm that @spevans 's patch fixes all the << is now obsolete compilation failures with latest toolchains.

There's a conflict in one of the files - can you rebase?

Let's close this PR and open a new one. @spevans would you mind putting it up?

No problem, I will sort out a PR in a bit


Replace action buttons with dropdowns

Currently the Caches admin page has 2 buttons per table row. These buttons take up a lot of horizontal space and there isn't enough room to add extra options while keeping the page looking clean. This PR replaces the buttons with dropdowns so we can cleanly add extra actions cleanly.
Before:

After:

@Flynsarmy many thanks for these - I'm seeing the notifications and will review/merge as soon as back to work.


investigate Luigi for workflow management

I ran into this post on Python Weekly which shows how to use Luigi to build workflows, manage dependencies, schedule tasks, etc. in Python. Luigi was developed at Spotify and appears to be one of the leading workflow management libraries in Python. Probably worth looking into as this could be useful for QIIME 2.

awesome!


[TACHYON-1630] Add the Chinese version of documentation page 'Command-Line-Interface'

https://tachyon.atlassian.net/browse/TACHYON-1630

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8458/
Test PASSed.

LGTM. Thanks for the translation!

LGTM


added WhatIsMyBrower.com swag

If your system is to be integrated with their API and have sent at least 1 API request then you get sticker

Thanks!


add EMR on EKS virtual cluster

Description of your changes

This PR adds support for EMR on EKS Virtual Clusters.
Note that EMR on EKS job run  could not be implemented because Terraform does not support it because running it with a IaC tool like TF doesn't fit the nature of the API resource well (I think it makes perfect sense in the Kubernetes world though.) This is supported in the ACK based provider.
Fixes #209
I have:

[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested against my EKS clusters. Create, delete, and update work.
# kubectl get virtualcluster
NAME      READY   SYNCED   EXTERNAL-NAME               AGE
example   True    True     9gkfze5bydgrgipnxqotliq50   68s

# aws emr-containers describe-virtual-cluster --id 9gkfze5bydgrgipnxqotliq50
{
    "virtualCluster": {
        "id": "9gkfze5bydgrgipnxqotliq50",
        "name": "example",
        "arn": "arn:aws:emr-containers:us-west-2:123:/virtualclusters/9gkfze5bydgrgipnxqotliq50",
        "state": "RUNNING",
        "containerProvider": {
            "type": "EKS",
            "id": "my-eks",
            "info": {
                "eksInfo": {
                    "namespace": "emr-on-eks"
                }
            }
        },
        "createdAt": "2022-11-29T18:41:00+00:00",
        "tags": {}
    }
}

/test-examples="examples/emrcontainers/virtualcluster.yaml"

Why was this closed? We would also like to see emrcontainers via upbound provider-aws


Ubuntu 16.04 LTS environment is deprecated It will be removed on September 20, 2021. Migrate to ubuntu-latest instead.

https://github.com/actions/virtual-environments/issues/3287.
e
On branch migrate-to-ubuntu-latest
⚛👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

Copy the correct template for your contribution

🐛 Are you fixing a bug? Copy the template from https://bit.ly/atom-bugfix-pr
📈 Are you improving performance? Copy the template from https://bit.ly/atom-perf-pr
📝 Are you updating documentation? Copy the template from https://bit.ly/atom-docs-pr
💻 Are you changing functionality? Copy the template from https://bit.ly/atom-behavior-pr

Replace this text with the contents of the template
Fill in all sections of the template
Click "Create pull request"

Don't go to ubuntu-latest see the discussion in https://github.com/atom/atom/pull/22416
It would remove compatibility with older stable distribution releases because of glibc-library compatibilty.
Instead if we have to upgrade, go to Ubuntu 18.04.
If we do upgrade to 18.04 we can also drop this work-around that we had to use to get a more recent rpm from Bionic: https://github.com/atom/atom/pull/22433

I made a PR to update this branch accordingly: https://github.com/atom/atom/pull/22741


BOOL_SAVE_MARKDOWN - SSH Error (using wrong key?)

Required Prerequisites for filing a bug
You must follow ALL the steps in the troubleshooting guide.  Not doing so may result in automatic closure of the issue.
Required information

Steps to reproduce the problem

create a fresh clone of fastpages, follow the initial SSH key setup and merge the pull request (build passes).
edit the "convert notebooks" section of the ci action to save markdown.

    - name: convert notebooks and word docs to posts
      uses: ./_action_files
      with:
          BOOL_SAVE_MARKDOWN: true
          SSH_DEPLOY_KEY: ${{ secrets.SSH_DEPLOY_KEY}}

trigger CI action by pushing any change
get the following key error during this step

Agent pid 10
converting: _notebooks/2020-02-20-test.ipynb
Identity added: _mykey (_mykey)
Warning: Permanently added 'github.com,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

A link to the notebook or markdown file where the error is occurring
This is a clone of the basic repo, so the only ipynb is the test one. https://github.com/SamuelCochrane/fastpages/blob/master/_notebooks/2020-02-20-test.ipynb

If the error is happening in GitHub Actions, a link to the specific error along with how you are able to reproduce this error.  You must provide this in addition to the link to the notebook or markdown file.
https://github.com/SamuelCochrane/fastpages/runs/4846879725?check_suite_focus=true
repro steps listed above.

A screenshot / dump of relevant logs or error messages you are receiving from your local development environment. Instructions of running a local development server is provided in the development guide.
NA, this is a github action issue.

Other Notes
I initially ran into this issue when trying to add the<EMAIL_ADDRESS>action to my existing jekyll site, and received the same error.
After a fresh clone of fastpages, doing no alterations except setting the BOOL_SAVE_MARKDOWN and SSH_DEPLOY_KEY arguments to the action, I still receive the error.
The "Check If Secret Exists" step in the CI action passes, so it does have an SSH_DEPLOY_KEY.
The deploy key was created at https://8gwifi.org/sshfunctions.jsp per the instructions, with the arguments set to RSA/4096/No-passphrase.
In the error, it states it is adding 'github.com,<IP_ADDRESS>' (ECDSA), which is not the algorithm I selected on the website (I selected RSA per instructions). Would this indicate it is somehow using/generating the wrong key?

Bumping this as it's been open for 2+ weeks with no response.

You are problem using the wrong keys in the wrong place.  Maybe you swapped them by accident?

Hi @hamelsmu, could you elaborate?
As per above, I'm testing this on a fresh clone of Fastpages, which only has one key (SSH_DEPLOY_KEY)

I'm a little confused.
Like I mentioned the site builds OK using the SSH_DEPLOY_KEY. Would it still have worked even if it had the wrong value inside the secret?
And sidenote, have you tried my reproduction steps? It should be fairly quick using my notes to see if you get the same issue from a fresh clone of the fastpages repo.  If you don't, then it's probably user error - but I'd like to confirm that you're able to get it working yourself before I close the ticket for that reason.

Hello @SamuelCochrane the issue seems to be permissions.  You can resolve that by setting the right permissions in your repo.
I would suggest starting over again and it should work now!  I have also made some modifications to the fastpages repo such that hopefully, you will have an easier time.
I'll also update the instructions

@SamuelCochrane Actually becaues of changes in GitHub Actions, you have to take extra steps for the setup to work.  I have added detailed instructions in the setup section of the README to show how to resolve this error

Thanks for your patience in helping resolve this. I too seem to be having a similar issue.
I tried re-running the failed build actions but it still gives the same error. Anything else I can do to help you identify the bug? Thanks.
p.s. normal builds without book_save_markdown = true are working fine.
This is my ci.yml file
name: 'fastpages: An easy to use blogging platform with support for Jupyter Notebooks.'
description: Converts Jupyter notebooks and Word docs into Jekyll blog posts.
author: Hamel Husain
inputs:
  BOOL_SAVE_MARKDOWN:
    description: Either 'true' or 'false'.  Whether or not to commit converted markdown files from notebooks and word documents into the _posts directory in your repo.  This is useful for debugging.
    required: false
    default: false
  SSH_DEPLOY_KEY:
    description: a ssh deploy key is required if BOOL_SAVE_MARKDOWN = 'true'
    required: false
branding:
  color: 'blue'
  icon: 'book'
runs:
  using: 'docker'
  image: 'Dockerfile'

This is the error log of the build:
1s
Run fastai/fastpages@master
  with:
    BOOL_SAVE_MARKDOWN: true
    SSH_DEPLOY_KEY: ***

  env:
    SSH_AUTH_SOCK: /tmp/ssh-auth.sock
/usr/bin/docker run --name df00be658c6c34d8a88e2c088a44c7af9_b200b1 --label 08450d --workdir /github/workspace --rm -e SSH_AUTH_SOCK -e INPUT_BOOL_SAVE_MARKDOWN -e INPUT_SSH_DEPLOY_KEY -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_RUN_ATTEMPT -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_REF_NAME -e GITHUB_REF_PROTECTED -e GITHUB_REF_TYPE -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e GITHUB_STEP_SUMMARY -e RUNNER_OS -e RUNNER_ARCH -e RUNNER_NAME -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/www/www":"/github/workspace" 08450d:f00be658c6c34d8a88e2c088a44c7af9
Agent pid 10
No notebooks were modified
Identity added: _mykey (_mykey)
Warning: Permanently added 'github.com,<IP_ADDRESS>' (ECDSA) to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

These are my permission settings:

@akvsak I think you have switched your public/private keys

I will check up on this but would a normal build (without saving markdown) also fail if the keys were swapped?

oh I see I'm not sure about this - is your repo public?

oh I see I'm not sure about this - is your repo public?

Yes. github.com/akvsak/www/


A question about EfficientNet-L2

I notice that your code has supported the construction of EfficientNet-L2 model, but you haven't provided pretrained weights of that model. I‘ll appreciate it if you make your releases contain it.

Sorry, I just notice that my issue is the same as issue#144. Thanks for your answer in that issue.


[e2e]: delegator-lowperms workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5780222446
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Aug  7 02:15:12 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5780341318
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Aug  7 02:35:49 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5780579586
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Aug  7 03:14:11 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/5788529761
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Mon Aug  7 18:22:52 UTC 2023
Tests are passing now. Closing this issue.


[docs] Metrics incorrect menu links

Menu links for the following items are not working:

/mp/metrics/Metrics in HelidonMP
/mp/metrics/Metrics-Capable Modules
/se/metrics/Metrics in HelidonMP
/se/metrics/Metrics-Capable Modules

Hi @romain-grecourt I'm not sure what's broken? The menu links at the top of these pages are working for me:
https://helidon.io/docs/v3/#/mp/metrics/metrics
https://helidon.io/docs/v3/#/mp/metrics/metrics-capable-components
https://helidon.io/docs/v3/#/se/metrics/metrics
https://helidon.io/docs/v3/#/se/metrics/metrics-capable-components

@ljamen The links that don't work for me are in the navbar on the left. For example clicking on "Metrics in Helidon MP" does not do anything.
I noticed that  files all start with metrics-  and the pages that work do not. So I renamed the MP ones to not start with metrics- and they worked! @romain-grecourt I wonder if we have a bug in the tool chain where (waving my hands) if the filename starts with the same word as the directory name the link is broken

@barchetta Odd. I'm not able to reproduce this issue. The nav links are also working for me.

@ljamen the plot thickens! I see: works in Chrome and Safari. Does not work in Firefox.

@barchetta It works in Firefox. That's what I'm using. Bizarre.

This is caused by the uBlock Origin ad blocker. See https://github.com/uBlockOrigin/uAssets/issues/15998

uBlockOrigin has fixed the issue, therefore I am closing.


consolidate csproj settings

very minor changes to remove some noise from the csproj files

i am using this one to merge the slns. so dont merge yet

i am using this one to merge the slns. so dont merge yet

@lukencode i hit a snag. i have one failing test and cant work out the cause

@lukencode i hit a snag. i have one failing test and cant work out the cause

ok this needs to be squashed. but i didnt merge the Renderers since i couldnt get razor to work. happy to work with u on another PR to sort that, but it might need to be a pairing session since i am at a loss as to why it was breaking

ok this needs to be squashed. but i didnt merge the Renderers since i couldnt get razor to work. happy to work with u on another PR to sort that, but it might need to be a pairing session since i am at a loss as to why it was breaking


Fix bad release note link

Part of https://github.com/qiskit-community/qiskit-algorithms/pull/152, but split out into a dedicated change to avoid issues with cherry-picks and release notes, as explained in https://github.com/qiskit-community/qiskit-algorithms/pull/152#discussion_r1486759015.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.625%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6486

Relevant Lines:
7157

💛  - Coveralls


devenv script

Here it is an implementation of a script with commands to interact with all the services required to develop Mostro clients:

The mostro source was replaced by the release binary to avoid compilation.
All the services are configured with config files copied inside the docker images to reduce docker-compose.yml file size.
The start command run a bitcoin and lightning initialization: generating channels within three lnd nodes: one for mostro and two other named alice and bob (representing mostro users).

The idea is to expand this script to create an automated mostro initialization that generates multiples orders with different states. By now, the script has a create_random_orders that emits 6 sell orders with mostro cli, but requires interaction to accept the order (mostro-cli could be modified to accept a --yes flag to avoid interaction).
And the wallets generated in lightning are always random, the idea is to use the hardcoded development mnemonics to make them deterministic.
The functionalities currently supported are:
Usage:
  devenv [options] [command] [args]

Available Commands:
  start                             Start dev environment.
  restart                           Restart dev environment.
  stop                              Stop dev environment.
  sh <service_name>                 Open a shell inside a running container.
  info                              Dev env info.
  private_key <mnemonic> <path>     Generate private key from mnemonic and
                                    derivation path.
  public_key <private_key>          Generate public key from private key.
  bitcoin_cli [args]                Bitcoind client.
  mostro_lncli [args]               Mostro lnd client.
  alice_lncli [args]                Alice lnd client.
  bob_lncli [args]                  Bob lnd client.
  nak [args]                        Nostr relay client.
  mostro_cli [args]                 Mostro client.
  create_random_orders              Create random generated Mostro orders.
  clean                             Clean dev environment.
  help                              Display detailed help.
  version                           Print version information.

Options:
  --help, -h              Alias help command.
  --version, -v           Alias version command.
  --log-level <level>     Set the log level severity. Lower level will be
                          ignored. Must be an integer or a level name:
                          trace debug info warn error fatal.
  --                      Denotes the end of the options.  Arguments after this
                          will be handled as parameters even if they start with
                          a '-'.

Summary by CodeRabbit
Release Notes

New Features

Updated the README to reflect changes in setup instructions and service definitions.
Introduced a new script for managing the development environment (devenv).
Added new services and health checks in the Docker Compose configuration.
Added a new configuration file for the Nostr Relay application.
Enhanced utility scripts for managing Bitcoin and Lightning Network operations.

Documentation

Revised README for clarity on environment setup and service management.
Removed outdated documentation files to streamline the project.

Chores

Consolidated various scripts for better management of Bitcoin and Lightning Network operations.

what a great work, how can I connect with the relay? usually I monitor all connections to relay with nostreq like this
nostreq --kinds 10002,38383,1059 --limit 5 | nostcat --stream ws://localhost:7000 |jq

how can I connect with the relay?

After running ./devenv start the nostr relay is binded to port 8080 of localhost.
Changing the port from 7000 to 8080 should work.
nostreq --kinds 10002,38383,1059 --limit 5 | nostcat --stream ws://localhost:8080 | jq


some bug in the message life time

it will how the message was produced 6 hours ago even though it was produced a minute ago. https://i.imgur.com/JCSb9Mx.png

Same here, but it says 2 hours. I'm on UTC+2 time and I'm guessing that's what it's referring to.

Releasing a fix for this today.

This is solved.