[Question] What's the role of fixedEntries in a TransactionSkeleton?

As per title, I'm wondering: within a Lumos typescript, what's the role of fixedEntries in a TransactionSkeleton?
As usual I'm asking here since GitHub issues are SEO friendly and very likely in the future there will be other L1 developers wondering the same :wink:
Phroi

fixedEntries in a TransactionSkeleton defines a list of entries that are considered "fixed" and should not be changed while generating or modifying the transaction.
This is useful when working with specific cells in a transaction that you don't want to be modified by other functions in @ckb-lumos/common-scripts and operations while building the transaction.

Good to know!! Thank you @homura, for the complete response and the drawing, very appreciated! :pray:


KVStoreDist::Init called many times

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
When running 1 worker and 1 server with distributed learning, I noticed that while the worker initializes one KVStoreDist (src/kvstore/kvstore_dist.h), its Init() call appears to be called many times.
I'm wondering if this intended and why is this necessary?
Many thanks!
Environment info
Operating System:
Ubuntu 14.04
Compiler:
GCC 5.2
Package used (Python/R/Scala/Julia):
Python
MXNet version:
Or if installed from source:
Installed from source
MXNet commit hash (git rev-parse HEAD):
df27b9c7c35d98f22b9b19d6c84af21f5df97400
If you are using python package, please provide
Python version and distribution:
If you are using R package, please provide
R sessionInfo():
Error Message:
...
[04:14:44] src/kvstore/./kvstore_dist.h:63: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Calling INIT 0
[04:14:44] src/kvstore/./kvstore_dist.h:77: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Calling Barrier 0
[04:14:44] src/kvstore/./kvstore_dist.h:80: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Ending INIT 0
[04:14:44] src/kvstore/./kvstore_dist.h:63: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Calling INIT 0
[04:14:44] src/kvstore/./kvstore_dist.h:77: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Calling Barrier 0
[04:14:44] src/kvstore/./kvstore_dist.h:80: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Ending INIT 0
[04:14:44] src/kvstore/./kvstore_dist.h:63: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Calling INIT 0
[04:14:44] src/kvstore/./kvstore_dist.h:77: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Calling Barrier 0
[04:14:44] src/kvstore/./kvstore_dist.h:80: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!Ending INIT 0
...
Minimum reproducible example
~/mxnet/tools/launch.py -H ~/train/hosts -n1 -s 1 python train_resnet.py --data-dir /home/ubuntu/train/imagenet/data/lowq256/ --aug-level 1 --depth 18 --batch-size 1 --kv-store dist_sync_device
Steps to reproduce
Just run that script
What have you tried to solve it?
I'm not sure if this is a problem or is known (so it's intended)

Ugh looks like
for idx, param_on_devs in enumerate(param_arrays):
kvstore.init(idx, arg_params[param_names[idx]])
if update_on_kvstore:
kvstore.pull(idx, param_on_devs, priority=-idx)
This is called per key?

Yes it's doing initialization per key

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


Parse & Align Sequence Data from CSV

LANL (and MicrobeTrace, for that matter) gives the ability to download CSVs with sequence columns embedded. It seems desirable to parse this sequence data as though it came from a FASTA file.

Oh, forgot about this one. It's been resolved by a battery of commits around multiple-file loading, capped off by 7821e05217008eae41d4314e484ab32b56c7b8ea.


Fix docker-compose config on Apple silicon

Description
Adds an explicit platform to relevant python service definitions in both local.yml and production.yml.
Checklist:

[x] I've made sure that tests are updated accordingly (especially if adding or updating a template option)
[x] I've updated the documentation or confirm that my change doesn't require any updates

Rationale
When running from scratch on Apple Silicon, the default django service would continuously poll for a postgres connection. After logging the psycopg2 exception in the container entrypoint, I found that the script was silencing a connection error stating the following:
SCRAM authentication requires libpq version 10 or above

Upon further investigation, I found that there was an inconsistency with some versions of the python image that would install an outdated version of libpq. According to the Docker Desktop documentation:

Not all images are available for ARM64 architecture. You can add --platform linux/amd64 to run an Intel image under emulation.

We can specify this within the docker-compose files by setting the platform property on a service.

Thanks for the fix! 🎉

Hello.
I start play with project on Friday  and continue today. That's why I notice this change.
Issue
When I try to build image:
docker-compose -f local.yml build
I receive errors:
Unsupported config option for services.celerybeat: 'platform'
Unsupported config option for services.celeryworker: 'platform'
Unsupported config option for services.django: 'platform'
Unsupported config option for services.docs: 'platform'
Unsupported config option for services.flower: 'platform'

Reaserch
I thing I found similar issue:
https://github.com/blabla1337/skf-flask/issues/744
Context
os
VERSION="18.04.6 LTS (Bionic Beaver)"
docker version
Client: Docker Engine - Community
 Version:           20.10.12
 API version:       1.41
 Go version:        go1.16.12
 Git commit:        e91ed57
 Built:             Mon Dec 13 11:45:27 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.12
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.16.12
  Git commit:       459d0df
  Built:            Mon Dec 13 11:43:36 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.12
  GitCommit:        7b11cfaabd73bb80907dd23182b9347b4245eb5d
 runc:
  Version:          1.0.2
  GitCommit:        v1.0.2-0-g52b36a2
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker-compose version
docker-compose version 1.26.0, build d4451659
docker-py version: 4.2.1
CPython version: 3.7.7
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019

@foarsitter
Thank for your help. I confirm platform works  with:
docker-compose version 1.29.2, build 5becea4c
docker-py version: 5.0.0
CPython version: 3.7.10
OpenSSL version: OpenSSL 1.1.0l  10 Sep 2019


vertices impl questions

In vertices.cc I see the impl of Vertices::init
SkVertices::Builder builder(vertex_mode,
                            positions.num_elements() / 2,
                            indices.num_elements(),
                            builderFlags);

if (positions.data())
  DecodePoints(positions, builder.positions());
if (texture_coordinates.data())
  DecodePoints(texture_coordinates, builder.texCoords());
if (colors.data())
  DecodeInts<SkColor>(colors, builder.colors());
if (indices.data())
  DecodeInts<uint16_t>(indices, builder.indices());

The builder assumes several things (that aren't obvious to me are checked by the caller)

positions are required -- SkVertices is meaningless with out them, but we do a .data() check

I presume DecodePoints just goes off of the size of the array, but the builder assumes that len(positions) == len(texCoords) == len(colors). Are we assured of that?

Skia does not validate that the indices are all within [0...len(positions)-1]. Should we do that check here? (not sure about this one).

@chinmaygarde or @abarth would know.

The Dart wrapper for Vertices tries to check the validity of the arguments before calling the native peer:
https://github.com/flutter/engine/blob/master/lib/ui/painting.dart

Cool.
A reader in the native code might want to see asserts. I may post a CL with
that. Thanks.
On Wed, Apr 5, 2017 at 6:05 PM, Jason Simmons<EMAIL_ADDRESS>wrote:

The Dart wrapper for Vertices tries to check the validity of the arguments
before calling the native peer:
https://github.com/flutter/engine/blob/master/lib/ui/painting.dart
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/9226#issuecomment-292011024,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMa7oluata8Mga7uYQ23A_dXrNMKHlqmks5rtBAVgaJpZM4M0qMG
.


bat version 0.3.5

Codecov Report

Merging #87 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   92.31%   92.31%
=======================================
  Files          24       24
  Lines        1028     1028
=======================================
  Hits          949      949
  Misses         79       79

Impacted Files
Coverage Δ

bat/__init__.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80ed70...0e818fc. Read the comment docs.


Awaited async calls capture and re-enter the synchronization context which may lead to deadlocks

The library does not .ConfigureAwait(false) on all internal await calls, thus it unnecessarily captures the synchronization context.
This may lead to deadlocks:
http://www.tugberkugurlu.com/archive/the-perfect-recipe-to-shoot-yourself-in-the-foot-ending-up-with-a-deadlock-using-the-c-sharp-5-0-asynchronous-language-features

@verdie-g - please note that I am working on a pull request to resolve the above.

Yep, I'm aware of this issue. I didn't use ConfigureAwait because I've always used this library in full asynchronous scenarios where waiting on a Task is not allowed. If you need it though, feel free to open your pull request.


Desktop notification on dispatching an action

We could add a notify parameter in createLogger function that will generate a desktop notification on state change. It will be handy to see action.type in notifications, and there will be no need to check to the console for just checking that action was dispatched. Any thoughts.

It's redux-logger, not redux-notifier


Update nltk

⚠ IMPORTANT: Please do not create a Pull Request without creating an Issue first.
All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.
Before submitting a pull request, please be sure to review:

Our Code of Conduct: https://github.com/COVID-19-electronic-health-system/.github/blob/master/CODE_OF_CONDUCT.md
Our Contributing Guidelines: https://github.com/COVID-19-electronic-health-system/.github/blob/master/CONTRIBUTING.md
Our Support documentation: https://github.com/COVID-19-electronic-health-system/.github/blob/master/SUPPORT.md

Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.
Fixes #703
Summary
nltk bumpet to 3.4.5 version
Details
nltk bumpet to 3.4.5 version
Test Plan (required)
check requirements.txt
Final Checklist

[x] For CoronaTracker, did you bump the version in package.json?

Update the second decimal for a major change
Update the third decimal for a minor change
Numbers can go past 9, e.g. 1.0.9 => 1.0.10
For more info, read about Semantic Versioning

[x] Did you add any new tests as necessary?
[x] Is your PR rebased off the most current master?
[x] Have you squashed all commits? (can be done at merge)
[x] Did you use yarn not npm? (important!)
[x] Did you use Material-UI wherever possible?
[x] Did you run yarn lint on the code?
[x] Did you run all of your most recent changes locally to make sure everything is working?

So I didn't realize this, but apparently there's a bot that goes in and creates a PR to seamlessly fix this. Assuming that works, I'll tentatively close this PR :/


chrome dinosours game

Describe the project you want to add with tech stack
chrome dinosours game
Expected behavior
I want to create chrome dinosours game which is monitoring with keyboard
Screenshots (optional)

Additional context (optional )
languages used html,css,javascript.

Is this repo not part of hacktoberfest or hacksquad??

Hey @sadanandpai can you assign me this issue want to work on it.


Suggestion: change documentation link icon against sample queries to a more intuitive icon

Is your feature request related to a problem? Please describe.
Telemetry data indicate that the number of documentation link clicks compared to sample query runs is very low.
Describe the solution you'd like
Update documentation link icon to something more intuitive.

Describe alternatives you've considered
A different icon.

@RabebOthmani, @adhiambovivian  Thoughts on this?

looks good to me @millicentachieng


modify sub module of omr-agentcore to use 3.0.9 release

merging as needed to get 1.0.12 release of appmetrics built and no code changes require buddy checking


New style tag syntax.

Running this play with ansible2 gets error:
"ERROR! Include tasks should not specify tags in more than one way"

I haven't tested backwards compatibility, might be useful.  Thanks for the role.


Can't change speed

Setting the speed in bpm/wpm when initializing makes no difference. Tested in Safari 11 and Firefox 56.

Ok so – bpm in README.markdown seems to be a typo.


Readme

Hi,

I recently installed manim on Linux and I struggled a bit getting everything done right. I wrote a small installation guide for Linux to help newcomers to use your library.
When everything was running. I uninstalled everything and registered every command I used. When I was over, I reinstalled everything following my tutorial and it's working:)

By the way, I love this project and particularly your youtube channel.

Is there any particular reason why you closed this? It looks like a reasonable change to me. If you feel like reopening it, you'll have to mention that miktex isn't included in the default repositories for ubuntu. Additionally, the first step has a misleading title, since it installs system dependencies other than latex.

Hi, first I choose to install manim into the /lib folder arbitrary which is usless and maybe not a good option. Secondly, the pull request failed when I used the command line. I do the changes and I repull.
Thank you for your comment !


Made set public

Explain rationale?

http://prntscr.com/at1muu
I'm using it to extend your repo

OK, I'm cool with this change, but would you mind adding a /// ... documentation comment to explain the method? A small test case wouldn't hurt either.

I don't think a test case would help much. The functionality is very straight forward, instead of a test method, protecting user from bad inputs may be useful. I can't think of inputs that will crash this atm but I am sure there are some.

I agree the set should be made public. In the readme you say that you can create custom types, but this is not possible unless you redefine the set function in the consuming side.
For testing this, in TestHelper you are already defining custom types that use that same set function which still work. The only way to really test this is to create a module outside of the workspace, consume SwiftyUserDefaults, then define custom types without having to explicitly recreate the set function. I just tried this in my app by consuming SwiftyUserDefaults via Carthage, adding the checkout to my workspace, and modify the source code to make the set public. I was able to define my own custom types without having to redefine the set function 👍

Thanks!


Write prompt to file error

Describe the bug
INFO:dynamic_prompting.py:Prompt matrix will create 8 images in a total of 8 batches.
ERROR:dynamic_prompting.py:Failed to write prompts to file: 'charmap' codec can't encode character '\u0142' in position 1208: character maps to
Version used
Dynamic-prompt extension 0.25.0
think is due to my artist.txt wildcard file that contain nord-european painter with Ä (142 in my charmap) in their name.
some google search suggest it correspond to this polish char: ł

photographers.txt
in line 1201 u will find ł  in upper and lowercase

Could you please test? I couldn't reproduce the error but my locale is probably different to yours.

Could you please test? I couldn't reproduce the error but my locale is probably different to yours.

tested with an artists file filtered only on names with "strange" characters and works very well. Nice work again.


all: update/add checksums/manifests

Built on an Alpine chroot, so the manifests may not be perfectly correct.

:+1:


Quick action buttons (reset, pause, main menu)

Added GUI to pause/play/restart/go to main menu. No main menu scene, but the signal does exist. Commit

Added GUI to pause/play/restart/go to main menu. No main menu scene, but the signal does exist. Commit


Generate navigation stack when using nested routes

Hi all.
Could be usefull if Get create the navigation stack when user access one nested route directlly.
Using the docs example, if I create three pages, 'home', 'products' and 'eletronics', like this:
GetPage(
      name: '/home',
      page: () => HomeView(),
      binding: HomeBinding(),
      children: [
        GetPage(
            name: '/products',
            page: () => ProductsView(),
            binding: ProductsBinding(),
            children: [
              GetPage(
                 name: '/electronics',
                 page: () => ElectronicsView(),
                 binding: ElectronicsBinding(),
              ),
            ],
          ),
      ],
  );

if the user navigate to '.../home/products/eletronics', the navigation stack will be empty and back button will not be visible, so could be usefull if Get sets the navigation stack, but, without building them. just place on navigation stack so the user can back to parent page.

With Navigator 1.0, we have no control over the Stack.
With the migration to Navigator 2.0 on GetX 4 this will be possible

Ok, I will wait for GetX 4.0, thanks.

How would this be done in GetX 4? I could not find any documentation


ensure the main process raise an exception when the subprocess fails

When the subprocess of testing imports and basic workflow runs and errors out, the main process still exit with code 0, which would not fail the CI.
This PR will make the CI fail when the subprocess fails.
This PR should be merged after #18655 .

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (689cd70) 78.50% compared to head (cfd2a8d) 57.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18663       +/-   ##
===========================================
- Coverage   78.50%   57.94%   -20.56%
===========================================
  Files         334      334
  Lines       32605    32605
  Branches     6377     6377
===========================================
- Hits        25595    18892     -6703
- Misses       5454    12283     +6829
+ Partials     1556     1430      -126

Flag
Coverage Δ

keras
57.94% <ø> (-20.45%)
:arrow_down:

keras-jax
?

keras-numpy
57.94% <ø> (ø)

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 179 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Encryption update notification should tell user how to fix any issues

The current text is very absolute, making it sound like the connections will be broken without a way to fix them which is a pretty scary thing for people to see pop up right after updating.
I would suggest making it a little clearer that this is easily fixed - something like ...no longer working unless certain Encryption related connection properties are changed.

cc @erinstellato-ms


Match_label_with_feature bug when more than one event is skipped

match_label_with_feature has a bug which only catches single events which are skipped, if two events have not been aligned using signalalign then we do not capture the second or third skipped event in the final training matrix.

Bug was fixed with this commit: af2d4dcd566dc411d42cca584b7d01e3da91413c. We just created a while loop which added null labels. We may want to add a tracking step at this point to get some QC data from the data preparation.


Added an option to support displaying screenshot of the element

Liliia (@lpelypenko), thanks for this useful project, it allows us to generate customized report with the foundation you have built.
One thing we love to have is the ability to display a screenshot of an element that has the violation to the specified rules. Because different clients may use different browser driver, with an option to pass in a custom function that returns the processed screenshots will be ideal for broader adaption.
In our case, with this proposed option, we are able to do this:
 // Axe-core reporting
    const results = await new AxePuppeteer(page).analyze();

    await createHtmlReport({
        results,
        options: {
            screenshotFunction: async selector => await (await page.$(selector))?.screenshot({encoding: 'base64'})
        }
    });

    await browser.close();

Which allows us to display an image like this:

Hi @zhenyanghua,
I am so sorry for the delay, I will try to look on how this feature works for me locally this week and release by the weekends.

Hi @zhenyanghua,
can you please provide full example of screenshotFunction usage that I can run it locally?

I am also interested in this functionality. We need to pass reports back to a Design Team, and without screenshots it's more tricky.


Conditionally compile

Is it better to conditionally compile these files for reducing binary size for mobile app?
https://github.com/grovesNL/spirv_cross/blob/6bcf6a58e776bb1bc4d49d8e232c7d48f4793f15/spirv_cross/build.rs#L26-L28

This is fixed in the latest release (0.13.0): features glsl, hlsl, and msl are now available.


Getting render() got an unexpected keyword argument 'renderer' in Django 2.1.1

django-json-widget version: 0.1.1
Django version: 2.1.1
Python version: 3.6.5
Operating System: MacOS High Sierra 10.13.6

Description
Getting error when following the default installation instructions.
TypeError at /admin/core/user/5/change/
render() got an unexpected keyword argument 'renderer'

What I Did
Steps to reproduce:

pip install django-json-widget
settings.py

    ...
    'django_json_widget',
    ...
]

admin.py

from django_json_widget.widgets import JSONEditorWidget

class JsonAdmin(admin.ModelAdmin):
  formfield_overrides = {
    JSONField: {'widget': JSONEditorWidget }
  }

@admin.register(DuitUser)
class UserAdmin(JsonAdmin):
    list_display = ('first_name', 'last_name', 'mobile_number')

Open localhost:8000/admin in browser. You should see the error Exception Value: | render() got an unexpected keyword argument 'renderer'

Possible reasons
This is almost certainly because of this backwards-incompatible change in Django 2.1.
https://stackoverflow.com/a/52039655/842837

I close this issue because I already uploaded on PYPI a new version and fixed it. Thanks for waiting


Update install.md

@haroldus- Thanks for updating the install docs 😁 Merged in!  Here's the docs: http://rubyonjets.com/docs/install/


fix: spell check error

Description
Fix this error.
Warning: Unknown word (iscloam)
Warning: Unknown word (iscloam)
Files checked: 143, Issues found: 2 in 1 files.
Error: 2 spelling issues found in 1 of the 143 files checked.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Checking spell_check in my local environment,
autoware-documentation/docs/design/autoware-interfaces/components/perception-interface.md:102:9 - Unknown word (unint)
is also appearing.
Can you help us fix this typo as well?
https://github.com/autowarefoundation/autoware-documentation/blob/04321c92e06472faf10353ebacc34eab5a915a6f/docs/design/autoware-interfaces/components/perception-interface.md?plain=1#L102
unint8-> uint8

Thank you. Fixed it.


Retry Across Tasks

It doesn't seem to be in the scope of Airflow, but I just wanted to check if there are any easy solutions for this. If I have tasks 1,2,3 and want to conditionally retry them based on the outcome of a task 4, it seems that I can't because a conditional branch pointing to 1 would create a cycle. I'd guess the way to handle this would be recording the need to retry in a database and having something else schedule a re-run of the workflow. Has anyone set up a system to do this sort of thing?
Thanks for any answers!

@aaron-starov would it be possible for you to contain your four tasks in a subdag and retry on the subdagoperator ?

@syvineckruyk thanks, yes, that would be perfect -- I missed the subdagoperator.


Updates to examples to clarify width/height

This is just an extension of the conversation from #17. I want to clean up the examples, maybe make a few more, and simplify the documentation on them. You mentioned:

In my own code I have just a single constant that is number of segments and I calculate everything based on that one.

This is what's in the examples now:
// Define LED Matrix dimensions: 32x8, 16x8, or 8x8
const int LEDMATRIX_WIDTH    = 32;
const int LEDMATRIX_HEIGHT   = 8;
const int LEDMATRIX_SEGMENTS = LEDMATRIX_WIDTH / LEDMATRIX_HEIGHT;

// The LEDMatrixDriver class instance
LEDMatrixDriver lmd(LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN);

Are you suggesting it be changed to:
// Number of 8x8 segments you are connecting
const int LEDMATRIX_SEGMENTS = 4
const int LEDMATRIX_WIDTH    = LEDMATRIX_SEGMENTS * 8

// The LEDMatrixDriver class instance
LEDMatrixDriver lmd(LEDMATRIX_SEGMENTS, LEDMATRIX_CS_PIN);

Just want to clarify before I submit some PRs

Merged, thanks :)


Testing runhouse install

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1373  👈
#1336 : 1 other dependent PR (#1343 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mkandler and the rest of your teammates on  Graphite


FAIL: Test adding distances to source space

I'm getting a failing test:
======================================================================
FAIL: Test adding distances to source space
----------------------------------------------------------------------
Traceback (most recent call last):
File "/autofs/cluster/pubsw/2/pubsw/Linux2-2.3-x86_64/packages/python/anaconda/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
File "/autofs/cluster/pubsw/2/pubsw/Linux2-2.3-x86_64/packages/python/anaconda/lib/python2.7/site-packages/numpy/testing/decorators.py", line 146, in skipper_func
    return f(*args, **kwargs)
File "/autofs/cluster/pubsw/2/pubsw/Linux2-2.3-x86_64/packages/python/anaconda/lib/python2.7/site-packages/numpy/testing/decorators.py", line 146, in skipper_func
    return f(*args, **kwargs)
File "/autofs/space/megmix_002/users/mluessi/data/code/mne-python/mne-python/mne/tests/test_source_space.py", line 138, in test_add_source_space_distances
    assert_array_equal(so['dist_limit'], np.array([-0.007], np.float32))
File "/autofs/cluster/pubsw/2/pubsw/Linux2-2.3-x86_64/packages/python/anaconda/lib/python2.7/site-packages/numpy/testing/utils.py", line 719, in assert_array_equal
    verbose=verbose, header='Arrays are not equal')
File "/autofs/cluster/pubsw/2/pubsw/Linux2-2.3-x86_64/packages/python/anaconda/lib/python2.7/site-packages/numpy/testing/utils.py", line 645, in assert_array_compare
    raise AssertionError(msg)
AssertionError:
Arrays are not equal

(mismatch 100.0%)
x: array(None, dtype=object)
y: array([-0.007], dtype=float32)

is this fixed?

Should be, I think it was just a case of an outdated sample dataset


Slight efficiency improvement on all page transitions

There's a slight redundancy having the various page transitions themselves listening to the route animation since all of the rebuilding can be delegated to its descendants.
This should effectively remove one build per frame.

Just a random thought, maybe this exists already but I didn't find it in https://flutter.io/debugging
We could add a 'insight' output verbosity filter or something in debug mode where we log the number of times States get setState called on by the user but creates the same (shallow) Widget as the last build call. Then we can print a nice table to help users catch redundancies.


Fetch detailed information about each project

Having an axios request inside of the projects.map simply wouldn't generate a schema for me. By adding it outside of that it would work. However, I noticed that the detailed information of each project (/projects/:projectID) would include all the information that is present in the general information of all the projects (/users/:userName/projects). So it made more sense to me to simply extract all of the information from the detailed information about each project.
Also, to get around the keys-being-numbers issue I broke the keys down into arrays with strings as keys. I think the naming could perhaps be better in some places.
Let me know if it works / what you think! 👍

I just noticed there is a breaking change 😕
The cover field has been removed, as it has been turned into an array now: https://github.com/LeKoArts/gatsby-source-behance/pull/1/files#diff-b795d1c35ffc98dcf589692c744446ceL57.
I'm not really sure what the appropriate way is to handle this, if people are actively using this plugin with the cover field it'd break. It could be re-added but I don't know if that's the right thing to do 🤔

Cool, thank you!
I‘ll have time to test it next week :)
Did you also test the modules? So that we could programatically create project pages with all the content (text + images)?

I'm sorry but I don't know which modules you're talking about? 🤔 Wasn't aware of any, if you could point me in the right direction I'll look what I can do 😄

modules: project.modules
It contains both texts and images (basically the content of thr post)

Oh offcourse, thought you were talking about components in React or something, I will test it sometime this week, will get back with the results here.

So, after further testing it was indeed the case that the mapping of  project.modules had to be adjusted, now it will check if the type is of images or grid_collection and only then it will map the number keys. In case of other types it will leave it untouched (I didn't spot any keys that were numbers in these cases).

As you see I changed some things afterall :D


work around the buggy behavior of textNode in old chrome. fix #6601

What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
fix #6601
There are currently many browsers based on the outdated chrome in China which could not got autoupdated.
This PR tries to work around the textNode wrong behavior in old version of Chrome.
As for the proper test case, I haven't added the proper test case as it's a problem of outdated browser version. Let me know if it is necessary to add it.

Thanks for the PR! I found an easier fix by force removing the node before applying innerHTML/textContent in 0f2cb094


Add preferredWorkflow to settings, and fix issue with its setup.

This patch adds the preferredWorkflow option to the plugin settings. It also fixes an issue where the setting was being overridden by the defaults, and the user setting was never used.

Hi @benjypng, great plugin! I'd like to use the TODO option for the preferred workflow, but I found that I couldn't set it in the settings menu, and setting it in the JSON would get overwritten.
After removing the updateSettings call, everything started working for me, but it's unclear if that call was needed for anything (first time I've hacked on these plugins).

Hey thanks! I have not updated the plugin in a long time so the approach was rather old. There has since been changes to the Logseq API and I just gave it a refresh last night. Your issues should be resolved in the latest version.

Ah that's great, code looks much cleaner now too :)
Checked and it's all working for me now, thanks!
Something I noticed though is that the append_source option doesn't work if we're on the journals homepage - doesn't look like there's a simple way to fix it though since getCurrentPage returns null in this situation but I may be wrong.
@benjypng what do you think about defaulting to the current date journal page in this case? I could submit a PR for this.

Hmm I actually prefer not to do that since it's not actually accurate to default to the current date journal page. I rather it just return null since that is in fact what is happening.

Ah ok, makes sense. Do you think that behaviour could be added as an additional option that's disabled by default?

It is a straightforward enough change, I am just not sure of the use-case yet.
The most "product" way to handle it will actually be to notify the user that they are on the home page if they have that option enabled when trying to use the append source option.

My use-case for it is that I use the Journals home page for adding in my notes, and I like to be able to see what tasks were added on which days.
I agree regarding a message being shown when it's null - I thought something was broken when nothing was being appended.


DBZ-996 Tolerate race condition in PK updates

https://issues.jboss.org/browse/DBZ-996

Applied. Thanks, @jpechane!


Custom layout does not support SwiperControllerEvent.MOVE_INDEX yet!

why  Custom layout does not support SwiperControllerEvent.MOVE_INDEX yet!
自定义布局的swiper如何通过使用函数出发跳转到某个index
How to jump to an index by using the function when use custom swiper

any solutions ?

May be you can try controller.next() and controller.previous() ???


Moving all views between side panel and panel does not preserve active one

Testing #141357
I would have expected:

the order to preserve
the active view to restore
the active view getting focus after the op

the order may be preserved only on the first move since each part caches its order.
restoring focus/active needs to be fixed


Reexport asset_store under piston

Blocked by https://github.com/PistonDevelopers/asset_store/issues/16
Perhaps a current object could be set up to make asset loading easier?

This is outdated.


Populate the status for direct connections and ensure Kafka and SR proxies use credentials in headers

Resolves #123
Summary of Changes
Completes the functionality of direct connections, though we will add more integration tests as follow-ons. For example, the existing ITs use LocalTestEnvironment that runs containers without authN, and the recently-added ITs for direct connections use no credentials. We'll need another ConfluentPlatformTestEnvironment that runs CP clusters with several authN mechanisms enabled, and then we'll run additional tests against that.
Any additional details or context that should be provided?
This PR modifies the DirectConnectionState class to properly populate the status for direct connections, after verifying the ability to connect to Kafka using an AdminClient and to SR using an SR client.
It also fixes a few issues with how we compute the authentication-related headers using the credentials. These headers are used in the Kafka REST proxy and SR proxy implementations.
It adds some debug log messages to the ‘KafkaProducerClients’, KafkaConsumerFactory, SchemaRegistryClients and AdminClients beans, including logging at debug level the (redacted) configuration properties for these clients. To make it easier to log the redacted configurations, the ClientConfigurator class was changed to return a Configuration object rather than a Map<String, Object>. The Configuration object has one method to get the configuration properties as a map, while the toString() and other methods ensure that only the redacted form of the configuration is otherwise exposed.
Finally, fixed a bug in BasicCredentials and ApiKeyAndSecret classes in the httpClientHeaders() implementations. This method returns the authorization-related HTTP headers, and the base64-encoded value was not being created correctly. A few unit tests were added, using obviously-fake secret values.
Pull request checklist
Please check if your PR fulfills the following (if applicable):

Tests:

[x] Added new
[ ] Updated existing
[ ] Deleted existing

[x] Have you validated this change locally against a running instance of the Quarkus dev server?make quarkus-dev

[x] Have you validated this change against a locally running native executable?make mvn-package-native && ./target/ide-sidecar-*-runner

Thanks for the review, @flippingbits. I've incorporated your feedback -- would you please take a look?


[BUG] Table hyperlink

I am really loving this little gem of python! Thanks for the awesome work!
I am trying to make an hyperlink to work on tables without success.
from rich import print
from rich.console import Console
from rich.table import Table

c = Console()
table = table = Table()

#does not work
table.add_row('Hello [link="https://google.com"]World[/link]')

#does not work
table.add_row('Hello [link=https://google.com]World[/link]')

#works
table.add_row('https://google.com')

c.print(table)

This is the code I have been trying. I want to be able to rename links.
Mac OS Monterrey with ZSH terminal

Not all terminals support the link code. But most will turn URLs in to link. If you are on MacOS, give iTerm a try, which support links and is better than the standard console.

Thanks for your quick answer!
It appears to be tmux my problem, as without it, it works.


Refused to frame https://myinstance.my.connect.aws/

[x] Added domains to Approved Origins
[x] Updated to latest Amazon Connect Streams version
[x] Checked existing Issues on Github

Our application has the following error when rendering the iframe for Amazon Connect: Refused to frame 'https://myinstance.my.connect.aws/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self'".
We are able to bypass this error for development by using a chrome extension to remove X-Frame-Options and Content-Security-Policy response headers, but we need a solution to be able to go to production. We have looked in old github Issues for solutions but have not been successful in our attempts to resolve this. The common reason for this error is that the domains have not been added to the Approved Origins, but we have confirmed that they were added. It seems likely this issue would be caused by our response headers, but we have not had any success in resolving the error by changing our configuration. We also ensured that third part cookies are enabled. Any assistance would be appreciated!
const middleware = [
  (req: Request, res: Response, next: NextFunction): void => {
    res.locals.env = getEnv()
    res.set('Content-Security-Policy', "frame-ancestors 'self';")
    next()
  },
]

app.prepare().then(() => {
  const server = express()

  server.use(
    helmet({
      contentSecurityPolicy: {
        directives: {
          'default-src': ["'self'"],
          'frame-ancestors': ["'self'", "https://myinstance.my.connect.aws"],
        },
      },
      crossOriginEmbedderPolicy: false,
    })
  )

[...]

  server.get('*', middleware, (req: Request, res: Response) => {
    return handle(req, res)
  })

  bootstrap(server).then((server) => {
    server.listen(PORT, () => {
      logger.info(> Ready on http://localhost:${PORT})
    })
  })
})

  connect.core.initCCP(containerDiv, {
    ccpUrl: https://myinstance.my.connect.aws/ccp-v2,
    loginUrl: https://myinstance.my.connect.aws/connect/login,
    loginPopup: false,
    softphone: {
      allowFramedSoftphone: true,
    },
    pageOptions: {
      enableAudioDeviceSettings: true,
      enablePhoneTypeSettings: true,
    },
    ccpAckTimeout: 1,
    ccpSynTimeout: 1,
    ccpLoadTimeout: 1,
  })

Similar to this: https://github.com/amazon-connect/amazon-connect-streams/issues/871#issuecomment-2523939631


Getting Nosync from OSSC

Hi,
I have been using the mod for a while without any issues with OSSC. All of a sudden I get a "Nosync" reponse by the OSSC.
Component cable already changed but this is not the issue(working cable with other consoles). I tried everything on the OSSC end (sync settings) to no avail.
Any ideas or ways to understand what's happening?

Obviously something has gone bad suddenly. Try to narrow down the possibilties. Is it maybe the OSSC itself? Try to use it with a different computer.
When the OSSC is OK, try to feed a signal from the C64 A/V port to the Y input. Compositive video or luma should both give working sync, even if the picture is then black and white. When this works you need to do a bit more diagnostic.
You may find this issue thread useful for doing the troubleshooting:
https://github.com/c0pperdragon/C64-Video-Enhancement/issues/75

I switched chips between 2 breadbins and it worked out well (I did the same previously with the same machines and it didn't work...). So everything is fine now, thanks a lot!


HL-375 | Only render training compensation row if amount > 0

Description :sparkles:
Issues :bug:
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #629 (865a561) into develop (964f801) will increase coverage by 32.93%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           develop     #629       +/-   ##
============================================
+ Coverage    61.85%   94.78%   +32.93%
============================================
  Files          587      167      -420
  Lines        14700     6802     -7898
  Branches      1471        0     -1471
============================================
- Hits          9092     6447     -2645
+ Misses        5322      355     -4967
+ Partials       286        0      -286

Impacted Files
Coverage Δ

backend/benefit/calculator/rules.py
94.54% <100.00%> (ø)

backend/shared/shared/azure_adfs/views.py
41.17% <0.00%> (-41.18%)
:arrow_down:

backend/shared/shared/oidc/auth.py
81.48% <0.00%> (-1.86%)
:arrow_down:

frontend/shared/src/components/header/useHeader.ts

frontend/tet/admin/next.config.js

...t/applicant/src/hooks/useDeleteApplicationQuery.ts

...saseteli/employer/src/components/header/Header.tsx

...er-tests/thank-you-page/thankYouPage.components.ts

...c/hooks/employments/useWatchEmployeeDisplayName.ts

...d/src/components/forms/inputs/SelectionGroup.sc.ts

... and 413 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964f801...865a561. Read the comment docs.


Fix timestamp with timezone comparison

In the original comparison the timestamp with timezone value had the millisecond portion of the value adjusted to UTC based on the timezone id of the value.
However, this is not correct because the millisecond value is already adjusted and normalized to be in UTC and can, therefore, be directly compared.

Fixes https://github.com/prestodb/presto/issues/21188

@majetideepak Please take a look.

Hi @czentgr, a recent change has made TimestampWithTimezone type be a Bigint type instead of a Row type (https://github.com/facebookincubator/velox/pull/7480), so there is a merge conflict now. Could you rebase this PR to resolve the conflict?

@kagamiori Thanks for making me aware of the changes. I rebased the PR.


Chatbox is not safely parsing when contents include code

Describe the bug
The following input gets no response and causes a console error that references the onopen function from the code. It appears that the code is somehow being executed - or at the very least not safely parsed.
To Reproduce
Try sending the following:

change the modal to use nextui modal. dont output all the code, just the parts that we need to change:
The Modal handles the focus within the modal content. It means that you can use the modal with form elements without any problem. the focus returns to the trigger when the modal closes.

Preview

Code
App.jsx
MailIcon.jsx
LockIcon.jsx
import React from "react";
import {Modal, ModalContent, ModalHeader, ModalBody, ModalFooter, Button, useDisclosure, Checkbox, Input, Link} from "@nextui-org/react";
import {MailIcon} from './MailIcon.jsx';
import {LockIcon} from './LockIcon.jsx';

export default function App() {
  const {isOpen, onOpen, onOpenChange} = useDisclosure();

  return (
    <>
      <Button onPress={onOpen} color="primary">Open Modal</Button>
      <Modal
        isOpen={isOpen}
        onOpenChange={onOpenChange}
        placement="top-center"
      >
        <ModalContent>
          {(onClose) => (
            <>
              <ModalHeader className="flex flex-col gap-1">Log in</ModalHeader>
              <ModalBody>
                <Input
                  autoFocus
                  endContent={
                    <MailIcon className="text-2xl text-default-400 pointer-events-none flex-shrink-0" />
                  }
                  label="Email"
                  placeholder="Enter your email"
                  variant="bordered"
                />
                <Input
                  endContent={
                    <LockIcon className="text-2xl text-default-400 pointer-events-none flex-shrink-0" />
                  }
                  label="Password"
                  placeholder="Enter your password"
                  type="password"
                  variant="bordered"
                />
                <div className="flex py-2 px-1 justify-between">
                  <Checkbox
                    classNames={{
                      label: "text-small",
                    }}
                  >
                    Remember me
                  </Checkbox>
                  <Link color="primary" href="#" size="sm">
                    Forgot password?
                  </Link>
                </div>
              </ModalBody>
              <ModalFooter>
                <Button color="danger" variant="flat" onPress={onClose}>
                  Close
                </Button>
                <Button color="primary" onPress={onClose}>
                  Sign in
                </Button>
              </ModalFooter>
            </>
          )}
        </ModalContent>
      </Modal>
    </>
  );
}

It throws in console:
Uncaught (in promise) TypeError: Cannot create property 'u' on string '{onOpen}'
at I (shared.js:2:746597)
...
Please complete the following information):

OS: Windows
Browser: Chrome
Extension Version: 2.4.8

Additional context
其他
Add any other context about the problem here.

fixed in v2.4.9
and it's also recommended to wrap your code in
```
YOUR CODE
```


Component Relative URLs can not be found (getting 404 error)

Please provide us with the following information:

OS?
Windows
Versions.
angular-cli: 1.0.0-beta.17
node: 6.6.0
os: win32 x64

Repro steps.
I'm developing a library that is to be distributed via npm so I can re-use this library in multiple client apps.  This library is a very simple component that works if I use in-line template to render HTML.  However, if I convert the in-line template to a physical HTML file referenced by templateUrl, then I get a 404.  The browser is trying to find the HTML file (my-awesome-component.html) at the root of the app.  The physical HTML actually resides in node_modules (installed via npm install command).
How do you render component relative URLs (HTML and stylesheets) when loading the component from node_modules (this is where the physical files live)?
The log given by the failure.
Here's the error I receive:
_Failed to load resource: the server responded with a status of 404 (Not Found)
http://local.solutiaconsulting.com/my-awesome-component.html_

Thanks! We'll be in touch soon.

This isn't something we can resolve in the CLI. The recommendation is that libraries should inline html and css when preparing the package to be distributed via NPM.


Message List Color issue after Oreo Update (S7)

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
Text color should not have changed
Actual behavior
Text for messgae list has change to bright magenta. Alternatively unread messages are birght magenta if the option in reverse colors is checked.
Steps to reproduce

Environment
K-9 Mail version: Pro 1.15
Android version: 9.0
Account type (IMAP, POP3, WebDAV/Exchange):

Wrong bug tracker. There's no "K-9 Mail Pro 1.15".


Expose properties needed for octopus-psd

In this pull request, we would like to expose needed properties on Layer and needed types and keys. Also, we added some functionality do be able to decode image patterns.

@pastelmind @dlehdanakf who could be a good reviewer here? Since I contributed part of the work to this PR I don't feel like I would be an impartial judge on that :)
Let me know if you need more background on why we want these features :)

@alexanderspevak let's convert it to a draft since it seems like there's more work to be done.

@alexanderspevak let's convert it to a draft since it seems like there's more work to be done.

changed.

Hi there @pastelmind . Would you be so kind and tell us if we can merge this pull request, or if there are any changes that you would like to amend?

What if I created a separate PR based on this one, plus the proposed changes? Does this suit you?

Yeah, that works :)

Closing in favor of #93


Updated to new API version and Weather API Configures

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: devashishkumar709:white_check_mark: sahilchutani:x: bifrost-trojanYou have signed the CLA already but the status is still pending? Let us recheck it.

Please check the comments.

Done


Git sources and references

It would be nice if you had a Git sourced project in paket.dependencies if that project would be added as a project reference if you use it in paket.references and the git root contains a cs or fsproj file.

how would this look in the paket.references file?
Can you come up with a syntax?

I would like to propose the following syntax.
If you have either a github or git source in the depencencies
github tpetricek/FSharp.Formatting
git https://github.com/fsprojects/Paket.git
You would reference the all cs/vb/fsproj files in the root of these folders with
FSharp.Formatting
Paket
It would be nice though to maybe select one of several proj files by
GITNAME projectreference: foo.vb/fs/csproj, bar.vb/fs/csproj


How to use coalesce with filters

I have a use case where I need to fall back to a different document if the one I query for doesn't exist. The folks at Sanity showed me this:
coalesce(
  *[_type == 'pgPage' &&
      slug.current == $slug &&
      region == $region][0],

  *[_type == 'pgPage' &&
      slug.current == $slug &&
      region == "global"][0]
)

{
  slug: "my-page",
  region: "ca"
}

This allows me to request the document where region === "ca" but if it doesn't exist, I get back the region === "global" document.
How can I do the same thing with groqd?

👋 Hey @jamiechong TIL about the coalesce function. very cool. At the moment groqd doesn't provide first class support for it, but you can still use it by stitching together some query strings explicitly.
I whipped up a quick groqd arcade example that should highlight how you can use it. atm the arcade doesn't respect query params, so I just hardcoded the filters. Should give you the general idea tho.
import { runQuery } from "playground";
import { q } from "groqd";

runQuery(
  q(`coalesce(
    ${q('*').filter('_type == "pokemon" && "type.Water" in types[]._ref').slice(0).query},
    ${q('*').filter('_type == "pokemon"').slice(0).query}
  )`)
  .grab({
    name: q.string(),
    attack: ["base.Attack", q.number()],
  })
);


Joints slide

Godot version:

OS/device including version:
Windows 10 64
Issue description:
There is looseness in the joint that can't be removed (it's not rigid). I'm guessing this is not supposed to happen?

Minimal reproduction project:
physics test1.zip

Can reproduce in 3.2.3 stable with both Bullet and Godot Physics.


Year in TDRC

I have an mp3 file with a year I set through iTunes, but running tag.year() returned None. The reason is that the year is in TDRC. iTunes seems to use TDRC, and VLC detected the year from TDRC as well.
rust-id3 seems to use TYER to get the year. Not sure how common TYER is, but it doesn't seem to be part of the id3v2.4 spec whereas TDRC is.
TDRC is a timestamp, which according to the spec will always start with yyyy.

Ah my bad, tag.get_date_recorded() is for getting TDRC


Ability to set a top-of-file comment on deploy.yaml

To aid on-boarding and also to be able to describe what's being deployed.
For example, the following as the first few lines of the deploy.yml file:
# This file is auto generated. Please see the ReadMe.md for instructions.
# DO NOT MODIFY THIS FILE DIRECTLY
# This file is configured to deploy to:
#  - uat
#  - uat2

name: deploy
on:
  push:
    branches:
# ...

The api for this could be simple:
const preparedComment = `# This file is auto generated. Please see the ReadMe.md for instructions.
# DO NOT MODIFY THIS FILE DIRECTLY
# This file is configured to deploy to:
${ENVS_TO_DEPLOY_TO.map((e) => `  - ${e.name}\n`)}
`;

const pipeline = /*...*/;
pipeline.workflowFile.commentBefore = preparedComment;

This would need to be built-in, otherwise it'll invalidate/break the diffProtection, which is undesirable.
I believe the code for this wouldn't be too complicated. The only issue I see is the old version of the yaml that's being used has a different API for these functions. At this point, I believe switching to the newer yaml library would be trivial, but these changes in particular would use the parts of the API that have changed.
If interested, I could work up a PR.

hi @giseburt! Adding in these comments would be helpful. I'm happy with upgrading yaml to a newer version as well. Ideally those would come in two separate PRs. If you're willing to contribute, that would be awesome!

@kaizencc Ok, the update to the new YAML was trivial, and can be found in #353.
I'll make a PR for the second part within a day or so.


Preset assets: support home domain overrides

Preview is available here:http://stellar-demo-wallet-client-pr333.previews.kube001.services.stellar-ops.com/

Preview is available here:http://stellar-demo-wallet-client-pr333.previews.kube001.services.stellar-ops.com/


refactor: remove cluster issuer

:white_check_mark: Build TheIdServer 4.6.2-user-ole1-0017 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/e45f6ac330 by @aguacongas)


Extend version command to help troubleshoot porter

I want a command to help me troubleshoot when someone submits a bug report. Instead of having to asking questions about "what os are you running", "what mixins are installed?" etc, I'd rather tell them "run this one command and send me the output".
I think we can add a --system flag that when present prints additional information about what is installed in the porter home directory.
$ porter version --system
porter v0.14.1-beta.2 (72dd5df)

System
--------
os: darwin
arch: amd64

Mixins
------
Name         Version          Author
aws          v0.1.2-beta.1    DeisLabs
az           v0.2.1-beta.1    DeisLabs

The following will need to be changed:

cmd/porter/version.go - add system flag
pkg/porter/version.go -

Add VersionOpts struct to hold what we use currently plus the system bool and have version take this new opts struct instead.
Add method to collect additional information when system flag is present (os, arch)
Use porter.ListMixins to get a list of the installed mixins, and use similar table printing as porter.PrintMixins
Make a new struct to contain all the collected information and handle printing it according to the requested output format (json, table, etc).
Add tests to version_tests.go

@carolynvs can I give this a shot?

@phillipahereza  You bet!

@carolynvs what output formats should I allow with the system flag because port mixins list allows table output while porter version doesn't. Should I ignore the table output for the system flag?

@phillipahereza Yes, each command in porter may support a different set of format values. So just go with what porter version already supports: json, plaintext. 👍

@carolynvs how do I build my latest changes? Every time I run make build-porter, it builds a specific commit


[move source language] improve error message for unused resource para…

…meters

The error message for an unused resource parameter points to the procedure declaration + says "The local 'x' might still contain a resource value due to this assignment".
This PR changes it to say "The parameter 'x' might still contain a resource value", which is somewhat clearer.

Motivation
See above.
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
New move-check tests.

is if we do a similar thing here as in the IR compiler where we unify the locals and function parameters

Can you elaborate on this?

@bors-libra r=tzakian

:pushpin: Commit 051a071 has been approved by tzakian

:hourglass: Testing commit 051a0710d019fde304c5285b1dce7c60a5897cfc with merge e12cbf78b242bc3594c0d8bd3ed67b11e9e09134...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=tzakian

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

:pushpin: Commit 051a071 has been approved by tzakian

:hourglass: Testing commit 051a0710d019fde304c5285b1dce7c60a5897cfc with merge 3a9b5928f7ec0441a13e07ff2d2336c7bb40f598...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra r=tzakian

:pushpin: Commit 85ae571 has been approved by tzakian

:hourglass: Testing commit 85ae5711fe3dd046797995cebc5e1e1db81175c7 with merge 2776c2bde810b037d3dc508b6e59a5698147f686...

:broken_heart: Test failed - checks-circle_commit_workflow

@bors-libra retry

:hourglass: Testing commit 85ae5711fe3dd046797995cebc5e1e1db81175c7 with merge 36573cc538c2841f3ba10d5fd0200d2207e0ddcc...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: tzakian
Pushing 36573cc538c2841f3ba10d5fd0200d2207e0ddcc to master...


Show reconciliation previews on hover of reconciliation candidates

When hovering unmatched reconciliation candidates and matched cells, the reconciliation preview from the service shows up (if provided).
Clicking on unmatched reconciliation candidates now has the same behaviour as clicking on matched cells: it opens the page of the entity in a new tab.
As argued in #1943 I think this is a much more natural behaviour and I have heard of multiple users who were confused about this. I think it should not be too hard for experienced users to adapt.
Tested in Firefox and Chromium: please test extensively on as many environments as possible and report if anything does not feel natural.
One possible downside of this is that people could feel like the previews pop up too often, when the user inadvertently hovers a reconciliation link without any intent to inspect it. If you think this is a big issue, maybe it's worth removing the hover on matched cells, but my gut feeling is that it is nice to preview matched cells too (especially when using the auto-match feature in the reconciliation operation, which is enabled by default).
Closes #1943.

@wetneb I was hoping that we had a Toggle Preference for "hover.reconcilePreview"="true"?  Other than that, I agree it the new tab feels natural, but popup reconcile preview feels unnecessary and necessary at different times of the data cleaning/reconciling phases.  So let's see if we can make this a preference to turn on or off as needed.

@thadguidry a toggle could be useful, but where would we put it?

I don't think it would make sense to put it in the reconciliation dialog - that contains the configuration options for an operation, not for the UI.
Putting it in the global preferences would be pretty useless - users are not likely to discover it and it is going to be inconvenient to go back and forth between the project and the preferences to switch that when required. Moreover the preferences are global, not per project, so it's inconvenient if you have one project where you need the previews and not the other.
Putting it next to the records/rows mode and the number of rows to display could work, but IMHO it's a very niche setting that does not deserve to occupy highly-visible space there. And it's going to make this bar longer, which is likely to cause problems on small screens.

It's easy to add a toggle in the global preferences but my gut feeling is that it's not going to be used…

We could just add it to the existing "Project metadata" dialog.
//*[@id="metadata-body"]
But instead of it being a Key/Value... but the new toggle option right above the Key/Value table.
Label the toggle option "Hover Recon Preview" and default it on and give it a tooltip to explain it.
Store the setting as part of the Project metadata for now if we can to simplify.
We can always partition it later with
"Project metadata"
"Project settings"
(or if not too much work, you can add a 2nd storage layer to Projects called "Settings" in addition to "Metadata"? but I think that's more work, and quick and dirty is fine for now)

Still not convinced, it's hacky. It really does not belong to project metadata: UI settings should not go there. I will add a toggle in the global preferences for users who get annoyed by the popups and that will do.

My commit message was incorrect, it's cell-ui.previewMatchedCells=false that you need to add to disable previews on matched cells. This requires reloading the project page too.


enumerate the commenter names

as discussed in email, I added a preview of the user names of the commenters. This way comments by e.g. Statcheck will have less urgency than real criticisms by human commenters.

Is it possible to show only unique commenters instead of repeating several times the same commenter? e.g. see behavior on this result: https://www.ncbi.nlm.nih.gov/pubmed/?term=obokata+stap


Property 'onEnded' does not exist on type 'AppComponent'.

In angular 9 i'm having this issue

@sanjay-devappsys, could you please share the code?

Actually I just copy pasted the advanced option which you've written in the repo readme file, and I think the issue is because of the binding in (ended )="onEnded($event) attribute.
The compiler in the angular 9 has been updated, usually in angular 8 or lesser this error would have appeared while we building  the project. Anyway I was able to get rid of the error by adding an empty onEnded function in the corresponding component.


patch #1

Fixed issues in index.html and uploaded application.html with patches.

Thank you Rajiv. LGTM!


Added merge operation on Either

I copied approach from Scalaz / disjunction, where I can end computations in a nice way - mapping both Left and Right side of Either to the same type. Thus eventually assigning it to a result (http response or String in a single step.
At  the moment almost same can be achieved by getOrElseGet but if both sides are already mapped to the same type (like String. HttpEntity) it  is unnecessary complex call.
see merge at https://static.javadoc.io/org.scalaz/scalaz_2.12/7.3.0-M22/scalaz/$bslash$div.html

Codecov Report

Merging #2242 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2242      +/-   ##
============================================
+ Coverage     97.17%   97.17%   +<.01%
- Complexity     5344     5346       +2
============================================
  Files            94       94
  Lines         12288    12291       +3
  Branches       1596     1596
============================================
+ Hits          11941    11944       +3
  Misses          193      193
  Partials        154      154

Impacted Files
Coverage Δ
Complexity Δ

vavr/src/main/java/io/vavr/control/Either.java
100% <100%> (ø)
50 <2> (+2)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00205bc...089ab7b. Read the comment docs.

Hi Jarek, thank you for your PR!
A while ago we decided against a static flatten function in favor of the workaround flatMap(t -> t).
Main reasons:

we want to keep the amount of static methods small. Most of them exist only because of missing features within Java‘s type system
we want to keep the API as thin as possible. We decide on a per case basis if ti is worth to add syntactic sugar
...

The characteristics of the merge function are very similar to those of flatten, so I will close this PR.
I hope you understand!

Thank you for the answer. Understood.  Not a problem at all.
getOrElseGet works for me.
and indeed such specific "sugar" operations can be added per project to not pollute vavr api,
(in that case maybe I will use kotlin extension functions)

@jarekratajski thank you!


Feature/vost 84 saving has seen tutorial

When the user has seen the tutorial, then don't show it again
If the user clicks on "Tutorial" in the about screen, he will be taken to the tutorial

Resolved all the conflicts


Add "start chat" in search for people results

Clicking on people in the search results doesnt give you an option to "start chat" with them.
Makes it hard to make use of the search functionality

It has been fixed.


Upgrade Vault to 0.6

There are no breaking changes for Mantl, it'll just be a smooth package upgrade.

Ansible version (ansible --version): n/a
Python version (python --version): n/a
Git commit hash or branch: master
Cloud Environment: all
Terraform version (terraform version): n/a

see https://github.com/asteris-llc/mantl-packaging/pull/115


Initial Thread-Safe Implementation

Add thread-safety to XACC/QCOR (Experimental). We introduce _XACC_MUTEX macro in xacc.hpp to turn on/off the feature (default is OFF). When the macro is ON, only a single thread can execute the following routines by using eit
her std::mutex or std::recursive_mutex:

User-facing API routines

createObjectiveFunction() (qcor::__internal__::get_objective())
createOptimizer()

Compiler-related modules

Syntax Handler

QuantumKernel::operator()
QuantumKernel::~QuantumKernel()

QJIT

QJIT::QJIT()
QJIT::jit_compile()
QJIT::write_cache()

Also, regardless of the macro, the VQEObjective class is now xacc::Cloneable.
Add the following test files to test multi-thread execution. It is worth noting that, when the macro is OFF, these test programs are executed sequentially.

examples/simple/bell_threaded.cpp
examples/simple/simple-objective-function-async.cpp
examples/simple/simple-objective-function-threaded.cpp
examples/qpu_lambda/deuteron_threaded.cpp
examples/qpu_lambda/deuteron_vqe_threaded.cpp
examples/qpu_lambda/deuteron_vqe_obj_func_threaded.cpp
examples/qpu_lambda/lambda_test_bell_threaded.cpp

Hi @amccaskey,
I've just updated XACC's cmake/xacc-config.cmake.in and cmake/xacc_config.hpp.in so QCOR can detect whether the _XACC_MUTEX (C macro) and XACC_MULTI_THREDED (CMAKE variable) are defined (https://github.com/eclipse/xacc/pull/455/commits/d51b6dc121ea1c5d6b8ca317c751201e97b8de0e).
Having that said, I'd like to get your advice on how to use those variables in QCOR.
Currently, many of my thread-safe implementations do something like this to check if _XACC_MUTEX is defined:
#include "xacc_config.hpp" // define/undef _XACC_MUTEX
#ifdef _XACC_MUTEX
#include <mutex>
#include <thread>
#endif
...
#ifdef _XACC_MUTEX
std::cout << "_XACC_MUTEX is defined: multi-threding execution" << std::endl;
#endif

I was wondering if I should keep this pattern or somehow update it. One alternative implementation I came up with was, like the XACC part, to update QCOR's qcor_config.hpp.in and let CMake define _QCOR_MUTEX if _XACC_MULTI_THREADED (set by XACC's CMake) is defined:
#include "qcor_config.hpp" // define/undef _QCOR_MUTEX
#ifdef _QCOR_MUTEX
#include <mutex>
#include <thread>
#endif
...
#ifdef _QCOR_MUTEX
std::cout << "_QCOR_MUTEX is defined: multi-threding execution" << std::endl;
#endif

Which one would you prefer? Please let me know if you have any other suggestions.

Hey akihiro, I like your idea of setting up a QCOR_MUTEX variable based on the upstream value of the xacc one

Hey @amccaskey, sure I'll update the PR accordingly.

@amccaskey, I think I've incorporated all the requested changes and updated the PR.
One thing to note is that I added deuteron_threaded.cpp, which is a threaded version of deuteron.cpp, a while ago. However, since deuteron.cpp cannot be compiled by recent versions of QCOR, I didn't include it in ctest.
Please let me know if you have any further requests. I'll be happy to work on that.
Akihiro

@ahayashi I just reviewed this. I think it looks fine. I do have one request before we pull it. I'm interested in demonstrating why one would need multithreaded qcor.
I think it would be helpful if you put together an example that tries to use multiple threads to solve a single problem in less time than you could have sequentially. Of course, let's just use QPP as a simulation backend, but maybe we could create an OptFunction that spawns off multiple threads, each thread computing the expected value of a single term in a Hamiltonian, with a join and sync on the values, summed and returned for the Optimizer. Would be nice to profile the runtime and show a speedup.
Also can we show multi-threaded execution on the IBM backend? Multiple threads submitting jobs to be queued and executed.

@amccaskey, thanks for reviewing this!
Yes, the OptFunction example sounds good to me. Let me create such an example and add it.
Re. the IBM backend, while I've been only focusing on the QPP backend, yes, I'll be happy to work on supporting the IBM backend.


Update human-interface-guidelines.md

Add link to associated resource

propose adding link to referenced resource

This isn't the right place to link. Instead please add the link in the Contractor section below (where the current link points)

first pull amendment


[Bug]: Release action fails on soft-prop

Python Version
3.11
Describe the bug
The release action is failing during the signing and uploading of the built wheels due to a soft-prop issue: https://github.com/pybop-team/PyBOP/actions/runs/9839631010
The generated error is for soft-prop@v1, however, v2 is defined in the action and approved on the repository. @agriyakhetarpal, do you mind taking a look at this one?
Steps to reproduce the behaviour
See v24.6 release action: https://github.com/pybop-team/PyBOP/actions/runs/9839631010
Relevant log output
No response

Strange, I think this was either a GitHub error or that one of the actions is a composite action that uses v1 internally. Should we allow the use of external actions? If and as long as we make approvals required workflow runs for any outside collaborators, that should limit the use of actions as well.


PubSub topic used is not available in subscribing topic method

When subscribing using wildcards ("+" or "#" relevant for MQTT), the actual topic is not known by the subscribing topic method. This could be useful in many cases, for instance when embedding a unique id in the topic to enforce authorization in MQTT.
Could this be added to the callback somehow?

Could the source or subject attributes of the cloudevent be used?

The solution for this would be for this to be provided via the cloud event or GRPC Metadata. That however requires support for this in the Dapr Runtime / sidecar (dapr/dapr repo) first.

It could be added to the gloud event from the python SDK, without ant updates to the runtime, no? From the request.topic property?
    def OnTopicEvent(self, request, context):
        """Subscribes events from Pubsub."""
        pubsub_topic = request.pubsub_name + DELIMITER + \
            request.topic + DELIMITER + request.path
        no_validation_key = request.pubsub_name + DELIMITER + request.path

        if pubsub_topic not in self._topic_map:
            if no_validation_key in self._topic_map:
                pubsub_topic = no_validation_key
            else:
                context.set_code(grpc.StatusCode.UNIMPLEMENTED)  # type: ignore
                raise NotImplementedError(
                    f'topic {request.topic} is not implemented!')

        event = v1.Event()
        event.SetEventType(request.type)
        event.SetEventID(request.id)
        event.SetSource(request.source)
        event.SetData(request.data)
        event.SetContentType(request.data_content_type)

        # TODO: add metadata from context to CE envelope

        response = self._topic_map[pubsub_topic](event)
        if isinstance(response, TopicEventResponse):
            return appcallback_v1.TopicEventResponse(status=response.status.value)
        return empty_pb2.Empty()

But it is maybe better provided through the runtime. E.g. by providing the topic in the request.source property?

It's not clear to me whether the source or topic will be set in the case where a cloud event was not published by Dapr itself.

@ngiind the source attribute might be used for something else if the cloud event didn't originate from Dapr. Perhaps we could add this as a custom cloud event extension attribute.

@berndverst when is the source not Dapr?
Maybe the topic does not belong in the cloud event, and should instead be a separate parameter for the TopicSubscribeCallable? The MQTT Cloud events binding spec does not seem to include the topic in the event (https://github.com/cloudevents/spec/blob/main/cloudevents/bindings/mqtt-protocol-binding.md).

I see what you are requesting now. Yes we could just get the topic from the request itself. We could set it as a cloud event extension. How about that?
If I change the method signature for the topic callback I would introduce a breaking change. Unfortunately the topic functions take in an instance of CloudEvent from the official Cloud Event SDK. None of these fields in the Python Cloud Events SDK are designed to hold the topic information. Source could be populated already.
I think setting a cloud event extension (custom property) and using a prefix like dapr_ may make sense.
extensions = dict()
extensions['dapr_topic'] = request.topic

event = v1.Event()
        event.SetEventType(request.type)
        event.SetEventID(request.id)
        event.SetSource(request.source)
        event.SetData(request.data)
        event.SetContentType(request.data_content_type)
        event.SetExtensions(extensions=extensions)

Then in your handler you can either get the complete list via
event.Extensions() or you can use event.Get('dapr_topic')

@berndverst: I think this seems like an ok solution, considering that we need to be backwards-compatible. This should be an issue in the other SDKs as well, no? Maybe we need to align?

@ngiind yes we probably need to agree on the name / prefix. We can make this change in the dapr.ext.grpc library once we have decided what to do and do an off-cycle release of that library.

Sounds like a good plan @berndverst. How do we synchronize with the other SDKs? I'm a bit of a neebie, sorry :).

It will be best for us to raise a new proposal in the dapr/dapr repo. Though this is also something the "SIG SDK spec" working group should handle. The dapr/dapr issue is probably a good start and it can be routed from there accordingly.

Ok. Thanks! Shall I raise the issue in dapr/dapr?

Nudging this. I can help implement it.

@ngiind it is now implemented in the attached PR - it requires Dapr 1.10. It could not have been implemented prior to my work updating the protos in the Dapr Runtime.
event.Subject() will be the pubsub topic.
This is a synonym for event.Extensions()['topic']

Thank tou, @berndverst ! <3

Thank you, @berndverst ! <3

@ngiind small correction:
event.Subject() will be the topic via which the event was delivered, this could be a deadletter topic for example.
The originally intended topic is also accessible via event.Extensions()['topic'] if desired.


Cherry-pick: Add NumOfHosts to RayCluster helm-chart template (#1969)

Why are these changes needed?

Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

I cherry-picked these two commits one by one.


Feature Request: mini faction quick filter

Is there a way we could get "AD"/"AP"/"SL" added as filters for the three mini factions?

oh, huh.
We don't have the faction "short codes" documented on the public pages.
f:adam f:apex and f:sunny-lebeau all work, but that isn't documented anywhere.
ad / ap / sl are good abbreviations.
i'll get that patched up and update the syntax pages with some info on this as well.


MWPW-154209 - [hero-marquee] bugs

Fixed some bugs in the hero-marquee that were found in GPW user testing. These changes address the following.

Row type and button variants on con-block rows should style the elements. They are not. ex con-block-row-text (s-body, xl-button, xxxl-heading)
:icons: in the main content area not rendering.
Update lockup styles from incoming globals.
When background image is smaller than 1199px, the image should be forced to display at 100% in tablet view.
When CTA is the ONLY element placed in "con block row text," margin top should be removed.
Video elements not displaying for mobile or tablet when authored w/ bg-bottom-mobile, bg-top-tablet variants.

Resolves: MWPW-154209
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/hero/hero-bugs?martech=off
After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/drafts/rparrish/hero/hero-bugs?martech=off

Prod URLs:

Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off
After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off

@colloyd Ok, I addressed that - For those interested in the what/why... I check for rows w/ out <p> tags and wrap them in  so they all get decorated the same and can applyTextOverrides. This should happen before decorating the buttons.

@overmyheadandbody  - I made a few adjustments from your feedback. Thanks for the look and LMK if you have anything else.

FYI, i was doing some testing w/ GWP and found one issue im addressing now. When a row-lockup type is used it doesn't fetch the required iconography.css. Ill get an update asap and remove the do-not-merge label. Thanks

FYI - This ^ has been addressed. Carry on

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-154209


Default config should come first

Hello, Patrik.
Just some suggestion. If you change the order and put:
'
  ' Default font styles
  '
  DefaultFontColor $color_fg
  ' https://github.com/twbs/bootstrap/blob/v4.5.3/scss/_variables.scss#L277
  DefaultFontName -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, "Helvetica Neue", Arial, "Noto Sans", sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji"
  ' DefaultFontSize
  ' DefaultFontStyle

  ' TODO: get this to work
  ' https://github.com/twbs/bootstrap/blob/v4.5.3/scss/_variables.scss#L278
  ' DefaultMonospacedFontName SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace

  ' DefaultTextAlignment

just after "skinparam {", all defaults will work and all specific changes, like DefaultFontColor  to ClassFontColor will work too.
Have a nice day!
Guilherme.

Thanks for the suggestion, @guipatriota
Is this what you mean? : https://github.com/patrik-csak/one-dark-plantuml-theme/commit/41dcd67b3563d4b0a6b1202c43d4d139462f0f42
Do you have an example of something that doesn’t work but is fixed by your suggested change?

Hi, Patrik.
That's exactly the change I made (https://github.com/patrik-csak/one-dark-plantuml-theme/commit/41dcd67b3563d4b0a6b1202c43d4d139462f0f42). I used your code as a starting point to create a theme in the style of DraculaPro Theme. However, I noticed that in some class and use case diagrams, the fonts, colors, and sizes were not being changed as expected. I even tried using DefaultMonospacedFontName instead of DefaultFontName. It only started working correctly after I placed these lines at the beginning of the skinparam.
In my code, I did:
skinparam {
  '
  ' Default font styles
  '
  DefaultFontColor $color_pink
  DefaultFontName Fira Mono
  DefaultFontSize 20
...


Fix 'ansible_env' is undefined

Change introduced in kamaln7/ansible-swapfile#9 causes:
the field 'environment' has an invalid value, which appears to include a variable that is undefined. The error was: 'ansible_env' is undefined

The error appears to have been in '[...]/kamaln7.swapfile/tasks/main.yml': line 54, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

- name: Create swapfile
 ^ here

with Ansible 2.2.0 when gather_facts is used.
See ansible/ansible#14655 for information. This fixed the problem for me, but I did not try any other Ansible versions or setup. Others have reported issues e.g. with commands in /usr/bin with the fix, but swapon and mkswap are probably usually in one of those paths listed in the task file?

Thank you! 👍


Tools panel

Add a new panel to the farm designer page for Tools, which replaces the functionality of the existing Tools Page. Users can add Slots, Tools, and Seed Containers from the scrollable menu, and edit the coordinates/names/etc from the edit panels.
Advantages:

Makes more of the user experience visual (intuitive) and more tightly integrated with the map (eventual goal is that most interaction is via the map)
User can click to edit a slot without leaving the map (would still leave the map on mobile, but would be editing the clicked-on slot)
User can see the map update live as they make edits to a slot's location/orientation (desktop only)
User could add a new slot by clicking directly on a location in the map (via a tooltip)
User visually picks which slots they want to load/unload tools from rather than reading the list on the Tools page.
User could potentially drag and drop Tools into/out-of/in-between Slots.

Empty State Graphic:


Bump framework

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8201574879

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8201574879
Status: success


refine interactive utils

make those interactive APIs consistent with InteractiveUtils.@code_typed and its family.

Codecov Report

Merging #66 (cc883d6) into master (dd64c6d) will decrease coverage by 0.21%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   83.66%   83.45%   -0.22%
==========================================
  Files           9        9
  Lines         796      810      +14
==========================================
+ Hits          666      676      +10
- Misses        130      134       +4

Flag
Coverage Δ

unittests
83.45% <62.50%> (-0.22%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/JET.jl
53.75% <62.50%> (+3.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd64c6d...cc883d6. Read the comment docs.


Kishore test

This change is intended as at least a partial fix for the issue, https://github.com/bluek8s/kubedirector/issues/263.
The NVIDIA-suggested workaround (https://github.com/NVIDIA/k8s-device-plugin/issues/87), referred to by the issue's description, is implemented:
For each container pertaining to a Role that has NOT requested a GPU resource, an "NVIDIA_VISIBLE_DEVICES=VOID" environment variable is added.
We may have to watch for future updates to NVIDIA's Docker plug-in, to see if the need for this workaround is removed.

Yep, looks plausible!
I remember earlier you had seen some warning messages about the operator trying to modify a non-modifiable statefulset property. I'm curious about those... wondering if this PR stimulates that in some way or if that was a coincidence that you were seeing them. Do you see those messages consistently in some situations (like when adding this env var), or is it rare/random?


feat: add infra concurrent opts & optimize delete instances

Why do we need to limit concurrent reconciles? And some context to pr message?


minhook lib fails to load when trying to be included in a project due to cmake issue

Describe the bug
minhook lib fails to load when trying to be included in a project due to cmake issue on vcpkg.
Environment

OS:  Windows 10 64bit
Compiler: Microsoft (R) C/C++ Optimizing Compiler Version 19.26.28806 for x86

To Reproduce
Steps to reproduce the behavior:
./vcpkg install minhook
then when I try to use it in a my project with the following CMakeLists.txt:
<project stuff>

find_package(minhook CONFIG REQUIRED)
target_link_libraries(${OUTPUT_FILE} PRIVATE minhook::minhook)

I then get the following:
CMake Error at C:/vcpkg/installed/x64-windows/share/minhook/minhook-config.cmake:63 (include):
  include could not find load file:
    C:/vcpkg/installed/x64-windows/lib/minhook/minhook-targets.cmake
Call Stack (most recent call first):
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:285 (_find_package)
  CMakeLists.txt:51 (find_package)
-- Configuring incomplete, errors occurred!

Expected behavior
For this not to fail when I try to use it in my project
Failure logs
logs did not mention any of this
Additional context
@qis gave me a few suggestions in the vcpkg channel regarding what the issue might be.

Solution
--- i/ports/minhook/portfile.cmake
+++ w/ports/minhook/portfile.cmake
@@ -36,14 +36,11 @@ vcpkg_from_github(
 vcpkg_configure_cmake(
     SOURCE_PATH ${SOURCE_PATH}
     PREFER_NINJA
-    OPTIONS
 )

 vcpkg_install_cmake()
-
+vcpkg_fixup_cmake_targets(CONFIG_PATH lib/minhook)
 vcpkg_copy_pdbs()

 file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
-file(COPY ${CURRENT_PACKAGES_DIR}/debug/share/${PORT}/minhook-targets-debug.cmake DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT})
-file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)
 file(INSTALL ${SOURCE_PATH}/LICENSE.txt DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

and new vcpkg/ports/minhook/install-destination.patch file:
--- i/cmake/minhook-config.cmake.in
+++ w/cmake/minhook-config.cmake.in
@@ -36,4 +36,4 @@ set(MINHOOK_FOUND ON)
 set_and_check(MINHOOK_INCLUDE_DIRS  "${PACKAGE_PREFIX_DIR}/include/")
 set_and_check(MINHOOK_LIBRARY_DIRS  "${PACKAGE_PREFIX_DIR}/lib")

-include("${PACKAGE_PREFIX_DIR}/lib/minhook/minhook-targets.cmake")
+include("${CMAKE_CURRENT_LIST_DIR}/minhook-targets.cmake")


Fix infinite loop bug and add feature event.

Could you remove the infinite loop fix (this has been fixed already on the fix branch) and set dotanshima:development as the base branch instead of master?


Add Samples of Content blocks to sample data

OVERVIEW
Current initialize sample data inserts Sections, this feature to add related text content blocks as sample data to initialize new package install.
ACCEPTANCE CRITERIA
As part of new install data is initialized with set of sections and related text content blocks.
OUT OF SCOPE
BACKGROUND/REFERENCE

New sample content was added to the trial org for Sprint '23. A copy of the content is attached below. The org will expire on April 28th. Org URL: https://clientcloudcare6.lightning.force.com/
GCK_content.zip


Fastest way of obtaining Nth state

🙋♂ Question
I'm using Immer + Redux inside a NodeJS application. To ease debugging, the application saves all patches to a file.
What would be the fastest way of calculating the Nth state? Is there some "mutable" mode, where Immer forgoes immutability while applying patches to boost performance?
If not, before I look into Immer's codebase, would it be quicker to fork Immer, or just write my own patch applier?
Environment

Immer version: "immer": "^7.0.14"

Not sure if I understand your question, but using applyPatches inside
produce should do just that.
On Sun, 15 Nov 2020, 14:29 Sun-2<EMAIL_ADDRESS>wrote:

🙋♂ Question
I'm using Immer + Redux inside a NodeJS application. To ease debugging,
the application saves all patches to a file.
What would be the fastest way of calculating the Nth state? Is there
some "mutable" mode, where Immer forgoes immutability while applying
patches to boost performance?
If not, before I look into Immer's codebase, would it be quicker to fork
Immer, or just write my own patch applier?
Environment

Immer version: "immer": "^7.0.14"

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/immerjs/immer/issues/700, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN4NBDV4MBD22G5E66GCGLSP7QU5ANCNFSM4TWHFJ3Q
.

Closing question as answered, feel free to comment if that interpretation is incorrect.


Dynamic page loading failed TypeError: Cannot read property 'ReactCurrentOwner' of undefined

Steps to reproduce
create a Component
`import React from 'react';
import { render } from 'react-dom';
import { Stage, Layer, Rect, Text } from 'react-konva';
import Konva from 'konva';
class Canvas extends React.Component {
render() {
return (

);
}
}
export default Canvas;`
but when loading the page, I got below error:

It seems like this issue usually has to do with node_modules confusion or the versions of your modules. Without additional context, I would say try deleting node_modules and running npm install. Make sure you are installing correctly with your version of React: https://github.com/lavrton/react-konva#installation
A couple other things - Is there any reason you are importing from both konva and react-konva? You also do not need to import render from react-dom to be able to define a component's render method. Also, it doesn't look like you are returning anything from your component's render function, which React doesn't allow. Hope that helps!

As I can see you are trying to render <div> into a stage. react-konva doesn't support such drawing.

Importing some from "react-konva" is error.
I 'm not  render  into a stage

Importing some from "react-konva" is error.
I 'm not render  into a stage

Importing some from "react-konva" is error.
I 'm not render   div   into a stage

@chuanshuogod can you make a demo? You can use this for bootstrap: https://codesandbox.io/s/k31j2jjxov
Or use something else. Also check versions. Try to use the last one.

I can use version 1.1.4, but 1.7.1 can't.

My English is not good .
Thanks for your help

I think there is react and react-konva versions mismatch.

OK!You are right!!!!
I'm so foolish~~~~~
Thank you very very very much~!!!(^_^)

@lavrton What is the mismatch? What should the correct versions be? (Is this documented somewhere?) I'm running into the same bug with React 16.


linear search: is not avaliable

searching algorithm is used for searching in small data.

Can You plz elaborate what are you trying to say?

program about linear search


Publish release

:white_check_mark: Build psmsi 3.2.32+g1824f1632f completed (commit https://github.com/heaths/psmsi/commit/1824f1632f by @heaths)


Add notes on how to install datalad on the CECI cluster

Hey @jovadla and @Remi-Gau, unless you see something to change add here, I will merge this one. LMK

Thanks for starting this @marcobarilari

Thanka marco.


create react components

@ryanlacroix @Addyvan status update?

Broken down into smaller tasks and added to the React components Milestones.


Modify model query builder

I want to modify the model query in a controller before a request is executed. This is required if I want to filter the data and show only owned models by a user in the index method,
Currently, I'm overriding newModelQuery in the controller to achieve the above
//in PostController.php

public function newModelQuery(): Builder
{
    $query = $this->getModel()::query();
    if(auth()->user()->hasRole('user')){
        $query = $query->where('user_id', auth()->user()->id);
    }
    return $query;
}

is there any better way to do this?
Can the hook itself pass the query builder as shown below?
protected function beforeIndex(Request $request, $query)
{
    if(auth()->user()->hasRole('user')){
        $query = $query->where('user_id', auth()->user()->id);
    }
}

Hi @SachinGanesh,
I think the proposed improvement makes sense 🤔
Same would be possible for beforeShow, beforeUpdate, beforeDestroy, and beforeRestore hooks as well - query builder would be passed alongside the resource key.
Gonna make the necessary changes over the weekend.
However, If you would like to apply the role filter to all endpoints (not just the index one), current approach is correct.

Okay. Thank you!

@SachinGanesh,
Went for a bit different approach, but the end result is basically the same.
There are now "wrapper methods": buildIndexQuery, buildShowQuery,  buildUpdateQuery, buildDestroyQuery, and buildRestoreQuery that you can override in your model controller and customize the query used to fetch model(s) in the given method/endpoint.
Documentation and wrapper methods in relation controllers is coming next week ~
In your case, the solution for index endpoint would be:
//in PostController.php

protected function buildIndexQuery(Request $request, array $requestedRelations): Builder
{
    $query = parent::buildIndexQuery($request, $requestedRelations);

    if(auth()->user()->hasRole('user')){
        $query = $query->where('user_id', auth()->user()->id);
    }

    return $query;
}

@alexzarbn This approach looks good to me. Thank you!


feat: withdraw_from

Adds withdraw_from to the cycles ledger, also makes it so that reimbursing a block from a failed withdraw attempt costs 1x FEE because a block is produced. create_canister will receive the same treatment when I implement create_canister_from

Adds withdraw_from to the cycles ledger

What is the use case for withdraw_from? Does this provide transfer_from and withdraw in a single step?

@ByronBecker yes


Send alpha announcement

Once we get #80 done, we need to send an announcement that the Shipyard alpha is available for testing.

Wrong repo, thanks Waffle.


Update pangolin to v4.0

A new version of Pangolin (v4.0) was just released:
https://github.com/cov-lineages/pangolin/releases/tag/v4.0
They have significantly changed quite a bit of stuff, and this new version apparently isn't backwards-compatible

release 3.6.0 and later now support pangolin 4+. Thanks!