ProtoRecordConverter might wrongly cast a Message.Builder to Message

ProtoRecordConverter returns current record as follows:
  public T getCurrentRecord() {
    if (buildBefore) {
      return (T) this.reusedBuilder.build();
    } else {
      return (T) this.reusedBuilder;
    }
  }

However this might fail if T is subclass of Message and buildBefore == false, since it's actually casting a Message.Builder instance to Message type.
Reporter: Wu Xiang
Assignee: Reuben Kuhnert / @sircodesalotOfTheRound
Note: This issue was originally created as PARQUET-388. Please see the migration documentation for further details.

Reuben Kuhnert / @sircodesalotOfTheRound:
I'm a little confused on this one, because the signature for ProtoRecordConverter is:
public class ProtoRecordConverter<T extends MessageOrBuilder> extends ProtoMessageConverter { ... }

And both Message and Message.Builder both extend from this:
// Message.java
public interface Message extends MessageLite, MessageOrBuilder {
  ...
  public interface Builder extends Builder, MessageOrBuilder { ... }
}

So technically it is correct that the current record could be either Message or Message.Builder.

Wu Xiang:
hi Reuben,
Yes,  I agree that current record could be either Message or Message.Builder. But the problem is when I use it, the 'buildBefore' flag would always be false, which means the Builder instance is always returned.
More details,
I'm implementing a wrapper for cascading to read/write parquet|protobuf data. And the default ProtoReadSupport class is used to help with that.
The signature for ProtoReadSupport is as follows, where only Mesage type is declared as the type parameter.
public class ProtoReadSupport<T extends Message> extends ReadSupport<T> { }

But the RecordMaterializer inside ProtoReadSupport is actually returning Message.Builder. This is where type inconsistency comes from.
To make it work, I need to add some hacks for RecordMaterializer (ProtoRecordConverter), by switch the 'buildBefore' flag.
    @Override
    public RecordMaterializer<T> prepareForRead(Configuration configuration, Map<String, String> keyValueMetaData, MessageType fileSchema, ReadContext readContext) {
        String headerProtoClass = keyValueMetaData.get(PB_CLASS);
        String configuredProtoClass = configuration.get(PB_CLASS);

        if (configuredProtoClass != null) {
            LOG.debug("Replacing class " + headerProtoClass + " by " + configuredProtoClass);
            headerProtoClass = configuredProtoClass;
        }

        if (headerProtoClass == null) {
            throw new RuntimeException("I Need parameter " + PB_CLASS + " with Protocol Buffer class");
        }

        LOG.debug("Reading data with Protocol Buffer class " + headerProtoClass);

        MessageType requestedSchema = readContext.getRequestedSchema();
        Class<? extends Message> protobufClass = Protobufs.getProtobufClass(headerProtoClass);
        ProtoRecordMaterializer<T> materializer = new ProtoRecordMaterializer<T>(requestedSchema, protobufClass);
        ((ProtoRecordConverter<T>)materializer.getRootConverter()).setBuildBefore(true);
        return materializer;
    }

Reuben Kuhnert / @sircodesalotOfTheRound:
Just as a general comment, returning <T extends MessageOrBuilder> does feel very mysterious to me. Does it make sense to have two explicit methods like asBuilder and asMessage in addition to the current getCurrentRecord?

Matt Martin / @matt-martin:
I agree with [~wxiang7] that there seems to be something a little bit off here.  I'm also getting an unexpected ClassCastException in the following Scala code:
val reader = ParquetReader.builder(new ProtoReadSupport[SomeMessageClass](), new Path(file.toURI)).build
...
reader.read

At reader.read I get the following exception:
ClassCastException: : SomeMessageClass$Builder cannot be cast to SomeMessageClass

I cannot change the declaration of reader to the following:
val reader = ParquetReader.builder(new ProtoReadSupport[SomeMessageClass$Builder](), new Path(file.toURI)).build

because then I get the following error:
type arguments [SomeMessageClass$Builder] do not conform to class ProtoReadSupport's type parameter bounds [T <: com.google.protobuf.Message]

Wu Xiang:
Hi Lukas,
Thanks for your reply.
To be sure, when you say 'The cast is correct', do you mean by that ProtoRecordConverter<MyProtoMessage>::getCurrentRecord would work correctly ?
In my case, I created a instance of ProtoReadSupport<MyProtoMessage>, which then created RecordMaterializer<MyProtoMessage> and ProtoRecordConverter<MyProtoMessage> instances internally.  Since the buildBefore flag is not set, ProtoRecordConverter<MyProtoMessage>::getCurrentRecord would definitely cast a MyProtoMessage.Builder instance to MyProtoMessage, with runtime exceptions.
P.S. The signature for ProtoReadSupport is as follows, which leads ProtoReadSupport<MyProtoMessage.Builder> to compile time error.
public class ProtoReadSupport<T extends Message> extends ReadSupport<T> {}

wu

Wu Xiang:
One more suggestion, let's just be honest to align the type signature of ProtoRecordConverter class definition and getCurrentRecord method.
I mean, when we use ProtoRecordConverter<MyProtoMessage> (or ProtoReadSupport), only MyProtoMessage instances would be returned from getCurrentRecord.
On the other hand, when we use ProtoRecordConverter<MyProtoMessage.Builder> or ProtoReadSupport<MyProtoMessage.Builder>, only MyProtoMessage.Builder instances returned.
In this way, I would feel less confused about ProtoRecordConverter API.

Lukas Nalezenec / @lukasnalezenec:
Hi, author here.
The cast is correct, the buildBefore flag is extra feature, its not used much.
Do you really need data converted from Builder to Message ? Using Builder is more efficient.

Lukas Nalezenec / @lukasnalezenec:

To be sure, when you say 'The cast is correct', do you mean by that ProtoRecordConverter::getCurrentRecord would work correctly ?

No, it won't work correctly but  ProtoRecordConverter<MyProtoMessage.Builder>::getCurrentRecord will work correctly.

The signature for ProtoReadSupport is as follows, which leads ProtoReadSupport<MyProtoMessage.Builder> to compile time error.

It looks like there is bug in the signature. IMO it should be
public class ProtoReadSupport extends ReadSupport {}
I will look at it later today.
Thank you very much.

David Cardon:
A workaround I found was to replace all of the Message references in ProtoReadSupport with MessageOrBuilder.  You can then fairly easily resolve the Builder into a Message outside of the reading mechanism.


TypeError: THREE.BoxGeometry is not a constructor in examples on latest Build

Hey,
amazing Library! I get an error with the latest Files in all examples: TypeError: THREE.BoxGeometry is not a constructor. Why is three.js outdated that much on your rep? And wich Three.js version works best with physijs at the moment?
Thanks

I'm getting this error as well

Getting this error in MeteorJS

Three.js r125 removed support for Geometry.
Please use now custom BufferGeometry.

Three.js r125 removed support for Geometry.
Please use custom BufferGeometry.
https://threejsfundamentals.org/threejs/lessons/threejs-custom-buffergeometry.html


Data model best practices

As Patti the app developer, I want clear and concise documentation that covers model development, so that I understand the Nautobot standards, conventions, and best practices.
I will know this is complete when:

There is a model development section in the app developer guide

This section covers new model development
How to name models
How migrations are named, etc
How to integrate with the existing data model

What can and cannot be done

How to integrate with Nautobot features

See https://blog.networktocode.com/post/developing-nautobot-plugins-1/ for prior art.

As Patti the app developer, I want clear and concise documentation for model development so that I know the Nautobot standards and best practices.
I will know this is complete when:

There is a model development section in the app developer guide
This section covers standards and conventions for new model development

How to create new models
How migrations are named, etc
How to name models
How to integrate with the existing data model

What can and cannot be done

Integrating & supporting Nautobot features

See https://blog.networktocode.com/post/developing-nautobot-plugins-1/ for prior art.

Time box the initial version to a 2 and we will go from there.


Security review: ElementRef

We are currently using ElementRef, which is considered an XSS risk. Determine if this applies to our use and how to secure it.

Actually, this will be unnecessary once we stop using Snap.svg.


Login failed,The account may be a moomoo ID. Before logging in, please re-download and install FutuOpenD via the moomoo official website.

Logging in
>>>
Login failed,The account may be a moomoo ID. Before logging in, please re-download and install FutuOpenD via the moomoo official website.
>>>
Login failed
>>>

一定要开户的账号吗，我用手机随便新注册一个富途账号不可以？

 /bin/FutuOpenD
Futu OpenD version: 8.0.4008(240117152500)
Start Time: 2024-04-04 17:51:17
Futu OpenD is running
Load configuration file successfully
Server startup
API Listening Address: <IP_ADDRESS>:11111
API RSA Enable: No
Login Method: Account password login
Logging in
Login failed,Only account opening user is allowed to log in.
Login failed
Futu OpenD exited


iOS/Android - Tapping outside of the keyboard does not close the keyboard

On both iOS and Android, whenever I tap outside of the keyboard, the keyboard does not close. This is not a big deal on Android because the done button and the built in down arrow both work to close the keyboard. However, on iOS, there is no way to close the keyboard due to the issue of the done button also not working (https://github.com/zleao/zoft.MauiExtensions.AutoCompleteEntry/issues/10).

Fixed in version 3.0.1


Create codeql-analysis.yml

Testing if we can replace https://pyup.io/safety/ with an alternative

The Travis CI checks are failing for the same reason that the master build is failing - invalid safety API key.


report pdf generation broken with dotnet 6

got the following error under ubuntu 20.04 with dotnet 6
One or more errors occurred. (Unable to load native library. The platform may be missing native dependencies (libjpeg62, etc). Or the current platform is not supported.)
error log
==> /var/log/fworch/ui.log <==
Dec  6 18:01:38 fworch-comp fworch-ui[244223]: Message:
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:  One or more errors occurred. (Unable to load native library. The platform may be missing native dependencies (libjpeg62, etc). Or the current platform is not supported.)
Dec  6 18:01:38 fworch-comp fworch-ui[244223]: Stack Trace:
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:  at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:    at System.Threading.Tasks.Task.Wait()
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:    at WkHtmlToPdfDotNet.SynchronizedConverter.Invoke[TResult](Func`1 delegate)
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:    at WkHtmlToPdfDotNet.SynchronizedConverter.Convert(IDocument document)
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:    at FWO.Report.ReportBase.ToPdf() in /usr/local/fworch/lib/files/FWO.Report/ReportBase.cs:line 131
Dec  6 18:01:38 fworch-comp fworch-ui[244223]:    at FWO.Ui.Pages.Reporting.ReportExport.<Export>b__17_0() in /usr/local/fworch/ui/files/FWO.UI/Pages/Reporting/ReportExport.razor:line 133

Libraries installed:
tim@fworch-comp:~/tpurschke-fwo$ dpkg -l | grep jpeg
ii  libjpeg-turbo8:amd64                       2.0.3-0ubuntu<IP_ADDRESS>                amd64        IJG JPEG compliant runtime library.
ii  libjpeg-turbo8-dev:amd64                   2.0.3-0ubuntu<IP_ADDRESS>                amd64        Development files for the IJG JPEG library
ii  libjpeg62:amd64                            1:6b2-3                               amd64        Independent JPEG Group's JPEG runtime library (version 6.2)
ii  libjpeg8:amd64                             8c-2ubuntu8                           amd64        Independent JPEG Group's JPEG runtime library (dependency package)
ii  libjpeg8-dev:amd64                         8c-2ubuntu8                           amd64        Independent JPEG Group's JPEG runtime library (dependency package)
tim@fworch-comp:~/tpurschke-fwo$

reverting to pdf lib 1.5.59 restored functionality

now I cannot get PDFs generated with v1.5.59.
tested on deb10, ubu20.04

created https://github.com/HakanL/WkHtmlToPdf-DotNet/issues/72


Advanced SystemCare Ultimate <IP_ADDRESS> Crack + Key [Latest]

Advanced SystemCare Ultimate <IP_ADDRESS> Crack + Key [Latest]
Advanced SystemCare Ultimate Crack is powerful and combines top-level anti-virus functions and proven comprehensive PC tuning functions. It has a one-click method to help protect, repair, clean and optimize your PC. Based on the top-ranked BitDefender anti-virus technology and IObit anti-malware engine, it is part of the IObit anti-virus project, dedicated to providing our users with more and better value-added services.
IObit Advanced SystemCare Ultimate 16 license key has real-time protection against viruses, spyware and phishing attacks, powerful debugging and removal functions, and can provide always-on, automated and all-in-one protection against various security threats, and the system slows down , Freezing and crashing. It can ensure the safety of the PC and automatically maintain the highest computer performance without reducing the system speed. It is compatible with other security software, such as anti-virus, anti-malware, firewall, etc.
Download Now

✅▶▶DOWNLOAD Advanced SystemCare Ultimate Free
✅▶▶MIRROR Advanced SystemCare Ultimate Crack


Feature request: Use Custom File Name Default

Is it possible to include a setting where this use custom file name checkbox is checked by default?

When I download some streams I have to rename them due to the limits of my file system I end up renaming them frequently an option to have it enabled to default would save some time for me.

Also, no I don't a blank text field I would like to have the option to change the text field enabled by default.

 Most users don't edit the filename and go with the filename templating system.
I dislike the checkbox anyway and would prefer the textbox to be editable by default and add a simple button to reset the text to the filename template. So no checkbox anymore.
This goes onto my private todo list. I don't want to add settings for every single checkbox in the UI, that's just overkill.


[DateTime Picker] z-index issue.

Describe the bug
DateTime picker selection panel has a high z-index and hence components like Side Nav bar or App switcher are displayed behind it.
Below screen shots are for reference.

Specific timeline issues / requests
We are using this component for our upcoming June 2020 release.

After posing the question about z index in the carbon components slack channel this seems to be an issue with Carbon. I have opened up an issue to track on the Carbon repo.

Moving out of sprint 51 since the fix needs to be pushed to Carbon repo.

This should have been fixed in https://github.com/carbon-design-system/carbon/issues/6362 and our subsequent upgrades to Carbon.


atom --wait should open files in a tab instead of a new window

When I use atom .git/COMMIT_EDITMSG, the file is opened in the current atom window, that's fine.
But when I use atom --wait .git/COMMIT_EDITMSG, the file is opened in a new window with working directory of ".git", which is quite slow and not what I want.

Unfortunately because of the way the command line has to wait for the atom process to finish it has to open a new copy of atom.

Dang, that's a shame. I was following this issue because this behavior makes it really hard to use Atom as git's editor. Any recommendations on that front? Or any hope of this ever being fixed? (I'm assuming something would need to be changed upstream, in Electron?)

It's nothing specific to Electron - it's more the way command line tools
wait for other tools to complete by starting a process and waiting for it
to terminate.
Do you have examples of any other editors that can be the git editor
without firing up a new instance/window?
On Tue, Mar 1, 2016 at 10:53 AM, Adam Becker<EMAIL_ADDRESS>wrote:

Dang, that's a shame. I was following this issue because this behavior
makes it really hard to use Atom as git's editor. Any recommendations on
that front? Or any hope of this ever being fixed? (I'm assuming something
would need to be changed upstream, in Electron?)
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/10244#issuecomment-190850229.

https://github.com/atom/atom/blob/7aab88c4f62eb671bdfb9c036d1f0733f913109d/src/browser/atom-application.coffee#L468
Is it possible to listen on a tab's close event?

It's possible for things with access to Atom's API to listen for an editor's close event. There's no mechanism for something outside of Atom (like a command-line script) to listen for an editor's close event.

However, in this case, Atom sends SIGTERM to its parent process manually, not by SIGCHILD.

It's nothing specific to Electron - it's more the way command line tools
wait for other tools to complete by starting a process and waiting for it
to terminate.

Ah, that makes sense. Sublime has some sort of workaround though:

@lee-dohm: Given the above discussion, would the Atom team consider this as a valid feature request?

It could be cool to add and we don't actually wait for processes today, we actively terminate launch processes but track it by Window not by file.
Re-opening as a potential feature request.

Awesome. Thanks so much!

Is there any work being done on this issue, it has been almost year ago?
Opening new window instead of tab when committing with git is still in place.
More of a sublime behaviour is wanted :)

You are free to help out by creating a PR.


[SPARK-40324][SQL] Provide a query context of ParseException

What changes were proposed in this pull request?
In the PR, I propose to extend ParseException and add new field queryContext which contains an array of query contexts. By default, the field is initialized by the context of currently processed tree node.
Also I removed the wrapper validateParsingError() of checkError() to use last one directly.
Why are the changes needed?
To improve user experience with Spark SQL by providing more context of parsing errors.
Does this PR introduce any user-facing change?
No, it extends existing functionality.
How was this patch tested?
By running the affected test suites:
$ build/sbt "sql/testOnly *QueryParsingErrorsSuite"
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
$ build/sbt -Phive -Phive-thriftserver "test:testOnly *TruncateTableParserSuite"
$ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *ShowPartitionsParserSuite"

@srielau @anchovYu Could you take a look at the PR, please.

Merging to master. Thank you, @srielau @cloud-fan for review.


HL Python SDK: Support copy object between repositories

Prerequisite: https://github.com/treeverse/lakeFS/issues/7446
Support providing a destination repo (Optional for backwards compatibility)

This seems doable, but for "common" usage some interactions with garbage collection might be  strange.
For externally-managed objects this is obviously easy enough to do.  For an internally-managed object -- anything where lakeFS choses a path inside the repository storage namespace -- ownership makes things muddier.  The source repository "owns" the object, meaning that it can garbage collect it.  So if the source object is never committed it may vanish within a few days, and if committed it can vanish once it falls off of the head of all branches and according to a complex set of rules.
The API does not support zero-copy links even within a single repository because of the associated surprises.  We can support cross-repository zero-copy links even without the API, sure, but they be even more surprising.


PEAR-1945: Fix overwritten responsive grid style and adjust numeric range facet style

Description
The issue involved the responsive grid style being overwritten, as well as changes to the Numeric Range Facet style.
Checklist

[N/A] Added proper unit tests
[N/A] Left proper TODO messages for any remaining tasks
[N/A] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks ok to me 👍


test: test_fail needed besides test_ok

to prevent bugs like https://github.com/appliedzkp/zkevm-circuits/pull/261

yes, we need to enable negative test !!!

I would like to work on this issue, may I ask on where to start to look into it?


Host regions must be specified

The API URL must contain either "eu" or "us", it would be nice to have a feature that sets the mailgun-js host !
Module is broken at the moment..

do you have a link to the section of the docs that describes this?


Sync folk with latest axs

do that when graph features is 80% done, but before writing a test to test that it works for all entry

https://github.com/elimkwan/axs_clone/commit/6101f26dd923a6b3badcc53c695625eb8b3b8a8b syncs the forked repository with the AXS.


Help on an alias with parameters shows misleading jinja delimiters

I defined a chatops alias like that:
name: "mypack_doc"
action_ref: "mypack.doc"
description: "Launch a documentation build & upload results on website."
formats:
  - "(doc|docs|dox|docu) {{branch=master}}"

and in the slack channel, when I ask for help, i get that:
stanleyAPP [6:08 PM]
!(doc|docs|dox|docu) {{branch=master}} - Launch a documentation build & upload results on website.

I think the jinja delimiters {{ and }} should be strippped from the help output, since they are misleading my users who just copy/paste them...
The (|) enabling choice, is less problematic to grasp, apparently...
WDYT ?

formats is machine-friendly and could be not readable by humans.
display format https://docs.stackstorm.com/chatops/aliases.html#display-representation-format-objects is an addition to that for human-readable !help response.

Yes, you're right, sorry for the noise.

No problem!


Add datashader integration tests

Fixes #20

@esc Doesn't look like it's actually running the datashader integration. Anything I did wrong or is it because it's an external PR?

I think you will still need to make an entry in the circleci config.

Yeah, looks like it is being picked up now.

🤦♂ ... thanks!

I think there is a spurious space in the package spec?

I think there is a spurious space in the package spec?

Ah, yes, we use reprs to insert the dependencies into the conda command:
conda install "pytest >=3.9.3"
is valid, but:
conda install pytest >=3.9.3
is not.

@philippjfr you can also run this locally for debugging, if you need to.

@philippjfr you can also run this locally for debugging, if you need to.

Yeah, sorry been lazy and context switching between this and something else. Bad CI etiquette I know!

Haha, progress before consensus. 🙉

This time I did run it locally...will make one more attempt.

Guess it's because locally it's using my other conda env.

Now that TexasBBQ is being used this PR requires some tweaking. As you can see here:
https://github.com/numba/numba-integration-testing/blob/master/switchboard.py#L27
You will need to inherit from GitTarget now for installation and testing you need to return the command string that should be run.

@philippjfr you want to give this another spin?

@esc Thanks for the ping. I'll put it on my stack, hopefully I'll get to it tomorrow.

o.k. awesome, so this works for now and stops only at import errors, I'll merge this now and then rebase #32 ontop.

and of course 🤞 that datashader was fine with 0.48


Tweaks during SH23

Hey @ldr426 : these are some tweaks that I made to make things work during the survey. Let's keep them in this PR and not merge them. I just wanted to let you know what I have fiddled with. I may continue to push changes to this PR.
Note that some changes I made were relative imports to use echoshader as package. I recommend look into the -e option for pip install, which allows you to develop a package under "development mode" so that you can import the package you are working on directly. @Sohambutala has recently used it and you could ask him about that.

Thanks, I will check it later!


Upgrade markupsafe from 1.0 to 1.1.1

The following error occurs on pip install -r requirements.txt while using Python 3.7.9.
I found the solution here: https://github.com/pallets/markupsafe/issues/116 and updated MarkupSafe from 1.0 to 1.1.1
ERROR: Command errored out with exit status 1:
 command: /Users/chaynorhsiao/Code/REST-auth/venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/5v/cz5lkd_15fl759j_38vjsthr0000gn/T/pip-install-rt5k3gwz/markupsafe/setup.py'"'"'; __file__='"'"'/private/var/folders/5v/cz5lkd_15fl759j_38vjsthr0000gn/T/pip-install-rt5k3gwz/markupsafe/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/5v/cz5lkd_15fl759j_38vjsthr0000gn/T/pip-pip-egg-info-ivlzia0j
     cwd: /private/var/folders/5v/cz5lkd_15fl759j_38vjsthr0000gn/T/pip-install-rt5k3gwz/markupsafe/
Complete output (5 lines):
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/private/var/folders/5v/cz5lkd_15fl759j_38vjsthr0000gn/T/pip-install-rt5k3gwz/markupsafe/setup.py", line 6, in <module>
    from setuptools import setup, Extension, Feature
ImportError: cannot import name 'Feature' from 'setuptools'

you are right


Invalid watch source for Accordion

Hello,
Thank you for working on this. I am a Nuxt person. I tried recreating the components on the shadcn-ui website with the components from this package and I am getting this warning in the terminal and browser console. It may be Nuxt 3 specific, I am not sure.
Describe the bug
I keep gettting this warning in the browser and in the VSCode terminal:
[Vue warn]: Invalid watch source:  item-1 A watch source can only be a getter/effect function, a ref, a reactive object, or an array of these types.
To Reproduce
This is the component that I created:

Click to see code
<template>
  <AccordionRoot class="w-full" :collapsible="collapsible" v-model="model" :type="type">
    <template v-for="(item, i) in items">
      <AccordionItem class="border-b" :value="item.value">
        <AccordionHeader>
          <AccordionTrigger
            class="flex w-full flex-1 items-center justify-between py-4 font-medium transition-all hover:underline [&[data-state=open]>svg]:rotate-180"
          >
            {{ item.title }}
            <Icon class="h-4 w-4 shrink-0 transition-transform duration-200" :name="icon" />
          </AccordionTrigger>
        </AccordionHeader>

        <AccordionContent class="content overflow-hidden text-sm transition-all">

        </AccordionContent>
      </AccordionItem>
    </template>
  </AccordionRoot>
</template>

This is how the component is being used:

Click to see usage
<template>

    <UIAccordion :items="accordionItems" v-model="item" />

</template>

Expected behavior
Well, I expect no warnings
Screenshots
Browser

Terminal

Desktop (please complete the following information):

OS: MacOS & Windows
Browser Chrome Browser

Additional context
Nuxt Info:

Operating System: Darwin
Node Version:     v16.19.1
Nuxt Version:     3.6.5
Nitro Version:    2.5.2
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      devtools, modules, app
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

thanks! can you provide a reproduction so we can have a more clear understanding of the issue?

I will make the changes & let you know soon. Thanks

@khairulhaaziq here is a link to the reproduction: https://stackblitz.com/edit/nuxt-starter-ws3qeq?file=components%2FUI%2FAccordion.vue
I tried using useVmodel but got the same results.

Remember that this does not break anything, so there is no need to stress over it. I was just bringing it to your attention so it can be looked at later.

hi yeah sorry this is on our side. yeah I dont think it is an issue, we will try and find a fix when we have time someday probably, but not a problem at all I think. Thanks so much for the stackblitz, wish everyone does that! Btw are you working on something like shadcn?

No problem, it can be updated some day in the future. For now, it does not break anything.
Yes, I have created shadcn for Nuxt many times over lol. I decided to create it again when I saw this package being worked on.
The reason why I keep starting over is because I have to be installing packages from all over the place to get the functionality I need and documenting is a pain. I will share the link to the last iteration that I worked on.
My hope is that I can rewrite it one final time with Radix Vue

No problem, it can be updated some day in the future. For now, it does not break anything.
Yes, I have created shadcn for Nuxt many times over lol. I decided to create it again when I saw this package being worked on. The reason why I keep starting over is because I have to be installing packages from all over the place to get the functionality I need and documenting is a pain. I will share the link to the last iteration that I worked on. My hope is that I can rewrite it one final time with Radix Vue

yeah please share it I personally need it 😂. you can contact us directly in discord if you have any more issues

Here it is:
Website: duxt-ui.netlify.app
Repo: https://github.com/BayBreezy/duxt-ui


A special function for unpickling old xarray object?

I noticed that some users experiencing troubles to restore xarray objects that is created xarray < 0.8.
Is there any possibility to add a function to support unpickling old object, such as
xr.unpickle_legacy(file, version)?
We previously recommended using pickle to store xarray objects (at least for the short term use, maybe).
xref (private repo)
gafusion/OMFIT-source#2652

Some additional explanations
I was consulted by an onwer of a project that is using xarray inside it,
the way to load xarray objects that is pickled with older-version xarray.
They does not recommend to use pickle, but some users actually do this and have troubles to restore old pickled files.
In partiular, xarray renamed Coordinate to IndexVariable in some point between v0.7 to v0.8.
There might be another module/class name changes too, and
these result in the (uninformed) error
UnpicklingError: NEWOBJ class argument isn't a type object

What I would like to propose here is to provide a workaround to unpickle old xarray objects.
The function would look like
def unpickle_legacy(filename):
    """
    Unpickle old xarray objects.
    """
    class RenamingUnpickler(pickle.Unpickler):
        def find_class(self, module, name):
             if name == 'Coordinate':
                 name = 'IndexVariable'
             return super().find_class(module, name)

    with open(filename, 'rb') as f:
        return RenamingUnpickler(f).load()

for all the previous releases.
Continuously supporting such a function might be an additional task,
but it will emphasize the robustness of our project.
Any comments are welcome.

If you're interested in maintaining/implementing this, I would be supportive.
Personally, I am reluctant to work on this because I value being able to refactor xarray internals without added friction. We are pretty clear in the docs that pickle isn't supported for long term storage, so this is a problem they somewhat brought upon themselves.

My 2 cents. I would be reluctant to find this in Xarray anytime soon. This just seems like its going to be a hard thing to maintain. Perhaps, after the data model and api have really stabilized, this would make sense, but it strikes me as something that is going to be more work than its worth to maintain. Afterall, we can rountrip xarray datasets to a number of stable file formats.

@jhamman

Perhaps, after the data model and api have really stabilized, this would make sense, but it strikes me as something that is going to be more work than its worth to maintain.

Agreed.
In my experience, surprisingly many people (including my students) are using pickle without notifying its potential risk.
Is it too redundant to issue a warning when xarray object is being pickled (maybe in getstate method)?
It is annoying for the short term usage by advanced users though.


joss-paper: Elaborate on target audience

I think both the documentation and the paper would benefit from a clearer statement on who the target audience is. I think it suffices to name the main (potential) end users of this software package.
See openjournals/joss-reviews#5003

I would like to disagree here politely. There are at least three other implementations of sparse grids, which I cite to show the significance of sparse grid approximations. I explain the necessity of my package by distinguishing myself from the other packages.
The package has been written to the best of my abilities to be universally applicable. For example, if there is any functional relation y=f(x), this package can be used to sample that function.

Hi, @baxmittens,
I am not saying I did not get an idea of your target audience by reading the whole statement of need section of your paper, I am merely suggesting a clearer (shorter) statement of your target audience.

The package has been written to the best of my abilities to be universally applicable. For example, if there is any functional relation y=f(x), this package can be used to sample that function.

I agree that anyone can use your package to sample f(x), but I think you designed it based on a scenario where evaluation of f(x) is time-consuming or memory-heavy. So, I would say your end users are, above all, people who want to evaluate that type of functions, right?
Thereby, my suggestion is to put that into a single sentence. Something like adding to the first sentence of the statement of need

"DistributedSparseGrids.jl is a Julia package for integrating and interpolating functions with generic return types, whose evaluation is time-consuming and/or memory-demanding.".

Anything of the sort would do for me.
But I leave this as a suggestion to improve your paper. I know it's a detail. So, I am closing the issue.


Inconsistent perspective on world join

I have perspective set to 0 (first-person) in my standardoptions.txt. However, sometimes I join in third-person front view when I enter a world from the wall instead. I have tested with both true and false for changeOnResize, with running 6 instances instead of 9 in case it was a lag issue, and with using the full standardoptions.txt in each instance instead of copying the file path of the global file, but none of these seemed to solve the problem. Weirdly enough, the issue doesn't seem to exist when I only play a single instance from my wall (e.g. only pressing "r" or "f" on and then resetting one of the instances), but once I start loading into different instances, the issue comes back. I can link a video example if you want to see what it looks like (also for reference, my change perspectives key is caps in case this conflicted with something in the mod).
Smooth lighting off also seems to correspond to "ao:2" in standardoptions.txt instead of "ao:0" as it normally is, and I'm not sure if this is tied to the inconsistent perspectives bug. All the other settings in standardoptions.txt work as intended.

could you try unbinding your perspective hotkey to make sure the macro isnt accidentally pressing it?
smooth lighting i think is bugged because of sodium which should be fixed there

wow that actually seems to have solved the problem, sorry for the dumb post lol


core: only recurse relevant request objects

Fixes #1908
Previously, we took an input object that would go to request and iterated over all of the properties. This turned out to be an issue when the request object had properties containing circular references. What we really want to do is loop a select number of properties which may include the projectId token:

reqOpts.qs (an object which gets serialized into a query string)
reqOpts.json (the JSON payload)
reqOpts.uri (the URL the request is sent to, which always exists)

LGTM - my only request would be to add a (probably system) test that passes in something with a circular reference.

That's a fair request, but hopefully you can help me figure out the right way to handle this, because it might be more complex than it seems at first glance.
The error reported from #1908 is indeed from a recursion issue. And this PR does fix it, but not by handling the circular reference directly, but by narrowing the scope of the input to these methods that we loop over. In effect, that addresses the circular reference, because we aren't looping over unknown values on the reqOpts object, which seemed to be affected by the environment. This will now only loop over the parts of the request that could contain the project ID token, which we control.
But, the project ID token could be alongside user input, and that user input could have a circular reference, and when we iterate over it looking for the project ID token, the code would blow up the same way as in #1908. The complicated part is, each API-- or even, each method-- could have its own preferred way of handling circular references-- maybe it's okay, maybe it should be replaced with [Circular], maybe it should be removed, maybe it should blow up the code (granted, with a more helpful error, which will [happen after #2068).
So, the question is-- do we handle circular references, and if so, how?


[vcpkg msys] Fix msys2

Update to 2020-07-20. Unfortunately, this drops support for building on x86
cc @ras0219-msft @BillyONeal

vcpkg_acquire_msys
  if(_vam_HOST_ARCHITECTURE STREQUAL "AMD64")
    set(TOOLSUBPATH msys64)
    set(URLS
	  "http://repo.msys2.org/distrib/x86_64/msys2-base-x86_64-20200602.tar.xz"
      "https://github.com/msys2/msys2-installer/releases/download/2020-06-02/msys2-base-x86_64-20200602.tar.xz"
      "https://sourceforge.net/projects/msys2/files/Base/x86_64/msys2-base-x86_64-20200602.tar.xz/download"
    )
    set(ARCHIVE "msys2-base-x86_64-20200602.tar.xz")
    set(HASH ea754c9ea9fc7ae7051c15f97f5ee95dc628bf12af3713f941991a6ab3169f4c23767d132fa6640338a449648998dc4013c6f094f7ce2fe44c61caf276caf8c6)
    set(STAMP "initialized-msys2_64.stamp")
  else()
    set(TOOLSUBPATH msys32)
    set(URLS
      "http://repo.msys2.org/distrib/i686/msys2-base-i686-20200517.tar.xz"
      "https://github.com/msys2/msys2-installer/releases/download/2020-05-17/msys2-base-i686-20200517.tar.xz"
    )
    set(ARCHIVE "msys2-base-i686-20200517.tar.xz")
    set(HASH 74786326c07c1cf2b11440cbd7caf947c2a32ebcc2b5bb362301d12327a2108182f57e98c217487db75bf6f0e3a4577291933e025b9b170e37848ec0b51a134c)
    set(STAMP "initialized-msys2_32.stamp")
  endif()

?

But if the host is x86, how should we use msys?

@emptyVoid Ping for review this PR.

From https://www.msys2.org/:

MSYS2 requires Windows 7 (64 bit) or newer

and x86 is no longer supported

Well, afaiu MSYS2 team have just dropped building x86 installer. MinGW packages are still being updated for both platforms. And vcpkg doesn't really use the x86_64-only MSYS tools and packages.
I'm not sure if this is a good move to forsake all the vcpkg users who are stuck with x86 build servers, though of course I got no idea how many of them are out there.

what about #12467 instead?

Fixed by #12467 instead


clean go.mod

Description
Updates go.mod so that:

tm-db is at v0.6.7
we no longer need a replace statement for gorocksdb
tendermint is at v0.34.16

For contributor use:

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[x] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer

Codecov Report

Merging #1007 (d9ba38c) into main (08b3bd6) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head d9ba38c differs from pull request most recent head b4d13ff. Consider uploading reports for the commit b4d13ff to get more accurate results

@@           Coverage Diff           @@
##             main    #1007   +/-   ##
=======================================
  Coverage   20.60%   20.60%
=======================================
  Files         193      193
  Lines       25237    25237
=======================================
  Hits         5199     5199
  Misses      19084    19084
  Partials      954      954

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b3bd6...b4d13ff. Read the comment docs.

(In particular that tendermint/tendermint#7885 isn't problematic with our app version being initially set wrong)

this is a partial fix to the app version issue, the other fix is in the sdk. We are still waiting on a test for it.

@marbar3778 I've tested this with both the -tags and the ldflag and it works for compiling with rocksdb.


Run the parser-generated files through dos2unix

On Windows, menhir uses native end-of-lines, but our repository enforces LF as a convention.
This means that anyone running through a boostrap cycles on Windows ends up with:
modified:   src/parser/ml/parse.mly
modified:   src/parser/parse.fsi
modified:   src/parser/parse.fsy

warning: CRLF will be replaced by LF in src/parser/ml/parse.mly.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in src/parser/parse.fsi.
The file will have its original line endings in your working directory.
warning: CRLF will be replaced by LF in src/parser/parse.fsy.
The file will have its original line endings in your working directory.
The Makefile should do:
DOS2UNIX=$(shell which dos2unix >/dev/null 2>&1 && echo dos2unix || echo true)

889301cbb72c0b77e49559372218d61d64dde42c


docs: add badge showing supported Python version range

This PR

docs update. Adds a Python badge showing the supported versions.

Related Issues

Fixes #1234523
Notes

So very inconsequential, but badges are the first place a lot of people look (including me).
Follow-up Tasks

Make sure to update the version here too :slightly_smiling_face:
How to test

Open the README.md
Read badges
Confirm it says "Python >=3.8"

Codecov Report

Merging #30 (d3d180a) into main (b39cced) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   85.40%   85.40%
=======================================
  Files          17       17
  Lines         281      281
=======================================
  Hits          240      240
  Misses         41       41

Flag
Coverage Δ

unittests
85.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed off on commits


update output of elasticapm test management command

What does this pull request do?
We are not able to show an URL to the error, so we explain
how the user can find the error in Kibana themselves.
Why is it important?
Telling the user to open an URL that isn't there is a bit confusing...

Test failure is due to psutil/pypy incompatibility, see https://github.com/elastic/apm-agent-python/pull/725


test: [M3-7891] - Improve Cypress feature flag mocking ergonomics

Description 📝
This is a backwards compatible change to how we mock LaunchDarkly feature flags from our Cypress tests. The goal of this change is to make mocking feature flags less burdensome when writing Cypress tests.
Previously, mocking LaunchDarkly features required using the mockAppendFeatureFlags, mockGetFeatureFlagClientstream, and makeFeatureFlagData utils. With this change in place, only mockAppendFeatureFlags is required to mock feature flags in most cases. This is a backwards compatible change, however, so existing calls to mockGetFeatureFlagClientstream, mockAppendFeatureFlags, and makeFeatureFlagData will continue to work as expected.
This PR also modifies a few tests for the sake of demonstrating the change, but the remaining clean up of our feature flag mocks will be handled by M3-8321.
Changes  🔄

Call mockGetFeatureFlagClientstream before every test, making it unnecessary to call from within tests
Modify mockAppendFeatureFlags to accept a FeatureFlagMockData object, which is a new type that allows feature flags to be expressed more flexibly
Clean up feature flag mocks in betas.spec.ts, create-image.spec.ts, and placement-groups-navigation.spec.ts to demonstrate the change
Removes mockGetFeatureFlags since we've never used it and don't have a use case for it

How to test 🧪
We can rely on CI to confirm that these changes work. Specifically, we want to ensure that existing calls to mockAppendFeatureFlags, etc., continue to work as expected (this is the majority of our tests), and that the modified tests (betas.spec.ts, create-image.spec.ts, and placement-groups-navigation.spec.ts) pass too.
As an Author I have considered 🤔
Check all that apply

[ ] 👀 Doing a self review
[ ] ❔ Our contribution guidelines
[ ] 🤏 Splitting feature into small PRs
[x] ➕ Adding a changeset
[ ] 🧪 Providing/Improving test coverage
[ ] 🔐 Removing all sensitive information from the code and PR description
[ ] 🚩 Using a feature flag to protect the release
[ ] 👣 Providing comprehensive reproduction steps
[ ] 📑 Providing or updating our documentation
[ ] 🕛 Scheduling a pair reviewing session
[ ] 📱 Providing mobile support
[ ] ♿  Providing accessibility support

Looks like the test failures are related to the region select label variations introduced by gecko


How to disable "this may be converted to an async function" messages, etc?

I have some messages coming from (I think) atom-typescript, which don't seem to be configured in either my eslintrc or in tsconfig.
How can we configure these messages (f.e. disable the this may be converted to an async function specifically)?

Use ignoredDiagnosticCodes option in Atom-Typescript settings. Currently only globally-configurable, although that might change in the future.

In particular, "this may be converted to an async function" is suggestion diagnostic 80006, so you would add 80006 to the (comma-separated) list of ignoredDiagnosticCodes

FWIW, those "suggestion" diagnostics are only there to provide GUI endpoints for automatic code transformations. So those can be safely ignored (as is the case with any diagnostics with severity "informational")

How can I discover the code numbers of any diagnostics?

It's literally in the settings GUI:

diagnostigMessages.json is a clickable link.

Oh sorry, well now that I know they were called "diagnostics" I surely could have figured that one out. Thanks!


GHCJS versioning

GHCJS has pushed a GHC 8.2 branch. Given this, I'd be surprised if the 8.0 branch continues to get very much support, though it has been quite stable for a while now. So I'm proposing we follow suit with the package sets indexed by GHC version, and do the same with GHCJS. That is, move haskell.packages.ghcjs to haskell.packages.ghcjs7103, move the current haskell.packages.ghcjsHEAD to haskell.packages.ghcjs80, set haskell.packages.ghcjs to the ghcjs80 set, and put the 8.2 branch on haskell.packages.ghcjsHEAD (and potentially ghcjs82, depending on how stable it is).
@peti what do you think of this? Having ghcjs82 would probably make it easier to interact with the LTS-10 package set we're based on. Of course, this is predicated on having the GHCJS 8.2 branch building in Nix, which apparently has a bunch of changes in the build system. But I have a lousy prototype for that.

For now, we have adopted the convention of keeping old GHCJSes and aliasing ghcjs.

Just FYI: I intend to drop ghc 7.10.3 soon, and this implies that we'll drop the corresponding ghcjs too.

@peti Fair enough. @dmjio you may want to start making arrangements...

@dmjio, because ghc-7.10.x is old and I don't want to maintain it.

@peti, understandable. Can you assign ownership of the derivation to me instead ? And I’ll perform the maintenance. I’d like to keep it around because GHCJS 7.10.3 is the only version that has a working GHCJSi.
Sent from my iPhone

On Jul 22, 2018, at 6:13 AM, Peter Simons<EMAIL_ADDRESS>wrote:
@dmjio, because ghc-7.10.x is old and I don't want to maintain it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Can you assign ownership of the derivation to me instead?

Such a thing as "assigning ownership" does not exist. Nixpkgs is a collaborative effort and people who make changes that affect other derivations, say, because they're changing stdenv for cross-compiling and whatnot, cannot just leave other packages in a broken state and say "someone else should fix that". If you're changing stdenv or updating binutils or updating gcc, then you have to fix the fallout from your change, too. This means that derivations we keep in Nixpkgs impose a cost on the team as a whole, especially if those are complex builds that are hard to understand, debug, and maintain. Keeping ghc-7.x around in Nixpkgs is too expensive from that PoV.
If you feel strongly about ghc 7.10.3, then I'd recommend that you maintain it in a separate repo and document how people who'd like to use it can register that repo as an overlay.

I meant like put my name in the maintainers list in the derivation, but I guess it's already there:
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/ghcjs/base.nix#L191
If you don't want to maintain it, I can't stop you. I'll handle things on my end accordingly. The real issue here is GHCJS itself.


Add owners file

Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

cherry-pick gaudi-release

/cherry-pick gaudi-release


feat(feedback): improve feedback ui using the twitter-text API

A proper fix for #39303. This PR uses the twitter-text API and suggests the feedback limit to the user via a twitter-like progress UI.
A screenshot:

Thanks, but I do not think we consider this PR at the moment in this area.


support follow symlinks on directories

currently tiny-glob does not find files in symlinked directories
sample:
#!/bin/bash

mkdir dir-1
touch dir-1/file-1
ln -s dir-1 dir-1-linked

# run tiny-glob
node -e "console.log(require('tiny-glob/sync.js')('dir*/**').join('\n'))"

# actual result
dir-1/file-1

# expected result
dir-1/file-1
dir-1-linked/file-1

the problem should be
if (!stats.isDirectory()) {

which does not detect symlinked directories
where stats.isSymbolicLink() == true
fs.realpathSync(path) can be used to fully resolve the link target
but that returns the absolute path ....
other glob tools have this feature normally off
and only enabled with a follow: true option
one reason: circular symlinks give infinite recursion

Thank you! Would you mind doing a PR for this?


Purpose of index.html file in the project root

This file seems to be pretty useless. Is there any usage of it or it can be safely deleted?

This file is useless now, it can be deleted safely


Can't use NSURLProtocol intercepts requests

As far as I know, NSURLProtocl could intercepts all reqeuests sent by URL Loading System. But after testing Alamofire (as well as AFN), My custom NSURLProtocol couldn't intercepts those requests sent by it, whici means the protocol's "canInitWithRequest" won't be consulted,  but for those sent by NSURLSession, this method could be invoked.
anyone could help me ?
thx

These tests demonstrate how you could use an NSURLProtocol with Alamofire if you wanted @Yannmm.
Best of luck! 🍻

@cnoon，it turns out that if you use a custom NSURLSessionConfiguration (rather than sharedSession()), you are gonna have to do the following to make your NSURLProtocol make difference:
        let sessionConfiguration = NSURLSessionConfiguration.defaultSessionConfiguration()

         if sessionConfiguration.protocolClasses != nil {
                sessionConfiguration.protocolClasses!.insert(KLXFakeDataProtocol.self, atIndex: 0)
         }
        // use custom sessionConfiguration to initialize your NSURLSession / Alamofire.Manager

this part is neither documented in the NSURLProtocol References nor majority of tutorials on the internet.
Hope may helop someone.


Fix paging for all prompts

origin of this issue is https://github.com/cargo-generate/cargo-generate/issues/400 where a test example is provided and little more context is given.

Hi,
I hope, @pksunkara meant "increase usability for paging" by "Fix paging for all prompts". :)
(I looked into the code of cargo-generate and the error that happens in cargo-generate/cargo-generate#400, is that they use a loooooooong list without paging, which makes the select prompt unusable)
Anyways, did a quick&dirty demo with the select prompt to suggest how we could increase the usability with paging.
Maybe that is what you had in mind...
Here's what I added:

Prompt is always shown on every page
A page indicator is printed next to the prompt

Here's how it looks with the select example:

I also tried it with cargo-generate with the repo described in cargo-generate/cargo-generate#400. It looks like this:

If this is what you had in mind, I could start implementing this for all prompts that need paging and make a PR to discuss the details.
Another thought here:
IMHO dialoguer should figure out for itself if it needs to activate paging or not. It could just check, if selections.len() > capacity and activate paging automatically.

D'uh. I somehow managed to delete my comment (I can't see it anymore) 🤦♀. So here we go again:
I hope, @pksunkara meant, "Increase paging usability" with "Fix paging for all prompts". :)
I looked into the code of cargo-generate regarding cargo-generate/cargo-generate#400. What happens there is, that they use a looooong list without paging, which makes the select prompt unusable.
Anyways, I did a quick&dirty demo to suggest how we could increase the usability with paging. Here's what it could look like with the select prompt:

I also did it with the example mentioned in cargo-generate/cargo-generate#400, which then would look like this:

If this is what you actually meant, I could start implementing this for all prompts that need paging and make a PR to discuss the details.
Another thought here:
IMHO, dialoguer should figure out for itself, if it needs paging or not. It could just check, if selections.len() > term.size().0 and activate paging for itself. This would also prevent errors like cargo-generate/cargo-generate#400 in the future.

use a looooong list without paging, which makes the select prompt unusable.

Even if paging was enabled, there are quite a lot of issues with it (especially when terminal is resized).

IMHO, dialoguer should figure out for itself, if it needs paging or not. It could just check, if selections.len() > term.size().0 and activate paging for itself.

I agree. Basically the whole paging thing in dialoguer needs to be looked over carefully, improved and all bugs fixed. Which is what this issue is about.

This will be perfect, once your feature with Fuzzy Search also lands in a release :-)

Ok, good to know.

Even if paging was enabled, there are quite a lot of issues with it (especially when terminal is resized).

@pksunkara Could you elaborate further, which issues there are? Or just throw some issue numbers at me. I would like to look into it and check, if I can fix that stuff.

I started to work on fixing paging in https://github.com/deg0nz/dialoguer/tree/Test-Paging-Stuff
I managed to extract all the paging stuff and put it into an own module without breaking the paging feature so far.
But some things came up:

I added an update() function so the whole page can be re-rendered. But this only works, when a new key press occurs, because then the next loop iteration is started. If we really want a dynamic updating of the whole screen, we need something that observes term.size() output -> I think this would need changes in console as well and could involve concurrency and/or async stuff. But I think, that "healing" on the next keypress would suffice for now.
The more I work on the paging stuff, the more it feels, that this should somehow be a part of TermThemeRenderer. Should we leave a Paging module, or should we integrate the paging into TermThemeRenderer?


Similar project?

Saw your ycombinator post, thought I'd make you aware of a similar effort:
https://github.com/llm-workflow-engine/llm-workflow-engine has linear workflows (via Ansible integration), conversation threads, templating, provider/model presets, and OpenAI functions support.
I built it for the same reasons listed in the OP -- really seemed like a simple linear workflow manager would be incredibly useful.

@thehunmonkgroup very cool! I wasn't aware of that project. It seems quite robust. I'm leaning towards something much lighter weight here, and this is very much a personal project right now. I'm going to close this issue but keep an eye out for great stuff from LWE.


Sign PowerShell Module Files

Is Your Feature Request Related To A Problem? Please describe.
In order to provide confidence in the source of the PowerShell Module files, we should sign then using the authenticode certificate for Chocolatey Software, Inc. so that the consumers that trust where they come from.
Describe The Solution. Why is it needed?
Use the Chocolatey Software, Inc authenticode certificate during the build process to sign the final PowerShell Module files before shipping the package to the PowerShell Gallery.
Additional Context.
N/A
Related Issues
N/A

The work associated with this issue was completed during this PR:
https://github.com/chocolatey/ChocoCCM/pull/70


Failure to generate client interface

Not sure if this is NSwag or Microsoft failing.
given a csproj file containing
  <ItemGroup>
    <OpenApiReference Include="OpenAPIs\TestQueryDoc.json" CodeGenerator="NSwagCSharp" Namespace="Test.Query" ClassName="TestQueryClient">
      <SourceUri>http://localhost:5001/Test/swagger/v1/docs.json</SourceUri>
      <Options>/GenerateExceptionClasses:false /AdditionalNamespaceUsages:Test.IAPI.Exceptions /GenerateClientInterfaces:true</Options>
    </OpenApiReference>
    <OpenApiReference Include="OpenAPIs\TestCommandDoc.json" CodeGenerator="NSwagCSharp" Namespace="Test.Command" ClassName="TestCommandClient">
      <SourceUri>http://localhost:5002/Test/swagger/v1/docs.json</SourceUri>
      <Options>/GenerateExceptionClasses:false /AdditionalNamespaceUsages:Test.IAPI.Exceptions /GenerateClientInterfaces:true</Options>
    </OpenApiReference>
  </ItemGroup>

The client interface is generated for TestQueryDoc.json but not TestCommandDoc.json, it is referenced by TestQueryClient but not TestCommandClient
It does not matter which order the references are in.
Clean and rebuild does not change the result.
[System.CodeDom.Compiler.GeneratedCode("NSwag", "<IP_ADDRESS> (NJsonSchema v<IP_ADDRESS> (Newtonsoft.Json v<IP_ADDRESS>))")]

And then the next day, having survived a restart previously, it magically starts working properly, without even closing Visual studio.

And then back again.


Search dropdowns stay in absolute position on page

Brief Description: An open dropdown box stays in the same spot on the screen while scrolling instead of scrolling up.
Operating System (OS and version): OSX
OpenBazaar version (shown on About OpenBazaar page in menu): 1.7.8 (1.7.8)
Hardware: MBP
Reproducible (Always / Almost Always / Sometimes / Rarely / Couldn't Reproduce): Always
Steps to reproduce:

Go to search
Open shipping dropdown
Scroll page

Additional info (links, images, etc go here): https://imgur.com/a/Yw6mF

Another lovely gift from select2 for us. It may be fixable if we use the property where we give it a specific container for the menu as opposed to letting it create one in the body... but I"m not sure.


”Brateiu”, ”Buzd” are listed in the drop-down menu

Description:
When user writes ”Brateiu”, ”Buzd” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Brateiu"

Expected results
The location appears in the drop-down menu as "Sat Brateiu, SIBIU (Brateiu)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Buzd"

Expected results
The location appears in the drop-down menu as "Sat Buzd, SIBIU (Brateiu)".


Remove the text-align="justify" property for the PDF TOC entries

If the TOC entries are long enough to be rendered on multiple lines, the first lines are displayed justified. We have users that dislike this presentation mode and ask how to disable it.
Searching in the GitHub history, I see that this property was set to fix an issue regarding an uneven right edge on PDF TOC, see #735.
I've tested with Apache FOP 2.1 and DITA-OT 2.5 and the numbers from the right side seems to be aligned correctly.
So, could we discard the changes from the issue #735?

There is no DITA-OT 2.5 and FOP 2.1 isn't shipped with stable DITA-OT.

Link to our forum where you can see the images posted by our user:
https://www.oxygenxml.com/forum/post38630.html

Sample files with a TOC that has a short title, 2 line title, and 3 line title (with only long words so the justification is obvious):
2403.zip

Fixed with https://github.com/dita-ot/dita-ot/commit/d822cb3c83647b9cbb1d90c414a54b02591edbda


Update docs for Raspberry Pi

Please provide us with the following information:

Raspberry Pi has a new 64 bit OS, and the good news is that it works.
Please update the docs to reflect this, and the renaming.
Raspberry Pi OS 32bit is not currently supported
Raspberry Pi OS 64 bit Beta is working
This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [X] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

This relies on issue #451


Replace awesome_print with amazing_print

With Ruby 2.7.1, awesome_print emits a deprecation warning when evaluating the Pry prompt:
2.7.1 (jazz_fingers)[5] » Array([3])
~/.asdf/installs/ruby/2.7.1/lib/ruby/gems/2.7.0/gems/awesome_print-1.8.0/lib/awesome_print/formatters/base_formatter.rb:113: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead
~/.asdf/installs/ruby/2.7.1/lib/ruby/gems/2.7.0/gems/awesome_print-1.8.0/lib/awesome_print/inspector.rb:63: warning: Capturing the given block using Proc.new is deprecated; use `&block` instead

It looks like awesome_print is abandoned but there's a maintained fork it can be replaced with: https://github.com/amazing-print/amazing_print

released as 6.0.0.pre.rc1
Thanks @jmromer !


Bench updates

Fix the diesel_async benchmarks
Bump some dependencies
Use batch inserts for all crates supporting sqlite so that this is a fair benchmark

Perhaps this gets into the weeds of DB drivers and the like (for instance, I only recently learned that most DBs ship with native C libraries for other programs to take care of SQL parsing, wire protocols, network calls, etc. 😅 ), but is having two separate dependencies a concern for diesel as far as diesel+async is concerned?

That's the reason for the distinction of Backend and Connection in diesel. A Backend describes a specific sql database implementation. This includes things like the specific sql syntax or how the database serializes values. A Connection describes how should diesel interacts with the database, so essentially which low level driver is utilized to talk with the database. The design explicitly allows that a Backend has more than one Connection implementation.
For diesel we have different feature flags for the Pg backend (postgres_backend) and for the PgConnection implementation (postgres, which implies postgres_backend).  This allows users to better opt in what should be included and what not. For the diesel_async use case I just enable the postgres_backend feature to have access to the backend implementation. That removes the dependency to libpq as we don't need PgConnection there.


CSS Tweaks

Reviewer: @rox163
This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[X] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG
-Modifications to align with UX spec

:+1:


Free k666

I think I fixed the Readme file now. I get confused over which repository to use. Hope this was the right one.

No... it wasn't the right one... sorry...
Also, there were two conflicts in README.md... you only fixed the top one.


XCTests and XCUITests failing on webview_flutter_wkwebview package iOS 17 XCode RC1

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Install XCode RC1 and iOS 17.0 Simulator
git clone GitHub - flutter/packages: A collection of useful packages maintained by the Flutter team
cd packages
cd web_view_flutter/webview_flutter_wkwebview/example/ios
flutter pub get
pod install
Run the test using command (Replace $simulator_id):

xcodebuild test -workspace Runner.xcworkspace -scheme Runner \

-destination 'platform=iOS Simulator,id=$simulator_id' > logs.txt

9- Alternatively, you can run test inside Xcode in the Test Navigator
Expected results
Running all tests should succeed
Actual results

[Screenshot 1]: Xcode test navigator showing failing test: testLoadRequestWithInvalidUrl
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
error: -[FWFWebViewHostApiTests testLoadRequestWithInvalidUrl] : loadRequest:<OCMAnyConstraint: 0x600000b41910>: explicitly disallowed method invoked: loadRequest:<NSMutableURLRequest: 0x600000b476e0> { URL: %25invalidUrl%25 } (NSInternalInconsistencyException)

Test Case '-[FWFWebViewHostApiTests testLoadRequestWithInvalidUrl]' failed (0.049 seconds).

Test Suite 'FWFWebViewHostApiTests' failed at 2023-09-18 16:07:37.317.

Executed 1 test, with 1 failure (1 unexpected) in 0.049 (0.050) seconds

Test Suite 'RunnerTests.xctest' failed at 2023-09-18 16:07:37.318.

Executed 1 test, with 1 failure (1 unexpected) in 0.049 (0.051) seconds

Test Suite 'Selected tests' failed at 2023-09-18 16:07:37.318.

Executed 1 test, with 1 failure (1 unexpected) in 0.049 (0.053) seconds

Flutter Doctor output
Doctor output
[✓] Flutter (Channel master, 3.14.0-14.0.pre.333, on macOS 13.5.2 22G91 darwin-x64, locale en-UY)

[✓] Xcode - develop for iOS and macOS (Xcode 15.0)

[✓] Chrome - develop for the web

[✓] VS Code (version 1.82.2)

[✓] Connected device (3 available)

[✓] Network resources

This will be the same problem as described here, so I'll fix it at the same time.

Hi @stuartmorgan, thanks for the answer. FYI there is a third XCTest-XCUITest issue we reported that might be caused by the same problem you described. Here it is in case you want to take a look.
Thanks.


cart e2e spec failing

Closes GH-5287

I don't think this should be approved because this 'was' a fix for waiting for an item to be added to a cart. One day or eventually, this test will fail because of how fast cypress runs.
I think we need to check why this request wasn't sent, therefore not waiting if that's the case or why the ticket really failed.

I think that failed for other reason. This wait for anonymous cart refresh and sometimes this function might have been used for logged user, so url pattern needs to be improved to catch both current and anonymous user.

I don't think this should be approved because this 'was' a fix for waiting for an item to be added to a cart. One day or eventually, this test will fail because of how fast cypress runs.
I think we need to check why this request wasn't sent, therefore not waiting if that's the case or why the ticket really failed.

I think that failed for other reason. This wait for anonymous cart refresh and sometimes this function might have been used for logged user, so url pattern needs to be improved to catch both current and anonymous user.

Looking at the code, I see that it should only be when the user is an anonymous user because when this function 'manipulateCartQuantity' gets called, it always gets called after a user signs out. (Only looking at cart here)
However, if you really want, we can meet in the middle. We can put a wild cart in between /users/*/carts. But I think, what I said above should always have the user as anonymous and never as a current user


Fix C# Solution Directory Project Settings

Related Issue: #68381
he C# editor plugin would not load the change of project settings, so it always generates files in the default directory. I added a function  RefreshProjectLocation to force it reloading the settings.
The dll compiled would be generated where the sln file is, so the engine could not find it correctly. I added BaseOutputPath and OutputPath in the csproj file to re-indicate that dotnet should output results in the default place.
In the default case, a C# script would be compiled only if it is located at the same/the sub directory of the csproj. To make all scripts reachable, I also addedCompile Include in csproj.
Since the GodotProjectDir in modules\mono\editor\Godot.NET.Sdk\Godot.NET.Sdk\Sdk\Sdk.props depends on the sln file's path, rather than res://, scripts' pathes in the dll file would be incorrect after the sln file has been moved. So I rewrote the GodotProjectDir in the csproj.
It runs well on my device. Feel free to tell me if something goes wrong or something needs to be changed. :smiley:
Bugsquad edit:

Fixes #68381

Thanks!


[W-10592849] banner for beta

ref: W-10592849
Add a banner for beta only.
beta:

archive:

To test:

run gulp bundle to create a local UI bundle
open antora-site-playbook and switch to the beta branch
select one of the playbook, point the UI bundle to the local ui-bundle.zip path, run make gen-site playbook=replace_me_with_the_playbook_path
verify that the site has the beta site banner (see first screenshot)
revert the change, and switch to the archive branch
open antora-playbook.yml (or create a my-playbook.yml). Point the UI bundle to the local ui-bundle.zip path, run make gen-site playbook=replace_me_with_the_playbook_path
verify that the site has the archive site banner (see second screenshot)

https://www.loom.com/share/ceb8b7d205564a30ac4920506492b022


Sets default uv size for cylinder to 3 on x axis

Makes the uv mapping less stretched on the cylinder by default

Are you sure this is the correct value? The texture still seems stretched, judging from the appearance of CylinderMesh in the Godot editor.
UV Scale (3, 2)

Compare this with Vector2(2, 4):
UV Scale (2, 4)


[fix][meta] Use ForkJoinPool.commonPool to handle Metadata operations

Motivation

Observed that the metadata store executor thread can be blocked when handling chained future operations (e.g. while running handleGetResult). Especially, when the chained future operation needs to wait for another metadata access, this can block the metadata get/put operations, because the flush() will never be called(because the executor is blocked now).
Modifications

Use ForkJoinPool.commonPool threads to execute the metadata operations, instead of the metadata executor thread.

Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/heesung-sn/pulsar/pull/65

Questions:

This looks like just wanna mitigate the issue to the common pool. we should avoid blocking calls for metadata.
Did you think about multi-thread will change the request order?

Although ForkJoinPool can grow very large(max 32767) -- it is less likely exhausted  (Should be more than the number of caller threads), I agree that we should not chain the "heavy operation" (in this case, metadata sync calls) after the metadata operation.
I will fix the caller code not to trigger the metadata sync call, instead.


Test case for request.get(...).send(...) querystring

Test case for issue #606; test currently fails for .send, but passes for .query.

.send won't result in a querystring, so not sure what that test is trying to show.

As mentioned in #606, the documentation indicates that it does:

When issuing a GET request the res.send(obj) method will invoke res.query(obj),

This test shows the described behavior.  If that's not what is desired/expected, the docs need to be changed.

That is tragic. I think being explicit is better. Did this behavior ever
work?
On Sunday, April 12, 2015, Charlie DeTar<EMAIL_ADDRESS>wrote:

As mentioned in #606
https://github.com/visionmedia/superagent/issues/606, the documentation
indicates that it does
https://visionmedia.github.io/superagent/#query-strings:
When issuing a GET request the res.send(obj) method will invoke
res.query(obj),
This test shows the described behavior. If that's not what is
desired/expected, the docs need to be changed.
—
Reply to this email directly or view it on GitHub
https://github.com/visionmedia/superagent/pull/607#issuecomment-92201830
.

I don't know if it ever worked. But I know I tried it, when implementing a polymorphic function that handled both getting and posting, and the docs said I could -- something like:
function sendIt(method, data) {
    request[method]
        .send(data)
        .set("Authorization", ...)
        ... other stuff ...
       .end()
}

Having to branch "send" to "query" when using a different verb makes that a fair shake less elegant to implement.  But I recognize that conflating query/body could constrain you from exercising edge cases in the HTTP spec like sending a body along with a get request.  I'd personally be happy with a docs fix as well.

Are you having this issue with the client or browser versions or both?

Uh -- client version, I guess?  I'm using superagent in unit tests under node, and browserify-packed version in the browser.  Invoked like this in both cases:
var request = require("superagent");
request.get...

I too encountered this issue recently, I have to branch for gets and do the exact same code block but replacing "send" with "query". Was there ever any movement on this?
I use both the node and the browser versions of this library.

+1 on this, couldn't figure out why send() wasn't working with get().  Forcing .query() instead makes code harder for no reason.  @englercj is your version up on NPM?

@blented No, the logic to do what I mentioned is in my application code. I didn't change this lib.

+1.  Ran into this same issue.  Docs and test case says it's supported.  Turns out, it's not.  I was also creating a polymorphic function like @yourcelf explained above.

+1
I remember this working at some point, but as long as the documentation is consistent/accurate I don't care which way this goes.

OK, I have updated the docs to no longer lead users to believe request().get().send() will populate the query string. I agree that behavior was confusing and inconsistent and crossed the border from smart/convenient into magic and surprising. So .query() is for query strings and .send() is for bodies.


rasa test to include action server

Description of Problem: How do I test that my bot is working?
Currently, rasa test :

Fully tests NLU, including external entity extractors like duckling
Does not fully test e2e stories, because it does not actually call the action server.

This means that even when rasa test shows that all the e2e stories pass, it is not a guarantee that the bot is functional. One has to test all the e2e stories manually, which is a lot of work and it slows down the CDD iterations.
Doing tests with the action server included is especialy important during the CDD Fix step, or when upgrading a bot from Rasa OSS 1 to Rasa OSS 2.
A side benefit of including the action server during rasa test is that it would provide a nice method for debugging custom actions and it provides a declaritive mechanism to create full coverage tests of the custom actions. (https://github.com/RasaHQ/rasa/issues/4212#issuecomment-698888514)
Overview of the Solution: rasa test calls the action server.
Blockers (if relevant): It is not a blocker, because it is standard testing practice. But, the user must be careful that the action server is running in some kind of local mode or testing mode. Eg. during testing it is not actually updating a production data-base or calls external services.
Slack thread

Anything you would add @akelad? We have discussed this in the past

Context behind past decision to not execute actions in test stories: https://forum.rasa.com/t/snapshot-based-testing-with-rasa/13318

not much to add to this, but we have had customers bring this up a few times in the past year.
Having a mock action server for testing I believe is common in the enterprise anyways -otherwise you would be modifying "real world things" with your manual tests as well. So I feel like allowing rasa test to include the action server again could make sense

I really think we should make running the actions a possibility, especially given another data point that Ella added to the Slack thread yesterday. I'm adding this to the Rasa Open Source 2.1 milestone to push this discussion more

So I've looked a bit into this issue. I think this is actually quite a big architectural and dev experience decision and I would like to discuss this a bit more to make sure we are on a good path forward.
If I understand correctly the proposal is that when using rasa test the action server should run alongside so that custom action code is run to validate that slot_was_set is actually happening and use this as test cases for the custom actions. As a result, it would be easier to test that the actions are actually doing what they are supposed to do.
In the following I am comparing a unit testing-based approach that we currently advise in the docs to this approach (yellow box at the end of this section). While we have that hint in the rasa docs, there is no section on testing actions in the actions server docs ⚠
Unit Testing
Pros

Extensive test capabilities beyond simple equality for values. slot_was_set would currently just amount to direct equality check
Simpler to test actions for multiple different values
Fosters configurability and testability of actions from the get go as opposed to making it an afterthought
Separating testing the machine learning model and manually written code leads to faster turn around time for developing actions
Testing different environments for actions is straight forward (e.g. working service, failing service, slow service, ...)

Cons

Seems Difficult/Cumbersome to manually write realistic tracker states as inputs for unit tests

Action server in rasa test
Pros

some test cases are already there and we can use them

Cons

Test capabilities are limited; Developing additional capabilities might be quite complex (building our own testing framework ). As stated above slot_was_set would currently just amount to direct equality check
Tight coupling of model and action testing - I am thinking, if you want to debug an action, you might want to do so for specific test cases - this means we would ideally also have a mechanism to single out specific test stories from the set instead of running all of them. This already easily doable in unit testing - just pick your test case - but needs additional deliberation and work in the conversation setting.
I think even with this capability in place, you might still wanna unit test your actions for situations when background services fail etc. You could do this here, but then you would need to specify environment configs alongside stories

In my opinion, we should go with unit testing approach and make it easier to understand and use:

Improve the docs (prominent section on how to test actions, best practices)
Provide some abstraction for the test cases, e.g. the one outlined here by @koaning
Potentially provide some method to generate complex tracker states (does this possibly already exist?)

option a) export tracker state from an interactive session -> paste data into the unit test.
option b) write conversation in the unit test -> simulate tracker state based on config, domain and the given conversation -> use resulting tracker state to test

What do you think @ArjaanBuijk , @koaning, @TyDunn. Is this an accurate overview of the choices and their merits? Did I miss something? Please discuss :)

From a high level, this seems like a fair overview at first glance. Curious to also hear what @wochinge thinks, since he spent some time in the code last Friday, as well as @akelad and the others you tagged

Thanks for writing this detailed overview! 💯
In my opinion we need both. I see conversation tests as integration tests. From that perspective it makes sense to include the action server in the. conversation tests as you want to ensure the behavior of all components combined. It's less about checking certain slot values in my opinion, but rather whether the conversation flows as expected (e.g. that the custom action isn't causing the bot to say goodbye after the user said hi). This is of course also possible with unit testing but I think it's fragile as:

you need a very good understanding which custom action events cause which bot behavior
you need to have all stories / rules in mind when design unit tests for the action server
conversation tests and unit tests are separated. So when you change a story you need to think of two places to adapt instead of just one.

Considering a team workflow where the conversation designer comes up with the conversations and the developers implement them, I'd expect the conversation designer also to be the one who is acceptance testing the assistant's behavior. Ideally they can define a definition of done (stories of done 😆 ) right at the beginning which the developers can use to develop the bot against. Although this makes me cringe as developer, I'd argue that unit tests are less of a priority / have less value in this setting.

Tight coupling of model and action testing

Interesting point. I think actions which set featurized conversation state are somewhat part of the model 🤔
Slightly off topic:
You're slot_was_set example touches a very interesting point. As far as I know our conversation tests do not test slot values at the moment. In my opinion this is less interesting for featurized slots as they will influence the conversation flow anyway, but it might be interesting to check for unfeaturized slot values (e.g. whether the form extract slots as expected).

+1 to Tobias' opinion, for me the full conversation tests are more important, i.e. the action server in rasa test option. Every customer we've ever worked with always needs to test the full flow, including the execution of the custom actions. Something we should consider though, is that you might not want to run your "prod custom action" because that might be modifying real world data. So you'd have some sort of mock custom action instead - not actually sure how our customers handle this, though i'd imagine they just have slight variations of custom actions in their dev/qa/prod envs?

Thanks for the food for thought! Lots of new info here for me :) will look into these things

So you'd have some sort of mock custom action instead - not actually sure how our customers handle this, though i'd imagine they just have slight variations of custom actions in their dev/qa/prod envs?

Up to them to create a proper integration test environment, no? If their custom actions need a database than their integration tests need a test database 🤷🏻

yeah i was kind of thinking aloud and came to this conclusion in the end as well :D

Something we should consider though, is that you might not want to run your "prod custom action" because that might be modifying real world data. So you'd have some sort of mock custom action instead - not actually sure how our customers handle this, though i'd imagine they just have slight variations of custom actions in their dev/qa/prod envs?
@erohmensing @ArjaanBuijk You mentioned some customers that you work with already run actions with whole conversation tests. Do you know how they handle this?

@TyDunn ,
There were always non-prod environments to run these tests, and those non-prod environments are complete copies of the prod environment, including the action server.

This has come up a bunch of times over the years from multiple customers

One more data point from a user, in favour of testing custom actions:
In summary: The combination of not being able to direct a conversation based on intent x entity value, and not being able to run the custom actions that work around that limitation, is particularly frustrating.
Currently, entity values cannot directly influence action prediction, only entity types. If you autofill a categorical slot of the same name with the entity value, you can direct the next step of the conversation, but now it also gets set at every point in the conversation where that entity is extracted, which is not always desirable.
To work around this limitation, you can create a slot with a different name, and fill it from the entity using a custom action only in those stories where it is needed. Depending on how many instances of this you have, you can end up with many more custom actions than before, and none of them are run during testing.

Are there any updates on this?

Enable has done a spike on conversation testing and then benched it for 3.0 after talking to a few customers as we've realized that it doesn't make sense to do something hacky which doesn't work longterm. What I know from @TyDunn is that it's gonna one of the two key things for 3.1

Is this still slated for 3.1? I'm doing a lot of manual testing with rasa shell --debug because of this and #9013

It's currently planned for next year and unclear in which release it will go into. This is an issue we want to address holistically with other pain points our customers are seeing. Stay tuned!

Hello :)
Is it maybe possible to get an estimate when we could expect solution to this issue?
It just occurred to me that the values of slow_was_set are not being considered in test stories (neither is slot extraction or validation inside forms) and as I understand this boils down to being able to test Rasa with running actions server.
Knowing the potential time frame could help me decide if writing a custom solution is worth the effort.

As a workaround, you'll find a pytest example in the financial-demo here.

@lumpidu thanks for your comment, and sorry for the miscommunication on my end. I had written this above:

Closing this issue as we're planning more discovery on this topic in the next months

We're continuing internal work on this, and you should hear a few updates in the next months. I'll see about re-creating a Jira ticket in the OSS backlog. Thanks a lot for your interest!

Is this issue still in progress?


Documentation for updown

added documentation for up down
fixes #159

Will merge first, please fix the styling in another PR


[MetricsAdvisor] Randomly generating resource names in samples

Fixes https://github.com/Azure/azure-sdk-for-net/issues/20659.
We were not generating names in our samples randomly, so we often got name conflicts because of tests running in parallel. Example in the issue linked above.

Because this only affects samples, consider running the live tests here too to make sure everything is passing as expected

I would like to do so, but in fact there are two major issues affecting live tests reliability, so I expect them to fail anyway. The other one is this one: https://github.com/Azure/azure-sdk-for-net/issues/20658, for which I already have a draft PR out. I'll run the tests pipeline there and assure both approaches work.


BLT leaves a dead process behind when the game is exited by ALT+F4

This didn't use to happen with old BLT. Basically whenever the game is exited by ALT+F4 the game leaves behind a dead 600mb ram usage process and it keeps the game running on Steam

I've noticed this as well. For now it's probably best just to go into Task Manager and kill the process.


make the tab title flash when there are new messages

like for gmail chat in the browser

I haven't been able to make it flash, but it now shows a 'badge' with the new message count.

Well, I've done all I believe can actually be done at the moment. If you have any other methods of making it 'flash' feel free to reopen the issue. xD


Update conda-store docs

Reference Issues or PRs
Closes #197

What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[x] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[ ] Did you test the pull request locally?
[ ] Did you add new tests?

Documentation

Access-centered content checklist
Text styling

[x] The content is written with plain language (where relevant).
[x] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
[x] All links describe where they link to (for example, check the Nebari website).
[x] This content adheres to the Nebari style guides.

Non-text content

[x] All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
[x] If there are emojis, there are not more than three in a row.
[x] Don't use flashing GIFs or videos.
[x] If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?
With the updates, this page may not belong in "tutorials".
Should be merged after #397 and https://github.com/conda-incubator/conda-store/pull/726

I will do a last passtrough here in will merge, thanks @pavithraes @kcpevey


help information in subcommand list

Hello, I'd like to know whether it's possible to show more detail in subcommand list, including args, options. e.g.
help      Displays help for command.

to
help <command>      Displays help for command.

Currently if you overwrite short_help when the option/arg is defined that will show up in the help for the command list, but its hard coded to be very brief currently.
There is a larger question of support for customizing formatting brought up in #513 but I'm not certain how long it will be before that is scoped out or released.
Feel free to reopen for further assistance


error

excuse me：I am a beginner, when I run thetrain_marta_gan.py , there is a mistake：
File "/media/mb/668452BE84529103/code/MARTA-GAN-master/network.py", line 43, in generator_simplified_api
padding='SAME', batch_size=batch_size, act=None, W_init=w_init, name='g/h1/decon2d')
File "/home/mb/.local/lib/python2.7/site-packages/tensorlayer/decorators/deprecated_alias.py", line 24, in wrapper
return f(*args, **kwargs)
TypeError: init() got an unexpected keyword argument 'batch_size'
Can you tell me what should i do

thank you，I've solved it

Hi!
excuse me: I meet the same promble. can you tell me what  I should do,please?


Automator: update ztunnel@master in istio/istio@master

Generated by Automator - 2023-07-08T14:40:21+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
54328d2d1bc02b0f9f9cd2e7a1e09811989b847d
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
69cb5ee0f4932f34719add6fe465528924fe8e11
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests-arm64


Polymer/Shadow DOM not playing nice with FastClick

I can add more steps to reproduce if you'd like, but for now I'll just report what I'm seeing.
I've created a polymer component which uses shadow dom. Clicking on an element inside the component opens a drop-down. With fast-click enabled on a mobile (or emulated) device the click/tap event doesn't fire, and the drop-down isn't opened.
I'm binding the event with the on-click attribute supported by polymer.
Disabling FastClick on my custom element is the work-around.

Perhaps the bug lies in Polymer? It does a lot of weird stuff to accomplish what it does.

I'm also running into this issue.  How did you manage to disable fastclick?  I've tried adding a needsclick to my select element, but the drop-down still doesn't get opened.

Sorry it's been a long time since I worked on this, and I forget exactly what I did to disable fastclick. Wish I could be more helpful.

No worries, thanks anyway :)


Module Fails to Initialize at new Session()

Description
Module fails to initialize when creating a new Session() object, raising an error related to undefined options.proxy.
Steps to Reproduce

Set up everything as described in the Getting Started guide.

Use the following code:
 import express from 'express';
 import { Session, ready } from<EMAIL_ADDRESS>
 // Ensure the library and dependencies are ready
 await ready;

 session = new Session();

Run the server:
bun run server.ts

The following error is produced:
$ bun run server.ts
28 |     }
29 | }
30 | export class BunNetwork {
31 |     proxy;
32 |     constructor(options) {
33 |         this.proxy = options.proxy && (typeof options.proxy === 'string'
                         ^
TypeError: undefined is not an object (evaluating 'options.proxy')
      at new BunNetwork (/home/user/Projects/session-bot-new/node_modules/@session.js/bun-network/dist/index.js:33:22)
      at new Session (/home/user/Projects/session-bot-new/node_modules/@session.js/client/dist/instance/index.js:46:32)
      at /home/user/Projects/session-bot-new/server.ts:18:11

Bun v1.1.26 (Linux x64)

Expected Behavior
The session should initialize successfully without any errors.
Actual Behavior
The initialization fails, throwing a TypeError: undefined is not an object (evaluating 'options.proxy').
Environment Details:

Node Manager: Bun v1.1.26 (Linux x64)
Module: @session.js/bun-network
File causing the error<EMAIL_ADDRESS>at line 33

Additional Notes

This issue seems to be related to the proxy configuration within the BunNetwork class.
Steps were followed exactly as per the Getting Started guide, and no additional proxy configuration was mentioned.

Possible Solution
It seems like the options object passed into the constructor of BunNetwork might be undefined, or the proxy property is missing. A check for the existence of options should likely be implemented here:
this.proxy = options?.proxy && (typeof options.proxy === 'string');

Thank you for looking into this issue!

Thank you for reporting that and for using session.js! I'm aware of this issue and it's because code expects options object in constructor to be present. Please for now just pass {} in argument as in new Session({})
I'm having troubles right now with money so I don't have time to work on session.js, but this will be definitely fixed in the urgent manner as soon as I come back to work on it. I'm sorry for inconvenience!

invoking new Session({});
didnt worked, same error.

Can you update @session.js/client to 0.0.47, try again and let me know if it now works?

hmm, same issue

ok, worked now!
thank you!

can you share your xmr address so i can tip you?

You can find it there: https://hloth.dev/donate
Thank you for support!

sent 40$


Lyrics are added for the songs

Lyrics are added to the existing songs.
I have verified that this is not a Breaking Change
https://user-images.githubusercontent.com/70525647/199005386-0da41fbf-77ff-457a-be79-54c00866fa62.mp4