Python 3 support

This pull request is big. Let me know if you prefer splitting it up and/or merging upon another branch. There is still some work to do, see comment in #40.
Sorry for my trailing whitespace deletion. Should have disabled that before.

Coverage increased (+0.46%) to 73.68% when pulling d6dfc048c845b95bef82517e7f057a3abd8a8bd9 on timtroendle:enhancement/python3-compatibility into 75aeac0b2a4eed702b5f53a93f6d4877bac1b397 on open-research:master.

Coverage increased (+0.44%) to 73.66% when pulling 56b1cfc138e6eb5b26e0d5213024b0b0184d6f77 on timtroendle:enhancement/python3-compatibility into 75aeac0b2a4eed702b5f53a93f6d4877bac1b397 on open-research:master.

Wow (a lot of) great work! To ease review is there a chance you could do
the following?

Import the sort of todo-list in #40 to a comment here, and clarify what
has and hasn't been done since you posted that comment?
if there are LOTS of trailing whitespace changes buried in here (I
haven't had a time to look), possibly rebase and use something like
http://stackoverflow.com/questions/3515597/git-add-only-non-whitespace-changes
to modify those commits where lots of whitespace is changed

I'll let @apdavison or @maxalbert speak to the overall merge strategy as
I'm a newcomer to the project.
On Sun, May 17, 2015 at 1:36 PM, Coveralls<EMAIL_ADDRESS>wrote:

[image: Coverage Status] https://coveralls.io/builds/2584321
Coverage increased (+0.44%) to 73.66% when pulling 56b1cfc
https://github.com/open-research/sumatra/commit/56b1cfc138e6eb5b26e0d5213024b0b0184d6f77
on timtroendle:enhancement/python3-compatibility into 75aeac0
https://github.com/open-research/sumatra/commit/75aeac0b2a4eed702b5f53a93f6d4877bac1b397
on open-research:master.
—
Reply to this email directly or view it on GitHub
https://github.com/open-research/sumatra/pull/242#issuecomment-102853015
.

There aren't so many trailing whitespace deletions, I don't think it's necessary to rebase for that.

This is great work @timtroendle Many thanks. I've reviewed about half the changes so far, I'll try to finish later this week, and I will also test this branch locally (Travis CI doesn't run the system tests at the moment, just the unit tests).

Good deal, and you've answered the questions in #40 so I think that
obviates my other suggestion -- sorry for the bother @timtroendle
The only remaining item is 'test extensively'. So, to be helpful I'll try
it this branch locally too
On Mon, May 18, 2015 at 12:41 PM, Andrew Davison<EMAIL_ADDRESS>wrote:

There aren't so many trailing whitespace deletions, I don't think it's
necessary to rebase for that.
—
Reply to this email directly or view it on GitHub
https://github.com/open-research/sumatra/pull/242#issuecomment-103186812
.

What's left is the consistent string handling. I'll try that locally and see how many changes that'll be. In case there are quite some changes upcoming, maybe we want to merge this branch first onto another branch than master and open another pull request for that, so that the changes of these new commits are clearer to distinguish.
For testing I'm trying this locally with Python3, Git and Python executables on a Mac (I learned that at least the ShelveRecordStore has quite some dependency on the system setup). That setup works fine as far as I can tell, but there are so many other setups possible. The more they are covered the better I assume. Python2 might still have problems at the moment due to the unresolved string handling.

I've added the string handling. To not disturb your review in this pull request, I put these changes on another branch. I opened up a pull request onto this branch here in my own fork. Let me know what you prefer. I can merge right away and you'd have all the changes here.

Yes please, can you merge everything so we have only a single PR to review.

Done.

Coverage increased (+0.66%) to 74.05% when pulling 58e01543980a00ea7e3dd8b7af48c9fcf8defb8f on timtroendle:enhancement/python3-compatibility into<PHONE_NUMBER>dce6afb2af091b294e0446a146ff50 on open-research:master.

I tested this out locally, and the unit tests all pass, but there were some failures in the system tests. To get test/system/test_ircr.py to pass, I:

added from future import standard_library; standard_library.install_aliases() to test_ircr.py
changed the file open modes from rb to r and wb to w in test_ircr.py and test/system/utils.py
added bytes to the list of types in parameters.py, lines 293 and 337.

I'm not sure the latter is the right solution, though.

I'll have a look at it. Am I right in the assumption that the only relevant system test is test/system/test_ircr.py? From travis.yaml this seems to be the only one executed.

The other tests in test/system/test_ircr.py require Docker, so can't be run on Travis. You can run them locally, though, if you have Docker (need to build the images first).

These changes are not enough to make the tests run on my machine unfortunately. Actually there are also failing tests on master -- less though. I'll have to spend more time on this.
If I make this to run I'll merge in the current master as well and fix any potential new problems. My feeling is we should merge this branch soon and make Travis run the tests with Py3, as every new change in the repo might need to be ported as well.

There is one last test failing that deals with the ShelveRecordStore. I wonder why this test did not fail before -- I thought I did not touch that part since. As no other dbm module seems to be installed on the Travis instance, it falls back to dumbdbm. Here is a quote from its documentation:

The dumbdbm module is intended as a last resort fallback for the anydbm module when no more robust module is available. The dumbdbm module is not written for speed and is not nearly as heavily used as the other database modules.

Unfortunately dumbdbm tries to adjust its behavior to its name and does a type(key) == type('') == type('value') comparison which fails with unicode. This is fixed in Py3 but remains an issue in Py2. Well we could simply skip that test when there is no real dbm module. But still, that means that running Sumatra with a ShelveRecordStore will crash on such machines.
Have to think about that tomorrow again. Any opinion from your sides on this?

Unfortunately dumbdbm tries to adjust its behavior to its name and does a type(key) == type('') == type('value') comparison which fails with unicode. This is fixed in Py3 but remains an issue in Py2. Well we could simply skip that test when there is no real dbm module. But still, that means that running Sumatra with a ShelveRecordStore will crash on such machines.

This sounds like a Python bug. Is there an issue on the Python bug tracker for this? Anyway, if it is a Python bug then any use of shelve or pickle with unicode will fail on such machines, so it's not a Sumatra-specific issue. Skipping the test in such situations seems like the right approach.

I wonder why this test did not fail before

This may be because I switched from using the system Python distribution on the Travis boxes to Miniconda (in order to be able to install recent versions of NumPy, etc. without compilation).

Ok, that took a while but I think I have it. The reason why only this one line failed was line 26 in shelve_store.py in which the Unicode string is transformed into a Py2 str. In the test, the shelve store is used directly though. I suppose this is not a use-case and hence the ShelveRecordStore should work on systems without ndbm.

This sounds like a Python bug. Is there an issue on the Python bug tracker for this? Anyway, if it is a Python bug then any use of shelve or pickle with unicode will fail on such machines, so it's not a Sumatra-specific issue. Skipping the test in such situations seems like the right approach.

It's not actually a bug, it just don't accept Unicode. With line 26 in shelve_store.py I think this is solved for Sumatra, isn't it?

This may be because I switched from using the system Python distribution on the Travis boxes to Miniconda (in order to be able to install recent versions of NumPy, etc. without compilation).

Right, I can reproduce that on my Linux machine.

My last commit was rather radical as I removed the whole unused and currently failing test setup of test_web. Let me know if that was too radical and you'd prefer keeping it for later.

Coverage increased (+0.63%) to 75.98% when pulling 4dbe6792cc39d2e03e6068cea21612745c03f289 on timtroendle:enhancement/python3-compatibility into f8dde556c2c8a55209eb04eea869a45ef30d729d on open-research:master.

It's ok to remove it in the interest of getting this PR merged, since it is not being used at the moment. I can always retrieve it from the repository history when I get round to reimplementing tests of the web browser interface.

Great! Glad to see that this worked out. I hope this will be of use for some people so that it was worth the effort ... ;-)
By the way, a good reference for continuing to keep the code base Py2/Py3 compatible can be found at the python-future project.

Thanks Tim!
- Jaime
On Fri, Jun 5, 2015 at 1:37 AM, Tim Tröndle<EMAIL_ADDRESS>wrote:

Great! Glad to see that this worked out. I hope this will be of use for some people so that it was worth the effort ... ;-)
By the way, a good reference for continuing to keep the code base Py2/Py3 compatible can be found at the python-future project.
Reply to this email directly or view it on GitHub:
https://github.com/open-research/sumatra/pull/242#issuecomment-109203968


[GLUTEN-2028][CH] Fix parseNameStruct error and refactor code related to collectStructFieldNames

What changes were proposed in this pull request?
(Fixes: #2028)

fix parseNameStruct error since there are some places where the schema does not include struct nested fields, e.g. StorageJoinBuilder.
refactor the code related to collectStructFieldNames, because the method is implemented in multi places (RelBuilder and BasicScanExecTransformer), I unify them  in ConverterUtils.

How was this patch tested?
unit tests

@rui-mo @lgbo-ustc @zzcclp Could you help review this pr? Thanks!

LGTM


effect adapter errors when using Schema from Effect

[X] Before posting an issue, read the FAQ and search the previous issues.

Description
effect adapter errors when using Schema directly from effect instead of @effect/schema. This is the recommended way of doing it since Effect 3.10
Argument of type 'Struct<{ name: typeof String$; }>' is not assignable to parameter of type 'AnySchema'.
  Property '[TypeId]' is missing in type 'Struct<{ name: typeof String$; }>' but required in type 'Schema<any, any, never>'.

If applicable, a MRE
https://www.sveltelab.dev/8utko5i2yydzzjo

Those eternal updates... I'll put it up for the next release.

Those eternal updates... I'll put it up for the next release.

Great! Appreciate it!

There are some breaking types in the 3.10 update that I cannot figure out. @szethh can you take a look at an update for the adapter, perhaps?

sure, i knew this was coming ahah 😅
right after we merged the adapter pr they combined Schema into the greater effect namespace.
will do this over the next week

Thanks, I'll make a Superforms release today, just so you'll be using the latest version. :)


bump github.com/envoyproxy/go-control-plane

What type of PR is this?
What this PR does / why we need it:
bump github.com/envoyproxy/go-control-plane
Replace github.com/golang/protobuf/ptypes with google.golang.org/protobuf/types
Which issue(s) this PR fixes:

Fixes #

This version appears to be mirrored from envoy main (pending 1.31). If we release EG 1.1.0 according to the current timeline (https://github.com/envoyproxy/gateway/milestone/20), It's possible that envoy 1.31 would not be released yet.
@envoyproxy/gateway-maintainers  - should we pin envoy images and go-control-plane version to 1.30, or can we continue using latest artifacts here?

Hi @mmorel-35  - TBH, I'm not sure what our policy should be here, we can keep this open an defer to other maintainers...

Hi @mmorel-35 . We discussed this in the community meeting, and decided that since we use latest envoy images, we should also use latest go-control-plane in main. When we cut an RC, we'll pin both component versions and deal with any incompatible feature. So, you can resume this activity.

/retest


Compiling SWF is much slower than FlashCC and FlashDevelop, can it be solved?

Which SDK are you using?

flex_sdk_4.6

Can you try adding -incremental=true to the "additionalOptions" in your asconfig.json file?
{
	"compilerOptions": {
	},
	"additionalOptions": "-incremental=true",
	"files": [
	]
}

Does that make a difference? Thanks!

You may need to compile more than once to see a difference.

I have added.This is my project.
_https://github.com/kingBook/baoWeiTianDianWangGuo_
You can download it and try to compile it.I tried to compile it over and over again, and it was still slow.
It doesn't detect file changes, skip the files that haven't been changed.

It seems likely that FlashDevelop is using the Flex Compiler Shell (fcsh):
https://help.adobe.com/en_US/flex/using/WS2db454920e96a9e51e63e3d11c0bf67670-7fcd.html
This makes the compiler faster by keeping it active in memory. However, it's also not supported by all ActionScript SDKs. It's something I can look into for a future version of the extension, though.

when will you support "fcsh", if this is ready , I can drop FlashBuilder !

@leefj I have some other priorities to finish for 1.0 first, but it's definitely on my list of things to investigate as soon as possible.

of course，I can wait , thanks !

@joshtynjala Three Months Passed! I wait this function for a long time.Can you implement it a bit ahead of time please

I did some investigation today, and I built a little prototype. I'm able to launch fcsh from VSCode, and I can make it compile incremental builds.
Due to limitations in VSCode, this feature will not be compatible with the regular "task" workflow that VSCode provides. Instead, the extension will provide a command that you can run from the Command Palette with Ctrl+Shift+P. As I understand it, you can assign a keyboard shortcut to any command in VSCode, so you have an option to make builds a little more convenient, if you prefer keyboard shortcuts.
The extension will provide another command that builds the project and launches a debug session at the same time. Since fcsh is activated by a command isntead of a task, it cannot be recognized as a preLaunchTask in launch.json.
Additionally, you'll need to use an SDK that actually includes fcsh. As I understand it, only the Adobe Flex SDK, the Apache Flex SDK, and the Feathers SDK include fcsh. The Adobe AIR SDK & Compiler and Apache Royale/FlexJS do not include fcsh or an equivalent.

Unfortunately, I hit a snag with integrating FCSH. Apparently, FCSH does not work with Java 1.8 or newer. The FlashDevelop folks have previously figured this out and documented it here: http://www.flashdevelop.org/wikidocs/index.php?title=Java
To use FCSH, you need to install Java 1.6 or 1.7. The ActionScript & MXML extension for Visual Studio Code requires at least Java 1.8. With that in mind, to be able to use FCSH inside Visual Studio Code, you'd be required to install multiple versions of Java. While that's certainly possible, I'd rather not make it a requirement to use this feature.
So it looks like FCSH will not be supported for the Adobe/Apache Flex SDKs. However, I'm going to investigate ways to keep the AIR SDK & Compiler in memory. This is the newer ASC 2.0 compiler, so it's a different codebase that may not have the same issue. Jeff Ward created ascsh to simulate the behavior of fcsh, but for the AIR SDK & Compiler. I will try to use that, if possible.

@joshtynjala in Moonshine we are using FCSH to build Flex applications. If it would not work I should not able to build project when I have installed Java 1.8 ? Am I understand above comment wrong ?

@ piotrzarzycki21 It looks like Moonshine kills the fcsh process and then starts it fresh before every build. The issue with Java 1.8 happens only when you reuse the existing fcsh process.
On a related note, this means that Moonshine is not doing fast incremental compiles. It's doing a full compile every time.


feat(bson): add COPY TO support for writing bson files

[x] wire up copy to bson
[ ] test copy to (file) functionality

I've done another pass at refactoring this with a couple of notable changes:

I pulled in some FileType handling code from datafusion, so that we could add an option to the enum, which fixed all the test failures. I'm inclined to think that we just sort of have to do this sometimes (datafusion isn't going to want to support all the random things we do), and this is pretty inoffensive.
pulled out the RecordBatch -> bson document converter/iterator.
wired up COPY TO and left the read/write from file stuff on its own.

My inclination is to do some course testing of the copy to (which in this mode functions like an export) as a start.
I could (relatively easily) add "read bson file into memory and have a memory-table" read_bson function, but I think it's not that much harder (and more useful generally) to write the functions for the scanning, which is probably copying and tweaking some JSON handling code and doing s/j/b/ and a few other tweaks.
I'm going to retitle this to "add COPY TO bson" support, and I think we should merge it, and I'll do the object_store (scanning) thing, in another PR.

I think COPY TO makes sense first. That's typically the hardest/most tedious part, so once that's done, the rest should fall into place pretty easily.

I think COPY TO makes sense first. That's typically the hardest/most tedious part, so once that's done, the rest should fall into place pretty easily.

Definitely the easiest in terms of "this code is isolated from other code" and sufficiently abstract. The integration with object_store is the hard part, I think, as we discussed in the out-of-band conversation.

👀
FAILED tests/tests/test_bson.py::test_copy_to - psycopg2.errors.InternalError_: internal error: unsupported output format: bson


FEATURE REQUEST - Add Version Flag

To help the users when building and utilizing ZSSH, it would be nice to have a --version/-v/version flag at runtime which returned the current version, architecture, and build method.

closed with #44


⚠ Bofrost.fr has degraded performance

In 32a99e6, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 845 ms

Resolved: Bofrost.fr performance has improved in d368151 after 7 minutes.


does it have registration wizard functionality?

does this package has wizard registration capability? I mean user first insert required fields like email / username / password then he hits the NEXT button and a new page asks him for additional data (example sex / age / whatever) at this point when everything is filled the user submits the registration, the package so inserts the first data into users table and the details of the second page in a user_datas table or something. Is it possible with this?

No it doesn't sorry.


check-requirements fail on vanilla debian 10 due to python version

Package version (if known): 0.20.
Describe the bug
invenio-cli check-requirements fails on a vanilla Debian 10 when trying to determine the Python version.
Steps to Reproduce
vagrant init debian/buster64
vagrant up
vagrant ssh

sudo apt update
sudo apt -y upgrade
sudo apt install -y python3-dev python3-pip
sudo apt install
export PATH=/home/vagrant/.local/bin:$PATH
pip3 install invenio-cli
invenio-cli check-requirements

Additional context
Checking Python version...
Traceback (most recent call last):
  File "/home/vagrant/.local/bin/invenio-cli", line 10, in <module>
    sys.exit(invenio_cli())
  File "/home/vagrant/.local/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/vagrant/.local/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/vagrant/.local/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/vagrant/.local/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/vagrant/.local/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/vagrant/.local/lib/python3.7/site-packages/invenio_cli/cli/cli.py", line 53, in check_requirements
    run_steps(steps, on_fail, on_success)
  File "/home/vagrant/.local/lib/python3.7/site-packages/invenio_cli/cli/utils.py", line 22, in run_steps
    result = test.execute()
  File "/home/vagrant/.local/lib/python3.7/site-packages/invenio_cli/commands/steps.py", line 27, in execute
    return self.func(**self.args)
  File "/home/vagrant/.local/lib/python3.7/site-packages/invenio_cli/commands/requirements.py", line 78, in check_python_version
    version = cls._version_from_string(result.output.strip())
  File "/home/vagrant/.local/lib/python3.7/site-packages/invenio_cli/commands/requirements.py", line 24, in _version_from_string
    return groups.group(0)
AttributeError: 'NoneType' object has no attribute 'group'

It looks like Debian 10 has python symlinked to python2, which apparently prints the version info (python --version) to stderr instead of stdout


BFE published data set not Loading

Describe the bug
I have just published a new productive LD data set and wanted to display it on visualize.
Unfortunately visualize loads and loads but nothing happens
https://visualize.admin.ch/it/browse/dataset/https%3A%2F%2Fenergy.ld.admin.ch%2Fsfoe%2Fbfe_ogd56_energieperspectives2050%2F1?previous={"type"%3A"organization" %2C%22iri%22%3A%22https%3A%2F%2Fregister.ld.admin.ch%2Fopendataswiss%2Forg%2Fbundesamt-fur-energie-bfe%22%2C%22includeDrafts%22%3Afalse%7D
I can't really debug because visualize doesn't return any error that I can see and everything worked fine with the cobe-creator
(source: email from Ambrogio Foletti on 01.02.2022)
To Reproduce
Steps to reproduce the behavior:

Go to: https://visualize.admin.ch/it/browse/dataset/https%3A%2F%2Fenergy.ld.admin.ch%2Fsfoe%2Fbfe_ogd56_energieperspectives2050%2F1?previous={"type"%3A"organization" %2C%22iri%22%3A%22https%3A%2F%2Fregister.ld.admin.ch%2Fopendataswiss%2Forg%2Fbundesamt-fur-energie-bfe%22%2C%22includeDrafts%22%3Afalse%7D
Data does not load as expected

Expected behavior
The data should load to allow the user to create a visualization
Screenshots

Environment (please complete the following information):

Visualize environment and version:PROD
Browser and version Chrome

Additional context
Add any other context about the problem here.

Hi @sosiology, a https://energy.ld.admin.ch/sfoe/bfe_ogd56_energieperspektiven2050/KKWLaufzeit dimension is a TemporalDimension, but does not implement a timeFormat property, which should never be empty - that's why the dataset is not being loaded.

Above was the case for a moment, but it is not anymore. It turned out there is another issue which prevents the data loading - and it's due to a fact that by dimensions with more than 100 values don't have these values attached by default anymore and we have to fetch them in some other way.
I checked and we implemented this on December 11, while the current PROD environment was deployed on December 7 - so this will be fixed once we deploy to PROD (also, it currently works on TEST environment).
Let me know if there is anything else to support with @sosiology.

Thanks for the input @bprusinowski. If i understand correctly, we can only fix the issue once we deploy to PROD (whenever that is - tbd) but it should work on TEST if the BFE person wants to try it out.
I guess my main question is: If Zazuko removes the 100 values limit - would it work on PROD then? if so I would push the issue back to Michael to adjust on their side

Exactly, once we deploy to PROD it will be fixed - also, currently it works on TEST (just tested).
When it comes to 100 values limit, I am confident that this should be a workaround until we deploy to PROD, as Michael suggested this in the past already.
When I checked the column in question, it has 120 values, so 150 or 200 as a new limit should do fine.

Asked the client if it is okay to share the link to the test environment with the user who provided the feedback.

Informed user to check / test data set on TEST Environment. If we don't get any feedback in the next week, i will close the issue.

Hello there. BFE Data publisher here. Sorry for the late answer but I was not really aware of this repo.
Anyways, the problem is fixed (checked on INT) and this ticked can in my opinion be closed.
Thanks for your work!

Thanks @AFoletti !

LGTM 👍

But it takes quite long to load


Frontend web development react angular vue

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # 621

Type of change 📝

[ ] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[ ] Frontend Dev React/Angular/Vue

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[ ] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

@SourabhSaraswat-191939  @anandhu720  pls review this PR

@Techno-Simpola,
There are some changes required.

There is no need to mention what is vue.js and its installation. Because that is already covered before Vue components, you can see the roadmap for this. So you can remove that part.
You should add more explanation of code and theory. Because beginners cannot understand code directly.
Also show the output of your code.
etc. (try to improve it)

After doing all that changes. Ping a msg on the discord group with the link of your PR. So that I can review it as soon as possible.


Add more docs

At this point, I'm just writing down stuff I've made notes of (both mental, and tangible), so I'm not really particular about having things organized the way they are currently (or even having all this content finally make it into the docs for that matter).

Codecov Report

Merging #96 (a25205f) into main (99618bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   85.28%   85.28%
=======================================
  Files          12       12
  Lines         299      299
=======================================
  Hits          255      255
  Misses         44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99618bc...a25205f. Read the comment docs.

@thazhemadam there are probably still things we could add in docs but I'm fine with merging this nowish, especially since there have been a couple people expressing interest in the package after JuliaCon, so having the tutorial up would be good.
Thoughts?

I think this resolves #3

I agree. I think atm there's enough content in the docs to get things up and running.
We can always open up a new PR anyways when we want to add more content. Merging this PR.


[Feature Request] Embed Template Editor

By reducing the template designer sidebar width, the editor can be embedded while still working for HD screens.

Released with 2.21.0


Unlimited scenes

-Unlimited number of drawables
-Unlimited number of octree nodes

Can you put catwoman back please :laughing: ?

Done!

Yeah !!!


Add new rules from ktlint 1.2

New rules:

BackingPropertyNaming
BlankLineBetweenWhenConditions
KDoc
SpacingAroundSquareBrackets

Warnings

:warning:
It looks like this PR contains functional changes without a corresponding test.

  Generated by :no_entry_sign: dangerJS against 0efe17b62e53adcdb3cdf84fd084cbe7ff455c59

Additional question: do we backport new ktlint rules to the v1.x branch?

I'd say not as 1.x is stuck at KtLint 0.50.0

Agreed, makes no sense. Value gained is too low for making such a version bump.

I'd say not as 1.x is stuck at KtLint 0.50.0


Storage Account for Recovery Vault

My understanding is Storage Account is necessary in the Resource Group to setup a Recovery Vault. This step is not mentioned here. What is correct?
If Storage Account  is not needed then where does the Recovery Vault reside?
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8621ec19-98d2-d173-09f6-f8e26f769dd4
Version Independent ID: e85e619c-4ec7-34cb-9620-2b725712d858
Content: Prepare Azure for disaster recovery of on-premises machines with Azure Site Recovery
Content Source: articles/site-recovery/tutorial-prepare-azure.md
Service: site-recovery
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

Hi @Sam-SFO, you are correct. A storage account is required. The step isn't mentioned in the article because the Recovery Services Vault and Backup Services take care of this behind the scenes.
Reference here.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


CVRhsFn_wrapper unsafe use of @cfunction($f, ...)

See eg CVRhsFn_wrapper:
https://github.com/SciML/Sundials.jl/blob/64c98c838f811b8b4c05dbd67a85df64acf0b434/src/types_and_consts_additions.jl#L9-L10
which is used in
https://github.com/SciML/Sundials.jl/blob/64c98c838f811b8b4c05dbd67a85df64acf0b434/lib/libsundials_api.jl#L1668-L1671
The problem is that a temporary Base.CFunction closure is returned by @cfunction($f, ...), which may be garbage collected so it is not safe to return the enclosed pointer (somewhat similar to the problem with NVector addressed by https://github.com/SciML/Sundials.jl/pull/380, but more fundamental as the RHS function needs to persist for the whole lifetime of the solver use).
Suggested fix is to remove CVRhsFn_wrapper (which is only used by a few tests of the low-level interface), and require that the caller either uses the @cfunction(f, ...) form to generate a C pointer (ie f known at compile time and the runtime Julia RHS function passed in to Sundials C code as part of the opaque user data, this is what the high-level interface does), or manages the lifetime of the @cfunction explicitly.
Addressed by PR https://github.com/SciML/Sundials.jl/pull/384

Fixed thanks. I wonder if this will end up fixing the ability to use Sundials' sensitivity analysis stuff too. It would be interesting to try and get https://github.com/SciML/Sundials.jl/blob/master/test/cvodes_dns.jl up and running


Google-exclude List too long to save in google analytics

As suggested in the readme, I've tried to create a segment with google-exclude.txt list as a regex expression. The rule could not be saved. With half of the list, it has worked perfectly.
Expected Behavior
It should be possible to copy paste the regex expression and save it.
Possible Solution
The Regex-Expression should not exceed 30'000 character for a segment, as stated by Arnold M here (https://www.en.advertisercommunity.com/t5/Google-Analytics-Referral-Spam/advanced-segment-maximum-length-for-regular-expressions/td-p/504007).
Verify if this is the case and shorten the regex expression either by less urls or more general regex expressions.

Hi @daugsbi, thanks for your bug report. I think I wouldn't be able to write a regex to cover all the URL's and still be within the 30'000 characters. What could work is to check if the URLs in the spam list still exist and only add the active spammers. The only downside with this is that the Google Analytics exclude list will work with spam from way back.. So what would you suggest?

It's possible to create two segments to filter spam and use both of them (up to four segments can be applied, so still 2 available to combine individual segments). You could split the addresses beginning with 0-L and M-Z and reflect this change in the readme.

Hi @daugsbi, I've added a method to create two segments, can you verify if it works? Still have to write some code to be sure it will still work if we hit the 60.000+ .. we are now on 48.000+  I'll update the readme if it works! ;-)

@Gamesh Could you please take a look at the newly added Google Analytics segment exclude code?

@Stevie-Ray yeah, sure

at first glance what i can tell strrpos() has a third argument offset line 226 so substr() could be omitted. Other than that good job 👍
by the way all these string functions are not multi-byte safe (only mb_* are), so can't be used on Unicode domains, good thing you decode them before that.
We should create an optimizer pass, that would reduce the number of lines in the blacklist. One thing that comes to mind is we could search for all domains that have the same beginning. For example 4webmasters.com and 4webmasters.org would become:
4webmasters\.com|\.org
that would save some space with the cost of one additional iteration.

Tried your new php code for splitting up the google-exclude files. I threw a list of 120000+ at it and it does not work creating a third or 4th file. Creation of File1 is good, second file does not end at 30,000 characters and also breaks the input leaving an incomplete domain name. Goes onto create file3 which then is also broken output.

@Gamesh  wouldn't a 4webmaster(\.*) cover all possible extensions?

@Ubuntu101 yes it would, but no one knows if for example .net is a legit domain which we don't want to block blindly, that would defeat the purpose of blacklist.
the code does not create the third or fourth files, it's not written to do that currently. i'll look into it if @Stevie-Ray didn't already start writing this code.
But the problem remains as the blacklist grows it will still hit the maximum limit, we can only delay it by spiting into multiple files and optimizing our regex patterns to match more with less.

Hope you can figure out the file splitting, I've been messing with it myself but I'm not the greatest at PHP coding 😬 I think it's still the safest way to split them up into equal chunks. Look forward to seeing if you get it right.

hi @daugsbi, @Gamesh & @Ubuntu101. I did my best to rewrite the code. It generates the same files as before but the exclude script should now be able to fill a *-exclude-3 -exclude-4 with data. Feel free to do a pull request 👍  🔥  Also the multi-byte safe is new to me i've added a russian domain converter in the past but I don't understand what the mb_ functions do.. Thanks for your feedback!

Thanks @Stevie-Ray tried the new code this morning, does the same thing. When it hits the second file it starts falling apart but creates part1 perfectly, part 2 is oversized and cuts off at an incomplete domain name, then part 3 contains data already in part 2 but correctly sized but also beings with a cut off domain name.

@daugsbi PR solves this 100% https://github.com/Stevie-Ray/referrer-spam-blocker/pull/113 tested and working like a charm. Well done @daugsbi 👍

@daugsbi i've murged your code from PR #113 ..thanks man! and also @Ubuntu101 thank you for testing the script so we can confirm it works!


How long does it take for an activity policy to be active?

Hello,
in a service request we had some issue with activity policies. The activity policy was set to monitor on Log On activity in Azure or Office 365 and it took some time until alerts were raised. So how long does it take after creation/saving of the policy to become active, e. g. sending out email notifications?
I also noticed two asterisks (**) in the article. This should be fixed as it's either broken formatting or a missing footnote.
Thank you!
Best Regards,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 66e4554f-32d3-6166-0fb4-f7382d063ef6
Version Independent ID: de6a662e-0676-3e47-1321-5b6e14a54b14
Content: Create policies to control activities in Cloud App Security
Content Source: CloudAppSecurityDocs/user-activity-policies.md
Service: cloud-app-security
GitHub Login: @shsagir
Microsoft Alias: shsagir

@GiantCrocodile  Thanks for contacting Microsoft with feedback about our product documentation. Depending on the complexity, it could take from a few business days to a few weeks to look further into your question, issue, or suggestion. We'll contact you if we need further information, and you'll receive an email message each time we "@mention" you in a comment.
Thanks for the feedback regarding the asterisks. We've submitted a documentation change based on your suggestion, and the updated article should be live by tomorrow.
Thanks again for submitting your feedback. Your suggestions help improve our documentation.

@GiantCrocodile Thanks again for your feedback. After investigating, we've discovered that there isn't a specified time for how long it takes for activities to appear. Having said that, activity policies usually trigger in near real-time (or within a few minutes of an event), when the relevant activities become available to Cloud App Security.

@shsagir I'm not sure we talk about the same: The policy was created and thus active. New activities were logged. Still, the policy wasn't triggered at that time. We suspect a policy is instantly activated but until it can be triggered, it takes some time (hours).


[Power BI] Create an Inventory page in the Cost summary report

📝 Scenario
As a DevOps team/leadership, I need to understand how many resources are deployed by type in order to <TODO: What is the goal? Why is this needed?>
⭐ This is a requested feature, but we could use more context on how and why it would be used. Please leave comments.
💎 Solution
Create an Inventory page that provides a breakdown by resource type.
ℹ Additional context
Consider writing a proposal to offer a built-in view inside of Cost Management for the same, if applicable.

This is available in 0.4. If you have any specific requests to add to the inventory page, please let us know. I could imagine a lot in this space that may even warrant its own dedicated report.


Fix local_service_name leak in ebpf_native_load

Description
ebpf_native_load allocates local_service_name, which eventually gets freed by the cleanup_workitem. However, if we fail to allocate the cleanup_workitem, then local_service_name leaks.
Manually free local_service_name if we fail before the cleanup_workitem can be allocated.
Testing
Tested in XDP stress test. Other eBPF issues are still being hit, but this one seems fixed.
Documentation
N/A.

Note:
This should be covered by systematic low-memory testing in kernel mode, when we get that working.
Alternatively, we can look into combining systematic low memory testing and leak detection in our user mode framework.


PyTuple: use fast macros on !abi3

They were already defined, but not used so far.  For abi3 they now forward
to the C functions.
Question: should these be defined at all for abi3, or should I add the conditional code in the PyTuple impl?

It looks like these macros are only defined in https://github.com/python/cpython/blob/main/Include/cpython/tupleobject.h, i.e. for the unlimited abi.
So I'd vote for doing the same for our ffi module - only define these macros for the unlimited abi and write the conditional code inside our tuple code.
If there's lots of places in the code where this happens, can always add tiny #[inline] pub(crate) fn pytuple_set_item helpers which are defined differently for each #[cfg] and call to the relevant ffi function.

So far, these were each only used in one place, so I went and added the conditional there.


Test lowest version constraints

Follow-up of #101 and #111.
See https://travis-ci.org/andig/http/builds/200662157 for sample output. It already shows that ringcentral:1.0 is broken. https://travis-ci.org/andig/http/jobs/200662167 shows some additional errors that should be investigated once ringcentral/psr7 is upgraded to 1.2.
Note: this doubles the build matrix

Doubling is a wee bit much tbh. This adds only one build:
env:
  - DEPENDENCIES=default

matrix:
  include:
    - php: 7.0
      env:
        - DEPENDENCIES=lowest

Then for the sake of it lets to the same for the lowest supported version 5.3, too?

What confuses me now is that on php 5.3 composer picks ringcentral/psr7:1.2 while on php 7.0 it chooses 1.0?

ringcentral/psr7:1.0 requires php: >=5.4.0 (thats why it can be picked by the PHP7 build), since ringcentral/psr7:1.2 it has been lowered to >=5.3, so that's the lowest version the PHP5.3 build can pick.

Then something else is broken in the 7.0 build.
$ ./vendor/bin/phpunit --coverage-text
PHPUnit v0.4.3-14-g8d2e2c9 by Sebastian Bergmann and contributors.

Since phpunit 4.0 is installed that might have been bogus- the version number definitely looks borked.

I'd like to look into getting the release out :shipit: What is the status here? Do you think this PR is still needed?
IMHO we don't really need this, but I see no harm in adding this anyway if you feel that this adds value. :+1:
Technically, each and every minor version of our dependencies could have introduced breaking changes, but I rarely see this being an actual issue and the latest version is regularly tested via CI. Also testing the lowest supported version adds some value, but ultimately if we'd want to be 100% sure we'd have to test every possible combination of our dependencies :-)

The issue was at least obvious with ringphp and it shouldn't harm. Imho this pr is ready.
Viele Grüße,
Andreas

Am 13.02.2017 um 09:06 schrieb Christian Lück<EMAIL_ADDRESS>I'd like to look into getting the release out  What is the status here? Do you think this PR is still needed?
IMHO we don't really need this, but I see no harm in adding this anyway if you feel that this adds value. 👍
Technically, each and every minor version of our dependencies could have introduced breaking changes, but I rarely see this being an actual issue and the latest version is regularly tested via CI. Also testing the lowest supported version adds some value, but ultimately if we'd want to be 100% sure we'd have to test every possible combination of our dependencies :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Will do, but to learn something: why is this necessary? Targeting different files here?

Will do, but to learn something: why is this necessary?

The branch behind this PR is based on an older version of the master branch, one which did not specify the proper minimum version requirements. Hence, trying to test minimum versions on this branch does current fail, see e.g. Travis.
In the meantime, the master branch has been updated and we now specify proper minimum version requirements (#113 and #115). However, we do not currently run any tests on the master branch for older versions (and it's debatable whether this is needed in the first place).
If you rebase this branch on the current master, then this branch will use the proper minimum version requirements.
If we were to accept this PR now without rebasing on master first, then we risk accepting a PR that does technically not build currently, but will will build once it's merged.
I hope this helps :+1:

If we were to accept this PR now without rebasing on master first, then we risk accepting a PR that does technically not build currently, but will will build once it's merged.

Actually, I was assuming that retriggering the travis build (which anybody with sufficient privileges can) would  apply it to current master and then test to get valid results. As said, really no problem and will do asap once I'm back at the machine.

Thanks for keeping this updated! :+1:

retriggering the travis build (which anybody with sufficient privileges can do but not me) would apply it to current master

This may be true from a practical (sane!) view point :-) I'm tempted to disagree from a theoretical view point, but I'm not really that much into discussing theoretical aspects of this, so I appreciate you've rebased this on current master already, which I still believe is the cleanest way of addressing this :-)

Awesome, thank you 👍


Rename index.md to README.md

If you browse documentation from GitHub it makes more sense.

There's an effort underway to re-work the documentation. So I'd like to hold off on a rename. The docs team is trying to take the contents of this directory and turn it into a Hugo site. We're sorta waiting for some guidance from that team about how things will need to be structured. But my understanding is that index.md becomes the index.html for that site.
That said, I think it would be fine (and useful) to add a README.md that provided some generic info and pointed to the index. Then we can adjust accordingly as things progress.

Related to #2501

Having a README makes sense for easier viewing on Github - I tested and this won't impact on the Hugo site at all, so this is a win-win.

Okay. Merging it, then.


Remove ExternalDNS contour ingress workaround

Due to a long standing upstream issue of Contour (projectcontour/contour#403), we had to introduce a workaround for External DNS creating DNS entries.
Since the upstream issue has been resolved and released in the latest version of Contour, we should address the same in Lokomotive and find a graceful way to remove the workaround to avoid any breaking change.

@ipochi can I work on this issue?

@knrt10 Yes, please go ahead !!! Let me know if you have any questions :)


MI300 Onnxrt EP Changes

Get MI300 runs working with MIGraphX.
Similar to bringup with Navi3x using the DLM repo to run through a bunch of tests
Will be in tandem with #2078

still waiting on changes to Onnxruntime to compile for MI300

Looks like there's a workaround for this. Moving this and #2078 to in progress


Automated cherry pick of #1596: 私有云或公有云镜像windows默认用户名都是Administrator

Cherry pick of #1596 on release/2.10.0.
#1596: 私有云或公有云镜像windows默认用户名都是Administrator

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@f3e6aca). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1598   +/-   ##
================================================
  Coverage                  ?   7.72%
================================================
  Files                     ?     409
  Lines                     ?   62372
  Branches                  ?       0
================================================
  Hits                      ?    4816
  Misses                    ?   57147
  Partials                  ?     409

Flag
Coverage Δ

#aFlag
7.72% <0%> (?)

Impacted Files
Coverage Δ

pkg/compute/guestdrivers/aliyun.go
5.68% <0%> (ø)

pkg/compute/guestdrivers/base.go
0% <0%> (ø)

pkg/compute/guestdrivers/huawei.go
9.61% <0%> (ø)

pkg/compute/guestdrivers/qcloud.go
5.31% <0%> (ø)

pkg/compute/guestdrivers/zstack.go
7.46% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e6aca...2cac700. Read the comment docs.

/lgtm
/approve


Reproduce results in the paper

Hi
I am trying to reproduce the results in the paper.
Running the current version of the code for PTB dataset gives 55.75 and 53.43 PPW for validation and test dataset respectively (without fine-tune).
This is almost 0.5~1.0 PPW higher compared to the results in Table 7 in the paper.
I ran the command to train as provided in the README.md
Can you pleas provide the settings used so as to reproduce the results in the paper.
Thanks

Table 7 indicates fine-tuned results.
So, if you try fine-tuning, you probably obtain similar scores in the paper (in PTB, valid: 54.62, test: 52.87).
Would you try to apply finetune.py to the trained model?
#At first training step, I think your result is similar to ours.
#In PTB, we achieved valid: 55.45, test: 53.44 with GTX1080Ti, and valid: 55.21, test: 53.44 with P100.

I thought that the results mentioned in table 7 are with and without fine-tuning.
I will do fine-tuning to the model to match your results.
Thanks for the explanation.


"Oncești" commune is listed in the drop-down menu

Description:
The commune is listed in the drop-down menu according to the law
Preconditions :the website (https://peviitor-ro.github.io/ui.orase/) is up and runing.
After every step delete the text you typed from the search bar.

Step 1
Type "Oncești" in the search bar.
Expected results
The location is listed in the drop-down menu as "Oncești, Bacău"


scripts: reana initialisation doesn't follow docs

Split https://github.com/reanahub/reana/blob/master/scripts/reana#L103-L111 into the instructions described here

See also https://github.com/reanahub/reana/issues/34


Fix line number positioning

This PR uses a recent Monomer update that fixes, without workarounds, the issue with glyph positions differing between calculations and rendering. The update also includes a new attribute in GlyphPos, called x, that should be used when rendering glyphs manually; the minX attribute should not be used for rendering, only for calculating bounding boxes.
The difference in line number position is caused by the descending of the font not being considered.
~Note: the commit hash will no longer be valid after the PR is merged.~
Note: the commit hash now points to main; the is no need to update it.

Looks great!
Thanks @fjvallarino


Corrupted data (columns) in Google Spreadsheet

There are corrupted data (columns) on all tabs in Google Spreadsheet except 'Original' tab
Example of corrupted data (column's names) on the 'Destroyed' tab:
Russia_Losses_excluding_Recon_Drones_and_Trucks_-_13640,_of_which:_destroyed:_9785,_damaged:_683,_abandoned:_951,_captured:2221	Russia_Losses_excluding_Recon_Drones_and_Trucks-_13682,_of_which:_destroyed:_9822,_damaged:_684,_abandoned:_954,_captured:2222	Russia_Losses_excluding_Recon_Drones_and_Trucks-_13714,_of_which:_destroyed:_9852,_damaged:_685,_abandoned:_955,_captured:_2222

ref: https://docs.google.com/spreadsheets/d/1bngHbR0YPS7XH1oSA1VxoL4R34z60SJcR3NxguZM9GI

May need to loop in @scarnecchia on this one. Her repo is the main way I scrape data from the Oryx site, though with some mods. Will look into it, thank you for flagging.

I think I've got it fixed. What happened was this: Oryx (really Jakub) began to include a count of losses which removed some drone types. However, because this number changed every day, it led to column multiplication, since mine is a daily tracker. The good news is that this continual duplication never impacted the numbers after I switched to name-based rather than positional-based tabulations in the sheet. The bad news is that the duplication was leading to steadily longer processing times and putting strain on the server.
I am going to close for now, but please comment here if you see it again. I had to add a "if the column begins with these characters" qualifier, so it can show up again if the name changes on the Oryx site.


Request: add support for dotlottie

Support dotLottie file format :
Since both lottie-ios and lottie-android now support .lottie files, maybe now is a good time add support for dotlottie?
https://github.com/airbnb/lottie-ios/pull/1785
add support for dotLottie  airbnb/lottie-android#1660

+1, smaller dotlottie files help a lot in reducing RN bundle size.

+1

+1


Can we include the python 2 and python 3 artifacts in the same pypi release?

As part of launching, I tested if I could put py2 and py3 artifacts into the same pypi version (e.g. just cirq 0.3.1 instead of cirq <IP_ADDRESS> and cirq <IP_ADDRESS>), but my quick test indicated that pypi was pretending only the python 2 version was available when I did so. So I put them in separate versions just to be sure it would work.
But there's no way that's actually how it works, right? Surely there's a way to get both the py2 and py3 code into one version distribution? Did I just mess up my quick test, and including the artifacts in the same package actually just works? Does someone know offhand how this works, or a site that explains the details of doing this?

@Strilanc Just wondering; why is this project supporting Python 2?  I'm asking because most programs have been phasing out their Python 2 support lately.

@vtomole There are two reasons:

A non-negligible number of people are still using it.
We came up with a low-cost way to support it.

The low-cost way to support it is by using a transpiler. This is very common in the javascript ecosystem, e.g. babel will take your ES6 code and transpile it down to ES5, and so it is very easy to use new features while maintaining compatibility.
When compared to babel and traceur and such, python has terrible transpilers. But 3to2 is good enough that, with a few additional tweaks, you can just write python 3 code and have it automatically work in python 2. There are still gotchas (e.g. using the default parameter of max, using non-indexed format string arguments to a custom string formatter, probably anything to do with async methods), but they are negligible compared to the costs of writing code that must run in both languages.

https://stackoverflow.com/questions/40114100/uploading-different-versions-python-2-7-vs-3-5-to-pypi
Think you have to do different versions?

Using separate version numbers for the packages is what I did last time. I want to put them both in the same package with the same version.
... I think. My plan for this issue is to just experiment with the testing pypi when it comes near release time.


Add AstraDB document loader

Description: this adds the AstraDB document loader and an integration test
Twitter handle: cbornet_

@hemidactylus can you please take a look ?

Added support for sort option.


Configure trusted key store per client

Fixes #47.

Especially how to generate a keystore.

I can offer to write a linux-specific paragraph. Should be sufficient, right?

Should be sufficient, right?

Absolutely

I looked, but haven't found any simple solution... any idea?

Most likely not worth the effort. Using github is fine, imo.

:+1:


Fix aliasing in syscalls

Problem
Some read-only and mutable references may alias each other in the same scope.
This theoretically breaks Rust's aliasing assumptions, although practically not an issue.
Summary of Changes
Improve lexical scoping such that read-only references go out of scope before a writable reference is created. This ensures that no unsound aliasing occurs.
Fixes #

Note: This PR is much easier to review when hiding whitespace changes: https://github.com/anza-xyz/agave/pull/2454/files?diff=unified&w=1

Can you split out the changes where you buffer things with explicit deref cloning into a separate PR and only have the scope changes in this one?


CLIMATE-719 - Subsetting model data on curvillinear grids in the configurationfile runner

run_RCMES.py is using ocw.dataset_processor.temporal_slice to slice temporal boundaries in model datasets on curvillinear grids

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Failed.


copr: Add vectorize week_with_mode

Signed-off-by: Poytr1<EMAIL_ADDRESS>PCP #5751

What have you changed?
Vectorize week_with_mode
What is the type of the changes?

Improvement (a change which is an improvement to an existing feature)

How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No
Does this PR affect tidb-ansible?

No

Close this and open a new one for it: https://github.com/tikv/tikv/pull/6646


feat(UniversalRoutes): Stop overwriting the (maybe) customized onFail…

With this change we still can customize the onFail method of the middleware and use the UniversalRoutes feature.

@stancl No comment on this one?

Codecov Report

Merging #679 (8fb3eb0) into 3.x (1a5300a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.x     #679      +/-   ##
============================================
- Coverage     87.02%   87.01%   -0.02%
  Complexity      372      372
============================================
  Files           103      103
  Lines          1102     1101       -1
============================================
- Hits            959      958       -1
  Misses          143      143

Impacted Files
Coverage Δ

src/Features/UniversalRoutes.php
93.33% <100.00%> (+0.47%)
:arrow_up:

src/Commands/Run.php
100.00% <0.00%> (ø)

src/Listeners/UpdateSyncedResource.php
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5300a...8fb3eb0. Read the comment docs.

Regarding this review, you are right. See my comment on the review.
So, resolved the mentioned review and also added a test. Now it throws a correct exception when $originalOnFail() is null instead of the generic Value of type null is not callable error.

The solution looks good. Regarding the test, I'd come up with a better name, the current one is long and a bit hard to understand.
Also, I'm thinking that I'll merge the pest PR first and then you can edit this to be a pest test.

You can now adjust the DomainTest to use pest

You can now adjust the DomainTest to use pest

Done.

I'd come up with a better name, the current one is long and a bit hard to understand.

I've renamed the test to throw correct exception when onFail is null and universal route is enabled.

Is this ready to be merged now?

Is this ready to be merged now?

Yes. I don't see any reviews/comments to resolve.


Fix flake8 warnings & errors

Clean up the code a bit (mostly standard PyCharm fixes). Changes are generally for style, little functional changes:

Remove unused imports and reorder them.
Fix indentation.
Remove trailing whitespaces.
Fix whitespace around operators.
Fix some of the line lengths.
Fix some of the commented-out code.

This PR reduces flake8's total number of warnings & errors from 578 to 130.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: hgrif sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for these edits. Accepting the changes.


Page for environment variables

It would be nice to have a page for what environment variables to use. Right now, the nvidia page has some:https://github.com/hyprwm/hyprland-wiki/blob/e32263da788af80acb43cb7ba1d6b5dcb188899c/pages/Nvidia/_index.md?plain=1#L26-L36
...but not all of these env variables are related to nvidia.

Maybe some of those could be moved to the example wrapper section, as the NVIDIA article already links back to it. Potentially, a "final result" example (w/ both NVIDIA and other misc envvars in it) can be attached at the end of the relevant NVIDIA section.


When long press input textview UI wink.

when magnifier popup this bug will happen
Please see the video : (please seek to second : 0.52)
https://drive.google.com/a/thai-g.com/file/d/0B_A5FPAMZQzDZUZCaDRSWXBNUkk2VXp4c2xCeWN0dEI3WGZN/view?usp=sharing

Thanks @chindanai ! Please update the issue after reading the guidelines :smile:

I've add the steps reproduce.

@chindanai
@jessesquires   I found the same problem. I want to know if you guys had solve this issue?

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Added support for current release of aiohttp.

Previous implementation throwed warnings about unclosed ClientSession (in current version of aiohttp 2.2.3):
client_session: <aiohttp.client.ClientSession object at 0x7fb52710ca58>
ERROR:asyncio:Unclosed client session

Merged with a08f143..2c55b7d

thx! :)


Only format the TogglDeskop source (mac)

📒 Description
This PR will change the direction of xcode-formatter.
🕶 Types of changes
Bug fix (non-breaking change which fixes an issue)
🤯 List of changes

[x] Only format the TogglDesktop's source code

👫 Relationships
Closes #3395
🔎 Review hints

Start / Stop in Debug mode 20 times
Check the size of those files in ./src/ui/osx/Pods/GTMSessionFetcher/Source/*
If the size is not change -> 💯
Check the build log -> Make sure xcode-formatter doesn't format those Pod's libraries

I'm not sure why formatter was increasing the file size from a few kb to 100 mb but it is fixed now. I also noticed that building was superslow when code formatting these pods


Add support to FreePBX

Description of PR
Add support to Sangoma (FreePBX) machines
Type of change
Feature Pull Request

Thank you!
It seems to fail on the following:
 --> Executing Yamllint on files found in /home/travis/build/dj-wasabi/ansible-zabbix-agent/...
/home/travis/build/dj-wasabi/ansible-zabbix-agent/tasks/main.yml
  33:1      error    trailing spaces  (trailing-spaces)
  44:1      error    trailing spaces  (trailing-spaces)

/home/travis/build/dj-wasabi/ansible-zabbix-agent/molecule/default/prepare.yml
  16:1      error    trailing spaces  (trailing-spaces)
  27:1      error    trailing spaces  (trailing-spaces)

Can you take a look? 👍

Ok, fixed. Sorry about that.

No worries @darco1991 👍
Thanks you for creating a PR! 👍


feat: core plugin docs [APE-1750]

What I did
Add methoddocs for core plugins to Plugin Python Reference section for further documentation.

fixes: #
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

Would say that the cache provider doesn't work very well, so probably should fix it first before documenting it


Review use of website backlog page

What
Understand how the backlog page on the Design System website is being used, with a view to retire if not visited.
Why
The backlog page on the website is out of date with the GitHub community backlog.
Who needs to know about this
Charlotte, Kelly, Senior Performance Analyst
If we choose to deprecate - Developer, Content Designer
Done when

[ ] Use GA to understand traffic to the backlog page
[ ] Agree whether to retire or remain

Next steps
[outcome of decision]
Investigate where website backlog is linked to from other resources

@christopherthomasdesign @CharlotteDowns @trang-erskine I had a look at historical server logs data and average fortnightly page views of the website backlog page were around 678

Just adding here what I sent to Kelly in Slack:
So a few things (data from 17th Aug - 20th Sept 2021):
(Note that I think some of this data is a little skewed from the community events we've had this month!)

It doesn't get a super high volume of traffic but it is a consistent amount (report attached)
Most of the traffic comes from /community (which is in the top navigation bar)
It's the most clicked on page for users that visit /community
Once a user is there, there are a lot of clicks off into GitHub (report attached)

I don't think the page is perfect, but it does suggest people are engaging with it and interested
GitHub clicks from the backlog
Traffic summary

I'd be tempted to keep the page, but remove the long list of backlog items there. Seeing as they duplicate what's on GitHub and need to be manually kept up-to-date with GitHub. And probably make the link to the GitHub slightly more prominent.
Depending on how we re-structure the backlog, we might want to revisit the content of the page more generally.

Thanks for sharing the data Sara. So interesting that access denied pattern is the most clicked on backlog item https://github.com/alphagov/govuk-design-system-backlog/issues/158. The next 2, filter a list and pagination is expected.
I'm also in favour of Chris's suggestion to remove the list.

My guess is 'access denied' is the most clicked on because it's top of the list 😆

Yeah Chris is right - you do generally see that the first thing in a list is always clicked on the most (on GOV.UK especially). Removing the list sounds like a good idea!


Runtime.ImportModuleError: Unable to import module 'helper': No module named 'lib.s3_util'

Hello,
Describe the bug
helper Lambda function log output:
[ERROR] Runtime.ImportModuleError: Unable to import module 'helper': No module named 'lib.s3_util' Traceback (most recent call last):
In Line https://github.com/aws-solutions/aws-waf-security-automations/blob/main/deployment/build-s3-dist.sh#L148 the file s3_util.py should copied to the helper lib folder but the file is not in die source directory:
https://github.com/aws-solutions/aws-waf-security-automations/tree/main/source/lib
There are some other files too, which should be copied but not available in the directory. Please check them too.
stack_requirements.py want to use this lib:
https://github.com/aws-solutions/aws-waf-security-automations/blob/main/source/helper/stack_requirements.py#L19
To Reproduce
Error occurs during stack creation
Expected behavior

file should be available
not module error

Please complete the following information about the solution:

Version: v4.0.0

Screenshots
/
Additional context
/

Release v4.0.1 fixes the issue.


Asset browser not working

Hello,
after setting up the folder for the assets to be downloaded, when I expand the add-on and try to enter the dropdown menu that says Baked suite asset browser tool, I don't see any button, just paragraphs of text which is not fully shown unfortunately so I cant see what it says, but I think it's some kind of instructions. Any ideas why this might be ?
Thank you!

Hey! You should be able to scroll down and see the rest of the settings.
Note that the minimum required blender version is 3.5
It might be useful to join our discord and open a ticket. It will be easier to debug the issue.
https://discord.gg/bakeduniverse
It's currently late here so if nobody has picked up your ticket before I return I'll pick it up tomorrow asap.


Support collections

Be able to shard content items in different Document tables, a.k.a collections.
Create a DocumentTableStrategy class that can provide the table name for a class. It could a single table, one per class, one per hierarchy, or a specific classes in the same tables.
When loading documents, the type needs to be defined to be able to select which table to query.

What do you think on more generic approach preparing YesSQL field for a future evolution where YesSQL coordinates a distributed system of dbs where sharding logic goes beyond the type of the document to store documents in one location or other based on data within the document like other NoSQL systems do.
Asking the user for the type to find out the collection when he wants to execute a query IMO limits the future support of other sharding strategies not based on the type.
So, instead of hiding the fact we need to know the collection where we are going to look for the document, I would ask for the collection instead of the type. Or at least I would offer both options:

No collection or type is defined, session.QueryAsync(): with a param it can be decided if it will make the query to look for results in default collection or in every collection.
Collections are defined session.QueryAsync("PersonCollectionSpain","PersonCollectionFrance"): query limited to the provided collections.
Define the type but not the collection session.QueryAsync<Person>(): The collection query will look for content with those types in all the collections or in the default collection depending on a parameter.
Define the collection and the type: session.QueryAsync("PersonCollectionSpain","PersonCollectionFrance")()

Initially this will neither have any performance penalty on Orchard 2 nor any change on its code. Cause YesSql by default will use default collection. For the case of OpenIdTokens we will specify explicitly the "OpenIdToken" collection.

Creation of an index also will need we provide the collection where it has to be created, isn't it? Maybe index tables need a prefix with the collection to avoid duplicated names of an index used in two different collections.

So far I intend to support collections by prefixing all tables with its name. So a query will have to provide a collection name. Querying won't be supported cross-collections unless you create your own SQL queries to do unions. We would be able to add support for cross-collections queries at a later time.
I will also provide an option to move a document from one collection to the other. And some extensibility to configure how to find the collection for a document, for instance to define that Token documents always go to tokens collection.

Because collections will contain indexes, documents and content tables, we should be able to use different connection strings for each collection. Also it should be pretty straightforward to have a class and its indexes in a separate collection by default.


[updatecli] Update stable/jenkins Helm Chart version to 2.1.2

! Experimental project
This pull request was automatically created using olblak/updatecli
Based on a source rule, it checks if yaml value can be update to the latest version
Please carefully review yaml modification as it also reformat it.
Please report any issues with this tool here

Superseded by #298


Integrate keywords into search

Changes

Update query for better performance (See #475 for more information)
Integrate Keywords into query

There are more changes than one line. See last commit for all changes.


Tests no longer detected after update

After recently updating GoSublime to 17.11.13-1 it is no longer allowing me to run specific tests. I can only run "All Tests"

I was able to fix the issue by downgrading with the following
GoSublime $ git checkout tags/r17.10.15-1
Note: checking out 'tags/r17.10.15-1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 40439d2... ANN
GoSublime $


[BUG] Bug-report-from-comment: body text is inserted with leading quotation mark

Sanitize body text and strip quotation mark

Resolved by 6f75ee339a1a8032b260476ad68352442ac041b4


Update fantastical extension

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Are you sure you used the Organize Imports command? It doesn't seem so.

Are you sure you used the Organize Imports command? It doesn't seem so.

I have used JetBrains' organising imports functionality and have double checked with VS Code's version. All files have had their imports organised as expected.

Weird. This is how imports are sorted for me:

And this is where I find the Organize Imports command in VS Code (also works with ⇧⌥O):

Can you give it a quick spin to ensure I didn't break anything 🙂

Can you give it a quick spin to ensure I didn't break anything 🙂

Your changes look good to me.

@xilopaint do you have any corrections before merge?

This PR broke the Quickly Add Fantastical Reminder command. The command is currently adding an event instead of a reminder.
I suggest removing the title of the new setting created and using Hide Raycast on Add as a label.
import { runAppleScript } from "@raycast/utils"; should be the second line in each file.

@xilopaint I'm confused why runAppleScript import needs to be on the second line. The only way to ensure that everyone's IDEs organises the imports the same way would be to set something up in prettier or eslint.
I've updated the preference from your suggestion

Can you check again @xilopaint - first point on you list should be fixed

@xilopaint I'm confused why runAppleScript import needs to be on the second line.

Because after @pernielsentikaer's change runAppleScript is being imported from @raycast/utils instead of run-applescript. If you run Organize Imports again it will be on the second line.


Eran/get credentials

curl -s $BM_URL/api/assisted-install/v1/clusters/9f2ea282-2530-471a-921a-287ef1346d22/credentials
{"password":"sNVw7-k7V8V-Y4vzb-X799R","username":"kubeadmin"}

Didn't we also want console URL?  Or is it obvious?
This looks fine to me.

I'll add the consul to the response as well


help me,please ! the CookieManager of setCookie method is not work on iphone iPhone x 12.2

help me,please ! the CookieManager of setCookie method is not work on iphone iPhone x 12.2

Now it should be fixed in 2.0.0. Also, this plugin changed its name to flutter_inappwebview. The current latest version now is 2.1.0+1. So, you can change your dependency influtter_inappwebview: ^2.1.0+1.


Improved version constraints

How about we use semver compatible version constraints?

Step 1: Push code to GitHub
Step 2: Graham Campbell fixes code.
Thanks, Graham!

np. Your work on guzzle is awesome.


Methods in functional components

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[x] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Currently it's difficult to use the functional template since you lose access to closures where as the render method can reference closed-over functions.

why functional component need method?

@Kingwl I already explained in the PR body but, when using a render method instead of using a functional template, I can write functions outside of the component and reference them via closure. However, when using a template, I no longer have access to the closure.
I can reference them via $options.methods but seems hacky and would prefer official support in offering a similar API to stateful components.

I respect your work, but I think there will be a better solution
/ cc: @posva

Here's an issue in vue-loader (it was originally in vue but closed) that might explain the use-case more clearly: https://github.com/vuejs/vue-loader/issues/1291
What are you thinking @Kingwl ?

I don't think we should be going further along the route of "making functional components work like normal components in a Vue file", for the following reasons:

In v3, stateful components are much faster to initialize, and this should make it less necessary to use functional components just for performance
v3 stateful components can also return multiple root nodes

If we want to make functional components fully equivalent to stateful ones in a Vue file, we go down the rabbit hole of supporting components, directives, methods, provide/inject and all other options... which eventually defeats the simplicity of functional components. I think we should go back and make functional components more about "functions".


tell the author that /tools/prepare.sh fails on your system - node Error - Ubuntu 16.04.3

/resin-docs/tools$ ./prepare.sh
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   142  100   142    0     0     83      0  0:00:01  0:00:01 --:--:--    83
100 35873  100 35873    0     0   9789      0  0:00:03  0:00:03 --:--:-- 27425
/home/rw2/resin-docs
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   144  100   144    0     0     95      0  0:00:01  0:00:01 --:--:--    95
100  2449  100  2449    0     0    812      0  0:00:03  0:00:03 --:--:--  1896
/home/rw2/resin-docs
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   142  100   142    0     0     86      0  0:00:01  0:00:01 --:--:--    86
100  143k  100  143k    0     0  35407      0  0:00:04  0:00:04 --:--:--  113k
/home/rw2/resin-docs
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   149  100   149    0     0     97      0  0:00:01  0:00:01 --:--:--    97
100 56712  100 56712    0     0  15530      0  0:00:03  0:00:03 --:--:-- 63224
/home/rw2/resin-docs
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   144  100   144    0     0     82      0  0:00:01  0:00:01 --:--:--    82
100 15493  100 15493    0     0   4215      0  0:00:03  0:00:03 --:--:-- 25440
/home/rw2/resin-docs
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   155  100   155    0     0     20      0  0:00:07  0:00:07 --:--:--    38
100  4315  100  4315    0     0    474      0  0:00:09  0:00:09 --:--:--  4695
/home/rw2/resin-docs

<EMAIL_ADDRESS>build /home/rw2/resin-docs
./tools/build.sh && webpack -p

/usr/bin/env: ‘node’: No such file or directory
npm ERR! Linux 4.10.0-42-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "build"
npm ERR! node v4.2.6
npm ERR! npm  v3.5.2
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>build: ./tools/build.sh && webpack -p
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script './tools/build.sh && webpack -p'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the resin-docs package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ./tools/build.sh && webpack -p
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs resin-docs
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls resin-docs
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/rw2/resin-docs/npm-debug.log
resin-docs/tools$ sudo apt-get install node.js
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'node-jsv' for regex 'node.js'
Note, selecting 'node-jsdom' for regex 'node.js'
Note, selecting 'node-jsesc' for regex 'node.js'
Note, selecting 'node-json-stringify-safe' for regex 'node.js'
Note, selecting 'node-jscoverage' for regex 'node.js'
Note, selecting 'node-jssip' for regex 'node.js'
Note, selecting 'node-jsonparse' for regex 'node.js'
node-jsdom is already the newest version (0.8.10+dfsg1-1).
node-jsesc is already the newest version (0.5.0-1).
node-json-stringify-safe is already the newest version (5.0.0-1).
node-jsonparse is already the newest version (1.0.0-1).
node-jssip is already the newest version (0.6.34-5).
node-jsv is already the newest version (4.0.0+ds1-1).
0 upgraded, 0 newly installed, 0 to remove and 162 not upgraded.
rw2@rw2-ThinkPad-T530:~/resin-docs/tools$ sudo apt-get install npm
Reading package lists... Done
Building dependency tree
Reading state information... Done
npm is already the newest version (3.5.2-0ubuntu4).
0 upgraded, 0 newly installed, 0 to remove and 162 not upgraded.

I couldn't reproduce the issue. I believe this is not a problem with prepare.sh, but with node either incorrectly installed or having an older version of it. Closing.


Written Integration Tests using RestAssured for Rating APIs , Mlayer APIs , Count APIs, GeoCoding APIs and NLP APIs in Catalogue Server

Written integration tests for get item using rest assured.

Can one of the admins verify this patch?

Done with the integration tests for rating apis. Please review.

@karun-singh can you review the changes to Jenkinsfile?

ok to test

retest this please

retest this please


Loging Window for what is going on

I appreciate if you could add Logging Window for what is going on while connecting, searching, downloading, current blog details, like below in my simple app

That are some nice enhancements of TumblOne.

You could play around with TumblThree as well ;). Any coder is welcomed.
Back to topic: It's nice to have this, yupp. If someone wants to go for this, do it. One could probably redirect everything from the queue process text into a log window/file as a beginning.


Performance improvements and cleanup

Things this PR does, at a very high level:

Clean up (and speed up, hopefully) fill_support_matrix
Clean up fill_confidence_matrix and fill_confidence_matrix_tr

We've cherry-picked most of the changes here into other PRs, so I'm closing it.


Refreshing issues tag widget Rover

I encountered refreshing issues with the tag widget in Rover. After running scripts introducing tags to my data, the tags were only displayed correctly in the diagram after running the script for the first time. After running tagging script 2, the widget displayed the wrong axes labels and the refreshing button could not be pressed anymore. Closing the widget, removing all tags from the archive, then running the tagging scripts again and loading the widget freshly solved the issue.
In the screenshot below you can see the wrong axes labels that were displayed. The search for one of the tags correctly displayed that there were only 5 traces tagged 'DO_active' whereas the widget displayed a bar corresponding to over 25 molecules.

Unfortunately I have not been able to reproduce this problem. I think I must not have done the correct sequence of things. It sounds like the tag widget basically crashed and after that it was not correct because it couldn't be updated. I will keep trying to see if I have the same problem and can fix it. Thanks for reporting this!!

The issue I encountered is now resolved. Basically, if you have a molecule record selected and you then delete it using the Delete molecule item in the menus, the contents of the molecule record would still be displayed. Even worse, if you switched tabs and then switched back, the record was added back into the archive.
Now all references to the deleted molecule record are removed and all the molecule record fields are cleared if the currently selected record is deleted. Just for completeness, when deletes sets of molecule that were not actively selected during deletion, there was never a problem.
I am not sure if this resolve the original issue. One thing I did notice is that the tag widget will update with the reload rotating because it is very fast. So I don't think it was not updating. In all cases, it was reflecting the set of current molecule tags. Also, when not in virtual mode, there is no indexing. This mean the tag counts are created again by looking at all records, so over all I am really puzzled.
I am going to close this issue for because as far as I can see the main problem was solved. However, we can certainly reopen the issue at a later time if this issue comes up again.
One final thought, I wonder if somehow there was actually an error in the molecule index that didn't show all the tagged molecules, this could explain the confusion.. Hmm.. 🤔


Redirect after reading response body

I am able to read the response body for the given request using the ResponseHandler of Titanium Proxy.
Based on the content of the response body (eg: check if the response string contains a keyword), I would like to redirect the user to a custom HTML page, similar to the way you have done in your example.
e.Ok("<!DOCTYPE html>" +
	      "
" +
	      "Website Blocked" +
	      "
" +
	      "
Blocked by titanium web proxy.
" +
	      "" +
	      "");

(However, the example redirect at Request time itself, whereas I am looking to redirect at Response time based on content of original response.)
Is it possible to achieve this? If so, can you please guide me in doing so.

In your case you should subscribe to the proxyServer.BeforeResponse and set the response headers and the body.
Maybe we can add helper methods (or make the current one to work in the response event, too) for this case, too.

I tried using the proxyServer.BeforeResponse and clear the header and add my html page as you suggested. Instead of showing the html page, it downloads html file.
Let me also mention, that the corresponding request is a "download file request".
The response has the content of the file, which I am able to read in the BeforeResponse Handler.
So, instead of downloading the file, I would like to redirect the user to the custom html page(depending on the body content).
So for example, if I download "abc.txt" from the website, I get the response body in the BeforeResponse handler. I replace the body with my custom html script, clear the headers and add my own headers.
The result of this handler is I don't get the new custom page in my browser, instead the file named
"abc.txt" is still downloaded, but when I open the file I see the custom html script.

Copy you plese copy your code here? If you replace the body and the browser gets the original, then it is a bug in TWP. It can't be happen.
did you call the the
var bodyBytes = await e.GetResponseBody();
before you set the body with
await e.SetResponseBody(bodyBytes);
?

Please try the following with the latest beta (3.0.379 or newer):
            var ext = System.IO.Path.GetExtension(e.WebSession.Request.RequestUri.AbsolutePath);

            if (ext == ".gif" || ext == ".png" || ext == ".jpg")
            {
                byte[] btBody = Encoding.UTF8.GetBytes("<!DOCTYPE html>" +
                                                       "
" +
                                                       "Image is blocked" +
                                                       "
" +
                                                       "
Blocked by Titanium
" +
                                                       "" +
                                                       "");

                var response = new OkResponse(btBody);
                response.HttpVersion = e.WebSession.Request.HttpVersion;

                e.Respond(response);
                e.TerminateServerConnection();
            }

I close this issue due to inactivity. Feel free to reopen if needed.


Cut v1.18.1 Release on 29th November, 2024

This issue can be closed when we have completed the following steps (in order).
Please ensure all artifacts (PRs, workflow runs, Tweets, etc) are linked from
this issue for posterity. Refer to this prior release issue for
examples of each step, assuming vX.Y.Z is being cut.

[ ] Run the Tag workflow on the release-X.Ybranch with the proper release version, vX.Y.Z. Message suggested, but not required: Release vX.Y.Z.
[ ] Run the CI workflow on the release branch and verified that the tagged build version exists on the releases.crossplane.io build channel, e.g. build/release-X.Y/vX.Y.Z/... should contain all the relevant binaries.
[ ] Confirm the full set of patch versions that will be released and promote them from lowest to highest, so the highest version is the last to be promoted (e.g. v1.12.2 should be promoted after v1.11.3), in order to avoid the promote workflow overwriting the latest patch release.

NOTE: This ordering requirement can be avoided by checking the "pre-release" checkbox in the promote workflow for the older releases, as described in #5420.

[ ] Run the Promote workflow with channel stable on the release-X.Y branch and verified that the tagged build version exists on the releases.crossplane.io stable channel at stable/vX.Y.Z/....
[ ] Published a new release for the tagged version, with the same name as the version and descriptive release notes, taking care of generating the changes list selecting as "Previous tag" vX.Y.<Z-1>, so the previous patch release for the same minor. Before publishing the release notes, set them as Draft and ask the rest of the team to double check them.
[ ] Request @jbw976 to perform a CloudFront cache invalidation on https://charts.crossplane.io/stable/ and https://releases.crossplane.io/stable/
[ ] Ensured that users have been notified of the release on all communication channels:

[ ] Slack: #announcements channel on Crossplane's Slack workspace.
[ ] Twitter: reach out to a Crossplane maintainer or steering committee member, see OWNERS.md.
[ ] LinkedIn: same as Twitter

[ ] Remove any extra permissions given to release team members for this release

waiting for https://github.com/crossplane/crossplane/pull/6145


Cancel Button doesn't restore original values

Hello,
I am currently trying to use PreferencesFX and I have encountered a problem or even a bug directly.
I created a simple demo application with PreferencesFX, with a StringProperty, an IntegerProperty and a BooleanProperty. I put a listener on the StringProperty, which always gives me the latest content when changes are made.
private final StringProperty welcomeText = new SimpleStringProperty("Hello World");
this.welcomeText.addListener((observable, oldValue, newValue) -> System.out.println(newValue));

This allows me to see that the changes are not undone when leaving the window via the Cancel button. Is this a bug or do I still have to adjust other parts to make the Cancel button work properly?
My entire demo application is available in the following Gist: https://gist.github.com/elyday/64a0975551fb7121b874491bc6eaef33

I checked out the develop branch once, because I actually intended to write for a fix here, and I noticed that this bug has already been fixed in the develop branch.
Maybe they are ready to release a new version with this fix?

Hi,
Thanks for the detailed explanation!
The fix for this bug was already implemented in #56.
We will likely make a new release soon, in the meantime you can build the develop branch and install PreferencesFX in your local repository to use it.

Hi @elyday
The fix for this issue was included in release 8.3.0 (for Java 8) and 11.3.0 (for Java 11), which has just been released.


ViolinPlot in vue-chart.js

Hi, I'm trying to use the ViolinChart in my vue.js using chart.js
Is this currently possible?
Im currently getting a "RangeError: Maximum call stack size exceeded"

can you provide a codesandbox or stackblitz or similar one?

Here you go! https://codesandbox.io/s/recursing-driscoll-qmswm3?file=/src/App.vue
I'd like to plot a ViolinPlot and add data labels to each point on hover like a tooltip

e.g. https://codesandbox.io/p/sandbox/thirsty-forest-c9t29m?file=%2Fsrc%2FApp.vue%3A45%2C1-46%2C1

thanks for the help! unfortunately i cant access this link


Make the code build in shared_library mode

This pull request is a proof of concept of everything that is currently needed to make oz-wl master (Chromium M42) build with component=shared_library (see #367).
The basic issue is that code in the wayland target (that the ozone target in ui/ozone/ozone.gyp depends on) is currently using code from other layers (such as content/ and media/) that should not be used at this level, otherwise we end up with circular dependencies.
As I said, I am not entirely sure all the approaches I have taken with the commits in this PR are correct, my idea is to get input from others.

@baleboy @darktears @kalyankondapally @joone

I've rebased the patches addressing the comments in the "Build the code in vaapi code in media/" and the IME one, PTAL.