Impact analyses OpenSCD-core

Investigate the steps needed per plug-in to move to OpenSCD-core.
https://wiki.lfenergy.org/display/SHP/Make+use+of+OpenSCD+core
Activities:
Look into the code to see what needs to be changed
Make a list of decision that needs to be made
Report the finding here: https://wiki.lfenergy.org/display/SHP/Make+use+of+OpenSCD+core
Acceptance criteria:
Report findings in the wiki page
compas-oscd-components (GIT Repository / NPM Package):
  compas-open:
    /src/compas/CompasOpen.ts
    /src/compas-services/CompasSclDataService.ts
    compas-scl-list
    compas-scltype-list
  compas-save:
    /src/compas/CompasSave.ts
    /src/compas-services/CompasSclDataService.ts
    compas-changeset-radiogroup
    compas-scltype-select
    compas-comment
    compas-labels-field
    compas-loading
    CompasExistsIn

  compas-changeset-radiogroup:
    /src/compas/CompasChangeSetRadiogroup.ts
    /src/compas-services/CompasSclDataService.ts (Only for ChangeSet, so maybe just move this)
  compas-comment:
    /src/compas/CompasComment.js
  compas-labels-field:
    /src/compas/CompasLabelsField.ts
  compas-loading:
    /src/compas/CompasLoading.ts
  compas-scl-list:
    /src/compas/CompasSclList.ts
    compas-loading
  compas-scltype-list:
    /src/compas/CompasSclTypeList.ts
    /src/compas-services/CompasSclDataService.ts
    compas-loading
  compas-scltype-select:
    /src/compas/CompasSclTypeSelect.ts
    /src/compas-services/CompasSclDataService.ts
    compas-loading

  CompasExistsIn (Mixin):
    /src/compas/CompasExistsIn.ts
    /src/compas-services/CompasSclDataService.ts

  /src/compas/foundation.ts
  /src/compas/private.ts

compas-oscd-auto-alignment-plugin (GIT Repository):
  CoMPAS Auto Alignment Plugin:
  /src/compas/CompasAutoAlignment.ts                     (Component)
  /src/compas-services/CompasSclAutoAlignmentService.ts  (Service)
  /src/menu/CompasAutoAlignment.ts                       (Menu)
  Maybe combine the menu and component in the new setup.

compas-oscd-import-cim-plugin (GIT Repository):
  CoMPAS Import CIM:
    /src/compas-service/CompasCimMappingService.ts
    /src/menu/CompasCimMapping.ts

compas-oscd-project-plugins (GIT Repository):
  CoMPAS Open:
    /scr/menu/CompasOpen.ts
    compas-open
  CoMPAS Save:
    /scr/menu/CompasSave.ts
    compas-save
    compas-loading
  CoMPAS Save as:
    /scr/menu/CompasSaveAs.ts
    compas-save
    compas-loading
  CoMPAS Save as version:
    /scr/menu/CompasSaveAsVersion.ts
    compas-save
    compas-loading

  - use repository 'compas-oscd-components'

compas-oscd-merge-plugins (GIT Repository):
  CoMPAS Import IED:
    /scr/menu/CompasImportIEDs.ts
    compas-open
  CoMPAS Merge Project:
    /scr/menu/CompasMerge.ts
    compas-open
  CoMPAS Update Substation:
    /scr/menu/CompasUpdateSubstation.ts
    compas-open
  CoMPAS Compare IED:
    /scr/menu/CompasCompareIED.ts
    compas-open

  - These plugins are extending the ones from OpenSCD.
    Only change is how the SCL File is retrieved.
    So this will be a discussion how to deal with this.
  - use repository 'compas-oscd-components'

compas-oscd-editors (GIT Repository):
  CoMPAS Versions:
    /src/compas/CompasUploadVersion.ts
    /src/compas-editor/CompasVersions.ts
    /src/compas-editor/foundation.ts
    /src/compas-wizards/scl.ts
    compas-loading

  - use repository 'compas-oscd-components'

compas-oscd-ocl-validator (GIT Repository):
  Validate using OCL
  /src/compas-services/CompasValidatorService.ts
  /src/validators/CompasValidateSchema.ts

compas-oscd-settings-plugin (GIT Repository):
  CoMPAS Settings
  /src/compas/CompasSettings.ts

compas-oscd-core (GIT Repository / NPM Package):
  /scr/compas-open-scd.ts   (New Component to be used in the distros.)
  /src/compas/Compasing.ts
  /src/compas/CompasNsdoc.ts
  /src/compas/CompasUserInfo.ts
  /src/compas/CompasSessionExpiredDialog.ts
  /src/compas/CompasSessionExpiringDialog.ts

compas-oscd-distro (GIT Repository):
  compas-oscd-core component.
  including all needed plugins.

locamation-vmu-plugin (GIT Repository):
  /src/menu/LocamationVMU.ts
  /src/locamation/*.ts

alliander-import-cim-plugin (GIT Repository):
  Alliander Import CIM (was CoMPAS import from API)
    /src/compas/CompasImportFromApi.ts              (Component)
    /src/compas-service/CompasCimMappingService.ts  (Service)
    /src/menu/CompasImportFromApi.ts                (Menu)
    Maybe combine the menu and component in the new setup.

alliander-oscd-distro (GIT Repository):
  compas-oscd-core component.
  including all needed plugins.

Remark: Remember the use of wizard-divider, wizard-textfield and more.
Open questions:
Where to push the NPM packages? Create a CoMPAS organisation on NPM (it that is easy). OpenSCD URL example?

Added first setup to the description so everyone can change it.

Todo: create issues to migrate


consider adding possibility to check/uncheck or labelizing files

When we have a large amount of files to review or correct, it is extremely difficult to find our way into the sidebar.
It would be interesting to be able to simply check a box or apply a color (a label) to the name of the file whose proofreading or correction is finished.
A label seems more flexible to adapt to the majority of cases. Something like this.

Sounds like something an extension could do using  FileDecorationProvider API that arrived in 1.52

Sounds like something an extension could do using  FileDecorationProvider API that arrived in 1.52

Also there are other issues that ask for coloring of items in the Explorer. Thus closing as extension-candidate and duplicate of those issues


PolyOverlayWithIW: draw optimization for Path

Issue Type

[x] Improvement
[x] Performance

Description and/or steps/code to reproduce the problem
When we build a Path for a PolyOverlayWithIW, there's no specific optimization for the Path.
For instance, if there are 10 points (pixels) on the same line, we could simplify the Path considering one segment instead of 9.
Environment
Version of osmdroid the issue relates to:
6.1.5

I have good news: I found a very effective way to boost performances for PolyOverlayWithIW with Path.
At least in one very slow example: Marine Corps Air Station Miramar / north of San Diego (cf. #1409) (14K points).
The display of this polygon is very slow if the zoom is much too close. But it's not that slow if the polygon fits the screen.
When we clip the Path into (more or less) the screen, we clip each segment and that creates several segments if this segment is out of the screen. If many segments are out of the screen, that creates a lot more segments for the Path, which causes performance hinderance.
Could we get rid of those generated out-of-the-screen clipped segments? Well, perhaps, but that should be done very carefully because the current clipping process works for polygons with holes and filling. For polylines and drawLines, we are less careful because we can afford it: if it's out of the screen we simply dismiss the segment.
The good news is that when we clip the segments they are clipped into a rectangle, and obviously a lot of consecutive clipped segments are on the same rectangle side. And that's where we can optimize the display: hundreds of segments clipped on the same rectangle side can be optimized into a couple of actual Path segments (instead of hundreds).
I'll PR soon.

Done.
The combination of #1467 (#1474), #1465 (#1466) and #1409 (#1459) is really terrific!


Not Up To Date?

Using the newest update and Unity Keeps warning me the SDK is not up to date every time I hit play. Very annoying.   Odd tho, as the asset bundler says 1.3.0, but I clearly have 1.3.43

Forgot to update the SDK version number when released 1.3.43
should be fixed after DNS cache expiration


The app fails with "Cannot GET /

My aim is to really talk to you about working together on a really cool tutorial for Aurelia users (I am aware of your blog, your article on Rob Eisenberg's blog, your use of Paul van Bladel's aurelia plugin and I am pretty good friend with Eugenio and Matthias.
So, it feels silly to trip on the most simple first step. I am using node v5.5.1
Can you tell me what am I missing, please?

This app doesnt contain '/' page.
You can find the "how to" inside the readme file.
good luck!!

enter the following url, you will recieve a random sentence:
localhost:3001/api/random-quote

Thank you @szare and @ComBarnea - I suggest that the sample gets updated by setting api/random-quote to be the default path :-)


EF: HasMaxLength doesn't configure dimmension

In EF, the idiomatic way to configure blob or text column's max length is using HasMaxLength. It would be nice if you could also use this to configure a vector column's dimension.
In other words, I want this...
modelBuilder.Entity<MyEntity>()
    .Property(e => e.Vector).HasMaxLength(3);

...to produce this.
CREATE TABLE "MyEntity" (
    -- ...
    "Vector" vector(3),
    -- ...
);

🩹 Workaround
Today, you have to use HasColumnType.
modelBuilder.Entity<MyEntity>()
    .Property(e => e.Vector).HasColumnType("vector(3)");

Hi @bricelam, happy to include something like this if you want to submit a PR. I think ideally it'd be called HasDimensions, as HasMaxLength implies shorter vectors can be stored.

Cleaning up issues, but someone is welcome to submit a PR.


bootstrap integration sample

Some sample using bootstrap 3 ?

I see with this
https://datatables.net/examples/styling/bootstrap.html


feat: configured jxboot-helmfile-resources secret schema to pull from external secret locations rather than k8s so they populate prior to applying k8s resources

Hi @chrismellard. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ccojocar
You can assign the PR to them by writing /assign @ccojocar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test kube

tls
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test kube

tls
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test tls

gsm
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test kube

tls
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test tls

gsm
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test gsm

vault
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test kube

tls
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test tls

vault
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test vault

gsm
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test tls

vault
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test vault

gsm
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test gsm

kube
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

tls
e2270ef75b72b53498d8bcef3573906e54ecc1b0
link
/test tls

gsm
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test gsm

kube
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test kube

vault
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test gsm

kube
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test kube

vault
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test vault

tls
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test tls

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
0a912b63df4dafe1f4505bfa2b6813fc3dd91f94
link
/test kube

gsm
f90bf4d19dcd759f666c970425a0dace4d5c5385
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
f90bf4d19dcd759f666c970425a0dace4d5c5385
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
f90bf4d19dcd759f666c970425a0dace4d5c5385
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
1e5223347311a2662c16118389ff87d6710dceec
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
1e5223347311a2662c16118389ff87d6710dceec
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/retest

@chrismellard: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
1e5223347311a2662c16118389ff87d6710dceec
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test gsm


File Structure recovery sometimes fails

Based on https://github.com/bruderstein/nppPluginManager/issues/52
It looks like the 1.7.1 work around is not reliable.

Ported from: CollinChaffin https://github.com/oleg-shilo/cs-script/issues/62

After installing the prerelease of <IP_ADDRESS>, I really do need help to debug this because the Roslyn support is still not working properly.
Here's what I've done to simplify this because I am getting a bit frusterated:
Removed the env variable for CSScript as I don't want the non-prerelease via chocolately to interfere with this test.  I assume the NPP plugin should use the embedded assembles and intellisense executables etc.
Moved EVERYTHING for plugins out of APPDATA temporarily and back to the default programfiles86 and renamed the xml flag file so that NPP is running in default plugin config mode
Installed <IP_ADDRESS> via unzip manually into plugins folder
Upon executing NPP now, and every execution, I receive this:

However, there is a change because now, my plugin config the Rosylyn checkbox for some reason remains enabled continually, despite it not working, whereas previous versions upon relaunch the checkbox would be unchecked:

As you can see, it maintains the setting to utilize the embedded engine to keep this simple:

...and I am not certain what other steps I can take to fully debug this plugin, but my logic pushed me to execute the "CompatibilityTest.exe" that, unlike before was throwing an exception and crashing hard, now says all is great (just to take the other half of my hair):

So, @oleg-shilo, I really appreciate your assistance to help me enable the Roslyn C#7 support.

So is there a debug setting I can enable to tell me exactly what exception is being thrown and preventing it from loading?  Everything seems okay otherwise so I am at a loss as to why this is happening now after eliminating the first 2 reasons (folder structure, and APPDATA location) that I have totally eliminated.

It is a complex problem and below is the full overview of the symptoms, causes and the history.

Plugin before v1.7.0
Prior introduction of C#7 support (v1.7.0) the plugin was distributed with two different versions of Roslyn binaries. This is due to the fact that before VS2017 release Roslyn (v1.0.3) was in Beta for scripting functionality. And to make the matter worth, the versions that worked for scripting were in conflict with versions that worked for code analysis. CS-Scriupt.Npp solved this problem by distributing both conflicting distros in their individual sub-folders (Roslyn and Roslyn.Intellisense) with the plugin implementing distro specific assembly probing.
Later, Notepad++ Plugin Manager (PM), at least v<IP_ADDRESS>, has introduced the defect - collapsing all plugin sub-folders into one single (root) directory, effectively completely screwing Roslyn. Currently this issue is still being worked on by Npp team (https://github.com/bruderstein/nppPluginManager/issues/52).
Plugin v1.7.0
CS-Scriupt.Npp v1.7.0 - was released with a single Roslyn folder (<root>/Roslyn) as the latest Roslyn removed the internal incompatibility. Though, because the plugin was still relying on the presence of the Roslyn sub-folder the faulty PM was still preventing C# 7 from working,
Plugin v1.7.1
CS-Scriupt.Npp v1.7.1 - was a desperate attempt to deal with the faulty PM. It has introduced additional assembly probing flow for the "collapsed file structure". It also introduced an aggressive "Fix file structure" feature, which later was found to be unreliable.
Plugin v1.7.3
CS-Scriupt.Npp v1.7.3 - was released after Npp support indicated that the PM fix is to be delivered (sooner or later). This version has revoked the over ambitious Fix file structure feature, improved error handling/reporting and limited auto-disabling C#7 support (in case of Roslyn error) to the session scope only.
Plugin v1.7.4
During the intensive testing of plugin v1.7.3 the latest Roslyn (v2.0.0) has unexpected assembly probing behavior presumably triggered by being hosted by in unmanaged hosts (e.g. Notepad++). Thus user assembly probing sometimes was not invoked on the obvious default probing failures. These findings are consistent with findings during the integration of CS-Script intellisense engine with Sublime Text on Linux where user assembly probing was not triggered for some assemblies all the time. This is most likely due to some custom assembly probing implemented by Roslyn itself.
While the the problem was only intermittent (~1 out of 20 in the testing environment) it had to be addressed. Release v1.7.4 has moved RoslynIntellisense.exe (the only consumer of Roslyn binaries) into the Roslyn sub-folder. This is expected to prevent custom assembly probing at all as the default probing would be up to the challenge. This changed made the problem go away in the test environment but still needs to be confirmed by users.
Thus the  v1.7.4 is the latest version that needs to be used for C# 7. Unfortunately the plugin's update channel (in AboutBox) may or may not deliver it correctly so the best way is to install the plugin manually.

Hi @CollinChaffin, the post above explains the issues. My guess is that you were still testing v1.7.3-pre. If so can you please do the testing again but now with v1.7.4-pre. I expect it to fix the issue completely.

As for error logging it's always enabled. You can access it from AboutBox:

Though it doesn't help much as the exception is indicating that the Roslyn failed to do proper assembly probing by some how bypassing CS-Script pugin asm routine. BTW this is the reason why CompatibilityTest.exe is successful - CompatibilityTest.exe is a managed not native host.
Anyway, v1.7.4 should address this final bit.

Okay boy I wish I had seen that 20hrs ago I probably spent about 10 more screwing around with this :) LOL.  Anyway, good news is, it's fixed.  Holy cow.  It works again!  Whew!
I am curious I guess I can read the commit diffs your explanation above doesn't quite align with my testing because for me on mult systems, it was 100% of the time failure, bar none.  At NO time can I get 1.73 Roslyn support to work down to fresh VM OS installs, zero other NPP plugins on fresh NPP installs - I mean I beat this to death so I'm guessing there had to be (something) absolutely broken that absolutely looks like at a glance (of the changelog) was fixed by basically moving the Roslyn files again.....which STILL doesn't seem to align since in my last hours of screwing around with this, I was literally moving those assemblies myself just to see if in fact it was still a directory location issue - unless I just missed whatever magic location change occurred.  But, since we're only talking about 3 folders, the NPP main plugin, the CS-Script plugin, and then the Roslyn subdir - I'm still a bit confused what this ultimate fix was.
So if you get a min I'd love a bit more info on what you changed from 1.73 to 1.74 pre and what your take is on the fix etc. I'd really appreciate it I only ask since I invested so much to try to help with this and it really does interest me.  BTW, thanks for the acknowledgement!  I do appreciate that!  Also, hopefully as I get more free time in the hopefully near future, I'd be interested in perhaps helping you with some additional pulls/actual code contributions too if you'd be interested when the time comes!

Okay boy I wish I had seen that 20hrs ago I probably spent about 10 more screwing around with this :)

Mate, I know the pain. :) I also spend my whole weekend on this. On something that shouldn't' have happened in the first place. Something that ultimately you have no control over.
Anyway I am so relieved that it worked in your environment as your 100% is a way more trustworthy comparing to my 5% failure rate.

I'm still a bit confused what this ultimate fix was.

This is what is the fix (actually work around) in v1.7.4.
The latest Roslyn (v2.0.0, bundled with cs-script.npp v1.7.0+) must have introduced something that screwed with the user assembly probing. My AppDomain.AssemblyResolve event handler is not called in 5% of the runs (100% in yours). Mind you on Linux I also have 100% failure rate.
The invocation of the user asm resolving algorithm is non-deterministic. CLR may not fire it if other AssemblyResolve returned non-null result. Even if the result is wrong. My speculation is that this is exactly what Roslyn started doing from v<IP_ADDRESS>. Though I have no evidence of that.
Anyway, Nothing can be done to fix it. Roslyn is doing his business and there is nothing wrong from its point of view. Thus instead of fixing the compromised asm probing in the RoaslynIntellisesnse.exe (CS-Script.Npp module that loads/uses Roslyn) I brought this module inside of the Roslyn directory so it doesn't need to do the probing any more.
This change potentially requirs a new asm probing from RoaslynIntellisesnse.exe for Intellisense.Common.dll. But it is simple enough as I have full control over the both modules. And on practical level probing is not even needed as Intellisense.Common.dll is always loaded before RoaslynIntellisesnse.exe.

The bottom line is that we had two fundamental problems:

Npp collapsing the folders
Still not fixed. User has to install/restore the plugin manually.
Roslyn obstructing asm probing from RoaslynIntellisesnse.exe
Solved by avoiding asm probing as the result of moving the module inside of the Roslyn folder.

Thank you again for spending time on this. I will start pushing the release notifications to the Npp users.

Hey so sorry haven't gotten back to you on this!  Just caught up and it makes better sense now - thanks for the additional explanation clearly we both were looking at this one FAR too long! :)
It's just awesome we were able to debug through it - that is always very rewarding when the debugging at least leads to a fix!  I'm just catching up on the plugmgr too I see your last questions about the reinstall/ininstall etc. and it's funny in my last test runs I actually wrote down that exact list of questions.  I certainly wasn't trying to step on your toes and I didn't mean to come across not understanding how much work you've put into this I absolutely do!  As I said over in that issue #52, because my only real outstanding questions from a testing perspective are the exact ones you already asked, I'll pull back a bit as to not get in your way of the development effort - but, by all means anytime you could use a second set of eyes or hands on an this or any other issue don't hessitate to ping me and I'll see if I can help.
I'm happily using the latest pre (or unplublished) version 1.7.6 and in the installed/running state it's working great!  Once again, thanks again for the release note shout-out on helping with the issue, I always appreciate seeing other DEVs do that I've always tried to do that myself when other DEVs have helped me - but as I'm sure you're aware - most DEVs unfortunately do not these days so dealing with another member of a dying breed is a nice change!

Hi Collin,
Yes it has been an interesting journey. And what is really rewarding is that he solution is something that  truly addresses the problem but not just decreasing its chances. And the fact that the problem shouldn't exist at the first place is kind of irrelevant.
I also wanted to thank you for all the time you spent on this and the fact that you have up-voted  the PM defect I logged. I do believe it made the difference. Suddenly after 2 weeks if being effectively ignored it got the attention it deserved. That is why I felt the need to mention your assistance in the release notes. :)

I see your last questions about the reinstall/ininstall etc. and it's funny in my last test runs I actually wrote down that exact list of questions...

As for  this one, I decided to abandoned any effort in this direction. The NPP guys are so busy that they just have no time to answer the questions properly and promptly. I have already learned that if the question doesn't get simple answer quickly then you may be facing the prospective of getting into the slow unproductive endless question/answer exchange. With no warranty of getting the complete answer ever. I do not blaming anyone I am just trying to be realistic and be practical about the solution to the problem.
Thus I decided to limit my dependency on Npp and implement unconditional "run-on-uninstall" step from inside of my plugin. I was able to do this simply because PM will always stop the NPP before the uninstall and the plugin can hook up to the NppOnExit event.
This technique is not truly for "OnIninstall" but rather "OnPossbleUninstall" but it is good enough for my case: I just need to kill VBCSCompiler.exe that was started by the exiting Npp anyway. The approach is not ideal and it can interfere with other VBCSCompiler.exe clients (CS-Script, Sublime Text, Visual Studio). However the probability of this is low and the impact is almost undetectable - one off ~5 seconds delay with the C#/VB code compilation.
Thank you again for your help.
Happy Easter to you and your family.


Update semanticdb-scalac to 4.4.19

Updates org.scalameta:semanticdb-scalac from 4.4.18 to 4.4.19.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "semanticdb-scalac" } ]

labels: library-update, semver-patch

Superseded by #112.


:sparkles: feat(enharmonic): remove semitones from toString output

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
814

Relevant Lines:
814

💛  - Coveralls


Add script to generate blsToExecutionChange for testnet validators.

Add script to generate blsToExecutionChange for testnet validators to make withdrawal testing easier on local testnet. The script does the following:

Set up the parameters required for generating blsToExecutionChange using staking-deposit-cli
Runs staking-deposit-cli using docker and outputs the json to a local directory.

To use this script, lighthouse and lcli needs to be built using this PR, so that we could use a given mnemonic to set up the genesis validators:
https://github.com/sigp/lighthouse/pull/3807
Once the testnet is started, the script local-testnet/generate_bls_to_execution_change.sh can be used to generate bls_to_execution_change json for genesis validators.
Example:
./generate_bls_to_execution_change.sh 3 3,4 0x49011adbCC3bC9c0307BB07F37Dda1a1a9c69d2E
Generating BLS to execution change for validators: 3,4
Validator 3 withdrawal credentials: 0x00d9b97d22d95ed721cce4a04b788b27bf4587672c379937e17ed691261aa5e7
Validator 4 withdrawal credentials: 0x00a75729087749b5bc51afb4dded73d23af7ee8b2e7cd9175ca05d9d290f355a

***Using the tool on an offline and secure device is highly recommended to keep your mnemonic safe.***

**[Warning] you are setting an Eth1 address as your withdrawal address. Please ensure that you have control over this address.**

**[Warning] Using devnet chain setting to generate the SignedBLSToExecutionChange.**

Verifying your BLSToExecutionChange file:         [####################################]  2/2

Success!
Your SignedBLSToExecutionChange JSON file can be found at: /app/bls_to_execution_changes

Press any key.

NOTE: the local testnet is a copy from the Lighthouse repo, longer term we potentially want to unify them to reduce maintenance burden.

@rickimoore I've copied all the latest Capella local testnet changes from @pawan's PR https://github.com/sigp/lighthouse/pull/3807, there are a few important changes for starting up local testnet:

Clone and build geth and bootnode

https://github.com/ethereum/go-ethereum.git
git checkout v1.11.5
make all

Build lighthouse & lcli from this branch

# under the lighthouse directory
git fetch origin pull/3807/head:pr-3807
git checkout pr-3807
make lighthouse && make install-lcli

Start local testnet with this command instead (new genesis.json parameter)

./start_local_testnet.sh genesis.json

The local testnet works, however the generate BLS change script no longer works - I'll check with @pawan on how he's generating the keys. If generating the json file is important to you now, you may want to run local testnet with the older commit.

For reviewer(s), this PR contains all local testnet scripts copied from sigp/lighthouse#3807 - I'm trying to keep it in sync (mostly) to the lighthouse repo keep it maintainable.
The only new change here is this file:
https://github.com/sigp/siren/pull/167/files#diff-8d8da66adb19d899688c9f2b897fca422fcc3355b7945e61e55853185213c4c3

@rickimoore I can confirm blsToExecutionChange now works on the local testnet now! (thanks @pawanjay176)
I've updated the steps in the PR description.


Corrupted AST when binding an option and accessing a property

Hi there! I'm getting unexpected results in the AST when having a binding to an option an accessing a property immediately after. So, if I have this code:
let test() =
    let x = Some 5
    x.IsSome

The resolved expresión for test() body becomes:
Application
  (Call
  (Some Value val xs,member get_IsNone,[type Microsoft.FSharp.Core.int],[],[]),
   [],[Const (null,type Microsoft.FSharp.Core.unit)])

The binding disappeared and has been replaced by an application to unit. This seems to happen with .IsSome, .IsNone, Option.isSome, Option.isNone. If I don't access the identifier directly everything works normally. Modifying the code like so:
let test() =
    let xs = Some 5
    xs |> Option.isSome

gives:
Let
  ((val xs,
    NewUnionCase
  (type Microsoft.FSharp.Core.Option<Microsoft.FSharp.Core.int>,Some,
   [Const (5,type Microsoft.FSharp.Core.int)])),
   Call
  (null,val op_PipeRight,[],
   [type Microsoft.FSharp.Core.int Microsoft.FSharp.Core.option;
    type Microsoft.FSharp.Core.bool],
   [Value val xs;
    Lambda
  (val option,
   Call (null,val isSome,[],[type Microsoft.FSharp.Core.int],[Value val option]))]))

I reproduced the issue with versions <IP_ADDRESS> and <IP_ADDRESS>. Any hint to solve the problem would be much appreciated.

Definitely a bug!

I've found a similar issue. When I have this code:
type Todo = { title: string; completed: bool }

let filters =
    Map [ "active", Array.filter (fun (t: Todo) -> not t.completed) ]

let remaining todos =
    filters.["active"] todos |> Seq.length

The generated AST for method remaining is:
Application
  (Call
  (Some Value val filters,member get_Item,
   [type Microsoft.FSharp.Core.string;
    type Test.Todo Microsoft.FSharp.Core.[] -> Test.Todo Microsoft.FSharp.Core.[]],
   [],[Const ("active",type Microsoft.FSharp.Core.string)]),
   [],[Value val todos])

This means the call to Seq.length got missing. I'm very puzzled about this, if I change the body of the method to Seq.length(filters.["active"] todos) then the AST is generated correctly:
Call
  (null,val length,[],[type Test.Todo],
   [Coerce
  (type Microsoft.FSharp.Collections.seq<Test.Todo>,
   Application
  (Call
  (Some Value val filters,member get_Item,
   [type Microsoft.FSharp.Core.string;
    type Test.Todo Microsoft.FSharp.Core.[] -> Test.Todo Microsoft.FSharp.Core.[]],
   [],[Const ("active",type Microsoft.FSharp.Core.string)]),
   [],[Value val todos]))])

Also if I use a dictionary instead of a map for filters the problem disappears:
type Todo = { title: string; completed: bool }

let filters =
    dict [ "active", Array.filter (fun (t: Todo) -> not t.completed) ]

let remaining todos =
    filters.["active"] todos |> Seq.length

This generates the following (correct) AST for remaining:
Call
  (null,val op_PipeRight,[],
   [type Test.Todo Microsoft.FSharp.Core.[]; type Microsoft.FSharp.Core.int],
   [Application
  (Call
  (Some Value val filters,member get_Item,
   [type Microsoft.FSharp.Core.string;
    type Test.Todo Microsoft.FSharp.Core.[] -> Test.Todo Microsoft.FSharp.Core.[]],
   [],[Const ("active",type Microsoft.FSharp.Core.string)]),
   [],[Value val todos]);
    Lambda
  (val source,
   Call
  (null,val length,[],[type Test.Todo],
   [Coerce (type Microsoft.FSharp.Collections.seq<Test.Todo>,Value val source)]))])

Any help with this would be appreciated. I haven't found many cases so far but if the AST provided by the F# compiler services is not reliable, it will greatly hinder the usability of a project like Fable.

Well that needs to be fixed :)

I'd like to help but I'll need some guidance about where to look at first, as I don't know the inner guts of the compiler services that well.

This was fixed in <IP_ADDRESS> too (all the fixes were the same bug more or less!)


Write Documentation for sw-build

Library Affected:
sw-build
Browser & Platform:
E.g. Google Chrome v51.0.1 for Android, or "all browsers".
Issue or Feature Request Description:
Write Documentation for sw-build

When you get a chance, it would be great to expand on what the initial docs for sw-build might look like from an IA perspective.

I'm still missing my cut-and-paste code samples.

There are two code samples of using sw-build in https://github.com/GoogleChrome/sw-helpers/blob/master/docs/recipes/rollup.md, and that page could be deprecated entirely if you put together more official documentation.
The code on that page uses out-of-date parameter names for some of the sw-build methods, though, as dest needs to be swDest and rootDirectory needs to be globDirectory.


The  Infer Constraints functionality is not working

I am using Android Studio 3.1.2 for Windows.
When reproducing step 9 of the codelab I faced the following. After pressing Infer Constraints button the constraints are visually drawn in designer but nothing is written into xml file. After closing the page all constraints are gone.
This happens in this particular activity_main_inference.xml file. If I try the same functionality in some newly created layout it works.

I have encountered the same problem, have you solved it?

same problem

Hi. I had a similar issue, but I found that on the App/res/values/styles.xml file, you should add "Base" to the line containing

Same problem here. Anyone got the solution? Thanks.

This is terrible. Googles own code doesn't work. Then, how can we as devs be expected to handle this?
I do still prefer Relative and LinearLayouts after all this time.

I have the same problem. Adding 'Base' before the Theme doesn't work for me.

I got the same problem

I thought I got the same issue. But what I noticed was: when you select everything, using "ctrl + click", you can see all of the elements in a layout with constraints.


ValueConstraint: Datetime/json constraints

Description

Assert strftime format
Assert dateutil parseable
Assert JSON parseable
Match JSON schema
New op: APPLY_FUNC, evaluation using a function passed when creating the constraint
dateUtilParseableConstraint()
jsonParseableConstraint()
matchesJsonSchemaConstraint()
strftimeFormatConstraint()
Some of the concerns in one of the previous PRs would still be valid for this one, e.g. if statements, but after merging the previous PRs I would update this one from mainline accordingly.
Previous unmerged constraints included here, so the review can wait after merging those.
General Checklist

[ ] Tests added for this feature/bug
if it was a bug, test must cover it.
[ ] Conform by the style guides, by using formatter
[ ] Documentation updated
[ ] (optional) Please add a label to your PR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

173 of 184 (94.02%)  changed or added relevant lines in 3 files are covered.
17 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.5%) to 80.662%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/whylogs/core/statistics/constraints.py
170
181
93.92%

Files with Coverage Reduction
New Missed Lines
%

src/whylogs/core/statistics/constraints.py
4
76.56%

src/whylogs/proto/constraints_pb2.py
13
66.67%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
3906

Relevant Lines:
4708

💛  - Coveralls

I resolved conflicts and edited the update process of the BTWN set constraints, using the update object introduced by @MilenaTrajanoska to follow the same pattern.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

68 of 82 (82.93%)  changed or added relevant lines in 1 file are covered.
83 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.4%) to 80.582%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/whylogs/core/statistics/constraints.py
68
82
82.93%

Files with Coverage Reduction
New Missed Lines
%

src/whylogs/core/datasetprofile.py
5
84.73%

src/whylogs/proto/constraints_pb2.py
13
66.67%

src/whylogs/core/statistics/constraints.py
65
75.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
3903

Relevant Lines:
4708

💛  - Coveralls


Is webkit integration done?

I'm planing to use webkit media stream components...but I find no openwebrtc libs in the source tree

It was removed from WebKit at the beginning of October 2017 because the OpenWebRTC is no longer actively maintained. The current upstream WebKit ports (WPE, GTK, Mac) are using a libwebrtc-based media-endpoint now.


category url not found

hi, by the way thanks for the awesome theme, i love it. uuhmm, I just added some category on post, but in layout after i click categories menu that i made its says 404. can you help me?
this is the generated url https://rhmdhdyt.github.io/category/oriflame/

i think i need to create html category manually in _categories right?

Yes. I see that you made a category named marko, so you would do the same thing with other new categories.


Inference Sample

Hi,
Can a proper inference sample code be provided on which we can try VCD? I've been trying to set it up with LLaVA but I think I'm doing things wrong. If the authors can provide a simple script in which we can try and see the difference between a VCD and non VCD LVLM, that would be really helpful.

+1


stable/percona uses mysql image

https://github.com/helm/charts/blob/798226aac49d8f28bca9b6afb03a89df8ce1d467/stable/percona/templates/deployment.yaml#L29

I probably called my branch in the wrong way, but this PR https://github.com/helm/charts/pull/8978 (that otherwise should be listed here) solve this issue.

Guys we cannot close this issue. The related PR was not approved or rejected and, at this stage, this chart is unusable simply because it doesn't use percona image!!! Then you have two choices: resolve this issue (approving and merging or rejecting giving infos about that) or remove the percona chart from your repo. Tertium non datur.
Please give a feedback or merge.


Add a policy class template parameter to basic_text_view and itext_iterator to enable custom error handling

At present, underflow and invalid code unit sequences result in exceptions being thrown from itext_iterator advance operations.  These operators can't return errors in any other way and still be usable as generic iterators.  Yet, use of exceptions is not acceptable to many members of the C++ community.
Custom error handling could be provided by adding a policy class template parameter to basic_text_view and itext_iterator.  The policy class would have member functions that would be called in underflow or invalid code unit sequences.  Those functions could then throw custom exceptions, record errors elsewhere, signal that incomplete code unit sequences should be saved as state in the iterator (which would then compare equal to the end iterator), provide substitution characters for invalid code unit sequences, etc...

Closing this issue as resolved by the introduction of error policies in commit 4950cdfda13cbfc9a20fcfbf4c85a7a9fcf1f8c6.  The current error policy classes are simpler than what was suggested in the writeup for this issue (no member functions), but I think suffices.


Update grpc and remove lager

TIL: mix deps.clean is necessary to remove unused deps.

I think this is ready.


finding nCr

find nCr value modulo M
1<=n<=10^5
1<=r<=10^5
M is a prime

can i work on this?

Added nCr in this

Added nCr in this

this will fail for large values of n and r
check my pr for the edits i am suggesting

@m-e-r-l-i-n  Can you give me an example for which it will fail?

n=2*10^4 r=10^4 M=10^9+7


Connected lists dropping not in dropzone still adds to dropzone

We have 3 lists, one is for categories and the other is for items. Then these can be dropped inside the last one to create a checklist. The problem is that when a user goes over this dropzone and then drops it next to it. The system doesn't recognise this as a cancel operation.

On the left is this dropzone. on the right are the lists for items and categories. First you need a category on the left to drop items in it.
I just can't find out if it is something we are doing wrong or that the plug-in doesn't support it.

Could you fork one of the codepen examples found in README.md to create a simplified version of your code? Otherwise it's very difficult to make assumptions and suggestions based on the provided description.

If you could come on gitter, we can give you access to the system as it is not live yet

The issue was that when an element was dragged outside of the draggable-sortable, the ui-sortable got a 0 height and as a result you can't place it back in its original place.
Suggested solutions:

define a minimum height for the draggable containers or
use placeholder option and define a height or
use the start & stop callbacks to

onDragStart:
i) get the height of the dragged item
ii) set that height to the draggable container
onDragStop set the height of the draggable container back to 'auto'


Health Equity Quarterly Report

Problem statement
Approaching the endd of the quarter of work for the Health Equity Pilot with Texas, we wanted to measure and consolidate learnings.
What you need to know

Initiative Goals and Metrics: https://cdc.sharepoint.com/:w:/r/teams/ReportStream/_layouts/15/Doc.aspx?sourcedoc={E17F23C4-8348-4FBD-B4D8-DC099DF609BD}&file=ReportStream Health Equity Initiative.docx&action=default&mobileredirect=true

Acceptance criteria

[ ] Below answers/content included in the existing Initiative Document
[ ] All Goals reviewed and documented with the findings/outcomes
[ ] Calculate and document metrics found in the Initiative Document
[ ] Ensured all Pilot questions have been answered and link to the answers in the Initiative Document
[ ] Recommendations for follow-on work based on findings
[ ] Notify stakeholders (Jillian, Audrey, Chris, Glenn) async for review

Working draft of report ready for review. @jillian-hammer @chris-kuryak @GlennRGrieves

just completed my first review of the draft - thanks @jakefishbein-navapbc!

Final draft added to the Health Equity Initiative document and submitted for review.


Fix indent in NMR_ModelReaderNode.cpp

Found with the compilation warning:
[143/260] Building CXX object CMakeFiles/lib3mf.dir/Source/Model/Reader/NMR_ModelReaderNode.cpp.o.cpp.oeamLattice1702_Ref.cpp.o.o
../Source/Model/Reader/NMR_ModelReaderNode.cpp: In member function 'void NMR::CModelReaderNode::parseContent(NMR::CXmlReader*)':
../Source/Model/Reader/NMR_ModelReaderNode.cpp:175:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  175 |     if (!pszNameSpaceURI)
      |     ^~
../Source/Model/Reader/NMR_ModelReaderNode.cpp:178:6: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  178 |      if (nCount > 0) {
      |      ^~

closing in favor of
https://github.com/3MFConsortium/lib3mf/pull/279


Smart contract development

In its early days, I was somewhat adamant to keep Create Eth App a frontend-only development tool. However, with time, interesting use cases for smart contract development came to mind: flash loans, buidler setups, etc.
I'm still not convinced that it is worth it, particularly given the complexity it would bring, but I decided to open the GitHub issue to entertain the idea further.

Received a request for this:

Any thoughts on using @ethPM1 as a way to simplify the creation of new templates?

I've used create-eth-app in tandem with buildler. e.g. here's an old demo dapp of a builder project on the top level of the repo, with a create-eth-app within the /frontend/ directory.
My 2 Gwei: I think it would be a nice addition to provide a flag option when creating a new project.

Thanks for your feedback, @samajammin! This helps a lot with deciding what are the best features to implement next.
In the interim, @austintgriffith made huge progress with scaffold-eth; a tool that generalises what your honeypot app does by assembling buidler and create-eth-app together.


Scene tree filtering by type and group does not work in a running scene (Remote)

Godot version
v4.0.3.stable.official [5222a99f5]
System information
Windows 11
Issue description
Scene tree filtering by type and group doest not work in a running scene (Remote). Filtering by name in remote works fine, and filtering by type/group in the local scene works fine also.
Steps to reproduce

Run any scene
Сlick Pause Running Project (F7)
Switch to the Scene/Remote tab
Cliсk ⋮ button to the right of the "Filter Nodes" field
Select Filter by Type or Filter by Group
Try to type something into the field -> nothing will be displayed

Possibly related issues: #22949
Minimal reproduction project
Not needed

The filter logic is implemented twice. Once in SceneTreeEditor here the filtering with type and group is implemented. For the remote tree it is implemented separate in EditorDebuggerTree. Here the new search patterns are not implemented yet. The best thing would in theory be to unify the filter logic, but since both trees work with very different data basis this does not seem feasibly. Copying the logic over should be possible and the type filter could easily be replicated. The used RemoteNode structure does however not contain information on groups so this filter seems hard to support.


[Engine API] Unified list of opaque requests

Reference: https://github.com/ethereum/execution-apis/pull/577

Closed in favor of https://github.com/Consensys/teku/issues/8620


Unfinished todo's are no longer rolled over

Coming out of testing #41 - I'm finding for my install, I'm no longer seeing any TOODs being rolled over.
From the testing of the above issue, I deleted the obsidian-rollover-daily-todo directory from my Documents/Obsidian/.obsidian/plugins folder, and cloned the upstream repository and built commit a4d090eb7facb6:
$ git clone git@github.com:lumoe/obsidian-rollover-daily-todos.git
$ cd obsidian-rollover-daily-todos
$ pnpm install
$ pnpm build

The README.md file doesn't include any specific instructions for building, but based on the ci workflow in .github/workflows/ci.yml I settled on the above pnpm calls.
My daily note format is: YYYY/gggg-[W]ww/YYYY-MM-DD and I have all three roll-over config options enabled.
I'm not seeing any errors in the dev-console inside Obsidian at all.

Thanks for reporting this issue! Do you use periodic notes or the daily notes plugin? Did you try restarting obsidian and tried it afterwards?

Using Periodic Notes.   Daily Notes is disabled.

Was there any progress on this? Or anything I can try to see what's happening (or not happening).
With the dev tools open and running "Rollover Todos Now" I see nothing in the console.

can you share your settings for periodic notes? I'm working on a fix for the master-branch. The issue was caused by using nested folders as the format-specifier. Maybe you use something like YYYY/YYYY-MM-DD as your format?

update: also pushed the bugfix to the release-2.0 branch. Can you test once again?

Settings:
Format: YYYY/gggg-[W]ww/YYYY-MM-DD
Template: Templates/Daily Note Template
Folder: Daily Notes
Updated to the release-2.0 branch:

TODOs with [ ] did roll over, however, any with the newly supported 'in-progress' type values did not, such as [/] or [?] - maybe we want to roll over things that are NOT [x] rather than those that ARE [ ]?
TODOs rolled over to the END of the daily note, not into my "Things to Try to Get Done" heading, looking at the configuration I see I no longer have any headings configured, or an ability to do so:

the newly supported 'in-progress' type values

i think the PR for this is still open, so the functionality is not yet available.

looking at the configuration I see I no longer have any headings

loading of the headings is not 100% reliable for me. Could you check if the headings appear after you deactivate and reactivate obsidian-rollover-todos?

Deactivating/Reactivating the plugin didn't help with the headers (pulled the latest changes in the release branch).
Interesting - now when I manually roll over when I have my current days notes:

Switched to the fix/complex-date-formats branch and rebuilt - the plugin now finds my headings, and finds the todos to move over, and moves over the [ ] items only (so not the in-progress items I mentioned earlier).

just to summarize, so that things are not getting mixed up: fix/complex-date-formats still shows the headers as a dropdown. The "new" header-parsing is only available on release-2.0. Both branches have the fix for handling complex dates in place.
If you see your todos rolled over on both branches, then this issue should be closed.
I had another look in the code. On release-2.0-branch, the settings for the periodic-notes-plugin are not respected; I have to add that back.
Can you open a new issue for respecting periodic-notes in the release-2.0-branch? Please prefix the issue with v2:  or something along these lines. This would make my life a bit easier.

Update:<PHONE_NUMBER>aff231318f3f9bf195cc0471441f67 adds support for periodic-notes back on branch release-2.0. If you could test and confirm that it works, we can work around creating a new issue.

I just pulled the release-2.0 branch and rebuilt:

once again "2023-02-09 is not a daily note"
headers are not shown in the config

Switched back to fix/complex-date-formats and pulled Lukas Mölschl's commit 72d854940f594d - and that does as expected.
I see the two branches differ quite a bit with dependencies.
I wonder if there's something else missing on that branch - tripping up the headers?

I just tried the master branch (2ec2494f934868) - that works fine for rolling over, showing the headers, and everything.
I also raised #87 to cover the [/] style TODO entries I mentioned earlier.

once again "2023-02-09 is not a daily note"

did you create the new note as Daily Notes/2023/2023-W06/2023-02-09.md?

headers are not shown in the config

can you maybe share Templates/Daily Note Template? I can't reproduce the headers not showing up.

I wonder if there's something else missing on that branch - tripping up the headers?

I don't think that that's the cause of the error. The template-headings are parsed by obsidian-rollover-todos without using any dependencies.

Can you comment on this? I implemented a fix and am very interested to know if it works for you.
with no feedback I‘d consider this issue resolved.

I am not sure, if I get everything with the testing of the 2.0-branch. I installed it just now after the 1.1.4 in Obsidian did not show any options any more, just empty.
Now I have the options page again, but on top there are no headers shown. I have a template for daily notes set up and there are headers in that template.
I still have to see, if the open tasks are rolled over with the next note....

Can you restart Obsidian and look into rollover-daily-todos settings again? Maybe try with activating/deactivating. If that doesn’t work we have to look at how you installed from the release-2.0 branch.

Neither restarting nor off and on did sth.
I cloned the repo with argument release-2.0 to the plugins folder (git bash), then in the subfolder via powershell (git win would not recognize pnpm command):
pnpm install
pnpm build

@VOOM108 sounds like the same issues I had when trying the release-2.0 branch awhile ago.

Rolling over yesterday's tasks did not work, either...

I would have been very surprised if that worked, given the information that you provided earlier!
I did find two bugs when inspecting this problem though. The bugs are fixed in the release-2.0-branch. Can you
git pull && pnpm clean && pnpm build

again and see if that fixed the issue? @talios it would be very helpful if you could do the same thing!

$ git pull && pnpm clean && pnpm build

Already up to date.

><EMAIL_ADDRESS>clean /Users/amrk/Documents/Obsidian/.obsidian/plugins/obsidian-rollover-daily-todos
> rimraf main.js data.json

sh: rimraf: command not found

Whats rimraf? I tried doing a pnpm install but that didn't help.

Manually running pnpm install rimraf resolved that issue - now to test.
I now see my template headings which is a good sign.  Will do some testing shortly.

Ah yes sorry, I forgot about pnpm install.
Thanks for confirming that it works again!

That seems to work be working when I manually run "roll over todays now" on an existing daily-todo note doesn't seem to run when creating the new daily note (altho, I had deleted the note, not sure if theres state tracking there ).
I've noticed however, occasionally, after the pulled in notes I end up with my title as a note entry:
## Things to Try to Get Done

 - [ ] we pulled this over
 - [ ] and this

 - Things to do today

If I understood correctly

Automatic rollover doesn’t seem to work for you
Unexpected lines end up in your note after rollover.

Is that right so far?
Can you provide reproduction steps for both cases?

Further testing:

automatic rollover IS working - strangely it didn't earlier, but now consistently does
Seems I'd added that as a place holder in my daily note template - removing that and every is GOOD AS GOOD!

Cheers


services/horizon: Add docker compose file for running both horizon and stellar core

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
I have added a docker compose file which allows you to easily run both stellar core and horizon together.
Fixes https://github.com/stellar/go/issues/1538
Goal and scope
We do have a docker image which allows you to run both Stellar Core and Horizon. But because Stellar Core and Horizon are bundled together, it makes the stellar quick start docker image ill-suited for developers who want to contribute to either Stellar Core or Horizon.
As a Horizon developer, I would like to be able to add a feature to Horizon without having to install and setup postgres, stellar core, etc. Using the Docker compose file included in this PR, I am able to run Horizon locally from source and my local Horizon instance is able to interact with its dependencies running in Docker.
Similarly, I could run Stellar Core locally from source with Horizon running in docker and the Horizon docker container would be able to interact with my local Stellar Core instance.
Summary of changes

I added a Dockerfile which builds horizon from source. The advantage of this Docker image is that it isn't bloated. The docker image runs on alpine and consists of the horizon binary and nothing else. Also, because the Dockerfile builds Horizon from source, it allows you to checkout any development branch of Horizon and run that version of Horizon in docker. You are no longer restricted to running a version of Horizon that has been published as a Debian release.
All the Docker containers in the Docker Compose file have ports exposed on the host machine. The containers communicate with each other using host.docker.internal. This is important because it allows any individual container to be swapped out with an instance which is running locally on the host machine outside of Docker.
The Horizon entrypoint script first installs the db migrations before running the Horizon service
The stellar core configuration is included in stellar-core-testnet.env

Known limitations & issues

The Docker Compose uses TCP sockets instead of unix domain sockets to connect to postgres. Unix domain sockets are much faster but the cost is that it's difficult to swap in local instances of Stellar Core / Horizon.
host.docker.internal is not supported in Dockef for linux, https://github.com/docker/for-linux/issues/264, but we do have a work around for linux users
currently, the only configuration I have is for test net. In the future it would be nice to add configuration for running a main net stellar core instance.

What shouldn't be reviewed
N / A

Nice! Much better than the quickstart. Every component isolated in its own container 👍


111

Can you help me configure the environment? I can't run it successfully.

Can you help me configure the environment? I can't run it successfully.

Am working on adding a "How to run " section on the Redme. But you require Oracle Open JDK 22.0.2. Other  dependencies are run from the pom.xml in intellij.  If you run on any issues you can offer more details for asisstnce.


Add new quests

Also, koumakan version doesn't mention that Isuzu should be the flagship.

Back then wikiwiki did not state the flagship requirement, so I did not include it.


Added tests to verify custom pciAddress slots and function

Signed-off-by: Vatsal Parekh<EMAIL_ADDRESS>
What this PR does / why we need it:
Added tests to verify custom pciAddress slots and function, this enhances the check for supported range of pci addresses
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Added tests to verify custom pciAddress slots and function

/retest

/retest

/retest

/retest

/approve

/retest

/test pull-kubevirt-goveralls

/test pull-kubevirt-goveralls

/retest

/retest

/retest

/retest


Don't NRE when calling SkinManager.AddSkin during initialization

It's not currently possible to add an embedded skin during the OnInit phase because of an NRE on this line (MenuRef isn't initialized yet).  This makes it impossible for a previously-selected embedded skin to be loaded during initialization, since the only other event, OnReady, is never run when the default skin is pre-selected, making the embedded skin unselectable.

Friendly ping?  Skin author would like to upload a showcase but the skin still isn't usable by the general public

Hi, I’m currently unable to sufficiently test this use case and make a release in the coming week. I haven’t merged this because I’m not sure if it should null check here or not call this method at all, but I haven’t had the time to look into this.
My current best suggestion would be to add the embedded skin in something like herocontroller update, and enabling it if it was expected to be the selected skin and use the skin set event to keep track of your skin being selected in the given save.
I know this isn’t ideal but this has 0 likelihood of breaking when I do actually fix the behaviour in CK itself which should be by the end of July or early August.


Update README.md to clarify installation requirements

Hi @mikkelhegn and thanks for the PR!
I'm going to close this in favor of #96 as protoc is going to be removed as a install/build dependency for cargo-component as a result.
Thanks!


Update kube installation intro with ref to rbac details

Description
Doc fix.
Updated v2.X/getting-started/kubernetes/installation/index.md to
augment the vague remark about RBAC requirements with a pointer to the
concrete details in the hosted instructions, as a way of elaborating
for general consumption.
Addresses #912
Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note
None required

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@duglin please help here, you know IBM has authorized me to contribute to Calico.
@caseydavenport you may want to review this, but I am not able to assign reviewers.

/_site/v2.1/getting-started/kubernetes/installation/index.html
  *  linking to hosted#rbac, but rbac does not exist (line 1103)
     hosted

Looks like the rbac section was added in v2.2, so doesn't exist for v2.1

I removed the reference in the v2.1 case.  The HTML linter is failing with an unrelated problem with DCOS doc.

@MikeSpreitzer one more place - I think we should add to the master/ directory - that's where new releases of the docs are cut from.

Made the edits in the master section too.


onFinishDiscoveringReaders is not called

How to provide timeout to discoverReaders function? If I don't pass any timeout, discoverReaders is not stopped i.e. onFinishDiscoveringReaders is not called. I am seeing indefinite logs of didUpdateDiscoveredReaders though

Did you resolve this issue? Seeing the same thing


Tracking Issue for workspace feature-unification

Summary
RFC: #3692
Implementation: TODO
Documentation: TODO
Adds the resolver.feature-unification configuration option to control how features are unified across a workspace.
Unresolved Issues

[ ] Bikeshed the config option naming.

Future Extensions

Support in manifests
Dependency version unification
Unify features in other settings

About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Given that my concerns on the RFC were ignored I will repeat them here as well.
This feature can result in build failures in upstream dependency crates outside of the workspace if the workspace feature unification is used.
The charge team should make clear in the document and communication around this feature that:

This can happen and might not be fixable due to other deficiencies in cargo and the wider rust ecosystem.
This is entirely up to the user that sets this setting and not to the upstream crate
Ideally these information should be presented by cargo as part of the compiler error message

Also as I personal note I want to emphasise again that I'm highly disappointed how the cargo team seems to handle concerns and suggestions to resolve these concerns. I'm also disappointed how the team decided to (not) communicate their decision. For me that doesn't look like a team that's interested in outside contributions. For me personally that means that I will likely not contribute to cargo anymore, including taking care of concerns from the cargo team for potential concerns for features I design/work on. I also cannot recommend other persons to contribute to this team anymore. That effort is likely better spend somewhere else.

Whoever marked my comment as duplicate: Could you point to the "duplicated" comment in this thread?
Also could you point to an official answer to these suggestions from the cargo team and not from individual team members? I'm really not sure what you are expecting to happen if you just keep pretending to ignore meaningful suggestions.

As you said, this was repeating content from the RFC discussion.  I gave some replies in the RFC.  The Cargo team saw the discussion and signed off on the RFC without raising concerns.  This was re-iterated by Eric in the thread you opened on Zulip, see https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/Offical.20team.20response.20to.20concerns.20raised.20in.20RFC-3692/near/479039846
As this has come up before and is re-litigating the RFC, I collapsed it to get it out of the way of the discussion for implementing the RFC.  It is a big help to be able to have Issue discussions more focused using tools like that.  Some other teams go to the extreme of locking Tracking Issues, reserving them solely for status updates.

@epage I still do not see where exactly my concerns about the potential social impact are addressed. Can you point to the exact location, including an explanation why it's not possible to have this slight adjustment to the wording to make clear that the communication around this feature needs to be aware of these edge cases. Given how other parts of the rust project usually try to have the best possible diagnostic for error cases I really cannot understand why you and the cargo team continues to just ignore these suggestions.
All I got so far is reiterating why you don't consider this a breaking change. I got your point there the first time, I just disagree with it. Even that does not mean that I'm the opinion that you shouldn't do this feature, which is why I literally trying to suggest for more than a month now that this likely can be resolved by just having that diagnostic/documentation note explicit in there.

As for implementing this, I think its ok to implement each config value (and maybe stabilize) separately.
For all of this, the top-level function for where all of this lives is
https://github.com/rust-lang/cargo/blob/e858736b561805af163ad9dbe0dbd30aa889701f/src/cargo/ops/resolve.rs#L137-L269
Keep in mind that we have two resolvers (dependency, feature) and multiple phases

Resolve dependencies for the lockfile (resolve_with_registry)
Resolve dependencies to strip out unrelated packages, unspecified features (resolve_with_previous)
Resolve features (FeatureResolver::resolve)

To make workspace work, we'll likely need to duplicate the logic from (2) to be able to run it after feature resolver so that we can resolve features for unselected packages.  The problem with outright moving the logic from the dependency resolver to the feature resolver is that, under various circumstances, we allow Cargo to combine (1) and (2) so that dependencies don't need to be vendored or that we can skip downloading git dependencies for the sake of deciding not to use them.  This is what the other two cases at the beginning of resolve_ws_with_opts are about.
The big risk is that we do the filtering differently between the the dependency resolver and the feature resolver.
As for package, a hacky way to implement that is to do back-to-back compilations.  The downside is the redundant work.  Ideally, FeatureResolver::resolve could just handle this.  The main question I have is how well will it scale to have these additional disjoint feature graphs.  There might need to be work done to handle that.

@epage I'm still waiting on your response to my question above.
I'm also highly disappointed that the cargo team just does not seem to care about good diagnostics at all.


Plotting

Helo,
Can I plot 2 different spectra on superposition? I only found the plot_array function, but I would like to compare two different spectra by plotting them on the same plot. Is this somehow possible?
Thank you

There is no direct method to do this but it is very easy just using standard matplotlib plotting functions. Every fid object has the associated spectral data (1D numpy array) as an attribute, e.g. fid0.data.
So you could do:
plt.plot(fid0.data)
plt.plot(fid1.data)

Of course you'd have to do some tweaking to convert index position of the array to PPM. If you are unsure look in the source code in plotting.py.


AtomicWake memory order regression

Introduced by #1316
The patch introduces a load with SeqCst assuming sequential consistency from the write as well, but the write is done with AcqRel semantics which introduces a potential deadlock.
this load assumes it will always see the latest write from here.
However, that would require the compare_and_swap to use a SeqCst ordering.
This can lead to deadlocks where the notify doesn't see the registered task.

From the SeqCst docs:

Like Acquire/Release/AcqRel (for load, store, and load-with-store operations, respectively) with the additional guarantee that all threads see all sequentially consistent operations in the same order.

I think the "with the additional guarantee that all threads see all sequentially consistent operations in the same order". Because only the load is SeqCst, it does not have to have a sequentially consistent ordering with respect to the compare_and_swap (which is AcqRel). I think you're correct, and would accept a PR to either revert or switch the compare_and_swap to SeqCst.

I've been looking at this and I'm also reasonably confident that SeqCst isn't enough either, since it only imposes a total ordering between sequentially consistent operations, not to third elements unrelated to the atomic variable being updated. The operation that is wanted here is a load(Release) (guarantee that my writes were released to other threads before any of them observed the change away from the value I observed with my load). However, that's not a thing that exists in LLVM nor any architecture I'm aware of. I'm planning to revert for now. cc @stjepang

cc @stjepang

cc @stepancheg, right?

Heh, yup. My "@st" + autocomplete was not sufficient XD

@cramertj

I'm also reasonably confident that SeqCst isn't enough either

Are you sure? My naive understanding is that any SeqCst operation is a full memory barrier, all other threads will see all my changes on their next SeqCst.
(I couldn't understand your explanation sorry)

@stepancheg The LLVM docs say:

SequentiallyConsistent (seq_cst in IR) provides Acquire semantics for loads and Release semantics for stores. Additionally, it guarantees that a total ordering exists between all SequentiallyConsistent operations.

It's guaranteeing a total order of SeqCst ops, not of other operations that fall between the SeqCst ops, nor is it giving Release semantics for loads.


MX records in cloudflare

Hi everyone !
I'm using octodns since few month and I really appreciate it.
But today when I try to sync with cloudflare, I got this error :
Traceback (most recent call last):
  File "/home/alex/dns/env/bin/octodns-sync", line 11, in <module>
    sys.exit(main())
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/cmds/sync.py", line 39, in main
    dry_run=not args.doit, force=args.force)
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/manager.py", line 289, in sync
    plans = [p for f in futures for p in f.result()]
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/manager.py", line 49, in result
    return self.func(*self.args, **self.kwargs)
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/manager.py", line 225, in _populate_and_plan
    plan = target.plan(zone)
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/provider/base.py", line 49, in plan
    exists = self.populate(existing, target=True, lenient=True)
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/provider/cloudflare.py", line 246, in populate
    lenient)
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/provider/cloudflare.py", line 223, in _record_for
    data = data_for(_type, records)
  File "/home/alex/dns/env/local/lib/python2.7/site-packages/octodns/provider/cloudflare.py", line 160, in _data_for_MX
    'preference': r['priority'],
KeyError: u'priority'

Can you help me, I thought the problem was the priority set to 0 but even if I set it to 1 or 10 I have this error.
My config :
---
'':
  - ttl: 3600
    type: A
    value: <IP_ADDRESS>
  - ttl: 3600
    type: MX
    values:
      - priority: 0
        value: residencesainteanne-fr.mail.protection.outlook.com.
  - ttl: 3600
    type: TXT
    values:
      - v=spf1 a mx include:_spf.point-web.fr ~all
      - v=spf1 include:spf.protection.outlook.com -all
      - MS=ms49229553
_sip._tls:
  ttl: 3600
  type: SRV
  values:
    - port: 443
      priority: 100
      target: sipdir.online.lync.com.
      weight: 1
_sipfederationtls._tcp:
  ttl: 3600
  type: SRV
  values:
    - port: 5061
      priority: 100
      target: sipfed.online.lync.com.
      weight: 1
autodiscover:
  ttl: 3600
  type: CNAME
  value: autodiscover.outlook.com.
enterpriseenrollment:
  ttl: 3600
  type: CNAME
  value: enterpriseenrollment.manage.microsoft.com.
enterpriseregistration:
  ttl: 3600
  type: CNAME
  value: enterpriseregistration.windows.net.
ftp:
  ttl: 3600
  type: CNAME
  value: residencesainteanne.fr.
imap:
  ttl: 3600
  type: CNAME
  value: fo-mailpop-1.point-web.fr.
lyncdiscover:
  ttl: 3600
  type: CNAME
  value: webdir.online.lync.com.
mail:
  ttl: 3600
  type: CNAME
  value: vm-mail0.point-web.fr.
msoid:
  ttl: 3600
  type: CNAME
  value: clientconfig.microsoftonline-p.net.
'pointweb._domainkey':
  ttl: 3600
  type: CNAME
  value: dkim-customers.point-web.fr.
pop:
  ttl: 3600
  type: CNAME
  value: fo-mailsmtp-1.point-web.fr.
sip:
  ttl: 3600
  type: CNAME
  value: sipdir.online.lync.com.
smtp:
  ttl: 3600
  type: CNAME
  value: fo-mailsmtp-1.point-web.fr.
webmail:
  ttl: 3600
  type: CNAME
  value: fo-mailwebmail-1.point-web.fr.
www:
  ttl: 3600
  type: CNAME
  value: residencesainteanne.fr.

There was a similar sounding report over in https://github.com/github/octodns/issues/248 yesterday. You might take a look at that to see if you're running into the same thing.

@alexverilhac the _data_for methods are for converting responses from Cloudflare's API into OctoDNS's structure for records.
Definitely let us know if you figure out the issue, that way can look to see if we can add something into OctoDNS to handle these cases.

Yeah look at my comment in #248. I think cloudflare made a change. Try manually changing the MX priority within the cloudflare portal manually. Change it to anything other than 0, then use octodns to change it back to what you intend.


Usage of ffmpeg cli switches instead of fluent interface

We receive ffmpeg command line switches from a server like .e.g.
-s 1920x1080 -movflags faststart -r 25 -c:v libx264 -preset superfast -b:v 4000k -minrate 3000k -maxrate 5000k -bufsize 13000k -pix_fmt yuv420p -c:a aac -b:a 128k -avoid_negative_ts 1
Is it possible to convert such a string to a node-fluentf-fmpeg command or poss it directly to the ffmpeg binary?
Version information

fluent-ffmpeg version: latest
ffmpeg version: latest
OS: all

You could just split them up and push them into an array. See https://github.com/fluent-ffmpeg/node-fluent-ffmpeg#outputoptionsoption-add-custom-output-options :)
Otherwise you can use the Node.js child process API. Just be aware that you need to sanitize the arguments to not end up with RCE.


[Experiment] Hide ULX command messages

Hides ULX command messages, eg. !whip ^ 10 while still retaining ULX FancyLog messages, ie. You whipped Yourself 10 times with 0 damage.

QA Result: Passed ✅

Chat messages for commands are not shown ✅
Logs from commands are still shown ✅

I noticed some commands are missing a log (well, only freeze and unfreeze from testing). Don't think this is a blocker though.


GA release

Package name: @google-cloud/vision
Current release: beta
Proposed release: GA
Instructions
Check the lists below, adding tests / documentation as required. Once all the "required" boxes are ticked, please create a release and close this issue.
Required

[ ] 28 days elapsed since last beta release with new API surface
[ ] Server API is GA
[ ] Package API is stable, and we can commit to backward compatibility
[ ] All dependencies are GA

Optional

[ ] Most common / important scenarios have descriptive samples
[ ] Public manual methods have at least one usage sample each (excluding overloads)
[ ] Per-API README includes a full description of the API
[ ] Per-API README contains at least one “getting started” sample using the most common API scenario
[ ] Manual code has been reviewed by API producer
[ ] Manual code has been reviewed by a DPE responsible for samples
[ ] 'Client LIbraries' page is added to the product documentation in 'APIs & Reference' section of the product's documentation on Cloud Site

@bcoe we need to make a call on #465 here.  I am cool with adding mixins to help do common tasks, but I really want to avoid custom/mutating code for GAPIC generated libraries.  It just don't scale.


Modify findTransformECC to support a mask of pixels to consider

Tests of the mask are also included.
This is useful for registering a non-square image against a non-square template.

@ellbur, thank you for the contribution! and terribly sorry for delay; I finally got to this PR. Please, see my comments to the code

:+1:


ROS2: Symlinking for colcon build

Fixes some problems with having two srcs in the same folder.
To-Do/Fix:  figure out a way to run the symlink script automatically at build stage. I've found this:
https://colcon.readthedocs.io/en/released/user/configuration.html?highlight=colcon.pkg#colcon-pkg-files
...but didn't make something working with it. @trey0 in case you want to check?

Fixed @marinagmoreira , ready for merge


documentation about feature gates

I find myself referencing this forge article a lot:
~https://forge.rust-lang.org/feature-guide.html~
EDIT (mark-i-m): this moved to https://rust-lang.github.io/rustc-guide/implementing_new_features.html
It's ok, but not great. Some things I would like to see covered in rustc-guide instead (and then perhaps remove that article):

[x] how to add a feature gate in the code

[x] how to add a test covering your feature gate

[ ] how to change for simple syntactic things
[x] how to do more advanced gates by looking at sess.features.your_feature_here as a boolean

Also, how to stabilize. And then maybe we can get rid of that forge article too...

how to change for simple syntactic things

@nikomatsakis Could you clarify what you mean by this? Do you mean warning cycles and future compat lints?

For anyone else coming here from google and looking for where the above link moved to: https://rust-lang.github.io/rustc-guide/implementing_new_features.html

Thanks @alecmocatta
Updated above.

@Centril Do you happen to know what the procedure is for this (from Niko's post above):

how to change for simple syntactic things

@mark-i-m It's documented in https://rust-lang.github.io/rustc-guide/implementing_new_features.html :)

Oh, lol ok. I will close this issue then!


Reduce method visibility

Yet another of trivialities I'm spotting as I'm close-reading the code...

Thanks, @adambaratz. Trivial fixes are very welcome. Let me know if you have any questions as you read through the code.


fix: ContainerRegistryURL to template <CONTAINER_REGISTRY_URL> in association with -p containerRegistryURL usage

This is an example fix for a problem involving the composition of FQINs for the metaphor image from subcomponents.
It has been tested with GKE + ghcr in particular, but may break other instances where <CONTAINER_REGISTRY_URL> is used if it were to be replicated there without testing. So, this PR is restricted to gcp for now.
It might also be reasonable to consider something like https://github.com/kubefirst/gitops-template/pull/549 if the pattern platform-registry analogous to gcp-github would also attempt to account for aws-ecr and gcp-gar as appears to currently be the case for aws-github.

Given a FQIN for a ghcr-hosted container image constructed of subcomponents

URL
ghorg
repo

tag

ghcr.io
kubefirst
metaphor
:
8aea8

we could define CONTAINER_REGISTRY_URL=URL/ghorg among any other reasonable composition of subcomponents into composite variables so long as they are used consistently.
ContainerRegistryURL needs to be defined such that it generates the correct value in gitops-template/gcp-github/ci/.github/workflows/main.yaml#L5 relative to it's usage in gitops-template/gcp-github/ci/.github/workflows/main.yaml#L53. There are analogs to this for the other provider-registry combinations, but gcp and aws are special cases as there's an attempt to support their respective internal registries in addition to the associated git providers. This may need to be revisited in the near future, but CONTAINER_REGISTRY_URL=URL/ghorg may work well enough for now.

Thanks a lot for this PR @cameronraysmith! Someone from the engineering team will review it shortly.

@cameronraysmith: just noticed it's in draft state, but I assume from Slack that it was ready to be reviewed, can you let me know if it's the case or not please?

Followed by #1797 for aws.


Can't use --eta argument with celeryctl

It doesn't seem to be possible to use the --eta argument with celeryctl because the string value is never converted to a datetime, but some parts of celery assume that it is a datetime:
$ py manage.py celeryctl apply --eta=$(date) asdf
...lib/python2.6/site-packages/piston/oauth.py:42: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
  self.message = message
...lib/python2.6/site-packages/piston/authentication.py:142: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
  response = HttpResponse(err.message.encode('utf-8'))
Traceback (most recent call last):
  File "manage.py", line 18, in <module>
    execute_manager(settings)
  File "...lib/python2.6/site-packages/django/core/management/__init__.py", line 438, in execute_manager
    utility.execute()
  File "...lib/python2.6/site-packages/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "...lib/python2.6/site-packages/djcelery/management/commands/celeryctl.py", line 26, in run_from_argv
    util.execute_from_commandline(self.handle_default_options(argv)[1:])
  File "...lib/python2.6/site-packages/celery/bin/base.py", line 72, in execute_from_commandline
    return self.handle_argv(prog_name, argv[1:])
  File "...lib/python2.6/site-packages/celery/bin/celeryctl.py", line 340, in handle_argv
    return self.execute(command, argv)
  File "...lib/python2.6/site-packages/celery/bin/celeryctl.py", line 330, in execute
    cls(app=self.app).run_from_argv(self.prog_name, argv)
  File "...lib/python2.6/site-packages/celery/bin/celeryctl.py", line 73, in run_from_argv
    self(*args, **options.__dict__)
  File "...lib/python2.6/site-packages/celery/bin/celeryctl.py", line 47, in __call__
    self.run(*args, **kwargs)
  File "...lib/python2.6/site-packages/celery/bin/celeryctl.py", line 170, in run
    expires=expires)
  File "...lib/python2.6/site-packages/celery/app/base.py", line 227, in send_task
    return result_cls(new_id)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)
  File "...lib/python2.6/site-packages/celery/app/base.py", line 287, in default_connection
    yield connection
  File "...lib/python2.6/site-packages/celery/app/base.py", line 224, in send_task
    expires=expires, **options)
  File "...lib/python2.6/site-packages/celery/app/amqp.py", line 215, in delay_task
    eta = eta and eta.isoformat()
AttributeError: 'str' object has no attribute 'isoformat'

Does ask/celery@27ab2111b04a8b5e4e45c638c6b463e699f99ed9 fix this for you?  With this change --eta must be an ISO 8601 formatted date.  If you need an int/float use --countdown.


CsvAgent encoding issue when consuming events from FtpsiteAgent

Test details

tested on everything up to 0d4695ddf499c3639099394676803689e9da22ea

Description
IS

Issue with transforming encoding from ASCII-8BIT to UTF-8

SHOULD

handle encoding issues gracefully by automatic encoding conversion prior to event handling

Steps to reproduce

set up FtpsiteAgent to emit events which are consumed by a CsvAgent
trigger scenario by adding a file to watched FTP directory
will produce exception during receive. See stacktrace:

Exception during receive. "\xC3" from ASCII-8BIT to UTF-8: /Users/dw/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/core_ext/object/json.rb:34:in `encode'
/Users/dw/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/core_ext/object/json.rb:34:in `to_json'

@davidwabnitz Can you upload the CSV file you used?

When reading the data directly from the FTP client we can not automatically detect the encoding, when reading non UTF-8 encoded files the force_encoding option needs to be set.

closing as fixed


Export-Excel using both -Title and -Tablestyle to separate worksheets creates a corrupt xlsx file.

Like the title says :) nothing more to it than that :)
Data is appended through a script to the file. It also happens when i export all data at once doing the same (title and Tablestyle)
It works fine when you only use 1 worksheet.

Please post a repro.

I was working on this but i found what was the problem so i can prevent it from happening.
What i am doing is get tables from SQL with a query (using powershell) and then export that to an excel worksheet using an foreach (some conditions) loop. I did not check if the result was empty or not - i simple did the export-excel with the append switch. That all worked fine, but as soon as i started to use a tablestyle i got a corrupt xlsx as a result.
Now i check if the variable has any info in it and then i use export-excel, and just do nothing when it doesnt have any data. This fixed the problem for me.

sorry for the late reply ;)

No problem. Thanks for reporting it and the update.


Run as this user... bug?

Brief description of your issue
When i want run cmd as another user in Windows Server 2019 i get black screen cmd which works but i can't see what i type in this window.

Steps to reproduce (optional)

Search explorer.exe process of another user

Run as this user CMD in your session

You get so cmd screen (it works but you can't see it in your session)

Expected behavior (optional)
Normal cmd graphic
Actual behavior (optional)
cmd with black screen but works i written in die cmd   whoami > c:\test.txt answer was impersonated username

Environment (optional)
SystemInformer 3.0.9873.5346 self compiled today from main
Windows Server 2019

SystemInformer 3.0.9873.5346 self compiled today from main

Can you try the latest stable v2.39 and confirm it also has the same issue?
https://processhacker.sourceforge.io/downloads.php
The nightly is using an entirely different runas implementation which might be missing support for RDP and it would help to know if those versions are working or if all versions have the same issue.

The screenshot looks very much like starting a process with a logon SID in its token that doesn't match the current window station's SID. Just saying.

@diversenok The current desktop DACL doesn't have enough privileges for the administrator by default and there wasn't any error message. I've fixed this in the latest nightly.

Interesting, I didn't notice that admins don't get full access to the window station/desktop. What I meant with the previous comment is that during logon, winlogon assigns the current window station and desktop the logon SID from the session's token (we can observe it via GetUserObjectInformation with UOI_USER_SID). It also adds a full access ACE with this logon SID into the DACLs.
@dmex Maybe we should use the same logic and add an ACE with the logon SID of the new token/process instead of granting access to Everyone. We can get the new logon SID directly from LogonUserExExW or read it from the new process's token before it starts.


https://m.facebook.com/profile.php?id=100086411012865&eav=AfZV4Xt63Ey…

…zRRwfN4jvfJ1Snt0sgXn9PO2yyH0Fx_Uo79Fu11dhB1yFleub6cbBZsU&paipv=0&mds=%2Frapid_report%2F%3Fcontext%3D%257B%2522session_id%2522%253A%2522b815879b-daaa-4045-824a-9214c6238e38%2522%252C%2522type%2522%253A2%252C%2522story_location%2522%253A%2522profile_someone_else%2522%252C%2522entry_point%2522%253A%2522profile_report_button%2522%252C%2522reportable_ent_token%2522%253A%2522100086411012865%2522%257D%26av%3D100028667393946%26__xts__%255B0%255D%3D78.%257B%2522app_id%2522%253A333176286769482%252C%2522profile_id%2522%253A100086411012865%252C%2522action%2522%253A5%257D&mdf=1
اخبار

Is this like… the mother of all suspicious links?

Is this like… the mother of all suspicious links?

Looks like microsoft's promotion for "branch protection rules". Nice try, meah...))


Feat/470 user panel api token

What this PR does / why we need it:

This is the initial work for the user panel in the SPA.
This work will include:
Add links to the user panel in the User dropdown from the application header.
Add routing to the user panel.
Create 4 tabs panel with tab open by default according to url query param.
Only the API Token tab content will be created, the rest of the tabs will remain empty for now, maybe disabling tabs.
Note that this is only UI work, it wont show real info about API token yet.

This part of the documentation Users Token Management could be useful for developing use cases for managing api tokens from the SPA.
Which issue(s) this PR closes:

Closes #470

Special notes for your reviewer:
The rest of the tabs are disabled, only the API Token tab is enabled.
Also the Recreate Token and Revoke Token buttons are disabled.
Suggestions on how to test this:
Step 1: Run the Development Environment

Execute npm i.
Navigate with cd packages/design-system && npm run build.
Return with cd ../../.
Ensure you have a .env file similar to .env.example, with the variable VITE_DATAVERSE_BACKEND_URL=http://localhost:8000.
Navigate with cd dev-env.
Start the environment using ./run-env.sh unstable.
To verify the environment, visit http://localhost:8000 and check your local Dataverse installation.

Step 2: Test the feature
This is only UI work, but couple things could be tested.

Check that you navigate successfully to the Account page with the apiToken tab selected by default when clicking on the Api Token item on the user dropdown in the header.
Check that the fake api token is correctly being copied to the clipboard

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

I added a basic story, when we integrate with the use cases we will be able to mock responses to show different scenarios.
I think is ready for review now @ekraffmiller

Hi German! I noticed that even without logging in, I was able to access the API token page by directly navigating to 'http://localhost:8000/spa/account?tab=apiToken'. Should we implement some measures to prevent unauthorized access to this page?

I noticed that even without logging in, I was able to access the API token page by directly navigating to 'http://localhost:8000/spa/account?tab=apiToken'. Should we implement some measures to prevent unauthorized access to this page?

Hi @ChengShi-1, yes, that is going to be solved when me merge the Private Routes Guards PR