[REF-2157] rx.download doesn't work with rx.get_upload_url from a backend event handler

Describe the bug
I want to write a file to a path obtained via rx.get_upload_dir() and then cause the user to download it via rx.download, but it doesn't work.
To Reproduce
import reflex as rx

class State(rx.State):
    button_text: str = "Download"
    def do_download(self):
        filename = "foo.txt"
        (rx.get_upload_dir() / filename).write_text("test")
        return rx.download(rx.get_upload_url(filename))

@rx.page()
def index():
    return rx.button(State.button_text, on_click=State.do_download)

app = rx.App()

Expected behavior
Download the file that we write in the event handler
Instead, exception
Traceback (most recent call last):
  File "/Users/masenf/code/reflex-dev/reflex/reflex/state.py", line 1439, in _process_event
    events = fn(**payload)
             ^^^^^^^^^^^^^
  File "/Users/masenf/code/reflex-dev/repro-download-from-upload-dir/repro_download_from_upload_dir/repro_download_from_upload_dir.py", line 8, in do_download
    return rx.download(rx.get_upload_url(filename))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/masenf/code/reflex-dev/reflex/reflex/event.py", line 589, in download
    raise ValueError("The URL argument should start with a /")
ValueError: The URL argument should start with a /

Specifics (please complete the following information):

Python Version: 3.11.4
Reflex Version: 0.4.4a1
OS: macOS
Browser (Optional):

Additional context
Add any other context about the problem here.
REF-2157

hello, is it possible that this is no longer working with more recent versions? i can download a file in "/assets" but not in "/uploaded_files" using a very similar code to what you have in the bug description. thank you

hello, is it possible that this is no longer working with more recent versions?

yes it appears to be broken in 0.6.0+


Cannot type into text input on jqModal dialog when modal set to true

I recently upgraded jqModal from r14 to r24.
I'm experiencing the same issue described in this Stack Overflow question: http://stackoverflow.com/questions/29395113/cannot-type-into-text-input-on-jqmodal-dialog-when-modal-set-to-true and the same fix (comment out modal:true).
However, since we are on r24, I'm confused, since your Stack Overflow answer indicates that it was fixed in r23.
Additionally, this changes the functionality of the software I'm writing, since clicking outside the modal didn't previously close the modal. This may or may not be a big deal to the product owners, but I wanted to open this issue to hopefully get some more information before approaching them about it.
Thanks,
Matt

This should be closed - the issue was with our custom code wrapping jqModal, not jqModal itself.
Turns out we had a piece of code that was clearing and resetting the CSS class list for the popup window div. This worked fine in older versions of jqModal, but r23 added a "jqm-init" class that is used by the code that manages the focus event. Since we were inadvertently removing that class, we were  ultimately creating an endless focus loop.
Once we started preserving the "jqm-init" CSS class everything worked perfectly.

:+1:


Travis

This pull request is to get Travis setup. If Travis is able to pass its test and work correctly. Then Carlos will verify the pull request before it is merged. If there is an issue with Travis I will need to update this pull request.

Okay so appears Travis is having a few issues. I will need to review the errors and adjust the code.


Take steps to reduce database queries

Proposes the following:

[ ] Allow the transform func caller to specify an arbitrary number of fields they wish to receive alongside just the name.

Do not rely on discord by storing the metadata for tags in the resulting options themselves. An alternative suggestion is to store a dictionary like we have with kona searching for bookmarks.

[ ] Remove the ability for users to provide the new content to edit the tag with OR find a better route of dealing with the situation. Removing the parameter is a big cost to UX especially if it is only a short amount of content to update to.

It would also be nice if something similar happened to item input transformers. For instance, we retrieved more fields about the item such as whether it is available in the shop at once.

[ ] Deal with #168

In general, you want to have functions that return the same type and the same thing every time.
Dynamically changing the return type based on the inputs makes debugging more difficult from my experience. If we want to implement these features, it needs to be thoroughly battle tested. Many days of writing the code, and many weeks of testing and iterating over our code design choices and mistakes.
I cannot recall seeing instances of functions by others where the return type and input types are both dynamic in anyone else's code, though in some functions of our code we already have this practice in place (in particular the SQL table query updating functions).

In general, you want to have functions that return the same type and the same thing every time.
Dynamically changing the return type based on the inputs makes debugging more difficult from my experience. If we want to implement these features, it needs to be thoroughly battle tested. Many days of writing the code, and many weeks of testing and iterating over our code design choices and mistakes.
I cannot recall seeing instances of functions by others where the return type and input types are both dynamic in anyone else's code, though in some functions of our code we already have this practice in place (in particular the SQL table query updating functions).

So in reality the return types are not actually dynamic. The transform function instead returns a tuple containing sqlite3.Row and the interaction instead of just the tag name (str) and interaction. The columns that will appear are the only things which change but the return type is always the same. This approach is good for now as you can access a field value easily by using the index (provided you know the location of the field you want to get which is faster) or the name of the column when the query is made. Former is simplistic, latter is more readable. We will use both depending on the circumstances.

The PR is not yet ready but @serephenna can you review the current changes.
I most likely will not be able to continue with the other pending tasks until the following Friday.

Second task is no longer planned, causes problems for specific commands like the item command where it needs access to many details about the item across multiple tables.


I think i found a bug, as well as a fix.

The case is pretty specific, but none the less quite important for Jessecar96 steambot.
I feel like its quite common that steam web api returns an internal error 500 when trying to accept a tradeoffer. I guess you cant really do anything about this. But what i noticed was that a tradeoffer which fails on accepting, will not be handled again before the bot restart.
I've been looking a little into the code, and as far as i can see the problem is cause by:
In TradeOfferManager method SendOfferToHandler(Offer offer), and the hashset: tradeOfferHistory.
So everytime a new tradeoffer is recieved, it is added to the tradeOfferHistory hashset. This is done before the we handle the tradeoffer, so in case the tradeoffer, does not go as planned (an exception is thrown), we will not revisit this specific offer even though we never finished it. (I dont know what the purpose of this hashset is?),
 private void SendOfferToHandler(Offer offer)
 {
        var tradeOffer = new TradeOffer(session, offer);
        tradeOfferHistory.Add(offer.TradeOfferId);
        OnNewTradeOffer(tradeOffer);
  }

If we look at both GetTradeOffersSince() and GetActiveTradeOffers() they have this statement:
 if (offer.TradeOfferState == TradeOfferState.TradeOfferStateActive && !tradeOfferHistory.Contains(offer.TradeOfferId))

Which shows us that an already "handled" offer will not be handled again.
Im not 100% sure about this, but i wanted to share this with you, as it is causing me problems right now. I've not tried a fix for this yet. First i wanted to make sure that im correct about this, and it actually is this, that is causing the problem.
The fix though, would simply be to switch lines between tradeOfferHistory.Add(offer.TradeOfferId) and OnNewTradeOffer(tradeOffer)

i test this atm but i think its only a misstake not a bug ^^

Well i can tell you that switching those lines will give this error:
ERROR: System.NullReferenceException: Object reference not set to an instance of an object.
   at SteamBot.DepositTradeOfferUserHandler.OnNewTradeOffer(TradeOffer offer)
   at SteamBot.Bot.TradeOfferRouter(TradeOffer offer)
   at SteamTrade.TradeOffer.TradeOfferManager.SendOfferToHandler(Offer offer) in c:\Users\A\Desktop\SteamBot-master\SteamTrade\TradeOffer\TradeOfferManager.cs:line 142
   at SteamTrade.TradeOffer.TradeOfferManager.GetTradeOffersSince(Int32 unixTimeStamp) in c:\Users\A\Desktop\SteamBot-master\SteamTrade\TradeOffer\TradeOfferManager.cs:line 87
   at SteamTrade.TradeOffer.TradeOfferManager.GetOffers() in c:\Users\A\Desktop\SteamBot-master\SteamTrade\TradeOffer\TradeOfferManager.cs:line 113
   at SteamBot.Bot.<HandleSteamMessage>b__10(NotificationCallback callback)
   at SteamKit2.CallbackMsgExtensions.Handle[T](ICallbackMsg msg, Action`1 handler)
   at SteamBot.Bot.HandleSteamMessage(ICallbackMsg msg)
   at SteamBot.Bot.BackgroundWorkerOnDoWork(Object sender, DoWorkEventArgs doWorkEventArgs)

Was this error the succes case, or in case you got an internal 500 error?

The reason for logging previous trade offers is simple - it allows you to ignore them completely. If SteamBot didn't do this, the same trade offer would appear over and over on every trade poll.

But isnt the purpose of GetTradeOffersSince to do that? The first method to handle tradeoffers look like this:
 public bool GetOffers()
    {
        if (LastTimeCheckedOffers != 0)
        {
            bool action = GetTradeOffersSince(LastTimeCheckedOffers);

            if (action)
                LastTimeCheckedOffers = GetUnixTimeStamp();
            return action;
        }
        else
        {
            bool action = GetActiveTradeOffers();
            if (action)
                LastTimeCheckedOffers = GetUnixTimeStamp();
            return action;
        }
    }

I thought the purpose of all this was not to keep going around the same trade offers?
But i assume that there was some problems with this, since they added the hashmap. But never the less, i would still say that my fix fixes the problem, as the trade offer should only be marked as done when its actually done

Well, I suppose only @StormReaper know why he added it. :grinning:

Yup. There is one thing i can think off, but i dont know if its possible.
Can a tradeoffer be corrupt? In this case, adding the offer to the hashmap before handling the offer makes perfect sense. But in any other case, i think its better to add the offer to the hashmap after you are doing handling it

No, tradeoffers cannot be corrupt. They can arrive to you corrupted due to your connection/valve servers sending malformed data. I'd validate the offer after sending the .Accept() method through. I'll talk about this more tomorrow though. School n' shit

Let me elaborate on the snipper posted above as it's fairly easy to understand.
Upon startup, the bot has its LastTimeCheckedOffers timestamp set to zero, which is a (afaik) millis-since-1970 format. If it's zero, then the bot does a full scan of all ACTIVE offers. If it has a value other than zero, this means offers have been fetched at least once during this session, and it will instead get offers that arrived since the timestamp the offers were last fetched.
As for the "offer unavail. for handling if Steam 500's while accepting" - that's up to YOU to take care of. It's a Steam bug, more than a Bot bug. If you press "Accept offer" on steam you would expect the offer to be accepted, but sometimes Steam says "fuck you" and errors out. You then retry accepting.
Overall there are two solutions to this:
One is to manually validate if the offer was actually changed by Steam's backend after you sent them a signal.
Another is to modify the bot's core code to look out for that, and retry accepting/declining if no valid response is returned after requesting a change within the offer object.


unexpectedly found nil while unwrapping an Optional value

"direct field offset for BTNavigationDropdownMenu.BTNavigationDropdownMenu.(configuration in _2FD11A7176F1278EC9F8CADD0C8AF5A3) : BTNavigationDropdownMenu.BTConfiguration"
Over and Over again facing this issue.Whenever trying to initialize this issue occures.

@Sadmansamee Have you resolved this issue yet?

@Sadmansamee: could you share the way you solve this issue, I believe it could help others facing the same issue.


 in  missing md css style

Short description of the problem:
<ion-toolbar color="dark">
  <ion-searchbar></ion-searchbar>
</ion-toolbar>

What behavior are you expecting?
The search bar should have a dark background, but now it's all white.
There is a rule for ios: .toolbar-ios-dark .searchbar-ios .searchbar-input, which works fine after ported to md mode.
Which Ionic Version? 1.x or 2.x
v2 rc1
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.1.1
Gulp version:  CLI version 1.2.2
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-rc.1
Ionic CLI Version: 2.1.1
Ionic App Lib Version: 2.1.1
Ionic App Scripts Version: 0.0.36
OS: Windows 7 SP1
Node Version: v4.3.1

Hey, thanks for the issue! I'm not sure if I understand the problem. Are you saying the Material Design searchbar should have a dark background when placed inside of a dark toolbar? So you want this:

to look more like iOS?

Oh! A flash! I was engulfed by the fruit. Now I got the point. But frankly,
it's a bit too outstanding to have a white search box over on a dark
screen. Especially when I'm in dark, that white box jump out and hurt my
eyes a bit.


Export as CSV button only works on Chrome

The export as CSV button introduced in https://github.com/lmenezes/elasticsearch-kopf/pull/323 apparently does not work in Firefox. Perhaps this is something to do with the angular app, perhaps it has something to do with the implementation of the button in the controller. Or perhaps the underlying jquery csv libraries are missing something.
This isnt a major issue, just making a note of it here.

@kaustavha thanks again :)


Is there a way to filter by cloud cover ?

I'm looking through your functions, is there a way to filter by cloud cover ?
Trying to get the latest tile with cloud cover between 0-5%
Thank you

No, not yet. You are welcome to contribute to this project.

thanks for the quick response, i'll let you know if i figure it out :)

Any hints on where I should look, how this could fit into the project ?

Thinking about it.. perhaps it would be worth to wait a few weeks as we will most probably establish an OpenSearch interface, which one will be able to query to get information about the catalogue. I cannot state exactly, when this will happen as it does not depend solely on us, but should be soon.
Until that moment, the only option is to crawl all possible dates within specific tile and check tileInfo.json file, which includes information about meta-data.

Thanks, I will look into it and see if i can do something.

Hi attibalazs,
I think it would be possible to add cloud cover filter to current script with not much work. I suggest the following:

cloud cover can be obtained from tileInfo.js files (attribute cloudyPixelPercentage)
Class SafeTile() in aws.py file already collects tileInfo.js file and stores it into self.tile_info. There you can extract the cloud cover percentage.
In the beginning of get_structure() method of SafeTile() class you can add condition to return empty dict if cloud cover percentage is to high. This way script will only download tiles with specified max cloud percentage.
the rest should be easy ...

Feel free to make any contributions to project. :)

@AleksMat thanks for your comment, I just saw it, my approach is a bit cruder, I'll try to refine it using your suggestion. This is what I have so far, I didn't need to change your library with this approach.
def get_sentinel2_data(tile, data_folder, cloud_cover_max):

    # initalize tile
    safe_tile = SafeTile(tile_name=tile[0], date=tile[1])

    # get cloud cover percentage
    tile_info = safe_tile.get_tile_info()
    cloud_cover = tile_info['cloudyPixelPercentage']

    # check if is below the limit
    if cloud_cover <= cloud_cover_max:
        sentinelhub.download_safe_format(tile=tile, entire_product=True, folder=data_folder)
    else:
        logging.warning('cloud cover is {0} which exceeds the acceptable value of {1}'.format(cloud_cover, cloud_cover_max))

Thank you, we hope it will be useful for other users as well.


Debugger for Chrome does not open with recommended React configuration

VSCode Version: 1.26.1
OS Version: i3 Arch Linux
So I have configured the launch.json of my project like it suggests here: https://code.visualstudio.com/docs/nodejs/reactjs-tutorial#_debugging-react

I have also added "runtimeExecutable": "/usr/bin/google-chrome-beta" to the configuration as I have the beta version of Chrome (I have already tested with the stable version as well). When I set a breakpoint in a random component and click on debug (with npm start running on 3000 already), a about:blank page opens, and a few seconds later I get a notification on vscode saying
Cannot connect to runtime process, timeout after 10000 ms - (reason: Cannot connect to the target: connect ECONNREFUSED <IP_ADDRESS>:9222).
Does this issue occur when all extensions are disabled?: Yes
This is my launch.json
{
  "version": "0.2.0",
  "configurations": [{
    "name": "Chrome",
    "type": "chrome",
    "request": "launch",
    "url": "http://localhost:3000",
    "webRoot": "${workspaceRoot}/src",
    "sourceMapPathOverrides": {
      "webpack:///src/*": "${webRoot}/*"
    },
    "runtimeExecutable": "/usr/bin/google-chrome-beta"
  }]
}```

See this section of the readme: https://github.com/Microsoft/vscode-chrome-debug#cannot-connect-to-the-target-connect-econnrefused-1270019222
If you already have an instance of Chrome running, you may want to configure a new user-data-dir or set "userDataDir": true.


Fix TextBox cursor positioning

Fixed the cursor positioning in the TextBox which seems to work mostly correctly now.  Still have a problem on my keyboard with the numeric keypad seeming to always give numeric keys regardless of the num lock state.  Might look into that next.

You opened the wrong source branch, you want to use your fixtextbox into my develop-7.3 😄 Dont worry, it took me a while to get used to this too..

Doh.  So another pull request I guess.

Yep :D


Python: MISHOTOKEN

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform

OS: [e.g. Windows, Mac]
IDE: [e.g. Visual Studio, VS Code]
Language: [e.g. C#, Python]
Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Add any other context about the problem here.

I dont see any action here, will be closing. Please provide more context if we need to take further investigation.


HotShotHandle::clone loses buffered events

handle and handle.clone() are not perfect substitutes for each other, because handle.next_event() will return an event which was previously buffered, while handle.clone().next_event() will return the next event emitted after the clone. This is especially tricky at startup, because handle.start() emits a Decide event for the genesis block, so the following seemingly equivalent programs are actually very different:
A.
handle.start().await;
let genesis_event = handle.next_event().await;

B.
handle.start().await;
let not_genesis_event = handle.clone().next_event().await;

I'm not sure exactly what the best way to fix this is, but it's definitely a sharp edge that I've run into a few times. See EspressoSystems/espresso-sequencer#319.

This issue no longer exists since the event stream has been decoupled from the handle. It is explicit now that you won't get any events emitted before you called get_event_stream, which I think is a reasonably intuitive behavior.


Allow checks to show "failed due to permissions" instead of not running any of it

In many environments, an admin is not an admin of the whole Azure SQL server and only the DB; or a developer wants to validate the database level items only.
The script as-is fails if any system view is not accessible without allowing us to run checks against a database. Splitting these into two catch blocks and simply show the checks that failed due to permissions will still offer users the ability to see improvements/things to fix instead of not knowing any of them.

I adjusted this script to remove the try/catch so I can see what returns just for the database level and I only see it return compatibility warning and just returning query hashes for "top queries" to check.
It would be nice if the tips table was expanded to include which checks apply to Azure SQL DB, MI, or both. I'm sure that is a vast difference in what can be checked based on the glance at the tips in the script.

I adjusted this script to remove the try/catch so I can see what returns just for the database level and I only see it return compatibility warning and just returning query hashes for "top queries" to check.
It would be nice if the tips table was expanded to include which checks apply to Azure SQL DB, MI, or both. I'm sure that is a vast difference in what can be checked based on the glance at the tips in the script.

Thanks for suggestions @wsmelton. Coincidentally :), the latest commit (yet to be released) adds support for running the script with only VIEW DATABASE STATE permission that a database owner would have, and without any server-level permissions. The wiki has been updated accordingly.
The suggestion of showing which tips were not evaluated because of insufficient permissions is great, we will add that. Right now there is just one tip like that, but that could change.
It is entirely possible that the script will return just a few tips, or no tips (see this question in FAQ).
Currently, the script is written for SQL DB, there are no MI-specific tips (see here). This may change in the future (ideas for MI-specific tips are welcome), and in that case we should indeed add an applies_to column. If you think we should do it even now when the only values would be "SQLDB" and "SQLDB/SQLMI", we could consider that too.

Thanks for suggestions @wsmelton. Coincidentally :), the latest commit (yet to be released) adds support for running the script with only VIEW DATABASE STATE permission that a database owner would have, and without any server-level permissions. The wiki has been updated accordingly.
The suggestion of showing which tips were not evaluated because of insufficient permissions is great, we will add that. Right now there is just one tip like that, but that could change.
It is entirely possible that the script will return just a few tips, or no tips (see this question in FAQ).
Currently, the script is written for SQL DB, there are no MI-specific tips (see here). This may change in the future (ideas for MI-specific tips are welcome), and in that case we should indeed add an applies_to column. If you think we should do it even now when the only values would be "SQLDB" and "SQLDB/SQLMI", we could consider that too.

I'd likely go ahead and add the applies column now. This will help on the command for dbatools and give a nice filter that can be used with PowerShell output.
Identify which level the tips applies might be useful but may not be, have not run this on service I have higher privileges on yet.

I'd likely go ahead and add the applies column now. This will help on the command for dbatools and give a nice filter that can be used with PowerShell output.
Identify which level the tips applies might be useful but may not be, have not run this on service I have higher privileges on yet.

Regarding applies_to, can you clarify how that will help? I.e. if you run the script on DB, what's the usefulness in seeing that some returned tips happen to also apply to MI? And if you run it on MI, applies_to will be "SQLDB/SQLMI" by definition. Perhaps I am not seeing the scenario for this, an example will help.
Regarding permissions, this is a little bit more nuanced. Required permissions depend on the service objective. For Basic, S0, S1, and for all elastic pools, you do need VIEW SERVER STATE (thus server level access, though not necessarily server admin access, see Permissions in wiki) to query nearly all DMVs used in the script. I am not sure that it would be worthwhile running the script at all in that case if we only have VIEW DATABASE STATE - the output will be a long list of tips not evaluated due to insufficient permissions.

Regarding applies_to, can you clarify how that will help? I.e. if you run the script on DB, what's the usefulness in seeing that some returned tips happen to also apply to MI? And if you run it on MI, applies_to will be "SQLDB/SQLMI" by definition. Perhaps I am not seeing the scenario for this, an example will help.
Regarding permissions, this is a little bit more nuanced. Required permissions depend on the service objective. For Basic, S0, S1, and for all elastic pools, you do need VIEW SERVER STATE (thus server level access, though not necessarily server admin access, see Permissions in wiki) to query nearly all DMVs used in the script. I am not sure that it would be worthwhile running the script at all in that case if we only have VIEW DATABASE STATE - the output will be a long list of tips not evaluated due to insufficient permissions.

Just one right off...
Supporting the ability to use that SQL script in other tools as well or just in dbatools we support the ability to provide multiple servers and we execute that code against all of them. We format the output of SQL scripts to return a consistent output object or dataset.
If the user is running it across their enterprise of servers (Azure SQL DB/MIs) we could include a custom property that we maintain, but having the raw script handle that functionality makes it more consistent when another tool is used.

Just one right off...
Supporting the ability to use that SQL script in other tools as well or just in dbatools we support the ability to provide multiple servers and we execute that code against all of them. We format the output of SQL scripts to return a consistent output object or dataset.
If the user is running it across their enterprise of servers (Azure SQL DB/MIs) we could include a custom property that we maintain, but having the raw script handle that functionality makes it more consistent when another tool is used.

As a full example...I ran this against a database (that sadly I only have access to the DB and not server level but adjusted it where it would at least return something)...
This is the base output of the version I used:

Within dbatools, we will inject a set of base properties:

ComputerName
InstanceName
SqlInstance

I can inject another one such as ServiceType that injects either Azure SQL DB or Azure SQL MI (or the short terms you provided). This allows when users pass in 2 or 3 server names that may be mixed to filter based on just those easily. The alternative is they have to call the command 2 or 3 times vs. one.
Some of this is also to cover less experienced users that see the script and want to utilize it in their enterprise but are not aware of all the exact differences between SQL DB and SQL MI. I would see this script as something I might use when I'm brought into new environments or new DBAs are brought in to start managing an already existing environment. Being able to identify which tip is for both or each just makes it easier to focus from my point of view.

As a full example...I ran this against a database (that sadly I only have access to the DB and not server level but adjusted it where it would at least return something)...
This is the base output of the version I used:

Within dbatools, we will inject a set of base properties:

ComputerName
InstanceName
SqlInstance

I can inject another one such as ServiceType that injects either Azure SQL DB or Azure SQL MI (or the short terms you provided). This allows when users pass in 2 or 3 server names that may be mixed to filter based on just those easily. The alternative is they have to call the command 2 or 3 times vs. one.
Some of this is also to cover less experienced users that see the script and want to utilize it in their enterprise but are not aware of all the exact differences between SQL DB and SQL MI. I would see this script as something I might use when I'm brought into new environments or new DBAs are brought in to start managing an already existing environment. Being able to identify which tip is for both or each just makes it easier to focus from my point of view.

The last point is reasonable, we will add that column to the result.
Just to be clear, this will be purely informational. Nothing in the script logic will change based on whether it is running on DB or MI, so I am not sure how this new column will be useful in the dbatools scenario you described. In other words, regardless of platform (DB or MI), each produced tip will be relevant, so no additional filtering of the result set should be done.

The last point is reasonable, we will add that column to the result.
Just to be clear, this will be purely informational. Nothing in the script logic will change based on whether it is running on DB or MI, so I am not sure how this new column will be useful in the dbatools scenario you described. In other words, regardless of platform (DB or MI), each produced tip will be relevant, so no additional filtering of the result set should be done.

Linked PR adds support for returning at least some tips when you only have VIEW DATABASE STATE permission. There is a second result set returned listing the tips that weren't evaluated because of insufficient permissions. Please give this a try (just copy the latest code from the dfurman-dev-1 branch, there is not a release for this yet).
More on the applies_to: We can add the column to the tip definition table (@TipDefinition), which would make the code self-documenting, a useful thing from that viewpoint, but nothing more than that. I have a concern including this column in the output though. If a less experienced user sees that a tip applies to e.g. SQL DB, they might get an impression that it applies to all of SQL DB databases they have (or perhaps all similar databases, i.e. across different environments), while in reality it would only apply to the database where the script ran.
Also, if/when we add full support for MI tips, we are likely to do that in a separate script anyway; I expect the code will be substantially simpler that way compared to a lot of conditional processing. In that case, we'd need to deprecate this column, which could be problematic.
So for now I am leaning towards not adding that column, at least not until there is a clear scenario where it will be useful. Admittedly, I may not fully understand the dbatools scenario you mentioned (e.g. I don't understand what "inject a set of base properties" means in this context - not a PowerShell dev here). If you think I missed your point, please elaborate.
Thanks again for feedback and suggestions, please keep them coming.

Linked PR adds support for returning at least some tips when you only have VIEW DATABASE STATE permission. There is a second result set returned listing the tips that weren't evaluated because of insufficient permissions. Please give this a try (just copy the latest code from the dfurman-dev-1 branch, there is not a release for this yet).
More on the applies_to: We can add the column to the tip definition table (@TipDefinition), which would make the code self-documenting, a useful thing from that viewpoint, but nothing more than that. I have a concern including this column in the output though. If a less experienced user sees that a tip applies to e.g. SQL DB, they might get an impression that it applies to all of SQL DB databases they have (or perhaps all similar databases, i.e. across different environments), while in reality it would only apply to the database where the script ran.
Also, if/when we add full support for MI tips, we are likely to do that in a separate script anyway; I expect the code will be substantially simpler that way compared to a lot of conditional processing. In that case, we'd need to deprecate this column, which could be problematic.
So for now I am leaning towards not adding that column, at least not until there is a clear scenario where it will be useful. Admittedly, I may not fully understand the dbatools scenario you mentioned (e.g. I don't understand what "inject a set of base properties" means in this context - not a PowerShell dev here). If you think I missed your point, please elaborate.
Thanks again for feedback and suggestions, please keep them coming.


Fix typo

@stuartleeks,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@stuartleeks : Thanks for your contribution to the Azure documentation! The author, @azdocprs, has been notified to review your proposed change.

@AndrewHoh Please review these proposed changes. Thanks.

@jomolnar Looks good.

@stuartleeks Thanks for  the contribution. @AndrewHoh If you work on other pull requests in this repository, please sign off so that automation can add the appropriate label. Thanks again.


Updated cockroach demo connection parameters

Fixes https://github.com/cockroachdb/docs/issues/9634.
Fixes https://github.com/cockroachdb/docs/issues/9541.
Fixes https://github.com/cockroachdb/docs/issues/9635.
@ianjevans This might also fix https://github.com/cockroachdb/docs/issues/9898... only thing is that we still have a "port" placeholder in like half of the hello world samples (e.g., https://github.com/cockroachlabs/hello-world-go-pgx/blob/master/main.go#L37).

This change is


Save object if modified in async rules

Ref

https://nanopay.atlassian.net/browse/NP-6128

Issues

Unlike async rules where the object would be automatically saved if modified, the async rules require explicit dao.put() call to save the object.

Changes

Handle saving the object if it was modified in async rules

I don't like this. This is the same issue as any one rule.
We just need an async coding convention whereby if you put, do a find first.


Make Conn fully net.Conn compatible

Implement Read/WriteDeadline
Return remained data on Read after Close
Move network related internal packages under internal/net/
Test using nettest.TestConn

Reference issue
related: #148

passed nettest.TestConn

Codecov Report

Merging #184 into master will increase coverage by 1.42%.
The diff coverage is 91.11%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage    72.6%   74.02%   +1.42%
==========================================
  Files          60       61       +1
  Lines        3431     3523      +92
==========================================
+ Hits         2491     2608     +117
+ Misses        649      629      -20
+ Partials      291      286       -5

Flag
Coverage Δ

#go
74.02% <91.11%> (+1.42%)
:arrow_up:

#wasm
?

Impacted Files
Coverage Δ

internal/net/deadline/deadline.go
100% <100%> (ø)

conn.go
81.85% <77.41%> (+4.35%)
:arrow_up:

listener.go
57.89% <83.33%> (ø)
:arrow_up:

internal/net/udp/conn.go
81.96% <85.71%> (ø)

internal/net/dpipe/dpipe.go
96.47% <96.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b80bd9...4fd3cb7. Read the comment docs.

I set branch of the dtls module to this at https://github.com/pion/webrtc/pull/1004. All tests seem working correctly.

Ah excellent. :shipit:

rebased


Attaching meta data to a Connection

We implement a custom Connect (well tower::Service) in our proxy and I'm trying to figure out if it's possible to carry information from the established connection to the Response?
Our use case is: We load balance connections from the Connect implementation. The chosen backend has a unique identifier which we use as labels for our metrics. I can't record our "http response time" metric labeled with this backend identifier.
Is it currently possible to attach meta data? If not, is there a way to work around this?

https://docs.rs/hyper/0.13.3/hyper/client/connect/struct.Connected.html#method.extra

@sfackler Thanks, I looked for it, but probably with the wrong keywords.


[Bug] Icon on workspace desktop are not being added and drag functionality on desktop doesnt exist on newly installed

Description
Hi, I'm new to the whole Linux thing, and i've just installed an ArchLinux distro followed a couple of step by step guides and it seems to be fine when I'm not using budgie.
Desktop Icons are not being shown as default on an Archlinux and when the toggle changes in budgie-desktop-settings nothing happens. after installing budgie-extras which is not recommended in ArchWiki  the icons will be shown on the desktop but frozen in place and there is no drag functionality on the workspace which again works in nautilus file manager installed.
Here's a picture of the current desktop icons that are clickable and functional but not draggable.
I'm a newbie so apologies if I'm Mistaken.
Budgie version
10.8
Operating System
ArchLinux rolling on X11 windowing system
Steps to reproduce the issue
follow the manual installation of budgie on Arch Linux guide on buddiesofbudgie.org
Actual result
drag functionality doesnt work.
when mouse inits mousedown on desktop the box that should show doesnt come up and workspace doesnt register anything
also the icons on the desktop arent being highlighted or draggable by mouse down event.
Expected result
drag box should appear on a mousedown event on an empty space in desktop environment.
icons should be able to move around on desktop environment upon registering a mousedown event.
icons should register highlight on mousedown event like when tab button is used to gain focus.
Additional information
No response

Budgie Desktop View does not support arbitrary locations for desktop icons and the feature is not planned. Nautilus hasn't had a desktop icons implementation for many years now and isn't even the default file manager on most of the operating systems that ship Budgie. Most end up going with nemo.
The toggle won't do anything if budgie-desktop-view is not installed.


Postgres pretend mode bug

PostgresProcessor tries to get undefined offset 0 at line 24.
This bug appears when using pretend mode with saving model both in Laravel 5.1 and 5.2

Pretend mode isn't intended to work for those sorts of queries.

Pretend mode isn't intended to work for those sorts of queries.


Service: Support mTLS certificate refreshing

Author: @robzienert
Summary of the feature being proposed
Support mTLS certificates being refreshed.
What value does this feature bring to Temporal?
This would help organizations that use short-lived, rotating mTLS certificates adopt Temporal. Users of Hashicorp Vault, Amazon CM, or other technologies would find this particular proposal useful.
Our specific use case refreshes certificates every T minutes in /dev/shm. I'm open to specifics of implementation (file watch, polling, etc).
Are you willing to implement this feature yourself?
Yes.

Sorry, somehow I didn't see this when I was opening #1162.
@robzienert, I'm literally starting looking into this right now. If you are still interested, let's cooperate.

Sorry, somehow I didn't see this when I was opening #1162.
@robzienert, I'm literally starting looking into this right now. If you are still interested, let's cooperate.

@sergeybykov Sure, would love to help where I can.
I realize this isn't part of the proposal, however: I'm currently trying to get our certs to work as-is without refreshing and am not having much success - is it possible that the TLSProvider could be extensible? If I could use our certificate service directly, I wouldn't need to export CAs and so-on, and would be able to provide certificates directly without Temporal trying to generate its own.

@sergeybykov Sure, would love to help where I can.
I realize this isn't part of the proposal, however: I'm currently trying to get our certs to work as-is without refreshing and am not having much success - is it possible that the TLSProvider could be extensible? If I could use our certificate service directly, I wouldn't need to export CAs and so-on, and would be able to provide certificates directly without Temporal trying to generate its own.

Have you tried WithTLSConfigFactory server option? It enables overriding of the TLS config provider, and should let you define TLS config on all four ends the way you need.

Have you tried WithTLSConfigFactory server option? It enables overriding of the TLS config provider, and should let you define TLS config on all four ends the way you need.

That extension works great, feel bad I missed it before! Our refresh intervals are infrequent enough that we're not in immediate need of certificate refreshing.

BTW, #1288 enabled dynamic serving of certs on a per-connection basis. We still plan to change the included cert provider to update certs without restarting server.


Menu option deprecation fix

Hi @thatfiredev
The deprecated methods have been replaced with the updated ones according to the solution  proposed.
Thank you!

Hi @thatfiredev
I'll be closing this pull request because the CLA is failing as the account that is used in the commit is different from the one that i used to sign the CLA.


Fix failing builds

All builds related to planner are failing.
This PR updates the version of pip used in the containers for API tests and also install the python-devel package.

@jarifibrahim Your image is available in the registry. Run docker pull quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2736 && docker run -it -p 5000:8080 quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2736 and visit http://localhost:5000 to access it.


python3 support for poll_rss.py print func

updating print to Python3 style

Thanks!
You'll need an import and remove some of the white-space you've used for this to be implemented correctly, example here: https://github.com/stephenmcd/mezzanine/blob/7c523b7909062cda5e892adec9e7b6aefe1359e2/mezzanine/core/management/commands/createdb.py#L1

Closing this since this is outdated and fixed by another PR


Adsk Contrib - Enable 'warnings as error' for the Linux CI builds

Enable 'warning as error' for the Linux CI builds to trap all potential issues using the compiler capabilities. Only the Linux CI builds are warning free for now.
Note: By default, the 'feature' is OFF so anyone cloning and compiling the library could not be blocked because of an untested combination of platform & compiler versions.

Following the two-weeks rule, here is a friendly reminder that the branch could be merged next week unless there are some objections.


CAMEL-10500 Camel-Git: Add allowEmpty commits option

Thanks the PR has been merged. Can you close this?


(maint) Add changelog for 4.0.38 release.

In preparation for the 4.0.38 release, we generate the change-log.

Jenkins please test this on all

CLA signed by all contributors.


Map showing only background after navigate to different shell tab and then back again (android)

Describe the bug
I have an application with the mapsui control on a shell navigation tab. The first time visiting the tab, the map is displayed correctly, and I can pan / zoom and interact with the map.
When I select a different shell tab, and then go back to the map tab, only the map control background colour is shown, no map layer is shown.
The issue is only on android, not IOS.
The map was working correctly in 4.0.0 beta 5
To Reproduce
Steps to reproduce the behavior:
Create a maui application using Shell, with a screen with shell tabs on.
Add a mapsui map with open layers on it to the first tab.
Add other tabs with other controls on
Run the app, and the above behaviour is observed.
Note, my app has other functionality than this, I'll try and determine the smallest reproducible version.
Expected behavior
The map is displayed correctly when navigating back to the tab with the map on it.
Screenshots
On initially visiting the tab:

After navigation to another tab

(background of mapsui component set to pink)
Smartphone (please complete the following information):

Device: Android emulator and Android device (eg Samsung galaxy) in both debug and release builds
OS: all android versions I have tried, definitely 11
Browser: NA
Version: 4.0.0 beta 6 and beta 7 (works on beta 5)

Additional context
This used to work fine with the previous betas. I am not sure when it broke, I will install an earlier version and see if I can find it went wrong.
I've tried doing a map.Refresh() in OnAppearing, with no success.

Have you a sample project that displays this behavior?

I have seen similar weirdness with MAUI on Android recently. I suspect it's a bug in the Maui framework itself rather than Mapsui. Have you checked with the same MAUI / .NET SDK Version that beta 5 works, but 6 and 7 fail? Or was your beta 5 build done with an earlier SDK version?

Can you provide the Android Debug Output, when It fails?

And attach to logger to see exceptions https://mapsui.com/documentation/logging.html.
Also you could use different colours (lets add a u because you are in the UK) for:

The background of the tab
mapControl.BackgroundColor
mapControl.Map.BackColor

It could be something related to initialization resulting in wrong width/height/boundingbox. Or some unexpected things happening during reinitialization.
btw, the MAUI MapControl is derived from the ContentView which might have it's own issues. I was considering deriving is from an AbsoluteLayout which would allow users to place MAUI popups at the place where they click the map.

This happens for me as well.

I assume this is fixed by either UseGPU = false; or with the over fetch issue that was fixed in beta 9, If not please open a new issue.

@anmelegov If MapControl.UseGPU = false produces an NullReferenceException this is a bug that we should fix please open an issue for that, describing the exact situation.
You mention 'fully reinstantiate the map component'. I don't know your exact situation but in general the idea is that the MapControl itself belongs to the view and should be cleaned up if the view is cleaned up. The state should be maintained in the Map object as part of the ViewModel. The IMapControl should not need to be injected in the ViewModel. If this is what you do but this still causes problem then please describe that in a bug report so we can fix it.


meteor: 2.7.3 -> 2.11.0

Updating the version to the latest released version, https://docs.meteor.com/changelog.html#v211020230302
Updated the sha's.

The sha was gotten by downloading the files at:

https://static.meteor.com/packages-bootstrap/2.11.0/meteor-bootstrap-os.linux.x86_64.tar.gz

https://static.meteor.com/packages-bootstrap/2.11.0/meteor-bootstrap-os.osx.x86_64.tar.gz

https://static.meteor.com/packages-bootstrap/2.11.0/meteor-bootstrap-os.osx.arm64.tar.gz
and running sha256sum on it.

Added support for aarch64-darwin

Updated new static meteor domain name, please check: https://forums.meteor.com/t/maxcdn-end-of-lifecycle-new-meteor-domain-name/59260

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)

23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 222761 run on x86_64-linux 1

1 package failed to build:

meteor

Logs: https://gist.github.com/pbsds/67d8d9b19759e5b9dd24b53191aff8f8


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/38551

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71169

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/71170

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73088

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73087

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73635

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/73636

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/76493

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82220

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/90951

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/92983

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


duplicated code/scripts in pivpn installation - why ?

what is the purpose of these duplicated scripts in /etc/.pivpn/scripts and /opt/pivpn ?
root@pivpn1:/etc/.pivpn/scripts# ls -la /etc/.pivpn/scripts/
insgesamt 48
drwxr-xr-x 2 root root 4096 Mär 22 20:28 .
drwxr-xr-x 5 root root 4096 Mär 22 20:28 ..
-rw-r--r-- 1 root root  651 Mär 22 20:28 bash-completion
-rw-r--r-- 1 root root 1323 Mär 22 20:28 clientStat.sh
-rw-r--r-- 1 root root  335 Mär 22 20:28 fix_iptables.sh
-rw-r--r-- 1 root root  794 Mär 22 20:28 listOVPN.sh
-rwxr-xr-x 1 root root 7205 Mär 22 20:28 makeOVPN.sh
-rw-r--r-- 1 root root 1043 Mär 22 20:28 pivpnDebug.sh
-rw-r--r-- 1 root root 3325 Mär 22 20:28 removeOVPN.sh
-rw-r--r-- 1 root root 5270 Mär 22 20:28 uninstall.sh
root@pivpn1:/etc/.pivpn/scripts# ls -la /opt/pivpn/
insgesamt 44
drwsr-xr-x 2 pivpn root 4096 Mär 22 20:28 .
drwxr-xr-x 3 root  root 4096 Mär 22 20:28 ..
-rwxr-xr-x 1 root  root 1323 Mär 22 20:28 clientStat.sh
-rwxr-xr-x 1 root  root  335 Mär 22 20:28 fix_iptables.sh
-rwxr-xr-x 1 root  root  794 Mär 22 20:28 listOVPN.sh
-rwxr-xr-x 1 root  root 7205 Mär 22 20:28 makeOVPN.sh
-rwxr-xr-x 1 root  root 1043 Mär 22 20:28 pivpnDebug.sh
-rwxr-xr-x 1 root  root 3325 Mär 22 20:28 removeOVPN.sh
-rwxr-xr-x 1 root  root 5270 Mär 22 20:28 uninstall.sh

ok, i see, it's the local git dir  - but wouldn't that better belong in /home/$pivpn ?
i never have seen git repo checkout to /etc , that is directory for configuration/startup files. not for installation-source dir.

Been looking at this .. I have never liked the fact of having that Dir there, specially hidden, but never paid much attention to it tough ...
This should be fixed and we aren't definitely putting stuff in the right places...
/etc/.pivp Should be moved to /usr/local/share/pivpn
/etc/pivpn Should be moved to /var/local/pivpn
the Scripts in /opt/pipvn should be symlinks to /usr/local/share/pivpn/scripts/<script>
Update script should then be changed to just here then should just pull latest changes from pivpn maaster or test repo
guess this actually will simplify a lot of stuff ...
@devZer0  @orazioedoardo you agree?
Gues we could put this change on test-wireguard branch.

Considering that the script mimics the structure of Pi-hole, I think /etc/.pivpn for storing git files and /opt/pivpn for the scripts make sense. Considering the file system hierarchy, I wouldn't use /var. I would, however, make make /opt/pivpn's scripts symlinks to /etc/.pivpn's scripts.

@orazioedoardo well we don't really need to follow all pihole does even though the similarities are there.
I personaly don't thing /etc/ is a place to put a dotfile/folder ... Linux as a file system hierachy for this kinds of things, i do believe that /etc/.pivpn should be elsewhere in the file system.
I Do believe as well this will cause less confusion for our users.

I'd really like to get some traction here ...
I don't really like the fact of having /etc/.pivpn/ this is against all linux logics and it should go elsewhere.
I believe that /etc/.pivpn/ should definitely go to /usr/local/share/pivpn
also /etc/pivpn its arguable but, it is not a configuration file, and i can agree as well that /var/... its not the best place for it .. so it doesn't really bother me to keep it where it is.
However i would like some agreement here specially from you @orazioedoardo ... What you thig?
@devZer0 and you?
This is the best time to address this!
test branch looks pretty solid now and its a good time to make the change before moving it to master.
tbh i'd like to have test branch moved to master this weekend .. latest next.

Will set this on hold ... as the update will break once again for users that want to use pivpn -up .. not really sure if we want this at the moment.


Is it possible to include function composition ∘ as a binary operator?

Hi and thanks for this package!
I mentioned this on discourse:
Is it possible to include function composition ∘ as a binary operator?

Thanks for posting here too, @azev77.
I thought about this again; what equations would be possible with this operator that wouldn't be possible without it? It should already be capable of composing operators in a tree.
I could see other operators like differential operators being of interest. But all of these would require a lot of internal changes to get working, and the algorithm for evaluating them would be slower (I think).
Cheers,
Miles

I don't see such functionality on the horizon, so am closing this. Will re-open if I make the package capable of handling more flexible operators. The reason I do not currently is because having a small set of allowable operators (real -> real and real,real->real) allows me to make some significant optimizations.


Suggest replacing cpx with maintenance fork

Similar to https://github.com/es-tooling/module-replacements/pull/2, suggest replacing cpx with the cpx2 maintenance fork. See https://github.com/renovatebot/renovate/pull/27507 as an example where I contributed something similar to another tool. I'm happy to contribute this here as well.

good catch! makes sense to me
would you be up for opening a PR? there's a template you can follow here
you can ignore the manifests for now until we sort the automation out around that

Opened https://github.com/es-tooling/module-replacements/pull/19 and https://github.com/es-tooling/eslint-plugin-depend/pull/17 for this one 🙏🏻 Didn't look like any tests needed updating. Happy to make any changes, if needed.


hibernate.jdbc.time_zone unsupported on TIME columns

Hi, we are trying to add the property <property name="hibernate.jdbc.time_zone" value="UTC"/> to our application, but we got UnsupportedOperationException on some MySQL TIME columns, may I know is there any plan to support that?
Stacktrace
java.lang.UnsupportedOperationException: null 	at org.hibernate.reactive.adaptor.impl.PreparedStatementAdaptor.setTime(PreparedStatementAdaptor.java:246) 	Suppressed: reactor.core.publisher.FluxOnAssembly$OnAssemblyException:
Environment Information

Version: 1.0.0.CR6

In theory it should already work :-)
https://github.com/hibernate/hibernate-reactive/issues/667
I will have a look

Can you past an example of an entity you are using? A reproducer would be even better. You can use JBang to start an example testcase:
jbang init -t mysql-reproducer@hibernate/hibernate-reactive Issue856.java
jbang edit --open=idea --live Issue856.java

You can replace idea with your favourite IDE

Nevermind.... I can see the exception

for more deatils, we are using LocalTime in the Entity and TIME in the database
Entity
public class A {     @Column(name = "time")     private LocalTime time; }
Table
CREATE TABLE IF NOT EXISTS A(  time` TIME
)

So the issue here is that the notion of a zoned time is entirely broken and should never have been introduced in SQL (fortunately most databases don't support it). The mapping between timezones depends on the date, and so only zoned datetimes make sense.
Until this moment I had no idea about the behavior of hibernate.jdbc.time_zone, which looks pretty bad to me, at first sight, and perhaps we should change it in H6.
So I'm not sure what to do here. "Fix" it to do the same bad thing as ORM, or just ignore the setting when working with times?
Or just ignore the property altogether, and figure out how to do this using a connection property instead? (Might need a new feature in the Vert.x client, I'm not sure.)

I'm removing the "bug" label. It's not a bug that zoned times don't work. They're broken by design.

(This is of course partly my fault for not digging deeper when I did #676 and noticing the problem with the behavior of hibernate.jdbc.time_zone.)

I started a discussion here.

The mapping between timezones depends on the date, and so only zoned datetimes make sense.

Ok, but they are trying to store a LocalTime that doesn't have any timezone attached and shouldn't require any convertion.
Am I missing something?

But that's not what this property does, it seems. In ORM it attaches a timezone to the thing.
At least, it seems to me. (I have never been able to completely understand the semantics of that JDBC method.)

"Fix" it to do the same bad thing as ORM

I think I will check what ORM does and do the same. It's probably the behaviour that users tjhat are familiar with ORM will  expect anyway.

I think I will check what ORM does and do the same.

hahahaha oh sweet summer child!
ORM calls a JDBC method which has essentially undocumented semantics.

So to recap part of the discussion with @yrodiere on Zulip:

He says this stuff is all very fragile (and probably broken) in ORM to begin with, partly because all the JDBC drivers do fragile and different things.
What I decided to do for handling Timestamps with hibernate.jdbc.time_zone (which tries to convert the given Timestamp to the given timezone before passing it to the driver) might or might not be robust, but it certainly doesn't seem conceptually correct for a Time.

So the options are (1) just silently ignore the setting, (2) blow up when the setting is present, or (3) do something we know is broken.
I'm inclined to go with (2).

I suppose we could keep doing what we're currently doing for datetimes, and just ignore the setting which it comes to times. But geez, that amounts to introducing a new and differently-broken semantics for a feature which is already kinda broken. Brrr.

@pqab why precisely do you use this setting? Could you reasonably, like, just _not_use it?

@pqab why precisely do you use this setting? Could you reasonably, like, just _not_use it?

And same question for @Ngosti2000

To be fair, I didn't expect it to be applied to objects that don't have time zone like LocalTime.
I suspect the problem is that it's a global property and if you set it because it makes sense in other cases I don't think  there is a way to disable it for specific fields. Or maybe there is?

To be fair, I didn't expect it to be applied to objects that don't have time zone like LocalTime.

Right, same. We assumed too much sanity.

I don't think there is a way to disable it for specific fields. Or maybe there is?

Not that I know of.

we have some others DATE fields need the global property, but we expected that the TIME field should be ignored because it doesn't have time zone


Imporve regex

Make regex ignore command if there is anything written before "no"

I don't understand the purpose of this. My original intention was to match everything that starts with "no" and ends in a "?" regardless of where it is in the message

I guess I misunderstood what the intention was. Closing this now.
G


CIP: add spoiler or nsfw attribute to note metadata's attachement

Motivation
Many social media has the functionality to mark an image or video as spoiler or nsfw for its sensitive content. It will be shown in a blurred form before users clicking to show the actual content.

 For some examples:

Twitter:
Discord:

Mastodon:

I think it's helpful to maintain the health of community. It also gives at least an option to let user post some sensitive content in a thoughtful way.
Proposal
I would like to add an optional alt attribute to the element of attachements in note's metadata.
         {
            name?: string
            address?: string
            mime_type?: string
            size_in_bytes?: number

+           /**
+            * The spoiler indicator for medias. Defaults to false.
+            */
+           spoiler?: boolean
          }

I'm not sure if spoiler or nsfw is a better name.

sounds good

@Fooooooooooox I think we should reopen this for some others' thoughts. This is just a general idea.


Resolves BagOpenCloseVisualizer is Obsolete

About the PR

Converts the BagOpenCloseVisualizer into a generic visualizer.
TODO:

[x] Testing

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Reopen when you come back to this.

Converted to a generic visualizer. Commits tested and pushed.
@DrSmugleaf Reopen whenever is convenient.

This PR is extremely cooked.

@metalgearsloth
Cookedness should be fixed and I've made it into a generic visualizer.
Please reopen whenever is most convenient.

i think you force pushed to the repo before opening the pr which apparently makes it impossible to reopen??

Opened a new version over here. #16399


Normal maps in 3D space don't work on Android

Operating system or device - Godot version:
Android 7.1, latest master branch
Issue description (what happened, and what was expected):
Normal maps in 3D space don't work on Android. It just renders the diffuse texture.
If this is intended behavior, it should be documented somewhere. (I could't find anything)
Steps to reproduce:
Add a Sprite3D with a FixedMaterial which uses a normal map. Add a light to the scene to test it.

Have you enabled fragment lighting in Scene -> Project Settings -> Rasterizer.Android?

Yes.

So, there seem to be differences between devices.
Android 7.1, OnePlus 2:
![img_20161031_083710]
Android 7.0.1, Samsung Galaxy Tab S2:
![screenshot_20161031-083227]
PC, Linux, GTX 970, proprietary drivers, this is the correct one:
![screenshot_20161031-083656]
(https://cloud.githubusercontent.com/assets/8849554/19847237/bf79b22e-9f45-11e6-8508-698a66f00c07.png)
(https://cloud.githubusercontent.com/assets/8849554/19847211/8e65ba34-9f45-11e6-8777-cbac7b360cfc.png)
(https://cloud.githubusercontent.com/assets/8849554/19847184/58efea50-9f45-11e6-9bb6-bf7dd2ecde98.jpg)

Maybe a precision issue.
Sometimes I get different results between PC and Android and I need to add
some hacks for mobile.
Are you using normalize()? Any chance of having a look at your shader's
code?

This is my shader code:
uniform color fmp_specular;
uniform texture fmp_normal_tex1;
uniform texture fmp_normal_tex2;

float speed = 0.02;

color specular=fmp_specular;
SPECULAR=specular.rgb;
SPEC_EXP=48;

vec2 uv1 = UV;
vec2 uv2 = UV;
vec3 normal_tex = vec3(0);
float time_rem = mod(TIME, speed * 3);

uv1 += TIME * speed;
uv2 -= TIME * speed;

normal_tex = mix(tex(fmp_normal_tex1, uv1), tex(fmp_normal_tex2, uv2), 0.5).xyz;

NORMALMAP = normal_tex * vec3(2.0, 2, 0.3) - vec3(1,1,0);
NORMALMAP_DEPTH = 1;

DIFFUSE=vec3(0);

The texture uniforms are both a water normal map.
As I'm new to shaders, could you explain the normalize() function to me, please?

normalize() takes a vector and makes it one unit long while keeping its
direction. It's like dividing every component by the length of the vector.
But I've found sometimes on mobile the vector ends up measuring less than
1.0 and I have needed to put down normalize() and do it by multiplying by 1
/ length(vector) to get accurate results (you know, multiplying by the
inverse of a number is an optimization used when you have to divide several
times by the same number as division is much slower than multiplication).
With TIME you have to be careful because as time goes by it can grow as
much as to cause numeric range issues. That's why using fract(), mod(),
etc. on it is advisable depending on what you need to achieve or what
computations it will be involved in.
All that said, I have not yet seen anything that can cause precision issues
in your shader during the first minutes of execution.
The only thing that I find wrong is that if you are translating from normal
map color to the actual normal by yourself, you must assign the result
directly to NORMAL (by using NORMALMAP Godot will do the conversion one
more time).
Furthermore because of that 0.3 for Z, you are not getting a unit normal
vector. It might be what you want, but if not, you have to normalize() the
resulting vector.
Check these things and tell your results so we can further investigate
whether you have hit a bug.

Thank you! By normalizing, it works on Android.

I'm glad I've helped you. Good luck with your project!

Thanks, normalizing the vectors in my shader worked and it gave me a much more cooler effect.
You have no idea how happy you just made me, Thank You!!


Provide mechanism to pass build pipeline version down to cmake

Currently, src\tool\cpp\cppwinrt\version.h is updated by our internal build system. We should be generating this file as part of the cmake compile process, as demonstrated in the CMake tutorial

Rather than using version.h as the version source for other projects, the version number should be explicitly passed to cmake and propagated down.

So we would pass XLANG_VERSION_STRING (or it's equivalent) into cl as a command line parameter for cpp/cppwinrt project?

We still need to keep the cpp\cppwinrt\version.h around (it's included in the projection).  But other projects (natvis, nuget, vsix) could do their own versioning thing and not depend on cppwinrt.

It sounds like we can seperate this into to parts.

Use a cmake variable to track cppwinrt version number. We'd generate version.h with that and use it for package projects that need the version information
Enable passing in the cppwinrt version number from the build pipeline (with a resonable default for local build)

Fixed by #172


⚠ 366.ru has degraded performance

In 15d1f38, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 1879 ms

Resolved: 366.ru performance has improved in 4077959.


Enhancement: support more than 1 condition inside min/max aggregates for translation

The set of conditions must have bound variables and may not rely on outside Variables.

Also the length of conditions is restricted to 1 currently, fix this too.

002.jobshop.lp


Improve latency in parse_project

In codespaces, parse_project consistently takes the same amount of time as on my local machine (between 1.2-1.8 seconds). I noticed we’re calling it more than once per change. I know we do it on every keystroke, but sometimes I’m seeing it happen 5+ times after making just 1 keystroke. Since each call is happening in a separate thread, it makes sense that the latency is so much better on 16 cores vs 2 cores. If we implemented something that cancels a running parse_project  call when it’s been usurped by a new one, or otherwise prevents multiple parse_projects  to run at the same time, I think it would help a lot with latency overall. Another benefit would be that the server would be sending fewer publish_diagnostics  notifications so from the user’s perspective, the squiggly lines won’t be jumping around as much while they’re typing.
I also noticed that the inlay hints load pretty quickly when the project is first opened, but they seem to take progressively longer the more I type. Since we call parse_project  on save as well as on change, I tried disabling autosave to see if it would reduce the number of calls. It did reduce the number of calls and improved latency significantly (inlay hints after less than 2 seconds). I wonder if we could remove the call to parse_project on save entirely, since it should be captured by on_change already.
I’m still not sure why the perf is worse in codespaces. I think it has something to do with the throughput between the codespaces machine and the extension host (which is currently a black box). There is a big delay between when the client thinks it’s sending a message and when the server starts executing the API handler function. It seems like whatever is being used to relay the stdin/stdout to the remote extension is doing it in a more synchronous way than how it works locally.
If we make the LSP more efficient overall (fewer messages passed, especially time consuming & resource blocking ones like parse_project) I think it will help immensely. I’ll start looking into how to queue and cancel parse_project threads.

https://github.com/FuelLabs/sway/issues/4275


Use validator-api to validate model

Current coverage is 45.36% (diff: 100%)

Merging #54 into master will not change coverage

@@             master        #54   diff @@
==========================================
  Files            49         49
  Lines           313        313
  Methods           0          0
  Messages          0          0
  Branches         29         29
==========================================
  Hits            142        142
  Misses          159        159
  Partials         12         12

Powered by Codecov. Last update 58f188e...39b26a8

Of course - an exercise that needs to be carried out once we have finalised the model I guess.
On a side note, please don't approve PRs until you're actually happy to merge. Soon I hope to have a bot that auto-merges PRs that are approved, have no conflicts & have passed all status checks.


[fix] public side colorbox options

Coverage increased (+0.005%) to 83.361% when pulling a2cf69fa39a633a715aa6aaa3e6a47728b4ea4e8 on itowtips:fix-colorbox into af0b80f038a5337ac0c43b8421e0496727326db3 on shirasagi:master.

Coverage decreased (-0.01%) to 83.343% when pulling a2cf69fa39a633a715aa6aaa3e6a47728b4ea4e8 on itowtips:fix-colorbox into af0b80f038a5337ac0c43b8421e0496727326db3 on shirasagi:master.


Help us test: new things.py release 0.0.15

As of fixing all issues in #110, we're ready for a new release.
I propose we push to PyPI immediately (since its breaking already), and then invite various people to test it. (/cc @AlexanderWillner)

Context
What changed

Various things broke with the new Things database that were fixed (see #110).
The values for date-parameters were extended; now you can do this:

>>> things.todos(stop_date="2023-05-21", status="completed")
>>> things.todos(deadline="<2024-01-01")
>>> things.todos(start_date=">2023-01-01")

How you can help

Test your workflows and ensure everything appears and works as expected.
Test various methods of the API: https://thingsapi.github.io/things.py/things/api.html
Read the documentation and ask if something seems unclear.

Gratitude ☀
Besides @CaAlden, @NickChristensen,  @hlipnick, @subokita, @bkleinen mentioned already, who played an important part in this update... also kudos to @jeredactyl, @patrick91, @fabge, @ishan1m, @roelvangils, @nathankoerschner, @chrizel, @Avery2, and @lmgibson who have supported this library directly or indirectly. Your participation makes open source work.
Thank you. 🙏

Thank you so much 🙏
(This might just be something specific to my environment, but after upgrading things-cli, I still get an error. Am I doing something wrong?)

Am I doing something wrong?

The dependency (things.py) was not updated automatically. This might be fixed in things-cli v0.2.1

@ishan1m if you run pip3 install --upgrade things-cli that third-party library might work now (its author submitted a fix thanks to your comment).


Update to pug-parser

Jade recently renames itself to pug due to copyright issues and they changing internal architecture prior to 2.0 release.
I mostly done this because of nicer errors messages in my gulp workflow.
PR also includes basic test suite.
Have a nice day!

Hi @adammockor. Thanks for proposing this.
I think I'd be more open to this if we discussed the changes first and maybe introducing them as smaller pull requests. Namely:
Naming
I'm not sure the name change is necessary. The language is still called Jade.
Tests
Which test runner, matchers, etc
API
For a while I've been meaning to release a version that allows consumers to provide their own version of Jade and pass that to this package.
This would allow them to update Jade independently instead of relying on whatever version is used here.
Could/should we do some sort of version/feature detection that automatically does the right thing for a particular version of Jade?
Changes to Jade's internal architecture
How they affect this project. Given the above points, I think this is the only thing that warrants a breaking change.
Versioning
My current thinking is that a major release should be made based on the internal architecture that's currently supported here. If making an update to support a different internal architecture, that would warrant another major release.
We could provide info such as "v1 supports Jade ^1.9.0, v2 supports Jade ^1.10.0" or whatever is correct.


Implemented Quadratic Equation Intersection Calculator (Fixes #33)

Issue name and ID I worked on -
Quadratic Equation Intersection Calculator (Issue #33)
Briefly explain your program logic -

The function takes six parameters a1, b1, c1, a2, b2, and c2, which represent the coefficients of two quadratic equations of the form a * x^2 + b * x + c.

It calculates the discriminant (disc) using the formula disc = B^2 - 4 * A * C, where:

A is the difference between a1 and a2.
B is the difference between b1 and b2.
C is the difference between c1 and c2.

The code then checks three cases separately:

If the discriminant (disc) is greater than 0, it means there are two real roots for the quadratic equations.

It calculates the first root x1 and its corresponding y1 value.
It calculates the second root x2 and its corresponding y2 value.
It sets the result variable to a string indicating that the equations intersect at [x1, y1] and [x2, y2]. The toPrecision(2) method is used to round the values to two decimal places.

If the discriminant is equal to 0, it means there is only one real root for the quadratic equations.

It calculates the root x and its corresponding y value.
It sets the result variable to a string indicating that the equations intersect at [x, y]. Again, toPrecision(2) is used for formatting.

If the discriminant is less than 0, it means there are no real roots, and the equations do not intersect.

It sets the result variable to indicate that the equations do not intersect.

Finally, the result variable is updated with the appropriate message based on the calculation results, indicating whether the equations intersect and, if so, where.

Screenshots(Attach 2 screenshots of your own input and output) -
Two Real Roots use case

Single Real Root use case

No Real Root use case

By raising this PR I affirm that -

[x] My code follows the guidelines of this project.

[x] I have performed a self-review of my own code.

[x] I have commented my code.

[x] My code gives the correct output.

[x] I affirm that I strictly follow contributing guidelines and code of conduct.

hi @SarthakKeshari I've completed working on the issue "Quadratic Equation Intersection Calculator" within the specified deadline. Kindly accept and merge my PR as soon as possible. Thank you so much for the opportunity.

Congratulations 🎉 @DeexithParand2k2 on your contribution.
Thanks for adding value to this repository. 😊
Let's celebrate this fest 😃 by providing more developers 👨💻👩💻 an opportunity to contribute. Help us make this repository reach far and more by sharing this to your friends and colleagues.
Your efforts can make difference.

@DeexithParand2k2,
The efforts you have put in not only to write your code but also explain it so well, adding admin-appreciation points for this PR.
Kudos to you!! 🎉

Hey 👋, may you also encourage us by clicking the star icon on the repository main page. ⭐

Thank you @SarthakKeshari for the opportunity. Would love to contribute more. Thank you.


Function-scoped "use strict" doesn't seem to apply

I apologize if I'm doing things wrong but I've looked at the docs, searched the issue tracker and elsewhere but I'm still not sure what is up.  Whenever I use function-scoped strict mode enablement, JSHint doesn't seem to catch the errors/warnings unless I set globalstrict or strict.
Is there no way to have strict mode checking enabled conditionally based on the existence of the enablement statement?
Here is my example script:
(function () {
  'use strict';

  // Strict mode compliant
  // var name = 'JSHint';

  // Not valid in strict mode since it's attempting to assign to an undeclared variable
  name = 'JSHint';

  // Not valid in strict mode since it's attempting to use an undeclared variable
  context.setVariable('NAME', name);
})();

And here is my .jshintrc:
{
  "globals": {
    "context": true
  },
  "-W034": true
}

When I run jshint my-file.js, I do not get any errors or warnings output while I would had expected the following:
my-file.js: line 8, col 3, 'name' is not defined.
my-file.js: line 10, col 31, 'name' is not defined.

2 errors

Am I doing something wrong?  I'm using jshint v2.9.5.
Note: I realize that the test above is somewhat convoluted but this is how JavaScript snippets are written by customers and then invoked by our runtime.  This is not my code.  ;)

Short answer: The behavior you're experiencing is expected. Enable the undef option to cause JSHint to report references to undefined bindings.
Long answer:
While strict mode code produces an error when assigning to variables that have not been declared, this is a runtime error. It cannot be detected statically because the presence of global bindings can't be known statically. A couple examples:
'use strict';
global['f' + 'o' + 'o'] = null;
(0,eval)('var bar;');

foo = 0;
bar = 0;

It's definitely possible for JSHint to make educated guesses: that's what the undef option enables. But since this can only ever be an approximation of the runtime behavior in strict mode, we require users to explicitly opt-in.
Related to your code sample in particular, note that browser environments provide a global binding name "name". In recognition of that, JSHint would not report an warning even when undef is set... If linting code for the browser environment, this is. Based on the information you've shared, this doesn't look to be relevant for your case, but I wanted to point that out in case anyone else stumbles on this discussion thread in the future.

Fair enough, thanks for taking the time.

Sure thing.


add: SRIJAN KUMAR

Description

Related Issues

Changes Proposed

Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

Hi @SRIJAN-KUMAR7 , thanks for your interest in contributing to DevDisplay!
Before we proceed, we noticed you adding your profile on #DevDisplay but forgot to star the repo. It's like making an amazing sandwich and forgetting to take a bite! -- I think our repo's feeling a little lonely without your 🤗 So, be sure to star the DevDisplay GitHub Repository. 🌟
💌 This is a mandatory step for all contributors. & It's is the first priority of contribution in DevDisplay 💌
🚀 We look forward to your contribution once these steps are completed. 🚀
Thanks 👍🏻


Publish 8.6-20231223024716+0000

Publish 8.6-20231223024716+0000

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Enable CD on plugin-flaky-test-handler.yml

Link to GitHub repository
https://github.com/jenkinsci/flaky-test-handler-plugin/

### Release permission checklist (for submitters)
- [ ] The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to [accounts.jenkins.io](https://accounts.jenkins.io/).
- [ ] All users added have logged in to [Artifactory](https://repo.jenkins-ci.org/) and [Jira](https://issues.jenkins.io/) once.
- [ ] I have mentioned an [existing team member](https://github.com/orgs/jenkinsci/teams) of the plugin or component team to approve this request.

When enabling automated releases (cd: true)
I unfortunately merged the PR for enabling already because in section https://www.jenkins.io/doc/developer/publishing/releasing-cd/#update-maven-pom-and-config it says "Merge this PR activating CD".
Link to the PR enabling CD in your plugin
https://github.com/jenkinsci/flaky-test-handler-plugin/pull/31
### CD checklist (for submitters)
- [x] I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

### Reviewer checklist
- [ ] Check that the `$pluginId Developers` team has `Admin` permissions while granting the access.
- [ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
- [ ] If security contacts are changed (this includes add/remove), ping the security officer (currently `@Wadeck`) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

Hey pretty close but there's one issue on your PR, I've submitted a review on it: jenkinsci/flaky-test-handler-plugin#31

Thanks, @timja! I added the missing dot to master in this https://github.com/jenkinsci/flaky-test-handler-plugin/commit/4ec72cc2006ae71915a90562bb92ed91ad1af151 (had to use master because the PR was unfortunately already merged by me)


Update authorization feature spec to system spec

Summary
Rails 5.1 introduced "System Tests", the brave new world of automated testing in Rails. It seems like this has been refined quite a bit and will become more prevalent in Rails 6.0. We'd like to get ahead of the curve on this.
Task:
We need to convert /spec/features/authorization_spec.rb from a feature spec to a system spec. There are 4 steps to this:

[ ] Create a similarly named file in the spec/system directory. For example if the file was called happy_spec.rb it would be called happy_system_spec.rb in the new directory.
[ ]   Set each spec’s type as type: :System
[ ]   Use RSpec.describe to define system specs, instead of RSpec.feature
[ ]   Replace the scenario alias in previous feature specs with the standard it syntax

Two files have already been converted that you can use as examples -- the account_system_spec.rb spec and the adjustment_system_spec.rb spec. You can also see the original feature files at account_spec.rb spec and adjustment_spec.rb spec.
More information on system specs can be found below.
Reference

https://edgeguides.rubyonrails.org/testing.html#system-testing
https://relishapp.com/rspec/rspec-rails/docs/system-specs/system-spec
https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6
https://dev.to/aergonaut/running-rails-5-system-tests-on-travis-ci-with-chromedriver-4nm7
http://blog.mechanicles.com/2018/03/04/gotchas-rails-system-testing.html
https://everydayrails.com/2018/01/08/rspec-3.7-system-tests.html

Working on this! 😄

This was completed, but the issue was not tagged correctly so it didn't autoclose.


Powershell snippet

Addresses #1452

@o2sh Because the CI runs are required before merge, and they only get run on code changes, I can't merge documentation PRs :sweat_smile: Would you want to merge this?


Just some cleanup

Changed

Adds dependency on certifi rather directly (rather than thru requests).
Fixed a number of pylint reported issues.
Updates packaging and pylint versions.
Mark pylint codebase test as skipped rather than commenting it out.

Codecov Report
Base: 95.04% // Head: 94.95% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (d54c742) compared to base (02560a3).
Patch coverage: 68.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   95.04%   94.95%   -0.10%
==========================================
  Files         141      141
  Lines        7070     7080      +10
  Branches      522      523       +1
==========================================
+ Hits         6720     6723       +3
- Misses        292      299       +7
  Partials       58       58

Impacted Files
Coverage Δ

src/spellbot/cli.py
82.14% <ø> (ø)

src/spellbot/metrics.py
100.00% <ø> (ø)

src/spellbot/operations.py
94.88% <0.00%> (ø)

tests/test_codebase.py
90.54% <36.36%> (-9.46%)
:arrow_down:

src/spellbot/client.py
86.86% <100.00%> (-0.14%)
:arrow_down:

src/spellbot/services/awards.py
75.75% <100.00%> (ø)

tests/actions/test_tasks_aciton.py
100.00% <100.00%> (ø)

tests/test_bot.py
100.00% <100.00%> (ø)

tests/test_utils.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adding support for upload field in the repeater control

the repeater field now supports ‘upload’ fields
the WordPress Media Library can be filtered for repeater upload fields using the newly added $mime_type parameter.

Kirki::add_field( 'config', array(
    'video' => array(
        'type'        => 'upload',
        'label'       => esc_attr__( 'Video'),
        'mime_type'   => 'video/mp4',
)));

Closing #898

@aristath same here not sure why it fails

this needs documentation


Upgrade AssertJ Core 3.23.1 -> 3.24.0

This PR contains the following updates:

Package
Type
Update
Change

org.assertj:assertj-core
compile
minor
3.23.1 -> 3.24.0

[ ] If you want to rebase/retry this PR, check this box

Also tweaked the suggested commit message.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

Likely we should also investigate use of assertj-guava

That link leads to website that links to a GH repo that is a public archive though.

AssertJ Guava is hosted on github : https://github.com/joel-costigliola/assertj-guava.

However, it lives in AssertJ core.
But yes, there could be some interesting stuff in there :).

However, it lives in AssertJ core.

The new BOM shows that they're split.


RAINCATCH-1262 - server side config improvements

Motivation
Application configuration should be centralized and easy to manage using environment variables.
Description
Improve server side configuration to not relay on the environment variables inside various files in the code. To do that configuration cannot be json anymore.
We need to have ability to choose from environment variables or default values.
That's why I have moved configuration to js files.
JS files will allow us to:

Add comments to configuration
Resolve configuration dynamically from environment variables
Handle legacy parameters (RHMAP)

Progress

[x] Move json files to js (for documentation)
[x] Refactor configuration
[x] Add Documentation

Changes Unknown when pulling 05dc07cc15244f5f127572cc6430ddb23c409b59 on wtrocki:RAINCATCH-1262 into ** on feedhenry-raincatcher:master**.

Changes Unknown when pulling b578715019738957ead4c31746550ad78a7d0722 on wtrocki:RAINCATCH-1262 into ** on feedhenry-raincatcher:master**.

Changes Unknown when pulling b578715019738957ead4c31746550ad78a7d0722 on wtrocki:RAINCATCH-1262 into ** on feedhenry-raincatcher:master**.


falling_objects_issue

Checking for Objects that fall

We need to develop a logic such that:
Detect if the object falls (i.e. if its height is less than the bin height)
If so, remove the object from lists where we track objects. like the sorted_object_list

completed.


Ergo: block effort

Discussed in https://github.com/oliverw/miningcore/discussions/1322

Originally posted by Censseo July 22, 2022
Hello, I'm trying to understand what to do with the block effort, because I don't really understand what the value sent by the api meaning.
I looked into the code and if I understand well it's the SUM(difficulty/network_difficulty) from shares but the value sent cannot be true because I got something like 0.0033236580321025786, what I am supposed to do with that?

Its very likely that something broke in the last release that fixed some other Ergo problems related to the recent Ergo node update. Currently looking into it.

Its very likely that something broke in the last release that fixed some other Ergo problems related to the recent Ergo node update. Currently looking into it.

Hi @oliverw I git pull the dev branch. Let's wait for the next block to see if it was fixed. Thanks.

Please update this issue when you got more information.

Please update this issue when you got more information.

I will. Unfortunately, no blocks so far.

Please update this issue when you got more information.

I will. Unfortunately, no blocks so far.

So?

Nothing yet.

Please update this issue when you got more information.
We've found two blocks. Effort looks good now. Thanks a lot

Please update this issue when you got more information.
We've found two blocks. Effort looks good now. Thanks a lot

Was this meant to be a quote?

Not in that way. Quote your question yes, but not my answer xD.


Update README.md

:cloud: Pending: waiting for processors

Note: You can also view OPS Portal for detail build statistics, or click here to report any potential performance downgrade issues.

:clock10: Preparing: avg. preparing time 1 min(s) 16 sec(s)

:clock10: Incremental building: avg. incremental building time 30 sec(s)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

README.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Simplied shell runs in GitHub Actions

Set default shell in the beginning of each step to avoid redundant settings later.
Please complete the following checklist:

[x] I have read the contribution guidelines.

[ ] I have documented all public-facing changes in the changelog.

[ ] This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the licenses directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied.

It is your responsibility to disclose code, documentation, or other content derived from external source(s). If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.

[x] This pull request does not include code, documentation, or other content derived from external source(s).

Note: This document may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.

@qiyunzhu This looks good to me. Merging now.


Use regexp compile

The regexp.MustCompile function panics if the regex fails to compile and should only be used in globals or init functions. Instead use regexp.Compile and check err is nil.

Thank you, but this is a static well-tested regex, I am comfortable with the simpler thing.


The server stops working after long context window is passed with zephyr model deployed with docker container on A10 GPU

I have deployed ollama on Nvidia A10 using Docker container , it works fine or smaller context window but server starts stop to work and gives below error
2023/11/17 14:08:33 llama.go:385: signal: killed
2023/11/17 14:08:33 llama.go:459: llama runner stopped successfully
Is there any guide on why this might be happening

It could be running out of memory while processing the context, are there any other logs above those ones? There should be some more specific details about why the runner is stopping in the ~20 lines above the llama runner stopped successfully log.

Thanks again for bringing this issue to our attention. We've since changed how we run models so the timeout on model load will no longer occur. If anyone sees anything similar in the future please open a new issue so we can keep track of it.


Updating .gitignore to ignore stuff built by kythe/web/site/build.sh [phab:D1529]

Created by danielmoy-google at 2017-04-14 21:14:04:

salguarnieri accepted this revision at 2017-04-14 22:43:41

danielmoy-google closed via commit 400a1ac0955e44e0884bb6660ec4424ae5ac3e89 at 2017-04-17 12:08:44