feat: add Aptos plugin

Relates to:

Risks

Background
What does this PR do?
Introducing new plugin for agent to manage an Aptos wallet.
What kind of change is this?
Now agent can manage an Aptos wallet and send APT token to others.

Documentation changes needed?

Testing
Where should a reviewer start?
Go to the aptos-plugin directory. To keep things simple, I only support transferring APT at the moment. Will add more functionalities later.
Detailed testing steps
Enable the aptos-plugin in the test agent, set the aptos wallet private key and network in .env.
For unit test, run pnpm test in plugin-aptos directory.
For end to end test, replace default character at this line with this custom character that enables aptos.
   const character = defaultCharacter;
    let customAptosPlugin = aptosPlugin;
    let customTransferAptToken = TransferAptosToken;
    customTransferAptToken.validate = async (content, runtime, callback) => {
        return true;
    };
    customAptosPlugin.actions = [customTransferAptToken];
    character.plugins = [customAptosPlugin];
    character.modelProvider = ModelProviderName.OPENAI;
    let characters = [character];

@shakkernerd gmgn ser I've added the unit test, feel free to take another look

@0xaptosj GM - kudos for writing the tests.
I am looking into this now.

lfg


Support an unlimited number of -s in comments

What is your feature request?
Make comment tokens have an arbitrary number of preceding - characters. Right now --- becomes an operator instead of a comment.
Please describe in detail how you expect this new feature to behave.
The following lines of code should all be comments:
-- comment
--- comment
---- comment
--! comment
--> comment
--| comment
--// comment

Related to #95


Update contracts to 0.6.2 with eth-brownie or directly with py-solc-x

We've had the issue of managing 0.4.24+ versions with py-solc before. Seems like there's a convenient truffle-like project in development that can help us manage 0.5+ versions through py-solc-x.
Update all our contracts to latest 0.6.2 version.
Links:
https://eth-brownie.readthedocs.io/en/stable/
https://pypi.org/project/py-solc-x/

Taken by @uivlis . Estimate 2-3 days.

Assigning @KadenZipfel since this hasn't moved forward.


Add cli command to print out the resulting cloudformation template

...that would be applied when executing create/update.
For being able to double check what would happen if we apply this

Test this please


feat: get all the villagers by Realm when in the villagers panel

Fetch the statuses of each villager while in the villagers panel

Needs #29 first for the queries to work.


Add test with high branching factor

Adds a test with a high branching factor in order to test new features like node merging and branch parallelization.
The test splits into 8 branches in total (and this can be increased by increasing the length of the proof array). It takes 1h to run on my machine.

We should add an actual test to the testing harness that merges the nodes and makes assertions about them. For example, it should be added to this test harness that the node merging is happening correctly: https://github.com/runtimeverification/kontrol/blob/master/src/tests/integration/test_foundry_prove.py#L236

@ehildenb Currently I don't think it's feasible to apply node merging to this example, because of this issue: https://github.com/runtimeverification/kontrol/issues/194.

@nwatson22 brought up another challenge in adding this example to our test suite: the merge node functionality requires the user to accurately specify nodes to be merged, and it might be nontrivial to identify and add such nodes to the kcfg in this example. This should be partially addressed in https://github.com/runtimeverification/kontrol/pull/163, but it requires additional changes and is not being worked on at the moment.


Future traffic light states in test dataset for Sim Agent Challenge

Hi,
It seems that the test dataset only contains traffic light states for the input duration of 1 second, and does not include traffic light states for future time intervals. For the Sim Agent Challenge, does that mean we also need to simulate (generate) the traffic light states on our own?
Thank you in advance for clarifying that.
Best,
Xintao

Hi @yougeyxt, yes you are correct, the test set does not include future traffic light states.
In theory yes, by simulating traffic light states realistically, you should be able to generate a better scoring submission.
From our exploratory experiments the difference shouldn't be massive, as these are 8s-long simulations, and usually traffic lights have a longer durations, and we don't see traffic light changes as frequently in Scenarios.
Happy to hear your thoughts on this too,
Nico

Hi @yougeyxt,
In principle a simulator should also simulate information about traffic lights, as this are still "unknown" latent variables to the AV itself. Being exogenous depends on where you place the border between "what is simulated" and "what is externallu defined". In this case, we are making as few assumptions as possible, so the task here is quite similar to developing a "world model" instead of just a "traffic simulator".
This is an arbitrary choice we made, so I understand that other solutions might be also valid.
I'd be happy to discuss more if you want, we are trying to address all these little details in the proceedings of this challenge, so feedback is always appreciated!
Add: we are having office hours tomorrow and friday if you need direct feedback (see pinned post).


Add CSS class to preserve form design

What's wrong with it currently?

If we use
field($model, 'from_date')->widget(\yii\jui\DatePicker::classname(), [
    //'language' => 'ru',
    //'dateFormat' => 'yyyy-MM-dd',
]) ?>
the textbox appears as plain textbox without bootstrap style i.e. layout appears broken so adding the CSS class brings back the lost style when adding DatePicker.

Won't accept the pull requests because it's jQueryUI widget that could be used without bootstrap.

Ok. How about I add a specific example when working with Bootstrap?

http://www.yiiframework.com/doc-2.0/guide-concept-di-container.html#practical-usage

You mean, I can add the specific example here under "Practical Usage" section?

No, I mean you can set additional class application-wide using it.


fix: correct onDelete call

Call deregisterDelegatedAdministrator on deletion
Fixes #1442

Many thanks @gshpychka fixing that bug 😍
If created another PR https://github.com/pepperize/cdk-organizations/pull/1454 updating the jest snaptshots via projen's self-mutation


Plan for dropping Python 2 support

Python 2 has great for many of us. But after two decades, the sun is setting on Python 2 support, which will not be maintained past 2020.
I'll propose the following. The next release for shapely is version 1.7, which currently supports both Python 2 and 3. This support should continue for the maint-1.7 branch for this release series. However, after this release, the master and development efforts for the 1.8 milestone should require Python 3.5+.
How does this seem to everyone?

Sounds good to me.
Mentioned in #721.


screencast links broken

several of the links on the main README under "screencasts" are broken.
Looks like some of the videos are on Nikita's channel? Not sure what is meant to be on the README

@alex9311
I don't have any problem with it. Links work correctly.

how weird... The link for the introduction video (https://www.youtube.com/watch?v=L9_IvUIHGwM&feature=youtu.be) leads to a "this video does not exist" for me

@alex9311
It is strange, the link is opened as expected for me.

@alex9311
Is the problem still reproduced?

it seems fixed now! Did you change something?

@alex9311
No, I suppose there was some problems with youtube.
I will close the issue.


Fix output buffer is imcomplete working in child_process

When I send a large buffer, over 50KB's CSS string, working in child_process.spawn, node-sass outputs only partial strings.
Certainly, it is caused by nodejs's console.log max size.
https://github.com/nodejs/node/issues/9546
So I modified to send output by continuous partial strings, its asynchronous.
This PR will fix this issue: https://github.com/sass/node-sass/issues/1823.

https://www.npmjs.com/package/stdout-stream seems like a better alternative than writing out own stdout stream lib.

I replaced out stdout lib to suggested package, it also works fine!

It works fine, but Travis CI is down for some testings...

I'm sorry the issue here is not clear.
Either the problem is related to console.logs max buffer size, in which we can fix by
emitter.on('log', stdout.write)

It's because process.stdout is no longer blocking, in which case we can use https://github.com/isaacs/block-stream. Either way i don't think this is the correct solution.

Yes, I think so.
However, process.stdout is no longer blocking, then we stop process.exit until stdout stream output completely. It's called by emitter.emit('done') immediately, So I add the flag of asyncWaiting.

OK I did some digging. You're correct that the issue is due how process.exit works.

It is important to note that calling process.exit() will force the process to exit as quickly as possible even if there are still asynchronous operations pending that have not yet completed fully, including I/O operations to process.stdout and process.stderr.

I see ways to solve this:

remove the process.exit (I don't think we need it)
use exit instead

Thank you for your advice. I replaced to process.exit to exit package.
And I removed exiting in emitter.on('done', ...) callback because of process exited even though using stdout-stream package, I wondering...
After removed this point, It works fine: CLI, spawned process, and watch mode.

https://github.com/sass/node-sass/pull/1834/files#diff-c19ab2481e2703fcf0d2808f4c762f63R165
Use bind() because of avoid error on stdout-stream.

Thank you for your work and patience. I'll merge this when CI is happy.


remove commons-lang3 and commons-lang dependancy for Dao module

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@b471119). Click here to learn what that means.
The diff coverage is 0%.

@@          Coverage Diff           @@
##             dev    #1663   +/-   ##
======================================
  Coverage       ?   14.92%
======================================
  Files          ?      285
  Lines          ?    13961
  Branches       ?     2271
======================================
  Hits           ?     2083
  Misses         ?    11656
  Partials       ?      222

Impacted Files
Coverage Δ

...java/org/apache/dolphinscheduler/dao/AlertDao.java
3.38% <ø> (ø)

...g/apache/dolphinscheduler/dao/utils/DagHelper.java
0% <ø> (ø)

...pache/dolphinscheduler/dao/upgrade/UpgradeDao.java
0% <ø> (ø)

...org/apache/dolphinscheduler/dao/TaskRecordDao.java
0% <ø> (ø)

...va/org/apache/dolphinscheduler/dao/ProcessDao.java
0.86% <ø> (ø)

...ache/dolphinscheduler/common/utils/ArrayUtils.java
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b471119...4fbb247. Read the comment docs.


Copy-edit the README

Hey @hasegeli,
Although these are all relevant and great changes, currently they conflict with our internal documentation formatting process. Sadly we are currently lacking on documentation for module formatting, but this is something we are working on.
Again I want to thank you for taking your time to submit this PR we really appreciate it and will get our guidelines published as soon as we can.

#964


Help users with old Node versions upgrade

The current Ubuntu release ships with Node 4.2.6, which the CLI does not support (we require 6+). This suggests many Linux non-JS developers will find the CLI harder to install than it should be. Long-term we're looking at packaging the CLI with Node (https://github.com/resin-io/resin-cli/issues/484), but for now any improvements here would be very useful.
For now, we still shouldn't support this version because it's out of LTS and coming out of maintenance entirely early 2018, but it would be nice if we at least included some basic advice to users on how to upgrade their Node version (e.g. a link to https://nodejs.org/en/download/)

Wondering if it's a wake up call to just bundle it sooner. @jviotti have
you made progress with capitano/etcher CLI on this front?
--
Alexandros Marinos
Founder & CEO, Resin.io
+1<PHONE_NUMBER>
@alexandrosm
On Tue, Aug 1, 2017 at 3:53 AM, Tim Perry<EMAIL_ADDRESS>wrote:

The current Ubuntu release ships with Node 4.2.6, which the CLI does not
support (we require 6+). This suggests many Linux non-JS developers will
find the CLI harder to install than it should be. Long-term we're looking
at packaging the CLI with Node (#484
https://github.com/resin-io/resin-cli/issues/484), but for now any
improvements here would be very useful.
For now, we still shouldn't support this version because it's out of LTS
and coming out of maintenance entirely early 2018, but it would be nice if
we at least included some basic advice to users on how to upgrade their
Node version (e.g. a link to https://nodejs.org/en/download/)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/resin-io/resin-cli/issues/603, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLUCMAs-yfApQ3XWDYbsHbt9KRg5cWcks5sTwONgaJpZM4Opjm2
.

Not really. I couldn't allocate any time to work on those projects, but I'll try to get on it soon.
—
Juan Cruz Viotti
--- original message ---
On Tue, Aug 1, 2017 at 09:57 am<EMAIL_ADDRESS>Alexandros Marinos wrote:
Wondering if it's a wake up call to just bundle it sooner. @jviotti have
you made progress with capitano/etcher CLI on this front?
--
Alexandros Marinos
Founder & CEO, Resin.io
+1<PHONE_NUMBER>
@alexandrosm
On Tue, Aug 1, 2017 at 3:53 AM, Tim Perry<EMAIL_ADDRESS>wrote:

The current Ubuntu release ships with Node 4.2.6, which the CLI does not
support (we require 6+). This suggests many Linux non-JS developers will
find the CLI harder to install than it should be. Long-term we're looking
at packaging the CLI with Node (#484
<https://github.com/resin-io/resin-cli/issues/484), but for now any
improvements here would be very useful.
For now, we still shouldn't support this version because it's out of LTS
and coming out of maintenance entirely early 2018, but it would be nice if
we at least included some basic advice to users on how to upgrade their
Node version (e.g. a link to https://nodejs.org/en/download/)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/resin-io/resin-cli/issues/603, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABLUCMAs-yfApQ3XWDYbsHbt9KRg5cWcks5sTwONgaJpZM4Opjm2
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
--- end of original message ---

This is fixed on master, and will be in the next release.


Add SLR32 to OpenSLR

I would like to add SLR32 to OpenSLR. It contains four South African languages: Afrikaans, Sesotho, Setswana and isiXhosa

And yet another one ! Thanks a lot :)

I just hope you don’t get fed up with openslr PR 😊 there are still few other datasets created by google in openslr that is not in hf dataset yet


time-inject: wrong displayed times and (multiple) wrong trigger times

Describe the bug
i use the time-inject node to trigger the garden lights at specific times depending on the sun position (on = civil dusk, off = civil dawn).
there seems to be 2 issues for me:
1.) the status which is displayed next to the node is only correct after the first deploy. when the first time the node was triggered, the new displayed value for next trigger time seems to be wrong.
For example at the moment, the displayed value for the next civil dusk is at 12.06.2020 23:45:21 which is A) in the past and B) not a correct calculated value for civil dusk for my lat/long location.
2.) it will trigger at the correct time, but also at other times. so last night, the expected time was 04:32 but it has also triggered at 01:00 and 02:20.
it is completely independent from the chosen sun set method (nautical dusk, astronomical dusk etc), they all not working. even using an exact timestamp to trigger seems not to work correctly.
i have checked the defined time and timezone on my server, it is set correctly.
Expected behavior
the status of the used nodes should display the next time when the it will trigger again. this value will be automatically updated after a trigger.
it will only trigger once in 24h, the time of the selected sun position.
System information (please complete the following information):

Node Version 10.14.1
Node-Red Version 1.0.4
sun-position version 1.1.3

Additional context
n/a
It would be nice to get some help, this things are driving me crazy at the moment.

have again checked the issue to give you more detailed information.
This is how to reproduce the bug:

create a time-inject node, configure a time where it should trigger, like 10:00 AM
deploy with "only changed nodes"
change the time in node from step 1 from 10:00 AM to 10:01 AM
deploy with "only changed nodes"

Expected Result: it will only trigger at 10:01 AM
But Result is: it will trigger on 10:00 AM and on 10:01 AM
To avoid this, the workaround is to restart the whole flows, or to restart the machine where node red is running. then it would run again as expected.

I am not sure this is related but just today nothing was injected as the node completely skipped today's date. https://imgur.com/0UNWLH1 It went from 6/28 to 6/30 skipping today's date.

I have the same issue.
This flow:

with inject enhanced node set like this:

triggers like this:

Sunset is given as 20:23:41 by the node itself.
The time shown in the node status changrs with each trigger.
The workaround suggested above to restart did not work for me.


How do I set dynamic host?

Hi,
Is there anyone encounter or trying to have dynamic deep link host?
For example I have multiple host with a similar pattern as bellow

https://test1.example.com
https://test2.example.com
https://test3.example.com

I'm wondering if we can do this with uni_link or use other way? Your help would be appreciated!

As far as I know you have to specify host for any and all https schemes, so this is a NO to your question.

@avioli thank you for your response. Actually, it's possible to do using App Linking(Android) & Universal Link(iOS). With above example, we need to provide the json verification file (assetlinks.json or apple-app-site-association) in domain https://example.com.
Anyway, thank you again for your support.


What is the difference between Teaser and Default?

I just pip installed this plugin and there is no difference between teaser and default that I can see.  I don't mind if there is no CSS for it... my problem is that there is no obvious difference, either on the page or in the HTML.  So... what is the point of the display type if it does nothing?
If it could just show up as a class in the HTML, I could easily use it to build up CSS to change the display...

Well, you are able to create a custom template to use different types of galleries in your project. You can add the display type as a css class and create some styles or even use it in an if clause to enable/disable other contents. It's up to you =)

My point was that I was looking in the HTML that you create and there are no hooks that say "default" or "teaser" in that HTML.  To do what you describe, I would have SOMETHING in the HTML - like class="default" tag that would let me hook CSS to it.
All that the code you provide does is:
{{ gallery.title }}
{% if gallery.date %}{{ gallery.date|date }}, {% endif %}{{ gallery.location }}
{% render_placeholder gallery.description "description" %}

    {% for image in gallery.get_folder_images %}

    {% endfor %}

Which means that other than the class="Image Gallery" there is nothing to distinguish your output and there is no way to identify whether my plugin setting are using "teaser" or "default"
I offer as a counter example, this:
https://github.com/bethlakshmi/cmsplugin-image-gallery/blob/master/image_gallery/templates/image_gallery/partials/gallery.html
which actually puts the display_type into the output so it can be used in some meaningful way.
I asked in case I was missing the specific way you implemented this, but you haven't provided me with any details on how I could write CSS that would actually work....

Alright, added it to the template. https://github.com/bitmazk/cmsplugin-image-gallery/commit/ab2dedcbdc42436aafdc45582a1e771cb82ea7a0


ImageConcatFromBatch node not found

After install everything got: ImageConcatFromBatch node not found

This is a error i got on ComfyUI log.
[ERROR] An error occurred during the on_prompt_handler processing
Traceback (most recent call last):
File "E:\ComfyUI_4ALL\ComfyUI\server.py", line 733, in trigger_on_prompt
json_data = handler(json_data)
^^^^^^^^^^^^^^^^^^
File "E:\ComfyUI_4ALL\ComfyUI\custom_nodes\ComfyUI_smZNodes\smZNodes.py", line 867, in prompt_handler
if node["class_type"] == "smZ CLIPTextEncode":
~~~~^^^^^^^^^^^^^^
KeyError: 'class_type'
invalid prompt: {'type': 'invalid_prompt', 'message': 'Cannot execute because a node is missing the class_type property.', 'details': "Node ID '#117'", 'extra_info': {}}

This is a new node I just added yesterday to KJNodes: https://github.com/kijai/ComfyUI-KJNodes
It's fully optional though and only used to create a final grid with the validation sampling results.


Mark B9 Procedural Parts compatible with 1.0.5.

I spent a few hours building seaplanes with this, both with and without FAR.  No issues reported on the forum.  Seems to work fine in 1.0.5.

Thanks for updating, merging with my thanks


[CI] - build fails in Visual Studio 17.6.0 Preview 3.0 - C1214 - Modules conflict with '/Zc:twoPhase'

Microsoft PowerToys version
0.69.1 / main branch
Installation method
Other (please specify in "Steps to Reproduce")
Running as admin
None
Area(s) with issue?
General
Steps to reproduce
Trying to build PowerToys main branch in Visual Studio 17.6.0 Preview 3.0 gives about 40+ C1214 errors:

C1214 - Modules conflict with non-standard behaviour requested via '/c:twoPhase'
It worked fine on 17.6.0 Preview 1.0, but started giving this error on two separate laptops when I upgraded them to 17.6.0 Preview 3.0 earlier today.
Using the "rollback" feature in the Visual Studio Installer to reinstall 17.6.0 Preview 1.0 fixed the issue - I know Preview versions shouldn't be used for production workloads so it's kind of my problem to deal with, but it might be worth checking whether there's a change queued up that could affect building PowerToys if / when it reaches the LTS version of Visual Studio...
Original version - VS2022 17.6.0 Preview 1.0 - working

After upgrade - VS2022 17.6.0 Preview 3.0 - build fails with C1214

Rollback - VS2022 17.6.0 Preview 1.0 - working again

✔ Expected Behavior
To be able to build PowerToys from source in Visual Studio 17.6.0 Preview 3.0
❌ Actual Behavior
Multiple C1214 errors
Other Software
No response

The release notes for Visual Studio 2022 17.6.0 Preview 3.0 say this:
https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes-preview#summary-of-whats-new-in-this-release-of-visual-studio-2022-version-176-preview-3

Two-phase name lookup (ISO C++ [temp.dep]) is now the default when /std:c++20 or /std:c++17 is specified. Specifying /Zc:twoPhase- is no longer required with /std:c++17. Managed templates and generics are an exception and will be compiled as before, without two-phase lookup semantics.

which looks like it's related...

I've found a machine that has VS2022 17.6.0 Preview 2.0 on it, and that builds fine as well so it looks like Preview 3.0 is the problem...

Also, changing either of these settings in C++ projects with Preview 3.0 fixes the build error, but I don't know if that would cause other issues:

Changing the "C++ Language Standard" setting to "ISO C++20 Standard (/std:c++20)" fixes the issue:

Separately, changing the "Build ISO C++23 Standard Library Modules" setting to "No" fixes the issue

@snickler has some info on this

@mikeclayton - Great find on the Build ISO C++23 Standard Library Modules option. Glad to see there's more people testing with the VS Previews. I ran into the same exact issue and partially got around some of the build issues, only to encounter more - but this option is the thing I was missing. I'll get a fix rolling for this!

@snickler - cheers, although tbh I don't properly understand what either of those settings actually do other than what I read on the documentation pages a couple of days ago :-)
I'm not really a C / C++ developer so my comment was meant more as an observation of what happened when I tried messing with some settings rather than a suggestion of what to do to fix the issue. but if it does the job then it's all good...

@snickler - cheers, although tbh I don't properly understand what either of those settings actually do other than what I read on the documentation pages a couple of days ago :-)
I'm not really a C / C++ developer so my comment was meant more as an observation of what happened when I tried messing with some settings rather than a suggestion of what to do to fix the issue. but if it does the job then it's all good...

That looks to be exactly what I was looking for in terms of making builds work again with 17.6 Preview 3. I currently have everything building properly by setting <BuildStdModules>false</BuildStdModules> so it doesn't build using modules, but looking through the documentation there may be some improvements that C++ modules could provide us in the long run which may help improve build times overall 🤔🤔.
@crutkas - What are your thoughts?


Extension loading bug

Currently loading this extension will throw an error somewhere in the worker code
Error: "/images/addon-logo.svg" is not a file.

Paths starting with "/" caused the bug.


SPIKE SageMaker Async Operator

Do SPIKE research on async Sagemaker operators

SageMakerTransformOperator

Can be implemented as an async Operator.
Create of transform job and poll for the status with the job name
Connection type is AWS default, with sagemaker arn role created and  the URI of a Docker image for handling KNN model training. To find the URI of a free Amazon-provided image that can be used,
substitute your desired region in the following link and find the URI under "Registry Path".
https://docs.aws.amazon.com/sagemaker/latest/dg/ecr-us-east-1.html#knn-us-east-2.title
Use aiobotocore lib for async connection

SageMakerProcessingOperator

Can be implemented as an async Operator.
Create the processing job and poll for the status is completed
Connection type is AWS default, with sagemaker arn role created and  the URI of a Docker image for handling KNN model training. To find the URI of a free Amazon-provided image that can be used,
substitute your desired region in the following link and find the URI under "Registry Path".
https://docs.aws.amazon.com/sagemaker/latest/dg/ecr-us-east-1.html#knn-us-east-2.title
Use aiobotocore lib for async connection


Activating terminal by clicking on the tab does not set input focus

Windows Terminal version (or Windows build number)
1.6.10571.0
Other Software
No response
Steps to reproduce
When I activate the Windows Terminal it is because I want to type into it. However if I activate the Windows Terminal by clicking on the tab (i.e.; the tab-switcher component at the top of the window) then input focus is not set and will actually be taken away.
To be more precise, if I click on the tab-switcher for the current tab then focus is taken away. If I click on a different tab then focus is set.
Expected Behavior
When I click on a tab-switcher, whether to give the terminal focus or just because I feel like it, input focus should be set to that tab. The cursor should flash and any characters that I type should be displayed.
Actual Behavior
When I click on the tab-switcher for the currently selected tab then input focus is turned off, the flashing cursor goes away, and my keystrokes go nowhere.

This sounds like issue #3609.

Sure is!
/dup #3609


Two chat windows are getting created for MS Teams Bot when installing the bot for the first time.

When user clicks on add button on the app to install the bot under Built for your org tab, it creates two chat windows in the recent section in MS Teams for that Bot. In those recent chats, one chat window stays in the draft mode, and disappears after some time or when we click on that draft chat.  Is this expected behavior?

we are seeing this issue only for our bot. When user tries to install the bot, we send thank you message and authenticate the user by using SSO. We followed the steps to enable SSO on this page: https://learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/authentication/bot-sso-overview and when user signs in successfully, we send other messages. However, in this process, sometime, we have seen our bot is creating two chats window and one chat remain in draft mode and it goes away in some time or unless we click on it.

We checked this at our end, and we are not able to repro this issue. Could you please share the deployed manifest with us so that we can check if we have a local repro. Please share manifest at<EMAIL_ADDRESS>


Add logging snippets for Javascript & typescript

Add logging snippets for Javascript & Typescript
This PR addresses https://github.com/Microsoft/vscode/issues/37839 😄
Context
One nifty set of snippets that I do miss from my time with Atom are the log, warn and error snippets for Javascript.
log  => console.log()
warn => console.warn()
error => console.error()

Changes

Added new log, warn and error snippets to extensions/javascript/snippets/javascript.json
Added new warn and error snippets to extensions/typescript/snippets/typescript.json

After Changes

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: abinavseelan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@egamma @mattbierner How do we usually balance built-in snippets vs extension provided?

@auchenberg My idea for what should be a built-in snippet:

Useful for a large number of developers
Not framework or pattern specific
Meaningfully improves writing code and does not get in the way

This one fits the first two well. As for the third, these snippers are not a huge improvement over suggestions IMO but  I do think they are a nice quality of life addition


feat(properties/HistoryCleanupProps): Add user document hint for hist…

…ory time to live for dmn
Related to https://github.com/camunda/camunda-modeler/issues/4062

Fixes #
Proposed Changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contribution. I've updated it to use our tooltips feature in https://github.com/bpmn-io/dmn-js-properties-panel/pull/82.

Superseded by https://github.com/bpmn-io/dmn-js-properties-panel/pull/82.


Using the "multiple" attribute on  has issues when setting Angular ng-model

  <option ng-repeat="option in myModel.myOptions track by $index" value="{{option.value}}>{{option.name}}

Using multiple doesn't keep the model in sync.

The control value will only show the name of the first selected item from the model and not a comma separated list from the initial model.
Options are not properly checked from the model.
Checking/Unchecking options does not properly update the model.
Including any space or returns/line feeds between the  tags and the {{}} will prevent the initial value from the model to be loaded.

Need code example, make an example on something like JSBin, and post the link here.
Closed until then.


Fix undefined ref errors in {val}ToLinkMap callbacks

Problem
There were errors when trying to reference a value in a callback function where the value was undefined because it was not referencing the correct variable name that was defined in the variable statements part of the components.
Solution
I updated how the reference was created so it is referencing the correct var name.
Additional Notes
In general I worked on simplifying the code of creating the Records value name to make sure it's consistent across each use case that needs that variable name.
Links
Ticket

GitHub issue:
Other links
Verification
Manual tests
I updates all the snapshots and went through all the snapshots changes to make sure the references to all the name changes were pointing to the correct variable.
Automated tests

[x] Unit tests added/updated
[ ] E2E tests added/updated
[ ] N/A - (provide a reason)
[ ] deferred - (provide GitHub issue for tracking)

Housekeeping

[x] No non-essential console logs
[x] All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #1130 (ece6ef2) into tagged-release/nohooks-patch (6bd127c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@                       Coverage Diff                        @@
##           tagged-release/nohooks-patch    #1130      +/-   ##
================================================================
- Coverage                         94.00%   94.00%   -0.01%
================================================================
  Files                               125      125
  Lines                              5957     5951       -6
  Branches                           1822     1817       -5
================================================================
- Hits                               5600     5594       -6
  Misses                              339      339
  Partials                             18       18

Files
Coverage Δ

.../forms/form-renderer-helper/event-handler-props.ts
99.16% <100.00%> (ø)

...react/lib/forms/form-renderer-helper/form-state.ts
98.94% <100.00%> (ø)

...act/lib/forms/form-renderer-helper/model-values.ts
92.48% <100.00%> (ø)

...act/lib/forms/form-renderer-helper/relationship.ts
93.15% <100.00%> (ø)

...b/forms/form-renderer-helper/render-array-field.ts
100.00% <ø> (ø)

.../codegen-ui-react/lib/forms/react-form-renderer.ts
96.77% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd127c...ece6ef2. Read the comment docs.


PHP Notice on lots of variables

There are many bits of logic simply checking for the existence of properties.  This throws a notice in PHP.  You can safely check for variables by using isset

I second @drewwells

@inphovore sorry to bring you back to this, but how did you solve this issue?


Update README.md

removes @thisiscoding1234's github stats and explicitly marks some things as work in progress btw


Slow download in googlecolab

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2022.06.29 (update instructions) or later (specify commit)
[X] I've searched the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
I'm using yt-dlp from googlecolab to download video and audio files from mpd link but the speed is not stable and sometimes it's very slow to download the audio file, like on the verbose output bellow, 10 minutes, for downloading 32 MB,  I don't know if this is because I'm using free googlecolab or it is from the yt-dlp itself that is slow downloading files from mpd link
this is the command that I use
!yt-dlp --force-generic-extractor --allow-unplayable-format -f video_avc1_1+audio_IND_mp4a_3 -o "Ben.10.Alien.Force.E02.%(ext)s" "the mpd link"
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
WARNING: You have asked for UNPLAYABLE formats to be listed/downloaded. This is a developer option intended for debugging.
         If you experience any issues while using this option, DO NOT open a bug report
[generic] IDN_index: Requesting header
WARNING: [generic] Forcing on generic information extractor.
[generic] IDN_index: Downloading webpage
[generic] IDN_index: Extracting information
[info] IDN_index: Downloading 1 format(s): video_avc1_1+audio_IND_mp4a_3
WARNING: You have requested merging of multiple formats while also allowing unplayable formats to be downloaded. The formats won't be merged to prevent data corruption.
[dashsegments] Total fragments: 680
[download] Destination: Ben.10.Alien.Force.E02.fvideo_avc1_1.mp4
[download] 100% of 316.29MiB in 05:14
[dashsegments] Total fragments: 680
[download] Destination: Ben.10.Alien.Force.E02.faudio_IND_mp4a_3.m4a
[download] 100% of 32.13MiB in 10:17

--allow-unplayable-format


Incorporate Araq's suggestions

From the forum reply

Your implementation should inline data elements that fit in the about 3 bytes in the payload. For example: Numbers like 0, 1, 2, 3 are common and do not have to take up space in the BiTable. Likewise for short key names like "abc". This is reasonably easy to implement and should improve benchmark results quite a bit. It also means that the typical JSON data uses even less space.
 Running time gets worse. Shrinks  in size but not substantially. Doesn't work at compile time.
literals: Size has improved dramatically, while performance slightly suffers. Doesn't work at CT. Bug-free but tests need to be adjusted.
short. Biggest improvements in both runtime and size. Code becomes spaghetti, with many if isShort-else branches. May not work at CT, but hard to tell since there's still many bugs to be fixed. New tests need to be written, and refactorings need to be done to improve code quality.

Here's the bench report of the main branch by just changing the bitable implementation to not store hashes.
extract:
  Collected 10000 samples in 3.8511 s
  Average time: 0.3759 ms
  Stddev  time: 0.0407 ms
  Min     time: 0.3672 ms
  Max     time: 1.1593 ms
parse:
  Collected 10000 samples in 10.9879 s
  Average time: 1.0874 ms
  Stddev  time: 0.0157 ms
  Min     time: 1.0521 ms
  Max     time: 1.1939 ms
toString:
  Collected 10000 samples in 5.7015 s
  Average time: 0.1715 ms
  Stddev  time: 0.0042 ms
  Min     time: 0.1693 ms
  Max     time: 0.1973 ms
fromJson:
  Collected 10000 samples in 3.9908 s
  Average time: 0.0040 ms
  Stddev  time: 0.0007 ms
  Min     time: 0.0039 ms
  Max     time: 0.0258 ms
toJson:
  Collected 10000 samples in 0.0118 s
  Average time: 0.0009 ms
  Stddev  time: 0.0003 ms
  Min     time: 0.0008 ms
  Max     time: 0.0198 ms
test:
  Collected 10000 samples in 3.9942 s
  Average time: 0.0041 ms
  Stddev  time: 0.0006 ms
  Min     time: 0.0039 ms
  Max     time: 0.0236 ms
replace:
  Collected 10000 samples in 4.0076 s
  Average time: 0.0042 ms
  Stddev  time: 0.0007 ms
  Min     time: 0.0041 ms
  Max     time: 0.0253 ms
remove:
  Collected 10000 samples in 4.1095 s
  Average time: 0.0131 ms
  Stddev  time: 0.0011 ms
  Min     time: 0.0130 ms
  Max     time: 0.0345 ms
add:
  Collected 10000 samples in 4.0237 s
  Average time: 0.0042 ms
  Stddev  time: 0.0007 ms
  Min     time: 0.0040 ms
  Max     time: 0.0239 ms
copy:
  Collected 10000 samples in 4.0739 s
  Average time: 0.0086 ms
  Stddev  time: 0.0009 ms
  Min     time: 0.0084 ms
  Max     time: 0.0283 ms
move:
  Collected 10000 samples in 4.1703 s
  Average time: 0.0180 ms
  Stddev  time: 0.0014 ms
  Min     time: 0.0176 ms
  Max     time: 0.0391 ms

used Mem: 270.281KiB

Observation that was missed: not caching hashes might be the reason that the literals branch doesn't perform as well for extract, but the size would increase as well.

Also worth noting VM performance of main versus literals. literals may take less time to execute but results in more instructions.
master:
prof:     µs    #instr  location      393166      7504  /home/antonisg/Code/dumpster/dumpster/classical_ml/random_forest.nim(10, 6)
      158747       967  /home/antonisg/Code/dumpster/dumpster/classical_ml/random_forest.nim(25, 7)
       93287    125480  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/rawops.nim(19, 6)
       91051         9  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(110, 6)
       90909        28  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(96, 6)
       90635      2656  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/extra.nim(11, 6)
       70148        10  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(87, 6)
       69893     42246  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(26, 6)
       66395     38000  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/jsontree.nim(26, 6)
       56320    176378  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/bitabs.nim(69, 6)
       48569     92468  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/jsonptr.nim(104, 6)
       40854     53276  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(354, 6)
       30273      3660  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/builder.nim(96, 6)
       20453        28  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(107, 6)
       20414        32  /home/antonisg/Build/Nim/lib/pure/lexbase.nim(137, 6)
       20274        44  /home/antonisg/Build/Nim/lib/pure/lexbase.nim(46, 6)
       20227        11  /home/antonisg/Build/Nim/lib/pure/streams.nim(244, 6)
       20176        46  /home/antonisg/Build/Nim/lib/pure/streams.nim(1209, 8)
       18145        60  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/builder.nim(27, 6)
       17385     31410  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/rawops.nim(3, 6)
       14178      1162  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/extra.nim(19, 6)
       13997      3699  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(520, 6)
       12929     53580  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(178, 6)
       12472      5886  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/jsontree.nim(106, 6)
       10551     47184  /home/antonisg/Build/Nim/lib/system/indices.nim(88, 6)
        9384     42469  /home/antonisg/Build/Nim/lib/system/indices.nim(76, 6)
        9220     39512  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/jsonptr.nim(40, 6)
        9156      3738  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(4, 6)
        6907      4814  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/builder.nim(30, 6)
        6556     26256  /home/antonisg/Build/Nim/lib/pure/hashes.nim(382, 6)
        5999     20571  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/bitabs.nim(57, 6)
        5956     23296  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(265, 6)

0.023049161999999956

literals:
prof:     µs    #instr  location      395387      7504  /home/antonisg/Code/dumpster/dumpster/classical_ml/random_forest.nim(10, 6)
      177519       959  /home/antonisg/Code/dumpster/dumpster/classical_ml/random_forest.nim(25, 7)
      117820    129508  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/rawops.nim(19, 6)
      109033      2656  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/extra.nim(11, 6)
      102605         9  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(116, 6)
      102480        28  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(102, 6)
       84329    157283  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/bitabs.nim(66, 6)
       82004        10  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(93, 6)
       81787     42246  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(32, 6)
       55803     13860  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/jsontree.nim(30, 6)
       48168     92468  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/jsonptr.nim(104, 6)
       40856     53276  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(354, 6)
       36521      6340  /home/antonisg/Build/Nim/lib/pure/hashes.nim(213, 8)
       34523     15850  /home/antonisg/Build/Nim/lib/pure/hashes.nim(165, 6)
       34516     23360  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/jsontree.nim(27, 6)
       29987     15850  /home/antonisg/Build/Nim/lib/pure/hashes.nim(117, 6)
       25492    110146  /home/antonisg/Build/Nim/lib/pure/hashes.nim(100, 6)
       24421      3660  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/builder.nim(111, 6)
       24319        60  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/builder.nim(27, 6)
       20720      5202  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/parser.nim(4, 6)
       20171        28  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(107, 6)
       20131        32  /home/antonisg/Build/Nim/lib/pure/lexbase.nim(137, 6)
       19999        44  /home/antonisg/Build/Nim/lib/pure/lexbase.nim(46, 6)
       19937        11  /home/antonisg/Build/Nim/lib/pure/streams.nim(244, 6)
       19854        46  /home/antonisg/Build/Nim/lib/pure/streams.nim(1209, 8)
       16666     31410  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/rawops.nim(3, 6)
       14121      3699  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(520, 6)
       14050      1162  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/extra.nim(19, 6)
       12834     53580  /home/antonisg/Build/Nim/lib/pure/parsejson.nim(178, 6)
       10795      2196  /home/antonisg/Code/dumpster/jsonpak/src/jsonpak/private/jsontree.nim(117, 6)
       10380     47184  /home/antonisg/Build/Nim/lib/system/indices.nim(88, 6)
        9279     42469  /home/antonisg/Build/Nim/lib/system/indices.nim(76, 6)

0.02215018999999996


Missing XML Declaration in Jelly Files -

What feature do you want to see added?
While working on the AnchorChain plugin, I discovered that several Jelly files were missing the required XML declaration:
<?jelly escape-by-default='true'?>
According to the Jenkins documentation, when migrating the <description> tag from pom.xml to a Jelly file, this declaration is mandatory.
While there is an existing OpenRewrite recipe that handles the file creation, it doesn't address cases where the file exists but lacks the required declaration.
Questions for Discussion:

Which existing PluginModernizer recipe would be most appropriate to incorporate the org.openrewrite.jenkins.CreateIndexJelly recipe?

What would be the best approach to implement the missing declaration fix:

Modify the existing OpenRewrite recipe
Create a new dedicated recipe
Use a simpler approach similar to our Dependabot solution or https://docs.openrewrite.org/recipes/text/appendtotextfile (though this may be insufficient)

Your guidance on these implementation approaches would be appreciated.
Upstream changes
No response
Are you interested in contributing this feature?
Yes. In the meantime, I will give a try at org.openrewrite.xml.XsltTransformation.

I discussed the matter there too: https://rewriteoss.slack.com/archives/C01A843MWG5/p1729698356197269 .

Perhaps plain text parsing is probably the easiest. At the end we just need to modify one line of the document ?


fix: replace use of deprecated set-output

Summary

fixes #83
Replaces set-output command with suggested alternative
- echo "::set-output name=markdown::$(echo $UPDATE)"
+ echo "markdown=$(echo $UPDATE)" >> $GITHUB_OUTPUT

Type of change

[x] Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

[ ] Added or updated test cases to test new features

Thanks for contributing :tada:


Change console/log data to use the in-memory queue due to unexpected …

Change console/log data to use the in-memory queue due to unexpected back pressure from the kernel when using sockets.

Resolves #101


Addition of multiple authors at once not possible

Describe the bug
Under "manage authors" you can import the author information with the ORCID. Doing so enables two buttons "Add all" and "Add selected". This implies you can add multiple authors at a time, however importing a second author overwrites the first entry.
To Reproduce

Click on a project
Click on Edit  (under Author)
Click add author
Copy and Paste a valid ORCID
Click Import
Copy and Paste a second valid ORCID
Click Import
The previouse entry gets overwritten

Expected behavior
A second (new) entry should be created so you can add multiple entries at the same time.
Screenshots

Desktop (please complete the following information):
Win 10 Pro Version 21H2
Firefox 107.0 (32-Bit)

Dear @tditfe ,
This is not a bug.
For each import, you must click the Add button, to add your entry to the list.

Well I guess this is the classic dilemma, bug or feature xD...sorry for the mislabel i am quite new the whole writing an issue thing.
But you are saying this is supposed to work this way? The problem i am trying to convey is that you have two buttons both of which imply that i can add multiple authors (entries) to the list in one go. So i guess the way to avoid the confusion is simple get rid of one button and relabel the other button to "add"

@NRayya update on this please?


Duplicate check ignores transformation value

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request/question

Current behavior

When you have allowDupes = false and a transform defined, you are able to add duplicate items.
Expected behavior

Duplicates should be detected based off of the transform function -- which should not allow duplicate items.
The findDupe function should transform the tag.value (or it should be transformed sometime before hand.
Code in question.
Minimal reproduction of the problem with instructions (if applicable)

    public transformer(text: string) : string {
        return text + "Test";
    }

<tag-input
        [(ngModel)]="promptItems"
        [blinkIfDupe]="true"
        [allowDupes]="false"
        [transform]="transformer"
        #input
        >
    </tag-input>

What is the motivation / use case for changing the behavior? (if applicable)

To not allow duplicate items.
What do you use to build your app? (SystemJS, Webpack, angular-cli, etc.). Please specify the version

"@angular/cli": "^1.0.3",
"@angular/compiler-cli": "^4.1.2",
"@angular/core": "^4.1.2",

Angular version:

"@angular/core": "^4.1.2",

ng2-tag-input version:

"ng2-tag-input": "1.3.3",

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

all

You can work around this bug by:
    public onAdding(tag : any) : Observable<any> {
        tag.value = tag.value + "Test"; // use your transform function here

        return Observable.of(undefined)
                         .mapTo(tag);
    }

<tag-input
        [(ngModel)]="promptItems"
        [blinkIfDupe]="true"
        [allowDupes]="false"
        [transform]="transformer"
        [onAdding]="onAdding"
        #input
        >
    </tag-input>

Hi @tonysparks,
thanks for this. I deprecated transform and your workaround is now the recommended way

@tonysparks thanks for this. Actually it transform the first letter of the string to uppercase.
However when I select the tags from the tag-input-dropdown, it does not add the selected tag.
This is my view
`
<tag-input (onRemove)="RemoveTags($event)" [modelAsStrings]="true" [validators]="validators"
[errorMessages]="errorMessage" (onAdd)="onTagsAdded($event)" [onTextChangeDebounce]="50" [maxItems]='3'
separatorKeyCodes='[{9, 32}]' [secondaryPlaceholder]="'Enter your indicated tags...'"
[placeholder]="'Enter your indicated tags...'" [(ngModel)]="InputTags" [identifyBy]="'value'"
[displayBy]="'display'" [addOnBlur]="true">
<tag-input-dropdown [appendToBody]="false" [showDropdownIfEmpty]="true" [autocompleteItems]="UserTags"
[identifyBy]="'value'" [displayBy]="'display'" [dynamicUpdate]="true" [keepOpen]="false">

`
This is my component.ts
public transform(value: string): Observable<object> { 		const item = { display: ${value.charAt(0).toUpperCase() + value.slice(1)}, value: ${value.charAt(0).toUpperCase() + value.slice(1)} }; 		return of(item); 	}
Please tell if I made mistake here. Thanks


🚀 Feature: Capitalize Kind Facets in Catalog Table Title

🔖 Feature description
Use the properly capitalized version of the entity Kind in the Catalog Table. This is what it should look like:

🎤 Context
Currently the default CatalogTable shows a dynamic title based on the Kind and Type filters. Kind is a special case because there is a properly capitalized version (eg Component) which shows up in the Filter/Picker but under the hood we use a lowercase version (eg component). Unfortunately the current title construction only has access to the filter value so you get the lowercase version in the title.

✌ Possible Implementation
I tried two different approaches for this before opening this issue:

https://github.com/backstage/backstage/pull/27590 adds a label attribute to the EntityKindFilter and then pulls that if it is set when constructing the table title.
https://github.com/backstage/backstage/pull/27603 exports the useAllKinds() hook and uses that to retrieve the labels for a given Kind filter value when constructing the table title.

Both of them work functionally, but I think they both have similar issues at the React level (which I am far from an expert with) and both seem to have test-time issues which I haven't been able to fully resolve.
I am looking for advice on which of these two approaches is preferred, or if there is an even better third option (likely) that I haven't considered.
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Related question, is there ongoing work to change how the CatalogTable toolbar/search/title works as implied in this TODO?
https://github.com/backstage/backstage/blob/13180c52602fbd3c6c8a719711ddbf7fa35d52e2/plugins/catalog/src/components/CatalogTable/CatalogTable.tsx#L174
cc @timbonicus

which version of Backstage are you using? It looks correct on demo.backstage.io

No, that page shows All components (16) -- it should be All Components (16) (note the capital C)

After discussing with a coworker who knows more about react, I've reworked my second approach into https://github.com/backstage/backstage/pull/27648 and have all the tests passing.
The only thing I'm concerned about is a visible re-render on the CatalogTable, but I can see this on master with no changes as well so I don't think I've broken anything.

Looks like the APIS/APIs issue is well known in the pluralize library: https://github.com/plurals/pluralize/issues/127

Thanks for the suggestion @tylerd-canva 🙏
Could you share more about the reasoning for why it should be capitalized?

It's capitalized everywhere else in the UI, including in the Kind picker/filter visible on the same page. Mostly it just looks bad without the capitalization. components is an innocent example but we have a few more custom Kinds in my org, for example UserOperation and UserFlow. useroperation and userflow looks WAY worse in comparison.


odo config set allows setting an environment variable with blank value its name

@amitkrout thanks for picking that up. It's affecting the odo config set --env as well (which is not a part of this PR):
# when using zsh
$ odo config set --env ""=hello
zsh: hello not found

# now switch to bash
$ bash

$ odo config set --env ""=hello
Environment variables were successfully updated.
Run `odo push --config` command to apply changes to the cluster.
[dshah@think nodejs-ex]$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
        hello

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-fsfk
MinMemory
MaxMemory
DebugPort
Ignore
MinCPU
MaxCPU

Originally posted by @dharmit in https://github.com/openshift/odo/pull/2275#issuecomment-546250604

It also allows user to set blank value for environment variable:
re successfully updated.
Run `odo push --config` command to apply changes to the cluster.

$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
foo

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-fsfk
MinMemory
MaxMemory
DebugPort
Ignore
MinCPU
MaxCPU

Should we disallow this. Just that if someone is doing it. They are aware of what they are doing?
And setting blank value is something that is a conscious decision?

Yes, if a user is doing this, they are aware of what they are doing. Keeping a check for this is pain in the butt from code point of view. Funny thing is that, in its current form, you could set the environment variable with empty name but you can't unset it.
$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
hi      hello

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-fsfk
MinMemory
MaxMemory
DebugPort
Ignore
MinCPU
MaxCPU

$ odo config set --env ""=hello
Environment variables were successfully updated.
Run `odo push --config` command to apply changes to the cluster.

$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
hi      hello
        hello

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-fsfk
MinMemory
MaxMemory
DebugPort
Ignore
MinCPU
MaxCPU

$ odo config unset --env ""
Environment variables were successfully updated.

$ odo config view
ENVIRONMENT VARIABLES
------------------------------------------------
NAME    VALUE
hi      hello
        hello                <------ But we just did an unset to remove this!

COMPONENT SETTINGS
------------------------------------------------
PARAMETER         CURRENT_VALUE
Type              nodejs
Application       app
Project           myproject
SourceType        local
Ref
SourceLocation    ./
Ports             8080/TCP
Name              nodejs-nodejs-ex-fsfk
MinMemory
MaxMemory
DebugPort
Ignore
MinCPU
MaxCPU

/priority medium

/kind bug

Empty value is a valid case. We shouldn't prevent that.
Empty variable name (key) doesn't make sense, we should have validation check for it.
But to be honest, not sure if I would worry about this much. How can user end up running something like this odo config set --env ""=hello?
/priority low
/remove-priority medium

/remove-lifecycle stale

I think this is an edge case which probably doesn't need to be dealt with. I purposefully tried this to break things. But, I agree that it doesn't make sense from user point of view to do what I've mentioned in the issue description.
Closing.


Firefox issue

Replace event.srcElement with event.target || event.srcElement
Right now firefox handles key presses

awesome!

nice 👍 . any timeframe on when this will be published?


Google Adsense ads.txt file

Google adsense is still showing me an error and asking me to fix it by adding ads.txt file on the root of my website. How do I do it? When I upload on root, and try to access it, the Jekyll engine shows a 404 page...

Not sure, this isn't a Jekyll or theme issue. You'll have to dig into Google's support for resolution.


Re-implement container functionality

This PR re-implements the user-specified container element functionality, this time with the following "features":

optionally specify the container as a css selector or a DOMElement
Uses the container element's top to determine scroll direction when pageYOffset is constant, but falls back to using pageYOffset where possible
checks for scrollable container elements and throws errors to indicate when direction calculations will fail
when container is not specified, checks the DOM tree above the step elements for scrollable parent containers and throws errors when scrollable parent containers are found.

I added quite a few test cases in the form of html files to dev/container-tests/.  These outline a number of use cases where errors might be thrown and where scrollama should behave as expected.  Please let me know if you can think of other test cases or ways this functionality might affect other functionality that exists in scrollama.  I'm open to deleting these test files to avoid cluttering up the repo, but I found them useful for testing this functionality.

Thanks for putting the time into this! I cloned your repo and started playing around with the demos. Admittedly there is a lot going on so I need to spend a bit more time reviewing. One thing I noticed is that the examples don't seem to produce a container that has its own scrollbar (which I think was part of the initial desire). I'll keep exploring though and let you know if I have other questions.

No problem. Glad to help! I fixed the issue you mentioned with scroll bars not showing up in the containers.  I had followed the example from the previous PR and used a height: view height, which worked on a small screen I was working on, but not on larger ones....the perils of using vh.
Unfortunately, I couldn't find a way to consistently determine scroll direction when the step container is scrollable, mainly due to the issue of determining which container is being scrolled at any given time. This is true whether a container element is specified or not (example 01-no-container-with-overflow-on-container-not-wrapper.html shows the no-container case).  What I tried to do was to outline some use cases where we can't accurately determine scroll direction and alert the user of those cases, which hopefully will be useful going forward.  Given that, I've come around to the idea that the container functionality might create more problems than it solves.
Maybe it's a good idea to keep the error checking and leave the container functionality out?  I'm open to whatever you think is best.
Also, if you have ideas about how to determine scroll position within a scrollable step container, I'm all ears!

sorry for the long delay...

Given that, I've come around to the idea that the container functionality might create more problems than it solves. Maybe it's a good idea to keep the error checking and leave the container functionality out?

Would you be open to just doing a PR that does error checking but doesn't have the container functionality?

I'd be happy to! See #106.
I'm closing this PR now.


add pagination to gallery

How would it be?

Like having some amount of games on each page, choose a page at the bottom.

I'm not sure I see a need for this now. Maybe if we have hundreds of more games it will become necessary. I think I still prefer infinite scrolling. Is a there a particular reason you suggest this?

On some slower devices, it can take a while to load everything. For instance, a new computer I got is only 4gb of RAM, and it takes a while to load. Limiting it to say, 20 items on each page could make it faster.

@leomcelroy given the feedback below do we want to do this?

We could add a dropdown that allows the user to choose the amount of games to display per page, up to all at once.

I believe this isn't an issue anymore? The new gallery, in my experience, is a lot more performant than the old one. I'm gonna close this but if it's still an issue I guess we can look into pagination (or just more perf optimizations).


improvement(es): Support custom field types on map type properties

Codecov Report

Merging #1054 (20c2507) into 8.x (f2886fc) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                8.x    #1054      +/-   ##
============================================
- Coverage     64.53%   64.50%   -0.03%
- Complexity    12347    12354       +7
============================================
  Files          1715     1716       +1
  Lines         57346    57408      +62
  Branches       5325     5331       +6
============================================
+ Hits          37006    37031      +25
- Misses        18060    18093      +33
- Partials       2280     2284       +4

Impacted Files
Coverage Δ

...m/b2international/index/es/admin/EsIndexAdmin.java
80.80% <50.00%> (-0.62%)
:arrow_down:

...nowowl/core/rest/resource/ResourceRestService.java
61.36% <0.00%> (-35.07%)
:arrow_down:

...com/b2international/index/es/EsDocumentWriter.java
68.50% <0.00%> (-2.69%)
:arrow_down:

...owowl/core/uri/DefaultResourceURIPathResolver.java
87.23% <0.00%> (-1.41%)
:arrow_down:

...ernational/snowowl/core/jobs/RemoteJobTracker.java
91.30% <0.00%> (-0.63%)
:arrow_down:

...src/com/b2international/snowowl/core/Resource.java
86.81% <0.00%> (ø)

...wl/core/rest/resource/ResourceUpdateRestInput.java
0.00% <0.00%> (ø)

...rnational/snowowl/core/internal/SnowOwlPlugin.java
98.24% <0.00%> (+0.03%)
:arrow_up:

...owl/core/request/version/VersionCreateRequest.java
87.12% <0.00%> (+0.75%)
:arrow_up:

.../b2international/index/es/client/EsClientBase.java
68.42% <0.00%> (+2.51%)
:arrow_up:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


"Argument list too long" error occurs when building a package with a large dependency set

Upstream unsets only NODE_PATH:
https://github.com/adnelson/nixfromnpm/blob/b89beeaf6e8c59f6a74633ab77f233b50d2654de/nix-libs/nodeLib/buildNodePackage.nix#L446
... but not NIX_LDFLAGS.
With a large number of deps, these env vars (NODE_PATH and NIX_LDFLAGS) can grow quite large (>128k), such that leaving them exported and attempting to invoke shell commands can lead to misleading "Argument list too long" errors, which actually indicate that kernel-limited env space has been exceeded.
We patch nixfromnpm to unset NIX_LDFLAGS but we think a better solution would instead use something like passAsFile instead of exporting the environment variables.

To be honest I’ve never used passAsFile and am not sure what would be needed to get that to work. Do you think you could make a PR? In any case it might be good to have a test case for this (although it might by necessity take a long time to run).


Fix docs building in CI

Fix docs building in CI. This was broken by #592, but wasn't noticed until the PR landed because the workflow only runs on main, not PRs.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.75%. Comparing base (41248ed) to head (46a39eb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   92.55%   92.75%   +0.20%
==========================================
  Files          91       92       +1
  Lines       11304    11236      -68
  Branches     1581     2058     +477
==========================================
- Hits        10462    10422      -40
+ Misses        837      814      -23
+ Partials        5        0       -5

Flag
Coverage Δ

cpp
92.75% <ø> (+6.81%)
:arrow_up:

python_and_cython
92.75% <ø> (-2.97%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix and re-enable MSI build

This supersedes #661, though it does not enable deployment yet.

I want to see if this works on AppVeyor, but there seems to be a problem with AppVeyor right now ...

Looks like this works. I will remove the last commit as soon as this is reviewed and the AppVeyor SSL revocation issue is solved.
@brson @Diggsey I'm able to work a bit more on the MSI installer during the coming 2–3 weeks (but probably not after that ...). I'm going to need some help and guidance from the maintainers, though.

:umbrella: The latest upstream changes (presumably #1230) made this pull request unmergeable. Please resolve the merge conflicts.

Thanks for this @Boddlnagg and sorry for the delay! It looks like this is just a few fixes here and there, so if you'd like to rebase and remove the temporary commits, I can r+ to land this

@alexcrichton Thanks! I did the rebase.

The CI failure is weird: error: failed to parse lock file at: C:\projects\rustup-rs\Cargo.lock. Running with --verbose gives
Caused by:
  package `gcc 0.3.50 (registry+https://github.com/rust-lang/crates.io-index)` is specified as a dependency, but is missing from the package list

Other crates in the same workspace use gcc 0.3.51 and manually changing the version in the lockfile makes the error disappear (I'm adding that to the PR). But I don't really understand what's going on. Is this expected behavior for cargo?

Oh nice! In that case...
@bors: r+

:pushpin: Commit eaed698 has been approved by alexcrichton

:hourglass: Testing commit eaed6985914831a05351da7c40e104613aba7502 with merge c4e7616c565630d0ad93767ec8676c8a570995c5...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c4e7616c565630d0ad93767ec8676c8a570995c5 to master...


Release 1.9.1

Based on master + #846 after it lands on master

Good call.

Released everywhere.


install microk8s in packer, then microk8s leave at run-time

This is a proof-of-concept that we can install microk8s in a packer image to ensure that part is reliable, then we can leave  the old cluster from the packer build during cloud-init.

depends on: https://github.com/polyseam/packer-cndi-node


[sysrst_ctrl] First doc update pass

This addresses #10099 and also corrects the default debounce timer configurations for some of the timers that were set to 0.
CC @patel-madhuri

wanted to change the reset value?

Which reset value are you referring to exactly (sorry I may have missed something)?


[codespaces] Install additional tools for puppeteer to work out of box

fixes #706
Adds in the bare minimum for a seamless out of box experience for the node library Puppeteer on Codespaces.
Validated with this example project: https://github.com/joshspicer/puppeteer-example
Guidance from the puppeteer docs: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#chrome-headless-doesnt-launch-on-unix

For anyone else coming here and struggling to get Puppeteer up and running, I think these deps are a bit out of date now. Installing the Debian deps listed in the official troubleshooting guide got me up and running:
https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md#chrome-headless-doesnt-launch-on-unix
This was my final dev Dockerfile.


Warn when throwing away the results of known-pure functions

TypeScript code being linted
let actions: number[];
...
actions.concat()

Actual behavior
The code passes.
Expected behavior
TSLint warns you that the you're throwing away the result of actions.concat
I'm not sure if this is out of scope for tslint, but a common mistake is to assume that .concat() modifies the state of this because concat  is poorly named and many other languages do the stateful thing. Same story for Array.prototype.push.

My point about push was poorly communicated. I mean that you could also write a rule that prevents you from doing:
let e = arr.push(4);

@leeavital As of now, you can use the no-expression-statement rule from tslint-immutable and no-map-without-usage from tslint-clean-code.

Note: per #4534, this issue will be closed in less than a month if no PR is sent to add the rule. If you really need the rule, custom rules are always an option and can be maintained outside this repo!

💀 It's time! 💀
TSLint is being deprecated and no longer accepting pull requests for new rules. See #4534. 😱
If you'd like to see this rule implemented, you have two choices:

Recommended: Use typescript-eslint to lint your TypeScript code with ESLint ✅
Legacy: Write it as a custom TSLint rule 🤷♂

👋 It was a pleasure open sourcing with you!
If you believe this message was posted here in error, please comment so we can re-open the issue!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


RO-4193 Update master dependencies

Automated dependency update pull request, see individual commits for details.
Issue: RO-4193

recheck_xenial_no_artifacts_swift_deploy

Added do not merge as https://github.com/rcbops/rpc-openstack/pull/3025 needs to merge first, then we can rebase this patch for the other stuff.


refactor to allow creating our own instance of SimpleSchema

Hi, I've adding additional properties for SimpleSchema beyond those automatically added from json-simple-schema by using .toSimpleSchemaProps(), which I add in this PR. I thought this might also be useful for others, so I'm submitting it for your consideration.

Thanks for the contribution. I'll publish it in a few minutes, after I add a test and update the documentation.


Demos

http://codepen.io/tomhodgins/pen/oLbXxG
... that one should be:
@element p and ...
as is it just starts out limegreem for the button that I assume you wanted to change when lots of text was inserted
Overall, sounds cool, especially for truncation; but adding debounce or throttle mechanism to help performance might be a good idea

Hi @petty! Thanks for your interest. If you look at all of the feature demos on one page you can see how the min-lines and max-lines demos work in context with all the other demos. The main thing to illustrate is that the demo changes after a certain number of lines are contained within the element :)
As for a debounce/throttle mechanism - I'm happy to let you know that we have that in place already! EQCSS.apply() will recalculate the styles immediately when called, while EQCSS.throttle() can be used as well and is throttled. The events that EQCSS.js automatically watches use EQCSS.throttle by default, so performance shouldn't be an issue using the default settings, though we allow you to manually trigger recalculations exactly when you need to as well.

So check this code pen out:
http://codepen.io/tomhodgins/pen/oLbXxG
That CSS should be
/* Max-lines */
@element p and (max-lines: 5) {
.maxlines {
background: greenyellow;
border-color: limegreen;
}
}
... then editing the text or loading with text that exceeds 5 lines changes the color.

What does this demo do:
http://elementqueries.com/demos/flyout.html
... in Chrome I don't see it do anything, from the link off of Github for your project.
Maybe it only works locally??

Other demos (again from your project page on Github) only work after resizing after the window loads:
http://elementqueries.com/demos/blocker.html#

Hi @petty! I've recorded a video of me using the max-lines demo so you can see how it works!  A couple things to note:

the div id set to contenteditable so you can interact with it and add lines
there is no explicit  tag inside that element.

So no changes are needed to this demo for it to work. Here's the video of me interacting with it:

As for the scrolling demos where the scroll is set on body or html — those demos will be working again here shortly. Previously (when those demos were built) we were calling EQCSS.apply() on scroll events, but that's unnecessary for performance reasons if we don't need to be watching it - so we switched it around so that only elements with m**-scroll-* conditions were watched for scroll with EQCSS.throttle(). The issue you're noticing is that browsers think about body and html elements differently than other elements, so we're working on a fix for this which will watch window instead for scroll if the element is body or html. You can check out progress toward that fix in Issue #20 here, and a fix should be released for this soon :D
In the meantime I've added this to the flyout and scroll blocker demos so they'll work as originally intended:
  <script>window.addEventListener('scroll',EQCSS.throttle)</script>


sdk/go.mod not bumped to v2

It looks like when v2 was release the sdk/go.mod was missed. The docs were updated, but running the command from the docs results in an error due to the sdk/go.mod file not having the v2 suffix.
❯ go get github.com/pulumi/pulumi-mongodbatlas/sdk/v2/go/...

go get: module github.com/pulumi/pulumi-mongodbatlas/sdk@upgrade found (v1.7.0), but does not contain packages matching github.com/pulumi/pulumi-mongodbatlas/sdk/v2/go/...

Hey @jacobfoard
Apologies for this - I will make a release for this right now
Paul

Hey @jacobfoard
Take v2.0.1 for a spin and let me know if there are any other issues
Paul

@stack72 Just verified, looks good!
Thanks so much for the quick response!

My apologies for it not being correct to start with :)


Server.app for FRI 1.16

Could you please provide the equivalent Server.app version for FRI 1.16?
Thank you very much.

Hi @pala5, sorry I personally don't have access. The app for 1.15 should, however run fine: https://github.com/lbr-stack/fri/blob/ros2-fri-1.15/server_app/LBRServer.java
if you could check and contribute, that would be awesome!
Alternatively, @BoWangFromMars uses FRI 1.16. Maybe he can help out.

Thanks @mhubii. True, I was already using the 1.15's app. I'll test it further tomorrow. I'll let you know.

Hi @mhubii, good news from my side. As you have said, Server.app for FRI 1.15 works well. Could it be nice to note it on the README, or maybe even better, rename the branch as ros2-fri-1.15-16. It is just a suggestion.
Thank you!

hi @pala5 thank you for coming back. Let's keep this issue open for now. As you said, this isn't properly documented, nor is the server application at the right location

hi @mhubii I would like to do it!


SA1003 and SA1022 are reported for the same whitespace error

In the following code, both SA1003 and SA1022 are reported for the + token. In this situation, SA1003 should be suppressed.
var x = + 3;

Grabbing this.


[COASTAL-1411] Add CustomAlert with image support

https://tidepool.atlassian.net/browse/COASTAL-1411

I also don't see code that is showing how this is used; that's important to evaluate this kind of change.


ScamDetector crash due to metamask code v. 2.18.2

{
"error":"duplicated key not allowed",
"level":"error",
"msg":"INSERT INTO "labels" ("created_at","updated_at","deleted_at","source_id","label","entity","unique_id","document") VALUES ('2023-08-18 00:52:37.799','2023-08-18 00:52:51.18',NULL,'0x47c45816807d2eac30ba88745bf2778b61bc106bc76411b520a5289495c76db8','scammer','polkstarter.xyz','0xc793e9517d075f039d47cf4e25274aaae1fac65f962ccd1153bd9c634b28d2e5','{"id":"0x857c158b9fef356e5bc446fc9ae5607cbd39af823d39d3d9ed9fe33f8e2de713","created_at":"2023-08-18T00:52:37.79919256Z","label":{"label":"scammer","confidence":1,"entity":"polkstarter.xyz","entityType":"URL","remove":false,"metadata":["address_type=","bot_version=2.18.2","chain_id=","comment=","label_version=2.1.0","logic=manual","reported_by=Metamask ","threat_category=ice-phishing"]},"source":{"bot":{"image":"disco.forta.network/bafybeieqxg75lhba7wnkblaotsqhlfx5yxb6fyb2lzyqs4lw5od2q4w55m@sha256:96d61328a7dbc13a3134b366743790601e387c22d12fff83c3b30320f0174b2a","imageHash":"96d61328a7dbc13a3134b366743790601e387c22d12fff83c3b30320f0174b2a","id":"0x47c45816807d2eac30ba88745bf2778b61bc106bc76411b520a5289495c76db8","manifest":"QmXExNQD4F464aYzJzF1qhMZ6N3GKh7chZwDxaoMJKCn7G"},"alertHash":"0x959e6ed08b9a6a4ff0449fddc5c0a57c93eb30e614a473c851722d877ba00e27","alertId":"SCAM-DETECTOR-MANUAL-METAMASK-PHISHING","chainId":56,"id":"0x47c45816807d2eac30ba88745bf2778b61bc106bc76411b520a5289495c76db8"}}') RETURNING "id" [1.315523ms]",
"time":"2023-08-18T00:52:51Z"
}

vasilis not able to reproduce; unable to deploy the bot due to missing secrets file.
christian to send instructions on how to deploy.


Update specs2-core to 4.12.8

Updates org.specs2:specs2-core from 3.+ to 4.12.8.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

labels: test-library-update

Superseded by #33.


PyYAML fixed dependency is blocking most of the projects depending on this library

Please upgrade PyYAML as soon as possible. For the moment the OpenCTI connector will not be released / updated until this will be done: https://github.com/OpenCTI-Platform/connectors/tree/master/external-import/intel471.

Fixed


Commit failure unhandled, database left in unusable state

When sqlite is used from multiple processes at the same time, COMMIT may fail with "database is locked" error.
After that happens, all subsequent transactions in rusqlite fail with "cannot start a transaction within a transaction".
I think this is because:
    fn commit_(&mut self) -> Result<()> {
        self.committed = true;
        self.conn.execute_batch("COMMIT")
    }

Sets self.committed = true; without checking whether commit has succeeded, and when COMMIT fails, the transaction remains open — forever.
It should probably be:
    fn commit_(&mut self) -> Result<()> {
        self.conn.execute_batch("COMMIT")?;
        self.committed = true;
        Ok(())
    }

Random thoughts:

either use the sqlite3_get_autocommit method and remove the committed flag.
or do a rollback when a COMMIT fails.


Add ImmutableCreate2Factory supprt

Support for Another Factory Type in Create2 Deployment
I have added support for another factory type for create2 deployment. You need to specify this in the root hardhat config as follows:
deterministicDeployment: {
    '137': {
        factory: '0xCAcc283126Cc22204f6538dA7751E1eEb29f4C48'
    }
}

const deployResult: DeployResult = await deploy("TestDeployContract", {
        from: deployer,
        log: true,
        args: [100, 200], // Unlock timestamp in seconds
        waitConfirmations: 1,
        deterministicDeployment: "0x11111",
    });

I have tested deploying contracts with and without proxy
const deployResult: DeployResult = await deploy('UpgradeableTestDeploy', {
    from: deployer,
    log: true,
    waitConfirmations: 1,
    deterministicDeployment: "0x0a0a0a",
    proxy: {
      execute: {
        init: {
          methodName: "initialize",
          args: [100, 200],
        },
      },
      proxyContract: "OpenZeppelinTransparentProxy",
    },
  });

@wighawag Hi
Can you find some time to check pull request?

Hi @ifelsedeveloper can you explain the rationale behind this PR ? What it do that current factory deployment setup could not do ?


Update DirectPostAuthorizeResponse.php

An update to @funju47shin pull request.

:+1:

Should be a fix for #5

Please confirm that this works in production then I will tag for release.

Thanks @delatbabel. Give me a week to get back to you. Work is a bit crazy.

@delatbabel tested with the master branch in my machine it works fine, received Approved transaction with   sandbox credentials.

@delatbabel  yep this worked for us. Any chance of a tagged release so we can use composer again?

Tagged as v2.1.1

@delatbabel Awesome !


Repo sync for protected CLA branch

The pull request is created from master637641253125471386 to master to fix git push error for protected CLA branch

@shsagir : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Drag and re-order files before upload

I have received a report from a user that a feature disappeared recently. Previously it was possible to drag and re-corder files before uploading them. Now it is not possible any more. Is this intentional?
I have checked the documentation and commit log but could not find anything related to this change.

@kelong @clementmas No drag and drop yet but I've added file sorting in version 4.0.0

Hi, when you finish drag and drop file sorting, could you also change hidden input field "filepond" with file ID to an array (<input type="hidden" name="filepond[]" value), or to filepond1 .... filepond100000 :). So it will be easy to write sorting to db on server (now I receive only one variable filepond) Thank you.

@smickar are the files not sorted correctly?

Hi, it is not about sorting, but about that every file hase same hidden input name "filepond". So when I submit form with Filepond I receive only one variable "filepond", even if I have xx files.

@smickar, that's basically how it works at the moment, this is how the PHP boilerplate functions: https://github.com/pqina/filepond-boilerplate-php

Hope ti see manuale sorting soon

Also hoping to see this feature implemented!

hi @rikschennink, is there any development about drag and drop sorting?

I've developed a tiny prototype but so far haven't had time to work on it further.

I did not find any uploader with manual sorting :(

@KilledDebtor I think this one is a good example: https://innostudio.de/fileuploader/

I have written a simple plugin for this: https://github.com/yqlim/filepond-plugin-drag-reorder
It has been tested for ajax submission. It has not been tested with FilePond upload feature however.

Is the prototype code available somewhere? I am also super interested in this feature. I agree with a previous comment that it should apply to existing files (I want to implement a way to manually sort existing + new images and save them with their sequence information). @yqlim solution might do the trick though, I need to test it out. Thank you!

There is a work around until the official solution gets pushed. It's rough, but it gets the job done.

In filepond.js create a global variable just after 'use strict' to store an index value.
`(this, function (exports) {
'use strict';
var idx;
var isNode = function isNode(value) {
return value instanceof HTMLElement;
};`

In the write$5 (around line 8913) function, assign the value of dragIndex to your global index variable.
// get index  	var dragIndex = dragCoordinates  		? getItemIndexByPosition(root, dragCoordinates)  		: null;  	idx = dragIndex;

Declare a function variable in the public API section that returns your global index variable.
`//
// PUBLIC API -------------------------------------------------------------------------------------
//
var setOptions = function setOptions(options) {
return store.dispatch('SET_OPTIONS', { options: options });
};
 var getFile = function getFile(query) {
 	return store.query('GET_ACTIVE_ITEM', query);
 };

 var getDraggedIndex = function getDraggedIndex() {
 	return idx;
 }`

In the createOptionAPI declaration around line 11496 create a reference to the function you created above.
`createOptionAPI(store, defaultOptions),
{
/**
* Override options defined in options object
* @param options
*/
setOptions: setOptions,
 		getDraggedIndex: getDraggedIndex,`

Now that you have a reference to the index, you can use this with your FilePond instance. In the addfile event, make each file added draggable, then add dragstart and dragend event listeners.
`$('.filepond--list').children().attr("draggable", true);
 		var imgs = document.querySelectorAll(".filepond--item");
 		[].forEach.call(imgs, function(col) {
 			col.addEventListener('dragstart', dragStart, false);
 			col.addEventListener('dragend', dropped, false);
 		});`

In dragstart, get the file id from the event target id, store the file in a new variable, then remove the file from the FilePond instance. Then in the dragend function get your index value and add the new file at that index.
`var newFile;
 function dragStart(event) {
 	var itemId = event.target.id.substring('filepond--item-'.length);
 	newFile = pond.getFile(itemId);
 	pond.removeFile(itemId);
 }

 function dropped(event) {
 	var index = pond.getDraggedIndex();
 	pond.addFile(newFile.file, { index: index });
 }`

👉 https://twitter.com/rikschennink/status/1205139448360509442?s=20

Looking good. Can't wait for the update. I've hacked together a rough drag and drop reordering so it'll be nice to have something cleaner to work with.

First reorder by drag/drop has been added in 4.9.1.

Enable with allowReorder
Only works in column mode (not yet in grid)
Only works on browsers that support Pointer Events, that's most browsers nowadays.
Works when files list shows scrollbar but still needs some tweaks.

@rikschennink You made my day ! Really nice, thanks for your work !

@rikschennink Thanks a lot for this update! Is there (or will there be) a Callback for listening to reordering events? Or is there another way to get the order of the files when it changes?

@nusoft That sounds like a good idea. It currently does not trigger any events.

@rikschennink I enabled allowReorder but it didn't work with me.. I just want to get the order of elements once I submit the form. How would I do that?

Hi @OneMajed I don't understand how this is related to re-order, can you elaborate

Currently, I am sending the images using ajax.
What I need to achieve is once I submit the form with the images, I need the images order to be sent to my backend with the same order displayed. How can I receive this list (for example as a json)
Thanks @rikschennink

@OneMajed getFiles should return the correct order.

Thanks @rikschennink it worked with me

Any plans to support grid reorder. Only works in column mode.

@prince272 https://github.com/pqina/filepond/pull/421

Now available in 4.15.0


Automate - Quota - Fixed google storage requested.

@gmcculloug
Please Review

@billfitzgerald0120
Can you rebase and push this PR again.
https://github.com/ManageIQ/manageiq/pull/8451 fixed a sporadic error, which is failing for you on Travis

@billfitzgerald0120
Let me close and re-open it, it should pick up the latest changes.

@mkanoor
Please Review

👍
@gmcculloug Should this be back ported to Darga