API register call should respond with a context token for guest users

Description
The shopware api documentation (https://docs.shopware.com/en/shopware-platform-dev-en/store-api-guide/account?category=shopware-platform-dev-en/store-api-guide#register) says, that either /store-api/v3/account/register or /store-api/v3/account/register-confirm gives a logged in context-token. Unfortunately this token doesn't exist as a part of the  response data for registrations as a guest. The new token only exists in the response header. This new token can only be accessed when the webserver is properly configured with Access-Control-Expose-Headers sw-context-token. Otherwise, clients like e.g. axios won't expose this custom header.
The solution to this should be, that the sw-context-token is part of the response data, just as it is in other api calls (e.g. login).

This issue makes a checkout process as a guest impossible via store-api endpoints. Until fixed, we have to use the sales-channel api for guest checkout.

This issue makes a checkout process as a guest impossible via store-api endpoints. Until fixed, we have to use the sales-channel api for guest checkout.


import change from #30

@sirKitKat volunteers these changes in issue #30.

Can this be integrated into a release so it will make it into the next docker build?  I'm not getting carelink data at all I think because of this issue (it's getting the NaN error guessing the offset)

Howdy @mattster98, thanks for the input!  Which region are you located in?  Are you saying @sirkitkat's fixes worked for you, or reporting that it does not currently work at all?
I've been working on testing these changes for integration and release ASAP.

No, I'm still trying to get a docker image built so I can try it out.  I deployed the latest released build to my own kubernetes cluster and have not rolled my own before, so it's a bit of a struggle.

OK - quite the journey to here, but I got my updated docker built that points to my custom npm for minimed-connect-to-nightscout that has this change in it, aaaaand it is still failing.  It DOES now show the correctly guessed offset (I'm in US/Eastern and it says -0500).  However I still get the RangeError: Invalid time value
│ nightscout 2023-01-05T20:00:43.127Z [Arguments] {                                                                                │
│ nightscout   '0': 'EU login 3 (url: https://mdtlogin.medtronic.com/mmcl/auth/oauth/v2/authorize/login?locale=en&countrycode=US)'                                                                                │
│ nightscout }                                                                                │
│ nightscout 2023-01-05T20:00:43.406Z [Arguments] {                                                                                │
│ nightscout   '0': 'EU login 4 (url: https://mdtlogin.medtronic.com/mmcl/auth/oauth/v2/authorize/consent, sessionID: aca9d16d-ab83-486a-926d-64130fe9fa39, sessionData: eyJ0eXAiOiJKV1QiLCJjdHkiOiJKV1QiLCJhbGciOiJkaXIiLCJlbmMiOiJBMTI4Q0JD │
│ nightscout }                                                                                │
│ nightscout 2023-01-05T20:00:43.616Z [Arguments] {                                                                                │
│ nightscout   '0': 'EU login 5 (url: https://carelink.minimed.com/patient/sso/auth?code=ac0e9bd6-cc51-4987-865d-ba391da70e23&state=auth)'                                                                                │
│ nightscout }                                                                                │
│ nightscout 2023-01-05T20:00:44.397Z [Arguments] {                                                                                │
│ nightscout   '0': 'GET data (as carepartner) https://clcloud.minimed.com/connect/v2/display/message'                                                                                │
│ nightscout }                                                                                │
│ nightscout 2023-01-05T20:00:44.852Z [Arguments] {                                                                                │
│ nightscout   '0': 'Guessed pump timezone -0500 (pump time: "2023-01-05T14:56:00.706-00:00"; server time: Thu Jan 05 2023 15:00:44 GMT-0500 (Eastern Standard Time))'                                                                        │
│ nightscout }                                                                                │
│ nightscout (node:1) UnhandledPromiseRejectionWarning: RangeError: Invalid time value                                                                                │
│ nightscout     at Date.toISOString (<anonymous>)                                                                                │
│ nightscout     at timestampAsString (/opt/app/node_modules/minimed-connect-to-nightscout-mattster98/transform.js:50:30)                                                                                │
│ nightscout     at deviceStatusEntry (/opt/app/node_modules/minimed-connect-to-nightscout-mattster98/transform.js:123:18)                                                                                │
│ nightscout     at Object.module.exports [as transform] (/opt/app/node_modules/minimed-connect-to-nightscout-mattster98/transform.js:187:20)                                                                                │
│ nightscout     at handleCarelinkData (/opt/app/lib/plugins/mmconnect.js:61:33)                                                                                │
│ nightscout     at Object.fetch (/opt/app/node_modules/minimed-connect-to-nightscout-mattster98/carelink.js:325:13)                                                                                │
│ nightscout     at processTicksAndRejections (internal/process/task_queues.js:93:5)                                                                                │
│ nightscout (Use `node --trace-warnings ...` to show where the warning was created)                                                                                │
│ nightscout (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch( │
│ nightscout (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.                         │

I tried deploying a dev version so I could inspect as it was running to try and debug this, but that's beyond what's left of my capabilities today.. I'll keep trying tomorrow.
I have the following env variables.. that may mean I'm not getting all of the fix based on my interpretation of the code.
MMCONNECT_SERVER:          US
MMCONNECT_COUNTRYCODE:     US

OK - I managed to get a local server running on windows so I could more easily debug via probably the hackiest way possible (more logging to console) but the only way I could seem to get the runtime values that were triggering the error.
My sMedicalDeviceTime is 2023-01-06T12:56:01.582-00:00
That seems to be the problem since the non-EU fix in parsePumpTime looks to concatenate a timezone offset before date.parse instead of offsetting the resulting unix timestamp.  I already have the offset, so it's generating an invalid input to date.parse.
It might make more sense to just try the first method, and if that fails, try the second.  By forcing the EU method on my server, I begin to successfully download from carelink.


Actualize doc, fixes for config, added FriendlyException

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
#13

👍


New RLP CRD version

Group
Version
Kind

kuadrant.io
v2beta1
RateLimitPolicy

Example with all fields:
apiVersion: kuadrant.io/v2beta1
kind: RateLimitPolicy
metadata: {}
spec:
  targetRef:
    group: gateway.networking.k8s.io
    kind: HTTPRoute
    name: <HTTPROUTE-NAME>
  limits:
    <limit-name>:
      routeSelectors:
      - matches:
        - hostnames:
          - "*example.com"
          path:                      # HTTPPathMatch
            type: PathPrefix
            value: "/toys"
          method: GET          # HTTPMethod
          headers:                # []HTTPHeaderMatch
          - type: Exact
            name: "X-Canary"
            value: "1"
          queryParams:      # []HTTPQueryParamMatch
          - type: Exact
            name: "q"
            value: "1"
      rates:
      - limit: 50
        duration: 1
        unit: minute
      counters:
      - auth.identity.username
      - context.request.http.path
      when:
      - selector: auth.identity.group
        operator: neq
        value: admin

In RFC 0001, we exemplified hostnames at the same level as matches. I think the idea was that matches could be typed as or identical to GWAPI's []HTTPRouteMatch.
I have nothing against bringing hostnames as new field of brought inside of matches, side-by-side with the other fields inherited from GWAPI. However, in that case, we probably don't need the matches level at all. routeSelectors could of type []Selector, where:
type Selector struct {
  Hostnames:   []Hostname            `json:"hostnames,omitempty"`
  Path:        []HTTPPathMatch       `json:"paths,omitempty"`
  Method:      HTTPMethod            `json:"method,omitempty"`
  Headers:     []HTTPHeaderMatch     `json:"headers,omitempty"`
  QueryParams: []HTTPQueryParamMatch `json:"queryParams,omitempty"`
}

Any advantage on keeping matches []HTTPRouteMatch or let's go with the custom Selector type above?

. However, in that case, we probably don't need th

That sounds good, because I also believe that routeSelectors should be the type of []HTTPRouteMatch

I also believe that routeSelectors should be the type of []HTTPRouteMatch

But it wouldn't, right? The two options pitched are:

Using HTTPRouteMatch (like in the RFC):

type RouteSelector struct {
  Hostnames []Hostname
  Matches   []HTTPRouteMatch
}

Without HTTPRouteMatch:

type RouteSelector struct {
  Hostnames:   []Hostname            `json:"hostnames,omitempty"`
  Path:        []HTTPPathMatch       `json:"paths,omitempty"`
  Method:      HTTPMethod            `json:"method,omitempty"`
  Headers:     []HTTPHeaderMatch     `json:"headers,omitempty"`
  QueryParams: []HTTPQueryParamMatch `json:"queryParams,omitempty"`
}

Correct, updated previous comment

Do we want v2beta1 or v1beta2?
In RFC 0001 v2beta1 is specified. But as we are skipping v1 it seems a long hop IMO.


Events

This rewrites the events to be a little more type safe, by using custom classes for each event type. This also adds get/set properties which can make it possible to bind these events when used in React.

:wave: Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

:art: If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
:fast_forward: If this is a PR that includes changes to an interaction, please include a video recording in the description.
:warning: If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.


Bundle all legacy helpers into a separate script file

Maybe call this hwcrypto-lgacy.js, which is required mostly for older IE-s

This has been fixed in bcf6e4dfb87, but current file size is not OK

Fixed with 0.0.9 release


Add Nginx restart task

Nginx is slowing down over time for some reason. Restarts seem to fix it. Also fixes the cert issue.

done


Add Owners to GraphRbac

Fix https://github.com/Azure/azure-sdk-for-python/issues/1359

Add Applications_ListOwners
Add Application_AddOwner
Add ServicePrincipal_ListOwners

Already tested and generated in:
https://github.com/Azure/azure-sdk-for-python/pull/1599

No modification for AutorestCI/azure-sdk-for-node

 https://github.com/Azure/azure-sdk-for-python/pull/1605

 https://github.com/Azure/azure-sdk-for-ruby/pull/1109

No modification for AutorestCI/azure-sdk-for-node

No modification for AutorestCI/azure-sdk-for-ruby

No modification for AutorestCI/azure-sdk-for-python


Update 02.01-Pose-Basics.ipynb

clarify the input file is in inputs/

@jadolfbr thanks for the review!
we also noticed today that 'cd' no longer works, I think you need to do "%cd" ... can yo uconfirm? I think Google made this change. if so, i'd like to push that edit too.


Create group page

Just a page, currently linked nowhere. Could be linked in the #134 component.

Current coverage is 96.58% (diff: 100%)

Merging #136 into master will increase coverage by 0.11%

@@             master       #136   diff @@
==========================================
  Files            77         81     +4
  Lines          1104       1141    +37
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1065       1102    +37
  Misses           39         39
  Partials          0          0

Powered by Codecov. Last update 9e3af5a...f51453a


Invalid custom inputTypes are not rejected

Pass in anything that's not a React Component to addInputType, and no exceptions will be thrown.
One issue is that ! has higher precedence than instanceof. So, in addInputType, the line:
!React.Component instanceof instance.constructor
is actually negating React.Component, not the result of the instanceof test.
However, wrapping it in parentheses like !(React.Component instanceof instance.constructor) doesn't fix the overall issue, so I think there's something wrong with the instanceof test, too.

Ahh. This may have been a time thing, those validation checks have probably changed over time, and Winterfell hasn't kept up with that. I'll do some digging on this, and work out what the best validation check is.
Happy to accept PRs too! :)

I was going to submit a PR, but the handful of things I tried didn't work. I'm not too clear on how React's object hierarchy works under the hood, unfortunately. I've mostly left Javascript for Clojurescript these days, so my esoteric knowledge about Js prototype stuff is dwindling...


Clean up css

Purpose
When this project began it packed a lot of legacy CSS from FUN MOOC. We're not using most of it and due to the way it's written (basic CSS, one large file, etc.) it's not a base we can build off of.

Proposal

[x] refactor the large_banner plugin that was using styles from this legacy CSS
[x] drop all unused styles

I would prefer starting from a clean sheet...


export_to_png

I have an issue in using export_to_png.
I have an app running on android using camera widget.
I tried to use export_to_png to capture image via camera  i don't know where the image saved.
When i run the app on linux, it works well but in android i don't know where the image saved

Python: 2.7
OS: Android
Kivy: 1.10.0

Thanks

Thanks


[Operators] shield to prevent CancellationError

shield future to prevent cancellation (https://docs.python.org/3/library/asyncio-task.html#shielding-from-cancellation)

And why do we want to prevent cancellation?

And why do we want to prevent cancellation?

annotation plugin throwing cancellation errors. still want/need to test locally with the plugin though

I feel like that's from the multiprocessing and we should fix that not hide it

on second thought, yeah your right. Shielding would just make debugging harder... removed the shield, but it wouldn't hurt to keep the tests.


docs: init CHANGELOG

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
1138

Relevant Lines:
1138

💛  - Coveralls


Test changes to reduce memory footprint

The motivation is our cloudbees build showing that executors are out
of memory and paging just before the gradle test tasks exits.
Also bumped the gradle version to 2.9

test this please

test this please


Add additional str accessor methods for DataArray

This implements the following additional string accessor methods, based loosely on the versions in pandas:
One-to-one

[x] casefold(self)
[x] normalize(self, form)

One-to-many

[x] extract(self, pat[, flags, expand])
[x] extractall(self, pat[, flags])
[x] findall(self, pat[, flags])
[x] get_dummies(self[, sep])
[x] partition(self[, sep, expand])
[x] rpartition(self[, sep, expand])
[x] rsplit(self[, pat, n, expand])
[x] split(self[, pat, n, expand])

Many-to-one

[x] cat(self[, others, sep, na_rep, join])
[x] join(self, sep)

Operators

[x] +
[x] *
[x] %

Other

[x] Allow vectorized arguments.

[x] Closes #3940

[x] Tests added

[x] Passes isort . && black . && mypy . && flake8

[x] User visible changes (including notable bug fixes) are documented in whats-new.rst

[x] New functions/methods are listed in api.rst

I'd set a default for the name of new dimensions e.g. group_dim: Hashable = "group". I think that's a good choice in most cases.

I thought about doing this at first.  However, this could lead to conflicts if the DataArray already has a dimension with that name, which would be a particular problem if people chained together multiple such operations.  So I checked what default name xarray uses elsewhere, and it doesn't seem to use default names for the most part (the main exception being DataArray creation).  So I think that, in order to avoid unexpected behavior, and to keep consistency, not automatically choosing a name is a better option.

Just wanted to let you know that we are definitively interested in this contribution! I'd start by removing the dtype assertions again, that makes the diff of the tests much smaller and more digestible. Unless there is a reason for them? Does this not work correctly in assert_equal?

@mathause
Sorry for the delay, I have been swamped at work.  I probably won't have any time to work on this before Christmas.
I have finished implementing the cat and join methods, and I implemented +, *, and % operator support.
I am currently working on improving the vectorization of some of the functions.  The idea is that some arguments, like for example the regular expression pattern or the number of repetitions in rep, will be able to be given an array-like, with the dimensions being broadcast against the original DataArray.
This can be useful, for example, if a DataArray combines data of different formats along a dimension (ideally this wouldn't be the case but people don't always have that much control over the data they get).  Or it could be used to create an ASCII bar chart where the number of symbols is equal to the value in an array element.

However, this could lead to conflicts if the DataArray already has a dimension with that name, which would be a particular problem if people chained together multiple such operations.

That should raise a KeyError, no?

Yes, but I think it would be strange if using the default parameters once works fine, but using them twice or more in a row somehow returns an exception.  I think the defaults should either work generally or not be defaults at all.  That is just my opinion.  More fundamentally, it is just inconsistent with how xarray works elsewhere and so I think it would be unexpected.

Some of the tests could probably be simplified, to make them easier to read. E.g. when you try to raise an error.

Please point out the specific cases if you haven't already done so.

we usually add a match to the pytest.raises. This also helps to understand what you are testing.

I will add this.

assert_equal should raise an error if the dtype does not match, so you should not need to add all the assert result.dtype == expected.dtype.

It doesn't work with an object dtype:
>>> import numpy as np
>>> import xarray as xr
>>>
>>> a = xr.DataArray(np.array("a", dtype=np.str_))
>>> b = a.astype(np.object_)
>>> a.dtype == b.dtype
False
>>> a.equals(b)
True
>>> xr.testing.assert_equal(a, b)

This does not raise an exception on my machine at least.  I ran into several cases where I was incorrectly getting object dtypes and the tests weren't catching it, hence the dtype checks.

Sorry for the delay, I have been swamped at work. I probably won't have any time to work on this before Christmas.

No probem at all, just wanted to check in.
Yes you are correct concerning the dtype. This comes back to numpy, where the following returns true
np.array("a") == np.array("a", dtype=object)

I wonder if that's the right choice... Thus, you are right to change the tests.

@mathause One possibility might be to make xr.testing.assert_identical match dtypes.  I can see different dtypes being "equal", but not "identical".

I opened an issue regarding the dtypes check. Let's see what the others think.

@keewis Thanks for the suggestions.  I will add everything to the relevant documentation when I have everything completed and the changes are agreed upon.

api.rst contains a structured enumeration of methods autosummary should generate documentation pages for, so there's not much to do, and it would allow us to check the rendered version of the docstrings.

The latest version I just pushed should have the requested changes.  It also has cat, join, +, *, %.  I have also implemented broadcasting for many (but not all) of the functions I plan to implement it for so you can see some examples of how it works.

The version here should be complete, in that all planned features are implemented, although of course there may be additional changes.  So I removed the [WIP] part and updated whats-new.rst and others. I squashed my commits down and force-pushed to get a clean look at things. Please take a look and tell me what you think.

All tests now pass as well.

Thank you very much @toddrjen — it's a huge contribution!

I fixed a conflict and am merging.
Thanks @toddrjen ! This is a very significant contribution.

Thanks - awesome! Even going through the code took ages so kudos for sticking with it!


perf tracing: make log recording optional

Describe the feature
most tracers don't need logs that we record here (currently only CallTracer if includeLogs is enabled):
https://github.com/paradigmxyz/reth/blob/c75cacf85551f9d6ccbdfddf5530541b6da7658e/crates/revm/revm-inspectors/src/tracing/mod.rs#L328-L341
TODO

add config value for record_logs:
https://github.com/paradigmxyz/reth/blob/c75cacf85551f9d6ccbdfddf5530541b6da7658e/crates/revm/revm-inspectors/src/tracing/config.rs#L7-L10
only record logs if record_logs is true

Additional context
No response

I think this one is closed by #3286 or does it require other elements?


Can you share the preprocessed data?

Hi Team LifelongnnUnet,
With Prostate datasets, in paper, you report that:

But I downloaded the following official data, I explored that the information of the dataset you provide is different a little bit:
UCL

The shape of images is (28, 384, 384), not (24,384,384)
The spacing: (3.6, 0.5, 0.5) not (3.5, 0.5, 0.5)

I2CVB:  is right.
ISBI

The shape of images is (20, 384, 384), not (19, 384,384)
The spacing: (3.6, 0.5, 0.5) not (3.7, 0.5, 0.5)

DecathProst (The most difference)

The shape of images is (2, 20, 320, 320), not (19, 316, 316)
The spacing: (1, 3.6, 0.6, 0.6) not (1, 1, 1)

Can you tell me what have you processed the data? And can you share data with us?
Thank you so much.

Also with DecathHip (hippocampus)

The shape is (28, 49, 38) not (36, 50, 35)

That's my fault. It's a mean resolution and mean spacing.

That is mean resolution and mean spacing. IT's my fault.


thumbs issue when searching

If you search and don't interact with the page, the thumbs won't load.
It looks like we load: https://lbry2.vanwanet.com/speech/f638256dff338716:b.png and not the optimizer urls, and then the optimizer ones once you interact. I don't think we should load both.

Sean fixed this.


Fix/improve jazzy docs

This PR makes a number of fixes/improvements to the API docs generated with jazzy.

The top-level index.html page now shows the SDK version (from git describe --tags), and the correct copyright date / date of generation.
The doc for each service now shows the service-specific README, with the full SDK README included as the first section under "Guides".
Fixed the links to the quickstart and objective-c docs by moving this to the gh-pages branch.

You can see a rendered version of the new docs here.
I'll note that the docs for Conversation aren't quite right, because this was removed from the README but we still generate docs for it.  We need to decide whether to drop it from the docs or fix the README.

The version string is confusing. Can we just keep the v0.32.0 part?

One more concern I have is potential confusion for a user that navigates to the API docs for one service (Assistant, for example), clicks the README link, and sees code examples for services that are not Assistant.
I think the easiest way to avoid that confusion is to put some small disclaimer near the top of the main README to explain that the README covers all Watson services, not just the service whose API docs you're viewing. A subtle way to do this would be include a list of all services included in the SDK, so the reader has context on what the main README will cover.

@mkistler First I've looked it this, so some comments might not apply to this PR.

I was confused by the terminology. I thought I was looking at the README on the VisRec index page, so was confused when I clicked it and saw a different page. Would also expect a link back to this top-level page.
I would recommend renaming the Guides section (e.g., More information) and putting all the links under that section (the stuff under The following links... at the bottom).
The description at the top of the classes is generic to the service and doesn't provide any info about the classes. I'd leave it out.
Re: Anthony's comment, I'd rename the link text from README to something like Swift SDK

@AnthonyOliveri

I will fix the section headers.
The version comes from git describe --tags, which will look like v0.32.0 when the docs are generated from the commit with tag (which is how we should always do it).
All the service-specific code examples have moved to the READMEs within the service.  There are some specific service names in the "front matter" sections (e.g. Authentication, Custom Headers, etc), but that content applies to all services -- we just use a concrete service name to illustrate.  Is this what you are concerned with?

@AnthonyOliveri I like your idea of including a list of all the services available in the SDK.  This was there previously ... I can add that back.

All the service-specific code examples have moved to the READMEs within the service. There are some specific service names in the "front matter" sections (e.g. Authentication, Custom Headers, etc), but that content applies to all services -- we just use a concrete service name to illustrate. Is this what you are concerned with?

@mkistler I think using different services for concrete examples in those sections (like Authentication) is fine. My point is that a reader will be looking at the Assistant docs (for example), click the README link, and then get confused as to why the examples show services like discovery and toneanalyzer but not assistant. It should be clear that the README is not just for Assistant, but all of the Watson services.

I also agree with @SirSpidey's suggestion on adding a link in the left nav to get back to the index.html page.

@AnthonyOliveri @SirSpidey I think I have fixed what I am able to fix. I agree with all your suggestions for improvement but I cannot find a way to implement these with the jazzy tool that we use to generate the docs.

@mkistler There's no way to add a link to the left nav for the index.html page?

The only page we really control is the top-level index.html.  All the rest of the pages are generated by jazzy.  jazzy allows us to add "documentation" pages with the --documentation command-line argument.

Using the --documentation option, extra markdown files can be integrated into the generated docs and sidebar navigation.
Any files found matching the file pattern will be parsed and included as a document with the type 'Guide' when generated.

There is no option to specify the category name -- it is hard-coded as "Guides".  And the name shown is the name of the file -- there is no option to specify a custom name.
Likewise, I could find no option for adding a backward link to the top-level index.html.
Short of forking jazzy and adding these features, or doing some complicated post-processing of the generated pages, I don't see any way to do this.

Fair enough. I tried changing the title of the Guides section to something like All Watson Services, but had no luck.
I did make a minor improvement to the links at the top of the page. Instead of just saying Reference > Reference, they now say {Service} Reference.


New file isn't found in project

If you have an existing project and emacs lsp-mode is working fine, and then you create a new file with contents
Module: my-module

define stuff...end;

and then you save the file, the LSP server doesn't find a module for the file and shows an error in the mode line.  stderr looks like this (test.dylan is a new file):
D 2024-04-21T20:47:16.000-0400 [Main thread] Received JSON:
{
  "id": 226,
  "jsonrpc": "2.0",
  "method": "textDocument/hover",
  "params": {
    "position": {
      "character": 28,
      "line": 30
    },
    "textDocument": {
      "uri": "file:///Users/cgay/dylan/workspaces/deft/sources/commands/test.dylan"
    }
  }
}
D 2024-04-21T20:47:16.000-0400 [Main thread] textDocument/hover: No data found for {<open-document> file:///Users/cgay/dylan/workspaces/deft/sources/commands/test.dylan 7} (line: 30, column: 28)
D 2024-04-21T20:47:16.000-0400 [Main thread] Sent JSON:
{
  "id": 226,
  "jsonrpc": "2.0",
  "result": null
}

I believe this is because define handler textDocument/didOpen uses od/file-module to find the module. I think we need to fall back to looking for the Module: header and try to find the module by name.

In fact, the Module: header should be the first thing to look at, not just a fallback.


Search Functionality

Make a button to open all dropdown boxes at once, so you can ctrl-f browser search
or have an integrated search

Make a button to open all dropdown boxes at once, so you can ctrl-f browser search

I think this is reasonable.

or have an integrated search

I'm not sure how this might work with quests since they have different wording than every other list.
In the mean time, I have added this commit to change the default from all closed to all open so you may ctrl+f browser search. I will get to the button later.
May I ask what you generally are searching for when using this website?

Mainly it was searching for bosses and graces by their name.

Thanks for the feedback.
The graces are listed in the order the game presents them if that helps as well. So you can see immediately if you are missing any.

Added the open all / close all button in this commit
There is a bug currently where if you close all then open them all manually one by one it will still try to open all when clicking this new button again.
I'll be working on a fix for that but I'm going to close this request since it has been completed.

Fixed that bug in this commit


Some ideas seek the author's opinion.

I plan to submit some potentially breaking updates in my PRs, such as adding fields in ServiceInstallCtx and adding values to the TypedServiceManager enumeration. I noticed that a PR to add methods in ServiceManager has already been merged in the repository, which is already a breaking change. Would the author mind merging the PRs I described?

Sure, feel free to submit PRs and I'll review them.
I'm traveling for the next couple of weeks, so the PRs may not get merged immediately.


Refactor: parens not needed after not operator - it has low precendence

Description
Refactor: parens not needed after not operator - it has low precendence
Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.89%. Comparing base (3bc1fb5) to head (53e25b5).
Report is 58 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
+ Coverage   94.83%   94.89%   +0.06%
==========================================
  Files          60       60
  Lines        2671     2686      +15
==========================================
+ Hits         2533     2549      +16
+ Misses        138      137       -1

Files with missing lines
Coverage Δ

ols/app/models/config.py
97.65% <100.00%> (+<0.01%)
:arrow_up:

ols/app/models/models.py
100.00% <100.00%> (ø)

/retest

/lgtm

/approve

/override "ci/prow/e2e-ols-cluster-4-15"
/override "ci/prow/e2e-ols-cluster-4-16"
/override "ci/prow/images"


[Bug]: MySQL query fails for having the "IS" word inside a comment in Prepared Statement

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When there's an "is" word inside a comment in a MySQL query having the prepared statement turned on, the query fails with the following message

"Appsmith currently does not support the IS keyword with the prepared statement setting turned ON. Please re-write your SQL query without the IS keyword or turn OFF (unsafe) the 'Use prepared statement' knob from the settings tab."

Expected result
Comment is supported even in a prepared statement and here's an example of the expected result when the "is" word doesn't exist inside the comment

Steps To Reproduce

Create a MySQL datasource
Write a simple query having the "is" word inside a comment. For example,

SELECT
* --Appsmith is awesome
FROM TABLE

The query should fail with the error message

"Appsmith currently does not support the IS keyword with the prepared statement setting turned ON. Please re-write your SQL query without the IS keyword or turn OFF (unsafe) the 'Use prepared statement' knob from the settings tab."

Public Sample App
No response
Version
Cloud / Self hosted- v.17.2

RCA: the validation step is done before removing comments on the query statement.
Fix: Rearranging the steps: remove comments first then validate


Add Socket and AddressInfo resource objects

https://php.watch/versions/8.0/sockets-sockets-addressinfo

Looks like a safe change from the backward compatibility point of view so I merge it. In case, some issues arise, we will have to change Socket to Socket|resource.


[Fix] Null check rootNode before calling getScope with it

I'm getting this error while linting some valid React/TS code after upgrading to the latest version (7.34.2):

Stack trace
Oops! Something went wrong! :(

  ESLint: 8.57.0

  TypeError: Missing required argument: node.
  Occurred while linting ./OptionsTable.tsx:599
  Rule: "react/display-name"
      at SourceCode.getScope (./node_modules/eslint/lib/source-code/source-code.js:773:19)
      at getScope (./node_modules/eslint-plugin-react/lib/util/eslint.js:19:23)
      at resolveValueForIdentifierNode (./node_modules/eslint-plugin-react/lib/util/propTypes.js:378:21)
      at buildReactDeclarationTypes (./node_modules/eslint-plugin-react/lib/util/propTypes.js:420:5)
      at ./node_modules/eslint-plugin-react/lib/util/propTypes.js:788:39
      at iterateProperties (./node_modules/eslint-plugin-react/lib/util/propTypes.js:71:7)
      at ./node_modules/eslint-plugin-react/lib/util/propTypes.js:773:23
      at Array.forEach (<anonymous>)
      at DeclarePropTypesForTSTypeAnnotation.convertReturnTypeToPropTypes (./node_modules/eslint-plugin-react/lib/util/propTypes.js:762:34)
      at DeclarePropTypesForTSTypeAnnotation.searchDeclarationByName (./node_modules/eslint-plugin-react/lib/util/propTypes.js:667:14)

I don't really understand enough about the codebase to say whether this is the correct fix, or if this really should be passing in node instead of rootNode to getScope or something like that. This resolves the immediate issue for me at least and seemed reasonable to check the value is valid before it tries to call something that requires it.

Thanks - we'd need a regression test in order to land this tho.

@ljharb I've attempted to add some regression tests by trying to find a minimal reproduction. I think the issue relates to using ReturnType<typeof object> for the type parameter for a component, but I don't really know the details.
I get the expected failure without the nullcheck:

I see that code coverage is failing on some indirect changes related to code beneath a node.type === 'TSParenthesizedType' conditional. Not sure why that would happen, but is this code actually necessary since TSParenthesizedType seems to no longer be generated as a node type?

@crnhrv that PR seems to be in v5 of the parser, but we still support down to v2

Cool, thanks for the help. Will leave it with you then


Avoid conflicts with other OIDC flows

When developing a front-end application that requires two or more IDPs (one being done even with another library), the library seems to conflict because it tries to manage code and state parameters that should be handled by another flow.
From what I've seen, this library handles OIDC's parameters also when they are sent to another route in the context provider, correct?
Is there a way to specify a specific callback url so that it only handles the flow when parameters are sent there?
If not, is there a workaround for this or a way to implement it?

Check https://github.com/authts/react-oidc-context/blob/8f5d9b47c12831d257eda29c14cab7f1d0134e31/src/AuthProvider.tsx#L55


Mutiple selection and edit of points for CSGPolygon, path and related nodes

Godot version:

3.1 alpha
OS/device including version:

Issue description:

I am working on the CSG tutorial and I realize some problem when playing with the tools. I draw a polygon far away from the origin of the CSGPolygon nodes. My initial thought is to move the whole polygon towards the origin, unfortunately, I cannot do so. The only thing I can do is to redraw the CSG polygon near the origin, it is not a complicated shape to redraw but it is not a good experience.
It would be better if I can select all the points or some points and move it around. Being able to scale the selection(only changing the location not actual scale) is also nice feature. I think this feature is beneficial to Path, Path2D, Polygon2D and other nodes that can edit points.
Steps to reproduce:
Minimal reproduction project:

What I also miss of CSGPolygon is a snap to grid point edition.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!


onPremisesUserPrincipalName blocks conversion - no info given on the article

The article states that the conversion of internal users to B2B users works also in the hybrid scenario. But in many organisations, the onPremisesUserPrincipalName is filled in Azure AD due to the sync. The conversion gets blocked because of it. It would be great if the article would mention a note about why this is the case and how to work around it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81002e29-e756-60db-55b3-fe645fa59240
Version Independent ID: 3be93733-6f54-b684-ad0a-91ba3a90388a
Content: Invite internal users to B2B collaboration - Azure AD
Content Source: articles/active-directory/b2b/invite-internal-users.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@Staubi999 Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we’ve created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close

Can you please give details of how to avoid the sync of onPremisesUserPrincipalName? We've been trying to do it with Sync rules but with no success


Enable ldap for cerebro

Allow LDAP configuration for cerebro (https://github.com/lmenezes/cerebro/blob/master/conf/application.conf#L20)

@Infra-Red we can take a look at this and submit a PR


implement draft recurring donations service for make sure not miss any donation

Related to https://github.com/Giveth/giveth-dapps-v2/issues/3974

We should make sure we are checking not only when a recurring donation is created but also when it is updated.

@mohammadranjbarz, please note that when updating, we must be able to create draft recurring donations even without having the 'recurringDonationId'. Thanks

@MohammadPCh  Your desired changes has been deployed on staging

I've got Unauthorized error @MohammadPCh @mohammadranjbarz

https://github.com/Giveth/impact-graph/assets/111529185/ecbd5dc4-a2c2-4b31-9ad1-ce32cba9374a

@maryjaf Is it happening every time? because we check the user authentication before donating.

I've got Unauthorized error @MohammadPCh @mohammadranjbarz

curl 'https://impact-graph.serve.giveth.io/graphql'
-H 'accept: /'
-H 'accept-language: en'
-H 'authorization;'
-H 'authversion: 2'
-H 'content-type: application/json'
-H 'origin: https://staging.giveth.io'
-H 'referer: https://staging.giveth.io/'
-H 'sec-ch-ua: "Google Chrome";v="123", "Not:A-Brand";v="8", "Chromium";v="123"'
-H 'sec-ch-ua-mobile: ?0'
-H 'sec-ch-ua-platform: "macOS"'
-H 'sec-fetch-dest: empty'
-H 'sec-fetch-mode: cors'
-H 'sec-fetch-site: same-site'
-H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36'
-H 'wallet-address: 0xa1179f64638adb613ddaac32d918eb6beb824104'
--data-raw $'{"operationName":"createDraftRecurringDonation","variables":{"projectId":223623,"networkId":11155420,"flowRate":"36170000106169","currency":"GIV","anonymous":false,"isBatch":true,"isForUpdate":false},"query":"mutation createDraftRecurringDonation($networkId: Float\u0021, $currency: String\u0021, $projectId: Float\u0021, $recurringDonationId: Float, $anonymous: Boolean, $isBatch: Boolean, $isForUpdate: Boolean, $flowRate: String\u0021) {\n  createDraftRecurringDonation(\n    networkId: $networkId\n    currency: $currency\n    recurringDonationId: $recurringDonationId\n    projectId: $projectId\n    anonymous: $anonymous\n    isBatch: $isBatch\n    isForUpdate: $isForUpdate\n    flowRate: $flowRate\n  )\n}"}'

[ ] 2-
Draft donation isn't worked because because there is no change in previous flow and the donation isn't shown in the list like as before @mohammadranjbarz @MohammadPCh
to reproduce:
-Tap on donate in project page and then select recurring donation tab
-Set amount
-Tap on donate button in donation page
-Before confirming the metamak transaction, close the dapp window
-Confirm metamask transaction
-See this donation isn't shown in project and user page

I've tested draft donations scenario and it works now
Thanks @CarlosQ96 @mohammadranjbarz

Draft donation problem has been fixed


Now x86 doesn't compile in new version

Platform (please complete the following information):

OS: Windows
Sdk vervion: latest
Xamarin.Forms: latest

Describe the bug
Now after you have added the x64 uwp dll in the new version - getting errors when compiling x86. It's a closed circuit :D Maybe try to reach out nuget support, maybe they know how to include both x64 and x86 dlls?
Exceptions (if applicable)
Copy paste the exception and the stack trace
error MSB3270: There was a mismatch between the processor architecture of the project being build "x86" and the processor architecture of the reference "C:\Users\pluki_000\.nuget\packages\sharpnado.shadows\1.1.0\lib\uap10.0.16299\Sharpnado.Shadows.dll", "AMD64" (and the same for Sharpnado.Shadows.UWP.dll)

duplicate of #9


fix: revert helmut's library clean up

Reverts splunk/pytest-splunk-addon#523

I'll fix semgrep and misspell in the next PR.


DSCP-215 Haddock for avl plus

Started making haddock and fixing stuff that is unnesessary.

[x] Removed Serialisable class and HashMapStore (the latter was reason to serialisation);

[x] Tree is a cache itself, and serialising on each operation just heats more air;
[x] Test that everything works.

[x] Rename NullStore (= IO, monad that fails to retrieve) and make it into separate module;
[x] Actually haddock all modules that will be alive at the end.
[x] Its now possible to overwrite storage, which removes nodes that aren't needed anymore.

@flyingleafe

original paper

There is a problem. I think I had a paper, but idеas from it were mostly provided by @vlad107 and from @manpages / @vlad107 Merkle-tree impl. Some things that are there were taken from cardano(?) tree made in scala. Rebalance was taken from some description on C-impl of AVL-tree and debugged into providing non-skewed trees later after each major refactor. Proofs-as-subtrees was invented by me so I don't had to write insert/delete on proofs-as-hash chains. Revisions were invented here to not depend on hashes for equality internally (and to not rehash, recently).
Contour is internal thing. I can provide full docs to all internal things, including contour, Zipper, rebalance, etc.
I'll do docs for all internal mechanisms, then.

@flyingleafe review/merge


[language] remove diem-types dependency from bytecode-verifier-tests and invalid-mutations

This removes the dependency on diem-types from bytecode-verifier-tests and invalid-mutations.

@mengxu-fb we could do that. Although I think it's also possible that we'll take another holistic look into the error handling story for Diem and Move later, and depending on what we conclude, we may want to make a bigger change in that space.

/land


[bug] "disable keybinds messages" also hide emotes

Sounds weird, but whenever that's enabled, can't see emote action text in chat anymore.

clip of a screenshot taken with the checkbox unchecked and the emote showing.

same /dance but with it enabled. no emote text. yeah re-did the animation :).

Fixed in Release 1.18.rc7


Out of tree builds not working

I usually like to run configure and make from a subfolder, e.g.
mkdir build && cd build && ../configure && make
to keep the source and the build products separate (aka VPATH build).
I'm trying this in cygwin 64 bit at the moment, and it isn't working correctly. On Ubuntu 14.04 I see similar behavior.
gist of output from running ../configure https://gist.github.com/1fd5a01c747c95e564e1d258cc237440
gist of config.log and Makefile from build after running ../configure https://gist.github.com/9bb454cad03df4759b1d627851b07661
My autotools is a little rusty so nothing jumps out at me to fix this. Any ideas?

Fixed on v1.8.6. Thanks!


feat: add third party scanners page

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Add support for Redis Cluster

Redis cluster is a much better solution for HA then sentinel, I tried to pass a cluster enabled redis client to kue.js but it didnt work. I used ioredis as the redis client, its interfaces are very similar to node-redis but with some subtle difference, e.g. message subscription and lua script loading and invocation.
Glad to see redis cluster support in kue.js.
Thanks

Glad too see a PR supporting ioredis according to https://github.com/luin/ioredis/wiki/Migrating-from-node_redis

+1

We should also add support for ioredis. I should check @az7arul's PR.

+1

+1

+1

Although node_redis and ioredis will merge, there seems to be no set timeline regarding this!

Done through #652


Ginkgo: Kafka test issues

I've seen the following error in the last days of testing.
    "status": [
      {
        "code": "Failure",
        "message": "Error regenerating endpoint: Unable to allocate ingress redirects: address already in use",
        "state": "ready",
        "timestamp": "2018-02-04T18:51:16Z"
      }
    ]

Cilium.log
Feb 04 18:51:16 runtime cilium-agent[26466]: level=debug msg="Setting packet marker of socket" fd=39 marker=4277797251
Feb 04 18:51:16 runtime cilium-agent[26466]: level=error msg="Unable to create kafka proxy" error="address already in use" id="47048:ingress:TCP:9092"
Feb 04 18:51:16 runtime cilium-agent[26466]: level=warning msg="Regeneration of endpoint program failed" containerID=95a7c04b49f50ae5016f5bf6a8c2e2b8897bfa23f9f3e4ff3f975914a3c575ca endpointID=47048 error="Unable to allocate ingress redirects: address already in use" policyRevision=88

https://github.com/cilium/cilium/blob/a1b540462ff16be31a7d2e22364174c6abe57d07/pkg/proxy/proxy.go#L365-L375
https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/1252/
Attached ginkgo logs.
RuntimeKafkaKafkaPolicyIngress.zip

I don't know much about the proxy stuff, but if we're seeing this only in CI I wonder if we accidentally bypass/don't wait for the kafka proxy releasing it's ports and then use the same one. In particular, 9092 is a default port for kafka, I think.

hi!
finally i can reproduce the issue and i tried to fixed but i think that it's envoy internal.
workflow to reproduce:
docker run -dt --net=cilium-net --name zook -l id.zook digitalwonderland/zookeeper
docker policy import l7.json

l7.json
[{
    "labels": [{"key": "name", "value": "l7-rule"}],
    "endpointselector": {"matchlabels":{"id":"app1"}},
    "ingress": [{
        "fromendpoints": [
            {"matchlabels":{"id":"app2"}}
        ],
        "toports": [{
            "ports": [{"port": "80", "protocol": "tcp"}],
            "rules": {
                "http": [{
                    "method": "get",
                    "path": "/public"
                }]
            }
        }]
    }]
}]

when you apply the policy a new port is allocated, and you can see in the ss -putan output
root@runtime:/home/vagrant# ss -putan | grep 10000
tcp    listen     0      128       *:10000                 *:*                   users:(("cilium-envoy",pid=28927,fd=24))
root@runtime:/home/vagrant#

when you delete the policy cilium policy delete --all the
proxy.allocatedports are empty, and the signal to envoy is sent[0] i can see the call in the envoyproxy[1][2]
[0] https://github.com/cilium/cilium/blob/master/pkg/envoy/envoy.go#l312
[1] https://github.com/cilium/cilium/blob/master/pkg/envoy/grpc.go#l203
[2] https://github.com/cilium/cilium/blob/master/pkg/envoy/streamctrl.go#l236
but if i made an ss the port still listen.
so, i think that we do all correct in envoy, but the problem is in the following function:
https://github.com/envoyproxy/envoy/blob/master/source/server/lds_api.cc#l43
in the envoy log i saw that message, but the proxy keep listening:
2018-02-07 20:16:52.141][28927][info][upstream] external/envoy/source/server/lds_api.cc:58] lds: remove listener '56326:ingress:tcp:80'

The main problem is that cilium will try to allocate another proxy in port
10000, and when it try, it'll fail. this is causing all the test failures in
right now in master.
Not sure what is the best way to fix this, any idea @jrajahalme @tgraf

I'll let @jrajahalme comment first on Envoy behaviour. We can definitely avoid reusing ports for longer to avoid this problem but we need to understand the behaviour of Envoy. Part of the problem might be that Envoy is not using SO_REUSEPORT?

@eloycoto It would be helpful to see the Errors in envoy log for the failed re-use of the port 10000.
Anyway, Envoy does not immediately destroy the listener (and close the socket), see this comment in Envoy sources:
      // Once the drain time has completed via the drain manager's timer, we tell the workers to
      // remove the listener.

But on the other hand it should be able to pass sockets from draining listeners to new ones when they use the same address and port. I think this should also work accross restarts, if re are not using the same Envoy instance in all the tests.
@tgraf is right in that Envoy does not set SO_REUSEPORT, but IMO it would not be safe to allow other programs to listen on the same port.

Hi,
I'll post tomorrow, the main issue is when a Kafka proxy starts on that port, not envoy
Regards

I've submitted https://github.com/cilium/cilium/pull/2747 to implement:

Delay port released
Random port number allocation

Hi @jrajahalme
The logs from envoy:
vagrant@runtime:~$ cat /var/run/cilium/cilium-envoy.log
[2018-02-08 17:52:34.671][7510][info][main] external/envoy/source/server/server.cc:157] initializing epoch 0 (hot restart version=9.200.16384.127)
[2018-02-08 17:52:34.729][7510][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:131] cm init: all clusters initialized
[2018-02-08 17:52:34.729][7510][info][config] external/envoy/source/server/configuration_impl.cc:54] loading 0 listener(s)
[2018-02-08 17:52:34.730][7510][info][config] external/envoy/source/server/configuration_impl.cc:92] loading tracing configuration
[2018-02-08 17:52:34.730][7510][info][config] external/envoy/source/server/configuration_impl.cc:118] loading stats sink configuration
[2018-02-08 17:52:34.731][7510][info][main] external/envoy/source/server/server.cc:330] all clusters initialized. initializing init manager
[2018-02-08 17:52:34.733][7510][info][main] external/envoy/source/server/server.cc:346] starting main dispatch loop
[2018-02-08 17:52:34.748][7510][info][upstream] external/envoy/source/server/lds_api.cc:50] lds: add/update listener '56326:ingress:TCP:80'
[2018-02-08 17:52:34.750][7510][info][config] external/envoy/source/server/listener_manager_impl.cc:538] all dependencies initialized. starting workers
[2018-02-08 17:53:51.201][7510][info][upstream] external/envoy/source/server/lds_api.cc:58] lds: remove listener '56326:ingress:TCP:80'

The policy was deleted at 17:53 and after a few min the port is still listening:
root@runtime:/home/vagrant# date
Thu Feb  8 18:03:01 UTC 2018
root@runtime:/home/vagrant# ss -putan | grep envoy
tcp    LISTEN     0      128    <IP_ADDRESS>:9901               <IP_ADDRESS>:*                   users:(("cilium-envoy",pid=7510,fd=9))
tcp    LISTEN     0      128       *:18365                 *:*                   users:(("cilium-envoy",pid=7510,fd=24))
root@runtime:/home/vagrant#

@eloycoto can we close this since #2796 was resolved?

Hi @ianvernon
I've just checked now, and the envoy proxy is still not closing the ports after a while(12 min in this case)

Close this one.


Version 1.6 apk don't start

After update to v1.6 I can't use nostrid
Google pixel 6a
Android 13

Try clearing the app data, or uninstalling and installing it again.

I did all that, still can't use it

Does v1.5 work in your device?

I never installed it, before 1.6 I had installed 1.3, Let me try 1.5

What about v1.4?

v1.4 don't work neither, I just installed 1.3 again and it works

Ok I'll see if I can reproduce the error in a simulator

I didn't find an image for Pixel 6a, but I tried it in Pixel 5 Android 13 and Nexus 6P Android 13 and they both work fine.
Can you try these builds? They are intermediate points between 1.3 and 1.4, let's see if we can pin point the exact commit that causes the error. Let me know which one works (if any).
https://github.com/lapulpeta/Nostrid-media/raw/main/com.nostrid.nostrid-034a83a1.apk
https://github.com/lapulpeta/Nostrid-media/raw/main/com.nostrid.nostrid-2a036ea8.apk
https://github.com/lapulpeta/Nostrid-media/raw/main/com.nostrid.nostrid-dca6807c.apk

Make sure you try all the builds (they are not in order)

I installed all of them, I got the same result

The issue continues with v1.7, maybe you can add some way of export some related output on the crash

Can you try this one?
https://github.com/lapulpeta/Nostrid-media/raw/main/com.nostrid.nostrid-9fde558.apk

that one works

Can you try this one?
https://github.com/lapulpeta/Nostrid-media/raw/main/com.nostrid.nostrid-9fde558.apk

Ok, I know which commit is causing it to fail, but I don't know why. I assume v1.8 is not working for you? Also can you try v1.2?

v1.8 don't work, v1.2 works, all versions until v1.3 works

We changed the database engine in v1.11. Can you please give it a try?

It works! thank you for this wonderful work


Documentation: Rephrase brew services start|stop usage

Fixes #118.

Thanks for your contribution to Homebrew!  You rock!

@MikeMcQuaid Best. Contribution Message. Ever.
Thanks! 👍

You earned it!


Add documentation

This PR adds some basic end-user documentation. It mentions features from #8, which should be merged first.

Feel free once issue is opened for https://github.com/DangerOnTheRanger/celvet/pull/9#discussion_r956493337 and the documentation is updated to directly explain what limitErrors (and all the other categories) contain and how to fix them (use a table maybe?)


[stable/unifi] #10789 breaks LoadBalancer services

Is this a request for help?:
This is a bug introduced with #10789.
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Version of Helm and Kubernetes:
$ helm version
Client: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.3", GitCommit:"eecf22f77df5f65c823aacd2dbd30ae6c65f186e", GitTreeState:"clean"}
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:54:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.5", GitCommit:"51dd616cdd25d6ee22c83a858773b607328a18ec", GitTreeState:"clean", BuildDate:"2019-01-16T18:14:49Z", GoVersion:"go1.10.7", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
stable/unifi 0.3.0
What happened:
#10789 was merged, combining the STUN and discovery services into one, which combines TCP and UDP ports in one service now. This makes it impossible to use with LoadBalancer services, which is how I was exposing the UniFi service to my network (with MetalLB and its options to combine multiple LoadBalancer services into one external IP address).
What you expected to happen:
I did not expect breaking changes in a chart with only a minor revision bump for a start.
How to reproduce it (as minimally and precisely as possible):
I use the following values in a values.yaml file (among others) with MetalLB to expose the service:
    controllerService: &lb-service
      type: LoadBalancer
      annotations:
        metallb.universe.tf/allow-shared-ip: k8s-ext57
      loadBalancerIP: <IP_ADDRESS>  # example IP

    stunService: *lb-service

    discoveryService: *lb-service

Anything else we need to know:
It should be fine to combine the STUN and discovery services, just not also the controller service. I don't really see the utility of having a single cluster IP as you can't connect access points and switches to a cluster-internal-only IP address unless you're doing something unusual...

@bootc thanks for finding this.  You're absolutely correct that this breaks LoadBalancer configurations and I didn't realize this when reviewing the change.  I'll submit a PR momentarily to revert this.
p.s. how did you notice the new chart so fast?  You filed this minutes after the change was merged.  Is there some automation that upgrades charts for you?

#11278 created for this.  @bootc do you mind taking a look and leaving a /lgtm if this looks ok to you, in order to move the PR forward?

Just chance, sorry! I happened to be reviewing some of my deployments and upgrading UniFi to 5.10.12 and I noticed an update, so I had a look at the diff and alarm bells rang...

Hi @bootc sorry for the inconvenience. Your example shows the same configuration (load balancer type) for all three services. This should be equivalent to the single service with a loadbalancer type. Can the metallb loadbalancer service not handle multiple ports/mixing TCP UDP?  I see that metallb had a special feature that combines the loadbalancer services into a single ip. Other loadbalancer type implementations don't necessarily have this, giving you different IPs which was causing my incompatibility. Unifi doesn't expect it's ports to be exposed on different ips.
Can you explain what exactly does not work? I admit this should be a major version if emerged back in though.
I

Hi @wernerb, the error we get from kubernetes is cannot create an external load balancer with mix protocols
Based on this it looks like a known thing.
However, @bootc there may be a workaround but I haven't tried this yet.
(I, too, use metalLB as the LoadBalancer in my setup)

Ok this clears up a few things. It looks like @bootc is already using that workaround though, but metallb /or any other loadbalancer implementation can't mix protocols so need separate services.
It would be great to have guidance from helm/charts on how to handle this. Its a trade-off between allowing clusterip to work or load balancer type. I think we could assume most usecases using this chart would use the metallb implementation and not that many people deploying the unifi controller on AWS or GKE. In the thread mentioned GKE load balancing wouldn't even work.
We can still simplify by combining the stun/discovery service though and will create a patch for that.
Again, unifi expects all ports to be on the same up which was the reason to simplify/make it work in the first case (I don't use load balancer type and instead just add a route to the clusterip network in my home router)
Documenting the metallb workaround as the default setup would be best as well. We can add this as text to the helm chart installation. What do you think @bootc @billimek

If combining the service is useful for some people then why not have an option for that? I don't have any issue with having one service as an option if it's useful, just not keen on breaking existing setups.
I don't think there's any way to load balance UDP at AWS at all. I can't speak for GKE, AKS or other implementations. Either way Kubernetes doesn't support LoadBalancer services with both UDP and TCP ports at all, hence the hack with MetalLB to allow this to work.
It might be helpful to show a usage example with MetalLB but there's probably not much we can do beyond that than point people at the relevant documentation.

For what it's worth, I'd have value in combining the services and someone else beat me to the punch with a PR :)
I expose my ClusterIP network as routable, so that's what APs connect to.  They get mad that they can't connect to the STUN service (as far as I can tell there's no way to tell them to look for that on a different IP).  The only way it really impacts me is with a little warning icon on each AP, so priority hasn't been particularly high.
I'm not sure whether they're looking for STUN with the discovery IP or the controller IP, but my guess would be the discovery IP.

As an aside, are any of you interested in becoming maintainers for the unifi chart?  I'd love to see more than just one person on the chart.  It's a 'simple' PR to add some folks to the OWNERS file.

My available time for OSS is pretty spotty, but I don't mind being included on the list

Also, I made a PR to do the unified service but as an option rather than a requirement :) #11550

#11550 is now merged!


Make validation messages into TemplateFields

Some of our declaration questions want to be able to reference other questions, so that we can say things like
if you answered question 32, you have to answer this one.
The syntax they use for this is a bit peculiar. It looks like
if you answered question [[questionId]], you have to answer this one.
I'm trying to get rid of this, in favour of something like
if you answered question {{ content.get_question('questionId').number }}, you have to answer this one.
Since v2 of the Content Loader, we can use jinja to render TemplateFields.  The fields we allow to be templated are whitelisted -- for example, question and hint accept jinja templating, but type and id don't.
Some of the values we want to replace in the declaration questions are in validation messages (ie, mitigatingFactors2.yml) but validation messages aren't whitelisted as TemplateFields.
This pull request makes the message value of validation items into TemplateFields.

Note
If this pull request goes in, there's a couple of other things to follow up with:

updating the README in the frameworks repo with all TemplateFields (ie, like this)
removing the question_references stuff entirely in the supplier app (ie, more or less like this)

[[questionId]] feels more friendly to content writers, if we're still working on the assumption and desire for the frameworks repo to be accessible to non-developers. The suggested replacement, {{ content.get_question('questionId').number }}, is now really mingling code and content, moving us farther away from any goal to have this be maintained primarily by designers. If we're accepting that, fine, but if we still have it in the back of our heads that this should be accessible to non-developers, it would be nice to keep anything 'magical' (content-wise) as simple as possible. Double square brackets, while magical, are at least fairly simple to understand.

Yeah, point taken. It is harder to use.
I guess it depends what our priorities are.  Right now, we have two ways of swapping out values: one that uses double square brackets and one that doesn’t. This removes one way of doing value substitution so that we’re consistently using the “new” Jinja-rendering way: it’s more flexible for us, and it makes our codebase more consistent, but it’s also much less readable for non-coders.
I think what I would argue is that most of these declaration questions are copy+pasted anyway for new frameworks, so if the square brackets notation isn't being used very often when writing new questions, then we don't have much of a practical issue.  (for example, appropriateTradeRegistersNumber is the same across DOS and DOS2, and mitigatingFactors2 has been updated from G8 to G9, but only to make the content work better with markdown.)
I would be happy to rewrite the G9 and DOS2 questions to this format to facilitate copy+pasting sometime down the road if that's a compromise.
To sum up: it is harder to use the new format but I don't think it's a big problem in practice. However, if we do think that it is, then fair enough and I'll look for another solution to this.

@samuelhwilliams, you've been outvoted.


Cannot add a new device anymore

Hi,
I am using your service since years. Recently I wanted to integrate a new device. But the web page does not react when I try to "Add devices". It does also not react when clicking the "Edit" button on an existing device. I could delete a device though - at least it comes up with a popup box asking whether I really want to remove the selected device.
Am I doing something wrong here?
Regards, Stephan

It's all working fine for me.
You'll have to share the logs from the browser so I can see what if any errors are being generated.
It would probably help to also know what browser you are using

seems like this is my problem - tested with chrome, firefox, brave and even with my mobile. seems to be related to my location then... strange

So sorry - my own fault - my local network is blocking the jquery stuff... as soon as I switched to my mobile provider it started working again....


feat: add "optional" flag for props

Adds the flag "optional" to props that combines default and strip_option

so the optional  modifiers have not been merged?
now just can use default

so the optional modifiers have not been merged?
now just can use default

Yes - "optional" is just "default" + "strip_option" which you can do today. This updates the code so the docs match up

I think we need declare the version you can use in document, because in document have many feature is not complete. we need tell them is unfinished.


Loading error

I get an error, before that I uploaded this video and everything was fine and now this error
python -m youbit download https://youtu.be/0V-R12BKWiI Traceback (most recent call last):   File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main     return _run_code(code, main_globals, None,   File "/usr/lib/python3.10/runpy.py", line 86, in _run_code     exec(code, run_globals)   File "/home/qlxi/.local/lib/python3.10/site-packages/youbit/__main__.py", line 212, in <module>     main()   File "/home/qlxi/.local/lib/python3.10/site-packages/youbit/__main__.py", line 208, in main     app()   File "/home/qlxi/.local/lib/python3.10/site-packages/typer/main.py", line 214, in __call__     return get_command(self)(*args, **kwargs)   File "/home/qlxi/.local/lib/python3.10/site-packages/click/core.py", line 1130, in __call__     return self.main(*args, **kwargs)   File "/home/qlxi/.local/lib/python3.10/site-packages/click/core.py", line 1055, in main     rv = self.invoke(ctx)   File "/home/qlxi/.local/lib/python3.10/site-packages/click/core.py", line 1657, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "/home/qlxi/.local/lib/python3.10/site-packages/click/core.py", line 1404, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "/home/qlxi/.local/lib/python3.10/site-packages/click/core.py", line 760, in invoke     return __callback(*args, **kwargs)   File "/home/qlxi/.local/lib/python3.10/site-packages/typer/main.py", line 532, in wrapper     return callback(**use_params)  # type: ignore   File "/home/qlxi/.local/lib/python3.10/site-packages/youbit/__main__.py", line 174, in decode_url     output_path = download_and_decode(url, output_dir)   File "/home/qlxi/.local/lib/python3.10/site-packages/youbit/decode.py", line 23, in download_and_decode     downloader.download(download_path)   File "/home/qlxi/.local/lib/python3.10/site-packages/youbit/download.py", line 49, in download     ydl.download([self.url])   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 3318, in download     self.__download_wrapper(self.extract_info)(   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 3293, in wrapper     res = func(*args, **kwargs)   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1466, in extract_info     return self.__extract_info(url, self.get_info_extractor(key), download, extra_info, process)   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1477, in wrapper     return func(self, *args, **kwargs)   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1574, in __extract_info     return self.process_ie_result(ie_result, download, extra_info)   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1632, in process_ie_result     ie_result = self.process_video_result(ie_result, download=download)   File "/home/qlxi/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 2682, in process_video_result     formats_to_download = list(format_selector({   File "/home/qlxi/.local/lib/python3.10/site-packages/youbit/download.py", line 62, in _format_selector     resolution: tuple = self.youbit_metadata.settings.resolution.value AttributeError: 'dict' object has no attribute 'settings'

I'm suspecting you upgraded to YouBit 2.0.0, but the video you're trying to decode was made with YouBit < 2.x. They are not compatible. Either decode with an earlier version of YouBit, or update the video's description to the following:
gASVWwEAAAAAAACMD3lvdWJpdC5tZXRhZGF0YZSMCE1ldGFkYXRhlJOUKYGUfZQojAhmaWxlbmFtZZSMCHByaXYuemlwlIwIbWQ1X2hhc2iUjCBmMTI2MWRhZWNlOWM3MjdjNWUwZDY5NmRiODkxM2NkNZSMCV9zZXR0aW5nc5SMD3lvdWJpdC5zZXR0aW5nc5SMCFNldHRpbmdzlJOUKYGUfZQojAtfcmVzb2x1dGlvbpRoCowKUmVzb2x1dGlvbpSTlE2AB004BIaUhZRSlIwPX2JpdHNfcGVyX3BpeGVslGgKjAxCaXRzUGVyUGl4ZWyUk5RLAYWUUpSMDF9lY2Nfc3ltYm9sc5RLIIwVX2NvbnN0YW50X3JhdGVfZmFjdG9ylEsSjAxfbnVsbF9mcmFtZXOUiYwIX2Jyb3dzZXKUTnVijA55b3ViaXRfdmVyc2lvbpSMC3ByZWhpc3RvcmljlHViLg==
This is the metadata of your video, but updated to be in the YouBit 2.x format. Note that the video will then be incompatible with earlier versions.

I'm suspecting you upgraded to YouBit 2.0.0, but the video you're trying to decode was made with YouBit < 2.x. They are not compatible. Either decode with an earlier version of YouBit, or update the video's description to the following: gASVWwEAAAAAAACMD3lvdWJpdC5tZXRhZGF0YZSMCE1ldGFkYXRhlJOUKYGUfZQojAhmaWxlbmFtZZSMCHByaXYuemlwlIwIbWQ1X2hhc2iUjCBmMTI2MWRhZWNlOWM3MjdjNWUwZDY5NmRiODkxM2NkNZSMCV9zZXR0aW5nc5SMD3lvdWJpdC5zZXR0aW5nc5SMCFNldHRpbmdzlJOUKYGUfZQojAtfcmVzb2x1dGlvbpRoCowKUmVzb2x1dGlvbpSTlE2AB004BIaUhZRSlIwPX2JpdHNfcGVyX3BpeGVslGgKjAxCaXRzUGVyUGl4ZWyUk5RLAYWUUpSMDF9lY2Nfc3ltYm9sc5RLIIwVX2NvbnN0YW50X3JhdGVfZmFjdG9ylEsSjAxfbnVsbF9mcmFtZXOUiYwIX2Jyb3dzZXKUTnVijA55b3ViaXRfdmVyc2lvbpSMC3ByZWhpc3RvcmljlHViLg== This is the metadata of your video, but updated to be in the YouBit 2.x format. Note that the video will then be incompatible with earlier versions.

Traceback (most recent call last):   File "C:\Users\WORK\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 188, in _run_module_as_main     mod_name, mod_spec, code = _get_module_details(mod_name, _Error)   File "C:\Users\WORK\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 147, in _get_module_details     return _get_module_details(pkg_main_name, error)   File "C:\Users\WORK\AppData\Local\Programs\Python\Python39\lib\runpy.py", line 111, in _get_module_details     __import__(pkg_name)   File "C:\Users\WORK\Downloads\youbit-0.1.4\youbit-0.1.4\youbit\__init__.py", line 10, in <module>     from .yb import Encoder, Decoder   File "C:\Users\WORK\Downloads\youbit-0.1.4\youbit-0.1.4\youbit\yb.py", line 19, in <module>     import youbit.ecc.ecc as youbit_ecc   File "C:\Users\WORK\Downloads\youbit-0.1.4\youbit-0.1.4\youbit\ecc\ecc.py", line 4, in <module>     from youbit.ecc.creedsolo import RSCodec ModuleNotFoundError: No module named 'youbit.ecc.creedsolo'

That is another issue entirely. Your C extension was not compiled. Run build.py.


Infinite loop with mailer monolog service when running Symfony 5.4

How do you use Sentry?
Sentry SaaS (sentry.io)
SDK version
3.6.0
Steps to reproduce

Require sentry/sentry-symfony in a Symfony 5.4 application.
Setup monolog with a symfony_mailer handler.

Expected result
Working Symfony application
Actual result
Infinite loop:
This is the recurring part of the stack trace:
   19.9106   34245712 250. ContainerBlsxpCq\App_KernelProdContainer->ContainerBlsxpCq\{closure:...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11067-11072}() ...\vendor\symfony\mailer\Transport.php:170
   19.9106   34245712 251. ContainerBlsxpCq\App_KernelProdContainer->getMailer_TransportFactory_NullService() ...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11068
   19.9106   34245712 252. ContainerBlsxpCq\App_KernelProdContainer->getTraceableHttpClientService() ...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11113
   19.9106   34245712 253. ContainerBlsxpCq\App_KernelProdContainer->getMonolog_Handler_MainService() ...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:7195
   19.9107   34246960 254. ContainerBlsxpCq\App_KernelProdContainer->getMonolog_Handler_DevelopersService() ...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11273
   19.9107   34246960 255. ContainerBlsxpCq\App_KernelProdContainer->getMailer_MailerService() ...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11230
   19.9107   34247888 256. Symfony\Component\Mailer\Transport->fromStrings($dsns = ['main' => 'smtp://localhost']) ...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11072
   19.9107   34247888 257. Symfony\Component\Mailer\Transport->fromString($dsn = 'smtp://localhost') ...\vendor\symfony\mailer\Transport.php:105
   19.9107   34247888 258. Symfony\Component\Mailer\Transport->parseDsn($dsn = 'smtp://localhost', $offset = ???) ...\vendor\symfony\mailer\Transport.php:113
   19.9107   34248304 259. Symfony\Component\Mailer\Transport->fromDsnObject($dsn = class Symfony\Component\Mailer\Transport\Dsn { private $scheme = 'smtp'; private $host = 'localhost'; private $user = NULL; private $password = NULL; private $port = NULL; private $options = [] }) ...\vendor\symfony\mailer\Transport.php:161
   19.9107   34249360 260. ContainerBlsxpCq\App_KernelProdContainer->ContainerBlsxpCq\{closure:...\var\cache\prod\ContainerBlsxpCq\App_KernelProdContainer.php:11067-11072}() ...\vendor\symfony\mailer\Transport.php:170

Basically, the Monolog initializes the Monolog handlers, which get a tracable HTTP service injected, which requires the Monolog service again.
I guess this is something specific in my installation (I recently updated from Symfony 4.4), otherwise others would have reported this already.

I disabled the http_client integration for now to work around this problem.

Could you please share the Monolog configuration you're using to reproduce the issue?

packages/monolog.yaml:
monolog:
    channels:
        - app
        - import
        - translation

    handlers:
        backoffice:
            type: symfony_mailer
            from_email<EMAIL_ADDRESS>            to_email:
                -<EMAIL_ADDRESS>            subject: '[XXXXX] %%message%%'
            level: warning
            formatter: monolog.formatter.html
            content_type: text/html
            channels:
                - ratedownload

        developers:
            type: symfony_mailer
            from_email<EMAIL_ADDRESS>            to_email:
                -<EMAIL_ADDRESS>            subject: '[XXXXXX] %%message%%'
            level: warning
            formatter: monolog.formatter.html
            content_type: text/html
            channels:
                - app

monolog/prod/monolog.yaml:
monolog:
    handlers:
        main:
            type: fingers_crossed
            action_level: error
            handler: main_split
            excluded_http_codes: [ 404, 405 ]
            buffer_size: 50 # How many messages should be saved? Prevent memory leaks
            channels: [ "!ratedownload" ]
        main_split:
            type: group
            members: [ main_file, developers ]
        main_file:
            type: rotating_file
            path: "%kernel.logs_dir%/%kernel.environment%.log"
            level: info
            max_files: 10
        console:
            type: console
            process_psr_3_messages: false
            channels: [ "!event", "!doctrine", "!ratedownload" ]
            console_formatter_options:
                multiline: true
        #        deprecation:
        #            type: rotating_file
        #            path: "%kernel.logs_dir%/%kernel.environment%.deprecations.log"
        #            max_files: 10
        #        deprecation_filter:
        #            type: filter
        #            handler: deprecation
        #            max_level: info
        #            channels: ["php"]
        import:
            type: rotating_file
            path: "%kernel.logs_dir%/import.log"
            level: info
            channels: [ "import" ]
            max_files: 10
        translation:
            type: rotating_file
            path: "%kernel.logs_dir%/translation.log"
            level: info
            channels: [ "translation" ]
            max_files: 10
        sentry:
            type: sentry
            level: !php/const Monolog\Logger::ERROR
            hub_id: Sentry\State\HubInterface
            bubble: true
            fill_extra_context: true

I tried using your configuration and I cannot reproduce the issue. I didn't set the MAILER_DSN environment variable, so it's using the NullTransport of the Mailer. Likely I'm missing something, but I don't know what. Could you prepare a little repo reproducing the problem?

I tried to reproduce it in an empty project. In this project, the getMailer_TransportFactory_NullService method of the container looks like this:
    protected function getMailer_TransportFactory_NullService()
    {
        $a = ($this->privates['monolog.logger.mailer'] ?? $this->getMonolog_Logger_MailerService());

        if (isset($this->privates['mailer.transport_factory.null'])) {
            return $this->privates['mailer.transport_factory.null'];
        }
        $b = ($this->services['event_dispatcher'] ?? $this->getEventDispatcherService());

        if (isset($this->privates['mailer.transport_factory.null'])) {
            return $this->privates['mailer.transport_factory.null'];
        }
        $c = ($this->privates['.debug.http_client'] ?? $this->get_Debug_HttpClientService());

        if (isset($this->privates['mailer.transport_factory.null'])) {
            return $this->privates['mailer.transport_factory.null'];
        }

        return $this->privates['mailer.transport_factory.null'] = new \Symfony\Component\Mailer\Transport\NullTransportFactory($b, $c, $a);
    }

In the 'broken' project, it looks like this:
    /**
     * Gets the private 'mailer.transport_factory.null' shared service.
     *
     * @return \Symfony\Component\Mailer\Transport\NullTransportFactory
     */
    protected function getMailer_TransportFactory_NullService()
    {
        include_once \dirname(__DIR__, 4).''.\DIRECTORY_SEPARATOR.'vendor'.\DIRECTORY_SEPARATOR.'symfony'.\DIRECTORY_SEPARATOR.'mailer'.\DIRECTORY_SEPARATOR.'Transport'.\DIRECTORY_SEPARATOR.'TransportFactoryInterface.php';
        include_once \dirname(__DIR__, 4).''.\DIRECTORY_SEPARATOR.'vendor'.\DIRECTORY_SEPARATOR.'symfony'.\DIRECTORY_SEPARATOR.'mailer'.\DIRECTORY_SEPARATOR.'Transport'.\DIRECTORY_SEPARATOR.'AbstractTransportFactory.php';
        include_once \dirname(__DIR__, 4).''.\DIRECTORY_SEPARATOR.'vendor'.\DIRECTORY_SEPARATOR.'symfony'.\DIRECTORY_SEPARATOR.'mailer'.\DIRECTORY_SEPARATOR.'Transport'.\DIRECTORY_SEPARATOR.'NullTransportFactory.php';

        $a = ($this->services['event_dispatcher'] ?? $this->getEventDispatcherService());

        if (isset($this->privates['mailer.transport_factory.null'])) {
            return $this->privates['mailer.transport_factory.null'];
        }

        return $this->privates['mailer.transport_factory.null'] = new \Symfony\Component\Mailer\Transport\NullTransportFactory($a, ($this->privates['.debug.http_client'] ?? $this->get_Debug_HttpClientService()), ($this->privates['monolog.logger.mailer'] ?? $this->getMonolog_Logger_MailerService()));
    }

The isset calls break the loop. I have no idea why my project doesn't have them.
The repository with the example that works is at https://github.com/jorrit/sentry-symfony-bug-demo.

I tried cloning your repository and running the bin/console script and it works fine, no issues during the compilation of the container. I'm sorry, I don't know how to help without a project that clearly shows the error.

I know, the repository works fine. I have yet to figure out why that repository works and my private project doesn't. It has something to do with the difference in how the DI container is generated. I'll close this issue because at this moment it doesn't seem to involve sentry directly. I will reopen when there might be something that can be improved here.
Thank you for your time.

Hola alguna solución para este bug, a mi también me ocurre

@jorrit Any news on this? I seem to have the same issue (loop / segmentation fault when installing sentry and having a monolog handler of type symfony_mailer registered) here.
References:
https://discord.com/channels/621778831602221064/1305933891202449438
https://github.com/sulu/sulu/discussions/7650

No news, I still use the work-around.

@jorrit Your workaround is to disable http_client right? Sadly
I'm not able to as I'm using Sulu CMS which needs the HTTP client.

I disabled the Sentry - HTTP client tracing integration, not the whole http client.
This is the configuration in config/packages/sentry.yaml:
when@prod:
    sentry:
....
        tracing:
            http_client: # Symfony HTTP client
                enabled: false # See https://github.com/getsentry/sentry-symfony/issues/796

@jorrit Thanks a lot for the clarification, this works for me too!


noweb: 2.12 -> 2.13

Description of changes
https://github.com/nrnrnr/noweb/releases/tag/v2_13
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Verified against a project locally (and the indentation is fixed).


Distance in list

Resolves #116

@jake-shasteen  everything works :+1:

@jake-shasteen  this works for me as well! no conflicts found.


[feature] Added controller integration for wireguard #150

Closes #150

Coverage decreased (-1.0%) to 98.247% when pulling c1b372cc907dab9a9c5d5a6c8430b0b43b81b5eb on issues/150-wireguard-controller-integration into<PHONE_NUMBER>4e961bb3f7e132af91f6747087645d on master.


Can I get permission to push a new branch?

I have an update for the site ready locally with the new ShirubaSprings course and WinterMajor2020. Unfortunately I'm unable to push a new branch to GitHub.
I get permission denied when I try to push the new branch up to open a PR.
ERROR: Permission to golf-clash-notebook/golf-clash-notebook.github.io.git denied to KalamazooJiggs.

No permission is needed to open a PR. You can check out this guide. Let me know if you have any other questions.

Oh I can create fork and create a PR from that. 😁
I’ll do it as soon as I’m back home.


Setup CI

[x] Include black
[x] Include interrogate
[x] Coverage
[x] Unimport
[x] pytest-random
[x] pytest-flake8
[x] Mypy

Closed by #8
(Did not use unimport: would not give failure code.)


Why SideEffect is mandatory for ContainerHost?

I want to write a ContainerHost based ViewModel without any side effect because i don't need any side effect in a particular use case, but orbit-mvi is enforcing me to have a side effect anyway.
interface ContainerHost<STATE : Any, SIDE_EFFECT : Any>
The question is, how can i write a ViewModel without having any side effect?

As an example, i want to write a CounterViewModel which just increments and decrements the count. In this case there is no need to have any side effect.

@yasiralijaved You can declare ContainerHost<SomeState, Nothing>