Version 3.4.2

Adding license to source distribution for https://github.com/cdgriffith/Box/issues/92

Coverage remained the same at 100.0% when pulling 466c19a6e56e1ae8c483d562044f16453c3e4540 on development into 3d221d7b33c1138a6c732a45ac943b201bd7fea2 on master.


reloadData and veryShortStandaloneWeekdaySymbols

As you can see here in the reloadData method the weekDays always displayed from shortStandaloneWeekdaySymbols. without checking the _useVeryShortWeekdaySymbols flag.
an if statement must be added to check _useVeryShortWeekdaySymbols to choose between shortStandaloneWeekdaySymbols and veryShortStandaloneWeekdaySymbols.
I don't know how to do it :)

(void)reloadData
{
_minimumDate = self.minimumDateForCalendar;
_maximumDate = self.maximumDateForCalendar;
[_weekdays setValue:[UIFont systemFontOfSize:_appearance.weekdayTextSize] forKey:@"font"];
CGFloat width = self.fs_width/_weekdays.count;
CGFloat height = kFSCalendarDefaultWeekHeight;
[_calendar.veryShortStandaloneWeekdaySymbols enumerateObjectsUsingBlock:^(NSString *symbol, NSUInteger index, BOOL *stop) {
if (index >= _weekdays.count) {
*stop = YES;
return;
}
UILabel *weekdayLabel = _weekdays[index];
weekdayLabel.text = symbol;
}];
[_weekdays enumerateObjectsUsingBlock:^(UILabel *weekdayLabel, NSUInteger idx, BOOL *stop) {
NSUInteger absoluteIndex = ((idx-(_firstWeekday-1))+7)%7;
weekdayLabel.frame = CGRectMake(absoluteIndex * width,
_header.fs_height,
width,
height);
}];
_needsReloadingSelectingDates = YES;
[_collectionView reloadData];
[_header reloadData];
}

Weekday symbol doesn't need to be reloaded at all. Remove it would solve the problem.

I use cocoa pod as pod 'FSCalendar'. Is there a chance that the latest version is not on the cocoapods? because I can't find the calendar:shouldDeselectDate: delegate!

No. It's already been pushed to cocoapods. You can run pod try 'FSCalendar' to see the results


Need to resolve the infinite sapling glitch detected

Resolved in version 1.0.2: Associated group players no longer receive drops from saplings. To handle this better, it would require integrating with whatever controls the auto-planting, which sounds like more trouble than it's worth, especially when prisoners shouldn't be planting their own trees, in my opinion.


Does it have flash-attention 2?

It seems that they have incorporated sdpa, flex-attention but there is no flash-attention 2. Have I missed anything?

Depending on the gpu, sdpa selects the fastest kernel for your setup, including Flash Attention v2.


Fix tests for network-policy-advisor

It was not testing anything because the source files were in a different
directory than expected. Moreover, it was dependent on the current
working directory, so the following was running tests differently:

go test ./pkg/gadgets/networkpolicy/...
cd pkg/gadgets/networkpolicy ; go test ./...

Fixes 7b68ec33b594934fed7c4d8ad1db5e2e8e351d00

The CI failure seems unrelated to my patch.

The CI failure seems unrelated to my patch.

Yeah, it happens sometimes and it is quite frustrating to need to re-run the CI without knowing what happened.
I have been thinking about it and I think it would be useful to have the logs of the gadget pods to be sure there wasn't an error that wasn't sent to the CLI (I added it in PR https://github.com/kinvolk/inspektor-gadget/pull/556). And, the logs or output of the test-pod to be sure that the command that has to create the events for triggering the gadget actually worked (see issue https://github.com/kinvolk/inspektor-gadget/issues/567).
What do you think? What else do you think we can do to have enough information to debug this situation?

What do you think? What else do you think we can do to have enough information to debug this situation?

I think your suggestions are good for this failure.
For other tests, it might make sense to print the list of pods (kubect get pods -A) and the last events (kubectl get events -A) like in command.go#L110. That could include explanations why a pod didn't start.

The network-policy-advisor tests are being rewritten and fixed in https://github.com/kinvolk/inspektor-gadget/pull/577. If PR 577 is merged, we don't need this PR anymore.


🎉 release: v4.1.0

Description
This is a release PR.

:tada: This PR is included in version 4.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[CARBONDATA-4006] Fix for currentUser as NULL in getcount method during index server fallback mode

Why is this PR needed?
In case of index server fallback, Server.getRemoteUser.getShortUserName always returns NULL. Can give null pointer exception in any generic events.
What changes were proposed in this PR?
Do not launch any generic events in case of index server fallback mode. The behaviour is similar as getSplits and invalidateSegmentCache API's.
Does this PR introduce any user interface change?

No
Yes. (please explain the change and update document)

Is any new testcase added?

No
Yes

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4194/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4196/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2453/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4202/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2459/

@kunal642

retest this please

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2522/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4267/

LGTM

@kunal642 @akashrn5 please merge this

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4713/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/2956/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4760/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3002/

LGTM


Losing AutoLayout constraints when usingblurEffectStyle in a container view

AutoLayout constraints will be gone when usingblurEffectStyle in a container view.

May document it and remove BlurDesignable from AnimatableScrollView and AnimatableStackView

Instead of removing from AnimatableScrollView and AnimatableStackView, can't we transfer the constraints to the new view?

I'll try, but seems quite hard

There is maybe another bug :
Each time configBlurEffectStyle is called (when changing blurOpacity or blurEffect value for instance) a new Blur subview is added : insertSubview(blurEffectView, at: 0).
This behaviour can easily be tested using https://github.com/IBAnimatable/IBAnimatable/tree/feature/BlurEffectStyle

You are right @lastMove, we have to remove the previous one before adding a new blur view.

How about we add a tag like IBAimatableBlurEffectView? Then we can remove the effect view before re-add if it exists.

Sounds faire enough 👍

You are thinking about a tag or about a UIView subclass.
I prefer the internal subclass approach, since with tag there is a collision risk.

An internal or even private subclass would be better, I didn't figure out this approach, 👍
Jake
Sent from my iPhone

On 1 Aug 2016, at 1:32 AM, Jason Ak<EMAIL_ADDRESS>wrote:
You are thinking about a tag or about a UIView subclass.
I prefer the internal subclass approach, since with tag there is a collision risk.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@JakeLin Did you find a solution about this issue? Should we update the docs?
Another though, it could be great to add an example of blur / vibrancy in the playground app.

I added a demo of blur / vibrancy "User interface => Blur Effect"

@tbaranes I didn't find a solution for that, I think we should remove BlurDesignable from AnimatableScrollView and AnimatableStackView. And only AnimatableView and AnimatableImageView can support BlurDesignable. And add documentation comment to BlurDesignable.vibrancyEffectStyle to let the user know all constraints for the subviews will be lost once well apply the Vibrancy Effect style. The workaround is to reset the constraints programmatically.


Typescript NodeNext path alias with extension

I have a typescript project with moduleResolution: 'NodeNext'. In my tsconfig.json, I have set up an alias which points directly to a file. In the ES spec, this would be with the file extension, and thus should be in the alias target:
tsconfig.json
{
	"paths": {
		"alias": ["path/to/specific/file.mjs"]
	}
}

Eslint complains, if I try:
import something from 'alias';

with "Unable to resolve path to module 'alias'".
Am I configuring this incorrectly, or is this not yet supported?

I forgot to add that Typescript correctly resolves to the file, so this isn't an issue with the alias specification.

If you still have any issue, please provide a runnable reproduction.

@JounQin Pretty simple case: https://github.com/WoodyWoodsta/repro-eslint-import-resolver-typescript-191

@JounQin Did you manage to have a look at the reproduction above?
I'm experiencing the same issue on v3.6.1. It also seems related to https://github.com/import-js/eslint-import-resolver-typescript/issues/234.

Sorry, I've totally forgotten about this issue, I'll take a look when I'm free at this weekend, or you can help to debug first.

The fix is easy:
{
	"paths": {
		"alias": ["path/to/specific/file.mts"]
	}
}


Implement a Classifier

UPD: Another (better) candidate: https://coltekin.github.io/offensive-turkish/

Just like many packages libraries I suggest an examples directory for use cases of SadedeGel.

Just like many packages libraries I suggest an examples directory for use cases of SadedeGel to display such implementations.

Agreed. Also will allow us to add links to binder notebook on the examples/README.md for easy access.

Here is a benchmark dataset for this task.
https://www.kaggle.com/savasy/ttc4900

What is the next action for this task to be closed ?

What is the next action for this task to be closed ?
Upload our notebooks to /notebooks ?

Pull request is sent ?

#174 done :)

I implemented a base class under sadedegel.classification. The PR is branched from feature/tokenizer_data named as feature/news_classification. The next action will be a training CLI that consumes the labeled dataset of TS Corpus.

Let's track diffrent things in different issues. I will accept @askarbozcan 's pull request but this is not what we want. We need to show sadedegel can yield accuracyt results for different problem sets. Moreover this should be test across major releases. This might be related to what @dafajon has done.

It seems that we are pretty done with this.


fix: request_headers

fix: request_headers
change from '"Authorization" : authorization' to '"Authorization" : authorization'

@johnheintz do you know if the auth header format changed?

fix: request_headers
change from '"Authorization" : authorization' to '"Authorization" : authorization'

@t-umeno it was just the extra space inside the string?

Thanks @t-umeno

Thanks!
2020年8月4日(火) 6:39 John Heintz<EMAIL_ADDRESS>
Thanks @t-umeno https://github.com/t-umeno
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CiscoDevNet/stealthwatch-cloud-sample-scripts/pull/1#issuecomment-668255192,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLMYD2C2M53JNKISQSNIETR64VBRANCNFSM4PTLEVIQ
.


No App Connection to Race Timer when mobile data is turned on

Hi just faced problems to connect to the Race Tracker via Wifi.
I discovered, i need to turn of the mobile Data. Then it works perfectly.
Phone: OnePlus 5T
Android: 8.0.0
OxygenOS: 5.0.3
Anyone having the same issue?

Hotspot provided by the Wifi module obviously doesn't provide internet access - modern versions of Android will detect that and will still use mobile data despite being connected to the hotspot. Turning off the data is one workaround, the other one should be a notification in the statusbar that pops up after connecting to such a network - "Access point has no internet. Touch to configure" (or something similar sounding. After clicking the notification there should be an option to stay connected to the AP. That should solve the issue as well


Octet and Directory String in Active Directory

Guys, you developed perfect library for node.js! But I found one issue, ldapjs can't recognize difference between Octet and Directory String and make utf-string, not array.
My code: https://gist.github.com/magmel48/114a17228e35761d6efc
AD values:

Response from my code (I tried to get objectGUID value):

+1 had a similar issue retrieving thumbnailPhoto attribute, wherein I was using entry.object in which I was getting a corrupted buffer. But when I used the  entry.raw everything starting working great. Thanks @pfmooney and @magmel48.


Move Delete and Edit Buttons to left side of screen

This will ensure I'm not reaching over those buttons when trying to move items.

The placement of the buttons appears fine, and the issue I was initially concerned about appears to be a non-issue. Plus, this will conflict with #7.
If this becomes an issue for other users, they could switch the app into left-hand mode (see #7) to mitigate the issue.


Fix profile section css overflow

@nileshgulia1  I will merge this as a quickfix but I have added a comment to state that this code will be removed at a later date.
ITML together with me need to modify the container overrides so that there isn't crazy left and right margins like it is currently set.
Once that is done this code will be obsolete, however for the sake of having one visual annoyance "fixed" I will merge these changes.

We should get rid of the horizontal scroll:
https://user-images.githubusercontent.com/323385/157396997-af4c930c-e8aa-4f4b-8307-feb00b3c28df.mp4


Publish to Bower

It's published now, I've not made any releases yet though as this probably doesn't work with the latest quickcheck - it's intended for the version we release with purescript 0.7.

I would really like to see this library published - is there anything I can do to help? What needs to be done?

I have a version that simplifies a whole bunch of stuff. I'll try and finish it up soon and get this thing published at last.

Released at last!

Now I need to make the same thing for strongcheck I guess...

\o/ thank you!

:+1:


The audio display bar is the wrong color

Every time a new wallpaper is loaded, the color of the audio bar will not change to the new preset, and will always be the initial red audio bar

Hi! Can you send me an example with another wallpaper and which preset of this wallpaper you are using? Thanks

你好！您能否向我发送一个包含其他壁纸的示例以及您正在使用该壁纸的哪个预设？谢谢

Ok, thanks, the latter one and the first one have the same problem。
1：https://steamcommunity.com/sharedfiles/filedetails/?id=2895273156
2：https://steamcommunity.com/sharedfiles/filedetails/?id=2298673278
2298673278.zip
2895273156.zip


Add ImmutableVector3Builder

It's mentioned in a comment, but the implementation doesn't exists.
https://github.com/Mojang/minecraft-scripting-libraries/blob/8cf3f6aa9c7d1826f2e8abc74fa583d17b1b8795/libraries/math/src/vector3/vectorWrapper.ts#L13

A build of a stale comment leftover when I was first implementing this I guess. I was a bit torn on how valuable people would find the immutable version vs. just using the functions instead. Is this something you would find valuable?


chore: integrate currency input widget

Fixes #27747
https://github.com/appsmithorg/appsmith/assets/6636360/9234acc1-f41a-4ca8-aaf6-15c66e2b3e9d

/ok-to-test

/build-deploy-preview skip-tests=true

It's better to show an error than to erase user's input.

/build-deploy-preview skip-tests=true

Why do we list Euro for each individual country that uses it?
Also, please be aware that not every convention uses comma, some use point: https://en.wikipedia.org/wiki/Decimal_separator#Hindu–Arabic_numerals

Why do we list Euro for each individual country that uses it? Also, please be aware that not every convention uses comma, some use point: https://en.wikipedia.org/wiki/Decimal_separator#Hindu–Arabic_numerals

If we are solving for this, I think it's also worth mentioning that the place values used in the Indian numeral system are different than the International numeral system.
Example - 1000000 would be 10,00,000 in the Indian system and 1,000,000 in the international one.

Yes, there's a huge variety with digit grouping too, but at least that is done automatically and doesn't interfere with user's input / result in an error unlike the decimal.

Why do we list Euro for each individual country that uses it?
I am also not sure about why did this way.

Also, please be aware that not every convention uses comma, some use point:
Yes, that is handled with Intl class ( https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl )

If we are solving for this, I think it's also worth mentioning that the place values used in the Indian numeral system are different than the International numeral system.

Very good catch. The current implementation is not solving this. But let me create an issue for this to track.

@dhruvikn added the issue here - https://github.com/appsmithorg/appsmith/issues/28862

/ok-to-test

/ok-to-test

Yes, that is handled with Intl class ( https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl )

That seems unreliable, could we instead allow both comma and period as valid input?

That seems unreliable, could we instead allow both comma and period as valid input?
It should depend on the language the user is using. Allowing both will just create confusion.

It should depend on the language the user is using. Allowing both will just create confusion.

That is very unreliable, subject to a combination of many OS and browser settings. It is very likely therefore to not match what the user is expecting. Allowing both would only create confusion if user is trying to do digit grouping manually, but at least would allow decimal input.

I feel you are mixing two things, Language and Currency. How we show the currency should depend on the language user is using. 🤔
Currency is just an number but the period and comma representation are the part of the language.


Local composites

Example notebook from EERIE Hackathon 2023 - local composites of IFS-AMIP data on warm/cool mesocsale SST features.

Chris, sorry, was travelling, took some time to accept :(


Adds deprecation warning

It doesn't make much sense for us to maintain this project, so I think it makes sense to add this message and, probably, make this repo read only.

Thanks. I fixed it, rebased and merged into master in 322771cf90acf4178abcaf255ab0566848ffc399.


Add postgres Test container with default configurations for the postg…

Here is the PR with the Postgres Changes,
In this Pr we are using PG as client

Looks like the Gemfile.lock file needs to be updated as well.

Merged in https://github.com/guilleiguaran/testcontainers-ruby/commit/18bf976f8b1c9e4ad068542b6aeb7bc4a9db1a04


Some labels show rectangles instead of characters in russian locale.

Some labels show rectangles instead of characters in russian locale:

Just pushed the fix in 1.3.7


Fixbuildtask

When building for desktop buildtask, tests and vsintegration use converter.
When building for coreclr all use func.
Dev 15 will use func all up.
Fixes #1144

Thanks so much!


WIP ENH add SCAD penalty

Revival of old branch. The goal of this branch is to add the SCAD and BlockSCAD penalties.

I copy-pasted the work already done by @Klopfe in the previous repo. I'm working on BlockSCAD.
@Klopfe @QB3 @mathurinm any ideas on against which solver/framework we should test SCAD (also MCP, and L0.5). The non-convex penalties are not tested at the moment.

update: blockSCAD does converge now, but very slowly. With ws_strategy="fixpoint", it is faster. I suspect the distance to the subdifferential is wrong for one case (see the review above).
I'd suspect there's still an error in the prox computation.

From the experiments I performed, no. Now it works fine. I'd be glad if you could tell me if it works fine for you.

From the experiments I performed, no. Now it works fine. I'd be glad if you could tell me if it works fine for you as well.

I'll run some tests and let you know. It would be nice to merge this PR soon. Thanks for the great work!

@PABannier can you add unit tests for Scad and BlockSCAD ?

@PABannier can you add unit tests for Scad and BlockSCAD ?

Do we know how we could test SCAD @PABannier @mathurinm ? It is not so clear to me.

I wish we could factoriz the subdiff and block subdiff, but it does not seem trivial to me. Apart from this, LGTM.

yes, I spent quite a while trying to do so but it does not seem so easy... I think we can leave it as it is right now.


Adding SSL certificates through http does not seem to update

Description
Adding SSL certificates through http does not seem to update
Steps to reproduce the issue:

curl -i -XPUT
--data-binary @certs/xip.io.pem
"$(docker-machine ip node-1):8080/v1/docker-flow-proxy/cert?certName=xip.io.pem&distribute=true"

2.` curl "$(docker-machine ip node-1).xip.io:8080/v1/docker-flow-proxy/config"`

3. **Expected**

frontend services
bind *:80
bind *:443 ssl crt /certs/xip.io.pem
mode http

**Actual:**

frontend services
bind *:80
bind *:443 ssl crt-list /cfg/crt-list.txt
mode http

Since quite a few releases ago, certificates were moved to crt-list.txt. Can you output the contents of the /cfg/crt-list.txt file?

cfg.zip

Thanks @vfarcic  for looking into this. Attached zip file of the directoru.

Are you sure that the /cfg dir you sent me is the correct one? Seems that the proxy is in a different state than the one described in the issue. haproxy.cfg from the zip file has bind *:443 while in the issue description it's bind *:443 ssl crt-list /cfg/crt-list.txt.

I sent you the wrong /cfg folder. I checked the /cfg/crt-list.txt and it does point to the pem file. I guess I got confused because the documentation was not caught up. Sorry about that.

@adi-raghavendra Can you make a PR with a corrected documentation?

https://github.com/vfarcic/docker-flow-proxy/pull/306


Merge pull request #47 from fabianvf/support-upstream-interfaces

support upstream interfaces in listers and informers
Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

/retitle https://github.com/kcp-dev/code-generator/pull/49

/retitle generators: handle relative paths to go.mod


Stripe Checkout SCA upgrade

Is Cashier being updated to work with the new Stripe Checkout (SCA compliant) which has to be implemented by September this year? If so, will that Cashier version be compatible with Laravel 5.6 or will I have to upgrade my project to Laravel 5.8?

Hi there. You can follow along here: https://github.com/laravel/cashier/issues/637.
The next Cashier version will require at least 5.8


pianoroll_str_to_df doesn't recreate original input when it should

To recreate the error:
import
pitches = [60, 60, 62, 64, 62, 60, 64, 60, 64]
bpm = 120
beat_dur = 60/bpm * 1000
durations = [1, 1, 1, 1, 1, .5, .5, 2, 2]
durations = [int(beats*beat_dur) for beats in durations]
onsets = [0, 1, 2, 3, 4, 5.5, 5.5, 6, 6]
onsets = [int(beats*beat_dur) for beats in onsets]
excerpt = pd.DataFrame(
    {
        "onset": onsets,
        "track": 0,
        "pitch": pitches,
        "dur": durations,
    }
)
pianoroll_str = df_to_pianoroll_str(excerpt, time_increment=250)
note_df = pianoroll_str_to_df(pianoroll_str, time_increment=250)
assert note_df.equals(excerpt), "oops"

The diff is index 4, duration increases from 500 to 750 i.e. the silence is ignored.
Additionally the docstring is incorrect - it creates a note df, not a pianoroll

The issue was: If a note ends on an otherwise empty frame, it is not detected until the following frame.


[Bug] The parameters n=number_outputs does not work in the function: response = client.chat.completions.create

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.

Describe the bug
I server internvl-76b with lmdeploy:
CUDA_VISIBLE_DEVICES=0,1,2,3 /opt/anaconda3/envs/internvl-ins-lmdeploy/bin/lmdeploy serve api_server ${model_path} --session_len 8192 --model-name ${MODEL_NAME} --backend turbomind --enable-prefix-caching --vision-max-batch-size 1 --server-port ${PORT} --tp 4 --chat-template /zhangjunlei/code/internVL/internvl_chat/lmdeploy_internvl2_chat_template.json >laji_23334_1.log 2>& 1&
I tried to ran the self-consistantce setting, where I need to generate multiple outputs at once.
Here:
        response = client.chat.completions.create(
            model=model,
            messages=messages,
            temperature=temperature,
            max_tokens=max_tokens,
            top_p=top_p,
            n=num_outputs,
            stop=stop_token
        )

The version of openai I used is the latest. The num_outputs does not work and always return only 1 choice in the response.
The output is like:
`ChatCompletion(id='9', choices=[Choice(finish_reason='stop', index=0, ...
Reproduction
CUDA_VISIBLE_DEVICES=0,1,2,3 /opt/anaconda3/envs/internvl-ins-lmdeploy/bin/lmdeploy serve api_server ${model_path} --session_len 8192 --model-name ${MODEL_NAME} --backend turbomind --enable-prefix-caching --vision-max-batch-size 1 --server-port ${PORT} --tp 4 --chat-template /zhangjunlei/code/internVL/internvl_chat/lmdeploy_internvl2_chat_template.json >laji_23334_1.log 2>& 1&
Environment
225] sys.platform: linux
[226] Python: 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0]
[227] CUDA available: True
[228] MUSA available: False
[229] numpy_random_seed:<PHONE_NUMBER>
[230] GPU 0,1,2,3: NVIDIA A100-SXM4-80GB
[231] CUDA_HOME: /usr/local/cuda
[232] NVCC: Cuda compilation tools, release 11.8, V11.8.89
[233] GCC: gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
[234] PyTorch: 2.2.2
[235] PyTorch compiling details: PyTorch built with:
[236]   - GCC 9.3
[237]   - C++ Version: 201703
[238]   - Intel(R) oneAPI Math Kernel Library Version 2023.1-Product Build 20230303 for Intel(R) 64 architecture applications
[239]   - Intel(R) MKL-DNN v3.3.2 (Git Hash 2dc95a2ad0841e29db8b22fbccaf3e5da7992b01)
[240]   - OpenMP 201511 (a.k.a. OpenMP 4.5)
[241]   - LAPACK is enabled (usually provided by MKL)
[242]   - NNPACK is enabled
[243]   - CPU capability usage: AVX512
[244]   - CUDA Runtime 12.1
[245]   - NVCC architecture flags: -gencode;arch=compute_50,code=sm_50;-gencode;arch=compute_60,code=sm_60;-gencode;arch=compute_61,code=sm_61;-gencode;arch=compute_70,code=sm_70;-gencode;arch=compute_75,code=sm_75;-gencode;arch=compute_80,code=sm_80;-gencode;arch=compute_86,code=sm_86;-gencode;arch=compute_90,code=sm_90
[246]   - CuDNN 8.9.2
[247]   - Magma 2.6.1
[248]   - Build settings: BLAS_INFO=mkl, BUILD_TYPE=Release, CUDA_VERSION=12.1, CUDNN_VERSION=8.9.2, CXX_COMPILER=/opt/rh/devtoolset-9/root/usr/bin/c++, CXX_FLAGS= -D_GLIBCXX_USE_CXX11_ABI=0 -fabi-version=11 -fvisibility-inlines-hidden -DUSE_PTHREADPOOL -DNDEBUG -DUSE_KINETO -DLIBKINETO_NOROCTRACER -DUSE_FBGEMM -DUSE_QNNPACK -DUSE_PYTORCH_QNNPACK -DUSE_XNNPACK -DSYMBOLICATE_MOBILE_DEBUG_HANDLE -O2 -fPIC -Wall -Wextra -Werror=return-type -Werror=non-virtual-dtor -Werror=bool-operation -Wnarrowing -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-unused-parameter -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-stringop-overflow -Wsuggest-override -Wno-psabi -Wno-error=pedantic -Wno-error=old-style-cast -Wno-missing-braces -fdiagnostics-color=always -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Werror=format -Wno-stringop-overflow, LAPACK_INFO=mkl, PERF_WITH_AVX=1, PERF_WITH_AVX2=1, PERF_WITH_AVX512=1, TORCH_VERSION=2.2.2, USE_CUDA=ON, USE_CUDNN=ON, USE_EXCEPTION_PTR=1, USE_GFLAGS=OFF, USE_GLOG=OFF, USE_MKL=ON, USE_MKLDNN=ON, USE_MPI=OFF, USE_NCCL=ON, USE_NNPACK=ON, USE_OPENMP=ON, USE_ROCM=OFF, USE_ROCM_KERNEL_ASSERT=OFF,
[249]
[250] TorchVision: 0.17.2
[251] LMDeploy: 0.6.0+
[252] transformers: 4.37.2
[253] gradio: 3.35.2
[254] fastapi: 0.112.0
[255] pydantic: 2.8.2
[256] triton: 2.1.0
[257] NVIDIA Topology:
[258] 	GPU0	GPU1	GPU2	GPU3	NIC0	CPU Affinity	NUMA Affinity	GPU NUMA ID
[259] GPU0	 X 	NV12	NV12	NV12	SYS	0-31,64-95	0		N/A
[260] GPU1	NV12	 X 	NV12	NV12	SYS	0-31,64-95	0		N/A
[261] GPU2	NV12	NV12	 X 	NV12	PXB	0-31,64-95	0		N/A
[262] GPU3	NV12	NV12	NV12	 X 	PXB	0-31,64-95	0		N/A
[263] NIC0	SYS	SYS	PXB	PXB	 X
[264]
[265] Legend:
[266]
[267]   X    = Self
[268]   SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
[269]   NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
[270]   PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
[271]   PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
[272]   PIX  = Connection traversing at most a single PCIe bridge
[273]   NV#  = Connection traversing a bonded set of # NVLinks
[274]
[275] NIC Legend:
[276]
[277]   NIC0: mlx5_0
[278]

Error traceback
No response

Yes. We haven't supported n>1


fix(ci): LINUX_AMD64_RELEASE is no more ignored thanks to curly braces

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.47%. Comparing base (8a9f0a2) to head (1159895).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   92.43%   92.47%   +0.04%
==========================================
  Files          47       47
  Lines        4386     4386
==========================================
+ Hits         4054     4056       +2
+ Misses        231      230       -1
+ Partials      101      100       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: fixed content width on wide displays

"Solves" misalignment on some pages with too little content.
Before:

After:
https://github.com/user-attachments/assets/264e22f9-b073-4140-ab12-a9324f46ee70

The issue persists on mid-size desktop (laptop) screens—the fixed-width styling can only be applied on large enough displays; otherwise, the content gets obscured on other pages with actual content.
The moving sidebar is caused by not having enough content (vertically).

I'm torn between merging and closing this as wontfix. A similar issue (although much bigger) was solved by https://github.com/apify/apify-docs/pull/1216. This one is simply caused by not enough content (likely present in vanilla Docusaurus as well) and while having quite a simple solution, it adds extra complexity and yet another media query breakpoint to the already complex styling system for the docs.


XIVY-9347 Use uuid for task instead of id

Also im not sure if you saw it but ES reindexing takes now quite a bit longer 😞

Also im not sure if you saw it but ES reindexing takes now quite a bit longer disappointed

related to UUID?

Also im not sure if you saw it but ES reindexing takes now quite a bit longer disappointed

related to UUID?

im not 110% sure. but it started being slower on 12th of May and i saw you merged UUID on 11th?


Measure impact of global type inferencing on largish standalone benchmark

Let's get some numbers on the compile-time performance impact of enabling global type inferencing. Of course, knowing where it helps on generating smaller and faster code would also be good.

Global type inference is the default in dart2js.


First release

All the following issue should be base on the branch : 138-first-release
For this issue to be close, all the following issue should be done:

[x] #130
[x]  #131
[x]  #132
[x]  #133
[x]  #134
[x]  #135
[x]  #136
[x]  #137

When this issue is close, no more issue should be resolved for the first deployment

What I use github desktop and it merge without me asking to merge gonna fix that


Add versionCode property to AndroidManifestInfoReceiver

Goal
Right now the manifest is determined to be the source of truth for the application versionCode, but there are new APIs in AGP that allow setting it via onVariants...outputs.versionCode. This appears to be set after manifest processing, so it results in uploaded mapping files that don't match on Bugsnag's backend for retracing due to a version code mismatch.
Design
I've wired in just enough right now to set it manually, as a toe-hold for the future. It adds an optional versionCode property that will take precedence if set but otherwise defer to the manifest version (which matches AGP's behavior). Integrating this across the many AGP versions that the Bugsnag plugin supports will take more time. I'd like to propose going with this as a toe-hold for now and consumers like us can manually set it as-needed while a longer term integration is sought, as it would impact the current way variants are loaded and require newer APIs.
Testing
Just a unit test for now, planning to test this in our project to make sure the versionCode override works

The last two commits were opportunistic to make it easy to filter on these types when using tasks.withType<...>() APIs to filter

Hey @ZacSweers,
Thanks for this, we will review as soon as we can.

Confirmed internally that using this change and setting the version code property resolves the original issue for us

Thanks for the contribution @ZacSweers - these commits will be merged with #375 so I'm closing this PR.

Hey @ZacSweers, this got merged down through https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/375 and was released in https://github.com/bugsnag/bugsnag-android-gradle-plugin/releases/tag/v5.7.5. Thank you for your contribution!


Linked container will no longer be stopped and restarted

Now docker seems to treat --link (as well as docker-compose links) within NetworkSettings Links instead of inside HostConfig. When new dependent docker image is fetched by watchtower, only such container is auto closed and restarted, other linked containers (which links to updated container and should be restarted together) are not handled correctly by watchtower.

Thanks for the repport.  None of our (multiple) linked containers are restarted when the container is updated.
 We now have to manually restart the containers to get it to work :(

@flipace  thanks for your report. Would it be possible for you to give me some example docker run commands with linked containers where watchtower is failing? That would greatly help me, to track it down.

I'm quite new to the Watchtower party, so I'm not sure whether I'm mis-interpreting the documentation other I'm also hitting this issue. A maximally reduced minimal example as follows:
version: '3'
services:

  nginx:
    image: nginx
    links:
      - service

  service:
    image: my-image
    labels:
      - com.centurylinklabs.watchtower.enable=true

  watchtower:
    image: v2tec/watchtower
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    command: --interval 10 --label-enable --debug --no-pull

Note, I'm using most of the watchtower parameters just for local testing.
Dockerfile for my-image:
FROM nginx
RUN echo "Hello world!" > /usr/share/nginx/html/index.html

Test it:
$ docker build -t my-image .
$ docker-compose up

Then, modify the Dockerfile for my-image and rebuild it:
$ docker build -t my-image .

After ~ 10 seconds, Watchtower detects the changes and the following happens:
watchtower_1  | time="2018-04-15T18:53:39Z" level=debug msg="Checking containers for updated images"
watchtower_1  | time="2018-04-15T18:53:39Z" level=debug msg="Retrieving running containers"
watchtower_1  | time="2018-04-15T18:53:39Z" level=info msg="Found new my-image:latest image (sha256:db72a62491ddd7ece16905d8557bfdd7d6a72628191210ef614f47c07672ac40)"
watchtower_1  | time="2018-04-15T18:53:39Z" level=info msg="Stopping /watchtowertest_service_1 (7f029015bce8df1fd7002a7ca76ff12929dc5e1c73ed025b71ccbd6095619e76) with SIGTERM"
watchtowertest_service_1 exited with code 0
watchtower_1  | time="2018-04-15T18:53:40Z" level=debug msg="Removing container 7f029015bce8df1fd7002a7ca76ff12929dc5e1c73ed025b71ccbd6095619e76"
watchtower_1  | time="2018-04-15T18:53:40Z" level=info msg="Creating /watchtowertest_service_1"
watchtower_1  | time="2018-04-15T18:53:40Z" level=debug msg="Starting container /watchtowertest_service_1 (fa697efe3ecd9d396752d83516cef92aa73136a0ce833d1ff8e67cef450e1854)"
watchtower_1  | time="2018-04-15T18:53:41Z" level=debug msg="Scheduled next run: 2018-04-15 18:53:49 +0000 UTC"

But the nginx service is not being restarted. According to the docs, I would have expected, that nginx would be restarted as well?

@qqilihq this looks like it's the same issue i have - i didn't have time to make the repro though, but yours looks good! we had to disable wt because of this :(

Are there any alternative projects that provide the same functionality?

I have detect the same issue, see watchtower log:
nextcloud and ttrss are started with a link to mariadb.
Unfortunately mariadb was stopped before nextcloud and ttrss were stopped.
At the starting, nexcloud and ttrss are started before maraidb was started.
root@workingmachine ~ # docker logs watchtower
time="2018-10-26T14:41:59+02:00" level=info msg="First run: 2018-10-26 14:46:59 +0200 CEST"
time="2018-10-26T14:47:06+02:00" level=info msg="Found new linuxserver/tt-rss:latest image (sha256:577e619a928c23c026cca6f789a9ea7df47ff425f47493db6e8eb9b0bfb834c3)"
time="2018-10-26T14:47:18+02:00" level=info msg="Found new nextcloud:14 image (sha256:dbcf87f7f2897ca0763ece1276172605bd18d00565f0b8a86ecfc2341e62a3f4)"
time="2018-10-26T14:47:28+02:00" level=info msg="Found new mariadb:10.2 image (sha256:16f756926078fa66ed64c0940ea4944e91d60b46483b28b241a28974dc3704b5)"
time="2018-10-26T14:47:28+02:00" level=info msg="Stopping /mariadb (a30ba4ff0115251b70c93f5c6ca008f83f6d569102fcf0b76c287ae69178bdc2) with SIGTERM"
time="2018-10-26T14:47:30+02:00" level=info msg="Stopping /nextcloud (bae15b97043a056386513dde4807014d185ff46f74d0727ff40c4ece0f771e59) with SIGTERM"
time="2018-10-26T14:47:31+02:00" level=info msg="Stopping /ttrss (60a5a066b7480f5a2e763151daba15b0099c02309abcc1271c4f1cebf3c02b05) with SIGTERM"
time="2018-10-26T14:47:35+02:00" level=info msg="Creating /ttrss"
time="2018-10-26T14:47:36+02:00" level=info msg="Removing image sha256:9724f106ac94d6ea7c542f138ac60069095d88bbb3550ad1a7b5d85e46b4c55b"
time="2018-10-26T14:47:36+02:00" level=info msg="Creating /nextcloud"
time="2018-10-26T14:47:37+02:00" level=info msg="Removing image sha256:a36a7b14ffa47969ed0fc002e54a1dd55e6ca7a8369cfb7cf43dc18f592b3a3f"
time="2018-10-26T14:47:40+02:00" level=info msg="Creating /mariadb"
time="2018-10-26T14:47:40+02:00" level=info msg="Removing image sha256:26ea4885da20491a5051470f1bc13ad691bfb8e7dda95eaf71eda0037a58d48b"

As docker links are considered deprecated, this isnt something I will prioritize. If someone would like to have a stab at providing a PR, I'd be happy to review it however.
Docker official documentation deprecation notice added as reference.


Duplicate/ Triplicate when refreshing the OUTGOING stock list.

Issue: After clicking STOCK OUT, No. of items are refreshed but in duplicate/triplicate. Need to click UPDATE first before next stock out.

[TEMP FIX] I disabled some of the auto-update functions. I knew there are a lot of things happening after clicking the stock out button, but the long-term solution requires more time. So, temp fix is to click update to refresh the empty list.


Installation

Hi,
I have been messing around with iodine just for fun, what i find to be weird is installation by default it should be installed user level change /usr to /usr/local I had to modify the scripts to get it to work.

Thanks for pointing this out, I fixed this in the most recent commit (The install scripts are kind of temporary, really, we just hacked those together for convince)


Login error in the example app

I can't log into the app. I create correct AgoraRtmClient with my app ID.
I log correctly once! and when i press logout i cant log again.
E/AGORA_SDK( 3302): cannot open log file for writing: agorartm.log, err=30
I/flutter ( 3302): Connection state changed: 2, reason: 1
I/flutter ( 3302): Login error: login failed errorCode:4
I/flutter ( 3302): Connection state changed: 1, reason: 3

https://docs.agora.io/cn/Real-time-Messaging/API Reference/RTM_java/interfaceio_1_1agora_1_1rtm_1_1_rtm_status_code_1_1_login_error.html#acca827c09a8cdda967cf19eca8f9474f
you can see the error code here. 4 means you are using an invalid appid

so why i once logged correcty without changing anything?

maybe you can show me your code indicating how you do logout/login

i just run example app: https://github.com/AgoraIO/Flutter-RTM/tree/master/example
only change i made is paste appid from agora console to _client = await  AgoraRtmClient.createInstance('pasted app id here');

@ejdrian313  have you turned on token feature for your appid? you may check this out in your dashboard project settings.

@Matrixbirds please help take a look

@ejdrian313 i just tried with my appid, i tried login/logout for several times an it's working fine for me.  maybe you can provide me sth more to clarify the issue?

no activity, reopen if the issue remains

am currently having this issue, the only thing i modifed in the example script provided was the APP_ID, yet am getting errors

am currently having this issue, the only thing i modifed in the example script provided was the APP_ID, yet am getting errors

@ejdrian313 i just tried with my appid, i tried login/logout for several times an it's working fine for me. maybe you can provide me sth more to clarify the issue?

how did you made yours working for you????

@ejdrian313 i just tried with my appid, i tried login/logout for several times an it's working fine for me. maybe you can provide me sth more to clarify the issue?

how did you made yours working for you????

@plutoless hello, I have some issues with this, when I logged in, I got errorcode:8 where that is the user alr login, but when I logged out, I got errorcode:102 that is for user not login? how I can fix it?


adding score rendering

fixed link error in takequiz.handlebars
adding rendering of scores in my scores

I also added bootstrap link

looks good to go!


Keep resulting swagger.json consistent

Keep the execution order of the specs so that the resulting swagger.json will be consistent.

makes sense - thx


west.yml: MCUboot synchronization from upstream

Update Zephyr fork of MCUboot to revision:
13767d0b72eb14ce42eb8aad1e5a133ef66afc54
Brings following Zephyr relevant fixes:

bootutil: Disable MCUBOOT_BOOT_MAX_ALIGN assert for
non-swap modes

Notes on process:

The MCUboot update from mcu-tools/mcuboot/main with the SHA used in west.yaml is already synchronized to zephyrproject-rtos/mcuboot/upstream-sync branch, and is available in the Zephyr fork of MCUboot.
The [DNM] on this PR should be kept until the PR passes all tests and is accepted.
Once the PR passes all tests and gets accepted, the upstream-sync branch should be fast-forward merged to zephyrproject-rtos/mcuboot/main branch and [DNM] should be removed.
After the main branch gets updated, this PR does not require further changes and should be merged as is.

CC @butok


Chrome Autofill does not trigger change

Version
2.5.3
Reproduction link
https://jsfiddle.net/n2kcp15b/
Steps to reproduce

open any form that has a textfield
auto complete it from chrome auto fill
check the attached v-model and see that it didn't update

What is expected?
update the v-model from what ever chrome autofilled
What is actually happening?
no update is happening

This only happens on Chrome on iOS (safari works fine). I also got reports it has the same issue on Chrome on Android but i didn't confirm.
This seems to be still an issue and i saw a few github issues that reported the same thing months ago but are now closed.

Currently the workaround i have is:
setInterval(() => {
  let value = $('#' + this.id).val();
  if(value != '' && this.value != value) {
    this.value = value;
  }
}, 50);

It works fine on Android, cannot test on iOS but there's a known issue with iOS Safari not emitting events when autocompleting, so, unfortunately, I'm not sure we can do something.
@VinceG There must be an event you can listen to instead of checking the value every 50ms, Maybe listening to the blur event will work

I don't think this is something we can fix at the framework level, because it's buggy behavior in one specific browser (not firing input events on autocomplete). A userland workaround seems to be the only way here - I'd suggest only adding the setInterval when you know you are in that specific browser, alternatively, perform the manual sync once before submitting.

Wrap elements in <form> to trigger OnChange event

This issue is not unique to Vue and other front end frameworks have tried to tackle this as well
The General Problem
According to this post on Detecting Browser Autofill from StackOverflow

The problem is autofill is handled differently by different browsers. Some dispatch the change event, some don't. So it is almost impossible to hook onto an event which is triggered when browser autocompletes an input field.
Change event trigger for different browsers:

For username / password fields:

Firefox 4 & IE 7  - don't dispatch the change event.
Safari 5 & Chrome 9 - do dispatch the change event.

For other form fields:

IE 7 - don't dispatch the change event.
Firefox 4 - does dispatch the change change event, but only when users select a value from a list of suggestions and tab out of the field.
Chrome 9 - does not dispatch the change event.
Safari 5 - does dispatch the change event.

Hack For WebKit browsers
According to the MDN docs for the  :-webkit-autofill CSS pseudo-class:

The :-webkit-autofill CSS pseudo-class matches when an element has its value autofilled by the browser

So, leveraging that property:

We can define a void transition css rule on the desired <input> element once it is :-webkit-autofilled. JS will then be able to hook onto the animationstart event.

Credit to the Klarna UI team for coming up with the solution here:
klarna/ui/Field/styles.scss:
:-webkit-autofill {
    /* Expose a hook for JavaScript when auto fill is shown. */
    /* JavaScript can capture 'animationstart' events */
    animation-name: onAutoFillStart;

    // Make the backgound color become yellow _really slowly_
    transition: background-color 50000s ease-in-out 0s;
 }

:not(:-webkit-autofill) {
    /* Expose a hook for JS onAutoFillCancel */
    /* JavaScript can capture 'animationstart' events */
    animation-name: onAutoFillCancel;
}

klarna/ui/Field/index.js:
this.refs.input.addEventListener('animationstart', (e) => {
  switch (e.animationName) {
    case defaultStyles.onAutoFillStart:
      return this.onAutoFillStart()

    case defaultStyles.onAutoFillCancel:
      return this.onAutoFillCancel()
  }
})

Outside of that, you're probably going to have to resort to polling for changes, since we can't guarantee an event will fire.
The library tbosch/autofill-event bills itself as "A polyfill to fire a change event when the browser auto fills form fields".

@KyleMit Thanks for the details explanation. It's a-shame that we still don't have a proper consistent API to work with across browsers.

You may add "name" attribute. It works for me in last Chrome

This trick works great, thanks!

You may add "name" attribute. It works for me in last Chrome ☮

It looks like all fields that can be autofiled should have "name" attribute

I have the same problem on Macos 10.13.3, chrome 70.0.3538.110.I find that just change when you click on any other non-input place, the change event will trigger, This seems to be triggered when the input's blur event fires.This is really weird.

You may add "name" attribute. It works for me in last Chrome ☮

This not works for me,I do form validation when the blur event fires. When the blur event is triggered for the first time，the model of username and password was empty string.

@rmaclean-ee You do not really understand what I mean，If you just click the login button to login, there is no problem.But if you bind blur event to the form field, when the blur event trigger you get the value, the value is empty, I think  that Chrome remembers the password  may be set the value to form fied when the blur event is trigger or after blur event is trigger.

I wasn't responding to your point on the nextTick, I was responding to the original requester about causes for it not filling in v-model.
As I said, making sure it is wrapped in a form tag solved my issue and my v-model is correctly filled in now without the need for any workarounds.

I know this issue is closed, but just for the sake of documentation and future Googles:
I'm having the same problem that @WormGirl detailed on Chrome 72.0.3626.121, MacOS 10.14.3. Clicking anywhere or calling something as simple as offsetHeight (from the console, can't seem to get this to work from inside a component consistently) causes a redraw and properly triggers the expected events.
Interestingly enough, calling foo.matches(':webkit-autofill') also returns false during this state, which means the entire JavaScript side of things is not being updated in general.
For reference, I have two inputs, email and password, and they both are wrapped in a <form> element and have name attributes. This doesn't make a difference as suggested by earlier comments.
I was able to get away with only CSS selectors (which work correctly), but this is definitely just a browser-specific bug.

I've faced similar problem with autofill and v-model usage in Chrome browser (Firefox is fine).
But my user-case is a little bit more specific.
I've been using v-model on VueComponent which passes its down to inner <input /> using :value="value" & @input binding. The problem which I've encountered is that autofilled value injected by chrome (without any events) is being overwritten by Vue's bindings (bug does not appear when used on plain <input /> with v-model).
The hack is instead of always binding value to <input /> use conditional binding:
<template>
   <input v-bind="{ /* any bindings you need */ ...valueBinding } @input="onInput" />
</template>
....
computed: {
  valueBinding() {
      /*
        Fix to Chrome autocomplete bug
        Autofilled value gets overriden by v-model or .sync binding
        So if value is null we just dont bind it
       and allow chrome to pass whatever it wants first
      */

      if (this.value) {
        b.value = this.value;
      }

      return b;
  }
}

It looks dirty, feels dirty and it is actually dirty. But it works for me and it took a lot of time to come up with solution. Hopes it will help somebody.

@PinkiNice  what is b? it's not defined (trying to fix my bug here )

bug of chrome, not vue.
remove those css bound to the value of input-element, as a nowaday solution
head>
	<title>自动填充与JS-Stack</title>
	<meta charset="utf-8">
</head>

<form method="get">
	<input id="username" name="username" placeholder="姓名" type="text" onchange="onChange(this)"/>
	<input id="password" name="password" placeholder="密码" type="password" onchange="onChange(this)"/>
	<input type="submit" value="Submit"/>
</form>

<script>
	var	username = document.getElementById('username');
	var	password = document.getElementById('password');
	function show(tag){
		console.log(tag, 'username=', username.value, '!');
		console.log(tag, 'password=', password.value, '!');
	}
	function onChange(input){
		//alert会切换focus
		//alert(input.name+" changed!");
		console.log('input:', input.name, '=', input.value);
		show('after change:');
	}

	show('step 1:');

	// focus切换触发JS-Stack运行
	if(false){
		username.onfocus = password.onfocus = window.onfocus=function(event){
			console.log("onfocus", event.target)
		}
		username.onblur = password.onblur = window.onblur=function(){
			console.log("onblur", event.target)
		}
	}

	// 通过定时器无法运行JS-Stack: autocomplete对应的focus|change|blur事件
	window.setTimeout(function(){
		show('step 2:');
		// window.setTimeout(function(){
		//	show('step 3:');
		//},1000);
	},1000);
</script>

It works fine on Android, cannot test on iOS but there's a known issue with iOS Safari not emitting events when autocompleting, so, unfortunately, I'm not sure we can do something.
@VinceG There must be an event you can listen to instead of checking the value every 50ms, Maybe listening to the blur event will work
I agree with you, I think it will trigger change when blur event is occurred
do something like this:

handleBlur ($evt) {
   this.$nextTick().then(() => {
       // The model here will get the autofilled value
   })
}

@yyx990803 why need this $nextTick()?

This is just like setTimeOut.

Based on facebook/react#1159, it looks like the input fields have the value before page load, so for vuetify (can easily be adapted for anything else), I added this code to my login dialog, and put refs on both text fields.
Typescript w/ vue-property-decorator:
@Component export default class extends Vue {
	username = "";
	password = "";

	@Ref() readonly usernameBox!: Vue;
	@Ref() readonly passwordBox!: Vue;

	mounted() {
		this.username = this.usernameBox.$el.querySelector("input")!.value;
		this.password = this.passwordBox.$el.querySelector("input")!.value;
	}
}

Vanilla JS:
export default {
	data: () => ({
		username: "",
		password: "",
	}),
	mounted() {
		this.username = this.$refs.usernameBox.$el.querySelector("input").value;
		this.password = this.$refs.passwordBox.$el.querySelector("input").value;
	}
}

The best way for me:
const input = this.$refs.input;
      this.autofilled = window.getComputedStyle(input, ':-webkit-autofill').animationName === 'onAutoFillStart';

Thanks, @Neoniklain. your comment piqued my interest in this topic again. The full solution requires a bit more code than your example provides, but it did give me just enough to find this SO answer which details the solution you're describing: https://stackoverflow.com/a/41530164/51021

This is old Chrome bug, I just open https://bugs.chromium.org/p/chromium/issues/detail?id=1166619 for it.

This is old Chrome bug, I just open https://bugs.chromium.org/p/chromium/issues/detail?id=1166619 for it.

Seemingly still an issue, and after trying every possible combination it seems specific to IOS's native keychain password management + chromium browsers. No other combination has the issue, not IOS with safari, not chrome on android, nothing.

Bug is still present.

With this code, it works on both Chrome and Safari for me:
<template>
  <input
    ref="input"
    :value="value"
    type="password"
    @input="onInput"
    @change="onInput"
  />
</template>

<script lang="ts" setup>
import { ref } from 'vue';

const value = ref<string | null>(null);

function onInput(e: Event) {
  // We should also fire this at the `@change` event on the input.
  // Because `@input` does not always gets triggered when autofilling.
  // This happens for example on iOS Safari when autofilling credentials from the keychain.

  if (e.target instanceof HTMLInputElement && e.target.value) {
    value.value = e.target.value;
  } else {
    value.value = '';
  }
}
</script>

It combines the following:

a workaround for the "composing input" problem on the v-model (https://github.com/vuejs/vue/pull/9814). (:value and @input instead of v-model)
and adding a seemingly redundant @change event listener. Because apparently, the input event does not always get triggered when the value got autofilled.

Bug is still present.

It is. Why is this closed?

Bug is still present.

It is. Why is this closed?

My understanding is that it was closed because it's an issue with the browser, not Vue, and that it likely won't get solved because there are security implications that come with exposing auto-filled login details to JS

because there are security implications that come with exposing auto-filled login details to JS

I'm curious what made you come to that conclusion. Because if you don't have access to the auto-filled value, how are you going to send it to the server? Sooner or later you will have to read the value in JS

It's not that you never get the value. It's that it doesn't show up right away. I haven't run into this issue in a while so my memory is a little foggy, but if I remember correctly, the value is postponed until the user interacts with the page. If the user, for example, clicks the submit button, then the value is populated and the click event is fired in quick succession.
I'm not at my computer right now though, so try it before taking my word for it. I don't remember there being anything functionally wrong when I came across this; the issue for me was that I was using material design, and the name of the textbook was overlapping the value until the user clicked "Login" since the event was postponed. It was just a design issue.

Some people indeed report that "interacting with the page" is enough for onChange/onInput to be triggered, but that's not what we observed (on Firefox - Chrome seems to work fine).

Ok. This isn't an issue with Vue though; if you register the event handler yourself you'll get the same result. The issue lies within Firefox. I believe someone here opened a bug report on their tracker. Try checking there and see if anyone has offered a solution or status update.

just wanted to share really cool and slicky solution [https://stackoverflow.com/a/73633659/24207152]
compliments to [https://stackoverflow.com/users/3276256/3rdsenna]
att. @WormGirl


How to run webdriver parallel in Selenium Grid

What are you trying to achieve? (Expected behavior)
Example I have an array of urls
$urls = [
    'http://google.com',
    'http://facebook.com',
];

I'm be able to setup the Hub and Node through Docker. How can I perform my task parallel instead of one by one in a loop?
foreach($urls as $url) {
    $driver->get($url);
}

Php-webdriver version: latest
PHP version: 7.1

Hi, PHP is by default single-threaded.
If you want parallelism, you can for example leverage React PHP and encapsulate the request to promises: https://reactphp.org/ (but each request would have to have its own $driver instance, otherwise you would control the same browser window).
And If you want parallel execution of your test, have a look eg. on https://github.com/lmc-eu/steward /


Add Code of Conduct policy

As a contributor, I would like a Code of Conduct posted so that I know that contributors to this project are held to standard of behavior.
Acceptance Criteria:
[ ] I know this is complete when a markdown file is posted within the repository.

Fixed by #6


Remove unused loggers from history

What changed?

Why?

How did you test it?

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 9fc7235a-d40d-424b-870f-47b15851bcb5

9 of 9 (100.0%)  changed or added relevant lines in 5 files are covered.
68 unchanged lines in 12 files lost coverage.
Overall coverage decreased (-0.01%) to 56.943%

Files with Coverage Reduction
New Missed Lines
%

service/history/execution/mutable_state_task_refresher.go
1
73.42%

service/history/queue/timer_queue_processor_base.go
1
77.92%

common/membership/hashring.go
2
83.54%

common/peerprovider/ringpopprovider/config.go
2
81.58%

common/task/weightedRoundRobinTaskScheduler.go
2
89.12%

common/util.go
2
51.17%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
3
55.49%

common/task/fifoTaskScheduler.go
3
84.54%

common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go
8
77.95%

common/persistence/nosql/nosqlplugin/cassandra/tasks.go
14
72.8%

Totals

Change from base Build 8d87d80f-afd1-43e9-ba9d-8f82a47525d8:
-0.01%

Covered Lines:
83959

Relevant Lines:
147445

💛  - Coveralls


Update documentation and Change setting docker host.

Purpose

Fixes https://github.com/ballerinax/docker/issues/210. Use DOCKER_HOST by default, else get host depending on the OS. This can be overriden by the @docker:Config{} annotation.

Goals

Updated documentation.

Codecov Report

Merging #214 into master will increase coverage by 0.75%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
+ Coverage      64.7%   65.46%   +0.75%
  Complexity      116      116
============================================
  Files            14       14
  Lines           561      553       -8
  Branches         56       53       -3
============================================
- Hits            363      362       -1
+ Misses          168      165       -3
+ Partials         30       26       -4

Impacted Files
Coverage Δ
Complexity Δ

...g/ballerinax/docker/DockerAnnotationProcessor.java
81.19% <ø> (+2.33%)
18 <0> (ø)
:arrow_down:

...allerinax/docker/generator/models/DockerModel.java
80.55% <100%> (+4.87%)
31 <0> (+1)
:arrow_up:

...org/ballerinax/docker/utils/DockerPluginUtils.java
38.88% <0%> (-2.78%)
6% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81416b7...aa4324f. Read the comment docs.


The first thing that was that the one

The first thing you can say was

One thing is I

The first thing that I was


Upgrade from v1.12.3 to v1.14.4 leads to more CPU usage without traffic

Description:
While trying to upgrade to latest version of envoy, we faced the problem (maybe) - envoy started to consume 1.5x more cpu (from 7-9% cpu to 12-20%) when there are no traffic to this particular envoy instance. Also, cpu usage graph now have way more spikes than it had before(previously it looked like a flat line - now it is full of spikes).
We have our own control plane and our bootstrap config looks like this:
node:
  cluster: private-cluster

admin:
  access_log_path: /var/log/envoy/admin_access.log
  address:
    socket_address: { address: <IP_ADDRESS>, port_value: 9901 }

stats_flush_interval: 120s

dynamic_resources:
  lds_config: {ads: {}}
  cds_config: {ads: {}}
  ads_config:
    api_type: GRPC
    grpc_services:
      envoy_grpc:
        cluster_name: xds_cluster

static_resources:
  clusters:
  - name: xds_cluster
    connect_timeout: 1s
    type: STRICT_DNS
    lb_policy: RANDOM
    http2_protocol_options: {}
    upstream_connection_options:
      tcp_keepalive:
        keepalive_time: 300
        keepalive_interval: 10
    load_assignment:
      cluster_name: xds_cluster
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: private-address
                port_value: 8080

we have quite a lot of routes/clusters/clusterLoadAssignments there which change quite often, though in this particular case number of changes is not that big - change every 20-300 seconds, but they are still present. Full config dump after initialization is about 6mb.
Doing CPU profiling gives me something like this:

We don't use envoy's healthchecking/rate limiting/etc - I am not sure whether their appearance in cpu profile says anything, but it bothers me a bit. Also, "__ZNSt3__1L20__throw_length_errorEPKc" looks strange.
Full profile of 10 minutes of time is here: envoy.1.14.prof.zip

I'm pretty skeptical of these symbols. Can you get a trace with a binary with debug symbols?

I forgot to mention that I also have a custom envoy (we use some of internal plugins). Currently I build envoy with ci/do_ci.sh bazel.release.server_only and take binary from build_release_stripped dir. Should I build it differently, ie: bazel.debug.server_only? or something else

If you are stripping the symbols you have to actually make sure perf, etc. can find them, or just don't strip.

I just reused https://github.com/envoyproxy/envoy/blob/master/ci/Dockerfile-envoy, which uses stripped dir, I guess, I need to use build_release dir instead. Will update, thanks.

btw, are there any performance downsides about using stripped/non-stripped binaries? ie: slower startup due to ~1gb envoy binary size/etc?

No, no downsides other than increased disk cost, transfer, etc.

@fxposter Those are just mangled symbol regardless whether you have debug symbols or not. For example
echo _ZNSt3__1L20__throw_length_errorEPKc | c++filt
std::__1::__throw_length_error(char const*)

pprof should be able to demangle it with --symbols flag though

Hm, while running with the non-stripped binary - at the end I get the same flamegraph/top with same symbols :(

@lizan yes, I tried c++filt, flamegraph stacktraces are still quite weird though :(

Regarding "--symbols" - are you talking about https://github.com/google/pprof? Don't see such option there.

BTW, the screenshots are taken from pprof that was ran on mac os x, while envoys were running in docker on linux machines.

To this point

I collect .prof file by running /cpuprofiler?enable=y and /cpuprofiler?enable=n
Even with release (but non-stripped) version of envoy when I try running pprof in docker with the same image where it was collected - I get this

pprof -text /usr/local/bin/envoy /data/envoy.1.14.stats.prof
Some binary filenames not available. Symbolization may be incomplete.
Try setting PPROF_BINARY_PATH to the search path for local binaries.
File: envoy
Type: cpu
Showing nodes accounting for 16.03s, 99.63% of 16.09s total
Dropped 2 nodes (cum <= 0.08s)
      flat  flat%   sum%        cum   cum%
    13.30s 82.66% 82.66%     15.99s 99.38%  [envoy]
     1.43s  8.89% 91.55%     14.60s 90.74%  [libc-2.23.so]
     1.30s  8.08% 99.63%      2.85s 17.71%  [libpthread-2.23.so]

When running pprof on mac os (without specifying the binary) - it shows mangled names

Managed to get proper data:

CPU usage spikes look like:

I suspect code that applies new envoy configurations coming from control plane now takes much more time than it was before.

Aside from that, looking at the pprof, it seems the VersionConverter is the source of CPU usage. I believe it's because your control plane is sending Envoy v2 config instead of v3, so Envoy will convert it to v3 internally. The v3 API took in place since 1.13. If your control plane send v3 protos, I think it will be down closer to the original CPU usage.
cc @htuch

@lizan yes, that's right to the extent that is the source of the extra CPU usage. This is tracked in https://github.com/envoyproxy/envoy/issues/10875. Since 1.14 I think we've reduced the overhead from 3.6x down to 2x for v2 ingest vs. v3. So, you might see a real improvement by moving to HEAD @ master. Otherwise, I suggest moving to v3.

Should it be v3  "all-in", ie: if I just start returning v3 resources while keeping all envoy configs the same (we don't specify it and hence use default AUTO resource version) - it will still be subject to extra CPU usage? ie: in this case control plane will receive request for V2 resource, it will respond with v3 one, envoy will parse it as v3 and convert to v2?

cause by just switching to sending v3 resources does not seem like it's helping with CPU usage

If you send all your resources as v3, there should be no conversion happening in Envoy at all; you should not see VersionConverter in the CPU profile. You need to set V3 in the resource version explicitly to make this happen.

I mean - I changed my control plane (based on go-control-plane) to still using cache/v2 and server/v2 from the library and register API from discovery/v2 (we use ADS). According to docs - I can do that and envoy will accept v3 resources from v2 APIs. But when I do config_dump afterwards - I see that under, for example, type.googleapis.com/envoy.admin.v3.ClustersConfigDump there are type.googleapis.com/envoy.api.v2.Cluster resources still, while I think I send v3 resources already

Envoy can accept v2 APIs and convert internally to v3. The point above is that if you want performance, you need to put v3 resource on the wire at the control plane, so Envoy doesn't need to do the work of converting.

Yes, I got that. My question is different. If I send v3 resources on the wire (ie: actual v3 resources are marshaled on the control plane side), but lds/cds/rds references in envoy's config will still be auto (ie: envoy will ask v2 resources from control plane, but will receive v3 resources back on the wire) - is that enough or not to not do conversion all the time?
Cause that's what I did and it seems like envoy treats them as v2, though go-control-plane sends v3.

I think you probably need to change resource versions to v3, otherwise I don't see how it works given https://github.com/envoyproxy/envoy/issues/10776

this one is for purely v3, cpu graph still has spikes
Now I suspect this part :)

Will generate graph for v1.12 with v2 (which was flat in terms of CPU usage) and compare

CC @jmarantz for stats overheads.

Thanks for the heads up. Looks like RDS is re-creating a lot of stats on every update?
I suspect this code could be optimized a bit:
  for (const auto& virtual_cluster : virtual_host.virtual_clusters()) {
    virtual_clusters_.push_back(
        VirtualClusterEntry(virtual_cluster, stat_name_pool_, *vcluster_scope_));
  }

in source/common/router/config_impl.cc function VirtualHostImpl::VirtualHostImpl. I think it's re-creating the same exact block of stats for every virtual cluster in every virtual host.
Not sure of the cardinality of this in general, or for @fxposter's config in particular. Does anyone have more context around this code path?

Our config may be quite different from others. yes - we have infrequent (once a couple of minutes) updates of clusters and each cluster have separate path in same domain in routeconfiguration (or our control plane is a bit broken at this point, this is separate cluster where I was playing with new envoy version - changing envoy configs/versions/control plane code). but with the same control plane envoy 1.12 uses less cpu and is more stable in terms of CPU usage.

Oh, and the last flame graph looks like regexes in particular, but I don't think there's been a change in that area of stats recently, and that may be a side effect of wasteful re-creation of the same stats.
On Thu, Jul 16, 2020 at 3:15 PM Pavel<EMAIL_ADDRESS>wrote:

This one is from 1.12, overall structure is the same, but sample time for
1.14 is 10seconds, while for 1.12 it is 3 seconds
[image: image]
https://user-images.githubusercontent.com/109216/87712617-99b2eb80-c7b1-11ea-9c2e-b1c3e957bc8a.png
CPU usage (blue and green are 1.14, red is 1.12)
[image: image]
https://user-images.githubusercontent.com/109216/87712717-c535d600-c7b1-11ea-9fd1-b833e4bdb042.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/issues/12080#issuecomment-659615597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAO2IPNXHPFFI35IOUEZEBDR35GVPANCNFSM4OZ5AAMA
.

in this case - no, but sending same configs result in this behaviour. in this case I send v3 resources instead of v2 (it doesn't matter much - situation is the same in both cases), but content of resources is same

In my recent experiences, translating between API versions during xDS updates has been a significant bottleneck. So from a functional perspective you may be right but I am skeptical that it is a no-op for perf.
Having said that it does look like there's some potential perf improvements, having looked at the code. This will become actionable if we have a testcase to repro though, otherwise we kind of shooting in the dark.

After re-checking what is actually in rds/cds - I would say the pattern is to add and remove 2-5 clusters and corresponding routes each 2-10 minutes. 2 resources in RDS (egress/ingress) and path and domain-based mappings for each cluster (ie: for each cluster there is a separate domain and a separate mapping within some single domain).
Overall number of clusters is ~1500 (and ~3000 corresponding routes).

May we please have the stale tag removed? I'm curious to know more about the increased CPU utilization that still occurred after the v3 upgrade.
Regarding the v3 upgrade, it would seem there's not much that can be done other than to upgrade as soon as possible. Was this called out in the v14 release notes or documentation? At quick glance, I don't see mention of it & this does seem to be a well-known "issue"

Regarding the v3 upgrade, it would seem there's not much that can be done other than to upgrade as soon as possible. Was this called out in the v14 release notes or documentation? At quick glance, I don't see mention of it & this does seem to be a well-known "issue"

Probably not, doc updates appreciated. It is a "known issue" at this point. And yes, I would upgrade to v3 as soon as you are able. I don't think there is anything else actionable on this issue unfortunately. @htuch has done a bunch of recent changes to improve v2 -> v3 upgrade perf fwiw.

Tagging for https://github.com/envoyproxy/envoy/issues/10943 postmortem; I don't think we had clear evidence that performance was problematic at the time of the release, most discussion has taken place since then, but worth keeping in mind for the future.

I will provide a sample control plane this week.

https://gist.github.com/fxposter/8887788a575090601ba6b106e80e3230
this is the go-control-plane that shows the effect of that. when changing only paths under some wildcard domain - it consumes less cpu, when constantly adding/removing domains in routes - all those metric generation starts to consume much more CPU. This was not the case for 1.12.

and looking at graphs above - it seems that quite a lot of time is spent in Envoy::Stats::TagProducerImpl::produceTags/etc.


Support Stored Procedure for Sharding-Proxy IF not sharding

Feature Request
For English only, other languages will not accept.
Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot make decision by current information, we will close it.
Please answer these questions before submitting your issue. Thanks!
Is your feature request related to a problem?
No.
Describe the feature you would like.

CREATE PROCEDURE and CREATE FUNCTION Syntax both supported. Here are the test cases:
For CREATE PROCEDURE:
delimiter $$
CREATE PROCEDURE insert_procedure()
BEGIN
        insert into t_order (order_id, user_id, status) values (123, 123, "123");
        insert into t_order (order_id, user_id, status) values (456, 456, "456");
END$$
delimiter;
call insert_procedure();

For CREATE FUNCTION:
DELIMITER $$
CREATE FUNCTION hello ( ) RETURNS VARCHAR ( 255 )
BEGIN
        RETURN 'Hello  world!';
END $$DELIMITER;
SELECT hello ();


shared-mime-info: split outputs

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Mhm is it really worth it to split the package for one manpage?
╰─ % wc -c ./result/share/man/man1/update-mime-database.1.gz
780 ./result/share/man/man1/update-mime-database.1.gz

I could not find dev output

That is the only dev output next to mpv I have in my home-manager profile.
 result-dev ⇒ /nix/store/wi8493arxarx96spsmz4ra9br06g5z8s-shared-mime-info-2.1-dev
├──  nix-support
│  └──  propagated-build-inputs
└──  share
└──  pkgconfig
└──  shared-mime-info.pc
 result-man ⇒ /nix/store/0pf295vcg2fvamqlc1m981ph38qd0v1j-shared-mime-info-2.1-man
└──  share
└──  man
└──  man1
└──  update-mime-database.1.gz

I tried building plasma5Packages.kio which failed at building gpgme because some none utf-8 got send over the remote protocol. Should be fixed in the next nixUnstable version.


Migrate TS typings to DefinitelyTyped

For 4.0 and beyond, we've decided to move styled-components typings out of this repo to https://github.com/DefinitelyTyped/DefinitelyTyped. This aligns with our strategy on Flow: to allow the community to type the library at their own pace elsewhere.
Anyone who's interested in doing this is welcome to start immediately.

cc @styled-components/typers

I will move it over.

Awesome, thank you @Igorbek 🙇

Can I ask the reason for this?
In the TypeScript community, having type definition in the main repository is a good practice. There are plenty of reasons, if listing some:

Having type definition in a repository makes it much easier to sync versions between code and types.
DefinitelyTyped is a huge monorepo and somewhat difficult to access. Also, because it's not owned by styled-components, we lose flexibility to change how we maintain it. For example, it enforces a specific way to provide tests, etc. It's difficult to review too.
Having type definitions in styled-components makes contributors willing to contribute more, because it makes them feel like contributing to styled-components itself, instead of DefinitelyTyped.
Having type definition in a repository is also helpful when using plain JavaScript too. Tools like VS Code provides autocompletion and type information even with plain JS when there is typing in a package.

I can't actually come up with a good reason to separating the definition but for maintenance reason. If maintenance is an issue, I (and other typers) are quite familiar with TypeScript and can always help you with it from now.
In conclusion, can we please revise this?

So first, let me say that this decision wasn't made lightly. It's been discussed off and on over several months between @mxstbr, @kitten, and I.
The reality is none of the core team makes extensive use of the TS ecosystem. Thankfully, there are a few dedicated members of the s-c community that are willing to pitch in to handle typing-related issues, @Igorbek for example, but this is all volunteer time and he may not always be available.
We receive a massive amount of issues, PRs, and such on TS typings weekly. So many that constantly triaging them hinders our ability to focus on actually improving the library. Moving the TS typings to a community location ends up being the most pragmatic decision to ensure that our time is not being scuttled on things for which we don't have enough context.
I realize this may not be a popular choice, but it's the right one for styled-components and will allow you, members of the TS community, to upgrade and use the latest functionality without waiting on us. If you are concerned about the community typings falling behind forthcoming library changes, we will have a beta period and thoroughly communicate things ahead of time so people can prepare.
Thank you for your understanding.

I really appreciate your detailed comment. I understand that handling TS issues and pull requests in the same repo becomes a burden for maintainers.
I think if it's the reason, we can try a different approach? For example, we can separate types to its own repository, let's say styled-components/types, and download the type definition file only on npm publish of styled-component. We can just use curl for the download, don't need a git submodule. I think it is just another possible solution, it isn't a very common practice though.
I understand that the final decision is up to the core team and I will completely respect the decision.

let's say styled-components/types, and download the type definition file only on npm publish of styled-component

The problem with this strategy is there is no semver protection for the types. It would be super easy to accidentally release a breaking type change with an otherwise minor library release.
Also, part of the reasoning for DefinitelyTyped is they own the @types scope which seems to be the de-facto place to look for types in the TS ecosystem. It just makes sense to put them there and expands the number of people that could potentially chip in to maintain them exponentially.

I know it's been a month, but I was just linked to this and I want to elaborate on our position.
As a member of the TypeScript team, I think this was the right move. Types that are not generated directly from .ts files should typically be put on DefinitelyTyped.
Thanks @Igorbek and others in @styled-components/typers who've helped out with the types in this project (even though I don't use it myself - I'm not a front-end dev :wink:).
The reality is that pinning the responsibility of .d.ts maintenance on library authors puts too much burden on them, whereas DefinitelyTyped provides an opportunity to

get some level of oversight from the TypeScript team
get more wide review from peers
easily use testing infrastructure like dtslint
easily test against other packages on DefinitelyTyped that reference this package
decouple versioning of the package with the .d.ts files, allowing .d.ts fixes to be shipped without a package publish.

So I would say this was a reasonable move.

To address some points:

Having type definition in a repository makes it much easier to sync versions between code and types.

This really depends on how you communicate with the community and how much patience a maintainer has.

DefinitelyTyped is a huge monorepo and somewhat difficult to access. Also, because it's not owned by styled-components, we lose flexibility to change how we maintain it. For example, DefinitelyTyped enforces a specific way to provide tests, etc.

The monorepo is problematic for new contributors, but if you have ideas for better testing strategies, we're interested.

In DefinitelyTyped, it's much more difficult to track issues and review pull requests. There are 2000+ open issues and 100+ open pull requests. There is no way to track a specific directory or keyword in GitHub, so contributors are likely to stop tracking them.

We're not sure how to manage issues, but pull requests are above 100 because of the influx. Right now they're at 50, not all of which are actually actionable.

Having type definition in a repository is also helpful when using plain JavaScript. Tools like VS Code provides autocompletion and type information even with plain JS when there is typing in a package.

VS and VS Code both provide what's called "automatic type acquisition", so JS users get the types either way.

@DanielRosenwasser  Thanks for your comment. I didn't know about VS Code type acquisition. It's great.
It may be just my personal experience, but I found that types in DefinitelyTyped are more likely to be out of sync, than ones installed with JS packages. As you mentioned, I guess, new contributors are more willing to contribute when it's in the main repo.
However, I understand maintaining type definitions is a burden and moving it to DefinitelyTyped reduces the burden. I respect the decision of maintainers and believe it's the right move.

So the types won't be fixed until they are moved to a separate repository? When will that take place? Does it have to wait for the 4.0 release?

No, they can be moved at any time. Someone just has to do it.

As we are using s-c with TS at our company I feel I could help out, but it would be my kinda first bigger contribution so I want to make sure what is to be done ;)

PR to https://github.com/DefinitelyTyped/DefinitelyTyped/ - with types from styled-copmponents in proper DefinitelyTyped structure.
PR to s-c removing the types
PR to styled-components-website - I'm deducting this from your recent tweet

Should i be aware of any other problems with this?
I was thinking about it and I'm concerned about two things:

Coordinating the release cycle of s-c and DefinitelyTyped - to make sure types won't get missing in any release.
Dependencies - e.g. styled-system and their typings maybe?

That looks right to me @AllainPL!

Coordinating the release cycle of s-c and DefinitelyTyped - to make sure types won't get missing in any release.

For major releases, there will be a beta period to accommodate this sort of thing. Is making an issue against DT with the relevant API changes the right way to go or to make an issue here and tag people to update flowtyped and DT?

Dependencies - e.g. styled-system and their typings maybe?

IDK, I think that's up to the individual lib authors

I actually thought that it'd be started from 4.0.

I actually thought that it'd be started from 4.0.

Yeah but I don't think there will be another minor release before 4.0 at this point. The global style thing is taking too long.

@probablyup looks like you did the heavy lifting ;) - I was too slow ;(
I checked the version of s-c from #1922 with emulated types/styled-components package against my project and everything looks fine.

@AllainPL thanks much for testing it out!

The migration is complete. Please file any future TypeScript related issues there.
Thanks all.

@utatti I think if the project isn't written in TS, it actually a good thing that the types move to DefinitelyTyped (The TS community).
Just look at immutable.JS that has outdated types and the maintainers refuse to fix types of old version (which is still the latest!) so it won't publish new versions of the lib. If it was by the community, both Flow and TS users would enjoy much better types. Not mention you need to manually remove a line in the definitions of Flow to make it work with a new versions of Flow

I've got some v4 typings nearly done, but for some reason the tests are failing as the styling callback props are getting typed as any. Could anyone take a look at my changes and see if they can see whats up?
https://github.com/DefinitelyTyped/DefinitelyTyped/commit/ba75fbf6d5ae5978479912ab92b1e50fc30afb42

@Igorbek could you help out? ^


How to synchronize playback bag files based on multiple camera in Unity?

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win10

Platform
PC

SDK Version
2.24.0

Language
C#/Unity

Segment
Medical

Issue Description
I try to record video using 3 camera in Unity and it looks working well while streaming.
However recorded 3 video are not synchronized when I playback them.

How to synchronized recording based on multiple camera in Unity?

I find related closed issue (https://github.com/IntelRealSense/librealsense/issues/1810)
Can I get timestamp of bag files using C# or RealSense SDK for Unity?

I realize that I should modify or replace rsDevice prefab for sync multiple bag videos.

I used seek function which is member of playbackDevice class.
However I can't sync playback within 200ms because record timing differ each bag file.
I want to sync playback within 100 ms based on 15 fps bag files.

Anyway I roughly synchronized 3 bag files in unity, So I close this issue.


Push Notification in China

I have build my cross platform mobile application using Flutter and integrated push notifications also using FCM but since Google Services are blocked in China the chinese users are not getting any push notifications.
I have searched a little and found pushy as the best solution for push notification in China but seems like flutter doesn't support pushy integration yet now. So can we you please integrate pushy or any other service for enabling the push notifications in China.
Thanks!

Closing as dup of #13328

@surbhitydy We have just released official support for Flutter! 😄
https://pushy.me/docs/additional-platforms/flutter
As you mentioned, you can use Pushy to deliver notifications reliably in China without relying on Google services.


add settings modal

take out "reset to default" and the "by x y z" from the binding screen and move it into a separate modal with these things, options to change keyboard layouts, and potentially other options!?! wild

Not too sure; it seems more natural for the existing modal to function as a settings modal, too. This is at risk of overcomplicating the UI, while also providing a service I don't find valuable? And if there is a need to add so many functions that the existing modal isn't sufficient, just put the bindings behind their own page within the settings modal (if i phrased this poorly let me know); most people won't touch them more than once anyways.

on the contrary, in my experience people look at the bindings a lot when starting out, so having it front feels important
this overcomplicates the ui, but potentially shrinks the bindings modal again (which may or may not be good, who knows)

so having it front feels important

this can be the case concurrently with a paned layout; they're not mutually exclusive. Here's a mock: https://pihart.github.io/qboard/?json=mocks/paned-settings-modal-158.1.json

The bottommost tab should let people edit the raw JSON qboard configuration.
This is better than opening developer tools (slow, not possible for most on mobile) reading localStorage, parsing, editing, serializing, rewriting (also, this is nontrivial if there are multiple properties to write), finding the commands to force the live qboard to recognize the changes, and closing developer tools.


adding redirect rules to prevent google links from reaching page not …

…found
Signed-off-by: Chance Whittaker<EMAIL_ADDRESS>Currently some links from Google, such as https://docs.cert-manager.io/en/release-0.11/ would route to https://cert-manager.io/docs/en/release-0.11/ which would take the browser to a 404 page not found (see screenshot)

This change should ensure that these links are at least routed back to the specific release-note page that was referenced in the link. This is not a full solution to the problem just an improvement on the current situation.

CC @mattbates for visibility

Three commits:

Adding more specific redirect rules to mitigate 404 errors
Updating outdated links in content
Adding specific links from outside sources (https://www.fairwinds.com/blog/upgrade-cert-manager-its-worth-it) that needed to be redirected and applying contextual comments

Happy to review this once the conflicts have been resolved :+1:


AWS SQS/CloudWatch Scaler - Instance Profile On Keda Deployment

The current behaviour of the AWS SQS/CloudWatch scaler is that it looks for AWS environment variables on the deployment you are trying to scale, and if they are not found, it throws an error.
It would be good for this to not throw an error and to allow the go AWS library to attempt to load credentials in a usual way (using the default credential chain) and to search the environment variables on the keda deployment, as well as attempting to retrieve instance profiles.
When applying instance profiles to nodes (or to containers using kube2iam) this could be really handy and would allow you to scale jobs on based on sqs queues and cloudwatch metrics with the scaler only ever requiring read only credentials.
Using the default chain for AWS also makes things more secure in the fact that no aws secrets need to be created or stored in kubernetes.

@jralph was this issue fixed for you? I am running into the same exact issue and I'm looking at the PR now and I'm not sure this addresses the instance profile arn case. It seems like it still expects the environment variables to be set which shouldn't be necessary with instance profile arns.


Typo in README.md

At https://github.com/uhppoted/uhppoted-app-wild-apricot/blob/master/README.md#credentialsjson
Documentation states wild apricot account id is stored under account, when the code is actually looking for account-id
Command fails with ambiguous message:
Error getting contact list (403 The specified account cannot be accessed with the credentials provided.)
https://github.com/uhppoted/uhppoted-app-wild-apricot/blob/master/commands/credentials.go#L10

Thanks for the heads up! I've:

corrected the typo in the documentation
added some validation to the credentials to make identifying this problem simpler

re. ambiguous message. Unfortunately the particular call to Wild Apricot that generates this error can fail for a number of reasons - listing the operation and the error returned from Wild Apricot seems to be the most viable option. Am open to suggestions though.

Fixed in release v0.6.12


Update and rename policy-documents.md.md to policy-documents.md

doesn´t seem relevant any more -- closing


Test: get place list

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+22.1%) to 69.697%

Totals

Change from base Build<PHONE_NUMBER>:
22.1%

Covered Lines:
100

Relevant Lines:
131

💛  - Coveralls


[Feature Request] Option to (hold) Ctrl + Hover

Adding the option to show HoverEdit (unpinned) after Ctrl Hovering instead of just time delay. I think it was much better that way.

This is the way it currently works. Whether or not you need to hold the modifier key is managed within the settings of the core plugin "Page Preview"

This is the way it currently works. Whether or not you need to hold the modifier key is managed within the settings of the core plugin "Page Preview"

But this plugin take over that control, it is fine when I disable hover edit. I don't want a timer to trigger the hover, I want to use control for that. I think the control used in core obsidian shows that it is more convenient to use Ctrl rather than setting a timer for many people. It can be an option. I hope you consider it later if there is not a major technical difficulty to implement it.
thanks

Please add this option sooner, I really miss Ctrl + Hover open of original obsidian. The setting is already there you should just use it (using "open hover after x seconds" only when Ctrl + Hover option is not active).
Thank you very much for effort


new-theme Abridge

I have been building this theme in my spare time over the last couple weeks.
It is a responsive lightweight blog theme, using semantic html and no javascript. (the search may end up being the only thing that requires javascript.)
I spent most of the time reading the documentation and learning from what other themes have done.
theme: https://github.com/Jieiku/abridge
demo: https://jieiku.github.io/abridge-demo/
I had some trouble figuring out how to add my theme to this repo, these are the steps I used:
fork https://github.com/getzola/themes
git clone https://github.com/Jieiku/themes
cd themes
git branch new-theme
git checkout new-theme
git submodule add https://github.com/Jieiku/abridge abridge
git commit -am "new-theme"
git push --set-upstream origin new-theme

Then create the pull request.

Thanks!


fine-tune validation scripts

yet another iteration of fine-tuning of the validation scripts

This change is

LGTM


RegexFeaturizer is not case-insensitive

RegexFeaturizer with regex patterns and lookup tables do not work as case-insensitive.
https://github.com/RasaHQ/rasa/blob/master/rasa/nlu/featurizers/sparse_featurizer/regex_featurizer.py#L111
In the documentation, it is said that lookup tables work as case-insensitive.
https://rasa.com/docs/rasa/nlu/training-data-format/#lookup-tables
A simple re.I flag will be enough to achieve case-insensitive regex patterns.

Sorry, my mistake.
https://github.com/RasaHQ/rasa/blob/master/rasa/nlu/featurizers/sparse_featurizer/regex_featurizer.py#L174
Lookup tables are created with case insensitive match.


Sequence encoding constants need to be updated for SBOL 3

The sequence encoding constants SBOL_IUPAC_DNA and similar need to be updated for SBOL3.
They currently have the values from SBOL 2.
Their proper values can be found in Table 1

The sequence encoding constants SBOL_IUPAC_DNA and similar match the SBOL 3.0 specification.
These constants do not match the as yet unreleased 3.0.1 specification, which chose to change them, making them seem less "constant".

This was a change that was scheduled for 3.0 in March of 2019, per https://github.com/SynBioDex/SBOL-specification/issues/10 and https://github.com/SynBioDex/SBOL-specification/issues/191
The table unfortunately wasn't correctly updated, and thus the fix.

Three of the SBOL3 test suite examples will need updating as well:

https://github.com/SynBioDex/SBOLTestSuite/tree/master/SBOL3/BBa_F2620_PoPSReceiver
https://github.com/SynBioDex/SBOLTestSuite/tree/master/SBOL3/multicellular
https://github.com/SynBioDex/SBOLTestSuite/tree/master/SBOL3/toggle_switch


Example the use of frame buffers in websocket stream state

It seems we need both rd_.fb and wr_.fb for the case where ping_op and read_some_op are both active, all code which uses the control frame buffer needs an audit.

Done


Create irpct.txt

Add IRPC Technology College

@piseth14 irpct.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!