Severe performance degradation opening large folders in latest release

VSCode Version: 1.37.1
OS Version: Windows 7

I regularly have Code open to a workspace with a large number of files in a single folder ( >20k files). I've never really had a problem with that until the latest release of 1.37.1, where I experience severe lagginess in every element of Code UI, especially text response in editor windows and terminal. This occurs even when Explorer sidebar is not visible. CPU usage shows Code using a large percentage of CPU. Previous version 1.37 seemed ok (but not great) for the day or two I had it, and I definitely know 1.36 builds worked just fine for this case. This issue occurs with extensions disabled (it's pretty much impossible to run with extensions at all in this state).
Steps to Reproduce:

Open a folder workspace with a large amount of files. Explorer sidebar does not need to be open.
Observe laggy UI performance, laggy typing in text windows, especially a terminal window. The performance will sometimes improve briefly, before degrading again after performing any action.

Does this issue occur when all extensions are disabled?: Yes

/needsMoreInfo - please review https://github.com/Microsoft/vscode/wiki/Performance-Issues and post the additional info it suggests gathering.

Here's the performance issue reporter data, and attaching the both the Javscript profiler data and Performance profiler data of me typing into a terminal while a folder with 20k files is open (where it has >2s typing lag)
CPU-20190820T142627.cpuprofile.txt
Profile-20190820T143149.json.txt
CPUs | Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz (12 x 3491)
-- | --
GPU Status | 2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled
Load (avg) | undefined
Memory (System) | 63.91GB (55.26GB free)
Process Argv | --disable-extensions --verbose
Screen Reader | no
VM | 0%

CPU %	Mem MB	   PID	Process
    0	    95	  6416	code main
    0	    64	  3792	   window (Issue Reporter)
    0	    19	  3816	   utility
   23	    69	  5188	   shared-process
    0	   107	  7392	   gpu-process
    0	    11	  9876	   electron-crash-reporter
    0	   421	 10792	   window (Welcome - _materials - Visual Studio Code [Administrator])
    0	     5	 11020	     winpty-process
    0	     4	 11048	       C:\WINDOWS\system32\cmd.exe
    0	    13	 11056	     watcherService
    0	    68	 11196	     extensionHost

|  Window (Welcome - _materials - Visual Studio Code [Administrator])
|    Folder (_materials): more than 21242 files
|      File types: xml(21242)
|      Conf files:

Extensions are disabled

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Same thing on Insider's build, here's a new set of performance captures using insiders
Profile-20190821T132035.json.txt
status.txt
CPU-20190821T132143.cpuprofile.txt

@RMacfarlane moving to you as this looks like shared process is spiking, probably the workspace statting?

Yes, this is likely due to the workspace stats call. I made a change yesterday that should improve perf somewhat, @starkat99 can you let me know if you see any difference with today's insiders?

For another tip to reduce stat load see #78710. I submitted a PR for that issue but it hasn't yet been accepted.

I tried this again in today's Insiders build. The issue has mostly gone away, just not completely. Most of the UI seems to be functioning normally now (with or without telemetry enabled, it makes no difference) with the exception of the terminal. As soon as a terminal receives focus (or a new terminal is opened, unhidden, etc.) the severe UI lagginess returns to the entire UI. But once I change focus away from terminal or close it and give it a couple seconds for the lag to resolve, the rest of the UI returns to regular performance. So, as long as I avoid using a terminal everything is usable again with a large workspace folder.

Thanks @starkat99!
I'm able to reproduce this issue, I created a folder with 30k text files in it at the top level. This doesn't seem to be related to the workspace stats call, since it also happens when telemetry is off. When the terminal has focus, there are repeated calls to fs.readdir that are taking more than a second to return

This this new setting in insiders:
"terminal.integrated.enableFileLinks": false


Parameters Object does not list examples field

I looked at #636 again after @darrelmiller posted "Extending representations to parameters and headers" #762 . I think the Parameter Object section should include the (singular) example field under Fixed Fields.  examples are used in parameters in the samples under Examples Object :
# in a parameter

  parameters:
    - name: 'zip'
      in: 'query'
      type: 'string'
      format: 'zip'
      example:
        $ref: 'http://foo.bar#/examples/zip-example'

Also, given the ongoing discussions about multiple representations/content in #762 the example or examples field should be added to  content (was representations) content object, as examples and content objects should apply to parameters as well.

@DavidBiesack It's there https://github.com/OAI/OpenAPI-Specification/pull/761/files#diff-4a97aef5bba9ddb7fd8609f48f4bdc30R906

Thanks @darrelmiller -- is it worth splitting that off into a separate PR, since the examples #636 is already merged but the representations/content PR #761 is still a proposal?

Both merged now


Changed delete modal

https://user-images.githubusercontent.com/59005440/111616754-45f91600-8808-11eb-9822-98eec7f10e5a.mp4


Add Build & Deploy workflow with GitHub Actions

This workflow build-and-deploy.yml will publish a test page, where the player is shown (on push to main-branch). The test page will be automatically redeployed, whenever there is a push to the main-branch (this can be changed).
This can be very useful for testing (especially as a reviewer). You simply open the test page and see/test/review the changes, instead of pulling the changes, building the project and then test it locally. In my opinion this is a great advantage.
The workflow can be customized and extended (my version is only a basic version).
If this will be merged, you have to configure your site to publish with GitHub Actions (only once):

Go to Settings in your repository, left on the sidebar click Pages and choose GitHub Actions from Source Dropdown.
You can also specify a custom domain (if you have one, something like test.paella.upv.es) if you want to. I even recommend that, currently I have to add the ID each time (/?id=belmar-multiresolution-remote).

For more informations see: Publishing with a custom GitHub Actions workflow

Could you activate the build and deploy workflow with GitHub Actions? In case there is any problem or question please do not hesitate to ping Nadine / @naweidner for help or answers! It's running on Nadine's fork of this repo e.g. under https://naweidner.github.io/paella-ethz/?id=belmar-multiresolution-remote so there should be no general problem with this pull request.


Add flag to DB for inactive accounts after registration

Flag added to DB. Accounts are inactive on registration


be sure to test both sides of @@var ||= ... in the compiler

Motivation

This test is disabled, but I discovered that it doesn't provide good coverage of whatever AST we provide because we're not testing both cases of ||=. :man_facepalming:  This PR fixes that.
Test plan

See included automated tests.

(ooc, why is this test currently failing?)

(ooc, why is this test currently failing?)

Because @@var ||= ... gets desugared into:
if @@var
  @@var
else
  @@var = ...
end

which is not correct from the perspective of the VM: class variables are not permitted to be accessed before initializing them.  (This is maddeningly different from instance variables, but there you go.)  So you have to do something more like:
if defined?(@@var) && @@var
  @@var
else
  @@var = ...
end

but then the compiler doesn't properly implement defined? on class variables, which is being addressed in #4558 (along with a better desugaring).

Oh! Gotcha---I had it in my head that #4558 had already landed :sweat_smile:


Cleaning up setup script and presubmit

Coverage remained the same at 74.597% when pulling e9d930d21a2e89fb99e5a4202352194eb298a47a on use-release-tools into 40d25ffc00b894e4ecc26f8103115bc6e42c1da1 on master.


mcmc_sampler bug

In the current MCMC Sampler, the init requires casual_model which is then passed to the parent class DoSampler.  However, the mcmc_sampler also expects a casual_model in the kwargs (line 23).
If causal_model is specified and is not in the kwargs then we get the following error or if both are specified:
AttributeError: 'NoneType' object has no attribute '_graph' (From line 23 of mcmc_sampler).
If we don't pass causal_model but pass causal_model in the kwargs, we get the following error:
AttributeError: 'NoneType' object has no attribute 'identify_effect' (From line 55 of do_sampler)
I suspect that removing the kwargs part of line 23 in mcmc_sampler would fix the code, but I have not tried to do so.

Thanks for raising this @isaachaberman . @akelleh do you mind having a look at the error?

@isaachaberman thanks for raising this. Just merged an update that corrects this error. Can you check again if it works for you?


Help with Interactive Debugging - AttributeError: '_ContainerApp' object has no attribute '_is_interactivity_enabled'

I am new to modal so the issue may just be that. I'm trying to jump into an Ipython shell as explained in the docs here. I have created a simple example that replicates the issue I am coming up against.
hello_world.py
import modal

stub = modal.Stub("example-get-started")

@stub.function()
def f(name):
    print(f"HELLO WORLD {name}")
    modal.interact()
    import IPython

    IPython.embed()

@stub.local_entrypoint()
def main():
    f.remote('Chris')

modal run --interactive hello_world.py

Hi, thanks for reporting and sorry about that. This was a regression on our end caused by some incomplete refactoring. I've just merged a fix, which should be live on PyPI in ≈10 minutes.

Beautiful! Just tried it in the updated version and it worked. What an awesome feature. And thanks for the quick fix!

I'm using v0.62.42 and I'm still running into this issue. Here's my code:

Logs:


[TACHYON-283]Inode based Access Control

Hi :
The Inode based Access Control has been completed. This pull request adds authentication framework and implements the simple authentication. The Tachyon master service will do acl authorization check based on the authentication. In order to decouple the big new feature, the pull request has already been split to 9 sub-tasks. The function of each sub-task can be deduced from
the commit summary. Please feel free to give your comments. Thanks very much.

Can one of the admins verify this patch?

Thanks for the patch, @shenguoquan .
Currently, it seems this PR tries to resolve multiple JIRA tickets? My personal opinion is we should keep one PR per JIRA, so we could keep each pr as small to ease review process. Any possibility to separate this PR into multiple ones?

+1 to incremental PRs

@apc999 @calvinjia Thanks for your advice. I will send the pull request for each Jira. Because the TACHYON-482 and TACHYON-483 is cloesly tied with each other. I will put these two patches into a PR. We at firstly can talk about this PR.

@shenguoquan Thanks, could you close this PR if its no longer necessary?

@calvinjia sure. Thanks for your comments.


update gax to 1.33.0

@garrettjonesgoogle

If you wait just a couple hours, it will be 1.33.1: https://github.com/googleapis/gax-java/pull/596

@elharo Can you update this to 1.33.1?

done


virtualworkspace: forwardingregistry: are we at the correct level of abstraction?

Right now, the implementation in pkg/virtual/framework/forwardingregistry is implementing rest.StandardStorage, which lives at a level in the stack that is low enough that incoming requests have had their bodies + query parameters parsed into Go-objects and functions. Furthermore, it expects as output Go objects, so there are a couple of implications:

we are not able to pass along the incoming request bodies in e.g. UPDATE or CREATE calls without parsing them

this leads us to drive the GET -> apply -> validate -> UPDATE flow, which is supposed to happen between the API server and the database
this leads to more network traffic, more apiserver + database load, and bugs like https://github.com/kcp-dev/kcp/pull/1059

we are doubling serialization and deserialization cost (especially egregious on WATCH streams)

I ran into this type of conundrum in the sharding server implementation a long time ago. At the time, I was also looking to implement rest.StandardStorage, so had to hack around things like this ... the multi-shard handlers actually did want to mess with the resourceVersion for objects on the wire, so I stuck with rest.StandardStorage, and expected to find some more minimal deserialization later. For the forwarding registry, if we expect not to change the underlying fields in the data, perhaps we can be implementing it at a different layer of abstraction altogether to side-step these issues?
/cc @ncdc @sttts @davidfestal

For the forwarding registry, if we expect not to change the underlying fields in the data

At least for the syncer virtual workspace we expect to change the resources "on-the-fly" while forwarding. This is the whole point of the per-workloadcluster transformations that will be performed on the syncer virtual workspace side, and which would be the basis for the future implementation of syncing "strategies" (whatever we call them) like deployment splitter, etc ...

@davidfestal what mutations are you speaking of?

cf https://github.com/kcp-dev/kcp/issues/487:

explore:

a mechanism to plug-in live, golang-based transformations (one-object-to-one-object) of objects in kcp
a mechanism to plug-in live, golang-based transformations that do 1:n mapping of an object in kcp to multiple objects to be synced.

For now only the 1rst as been prototyped.
cf. also:

and https://github.com/kcp-dev/kcp/issues/751#issuecomment-1075338469
https://github.com/kcp-dev/kcp/issues/786#issuecomment-1081933596
https://kubernetes.slack.com/archives/C021U8WSAFK/p1649367172590119?thread_ts=1649334621.955789&cid=C021U8WSAFK

Interesting. 1:n sounds very tricky to do in e.g. WATCH. Might be something we should try to design up-front to make sure we get it right.
As it stands, one side-effect of the current approach is that we do PrepareForUpdate() in the intermediate server (and validation) - I think this is clearly wrong, as the storage responsible for the object should (e.g.) decide when the generation changes, not some generic intermediary.


[raftstore-v2]: add the missed apply log duration and fix apply wait time

What is changed and how it works?

Issue Number: Ref #14321
What's Changed:

Add the apply log duration metrics.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

No code

Release note
None

/test

/test

/merge

/test

/merge


DOMWrapper: setValue

combines setSelected, setChecked` etc as per  https://github.com/vuejs/vue-test-utils-next/issues/17#issuecomment-604367645

This does not seem to be documented on the Migrating page https://next.vue-test-utils.vuejs.org/migration/

This should have been backported to VTU v1 and include deprecation messages. Is that not the case?


ONNX support for Mixtral text-classification

Feature request
I have been trying to optimize a mixtral model trained for text-classification, into its ONNX counterpart.
I have tried it using torch level extraction -
torch.onnx.export(
    model,
    args=tuple(inputs.values()),
    f=output_path,
    opset_version=15,
    do_constant_folding=True,
    input_names=["input_ids", "attention_mask"],
    output_names=["score"],
    dynamic_axes={
        "input_ids": {0: "batch_size", 1: "sequence"},
        "attention_mask": {0: "batch_size", 1: "sequence"},
        "score": {0: "batch_size"},
    },
    verbose=False,
)

Converting the model gives the following warning -
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/modeling_attn_mask_utils.py:114: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if (input_shape[-1] > 1 or self.sliding_window is not None) and self.is_causal:
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/modeling_attn_mask_utils.py:162: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if past_key_values_length > 0:
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:177: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if seq_len > self.max_seq_len_cached:
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:329: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if attn_weights.size() != (bsz, self.num_heads, q_len, kv_seq_len):
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:336: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if attention_mask.size() != (bsz, 1, q_len, kv_seq_len):
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:348: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if attn_output.size() != (bsz, self.num_heads, q_len, self.head_dim):
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:823: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
if top_x.shape[0] == 0:
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:827: TracerWarning: Converting a tensor to a Python list might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
top_x_list = top_x.tolist()
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/transformers/models/mixtral/modeling_mixtral.py:828: TracerWarning: Converting a tensor to a Python list might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
idx_list = idx.tolist()
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/torch/onnx/symbolic_opset9.py:5589: UserWarning: Exporting aten::index operator of advanced indexing in opset 15 is achieved by combination of multiple ONNX operators, including Reshape, Transpose, Concat, and Gather. If indices include negative values, the exported graph will produce incorrect results.
warnings.warn(
/home/piyush/miniconda3/envs/tf/lib/python3.10/site-packages/torch/onnx/symbolic_opset9.py:6350: UserWarning: Warning: ONNX export does not support duplicated values in 'index' field, this will cause the ONNX model to be incorrect.
Doing inference using this ONNX model gives the following error -
InvalidArgument: [ONNXRuntimeError] : 2 : INVALID_ARGUMENT : Non-zero status code returned while running Expand node. Name:'/model/layers.0/block_sparse_moe/Expand_1' Status Message: invalid expand shape
Motivation
To use Mixtral models for fast inference using ONNX.
Your contribution
I am new to these things, but can definitely try to raise a PR.

Mixtral is MoE and MoE is not yet supported by ORT AFAIK.
There is PR  but didn't have any commit for 3 weeks now so I don't know if it's still a thing on their side.

Mixtral MoE was merged last week https://github.com/microsoft/onnxruntime/pull/19945

Mixtral MoE was merged last week microsoft/onnxruntime#19945

Hi, @mgiessing ,  do you know what's the proper way to get ONNX from PyTorch for the MoE model? torch.onnx.export might involve modifying conditional statements.


Update file for deployment using PowerShell - AlertIQ

Change(s):

Updated file connectors.json
Updated file SentinelallInOne.ps1

Reason for Change(s):

Add more connectors and update the API

Version Updated:

Yes

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

We are checking with Ruchir for this PR

Waiting for the update from Ruchir

Waiting for the update from Ruchir

Waiting for the update from Ruchir

Waiting for the update from Ruchir

@hvanh2122  - Please provide PR details in following format -
Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@hvanh2122 : Please address the @rushriva comments

@hvanh2122 : Please address the @rushriva comments

I changed the PR details as requested by @rushriva. Please check. Thank you

@hvanh2122  - Please provide more details around this change, why this change was needed? Can you also provide test screenshots for this change.

@hvanh2122: Please provide more details around this change, why this change was needed? Can you also provide test screenshots for this change as requested by @rushriva

@hvanh2122 : Please provide more details on this PR to understand as requested by @rushriva

@hvanh2122 : Please provide more details on this PR to understand as requested by @rushriva

@hvanh2122 : Please provide more details on this PR to understand as requested by @rushriva

I changed the PR details as requested by @rushriva. Please check. Thank you

@rushriva : Author addressed as requested by you please check and provide your feedback. Thanks!

I changed the PR details as requested by @rushriva. Please check. Thank you

Hi @rushriva,
Can you please review the changes again and provide your feedback
Thanks

Hi @rushriva,
Can you please review the changes again and provide your feedback
Thanks

Hi @rushriva,
Can you please review the changes again and provide your feedback
Thanks

Hi @rushriva/ @rahul0216,
Can you please review the changes again and provide your feedback
Thanks

looks good to me @anki-narravula


Some display boxes now showing its full width -- text can't be read

hi Maurice,
writing this as a new issue since it's not really related to the previous one. please let me know if you would rather i keep that thread going.

please note that the point count number box is not showing at all, so i'm not really sure what number is in it.
the other color selectors seem to be a bit small too: voronoi color, delaunay color, point color, convex hull color.
i'm using it on a 4k screen on Win10, so not really sure if that's one of the reasons too...
tks
Lawrence

Hey,
sorry about the (very) late reply, things drown sometimes...
That is an issue I also experienced under Windows but wasn't able to fix unfortunately. It works fine under Linux and one Windows machine, but looks exactly like yours on another Windows machine...
It seems to be related to the GUI and I don't really know how to fix.

Hey,
sorry about the (very) late reply, things drown sometimes...
That is an issue I also experienced under Windows but wasn't able to fix unfortunately. It works fine under Linux and one Windows machine, but looks exactly like yours on another Windows machine...
It seems to be related to the GUI and I don't really know how to fix.


Double fix README encoding issue

Remove non-breakable space from README.rst, specify encoding=utf-8 in setup.py when reading README.RST
Addresses #601

Looks fine


Add draft comment attribute that can show on PDF cover page

We want to display an additional comment at the bottom (if exists), this will need to be a new attribute that Metanorma provides.

Ideally that we can do this for other flavors as well. The Ribose flavor can use it as well.
Originally posted by @Intelligent2013 in https://github.com/metanorma/metanorma-iso/issues/635#issuecomment-1109579156

We already have conditional text that appears in draft, and appears in the boilerplate section of the Semantic XML, so this is nothing new at all.

Can we have a way to change that text using document attributes or a special block?

e.g. a "WARNING" or "NOTE" before the content body starts?

We can do all sorts of stuff, but you're not telling me what you need. There is a ticket on making the boilerplate XML easier to configure, which I think is a waste of time. There is provision for admonitions at the start of a document, and the warning can be injected there in Presentation XML generation.
But I am not interested in a fishing expedition. You want a comment at the bottom of the title page, that's what you're getting.

What you want is custom text that can be added to include on e.g. a cover page.
That will need an extension to the code used to manipulate the boilerplate contents onto the cover page, will try to make it generalisable.

We are going to reuse the solution for putting admonitions before all clauses, at the top of a document: instead of beforeclauses=true, it will be coverpage=true.
We have an added requirement that such admonitions may need to appear without their default title. I will do so in markup by setting their caption to empty: . {blank}

notag notes and admonitions are unnumbered

coverpage notes and annotations will be moved to div[@id = 'coverpage-note-destination'] in HTML and Word in postprocessing.

@opoudjis could you clarify how to encode ?

As a result of this ticket, you can populate that by adding the following to the document preface:
[NOTE,notag=true,coverpage=true]
====
This document is circulated as received from the committee secretariat.
====

https://www.metanorma.org/author/topics/document-format/text/#cover-page-admonitions

@opoudjis thanks!


UnboundLocalError in run.py during training

Hello,
I executed the following command:
python run.py train CHECKPOINT --max_epoch=100 -c default
The code is throwing the following error on line 207:
if cfg['TRAIN']['SAVE_IMG'] and sim_mtx is not None:
UnboundLocalError: local variable 'sim_mtx' referenced before assignment
I am facing this issue and not sure how to fix it. Any insights on what might be causing this error?

@Rodrigo29Almeida
Try setting SAVE_IMG to False in the config file.
But I don't quite understand it, because the training should return the sim_mtx when calculating the loss at the first iteration.

Hello, thanks for your help before. I was a problem with a missing "/" in my path to the database. I apologize for the error.
I have installed an anaconda environement following your steps.
As I attempted to run the code in my environment, I encountered an issue in the trainer.py file, specifically in the train_step function. The problematic line is:
feat = m_specaug(m_pre(X))  # (nA+nP, F, T, 1)
The error message I received is as follows:
OperatorNotAllowedInGraphError: using a tf.Tensor as a Python bool is not allowed: AutoGraph did convert this function. This might indicate you are trying to use an unsupported feature.
I am reaching out to seek your guidance on resolving this issue. Additionally, I want to inform you that I previously addressed a problem with len() in the same file. The error message was:
"len is not well defined for symbolic Tensors. (X:0) Please call x.shape rather than len(x) for shape information."
To resolve this, I modified the code from:
n_anchors = len(X[0])   to   n_anchors = X[0].shape[0]
I would greatly appreciate your assistance in understanding and resolving the current issue. If you have any suggestions or insights, it would be immensely helpful.
Thank you for your time.


[bug] ModuleStatusConstructor(): argument module is optional but it is being tested in step 5 and 6.

loader.js implementation feedback

Fixed as part of https://github.com/whatwg/loader/pull/122


Allow to change the email in oauth2 registration

Just associate the oauth2 token to account and send the confirmation email if email account is not the same from the oauth2 provider.

Hi @lasote, this may also be related to give users the ability to link different e-mail accounts in biicode, maybe with more than just one-email: https://github.com/biicode/biicode/issues/4

Yes, but having multiple emails is much harder. All have to be confirmed, (or in process, so have to keep a state), change the login system to use multiple emails, oauth process...  That's a different feature.

Its funny...users want to have multiple accounts with one email and others want single account with multiple emails? LoL  So... by now... One Email to Rule Them All!! XDDD

but what if they don't want to change their biicode base email?


Fixed issues in receipts, updated to PEP8

Coverage increased (+0.04%) to 87.108% when pulling a65a70f2d1af7889c23e1700ab5a44f0b71d2ded on shirishagaddi:fixes into c8de256b52589ac15cb8d153b6ff0ebca9831d3b on MicroPyramid:master.


Still can't query player data...

#2 is closed before I can confirm the issue is fixed so here we go again.
After clicking 查询 button, an empty toast was created by createStatStore(). Tracking down the calling stack we got getGenshinGameStats->request<GameStats>.
console.log(response.text()); shows {"data":null,"message":"","retcode":10103} was received, indicating something is wrong with Mihoyo API. Tested with UID 100011111 on https://babalae.github.io/genshin-info/ to make sure UID is valid.

It seems an API request issue, unable to reproduce.
You can launch a Chromium-based browser with --disable-web-security, and temporarily disable Tampermonkey to find the location where the error occurred.
Development Mode
You may clone the repository, run npm run build:api && npm run build:genshin-data && npm run build:genshin-api at the root of repository, then cd packages/genshin-stats && npm run dev.
On the development page, click the Settings button, then fill in the cookies and have a try.

Tested again and now it is working. Not sure what happened.


Don't use tty in remote exec

What this PR does / why we need it:
virtctl vnc didn't work with CRI-O, because the remote exec command in
virt-api converted LFs into CR + LF, which broke the VNC network protocol.
The root cause for this is that this seems to be a default behaviour
of tty, see https://github.com/moby/moby/issues/8513#issuecomment-216191236.
The solution is to not use tty, we don't need it.
(Still unclear why this only happened with CRI-O)
Release note:
Fixed virtctl vnc for Openshift CRI-O

also see https://bugzilla.redhat.com/show_bug.cgi?id=1619218

looking into the failed tests...

@fabiand do we want do backport this to the release-0.8 branch?

Yes, please prepare a patch.

@fabiand done: https://github.com/kubevirt/kubevirt/pull/1518

This might have caused issues with something we were doing @slintes. I'm going to do some more looking into it but now when I VNC into a VMI I've been able to VNC into forever I get an error.

@gageorsburn  That's interesting, because those bytes which your client (is it Chicken VNC on Mac?) is trying to interpret as auth type, is the Server protocol version "RFB 003.008". And this PR indeed fixed sending this server version on Openshift with CRI-O (though I don't fully understand yet why this was an issue with CRI-O only). But it was always send this way on Openshift and Kubernetes with Docker. Which type of cluster are you using? Is there an option in your VNC client to disable auth?


Is it possible to get authorized user's bookmark list?

Hi there~
I would like to use rettiwt to grab all my bookmarks and automatically sync to my Notion database, however currently is not possible to get the authorized user's bookmark list info.
Also, I noticed that I am not able to get the api key if i have 2fa enabled: after run rettiwt auth login <email> <handle> <password> with 2fa enabled it doesn't return anything. Maybe ask to input 2fa when needed?
Thank you~

however currently is not possible to get the authorized user's bookmark list info.

Yes, unfortunately.

Maybe ask to input 2fa when needed?

2fa has not been implemented yet, however, it is certainly in the works and I'm trying to get my head around implementing it.


add cleanup cron

We have tried to cleanup such objects with s3 lifecycle policies, but it didn't work.
The plan is to leave it as deactivated cron, and activated it when/if necessary.

/cc @osherdp

/hold


Frontend | CB-270 | Merge frontend and configure CI

This commit merges frontend from old codersboard repository to new one.
The version of the frontend is taken from https://github.com/CodersCrew/codersboard/pull/56
and includes changes releated to CB-199 task.
Also:

upgrade Dockerfile/docker-compose.yml to be similar to this one in backend.
add ci-frontend workflow

@htk4 As I see there are some issues with frontend build. Could you review it or discuss with someone from frontend team?

These issues are related to linter and formatter, so I will fix them in next commits within this PR - someday 😄


Rplots.pdf generated in working directory by plot-qualities

We observed this on the workshop cluster (linux) but I don't see this locally.

http://stackoverflow.com/questions/6535927/how-do-i-prevent-rplots-pdf-from-being-generated

Closing since this function is being deprecated for most users in favor of the new interactive quality plot.


fix(nuxt): nuxt v3 compatibility

Update to RC.14 with latest api changes and dependency bumps (major) to prepare for v3.0.0
https://github.com/nuxt/framework/releases/tag/v3.0.0-rc.14

I just tried the new<EMAIL_ADDRESS>but it doesn't work:
https://github.com/nuxt/framework/discussions/9032#discussioncomment-4171427


feature/NWPS-413-ButtonComponent

Please review

Approving on the basis on sending working button in master/prod with view that changes miay come after.


Add Rafael Belchior and André Augusto to GitHub

For now I'm just requesting to add Rafael and Andre to the GitHub org with read permissions to Cacti
We are in talks about making Rafael a maintainer and I'm hoping that in a couple of days that gets confirmed as well and then we can add him to the maintainer group of Cacti as well, but for now, that's not a decision that's been finalized.
GitHub IDs:
https://github.com/RafaelAPB
https://github.com/AndreAugusto11

Invites sent! I put them in contributors which has no superpowers

Invites sent! I put them in contributors which has no superpowers

@ryjones Thank you very much!


[Gradio] Add Tool Load Tab

在gradio界面加入Tool Load以及Unload
@Bobholamovic @juncaipeng

Codecov Report
Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (086d270) 61.61% compared to head (ded7a50) 61.01%.

Files
Patch %
Lines

...bot-agent/src/erniebot_agent/utils/gradio_mixin.py
4.25%
45 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
- Coverage    61.61%   61.01%   -0.60%
===========================================
  Files           56       56
  Lines         2743     2773      +30
===========================================
+ Hits          1690     1692       +2
- Misses        1053     1081      +28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.164

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.164


[RFC] LoggerInterface for the logger

Hi,
I looked at the Propel main class and saw there is a logger attached to Propel. What about injecting a Propel\Logger\LoggerInterface object for using Monolog as the underlying logging system?
Any idea @fzaninotto and @willdurand?

Keep It Simple, Stupid: Monolog will be used as the logging component, no need to add another layer of abstraction on top of that.

So, is it a no go? We said we'd use Monolog, I think it does the job.

Hum, @fabpot should look at this issue and share his mind.
We choose Monolog as Logger component, to add yet another interface may doesn't make sense..

+1 for keeping it simple and just integrate Monolog (without adding yet another interface).

Wonderful :)


There is an exception during debugging, but there is no problem in the running state.

Required information
Operating system:
Ubuntu 20.04.5 LTS
Compiler version:
gcc version 9.4.0 (Ubuntu 9.4.0-1ubuntu1~20.04.1)
Observed result or behaviour:
program crash during debugging
Expected result or behaviour:
Can be debugged normally
Conditions where it occurred / Performed steps:
When using gdb to debug a program

@byrnexu I see in the stack trace that you run into the error handler. Could you please also add the error message and full log output to the issue.
My idea why this crashes is that the mutex lock receives a SIGINT signal from the debugger and our current policy is to repeat the call 5 times and then fail (where I have to admit that this is not the best strategy).
But if you are running into some timeout than @mossmaurice solution should solve the issue.

@byrnexu Thanks for creating this issue! Which iceoryx version are you running?
Often, during debugging the monitoring feature can kick in, cleaning up the resource of unresponsive apps and should be disabled by starting RouDi with ./iox-roudi -m off. If you are on master this feature was recently disabled by default (#1580).

Hello, I am running version 2.0.2


Webpack crashed after finding an error in my code

Using the webpack dashboard plugin, I tried making an error (using a non-existent variable) and I got this log after webpack showed the said error through awesome-typescript-loader:

[3805:0x332ed30]    79063 ms: Scavenge 1167.4 (1371.3) -> 1167.2 (1376.8) MB, 5.0 / 0.0 ms  allocation failure
[3805:0x332ed30]    79075 ms: Scavenge 1172.3 (1376.8) -> 1171.9 (1387.3) MB, 5.7 / 0.0 ms  allocation failure
[3805:0x332ed30]    79340 ms: Scavenge 1202.8 (1407.7) -> 1197.2 (1407.7) MB, 3.9 / 0.0 ms  allocation failure
[3805:0x332ed30]    79355 ms: Scavenge 1202.8 (1407.7) -> 1202.3 (1427.2) MB, 6.4 / 0.0 ms  allocation failure

<--- JS stacktrace --->
Cannot get stack trace in GC.
FATAL ERROR: Scavenger: promoting marked
 Allocation failed - process out of memory
 1: node::Abort() [node]
 2: 0x12b81cc [node]
 3: v8::Utils::ReportOOMFailure(char const*, bool) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: 0xa98e0b [node]
 6: void v8::internal::ScavengingVisitor<(v8::internal::MarksHandling)0, (v8::internal::PromotionMode)0, (v8::internal::LoggingAndProfiling)1>::EvacuateObject<(v8::internal::ScavengingVisitor<(v8::internal::MarksHandling)0, (v8::internal::PromotionMode)0, (v8::internal::LoggingAndProfiling)1>::ObjectContents)0, (v8::internal::AllocationAlignment)0>(v8::internal::Map*, v8::internal::HeapObject**, v8::internal::HeapObject*, int) [node]
 7: v8::internal::Scavenger::ScavengeObject(v8::internal::HeapObject**, v8::internal::HeapObject*) [node]
 8: v8::internal::Heap::IteratePromotedObjectPointers(v8::internal::HeapObject*, unsigned char*, unsigned char*, bool, void (*)(v8::internal::HeapObject**, v8::internal::HeapObject*)) [node]
 9: void v8::internal::BodyDescriptorBase::IterateBodyImpl<v8::internal::ObjectVisitor>(v8::internal::HeapObject*, int, int, v8::internal::ObjectVisitor*) [node]
10: void v8::internal::BodyDescriptorApply<v8::internal::CallIterateBody, void, v8::internal::HeapObject*, int, v8::internal::ObjectVisitor*>(v8::internal::InstanceType, v8::internal::HeapObject*, int, v8::internal::ObjectVisitor*) [node]
11: v8::internal::Heap::DoScavenge(v8::internal::ObjectVisitor*, unsigned char*, v8::internal::PromotionMode) [node]
12: v8::internal::Heap::Scavenge() [node]
13: v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
14: v8::internal::Heap::CollectGarbage(v8::internal::GarbageCollector, v8::internal::GarbageCollectionReason, char const*, v8::GCCallbackFlags) [node]
15: v8::internal::Factory::NewRawTwoByteString(int, v8::internal::PretenureFlag) [node]
16: v8::internal::String::SlowFlatten(v8::internal::Handle<v8::internal::ConsString>, v8::internal::PretenureFlag) [node]
17: v8::internal::String::Flatten(v8::internal::Handle<v8::internal::String>, v8::internal::PretenureFlag) [node]
18: v8::String::WriteUtf8(char*, int, int*, int) const [node]
19: Hash64String(Nan::FunctionCallbackInfo<v8::Value> const&) [/home/mahdi/Documents/projects/miare/node_modules/farmhash/build/Release/farmhash.node]
20: 0x7f2aab65d2e2 [/home/mahdi/Documents/projects/miare/node_modules/farmhash/build/Release/farmhash.node]
21: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [node]
22: 0xb46f2c [node]
23: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node]
24: 0x7c9604843a7
EXIT RUNTIME
Aborted (core dumped)
error Command failed with exit code 134.

Complete process:

First green line is from the  last successful build.

Can you create a minimal repository that hits the issue and then provide install + error reproduction steps? That would be a great help for us to investigate this more quickly. Thanks!
Looks related to https://github.com/FormidableLabs/electron-webpack-dashboard/issues/52 (at least a comment there).

I posted the comment in #52, thought it might clear that issue somehow. It works after the first build but as I mentioned, on error it crashed.
I created a new webpack config file, really minimum (using webpack-cli) and no crashes were visible. Although new errors did not appear in webpack dashboard.
This is my webpack config file:
const webpack = require('webpack');
const path = require('path');
const DashboardPlugin = require('webpack-dashboard/plugin');

const UglifyJSPlugin = require('uglifyjs-webpack-plugin');

module.exports = {
	entry: './index.js',

	output: {
		filename: '[name].bundle.js',
		path: path.resolve(__dirname, 'dist')
	},

	module: {
		rules: [
			{
				test: /\.js$/,
				exclude: /node_modules/,
				loader: 'babel-loader',

				options: {
					presets: ['es2015']
				}
			}
		]
	},

	plugins: [new UglifyJSPlugin(), new DashboardPlugin()]
};

and my index.js file containing the error:
cost hello = "Hello World!";


Shell + Message Router integration

Message Router can now be created without any configuration in JS, just call createMessageRouter().
Fixed async start and stop logic in Shell

"Chrome <IP_ADDRESS> (Windows 10) DatagridComponent it should create app FAILED
Error: Unable to create the MessageRouter client, configuration is missing." from the build

"Chrome <IP_ADDRESS> (Windows 10) DatagridComponent it should create app FAILED Error: Unable to create the MessageRouter client, configuration is missing." from the build

Yup, forgot to run those tests. I'll fix the tests, MessageRouter should be injected and mocked instead of creating it in each component.


when to release  2.2.0 version

we wan't to use new version because to fix snakeyaml bug : https://github.com/apolloconfig/apollo-java/pull/35

It may take some time as the create app function is still ongoing. However you may use the snapshot version if it's urgent.


Migrate to interchange 0.3.0

This PR migrates to interchange 0.3.0, using const generics.
I'm also looking to see if we can benefit from the improved flexibility to get rid of the client-N feature by having the interchange be provided by the runner instead of coming from trussed.

I had a similar patch for the old client context implementation.  It replaced the client-? features with const generics and a lifetime in Service and ServiceEndpoint:
https://github.com/robin-nitrokey/trussed/commit/bd18de095cb37d7a686c257823c3bae93a960b69


Pull content using PMP best practices

Apply best practices when pulling content:

[x] Title/slug
[ ] Date
[ ] Author (if possible)
[ ] Body (content encoded)
[ ] Featured image, including caption/alt (from first-attached-image)

See https://support.pmp.io/docs#dictionary

Missing published date -> #25

Enhancements -> #26
Also see images-not-getting-pulled -> #16

Okay, I think that covers the bugs in separate issues.
I also opened #30, as I'm a bit concerned about Wordpress's out-of-the-box Post attribution.  And it would be good to brainstorm about how that might work.


k8s 1.21 failing on Windows 20H2 Standard

Tracking issue for https://github.com/rancher/rancher/issues/32932
Workaround:
Document that only Windows 20H2 Datacenter is supported for 1.21.

You will need an rke2 server and a windows agent to reproduce the errors we are seeing. What is happening is that when on a 20H2 standard edition server, containerd starts up and the containerd go client fails to connect to the fully qualified npipe address.
npipe:\\\\.pipe\containerd-containerd

If I start containerd manually and use critctl everything works as expected. If I change the code to use
\\.pipe\containerd-containerd

Then it works as expected. When on 20H2 datacenter edition everything works and executes as expected.
RKE2 Server Installd;
curl -sfL https://get.rke2.io | sh -
echo "RKE2_CNI=calico" >> /usr/local/lib/systemd/system/rke2-server.env
systemctl enable rke2-server.service
systemctl start rke2-server.service

You will need a 20H2 standard edition and datacenter edition with the Windows Containers feature enabled. Then execute.
Invoke-WebRequest -Uri https://raw.githubusercontent.com/rancher/rke2/master/install.ps1 -Outfile install.ps1
New-Item -Type Directory c:/etc/rancher/rke2 -Force
Set-Content -Path c:/etc/rancher/rke2/config.yaml -Value @"
server: https://<server>:9345
token: <token from server node>
"@

$env:PATH+=";c:\var\lib\rancher\rke2\bin;c:\usr\local\bin"

[Environment]::SetEnvironmentVariable(
    "Path",
    [Environment]::GetEnvironmentVariable("Path", [EnvironmentVariableTarget]::Machine) + ";c:\var\lib\rancher\rke2\bin;c:\usr\local\bin",
    [EnvironmentVariableTarget]::Machine)

./install.ps1
rke2.exe agent

Original issue: https://github.com/rancher/rke2/issues/1454

Hi @phillipsj I'd like to understand better what issue you are seeing connecting to containerd via named pipe. Can you share some more details please?

What address is containerd configured to listen on?
What client is connecting to containerd?
What address is the client configured to connect to?
What error message is observed from the client?

One note is that I would expect the named pipe path to look like either npipe://\\.\pipe\containerd-containerd (in k8s or crictl config) or just \\.\pipe\containerd-containerd (in containerd config). I see the format of your address is slightly different above, but not sure if that's just a typo in the issue or not.

@keypar here  are the details:

The address is \.\pipe\containerd-containerd
The containerd go client
The containerd go client is using : npipe:\\.pipe\containerd-containerd
The error message is below.

failed to dial \"npipe:////./pipe/containerd-containerd\": connection error: desc = \"transport: error while dialing: open npipe:////./pipe/containerd-containerd: The filename, directory name,
or volume label syntax is incorrect.\"

I can't imagine it is as simple as the address I am using. The exact same configuration works on 1809, 2004, 20H2 Data Center, but doesn't work on 20H2 standard. If it was an incorrect address I would expect it to at least fail on 20H2 Data Center.

If you're using the containerd Go client code and not customizing what dialer is used (via WithDialOpts), then the default dialer will connect with winio.DialPipe. DialPipe expects the pipe to be in the format \\.\<pipename, and doesn't support the npipe:// prefix. I was able to repro on a Win11 machine that \\.\pipe\containerd-containerd works and npipe:////./pipe/containerd-containerd does not.
To summarize, \\.\pipe\containerd-containerd is the expected format to use with the containerd Go client code. The npipe:// prefixed format is something added by Kubernetes tooling, and not supported by containerd or Windows directly.
What's still unclear to me is how the npipe:// prefixed format would have worked on other OS releases, but I think the answer here is to stick with the \\.\pipe\containerd-containerd path with the containerd Go client instead.

That's good to know and interesting that crictl requires the npipe:// prefix.

@kevpar could you please try to repo on 20H2 standard vs datacenter? That is where I am seeing the issue.

@kevpar I just tested the same release on Windows Server 2022 Data Center preview and it behaves the same as 2019, 2004, and 20H2 Data Center. It seems standard is still the only one that has an issue. I will test 2022 standard out of curiosity.

@phillipsj you saying that the npipe:// prefixed path works on 2022/20H2/2004/2019 Datacenter editions, but doesn't work on 20H2 Standard (and 2022/2004/2019 Standard are as-yet untested), right?
Can you provide the exact Go client code that is making the connection in the cases where npipe:// works?

@kevpar I just tested the same release on Windows Server 2022 Data Center preview and it behaves the same as 2019, 2004, and 20H2 Data Center. It seems standard is still the only one that has an issue. I will test 2022 standard out of curiosity. It is line 103 here that is causing the issue.

I set up a 20H2 Standard VM and tested using a simplified test program.
PS C:\Users\Administrator\desktop> cmd /c ver

Microsoft Windows [Version 10.0.19042.1165]
PS C:\Users\Administrator\desktop> ./ctrdconnect
PS C:\Users\Administrator\desktop> $LASTEXITCODE
0

I'm not seeing the same issue repro. Can you try this same test program?

2022 standard has been confirmed to work with the same version.

Is everything working as expected then? Or are you still seeing issues on some platform?

I still need to retest Windows 20H2 standard, I will retest using the same ISO and one that is up to date to see if I get different results. Several people have independently verified that 20H2 standard edition works. Your initial test showed it wouldn't have worked on Windows 11. So there seems to be something happening.

The scenario is actually a little different than I understood at first. Using the standard containerd.New function to create a connection will not work if given an address with the npipe:// prefix. However, in your case you're using the Kubernetes util.GetAddressAndDialer function and passing it the npipe:// path, which is expected to work as the function will correctly handle the prefix. So everything I have observed so far indicates we are seeing correct behavior.

The two methods of establishing a connection are the equivalent of testing with ctr versus crictl, for what it's worth.

@phillipsj Can this issue be closed with the latest Windows Server patches?

Yes.


Fix bot throws an error due to the new version has conflict with the restored conversation state

Closes #5007
During the continous deployment of bots, while bot assets changed and the bot resume the state from persistent  storage, the bot may throws error. It is caused by the dialogId may no longer exsisted in the bot assets.
In this PR, if such error occured, the current dialog will be replaced by the root dialog.

@EricDahlvang Can you take a look at this one? Thanks!

@EricDahlvang Can you take a look at this one? Thanks!

@LeeParrishMSFT  this is a draft, and does not look ready for review.
Also, i'm not seeing how these changes would resolve the issue: https://github.com/microsoft/botbuilder-dotnet/issues/5007
The changes in this PR currently do not look like they will have any affect, since DialogContext.FindDialog already calls the parent recursively:
                if (this.Dialogs != null)
                {
                    var dialog = this.Dialogs.Find(dialogId);
                    if (dialog != null)
                    {
                        return dialog;
                    }
                }

                if (this.Parent != null)
                {
                    return this.Parent.FindDialog(dialogId);
                }

The problem is, the ids are re-written as the dialog stack is changed.  Until the dialog ids are not re-written, or there is a mapping/coordination between previous and new ids, as well as dialog versioning stored with the state: this will continue to be a problem.

@LeeParrishMSFT  this is a draft, and does not look ready for review.
Also, i'm not seeing how these changes would resolve the issue: https://github.com/microsoft/botbuilder-dotnet/issues/5007
The changes in this PR currently do not look like they will have any affect, since DialogContext.FindDialog already calls the parent recursively:
                if (this.Dialogs != null)
                {
                    var dialog = this.Dialogs.Find(dialogId);
                    if (dialog != null)
                    {
                        return dialog;
                    }
                }

                if (this.Parent != null)
                {
                    return this.Parent.FindDialog(dialogId);
                }

The problem is, the ids are re-written as the dialog stack is changed.  Until the dialog ids are not re-written, or there is a mapping/coordination between previous and new ids, as well as dialog versioning stored with the state: this will continue to be a problem.

Hi @EricDahlvang,
I completely agree that the only way to continue the dialog is keep the IDs unchanged or we have a old-new IDs mapping.
So the current solution only tried to resume the dialog in some point. The difference of the findDialog is,
The existing code:
                if (this.Dialogs != null)
                {
                    var dialog = this.Dialogs.Find(dialogId);
                    if (dialog != null)
                    {
                        return dialog;
                    }
                }

                if (this.Parent != null)
                {
                    return this.Parent.FindDialog(dialogId);
                }

Only tries to recursively find the dialog of the ActiveID of current dialogContext.
The code I added:

                    if (dialog == null)
                    {
                        var dc = this;
                        while (dialog == null && dc != null)
                        {
                            dc = dc.Parent;
                            dialog = dc.FindDialog(dc.ActiveDialog.Id);
                        }

                        if (dialog == null)
                        {
                            throw new InvalidOperationException($"Failed to continue dialog. A dialog with id {this.ActiveDialog.Id} could not be found.");
                        }
                        else
                        {
                            return await dialog.BeginDialogAsync(dc, cancellationToken).ConfigureAwait(false);
                        }

once the previous findDialog returns nothing, it will recursively find a valid activeDialog of current dialogContext's ancestor dialogContext. Then restart the dialog from there.
This is only a draft solution. The default behavior fallback of no dialog found need to be discussed further. I will keep talking to Dong and Tom to find out a better solution.

Hi @EricDahlvang,
I completely agree that the only way to continue the dialog is keep the IDs unchanged or we have a old-new IDs mapping.
So the current solution only tried to resume the dialog in some point. The difference of the findDialog is,
The existing code:
                if (this.Dialogs != null)
                {
                    var dialog = this.Dialogs.Find(dialogId);
                    if (dialog != null)
                    {
                        return dialog;
                    }
                }

                if (this.Parent != null)
                {
                    return this.Parent.FindDialog(dialogId);
                }

Only tries to recursively find the dialog of the ActiveID of current dialogContext.
The code I added:

                    if (dialog == null)
                    {
                        var dc = this;
                        while (dialog == null && dc != null)
                        {
                            dc = dc.Parent;
                            dialog = dc.FindDialog(dc.ActiveDialog.Id);
                        }

                        if (dialog == null)
                        {
                            throw new InvalidOperationException($"Failed to continue dialog. A dialog with id {this.ActiveDialog.Id} could not be found.");
                        }
                        else
                        {
                            return await dialog.BeginDialogAsync(dc, cancellationToken).ConfigureAwait(false);
                        }

once the previous findDialog returns nothing, it will recursively find a valid activeDialog of current dialogContext's ancestor dialogContext. Then restart the dialog from there.
This is only a draft solution. The default behavior fallback of no dialog found need to be discussed further. I will keep talking to Dong and Tom to find out a better solution.

Thanks for debugging @cosmicshuai! I'd love to discuss this with you folks and bring in @tomlm and @Stevenic.
Let's consider a deployment and whether assets or not:
1- Assets did not change at all: Then all the IDs are recomputed to the same values and we guarantee that the conversation continues smoothly
2- Assets changed: This is what we need to discuss. In the case you are fixing, the dialog that got changed was the dialog that was on the top of the stack when the conversation was persisted. In that case, the trick of finding the dialog up the parents stack could help identify the active dialog. However the extent to which dialogs could change is endless, including swapping ID's and absolutely changing the structure of the dialog graph, etc. It's not obvious 1) how to determine whther the change was large enough that the data in storage is not relevant to the new assets and 2) what to do if we decide that the dialog structure changed in such a way that we cannot use part of the state.
Let's have a discussion on what is the right approach here and take it from there.

Thanks for debugging @cosmicshuai! I'd love to discuss this with you folks and bring in @tomlm and @Stevenic.
Let's consider a deployment and whether assets or not:
1- Assets did not change at all: Then all the IDs are recomputed to the same values and we guarantee that the conversation continues smoothly
2- Assets changed: This is what we need to discuss. In the case you are fixing, the dialog that got changed was the dialog that was on the top of the stack when the conversation was persisted. In that case, the trick of finding the dialog up the parents stack could help identify the active dialog. However the extent to which dialogs could change is endless, including swapping ID's and absolutely changing the structure of the dialog graph, etc. It's not obvious 1) how to determine whther the change was large enough that the data in storage is not relevant to the new assets and 2) what to do if we decide that the dialog structure changed in such a way that we cannot use part of the state.
Let's have a discussion on what is the right approach here and take it from there.

Update: After some discussion, the current solution is to restart the whole conversation once the dialog assets changed during the CI/CD. Still need some debug to ensure everything works correctly.

@carlosscastro
Could you help review this PR?

@cosmicshuai, looks like this fix is still under discussion.  Should we convert this back to draft until it is decided?

@mrivera-ms Sure, please convert it to draft.
I think I need to add a unit test that once the bot use conversation state and the bot assets changed. It won't throw this error again.

Trying to add a e2e test for this fix.

@cosmicshuai, @boydc2014, are we on track for R13? If not, we need to push the issue to the next milestone. Thank you.

Here is a E2E test for this fix.

Add CosmosDB to TestBot Json

Add a bot use cosmosdb to store conversation state.

change the bot assets then resume the dialog

I recorded a video to demo this change:
https://user-images.githubusercontent.com/17074777/112590175-59763380-8e3d-11eb-8161-0ac8cf76eca9.mp4

@cosmicshuai, @boydc2014, are we on track for R13? If not, we need to push the issue to the next milestone. Thank you.

Yes, the code is ready, aligned with Shuai and Carlos's conversation. Shuai just updated some more proof, and i just approved that.

@mrivera-ms Hi Monica, I think this PR is ready for merge. Could you take a look?

@carlosscastro, could you please take a look at this PR? @cosmicshuai has updated the changes.

Please merge this pr, so I don't have to write a workaround.

Closing this one for now, the proposed solution doesn't address the problem and could generate others.


[Bug] a bug in training on a homogeneous graph created from a built-in dataset.

Our built-in graph partitioning pipeline has a bug on homogeneous graphs. Here is how we can reproduce the bug.
Construct a homogeneous graph.
python3 tools/partition_graph.py --dataset ogbn-products --filepath /tmp/ogbn-products/ --num-parts 1 --output /tmp/ogbn_products_1p

Use the following yaml file products_nc.yaml.
---
version: 1.0
gsf:
  basic:
    model_encoder_type: rgcn
    graph_name: ogbn-products
    backend: gloo
    verbose: false
  gnn:
    fanout: "15,10"
    num_layers: 2
    hidden_size: 128
    use_mini_batch_infer: false
  input:
    restore_model_path: null
  output:
    save_model_path: null
    save_embed_path: null
  hyperparam:
    dropout: 0.5
    lr: 0.001
    num_epochs: 10
    batch_size: 1024
    wd_l2norm: 0
  rgcn:
    num_bases: -1
    use_self_loop: true
    sparse_optimizer_lr: 1e-2
    use_node_embeddings: false
  node_classification:
    target_ntype: "node"
    label_field: "labels"
    multilabel: false
    num_classes: 40

use the following command to run the training job.
python3 -m graphstorm.run.gs_node_classification \
        --num-trainers 1 \
        --num-servers 1 \
        --num-samplers 1 \
        --part-config /tmp/ogbn_products_1p/ogbn-products.json \
        --ip-config ip_list.txt \
        --cf products_nc.yaml --node-feat-name feat

below is the error:
Traceback (most recent call last):
  File "/home/ubuntu/workspace/graph-storm/python/graphstorm/run/gsgnn_np/gsgnn_np.py", line 151, in <module>
    main(args)
  File "/home/ubuntu/workspace/graph-storm/python/graphstorm/run/gsgnn_np/gsgnn_np.py", line 116, in main
    trainer.fit(train_loader=dataloader, val_loader=val_dataloader,
  File "/home/ubuntu/workspace/graph-storm/python/graphstorm/trainer/np_trainer.py", line 120, in fit
    for i, (input_nodes, seeds, blocks) in enumerate(train_loader):
  File "/home/ubuntu/.local/lib/python3.10/site-packages/dgl/distributed/dist_dataloader.py", line 115, in __next__
    self._request_next_batch()
  File "/home/ubuntu/.local/lib/python3.10/site-packages/dgl/distributed/dist_dataloader.py", line 147, in _request_next_batch
    result = self.collate_fn(next_data)
  File "/home/ubuntu/.local/lib/python3.10/site-packages/dgl/dataloading/dist_dataloader.py", line 202, in collate
    input_nodes, output_nodes, blocks = self.graph_sampler.sample_blocks(self.g, items)
  File "/home/ubuntu/.local/lib/python3.10/site-packages/dgl/dataloading/neighbor_sampler.py", line 141, in sample_blocks
    block.edata[EID] = eid
  File "/home/ubuntu/.local/lib/python3.10/site-packages/dgl/view.py", line 227, in __setitem__
    self._graph._set_e_repr(self._etid, self._edges, {key: val})
  File "/home/ubuntu/.local/lib/python3.10/site-packages/dgl/heterograph.py", line 4133, in _set_e_repr
    raise DGLError('Expect number of features to match number of edges.'
dgl._ffi.base.DGLError: Expect number of features to match number of edges. Got 10158 and 0 instead.
Client[0] in group[0] is exiting...

@jalencato Is this bug resolved?


Create Deliver icon on message. Showing fail icon if the message is not delivered

Is there anyway to show custom view on message? I want to show delivery status on each message? how to do it?

You mean like this?

Yeah, but I want to show it to right.

Unfortunately the delivery status  is supported only above the timestamp.
So you will have to modify the library to achieve what you want to do.


Overloading the >>- operation to do both map and flatMap

I don't think theres a reason why only flatMap should be tied to the >>- operator. I think it's pretty clear that if you use the operator you want to map/flatMap depending on what you are returning from your function. I find it unlikely that someone would consciously want to map to Result<Result<T, ErrorTpe>,ErrorType> just like its probably an error if you map to Optional<Optional<T>> and you probably wanted to use flatMap. For extreme cases, they can just type the function name.

I’m disinclined to overload >>- to perform map. In no particular order:

Overloading increases the amount of work Swift has to do in order to compile an expression. Specifically, it necessitates the addition of constraints which can cause “Expression was too complex to be solved in reasonable time” errors to crop up. Every additional overload of any term used in a given expression increases this cost significantly.

Overloading increases the amount of semantic work a reviewer or maintainer has to do in order to understand an expression.

Nested results and optionals are completely valid use cases whether or not you or I encounter them. We shouldn’t penalize someone who wants to do something using nested results.

The distinction between map and flatMap is extremely important as a reviewer. If something maps, you know it’s going to be 1:1—it will not e.g. increase the size of the output. If it flatMaps, it warrants more thorough review since it has the capacity for choice: it can turn successes into failures or vice versa. This is extremely important, and would not be made easier by conflating >>- to do both jobs.

TL;DR: map and flatMap represent different classes of operation, and thus should not be conflated in a single operator :-1:

Ok :) sounds good to me


Make tslint.json to be simple with extends standard.

To make tslint.json be simplify:
{
  "extends": [
    "tslint:recommended",
    "tslint-config-standard"
  ]
}

If we use the above setting for tslint, the current project has many warnings.
We need to:

change tslint.json to the above setting
add custom rules to tslint.json to satisfy npm run lint with the current project code base
look into the new tslint.json, study it and then to select: which rule need to follow by changing the code style, and which rule we need to keep customized.

Done.


What’s wrong with 2.5?

Why did you delete it?

Did you just need to patch something lol

Yes, I needed to fix something. Its back online now!

Thanks!


update-python-resources: include wheel in resources

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

When we used virtualenv for our Python virtual environments, the wheel resource from the<EMAIL_ADDRESS>formula was pulled in automatically, so there was no need (or rarely a need) for wheel to be specified as a resource. Now that we use python3 -m venv for virtual environments, though, the wheel resource is no longer automatically installed in the virtual environment:
$ python3 -m pip list
Package    Version
---------- -------
pip        21.0.1
setuptools 53.0.0
wheel      0.36.2

$ python3 -m venv venv

$ source venv/bin/activate

$ python3 -m pip list
Package    Version
---------- -------
pip        21.0.1
setuptools 53.0.0

For some more context into why wheel was added, see https://github.com/Homebrew/brew/pull/8059#discussion_r461064786 which points to https://github.com/Homebrew/homebrew-core/pull/58380#discussion_r458830938. Again, the information in that thread is outdated now that we use python3 -m venv.
As a result, the number of times that wheel is added as an extra_packages item to the pypi_formula_mappings.json file (overriding the exclusion) has increased a lot recently.
I don't think it makes sense for us to exclude wheel as a resource anymore, given this. As far as I know, it doesn't show up in the pipgrip output by mistake enough to be an issue. I would guess that we already include a few resources that aren't needed because they are output by pipgrip, so I don't think wheel showing up in a few extra cases where it may not really be needed is a hueg deal. Plus, we can always exclude wheel manually if needed.
This also may solve some of the issues mentioned in https://github.com/Homebrew/brew/pull/10811#issuecomment-797273663 with wheel.
Lastly, I left the remaining excluded resources (argparse, pip, setuptools, wsgiref) in the sclude list. Of these, only pip and setuptools are installed automatically, so I think argparse and wsgiref could probably be removed from this list. I couldn't figure out why I added them to this list in the first place, though. I bet that I just copied the items in an exclude list from somewhere else, but I can't seem to find where that would be, and I wonder if there's a reason for them being there. If anyone remembers and has some insight, I'd appreciate it.

Review period will end on 2021-03-16 at 00:00:00 UTC.

Makes sense to me. I'm not sure if this will actually help with what I described in #10811 because I'm not sure if pipgrip catches PEP 517 build backend tools. In any case, I think it's probably a good idea for the occasional situation where wheel is actually needed.

Review period ended.


how to localize the 'cancel' button text

I thought this would work out of the box, but when I switch the system language to different than english, the button still shows "cancel" instead of eg. "abbrechen" in german. Any ideas why this is the case?

this can be done by going to project settings in xcode and adding the language there, in the "Localizations" tab.


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.40%. Comparing base (5729174) to head (6bbeeb5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   90.40%   90.40%
=======================================
  Files          19       19
  Lines         396      396
  Branches       65       65
=======================================
  Hits          358      358
  Misses         38       38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


bug: problematic interaction between Astro Islands and navbar class

What version of daisyUI are you using?
v4.6.1
Which browsers are you seeing the problem on?
All browsers
Reproduction URL
https://stackblitz.com/edit/daisyui-astro-us2kgv
Describe your issue
As per https://github.com/withastro/astro/issues/9957:

When integrating Tailwind CSS and DaisyUI in a project, embedding a framework-specific component within a div element assigned the "navbar" class—utilizing the client:only directive—results in an unexpected outcome where raw JavaScript code is displayed. This issue appears to be specifically triggered by the presence of the "navbar" class

This happens because Astro injects its Islands directly as a set of three tags: a style, a script, and an <astro-island>. Since the navbar uses the selector:
:where(.navbar > *) {
  display: inline-flex;
  align-items: center;
}

This causes the injected script and style tags to be given a visible display property, which messes everything up.
My current workaround is: https://stackblitz.com/edit/daisyui-astro-fmyw1d?file=src%2Fglobal.css although (a) it would be great if DaisyUI prevented this from happening by default, and (b) I'm not good enough with css to be confident that this is a proper fix for the problem.
While this issue happens with Astro, in theory anyone who put a

I really like Astro. But injecting style and script tags in between DOM elements is questionable 💀
I will try to change the selector to avoid selecting those tags.


Improve diagnostics when CLR load fails

I ran into a frustrating problem with CLR load failures on certain computers when running an application that uses wwDotNetBridge was deployed. In the process of debugging, I improved ClrHost to report error information for any failure (vs. only for selected API calls). Once I learned what the error was, I thought perhaps the problem was related to using deprecated CLR hosting APIs, so I added an updated CLR loader.
I also thought for a moment that a .NET DLL I had created using a Microsoft.NET.Sdk-style project was loading whereas wwDotNetBridge.dll was not, so I updated the project format for wwDotNetBridge accordingly. (It turned out that PowerShell, through which I was testing loading, was keeping assemblies loaded, so load attempts that would have failed silently succeeded.)
None of these changes were actually necessary (although the error reporting was quite helpful). It turned out to be just the need for a lousy loadFromRemoteSources line in a .config file, which I considered early on, but had initially ruled out due to misleading documentation.
The good news is the work nonetheless makes for a useful update and future-proofing to the wwDotNetBridge bootstrapping.

I based the branch of this PR on my events branch, which will make merging easy once events is merged. However, I see it causes lots of commits to show.

Can you do me a favor and break these fixes out into separate more bite sized branches? This merge is getting too big to manage. At least the C++ changes and the core changes.
I will merge things in when I have a little more time to look closer at the code which will likely be later next week.

I wasn't able to merge this. I tried to cherry pick the changes from the CLR4 commits, but it pulled in other changes that were out of sync with the previous merge.
I just manually merged the two files in and that's working fine.
There are a other things here, but I just don't have the time to figure out exactly what these tweaks are in this bunch of changes. Most of these look like little convenience tweaks. So if you care about these maybe try to merge master back into your final code and see where you land. Most of the important changer are merged in now so we should be close.


Autogallery

Robin's Summary

Added an auto-generate gallery button that appears for empty galleries to address cold start problem
Collections are organized by contract address and ignores spam (in the future, collections will be organized via GPT)
Undo option if autogallery feature was used (not a universal undo for any action)
Added tooltip for new user flow

Summary by OpenAI
Release Notes

New Feature: Added AutoGalleryToggle component to auto-generate a gallery based on collections.
Documentation: Updated OnboardingDialogMessage object with a message suggesting the use of auto-gallery feature.
Style: Added two new values to the whiteSpace prop in NewTooltip.tsx.
Test: Added optional property forceDisplay to useTooltipHoverOptions type in useTooltipHover.ts.
Chore: Added three new SVG icons, AdmireIcon, PaintbrushIcon, and UndoIcon.

A gallery auto-generated,
With collections now integrated.
Bugs fixed and docs updated,
Code refactored and style upgraded.
New icons added, tests run,
This PR is a job well done!

LFG! excited for this one, looks great
a couple of comments:

Let's keep the Admire icon specifically for Admires. Since these are 2 distinct actions I think using it for both weakens its importance as the "admire" icon. Do you think the paintbrush doesn't work here? or maybe wanna save for other features? im down to help look for alternatives too

the position of the How to set up your gallery tooltip looks a bit off when I navigate to the editor. but it might be an existing issue prior to this PR.. maybe because the tooltip position gets set before the LHN disappears 🤔 in which case don't need to worry about it in this PR

Suggestion: For this sentence in the tooltip "Auto-generate a gallery based on your collections", the reference to collections is a bit confusing imo since the whole left sidebar is about Gallery collections not nft collections (contracts). offering some potential alternatives: "Auto-generate a gallery sorted by contract", "Auto-generate a gallery organized by project"

@kaitoo1

great point about the admire icon- the reason i initially used it was bc other platforms often designate AI functionality with sparkles and i realized we already had one. i didn't think about the point about it seeming confusing relative to the admire action

also changed the copy, great suggestion!

interesting point about the misplaced tooltip. i can def repro when navigating from somewhere else, but not when i refresh from the page directly. forcing a position left: 0px seems to fix the issue for both cases 👍


Open Workspace in New Window icon in the remote explorer is not keyboard accessible via tabbing.

Testing #183578
Tested on mac.

Open Remote Explorer with some remote extensions installed.
Select an entry in the tree and try to tab to the Open Workspace in New Window button. However, Open Workspace in Current Window is keyboard accessible.

You can use the right arrow key to move focus to additional inline actions.


PackageId:CPython39.Exe.x64;PackageAction:DownloadPackage;ReturnCode:0x80070133;

This issue has been moved from a ticket on Developer Community.

[severity:I'm unable to use this version]
Unable to install Visual Studio Community 2022
===DO NOT EDIT BELOW THIS LINE===
PackageId:CPython39.Exe.x64; PackageAction:DownloadPackage; ReturnCode:0x80070133;

Original Comments
Feedback Bot on 6/29/2023, 06:35 PM:
(private comment, text removed)

Original Solutions
(no solutions)

It seems the problem occurs when the CPython download fails. This could be due to network timeouts, corporate firewall policy, VPN configuration, anti-virus, or other problems. See if a retry helps, and if not, see if you can download the Python runtime directly from https://python.org/ and install it manually.
If that doesn't solve your issue, we could use more detailed logs to see what's really going on. Can you please collect more logs by running http://aka.ms/vscollect.exe and uploading %temp%\vslogs.zip and reopen the ticket if it persists? Thank you!😊


Add datapath visualizaiton

Overview

Link to the Google Docs document
https://docs.google.com/document/d/1PruQ8zEo6KMc3_CmpRoazlFw5wbU9dNqWk6H6knj0sg/edit#heading=h.kvacwaylps7p
Defenition of done

Run examples for Kiali , WeaveScope
Investigate how is Kiali work
a. If Kiali works vis Prometheus then we need to investigate what format of entries Kiali uses for drawing.
b. if Kiali works without Prometeus then we should investigate what data is Kiali using for drawing.
Provide PRs into SDK if needed for Kiali
Add example in deployment-k8s, NSM + Kiali
Write article and post on dev.to

Weave Scope is not supported anymore:
https://www.weave.works/blog/weave-cloud-end-of-service
https://github.com/weaveworks/scope#please-note-this-project-is-no-longer-maintained-more-details-available-here
Kiali is a management console for Istio service mesh: https://github.com/kiali/kiali#introduction
And don't have plans to support other meshes: https://github.com/kiali/kiali/issues/2962
Also, Kiali is highly integrated with Istio in code: https://github.com/search?q=repo%3Akiali%2Fkiali+istio&type=code
I think both solutions are not suitable.

There are three options for solving the issue:

Using Grafana Features
Pro:
well-known product with rich functionality
Cons:
node graph display capabilities do not meet our requirements
Continue searching for a system that meets our requirements
Pro:
no creation costs
Cons:
The result is not guaranteed. Possible costs for integration and integration support
Create our own system
Pro:
Flexibility. Xored has engineers with experience building such a system
Cons:
The resources for support are required

TODO:

add color scheme
display all ifaces on graph
add fields panel (ip context + metrics)
add menu panel (overview (empty), graph)
overview ( stats: number of nses, number of ns, 3 graphs (1. tx_bytes, 2. rx_bytes, 3. error_packets)
try use 'get' (https://github.com/networkservicemesh/api/blob/main/pkg/api/networkservice/connection.proto#L80)  via grpc client
use cytoscape.js for graph
Consultate about UX/UI


Caching is broken on aashe-hub-prod

Nothing is getting stored or received:
In [4]: from django.core.cache import cache

In [6]: cache.set('test-cache-key-ben', 'this is a test', 60*10)

In [7]: cache.get('test-cache-key-ben')

Is that why changes have been instant the last few days?

Yes.
— Bob

On Jun 1, 2017, at 12:09 AM, monika-aashe<EMAIL_ADDRESS>wrote:
Is that why changes have been instant the last few days?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/AASHE/hub/issues/459#issuecomment-305383887, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlK8BvWBWTiHVNWMpYn7q_bVsPsW8I1ks5r_jlxgaJpZM4NseCT.

--
Register today
http://conference.aashe.org/registration/registration-rates/ for the 2017
AASHE Conference & Expo, themed "Stronger in Solidarity," and join us in
San Antonio, Texas from Oct. 15 - 18.
Connect with us:   Website http://www.aashe.org/ | Facebook
https://www.facebook.com/aasheorg | Twitter
https://twitter.com/AASHENews | LinkedIn
http://www.linkedin.com/company/aashe

Email Confidentiality Notice
http://www.aashe.org/email_confidentiality_notice


compute_face_descriptor fails with numpy array

I'm trying to solve this issue.
I have an 50x50 image as a numpy array and I'm trying to call:
face_descriptor.compute_face_descriptor(image, shape)
Which results in:
RuntimeError: Unsupported image type, must be 8bit gray or RGB image.
I have tried to do:

x = x[:, :, np.newaxis]
To convert x to image using PIL and scipy.misc
To convert it to OpenCV mat.

I have no clue of what I should do to use this method properly.

The example shows you how to use it.  If you run it without modifying the code it will work.

I'm just reading another set of images. It doesn't make sense that this makes the code stop working.

predictor_model = 'Resources/shape_predictor_68_face_landmarks.dat'
embeddings = 'Resources/dlib_face_recognition_resnet_model_v1.dat'

# Create a HOG face detector using the built-in dlib class
face_detector = dlib.get_frontal_face_detector()
face_pose_predictor = dlib.shape_predictor(predictor_model)
face_aligner = openface.AlignDlib(predictor_model)
face_descriptor = dlib.face_recognition_model_v1(embeddings)

labels = []
images = []
size = 50

path = 'Data/yalefaces'
for p in os.listdir(path):
    images.append(io.imread(os.path.join(path, p), as_grey=True))
    labels.append(int(p.split('.')[0].replace('subject', ''))-1) # original from 1 to 15

n_targets = len(set(labels))

def get_embeddings(image):
    face_rect = dlib.rectangle(left=0, top=0, right=size, bottom=size)
    # Get the landmarks/parts for the face in box face_rect.
    shape = face_pose_predictor(image, face_rect)
    # Compute the 128D vector that describes the face in img identified by
    # shape.  In general, if two face descriptor vectors have a Euclidean
    # distance between them less than 0.6 then they are from the same
    # person, otherwise they are from different people.  He we just print
    # the vector to the screen.
    return face_descriptor.compute_face_descriptor(image, shape, 1)

for x in images:
    print(x.shape)
    l = get_embeddings(x)

This is my full code. Not much of changes.

What happens when you run the example without any code changes at all?

Same thing:
Data/yalefaces
Processing file: Data/yalefaces\subject01.glasses.gif
Number of faces detected: 1
Detection 0: Left: 110 Top: 82 Right: 239 Bottom: 211
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-25-236587bcd4fa> in <module>()
     42         # person, otherwise they are from different people.  He we just print
     43         # the vector to the screen.
---> 44         face_descriptor = facerec.compute_face_descriptor(img, shape)
     45         print(face_descriptor)
     46         # It should also be noted that you can also call this function like this:

RuntimeError: Unsupported image type, must be RGB image.

Post that image somewhere and I'll take a look.

Ok, thank you. You can find everything here: https://github.com/paulaceccon/mlPlayground.  The notebook is FaceRecognizer.ipynb and the images are under Data. Thank you again.

That's not an RGB image, as the error says.  Use an RGB image or convert the image to RGB.

Sorry if this is stupid, but I didn't understood what is the expected input. For example, I tried to convert,  by code, my 2D (1 channel) data to 3 channels (like numpy.array([x, x, x]) and this didn't work either. Is there an expected format in terms of array, tensor, etc?

Use some program to convert the image file to RGB, or google how to do it.  This forum is for reporting dlib bugs or discussing dlib development.  It's not the place to ask for generic programming advice or tutorials.  There is already a lot of that available on the net elsewhere.

Ok, thank you. I was JUST trying to understanding the input type, as the doc doesn't say if it is a numpy.array or whatever.
compute_face_descriptor((face_recognition_model_v1)arg1, (object)img, (full_object_detection)face[, (int)num_jitters=0]) → vector :
Takes an image and a full_object_detection that references a face in that image and converts it into a 128D face descriptor. If num_jitters>1 then each face will be randomly jittered slightly num_jitters times, each run through the 128D projection, and the average used as the face descriptor.


Login Screen

Description

Hi, i'm wondering if Pinpoint has a Login Screen and ... if it does not have one, is this documentation enough to do it?
https://naver.github.io/pinpoint/plugindevguide.html
Or do i need more documentation to implement this feature?
Any example of code or any additional documentation  it is going to help a lot.
I want to implement this because I want to restrict access to certain users, for which I suppose I also need a database ... which should be HBASE or any other such as MySQL?
Thanks in advance.
Environment

Pinpoint version: 1.8.0 Snapshot
OS, WAS, affected library, etc: Ubuntu Server 16.04, Tomcat 8, Hbase 1.2.2, Hadoop 2.7.2, Java 8
Additional details (e.g. how your collector/web is set up): Collector/Web Deployed on Tomcat 8, Agent deployed on WebLogic 10.3.6

Hi @ing-arriola
There is not guide for auth. You should see code pinpoint-web yourself. I think you should use spring security because pinpoint web is base on spring framework.

Hi @minwoo-jung
Spring Security.... I did not know about that ... but I find it very interesting that you have shared the information with me to start investigating the issue and implement the user validation screen.
Thank you so much!!

can pp-web 1.7.1 also implement login in the way of spring security?
THX

Hi @wikiios
Yes. it can implment base on 1.7.1 version.


Stop micromanaging WS support in IDEs

Description
This PR removes the subscriptions_enabled flag from the Django and Channels views. It also removes two internal flags with the same purpose from all other views.
These flags were originally added to address #334. However, the behavior described in that issue has since been changed in GraphiQL, making our flag useless. (Tested locally using the Django integration, setting subscriptions_enabled to true, opening GraphiQL, and observing the browser's network tab).
Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Fixes #2051

Summary by Sourcery
Remove the subscriptions_enabled flag from various views and update the documentation accordingly. Enable WebSocket support by default in all GraphQL IDEs, simplifying the configuration process.
Enhancements:

Remove the subscriptions_enabled flag from Django and Channels views, as well as from other internal views, to simplify the configuration and enable WebSocket support by default.

Documentation:

Update the documentation to reflect the removal of the subscriptions_enabled parameter from the GraphQLView and AsyncGraphQLView in Django and Channels integrations.

Chores:

Add a RELEASE.md file to document the changes in this release, indicating the removal of the subscriptions_enabled setting and the default enabling of WebSocket support.

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release removes the dated subscriptions_enabled setting from the Django and Channels integrations.
Instead, WebSocket support is now enabled by default in all GraphQL IDEs.
Here's the tweet text:
🆕 Release (next) is out! Thanks to @NucleonJohn for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

@DoctorJohn feel free to merge when Pre commit is fine :D


STYLE: clang-format AlignEscapedNewlines Left (for macro definitions)

Aligns escaped (\) newlines as far left as possible, according to
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
Applies especially to macro definitions.
Aims to fix a kwrobot-v1/ghostflow-check-master error at pull request
#2785
"Remove virtual from Get/Set macro definitions", as reported by
Dženan Zukić:

commit 8f26661 creates blob [...] at Modules/Core/Common/include/itkMacro.h
with size 101090 bytes (98.72 KiB) which is greater than the maximum
size 100000 bytes (97.66 KiB). If the file is intended to be
committed, set the hooks-max-size attribute on its path.

Tip of the day: when looking at the diff (Files changed) in GitHub, you may like to switch from "Split" to "Unified" view.

Catch-22: clang-format locally adjusted my itkCheckHasFenvtStructMember.cxx
But then KWStyle did not want me to commit, saying:
Modules/Core/Common/CMake/itkCheckHasFenvtStructMember.cxx:0: error: Header mismatch: #include (/*=========================================================================) : Utilities/KWStyle/ITKHeader.h
pre-commit hook failure
-----------------------

KWStyle check failed.

Line numbers in the errors shown refer to the file:
Modules/Core/Common/CMake/itkCheckHasFenvtStructMember.cxx.kws

Any suggestion?

Does this PR need rebasing now?

@dzenanz  Indeed... I just did! Took out the Fix KWStyle check errors from cxx files .../CMake commit, for clarity. Thank you for merging that one already  😃


[Bug]: UserProxyAgent code_execution_config "use_docker": False doesn't cancel docker requirement and in WSL couldn't detected Docker

Describe the bug
Hi Autogen community,
I have Autogen set up to run on my WSL 2 Ubuntu 22.04 environment. Inside my service, there is an Autogen agents setup. One of the agents in this setup, UserProxyAgent, still requires Docker even when I pass "use_docker": False. When I tested this option on MacOS, I saw the same result. It seems to me that the "use_docker" config option is somehow not canceling the Docker requirement.
Below is my agent:
exec_agent = autogen.UserProxyAgent(
    name="Exec",
    system_message="Executor. You follow the plan. Execute the code written by the coder agent and return outcomes.",
    human_input_mode="NEVER",
    code_execution_config={"last_n_messages": 12, "work_dir": code_dir, "use_docker": False},
    llm_config=llm_config,
)

To solve this issue, I needed to pass os.environ["AUTOGEN_USE_DOCKER"] = "no", and then it worked.
Beyond this issue also, in the same WSL environment, even though Docker was running and WSL 2 Backend was enabled in the Docker Engine on the Windows 11 side, it could not detect it.
Thanks!
Steps to reproduce

Create a WSL 2 Ubuntu 22.04 environment in Windows 11.
Install Docker in the environment.
Create a dummy UserProxyAgent and test it with the use_docker: True or False options.

Model Used
gpt-4
Expected Behavior
Docker should have been not required for this environment.
Screenshots and logs
No response
Additional Information
AutoGen version: 0.2.31
OS: Ubuntu 22.04
Python: 3.10.8

@dtunai -- the requirement to set that environment is intentional, helps ensure that users consciously disable docker.


Support pandas 2.0

Our CI jobs for pandas 2.0 are currently failing (see, e.g., here).
I see (at least) two issues with supporting pandas 2.0:

https://github.com/pandas-dev/pandas/issues/50127 (open PR here): this issue is causing our CI failures
https://github.com/pandas-dev/pandas/pull/52212 changed how pandas is inferring dtypes from scalars, which results in issues when we partition by a datetime (loading the data eagerly will return a datetime64[ns], loading the data as dask data frame will return a datetime64[s]). I don't think we have tests for this by the way. That we could address by explicitly setting the units to nanoseconds here.

@DamianBarabonkovQC @xhochy

Open for PRs.