feat: make env vars optional

Is your feature request related to a problem? Please describe.
I pulled my t3 app on my laptop at an internet cafe (I wanted to do a little UI work). Trying to run it locally, I'm confronted with
❌ Invalid environment variables:
DATABASE_URL: Required
NEXTAUTH_SECRET: Required
NEXTAUTH_URL: Required
DISCORD_CLIENT_ID: Required
DISCORD_CLIENT_SECRET: Required
I created a .env and stuck it in my src folder with those variables with empty values
Still doesn't work.
I then added optional to them here
export const serverSchema = z.object({
    DATABASE_URL: z.string().url().optional(),
    NODE_ENV: z.enum(["development", "test", "production"]),
    NEXTAUTH_SECRET: z.string().optional(),
    NEXTAUTH_URL: z.string().url().optional(),
    DISCORD_CLIENT_ID: z.string().optional(),
    DISCORD_CLIENT_SECRET: z.string().optional(),
})

And that fixed the problem.
Describe the solution you'd like to see
I believe these env vars should be optional from the start. People who are just starting out my just want to be focusing on their frontends and not have to worry about environment issues.
Desribe alternate solutions
You probably have a better solution than the one I proposed.
Just make source buildable out-of-the-box if someone were to push to their remote, then pull to another machine.
Additional information
No response

Actually, I'm still having issues
  Type 'undefined' is not assignable to type 'string'.

  21 |     providers: [
  22 |         DiscordProvider({
> 23 |             clientId: env.DISCORD_CLIENT_ID,
     |             ^
  24 |             clientSecret: env.DISCORD_CLIENT_SECRET,
  25 |         }),
  26 |         // ...add more providers here

I put random values into my .env, and now I'm getting
Type error: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

  21 |     providers: [
  22 |         DiscordProvider({
> 23 |             clientId: env.DISCORD_CLIENT_ID,
     |             ^
  24 |             clientSecret: env.DISCORD_CLIENT_SECRET,
  25 |         }),
  26 |         // ...add more providers here

I realize this is because I made those objects optional so I reverted schema.mjs
Now I'm facing
warn  - You are using a non-standard "NODE_ENV" value in your environment. This creates inconsistencies in the project and is strongly advised against. Read more: https://nextjs.org/docs/messages/non-standard-node-env
❌ Invalid environment variables:
 DATABASE_URL: Required
 NEXTAUTH_SECRET: Required
 NEXTAUTH_URL: Required
 DISCORD_CLIENT_ID: Required
 DISCORD_CLIENT_SECRET: Required

error - Failed to load next.config.mjs, see more info here https://nextjs.org/docs/messages/next-config-error

> Build error occurred
Error: Invalid environment variables
    at file:///C:/Users/conno/source/repos/bobbyconnolly/ginger/src/env/server.mjs:16:11
    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:385:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async Object.loadConfig [as default] (C:\Users\conno\source\repos\bobbyconnolly\ginger\node_modules\next\dist\server\config.js:68:36)
    at async Span.traceAsyncFn (C:\Users\conno\source\repos\bobbyconnolly\ginger\node_modules\next\dist\trace\trace.js:79:20)
    at async C:\Users\conno\source\repos\bobbyconnolly\ginger\node_modules\next\dist\build\index.js:69:28
    at async Span.traceAsyncFn (C:\Users\conno\source\repos\bobbyconnolly\ginger\node_modules\next\dist\trace\trace.js:79:20)
    at async Object.build [as default] (C:\Users\conno\source\repos\bobbyconnolly\ginger\node_modules\next\dist\build\index.js:65:29)

with env vars /src/.env
 DATABASE_URL=localhost:5432/your_database_name
 NEXTAUTH_SECRET=taco
 NEXTAUTH_URL=http://localhost:3000
 DISCORD_CLIENT_ID=taco
 DISCORD_CLIENT_SECRET=password

I see now that server.mjs / line 10 (const _serverEnv = serverSchema.safeParse(process.env)) is actually grabbing the environment variables.
I finally had the sense to make another npx create-t3-app@latest and noticed that the .env lives one folder up from /src with the following data
# When adding additional env variables, the schema in /env/schema.mjs should be updated accordingly

# Prisma
DATABASE_URL=file:./db.sqlite

# Next Auth
NEXTAUTH_SECRET=
NEXTAUTH_URL=http://localhost:3000

# Next Auth Discord Provider
DISCORD_CLIENT_ID=
DISCORD_CLIENT_SECRET=

Now building works and yarn dev working 🥳

Yes .env should be in the project root.
Maybe we should have a committed version of .env-example with the default values so that one can copy those if they pull the repo from remote?

I'm getting the same error, just following Theo's tutorial on youtube:
`

❌ Invalid environment variables: {
06:37:07.637 | NEXTAUTH_SECRET: [ 'Required' ],
06:37:07.637 | DISCORD_CLIENT_ID: [ 'Required' ],
06:37:07.637 | DISCORD_CLIENT_SECRET: [ 'Required' ]
06:37:07.637 | }
06:37:07.637 | - error Failed to load next.config.mjs, see more info here https://nextjs.org/docs/messages/next-config-error
06:37:07.643 |
06:37:07.643 | > Build error occurred
06:37:07.644 | Error: Invalid environment variables
06:37:07.644 | at T.m (file:///vercel/path0/node_modules/@t3-oss/env-nextjs/dist/index.mjs:1:500)
06:37:07.644 | at T (file:///vercel/path0/node_modules/@t3-oss/env-nextjs/dist/index.mjs:1:690)
06:37:07.644 | at P (file:///vercel/path0/node_modules/@t3-oss/env-nextjs/dist/index.mjs:1:1081)
06:37:07.644 | at file:///vercel/path0/src/env.mjs:4:20
06:37:07.644 | at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
06:37:07.663 | Error: Command "npm run build" exited with 1

`

What about postgresql where DATABASE_URL is not needed? It should be optional, isn't it?

why would a connection URL not be needed for postgres?

@c-ehrlich because it uses the variable POSTGRES_URL

@c-ehrlich because it uses the variable POSTGRES_URL, etc

then you should change your env object to use POSTGRES_URL instead of DATABASE_URL

I am playing with the base t3stack app which by default had Discord auth. I replaced this with GitHub and now I getting the error:
❌ Invalid environment variables: {
DISCORD_CLIENT_ID: [ 'Required' ],
DISCORD_CLIENT_SECRET: [ 'Required' ]
}
I replaced everything like in the tutorial - https://www.youtube.com/watch?v=CGDBNlDE7Js yet the app still thinks I should use Discord instead. Is there any package I need to uninstall and replace with github? Can't find anything all posts and tutorials explain how to check env. auth.ts etc. but nothing about installing anything :(
Cheers


Refactors chart.jsx into rechart. Updates table to use stickyHeader.

Updates table to use stickyHeader. Removes classes to improve ui.
updates package.json
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Do not change the following line aside from replacing YOUR-ISSUE-HERE with the issue this PR fixes
fixes #370
Please provide enough information so that others can review your pull request:
I refactored the chart.jsx bar chart into a rechart line chart. I refactored the logic to make it more readable.
Also added a stickyHeader tag onto table.jsx and removed the classes as they were messing up the margins and made the font look ugly in red.
Explain the details for making this change. What existing problem does the pull request solve?
The show me more page needed a facelift.
Test plan (required)
BEFORE:

AFTER:

Final Checklist

[x] Have you bumped the version in package.json?

Second decimal for major change, third decimal for minor change. This can go past 10 i.e. 1.0.9 !=> 1.1.0, 1.0.9 => 1.0.10
Read here for more info

[x] Have you added any new tests necessary?
[x] Is your PR rebased off the most current master?
[x] Have you squashed all commits, or if you will merge will you squash all commits?
[x] Did you use yarn, not npm?
[x] Did you use Material-UI wherever possible?
[x] Did you format according to Prettier?
[x] Did you run all of your most recent changes locally to make sure everything is working?

see the requested changes other than that, the charts look great! nice work!

PR #525 has the old Chart.jsx. Just a heads up.

@kevin-Price Have you pulled the latest master? The current verion is 0.3.40

@acthelemann
Thanks for the catch!


update file

@4change  sign CLA

Related Doc - https://kubernetes.io/zh-cn/docs/tasks/configmap-secret/managing-secret-using-kubectl/

@4change, would you be willing to sign the CLA?
See https://github.com/kubernetes/website/pull/38115#issuecomment-1342549096

CLA not signed and the author is not responding.
/close
Feel free to reopen when CLA issue is resolved first.


License type?

Nice example. I see this repository is forked many times, but there is no open source license listed in the repository.  Reading over your blog, it seems your intention is to make it freely available. Would you be amenable to adding a license type to the readme file, such as https://opensource.org/licenses/MIT?
Great example BTW. I learned a lot.

I have added MIT license to my repo now :) Glad you learned I might make an free ebook out of it.


meta-resin check resin-boot partition free space at build time

Make meta-resin warn and error out at build time when creating the resin-boot partition if the free space in this partition is less than the biggest file which resides there (this is a requirement for being able to do atomic updates for the boot files)

Shall we do this check only for non-production builds?

The non production builds don't have resinhup support so given that this issue is only for atomic writes when updating the hostOS, I would say having this only for production builds would be enough.

The size of files in resin-boot can vary between development builds and production builds. This is what I meant with the above comment. That maybe we should not have this check fatal for development builds

What I propose is to not implement this check for development builds. Do you see a problem with this @floion ?

So we should only have the check for production builds, right?

Yes.

Cool, that's what I actually meant in the second comment here. Now that I look at it I see I wrote it the other way around

@agherzan this was implemented, right?

Implemented in https://github.com/resin-os/meta-resin/pull/895


add daemonization

Add flags to rez-env and to suite wrappers to daemonize a command.
This will involve adding a new tool, rez-daemonize-wrapper. This will be the process actually daemonized, and it will subproc the target command. This is needed because otherwise Rez will clean up the context file before the child process terminates, meaning that any attempt in the child proc to use the rez API and query the current context would fail. rez-daemonize-wrapper would just run the child proc and then cleanup the rez tempfiles on exit.
I expect to add these args:
rez-env --daemon
my_suite_tool ++daemon

We have a similar problem and took a simpler approach of just not allowing rez to delete the temporary files so they exist beyond the current execution scope.  This has the benefit (for us) of also allowing multiple commands to be run within the same environment (e.g. we can return to it later) which I don't think is possible with the daemon approach.

Ah, I have thought about adding this as a configurable option
(no_tempfile_delete or similar). It should also be possible to set this for
an individual resolve too.
Unfortunately for us simply not deleting tempfiles isn't an option, for
multiple reasons. And daemonization is necessary because we have various
init.d services that aren't actually daemonizing right now!
A
On Thu, Nov 19, 2015 at 2:01 PM, Mark Streatfield<EMAIL_ADDRESS>wrote:

We have a similar problem and took a simpler approach of just not allowing
rez to delete the temporary files so they exist beyond the current
execution scope. This has the benefit (for us) of also allowing multiple
commands to be run within the same environment (e.g. we can return to it
later) which I don't think is possible with the daemon approach.
—
Reply to this email directly or view it on GitHub
https://github.com/nerdvegas/rez/issues/271#issuecomment-158211843.


Updating to the latest stable dependencies. Fixes possible ring libra…

…ry version conflicts

@fafhrd91 should include this with 0.6?


Configuration

Dear Juexin wang,
I'm trying to make your code run on a much larger protein, and i was wondering what was your configuration (i.e number of cpus/gpu, memory etc.) that you used on your example data ?
Kind regards
Leopold Quitté

Hi Juexin,
Thanks for your quick reply. I'm currently trying to make your code work on
a protein complex of 800 residues with a NVIDIA V100 Volta (32G HBM2
memory).
Do you think it could work ? And if not do you have any idea how to ?
Kind regards,
Léopold Quitté
Le ven. 27 mai 2022 à 18:00, juexinwang @.***> a écrit :

Hi Leopold,
The memory is a huge big challenge in current codes. We used one typical
TitanV with 11G memory with less than 100 residues. The current setting
does not support too long protein sequences, but we are working on
improving the capacities. If you have enough memories in GPU, you can try
bigger proteins.
Juexin
—
Reply to this email directly, view it on GitHub
https://github.com/juexinwang/NRI-MD/issues/2#issuecomment-1140067796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APAF4SZEIAXMIX5BICT5PB3VMFAW7ANCNFSM5XEP3KDA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi Léopold Quitté,
I am so glad you have a V100 card. But I am still not confident the 800 residue complex can work directly. Using the current codes, one quick way you can do this is sampling, saying choose only even or odd residue to run. Another way is a granularity-based method, saying aggregate nearby residues as a unit, and run the model within the units. Let me know if you have any updates.


[Bug]: Failed to start example with vercel integration

Which Remix packages are impacted?

[X] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[ ] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[ ] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[X] @remix-run/vercel

What version of Remix are you using?
1.0.3
Steps to Reproduce
Hi there! Thanks for your work 🎊!!!
I follow the steps on this tutorial
npx create-remix@latest
# follow the prompts
cd ./remix-example
npm run dev

The prompts can be found here or down
Need to install the following packages:
  create-remix@latest
Ok to proceed? (y) y

R E M I X

💿 Welcome to Remix! Let's get you set up with a new project.

? Where would you like to create your app? ./remix-example
? Where do you want to deploy? Choose Remix if you're unsure, it's easy to change deployment targets. Vercel
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes

> postinstall
> remix setup node

Successfully setup Remix for node.

added 422 packages, and audited 423 packages in 2m

115 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
💿 That's it! `cd` into "remix-example" and check the README for development and deploy instructions!

Expected Behavior
I except to open my browser on port localhost:3000 and see the server running
Actual Behavior
First thing I notice is that the example says

Open up https://localhost:3000, the app should be running. If you want, take a minute and poke around the starter template, there's a lot of information in there.

But you the default port as I see in AppConfig is 8002 so you need to add devServerPort: 3000 to remix.config.js
Second is when you changed the port I got a 426 error

And when I try to open https://localhost:3000 I got an ERR_SSL_PROTOCOL_ERROR

Dang. @mcansh is actually wrapping up better Vercel integration with their new files API, should be out soon.

@ryanflorence Thanks Ryan! No problem!! I just follow the demo with Remix App Server and already loving the work you've done!!

Our team will follow up here as well, sorry about this! 🙏

Thanks @leerob!!

Should be working as expected now with the updates to the vercel integration.
If not, please reopen a new issue 🙏🏼


Fix Node Fetch import

What is it?

[ ] Feature / enhancement
[x] Bug
[ ] Docs / tests

Description
Qwik recently updated to v3.x.x of node-fetch which has a default export.
https://www.npmjs.com/package/node-fetch:
import fetch from 'node-fetch';
Addresses @shairez issue in: #858
Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Thanks @nnelgxorz ! 🙏


[VS Code] [Audio] cannot stop call in Disconnected state

Error:
cannot stop call in Disconnected state
Steps to Reproduce:

Joining Collabration
Joining Audio Call
Not Working
Error when pressing disconnect

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.50

applicationName
VSCode

applicationVersion
1.33.1

platformName
Linux

platformVersion
4.15.0-20-generic

Adding @jasongin

1

macos 10.14.4

Thanks for reporting this issue! We have made some significant updates to our audio extension with the latest Live Share Audio extension release (0.1.60). I've tried to repro using Ubuntu 19.04 with the latest VS Code and VS Live Share Audio extension and haven't been able to repro. Can you try updating VS Code, and both the Live Share & Live Share Audio extensions to the latest versions and see if this fixes your issue?
If it still occurs tt would also be helpful for our investigation if you uploaded your logs here. You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

This issue has been closed due to inactivity. Thank you for reporting this issue. If you face problems with you current Live Share usage, please feel free to reopen this issue.
-Live Share team


ROX-15259: Do not show DNS flows in the inactive view

Description
This PR hides the DNS flows when we pick the "Inactive flows" option and we show it when we pick a new (third) option called "Inactive flows with DNS flows"

@vjwilson @pedrottimark I added that unit test and got it to work. You can look at this commit https://github.com/stackrox/stackrox/pull/6003/commits/46f5836fad9e4ca37b339cc9fea651e059631e49. Looks like I had to change the lines like this
modifiedData.endTerminalType = EdgeTerminalType.directional;

to something like this
modifiedData.endTerminalType = 'directional' as EdgeTerminalType;

@vjwilson @gavin-stackrox The tests have been failing consistently but they don't seem to be because of my changes (from what I can see). Any idea what I can do to fix it?

@sachaudh looks like your build is failing https://github.com/stackrox/stackrox/actions/runs/5271330663/jobs/9532051450?pr=6003


Dice So Nice Issue

As the title states, there's an issue with Dice So Nice and Delta Green where when when you roll, the default foundry dice sound effect happens and then the the Dice So Nice roll comes after so it creates a weird, unsatisfying delayed effect.

This should be resolved in v1.4.5. However as a heads up, that branch is only compatible with Foundry version 12. Mostly because @jalensailin fixed it as a part of some other v12 related Dice So Nice issues that had cropped up... I'll close this issue for now, but feel free to reopen it or start a new one if an upgrade doesn't seem to fix it.


Add Physics support in YAF specification

Add things like rigid body specification, collider shapes and more via the YAF interface.

Physics support should come in 3 ways:

Rigidbodies: support Kinematic, Dynamic and Static rigidbodies
Colliders: support various shapes defined in RAPIER specification
Joint Constraints: apply forces that move rigid bodies, and joint limits restrict that movement.


Add an ability to add a transition only for ease-in in Dialog component

Currently if I add a transition to Dialog component, the transition is applied for both in and out animation. I want to add a fancy slide-in transition to my Dialog component, but I don't want to have the same transition for ease-out. I'd like to have ease-out quick and simple like a regular fade-out.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Motivation 🔦
Based on google recommendations, discarding of a Dialog component should be quicker than appearing. Which, I believe, makes sense.
https://material.io/components/dialogs#behavior
https://developers.google.com/web/fundamentals/design-and-ux/animations/animating-modal-views

You can use a custom TransitionComponent, for example with Fade:
const CustomFade = React.forwardRef((props, ref) => (
  <Fade {...props} ref={ref} timeout={{ enter: 2000, exit: 200 }} />
));

<Dialog TransitionComponent={CustomFade}>

https://codesandbox.io/s/simpledialog-material-demo-forked-wemts?file=/demo.tsx

@michal-perlakowski thanks for the reply. That perfectly works with Fade transition. If I use Slide transition, and want to discard it quicker, and if I just add less time to exit, I see annoying flicking on the screen, as slide-out doesn't look good with small exit time. I'd like to have a regular fade-out for exit while I have slide-in. Don't know if I ask much )
https://codesandbox.io/s/simpledialog-material-demo-forked-bctzn?file=/demo.tsx

This issue can be solved with a custom TransitionComponent. The implementation of such a component is best discussed in the usual support channels.


Add "Open Code here" context menu for Nautilus

Visual Studio Code on Windows populates the context menu on Explorer with Open Code here (or something like that, I forgot). It should be the same on Nautilus. Why not include in VSCode itself?
Workaround
Using https://github.com/harry-cpp/code-nautilus:
bash -c "$(wget -qO- https://raw.githubusercontent.com/harry-cpp/code-nautilus/master/install.sh)"

Then:

References
https://github.com/microsoft/vscode-docs/issues/873
https://github.com/microsoft/vscode/issues/22036

I don't understand how this voting works. Is there a place where you advertise users to vote for the next features listing? Otherwise, how would the users know that something is a backlog candidate at a glance?
I mean, for sure you don't expect a user to dig into a 5k+ Issues in this repository for finding this, right?


libhdfs3: add log for slow read

Add log for slow read and we can get the duration of each read operation by opening debug logs.

@zhanglistar @taiyang-li @lgbo-ustc
Please take a look.

@tavplubix  Thanks for your suggestion, I have made some modifications to this Pr.
1、Add slow read logs to identify the bad performance of HDFS cluster
2、Print the duration of each read operation in the debug log
Please take a look again, thanks a lot.

Do you need them for a Pull Request in https://github.com/ClickHouse/ClickHouse? Which one?

Do you need these changes for a Pull Request in https://github.com/ClickHouse/ClickHouse? Which one?

https://github.com/ClickHouse/ClickHouse/pull/54057

Do you need these changes for a Pull Request in https://github.com/ClickHouse/ClickHouse? Which one?

@tavplubix
ClickHouse/ClickHouse#54057
Please take a look again.

See the discussion in https://github.com/ClickHouse/ClickHouse/pull/54057


New Swagger UI blocks access from container port forwarding or remote access

New swagger UI makes a base URL which usually not accessible from local debug mode.
This prevent users to remote access it.
This can be easily replayed by
docker run --name pinot-quickstart -p 9000:9000 -p 8000:8000  -d apachepinot/pinot:latest QuickStart -type batch

Then access localhost:9000 UI
Sample screenshot for docker :

Sample screenshot for k8s:

@jackjlli

Thanks @jackjlli for quick fix in  https://github.com/apache/incubator-pinot/pull/5983


Update cid-redirects.json

trying a pretty paste
Purpose of this pull request
This pull request (PR) ...
Issue number:

Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[x] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

Hi @stacykor , may I close this out?


Add a static code analysis tool

similar to Mithrill

The teams has decided to first focus in coverage, then study whether it is worth adding mythril


Usability: Should the 'NHS Number' text input use a numeric keyboard?

that seems really reasonable to me!
Rails expects this to come in as a string, does anyone know what a numeric entry comes into rails as - an integer?

We should use the markup here: https://design-system.service.gov.uk/components/text-input/#numbers


Refactor OtcMedicineObserver into just MedicineObserver

The payload is a MedicineRecord the MedicineRecord.OTC property can be used to determine appropriate logic.

Cost vs. benefit analysis indicates this is not worth the time.


BZ-1313782:  Error on startup: Unable to bootstrap project org.kie.example:project1:1.0.0-SNAPSHOT

We usually force the user to fill in the project name. In some rare cases when it does not exists we use artifactId. Because of this it makes sense to use it as project name.
+1

6.4.x: 32c9dc0bb249bef433da1ae5e6cdf1bb4f87d73a


Add a pre-commit hook

Fixes #262. Please review my PR to add lint-checking support using pre-commit. Thanks!

Sorry for the late response, I was on a week-long break. any LGTM :+1: Merging it

All good, thank you!


Package cannot access server

I tried the package today. Unfortunately Server returns:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">

<title>451 Unavailable For Legal Reasons</title>

Forbidden

We can not allow access to /fahrinfo/api/location/queryWeb?q=hauptbahnhof

Check out Bayern Fahrplan

Apparently the header of the get request (in this line) just needs a User-Agent field.
Like this one from the MMM-mvgmunich project:
"User-Agent": "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.110 Safari/537.36"

Perfect, thanks a million had same issue now appears to be operational again.

Sorry for the wait, I'll push a new release in a bit :)


Re-introduce spring.application.name in all the generated apps throug…

…h the plugin
Resolves #14

LGTM, merging ...


Feature request: prefix styles with text-fluid

Or at least have the option to. ie text-fluid-lg, that way they can be used alongside fixed font sizes. Thanks!

Thought about it but I think I can a add a prefix like fluid- to make this possible.

Hurray! Thanks. :)


[ITensors][Enhancement] Add logarithmic inner product of two MPS with MPO

Description
This adds a logarithmic inner product <x|A|y>  as logdot(x::MPS, A::MPO, y::MPS) and with alias loginner. A test of the new functionality has been added. The implementation of dot in mpo.jl has been moved to _dot, with a boolean argument switching between either normal dot product or logdot.

[test ITensors mps]

@b-kloss looks like one of the tests failed because the inner product done in the test you added was randomly negative. Probably can just add a check for that and switch to complex if needed.

It was not handled properly in the test (not inside loginner), fixed it. I was wondering whether it would be better to rename _dot to _log_or_not_dot to be consistent with the naming in abstractmps.jl.

Yeah, let's stay consistent with the MPS * MPS code.

[test ITensors mps]

Thanks!


Improve structure of core and plugins for lib and cli

WIP
Conceptual hierarchy:

cli dependsOn lib
other plugins dependOn lib
lib depends on core

Lib
The lib module exposed a lib for all platforms.
This includes an npm module (that does not offer cli integration)
Cli
The cli module exposes executables for all platforms, native, js, and jvm(?)
This includes an npm module that offers cli integration, and includes / depends on the other npm module.
Checks:

[ ] Test integration with intellij plugin
[ ] Test integration with vscode plugin
[ ] Test npm integration locally
[ ] Add tests
[ ] Add documentation about module structure

From a code organisation perspective I get why it is better to split the cli and lib into two package.
From a consumer perspective I think it is beter to have one npm package published (@flock/wirespec).

One package is simple to document and understand.
With two packages versions can go out of sync wich can give unexpected behavior.
The code in both packages will be almost the same
Package size is not an issue they are relative small and will be tree shaked when bundled with an app.

From a code organisation perspective I get why it is better to split the cli and lib into two package.
From a consumer perspective I think it is beter to have one npm package published (@flock/wirespec).

One package is simple to document and understand.
With two packages versions can go out of sync wich can give unexpected behavior.
The code in both packages will be almost the same
Package size is not an issue they are relative small and will be tree shaked when bundled with an app.

We could make the cli js lib expose both, and not expose an npm module from the lib folder, maybe? That way, we can still expose libs in the lib (mostly maven/gradle deps), and consider npm modules and native clis the other module. If need be we could have an npm module, and a cli module, to split stuff, te ensure we can generate the typescript definitions.
core -> core
lib  -> maven/gradle libs
cli -> native clis
npm -> npm module (non multplatform)

I have tried to expose the lib via the cli module. Then the typescript issue occurred. That is why the npm module was introduced. This module only has a js source set. Maybe the location of the module in plugins is a bit wierd. To me it makes sense to have one module to control what is published to npm


feat: Netlify edge function

Description
Uses edge functions folder and converts image edge function to use Deno
TODO

[x] Figure out why /user/[userName]/highlights route is failing
[x] Try removing @ts-ignore directives in edge function

What type of PR is this? (check all applicable)

[x] 🍕 Feature

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

I found something interesting in the latest deploy log. There is an error happening when bundling the edge functions
10:57:36 AM: Packaging Edge Functions from netlify/edge-functions directory:
10:57:36 AM:  - card
10:57:40 AM: Could not load configuration for edge function at '/opt/build/repo/.netlify/edge-functions/next_middleware/index.ts'
10:57:40 AM: error: Uncaught (in promise) SyntaxError: The requested module '../log/logger.ts' does not provide an export named 'detachedLogger' at https://edge.netlify.com/bootstrap/util/redirect.ts:3:10
10:57:40 AM: const { Netlify } = await import(bootstrapURL)
10:57:40 AM:                     ^
10:57:40 AM:     at async file:///opt/buildhome/node-deps/node_modules/@netlify/edge-bundler/deno/config.ts:4:21
10:57:40 AM: Could not load configuration for edge function at '/opt/build/repo/netlify/edge-functions/card.tsx'
10:57:40 AM: error: Uncaught (in promise) SyntaxError: The requested module '../log/logger.ts' does not provide an export named 'detachedLogger' at https://edge.netlify.com/bootstrap/util/redirect.ts:3:10
10:57:40 AM: const { Netlify } = await import(bootstrapURL)
10:57:40 AM:                     ^
10:57:40 AM:     at async file:///opt/buildhome/node-deps/node_modules/@netlify/edge-bundler/deno/config.ts:4:21
10:57:40 AM:
10:57:40 AM: (Edge Functions bundling completed in 3.8s)

I found something interesting in the latest deploy log. There is an error happening when bundling the edge functions
10:57:36 AM: Packaging Edge Functions from netlify/edge-functions directory:
10:57:36 AM:  - card
10:57:40 AM: Could not load configuration for edge function at '/opt/build/repo/.netlify/edge-functions/next_middleware/index.ts'
10:57:40 AM: error: Uncaught (in promise) SyntaxError: The requested module '../log/logger.ts' does not provide an export named 'detachedLogger' at https://edge.netlify.com/bootstrap/util/redirect.ts:3:10
10:57:40 AM: const { Netlify } = await import(bootstrapURL)
10:57:40 AM:                     ^
10:57:40 AM:     at async file:///opt/buildhome/node-deps/node_modules/@netlify/edge-bundler/deno/config.ts:4:21
10:57:40 AM: Could not load configuration for edge function at '/opt/build/repo/netlify/edge-functions/card.tsx'
10:57:40 AM: error: Uncaught (in promise) SyntaxError: The requested module '../log/logger.ts' does not provide an export named 'detachedLogger' at https://edge.netlify.com/bootstrap/util/redirect.ts:3:10
10:57:40 AM: const { Netlify } = await import(bootstrapURL)
10:57:40 AM:                     ^
10:57:40 AM:     at async file:///opt/buildhome/node-deps/node_modules/@netlify/edge-bundler/deno/config.ts:4:21
10:57:40 AM:
10:57:40 AM: (Edge Functions bundling completed in 3.8s)

This error magically went away after clearing the cache and rebuilding. I think this issue is resolved now

@foxyblocks nice. We're ready to review if you are

@foxyblocks nice. We're ready to review if you are

@brandonroberts There's a few TODO items here, lemme finish those up first

Looks like the /user/[userName]/highlights route is encountering a client side error on the deploy preview https://deploy-preview-1400--oss-insights.netlify.app/user/foxyblocks/highlights

Going to turn on production sourcemaps and see if I can get a better error

Looks like the /user/[userName]/highlights route is encountering a client side error on the deploy preview https://deploy-preview-1400--oss-insights.netlify.app/user/foxyblocks/highlights
Going to turn on production sourcemaps and see if I can get a better error

This resolved itself after a bunch of debugging and when I reverted a version upgrade of esbuild in the package.json and re-deployed. Seems weird that that would have caused the issue but it's fixed now

The last thing I would maybe want to do for this is have an e2e-test in place for the edge-function. Ideally I'd want the test to run in an environment that's as close to production as possible because there seem to be a lot of variables that can make this not work and I ran into many cases where things were working fine locally and failing in the previews.
Maybe we could have a test that waits for the deploy preview to finish and then runs a quick request to check the status code or something like that.

@foxyblocks cool. We can definitely look into adding an e2e test as a follow-up


Update custom-metrics.md

🚀 Deployed on https://661ed3e58132076df03bece9--cozy-fox-0defec.netlify.app


Exceptions that are ignored open the circuit

Basically that's it.
When I place in the @HystrixCommand configuration the option ignoreExceptions=FunctionalException.class and I throw that exception, after a while throwing it, the circuit opens. Is that a correct behavior?

Closed? Why?


[FEATURE] JRTB-5: As a user, I want to add the group to the subscription

https://github.com/JiLaRiAtIoN/javarush-telegrambot/pull/22


update concepts folder link

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
update link
Issue reference
resolve https://github.com/dapr/docs/issues/4285

@holopin-bot @Arhell Thank you!


Annotation aliases

[ ] Move Annotations to util?
[ ] This needs some tests in RepositoryTest
[ ] Handle conflicting annotations, e.g. a meta-annotation + @Column. Do we fail here? Do we try to merge these? Do we fail if both annotations contain overlapping attributes?


Generate protobuf classes from external jar

I have the need to use messages from a third party jar that contains *.proto definitions for their interface.
I do not need to write any *.proto messages myself but only need to generate Scala classes from their jar that contains the message definitions.
How can I do this using sbt-protoc? I attempted to do
PB.protoSources in Compile := Seq((target)(_ / "protobuf-external").value)
As well as add the jar to my library dependencies but that does not work.
Is this a capability of sbt-protoc? I can see the *.proto files in the /target/protobuf_external directory but can't seem to generate them.
Thank you for the help

I was unable to reproduce this problem. I added the line you included above in one of my example projects and the external protos were generated and compiled. Can you publish a minimal example?

Will do. I'll update the thread when I have it.

I've just noticed that in your code snippet you wrote protobuf-external though it should be protobuf_external (with an underscore) - which could explain why it does not generate code for the dependencies.
I added a question to the FAQ about generating code for external JARS: https://scalapb.github.io/faq.html
Here is an example where it is used in a multi-project build:
https://github.com/thesamet/sbt-protoc/tree/master/examples/multi-with-external-jar


Watch fails by 'JavaScript heap out of memory' when watching tsx files

TypeScript Version:  nightly (2.0.2)
Node Version: 6.4.0
Code
jest.tsx
import * as React from 'react';
import { shallow, mount } from 'enzyme';
import App from '../src/components/App';

describe('Test environment tests', () => {
    it("should work", () => {
        expect(1 + 1).toBe(2);
    });

    it('should work with react components', () => {
        const wrapper = shallow(<App />);
        expect(wrapper.contains(<div/>)).toBe(true);
    });
});

Expected behavior:
I will fail with the following error when watching using vscode:
4:53:40 PM - File change detected. Starting incremental compilation...
<--- Last few GCs --->
  155816 ms: Mark-sweep 1310.1 (1434.2) -> 1310.1 (1434.2) MB, 1924.0 / 0 ms [allocation failure] [GC in old space requested].
  157725 ms: Mark-sweep 1310.1 (1434.2) -> 1310.1 (1434.2) MB, 1909.8 / 0 ms [allocation failure] [GC in old space requested].
  159675 ms: Mark-sweep 1310.1 (1434.2) -> 1310.1 (1434.2) MB, 1949.4 / 0 ms [last resort gc].
  161675 ms: Mark-sweep 1310.1 (1434.2) -> 1310.1 (1434.2) MB, 2000.2 / 0 ms [last resort gc].
<--- JS stacktrace --->
==== JS stack trace =========================================
Security context: 0x3d384a7c9e31 <JS Object>
    1: instantiateList [/usr/lib/node_modules/typescript/lib/tsc.js:~17703] [pc=0x1122188fa154] (this=0x3d384a7e0fa9 <JS Global Object>,items=0x3c9bf043bf51 <JS Array[1]>,mapper=0xf92614d0811 <JS Function (SharedFunctionInfo 0x8a96e8edb01)>,instantiator=0x1b5df291ed01 <JS Function instantiateSymbol (SharedFunctionInfo 0x5b9624afa79)>)
    2: instantiateSignature [/usr/lib/node_modules/typescrip...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
 1: node::Abort() [node]
 2: 0xff6e1c [node]
 3: v8::Utils::ReportApiFailure(char const*, char const*) [node]
 4: v8::internal::V8::FatalProcessOutOfMemory(char const*, bool) [node]
 5: v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
 6: v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 7: 0x112218106338

Watching build tasks has finished.

Actual behavior:
It should recompile the changed files.

Seems to be related to https://github.com/Microsoft/TypeScript/issues/10759 (high memory consumption when compiling enzyme)

@vladima, yes my problem is related to enzyme. Event if I don't use enzyme in my code but have the type declarations installed, the error occurs

looks like the same issue as  #10759. both are attributed back the enzyme .d.ts file.


Technical solutions to support a SHOULD for back navigation during the booking flow are missing

Concerning the tech spec proposal #4 to implement a "booking" flow for passengers, we consider the "back" UX navigation pattern as optional. As per the RFC 2119, carpool operators MAY implement this pattern so that passengers can go back to the MaaS app.
Currently this is optional due to technical limitations that exist in many cases today. For example:

Passengers that don't have the app installed, may be redirected first to the app store to install it. Then they may have to go through the operator's onboarding before starting the booking flow
Operators may choose to open a third-party url first before redirecting to the app
Operator or MaaS apps may have their own navigation systems in place, with custom screens that override the operating system default behavior

In all the above cases it is not trivial to implement a solution where the user can use the operating system "back" UX pattern to return from the operator to the MaaS app.
Until those technical difficulties are addressed, we cannot propose that operators SHOULD provide a back navigation.

@osarrat proposed an interesting way to pass some arguments during search, before the booking flow occurs to take them into accounts in deeplinks and after during the booking by deeplink process, in PR https://github.com/fabmob/standard-covoiturage/pull/6 ...
We could maybe take inspiration on that by adding something like a callbackUrl which would be the "Return to the MaaS" URL for the "back" functionality ?
This wouldn't be so complex for the operator and we could use a SHOULD instead of MAY ?

Following today's discussion, I made a new proposal for a converged (API + deeplink) booking in PR https://github.com/fabmob/standard-covoiturage/pull/18
In this case, passengerOperatorUrl (if the MaaS provides a passenger) could be used as callback URL to solve this and send back to the MaaS ?


Thinking in react

Keep up the good work! 👍

@miku86 Do you have time to finish this translation because my suggestions were made some time ago?

@miku86 Do you have time to finish this translation because my suggestions were made some time ago?

Thanks for the reminder.
I have blocked 2hrs on saturday for this.

Hey folks,
please have a in-depth look at this.
I highlighted state and props multiple times to emphasize the importance.
Thanks.

Great! If we don't change the meaning, I think it's okay. We should also always think about how we would like to read this document. 1:1 translation sometimes sounds really strange and I think one of our tasks is to make it readable for all developers.


Memory leak in Azure Core caused by throwing exception pointer

https://github.com/Azure/azure-sdk-for-cpp/blob/12b389a5790c484f98fbdb95fab6a8dccda5b46e/sdk/core/azure-core/src/http/curl/curl.cpp#L24
https://github.com/Azure/azure-sdk-for-cpp/blob/12b389a5790c484f98fbdb95fab6a8dccda5b46e/sdk/core/azure-core/src/http/curl/curl.cpp#L29
https://github.com/Azure/azure-sdk-for-cpp/blob/12b389a5790c484f98fbdb95fab6a8dccda5b46e/sdk/core/azure-core/src/http/curl/curl.cpp#L527
https://github.com/Azure/azure-sdk-for-cpp/blob/12b389a5790c484f98fbdb95fab6a8dccda5b46e/sdk/core/azure-core/src/http/curl/curl.cpp#L535

https://stackoverflow.com/questions/2023032/catch-exception-by-pointer-in-c
https://stackoverflow.com/questions/10948316/throw-new-stdexception-vs-throw-stdexception


Is it possible to import it in a ES6 module ? (front-side)

I'm trying to use the package to implement a fuzzy search in a React component.
I don't want to use UMD.
I'm trying to import the module like so:
import stringSimilarity from 'stringSimilarity'
Node throw: Cannot find module 'stringSimilarity'.
Is it possible with this package ?

import stringSimilarity from 'string-similarity'


page.window_frameless not working properly in windows

Description
page.window_frameless, when set to True, in windows, we're unable to drag the application. However, we are able to drag the application in mac. Please provide the solution.
Code example to reproduce the issue:
page.window_frameless = True

maybe try this ?

Could you please provide a code to reproduce the issue?

How about this
import flet as ft

def main(page: ft.Page):
    page.title = "Say Hi"
    page.window_title_bar_hidden = True

    def print_hi(e):
        list_names.append(ft.Text(value=f"Hello {first_name.value} {last_name.value}"))
        first_name.value = ""
        first_name.focus()
        last_name.value = ""
        page.update()

    list_names = []
    first_name = ft.TextField(label="first name", autofocus=True)
    last_name = ft.TextField(label="last name")
    say_hi = ft.ElevatedButton(text="Say Hi", on_click=print_hi)
    text_hi = ft.Column(list_names)
    col = ft.Column(
        spacing=3,
        controls=[
            first_name,
            last_name,
            say_hi,
            text_hi,
        ],
        expand=True,
    )
    wda = ft.WindowDragArea(col, expand=True)
    page.add(wda)

ft.app(target=main)


upgrade to angular 1.7

1.6 may be a bit painful:
https://toddmotto.com/angular-1-6-is-here

Briefly tried it - seems like some issues with ui-grid.

Moved this to target 1.7


Looping sound on ios9

Playing a looping sound on fileload causes the file looping to have a gap of time that is relative to the time waited before tapping the screen and enabling sounds.
Example can be seen here: https://dl.dropboxusercontent.com/u/8932415/ios_sound_loop/index.html
If you wait few seconds before tapping the screen then there's same amount of seconds between the loops.
In 6.1 the same problem does not occur if I listen manually to the touchend -event and start at that point:
https://dl.dropboxusercontent.com/u/8932415/ios_sound_loop/index_6.1.html
Same problem occurs in 6.1 also if I start the sound before enabling sounds:
https://dl.dropboxusercontent.com/u/8932415/ios_sound_loop/index_6.1.html
Is this an issue that can be fixed or should I handle the startup of background sounds manually on ios?

Tested the issue without soundjs and couldn't replicate it:
https://dl.dropboxusercontent.com/u/8932415/ios_sound_loop/index-nosoundjs.html

+1

+1
Having same issue when locking/unlocking device


management/osimage: implement ReplicateImage/UnreplicateImage

Hi @mischief, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Closing as this is Private API. https://github.com/Azure/azure-sdk-for-go/pull/391#issuecomment-243882801


storage: Use gocheck for tests

cc: @paulmey

merging for now as it's just mostly dumb code conversion, you can review later.
fixed two test bugs (false positives) already, so I would be surprised if you find anything to comment on.

:+1:


contribution: max-file-line-count

Hi,
please consider:
https://angular.io/guide/styleguide
Consider limiting files to 400 lines of code.

"max-file-line-count": [true, 400]

Maybe this helps :)

:tada: This issue has been resolved in version 1.14.4 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


check for valid bed file before running the pipeline

check to make sure the bed file is sorted without overlapping regions before running the pipeline

fixed in https://github.com/NCI-CGR/GEMSCAN/commit/2ffda5ffc8fdb2c31eab2ff3d5422b96c24edbaf


NavController.goForward() query params don't work

Bug Report
Ionic Info
Ionic:

   ionic (Ionic CLI)          : 4.1.0
   Ionic Framework            : @ionic/angular 4.0.0-beta.2
   @angular-devkit/core       : 0.7.3
   @angular-devkit/schematics : 0.7.3
   @angular/cli               : 6.1.3
   @ionic/ng-toolkit          : 1.0.6
   @ionic/schematics-angular  : 1.0.5

System:

   NodeJS : v8.11.3
   npm    : 5.6.0
   OS     : Windows 10

Describe the Bug
Query params passed via NavController.goForward() are not appended to the URL.
Steps to Reproduce

Create starter app: ionic start myApp sidemenu --type=angular
Add button to side menu (or anywhere), wire to following handler:

test(): void {
      this.navController.goForward(`/list`, true, { queryParams: { dummy: 4 }});
  }

Expected Behavior
When clicking button, browser should navigate to "/list?dummy=4". Instead it navigates to "/list" without query param.

After some more testing, it seems like this might be an issue with the Angular router. Router.navigateByUrl() ignores NavigationExtras.queryParams. If NavController is using that under the hood it explains the problem.
Is NavController going to be supported going forward? It's not currently in the v4 beta docs. Should we be using Angular Router instead? If so, how do we handle the "direction" indication that Ionic uses for animations?

You can use Router to send a queryParams:
test(): void {       this.router.navigate('/list', { queryParams: { dummy: 4 }});   }

Sure, but then you lose the forward/back/root hints that Ionic (maybe) uses. Really I just want a clear answer from Ionic team on which we should be using going forward in an Ionic project.

+1
This is quite important.

Thanks for the thread. Also need to know what to use - how to have the back/forward functionality, if we are going to have that...

@MichaelMalony I tested it with beta.12 and it's working now. Could you test it and close this issue, if it works for you too?

Hello, I am using beta.12, and it works only if I use the URL as array:
this.router.navigate( ['/list'] , { queryParams: { dummy: 4 }}); }   WORKS
this.router.navigate( '/list' , { queryParams: { dummy: 4 }}); }   NO QUERY PARAMS

Yes, router navigation is a feature of Angular, not Ionic. I also did it with the array and this worked for me.

Closing since it looks more like a angular issue than a ionic one! thanks everyone for figuring this out!


Update README.md to enter a Base URL

I just setup the Happy Lager site following the README.md instructions. Everything worked until I tried to view one of the News entries. The CSS was not loading. In the _layouts/base.html file, I found:
<link rel="stylesheet" type="text/css" href="{{ siteUrl }}assets/fonts/stylesheet.css">
<link rel="stylesheet" type="text/css" href="{{ siteUrl }}assets/css/happylager.css">

Under Settings > Sites > Happy Lager (en) the Base URL was not set. It might be helpful to add a note in the README.md to set this field.

This should be fixed now per 97b3a00486c7faea3e7fbcbdedf8f888f1d00f9d. Now the site URL is based on a SITE_URL environment variable, and a default value of http://happylager.test is provided by the .env.example file.


Newsletter does not work

When I fill an email in the newsletter field and click the subscribe button, the user does not get added to it. I am not sure like do I have to follow some steps for that or was something wrong with my configuration. Can you help me with this?

Yes sure.
My website is Thinkbrew. I am using Mailgun to send emails and am able to send mails if I manually add the members in the dashboard, but when I try to add an email through the newsletter the email does not get added to the mailing list.

It seems like you didn't check if your url value in your Ghost config file uses https as I suggested.
Currently your website has the following errors:

Those errors are generated because the url value in your config file still uses http, therefore the subscription form doesn’t work.
Once you fix that issue it should work fine. If you don't know how to change the url value please ask in the Ghost forum since that is not related to the theme.

I am not able to send email too! My config.production.json is fine. I have set up mailgun through ghost dashboard.
My ghost version is 5.2.3. I was able to run this theme on ghost v5 with some tweaks.
It's currently throwing error 504 :/
Any help pls!


Screen Glitch after changing theme

Unable to revert foreground color of the text in input screen widget after changing theme.
Works completely fine initially, but glitch occurs after changing the themes making the selected text not visible.

Fixed this issue by making changes in the change() function in script.

Fixed this issue by making changes in the change() function in script.


Add done button

Fixed in https://github.com/ethercreative/react-native-date-input/commit/e7694f233acaa00a96d9261035cb873234f199e9


Fix/PC console bid completion count

Load Bid and Recommendation invitations and to get correct task completion count.
Fixes #652

Thanks, I missed that we were already getting invitations. I realized there was one other thing I needed to confirm before this was merged: currently the PC console is treating taskCompletionCount for AC Recommendations as the number required per paper. Is this correct?

yes, that's correct.

OK, I think this is ready to merge then.


@sweir27 => [Feature] Add reset filters button to /auction/:id

This PR adds a little Reset Filters button to the sidebar component that when clicked resets filter state.

TODO:

[ ] Write tests

@katarinabatina - I winged it with this design; thoughts?
cc @devangt

@damassi thanks for the contribution here, to ensure continuity with other filtering on the site I'd like to think about this issue a bit more before shipping it. Mind if we park this for the moment?

@katarinabatina - sure thing, but note that we've had a few requests for this feature in the last week.

@damassi good to know, in the future if you wanna make a ticket and mark it as needs design ping me and @devangt we'll get it prioritized.

@katarinabatina - will open ticket now.
@sweir27 - Re /collect pages, there's no reset button that I could find, otherwise I would have piggybacked on that.

Closing this until CE UI revisit completes.


running the game on deterministic mode

Hi,
I would like to run the game in deterministic mode, as described in the blog post:

Second, to investigate the impact of randomness, it can be run in both a stochastic mode (enabled by default), in which there is randomness in both the environment and opponent AI actions, and in a deterministic mode, where there is no randomness.

How can I enable this? Thanks in advance.

https://github.com/google-research/football/blob/master/gfootball/scenarios/11_vs_11_stochastic.py#L25
You have to modify or create your own scenario and change that flag.


Feature request: provide gizmo lines for applied external forces

Hi, this project is great, congrats and thanks!
While trying it, I've realized that iterating through game dev can be painful.
Suggestion

Provide gizmo lines as part of the PhysicsGizmos that showcase the externally applied forces. I suppose with a simple line in the normal of the force would be enough.
Provide a configurable option in PhysicsDebugConfig to configure the maximum length of the lines, and the expected maximum force. This way one can tune the scale of the lines for them to be visible and useful.

Hi! In #324, I added publicly accessible contact impulses (for forces, divide by delta time) and support for rendering them. The scale can also be customized, although you can't set the maximum length at the moment.
This is only for contacts for now, and doesn't include gravity, ExternalForce, or joints. I could definitely support rendering those too though, and especially joints might be useful.
It might also be nice to visualize the total force or acceleration of a body. This would include gravity, ExternalForce, and all of the contact and joint forces. Things like the user abruptly setting the velocity to a specific value probably shouldn't be counted towards the force though.


Renaming of current serialisers

All current serialisers could be renamed from e.g StringSerialiser to StringToBytesSerialiser following gh-886. To remove ambiguity from other future types.
We could deprecate the old classes to be empty extensions of the new class names.

Migration
Json schemas with serialiser will require renaming to the new formats

Serialisers added in #988 have been named to match this ticket.

We should wait until we next plan to do a major release before we make this change, due to the migration required.

Rather than doing this, bytes will be the default output type. All serialisers that serialise into anything other than bytes should have a class named accordingly. So for serialisers that output bytes we don't need to put ToBytes in the class name.


Set google ad campaign script up

Im trying a google ad campaign, i think we need to put this somewhere
<!-- Google tag (gtag.js) event -->
<script>
  gtag('event', 'ads_conversion_PAGE_VIEW_1', {
    // <event_parameters>
  });
</script>

What are the event parameters?


psnr_ssim.py: error: unrecognized arguments: --dir2 celeba-hq_sample/src

After runing bash eval.sh, the following error occurred:
RuntimeError: Invalid path: res/img
usage: psnr_ssim.py [-h] [--dir0 DIR0] [--dir1 DIR1]
psnr_ssim.py: error: unrecognized arguments: --dir2 celeba-hq_sample/src

It's a mistake in eval.sh. We will fix it later. You can change the argument --dir1,2 to --dir0,1.


manila: Fix tempest issues

The read_write_two_vms tests are known to fail because the share
doesn't cleanly unmount when it is shared to more than one vm[1], so
blacklist them. We also need to create the default share type with
snapshot support explicitly set, otherwise the snapshot tests will fail
with message "Snapshot cannot be created from share $id, because share
back end does not support it."
[1] https://bugzilla.suse.com/show_bug.cgi?id=1137262
This combined with https://review.opendev.org/662255 and https://review.opendev.org/664434 should fix the failing manila tests in the tempestfull job for cloud9.

@flaviodsr could you please check if/how we create the default share type for manila in Ardana ? I didn't see anything like that in #3479. Also, how come we don't need to disable these test cases in Ardana too ?

@flaviodsr could you please check if/how we create the default share type for manila in Ardana ? I didn't see anything like that in #3479. Also, how come we don't need to disable these test cases in Ardana too ?

The default backend configured for ardana is CephFS native (the one mentioned by the ardana documentation) and there is no scenario test for CephFS native.


Front-end support for more flexible long-term subscription options

Allow displaying either annual or lifetime subscriptions (relying on the server to send the relevant products).

We can merge this without the server piece for deploy today.
Added commits to fix nitpicks.


Tool tip

It seems the input fields have become shorter. Was this intended? We should discuss with @snakeround if we should keep the input fields the same length.
Also, some of the tooltips don't appear in the right direction, they go off-screen.
Furthermore, I don't see the following tooltips:

Hppd calculations
Staff type
Quantity
Shift
Shift Total


[Issue-2465] Update chainlist

Related issue(s)
#2465
Is your feature request related to a problem(s)? Please describe.

Update chain list providers

Describe the solution you'd like

Update default provider for Parallel: set to Dwellir
Add providers for Polkadex
Update endpoint value for provider Parallel of chain Parallel

Describe alternatives you've considered

No

Additional context

No

🚀 Deployed on https://pr-2470--sw-web-runner.netlify.app


Honey pot UI

Motivation and context

Added UI for the Honey Pot feature

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have added a description of my changes into the CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (see GitHub docs)
[x] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

Information about comments

[x] Fixed aligns of preview and assignee on task page
[x] Added margin in the end of job list on task page
[x] Solved/Unsolved issues for Job are kept on place, we can think about removing them in PR with analytics page

[x] Copy Job list button was restored to it's place
[x] Added borders and border highlight like on task card for job card
[x] Changed "0%" to "<1%"

[x] Submit and Submit and Open button. I think we should keep those buttons for consistency. In any case user can decide by himself what he wants, just create and go back or immediately go to GT job
[x]  About GT job issues and participating in computing completion progress
These jobs still have to be annotated and reviewed by someone in the annotation team, it makes sense to treat their progress equally with other jobs.
[x] Space in submit form.
Personally, I think without it, form looks too short and page becomes empty.
[x] Frame intercesction (as all data on Quality page) is extracted from Quality report, so currently we wont show it immidiately
[x] Tracks are now shown only on frames included in GT job
[x] Object menu in object sidebar is removed for GT annotation
[x] Sorting for conflcits/quality is fixed
[x] Frame intersection N/A and no ability to download the report means the report doesn't exist yet. We need to wait for it to be computed
[x] With fixed problem with tracks, there won't be any annotations on jobs with 0% intersection
[x] 2d cuboids and tags wont supported in this version
[x] Automatically go to the next frame in tag annotation mode
[x] Find empty frame navigation in GT job
[x] Delete frame in GT job
Currently deleted frames are marked for a task, so deleting frame in GT deletes it everywhere. It really doesn't make sence to support deleting frames in GT jobs, So lets disable that option for now
[ ] Broken top margin in the frame filter configuration dialog in the annotation page

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

@klakhov
May we align task preview a little bit?

And stick Assignee field to the right:

I would suggest adding a little margin at the end of this page:

Do we need this "Solved"/"Unsolved" issues here? Looks like now this is information for "analytics" page.

With a little vertical gap (8px) it looks better IMHO:

In this PR we lost this button. It is expected?

Need to add border color as for tasks on project page:

Last updated filter does not work as expected. It does not show anything.

"0%" -> "< 1 %"

Do we need both "Submit" and "Submit and open" buttons if we only can create on Job?

Any issues for GT job are unexpected:

It is not convenient to put GT jobs to "Completed", "Acceptance". First need to put it to "Acceptance" on task page, then open the job and in annotation menu set "Completed". If we first set "Completed", then "Acceptance", "Completed" will be reset to "New".

On annotation view it shows "Missing annotation" only on one frame. On others it does not, but it is still missing (all the objects are tracks)

This menu should not exist for GT annotations:

I am not sure, that sorting by "Conflicts" and by "Quality" works:

What is difference between frame intersection N/A and 0%?

How is that possible that jobs with 0.0% intersection frames have GT annotations?
Yes, all annotations are tracks. But we annotated GT annotations on random frames. For example on frame 10 and 100.
And we can't guarantee that on frame 50 the interpolated object is correct. But it is considered as GT in job with frame 50.
What's more I have a job with one frame 300 (the latest frame of the task).
But the latest frame in GT job is 294.
So, I still have GT annotations on frame 300 where I didn't annotate anything.

On GT job I do not have any masks annotated. Mask is a shape only, it can not be even interpolated.

@bsekachev,

Any issues for GT job are unexpected

I do not think GT jobs should participate in computing completion progress

These jobs still have to be annotated and reviewed by someone in the annotation team, it makes sense to treat their progress equally with other jobs.

It is not convenient to put GT jobs to "Completed", "Acceptance". First need to put it to "Acceptance" on task page, then open the job and in annotation menu set "Completed".

There is the button for this in the job actions menu:

How is that possible that jobs with 0.0% intersection frames have GT annotations?

Can it be a percent truncation problem? Maybe, there's just 1 common frame giving something like 0.04, which is being truncated by the UI.

Yes, all annotations are tracks. But we annotated GT annotations on random frames. For example on frame 10 and 100. And we can't guarantee that on frame 50 the interpolated object is correct. But it is considered as GT in job with frame 50.

How would you suggest to resolve the problem? This is the same for frame step.

One more bug in tag annotation mode with enabled option "Automatically go to the next frame"

It opens frame absent in GT job.

It does not detect missing tags.
Is it expected?

Find empty frame feature navigates to not existing frames in GT job:

[ ] I removed frame 20 in GT job and it is removed in a regular job

@bsekachev, tags and cuboids are not supported yet.

@klakhov

Submit and Submit and Open button. I think we should keep those buttons for consistency. In any case user can decide by himself what he wants, just create and go back or immediately go to GT job

There is no reason to stay on "Create GT job" page after GT job is already created because several GT jobs can not be created.
Two options I see: open GT job immediately, return to analytics page.

@bsekachev

There is no reason to stay on "Create GT job" page after GT job is already created because several GT jobs can not be created. Two options I see: open GT job immediately, return to analytics page.

Ok, I see. Let's stick to the first option

Okay, let's solve conflicts wait for Andrey review and I believe we can merge it

[ ] It seems the report computation time info is missing (it was under the downloading button)

[ ] Job actions menu needs to be fixed: the 3 to "Go To ..." buttons have no use outside the annotation window, probably need to add the black border around the menu

[ ] Job frame filter has invalid top margin (it's a regression against develop)

[x]  It seems the report computation time info is missing (it was under the downloading button)
Fixed
[ ]  Job actions menu needs to be fixed: the 3 to "Go To ..." buttons have no use outside the annotation window, probably need to add the black border around the menu
This menu is mutual for Jobs cards(on task and jobs pages), those buttons are used on Jobs Page mostly. I dont think we need 2 different menus
[x]  Job frame filter has invalid top margin (it's a regression against develop)
Fixed

This menu is mutual for Jobs cards(on task and jobs pages), those buttons are used on Jobs Page mostly. I dont think we need 2 different menus

Ok, but job menus on the task page have the same problem - the "Go To" buttons are not needed there.

Codecov Report
Attention: Patch coverage is 24.16201% with 543 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (ea6c68f) to head (4775e3f).
Report is 1451 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6039      +/-   ##
===========================================
- Coverage    81.17%   80.12%   -1.06%
===========================================
  Files          322      331       +9
  Lines        37782    38431     +649
  Branches      6821     6923     +102
===========================================
+ Hits         30670    30792     +122
- Misses        6803     7329     +526
- Partials       309      310       +1

Components
Coverage Δ

cvat-ui
74.68% <24.16%> (-2.03%)
:arrow_down:

cvat-server
85.16% <ø> (-0.02%)
:arrow_down:

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Add OpProviderStrict and OpProviderGeneric

Makes OpProvider a basic interface not to be exposed to providers' implementations. The choice is now between OpProviderGeneric (not tied to the task's return type) and OpProviderStrict (tied to the task's return type).

I am actually not sure I agree we need to make onSuccessStrict abstract. There are cases where the Provider's author needs type safety with respect to the returned value of the Task without the need to execute anything in case of Task's success. After all, for OpProviderGeneric the onSuccess method is not abstract either.

@jocke third opinion on the abstract thingy?

I don't see the reason why it has to be abstract in the strict case if the generic one is non-abstract. It should be both or either.

I don't see the reason why it has to be abstract in the strict case if the generic one is non-abstract. It should be both or either.

Agree. Removing abstract and merging 👍


Use colorization mode by default

Please make the new colorized mode feature enabled by default.

Reasons: #6

Fixed in v1.2.


Entire Premise is Flawed

This product should not exist in its current form. There is nothing wrong with preventing the debugging or reverse engineering of content that YOU hold copyright to
But there is something VERY wrong with interfering with use of the developer tools on a page that belongs to ME, is in active development, and is costing me money every day that bugs don't get fixed. This is not a hypothetical situation: there exists a company which distributes streaming video channels via a player intended for embedding via iframe in somebody else's website... This company, Company A, has chosen to use disable-devtool to protect their assets.
Then there is another company, Company B, who has added features such as multi-lingual subtitles to the content provided by the first company.  They have accomplished this by embedding Company A's player into an HTML document, loading the subtitles from an API, and then displaying them on top of the video...
Then there is Company C, which belongs to me. I am a customer of Company B - and I embed Company B's player into the UI for my own app... Specifically, I embed it into a page which contains: metadata and artwork about the item of content being played in the player, 20 recommended or related content items that the user may wish to view next, a buggy and ill conceived attempt at a fancy responsive nav that need to be refactored, AND AN AI CHATBOT THAT COMMUNICATES WITH THESE OTHER PIECES VIA POSTMESSAGE.
Because Company A has chosen to use the disable-devtool package, Company B is forced to include it in their offering to the customer, Company C, who then embeds it in an extremely complex JS app, only to find that the player works perfectly - but that it takes 3 times longer than normal to fix bugs in their front end code... Company C first works around the problem by substituting the offending player with a placeholder (most of the features on the parent page do not directly interact with the actual video stream) - but it proves to be a giant pain in the ass switching back and forth, and finally one of Company C's competitors, who also uses the player from Company B, takes pity on C's founder and points him to a plugin that DISABLES THE DISABLE-DEVTOOL.
Why don't you do the dev world a favor and stop maintaining this package, because it is literally malware - yes, i think anything that makes it impossible for me to use my browser devtool to debug code I wrote myself definitely qualifies as malware (and it doesn't just break the debugger - I can't even inspect the DOM because opening the devtool causes the location.href to navigate away to a different page!)

@samrahimi Exactly the problem I was facing a few months ago, gave up quick, after having a word with Company A. @theajack facilitates these abhorrent developers, giving them the toolkit to absolutely destroy DX.

@farhansolodev but i would argue that the difficulty in obfuscating client side javascript is overall a good thing when it comes to reducing malware. personally i would strongly urge google and other browser vendors to fix the vulnerabilities in devtools that make it possible to break debugging IN THE PARENT DOCUMENT due to code running IN AN IFRAME OF UNTRUSTED ORIGIN
I've heard that certain configurations of disable-devtool let you break console.log as well, by basically trampling the prototype of "console" - i'm not sure if this affects the parent page too, but if it does, that is extremely dangerous... because that same vulnerability could be exploited by somebody who is actually seriously malicious - and they could, for example, cause text that you want to log to the console to be silently uploaded to the attacker's server...
I don't know about you, but when I'm developing, I'll often use console.log to help debug stuff, and that means I might log something - in the version running locally - that's totally inappropriate to log in production, like passwords, credit card numbers entered into a text field, etc... because I assume the console.log command to be a safe, local-only built in function placed there for developer convenience... You know what I mean?

@samrahimi

fix the vulnerabilities in devtools that make it possible to break debugging IN THE PARENT DOCUMENT due to code running IN AN IFRAME OF UNTRUSTED ORIGIN

yeah i agree, that is reasonable


Note Feature

Describe your suggested feature
Like When you open a manga in library there should be an option to
add Note for that manga like your opinion or their last thought about it. It can store locally
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is a request regarding an extension, I should be opening an issue in the extension's repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

This feature may come to aniyomi if this PR gets merged


Able to select text in multiple TextBoxes at once

I don't think that this should be happening, but I can select text in multiple TextBoxes at once.

If I start typing I only replace the text in the focused one, but I don't think it's aesthetically pleasing to be able to select text in multiple Boxes.

Code
let items = ["Number0", "Number1", "Number2", "Number3", "Number4", "Number5", "Number6", "Number7", "Number8", "Number9"];
let mut layout = Flex::column();
for item in items.iter() {
    let text = item.to_string();
    let original_text: Flex<AppData> = Flex::column()
        .with_child(Label::new( format!("{}", text)));
    let translated_text: Flex<AppData> = Flex::column()
        .with_child(TextBox::new().with_placeholder(format!("t{}t", text)).fix_width(TEXT_BOX_WIDTH).lens(AppData::text));
    let item_layout: Flex<AppData> = Flex::row().with_child(original_text).with_child(translated_text);
    layout.add_child(item_layout);
}
Scroll::new(layout)

I've played around a bit with some apps on my system (Linux) and both GTK and QT as well as VS Code clear single line text boxes when text is being selected somewhere else in the window. So I think doing the same in Druid would be reasonable.
This should probably be done through a command, something like TEXT_SELECTED: Selector<WidgetId>. That way the widget sending the command can ignore it based on the payload and other single line text edit widgets could clear themselves when receiving the command with a different id.

I think the correct fix here is to have the text box clear the selection when it loses focus.

The simplest way to achieve this is to only draw selection rect when TextBox is focused.
// Draw selection rect
- if !self.selection.is_caret() {
+ if is_focused && !self.selection.is_caret() {


-Xfatal-warnings does not work in metabuild

steps

$ cat build.sbt
fork in Compile := true

$ cat project/build.properties
sbt.version=1.5.0

$ cat project/plugins.sbt
scalacOptions += "-Xfatal-warnings"

$ sbt compile
[info] welcome to sbt 1.5.0 (AdoptOpenJDK Java 1.8.0_282)
[info] loading settings for project tmp-build from plugins.sbt ...
[info] loading project definition from ~/tmp/project
~/tmp/build.sbt:1: warning: method in in trait ScopingSetting is deprecated (since 1.5.0): `in` is deprecated; migrate to slash syntax - https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash
fork in Compile := true
     ^
[info] loading settings for project tmp from build.sbt ...
[info] set current project to tmp (in build file:/~/tmp/)
[info] Executing in batch mode. For better performance use sbt's shell
[success] Total time: 0 s, completed Apr 7, 2021 11:08:46 AM

problem
I would like to be able to make any warnings in the metabuild fatal, so we can catch them in CI (e.g. the new syntax warnings during the sbt 1.5 migration). This does not seem to work however.
expectation
Adding -Xfatal-warnings to project/plugins.sbt makes warnings in build.sbt fatal.
notes
Adding other compiler options, e.g. scalacOptions += "-Xlint" to project/plugins.sbt seems to work fine (it now spits out a bunch of "unused import" warnings), so this might be specific to fatal warnings?

Turns out using scalacOptions += "-Wconf:any:e" instead works as expected.
I suppose the -Wconf:cat=unused-nowarn:s added implicitly by sbt then overrides the -Xfatal-warnings flag.
I'm not sure anymore if this is a bug in SBT, scalac or it's just the intended behavior. Feel free to close this issue.

@dziemba Thanks for doing the detective work on scalacOptions.

with the Scala 2.12.17 compiler, I can supply -Xfatal-warnings either before or after -Wconf:... and it still takes effect, as seen in the following transcript:
% cat O.scala
object O { 2 }
% /usr/local/scala/scala-2.12.17/bin/scalac -Xfatal-warnings -Wconf:cat=unused-nowarn:s O.scala
O.scala:1: warning: a pure expression does nothing in statement position; multiline expressions may require enclosing parentheses
object O { 2 }
           ^
error: No warnings can be incurred under -Xfatal-warnings.
one warning found
one error found
% /usr/local/scala/scala-2.12.17/bin/scalac -Wconf:cat=unused-nowarn:s -Xfatal-warnings O.scala
O.scala:1: warning: a pure expression does nothing in statement position; multiline expressions may require enclosing parentheses
object O { 2 }
           ^
error: No warnings can be incurred under -Xfatal-warnings.
one warning found
one error found

so it doesn't seem like this could be caused by scalac, so something must be wrong on the sbt side
but it isn't clear to me how this could be going wrong on the sbt side
I had hoped that running sbt -debug would show me that command line sbt was using to compile the build definition, but it doesn't

I was looking at https://github.com/scala/scala/blob/4a129421867925c1594795353e0cab74d00af112/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala#L1915
                refchecksWarning(t.pos, text, WarningCategory.OtherPureStatement)

and noticed that this warning has a warning category, which sbt is not suppressing. This might be a fairly simple fix to add something to:
https://github.com/sbt/sbt/blob/8857ff2960f91d3fb2f623a1730a677af1a75499/main/src/main/scala/sbt/Defaults.scala#L980-L986
-Wconf:cat=other-pure-statement:s?


Adjust the URIs in the downloaded task configuration

Example:

small first letter for predicates
The URIs: tag:complexible:pinto:124b9cd479ce12935d1c18757bbb400b Would be good if they can have also form of HTTP URLs, so e.g. rather "{taskHttpURL}/configuaration"

Do 24.2. upravit pojmenovani predikatu a pinto URI nechat na pozdeji


KeyError raised when a message doesn't have a title.

In the init function, you have the following:
self.title = messageJson["title"]
If a message doesn't have a title, this generates a KeyError exception
I've fixed it in my copy by changing this line to say:
self.title = messageJson["title"] if "title" in messageJson else None

Interesting, I believe I thought that all messages are required to have a title, but nonetheless I'll change this now - thanks


os type define moved to config

I don't know if it'll be accepted (as it changes FatFS code), but it seems highly logical.
If you don't want to touch FatFS, just close it ;)

I'm hesitant to change anything in FatFS. As it is, I have to manually merge changes to ffconf.h whenever there is a new FatFS release. There is a FatFs User Forum. You could try bringing it up there.


Allow Task objects to defer dataset download

currently Task object initialization causes the tasks to download their datasets upon initialization.
This is not always desirable, so we should allow users to defer download and perform it manually.
Should add a defer_download: bool = False flag to Task and ConfigurableTask init() methods which, when set to true, has the dataset not downloaded, and allow users to easily call a task.download() method with no args that performs the download.
If users attempt to run the task without first downloading the dataset, we should raise an error.

Hi @haileyschoelkopf
I have started looking into this. I am confused as to why even though the Task class has a download method:
https://github.com/EleutherAI/lm-evaluation-harness/blob/86319a9b14ddae2030bc6e0fdddd47fc7d0bb525/lm_eval/api/task.py#L236-L240
the ConfigurableTask class is the only class which inherits from it and overrides the download method. Wouldn't it be simpler to just define the download method in the Task class as follows:
def download(
        self,
        data_dir: Optional[str] = None,
        cache_dir: Optional[str] = None,
        download_mode=None,
        **kwargs,         # <--- allow for additional kwargs
    ) -> None:
        """Downloads and returns the task dataset.
        Override this method to download the dataset from a custom API.

        :param data_dir: str
            Stores the path to a local folder containing the `Task`'s data files.
            Use this to specify the path to manually downloaded data (usually when
            the dataset is not publicly accessible).
        :param cache_dir: str
            The directory to read/write the `Task` dataset. This follows the
            HuggingFace `datasets` API with the default cache directory located at:
                `~/.cache/huggingface/datasets`
            NOTE: You can change the cache location globally for a given process
            by setting the shell environment variable, `HF_DATASETS_CACHE`,
            to another directory:
                `export HF_DATASETS_CACHE="/path/to/another/directory"`
        :param download_mode: datasets.DownloadMode
            How to treat pre-existing `Task` downloads and data.
            - `datasets.DownloadMode.REUSE_DATASET_IF_EXISTS`
                Reuse download and reuse dataset.
            - `datasets.DownloadMode.REUSE_CACHE_IF_EXISTS`
                Reuse download with fresh dataset.
            - `datasets.DownloadMode.FORCE_REDOWNLOAD`
                Fresh download and fresh dataset.
        """
        self.dataset = datasets.load_dataset(
            path=self.DATASET_PATH,
            name=self.DATASET_NAME,
            data_dir=data_dir,
            cache_dir=cache_dir,
            download_mode=download_mode,
            **kwargs,           # <--- pass the additional kwargs
        )

And remove the download method in the ConfigurableTask.
What do you think?

Yes, I think these should be unified.
One thing to check is that despite passing cache_dir directly in the Task.download() method, the HF environment variables should take precedence.

Any progress on this? it is so inconvenient to pass local data for evaluation.


1.1.17 Error after update

I get the following error in the logs after updating:
This error originated from a custom integration.

Logger: homeassistant.config_entries
Source: custom_components/mass/__init__.py:105
Integration: Music Assistant (documentation, issues)
First occurred: 12:50:41 PM (1 occurrences)
Last logged: 12:50:41 PM

Error setting up entry Music Assistant for mass
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 335, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/mass/__init__.py", line 112, in async_setup_entry
    raise exc
  File "/config/custom_components/mass/__init__.py", line 105, in async_setup_entry
    await mass.setup()
  File "/usr/local/lib/python3.9/site-packages/music_assistant/mass.py", line 81, in setup
    await self.database.setup()
  File "/usr/local/lib/python3.9/site-packages/music_assistant/helpers/database.py", line 45, in setup
    await self._migrate()
  File "/usr/local/lib/python3.9/site-packages/music_assistant/helpers/database.py", line 221, in _migrate
    await db.execute(f"ALTER TABLE {TABLE_ALBUMS} DROP COLUMN artist;")
  File "/usr/local/lib/python3.9/site-packages/databases/core.py", line 170, in execute
    return await connection.execute(query, values)
  File "/usr/local/lib/python3.9/site-packages/databases/core.py", line 295, in execute
    return await self._connection.execute(built_query)
  File "/usr/local/lib/python3.9/site-packages/databases/backends/sqlite.py", line 128, in execute
    await cursor.execute(query_str, args)
  File "/usr/local/lib/python3.9/site-packages/aiosqlite/cursor.py", line 37, in execute
    await self._execute(self._cursor.execute, sql, parameters)
  File "/usr/local/lib/python3.9/site-packages/aiosqlite/cursor.py", line 31, in _execute
    return await self._conn._execute(fn, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/aiosqlite/core.py", line 129, in _execute
    return await future
  File "/usr/local/lib/python3.9/site-packages/aiosqlite/core.py", line 102, in run
    result = function()
sqlite3.OperationalError: near "DROP": syntax error

Given I've had not set up much yet, I solved it by deleting the db. I don't think that's a valid path forward for future updates though?

same here.

What a strange error. As if sqlite did not accept the query. I will try if I can reproduce that one.
Can you share some details about the platform you guys are running ?

OK I found out that DROP column was introduced in sqlite 3.35.0 a year ago so the explanation is that Alpine (on which the Home Assistant image is based on) has an old version... I will provide a hotfix soon

I've provided version 1.1.18 which prevents this issue from happening but if it already impacted you, there's no other way than to delete the music_assistant.db file in the config folder.


docs(fix): #1613 link to demo configuration code for widgets

fixes #1613. just scratching an itch...
A picture of a cute animal (not mandatory but encouraged)

Deploy preview for netlify-cms-www ready!
Built with commit a1e8947909b657ee6c8dd2f8a30c23e33612aedf
https://deploy-preview-1620--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit a1e8947909b657ee6c8dd2f8a30c23e33612aedf
https://deploy-preview-1620--cms-demo.netlify.com

testing: verified link for demo site goes to the correct config file in github.


Unable to use asterisk

I'm no longer able to use an asterisk with the package enabled. I suspect there's a conflict with the added shortcuts. I'm on version 0.13.0. Atom 1.7.3.

Hi @MGallow, thanks for reporting.
I have indeed attached an event to the asterisk (see #103), but it should only do anything when there's also text selected. This behaviour can be disabled via the settings, although it shouldn't be necessary. I have a hypothesis (see #72) the Atom needs to restarted after an update to a package that adds an extra setting; otherwise it causes weird bugs like this.
Have you tried reloading Atom? If so, did it work? If it didn't, does disabling the option via the language-markdown settings work? If that also doesn't work, perhaps it's an OS-related issue, or perhaps a conflict with another package. If so, could you supply me with some additional information...

Ah, yes reloading Atom resolved the issue. Everything appears to be working correctly now. Thanks, love the package!


When emoji image is needed

The goal: user wants to replace native unicode emojis by images or insert it into a contentEditable.
The problems:

Dynamically created components can't be inserted to DOM in proper place.
Performance: many components make it slow. We can already observe it while opening emoji picker.

The workaround is to dynamically create the component, set emoji properties like id and set, call ngOnChanges(), hide generated component, wait for it to load, take HTML, destroy generated component and finally replace the unicode emoji by image...
Desired solution: there should be built-in service method to get HTML code for given emoji, getter or field with HTML / style in EmojiEvent.
Which solution would be the best? If it is a method - which service is the most sufficient for it?

i think i follow you.
Is this like when twitter replaces your emoji with their emoji?

It looks like this is how the original is doing it
https://github.com/missive/emoji-mart/blob/4715fe8f487a51796127626db23b3708a58b2539/README.md#using-with-dangerouslysetinnerhtml

works for me 👍

Could you provide any estimate on the issue? It'd be really helpful to have the possibility to get an image or html markup from the native unicode character or string id.

@asmironov, hard to give any estimation. I need to refactor and standarize a lot of code... I will try to finish it in this week, not sure if I will have enough time though.

@scttcper ,Can you create a stackbiltz example for above mention snapshot of textarea or emojiPicker. I'really need complete example  of  ngx-emoji-mart with chat input or textarea with binding.

should be easier with the new function added to emoji service https://github.com/TypeCtrl/ngx-emoji-mart#display-emoji-as-custom-element

@scttcper Thanks a lot for the new emojiSpriteStyles method! :+1:
My needs went a bit further though. I didn't want to store emojis in their image representation but as unicode. (Mobile devices don't need the image representation as they replace them with their native fonts. When entering a unicode emoji via the mobile device's keyboard instead of using emoji-mart, that would lead to different types of emojis for desktop users, the mobile ones looking ugly on desktop.)
So when saving them as unicode instead, I needed a way to transform a whole block of html (stored in my DB) to display images instead of unicode emojis.
Therefore I came up with this angular pipe:
https://gist.github.com/lentschi/8600f9b6ea7e7f5178f40a36f3053de7
-> To use it: <div [innerHTML]="messageWithUnicodeEmojis | replaceEmojis">
(Of course this pipe should only be applied to non-mobile devices - I added a matching condition in my project.)
I don't know if there is an easier way to do that with your lib already...? If so please, tell me! :-)
If not, feel free to somehow integrate my gist in your lib, should you find it useful!

@lentschi looks good thanks for the example, but i think everyone will end up having their own storage and display needs so i don't really want to maintain it.
The only part that might be easier now is the styles part of your code https://gist.github.com/lentschi/8600f9b6ea7e7f5178f40a36f3053de7#file-replace-emojis-pipe-ts-L51-L60 but most people will need custom styles anyway to match their page.

@scttcper Yeah, of course, you're right - My code is a bit too specific. :blush:
But maybe you could just add a method that takes a replace callback for each unicode emoji to EmojiService:
const htmlWithSprites = this.emojiService.replaceUnicodeEmojis(textOrHtmlWithUnicodeEmojis, (emojiData: EmojiData, offset: number): string => {
  const styles = this.emoji.emojiSpriteStyles(emojiData.sheet, 'twitter');
  const el = document.createElement('div');
  Object.assign(el.style, styles);
  // PLUS add any custom styles ...

  return el.outerHTML;
});

That would facilitate building custom pipes etc. to replace native emojis with sprites.
Though I totally understand, if adding that would be too difficult to maintain! (I wonder how it is done with the original library, or if noone else had this requirement.)

this.emoji is for which object?

Just in case anyone should still stumble across this: There was a bug in my gist so I just updated it. I also added some more options (described in the comments at the top of the gist) and added a StackBlitz sample: https://stackblitz.com/edit/pt-emoji-px4xto

Yeah but then why choosing a country flag displays the country code rather than the flag ? What is the solution for that ? @lentschi

@Alec-Aldrine-Lakra Are you referring to my most recent StackBlitz sample?
If yes, I'm afraid I can't reproduce your issue. Flags are displayed correctly in recent versions of Firefox & Chrome with all image sheets.
If no, please provide a failing sample (e.g. on StackBlitz), then I might be able to help.

Due to ongoing request I moved my former Gist extending ngx-emoji-mart to its own library:
npmjs.com: https://www.npmjs.com/package/ng-utf8-emojis-to-images
GitHub: https://github.com/lentschi/ng-utf8-emojis-to-images


Add support for inputs loaded via solc's import callbacks

🌟 Feature Request
📝 Description
When compiling a source file and finding an import that is not provided as input, solc will try to resolve the source via an import callback. If resolved successfully, the source will  be compiled and be part of the output. This is not something that zksolc apparently expects, as it fails with this error. You can reproduce the behavior by following these examples.
Ideally zksolc would be able to work just fine when it finds compiled outputs from solc that come from sources that are not part of the initial input. At least an attempt to reproduce the deafult Host Filesystem Loader that tries to get the file from the path derived from the source unit name would probably fit lots of use cases. If this is not possible or not planned to be supported, it would be nice to either use solc internally with --no-import-callback or give a clearer error explaining the user what happened a bit better (solc produced an output from a resolved import vs from a source provided on compiler input and this is not supported).
🤔 Rationale
Benefits from the feature would be:

Get closer to feature parity with solc.
User would not have to specify all sources as input to the compiler and just provide the "root" files.
Prevent some confusion on errors. There are cases that solc will add an already provided input but with a different name as a result of import resolution (It may have home/user/Contract.sol and ./Contract.sol as different source units), in which case zksolc will fail when looking to the sources map with Source code for path not found even though a source code matching that path was provided as input.

📋 Additional Context
This request comes as a result of investigating an issue in foundry: https://github.com/matter-labs/foundry-zksync/issues/411
After patching forge with an issue that did not add the correct allow_paths, using forge build --zksync on the provided example will result in the issue described in .3 on the Rationale, where solc will resolve an import of an already provided source with a different source unit name, and then zksolc won't find the source by the path string of solc's output in the input provided by foundry.

Will be released in v1.5.2!


curl: increase verbosity and exit(1) on >=400 status codes

This PR aims to resolve the issue mentioned in #68.
I've added the --fail flag to all curl commands which means that it will exit(1) on any status code gte 400.
I'm assuming this is correct for everything and that we aren't relying on silencing these errors at some point.
I've also removed all -s flags from curl in order to show more verbose output.
I'm not 100% that this the correct thing to do?
I usually only use that in non-interactive shells to silence the download progress bar.
resolves https://github.com/pelias/kubernetes/issues/68

I usually only use that in non-interactive shells to silence the download progress bar.

That's exactly why I do it as well. I think the -s can stay, but adding the --fail flag is good. I believe with -s the actual output of the HTTP response will still be printed.

Makes sense, let's hold off a bit on merging this, it seems that non-master nodes will fail with a message such as this is not the master, aborting snapshot load.
What will the effect of that failure be on non-node master startup if the script exit(1)?

Following up on this. I think we can restore the -s flags and then merge this PR.

Added -s flags back via rebase.


Changed package versions to fixed ones

@suhasj
Just FYI...the Xunit packages are not available on public Nuget feed and we are figuring out if we need to create a separate feed for external packages, but other than that please take a look at the changes to other packages.

Hi @kichalla, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

Adding @Praburaj

@kichalla why are we updating this ? If add the release versions, we would have to update it for each release right ?

@suhasj : yes, we want to lock on the versions for at least the released packages.


Changing shebangs in executable scripts:

Using /usr/bin/env for all shebang invocations
Moving shebangs to first line of the script, before any Python code

copypasta!