Warning 'unreachable code after return statement'

See following code snippit
function _initRotationControls () {
        // TODO - Not a fan of these controls
        return; // <-- issue starts here
        var self = this,
            wrap, btnLeft, btnRight, iLeft, iRight;
        ...

Yep - I'm aware of that code.  I started to include rotation buttons in the default interface for croppie, but didn't like how they were turning out.  If that warning is bugging you, you can remove that code.


How to restart a flow from the beginning when a job fails

Hi,
When I set the retries option in my child job which depends on a parent job, it only retries the child job. Is there a way I can force the whole flow to be retried on any job failure instead of just the job?

AFAICT the concept in Azkaban is that any given job should stand alone. E.g. it either succeeds and it's children can run or it fails and notifies the operator. There is no concept of branching logic or job skipping.
If you have logic that requires walking back from failure I'd suggest that you could encapsulate it inside a single job. Alternatively, on occasion I've created flows that ignore failures and just rerun on a schedule, e.g., no notifications on failures and disallow concurrent runs.


Docs: eager loading is not documented (want to see startup errors at startup)

I have been annoyed for a while by Flask's lazy loading feature, without even knowing about the feature or why it was annoying me. (The specific problem: when I have a bug in my app factory that should cause an immediate crash on startup, Flask swallowed the exception and only showed it to me with the first request.)
So this morning, I dug into the code and learned that this is not a bug, but clearly a deliberate feature added back in 2014 ago. I also learned about the workaround for this feature: flask run --eager-loading. Perfect! Nothing to fix here, right?
So what's the problem? Documentation! I had to dig into the source code to understand what was going on, and to figure out how make Flask behave the way I want. That should be described in the manual.
Expected Behavior
In my perfect world, a bug in the app factory would cause an immediate crash on startup. But since delaying such crashes was clearly added deliberately to Flask, and has been there for 5 years, I do NOT propose changing this behaviour.
What should happen: the next person who is annoyed or confused by this behaviour should find an explanation and a workaround in the docs.
import flask

app = flask.Flask(__nam__)                     # <<< TYPO!!!

@app.route('/')
def index():
    return flask.make_response({"foo": 42}, 200)

Actual Behavior
I google'ed, I searched the manual, and I could not figure out why Flask was making it hard to see my bugs. I had to read the source code to find out about --eager-loading.
Environment

Python version: 3.6, 3.7
Flask version: 1.1.1
Werkzeug version: 0.16.0

The point of lazy loading is that the dev server DOES NOT CRASH when you save code that has import-time errors (e.g. syntax errors). Usually this is much preferable, because during development you are going to reload the page or otherwise send a request shortly after changing the code anyway... And then you will see the error!

Proposed fix: add a section "Startup errors" to page https://flask.palletsprojects.com/en/1.1.x/errorhandling/. I am volunteering to write this documentation, but I'd like some feedback: is this the best place to put it, and is this the right amount of detail?
Quick outline of what I propose to add:

flask uses "lazy loading" by default
purpose: prevent the dev server from crashing due to import-time errors (after all, you're about to send another request)
if you would prefer the dev server to crash, you want "eager loading"
just run flask run --eager-loading: problem solved

Yeah, I'm inclined to leave it as an undocumented option to the run command, it's not intended for general use.
The docs aren't really laid out in a way that documenting every option to every command is easy to keep organized and useful. If you're interested in what options are available, use the --help option to any command or sub-command.

The problem is that I had no idea that lazy loading was even a thing until I dug into the source code. Once I knew that, it was not difficult to guess "hey maybe there is a command-line option for this". But it never occurred to me to look for one until I realized this behaviour was deliberate, rather than a bug.

I'd like to close this in favor of making initial errors immediate. See #3431

I'd like to close this in favor of making initial errors immediate. See #3431

Yeah, that would be a big improvement.
In the meantime, I've written the docs -- see https://github.com/pallets/flask/pull/3432. If #3431 is likely to be fixed soon, great! Forget my PR. But if you want to describe the status quo circa 1.1.1, I believe my PR improves things.


chore(docs): fix confusing View component remove and add for rn-cli

This package is awesome. Kudos to you @marklawlor and all of the maintainers.
While I'm following the docs for react-native cli, I saw that there is a confusing class insertion outside a View component tag. I just want it to be clear by creating this PR.

Thanks in advance

Cheers :+1:


Enhance scripts to deploy Knowlg DBs in the AWS environment

Enhancing Terraform scripts to deploy Knowlg DBs in the AWS environment
labels: C4GT Community
Description
I will be adding the terraform scripts which will provision the infra for the aws environment
Sub-Goals

[ ] [adding a script for Neo4j]
[ ] [adding a script for Cassandra]
[ ] [adding a script for Redis]

Expected Outcome
Deployment of the DB over AWS cloud using the Terraform.
Implementation Details
Adding the terraform scripts which enable IAAC(infrastructure as a code) to support the aws setup with the help of terraform aws provider.

Project
One-click installation of Knowlg in AWS environment.
Tech Skills Needed:
Kubernetes, Terraform
Complexity
Medium
Time period estimated
5 days
Category
Feature
Sub Category
[Database],[Localization], [Configuration],[Support]

Ok


Release 0.1.13

Changes:

dir: fix write_file_with_sync() to be FnOnce

/cc @cgwalters

Tagged: https://github.com/coreos/openat-ext/releases/tag/v0.1.13
Published: https://crates.io/crates/openat-ext/0.1.13


[SPARK-22400] [SQL] rename some APIs and classes to make their meaning clearer

What changes were proposed in this pull request?
Both ReadSupport and ReadTask have a method called createReader, but they create different things. This could cause some confusion for data source developers. The same issue exists between WriteSupport and DataWriterFactory, both of which have a method called createWriter. This PR renames the method of ReadTask/DataWriterFactory to createDataReader/createDataWriter.
Besides, the name of RowToInternalRowDataWriterFactory is not correct, because it actually converts InternalRows to Rows. It should be renamed InternalRowDataWriterFactory.
How was this patch tested?
Only renaming, should be covered by existing tests.

cc @cloud-fan

Is the idea that this is unreleased and can be renamed?

Test build #83216 has started for PR 19610 at commit 12a3703.

yea, and we can't change it after release.

LGTM

Thanks! Merged to master.

Test build #83216 has finished for PR 19610 at commit 12a3703.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class InternalRowDataWriterFactory(
class InternalRowDataWriter(rowWriter: DataWriter[Row], encoder: ExpressionEncoder[Row])

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83216/
Test PASSed.

Merged build finished. Test PASSed.


[Feature Request]: Add TypeScript types

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview
It is possible to have the ESLint config be type checked using JSDoc comments and the // @ts-check annotation comment: e.g.
// @ts-check

/** @type {import("eslint").Linter.Config[]} */
export default [
    // ...
]

But this package doesn't export types ATM. It would be nice if it did export types so it works without errors using this. Most/all other plugins I used do have types.
Expected Behavior
For the package to have TypeScript types
eslint-plugin-react version
v7.35.0
eslint version
v9.8.0
node version
v18.20.4

typescript-eslint provides a typed wrapper for configs.
https://typescript-eslint.io/getting-started
// @ts-check

import eslint from '@eslint/js';
import tseslint from 'typescript-eslint';

export default tseslint.config(
  eslint.configs.recommended,
  ...tseslint.configs.recommended,
);

I'll probably add types eventually, but in the meantime, a DT package would be the way to go.

https://typescript-eslint.io/users/configs/

Here's a PR that adds this through type generation based on the JSDocs: https://github.com/jsx-eslint/eslint-plugin-react/pull/3830

@voxpelli thanks for adding this! I submitted a request for types back in #3776, so it's great to see it happen!
One issue though - I updated to v7.37.0, but TypeScript is still complaining there are no type declarations.

Are we sure the types are being generated + added to the package build correctly? I noticed there is no "types" field in package.json - could that be the problem? Usually packages declare their type exports like this:
"main": "index.js",
"types": "index.d.ts",

If this is a bug, should we open a new issue for this?

I noticed there is no "types" field in package.json - could that be the problem

Oh, I forgot to add that? 🫣
Yeah, would be great to add that, can you validate that it works when that's been added?

Though I did add a test that should have validated that the types are working properly when used in a module, is that test then broken? 🤔

can you validate that it works when that's been added?

I would, but I can't find the type file to point to - there's no index.d.ts. There is a lib/types.d.ts file, but it doesn't seem to define the export types, and it hasn't been modified in 6 months.
Here is what I see in my node_modules.

It's possible the type declarations are being excluded when publishing to npm. Or maybe I just don't know where to look.
You can see what has been published by browsing the package files here. Do you see your type files?

I published manually, locally. The types built fine, afaik.
Indeed, the publish workflow failed and I couldn't reproduce that locally.
If there's a bug then it'd be great to get that fixed.

I'll open a separate issue for this.

#3836


Update stickybits.js

remove unused method

@aimwhy thank you!


ENH Add SLOPE penalty

POC of the SLOPE penalty with FISTA solver. We should first merge #91 before this one.
(The diff is significant because this branch stems from #91 ).

Note to self:
Work remaining: implemented vector fixed-point violation for stopping criterion and fix vector prox computation for FISTA.

What do you think of adding https://github.com/jolars/pyslope as a test dependecy for SLOPE and test that we find the same solution ?

What do you think of adding https://github.com/jolars/pyslope as a test dependecy for SLOPE and test that we find the same solution ?

I think it's a good idea. Then we can have a "true" test

merge when green


Speech recognition continues despite of music at the beginning

Hi
I have a jupyter notebook code ready to convert audio to text and I have tried it and it works fine with wav-files in English and Finnish.
But when I have audio files with waiting music at the beginning for about 3-4 seconds, it gives me this:
No speech could be recognized: NoMatchDetails(reason=NoMatchReason.InitialSilenceTimeout)
So I think the reason why the code does not work is the music at the beginning, how can I work with this so that it continues to recognize speech despite of the fact that there is waiting music for about 3-4 seconds at the beginning?
Part of my code is below:
audio_file_path = Path("audiofile").resolve()
speech_config = speechsdk.SpeechConfig(subscription=speech_key, region=service_region)
audio_input = speechsdk.AudioConfig(filename=str(audio_file_path))
speech_recognizer = speechsdk.SpeechRecognizer(
speech_config=speech_config, language="fi-FI", audio_config=audio_input)
def recognize_audio_file():
print('Recognizing first result...')
result = speech_recognizer.recognize_once()
if result.reason == speechsdk.ResultReason.RecognizedSpeech:
    print('Recognized: {}'.format(result.text))
elif result.reason == speechsdk.ResultReason.NoMatch:
    print('No speech could be recognized: {}'.format(result.no_match_details))
elif result.reason == speechsdk.ResultReason.Canceled:
    cancellation_details = result.cancellation_details
    print('Speech Recognition canceled: {}'.format(cancellation_details.reason))
    if cancellation_details.reason == speechsdk.CancellationReason.Error:
        print('Error details: {}'.format(cancellation_details.error_details))

if name == 'main':
recognize_audio_file()

Many thanks for your advice beforehand.
Marko

Many thanks!

Closing the issue, let us know if there is any other issues.


Mapbox Visualizatuion error cause by "is not JSON serializable"

Make sure these boxes are checked before submitting your issue - thank you!

[yes ] I have checked the superset logs for python stacktraces and included it here as text if any
[yes ] I have reproduced the issue with at least the latest released version of superset
[yes ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.19.1
Expected results
I try to draw mapbox in superset. I have dataset with column Latitude and Longitude and use it in respective field.
Actual results
TypeError: <superset.connectors.druid.models.DruidMetric object at 0xefbea90> is not JSON serializable
Steps to reproduce

Anyone  already have the same problem?
Thanks

Please reproduce with latest version and also post the full backtrace proberly quoted in text and not in picture.

This is full backtrace i receveid
Traceback (most recent call last):   File "/usr/lib/python2.7/site-packages/superset/viz.py", line 249, in get_payload     df = self.get_df()   File "/usr/lib/python2.7/site-packages/superset/viz.py", line 79, in get_df     self.results = self.datasource.query(query_obj)   File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 971, in query     client=client, query_obj=query_obj, phase=2)   File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 799, in get_query_str     return self.run_query(client=client, phase=phase, **query_obj)   File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 962, in run_query     client.groupby(**qry)   File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 192, in groupby     return self._post(query)   File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 391, in _post     headers, querystr, url = self._prepare_url_headers_and_body(query)   File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 34, in _prepare_url_headers_and_body     querystr = json.dumps(query.query_dict).encode('utf-8')   File "/usr/lib64/python2.7/json/__init__.py", line 243, in dumps     return _default_encoder.encode(obj)   File "/usr/lib64/python2.7/json/encoder.py", line 207, in encode     chunks = self.iterencode(o, _one_shot=True)   File "/usr/lib64/python2.7/json/encoder.py", line 270, in iterencode     return _iterencode(o, 0)   File "/usr/lib64/python2.7/json/encoder.py", line 184, in default     raise TypeError(repr(o) + " is not JSON serializable") TypeError: <superset.connectors.druid.models.DruidMetric object at 0xb319650> is not JSON serializable

Quote with 3 backticks please.

Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/superset/viz.py", line 249, in get_payload df = self.get_df() File "/usr/lib/python2.7/site-packages/superset/viz.py", line 79, in get_df self.results = self.datasource.query(query_obj) File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 971, in query client=client, query_obj=query_obj, phase=2) File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 799, in get_query_str return self.run_query(client=client, phase=phase, **query_obj) File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 962, in run_query client.groupby(**qry) File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 192, in groupby return self._post(query) File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 391, in _post headers, querystr, url = self._prepare_url_headers_and_body(query) File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 34, in _prepare_url_headers_and_body querystr = json.dumps(query.query_dict).encode('utf-8') File "/usr/lib64/python2.7/json/__init__.py", line 243, in dumps return _default_encoder.encode(obj) File "/usr/lib64/python2.7/json/encoder.py", line 207, in encode chunks = self.iterencode(o, _one_shot=True) File "/usr/lib64/python2.7/json/encoder.py", line 270, in iterencode return _iterencode(o, 0) File "/usr/lib64/python2.7/json/encoder.py", line 184, in default raise TypeError(repr(o) + " is not JSON serializable") TypeError: <superset.connectors.druid.models.DruidMetric object at 0xb319650> is not JSON serializable

It's ok??

Copy it from the server logs, it'll have the proper newlines.

TypeError: <superset.connectors.druid.models.DruidMetric object at 0xb319650> is not JSON serializable
2017-10-05 15:09:24,759:INFO:root:Caching for the next 86400 seconds
2017-10-05 15:17:22,439:INFO:root:[stats_logger] (incr) explore
2017-10-05 15:17:23,749:INFO:root:[stats_logger] (incr) explore_json
2017-10-05 15:17:23,820:INFO:root:[stats_logger] (incr) loaded_from_source
2017-10-05 15:17:23,820:INFO:root:Serving from cache
2017-10-05 15:17:28,259:INFO:root:[stats_logger] (incr) explore_json
2017-10-05 15:17:28,332:INFO:root:[stats_logger] (incr) loaded_from_cache
2017-10-05 15:17:28,348:INFO:root:Caching for the next 86400 seconds
2017-10-05 15:17:40,590:INFO:root:[stats_logger] (incr) explore_json
2017-10-05 15:17:40,659:INFO:root:[stats_logger] (incr) loaded_from_cache
2017-10-05 15:17:40,664:ERROR:root:<superset.connectors.druid.models.DruidMetric object at 0x95a5410> is not JSON serializable
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/superset/viz.py", line 249, in get_payload
    df = self.get_df()
  File "/usr/lib/python2.7/site-packages/superset/viz.py", line 79, in get_df
    self.results = self.datasource.query(query_obj)
  File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 971, in query
    client=client, query_obj=query_obj, phase=2)
  File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 799, in get_query_str
    return self.run_query(client=client, phase=phase, **query_obj)
  File "/usr/lib/python2.7/site-packages/superset/connectors/druid/models.py", line 962, in run_query
    client.groupby(**qry)
  File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 192, in groupby
    return self._post(query)
  File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 391, in _post
    headers, querystr, url = self._prepare_url_headers_and_body(query)
  File "/usr/lib/python2.7/site-packages/pydruid/client.py", line 34, in _prepare_url_headers_and_body
    querystr = json.dumps(query.query_dict).encode('utf-8')
  File "/usr/lib64/python2.7/json/__init__.py", line 243, in dumps
    return _default_encoder.encode(obj)
  File "/usr/lib64/python2.7/json/encoder.py", line 207, in encode
    chunks = self.iterencode(o, _one_shot=True)
  File "/usr/lib64/python2.7/json/encoder.py", line 270, in iterencode
    return _iterencode(o, 0)
  File "/usr/lib64/python2.7/json/encoder.py", line 184, in default
    raise TypeError(repr(o) + " is not JSON serializable")
TypeError: <superset.connectors.druid.models.DruidMetric object at 0x95a5410> is not JSON serializable
2017-10-05 15:17:40,665:INFO:root:Caching for the next 86400 seconds

This is log directly receivred from server.
I use druid for backend database.

@xrmx

@georgeke

@xrmx

I'm experiencing the same issue

Same here.  Would be great if this worked as there are many Geo coded (Lat Long) data set use cases for interactive exploration.  As an aside, would something like Leaflet.js be possible with Superset?

from superset.connectors.druid.models import DruidMetric
import json
from superset.utils import base_json_conv

m = DruidMetric()
json.dumps(m, default=base_json_conv)

'null'

DruidMetric just needs a default method from JSONEncoder.

I also have the same issue. How can we set this default method?

Digging abit deeper, unfortunately adding a "default()" method will not work. The json module has a bit of a peculiar default way of doing serialization, which does not allow serialization methods being added to classes.
However, here it seems that a DruidMetric is somewhere to being forgotten to be .json_obj() as it is done in run_query for metrics. Somehow one (or more) slips trough.

Ok I found the issue. The dimensions of the LimitSpec part of the query are populated with metrics or self.metrics. This is a druidmetric instead of a column name.
I think the logic (run_query) is wrong here and it should use dimensions instead and not metrics. I’m not entirely sure and need some help from @Fokko or @mistercrunch. Then the PR is quite simple.

Hi, i am facing the same issue.On running single custom dimension i get the following error:
KeyError: u"None of [[u'outputName', u'extractionFn', u'type', u'outputType', u'dimension']] are in the [index]"
Can you specify which version of druid to use? and what is the fix?

I don't think it really has to do with Druid. Which version Superset are you running?

Hi,
Using 0.20.
Two issues am facing:
1.Extensions are non filterable.
2.And single extension dimension is non groupable.It throws the error
specified in the above post.
Any reason why topN query doesnt work on superset for single extension
dimension? Same works if i hit the same query on druid.
On Thu, Feb 1, 2018 at 5:38 PM, Fokko Driesprong<EMAIL_ADDRESS>wrote:

I don't think it really has to do with Druid. Which version Superset are
you running?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/issues/3604#issuecomment-362246857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZHoWqyDkzi6N-Yeb5Bh7FMovUCpRVMKks5tQakvgaJpZM4Pu95g
.

@chirpy2291 the fix is new (not even in a released version afaik) and you are running an old version of superset. So why not use master first and then open a new issue if needed instead of hijacking this closed issue?

Since the code is in production its not possible to include all the new
features and  release with the given timeframe. So sometimes when we have
to go forward in a short span of time we have to look back a little. I
thought you being a contributor would be able to help. Sorry for the
inconvenience.
On Sun, 4 Feb 2018 at 4:58 PM, bolkedebruin<EMAIL_ADDRESS>wrote:

@chirpy2291 https://github.com/chirpy2291 the fix is new (not even in a
released version afaik) and you are running an old version of superset. So
why not use master first and then open a new issue if needed instead of
hijacking this closed issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-superset/issues/3604#issuecomment-362899784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZHoWq69ltZgguDB66Wp2znrgmjhDRdpks5tRZRMgaJpZM4Pu95g
.


Added transition to rounded-bottom button

Added transition: all 0.2s to rounded-bottom button

Issue: #1262

Thank you for your work!
@all-contributors please add @mainak-debnath for code


[WIP] explicitly declare package to be zip_safe

The install is slightly faster, about 0.7s vs 0.9s with the flag True. I haven't tested the command times.
We might also need to have a special debug mode, if this won't give descriptive tracebacks, but not sure. Needs testing.

Coverage remained the same at 90.37% when pulling 79df75b301fdfad9ac655cc1f5aed8c0fd06c5a1 on AlanCoding:zip_safe into c2b1fd4e1bb3c6100670868dc93af0c7c4becebf on ansible:master.

juggling various versions locally, I have found this to be very, very, dangerous.


fix: user email migration

Relates to https://jira.dhis2.org/browse/HUB-105 and is an implementation of the proposal here https://github.com/dhis2/notes/discussions/260

What do you think about something like this for simple rate limiting:
const LRU = require('lru-cache')

class RateLimiter {
    constructor({ maxPerHour }) {
        const oneHourMs = 1000 * 60 * 60

        this.cache = new LRU({
            maxAge: oneHourMs
        })
    }

    do(fn, key) {
        const count = this.cache.get(key) || 0
        if (count < maxPerHour) {
            this.cache.set(key, count + 1)
            fn()
        } else {
            throw new Error('Rate limit exceeded')
        }
    }
}

class EmailService {
    constructor() {
        // ...

        const maxEmailsPerHour = 10
        this._rateLimiter = new RateLimiter({ maxPerHour: maxEmailsPerHour })
    }

    async sendOrganisationInvitation() {
        // ...

        return this._sendMail(sendTemplate, fromUserId)
    }

    _sendMail(email, key) {
        this._rateLimiter.do(() => {
            this.transporter.sendMail(email)
        }, key)
    }
}

I've tested the invitation/accepting functionality and it works great - way better than the previous UX of having to have signed in at least once. Also good to see the migration from app.developer.name and app.developer.email to app.contactEmail :+1:

What do you think about something like this for simple rate limiting:

That would be great, but I wonder if it would be worth to look into something like https://github.com/wraithgar/hapi-rate-limit

I wonder if it would be worth to look into something like https://github.com/wraithgar/hapi-rate-limit

Looks good let's try to integrate it once this PR is merged :+1:


« into » is repeated

Data comes into into the designer ...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0fd665ec-39f3-6f03-bfa6-37481ed5f5d0
Version Independent ID: 7ef82685-2aca-15db-cdd3-c8bfd5ef01ed
Content: Import data - Azure Machine Learning
Content Source: articles/machine-learning/how-to-designer-import-data.md
Service: machine-learning
Sub-service: core
GitHub Login: @PeterCLu
Microsoft Alias: peterlu

@yaniaoulmi , thanks for your eagle-eyed catch. That should definitely not read "into into". The error has been fixed, and you should see the changes live in a few hours.
#please-close


FIX: add cache-sim argument (fix issue 34)

Fixes #34.
If you want to use this before it gets merged, replace your iai line in Cargo.toml to this:
iai = { git = "https://github.com/sigaloid/iai", rev = "d56a597" }

I am still getting a ‘no entry found for key’ panic with d56a597.

What version of valgrind are you on? And is it pointing to my fork in your Cargo.toml?
Strange that it still wouldn't work, as that's the only cause :(

What version of valgrind are you on? And is it pointing to my fork in your Cargo.toml?

3.21.0, and yes, I removed Cargo.lock to make sure it was picking it up, and it still panics.

I can confirm the problem noticed by @bluebear94, I still get the error. Also, I found the following in the cargo output, verifying that this PR is used:
   Compiling iai v0.1.1 (https://github.com/sigaloid/iai?rev=d56a597#d56a5971)

I needed a cargo update but afterwards it worked.

@sigaloid: I am relying on your bugfix in the HDT library on crates.io but depending on a GitHub repository is making me nervous.
As the main developer of this project, @bheisler has been inactive for the last 2 and a half years and I could not find any contact information, it seems to me as if this won't get merged in the near future.
Could you consider publishing your fork on crates.io, so other crates can reliably depend on a fixed version of iai?


Enhanced RDoc for CSV::Row

Methods:

index
field?
each
==

Plus, tuned up a few call-seq.

Thanks!


Fix SqlTask cannot split the given sql when browser in windows

Purpose of the pull request
close #15048
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #15062 (47a359e) into dev (c59b2d5) will increase coverage by 0.02%.
The diff coverage is 38.46%.

:exclamation: Current head 47a359e differs from pull request most recent head a46488e. Consider uploading reports for the commit a46488e to get more accurate results

@@             Coverage Diff              @@
##                dev   #15062      +/-   ##
============================================
+ Coverage     39.00%   39.02%   +0.02%
- Complexity     4599     4601       +2
============================================
  Files          1231     1232       +1
  Lines         43300    43263      -37
  Branches       4792     4775      -17
============================================
- Hits          16888    16883       -5
+ Misses        24536    24503      -33
- Partials       1876     1877       +1

Files
Coverage Δ

...scheduler/plugin/task/sql/utils/SqlSplitUtils.java
66.66% <66.66%> (ø)

...ache/dolphinscheduler/plugin/task/sql/SqlTask.java
3.50% <14.28%> (+0.56%)
:arrow_up:

... and 22 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Dark theme support

The current version of the theme has potential. I would very much like to see a dark version of it.
NOTE: A more minimalist logo would help people in creating a better relationship with the theme in the marketplace.

Also, I think the contrast of some colors isn't that great for the eyes. For example, the yellow for rainbow brackets doesn't read well on the theme light background. Maybe this helps in improving the theme, so more people could use it everyday.

The current version of the theme has potential. I would very much like to see a dark version of it.
NOTE: A more minimalist logo would help people in creating a better relationship with the theme in the marketplace.

Thank you for the feedback.

A dark version of the theme is planned.
Indeed, the logo can be (greatly) improved and there will probably be at least one newer iteration of it in the future

Also, I think the contrast of some colors isn't that great for the eyes. For example, the yellow for rainbow brackets doesn't read well on the theme light background. Maybe this helps in improving the theme, so more people could use it every day.

I will check this on my end and get back to you with an update. Thank you!

Also, I think the contrast of some colors isn't that great for the eyes. For example, the yellow for rainbow brackets doesn't read well on the theme light background. Maybe this helps in improving the theme, so more people could use it every day.

I will check this on my end and get back to you with an update. Thank you!

This is proving to be quite an endeavor!

Also, I think the contrast of some colors isn't that great for the eyes. For example, the yellow for rainbow brackets doesn't read well on the theme light background. Maybe this helps in improving the theme, so more people could use it every day.

I will check this on my end and get back to you with an update. Thank you!

This is proving to be quite an endeavor!

Maybe this  article helps a little bit.

The current version of the theme has potential. I would very much like to see a dark version of it.

The work on dark version has started. Stay tuned!

Later Edit: improvements for Light theme are underway (they were long overdue), therefore Dark version is postponed for now.


Antonclk fix calweek substring

bugfixed calendar week shown 3 digits (substring -> slice) furthermore replaced deprecated substr by slice

Thank! But is there a reason for replacing substr with slice? As far as I can tell they both work, and substr is what tends to be used in other Espruino apps.

Thanks for merge.
Reason for replacement:
I just got the deprecated warning from my VS Code and found it mentioned at
Mozilla deprecated and obsolete features

String.prototype.substr()
Deprecated: This feature is no longer recommended. Though some browsers might still support it, it may have already been removed from the relevant web standards, may be in the process of being dropped, or may only be kept for compatibility purposes. Avoid using it, and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.

Mozilla dev substr