Placeholder Text

I edited the /usr/local/lib/python3.6/dist-packages/isso/js/app/i18n/en.js and restart isso. It's still the same.
Any other steps I could have missed?

Just make again. You change the js source and you need to make to get a new embed.js

I was installed via pip and the only way to do it was reinstall from source?
I would rather edit embed.min.js as they were just strings. But seems editing the one in /usr/local/lib/python3.6/dist-packages/isso/js/app/ wasn't make any difference either.


Add THROUGH write type to DataFlow doc

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4917/
Test PASSed.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.0 please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4918/
Test FAILed.


How can a DebugConfigurationProvider determine Debug vs Run without Debugging

If an extension implements a DebugConfigurationProvider, it would be useful to know if resolveDebugConfiguration was triggered in debug mode or run without debug mode.
The debugConfiguration: vscode.DebugConfiguration parameter appears to contain a noDebug = true property when using run without debug, but I don't see this mentioned in the VS Code API types or on the API reference.
I'd like to know if noDebug is the endorsed way of detecting debug mode, and if it isn't, I'd like to request a way to detect this. I'm using @types/vscode v1.40

The "noDebug" attribute is specified in the Debug Adapter Protocol (DAP): https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Launch.
You can include that protocol as a TypeScript d.ts npm module vscode-debugprotocol.
Please note that the DAP is not duplicated (or automatically included) in VS Code's extension API.


Unhandled exception we got in production

  File "/opt/wayback-search-venv/lib/python3.7/site-packages/mcmetadata/__init__.py", line 34, in extract
    article_title = titles.from_html(raw_html, article['title'])
  File "/opt/wayback-search-venv/lib/python3.7/site-packages/mcmetadata/titles.py", line 49, in from_html
    title = whitespace_pattern.sub(title, ' ')
  File "/usr/lib/python3.7/re.py", line 311, in _subx
    template = _compile_repl(template, pattern)
  File "/usr/lib/python3.7/re.py", line 302, in _compile_repl
    return sre_parse.parse_template(repl, pattern)
  File "/usr/lib/python3.7/sre_parse.py", line 964, in parse_template
    this = sget()
  File "/usr/lib/python3.7/sre_parse.py", line 256, in get
    self.__next()
  File "/usr/lib/python3.7/sre_parse.py", line 246, in __next
    self.string, len(self.string) - 1) from None
re.error: bad escape (end of pattern) at position 19

Unfortunately, I don't have the input that triggered it.


Downloads aren't working anymore

Used to work before, now it doesnt?

Intermittent download issues are caused by a bug in the WebRTC implementation we are using: flutter-webrtc/flutter-webrtc/issues/759

any updates to this?

@earlpeterg yeah it's been fixed about 1 minute ago in v1.3.15, lucky timing

Thank you so much!


Add-DbaAgDatabase Does not Add to Secondary Replica

Command: Add-DbaAgDatabase -SqlInstance Replica01 -AvailabilityGroup AGName -Database DB01 -Confirm:$false
When opening the Dashboard, I see the message the DB is not joined to the Secondary replica and I get error message: The data synchronization state of this availability database is unhealthy.
It does not add the DB to the Secondary replica at all. Even after I ran:
Command: Add-DbaAgDatabase -SqlInstance Replica02 -AvailabilityGroup AGName -Database DB01 -Confirm:$false
Nothing happens.
Adding the database manually works fine.
Other databases participate of the AG.
When opening the database on the Secondary Replica Dashboard I get error:

This secondary database is not joined to the availability group. The configuration of this secondary database is incomplete. For information about how to join a secondary database to an availability group, see SQL Server Books Online.

And message

The data synchronization state of this availability database is unhealthy. On an asynchronous-commit availability replica, every availability database should be in the SYNCHRONIZING state. On a synchronous-commit replica, every availability database should be in the SYNCHRONIZED state.

I attempted to run the the [Add-DbaAgDatabase] on another environment with AOAG in order to test/check if there was an issue with my servers.
Turns out that I get the exact same result: Database is added only to the Primary replica and I see the same errors on the Secondary: This secondary database is not joined to the availability group.
Adding the database manually or through SQLPS https://docs.microsoft.com/en-us/powershell/module/sqlserver/add-sqlavailabilitydatabase?view=sqlserver-ps works fine.
Any update / assistance is much appreciated.
Thanks

Thanks so much, I don't use AGs so I'm not really familiar with their default behavior. I'll add this in within the next 24 hours 👍  Please keep the feedback coming.

I have definitely seen that behavior in my home-grown AG scripts, though I'm still unsure what causes it. Sometimes I was getting a perfectly healthy AG, sometimes databases would not join. So I implemented something like this:
#Add the database to AG
Write-Verbose "Adding database $targetDatabaseName to the Availability Group $AvailabilityGroup"
$availabilityDb = New-Object -TypeName Microsoft.SqlServer.Management.Smo.AvailabilityDatabase -ArgumentList @((Connect-DbaInstance -SqlInstance $currentPrimary).AvailabilityGroups[$AvailabilityGroup], $targetDatabaseName)
$availabilityDb.Create()

# wait a few seconds before enforcing secondaries
Start-Sleep 10

#Ensuring all secondaries managed to join the AG
foreach ($s in $TargetServer) {
	if ($s -ne $currentPrimary) {
		$agDb = (Connect-DbaInstance -SqlInstance $s).AvailabilityGroups[$AvailabilityGroup].AvailabilityDatabases[$TargetDatabaseName]
		Write-Verbose "Database $s.$TargetDatabaseName is joined to $AvailabilityGroup`: $($agDb.IsJoined)"
		if (!$agDb.IsJoined) {
			Write-Verbose "Manually joining the AG $AvailabilityGroup`:  $s.$TargetDatabaseName"
			$agDb.JoinAvailablityGroup()
		}
	}
}

Basically, for each secondary that is not joined, call JoinAvailablityGroup() when IsJoined is $false.
Start-Sleep is there because it takes some time for the AG to finalize the sync operations after joining (could be more on highly-loaded systems), not sure yet if there is an alternative to this.

This is super helpful, thank you!

thanks for the code! i didnt realize that $ag would even have the JoinAvailablityGroup() method. Saved me a ton of time! PR will be merged once tests pass ✔


Container Deploy very slow using NodeJs

I'am developing an pipeline to deploy several applications on azure Webapps/Functions. But using azure/webapps-deploy@v2 with an particular frontend NodeJs application container application we get an particular problem, the deploy was executed as expected, and the function was up and running with the app. But the action get into a loop trying to redeploy the aplication several times and stuck on Github Actions until fail by timeout.
These are the stuck log's in Github Actions. This happens even when we try to re-run the pipeline, but only on this particular application.
Can you help us?

Facing the same issue. Deploying a ReactJS app via container registry is stuck after 'Restarted app service' message. In my case, it does NOT seem be getting into the re-deployment loop though. The App seems to be running as well

@alfjjacob : we are looking into this performance issue, between can you please provide time taken for specific steps in azure/webapps-deploy@v2 ? also the time it took in the build phase.

@rahulaga-msft - Build is taking ~5secs but the deploy is stuck for several minutes

UPDATE: Having this same issue with any container deploy to WebApp, when the deploy hapens with Azure Functions the action works as expected.
PS: I made a mistake when I said this issue causes a loop, the deploy just stuck after conclusion and the log "Deployment passed!" without make any loop. The pipeline just stuck on this step, but the application update reflects on Azure Webapp.

UPDATE: I tried to resolve this issue to open a PR on this repository, and I've found the function where the problem happens, but I cant resolve this without broken another feature on this action.
To resolve this issue, I just remove the if statement which calls the addAnnotation method (from 'azure-actions-appservice-rest/Utilities/AnnotationUtility')  on method    UpdateDeploymentStatus and the action works deploying containers in functions and webapp's.
The method can be found at /src/DeploymentProvider/Providers/WebAppDeploymentProvider.ts

Reviewing the deployment step to determine why it is taking longer

We are tracking this issue as https://github.com/Azure/webapps-deploy/issues/229.


fix: remove scroll to bottom

:tada: This PR is included in version 1.1.7 :tada:
The release is available on:

GitHub release
1.1.7
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Design issues with importing keys from Keysync

My intention is to sync my OTR key from pidgin onto ChatSecure on my phone. I ran KeySync on my desktop:
$ keysync -i pidgin -o chatsecure
Reading pidgin files...
('', None)

Scan this QR Code:
<QR Code>

or enter this password into ChatSecure:
        <Base64 string>

I've failed to find any screen in ChatSecure for reading the QR for a key, or where to type this string. There are no instructions anywhere, and if there's a "scan key from QR" screen, it's impossible to find.
One of the two UIs (or both) need some work to make the procedure understandable.

I moved on to using the otr_keystore.ofcaes file. I copied it to /otr_keystore.ofcaes, as indicated, but I still get a message saying "Please copy the otr_keystore.ofcaes file from the desktop OtrFileConverter tool to the root directory of your device storage".

This messages fades stupidly fast, and I need to run this three times to read it completely. It should be a proper window with confirmation, IMHO.
I already copied the file, so something else is wrong. Permissions are 744, so I'm at a loss. The error message is probably wrong (a file selection would probably be more friendly too).

Keep in mind: This isnt' actually a support request: "who do I do this", but rather a proper bug report: the bug is that the usage is too unclear for even someone quite tech-savvy to understand.
My suggestion (which I should have mentioned before) is to add an "import keys" subsection on the account settings, which a button to select "otr_keystore.ofcaes" via a file picker.


How to import customStatement ?

import 'package:drift/drift.dart';   import 'package:drift/native.dart';
But can't import customStatment

Please correct in the documentation if this is a realtime instance method

customStatement is indeed an instance member on the database class.
The documentation mentions that the snippet should be placed inside the database class, so I think it's fine?

yes, explicit is better than implicit It is better to correct the documentation ))


Bump to v2.1.5

coverage: 92.659% (-0.01%) from 92.669% when pulling 98ee1276e1bb9d2ba94b1786fb0638c816460515 on bump_v215 into 02621e1cd248cd0d4216d2b6e87277cf0e8b7cd2 on master.


Ivvi/termchar

Fixes #276
Changes proposed in this pull request:

Explicitly set VI_ATTR_ASRL_END_IN to 0 (false)
Use multiple block read as a safety fallback

@AdriaanRol @giulioungaretti @alexcjohnson

Closing this as merged in #320 !


Add documentation

I've been working with people in the virtualdom room on IRC to create some documentation for people interested in working with virtual-dom directly. If you want to read them online, I've tagged the release at https://github.com/littleloops/virtual-dom-docs-wip/tree/0.1
Although the docs cover things in both vtree and vdom, @neonstalwart recommended vtree as the place to keep the documentation. Let me know your thoughts on this, and if you find any problems in the docs.

did this ever make it into virtual-dom?

Hey @neonstalwart, I had to concentrate on non-frontend related dev for a while, but I'll be moving back into virtual-dom/mercury development again this upcoming week, which should give me a chance to do the updates I need to the docs (Raynos asked for some examples to be moved from to virtual-hyperscript now that it's officially part of the project) and resubmit them to the merged virtual-dom. I'll pop into IRC as well this weekend and say hi.

cool.  just wanted to make sure we didn't forget these docs - i think they're really valuable.


annotation widget mac specific issues

For the hackathon we will merge the annotation widget as is but there could be some specific mac issues:

[ ] when saving an element, the View widget is not updated. Workaround: from the element widget add the element, and delete it; now the View widget is updated an it works.
[ ]  The colors of the annotation widget do not correspond to the colors used for plotting, easy fix.
[ ]  The "Annotation table" dropdown combobox does not update the color classes.
[ ]  when trying to plot instance_key an error is raised. The user playing around with the annotation widget may encounter this bug because the table created has only a few columns, so it's likely to try to plot instance_id.

A reminder to myself (or anyone with a Mac) to check if https://github.com/scverse/napari-spatialdata/pull/261 has fixed the bugs reported above.


HeLMS - Add trigger for unit in zone with altitude extents

Some lua to use in the condition predicate of a trigger.

Basic version of this included in v1.11


:recycle: use safe way

feel like breaking your private list, hesitate for 5s about _dashprivate_config  :no_bell:

:+1:


[front end] operation module fix bugs

Codecov Report
Base: 73.83% // Head: 73.83% // No change to project coverage :thumbsup:

Coverage data is based on head (ad76e21) compared to base (4e7d4cb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #23   +/-   ##
=========================================
  Coverage     73.83%   73.83%
  Complexity     1430     1430
=========================================
  Files           154      154
  Lines          5889     5889
  Branches        670      670
=========================================
  Hits           4348     4348
  Misses         1261     1261
  Partials        280      280

Flag
Coverage Δ

unittests
73.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Admin Award Table

I noticed in the award table file the image variable was set incorrectly. Below is the details.
        @if($award->image)
          image }}" name="{{ $award->name }}" alt="No Image Available" />
        @else

Changed:
        @if($award->image_url)
          image_url }}" name="{{ $award->name }}" alt="No Image Available" />
        @else

I will be making this table paginated as well. I think if you have 50 awards it would be nicer in pages :D


Speed up data transformation time

67 subjects for the Dengue subset, converting ~30 observations/conditions:
Patient took 1.19 seconds to convert 67 rows.
Encounter took 1.31 seconds to convert 67 rows.
Observation took 6.85 seconds to convert 2194 rows.
Condition took 5.99 seconds to convert 461 rows.

The resources are independent so can be parallelized, probably most of this is due to unpacking and repacking from fhir.resources which is yet to undergo a rewrite to support Pydantic v2 (which is much faster). Will take a look with a profiler.
Alternative could be to parse and validate in two steps - parsing and conversion should be relatively fast, as that would just need the mapping file, without any reference to fhirflat.resources. Validating would still need construction of resource object, but that could be parallelised across rows/resources.

Using pandarallel for ingest_to_flat() conversions to/from object format provides a significant speedup, even without parallelising across different resources -
Patient took 1.18 seconds to convert 67 rows.
Encounter took 0.97 seconds to convert 67 rows.
2 resources not created due to validation errors. Errors saved to encounter_errors.csv
Observation took 2.19 seconds to convert 2194 rows.
Condition took 1.33 seconds to convert 461 rows.

Also see https://pandas.pydata.org/docs/getting_started/install.html#performance-dependencies-recommended


Wiki: Add HowTo work with templates

Wiki how templates works, nice links to doc, and tips and tricks to know before diving head first in this ;)

done


deploy commands run as root, not lobsters

In roles/lobsters/tasks/main.yml the opening couple tasks need to run as root, but from migrate database most (all?) of them should be running as the user lobsters, not root. This was a bug when I was deploying the scout gem: the migration command ran as root, scout created a new log/scout_apm.log, then the following command to recompile assets failed because it couldn't open a root-owned config file. Not sure why this one wasn't running as root, actually, but for sure all of them should be explicitly running as lobsters.

This has been fixed for a while.

This has been fixed for a while.


NodeJS 8.x is Deprecated

Hi,
The version of NodeJS suggested in the installation instructions (8.x Carbon) is now deprecated.
Following the installation instructions gives a big red warning to this effect.
Does Glass support either NodeJS 10.x or 12.x, which are the newer LTS releases?

I have it working with v10.19.0

doesn't work with 14. will try with 10 later.  thank you for the info

I have it working successfully on version 12.20.0

I am also running it on node 12 without issues.

Hi,
installed it today on a raspi which has Node.js v10.23.1 installed.
during install lot of warning messages including:
npm WARN npm npm does not support Node.js v10.23.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
could nevertheless access glass on port 3000 but after some clicks it crashed with:
[Glass Server] Slack alert triggered, but no webhook configured...
[Glass Server] Loading E-Mail template...
[Glass Server] Loading E-Mail template... DONE...
[Glass Server] Sending E-Mail Alert...
/bin/sh: 1: ./bin/dhcpd-pools: Exec format error
child_process.js:669
throw err;
^
Error: Command failed: ./bin/dhcpd-pools -c /etc/dhcp/dhcpd.conf -l /var/lib/dhcp/dhcpd.leases -f j -A -s e
/bin/sh: 1: ./bin/dhcpd-pools: Exec format error
at checkExecSyncError (child_process.js:629:11)
at execSync (child_process.js:666:13)
at Timeout._onTimeout (/opt/glass-isc-dhcp/app.js:322:21)
at ontimeout (timers.js:436:11)
at tryOnTimeout (timers.js:300:5)
at listOnTimeout (timers.js:263:5)
at Timer.processTimers (timers.js:223:10)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node ./bin/www
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-01-12T16_24_53_259Z-debug.log

Hi,
installed it today on a raspi which has Node.js v10.23.1 installed.
during install lot of warning messages including:
npm WARN npm npm does not support Node.js v10.23.1
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
could nevertheless access glass on port 3000 but after some clicks it crashed with:
[Glass Server] Slack alert triggered, but no webhook configured...
[Glass Server] Loading E-Mail template...
[Glass Server] Loading E-Mail template... DONE...
[Glass Server] Sending E-Mail Alert...
/bin/sh: 1: ./bin/dhcpd-pools: Exec format error
child_process.js:669
throw err;
^
Error: Command failed: ./bin/dhcpd-pools -c /etc/dhcp/dhcpd.conf -l /var/lib/dhcp/dhcpd.leases -f j -A -s e
/bin/sh: 1: ./bin/dhcpd-pools: Exec format error
at checkExecSyncError (child_process.js:629:11)
at execSync (child_process.js:666:13)
at Timeout._onTimeout (/opt/glass-isc-dhcp/app.js:322:21)
at ontimeout (timers.js:436:11)
at tryOnTimeout (timers.js:300:5)
at listOnTimeout (timers.js:263:5)
at Timer.processTimers (timers.js:223:10)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: node ./bin/www
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!


⚠ Secret Website 3 has degraded performance

In a1540f6, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 3054 ms

Resolved: Secret Website 3 performance has improved in a74f2e7.


Jekyll --server : missing mime-types for video

Hi,
I'm making an S5 presentation collection site for myself as embedding video in a presentation is historically a colossal pain in the behind. S5 & Jekyll suited me well, but when run locally I found that Jekyll serves the pages with a very limited mime-type list.
I added:
mime_types.store 'webm', 'video/webm'
mime_types.store 'ogv', 'video/ogg'
mime_types.store 'ogg', 'video/ogg'
to bin/jekyll, right after line 269
This works for me, but I imagine a gem update will ruin my day. Also others might want to have a more robust mime-type list.
I would like to suggest importing apache's mime-types.
Thanks for the great work, I use it with a great deal of pleasure.
Kind regards,
Sander

conneced #406
h5bp .htaccess is good source of proper MIME types


Window buttons (Minimize, Maximize) are wrong color when using ExtendClientAreaToDecorationsHint and dark theme

Describe the bug
The window buttons for maximize and minimize actions are always white background on hover, regardless of theme selection (fluent, simple), when using the dark variants.
To Reproduce
Create a 11.0.5 project, set the ExtendClientAreaToDecorationsHint property on your window to true, set  RequestedThemeVariant="Dark" in your App.axaml, run the project, hover over the window buttons
Expected behavior
On light themes, the button foreground (the minimize/maximize icons) should be black, while the background should be white, or light gray on hover - this works fine.
On dark themes, the button foreground should be white (works), while the background should be dark gray (also works), and a lighter dark gray on hover (<-- this doesn't work).
Screenshots

Environment

OS: Windows 10
Avalonia-Version: 11.0.5

closing as duplicate


groveloudness: Initial implementation

This module implements support for the Grove Loudness sensor.
Signed-off-by: Jon Trulson<EMAIL_ADDRESS>Signed-off-by: Zion Orent<EMAIL_ADDRESS>

Wonderful!  Added just a bit more to the description of the sensor and pushed.  Thanks much!


fix(planning_test_utils): delete duplicated publisher and spinsomenode

Description
fix duplicated publisher of route and spinsomenode function

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

close this PR because change in this PR is not needed if this is merged.


Add tag support to API Gateway keys

This PR add support for API Gateway key tags.
boto3 support tags since version 1.9.154.

Coverage increased (+0.0002%) to 93.251% when pulling 59852eb13aef9869ae8b6b2f80b76ddb98a46239 on gdippolito:master into 3a5d857a60c3a2d140ed2c8adfe8dcaf71a4cac8 on spulec:master.

Thank you!

We release a prerelease on every commit: https://pypi.org/project/moto/#history


[enhancement] add token support to replace ssh connect would be better

just a advice
using ${{env.repo}} and ${{env.token}} to connect the github repo
btw : add a basic auth or pass for the edit part would be better

Thanks for the feedback

using ${{env.repo}} and ${{env.token}} to connect the github repo

I'll at it to the todo. Good idea!

btw : add a basic auth or pass for the edit part would be better

I don't know if I would like to go that route. This would at a lot of complexity to the "simple wiki". Especially when using multiple users (permissions etc...). If you have a clean way in mind, feel free to post it!

for the first advice, thanks for your acceptance.

I don't know if I would like to go that route. This would at a lot of complexity to the "simple wiki". Especially when using multiple users (permissions etc...). If you have a clean way in mind, feel free to post it!

yes, simple is the key for self-hosted.
but if u post the wiki online, at least the editor part have a simple encryption, in case every one can modify your repo data.

hi @Eloco
I added a basic password protection in #48, let me know if it fits your needs.


Offline fallback for GRANDPA

Motivation
GRANDPA voting is completely off-chain, so detecting offline validators and changing sets is difficult. Furthermore, changing validator sets is usually done in conjunction with finality -- when finality is stalled, how are we supposed to switch to a new set?
The answer is to fall back onto the block production system: GRANDPA is an asynchronously safe finality gadget, while the block production system is typically safe under synchrony. So if the block authors believe that nothing has been finalized for a sufficiently long time, we can trigger a "forced" set change that allows full nodes to begin to follow the new best set.
By nature, this forks off light clients (including warp sync), who won't be able to function again until aware of a trusted checkpoint after the forced change.

Abstract
Alistair described a scheme for figuring out when finality is stalled on-chain in the GRANDPA paper: https://github.com/w3f/consensus/blob/master/pdf/grandpa.pdf
To paraphrase:
Every block producer puts the highest block number that they see as finalised in their block.
Then any participant sees that if there is an n such that

their best chain is at least length n + 100
the indicators of the last finalised block height of blocks n-100 to n in their best chain have median at most n-1050 and
n is the minimum that satisfied 1 and 2.

Implementation notes
We implement this by adding an srml-finality-tracker which adds an inherent for block authors to report the finalized block, and records a rolling window of reports, tracking the median.
Whenever the median is sufficiently low (step 2 of above), srml-finality-tracker signals the listeners.
srml-grandpa is one such listener: when it is notified of finality lagging, it issues a new forced authority set-change event.
forced set changes are applied on block import, unlike regular set changes which are applied on finality.
substrate-finality-grandpa has been altered to handle these kinds of events.
TODO:

[x] Add tests for finality-tracker
[x] Add tests for srml-grandpa
[x] Add tests for finality-grandpa AuthoritySet struct
[x] Add tests for finality-grandpa's handling of forced changes
[x] Determine if this PR is breaksconsensus OR breaksapi -- I have been careful to keep storage and APIs backwards compatible but @gavofyork or @bkchr a careful review of the runtime to determine this would be appreciated.

How is this looking? @bkchr you happy to sign off?

(after talking with Al I'm not convinced there is still a lot to do to implement this and I'm not convinced it will backport well)

the StoredPendingChange stuff is pretty dodgy as the code will only work if the instance is the last item to be decoded from a byte stream. If it's within a Vec or is not the last field in a struct, then it'll break badly. In this case it looks like you'll get away with it though.

yeah -- this works because we only ever have them singularly in the storage in prior versions.

Basically what @alistairstewart recommends is that the old GRANDPA set stop running when the signal is fired (blockheight T) and the new one start at T+100 (or whatever). This requires some substantial machinery changes in GRANDPA.

I think this is ready for another review. Multiple standard authority set changes are allowed (#1808) and are kept in a ForkTree, forced changes are tracked separately in a Vec and only one is allowed per fork (since the changes are enacted on block height instead of finality, presumably there's no scenario where we would need more than one pending forced change). Currently there's no validation that the changes don't overlap, this is enforced by the runtime. I filed #1861 to improve this.
I've also changed the ImportResult enum, AlreadyQueued was never used and Queued didn't make sense since it's returned when the client actually imports the block. It was replaced with ImportResult::Imported(PostImportActions), where PostImportActions is a bitmask specifying actions to take after the block is imported like requesting a justification, or clearing pending justification requests.

When a forced change is applied the voter is restarted with the block that enacted the change as canon block. We could use the block that signaled the change instead, but this would make verification of justifications more complicated, since we'd need to check if there's any pending forced change (since forced changes would finalize "backwards") to figure out which validator set to validate the justification against. I've also filed #1867.

Discussed with @rphmeier and this still has some issues, will address them tomorrow.

@rphmeier @andresilva how is this looking?

I think it's ready for another review. I didn't approve the PR because most of the changes since the last review have been made by me and I'd like a sign off from @rphmeier.

I'll give it another review but not sure I can get to it this week. I'll try on the weekend or Monday.

When this PR is approved don't merge it right away since I'm still doing some local testing.

Contesting the patch label -- this is probably a bit too unstable to backport to earlier testnets safely.

I removed the patch label but we should still backport this and disable the finality tracker module (otherwise it will be harder to backport new fixes for grandpa).


Navbar dropup

This is fix for https://github.com/twbs/bootstrap/pull/23520

There is no need redefine .dropdown-toggler in navbar.
Everything should work from _dropdown.scss
Move .dropdown-menu positions to media-breakpoint-up in .navbar-expand

codepen with css changes
https://codepen.io/anon/pen/PJOEoo

Already done here : https://github.com/twbs/bootstrap/pull/24244 :wink:

Yeah :) I already saw :)


[WIP]: Portico Navbar.

This is the new navbar for all logged-out portico pages. It features a new menu system that allows for a user to click into a lot more zulip links than they previously could.

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

This has some linter failures.

This has been replaced in favor of a simpler green nav in portico.


[Go] pinecone, localvec: support multiple indexes

We'd like to have the invariant that every plugin can be fully configured with a single Init call.
A program might want to use multiple distinct DBs (namespaces, indexes, what have you) from the same vendor.
It follows that the Init method must support multiple names. Each might have its own embedder. Thus a Config struct for a vector DB plugin should have something like
type Config struct {
   ...
   Indexes []IndexConfig
}

type IndexConfig struct {
    Name string
    Embedder *ai.EmbedderAction
}

Something like #367 is a mistake, because to use multiple indexes you have to make multiple Init calls, and that is against the Genkit spirit of initializing everything at program startup so the UI can see all the pieces.

I did this for localvec. #367 was redeemed by having Init return slices of actions.


traceparent/tracestate not in outgoing request headers

Description/Screenshot
Upon following the instructions here to enable  distributedTracingMode with AI_AND_W3C, AI, or W3C, i'm still not seeing traceparent/tracestate on outgoing request headers.
Steps to Reproduce
Follow regular instructions for applicationinsights setup for web as well as react-native plugin and set distributedTracignMode property of ApplicationInsights config object to DistributedTracingModes.AI_AND_W3C using type IConfig | IConfiguration
import { ApplicationInsights, DistributedTracingModes, IConfig, IConfiguration } from "@microsoft/applicationinsights-web";
import { ReactNativePlugin } from "@microsoft/applicationinsights-react-native";
// ---
const appInsightsConfig: IConfig | I Configuration = {
      disableAjaxTracking: false,
      disableCorrelationHeaders: false,
      disableFetchTracking: false,
      distributedTracingMode: DistributedTracingModes.AI_AND_W3C,
      instrumentationKey,
    extensions: [RNPlugin]
};
const appInsights = new ApplicationInsights({ config: appInsightsConfig });
appInsights.loadAppInsights();
// ---

OS/Browser: iOS, React-Native application, Typescript
SDK Version [e.g. 22]<EMAIL_ADDRESS><EMAIL_ADDRESS>How you initialized the SDK: npm setup

Expected behavior
Expected to see traceparent/tracestate on outgoing requests.
Additional context
Even though this bug is resolved I tried to match the header params according to this thread just in case.
Descriptions of urls:
* General Headers
    * Request URL: https###
    * Request Method: GET
    * Status Code: 200 OK
    * Remote Address: ###
    * Referrer Policy: no-referrer-when-downgrade
* Response Headers
    * Content-Encoding: gzip
    * Content-Type: application/json; charset=utf-8
    * Date: Fri, 05 Jun 2020 20:52:06 GMT
    * Request-Context: appId=###
    * Transfer-Encoding: chunked
    * Vary: Accept-Encoding
    * x-content-type-options: nosniff
    * x-correlation-id: context.Request.Headers.GetValueOrDefault("x-correlation-id","")
    * X-Powered-By: ASP.NET
* Request Headers
    * Provisional headers are shown
    * accept: text/plain
    * authorization: ###
    * content-type: application/json
    * dwp-apim-subscription-key: ###
    * User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) ReactNativeDebugger/0.10.7 Chrome/78.0.3904.130 Electron/7.1.9 Safari/537.36
    * x-app-version: 1.0
    * x-build-version: 1
    * x-correlation-id: ###
    * x-user-session-id: ###
* Query String Parametersview source
view URL encoded
    * top: 10

"###" - indicates that the field is present but left out for sensitivity reasons
@markwolff Is this what you're looking for?
I'm relatively new to App Insights so please let me know if there is not enough information or if this is not the best place to post this.
Thanks,

Could you provide a network trace or describe the urls your app is on and to where requests are being sent? One thing that could be required is enableCorsCorrelation if you are sending cross origin requests here.

@dlewis2017 This would be the correct place to ask! Just trying to understand what type of outgoing requests you are making:

Is your app itself making the requests? Or is it within some sort of embedded webview that is making them?
Are they to a url outside of your app? For this, you should try adding enableCorsCorrelation: true to your config and see if this resolves the issue.

enableCorsCorrelation: true should be enough to get the traceparent. but tracestate is currently not supported, see https://github.com/microsoft/ApplicationInsights-JS/issues/1291
Following config must work:
const appInsights = new ApplicationInsights({
  config: {
    instrumentationKey,
    distributedTracingMode: DistributedTracingModes.W3C,
    enableCorsCorrelation: true
  }
});
appInsights.loadAppInsights();

@alaingiller okay thanks. I'll reduce my config to just that and see if it works.

@alaingiller @markwolff I tried stripping down the config to what is presented above and still no luck.
I'm using the Network Inspect feature of React Native Debugger to check the requests. I also checked App Insights with no luck.

Just to follow up @alaingiller @markwolff A teammate of mine tried to step through app insights sdk via chrome debugger and saw the correct attached headers. Seems to be a React Native Debugger issue. Thanks for the insights!

I just wanted to add more details for anyone who tries to debug network requests thru React Native Debugger - this issue seems occur when enabling Network Inspect on React Native Debugger.  It uses a Web Worker to send XHR requests when it gets enabled, and the mechanism in which App Insights JS SDK uses to catch those XHR events do not get hit.  As soon as I turned off Network Inspect, the XHR send event callback was being hit again.


Library does not handle Activity re-creation by Android system

Description
On low end Android hardware (2 GB of RAM), at some point in the functioning of an application, when trying to take some pictures with the library, the Android OS will kill the host application and re-create it after the takePictures intent is finished. Applications should handle these lifecycle methods themselves, but so should the react-native-image-picker library. When Android starts killing background tasks, the picture which was last taken will not be available to the host application and the library should be able on restart to provide this to the host application. Expo-image-picker recently implemented a similar functionality here: https://github.com/expo/expo/pull/9697/files although it is not complete there as well. They only take one case into consideration, the one where the activity is killed by the OS, but not the application. I don't know if in the latter case there might be a solution in the react-native ecosystem.
How to repeat issue and example
Use the react-native-image-picker library to launch the camera (or choose image, they should behave the same). Go to "Developer options" and set to true the option to "Don't keep activities". Take a picture. The picture taken won't be available to the calling application.
For the second issue (when the application gets destroyed instead of the activity), also change the "Background process limit" in "Developer options" to "No background process".
Solution
Persist the image information onHostDestroy and provide a callback for the host application to check if it was restarted and there is a pending image request.
For the second issue I am not sure what solution can be applied
Additional Information

Image Picker version: v3.0.0-vnext.3 (present in older versions as well)
React Native version: 0.63.3
Platform: Android
Development Operating System: Windows
Dev tools: Android Studio, tested on device and emulator with Android 10 OS

Note: There are multiple issues opened on this platform which are actually related to this specific particularity. The issues labeled: "Application restarts without error after taking picture" or similar titles are related to this issue that the Android OS will restart the background application if it needs to free up memory.

Thanks for the report. I know the issue exist, but don't know the right way to solve it. From what I know react-native uses just single activity for whole app lifecycle. So if the activity is recreated, then your apps unsaved data all be lost. Your app will open from first screen. So you need to handle the navigation to the screen he was before restart and handle the new image data.
I will look into it, but solution may not be straightforward as you think and sometimes may be not worth adding (because there is no 1gb android phones in even Indian market).

Thank you for the reply. As I said in the report, the application will handle navigation and recreation of the previous screen on startup (for e.g. my application allows the user to upload multiple pictures before submitting them to a back-end API. When the activity goes to background, we persist the state (what images were already taken) and we are able to show them when the application restarts). The main issue is with the last picture the user will take because for that one we get no response from the ImagePicker. If the ImagePicker itself hold the last taken image somewhere and will provide a callback that the host activity can call upon re-creation then the application may fully restore it's state, even with the latest image taken.
The issue is present on a Samsung Galaxy TabA7 tablet (i think it is 2018) which has 2Gb of RAM memory an uses ~1.5 Gb from startup. It might be that Samsung OS more aggresively kills background tasks than other OS but Samusng devices are still a big market share.
I started working on  a solution for what our project needs (only the basic launchCamera functionality) and I am storing the latest picture in sharedPreferences and provide a callback that the host may call to check and retrieve the pendingImage if there is one. Initial tests are quite promising. I will let you know if we are successful and with what solution (I started working on the 2.x version for the moment as I do not want to handle permissions myself).

Good, but you can work on 3.x.x because there is no permission for android. Check docs.

Just adding some information.
I have a 4GB ram phone and experiencing the same issue.
To reproduce it i leave the app in background for about 20 minutes and the first attempt to take a picture makes de app restarts. The second attempt work normally as well as the next ones.

I have founded this PR about this problem, i think its a good shot:
https://github.com/react-native-image-picker/react-native-image-picker/pull/763/files
Issue related:
https://github.com/react-native-image-picker/react-native-image-picker/issues/732

I have founded this PR about this problem, i think its a good shot:
https://github.com/react-native-image-picker/react-native-image-picker/pull/763/files

Thats a different error case, can you paste your android stacktrace if any. Use logout

Unfortunately this is beyond the scope of this library since there is an issue with how react-native handles onActivityResult after the react context is re-created. The issue can be followed here: https://github.com/facebook/react-native/issues/30277. I was unable to adapt this library to do something about these use cases. @deadlock indeed it can happen on devices with more memory if the OS is highly constrained in memory or the current application uses too much memory. It may also vary between devices with the same memory capacity since different proprietary OS may be more aggressive in killing background tasks.

To me it seems like this only started happening after I updated Android Studio to 4.1, targetSDK to 29 and also gradle. After that this started happening and I have no clue why. Everytime I take a picture the app just restarts, I was actually using react-native-crop-image-picker on the app before, then changed to this one but the exact same issue happens.
I'm also currently on<EMAIL_ADDRESS>

Reverting here with some more information. For anyone not looking for fancy camera options, just the ability to take pictures or start video recording, you can use the React Native Camera library (https://github.com/react-native-camera/react-native-camera) to overcome this issue with activity being re-created by the Android system. The difference is that the RNCamera library does not launch a new Android activity (just embeds the camera wherever you specify it to do it) which means that your current React application will remain active, even when taking picture/recording video.
If you want to allow the users of your application to launch an intent with their preferred choice of camera application then you need to find other solutions. Regarding this specific library, we will need to wait for the react native issue to be addressed. @ravirajn22 I don't know if you want to close this issue or just keep it as a reference for all similar issues that might pop up. I don't think there is anything you or any other library contributor can do regarding this issue until the react-native team tackles their issue.

Thanks @zandrei for the info.
For your info, embedding camera requires "Camera permission" on android but it provides various customisation.

Issue still persist of app restarted when clicked for camera after installing react-native-camera. Any solution , thanks in advance

@tomNjerry if you started using the react-native-camera library then you should redirect your issues to the react native camera github page (link in the post above). Normally, if you used the react-native-camera and embedded the action to take pictures in one of your pages then the react application never goes to background and cannot be killed by the Android OS. Bear in mind though that if the user minimizes your application (by pressing the home button), your app might still be killed by the Android OS so you should still think on what you need to do for your specific application to persist its state and re-create it when it is re-created by the Android OS. (this might mean you would need to persist navigation state and also any other information that was not persisted to a back-end API when the application goes to background and then read from the storage when your application is re-created by the Android OS).

Just adding some information.
I have a 4GB ram phone and experiencing the same issue.
To reproduce it i leave the app in background for about 20 minutes and the first attempt to take a picture makes de app restarts. The second attempt work normally as well as the next ones.

Mine is 6GB, also happen.

Just adding some information.
I have a 4GB ram phone and experiencing the same issue.
To reproduce it i leave the app in background for about 20 minutes and the first attempt to take a picture makes de app restarts. The second attempt work normally as well as the next ones.

Mine is 6GB, also happen.

indeed it can happen on devices with more memory if the OS is highly constrained in memory or the current application uses too much memory. It may also vary between devices with the same memory capacity since different proprietary OS may be more aggressive in killing background tasks.

@lunajing read the previous reply to deadlock user. The most important factor is the memory already in use. You can use my suggestion here https://github.com/react-native-image-picker/react-native-image-picker/issues/1502#issuecomment-749447624 to fix your problem for now

indeed it can happen on devices with more memory if the OS is highly constrained in memory or the current application uses too much memory. It may also vary between devices with the same memory capacity since different proprietary OS may be more aggressive in killing background tasks.

@lunajing read the previous reply to deadlock user. The most important factor is the memory already in use. You can use my suggestion here https://github.com/react-native-image-picker/react-native-image-picker/issues/1502#issuecomment-749447624 to fix your problem for now

We are also facing this

Hello, I also encountered this difficulty. Is there any way to know if the phone has this behavior? So know if I show the image picker or use the rn-camera

also facing the same issue on Android 10
App restart after taking pictures from camera
please help with any solution!!!

Also facing this problem  :(

i have this erro Caused by: java.lang.IllegalStateException: Screen fragments should never be restored. Follow instructions from https://github.com/software-mansion/react-native-screens/issues/17#issuecomment-424704067 to properly configure your main activity.

I am facing the same issue for launchCamera  launchImageLibrary
The application re starts
Is there any fix for that

Hi, any changes? how resolve this?
on ios work fine, on some android restart the app

On android, it can be reproduced by enabling "Don't keep activities" under Android Developer Option.
Then, every time you launch the image lib or camera, the app restarts.

I am still facing this issue, any updates on this.
using react-native 0.67.3 & react-native-image-picker 4.8.2

same issue at jul 2023 in phone with 4 ram an i open the app with nothing in background.

Same here. At first, I thought it was related to a memory issue, but it sounds like on Samsung S20 FE 5G, my app is ending when in the background and when I hit ok after taking a photo, it just gets restarted on the home page.

Still facing same app restart issue.

Still facing same app restart issue.

Yep, see this : https://github.com/jive/gotoconnect-mobile/pull/10295 to help you guys


Add support for '--' argument separator

Depends on https://github.com/aspnet/Common/pull/145.
Lays the foundation for allowing dotnet-watch to have command line flags such as --log.
Update README.md.
cc @victorhurdugaci

Is there any plan to add any arguments right now? If not, I'm not sure that we want this change yet /cc @glennc

I was thinking of adding --log <LEVEL> and/or --verbose

Sync with @glennc , I think he should approve that. Right now you have way to pass it. I think if the number of options we plan to add to dotnet watch is small (<5), we shouldn't complicate the command line, especially if those options are used by very few people.

Most usages don't need '--'. It's an optional arg that makes definitive which args are "mine" vs "theirs".
IMO it's not a matter of complicating/simplifying the command line. This is about env variables. Long environment var names are hard to discover and clunky to set. Adding '--' would allows us to do command line args for these settings (e.g. --log or --polling).
cc @glennc

Talked with @glennc. The clarify this, the primary purpose of '--' is to make deterministic the split between which args belong to dotnet-watch (subset 1) and which should be passed through to the inside command (subset 2).
The only good example we have of this at the moment is '--help'

Input
How dotnet-watch splits args into the sub command

dotnet watch --help
dotnet watch --help  / (no sub args)

dotnet watch -- --help
dotnet watch / --help

But let's say we start adding more options, like --verbose, here are implications:

Input
How dotnet-watch splits args into the sub command

dotnet watch --verbose -- run --verbose -- a b c
dotnet watch --verbose / run --verbose -- a b c

dotnet watch -- run --verbose -- a b c
dotnet watch --verbose / run --verbose -- a b c

dotnet watch run --verbose -- a b c
dotnet watch / run --verbose -- a b c

dotnet watch --verbose run
dotnet watch --verbose / run

dotnet watch -- --verbose run
dotnet watch / --verbose run

dotnet watch --verbose --verbose run
Error!

dotnet watch --verbose -- --verbose run
dotnet watch --verbose / --verbose run

Ping @glennc. Are you okay with "--" support in syntax for dotnet-watch?

Talked with @glennc. We're okay moving ahead with this.
cc @moozzyk

:up: :date:

One small comment and then :ship::it:


Property Widget: action button icons can get outside content group area depending on widget width

Repro Steps:

Select any element in the view.
In properties widget, add favorite property and share it.
Start reducing panel width where properties widget is housed.
Notice that at certain point, share icon starts to clip content group border and eventually gets outside the borders. It would be ideal, to treat share icon as a content within the group and keep it within the borders.

Note: As you reduce the width further to min-width, the icon position did get corrected however.

Version used:
@itwin/property-grid-react: 0.9.0
Here's our work item:
https://dev.azure.com/bentleycs/beconnect/_boards/board/t/iModel Viewer Framework Service/Backlog items/?workitem=1198433

Can you try out @itwin/property-grid-react: 0.10.0? It should work fine in that version.

Seems like that fixes the problem. Thank you!


Unsupported platform builds shouldn't need to manually specify -DNOTEST=1

We can't build tests on unsupported platforms because they require EGrabber.h. We can add the NOTEST flag when we configure in order to get around this, but we could also just set NOTEST=1 when we can't find the EGrabber library.

I'm generally in favor of putting things like that in a sandbox module that you have to turn on behind a CMake flag. Happy to do this if that's the way you want to take it.


[RELEASE] 1.4.4

What's the task? Please describe.
Action items for releasing v1.4.4
Describe the sub-tasks.

Pre-Release

[x] Regression test plan (manual) - @khushboo-rancher (https://github.com/longhorn/longhorn/wiki/Release-Test-Plan---1.4.4)
[ ] Run e2e regression for pre-GA milestones (install, upgrade) - @yangchiu
[ ] Run security testing of container images for pre-GA milestones - @roger-ryao
[ ] Verify longhorn chart PR to ensure all artifacts are ready for GA (install, upgrade)  @chriscchien
[ ] Run core testing (install, upgrade) for the GA build from the previous patch and the last patch of the previous feature release (1.4.2). - @yangchiu

Release

[ ] Release longhorn/chart from the release branch to publish to ArtifactHub
[ ] Release note

[ ] Deprecation note
[ ] Upgrade notes including highlighted notes, deprecation, compatible changes, and others impacting the current users

Post-Release
~- [ ] Create a new release branch of manager/ui/tests/engine/longhorn instance-manager/share-manager/backing-image-manager when creating the RC1~

[ ] Update https://github.com/longhorn/longhorn/blob/master/deploy/upgrade_responder_server/chart-values.yaml @PhanLe1010 (reviewer: @mantissahz )
[ ] Add another request for the rancher charts for the next patch release (1.4.5) @rebeccazzzz

Rancher charts: verify the chart is able to install & upgrade - @khushboo-rancher

[ ] rancher/image-mirrors update @mantissahz  (reviewer: @PhanLe1010 )
[ ] rancher/charts 2.7 branches for rancher marketplace @mantissahz  (reviewer: @PhanLe1010)

cc @longhorn/qa @longhorn/dev

@longhorn/qa RC1 is ready. Please help with the testing. Thanks.

https://github.com/longhorn/charts/tree/v1.4.x
https://github.com/longhorn/longhorn/wiki/Release-Test-Plan---1.4.4

RC2 is planned for 10/20 (https://github.com/longhorn/longhorn/milestone/48) if required.
Also, 1.5.2 RC1 will be released together.

Vulnerability scanning

Build 1181 : ✅ 66 HIGH, 0 CRITICAL v1.4.4.-rc1

Analyze test result of SLES on 1.4.x (AMD)

Build 334 : 2 failed

tests.test_basic.test_aws_iam_role_arn failed on SLES on 1.4.x (AMD) #6912

test_csi_umount_when_longhorn_block_device_is_disconnected_unexpectedly #6533

Analyze test result of SLES on 1.4.x (ARM)

Build 324 :  2 failed

tests.test_basic.test_default_storage_class_syncup failed on SLES on 1.4.x (ARM)  #6913

test_csi_umount_when_longhorn_block_device_is_disconnected_unexpectedly #6533

@nitendra-suse are these failed test cases flaky or regression?

Run e2e regression for pre-GA milestones (install, upgrade):

v1.4.4-rc1

amd64: 2 failures
arm64: 2 failures
amd64 upgrade: 1 failure
arm64 upgrade: 1 failure

@longhorn/qa there are 11 issues not verified yet. Please pick up the issues and help with them.
https://github.com/longhorn/longhorn/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+milestone%3Av1.4.4
P.S. @khushboo-rancher Please help coordinate this.

@nitendra-suse are these failed test cases flaky or regression?

I am running tests again to verify for flaky.

@nitendra-suse are these failed test cases flaky or regression?

I am running tests again to verify for flaky.

@nitendra-suse any updates?

@longhorn/qa 1.4.4-RC2 is ready. Please use RC2 for the following testing.

https://github.com/longhorn/longhorn/releases/tag/v1.4.4-rc2
https://github.com/longhorn/charts/commit/d58c50bbddf8128acc4cb91d8da1cd9df1efc10f

Below are the changes after RC1. There are only two primary things here. @khushboo-rancher see what extra test cases we need to verify.

https://github.com/longhorn/longhorn/issues/6829
https://github.com/longhorn/longhorn/issues/5509

longhorn-ui

release: v1.4.4-rc2 3b61757

longhorn-manager

release: v1.4.4-rc2 65805d0d
fix(import): typo b0af7ed8
style: imports 01b336e4
feat(log): add function name and line number in log message c6c38512

longhorn-engine

release: v1.4.4-rc2 e05b1d1e
feat(log): add function name and line number in log message 0d23b296

longhorn-instance-manager

release: v1.4.4-rc2 12b3a47
feat(log): add function name and line number in log message 31ed421

longhorn-share-manager

release: v1.4.4-rc2 08fe1e9
feat(log): add function name and line number in log message 90c90bb
Create volume export config when volume is ready 4931b9f

backing-image-manager

release: v1.4.4-rc2 9d2a7e7
feat(log): add function name and line number in log message 3cc25c5

Run security testing of container images for pre-GA milestones:
v1.4.4-rc2: 69 HIGH, 0 CRITICAL

@nitendra-suse are these failed test cases flaky or regression?

I am running tests again to verify for flaky.

@nitendra-suse any updates?

Tests are flaky :
amd64 results  : test_aws_iam_role_arn not reproduceable
amd64 results

Verify longhorn chart PR to ensure all artifacts are ready for GA (install, upgrade)

[x] longhorn/chart PR - result
[x] chart PR - result

Run core testing (install, upgrade) for the GA build from the previous patch and the last patch of the previous feature release (1.4.3)
amd64: 0 failure
arm64: 0 failure
amd64 upgrade: 0 failure
arm64 upgrade: 0 failure

@mantissahz Please help with the rancher chart and you can consult with @PhanLe1010 .
@khushboo-rancher @roger-ryao Please help with verifying the Rancher chart when it's ready.

Hi @innobead :
I noticed that the default branch for Rancher is dev-v2.8.
Do we also need to create rancher/charts 2.8 branches for the Rancher Marketplace?
cc @PhanLe1010 @mantissahz @khushboo-rancher

I noticed that the default branch for Rancher is dev-v2.8.
Do we also need to add rancher/charts 2.8 branches for the Rancher Marketplace?

@roger-ryao Yeah, it is, so I started to add the v1.4.4 chart to dev-v2.8 yesterday.
@innobead Do I need to continue working on this?

We should have longhorn into active branches including 2.7 and upcoming 2.8.

@mantissahz Please let me know if all Rancher chart PRs ready and merged, and then we can close this issue.
cc @PhanLe1010

Hi @innobead
https://github.com/rancher/charts/pull/3217 has been merged, and we have verified it.


[BACKLOG-6213] Fixing getNrSubdirectories now that /etc is hidden. Te…

…st added to verify and prevent regression.

@mdamour1976 Should do it


Try to spiff up show location

coverage: 94.375% (-0.02%) from 94.396%
when pulling 53b1e4b7ee19ed755ac2cc266174311f1673cafd on nimmo-show-location
into f7361b54f1a21cc53ec8f83403966d66bb498430 on main.


opening a project going from dark mode to light mode does not work well

either we should fix it or remove the ability to have different themed projects
https://github.com/user-attachments/assets/9cf7e149-e530-4753-b5ea-77c56974ce71

I think Dark/Light Theme should be an app-wide setting, not per-project. I've never seen any other software offer per-project light/dark theme.

Yeah I agree, and we turned off Theme as a project-level setting in #3312. I think the settings parsing system would still pick it up though, what that PR did was just turn off users' ability to change the setting, not whether the app would respect it. @jessfraz does that project you opened in your video have a theme setting in its project.toml?
I think the visual regression is not really the result of that, but rather due to some hasty changes I made to global CSS while trying to create #3794. I suspect light OS + dark theme and dark OS + light theme are what is happening here. It's the same issue I'm trying to fix for Josh.


Frontend alignment issues

Just some notes on things to fix regarding alignment:
homepage - discover section

Simple fix: process all the images here to the same ratio.
All the images are embedded as <img> tag instead of a <div> background image for accessibility reason. Set <img> to the same ratio from front end might cause the image distortion.

@wenqili - yes, let's do it this way. Handling image resizing etc etc can be a pain. Thanks for the tip!


[Var declarations] Wrong statement

For var declarations, write each declaration in its own statement.
Hi guys,
I think there is a typo in rules page. Please check and confirm it.
Thanks.

@dzotic9 Thanks for the issue. Can you explain what you think the typo is? I don't see an issue.


Restriction to my playlists

Hi,
I'm having trouble getting my playlists to play.  What is the recommended terminology to play only my playlists?  Or perhaps there is a way to restrict playlist searching?
I have a "Christmas 2019" playlist.  mycroft gets the "play christmas 2019 playlist" utterance correct and then plays something truly unexpected:
_play christmas 2019 playlist

Just one moment while I look for that
Listening to 2019 Electronica Playlist For Christmas Lounge by Various Artists._

Advice?

Hi,
Try "play the playlist Christmas 2019"

Aha thanks!  Any documentation on the expected verbiage or do I need to go through the skill code?  I plan to write my own skill in the near future but not yet familiar with it.

We should probably expand the list example phrases in the readme to include more of the specifiers
play something by X
play the artist X
play the album X (by Y)
play the record X (by Y)
play the song X (by Y)
play the track X (by Y)
play the playlist X

Yep, would be good!
Also, it looks like searching your own playlists is only supported in the app, not desktop.  Probably not supported in my raspotify/librespot.
https://community.spotify.com/t5/Desktop-Windows/Search-in-OWN-playlists/td-p/1555294

The skill has sort of a workaround for it. It periodically fetches the user's playlists and does an internal search through this list before doing the search through the public playlists.
My intention is to make it possible to specify "play my playlist X" to only search the users playlists.


Updated Transifex configuration for new CLI.

See https://developers.transifex.com/docs/migrating-from-older-versions-of-the-client.

LGTM
I've done a similar commit for djangoproject.com
https://github.com/django/djangoproject.com/commit/141c7603155a9e199d92a5df674abd96e750bcc3

Thanks both for checking :+1:


[AIRFLOW-1899] Fix Kubernetes tests

Make sure you have checked all steps below.
@dimberman
What do you think? I've missed your integration tests, but I was doing the same thing in parallel. I've created some tests that use the json-rest api to start a job, and then assert the state. Currently there is one sunny-day scenario, which is ok for now.
cc @bolkedebruin I also had some issues with timezones. Postgres complained that I needed to provide a timezone.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-1899] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1899
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3301 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
- Coverage   75.87%   75.84%   -0.03%
==========================================
  Files         197      197
  Lines       14706    14730      +24
==========================================
+ Hits        11158    11172      +14
- Misses       3548     3558      +10

Impacted Files
Coverage Δ

airflow/configuration.py
82.04% <ø> (ø)
:arrow_up:

airflow/bin/cli.py
63.75% <0%> (-0.04%)
:arrow_down:

airflow/jobs.py
82.84% <100%> (+0.28%)
:arrow_up:

airflow/www_rbac/views.py
72.37% <100%> (ø)
:arrow_up:

airflow/www_rbac/api/experimental/endpoints.py
83.91% <30.76%> (-5.32%)
:arrow_down:

airflow/models.py
86.6% <62.5%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ab796...be08077. Read the comment docs.

I think it's a really good idea to use the airflow API rather than kubernetes commands. I definitely still want the "kill scheduler then resume" test to remain since resuming tasks is really important.

@dimberman We're still using the API: https://github.com/Fokko/incubator-airflow/blob/9c5ce551013cb46b58584e51e04ac358a2e48b27/tests/contrib/minikube/test_kubernetes_executor.py
I agree with you that we should test this indeed.

@bolkedebruin Any further comments? I've split some unrelated changes into separate PR's and polished it a bit.

@Fokko sounds good. Could you please @ me in the other PRs? I've been fighting off a cold the last few days but should have time tomorrow to get some work done (And now that I know where the logs are I suspect it'll be a lot easier to work).


Release last sprint

Release

Update card address text #1221
Add ad blocker warning #1220
Implement new Stripe Checkout flow #1216
Fix StripePaymentResponse and InvoicePaymentResponse type definitions #1215
Fix local storage issues  needs review #1214
Update address form #1213

⚠ DO NOT MERGE ⚠
ed38de8793b85093a78737f3d197ce4c4635a081 needs to be reverted beforehand after testing the new Stripe Checkout flow


[openload] Add support for oload.win

Example link: https://oload.win/f/kUEfGclsU9o
Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

add test and you can also add https://oload.download


[150] Rake tasks can log in production

Followed this guide to get rake tasks to log http://macbury.ninja/2014/8/better-loging-in-rake-tasks
When RAILS_ENV is production or staging rake tasks will not log to STDOUT and therefore don't get collected by logspout and piped to Papertrail.
This will allow the Papertrail alerts to ping when we scrape a vacancy

 Rake task output should log to Papertrail

@tahb it needs rebasing


Import createNumberMask EmberJS

Tks for th addon. How Can I import createNumberMask in EmberJS?

I'm not really sure about Ember. @lozjackson might know?

Take a look at https://github.com/text-mask/ember-text-mask-addons
It imports the text-mask-addons into an ember-cli project.. see here for how to import the createNumberMask
https://github.com/text-mask/ember-text-mask-addons#createnumbermask

Work for me. Tks


ModuleNotFoundError: No module named 'requests'

hey brother
i download ur zip and "https://github.com/binance
/
binance-connector-python"
and wheni creat py folder and copie this "
from binance.spot import Spot
client = Spot()
Get server timestamp
print(client.time())
Get klines of BTCUSDT at 1m interval
print(client.klines("BTCUSDT", "1m"))
Get last 10 klines of BNBUSDT at 1h interval
print(client.klines("BNBUSDT", "1h", limit=10))" from your exemple i get this error
Traceback (most recent call last):
File "c:\Users\Admin\Desktop\binance-connector-python-master\binance-connector-python-master\oroginal Copie.py", line 1, in
from binance.spot import Spot
File "c:\Users\Admin\Desktop\binance-connector-python-master\binance-connector-python-master\binance\spot_init_.py", line 1, in
from binance.api import API
File "c:\Users\Admin\Desktop\binance-connector-python-master\binance-connector-python-master\binance\api.py", line 4, in
import requests

ModuleNotFoundError: No module named 'requests'
i didnt know what to do

Have you installed requestsmodule?
If not, please follow How to Install Requests Library in Python.

yes i did it dude i dont know why he said no module but i already have the
package look these 2 pic [image: Capture d’écran 2022-12-21 100158.png][image:
Capture d’écran 2022-12-21 100122.png]
Le mer. 21 déc. 2022 à 07:43, tungrix @.***> a écrit :

Have you installed requestsmodule?
If not, please follow How to Install Requests Library in Python
https://www.agiratech.com/install-requests-library-in-python.
—
Reply to this email directly, view it on GitHub
https://github.com/binance/binance-connector-python/issues/195#issuecomment-1360916747,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A44C24M4LXULUQ3JRKDUUBTWOKRJDANCNFSM6AAAAAATEXZLSA
.
You are receiving this because you authored the thread.Message ID:
@.***>

The images are not available.

help me plzzz :'(

bro i fix it by using another edi i use pycharm and fix the modules but after all that i get this massage !!

from the beggning he ask for api then when i put it he said ivalid api key

By calling print(client.account()), you are trying to fetch the data related to your account, so a valid api key and secret are necessary.

<3 <3 <3 i make it ty for help now i have another pb hahah but i will try buy myself and if ififnt get a sultion i will back to help me (not i m noob in info but i did my beast to learn hahah thanks again bro /sis <3)

Looks like it is not an issue.


adobe fonts provider

@danielroe If nobody's working on this, I'd love to work on this provider.
I'm currently thinking about specifying a kit id in the module config, then in providers/adobe.ts get the info of this kit (weights, families) as metadata and add all the fonts provided by the kit's CSS if one of the requested fonts matches because Adobe Fonts doesn't provide an endpoint to get CSS for a single font.
Also, there is an older Adobe Fonts API on https://fonts.adobe.com/docs/api/kits. The newer one requires an API key to access it. Is it okay to use the older API endpoints?

That would be great! It looks like we can use the older API, they just encourage use of the new one.


r-click results grid->filter ->customize filters--ability to select multiple columns at once to move up/down instead of selecting one-by-one & clicking move-up/-down

Is your feature request related to a problem? Please describe.
it's time consuming to move columns one-by-one clicking move-up multiple times once for each col we'd like to move up to show these cols first in the results grid
Describe the solution you'd like
it saves time to enable multiple column selection to move fields up in the results grid ..shift-select-all-cols we'd like to move & just click move-up/move-down once
Describe alternatives you've considered
selecting in SQL is considered but for tables with 100s of cols it's timeconsuming
Additional context
Add any other context or screenshots about the feature request here.

@iDeepMind  Thank for the suggestion, we will implement it.

Verified


Timing code in the library

I noticed there is code to time the navmesh building process inside some library calls. I was thinking this would not be desirable, if the navmesh is being built dynamically during a game.

Pretty sure this isn't a real issue!


Parallelize network requests in uv tree --outdated

Summary
Closes https://github.com/astral-sh/uv/issues/9266.

Separately, I'll probably add a progress bar for this.

While I was here, I also modified uv tree --outdated such that we no longer drop network errors.


Make intropsection cycle-safe

wraps type introspection utilities _fetchAllTypesFromObject and _fetchAllTypesFromType in a simple CollectTypes so that they can avoid infinite loops due to cycles

Thanks! Merging #37, and then publishing.


needed alert box

needed alert box incase the details of user is missed or the details given or wrong

and also when i am trying to login to the website without giving any details its not giving any alert box and also a php file is getting downloaded when i try to login

i want to resolve this issue.


Support for .net 8

Hi there, any plans to add support for net 8?

Most definitely :) I'll try to push at least one pre-release with .NET 8 support before .NET 8 is GA.

@wondertalik Pre-release packages with .NET 8 support are available on NuGet now :)


Native Node.js addon

I was wondering if it was possible for you to integrate libcurl-impersonate into a native Node.js addon so it works in JS out-of-the-box, without the long and tedious process of building node-libcurl with the impersonate patch.
What I'm suggesting is a fork of node-libcurl because  I feel like that would take a lot less work than creating a new thing from scratch. While I do understand there are a couple of forks which do that, they are all unmaintained and largely out of date. This repository seems somewhat alive so I hope it won't be an issue keeping it alive. (An occasional pull from upstream should be all of the maintenance it needs.)
I'm not very familiar with the development ecosystem of c++ and such so I'm afraid I won't be of much help, but logically it shouldn't be that big of a deal, right? Surely we can just replace which curl it uses in it's deps. (I understand it may not be this simple, but I really need a reliable impersonate library in Node. Thanks in advance!)

While I do understand there are a couple of forks which do that, they are all unmaintained and largely out of date.

Yes, I acknowledged the other fork(s) but as I mentioned, it hasn't been updated for 2 years. Not sure how to feel about that but I'm definitely not using something like that.
The sole reason I proposed this was to get a regularly maintained lib that works and is up to date. If nobody is willing to do something like this, I'll probably go and bother the original author of the fork you linked above since it seems like the most promising thing.

Look at this one, it's quite new, updated 4 month ago. https://github.com/ycq0125/node-libcurl

I stumbled upon that package as well during my research, but it looked sketchy and unmaintained. I still decided to give it a try and got some build errors when installing it that I'm not willing to look into further since the only error I see is MSBuild.exe failed with exit code: 1 which is extremely frustrating.
I'll try to replace the libcurl package of node-libcurl or even go as far as forking the package and see where that gets me. Hoping for the best.

Tried that a couple days ago but it didn't work correctly if I remember correctly. I'll try some other things in the meantime. I hope you understand me making this issue was a last resort after nothing else worked.

Which platform are you on? Windows?

Windows 10. Specifically 10.0.19045.3693.

I guess it's a little more diffcult for you to use the environment variable trick. But here are a few general tips:

You can download the window dll, from this fork's release page.
Unlike on Linux, you don't need to patchelf or whatever.
Install node-libcurl, find which libcurl.dll it's using, replace it with the dll above.
Setup envionment variable the Windows way, depending on your shell or app.

I just do this :)
apt install build-essential pkg-config cmake ninja-build curl autoconf automake libtool golang-go unzip python-is-python3 2to3 libcurl4-openssl-dev build-essential
git clone https://github.com/yifeikong/curl-impersonate.git
cd curl-impersonate
mkdir build && cd build
../configure
make chrome-build
make chrome-install
ldconfig
rm /usr/local/lib/libcurl.so
ln -s /usr/local/lib/libcurl-impersonate-chrome.so.4.8.0 /usr/local/lib/libcurl.so
rm /usr/bin/curl-config
ln -s /usr/local/bin/curl-impersonate-chrome-config /usr/bin/curl-config
echo "/usr/local/lib/libcurl-impersonate-chrome.so" >> /etc/ld.so.preload
ldconfig
cd your-app
rm package-lock*
npm install node-libcurl --build-from-source --curl_libraries='-Wl,-rpath /usr/local/lib -lcurl'
pm2 kill
const { Curl, curly } = require("node-libcurl");
process.env.CURL_IMPERSONATE_HEADERS = "yes";
Curl.defaultUserAgent = null;
curly.defaultUserAgent = null;
const sessionCurl = curly.create();
thanks for keeping this lib up to date !

A lot easier way with pre-combiled binaries
Mind the architecture of your docker environment and latest lib version in the url
WORKDIR /tmp/curl-lib
RUN wget --no-check-certificate https://github.com/yifeikong/curl-impersonate/releases/download/v0.7.0/libcurl-impersonate-v0.7.0.x86_64-linux-gnu.tar.gz \
  && tar zxvf libcurl-impersonate-v0.7.0.x86_64-linux-gnu.tar.gz \
  && cp libcurl-impersonate-chrome.so* /usr/local/lib \
  && echo "/usr/local/lib/libcurl-impersonate-chrome.so" >> /etc/ld.so.preload \
  && ldconfig /etc/ld.so.conf.d

WORKDIR /app
COPY package.json package-lock.json test.js ./
RUN npm rm --save node-libcurl
RUN npm install --save node-libcurl --no-cache --force --build-from-source --curl_libraries='-Wl,-rpath /usr/local/lib -lcurl-impersonate-chrome'

const { Curl,curly } = require('node-libcurl');

process.env.CURL_IMPERSONATE_HEADERS = 1
Curl.defaultUserAgent = null;
curly.defaultUserAgent = null;

process.env.CURL_IMPERSONATE = 'chrome124';

console.log(Curl.getVersion());

( async () => {
	const r= await curly.get('http://httpbin.io/headers');
	console.log(r.data);
})()

fixed


Provide custom alias

Add a feature to provide custom alias of user choice.

I want to work on this issue

Sure go ahead @BalgopalPatro. Also, do give an update about your progress.

@arjungarg07  can you elaborate on this. Is this about giving custom naming of website to the person ?

Hey @harshil15999 , No it's not about giving a custom domain but a custom code of the user's choice.

@arjungarg07 please assign this to me too

I think @BalgopalPatro is working on it. You can confirm with him on our slack channel.

@BalgopalPatro working on it?

@arjungarg07  please re assingn

@arjungarg07  in the frontend after each keypress should checking be done or after submit is pressed ?

@harshil15999, after submit, is pressed.


Note to Clarity Connection Differences

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/2157

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Yea, sorry about that, that line got removed by mistake.  Should be all good now


fix: SpanDetail text overlap

before:

after:

This was discussed here, https://github.com/apache/skywalking/discussions/9255


Add storage.Internal error, which the API propagates as a 500.

Fixes #2571 - see there for discussion.

@juliusv WDYT?

See my latest comment on https://github.com/prometheus/prometheus/issues/2571 - sorry about my confusion earlier.

Updated for https://github.com/prometheus/prometheus/issues/2571#issuecomment-291868311 to put the error in the promql package.  @juliusv PTAL

:+1: awesome

Thanks!
On Thu, Apr 6, 2017 at 3:36 PM Julius Volz<EMAIL_ADDRESS>wrote:

Merged #2572 https://github.com/prometheus/prometheus/pull/2572.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/pull/2572#event-1032337485, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAbGhY94cHe381nhjito9HAEIALjomGuks5rtPhpgaJpZM4MzAVM
.

Actually I totally missed that this error isn't being set in the engine when storage accesses fail. I believe the engine itself should wrap it around errors coming from the storage layer?


fix: add npm dependency type check

See https://github.com/restfulhead/npm-auto-plugins/pull/29 instead


Keyboard and mouse are not working with Vision image

Hi @dmitriykovalev
I assembled the vision kit as per the directions given in the website. After that, I flashed the provided image onto a SD card and hooked the kit to a monitor. I also, inserted my keyboard and mouse dongle to the microUSB port on the Pi through a microUSB to female USB OTG cable. With all of this, I'm not able to use my keyboard and mouse after the system boots up.
I looked up online and added modules_load = g_hid in the cmdline.txt under the boot folder. But this didn't fix the problem.
Is there any extra setting that we need to add to make the keyboard/mouse work?
Thanks,
Venky

@kodukulav
SD card image should work fine with USB keyboard and mouse, you don't need to modify cmdline.txt for that. Try to download the latest image (there was an update recently) and make sure you use good power supply (e.g. wall power adapter) and good USB hub (try to plug in keyboard and mouse separately without a hub to troubleshoot).

Please reopen if you still have this problem.


Better support for multiple factories

Idea
After a long sequence of evolution, we now support Factory as a separate thing on the gfx-rs level, and it's being generated together with the device in gfx_device_gl::create(). There is only one factory and no ability to create more for GL.
This somewhat makes logical sense. However, the implementation of the gfx_device_gl::Factory requires sharing the GL context with the device, and everything that factory needs can be taken from the device. Thus, there is no actual barrier to have multiple factories. Since they use Rc for referencing the context, they can't be moved to another thread, and neither can the device be.
Thus we can easily have multiple factories. We can have create_factory() method inside the gfx::Device.
Problems

On different APIs we may need different parameters to initialize a new resource factory. Consider the pool size that the factory allocates from.
Unclear how to guarantee resource destruction. If a factory is created for a short session and then dies, these resources are never going to be de-allocated. We need the life times of the resources to be bound to the factory lifetime, optimally.

Benefits
TODO
Perhaps, it's not a good idea after all....

Here is why this is needed. gfx_graphics could spawn its own factory from the device, thus not requiring any update() calls and generating glyphs on the fly. Also, the problems are not difficult to tackle:

We can make this a part of GL Device only for now
We can force the device to hold references to all the factories. Although, that requires sharing factories, which sucks... Alternatively, there could be a pool of "abandoned resources" that all the factories keep (a mutable) track of. When a factory dies, it transfers all the known handles into the pool. The device can scan this pool on cleanup.

cc @eddyb @bvssvni @csherratt

That would be nice!

Extending this idea even further, maybe factories don't even need to hold their resources. We can have a single pool, owned by the device, and the factories push to it when they create resources. Then, the cleanup only needs the device. I believe this is the cleanest solution, improving even what we have now, and freeing the way to support multiple factories with no effort.

This sounds like a good idea. It does not matter which object that owns the last reference as long as it is accessible with cleanup.

I bet gfx-debug-draw will hugely benefit from this change too. cc @stjahns

Fixed in #743


Add support for CentOS.

This is CentOS 7 (in AWS, the hardened image https://aws.amazon.com/marketplace/pp/B07MJ75S6C) which uses the old (and reliable!) Init system.

I started to make some style changes to this, but realized that most of it isn't needed -- the platform_family values already correctly account for centos under the family of rhel.
It sounds like the issue is this AMI using SysVinit, which the Chef service resource isn't detecting correctly? Ideally I'd rather see that get fixed in an upstream PR to the chef-infra client, but I'd take a PR to conditionally fix it on Frontline AMIs (i.e. making provider a case statement that was specific to CentOS w/ SysVinit)


Image is attempted to be loaded infinitely when no fallback is defined

E.g.
{{vcl-img src=model.mainImage alt="No image"}}

Solved


./test.sh: 8: ./test.sh: th: not found

Question about ENet-TuSimple-Torch
May I ask why I get error"sh ./laneExp/ENet-model/test.sh
./laneExp/ENet-model/test.sh: 8: ./laneExp/ENet-model/test.sh: th: not found "
When I run the code cd $ENet_TuSimple_ROOT sh ./laneExp/ENet-model/test.sh .
I do have that directory"./laneExp/ENet-model/test.sh"

It seems that either Torch is not properly installed or the path to your Torch has not been added to the .bashrc.


Allow fileExt to be optional

Moved from https://github.com/storybooks/storybook-addon-jest/issues/4

Right now if you don't provide one this will append undefined to the end of the regex:
https://github.com/storybooks/storybook/blob/087647673aedfe925496698a4e9c3a6106b967f4/addons/jest/src/index.js#L9

Looks like it's just a matter of using empty string as a default value. If anybody wants to make a PR, go for it

If anyone new to storybook or open source in general wants to take this issue, I'm available to help!

@ndelangen just dabbling into open source. Would make a PR

@Promhize
You'll have to

Fork the repo
Clone the forked repository to your computer
Create a branch named feature/default-
Edit the following file: addons/jest/src/index.js
The change to apply: change line 3 from:const findTestResults = (testFiles, jestTestResults, jestTestFilesExt) =>

to:const findTestResults = (testFiles, jestTestResults, jestTestFilesExt = '') =>

Commit the changed file and push to the remote
Go to our github page here: https://github.com/storybooks/storybook
GitHub should suggest to open a PR, if it doesn't you should be able to select your branch and our master branch here to create one: https://github.com/storybooks/storybook/compare (our master branch should be the base.
Describe the change you made in the title and description.
Wait for someone to review the PR.
It should be merged pretty quick!

@ndelangen thanks. Looking to make further contributions.  Check README here: https://github.com/storybooks/storybook/tree/master/addons/jest#withtestsoptions

Done, but not released yet

Actually it was release in 3.2.16 but not well documented:
https://unpkg.com/<EMAIL_ADDRESS>Commit: https://github.com/storybooks/storybook/commit/d185d1abd7e15e0c435bdb740d0ac44e784d58c4#diff-c1ceced995a7529ca1ae8fcb2a0f4aafR26

Oh. Should we revert https://github.com/storybooks/storybook/pull/2373 then?

Yes, please. Sorry for the lack of documentation regarding it.

@Promhize drop by our slack channel.
That way we can collaborate much easier and faster, if you want to do more collaboration I can help get you on-boarded on the project.


Candidate for Asynchronous NSGA2

Implements an asynchronous variant of NSGA2, using the ENLU insertion operator as in https://ieeexplore.ieee.org/document/7738460. This is opening a candidate, several things may require changes before merging.
This is implemented as a wrapper around the already extant steady_state, with an extra population representation and custom inserter used internally. The ranking function is exposed and available for testing, and if used for traditional generational ranking performs as good or better than fast_nondominated but not as good as rank_ordinal.
There are some changes to other files of note:
The singe-layer crowding distance function was broken out from within the overall operator. This is because it is cheaper to use directly in the insertion function.
I commented out the assertions in worse_than for MultiObjectiveProblem. While it is good for checking for regressions, the function is used too frequently to have them ran every time.

There are faster versions of the insertion function in literature that may be worth looking at in the future. For the current use cases I am aware of (preventing holds during evolution) this is probably plenty fast enough.

This has been merged in with the zero-scale objectives. A new PR will be opened for future changes.


message feed: Redesign empty feed notice.

Part of #24345 (redesigning the search bar)
Figma for the empty search screen: https://www.figma.com/file/jbNOiBWvbtLuHaiTj4CW0G/Zulip-Web-App?type=design&node-id=1700-137541&mode=design&t=UhuV7tXTigUjuQQA-0
This changes the design of the screen that shows
when there are no search results, as well as the
banner that shows when the user reaches the end
of search results if there are possiby more
results in a public stream search or results
in messages not searchable because the organization
has limited history.

also visible for when there are some search results:

@evykassirer can you explain what specific design changes this is supposed to be making? A few things that would help a lot when requesting review for a design change:

Before/after comparison screenshots; see https://github.com/zulip/zulip/pull/25997 for a good example of this.
The prose description explaining what changes we're trying to do. I would generally prefer some copy-pasting with a link of which part of a giant omnibus giant issue is implemented in a given PR; as it is, it feels impossible for me to discern where the changes made here were proposed to investigate the questions I posted above as to whether these specific details are even intentional or just the result of Vlad not having been briefed on every error possible error condition that could be displayed.

This is part of https://github.com/zulip/zulip/pull/24345 (redesigning the search bar) as I mentioned above, and is part of the designs Vlad requested. I don't know much about it other than that and the conversation I had with Vlad -- I can link the conversation and mention your concerns there.

Here's the link to the conversation, and I also added it in the PR description above:
https://chat.zulip.org/#narrow/stream/101-design/topic/search.20empty.20results

Closing based off of discussion on CZO: https://chat.zulip.org/#narrow/stream/101-design/topic/search.20empty.20results/near/1603563


chore: import repository https://github.com/briferz-x/python-http.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create SECURITY.md

kontrolle ist besser

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


count() in LRUQueryCache

Description
Currently, the implementation of Weight.count() in LRUQueryCache first considers whether the wrapped Weight can obtain the count, and then considers the cache.
However, for certain queries, such as IndexSortSortedNumericDocValuesRangeQuery and PointRangeQuery, obtaining the count from CacheAndCount should be faster. Should we adjust the logical order?

I'm good with flipping the order of the checks.

@LuXugang @jpountz I opened a PR #13742 for this.


Additional Unit Tests

Additional testing for seasonal averages for multiple data types and distributions.

Coverage increased (+1.08%) to 82.215% when pulling 9c92544352cf9c7617de0cd649a1fbbf2654c9c4 on testing into 5fc3c06b5a9376349ab53b0c1361f3f72e95ead0 on develop.

Coverage increased (+1.08%) to 82.215% when pulling 9c92544352cf9c7617de0cd649a1fbbf2654c9c4 on testing into 5fc3c06b5a9376349ab53b0c1361f3f72e95ead0 on develop.


10 how does fractal submit slurm jobs from the correct user

@jluethi @tcompa @mfranzon
The promised update on how this PR is proceeding. Unfortunately we encountered a new road block which is quite difficult to bypass, having to do with the intricacies of how jobs are handled by Parsl.
Will keep going at it for the remaining of today and tomorrow.

Ok, thanks for the update @jacopo-exact
One high level question: With the new architecture, can we still run the server on the cluster head node and submit to it via a bash script that defines a user with username & password? Because that is a) very convenient for testing and b) may also be how we'd run demos to keep it simple for the time being.
Also, another high-level feedback from @gusqgm : FMI IT seems less concerned with having a sudo user that submits on the cluster head node than having ssh keys. I'm sure we'll find a way to get a setup with ssh keys if that is the best way. But if it gets much harder to do things with ssh tunneling, let's reconsider just using a sudo user.

One high level question: With the new architecture, can we still run the server on the cluster head node and submit to it via a bash script that defines a user with username & password? Because that is a) very convenient for testing and b) may also be how we'd run demos to keep it simple for the time being.

username and passwords is the current way the user authenticates with the fractal-server, and this won't change for the time being. The ssh transport is the way that fractal-server communicates with the slurm daemon.

Also, another high-level feedback from @gusqgm : FMI IT seems less concerned with having a sudo user that submits on the cluster head node than having ssh keys. I'm sure we'll find a way to get a setup with ssh keys if that is the best way. But if it gets much harder to do things with ssh tunneling, let's reconsider just using a sudo user.

The sudo way has its long list of technical difficulties that are solved by the ssh transport. There should be no ssh tunneling involved in the communication between fractal-client and fractal-server. If this is the issue you're facing, we'll set up a machine exclusively dedicated to serving the fractal-server on a standard port (80 or 443).

Sounds reasonable to me, thanks for the context @jacopo-exact !
Also, if we use username & password or some oauth2 credentials later, there shouldn't be ssh tunneling between server & client, I agree. So no need to set up an additional machine for that for the moment :)

Closed in favor of #112


Align find projects by workspace

add optional query params for FindAllProjectsOnWorkspaceAsync

solves: #11

Looks good to me. Good job 👍


ValueError with NucleoATAC

I try running NucleoATAC with a bed file flanking TSS's, and I get the following error:
Traceback (most recent call last):
File "/Users/Eric/anaconda/envs/nucleoatac/bin/nucleoatac", line 31, in
nucleoatac_main(args)
File "/Users/Eric/anaconda/envs/NucleoATAC/lib/python2.7/site-packages/nucleoatac/cli.py", line 56, in nucleoatac_main
run_occ(occ_args)
File "/Users/Eric/anaconda/envs/NucleoATAC/lib/python2.7/site-packages/nucleoatac/run_occ.py", line 86, in run_occ
chunks = ChunkList.read(args.bed, chromDict = chrs, min_offset = args.flank + args.upper/2 + max(pwm.up,pwm.down) + args.nuc_sep/2)
File "/Users/Eric/anaconda/envs/NucleoATAC/lib/python2.7/site-packages/pyatac/chunk.py", line 155, in read
end = int(in_line[2])
ValueError: invalid literal for int() with base 10: '3206415\rchr1'
I looked at the bedfile and that value is on the first line of the bedfile.  What's going on, what did I do?

Looks like the issue is with reading in the bed file for the peaks, in particular that the line endings are not as expected... '\r' instead of '\n'.  For reading in the file properly it expect '\n' line endings.

Simple fix, thanks!  Program is running.