Omni sensors for SDM12 are not reporting sensor values

Checklist

[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
Sensors for SDM12 (temperature, current, power) are not reporting values.
But, as soon as DC is connected, and the SDM12 is selected in the DC UI, the sensors start reporting.
Close DC, or change focus to a different object, and sensors stop reporting again.
I am not 100% sure, but sensors for SDM12 did work when introduced, so may have stopped working some point later.
I noticed this with SDM12's, but it may apply to other omni sensors as well.
I could not confirm if temperature is reported, as DC in v4.6 that I tested with did not show temperature, at least I could not find it in the UI, have not tested with DC 4.7 yet.
Reproduction steps

Run monitor_omni_sensors.py, or add SDM12 sensors to HA dashboard.
Observe that there are no values reported.
Launch DC, connected to controller, focus on a SDM12 module.
Observe that sensor values are now reported every few seconds.
But only for the selected module.
Change DC focus to a different module and observe values now reported for that module.
Close DC and sensor values stop being reported.

I did some more experimentation, this is what I found.
Using the OmniSensor example python monitor_omni_sensors.py <IP_ADDRESS> --debug --username=administrator --password=password:
DEBUG:aiovantage.command_client.events:Sending message: LOGIN administrator password
INFO:aiovantage.command_client.events:Connected to event stream at <IP_ADDRESS>:3010
DEBUG:aiovantage.command_client.events:Started the event stream
INFO:aiovantage.controllers:OmniSensorsController subscribed to state changes
INFO:aiovantage.controllers:OmniSensorsController initialized (36 objects)
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE STATUS ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG STATUS ON
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE STATUSEX ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG STATUSEX ON
DEBUG:aiovantage.command_client.events:Received message: R:LOGIN administrator @Vantage1
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 STATUS ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG STATUS ON
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 STATUSEX ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG STATUSEX ON

And the SDM12 sensor values are never updated.
Open Infusion Diagnostics Host Commands window, Click on Full, or just on Automation, and the sensor values start getting reported.

Test in telnet by repeating the steps, and see the same behavior.
Modify base.py and "AUTOMATION", "EVENT", "SYSTEM":
        # Some state changes are only available from "object" status events.
        # These can be subscribed to by using "STATUSADD {vid}" or "ELLOG STATUS".
        if self.interface_status_types:
            # Subscribe to "object status" events from the Enhanced Log.
            self.event_stream.subscribe_enhanced_log(
                self._handle_event, ("STATUS", "STATUSEX",
                                     "AUTOMATION", "EVENT", "SYSTEM")
            )

Rerun, and now sensor values are getting reported.
DEBUG:aiovantage.command_client.events:Sending message: LOGIN administrator password
INFO:aiovantage.command_client.events:Connected to event stream at <IP_ADDRESS>:3010
DEBUG:aiovantage.command_client.events:Started the event stream
INFO:aiovantage.controllers:OmniSensorsController subscribed to state changes
INFO:aiovantage.controllers:OmniSensorsController initialized (36 objects)
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE STATUS ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG STATUS ON
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE STATUSEX ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG STATUSEX ON
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE AUTOMATION ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG AUTOMATION ON
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE EVENT ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG EVENT ON
DEBUG:aiovantage.command_client.events:Sending message: ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Sending message: ELENABLE SYSTEM ON
DEBUG:aiovantage.command_client.events:Sending message: ELLOG SYSTEM ON
DEBUG:aiovantage.command_client.events:Received message: R:LOGIN administrator password
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 STATUS ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG STATUS ON
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 STATUSEX ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG STATUSEX ON
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 AUTOMATION ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG AUTOMATION ON
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 EVENT ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG EVENT ON
DEBUG:aiovantage.command_client.events:Received message: R:ELAGG 1 ON
DEBUG:aiovantage.command_client.events:Received message: R:ELENABLE 1 SYSTEM ON
DEBUG:aiovantage.command_client.events:Received message: R:ELLOG SYSTEM ON
DEBUG:aiovantage.command_client.events:Received message: EL: 473 475 0 1 0
DEBUG:aiovantage.command_client.events:Received message: EL: 475 107 Load.GetLevel 0 0
DEBUG:aiovantage.command_client.events:Received message: EL: 473 Button.GetState 0
DEBUG:aiovantage.command_client.events:Received message: EL: 475 Task.IsRunning 1
DEBUG:aiovantage.command_client.events:Received message: EL: 475 117 Load.GetLevel 0 0
DEBUG:aiovantage.command_client.events:Received message: EL: 475 112 Load.GetLevel 0 0
DEBUG:aiovantage.command_client.events:Received message: EL: 2 Controller Query 475 Complete: 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 24 Temperature.GetValue 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 25 PowerSensor.GetPower 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 26 PowerSensor.GetPower 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 27 PowerSensor.GetPower 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 28 PowerSensor.GetPower 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 29 CurrentSensor.GetCurrent 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 30 CurrentSensor.GetCurrent 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 31 CurrentSensor.GetCurrent 0 0
DEBUG:aiovantage.command_client.events:Received message: EL:<PHONE_NUMBER> 32 CurrentSensor.GetCurrent 0 0

By the design of the code it looks like OmniSensor may need to add AUTOMATION to subscribe to events, but I am not certain enough to do a PR yet.
From the screenshot you can see how data started working after running the example app:

With the change to add AUTOMATION, and running the omni test app, and HA, I now see periodic EL's for sensors, but the reported values never change. E.g. in my case all but two are 0, and the two non-zero values never change.
I "AUTOMATION", "EVENT", "SYSTEM", ran the test app, logged to file, connected DC, selected the SDM module, and observed that DC seems to be polling HW values, as expected the values reported by HA reflected the polled values. I selected a SDM, power cycled some loads, observed values changing as expected. Disconnected DC, and previous values kept being reported, even after powering off loads.
I am not sure if the log captures all commands sent from other clients, else some MITM network traffic snooping between DC and the controller may be required?
Log attached.
omni.log

Fixed in 0.15.0

Or 0.16 where the cache=false was added?

0.16! good catch


do not translate values of facet reviewer_tags

What it fixes: in a previous commit I added localization prefixes reviewer_tags when configuring the facet reviewer_tags. So if you have tags like mytag they now appear as reviewer_tags.mytag. This bug only appears in the route /dataset.

Looks good to me!


change the line endings of the horizontal line drawn below the selected tab.

Description
Change the line endings of the horizontal line drawn below the selected tab
Related Issues
The line endings of the horizontal line drawn below the selected tab are  StrokeCap.square.

I want to change the line endings of the horizontal line drawn below the selected tab as define of StrokeCap values
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change.

@googlebot I signed it!

Hi @ttpho, thanks for the contribution. This change has not been updated in a while, and it is lacking a test, so I am going to close this for now. If you would like to continue working on this, feel free to re-open. Thanks!


New drivers for Vue3 and Angular5+

Reason
The drivers to register components on frameworks were not working for Angular5+ (starting on version 5.0.0) and Vue3 (starting on version 3.0.0).
Solution

Adapt the current angular2 driver to work with all versions from 2.0.0 to  the newest 12.2.1
Create a new driver for vue3. Vue3 has breaking changes in which the components are registered on the vueApp instance while on Vue2 it was possible to register it directly on the Vue object as a static method.
It was also necessary to rewrite the way karma load the Vue scripts. Because both Vue2 and Vue3 sets the same object name Vue on the window object, we can't preload both libs on karma.conf.js. As a solution we setup a loadScript helper to dynamically load each Vue version, when it is necessary.

@andregardi Should we have any new tests for Angular 4+?

@andregardi Should we have any new tests for Angular 4+?

I am working on that.
The current tests uses Angular 4 lib, even if the driver is called an angular2.
I am trying to add a dynamic scripting load, to have a dedicated tests that uses Angular 12 lib, similar of what we have to Vue2 vs Vue3. The value of this tests is to show that the same driver even with the new versions of Angular.
At the moment things a breaking and I am still looking for the reason/solution. But I think we will get that to work soon.

@mnicpt
I added a test that dynamically loads Angular 12 and use it to test the angular2 driver.
At same time I kept the old tests as it was. It help us to guarantee that the new driver keeps compatible with the old Angular versions, while it also works with the newest Angular 12.


num_steps_per_image>1  test_integration_autorunner

          > there's still an error after the above ones being fixed

======================================================================
ERROR: test_autorunner_ensemble (__main__.TestAutoRunner)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/Documents/MONAI/tests/test_integration_autorunner.py", line 132, in test_autorunner_ensemble
    runner.run()
  File "/home/Documents/MONAI/monai/apps/auto3dseg/auto_runner.py", line 803, in run
    self._train_algo_in_sequence(history)
  File "/home/Documents/MONAI/monai/apps/auto3dseg/auto_runner.py", line 659, in _train_algo_in_sequence
    acc = algo.get_score()
  File "/home/Documents/MONAI/monai/apps/auto3dseg/bundle_gen.py", line 264, in get_score
    dict_file = ConfigParser.load_config_file(os.path.join(ckpt_path, "progress.yaml"))
  File "/home/Documents/MONAI/monai/bundle/config_parser.py", line 402, in load_config_file
    with open(_filepath) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmpd2llrjiy/work_dir/segresnet_0/model/progress.yaml'

this is still an issue when num_steps_per_image>1, @myron prgoress.yaml was not saved properly. but we are merging this and overriding it to num_steps_per_image=1 in the test cases because we want to run full integration tests to unblock the release.
Originally posted by @wyli in https://github.com/Project-MONAI/research-contributions/issues/224#issuecomment-1513181919

this PR should fix it https://github.com/Project-MONAI/research-contributions/pull/237


Kotlin sample: export tiles

hey @TADraeseke, another kotlin sample for you to take a look at when you can! The biggest changes I made from the Java Android sample, is that rather than the preview window showing a larger mapview area than the one exported, the preview window now shows exactly the map exported as defined by the preview window (it follows the Java SDK workflow in that way). I think this is a little clearer to the user, but please let me know what you think.
Also have the new progress indicator layout: some issues I have with it are I haven't figured out how to chance its indicator from orange to blue (to keep with our colour scheme) and that you can click away from it and the progress disappears (but the job still completes). Not sure if we need to add in an indicator somewhere there is still a download happening in the background.
One final thing, I'm getting a crash when rotating the device: I haven't figured out why, but it's to do with the geometry of the download area returning null (see code block for where crash occurs). I'm not sure why this should be when rotating the device (if it's just reloading the app, I don't see this crash on start up).

Thanks @TADraeseke ! Could you take another look please? Still having problems understanding why I'm getting a crash when rotating to landscape. When you have a moment could you take a look please and see if anything obvious jumps out at you as to why and let me know please? Thanks!

@sorenoid please could you do a second review for this sample? @TADraeseke and I are still working on a way to make the progress bar colours match the rest of the app: other than that work in progress (no code in here yet for that) everything else is ready for the second review. Thank you!

@TADraeseke I've implemented those changes we discussed: this should now be working on all devices! could you take another look through please? Really like your addition to the progress bar, thanks for that!

@TADraeseke thanks very much for that! Changes made: could you take a final look before I merge please?


model is retrained everytime due to dynamic checkpoint names

Rasa version:
Rasa 1.3.8
Commit 39300da9a5de7a3c7fd285519f9577466bfda8d5
Python version:
3.6.9
Operating system (windows, osx, ...):
osx
Issue:
I trained my model, and running rasa shell everything works fine. But once I start rasa interactive, it starts training a model, even though I didn’t change anything. After Your Rasa model is trained and saved at ... and Type a message and press enter (press 'Ctr-c' to exit)., it continues with processing story blocks, which takes longer than training the model. (I aborted at this point.)
If I want do rasa train and rasa shell after that, the action server seems not accessible.
Error (including full traceback):
First, no error message, just unexpected behaviour. Here is a screenshot:

Then, If I want do rasa train and rasa shell after that, I get this message:
rasa shell --debug                                                                                [16:59:55]
2019-10-15 17:00:53 DEBUG    rasa.model  - Extracted model to '/var/folders/yg/vcndsyk94tl492272h0x_wlm0000gp/T/tmpn8j0x0jm'.
2019-10-15 17:00:53 DEBUG    rasa.cli.utils  - Parameter 'endpoints' not set. Using default location 'endpoints.yml' instead.
2019-10-15 17:00:53 DEBUG    rasa.cli.utils  - Parameter 'credentials' not set. Using default location 'credentials.yml' instead.
2019-10-15 17:00:53 DEBUG    rasa.model  - Extracted model to '/var/folders/yg/vcndsyk94tl492272h0x_wlm0000gp/T/tmp2lsre1di'.
2019-10-15 17:00:54 INFO     root  - Connecting to channel 'cmdline' which was specified by the '--connector' argument. Any other channels will be ignored. To connect to all given channels, omit the '--connector' argument.
2019-10-15 17:00:54 DEBUG    sanic.root  - CORS: Configuring CORS with resources: {'/*': {'origins': [''], 'methods': 'DELETE, GET, HEAD, OPTIONS, PATCH, POST, PUT', 'allow_headers': ['.*'], 'expose_headers': None, 'supports_credentials': True, 'max_age': None, 'send_wildcard': False, 'automatic_options': True, 'vary_header': True, 'resources': {'/*': {'origins': ''}}, 'intercept_exceptions': True, 'always_send': True}}
2019-10-15 17:00:54 DEBUG    rasa.core.utils  - Available web server routes:
/webhooks/rest                                     GET                            custom_webhook_CmdlineInput.health
/webhooks/rest/webhook                             POST                           custom_webhook_CmdlineInput.receive
/                                                  GET                            hello
2019-10-15 17:00:54 INFO     root  - Starting Rasa server on http://localhost:5005
2019-10-15 17:00:54 DEBUG    rasa.core.utils  - Using the default number of Sanic workers (1).
2019-10-15 17:00:54 INFO     root  - Enabling coroutine debugging. Loop id<PHONE_NUMBER>.
2019-10-15 17:00:54 DEBUG    rasa.model  - Extracted model to '/var/folders/yg/vcndsyk94tl492272h0x_wlm0000gp/T/tmp6h47_0xh'.
2019-10-15 17:00:58 DEBUG    rasa.core.tracker_store  - Connected to InMemoryTrackerStore.
2019-10-15 17:00:58 DEBUG    rasa.core.lock_store  - Connected to lock store 'InMemoryLockStore'.
2019-10-15 17:00:58 DEBUG    rasa.model  - Extracted model to '/var/folders/yg/vcndsyk94tl492272h0x_wlm0000gp/T/tmp72_fr08t'.
2019-10-15 17:00:58 DEBUG    pykwalify.compat  - Using yaml library: /Users/johannes/miniconda3/envs/rasa/lib/python3.6/site-packages/ruamel/yaml/__init__.py
Bot loaded. Type a message and press enter (use '/stop' to exit):
Your input ->  hi
Unable to start server
Traceback (most recent call last):
  File "/Users/johannes/miniconda3/envs/rasa/lib/python3.6/site-packages/sanic/server.py", line 778, in serve
    http_server = loop.run_until_complete(server_coroutine)
  File "uvloop/loop.pyx", line 1417, in uvloop.loop.Loop.run_until_complete
  File "uvloop/loop.pyx", line 1686, in create_server
OSError: [Errno 48] error while attempting to bind on address ('<IP_ADDRESS>', 5005): address already in use

Restarting my machine fixes this issue until I run rasa interactive again.
Command or request that led to error:
rasa train
rasa shell
rasa interactive  <-- problem here --/>

Content of configuration file (config.yml) (if relevant):
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: en
pipeline:
- name: "DucklingHTTPExtractor"
  # url of the running duckling server
  url: "http://localhost:8000"
  # dimensions to extract
  dimensions: ["duration", "number"]
  # allows you to configure the locale, by default the language is
  # used
  locale: "en_EN"
  # if not set the default timezone of Duckling is going to be used
  # needed to calculate dates from relative expressions like "tomorrow"
  timezone: "Europe/Berlin"
- name: "WhitespaceTokenizer"
- name: "RegexFeaturizer"
- name: "CRFEntityExtractor"
- name: "EntitySynonymMapper"
- name: "CountVectorsFeaturizer"
  analyzer: "char_wb"
  min_ngram: 1
  max_ngram: 4
- name: "EmbeddingIntentClassifier"

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
  - name: MemoizationPolicy
  - name: EmbeddingPolicy
    max_history: 5  # default: 5
    batch_strategy: "balanced" # alternative: "sequence"
    epochs: 30 # default: 1
    random_seed: 2019  # default: null
    evaluate_on_num_examples: 0 # default: 100
  - name: MappingPolicy
  - name: FormPolicy

Content of domain file (domain.yml) (if relevant):
%YAML 1.1
---
actions:
- rating_inform
- travel_inform
- utter_acknowledge_problem_badlink
- utter_ask_eval_binary_natural
- utter_ask_eval_binary_helpful
- utter_ask_eval_binary_recommend
- utter_ask_bot_eval
- utter_ask_bot_rating
- utter_ask_helpdevelopers
- utter_ask_passengercount
- utter_ask_rephrase
- utter_ask_reqmore
- utter_ask_addtravel
- utter_ask_should_have_done
- utter_ask_should_restart
- utter_ask_travel
- utter_ask_travelmode
- utter_ask_traveltime
- utter_ask_whattodo
- utter_ask_why_here
- utter_explain_why_offset_travel
- utter_general_about
- utter_general_affirm
- utter_general_deny
- utter_general_emotional_happy
- utter_general_emotional_resigned
- utter_general_emotional_surprised
- utter_general_emotional_wow
- utter_general_goodbye
- utter_general_greet
- utter_general_oos
- utter_general_oos_future
- utter_general_thankyou
- utter_general_yourewelcome
- utter_meta_acknowledge_privacy
- utter_meta_iamabot
- utter_meta_list_features
- utter_meta_privacy
- utter_sorry
entities:
- duration
- number
- travelmode
forms:
- rating_form
- travel_form
intents:
- general_convey_affirmation
- travel_convey_affirmation
- general_convey_denial
- general_convey_express_uncertainty
- general_convey_farewell
- general_convey_greeting
- general_convey_thankyou
- general_express_emotion_happy
- general_express_emotion_unhappy
- general_express_emotion_surprised
- general_inform_affirmation_all
- general_inform_alreadydoing
- general_inform_problem_badlink:
    triggers: utter_acknowledge_problem_badlink
- general_inform_problem_badreply
- general_inquire_clarification
- meta_inquire_capabilities:
    triggers: utter_meta_list_features
- meta_inquire_botchallenge:
    triggers: utter_meta_iamabot
- oos_inform:
    triggers: utter_general_oos
- oos_inquire:
    triggers: utter_general_oos
- oos-future_inform:
    triggers: utter_general_oos_future
- oos-future_inquire:
    triggers: utter_general_oos_future
- travel_inform
- travel_inform_distance
- travel_inform_duration
- travel_inquire_clarification
- travel_inquire_howto_offset:
    triggers: travel_form
- general_placeholder
slots:
  eval_binary_helpful:
    type: unfeaturized
  eval_binary_natural:
    type: unfeaturized
  eval_binary_recommend:
    type: unfeaturized
  passengercount:
    type: unfeaturized
  requested_slot:
    type: unfeaturized
  travelmode:
    type: unfeaturized
  traveltime:
    type: unfeaturized
  traveldistance:
    type: unfeaturized
templates:
  utter_acknowledge_problem_badlink:
  - text: Oh no! I am sorry the link doesn't work anymore. I'll let my developers
      know.
  utter_ask_bot_eval:
  - text: Anything you'd like my developers to know?
  utter_ask_bot_rating:
  - buttons:
    - payload: you are dreadful
      title: dreadful
    - payload: you are mediocre
      title: mediocre
    - payload: you are good
      title: good
    - payload: you must be a human!
      title: human-like
    text: How do you think my performance will be rated?
  utter_ask_eval_binary_helpful:
  - text: Was our conversation helpful to you / did you learn something by chatting
      with me?
  utter_ask_eval_binary_natural:
  - text: Would you say our conversation was natural / intuitive?
  utter_ask_eval_binary_recommend:
  - text: Would you ask others to chat with me?
  utter_ask_helpdevelopers:
  - text: Could you help me with something, too?
  utter_ask_passengercount:
  - text: How many people were in the car?
  utter_ask_rephrase:
  - text: Not sure if I got that right. Could you please rephrase this?
  utter_ask_reqmore:
  - text: What would you like to do now?
  - text: Can I help you with anything else?
  utter_ask_addtravel:
  - text: Would you like to add another travel mode?
  utter_ask_should_have_done:
  - text: Oh no. I am utterly confused now. What should I have said?
  utter_ask_should_restart:
  - text: Thanks. I will send this to my developers so they can improve me. For now,
      I suggest I wipe my memory and restart our conversation. I won't remember anything
      you've said. Is that ok?
  utter_ask_travel:
  - text: Did you travel recently, or are you planning to travel?
  utter_ask_travelmode:
  - buttons:
    - payload: By car
      title: car
    - payload: By plane
      title: airplane
    - payload: By train
      title: train
    text: By what means did you travel?
  utter_ask_traveltime:
  - text: And how long did you / will you travel with the {travelmode}?
  utter_ask_whattodo:
  - text: What would you like to do?
  utter_ask_why_here:
  - text: I see.  If you cannot avoid these emissions,
      you can buy 'offsets', i.e. donations to projects that reduce greenhouse gases,
      e.g. by planting trees.
  utter_general_about:
  - text: I was built to help you reduce or offset your greenhouse gas emissions.
  utter_general_affirm:
  - text: 'Yes'
  utter_general_deny:
  - text: 'No'
  utter_general_emotional_happy:
  - text: :-)
  utter_general_emotional_resigned:
  - text: Too bad :-/
  utter_general_emotional_surprised:
  - text: Seriously?!
  utter_general_emotional_wow:
  - text: Wow!
  utter_general_goodbye:
  - text: Goodbye then!
  - text: Alright, bye!
  utter_general_greet:
  - text: Hello!
  - text: Hi
  utter_general_oos:
  - text: I am afraid I can't help you with that.
  - text: That's beyond the scope of my programming.
  utter_general_oos_future:
  - text: Good question! A future version of me might be able to answer this.
  utter_general_thankyou:
  - text: Thank you.
  - text: Thanks
  utter_general_yourewelcome:
  - text: You're welcome!
  - text: No problem.
  utter_meta_acknowledge_privacy:
  - text: Data collection is set to {allow_datacollection}.
  utter_meta_iamabot:
  - text: I am a bot, powered by Rasa.
  utter_meta_list_features:
  - text: At the moment, I can only help you offset CO2 emissions of your travels.
  utter_meta_privacy:
  - buttons:
    - payload: You can collect my data
      title: Yes, you can record and share my conversation.
    - payload: Please forget my data
      title: No, I'd like to keep this private.
    text: Can we record and publish the conversation you are about to have?
  utter_sorry:
  - text: Oh no, sorry!

you forgot to kill previous action server, so it cannot start the new one

The problem are the OR statements. They get different names:
## happy path
* greet
    - utter_greet
* mood_great
    - utter_happy

## sad path 1
* greet
    - utter_greet
* mood_great
> GENR_OR_9b3d9

## sad path 1
* greet
    - utter_greet
* mood_unhappy
> GENR_OR_9b3d9

## sad path 1
> GENR_OR_9b3d9 . <--
    - utter_cheer_up
    - utter_did_that_help
* affirm
    - utter_happy

## sad path 2
* greet
    - utter_greet
* mood_unhappy
    - utter_cheer_up
    - utter_did_that_help
* deny
    - utter_goodbye

## say goodbye
* goodbye
    - utter_goodbye

## bot challenge
* bot_challenge
    - utter_iamabot

ffcabb810d5df18f86f3fafee2a6206f

@JEM-Mosig I think I know what I might have missed, gimme a few and I'll test fixing this

@wochinge I don't see anything obvious yet with the change I made I'll look into this further but I didn't even think about testing the interactive piece with this before

so I feel pretty confident this is not related to my commit if someone wants to double check my work I only changed the info the /status route gives back so not sure how that broke this

I'm . tackling it 👍

@wochinge to be clear you tackled the comment https://github.com/RasaHQ/rasa/issues/4612#issuecomment-543770679
but not the overall issue of this thread right? cause i just had a customer run into it as well

it'll happen as well if they have cycles due to checkpoints

Yes, I only tackled the comment https://github.com/RasaHQ/rasa/issues/4612#issuecomment-543770679 .

@btotharye i just figured out what tobias meant - he fixed only the part in the comment here: https://github.com/RasaHQ/rasa/issues/4612#issuecomment-543770679
The original issue is still remaining, which you can work on (even if it's not necessarily to do with your original change)

@btotharye i just figured out what tobias meant - he fixed only the part in the comment here: #4612 (comment)
The original issue is still remaining, which you can work on (even if it's not necessarily to do with your original change)

ok makes sense now so the original issue that this was filed for is what actually needs to be looked at by me then, gotcha.

Looks like it happens to me with a basic setup without any OR or checkpoints it just processes super fast so I never noticed it before:
Nothing changed. You can use the old model stored at '/models/20191031-104526.tar.gz'.
2019-10-31 10:45:42 INFO     absl  - Entry Point [tensor2tensor.envs.tic_tac_toe_env:TicTacToeEnv] registered with id [T2TEnv-TicTacToeEnv-v0]
Bot loaded. Visualisation at http://localhost:5006/visualization.html.
Type a message and press enter (press 'Ctr-c' to exit).
Processed Story Blocks: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 4/4 [00:00<00:00, 1230.72it/s, # trackers=1]
? Your input ->

Looking into why this happens I've been able to reproduce this with the rasa-demo code as well and you can see the issue there since it has more data and takes a few with the story blocks before you can talk to it.
Should have updates shortly on it.  Thanks

@wochinge do checkpoints and ORs exist still in 2.0 stories? wondering if this may have been incidentally fixed

if they are not, they should be

they still exist sadly, we don't have a better solution yet

related other issue: https://github.com/RasaHQ/rasa/issues/7581


Inprove error reporting on Init

When there are problems with variables it stops but does not include the name of the variable that created the issue

@pollockm , @Beazurt , we should bump this, as it would solve one of the main support issues. If the variable is missing or the name is wrong it will not start the application but it doesn't specify which variable was failing. To figure that out users have to go to the init and figure which variable is missing.


idp metadata has wrong sso location

The metadata (as found on https://login.eduid.nl/saml/guest-idp/metadata) has
<md:SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="https://login.eduid.nl/saml/guest-idp/SSO/alias/guest-idp"/>
<md:SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="https://login.eduid.nl/saml/guest-idp/SSO/alias/guest-idp"/>

while it turns out that it only works when you leave out the last /alias/guest-idp of those URLs.

Seems to be buried deep in the SAML library we use: https://github.com/spring-projects/spring-security-saml/blob/develop/core/src/main/java/org/springframework/security/saml/provider/provisioning/AbstractHostbasedSamlProviderProvisioning.java#L97.
Also see https://www.pivotaltracker.com/story/show/175373291 - EOL of spring-security-saml

Nothing that Apache mod_sed can't solve 😄

Solved by using new SAML library: https://login.test2.eduid.nl/saml/guest-idp/metadata/


Update stop on failure README section

Hi,
This adds a reminder in the README to always run cghooks update after changing the config section.
Thanks

That's helpful


Export deployment operations

We have a template export API, along with PowerShell and CLI that seem to call it.
https://docs.microsoft.com/en-us/rest/api/resources/deployments/exporttemplate
https://docs.microsoft.com/en-us/powershell/module/az.resources/export-azresourcegroup?view=azps-2.3.2
https://docs.microsoft.com/en-us/cli/azure/group/deployment?view=azure-cli-latest#az-group-deployment-export
What RBAC operation allows this action? There are various resources/deployments/ operations but none that specifically say "export".
I'm looking here.
https://docs.microsoft.com/en-us/azure/role-based-access-control/resource-provider-operations#microsoftresources
Thanks!

Most likely it will be Microsoft.Resources/deployments/read but requires some further checking.

closing as not much activity here...

please reopen if you still need any more help

@zikalino ok, I guess you meant that the further checking has to be done by us. Thank you.


Restrict access to the site from countries listed by OFAC

We need to implement an OFAC filter and restrict access to apps that possess mechanisms for making transactions within our system.
For the implementation, just adding a wrapper component (maybe named OFACFilter) then implement the logic for OFAC filter in that component, if users' IP is acceptable, we will return the children, otherwise, we should also show a modal blurb w/ some Terms and Conditions that states the user confirms they are not from one of these countries nor is using a VPN to avoid sanctions from these countries.

From @thomivy:

https://www.opensanctions.org/api/
https://www.trade.gov/consolidated-screening-list


failed to download cbslocal video

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.06.19. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2018.06.19

Before submitting an issue make sure you have:

[ x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones
[ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'http://sanfrancisco.cbslocal.com/2016/06/17/source-oakland-cop-on-leave-for-having-girlfriend-help-with-police-reports/']
[debug] Encodings: locale cp1252, fs mbcs, out cp1252, pref cp1252
[debug] youtube-dl version 2018.06.19
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-81300-gce2217b
[debug] Proxy map: {}
[CBSLocal] source-oakland-cop-on-leave-for-having-girlfriend-help-with-police-reports: Downloading webpage
[CBSLocal] 3417601: Fetching server time
ERROR: An extractor error has occurred. (caused by KeyError('DVzl9QRzox3ZZsP9bNu5Li3X7obQOnqP',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\common.py", line 501, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\cbslocal.py", line 92, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\anvato.py", line 276, in _extract_anvato_videos
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\anvato.py", line 182, in _get_anvato_videos
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\anvato.py", line 172, in _get_video_json
KeyError: 'DVzl9QRzox3ZZsP9bNu5Li3X7obQOnqP'
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\common.py", line 501, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\cbslocal.py", line 92, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\anvato.py", line 276, in _extract_anvato_videos
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\anvato.py", line 182, in _get_anvato_videos
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\anvato.py", line 172, in _get_video_json
KeyError: 'DVzl9QRzox3ZZsP9bNu5Li3X7obQOnqP'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\YoutubeDL.py", line 792, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp3niajf93\build\youtube_dl\extractor\common.py", line 514, in extract
youtube_dl.utils.ExtractorError: An extractor error has occurred. (caused by KeyError('DVzl9QRzox3ZZsP9bNu5Li3X7obQOnqP',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

...
<end of log>

Description of your issue, suggested solution and other information
Tried to use youtube-dl for the first time, on http://sanfrancisco.cbslocal.com/2016/06/17/source-oakland-cop-on-leave-for-having-girlfriend-help-with-police-reports/, got the error above.
CBSLocal is listed as being supported.

For CBS Local (tested with newyork.cbslocal.com):
_ANVACK_TABLE = {
# ...
    'DVzl9QRzox3ZZsP9bNu5Li3X7obQOnqP': '3hwbSuqqT690uxjNYBktSQpa5ZrpYYR0Iofx7NcJHyA',
# ...
}


GPUImageMovieWriter cannot save audio/sound

A normal video taken from iPhone, after applied the filter, saved with GPUImageMovieWriter, but the result video has no audio/sound, even used the shouldPassthroughAudio and audioEncodingTargert as example did.
`self.gpuMovie = [[GPUImageMovie alloc] initWithURL:self.videoURL];
self.gpuFilter = [[GPUImageGrayscaleFilter alloc] init];
NSString *finalMoviePath = [NSTemporaryDirectory<EMAIL_ADDRESS>unlink([finalMoviePath UTF8String]);
NSURL *finalMovieURL = [NSURL fileURLWithPath:finalMoviePath];
self.gpuWriter = [[GPUImageMovieWriter alloc] initWithMovieURL:finalMovieURL size:CGSizeMake(224, 128)];
[self.gpuMovie addTarget:self.gpuFilter];
[self.gpuFilter addTarget:self.gpuWriter];

self.gpuWriter.shouldPassthroughAudio = YES;
self.gpuMovie.audioEncodingTarget = self.gpuWriter;

[self.gpuMovie enableSynchronizedEncodingUsingMovieWriter:self.gpuWriter];
[self.gpuWriter startRecording];
[self.gpuMovie startProcessing];

__weak typeof(self) wself = self;
[self.gpuWriter setCompletionBlock:^{
    NSLog(@"Finally, Done");
    [wself.gpuFilter removeAllTargets];
    [wself.gpuWriter finishRecording];
    `

I am using iOS 10. Any help will be appreciate.

 It seems another typical issue when you try to run the code inside iPhone simulator. Although I don't know why iPhone simulator will cause this problem, but when I finally decided to try on a real iPhone, it worked.
I cannot believe that I wasted whole day for this issue, I guess I totally forgot it because the video part (and other AVFoundation code I used) all worked smoothly even in simulator.


Empty lines are removed from text in text area tag

What version of Minify are you using?
2.0.1

PHP version?
5.2.5

What steps will reproduce the problem?
1. Minify HTML containing a TEXT AREA that has multiple empty lines.

What is the expected output?
The text inside the text area to be untouched by Minify. This text will
have a different meaning if Minified (just like the pre tag).

<textarea name="comment" id="comment" rows="6" class="maxwidth" cols="80">66666

1234567890</textarea>

What do you see instead?
Minify changes the contents of the text area tag and the empty lines are
incorrectly removed.

<textarea name="comment" id="comment" rows="6" class="maxwidth" cols="80">66666
1234567890</textarea>

Please provide any additional information below.
The TEXTAREA tag should be handled the same way as the PRE tag. You can
reuse the code in Minify/HTML.php, just make it handle PRE tags AND
TEXTAREA tags.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 31 Jul 2008 at 4:28

This should be fixed in R162. Can you verify this file works for you?

http://code.google.com/p/minify/source/browse/trunk/lib/Minify/HTML.php

Thanks for catching this!

Original comment by<EMAIL_ADDRESS>on 31 Jul 2008 at 3:20

Changed state: Fixed

This seems to be all fixed now.

Original comment by<EMAIL_ADDRESS>on 31 Jul 2008 at 8:45

Original comment by<EMAIL_ADDRESS>on 1 Aug 2008 at 2:49

Changed state: Verified


Git stopped working in WSL1 gnutls_handshake() failed: The TLS connection was non-properly terminated.

Windows Version
10.0.22631.3007
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[ ] WSL 2
[X] WSL 1

Kernel Version
Linux version 4.4.0-22621-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #2506-Microsoft Fri Jan 01 08:00:00 PST 2016
Distro Version
20.04
Other Software
Git from repository
Repro Steps
I'm trying to execute git fetch and I get the error gnutls_handshake() failed: The TLS connection was non-properly terminated.
This used to work fine until recent windows updates.
I've tried all common troubleshooting steps found in the related issues, none of which solve my issue.
Expected Behavior
Everything runs correctly
Actual Behavior
gnutls_handshake() failed: The TLS connection was non-properly terminated.
Diagnostic Logs
No response

/logs


wp-content/plugins folder is not generated

Hi. WP2Static generate all required assets except the folder "plugins".
This is the failed resource request:
scheme: https
filename: /wp-content/plugins/cookie-notice/css/front.min.css
status: 404 NotFound

This is my VM-test info:
### wp-core ###

version: 5.6
https_status: true
multisite: true
user_registration: false
blog_public: 1
default_comment_status: open
environment_type: production
user_count: 1
site_count: 2
network_count: 1
dotorg_communication: true

### wp-active-theme ###

name: Twenty Twenty (twentytwenty)

### wp-plugins-active (5) ###

Cookie Notice: version: 1.3.2
Disable WP Sitemaps: version: 1.2
WP2Static: version: 7.1.6

### wp-server ###

httpd_software: Apache
php_version: 7.4 64bit
php_sapi: apache2handler
max_input_variables: 1000
time_limit: 0
memory_limit: 128M
admin_memory_limit: 256M
max_input_time: -1
upload_max_filesize: 2M
php_post_max_size: 8M
curl_version: 7.64.0 OpenSSL/1.1.1d
suhosin: false
imagick_availability: true
pretty_permalinks: true
htaccess_extra_rules: true

### wp-database ###

extension: mysqli
server_version: 10.5-MariaDB
client_version: mysqlnd 7.4

### wp-constants ###

WP_HOME: undefined
WP_SITEURL: undefined
WP_CONTENT_DIR: /var/www/html/wp-content
WP_PLUGIN_DIR: /var/www/html/wp-content/plugins
WP_MAX_MEMORY_LIMIT: 256M
WP_DEBUG: false
WP_DEBUG_DISPLAY: true
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: false
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_LOCAL_DEV: undefined
DB_CHARSET: utf8
DB_COLLATE: undefined

### wp-filesystem ###

wordpress: writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable

Thanks!

This problem goes away for me with https://github.com/leonstafford/wp2static-addon-advanced-crawling enabled.

This problem goes away for me with https://github.com/leonstafford/wp2static-addon-advanced-crawling enabled.

This problem goes away for me with https://github.com/leonstafford/wp2static-addon-advanced-crawling enabled.

Thanks John. I've downloaded the master code from the repo, and I've compiled with composer. Then I've installed in Wordpress with plugin menu > select local file. Now, I can see the pluging "WP2Static Add-on: Advanced Crawling Options" in the Wordpress plugin list, but not in the WP2Static > Addons, neither any options in other menus. Do I have to do something else? Because I've re-generated the static web and the folder "wp-content/plugins" still does not exist.
Thanks! Regards.

This problem goes away for me with https://github.com/leonstafford/wp2static-addon-advanced-crawling enabled.

Thanks John. I've downloaded the master code from the repo, and I've compiled with composer. Then I've installed in Wordpress with plugin menu > select local file. Now, I can see the pluging "WP2Static Add-on: Advanced Crawling Options" in the Wordpress plugin list, but not in the WP2Static > Addons, neither any options in other menus. Do I have to do something else? Because I've re-generated the static web and the folder "wp-content/plugins" still does not exist.
Thanks! Regards.

You definitely need to see it in the Addon list. The code to add it to the list is very straightforward and runs on every page load, so it sounds like something fundamental is broken. Do you see any messages in your web server's error log?
I've also attached a known-good build that may work for you:
wp2static-addon-advanced-crawling-1.0-alpha-003.zip

You definitely need to see it in the Addon list. The code to add it to the list is very straightforward and runs on every page load, so it sounds like something fundamental is broken. Do you see any messages in your web server's error log?
I've also attached a known-good build that may work for you:
wp2static-addon-advanced-crawling-1.0-alpha-003.zip

Thanks for your reply John.
I use WP Multisite and I've discovered that the addon only installs it in the site base, but not in other sites. I've solved easily: in database, I insert the same register from table *_wp2static_addons in the site table *_<<SITE_NUMBER>>_wp2static_addons.
But this not solve the problem. After this I've generated the static site and the problem persists. Here my WP log:
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-includes/css/dist/block-library/style.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-content/plugins/cookie-notice/css/front.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-content/themes/hello-elementor/style.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-content/themes/hello-elementor/theme.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:15 +0000] "GET /site1com/site1com/wp-content/plugins/cookie-notice/js/front.min.js HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:15 +0000] "GET /site1com/site1com/wp-json/ HTTP/1.1" 404 5813 "-" "WP2Static.com"

Here we can see that the addons search the content in REPLICATED PATH: site1com/site1com.
If you need more information, I am at your service.
Thanks! Regards.

Thanks for your reply John.
I use WP Multisite and I've discovered that the addon only installs it in the site base, but not in other sites. I've solved easily: in database, I insert the same register from table *_wp2static_addons in the site table *_<<SITE_NUMBER>>_wp2static_addons.
But this not solve the problem. After this I've generated the static site and the problem persists. Here my WP log:
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-includes/css/dist/block-library/style.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-content/plugins/cookie-notice/css/front.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-content/themes/hello-elementor/style.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:14 +0000] "GET /site1com/site1com/wp-content/themes/hello-elementor/theme.min.css HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:15 +0000] "GET /site1com/site1com/wp-content/plugins/cookie-notice/js/front.min.js HTTP/1.1" 404 5813 "-" "WP2Static.com"
[15/Jan/2021:13:53:15 +0000] "GET /site1com/site1com/wp-json/ HTTP/1.1" 404 5813 "-" "WP2Static.com"

Here we can see that the addons search the content in REPLICATED PATH: site1com/site1com.
If you need more information, I am at your service.
Thanks! Regards.

Hi @leonstafford,
I have some similar problem with some of my multisite environments. So far I have tracked down the error to this line of code: https://github.com/leonstafford/wp2static/blob/develop/src/DetectPluginAssets.php#L29
The option active_plugins does not seem to contain network-wide enabled plugins, does it?! There is another option called active_sitewide_plugins in the wp_sitemeta table that contains a list of network-wide active plugins. Maybe you might want to merge them into a single array?
So @aramcap might have activated the cookie-notice plugin network-wide and then the DetectPluginAssets class will not collect the plugin's assets because the active_plugins does not contain this plugin, but active_sitewide_plugins does?!
Best regards
Stefan

Many thanks, @stefanullinger, that sounds very helpful!
Could you please confirm if you're using subdomain multisite or subdirectory?
I'm relying on my Lokl project for most of my testing at the moment, which doesn't support multisite today, but may be able to quickly add it in either/both forms. That would be good for me to get more familiar with multisite stuff, else, I have to spin up a VM/VPS.
I've started moving all detection stuff into https://github.com/leonstafford/WordPressURLDetector, so will get this multisite detection stuff into that library and start importing that into WP2Static soon. There's still a bit of work to do on that, though.
If it's taking too long, I may be able to do the quick array_merge suggested here in an interim release.

Hi @leonstafford,
I've tried both multisite options now – using a subdomain multisite, and using a subdirectory multisite. Either way, WordPress will store network active plugins in the active_sitewide_plugins option of the wp_sitemeta table.
I will create a PR on your WordPressURLDetector repository now. Thanks for extracting all of this into a separate library by the way!
Would be cool, if you could provide an update of WP2Static soon, as I have some multisite project running in production, and copying missing files manually slows down the deployment / maintenance of this project a bit.
Best regards
Stefan


A question about your code

I am a newbie in this field, and I have a question about your code. When you instantiate AttackPGD, you enter the initial model. During the training of the model, whether the weight of the model entered in PGD is not updated.
Here is the detail about this issue. The following work did not update the parameters of basic_net.
net = AttackPGD(basic_net, config)

Hi!  This code does update the parameters of basic_net since they are also parameters of net.


ISPN-11586 CNFE when using testdriver in ServerRunMode.EMBEDDED mode

The org.infinispan:infinispan-core test-jar is required since its org.infinispan.test.TestingUtil is
used by org.infinispan.server.test.core.EmbeddedInfinispanServerDriver#start when running in
embedded run mode and optional maven dependency doesn't make it on the CP thus CNFE.
https://issues.redhat.com/browse/ISPN-11586
10.1 - https://github.com/infinispan/infinispan/pull/8159

Merged, thanks @rhusar !

I disagree with this. infinispan-core test jar was made optional because external projects should use CONTAINER mode, not EMBEDDED

@tristantarrant Ok, so it looks like the design decision is that EMBEDDED mode is never to be used outside of Infinispan test suite. Is there any technical reason why this won't work? I got it working in your example project on GitHub without problems (although, I haven't gotten it to work within our test suite).
If you really think that EMBEDDED mode is unusable outside of ISPN, I can revert this and update the Javadoc on the https://github.com/infinispan/infinispan/blob/master/server/testdriver/core/src/main/java/org/infinispan/server/test/core/ServerRunMode.java to make this clearer - although, the DEFAULT mode is also EMBEDDED mode unless the container image stream is explicitly set, so that probably needs to be refined as well.


Automatically remove nan from input data when it is sparse.

Solves https://github.com/dmlc/xgboost/issues/2053

Codecov Report

Merging #2062 into master will decrease coverage by -0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
- Coverage   30.75%   30.58%   -0.18%
==========================================
  Files          72       72
  Lines        5823     5836      +13
  Branches      580      583       +3
==========================================
- Hits         1791     1785       -6
- Misses       3957     3971      +14
- Partials       75       80       +5

Impacted Files
Coverage Δ

src/tree/updater_histmaker.cc
0% <ø> (ø)
:white_check_mark:

src/c_api/c_api.cc
0% <ø> (ø)
:white_check_mark:

src/tree/updater_colmaker.cc
0% <ø> (ø)
:white_check_mark:

src/data/sparse_page_raw_format.cc
80.76% <ø> (-3.85%)
:x:

src/objective/regression_obj.cc
89.26% <ø> (-1.13%)
:x:

src/data/simple_dmatrix.cc
58% <ø> (-0.67%)
:x:

src/data/sparse_page_dmatrix.cc
86.41% <ø> (-0.55%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7927031...40f6e26. Read the comment docs.


rollouts: add container cluster watch

This pull request updates the rollouts proof of concept, adding a watch for container cluster resources. This watch allows the reconciliation of rollouts when the target cluster list changes (for instance, a cluster being added or removed from the list).

Good going so far. I have couple of minor comments.
I am also thinking if we need to do the same thing for RemoteRootSync ? and how to take care of orphaned RemoteRootSync because they will not be captured here probably.

Thanks! I updated the code so this should be ready for review.
Regarding the RemoteRootSync, I believe we already have this covered since the Reconciler considers this as a 'Owned' resource so it automatically watched. For example, anytime I delete a RemoteRootSync outside of a rollout, the rollout reconciles and recreated the sync.
I'll be covering the orphaned case in a separate pull request that will focus on removing a RemoteRootSync that is no longer needed by a rollout. The ETA for the pull request is this afternoon. This pull request here is important as it does trigger the rollout reconcile when a cluster is removed from the target set which leads us into this scenario.


Exclude dependabot from committer highlight section

When seeing the preview on https://eclipsefdn-adoptium-v2.netlify.app/ the committer highlight section on the front page can show dependabot. I think it would be fine to exclude dependabot from the eligible candidates.

makes sense to me, the code is in https://github.com/adoptium/website-v2/blob/main/src/hooks/useAdoptiumContributorsApi.tsx if you want to have a go at it?

Thanks for the pointer! I'll see if I can take a poke, but I can't safely commit to a date within this month :( sorry;;


Some changes for integration

Two main changes:

Using absolute path. I do not have a good solution for the changes made in ss_log_config.json
Fixing robot waiting issue (ss_ros.py).

Can you submit the pull request to merge into the develop branch instead of the master branch?
Also, for future requests, it'd be great if you could divide up the fixes into smaller pieces that address just one issue each (e.g., one pull request to fix the script files, one to fix the file paths, etc). That'll make it easier to accept the changes that are fine, while letting us hash out anything that still needs revision in a separate request.

Let me close this request and make necessary changes and then submit the request to the develop branch.


Change the CLI name

The CLI name 'ocmqe' does not respond to the repository's goal. Let us update its name to 'ocdm' whose full name is 'openshift cloud data management'.

As far as I can see, here are some criteria:

multicloud: aws, gcp
we may incorporate later some common test shared packages

what about ocm-cloud-management ? or ocm-cloud-test-management ?


New branching model

I've come up with this excellent article and, from now on, I've decided to adopt its Successful Git branching model on this repository and all of its associated bindings.
There will be two permanent branches:
- master: containing only stable releases.
- develop: to push all the daily work.
Develop of new features will be done on its own branches that won't be (unlikely) pushed to origin. There will be also branched related to releases and hotfixes as stated in the article.
It's going to be a little hard to get used to this kind of workflow, but it will help with the development of the library and will pave the way for easier future collaborations.

Already accomplished. Closing...


Search and load guess plugins automatically

Unlike other plugins, users normally don't know name of guess plugins. So, they don't write name of the guess plugins to configuration files.
To make guess plugins pluggable, Embulk should find and load installed guess plugins automatically.

An implementation idea is:

add PluginSource.listPlugins(Class<?> type) method
JRubyPluginSource (Embulk::PluginRegistry) returns list of installed plugins using Gem API

is this perhaps difficult...?

GuessExecutor calls the method and uses them automatically.

I haven't heard this requirement. Closed for now.
Reopen if necessary.


chore(release): upgrade Alpine base image to 3.19

Summary

Checklist

[ ] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #FTI-5288

Should we update the GCC version as well? https://github.com/Kong/kong/blob/30154217e03d7b77675716e0728609b19518dc73/build/toolchain/repositories.bzl#L26

Only required by individual customers.


Proof of concept .NET Core version

This is a proof of concept TikaOnDotnet build that multitargets .NET 4.6.2 and .NET Core 3.1. There are some major changes to the build process in this fork.... Using IKVM-Revived version 8.2.1 and its IkvmReference tag instead of the old build script.
This isn't ready to merge yet. Mainly submitting to get the ball rolling on issue #113.
Thank You :)

Thank you so much for doing this. I'll take a look as soon as I can. I do think this is a good opportunity to get tika working on dotnet core and update the deployment to be "modern" on Github actions. If anyone wants to setup up and collaborate on this do chime in. I do not have a lot of bandwidth for this project but do want to keep the lights on if possible now that ikvm revived has been released.

@dylanlangston Hmm I have everything but TextExtractor building. It seems that the namespaces are all messed up.

Closing this to move work to #152 because I wanted to continue this work on its own branch. I did pull in the POC and will be using it as a basis for the work. Thank you!


Task "ngtemplates" failed

looks like no registration of this kind of task?

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Don't refetch images from the store

Signed-off-by: Matthew McNew<EMAIL_ADDRESS>

Codecov Report

Merging #249 into master will increase coverage by 0.16%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   66.08%   66.25%   +0.16%
==========================================
  Files          73       74       +1
  Lines        2677     2726      +49
==========================================
+ Hits         1769     1806      +37
- Misses        691      697       +6
- Partials      217      223       +6

Impacted Files
Coverage Δ

pkg/apis/experimental/v1alpha1/store_types.go
0% <ø> (ø)
:arrow_up:

pkg/cnb/store_buildpack_repository.go
78.84% <100%> (+4.7%)
:arrow_up:

pkg/cnb/remote_store_reader.go
70% <63.63%> (-14.62%)
:arrow_down:

pkg/cnb/mountable_buildpack_layer.go
80.48% <80.48%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b8ce1...dbf8d4c. Read the comment docs.


[INTEL MKL] Fixes a failure in //tensorflow/python/profiler:model_analyzer_test.

Modified  testComplexCodeView to look for lower total_float_ops. The value of total_float_ops is lower when Tensorflow is compiled with Intel MKL.

@rmlarsen thanks. I have updated the PR based on your feedback.


Wisconsin long term care update

Added “Are you enrolled in a Medicaid long-term care program?” to universal qualifier list
Added qualifier to active phase, split off some of the LTR more info string into this qualifier instead

[{"key":"global","type":"customStrings","value":{"content":{"c19.eligibility.question/long_term_care_resident.are_you":{"en-us":"Are you enrolled in a Medicaid long-term care program?"}}}},{"key":"wisconsin","type":"vaccination","value":{"content":{"phases":[{"id":"1a","qualifications":[{"question":"c19.eligibility.question/long_term_care_resident.are","moreInfoText":"c19.eligibility.moreinfo/long_term_care_resident.are.wi.1a"},{"question":"c19.eligibility.question/essential_worker.ff_leo_corrections","moreInfoText":"c19.eligibility.moreinfo/essential_worker.ff_leo_corrections.wi.1a"},{"question":"c19.eligibility.question/age.65_up"},{"question":"c19.eligibility.question/essential_worker.are_you","moreInfoText":"c19.eligibility.moreinfo/essential_worker.are_you.wi.1a"},{"question":"c19.eligibility.question/essential_worker","moreInfoText":"c19.eligibility.moreinfo/essential_worker.wi.1a"},{"question":"c19.eligibility.question/congregate.do","moreInfoText":"c19.eligibility.moreinfo/congregate.do.wi.1a"},{"question":"c19.eligibility.question/health","moreInfoText":"c19.eligibility.moreinfo/health.wi.1a"},{"question":"c19.eligibility.question/healthcare_worker","moreInfoText":"c19.eligibility.moreinfo/healthcare_worker.wi.1a"},{"question":"c19.eligibility.question/long_term_care_resident.are_you","moreInfoText":"c19.eligibility.moreinfo/long_term_care_resident.are_you.wi.1a"}]}]}}},{"key":"wisconsin","type":"strings","value":{"content":{"c19.eligibility.moreinfo/long_term_care_resident.are.wi.1a":{"en-us":"SDMAC's definition of residents of long-term care is: “adults who reside in facilities that provide a variety of services, including medical and personal care, to persons who are unable to live independently.”","ko-kr":null,"vi-vn":null,"zh-cn":null,"es-us":null,"de-de":null,"es-es":null,"fi-fi":null,"fr-fr":null,"he-il":null,"it-it":null,"ja-jp":null,"pt-pt":null,"sv-se":null,"th-th":null},"c19.eligibility.moreinfo/long_term_care_resident.are_you.wi.1a":{"en-us":"Individuals enrolled in Medicaid long-term care programs became eligible to get the COVID-19 vaccine. This includes:\n\nMembers of Family Care and Family Care Partnership\nParticipants in IRIS (Include, Respect, I Self-Direct)\nChildren ages 16 years and older in the following programs:\nChildren's Long-Term Support Waiver Program\nKatie Beckett Program\nChildren's Community Options Program (CCOP)\nChildren Come First\nWrap Around Milwaukee\nChildren with Medical Complexity Program"}}}}]


translated a sentece from english to spanish

translated one sentence that was missed apparently. plz double-check, I am not a native spanish speaker

Thanks for finding this! @miguelraz does this sentence look good?

@mbauman this looks good to merge :)

Sorry for the delay @JoHof and thanks again!


Quick Onboarding Setup

Assalamualaikum,
There's some issue with initial setup for new onboarding developer to get started quickly.
1. Google Identity setup is required
GOOGLE_CLIENT_ID=
GOOGLE_CLIENT_SECRET=

Currently this is a blocker for me to spin locally as I need to setup google identity oauth. Is there env that can bypass this setup for developer to contribute faster?
Edit: I've added a guide you can add to your wiki. Just copy paste.
https://github.com/farhan-helmy/ratemysurau/issues/63
2. DB Seed has setup errors
Following the Installation setup in Readme, there's issue with db setup. Migration steps are missing.
Will create a PR to support you in this, as I was able to spin up the db successfully. (plus Readme update)
$ yarn
$ yarn db:migrate # will create PR to have this script
$ yarn db:seed # will create PR to have this script

Unfortunately, even after seed I can't seem to see the record in the homepage. Suggesting a dummy seed data for contributors.
3. Secret exposed for local DB
I believe this was intended for local development, but for safety, best to change to Makefile password to password.

4. Usage of .env.local
You might be using this for separating local and remote, but for new onboarding user, I suggest to keep it simple with .env.
    # there's `.env.local` here
    "db-seed:local": "NODE_ENV=development dotenv -e .env.local -- prisma db seed"

Or we can update Readme to include .env.local as part of setup.

Waalaikummussalam awesome stuff Zafranudin! Will checkout ur PR


Implement basic XML documentation parsing

Need to parse XML docs this way (tag => property):

Name => Name
<summary> => Summary
<param> => items of Parameters
<typeparam> => items of GenericParameters
<exception> => items of Exceptions
<returns>/<value> => Returns
<inheritdoc> => get it from base
All the rest => Notes

<include>s are not planned to be handled as for the first version. Highlights (<c>, <see> and friends) should be surrounded with asterisks to use a special font for them. Existing asterisks should be escaped with \.

<inheritdoc>s will not be handled in the first version as well as <include>s.

Manual testing shows that XMLDocParser has been debugged. Unit tests were moved to another ticket (#7).


Fix SourceDistTask with underscore in version

The project's version number, if it contains a _ needs to be converted to a -.
Closes #84

Is this good?
Do you need anything else??

Can you please rebase and squash commits?

You can do this in the merge as an admin of this project.
Go to project settings and enable it.
https://github.com/blog/2141-squash-your-commits

Squashing commits removes history, and if we ever want to do some fixup before doing a merge (we've done this internally) you would loose credit for the commit on the merge commit. So we do merge commits for PR's.

Oh, I didn't know that. Good to know for the future.


Package configuration and how to turn things off for none typescript projects

I have other projects in Sublime that do not do anything with TypeScript. But my console logs a lot of TS messages (assuming that is indeed TypeScript). So how do I turn this off?
How can I make one project use the TypeScript plugin and all my other projects just leave unaffected.
I also noticed there is no preference / package settings / typescript ?
[2015-11-03 13:11:39,399 - INFO     - TS] Popup resource path: Packages/TypeScript/popup.html
[2015-11-03 13:11:39,400 - INFO     - TS] Loaded tooltip template from Packages/TypeScript/popup.html
[2015-11-03 13:11:39,404 - DEBUG    - TS] on_activated
[2015-11-03 13:11:39,405 - DEBUG    - TS] on_selection_modified
[2015-11-03 13:11:39,410 - DEBUG    - TS] on_post_text_command
[2015-11-03 13:11:47,037 - DEBUG    - TS] on_activated
[2015-11-03 13:11:48,418 - DEBUG    - TS] on_text_command
[2015-11-03 13:11:48,418 - DEBUG    - TS] on_selection_modified
[2015-11-03 13:11:48,419 - DEBUG    - TS] on_post_text_command
[2015-11-03 13:11:48,548 - DEBUG    - TS] on_selection_modified
[2015-11-03 13:11:49,236 - DEBUG    - TS] on_text_command
[2015-11-03 13:11:49,237 - DEBUG    - TS] on_selection_modified
[2015-11-03 13:11:49,237 - DEBUG    - TS] on_post_text_command
[2015-11-03 13:11:49,298 - DEBUG    - TS] on_selection_modified
[2015-11-03 13:11:49,860 - DEBUG    - TS] on_text_command
[2015-11-03 13:11:49,861 - DEBUG    - TS] on_selection_modified
[2015-11-03 13:11:49,861 - DEBUG    - TS] on_post_text_command
[2015-11-03 13:11:49,958 - DEBUG    - TS] on_selection_modified

The way sublimed works is that it loads all the plugin at startup, and then lets the plugin to decide which files to handle or not. In the TS plugin we check the file types before we do anything.
The reason you are seeing these log files might be some other plugin changed the log level to DEBUG, because all these debug messages are not supposed to be seen normally. Although the plugin is not doing anything except checking the file types.
Regarding the settings, it is in a PR now: https://github.com/Microsoft/TypeScript-Sublime-Plugin/pull/375
It will be there soon. Thanks!

FYI the "preference / package settings / typescript" is added to master.

confict with Anaconda plugin. Just open a python file,the console show debug info like this. pls help!


Added GC locations to Enable Node Map doc

Closes #2885

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f7925cee2c221c31b1ada6e5f75140b39b2a716c/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dbbc8f34c6a19492dca38281ba3a95f7a151b46b/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a383ef5cf9597dca0a3127220880ed9fa39bb108/


Line comment without following string literal breaks syntax hightlighting

A line comment that starts with html but is not followed by a temlate literal breaks syntax highlighting for the rest of the file.
Minimal example:
const foo = 'html'; // html is awesome
console.log(foo);

The part before the comment is displayed correctly, but the comment and the next line are default text color and VS code showes JS completion when typing inside the comment.

Will be fixed in next 24 hours.
Thankyou

Issue is fixed


Link Color

How can I change the Link color, Please?

Pass in a custom link https://github.com/MrBlenny/react-flow-chart/blob/master/stories/CustomLink.tsx#L66


Ensure that PlantCV runs in Clowder

Need to be able to reproduce PlantCV worklflow from tutorial and embed on Clowder
Use perimeters from tutorial. These can be changed using Jupiter later.

Plant CV perimeter settings work for the Danforth system only.  We will focus on this for now.

Ensure that any two steps work - like object shape attributes (height)

1st step is mask. Second is analysis

plantcv extractor coding has been done. will create three issues this week to get it into the prototype framework:

merge source code to dockerfile and create extractors-plantcv
integrate in nebula
test sample input images

Here is an example of plantcv running in Clowder: http://<IP_ADDRESS>/clowder/files/564214dce4b086fa6db9104f
TODO:

[ ] commit code to Clowder or PlantCV repository (for PlantCV, I made a fork here: https://github.com/terraref/plantcv)
[ ] Document end-user functionality

[ ] pull code

@robkooper I think the remaining task before closing this issue is to merge the pull request for the PlantCV docker file


ResourceLoader.has_cached() giving unexpected output when ResourceLoader.load() called with no_cache=true

Godot version
3.3.stable, 3.4.4.stable
System information
Linux Mint 20.3
Issue description
func _ready():
	var res = Resource.new()
	var path = "res://test.tres"
	ResourceSaver.save(path, res)
	for i in range(10):
		res = ResourceLoader.load(path, "", true) # no_cache=true
		print(ResourceLoader.has_cached(path))

This code gives the following output
True
False
True
False
True
False
True
False
True
False

It should be all False.
Steps to reproduce

Save a resource using ResourceSaver.save() at a path.
Load it using ResourceLoader.load() with no_cache = true.
Use ResourceLoader.has_cached() on the path.
Repeat step 2 & 3 few times.

Minimal reproduction project
Minimal.zip

Related to https://github.com/godotengine/godot/issues/59686.

Temporary workaround for anyone having the same problem:
use res.resource_path = "" or res.take_over_path("") after the load().
In case res has subresources do this for them too.

And another issue that is for a different method, but likely related as it is also based on cache (rebuild/refresh) misbehaviour: https://github.com/godotengine/godot/issues/43990

Fixed by #62408.


Option to intercept requests before firing event

Hey!
I've stumbled upon a possible issue, Currently if the upstream option is set the incoming host header isn't being used. We use a single worker for multiple subdomains, but still need the correct upstream URL. So we need to fetch the subdomain from the incoming request and use it as the subdomain on the upstream URL.
With dollarshaveclub/cloudworker we had to create our own HTTP server so this could be handled easily, But now we are using the server built into MiniFlare which handles things slightly different to our use case.
If we are able to modify the incoming request just before this.dispatchFetch is called it would solve our problem. As long as we had access to the original incoming request and the new request that get's passed to the worker
https://github.com/mrbbot/miniflare/blob/8010e3321d7913a206839e683ef469c22df5aedb/src/index.ts#L416

Awesome! I've created my own server for now as we don't terminate WS in the worker, We just pass it onto the origin. I look forward to the above update 😁


use recapture when doing redo on ordered-write errors

what I already tested manually

update passes
update fails with validation rule
retry of update fails again (but is creating a new trigger-log record)
retry passes when validation rule is dropped / fixed

and the same for insert

@samifahed I just did the manual test, see comment.


[FEATURE] allow defaultValue to be passed in for first() and last()

Currently trying to chain off first() or last() without having to first check length is causing flow errors about not being able to perform the next action off undefined.
e.g.
foo.last().get('bar') throws Cannot call foo.last().get because property get is missing in undefined
It would be awesome to be able to use first() and last() in the same way that get(), getIn(), updateIn(), etc. work.
Suggested API:
foo.last(Map()).get('bar')
Allow first() and last() to take an optional single argument to act as a defaultValue when there is no first or last value found.

I'd like to take this issue up, if that's okay.

I think that's a great idea and you should make a PR @yasserhussain1110!

@rgbkrk I have created a PR. Please let me know if corrections/changes are required.


updates to the project docs naming and organization + wrote new project setup instructions for dbt cloud

fixes #275

I am not sure why, it renders for me locally with no problem.

If the files are present on your local branch but not github, is there any chance they aren't getting committed?

Thanks for review and feedback @JamesSLogan! I think this is ready now

Almost there - mkdocs now shows me these messages:
WARNING -  Doc file 'code-review.md' contains a relative link './setup.md#install-dependencies', but the target 'setup.md' is not found among documentation files.
WARNING -  Doc file 'snowflake-project-setup.md' contains a relative link './setup.md#aws', but the target 'setup.md' is not found among documentation files.

I believe these 2 links need to be to local-setup instead of setup now.

Thanks for catching and flagging those warnings @JamesSLogan and for all the feedback and review.

Nice work @britt-allen!

Thanks @ian-r-rose!


Localize timezones on dailyReportsChart

Report dates are localized to the browser's timezone, but the dailyReportsChart on the dashboard is not. This means that the chart shows a date that hasn't "had" any reports yet. It would be nice for this to also be localized.

Hi! would like to take up this issue :)


[Federation][kubefed] Not possible to disable a controller via --controllermanager-arg-overrides

 Issue by marun
Wednesday Mar 08, 2017 at 23:25 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/42761

#42375 promised to support disabling any of the federation controllers.  However, due to the way kubefed init marshalls overrides (splits on commas), multi-valued overrides (separated by commas) are not supported.  This means that only a single controller can be disabled.
Support for multi-valued arg overrides was discussed on #40917.
cc: @kubernetes/sig-federation-bugs

 Comment by irfanurrehman
Thursday Mar 09, 2017 at 15:37 GMT

As a bug fix, I think we can replace currently used ',' with another special character (;, :, or something else) for 1.6, but I think we might need to think more beyond 1.6..
Or does a dedicated argument for disabling controllers makes more sense.. ? (because the overrides argument details might end up with 2 notes, in 1.6 release notes, if we do above)

 Comment by marun
Tuesday Mar 28, 2017 at 23:26 GMT

Actually, not even a single controller can be disabled via override.   The marshalling code disallows the form that would be required (e.g. --controllers=services=false):
https://github.com/kubernetes/kubernetes/blob/master/federation/pkg/kubefed/init/init.go#L915

 Comment by marun
Friday Mar 31, 2017 at 04:16 GMT

I've updated the title to reflect the increased severity of the problem.  The following documentation provides an example that currently breaks kubefed init as per my previous comment:
https://kubernetes.io/docs/tutorials/federation/set-up-cluster-federation-kubefed/#passing-command-line-arguments-to-federation-components

 Comment by irfanurrehman
Thursday Apr 06, 2017 at 11:39 GMT

How about using a ":" as the key:value separator.
for example:
--apiserver-arg-overrides="--anonymous-auth:false,--v:4" \
--controllermanager-arg-overrides="--controllers:services=false"

Any of you have come across, any arguments (or possibility of them in future) which might have a ":" in use.
If this sounds ok, I will raise a PR ASAP, and update the documentation too.

 Comment by perotinus
Thursday Apr 06, 2017 at 14:54 GMT

@marun @irfanurrehman Couldn't we also fix the issue with the marshaling code? Instead of splitting on every =, it would scan for a comma, then split on the first = after that comma. The state machine is a bit more complicated, but from a user's point of view it should work as expected, whereas using colons makes for a bit of an odd experience.
For that matter, isn't there a Go library that could deal with this sort of marshaling?

 Comment by marun
Thursday Apr 06, 2017 at 21:42 GMT

I agree with @perotinus that it would be preferable to split on the first = rather than confusing things with an additional separator character.
No code is always better, but in this case a simple parsing change should solve the problem. Unless there's already a vendored library that handles this I'm not sure it'd be worth the dependency.

 Comment by irfanurrehman
Friday Apr 07, 2017 at 09:40 GMT

@marun @perotinus, actually there are two issues here that need to be solved. Apologies for confusing this one with the other (multiple controllers cannot be disabled using kubefed init). I agree with perotinus, for the current issue, update the marshaling and the problem of = can be solved (if only one controller is specified).
To solve the multiple controllers problem (and still using the --controllermanager-arg-overrides) needs changing the separator to another character then ,. To me this sounds like a viable solution because, its quite unlikely that the other separator for example : will also be used by some other argument (but very likely that , will be used by somebody else again).
One other solution, given that this is the only argument which uses both = and , in value; is a dedicated kubefed init argument for disabling controllers, but will fall flat if some other argument presents the same problem in future.
My suggestion would thus be to solve the = problem with updated marshalling and , problem replacing it to another separator (say :).

 Comment by madhusudancs
Tuesday Apr 11, 2017 at 00:11 GMT

Copying my comments with context from PR #44209.

How is that less complex?

More complex in terms of UX, not implementation. I think it would be simpler for the user to provide a first-class argument to kubefed vs having to remember kubefed-specific formatting for multivalued arguments.

There are pros and cons. There are the advantages that you mention here. But on the other hand

Every user, even the ones who don't care about these flags, has to sift through the ton of documentation that is generated for these flags.
Each such flag has to be dealt on a case-by-case basis. If we miss a flag in a release, there will be a window where users will have to wait for that flag to be available in kubefed.
Adds to the confusion. There are now multiple ways of providing override args.
Name collision. You might have a flag with a same name for different components that mean different things. Now you need to namespace them or qualify them with the component name. In either case those names are not exactly the same as the one taken by the components and users need to learn this.

 Comment by marun
Tuesday Apr 11, 2017 at 14:04 GMT

@madhusudancs I think those justifications are largely hypothetical, and that following the principle of YAGNI would be a more likely path to usable software.

 Comment by nikhiljindal
Tuesday Apr 11, 2017 at 17:13 GMT

Yes I agree with @madhusudancs. We will always be playing a catchup game to add flags to kubefed whenever they are added to any federation control plane binary. A generic mechanism, where kubefed just passes through the flag works better. kubefed doesnt need to know about all of those flags.

 Comment by perotinus
Tuesday Apr 11, 2017 at 18:00 GMT

@madhusudancs @nikhiljindal I'm not sure that a generic mechanism for passing parameters and having top-level arguments to kubefed are mutually exclusive. There's benefit to making common things easier to do, and still providing an escape hatch for other things.
That said, I still think the overrides passed as a flag mechanism is not a good one, and we should replace it ASAP.

 Comment by madhusudancs
Tuesday Apr 11, 2017 at 21:18 GMT

I'm not sure that a generic mechanism for passing parameters and having top-level arguments to kubefed are mutually exclusive.

They are not mutually exclusive. But we need to be deliberate. I don't think "a flag that takes comma-separated values" qualifies to be top-level flag in kubefed.

There's benefit to making common things easier to do, and still providing an escape hatch for other things.

But what makes this common? The argument here is not about common vs uncommon flags, but it is about flags that take comma separated values. They are two different things.

That said, I still think the overrides passed as a flag mechanism is not a good one, and we should replace it ASAP.

This was always supposed to be a medium-term solution. The long-term solution is to use some form of structured config.

 Comment by irfanurrehman
Wednesday Apr 12, 2017 at 06:24 GMT

I think its time we explore using the config similar to what kubeadm does -> https://kubernetes.io/docs/admin/kubeadm/
As far as I understood, kubeadm allows overriding args only through config.
Earlier, we did choose to use command line args for simplicity, and if we suspect breaking users cases, by removing command line override args (given kubefed declared beta in 1.6); we can have both. Suggestions?

 Comment by perotinus
Friday Apr 14, 2017 at 00:47 GMT

Hmm. I'm not quite sure what the right path forward is here. If we want to get something done right now, then I think the proposed solution of using colons is the way to do that. I'm concerned that adding this will tie us to supporting it going forward, or that something in the future will require a colon and we'll have tied our hands: it's dangerous to choose an arbitrary sentinel character, because you never know when you'll need it elsewhere.
How pressing is it to fix this issue? If we can wait until we have a more integrated solution to kubefed configuration, then we will have less to maintain.

 Comment by marun
Friday Apr 14, 2017 at 03:07 GMT

How pressing is it to fix this issue? If we can wait until we have a more integrated solution to kubefed configuration, then we will have less to maintain.

The docs say this is supported or 1.6, so a fix to either docs or the code is suggested.
@nikhiljindal Is this required for your work in disabling alpha features by default, so that users will have a way of enabling controllers that would otherwise be disabled?

 Comment by nikhiljindal
Friday Apr 14, 2017 at 06:38 GMT

@nikhiljindal Is this required for your work in disabling alpha features by default, so that users will have a way of enabling controllers that would otherwise be disabled?

Controllers can be explicitly disabled or be disabled automatically if the corresponding API resource is disabled. My plan is to use the later. I will disable apha APIs which will automatically disable the corresponding controllers. Enabling the APIs using --runtime-config flag on federation-apiserver will enable the controllers.
Now I assume the same problem exists with runtime-config flag for apiserver. So they can enable one alpha API or all (runtime-config supports api/alpha=true to enable all alpha APIs at once) but not 2.
There is always the workaround to run kubectl edit deployments federation-apiserver-deployment --namespace=federaion-system directly and pass runtime-config flag.

 Comment by quinton-hoole
Friday Sep 08, 2017 at 02:10 GMT

cc @madhusudancs @perotinus as they probably need to fix this for the cluster registry reference implementation.  I'm pretty sure @irfanurrehman is not currently working on this, so unassigning.

cc @marun


⚠ Bofrost.es has degraded performance

In 6aa7e11, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1686 ms

Resolved: Bofrost.es performance has improved in 27bab5f after 12 minutes.


Ignore links specified in reltable if topics are filtered out

Let's say that in the DITA Map I refer to a topic with a profiling attribute set on the topicref:
    <map title="Growing Flowers">
         <topicref href="topics/introduction.dita" audience="expert"/>
      <topicref href="topics/care.dita"/>
      <reltable>
        <relrow>
          <relcell><topicref href="topics/introduction.dita"/></relcell>
          <relcell><topicref href="topics/care.dita"/></relcell>
        </relrow>
      </reltable>
    </map>

I then publish using a DITAVAL to filter out the "audience=expert" value. But there is still a reference to the "introduction.dita" in the reltable and this particular reference does not have the same profiling attribute set on it.
Because of this, the HTML generated for the other topic "care.dita" will contain a reference to "introduction.html".
So maybe a topic referenced in a reltable should be ignored if it is explicitly excluded in the DITA Map.
I added a sample project here:
ignoreLinksInReltable.zip

+1 Another one of our end users had the same need, to automatically exclude from the reltable links to topics filtered out from the main DITA Map

Interesting ... I wonder if this would always be the case? If a topic is excluded from the TOC, you might still want to create links to that topic, but I'm not sure. The intent with the sample above seems clear but I think it's easy to create more complicated ones that make it less obvious.
You can reference a topic as many times as you want from a map, and we definitely don't want to automatically, always combine all of the filter values from all of the references. The <ditavalref> processing also complicates things. I'm thinking of a case where you might have a topic once in the TOC for experts, once in the TOC for beginners, and somewhere else as part of a key definition. [Of course -- if you use relationship tables with this then it's already going to be confusing for many cases, so trying to figure out what / where to filter is already probably not always giving the right result.]

I would consider the example above to be user error: reltable links should never use direct URL references because the context of the intended target is ambiguous and, in the case where there is no other reference to the topic from the map, the topic has no defined location in the navigation hierarchy (and thus would not be present in PDF-type output, which would almost certainly not be what the author intended).
In that case I would support Robert's assertion that, at least for HTML-type outputs, it might be reasonable to render the topic and have a reltable link to it.
In the case where a reltable topicref uses a key reference then there should be no computational problem determining whether or not the target topicref is or isn't filtered out--if the key can't be resolved (and there's no fallback @href) then the link is unresolvable and should itself be suppressed. If the key is resolved to a normal-role topicref (directly or indirectly), then the link is resolvable and should be retained.

People are still interested in this, see: https://www.oxygenxml.com/forum/dita-editing-and-publishing-dita-content/topic24461.html


Megan's final edits!

Megan's final edits before the last :fingers crossed: push to content.  I will add to this PR throughout the afternoon with anything else I find.
Changes

link on the journey disclaimer to new ask Q
copy edits to form explainer additions that I never carefully proofed before

Review

@virginiacc @stephanieosan

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@virginiacc  It's getting late, I'm heading home for the night. I can't say I've reviewed everything I wanted to.
Up to you if you want to go ahead and review/merge this now, and I can start a new request in the morning if I find anything else, or if you want to hold off and review/merge right before retro tomorrow.
One thing I especially need you to check is whether my external link is done correctly in commit # 3.

@mthibos This looks great! :+1:
The only issue I see with the external link is that the page it opens gives a 403 error:

But that's an external issue, so I think we're good to merge.

@virginiacc
That's strange, when I go there directly it's not an error!


[DOC] Clarify Wasm, VMContext, Env. Add Rust Transaction example

Is your feature request related to a problem? Please describe.
It's difficult to understand the relationship between wasm, VMContext, and env, and it's really hard to find how to send NEAR from user to user.
Describe the solution you'd like
A specific page for Wasm, VMContext, and env and a code example for using Promise to transfer funds between two users. I could use help describing wasm and vmcontext.

Also should include documentation providing context around contract initialization, re-deploying a contract and what happens to state, and how to access blockchain storage

Also should include documentation providing context around contract initialization, re-deploying a contract and what happens to state, and how to access blockchain storage

Also some additional commentary on the idea that "All data stored on the NEAR blockchain is done in key / value pairs.". It'd be useful to describe in docs/concepts/data-storage how to initialize a Vector, UnorderedMap, etc., and what it means to pass prefix: S / IntoStorageKey

Thanks for the contribution @RNHTTR, a lot of the rust documentation is being updated/added here https://www.near-sdk.io/ which includes roughly the changes you're proposing here. https://github.com/near/sdk-docs is the repo, for reference.

Thanks for the contribution @RNHTTR, a lot of the rust documentation is being updated/added here https://www.near-sdk.io/ which includes roughly the changes you're proposing here. https://github.com/near/sdk-docs is the repo, for reference.

Aha! That looks great, and like you said, covers a lot of what I'm trying to capture. Ultimately, as I learn about NEAR & the rust sdk, I wanted to capture some of the things that I found challenging/confusing and be proactive in updating the documentation accordingly.
Not sure this PR is the best forum to continue discussion, but I've found the following difficult to follow:

What is env, what are its properties/methods, and why are these significant?

Where does env even come from? Can these be manipulated from the front-end when the contract is called?
Who exactly is env::current_account_id, env::predecessor_account_id, env::signer_account_id, and how are these set?

How can a contract let user A send NEAR to user B? This is what I was trying to capture with the send_funds method, but it looks what I was trying to convey was nicely captured in the docs you shared.
Understanding the on-chain storage components of a contract. I thought that when a contract was deployed, each time the contract was called, the new method would be called, and the properties in new would be set each time the contract was called.

On a similar note, seeing code like LookupMap::new(b"my_property".to_vec()) was really confusing to me. It'd be nice if there was some additional clarification on the key / value paradigm for on-chain storage, outlined in the overview here. Now I understand that "my_property".to_vec() sets the key for the storage object on-chain. At least I think I understand it :)

Let me know if this makes sense or not. Thanks!

Not sure this PR is the best forum to continue discussion, but I've found the following difficult to follow:
To

What is env, what are its properties/methods, and why are these significant?

Where does env even come from? Can these be manipulated from the front-end when the contract is called?
Who exactly is env::current_account_id, env::predecessor_account_id, env::signer_account_id, and how are these set?

How can a contract let user A send NEAR to user B? This is what I was trying to capture with the send_funds method, but it looks what I was trying to convey was nicely captured in the docs you shared.

Understanding the on-chain storage components of a contract. I thought that when a contract was deployed, each time the contract was called, the new method would be called, and the properties in new would be set each time the contract was called.

On a similar note, seeing code like LookupMap::new(b"my_property".to_vec()) was really confusing to me. It'd be nice if there was some additional clarification on the key / value paradigm for on-chain storage, outlined in the overview here. Now I understand that "my_property".to_vec() sets the key for the storage object on-chain. At least I think I understand it :)

Let me know if this makes sense or not. Thanks!

I think it's okay to close. In my opinion, having some of this info up front would make the learning curve a little gentler. Just food for thought :)
Thanks for the explanations!


Subdirectories for same equation, different spatial dimension

The equations directory keeps filling up, what do you think about adding directories for e.g. compressible_euler_equations which contains the implementations of the respective dimensions?

The equations directory keeps filling up

Haha, you should meet some other scientific codes (200+ files is not uncommon) 😬
But on a more serious note: Personally I think the current number of files is still acceptable (<40). IMHO, I would not add subdirectories lightly here, and there's a reason for it:
Right now, we do not consistently document all the features that Trixi.jl has (or does not have). More specifically, which system of equations for which dimensionality is available is only derived from "the corresponding file exists". Thus, the one directory approach has the advantage that it is easy for both novice and experienced users to figure out what is available.
To summarize, I think keeping the files in one folder is preferable, at least for the time being. Once we get closer to, say, 50 files, I would definitely be open to reconsider this decision. However, I am not dead-set on not adding subdirectories, thus if there is strong support from the community for more subdirectories, I wouldn't stand in the way.