Add environments and silence logging in tests

Codecov Report

Merging #41 into master will increase coverage by 3.68%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   53.73%   57.42%   +3.68%
==========================================
  Files          15       15
  Lines         562      566       +4
==========================================
+ Hits          302      325      +23
+ Misses        244      222      -22
- Partials       16       19       +3

Impacted Files
Coverage Δ

app.go
76.19% <37.5%> (+64.42%)
:arrow_up:

server.go
18.75% <0%> (+18.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da031a...4145e55. Read the comment docs.


0.11.0-beta4: Error: spawn cmake ENOENT {}

Brief Issue Summary
The tools are property detecting the presence of Visual Studio and create the entries in the cmake-kits.json file. It does not select any kit automatically, When trying to select a kit, it raises the following error:
Error: spawn cmake ENOENT {}

Expected:
It should be possible to select a kit, or at least a message should appear that gives any information regarding the nature of the problem.
Apparent Behavior:
The detection of the kits seems to work fine, but something is wrong when trying to select them. I do not know what the ENOENT means. The last message in the logs indicates that the plugin is trying to start cmake. But there is no report that this actually worked.
CMake Tools Log
The following messages appear when starting vscode:
[main] Safe constructing new CMakeTools instance
[kit] Constructing KitManager
[variant] Constructing VariantManager
[main] Constructing new CMakeTools instance
[main] Starting CMakeTools second-phase init
[rollbar] Checking Rollbar permissions
[rollbar] Rollbar enabled?  true
[variant] Loaded new set of variants
[kit] Second phase init for KitManager
[kit] Re-read kits file from prior session
[kit] Re-reading kits file C:\Users\<name>\AppData\Roaming\CMakeTools\cmake-kits.json
[kit] Loading new set of kits
[kit] Successfully loaded 3 kits
[kit] Active kit set to null
[main] Starting CMake driver

When trying to manually selecting a kit using the tool bar, the following message is added.
[rollbar] Unhandled exception: Unhandled Promise rejection: selectKit Error: spawn cmake ENOENT {}

When starting vscode without an already created kits file the following messages appear:
[main] Safe constructing new CMakeTools instance
[kit] Constructing KitManager
[variant] Constructing VariantManager
[main] Constructing new CMakeTools instance
[main] Starting CMakeTools second-phase init
[rollbar] Checking Rollbar permissions
[rollbar] Rollbar enabled?  true
[variant] Loaded new set of variants
[kit] Second phase init for KitManager
[kit] Rescanning for Kits
[kit] Scanning for Kits on system
[kit] Scanning directory ... for compilers
(shortend)
[kit] Found 0 kits in directory ...
(shortend)
[kit] Testing GCC-ish binary: C:\Strawberry\c\bin\gcc.exe
[kit] Found 0 kits in directory ...
(shortend)
[kit] Detected GCC compiler kit: C:\Strawberry\c\bin\gcc.exe
[kit] Checking for kit: Visual Studio Professional 2017 - ...
(shortend)
[kit] Checking for kit: VisualStudio.14.0 - ...
(shortend)
[kit] Found 1 kits in directory C:\Strawberry\c\bin
[proc] Executing command: C:\Users\<NAME>\AppData\Local\Temp\vs-cmt-0.5467378164347365.bat
(shortend)
[kit] Found Kit: GCC 7.1.0
[kit] Found Kit: Visual Studio Professional 2017 - x86
[kit] Found Kit: Visual Studio Professional 2017 - amd64
[kit] Saving news kits to C:\Users\<name>\AppData\Roaming\CMakeTools\cmake-kits.json
[kit] Re-reading kits file C:\Users\<name>\AppData\Roaming\CMakeTools\cmake-kits.json
[kit] Loading new set of kits
[kit] Successfully loaded 3 kits
[kit] Active kit set to null
[kit] C:\Users\<name>\AppData\Roaming\CMakeTools\cmake-kits.json saved
[main] Starting CMake driver

When trying to manually selecting a kit using the tool bar, the following message is added.
[rollbar] Unhandled exception: Unhandled Promise rejection: selectKit Error: spawn cmake ENOENT {}

Platform and Versions

Operating System: Windows 10 - Verion: 1703 - Build: 15063.786
CMake Version: Visual Studio 2017 embedded version: 3.9.2-MSVC_2 (at: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin)
VSCode Version: 1.19.1
CMake Tools Extension Version: 0.11.0-beta4
Compiler/Toolchain: Visual C++ 2017, GCC 7.1

Other Notes/Information
While it seems to detect the Visual Studio kit properly, it seems it is not using the cmake from Visual Studio as I'd expect it to do.
The error also it shown for every command I tried to execute related to the cmake extension. Even things like resetState raise this error:
[rollbar] Unhandled exception: Unhandled Promise rejection: resetState Error: spawn cmake ENOENT {}

In beta5 it will search more than just $PATH for the CMake executable. Should fix this for users who have CMake installed but not on the $PATH.


feat: add moderation

[x] Add new API endpoint /api/openai/moderation
[x] Add according settings value, so user can toggle this off
[x] Add the required check on every chat message

fixes #55

Thanks for working on this! Will process it later today. The quality of the code seems good, I may move the moderation to tRPC if possible.
When the feature is off, will it impact at all the current workflow for existing users (latency, data, ..)?

@danbalarin Merged!
Good placement of the moderation flags and checking for the user input.
I'm defaulting moderationCheck to false, so there's no additional roundtrip for current users - however, I see the benefit for sysadmins to turn it on by default in their managed installations. maybe the default should be centralized to a config file, or tied to env variables, along with other defaults.
Thanks for your contrib!


joystick events stack up?

investigate if we can make it more responsive

the jog queue is cleared on the joystick going idle (when not previously). This is analogous to how we handle keyboard events (jog clear queue on key release)


Simplify the project structure and debugging

This PR flattens the provider folder structure to improve troubleshooting DAGs created with this provider and the provider's developer experience. It contains breaking changes, which is fine since the provider has not reached a stable state yet (we're under the 1.0 release).
As part of this PR, we are changing the import paths to existing decorators, hooks, operators and trigger
changed, as documented in the table below:

Type
Previous import path
Current import path

Decorator
ray_provider.decorators.ray.ray
ray_provider.decorators.ray

Hook
ray_provider.hooks.ray.RayHook
ray_provider.hooks.RayHook

Operator
ray_provider.operators.ray.DeleteRayCluster
ray_provider.operators.DeleteRayCluster

Operator
ray_provider.operators.ray.SetupRayCluster
ray_provider.operators.SetupRayCluster

Operator
ray_provider.operators.ray.SubmitRayJob
ray_provider.operators.SubmitRayJob

Trigger
ray_provider.triggers.ray.RayJobTrigger
ray_provider.triggers.RayJobTrigger

Previously, there were four modules within the ray_provider named ray.py. Not only was the project structure more nested and complex than it had to be, making the overall project maintainability harder without a benefit, but this caused many problems when troubleshooting the actual ray provider.
The following logs illustrate the problem from a debugging perspective:

Different lines mentioning ray.py referenced different modules. It was time-consuming and frustrating for developers to troubleshoot and identify which ray.py the logs referred to: was it the hooks/ray.py, operators/ray.py, trigerrer/ray.py, or deocrators/ray.py? This sort of ambiguity significantly delayed the development of #81. We aim to reduce development time by introducing this change.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.69%. Comparing base (9ef6bc3) to head (ba4b570).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   97.69%   97.69%
=======================================
  Files           5        5
  Lines         564      564
=======================================
  Hits          551      551
  Misses         13       13

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: correct line numbers when console logging stack traces

fixes https://github.com/sveltejs/kit/issues/10138
This PR fixes the server stack trace by mutating the error object with vite.ssrFixStacktrace rather than using a Proxy. It also fixes the stack trace output by Vite in the server logs and the vite HMR overlay by passing in the option when loading SSR modules.
Thanks to @dmoebius we know that console.log, etc. bypasses proxies (for some strange reason). We can also safely use vite.ssrFixStacktrace without worrying about repeatedly fixing the same error object because it memoizes the error objects fixed. This optimisation wasn't available when vite.rewriteStacktrace was first exposed (but it has been now for some time!).
No test because I can't figure out how to capture the output of console.log and Vite's own messages.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

another PR related to fixing stack traces: https://github.com/sveltejs/kit/pull/10638


feat: add dangerjs

Add dangerjs to request 2 reviewers on contracts PRs

looks like some tests are failing, should I bypass them?


GDScript 2.0: String" and "" for "in" operator

Godot version
4.0 alpha 12
System information
KDE neon 5.25
Issue description
Autoloads don't work directly with the in operator when checking for if a variable exists.
You have to set it to a variable first...
https://cdn.discordapp.com/attachments/908062856459743262/1005618717356466287/unknown.png
https://cdn.discordapp.com/attachments/908062856459743262/1005619270690013224/unknown.png
Steps to reproduce

Have code that tried to check if something is in a Autoload like this..  if "myVaribable" + str(1) in MyAutoload):
See it doesn't work
Fix it by storing the autoload into a variable first...

var myAutoload = MyAutoload
 if "myVaribable" + str(1) in myAutoload):

Minimal reproduction project
Test.zip

Seems very similar to #51538

I cannot reproduce. There has been many changes since the report, so I'll assume it was fixed along the way.


API compatibility breaks

Renames CollectionPhase::Collecting -> CollectionPhase::Sweeping
Renames StaticCollect -> Static

The next version of gc-arena will be a 0.x version bump because the way DynamicRootSet works has changed.
Let's think about some minor API breaks we want to make before the next release!
The big other one I can think of is not re-exporting so much in the crate root.
@moulins thoughts?

I would consider axing the unsafe_empty_collect! macro; it's not used anywhere inside the crate, and I struggle to find a situation when it would be the correct thing to use over static_collect!.
In regard to reducing root-level exports, maybe this should be paired with a dedicated gc_arena::prelude that can be glob-imported. I'm not entirely sure what items should be in this prelude, though.
Finally, the Collect trait as it currently exists precludes future optimizations:

Collect::needs_trace is a method, which means we can't use the information statically;
Collect::trace takes a &Collection, which means we need to lock/unlock a RefCell every time we want to push a GcBox onto the gray queues.

I propose the following API:
#[derive(Copy, Clone)]
pub struct CollectFlags {
  needs_trace: bool,
  // could add other flags here, e.g. needs_drop?
};

impl CollectFlags {
  pub const DEFAULT: Self = CollectFlags { needs_trace: true };
  pub const EMPTY: Self = CollectFlags { needs_trace: false };

  // used by the `Collect` derive-macro to combine field flags
  pub const fn combine(flags: &[Self]) -> Self { ... }
}

pub struct Collection<'a> {
  // could become `&'a mut Context` without breaking the `Collect::trace` signature
  cx: &'a Context,
  // not really necessary, but possibly useful in the future?
  _inv: Invariant<'a>,
}

impl Collection<'_> {
  pub fn trace<T: Collect + ?Sized>(v: &T) { ... }

  // equivalent to `Self::trace(&gc)`, but avoids the `Deref` footgun
  pub fn trace_gc<T: ?Sized>(gc: Gc<'_, T>) { ... }
}

pub trait Collect {
  const FLAGS: CollectFlags;

  fn trace(&self, cc: Collection<'_>);
}

It does make Collect not object-safe, but I don't believe dyn Collect is ever useful, so I'm quite OK with that.

Yeah these are great suggestions. Full agreement about unsafe_empty_collect.
I think making the Collection object able to hold a &mut Context is also really good, but I think I'd like to go ahead and make that change at the same time as changing the API, which I think I can do in a separate PR soon.
As far as re-exporting less in the crate root, I don't know what would go in such a prelude module but it's probably not the current set. The issue I have with the current set of exports is that it's just kind of random, you almost always need a Lock or RefLock, and you almost never need rootless_arena, but the first two are not in the crate root and the second one is for some reason.
Mostly I just want this to change. We don't export that many things total, so my instinct is to put whatever would go in the prelude in the crate root, but change what's there now to make better sense, but honestly I'm fine with anything. Personally I actually don't ever use glob imports, so I'd ignore the existence of a prelude and just import everything manually.

I made an attempt at a slightly better crate organization in 8b57ff3493ba6eb39f12ce92ecdff8c5d7a871ad.
I didn't make a prelude module or make any drastic changes at all really, just cleaned up the crate root slightly. I'm obviously biased, but I left everything in the crate root that's something that I personally reach for all the time and nothing else. Well, that's not entirely true because I also use the Root typedef a lot but I think everywhere you need that you're doing something pretty specialized.


How to export a proper NFO

Hello there,
I have built a custom Confignon to export informations about my movie but here is my problem:

The export is contains ASCII characters I need
The export is done in .txt

When I rename the file in .nfo, all ASCII are broken. I have to manually Save As MSDOS Info file / .nfo and then open it and paste my ASCII inside to finally save and have a proper NFO.
Is there any way to do that automatically?
Thanks a lot for your help and contribution. Great app!

On Windows, I personally use (command line) mediainfo --LogFile=MyLogFile.txt MyFile.ext in order to store in UTF-8, which is the best locale IMO for transferring documents.
I can not talk about "NFO" as I have no idea about what (which locale) you/they expect. you say "proper NFO", please provide a link to the specification of this "format" so I can understand what "proper NFO" technically means.

Thanks for your feedback, I will give it a try.
The problem is that windows seems to change the encoding when renaming the .txt to .nfo and the GUI don’t care about the extension I put.
Can I add on top of that the —output option to choose a custom csv template?

I have made some tests and here is the situation now.
On Windows, I cant correctly generate the output with my custom template in CLI with
"!mediainfo_path!" "--output=file://!output_extension!" "%%i" > !shortpath!.txt
but as soon as I change that to .nfo, the file is not saved anymore in UTF-8 but in OEM-US and all my ASCII are broken.
So now, I'm trying to do the same on Linux with the CLI command:
./mediainfo --Output="/volume1/template.csv" --LogFile="/volume1/output.nfo" "/volume1/file.mkv"
but I only get a simple output file, my template is not used.
Can you please help on that?
Thanks

The problem is that windows seems to change the encoding when renaming the .txt to .nfo

File renaming is just file renaming, maybe your tool (not one from Windows by default, .nfo is by default associated to "System Information" program) does not like UTF-8?

the file is not saved anymore in UTF-8 but in OEM-US

Please provide this file in OEM-US, so I can check it. Because I don't see how it could be OEM-US.

but I only get a simple output file, my template is not used.

You forgot "file://" in your command.

You forgot "file://" in your command.
Doesn’t seem to work with that on Linux. Please advice!
Thanks!

It was a typo error. My bad.
So I got it properly displayed in the console and in the .txt file here: https://send.firefox.com/share/b0e1d9a084
But if I save the file as .nfo, here is the result: https://send.firefox.com/share/be9c7f3b37

wrong links.

Edited.

As expected both files are same (same file hash and so on). They are both in UTF-8. None is in OEM-US.
.nfo is not supported by default by Windows, so I tested with notepad++, .txt is open automatically in UTF-8, I had to configure manually for .nfo (open by default in local code page) for UTF-8 (I change nothing in the file, I just say to notepad++ that the file is encoded in UTF-8) and it is fine.
Summary: renaming does not change the encoding of the file but may change the behavior of your reading tool. Not a MediaInfo issue.

I fixed my problem by adding the BOM manually with sed at the beginning of the file.
It seems that --BOM is not doing the job 🥇


fix SelectGroupContext - provide default value

fixes the comment of #519

Can we add a changeset? @jaf107

I guess since this is a follow up to a feature there’s no need for a changeset - the original should cover everything as we’ve not done a release yet


[PE-D] Editappt Bugs

Similar to previous issue, editappt has a bug in terms of storing the contacts. First screenshot is before listpersons which show the main contacts list. Second is after the command listpersons

Labels: severity.High type.FunctionalityBug
original: KristopherPTaslim/ped#6

Not a bug
This is intended behaviour for better UX. Indexes used at a point are referenced to what is currently being shown, not to the main list.


Add flag to compile gpr with compatibility for musl

This adds the compile time flag GPR_MUSL_LIBC_COMPAT to compile GPR in a way that is compatible with musl libc. This is set in the platform detection code in port_platform.h, but it can also be set explicitly. This also changes the Node artifact build to set that flag explicitly so that the Node artifacts will be compatible with Alpine Linux.
Unfortunately, this change mostly only benefits Node. There are other libc differences that affect how the TCP code is compiled, and those are mutually incompatible, but Node avoids that problem because it uses different TCP code.
Note: The check in wrap_memcpy.c is now effectively checking __GLIBC__ instead of __GNU_LIBRARY__. It looks like __GNU_LIBRARY__ is from older versions of glibc, so __GLIBC__ is probably what we want to be checking there anyway.

Performance differences noted:
Benchmark                                                         cpu_time    real_time
--------------------------------------------------------------  ----------  -----------
BM_ClosureSched2OnExecCtx                                            +8.00        +8.00
BM_ErrorGetStatusCode<ErrorWithHttpError>                           +10.50       +10.50
BM_ErrorHttpError<ErrorWithNestedGrpcStatus>                         +5.50        +5.50
BM_HpackEncoderEncodeHeader<SingleInternedElem>/0/16k                -9.00        -9.00
BM_HpackParserParseHeader<NonIndexedBinaryElem<10, true>>           +29.00       +29.00
BM_HpackParserParseHeader<RepresentativeClientInitialMetadata>      +25.00       +25.00
BM_MetadataFromInternedKey                                           +7.00        +7.00
BM_MetadataFromInternedSlicesAlreadyInIndex                         +10.00       +10.00
BM_MetadataFromStaticMetadataStringsNotIndexed                      -15.50       -15.50
BM_PollEmptyPollset_SpeedOfLight/1/0                                 +9.00        +9.00
BM_PollEmptyPollset_SpeedOfLight/1/97.6562k                          +9.00        +9.00
BM_TransportStreamSend/128M                                     +162373.00   +162396.50
BM_TransportStreamSend/16M                                       +22009.00    +22007.00
BM_Zalloc/4k                                                        +21.50       +21.50

The Mac failure is #10202. The Windows failure is #9620. The interop failures are #10576.


Few new misclassified instances

via Aevala

Relevant : https://discord.com/channels/1009139814836207656/1009139816841089026/1024319864682328196
Let's make sure we have these included:

AK, ANK, AHK, OK (Ahn'kanet The Old Kingdom)
DK, DTK (Drak'Tharon Keep)
GD, GDK (Gundrak)
Nex, Nexus (Nexus)
OC, Oculus (Oculus)


Guardian Oracle service to verify token trust chain from within Hedera smart contracts

Problem description
For many if not all operations with ESG assets there is frequently an question of trust - assets validity needs to be determined before the operation/transaction can take place. In Guardian ecosystem such operations (on tokens) are performed on-chain (#1659), mostly via smart contracts, and the 'validity' of ESG assets can only be determined by OK-ing their trust chain. This translates into the requirement for enabling smart contracts to somehow be able to verify trust chains.
Requirements
Develop a Guardian 'Oracle' service to produce (at least) a verifiable binary valid/not valid answer for a given token or group of tokens reachable from within the smart contract, which can then form the basis conditional operation inside the smart contract.
Definition of done
There is a supportable way to assess the validity of tokens trustchain from within smart contract on-chain.
Acceptance criteria
Guardian instance can be configured to be a Hedera Oracle.

Can you please provide a concrete example of a kind of check you would like to do on a trust chain?

concrete example

@AlexIvanHoward This ticket is for creating 'rails' which would enable any additional information about the token, its trust chain and the data in it (in the various documents that compose the trust chain) - 'the metadata' -  to be become available for automatic decision making (by code) in smart contracts. To answer your question specifically, one example could be geographic location of the project which produced the carbon offset - which may be relevant for purchasing decisions.


Revert "Propuesta modelo inicial"

Reverts tomasayala/algo3_tp2_1C2022#1

Codecov Report

Merging #2 (0cfdec4) into master (117d7f6) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master        #2   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity         5         5
===========================================
  Files              2         2
  Lines             10        10
===========================================
  Hits              10        10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117d7f6...0cfdec4. Read the comment docs.


Slot queue

Closes #429.
Implementation of a slot queue for the sales module as described in the slot queue design document
In order to support contract event subscriptions in the slot queue, events in the Sales and SalesAgent modules were overhauled. Contract events are now subscribed to in the Sales module, with each event calling SalesAgent callbacks. This prevents each SalesAgent from creating their own event subscriptions which, in a busy host, could have quickly lead to the blockchain provider hitting its cap of event emitters, as well as a higher memory footprint.
~Relies on https://github.com/codex-storage/codex-contracts-eth/pull/61~ (merged and submodule commit updated)

In the current form, I see a potential issue, where availability can be free when passed into SlotQueue, but then the situation can change as another slot might take priority and eliminate the availability which was originally "assigned" to the original slot.

Hopefully, https://github.com/codex-storage/nim-codex/pull/455#discussion_r1244533563 cleared this up, showing that there is indeed a second availability check at the start of the processing of the slot.

IMHO it is very tightly coupled to the decision-making "if slot should be picked up or not" which I thought should be the sole domain of the SlotQueue, so I am wondering if this logic should not be moved to SlotQueue?

I definitely agree with this, however let's first agree on the design as to whether or not we should be filtering out requests/slots on push.

Is my understanding here correct? If so, then IMHO it is not really addressing the problem no?

Your understanding is correct. I believe it is addressing the problem of filtering and sorting slots that it is interested in, based on its availabilities and other factors like profitability. However, I do agree that it has the downside that it may receive requests that it cannot process at the time, but could potentially process in the future if the host adds additional availabilities. My line of thinking in this case was that if there are un-filled requests available in the network, then by the time the host adds additional availabilities, these requests would likely have been picked up by other hosts, assuming they have made their offer attractive.

Another solution could be to add Slots to the Queue even if there is no availabilities. As it has cap on max. items in the queue and the least interesting slots will be removed. And once there would be available availability (there would have to be some signal coming into the SlotQueue for that), then it would start processing, until the availability is used up.

I like this suggestion, however once a new availabilities signal comes in to the slot queue, assuming there are no matching availabilities to the slots in the queue, what happens to the slots in the queue? Do they remain for some period of time (like a ttl, similar to your previous suggestion)?
Another potential solution could be that once a host adds a new availability, it could query the contract for the last x requests that are not yet filled or expired, and then add any that match the new availability to the queue. Thoughts?

Hopefully, https://github.com/codex-storage/nim-codex/pull/455#discussion_r1244533563 cleared this up, showing that there is indeed a second availability check at the start of the processing of the slot.

Yup, makes sense 👍 Although the two checks somewhat does not seem like "clean" solution... But let see about what do we agree on.

Your understanding is correct. I believe it is addressing the problem of filtering and sorting slots that it is interested in, based on its availabilities and other factors like profitability.

Well, I don't think that in the current implementation, it actually addresses it. IMO it just picks the first slot(s) that are requested since the availability is made available (what a word twist 🤪🙈).

I like this suggestion, however once a new availabilities signal comes in to the slot queue, assuming there are no matching availabilities to the slots in the queue, what happens to the slots in the queue? Do they remain for some period of time (like a ttl, similar to your previous suggestion)?

From my point of view, there should be a subscription to SlotFilled event and once it is detected then the slot should be removed from the queue, unless it has been already evicted because of the Queue size limit.

Another potential solution could be that once a host adds a new availability, it could query the contract for the last x requests that are not yet filled or expired, and then add any that match the new availability to the queue. Thoughts?

Hmmm this would be actually a more simple solution and potentially a good one as well. In this case we would not even have to have the async slot queue 😅

Well, I don't think that in the current implementation, it actually addresses it. IMO it just picks the first slot(s) that are requested since the availability is made available (what a word twist 🤪🙈).

I believe there are two different problems: matching new requests AFTER availabilities were added to a host (the PR in its current form) and matching existing requests that were created BEFORE availabilities were added to a host (the point you've mentioned). Both of these are valid. I had opted to solve only the former (the AFTER problem) in this PR, however the more we discuss, the more it becomes clear that we likely need to solve the BEFORE problem as well.

From my point of view, there should be a subscription to SlotFilled event and once it is detected then the slot should be removed from the queue, unless it has been already evicted because of the Queue size limit.

This has been added already, specifically line 228 removes the slot from the queue once filled: https://github.com/codex-storage/nim-codex/blob/8afef3324dda1bb9cd754c741d6ff0f70e00a9ef/codex/sales.nim#L222-L241

Hmmm this would be actually a more simple solution and potentially a good one as well. In this case we would not even have to have the async slot queue 😅

Yes, I believe it would solve the BEFORE problem^^, but not the AFTER problem, so we'd still need the queue for the BEFORE problem. The reason being is that this querying of the contract would be triggered only once availabilities are added to the host. However, it would be much less efficient to query the contract for the last x non-filled requests every time a new StorageRequested event is emitted, and instead more efficient to use a queue to manage those requests as they come in.
Once new availability is added and available requests are queried, we could put the requests in the queue, which should sort and process the requests automatically. This could be the new work in this PR to handle the BEFORE problem.


retrieveParametersFromServer Paramter

The retrieveParametersFromServer parameter was added for ADFS compatibility in #37. It looks like that setting conforms better to the document referenced in https://github.com/onelogin/php-saml/pull/37/commits/ce3bf78afb9ffa5733c2263a5c1831413d7dd521.
At this point, is there any reason not to leave retrieveParametersFromServer TRUE for all setups, including non-ADFS ones?

Some php-saml running under Nginx can experience issues with QUERY_STRING

Interesting - we're currently using nginx. Can you provide more details on what issues we might experience?
Our initial tests on nginx/php-fpm show that leaving the parameter to TRUE works for logout requests from both ADFS and SimpleSamlPHP.

I don't remember who reported that. I will review Issues/mails.

For the record, I have been bitten by this while using BIG-IP APM's SAML2 module. Because SAML2 LogoutRequests and LogoutResponses were URL-encoded with lower-case hexadecimal numbers, the signature validation kept failing. Problem was solved by setting retrieveParametersFromServer to TRUE.
I don't get why this is not the default. If parameters are URL-encoded with lowercases, this is very very unlikely that the signature would have been computed with the uppercase version.


Create channel picker for draft order creation

To create a draft order we need to know its channel beforehand. This picker allows user to specify the channel explicitly while also defaulting to the currently selected global channel.

https://app.clickup.com/t/2549495/SALEOR-1611
PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Translated strings are extracted.
[ ] Number of API calls is optimized.
[ ] The changes are tested.
[ ] Data-test are added for new elements.
[ ] Type definitions are up to date.
[ ] Changes are mentioned in the changelog.

Test environment config

API_URI=https://master.staging.saleor.rocks/graphql/

Task linked: SALEOR-1611 Channel chooser when draft order create


gaussian scale coordinate

Thanks so much for the fantastic work!! @dcharatan
Could you please elaborate more on the note here when constructing Gaussians?
        return Gaussians(
            means=means,
            covariances=covariances,
            harmonics=rotate_sh(sh, c2w_rotations[..., None, :, :]),
            opacities=opacities,
            # Note: These aren't yet rotated into world space, but they're only used for
            # exporting Gaussians to ply files. This needs to be fixed...
            scales=scales,
            rotations=rotations.broadcast_to((*scales.shape[:-1], 4)),
        )

Looking forward to your reply!

I posted a few comments about this in issue #9. Take a look there and feel free to post a follow-up if you still have questions!

Another thing I just noticed: that comment refers to the rotations, not the scales, so it should be one line lower! Sorry if that's what was confusing! The scales themselves don't have to be rotated.


CI: Replace Cirrus CI with paid AWS CodeBuild for Linux arm64 testing

For running tests on a real Linux arm64 machine, we were using a free plan from Cirrus CI. It worked fine except slow builds. It usually took ~25 minutes to complete one CI job.
This PR replaces Cirrus CI with a GH self-hosted runner at AWS CodeBuild. It is a paid plan but the build time is reduced to ~10 minutes when AWS Graviton (4 vCPUs) with 8GB memory is used. Hopefully it will not cost too much.

List of duration to run a CI job on Rust stable:

Runner
Instance Type
OS
Arch
vCPUs
RAM
Duration

GitHub-hosted (Azure)
ubuntu-latest
Linux
x86_64
4
16GB
7m 34s

AWS CodeBuild
arm-3.0-medium
Linux
AArch64
4
8GB
8m 41s

AWS CodeBuild
arm-3.0-small
Linux
AArch64
2
4GB
16m 3s

GitHub Actions / Standard GitHub-hosted runners for public repositories
AWS CodeBuild / Self-hosted GitHub Actions runners in AWS CodeBuild
AWS CodeBuild / Build environment compute modes and types


Language settings

Description of the new feature / enhancement
To change Language consistent to Windows language
Scenario when this would be used?
My Windows in Hebrew that is right to left oriented and the English language in PowerToys  is messed up right to left with English
Supporting information
No response

Also sounds like #27724

Screenshot would be nice 🙂

Other question: can you tell/show what the OS & app language settings are in Windows Settings? People often confuse regional settings with language.

/dup /dup https://github.com/microsoft/PowerToys/issues/7670


Authentication token with ng-admin

I have Rest API server with token-based authentication. After Client login successfully , server response token to client, client send data with this token to get resource from server. How can I insert this token in URL from ng-admin?

http://ng-admin-book.marmelab.com/doc/FAQ.html

Thanks, @Phocea.


Build broken on Rails 7.1.1 due to Rails bug

I believe that Rails 7.1.1 is broken on postgres < 10, probably effecting all Rails installations even without this gem.
https://github.com/rails/rails/issues/49591
https://github.com/rails/rails/pull/49504
So build will be broken on 7.1.1 until 7.1.2 is released, I guess? Hopefully soon?
Github Actions is currently running pg 9.4
  1) AttrJson::NestedAttributes should allow class to override and call super
     Failure/Error: instance = overridden_class.new

     ActiveRecord::StatementInvalid:
       PG::UndefinedColumn: ERROR:  column a.attidentity does not exist
       LINE 4:        a.attidentity AS identity,

The term attidentity does not appear in source for attr_json.  I don't believe this has anything to do with us.

Interestingly, postgres 11 seems to be the minimum version actually still supported by pg? https://endoflife.date/postgresql
Except Github Actions (tagged to ubuntu-latest) is still running pg 9.4 by default!
I think that should be Ubuntu 22.04. Does Ubuntu22.04 still run pg 9?  Perhaps a patched version with security backports etc?
I guess I could look into getting Github Actions to install pg 11 on my builds….  if Rails doesn’t release a fix soon?
Rails docs officially say pg 9.3+ is supported, so I think Rails is treating this like a bug.

Wait a second, no -- we are specifically asking for postgres 9.4!
https://github.com/jrochkind/attr_json/blob/004480c2a8d41b181a15c7c8baf08f588fa85d17/.github/workflows/ci.yml#L21
Perhaps we wanted to support all the way back to that at minimum?
We'll wait a bit to see if Rails patches so we can leave that alone, otherwise bump the version we test with to 10? (Also out of pg support, but I believe in supporting old dependencies when we can, I know some people are stuck with them!)


count(*) in final aggregation fails due to argument type number registered as 0

Bug description
I changed a test case from velox/exec/tests/AggregationTest.cpp as POC, and I cannot run final aggregation with count(*).
The failure happens at aggregation phase on this line as intermediate aggregates require at least one argument: https://github.com/facebookincubator/velox/blob/main/velox/exec/HashAggregation.cpp#L102.
This will work if I swap count(*) with count(1) as the duckdb parser treats count(*) differently from count(1).
Error is pasted in the "Relevant Logs" section.
Sample code (Ignore the assert part):
core::PlanNodeId aggNodeId;
auto task = AssertQueryBuilder(duckDbQueryRunner_)
                .config(QueryConfig::kMaxPartialAggregationMemory, "100")
                .plan(PlanBuilder()
                          .values(vectors)
                          .partialAggregation({"c0"}, {})
                          .capturePlanNodeId(aggNodeId)
                          .finalAggregation({}, {"count(*)"}, {BIGINT()})
                          .planNode())
                .assertResults("SELECT distinct c0 FROM tmp");

System information
Velox System Info v0.0.2
Commit: 01b164c8c227c0d0a88fc3e05987da48d69cfb22
CMake Version: 3.26.0
System: Darwin-22.3.0
Arch: x86_64
C++ Compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
C++ Compiler Version: <IP_ADDRESS>60021
C Compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
C Compiler Version: <IP_ADDRESS>60021
CMake Prefix Path: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.3.sdk/usr;/usr/local;/usr;/;/usr/local/Cellar/cmake/3.26.0;/usr/local;/usr/X11R6;/usr/pkg;/opt;/sw;/opt/local
Relevant logs
C++ exception with description "Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Retriable: False
Expression: !argTypes.empty()
Function: HashAggregation
File: /Users/admin/Desktop/QueryEngine/es/velox/velox/exec/HashAggregation.cpp
Line: 112
Stack trace:
# 0
# 1
# 2
# 3
# 4
# 5
# 6
# 7
# 8
# 9
# 10
# 11
# 12
# 13
# 14
# 15
# 16
# 17
# 18
# 19
# 20
# 21
# 22
# 23
# 24
# 25
# 26
# 27
# 28
# 29
# 30
" thrown in the test body.

Process finished with exit code 1

@sungho-park-23 This query doesn't look right. Try changing it to
core::PlanNodeId aggNodeId;
auto task = AssertQueryBuilder(duckDbQueryRunner_)
                .config(QueryConfig::kMaxPartialAggregationMemory, "100")
                .plan(PlanBuilder()
                          .values(vectors)
                          .partialAggregation({"c0"}, {"count(*)"})
                          .capturePlanNodeId(aggNodeId)
                          .finalAggregation()
                          .planNode())
                .assertResults("SELECT c0, count(1) FROM tmp GROUP BY 1");

@mbasmanova I don't know if this is supported (at least from PlanBuilder.cpp it doesn't seem supported), but I actually wish to do partial aggregation separately and then get that intermediate output, and then at a later time use that intermediate output for final aggregation. Is this impossible to do? Or is there a different way I could think about doing this?

Also, in this case, is there a reason the count(1) would work but not the count(*)?
core::PlanNodeId aggNodeId;
auto task = AssertQueryBuilder(duckDbQueryRunner_)
                .config(QueryConfig::kMaxPartialAggregationMemory, "100")
                .plan(PlanBuilder()
                          .values(vectors)
                          .partialAggregation({"c0"}, {})
                          .capturePlanNodeId(aggNodeId)
                          .finalAggregation({}, {"count(1)"}, {BIGINT()})
                          .planNode())
                .assertResults("SELECT distinct c0 FROM tmp");

I actually wish to do partial aggregation separately and then get that intermediate output, and then at a later time use that intermediate output for final aggregation.

This is supported. First, create a query plan that end in partial aggregation. Than create a new plan that starts with final aggregation.

Would this look something like this?

Run this partial aggregation first

PlanBuilder()
        .values(vectors)
        .partialAggregation({"c0"}, {"count(*)"})

Run final aggregation with results from #1 as:

PlanBuilder()
        .values(resultsFromNum1)
        .finalAggregation({"c0"}, {"count(*)"}, {BIGINT()})

For example, if I run just #2, I get this issue with count(*) but not with count(1).

@sungho-park-23
Here is what this should look like:
TEST_F(CountAggregationTest, xxx) {
  auto data = makeRowVector({
      makeFlatVector<int64_t>({1, 2, 3, 1, 2, 2, 3}),
  });

  auto partialAgg = PlanBuilder()
                  .values({data})
                  .partialAggregation({"c0"}, {"count(1)"})
                  .planNode();

  auto partialResults = AssertQueryBuilder(partialAgg).copyResults(pool());
  LOG(ERROR) << partialResults->toString();
  LOG(ERROR) << partialResults->toString(0, 10);

  auto finalAgg = PlanBuilder()
                   .values({partialResults})
                   .finalAggregation({"c0"}, {"count(a0)"}, {BIGINT()})
                   .planNode();

  LOG(ERROR) << finalAgg->toString(true, true);

  auto finalResults = AssertQueryBuilder(finalAgg).copyResults(pool());
  LOG(ERROR) << finalResults->toString(0, 10);
}

Note that final aggregation takes grouping keys (in this case it is a single column c0), aggregate expressions (this case a single expression count(a0)) and result types.

.finalAggregation({"c0"}, {"count(a0)"}, {BIGINT()})

Neither count(1) nor count(*) are valid aggregate expressions for final aggregation. Final aggregation needs to apply "count" function to intermediate results, e.g. column a0. count(a0) does that.
Note that PlanBuilder is a test-only utility that should be used only for testing. It is not suitable for use in production code.
I'm curious, what's the context in which you have ran into this issue.

I see, thank you for the deep explanation!
My understanding on the aggregate expressions on final aggregation was lacking, and you helped answer those uncertainties here. It makes sense that "count" should apply onto the intermediate result rather than * or 1. Thanks a lot!
I work at ByteDance/TikTok under Frank, and we are trying to support some elastic search queries where we craft and define the query plan and run it for them through Velox. But since we are doing the crafting (instead of PlanBuilder as you mentioned it is only for testing), there are these edge cases that I was unsure on what the exact behavior should be. I do follow the PlanBuilder logic mostly in crafting these plans though. In this case here, the user wants to run partial aggregation separately and then combine multiple intermediate results in one final stage so that possibly partial aggregation can happen in different nodes especially with a setup where the data is spread out across multiple physical machines.

@sungho-park-23 Happy to hear the issue is resolved now and appreciate very much you sharing the context behind this issue. All makes sense to me.


How to double check that 2nd order grads are being used

I want to make sure that MAML is indeed using 2nd order info in the updates. I already did the obvious: track_higher_grads =   True but can I somehow do opt.hessian.sum() and print the values to see them?

I'm not sure I understand the question...


Added option to change the SSL KeyManagerFactoryAlgorithm using Configuration.

The SSLContext setup retrieved most of its parameters from Configuration, except the algorithm for KeyManagerFactory, for which it used only the default one.
I have added this setting to the Configuration file and updated the SSLContext building accordingly.
Also fixed some javadoc @param inconsistencies.

Thanks!


CA integration through Envoy SDS

Please provide a description of this PR:
This PR includes the following changes:

Make istio-agent check the presence of a Unix Domain Socket on the fixed path /var/run/secrets/workload-identity/socket:
    1. In the case where the socket exists, istio-agent does not start its own SDS Server.
    2. In the case where the socket does not exist, istio-agent checks whether certificate files on the fixed path folder (/var/run/secrets/workload-identity) exists.  If the certificate files exist, istio-agent starts its own SDS Server, listening on the fixed socket path (/var/run/secrets/workload-identity/socket); to serve those certificate files, keeping file  watchers on them. Envoy proxy connects to the SDS Server run by istio-agent through the fixed socket path and gets the cryptographic materials of the certificate files served by the SDS API.
    3. In case istio-agent does not find either the socket, or the certificate files in the fixed path;  it starts its own SDS Server using a `caClient` to connect to istiod to get the cryptographic materials (See CA Flow).

Added new tests for istio-agent covering the scenarios where the socket is detected and where the certificates are detected.

Added a volume and volumeMount for the fixed path to the chart manifests.

Updated all the affected testdata files.

Update agent README with the details of the new CA integration approach.

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Thanks for all the comments, I'm closing this PR and I'm sending a new one including several changes that were suggested in the proposal document.


Cannot install because of missing file on GitHub

Hi,
I tried to install IHaskell, but got stuck at the stack command. If I type it in as described, I get an 404 error from GitHub:
$ stack install --fast --extra-include-dirs ${HOMEBREW_PREFIX}/include --extra-lib-dirs ${HOMEBREW_PREFIX}/lib

Downloading lts-20.13 build plan ...
RedownloadInvalidResponse Request {
  host                 = "raw.githubusercontent.com"
  port                 = 443
  secure               = True
  requestHeaders       = []
  path                 = "/fpco/lts-haskell/master//lts-20.13.yaml"
  queryString          = ""
  method               = "GET"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
}
 "~/.stack/build-plan/lts-20.13.yaml" (Response {responseStatus = Status {statusCode = 404, statusMessage = "Not Found"}, responseVersion = HTTP/1.1, responseHeaders = [("Connection","keep-alive"),("Content-Length","14"),("Content-Security-Policy","default-src 'none'; style-src 'unsafe-inline'; sandbox"),("Strict-Transport-Security","max-age=31536000"),("X-Content-Type-Options","nosniff"),("X-Frame-Options","deny"),("X-XSS-Protection","1; mode=block"),("Content-Type","text/plain; charset=utf-8"),("X-GitHub-Request-Id","[...]"),("Accept-Ranges","bytes"),("Date","Thu, 25 May 2023 06:48:15 GMT"),("Via","1.1 varnish"),("X-Served-By","cache-fra-eddf8230022-FRA"),("X-Cache","MISS"),("X-Cache-Hits","0"),("X-Timer","S1684997295.255043,VS0,VE232"),("Vary","Authorization,Accept-Encoding,Origin"),("Access-Control-Allow-Origin","*"),("X-Fastly-Request-ID","[...]"),("Expires","Thu, 25 May 2023 06:53:15 GMT"),("Source-Age","0")], responseBody = (), responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose})

What should I do now?
Thanks

This seems like a transient Stack error, what happens if you try again?

It responses with the same error again.

Actually, it looks like that file isn't available at https://github.com/commercialhaskell/lts-haskell, which to me suggests your version of Stack might be too old. What is the output of stack --version?

My stack versions seems to be 1.9.1
$ stack --version

Version 1.9.1, Git revision f9d0042c141660e1d38f797e1d426be4a99b2a3c (6168 commits) x86_64 hpack-0.31.0

That version is from 2018 and is over 4 years old. Please try using v2.11.1.

Ok, now it works. Thank you very much.


Add the ability to manually set the stickyContainer ViewGroup

Here's the PR, as requested in #179

Can you please commit in rc1 branch?
(delete this request)
Thanks.


Merging with main with newly created AuthorRepository +  a big code CleanUp

Split CheepRepository in two. There is now a CheepRepository and an AuthorRepository. There has been a general clean-up in most classes

This looks good. Great with cleanup and refactoring. We just need to look at those warnings.


Add debug log messages when the engine's run mode is exposed to the embedding

Add debug log messages when the engine's run mode is exposed to the embedding.
This ticket number will be referenced in TODO comments where such logs are desired.

This is available in the BuildConfig class now.  Can we close this?

(Closing this since I'm pretty sure it's fixed, feel free to reopen if it's for something else)

I believe this was about log statements in general, and the debug build config has not been integrated with those yet. They're all still Log.d(TAG, ....). So I'm gonna re-open this.

Ahh gotcha.  Sorry for the confusion.

I think the goal of this issue has been reasonably resolved with the Flutter Log proxy that was added recently. Closing.


Enable r.sessionWatcher by default

What problem did you solve?
Since a file-based session watcher was introduced in #150 one and a half years ago, a lot of features has been implemented around it, and they work well in a wide range of scenarios. This PR changes the status of the session watcher from experimental to normal by enabling r.sessionWatcher by default in the setting as I suggested at https://github.com/Ikuyadeu/vscode-R/issues/668#issuecomment-860214074.
(If you do not have screenshot) How can I check this pull request?
The setting of r.sessionWatcher is enabled by default.

Not sure if this fits the scope of the PR, but should we also also pass r.previewDataframe and r.previewEnvironment command s to session watcher by default?

Not sure if this fits the scope of the PR, but should we also also pass r.previewDataframe and r.previewEnvironment commands to session watcher by default?

Yes, I think this PR should address these commands that are introduced before sesssion watcher. It might make sense to check on r.sessionWatcher and if it is enabled, then r.previewDataframe just sends View(X) and r.previewEnvironment sends View(globalenv()) to terminal or otherwise keep the old behavior.

previewEnvironment and previewDataframe are updated so that if session watcher is enabled, then View(globalenv()) and View(symbol) are sent to terminal, respectively; otherwise, fallback to the old behavior.


Move Git integration tests to the test/integration pkg

We introduced the IntegrationTest target in #31 which is supposed to be used for running the integration tests. The Test target is supposed to be used for running the unit tests.
Therefore, this PR moves the Git integration from Test to IntegrationTest (and pkg/integration).
/assign @puerco @saschagrunert @cpanato
cc @kubernetes-sigs/release-engineering

/test pull-release-sdk-integration-test

Nice one
/lgtm


Eliminate Hidden And NonEmpty Values

Add class 'ignore' for hidden input in form
Add class 'ignore' for elements in form whose value is not null

Ignore class are added only for the forms which is inside div with class '.form' and if any input fields has a predefined value ignore class is added to it so that progress bar will move properly


Announce that I published extension of Swipeout for Android native behavior.

Hi guys, you might have noticed that 'Swipe action' is iOS thing.
It's not compatible on Android since it has scrollable tab navigation.
If you look facebook for any major app, you will notice they have 'long press action' for cell item.
So, I published extension of Swipeout for Android.
If you use this, iOS will work as before and you will see an 'action sheet' on Android instead swipe action.
None of your code need to change except replacing  to
https://www.npmjs.com/package/react-native-swipeout-longpressforandroid
Honestly, I'm very new to React Native and Javascript but have many experience for Xamarin.Forms. So I need your help and contribution. Thanks.
Also thanks for the awesome library, Swipeout and Action sheet.

Thanks for this @benevbright. I will keep an eye on that Component of yours and might use it in the future.


Message text not visible when device language set to Hebrew

Describe the bug
When the device language is set to Hebrew (maybe also others?), messages do not appear to have a content within a conversation.
To Reproduce

Set device language to Hebrew
Open a conversation inside Rocket.Chat

Expected behavior
Text/message should be visible
Screenshots

Devices and Versions
Your Rocket.Chat.Android version: 3.2.0
Your Rocket.Chat Server version: Cloud
Additional context
Also confirmed by @Sing-Li - thanks for testing!

The issue seems to have been fixed in version 3.4.0.


User is interested in finding all studies for a specific language based on a free text search, for instance “réseaux sociaux“

As a user I am interested in finding all studies for a specific language based on a free text search

I use the language selection functionality next to the search box:

In the search box I input my specific search term:

I am expecting information on amount of results for the specified language and search term:

I want to use the navigator to look through the pages

I also want to edit the amount of results shown in a page

I have created selenium tests that make sure the navigator and results per page selections work as expected in one case. I have not repeated the same tests (change page and number of results) for each of these cases similar as there are in these user stories.
In this user story the search terms only return 14 results (picture in step 3), so the user cannot navigate to a second page, unless he/she first changes the results per page to 10.


Xdebug not enabled?

var_dump( 'hello world' ); outputs normally (not Xdebug style) and I see no mention of Xdebug in phpinfo() except for the docker-php-ext-xdebug.ini file that's being loaded.
I thought it was enabled by default? If not, how do I enable it. That .ini file looks like it's supposed to be loading the extension.

Oh, I happened to notice that the VM had a newer version. I had to update docker-php-ext-xdebug.ini to no-debug-non-zts-20160303 and that fixed it.


⚠ ClamAV has degraded performance

In 66ee8c6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 571 ms

Resolved: ClamAV performance has improved in 41f0a80.


White / Blank screen displayed on launch in release mode.

Hello guys!
I am having this issue.
Description
Blank / White screen is randomly shown on startup in release mode and I get stuck, I have to close the app and try again in order to make it work. I think it has a lot of more chance for the white screen to be displayed if it is the first run after a fresh install. I think it has something to do with react navigation and react-native-screens but I am not sure about it. Happens on both Android and iOS.
Already tried this solution without any success.
https://github.com/facebook/react-native/issues/26605#issuecomment-576178239
React Native version:
Run react-native info in your terminal and copy the results here.
info Fetching system and libraries information...
(node:7256) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
System:
    OS: macOS 10.15.6
    CPU: (4) x64 Intel(R) Core(TM) i5-8210Y CPU @ 1.60GHz
    Memory: 828.73 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.7.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.7 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 11.6/11E708 - /usr/bin/xcodebuild
  Languages:
    Java: 12.0.1 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: ^16.13.1 => 16.13.1
    react-native: ^0.63.2 => 0.63.2
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Create sample project and add some screens using react navigation lib.
Perform a release run on xCode / Android

Expected Results
Blank / White screen should not appear and should be replaced by the splash and the app after everything loads.
Snack, code example, screenshot, or link to a repository:
This sample starts with a fresh install app from testflight.

Dependencies:
"@apollo/react-components": "^4.0.0",
    "@apollo/react-hooks": "^4.0.0",
    "@react-native-community/async-storage": "^1.11.0",
    "@react-native-community/datetimepicker": "^3.0.0",
    "@react-native-community/masked-view": "^0.1.10",
    "@react-native-community/toolbar-android": "^0.1.0-rc.2",
    "@react-native-community/viewpager": "^4.1.4",
    "@react-native-firebase/analytics": "^7.4.1",
    "@react-native-firebase/app": "^8.3.0",
    "@react-native-firebase/messaging": "^7.6.1",
    "@react-native-firebase/remote-config": "^8.1.1",
    "@react-navigation/bottom-tabs": "^5.8.0",
    "@react-navigation/native": "^5.7.3",
    "@react-navigation/stack": "^5.9.0",
    "@sentry/cli": "^1.55.1",
    "@sentry/react-native": "^1.7.1",
    "apisauce": "^1.1.2",
    "apollo-boost": "^0.4.9",
    "apollo-client": "^2.6.10",
    "base-64": "^0.1.0",
    "easy-peasy": "^3.3.1",
    "g": "^2.0.1",
    "graphql": "^15.3.0",
    "graphql-tag": "^2.11.0",
    "jetifier": "^1.6.6",
    "jwt-decode": "^2.2.0",
    "moment": "^2.27.0",
    "react": "^16.13.1",
    "react-native": "^0.63.2",
    "react-native-code-push": "^6.3.0",
    "react-native-credit-card-input": "^0.4.1",
    "react-native-device-info": "^5.6.4",
    "react-native-dialog-input": "^1.0.8",
    "react-native-elements": "^2.2.1",
    "react-native-email-link": "^1.9.2",
    "react-native-fbsdk": "^2.0.0",
    "react-native-gesture-handler": "^1.7.0",
    "react-native-gifted-chat": "^0.16.3",
    "react-native-google-places": "^3.1.2",
    "react-native-image-picker": "^2.3.3",
    "react-native-image-zoom-viewer": "^3.0.1",
    "react-native-iphone-x-helper": "^1.2.1",
    "react-native-linear-gradient": "^2.5.6",
    "react-native-localization": "^2.1.6",
    "react-native-masked-text": "^1.13.0",
    "react-native-modal": "^11.5.6",
    "react-native-modal-datetime-picker": "^8.9.3",
    "react-native-permissions": "^2.1.5",
    "react-native-reanimated": "^1.13.0",
    "react-native-safe-area-context": "^3.1.4",
    "react-native-screens": "^2.10.1",
    "react-native-segmented-control-tab": "^3.4.1",
    "react-native-vector-icons": "^7.0.0",
    "react-native-webview": "^10.4.0",
    "rn-fetch-blob": "^0.12.0",
    "styled-components": "^5.1.1"

Hi @agusvazquez sorry you're experiencing this. Could you provide a minimum repro that demonstrates this?

Hey @safaiyeh thanks for your response.
I have created a new project with the same structure as my real project, but I just wasn't able to reproduce the issue.
This is the project if you want to check it out.
https://github.com/agusvazquez/BlankScreen-Demo
Apologies for not being able to give you all the feedback you need. I will keep working on reproducing the issue.

A quick check of the react-native-screens repo, I saw some issues concerning the blank screens. Could you check if those are helpful?

Also I found this issue, does their fix work for you? https://github.com/facebook/react-native/issues/26400

Yes! I have been googling and tried most of the solutions on react-native-screens repo. I will check again, perhaps I missed something.
About #26400 , I saw that one is related to android only, and in my case it happens on both Android and iOS with more occurrences on iOS on the first launch.

Hello @safaiyeh .
I have been testing this and I realized that this only happens when downloading the app from the Store / Testflight. Running as release mode does NOT reproduce this issue.
Looking for that, I saw this.
https://github.com/microsoft/react-native-code-push/issues/1356
I removed codepush from my project, and now it seems to work fine. I will continue it with them.
Thanks for your support!

@agusvazquez Awesome! I'm glad you narrowed down the issue.


refactor(rust): remove the annoying clippy::wildcard_imports

#6860  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite

Praise the lord! It was so annoying.


WIP: Unit tests for ManageController

Created small PR for 2 initially to get feedback before creating PR's for more.
ManageController.IndexGetAddsCorrectMessageToViewDataWhenMessageEqualsChangePasswordSuccess
ManageController.IndexGetAddsCorrectMessageToViewDataWhenMessageIdEqualsSetPasswordSuccess

@Chris-Wooder, I'm going to try to get my eyes on this today or tomorrow. Thanks.

Great, i am ready to create another pull request but will wait for first review to apply any comments.  As more tests are populated I will refactor some of the repeated code out into some helper methods to centralise creating the controller for common scenarios.

@Chris-Wooder, first and foremost, thanks for your contribution. I've quickly looked at the two test implementations you've added and I've included some fixes in my code review for you to implement.
If you have any questions, please let me know.

@Chris-Wooder, please do NOT do this:

As more tests are populated I will refactor some of the repeated code out into some helper methods to centralise creating the controller for common scenarios

shared setup in unit test methods are not a good thing. I realize some of our codebase does have shared setup, and those unit test are very hard to unravel unless you're the initial author of the unit test.
Don't worry about repeated code for now, just worry about unit test implementation/correctness.

@mgmccarthy thanks for the feedback, yes makes sense, should've paid more attention to stub names.  Implemented methods for the first 4 GET index stubs.

@Chris-Wooder, do you want to work on any other tests? If so, would you like to keep this PR open as a WIP and keep adding to it, or do you want to do small PR's and have them merged in as we go?

@mgmccarthy, yes I am working on more, unless you think there are any other particularly high priority tests I will continue going through the stubs for the ManageController.
As for Pull Request, I don't mind, is there a preference on the project?

@Chris-Wooder however you want to work. I do know this controller is in desperate need of unit tests, and it's one of the harder controllers to test.
For now, let's leave this PR open as  WIP, and you can keep adding to it as much or as little as you want. 4-6 tests at a time (or at least logically grouped tests by action method name/type (POST/GET)) will help keep the code review process working nicely.
When we get to a certain threshold of code, we'll probably want to merge the PR.
Thanks

Ok will carry on with ManageController

thanks again @Chris-Wooder and @mgmccarthy let me know when good to go/merge

This pull request contains all tests for the Index GET & POST Actions.  Maybe makes sense to create a new PR for next set of commits...

I would agree, moving to another PR allows this to get pulled in independent of the next batch.  If you're good to do that edit the name to remove wip and we'll merge. Thanks

@tonysurma done.


Parser bombs, callback not called

It appears the fix for issue 26 has caused a new variant of issue 20 where the parser bombs but does not call the scan callback with the error. I think it's because the try/catch inside the exec() callback in windows-scan.js was removed. In my case the result is the process exits, I'm not sure if that's always true. Here's the current exception:
...\node_modules\node-wifi\src\windows-scan.js:47
    network.mac = networkTmp[4].match(/.*?:\s(.*)/)[1];
                               ^

TypeError: Cannot read property 'match' of undefined
    at parse (E:\KPM\SrvWebs\vgr-system-server\node_modules\node-wifi\src\window
s-scan.js:47:32)
    at E:\KPM\SrvWebs\vgr-system-server\node_modules\node-wifi\src\windows-scan.
js:33:27
    at ChildProcess.exithandler (child_process.js:262:7)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Socket.stream.socket.on (internal/child_process.js:348:11)
    at emitOne (events.js:115:13)
    at Socket.emit (events.js:210:7)
    at Pipe._handle.close [as _onclose] (net.js:545:12)

parse() throws the exception. The exec() callback function which called parse() doesn't have a try/catch, the try/catch you see is for the exec() call itself.

Sorry for the delay. I am not sure to understand the reason. The try catch outside the exec call should handle this error.  I am investigating.

It happened again today on Windows 10. Sometimes "netsh wlan show networks" will encounter a network for which it prints the SSID, Network type, Authentication, Encryption, but nothing else. So parse() throws an exception trying to parse the MAC, and in the callback function passed to exec() from scanWifi() there is no try/catch, so the process is terminated. The try/catch around the call to exec() doesn't help, because the exec() function has already returned.

Hi,
In order to improve the stability of this library, I think it would be better to create unit tests and have example of netsh standard output to reproduce this kind of situtation. Can you provide an output related to your situation to include it in the unit tests ?

I haven't caught it in this state. Will update if I do.


./build_release.sh 时报错

-- Operation System is UNIX-like OS's
-- Generator is Unix Makefiles
-- MyDepends is at /home/mydeps
-- Platform is x64
-- Configuring done
-- Generating done
-- Build files have been written to: /home/lzz/wonderTrader/wondertrader/src/build_all
[  1%] Building CXX object WTSUtils/CMakeFiles/WTSUtils.dir/WTSCfgLoader.cpp.o
In file included from /home/lzz/wonderTrader/wondertrader/src/WTSUtils/../Includes/WTSCollection.hpp:16:0,
from /home/lzz/wonderTrader/wondertrader/src/WTSUtils/../Includes/WTSVariant.hpp:14,
from /home/lzz/wonderTrader/wondertrader/src/WTSUtils/WTSCfgLoader.cpp:7:
/home/lzz/wonderTrader/wondertrader/src/WTSUtils/../Includes/FasterDefs.h:3:10:fatal error: boost/container_hash/hash.hpp: No such file or directory
#include <boost/container_hash/hash.hpp>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
WTSUtils/CMakeFiles/WTSUtils.dir/build.make:62: recipe for target 'WTSUtils/CMakeFiles/WTSUtils.dir/WTSCfgLoader.cpp.o' failed
make[2]: *** [WTSUtils/CMakeFiles/WTSUtils.dir/WTSCfgLoader.cpp.o] Error 1
CMakeFiles/Makefile2:85: recipe for target 'WTSUtils/CMakeFiles/WTSUtils.dir/all' failed
make[1]: *** [WTSUtils/CMakeFiles/WTSUtils.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
请问应该如何解决呢？

mydeps的路径放错了，已经解决。

mydeps的路径放错了，已经解决。


this closes #68 by excluding by default netbeans configuration file

find as PR a very small contribution to your project.
It provides default exclusion of netbeans configuration file.
I tried to integrate the required tests that demo the modification is working as expected.
come back to me if something is missing.

Thanks!


DalaranBalance

Various balance changes for Dalaran. #2757
Added "draenei" nick name.
Dalaran now opens the gate to gilneas once they have control of their city.
Battlemage:

Health 400 -> 450.
Mana 300 -> 325.
Gold 17 -> 16.

Jaina:

Base health 200 -> 350.

Antonidas:

Base health 300 -> 400

Arcanist:

Dispel summon damage increased in line with other dispels 200 -> 250.

Initiate mage:

Attack 29->26.
Health 550 -> 525.

I gather you've merged these changes into #2769 so I'll just close this one!


Splitting.grid

Merge SplittingImage into Splitting with a Splitting.grid function. They're basically the same (create elements/divide element and apply CSS vars) and could use all the same core functions.
API could be along these lines:
Splitting.grid({
  target: ...,
  rows: 1,
  cols: 1,
  image: 'auto' // finds first <img> and applies it as `background-image`
    false // no background image applied
    URL // image directly set as background-image
});

I've got this on my radar.  Once I get the 1.0.0 passing tests for the whole API, I think this shouldn't be a big deal to move over.

Based on our latest discussion:
Splitting({ by: 'grid' }) = make a grid ( SplittingImage functionality ).
Splitting({ by: 'layout' }) = detect layout, apply CSS vars.
Behind the scenes for layout, we could actually generalize it and make it two splits of rows and cols that users can use, and then lines could utilize the same backend.
'layout' = ['rows', 'cols']
'lines' = ['words', 'rows']
Does that make sense? rows would loop through elements and compare the offsetTop, cols would loop through elements and compare offsetLeft.
It assumes a linear progression in the current setup. Might need to be abstracted a bit. Something like this may work:
var rows = {};
elementArray.some( el => {
  ( rows[el.offsetTop] || rows[el.offsetTop] = [] ).push(el);
});
// then create an array from the object, sorted by the keys to be indexed as the `--row` value.

layout may not be able to be so abbreviated as ['rows', 'cols']. I don’t know that those would cascade smoothly into each other with the way rows & cols return arrays of arrays. Still, internally it should be able to use both of those directly and/or simply call Splitting({ target: el, by: 'rows' }) and Splitting({ target: el, by: 'cols' }).


Zenodo did not automatically create a DOI for v0.6.1

Should we try deleting the release&tag on github and restarting the tagging process from scratch ?

Asking them by mail should be enough no?

I contacted Zenodo via their support web page.

That was swiftly fixed by Zenodo's support:

From a brief investigation, we found that during the release process, there was probably an issue either on our network or storage stack, which interrupted the transfer of the release zipball from GitHub. I restarted the process and the release seems to be published now at "https://zenodo.org/record/1115640" under the DOI "10.5281/zenodo.1115640".


Create iSIM package for pip installation

A setup.py script was created for easy "pip install -e ." command.
In order to do this some modifications needed to be made.
I am reorganizing all isim_*.py code into an iSIM directory. In doing so I removed the isim prefix to all scripts.
All scripts in package are imported through an iSIM import.
I have changed all imports in the .py scripts to be compatible with this. At current I have not changed the ipynb, but will before merging.

I have begun some scripts to establish tests for the code as well. However, I think for organization sake this is better done in its separate pull request. I don't want to merge too much at one time. So we can discuss further in the meeting monday.


upgrade auditbeat

Signed-off-by: David J. M. Karlsen<EMAIL_ADDRESS>What this PR does / why we need it:
upgrades to latest auditbeat version
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] DCO signed
[X] Chart Version bumped
[X] Variables are documented in the README.md

/lgtm


Generate Spanish locale file into applications when creating a new work type

@jcoyne Build should go :green_heart: momentarily. Re-review?


model/gateway: add 'max_concurrency' field

Add max_concurrency to the session start limit struct, which indicates how many shard sessions may concurrently be started.
Documentation and tests have been added to go with it.

It should probably be said here that it is currently in a pr for the official Discord docs. https://github.com/discord/discord-api-docs/pull/1621


Initial storybook commit

Summary
Add an initial skel for start building the storybook. Included some examples.
I think QA is not needed here in the sense is almost not touching the real code (just a small change related to how the color of the theme is applied to the badges) the rest of the code is just related to the storybook.
Ticket Link
MM-17861

Has been in between the merge of the other branch, but I can check it, the necessary changes should be minimal

@reflog good catch, now is working, thanks for the heads up :)

Thanks @jespino!
Can you give me more info on what to check for here:

(just a small change related to how the color of the theme is applied to the badges)

Also, is it possible to write unit tests and/or Cypress tests for storybook PRs?

@lindy65 Yes, it was a change about how the background color of the badges is defined. Before the change it was done through the all themeing approach (which is not working properly for the storybook) so I change it to use the new approach (css-variables). I is a look and feel change only that Is quite hard to test and is not tested anyway in any other case. The "QA" test should be verify that the color of the badges change accordingly to the theming changes, with that I think we are safe.
About Unit/Cypress test of the storybooks, we could do that for sure, but I think would be a pretty high investment in adding tests to something that is going to be documentation only.

Thanks @jespino 👍
Can you give me a list of areas to check the badges or is it across the app?
Thanks for explanation re unit/cypress tests - agree - not necessary for documentation only.

@lindy65 it is across the app but is affecting everything in the same way using the same CSS, so it should behave in the same way in every instance.

Perfect, thanks @jespino! I'll test soonest!

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3570.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Thanks @jespino
I tested the background colours of BOT badges when changing themes
For the "Mattermost" and "Organization" themes, the background of the BOT badges is a light grey when not hovered over

and a darker grey when hovered over

For the "Mattermost Dark" and "Windows Dark" themes, the background of the BOT badge is a darker grey when not hovered over

and a lighter grey when hovered over

Let me know if you think there are other badges you think I should test, otherwise this looks good to me!

No, If that is right, I think we are good to go :)

Test server destroyed


Upgrade keycloak httpd client install from 1.1 to 1.3

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

Upgrade keycloak httpd client install from 1.1 to 1.3
Change Log

SPECS-EXTENDED/keycloak-httpd-client-install/keycloak-httpd-client-install.spec
SPECS-EXTENDED/keycloak-httpd-client-install/keycloak-httpd-client-install.signatures.json
cgmanifest.json

Does this affect the toolchain?

NO
Associated issues

N/A

Links to CVEs

N/A

Test Methodology

Local Build

@microsoft-github-policy-service agree company="Microsoft"


fix: cidr split with multiple azs

https://github.com/camunda/camunda-tf-eks-module/pull/181 introduced a bug regarding the split of the vpc for the AZs, this fix and test the vpc subnet definition

we have a cidr block of <IP_ADDRESS>/16, the fix splits it up into blocks of /22, shouldn't it be possible to do something like /19 or /20 otherwise feels like a lot of wasted space.
You'd have 3 public and 3 private subnets, so total of 6.
I think the fix is a bit too generous atm.


Style feedback form

decrease textarea height
decrease radio button widths
increase space above submit button

Tested on Heroku, approved, please merge.


mro h7 secured firmware

This PR is for automating the security and testing of the mro-h7 flight controller. More info found here.
Acceptance Criteria

[x] make cppcheck_secure make target created & runs
[x] make scan-build_secure make target created & runs
[x] make clang-tidy_secure make target created & runs
[x] make coverage_secure make target created & runs

Fixed cppcheck-htmlreport errors and reverted text changes.


localstorage: open up for custom variables to store

Is it needed? For what cases do we need to change them? If it collides with another panelbar?

It's more for custom elements. If someone feels to store some of their own values across page loads. Since we already have a panelBarState class, I thought it also could handle such things. Maybe I'll rather label it as an idea for now.


do proper testing if the package really works

also increment build number
ref: conda-forge/staged-recipes#3215

@megies,
Would you like to be included as an additional maintainer?

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@megies,
Would you like to be included as an additional maintainer?

Your call, I mainly just wanted to be able to install this via conda. But I can also try to help keep it up to date if you like.

an additional maintainer would be awesome. I am adding you as part of the merge.

OK, fine, thanks!


Add Visual Studio Code

Description
Add Visual Studio Code extension.
Commands
Search and trigger commands directly from Raycast. This command requires that the Raycast for VSCode extension is installed in VSCode. If not the user will get an action to do so.
VSCode has some internal API limitations and therefore not all command aliases can be shown. If this is the case the command ID will be shown instead.
User can also store the VSCode command as quicklink (using URL schemas in the background) which makes it accessible from the root menu of raycast.

Show Installed Extensions
Show locally installed extensions.

Install Extensions
Install Extension in VSCode.

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

@pernielsentikaer I will add that for you.

@pernielsentikaer I add Insiders build support

Hi 👋
It works as expected, two things:

Is there a way to get Commands running without your extension behind it?
Maybe we should find another icon since it covers more versions (Since it could also cover VSCodium)

WDYT?

@pernielsentikaer would make sense to call the merged extension just visual-studio-code

Yes, we would rename Visual Studio Code Recent Projects to Visual Studio Code and merge if things fit in, so we don't end up with too many extensions for the same application.
I already spoke with @thomaspaulmann about it, and it makes sense to do it.
Could you change this PR into a modification or make a new PR if it's easier 😊

FYI I did a bigger refactoring of the recent projects extension. Please make sure to build on top of it.

Hassan

شكرا

Are you still up for this @tonka3000 - in this PR or another 😊

@pernielsentikaer I will do it in another PR.  Right now very busy, will take some time.

Closing this due to a new PR will be opened, let me know if you want this open @tonka3000 and I'll reopen it

Great work @tonka3000 👏  will keep my eyes peeled for this one!

@thomaspaulmann @eduwass #6329 PR is now pushed


bad rendering performance of some components in blazor server side

Feature request type
Performance improvement
Component name
No response
Is your feature request related to a problem?
If you have many components on one page (e.g. many checkboxes in a treeview...) then every single checkbox makes a JS interop call to the client. In this example it's the keyinterceptor-call in the component's OnAfterRender. This makes it really slow in blazor server side.
Describe the solution you'd like
No/Less JS interop calls in a component's lifecycle method.
Have you seen this feature anywhere else?
No response
Describe alternatives you've considered
For the keyinterceptor in this example I can imagine a client side mutationobserver that automatically registers/unregisters element's events based on classes/data-attributes. On the server side you would only need to register the component or eventhandlers in a scoped keyinterceptor-element-eventhandler-list to handle the callbacks that are invoked from the client side.
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, I've created a sample project/prototype: https://github.com/haas-daniel/KeyInterceptor


wiki: mention WindowedApplication when targeting Apache Flex SDK desktop

For desktop builds WindowedApplication is used.
Maybe this line is missing in Create a project that targets the classic Apache Flex SDK at the end of 7. step:
"An Adobe AIR project that targets desktop should set WindowedApplication instead Application."

Will the project still compile and run if you use Application instead of WindowedApplication with AIR? I would expect that to be allowed, but it's been a while since I last tried. I ask because this page is supposed to be focused more on configuring the project and workspace settings. The sample "Hello World" code Flex MXML is probably the least important detail there.
That said, if using Application with AIR results in compiler or runtime errors, then I agree that it would be better to make it note about WindowedApplication. If it runs fine, I'd rather keep these instructions simpler.

After quick test it looks answer is no.
Just tried new Flex project in FB 4.6 for desktop with Adobe Flex 4.6.0 SDK, then changed WindowedApplication to Application, and results are; no problems reported, compilation works, but when run - no initial window is visible. After quick check that is probably because to that WindowedApplication  implements IWindow and it returns NativeWindow for app.

Okay, I'll add a note.
I actually recall now that WindowedApplication has some special code that sets the native window's visible property to true manually because the default template for an AIR application descriptor has it set to false, for some strange reason. This is probably why you don't see the native window. Application doesn't have this special logic.


*Docs launch - to be merged with PR #254 on substrate-website

remove playground and index pages, add redirects, update navigation
https://github.com/paritytechmarcomms/substrate-website/pull/254

@user-09876 So the main reason it that this page will be moved to substrate.io/developers and therefore we do not want any homepage on docs.substrate.io. Instead I have setup a redirect from / -> /quick-start/ which is hopefully ok. I left the index.js in the root of the folder in case we want to put it back.


LUA Scripts not running in HTML5

Describe your problem here.
Hello Guys,
I want my mod for HTML5 but I have used LUA Scripts in my mod. Now LUA Scripts are not loading in HTML5. Please tell me what I do.  Sites like KBHgames.com are using LUA Scripts in HTML5. How are they using LUA in HTML5?
Are you modding a build from source or with Lua?
Lua
What is your build target?
HTML5/Browser
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Lua Scripts do not function on HTML5

Lua Scripts do not function on HTML5, nor they can run on it

I checked PsychEngine.js of one of mod of KBH Games. How are they using LUA in HTML5.
this.makeLuaSprite("bg","bg",-1100,-650),this.setLuaSpriteScrollFactor("bg",.9,.9),this.scaleLuaSprite("bg",1.4,1.4),this.makeLuaSprite("CasaFH","CasaFH",-1900,-800),this.scaleLuaSprite("CasaFH",1.4,1.4),this.addLuaSprite("bg",!1),this.addLuaSprite("CasaFH",!1)
This code is showing.

Try to put this. In front of everything them


Docker Image for KPSR Tutorial

Depends-On: https://github.com/klepsydra-technologies/kpsr-tutorial/pull/38

Implementation is going to be done in https://github.com/klepsydra-technologies/kpsr-tutorial/pull/39 instead
As requested in https://klepsydra.atlassian.net/browse/KPCI-243?focusedCommentId=10275


New version: charmbracelet.melt 0.6.2

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Automated with GoReleaser
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\melt.exe returned exit code: 1
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\melt.exe returned exit code: 1

(Automated response - build 887.)


Implementation of Neo4jIgnoreAttribute to control property serialization instead of JsonIgnoreAttribute

Implementation of Neo4jIgnoreAttribute as BoltGraphClient serializes object parameters ignoring JsonContractResolver, see #336
Works with BoltGraphClient and GraphClient

Changes in Neo4jClient/Neo4jClient.csproj and Neo4jClient/project.json were just to get it built on my system.

Hey,
I've gone through and would have no problem pulling this in, but I'd need there to be some tests - i.e. proving that it works correctly, especially given that this would replace a default in the client (the contract resolver) from being an imported one to a custom one.
So tests about Ignoring and renaming would be great!

Perfect, unfortunally, I have no resources to do more tests. As the Neo4jContractResolver part is just for the non-bolt client, we do not need it for our actual problem switching to BoltGraphClient. I thought it would be easier for documentation when Neo4jIgnoreAttribute works in both clients by default. Maybe you can just include the Neo4jContractResolver in the project but not set it as default, so users can refer to it just by need. We were using it since about 2 years now in our application without problems, so it works fine for us, but I have no idea which different scenarios could be affected on other users applications. If you could just pull in the changes in SerializeObject and the Neo4jIgnoreAttribute it would be perfect.

I mean - I'd still need tests to prove that it works - I can't just pull in code without proof - from my pov - if I put in the Neo4jIgnoreAttribute and someone uses it and it doesn't work - it's on me to fix it then - it's especially an issue when it's around the serialization aspect.
I can see the benefit of the code, and I'd hope to get time to add tests myself. Do I have permission to push to your branch?

What kind of proof do you need exactly? Before I created the PR, I tested it in a branch of our full recruiting portal web application and everything worked fine (I removed the official Neo4jClient-Nuget package, included the project from the PR and switched it from https to bolt - there is heavy use of [Neo4jIgnore] in our application and it didn't worked over bolt with the Nuget version).
If you don't make the Neo4jContractResolver as default, it's just this one line which has any influence on behaviour and could break:  pi.IsDefined(typeof(JsonIgnoreAttribute)) || pi.IsDefined(typeof(Neo4jIgnoreAttribute)) instead of pi.IsDefined(typeof(JsonIgnoreAttribute)) ... should be a manageable risk.
As I'm not familiar with your testing engine, I don't know how to prove. Mayby you can use the sample code in #336 to test it by your own.
I just added you as a contributor to my branch.

Hey @Clooney24 et al.
I'm very sorry for the time this is taking - (has taken).
I've put this into the 4.x version of the codebase, not the 3.x one, which will be <IP_ADDRESS>-prerelease - At the moment, I think there will be maybe another 1 or 2 releases before removing the pre-release tag - we're pretty much at RC atm.
I'm closing this for this reason.
Thank you for doing the changes, and, again, sorry for the time


AsyncRestTemplate Interceptors with non blocking async client (apache http async client)

A question came up while I was trying to using asyncresttemplate with async http client as per this example: http://vincentdevillers.blogspot.com/2013/10/a-best-spring-asyncresttemplate.html
Question is: Will sleuth continue to copy over the tracer contexts at the async http client level as well? Or will this be a different implementation altogether? Or will this not be supported out of the box?

We already support AsyncRestTemplate - https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebAsyncClientAutoConfiguration.java . Is it not working?

Ahhh .. thank you for that. I am going to give this a try and let you know how it goes! Appreciate your prompt reply!

I am going to close this for now. I will comment back once I have a trial project to let you know if it worked or not!

@marcingrzejszczak I am reopening this issue because I wasn't quite sure how custom async http client would work with the asyncwebclientautoconfiguration you mentioned above. So if you look at the example I mentioned above, you are setting up multiple properties for the async http client. Now from those client beans you make up the asynchttpclientfactory bean and so on and so forth. But if I do it manually, because of the OnconditionalMissingBean annotation in spring sleuth code, it will never really configure the way Sleuth expects those asyncclientfactories to be autoconfigured. We could potentially extend the Sleuth configuration, write our own. But is there any other way to do it out-the-box? Or any plans to support this in the future?
A more generic question here would be: There could be many different reasons of overriding the default configuration of restTemplate (or for that matter, asyncRestTemplate with (or without) async http client). Something directly autowiring these clients without configuring them might not work best for a given application. So, on one side, straight up using autowired restTemplates work fine out-the-box, custom configured autowired restTemplates will not work out-the-box, unless, somehow we know what to (and how to) override from Sleuth.
If that's how it will be supported, it'd be nice to some kind of example/documentation on how we can write custom, overridden, configurations for these clients.


TensorFlow 2.2.0 stable available

hi,
you can compile tensorflow in version 2.2.0 and TensorRT 7.1.0 with all tweaks (avx2, fma, etc)?
python 3.8.2
cuda 10.2
cudnn 7.6
nccl 2.6
CUDA Compute Capability=5.0

Hello,
unfortunately, I don't have access to the machine I used to build the wheels at the moment.


WIP: Remove old frontend and ui backend. Update Readme.

Remove the previous frontend and backend ui.
Update the README mentioning the http://beta.lanthorn.ai site.

I think you forgot to remove config-frontend.ini

Yes, you are right. I removed it.


[ ]  Please fix review comments
[ ]  All dependencies should be latest

@vinodloha - removed react and react-dom from storybook package.json. Rest of the dependencies are latest.


[gelly] Add Vertex.create and Edge.create helper methods

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[x] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[x] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Added helper methods to make Gelly API more concise.
Now one can write this:
Vertex<Integer, NullValue> v = Vertex.create(42);
Edge<Integer, Integer, NullValue> e = Edge.create(5, 6);

Instead of this:
Vertex<Integer, NullValue> v = new Vertex<Integer, NullValue>(42, NullValue.getInstance());
Edge<Integer, Integer, NullValue> e = new Edge<Integer, Integer, NullValue>(5, 6, NullValue.getInstance());

Hi @mushketyk,
thank you for this PR. Is there a corresponding JIRA for it? If not, can you please create one and tag the PR with it?
Also, make sure you read the How to contribute guide and make sure your PR checks all the items in the list above.
Let us know if you have questions!

Hi @vasia
I've created a JIRA issue for the pull request.
What do you think about this change?

Closing according to discussion in JIRA.


Using the exchange crate

This is a WIP and it's actually not compiling because the exchange crate needs to be present in an outside path.

I just merged the separating-crates branch to master which included the usage of the exchange crate.
Is this PR still necessary?


Questions about employing distrifuser to SD2.1/1.5

Hi,
I have tried scrips/sd_example.py. It works well when I use 2 GPUs. However, when I use 4 or more GPUs, the output of SD will be a totally black image.  Is this a bug or distrifuser cannot process such low-resolution (768768, 512512) images so far?

Could you change the mode of this line to sync_gn to see if it works?

It's solved, Thanks!

For better speed, you can also try separate_gn for better speed. stale_gn and correct_async_gn seem to have some bugs when the resolution is small. I will let you know when I solve this.


Bugfix kubernetes via dns

@noctarius As discussed yesterday (@SchweizerischeBundesbahnen in Muntelier) we had a problem with hazelcast on openshift. We now debugged it and found out, that the problem is in the DnsEndpointResolver. As the response from openshift dns looks like this:
nslookup u219692-hazelcast.u219692-hazelcast.svc.cluster.local <IP_ADDRESS>
Server:         <IP_ADDRESS>
Address:        <IP_ADDRESS>#53
Name:   u219692-hazelcast.u219692-hazelcast.svc.cluster.local
Address: <IP_ADDRESS>
Name:   u219692-hazelcast.u219692-hazelcast.svc.cluster.local
Address: <IP_ADDRESS>
Name:   u219692-hazelcast.u219692-hazelcast.svc.cluster.local
Address: <IP_ADDRESS>
The current code adds three times the same ip address (loops the records and then calls "getByName" which always selects the frist answer and adds the ip <IP_ADDRESS> three times to discoveredNodes. This works fine as long as the newly started node has a higher ip (e.g. <IP_ADDRESS>) because it reaches the other cluster. If the new node gets the lowest ip (<IP_ADDRESS>) he thinks he's alone and creates a new cluster, even if the two other nodes already formed a cluster.
So here is how we fixed it :-)

Very nice patch, thanks a lot! :)


Translate post-05 to Japanese

The title says it all.
@JohnTitor Could you review the translation?

👍, I'll find time by the following week.

@JohnTitor Thank you very much! I applied all your careful suggestion except for the one I questioned.

Thanks a lot!