Enable mac upgrade MVP

Final changes to enable upgrade on Mac MVP. This includes:

Run upgrade application inline on platforms that support this
Updating flags on Mac platform to indicate it supports upgrade

Testing notes

On first run as a regular user, gvfs upgrade crashes. But after running sudo gvfs config upgrade.ring fast, the config file gets created (I think?) and there is no problem after that.

$ gvfs upgrade

Unhandled Exception: GVFS.Common.FileBasedCollectionException: Access to the path '/usr/local/vfsforgit/gvfs.config' is denied. ---> System.UnauthorizedAccessException: Access to the path '/usr/local/vfsforgit/gvfs.config' is denied. ---> System.IO.IOException: Permission denied
   --- End of inner exception stack trace ---
   at GVFS.Common.FileBasedCollection.OpenOrCreateDataFile(Boolean retryUntilSuccess) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedCollection.cs:line 383
   at GVFS.Common.FileBasedCollection.TryLoadFromDisk[TKey,TValue](TryParseAdd`2 tryParseAdd, TryParseRemove`1 tryParseRemove, Action`2 add, String& error, Action synchronizedAction) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedCollection.cs:line 233
   --- End of inner exception stack trace ---
   at GVFS.Common.FileBasedCollection.TryLoadFromDisk[TKey,TValue](TryParseAdd`2 tryParseAdd, TryParseRemove`1 tryParseRemove, Action`2 add, String& error, Action synchronizedAction) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedCollection.cs:line 300
   at GVFS.Common.FileBasedDictionary`2.TryCreate(ITracer tracer, String dictionaryPath, PhysicalFileSystem fileSystem, FileBasedDictionary`2& output, String& error, IEqualityComparer`1 keyComparer) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedDictionary.cs:line 38
   at GVFS.Common.LocalGVFSConfig.TryLoadSettings(String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/LocalGVFSConfig.cs:line 113
   at GVFS.Common.LocalGVFSConfig.TryPerformAction(Action action, String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/LocalGVFSConfig.cs:line 88
   at GVFS.Common.LocalGVFSConfig.TryGetAllConfig(Dictionary`2& allConfig, String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/LocalGVFSConfig.cs:line 25
   at GVFS.Common.ProductUpgrader.TryCreateUpgrader(ITracer tracer, PhysicalFileSystem fileSystem, LocalGVFSConfig gvfsConfig, ICredentialStore credentialStore, Boolean dryRun, Boolean noVerify, ProductUpgrader& newUpgrader, String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/ProductUpgrader.cs:line 85
   at GVFS.CommandLine.UpgradeVerb.TryInitializeUpgrader(String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/CommandLine/UpgradeVerb.cs:line 126
   at GVFS.CommandLine.UpgradeVerb.Execute() in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/CommandLine/UpgradeVerb.cs:line 82
   at GVFS.Program.<>c.<Main>b__0_3(ForNoEnlistment verb) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/Program.cs:line 80
   at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult`1 result, Action`1 action)
   at GVFS.Program.Main(String[] args) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/Program.cs:line 51
Abort trap: 6
$ sudo gvfs config upgrade.ring Fast
Password:
$ gvfs upgrade
Checking for GVFS upgrades...Succeeded
New GVFS version 1.0.19157.1 available in ring Fast.

Upgrade will unmount and remount gvfs repos, ensure you are at a stopping point.
When ready, run `gvfs upgrade --confirm` from an elevated command prompt.

sudo gvfs upgrade --confirm failure.

$ sudo gvfs upgrade --confirm
Checking for GVFS upgrades...Succeeded
New GVFS version 1.0.19157.1 available in ring Fast.
Launching upgrade tool...
Downloading...Failed

ERROR: Could not find Git installer in the latest release.

Upgrade logs can be found at: /Users/Ameen/Library/Application Support/GVFS/GVFS.Upgrade/UpgraderLogs with file names that end with the installation ID: 20190619_155931.

Press Enter to exit.

Upgrade completed.

Log file -
[2019-06-19 15:59:31 -04:00] TryRunPreUpgradeChecks (Start)
[2019-06-19 15:59:31 -04:00] Information {"Message":"Successfully finished pre upgrade checks. Okay to run `gvfs upgrade`."}
[2019-06-19 15:59:31 -04:00] TryRunPreUpgradeChecks (Stop) {"DurationMs":86}
[2019-06-19 15:59:31 -04:00] TryCheckIfUpgradeAvailable (Start)
[2019-06-19 15:59:32 -04:00] Information {"Message":"New release found - latest available version: 1.0.19157.1"}
[2019-06-19 15:59:32 -04:00] TryCheckIfUpgradeAvailable (Stop) {"DurationMs":537}
[2019-06-19 15:59:32 -04:00] Installed Version {"installedGVFSVersion":"<IP_ADDRESS>","installedGitVersion":"2.22.0.vfs.1.1"}
[2019-06-19 15:59:32 -04:00] TryDownloadUpgrade (Start) {"Upgrade Step":"TryDownloadUpgrade","Version":"1.0.19157.1"}
[2019-06-19 15:59:32 -04:00] Error {"Upgrade Step":"TryDownloadUpgrade","Version":"1.0.19157.1","ErrorMessage":"TryDownloadNewestVersion failed. Could not find Git installer in the latest release."}
[2019-06-19 15:59:32 -04:00] TryDownloadUpgrade (Stop) {"DurationMs":8}

Testing notes

On first run as a regular user, gvfs upgrade crashes. But after running sudo gvfs config upgrade.ring fast, the config file gets created (I think?) and there is no problem after that.

$ gvfs upgrade

Unhandled Exception: GVFS.Common.FileBasedCollectionException: Access to the path '/usr/local/vfsforgit/gvfs.config' is denied. ---> System.UnauthorizedAccessException: Access to the path '/usr/local/vfsforgit/gvfs.config' is denied. ---> System.IO.IOException: Permission denied
   --- End of inner exception stack trace ---
   at GVFS.Common.FileBasedCollection.OpenOrCreateDataFile(Boolean retryUntilSuccess) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedCollection.cs:line 383
   at GVFS.Common.FileBasedCollection.TryLoadFromDisk[TKey,TValue](TryParseAdd`2 tryParseAdd, TryParseRemove`1 tryParseRemove, Action`2 add, String& error, Action synchronizedAction) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedCollection.cs:line 233
   --- End of inner exception stack trace ---
   at GVFS.Common.FileBasedCollection.TryLoadFromDisk[TKey,TValue](TryParseAdd`2 tryParseAdd, TryParseRemove`1 tryParseRemove, Action`2 add, String& error, Action synchronizedAction) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedCollection.cs:line 300
   at GVFS.Common.FileBasedDictionary`2.TryCreate(ITracer tracer, String dictionaryPath, PhysicalFileSystem fileSystem, FileBasedDictionary`2& output, String& error, IEqualityComparer`1 keyComparer) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/FileBasedDictionary.cs:line 38
   at GVFS.Common.LocalGVFSConfig.TryLoadSettings(String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/LocalGVFSConfig.cs:line 113
   at GVFS.Common.LocalGVFSConfig.TryPerformAction(Action action, String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/LocalGVFSConfig.cs:line 88
   at GVFS.Common.LocalGVFSConfig.TryGetAllConfig(Dictionary`2& allConfig, String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/LocalGVFSConfig.cs:line 25
   at GVFS.Common.ProductUpgrader.TryCreateUpgrader(ITracer tracer, PhysicalFileSystem fileSystem, LocalGVFSConfig gvfsConfig, ICredentialStore credentialStore, Boolean dryRun, Boolean noVerify, ProductUpgrader& newUpgrader, String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS.Common/ProductUpgrader.cs:line 85
   at GVFS.CommandLine.UpgradeVerb.TryInitializeUpgrader(String& error) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/CommandLine/UpgradeVerb.cs:line 126
   at GVFS.CommandLine.UpgradeVerb.Execute() in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/CommandLine/UpgradeVerb.cs:line 82
   at GVFS.Program.<>c.<Main>b__0_3(ForNoEnlistment verb) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/Program.cs:line 80
   at CommandLine.ParserResultExtensions.WithParsed[T](ParserResult`1 result, Action`1 action)
   at GVFS.Program.Main(String[] args) in /Users/Ameen/Work/Microsoft/GVFS/VFSForGit_Actions/GVFS/GVFS/Program.cs:line 51
Abort trap: 6
$ sudo gvfs config upgrade.ring Fast
Password:
$ gvfs upgrade
Checking for GVFS upgrades...Succeeded
New GVFS version 1.0.19157.1 available in ring Fast.

Upgrade will unmount and remount gvfs repos, ensure you are at a stopping point.
When ready, run `gvfs upgrade --confirm` from an elevated command prompt.

sudo gvfs upgrade --confirm failure.

$ sudo gvfs upgrade --confirm
Checking for GVFS upgrades...Succeeded
New GVFS version 1.0.19157.1 available in ring Fast.
Launching upgrade tool...
Downloading...Failed

ERROR: Could not find Git installer in the latest release.

Upgrade logs can be found at: /Users/Ameen/Library/Application Support/GVFS/GVFS.Upgrade/UpgraderLogs with file names that end with the installation ID: 20190619_155931.

Press Enter to exit.

Upgrade completed.

Log file -
[2019-06-19 15:59:31 -04:00] TryRunPreUpgradeChecks (Start)
[2019-06-19 15:59:31 -04:00] Information {"Message":"Successfully finished pre upgrade checks. Okay to run `gvfs upgrade`."}
[2019-06-19 15:59:31 -04:00] TryRunPreUpgradeChecks (Stop) {"DurationMs":86}
[2019-06-19 15:59:31 -04:00] TryCheckIfUpgradeAvailable (Start)
[2019-06-19 15:59:32 -04:00] Information {"Message":"New release found - latest available version: 1.0.19157.1"}
[2019-06-19 15:59:32 -04:00] TryCheckIfUpgradeAvailable (Stop) {"DurationMs":537}
[2019-06-19 15:59:32 -04:00] Installed Version {"installedGVFSVersion":"<IP_ADDRESS>","installedGitVersion":"2.22.0.vfs.1.1"}
[2019-06-19 15:59:32 -04:00] TryDownloadUpgrade (Start) {"Upgrade Step":"TryDownloadUpgrade","Version":"1.0.19157.1"}
[2019-06-19 15:59:32 -04:00] Error {"Upgrade Step":"TryDownloadUpgrade","Version":"1.0.19157.1","ErrorMessage":"TryDownloadNewestVersion failed. Could not find Git installer in the latest release."}
[2019-06-19 15:59:32 -04:00] TryDownloadUpgrade (Stop) {"DurationMs":8}

I ran into the first issue when I was helping Jameson test this. It seems like an easy enough mistake to make, should we fix it in a follow up PR?

@alsheehan Thank you for trying this! The crash on the initial run as a regular issue is a known issue that I will fix. As you pointed out, it is because the regular user does not have permission to create this file.
For the second issue, it looks (in part) like a configuration issue. But does bring up another question - how should we handle the GitHub upgrader on non-Windows platforms.

One more testing note. After running sudo gvfs upgrade --confirm successfully, GVFS.Service showed multiple auto-mount failures caused by missing git credentials. As discussed, this is probably because GVFS.Service initiated auto-mount as soon as it got launched by VFSForGitInstaller.pkg::postinstall script, before gvfs upgrader got the chance to run its post installer and restore gcm settings.
[2019-06-19 16:25:33 -04:00] ExecuteMount (Start) {"Version":"<IP_ADDRESS>","EnlistmentRoot":"/Users/Ameen/Work/Microsoft/TestRepos/GVFS_5","Remote":"https://mseng.visualstudio.com/AzureDevOps/_git/GVFS","ObjectsEndpoint":"https://mseng.visualstudio.com/AzureDevOps/_git/GVFS","Unattended":false,"IsElevated":false,"NamedPipeName":"/Users/Ameen/Work/Microsoft/TestRepos/GVFS_5/.gvfs/GVFS_NetCorePipe","EnlistmentRootPathParameter":"/Users/Ameen/Work/Microsoft/TestRepos/GVFS_5"}
[2019-06-19 16:25:33 -04:00] AttemptAnonymousAuth (Start)
[2019-06-19 16:25:34 -04:00] NetworkResponse {"RequestId":1,"availableConnections":4,"CacheName":"","StatusCode":401,"connectionWaitTimeMS":"0.0013","responseWaitTimeMS":"893.9655"}
[2019-06-19 16:25:34 -04:00] AttemptAnonymousAuth (Stop) {"HttpStatus":"401","QuerySucceeded":true,"IsAnonymous":false,"DurationMs":1175}
[2019-06-19 16:25:34 -04:00] TryGetCredential (Start)
[2019-06-19 16:25:34 -04:00] Warning {"WarningMessage":"Git could not get credentials: git: 'credential-osxkeychain' is not a git command. See 'git --help'.\nfatal: could not read Username for 'https://mseng.visualstudio.com': terminal prompts disabled\n"}
[2019-06-19 16:25:34 -04:00] TryGetCredential (Stop) {"DurationMs":285}
[2019-06-19 16:25:35 -04:00] RetryConfig_LoadedRetryConfig {"Area":"RetryConfig","Timeout":"00:00:30","MaxRetries":6,"Message":"RetryConfigLoaded"}
[2019-06-19 16:25:36 -04:00] NetworkResponse {"RequestId":2,"availableConnections":4,"CacheName":"","StatusCode":401,"connectionWaitTimeMS":"0.0010","responseWaitTimeMS":"814.9171"}
[2019-06-19 16:25:36 -04:00] NetworkError {"RequestId":2,"AttemptNumber":1,"Operation":"QueryGvfsConfig","WillRetry":false,"Exception":"GVFS.Common.Http.GitObjectsHttpException: Anonymous request was rejected with a 401","ErrorMessage":"Anonymous request was rejected with a 401"}
[2019-06-19 16:25:36 -04:00] Error {"Exception":"GVFS.Common.Http.GitObjectsHttpException: Anonymous request was rejected with a 401","ErrorMessage":"TryQueryGVFSConfig failed"}
[2019-06-19 16:25:36 -04:00] Error {"ErrorMessage":"Unable to query /gvfs/config\nAnonymous request was rejected with a 401"}
[2019-06-19 16:25:36 -04:00] ExecuteMount (Stop) {"DurationMs":3478}


fix #710 - stop heartbeat service and unregistry self instances before shutting down server

before shutting down server:

stop heartbeat service
unregister self instance

attache debug test result:

Coverage decreased (-0.1%) to 66.069% when pulling 7ed2d019e6ca98953b837f890239b27192bacda1 on dengguojie:master into fd6b839d522a4b2621c27b8be113ec5b21efc8d6 on go-chassis:master.


feat(assets): add corrections in Op12: EH + F

add list of corrections in source description of Op. 12: source_EH_corr + source_F_corr

Thank you!
May I ask you to please merge develop into this branch again (there were some forced reverts recently).


No ESLint configuration Error

Hi. i created library using vue-sfc-rollup and builded.
after connecting with npm link to another app and imported it show below error.
 ERROR  Failed to compile with 1 error                                                                                9:03:20 PM
Syntax Error: Error: No ESLint configuration found in F:\sfc-test\dist.

You may use special comments to disable some warnings.
Use // eslint-disable-next-line to ignore the next line.
Use /* eslint-disable */ to ignore all warnings in a file.

You cannot expect proper behavior when installing via npm link, unfortunately. This has come up numerous times in prior issues and the problem is with the way webpack resolves modules installed in this manner. The guaranteed solution is to install from a .tgz file (created via npm pack). I believe you can also just delete the node_modules directory from within the component, itself prior to running npm link in the consuming app, as that will cause webpack to install the dependencies properly, though I can't be 100% sure on that.
Closing this issue, as it is a documented issue that must be resolved elsewhere, not with the code generated by vue-sfc-rollup.


Issues with high numbers of bookmarks

When renaming a recording with several hundred bookmarks, renaming the recording causes significant delays in rendering the list, which makes it appear as if data is lost.
After a minute or so, in which the interface is operable, the bookmarks re-appear.
Clicking filters on and off can take a minute to update the bookmark list.
Test collection: https://webrecorder.io/despens/compressed-moons

Fixed by new release


f32/f64/usize in cosmwasm(and other no f32/f64 envs) reproduction and fixes

Closes: #800
Description
Requires https://github.com/cosmos/ibc-rs/pull/790

replaced f64 logic with equivalent u64
forbidden use of f64 (and usize)
usize was replaced by u64, assuming that wasm64 is nearest highest target for mem size. i am ok with safety of thing, so u32/u16 could be better per  case (mostly length on names and some history things - sure never u64, but u64 is correct map to usize), so no ideal but working.
replaced weird serde issues (both serde and serde_wasm compile into wasm f64 even if do just strings, had to rip them as could)
added test to test changes (with these there is no validation error)
side change added schema for ChainId (i use in CW)

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests.
[x] Linked to GitHub issue.
[x] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

feel free to merge with https://github.com/cosmos/ibc-rs/pull/790 and run insuction in shell.nix header. try to rollback any change and see effects. serde works exactly only this way i found, other compile with floats

for usize correctness parity uses static assets
substrate/primitives/runtime-interface/src/impls.rs:45:1
so can asset some usize if needed too

pr has issue
"serde-json-wasm 0.5.1 (git+https://github.com/dzmitry-lahoda-forks/serde-json-wasm?rev=8a7e522c0e4de36a6dfb535766f26a9941017d81)",
need to use no-std serde-json-wasm

https://github.com/CosmWasm/serde-json-wasm/pull/58
https://github.com/CosmWasm/serde-json-wasm/pull/56
we trying to get no_std merged for 1 year+ already so

Hey @dzmitry-lahoda, Any chance you could wrap up this PR?
I also can assist with this if you select "Allow edits from maintainers".

hello, some things

I cannot allow edit because i have -forks org I do all forks (to avoid mix of my projects), and there is bug https://github.com/orgs/community/discussions/5634 . I cannot set the value. So I am ok with copy paste or else.
https://github.com/CosmWasm/serde-json-wasm was released version 1.0. they made it no_std afaid and fixed some issue - so this one should be used.
and final one, latest version of CosmWasm wasmd emulated floats (software implementation I guess). But I am not sure it works in no_std or without using their wasmd wasmer host or without using special assembly rewrite hook. So float less wasm still a thing, so for some people may be less prio.

but in general things I tried still holds, for next 1 month i am on ibc for solidity, so will not catch up this minimum this period, i guess company will continue more efforts to no_std versions of ibc in 2-3 month (after evm).

Thanks a bunch for the tips and updates. :pray: No worries, I’ll fork yours and open up a new PR.
Just, as for the 3rd point, given another issue we've got here, still we should move away from floats.
Looking forward to hearing about the progress on the no_std versions of IBC.

Superseded by #894


pkg/yaml: support dumping

This issue was originally filed by @seaneagan

See: http://www.yaml.org/spec/1.2/spec.html#id2762313
Bonus points for supporting a max line length.
The pretty package may be useful for this, see:
https://github.com/polux/pretty/issues/3

This issue has been moved to dart-lang/yaml#8.


Open browser with a number hotkey

Even though I use mouse for clicked links, it's very convenient to use keyboard to choose the browser I want.
It would be great to display numbers before (or after) each browser in a list, and open the link in needed browser hitting this hotkey.
Example image

Definitely a good idea, will add it to the backlog!

This landed in version 0.3.7.
It doesn't allow specifying hotkey to specific browser, but always shows them from 1-9.


Make a togglable overlay, showing the directions, in which players can move.

When zooming/moving the board, the overlay should move/zoom in the same manner as the board.

Closed by #83


Define Product

Beyond the actual goal of this pull request: Resolves #5.

I have updated names and types to match Unified Schema as @kmike suggested elsewhere. I wonder about the new classes in base.py, though:

Would they be problematic in the same sense as old names and types could be? Should we replace them by dictionaries?
Should they have a mechanism like that of Item to avoid data drop if they get additional fields in the future?

@Gallaecio

Would they be problematic in the same sense as old names and types could be? Should we replace them by dictionaries?

I hope no, but it'd be good to have tests for it.

Should they have a mechanism like that of Item to avoid data drop if they get additional fields in the future?

Yes, a good catch.

I think it'd be great to add more documentation to the field and class definitions. Would it make sense to do it in the same PR, or to handle it separately?

I am OK with doing it here.
I do wonder, though: do we do it in docstrings only, also in the README à la itemadapter, or go for Sphinx already?

I do wonder, though: do we do it in docstrings only, also in the README à la itemadapter, or go for Sphinx already?

Add docstrings here, add Sphinx in a separate PR, don't create a huge README?

Thanks @Gallaecio! 🚀 🚀


The term 'Update-WebApplicationProxyDeviceRegistration' is not recognize d as the name of a cmdlet

I'm getting the following response, when running Update-WebApplicationProxyDeviceRegistration.
Update-WebApplicationProxyDeviceRegistration : The term 'Update-WebApplicationProxyDeviceRegistration' is not recognize
d as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was
 included, verify that the path is correct and try again.
At line:1 char:1
+ Update-WebApplicationProxyDeviceRegistration
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Update-WebAppli...iceRegistration:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Did you get here from the page Configure a federation server with Device Registration Service

https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/deployment/configure-a-federation-server-with-device-registration-service)
and its GitHub source page
https://github.com/MicrosoftDocs/windowsserverdocs/blob/master/WindowsServerDocs/identity/ad-fs/deployment/Configure-a-federation-server-with-Device-Registration-Service.md

?

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


clang-format: add SpaceBeforeInheritanceColon False

For clang-format to adhere to checkpatch, this flag needs to be set.
In the same vein as https://github.com/zephyrproject-rtos/zephyr/pull/76553.
Observed while developing a new NCS AT parser https://github.com/nrfconnect/sdk-nrf/pull/15120. A source file that uses gotos and is auto-formatted with clang-format will not comply to CI unless it also has the flag above.
Without the flag above, the following code section:
yy13:
	{
			if (remainder) *remainder = cursor;
			return (struct at_token){
				.start = at, .len = cursor - at - 1,
				.type = AT_TOKEN_TYPE_CMD_SET
			};
		}

Is formatted to:
yy13 : {
	if (remainder) {
		*remainder = cursor;
	}
	return (struct at_token){
		.start = at, .len = cursor - at - 1, .type = AT_TOKEN_TYPE_CMD_SET};
}

Which does not comply to CI due to a space after the goto label and before the colon.
Adding the flag above will format it to:
yy13: {
	if (remainder) {
		*remainder = cursor;
	}
	return (struct at_token){
		.start = at, .len = cursor - at - 1, .type = AT_TOKEN_TYPE_CMD_SET};
}

Which successfully complies with CI.

@koffes

This change will affect C++ code.  I'm indifferent on this but wondering if @yperess or @cfriedt have thoughts on changing the SpaceBeforeInheritanceColon option.

I think it's fine. No complaints here.


bn_ppc: Move the extern functions to global scope and add ifdef

It seems some AIX compilers do not cope with them correctly otherwise.
Fixes #17087

This pull request is ready to merge

Apparently the build issue on AIX is not solved by this change. Let's not merge as it does not fix the issue.


Introspection settings mixing poorly with getattr and interactive plotting mode?

From<EMAIL_ADDRESS>on 2014-01-29T15:43:12Z
Spyder Version:  2.3.0beta3
Python Version:  2.7.6
Qt Version    :  4.8.5, PySide 1.2.1 on Linux
pyflakes >=0.5.0:  0.7.3 (OK)
pep8 >=0.6      :  1.4.6 (OK)
IPython >=0.13  :  1.1.0 (OK)
sphinx >=0.6.6  :  1.1.3 (OK)
rope >=0.9.2    :  0.9.4 (OK)
matplotlib >=1.0:  1.3.1 (OK)
sympy >=0.7.0   :  0.7.3 (OK)
pylint >=0.25   :  None (NOK)
I realize the introspection stuff has the potential for side-effects, since nearly everything in Python can be customized.  Simply calling hasattr could trigger who knows what from custom classes.  But I think this issue I'm reporting now is separate from that.
I encounter the bug if the introspection monitor is enabled and either automatic code completion or display balloon tips are enabled.  Happens in both console types.
Example:
=====================================================
import matplotlib.pyplot as plt

class AttrPrefix(object):
    def __init__(self,prefix=None,trace=False):
        self.trace=trace
        if prefix is not None:
            self.prefix=prefix
    def __getattr__(self,attr):
        try:
            return object.__getattribute__(self,attr)
        except:
            pass

        try:
            ret=globals()[attr]
            self.prefix()
            return ret
        except Exception as e:
            if not attr.startswith('_'):
                if self.trace:
                    print(e)
                    import traceback
                    traceback.print_stack()
            raise

class Fig(AttrPrefix):
    def __init__(self,*args,**kwargs):
        self.fig=None
        self.fig_number=None
        AttrPrefix.__init__(self,*args,**kwargs)
    def prefix(self):
        self.fig=plt.figure(self.fig_number)
        self.fig_number=self.fig.number
        self.fig.clear()

plt.close('all')
f=Fig()
f.plt.plot([1,2])
\# if you manually type the following line, it won't work:
f.plt.bar([1,2],[1,2])

plt.close('all')
f=Fig(trace=True)
f.plt.plot([1,2])
\# if you manually type the following line, it now catches a out of stack space Exception:
f.plt.bar([1,2],[1,2])
'''
\>>> f.plt.out of stack space (infinite loop?)
  File "/home/Josh/anaconda/lib/python2.7/threading.py", line 783, in __bootstrap
    self.__bootstrap_inner()
  File "/home/Josh/anaconda/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/home/Josh/anaconda/lib/python2.7/site-packages/spyderlib/widgets/externalshell/monitor.py", line 550, in run
    result = eval(command, glbs, lcls)
  File "<string>", line 1, in \<module>
  File "/home/Josh/anaconda/lib/python2.7/site-packages/spyderlib/widgets/externalshell/monitor.py", line 346, in get_dir
    obj, valid = self._eval(objtxt)
  File "/home/Josh/anaconda/lib/python2.7/site-packages/spyderlib/widgets/externalshell/monitor.py", line 340, in _eval
    return eval(text, ns), True
  File "<string>", line 1, in \<module>
  File "<stdin>", line 21, in __getattr__
'''

==================================================================
What I expect is for the figure to redraw and show a bar plot.  But it fails to do so (only if you are typing the command out manually in the console).
I've been exploring the problem for a while, and have hopefully caught a few important clues.  First if of course the caught Exception shown in the example.  The moment I press '.' after plt the problem occurs.  But interestingly, I can eat the Exception and everything almost works correctly.  Just that the figure's canvas no longer updates as expected.  Second clue is that calling plt.draw_if_interactive() fails to redraw.  It seems like the canvas' draw_idle method doesn't update if self._idle is False (at least for FigureCanvasTkAgg).  Instead using plt.draw() does work, but that is hardly interactive.  As to how the Monitor ends up convincing matplotlib canvases that they aren't idle... I'll leave that to someone else to figure out!
This bug is probably rather low priority if this is the only place it comes up.  But I've had plenty of strange issues with matplotlib figures + Spyder (happening across many different versions), some of which seem in ways similar to what I described here (figures not redrawing, figure state getting messed up, different behavior if typed manually) in situations that don't involve me doing anything particularly unusual.  It might at least be worth looking into, just to make sure it isn't causing other more important bugs.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1712

@ccordoba12, I looked at this for a bit.  I get the same stack trace when using the Tkinter backend, and the Qt backend suffers from similar responsive problems.  The Inline works fine with it, and I can manually update plots just fine within Tkinter and Qt backends.  I'd say this is an obscure edge case where you can't always write your code in an IDE.
I vote to close this one as won't fix.

Yep, let's close this one :-) Thanks for taking a look at it!


set_last_will not working if only use reconnect without connect first ?

Describe the bug
set_last_will not working if only use reconnect without connect first
I use A9G board
There's no guarantee that GPRS connects successfully the first time, so I don't call the connect () function. I just called reconect in the for loop. I am suspicious that reconect () didn't send the Last Will and Testament attached
I disconnected the power from the board but within a few minutes I still didn't see it offline.
To Reproduce
Steps to reproduce the behavior:
import utime
from umqtt.robust2 import MQTTClient

def sub_cb(topic, msg, retained, duplicate):
    print((topic, msg, retained, duplicate))

c = MQTTClient("umqtt_client", "localhost")
# Print diagnostic messages when retries/reconnects happens
c.DEBUG = True
# Information whether we store unsent messages with the flag QoS==0 in the queue.
c.KEEP_QOS0 = False
# Option, limits the possibility of only one unique message being queued.
c.NO_QUEUE_DUPS = True
# Limit the number of unsent messages in the queue.
c.MSG_QUEUE_MAX = 2

c.set_callback(sub_cb)

c.set_last_will(topic_pub_availability, "Offline", True, 1) #topic, 'online', retain=True, qos=1

# Connect to server, requesting not to clean session for this
# client. If there was no existing session (False return value
# from connect() method), we perform the initial setup of client
# session - subscribe to needed topics. Afterwards, these
# subscriptions will be stored server-side, and will be persistent,
# (as we use clean_session=False).
#
# TODO: Still exists???
# There can be a problem when a session for a given client exists,
# but doesn't have subscriptions a particular application expects.
# In this case, a session needs to be cleaned first. See
# example_reset_session.py for an obvious way how to do that.
#
# In an actual application, it's up to its developer how to
# manage these issues. One extreme is to have external "provisioning"
# phase, where initial session setup, and any further management of
# a session, is done by external tools. This allows to save resources
# on a small embedded device. Another extreme is to have an application
# to perform auto-setup (e.g., clean session, then re-create session
# on each restart). This example shows mid-line between these 2
# approaches, where initial setup of session is done by application,
# but if anything goes wrong, there's an external tool to clean session.
# if not c.connect(clean_session=False):
#     print("New session being set up")
#     c.subscribe(b"foo_topic")

while 1:
    utime.sleep_ms(500)

    # At this point in the code you must consider how to handle
    # connection errors.  And how often to resume the connection.
    if c.is_conn_issue():
        while c.is_conn_issue():
            # If the connection is successful, the is_conn_issue
            # method will not return a connection error.
            c.reconnect()
        else:
            c.resubscribe()

    c.check_msg() # needed when publish(qos=1), ping(), subscribe()
    c.send_queue()  # needed when using the caching capabilities for unsent messages

c.disconnect()

Details (please complete the following information):

Device board: A9G
Micropython version: https://github.com/pulkin/micropython/releases/tag/latest-build Latest master build
Library version: 2.1.0
901b23d

Hi,
I set
c.keepalive = 15 # 15s
and I call c.ping() every 5 second is OK.
I am wondering if the code is missing: code umqtt.robust2 not auto send ping every keeplive / 3.

The reconnect method is in fact the connect(clean_session=False) method with additions.
And the connect method with cleean_session=False sets "Last Will" correctly. I tested it just now.
You would need to see what messages are displayed on REPL.
Perhaps something else is affecting this problem. From my point of view, everything works.

The programmer is responsible for maintaining the connection. So you have to choose the keep_alive parameters yourself and send a ping to make the connection active.

Thank for reply.
c.keepalive = 15
But I think the code robust2 not automatic Ping feature to maintain KeepAlive ?

There are many different strategies for maintaining the connection, and that is why it is on the programmer's side to keep the connection active.
The problem is also under micropython to keep some code in the background to perform some tasks. That's why this library leaves it up to the programmer to choose their own methods to keep the connection active.

First, I set keepalive = 15s
I don't understand why the reconnect for 15s.
Then I discovered that robust2 did not ping automatically.
Each time will be blocked 1-2 seconds due to the connection process, while Ping is very fast.
I think you should add in the readme the need to maintain keepAlive with Ping().
Thank you very much for the great lib MQTT for micropython library. I hope it will be stable like mqtt pubsub library in arduino


@Catch all decorator does not pass through the error thrown, but always is of type InternalServerErrorException

Hi,
I'm using :

    "next": "^13.1.6",
    "next-api-decorators": "^2.0.1",

With a Catch all handler:
const exceptionHandler = (error: unknown, req: NextApiRequest, res: NextApiResponse) => {
  if (!(error instanceof HttpException)) {
    console.warn('Unhandled error for url', error, req?.url);
    res.status(500).send('Unhandled error');
    return;
  }
  res.status(error?.statusCode ?? 500).send(error?.message ?? 'Unhandled');
};

@Catch(exceptionHandler)
class SomeHandler {
   ...
}

But it always passes a InternalServerErrorException:

While I throw:
        const exception = new HttpException(401, data?.message ?? 'Unknown');
        throw exception;

or for that matter:
        const exception = new UnauthorizedException( data?.message ?? 'Unknown');
        throw exception;

Expected:
The message is passed through, but the status code is not!
Sometimes I just want to pass through the http status code together with the message 🙏🏻

Hi @icazemier
Can't replicate the issue you're having. Please provide a minimum reproducible repo.

Oh no! I can't reproduce it either on a dedicated project: https://github.com/icazemier/nextjs-api-decorator-catch-all
Let's close this ticket, excuse me for the fuss.


TRANSIENT_RPROMPT is not respected

To reproduce:
docker run -e LANG=C.UTF-8 -e LC_ALL=C.UTF-8 -e TERM=$TERM -it --rm ubuntu bash -uexc '
  cd
  apt update && apt install -y zsh git
  git clone https://github.com/bhilburn/powerlevel9k.git
  echo "
    setopt TRANSIENT_RPROMPT
    POWERLEVEL9K_PROMPT_ON_NEWLINE=true
    source ~/powerlevel9k/powerlevel9k.zsh-theme" >~/.zshrc
  exec zsh'

Then press <enter> a few times.
Expected: right prompt is displayed only for the last (active) prompt.
Actual: right prompt is displayed even for the past prompts.
Note: Adding POWERLEVEL9K_RPROMPT_ON_NEWLINE=true to the config fixes the issue.

Fixed on next with #1335


Not working properly for large strings.

In the run() function of connectedThread in BluetoothChatService.java (around line 493):
                // Read from the InputStream
                bytes = mmInStream.read(buffer);

                // Send the obtained bytes to the UI Activity
                mHandler.obtainMessage(Constants.MESSAGE_READ, bytes, -1, buffer)
                        .sendToTarget();

Try wrapping a stringBuilder around the mmInStream.read() call. When you reach the end of your string (however you've defined this), THEN call mHandler.obtainMessage. You should also check #14 , with regard to using .setData() to initialize the message itself, rather than just initializing by passing a reference to the buffer.


Automatic version updates failing

See: https://github.com/ZOSOpenTools/gmpport/actions
Due to:
buildenv:1: gmp-version: Get "https://gmplib.org/": dial tcp <IP_ADDRESS>:443: i/o timeout

@v1gnesh are you able to take a look?

Yeah, it works from the command-line. Wondering what we can do with this one..


Release only crash

It is working totally fine in development build .It ia all working when i even do react-native run-android --variant=release but the app crashes only in release builds

Please provide versions of everything, a crash stack trace, and ideally a link to your github repo so we can reproduce it

crash traces are still useful - if you say it crashes, seeing the line in react-native-share where it crashes (or the stack trace that leads to it) would be useful. But I also see that you aren't on the current version of react-native-share so I'm not sure how to support it
I will say - maybe totally unrelated - that crashes between dev and release for me were typically caused by bundling errors where differences between the metro bundler and webpack were exposed. There was a big problem with that if you moved gradle from 3.1.x to 3.2.x https://github.com/facebook/react-native/issues/18357 if you don't have react-native 0.57.2 (I think?) or higher because gradle changed asset locations.
There's no reason in general that there should be a difference in behavior with react-native-share between dev and prod though

I just noticed the same behaviour. Also very urgent problem for me. Released to TestFlight and all the sudden share is not working.
I will look this more on tomorrow but I noticed that when sharing Whatsapp and Facebook Messenger the share component crash. Sharing with text message or email is not crashing (some proplems with them also but not sure they are related to this).
And everything was working fine when testing with debug-build with xcode and test-device.

sorry for late reply, @mikehardy  i am unable to get stack trace because it is correctly working in development build and release build when run through --variant=release but it only crashes when installed through apk

@keshamtravels could you try running with logcat?
adb logcat

Same case, please if you get a resolution for this, share here 👍

@loubacking I did find one solution that fixed the problem for me, but it doesn't explain any core reason.
I also use react-native-image-crop-picker in my project and there is an new issue with resizing to given width and height in iOS (I am resizing to 1024x1024).
https://github.com/ivpusic/react-native-image-crop-picker/issues/843
So I added back @leomercier suggestion there and also the share started to work again. So you might want to check if pictures with resolution 1024x1024 are working with you?

Well i installed the newest version of rect-native share
then a problem of cl.json occured which i solved using
https://github.com/react-native-community/react-native-share/issues/200#issuecomment-361938532

ant then it worked


Add chocolatey install method

[ x ] Tested that Flux deploys on windows with minikube based instance
[ x ] ran flux check
website> flux check
► checking prerequisites
✔ kubectl 1.21.0 >=1.18.0-0
✔ Kubernetes 1.20.2 >=1.16.0-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.11.2
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v0.13.3
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v0.15.1
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v0.15.4
✔ all checks passed
website>

Other notes - reach out to the person maintaining the chocolatey package to see if we can move the package file to flux org

Thanks @alisondy !! 🎉


Update the solution to capture and store AWS account ID sent via ResolveCustomerAPI

Is your feature request related to a problem? Please describe.
AWSMP released an update to ResolveCustomer API. Customer AWS account ID is shared in the API response. Please update the solution to capture and store AWS account ID.
Doc for reference: https://docs.aws.amazon.com/marketplacemetering/latest/APIReference/API_ResolveCustomer.html#API_ResolveCustomer_ResponseSyntax

Fixed in #48. This issue can be closed.


Update to use cloudflare storage of corpus zip

Changes:

Download files in parallel (to help speed things up, esp. on the k8s cronjob that updates and uploads the zip)
Support downloading the zip file from the new cloudflare system, rather than gdrive
Remove some old code

To test:
$ pipenv install
...
$ pipenv run python -m allofplos.update
...

It should download the zip file
Not enough articles in /home/egh/c/allofplos/allofplos/allofplos_xml, re-downloading zip file
Creating folder for article xml
...

Check that it's connecting to cloudflare:
🤔 ps -fade |grep allofplos
egh       871858  842183 15 21:50 pts/1    00:01:06 /home/egh/.local/share/virtualenvs/allofplos-F990z4Rq/bin/python -m allofplos.update
🤔 sudo lsof |grep 871858 |grep TCP
python    871858                               egh    4u     IPv4            4334030        0t0        TCP ehetzner-thinkpad-t470.lan:48522-><IP_ADDRESS>:https (ESTABLISHED)
python<PHONE_NUMBER>72 python                 egh    4u     IPv4            4334030        0t0        TCP ehetzner-thinkpad-t470.lan:48522-><IP_ADDRESS>:https (ESTABLISHED)
🤔 dig +noall +authority -x <IP_ADDRESS>
67.172.in-addr.arpa.	1215	IN	SOA	cruz.ns.cloudflare.com. dns.cloudflare.com.<PHONE_NUMBER> 10000 2400<PHONE_NUMBER>

LGTM


Bug: Mux React Player is not playing the video on iOS Safari 16

Is there an existing issue for this?

[X] I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply
mux-player-react
Which browsers are you using?
Safari
Which operating systems are you using?
macOS
Description
The issue is on iOS Safari 16, the video is just a black screen when you try to play it.
I've confirmed that it works on iOS Safari 17 though.
I am using Next.js 14.0.4 and am Mux 2.3.2 and Tailwind 3.3.0.
I am also using it in conjunction with the Carousel from Embla (I have a carousel of pictures and a video).
The video will play (you can hear the music) but the screen will be black.
Is there a setting that needs to be done for Safari?
My video asset was uploaded on Mux with baseline 1080p and I am using the playbackID from there. I have no extra settings on it.
Here's a snippet of my code and how I'm using it:
<div
      id="product-video"
      className="flex flex-col lg:my-4 lg:flex lg:h-[500px]"
    >
      <MuxPlayer playbackId=""  /> // I removed it

Reduced test case
No response
Steps to reproduce
I will try to get a code pen up but there's not much to it.

Current Behavior
On Safari 16 there will be a black screen and the video ready to play. When I hit the Play button, it's still black but the video is going (you can hear the audio)
On Safari 17, it's the same, but the video will play.
Expected Behavior
The video will play
Errors
No response
What version of the package are you using?
v2.3.2

@devwilliamy do you have a test app where this is deployed or a codesandbox that reproduces the issue?

@devwilliamy is this in the iOS simulator?
related https://github.com/muxinc/next-video/discussions/168

This one was for this one: https://github.com/muxinc/next-video/discussions/155#discussioncomment-8383460
I was using this sandbox: https://codesandbox.io/p/devbox/next-video-mux-j9nn73?file=%2Fapp%2Fpage.js%3A21%2C1
I have videos in there too (sorry just noticed it seems a little choppy but you can see that the iPhone 14 on iOS 16.4 is black (it's just black when it plays though)


Expose extraction module publicly

It's currently impossible to define custom sorts outside of egglog due to the fact that types like Extractor and Cost aren't exposed. This PR fixes this by exposing extractor module.
The module is already using pub and pub(crate) in all the right places. I do wonder however if costs field of the Extractor needs to be public

Is there some way to make Rust to tell us about issues like this? I thought it would make a warning if something had lower visibility than required. Is the Sort trait not public enough?

Sort is public and can be referred to outside of the crate. However, one of the methods in Sort uses Extractor type that is not accessible outside of the crate. This type itself is public, but the module it is defined in isn't, so egglog consumers can't use the type and hence can't use this trait.
Rust compiler has a lint called unreachable_pub that complains if pub item isn't reachable from outside of the crate. It is allow by default due to false positives, but perhaps enabling it wouldn't be a big deal for egglog. I will have a look.

Okay, the lint works, and it finds a lot of errors, but surprisingly it thinks Extractor is reachable somehow? I can't figure out how though - it doesn't even show up in rustdoc output!


Laravel 8.71.0 Shift

This pull request includes updates for the recent minor version release of Laravel as well as updates to your package dependencies. Feel free to commit any additional changes to the shift-ci-v8.71.0 branch.
Before merging, you need to:

Checkout the shift-ci-v8.71.0 branch
Review all pull request comments for additional changes
Run composer update
Thoroughly test your application (no tests?, no CI?)

:information_source: The following Laravel packages were updated as they are known to be compatible with Laravel 8.71. Nonetheless, you should review the CHANGELOG to ensure no additional changes are needed.

[ ] thujohn/twitter

:warning: The Shift build servers run PHP 8. If you are still running PHP 7.4 or lower you should run composer update locally to ensure you have the proper versions of your dependencies to reflect your PHP 7 environment.


UPDATE: install spyder from git instead of hg

the spyder project migrated to GitHub

should be a no-brainer, @wronk

Indeed they did. Hope that was ready for merge... it just looked so simple I couldn't help myself.

no worries.  there was no "WIP" and indeed nothing more to be done.
On Tue, Jul 28, 2015 at 10:27 AM, Eric Larson<EMAIL_ADDRESS>wrote:

Indeed they did. Hope that was ready for merge... it just looked so simple
I couldn't help myself.
—
Reply to this email directly or view it on GitHub
https://github.com/LABSN/new-computer-setup/pull/15#issuecomment-125685248
.


Lost title color after HA update

Hello!
After updating HA Green to the latest version, the color in the title is missing

Core 2024.12.1
Supervisor 2024.11.4
Operating System 14.0
Frontend 20241127.6

Expected title:

Core 2024.9.1
Frontend 20240906.0

Can you please check this? Thank you

Updated the colors in the theme. Should be working now.

Yes, thank you 👍


Add samples structure

We need to add the structure for the sample code so that people can start adding compilable sample code.

@richlander @BethMassi @blackdwarf because there is a requirement that samples be compilable projects, this leaves us a decision -- do we accept Visual Studio projects, non-VS projects, or both?
I'm leaning towards accepting both, but preferring purely folder-based, CLI projects.

Talked with @BethMassi and we decided to require these samples to be cross-platform, which means no Windows or Visual Studio dependencies.

So are we talking about a .cs file with a project.json that could be ran using dnx? Or just the .cs file?

project.json and the cs file. @cartermp is working on the first sample so we have an example.

Great, I like that better than having solution files and adding to the complexity.

I added a stub that should give you an idea of what it would look like (pending merge, but should give an idea).

Great! Thank you.

On Nov 2, 2015, at 6:44 PM, Phillip Carter<EMAIL_ADDRESS>wrote:
I added a stub that should give you an idea of what it would look like (pending merge, but should give an idea).
—
Reply to this email directly or view it on GitHub.

@matthewreily the structure is in place!  You should be able to write some awesome samples now.

Thank you sir and also thanks to @BethMassi!  I'm attending a conference
today but will start at it tomorrow.
On Tue, Nov 3, 2015 at 1:34 PM, Phillip Carter<EMAIL_ADDRESS>wrote:

@matthewreily https://github.com/matthewreily the structure is in
place! You should be able to write some awesome samples now.
—
Reply to this email directly or view it on GitHub
https://github.com/dotnet/core-docs/issues/91#issuecomment-153463766.


Result view disappears when switching tabs

Issue Type: Bug

Run query in a tab that returns a result that is displayed in the "RESULTS" pane.
Do anything that opens a new tab, such as "New Query" or "Manage" or select an existing tab.
Switch back to the original tab.

Expected Result:  Tab should remain exactly as it was before switching focus away from it.
Actual Result:  The "RESULTS" pane on the original tab is now hidden or closed, requiring to run the query again to see results and losing any scroll position.
Version 0.33.3-insider
Commit 72084b8fc17494d9e946d2ea5926a4c7a9e71c4a
Date 2018-09-12T05:21:18.454Z
VS Code 1.26.1
Shell 2.0.8
Renderer 61.0.3163.100
Node 8.9.3
V8: 6.1.534.41
Architecture x64

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2904)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.74GB (19.65GB free)

Process Argv
C:\Program Files\SQL Operations Studio\sqlops.exe

Screen Reader
no

VM
67%

Extensions (8)

Extension
Author (truncated)
Version

firstresponderkit
dre
0.1.0

mssql-db-insights
mat
0.2.2

agent
Mic
0.32.7

import
Mic
0.1.0

profiler
Mic
0.1.5

server-report
Mic
0.1.3

whoisactive
Mic
0.1.1

sql-search
Red
0.2.1

I believe this may be related to #2476 with the Messages pane.  I think it may be that the messages pane is resizing itself over the top of the results pane and running the query again forces both panes to layout again.  Not 100% sure but I have a sneaking suspicion.

@anthonydresser could you please look at this issue today?

Currently am, I see what the problem is just trying to find a good answer 🙃


[camera] Added support for flash/torch mode in iOS and Android

Description
This PR implements the ability to toggle torch mode on/off in iOS and Android. You can use this to run the camera's flash continuously as a torch and can use it as a flash for photo capture (by turning it on/off before/after your capture), and during video capture as a continuous light.
It adds the following new methods to the CameraController:

Future<bool> hasTorch()
Future<void> disableTorch()
Future<void> enableTorch()

It has been tested on an iPhone 8 running iOS 13 and a Pixel 4 running Android 29. It works during video and photo capture as well. The example app has been updated with a new toggle switch for enabling/disabling the torch. The toggle switch will be disabled (20% opacity and non-interactive) if the current selected camera does not support torch mode.
Related Issues
Closes https://github.com/flutter/flutter/issues/66252
https://github.com/flutter/flutter/issues/31225
https://github.com/flutter/flutter/issues/58218
https://github.com/flutter/flutter/issues/57307
https://github.com/flutter/flutter/issues/54548
https://github.com/flutter/flutter/issues/41785
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Unfortunately on Android it doesn't work properly because you don't handle the precapture measurements. The photos on Samsung S8 are oversaturated.

After looking at https://github.com/gummie4444/flutter-better-camera where they did do the proper flash implementation, that is definitely way outside of the scope of what I wanted to accomplish here.

Yeah, and I tried to improve on that but frankly there are some edge cases like some LG or Huawei phones that still work differently than what you'd expect

After looking at https://github.com/gummie4444/flutter-better-camera where they did do the proper flash implementation, that is definitely way outside of the scope of what I wanted to accomplish here.

Yeah, and I tried to improve on that but frankly there are some edge cases like some LG or Huawei phones that still work differently than what you'd expect

I think all we can do is follow the Android API docs and implement it to that spec, and if any phone manufacturers don't implement the API correctly then there isn't much we can do about it.

@acoutts Huge thanks for putting this out. Really looking forward to seeing this in action, there's a lot of interest in the Flutter community for shipping this feature.

@bparrishMines is there anything I can do to help speed this along for merging?

@bparrishMines is there anything I can do to help speed this along for merging?

İf you want check this library for focus and many flash attributes: https://github.com/react-native-community/react-native-camera/tree/master/android/src/main/java/com/google/android/cameraview

@bparrishMines is there anything I can do to help speed this along for merging?

İf you want check this library for focus and many flash attributes (you can find ios part on the main section):
https://github.com/react-native-community/react-native-camera/tree/master/android/src/main/java/com/google/android/cameraview

For the scope of this PR I do not want to do anything else except torch mode like I've done here.

@ghunkins do you know anyone I can tag here to get this reviewed / merged? Seems like it is not maintained so far..

Tagging reviewers on #1969 here to hopefully bring this across the finish line. Can anyone please add themselves to help review and merge this?
@orestesgaolin @JoseGeorges8 @GustavoFigueira @VictorAlves @cyanglaz @mklim  @mehmetf  @bparrishMines . Thanks in advance! cc: @acoutts

As a user of the plugin I wouldn't like to see this feature implemented without proper handling of precapture measurements. It wasn't tested on variety of devices and I know that there are slight differences across manufacturers that will cause the output images to look incorrectly.
Merging this to the plugin repo would mean that now the Flutter team would have to handle all the issues related to this implementation and I guess they won't be investing into that in the nearest future. Sorry to say that, but I suspect that this PR won't land in the repo as there was no interaction from the team at all.

As a user of the plugin I wouldn't like to see this feature implemented without proper handling of precapture measurements. It wasn't tested on variety of devices and I know that there are slight differences across manufacturers that will cause the output images to look incorrectly.
Merging this to the plugin repo would mean that now the Flutter team would have to handle all the issues related to this implementation and I guess they won't be investing into that in the nearest future. Sorry to say that, but I suspect that this PR won't land in the repo as there was no interaction from the team at all.

Is it so difficult to add flash support to the camera library? Really !!?

As a user of the plugin I wouldn't like to see this feature implemented without proper handling of precapture measurements. It wasn't tested on variety of devices and I know that there are slight differences across manufacturers that will cause the output images to look incorrectly.
Merging this to the plugin repo would mean that now the Flutter team would have to handle all the issues related to this implementation and I guess they won't be investing into that in the nearest future. Sorry to say that, but I suspect that this PR won't land in the repo as there was no interaction from the team at all.

Just to reiterate, torch mode != flash mode. While you can indeed get by using the torch as a flash by simply turning it on/off before capturing an image, torch mode is simply the flash running constantly. The primary use case is when you need the flash turned on for the camera preview, such as for scanning QR codes, or really if you just want to build a simple flutter flashlight app.
I do hope someone can add the proper flash mode in the future for image capture, but I simply want to get torch mode merged here. Let's not hold it up for something outside of the scope of the original PR.

Hello is anyone out there?

cc @TahaTesser do you know anyone that can take a look at this?

cc @TahaTesser do you know anyone that can help take a look at this? Seems like there's been no activity on this plugin for the last month..

The Flutter team is making efforts to avoid this feature :)

@acoutts Thanks for the contribution, is there any example code of what you did? I'd like to use the code in your branch until it gets merged.

@acoutts Thanks for the contribution, is there any example code of what you did? I'd like to use the code in your branch until it gets merged.

You can see the files changed tab here and it will show the diff of this PR:
https://github.com/flutter/plugins/pull/2837/files
As for how to use it, that is as simple as calling await controller.enableTorch(); on the camera controller now.

cc @cyanglaz
Hi @acoutts
Thanks for the contribution! Unfortunately, this feature is non-trivial and we don't have anyone focused on adding new features to this plugin at the moment. We typically follow issue hygiene when prioritizing issues and PRs. We'll keep this on our radar, but I can't give a time frame when we'll be able to work on it.
Everyone is also free to use this PR by adding a git dependency to their pubspec.yaml.

Hello, could you help me on how do I use this PR on my project? I don't know how to import it in my pubspec.yaml file, I have used by copying your code and it's working really well, thanks for that PR by the way, you saved my life :D hope the Flutter community accept your this PR soon.

Thanks for the contribution! Unfortunately, this feature is non-trivial and we don't have anyone focused on adding new features to this plugin at the moment.

I'm a little confused. Is camera is no longer supported?

hmmmm

Hi @acoutts
I edited your OP to add https://github.com/flutter/flutter/issues/66252
Let me if you know disagree
Thank you

I appreciate the effort done to get this done, but I think a camera plugin without the option to use the flash/lamp is kinda weird. I think this is a critical feature that the plugin should have...
Is the PR code stable enough for use in a production APP or should we wait until it's merged?

Hi @acoutts
I edited your OP to add flutter/flutter#66252
Let me if you know disagree
Thank you

Thanks!

I appreciate the effort done to get this done, but I think a camera plugin without the option to use the flash/lamp is kinda weird. I think this is a critical feature that the plugin should have...
Is the PR code stable enough for use in a production APP or should we wait until it's merged?

It's been stable enough for me to use without issue so far since I created this PR months ago.

I appreciate the effort done to get this done, but I think a camera plugin without the option to use the flash/lamp is kinda weird. I think this is a critical feature that the plugin should have...
Is the PR code stable enough for use in a production APP or should we wait until it's merged?

It's been stable enough for me to use without issue so far since I created this PR months ago.

Okay, thanks! I will give it a go and if no issue arises I will make use of it. In case I find any weird behavior or bug I will let you know.
I will be keeping an eye on this, let me know if I can do anything to get this moving quicker.

I appreciate the effort done to get this done, but I think a camera plugin without the option to use the flash/lamp is kinda weird. I think this is a critical feature that the plugin should have...
Is the PR code stable enough for use in a production APP or should we wait until it's merged?

It's been stable enough for me to use without issue so far since I created this PR months ago.

Okay, thanks! I will give it a go and if no issue arises I will make use of it. In case I find any weird behavior or bug I will let you know.
I will be keeping an eye on this, let me know if I can do anything to get this moving quicker.

Unfortunately this plugin is not being updated for new features, so I would suggest looking to this community one for something more actively maintained: https://pub.dev/packages/camerawesome

Nice thanks a lot! I will check that out. It's a shame it's not supported in the official plugin though 😐

I have tested this on about 7 devices. There seems to be some oddities upon taking a photo, where the torch on the device flashes while taking a photo, causing the image to be under exposed.
This happens on every device I have tested so far but only seems to affect some (e.g. Samsung A71 running Android 10).
The best test of this is if you are in a completely dark environment you can see the preview is fully lit, however the photo that comes out of the 'takePicture' function comes out completely black.

Closing this PR in favor of #3314

Description
This PR implements the ability to toggle torch mode on/off in iOS and Android. You can use this to run the camera's flash continuously as a torch and can use it as a flash for photo capture (by turning it on/off before/after your capture), and during video capture as a continuous light.
It adds the following new methods to the CameraController:

Future<bool> hasTorch()
Future<void> disableTorch()
Future<void> enableTorch()

It has been tested on an iPhone 8 running iOS 13 and a Pixel 4 running Android 29. It works during video and photo capture as well. The example app has been updated with a new toggle switch for enabling/disabling the torch. The toggle switch will be disabled (20% opacity and non-interactive) if the current selected camera does not support torch mode.
Related Issues
Closes flutter/flutter#66252
flutter/flutter#31225
flutter/flutter#58218
flutter/flutter#57307
flutter/flutter#54548
flutter/flutter#41785
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x]  I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x]  My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x]  All existing and new tests are passing.
[x]  I updated/added relevant documentation (doc comments with ///).
[x]  The analyzer (flutter analyze) does not report any problems on my PR.
[x]  I read and followed the Flutter Style Guide.
[x]  The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x]  I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x]  I updated CHANGELOG.md to add a description of the change.
[x]  I signed the CLA.
[x]  I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ]  Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x]  No, this is not a breaking change.

how to use your branch in a flutter project?

Description
This PR implements the ability to toggle torch mode on/off in iOS and Android. You can use this to run the camera's flash continuously as a torch and can use it as a flash for photo capture (by turning it on/off before/after your capture), and during video capture as a continuous light.
It adds the following new methods to the CameraController:

Future<bool> hasTorch()
Future<void> disableTorch()
Future<void> enableTorch()

It has been tested on an iPhone 8 running iOS 13 and a Pixel 4 running Android 29. It works during video and photo capture as well. The example app has been updated with a new toggle switch for enabling/disabling the torch. The toggle switch will be disabled (20% opacity and non-interactive) if the current selected camera does not support torch mode.
Related Issues
Closes flutter/flutter#66252
flutter/flutter#31225
flutter/flutter#58218
flutter/flutter#57307
flutter/flutter#54548
flutter/flutter#41785
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x]  I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x]  My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x]  All existing and new tests are passing.
[x]  I updated/added relevant documentation (doc comments with ///).
[x]  The analyzer (flutter analyze) does not report any problems on my PR.
[x]  I read and followed the Flutter Style Guide.
[x]  The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x]  I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x]  I updated CHANGELOG.md to add a description of the change.
[x]  I signed the CLA.
[x]  I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ]  Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x]  No, this is not a breaking change.

how to use your branch in a flutter project?

@szuwest flash and torch features on Android and iOS is available since version 0.6.3+2 of the camera plugin and is available on pub.dev.  I recommend updating to the latest version 0.6.4+5.

@szuwest flash and torch features on Android and iOS is available since version 0.6.3+2 of the camera plugin and is available on pub.dev.  I recommend updating to the latest version 0.6.4+5.

@szuwest flash and torch features on Android and iOS is available since version 0.6.3+2 of the camera plugin and is available on pub.dev. I recommend updating to the latest version 0.6.4+5.

Thank you, I found it.

@szuwest flash and torch features on Android and iOS is available since version 0.6.3+2 of the camera plugin and is available on pub.dev. I recommend updating to the latest version 0.6.4+5.

Thank you, I found it.


Add Supported OS

(MSI GE70 2PE Apache Pro)
Maybe add another Column for the actual Keyboard/Laptop?

Yeah, Want to send another PR to add the column? (either system or machine)


Remove unused Java import package

Signed-off-by: Aurélien Pupier<EMAIL_ADDRESS>

/remove-lifecycle stale

anyone to review/merge this easy fix?

/assign @aledbf
can you please review this one?

/approve

Thanks!


added editor roles and keywords config

part of https://github.com/elifesciences/peerscout/issues/132

Merge at will.


Add stateful prop builder

StatfulPropBuilder will help in scoping prop changes and make it easier to use StatefulProp inside stateless widget

Good idea, thx! StatefulProps was mostly made to eliminate builders, but can see how this would be useful in some cases.


Incorrect InfoTree for applications

Consider the following snippet (adapted from https://github.com/leanprover/lean4/issues/3462):
def witt := 1

example (n : Nat) : n = n := n wit

This produces the following InfoTree:
• command @ ⟨7, 0⟩-⟨7, 34⟩ @ Lean.Elab.Command.elabDeclaration
  • Nat : Type @ ⟨7, 13⟩-⟨7, 16⟩ @ Lean.Elab.Term.elabIdent
    • [.] Nat : some Sort.{?_uniq.23} @ ⟨7, 13⟩-⟨7, 16⟩
    • Nat : Type @ ⟨7, 13⟩-⟨7, 16⟩
  • n (isBinder := true) : Nat @ ⟨7, 9⟩-⟨7, 10⟩
  • n = n : Prop @ ⟨7, 20⟩-⟨7, 25⟩ @ «_aux_Init_Notation___macroRules_term_=__2»
    • Macro expansion
      n = n
      ===>
      binrel% Eq✝ n n
      • n = n : Prop @ ⟨7, 20⟩†-⟨7, 25⟩† @ Lean.Elab.Term.Op.elabBinRel
        • n = n : Prop @ ⟨7, 20⟩†-⟨7, 25⟩†
          • [.] Eq✝ : none @ ⟨7, 20⟩†-⟨7, 25⟩†
          • n : Nat @ ⟨7, 20⟩-⟨7, 21⟩ @ Lean.Elab.Term.elabIdent
            • [.] n : none @ ⟨7, 20⟩-⟨7, 21⟩
            • n : Nat @ ⟨7, 20⟩-⟨7, 21⟩
          • n : Nat @ ⟨7, 24⟩-⟨7, 25⟩ @ Lean.Elab.Term.elabIdent
            • [.] n : none @ ⟨7, 24⟩-⟨7, 25⟩
            • n : Nat @ ⟨7, 24⟩-⟨7, 25⟩
  • _example (isBinder := true) : ∀ (n : Nat), n = n @ ⟨7, 0⟩†-⟨7, 34⟩†
  • n (isBinder := true) : Nat @ ⟨7, 9⟩-⟨7, 10⟩
  • sorryAx (n = n) true : n = n @ ⟨7, 29⟩-⟨7, 34⟩ @ Lean.Elab.Term.elabApp
    • [.] n : some Eq.{1} Nat _uniq.29 _uniq.29 @ ⟨7, 29⟩-⟨7, 30⟩
    • n : Nat @ ⟨7, 29⟩-⟨7, 30⟩
  • _example (isBinder := true) : ∀ (n : Nat), n = n @ ⟨7, 0⟩-⟨7, 7⟩

In this tree, there is a completion node for n, but not wit, leading to incorrect completions after wit. Instead, this tree should contain a completion node for wit somewhere that the completion can work with.

Ah, this is because elaboration naturally stops after finding out that n is not a function. This could be covered by a general "complete only keywords for Syntax.idents not covered by any completion nodes" fallback; not sure yet what other, positive and negative, impact that would have.

Oops, looks like I messed up the MWE. Updated now.


Dev

Codecov Report

Merging #19 (7b8463e) into main (a371523) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   84.38%   84.46%   +0.08%
==========================================
  Files           9        9
  Lines        1114     1107       -7
==========================================
- Hits          940      935       -5
+ Misses        174      172       -2

Impacted Files
Coverage Δ

src/surface.rs
84.15% <0.00%> (+0.71%)
:arrow_up:

src/model.rs
75.32% <0.00%> (-1.18%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add calibration videos and confirmation code for continued piloting

Refs: https://openscience.atlassian.net/browse/LEI-
Companion to:
Purpose
Summary of changes
Testing notes

I'll go ahead and merge this. I've put in a request to the person in charge of the server to update something that it will need to work, and I'll send you a note when that's ready.
Incidentally, did you and Sam work out a faster way to run through an experiment? It's something of a slow process at the moment. In particular, my completed sessions weren't showing up in staging-experimenter, so I want to be 100% sure that isn't a recurring problem.

Okay, thanks!
To run through the experiment faster, we'd previously been setting MAX_VIDEOS to 4 or so (line 369 of pref-phys-pilot.js) and testLength to 5 s (line 331). It would be much cleaner to make those into properties that could be passed in by the json schema defining the experiment, but I wasn't sure how.
I've previously had trouble with sessions not showing up in experimenter, but don't actually use that feature--I've just been running updates using the code in lookit/scripts in my coding-workflow branch of lookit. I do see sessions showing up right away in the consent spreadsheets we generate.


[flutter_test] Add createTestImageSync() method and add color to createTestImage()

Changes in this PR:

createTestImageSync() method is added for easier use in tests where HTML backend (which doesn't support Picture.toImageSync()) is not required
optional color parameter is added for fill color for both createTestImage () and createTestImageSync()

Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

/cc @jonahwilliams @dnfield

What is the goal of exposing createTestImageSync? Almost all of the testing APIs are already async

@jonahwilliams Once one starts dealing with images in widgets, this method is very handy in widget tests. But since it involves real async work, in widget tests it needs to be put under runAsync. The sync version avoids that so it becomes a short one-liner. More of a nice to have thing for developers, no change in the use given in the existing framework tests.

The createTestImage isn't especially useful for real applications AFAICT - it's meant to help with testing things like image providers and image streams.
This PR is suggesting adding new API that doesn't even get used in the patch - so the new API is not tested.
This adds code to this repository that will have to be maintained, and it's really not clear who will use it or why.
Also, the synchronous version of this API does actually do multithreaded work, and anything you would call that actually touches the pixels will end up needing runAsync logic (e.g. calling toByteData).
There is no issue filed, so it's not even clear what problem this is actually trying to solve or who is being impacted by it.
Finally, this type of utility could easily be created in a package if it suits your particular needs, without requiring maintenance or additional API surface in package:flutter_test.


docs: add HACKING.md

Types of PR

[x] New Features
[ ] Upgrade of existing features
[ ] Bugfix

Link to the issue
Description
Add HACKING.md
How to review this PR.
Others

sorry to be late and thanks for formatting!


Add basic error handling around wsConnTuple.

The existing wsConnTuple makes some use of !! which I avoid.  Death to partial functions!
Here I've introduced some basic error-handling around that by using Either String, which just lets me carry around a simple informative string in the bad case.
Often you'd want to introduce a new data type for errors, i.e.
data Error = InvalidUrl | ...

and then use Either Error, with associated Show or other pretty-printing instance for the error type.  But for simplicity Either String works fine.  The result is that someFunc has to deal with the bad case explicitly.
You could also clean this up a bit by using EitherT String IO (String, String).
I also simplified just a couple of cases where you could get away with a single return, instead of two.

I also added another commit here that just cleans up the code around sendMessages by using traverse_.  traverse and friends are useful to know; when specialized to lists their signatures look like this:
traverse  :: Applicative f => (a -> f b) -> [a] -> f [b]
traverse_ :: Applicative f => (a -> f b) -> [a] -> f ()

They're both useful for mapping an effectful function over a container - the latter case where you don't actually need the results, just the effects.
traverse f xs == sequence (map f xs)

There are even flipped versions of traverse and co., except with more familiar names. :smile:
for xs f  == traverse f xs
for_ xs f == traverse_ f xs

didnt know about (or remember) void. that's tight.


internal/dinosql: strip leading "go-" or trailing "-go" from import

If I try to import from a package named "go-x" or "x-go" it will
generate a syntax error. We should do the right thing and determine
what the package name is and set it to that, but in lieu of that,
a good guess for the import name is just stripping that prefix or
suffix.
Updates #261.

We should do the right thing and determine what the package name is and set it to that

Agreed

A good guess for the import name is just stripping that prefix or suffix

Also agreed.


fix: remove empty glob in spdlog BUILD file

There are no .cc files in the include directory of spdlog, so the pattern is not matching anything and the module does not work when --incompatible_disallow_empty_glob is set. This commit removes that pattern from the injected BUILD file so this does not happen.

I need to change the subresource integrity hash too, converting this PR to a draft meanwhile

Existing versions are immutable, this needs to be fixed in a new version.

@fmeum oh okay, so in case there were no newer releases of the software itself it wouldn't be possible to fix anything in the BCR? I'm closing this PR then, and hoping it gets fixed on #1206

you can upload a new version that only changes files in the BCR and make it 1.11.0.bcr.1


Initial functionality

🗣 Description
This PR covers the initial functionality required to generate an Assessor Portal AMI that can be used in the COOL.

💭 Motivation and context
This PR is an important part of the work required for https://github.com/cisagov/cool-system/issues/202 and it depends on https://github.com/cisagov/ansible-role-assessor-portal/pull/3.
Note that since the Assessor Portal requires several gigabytes of Docker images to function, those Docker images are pulled in as part of the construction of this AMI (see https://github.com/cisagov/assessor-portal-packer/pull/1/commits/c7a3e80b8240d8a467e85dda7cfaf13a11ef0253, https://github.com/cisagov/assessor-portal-packer/pull/1/commits/90b76b5905fd8224027bf46928352320f5e437ee, and https://github.com/cisagov/assessor-portal-packer/pull/1/commits/a2119926505aaa36fd8023a035036e318debc5da).  This is mainly to avoid having to fetch those Docker images every time a fresh Assessor Portal instance is deployed.

🧪 Testing
This AMI was tested in conjunction with https://github.com/cisagov/cool-assessment-terraform/pull/130, which adds support for these Assessor Portal instances.
Testing confirmed all of the following:

[x] An Assessor Portal instance could be successfully deployed into the COOL
[x] The Assessor Portal web application could be successfully started and accessed locally from a browser on the Assessor Portal instance
[x] Multiple Assessor Portal instances could be successfully deployed in the same COOL assessment environment
[x] An operator on one Assessor Portal instance could NOT access a running Assessor Portal web application on a different Assessor Portal instance
[x] The Assessor Portal web application (once started) could NOT be accessed from any other instances in the COOL assessment environment
[x] The Assessor Portal web application (once started) could NOT be accessed externally via the Internet

✅ Checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] All new and existing tests pass.

Approved, but please create those issues that you mentioned in response to my earlier reviews.

Issues documented in https://github.com/cisagov/assessor-portal-packer/issues/2 and https://github.com/cisagov/pca-gophish-composition-packer/issues/56.


Bluekai parser update

Updated the bluekai parser in order to :

take into account the format changes in bluekai orange data (new columns)
make it possible to use the parser with custom parsing rules and schema

After your review, I :

moved schema as an argument for the parse function
added some verifications of the input schema
moved all client/task-related data to json files

@valentinlehuger The current approach does not necessitates to instantiate a parser. However, the fact that we are now reading data from files may not be appropriate with this approach.
What do you think about moving all the client/task data instantiation in an init function (thus changing the way the parser is used), as we quickly discuss ?
Thanks!


Add method to DynamoDB Stream Event AttribubuteValue to return the proper type for that AttribubuteValue

Is your feature request related to a problem? Please describe.

When attempting to transverse a DynamoDB Stream Event, it would be nice to know the datatype of an AttributeValue so the correct call to get the value could be made.  I.E. string vs list vs map.
Describe the solution you'd like

Add an AtributeValue method that would return the type of value for that attribute.  It would be also nice to have enumerated labels for the types.
Describe alternatives you've considered

We always get all three and test the class.
Additional context

@gwlester I have a PR for this https://github.com/awslabs/aws-lambda-powertools-python/pull/462.
Can you check if this is what you want.

Since the PR got merged -- should this issue be closed now?
Just asking,

@gwlester kind of, us to you ;-). Once it is deployed, maybe you can help validate that it works for you.

@michaelbrewer -- let me know when 1.17.0 is available to deploy!  Thanks again!!!

hey @gwlester this is now available! Added an example in the release notes as well as the docs: https://github.com/awslabs/aws-lambda-powertools-python/releases/tag/v1.17.0
Closing this now as it's already available in PyPi too :)
Thanks a lot @michaelbrewer for the implementation


error with wit.ai

i get the following error on every phrase :
I'm listening
Found audio
Google Speech Recognition thinks you said hello
{"error":"Bad auth, check token/params","code":"no-auth"}
None
Failed wit!
[Errno 2] No such file or directory
Traceback (most recent call last):
File "bot.py", line 102, in decide_action
self.__text_action("I'm sorry, I don't know about that yet.")
File "bot.py", line 154, in __text_action
self.speech.synthesize_text(text)
File "/home/smartmiror/AI-Smart-Mirror/speech.py", line 54, in synthesize_text
song = AudioSegment.from_mp3("tmp.mp3")
File "/home/smartmiror/AI-Smart-Mirror/hhsmartmirror/local/lib/python2.7/site-packages/pydub/audio_segment.py", line 522, in from_mp3
return cls.from_file(file, 'mp3', parameters)
File "/home/smartmiror/AI-Smart-Mirror/hhsmartmirror/local/lib/python2.7/site-packages/pydub/audio_segment.py", line 505, in from_file
p = subprocess.Popen(conversion_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
File "/usr/lib/python2.7/subprocess.py", line 711, in init
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Traceback (most recent call last):
File "bot.py", line 254, in
bot.start()
File "bot.py", line 48, in start
self.decide_action()
File "bot.py", line 109, in decide_action
self.__text_action("I'm sorry, I couldn't understand what you meant by that")
File "bot.py", line 154, in __text_action
self.speech.synthesize_text(text)
File "/home/smartmiror/AI-Smart-Mirror/speech.py", line 54, in synthesize_text
song = AudioSegment.from_mp3("tmp.mp3")
File "/home/smartmiror/AI-Smart-Mirror/hhsmartmirror/local/lib/python2.7/site-packages/pydub/audio_segment.py", line 522, in from_mp3
return cls.from_file(file, 'mp3', parameters)
File "/home/smartmiror/AI-Smart-Mirror/hhsmartmirror/local/lib/python2.7/site-packages/pydub/audio_segment.py", line 505, in from_file
p = subprocess.Popen(conversion_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
File "/usr/lib/python2.7/subprocess.py", line 711, in init
errread, errwrite)
File "/usr/lib/python2.7/subprocess.py", line 1343, in _execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
on magic mirror it says : "I'm sorry, I couldn't understand what you meant by that"

Your token should be passed along with the word "Bearer"

Sorry pasted not passed in the file

I seem to having the same issue, I have done the correct pasting. Seems to be a Wit.Ai issue.


Updating golang version

Pull Request Test Coverage Report for Build 6061

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.794%

Totals

Change from base Build 6051:
0.0%

Covered Lines:
9757

Relevant Lines:
10721

💛  - Coveralls


An event was found but no note was found there

I created a chart file to play on Beatstar. When I encrypted the chart file, it noticed "an event was found at offset 76256, but no comments were found". Therefore, I checked my chart file and found that offset 76256 does not exist, final offset was 64248 and length was 456, offset 76256 I couldn't find it anywhere, please help me

Closing for inactivity


Use of Assembly.Location makes this incompatible with single file EXEs

For a project I am working on, I was interested in trying out the single file EXE.  Unfortunately, due to the use of Assembly.Location in at least one spot (which is incompatible with single file EXEs) causes the application to hang indefinitely while attempting to build the project out of process.
The output of the ProcessRunner shows the logger switch causes the build to fail, and apparently never return:

Of course, the workaround is to not do a single file EXE, but the single file feature is quite nice.

I haven't worked with the single file EXE too much yet, but I wonder if there is a way to access the bundled (?) assembly via some "path".  Or alternatively, extract a single bundled assembly.   I haven't tested anything out yet, though.

Unfortunately, assembly loading can be tricky and the location of the logging assembly could be in a few places depending on platform, delivery, etc. That's why Assembly.Location works well here - it lets the code completely ignore how the logging assembly is linked and from where and relies on the runtime to do that and supply the information. It's probably possible to embed the logging assembly directly in the Buildalyzer NuGet kind of like an unmanaged library instead of relying on a transitive dependency to bring it in, and then we might be able to find it using NuGet APIs or some other mechanism.
All of that sounds like a non-trival amount of work and testing for a feature that's non-critical though. It's not that I'm opposed to the idea, it's just that priority-wise it falls pretty low on a list that I'm already struggling (and mostly failing) to keep up with.
TL;DR: I'd probably accept a PR as long as I had confidence it wouldn't create more problems down the road or on other platforms, but I'm unlikely to work on this myself.

I wouldn't be offended if you just want to close this issue. I spent a little time trying to find a good way to do this and it just seems overly complicated for the simple workaround of "don't deploy as single file". Maybe some future advancements in single file deployments would make worth revisiting later.

I'll close the issue for now given I'm unlikely to have the bandwidth for much further exploration, but if you (or anyone else) ends up with new information or a workaround, I'd be happy to reopen it.


Update minimum supported compiler versions for major release 4.0

Currently, the oldest supported compilers are VS2013, GCC 4.6 and Xcode 6.4 for Windows, Linux and Mac platforms respectively. Because of this,

Certain features of C++11 aren't yet implemented in these compilers (or buggy) - "using" isn't implemented in GCC 4.6, "constexpr" isn't implemented in VS2013.
Certain C++14 features, which will make the codebase more expressive, can't be taken advantage of - like generic lambdas, generic capture, decltype(auto)

For the next major release (4.0), we should consider updating the minimum supported compiler versions.
( A possible criterion is full C++11 compliance and partial C++14 compliance. For example, switching to VS2015, GCC 4.9.x, Xcode 8.0 satisfies this, as well as addressing the two bullets specified above. However, the criterion will be formalized later)
More information: http://en.cppreference.com/w/cpp/compiler_support

During our monthly meeting, we agreed on the following decision on the absolute minimum compilers supported: (the criterion is full core C++14 compliance)
https://github.com/ksubramz/CppMicroServices/blob/min_compiler/minimum_supported_compilers.md


Add new Torrent Update

The last torrent blockchain update file is more then 3 month old - needs update.

Added a new update torrent - needs testing

TODO: When local testing with torrent was positive - ask community over twitter to help seeding the torrent.

My raspiblitz is sitting on a 1Gbit upload connection here and I would be happy to help with seeding. Can I use the raspi-internal torrent client for this? If so, please point me to some instructions.

@kilrau moved the torrent seeding feature to the v1.2 release .. you can subscribe to this issue, to get an info on updates: https://github.com/rootzoll/raspiblitz/issues/24

Done, thx!

OK - new Torrent Update File is tested and works. Opening a new issue to ask people seeding. Closing this issue.


fix: remove redundant ArtsyKeyboardAvoidingView

This PR resolves []
Description

Remove redundant ArtsyKeyboardAvoidingView component - we already use it in the EditSavedSearchAlert.tsx and this is enough :)
Slack thread with links
Android and iOS issue - both are fixed by this PR

before
after

PR Checklist

[x] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix odd floating button bug on the Create Alerts modal -daria

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix odd floating button bug on the Create Alerts modal -daria)

  Generated by :no_entry_sign: dangerJS against 8e8f7cfcca5bcc33f7e169f17fbd7a90356e629f


Update GitHub description from 'An utility' to 'A utility'

Just a small thing. :)

Changed, thanks @RichardLitt!


highmaps drilldown click event not firing

UPDATE
got this working, had to do all the property settings on all avail mapdata things in my config, not just the main one.
I set this in my chart config
 options: {
            chart: {
                events: {
                    drilldown: function (event) {
                         console.log(event);
                    }
                }
            },

But the drilldown event does not seem to fire. Replacing drilldown with click captures clicks outside of map area, but that won't do what I need.
I do have modules/drilldown.js loaded up as well. Any help or hints appreciated.
thanks

Same for me any update about this bug ?

same for me. Any update? @ragefuljoe Could you please attach a jsfiddle for your update? Appreciate your help.

I used a service to generate chart config objects, here's what I have for maps:
https://gist.github.com/ragefuljoe/fa642ab632f6787d20a127720d65caa5

Same for me - drilldown and drillup events are not firing


43 is not supportted

Although the following MSISDN is valid, I am getting notvalid number error. When I change the MSIDN number by adding "00" as prefix  like "00436642161003" it works fine,
Although for other countries such as 90, 1 ,49 I can pass MSISDN number without 00 prefix and it works properly, Why I need to add 00 for the country 43.
Howver when I have appied same logic (adding "00" as prefix) for the USA number I am gettibg invalid number. So my workaround solution is not properway
  // Check msisdn valid?
  PhoneNumberUtil phoneUtil = PhoneNumberUtil.getInstance();
  PhoneNumber number = null;

  String msisndn = "436642161003";
  String region = "AT";

  System.out.println(phoneUtil.getCountryCodeForRegion(region));
  try {
     number = phoneUtil.parse(msisndn, region);
  } catch (NumberParseException e) {
     e.printStackTrace();
  }

  System.out.println("RegionCode valid:" + phoneUtil.isValidNumber(number));

Hi,
We parse numbers in national or international format, so either you need to format the number in national format (without the country code) and supplying the region, or you need to format it in international format, for this you need to either add the international prefix or '+' in front of the country code.
For your example to parse properly you either need to call with:
msisndn =<PHONE_NUMBER> (national format) or
msisndn = +436642161003 (international format, works for all countries) or
msisndn =<PHONE_NUMBER>1003 (international format, works if region = Austria)
"436642161003" doesn't work because we interpret it as a national number, and for this example it isn't valid. For other countries, numbers starting with the same digits as the calling code might be valid, which is why it works in some cases (however, it won't be the number you expected, if your example passed it would be the number +43 43664...).
"00" isn't the international prefix for US, "011" is, therefore appending "00" wouldn't work if region = US
The easiest way to get it to work is appending '+' if you know it's in msisdn format.

I have added + at the beginning of MSISND, and tested two cases, here is the results and what I was expecting..
String msisndn = "+178095257XX";
String region = "US";
phoneUtil.isValidNumberForRegion(number,region));  return false;   // I am expecting it returns true,
phoneUtil.isValidNumber(number)  return true;
String msisndn = "+178095257XX";
String region = "TR";
phoneUtil.isValidNumberForRegion(number,region));  return false;
phoneUtil.isValidNumber(number)  return true;   // I am expecting it returns false,

Hi,
The reason the number is not valid for region US is that it's a Canadian number, not a US one.
And I'm not sure why you're expecting the two equal calls to isValidNumber(number) to return different things?
You can use our demo to try numbers out: http://libphonenumber.appspot.com/

Thanks, sorry it was my fault. I want to know somethinf else
How ofter your library updated once new operator comes in live.

Our library is updated continuously, we are however dependent on getting good information. We try to address bug reports within a week, if you create a pull request yourself it might go in quicker.
The jar (and binary data files) is released once or twice a month, but you can build them yourself.
For questions rather than bug reports please use our mailing list<EMAIL_ADDRESS>(https://groups.google.com/forum/#!forum/libphonenumber-discuss)


Typescript code to integrate TestRail

I'm unable to integrate with TestRail by using this api, I have written code by using TypeScript. Kindly provide a sample code for addRun, getTests, getRun etc.

I have never used TypeScript so I don't know what you need to do to run this with it. You may have to create types for each object that is returned. I am not sure. Here are some places to start looking into answers:
https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/Modules.md#working-with-other-javascript-libraries
https://stackoverflow.com/a/26505153/2249725

I'm unable to call a javascript function (like addRun, getCase, addCase etc..) from typescript code.
If possible please provide the input for this

This is a vanilla JavaScript package. If you want to use it in typescript you have to figure out how that works.