HDFS-17158. Show the rate of metrics in EC recovery task.

JIRA: HDFS-17158. Show the rate of metrics in EC recovery task.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 36s

trunk passed

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 24s

trunk passed

+1 :green_heart:
shadedclient
40m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
40m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
238m 29s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

393m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5947

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5ff32414e9c2 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 43fa8f9d5a66d97c084c0e177872382662a308d2

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/1/testReport/

Max. process+thread count
2468 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 51s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 28s

trunk passed

+1 :green_heart:
shadedclient
41m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
40m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
238m 29s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

393m  4s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5947

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6720bf461b1f 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3fac74d6f63ecd8c9e2d0abb46afa305c8989e7c

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/2/testReport/

Max. process+thread count
2247 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m  7s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
40m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
41m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
234m 13s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

389m 30s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5947

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 093ba7987831 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 914d6334f472da4474bb0af21245b4eb646f89af

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/3/testReport/

Max. process+thread count
2275 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 24s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 12s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 26s

trunk passed

-1 :x:
shadedclient
40m 32s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m 24s

the patch passed

-1 :x:
shadedclient
39m 36s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
240m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

393m 56s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5947

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 74ac913e37a8 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d0a03ff45b4c73f9b0c21d8d6e221dee51e5fb28

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/5/testReport/

Max. process+thread count
2434 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5947/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


NSTStreetView Does not exist

I followed all steps to set up Google Maps and Places.
ExceptionsManager.js:71 Warning: Native component for "NSTStreetView" does not exist

same issue here, no solution?

You might need to add.
return Arrays.<ReactPackage>asList(
      ...
      new NSTStreetViewPackage(),
       ...
      );

in MainApplication.java  as react-native link is not adding this.

solved in 0.2.1


Consider renaming?

This tool now does much more than outputting to zip, including outputting to an extracted folder, or to ISO/CSO. So maybe it should be renamed pkgtool or similar? Or pspkgtool to make it clear it is PlayStation-specific, as opposed to other types of PKG files.

That's why I didn't want (and still don't) to have non-zip mode... blame Radziu.

Just don't use -x on extraction and you have pkg > zip, problem solved. I always use non-zip mode if game have small amount of files.

Its not about using or not using extra argument. Its about maintaining/testing extra code (which I do not have use for).

I didn't mean to start a debate over the functionality of the program, just its name! You're free to have it do whatever you want, but as I saw the latest update would convert PSP pkgs to ISO or CSO, and as I already knew about the -x option previously added, I thought you were expanding the program to do more and more. It was only for that reason that I suggested thinking about the name.

ok. but i'm grateful for non-zip option. thanks for your hard work. regards


UX is inappropriate if one of the tabs contains ScrollView

Swiping between tabs feels not good if one of tabs contains scrollview: scrollview prevail on swiping too much, so it's hard to swipe between tabs instead of scrolling up and down.
Try to apply this piece of code to this library:
onPanResponderMove: (_, {dx, dy, x0, y0}) => {
  if (!this._axis) {
    const dx2 = dx * dx;
    const dy2 = dy * dy;
    if (dx2 + dy2 > 10) {
      this._axis = dx2 > dy2 ? 'x' : 'y';
    }
  }
}

This feels way better.

I'm not sure about this. In the app we were working on, I found the swipe was triggering a lot when scrolling.

The default pager now uses native primitives. So this is no longer relevant.

@satya164 is there a convenient way to increase swipe angel now?


Normalise route names when chaining routes

Route names appear to be normalised when they're added to the router but during route chaining the route name requested is used for the lookup verbatim.
This has the upshot that it is non-obvious how to chain to a route named 'test-route'.

Thanks. @pfmooney this looks good, could you make sure it prepushes clean and merge?


[Bug] : Responsive issue fixed

Hello @mdazfar2 ,
closes-issue #237
Before
Screencast from 2024-06-06 12-08-30.webm
After
Screencast from 2024-06-07 07-22-55.webm

@sivaprasath2004 Resolve the conflicts

@mdazfar2 resolved please merge it..


nan_strategy=_SKIP producing negative values in some cases

Hello shakedzy,
First of all, thank you for the great contribution to Python with this fantastic package.
Also, congratulations to the paper written in TowardsDataScience.com .
I just had one question/concern after using your package.
Doing the correlation of category-category with Theil's U, I was getting negative results for some cases.
After analyzing your code, I have seen that what is causing these negative results is the parameter "nan_strategy=_SKIP"  in the function "_comp_assoc"(lines 409 and 415 in dython/dython/nominal.py).
I do not know if this should be like this or if it is an error since you can specify the nan_strategy in parameters,
Thank you very much,
Regards,
Xavi

Hi @xavisilver - thanks for the feedback. Please be sure to go over this closed issue which sounds very similar to what you raised.
If this isn't the case, it's impossible to assist without data sample and the exact code you're running, so please make sure to attach these.

Hey shakedzy,
Thanks for the answer. I have checked the issue and it is applicable to my case. I had not specified the correct format to the columns and it was reading them as numeric.
Thank you,
Xavi,


Ethcing: Batchfile must contain at least one inscription

Etching does not work if i don't specify an inscription configuration

duplicate of #3396

At the moment you need to create an inscription but you can specify an empty one by doing:
inscriptions:
  -


Add the Fine-Grained Visual Categorization Plant Pathology dataset

Describe the dataset
Add FGVC7-plant-pathology dataset to Hub. So this would work.
import hub
ds = hub.load("username/FGVC7-plant")

Steps

Please take a look at the docs on uploading datasets.

Uploading script should be added to examples folder

Example
You can find an example of large dataset loading and upload here:

https://github.com/activeloopai/Hub/blob/master/examples/coco/upload_coco2017.py

@mikayelh would love to work on this issue :)

@sentinelprime619 assigned the issue. Please let us know if you have any further question at https://github.com/activeloopai/Hub/discussions/119

Hi, @sentinelprime619 ! Hope this finds you well. Dropping a note to check in on you an ask if you need a hand with uploading the dataset. Feel free to ask us in the GitHub Discussions (we have beta access!) or our dedicated Slack channel. Also, if you haven't already, please star our package. Thanks a mil!

Hey @sentinelprime619, do you need any assistance with uploading the dataset? We've just released v1 of Hub, which makes uploading even easier. If you need any help, feel free to join our Community Slack to ask questions!

Closing this due to inactivity, will reopen if theres widespread interest.


[Error: Quota limit exceeded, try again later]

I guess I need an api key, but how do i set it, and let's consider google doesn't offer this API publicly

@sebfindling
Yes this is an unofficial API so there is no api key and unfortunately, Google will limit the number of requests you can make in a given time period.  I have not figured out a way around this yet but when I do, I will reopen this issue.

Any idea of what the quota is?

Do we have an idea about what the limit is? Like 3000 requests per day maybe?


CDK migration?

Hi Team,
Do you have already available the cdk migration for the templates, please?
Thanks
Tony

Hi Tony,
Currently, the solution does not use CDK. We have plans to migrate to CDK, but not in the near future.
Thanks

Closing this ticket as we are not migrating to CDK


OSX gives  tcp connect error

when i run it immediately gives error like this
   Compiling proxy_tester v0.1.0 (/Users/quantum/Desktop/code/proxy_tester)
    Finished dev [unoptimized + debuginfo] target(s) in 5.67s
     Running `target/debug/proxy_tester`
Ignored <IP_ADDRESS>:80 ,error sending request for url (https://jsonip.com/): error trying to connect: tcp connect error: Too many open files (os error 24)

Here is the code
use std::time::Duration;
use std::fs::File;
use std::io::prelude::*;
use std::io::BufReader;
use tokio::task::JoinHandle;
use futures::future::join_all;

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let proxies = get_proxies();

    let mut handles : Vec<JoinHandle<_>> = Vec::new();

    for proxy_ip in proxies.iter(){
        let proxy_ip = proxy_ip.clone();

        let sp =   tokio::spawn(async move {
            let proxy = reqwest::Proxy::all(&format!("http://{}",proxy_ip)).expect("Error on proxy");
            let client = reqwest::Client::builder().proxy(proxy).timeout( Duration::new(20, 0)).build().expect("Couldnt build client");
            let resp =  client.get("https://jsonip.com").send().await;

            match resp {
                Ok(t) => {
                    let text = t.text().await;
                    if let Ok(xyz) = text {
                        dbg!(xyz);
                    } else{
                        println!("Coun't parse {}",proxy_ip);
                    }
                },
                Err(e)=>{
                    println!("Ignored {} ,{}", proxy_ip,e);
                }
            }
            println!("Completed");
        });
        handles.push(sp);
    }

    while handles.len() > 0 {
        if handles.len() >= 3 {
            join_all(vec![ handles.pop().unwrap(), handles.pop().unwrap(), handles.pop().unwrap()]).await;
        }else{
            join_all(handles).await;
            handles = vec![];
        }
    }

    Ok(())
}

fn get_proxies() -> Vec<String>{
    let proxy_file = File::open("/Users/quantum/Desktop/code/proxy_tester/proxies.txt").expect("Coulnt open proxies.txt file");

    let  buf = BufReader::new(proxy_file);

    buf.lines().map(|l| l.expect("Could not parse line")).collect()
}

As the message says, "Too many open files (os error 24)", you're hitting the file limit set by your OS. You can see that limit by running ulimit -n.

@seanmonstar the default ulimit -n is 256 . And it starts showing error from beginning that is giving me worries.

Well, at the beginning you're opening a new connection for every proxy in your list, so that would make sense. Try increasing your limit.

oh i get it . I thought tokio::spawn do nothing unless i await but it seems it starts to send request for every proxy in list. And I thought because of below code it will open only 3 connection at maximum. Sorry for this issue. Thank you much
   while handles.len() > 0 {
        if handles.len() >= 3 {
            join_all(vec![ handles.pop().unwrap(), handles.pop().unwrap(), handles.pop().unwrap()]).await;
        }else{
            join_all(handles).await;
            handles = vec![];
        }
    }


0.1.0 Release

all it needs is the compat bound, very simple module.

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/65333
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 70dbf753ab9ea709779f7ed9d32c97c3e13dce04
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/65333
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 62fcc84688ab9dd15b116af4174595023b9f621e
git push origin v0.1.0


meiliesearch options in defineNuxtConfig should be 'options' and not 'clientOptions' as mentioned in the Frontend docs.

In the Frontend docs this is described as setup:
meilisearch: {     clientOptions: {... }  }
But those options didn't work for me. Looking at /node_modules/nuxt-meilisearch/dist/runtime/composables/useMeilisearchClient.mjs is noticed that you have to use options instead of clientOptions:
const { meilisearchClient: { hostUrl, searchApiKey, options } } = useRuntimeConfig().public;
The options work now, I changed the setup to:
meilisearch: {  options: { ... } }

I moved to your point
It will be live on next release


Create .editorconfig

I think it would be interesting to have a .editorconfig because ESLint warn us a lot about the identation like this Expected indentation of 2 space characters but found 1
EditorConfig allow our editor to respect the same rules
http://editorconfig.org/

My bad due to a network error
#76


Be smarter about launching without a Qt event loop

Several new users have reported issues with the %gui=qt / --gui=qt / with gui_qt() stuff. It's actually a pretty big gotcha with napari right now. At a minimum, we should catch these exceptions in the following entry-points:

Viewer()
view_*()

and provide an informative error message. Better, we should detect when there is no event loop and create our own, which would be blocking in IPython — but this is fine, this is how matplotlib works.

CC @GenevieveBuckley @DrLachie

Agreed - minimum fail gracefully, 2nd option is to warn and wait an extra couple seconds, sometimes it may be coming, finally we should make our own.
Fixing this is a high priority

This has now been closed by #642


[UCarousel] inside [UModal] = incorrect (negative) pages value in indicators slot

Environment

Operating System: Windows_NT
Node Version:     v20.12.0
Nuxt Version:     3.11.1
CLI Version:      3.11.1
Nitro Version:    2.9.5
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      app, modules, routeRules, imports, components, runtimeConfig, colorMode
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Version
2.13.0
Reproduction
https://stackblitz.com/edit/nuxt-ui-qyflse?file=app.vue
Please open preview in new tab and wait till the error appears.
Description
Code from Carousel.vue:
    const pages = computed(() => {
      if (!itemWidth.value) {
        return 0
      }

      return props.items.length - Math.round(carouselWidth.value / itemWidth.value) + 1
    })

Sometimes, when the carousel dimensions change, we may get the wrong pages value (when carouselWidth.value and itemWidth.value changes handled unsimultaniously, as I get it). In most cases this is not very bad, because after a moment the value will return to the correct one. But if you place the carousel in a modal, this code may produce a negative number, which will lead to a fatal error in the renderList vue function.
The solution is simple, just check the result for a negative number:
return Math.max(props.items.length - Math.round(carouselWidth.value / itemWidth.value) + 1, 0)

Additional context
No response
Logs
No response

This should have been fixed with #1619 and can be checked with<EMAIL_ADDRESS>Feel free to reopen if I'm mistaken.
P.S.: great reproduction ❤

No, #1619 don't fix this bug.
As I said, the solution is simple, just check the result for a negative number in pages computed function:
return Math.max(props.items.length - Math.round(carouselWidth.value / itemWidth.value) + 1, 0)


Reminder to update a sector index

And quick link to it.
If you track buildings in sector indices, it would be handy if bookie told you that you haven't updated some index in a while, and give you a link to it. No idea where to add this and how it would look but adding this ticket so we remember to think about it when the workload is lighter.

http://forum.pardus.at/index.php?act=ST&f=10&t=9592&hl=&view=findpost&p=785563
Please note that the index page is cached and will only be refreshed approximately once in 6 hours.


Result before Build After Due Date is not visible

The result before the Build After Due Date is not visible as instructor anymore, it only says Result Count 2. It is and was, however, in some cases critical for resolving discussions and issues to see the result that the students got displayed before the Build After Due Date. We need to be able to see all results, be it in the submissions list or a separate list.
Also, in regard to the multiple correction rounds for exams it would be dangerous if instructors cannot see the different assessments and all changes done to them.

We already talked about showing all results of one submission in this list. In the example above this would look like this and should be easy to implement

Additionally it would be nice to highlight the result that actually counts for the students in the end in some way (could be done in a follow up)

We already talked about showing all results of one submission in this list. In the example above this would look like this and should be easy to implement

Additionally it would be nice to highlight the result that actually counts for the students in the end in some way (could be done in a follow up)


Make the output show even before the spinner is finished

Just make it not occur if the output is empty?

Have an optional parameter "display-only-on-complete". That can then be used when a smooth plot change is desired.


Add Penpot/Uncategorized

Penpot

Penpot - Penpot is the Open-Source Design & Prototyping Tool for Product Teams.
License: <Mozilla Public License, v. 2.0>
Why do you think this helps users privacy?: <You can deploy your own instance with it, and dev recently updated local cache for google fonts. Open source as well>
Under what section should this service be listed?: <Uncategorized, or Teamwork>
Additional comments / info: <Github documentation here: https://github.com/penpot/penpot>

Isn't penpot an alternative to Figma? Maybe we could add a new section "Design tools" or something like that and add Penpot there?

Yeah, that works too. I do know of a few other open source design tools to recommend so having a Design Tools section would help!


Unable to serve app ruby 2.5.3?

Not sure if anyone else has encountered this already with serving ruby 2.5.3 app. I am trying to serve an app that uses ruby 2.5.3. I get the following from terminal
$ rails server
Traceback (most recent call last):
	4: from bin/rails:3:in `<main>'
	3: from bin/rails:3:in `load'
	2: from /Users/tiffanylo/CHAYN/SoulMedicine/soulmedicine/bin/spring:8:in `<top (required)>'
	1: from /Users/tiffanylo/.rbenv/versions/2.5.3/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
/Users/tiffanylo/.rbenv/versions/2.5.3/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- bundler (LoadError)

I am also having issues with Rails Server. Are you using raspbian? Ubuntu?

Hi @missamii and @ultrasam, how is it going?
According to your logFile, your ruby version compiled is 2.5.3, while your bundle is trying to use ruby version 2.5.0. Taking a little close to the beggining of the rbenv official documentation (how rbenv works), there is a priority in searching the versions path, first local and after global.
It's seems your bundle is searching the global path instead of the local one. Try remove (uninstalling) the global one to avoid bundle to find this path.
Checking your ruby versions:
rbenv local - this will say the first path reached.
rbenv global this may say system, meaning the global ruby version.

This issue tracker is for a Ruby version manager. Please ask questions about general Ruby usage elsewhere, in more appropriate support forums. Thank you!


Fix type generation for missing arg

Hover on bar in call(foo.bar)

with
class Main {
	static function main() {
		var test:{bar:String} = {bar: ""};
		foo(test.bar);
	}

	static function foo():Void {}
}

regardless of where I use "Add argument" it always does static function foo(test:{bar:String}):Void {} instead of just bar:String

This is the case i fixed in this PR, cannot repro. You probably forgot to checkout it first?

I had the branch checked out, but maybe I forgot to reload my other vscode instance when I tested it... it seems to work now.


[Bug]: Error when using default containers

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
If you assign a default skin and use a default container from another skin, all modules using the default container will throw an error.

Steps to reproduce?

install a new skin
Go into Themes and select a default skin.
Select "Container" and select a default container that is NOT in the default skin.
Add a new module to a page, it will display the error.

Current Behavior
Error displayed
Expected Behavior
No error and it uses the default container selected in themes option.
Relevant log output
No response
Anything else?
This worked in DNN9.12, so this bug will break upgrades if no container is specified for the module
Affected Versions
9.13.2 (latest release)
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry, I didn't realize this was the Skin forcing a container that was not installed.  I'll close it.


index of a recurrence

Hello,
My scenario is if I give MasterRecurring Id to my API, it should return list of all the occurrences inside it with start date, end date and occurrence index number, so that I can further navigate to update , read or delete single occurrence based on its index number using Appointment.bind(service, recurringMaster.Id, indexofOccurences). Is there any way to achieve indexes of all the occurrences?
Regards,
Vasu Gupta

No. Occurrences are very irritating in Exchange. From a specific occurrence you can find the master. From the master you can find the first, deleted, modified, exceptions. As far as the index goes, believe it or not, MS just tells you to keep using an index until you get an error. Obviously in anything except well-bounded series, this is nonsensical. But this is a server level issue, not a java library issue.


Add spacing to card numbers

@bbean86 Care to weigh in on how thoroughly you've tested your implementation? I specifically left out any formatting because it adds a ton of complexity. You have to worry about data being pasted in and where the cursor's positioned as users are typing. In order to support this I'd have to get a suite of tests written up with Protractor to even consider releasing it. Before I spend that time I'd like to hear whether you've encountered any issues to date.

There is a sore lack of unit testing on this feature on my part, and I apologize for that. However, I have monkey-tested this to death, as well as this going through a full cycle of QA at my company with no issues for Amex, MasterCard, Visa, and Discover card numbers. Pasting works, cursor positioning while typing is fine (no extra spaces or weirdness like that). It does rely on the length property for a card, though. Maybe that property should be renamed maxLength? Also, I honestly only did cursory research on the non-major card number formats, so I just gave them the xxxx xxxx xxxx xxxx format if I couldn't find anything definitive. We may want to do a little more digging there.

Another thing to bring up is that for this to work in my implementation, on the input you have to use ng-model-options='{ allowInvalid: true }'. We could hide that behind a directive to turn this feature on, like cc-formatted. That directive would require cc-number and just apply the needed ng-model-options.

Well the bigger issue is that unit testing won't cut it on something like this. I have to spin up Sauce and write Protractor tests to verify this behavior.

Using ngModelOptions should be fine as a hack but it's not the right solution. This one will take some time because I want to be 100% sure that it's not introducing bugs with all the many edge cases that modifying user inputs on the fly can create. There's definitely value in it because it's way easier to parse what you're seeing on screen when it's spaced and you can chunk the numbers.

The formatting's pretty important in a professional product. It's the main reason that I'm going to fork laurihy/angular-payments and fix the bugs instead.

I don't have time to do this wrong, answer issues about it, and then hack on fixes over time. As advertised, I'm doing this right or not at all. I'd certainly welcome a PR here that handles it which I genuinely believe would take less time than trying to fix angular-payments.

This is actually super easy if you don't care about cursor bugs (3dd5bd12d766758bbdd8ef5681906744537bec33)
I want to at least take a crack at addressing the fact that any keystroke results in the cursor being moved to the end of the input. I can't dive too deep this weekend so if I can't resolve it I'll still ship a new minor version with formatting disabled by default and enabled via an attribute. I feel a responsibility to do this right but if Stripe's willing to ship buggy forms for these rare cases I'm open to allowing opt in.

I pushed this in 2.3.0. There are some easily reproducible cursor positioning bugs, but that's also true of every single other open source implementation I could find. I picked the cases that seemed most unlikely to ignore for now and focused on getting obvious/common stuff right. It's also got the advantage of not relying on DOM events at all, so none of the nonsense from angular-payments with short-circuiting Angular's input handling and causing all kinds of obscure bugs.
I'm basically going to leave this as is for the foreseeable unless anyone is up for doing PRs. If and when I get time to work on input masking again it'll be in the form of a super thorough vanilla implementation that can be plugged in here. I feel like anything in between isn't worth the effort.


dat fork

for forking manually
Scenario: Im on the latest checkout, ab23d12. I want to experiment on this dataset, which will be a pretty destructive transformation.
Currently,
dat import updates.csv

will not create a fork on the current branch, but add d as the new latest.
a
|
b
|
c
|
d (latest)

When other people dat pull, they'll see 'd' as the latest checkout if they haven't changed their local repo.
What I'd really like is a fork, so that when they pull, they don't have to use my experimental version.
$ dat fork
Current version is bsbd234
$ dat forks
ab23d12
bsbd234
$ dat import updates.csv

So it'd look like:
a
|
b
| \
c  d <- (c is still 'latest')

@karissa you can do this currently using a checkout
dat checkout b
dat import updates.csv

@mafintosh I really want d to be a copy of c, though, so they'd have to do
dat checkout b
dat export -d dataset --checkout=<c> | dat import -d dataset
dat import updates.csv

@karissa ok i think i understand the use-case. we could easily add this by just copying the c graph node internally and giving it a bit of new metadata so it gets a new hash.

+1

Wouldn't it be better to use something like git branches? So instead of copying a graph node, there would be a list of tags that you could assign to certain nodes.
So it would be more like:
dat branch experiment
dat checkout experiment
dat import updates.csv

After dat branch:
a
|
b
|
c <- latest, experiment

After the import
a
|
b
|
c <- latest
|
d <- experiment


Add Support for Snapshot Nodes

Opening for visibility, but it seems like any upstream snapshot nodes are failing to be rendered.

Hi @tnightengale, Thank you for your feedback.
We're trying to understand how can we add the snapshot support into the unit test package.
We'll share our progress when we have something in place.

https://github.com/EqualExperts/dbt-unit-testing/pull/50

Solved by #50


Code splitting for improved performance 🚀

Improving the initial loading speed by code splitting the route components and making subsequent navigation faster by prefetching.
Sorry if I made any mistakes :(

Thanks for the PR @sanjaiyan-dev ! Can u use a formatter like Prettier to format the files that u edited? The builds are failing because of formatting issues.

Done 🤝

Benchmarks -:
Before update

After update

🚀🚀🚀


New temporal field for editing the final version of a motion.

@emanuelschuetze First work, please make a list of missing thinkgs, like pdf, exportdialog, ...

Ok.


Group all deps update into one pr

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Group all deps update into one pr
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer

coverage: 80.775% (-0.08%) from 80.856%
when pulling b6a6d64eed5ba0acf7799413f4e5d6ba97ff4213 on MartinForReal-patch-1
into 1fe0e69cc01b3eb478b9d35e512d7d18ee604695 on main.


Created SessionManager.UI as a Universal App

The SessionManager.Universal.UI follows a lot of the structure and contents of the SessionManager.UI project. There are some key changes and refactors that have happened and I will try to list them below. The functionality of the app is similar to the one provided by the desktop version but there are still ways to improve either one. This is simply an initial build meant to kick-start further developments on the platform.
Key changes from the SessionManager.UI:

Added CrossPlatform classes to bridge functionality to UWP. Classes were imported from HoloToolkit-unity project. Copyright headers maintained where applicable
SharingClient.dll is copied via post-build script to ensure proper version and architecture are selected
Changes to XToolsApp.cs to support Connect() / Disconnect() rather than do it on initialize.

Some known limitations to be addressed in future:

Read server IP and User from a config file (did not use the XtoolsConfig.txt to give ability to connect/disconnect
App crashes in debug only when disconnecting.

Addresses #6. Hope this helps.

Hi @alexdrenea, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks guys for all the feedback. Much appreciated. I will add my comments to each line and correct where applicable and make another commit soon.

Hi guys,
Any further comments or feedback on the pull request that I should update?


Stuck on bin\start-mongodb.bat "C:\Program Files\MongoDB\data"

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[x ]

I am installing on Windows. I have installed Mongo, but I am getting stuck on this line:
bin\start-mongodb.bat "C:\Program Files\MongoDB\data"
"Windows cannot find mongod.exe...."

I navigated to the bin folder in my app folder where the start-mongodb.bat file is
changed "C:\Program Files\MongoDB\data" to "C:\Program Files\MongoDB\data", but I still got the same message.
changed "C:\Program Files\MongoDB\data" to "C:\Program Files\MongoDB\Server\4.0\data", but I still got the same message.

What am I doing wrong?

I have installed it also and got mongod.exe under C:\Program Files\MongoDB\Server\4.0\bin. Will you please use this once and check whats happening? In data folder under 4.0 there is no mongod.exe.

It's under the bin folder, but I still got that error. Baffled. I subsequently installed MongoDB Compass, started that and, in the bin folder double clicked on the mogod.exe file. The question is, is this correct?


How does Eureka, which contains context-path, configure prometheus

My Eureka Server contains context-path, so configured as consul_sd_configs:-server: localhost:8500/context-path, on prometheus, but in the end prometheus reports about Get http://localhost:8500/context-path%2Fv1/catalog/services.

Prometheus' consul client does not support a context path. The property you are using is intended for host and port only, not a context path (see https://prometheus.io/docs/prometheus/latest/configuration/configuration/#consul_sd_config). Hence, slashes are escaped.
You could try to use a reverse proxy (like nginx) to add the context path to the requests. This should work as the endpoints of this adapter don't build any paths themselves. All the path logic is done on the client in prometheus.


Calling nextStep in onNextStep causes a loop

if (this.currentStep < this.numberOfSteps - 1 && this.currentStep !== -1) {         this.customCallbacks.onNextStep(this.currentStep)         this.currentStep++       }
Should be
if (this.currentStep < this.numberOfSteps - 1 && this.currentStep !== -1) {         this.currentStep++;         this.customCallbacks.onNextStep(this.currentStep-1);       }
Otherwise it will go to a loop, since the currentStep stays the same, before reaching the next step.
This happens in a situation if we want to check in onNextStep eg if currentStep === X and some other condition matches => skip to the next step => loops forever.

This is happening to me.  I wanted to skip a step if a certain condition is met (element not on screen) so in my onNextStep callback I check a condition and then call nextStep but this is always causing an infinite loop if nextStep is ever called even once.

Hi, is the problem still happening in the last vue-tour version? The code has changed at this level recently.


Usage with MongoDB

Sorry, not an issue with the next-firebase-auth-edge but rather a question of how to use it properly in my case. I am new to the backend and especially to authentication flows.
I am moving from NextAuth to this library since NextAuth has no support for mobile app login. My next step once the web app is done is to get Android and iOS apps to use the same Next.js backend and the same rest API.
I am using MongoDB and with NextAuth I could check the NextAuth's session on the API route and get the userEmail with which I could access all user's data in the database.  Even better I could use midleware.ts to check if the session is valid and forward userEmail to the API routes. API routes will connect to MongoDB and get all the data back to the frontend web app in response.
I got errors when tried to add Firebase Auth check in middlware.ts and that is how I found this library.
How can I make this library work in a similar way I used it with NextAuth?

Check authentication in the middleware and forward user info (email or uid for example) in the request headers to the API route that the request was made to.

Would it be a good approach or should I use it as in the example, and get user data from the getTokensFromObject in each API route?
Thank you for your help.
Sorry, I could not find a better place to post this question.

Hey @Vitallyz! Thanks for the question.
You definitely could do something like this:
export async function middleware(request: NextRequest) {
  return authentication(request, {
    loginPath: "/api/login",
    logoutPath: "/api/logout",
    apiKey: authConfig.apiKey,
    cookieName: authConfig.cookieName,
    cookieSerializeOptions: authConfig.cookieSerializeOptions,
    cookieSignatureKeys: authConfig.cookieSignatureKeys,
    serviceAccount: authConfig.serviceAccount,
    handleValidToken: async ({ token, decodedToken }) => {
      // Set custom request headers based on decodedToken <------- THIS SECTION

      if (decodedToken?.email) {
        request.headers.set("X-User-Email", decodedToken.email);
      }

      request.headers.set("X-User-Uid", decodedToken.uid);

      // Authenticated user should not be able to access /login, /register and /reset-password routes
      if (PUBLIC_PATHS.includes(request.nextUrl.pathname)) {
        return redirectToHome(request);
      }

      return NextResponse.next();
    },
    handleInvalidToken: async () => {
      return redirectToLogin(request);
    },
    handleError: async (error) => {
      console.error("Unhandled authentication error", { error });
      return redirectToLogin(request);
    },
  });
}

And later in API Route:
export default async function handler(
  req: NextApiRequest,
  res: NextApiResponse
) {

  const uid = req.headers["x-user-uid"];
  const email = req.headers["x-user-email"];
}

Please note that in example middleware.ts API routes are not handled by middleware due to this config:
// middleware.ts
export const config = {
  matcher: [
    "/",
    "/((?!_next|favicon.ico|api|.*\\.).*)",
    "/api/login",
    "/api/logout",
  ],
};

It instructs Next.js to ignore all /api/* routes other than /api/login and /api/logout. That is why all route examples use getTokensFromObject. You would have to modify this config to include your api routes.
Now, to answer the question if would it be a good approach:
At the moment API route is called, you already have uid or email in headers. It's encoded in cookie headers. Let's take this example scenario to show difference between two approaches:
NextAuth way:

Browser calls /api/example-endpoint route after user was logged in
Middleware handles /api/example-endpoint route, verifies token and sets additional request headers
API route assumes request is authenticated and extracts those additional request headers to identify a user in MongoDB

next-firebase-auth-edge way:

Browser calls /api/example-endpoint route after user was logged in
Middleware ignores this route and proceeds request to API route
API route calls getTokensFromObject which verifies the token and extracts user data from the token

There is no good or bad in both approaches. The difference is where the token get's verified. In NextAuth, it's always verified by middleware. In next-firebase-auth-edge, API routes validate token themselves just before extracting user data.
My motivation for the design was:

Not all API routes require authentication, so it's up to API route to decide if it should be authorized
I see no point in redirecting user to login via API route, that's why authentication middleware ignores all API routes by default.

The drawback of 2. is that if there are no user credentials in API route that requires uid or email we need to handle it explicitly in API route like this:
export default async function handler(
  req: NextApiRequest,
  res: NextApiResponse
) {
  const uid = req.headers["x-user-uid"];
  const email = req.headers["x-user-email"];

  if (!uid) {
    return NextResponse.json({ message: "Not authorized" }, { status: 401 });
  }

  // ...success flow
}

And now it's up to /api/example-endpoint caller to decide if user should be redirected or not.
TLDR; it's perfectly fine to use getTokenFromObject in API Route to extract user data before contacting MongoDB, but it's also possible to implement approach similar to NextAuth by slightly updating middleware config object and handleValidToken implementation if needed

@awinogrodzki Thank you so much for such a descriptive answer and thanks for the heads up about the matcher!
Your explanation makes sense thanks for that!
But it raises another question I had for that library regards user redirect:
In the solved issues I've seen someone complaining about an issue where the backend does not redirect users from register/login/reset-password pages if the user is logged in. Your response was adding the PUBLIC_PATHS array and some logic to redirect users from those pages to the homepage.
My question is, would it be better to do the redirect thing on the front-end side (and render a fallback view while Firebase is checking auth), since if we go directly to the /login page, it will take some time for the API call to happen, and the login page will be briefly rendered before the redirect to the homepage happens? Or do I miss something in this mechanism?
https://github.com/awinogrodzki/next-firebase-auth-edge/issues/67
Thanks a lot!

@Vitallyz you could implement redirect on front-end side. That way, user with valid credentials would experience something like this:

Logged in user opens /login page
They see the /login page for a brief time
They get redirected to /page

This means at least 3 subsequent requests before authenticated user lands on our target, which is home page.
In middleware-first approach, the one with PUBLIC_PATHS, this journey is only 2 request trip:

User requests /login with authenticated user, middleware intercepts this request, sees that user is authenticated (therefore not allowed to see /login page) and returns response with 307 Temporary Redirect status and Location: / header
Browser sees the redirect and immediately redirects user to home page

You can see that with the second approach, we are saving at least one network roundtrip. Depending on how many requests are being made in /login page.
As I said previously, Next.js is automatically pre-fetching all links, even in /login page, so with the second approach we save a considerable amount of network roundtrips. Ofcourse, this would not matter in 90% of the cases, but with scale, this setup can save us a lot of $$$ on AWS bills :-)

Thanks, @awinogrodzki I think what I was missing is the fact that it is a server-side rendering I will have to play with this once the auth is working properly in my app.

I will close the issue now. If you have more questions, feel free to create new issue


add gap in header nav on mobile #106

Issue #106

Please create a fresh branch for new features/bugfixes from master. This one has a bit too many commits :)


Updated the cesiumjs.org bing key

Updated the cesium website Bing key.

@mramato Could you please review?

Thanks.


Part 1 of SC-62 related updates to zlint

These are two of the  more critical changes required by the SC-62 ballot that goes into effect on Sept 15th. The following changes were made in this PR:

Updated lint for common name handling. The definition for the CN field has switched from deprecated to NOT RECOMMENDED (essentially SHOULD NOT). An IneffectiveDate was added to the original lint. [This was based on nomenclature adopted from https://datatracker.ietf.org/doc/html/rfc2119#section-4]
Added a new lint for subscriber cert basic constraints checking. Post-SC62, basicConstraints MAY be included but MUST be critical if present.
Added a date for SC62 Effective

I did want to get eyes on the approach here. We don't usually use Ballot numbers in the effective dates, however these changes present a unique challenge since we have one lint that is no longer effective while a new lint becomes effective; additionally SC-62 makes changes to both the TLS BRs and the EVGs. Perhaps I could change that to the version of the TLS BRs going into effect on that date anyway? paging @christopher-henderson for feedback.

Thanks, I accepted both of those changes and agree with your reasoning. Appreciate the review!


Create new database for 2.0.0

📚 Context
For the 2.0.0 release, major changes will need to be implemented to take into consideration the first part of the output unification. This effort requires a change in how the node stores data relating to the inputs, outputs and proofs
This release will also include several major changes to how the node operates, its architecture and the flow of data between the services. One such change is the deprecation of Redis, and therefore the indexer, and concentrating all the information on the database.
Both these tasks require a new database design, as well as the new GraphQL API proposed in #242 uses PostGraphile, that in on itself also is built on top of database schema.
✔ Solution
The first step is creating the base repository, with the migrations and functions related to the basic operation of the node. This will allow other services to start being built on top of it.
Then, each service will bring forth personal needs from the database. In an effort to better divide each service's scope, most functionalities related to the database will be covered in the repository or inside the database, and the issues will be part of this epic.
A new view in a separate schema will be created for the PostGraphile.
To conclude, new tests need to be created and the previous database, indexer and GraphQL API in rust need to be deprecated.
📈 Subtasks

[ ] #347
[ ] #348
[ ] #349
[ ] #368

This epic is now obsolete, as we moved all 2.0.0 issues to #375.


fix(plugins): Fix PluginPlayer setup

This closes #530 and follows from some discussion on Gitter.
Bug
When the game definition included a phases section, the state expected from the PluginPlayer’s setup method was being overwritten with undefined.
Diagnosis
The player plugin wraps moves with a modified G, adding a player and (for 2-player games) opponent field from G.players, then restores their values to G.players after the move.
For some reason, the turn.onBegin function called in StartTurn is wrapped twice. I still don’t quite understand why, or why this only happens when phases are defined, but here is the result of a console.trace I added to the start of the player plugin’s moveFn:

Double-wrapped moveFn stack trace

Trace: fnWrap
  at CustomConsole.trace (internal/console/constructor.js:336:11)
  at trace (/boardgame.io/src/plugins/plugin-player.js:19:15)
  at Object.onBegin (/boardgame.io/src/plugins/main.js:79:10)
  at StartTurn (/boardgame.io/src/core/flow.js:322:5)
  at Process (/boardgame.io/src/core/flow.js:222:15)
  at Object.init (/boardgame.io/src/core/flow.js:845:11)
  at init (/boardgame.io/src/core/initialize.js:64:25)
  at new _ClientImpl (/boardgame.io/src/client/client.js:111:22)
  at Client (/boardgame.io/src/client/client.js:431:10)
  at Object.<anonymous> (/boardgame.io/src/plugins/plugin-player.test.js:116:14)
Trace: fnWrap
  at CustomConsole.trace (internal/console/constructor.js:336:11)
  at trace (/boardgame.io/src/plugins/plugin-player.js:19:15)
  at Proxy.<anonymous> (/boardgame.io/src/plugins/main.js:79:10)
  at Proxy.<anonymous> (/boardgame.io/node_modules/immer/src/immer.js:44:45)
  at Immer.call (/boardgame.io/node_modules/immer/src/immer.js:64:33)
  at produce (/boardgame.io/node_modules/immer/src/immer.js:44:22)
  at /boardgame.io/src/plugins/plugin-player.js:33:17
  at Object.onBegin (/boardgame.io/src/plugins/main.js:79:10)
  at StartTurn (/boardgame.io/src/core/flow.js:322:5)
  at Process (/boardgame.io/src/core/flow.js:222:15)

Because the wrapper is doubled, after the move function returns to the outer fnWrap, the G.player and G.opponent fields have already been stripped and when they are restored to G.players they are undefined.
Fix
I’ve added checks to the plugin’s fnWrap to make sure that G.player and G.opponent are defined before restoring them to G.players.
Presumably the double wrapping is a more fundamental bug that needs fixing, because it could impact similar plugins, but I’m not sure exactly where that’s coming from.

Thanks for looking into this!
Do you mind documenting the double-wrapping problem in an issue?


Remove attributes annotation of Builder struct

The struct created for a Builder should not have attributes because these structs only derive from Debug, PartialEq, Clone and Default. None of these support attributes.
This becomes a problem if a plugin tries to add attributes to the metadata field to configure the generated code for the struct. In this case, the attributes will also be added to the Builder struct; which is wrong.
Motivation and Context
I'm customizing client code generation by overriding the method:
override fun symbolProvider(base: RustSymbolProvider): RustSymbolProvider

I override the symbol.expectRustMetadata().additionalAttributes value and add extra values there. The generated code adds the correct attributes for the struct, however, it also adds these attributes to the Builder.
The Builder is restricted to deriving from Debug, PartialEq, Clone and Default (see code).
I believe this change was added by mistake in https://github.com/smithy-lang/smithy-rs/pull/2222/.
Description
To solve the issue, I simply remove the offending line.

Testing
I don't expect any existing code to break, given that this is a bug. It only manifests when someone is customizing the generated code.

Checklist

[ ] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
[ ] I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ok, I see that we actually need Builders to have the non_exhaustive attribute. I'll work on fixing this.

Thanks @david-perez! I will change those files too, as you requested.

Hello @david-perez , I have added the tests as you requested, to both client and server generators.
Notice that I didn't need to make any changes to the server classes because they don't have the same bug as the client.
Please let me know if you'd like me to do anything else in this PR.

Hello, how could we expedite this to be merged and available in the next release?

I see some linting checks failed. I'll resolve these and update the branch

I'm sorry I didn't see the ./gradlew ktlint --format option. I can run everything locally now, so the next set of tests should pass.

Hello, the failing check is ** ci / Ask maintainer to run the PR bot and canary workflows**.


no audio output when speaking

Briefly summarize your issue:
alexa seems to work fine and she even responds to the wake word but you can't hear her voice when it says "speaking". There are also some issues with Alsa lib (see behavior) which might be caused by the hifiberry we use.
What is the expected behavior?
We should be able to hear her
What behavior are you observing?
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.front.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM front
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround51.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround21
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround51.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround21
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround40.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround40
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround51.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround41
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround51.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround50
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround51.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround51
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.surround71.0:CARD=0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM surround71
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.iec958.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM iec958
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.iec958.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM spdif
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'cards.HifiberryAmp.pcm.iec958.0:CARD=0,AES0=4,AES1=130,AES2=0,AES3=2'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM spdif
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.hdmi
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.hdmi
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.modem
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.modem
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.phoneline
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.phoneline
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'defaults.bluealsa.device'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4996:(snd_config_expand) Args evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM bluealsa
ALSA lib confmisc.c:1281:(snd_func_refer) Unable to find definition 'defaults.bluealsa.device'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:4996:(snd_config_expand) Args evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM bluealsa
Provide the steps to reproduce the issue, if applicable:

Tell us about your environment:

What version of the AVS Device SDK are you using?
  <x.y.z>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[x] Raspberry Pi + Hifiberry Amp+
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[x] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hello valor-y,
This can be caused by many things and there are several threads covering this kind of problem.  I suggest looking in to the following:

Troubleshooting Guide (look for 'no audio output from the SDK')
#627
#577
#534
#517
#516
#500
#479
#427

Best regards,
-SWH

Team,
I deployed the same code on Android 8 [Respeaker core V2.0 Hardware], how can I test this, I am getting the same voice output issue
gst-launch-1.0 -m audiotestsrc ! autoaudiosink or m_pipeline.audioSink = gst_element_factory_make("alsasink", "audio_sink");
Regards
Vithal

Hi Vithal,
This issue has been inactive for a long time.  Are you still experiencing this issue?
Best regards,
-SWH

No, problem solved.
Regards
Vithal
Get Outlook for Androidhttps://aka.ms/ghei36

From: swh<EMAIL_ADDRESS>Sent: Tuesday, July 2, 2019 1:55:54 AM
To: alexa/avs-device-sdk
Cc: VK; Comment
Subject: Re: [alexa/avs-device-sdk] no audio output when speaking (#1027)
Hi Vithal,
This issue has been inactive for a long time. Are you still experiencing this issue?
Best regards,
-SWH
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Falexa%2Favs-device-sdk%2Fissues%2F1027%3Femail_source%3Dnotifications%26email_token%3DAKHD4W4FXBYMPOKGK4C3V7LP5KKQVA5CNFSM4F7TRZY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7VDHY%23issuecomment-507466143&data=02|01||8f772478533c49bf849608d6fe7fa828|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636976221561553890&sdata=KOASzCyN8U3ACwDtlz7BKigY1idugrz%2FJYLL%2F1FzUwg%3D&reserved=0, or mute the threadhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKHD4W4SL42CHHSDCRM4BBLP5KKQVANCNFSM4F7TRZYQ&data=02|01||8f772478533c49bf849608d6fe7fa828|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636976221561553890&sdata=sXEIlFkIK0IEFUJRL%2BINi5eA3hg0AzKR%2F4G%2B9%2BVtJPE%3D&reserved=0.

Closing the issue since it has been solved.


Fixed up and properly tested back end get all routes for each model

"get all" routes fully functional in Postman

Accept this one first


Add microbenchmarks

I can take this one and at least get the bare minimum scaffold setup.
My intent is to create a benches directory to the project root and add a few benches. As a follow-up it makes sense to add a job to Prow for this to run on a cron schedule.

Connection init with HBONE
Throughput?
Config ingestion?
Identify components that need this. It’s most likely these will be added as-needed to tackle specific issues.

This is pretty simialr to https://github.com/istio/ztunnel/issues/99. Id scope this task to microbenchmarks that are not exercising a real network call, etc.
There may not actually be many functions that qualify in that category though


WIP: Add Docs

For now just updating the README, adding a .gitignore, and adding a print statement to the example coapserver.rs.
@malishav, it looks like libraries in Rust should not have Cargo.lock checked into version control, can you confirm that? (if it is the case, I will add it to the .gitignore as well).

@malishav, it looks like libraries in Rust should not have Cargo.lock checked into version control, can you confirm that? (if it is the case, I will add it to the .gitignore as well).

Yes, I think we can add Cargo.lock to .gitignore

I think the README docs are enough for now, since many things are likely to change, such as the build system parameters.

Looks great! Let's just add steps on building and flashing for nrf52840 with and without hardware support for now. That should be pretty useful for a newcomer to the repo.

Good idea, done.

Looks great, merging


Api/builders

Here's some more builder APIs that I needed.
I've tried to follow the project conventions more rigorously this time around.
Instruction insertion API doesn't have a test because adding that after Instruction builder api seems like a reasonable thing to me.

I've made the requested changes.
Just a heads up, I've started doing codegen for my own language so expect a few more builder api implementations.

As for the builder api implementations: that's perfectly fine, I'm currently working on finishing the core apis

Looks good, thanks for the contribution


[Suggestion] use /2/timeline/media API endpoint to download media only for a user

Since Twitter's old web media API /i/profiles/show/:username/media_timeline was closed, it looks to me the extension now simply use /1.1/statuses/user_timeline.json even if downloading Media from a user.
(By the way, for some reason it only uses count=40. I believe they support up to count=200 which may save you some call counts.)
We probably can improve it by using the new web API /2/timeline/media/:id.json as it might be faster for media only requests.
This is just a suggestion; you may have your reason to stick with user_timeline.json, so do what you think is the best!

Thanks for your suggestion.

I believe they support up to count=200 which may save you some call counts.
I'll fix it at the appropriate time.

new web API /2/timeline/media/:id.json
I don't see a simple parameter (like max_id) to specify the period of time, and it seems to need to be specified with a complex parameter (cursor).
I haven't been able to analyze the format of the cursor parameter yet. If you know it, please let me know.

This issue has been fixed in version <IP_ADDRESS>.

Thanks!


cleanup unawaited futures lints

@Hixie

This is more of a @yjbanov question but LGTM.

LGTM

Presumably these were all bugs? :D

@eseidelGoogle

Presumably these were all bugs?

They are all error situations, so they look unlikely to have been bugs, but you never know, concurrency is tricky. I really like this lint. It would have caught this for example.


OR filter (where)

After brainstorm we have come to the conclusion that we won't be able to implement without losing the REST feature.
To make queries with OR (or where more complex) we recommend using VIEWS (within the database) or #70 (like view the level of application)

Hi any news on that with the 1.0.0 release? I know in PostgREST OR and complex filtering is available
Thanks

@pastarace we still don't support complex or operations, can you open a new issue for us to feature?
It's a resource that pREST needs to learn how to handle


KAFKA-9896: fix flaky StandbyTaskEOSIntegrationTest

We seem to typically fail on waiting for the first record to be processed, which we only give 15s. 15s to process a single record is reasonable, but we don't wait for the instances to reach the RUNNIG state until after we wait for the record to be processed.
We should first make sure the instance reaches running (for which a 60s timeout seems to be the common case in other integration tests), and then wait on the record to be processed.

Retest this please.

Retest this please.

Retest this please.

Checkstyle error:
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java:46:8: Unused import - java.util.Arrays. [UnusedImports]
15:29:35 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java:56:15: Unused import - org.apache.kafka.test.TestUtils.waitForCondition. [UnusedImports]

Retest this please.

Retest this please.

Failed with unrelated flaky
admin.ReassignPartitionsUnitTest.testModifyBrokerThrottles
and
connect.mirror.MirrorConnectorsIntegrationTest.testReplication

Retest this please

@mjsax can this merged? One failure in one build:
MirrorConnectorsIntegrationTest.testReplication


Add number, boolean, and single-quote-strings argument types support for template helpers

You can view the difference here:
Before: http://codepen.io/ichuan/pen/xVQQeE?editors=1010
After: http://codepen.io/ichuan/pen/JXewXN?editors=1010

Very useful!

Looks good, thanks and sorry for late merge!


How to finetune with multi resolution?

Is there any plan release the code of multi resolution finetune with sat? I found that the current sft.yaml file is not adjust with the v1.5 ckpt

In the fine-tuning section, we will provide a fine-tuning version of diffusers. The model version of diffusers will be released this week, and it is expected to be fine-tuned on cogvideox-factory


Revert "ribbit.network: Set ribbit.local as the mDNS hostname"

Reverts Ribbit-Network/ribbit-network-frog-software#11
This leads to random software crashes for reasons that are not fully explained yet.

I've also reopened #10 to track this down later.


Load Failed Problem

Some Structures can't be loaded.
For example:
X = nist.Compound('C25085534')
With the error of :
ValueError: could not convert string to float: 'Monomer  42.0797'

@hhddd6 thanks for the info! I'll update the package in 2-3 weeks.

@hhddd6 please check the new release. The package was tested for all compounds provided in sitemaps and it should work fine.
Please note that new release have no backward compatibility with previous version, so you will probably need to change your code.
Feel free to open the issue if something goes wrong.


NETOBSERV-906 convert and post-process flows spec

That's the second step after https://github.com/netobserv/network-observability-console-plugin/pull/296
Once the latter is merged, perhaps we can change it so it pulls the markdown with curl/wget
@skrthomas the asciidoc output is docs/flows-format.adoc

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d6dfe83). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage        ?   48.13%
=======================================
  Files           ?       43
  Lines           ?     4855
  Branches        ?        0
=======================================
  Hits            ?     2337
  Misses          ?     2314
  Partials        ?      204

Flag
Coverage Δ

unittests
48.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


device.isConnected does not return the true connection state

The following code prints incorrect information as far as I can tell:
console.log('await device.isConnected()', await device.isConnected()); // logs false
await device.connect();
console.log('await device.isConnected()', await device.isConnected()); // logs false

The first log statement should be false, but the second log statement should be true.

I think I see what's happening, the device.isConnected() call is returning an updated device, but the state of the original device does not update. Though I love functional programming, this is very confusing as the API is object oriented, calling a method on the object. I would expect the internal state of the device to be changing because of this. Either go fully functional or fully OO, but mixing them like this is causing confusion.

Actually, this gives incorrect results as well, I would expect the bleManager to be maintaining the global state of the device at all times:
console.log('await bleManager.isDeviceConnected(device.id)', await bleManager.isDeviceConnected(device.id));
await device.connect();
console.log('await bleManager.isDeviceConnected(device.id)', await bleManager.isDeviceConnected(device.id));

It happens because isConnected actually uses isDeviceConnected under the hood https://github.com/Polidea/react-native-ble-plx/blob/484501102ed87ba4004b8a128d86245018577117/src/Device.js#L141

This issue is still present on version 2.0.0. Everytime I try to check the status of a connected device by using isDeviceConnected it always returns false.
Please check the following code, despite of sending a connected device Id, I always get Device AA:BB:CC:DD:EE:FF is NOT connected!:
const isBleDeviceConnected = async (deviceId = null) => {
    if (!deviceId) return false;
    const isConnected = await bleManager.isDeviceConnected(deviceId);
    if (isConnected) {
      console.log(`Device ${deviceId} is connected!`);
    } else {
      console.log(`Device ${deviceId} is NOT connected!`);
    }
    return isConnected;
  };

Context: I need to check by using the built-in RN AppState component whether a device the user was using before switching of apps (or after coming back from background) it's still connected...
Is there any fix in progress or a workaround available?
Thanks in advance!
Federico

It seems that this issue is still in the version 2.0.1. Any news about that ? @dariuszseweryn

Current issue: #655


Add plugin to select the Envoy's cluster according to the request attributes

Description
No response
Use Scenes
This allows HTNN to use the corresponding upstream dynamically, which is required in the fail-over situation.
Advice
We can do this via cluster_specifier: https://github.com/envoyproxy/envoy/tree/main/contrib/golang/router/cluster_specifier

We can solve this by using routePatch plugin to use cluster_header field in the RDS, and then write a Go plugin that sets the cluster header and calls ClearRouteCache/RefreshRouteCache.
cluster_specifier is not flexible enough.


Add longopts

Hi - I like this library a lot, one small request. In build-scripts/any code or documentation that's checked in to source control, our team have a loose convention to always use long options (e.g. --option) rather than short options (e.g. -o) for CLI programs. The idea is that short options are helpful when you're typing and want to move fast, but they're worse if you're reading commands, (say, in an npm script), because they're harder for a newcomer or a code-reviewer to look at and guess what the option does.
So, I think it'd be worthwhile to add long options for these specific options:
  -e <path>           parses the file <path> as a `.env` file and adds the variables to the environment
  -e <path>           multiple -e flags are allowed
  -v <name>=<value>   put variable <name> into environment using value <value>
  -v <name>=<value>   multiple -v flags are allowed
  -p <variable>       print value of <variable> to the console. If you specify this, you do not have to specify a `command`
  -c [environment]    support cascading env variables from `.env`, `.env.<environment>`, `.env.local`, `.env.<environment>.local` files

I'd suggest:

-e -> --env
-v -> --variable
-p -> --print
-c -> --config

Makes sense! Feel free to create a PR. It seems we already have support for this https://github.com/entropitor/dotenv-cli/blob/master/cli.js#L32


"Vărbilău", "Coțofenești", "Livadea", "Podu Ursului" and "Poiana Vărbilău" villages are listed in the drop-down menu

The villages are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Preconditions : the website (https://peviitor-ro.github.io/ui.orase/) is up and runing. After every step delete the text you typed from the search bar.

Step 1
Type "Vărbilău" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Vărbilău, PRAHOVA (Vărbilău)".

Step 3
Type "Livadea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Livadea, PRAHOVA (Vărbilău)".

Step 4
Type "Podu Ursului" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Podu Ursului, PRAHOVA (Vărbilău)".

Step 5
Type "Poiana Vărbilău" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Poiana Vărbilău, PRAHOVA (Vărbilău)".


fix for contractor name

fix: contractor name should be same as the class name

Thanks for catching that 👍


WIP: support building and packaging on Windows with VS2015

Have tried to adapt setup.py for Windows (Python 3).
Todo:

[ ] Check and review code changes for other systems (fix clang)
[x] Add Appveyor build
[x] Fix one failing test

So, I somehow broke the clang compilation (finding boost) and appveyor builds still gives the strange linking error.
However, on home pc with Python 3.6.1 x64 the same development pack is successful: https://github.com/alex85k/pyosmium_libs/releases , the batch file is here
https://github.com/alex85k/winbuilds/blob/master/build_pyosmium.bat .

Have located the problem on appveyor: this is VS2015 Update 3 bug:
https://connect.microsoft.com/VisualStudio/Feedback/Details/2852624
Trying to switch to 2017.

Hm, that "else" condition for loops in Python was a surprise :) Tried to fix again.

The bug workaround seemed to work on Appveyor:
https://ci.appveyor.com/project/alex85k/pyosmium/build/1.0.13
now trying to fix tests...

Appveyor is almost happy:
https://ci.appveyor.com/project/alex85k/pyosmium/build/1.0.14
There is only one failing test
ERROR: test_func (test_osm.TestAreaFromWayAttributes)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\dev\pyosmium\test\helpers.py", line 118, in test_func
    self.Handler().apply_file(fn, self.apply_locations, self.apply_idx)
  File "C:\dev\pyosmium\test\test_osm.py", line 129, in area
    assert_equals(n.num_rings(), (1, 0))
TypeError: No to_python (by-value) converter found for C++ type: struct std::pair<unsigned __int64,unsigned __

Appveyor is finally happy, test passing!
https://ci.appveyor.com/project/alex85k/pyosmium/build/1.0.16
However, this means that long is 32 bit , and somewhere on Windows __int64 is somehow used. Hope it works correctly for big IDs etc.

Many thanks. setup.py still needs some cleanup. I'd be happy to do the finishing up. Just need to wait that we have appveyor enabled on this repo.
I'm not sure why you say 'long is 32bit'. Where does that come from, python, compiler, boost-python? I can add a test for big IDs.

Yes, I'd be happy if you can clean up setup.py. That was the first Python module :)
long is certainly 32 bit on VS 64 bit, elsewhere
std_pair_to_python_converter<unsigned long, unsigned long>();
std_pair_to_python_converter<uint64_t, uint64_t>();

was the same.

Ah, so this is just about checking the code for correct use of 'long' in the code. The code should be following the conventions from libosmium there, so we are hopefully fine. In any case, I've pushed two tests with 64bit ids now.

I have tried rebasing to current master, all additional tests pass successfuly. This time tested on Python 2.7.

Pushed the reabsed version here to trigger Appveyor.

Cleaned the PR after https://github.com/osmcode/pyosmium/pull/36, only thing to fix after is supporting Python 2.7.
Boost Python and Osmium certainly can not be built with 2.7-native Visual C++ 9.0.
However, substitution of VS2015 works for this extensions without problems. The only problem on Appveor is auto-linking.

DEFAULTLIB always wants to use boost_python-vc140-mt-1_63.lib and by default boost python for Python3 uses boost_python3-vc140-mt-1_63.lib .
Should we just use different development packs or change the library name?

Re-pushed. Seems to work with two different sets of libraries. Linker debug output removed.

You can also fork https://github.com/alex85k/pyosmium_libs to create devpacks on appveyor (or switch to windows-builds) and do not rely on my github release binaries.

Should we just use different development packs or change the library name?

The different packages are better. That should also allow us to add more python versions in the future. So I've merged as is. Thanks again.

You can also fork https://github.com/alex85k/pyosmium_libs to create devpacks on appveyor

It would be more practical to have that under the osmcode org. You can also just move the repo here to osmcode (keeping full access rights, of course). Or I can just fork it, as you prefer.


consider adding unnecessary_to_list_in_spreads to recommended

As per conversation starting w/ https://github.com/dart-lang/linter/issues/2965#issuecomment-1129010673.

This has been approved for the recommended set.


Regression for DPR (difficult to do, punting)

Discussion with @MXueguang on Slack:
DPR is a bit different from other datasets; it doesn't have a qrels file so it can't use trec_eval - since it needs to look at each retrieved document to see if contains the answer.
It's possible to do the search over the current set of retrieval docs. Those wouldn't be general qrels but would allow us to regression test - this doesn't seem worth doing though.
The general solution is to make anserini regression take more than trec_eval, but DPR eval is in Pyserini, which creates a circular dependency.
So, no good solution at present. Punting for now.


Discussion: Opportunity to create issues to Add UI features

This is the link to the figma design board
There are a lot of components that needs to be created. See the figma designs to figure out which components are needed to be done. You can create issues to complete one section/component at a time. You can start from any page you want. You can work on max 2 issues simultaneously

I have looked through the figma board and I really love what you are building. I noticed that the blog and company designs is yet to be implemented. Can I create two issues on this and proceed working? @ashuvssut

Yes you can work on Career opportunities section in company page. Open up a separate issue

We are not planning to implement any more section in Blog page

Alright, I'll do that now

I will implement  Meet The Team section since it's on the same page @ashuvssut

Hi @ashuvssut I would get the "Ready to get Started" section if you dont mind

@ashuvssut,
I would love to work on following component. If it is not assigned yet.

@sonali-d checkout issue #151

Hi! I'm on vacation so reassign it if you want

@senali-d you may self-assign the issue to yourself. Else just make a random comment so that I can assign it to you


Improvement to array type snapshot possibilities testing

Coverage remained the same at 100.0% when pulling 5fde1d1c91741f47ee63df276f5577a520dba1b0 on array-type-possibilities-improvement into 394714f86ee677fede30e340ae02af29a8769d5d on master.


Allow NITRO_CLI_INSTALL_DIR to be overriden in nitro-cli-env.sh

Issue #, if available: N/A
Description of changes: Similar to https://github.com/aws/aws-nitro-enclaves-cli/pull/376, there are a few cases where NITRO_CLI_INSTALL_DIR is fixed to a particular path when it should be adjustable. In this case, when compiling aws-nitro-enclaves-cli, the makefile command
sed -i "2 a NITRO_CLI_INSTALL_DIR=$$(readlink -f ${NITRO_CLI_INSTALL_DIR})" \
		${NITRO_CLI_INSTALL_DIR}${ENV_SETUP_DIR}/nitro-cli-env.sh

injects the current NITRO_CLI_INSTALL_DIR value to the nitro-cli-env.sh file.
At Stripe, we compile aws-nitro-enclaves-cli from source in CI and later deploy the binaries and configuration files to live hosts. The NITRO_CLI_INSTALL_DIR is different in our CI systems than it is on our live hosts. For example, NITRO_CLI_INSTALL_DIR=/build/aws-nitro-enclaves-cli in CI and NITRO_CLI_INSTALL_DIR=/deploy on live hosts. We ran into the issue of the hardcoded NITRO_CLI_INSTALL_DIR variable on live hosts when trying to prepare running an Enclave on them.
To fix this, this PR modifies the injected statement to allow for an existing NITRO_CLI_INSTALL_DIR to be used instead. The prepared version of nitro-cli-env.sh now starts like:
#!/bin/bash

NITRO_CLI_INSTALL_DIR=${NITRO_CLI_INSTALL_DIR:-/build/aws-nitro-enclaves-cli}

This allows an existing NITRO_CLI_INSTALL_DIR to be respected, while maintaining a fallback to the build-time value if not set.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Can you please a signature to the commit? git commit --amend -s


Added new project product-list-with-cart-master and did some changes so that all images are visible

I added a new project called product-list-with-cart

please add gssoc extd label and hactoberfest label

Hi @beRajeevKumar , I just submitted this pull request as part of my contribution to the GirlScript Summer of Code (GSSoC)extd. It would be great if you could review it and possibly add the GSSoC label and hactoberfests label. Thank you! .Please assign it to me if any changes i would work on them.

@beRajeevKumar Hello with adding project i did some changes also and that changes resolve a image issue in last three part please review it and add lables gssoc(extd) gssoc and hactoberfest

@beRajeevKumar


fix focusmanager skipFocus issue

Closing this as this should be resolved with the new FocusManager added here
https://github.com/rdkcentral/Lightning-UI-Components/pull/49