Ensure that default dimensions passed to LLM instance are respected by embed

Related to: https://github.com/patterns-ai-core/langchainrb/issues/572
We need to set the embed dimensions in the LLM instance, otherwise we risk having one the Vector DB config set to a different dimension size to the dimensions returned by the embed method.
Allow dimensions to be manually set in the embed method, but respect them if they are set in the LLM.

@prdanelli I think this parameter needs to be changed to plural: https://github.com/patterns-ai-core/langchainrb/blob/main/lib/langchain/llm/openai.rb#L188.
In fact -- I think we need to make that global change everywhere: plural ("dimensions") instead or "dimension".

@andreibondarev absolutely agree about the item you linked - i've pushed that fix. The rest should probably be updated in another PR as it might be a breaking change.

@prdanelli Once the specs are fixed -- let's ship this PR.
Ticket for the future: https://github.com/patterns-ai-core/langchainrb/issues/575

Just pushed a fix... I missed one of the dimensions references in that file.

@andreibondarev all ✅ now.

Thanks for your help getting this sorted Andrei. 🎖

Thank you for your fix!


Improve documentation on custom datasets finetune

I am trying to do a finetune using a custom dataset, in particular: https://huggingface.co/datasets/truthfulqa/truthful_qa
I haven't found any clear documentation, only partial docs explaining bits https://pytorch.org/torchtune/stable/tutorials/datasets.html
I am following the instructions, and this is my custom class:
class TruthfulQATemplate(InstructDataset):
    template = "Instruction:\n{instruction}\n\nInput:\n{input}\n\nResponse: "

    @classmethod
    def format(cls, sample, column_map):
        return cls.template.format(**sample)

Here is my config:
dataset:
  _component_: torchtune.datasets.instruct_dataset
  template: truthful_qa.TruthfulQATemplate
  max_seq_len: 4096
  source: truthfulqa/truthful_qa
  split: train
  data_dir: truthful_qa

However, when I try to tune a model I am getting:
File "/home/dpalmasan/local/miniconda3/lib/python3.12/site-packages/torchtune/config/_instantiate.py", line 20, in _create_component
    return _component_(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dpalmasan/local/miniconda3/lib/python3.12/site-packages/torchtune/datasets/_instruct.py", line 183, in instruct_dataset
    ds = InstructDataset(
         ^^^^^^^^^^^^^^^^
  File "/home/dpalmasan/local/miniconda3/lib/python3.12/site-packages/torchtune/datasets/_instruct.py", line 76, in __init__
    if not isinstance(template(), InstructTemplate):
                      ^^^^^^^^^^
TypeError: InstructDataset.__init__() missing 3 required positional arguments: 'tokenizer', 'source', and 'template'

What are the steps to use a custom dataset from hugging face for an instruct task?

Hi @dpalmasan! Looks like you might be inheriting from the wrong base class for your template: you should try InstructTemplate, not InstructDataset like so:
class TruthfulQATemplate(InstructTemplate):
    template = "Instruction:\n{instruction}\n\nInput:\n{input}\n\nResponse: "

    @classmethod
    def format(cls, sample, column_map):
        return cls.template.format(**sample)

Okay I updated the code. Now I am getting issues with setting up the mapping. I have
dataset:
  _component_: torchtune.datasets.instruct_dataset
  template: truthful_qa.TruthfulQATemplate
  max_seq_len: 4096
  source: truthfulqa/truthful_qa
  split: validation
  data_dir: generation
  column_map:
    instruction: question
    input: type
    output: best_answer
seed: null
shuffle: True
batch_size: 2

I am getting:
File "/home/dpalmasan/local/miniconda3/lib/python3.12/site-packages/torchtune/datasets/_instruct.py", line 94, in __getitem__
    return self._prepare_sample(sample)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/dpalmasan/local/miniconda3/lib/python3.12/site-packages/torchtune/datasets/_instruct.py", line 99, in _prepare_sample
    prompt = self.template.format(transformed_sample, self._column_map)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/phi3/truthful_qa.py", line 9, in format
    return cls.template.format(**sample)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'instruction'
  0%|

Ohh that was the issue. I still had to make the script a package installed or add it to PYTHON_PATH to make it work. But it worked. Docs are a little bit confusing, for setting the mapping I also had to look at the code:
dataset:
  _component_: torchtune.datasets.instruct_dataset
  template: truthful_qa.TruthfulQATemplate
  max_seq_len: 4096
  source: truthfulqa/truthful_qa
  split: validation
  data_dir: generation
  column_map:
    instruction: question
    input: type
    output: best_answer
seed: null
shuffle: True
batch_size: 2

Maybe some examples might be good. Thanks for the quick answer.

Yep, we've definitely got to make our docs more clear - your input is much appreciated!
cc @RdoubleA


Added E2 hostip()

With the upcoming change that the http extension could be disabled by default, there will no longer be a way to get the server IP, that and having to do a http request to get the server IP is ridiculous, so with this we can get the IPv4 address through a function.

:+1:

Did you try it? The "hostip" convar returns the local ip, not the public ip, and also your code can return negative values in its string...

Err, now I remember why I never used this before, for hostip to be set correctly the server has to set the ip on the command line, which because most people use hosts that don't set that arg this never worked....

Just make the http request once at startup, store the result, return this result in hostip()

Yes but what will the request call, I'm sure there're sites for this though I'm not sure about long term stability depending how long said site will stay up.

api.ipify.org

Something like this:
local serverIP = "<IP_ADDRESS>"
function httpRequestServerIP()
	http.Fetch( "http://api.ipify.org/",
		function( data )
			if data:match("%d+%.%d+%.%d+%.%d+") then
				serverIP = data
			else
				timer.Simple( 2, httpRequestServerIP )
			end
		end,

		function( )
			timer.Simple( 2, httpRequestServerIP )
		end
	)
end
hook.Add( "Initialize", "httpRequestServerIP", httpRequestServerIP )

e2function string hostip()
	return serverIP
end

I've had issues with http where if called on Initialize, http itself may not be initialized yet which will result in an error and doesn't actually call the failed function, if you have a better idea let me know.
As for the failed count, if this website for some reason goes down or just keeps erroring we won't call it exponential, if you have a better amount of times to check please say.

I never had a problem with http not being ready when Initialize hook ran serverside. Are you sure? Also, as timers will not run until a player connect to the server, maybe a better method would be to call httpRequestServerIP() in a PlayerFirstSpawn hook and then remove this hook so it's only called once.

Ehh, it may be fixed now, I'll switch it to Initialize and if we get any issues with it then we can change it

@bigdogmat Do you really need an IP address, or just a unique identifier for each server?

@immibis I'm using it to tell the difference between servers.
My personal use for it was because I have a timer e2 and this way I can have different databases for each server, because servers can have different settings and using one database file could get to big eventually.
Though this is just something that we should have as it's serverinfo.

Worth noting that with the HTTP method, Wiremod nos has an external dependency on IPify.

What if you have multiple servers running on the same IP?
You'll probably want to add a port() function as well
But what if they all run on port 27015 as far as they're concerned and are just portforwarded to different external ports?
Then your strategy breaks down and you'd be better off with a UUID or something
Also, your function will never return an IPv6 address and that's going to be a problem in the future.

All valid points, but is there even a way to get a uuid for a server?
And as far as I can tell, there's no way to get an ipv6 from the source engine.

So you see my point?
Getting the IP is not reliable or useful in general, so let's not have this phone-home code in there.

Even if it's not a reliable way it's serverinfo so I'd say this should still be added. As for IPv6, the api we're using can output a json string with the IPv4 and IPv6 in it though I'm not sure how it'd be implemented.
Should it be 2 functions one returns IPv4 other returns IPv6, or keep same function but let it return an array with both?

It should be neither of the two. What the OP really wants is a way to identify a server, so let's implement that instead.
Step 1: Load UUID from disk
Step 2: If that fails, generate UUID and store it to disk
Step 3: Return loaded/generated UUID
It really is that simple.
UUID algos can be found everywhere on the net, but since there are only a handful of gmod servers out there (compared to what UUIDs are usually used for), you can just generate 128 random bits any way you like and encode them the usual UUID way.

I am op... And I was saying the a function to get the ip should still be here because it's serverinfo. As for the UUID, I could probably make this though I'm not sure how good I'd implement it.

...What's the use case for this? Having a unique server identifier for eg. storing per-server data? What else would you want to do with the server IP if the HTTP extension gets disabled?

Well the idea was to use the ip as a unique identifier for storing files,
since files are stored clientside. However I can definitely see how having
an actual UUID would be better, especially since the ip isn't even reliable
in any way.
On Mon, Nov 9, 2015 at 10:56 AM, Abigail<EMAIL_ADDRESS>wrote:

...What's the use case for this? Having a unique server identifier for eg.
storing per-server data? What else would you want to do with the server IP
if the HTTP extension gets disabled?
—
Reply to this email directly or view it on GitHub
https://github.com/wiremod/wire/pull/1010#issuecomment-155015065.

@bigdogmat can you give a better justification for why the server IP should be available if we have UUIDs?
If not, I'll close this and we can discuss this at #1013 instead.

I was just making the point that sense it's serverinfo it should be added, though because of the extra loops needed to get this info I'm fine with closing this if no one sees a reason to have it.

Maybe there's a way to get this information from the client?

Only way to get ip from source itself afaik is to get the hostip/ip convar which both will return the localhost unless -ip is set on the command line for scrds, only issue I've seen with this is that not many hosting companies and people set this so on almost all servers it returns localhost.

If anybody knows of a way to reliably get the host IP without having to make the host perform an HTTP request, feel free to reopen - but I think the lack of use in combination with the difficulty to implement is sufficient reason not to merge this. Thank you though @bigdogmat!

With UUIDs hopefully coming soon then my main reasons for having this is gone, though I do know you can get the ip through C so if that function ever gets added to gmod I'll reopen this.

Yeah uuids are better. Were you going to add that, @AbigailBuccaneer ?

@Divran yes - as soon as I have a desk for my desktop, which will be Saturday, I'll be able to get cracking on all the Wiremod tasks I'd like to do. UUIDs will probably the the first (as it's very small and quick) and then I'd like to work on the E2 extension GUI.


[WFLY-4241] Upgrade jsf-impl to 2.2.9-jbossorg-2

https://issues.jboss.org/browse/WFLY-4241

Linux with security manager Build 750 is now running using a merge of 8c7c90d0a9892c6bc6f8e39a7428feb8f3ae5e52

Linux Build 5764 is now running using a merge of 8c7c90d0a9892c6bc6f8e39a7428feb8f3ae5e52

Windows Build 874 is now running using a merge of 8c7c90d0a9892c6bc6f8e39a7428feb8f3ae5e52

Linux with security manager Build 750 outcome was SUCCESS using a merge of 8c7c90d0a9892c6bc6f8e39a7428feb8f3ae5e52
Summary: Tests passed: 795, ignored: 371 Build time: 0:07:01

Windows Build 874 outcome was SUCCESS using a merge of 8c7c90d0a9892c6bc6f8e39a7428feb8f3ae5e52
Summary: Tests passed: 2913, ignored: 366 Build time: 0:51:06

Linux Build 5764 outcome was SUCCESS using a merge of 8c7c90d0a9892c6bc6f8e39a7428feb8f3ae5e52
Summary: Tests passed: 2912, ignored: 366, muted: 1 Build time: 0:52:32


[BUG] Dev server build fails with Parse error due to a single typo in dependency

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins.
[x] I'm using npm
[x] I'm on macOS
[x] I run Snowpack on Node.js v12+

Describe the bug
I added the @uppy/react package and tried to import one of its components. I received a Parse error with very little information on why my build was failing. @IanVS found a typo in the uppy package which was causing the issue but Snowpack's behaviour here remains a mystery.
To Reproduce

Clone the reproducible repo: git clone https://github.com/nik-field/snowpack-uppy-issue
npm start
See error!

Expected behavior
An error message that is more helpful in debugging.
Anything else?
Notice that in the cached bundle FOCUSABLE_ELEMENTS.js, whose import statement had the typo, isn't valid JS and seems to be a kind of jumbled mess of code that snowpack did its best to output.

When I was trying to debug this, I found that the FOCUSABLE_ELEMENTS.js file finished the esinstall step correctly, but was creating two import maps, and was being processed twice, with the second time wreaking havoc and resulting in invalid js syntax.  That's about as far as I could get in the debugging.


projectors gui default max pulses is too big

It's currently 999999, should be 4000.

Max pulses is set to 4000 by default; I'm not sure when I did this. Max channels is still at 999999.


Move templates to openshift ns and use VM namespace when posting to ProcessedTemplates

Pull Request Test Coverage Report for Build 601

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 88.126%

Totals

Change from base Build 748:
0.008%

Covered Lines:
1733

Relevant Lines:
1889

💛  - Coveralls

Backport of #203


Unable to infer type from union with undefined when using mapped types

I'm getting some wierd behavior when trying to match possibly undefined type of a value from a mapped type with a generic union including undefined. strictNullChecks flag is on.
The code below better describes the problem.

TypeScript Version:  2.4.1
Code
// A *self-contained* demonstration of the problem follows...
type TStorage = {
    a?: number,
    b?: string
};
const storage: TStorage = {
    a: 1,
    b: '2'
};
//this was original function signature with return type
//but was commented to better reflect the problem with type inference
//function get<K extends keyof TStorage>(key: K): TStorage[K] {
function get<K extends keyof TStorage>(key: K) {
    //inferred type of result
    // const result: {
    //     a?: number | undefined,
    //     b?: number | undefined
    // }[K]
    const result = storage[key];
    return fromUndefined(storage[key]);
}

function fromUndefined<T>(value: T | undefined): T {
    return value!; //cast here is just for example
}

declare const b: string | undefined;
//const bb: string - correct
const bb = fromUndefined(b);

//const value: number | undefined - correct
const value = storage.a;
//const value2: number - also correct
const value2 = fromUndefined(storage.a);

//const a: string | undefined <----  Why undefined?
const a = get('b');

Expected behavior:
last const a is of type string
Actual behavior:
last const a is of type string | undefined

Is it correct behavior and I'm missing something about mapped types?

Optional parameter is marked as T | undefined, so that TStorage[K] is string | undefined indeed.
type TStorage = {
    a?: number,
    b?: string
};
type A = TStorage['a'] //=> number | undefined
type B = TStorage['b'] //=> string | undefined
type TStorageValue = TStorage[keyof TStorage] //=> string | number | undefined

I see.
And if return type annotation is removed from get shouldn't it then infer correct type?
function get<K extends keyof TStorage>(key: K) /* No return type */ {
    const result = storage[key];
    return fromUndefined(storage[key]);
}

Looks like result's type TStorage[K] is not processed by fromUndefined.

Seems like result's type
// const result: {
//     a?: number | undefined,
//     b?: number | undefined
// }[K]

is not evaluated when passing to fromDefined and therefore does not contain expected  | undefined
That's why I'll try to rephrase the question - are there any plans to support such functionality or it's an intentional design decision?

I have also updated original code with commenting get return type to better reflect the problem.

fromUndefined is just a kind of workaround for type subtraction, there are some limitations for it:
fromUndefined(undefined); //=> expected never, but got undefined

function something<K extends keyof TStorage>(key: K) {
    const result = storage[key]; //=> TStorage[K]
   fromUndefined(storage[key]); //=> TStorage[K]
}

For those real type subtraction, see https://github.com/Microsoft/TypeScript/issues/4183.

Thanks for the anwser. #4183 contains lots of useful links to similar issues so I'm going to close this.


hugo: enable emoji

Emoji in documentation can be useful to provide visual information (like disclaimer, check mark, etc.)
Currently, there are not rendered: https://www.flatcar.org/docs/latest/container-runtimes/getting-started-with-kubernetes/
See also: https://gohugo.io/getting-started/configuration/#enableemoji

The stage site for k8s is looking good now - https://lemon-wave-085522403-256.westeurope.1.azurestaticapps.net/docs/latest/container-runtimes/getting-started-with-kubernetes/


&caption command not working

&caption command not working in „Scott The Woz“. Here‘s the file the bot sent if you need it Message: Magick: unable to read pixel cache '/tmp/magick-4LPjuX9h5iLh1TjIwR7Fr2xo7G8iXxfm': File exists @ error/cache.c/ReadPixelCachePixels/4705
Stack Trace: undefined

Duplicate of #221


Enable build for codeql scanning

Test codeql scanning options

Codecov Report

Merging #7 (ba1f38b) into main (a828cb2) will increase coverage by 1.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   72.72%   74.07%   +1.34%
==========================================
  Files           3        3
  Lines          33       27       -6
  Branches       19        0      -19
==========================================
- Hits           24       20       -4
+ Misses          8        7       -1
+ Partials        1        0       -1

Flag
Coverage Δ

Linux
∅ <ø> (∅)

Windows
74.07% <ø> (ø)

macOS
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/main.cpp
22.22% <0.00%> (-8.55%)
:arrow_down:

test/tests.cpp
100.00% <0.00%> (ø)

test/constexpr_tests.cpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a828cb2...ba1f38b. Read the comment docs.


WIP PR containing #370

Hey @AALEKH - please change the commit message to be:
Scala Common Enrich: converting transactions from given currency to "home currency" (closes #370)

Closing this PR as @fblundun has merged all this into his branch. Thanks @AALEKH !


[routing-manager] classifying valid OMR prefixes

The method bool RoutingManager::IsValidOmrPrefix(const Ip6::Prefix &aOmrPrefix) looks overly restrictive. A valid OMR prefix could start with 0xfc as well. (Not necessarily 0xfd ) And a global IPv6 prefix does not necessarily start with the 3 bits 0b001 I think. It could also be configured in any other IPv6 namespace that may be made available in the future. I don't see value of a BR trying to 'play the role of a registry' and verify configured prefixes per today's IANA registrations. (Or is there a use case for that?) It seems not future proof.
https://github.com/openthread/openthread/blob/main/src/core/border_router/routing_manager.cpp#L894
Originally posted by @EskoDijk in https://github.com/openthread/openthread/issues/7900#issuecomment-1210523831

Thanks @EskoDijk .
On the first point regarding ULA, I just submitted: https://github.com/openthread/openthread/pull/8012

Looks like we already had a Ip6::Prefix::IsUniqeLocal() (which was checking for fc00::/7) but was not used.
One key change here is that with this PR we also allow for any ULA prefix (not require the ULA to be 64 bit length) - which I think is correct behavior. Thoughts?

On the second point (GUA), I think we probably need more thoughts/discussions:

Not clear to me how to define a GUA prefix?

We can go for https://www.rfc-editor.org/rfc/rfc4291#section-2.4 definition?
Or cover all reserved from https://www.iana.org/assignments/ipv6-address-space/ipv6-address-space.xhtml?

In general for a ULA/GUA prefix, for it to be a valid OMR prefix, it is required that a Thread Device can perform SLAAC using the prefix per (6LoWPAN) SLAAC procedures.  RFC 4944 defines (https://www.rfc-editor.org/rfc/rfc4944.html#section-6) that the prefix length MUST be 64 bits for SLAAC. So both for GUA/ULA, 64 bits length is a requirement.
On the GUA, yes section 2.4 defines it and also https://www.rfc-editor.org/rfc/rfc4291.html#section-2.5.4 . So a GUA is roughly "everything else" and that's why we don't need to check much about it.
So the simplest way to check if a GUA or ULA is a valid OMR prefix is to check all of below:

prefix length == 64
prefix does not start with ff::/8
prefix does not start with fe80::/10

PS so I think the ULA check as in #8012 isn't needed; and length check should be kept.  @jwhui Maybe you can verify if my RFC 4944 interpretation of a required /64 prefix to do SLAAC is correct.

PS so I think the ULA check as in #8012 isn't needed; and length check should be kept. @jwhui Maybe you can verify if my RFC 4944 interpretation of a required /64 prefix to do SLAAC is correct.

RFC 4944 Section 6 does make the following statement:
   An IPv6 address prefix used for stateless autoconfiguration RFC4862
   of an IEEE 802.15.4 interface MUST have a length of 64 bits.

Thanks guys!

Submitted https://github.com/openthread/openthread/pull/8016 to change the check.
Requiring prefix length to be 64 for sure keeps things simpler.


address #178

This PR should address #178 by switching to the higher QuasarNet threshold used in the Y3 productions (jura, kibo, loa).
In addition, new logic was added to make use of the MgII after-burner, which is used to update the redshifts of QSOs selected using the WISE variability.
Reviews of the changes are more than welcome since this PR is on the critical path for the Y3 FastSpecFit VAC @stephjuneau @abrodze @dylanagreen @reac2 @paulmartini
I spot-checked (definitely not exhaustively...) the changes for a handful of WISE_VAR_QSO targets against the Loa/v2 QSO catalog:
qq = Table(fitsio.read('/global/cfs/cdirs/desi/survey/catalogs/Y3/QSO/loa/QSO_cat_loa_cumulative_v2.fits'))
W = qq[qq['SCND_TARGET'] & scnd_mask.mask('WISE_VAR_QSO') != 0]
W[(W['Z'] != W['Z_RR']) * (W['PETAL_LOC'] == 8) * (W['TILEID'] == 2196)]['SURVEY', 'PROGRAM', 'TILEID', 'LASTNIGHT', 'PETAL_LOC', 'TARGETID', 'Z', 'Z_RR', 'Z_QN']
SURVEY PROGRAM TILEID LASTNIGHT PETAL_LOC      TARGETID             Z                  Z_RR           Z_QN
 str4    str4  int64    int64     int64         int64            float64             float64        float32
------ ------- ------ --------- --------- ----------------- ------------------ ------------------- ----------
  main    dark   2196  20210514         8<PHONE_NUMBER>8676189 1.8426234940651056 0.21284610066723475  1.8400584
  main    dark   2196  20210514         8<PHONE_NUMBER>2425208 1.3908909604133473 0.35709775247845316  1.3845339
  main    dark   2196  20210514         8<PHONE_NUMBER>0812154 0.9638393272404113 0.15632818780359653 0.95521694
  main    dark   2196  20210514         8<PHONE_NUMBER>5006556 1.6940631630485758  0.8588117378801023   1.679311

With this PR:
% fastspec /global/cfs/cdirs/desi/spectro/redux/loa/tiles/cumulative/2196/20210514/redrock-8-2196-thru20210514.fits \
  --targetids=39632951318676189,39632961372425208,39632961380812154,39632961385006556 -o f.fits
rr = Table(fitsio.read('f.fits', 'METADATA'))
rr['TARGETID', 'Z', 'Z_RR', 'ZWARN', 'ZWARN_RR']
     TARGETID             Z                  Z_RR        ZWARN ZWARN_RR
      int64            float64             float64       int64  int64
----------------- ------------------ ------------------- ----- --------
39632951318676189 1.8426234940651056 0.21284610066723475     0        0
39632961372425208 1.3908909604133473 0.35709775247845316     0        4
39632961380812154 0.9638393272404113 0.15632818780359653     0        0
39632961385006556 1.6940631630485758  0.8588117378801023     0        4

Note that the new (Z) redshifts match.
Versus with main:
% fastspec /global/cfs/cdirs/desi/spectro/redux/loa/tiles/cumulative/2196/20210514/redrock-8-2196-thru20210514.fits \
  --targetids=39632951318676189,39632961372425208,39632961380812154,39632961385006556 -o f2.fits
rr = Table(fitsio.read('f2.fits', 'METADATA'))
rr['TARGETID', 'Z', 'Z_RR', 'ZWARN']
<Table length=4>
     TARGETID              Z                  Z_RR        ZWARN
      int64             float64             float64       int64
----------------- ------------------- ------------------- -----
39632951318676189  1.8426234940651056 0.21284610066723475     0
39632961372425208 0.35709775247845316 0.35709775247845316     4
39632961380812154  0.9638393272404113 0.15632818780359653     0
39632961385006556  1.6940631630485758  0.8588117378801023     4

The second target in this list is a WISE_VAR_QSO target, so its redshift was not updated.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

9 of 47 (19.15%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 49.749%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

py/fastspecfit/io.py
9
47
19.15%

Files with Coverage Reduction
New Missed Lines
%

py/fastspecfit/io.py
1
53.13%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.09%

Covered Lines:
3177

Relevant Lines:
6386

💛  - Coveralls


GitHub action migration

Changes for migration from CircleIC to Github Actions.
For updates related to Publish to PyPi for took reference from https://github.com/splunk/addonfactory-ucc-generator
Added pre-commit lint
Added review secrets in the build-test-release workflow.
Added compliance-copyright and compliance-dependency in required for a build similar to UCC
Updated license in all required files and also updated licenserc.yaml as ignore-list file to similar to UCC
Verified the generated build by comparing with CircleCI main build only version diff.
Closes #41

:tada: This PR is included in version 5.0.5 :tada:
The release is available on:

v5.0.5
GitHub release

Your semantic-release bot :package::rocket:


Formatter element size 0x0 on Firefox?

From the Gitter chat (seems to happen on Firefox only):

Hi everyone, I'm back with another small issue. When I load annotations programmatically either via setAnnotations(), or multiple calls to addAnnotation(), the formatter does not work properly. I can see that the elements exist, but the svg size is 0x0 until I click on an annotation, or make a new one. After that point everything works properly.

https://gitter.im/recogito/annotorious?at=621be125c61ef0178e4c71ce

I reported this issue. Will let you know if I come across more info

Closing this issue due to lack of activity. Annotorious v3 is almost ready to go. (It's now a separate branch in this repo. It will have a very different (and IMO better) approach to labeling.
An early in-development version of the OpenSeadragon Text Annotator extension, which will become the successor to the ShapeLabels plugin (at least for the OpenSeadragon version!) is available here:
https://github.com/annotorious/annotorious-v3-extensions/tree/main/annotorious-osd-textlayer


Flutter Web : GetConnect Post API calls not working in Flutter web but working fine on android and ios devices

Describe the bug
I am using GetConnect for api call in my flutter project.
getx version : 4.6.6
flutter version : 3.16
here is API call function :
`class ApiProvider extends GetConnect {
@override
void onInit() {
httpClient.baseUrl = BASE_URL;
httpClient.defaultContentType = "application/json";
httpClient.maxAuthRetries = 3;
httpClient.timeout = Duration(seconds: 600);
}
Future loginUserApi(LoginRequest data) =>
post("v1/user/signIn", json.encode(data.toJson()),
contentType: "application/json" , headers: {
'Content-Type': 'application/json',
'Accept': '/',
'App-ID': 'CUSTOMER',
} );
}`
this function is working fine on android and ios devices but when I run my project on flutter web it says :
[GETX] Cannot decode server response to json
and in network tab of chrome it says : Status Code : 415 Unsupported Media Type
when I call same API using dio its working on flutter web and other platforms
**Reproduction code

create new project with getx version : 4.6.6
set up API provider class extending getConnect
create post api call there and try calling that post api call in flutter web.

Check on the browser console. Maybe it's blocked by CORS,

try flutter run -d chrome --web-renderer html

1- Go to flutter\bin\cache and remove a file named: flutter_tools.stamp  (in flutter sdk folder)
2- Go to flutter\packages\flutter_tools\lib\src\web and open the file chrome.dart.
3- Find '--disable-extensions' and add '--disable-web-security' under it.

1- Go to flutter\bin\cache and remove a file named: flutter_tools.stamp  (in flutter sdk folder)
2- Go to flutter\packages\flutter_tools\lib\src\web and open the file chrome.dart.
3- Find '--disable-extensions' and add '--disable-web-security' under it

I am facing same issue is there any work around for this, I tried above solutions but nothing works for me


Make baseline task faster

Expected Behavior
If I run detektMain and it throw an issue that I want to include in the baseline (for example, a false-positive) it would be nice to run detektBaselineMain be really fast because I didn't change anything in my code.
Current Behavior
detekt needs to run a complete inspection again.
Context
Lately, with the introduction of Compose in my code base I have a lot of false-positives (1.19.0-RC2 should fix nearly all of them). Usually I was running detektMain find out that it was a false positive and then run detektBaselineMain. The cicle was so slow that I end up running detektBaselineMain and using the changes in the baseline to know if I really have any new issue.
That approuch works but it's far from ideal because I don't get the benefit from the html report with the snippets and because I end up modifing by hand the baseline.
A way to fix it
I was thinking that detektMain could generate the baseline file too. But, instead of saving it in the defined location by the user we could save it somewhere inside the /build folder. This way, if I run detektBaselineMain the only thing that we need to do is to copy that already generated file in the defined location by the user and that's it. That should be really fast.
The big problem: when we run detektMain that task fails, so, probably, gradle will not think of it as "UP-TO-DATE" but I imagine that we could do something to fix it.
This fix would help us with the real issue behind #3785 too.

We can also act like Android Lint - there is no separate baseline task. The baseline file path is optional. If specified, the Lint task will generate a baseline file if it doesn't exist, and will read it if it does exist. To regenerate the baseline, delete the file and keep the baseline path specified. To stop using baselines, delete the file and remove the config specifying the file path.
I have suggested this before but couldn't find the comment though it was suggested we don't do this, but I can't recall why. I suppose it might be confusing for those not familiar with Android.

That wouldn't fix my use case, would it? I mean, I run detektMain with my current baseline. I found out a new false positive. I remove baseline.xml and I need to re-run detektMain and it should do the complete scan again.

I see, I misread your issue. So you want to run detektMain, then if you see an issue raised that you want to actually ignore, then you want to run detektMainBaseline so the baseline is rebuilt. And what you want is for the run of detektMainBaseline, if run after detektMain, to run quickly, since the analysis had already been done by detektMain.
Gradle Enterprise Gradle Plugin has a feature that's conceptually similar - after running a build, if you decide you want to upload the build scan data after the build, you run gradlew buildScanPublishPrevious to publish the result of the build that was just run. In this case, a task that copies the output of detektMain to the baseline path of detektBaselineMain on demand would do this for you.
I'm not sure this should be part of the plugin though. We could change the detektMain task like you suggested to generate the baseline in the build folder, then I think a custom Copy task that has the detektMain baseline output as an input and copies to wherever it needs to would achieve what you want.

I was thinking about other option:

Create a task that generates the reports and the baseline. Thst task will never fail. It doesn't care about how much issues it found.
Make detektMain (and family) depend on that task. Now detektMain is the one that reads the output of that task and decides if it should fail or not.
Make detektBaselineMain (and family) depend on that task. This task will just copy the file.

A bonus would be if we would be able to make that the first task only creates one file as output. Not a report nor the baseline. Just all the raw data that we need to generate the reports and the baseline. And then, in detektMain and detektBaselineMain we read that file and based on its information we create our reports, baselines, decide if we should fail, etc.
Would that be doable?

My issue is not related with RC1 (I'm still on 1.18.1) It's a bit related with our lack of support for Compose but not only. In general I found my self using more baseline just because I know what rule does and if it appears in the baseline I can fix it and remove it directly from the baseline and it works and it's faster. But I don't feel that no one should use baseline instead of the main task just because it is faster. For that reason I was thinking on this.

but it sounds complicated to build and possibly to use.

Which part seems complicated? I think that the complicated part is to create a file with all the needed information and the "map it" to different reports and baselines? I was hoping that sarif could be that "raw" format. It seems that it was created with this propouse "Static Analysis Results Interchange Format". But I don't feel it would have all the information we need.

I think that this idea could work but for sure it's not for 1.0 nor 2.0 so closing.


Explain registration feature in more detail (docs)

When reading docs I can't figure out what DRONE_OPEN/WOODPECKER_OPEN really do (if true, or prevent if false).
In the server's help text it says enable open user registration.
What if it's false, who can do what?
What if it's true, who can do what?

short answer:
DRONE_OPEN: people can register, you don't have to create them manually. With only this set, anyone with a Github/Gitlab.. etc account can register
DRONE_ORGS: further limits who can register. Only accounts from the listed orgs.
you most likely want DRONE_OPEN and DRONE_ORGS if you want to limit users to your company or open source project.
This part of the docs gets the closest to explain this, but I can see how it is not clear

So woth DRONE_OPEN=false, an admin can create users manually? Where is this done? And how does that work if gitlab, gitea or whatever is used as an auth backend?

With DRONE_OPEN=false, DRONE_ADMINS can use the platform, or you may add users with woodpecker user * CLI commands, although I never tried that.
The usernames are for authorization. Auth is done through the provider specific auth method, so your Github (OAuth) username is matched against the user name entry in Woodpecker.


Update dark theme

I fixed a few issues with the dark theme and updated it to match GitHub's current design.
If you don't accept PRs on GitHub anymore, feel free to cherry pick my latest commit bdfea21 (I pulled the latest version from Codeberg, so there will be no merge conflicts).

Hey! Thanks for contributing.
This repo is meant to be a read-only and users should use the Codeberg repo as the new source. Any reason Codeberg does not work for your use case?

I understand. Maybe consider archiving this repo then? This would make it read-only.
I assumed it might still be open for PRs for the very reason that it is not read-only, which to me was very welcome, as I don't like to create accounts on sites which I don't use.

Yeah I should have probably archived this one. Not sure why I didn't.

as I don't like to create accounts on sites which I don't use.

FWIW you can login/register at Codeberg with your GH account, which effectively means you don't need to create a new account.
Alternatively, you can set up a fork on GH and update this one.
I didn't have time lately to keep the theme up-to-date but would be happy to see contributions in the codeberg repo 👍


Update add_weekday for latest cftime

cftime PR 135 has now been released (see v1.1.0 in the changelog), meaning that datetimes are cftime.datetime by default, instead of datetime.datetime.
This means that the datetimes Iris uses no longer have the weekday() method, but instead have the dayofwk attribute.
Have therefore adjusted the 3 methods that were using weekday() to use dayofwk.
Note that this will not currently pass Travis CI while #3682 remains open (which is pending some other fixes to get Travis to pass).

Closes #3686

Since we now have two PR's (this and #3682), which both also need the fix from the other, we will be merging this PR while the image hash tests are still failing. #3682 can then be rebased onto the changes in this PR, giving us a fully passing suite of Travis tests :-)


[ja] Feature gates translation

fixes #46662

preview page: https://deploy-preview-47145--kubernetes-io-main-staging.netlify.app/ja/docs/reference/glossary/?all=true#term-feature-gate

/retitle [ja] Feature gates translation

/lgtm

/assign @nasa9084
for approval

/approve


Use explicitly sized unsigned integral data types and add more tests

Maybe, the parameter i has also be of type size_t?


Some items and applications do not show in Grafana, but they exist in Zabbix

Describe the bug
Items and applications do not appear in the Grafana fields, but they exist in the Zabbix hosts. In another host, the application and item field appear their respective data. (This bug only happens with some hosts and group of hosts, and they are with the same settings, changing only the name)
Expected behavior
I hope the items and applications appear in the fields in Grafana.
Screenshots

This is the host on Zabbix, with the respective applications and items

This is the host on Grafana, with the respective applications and items (showing the empty fields)

Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

7.1.4
5.0.2
4.0.2

Check if the metrics will be available if you change Query Mode to 'Text'

I think I know what the problem is. My hosts on Zabbix have special characters, such as "/". I think that when I select the host, it tries to use Regex. After changing the name of the hosts, mainly removing the "/", I no longer had this problem. At least not for now.
So, is this a bug to fix it? Or is it a feature of the plugin?
Thank you.


[DNM] Add a sleep after standalone vm creation

To workaround some indentified network issue in the extracted crc
adoption job, wait for a few minutes until the network is functional.
Only when the SLEEP_TIME variable is set, the sleep should be executed.

Closing this as it doesn't really solve the problem and found a better solution elsewhere.


Enclosure.stl

here the enclosure that has been split up into 3 parts for easier printing and has been repaired.  when the enclosure was in one file it made it hard to print and was a lot more to get printed, but now it should be easier to print and a lot cheaper.
Enclosure.zip

Hi Mr Austin , is it possible de to send me step file , thanks

sadly I don't know how to convert it to a step file, but its saved as a STL in the zip file.


I changed the background to silver and it is not allowing me to pass the challenge

Challenge Give a Background Color to a Div Element has an issue.
User Agent is: Mozilla/5.0 (X11; CrOS x86_64 9202.66.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.148 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Click here for cat photos.

Things cats love:

cat nip

laser pointers

lasagna

Top 3 things cats hate:

flea treatment

thunder

other cats

<form action="/submit-cat-photo">
  <input type="radio" name="indoor-outdoor" checked> Indoor
  <input type="radio" name="indoor-outdoor"> Outdoor
  <input type="checkbox" name="personality" checked> Loving
  <input type="checkbox" name="personality"> Lazy
  <input type="checkbox" name="personality"> Energetic
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
</form>

Your solution is incorrect. You have to complete the task according to the instructions:

Create a class called silver-background with the background-color of silver. Assign this class to your div element.

If you need help doing that, ask in the Help Room or on the forum. Github issues are for reporting bugs only.

Hi @Cvilain17
Thanks for reporting this issue.
Here are some next steps that you should follow before we can help you with your query:

Check these troubleshooting steps first.
Please use the Chat Rooms or try looking through our forum for help with a specific challenge and any coding assistance.

IMPORTANT:
Please NOTE that this tracker is for reporting bugs and enhancements to freeCodeCamp's code base only.
Happy Coding!


Change styling of stowed strikes toggle

Feel free to close if you think its not an improvement. I was worried that the previous button didn't properly communicate what it was.

On second thought, maybe I can live with "show stowed" :o)

Though could we have be somewhat smart and not show at all if there aren't any stowed weapons?


Add validation of sizes of arguments of OptimizationResults and unit tests

Summary
OptimizationResult newly introduced variables class variables in #1122.
But, there is not enough check of arguments. So I added a check of sizes of OptimizationResult._x and OptimizationResult._variables.
I fix bugs of generation of OptimizationResult detected by this check.
#1131 modifies the way to interpret OptimizationResult so that OptimizationResult becomes read-only.
But, some interpret did not treat variables correctly. I notice that there is no unit test about OptimizationResult.variable_names and OptimizationResult.variables_dict.
So I added some relevant unit tests.
Details and comments

@manoelmarques @woodsp-ibm If possible, could you include it in the new release? It is a bug fix of the converter rework #1061 and #1131.

Thank you for merging this bug fix at the last moment to release the new version.


Use the full path for comparison to fix a test failure in the qmlui build

Hi, this is part one of the CPP files patches to fix problems when running the unittests in a QMLUI environment under Linux.
This patch addresses the comparison of path names, when done relatively, there is no "contains" match due to the leading "./" in the relative path that is compared.

Massimo, the travis build has been disabled. I have seen a message announcing a change on their side:
Since June 15th, 2021, the building on travis-ci.org is ceased. Please use https://www.travis-ci.com/ from now on.

Hi, wow, I haven't received one single email from Travis informing me of service disruption...
I think I have migrated now to .com...hopefully it should work

Hello Massimo, thanks for reactivating the travis build.
Do you have a chance to trigger the builds on the two pull requests manually, so you we see the build results before considering to merge? Otherwise, I will change a line forth and back to push and trigger the build.
https://github.com/mcallegari/qlcplus/pull/1281 (this one) and
https://github.com/mcallegari/qlcplus/pull/1282

This is very simple and clear and can be merged right away. Thanks.
I'll take a look at the others later


Caching is not utilized for development

For some reason, in a cleaned repo, the cross test command does not pick up the cache from cross build command, so sudo make test which runs cross build first and then cross test takes a long time to finish.

This can also be seen from the CI run.
Ideally, once built, make test should be very fast.


Scrubber

Has anyone used react-native-video and created a scrubber? Seems there isn't one at the moment.
I'd like the user to be able to change the time using a scrubber (e.g. youtube videos).

did u ever find anything on this? i'm more interested to scrub locally store video, but the component should be similar internally.

@jasonwiener I ended up building my own. I used the React-native gesture responder system to drag the scrubber left and right, then calculating the new audio time based on the scrubbers positioning.
The gesture responder system made it pretty easy in the end.

thanks! any chance you wanna share?

@jasonwiener sure I'd be happy to, let me get my code in order and put it in a gist, I will give you a shout here when done

@jasecoop Truly appreciate that!

@jasecoop do you mean seek controls? like these https://github.com/brentvatne/react-native-video/blob/master/Examples/VideoPlayer/index.ios.js

@stereodenis Yep, in fact it was this that sent me in the right direction. On top of that I made the seek controls interactive so you can drag and seek. cc @jasonwiener

@jasecoop that's what i'm trying to get my head around as well!

@jasonwiener This code is a thrown together as it's a WIP, but I've tried to simplify. I hope you'll find it useful.
I'm using what I've called a 'toggle' (I'm sure there's a more technical name) for the element that's draggable. It's left positioning lives is stored in state.
On drag:

Calculate new toggle position and set state
On drag release:
Calculate percentage of toggle position to container width
Use this percentage to calculate the new audio/video time the user has dragged to
Seek to new time

React-native gesture responder system handles the dragging events for us. So just work out the maths of positioning relative to track current time and you're good to go.
Next I need to work out how to seek to a certain point of the track when the user touches the scrubber.
  getInitialState: function() {
    return {
      toggleLeftPosition: 0
    }
  },

  getCurrentTimePercentage() {
    var percentage = parseFloat(this.props.audio.currentTime) / parseFloat(this.props.audio.duration);
    var w = Dimensions.get('window').width;
    var x = percentage * w;
    this.setState({
      toggleLeftPosition: x
    })
  },

  setNewTime() {
    var x = this.state.toggleLeftPosition;
    var windowWidth = Dimensions.get('window').width;
    var percentage = (x*100) / windowWidth;

    var totalSeconds = this.props.audio.duration;
    var newTime = (percentage/100)*totalSeconds;
    this.setState({
      currentTime: newTime
    })

    // seek to new time
    this.props.audio.setTime(newTime)
  },

  setPosition: function(e) {
     //Update our state with the deltaX/deltaY of the movement
     this.setState({
       toggleLeftPosition: this.state.toggleLeftPosition + (e.nativeEvent.pageX - this.drag.x)
     });
     //Set our drag to be the new position so our delta can be calculated next time correctly
     this.drag.x = e.nativeEvent.pageX;
   },

   onRelease: function(e){
     this.dragging = false;
     this.setNewTime();
   },

   _onStartShouldSetResponder: function(e) {
     this.dragging = true;
     //Setup initial drag coordinates
     this.drag = {
       x: e.nativeEvent.pageX,
       y: e.nativeEvent.pageY
     }
     return true;
   },
   _onMoveShouldSetResponder: function(e) {
     return true;
   },

   caculateTime() {
     if(!this.dragging) {
       this.getCurrentTimePercentage();
     }
   },

  componentWillReceiveProps() {
    if(!this.props.audio.paused && this.props.audio.uri == this.props.uriSource) {
      this.caculateTime();
    }
  },

  render: function() {
    return (

      <View>
          <View
            style={ [ local.toggle, { left: this.state.toggleLeftPosition } ] }
            onResponderMove = { this.setPosition }
            onResponderRelease = { this.onRelease }
            onStartShouldSetResponder = { this._onStartShouldSetResponder }
            onMoveShouldSetResponder = { this._onMoveShouldSetResponder }
          />
      </View>

    );
  }
});

@jasecoop SUPER cool and thanks a ton. i'll give it a whirl and holler back with thoughts too! truly appreciate the openness!

@jasecoop Do we have a final version of this solution?


Temp/try to fix work manager on agp 7.0.0

Issue tracker:
https://issuetracker.google.com/issues/198549508
Stackoverflow:
https://stackoverflow.com/questions/68919344/after-upgrading-agp-version-from-4-2-1-to-7-0-0same-with-7-0-1-workmanger-not

issue
https://issuetracker.google.com/issues/198549508
is not fully fixed:
android.enableR8.fullMode=true
was disabled


Update Patch

This push includes the following updates:

Updated server code, now working and can launch successfully
ui edited via bootstrap, general design still in progress
/home and /login are rendering the layouts successfully
added routes for home and login

All good


⚠ Bofrost.fr has degraded performance

In 24a9ca0, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 870 ms

Resolved: Bofrost.fr performance has improved in c323a0a.


keyboard appears when checking the checkbox even with the requestKeyboardFocusOnCheckListChanged option set to false

Is there an existing issue for this?

[X] I have searched the existing issues

Flutter Quill version
9.3.1
Steps to reproduce
check the check box
Expected results
checkbox checked without opening the keyboard
Actual results
checkbox is checked but the keyboard appears
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

I did an analysis, the requeskKeyboard() method is called 3 times when a checkbox is selected, one of these 3 times the skipRequestKeyboard variable changes its value which causes the keyboard to appear on the screen


'Move to a new file' operation reformats code (typescript)

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.95.0

when i refactor my typescript code by using the 'Move to a new file' operation, it reformats the selected code instead of keeping it as it was.
for example, it

removes empty lines between functions
removes line breaks in function parameters

Do you have an explicit example of code where this happened? We cannot always preserve everything, but we do try to preserve most formatting.

@DanielRosenwasser
sure, here's one example from today where vscode changed my formatting
before:
export function VerticallyDraggableDisc(
	{ stateHandle, radius }:
	{
		stateHandle: StateHandle<number>,
		radius: number
	}
): SceneNode {
	...
}

function HorizontallyDraggableDisc(){ ... }

after selecting both functions and refactoring with Move to a new file:
export function VerticallyDraggableDisc(
	{ stateHandle, radius }: {
		stateHandle: StateHandle<number>;
		radius: number;
	}): SceneNode {
	// function body
}
function HorizontallyDraggableDisc(){ ... }


[Text Analytics] Use TextAnalyticsAudience in tests

API change check
API changes are not detected in this pull request.

/azp run net - textanalytics - tests

/azp run net - textanalytics - tests-weekly

/azp run net - textanalytics - tests-weekly

/azp run net - textanalytics - tests-weekly

/azp run net - textanalytics - tests-weekly


Download album and playlist from Youtube Music

What is the purpose of your issue?

[ ] Bug
[x] Feature Request
[ ] Question
[ ] Other

Description

download album and playlist from youtube music
example:
spotdl -p https://music.youtube.com/playlist?list=OLAK5uy_l3qf_fJNreo3L6_ZPIaLOquqfTda--gZc
or
spotdl -a https://music.youtube.com/playlist?list=OLAK5uy_l3qf_fJNreo3L6_ZPIaLOquqfTda--gZc
Log

Pleas look into existing comments/the README. This is already done along with many other major changes.


Fix Arm64 BE to correctly handle divide by zero

This builds upon #116  and fixes the Arm64 BE to correctly handle divide by zero.
Tested on Arm64 Linux.
After this PR is applied there is no user of the string table functionality.  I have left support in - but it may be worth removing in a future if there is no future need for it.

Thanks for fixing this @matt-gretton-dann


Bug: peers not notified of deletion when 2 nodes in network

Bug description

There are two nodes in a tailnet, A and B
Node B is deleted
A MapResponse is generated for node A. Node A no longer has any peers, so len(MapResponse.Peers) == 0
Tailscale interprets len(MapResponse.Peers) == 0 as no change, meaning it isn't notified of node B being deleted https://github.com/tailscale/tailscale/blob/43819309e18ac7d496643fcd86489a2ee0927964/control/controlclient/map.go#L227
Node B remains on tailnet after being deleted, causing a security vulnerability for deleted nodes

Should be fixed by implementing Peer list deltas (sending PeersDeleted explitcly in #1383)

Hi, can you please close this issue as we have #1383, it will help to see easily what are the urgent fix.
Thanks


crc start failing with "Failed to add podman host dns entry"

General information

OS: Linux , Fedora 37 with all system updates.
Hypervisor: I'm not sure - the default? All of KVM, qemu, libvirt, virsh, etc.. are available.
Did you run crc setup before starting it? Yes
Running CRC on: Baremetal-Workstation

CRC version
CRC version: 2.13.1+3b466f8
OpenShift version: 4.12.0
Podman version: 4.3.1

(upgraded today to crc-linux-2.13.1-amd64 - had the same issue with crc-linux-2.12.0-amd64)
CRC status
DEBU CRC version: 2.13.1+3b466f8
DEBU OpenShift version: 4.12.0
DEBU Podman version: 4.3.1
DEBU Running 'crc status'
Machine does not exist. Use 'crc start' to create it

CRC config
- consent-telemetry                     : no
- preset                                : podman

Host Operating System
NAME="Fedora Linux"
VERSION="37 (Workstation Edition)"
ID=fedora
VERSION_ID=37
VERSION_CODENAME=""
PLATFORM_ID="platform:f37"
PRETTY_NAME="Fedora Linux 37 (Workstation Edition)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:37"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f37/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=37
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=37
SUPPORT_END=2023-11-14
VARIANT="Workstation Edition"
VARIANT_ID=workstation

Steps to reproduce

Download crc-linux-amd64.tar.xz , unpack, add it on path... followed the instructions on redhat.com product documentation.
crc setup
crc start

Expected
Some kind of successfull start.
Actual
It fails to start, last message is:
Failed to add podman host dns entry: exit status 1

Logs
Uploaded: https://gist.githubusercontent.com/Sanne/6df940bae0e3d09ec34d865a4f2e709a/raw/e46f3b75e50d31668da84343caeb1872396512d1/crc%2520startup%2520failure
It was previously suggested to me to check the permissions of /etc.hosts ;
Running ls -la /etc/hosts :
-rw-r--r-- 1 root root 182 May  5  2022 /etc/hosts

Thanks!

@Sanne looking into following logs looks like crc-admin-helper-linux file permission is not correct
DEBU Using root access: make root Podman socket accessible
DEBU Running SSH command: sudo chmod 777 /run/podman/ /run/podman/podman.sock
DEBU SSH command results: err: <nil>, output:
DEBU Running '/home/sanne/.crc/bin/crc-admin-helper-linux rm podman.crc.testing'

Can you check if crc-admin-helper-linux permission is same as this? if not can you try crc setup --log-level debug and share the logs?
ls -l $HOME/.crc/bin/
-r-s--x---. 1 root    prkumar  5212680 Dec 24 10:01 crc-admin-helper-linux
-r-x------. 1 prkumar prkumar 12606528 Aug  4 15:58 crc-driver-libvirt

It would seem I have the same permissions:
-r-s--x--- 1 root  sanne  5212680 Jan 26 00:00 crc-admin-helper-linux
-r-x------ 1 sanne sanne 12606528 Jan 26 00:00 crc-driver-libvirt

Can you try running ~/.crc/bin/crc-admin-helper-linux  add <IP_ADDRESS> issue3490.crc.testing manually and see if this adds an entry to /etc/hosts?
Could it be selinux blocking the changes to /etc/hosts? If the previous test fails, can you try again after sudo setenforce 0?

I've run ~/.crc/bin/crc-admin-helper-linux  add <IP_ADDRESS> issue3490.crc.testing and got:

Error: host file not writable, try running with elevated privileges
host file not writable, try running with elevated privileges

No difference even after sudo setenforce 0.
Then tried sudo ~/.crc/bin/crc-admin-helper-linux  add <IP_ADDRESS> issue3490.crc.testing ... that worked, but I understand it shouldn't be necessary?

~/.crc/bin/crc-admin-helper-linux is suid root, so sudo should not be making a difference :-/

Maybe the mount options of ~/.crc/bin disable suid?

mount | grep home :
/dev/nvme1n1p1 on /home type ext4 (rw,nosuid,nodev,relatime)
Nailed it! Thanks - not sure how this option got there.

Interesting - I might have inherited it from an older Fedora version, I've been doing upgrades for some year. Bottomline, that might have been my own fault, but I do wonder if it's worth patching the crc installation process to be more robus about this.
What do you prefer, should we mark this issue resolved, or would you rather keep it open to potentially improve the sanity checks and/or error messages?

@Sanne keep it open we can add it as part of preflight check.


Update create-dapp-app docs

Description
Update docs for readability and actionability.
Only had time to go through the homepage and the digital-asset template.
For the digital asset template I was running into an issue with formatting the address, and was getting this error. Help resolving this error would be appreciated :)
cc: @gregnazario (if you happen to know the fix, or know were to find a working example config file for create-dapp-app digital asset version).
Error:

.env:
VITE_APP_NETWORK=testnet
VITE_CREATOR_ADDRESS=0x71e3cdf1ef86d575ae38c7c2d19f22b8c88eb2b15082691782e5b8c8da401568
VITE_MODULE_ADDRESS=0x59f86a8bae077b39d32a71b8d4641c558c0198765b6e7997a2d0a8545c1e3237

(I'm not clear what the "Owner" one is. Note the VITE_MODULE_ADDRESS is auto generated, so I'm confused why it wouldn't be formatted properly - maybe Owner is referring to something else entirely?)
Checklist

Do all Lints pass?

[ ] Have you ran pnpm spellcheck?
[X] Have you ran pnpm fmt?
[X] Have you ran pnpm lint?

What wallet did you use as the collection_creator_address? This happens if you use the google account (wish actually should be hidden on the wallet selector modal)

What wallet did you use as the collection_creator_address? This happens if you use the google account (which actually should be hidden on the wallet selector modal)

Ah yes, I did use the Google one for convenience since I don't have an Aptos wallet yet. I'll update the doc so that it warns against it.

CAD templates that require upload files dont use AptosConnect anymore

@0xmaayan I'm a bit confused as to why this PR was closed instead of merged. I think the updated steps make it a lot simpler to figure out how to use the create-dapp-app. (The AptosConnect thing I mentioned at the top was just an issue I ran into - not the main point of the PR). Happy to message offline as well :)

@0xmaayan I'm a bit confused as to why this PR was closed instead of merged. I think the updated steps make it a lot simpler to figure out how to use the create-dapp-app. (The AptosConnect thing I mentioned at the top was just an issue I ran into - not the main point of the PR). Happy to message offline as well :)

sorry my bad. from the PR description it looks like this PR handles some AptosConnect error when trying to create a collection.
Feel free to reopen and include only the doc updates changes


[Bug] App freze and crash, if LogEvent called before Firebase init

[REQUIRED] Please fill in the following fields:

Unity editor version: 2021.3.12f1
Firebase Unity SDK version: 10.0.1
Source you installed the SDK: .unitypackage
Problematic Firebase Component: Analytics
Other Firebase Components in use: Crashlytics
Additional SDKs you are using: Ironsource mediation with all network sdks. Google Play Services Billing, Inapp review. Onesignal
Platform you are using the Unity editor on: Mac Arm 64 (Rosetta)
Platform you are targeting: iOS
Scripting Runtime: IL2CPP
Pre-built SDK from the website or open-source from this repo: website

[REQUIRED] Please describe the issue here:
On app startup, I send App version and OS version with FirebaseAnalytics.LogEvent(), but it instantly freeze my app in editor or build.
I initilize Firebase with this code;
FirebaseApp.CheckAndFixDependenciesAsync().ContinueWith(task => {
FirebaseAnalytics.SetAnalyticsCollectionEnabled(true);

        var dependencyStatus = task.Result;
        if (dependencyStatus == Firebase.DependencyStatus.Available)
        {
            // Create and hold a reference to your FirebaseApp,
            // where app is a Firebase.FirebaseApp property of your application class.
            // Crashlytics will use the DefaultInstance, as well;
            // this ensures that Crashlytics is initialized.
            Firebase.FirebaseApp app = Firebase.FirebaseApp.DefaultInstance;

            // Set a flag here for indicating that your project is ready to use Firebase.
            IsInitialized = true;
        }
        else
        {
            UnityEngine.Debug.LogError(System.String.Format(
                "Could not resolve all Firebase dependencies: {0}",dependencyStatus));
            // Firebase Unity SDK is not safe to use here.
        }
    });

Steps to reproduce:

Initialize firebase on awake
Also call, log event on awake without waiting to initialize

Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)?

Most likely

What's the issue repro rate? (eg 100%, 1/5 etc)

%100, until I remove the log event line.

What happened? How can we make the problem occur?

Unity freezes on the line Log event function, has to force quit. It also happens on IOS build, app freezes and crash after some time.

I have the same problem with 10.0.1 and Unity 2021.3.11f1

I haven't had any luck reproducing this on my end.  Can I ask why you need to LogEvent before the initialization, and can't wait until afterwards?  It is definitely recommended you initialize before doing any of the other calls, but it shouldn't freeze things.
Something you can try is adding:
Firebase.App.LogLevel = Firebase.LogLevel.Debug;

before any of the other calls, which will make it log more what is happening, which might give some insight as to the problem.

@a-maurice I fixed my issue with creating a callback under ContinueWith(task =>.
Well let me explain my usage, I call initialize firebase at the beginning. After the initialize function, I also call log.event to send if the app or os is updated.
I wonder if it's normal behavior to freeze and crash the whole game if Firebase isn't initialized somehow. Isn't that should be queue that log? event until firebase initializes?
I had to downgrade my firebase SDKs to 9.6.0 as the 10.0.1 package is not compatible with Ironsource adapters, I will reproduce this in a new project and share it here.

It definitely shouldn't be freezing or anything, which is the odd part.  Especially in editor, where Analytics doesn't reach out to the backend at all.  If you do have anything you can share that reproduces this, or any logs from the freeze, that'd be great.  Especially if it is in the editor, the Unity editor logs might have some hints as to what the problem is.


Remove Galley's old processer

The new processor pipeline was introduced in 1.3 and enabled by default in 1.4. The old pipeline was retained until the 1.5 (now).
As a reference from https://github.com/istio/istio/pull/15891,

The new pipeline is a superset of the old pipeline, including the following:

Intrinsic support for listening to mesh config changes and restarting the pipeline.
Intrinsic support for listening to CRD changes and restarting the pipeline when a change is detected.
Support for starting up without requiring all CRDs to be present.
The structure is amenable to handle multi-resource config analysis & CRD status update

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test lint_istio

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test lint_istio

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioio-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioio-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioio-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test unit-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

e2e-dashboard_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-dashboard_istio

e2e-simpleTests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests_istio

e2e-simpleTests-cni_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-cni_istio

e2e-simpleTests-distroless_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-simpleTests-distroless_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioio-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

integ-framework-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-framework-k8s-tests_istio

e2e-mixer-no_auth_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-mixer-no_auth_istio

integ-istioctl-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioctl-k8s-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-istioio-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-istioio-k8s-tests_istio

integ-telemetry-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-telemetry-k8s-tests_istio

integ-galley-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-mixer-k8s-tests_istio

integ-pilot-k8s-tests_istio
c05d55a17591a49ae89d31b4267cc2e0c358bc47
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
2b457645589c925929ede51da533774d0e152206
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
11e75a4e1d15b8381564b6fe6898446f582dc72f
link
/test integ-security-k8s-tests_istio

unit-tests_istio
2b457645589c925929ede51da533774d0e152206
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
2b457645589c925929ede51da533774d0e152206
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
f65011879d2103f27a20f6b4d8d04411dad398ba
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
f65011879d2103f27a20f6b4d8d04411dad398ba
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
29c29c034b87483e834f4cfd4fa35034952f7910
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Map is displayed with a height of 0

If I have <AzureMap> as the sole content of my Index.razor page, it displays fine. (This was in a small sample app I wrote).
But when I move it to my application I want to use it in, which has a lot of stuff in the MainLayout.razor, it has a height of 0. I finally tried to force a height doing the following:
<div style="width: 600px; height: 600px;">
<AzureMap Id="map"
          CameraOptions="new CameraOptions { Zoom = 12 }"
          Controls="new Control[]
{
    new ZoomControl(new ZoomControlOptions { Style = ControlStyle.Auto }, ControlPosition.TopLeft),
    new CompassControl(new CompassControlOptions { Style = ControlStyle.Auto }, ControlPosition.BottomLeft),
    new StyleControl(new StyleControlOptions { Style = ControlStyle.Auto, MapStyles = MapStyle.All() }, ControlPosition.BottomRight)
}"
          StyleOptions="new StyleOptions { ShowLogo = false }"
          EventActivationFlags="MapEventActivationFlags.None().Enable(MapEventType.Ready)"
          OnReady="OnMapReadyAsync" />
</div>

But it's still a height of 0:

According to this reply, there needs to be a way to call the component to tell it to resize.
I've put this in as a bug rather than an enhancement because the component is not useable in many use cases without this.

Because the library cannot guess what your application should look like, the styling is entirely up to you.
The samples should be displaying the map without any issue. Try to include the following css on your application and see if it works :
#map {
    position: fixed;
    width: 100%;
    height: 100%;
}

That works great - thanks - dave


Impossible to use DELETE in Bundle with Azure FHIR API

Describe the bug
I'm using Azure FHIR API, I try to do a batch DELETE using BUNDLE like described in the FHIR documentation
http://www.hl7.org/FHIR/bundle.html
FHIR Version?
R4
Data provider?
Azure FHIR API
To Reproduce
I'm doing this:

tokenFIHR=$(curl -s -X POST "https://login.microsoftonline.com/${tenant_id}/oauth2/v2.0/token" -d "client_id=${client_id}&client_secret=${client_secret}&grant_type=client_credentials&scope=https://{azure-tenant-id}.azurehealthcareapis.com/.default" | sed -n 's|.*"access_token":"\([^"]*\)".*|\1|p')

 curl -X POST -H "Authorization: Bearer $tokenFIHR"  -H "Content-Type: application/fhir+json; charset=utf-8"  -d '{"resourceType":"Bundle","id":"bundle-transaction","meta":{"lastUpdated":"2021-03-11T11:22:16Z"},"type":"transaction","entry":[{"request":{"method":"DELETE","url":"Patient/1234567890"}}]}' https://{azure-tenant-id}.azurehealthcareapis.com

Expected behavior
I expected this response (with the type "transaction-response"):
{
  "entry": [
    {
      "response": {
        "status": "200 OK"
      }
    }
  ],
  "resourceType": "Bundle",
  "type": "transaction-response"
}

Actual behavior
But I get this response (with same type "type":"transaction"")
{"resourceType":"Bundle","id":"7f555118-0cdb-40f7-9f97-aa6db06e28fe","meta":{"versionId":"1","lastUpdated":"2021-03-23T16:57:08.433+00:00"},"type":"transaction","entry":[{"request":{"method":"DELETE","url":"Patient/1234567890"}}]}

and my data was not deleted, any idea what I'm doing wrong ?

@DevWantJustHaveFun - Right now we don't support transaction bundles on the Azure API for FHIR, only batch bundles.

If posting to the https://server/ endpoint in Azure API for FHIR, then I would expect that you would receive an error when "type":"transaction"
If posting to the https://server/Bundle endpoint you would store the Bundle as a Resource, so it would be echoed back like in the example above.

@CaitlinV39  @brendankowitz  thanks for your responses, that's helped
the trick was to POST the bundle to "https://server/" and use the "type":"batch"
I get a successful response when I call the Azure FHIR API this way:
curl -X POST -H "Authorization: Bearer $tokenFHIR" -H "Content-Type: application/json" -d '{"resourceType":"Bundle","id":"bundle-batch","meta":{"lastUpdated":"2018-03-11T11:22:16Z"},"type":"batch","entry":[{"request":{"method":"DELETE","url":"Patient/1234567890"}}]}' https://{azure-tenant-id}.azurehealthcareapis.com/

Can you confirm that, now I can delete my patient and all this dependency (for example observation) in one bundle (one http call :tada: ) but there is no guarantee about the data consistency if some bundle entry are failing in between right ?

Correct, all calls within a bundle are treated independently. In the batch bundle response you can inspect the status of each of the request outcomes

@DevWantJustHaveFun let us know if you have additional questions!

@CaitlinV39 only one question, when the "transaction" will be supported ? :)


Fix: 'ttir.sum' op requires attribute 'keep_dim'

Fixes https://github.com/tenstorrent/tt-forge-fe/issues/763, Fix https://github.com/tenstorrent/tt-forge-fe/issues/777
Also done some cleanups and forge related changes for reduce ops like reduce_sum, reduce_mean, and reduce_avg and expanded the testcases
Logs
test_reduce_max.log
test_reduce_mean.log
test_reduce_sum.log
test_phi2_clm.log
test_phi2_sequence_classification.log
test_phi2_token_classification.log

For Golden checks, let's prepare this PR to be compatible with changes from here:

Unified verification logic #739

Mentioned PR contains grouped way of how verification should work. Can you sync with @vkovinicTT and update this PR to suite pending changes? :))

I don't like seeing multiple unrelated changes in one PR. This change escalated to 29 files changed with no obvious reason, especially when @vkovinicTT is already working on something similar.
@ashokkumarkannan1 @nvukobratTT I think, it's best to just keep the keep_dim changes in this PR, and remove everything else unrelated to it. Then we can merge this today without causing problems with merge conflicts and additional synchronization with test verification changes by @vkovinicTT

I agree with @pilkicTT. Lets separate these two.

For Golden checks, let's prepare this PR to be compatible with changes from here:

Unified verification logic #739

Mentioned PR contains grouped way of how verification should work. Can you sync with @vkovinicTT and update this PR to suite pending changes? :))

I don't like seeing multiple unrelated changes in one PR. This change escalated to 29 files changed with no obvious reason, especially when @vkovinicTT is already working on something similar.
@ashokkumarkannan1 @nvukobratTT I think, it's best to just keep the keep_dim changes in this PR, and remove everything else unrelated to it. Then we can merge this today without causing problems with merge conflicts and additional synchronization with test verification changes by @vkovinicTT

Sure @pilkicTT . I will update this PR. Thanks for the comments @nvukobratTT  @dgolubovicTT


Make a few improvements to the MSIs

Use https for the www.rust-lang.org link.
Fix the cmd.exe shortcut's working directory to not point to the documents folder of whoever installed it, which is wrong if it's installed globally.
Use the 64-bit cmd.exe on 64-bit windows for the shortcuts.
Send a WM_SETTINGCHANGE message at the end of the MSI install to update the %PATH% immediately. This should help with issues like rust-lang/rust#25781 and rust-lang/rust#32419.

Note: the WM_SETTINGCHANGE change uses WixBroadcastEnvironmentChange which requires WiX 3.10 and I believe the buildbots are still running 3.9 so they will have to be updated.

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)

I'm going to look into upgrade the windows image to the most recent wix, though I don't want to deploy right because nightlies are borken. Once nightlies work, we can deploy the new windows image with the new wix, then merge and deploy this new configuration.

I've made the new ami. For my own reference it's ami-3c1f5b5c.

I've deployed the new windows image. Let's see if it successfully build nightlies tonight.

Sorry for the delay. This should go into tonight's nightlies.


Add chapter on using profiles

With profiles gaining more importance as an alternative to Vulkan versioninig, we should have a chapter for them under "Using Vulkan".

Is there a chapter / section specific for each layer? I was trying to find a reference with the validation layer.

There is one for Validation https://github.com/KhronosGroup/Vulkan-Guide/blob/main/chapters/validation_overview.adoc
If there is already a good "how and what are profile layers" documentation, it would be simple to add a chapter here that just briefly explains what they are and then points to everywhere one needs to go for the various parts (source, SDK for built version, config options, etc)


Update icu tar to match one referenced in build script

Currently build.sh fails because it references icu4c-55_1-src.tgz, but this repository contains icu4c-52_1-src.tgz. To fix the problem, I grabbed icu4c-55_1-src.tgz from http://download.icu-project.org/files/icu4c/55.1/icu4c-55_1-src.tgz.

Merged, thanks! (I might do a git filter-branch later to delete the older tar.gz file and reduce the download size of the repo)

Awesome, thanks! Yeah, the filter-branch sounds like a good idea :+1:


feat: update rsbuild version

feat: update rsbuild version

Thank you, i was just working on a pull request to fix kernel panics in modernjs :P

Haha, we will make modern.js follow the latest Rspack / Rsbuild version