add a command to quickly recycle everything in the inventory possible

 autistic.sack.of.friends on Discord says

ideally it'll also do transformations such as 2 quarter decies + 1 half device -> 1 whole device, but i'm not sure what the best way to do that would be technically speaking

 autistic.sack.of.friends on Discord says

i'm already working on it btw

 autistic.sack.of.friends on Discord says

i don't know if i can safely assume recycling every possible device in the inventory will always be able to go in, but i guess i can just throw items on the floor if not

 autistic.sack.of.friends on Discord says

i mean yeah

 autistic.sack.of.friends on Discord says

5 pipes, every other slot full

 autistic.sack.of.friends on Discord says

able to recycle the first 4

 autistic.sack.of.friends on Discord says

hmm...

 autistic.sack.of.friends on Discord says

not sure how to get a full stringified list of tags

 yarden.zamir on Discord says

This was the last time someone tried something similar Keybinds to quickly specialize and stow held devices

 autistic.sack.of.friends on Discord says

ah, hmm

 autistic.sack.of.friends on Discord says

ok at the moment the code doesn't have to care about anything other than quarter devices

 autistic.sack.of.friends on Discord says

yarden.zamir is it safe to rely on that for now?

 yarden.zamir on Discord says

you mean relaying on specific fractions instead of arbitrary? Yes I think it's safe as I hate the fractions anyway and am not likley to use them much more than we do now

 autistic.sack.of.friends on Discord says

i thought of a neat way to do it anyway

 autistic.sack.of.friends on Discord says

like a way that doesn't care about fraction sizes and uses the same code for both size 1 and size 4

 autistic.sack.of.friends on Discord says

hmm

 autistic.sack.of.friends on Discord says

how would i remove an item given only it's slot reference

 autistic.sack.of.friends on Discord says

ok i think i got it working?

 autistic.sack.of.friends on Discord says

it leaves remainders properly

 autistic.sack.of.friends on Discord says

 autistic.sack.of.friends on Discord says

the duplicated items are from a system to reset the player's inventory

 autistic.sack.of.friends on Discord says

hmm

 autistic.sack.of.friends on Discord says

yarden.zamir i'm going to change the device system very slightly so each generic device also has it's own tag

 autistic.sack.of.friends on Discord says

to make it easier to create "the generic for the crafting_placeholder device@

 autistic.sack.of.friends on Discord says

for example

 autistic.sack.of.friends on Discord says

eh, doesn't seem neccesary

 autistic.sack.of.friends on Discord says

i think the device's id should be stored somewhere

 autistic.sack.of.friends on Discord says

like the sturdy bit

 autistic.sack.of.friends on Discord says

ok the command seems to work fine?

 autistic.sack.of.friends on Discord says

player.give() automatically handles dropping items on the floor

 autistic.sack.of.friends on Discord says

it even handles stack sizes over 64

 autistic.sack.of.friends on Discord says

 yarden.zamir on Discord says

Sure, just make sure to test if you are changing things with "moving parts"

 autistic.sack.of.friends on Discord says

yeah

 yarden.zamir on Discord says

I prefer not, I like that right now the behavior comes from the tag and the recipes and that's it

 autistic.sack.of.friends on Discord says

i guess? why though

 autistic.sack.of.friends on Discord says

maybe the tag could be auto-generated from the id if not provided, and there'll be a global table of devices with ids

 autistic.sack.of.friends on Discord says

i'll look at how the hammer does it's stuff i gues

 autistic.sack.of.friends on Discord says

we've got some unpleasant duplication here

 autistic.sack.of.friends on Discord says

there's just no way to get the generic from an item directly, right?

 autistic.sack.of.friends on Discord says

actually wait

 autistic.sack.of.friends on Discord says

there's probably a way to get it from recipes

 autistic.sack.of.friends on Discord says

oh god

 autistic.sack.of.friends on Discord says

that's how you're getting stonecutter recipes?

 yarden.zamir on Discord says

Yes, the complexity is fun

 autistic.sack.of.friends on Discord says

it wasn't an "oh god. it's incomprehensible"

 autistic.sack.of.friends on Discord says

it's more a "wow. why are you iterating over every stonecutter recipe"

 yarden.zamir on Discord says

No i mean the Computational complexity big o notation stuff

 autistic.sack.of.friends on Discord says

oh, right

 autistic.sack.of.friends on Discord says

yeah, you seem to have a lack of concern for perf

 autistic.sack.of.friends on Discord says

so how would you propose i do this? the code is a LOT harder to read if you can't just say "hey. sturdy device. generic."

 autistic.sack.of.friends on Discord says

oh yeah is there a way to detect what's on the player's cursor?

 autistic.sack.of.friends on Discord says

i'm thinking i have a sub mode where if you click on the "compact" button with something on your cursor it only tries to compact what's there

 .eweer on Discord says

Inventory Tweaks does that. By default if you have a grid that could do it (for coal a crafting grid, aka 3x3, For slime either your inventory 2x2 or grid...), K compresses all the items of your inventory that are the same that you are hovering and Shift + K only the stack you are hovering.

Just letting it be known in case you want "inspiration" :')

 autistic.sack.of.friends on Discord says

sounds cool, don't think we can do such neat keybind based ui though

 autistic.sack.of.friends on Discord says

we're stuck with inventory buttons that run commands

 .eweer on Discord says

But how can you hover an item and click on the button at the same time?

 autistic.sack.of.friends on Discord says

you can have one on your cursor

 autistic.sack.of.friends on Discord says

like when you're moving it

 yarden.zamir on Discord says

It's not my top priority, but in this case I belive you overestimate the preformance cost here.

 .eweer on Discord says

Ah, I see, would that be worth the headache? It seems quite a headache due to "ghost" clicks (aka when you want to click on a UI but game decides that nope, now you throw your items to floor)

 autistic.sack.of.friends on Discord says

there are a lot of stonecutter recipes

 autistic.sack.of.friends on Discord says

i guess it's on user interaction

 autistic.sack.of.friends on Discord says

it can take an entire millisecond if it wants

 yarden.zamir on Discord says

I think cycling through the inventory for each item

check stonecutter recipes that make it
cycle inventory for their inputs

 yarden.zamir on Discord says

Yes, it is a lot of computation, but yea I don't think there will be any noticable lag delay or tick issues from that

 autistic.sack.of.friends on Discord says

is there any structural advantage to having to re-extract this data every time you want it though

 autistic.sack.of.friends on Discord says

with an entire for loop

 yarden.zamir on Discord says

Just the genericness. But I don't mind if you add a step in the device script that adds that generic to a list

 yarden.zamir on Discord says

Though a tag is the same in that sense

 autistic.sack.of.friends on Discord says

yeah, i guess so

 autistic.sack.of.friends on Discord says

what should the generic's tag be

 autistic.sack.of.friends on Discord says

forge:devices/generic/sturdy?

 autistic.sack.of.friends on Discord says

also the devices/device distinction in the tagging system looks not great to me

 yarden.zamir on Discord says

I don't think we are on the same page, I don't mean different tag for each device

 yarden.zamir on Discord says

should be plural in all cases for tags I think

 autistic.sack.of.friends on Discord says

well then what's the best way to decide what all items tagged forge:device/sturdy should be compacted into?

 yarden.zamir on Discord says

Ah I see what you mean now, you itirate over the results not the generics. I was thinking doing exactly what I said above but filteting to check only devices

 yarden.zamir on Discord says

We can do your aproach though, it's better, i was just stubbern with tags

 yarden.zamir on Discord says

We can tag the generic with forge:devices/sturdy/generics

 yarden.zamir on Discord says

or `forge:generics/devices/sturdy

 yarden.zamir on Discord says

That's better because we leave the option for not all generics are devices

 autistic.sack.of.friends on Discord says

yeah

 autistic.sack.of.friends on Discord says

like the yellow nugget

 yarden.zamir on Discord says

yea

 autistic.sack.of.friends on Discord says

so should i do some string manip to turn the device tag into the generic tag or should we just have one string that's used for both

 yarden.zamir on Discord says

the former i think

 yarden.zamir on Discord says

leaves more room for us to use them seperetly \

 .eweer on Discord says

By the way, you are in devices.js, right?

 .eweer on Discord says

Line 355 should be commented before release

 yarden.zamir on Discord says

We can also make switch between logging to kjs and miencraft log to chat

 yarden.zamir on Discord says

Sometimes more useful

 autistic.sack.of.friends on Discord says

ok, made two commands

 autistic.sack.of.friends on Discord says

/bulkrecycle and /bulkrecycle all

 autistic.sack.of.friends on Discord says

all means it won't try to leave at least one item in each stack it's touching

 autistic.sack.of.friends on Discord says

future improvement: notice when there are two stacks of the same item, only bother keeping one stocked up

 yarden.zamir on Discord says

If you remove things from the inventory using the clear function then the slot doesn't matter, meaning you can add up all items on the same type then use clear on all the total amount of each, should work

 autistic.sack.of.friends on Discord says

oh, true

 autistic.sack.of.friends on Discord says

could clear every item minus one

 engineersmith_4628 on Discord says

What's unpleasent lol; it's so clean compared to else where in the code base

 autistic.sack.of.friends on Discord says

anyway can we ideally avoid storing the data about what goes into what primarily in tags

 autistic.sack.of.friends on Discord says

if you find yourself going "how do i get every stonecutter recipe for this item" the solution should not be a for loop most likely...

 engineersmith_4628 on Discord says

ye

 engineersmith_4628 on Discord says

that's why maps are best

 engineersmith_4628 on Discord says

Like I started with trades

 autistic.sack.of.friends on Discord says

rhino doesn't support classes

 autistic.sack.of.friends on Discord says

because they hate us

 engineersmith_4628 on Discord says

https://github.com/EngineerSmith/Create-Prepare-to-Dye/blob/trades/kubejs/server_scripts/base/trading/companies.js

 engineersmith_4628 on Discord says

https://github.com/EngineerSmith/Create-Prepare-to-Dye/blob/trades/kubejs/server_scripts/base/trading/agreement.js

 engineersmith_4628 on Discord says

You can still do something like it

 autistic.sack.of.friends on Discord says

yeah i know

 autistic.sack.of.friends on Discord says

not that hard either

 autistic.sack.of.friends on Discord says

i have really gotta work out if there's a nice way to display company-specific trading contract appearances

 autistic.sack.of.friends on Discord says

would i set the count of the ingredient to say how much to clear....

 autistic.sack.of.friends on Discord says

ok i was trying this

 autistic.sack.of.friends on Discord says

with the /claer command

 autistic.sack.of.friends on Discord says

the ingredient count doesn't actually metter

 yarden.zamir on Discord says

Not the command, use the kubejs wrapper, I use it in some other places

 autistic.sack.of.friends on Discord says

oh oops mispoke for some reason

 autistic.sack.of.friends on Discord says

it was the kube wrapper

 autistic.sack.of.friends on Discord says

it doesn't seem to respect input ingredient count

 autistic.sack.of.friends on Discord says

and doesn't have a form that takes a count input

 autistic.sack.of.friends on Discord says

https://github.com/Yarden-zamir/Create-Prepare-to-Dye/pull/499

 autistic.sack.of.friends on Discord says

ok it works!

 autistic.sack.of.friends on Discord says

i'll go deal with the complaints

 autistic.sack.of.friends on Discord says

oh yeah that's done now

 yarden.zamir on Discord says

Awesome! Great job!

 autistic.sack.of.friends on Discord says

yarden.zamir accidentally left an error in there! i'll commit a fix now

 yarden.zamir on Discord says

go over my comments too

 autistic.sack.of.friends on Discord says

oh, thanks

 autistic.sack.of.friends on Discord says

couldn't find any information on how tag locations worked

 yarden.zamir on Discord says

hmm. i wish prs synced with their relevent issues

 yarden.zamir on Discord says

me nither, was a nightmare to figure out

 yarden.zamir on Discord says

took me more than i want to admit

 yarden.zamir on Discord says

lol

Awesome, merge from main and fix the conflict and we can merge

 yarden.zamir on Discord says

autistic.sack.of.friends you still need to cover all cases where the old device tags were used like the hammer. Do a global search to see none are missed

 autistic.sack.of.friends on Discord says

oh yeah

 yarden.zamir on Discord says

fogot about it when i wrote that

 yarden.zamir on Discord says

i only remembered bacause i alrady broke it by doing the exact same before lol


Automated cherry pick of #3661: Replace busybox source to fix image errors

Cherry pick of #3661 on release-1.2.
#3661: Replace busybox source to fix image errors
For details on the cherry pick process, see the cherry pick requests page.

Codecov Report

Merging #3681 (f7bf88c) into release-1.2 (e9d7d23) will decrease coverage by 17.85%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-1.2    #3681       +/-   ##
================================================
- Coverage        60.66%   42.81%   -17.86%
================================================
  Files              285      146      -139
  Lines            22455    18374     -4081
================================================
- Hits             13622     7866     -5756
- Misses            7394     9803     +2409
+ Partials          1439      705      -734

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
42.81% <ø> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Add an error callback for AmiGO service

Need to add an "error" callback for queries to the AmiGO API. File/service in question is the createAmigoFeatureSet function in https://github.com/web-mev/mev-frontend/blob/main/projects/web-mev/src/app/d3/components/topgo/topgo.service.ts

Completed with fd9238abe0f68ec8b58d71f56ae5d19437122e95


rename special components page, mention rehype pretty code

@nf-core-bot fix linting

okay, needs to have some css added it looks like...

okay, needs to have some css added it looks like...

Yes was just looking at the preview thinking that it was good to add so that we can see what is missing! 😅
Also just realised that you already had a section on file names, which I accidentally duplicated.

I am adding the needed css now

Also just realised that you already had a section on file names, which I accidentally duplicated.

Fixed


JetBrains: Unable to remove remote repo for one specific project.

Installation Information
Plugin version: 5.3.2999-nightly
IDE version: IC-233.14475.28
Describe the bug
Steps to reproduce:

Have Cody plugin installed in your JetBrains IntelliJ IDEA editor
User is already logged in to Cody with Enterprise account and few remote repo are already added
Click on '-' button from Context window to remove remote repo.
Upon removal, click on "New Chat" button and verify the Context window

Observed behavior:
Remote repo are still there and not removed correctly.
Though, this behavior is only for this specific project and it is working fine with my other projects.
Here is the log snippet,
2024-03-05 02:14:43,987 [11890112]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ ChatPanelsManager:createWebviewPanel: 1
2024-03-05 02:14:43,987 [11890112]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView []
2024-03-05 02:14:43,987 [11890112]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView []
2024-03-05 02:14:43,987 [11890112]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider:registerWebviewPanel: registering webview panel
2024-03-05 02:14:43,988 [11890113]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView []
2024-03-05 02:14:43,988 [11890113]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: handleInitialized
2024-03-05 02:14:43,988 [11890113]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: updateViewConfig  {
  "arch": "x64",
  "os": "win32",
  "extensionVersion": "1.6.0",
  "uiKindIsWeb": true,
  "debugEnable": true,
  "serverEndpoint": "https://sg02.sourcegraphcloud.com/",
  "experimentalGuardrails": false
}
2024-03-05 02:14:44,340 [11890465]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/scip-dotnet","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToxMDI=","inclusion":"manual"}]}]
2024-03-05 02:14:44,350 [11890475]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/scip-dotnet","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToxMDI=","inclusion":"manual"}]}]
2024-03-05 02:14:44,355 [11890480]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/smoke-tests","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToyMDA=","inclusion":"manual"}]}]
2024-03-05 02:14:44,371 [11890496]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/cody","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToy","inclusion":"manual"}]}]
2024-03-05 02:14:44,376 [11890501]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/about","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeTo0NjA=","inclusion":"manual"}]}]
2024-03-05 02:14:44,394 [11890519]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/clabot-config","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToyMTc=","inclusion":"manual"}]}]
2024-03-05 02:14:44,493 [11890618]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/jetbrains","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToxMQ==","inclusion":"manual"}]}]
2024-03-05 02:14:44,501 [11890626]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/scip-typescript","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToxODY=","inclusion":"manual"}]}]
2024-03-05 02:14:44,518 [11890643]   WARN - #com.sourcegraph.cody.agent.CodyAgentClient - Cody by Sourcegraph: █ SimpleChatPanelProvider: postContextStatusToWebView [{"displayName":"github.com/sourcegraph/sg","providers":[{"kind":"search","type":"remote","state":"ready","id":"UmVwb3NpdG9yeToyMzE=","inclusion":"manual"}]}]
2024-03-05 02:14:45,730 [11891855]   INFO - #c.i.w.i.i.j.s.JpsGlobalModelSynchronizerImpl - Saving global entities to files

Expected behavior
Remote Repo should be removed correctly.
Additional context
Video link:
https://drive.google.com/file/d/1sa8rOb4rKus34j0pExQhnkfyG6dEv17Q/view?usp=drive_link

I think this one can be related to the flakiness of our persistence 😕 I am looking at it...


ADD more complete json output

This patch allow the wp-sec command to return a json object with the list of vulnerabilities and not only a count.

Uhm, for some reason behat doesn't like the new JSON with count and details...

Thnx for updating. I just checked the behat test. It's the blank space at the end of the json edited in the feature. Once removed it should pass :-)

Thank you!


The samples tests are flaking

See the sample test results here:
https://source.cloud.google.com/results/invocations/a512f6b7-49ce-4b79-8360-01f4e5186297/targets/cloud-devrel%2Fclient-libraries%2Fnodejs%2Fpresubmit%2Fgoogleapis%2Fnodejs-speech%2Fnode10%2Fsamples-test/log
  23 passing (2m)
  1 failing
  1) BetaFeatures
       should run speech diarization on a local file:
     AssertionError: expected 'Transcription: I\'m here\n hi I\'d like to buy a Chrome Cast and I was wondering whether you could help me with that\n Hulu which color would you like we have blue black and breath\n let\'s get the black one\n okay Chris would you like the New Concord Ultra model or the regular Comcast\n regular Chrome Cast design\n okay sure would you like to ship it regular or Express\n Express please\n terrific it\'s on the way thank you very much thank you\n bye\nSpeaker Diarization:\n word: bye, speakerTag: 0' to match /speakerTag: 1/
      at Context.it (system-test/betaFeatures.test.js:41:12)
      at process._tickCallback (internal/process/next_tick.js:68:7)

I'm wondering if this was just upstream flakiness, I haven't been able to trigger the same error yet.

Need some help from the API team, but it looks like this is just flakiness on their end and not anything to do with the client and/or the samples. I think we either have to just deal with it or change our assertions to not care what the value of speak tag is, just that it is present.

I reached out to @beccasaurus over email, who should be able to point us in the right direction :)

The Beta Speech diarization feature is not guaranteed to detect 2 speakers, sometimes only 1 speaker is detected.

@beccasaurus oh man I'm a little late now, but whenever we see the failure we actually don't get speaker 1, but rather speaker 0. This threw me off because the upstream docs say it should be a 1-based index.

I agree with @callmehiphop the way failing diarization is now handled is not ideal, getting a small set of results with tag 0 is not really useful.


Make extension hook methods protected - part 2

Follow up to this comment
There's a list of of $doNotMakeHookProtected in the extension-protector script created for this issue
Methods that matches this name were left public because there are currently being called directly
Notes

The 6.0.0 changelog has already been updated to broadly mention that extension hook implementations have been changed from public to protected, so no need to update changelog

Acceptance criteria

Go through the list of these of $doNotMakeHookProtected methods and where possible and appropriate, update code so they are not being called directly
If it's not sensible to stop calling the method directly, look for where the extend() call is and evaluate whether this should be

Changed to call the method directly
Removed
Updated so the method in the call to extend() is not the same name as the one being called directly

Change visibility on remaining extension hook methods that aren't called directly from public to protected

CMSEditLink() PRs
Kitchen sink CI run
Recipe reporting job failing because we're forking framework

https://github.com/silverstripe/silverstripe-framework/pull/11338
https://github.com/silverstripe/silverstripe-admin/pull/1809
https://github.com/silverstripe/silverstripe-assets/pull/628
https://github.com/silverstripe/silverstripe-cms/pull/2987
https://github.com/silverstripe/silverstripe-siteconfig/pull/173
https://github.com/silverstripe/silverstripe-versioned/pull/463
https://github.com/silverstripe/silverstripe-elemental/pull/1236
https://github.com/silverstripe/silverstripe-reports/pull/191
https://github.com/silverstripe/silverstripe-versioned-admin/pull/357
https://github.com/symbiote/silverstripe-advancedworkflow/pull/546
https://github.com/silverstripe/silverstripe-frameworktest/pull/199
https://github.com/silverstripe/developer-docs/pull/557

Other PRs
Kitchen sink CI run
Recipe reporting job failing because we're forking framework
Note these can be merged independently of the CMSEditLink PRs

https://github.com/silverstripe/silverstripe-admin/pull/1810
https://github.com/silverstripe/silverstripe-assets/pull/629
https://github.com/silverstripe/silverstripe-asset-admin/pull/1485
https://github.com/silverstripe/silverstripe-auditor/pull/88
https://github.com/silverstripe/silverstripe-campaign-admin/pull/321
https://github.com/silverstripe/silverstripe-contentreview/pull/249
https://github.com/silverstripe/silverstripe-cms/pull/2989
https://github.com/silverstripe/silverstripe-elemental/pull/1237
https://github.com/silverstripe/silverstripe-errorpage/pull/118
https://github.com/silverstripe/silverstripe-framework/pull/11339
https://github.com/silverstripe/silverstripe-frameworktest/pull/202
https://github.com/silverstripe/silverstripe-graphql/pull/597
https://github.com/silverstripe/silverstripe-ldap/pull/86
https://github.com/silverstripe/silverstripe-mfa/pull/559
https://github.com/silverstripe/silverstripe-realme/pull/154
https://github.com/silverstripe/silverstripe-session-manager/pull/209
https://github.com/silverstripe/silverstripe-sharedraftcontent/pull/251
https://github.com/silverstripe/silverstripe-subsites/pull/591
https://github.com/silverstripe/silverstripe-testsession/pull/91
https://github.com/silverstripe/silverstripe-userforms/pull/1317
https://github.com/silverstripe/silverstripe-versioned/pull/465
https://github.com/symbiote/silverstripe-advancedworkflow/pull/547
https://github.com/bringyourownideas/silverstripe-composer-update-checker/pull/93
https://github.com/tractorcow-farm/silverstripe-fluent/pull/873
https://github.com/silverstripe/developer-docs/pull/558

Note that I'm intentionally not touching the following extension hooks on the list:

canViewInLocale
canViewStage
isArchived
isAvailableInLocale

Looking at the way these are used, they're intentionally left public so they can be called like regular methods - but invokeWithExtensions() is used to invoke them as a safety measure since those methods don't technically exist on the object that we want to call them from.

There's a bit too much going on here to give me confidence, could we resolve and merge the (get)CMSEditLink() PRs first, rebase any of the non-(get)CMSEditLink() PRs and then redo the kitchen sink build

@GuySartorelli Now that we're using getCMSEditLink() - could you please redo the kitchen-sink CI run with the updated PRs

Sure, but all we did was change the name of things so it'll be the exact same result.

Please update the sink run, it's unlikely though there may have been a small regression accidentally introduced. It should just a matter of:

running composer update -W --no-install on the branch of recipe-kitchen-sink
pushing the updated composer.lock file
updating the link in the issue

Please update the sink run

I'm going to, gimme some time lol

@emteknetnz You've approved https://github.com/silverstripe/silverstripe-framework/pull/11338 but not merged it, but then you assigned the issue to me? Did you forget to hit merge?

I've rebased the PRs that had cmseditlink changes and rerunning sink.
Likely I'll have to rebase others too, but I'm letting it run as-is before I do that.


"てぃ" should be translated to "ti", not "tei"

Half vowels are not translated correctly.
てぃ -> tei is wrong

the commit 5230b46 should address this issue.


A way to tell if a specific dependency has changed since the last time we ran the rule

Yes, I know, this is terrible for hermetic builds, but GHC recompilation avoidance won't work otherwise. GHC needs to know if the source file has changed so it knows to unconditionally recompile the file; if the source file hasn't changed, GHC can do a more fine-grained check on the dependencies to see if recompilation is necessary.
Shake can't do this check, because it is at a much finer granularity than Shake can handle (it's not, "Did this .hi file change" but "did the ABI hash on this declaration change"). To teach Shake how to do GHC recompilation avoidance, you would have to (1) remove dependencies on hi files (otherwise you'll rebuild when any bit in an hi file changes), and (2) generate needs on specific declarations/export lists as GHC is parsing/renaming/typechecking a file. This is NOT impossible, but GHC would have to be refactored to do this.

I imagine this is possible somehow, by abusing rules and IO, but not immediately sure how. I'll need to wait until I'm back at a computer and have a think.

Can you sketch out a flow chart of the decisions you'd ideally like to be made? Something along the lines of:

If the .hs file hasn't changed, skip.
If the .hs file has changed, take the .hi file and the .hi of all immediate dependencies and run some GHC supplied function (that does the hash check or whatever - but the details are irrelevant if we can't break it apart - only the inputs/outputs matter - e.g. what goes in, does a single Eq'able hash come out).
If the previous test returns False, then compile.

At a first guess, I think a two-step dependency structure of depending on the file, and then on the hash, should do it in some way. Shake has unchanging builds, which let you "abort" a recompilation (because a dependency didn't change), and I think that should let us have Shake encode the rules but GHC do the checking.

So, here's how ghc --make works today:

If an .hs file has not changed, and all of its transitive dependencies (GHC unconditionally preprocesses and parses files to build an import graph every run of the compilation manager), we just skip compilation unconditionally. (This is referred to as "stable" in GhcMake.)

Otherwise, if an .hs file has not changed (so there is an existing, newer hi file) but it's not stable, we run the recompilation checker. The way this proceeds is we read in the old hi file, and then check if each recorded "usage" is consistent with the transitive set of interface files available to us. It is NOT the immediate dependencies; we may record a usage for something further down the tree, or even something external.

Otherwise, we compile.

Does your proposal work? If I understand correctly, you want to compute some sort of "environment hash", which combined with the source file are sufficient to tell if recompilation could change something.
I think this would work, but GHC doesn't generate any such hash presently. This is because you need to record enough information to be able to generate the hash in the first place (the usages), in which case it is much more straightforward to store the individual hashes and check them one-by-one.
But unchanging builds might give us a way out: instead of trying to agglomerating all of the hashes into a single hash, we could just have Shake track each of the individual dependency hashes. I thought this would not be possible to do (because I still need to need the actual interface file), but I think with unchanging builds, this concern no longer holds.
I must warn: there are a lot of these dependencies, so I don't know if atomizing in this way is actually a good idea. (We're also duplicating information which is stored in the hi file). I'm sure you'll know better!

So, I attempted to implement this, but I couldn't figure out how to write the Rule instance for my hashes.
Suppose that every Haskell declaration has a "declaration hash" associated with it. I created a new data type to identify declarations, and wrote a Rule instance from declarations to hashes. The way I use this is, after compilation, I zip through the list of declarations Haskell used and run "action" to add them to the dependencies.
Unfortunately, I can't load the stored hash from storedValue, because Shake won't let me pass in some important variables to my function.
What should I do in this case? If I have storedValue return Nothing I get tons of lint errors (and it doesn't work); if I have storedValue return a bogus fingerprint, I don't get any lint errors but it still doesn't work.

I think the answer is, don't use a rule, use an oracle!

OK, I've successfully implemented this using oracles, so I'm going to close this.

An important extra thing that arose while I was CRing my code: you DON'T want to use an Oracle for this; a persistent cache is better.

An important extra thing that arose while I was CRing my code: you DON'T want to use an Oracle for this; a persistent cache is better.


Fix bug preventing some roles from being copied during logical replication

Role names containing characters that require the name to be wrapped in quotes, e.g. "test.user", were being excluded.

Notify https://aptible.slack.com/archives/C03120ZGNPK/p1645198589071849 when the images have been updated.


np.float -> np.float64 fix

I've completely refactor Prince, so I don't think this is necessary anymore. Feel free to reopen if it is :)


alt_svc_cache: adding flush capabilities

Risk Level: low
Testing: new unit tests.  integration test TODO in a follow up
Docs Changes: n/a
Release Notes: will land with integration test.
Fixes https://github.com/envoyproxy/envoy/issues/18034

/wait on CI

/wait still not tidy argh

/lgtm api


WIP: Analysis refactorizing

Here's a notebook containing every analysis dataframe/plot that are working: https://gist.github.com/valschneider/fe7ee87e4ff3a6e3e443a316d21c04c0
Changelog:

Instored a colourblind-friendly colour cycle, so that we don't have to think about which colours to use
Added a requires_events decorator that both asserts trace events are available and add them to the method documentation.
Factorized plotting code (creation/saving to file)
Documented the shape of the returned DataFrame for all df_* methods.
Made all plotting methods return the matplotlib.axes.Axes they created/manipulated
Added a load_tracking analysis module for... load-tracking related analysis
Un-camelCased some methods
Incinerated the other analysis modules and factorized their ashes.

Things left to do:

Assert that some analysis methods haven't been broken (notably check that master.df_latency == next.df_task_states)
Status analysis
Thermal analysis
Update uses of the analysis API in lisa/tests/kernel
Update uses of the analysis API in lisa/tests/lisa
Un-camelCase the remaining offenders
(probably in a later PR) Make sphinx generate an example plot for plotting methods' documentation.

So I've just verified that master.df_latency == next.df_task_states, which is cool considering how much I've butchered the method creating this dataframe.

Alright, that's all of the remaining analysis modules + all (I think) comments addressed.

Fixed overutilized labelling
Fixed broken calls to plot_overutilized()


About page update

Status
Type

:white_check_mark: Ready
Feature

Description
In this PR I have refactored the ContributorCard code, in order to add contributors without an Github account to be more flexible.
In addition to this I have added new contributors

Motivation and Context

Screenshots / GIFs (if appropriate):

Checklist

[x] I have read the CONTRIBUTING document.
[x] I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
[x] I have documented my code if needed

Resolves

@noctera can you please resolve conflicts?


Adding CHECK_SERVICE_ACCOUNT to khcheck deployment

Should have done this in #361 but forgot.
This way people don't have to read the code to know about this setting.
The default SA is the default account that will be used by default so this won't matter for anyone who doesn't want to overwrite it like me..

Looks good from the testing on my end. I think it would also be good to clean up the deployment-sa that is defined in the .yaml files for the deployment check and switch to using the default sa.

The deployment-sa account should still be needed to be able to deploy the pods.
The reason why I need the CHECK_SERVICE_ACCOUNT function in Openshift is due to that I create a SA account that I allow to run containers as root which is needed since the deploy check deploys nginx and sadly nginx always is run as root.
I could of course use deployment-sa to do this but since this SA don't need to be able to run containers that runs as root after the changes that was recently done to the Dockerfiles I don't want to give this account any extra access that isn't needed.
Or did i misunderstand you?

I think I misunderstood you here.
Would you suggest moving away from using nginx servers?

I don't think it's worth the job to move away from nginx.
In a dream scenario Red Hat or nginx would release a non root container but I don't think they have nor will and I don't want to try to maintain something like that on my own.
The good thing with nginx is that everyone knows what it is so it's a very simple deployment and service to debug if something strange would happen.


does not render using griffe-pydantic if imported with __all__

When importing a Pydantic model from a private module to a public module, the class can be rendered in MkDocs by adding it to the __all__ dunder variable. However, this renders Pydantic model classes as regular classes, ignoring changes expected by having griffe-pydantic installed.
When rendering in MkDocs directly in the public module (without importing from a private module), the Pydantic model renders with griffe-pydantic as expected.

Hi @butterlyn, thanks for the report. It's quite curious indeed, let me investigate.

Sorry but I cannot reproduce the issue you describe. Could you please provide a minimal reproduction example?

@butterlyn could you let me know if you still have this issue with v1.1.0?

Cannot reproduce and no update, closing for now, feel free to comment further!


Add homebrew cask

Title says it all. :)

@jottr I cannot proceed with this until #10 is resolved.

@quanglam2807 see https://github.com/caskroom/homebrew-cask/pull/30265

@jottr Awesome!!!!


Hide the popup on upload pages + show the descript. on the page

Description

Disabled the pop-up window when user enters the submission pages.
Put the description on the page.
Add the word "Prompt" before the placeholder text + comment on code for the future developers so that they know what needs to be changed later.
Modify the stylings for a better UI.

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[x] Yes
[ ] No
[ ] Not necessary

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

Current view of the submission page:


"Stejari" is listed in the drop-down menu

Description:
"Stejari" is listed in the drop-down menu alongside its corresponding county, according to the law
Precondition:
The website is up an running.

Step 1
Type "Stejari" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Stejari, GORJ".


Adding contact flow

Add + icon on addresses screen https://zpl.io/bWdkA91
Adding contact screen https://zpl.io/aMR9MZK

Add error when QR code does not contain beam address

Example:

Actual:

Prevent invalid characters from being entered in the contact's address

Cannot enter some valid characters in an address to create a contact
video_2019-08-29_15-57-50.zip

should display an invalid address error after the user has moved to another field.
video_2019-09-03_16-04-06.zip

checked


Feature Request: prefer-template-url and prefer-style-urls

Would love to have optional rules prefer-template-url and prefer-style-urls (or similar names), which will force you to create an html and a style file as opposed to have the html and css within the component.ts file
Thanks!

Following the feature request process that lodash has, I'm closing the issue and adding votes needed label.
Later we can prioritize the feature requests by popularity and include them in a future release.

@mgechev would love to create a pull request with these rules if you think they make sense. The angular style guide mentions this as a DO in here https://angular.io/guide/styleguide#style-05-04, so it would be nice to have theme at least optionally.
If you think it makes sense and my PR will make it, are there any guidelines to follow or recommendations?

Currently, we have the rule component-max-inline-declarations which checks whether the number        of line is above 3. You can configure this rule with the number 0. You'll have an error like this:
Exceeds the maximum allowed inline lines for template. Defined limit: 0 / total lines: 1 (https://angular.io/guide/styleguide#style-05-04)

Nice! that is what I needed! Thanks!


Branch v1.4 UGDG

Codecov Report

Merging #335 (5fdffcf) into master (8054370) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
+ Coverage     66.04%   66.10%   +0.06%
  Complexity      889      889
============================================
  Files           139      138       -1
  Lines          3222     3219       -3
  Branches        543      543
============================================
  Hits           2128     2128
+ Misses          980      977       -3
  Partials        114      114

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8054370...5fdffcf. Read the comment docs.


Orchestrator: Changes not working

I have created branch with a work item editor and a few attributes and data elements.
I wanted to check the content so tried to run a CR preview through the Orchestrator as the DITA generation isn't working; #244
I received the error below. Will this be working in the next Mauro release? It has worked in the past.

Issue burned as it is duplicate of #314


Performance regression with project build in da663656 ...

Pressing F6 to build my project went from about 5 seconds to several minutes.
Adding logging to the build() function in projectService.ts shows that calls to emitFile() are taking ~1500-3000ms per file and my project has ~170 TS source files.
Via git bisect I've narrowed it down to either c797b2de7e693fa65f6bea241c6e3df013d06fd8 or da66365677b489c73cdfb716c83f6933fcba3b97 (the former is a fix needed to actually build the project, so I can't test between these two without source changes).
commit c797b2de7e693fa65f6bea241c6e3df013d06fd8
Author: Basarat Syed<EMAIL_ADDRESS>Date:   Thu Sep 3 10:15:10 2015 +1000

    fix(typescript) latest version of typescript expects `package.json` to be passed in in the initial file set

commit da66365677b489c73cdfb716c83f6933fcba3b97
Author: Basarat Syed<EMAIL_ADDRESS>Date:   Thu Sep 3 09:08:59 2015 +1000

    chore(ntypescript) update to latest

Running atom-typescript/node_modules/ntypescript/bin/tsc directly takes ~3.5s and I get similar results with the current stable version of TypeScript, so the issue appears relate to the way the compiler is being invoked rather than an issue with the tool itself.

I'll have a look :rose:

A normal call to services.getEmitOutput(filePath); takes under a 50ms as shown below:
HILD ERR STDERR: C:/REPOS/atom-typescript/lib/main/lang/fixmyts/quickFixRegistry.ts

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: Duration: 11ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: C:/REPOS/atom-typescript/lib/main/lang/fixmyts/quickFixes/addClassMember.ts

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: Duration: 23ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: C:/REPOS/atom-typescript/lib/main/lang/fixmyts/quickFixes/addClassMethod.ts

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: Duration: 26ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: C:/REPOS/atom-typescript/lib/main/lang/fixmyts/quickFixes/addImportStatement.ts

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: Duration: 16ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: C:/REPOS/atom-typescript/lib/main/lang/fixmyts/quickFixes/equalsToEquals.ts

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: Duration: 9ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: C:/REPOS/atom-typescript/lib/main/lang/fixmyts/quickFixes/extractVariable.ts

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: Duration: 23ms

But in your code it is taking 1500ms! :
CHILD ERR STDERR: c:/REPOS/passcards/addons/firefox/src/main.ts: 1657ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: c:/REPOS/passcards/addons/firefox/src/panel_content.ts: 1474ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: c:/REPOS/passcards/cli/agent.ts: 1411ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: c:/REPOS/passcards/cli/agent_server.ts: 1398ms

C:\REPOS\atom-typescript\dist\worker\lib\workerLib.js:175 CHILD ERR STDERR: c:/REPOS/passcards/cli/agent_test.ts: 1797ms

How to test
Wrap this line as follows:
let start = new Date();
var output = services.getEmitOutput(filePath);
console.error(`${filePath}: ${(new Date()).getTime() - start.getTime()}ms`)

Recommend raising this with Microsoft/TypeScript.

Has to do with compiler options. The following definitely speeds is back to 3.5s mark:
    "compilerOptions": {
        "target": "es5",
        "module": "commonjs",
        "declaration": false,
        "noImplicitAny": false,
        "removeComments": true,
        "noLib": false,
        "preserveConstEnums": true,
        "outDir": "../dist",
        "sourceMap": false,
        "jsx": "react"
    },

The culprit is "noEmitOnError": true,. Please raise with Microsoft/TypeScript or change the tsconfig to allow emit on error :rose:

Will do. Thanks @basarat !

From the linked issue, this is by design :rose:

Thanks for investigating. The explanation makes sense, although it should be possible to preserve the purpose of 'noEmitOnError', making sure that the JS on disk only reflects the last-successfully-typechecked state of the project, in an incremental way. That's something to be discussed upstream I think.
A short term measure in atom-typescript would be to abort the build with an error if noEmitOnError is set, rather than building the project very very slowly.

I've created a separate issue to track your ideas : https://github.com/TypeStrong/atom-typescript/issues/603


Update data-lake-store.md

Added overview, removed client section, added code example and updated with link to sample. @CamSoper for reference, will have team review to sign off.

Same comments as on the data-lake-analytics.

Scott doesn't like the vars
Open the PR against master, please.  My bad for not communicating that earlier.  :(

Thank you!  :)

:x: Validation status: errors

File
Status
Preview URL
Details

api/overview/azure/index.yml
:x:Error

Details

:x:Error

Details

api/overview/azure/index.yml

[Error] Error transforming model "W:\pifi-o-unknown\raw-\c2knv0k5.5co\rawmodel\api\overview\azure\index.raw.json" generated from "api/overview/azure/index.yml" using "ManagedReference.html.primary.js". Error running Transform function inside template preprocessor:

[Error] Error transforming model "W:\pifi-o-unknown\raw-\c2knv0k5.5co\rawmodel\api\overview\azure\index.raw.json" generated from "api/overview/azure/index.yml" using "ManagedReference.html.primary.js". Error running Transform function inside template preprocessor:

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[bug]: MacOs Installer 2.2.4: Segmentation fault: 11 using the Browser-based UI

Is there an existing issue for this?

[X] I have searched the existing issues

OS
macOS
GPU
mps
VRAM
128G
What happened?
I have downloaded the InvokeAI-installer-2.2.4-mac.zip and then installed using the defaults values.
I start invoke.sh using browser-based UI option. The server starts as usual.
Then, as soon as I access the server with the browser, I got the following error:
/invoke.sh: line 24: 11785 Segmentation fault: 11  .venv/bin/python .venv/bin/invoke.py --web $*
The command-line works as expected.
NOTE:
When I install manually the same version 2.2.4  using git clone and Conda, both the browser-based UI and the command-line work as expected.
attached are :
Log at 2022-12-11 11-24-01 PM.txt
problem-report.txt
Screenshots
Do you want to generate images using the

command-line
browser-based UI
open the developer console
Please enter 1, 2, or 3: 2

Starting the InvokeAI browser-based UI..

patchmatch.patch_match: INFO - Compiling and loading c extensions from "/Users/ivano/invokeai/.venv/lib/python3.10/site-packages/patchmatch".
patchmatch.patch_match: WARNING - patchmatch failed to load or compile.
patchmatch.patch_match: WARNING - Refer to https://github.com/invoke-ai/InvokeAI/blob/main/docs/installation/INSTALL_PATCHMATCH.md for installation instructions.
Patchmatch not loaded (nonfatal)

Initializing, be patient...

Initialization file /Users/ivano/invokeai/invokeai.init found. Loading...
InvokeAI runtime directory is "/Users/ivano/invokeai"
GFPGAN Initialized
CodeFormer Initialized
ESRGAN Initialized
Using device_type mps
Initializing safety checker
Current VRAM usage:  0.00G
Scanning Model: stable-diffusion-1.5
Model Scanned. OK!!
Loading stable-diffusion-1.5 from /Users/ivano/invokeai/models/ldm/stable-diffusion-v1/v1-5-pruned-emaonly.ckpt
| LatentDiffusion: Running in eps-prediction mode
| DiffusionWrapper has 859.52 M params.
| Making attention of type 'vanilla' with 512 in_channels
| Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
| Making attention of type 'vanilla' with 512 in_channels
| Using more accurate float32 precision
| Loading VAE weights from: /Users/ivano/invokeai/models/ldm/stable-diffusion-v1/vae-ft-mse-840000-ema-pruned.ckpt
Model loaded in 5.49s
Current embedding manager terms: *
Setting Sampler to k_lms

--web was specified, starting web server...

Initialization file /Users/ivano/invokeai/invokeai.init found. Loading...
Started Invoke AI Web Server!
Default host address now <IP_ADDRESS> (localhost). Use --host <IP_ADDRESS> to bind any address.
Point your browser at http://<IP_ADDRESS>:9090
System config requested
./invoke.sh: line 24: 10899 Segmentation fault: 11  .venv/bin/python .venv/bin/invoke.py --web $*

Additional context
Mac Studio M1 Ultra
Memory|: 128GB
macOs:  Ventura 13.0.1
Python 3.10.8
pip        22.3.1
protobuf   4.21.11
setuptools 65.4.1
wheel      0.37.1
PyTorch 1.12.1
Contact Details
No response

@i3oc9i  I have the same problem!!

I have repeated the test with 2.2.4 official tag, and the issue is confirmed.

@Vargol can you see if you get the same issue on your Mac, please ?

same as #1888 ?

IMHO No because if you look in the log patch match is not installed...

My observation is that installing with conda or with virtualenv do not come to the same result. Indeed there are different dependencies versions.
When I install manually using the conda way, all work as expected.

I've tried to do the same (installer 2.2.4) and had the same issue:
./invoke.sh: line 24: 22103 Segmentation fault: 11  .venv/bin/python .venv/bin/invoke.py --web $*
And I can confirm that a manual installation works flawlessly.

Thank you so much for the bug reports. It does sound like this can be solved by using the conda dependencies for the installer dependencies. Could one of those of you who have the manual install working please do the following:

Activate your environment (indicate whether it is a virtual environment or Conda)
Run pip list and save it to file 'dependencies-working.txt'
Now use the invoke.sh command to enter the "developer's console" (which activates the 2.2.4 venv)
Run 'pip list' again and save it to file 'dependencies-broken.txt'
Upload both files to this thread. I will then propose some fixes to try until we figure out what is causing the crash.

Now I'm busy at work, I will do this evening if person was able to do before

git clone from main and  pip install -r   requirements-mac-mps-cpu.txt  worked fine on MacOS 13.0.1 / Python 3.10.8
Here's my working list.
dependencies-working.txt

@varlog can you also test the offcial 2.2.4 installer ?

git clone from main and pip install -r requirements-mac-mps-cpu.txt worked fine on MacOS 13.0.1 / Python 3.10.8
Here's my working list. dependencies-working.txt
@Vargol
This is surprising to me, because the installer script does exactly the same thing that you did. I know this is extra work for you, but could you try the 2.2.4 installer, let it run to completion (you can skip the models downloading part), and then activate the .venv located in the invokeai runtime directory and do a pip list there as well? If the web GUI is crashing with one set of requirements and not with the other, we'll be close to tracking down the problem.

/opt/local/bin/python3.10: No module named pip```

I would prefer it id the script only updated pip in the venv anyway.
I've moved the pip update after the activation and setting of $PYTHON

Now I get errors due to  spaces in the path.

```*** Confguring InvokeAI ***
/Volumes/Sabrent Media/Documents/Source/Python/iai224/invokeai ~/Downloads/InvokeAI-Installer
./install.sh: ./.venv/bin/configure_invokeai.py: /Volumes/Sabrent: bad interpreter: No such file or directory```

Okay guess I need to use up more of my 256Gb internal drive....

``` ./invoke.sh
Do you want to generate images using the
1. command-line
2. browser-based UI
3. open the developer console
Please enter 1, 2, or 3: 2

Starting the InvokeAI browser-based UI..
>> patchmatch.patch_match: INFO - Compiling and loading c extensions from "/Users/xxx/iai224/invokeai/.venv/lib/python3.10/site-packages/patchmatch".
>> patchmatch.patch_match: WARNING - patchmatch failed to load or compile.
>> patchmatch.patch_match: WARNING - Refer to https://github.com/invoke-ai/InvokeAI/blob/main/docs/installation/INSTALL_PATCHMATCH.md for installation instructions.
>> Patchmatch not loaded (nonfatal)
* Initializing, be patient...
>> Initialization file /Users/xxx/iai224/invokeai/invokeai.init found. Loading...
>> InvokeAI runtime directory is "/Users/xxx/iai224/invokeai"
>> GFPGAN Initialized
>> CodeFormer Initialized
>> ESRGAN Initialized
>> Using device_type mps
>> Current VRAM usage:  0.00G
>> Scanning Model: stable-diffusion-1.5
>> Model Scanned. OK!!
>> Loading stable-diffusion-1.5 from /Users/xxx/iai224/invokeai/models/ldm/stable-diffusion-v1/v1-5-pruned-emaonly.ckpt
>> Calculating sha256 hash of weights file
>> sha256 = cc6cb27103417325ff94f52b7a5d2dde45a7515b25c255d8e396c90014281516 (2.50s)
   | LatentDiffusion: Running in eps-prediction mode
   | DiffusionWrapper has 859.52 M params.
   | Making attention of type 'vanilla' with 512 in_channels
   | Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
   | Making attention of type 'vanilla' with 512 in_channels
   | Using more accurate float32 precision
   | Loading VAE weights from: /Users/xxx/iai224/invokeai/models/ldm/stable-diffusion-v1/vae-ft-mse-840000-ema-pruned.ckpt
>> Model loaded in 70.48s
>> Current embedding manager terms: *
>> Setting Sampler to k_lms

* --web was specified, starting web server...
>> Initialization file /Users/xxx/iai224/invokeai/invokeai.init found. Loading...
>> Started Invoke AI Web Server!
>> Default host address now <IP_ADDRESS> (localhost). Use --host <IP_ADDRESS> to bind any address.
>> Point your browser at http://<IP_ADDRESS>:9090
>> System config requested
>> Image generation requested: {'prompt': 'a man waving over his shoulder', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed': 643416995, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '...', 'seamless': False, 'hires_fix': False, 'variation_amount': 0}
ESRGAN parameters: False
Facetool parameters: False
{'prompt': 'a man waving over his shoulder', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed': 643416995, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '', 'seamless': False, 'hires_fix': False, 'variation_amount': 0}
/Users/xxx/iai224/invokeai/.venv/lib/python3.10/site-packages/ldm/modules/embedding_manager.py:166: UserWarning: The operator 'aten::nonzero' is not currently supported on the MPS backend and will fall back to run on the CPU. This may have performance implications. (Triggered internally at  /Users/runner/work/pytorch/pytorch/pytorch/aten/src/ATen/mps/MPSFallback.mm:11.)
  placeholder_rows, placeholder_cols = torch.where(
Generating:   0%|                                                                                | 0/1 [00:00<?, ?it/s]>> Ksampler using model noise schedule (steps >= 30)
>> Sampling with k_lms starting at step 0 of 50 (50 new sampling steps)
100%|█████████████████████████████████████| 50/50 [03:20<00:00,  4.02s/it]
{'prompt': 'a man waving over his shoulder', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed': 643416995, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '', 'seamless': False, 'hires_fix': False, 'variation_amount': 0, 'init_img': ''}
>> Image generated: "/Users/xxx/iai224/invokeai/outputs/000001.1c789f65.643416995.png"
Generating: 100%|██████████████████████████| 1/1 [03:28<00:00, 208.79s/it]
>> Usage stats:
>>   1 image(s) generated in 209.23s```

requirements_still_works.txt
Forgot to attach this.

@Vargol, to summarize, after fixing the unrelated problems of whitespace in path names and pip not being installed, you were unable to reproduce the segfault issue when starting the web gui?
I will fix the pathname and pip issues in the installer. Can you explain to me how you installed the pip module without using pip?

venv installs pip in the virtual environment somehow, all I did was move the
$PYTHON -mpip install --upgrade pip
line so its was  after the activation
$PYTHON -mvenv $ROOTDIR/.venv
_err_exit $? "Python failed to create virtual environment $ROOTDIR/.venv. Please see $TROUBLESHOOTING for help."

#--------------------------------------------------------------------------------
echo
echo "** Activating Virtual Environment for InvokeAI **"

source $ROOTDIR/.venv/bin/activate
_err_exit $? "Failed to activate virtual evironment $ROOTDIR/.venv. Please see $TROUBLESHOOTING for help."

PYTHON=$ROOTDIR/.venv/bin/python
$PYTHON -mpip install --upgrade pip

Ok, easy fix then.

@Vargol so you were unable to reproduce the segfault after running the installer script?

Yep, thats right the installer worked fine here.
So, only difference that should occur, assuming pip fetches the same versions is that I'm using the python installed by macports.
Don't know if that is the incase for folk getting the failures.

.venv/bin/python -mpip list > depends_2.2.4_faulty.txt
depends_2.2.4_faulty.txt

When I apply the patch suggested by @varlog I still get the segmentation fault when the browser is started ...
.venv/bin/python -mpip list > depends_2.2.4_patched_faulty.txt
depends_2.2.4_patched_faulty.txt
differences between the patched installer and original one are minimals.
 diff depends_2.2.4_*
88c88
< picklescan                  0.0.5
---
> picklescan                  0.0.6
90c90
< pip                         22.2.2
---
> pip                         22.3.1
135c135
< tb-nightly                  2.12.0a20221210
---
> tb-nightly                  2.12.0a20221212

The patch was to fix the installer, my python doesn't have  have pip installed, but was worth trying as InvokeAI works without issues for me.
Try activating the venv and then running
.venv/bin/python -X faulthandler  .venv/bin/invoke.py --web
or
.venv/bin/python -X faulthandler  .venv/bin/invoke.py --web --root <your_root_dir>
see if that prints out any interesting information.

That's too bad. We're going to have to look at python itself. Could you
compare the output of python -V between the non-working 2.2.4 installer
.venv and the working conda-based install?
Thanks
On Mon, Dec 12, 2022 at 1:45 PM Ivano Coltellacci @.***>
wrote:

When I apply the patch suggested by @VarLog https://github.com/VarLog I
still get the segmentation fault when the browser is started ...
.venv/bin/python -mpip list > depends_2.2.4_patched_faulty.txt
depends_2.2.4_patched_faulty.txt
https://github.com/invoke-ai/InvokeAI/files/10211094/depends_2.2.4_patched_faulty.txt
differences between the patched installer and original one are minimals.
diff depends_2.2.4_*
88c88
< picklescan                  0.0.5

picklescan                  0.0.6
90c90
< pip                         22.2.2

pip                         22.3.1
135c135
< tb-nightly                  2.12.0a20221210

tb-nightly                  2.12.0a20221212

—
Reply to this email directly, view it on GitHub
https://github.com/invoke-ai/InvokeAI/issues/1941#issuecomment-1347064082,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA3EVNLMBZNN54F5S7FVLLWM5XE5ANCNFSM6AAAAAAS3IP4XQ
.
You are receiving this because you were assigned.Message ID:
@.***>

--
Lincoln Stein
Head, Adaptive Oncology, OICR
Senior Principal Investigator, OICR
Professor, Department of Molecular Genetics, University of Toronto
Tel:<PHONE_NUMBER>
Cell:<PHONE_NUMBER>
@.***
E**xecutive Assistant
Michelle Xin
Tel:<PHONE_NUMBER>
@.*** @.**>
Ontario Institute for Cancer Research
MaRS Centre, 661 University Avenue, Suite 510, Toronto, Ontario, Canada M5G
0A3
@OICR_news
https://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Foicr_news&data=04|01|Michelle.Xin%40oicr.on.ca|9fa8636ff38b4a60ff5a08d926dd2113|9df949f8a6eb419d9caa1f8c83db674f|0|0|637583553462287559|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PS9KzggzFoecbbt%2BZQyhkWkQo9D0hHiiujsbP7Idv4s%3D&reserved=0
| www.oicr.on.ca
Collaborate. Translate. Change lives.
This message and any attachments may contain confidential and/or privileged
information for the sole use of the intended recipient. Any review or
distribution by anyone other than the person for whom it was originally
intended is strictly prohibited. If you have received this message in
error, please contact the sender and delete all copies. Opinions,
conclusions or other information contained in this message may not be that
of the organization.

I have installed Manually with the pip method and it works
git clone https://github.com/invoke-ai/InvokeAI.git ./invokeai_pip
cd invokeai_pip

python3 -mvenv .venv
source .venv/bin/activate
ln -sf ./environments-and-requirements/requirements-mac-mps-cpu.txt requirements.txt
pip install --prefer-binary -r requirements.txt

export PYTORCH_ENABLE_MPS_FALLBACK=1
python scripts/invoke.py --web

@lstein here is the pip list on the manual install using Conda that work
depends_conda.txt

@i3oc9i Could you give this new version of the installer a try? It inserts --prefer-binary into the pip call, and also implements the spaces-in-folder-names and no-pip-installed issues that @Vargol identified.
Thanks!
InvokeAI-installer-2.2.4-mac.zip

@i3oc9i Could you give this new version of the installer a try? It inserts --prefer-binary into the pip call, and also fixes the spaces-in-folder-names and no-pip-installed issues that @Vargol identified.
Thanks! InvokeAI-installer-2.2.4-mac.zip

I still get seg fault errors after installing this - sorry :-(
I allowed a 'resume an interrupted install?' and skipped model install, thereby I assume only over-writing with new changes..

@lstein I have just tried the new InvokeAI-installer-2.2.4-mac.zip and fails
depends_new2.2.4_faulty.txt

@i3oc9i Thanks for this. The other issue worth exploring is whether the python on your system is the same as the python that the installer puts in your .venv. Could you try these two things?

In the environment in which invokeai is working, give these four commands:

which python
which pip
python -V
pip -V

In the environment in which invokeai is failing, give the same four commands.

Thanks!

@i3oc9i Could you give this new version of the installer a try? It inserts --prefer-binary into the pip call, and also fixes the spaces-in-folder-names and no-pip-installed issues that @Vargol identified.
Thanks! InvokeAI-installer-2.2.4-mac.zip

I allowed a 'resume an interrupted install?' and skipped model install, thereby I assume only over-writing with new changes.. I still get seg fault errors after installing this - sorry :-(
now trying 'clean' install with InvokeAI-installer from above..

Well, at least we have consistent failure reports. Thanks for your patience while I try to understand what's happening.

Conda environment
> which python
/Users/ivano/.miniconda/envs/invokeai/bin/python

> which pip
/Users/ivano/.miniconda/envs/invokeai/bin/pip

> python -V
Python 3.10.8

> pip -V
pip 22.3.1 from /Users/ivano/.miniconda/envs/invokeai/lib/python3.10/site-packages/pip (python 3.10)

Failing environment (last 2.2.4 installer)
> which python
/Users/ivano/invokeai/.venv/bin/python

> which pip
/Users/ivano/invokeai/.venv/bin/pip

> python -V
Python 3.10.8

> pip -V
pip 22.3.1 from /Users/ivano/invokeai/.venv/lib/python3.10/site-packages/pip (python 3.10)

@psychedelicious @blessedcoolant
This is a report of a segfault that occurs on MacOS only when the following conditions are met:

the --web option is passed to invoke.py
the 2.2.4 installer is used to install the requirements and source code

When the exact same requirements are installed using pip manually, the crash doesn't occur. The CLI works. Does any of this ring a bell for you?

Have not seen this before, sorry

That's not it, then. I thought of one last difference that might be relevant. When you install manually, the pip install uses -e because we assume that the user wants to install in editable/developer mode. Could you see if the bug manifests itself when you do the following from within the working conda environment:
pip install https://github.com/invoke-ai/InvokeAI/archive/refs/tags/v2.2.4.zip

This should do a package install, and manifest the bug the next time you launch with the --web argument.

I'm not sure to understand what this does into a Conda environment.
Anyway I created a new working Conda environment following the manual instructions from commit 1a1625406c57c2edb125bcecdcecf0f6dd904dea
then I executed the command line

pip install https://github.com/invoke-ai/InvokeAI/archive/refs/tags/v2.2.4.zip

here is the log
Log at 2022-12-13 1-27-33 AM.txt
git status does not report any change
and python scripts/invoke.py --web does not fail

@stein, @psychedelicious may be I have a tip.
In a falling install (done with the 2.2.4 installer) I started the browser in private mode.
In this case the server does not crash immediately, it generates a first image, and does a segmentation fault when a second image is generated.
Do you want to generate images using the
1. command-line
2. browser-based UI
3. open the developer console
Please enter 1, 2, or 3: 2

Starting the InvokeAI browser-based UI..
>> patchmatch.patch_match: INFO - Compiling and loading c extensions from "/Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1/.venv/lib/python3.10/site-packages/patchmatch".
>> patchmatch.patch_match: WARNING - patchmatch failed to load or compile.
>> patchmatch.patch_match: WARNING - Refer to https://github.com/invoke-ai/InvokeAI/blob/main/docs/installation/INSTALL_PATCHMATCH.md for installation instructions.
>> Patchmatch not loaded (nonfatal)
* Initializing, be patient...
>> Initialization file /Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1/invokeai.init found. Loading...
>> InvokeAI runtime directory is "/Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1"
>> GFPGAN Initialized
>> CodeFormer Initialized
>> ESRGAN Initialized
>> Using device_type mps
>> Initializing safety checker
>> Current VRAM usage:  0.00G
>> Scanning Model: stable-diffusion-1.5
>> Model Scanned. OK!!
>> Loading stable-diffusion-1.5 from /Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1/models/ldm/stable-diffusion-v1/v1-5-pruned-emaonly.ckpt
   | LatentDiffusion: Running in eps-prediction mode
   | DiffusionWrapper has 859.52 M params.
   | Making attention of type 'vanilla' with 512 in_channels
   | Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
   | Making attention of type 'vanilla' with 512 in_channels
   | Using more accurate float32 precision
   | Loading VAE weights from: /Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1/models/ldm/stable-diffusion-v1/vae-ft-mse-840000-ema-pruned.ckpt
>> Model loaded in 5.65s
>> Current embedding manager terms: *
>> Setting Sampler to k_lms

* --web was specified, starting web server...
>> Initialization file /Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1/invokeai.init found. Loading...
>> Started Invoke AI Web Server!
>> Default host address now <IP_ADDRESS> (localhost). Use --host <IP_ADDRESS> to bind any address.
>> Point your browser at http://<IP_ADDRESS>:9090
>> System config requested
>> Image generation requested: {'prompt': 'dog', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed':<PHONE_NUMBER>, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '...', 'seamless': False, 'hires_fix': False, 'variation_amount': 0}
ESRGAN parameters: False
Facetool parameters: False
{'prompt': 'dog', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed':<PHONE_NUMBER>, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '', 'seamless': False, 'hires_fix': False, 'variation_amount': 0}
/Users/ivano/Junk/TO_BE_DELETED/invokeai_fault_1/.venv/lib/python3.10/site-packages/ldm/modules/embedding_manager.py:166: UserWarning: The operator 'aten::nonzero' is not currently supported on the MPS backend and will fall back to run on the CPU. This may have performance implications. (Triggered internally at  /Users/runner/work/pytorch/pytorch/pytorch/aten/src/ATen/mps/MPSFallback.mm:11.)
  placeholder_rows, placeholder_cols = torch.where(
Generating:   0%|                                                                                | 0/1 [00:00<?, ?it/s]>> Ksampler using model noise schedule (steps >= 30)
>> Sampling with k_lms starting at step 0 of 50 (50 new sampling steps)
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 50/50 [00:20<00:00,  2.39it/s]
{'prompt': 'dog', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed':<PHONE_NUMBER>, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '', 'seamless': False, 'hires_fix': False, 'variation_amount': 0, 'init_img': ''}
>> Image generated: "/Users/ivano/invokeai/outputs/000001.ea5d7e27.1530923362.png"
Generating: 100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:21<00:00, 21.72s/it]
>> Usage stats:
>>   1 image(s) generated in 22.07s
>> Image generation requested: {'prompt': 'dog', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed': 193056849, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '...', 'seamless': False, 'hires_fix': False, 'variation_amount': 0}
ESRGAN parameters: False
Facetool parameters: False
{'prompt': 'dog', 'iterations': 1, 'steps': 50, 'cfg_scale': 7.5, 'threshold': 0, 'perlin': 0, 'height': 512, 'width': 512, 'sampler_name': 'k_lms', 'seed': 193056849, 'progress_images': False, 'progress_latents': True, 'save_intermediates': 5, 'generation_mode': 'txt2img', 'init_mask': '', 'seamless': False, 'hires_fix': False, 'variation_amount': 0}
Generating:   0%|                                                                                | 0/1 [00:00<?, ?it/s]>> Ksampler using model noise schedule (steps >= 30)
>> Sampling with k_lms starting at step 0 of 50 (50 new sampling steps)
                                                                                ./invoke.sh: line 24: 25857 Segmentation fault: 11  .venv/bin/python .venv/bin/invoke.py --web $*
/opt/homebrew/Cellar/python@3.10/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

I have installed Manually with the pip method and it works
git clone https://github.com/invoke-ai/InvokeAI.git ./invokeai_pip
cd invokeai_pip

python3 -mvenv .venv
source .venv/bin/activate
ln -sf ./environments-and-requirements/requirements-mac-mps-cpu.txt requirements.txt
pip install --prefer-binary -r requirements.txt

export PYTORCH_ENABLE_MPS_FALLBACK=1
python scripts/invoke.py --web

depends_pip.txt
EDIT: the difference that I remak here is the --prefer-binary option

not sure if this helps but..
so, using @i3oc9i's lead for manual install using venv and pip:
git clone https://github.com/invoke-ai/InvokeAI.git ./invokeai
cd invokeai

python3 -m venv py-venv4
source py-venv4/bin/activate

ln -sf ./environments-and-requirements/requirements-mac-mps-cpu.txt requirements.txt

pip install --upgrade pip
pip install --prefer-binary -r requirements.txt

export PYTORCH_ENABLE_MPS_FALLBACK=1
python scripts/invoke.py

which obviously senses I have no models so automatically invokes configure_invokeai.py and we download everything afresh
and finally
python scripts/invoke.py
couple of quick single word prompt test in cli, then
python scripts/invoke.py --web
working, tested with 2 x 2 images runs, 2 x 3 images runs with gfpgan face restoration, 1 x 3 images run with codeformer face restorations

@Cybergate9 the issue is not with the manual instal, but when you install using the InvokeAI-installer-2.2.4-mac.zip new installer

Thanks for the testing and the working recipe. I'd still like to get to the bottom of why the automatic install is causing this crash. I've been discussing this with @blessedcoolant , and we think the most likely issue is a problem with the Mac python build itself.
For @i3oc9i, @Cybergate9 and others who are experiencing the segfault after installing with the automated installer, could you confirm whether you got python from python.org or www.anaconda.com? If everyone who has the segfault problem consistently got their python from one or the other, then I'd like to ask you to uninstall the existing python from your system, download a fresh Python 3.10 build from whichever site you did not use, then run through the install and see if the problem is fixed.

I'm able to reliably reproduce the segfault in a brand-new python3.10 environment created with homebrew. have not tried with system or conda python yet.

Unable to reproduce this with the system python (3.9.6) - continuously generating images with no segfaults

@i3oc9i @Cybergate9  Could I ask you to please try the following:

download and unpack the latest 2.2.4 automated installer, just to be sure it's an unmodified version as you've been doing some troubleshooting
edit the install.sh by deleting a few lines as per this diff: https://github.com/invoke-ai/InvokeAI/pull/1969/files

Once you do, please do a full reinstall installer, using your usual homebrew-managed Python. I'm hoping :crossed_fingers: this fixes the issue, in which case we will release an updated installer.
Many thanks for helping us squash this!

@ebr, @lstein the fix solve the issue, good job, thank you very much
I have generated several images, and also tested the others features , all work flawlessly.

@i3oc9i @Cybergate9 Could I ask you to please try the following:
* download and unpack the latest 2.2.4 automated installer, just to be sure it's an unmodified version as you've been doing some troubleshooting
* edit the install.sh by deleting a few lines as per this diff: https://github.com/invoke-ai/InvokeAI/pull/1969/files
Once you do, please do a full reinstall installer, using your usual homebrew-managed Python. I'm hoping 🤞 this fixes the issue, in which case we will release an updated installer.
Many thanks for helping us squash this!
Dl'd from:
https://github.com/invoke-ai/InvokeAI/releases/tag/v2.2.4
i.e. InvokeAI-installer-2.2.4-p1-mac.zip

removed lines 113-118 from install.sh as per https://github.com/invoke-ai/InvokeAI/pull/1969/files
ran install.sh
accepted all prompt defaults incl. DL'ing weights etc.
Simple run tests
1 x 2 images, 50 steps
1 x 5 images, 30 steps
ctrl-c manual exit in cli
restart
1 x 5 images, 30 steps with face restoration, including purposefully triggering NSFW filter
1 x 5 images, 30 steps with face restoration
no errors to report :-)

@i3oc9i @Cybergate9 Could I ask you to please try the following:

download and unpack the latest 2.2.4 automated installer, just to be sure it's an unmodified version as you've been doing some troubleshooting
edit the install.sh by deleting a few lines as per this diff: https://github.com/invoke-ai/InvokeAI/pull/1969/files

Once you do, please do a full reinstall installer, using your usual homebrew-managed Python. I'm hoping 🤞 this fixes the issue, in which case we will release an updated installer.
Many thanks for helping us squash this!

This worked for me so far!  Thank you!


What happens with conflicting attributes?

The water_polygons layer contains a number of features with definitions that can overlap because they're coming from different OSM keys.
As an example, something with landuse=river natural=water would meet the criteria for kind of river and of reservoir.
The osm2pgsql-themepark implementation is
if t.natural == 'glacier' then
    kind = 'glacier'
elseif t.natural == 'water' then
    if t.water == 'river' then
        kind = 'river'
    else
        kind = 'water'
    end
elseif t.waterway == 'riverbank' then
    kind = 'river'
elseif t.waterway == 'dock' or t.waterway == 'canal' then
    kind = t.waterway
elseif t.landuse == 'basin' or t.landuse == 'reservoir' then
    kind = t.landuse
end

This is the logical way to read the spec as it goes down the table and takes the first condition that is met, but it's not ideal since landuse=reservoir natural=water would have a kind of the generic water.

Another example is the sites layer where there can be objects tagged with matching military and amenity tags. For this one it might make sense to have the object appear multiple times, or it might make sense to define a priority order.


Added FC tip Sep 2020 launch

In my previous PR, I placed the FC tip (ETR based) annoucement in the wrong section. We launched it in Sep 2020 actually.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Bump identity-inbound-auth-oauth version

###Purpose
$Subject
###Related PR

https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2006

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/4100589871

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/4100589871
Status: success


Documentation for v1 top-level API objects seems to be missing

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
The V1 top-level API objects URL now returns a 404: https://kubernetes.io/docs/api-reference/v1/definitions/ But, the equivalent page for extensions/v1beta1 still exists: https://kubernetes.io/docs/api-reference/extensions/v1beta1/definitions/
Proposed Solution:
This seems like a bug, but I'm not sure where. At this point I'm just wondering if this was on purpose. If it wasn't, then the solution probably involves (1) figuring out what happened, and (2) reversing that.
Page to Update:
https://kubernetes.io/docs/api-reference/extensions/v1beta1/definitions/

Andrew, can you take a look at this?

The root cause is that we've changed the structure of V1 reference docs. So, for example, /docs/api-reference/v1/definitions/#_v1_node should now be /docs/api-reference/v1.6/#node-v1-core. Consequently, there's no easy way to write the redirect. I'm still researching what the most efficient solution might be. Stand by.

I have made a change to the redirect.js script to take care of this issue in PR #3160.

These links should work now via a redirect.

I think this one is still broken? https://kubernetes.io/docs/api-reference/apps/v1beta1/definitions/

@hausdorff Thanks for catching that. I'll work on a patch to address it.

@chenopis As a Kubernetes noob, I'm not sure that I'm the right person to sign off, but based on what I understand, this looks good to me. :)

@hausdorff Just wanted to make sure the patch addressed the issue you were seeing. Thanks for submitting the issue and keeping on top of it! =)

@chenopis I think it is in acceptable shape for my usage. :) The v1beta1 extensions page[1] still seems to point to the old-style version of that page, which is fine for me, but may or may not be what you want -- I'm not sure.
Anyway, thanks for the help!
[1] https://kubernetes.io/docs/api-reference/extensions/v1beta1/definitions/

@hausdorff Yeah, we're still working on cleaning that up and other parts of the Reference section. Hopefully, they should be done w/in the next week or so.


kqueue-related types and values missing on Drragonfly

Trying to compile a project that depends on Mio results in some errors. This was on DragonFlyBSD 5.8, and Rust 1.47. I have a project that uses Tokio 1, which depends on Mio 0.7.7. The errors are:
error[E0432]: unresolved imports `super::Filter`, `super::Flags`
   --> /home/chuck/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.7.7/src/sys/unix/selector/kqueue.rs:366:17
    |
366 |     use super::{Filter, Flags};
    |                 ^^^^^^  ^^^^^ no `Flags` in `sys::unix::selector::kqueue`
    |                 |
    |                 no `Filter` in `sys::unix::selector::kqueue`

error[E0412]: cannot find type `Filter` in this scope
   --> /home/chuck/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.7.7/src/sys/unix/selector/kqueue.rs:58:32
    |
58  |             filter: $filter as Filter,
    |                                ^^^^^^ not found in this scope
...
138 |             let kevent = kevent!(fd, libc::EVFILT_WRITE, flags, token.0);
    |                          ----------------------------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing one of these items
    |
1   | use core::iter::Filter;
    |
1   | use crate::interest::ops::range::fmt::str::Filter;
    |
1   | use std::iter::Filter;
    |

error[E0412]: cannot find type `Filter` in this scope
   --> /home/chuck/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.7.7/src/sys/unix/selector/kqueue.rs:58:32
    |
58  |             filter: $filter as Filter,
    |                                ^^^^^^ not found in this scope
...
144 |             let kevent = kevent!(fd, libc::EVFILT_READ, flags, token.0);
    |                          ---------------------------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing one of these items
    |
1   | use core::iter::Filter;
    |
1   | use crate::interest::ops::range::fmt::str::Filter;
    |
1   | use std::iter::Filter;
    |

And:
error[E0425]: cannot find value `NOTE_BACKGROUND` in crate `libc`
   --> /home/chuck/.cargo/registry/src/github.com-1ecc6299db9ec823/mio-0.7.7/src/sys/unix/selector/kqueue.rs:655:19
    |
655 |             libc::NOTE_BACKGROUND,
    |                   ^^^^^^^^^^^^^^^ not found in `libc`

I think these are straightforward to solve:

target_os('dragonfly') is not defined for Filter and Flag, but these are the same  types as on FreeBSD and OpenBSD.
NOTE_BACKGROUND is actually specific to Apple (iOS and macOS, introduced into XNU in the "Mavericks" timeframe, late 2013). It's not a feature of DragonFly.

I have a PR for these which I'll attach. But, I'm having trouble testing it out locally. I think to expose the problem you have to compile something that depends on Mio, rather than just compiling it directly (which seems to always succeed). But when I tried to compile Tokio, specifying my locally modified mio, it complained like so:
the package `tokio` depends on `mio`, with features: `udp, tcp, os-util, uds` but `mio` does not have these features.

I tried to specify these features of mio in Tokio's `Cargo.toml, but got the same errors.

Fixed in #1458 and #1457.


Add GH actions workflow

Added the Dart template but it needs:

Rust
linters (code and licence)

Fixed in https://github.com/Foundation-Devices/tor/pull/27


/opt/traccar/bin/traccar: 1: eval: /opt/traccar/bin/./wrapper: not found

I m using ubuntu 14.04 32 bit but i have an error when start traccar
/opt/traccar/bin/traccar: 1: eval: /opt/traccar/bin/./wrapper: not found

root@ubuntu-512mb-sgp1-01:~# /opt/traccar/bin/traccar start
Starting traccar...
/opt/traccar/bin/traccar: 1: eval: /opt/traccar/bin/./wrapper: not found
Waiting for traccar..................
WARNING: traccar may have failed to start.

how can resolve it ?

I'm guessing you've downloaded wrong version of Traccar, right?

yes i v wrong download.I forgot to check the version of ubuntu.


Cannot open binary file in text editor

Testing #122030

open src/vs/platform/files/test/electron-browser/fixtures/service/binary.txt
click on "Do you want to open it anyway"
select text editor

=> 🐛 nothing happens
(I had hex editor installed too)

Actually this seems like a general issue, I cannot open a GH issues notebook with text editor either:

https://github.com/microsoft/vscode/commit/f4ab7e822f98611f54f3972b451836750e74f65e

\closedWith f4ab7e8

According to https://github.com/microsoft/vscode/issues/122361, this fix is already in Insiders.
But, when I click on the "Do you want to open it anyway" link, it does nothing, until I click on another tab and click back. This is with the binary.txt file on Windows, and I don't have any other editor installed.

I can immediately open a GH issues notebook with the text editor, though.

I can open the text editor, but clicking on Hex editor does nothing:

Wow, this issue is really stubborn I guess.


SVG icons have different size than font icons given the same size

Bug Report
SVG icons have different size than font icons given the same size
Steps

Expected Result
All icons should render the same size given the same size
Actual Result
Font icons render bigger than SVG icons
Version
0.10.0

Also noticed that SVG icons render with a different color and don't have the same hover behavior as Font Icons when in Menu. For example:

Sizing
There is some work in progress right now, #384, to address this.  The issue is that the current SVG view boxes include padding which they should not.  Once resolved, the SVGs will appear the same size as the font icons when used side-by-side.
Color

Also noticed that SVG icons render with a different color and don't have the same hover behavior as Font Icons when in Menu. For example:

This is due to "Home" item being the "active" item.  Clicking through the items helps show this:

🐞 BUG There does appear to be a bug in the Teams theme with proper application of the color to the fill property for the SVG icons.  There is some icon work in progress right now, #384, to address this.  The goal is for SVG icons and font icons to be able to be used side-by-side without having to be concerned with it as a feature developer.

@codepretty ^

with recent adjustments provided to icons is not an issue anymore 👍


Are there any detailed instructions to get those trained policy network from scratch?

Hi,I wanna train policy network by myself using your data named 'dummy_raw_template_library', but when I tried to use 'preprocess_expansion' command, just three npz files were produced, and raised some error messages 'raise MoleculeException(f"Unable to sanitize molecule ({self.smiles})")
aizynthfinder.chem.MoleculeException: Unable to sanitize molecule (c1ccccc1(C)(C))'.
 Thank u very much.

Hello.
Thank for your feedback.
I would be the first to admit that the information how to train your own policy network is a little bit thin. There is the documentation here: https://molecularai.github.io/aizynthfinder/training.html . Which I am sure you have already checked.
The 'dummy_raw_template_library' file was created for unit test purposes and does not really work for creating an expansion network. I could not reproduce your exception, and if I used the following config.yml file I could run the preprocess_expansion script myself
output_path: "."
file_prefix: "dummy"
split_size:
        training: 0.6
        testing: 0.2
        validation: 0.2

If you run into the sanitation problems with your own set of templates, you always add the following option to your config file.
remove_unsanitizable_products: False

Hope this help.
And please feel welcome to suggest something concreate that we can implement and that would improve the ease of creating your own expansion policy.

Hello.
Thank for your feedback.
I would be the first to admit that the information how to train your own policy network is a little bit thin. There is the documentation here: https://molecularai.github.io/aizynthfinder/training.html . Which I am sure you have already checked.
The 'dummy_raw_template_library' file was created for unit test purposes and does not really work for creating an expansion network. I could not reproduce your exception, and if I used the following config.yml file I could run the preprocess_expansion script myself
output_path: "."
file_prefix: "dummy"
split_size:
        training: 0.6
        testing: 0.2
        validation: 0.2

If you run into the sanitation problems with your own set of templates, you always add the following option to your config file.
remove_unsanitizable_products: False

Hope this help.
And please feel welcome to suggest something concreate that we can implement and that would improve the ease of creating your own expansion policy.

Hello.
Thank for your feedback.
I would be the first to admit that the information how to train your own policy network is a little bit thin. There is the documentation here: https://molecularai.github.io/aizynthfinder/training.html . Which I am sure you have already checked.
The 'dummy_raw_template_library' file was created for unit test purposes and does not really work for creating an expansion network. I could not reproduce your exception, and if I used the following config.yml file I could run the preprocess_expansion script myself
output_path: "."
file_prefix: "dummy"
split_size:
        training: 0.6
        testing: 0.2
        validation: 0.2

If you run into the sanitation problems with your own set of templates, you always add the following option to your config file.
remove_unsanitizable_products: False

Hope this help.
And please feel welcome to suggest something concreate that we can implement and that would improve the ease of creating your own expansion policy.

Thank you again for your help. I am wondering if I can train my own policy network based on your trained models through Transfer Learning. Do you have any advice?Thanks.


Update status of track

This issue is part of the migration to v3. You can read full details about the various changes here.
There are several new features in Exercism v3 for tracks to build. To selectively enable these features on the Exercism v3 website, each track must keep track of the status of the following features:

Concept Exercises have been built
A test runner has been implemented
A representer has been implemented
An analyzer has been implemented

The status of these features is specified in the top-level "status" field in the track's config.json, as specified in the spec.
Goal
The "status" field in the config.json file should be updated to indicate the status of the features for this track. The list of features is defined in the spec.
Example
{
  "status": {
    "concept_exercises": true,
    "test_runner": true,
    "representer": false,
    "analyzer": false
  }
}

Tracking
https://github.com/exercism/v3-launch/issues/12

I think this is already set properly.

Thanks @Pablo-No, you're right this is done.
I need to take a pass through the issues and close the things that aren't relevant.


Run update_admin_profile on CI profile in packaging

This PR is intended to fix the root cause of this build failure by selectively targeting the Continuous Integration profile for FLS updates upon deployment into the packaging org.
Pending: test against a mock packaging org.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

Testing successful.


Update solana.tokenlist.json (add Dogelana)

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

I'm so sorry but please edit it to be Ðogelana if possible... and ÐGLN