Docker corrupts output by converting \n to \r\n.

Description
Text files cated from inside docker to host got \r\n for newlines.
Tar gets broken.
Describe the results you received:
$ docker run --rm -it alpine sh -c echo | od -cx
0000000   \r  \n
             0a0d
0000002

$ docker run --rm -it debian:jessie sh -c echo | od -cx
0000000   \r  \n
             0a0d
0000002

$ docker run --rm -it debian:jessie tar -cf- /etc/os-release | tar -tf-
tar: Unrecognized archive format
tar: Error exit delayed from previous errors.

Describe the results you expected:
$ docker run --rm -it alpine sh -c echo | od -cx
0000000   \n
             000a
0000001

$ docker run --rm -it debian:jessie sh -c echo | od -cx
0000000   \n
             000a
0000001

$ docker run --rm -it debian:jessie tar -cf- /etc/os-release | tar -tf-
tar: Removing leading `/' from member names
etc/os-release

Output of docker version:
$ docker version
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 23:26:11 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 23:26:11 2016
 OS/Arch:      linux/amd64

Output of docker info:
$ docker info
Containers: 14
 Running: 0
 Paused: 0
 Stopped: 14
Images: 56
Server Version: 1.12.3
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 106
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.27-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.951 GiB
Name: moby
ID: 5GTA:PXIR:LUFZ:R4W5:KA27:MWLR:3VL4:ZNLF:F7B3:JMHP:VMIY:FM5H
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 20
 Goroutines: 38
 System Time: 2016-12-15T00:07:43.184310177Z
 EventsListeners: 1
No Proxy: *.local, 169.254/16
Registry: https://index.docker.io/v1/
WARNING: No kernel memory limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Docker for Mac
Version 1.12.3 (13776)
Channel: Stable
583d1b8ffe

This is a duplicate of https://github.com/docker/docker/issues/6674. The \r\n line endings are not added by docker, but by the shell /  TTY; see https://github.com/docker/docker/issues/8513#issuecomment-216191236 (and the -onlcr option described here http://pubs.opengroup.org/onlinepubs/009696799/utilities/stty.html);
By default the TTY uses \r\n line endings, and translates \n into \r\n;
$ docker run -t --rm debian sh -c "echo -n '\n'" | od -c
0000000   \r  \n
0000002

disabling "translate newline to carriage return-newline" with stty -onlcr disables this behavior and gives;
$ docker run -t --rm debian sh -c "stty -onlcr && echo -n '\n'" | od -c
0000000   \n
0000001

I'll close this issue because this is not a bug in docker, but a standard behavior of Linux, but feel free to comment after I closed

It should be reflected in the run -t docs because it is not obvious! And quite unexpected, I mean it breaks things far far away from the place docker run -t was used. It could cost couple of hours to find out side-effects.
Piping tar to tar this is quite common with ssh where ssh does not need any special keys!

If you're not running an interactive process, don't use -i, -t;
docker run --rm debian:jessie tar -cf- /etc/os-release | tar -tf-
tar: Removing leading `/' from member names
etc/os-release

Yes, it is clear. I agree.
It is stated in the doc

Specifying -t is forbidden when the client standard output is redirected or piped...


Urgent: White screen for certain polling location searches?

For the searched address, 137 Oleander Rd., Morenci, AZ 85540, the API returns polling location Vc1 Voting Center-1
Morenci Club Morenci Az.
Morenci Plaza
Morenci, AZ 85540
So I'm not sure what's happening here.

This is on the staging server

@lbirdpew @MariaBianchi can you provide the election ID?

EID 5000
Maria Bianchi
Project Manager | Voting Information Project
Democracy Works
<EMAIL_ADDRESS><EMAIL_ADDRESS>(o):<PHONE_NUMBER> ext. 3000 | (c):<PHONE_NUMBER>
On Wed, Nov 2, 2016 at 5:35 PM, Alex Konrad<EMAIL_ADDRESS>wrote:

@lbirdpew https://github.com/lbirdpew @MariaBianchi
https://github.com/MariaBianchi can you provide the election ID?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/votinginfoproject/vip-embeddable-tool/issues/228#issuecomment-258006310,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvBb_09y2Ruqt5c8nVN3Y08MbjkwLQ0ks5q6QIWgaJpZM4Knus4
.

@MariaBianchi This is happening because the Geocoder is actually not able to parse this address:

Two options for addressing this are:

Add additional rules for the tool to massage the address before sending it to be geocoded
Add error conditions to skip geocoding this address if the geocoder is unsuccessful.

@lbirdpew What would you prefer? A white screen with no information returned seems like a particularly bad handling of this.
What would it look like to the user if we skipped geocoding when it failed?

@MariaBianchi The location will be displayed but it's position will be no more accurate than its zip code. I am implementing that in the tool now because we need to be able to pass over these malformed location addresses to continue the functioning of the tool.

Thanks!
Maria Bianchi
Project Manager | Voting Information Project
Democracy Works
<EMAIL_ADDRESS><EMAIL_ADDRESS>(o):<PHONE_NUMBER> ext. 3000 | (c):<PHONE_NUMBER>
On Wed, Nov 2, 2016 at 10:20 PM, Alex Konrad<EMAIL_ADDRESS>wrote:

@MariaBianchi https://github.com/MariaBianchi The location will be
displayed but it's position will be no more accurate than its zip code. I
am implementing that in the tool now because we need to be able to pass
over these malformed location addresses to continue the functioning of the
tool.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/votinginfoproject/vip-embeddable-tool/issues/228#issuecomment-258051655,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvBby0iLPdoG9L3I0PreSxhUcxRvoxKks5q6UUCgaJpZM4Knus4
.

The tool is updated to skip locations that cannot be geocoded.

Thanks everyone.


feat: store member directory profile urls on slack profile 👥

Description ✏
Closes #497
Describe what this PR does.

Returns a list of students who have both a member profile and slack profile
For each student look up Slack profile by email, generate url, and set profile with newly added field
After each update add delay to abide by Slack rate limits

Type of Change 🐞

[x] Feature - A non-breaking change which adds functionality.
[ ] Fix - A non-breaking change which fixes an issue.
[ ] Refactor - A change that neither fixes a bug nor adds a feature.
[ ] Documentation - A change only to in-code or markdown documentation.
[ ] Tests - A change that adds missing unit/integration tests.
[ ] Chore - A change that is likely none of the above.

Checklist ✅

[x] I have done a self-review of my code.
[ ] I have manually tested my code (if applicable).
[ ] I have added/updated any relevant documentation (if applicable).

Question for @ramiAbdou: I wonder if we should move this code into a separate file to be run as a script, since adding the member directory URL to Slack profiles is probably just a one-time thing. There's also various console logs printed as part of these functions that make sense when running a script but probably should be removed otherwise. Thoughts?

Question for @ramiAbdou: I wonder if we should move this code into a separate file to be run as a script, since adding the member directory URL to Slack profiles is probably just a one-time thing. There's also various console logs printed as part of these functions that make sense when running a script but probably should be removed otherwise. Thoughts?

Yeah I moved it to its own file but honestly we don't have a great way of running scripts currently so there's not much precedent set for that. I'm okay with the logs in the script function, but I removed the logs from the function that updates an individual profile (which is now used when a new members joins the Slack workspace)!


Blog post on PSP history context

Ref: https://kubernetes.slack.com/archives/C019LFTGNQ3/p1653483955189929
/assign @mtardy

/sig security

We had a discussion about that in the #release-comms channel on the Kubernetes Slack that can be found here. The tl;dr is that a dedicated article could be interesting and that it could be published around Kubernetes v1.25 release, a few days after or a few weeks after!
Here is a link to an early draft of what it could be https://hackmd.io/@mtardy/S1cQSCJCc/edit.

The blogpost is out: https://kubernetes.io/blog/2022/08/23/podsecuritypolicy-the-historical-context/ 🥳!
/close


Add text page

Please add a text page of the motor sports we work with.

Great job and thank you.


Add support for using image digests instead of tags

Description of the change:
Adds the ability to create operators that use image digests instead of tags for operator images as well as related images.
Motivation for the change:
https://github.com/operator-framework/enhancements/blob/master/enhancements/sha-bundle-digest.md
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[x ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

@ryantking I forced an update to this branch so I could add the Signoff for Ish's initial commit which was causing DCO to fail. And I added the migration for camila.


[Snyk] Security upgrade netlify-cli from 15.9.1 to 17.13.1

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):

package.json
yarn.lock

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Server-side Request Forgery (SSRF) SNYK-JS-AXIOS-7361793
  833

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Server-side Request Forgery (SSRF)

👷 Deploy Preview for resonant-biscochitos-ee6470 processing.

Name
Link

🔨 Latest commit
cec93c52550b96bd489cec473a9c354eabd6cb60

🔍 Latest deploy log
https://app.netlify.com/sites/resonant-biscochitos-ee6470/deploys/66b9a741366a030008324cf2


Should we deprecate .dialProtocol?

Currently .dial and .dialProtocol call out to the same .dial method on libp2p-switch. Switch handles the non-existance of a protocol and dials appropriately. In an effort to simplify the interface, I think we should deprecate .dialProtocol and consolidate into a single, overloaded .dial method that mimics Switch.
.dialProtocol already does this overloading, so you can just supply the peer and a callback.
The major draw back to making this change is that users/libraries will need to replace dialProtocol with dial once it is phased out. This should be as simple as a find/replace since dial would conform to dialProtocol's footprint.
cc: @alanshaw

.dialProtocol is a useful convenience API.  It does introduce some redundancy in the codebase as the methods chain together but removing it makes the API slightly less ergonomic and will force people using it to refactor which may outweigh the benefits of removing the method.  Please reopen if you disagree (strongly).


NaN car velocity

In this very contrived example (basically just a trace from an attempted training run) we observe that the car velocity is sometimes NaN.
I suppose this could be an issue in the python bindings, but it seems more likely a problem with the underlying engine, hence why I'm reporting it here.
Repro:
from rocketsim import Vec3, Angle
from rocketsim.sim import Arena, CarConfig, GameMode, Team, Car, CarControls, Ball

arena = Arena(GameMode.Soccar)
agent_id = arena.add_car(Team.Blue, CarConfig.Octane)

ball = arena.get_ball()

ball.pos = Vec3(0, 0, 5000)
ball.angvel = Vec3(0, 0, 0)
ball.vel = Vec3(0, 0, 0)

arena.ball = ball

agent = arena.get_car(agent_id)

# x = +- 3000
# y = +- 3000
agent.pos = Vec3(2040.60498046875, -2534.492919921875, 17.0)
agent.angles = Angle(-0.0, 0, 0)
agent.angvel = Vec3(0, 0, 0)
agent.boost = 100

control_dicts = [
    { "throttle": 0.0,  "steer": 0.5,  "pitch": 0.5,  "yaw": 0.5, "roll": 1.0, "jump": False, "boost": False, "handbrake": False },
    { "throttle": -1.0, "steer": 1.0,  "pitch": 1.0,  "yaw": 0.0, "roll": 0.0, "jump": False, "boost": False, "handbrake": True },
    { "throttle": 0.0,  "steer": 0.0,  "pitch": 0.0,  "yaw": 0.75, "roll": 1.0, "jump": True, "boost": False, "handbrake": True },
    { "throttle": 0.0,  "steer": 0.0,  "pitch": 0.0,  "yaw": 0.75, "roll": 0.0, "jump": False, "boost": False, "handbrake": False },
    { "throttle": 1.0,  "steer": -0.5, "pitch": -0.5, "yaw": 0.0, "roll": 0.0, "jump": False, "boost": True, "handbrake": False },
    { "throttle": 0.0,  "steer": 0.5,  "pitch": 0.5,  "yaw": -0.5, "roll": 0.0, "jump": False, "boost": False, "handbrake": False },
    { "throttle": -1.0, "steer": 1.0,  "pitch": 1.0,  "yaw": 0.0, "roll": 0.0, "jump": False, "boost": False, "handbrake": True },
    { "throttle": 0.0,  "steer": 0.0,  "pitch": 0.0,  "yaw": 1.0, "roll": -1.0, "jump": True, "boost": False, "handbrake": True }
]

def control(**kwargs):
    controls = CarControls(**kwargs)
    arena.set_car_controls(agent_id, controls)
    arena.step(8)
    car_vel = arena.get_car(agent_id).get_vel()
    print(f"Car vel: {car_vel}")

[ control(**control_dict) for control_dict in control_dicts ]

Output (notice final line has NaN values for x and y:
Car vel: Vec3 { x: -0.07, y: 0.03, z: 137.92 }
Car vel: Vec3 { x: -79.549995, y: -18.42, z: 72.88 }
Car vel: Vec3 { x: -92.6919, y: -13.390303, z: 398.83078 }
Car vel: Vec3 { x: -92.68999, y: -13.389998, z: 355.47 }
Car vel: Vec3 { x: -88.259995, y: -13.59, z: 312.18 }
Car vel: Vec3 { x: -88.259995, y: -13.59, z: 268.82 }
Car vel: Vec3 { x: -92.68999, y: -13.389998, z: 225.48997 }
Car vel: Vec3 { x: NaN, y: NaN, z: 220.06998 }

@NeverCast says

It does not reproduce if I set the pos, vel, boost, ang and angvel of the agent and step the last action
So there is probably some internal state that makes the difference

Angular Velocity is all NaNs in the final state as well.

This is an issue with stalling, when it sees a flip and a stall is performed the dodgeDir vector is normalized but is zero

Stalling works fine for me in testing.
I also tested your exact case with the following code:
for (int j = 0; j < 120; j++) {

	arena.Step(1);

	RS_LOG("Tick [" << j << "]:");
	CarState state = car->GetState();
	if (state.isOnGround) {
		RS_LOG(" > Jumping on ground");
		car->controls.jump = !car->controls.jump;
	} else if (state.isJumping) {
		RS_LOG(" > Holding jump")
		car->controls.jump = 1;
	} else if (!state.hasFlipped && !state.hasDoubleJumped) {
		RS_LOG(" > Flipping...");
		car->controls.jump = !car->controls.jump;
		car->controls.yaw = 1;
		car->controls.roll = -1;
		car->controls.handbrake = 1;
	}
	RS_LOG(" > Pos: " << state.pos);
	RS_LOG(" > Vel: " << state.vel);
	RS_LOG(" > AngVel: " << state.angVel);
}

The output showed no NANs whatsoever.

Related to this, I did find a dodge direction bug that results in backward flips not giving enough force when moving forwards, which I fixed. However, dodge torque was untouched in that change.
Perhaps this is an issue with bindings, or my new changes magically fixed it?

Ok I managed to reproduce it, it seems all of the inputs are required:

Fixed with https://github.com/ZealanL/RocketSim/commit/454713d3ac05f9df9c05eadb3bf681aff0fc0f11, dodgeDir was being normalized unsafely, which produced invalid results when inputted with -0.
Thank you for reporting this! I somehow never encountered this bug in all my testing, weird.


RFE: specify emptyDir sizeLimit in Job Config

As a user, I want to specify the size limit of the emptyDir for a Kubernetes Job, in order to be able to download files that exceed this limit on demand, e.g., test-data.
Technical Details
Limiting the size of emptyDir is a good practice especially considering that multiple jobs can run in parallel, and to avoid filling up a single hosts memory/disk (temporarily).
However, there’s a feature gate in beta already in K8s 1.22 which would allow to use up to half the memory of the Linux host when not specifying a sizeLimit. Therefore we could even consider not having a sizeLimit by default.
See https://kubernetes.io/docs/concepts/storage/volumes/#emptydir

Note: If the SizeMemoryBackedVolumes feature-gate is enabled, you can specify a size for memory backed volumes. If no size is specified, memory backed volumes are sized to 50% of the memory on a Linux host.

Proposed config.yaml change
apiVersion: v2
actions:
  - name: "Print files"
    events:
      - name: "sh.keptn.event.sample.triggered"
    files:
      - my-32-megabyte-file.txt
    emptyDirSizeLimit: "64Mi" # <----- new field; defaults to 20Mi
    tasks:
      - name: "Show files"
        image: "alpine"
        workingDir: "/keptn"
        cmd:
          - ls -lh

Alternative definition (which provides more flexibility, especially towards future use-cases where we might want to share volumes between jobs)
apiVersion: v2
actions:
  - name: "Print files"
    events:
      - name: "sh.keptn.event.sample.triggered"
    files:
      - my-32-megabyte-file.txt
    volumes: # <---- new field
      - emptyDir:
          sizeLimit: 64Mi
    tasks:
      - name: "Show files"
        image: "alpine"
        workingDir: "/keptn"
        cmd:
          - ls -lh

To be decided: How should config.yaml look like
Code
It should be enough to make this part of the code configurable:
https://github.com/keptn-contrib/job-executor-service/blob/4557ca2dc0dc5f9f4aeb69b986cc4487b324c8c2/pkg/k8sutils/job.go#L54-L55
Definition of Done

[ ] Docs / FEATURES.md updated
[ ] New field(s) in job config (defaults to 20Mi)
[ ] Unit test added

After some more consultation, we figured that it might not be beneficial to provide the option to mount volumes from Kubernetes, as

it might be slow, depending on the Kubernetes setup
could pose problems (what if multiple jobs run at the same time)
does not always solve the use-case properly (e.g., caching = performance)

Primary focus should be the emptyDir size, which can then be configured using option 1

A PR is available in https://github.com/keptn-contrib/job-executor-service/pull/311, though there were some comments on what needs to be improved, which I don't have time to work on, unfortunately. Unassigning myself from this issue.


Need to add a Dockerfile to v2.0-dev to run CI

Now that I've added v2.0-dev to our Github Actions CI, I think we need to populate both main and v2.0-dev with a Dockerfile to run. main will be easy, I will just PR dev to main, but for v2.0-dev, I'll need to do a separate PR, probably after #65 is merged.

This will be resolved by #73


README.md updates

Updating README.md to include the command to ssh into other keylime instances created using vagrant, as well as starting the IMA emulator while deploying Keylime.

@font Please review. Thanks!


How to interpret this tool output? (This is not an issue)

Hello, what would be the meaning of this output? Just that the backend server is parsing the Content-Length header, thus not meaning that it is or is not vulnerable?
http_method=GET, detect_method=detect content length parsing, smuggling_method=no header smuggling, smuggling_variant=N/A, padding_method=no padding headers: distinguishable not by timing
Thank you very much.

Hello,
This exact line look like false positive.
I think that reading the source code is the best way to understand the output right now)


ci: add ubuntu 18.04 and rocky 9.1 builds configuration for azure

What problem does this PR solve?:

Add ubuntu 18.04 and rocky 9.1 e2e tests for azure.

Which issue(s) does this PR fix?:

https://jira.d2iq.com/browse/D2IQ-NUMBER

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

We also have azure tests for "rhel-7", "oracle-7", "sles-15" and "flatcar" in teamcity which are not migrated over GHA.
These configurations are not supported by https://docs.d2iq.com/dkp/2.4/supported-infrastructure-operating-systems
Not sure why those builds added in Teamcity. Should we migrate them to GHA too?
or should we disable them in TC?
@faiq @dkoshkin

We also have azure tests for "rhel-7", "oracle-7", "sles-15" and "flatcar" in teamcity which are not migrated over GHA.
These configurations are not supported by https://docs.d2iq.com/dkp/2.4/supported-infrastructure-operating-systems
Not sure why those builds added in Teamcity. Should we migrate them to GHA too?
or should we disable them in TC?
@faiq @dkoshkin

we shouldn't add builds that we don't claim we support. adding them to the previous CI was a mistake

we shouldn't add builds that we don't claim we support

I'm inclined to agree.


Add uestc

@tmggg First stage of verification passed, official domain is cduestc.cn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Thank you for your reply.

@tmggg Thank you for your patience while waiting for a review and processing your request. Pull request merged.


fix(operators): Remove shareReplay and shareBehavior

Remove two operators that were reintroduced by mistake. shareReplay and shareBehavior should not
exist anymore.
Resolves issue #710.

Merged with 536a6a6, thanks @staltz


tcgc needs to expose if a time is UTC or not

tsp exposes utcDateTime and offsetDateTime, see reference. tcgc doesn't expose the distinction between time types that are in UTC or contain a time-zone offset.

@iscai-msft do you know the original purpose why we convert both utcDateTime and offsetDateTime to datatime in tcgc?

make it a non-breaking change


Updated italian translation

Synced with en.js at commit 144f6c65578446bacf5e09632f36e906bdd0b639

Thank you ugilio for keeping this up to date. Email me your mailing address & shirt size so I can send you a thank you<EMAIL_ADDRESS>


interfaces/ folder not getting packaged

When I moved to alpha versions of ovos-core and ovos-workshop I accidentally removed the Manjaro installation of ovos-gui. Upon reinstalling it I didn't have the interfaces module or any of its files. When I copied them manually I was able to get my screen back.
I believe setup.py needs to be updated per Jarbas' comment on Matrix but not exactly sure how/where.

fixed in https://github.com/OpenVoiceOS/ovos-gui/commit/6e698465a8591f4496a7ef2e3fc86fd96633c6f8


WIP: Build resources/contact view

Description
This PR adds the resources/contact page as well as the side nav for all resources/ pages as indicated in the current Figma design.
Related Ticket
Resolves #79
To do

[x] Build nav for mobile views

Checklist

[X] Building the site with npm run build-site works without errors
[X] Building the app with npm run build-app works without errors
[X] I formatted JS and TS files with running npm run format-all

@kaxline sorry for the delay on reviewing. It looks great to me. I just noticed the yarn.lock though, can you delete that? we only use NPM plz 🙏


install_deps should be in README

README should pointer to scripts/setup/ubuntu-20.04/install_deps.sh or similar

The install_deps.sh script is mentioned in the Kani Installation Guide which is linked from the README. Closing this issue.


generating dataset from csv file

Hi, can you hint on how to generate XML files from csv annotations?

Hi,
The annotation data for this repository is already in xml format. If you have your annotations in csv files, you can use a script to convert the csv files to xml files respecting the PASCAL VOC format.


improvement Add BackupJobInfo with tableCommitSeqMap

Proposed changes
Add BackupJobInfo with tableCommitSeqMap

LGTM

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.98 seconds
stream load tsv:          459 seconds loaded<PHONE_NUMBER>9 Bytes, about 155 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          58 seconds loaded<PHONE_NUMBER> Bytes, about 18 MB/s
stream load parquet:          29 seconds loaded 861443392 Bytes, about 28 MB/s
insert into select:          68.9 seconds inserted 10000000 Rows, about 145K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230627170622_clickbench_pr_168987.html


fix: remove default memory cap for index training

Removed hard-coded 4GB limit, as sometimes that produces errors like:
OSError: LanceError(IO): Resources exhausted: Failed to allocate additional<PHONE_NUMBER> bytes for ExternalSorter[0] with 0 bytes already allocated - maximum available is<PHONE_NUMBER>, /rustc/79e9716c980570bfd1f666e3b16ac583f0168962/library/core/src/convert/mod.rs:716:9

Instead users can set this as an environment variable:
export LANCE_MEMORY_LIMIT=$((4 * 1024 * 1024 * 1024))

I did an environment variable for now because the indexing parameters are a mess and I don't want to refactor them yet.
Because we don't know how much memory the client machine may have, we set it to unbounded by default.
Closes #1701

Is this environment variable respected by the lancedb python API? I'm using version 0.9.0, and it appears to have no effect when running the following:
export LANCE_MEMORY_LIMIT=$((4 * 1024 * 1024 * 1024))
...
>>> await table.create_index("vector", config=index.IvfPq(distance_type="cosine", num_partitions=10000), replace=True)

The process gets killed, and using vmstat to monitor memory while it's running shows the available memory on the machine (32GB) dropping down into the MB range.

Is this environment variable respected by the lancedb python API? I'm using version 0.9.0, and it appears to have no effect when running the following:
export LANCE_MEMORY_LIMIT=$((4 * 1024 * 1024 * 1024))
...
>>> await table.create_index("vector", config=index.IvfPq(distance_type="cosine", num_partitions=10000), replace=True)

The process gets killed, and using vmstat to monitor memory while it's running shows the available memory on the machine (32GB) dropping down into the MB range.

Looks like it may be less of this setting, and more likely related to this thread: https://github.com/lancedb/lancedb/issues/767

The LANCE_MEMORY_LIMIT environment variable no longer exists.  The shuffling process it used to apply to has changed considerably (and will be changing more in the nearish future).
I have been working recently on splitting the index training process into steps (https://github.com/lancedb/lance/pull/2553 https://github.com/lancedb/lance/pull/2562 https://github.com/lancedb/lance/pull/2556).  I still have some ways to go here but hope to finish in the next week or two.  Once that is done I hope to be able to explore and tune the individual steps so that we can better communicate how much memory is required for each step and find ways to improve.

Great, thanks for that info. I appreciate your help!


feat: add accessibility automation configuration

Description
Changes proposed in this pull request:

feat: add accessibility automation configuration
add simple test case
adjust gitignore
add continuum packages

Related issue(s)

Definition of done

[x] The PR's title starts with one of the following prefixes:

feat: A new feature
fix: A bug fix
docs: Documentation only changes
refactor: A code change that neither fixes a bug nor adds a feature
test: Adding tests
chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.

[x] Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
[x] Explain clearly why you created the PR and what changes it introduces
[ ] All necessary steps are delivered, for example, tests, documentation, merging

/override tide


Added support for type conversions prior to publishing to kinesis, e.g. avro to json.

@brandonl Is this PR still relevant? If so pls make sure it is up-to-date. If not pls close it.


[TACHYON-1278] Extend socket timeout to fix build

https://tachyon.atlassian.net/browse/TACHYON-1278
Logging revealed that createRawTable is taking the server ~32 seconds, but our socket timeout of 30 seconds ruins everything.

wow, how does createRawTable take so long?

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/6876/
Test PASSed.

@gpang It executes mkdir 800 times, with each mkdir taking about 40 milliseconds.

LGTM. Just curious, why are mkdir called so many times? Is it possible to save some of those?

We represent each column of a table with its own directory, and the test creates a table with 800 columns.

hmm, do we need to test such wide table?

good question, I'd expect it's fine to do ~10 columns instead. @calvinjia ?

@aaudiber Is the code just less efficient for mkdirs now? It seemed to be passing before without any issues.

@calvinjia It's only ~2 seconds over the timeout now, so even the smallest performance hit could have tipped it over. It might also be that the Jenkins machines have gotten slower.

Well, we added a timeout in 0.8.2 to the socket. Before, it would never timeout which would cause indefinite hangs sometimes. I arbitrarily picked 30 seconds, but increasing that is fine, and now, there is a client config parameter to customize it.


Missing javascript sample code in application insights docs

Location: https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-telemetry?view=azure-bot-service-4.0&tabs=javascript#enabling-telemetry-to-capture-usage-data-from-other-services-like-luis-and-qna-maker
Issue: In the fourth bullet point of this section it alludes to some sample code with the box used to display sample code being displayed below the bullet point, however it's empty

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db892de5-e60e-1d4f-505b-11b1cdb73323
Version Independent ID: f7263014-b8fa-9a20-71aa-e4217b2821ee
Content: Add telemetry to your bot - Bot Service
Content Source: articles/v4sdk/bot-builder-telemetry.md
Service: bot-service
GitHub Login: @WashingtonKayaker
Microsoft Alias: kamrani

Thank you for reporting this, the link to the sample's source code was off by one.  This was due to the sample source being changed since the article was written.


htmlCollection iteration order

I am having a hard time understanding the htmlCollection iteration order.
Could you have a look at this Pen and give me some hints how to output a html table in proper order ?
https://codepen.io/anon/pen/XzEvzB

Hi Rusco,
Its a silly bug in the code
const td = (data) => hc(data, (val, idx) => { val[idx] }, (val, idx) =>
html${val}	);
Just change the red part to this one
const td = (data) => hc(data, (val, idx) => val , (val, idx) =>
html${val}	);
Than will fix the issue :)
Btw, please use key if you want to use htmlCollection.
Thanks for checking yalla
On Wed, Nov 22, 2017 at 2:39 PM, Rusco<EMAIL_ADDRESS>wrote:

I am having a hard time understanding the htmlCollection iteration order.
Could you have a look at this Pen and give me some hints how to output a
html table in proper order ?
https://codepen.io/anon/pen/XzEvzB
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yallajs/yalla/issues/7, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABqn3Ers76L4Yheu0lW3N8mAYNqIyYGiks5s4_nPgaJpZM4QnMDV
.

Oh I cannot see the color background, :)
Its a bug in your code pen, please check the changes.
If fix it in the codepen

This is the full fix code

//first approach without yalla:
const tdata1 = [['1', '2', '3', '4'], ['5', '6', '7', '8'], ['9', '10', '11', '12']];
const td1 = (row) => `${row.map(k => `${k}	`).join("")}`;
const tr1 = (table) => `<table border="1">${table.map(k => `
${td1(k)}
`).join("")}</table>`;
console.log(tr1(tdata1));

let { html, htmlCollection } = new Context();
let hc = htmlCollection;
//order of rows/columns gets mixed up, idx iteration is inverse ?
const tdata = [['1', '2', '3', '4'], ['5', '6', '7', '8'], ['9', '10', '11', '12']];
const td = (data) => hc(data, (val, idx) => val[idx] }, (val, idx) => html`<td>${val}</td>`);
const tr = (data) => hc(data, (val, idx) => val[idx], (val, idx) => html`<tr>${td(val)}</tr>`);
const table = html`<table>${tr(tdata)}</table>`;

render(table, document.getElementById("table"));

Full fix code

//first approach without yalla:
const tdata1 = [['1', '2', '3', '4'], ['5', '6', '7', '8'], ['9', '10', '11', '12']];
const td1 = (row) => `${row.map(k => `${k}	`).join("")}`;
const tr1 = (table) => `<table border="1">${table.map(k => `
${td1(k)}
`).join("")}</table>`;
console.log(tr1(tdata1));

let { html, htmlCollection } = new Context();
let hc = htmlCollection;
//order of rows/columns gets mixed up, idx iteration is inverse ?
const tdata = [['1', '2', '3', '4'], ['5', '6', '7', '8'], ['9', '10', '11', '12']];
const td = (data) => hc(data, (val, idx) => val, (val, idx) => html`<td>${val}</td>`);
const tr = (data) => hc(data, (val, idx) => val[idx], (val, idx) => html`<tr>${td(val)}</tr>`);
const table = html`<table>${tr(tdata)}</table>`;

render(table, document.getElementById("table"));


Saving issues

Haven't actually sat down and tried to use the app to make a beat in a while, and I ran into a weird saving issue. It seems very reproducible:

Create a new Project
Add a step to the default Track/Track Section.
Attempt to save the project.

The project seems to save but the step(s) are wiped out.
Going to raise this for further investigation & to let people know it's on my radar. Apologies to anyone who has been trying to use the app & is losing work or unable to save because of this! Hoping to clean some of this up with some test coverage, too.

Update: looks like it started happening in this commit (jotai@1.6.5): 84275c7
Saving still worked in this commit (jotai@1.6.4): 396f61b528abcb2bcf2b0b70be757bb390aec684


chore(log): Disable the spam message from pubsub module.

Partially fix #1992.
I'm not sure this is a final fix, but at least let's disable the spam message first, or we could not see any real problem.
I let it run on blockspacerace for about 2 hours after modify, don't see any problem besides having to resync bridge again.
My bridge established no more than 20 connections, seems very low.

Codecov Report

Merging #2002 (80152d8) into main (f18b1ab) will decrease coverage by 0.05%.
The diff coverage is 9.85%.

@@            Coverage Diff             @@
##             main    #2002      +/-   ##
==========================================
- Coverage   54.95%   54.91%   -0.05%
==========================================
  Files         216      215       -1
  Lines       13925    13917       -8
==========================================
- Hits         7653     7642      -11
- Misses       5460     5461       +1
- Partials      812      814       +2

Impacted Files
Coverage Δ

cmd/celestia/main.go
47.05% <ø> (ø)

nodebuilder/node/admin.go
26.66% <0.00%> (ø)

cmd/celestia/rpc.go
7.03% <7.03%> (ø)

share/eds/eds.go
67.19% <40.00%> (-1.87%)
:arrow_down:

api/rpc/client/client.go
72.72% <100.00%> (-9.63%)
:arrow_down:

core/testing.go
91.86% <100.00%> (+0.09%)
:arrow_up:

logs/logs.go
88.88% <100.00%> (+0.65%)
:arrow_up:

... and 6 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@HoytRen can you please rebase and also suppress net/identify logs to ERROR ?

Sure, work done. I don't see any new problem when I run modified version on blockspacerace.


buildbot: 3.8.0 -> 3.9.0

Description of changes
https://github.com/buildbot/buildbot/releases/tag/v3.9.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249871 run on x86_64-linux 1

20 packages built:

buildbot
buildbot-full
buildbot-plugins.badges
buildbot-plugins.badges.dist
buildbot-plugins.buildbot-pkg
buildbot-plugins.buildbot-pkg.dist
buildbot-plugins.console-view
buildbot-plugins.console-view.dist
buildbot-plugins.grid-view
buildbot-plugins.grid-view.dist
buildbot-plugins.waterfall-view
buildbot-plugins.waterfall-view.dist
buildbot-plugins.wsgi-dashboards
buildbot-plugins.wsgi-dashboards.dist
buildbot-plugins.www
buildbot-plugins.www.dist
buildbot-ui
buildbot-worker
buildbot-worker.dist
buildbot.dist


[Backport - Mitaka] MaaS: Set default alarm/check params

This patch sets the default alarm exclusions and check periods as
specified in #948.
(cherry pick from master c89e007)
Connects rcbops/u-suk-dev#1081

recheck_upgrade


ci(workflow): post build result as comment

What does this PR do?
Improve repo
Description

Updates the workflow to post a review and comment on the result of the build.

On push, if the build fails it will post the output of fpb-lint and request changes.
On push, if the build succeeds it will just approve the changes.

Why is this valuable (or not)?
I'm hoping this will make it easier for new contributors who don't understand how to check build failures, or can't find the warning in the logs.
Checklist:

[x] Read our contributing guidelines
[x] Search for duplicates.

Followup

Check the output of Travis-CI for linter errors!

failed to create review: Resource not accessible by integration

I'm assuming that's because of the repository settings.
@eshellman Sorry to pester, could you please peek at the settings:
https://github.com/EbookFoundation/free-programming-books/settings/actions
I'm assuming the one that needs to change is Workflow permissions → Read and write permissions should be selected.
This should hopefully give it permission to post reviews.

Actually… GitHub just tried to run my new workflow in the PR for the new workflow?
Maybe this is a bad idea, actually. 🤔
If GitHub will automatically run workflows for most users, and it will use the workflow configuration from their PR, that would open many opportunities to be malicious. I need to look into this.

Current setting is to allow all actions and "Require approval for first-time contributors who are new to GitHub
Only first-time contributors who recently created a GitHub account will require approval to run workflows."

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#allowing-specific-actions-to-run

If this is not ready yet, we should at least remove Travis and associated documentation before October.

Conficts with #5587 - commit https://github.com/EbookFoundation/free-programming-books/commit/09bbc1c2d9a5e5f7a257a71546095189d713e27e#diff-d1e75195b3218fdf3e35dbe669c50cb0638f0a506887d47981978a2cfc4554dd

Whether this will be added is another thing, but regardless over at TLDR, there is a pretty printed message sent https://github.com/tldr-pages/tldr/pull/7883#issuecomment-1072653937 like that.
Adding this helps new contributors easily fix their issues, so adding this would be a useful edition, especially with how many new Github users there are that contribute resources here and often make beginner mistakes.

_Accidentally hit the close and send button _

I'm thinking about coming back to this one later, but first I'd like https://github.com/vhf/free-programming-books-lint/pull/29 to be resolved. 🤔
I think there was a discussion before about some of the linter repos being transferred to EbookFoundation, is that still a thing?

I think there was a discussion before about some of the linter repos being transferred to EbookFoundation, is that still a thing?

Yes, you are right. Last word was about if somebody with minimal knowledges takes the control about npm registry account, it said Victor, to be able to make the deploys. In practice I think transfer fpblint would be great!!

@LuigiImVector do you see this to be applied to #6914. Use and envvar instead of write in file

@LuigiImVector do you see this to be applied to #6914. Use an envvar instead of write in temp file to compose lint report

I didn't understand, do you mean to save the file name to an envvar?

@LuigiImVector do you see this to be applied to #6914. Use an envvar instead of write in temp file to compose lint report

I didn't understand, do you mean to save the file name to an envvar?

Sorry for no context. I forgot cite the last Seth's post:

GitHub made a new feature which might make this cleaner:
https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/
It doesn't post a comment though, but rather than post a comment here we could use the summary feature and link to that page from here.

Doing this I think isn't necesary a sub-workflow

as soon as I have time I will try to implement it and check if it is okay, thanks

Conficts with #5587 - commit 09bbc1c#diff-d1e75195b3218fdf3e35dbe669c50cb0638f0a506887d47981978a2cfc4554dd
node-version: 14.x -> 16.x

More conflicts with #6696 and #6820 which contains parts with a more recent version (preserve both sides)

I'll close this in favor of #6914 who has made substantially more progress toward this goal.


Add test to make sure attributes aren't missing values

Attributes should either have values_from when they inherit values, or values if they have their own list of values. In the latter case, the values array should not be empty.
This is a followup to: https://github.com/Shopify/product-taxonomy/pull/125#discussion_r1551917060

https://github.com/Shopify/product-taxonomy/blob/main/test/integration/all_data_files_import_test.rb#L28-L38 should cover it.
And when we add dimensions, I suspect we ad a "third" type: value_validations or something to that effect?


added per-category examples and ice-area tracer

Added a notebook with examples of per-category ice area fraction and snow depth plotting and the difference between regular and ice area only sensible heat flux. Not sure if I'll have a chance to do contour plotting and region averaging but hopefully this is enough of advanced examples to get students started.

@davidclemenssewall Thanks! I think this is great for now. I will see if I can add the contour plotting/regridding and/or regional averaging. But it won't be this week...


HBASE-22695 Store the rsgroup of a table in table configuration

Still some bugs in the balancer and can not pass TestRSGroupsAdmin2.
Will update the patch soon.
Create a PR first so others can see the approach on how to store rsgroup of a table in table configuration.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
38
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
15
Maven dependency ordering for branch

+1
mvninstall
290
HBASE-22514 passed

+1
compile
93
HBASE-22514 passed

+1
checkstyle
124
HBASE-22514 passed

+1
shadedjars
268
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
75
HBASE-22514 passed

0
spotbugs
263
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
374
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
309
the patch passed

+1
compile
101
the patch passed

+1
javac
101
the patch passed

-1
checkstyle
76
hbase-server: The patch generated 4 new + 136 unchanged - 17 fixed = 140 total (was 153)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
264
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
928
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
73
the patch passed

+1
findbugs
401
the patch passed

_ Other Tests _

+1
unit
168
hbase-common in the patch passed.

+1
unit
104
hbase-client in the patch passed.

-1
unit
7694
hbase-server in the patch failed.

+1
asflicense
87
The patch does not generate ASF License warnings.

11960

Reason
Tests

Failed junit tests
hadoop.hbase.rsgroup.TestRSGroupsKillRS

hadoop.hbase.rsgroup.TestRSGroupsAdmin2

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5f3ce8f4776b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 47d6533186

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/1/testReport/

Max. process+thread count
4260 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
149
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
46
Maven dependency ordering for branch

+1
mvninstall
472
HBASE-22514 passed

+1
compile
145
HBASE-22514 passed

+1
checkstyle
182
HBASE-22514 passed

+1
shadedjars
381
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
115
HBASE-22514 passed

0
spotbugs
339
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
495
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
418
the patch passed

+1
compile
139
the patch passed

+1
javac
139
the patch passed

-1
checkstyle
111
hbase-server: The patch generated 4 new + 136 unchanged - 17 fixed = 140 total (was 153)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
360
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1314
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
100
the patch passed

-1
findbugs
343
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
196
hbase-common in the patch passed.

+1
unit
130
hbase-client in the patch passed.

-1
unit
13823
hbase-server in the patch failed.

+1
asflicense
72
The patch does not generate ASF License warnings.

19818

Reason
Tests

FindBugs
module:hbase-server

Nullcheck of info at line 344 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map)  At RSGroupBasedLoadBalancer.java:344 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map)  At RSGroupBasedLoadBalancer.java:[line 344]

Failed junit tests
hadoop.hbase.master.TestMasterShutdown

hadoop.hbase.rsgroup.TestRSGroupsKillRS

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a511b186dc25 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 47d6533186

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/diff-checkstyle-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/new-findbugs-hbase-server.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/testReport/

Max. process+thread count
4884 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
40
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
284
HBASE-22514 passed

+1
compile
100
HBASE-22514 passed

+1
checkstyle
136
HBASE-22514 passed

+1
shadedjars
393
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
192
HBASE-22514 passed

0
spotbugs
508
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
756
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
42
Maven dependency ordering for patch

+1
mvninstall
452
the patch passed

+1
compile
190
the patch passed

+1
javac
190
the patch passed

+1
checkstyle
41
The patch passed checkstyle in hbase-common

+1
checkstyle
51
The patch passed checkstyle in hbase-client

+1
checkstyle
113
hbase-server: The patch generated 0 new + 136 unchanged - 17 fixed = 136 total (was 153)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
397
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
921
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
75
the patch passed

-1
findbugs
252
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1
unit
181
hbase-common in the patch passed.

+1
unit
112
hbase-client in the patch passed.

-1
unit
7811
hbase-server in the patch failed.

+1
asflicense
79
The patch does not generate ASF License warnings.

13285

Reason
Tests

FindBugs
module:hbase-server

Nullcheck of info at line 344 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map)  At RSGroupBasedLoadBalancer.java:344 of value previously dereferenced in org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map)  At RSGroupBasedLoadBalancer.java:[line 344]

Failed junit tests
hadoop.hbase.rsgroup.TestRSGroupsKillRS

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 922dfc435bb3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 47d6533186

Default Java
1.8.0_181

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/3/artifact/out/new-findbugs-hbase-server.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/3/testReport/

Max. process+thread count
4959 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
29
Maven dependency ordering for branch

+1
mvninstall
401
HBASE-22514 passed

+1
compile
133
HBASE-22514 passed

+1
checkstyle
174
HBASE-22514 passed

+1
shadedjars
365
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
96
HBASE-22514 passed

0
spotbugs
340
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
485
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
17
Maven dependency ordering for patch

+1
mvninstall
396
the patch passed

+1
compile
131
the patch passed

+1
javac
131
the patch passed

+1
checkstyle
32
The patch passed checkstyle in hbase-common

+1
checkstyle
39
The patch passed checkstyle in hbase-client

+1
checkstyle
104
hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
371
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1248
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
95
the patch passed

+1
findbugs
517
the patch passed

_ Other Tests _

+1
unit
205
hbase-common in the patch passed.

+1
unit
124
hbase-client in the patch passed.

-1
unit
14940
hbase-server in the patch failed.

+1
asflicense
83
The patch does not generate ASF License warnings.

20555

Reason
Tests

Failed junit tests
hadoop.hbase.rsgroup.TestRSGroupsAdmin2

hadoop.hbase.rsgroup.TestRSGroupsKillRS

hadoop.hbase.rsgroup.TestRSGroupsAdmin1

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux eac0186d0c0d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1b5f6b5a48

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/5/testReport/

Max. process+thread count
5200 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
135
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

+1
mvninstall
433
HBASE-22514 passed

+1
compile
135
HBASE-22514 passed

+1
checkstyle
180
HBASE-22514 passed

+1
shadedjars
362
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
98
HBASE-22514 passed

0
spotbugs
321
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
463
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

+1
mvninstall
411
the patch passed

+1
compile
124
the patch passed

+1
javac
124
the patch passed

+1
checkstyle
33
The patch passed checkstyle in hbase-common

+1
checkstyle
40
The patch passed checkstyle in hbase-client

+1
checkstyle
105
hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
362
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1284
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
91
the patch passed

+1
findbugs
426
the patch passed

_ Other Tests _

+1
unit
179
hbase-common in the patch passed.

+1
unit
113
hbase-client in the patch passed.

-1
unit
13077
hbase-server in the patch failed.

+1
asflicense
90
The patch does not generate ASF License warnings.

18733

Reason
Tests

Failed junit tests
hadoop.hbase.rsgroup.TestRSGroupsKillRS

hadoop.hbase.master.assignment.TestOpenRegionProcedureHang

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6bc11fb1141c 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1b5f6b5a48

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/6/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/6/testReport/

Max. process+thread count
4776 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
67
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
22
Maven dependency ordering for branch

+1
mvninstall
319
HBASE-22514 passed

+1
compile
111
HBASE-22514 passed

+1
checkstyle
151
HBASE-22514 passed

+1
shadedjars
298
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
77
HBASE-22514 passed

0
spotbugs
277
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
385
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

+1
mvninstall
321
the patch passed

+1
compile
101
the patch passed

+1
javac
101
the patch passed

+1
checkstyle
25
The patch passed checkstyle in hbase-common

+1
checkstyle
34
The patch passed checkstyle in hbase-client

+1
checkstyle
92
hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
297
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1022
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
76
the patch passed

+1
findbugs
412
the patch passed

_ Other Tests _

+1
unit
172
hbase-common in the patch passed.

+1
unit
104
hbase-client in the patch passed.

-1
unit
13070
hbase-server in the patch failed.

+1
asflicense
70
The patch does not generate ASF License warnings.

17672

Reason
Tests

Failed junit tests
hadoop.hbase.rsgroup.TestRSGroupsKillRS

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ea70ac98f92b 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1b5f6b5a48

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/testReport/

Max. process+thread count
4510 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
73
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
62
Maven dependency ordering for branch

-1
mvninstall
326
root in HBASE-22514 failed.

+1
compile
94
HBASE-22514 passed

+1
checkstyle
125
HBASE-22514 passed

+1
shadedjars
256
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
71
HBASE-22514 passed

0
spotbugs
251
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
362
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
15
Maven dependency ordering for patch

-1
mvninstall
278
root in the patch failed.

+1
compile
98
the patch passed

+1
javac
98
the patch passed

-1
checkstyle
74
hbase-server: The patch generated 1 new + 136 unchanged - 15 fixed = 137 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
296
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
221
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
488
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
728
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
73
the patch passed

+1
findbugs
373
the patch passed

_ Other Tests _

+1
unit
162
hbase-common in the patch passed.

+1
unit
102
hbase-client in the patch passed.

-1
unit
15873
hbase-server in the patch failed.

+1
asflicense
144
The patch does not generate ASF License warnings.

19775

Reason
Tests

Failed junit tests
hadoop.hbase.rsgroup.TestRSGroupsBalance

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 2c1b6969b9da 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 1b5f6b5a48

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/patch-mvninstall-root.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/diff-checkstyle-hbase-server.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/patch-javac-3.1.2.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/testReport/

Max. process+thread count
4756 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
80
Docker mode activated.

_ Prechecks _

+1
dupname
1
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
36
Maven dependency ordering for branch

+1
mvninstall
408
HBASE-22514 passed

+1
compile
134
HBASE-22514 passed

+1
checkstyle
170
HBASE-22514 passed

+1
shadedjars
367
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
95
HBASE-22514 passed

0
spotbugs
349
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
494
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
18
Maven dependency ordering for patch

+1
mvninstall
385
the patch passed

+1
compile
125
the patch passed

+1
javac
125
the patch passed

-1
checkstyle
95
hbase-server: The patch generated 1 new + 136 unchanged - 15 fixed = 137 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
344
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1204
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
93
the patch passed

+1
findbugs
516
the patch passed

_ Other Tests _

+1
unit
207
hbase-common in the patch passed.

+1
unit
126
hbase-client in the patch passed.

+1
unit
15495
hbase-server in the patch passed.

+1
asflicense
72
The patch does not generate ASF License warnings.

21052

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f5320d6ddfbc 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 33a99f2d28

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/testReport/

Max. process+thread count
4470 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/10/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

OK, good. Finally we got all UTs passed. Let me address the checkstyle issues.
@infraio @sunhelly Any other oncerns? Thanks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
32
Maven dependency ordering for branch

-1
mvninstall
323
root in HBASE-22514 failed.

+1
compile
96
HBASE-22514 passed

+1
checkstyle
131
HBASE-22514 passed

+1
shadedjars
271
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
74
HBASE-22514 passed

0
spotbugs
248
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
362
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
16
Maven dependency ordering for patch

-1
mvninstall
316
root in the patch failed.

+1
compile
98
the patch passed

+1
javac
98
the patch passed

+1
checkstyle
23
The patch passed checkstyle in hbase-common

+1
checkstyle
31
The patch passed checkstyle in hbase-client

+1
checkstyle
78
hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
269
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
221
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
450
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
722
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
78
the patch passed

+1
findbugs
389
the patch passed

_ Other Tests _

+1
unit
177
hbase-common in the patch passed.

+1
unit
102
hbase-client in the patch passed.

-1
unit
16301
hbase-server in the patch failed.

+1
asflicense
119
The patch does not generate ASF License warnings.

20196

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestAsyncRegionAdminApi

hadoop.hbase.replication.TestReplicationSmallTests

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 4e09186fac1c 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 33a99f2d28

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/patch-javac-3.1.2.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/testReport/

Max. process+thread count
4760 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/12/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
81
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
25
Maven dependency ordering for branch

-1
mvninstall
81
root in HBASE-22514 failed.

-1
compile
20
hbase-client in HBASE-22514 failed.

-1
compile
34
hbase-server in HBASE-22514 failed.

+1
checkstyle
128
HBASE-22514 passed

+1
shadedjars
273
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
71
HBASE-22514 passed

0
spotbugs
48
Used deprecated FindBugs config; considering switching to SpotBugs.

-1
findbugs
20
hbase-client in HBASE-22514 failed.

-1
findbugs
36
hbase-server in HBASE-22514 failed.

_ Patch Compile Tests _

0
mvndep
13
Maven dependency ordering for patch

-1
mvninstall
87
root in the patch failed.

-1
compile
20
hbase-client in the patch failed.

-1
compile
37
hbase-server in the patch failed.

-1
javac
20
hbase-client in the patch failed.

-1
javac
37
hbase-server in the patch failed.

+1
checkstyle
22
The patch passed checkstyle in hbase-common

+1
checkstyle
30
The patch passed checkstyle in hbase-client

+1
checkstyle
74
hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
268
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
54
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
109
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
166
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
71
the patch passed

-1
findbugs
20
hbase-client in the patch failed.

-1
findbugs
37
hbase-server in the patch failed.

_ Other Tests _

+1
unit
171
hbase-common in the patch passed.

-1
unit
21
hbase-client in the patch failed.

-1
unit
37
hbase-server in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

2111

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux c4b67407b971 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 33a99f2d28

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-compile-hbase-client.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-compile-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-findbugs-hbase-client.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/branch-findbugs-hbase-server.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-mvninstall-root.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-client.txt

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-client.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-compile-hbase-server.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-javac-3.1.2.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-findbugs-hbase-client.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-findbugs-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-unit-hbase-client.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/testReport/

Max. process+thread count
290 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/13/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
62
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 10 new or modified test files.

_ HBASE-22514 Compile Tests _

0
mvndep
31
Maven dependency ordering for branch

-1
mvninstall
322
root in HBASE-22514 failed.

+1
compile
106
HBASE-22514 passed

+1
checkstyle
139
HBASE-22514 passed

+1
shadedjars
290
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
82
HBASE-22514 passed

0
spotbugs
280
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
398
HBASE-22514 passed

_ Patch Compile Tests _

0
mvndep
14
Maven dependency ordering for patch

-1
mvninstall
312
root in the patch failed.

+1
compile
102
the patch passed

+1
javac
102
the patch passed

+1
checkstyle
25
The patch passed checkstyle in hbase-common

+1
checkstyle
31
The patch passed checkstyle in hbase-client

+1
checkstyle
79
hbase-server: The patch generated 0 new + 136 unchanged - 15 fixed = 136 total (was 151)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
291
patch has no errors when building our shaded downstream artifacts.

-1
hadoopcheck
314
The patch causes 10 errors with Hadoop v2.8.5.

-1
hadoopcheck
653
The patch causes 10 errors with Hadoop v2.9.2.

-1
hadoopcheck
995
The patch causes 10 errors with Hadoop v3.1.2.

+1
javadoc
79
the patch passed

+1
findbugs
432
the patch passed

_ Other Tests _

+1
unit
183
hbase-common in the patch passed.

+1
unit
111
hbase-client in the patch passed.

+1
unit
15484
hbase-server in the patch passed.

+1
asflicense
74
The patch does not generate ASF License warnings.

19769

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/426

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 25f9f8aa79d1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-426/out/precommit/personality/provided.sh

git revision
HBASE-22514 / 06c8e4e52c

Default Java
1.8.0_181

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/branch-mvninstall-root.txt

mvninstall
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-mvninstall-root.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-javac-2.8.5.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-javac-2.9.2.txt

hadoopcheck
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/artifact/out/patch-javac-3.1.2.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/testReport/

Max. process+thread count
4682 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-426/15/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


QST: task count for getting one partition

What happened:
Created a dask.dataframe of multiple partitions. Got a single partition and saw the number of tasks is the same as the number of partitions or larger.
What you expected to happen:
When getting a partition from a dask.dataframe wouldn't the task count be 1? In the example below it shows 10. I may be mistaken here e.g. the number of tasks stays the same as the total number of partitions because the metadata/dataframe has to be scanned to find where the partition is located? I know it runs very fast as having a large file in remote storage (say 1,000 partitions i.e. read parquet says 1000 tasks) and getting one partition is fast.
Minimal Complete Verifiable Example:
import dask.dataframe as dd

ddf = dd.demo.make_timeseries(
    start="2000-01-01",
    end="2000-01-10",
    dtypes={"x": float, "y": float, "id": int},
    freq="1min",
    partition_freq="24h",
) # 9 tasks
ddf.to_parquet("tmp.parquet")

ddf = dd.read_parquet("tmp.parquet")
ddf.get_partition(0)

`
ddf.get_partition(0).visualize()

You have to cull the graph to get what you want; like passing optimize_graph=True to visualize
I wrote this function to do what you want (but with xarray things wrapping dask arrays) though I think there are still a few bugs. IT would be nice if dask provided a robust version of this functionality for dask collections
def visualize_one_block(dataset, **kwargs):
    """
    Visualize one block of a Dataset or DataArray.
    """
    graph = None
    if isinstance(dataset, xr.DataArray):
        dataset = dataset._to_temp_dataset()

    keys = []
    block = get_one_block(dataset.unify_chunks())
    graph = block.__dask_graph__()

    for _, variable in block.variables.items():
        if isinstance(variable.data, dask.array.Array):
            key = (variable.data.name,) + (0,) * variable.ndim
            keys.append(key)

    if graph is None:
        raise ValueError("No dask variables!")
    return dask.visualize(graph.cull(set(keys)), **kwargs)

def get_one_block(dataset):
    if isinstance(dataset, xr.DataArray):
        array = dataset
        dataset = dataset._to_temp_dataset()
        to_array = True
    else:
        to_array = False
    chunk_slices = dict()
    for dim, chunks in dataset.chunks.items():
        start = 0
        chunk = chunks[0]
        stop = start + chunk
        chunk_slices[dim] = slice(start, stop)
    subset = dataset.isel(chunk_slices)
    if to_array:
        subset = array._from_temp_dataset(subset)
    return subset

Hi @raybellwaves, does this help solve your problem?

The simple solutions here seem to be
ddf.get_partition(0).visualize(optimize_graph=True)

ddf.get_partition(0).dask.visualize()

(https://github.com/dask/dask/issues/8443#issuecomment-986814308)
I think it's non-trivial to have it show two tasks from the start.

Closing as answered, but if you feel that is not the case, we can reopen to continue the discussion. Thanks all!


Update README.md

Experiment with a 🧙Hocus-pocus! line

Try to add, modify, delete, etc. this line


Create Mobile app for iPhone

Is your feature request related to a problem? Please describe.
A large part of my digital history exists on my iPhone, so when I want to remember something I've seen somewhere and search in Cyte, I expect it to show up regardless of which digital platform I saw it on.
Describe the solution you'd like
I would like to be able to download an app which after a one-time setup + permission allocation, allows Cyte to capture context from my phone (which can be revoked/deleted/paused)
Describe alternatives you've considered
Recording my screen manually and uploading those videos to Cyte for them to be indexed. Or maybe it syncs over USB automatically. But this is an undesirable UX.
Additional context
Apple doesn't have a functional equivalent to ScreenCaptureKit for iOS. The closest I'm aware of is ReplayKit however it requires the user to trigger the recording for each session on device. Perhaps there is a way to improve this UX using a shortcut from the home screen to trigger the session recording. These can then be relayed/synced to a locally available (via bonjour) primary Cyte app whenever they are on the same network.

Working on this here
Currently am unable to get the extension running to then test the IPC implementation.
I tried building another project for a baseline, but haven't been able to get that one to run it's extension either.


feat(wash-cli): support interface wildcard overrides

Feature or Problem
This PR supports specifying wildcard interfaces in the wasmcloud.toml to prevent multiple overrides for the same interface.
For example, to override KV nats with Redis:
[[dev.overrides.imports]]
interface_spec =<EMAIL_ADDRESS>image_ref = "ghcr.io/wasmcloud/keyvalue-redis:0.28.1"
config = { values = { url="redis://<IP_ADDRESS>:6379" } }

This PR also started using config & secrets where they weren't being used before, so an integration test started failing. I added support for a secrets policy in the event that one is specified in the last commit.
Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration
This PR initially broke an integration test related to overrides because it brought in secrets that were configured on the ovveride
Manual Verification
I manually tested with the above

Hey so I was thinking that we wouldn't need to introduce a new syntax here -- * is not a valid iface name IIRC.
The code right now is set up to handle this -- coalescing version requirements is an explicit part of the process, and it's a chance for us to detect configurations that don't work/do slightly more complex things.
I could have sworn I wrote about this somewhere but in my mind we do want to allow multiple overrides for the same interface, for example if someone has:
[[dev.overrides.imports]]
interface_spec =<EMAIL_ADDRESS>image_ref = "ghcr.io/wasmcloud/keyvalue-redis:0.28.1"
config = { values = { url="redis://<IP_ADDRESS>:6379" } }

[[dev.overrides.imports]]
interface_spec =<EMAIL_ADDRESS>image_ref = "ghcr.io/wasmcloud/keyvalue-local:0.28.1"
link_name = "local-kv"
config = { values = { backing_file="/tmp/some-file" } }

Possibly in the same component and in a workspace, they might want to use different kvs for different things actually.

This was partly why I reworked the parsing of package names in core recently -- people should be able to use wasi:keyvalue only, and that will represent a package level override.

Oh okay awesome, I think this was a big blocker there. Is that fix already merged @vados-cosmonic ? If I can just input<EMAIL_ADDRESS>that's even better

Hey yeah the fix was released last week! Here's the new code in core, and the usage in the parsing stuff for wash-lib.
The way this is supposed to get used is via WitInterfaceSpec, which has methods like is_disjoint() and includes() to figure out if some interface is "covered" by another one (and then we can theoretically do the right thing at a higher level).

Amazing @vados-cosmonic , let me try this out!

@vados-cosmonic refactored to use the new API, looked great 🥳

Alright @vados-cosmonic finally got back and added that integration test! 😄


Add MPEG-TS library

I believe this is a reasonable version now. Certainly it compiles with just a few warnings about capitalisation of some names.

It's a pity that the way the changes got squash merged makes it appear that the PR has been rejected when in fact they are all accepted. Thanks for accepting them.

I'd like to keep the GIT history clean. No rewriting of history after pushed, but PRs and others get squashed together into their functional changes without having the whole review process part of the GIT history.
You can also do that yourself and just force-push updated commits to the PR :)

Your repo, your rules. :-)  I guess I just go with actual history as it was, not worrying about keeping a linear single commit trail – though no rewriting after push definitely.
(I'm currently tinkering with the related GStreamer-Rs bit of MPEG-TS. I suspect there may be questions, but more fidddling needed first.)


Find a better way to deal with default error handlers

Description
We can't check the status of the response using default http.HandlerFunc which prevents the use of default error handlers for most errors.
We can still use/catch 404 since it's at the end of our mux.ServeHTTP function.
Possible Solutions

Adapt the http.HandlerFunc -- this prevents our handlers being used with the default ServeMux; if that's even a problem

Can't be compatible with other multiplexers and ties handlers to the mux.


Use user identity when committing + pushing changes into git repositories on the Artemis server

When Artemis commits and pushes changes into git repositories, it does that with its own identify (username + email). However, it would be better, if it would use the user identify of the currently logged in user if available.
For example, when creating or updating a programming exercise, it should use the identify of the instructor who is currently logged in.
If a student uses the online editor, it should use the identify of this student. (In this case, we could still mark the submission in the database as executed from the online editor to allow to track how often the online editor was used and to distinguish from using a local git client outside of Artemis)

I implemented this change recently.


Another of the ansible scripts not working. #42422

ASK [Add all hosts] **********************************************************************************************************************************
task path: /home/mikmikmikmik/MicrosoftAnsibleTutorial/get-hosts-tasks.yml:12
fatal: [localhost]: FAILED! => {
"msg": "'dict object' has no attribute 'ansible_facts'"
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65ed9308-a32c-9e57-46c2-707f53d953f9
Version Independent ID: 69f2cc5f-9280-d85d-3d36-b4dff0172de6
Content: Tutorial - Deploy apps to virtual machine scale sets in Azure using Ansible
Content Source: articles/ansible/ansible-deploy-app-vmss.md
Service: ansible
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

Thanks for your comment. We are actively investigating and will get back to you shortly.

Assigning @TomArcherMsft  for review

Any hope for me? :)

@mcancarevic I'm looking at this now...

@mcancarevic From what I'm reading, you need to have already "gathered facts" or be working in the developer version. I'm going to connect with the engineering team to see how to update the code so that it works.

@mcancarevic There have been changes to the code syntax. I'm working with the engineering team to update the article. Once I have verified the code, I'll also update this GitHub Issue.

@mcancarevic The following sample code should work. Please let us know if it doesn't.
`

name: Get facts for all Public IPs within a resource groups
azure_rm_publicipaddress_facts:
resource_group: "{{ resource_group }}"
register: output_ip_address

name: Get loadbalancer info
azure_rm_loadbalancer_facts:
resource_group: "{{ resource_group }}"
name: "{{ loadbalancer_name }}"
register: output

name: Add all hosts
add_host:
groups: scalesethosts
hostname: "{{ output_ip_address.publicipaddresses[0].ip_address }}_{{ item.properties.frontendPort }}"
ansible_host: "{{ output_ip_address.publicipaddresses[0].ip_address }}"
ansible_port: "{{ item.properties.frontendPort }}"
ansible_ssh_user: "{{ admin_username }}"
ansible_ssh_pass: "{{ admin_password }}"
with_items:

"{{ output.ansible_info.azure_loadbalancers[0].properties.inboundNatRules }}"
`

I believe this is fixed with the code I submitted last year. #please-close

I believe this is fixed with the code I submitted last year. #please-close


support custom elements

We have HTML code that contains custom block level tags. For example:
<code-example>
  ...
</code-example>

Currently the hashHTMLBlocks sub parser does not capture these as it only matches the built-in block level HTML tags.

What do you mean?

This input:
<code-example>
  ...
</code-example>

produces the following html output:
<code-example>
  ...
</code-example>

Ah, you want to prevent showdown from parsing the "contents" of custom blocks?
You need to use a Lang Extension or a Listener Extension that captures these custom blocks and hashes them

Hi @tivie - thanks for getting back to me so quickly!
Yes, exactly currently the contents is parsed as markdown.
I am indeed currently using a lang extension to workaround this problem, but I believe that it will become increasingly common to have custom elements in our HTML and that support for this should be built in.
If you didn't want to treat all custom elements as block level, one option would be to provide users with a configurable white list of matching element names to check...

I am indeed currently using a lang extension to workaround this problem, but I believe that it will become increasingly common to have custom elements in our HTML and that support for this should be built in.

HTML5 does not support custom elements. XHTML does, however.

If you didn't want to treat all custom elements as block level, one option would be to provide users with a configurable white list of matching element names to check...

Well, that would make the parser extremely slow since each element added would require to check for balanced tags to make sense of them, effectively turning Showdown into an HTML parser as well.
For simple cases, like <foo>bar</foo> it would not be a problem, but complex cases, like:
<foo>
  <bar>
    <baz>bazinga</baz>
    <baz>bazinga2</baz>
    <bar>blabla</bar>
  </bar>
</foo>

would be a nightmare.
Right now Showdown uses some clever tricks to enhance parsing speed. For instance, it separates blocks from spans and does not look for nested block elements inside span elements (as those do not make sense).
Letting users add custom elements would be extremely error prone.
And since extensions are supported, it's actually very simple to make an extension for specific use cases