Update role from CV

Updates role to match CV repository. See full diff: https://github.com/cmbuckley/cv/compare/9d5231bd5e1b...5a6f7c1a0768

Better link, worse Netlify config


Prevent "require" in "spec_helper" from polluting code's namespace

Example is the best explanation:
spec_helper.rb:
require 'simplecov'  # has "require 'erb'" somewhere
require 'rspec'

foo_spec.rb:
require 'foo'
describe "Foo" do
    it "should evaluate code" do
        Foo.eval('1+1').should == '2'
    end
end

foo.rb:
# BUG: developer forgot "require 'erb'" here ...

def eval(code)
    # NameError for "ERB" raised in production only!
    ERB.new("<%=#{code}%>").result
end

Result: Specs pass, project is deployed and "NameError" occurs in production
Expected: Specs should fail with "NameError" exception.
Description: things like ERB, FileUtils,etc shouldn't be available for the code being tested, unless it is explicitly loaded by that code.
I would write a patch, I'm just making sure I'm not missing something important here.

What do you expect rspec to do here?

I don't think what you're asking is possible in ruby.  If you load another library that loads something else, that something else is going to be loaded into the processes' memory and there's no way rspec can prevent that or work around that.  It's simply how ruby works.

@dchelimsky: Good question :) Anything actually, to give the code run under RSpec to have an "environment" as similar to the one outside RSpec.
The outline:

require 'rspec' detects symbols it doesn't know about, e.g.:
:SimpleCov, :Digest, :MultiJson, :ERB, :StringScanner, :ScanError, :CGI, :DateTime

RSpec shows a warning about them (telling user to include 'rspec' first, or whitelist these symbols)

RSpec hooks into 'require', recording changes (in $" and Object.constants)

All constants that appeared from files not in given gem (e.g. erb.rb is not a file in simplecov gem) are removed

Files are marked for reloading:
$".delete_if {|file| file =~ /erb.rb$/} # for every file associated with above constants

RSpec executes specs, which 'require' files as if for the first time

RSpec re-requires files if necessary after tests

NOTES: I got the above working as a proof of concept on the example. I got just the "uninitialized constant" (ERB) and only that error (simplecov works also, even though it uses at_exit).
Using constants+their files alone solves the issue. Additionally this helps keep every *.rb file self sufficient in its requires, even for basic things, like 'datetime', 'fileutils', 'yaml', etc. This is especially important on gem upgrades, where dependencies are removed
Let me know if this is work working on and if there could be any major issues (e.g. performance with constant reloading, accessing Object methods, 'require' monitoring overhead, Ruby 1.8 compatibility, brittleness, etc).

@e2: I can certainly see how someone could find this useful, but I would actually not want this behavior.  I have, at times, purposefully loaded something before rspec (using ruby's -r command line option).  I wouldn't want RSpec to warn me about what I'm doing.  Furthermore, I think the approach you've outlined, while it sounds like it would work fine for most gems, has a lot of potential for problems.  You're making the assumption that gems can safely be re-required.  This isn't always the case.  If they just define some classes and modules its fine, but if they hook into other things (and setup callbacks, or whatever) you've got the potential to create issues, such as callbacks that get called twice.  I'm also concerned about the potential performance hit this could cause (particularly for item 4 above--RSpec would have to use rubygems to figure out where to look for a gem's files, and then it would have to read all the files to look for the presence/absence of particular constants).  Overall, it sounds like a lot of complexity (and future maintenance cost) for something that I don't think RSpec should be responsible for.
That said--I can definitely see how people would find this useful.  Would you want to build this as a separate gem?  We can certainly discuss any extension points you need in RSpec to make this doable as a separate gem.

Agreed with @myronmarston's perspective on this. Some people might find it useful, but it would require implicit management of things that would surely be brittle. Closing this, however feel free to comment here if there are any extension points that you'd need to support doing this as an external gem.


ect

Do you want to request a feature or report a bug?
(If this is a usage question, please do not post it here—post it on Stack Overflow instead. If this is not a “feature” or a “bug”, or the phrase “How do I...?” applies, then it's probably a usage question.)
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.
What is the expected behavior?
Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?

Sorry, this was created by mistake...


How to operate the fifth and sixth steps

hello，
If you already have Go and Git installed and available in PATH uncomment set MSYS2_PATH_TYPE=inherit line in msys2_shell.cmd located in MSYS2 installation folder
Otherwise run pacman -S mingw-w64-x86_64-go git
Run MSYS2 MinGW 64-bit shell from Start menu to compile and use go-face

Hello, when running, error, system error, how to solve it?
This program cannot be started because the computer is missing libcblas.dll. Try to reinstall the program to resolve this issue.

Microsoft Windows [VERSION 6.1.7601]
Windows 7 64-bit Ultimate

Hi. I haven't tried to compile with GoLand on Windows.

Hope you get this working. Comment if something doesn't work for you with MinGW method.


@apply rule warning

I get this warning from webpacker server in Rails environment
"You are using @apply rule and custom property sets. This feature won't be included in next the major release of postcss-next. This most likely won't get any more support from browser vendors as the spec is yet considered deprecated and alternative solutions are being discussed. "
Is there any other alternative to export classes in case @apply gets deprecated?

It sounds like you are running postcss-next before Tailwind; can you share your .postcssrc file or wherever it is that you setup your PostCSS plugins with Rails? Try moving postcss-next after Tailwind, I bet that will clear this warning.
postcss-next has its own version of @apply (which Tailwind is compatible with) and that version is eventually being removed from postcss-next. That won't affect @apply in Tailwind at all though; that will continue to work forever.

thanks so much, good to know
here is my .postcssrc file
'plugins:
postcss-import: {}
postcss-cssnext: {}
tailwindcss: 'app/javascript/css/tailwind.js'
'

Got it! Yeah so change it to this:
plugins:
  postcss-import: {}
  tailwindcss: 'app/javascript/css/tailwind.js'
  postcss-cssnext: {}

...and I bet that error will disappear unless you are using the postcss-next form of @apply in addition to how Tailwind uses it, ie:
@apply --some-custom-ruleset; // postcss-next
@apply .some-class; // Tailwind

yeap, that solves it, the error disappeared!


Link to CLI doc needs to be updated

Hi Team,
The link to the reference doc for az network vnet peering create is not updated:

https://learn.microsoft.com/en-us/cli/azure/network/vnet/peering#az-network-vnet-peering-create
Regards,
Hussein

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e6754f86-e867-36a8-ad76-26ef330f5c28
Version Independent ID: 2542c6dd-cece-3fce-8738-02c43f6496f4
Content: az network vnet peering
Content Source: latest/docs-ref-autogen/network/vnet/peering.yml
Service: virtual-network
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@necusjz for awareness


outputs from modules or remote state

I can see lots of post on this but for the life of me, I cannot find an example of how to do this.  I appreciate that tfvars files cannot interpolate, so how exactly can I combine .tf files with remote state values with tfvars and terragrunt?  Ideally, I would like to just use outputs from other modules but doesn't seem possible to do so with Terragrunt?
I have tried the following to build a security group (already done)and then attach to new EC2 instance.
terraform.tfvars
terragrunt = {
  remote_state {
...
    }
  }

  # Include all settings from the root terraform.tfvars file
  include = {
    path = "${find_in_parent_folders("region.tfvars")}"
  }

  terraform {
    source = "terraform-aws-modules/terraform-aws-ec2-instance"

    extra_arguments "-var-file" {
      commands = ["${get_terraform_commands_that_need_vars()}"]

      optional_var_files = [
        "${get_tfvars_dir()}/${find_in_parent_folders("region.tfvars", "ignore")}",
      ]
    }
  }
}

...

vpc_security_group_ids = ["${data.terraform_remote_state.sec_grp.this_security_group_id}"]

backend.tf
terraform {
  backend "s3" {}
}

data "terraform_remote_state" "sec_grp" {
  backend = "s3"
  config {
    bucket = "bucket"
    key = "sec_grp.tfstate"
    region = "eu-west-1"
  }

}

With this, I get the following error

[terragrunt] 2019/05/16 12:53:27 Invalid interpolation syntax. Expected syntax of the form '${function_name()}', but got '${data.terraform_remote_state.sec_grp.this_security_group_id}'

Any help would be so awesome, thank you!

Put the terraform_remote_state in your Terraform code (.tf), not your .tfvars files.

Closing as stale. In addition to the comment above, there is also now dependency blocks, with an example documented here. If there are any follow up questions, please file a new issue. Thanks!


Use gdrive as library

Is it possible to use gdrive as a library and then write programs with the library? Thank you!

Currently gdrive is not provided as a library in an officially supported way. Might be considered if enough people requests it.
Unofficially you can download the source and use the functions from there.


feat: Add undo/redo for design page

Description

now undo/redo steps:

editor update dialog
add commit in shell's saveData api
check if the assets changes
add snapshot to undo stack

change some async functions to sync:

now all lg template and lu intent apis in shell are synchronous.
commitChanges will batch all changes before commit. If there are some async functions, we need to find all of them and await. but it's easy to use if the apis are synchronous.

Task Item
closes #3779
closes #3400
closes #2212
closes #1451

Screenshots

Coverage increased (+0.2%) to 57.359% when pulling 84e9c7ad8b161c4ef9325f4cb08037011a59cf88 on lei9444:undo into e157b0f498f6c6e648ab7e16dbf4881a6bee7d10 on microsoft:main.

undo the inline lg editor, the data is changed but the content in editor doesn't update.

@lei9444 saving the partial atoms in the stack is good with me as the storing the difference in object and combining them on each undo/redo seems a lot more complex. I'm good with these changes. Can you make sure the electron installer works fine with this branch before we merge it in main.

I verified lg/lu assets change, looks good.

@lei9444 saving the partial atoms in the stack is good with me as the storing the difference in object and combining them on each undo/redo seems a lot more complex. I'm good with these changes. Can you make sure the electron installer works fine with this branch before we merge it in main.

Hi, @srinaath, I tested the undo/redo in electron app

undo the inline lg editor, the data changes but the content in editor doesn't update.

fix this issue: use key to force update the property editor when undo and redo


add more options and delete deprecated vivid option

This PR will:

remove the deprecated vivid option
add new options for

clickable --dirty
clickable desktop --nvidia (fix #5 )
clickable review
clickable update
clickable custom command (parameters to be set in settings)

I did close this PR and republished this plugin myself. Please see atom-clickable-plugin


add Elon Musk tribute page on project folder

Issue reference:
Proposed changes:
Type of change:
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Other (please specify)
[ ] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Additional info (if any):

Tribute Page


Gray Pop-up labels and drop downs get in the way

At the beginning of the game especially, the gray pop-up tutorial labels get in the way of performing the action, often blocking access to a required point or causing a person to create additional line segments, lines, etc. The drop downs on the tool also often cover important points. Can both of these be relegated to a separate box outside the working field (perhaps off to the right or below the main working box)? This would greatly declutter the work space.

I feel the same, they get in the way often.

I came here to report this, please fix!

I came here to report this as well. This problem makes the game unplayable for me. Is it going to be fixed?

Hi all, I'm going to make a new version of euclid the game in the summer,
that will work on android, iOS and in the browser of course. I think this
is a geogebra issue, that I'm not able to fix. The new version will
probably be done around september. The new version will not use geogebra,
so that I have more freedom to make the game exactly as I want.
I have made an iOS version in augustus last year (together with David
Hallgren), but I was too busy with school to finish it and get in the
appstore. Probably, this version will get in the appstore, around july.
This iOS version is absolutely, a 300% improvement of the webgame, with
tutorials and hints, achievements and more. And won't have silly bugs like
this.
2015-05-19 22:37 GMT+02:00 maxwellsdemon137<EMAIL_ADDRESS>
I came here to report this as well. This problem makes the game unplayable
for me. Is it going to be fixed?
—
Reply to this email directly or view it on GitHub
https://github.com/kasperpeulen/euclidthegame/issues/331#issuecomment-103661436
.

--
Kasper

Thank you!
Sent from my iPhone 7.
On 19 May 2015 at 16:03, Kasper Peulen<EMAIL_ADDRESS>wrote:

Hi all, I'm going to make a new version of euclid the game in the summer,
that will work on android, iOS and in the browser of course. I think this
is a geogebra issue, that I'm not able to fix. The new version will
probably be done around september. The new version will not use geogebra,
so that I have more freedom to make the game exactly as I want.
I have made an iOS version in augustus last year (together with David
Hallgren), but I was too busy with school to finish it and get in the
appstore. Probably, this version will get in the appstore, around july.
This iOS version is absolutely, a 300% improvement of the webgame, with
tutorials and hints, achievements and more. And won't have silly bugs like
this.
2015-05-19 22:37 GMT+02:00 maxwellsdemon137<EMAIL_ADDRESS>
I came here to report this as well. This problem makes the game
unplayable
for me. Is it going to be fixed?
—
Reply to this email directly or view it on GitHub
<
https://github.com/kasperpeulen/euclidthegame/issues/331#issuecomment-103661436
.

--
Kasper
—
Reply to this email directly or view it on GitHub
https://github.com/kasperpeulen/euclidthegame/issues/331#issuecomment-103666898
.

Fantastic! Can't wait. Terrific work.
Sent from Android
On May 19, 2015 5:03 PM, "Kasper Peulen"<EMAIL_ADDRESS>wrote:

Hi all, I'm going to make a new version of euclid the game in the summer,
that will work on android, iOS and in the browser of course. I think this
is a geogebra issue, that I'm not able to fix. The new version will
probably be done around september. The new version will not use geogebra,
so that I have more freedom to make the game exactly as I want.
I have made an iOS version in augustus last year (together with David
Hallgren), but I was too busy with school to finish it and get in the
appstore. Probably, this version will get in the appstore, around july.
This iOS version is absolutely, a 300% improvement of the webgame, with
tutorials and hints, achievements and more. And won't have silly bugs like
this.
2015-05-19 22:37 GMT+02:00 maxwellsdemon137<EMAIL_ADDRESS>
I came here to report this as well. This problem makes the game
unplayable
for me. Is it going to be fixed?
--
Reply to this email directly or view it on GitHub
<
https://github.com/kasperpeulen/euclidthegame/issues/331#issuecomment-103661436
.

--
Kasper
--
Reply to this email directly or view it on GitHub
https://github.com/kasperpeulen/euclidthegame/issues/331#issuecomment-103666898
.

Came here to report this, but now I'm just very happy to hear the news about the development.
Thanks!

@leftysrevenge @orrp @sambolic
see this facebook post for more details:
https://www.facebook.com/euclidthegame

Thank you!
Sent from my iPhone 7.
On 16 August 2015 at 11:55, Kasper Peulen<EMAIL_ADDRESS>wrote:

@leftysrevenge https://github.com/leftysrevenge @orrp
https://github.com/orrp @sambolic https://github.com/sambolic
see this facebook post for more details:
https://www.facebook.com/euclidthegame
—
Reply to this email directly or view it on GitHub
https://github.com/kasperpeulen/euclidthegame/issues/331#issuecomment-131581670
.


Quastion

Is it possible to run code on CPU?
I have tried and got next error
RuntimeError: Input type (torch.cuda.FloatTensor) and weight type (torch.FloatTensor) should be the same

Try to place input on CPU as well.


add_event: add "links", add "location", add "tags", keep "link" to maintain backwards compatibility

wasn't able to test, but should be harmless enough since all the fields are non-required

In the future, please push to develop first so that we don't accidentally break anything. Better safe than sorry!


move text and video on landing page next to each other

Looks good on desktop. Could you make it mobile responsive?

very cool


Configure archive command in Makefile to product for both arm64 and x86_64

$ lipo -archs plank
x86_64 arm64


Repository to build tabrisjs2 demo app

Hi,
I've been looking around the website, but am unable to figure out which repository builds the app at https://play.google.com/store/apps/details?id=com.eclipsesource.tabrisjs2 -- eg: via forking that git repo and running a build on your build service.
I want to add a couple of cordova plugins (SMS send/read) and rebuild it, so as to be able to write scripts which can utilize those functionality. Can you please point me to the repository?

You don't need to fork any repo; just set up the Tabris cli and build your app.  If you're interested in the source code behind the examples, they can be seen in the app by tappin the file icon next to the example's name and also in this repo in the examples dir.

I meant to say I want to use the functionality of the above linked app (like remotely loading scripts/github etc), except additionally also include a couple of cordova plugins, so I can use SMS functionality in the scripts as well. i understand I can write from scratch via CLI, but I'd rather use the tabrisjs2 app as the starting point. Is the source code of that app not available?

After adding the plugins, when you build the app, you have the option to build a debug version of the app and to include the developer console.  Just add the EnableDeveloperConsole flag to your config.xml.  The debug version of the app will include the same menu:

A the top, you can enter the URL to your development machine (the output from tabris serve).  You can then make changes to the source code on your machine and hit the reload button and it will reload the code from your development machine.  And you still have the console at the bottom to interact with the app.

@bmn86 The source code of the Tabris.js 2 app is not yet public, sorry. Is there anything specific you're looking for in the source code? I could help you out with a snippet.

@ralfstx is it possible to see how looks the cordova config show for Tabris.js 2 app? (including splash resolutions, logo dimensions and any other tweaks in .xml)?


exclude null values from payload

[To be manually tested]
Created as resolution of https://github.com/mailjet/laravel-mailjet/issues/1 .

You can create a release version 1.0.4 and in all project, they just need to composer update mailjet/mailjet-swiftmailer to fix their issues with Null value ;)

LGTM


Pretty-format JSON configs in app directory

Currently config_dir.jsons are created as single line files. They can be pretty-formatted manually for better readability and maintenance after bootstrapping, but having them that way from the beginning would be a nice enhancement.

hi @vadimgusev-codefresh has this been taken up ? or shall i take it?

@vadimgusev-codefresh @krishnaduttPanchagnula
the config.json and config_dir.json files created when adding new applications are already formatted correctly since v0.3.2
the only json file that is being written without indentation is the cluster config file, and it just contains two fields, so i think that's not too bad:
{"name":"in-cluster","server":"https://kubernetes.default.svc"}


Question: How to bring references into scope?

Hi,
I have a problem: I'm trying to use rhai to implement a filter type for my imag library, but I fail to bring an object into scope which I have as reference. Here's the codebase: https://github.com/matthiasbeyer/imag/pull/371/files
Note that the Filter trait provides a function filter which gets a &Entry. I need to bring this reference into scope of rhai, but I fail to do so. As you can see I added a wrapper type, but it doesn't help.
Maybe you have an idea?

Rhai currently has a few limitations around what argument types it can handle, so it ends up using a few conventions.
One of these conventions is that to make a method, the first parameter has to be '&mut self' rather than '&self'.  I'd like to remove this restriction in the future, if possible.

Yes, this would be a really nice enhancement I guess, as it would solve my issue here.

Took some time today to look into this one a bit more.  It sounds like it may take a while, unless I to find a new trick.  The current approach appears to require impl specialization (https://github.com/rust-lang/rfcs/pull/1210) to finish landing and become widely available in order to support the &T in addition to T and &mut T.

Not quite.  It is possible, but you have to specify the exact trait:
RegisterFn::<_, (Ref<TestStruct>,), INT>::register_fn(
        &mut engine, "action", |obj: &TestStruct| obj.x,
);


Drag and Drop to add Files in File Manager No Longer Works

I suspect this is related to our dropzone updates and our attempt to use the same library between dropzone and jQuery file upload, but it is no longer possible to drag and drop a file into the file manager. It simply loads the file in the browser. You can add files by clicking on the add file link, and dragging and dropping into the dropzone works, but the workflow of dragging and dropping into the overall fie manager window is totally broken now.

Well, it's working for me...

This is in the front end file manager fwiw, and also in safari although I don’t know if that’s relevant. I tested this morning using the image slider block

Here's what I'm seeing:

If you wait a second or two before releasing the mouse button  do you see the dropzone dialog?

Since some time, we became to have to wait seconds before uploading. I don't know why

@mlocati so what is happening is previously when you dragged and dropped on to the file manager it added them to the dropzone box, after the window loaded.
Now you must wait for the dropzone box and if you drag any where except the drag box it redirects to the image.

previously when you dragged and dropped on to the file manager it added them to the dropzone box

Nope: before #7314 got merged, files dropped in the file manager window were uploaded using the jQuery File Upload Plugin (see #7305).
Since #7314 got merged, we now have just one tool that handles file uploads.
The problem now is that we have to wait that the dropzone dialog opens before actually dropping files into the file manager window.
In order to solve this issue, we can preload the dropzone dialog, so that it can be displayed immediately.

What about #7921 ?

I also find this a usability defect comparing to the old versions. I believe the dialog also works in the front end managed but you have to wait and hit the dialog.
Before it was possible to drop the file anywhere in the file manager, there was zero chance of missing the drop target. Now you have to specifically hit the drop area inside the dialog which can be hidden e.g. behind the window where you are dragging the file from.
I would much prefer reverting to the old method. This could be done simply by getting rid of the default dialog layout for the dropzone and just extending the drop area to 100% of the file manager screen when a file is dragged on top of the window.

#7921 fixes the delay.
Of course we can inspect ways to extend the dropzone to the whole page.

+1 for extending the dropzone to the entire page. We have been getting a lot of reports from users stating the file manager is broken. I believe the couple second delay waiting for the drop zone is the biggest issue.
Once we explain to users to wait a couple of seconds for the drop zone to show up all is good but it still takes some getting used to and is pretty easy to forget especially if you have been using the file manager for the past several years.

+1 to extending the dropzone as well. The proposed solution in 7921 is clever, but I think it might make things more complicated.

This still an issue?

Nope! Thanks


API suggestion for symmetric conventions

As much as I love the power symmetric conventions provide I think their difference makes them confusing. For example I love ClassTypeHasSpecificNamespace but it's the only convention that takes a type filtering predicate.
I think it would be more consistent if we removed classType and classIsApplicable from constructor. We could have a SymmerticConvention class much like the Convention class with an Is method and also an ISymmetricConvention for Convention where the Execute method accepts a preciate in addition to those required by Execute in IConvention. SymmetricConvention could then accept a predicate required for symmetric logic which is passed into the Execute method.
Thoughts?

I am writing a symmetric convention for Shouldly, we have Should.Throw static methods and now .ShouldThrow extension methods. All overloads should match.
This is what it ended up looking like. https://github.com/shouldly/shouldly/pull/252/files#diff-eb10efae6035000b7610595c5b728ddeR23
Thoughts?


Restore run above/below commands

For #5746

Was the original removal of these command from the command palette a PM ask?

I didn't think so.
Also would be inconsistent and would be an accessibility issue.
Today we have all cell related commands in comman palette (run cell, run all cells, copy/delete cells, etc), hence I think this should be there as well.

Codecov Report

Merging #5856 (5519255) into main (1f0a599) will increase coverage by 8%.
The diff coverage is 15%.

@@           Coverage Diff           @@
##            main   #5856     +/-   ##
=======================================
+ Coverage     63%     72%     +8%
=======================================
  Files        403     403
  Lines      26953   26973     +20
  Branches    3933    3941      +8
=======================================
+ Hits       17047   19454   +2407
+ Misses      8495    5886   -2609
- Partials    1411    1633    +222

Impacted Files
Coverage Δ

...e/interactive-ipynb/nativeEditorCommandListener.ts
41% <15%> (+12%)
:arrow_up:

src/client/startupTelemetry.ts
29% <0%> (-26%)
:arrow_down:

src/client/extension.ts
57% <0%> (-11%)
:arrow_down:

src/client/common/process/pythonDaemonPool.ts
75% <0%> (-2%)
:arrow_down:

...active-common/intellisense/intellisenseProvider.ts
74% <0%> (+<1%)
:arrow_up:

...ient/datascience/editor-integration/codewatcher.ts
69% <0%> (+<1%)
:arrow_up:

src/client/datascience/baseJupyterSession.ts
70% <0%> (+<1%)
:arrow_up:

...ce/raw-kernel/liveshare/hostRawNotebookProvider.ts
65% <0%> (+<1%)
:arrow_up:

...nt/datascience/kernel-launcher/kernelDaemonPool.ts
88% <0%> (+<1%)
:arrow_up:

src/client/common/configSettings.ts
90% <0%> (+1%)
:arrow_up:

... and 139 more


Adding linebreak stripping

Adds --strip-newlines which collapses single newlines into a space - effectively what would happen during normal HTML rendering.  This is to address Confluence's behavior, which is to insert a <br>.
Closes #92

Thanks for the contribution! I've added a couple of comments to it.

Thanks for the feature @nyarly ! While I have you here and you probably also looked a bit deeper into goldmark, any thoughts on how to solve https://github.com/kovetskiy/mark/issues/324 ?


Please include all the financial information for NSE (Indian stocks ) too

I am not able to fetch the Indian stocks financial data (fiancials, earning, cashflow etc). Please include them too.

I am going to post it here since my question is similar to @kumarrahulicfai This is a NSE security.
I tried the following code:
import yfinance as yf
stock = 'ACC.NS'
pg = yf.Ticker(stock)

print("Short Name: " + pg.info['shortName'])
print("Long Name: " + pg.info['longName'])

It is not fetching even the name of security.  Is there a work around? I am getting an error:
IndexError: list index out of range

Hey there, try applying the fixes described in PR #179.
Just be aware that that fix returns inconsistent data for non-US tickers.