Remove the convenience initializers on generated messages

The generated convenience initializers that take default values are a great idea in theory, because they let users quickly create a message using whatever combination of fields they wish to initialize. However, they come with a hidden but large performance cost.
Default function arguments in Swift are implemented by creating a small shim for each argument, which loads the default value onto the stack. When such a function is called, these shims are called for any argument not provided by the user, and then the function body is executed.
This implies two things:

Code is generated for each default argument, increasing the binary size
Calling a function with N arguments that have defaults incurs the execution cost of loading all of the arguments, even if only one is provided.

In other words, if you have a message with 100 fields, you generate 100 shims for those default arguments; but worse, the execution cost of initializing the message with one argument is the same as the cost of initializing it with all 100 arguments. Even in release mode with heavy optimization, this cannot be avoided; see this gist for a snippet of the Hopper disassembly of a 100-field message where only field89: 0x600b34 was passed in.
We can also look at the binary size effects of these initializers, using our performance harness:

With convenience init
Without convenience init

Harness size, bytes (before stripping)
415,544
250,352

Harness size, bytes (after stripping)
152,992
144,536

Runtime .dylib size (release)
3,044,060
3,012,252

Since the runtime .dylib size includes the well-known types, there's an effect there as well. The difference in harness size is very stark before stripping (a 165KB savings by removing one initializer!), but in that case, stripping eliminated much of the overhead.
Proposed alternative
Being able to create a message with values at initialization time has its benefits; maybe you want to create one inline when you call another function to avoid a temporary variable, or you want to keep your variables immutable whenever possible and having to set properties after initialization time prevents that.
This is a topic that's been debated frequently on swift-evolution, because this isn't a protobuf-specific problem; indeed, all value types are affected. A very well-received alternative is to create a helper function that creates the value and takes a closure where initialization is performed. Unlike Swift value types in general, all of our protos conform to a common protocol, so we can provide such a helper easily across the board:
extension ProtobufMessage {
  public static func with(initializer: (inout Self) -> ()) -> Self {
    var message = Self()
    initializer(&message)
    return message
  }
}

Then, at the usage site, you can do:
let foo = My_Generated_Message.with {
  $0.bar = 5
  $0.baz = "quux"
}

// Or one-liners, if you prefer:
let foo = My_Generated_Message.with { $0.florp = "blorp" }

Granted, it's not quite as beautiful as argument list syntax, but this version incurs an execution cost relative only to the number of properties explicitly being set.

Thanks for the detailed write-up.  To be clear, you're talking about a 1% size change in the Runtime .dylib size and a 5% difference in the (post-stripping) harness size.
I think I agree with you, but I'd like to sleep on it first.

A more realistic test would be to add multiple messages and see how much it changes based on message count. @thomasvl and I have been chatting about adding a case to the perf harness that generates something akin to TestAllTypes, to test "more realistic" scenarios, along with multiple message support.
I'd still argue that bigger savings w.r.t. non-stripped builds is worth it, especially with stark differences as these, as it decreases the pain for local development/testing builds.

Upon further reflection, I realize that my conclusion about execution cost was a little too dire. I was focusing on the fact that the parameterized initializer assigns a value to each field, but forgetting that the default initializer does that as well, just implicitly; and even for zeros/nils, an explicit move instruction is still generated (especially for .none-valued optionals, because those are actually stored with a non-zero bit-pattern because of the way two-case enums with one payload are represented). So maybe that part isn't as critical now.
I still worry about the binary size changes with many messages and potential effects on compile time, though. We sometimes deal in messages that have hundreds of fields, so that's still a cause for concern.

(Apologies for the multi-post, I'm thinking very asynchronously tonight.)
Another design concern that just occurred to me: as the number of fields increases, a large initializer with default values has diminishing returns, because the arguments must be passed in the order that they are listed. So for a complex message, you have to be aware of that ordering. The with pattern, being more like a builder, doesn't suffer from this.
I definitely wish there was a clearer winner here that balanced all of these concerns.

Random late night thoughts –
While some what arbitrary, does it make any sense to only provide some of the fields to init?  Say basic types (numerics, strings, bytes (could even leave those off)) and messages; but not provides it for repeated fields and maps?
I was going to ask about taking your comment about number of args and order making large numbers not as useful, and suggest we only do it if there are say 6 or less fields; but that means if a proto gets a new field in the future, it could suddenly break code because it would stop getting an init.

Actually, I think you stumbled on another reason to remove these…
You mentioned the order is important.  Within a .proto file itself, order does not matter.  As a message definition evolves with a service/app/etc., developers are free to add fields anywhere, grouping things as they see fit. All that matters is the field never change, new ones are just added; not the order within the file.  No matter what order we pick (file order or field number order), when the message definition evolves, a new generation of source files could break developers code because the order to init could change.
So it may be safer to provide with(initializer:) and/or encourage developers to write their own extensions to add initializers their code needs rather than trying to provide them and have them be fragile in the fact of message evolution.

For what it's worth, the client libraries we're generating on top of gRPC, for other languages, can already be configured so users making an RPC don't have to explicitly create the request proto. For that, overloaded functions (for the specific service method) are generated with some of the fields as parameters. Field selection is tricky, due to the evolution problems you mentioned. Our solution is feeding a config file to our generator, which IMO would be too much trouble to do here.

Swift extensions make it easy for people to add their own convenience initializers if they want, so I'm happy switching to the .with {...} syntax now.

Actually, I think you stumbled on another reason to remove these…
You mentioned the order is important. Within a .proto file itself, order does not matter. As a message definition evolves with a service/app/etc., developers are free to add fields anywhere, grouping things as they see fit. All that matters is the field never change, new ones are just added; not the order within the file. No matter what order we pick (file order or field number order), when the message definition evolves, a new generation of source files could break developers code because the order to init could change.
So it may be safer to provide with(initializer:) and/or encourage developers to write their own extensions to add initializers their code needs rather than trying to provide them and have them be fragile in the fact of message evolution.

Does ordering matter if all the all the initializer parameters have defaults and they are sorted?


Nonverify start page should be more like contravel nonverify start page

The nonverify start page content needs changing to accomodate the fact the user has already seen a start page by this point

@sanjaypoyzer Does this look ok?
# Apply for a resident's parking permit without using GOV.UK Verify
You can still apply online for a parking permit, but you'll need to scan and upload some documents.
To apply online you will need to provide:

Proof of address, such as a council tax bill or a recent utility bill or a tenancy agreement or a mortgage statement

You'll need to scan in and upload these documents, and we'll check them after your application.


feat(planning_debug_tools): add height and yaw to analyze

Signed-off-by: taikitanaka3<EMAIL_ADDRESS>Description
add yaw and height to planning debug tools
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

already merged at another PR


PerformInteraction parameter min array size is 0

MOBILE_API.xml - The PerformInteraction command has an array field interactionChoiceSetIDList which has the min array size set to 0.  Other arrays require a minimum length of 1, not 0.

Same issue for ScrollableMessage softButtons parameter.

Same issue for ScrollableMessage softButtons parameter.

Should be a separate issue, so that it can be tracked and fixed separately, or a more general issue title should be created.

Outdated


Slow performance when calling getMap().then(function(){}); but not getMap();

From @facultymatt on September 26, 2014 3:8
I'm tracking down a performance critter. I use $interval to constantly center the map. Seems that getMap().then(function() {}) causes a performance hit while getMap() does not. The code is below.
function centerOnTrip(data, mapName) {
      if(!data) {
        return;
      };
      leafletData.getMap(mapName).then(function doCenter(map) {
        console.timeEnd('get map');
      });
}

Copied from original issue: tombatossals/angular-leaflet-directive#483

From @facultymatt on September 26, 2014 3:53
This is likely related to https://github.com/tombatossals/angular-leaflet-directive/issues/424
I tried removing the ID and removing all other maps on the page and the performance bug appeared gone...

@facultymatt is this still an issue? If so can you make an example?


Allow Reindex (and workflows?) from the validation page

Often, you'd like to run a reindex or common workflow on a number of items with  the same error or warning, Perhaps allow these directly on the validation page?

See comment on https://github.com/ucd-library/fin/issues/86 about showing reindex on this page.  Workflows can currently be reindex in bulk by using CLI.


add change predication for all controllers

Description of your changes

Fixes #1572
I have:

[x] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@muvaf any chance to check this change ? or is this something for the runtime ?

@haarchri @muvaf any progressing?

@liubog2008 Please update this PR with more information around how this fixes the issue.
I tend to agree with @haarchri that it may make sense to try fix this in crossplane-runtime rather than updating every controller in every provider manually.

I have this forked and built into v0.30.1
Here is my result (metric is in request per second to the aws api)

This type of problem can cost a company THOUSANDS of dollars a month in AWS billing as Cloudtrail is very un-forgiving. Even with this fix i would argue that the back-off is not high enough, i still see too many api calls.

I'm not sure updating every controller in every provider is the way to go. We might want to add something to crossplane-runtime to help.
LGTM, my fix is not elegant. I think a new For function is more reasonable.

Closing in favor of https://github.com/crossplane-contrib/provider-aws/pull/1705


Create users and repos tables

We should create a repos table with a name column. We need this so later in #9 we can store the default branch. And then, in #10, we can store the URL to the default branch — instead of the commit.
In this ticket we could also create a users table with a name column – but this is optional.
At the moment:

repos' name is stored in notebooks.github_repo_name.
users' username is stored in notebooks.github_owner_login.

Besides creating the table repos — and maybe users, we'll need to update Populate.populate/1. This should create or update repos when we download new livemd files from Github every day

@HassanRSiddiqi and I started to work on this in a pair programming session. He's finishing it.


Button implemented with useButton() can't be used to open a Menu

Provide a general summary of the issue here
I've created a Button using the useButton() hook, but I can't open a Menu (can't use it as a MenuTrigger) since:
PressResponder.mjs:33 A PressResponder was rendered without a pressable child. Either call the usePress hook, or wrap your DOM node with <Pressable> component.

Button taken from the docs:
import {useButton} from 'react-aria';
import {useRef} from 'react';

function Button(props) {
  let ref = useRef<HTMLButtonElement | null>(null);
  let { buttonProps } = useButton(props, ref);
  let { children } = props;

  return (
    <button {...buttonProps} ref={ref}>
      {children}
    </button>
  );
}

and used in a Menu also taken from the docs:
import {Menu, MenuItem, MenuTrigger, Popover} from 'react-aria-components';

<MenuTrigger>
  <Button aria-label="Menu">☰</Button>
  <Popover>
    <Menu>
      <MenuItem onAction={() => alert('open')}>Open</MenuItem>
      <MenuItem onAction={() => alert('rename')}>Rename…</MenuItem>
      <MenuItem onAction={() => alert('duplicate')}>Duplicate</MenuItem>
      <MenuItem onAction={() => alert('share')}>Share…</MenuItem>
      <MenuItem onAction={() => alert('delete')}>Delete…</MenuItem>
    </Menu>
  </Popover>
</MenuTrigger>

🤔 Expected Behavior?
The Button should implement Pressable since under the hood useButton() is using usePress().
😯 Current Behavior
PressResponder.mjs:33 A PressResponder was rendered without a pressable child. Either call the usePress hook, or wrap your DOM node with  component.
💁 Possible Solution
Not sure why this is happening? What am I missing?
using a Button from react-aria-components works just fine.
🔦 Context
No response
🖥 Steps to Reproduce
import React from 'react';
import { useRef } from 'react';
import { useButton } from 'react-aria';
import { Menu, MenuItem, MenuTrigger, Popover } from 'react-aria-components';

function Button(props) {
  let ref = useRef<HTMLButtonElement | null>(null);
  let { buttonProps } = useButton(props, ref);
  let { children } = props;

  return (
    <button {...buttonProps} ref={ref}>
      {children}
    </button>
  );
}

const TestMenu = () => (
  <MenuTrigger>
    <Button aria-label="Menu">☰</Button>
    <Popover>
      <Menu>
        <MenuItem onAction={() => alert('open')}>Open</MenuItem>
        <MenuItem onAction={() => alert('rename')}>Rename…</MenuItem>
        <MenuItem onAction={() => alert('duplicate')}>Duplicate</MenuItem>
        <MenuItem onAction={() => alert('share')}>Share…</MenuItem>
        <MenuItem onAction={() => alert('delete')}>Delete…</MenuItem>
      </Menu>
    </Popover>
  </MenuTrigger>
);

Version
"react-aria": "3.24.0", "react-aria-components": "1.2.0"

What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
macOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Thanks for the issue, have you already gone through https://github.com/adobe/react-spectrum/issues/5647 ?
Have you checked for duplicate packages? This script can help with that check: https://gist.github.com/jluyau/9024db3527788030312332075745469b

Thanks for the issue, have you already gone through #5647 ? Have you checked for duplicate packages? This script can help with that check: https://gist.github.com/jluyau/9024db3527788030312332075745469b

Thanks for a quick reply. I've ran through the issue, but I didn't initially connect that this was a possible approach to address the problem. I'll make an edit after I do.

Everything works as intended now, thanks!


Add S3 Storage Support

This PR adds a minio S3 Compatibale Storage backend to deepforge. (Depends on (#1403))

Currently, all the operations in S3Client rely on generating public presigned URLs. We need to change this to use config and regenerate the presigned URL.

Closing this PR in favor of using a aws-sdk JS/node client instead of writing a custom router.


APPS-1166 cwl jobReuse

TODO: need to fix the JSON lookup: the id of the target task might appear multiple times. Need to use full id instead.


Publish DC-0 output maps to the portal

we should put the outputs of DC-0 on the portal with some urgency because we want to use it as method of delivery to the working groups as part of the Data Challenge process.
We have simulations of Chile LAT and South Pole SAT available, but they are too large, we need to decide what subset we want to publish to the portal.
CHLAT maps size, total 6.4T
104G    split01
208G    split02
415G    split04
829G    split08
1.7T    split16
3.3T    split32

The SAT maps are very small, so no problem with those.
@smsimon do you know what the working groups are expecting, can we just do split01 and split02? We currently have 1 TB storage total at UCSD.

Naming schema is explained here:
https://docs.google.com/document/d/1VIQYsGMza9rOn3E0GY1hDpzLN4hcR7Fwm7tpXGUxSlY/edit?usp=sharing
For each split and frequency we have:

all the individual components
the full map c1111
the depth map (map03)
the white noise covariance matrix

zonca@login33 025 $ pwd -P
/global/cfs/cdirs/cmbs4/dc/dc0/mission/chlat/split01/025
zonca@login33 025 $ ls -lah
total 18G
drwxr-x--- 2 keskital cmbs4 4.0K Aug 24 16:48 .
drwxr-x--- 8 keskital cmbs4 4.0K Aug 24 18:13 ..
-rw-r----- 1 keskital cmbs4 2.3G Aug 24 16:46 dc0_chlat_t01.01_025_map02_c0001.fits
-rw-r----- 1 keskital cmbs4 2.3G Aug 24 16:47 dc0_chlat_t01.01_025_map02_c0010.fits
-rw-r----- 1 keskital cmbs4 2.3G Aug 24 16:47 dc0_chlat_t01.01_025_map02_c0100.fits
-rw-r----- 1 keskital cmbs4 2.3G Aug 24 16:47 dc0_chlat_t01.01_025_map02_c1000.fits
-rw-r----- 1 keskital cmbs4 2.3G Aug 24 16:48 dc0_chlat_t01.01_025_map02_c1111.fits
-rw-r----- 1 keskital cmbs4 1.6G Aug 24 16:45 dc0_chlat_t01.01_025_map03.fits
-rw-r----- 1 keskital cmbs4 4.6G Aug 24 16:46 dc0_chlat_t01.01_025_mat02.fits

We should put what splits we can on the portal so your plan of putting up split01 and split02 sounds reasonable. I can contact the AWGs that need more splits to let them know where to find them.

Note: The description portion on the DC0 page also needs some minor edits:

"DC-0 is the first execution of a Data Challenge run, it has been completed only for Large Aperture Telescopes located in Chile (CHLAT), the rest of the channels are still being worked on." to

"DC-0 is the first execution of a Data Challenge run, it has been completed for the Large Aperture Telescopes located in Chile (CHLAT) and the South Pole Small-Aperture Telescopes (SATs), the SPLAT is still being worked on."

"The full documentation of the release will be published publicly, for now it is being worked on in the Github repository CMB-S4/DataChallenge0, only accessible to Github accounts members of the CMB-S4 Github organization."

This link points to the old instrument design. If we wanted to have something ready ASAP we could point to the "Technical Design to Measurement Requirements" section of the PBDR https://github.com/CMB-S4/PreliminaryBaselineDesignReport

@smsimon please feel free to edit the file directly and make a pull request to this repository with the improvements:
https://github.com/CMB-S4/serverless-data-portal-cmb-s4/blob/main/dc0.md

@rpwagner ok, the new DC-0 files finished transferring to UCSD

@smsimon new DC-0 release on the portal #25
https://data.cmb-s4.org/dc0.html

Thanks, sent to the AWGs.


[Decode] dctbl pointer check code refactor

Issue: MDP-68544
Test: manual

code review trace to https://github.com/intel-innersource/drivers.gpu.media.sdk.lib/pull/4444


modal dialog issues

does not work in bootstrap modal dialogs

same for me

confirmed... :(

I had to pick an other plugin, but really it's easy to reproduce : try to use the image zoom plugin inside a bootstrap dialog.


Losing the isDV flag and date format coming back as NA and losing the…

… approval bars. Fix for AQCU-760
https://internal.cida.usgs.gov/jira/browse/AQCU-760

Travis failing on unrelated test failures (uvhydro).


Improve text "Publish" step

Describe the improvement
Your dataset/publication is published in Biblio and sent for review to the Biblio team. You can expect a response from a Biblio reviewer within the next 4 business days.
Time to be confirmed.

Instead of the above text, use
For publications:
"Your publication is published in Biblio and sent for review to the Biblio team. The Biblio reviewer team will process your publication as soon as possible, taking into account reporting deadlines. For questions, the Biblio team can be contacted at<EMAIL_ADDRESS>For datasets:
"Your dataset is published in Biblio and sent for review by the data curator team. The data curator team will process your dataset as soon as possible, taking into account reporting deadlines. For questions, the data curator team can be contacted at<EMAIL_ADDRESS>


Searchable REPL thoughts

hey all,
I've been thinking a bit about a browsable REPL-structure and I would like to share some thoughts for the upcoming v3 and guide-overhaul.
I discover myself stumpling through unrecognizable bookmark-folders with bad named bookmarks to keep some scripts/examples/best-practises/solutions in mind.
In the meanwhile there are so much, somethimes outdated, that I have to open several to find the right one. In the best case. Most of the time, I'm not able to find what I was looking for.
Wouldn't it make sense for the saved gists to add some search or sort criteria to get/find to the examples the user needs? Kind of what is done currently with the menu.
What could be a structure that makes sense, not distracting with too much overhead or additional administration-expense?

adding a category (i.e. official, best-practise, guide, basics, animate)
adding predefined tags (i.e. need-help, solution)
adding a short description

Maybe it's just me using the REPL this way. Maybe it's too much.
But as I notice, also from the repeadetly asked questions over @discord ('how can I do this', 'xy is not working', 'why?', 'how?'), the REPL could, maybe should be one central piece to make svelte a really good dev-experience.
Just a thought.
I know v3 requires all resources.

Another part of the conversation has focused on the idea retrieving features from gists (#if, /else, class:, etc).
This would let us search by feature, similarly to what has been done in blockbuilder.

@pngwn has written this walker this Runkit example:
const svelte = require("svelte");
const walk = require("estree-walker").walk;

const compiled = svelte.compile(`

{#if condition}

boo

{:else}

Hi

{/if}

`);

function walky(ast) {
    let features = [];
    walk( ast, {
        leave: function ( node, parent ) {
  	         if (node.type) {
                features.push(node.type);
             }
             if (node.attributes) {
                node.attributes.forEach(v => features.push(v.type))
             }
        }
    });
    return features;
}

console.log(compiled);
console.log(walky(compiled.ast.html))

to show how we can retrieve features from compiled templates 😎 .

In this example:

IfBlock -> #if:
ElseBlock -> /else
Class -> class:
etc.
If the provided string was a REPL example, we could tag it with these Svele features and think about the appropriate UI to search by these features.

Another part of the conversation was about the meta.json.
Currently as said that file contains just {"svelte": true}, but in the future it might contain:

the Svelte version,
eventually the repl version (to detect files expected to contain certaion fields)
the list of features detected in the gist
gist: ID, author, etc
?

{
  "svelte": true,
  "versions": {
    "svelte": "3.0.0-alpha1",
    "repl": "1.1.1",
  "features": ["#if:", "/else", "class:", "on:click"],
  "gist": {
    "id":<PHONE_NUMBER>657,
    "author": "pngwn",
    "title": "foo bar",
    "forkof":<PHONE_NUMBER>345345,
    ...
  }
}

Again, having these fields would permit to think about an enhanced/unified search:

by author
by strings in title
by features
by Svelte version
...

There hads been some discussion about the possibility to switch Svelte version while editing the REPL, especially useful while learning hopw to upgrade to a breaking version.

Should we do this, the meta file would have to change depending on context.

We realised that if the interface let us to publish (and unpublish) gists, when a gist goes "Public" we can save its ID and its meta file somewhere.
As of now we don't expect a huge amount of gists to be published so probably we can just update a single gist with the contents of all the meta files. This would permity us to easily search by fetching that central gist and working the wsearch in the client memory without using a DB for now.
Also, since the Svelte 2 gists have a minimal meta file, we could make so that the REPL saves this additional information only for Svelte version 3 to clearly mark a line between v2 and v3.
Users would have to actrively update Svelte 3 using the REPL interface to mark (and publish) to mark an old gist as searchable.

I think we can definitely improve the REPL, especially having more examples and making discoverability easier.
Searching Gists
I'm not sure if this will work unless we default gists made via the REPL to public (which I don't really like). People should feel free to mess around on the REPL and save their gists without worrying that it will be made public. Currently, gists made via the Svelte REPL are secret and I think it should stay that way. We should have a make public or publish option that flags them as public and adds that REPL example to the 'search database' however that would be implemented. We could then search anything within this collection. A curated selection of them could make up a showcase/ demo minisite/section.
Feature Tags
I think this is a good idea, its a little more complex than the example above but it should be pretty doable. I think the returned AST gives enough information to work out what features are being used. V3 probably makes this easier because we don't have the distinction between different function/ method types (there are less anyway). We'll obviously need to walk the JS AST as well, not just the HTML, but it should be possible to add these tags automatically at/after compilation. I don't actually know how the REPL works so I'll need to look into before I can say anything for certain.
Versioning
I think this is really a matter of philosophy. I don't know if Rich wants a clean break from v2, in which case the v2 REPL should go along with the v2 Documentation and never the twain shall meet. On the other hand, we could make it so that the user can select a compiler version within the REPL itself. I don't know how difficult or desirable this would be. We should definitely store more information in the metadata.json, that will just make our lives easier in the future (even if we only support one compiler version at a time, knowing that certain gists are not compatible will be useful).
Version Switching
I'm not convinced by this. I think its a cool idea but the svelte-upgrade package has its limitations and it might be frustrating for users if they keep getting partially coverted components. Even if we spend time writing the best codemod we can come up with, there will probably be caveats and I honestly don't think it is a great use of time. After a transitional period there will be very little value in it for most people and given the significant differences between v2 and v3 it wouldn't be the simplest of tasks. We will need comparison/ upgrade examples as part of an upgrade guide but we would be better off writing or at least finishing them by hand to ensure the clearest, most idiomatic v3 code. v3 is hugely different and we will probably write our code slightly different due to the freedom the new design brings. This should be reflected in the examples we write. I think this is a better compromise. Additionally, if we choose not to have v2 and v3 REPLs in the same REPL a convert option makes little sense.
Other Thoughts
One thing I've been thinking about is having REPL examples embedded in the documentation as examples that a user can freely edit (and maybe fork and save). These kinds of experiences always seem the best to me, giving the user the ability to play with the feature being spoken about. I don't know how realistic this would be or if it is practical from a performance point of view (multiple REPLs on a page, etc., there are resolutions to this problem but it can get complex very quickly). The docs are written in markdown and I think everyone would prefer that to continue so I guess we would need a way of injecting REPLs into markdown files. The obvious solution to this is for the REPL to be a svelte component and our markdown to be MDX for svelte. How this would work, I have no idea, but I've been thinking about it a lot recently. This could also bring other benefits, we wouldn't be limited by what Markdown allowed. If we wanted to use animations or interactive examples in the docs, this would allow us to do so. This is out of the scope of this issue but I thought I would mention it.
I also think I prefer the term 'playground' to 'REPL'.

Renaming the meta file to svelte.json
Current limitations of the Gist API (no search endpoint) force us to retrieve every single gist files to parse its content, which makes us quickly incur in API limits.
One solution to this would be to rename meta.json to svelte.json so that to detect Svelte examples we would have to search gists containing a svelte.json file and inspect its content to check if it's indeed a Svelte REPL meta file.

I also think I prefer the term 'playground' to 'REPL'.

@pngwn me too

Listing and searching own gists
Once logged in, it would be quite useful to list and/or search our own gists (by title, used Svelte features, etc) directly from the REPL.
Searching a user's gists shouldn't be a heavy operation and it would be a matter of filtering those with a working svelte.json.
This functionality would help to revisit old tests and eventually turn them into public examples or delete them.
Saving a thumbnail of the rendered area
Eventually, to help the search, we might think about capturing a thumbnail of the rendered area to be shown while the searching.


kv-client(cdc): add more metrics and logs

What problem does this PR solve?
Issue Number: ref #9222
What is changed and how it works?
Add more metrics and debug logs for kv-client.
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/retest

/test cdc-integration-storage-test

/cherry-pick


nixos/openldap: refactor the openldap module to make it safer and more versatile

Motivation for this change
Changes

Run OpenLDAP in foreground
Use systemd's StateDirectory to create configuration dir (if it is the default config dir), and database dirs (if they are located under /var/lib/openldap)
Forbid setting declarativeContents for database whos directory is not under /var/lib/openldap to avoid accidentally rm -rf of the whole directory
Run both the prestart script and slapd as unprivileged user instead of root
Change the default config directory to /var/lib/openldap/slapd.d

cc @kwohlfahrt
Todos

[x] Test on my machine
[x] Fix tests

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

I still don't think it's a good idea to put the OLC database in /etc. If we really need a read-only configuration, we could just use a derivation to build it. Putting things in /etc just feels.. awkward. Afaik, the reason for most of the programs that write their configuration to /etc to do so is that they support hot reloading (which is not possible without putting the configuration file in a fixed location).

That's a good approach, can we move the current preStart script into a derivation? That sounds like it would fit the Nix-managed (i.e. readonly) use case. Then the OLC-enabled config can live in /var, and the fixed output in the NIx store.

If we really need a read-only configuration, we could just use a derivation to build it.

That's a good approach, can we move the current preStart script into a derivation?

I tried to implement this this today, and it looks like it might not be workable. Unfortunately, file includes (like foo:< file:///path/to/value), are resolved when the configuration is built, not loaded. So it cannot be built from a derivation, since these are sandboxed. This is probably the best way we currently have of handling passwords as well for read-only config (as we don't want them copied into the store), so it probably does need to run in the preStart script, with access to the file-system.

And I would argue that read-only configuration provides no obvious benefits

I disagree on this - knowing that my configuration exactly matches what is declared in the module (and won't change when I redeploy the service) is a big benefit for me.
I can implement this and open a PR against your branch, then we can merge this?

Sure.

Just in case you missed it, I opened a PR here: https://github.com/poscat0x04/nixpkgs/pull/1 - let me know what you think!


Allow to paste example data to templated elements

Is your feature request related to a problem? Please describe.
Check https://github.com/camunda/connectors/issues/1401
Describe the solution you'd like
Section is visible.
Describe alternatives you've considered
Leave it to the templates developers whether they want to accept example data in the templates.
Additional context
See additional thoughts on this: https://github.com/camunda/connectors/issues/1401#issuecomment-2137621805

The example data is currently stored in a camundaModeler:exampleOutputJson, which is a zeebe:property. We would need to adjust our upgrade logic to explicitly exclude it from being removed when applying or upgrading templates.

As discussed in https://github.com/camunda/connectors/issues/1401#issuecomment-2147118609 and in the weekly, adding example data for connectors needs additional effort to support Connector runtime scope in our variable tooling

@marstamm Would you still agree this is a valid feature request? If so, let's move it into the respective place, otherwise let's close it.

As per https://github.com/camunda/connectors/issues/1401#issuecomment-2147118609 , I do not think this is a valid feature request. We can consider opening an issue to support "connector scope" in the variable resolver


Field Note: single mode output should have optional "unselect" behavior for repeated trials

Added feature, per clinician requests


java.util.ConcurrentModificationException in REST connection pool code

What kind an issue is this?

[x] Bug report. If you’ve found a bug, please provide a code snippet or test to reproduce it below.
The easier it is to track down the bug, the faster it is solved.
[ ] Feature Request. Start by telling us what problem you’re trying to solve.
Often a solution already exists! Don’t send pull requests to implement new features without
first getting our support. Sometimes we leave features out on purpose to keep the project small.

Issue description
I currently updated ES-Spark dependency from v5.0.0-alpha-5 to v5.0.1 (es-spark-20 in es-hadoop)
(until that moment, everything's OK)
And according to recommendation on DStream output API change, I also changed my output codes from stream.foreachRDD(_.saveToES(..)) to EsSparkStreaming.saveToES(stream, ...)
After this change, spark-submit with standalone cluster in client deploy mode, occasionally produces following error in workers.
java.util.ConcurrentModificationException
	at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
	at java.util.HashMap$EntryIterator.next(HashMap.java:1463)
	at java.util.HashMap$EntryIterator.next(HashMap.java:1461)
	at org.elasticsearch.hadoop.rest.pooling.TransportPool.removeOldConnections(TransportPool.java:168)
	at org.elasticsearch.hadoop.rest.pooling.PooledHttpTransportFactory.cleanPools(PooledHttpTransportFactory.java:121)
	at org.elasticsearch.hadoop.rest.pooling.PooledTransportManager$PoolCleaner.run(PooledTransportManager.java:86)
	at java.lang.Thread.run(Thread.java:745)

Steps to reproduce
How to Reproduce:

partially described in issue description.
It occurs in random manner, possibly with high probability in the state of indexing/updating operations are increased rapidly.

Spark/ES Cluster Configuration:

A Spark cluster with 3 workers (16 cores per one worker, each worker's in physically separated Linux server)
An ElasticSearch cluster with 3 nodes
Each server: 16 Cores, 32 GB memory space, 1 TB disk space

Version Info
OS:         :  CentOS 6
JVM         :  1.8.0_40
Hadoop/Spark:  Spark 2.0.1
ES-Hadoop   :  5.0.1
ES          :  2.4.1

Feature description

Thanks for opening this up. The problem was not so much a threading issue but a set of calls that mutating the collection of idle connections while iterating over that same collection. Should be fixed in the above commit.

I'm happy for this report being a little bit of contribution to more robust codes.
I'll wait for next version. Thank you!


Docker build fails with an "unsatisfiable constraints" error

Trying a local Docker build fails with the following "unsatisfiable constraints" error.
$ docker build -t tegola .
Sending build context to Docker daemon  107.2MB
Step 1/12 : FROM golang:1.14.1-alpine3.11 AS build
1.14.1-alpine3.11: Pulling from library/golang
aad63a933944: Pull complete
c732a2540651: Pull complete
7b2225181d6b: Pull complete
c8dae7ec6990: Pull complete
08684ee472f3: Pull complete
Digest: sha256:244a736db4a1d2611d257e7403c729663ce2eb08d4628868f9d9ef2735496659
Status: Downloaded newer image for golang:1.14.1-alpine3.11
 ---> 760fdda71c8f
Step 2/12 : ARG VERSION="Version Not Set"
 ---> Running in 50d8913ec5c4
Removing intermediate container 50d8913ec5c4
 ---> 3c55c7a00653
Step 3/12 : ENV VERSION="${VERSION}"
 ---> Running in e03c49a9f32a
Removing intermediate container e03c49a9f32a
 ---> 6667c5acdb26
Step 4/12 : RUN apk update 	&& apk add musl-dev=1.1.24-r2 	&& apk add gcc=9.3.0-r0
 ---> Running in a608d063395b
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.11/community/x86_64/APKINDEX.tar.gz
v3.11.6-215-g0999d9b171 [http://dl-cdn.alpinelinux.org/alpine/v3.11/main]
v3.11.6-212-g3a84324cad [http://dl-cdn.alpinelinux.org/alpine/v3.11/community]
OK: 11276 distinct packages available
ERROR: unsatisfiable constraints:
  musl-dev-1.1.24-r3:
    breaks: world[musl-dev=1.1.24-r2]
The command '/bin/sh -c apk update 	&& apk add musl-dev=1.1.24-r2 	&& apk add gcc=9.3.0-r0' returned a non-zero code: 1

Run using master branch on Ubuntu 20.04 with Docker version 19.03.14

@dkastl thanks for the report, and apologies for the slow response here. It looks like there's an issue fetching musl-dev, though a quick search shows that the version is still current. It might be worth making some version bumps in the Dockerfile to see if we could get this working. Maybe we bump to  Go 1.15.6 and alpine 3.12 and then bump musl-dev to musl-dev-1.1.24-r10.
Would you want to attempt doing the version bump?

Thank you for looking at this. My Go knowledge is rather low and so is my confidence for a pull request. I wouldn't mind if someone else does this. But I'm happy to test a merge request before merging.

I spun up a new branch, issue-728-Docker-failing which addresses the version bumps, though now the tegola build command is failing:
usage: link [options] main.o
  -B note
    	add an ELF NT_GNU_BUILD_ID note when using ELF
  -E entry
    	set entry symbol name
  -H type
    	set header type
  -I linker
    	use linker as ELF dynamic linker
  -L directory
    	add specified directory to library path
  -R quantum
    	set address rounding quantum (default -1)
  -T address
    	set text segment address (default -1)
  -V	print version and exit
  -X definition
    	add string value definition of the form importpath.name=value
  -a	no-op (deprecated)
  -benchmark string
    	set to 'mem' or 'cpu' to enable phase benchmarking
  -benchmarkprofile base
    	emit phase profiles to base_phase.{cpu,mem}prof
  -buildid id
    	record id as Go toolchain build id
  -buildmode mode
    	set build mode
  -c	dump call graph
  -compressdwarf
    	compress DWARF if possible (default true)
  -cpuprofile file
    	write cpu profile to file
  -d	disable dynamic executable
  -debugtramp int
    	debug trampolines
  -dumpdep
    	dump symbol dependency graph
  -extar string
    	archive program for buildmode=c-archive
  -extld linker
    	use linker when linking in external mode
  -extldflags flags
    	pass flags to external linker
  1 Version bumps in Dockerfile
  -f	ignore version mismatch
  -g	disable go package data checks
  -go115newobj
    	use new object file format (default true)
  -h	halt on error
  -importcfg file
    	read import configuration from file
  -installsuffix suffix
    	set package directory suffix
  -k symbol
    	set field tracking symbol
  -libgcc string
    	compiler support lib for internal linking; use "none" to disable
  -linkmode mode
    	set link mode
  -linkshared
    	link against installed Go shared libraries
  -memprofile file
    	write memory profile to file
  -memprofilerate rate
    	set runtime.MemProfileRate to rate
  -msan
    	enable MSan interface
  -n	dump symbol table
  -o file
    	write output to file
  -pluginpath string
    	full path name for plugin
  -r path
    	set the ELF dynamic linker search path to dir1:dir2:...
  -race
    	enable race detector
  -s	disable symbol table
  -strictdups int
    	sanity check duplicate symbol contents during object file reading (1=warn 2=err).
  -tmpdir directory
    	use directory for temporary files
  -u	reject unsafe packages
  -v	print link trace
  -w	disable DWARF generation
The command '/bin/sh -c cd /go/src/github.com/go-spatial/tegola/cmd/tegola 	&& go build -v -ldflags "-w -X github.com/go-spatial/tegola/cmd/tegola/cmd.Version=${VERSION}" -gcflags "-N -l" -o /opt/tegola && chmod a+x /opt/tegola' returned a non-zero code: 2

@gdey do you have know off hand what would cause that error? I figured I would ask before I dig too deep into the research.

Looks like a linker issue:
I would look at this bit:
-ldflags "-w -X github.com/go-spatial/tegola/cmd/tegola/cmd.Version=${VERSION}"
and any cgo code that has the linker flags.

Thank you! I made test build and run the help command and it seems to work now!

@dkastl great! We will get this into the v0.13.0 branch soon. I'm just waiting on a quick review from @gdey

closed via 154b7ccd821c57e14fcbf673529c4a8546131c8e


[WIP] docs: document the step-by-step of how partners should implement their anchor servers

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
[TODO: Short statement about what is changing.]
Why
Close #272.
Known limitations
[TODO or N/A]

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr334.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr334.previews.kube001.services.stellar-ops.com/


Compliance API, return profile status for reporting node

Adds status to the profiles array returned by the reporting node API /api/v0/compliance/reporting/nodes/id/:id
{
  "id": "96f34b9d-a6d5-456c-a2c8-ad3b0944f6f3",
  "name": "mysuite-centos3",
  "platform": {
    "name": "centos",
    "release": "6.7"
  },
  "environment": "_default",
  "latest_report": {
    "id": "91695430-8aa0-488a-be20-63212029d318",
    "end_time": "2019-06-27T09:08:47Z",
    "status": "skipped",
    "controls": {
      "total": 14,
      "passed": {
        "total": 0
      },
      "skipped": {
        "total": 14
      },
      "failed": {
        "total": 0,
        "minor": 0,
        "major": 0,
        "critical": 0
      }
    }
  },
  "tags": [],
  "profiles": [
    {
      "name": "apache-baseline",
      "version": "2.1.0",
      "id": "73eba2f2c12a6014cf0880c1e7d990bb783346a92d0d46284aaf785b8206cd39",
      "status": "skipped"
    }
  ]
}

Issue raised here: https://github.com/chef/automate/issues/691

Thank you Lance, merging...


Accessibility Enhancement Suggestion for Flutter

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Use case
Dear Team,
I would like to suggest an improvement for accessibility in Flutter.
Currently, developers need to manually add labels to interactive UI elements using the Semantics widget. This can be a time-consuming and tedious process, especially for large and complex applications.
Proposal
To address this issue, I propose incorporating a labelSemantics feature into development widgets. Developers would simply specify the label for the widget, and the labelSemantics would be generated automatically.
This would make accessibility more accessible for all developers, regardless of their level of experience.
Furthermore, having labelSemantics built into development widgets would make applications more accessible by default. This is because developers would not have to remember to add labels to interactive UI elements.
Here are some specific ways in which built-in labelSemantics in development widgets could improve accessibility:

Reduces developer workload. Developers would not have to manually add labels to interactive UI elements.

Makes accessibility more accessible to all developers. Even developers with limited accessibility experience could make their apps accessible.

Makes apps more accessible by default. Developers would not have to remember to add labels to interactive UI elements.

I believe that having labelSemantics built into development widgets would be a significant improvement for accessibility.

In addition, I suggest that widgets like Text() automatically receive the same value as the text passed to the widget for the semanticsLabel attribute. With this simple addition, a vast majority of applications would already have some level of accessibility support.


if metrics is too many, how to disign db?

if many server metrices , how to design db？
for instance  1000 server   ，each server have 20 metrices ，total 2000个metrics ，how to design db?

I presume you mean how should the metrics be named? Check out the link
below for some advice for the 0.8 release:
http://influxdb.com/docs/v0.8/advanced_topics/schema_design.html
http://influxdb.com/docs/v0.8/api/reading_and_writing_data.html
On Fri, Jan 30, 2015 at 5:39 PM, fengyun.rui<EMAIL_ADDRESS>wrote:

if many server metrices , how to design db？
for instance 1000 server ，each server have 20 metrices ，total 2000个metrics
，how to design db?
—
Reply to this email directly or view it on GitHub
https://github.com/influxdb/influxdb/issues/1462.

Also, this question should be asked on the Google Group here: https://groups.google.com/forum/#!forum/influxdb


Comprehend Moderation ver 0.1

This PR streamlines the #9665 configuration object and logic to enable chain moderation via the Amazon Comprehend service, allowing you to detect and redact PII, Toxic, and Intent information in the LLM prompt or answer.
This implementation simplifies the configuration and types it to specific class/model.
Usage sample

from langchain_experimental.comprehend_moderation import (BaseModerationConfig,
                                 ModerationIntentConfig,
                                 ModerationPiiConfig,
                                 ModerationToxicityConfig
)

pii_config = ModerationPiiConfig(
    labels=["SSN"],
    redact=True,
    mask_character="X"
)

toxicity_config = ModerationToxicityConfig(
    threshold=0.5
)

intent_config = ModerationIntentConfig(
    threshold=0.5
)

moderation_config = BaseModerationConfig(
    filters=[pii_config, toxicity_config, intent_config]
)

comp_moderation_with_config = AmazonComprehendModerationChain(
    moderation_config=moderation_config, #specify the configuration
    client=comprehend_client,            #optionally pass the Boto3 Client
    verbose=True
)

template = """Question: {question}

Answer:"""

prompt = PromptTemplate(template=template, input_variables=["question"])

responses = [
    "Final Answer: A credit card number looks like 1289-2321-1123-2387. A fake SSN number looks like 323-22-9980. John Doe's phone number is<PHONE_NUMBER>.",
    "Final Answer: This is a really shitty way of constructing a birdhouse.
]
llm = FakeListLLM(responses=responses)

llm_chain = LLMChain(prompt=prompt, llm=llm)

chain = (
    prompt
    | comp_moderation_with_config
    | {llm_chain.input_keys[0]: lambda x: x['output'] }
    | llm_chain
    | { "input": lambda x: x['text'] }
    | comp_moderation_with_config
)

try:
    response = chain.invoke({"question": "A sample SSN number looks like this<PHONE_NUMBER>. Can you give me some more samples?"})
except Exception as e:
    print(str(e))
else:
    print(response['output'])

Output

> Entering new AmazonComprehendModerationChain chain...
Running AmazonComprehendModerationChain...
Running pii Validation...
Running toxicity Validation...
Running intent Validation...

> Finished chain.

> Entering new AmazonComprehendModerationChain chain...
Running AmazonComprehendModerationChain...
Running pii Validation...
Running toxicity Validation...
Running intent Validation...

> Finished chain.
Final Answer: A credit card number looks like 1289-2321-1123-2387. A fake SSN number looks like XXXXXXXXXXXX John Doe's phone number is<PHONE_NUMBER>.

{"input": (lambda x: x['output'] ) | llm}

Copy that, yes that works as well. I tested out our first two example with your suggestion and it works. Will test out the other examples and change them.

New usage
llm = FakeListLLM(responses=responses)

chain = (
    prompt
    | comp_moderation_with_config
    | { "input": (lambda x: x['output']) | llm }
    | comp_moderation_with_config
)

try:
    response = chain.invoke({"question": "A sample SSN number looks like this<PHONE_NUMBER>. Can you give me some more samples?"})
except Exception as e:
    print(str(e))
else:
    print(response['output'])

@hwchase17 -  The #10104 looks like is merged but the PR status shows as open. The latest sample notebook is updated already by @anjanvb . Can you please pull the latest Notebook from the docs and let us know if we should close this PR.

@iamwrick
The PR is not merged yet. If you have all the updates in the PR, @hwchase17 should merge soon.

@3coins it does look like it was merged via #10153?

@3coins it does look like it was merged via #10153?

Yep, did not know there was another PR. If all updates are present in 10153, let's close this one.

@3coins it does look like it was merged via #10153?

Yep, did not know there was another PR. If all updates are present in 10153, let's close this one.

closing per ^


Orphanet Alignment for March release

Document is: https://docs.google.com/spreadsheets/d/17fX1oh-JSDLkPxEBTuiSXpiLx45qZI-S0spLa29ZGho/edit#gid=70424824
Files used are from Feb 20, 2024

@sabrinatoro if you don't have time to address these issues before you leave for vacation, I can take care of it

@nicolevasilevsky, changes have been made. It is ready for your review again. Thank you!


feat: file level lint

Codecov Report

Merging #808 (8024f7b) into release-next (4a7a3e6) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-next     #808   +/-   ##
=============================================
  Coverage         52.20%   52.20%
=============================================
  Files                47       47
  Lines              1226     1226
  Branches            257      257
=============================================
  Hits                640      640
  Misses              586      586


First of all, I want to say that I really appreciate the work you do.
Despite more than 6 years of experience with Unity and more than 10 at coding and making games, I'm rather new to Entitas and ECS. I still have much to figure out, but I'm already fascinated by it enough to use it in my home indie-games attempts. Mostly thanks to your awesome Unite presentations. If it wasn't for them, I don't think I would go for it: ECS seems weird in a lot of ways and not really applicable to bigger projects from where I'm at right now. I hope my views will change as I progress.
I'll try to do my part, as test-driven development is where I put all of my free time to and this new way of programming seems to hold a lot of promise.
My main issue with Entitas so far seems to be compilation hell after code generation. I'm used to first dive right in without reading much documentation, so after an hour or so of trying to imitate your example projects I have found myself lost when I figured out I didn't understand what got generated, how it got generated and how come trying to regenerate it seems to give me the same code with the same errors even after I've fixed the differences between my attempts and your examples. After reading though your wiki, I saw what things are required for generation and (my biggest foe) that you need everything to compile correctly before you can generate code.
Two days in, that last bit seems rather frustrating so far. I know I can get used to writing components without errors as they are very simple and understandable and my code generation will work fine at least 90% of the time, but the idea of refactoring it at some point in the future: deleting some of them, renaming, etc kinda scares me.
I saw that you are working on different approaches at code generation: you have Roslyn based code generator, for example. I didn't try it yet since it seems to be a year old and I didn't find any documenation on how to integrate it, so I've decided against it for now. I believe you've decided against integrating it into entitas due to it not working on platforms other than Windows.
I also saw that you are working on an alternative solution to this problem, although I believe it is far from ready at this point.
Am I right about all of this, or do you have a solution for this problem already, and I've just missed it? If so, please, let me know.
Anyways, just in case, I thought a little bit about the whole thing and then this idea hit me: what if we made another assembly just for code generation? Let me explain.
For code generation you need:

the component files and the data classes inside of them that (if I undestood ECS correctly) cannot be systems, pools or anything else, but raw data;
also you need the Entitas settings: pools, etc,- but those, I believe, should work fine even with compilation errors in unity project.

So basically, you can create another manual assembly before code generation that only includes files with "magical" names in the project like "Component" and Data. In other words, we make a naming convention for everything that is required for code generation so that we can manually create another assembly before code generation and then code generate based on that assembly only.
This way we can make sure that the probability of compilation errors is minimal and your ability to fix those compilation errors is huge.
The idea seems simple enough to work out of the box on any platform without changing much in your code generator. What do you think?
Of course, if you already have another solution in the works or maybe even up and working, I'm all ears. Otherwise, this might be a good workaround for the moment as this compile hell seems rather frustrating to me.
Regards,
Eugene.

Hi Eugene, great to hear that you're giving Entitas a try. I always try to make working with Entities fun and seamless. The current code generator is our biggest complaint atm and we are well aware of that. After researching and prototyping different alternatives to fix that issue we finally made some really good progress. I plan to test our next-gen code generator this week, maybe even on a big project I'm working on. The solution we're striving or is our custom DSL. it will look sth like this:
comp Position in Core
    x: float
    y: float
    z: float

comp Resources unique in Meta
    coins: int
    gems: int

Based on the DSL we can generate code at any time, no matter if your game compiles or not. But there is way more than just that, I think the DSL has much potential and we can have really cool features in the future. We're also trying to generate systems and blueprints for you. It is really promising :) As I said, I plan to test all this this week and let all of you guys know about the results.

The only concern maybe will be that the generated code from the DSL won't update your code using that generated code, so when you need to refactor something you will need to change the DSL and your code as well. Maybe i am wrong.

I also want to know whether I can change the DSL code templates to fit into my code base better. e.g. rather than a pools/contexts class being generated I want to create them through a different method like service attached to di container.

@JuDelCo true

@T2RKUS That sound like a good feature. Entitas will always ship with the current default code generator, so it will be easy to implement custom generators.

@T2RKUS with #265 you will be able to generate exactly what you need


Fixed an issue with none releases ending up as snapshot releases

This is confusing me, the tests seem to be about ignored packages but the title sounds like it's about changesets with none releases?

That is cause updating a dependency of an ignored package ends up being a none release for that ignored package - so it doesn't get released but so we can adjust its dependency ranges. This reflects the actual use case which got me to fix this.
There might be also a more basic test case to be written here though - I didn't evaluate it. The fixed bug is about a situation in which Changesets itself creates a none release for a package on behalf of the user. Can this happen in any other situation? I agree though that maybe the changeset description should be adjusted here

@mitchellhamilton I've tweaked the changeset and the test title, I've also added a new test case for a situation with explicit none release type. Could you re-review it?


How to run inference on multi-GPU machine ?

I am trying to run inference on my machine with two GPUs, but the demo script runs on single GPU and runs out of memory. Please let me know how to set the demo script to run on multi-GPU setup.

sorry. we only run single-gpu inference in our research. If you want to run multi-gpu inference in your engineering project, you can refer to the training process to implement it yourself.

sorry. we only run single-gpu inference in our research. If you want to run multi-gpu inference in your engineering project, you can refer to the training process to implement it yourself.


Public enum ToString/FromString and ToType/FromType

Closes #239.
All the public enums now expose a ToString and FromString, as well as a ToType and FromType for easy conversion from client side.

The enum utilities are now in [EnumName]Spec static class, with an enum_type_t typedef. So it is more easy to use in templates.
I also added a to_human_string for log values, and to_string for config-style strings.


feat: Adding Emotion ThemeProviders for all React apps

SUMMARY

In order to start moving things more toward using CSS-in-JS (with Emotion) this PR adds ThemeProviders to all of the React apps in the codebase. Maybe one day we can whittle down the number of these apps, but for now, they should all work the same, so I'm just propagating the pattern here.
In particular, the Explore and Dashboard apps will need it, so the theme can be used in viz plugins reliably.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[x] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #9853 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9853      +/-   ##
==========================================
- Coverage   71.13%   70.79%   -0.35%
==========================================
  Files         589      184     -405
  Lines       30797    17868   -12929
  Branches     3241        0    -3241
==========================================
- Hits        21907    12649    -9258
+ Misses       8779     5219    -3560
+ Partials      111        0     -111

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
70.79% <ø> (-0.48%)
:arrow_down:

Impacted Files
Coverage Δ

superset/views/database/mixins.py
58.92% <0.00%> (-21.43%)
:arrow_down:

superset/utils/cache.py
45.83% <0.00%> (-20.84%)
:arrow_down:

superset/db_engine_specs/mysql.py
78.26% <0.00%> (-13.05%)
:arrow_down:

superset/views/tags.py
35.13% <0.00%> (-4.11%)
:arrow_down:

superset/models/sql_types/presto_sql_types.py
72.41% <0.00%> (-4.06%)
:arrow_down:

superset/models/tags.py
58.58% <0.00%> (-3.80%)
:arrow_down:

superset/views/database/api.py
83.90% <0.00%> (-3.45%)
:arrow_down:

superset/views/sql_lab.py
59.06% <0.00%> (-3.29%)
:arrow_down:

superset/cli.py
36.59% <0.00%> (-3.14%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.29% <0.00%> (-2.71%)
:arrow_down:

... and 430 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ab8dd...2bf8cc2. Read the comment docs.

@suddjian could use a sanity check review, if you don't mind :)


FormFlow and multi-word field's term issues

Reproduce the issues:

Create a form with two fields:

[Serializable]
public class TestForm
{
    public string First { get; set; }
    public string SecondField { get; set; }
}

Build a FormDialog:

new FormBuilder<TestForm>()
    .Field(nameof(TestForm.First))
    .Field(nameof(TestForm.SecondField))
    .Confirm("Confirm?")
    .Build();

Run the dialog, fill up form fields (First and SecondField) and answer with "no" to the confirmation "Confirm?".

Issues

If you respond to "What do you want to change?" by clicking the button for the Second Field you will receive "SecondField" is not a field name option.
Select Second Field by responding with "Second" or "Field"

if you enter some text (different form "no") for second field, you will receive "..." is not a field name option.
if you enter "no", an "Object reference not set to an instance of an object." exception will be thrown.

Some workarounds
Explicitly define terms for SecondField containing single words. For example by annotating the SecondField property with:
[Terms(new string[] { "second", "field" })]

This is a bug.  Thanks for bringing it to our attention.  It will be fixed in the next release.


Add measure script

Wrote it to save my own sanity when comparing the runner.

@Evangelink merge or close?


Issue with init process.

I 've a liferay appplication running inside the docker.
There are 2 ways by which I start a liferay.
Starting a normal linux container with init process as bash (pid =1 ). Then entering the container using exec I start the liferay service and it runs with a pid > 1 and ppid as 0. Now when I stop/restart this liferay application the process goes defunct.
[root@f64c4d5 /]# ps -ef | grep defuct
root 328 0 18 14:47 ? 00:00:29 [java]
So in this case, I 've no means to restart my application.
I start my container with an entry-point to execute a bash script which acts a wrapper for my liferay. In this case the liferay runs with a pid > 1 and ppid = 1. Here also I cant restart my application. The process then stops properly and starts with ppid as 0 and then when I stop it again it goes into defunct.
I 'm kind of stuck without a means to restart application inside containers without bouncing the entire container. Please someone suggest some workaround to restart applications without bouncing the container?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.


Broken link in az vmss perform-maintenance section

I think the following section contains a broken link (note the space before the dash between virtual- and machine;

Operation on instances which are not eligible for perform maintenance will be failed. Please refer to best practices for more details: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual- machine-scale-sets-maintenance-notifications.

And I expect that it should be:

Operation on instances which are not eligible for perform maintenance will be failed. Please refer to best practices for more details: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-maintenance-notifications.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0408c294-207a-2b72-7b93-e09121602b75
Version Independent ID: 852cb67b-70c6-b811-3b0a-5d5b84b8a911
Content: az vmss
Content Source: latest/docs-ref-autogen/vmss.yml
Service: virtual-machine-scale-sets
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

hi @BigCat20196 could you help to have a look?

hi @Stephanvs Thank you for finding out this issue. You're right.
I am considering fixing it.

Thank you for your PR.
However, this yaml file is generated automatically through the. Py file, so it needs to be modified in the location where the file is generated to ensure that the modification is effective.
This problem will be fixed as soon as possible.
Thank you again for using azure and hope it gets better.


Chemical science pack (3) wrong recipe

0.17.0:
Changed name to "Chemical science pack".
Recipe changed to 3 Advanced circuits + 2 Engine units + 1 Solid fuel → 2 Chemical science pack. (Previously 1 Advanced circuit + 1 Engine unit + 1 Electric mining drill → 1 Science pack 3).
https://wiki.factorio.com/Chemical_science_pack

https://kirkmcdonald.github.io/calc.html#data=0-17-1&items=chemical-science-pack:f:1

Whats wrong?

Oh, settings in url set all time old version of factorio (


[style]: Background and foreground colors do not have a sufficient contrast ratio.

What's the style idea?
We need to improve the background and foreground colors as it is difficult for many users to read.
Add screenshots
Add screenshots[Accessibility Report]

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @SurajPratap10 , I have raised this issue under gssoc'23.
It'd be great if you review this and assign me.

Assigned @amelia2802

Thank you @SurajPratap10 for assigning, before I start working on this issue do you have any particular brand color dedicated to Imagine_AI? Or I can use any contrasts?

No, nothing as such. You can innovate @amelia2802  your style. If there would be any enhancements then I will tell that in the PR itself

Alright!


Add xmlsec1

Tool information

Tool name: xmlsec1
Add
Desired version: latest
Approximate size:
If this is an add request:

Brief description of tool: xml cryptography library
URL for tool's homepage: https://linux.die.net/man/1/xmlsec1

Area for Triage:
Area: Scripting and command line
Question, Bug, or Feature?:
"Feature"
Virtual environments affected

[X] macOS 10.15
[X] Ubuntu 16.04 LTS
[X] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Tool can be installed in runtime:
# Ubuntu; installation takes ~5 seconds
sudo apt-get install -y xmlsec1
# macOS; installation takes ~13 seconds
brew install libxmlsec1

hi @ruslan-shuster, considering the install is pretty quick and simple we won't bake it into the images. We've been having issues with disk space and so we are trying to prioritize only the more critical tools. Thanks for reaching out.


Unable to Format Time Intelligence Calculation

When formatting the following calculations for a newly create dashboard where the data is being house in SharePoint. I am getting the following error message:

Below are the calculations:
1.
SELECTEDMEASURE ()

CALCULATE(
SELECTEDMEASURE(),
SAMEPERIODLASTYEAR('Calendar'[Date])
)

VAR CurrentPeriod = SELECTEDMEASURE()
VAR PriorPeriod =
CALCULATE(
SELECTEDMEASURE(),
SAMEPERIODLASTYEAR(
'Calendar'[Date]  )
)
VAR Result =
IF(
NOT(ISBLANK(CurrentPeriod))
&& NOT(ISBLANK(PriorPeriod)),
CurrentPeriod - PriorPeriod
)
Return
Result

VAR CurrentPeriod = SELECTEDMEASURE()
VAR PriorPeriod =
CALCULATE(
SELECTEDMEASURE(),
SAMEPERIODLASTYEAR(
'Calendar'[Date]  )
)
VAR Result =
Divide(IF(
NOT(ISBLANK(CurrentPeriod))
&& NOT(ISBLANK(PriorPeriod)),
(CurrentPeriod - PriorPeriod)
),PriorPeriod)
Return
Result

Hi @Osam93
Sorry for the late reply. This issue seems unrelated to Tabular Editor. If you believe this issue is caused by Tabular Editor, please feel free to reopen the issue with a more detailed explanation.


Add new handle_ settings for exit-transformer

Add new handle_ settings and usage guidance to exit-transformer documentation. See https://github.com/Kong/kong-plugin-enterprise-exit-transformer/pull/3 for reference.

Direct link to rendered output:  https://deploy-preview-1980--kongdocs.netlify.app/hub/kong-inc/exit-transformer/


Incomplete installation dependencies

Installation instructions should include also the dependencies of the compiled binaries, e.g. DAlphaBall.gcc requires libgfortran.so.5 and others:
ldd DAlphaBall.gcc
DAlphaBall.gcc:
linux-vdso.so.1 (0x00007fff3d9a0000)
libgmp.so.10 => /lib/x86_64-linux-gnu/libgmp.so.10 (0x00007f92b9909000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f92b982a000)
libgfortran.so.5 => not found
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f92b9649000)
/lib64/ld-linux-x86-64.so.2 (0x00007f92b998e000)

Just the standard setup as described in your readme, within a docker image:
ARG APP=bindcraft
ARG BUILDPLATFORM=linux/amd64
ARG TARGETARCH=amd64

# cbe cluster 2024-10
ARG CUDA_VERSION="12.2"

# 3.10 because bindcraft uses 3.10
ARG MINICONDA_VERSION="Miniconda3-py310_24.7.1-0-Linux-x86_64"

ARG USER_FOLDER="/pub"
ARG CONDA_INSTALL_PATH="/pub/conda"
ARG CONDA_ENV_NAME="bindcraft_env"

ARG BINDCRAFT_GIT_REPO="https://github.com/martinpacesa/BindCraft"

####################################################################################
FROM --platform=$BUILDPLATFORM debian:stable-slim AS builder

ARG TARGETARCH
ARG APP

RUN dpkg --add-architecture $TARGETARCH \
    && apt-get update \
    && apt-get install -y \
      less wget git \
    && true
      # && rm -rf /var/lib/apt/lists/*

#="/pub/conda"
ARG CONDA_INSTALL_PATH
# ="Miniconda3-py311_24.1.2-0-Linux-x86_64"
ARG MINICONDA_VERSION

RUN wget --quiet \
    https://repo.anaconda.com/miniconda/${MINICONDA_VERSION}.sh \
     \
    && bash ${MINICONDA_VERSION}.sh -bfp ${CONDA_INSTALL_PATH} \
    && rm -f ${MINICONDA_VERSION}.sh

ENV PATH="${CONDA_INSTALL_PATH}/bin:${PATH}"

ARG BINDCRAFT_GIT_REPO
ARG CUDA_VERSION

WORKDIR /pub
RUN git clone $BINDCRAFT_GIT_REPO
WORKDIR /pub/BindCraft
RUN bash install_bindcraft.sh --pkg_manager 'conda' --cuda $CUDA_VERSION

# => had to add this for the software to work
RUN apt-get install -y libgfortran5

All other deps recognized perfectly fine.
I double checked now and I see that libgfortran5 indeed installed in the conda environment, but I don't see how DAlphaBall.gcc is supposed to find it? Conda env activation does not set LD_LIBRARY_PATH, and DAlphaBall.gcc is an externally provided binary and can't possibly know where the conda env will be located? Maybe I understand something wrong, but it definitely isn't working as-is. If I remove the libgfortran in the system lib folder, it stops working. I see now I can make it work by explicitly setting LD_LIBRARY_PATH to where conda installs it, but that would also require altering the setup file.
(BindCraft) root@e0ba40b47674:/pub# BindCraft/functions/DAlphaBall.gcc
at least one arg is required! surf, surf_vol, surf_vol_deriv, ...

(BindCraft) root@e0ba40b47674:/pub# apt-get remove libgfortran5
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following package was automatically installed and is no longer required:
  libquadmath0
Use 'apt autoremove' to remove it.
The following packages will be REMOVED:
  libgfortran5
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
After this operation, 2993 kB disk space will be freed.
Do you want to continue? [Y/n] Y
(Reading database ... 10776 files and directories currently installed.)
Removing libgfortran5:amd64 (12.2.0-14) ...
Processing triggers for libc-bin (2.36-9+deb12u8) ...

(BindCraft) root@e0ba40b47674:/pub# BindCraft/functions/DAlphaBall.gcc
BindCraft/functions/DAlphaBall.gcc: error while loading shared libraries: libgfortran.so.5: cannot open shared object file: No such file or directory

(BindCraft) root@e0ba40b47674:/pub# export LD_LIBRARY_PATH=/pub/conda/envs/BindCraft/lib
(BindCraft) root@e0ba40b47674:/pub# BindCraft/functions/DAlphaBall.gcc
at least one arg is required! surf, surf_vol, surf_vol_deriv, ...

DAlphaBall.gcc itself looks for the libs only in the standard locations as defined by the operating system, and this very specific path from the machine where it was compiled:
readelf -d BindCraft/functions/DAlphaBall.gcc | grep RPATH
 0x000000000000000f (RPATH)              Library rpath: [/ssoft/spack/syrah/v1/opt/spack/linux-rhel8-x86_64_v2/gcc-8.5.0/gcc-11.3.0-yrewh277xaqlocj7zcuxnv2m4fq4p3tw/lib64]

Unfortunately I have no experience with Docker and can't say how such a package will behave there, sorry :-/. In regular installs it does not seem to problem. You can search through the closed issues, there was someone who managed to do a docker install

I understand what you mean. It's not a docker thing though in this case, it's just a matter whether libgfortran5 already exists on the host system or not, regardless of whether the system is used directly or via docker.
I double-checked this now on multiple distributions (ubuntu22, debian12, centos7, alpine3.2) - only Debian had libgfortran5 preinstalled. Others gave the same error as in the docker install from debian-slim (which doesn't have it). Most people will I guess simply notice that the library is missing when they try to run, and either install the missing lib or ask their IT to install the lib. Few will actually report it to the github repo, since it's faster to just fix and forget. But it is an undocumented dependency, and anyone starting with a distro without preinstalled libgfortran5 will run into the same error after installing BindCraft according to instructions.
Google colab is based on Ubuntu22, but has a lot of additional things preinstalled, incl. libgfortran5.
My thing is working, I'm just trying to help you make it simpler for all users to install, including the 95% of users who always stay silent. :)

I see, thank you for the input! I will test some possibilities for the install of that with conda, as it is currently somewhat shaky :)


Create a List Report Object Page App with SAP Fiori Tools

Group: https://developers.sap.com/group.fiori-tools-lrop.html
I am unable to access the Odata URL in "Create a List Report Object Page with SAP Fiori App" developer guide with the following error:
Guide

Error

I'm believe the Odata URL might be down from this guide.

@jung-thomas Here is another issue with Gateway service.

@jung-thomas Here is another issue with Gateway service.

@bri-davis I see on the sign-in page that there is planned maintenance from Jan. 22-24. Please try again tomorrow and let us know if it works. Sorry for the inconvenience.
This seems to be a duplicate of issue https://github.com/SAPDocuments/Issues/issues/97 so I will close this one.

@bri-davis I see on the sign-in page that there is planned maintenance from Jan. 22-24. Please try again tomorrow and let us know if it works. Sorry for the inconvenience.
This seems to be a duplicate of issue https://github.com/SAPDocuments/Issues/issues/97 so I will close this one.


[BUG] Browser

Browser Logo Not Showing Any Idea To Add Browser Logo

Hi! There's old issue about that https://github.com/WhiskeySockets/Baileys/issues/228

this is not a bug. the new version of WhatsApp doesn't show the browser anymore. it will only show the OS name.

I don't think as @bentacos mentioned https://github.com/WhiskeySockets/Baileys/issues/228#issuecomment-1625710441
Because if you change https://github.com/WhiskeySockets/Baileys/blob/e24947e55ad6e3370de867b258bb33bb9e828c56/src/Utils/validate-connection.ts#L94C3-L94C56
to proto.DeviceProps.PlatformType.CHROME - it does show "browser" icon
So if I set browser: ["MyAwesomeApp", "Chrome", "<IP_ADDRESS>"] and change platformType to CHROME - it does show icon + `Google Chrome (MyAwesomeApp) with the icon  (screenshot attached below)
So what we need to do is to find right "platformType" based on browser[1] argument or fallback to DESKTOP if not found
https://github.com/WhiskeySockets/Baileys/blob/e24947e55ad6e3370de867b258bb33bb9e828c56/src/Utils/validate-connection.ts#L92-L96
https://github.com/WhiskeySockets/Baileys/blob/e24947e55ad6e3370de867b258bb33bb9e828c56/WAProto/WAProto.proto#L533-L558
I'll open PR with the suggested changes a bit later

Hello, thanks for the addition. Is this merged to main? I desperately need it

Hello, thanks for the addition. Is this merged to main? I desperately need it

It's not merged on main due to any update isn't come from last 2 month's
If you want to use  you can use @queenanya/baileys I updated on it

Thanks for the heads up, do you have the seperate github project for this? I would like to fork and append my own changes on top of it, personally I don't use npmjs, thank you so much in advance

Thanks for the heads up, do you have the seperate github project for this? I would like to fork and append my own changes on top of it, personally I don't use npmjs, thank you so much in advance

Actually I haven't seprate project I make issue and I got solution so I forked the whiskeysockets Baileys and add the browser in that and then I updated in npm if you don't use npm package I send a in zip file if you want


Replace socket subscriptions with custom events

Look into whether any race conditions can result from Subscription system for socket io events

Won't fix, replacing with a new redux model


Forward compatibility of generated AOT files

On recompiling one of our WAMR applications using the latest WAMR head, it proved unable to run AOT files generated by earlier versions of the wamr-compiler. Will this remain the case for future commits of wamr/wamrc? That is, will it always be the case that a wamr app that makes use of AOT and the wamrc that generates its AOT files need to be compiled from (about) the same version wamr source code?

@robinvanemden yes, the AOT file and runtime should match with each other, it is really not easy to run the older version of AOT file with latest runtime due to changes introduced by spec new features, e.g., spec proposal type import, typed reference function and exception handling, which introduce new contents and lead to the change of AOT file and AOT module instance layout.

Thanks for your answer, @wenyongh . That makes sense. We'll make sure to couple runtime & AOT versions accordingly!


Fixed: Bug #196 permissions reset when creating rfr

Signed-off-by: Jonathan<EMAIL_ADDRESS>Summary

fixes bug where it would default permissions if a rfr is created close #196
Checklist

[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[x] This PR is not a code change (e.g. documentation, README, ...)

[x] Have you tested the changes? (pytest & dpytest)
[x] Have you followed PEP-8 for naming and styling?
[x] Has your code been properly documented with RestructuredText docstrings?
[x] Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
[ ] If your code added new bot commands, have you updated documentation.json?

[x] All of this code is your own, or follows the author repo's licence.

Looks like @jplam123 won't be continuing with us, please reassign @Kaspiaan


Return partial dataset-hub-cache instead of error?

dataset-hub-cache depends on multiple previous steps, and any error in one of them makes it fail. It provokes things like https://github.com/huggingface/moon-landing/issues/9799 (internal): in the datasets list, a dataset is not marked as "supporting the dataset viewer", whereas the only issue is that we didn't manage to list the compatible libraries, to create the tags.
https://github.com/huggingface/dataset-viewer/blob/main/services/worker/src/worker/job_runners/dataset/hub_cache.py
In this case, we could return a partial response, or maybe return an empty list of libraries or modalities if we have an error.
What do you think @lhoestq?

In fact, it would make a lot more sense to always return the status of the dataset (ie. the list of the capabilities), instead of propagating an error.

Maybe we can just add a try/except in compatible-libraries and return something empty + the reason why it's empty

yes, an empty list of tags/libraries/modalities/formats is OK (no need to pass a reason in my opinion, since it's a custom endpoint for the Hub).
And we should always pass the other fields: preview, viewer, partial, num_rows (num_rows == 0 is OK if the other fields are false, I think)
https://github.com/huggingface/dataset-viewer/blob/9d4d0d2e69301e5eee3b68a889dd22c7cbe96642/services/worker/src/worker/dtos.py#L254


fix(accordion): Make whole accordion header clickable

Fix accordion header, used WCAG example here https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/

:tada: This PR is included in version 5.43.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add second preview to resolver dialog

I always found it annoying during parameter optimisation that you have to jump back and forth between two EICs, so i added another preview chart. They both use the same feature list. Furthermore, a "good" and a "bad" EICs are are automatically selected.
The bad EIC is determined by taking top 20 EICs (by area) and determining the lowest height/area ratio (low height and high area is most likely chromatographic noise). The good EIC is determined from the top 30 EICs (by area) and simply taking the heighest one.

Unfortunately there is currently no way to do the same for mobility dimension since we do not integrate that dimension.

Thats a great feature!


feat(plugin-jwt) rs512

Add support of RS512 algorithm for signing tokens in jwt plugin.
This add-on is based on the already-used module "crypto".
This pull request contains all the updates submitted by he review of the PR   https://github.com/Mashape/kong/pull/2642 (from next branch).  And this previous one have to be cancelled.

Manually merged to master with a few changes in the tests, code style and commit message. Thank you!


Added ILU preconditioner

This PR adds an ILU preconditioner, which allows the customization of the Upper and the Lower solver separately. As soon as an UpperTrs exists, an alias can be created for the plain Ilu class with these two solvers as the default ones.
TODO:

[X] Add test if with_config is present on solver before generating it
[X] Find out how to do the reverse apply correctly
[X] Add proper description for ILU
[ ] Merge #336
[ ] Merge #341
[ ] Rebase
[ ] Replace default solvers in Ilu with LowerTrs and UpperTrs (LowerTrs works, tested with code from #336)
[ ] (a bit off topic) Add factorization to the create_new_algorithm.sh script

If you do want to test it out. The UpperTrs class is here: upper-trs-solver and the cuda-kernels are here: upper-trs-cuda-kernels

Also just want to add that you should probably add creating a factorization algorithm to the dev_tools/create_new_algorithm.sh script.

@pratikvn Good idea, I added that to the TODOs

This PR should finally be ready for review.
However, PR #336 and #341 need to be merged before this one, so they are higher in priority.

This can now be reviewed.
I added all the comments and added more tests in the hope of getting the coverage up.
On a note: I removed adding factorization to the script from the TODO, since it does not really fit here. I will create another PR to do that.

After the rebase, which contained a fix for the uploading artifact problem, all tests pass now.
This can definitively be reviewed now.


Add Jalen Springfield to Contributors.md

Hi  @JalenSpringfield, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

I'm actually just starting to fully learn about open source contributions and git! I felt the tutorial was on point and left nothing up in the air. I felt pretty good about adding to a shared codebase. This definitely inspired me to keep learning!


Stop the error spam

Fixes WRAP-599
Fixes WRAP-600

Avoids sending a page view before the start route has loaded, this can happen quickly and cancel the in-flight request
Removes response.json as the endpoint now always sends back a 204 with empty text (not json)

Other fixes

getting offset of undefined errors, now ignores here maps complaining when it can't find the offset, this seems to be happening when the map isn't in view
React router error "Deferred data for key "tip" resolved/rejected with undefined, you must resolve/reject with a value or null." getTip will now return null if no tip was found

:tada: This PR is included in version 1.35.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update lib paths

Need to rename hex-grid.min.js to von-grid.min.js in some examples...
After renaming I have blank screen and 'THREE.WebGLRenderer 73    three.min.js:578' in console in both Win and Debian Chrome and Edge.
In pathfinding - "Cannot read property 'gridPos' of undefined    HexGrid.js:161".
In editor - "Cannot read property 'depth' of undefined    main.js:161"

Only the hex grid js is needed for hex maps. You're getting that error
because it's currently broken in the master branch since I'm currently in
the middle of rewriting everything. Sorry for the mess!
On Jan 20, 2016 5:48 AM, "Nikita Moshkalov"<EMAIL_ADDRESS>wrote:

Need to rename hex-gridminjs to von-gridminjs in some examples
After renaming I have blank screen and 'THREEWebGLRenderer 73
threeminjs:578' in console in both Win and Debian Chrome and Edge
In pathfinding - "Cannot read property 'gridPos' of undefined
HexGridjs:161"
—
Reply to this email directly or view it on GitHub
https://github.com/vonWolfehaus/von-grid/issues/6.

Thanks for reply. I will wait for this issue to be closed, understanding this to mean the end of work.

I've fixed the obvious outstanding issues and have merged the latest into the master branch. Please be aware that the Board and grid APIs have changed significantly.


Difference between argmax() and sample in lstm

I'm still confused when I read the follow code.
we can use random output or fixed output by choosing largest probability
def MakeOutput(prob, vocab, sample=False, temperature=1.):
if sample == False:
idx = np.argmax(prob, axis=1)[0]
else:
fix_dict = [""] + [vocab[i] for i in range(1, len(vocab) + 1)]
scale_prob = np.clip(prob, 1e-6, 1 - 1e-6)
rescale = np.exp(np.log(scale_prob) / temperature)
rescale[:] /= rescale.sum()
return _choice(fix_dict, rescale[0, :])
try:
char = vocab[idx]
except:
char = ''
return char
usually, I think we should choose the largest probability of a word in output. Why it have another way to  choose a random word? What's that mean(I also see the same way in Andrej Karpathy's blog)? Could any one explain it for me? Any explanation will be grateful!

what is the "_choice"?

@starimpact this is a help function to sample word randomly.
def _choice(population, weights):
assert len(population) == len(weights)
cdf_vals = _cdf(weights)
x = random.random()
idx = bisect.bisect(cdf_vals, x)
return population[idx]

what is the "_cdf"?

@liuzhi136 That is to sample from $p(x_{t+1} | \hat{x}_{1:t})$. This may be helpful for multi-step prediction. You can refer to the theory of Sequential Monte-Carlo (https://en.wikipedia.org/wiki/Particle_filter).

@sxjscience cannot see the formula.

@sxjscience It's difficult for me to understand the article in (https://en.wikipedia.org/wiki/Particle_filter).  Formula's meaning is word's prob of x_t+1 given first t words. Is that right?

@liuzhi136 Yes. Assume we want to predict the next k words, i.e, x_{t+1:t+k}. The estimator can be $\arg\max_{x_{t+1:t+k}} p(x_{t+1:t+k}) \mid \hat{x}{1:t})$. The rest problem is how to solve this optimization problem based on our model for one-step prediction, which is given by the RNN. One observation is that for every specific $x{t+1:t+k}$, we can easily compute its probability. However, it would be impossible for us to enumerate all the combinations and we need to find some approximate solutions. There are two possible ways for that, Beam Search (deterministic) and Sequential Monte-Carlo (probabilistic). For beam search, the idea is to always keep the word trajectories that have the highest likelihood. For sequential monte-carlo, the idea is to give a particle approximation of the distribution and update these particles.

@sxjscience Thank you so much. I think I got the main idea after reading your explanation.


Fix hash enricher for flatfile output (closes #71)

new release soon: https://github.com/bellingcat/auto-archiver/actions/runs/4438543046/jobs/7789743801


Update OpenChat

OpenChat paper is recently accepted by ICLR 2024 https://openreview.net/forum?id=AOJyfhWYHf

Thank you, looking forward to update this data point.
I note by the way that the paper talks of 'open-source' models where actually most of these are at best 'open weight' — nothing about the source of most of the tested models is actually open.

@imoneoi is there a canonical URL or a DOI? Openreview.net review forum IDs are not guaranteed to be durable links. (If the arxiv.org submission is updated with the accepted version and includes a note like 'accepted at ICLR', we would prefer that.)


[Code health] Set up Kotlin linter

https://github.com/pinterest/ktlint
https://github.com/jlleitschuh/ktlint-gradle

Let's also be sure to make CheckReturnValue the default, it could save us many headaches.