HBASE-27979 some syntax errors detected by IDEA in pom.xml

fix these syntax error mentioned in  https://issues.apache.org/jira/browse/HBASE-27979

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 52s
master passed

+1 :green_heart:
compile
4m 58s
master passed

+1 :green_heart:
checkstyle
1m 14s
master passed

+1 :green_heart:
spotless
0m 43s
branch has no errors when running spotless:check.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
4m 53s
the patch passed

+1 :green_heart:
javac
4m 53s
the patch passed

+1 :green_heart:
checkstyle
1m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 49s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
9m 49s
Patch does not cause any errors with Hadoop 3.2.4 3.3.5.

+1 :green_heart:
spotless
0m 40s
patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
5m 41s
The patch does not generate ASF License warnings.

46m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5327

Optional Tests
dupname asflicense javac hadoopcheck spotless xml compile checkstyle

uname
Linux dde43dc62a0c 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c92e6fdce

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 40s
master passed

+1 :green_heart:
compile
1m 41s
master passed

+1 :green_heart:
shadedjars
4m 49s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 47s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 22s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

+1 :green_heart:
shadedjars
4m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
8m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
270m 21s
root in the patch passed.

316m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5327

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e9947a0259db 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c92e6fdce

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/testReport/

Max. process+thread count
8382 (vs. ulimit of 30000)

modules
C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 27s
master passed

+1 :green_heart:
compile
1m 28s
master passed

+1 :green_heart:
shadedjars
4m 55s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
7m 51s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
1m 30s
the patch passed

+1 :green_heart:
javac
1m 30s
the patch passed

+1 :green_heart:
shadedjars
4m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
7m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
396m 24s
root in the patch passed.

439m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5327

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 739aa3c6c7d2 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c92e6fdce

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/testReport/

Max. process+thread count
8420 (vs. ulimit of 30000)

modules
C: hbase-checkstyle hbase-annotations hbase-build-configuration hbase-logging hbase-protocol-shaded hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-resource-bundle hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-client-byo-hadoop hbase-shaded/hbase-shaded-mapreduce hbase-external-blockcache hbase-compression/hbase-compression-aircompressor hbase-compression/hbase-compression-brotli hbase-compression/hbase-compression-lz4 hbase-compression/hbase-compression-snappy hbase-compression/hbase-compression-xz hbase-compression/hbase-compression-zstd hbase-assembly hbase-shaded/hbase-shaded-testing-util hbase-shaded/hbase-shaded-check-invariants hbase-shaded/hbase-shaded-with-hadoop-check-invariants hbase-archetypes hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project hbase-archetypes/hbase-archetype-builder . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5327/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[@shopify/react-server-webpack-plugin] Add support for node projects

Description
Fixes https://github.com/Shopify/quilt/issues/903
This PR adds Node project support to @shopify/react-server-webpack-plugin with respect to the project layout sewing-kit expects.
This is done by:

Adding a rails option to the webpack plugin to let it know whether we're virtualizing modules for a Rails or Node project.
Making it aware of an /app/index.js file for Node projects. Creates a virtual module at ./app/index.js when appropriate

🎩

cd packages/react-server-webpack-plugin && yarn run build && yarn link
dev cd sewing-kit and checkout react-server-webpack-plugin-node-support

yarn link @shopify/react-server-webpack-plugin && yarn run build
yarn link @shopify/sewing-kit

dev cd web-proving-ground && yarn link @shopify/sewing-kit
yarn dev and verify that the project actually runs
Stop the server. Delete the client directory. Run the server & verify that the app still works
Stop the server. Delete the server directory. Run the server & verify that the app still works
Stop the server. Delete the app directory. Run the server & verify that the app still works. At this point the whole app is pretty much running off virtualized webpack modules. You'll see a beautiful boilerplate component being rendered. Magic 😄

dev cd web-rails-proving-ground && yarn link @shopify/sewing-kit
Verify that the existing behavior for rails apps still works.

Type of change

[x]  Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above

All the comments have been addressed except the one about watch mode. Will tackle that one tomorrow morning. Aside from that this is in a good state for another review.
Updates:

app imports are now all pulling from index since we the app path resolved for us by sewing-kit. Test have been updated with resolves.modules to reflect this. Tested in both web-proving-ground and web-rails-proving-ground
Chatted with Gord about this earlier today. In node, if a user has an existing app/client/server directory, we can assume we know what they're doing. No need to create the folder and cover those wonky edge cases.
Cleaned up the unnecessary private functions
Removed the use of inputFileSystem in favor of glob/fs
Cleaned up the webpack configs in tests to return with the suggestion of returning a function instead of the function.

Got an offline 👌 from Gord, merging.


Outgroup selection with blast

Plan:

[x] progressively index unaligned.fa, only those sequences that have ott IDs with makeblastdb -in {unaligned.fa} -dbtype nucl -out {blastdb} -parse_seqids
[x] when add outgroups, blast while ignoring the ingroup and only keep n outgroups, e.g. blastn -query {unaligned.fa} -db {blastdb} -out {outfile.txt} -outfmt 6 -max_target_seqs n -negative_seqidlist {exclude_ids.txt}
[ ] incorporate operations in snakefile
[ ] include outgroups in constraint tree

The following extracts only those records that have ott IDs and then reformats the header to only retain the process ID:
egrep -A 1 'ott\d+' unaligned.fa | awk -F'|' '/^>/ {print ">"$3; next} {print}'

Indexing added as per commit https://github.com/naturalis/barcode-constrained-phylogeny/commit/0b17a327e22ad8eb14bee94fd85bebbd2f63f50b

Outgroup finder added as per commit https://github.com/naturalis/barcode-constrained-phylogeny/commit/e9349dc51120d27be1bf7c87cc6456fcc2720df1


Consider use an interface for the language extensions in plugin

See: https://github.com/microsoft/build-server-for-gradle/pull/125#discussion_r1504116135

Fixed by #113


cannot import name 'SpeechService' from 'aspeak'

so heres the code
from aspeak import SpeechService, AudioFormat
and it leads to
Traceback (most recent call last):
  File "/Users/willwade/GitHub/TranslateAndTTS/translatepb.py", line 9, in <module>
    from aspeak import SpeechService, AudioFormat
ImportError: cannot import name 'SpeechService' from 'aspeak' (/Users/willwade/.pyenv/versions/3.11.4/lib/python3.11/site-packages/aspeak/__init__.py)

I've tried py 3.8, 3.10.11, 3.9 and you can see above 3.11
I'm on a Mac M2
I have a feeling its the mac causing this issue. On Windows running py 3.8 its fine

I'm on a Mac M2
I have a feeling its the mac causing this issue.

Yes, your feeling is right. I haven't published wheels for apple silicon Macs.
This could be fixed but I am busy right now and don't have time to do so.
For now, You can build a wheel by yourself, or just use the closed-source speech SDK from Microsoft


Dont panic if host has no default input device

The default_input_device() function on core.rs returns a Result, but panics if there is none. By replacing the unwrap with ok_or, we prevent panicking and instead return an Error.

yeah also had issues with VM that had no audio device, thanks!


Refactor TaskPackageDropbox

Address the issue of loading in too many result.p.gz files which can exceed user's memory.
Changes:

Refactor the TaskPackageDropbox.py class
Split up the amount of work done by the _collect_all_finished_pkgidx_result_pairs method
Add run, run_multiple, resubmit and resubmit_multiple to reflect similar functions as the other

Tested the speed difference and saw similar results between before and after these changes.
Also saw a reduction in the memory usage which is fairly flat with time, which is the main goal of this PR (will add plots profiling the memory in a bit)

I realise I changed a few things that may not be need, such as run, run_multiple and so on. Pleased to hear your thoughts on these and the other changes

Removed public methods run, run_multiple, resubmit, resubmit_multiple

Thank you for the update.

In the PR message, you wrote that you "saw similar results between before and after these changes" not the identical results. What are the differences that you saw?

For the speed: the execution time before and after the changes were similar. The outputs were identical.
Although, I recently noticed that this line might be affecting the polling time of the dispatcher, i.e. it polls too many times.

That is right. It was about the speed. I didn't read the sentence carefully.

Without this PR, receive_one() unnecessarily unpickles all available results and then return one result. This PR makes receive_one() unpickle only one result.
The unit tests don't test if receive_one() indeed unpickle one result. I will make this an issue.


token credentials

@florianreinhart could you explain what is the 3 token parameter? key:  location of the certificate file. But what is "keyId" and "teamId" and when they need?

Please read Apple's documentation: https://developer.apple.com/library/content/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/CommunicatingwithAPNs.html#//apple_ref/doc/uid/TP40008194-CH11-SW1

I am sorry to bring this thread back to life, but I really cannot find my keyId, although I read the documentation you are refering. I can see the certificate on my Keychain Access app but cannot find anything like key ID? Thank you.

Login here https://developer.apple.com/account/#/membership
You will get you to your Membership Details( scroll down to Team ID)

Thank you @sidsonAidson, I already found the TeamID, but I cannot find the keyID, do you know where I can find this information?

you have to generate new certification from developer console .Certificate for "Apple Push Notification token-based authentication" and you will get a file named in this format:
APNSAuthKey_XXXXXXX.p8 where XXXXXX is your keyID

Thank you very much @sidsonAidson :D I finally found it.
In case anybody else has the same issue: you have to choose the following option when generating a new certificate from your developer console "Apple Push Notification Authentication Key (Sandbox & Production)".


Subscript Returns Error String as Value of AEXMLElement is Surprising (To Me)

It cramps my style. :smile_cat: It also feels awkward having to type:
let element = elementList["MyElement"]
if element.name != AEXMLElement.errorElementName {
    let string = element["MyString"].stringValue
}

as opposed to something like:
let element = elementList["MyElement"]
let string = element["MyString"].stringValue // I would expect string == ""

because 99% of the time I don't want the string, "element <MyString> not found", because I use stringValue. Was under the assumption that stringValue would return an empty string upon lookup error, not an error string.
This is coming from having used SwiftyJSON. So that is where my expectations are coming from. Feel free to disagree if that's how you feel.
Thoughts?

Hmmm, I think I agree. :)
This will be left open for now, maybe I'll change that in some upcoming version.

What about the subscript returning a optional type? It sounds more natural to me.

No, that's what I wanted to avoid from the initial version. It's easier for end users when subscript is not an optional. And problem with empty string is that you couldn't differentiate when something really has no value or the complete element is missing.

I kind of agree @ivensdenner. My preferred usage is:
if let v = element["MyString"] {
    print(v.stringValue)
}

Helped myself with:
extension AEXMLElement {
    var string: String? {
        if name == AEXMLElement.errorElementName { return nil }
        return stringValue
    }
}

In SwiftyJSON, there are two getters: var string: String? and var stringValue: String. The equivalent of SwiftyJSON's var string: String? is AEXMLElement's var value: String?. AEXMLElement can be made to mimic SwiftyJSON if subclassed like below:
class MyAEXMLElement: AEXMLElement {
    var value: String? {
        guard name != AEXMLElement.errorElement else {
            return nil
        }
        return value
    }

    override var stringValue: String {
        guard name != AEXMLElement.errorElement else {
            return ""
        }
        return super.stringValue
    }
}

And SwiftyJSON handles the errors by having an explicit var error: NSError? property, in case you want the actual error:
extension MyAEXMLElement {
    var error: NSError? {
        guard let value = value where name == AEXMLElement.errorElement else {
            return nil
        }
        return convertToNSError(value)
    }
}

Of course, I'm not saying the above is exactly how I think it should be implemented. I'm only showing how I would adapt the existing code to behave like SwiftyJSON.

Hi all, thanks for this discussion.
In the latest version (3.0.0) I've improved error handling logic to be as you recommended here, that is:

there is no errorElementName anymore
subscript returns empty element (value = nil and stringValue = "")
this empty element will have error property different then nil

Feel free to comment this change if you find anything suspicious (unit tests are passing but this can make breaking changes in other people code, that's why it's a major version bump).
This issue can be closed now.


[New game]: Add a game called Space Invaders

🎮 Game Request
Game logic and basic description
A game where you have to shoot space invaders before they move off from the screen and score points
Point down the features
Game points
Interactive
Responsive
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @SoarinSkySagar !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @SoarinSkySagar ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Dataset in the paper

Hi, I enjoyed the paper and wanted to check the dataset that you presented in the paper. Do you think it would be possible to access it ?

Hello,
Sorry for missing this issue! We just added the link to the dataset in the readme with a piece of code on how to access it.
Kind regards,
Oussama

Awesome, thanks !


2-add-editorconfig-file

This PR adds a .editorconfig file to help having the same conventions across various IDEs.
Added

New .editorconfig file

Fixed
N/A
Breaking
N/A

Hi @khalyomede
Can you remove the github.head_ref from CS Fixer's workflow?

Thanks @khalyomede!


[Bug]: Generate button throws error about RuntimeError: tensors must be 2-D

When I click on the generate button, it shows me an error saying RuntimeError: tensors must be 2-D. I'm running it on an Apple Mac Studio with M1 Max 32C GPU and 32 GB RAM. I cloned the repository and enabled the plugin just today.

Same issue. Tried just now.

mac launch script ships torch 1.12. i see the same behaviour on my macbook.
i've tried updating torch to 1.13.1 and the error was resolved
try it to see of it helps
in your webui folder activate the virtual environment and install newer torch
source venv/bin/activate
pip install -U "torch>=1.13,<2"

Please select the device for text generation as "cpu" in the settings of Promptgen.
@thesobercoder @legendPerceptor


https://www.puppeteersharp.com/ is DOA

DNS is not resolving to the website.

Working on it. Thanks for the report!

Fixed. Pay the bills Dario!


Create annotations

Annotations
1 error
Error: .github#L1
tjenkinson/gh-action-auto-merge-dependency-updates@c47f6255e06f36e84201ee940466e731ffa6e885 is not allowed to be used in Chiefy0x1/docs. Actions in this workflow must be: within a repository owned by Chiefy0x1, created by GitHub, or verified in the GitHub Marketplace

Why:
Closes ISSUE

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ ] For content changes, I have completed the self-review checklist.

dist/index.js dist/index.js


Infer partial stubs and add marker

Closes #93
I'm sure this can be improved. Also please review and test carefully (I'm still running integration tests, but they're taking forever).
The basic idea is to infer a stub package being partial from finding ignore_missing_stub = true in the metadata. If we decide to add a specific "partial" entry in the metadata, the logic will stay the same, only the property's inner code will change.
Alternatively typeshed could add the partial\n py.typed marker itself (assuming it can use packages instead of single files for single-file source w/o problem with stubtest)

In that case it would probably make sense to rename ignore_missing_stub to partial or partial_stub and clearly document what it does on the typeshed side. I'm a bit uncomfortable about adding the partial marker just by looking at some field named ignore_missing_stub.

In that case it would probably make sense to rename ignore_missing_stub to partial or partial_stub and clearly document what it does on the typeshed side. I'm a bit uncomfortable about adding the partial marker just by looking at some field named ignore_missing_stub.

I personally wouldn't rename [tool.stubtest].ignore_missing_stub (at least not for this feature).
I infer from it, because having stubtest ignore missing stubs usually means that, well, there's missing stubs! (and so, the stub package should probably be marked as partial, so that we don't hide public API that is not yet typed).
I do recognize this may not always be the case in the future (as we both alluded to ignore_missing_stub and partial are semantically different), so if you'd prefer going immediately for a different setting, let's do that :) (and the required changes in typeshed).
I see two ways of doing it (more suggestions welcome). Whichever solution should be well documented in typeshed.

Let typeshed add py.typed markers itself. And a test to ensure it contains partial\n. stub_uploader then only needs to include them in its filters.
Add a new metadata entry partial or partial_stub, keep this PR mostly as-is.

Now for example use cases where partial_stub = true and ignore_missing_stub = false:

pywin32: The maintainers stated not wanting to maintain separate stub files. But are open to inline typing (given they can be validated). So once ongoing obsolete code cleanup is done, the library would use inline types, and c-module extensions stubs would live in typeshed. I'd suppose pure-python modules would be excluded in stubtest. This is a very long-term maybe-plan.

partial_stub = false and ignore_missing_stub = true:

stubs that are skipped in stubtest (though skip + ignore_missing_stub wouldn't hurt)
stubs that would have stubtest_allowlist files of thousands of lines (I don't have a concrete example where this is a preferred solution over "fixing" whatever issue with a stub that causes this, or using regex)

I'd prefer to split those features, i.e. have a separate partial_stub key in the METADATA.toml file for the use cases you outlined and to avoid "hidden" side effects.


support "official" repositories that are created by the author of the tool

Needs to be fleshed out, will probably be included in #688


[Feature] Button Full Width (block prop)

Summary

Closes https://github.com/primer/brand/issues/350
List of notable changes:

Added a block prop to the Button component
Fixed the playground options for variants for Button

What should reviewers focus on?

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

[ ] All new and existing CI checks pass
[ ] Tests prove that the feature works and covers both happy and unhappy paths
[ ] Any drop in coverage, breaking changes or regressions have been documented above
[ ] New visual snapshots have been generated / updated for any UI changes
[ ] All developer debugging and non-functional logging has been removed
[ ] Related issues have been referenced in the PR description

Reviewer checklist:

[ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
[ ] Check that tests prove the feature works and covers both happy and unhappy paths
[ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

 Before  After

@rezrah Thank you so much for this comment! I'm so sorry I must have missed this, but this is super cool! Let me get to it right now, I haven't tried yet but everything looks manageable and something that I can give a shot. Thank you so much! This will be fun 😎


Inconsistent API group in ValidatingAdmissionPolicy concept / reference page

This is a Bug Report

Problem:
The page about ValidatingAdmissionPolicy uses a mixture of API groups: admissionregistration.k8s.io/v1alpha1 and admissionregistration.k8s.io/v1beta1.
Proposed Solution:
Be consistent; only use admissionregistration.k8s.io/v1beta1.
Page to Update:
https://k8s.io/docs/reference/access-authn-authz/validating-admission-policy/

Additional Information:
/sig api-machinery
/language en

I would like to work on this
/assign

/assign

/triage accepted

This issue got fixed by merging PR #42879.
Please close the issue.

This issue got fixed by merging PR https://github.com/kubernetes/website/pull/42879.
/close


Integers not decoded as number, doesn't match readme example.

This fails
it ('BigNum bug in ASN.1 implementation', () => {
        var ASNInteger = asn1.define('Integer', function () {
            this.seq().obj(
                this.key('aNumber').int());
        });
        var serialized = ASNInteger.encode({aNumber: 2}, 'der');
        var two = ASNInteger.decode(serialized, 'der');
        assert.equal(two.aNumber, 2);
        assert.equal(two+1, 3); // Fail
    });

With
AssertionError: expected '[object Object]1' to equal 3
Expected :3
Actual   :"[object Object]1"

It turns out that the example in the readme isn't quite correct:
  it ('example from github', () => {
        var Human = asn1.define('Human', function() {
            this.seq().obj(
                this.key('firstName').octstr(),
                this.key('lastName').octstr(),
                this.key('age').int(),
                this.key('gender').enum({ 0: 'male', 1: 'female' }),
                this.key('bio').seqof(Bio)
            );
        });

        var Bio = asn1.define('Bio', function() {
            this.seq().obj(
                this.key('time').gentime(),
                this.key('description').octstr()
            );
        });

        var output = Human.encode({
            firstName: 'Thomas',
            lastName: 'Anderson',
            age: 28,
            gender: 'male',
            bio: [
                {
                    time: +new Date('31 March 1999'),
                    description: 'freedom of mind'
                }
            ]
        }, 'der');

        var human = Human.decode(output, 'der');
        console.log(human);

    });

Prints
{ firstName: <Buffer 54 68 6f 6d 61 73>,
  lastName: <Buffer 41 6e 64 65 72 73 6f 6e>,
  age: <BN: 1c>,
  gender: 'male',
  bio:
   [ { time:<PHONE_NUMBER>00,
       description: <Buffer 66 72 65 65 64 6f 6d 20 6f 66 20 6d 69 6e 64> } ] }

I expect age to be 28 but it's <BN: 1c>, which seems to be a BigNum. How is it supposed to work? According to the readme or according to this test case?
Thanks

Hello!
I think what you are looking for is a documentation for BN module. This is the bignum that this library uses for integers.

Ok. I guess a small update to the readme should do the trick then. Thank you.


Update emea-bhr-invoice-layout.md

in a new "Configure default model mapping for project invoices" chapter please add the following image:

Because an image file was being added, I created a PR in the private branch and made the changes there. The changes have been merged and will publish later today. I am closing this PR.


Issue setting env variable

https://www.reddit.com/r/docker/comments/50822n/made_a_thing_to_turn_docker_run_commands_into/d72lj63:

This doesn't work for when I have an environment variable such as
-e PS1="\[\033[01;31m\]\u\[\033[01;32m\]@\h\[\033[01;34m\] \w \$\[\033[00m\] "

Currently got this, not sure it is good or not :
       environment:
            - 'PS1=\[\033[01;31m\]\u\[\033[01;32m\]@\h\[\033[01;34m\] \w \$\[\033[00m\] '

Actually docker run current behavior is to remove double quote of forms -e XXX="xxx" and send XXX=xxx to container, so this is solved by my PR https://github.com/magicmark/composerize/pull/571 deployed at https://deploy-preview-571--composerize.netlify.app/

Should be ok in the latest version


Some questions!

Hi,
Thank you very much for sharing this.
I'm trying to leverage the work you've done here, and I have a few questions:

The Readme says: "To use the matching tools, you will need to have a CDH3 cluster that has HDFS, MapReduce, and Zookeeper services available" ... I understand that this was written 2 years ago. It seems that there is now CDH4. In any event, I've not used the Cloudera platform. Can you point me to resources that will help me setup a CDH3 or CDH4 (if compatible) cluster that has HDFS, MapReduce and ZooKeeper?

What is the time complexity of the Auction algorithm? I understand it is a parallel graph algorithm, but I'm trying to wrap my head around the time complexity comparison to the Hungarian Algorithm which is also used to solve this class of problems, which can achieve O(n^3).

Thank you.

So I found an answer to #2, and unless the conclusion is challenged here, I'm moving my investigation to the Hungarian algorithm.
Comparison of Hungarian and Auction algorithm: http://chalamy.tripod.com/Report.pdf


Text extraction with bert conversion to keras_core (stage 1)

Converted the example "Text extraction with Bert" to Keras 3 (stage 1)

Replaced 'from tensorflow import keras' by 'import keras' (lines 46 & 47)
Replaced 'lr' by 'learning_rate' in the optimizer definition (line 248)

Tested locally and on Colab

The conversion of the example will await Transformers migration to Keras 3


MapSemiring does not play well with noncommutativity

due to the optimization in MapSemiring.times

It's actually not an issue.


authority includes default ports

When using v0.0.8, the :authority pseudo-header field always appends the port, even when the default port of 443 is used for https.  While not strictly incorrect, perhaps a good new test would be to see if both (with and without port) are allowed by a server when a default port (80 or 443) is used.
i.e.:
:authority: <IP_ADDRESS>:443
vs.
:authority: <IP_ADDRESS>

Thank you for the pointed out!
Fixed in 659eb72693136dae0bb6e7bc986113a11ba6e1ad.


License

What license is this code released under? I would like to fork it and adapt it for a different xmpp server.

hey @slaveriq, i added a BSD3 license to the repo. let me know if that works for your plans


Updated dependencies

@kylewlacy, I'm very interested in using ultra-batch, but I ran into a compatibility issue in that newer versions of tokio are incompatible with the version used by ultra-batch.  I prepared this PR to update the dependencies.  Would you be willing to consider it, and if acceptable, to release a new version of ultra-batch to crates.io?

@kylewlacy, thank you very much!  And thank you also for the corrections on the three points above -- a good learning opportunity for me.

@maldrake Okay, I just published v0.2.0 of ultra-batch! I ended up including a few miscellaneous changes too that I felt would be good since upgrading Tokio was already something I'd consider a breaking change. The Changelog includes a full list of changes.


Confirm page not Android Friendly

Hello Dev,
The whole platform OpenTrade is friendly to cell phone users. I used android and can place buy and sell trades easily.  I can view page easily under android.  However, I found one issue under cell phone android
browser (Chrom):  the confirmation page pop up is usally very small window, half cut off, I could not see
the full content of confirmation page, the price etc are gone.  I was able to click confirm but not seeing
the full confirmation pop up page content in Android is an issue.  Hopefully Dev can fix this cell phone
issue so that this will be awesome Android platform trading exchange!

https://github.com/CryptorClub/opentrade/commit/ed6594e5bf61e1cd16a115ef4c680ee310d41248

I think this issue can be closed now.


cargo bench --bench posw  failed with assert!(remainder.is_zero()) in the testnet3 barnch

🐛 Bug Report

cargo bench --bench posw  failed with the testnet3 barnch, the git version is
SHA-1: 111f5faa1a24342a3d454077e901ea01ea1d5181
Steps to Reproduce

git clone https://github.com/AleoHQ/snarkVM.git  ./vm
cd .vm/dpc
cargo bench --bench posw.

Expected Behavior

matrix_sumcheck_helper 131070/65536
matrix_sumcheck_helper 131070/65536
thread '' panicked at 'assertion failed: remainder.is_zero()', D:\work\storswiftlabs\snarkvm\algorithms\src\snark\marlin\ahp\prover\roun
d_functions\third.rs:226:9
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
thread '' panicked at 'assertion failed: remainder.is_zero()', D:\work\storswiftlabs\snarkvm\algorithms\src\snark\marlin\ahp\prover\roun
d_functions\third.rs:226:9
thread '' panicked at 'assertion failed: remainder.is_zero()', D:\work\storswiftlabs\snarkvm\algorithms\src\snark\marlin\ahp\prover\roun
d_functions\third.rs:226:9
i add  log in line#225
println!("matrix_sumcheck_helper {}/{}", h.degree(), non_zero_domain.size());
let (mut h, remainder) = h.divide_by_vanishing_poly(non_zero_domain).unwrap();
assert!(remainder.is_zero());
Your Environment

snarkVM  111f5faa1a
rust version 1.64
OS： window 11

+1

same issue

Closing as this feature has been removed from the testnet3 branch. Feel free to reopen if you encounter this issue elsewhere!


Adds the Admin Issue Diagnostic - A.I.D. Plugin

The Admin Issue Diagnostic - A.I.D. Plugin collects YOURLS environmentals and formats a template to copy/paste into a YOURLS issue. Just fill in the blanks! Fantastic for newbies, great for experts!

This output is markdown formated and ready to copy/paste into an issue. Just fill in the blanks.
A Sample output from a YOURLS on a Linode server running Debian 8.1, EasyEngine, and nginx.

=====
Technical details regarding my environment

YOURLS version: 1.7.3

Plugins enabled:

admin_issue_diagnostic/plugin.php

YOURLS DB Ver: 482

PHP version: 7.0.32-1~dotdeb+8.1

Server OS Build: Linux

Server & version: nginx/1.14.0

Browser information: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Generated by the AID Plugin ver 1.0

Bug description
What is the current behavior?
This is a bug because…
What is the expected or desired behavior?
Reproducible bug summary steps

A sample output from a YOURLS on a Pair Network shared server running Ubuntu and Apache. Again just fill in the blanks with the details...

=====
Technical details regarding my environment

YOURLS version: 1.7.3

Plugins enabled:

hyphens-in-urls/plugin.php
random-bg/plugin.php
sample-toolbar/plugin.php
admin-ydb/plugin.php
admin-issue-diagnostic/plugin.php

YOURLS DB Ver: 482

PHP version: 7.1.22

Server OS Build: Linux

Server & version: Apache/2.4.35

Browser information: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Generated by the AID Plugin ver 1.0

Bug description
What is the current behavior?
This is a bug because…
What is the expected or desired behavior?
Reproducible bug summary steps

Small nitpick about the "❣" : it's not part of the name (not on your plugin page) so it seems to indicate a special status of the plugin from others in the listing (like, it's particularly endorsed, or official, or favorite, or something)

❣
Ozh is partly correct "it seems to indicate a special status of the plugin from others in the listing", the special status being that this plugin was written mainly to help Newbies.  Likewise, to my knowledge, this is the only plugin on the list that does NOT modify YOURLS behavior.  This plugin helps Newbies write Issues, and changes nothing in the way YOURLS works.  Of course, it works for experts too.
Well written issues reduce the work for the YOURLS Team.
The origional request was to add this to the Admin Area (Note: At that time, I already had this in the Admin Area of my Multisite test site, to help me get all the information for majordome), instead I created a plugin.  I added the decoration to help Newbies find it!
If we don't want to help Newbies write better issues, I don't mind deleting the Newbie class decoration.
I would like to help Newbies, maybe because I have been teaching them for a few decades now.  I suggest leaving  the decoration in place, and adding a small legend at the bottom, like this:
❣ - Of special interest to Newbies
This may better serve both the Newbies and the YOURLS Team. but I defer to your decision.

Adding to the Legend.
I was recently looking for a list of plugins that modify the YOURLS charset. I could not find a list, although I know there are a number of Plugins. Perhaps a category icon could be added to identify related plugins. Like Plugins related to the YOURLS charset.

@PopVeKind Looks great, thanks a lot!


feature: implement EngineData parsing

fixes https://github.com/webtoon/psd/issues/6
This feature should be more or less finished - during the code review I'll run it on sample designs to verify parsing works consistently.

No hard feelings, but next time you could mention you are willing to give a feature one more try - I could have implemented something else in the same time and library would've benefited from that :)

As for this PR - I implemented fix to the CJK parsing bug and added test for it. I also migrated parser to stack-based - to make optimizations a little easier (now flamegraphs can properly merge similar invocations because stack looks largely the same).
That said, I couldn't find any meaningful optimizations (more that ~5% on Node.js). I suspect your hand-written lexer simply behaves better that what is generated from the async-function in my case :)

As for next steps - I'm literally indifferent as to which implementation ends up on master - as long as any does :) As you are the maintainer, the choice is yours (and your colleagues). The code in this PR is also yours to use as you see fit - e.g. for integrating your library if that speeds up development and such is the choice. Just let me know ;)

One final question: would it make sense to re-write this part in Rust? Since it looks like parsing EngineData might take a large portion of total design parsing time.

Thank you. I handled the situation poorly, and will not make the same mistake again.
I doubt parsing EngineData would be appropriate for Rust conversion. Decoding layer images is usually the most time- and memory-intensive task by far (hundreds of milliseconds per layer). Parsing an EngineData document with JS takes < 1ms when optimized, and I doubt Rust+WebAssembly would have a noticeable impact.

Ran some benchmarks; looks like for overall file opening process your parser provides a significant speedup:

Command
Mean [s]
Min [s]
Max [s]
Relative

cat samples.txt | xargs node parse.mjs scoiatael
6.868 ± 0.086
6.727
7.014
1.14 ± 0.05

cat samples.txt | xargs node parse.mjs pastelmind
6.049 ± 0.262
5.682
6.361
1.00

(where parse.mjs is here, Node is v18.2.0 and hardware is CPU: 11th Gen Intel i7-1185G7 (8) @ 4.800GHz)
@pastelmind Maybe the simplest way forward it to just merge this PR and then replace my implementation with yours?

@pastelmind had some spare time and managed to find pretty substantial optimizations; right now the results are:

Command
Mean [s]
Min [s]
Max [s]
Relative

cat samples.txt | xargs node parse.mjs scoiatael
4.793 ± 0.076
4.677
4.899
1.00

cat samples.txt | xargs node parse.mjs pastelmind
5.889 ± 0.052
5.815
5.977
1.23 ± 0.02

memoize results for each character instead of lookup

refers to STRING_TOKEN_JT - which pre-computes a boolean value for each character instead of doing two map lookups at runtime :) It was originally intended to be a specialized jump-table (hence JT suffix) but turned out that simple boolean array works best for this case.

It seems that avoiding unnecessary memory allocations greatly boosted your lexer's performance.

If you are referring to using Array instead of Generator then not really - I did it just to have clean demarkation line when benchmarking with 0x. This change can be easily reverted if we ever start to run into memory issues :)


Event  Emitter Support

Hi there,
Is there any way this library works with event driven approach? https://docs.nestjs.com/techniques/events
In the documentation they specifically state that "Event subscribers cannot be request-scoped." and your library is request-scoped. But I just want to make sure that there is a way or not.
Thank you!

Thank you @sandeepsuvit I'll follow that issue


Allow more consumers that partitions for a balanced consumer

Addresses issue: https://github.com/Parsely/pykafka/issues/527

Thanks @vitalyli, this is a good start. For this to be merged, the test will need to be runnable in Travis. That means it should probably avoid creating new threads wherever possible, since daemon threads can cause Travis to hang. Producing 10000 messages will probably make test runs take much longer than they need to. Additionally, this test only barely verifies that there are no crashes in the code you've written, but since there are components running on separate threads, crashes aren't guaranteed to be visible to Travis.
I suggest moving your test case to test_balancedconsumer.py, removing the use of threads, having it send only the minimum number of messages necessary to verify that consumers above the partition limit do indeed idle, and adding some self.assertTrue calls that ensure that extra consumers are able to start consuming if a space in the group opens up.
Broadly, this is the logic I'd think would be required for a test of this functionality (pseudocode):
# produce some test messages to 2-partition topic

c1 = topic.get_balanced_consumer(group)
c2 = topic.get_balanced_consumer(group)
c3 = topic.get_balanced_consumer(group)

# verify that the first two consumers can consume correctly
m1 = c1.consume()
m2 = c2.consume()
self.assertNotEqual(m1, None)
self.assertNotEqual(m2, None)

# verify that the last consumer doesn't get any messages
m3 = c3.consume()
self.assertEqual(m3, None)

# verify that the last consumer can start consuming if some partitions become available
c2.stop()
m2 = c2.consume()
m3 = c3.consume()
self.assertEqual(m2, None)
self.assertNotEqual(m3, None)

This is a high-level view of what I think the test for this change needs to look like.

@emmett9001 I'm not really familiar with travis and quite new to this project; literally spent one day banging my head against Kafka and found what works on my actual cluster. The test is by no means exhaustive. I'm in a process of setting up 10 or 20 dockers on ten machines; I will verify it there, but it will take a bit longer. If you guys want to take it over and make a better test for it, I'm ok closing this PR.

@vitalyli Sounds fine, thanks for being so responsive. Of course, if you find that this change works in your own environment, you can certainly run a forked version of pykafka until this change makes it into a proper release. Even with the test being finished right now, it would probably take a few weeks to cut a new release. I'll prioritize this for the next time I do some work on open issues.

Sounds good thanks!


Blog post on using IPFS with Docker

hey @kyledrake thanks for writing this! i'll do a quick review shortly.

Here's where I got with the part 2:
Create a cluster of 3 IPFS nodes using CoreOS
Now, let's create a cluster of IPFS nodes using CoreOS and Vagrant. Install Vagrant, and then start by cloning coreos-vagrant:
git clone https://github.com/coreos/coreos-vagrant/

cd coreos-vagrant

echo '$num_instances=3' >config.rb

echo '$new_discovery_url="https://discovery.etcd.io/new?size=#{$num_instances}"' >>config.rb

echo '$update_channel="stable"' >>config.rb

cp user-data.sample user-data

sed -i "s|#discovery: https://discovery.etcd.io/<token>|discovery: `curl https://discovery.etcd.io/new`|g" user-data

vagrant up

Now we should have core-01, core-02, and core-03. Let's ssh to one of them and setup a working instance on all the machines:
vagrant ssh core-01

Let's construct a simple systemd unit that runs an IPFS docker container. Save this as ipfs.service in your home directory:
[Unit]
Description=My Service
After=docker.service

[Service]
TimeoutStartSec=0
ExecStartPre=-/usr/bin/docker kill ipfs
ExecStartPre=-/usr/bin/docker rm ipfs
ExecStartPre=/usr/bin/docker pull jbenet/go-ipfs:latest
ExecStartPre=/usr/bin/mkdir -p /home/core/ipfs
ExecStart=/usr/bin/docker run --name ipfs -v /home/core/ipfs:/data/ipfs -p 8080:8080 -p 4001:4001 -p 5001:5001 jbenet/go-ipfs:latest
ExecStop=/usr/bin/docker stop ipfs

Because etcd uses port 4001 locally (which is used for the IPFS swarm port by default), we need to change that in the config:
THIS IS THE PART I DIDN'T GET TO
Now load the config:
fleetctl load ipfs.service
fleetctl start ipfs.service

@kyledrake thanks! this help is super useful. It's even going to be a driving force for us to fix our bugs! \o/
let me know how we want to collaborate on these things. we can definitely do edits together-- i've given you write perms in this repo so you can push branches directly here. that way we can both push + pull from them.

@kyledrake

Create a cluster of 3 IPFS nodes using CoreOS

looks great! agree that should be its own post.
by the way, check out: https://github.com/ipfs/container-demos -- these arent done... but they're good starting points. maybe we can use these posts to polish those.

also, i can make a gif of running the docker container. i usually find gifs in blog posts really useful to see what's going on. i made this one -- but i aborted till we get a smaller/better/faster/stronger docker image -- should have it ready in next couple days, and i'll record a proper gif.

New gif:

I've updated with some of the suggestions and the gif.

@kyledrake awesome thanks! i'll take it from here.


obsolate documentation with examples

Deno: latest version
The examples not work anymore. The index.ts not export Kafkasaur as service, the Kafka looks rights.

https://github.com/KafkaSaur/kafkaSaur/issues/7


Upgrade Spire to use CSI driver

This bumps up the Spire helm chart for the latest release, and the helm chart also adds support for the CSI driver so that workloads no longer need to perform a hostPath mount. The chains patch was updated to use the driver.
Fixes #130, replaces #354
Signed-off-by: Brandon Mitchell<EMAIL_ADDRESS>

cc @developer-guy and @dentrax

CI will be fixed by #356

Everything seems ready for merge, is there anything left to do before merging it? @sudo-bmitch


enable detaching from draft connect

Running draft connect --detach will reexecute draft with draft connect --export. --export is a hidden flag and is meant to only be used by draft if invoked with --detach. --export instructs draft to dump the environment information for connection. Container logs are lost in the detached state.
Draft does not cleanup the detached process. The onus of cleanup is on the detacher, because draft is not a process manager. Re-running draft connect --detach will establish a new background draft tunnel.
Usecase:
/> eval $(draft connect --detach)
/> curl $EXAMPLE_GO_GO_SERVICE_HOST:$EXAMPLE_GO_GO_SERVICE_PORT
Hello World, I'm Golang!

sounds good. @squillace in the interest of time, would it be okay to follow up in another PR to document this?

absolutely. don't care about long elaboration, just something so that searching if you need it finds it. Shouldn't take a second.


DB restore Error: too_large, Reason: the request entity is too large

using "@cloudant/couchbackup":"2.0.0"
Hi I am trying to restore a earlier a sample database , _hitting 413 Request Entity Too Large: POST https://xxyyzz.cloudant.com/r_history/bulk_docs - Error: too_large, Reason: the request entity is too large
File size is 1.35 MB only
Any reason for this unusual behaviour? Are any additional settings required?
sample code:
couchbackup.restore(fs.createReadStream(file_path),dest_url,{parallelism: 2},function(err, ok) {
                if (err) {
                    console.log('Error in DB['+dbname+'] Restore '+err);
                    callback(err,null);
                } else {
                    callback(null,ok);
                }
            });

Hi @tsghosh,
Please note that the maximum request body size to an API request for Cloudant is 1MB. You will receive a 413 response code stating “the request entity is too large” if you exceed this.
Have you tried reducing the --buffer-size parameter? The default is 500.
Thanks.

Thanks


compare input (md5) for old results with new input (md5)

Worker should be provided with results previously calc stored using internal comp names. This would allow new worker to map results to correct indices

Closing this issue since model-level caching and a primitive worker-level caching have been implemented. See also #45


Subgraph pre-defined methods

Get tokens by factory ID
await sdk.getTokensByFactoryID([FACTORY_ID_STRING]);
query getTokenByFactoryID($factory_id: String!) {
  tokens(where: {factory_id: $factory_id}) {
    id
    factory_id
    release_type
    ...
  }
}

Get tokens by creator
await sdk.getTokensByCreator([CREATOR_ADDRESS_STRING]);
query getTokensByCreator($creator: String!) {
  tokens(where: {creator: $creator}) {
    id
    factory_id
    release_type
    ...
  }
}

Search properties
await sdk.searchProperties([SEARCH_TERM_STRING]);
query searchProperties($value: String!) {
  properties(where: {value_contains_nocase: $value}) {
    key
    value
    tokens {
      id
      factory_id
      release_type
      ...
    }
  }
}

List all minted tokens by owner
await sdk.getMintedByOwner([OWNER_WALLET_ADDRESS]);
query getMintedByOwner($owner: String!) {
  owner(id: $owner) {
    id
    tokens {
      token {
        id
        factory_id
        release_type
        ...
      }
    }
  }
}

Split out and moved over to discussions:
https://github.com/simpleweb/open-format/discussions/90
https://github.com/simpleweb/open-format/discussions/91
https://github.com/simpleweb/open-format/discussions/92
https://github.com/simpleweb/open-format/discussions/94


merge package from arlac77/npm-package-template

package.json

chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(engines<EMAIL_ADDRESS>chore(package): add xo from template
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

.travis.yml

chore(travis): remove node versions 10.14.1
chore(travis): add node versions 10.14.2

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #429   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          41     41
=====================================
  Hits           41     41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70aef5f...a27355e. Read the comment docs.

Coverage remained the same at 94.545% when pulling a27355e73e95d8548b367d0915970c7383b921b5 on template-sync-1 into 70aef5f29b82e2efe99d5ec4ca418298dd57b69d on master.


Set-Location unexpected behaviour with \ on network paths

When working with local drives I can enter \\ in a path and powershell understands that I really just meant 1:
set-location c:\windows\\system32
$pwd -eq "c:\windows\system32"

This is the same as Powershell 5. However, Powershell 5 also allowed this behaviour with network paths while powershell 7 doesn't.
Why is this useful? well, it just lets us be a bit lazy with string concat -
#easy to write, easy to read
cd "$base\foo\bar"
#hard to write, hard to read
cd (Join-Path $base "foo\bar")

Even if you don't agree with this behaviour, I think at the very least the operation should just fail instead of taking you to the path up to where the \ is.
Steps to reproduce
set-location \\localhost\c$\windows\\system32

Expected behavior
$pwd -eq "\\localhost\c$\windows\system32"

Actual behavior
$pwd -eq "\\localhost\c$\windows"

Environment data

Name                           Value
----                           -----
PSVersion                      7.0.1
PSEdition                      Core
GitCommitId                    7.0.1
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

This works well in both PowerShell. You should run with elevated permissions.

This works well in both PowerShell. You should run with elevated permissions.


Decodes url parameters

I found a little url parameter issue. In some other comparable non-crystal web frameworks, url parameters are decoded.
Here is an example comparing the response of ruby's sinatra with kemal.
Sinatra
# GET [HOST]/user/sam%2Btest%40gmail.com

get "/user/:email" do
  params["email"]
end

# Response body =><EMAIL_ADDRESS>
Kemal
# GET [HOST]/user/sam%2Btest%40gmail.com

get "/user/:email" do |env|
  env.params.url["email"]
end

# Response body => sam%2Btest%40gmail.com

Sinatra correctly decodes the url parameters. I have not used Sinatra in production, but I have a good amount of experience with the Node.js Express framework and I know that the url parameters are also decoded with Express.
Keep up the good work! 👍

Yeah, i wasn't aware of this. Thanks @samueleaton 👍 💯

Could you please add a spec for this exact scenario?

Added spec. All specs passed.

LGTM 👍


"dotnet restore" error

Is it expected that Net Core would generate the following error after typing dotnet restore on Windows 7?
dotnet new --lang F#
dotnet restore

log  : Restoring packages for e:\User\Projects\HelloWorld\NetCore\hello\project.json...
error: An error occurred while sending the request.
error: URL-address is not using a supported protocol
dotnet exited with error code 1

project.json:
{
    "version": "1.0.0-*",
    "compilationOptions": {
        "emitEntryPoint": true
    },

    "compilerName": "fsc",
    "compileFiles": [
        "Program.fs"
    ],

    "dependencies": {
        "Microsoft.FSharp.Core.netcore": "1.0.0-alpha-151221",
        "NETStandard.Library": "1.0.0-rc2-23811"
    },

    "frameworks": {
        "dnxcore50": { }
    }
}

The firewall is disabled

sorry, it seems the reinstalling of dotnet helps


Terms of use shows up in English on French page

Discrepancy on https://staging.covid-hcportal.cdssandbox.xyz/fr/terms/
Figma FR content: https://www.figma.com/file/znPqLTQQDcUkaNjdDcShiz/Exposure-Notification-Health-Portal?node-id=10043%3A84074
Update translations

Pull Request for this issue has been created - https://github.com/cds-snc/covid-alert-portal/pull/733

Merged in stage and production.


Check for null key in InstancePoolTrait

Sometimes getInstanceKey returns null and it messes the instance pool. I think it has something to do with the joinWith populating the related objects.

This happens when you are saving your entity while alreadyInSave, now that not saved entity will go into instance pool.
Now InstancePoolTrait::getInstanceKey will call your entity getPrimaryKey() which returns null, and will be casted to empty string, and saved into instance pool with empty string key. Messes things up.


Content missing or in error for Accessories pages

General CSS fixes are needed (bold, font size, some spacing, etc), but I will list what I think are content fixes here.

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/sprayguns

Missing the links to the repair manuals,
"Airless spray guns" should not appear in the "more accessories" section.

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/revtipspraytips

Table font should be 16, not 13 (will put this on the CSS issue)
"Rev tip spray guns" should not appear in the "more" section

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/hoses

"airless hoses' should not appear in the "more" section

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/extensions

Bryan already separated the 1 table into 2, but now there is a large gap. Need to fix the other languages for this product, the 2nd table's heading is missing and the tables are conjoined there.
Need to fix the table header font size, color, and weight -- this accessory is different than the others.

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/fluids

The first table needs to be separated into 2 so that MagiCLEAN CONCENTRATE is not missing,
The links and icons to the PDFs are missing
"Fluids" should not appear in the "more' section

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/filters

1st two itens, Prolight 500 gun filters and Manifold filters are both missing part numbers.
"filters" should not appear in the "More" section

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/striping

GRAVITY FEED GLASS BEAD DISPENSER missing a part number
"striping' should not appear in the 'More" section
SURE STRIPE TIPS is missing the Tip Size Chart

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/other

Replacement Pumps, GUN & HOSE CONNECTORS, Hose Cover sections are missing part numbers
"other" should not appear in the "More" list

http://localhost:3000/na/en/products/accessories/revtipspraytips needs "TIP SIZE CHART:" bolded in content. The rest I'm getting with CSS.

https://main--airlessco--hlxsites.hlx.page/na/en/products/accessories/revtipspraytips is missing "Fluids' in the "more accessories" section.

Finished content updates to na/en

Finished content update to emea/en

These are all fixed with the new import.


Manager interfering with ReactMeteorData

Hi, first thanks for this optimisation item without which I cannot imagine my applications to be. I have found a possible bug in the implementation, when subscription manager is interfering with "ReactMeteorData" mixin. I am attaching a minimal repro application.
The problem is, that if you use a component with subscriptions inside another component with subscriptions, it is invalidating the parent subscriptions, making them run twice or more. Example:
I have following components and only parent has subscriptions:
<Parent>
<Child>
</Parent>
If I put following line inside paren's "render" method console.log("With: " + this.data.posts) where data is fed with following method:
getMeteorData() {
    this.data = { }
    var handle = subs.subscribe("posts");
    if (handle.ready()) {
      this.data = {
        posts: Posts.find().fetch()
      }
    }
    return this.data;
  },

The output is following as expected:
With: undefined
With: undefined
With: [object Object],[object Object],[object Object]

Now I add another subscription inside child component as following:
  getMeteorData() {
    this.data = { }
    var handle = subs.subscribe("user", this.props.post.uid); // Replace with Meteor.subscribe and all is good
    if (handle.ready()) {
      this.data = {
        user: Usrs.findOne({uid: this.props.post.uid})
      }
    }

    return this.data;
  }

Output becomes:
With: undefined
With: undefined
With: [object Object],[object Object],[object Object]
With: undefined
With: [object Object],[object Object],[object Object]

Somewhere there, the subscription invalidated meteor data and it ran again creating havoc in the application. Please note, that when I replace subs.subscribe with Meteor.subscribe all is running as expected and data is not invalidated.
Example minimal app is here 6Kb.

Yes. I can understand the issue. I think it's hard to mitigate this unless, you create two instances of subsManagers to each component.
I've added some notes here: https://goo.gl/9PeI1Q

Thanks! Just a question regarding performance .. .will that affect subsmanager performance if I will be creating a new instance of subs manager per each subscription? Will that interfere with its functionality ?
Thanks.

Nope. It create caches separately.
On Fri, Sep 18, 2015 at 7:25 AM Tomas Trescak<EMAIL_ADDRESS>wrote:

Thanks! Just a question regarding performance .. .will that affect
subsmanager performance if I will be creating a new instance of subs
manager per each subscription? Will that interfere with its functionality ?
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/kadirahq/subs-manager/issues/55#issuecomment-141306044
.


Having Sparkpy Import Error

Hey Paul not sure if I'm doing something wrong but when trying to spin up my errbot using Spark as the backend I'm getting:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/errbot/bootstrap.py", line 135, in setup_bot
    bot = backendpm.get_plugin_by_name(backend_name)
  File "/usr/local/lib/python3.5/dist-packages/errbot/specific_plugin_manager.py", line 86, in get_plugin_by_name
    raise Exception('Error loading plugin %s:\nError:\n%s\n' % (name, formatted_error))
Exception: Error loading plugin Cisco Spark:
Error:
<class 'SyntaxError'>:
  File "/usr/local/lib/python3.5/dist-packages/Yapsy-1.11.223-py3.5.egg/yapsy/PluginManager.py", line 488, in loadPlugins
    candidate_module = imp.load_module(plugin_module_name,plugin_file,candidate_filepath+".py",("py","r",imp.PY_SOURCE))
  File "/usr/lib/python3.5/imp.py", line 234, in load_module
    return load_source(name, filename, file)
  File "/usr/lib/python3.5/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 693, in _load
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 665, in exec_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/home/bhopkins/err-backend-cisco-spark/backend/cisco_spark.py", line 8, in <module>
    import sparkpy
  File "/usr/local/lib/python3.5/dist-packages/sparkpy/__init__.py", line 10, in <module>
    from .spark import Spark

Any ideas what is going on here by chance?  I installed sparkpy from your git repo archive.

Hi,
You can fix that with this workaround: https://github.com/Bassintag/spark-python-sdk/issues/1
(but on my side I've another issue after fixed that: self.spark = sparkpy.Spark(config.BOT_IDENTITY), https://github.com/panholt/err-backend-cisco-spark/issues/10)


feat: improve jsdocs

Please describe the changes this PR makes and why it should be merged:
https://github.com/Garlic-Team/gcommands/issues/412
Status and versioning classification:

This PR only includes non-code changes, like changes to documentation, README, etc.

Should this not include jsdoc for all files?

It will, it's draft

Please review @S222em . I'll finish the others in time, but not to delay v9.2.0 unnecessarily and at least have JSDocs on some properties.


[beta] Unclear instructions/tests for "Coding Interview Data Structure Questions: Create a Set Class"

Challenge create-a-set-class has an issue.
It's unclear whether or not the add() method should return a boolean indicating whether or not it added the item to the set.
This challenge passes without returning a boolean, but the challengeSeed of the next challenge returns booleans. This could cause confusion.
If we want to return a boolean status from add(), I think we need additional tests for it and possibly mention something in the instructions.

Hi, could I work on this?

@Greenheart Hi, could I work on this?

@jamos-tay Sure! :smile:


New version release info

It's been over 10 months since the last release. Can we when the next version would be released?

Note, the documentation around POS Tagger is now out of date on Github (Github and source code use 'EN' and 'DU" tags while the published 0.6.3 version requires putting together a filepath).

Is there a workaround for the 'EN' error?  When I try the POS tagger example, the RuleSet seems to give an error.  Thanks.
var ruleSet = new natural.RuleSet('EN');

{ Error: ENOENT: no such file or directory, open 'EN'
at Object.openSync (fs.js:443:3)
at Object.readFileSync (fs.js:343:35)
at new Lexicon (C:\omni\Node\vmaud\server\node_modules\natural\lib\natural\brill_pos_tagger\lib\Lexicon.js:29:21)
...

I will push a new version to NPM soon now.

Pushed a new version to NPM. It is a major release to 1.0.0 because of breaking changes in the use of external files.


Default methods

This implements #1.
However, I'm not entirely happy with it. It gets the job done, but I suspect several problems will happen:

It'll probably accept more than it should (eg. having default! { fn stuff(&self) { println("Hello world"); } }).
If the inside of default is not syntactically correct, it'll panic instead of providing nice error message with all the arrows pointing at it, etc.
I'm not sure if my approach of faking impl methods and feeding them to the rest of the code is really elegant.

Therefore, I'd appreciate some high level hint into what direction to improve it, how to do the error handling better. Or a link / recommendation to some other crate I could get inspired with.
Thank you

Thanks for the hints, this seems to be working nice :-).
Indeed, once I get used to the proc macros a bit, all the tooling around it looks almost elegant.

Published in 0.1.2.


Hardcore Buckets don't work with Clay Buckets

Clay Buckets mod can place water in the world, tested on latest for 1.10.2

Yeah, looks like it's using the old version of fluid handling, which we aren't really looking for.

info saved here


[BUG]: DockerInstaller@0 keeps getting intermittent certificate error

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
DockerInstaller
Task version
0.238.1
Issue Description
Intermittently we are seeing the error unable to get local issuer certificate when attempting to download the docker cli. Running the task again generally fixes it but it seems to be happening more frequently then previously
Environment type (Please select at least one enviroment where you face this issue)

[X] Self-Hosted
[ ] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
n/a
Operation system
Ubuntu 22.04
Relevant log output
Because it is intermittent it is hard to get debug logs but i will try

Downloading: https://download.docker.com/linux/static/stable/x86_64/docker-26.1.1.tgz
##[error]Error: Failed to download Docker from location https://download.docker.com/linux/static/stable/x86_64/docker-26.1.1.tgz. Error Error: unable to get local issuer certificate
    at TLSSocket.onConnectSecure (node:_tls_wrap:1674:34)
    at TLSSocket.emit (node:events:518:28)
    at TLSSocket._finishInit (node:_tls_wrap:1085:8)
    at ssl.onhandshakedone (node:_tls_wrap:871:12) {
  code: 'UNABLE_TO_GET_ISSUER_CERT_LOCALLY'
}

### Full task logs with system.debug enabled

<details>
  <pre> Downloading: https://download.docker.com/linux/static/stable/x86_64/docker-26.1.1.tgz
##[error]Error: Failed to download Docker from location https://download.docker.com/linux/static/stable/x86_64/docker-26.1.1.tgz. Error Error: unable to get local issuer certificate
    at TLSSocket.onConnectSecure (node:_tls_wrap:1674:34)
    at TLSSocket.emit (node:events:518:28)
    at TLSSocket._finishInit (node:_tls_wrap:1085:8)
    at ssl.onhandshakedone (node:_tls_wrap:871:12) {
  code: 'UNABLE_TO_GET_ISSUER_CERT_LOCALLY'
}
</pre>
</details>

### Repro steps

```yml
# can use any version i've seen it happen on 26.1.1 25.0.5 and a 17.x.x version
  - task: DockerInstaller@0
    displayName: Install Docker
    inputs:
      dockerVersion: 26.1.1

I have this with githubcomment@0 even when AGENT_CAINFO is set in env to the task.

We ended up finding an issue with cisco umbrella that was causing our intermittent failure. This has been resolved for me. @b0bu i'm going to close the issue if you want to reopen one with more info for you case.

I literally just messaged to fix it but thanks for the update, glad yours is resolved. For me adding:
NODE_EXTRA_CA_CERTS: path/to/certs. crt
Has worked


Invalid TS module names when protofiles contain dots or dashes

From https://github.com/grpc-ecosystem/protoc-gen-grpc-gateway-ts/issues/42
Fix is implemented in this PR: https://github.com/grpc-ecosystem/protoc-gen-grpc-gateway-ts/pull/43/files

Closed by #20


:sparkles: ArcDPS enums

I was going todo the entirety myself, then I noticed Elite Insights had already copied them over nicely.
I went ahead and asked them to use the file. I was kindly notified by the MIT License in their repo. Source is in the docs.
Wired up and ready.
Might want to exclude that file from codefactor if we were to just keep it up to date with theirs. It's a nice resource and they are a group working on finding the ids and stuff

Does Gw2-Elite-Insights Parser have a NuGet package or anything that it deploys that would expose this same stuff to us?  That would be preferred over manually copying over the classes, but not entirely sure what all they have set up or if it's just a UI application with the API stuff not split out.

Looks good to me.  Thanks for revising the formating!


[Feature] Allow data contributors to specify keywords to improve challenge search results

What product(s) is this feature for?
OpenChallenges
Description
We are currently indexing the following challenge elements for the challenge search:

title
headline
description

We use the default tokenizer, which identify tokens using spaces and slashes. More importantly, searching for a substring doesn't work unless the substring appears as a token at least once in the above elements.
The goal of this ticket is ticket is to allow the registration of extra keywords/tokens for challenges.
The keywords are only supported at the entity level so no changes will be made to the API spec, API clients or web app.
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

It looks like Elasticsearch is also using parenthesis and dash as separators when tokenizing. For example, searching for "smc" will return this challenge, which does not include "smc" as a token separated by other known separators.

I reviewed the different search issues I could remember/think of. The search results look great and there is no need to make any improvement at this point.
If we feel the need to one day, we could add an additional property to challenge to the data model similar to the HTML keywords metadata property.
<meta name="keywords" content="HTML, CSS, JavaScript">


Fixing the Is check for console scope activation object

While checking whether an activation object is console scope or not we were not checking it for the cross context object.

@akroshg @agarwal-sandeep Can you please take a look?

Do you have a test case for full repro?

@dotnet-bot test Ubuntu shared_ubuntu_linux_test please


ebiten: change []uint16 to []uint32 for indices at DrawTriangles and DrawShaderTriangles

Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?
This is a related change to #2612. Now Ebitengine internal uses []uint32 for indices, we should be able to use []uint32 for indices as public APIs instead of []uint16.
As this is a breaking change, let's do it in v3.
Why is this needed?
No response

I'll add some context since it's missing in the description:

Why is this needed?

To avoid a full-slice copy. When using DrawTriangles for batch drawing, the indices slice will be re-used on the caller side and it can be quite large (let's say maxUint16/10 elements or so for a particle system is not a rarity).
When these indices are passed to the DrawTriangles as uint16, Ebitengine internally creates a slice of uint32 of the same length and copies everything in there. We can hypothetically get rid of this step if the input argument type is []uint32. Then there would be no extra data copying/allocation in the DrawTriangles method.
I started to use DrawTriangles recently and it's very useful for several stuff, but my most favorite ones are:

batch-drawing of the same image and different positions (great for particle systems)
shader-oriented drawing when we don't need an input image, but want to draw using the shader itself

There is a way to enable this optimization without breaking the API and it involves Go build tags. I'm not recommending it, but it's just an idea.

Document some build tag, like ebiten_uint32
Introduce build-tag protected files, we need two (one for uint32 and one for uint16)
Use our new function in DrawTriangles

Here is how it could look like:
//go:build ebiten_uint32
package ebiten

type Indice = uint32

// This conversion is no-operation, it just returns the slice.
// No allocations, no data copying.
func convertIndices(indices []Indice) []Indice {
  return indices
}

//go:build !ebiten_uint32
package ebiten

type Indice = uint16

// This is how it behaves by default.
func convertIndices(indices []Indice) []Indice {
  is := make([]uint32, len(indices))
  for i := range is {
    is[i] = uint32(indices[i])
  }
  return is
}

And then in DrawTriangles:
- is := make([]uint32, len(indices))
- for i := range is {
-   is[i] = uint32(indices[i])
- }
+ is := convertIndices(indices)

The signature will change textually, but it will be 100% compatible with the current API.
- DrawTriangles(vertices []Vertex, indices []uint16, img *Image, options *DrawTrianglesOptions)
+ DrawTriangles(vertices []Vertex, indices []Indice img *Image, options *DrawTrianglesOptions)

There could be other ways, like adding a new transitional function that can be used before the older API is changed; but that would increase the public API surface which is bad (we would need something to do with these new functions later).
@Zyko0 may have something extra to add.
I would also like to invite @tinne26 for the discussion.

I'm writing this message for the second time as my laptop decided it's time for a quick reboot
and GitHub doesn't feel like saving any unsent comments.
But anyway. I want to add some context to this issue.

Why is this needed?

DrawTriangles internally copies the []uint16 slice as []uint32.
It can affect performance for both use-cases that I think are important for draw triangles style API:

Drawing a single (quad?) shader-style object (e.g. a shader-rendered circle)
Drawing a batch of images (important for a particle system)

In the first case the slice will be small, but it will mean that the DrawImage can manage
to do the job with ~0 allocations (as it uses slice pools for some other stuff, etc.) while
draw triangles needs at least 1 allocation for this slice.
In the second case the slice can be as large as maxUint16/10 and so on, because particle
systems can emit tons of objects that should be very lightweight.
Overall, it's both a performance reason and a logical next step for the internal transition for uint32 (so we don't have to convert stuff).
Now, how can we do it before v3? I can give one idea that I came up with; I'm not sure it should be used, but I'll share it anyway.

Document some kind of a build tag, e.g. ebiten_uint32
Introduce 2 new build tag-protected files (ebiten_uint32=true and ebiten_uint32=false)
Use a new function from that file

//go:build ebiten_uint32
package ebiten

type Index uint32

func convertIndices(indices []Index) []Index {
    return indices
}

//go:build !ebiten_uint32
package ebiten

type Index uint16

func convertIndices(indices []Index) []Index {
    is := make([]Index, len(indices))
    for i, x := range indices {
        is[i] = uint32(x)
    }
    return is
}

Change the DrawTriangles a bit:
- is := make([]uint32, len(indices))
- for i := range is {
- 	is[i] = uint32(indices[i])
- }
+ is := convertIndices(indices)

The signature will change textually, but it will be compatible:
- DrawTriangles(vertices []Vertex, indices []uint16, img *Image, options *DrawTrianglesOptions)
+ - DrawTriangles(vertices []Vertex, indices []Index, img *Image, options *DrawTrianglesOptions)

CC @Zyko0 @tinne26

Then there would be no extra data copying/allocation in the DrawTriangles method.

I think Hajime always prefers safety in these cases, so even if we pass a slice, it would still be treated as read-only and copied at least once, no? I'm also unfamiliar with all the checks for triangles merging and so on, so I'm not sure how much of a difference this all ends up amounting to.
I'm obviously in favor of the change from []uint16 to []uint32, but I don't think a build tag temporary solution is warranted without actual benchmarks showing that you can put out >10% more triangles per second or something like that after the improvement. Hajime was considering moving to v3 earlier due to the amount of deprecated code and stuff that's been accumulating with all the improvements, so I'd rather avoid adding even more things to this pile.
And I've said this multiple times, but the more Ebitengine grows, the more we are starting to have these optimization related issues, but there's still no benchmark suite for Ebitengine. If we want to keep pushing in this direction, we need a better foundation (I'm also saying this due to issues like #3023 that Hajime has been acknowledging himself while working on commercial projects).

I'm working on a particle system and I have some numbers that we can also compare with Godot particle system in terms of "the number of particles we can render until FPS starts to decrease".
I can measure the benefits that we can get if that copy can be avoided. Although if the copy will happen anyway, I'm not sure if I need to do that extra effort measuring and comparing stuff.

Wouldn't https://github.com/hajimehoshi/ebiten/pull/3026 mitigate your issue to some extent?

Another reason is that uint32 allows more vertices/indices to be submitted at once than uint16 (in the case of particles, it might matter)


RFC: Reject output lifetime elision with bound lifetimes in scope

The discussion in https://github.com/rust-lang/rust/issues/17822 raised some issues with the usability of output lifetime elision when there are bound lifetimes in scope. This RFC proposes to reject such programs, forcing the user to explicitly specify output lifetimes.
Rendered

ping @wycats @nikomatsakis @pnkfelix

I'm going to close this RFC; there hasn't been sufficient will to do this prior to beta, and at this point it would need a very strong impetus to justify the breakage in the short time we have left before 1.0.

@aturon do you think a lint that generates a warning could still be justified here (and since it is just a warning, it could land at any point, not necessarily before 1.0 release) ?

@pnkfelix I don't, personally; I haven't seen evidence of this form of elision actually causing problems in practice. The current setup is very simple and consistent in terms of how output lifetimes are determined (from any single input lifetime, or from &self if there are multiple), and using those outputs is often what you want even in this context.
If we start getting a lot of reports that this is a foot-gun in practice for people, we could consider a lint at that point.


Introduce versioning.

It seems very likely that the standard will change over time, especially now, and it would be smart to ensure that both library maintainers and users can conform to those changes. Perhaps introduce a MetaData object/field for the schema which can include such information.

readme even mentions the standard will change over time - versioning seems important!

absolutely

addressed with "version" field in latest commit https://github.com/VestboyMyst/openbracketformat/commit/d65519c47410e0fb0061e842dd829234ef85a030


[vault-secret-webhook] vault-agent container with runAsUser 100 fails to spawn on OpenShift

Describe the bug:
In OpenShift the vault-secret-webhook injects the init-container vault-agent with the securityContext "runAsUser: 100".
This is by default not allowed and you have to set the scc (security context contraint) anyuid to the service account which runs the pod.
Expected behaviour:
The webhook should respect the uid range of the namespace or the security context "runAsUser" should be removed.
Steps to reproduce the bug:

Install the Webhook
Deploy the sample application from documentation

Additional context:
The runAsUser part is hard-coded in file "cmd/vault-secrets-webhook/main.go" at line 120.
Environment details:

OpenShift 3.11
helm template ... | oc apply -f -
Logs from the misbehaving component (and any other relevant logs):

/kind bug

fixed by #698


[Clarification request/Improvement] Add version and github info always, also when --enable-debug was missing

I know, that tesseract --version outputs the exact version and github commit hash, if it was compiled with ./configure --enable-debug, example:
tesseract 4.00.00alpha-278-gc768b58
 leptonica-1.74.1
  libjpeg 6b (libjpeg-turbo 1.3.1) : libpng 1.2.50 : libtiff 4.0.3 : zlib 1.2.8

 Found AVX
 Found SSE

I wonder, why this is not output, when the configuration setting was not given and I suggest to modify the build code so that the version and github commit hash is always shown with the --versioncommand.

Yes. I agree, adding version info with github commit hash in non-debug builds will be very helpful.
An earlier request - https://github.com/tesseract-ocr/tesseract/issues/581#issuecomment-267339390

Needs change in
https://github.com/tesseract-ocr/tesseract/blob/fd0683f9e03934bbdf7fbebb4d21d64c37b68bc0/api/baseapi.cpp#L140

Duplicate to #581

@zdenop Is https://github.com/tesseract-ocr/tesseract/blob/fd0683f9e03934bbdf7fbebb4d21d64c37b68bc0/api/baseapi.cpp#L140 the only change needed, and would you accept a corresponding pull request ?

I am against to show GIT_REV in release mode:

Experienced users/testers should know what they are doing, what their are testing
Inexperienced users should use released stable version

@zdenop Where exactly is your problem to print the GIT_REV when users use --version ?
I *have a problem when, as an expert, I run always the latest version, but sometimes after git pull the latest build is not the "installed" build. As a user I want to have the fastest code, i.e. built without --enable-debug.
I again request to think over it, and to always - if available - burn the GIT_REV into the code. I ask you for this.

Not using --enable-debug increases processing speed about 6%.

@zdenop, what about using GIT_REV only for versions without tag, no matter whether it is a debug or a release build? Then released stable versions would not show GIT_REV.

Not using --enable-debug increases processing speed about 6%.

Only ~6%? With LSTM mode?
https://github.com/tesseract-ocr/tesseract/issues/40#issuecomment-263432042

BTW, maybe we should add another debug/optimization option -Og?
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html

#!/bin/bash
# git rev-list  `git rev-list --tags --no-walk --max-count=1`..HEAD --count
revisioncount=`git log --oneline | wc -l`
projectversion=`git describe --tags --long`
cleanversion=${projectversion%%-*}
#echo "$projectversion-$revisioncount"
#echo "$cleanversion-$revisioncount"
sed -i -e 's/.*TESSERACT_VERSION_STR.*/#define TESSERACT_VERSION_STR "'"$cleanversion-$revisioncount"'"/g' ./api/baseapi.h

can be used to update the TESSERACT_VERSION_STR with the latest commit #.

This has now been implemented.```
tesseract -v
tesseract 4.0.0-beta.1-59-g2cc4
leptonica-1.76.0
libjpeg 8d (libjpeg-turbo 1.3.0) : libpng 1.2.50 : libtiff 4.0.3 : zlib 1.2.8
Found AVX
Found SSE

Please check with latest code from master and close the issue.

I tried to build the new master version but make stopped with
libtool:   error: REVISION '00' must be a nonnegative integer
libtool:   error: '4:00' is not valid version information

How are you trying to build? I used the following today, without any problem.
#!/bin/bash
./autogen.sh
./configure --disable-openmp  --disable-graphics --disable-opencl
make
sudo make install
sudo ldconfig
make training
sudo make training-install

make distclean
git pull upstream master
./autogen.sh
./configure
make

@stweil Please see make error above.

@Wikinaut, it looks like you are using git, but your latest tag does not match the expectations (MAJOR.MINOR.PATCH with MAJOR, MINOR and PATCH being numerical values, maybe followed by additional non-numeric characters). The latest tag should be 4.0.0-beta.1. What do you get if you run git describe --abbrev=4?

I just built the master branch, as usual.

@stweil have a look (I just updated this above) to the make output
libtool: link: ( cd ".libs" && rm -f "libtesseract_api.la" && ln -s "../libtesseract_api.la" "libtesseract_api.la" )
/bin/bash ../libtool  --tag=CXX   --mode=link g++  -g -O2 -std=c++11 -L/usr/local/lib -llept  -version-info 4:00 -no-undefined   -o libtesseract.la -rpath /usr/local/lib  libtesseract_api.la ../ccmain/libtesseract_main.la ../textord/ltesseract_textord.la ../wordrec/libtesseract_wordrec.la ../classify/libtesseract_classify.la ../dict/libtesseract_dict.la ../arch/libtesseract_arch.la ../arch/libtesseract_avx.la ../arch/libtesseract_avx2.la ../arch/libtesseract_sse.l../lstm/libtesseract_lstm.la ../ccstruct/libtesseract_ccstruct.la ../cutil/libtesseract_cutil.la ../viewer/libtesseract_viewer.la ../ccutil/libtesseract_ccutil.la ../opencl/libtesseract_opencl.la  -lpthread
Especially to -version-info 4:00. Is the colon correct?

@Wikinaut, your local git has the latest code, but not the latest tags. It still uses the old tag 4.00.00dev. Are you pulling from your personal fork (where the tag might be missing)? If you pull from tesseract-ocr, you should automatically get the latest tag, unless you have disabled that in your git settings. Try git pull --tags to force pulling all tags.

The error message which you see comes from  -version-info 4:00. It should be  -version-info 4:0.

What info do u see for git remote -v?

@Shreeshrii
origin  git@github.com:Wikinaut/tesseract.git (fetch)
origin  git@github.com:Wikinaut/tesseract.git (push)
upstream        https://github.com/tesseract-ocr/tesseract.git (fetch)
upstream        https://github.com/tesseract-ocr/tesseract.git (push)

Try git pull --tags to force pulling all tags.

and then

run git describe --abbrev=4

git fetch --all --tags, then we are sure that you won't miss a tag. :-)

ok, works now.
Result as wanted:
tesseract -v
tesseract 4.0.0-beta.1-59-g2cc4
 leptonica-1.75.3
  libjpeg 6b (libjpeg-turbo 1.5.1) : libpng 1.2.50 : libtiff 4.0.8 : zlib 1.2.8

 Found AVX2
 Found AVX
 Found SSE

Closing this as solved, thanks.

tesseract 4.0.0-beta.1-59-g2cc4

@stweil, according to the semver 2.0.0 spec, there should be only one -. The rest should be replaced by dots.
BTW, from where the field before the commit hash comes from?
(59 here)

I think that is number of commits since last tag, beta.1
On Thu 29 Mar, 2018, 12:04 AM Amit D<EMAIL_ADDRESS>wrote:

tesseract 4.0.0-beta.1-59-g2cc4
@stweil https://github.com/stweil, according to the semver 2.0.0 spec,
there should be only one -. The rest should be replaced by dots.
BTW, from where the field before the commit hash comes from?
(59 here)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/issues/723#issuecomment-376990723,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2_o0bZI9uMx1qCMxYsmdDjOPypNc7sks5ti9fDgaJpZM4MDsWM
.

4.0.0-beta.1-59-g2cc4 is not a semver tag, so I don't think that the semver spec applies here.
As @Shreeshrii already said, 59 is the number of commits since the last tagged version. The 'g' before the hash might stand for 'git'.


Create sample.txt

@shaynafinocchiaro: Thank you for submitting your pull request!
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.


Better browser luncher 🌎

This PR fixes uncaught exception when Haul tries to open Google Chrome and fails.
I'm using Google Chrome Canary as my primary browser and I don't have a Google Chrome even installed. I introduced new dependency which based on the platform tries run command. If all attempts are unsuccessful, Haul print a warning about it.

Damn, @jukben, you're hungry 😛

Wait with the merge, I noticed that opn is async. I need to fix a code a little bit. 🤦♂

Coolio


Terragrunt support

Are you planning to add Terragrunt support?

I'm not a Terragrunt user myself, so I can't say if I'll get to that in the foreseeable future.
If we add it to our repertoire later on (at work, that is), I'll definitely consider it.

At the moment I change all the terraform commands in the main (3 places) to terragrunt.
built with:

edit the version in pyproject.toml
run pip install build
run python -m build
run pip install ./dist/tftui-1.0.0.tar.gz (with your version)

good luck

Perhaps adding a flag to toggle it to use terragrunt instead of terraform would be an easy permanent fix?  tftui -T or something?

Submitted a PR for this: https://github.com/idoavrah/terraform-tui/pull/30

Released version 0.5 that adds support for terragrunt (simply add/alias the '-e terragrunt' switch).
Thanks @jonwtech :)


add test for nested property invalidation

My understanding was off here - the internal variable must be live (terminated in a renderer) for upstream values to be resolved, and upstream value resolution is necessary in order to detect (re-)invalidation.


missing source code

Hi, May I ask that where can I find hateful_meme_feature.py used in run_feat_extract.sh. I cannot find the code in both this repo and py-bottom-up-attention.

It is located in the package branch of the py-bottom-up-attention repo, you can find it over here


Concatenation seems to be using a cache

When I pipe my filtered javascript files into concat, it seems to use a cached version because none of my changes are there.
If I don't concatenate them, the individual files are correct.
Any ideas?
edit:
Sorry, that wasn't very instructive. I forgot to mention I have:

deleted my destination files to make sure that the file is a fresh version
I have drastically changed the files ( removing 90% of the content )
I have deleted my npm folder
updated to the current version
Made a new gulp task which pipe all filtered JS into a new folder, and another function to read that folder for all js to concatenate
Output concatenated file to separate folder.

SORRY!
It was working as expect.
I had 2 data sets that are very similar being concatenated and I was checking the wrong one.


Current interview (Naomi Chan) link broken

Hi, apologies if I'm posting this in the wrong place, but I just clicked on the interview link on the homepage (https://diversity.p5js.org/feature/naomichan.html) and found that it was returning a 404.
It seems like the right person to notify might be @chellyjin.

thanks! we're in the process of archiving the pages from that series, and a new link should be available soon. sorry for the trouble. in the meantime, you can check out the interview video here: https://www.youtube.com/watch?v=y_U72iF1ws8


Starting connecting to currency && network information

About nitializing a new account and connecting it to the network. I suppose we should create an account in one tab (ID,...), and have another tab where we can write and read information about the network (URL, port, connected peers, other information...).
The same tab should be available at any time in "preferences", or elsewhere, to be able to see the network information, perhaps like it is in the webdemo : http://www.metab.ucoin.io/#/tech . I guess like something we have in Qbittorrent P2P interface : http://basunerat.se/wp-content/uploads/2013/04/qb111-300x232.png

https://github.com/ucoin-io/cutecoin/commit/16d64dda283c04985524abbd37ee27f03420f66a


Re rendering of Boxes

Boxes can now be "re rendered" by aligning them to the top of the terminal

Hi, thanks for this PR! I would like to know the need to implement this so that I can consider this for https://github.com/Delta456/box-cli-maker/issues/26

I'm trying to create a timer-like CLI app. The timer needs to update the displayed time in the same box without creating a new box below the previous one.


How do I click on something that isn't a link?

I'm trying to click on an SVG element – it is not a button or a link, so Capybara doesn't like it.
I can query for the element using element = response.css('.available') but I can't seem to click on it using
browser.click(element) – I think it would work if it were a capybara element, not a nokogiri element.
How do I get from the Capybara::Session to a Capybara::Page or Capybara::Node so I can execute .click on it?

I very quickly answered my own question:
browser.find(:css, "div#map .available", wait: 1).click


Istio Standard metrics drill down to pod name

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
Currently, I believe it's only possible to evaluate standard Istio metrics down to the service/ canonical service level (ex: istio_request_duration_milliseconds).
Identifying the specific pod affected will allow more granular troubleshooting and rolling up latency per pod, rather than service.
Describe alternatives you've considered
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Prometheus adds the pod name  when it scrapes a metric


issues on playing on mobile phones

@sampotts
i got some issues on smartphones with playback youtube videos. somethimes they wont play! they just show the youtube play icon when i click on that icon the loading circle is turning and turning but no playback... this happens only on smartphones. any ideas?
Thank you.

When i activate full-screen mode on my smartphone, parts of the video may get cut off because the screen stretches too much. this does not happen on regular yt-player but only on plyr-player. any help?

I've commented regarding the control we have over the YouTube quality, on the other issue you commented on. Closing this one.

@sampotts
i got issues on smartphones with playback youtube videos. somethimes they wont play! they just show the youtube play icon, when i click on that icon the loading circle is turning and turning but no playback... this happens only on smartphones. any ideas?
(This has nothing to do with quality check)
Thank you.