Add posibility to update concrete node pool

Since 0.9.4 there is new implementation of node pools. And it's not possible to update only concrete node pool. We experienced weird behaviour when we adding / removing / updating node pool. When we run kube-aws update ... all node pools (worker autoscaling group) initiate update even when they have no changes. Ex. we have monitoring pool (we don't make any change here) and adding staging pool after kube-aws update ... CF Stack for monitoring pool is updating and recreating autoscaling group for no reason.

Hi Patrik! Thanks for trying kube-aws.
Just a quick question but could you share me an example cluster.yaml to
reproduce the issue?
2017年3月21日(火) 21:52 Patrik Votoček<EMAIL_ADDRESS>
Since 0.9.4 there is new implementation of node pools. And it's not
possible to update only concrete node pool. We experienced weird behaviour
when we adding / removing / updating node pool. When we run kube-aws
update ... all node pools (worker autoscaling group) initiate update even
when they have no changes. Ex. we have monitoring pool (we don't make
any change here) and adding staging pool after kube-aws update ... CF
Stack for monitoring pool is updating and recreating autoscaling group for
no reason.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kube-aws/issues/427, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABV-bGgEZHOodxYQ7Tp9Pk7gYlURsXbks5rn8fwgaJpZM4MjwtI
.

Btw we are using kube-aws 0.9.4 (latest stable)
yaml
clusterName: k8s-cluster
externalDNSName: kubernetes.ourdomain.com
amiId: "ami-4829072e"
createRecordSet: true
hostedZoneId: "Z3AAAAAAAAAAAA"
keyName: patrik-ntb
region: eu-west-1
kmsKeyArn: "arn:aws:kms:eu-west-1:1111111111111:key/ffffffff-4590-4cab-b3eb-999999999999"
controller:
autoScalingGroup:
minSize: 1
maxSize: 3
subnets:
- name: MasterPrivateSubnet1
- name: MasterPrivateSubnet2
- name: MasterPrivateSubnet3
loadBalancer:
private: false
subnets:
- name: MasterPublicSubnet1
- name: MasterPublicSubnet2
- name: MasterPublicSubnet3
controllerInstanceType: t2.medium
workerCount: 0
worker:
nodePools:
- name: staging
count: 1
spotPrice: 0.03
instanceType: r4.large
subnets:
- name: StagingPrivateSubnet1
- name: StagingPrivateSubnet2
targetGroup:
enabled: true
arns:
- arn:aws:elasticloadbalancing:eu-west-1:1111111111111:targetgroup/k8s-staging-tg/1111111111111111
securityGroupIds:
- sg-bb07f1c2
nodeLabels:
kube-aws.coreos.com/role: worker
kube-aws.coreos.com/pool: staging
kube-aws.coreos.com/allocation: spot
k8s.ourdomain.com/pool-namespace: staging
etcdCount: 1
etcd:
subnets:
- name: MasterPrivateSubnet1
- name: MasterPrivateSubnet2
- name: MasterPrivateSubnet3
etcdInstanceType: t2.medium
vpcId: vpc-aaaaaaaa
vpcCIDR: "<IP_ADDRESS>/16"
subnets:

name: MasterPublicSubnet1
availabilityZone: eu-west-1a
idFromStackOutput: network-management-public-az1

name: MasterPublicSubnet2
availabilityZone: eu-west-1b
idFromStackOutput: network-management-public-az2

name: MasterPublicSubnet3
availabilityZone: eu-west-1c
idFromStackOutput: network-management-public-az3

name: MasterPrivateSubnet1
availabilityZone: eu-west-1a
idFromStackOutput: network-management-private-az1

name: MasterPrivateSubnet2
availabilityZone: eu-west-1b
idFromStackOutput: network-management-private-az2

name: MasterPrivateSubnet3
availabilityZone: eu-west-1c
idFromStackOutput: network-management-private-az3

name: StagingPrivateSubnet1
availabilityZone: eu-west-1a
instanceCIDR: "<IP_ADDRESS>/25"
private: true
routeTable:
idFromStackOutput: network-private-route-table

name: StagingPrivateSubnet2
availabilityZone: eu-west-1b
instanceCIDR: "<IP_ADDRESS>/25"
private: true
routeTable:
idFromStackOutput: network-private-route-table

name: ProductionPrivateSubnet1
availabilityZone: eu-west-1a
instanceCIDR: "<IP_ADDRESS>/24"
private: true
routeTable:
idFromStackOutput: network-private-route-table

name: ProductionPrivateSubnet2
availabilityZone: eu-west-1b
instanceCIDR: "<IP_ADDRESS>/24"
private: true
routeTable:
idFromStackOutput: network-private-route-table

name: ProductionPrivateSubnet3
availabilityZone: eu-west-1c
instanceCIDR: "<IP_ADDRESS>/24"
private: true
routeTable:
idFromStackOutput: network-private-route-table

kubernetesVersion: v1.5.4_coreos.0

when i adding this node-pool:

```yaml
- name: management
  count: 1
  spotPrice: 0.03
  instanceType: r4.large
  subnets:
    - name: MasterPrivateSubnet1
    - name: MasterPrivateSubnet2
    - name: MasterPrivateSubnet3
  targetGroup:
    enabled: true
    arns:
      - arn:aws:elasticloadbalancing:eu-west-1:1111111111111:targetgroup/k8s-management-tg/1111111111111111
    securityGroupIds:
      - sg-caed2ab3
  nodeLabels:
    kube-aws.coreos.com/role: worker
    kube-aws.coreos.com/pool: management
    kube-aws.coreos.com/allocation: spot
    k8s.ourdomain.com/pool-namespace: management
    k8s.ourdomain.com/monitoring: enabled
  elasticFileSystemId: fs-778c4fbe

It causes update staging CF Stack (recreating autoscaling group) for no reason because i just added one more node pool (management).

Thanks Patrik!
Btw have you changed the ASG's size(desired, min and max) after it was
created?
2017年3月21日(火) 22:17 Patrik Votoček<EMAIL_ADDRESS>
Btw we are using kube-aws 0.9.4 (latest stable)
yaml
clusterName: k8s-cluster
externalDNSName: kubernetes.ourdomain.com
amiId: "ami-4829072e"
createRecordSet: true
hostedZoneId: "Z3AAAAAAAAAAAA"
keyName: patrik-ntb
region: eu-west-1
kmsKeyArn:
"arn:aws:kms:eu-west-1:1111111111111:key/ffffffff-4590-4cab-b3eb-999999999999"
controller:
autoScalingGroup:
minSize: 1
maxSize: 3
subnets:

name: MasterPrivateSubnet1
name: MasterPrivateSubnet2
name: MasterPrivateSubnet3
loadBalancer:
private: false
subnets:
name: MasterPublicSubnet1
name: MasterPublicSubnet2
name: MasterPublicSubnet3

controllerInstanceType: t2.medium
workerCount: 0
worker:
nodePools:

name: staging
count: 1
spotPrice: 0.03
instanceType: r4.large
subnets:
name: StagingPrivateSubnet1
name: StagingPrivateSubnet2
targetGroup:
enabled: true
arns:

arn:aws:elasticloadbalancing:eu-west-1:1111111111111:targetgroup/k8s-staging-tg/1111111111111111
securityGroupIds:

sg-bb07f1c2
nodeLabels:
kube-aws.coreos.com/role: worker
kube-aws.coreos.com/pool: staging
kube-aws.coreos.com/allocation: spot
k8s.ourdomain.com/pool-namespace: staging

etcdCount: 1
etcd:
subnets:

name: MasterPrivateSubnet1
name: MasterPrivateSubnet2
name: MasterPrivateSubnet3

etcdInstanceType: t2.medium
vpcId: vpc-aaaaaaaa
vpcCIDR: "<IP_ADDRESS>/16"
subnets:

name: MasterPublicSubnet1
availabilityZone: eu-west-1a
idFromStackOutput: network-management-public-az1
name: MasterPublicSubnet2
availabilityZone: eu-west-1b
idFromStackOutput: network-management-public-az2
name: MasterPublicSubnet3
availabilityZone: eu-west-1c
idFromStackOutput: network-management-public-az3
name: MasterPrivateSubnet1
availabilityZone: eu-west-1a
idFromStackOutput: network-management-private-az1
name: MasterPrivateSubnet2
availabilityZone: eu-west-1b
idFromStackOutput: network-management-private-az2
name: MasterPrivateSubnet3
availabilityZone: eu-west-1c
idFromStackOutput: network-management-private-az3
name: StagingPrivateSubnet1
availabilityZone: eu-west-1a
instanceCIDR: "<IP_ADDRESS>/25"
private: true
routeTable:
idFromStackOutput: network-private-route-table
name: StagingPrivateSubnet2
availabilityZone: eu-west-1b
instanceCIDR: "<IP_ADDRESS>/25"
private: true
routeTable:
idFromStackOutput: network-private-route-table
name: ProductionPrivateSubnet1
availabilityZone: eu-west-1a
instanceCIDR: "<IP_ADDRESS>/24"
private: true
routeTable:
idFromStackOutput: network-private-route-table
name: ProductionPrivateSubnet2
availabilityZone: eu-west-1b
instanceCIDR: "<IP_ADDRESS>/24"
private: true
routeTable:
idFromStackOutput: network-private-route-table
name: ProductionPrivateSubnet3
availabilityZone: eu-west-1c
instanceCIDR: "<IP_ADDRESS>/24"
private: true
routeTable:
idFromStackOutput: network-private-route-table
kubernetesVersion: v1.5.4_coreos.0
when i adding this node-pool:
- name: management
  count: 1
  spotPrice: 0.03
  instanceType: r4.large
  subnets:
    - name: MasterPrivateSubnet1
    - name: MasterPrivateSubnet2
    - name: MasterPrivateSubnet3
  targetGroup:
    enabled: true
    arns:
      - arn:aws:elasticloadbalancing:eu-west-1:1111111111111:targetgroup/k8s-management-tg/1111111111111111
    securityGroupIds:
      - sg-caed2ab3
  nodeLabels:
    kube-aws.coreos.com/role: worker
    kube-aws.coreos.com/pool: management
    kube-aws.coreos.com/allocation: spot
    k8s.ourdomain.com/pool-namespace: management
    k8s.ourdomain.com/monitoring: enabled
  elasticFileSystemId: fs-778c4fbe

It causes update *staging* CF Stack (recreating autoscaling group) for no
reason because i just added one more node pool (*management*).

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
<https://github.com/kubernetes-incubator/kube-aws/issues/427#issuecomment-288074919>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABV-acE_YNO0a42Wgb7OTyFMFwPPPFiks5rn832gaJpZM4MjwtI>
.

no

Thanks for the info.
There seems to be a bug; for me, kube-aws does seem to recreate ASGs uselessly when nodeLabels are specified. The diff between generated user-data-worker files before and after a kube-aws update for me was:
$ diff --unified userdata-worker-84a1d2bffe344d1de572379585f300320629aedfa8d08ff899d86e9b44a5a313.json userdata-worker-27e7b32e230b6937b4ba219c24c25677a271b8c97aea5f5ed9101f2c6d5d1b14.json
--- userdata-worker-84a1d2bffe344d1de572379585f300320629aedfa8d08ff899d86e9b44a5a313.json	2017-03-22 09:22:31.000000000 +0900
+++ userdata-worker-27e7b32e230b6937b4ba219c24c25677a271b8c97aea5f5ed9101f2c6d5d1b14.json	2017-03-22 09:22:22.000000000 +0900
@@ -104,7 +104,7 @@
         --container-runtime=docker \
         --rkt-path=/usr/bin/rkt \
         --rkt-stage1-image=coreos.com/rkt/stage1-coreos \
-        --node-labels kube-aws.coreos.com/role=worker,kube-aws.coreos.com/reservation-type=on-demand \
+        --node-labels kube-aws.coreos.com/reservation-type=on-demand,kube-aws.coreos.com/role=worker \
         --register-node=true \
         --allow-privileged=true \
         --pod-manifest-path=/etc/kubernetes/manifests \

Would you mind verifying it by temporarily removingnodeLabels from your cluster.yaml and see if it resolves the issue?

I've just release kube-aws v0.9.5-rc.5 with the fix for the nodeLabels issue.
Could you confirm that it works for you?

I'm trying upgrade from 0.9.4 to 0.9.5-rc.5 but I'm getting error Error: Failed to read cluster config: failed to read/create auth token assets: open credentials/tokens.csv: no such file or directory when kube-aws update.

Could you create an empty file named so?
Also, please note that uprading from 0.9.4 wipes etcd data and recreate all
the nodes due to the H/A etcd enhancement..
I generally recommend you to recreate your cluster by running kube-aws destroy and then kube-aws up to see latest changes in cluster.yaml and
moving your pods one by one when upgrading kube-aws
2017年3月23日(木) 6:54 Patrik Votoček<EMAIL_ADDRESS>
I'm trying upgrade from 0.9.4 to 0.9.5-rc.5 but I'm getting error Error:
Failed to read cluster config: failed to read/create auth token assets:
open credentials/tokens.csv: no such file or directory when kube-aws
update.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kube-aws/issues/427#issuecomment-288551868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABV-VdhLq7gYWFwxZAHCohikfvrIuXNks5roZiBgaJpZM4MjwtI
.

Thanks it works!

Thanks for confirming @Vrtak-CZ!


[DOC] Spark3.1.0 should not need the extraclasspath set for standalone more anymore

For spark 3.1.0 we can update our docs to remove the need for the extraclasspath when using the plugin with Standalone Mode on the executor side. We should test this and then update our docs.
https://issues.apache.org/jira/browse/SPARK-32119

tested thsi work on spark 3.1.1. rc2


Fix tasks getting executed multiple times with MySQL storage backend

With the current MySQL Queue DAO implementation, tasks sometimes get executed multiple times even if the first attempt ends in success.
This PR is to fix that issue

@v1r3n @vikramsingh2104 please review this small fix for the MySQL persistence implementation

thanks @v1r3n are you going to create another 1.8.2 release candidate?

@picaron yes, we have some pending changes in dev that we are testing.  Should create an RC soon.

awesome, thanks 👍


[Bug]: Security issues in the underlying packages

Version
29.1.0
Steps to reproduce
Before yesterday, npm i reported only 4 low vulnerabilities. But yesterday it suddenly started showing 32 moderate vulnerabilities.
This package is flagged, but additional issues might need to be created on the dependency packages.
P.S. you guys need a [Security] issue template.
semver  <7.5.2
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix --force`
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/@babel/core/node_modules/semver
node_modules/@babel/helper-compilation-targets/node_modules/semver
node_modules/child-process-ext/node_modules/semver
node_modules/istanbul-lib-instrument/node_modules/semver
node_modules/make-dir/node_modules/semver
  @babel/core  *
  Depends on vulnerable versions of @babel/helper-compilation-targets
  Depends on vulnerable versions of semver
  node_modules/@babel/core
    @babel/helper-compilation-targets  *
    Depends on vulnerable versions of @babel/core
    Depends on vulnerable versions of semver
    node_modules/@babel/helper-compilation-targets
    @jest/transform  *
    Depends on vulnerable versions of @babel/core
    Depends on vulnerable versions of babel-plugin-istanbul
    node_modules/@jest/transform
      @jest/core  *
      Depends on vulnerable versions of @jest/reporters
      Depends on vulnerable versions of @jest/transform
      Depends on vulnerable versions of jest-config
      Depends on vulnerable versions of jest-resolve-dependencies
      Depends on vulnerable versions of jest-runner
      Depends on vulnerable versions of jest-runtime
      Depends on vulnerable versions of jest-snapshot
      node_modules/@jest/core
        jest  >=24.0.0-alpha.0
        Depends on vulnerable versions of @jest/core
        Depends on vulnerable versions of jest-cli
        node_modules/jest
          ts-jest  >=25.10.0-alpha.1
          Depends on vulnerable versions of babel-jest
          Depends on vulnerable versions of jest
          node_modules/ts-jest
        jest-cli  >=24.0.0-alpha.0
        Depends on vulnerable versions of @jest/core
        Depends on vulnerable versions of jest-config
        node_modules/jest-cli
      babel-jest  >=18.5.0-alpha.7da3df39
      Depends on vulnerable versions of @babel/core
      Depends on vulnerable versions of @jest/transform
      Depends on vulnerable versions of babel-plugin-istanbul
      Depends on vulnerable versions of babel-preset-jest
      node_modules/babel-jest
      jest-runner  >=24.2.0-alpha.0
      Depends on vulnerable versions of @jest/transform
      Depends on vulnerable versions of jest-runtime
      node_modules/jest-runner
        jest-config  >=24.0.0-alpha.0
        Depends on vulnerable versions of @babel/core
        Depends on vulnerable versions of babel-jest
        Depends on vulnerable versions of jest-circus
        Depends on vulnerable versions of jest-runner
        node_modules/jest-config
      jest-runtime  >=24.2.0-alpha.0
      Depends on vulnerable versions of @jest/globals
      Depends on vulnerable versions of @jest/transform
      Depends on vulnerable versions of jest-snapshot
      node_modules/jest-runtime
        jest-circus  >=25.2.4
        Depends on vulnerable versions of @jest/expect
        Depends on vulnerable versions of jest-runtime
        Depends on vulnerable versions of jest-snapshot
        node_modules/jest-circus
    babel-preset-current-node-syntax  *
    Depends on vulnerable versions of @babel/core
    node_modules/babel-preset-current-node-syntax
      babel-preset-jest  >=24.2.0-alpha.0
      Depends on vulnerable versions of @babel/core
      Depends on vulnerable versions of babel-preset-current-node-syntax
      node_modules/babel-preset-jest
    istanbul-lib-instrument  >=1.2.0
    Depends on vulnerable versions of @babel/core
    Depends on vulnerable versions of semver
    node_modules/istanbul-lib-instrument
      @jest/reporters  *
      Depends on vulnerable versions of @jest/transform
      Depends on vulnerable versions of istanbul-lib-instrument
      Depends on vulnerable versions of istanbul-lib-report
      Depends on vulnerable versions of istanbul-reports
      node_modules/@jest/reporters
      babel-plugin-istanbul  >=3.1.0-candidate.0
      Depends on vulnerable versions of istanbul-lib-instrument
      node_modules/babel-plugin-istanbul
    jest-snapshot  >=27.0.0-next.0
    Depends on vulnerable versions of @babel/core
    Depends on vulnerable versions of @jest/transform
    Depends on vulnerable versions of babel-preset-current-node-syntax
    node_modules/jest-snapshot
      @jest/expect  *
      Depends on vulnerable versions of jest-snapshot
      node_modules/@jest/expect
        @jest/globals  >=28.0.0-alpha.0
        Depends on vulnerable versions of @jest/expect
        node_modules/@jest/globals
      jest-resolve-dependencies  >=27.0.0-next.0
      Depends on vulnerable versions of jest-snapshot
      node_modules/jest-resolve-dependencies
  cross-spawn  6.0.0 - 6.0.5
  Depends on vulnerable versions of semver
  node_modules/child-process-ext/node_modules/cross-spawn
    child-process-ext  *
    Depends on vulnerable versions of cross-spawn
    node_modules/child-process-ext
      @serverless/dashboard-plugin  *
      Depends on vulnerable versions of @serverless/utils
      Depends on vulnerable versions of child-process-ext
      node_modules/@serverless/dashboard-plugin
        serverless  >=1.61.0
        Depends on vulnerable versions of @serverless/dashboard-plugin
        Depends on vulnerable versions of @serverless/utils
        Depends on vulnerable versions of child-process-ext
        node_modules/serverless
          serverless-plugin-typescript  2.0.0 - 2.1.5
          Depends on vulnerable versions of serverless
          node_modules/serverless-plugin-typescript
  make-dir  2.0.0 - 3.1.0
  Depends on vulnerable versions of semver
  node_modules/make-dir
    @serverless/utils  >=5.1.0
    Depends on vulnerable versions of make-dir
    node_modules/@serverless/utils
      serverless-offline  >=9.0.0
      Depends on vulnerable versions of @serverless/utils
      Depends on vulnerable versions of serverless
      node_modules/serverless-offline
    istanbul-lib-report  >=2.0.5
    Depends on vulnerable versions of make-dir
    node_modules/istanbul-lib-report
      istanbul-reports  >=3.0.0-alpha.0
      Depends on vulnerable versions of istanbul-lib-report
      node_modules/istanbul-reports

36 vulnerabilities (4 low, 32 moderate)

Expected behavior
There should be no vulnerabilities.
Actual behavior
There are 32 new vulnerabilities.
Debug log
None
Additional context
No response
Environment
OS: Linux, Windows, Mac
Node: 16 and 18

I see in the logging that Will install<EMAIL_ADDRESS>which is a breaking change but you mentioned it's version 29.1.0 I don't see anything mentioned about version 29.1.0

Bot will fix it :)

There are more to that like conventional changelog which we are using but it's dev dep only. A direct dep is semver which can be bumped to solve the issue by making a release.

@ahnpnl We are on 29.1.0 and npm audit says that to fix it we need to drop to 27.0.3 which we cannot do since it introduces hundreds of breaking changes.

https://www.npmjs.com/package/semver released a new version 20 hours ago. I'm assuming that's to fix that vulnerability. If ts-jest could release a new package that references the new version that would be awesome.


Fix secret template

Thanks!

This is referencing Values.config.rgw.multiMode.enabled. However, in the README.md multiMode is placed at Values.config.multiMode.enabled, missing the rgw key in the middle. Therefore this chart fails to deploy with default settings. Would be great if this could be fixed at either place

@StopMotionCuber You are right. There’s an error in the default values, which makes it’s way to the auto-generated documentation.

@StopMotionCuber @bumarcell I have pushed a commit which should hopefully address both issues (chart version will be 1.5.0):

Switched config.rgw.multiMode to config.multiMode
Fix config.multiMode.enabled not being able to be a boolean.

Please let me know if that fixes the mentioned issues. :smiley:

@galexrt I would actually keep multiMode inside rgw 😄 it makes sense to me at least.
Another thing that caused me a problem was env template in the deployment; I had to set .Values.config.rgw.existingSecret.name=nil although I'm not using an existing secret for one rgw but rather a realms.yaml file for multiple ones.

This works for me with default settings, thanks for the quick fix


UX backlog

If we had a UX designer's help, these are a sample of things we'd like help with. An ideal candidate would have experience with maps, data visualization, and accessibility. We do not need help running user studies or gathering feedback; we have plenty of that. We need help addressing known problems. We have internal users ready to help evaluate any fixes.
Scheme sketcher

Improve the style of objects we draw on top of the basemap (noting there are multiple basemaps people use)
Validate/improve our strategy for modal interactions on the map -- one tool active at a time, with context-sensitive instructions on the sidebar
Design a way to move some controls to the map for better visibility, handling problems with those controls taking up lots of space when activated
Review the mechanics of map drawing interactions and suggest improvements
Improve the "layer" mechanics, which group multiple features
Help design an interaction for joining routes together

Scheme browser

Improve the style of objects we draw on top of the basemap (noting there are multiple basemaps people use). There are 30+ layers to review, but only a few types of data we show -- so reusing some common patterns would be fine
Think through how multiple active layers on the map should act
Revisit the left sidebar's use and figure out more useful info to put there
Redesign the scheme filters/search interaction
Think through an alternate user flow through the tool, where people first select layers, then see a map with controls only for those layers

Inspectorate tools

Improve our "file management" design
Review the problem mapping and junction assessment flows, some of the most complicated pages
Review the scorecard design, especially for questions with lots of text
Validate that we're using gov.uk design components in reasonable ways, or suggest changes
Prototype a next-gen cross section tool, taking inspiration from Streetmix

UX backlog for Scheme Browser
From Sept 2024 user research sessions with internal users (inspectors and regional managers)
Feedback about the map

Legend that is more visible on the map and explains what each coloured line means
Modal with caveat about the data rather than the button we currently have. This loads at the start with a check box saying I have read this message to stop it appearing again. The message is ‘a reminder this data is based off’

Feedback about layers

Find a way to show selected layers, group them to the top or pull them out of the nested layer lists
Turn off all layers button at the top

Feedback about filters

Put a search field above schemes. Not immediately apparent the search field updates the schemes below - not obvious. Group them together in a way that makes it obvious the schemes are updated with the search terms you use.
Feedback about schemes (listed in left hand panel)
It would be useful to have a unique ID for a scheme, because scheme names can change
Deselect show schemes check box when the tool is loaded if we decide to load all schemes.

Feedback about scheme information on the map (pop-ups)

"Not sure what some of these headings refer to"

Feedback about the scheme data

"It's out of date information in terms of the designs that they the information that they have placed in more recent pulse surveys"
"it's out of date in terms of information on the level of interaction they've had on this scheme with Active Travel England's inspectorate"


Fixed README.md and examples

It fix some miss links on readme and general code of examples to work with any issue.

Any update on this?
I've just spent last 2 hours trying to figure out what's wrong with my setup, as the example code didn't work as expected (I constantly had the 'No matching action pattern' error). All fixed with this PR, thanks.

Hi @jorgecuesta @LsKs - thanks for your help with these issues - I have merged in and adapted the fixes manually, and also made some other updates to sneeze to fix the problem.


updating the dataflow sdk version

fixes #754
updating spark along side the dataflow jump
also updating other dependencies as well
changing GatkTestPipeline to downgrade a naming error to a warning
replacing calls to setName
replacing calls to setCoder with calls to withCoder when possible
hooking up the validation stringency for local files
fixes #745
disabling failing test and opening #774 to reenable it

LGTM!


KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
implementation overview - KIP
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ableegoldman @guozhangwang

@guozhangwang @dajac sorry for being late, I went through the whole conversation and I have pushed the changes suggested.

Now I am returning the close status after resolving the future returned by adminClient#removeMembersFromConsumerGroup
Now I have also added membersToRemove in the constructor RemoveMembersFromConsumerGroupOptions.

Thanks @sayantanu-dey I will review asap.


Update configuration template

Some of the runtime-template.yml configuration options are out of date. I updated it by inspecting our current DataStax helm chart configuration as well as the src/cfg/config.go structs.
Note: in https://github.com/datastax/pulsar-heartbeat/commit/4f858cc5e14ba4763421206665e635f00ccee89a, several configs were removed. I remove those here, too.

This update does not include a fix for the runtime-template.json file in the same directory.

Moved https://github.com/datastax/pulsar-heartbeat/pull/28.


Updating CTA. Removing references to scheduling 1x1 calls for support.

PR checklist:

[ ] Added changelog entry.

Committing changes  to a new branch.


TR: Send reason-phrase for HTTP API responses

What does this PR (Pull Request) do?

Reason-phrases are sent for routing over HTTP, routing over HTTPS, and the API over HTTPS, but not for the API over HTTP. This PR adds reason-phrases for the API over HTTP.
As @ocket8888 noted in #4074, Pygments needs reason-phrases for HTTP responses (of any HTTP version).

[x] This PR is not related to any Issue

This PR does not include tests because

The only component that depends on reason-phrases as far as I know is the documentation.
HTTP/2 responses have no reason-phrases.
If documentation ever stops failing to build due to no reason-phrase in a documented HTTP response, there is no reason to send one anymore, so building the documentation is a de facto test.

Which Traffic Control components are affected by this PR?

Traffic Router

What is the best way to verify this PR?
In the CDN-in-a-box directory,
docker-compose exec trafficrouter curl -I http://trafficrouter:3333/crs/stats

If this is a bug fix, what versions of Traffic Control are affected?

master (1c2ebee4)
3.1.0

The following criteria are ALL met by this PR

[x] I have explained why tests are unnecessary
[x] This PR does not need documentation because expected behavior does not change
[x] This PR does not include an update to CHANGELOG.md, such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Can one of the admins verify this patch?

We're using Tomcat 9, which removes reason-phrases altogether, to #4096 is no longer needed.


Optimize images

Related Issue
N/A
Proposed Changes

This pull request optimizes the images found in the repository using lossless compression. This means that the image quality will not be degraded. This will mean less space taken up by images along with faster loading times when viewing them. The overall file size has been reduced by around 10%.

Hi @JeffResc,
Thanks for the contribution, but it is not necessary because each SVG image is converted into React Component.
For example: blockquote.js
We are using this script to convert and optimize SVG files.

@marcelometal I see. Should I remove the SVGs from this PR and just keep the PNGs then?


Add Memory Icon Set

The memory icon set is tailored for the 2.7" Sharp Memory display.
Currently at 201 icons in the initial release.

This seems super useful!


Form Validation

Form validation is required to avoid spam entries.

please, go ahead to update it.

Thanks!


--outDir + --watch + path bug after file changes

TypeScript Version:
1.8.10
OS Version:
MacOS
In fact, I just begin to learn typescript, because the angular2.0, I use the https://github.com/angular/quickstart as the begining, and I change it's file structure, add ts folder, and move the typescript file to ts folder, change npm scripts:
"start": "tsc && concurrently \"tsc -w\" \"lite-server\" ",   ---->
"start": "npm run build:css && tsc --outDir ./app/scripts/ --rootDir ./app/ts/ && concurrently \"npm run tsc:w\" \"lite-server\" ",
"tsc:w": "tsc -w",  ---->
"tsc:w": "tsc -w --outDir ./app/scripts/ --rootDir ./app/ts/",
I start the project by run npm start, the tsc generate related js file to app/scripts folder, but when I change some typescirpt file, instead of outputing to the --outDir folder, it outputs .js files to where the .ts file is. It just happens after changing the file, the first compilation is right.

i see you are not passing any files on the commmandline, do you have a tsconfig.json in this folder? can you share that?

yeah, the project has a tsconfig.json file in it's root folder, and I don't change it, the content is:
{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "moduleResolution": "node",
    "sourceMap": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "removeComments": false,
    "noImplicitAny": true,
    "suppressImplicitAnyIndexErrors": true
  },
  "exclude": [
    "node_modules",
    "typings/main",
    "typings/main.d.ts"
  ]
}

Your build step is embedded in a quite complex npm script. Have you tried to run tsc directly from commandline? Just tsc -w with the --OutDir parameters and see if the output was correct.

after I move the --outDir configuration to tsconfig.json file, the problem get fixed, thx so much. But I still don't know why it not work with the CLI.

This is still a problem. It happens to me on Windows. The behavior of tsc changes when watching is enabled. The fact that a workaround exists doesn't solve the problem. This is preventing me from overriding a setting in tsconfig and will force me to have yet another config for a total of 3 so far.

can you provide more information?

Assume a folder structure:
-- project/
   |
   |-- src/
   |    |
   |    |--- code.ts
   |    |
   |    \--- tsconfig.json
   |
   \-- dist/

Assume tsconfig has outDir set to "dist"

I execute the following command from the project directory:

tsc -p src --outDir dist -w
-> compiled output goes to project/dist/code.js

Modify and save code.ts

-> compiled output goes to project/src/code.js
expectation is the original destination is overwritten, and that destination is the value in the command line argument (which should take precedence over the config file)

i can not reproduce this issue.. here is what i am doing:
c:\test\8656>tsc --v
Version 1.8.10

c:\test\8656>tree /f .
└───project
    └───src
            a.ts
            b.ts
            tsconfig.json

c:\test\8656>type project\src\tsconfig.json
{
    "compilerOptions": {
    }
}

c:\test\8656>cd project

c:\test\8656\project>tsc -p src --outDir dist -w
1:26:15 PM - Compilation complete. Watching for file changes.

c:\test\8656>tree /f .
C:\TEST\8656
└───project
    ├───dist
    │       a.js
    │       b.js
    │
    └───src
            a.ts
            b.ts
            tsconfig.json

c:\test\8656>touch project\src\a.ts

1:28:10 PM - File change detected. Starting incremental compilation...
1:28:11 PM - Compilation complete. Watching for file changes.

c:\test\8656>tree /f .
C:\TEST\8656
└───project
    ├───dist
    │       a.js
    │       b.js
    │
    └───src
            a.ts
            b.ts
            tsconfig.json

closing for now. please reopen if this still an issue and provide a project we can use to reproduce and diagnose the problem.

As I explain in my comment, tsconfig has outDir set to "dist", you left it empty.

@mhegazy I can reproduce this issue in Version 1.9.0-dev.20160620-1.0
Going back to<EMAIL_ADDRESS>fixes this issue

can you share a repro project? a github repo i could try maybe?

Get my LINQ project and try to build it with TS@next
https://github.com/ENikS/LINQ

i am sorry but i still can not see the issue. running tsc --w, tsc --w --out lib, tsc --p ./tsconfig.json --w all seem to generate the output under lib correctly. so what do i need to do to reproduce the issue?

I get this error every time I run tsc  without any command line arguments

I get this error every time I run tsc without any command line arguments

which error? i see a bunch of errors about missing Enumerable and IEnumerable, but i was only looking at output locations.

It seems something else is broken:
https://travis-ci.org/ENikS/LINQ/builds/140653700
If I change to TS@next build breaks before it has a chance to report the error. Looks like it is not picking up typings from the package.json.
The same repository builds just fine with stable TS
https://travis-ci.org/ENikS/LINQ/builds/140654729


RC Spot-Check Test: Mean: Share and Balance 1.1.0-rc.4

RC Spot-Check Test
Mentions: @marlitas, @jbphet, @amanda-phet
Simulation links

github repository for issues
phet top-level directory
sim: all_phet.html
phet-io wrapper index
link to phet-io zip file

Test Matrices
General Test:

[x] Tester =  NS, Platform =  mac + chrome/safari, Time = .75
[x] Tester = KW, Platform = Win 11 Chrome, Time = .5

PhET-iO Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Additional Features Test:

[ ] Tester = , Platform = , Time =
[ ] Tester = , Platform = , Time =

Features included

[x] PhET-iO
[x] Dynamic Locale
[x] Alternative Input
[x] UI Sound
[x] Sonification
[ ] Description
[ ] Voicing

Focus and Special Instructions
Second (and maybe final? spot-check). Really minimal changes to the mouse and keyboard cue for the candy bar (Distribute) and soccer ball (Balance Point) interactions.
Issues to Verify
All issues except for scenery-phet #841 can be closed.

[x] https://github.com/phetsims/mean-share-and-balance/issues/337
[x] https://github.com/phetsims/scenery-phet/issues/841
[x] https://github.com/phetsims/mean-share-and-balance/issues/350

For QA...

General features

What to Test

Click every single button.
Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.

If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.
Test some query parameters. (See QA Book for a
list of query parameters.)
When making an issue, check to see if it was in a previously published version.
Try to include version numbers for browsers.
If there is a console available, check for errors and include them in the Problem Description.
As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there
is a problem.
As the RC ends, notify the developer of any new QA credits that need to be added.

PhET-iO features

What to Test

Make sure that public files do not have password protection. Use a private browser for this.
Make sure that private files do have password protection. Use a private browser for this.
Make sure standalone sim is working properly.
Make sure the wrapper index is working properly.
Make sure each wrapper is working properly.
Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
sure the simulation loads without crashing or throwing errors.
Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:/wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER

Further instructions in QA Book
Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
random platform.
Conduct a memory test on the stand alone sim wrapper (rc.1).
Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
Test that the sim works offline:

Click the link to the phet-io zip file (at top of issue) to download the zip file.
Unzip it to a spot locally.
Open index.html by double clicking it on your desktop or in a Finder-view.
It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

Specific instructions can be found above.

Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
a list of features that may be supported in this test:

Alternative Input
Interactive Description
Sound and Sonification
Pan and Zoom
Mobile Description
Voicing

Test all possible forms of input.

Test all mouse/trackpad inputs.
Test all touchscreen inputs.
Test all keyboard navigation inputs (if applicable).
Test all forms of input with a screen reader (if applicable).

If this sim is not in this list or up to date there, make an
issue in website to ask if PhET research page links need updating. Please
assign to @terracoda and @emily-phet.

Screen Readers
This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

Windows 10 + Latest Chrome + Latest JAWS
Windows 10 + Latest Firefox + Latest NVDA
macOS + Safari + VoiceOver
iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information
We are tracking known screen reader bugs in
here. If you find a screen reader bug,
please check it against this list.

Keyboard Navigation
This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.
Magnification
This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel
controls. Please test magnfication and make sure it is working as intended and well with the use cases of the
simulation. Due to the way screen readers handle user input, magnification is NOT expected to work while using a screen
reader so there is no need to test this case.

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Calling QA here

Thanks QA team.  I'll follow up on the issue(s) independently.  Closing.


Add Emblem (EMB)

Currency name: Emblem
Symbol: EMB
Website: https://emb.overline.network/
Theme color: #f6c054
Logo (SVG format): EMB_Logo.svg.zip

@tommdn Want to make sure there's nothing else we need to add here. Here is a link to the SVG logo file that is not zipped: https://files.readme.io/bb3b2c6-EMB-Color.svg

@cw-blockcollider we're good.


When histogram widget is filtered, and user changes its buckets, it doesn't remove the filter

STR

Create a map of points.
Add a histogram widget.
Filter that widget.
Go to edit that widget.
Change the number of buckets.
💥 .

Fixed at https://github.com/CartoDB/deep-insights.js/pull/577/commits/f0cab097d60ef72cfde224d224cd13f421ba165f


Adding a DSPA ServiceMonitor template

Description
Adding a Service Monitor template to procure DSP Application metrics
Also added a CRD for ServiceMonitor because the unit tests run in a fake local K8s cluster which doesn't have the monitoring.coreos.com/v1 APIVersion.

How Has This Been Tested?

Ran make deploy with these changes
Created a DSP Application in a separate namespace.
Checked if a ServiceMonitor named ds-pipelines-samples came up.
Checked that specifically Data Science Pipelines Application metrics were scraped.
Metrics were found to be scraped by Prometheus:

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/retest

/test dsp-operator-e2e

/lgtm

this is marked as draft still. I can approve if you undraft it

this is marked as draft still. I can approve if you undraft it

Had marked it as draft because the Service Monitor wasn't able to pull in the correct DSP Application metrics. Updated Network Policy, ServiceMonitor is able to pull in metrics now. PR is marked ready for review!

one minor comment on Hashard's comment ... otherwise lgtm

/test dsp-operator-e2e


"Proxy" Chromium Browser

Discussed in https://github.com/DustinBrett/daedalOS/discussions/282

Originally posted by hosykynam0619ch2008-ies March 19, 2023
Hi Dustin, I love your project! As right now you're still using iFrame for the browser :(, I know there's might be a lot of request asking you to use proxy as the chromium, but I know it's hard hosting proxy, anddd coding the browser btw ._., so I'm here to ask you if you could replace the browser with this: https://r.studyschooltoday.eu.org/ , I've found this website which is a proxy server but it's design to look exactly like chrome, which fits the deadalOS browser, it's save you time of making a browser, instead of building a browser, just embed this site as an iframe and enjoy! I'm sorry if this site not work for you, sooooooo.... maybe give it a try, I (personaly) think this design fits..... the browser.
Thank you for reading this, I appreciate your work 😊

Thanks for posting this. I will respond now in the original discussion. https://github.com/DustinBrett/daedalOS/discussions/282


PHOENIX-6417 Fix PHERF ITs that are failing in the local builds

@yanxinyi

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
16m 26s
master passed

+0
hbaserecompile
22m 57s
HBase recompiled.

+1 :green_heart:
compile
0m 32s
master passed

+1 :green_heart:
checkstyle
0m 16s
master passed

+1 :green_heart:
javadoc
0m 22s
master passed

+0 :ok:
spotbugs
0m 52s
phoenix-pherf in master has 42 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m  2s
the patch passed

+0
hbaserecompile
15m 31s
HBase recompiled.

+1 :green_heart:
compile
0m 33s
the patch passed

+1 :green_heart:
javac
0m 33s
the patch passed

+1 :green_heart:
checkstyle
0m 16s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 22s
the patch passed

+1 :green_heart:
spotbugs
1m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 13s
phoenix-pherf in the patch passed.

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

53m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1180/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1180

Optional Tests
dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle

uname
Linux 52f2634e8e75 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 84d91ff

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1180/1/testReport/

Max. process+thread count
1624 (vs. ulimit of 30000)

modules
C: phoenix-pherf U: phoenix-pherf

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1180/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add support for smart tv

It's will be nice if there was support for smart tv, like open Netflix and YouTube, or mute, unmute tv, or change volume, turn on or off, change input source, etc...

https://github.com/resoai/TileBoard/blob/master/TILE_EXAMPLES.md#media_player

media player handles most of those use cases apart from opening Netflix or YouTube. There is no standard way to do that so you need an integration specific to your TV and trigger some custom commands (different for different TVs).
I have Sony Bravia and its custom integration provides a way to open apps (it's an Android TV) so it's a matter of creating custom scripts for each app you want to open and adding SCRIPT tiles in TileBoard to trigger them.
I don't think TileBoard needs to provide anything extra here.


Use sbt-apache-sonatype

So one of the tests are failing, will have to look into it

Some of the tests are a bit flaky, I guess this project needs a bit more work in general

Ah, it just passed. You are right it is flaky tests (I didn't think this project had flaky tests but good to know)


Removed username from profile edit form

Pre-Flight checklist

[x] Screenshots and design review for any changes that affect layout or styling
[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
N/A - Fixes an oversight from #202
What's this PR do?
Removes the username field from the edit profile form. The username should only be in the form if a new account is being created (just like the password field)
How should this be manually tested?

Create a new account. The register details page should have username and password, and submitting the form should successfully create the user
Edit a user profile. The username and password fields should be omitted, and saving the form should successfully apply changes to the relevant user fields

Screenshots (if appropriate)

Codecov Report

Merging #212 (17ad5f9) into main (f71ad51) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   90.72%   90.73%
=======================================
  Files         214      214
  Lines        6278     6280    +2
  Branches      309      309
=======================================
+ Hits         5696     5698    +2
  Misses        495      495
  Partials       87       87

Impacted Files
Coverage Δ

static/js/components/forms/EditProfileForm.js
100.00% <ø> (ø)

static/js/components/forms/RegisterDetailsForm.js
100.00% <ø> (ø)

...ic/js/components/forms/RegisterDetailsForm_test.js
100.00% <ø> (ø)

static/js/components/forms/ProfileFormFields.js
77.41% <100.00%> (ø)

static/js/lib/validation.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71ad51...17ad5f9. Read the comment docs.


PyTorch implementation

Hi,
I am trying to implement your code in PyTorch.
I believe I implemented VAT loss accurately. But, I cannot get the same performance probably because I used a different ConvNet. When I try to replicate your convnet; namely: "conv-large" the network did not work at all. Here, I am copying my code for conv-large in PyTorch. I would  appreciate if you can give me a feedback on what might be wrong.
Also, in the paper you are referring to the paper "Temporal Ensembling for Semi-Supervised Learning" for the network used in experiments. But, they are adding Gaussian noise in the first layer while I could not find noise in your implementation.
import torch.nn as nn
import torch.nn.functional as F
class conv_large(nn.Module):
def init(self):
super(conv_large, self).init()
    self.lr = nn.LeakyReLU(0.1)
    self.mp2_2 = nn.MaxPool2d(2, stride=2, padding=0)
    self.drop = nn.Dropout(p = 0.5)

    self.bn128 = nn.BatchNorm2d(128, affine=True)
    self.bn256 = nn.BatchNorm2d(256, affine=True)
    self.bn512 = nn.BatchNorm2d(512, affine=True)

    self.conv3_128_3_1 = nn.Conv2d(3, 128, kernel_size=3, stride=1, padding=1);

    self.conv128_128_3_1 = nn.Conv2d(128, 128, kernel_size=3, stride=1, padding=1);
    self.conv128_256_3_1 = nn.Conv2d(128, 256, kernel_size=3, stride=1, padding=1);
    self.conv256_256_3_1 = nn.Conv2d(256, 256, kernel_size=3, stride=1, padding=1);

    self.conv256_512_3_1 = nn.Conv2d(256, 512, kernel_size=3, stride=1, padding=0);
    self.conv512_256_1_1 = nn.Conv2d(512, 256, kernel_size=1, stride=1, padding=0);
    self.conv256_128_1_1 = nn.Conv2d(256, 128, kernel_size=1, stride=1, padding=0);

    self.avg = nn.AvgPool2d(6, ceil_mode=True) # global average pooling
    self.fc = nn.Linear(128, 10)

def forward(self, x):
    x = self.conv3_128_3_1(x);

    x = self.bn128(x); x = self.lr(x)

    x = self.conv128_128_3_1(x);

    x = self.bn128(x); x = self.lr(x)
    x = self.conv128_128_3_1(x); x = self.bn128(x); x = self.lr(x)

    x = self.mp2_2(x);
    x = self.drop(x)

    x = self.conv128_256_3_1(x);
    x = self.bn256(x);
    x = self.lr(x)

    x = self.conv256_256_3_1(x);
    x = self.bn256(x); x = self.lr(x)

    x = self.conv256_256_3_1(x);
    x = self.bn256(x); x = self.lr(x)

    x = self.mp2_2(x);
    x = self.drop(x)

    x = self.conv256_512_3_1(x);
    x = self.bn512(x); x = self.lr(x)

    x = self.conv512_256_1_1(x);
    x = self.bn256(x); x = self.lr(x)

    x = self.conv256_128_1_1(x);
    x = self.bn128(x); x = self.lr(x)

    x = self.avg(x)
    x = x.view(x.size(0),-1)
    x = self.fc(x)

    return x

Hi,
You use the same instance of nn.BatchNorm2d within different layers.
I am not familiar with PyTorch implementation of BN well, but I think you should use the different instance of BN for each layer.

That seems to be the mistake. Thanks for your reply.


Website won't stack

✔ BUGS → This form is required:
Steps
When I access my website from google chrome device toolbar it stack and work as expected in mobile size, but when I actually access it from mobile the website appear like the desktop version.
Expected Result
Stack everything in mobile
Actual Result
When I access my website from google chrome device toolbar it stack and work as expected in mobile size, but when I actually access it from mobile the website appear like the desktop version.
Version
Latest
Testcase
http://www.animapp.com.br
https://github.com/animapp-dev/animapp

https://webdesign.tutsplus.com/articles/quick-tip-dont-forget-the-viewport-meta-tag--webdesign-5972


exposed the websocket interface to make it more customizable

In an online playground I am currently developing (https://github.com/DDP-Projekt/Spielplatz) I am using my fork of this repos with this little modification to make the language server work with an arbitrary websocket connection.
Maybe you want to incorporate this change into the main repo, maybe not.
If not, I'm fine just using my fork.
Example usage: https://github.com/DDP-Projekt/Spielplatz/blob/main/server/server.go#L120C12-L120C26

Thanks for this!!! I definitely want to accept this, will try to review and approve this weekend.


chore: removing old crds and nodeTemplate reference

Fixes #
Description
Removed old crds and nodeclass
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

Wondering if we need these old crds, I assume they were kept in for kaito since kaito uses alpha apis? Opened this pr to have that discussion
CC: @rakechill

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.626%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
35605

Relevant Lines:
36471

💛  - Coveralls

Wondering if we need these old crds, I assume they were kept in for kaito since kaito uses alpha apis?

No, these CRDs are still required by the currently used version of core; so this will have to wait until we update core to v0.33+ (very soon). They are brought automatically from core within make verify (try make presubmit), so just deleting them from repo is ineffectual. (If you are wondering why this does not get caught by "file modifications detected" check - git diff does not consider new/untracked files ...) When these do go away, the corresponding symlinks from the chart need to go too.
nodeTemplate variable - good catch!

Thanks @tallaxes  will open new pr


Allow carousel's scrollable content to be tab-able with visual focus

Fixes #3814
Fixes #3835

Changelog Entry

Fixes #3814. Allow carousel's scrollable content to be tabbable, by @corinagum in PR #3841
Fixes #3834. Ensure carousel attachments are read by AT on tab focus, by @corinagum in PR #3841

Description
Carousel focus on children needed to be added in order to allow tabbing and AT to read contents.
Focus style will match from the following variables:
transcriptVisualKeyboardIndicatorColor
transcriptVisualKeyboardIndicatorStyle
transcriptVisualKeyboardIndicatorWidth
Specific Changes
#3814 - Allow carousel's scrollable content to be tab-able with visual focus

Add tabindex to carousel card(s)
Add focus indicator to carousel's children

#3835 - Ensure carousel attachments are read by AT on focus

Fixed by 3814; No test because we don't have a way to verify if AT reads content or not

[Other]

eslint comments in Playground
Remove unused asset from focusManagement.(...).html test

[x] I have added tests and executed them locally
[x] I have updated CHANGELOG.md
[x] I have updated documentation

Review Checklist

This section is for contributors to review your work.

[ ] Accessibility reviewed (tab order, content readability, alt text, color contrast)
[ ] Browser and platform compatibilities reviewed
[ ] CSS styles reviewed (minimal rules, no z-index)
[ ] Documents reviewed (docs, samples, live demo)
[ ] Internationalization reviewed (strings, unit formatting)
[ ] package.json and package-lock.json reviewed
[ ] Security reviewed (no data URIs, check for nonce leak)
[ ] Tests reviewed (coverage, legitimacy)

This won't be merge-able until #3836 gets in due to MB changes


Fix 1.9.3 support by using jwt 1.5.2

As documented here: https://github.com/jwt/ruby-jwt/issues/132

Fixes #51


how to deploy contract by annother account

Hi, I want to deploy contracts in account 'testa' with permission account 'testb'
first I authorize account 'testb'  with the activer permission of account 'testa'
cleos set account permission testa active '{"threshold" : 1, "keys" : [{"key": "EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV", "weight": 1}], "accounts" : [{"permission":{"actor":"testb","permission":"active"},"weight":1}]}' owner
then
cleos set contract testa data_contract/ -p testb
error:
Ensure that you have the related authority inside your transaction!;
If you are currently using 'cleos push action' command, try to add the relevant authority using -p option.
Error Details:
missing authority of testa

What you need to do is
cleos set contract testa data_contract/ -p testa instead of -p testb here. Since you have authorized testb@active for testa@active, the wallet will find out that testa can be satisfied with testb and then sign the transaction with testb private key in the end.


Add device removal callback for adapter

I added device removal callback for adapter in order to ease user space programs to cleanup some sort of information.
I actively used this thing in my own bluetooth app and it worked perfectly without any errors

Thx for this PR!


Update active-directory-azureadjoin-windows10-devices.md

We haven't published yet which 3rd party MDMs work with Windows 10. We will bring this change back when we do.

Hi @JairoCadenaMicrosoft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (jairoc). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

Hi @femila - can you review when you have a minute?

Looks good.
#sign-off


Missing Coverage from 1 module, not others

I seem to have a strange issue - I get coverage data for 5/6 projects.
I have unit tests that run code in the 6th project and I don't see any coverage data.   I see no errors on the console and no failed unit tests.
I made sure the project generates a pdb and the settings are for all 6 projects identical as I am using directory.build.props to make the settings consistent.   Is there any diagnostic information I can get to see why the 6th project is not getting coverage data?
using mstest vs 2017  / coverlet.msbuild 2.5.1 / unit test project is netcore 2.1 / dependency projects are net standard 2.0

Have you tried to run only for that project with include filter?We've an open issue on similar issue.

@abbotware can you please paste the terminal output from your test run

I have a issue on my project where in appveyor and Azure pipelines the coverage document is not generated because it cannot find symbols for a xunit package for some odd reason. I even filed a issue in opencover thinking it was related to opencover.
https://github.com/AraHaan/XmlAbstraction/

For me missing coverage for one project but not others was solved by adding this parameter to the dotnet test command: /p:CopyLocalLockFileAssemblies=true

Thanks!  I can confirm that using
/p:CopyLocalLockFileAssemblies=true
works!

@abbotware feel free to close this issue if solved!
Thanks a lot @zmhh for help!

I think this should be added to the docs (if it is not already there) as I think this is a common issue.

Shouldnt this doc be updated with a small blurb about this additional command line parameter?
https://github.com/tonerdo/coverlet/blob/master/Documentation/MSBuildIntegration.md

I think this is a common issue.

After some search I found other issue like this...btw I would like to try to understand if it's possible understand when/if that parameters is needed and maybe tell to user on output.
So I'd like to repro on my local...someone can provide a repro of issue?

well for me, i have a project that references this nuget:  Microsoft.Azure.ServiceBus
The following error appears without CopyLocalLockFileAssemblies=true
[coverlet] Unable to instrument module: ..\UnitTests\bin\Debug\netcoreapp2.1\Core.Messaging.dll because : Failed to resolve assembly: 'Microsoft.Azure.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7e34167dcc6d6d8c' [..\UnitTests.csproj]
When I originally reported the issue, there was no error message - so there have been some improvement / diagnostics - Adding 'you may need to set CopyLocalLockFileAssemblies=true' as a part of the error message might be good too.

Related issue https://github.com/dotnet/cli/issues/12705


VUE WAMP support

Hi.
I tried create WAMP application with Electron. And I got strange mistake that Electron app can't create WAMP object, because Electron doesn't know about this process nothing.
What about Vuido? Can I use Vuido with web sockets and WAMP?

You can use all libraries compatible with Node.js, for example socket.io to handle web sockets.


Is there an easier way to stub a specific command or script with this bats-mock?

I love the syntax of your implementation and it makes a lot of sense to me that the mock is a test double/spy that watches all the invocations and allows you to assert that it was called in specific ways, without necessarily having to write out an assertion for every single call.
While trolling StackOverflow and related sites I came across a question about mocking a script and checking the calls using bats-mock, but they were using the other version and it doesn't make it quite as easy to assert mock_called_with_args or similar, so I wrote up an answer with an example using your bats-mock, but I was having trouble emulating the stub behavior of actually shadowing/preempting a binary in the PATH so that the ${mock} definition was called instead. https://stackoverflow.com/q/38315185/3794873
I eventually came up with a hacky method by doing the mock creation in the setup() method or in each test and then by making a symlink to the mock's file path in the same directory and prepending that directory to the PATH variable and then unlinking and stripping the location back out of the PATH in the teardown or the end of the test. Is there a cleaner way to do this without repeating the code across all of the tests and in such a way that it allows for one or more binaries to be stubbed, in the case you want to avoid any external resources being accessed and you could stub success for the list?
Perhaps this is something that could be added to this better maintained version of bats-mock? Maybe something like mock_set_command_stub_name.

Upon reflecting on this I also realized that you need to use an additional $(create_mock) call for each binary you want to stub, otherwise you won't be tracking the right number of calls and args, so making a helper function like what [jasonkarns/bats-mock] uses for stub is probably the way to go.

@dragon788 thanks very much for your feedback. I was thinking about possibilities of mocking executables by their real names myself. And yes, symlink-ing + PATH manipulations occurred to me as well. However, the issue with this approach is that the executable can be specified with a path component (like /usr/local/bin/psql) in the script and so the idea breaks here. Not speaking about possible PATH manipulations by the script itself.
I have a hint of idea of solving that by chroot-ing into a disposable tree and doing unsafe things there but nothing is clear here yet, so I'm not sure if it's going to be the solution of there will be something else. I was a little bit hesitant about this enhancement, but after your message I started seeing a clear demand in it, so I scheduled work on it in terms of https://github.com/grayhemp/bats-mock/milestone/1.

Was interesting checking the implementation of stub.sh after discovering it in the question referenced above. https://github.com/jimeh/stub.sh/blob/master/stub.sh Haven't fully digested whether it can handle full paths and still stub the binary or not.

@dragon788 interesting tool, thank you. However, I'm a little bit afraid of stub/restore approaches. From my previous experience it's an easy way to shoot oneself in the foot.

I definitely think your idea of doing it in a chroot is the safest route, that way it can be destroyed between tests to prevent side effects and can't alter the host and cause any issues.

I just found this bat-mock tool and it looks very promising for unit testing bash code. I wonder if there is any progress with this issue?

@pszalko unfortunately it appeared to be harder that though and I just don't have enough time currently to address it properly. However, I would highly appreciate any PRs and/or ideas.

Solution from @dampcake is not working for me. It seems that function defined in @test is not passed to run: my script, which calls curl, takes it from system instead of mock.
To verify it, use another non-existing command (e.g. carl):
myscript.sh:
#!/usr/bin/env bash

carl --help

exit 0

and test:
@test "test mocked curl" {
    mock_curl="$(mock_create)"
    carl() {
	"${mock_curl}" "$@"
    }

    run myscript.sh
    [ "$(mock_get_call_num "${mock_curl}")" -eq 1 ]
}

When running test I get:
myscript.sh: line 3: carl: command not found

Did you create the carl script in a folder that is present in the PATH variable? Some distributions include the current directory (.) in the PATH, that has become less common since it can be a security issue, it is better to temporarily replace or extend the PATH variable explicitly for your test execution.

This is the complete example with curl. Both files are in the same dir.
myscript.sh:
#!/usr/bin/env bash

curl

exit 0

test.bats:
#!/usr/bin/env bats

setup() {
    # https://bats-core.readthedocs.io/en/stable/

    # modules installed with nvm and global npm:
    # npm install -g bats-support
    # npm install -g bats-assert
    load ${NVM_BIN}/../lib/node_modules/bats-support/load.bash
    load ${NVM_BIN}/../lib/node_modules/bats-assert/load.bash

    # module installed with:
    # https://github.com/grayhemp/bats-mock#installation
    # ./build install
    load /usr/local/lib/bats-mock.bash

    # get the containing directory of this file
    # use $BATS_TEST_FILENAME instead of ${BASH_SOURCE[0]} or $0,
    # as those will point to the bats executable's location or the preprocessed file respectively
    DIR="$( cd "$( dirname "$BATS_TEST_FILENAME" )" >/dev/null 2>&1 && pwd )"
    # make executables in . visible to PATH
    PATH="$DIR:$PATH"
}

@test "test mocked curl" {
    mock_curl="$(mock_create)"
    mock_set_output ${mock_curl} "this is the output from mock"
    curl() {
	"${mock_curl}" "$@"
    }

    # run something_that_call_curl
    echo "-- running myscript.sh" >&3
    run myscript.sh
    echo "${output}" >&3
    # this check will fail
    #[ "$(mock_get_call_num "${mock_curl}")" -eq 1 ]

    # run local function
    echo "-- running local function" >&3
    run curl
    echo "${output}" >&3
    # this check will succeed
    [ "$(mock_get_call_num "${mock_curl}")" -eq 1 ]
}

Myscript is not seeing the mocked version of curl, but the system real version of it. As expected, direct run of curl function from test.bats is working fine:
$ bats test.bats
✓ test mocked curl
-- running myscript.sh
curl: try 'curl --help' or 'curl --manual' for more information
-- running local function
this is the output from mock

1 test, 0 failures

Would using a symlink to the mocked version of curl and prepending it to the PATH inside the test work?
@test "test mocked curl" {
  mock_curl="$(mock_create)"
  mock_set_output ${mock_curl} "this is the output from mock"

  ln -s "${mock_curl}" $BATS_RUN_TMPDIR/curl
  PATH="$BATS_RUN_TMPDIR:$PATH"

  # run something_that_call_curl
  echo "-- running myscript.sh" >&3
  run myscript.sh
  echo "${output}" >&3
  # this check should pass now
  [ "$(mock_get_call_num "${mock_curl}")" -eq 1 ]

  # run local function
  echo "-- running local function" >&3
  run curl
  echo "${output}" >&3
  # this check will succeed

}

PR #20 contains a tentative implementation.
It doesn't use  chown but it is good enough for my test setup.
Restriction to PR #20: it doesn't work for testing shell scripts with hard-coded absolute paths.

@csecp I am pretty sure you will need to do an export -f curl after you declare it as a mock function in order for it to be usable in the downstream script under test.  You can avoid that by sourcing the script you are testing, but in this case i think exporting the mocked function makes more sense


100% CPU during cluster failover

Hi,
During a cluster failover, in the duration between the master died and the slave takes over (Basically redis node-timeout duration), the library seems to use 100% CPU.
I am obviously talking about loads of a few thousand requests per second.

After looking at the code a bit, i think that every command that fails calls this line: https://github.com/luin/ioredis/blob/master/lib/cluster.js#L472 which is causing a lot of callbacks and setTimeouts, instead of having a single one call all others when its done.
Also, this causes the refreshSlotsCache to be called many many times.

@luin any chance to release a version with this change?

I'm writing some tests for it, and I'll release a version once done

Cool thanks! Also, if you can add me to the contributors list in the README in your next commit it would be great :)

Of course will do! Actually I regenerate the contributors every time I release a version. :laughing:


Plugin.BLE crashes app on iPad iOS 13.1

To help us fix your issue, please provide the information in the below template. If something causes a crash, provide as much information as you can gather.
Just imagine: we do not know what you are doing!

Note: There is often little we can do without a minimal reproducible sample of the issue, so please provide that in a standalone git repository and link it here.

Steps to reproduce

Reference CrossBluetoothLE.Current in any capacity

Deploy app to iOS running iOS 13

This occurs with a fresh Xamarin.Forms app built with a single button which runs the following code when clicked:
bool bleEnabled = CrossBluetoothLE.Current.State == BluetoothState.On

It also occurs with the sample application provided in this repository.
Expected behavior
Code should execute normally without crashing.
Actual behavior
App crashes immediately.
Crashlog
This error appears to happen in native code an no stack trace shows up in the log.
Configuration
Version of the Plugin: 2.1.1 (also doesn't work on earlier versions)
Platform: iOS 13
Device: iPad 9.7 inch (5th generation)

Hi @mspoehr,
I'm the friendly issue checker.
Thanks for using the issue template :star2:
I appreciate it very much. I'm sure, the maintainers of this repository will answer, soon.

I needed to add both NSBluetoothAlwaysUsageDescription and NSBluetoothPeripheralUsageDescription to my info.plist per https://developer.apple.com/documentation/bundleresources/information_property_list/nsbluetoothalwaysusagedescription since our deployment target is < iOS 13.
Everything is working now, but this information should likely be added to the readme so future people don't get hung up on the same issue.

Thanks for this @mspoehr

Readme was updated thanks to @smstuebe. Will close this issue.


Add GroupingChooser component

Opening this up for review and feedback.
See issue: https://github.com/xh/hoist-react/issues/2177
See Toolbox PR: https://github.com/xh/toolbox/pull/446
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[ ] Caught up with develop branch as of last change.
[ ] Added CHANGELOG entry, or determined not required.
[ ] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[ ] Updated doc comments / prop-types, or determined not required.
[ ] Reviewed and tested on Mobile, or determined not required.
[ ] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

I've updated this branch following a review with Lee last week and opened it up for review

I think the GroupingChooser looks great! I like the indentation when the rows are static, but it feels a little too jumpy/snap-in-place-like on drag end, when the left margins recalculate.

Snap-in effect growing on me.    But Tom had the same concern that you do.
-Lee
On Mon, Nov 30, 2020 at 9:22 AM Petra Laohakul<EMAIL_ADDRESS>wrote:

I think the GroupingChooser looks great! I like the indentation when the
rows are static, but it feels a little too jumpy/snap-in-place-like on drag
end, when the left margins recalculate.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/xh/hoist-react/pull/2200#issuecomment-735815033, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARTL2IAE572QSKDYLWYY6DSSOTBLANCNFSM4UA4MDNA
.

Tom incorporated lots of my feedback, and I am very jazzed about where this landed!  I think it's a good combination of being clear/compact/clean, consistent with filter chooser, and not requiring too many extra clicks to operate.
We discussed the indentation which I was originally a proponent of -- if people felt strongly that it helped we could restore it, but I like the way everything lines up now, and its nice not to lose the valuable horizontal space.
Two things to consider before merging:

We will want to eventually support this on mobile.  Should we take the TabContainer approach of having the single cross-platform API.

I think that we should support the option to have it set to null, with potentially the option to not allow that.  It's seems like there are some application uses where that would make sense.  It could even be paired with empty text of 'Ungrouped' to provide an option of no grouping.


Component Life cycle methods swallow errors

Short description of the problem:
Component life cycle methods swallow errors, eg:

ionViewLoaded
ionViewWillEnter

What behavior are you expecting?
Errors to be logged to the console in the browser when running the app with ionic serve.
Steps to reproduce:

Implement the ionViewLoaded life cycle method
Implement the ionViewWillEnter life cycle method

    private ionViewLoaded() : void {

        console.log('1 - ionViewLoaded');
        if (1 == 1) {
            throw new Error('Error test');
        }
        console.log('2 - ionViewLoaded');
    }

    private ionViewWillEnter() : void {
        console.log('1 - ionViewWillEnter');
        if (1 == 1) {
            throw new Error('Error test');
        }
        console.log('2 - ionViewWillEnter');
    }

Other information:
When having the code throwing the error outside a life cycle method (e.g. in the constructor) then it logs to the console.  Do note I didn't have this issue with Ionic 2 Beta 6, started after upgrading to Beta 10.
Which Ionic Version?
Ionic 2 Beta 10
Plunker that shows an example of your issue
What versions of Ionic2/Angular2 is Plunker using, because when I put the code there, then the error logs to the console.  Do note the above issue I'm having didn't exist with Ionic 2 Beta 6, but only when I upgraded to Beta 10.
Run ionic info from terminal/cmd prompt:
Cordova CLI: 6.2.0
Gulp version:  CLI version 3.9.1
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X Yosemite
Node Version: v6.3.1
Xcode version: Xcode 7.2.1 Build version 7C1002

For a temp bypass for now I am wrapping my life cycling methods in try/catch blocks, e.g:
    private ionViewWillEnter() : void {
        try {
        // implementation
        } catch (error) {
            console.error(error);
        }
    }

and then I get information about the error on the console again.

Hello! I have confirmed this issue and am looking into it now. It looks like there is a try catch block in our source that is causing thrown errors to be swallowed unless you put your logic in your own try catch block. Thanks for submitting an issue!

After reviewing this issue some more it seems to be an angular bug https://github.com/angular/angular/issues/6651


Split ubuntu-install.sh, create docker-common.sh

Pinging @FranklinChen for comments.

@sumitsahrawat Is this for a hypothetical Dockerfile based on ipython/ipython or jupyter/minimal or something?

I am in the process of editing the Dockerfile in jupyter/docker-demo-images. With this, installing IHaskell will be straightforward, just clone the repo, and execute docker-common.sh.

Then we'll have IHaskell on try.jupyter.org, I think. Awesome.

Would it be possible to merge this into one script that uses a conditional?
For example, check whether ipython --version returns 3.0 or above; if it doesn't, install it, and if it does, do nothing.
That way, we can just use ubuntu-install.sh for Docker as well.
Something along these lines:
if [ `ipython --version | sed 's#\.# #g' | cut -f 1 -d ' '` -ge 3 ]; then
   # don't install ipython
else
  # install ipython
fi

That looks like a better option, I'll update the PR.

Another thing I noticed is that the docker containers use ipython3 as opposed to ipython. Would IHaskell be able to work with that?

IHaskell should not care at all.

Makes sense to check for IPython and not forcibly install it.

@sumitsahrawat Is this tested and ready-to-merge? (Note that I do not have Ubuntu on hand so cannot test this easily.)

I'll squash these commits, I'm experimenting with this script in a virtual machine.

This works. Tested with and without pre-installed ipython. Also tested with a lower version of ipython (v2.0) pre-installed.

Great. Will merge shortly.


this crudely gets Python 3 working

Lots of hard coding, because of lack of time.  I added some tests that are currently passing dealing with the inbox problems I was having.

Thanks for contributing.


Night CI 2023-12-11: Failed

action url: https://github.com/spidernet-io/egressgateway/actions/runs/7172709002

same with #1044


cursor: default for disabled  in pagination

This is the first time I fork and send pull request.
Am I doing everything right?


fix: Ensure ClusterAutoscaler can write status CM in workload cluster

Previously workload ClusterAutoscaler deployments were configured to
write the status configmap to the same namesapce as the workload cluster
is in on the management cluster. However, ClusterAutoscaler actually
writes this configmap and acquires a lock in the specified namespace in
the workload cluster. If that namespace does not exist then CA will fail
to run correctly, repeatedly throwing the error error initially creating leader election record: namespaces "my-new-ns" not found.
This commit updates the target namespace to use the default
kube-system which always exists on all clusters. This is the CA
default and as such is completely safe to use.

hi @jimmidyson, just for my knowledge, will this scenario get tested with any of the tests thru the PR pre-commit tests?

@deepakm-ntnx Sadly not right now, we need to add an e2e that creates a self-managed management cluster (we have that already) and then creates a workload cluster in a new namespace on that management cluster. An extension of the existing self-managed test suite... but no we don't have that yet.
I and @dkoshkin have manually tested it though.


Unable to launch web via Azure Dev Spaces

I got the error below following the steps Develop with .NET Core on Kubernetes with Azure Dev Spaces.

Starting warmup for project 'Webfrontend'.
Using dev space 'default' with target 'myapp-hello'
Release "azds-1d5814-default-webfrontend" does not exist. Installing it now.
NAME:   azds-1d5814-default-webfrontend
LAST DEPLOYED: Wed Jun 26 15:52:57 2019
NAMESPACE: default
STATUS: DEPLOYED
RESOURCES:
NAME         TYPE       CLUSTER-IP   EXTERNAL-IP  PORT(S)  AGE
==> v1/Service
webfrontend  ClusterIP  <IP_ADDRESS>         80/TCP   1s
==> v1beta1/Ingress
NAME         HOSTS                                       ADDRESS         PORTS  AGE
webfrontend  default.webfrontend.wqlm7l5jbj.cus.azds.io  <IP_ADDRESS>  80     1s
NOTES:
NAME         READY  UP-TO-DATE  AVAILABLE  AGE
==> v1beta2/Deployment
webfrontend  0/1    0           0          1s
http://default.webfrontend.wqlm7l5jbj.cus.azds.io/

Get the application URL by running these commands:
Building container image...
Sending build context to Docker daemon  3.927MB
Step 1/13 : FROM mcr.microsoft.com/dotnet/core/sdk:2.2
---> 155911c343f3
Step 2/13 : ARG BUILD_CONFIGURATION=Debug
---> Using cache
---> 0a860927aa11
Step 3/13 : ENV ASPNETCORE_ENVIRONMENT=Development
---> Using cache
---> 9aff467dfcc3
Step 4/13 : ENV DOTNET_USE_POLLING_FILE_WATCHER=true
---> Using cache
---> 4eec944c4cdb
Step 5/13 : EXPOSE 80
---> Using cache
---> 051a7179cc8d
Step 6/13 : WORKDIR /src
---> c265c50b4cb2
---> Using cache
Step 7/13 : COPY ["Webfrontend/Webfrontend.csproj", "Webfrontend/"]
---> Using cache
---> 29e207ff4a3d
Step 8/13 : RUN dotnet restore "Webfrontend/Webfrontend.csproj"
---> 114d8778f570
Step 9/13 : COPY . .
---> Using cache
---> Using cache
---> 45bccf0ad047
Step 10/13 : WORKDIR "/src/Webfrontend"
---> Using cache
---> 7ef376f04ab7
Step 13/13 : ENTRYPOINT ["/bin/bash", "/entrypoint.sh"]
---> Using cache
---> acf4addbf8a8
Successfully built acf4addbf8a8
---> e173184b7977
Successfully tagged webfrontend:devspaces-x016b947d6bdae4f7
---> Using cache
---> Using cache
---> 0b2cafae008c
Step 11/13 : RUN dotnet build --no-restore "Webfrontend.csproj" -c $BUILD_CONFIGURATION
Step 12/13 : RUN echo "exec dotnet run --no-build --no-launch-profile -c $BUILD_CONFIGURATION --" > /entrypoint.sh
Built container image in 1s
Waiting for container...
5s

Service 'webfrontend' port 'http' is available at http://default.webfrontend.wqlm7l5jbj.cus.azds.io/
Service 'webfrontend' port 80 (http) is available via port forwarding at http://localhost:28228
An error occurred during warmup for project 'Webfrontend':
System.InvalidOperationException: Container cannot be reached.
at Microsoft.Azure.DevSpaces.Client.Connection.ContainerConnector.d__34.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.DevSpaces.Client.Connection.ContainerConnector.d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.DevSpaces.Client.ManagementClients.ServiceManagementClientImplementation.d__96.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at Microsoft.Azure.DevSpaces.Client.ManagementClients.ServiceManagementClientImplementation.d__92.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Azure.DevSpaces.Client.ManagementClients.ServiceManagementClient.d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Client.DevSpacesServiceClient.<>c__DisplayClass27_0.<b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Logging.PerfLoggerExtensions.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Client.DevSpacesServiceClient.<>c__DisplayClass27_0.<b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Logging.PerfLoggerExtensions.d__31.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Logging.PerfLoggerExtensions.<ExecuteOperationAsync>d__31.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Package.Services.DebugService.d__25.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Package.Services.BackgroundWarmupService.<>c__DisplayClass11_0.<b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Logging.PerfLoggerExtensions.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Logging.PerfLoggerExtensions.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Package.Services.BackgroundWarmupService.d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Package.Services.BackgroundWarmupService.<>c__DisplayClass9_0.<b__4>d.MoveNext()
Enabling debugging...
Using dev space 'default' with target 'myapp-hello'
Release "azds-1d5814-default-webfrontend" does not exist. Installing it now.
NAME:   azds-1d5814-default-webfrontend
LAST DEPLOYED: Wed Jun 26 15:53:29 2019
NAMESPACE: default
STATUS: DEPLOYED
RESOURCES:
==> v1/Service
NAME         TYPE       CLUSTER-IP  EXTERNAL-IP  PORT(S)  AGE
webfrontend  ClusterIP  <IP_ADDRESS>         80/TCP   0s
==> v1beta1/Ingress
NAME         HOSTS                                       ADDRESS         PORTS  AGE
webfrontend  default.webfrontend.wqlm7l5jbj.cus.azds.io  <IP_ADDRESS>  80     0s
==> v1beta2/Deployment
NAME         READY  UP-TO-DATE  AVAILABLE  AGE
webfrontend  0/1    0           0          0s
NOTES:

Get the application URL by running these commands:
http://default.webfrontend.wqlm7l5jbj.cus.azds.io/
Building container image...
Sending build context to Docker daemon  3.927MB
Step 1/13 : FROM mcr.microsoft.com/dotnet/core/sdk:2.2
---> 155911c343f3
Step 2/13 : ARG BUILD_CONFIGURATION=Debug
---> Using cache
---> 0a860927aa11
Step 3/13 : ENV ASPNETCORE_ENVIRONMENT=Development
---> Using cache
---> 9aff467dfcc3
Step 4/13 : ENV DOTNET_USE_POLLING_FILE_WATCHER=true
---> Using cache
---> 4eec944c4cdb
Step 5/13 : EXPOSE 80
---> Using cache
---> 051a7179cc8d
Step 6/13 : WORKDIR /src
---> Using cache
---> c265c50b4cb2
Step 7/13 : COPY ["Webfrontend/Webfrontend.csproj", "Webfrontend/"]
---> Using cache
---> 29e207ff4a3d
Step 8/13 : RUN dotnet restore "Webfrontend/Webfrontend.csproj"
---> Using cache
---> 114d8778f570
Step 9/13 : COPY . .
---> Using cache
---> 45bccf0ad047
Step 10/13 : WORKDIR "/src/Webfrontend"
---> Using cache
---> 0b2cafae008c
Step 11/13 : RUN dotnet build --no-restore "Webfrontend.csproj" -c $BUILD_CONFIGURATION
---> Using cache
---> e173184b7977
Step 12/13 : RUN echo "exec dotnet run --no-build --no-launch-profile -c $BUILD_CONFIGURATION --" > /entrypoint.sh
---> Using cache
---> 7ef376f04ab7
Step 13/13 : ENTRYPOINT ["/bin/bash", "/entrypoint.sh"]
---> Using cache
---> acf4addbf8a8
Successfully built acf4addbf8a8
Successfully tagged webfrontend:devspaces-x016b947dea959b9c
Built container image in <1s
Waiting for container...
4s

Service 'webfrontend' port 'http' is available at http://default.webfrontend.wqlm7l5jbj.cus.azds.io/
Service 'webfrontend' port 80 (http) is available via port forwarding at http://localhost:28228

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a28fe6ff-a564-a867-2f1d-91197e74f22b
Version Independent ID: 2119d269-d3e2-3e8d-4753-e9dfe8a313a0
Content: Develop with .NET Core on AKS with Azure Dev Spaces and Visual Studio - Azure Dev Spaces
Content Source: articles/dev-spaces/quickstart-netcore-visualstudio.md
Service: azure-dev-spaces
Sub-service: azds-kubernetes
GitHub Login: @zr-msft
Microsoft Alias: zarhoads

@PingPongSet Thank you for the feedback!  We are investigating this and will get back to you shortly.

#26037

@PingPongSet Can you verify and provide a few details based on the below comment:
https://github.com/MicrosoftDocs/azure-docs/issues/26037#issuecomment-470235288

I followed the steps on this link as mentioned on the OP: https://docs.microsoft.com/en-us/azure/dev-spaces/quickstart-netcore-visualstudio?toc=%2Fen-us%2Fazure%2Faks%2FTOC.json&bc=%2Fen-us%2Fazure%2Fbread%2Ftoc.json
1 .NET CORE 2.2 VS 2017. VS 2019 is also tried.
2 "Publicly accessible" checkbox was checked

I tried it once again with VS 2017 (.Net Core 2.2) and VS 2019 (.Net Core 2.2) and did not run into any issues.
Try creating your AKS cluster in a new resource group with another name.
You might be facing an intermittent issue. Please go ahead and give it another try. Please make sure you have everything in place.
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


fix: deselect image on preview/exit

Fixes

Deselect image on preview / exiting preview

How to test it

Have an image selected and load the cluster

Checklist

[x] tested locally
[ ] added new dependencies
[ ] updated the docs
[ ] added a test

You should remove the selected image when the project is changed as well. Probably needs to be handled in setRootFolder.fulfilled.
Alternatively, search for selectedResourceId = undefined to check if there are any other places where the image should be set to undefined.


Issue/disable css

This PR fixes issue #7.
If you add cssOutput: false in the config, it stops the extra css being generated.
Due to a lack of a testing suite, I don't know how stable this is. I've tested it as best I can, but let me know if yu see any potential issues with this.

Thnx! Looked fine to me, just added na extra message (default temporary scss folder). Merged in commit https://github.com/gavro/gulp-iconify/commit/c87f08a6a803466e1c3c2956cf199b921de7dc63! (sorry for the major delay...)


About OPC-Radiomics dataset

Dear author, I noticed that the pretraining code does not include the OPC-Radiomics dataset, should I add it in data_utils_headneck.py?

Oh yes, you can add it.


MGRS Performance Issue

I have sent following to NASA:
What is the issue?
I have 38 Path objects each with two positions that are rendered on the map (full globe is visible). It takes the renderer approximately FOUR seconds to complete this task and application is non-responsive to user gestures in this interval (render is in on the UI thread). We want to know how this FOUR seconds interval can be reduced so that user doesn't see an unresponsive application. Depending on Camera position this interval can reach up to 7 to 8 seconds, I have not been able to gather exact data for that case.
Where Did I get the 38 paths from?
We have ported MGRS code to WW Android and that is where the Paths are generated from.
What am I sending you?
I have updated code from "PathFragment" class in the world-wind tutorials. I have added  code to generate the Path objects and add them to a layer. Code adds and removes the layer at an interval of 10 seconds. I am doing this repeatedly to see if performance changes on second, third iteration etc, it doesn't. In the Code you will see two private classes AddLayer and RemoveLayer that add and remove the layers. There is also an MGRSLayer class that has "doRender" overridden. It is in this overridden method where Path object are generated, added to the Layer and then "super.doRender" is invoked. It is the "super.doRender" method that takes 4 seconds to return.
Following is the Logcat for the application:
03-29 16:23:44.105 30242-30242/gov.nasa.worldwindx.tutorials D/PathsFragment: Add Layer
03-29 16:23:44.105 30242-30242/gov.nasa.worldwindx.tutorials D/PathsFragment: createMGRS
03-29 16:23:44.105 30242-30242/gov.nasa.worldwindx.tutorials D/PathsFragment: addRenderable
03-29 16:23:44.105 30242-30242/gov.nasa.worldwindx.tutorials D/PathsFragment: start super.doRender
HERE IS THE  GAP, it varies between 3.5 to 4.5 seconds.
03-29 16:23:47.735 30242-30242/gov.nasa.worldwindx.tutorials D/PathsFragment: done super.doRender
03-29 16:23:54.105 30242-30242/gov.nasa.worldwindx.tutorials D/PathsFragment: Remove Layer
Hardware:
Samsung, Galaxy Tab A, Model Number SM-T550
Android Version 6.0.1

PathsFragment (1).java.txt

Here is the scenario.

We are in steady state. MGRS grid is drawn.
User gesture on the screen causes multiple NAVIGATOR_MOVED events followed by NAVIGATOR_STOPPED event.
On receiving the NAVIGATOR_STOPPED event, MGRS grid lines are recalculated, that produces a set of Path objects (RHUMB style) and a set of Text objects.
Rendering those Path objects takes considerable amount of time.

Instead of asking you to look at all of this, I grabbed the Path objects that were created for a specific Camera location and incorporated them in the example I sent you. (I hope you have received that attachment)
In the example:
line 94: handler.postDelayed(new AddLayer(wwd), 5000); //STARTS THE LOOP
line 110: handler.postDelayed(new RemoveLayer(wwd), 10000); // CONTINUES THE LOOP
line 124: handler.postDelayed(new AddLayer(wwd), 10000); // CONTINUES THE LOOP
AddLayer adds the Layer and RemoveLayer removes the layer. Only reason I created the LOOP was to see if time taken to render is affected by doing it repeatedly. I could simply have executed AddLayer once and stopped.
you will see that
line 162: super.doRender(rc); // TAKES approximately FOUR seconds.
This is just one Camera Position and a set of Path objects that are created for that position. In other Camera positions set of Path objects and cardinality of the set changes and hence the time taken changes.

Set followTerrain to false for grid lines.