Launch Checklist

In order to launch we should have:

[ ] Crystal as a submodule in x-api
[ ] At least 10 problems
[ ] Documentation (see below)
[ ] One to a handful of people willing to check exercism regularly (daily?) to review. This will ensure that the track gets off on the right foot.
[ ] Add track implementors and other designated code reviewers as mentors to the track. This gives you access to all the solutions in Crystal whether or not you've submitted the problem to the site.
[ ] Toggle "active" to true in config.json
[ ] Send an email to the mailing list.

Documentation
The documentation lives in the docs/ directory here in this repository, and gets served to the site via the x-api. It should contain at minimim:

INSTALLATION.md - about how to get the language set up locally.
TESTS.md - about how to run the tests for the exercises.

Some nice to haves:

ABOUT.md - a short, friendly blurb about the language. What types of problems does it solve really well? What is it typically used for?
LEARNING.md - a few notes about where people might want to go to learn the language from scratch.
RESOURCES.md - references and other useful resources.

Successful Launches
Some tracks have been more successful than others, and I believe the key features of the successful tracks are:

Each submission receives feedback quickly, preferably within the first 24 hours.
The nitpicks do not direct users to do specific things, but rather ask questions challenging people to think about different aspects of their solution, or explore new aspects of the language.

For more about contributing to language tracks on exercism, check out the Problem API Contributing guide: https://github.com/exercism/x-api/blob/master/CONTRIBUTING.md

/cc @mhelmetag

Not exactly sure how long this will take but I'll chip away at these. Thanks for setting this up!!

Yeah, no hurry--we've got a bunch of tracks that are in the "might be launched someday" category.

How do I get xcrystal to get picked up by travis?

Oh, I have to turn that on. Just a sec.

Done.

Sweet!! Thanks :)

I would be fine to be on the list for "Add track implementors and other designated code reviewers as mentors to the track", if you need anyone.

@elorest, we definitely do. Once we set the language to active, we can pair on whatever exercises get posted on exercism.

Can we get the list updated? I guess we have 10 exercises now. Any more things left for launching?

Sweet! I've added @mhelmetag and @elorest as track mentors. Anyone else that I should add here?

@kytrinyx , I think that's it for now... unless I'm missing something. It looks like @gangwolf is itching to get this track active 😄  so does anyone disagree with starting up Crystal this weekend?

Let's do it!

Lets.
Isaac Sloan - isaacsloan.com
Artisan Rails Architect
1391 S Slate Canyon Dr.
Provo, Ut 84606
Cell:<PHONE_NUMBER>
On Fri, Jul 29, 2016 at 11:54 AM, Katrina Owen<EMAIL_ADDRESS>wrote:

Let's do it!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/exercism/xcrystal/issues/1#issuecomment-236248792,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHmpN13wDDbwUxaWSN-j17Wo0_PR76Aks5qaj5tgaJpZM4Hr19I
.

Flag set to active! Thanks, @Gangwolf !

Deploying this now! I'll announce it in the newsletter (and on twitter) today.


how to make botplay hit notetype

What is your question?
what do I need to add to my notetype script to make botplay hit the note

there's a property for notes in lua
i think you gotta set it like this:
if getPropertyFromGroup('unspawnNotes', i, 'mustPress') then -- Doesn't let Dad/Opponent notes get ignored
setPropertyFromGroup('unspawnNotes', i, 'ignoreNote', true) --Miss has no penalties
end

This is from the official wiki page of Psych Engine;
You should put this into your unspawned notes loop.

wait i didn't read the question lmao
put ignoreNote to false


Adds support to cellFormat, timeZone and userLocale as per documentation

Hi!
I needed cellFormat for a "copy across bases" functionality, so I coded it into your project. In case you want to integrate it :)
Cheers, and thank you for your library!
Joao

Thanks.
Can we check line ending and make sure it uses same as in editorconfig file?
Should be LF. Hopefully that's what it's on the source code.
Diff as is make it hard to actually view pr

Hi, sorry it's super annoying, but I'm using windows and using gitextensions which seems to make a bit of a witchcraft on it. You can see differences only if you go to the config wheel next on the top left next to "Jump to", and select "Hide Whitespace Changes". Or if you want, I am happy for you to copy the code and create a pull in your name.
Thanks! Cheers

Hide Whitespace Changes
Did not know this existed! Thanks for showing me that - I was able to review the code.

In any case, we need to fix line endings before merging, otherwise we will keep getting PRs with line ending changes.
What editor are you using? Most editors have plugins set line endings based on .editorconfig file.
As for git, I had this issue for while as a former windows user. I now set git config to core.autocrlf=input always. This leaves files untouched by git, and it's up to editors to decided line endings - I like this being a more explicit option than the other auto-convert settings.
Anyhow, thank you for this PR. I would like to get this merge, pending issues commented

You can force a project to normalize line endings: https://docs.github.com/en/github/using-git/configuring-git-to-handle-line-endings#per-repository-settings

Created issue to cover this.
closing PR because of 1.x release this would need a total re-write
Thanks


404 on npm

Has this project moved? I get a 404 on npm: https://www.npmjs.com/search?q=dayspan-vuetify

Greetings!
I just published the current version to NPM (0.0.1) - but as noted in the
README - I will be making some (potentially) breaking changes over the
next week.
Thank you for your interest!
If you find any bugs or missing features, please let me know through GitHub!
Thanks
On Jul 18, 2018 8:34 PM, "CJ"<EMAIL_ADDRESS>wrote:
Has this project moved? I get a 404 on npm: https://www.npmjs.com/search?
q=dayspan-vuetify
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ClickerMonkey/dayspan-vuetify/issues/17, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAZtcW2QE_GX7T4rDShP8eKZ5fADsyWbks5uH9QZgaJpZM4VVknd
.


Dart 2 Null Safety

Dart 2 Null Safety? Could you please update us on the progress?

Guess I'll just stop using this package then.

Fixed #5


Integrate wit Element UI?

I base on Element UI, could you example with form validation?

hey @thearabbit, what shows up inside the wizard is controlled by you. You can add in a form with your validation mechanisms and whatever you want inside the div with the correct name.
If you want to trigger validation when you click next, use the onNext property... which takes in a function. If validation succeeds, return true (will move wizard to next step)... or show the error message and return false (will keep the user at the current step)
Element UI's validation seems to be done asynchronously so a straight forward implementation doesn't exist for this yet.

Alright I have enhanced the plugin (v 1.1.0) to allow calling for next, back asynchronously and added an example for how you can do that with element-ui form validate. cheers!


HiyaCFW Helper says "Fatcat not found. Please make sure the Windows folder is at the same Location as this Script"

So i have been trying to Install twilight menu on my Dsi (and i've also done this Before) but Whenever i Try to use HiyaCFW Helper it gives me this Error Message
 "Fatcat not found. Please make sure the Windows folder is at the same Location as this Script"

Does anyone Know how to fix This?

Use 7z, not WinRAR


added Rose Pine theme

Added Rose Pine theme for spf (with screenshots)

Wow this look nice!
just btw next time update new theme please add in the /src/superfile/theme/your_name.json

Ok then!


Plugin "Console" doesn't work

Unfortunately plugin "Console" doesn't work on lite-xl.
Did someone try to fix it for lite-xl?
Thanks!

@azb92 It would be helpful if you could provide some additional details on top of "it doesn't work".

Now it's just a "Fatal error: cannot locate the data directory. Please verify that the data folder is available."
I checked previous versions and got this error:
Error: /data/plugins\console.lua:203: attempt to get length of upvalue 'output' (a nil value) stack traceback:	/data/plugins\console.lua:203: in function 'get_line_count'
/data/plugins\console.lua:208: in function 'get_scrollable_size'
/data/plugins\console.lua:299: in function 'update'
/data/core\rootview.lua:354: in function 'update'
/data/core\rootview.lua:358: in function 'update'
/data/core\rootview.lua:358: in function 'update'
/data/core\rootview.lua:357: in function 'update'
/data/core\rootview.lua:632: in function 'update'
/data/plugins\autocomplete.lua:237: in function 'update'
/data/core/init.lua:785: in function 'step'
/data/core/init.lua:853: in function <C:\Users\admin\Desktop\Soft\Test/data/core/init.lua:848>
(...tail calls...)
[string "local core..."]:14: in function <[string "local core..."]:2>
[C]: in function 'xpcall'
[string "local core..."]:2: in main chunk

Thank you for reporting this problem. What happens is that the new release is no longer compatible with the plugin and lite-xl misreport the error.
I have corrected already the reporting of the error message in the master branch. I will try to fix the actual problem with the console plugin, this is probably something simple to fix.

Thank you

The problem with the error message is fixed with the new release. As for the console plugin, I have published an adapted version compatible with lite-xl there:
https://github.com/franko/console


[📚] Fix layout

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


proof of concept for issues in Github Action 'EnricoMi/publish-unit-test-result-action

Sorry for disturbance, I am strugguling to provide POC for some Github Actions related stuff.
Closing PR, will continue elsewhere.


My location button in Google Maps Widget doesn't work

The camera doesn't move when I pressing "my location" button
Well, button working after fast click on the map before button click
class MapScreen extends StatefulWidget {
  createState() => MapScreenState();
}

class MapScreenState extends State<MapScreen> {

  build(context) {
    return Scaffold(
      body: GoogleMap(
        myLocationEnabled: true,
        compassEnabled: false,
        onMapCreated: (GoogleMapController controller) {},
        initialCameraPosition: CameraPosition(
          target: LatLng(51.5160895, -0.1294527),
        ),
      ),
    );
  }
}

Unhandled exception:
'package:flutter/src/gestures/converter.dart': Failed assertion: line 143 pos 18: '!state.down': is not true.
#0      _AssertionError._doThrowNew (dart:core/runtime/liberrors_patch.dart:40:39)
#1      _AssertionError._throwNew (dart:core/runtime/liberrors_patch.dart:36:5)
#2      PointerEventConverter.expand (package:flutter/src/gestures/converter.dart:143:18)
#3      _SyncIterator.moveNext (dart:core/runtime/libcore_patch.dart:151:12)
#4      ListQueue.addAll (dart:collection/queue.dart:715:25)
#5      _WidgetsFlutterBinding&BindingBase&GestureBinding._handlePointerDataPacket (package:flutter/src/gestures/binding.dart:83:27)
#6      _invoke1 (dart:ui/hooks.dart:168:13)
#7      _dispatchPointerDataPacket (dart:ui/hooks.dart:122:5)
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale ru-RU)
• Flutter version 1.0.0 at /Users/daniel/crossplatform/flutter
• Framework revision 5391447fae (2 months ago), 2018-11-29 19:41:26 -0800
• Engine revision 7375a0f414
• Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)
[!] Android toolchain - develop for Android devices (Android SDK 28.0.3)
• Android SDK at /Users/daniel/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
✗ Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.1, Build version 10B61
✗ libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:
brew update
brew install --HEAD usbmuxd
brew link usbmuxd
brew install --HEAD libimobiledevice
brew install ideviceinstaller
✗ ios-deploy not installed. To install with Brew:
brew install ios-deploy
• CocoaPods version 1.5.3
[✓] Android Studio (version 3.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 31.3.1
• Dart plugin version 181.5656
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
[✓] Connected device (1 available)
• iPhone XR • 0ED8A7F1-CE8A-4026-820D-1763AF319C68 • ios • iOS 12.1 (simulator)
! Doctor found issues in 2 categories.

 This issue was fixed, you just need to switch to a more recent channel.
flutter channel master
flutter upgrade

https://github.com/flutter/flutter/wiki/Flutter-build-release-channels


win-1 is dead.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
win-1 is dead.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

win-1 is out sync with Salt master, run command "salt-call state.apply" to re-sync with Salt master.


Add support for android14-5.15

please also update the badges on the homepage

Done, thanks for the review!
https://github.com/ClangBuiltLinux/ClangBuiltLinux.github.io/pull/42


general: WTForms deprecation of wtforms.ext.sqlalchemy

bring forward WTForm 3.0 compatibility:

[ ] replace by WTForms-Alchemy package: https://github.com/kvesteri/wtforms-alchemy
[ ] validators.Required() to DataRequired

--
invenio/modules/search/forms.py:30:from wtforms.ext.sqlalchemy.fields import QuerySelectField

now, are we compatible with WTForm 3.0?
Or remains other things to do? :)

replace by WTForms-Alchemy package

@hachreak still the first point is not finished (see git grep wtforms.ext.sqlalchemy).


Request an invoker image

Hi, I'm try to deploy this work to play, but i meet error when invoker pull runtime action images per manifest. It can't pull yhf0218/action-python-v3.6-ai:latest. Can you please provide the image? Thank you very much.

Hi, thank you for your question. I tried pulling the image on my side and it succeeded. What was the error message you had? Can you post it here to provide more contexts?

Thank you for your answer. My error message is as follows:
TASK [invoker : get invoker name and index] ************************************************************************************************************
Wednesday 14 August 2024  06:52:59 -0700 (0:00:00.029)       0:02:07.300 ******
ok: [invoker0]

TASK [invoker : pull invoker image with tag latest] ****************************************************************************************************
Wednesday 14 August 2024  06:52:59 -0700 (0:00:00.035)       0:02:07.335 ******
skipping: [invoker0]

TASK [invoker : pull runtime action images per manifest] ***********************************************************************************************
Wednesday 14 August 2024  06:52:59 -0700 (0:00:00.031)       0:02:07.367 ******
FAILED - RETRYING: pull runtime action images per manifest (10 retries left).

FAILED - RETRYING: pull runtime action images per manifest (6 retries left).
FAILED - RETRYING: pull runtime action images per manifest (5 retries left).

FAILED - RETRYING: pull runtime action images per manifest (2 retries left).
 I can try downloading it locally and loading it.

Sorry for the late reply. We are actively working on open-sourcing the repos to build action images.


Delayed importer fails for certain importers

The delayed import functionality fails in a certain importer that creates a zip for hermetic python packaging for Google.
Here is what fails.
Traceback (most recent call last):
...
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 658, in _load_unlocked
File "", line 571, in module_from_spec
File "/build/work/.../py/cirq/_import.py", line 105, in create_module
return self.loader.create_module(spec)
AttributeError: '_elfzipimport.ElfZipImporter' object has no attribute 'create_module'

The create_module method on a Loader is allowed to be not implemented or return None to indicate the default behavior.  https://docs.python.org/3/library/importlib.html#importlib.abc.Loader
The fix should just be to check if the create_module method exists and return None otherwise.

Ok, I can give that a try.

@dstrain115 is this still an issue?

I think we managed to work around the issue by building the package differently.  I am okay closing it and then re-opening it if we run into it again.

Thanks, let's do that then!


Color update

Updated colors so they are less bright and easier to see.

Codecov Report

Merging #233 (687f408) into master (40c7973) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master     #233   +/-   ##
=========================================
  Coverage     74.04%   74.04%
  Complexity      779      779
=========================================
  Files           109      109
  Lines          2527     2527
  Branches        271      271
=========================================
  Hits           1871     1871
  Misses          584      584
  Partials         72       72

Impacted Files
Coverage Δ

src/main/java/seedu/fast/commons/util/Colors.java
0.00% <ø> (ø)

src/main/java/seedu/fast/ui/TagComponent.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c7973...687f408. Read the comment docs.


update hound ci config

Issue fix to https://github.com/RackHD/RackHD/issues/391
@RackHD/corecommitters @heckj @yyscamper

:+1:

comment by test Jenkins, you can ignore this error
*** BUILD #36 ***

👍

👍


Creative inventory and JEI

Describe the bug
The items of this mod don't appear in the creative inventory and JEI
To Reproduce
I don't know how it happen
Video
https://clipchamp.com/watch/Gu6ILKJGxtm
Versions (please complete the following information):

Fabric Loader Version: 0.4.11
MC Version: 1.19.2
Mod Version: 1.5.63
JEI Version (if present) : <IP_ADDRESS>7
Fabric API Version (if present) : 0.68.0

Actually, this happens since I used "Minecraft Mod Uptader" https://www.curseforge.com/minecraft/mc-mods/minecraft-mod-updater

Not supporting tlauncher...

Not supporting tlauncher...

Why? Because it's non-premium? In case we non-premium don't have rights?

Not supporting people who don't buy the game.


A11y_SQLAzureDataStudio_NewDeployment_ SQLServerBigDataCluster_Screenreader: NVDA doesn’t announce as ‘Required’ for ‘I accept…License Terms’ checkbox

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:#A11y_SQLAzureDataStudioBenchmark;#A11yMAS; A11ySev2;#A11yTCS;#SQL Azure Data Studio;#Benchmark;#DesktopApp;#Win32;#MAS1.3.1;#Screenreader;#NVDA;#JAWS;
Environment Details:
Version: 1.16.0-insider
Commit: 506c6a5
Date: 2020-02-17T05:43:18.399Z
VS Code: 1.42.0
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Additional Details:
MAS References: MAS1.3.1
NVDA Version: 2019.2
Repro Steps:

Launch Azure Data Studio.
Select the Connections icon (if not already selected) from left bar.
Click on the ellipses '...' and select "New Deployment".
Select "SQL Server Big Data Cluster" card under deployment options
Launch NVDA screenreader
Navigate to ‘I accept…License Terms’ checkbox using tab key

Actual:
NVDA doesn’t announce as ‘Required’ for ‘I accept…License Terms’ checkbox when navigated using tab key.
Same issue is observed with JAWS screenreader
Same issue is observed in Database Dashboard screen: 1. Launch Azure Data Studio.2. Connect to server.3. In the Connections pane, navigate to server --> database --> right click on any database & select Manage.
Expected:
NVDA should announce as ‘Required’ for ‘I accept…License Terms’ checkbox when navigated using tab key.
User Impact:
Screen reader users will not get information that ‘I accept…License Terms’ checkbox is mandatory field.
Attachment link for Reference:
9323_A11y_SQLAzureDataStudio_NewDeployment_ SQLServerBigDataCluster_Screenreader.zip

#A11ySev2

GitHubTags:#SQLADS-Win32-Feb2020;


[SPARK-8213][SQL][WIP]Add function factorial

Merged build triggered.

Merged build started.

Test build #34916 has started for   PR 6822 at commit 06d7bac.

Test build #34916 has finished for   PR 6822 at commit 06d7bac.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression) extends UnaryExpression with Serializable with ExpectsInputTypes

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #34920 has started for   PR 6822 at commit b36b3e8.

Test build #34920 has finished for   PR 6822 at commit b36b3e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Merged build finished. Test PASSed.

cc @chenghao-intel

Can you also update the title of this PR? We usually put the [WIP] right after [SQL].

Merged build triggered.

Merged build started.

Test build #35033 has started for   PR 6822 at commit e7c1998.

Test build #35033 has finished for   PR 6822 at commit e7c1998.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35035 has started for   PR 6822 at commit 82accfd.

Test build #35035 has finished for   PR 6822 at commit 82accfd.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35039 has started for   PR 6822 at commit ee0dec8.

Test build #35039 has finished for   PR 6822 at commit ee0dec8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@chenghao-intel  @adrian-wang  any comments?

The return null comment?

Any preference here? just found that the some other existing code would throw exception during the type checking, so I guess it's fine to do the same here. Hive return null for such case, but I guess it's not informative and would confuse the user?

Merged build triggered.

Merged build started.

Test build #35237 has started for   PR 6822 at commit 9ccf803.

Test build #35237 timed out     for PR 6822 at commit 9ccf803     after a configured wait of 175m.

Merged build finished. Test FAILed.

retest this please

Build triggered.

Build started.

Test build #35499 has started for   PR 6822 at commit 9ccf803.

Test build #35499 has finished for   PR 6822 at commit 9ccf803.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Build finished. Test PASSed.

Don't forget to rebase code before updating it.

Build triggered.

Build started.

Test build #35630 has started for   PR 6822 at commit 0f63906.

Test build #35630 has finished for   PR 6822 at commit 0f63906.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #35633 has started for   PR 6822 at commit 0d42293.

Test build #35633 has finished for   PR 6822 at commit 0d42293.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Merged build finished. Test PASSed.

cc @rxin could you pls comments on this?

LGTM except some minor issues.

Build triggered.

Build started.

NAVER - http://www.naver.com/
<EMAIL_ADDRESS>님께 보내신 메일 <Re: [spark] [SPARK-8213][SQL]Add function factorial (#6822)> 이 다음과 같은 이유로 전송 실패했습니다.

받는 사람이 회원님의 메일을 수신차단 하였습니다.

Test build #35816 has started for   PR 6822 at commit 4839f0b.

Merged build triggered.

Merged build started.

Test build #35817 has started for   PR 6822 at commit e78f51a.

Test build #35816 has finished for   PR 6822 at commit 4839f0b.

This patch fails MiMa tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Build finished. Test FAILed.

retest please

Test build #35817 has finished for   PR 6822 at commit e78f51a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36351 has started for   PR 6822 at commit c51a2e2.

Test build #36351 has finished for   PR 6822 at commit c51a2e2.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)
case class UnHex(child: Expression) extends UnaryExpression with Serializable

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #36354 has started for   PR 6822 at commit 26dbed2.

Test build #36354 has finished for   PR 6822 at commit 26dbed2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Factorial(child: Expression)
case class UnHex(child: Expression) extends UnaryExpression with Serializable

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #36461 has started for   PR 6822 at commit 26edf4f.

Test build #36461 has finished for   PR 6822 at commit 26edf4f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Thanks. I've merged this.


Code

Thank you for your great work! Looking forward to your complete code

Thank you for your great work! Looking forward to your complete code


Iterator in SimpleVector not working as intended.

Describe the Issue
When you implement the Iterator in SimpleVector, project will not build.
Library Name and Version:
Name: SimpleVector
Version: 1.0.1
Environment:

Platform/OS: [e.g., Windows, macOS, Linux] Windows
Arduino IDE version (if applicable): NA
PlatformIO version (if applicable): NA
Development board (if applicable): Simulated Arduino Uno

Library Source:

[x] GitHub
[x] PlatformIO Registry

Expected Behavior
Project should still build when implementing the Iterator.
Actual Behavior
Project does not build.
To Reproduce
Attempt to implement the Iterator.
Error Message & Code Snippet
Multiple Error Messages depending on how you try to implement it.

Issue patched in latest Github Release, Issue will be patched in next Platformio Release


[WIP] - Show OneDrive sync status

Show sync status for files and folders for Onedrive.
Fixes #1314
This PR adds support for showing Onedrive sync status.
Currently features a hideous UI but if the underlying stuff works it can be improved :)
To be checked (help needed)

Does the sync status appear on files and folders when you navigate to the Onedrive folder?
Are there any items without icons?
Are there inconsistencies between windows explorer sync status and status in the app?
Is performance ok?

How it works
Files and folders inside the OneDrive folder have the following file properties:

System.FileOfflineAvailabilityStatus -> for folders it has the following values:
online: 0
partially offline: 1
offline: 2
offline pinned: 3
empty folder: 5

System.FilePlaceholderStatus -> for files it has the following values (checked on my pc, could not find documentation):
online: 8
sync (downloading): 9
{sync (uploading): 6} maybe
offline: 14
offline pinned: 15

It looks like the basic functionality works. I would recommend moving the status to it's own column in the list view layout.

@yaichenbaum happy to hear that.
So you suggest:

an additional column in datagridview
an fonticon overlay (like now but smaller and on a corner of item icon) for gridview?

@yaichenbaum happy to hear that.
So you suggest to mimic windows explorer correct?

an additional column in datagridview
an fonticon overlay (like now but smaller and on a corner of item icon) for gridview

That sounds like a good way to do it.

Below the current status of UI, still need polish.
DataGrid

TileView

GridView

@gave92 Should we add a color to the sync status glyphs depending on the status?

@yaichenbaum I think it would be nice, but I don't if it plays well when shown above another icon in GridView
Pleas look at the comment above for a few doubts I have.

Is the status icon positioning ok? (Explorer puts the icons near the text in "GridView")

If possible, we should use a similar placement.

Should the icons in Tile/GridView have a background? Like a filled circle or something?

I think that would look good, if not, it shouldn't be too hard to tweak that later.

Should the icons in GridView scale when making elements bigger/smaller?

I don't think that's necessary.

Should the icons be colored (i.e. light blue/filled white for cloud and green for the checkmark)?

I think so, this would help the icons stand out a little bit mor.

@yaichenbaum Thank for the feedback, I'll let you know how it coming along!

@duke7553 yeah only it won't probably be extendable to other cloud services.

Maybe change all references of Onedrive -> OneDrive

Sure I'll do

For me it also works for the Synology Drive Client. Maybe we can detect somehow, if a directory or file supports sync functionality or expose a setting, where directories can be added.

We should also rename it to a neutral name without OneDrive.

@lampenlampen Do you mean that with this PR you get sync status icons also for Synology Drive Client?
Perhaps OneDrive -> CloudStorage or similar

Yes. I needed to tweak 2 statements to enable sync status for these folders, but then yes. I remember slightly reading in one of the OneDrive-blog posts some years ago, that the underlying infrastructure is available to other cloud-providers as well
Maybe othrs with other Providers can test this as well, so we get a list with which providers it works. (Dropbox, Google, ...?)

@lampenlampen Wow that's very nice to hear! For detecting whether a folder is synced perhaps we can check if the System.FileOfflineAvailabilityStatus folder property is present or not?
In any case I guess totally worth to check if this also works with other cloud providers.

@lampenlampen @gave92 I noticed there is a way we can test this through https://docs.microsoft.com/en-us/windows/win32/properties/props-system-storageproviderid . Examples of returned values include Local, Network, OneDrive, or Computer.
Secondly, I would prefer if we ensure the root StorageFolder of each directory has a StorageFolder.Provider != Local, etc. before assuming we should get a IStorageItem for each item. This is because doing so has a performance penalty.

@duke7553 Thanks for the info, a couple of questions:

Where did you get the values of the property (Local/Onedrive/Network/...) from?
Would this help to check whether a folder is synced to a cloud storage (different from Onedrive)?

@gave92 Sorry. I sent the wrong link.
Assuming these have the same return values, it really doesn't matter which one you use.
Correct Link: https://docs.microsoft.com/en-us/uwp/api/windows.storage.storageprovider.id?view=winrt-19041#Windows_Storage_StorageProvider_Id

The ID that is returned will depend on your provider.
Additionally, I assume this way works with different providers, as they would return their own value for this. We'll need to have someone who uses another cloud provider test this for us.

@duke7553 Ah thanks for the clarification, I thought it was a fixed enumeration value.
I guess I could check this with Google Drive at least.
But we would also have to check if the method I'm using for getting the status works with each provider.

@lampenlampen Coud you check if the latest commit shows the sync status for both OneDrive and Synology Drive Client (without modifications)?
What were your edits? Just the lines that were comparing the WorkingDirectory with OneDrivePath or something more?

Yes it works 👍. I only edited these two lines.

@gave92 I tested the latest changes and I like the direction it's going in, one suggestion I have is to update the status when it changes without requiring the user to refresh the directory.

@yaichenbaum Latest commit adds support for auto-refreshing the icon when the sync status changes.
@duke7553 Could you check if you agree with the implementation of this? To get notified of sync status changes I added the FILE_NOTIFY_CHANGE_ATTRIBUTES filter to ReadDirectoryChangesW. Do you think this could lead to an overflow of notifications (e.g in case of antivirus scanning the watched folder or something)?

@gave92 That is a valid concern, but would an antivirus scan actually change the attributes of an item?

@duke7553 I was thinking about the Last Access Time property which I think is update any time the file is opened (even if contents are not changed)

@yaichenbaum Latest commit adds support for auto-refreshing the icon when the sync status changes.

@gave92 It looks great!

@gave92 Have you looked at aligning the status icon with the item name in the grid layouts?

@yaichenbaum still have too try that. I was looking into the possibility to add the OneDrive specific file actions to the context menu (like "Free space", "Always keep on this device",...). Seems doable l but the changes are extensive and better put in a separate PR that adds support for missing context menu items in general.

I was looking into the possibility to add the OneDrive specific file actions to the context menu (like "Free space", "Always keep on this device",...). Seems doable l but the changes are extensive and better put in a separate PR that adds support for missing context menu items in general.
I'll try tweaking the UI as you suggest soon.

@gave92 Looking forward to those UI tweaks, we should definitely look at adding those context menu items, but I agree it's probably better for a separate PR.

Grid View

Tile View

@yaichenbaum What do you think?

@gave92 It looks great!


feat(bigquery): add better timers around every API call

Tested with bigquery connector-tests for accuracy.
Primary changes -

Updated PerfTimer implementation to allow pausing timer
Renamed BigQueryDataDictionary to BigQuerySchemaApi, added timers for the calls in this class.
Refractored core audit log extraction methods into new class BigQueryAuditLogApi, added timers for the calls in this class.

Refractors:

Refractored connection config and related methods in BigQueryConnectionConfig class.
Refractored BigQueryDataDictionary to include bigquery client as instance method and moved related static methods to instance methods.
Refractored lineage code to be solely in BigQueryLineageExtractor.
Refractored and moved all queries/query templates to bigquery_v2/queries.py

Functional changes -

Fix repetitive access to BQ exported audit logs in lineage case
Deduplicates insertId via QUALIFY in BQ exported audit logs in lineage case

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Looks like a legitimate failure on FAILED tests/unit/test_bigquery_source.py::test_get_projects_list_failure because of the project list change

Looks like a legitimate failure on FAILED tests/unit/test_bigquery_source.py::test_get_projects_list_failure because of the project list change

@asikowitz fixed the test.


Compiler crashes when fused type is used as part of C++ template specialization

Following Cython code with fused type cannot be compiled  with Cython 0.29.7/ Python 3.7.2/Ubuntu linux 18.04.
This error happends only if I use fused type to specialize template.

cdef extern from "func.h":
    void func1[L](L arg);

ctypedef fused Num:
    long

def test(Num n):
    cdef void (*p_func1) (Num)
    p_func1 = func1[Num]

The error is:
1/1] Cythonizing test.pyx
/usr/local/lib/python3.7/site-packages/Cython/Compiler/Main.py:367: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/ishimoto/src/cython_bug/test.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)

Error compiling Cython file:
------------------------------------------------------------
...
ctypedef fused Num:
    long

def test(Num n):
    cdef void (*p_func1) (Num)
    p_func1 = func1[Num]
                  ^
------------------------------------------------------------

test.pyx:10:19: Compiler crash in AnalyseExpressionsTransform

ModuleNode.body = StatListNode(test.pyx:2:0)
StatListNode.stats[1] = FusedCFuncDefNode(test.pyx:8:0,
    defaults = [...]/1,
    fused_compound_types = [...]/1,
    match = "dest_sig[{{dest_sig_idx}}] = '{{specialized_type_name}}'",
    no_match = 'dest_sig[{{dest_sig_idx}}] = None',
    nodes = [...]/1,
    specialized_pycfuncs = [...]/1)
FusedCFuncDefNode.stats[1] = DefNode(test.pyx:8:0,
    modifiers = [...]/0,
    name = 'test',
    np_args_idx = [...]/0,
    num_required_args = 1,
    outer_attrs = [...]/2,
    py_wrapper_required = True,
    reqd_kw_flags_cname = '0',
    specialized_signature_string = 'long',
    used = True)
File 'Nodes.py', line 436, in analyse_expressions: StatListNode(test.pyx:9:4)
File 'Nodes.py', line 5156, in analyse_expressions: SingleAssignmentNode(test.pyx:10:19)
File 'Nodes.py', line 5309, in analyse_types: SingleAssignmentNode(test.pyx:10:19)
File 'ExprNodes.py', line 895, in coerce_to: IndexNode(test.pyx:10:19,
    is_subscript = True,
    result_is_used = True,
    type_indices = [...]/1,
    use_managed_ref = True)

Compiler crash traceback from this point on:
  File "/usr/local/lib/python3.7/site-packages/Cython/Compiler/ExprNodes.py", line 895, in coerce_to
    for signature in src_type.get_all_specialized_function_types():
  File "/usr/local/lib/python3.7/site-packages/Cython/Compiler/PyrexTypes.py", line 2986, in get_all_specialized_function_types
    if self.entry.fused_cfunction:
AttributeError: 'CFuncType' object has no attribute 'entry'
Traceback (most recent call last):
  File "setup.py", line 16, in <module>
    ext_modules=cythonize(ext_modules),
  File "/usr/local/lib/python3.7/site-packages/Cython/Build/Dependencies.py", line 1097, in cythonize
    cythonize_one(*args)
  File "/usr/local/lib/python3.7/site-packages/Cython/Build/Dependencies.py", line 1220, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: test.pyx

I encountered what I think is the same error, but with different error message. I just post this here to make it easier to find if somebody looks for my error.
Code is
from libcpp.unordered_map cimport unordered_map
cimport cython

cdef:
    unordered_map[int, double] data
    unordered_map[cython.integral, double] data

Error message is
python3 setup.py build_ext --inplace
running build_ext
skipping 'test_000.cpp' Cython extension (up-to-date)
cythoning test_001.pyx to test_001.cpp
/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/ohaas/HESSENBOX-DA/PhD/code/openChargeState/test/unorderedMapc++ArrayKey/test_001.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)

Error compiling Cython file:
------------------------------------------------------------
...
cimport cython

cdef:
    unordered_map[int, double] data
    unordered_map[cython.integral, double] data
                 ^
------------------------------------------------------------

test_001.pyx:9:18: Compiler crash in AnalyseDeclarationsTransform

File 'ModuleNode.py', line 124, in analyse_declarations: ModuleNode(test_001.pyx:2:0,
    full_module_name = 'test_001')
File 'Nodes.py', line 431, in analyse_declarations: StatListNode(test_001.pyx:2:0)
File 'Nodes.py', line 431, in analyse_declarations: StatListNode(test_001.pyx:8:4)
File 'Nodes.py', line 1327, in analyse_declarations: CVarDefNode(test_001.pyx:9:4,
    modifiers = [...]/0,
    visibility = 'private')
File 'Nodes.py', line 1158, in analyse: TemplatedTypeNode(test_001.pyx:9:18)

Compiler crash traceback from this point on:
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Nodes.py", line 1158, in analyse
    self.type = base_type.specialize_here(self.pos, template_types)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3677, in specialize_here
    return self.specialize(dict(zip(self.templates, template_values)))
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3695, in specialize
    specialized.scope = self.scope.specialize(values, specialized)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2483, in specialize
    entry.type.specialize(values),
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 415, in specialize
    base_type = self.typedef_base_type.specialize(values)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3695, in specialize
    specialized.scope = self.scope.specialize(values, specialized)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2493, in specialize
    utility_code=e.utility_code)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2431, in declare_cfunction
    cname=cname, visibility=visibility)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2395, in declare_var
    entry.func_cname = "%s::%s" % (self.type.empty_declaration_code(), cname)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 51, in empty_declaration_code
    self._empty_declaration = self.declaration_code('')
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3749, in declaration_code
    for param in template_params
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3750, in <listcomp>
    if not is_optional_template_param(param) and not param.is_fused]
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 1582, in declaration_code
    return self.const_base_type.declaration_code("const %s" % entity_code, for_display, dll_linkage, pyrex)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 1649, in declaration_code
    raise Exception("This may never happen, please report a bug")
Exception: This may never happen, please report a bug

@oliverhaas I don't think it is the same bug. You're trying to declare a fused variable at the module scope. That definitely doesn't make sense. In a function Cython can pick which "version" of the function gets run; here there's never an opportunity to decide so it stays in an indeterminate "could be any of these types"-state.
It should probably give you a better error message though.

Yes, you're right. When I was simplifying my use case I went too far and made a nonsensical example.
This one should be more fitting:
from libcpp.unordered_map cimport unordered_map
cimport cython

cdef void someFun(cython.integral var) nogil:
    cdef unordered_map[int, double] data
    cdef unordered_map[cython.integral, double] data
    return

python3 setup.py build_ext --inplace
running build_ext
skipping 'test_000.cpp' Cython extension (up-to-date)
cythoning test_001.pyx to test_001.cpp
/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /home/ohaas/HESSENBOX-DA/PhD/code/openChargeState/test/unorderedMapc++ArrayKey/test_001.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)

Error compiling Cython file:
------------------------------------------------------------
...
from libcpp.unordered_map cimport unordered_map
cimport cython

cdef void someFun(cython.integral var) nogil:
    cdef unordered_map[int, double] data
    cdef unordered_map[cython.integral, double] data
                      ^
------------------------------------------------------------

test_001.pyx:7:23: Compiler crash in AnalyseDeclarationsTransform

ModuleNode.body = StatListNode(test_001.pyx:2:0)
StatListNode.stats[2] = StatListNode(test_001.pyx:5:5)
StatListNode.stats[0] = CFuncDefNode(test_001.pyx:5:5,
    args = [...]/1,
    has_fused_arguments = True,
    modifiers = [...]/0,
    visibility = 'private')
FusedCFuncDefNode.stats[0] = CFuncDefNode(test_001.pyx:5:5,
    args = [...]/1,
    modifiers = [...]/0,
    visibility = 'private')
File 'Nodes.py', line 431, in analyse_declarations: StatListNode(test_001.pyx:6:4,
    is_terminator = True)
File 'Nodes.py', line 1327, in analyse_declarations: CVarDefNode(test_001.pyx:7:9,
    modifiers = [...]/0,
    visibility = 'private')
File 'Nodes.py', line 1158, in analyse: TemplatedTypeNode(test_001.pyx:7:23)

Compiler crash traceback from this point on:
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Nodes.py", line 1158, in analyse
    self.type = base_type.specialize_here(self.pos, template_types)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3677, in specialize_here
    return self.specialize(dict(zip(self.templates, template_values)))
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3695, in specialize
    specialized.scope = self.scope.specialize(values, specialized)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2483, in specialize
    entry.type.specialize(values),
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 415, in specialize
    base_type = self.typedef_base_type.specialize(values)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3695, in specialize
    specialized.scope = self.scope.specialize(values, specialized)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2493, in specialize
    utility_code=e.utility_code)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2431, in declare_cfunction
    cname=cname, visibility=visibility)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/Symtab.py", line 2395, in declare_var
    entry.func_cname = "%s::%s" % (self.type.empty_declaration_code(), cname)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 51, in empty_declaration_code
    self._empty_declaration = self.declaration_code('')
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3749, in declaration_code
    for param in template_params
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 3750, in <listcomp>
    if not is_optional_template_param(param) and not param.is_fused]
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 1582, in declaration_code
    return self.const_base_type.declaration_code("const %s" % entity_code, for_display, dll_linkage, pyrex)
  File "/usr/local/lib/python3.5/dist-packages/Cython/Compiler/PyrexTypes.py", line 1649, in declaration_code
    raise Exception("This may never happen, please report a bug")
Exception: This may never happen, please report a bug
building 'test_001' extension
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/local/lib/python3.5/dist-packages/numpy/core/include -I/usr/local/include/ -I/usr/include/python3.5m -c test_001.cpp -o build/temp.linux-x86_64-3.5/test_001.o -O1 -std=c++11
cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++
test_001.cpp:1:2: error: #error Do not use this file, it is the result of a failed Cython compilation.
 #error Do not use this file, it is the result of a failed Cython compilation.
  ^
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

I don't see why this shouldn't generally work, so it's a bug.
Needs investigation to find where things go wrong, but might be easy to fix in the end.
This line in the traceback seems suggestive:
if not is_optional_template_param(param) and not param.is_fused]

Apparently, param was not detected as fused type, probably during the original analysis of the template arguments.

I ran into this too. My code looked like this.
from libc.stdint cimport (
  int8_t, int16_t, int32_t, int64_t,
  uint8_t, uint16_t, uint32_t, uint64_t,
)
from libcpp.vector cimport vector
from libcpp.map cimport map as mapcpp
from libcpp.utility cimport pair as cpp_pair
cimport numpy as cnp
ctypedef fused UINT:
  uint8_t
  uint16_t
  uint32_t
  uint64_t

def _runs(
    cnp.ndarray[UINT, ndim=1, cast=True] labels
  ):
  cdef mapcpp[UINT, vector[cpp_pair[size_t,size_t]]] rns


Clarify the usage of Name (not Username) and case sensitivity

Is your feature request related to a problem? Please describe.
This is not a problem, just a small suggestion to make the cofiguration even smoother:
It is not obvious that you are supposed to use Name in exceptions, since Usernames are more common in other systems.
Describe the solution you'd like
Add (or if it's already there) make it clearer that exceptions uses the Name, not the Username (which was my default guess), and also that exceptions are case sensitive.
Additional Context
Thank you so much for your effort!

Thanks, this is a strange one


OS3 Client CSS metaissue

Feel free to add things to do.

[x] When a user logges in the sidebar has a too large margin (255px instead of 240px). Doing any resize event or interaction updates the DOM and the sidebar updates the wrong margin. See image below.

@FinnStutzenstein cannot reproduce in current firefox nor chromium

logged out
set browser width to 960px (lowest "desktop" resolution)
cleared both caches
logged in
looks fine

However, what I did notice is that:

[ ]  the side panel grows with the username. Should probably have a fixed width of 240px.

I noticed:

[ ] Login-Page: When Page-height is too small the Login-Button will be hidden by the footer. (If the page-heigth is reduced even more, the login button, and everything else, will appear below the footer.

Found out, the issue with the side panel only occurs (/seems only to occur) when you have your dev-tools open and put on the bottom.

[ ] The text in the motion comment fields looks off. it should be left on top and next to it there should be the edit button (#3929)

[ ] Color for  .file-drop-style or theme for the ngx-file-drop should be overhauled and fit to the overall oing of CSS-Standard in OS.

We need pointer (for the cursor) on mat-chips, if a dropdown opens (see motion detail view)

Also: in the motion detail mat-chipy should not ripple, if they are not clickable. Also some dividers need to be hidden, if no entries are above or below them.
The text --- (set null) needs to be changed to set null, which should be displayed grey.

At the agenda the heading (h1) should have the same margin as the other content below.
In addition there should be at least some margin to the toolbar.

[ ] At least the topic edit (may also create) form lays ontop of the headbar.

[ ]  At least the topic edit (may also create) form lays ontop of the headbar.

Seems like the same issue as #4442 (everything with on-transistion-fade got a ridiculous z-index)

Cannot reproduce.

browser
version
steps to reproduce?

In the topic edit form, this can reproduced by limiting the browser's height to about half a screen.
In a topic detail view, the topic's content just needs to be long enough.
Both observed in chromium.

Can confirm this happens when you are actively resizing the browser windows in that view.
If you are not resizing your viewport it will not happen.

The list of speakers (last speaker section) has some flaws:
@ctschup Can you think of a better way to place these buttons. It's not nice how they are flapping around.. Also some other button design
@MaximilianKrambach You did the unix<->human time convertion. The m is redundant here.. Please fix this.

In the projector detail view. A bit of left and right padding would be nice.

@MaximilianKrambach You did the unix<->human time convertion. The m is redundant here.. Please fix this.

See #4469

@GabrielInTheWorld With #4473 the theme is also applied to the login page. At least with the red theme, the inputs are not visible. Please also check all other themes.

[ ] use the parent-selector over ::ng-deep (&.class)
[ ] view encapsulation can be used, if deeper components cannot be styles. It's not necessary to write everything in the globaly style.scss

@tsiegleauq @GabrielInTheWorld The webpage has a double-scrollbar when the offline message is shown

nothing left to do so far.
If anything else occurs create a new issue.


Installation is going on, but logging shows many lines of "[NuGet] Access to the path 'C:\Windows\System32\WebThreatDefSvc' is denied"

With the closure of issue #461, I restarted the installation again, and it seems going well so far. While the installation is still ongoing and the terminal says installation for some package are completed, many lines of the message below were displayed for each package:
[NuGet]: Access to the path 'C:\Windows\System32\WebThreatDefSvc' is denied.

Should I be concerned about this (repeated) message?

same for me.

I'm unsure where this stems from. Do the tools work as expected?

Unfortunately the installation on Windows 11 didn't complete - it seems stuck in a restart-installation-restart cycle. I had to terminate the installation.

Unfortunately the installation on Windows 11 didn't complete - it seems stuck in a restart-installation-restart cycle. I had to terminate the installation.

Again - same for me, exactly.


MacOS - OSX Support

Hello,
Now the official PCSX2 support for OSX is closer than ever.
I would like to use this plugin in OSX as well. I tried to compile myself, but it failed. I think that the CMakeLists.txt most probably is not ready to be used with OSX.
If you don't have Mac, I can be your tester if you want. Anyway either TravisCI how GitHub Actions both offer MacOS as an option to compile in.
Would be this possible?
Thanks in advance

same here.

same


Add an API which accepts a body of Content-Type: application/octet-stream

In the route routes/io, add a new API which accepts a body of Content-Type: application/octet-stream and provides a useful output.
This issue will be assigned only after you send across a working PR.

Please assign this issue to me.
I submitted the working PR
part of GSSOC -24

Hey @animator! is this issue available, I can work on it

hey @animator  I am interested in working on this issue, kindly assign it to me.


Send binary file/large file

See https://github.com/ariary/QueenSono/blob/main/hack/README.md#send-binary-file


none browser provider

Clear and concise description of the problem
While working on landing #3079, I found out that the initial feature of the browser mode which simply is just starting a server and waiting for the user to navigate to that URL in their own browser is removed! I believe we need to have it again since it's a huge DX win and can play really well with vitest ui for the users.
Suggested solution
Having a new provider as @sheremet-va said which handles this case, I assume not so much should be gone into this browser provider and only the provider methods should be filled (for the sake of the provider)! I'd name this provider the none provider which does not open any browser for you as wd/playwright does.
Alternative
It was there before #2999.
Additional context
#3079
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Before implementing this feature I would recommend outlining:

how it works
what does it achieve (without buzzwords)
who it will be useful for

I would also recommend asking other community members if we need such a feature.

As a provider, this feature will not require any automated browser to run, unlike webdriverio or playwright provider. Instead, we only need the browser server and its URL, which is currently available, to be given to the user. Therefore, the user can simply copy the URL and open it in their own browser. I expect less work in the openPage field for this one.
This approach will result in a faster response and a better and faster Developer Experience, especially for those who have their browsers next to their IDEs. Moreover, there will be no need for any dependency, and it can work in any environment and browser, which means that the user will not be limited to the browsers provided by Playwright or Webdriverio.
I understand that some of you may be concerned about isolation issues, such as extensions that the user has on their system. However, I do not see this as an issue since Vitest has a non-safe mode flag called --no-isolate next to the safe mode --isolate. Some users, including myself, may prefer the non-safe mode sometimes because of the experience it provides.
I believe that this new feature will be very useful for users who do TDD and those who use more special browsers instead of the regular ones. Also, it has the potential to work in stackblitz, which is currently not possible with other providers. I think this feature has the potential to be explored further and be accessed globally using a server that serves the vitest browser server.

This sounds like a cool feature for the use case of writing unit / UI / component tests. In this case just spinning up my local browser that maybe already include some Chrome Devtools plugins can help accelerate my work writing tests. However in CI or when I want to just run the test, this would be not my default choice. So I think it should be careful documented for what purpose this should be used for and running browser tests through WebDriver should stay the default. Aside, great idea 👍

I like the idea, we onlyn need a browser.
How about web containers? How can I test browser on StackBlizt?
On local you can run browser test with webdriverio on Chrome and them open Firefox and copy/paste the url.

How about web containers? How can I test browser on StackBlizt?

I believe this would be possible with the none provider.

There is openBrowser function in Vite, maybe we can just reuse it?

The problem with openBrowser is that we need to configure server.open = true | <url-path> before starting the dev server, if the dev server is started without previous configuration, it will not work (tested and not working): so, to make it working the none provider should be checked in the server integration for the browser to configure the open flag before starting it:
// packages/vitest/src/integrations/browser/server.ts
{
        enforce: 'post',
        name: 'vitest:browser:config',
        async config(config) {
          const browser: Pick<BrowserConfigOptions, 'api' | 'enabled' | 'provider'> = config.test?.browser ?? {}
          const server = resolveApiServerConfig(browser) || {
            port: defaultBrowserPort,
          }

          config.server = server
          config.server.fs ??= {}
          config.server.fs.strict = false

          if (browser.enabled === true && browser.provider === 'none')
            config.server.open = true

          return {
            resolve: {
              alias: config.test?.alias,
            },
          }
        },
      },

Can this issue be closed since https://github.com/vitest-dev/vitest/pull/4427 was merged?


Enable a bulk interface for converting examples

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

For bridged providers that do example discovery and conversion from TF HCL to PCL and further on to TypeScript and other languages, it would be great to have a command-line interface to convert many (thousands) of examples at once.
This is partially addressed
https://github.com/pulumi/pulumi-converter-terraform/pull/29
However as written #29 does not allow the caller to set the input file name so the functionality cannot be used.
Suggested alteration is to accept it in PULUMI_CONVERT_EXAMPLES environment variable or use some form of by-convention "examples.json" processing.
Affected area/feature

This works now with #29 latest changes.


Move non-project issues to /plan

Hey @arlissc & @stephwright -- I think it might help users if we move all our planning issues to the /plan repo and keep this as a list of projects. Does that make sense to you? Any objections?
Issues affected: #1, #3, #4 & this issue (#16)
(sorry it's late, I can't sleep 🌙 ⭐)

No objections, though wondering if it would make sense to just label these as planning and keep them here as they relate to the global sprint?  Then folks can filter out issues labeled "planning"

True, but thinking of ppl new to github I thought that might be more confusing

I'm happy to migrate and close the issues.  I support keeping this repo uncluttered for all points mentioned.

Okie doke!

Done!


Add option to attach disconnect/reconnect handlers to ocppj.Client

Approved. There's some conflicts with the other request I merged before.

@lorenzodonini this can be merged

Closing, included in https://github.com/lorenzodonini/ocpp-go/pull/117/


can't get a table printed out in the pdf

Hey,
I am using this plugin to allow my users print out their receipts. My receipt is inside a table, but when I use the pdf generator I am not getting the formatted table.
This is how I am invoking the pdf generator
  var printDoc = new jsPDF();
  printDoc.fromHTML($('#pdf').get(0), 10, 10, {
    'width': 180
  });
  printDoc.autoPrint();
  printDoc.output("dataurlnewwindow");

While my table is like this

Receipt

Order Id
{{receipt.ID}}

Price
{{receipt.total}} {{receipt.currencySymbol}}

Status
{{receipt.orderstatus}}

            Postify Address Text...

</tbody>

Hey mohsinali1317
did you find solution for your problem
i am interested in it
thank you

Hi there,
Thanks very much for your issue. We're closing many of the old issues while we focus on v2. If you
still think this is a major problem, please reopen.
Many thanks,
James


Update/Add Themes

Generated 3/2/15 from base16-builder
https://github.com/chriskempson/base16-builder

I've been out of the loop. but did the default theme change? That seems unlikely but the default.reg file has changed.

Not sure, I just found out about base16 today...


Clean up unused computations in Github

Everything coinstac-ssr-* can go. If @spanta28 and @rssk are okay, I will go ahead and archive (not delete) them myself.

Yes


Expand search to TESS data products

#365: This PR adds quick checks to determine the observing spacecraft for data products on MAST.
This works to find target pixel files:
import lightkurve as lk

tic_id = 273985862
lk.search_targetpixelfile(tic_id, spacecraft='Tess')

   obsID    target_name                     productFilename                        description     distance
----------- ----------- ------------------------------------------------------- ------------------ --------
17000015500          -- tess2018206045859-s0001-0000000273985862-0120-s_tp.fits Target pixel files       --

...and light curve files:
lk.search_lightcurvefile(tic_id, spacecraft='Tess')

   obsID    target_name                     productFilename                     description  distance
----------- ----------- ------------------------------------------------------- ------------ --------
17000015500          -- tess2018206045859-s0001-0000000273985862-0120-s_lc.fits Light curves       --

I added the spacecraft keyword to distinguish between K2 and TESS observations, because the current API considered tic_ids within the numerical range of K2.

[x] Rework Kepler-specific keywords in download functions
[x] Add ability to return TessTargetPixelFile or TessLightCurveFile objects from download

Codecov Report

Merging #367 into master will decrease coverage by 0.22%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   91.29%   91.06%   -0.23%
==========================================
  Files          26       26
  Lines        4032     4042      +10
==========================================
  Hits         3681     3681
- Misses        351      361      +10

Impacted Files
Coverage Δ

lightkurve/search.py
94.71% <85.71%> (-3.78%)
:arrow_down:

lightkurve/periodogram.py
86.39% <0%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21833db...b826599. Read the comment docs.

FFIs are also available on MAST and queryable with astropy. @barentsen & @mrtommyb, would it be worth introducing the ability to search and download FFIs? Maybe a search_ffi() or  search_fullframeimage() function?

Thanks @nksaunders!
First thought: the MAST API (docs here) already has fields called obs_collection  (= mission identifier) and project (= processing project).  I wonder if we want to follow the same nomenclature and pass that keyword on the astroquery.  Of course, by default it would be e.g. project=['Kepler', 'K2', 'TESS'].

Regarding FFIs: we should think about adding a search_fullframeimage(), but I think it'll need a lot more discussion and thinking than supporting light curve and target pixel files, so I would split FFI support off in separate issues/PRs.

Updated usage:
tic = 273985862

tpf = lk.search_targetpixelfile(tic, project='TESS').download()
lcf = lk.search_lightcurvefile(tic, project='TESS').download()

These will return a TessTargetPixelFile or TessLightCurveFile.
You can pass a radius = <arcsec> keyword into both search functions to perform a cone search.

Thanks @nksaunders! This is getting close! We'll want to add a couple of unit tests for TESS data though before merging.

Note: the TESScut service is currently supported as follows:

@gully is investigating if we need a nicer API!

We should add a sector keyword

To support queries by sector number, it looks like we'll have to parse the sxxxx sector number from the filename (e.g. tess2018206045859-s0001-0000000261136641-0120-s_tp.fits)

Before we can merge this, we need to revise some of the logic in _filter_products -- e.g. search_targetpixelfile("pi Mensae") does not return anything right now, whereas I would expect it to return a TESS product by default.

I reduced the complexity of search._filter_products() by adding three helper functions: _mask_kepler_products(), _mask_k2_products(), and _mask_tess_products().
This PR needs another careful review and additional testing, but I think we're close to supporting TESS without breaking Kepler/K2, e.g.:

Thanks @barentsen! I was struggling with how to handle arbitrary combinations of ['Kepler', 'K2', 'TESS'] project keywords being passed in, and I think you've found the best approach with the mask functions.
While experimenting, I found that astropy gives a NoResultsFound warning for certain TESS targets. For example:
lk.search_targetpixelfile(38847248)

gives the following error:
WARNING: NoResultsWarning: Query returned no results. [astroquery.mast.core]

But it also returns the desired search result. My solution is to catch and filter the AstropyWarning raised by Observations/query_criteria().

@nksaunders I was surprised to see all those new warnings raises, I don't quite understand why we didn't see them in the past.  We can suppress them, because we'll throw our own!

Great!  I'm going to go ahead and merge this.  Thanks @nksaunders!

FYI I just tried to install this version of lightkurve, and it says it cannot find the sklearn module? I can install myself, but thought maybe it should be required or something?

Same with the george package. And in this case, i am unable to pip install it, due to a problem with gcc being missing. I think if we are going to require these other packages, we want to make sure they're easy for people to get installed.

Okay, IGNORE my above comments! Nick switched his branch recently from tess-search to search-tess, and the latter does not produce these problems..

@barentsen is this merged? I just cloned the master repo and python setup.py install I get
import lightkurve
lightkurve.search.search_targetpixelfile('pi Mensae')

WARNING: NoResultsWarning: Query returned no results. [astroquery.mast.core]
No data found for target "pi Mensae."


Revisit for data cleaning and reformatting

Revisit for data cleaning and reformatting. Example:

masks should be in png not jpg format.
masks should have 0 background
general naming of the images.

@mkutu what should be the final name for the cropouts?
cropout_name = Path(image_path).stem + '_cropout.JPG' ??

cropout = <image_id>.jpg
cutout = <image_id>.png
cutout mask = <image_id>_mask.png
cutout metadata = <image_id>.json


Send Mail - Fails

Irrespective of what I try to configure the default.yaml with, I get the below error when uptime attempts to send mail..This crashes the uptime service.
Mongoose: checks.findOne({ _id: ObjectId("56573f59e675a62e16000007") }) { fields: undefined, safe: undefined }
/opt/node-uptime/node_modules/mongoose/lib/utils.js:413
throw err;
^
TypeError: undefined is not a function
at Nodemailer.setGeneralOptions (/opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:238:23)
at Nodemailer.generateMailObject (/opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:196:10)
at Nodemailer.sendMail (/opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:184:10)
at /opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:69:20
at Nodemailer.validateSettings (/opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:173:5)
at sendMail (/opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:63:12)
at Transport.transport.sendMail (/opt/node-uptime/node_modules/nodemailer/lib/nodemailer.js:40:9)
at Promise. (/opt/node-uptime/plugins/email/index.js:81:14)
at Promise. (/opt/node-uptime/node_modules/mongoose/node_modules/mpromise/lib/promise.js:162:8)
at Promise.emit (events.js:107:17)

Issue was with the Nodemailer version. While trying multimail plugin, happen to install<EMAIL_ADDRESS>after which the default email plugin started to work!!


Geobuf Index

Lets discuss indexing. Previous discussion: https://github.com/mapbox/geobuf/issues/27#issuecomment-67220880
I think the solution I'd like to see here is a separate PBF-based format that would come as a separate file coupled with a Geobuf file that would store:

serialized R-Tree (rbush) with leafs pointing to feature offsets in the geobuf pbf
a map of feature ids to feature offsets for fast single-feature seeking

The R-tree serialization should avoid embedded messages because they are hard to decode lazily. I'd imagine one possible solution to be nodes stored as a flat set of messages, with references to children implemented as offset pointers.

I implemented this idea. proto: https://github.com/cubao/geobuf-cpp/blob/dev/geobuf_index.proto
test: https://github.com/cubao/geobuf-cpp/blob/b06e682bae6f04ad9147659edbd8eecb9dfe2d3f/tests/test_geobuf.py#L1918


Thanos compact doesn't exit cleanly while downsample is in progress

Thanos, Prometheus and Golang version used:
thanos, version 0.30.1 (branch: non-git, revision: non-git)
  build user:       pbuilder@build2001
  build date:       20230109-11:18:40
  go version:       go1.19.4
  platform:         linux/amd64

Object Storage Provider: s3/swift
What happened:
I have issued a systemctl stop thanos-compact while compactor is downsampling a block, and the process fails to stop cleanly upon receiving SIGTERM (systemd times out, see below). I have to issue SIGKILL to get the process to stop
May 29 08:43:11 thanos-fe2001 thanos-compact[2812451]: level=info ts=2023-05-29T08:43:11.977604579Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=17.34>
May 29 08:43:31 thanos-fe2001 thanos-compact[2812451]: level=info ts=2023-05-29T08:43:31.60204033Z caller=main.go:172 msg="caught signal. Exiting." signal=terminated
May 29 08:43:31 thanos-fe2001 thanos-compact[2812451]: level=warn ts=2023-05-29T08:43:31.602184411Z caller=intrumentation.go:67 msg="changing probe status" status=not-ready reason=null
May 29 08:43:31 thanos-fe2001 systemd[1]: Stopping Thanos compact...
May 29 08:43:31 thanos-fe2001 thanos-compact[2812451]: level=info ts=2023-05-29T08:43:31.603816577Z caller=http.go:91 service=http/server component=compact msg="internal server is shutting down" err=null
May 29 08:43:31 thanos-fe2001 thanos-compact[2812451]: level=info ts=2023-05-29T08:43:31.604977334Z caller=http.go:110 service=http/server component=compact msg="internal server is shutdown gracefully" err=null
May 29 08:43:31 thanos-fe2001 thanos-compact[2812451]: level=info ts=2023-05-29T08:43:31.605086565Z caller=intrumentation.go:81 msg="changing probe status" status=not-healthy reason=null
May 29 08:43:31 thanos-fe2001 thanos-compact[2812451]: level=error ts=2023-05-29T08:43:31.607431256Z caller=compact.go:564 msg="retriable error" err="syncing metas: filter metas: filter blocks marked for no comp>
May 29 08:43:33 thanos-fe2001 thanos-compact[2812451]: level=info ts=2023-05-29T08:43:33.630481321Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=2.022>
May 29 08:43:51 thanos-fe2001 systemd[1]: thanos-compact.service: State 'stop-sigterm' timed out. Skipping SIGKILL.
May 29 08:44:11 thanos-fe2001 systemd[1]: thanos-compact.service: State 'final-sigterm' timed out. Skipping SIGKILL. Entering failed mode.
May 29 08:44:11 thanos-fe2001 systemd[1]: thanos-compact.service: Failed with result 'timeout'.
May 29 08:44:11 thanos-fe2001 systemd[1]: thanos-compact.service: Unit process 2812451 (thanos) remains running after unit stopped.
May 29 08:44:11 thanos-fe2001 systemd[1]: Stopped Thanos compact.
May 29 08:44:11 thanos-fe2001 systemd[1]: thanos-compact.service: Consumed 6d 16h 41min 10.983s CPU time.

What you expected to happen:
Thanos compact interrupts downsample cycle, cleans up and exits
How to reproduce it (as minimally and precisely as possible):
SIGTERM Thanos compact while a downsample operation is in progress

With a little more logs, still an issue though AFAICS
Feb 15 12:34:24 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:34:24.841167079Z caller=compact.go:1005 group="0@{prometheus=\"k8s\", replica=\"a\", site=\"eqiad\"}" groupKey=0@12299621920028672149 msg="compaction available and
planned; downloading blocks" plan="[01HPNBA4N2H37RG1GDQWA2K6MJ (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000) 01HPNJ5VX0AQ822F8XZN3VPFPJ (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000) 01HPNS1K5Q70456C9MKS0TEFZP (min time: 170796960
0000, max time:<PHONE_NUMBER>000) 01HPNZXAD3YPZPK74R2V1BBV2Q (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000)]"
Feb 15 12:35:08 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:35:08.601104754Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.683339342s duration_ms=4683 cached=9186
 returned=9186 partial=0
Feb 15 12:35:13 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:35:13.539432482Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=2m7.148353681s duration_ms=127148 cached=
9186 returned=7860 partial=1
Feb 15 12:36:08 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:36:08.602169956Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.684299763s duration_ms=4684 cached=9186
 returned=9186 partial=0
Feb 15 12:37:08 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:37:08.787034361Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.869111509s duration_ms=4869 cached=9186
 returned=9186 partial=0
Feb 15 12:37:22 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:37:22.767690117Z caller=compact.go:1071 group="0@{prometheus=\"k8s\", replica=\"a\", site=\"eqiad\"}" groupKey=0@12299621920028672149 msg="downloaded and verified b
locks; compacting blocks" plan="[/srv/thanos-compact/compact/0@12299621920028672149/01HPNBA4N2H37RG1GDQWA2K6MJ /srv/thanos-compact/compact/0@12299621920028672149/01HPNJ5VX0AQ822F8XZN3VPFPJ /srv/thanos-compact/compact/0@12299621920028672149
/01HPNS1K5Q70456C9MKS0TEFZP /srv/thanos-compact/compact/0@12299621920028672149/01HPNZXAD3YPZPK74R2V1BBV2Q]" duration=2m57.926487222s duration_ms=177926
Feb 15 12:38:04 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:38:04.378537081Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=2m5.617315734s duration_ms=125617 cached=
9186 returned=7845 partial=0
Feb 15 12:38:04 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:38:04.383929721Z caller=clean.go:34 msg="started cleaning of aborted partial uploads"
Feb 15 12:38:04 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:38:04.383979441Z caller=clean.go:61 msg="cleaning of aborted partial uploads done"
Feb 15 12:38:04 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:38:04.384001651Z caller=blocks_cleaner.go:44 msg="started cleaning of blocks marked for deletion"
Feb 15 12:38:04 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:38:04.384867691Z caller=blocks_cleaner.go:58 msg="cleaning of blocks marked for deletion done"
Feb 15 12:38:08 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:38:08.652724261Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.734142181s duration_ms=4734 cached=9186
 returned=9186 partial=0
Feb 15 12:39:08 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:39:08.702401753Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.784330209s duration_ms=4784 cached=9186
 returned=9186 partial=0
Feb 15 12:40:08 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:40:08.720469895Z caller=fetcher.go:478 component=block.BaseFetcher msg="successfully synchronized block metadata" duration=4.802518518s duration_ms=4802 cached=9186
 returned=9186 partial=0
Feb 15 12:40:09 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:40:09.61805125Z caller=main.go:172 msg="caught signal. Exiting." signal=terminated
Feb 15 12:40:09 titan2001 thanos-compact[924]: level=warn ts=2024-02-15T12:40:09.618107781Z caller=intrumentation.go:67 msg="changing probe status" status=not-ready reason=null
Feb 15 12:40:09 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:40:09.618136014Z caller=http.go:91 service=http/server component=compact msg="internal server is shutting down" err=null
Feb 15 12:40:09 titan2001 systemd[1]: Stopping thanos-compact.service - Thanos compact...
Feb 15 12:40:09 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:40:09.618312177Z caller=http.go:110 service=http/server component=compact msg="internal server is shutdown gracefully" err=null
Feb 15 12:40:09 titan2001 thanos-compact[924]: level=info ts=2024-02-15T12:40:09.618361843Z caller=intrumentation.go:81 msg="changing probe status" status=not-healthy reason=null
Feb 15 12:40:09 titan2001 thanos-compact[924]: level=error ts=2024-02-15T12:40:09.619325255Z caller=compact.go:593 msg="retriable error" err="filter metas: filter blocks marked for no compaction: context canceled"
Feb 15 12:40:10 titan2001 thanos-compact[924]: level=error ts=2024-02-15T12:40:10.385481804Z caller=compact.go:487 msg="critical error detected; halting" err="compaction: group 0@12299621920028672149: compact blocks [/srv/thanos-compact/co
mpact/0@12299621920028672149/01HPNBA4N2H37RG1GDQWA2K6MJ /srv/thanos-compact/compact/0@12299621920028672149/01HPNJ5VX0AQ822F8XZN3VPFPJ /srv/thanos-compact/compact/0@12299621920028672149/01HPNS1K5Q70456C9MKS0TEFZP /srv/thanos-compact/compact
/0@12299621920028672149/01HPNZXAD3YPZPK74R2V1BBV2Q]: 2 errors: populate block: context canceled; context canceled"
Feb 15 12:40:29 titan2001 systemd[1]: thanos-compact.service: State 'stop-sigterm' timed out. Skipping SIGKILL.
Feb 15 12:40:50 titan2001 systemd[1]: thanos-compact.service: State 'final-sigterm' timed out. Skipping SIGKILL. Entering failed mode.
Feb 15 12:40:50 titan2001 systemd[1]: thanos-compact.service: Failed with result 'timeout'.
Feb 15 12:40:50 titan2001 systemd[1]: thanos-compact.service: Unit process 924 (thanos) remains running after unit stopped.

The only thing that works to stop compact in this case is kill -9, any idea on what the problem could be ?

I would normally take a pprof dump of what goroutines are active to understand better the problem, in this case though the http server has shutdown already. Any pointers/ideas on how to debug this further ? thank you!


s/rock-solid compiler/ownership model/

Closes https://github.com/rust-lang/beta.rust-lang.org/issues/409.
It looks like https://github.com/rust-lang/beta.rust-lang.org/pull/403
already addressed the first suggestion in that issue, so this commit
only touches on the second.
cc @aturon

Perfect, thank you!


Brackets extension error

#my brackets is upto date yet some extensions are showing that they require newer version of brackets
My current version is 1.8

@Kooldiv latest version is now 1.9 - https://github.com/adobe/brackets/releases/tag/release-1.9
I've released some extensions earlier so pre-release users could install them.

Try modifying the extension to use "view/WorkspaceManager" instead of "view/PanelManager". I had problem installing the most of the extensions too.
https://github.com/adobe/brackets/issues/11960#issuecomment-374403225


Release should update version # in master and tag release commit.

Actually, the github release task already creates a matching tag. Automating version # in code would be nice tho.

For now we'll just update azure and version.py with major+minor version and leave build # in its automated state.


Simplify bosh manifests, migrating from spiff to spruce

https://github.com/18F/cg-deploy-bosh/pull/21

Spiff is depreciated and causes friction in bosh deploys currently

We've already deployed using Spruce. So this should be good to close.

Related to #406

(Adam thinks this should be constrained to the manifests for BOSH itself, and is likely done.)


Make gensokyo:roe a CompliantSwitch

I need to ask permission first.

Done. The new switch should be made slightly bigger and maybe moved to the inside of the main rail station to accommodate other rails in gensokyo:roe

34ce05aaa5c1eceda88ea83dd2d91f60122960db makes the above ground station compliant


[Feature Request]Ability to use a separate file which stores names of cookie files to use and either extractor/domain

Checklist

[ x ] I'm reporting a feature request
[ x ] I've verified that I'm running yt-dlp version 2021.04.11
[ x ] I've searched the bugtracker for similar feature requests including closed ones

Description

Basically I want to stop having to change the cookie file to use in the command line every time I want to use a different site so I'd ideally like to list all the cookie files I'd like to use in a single file. Either by extractor (like netrc) or domain.

Why not just dump all the relevant cookies into one file?

Why not just dump all the relevant cookies into one file?

Sometimes I only want to update one cookie while leaving another outdated (but valid).

I doubt this is possible to implement. I'll play around with the cookiejar a bit and let you know

I doubt this is possible to implement. I'll play around with the cookiejar a bit and let you know

Hmm... netrc is able to use specific logons based on extractor, I'd imagine it would be similar except all you are doing are redirecting it to a cookie with that file name (only needs to support working directory). Doing it by domain would be nice but most likely a lot harder.
Anyways, thanks for looking in to it.


why

could you please share your custom node

The node is just an experiment, normal/depth preprocs can work if the source resembles the SMPL mesh, but the normal map background should be removed which is missing from the initial test workflow. You can get some sort of results using only DWpose as well with some inputs.

Hi there, we have now released the rendering & SMPL code. There are some gap on the rendered conditions, especially for Semantic_map. You can follow the instructions on README.md. Let me know if it solve your problem.


Adding keys for Abhishek

Please test this

please test this

please test this

please test this

please test this

please test this

rebase and resubmit.


TensorFlow training for MNIST is failing

TensorFlow training is giving the following error:
$ kubectl logs tensorflow
python: can't open file '/tmp/models/official/mnist/mnist.py --export_dir /model/': [Errno 2] No such file or directory

This requires a PV to be created and then the model will be generated there instead.

Fixed by https://github.com/aws-samples/machine-learning-using-k8s/pull/56


CPU load and IntelliSense stop working with Create React App

Hello everyone, As the title explains: the VS Code IntelliSense stop working when creating a new react app using both npx or create-react-app cli
Also, just by opening the newly created react app, I keep having high CPU load to that I can hear the CPU fan.
System Info

Windows 10 Pro 1909
Processor Intel(R) Core(TM) i5-9400F
RAM 16.0 GB

VS Code

Version: 1.41.0 (user setup)
Commit: 9579eda04fdb3a9bba2750f15193e5fafe16b959
Date: 2019-12-11T18:37:42.077Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18363

What I've Tried

code --disable-extensions
Uninstall all extensions
Re-install vs code (same version 1.41.0)
Install via npx and create-react-app cli v3.3.0

And finally I've downgraded to v1.40.2 and all IntelliSense back to work as usual and no more CPU load.
Thank you,

I am having the exact same problem, it only happens after 1.41 update and with a create-react-app project.

@StebanDev Sure, go to https://code.visualstudio.com/updates/ and from the left sidebar click on the previous release (October 2019)  which is v1.40.2 and don't forget to disable auto updates
From Setting search for update > update mode and set it to none.
Check here for more info
https://stackoverflow.com/questions/49346733/how-to-downgrade-vscode

Thanks @awran5, I installed it and now everything's working fine. I hope it could get fixed soon

I can reproduce with the following steps (Windows 10 - vscode 1.41 system setup)

clone and yarn install https://github.com/blikblum/lit-element-mobx-realworld-example-app
go to https://github.com/blikblum/lit-element-mobx-realworld-example-app/blob/master/test/dummy-superagent.js
Start a import statement and try to launch intelisense: import 'sup|' (Ctrl +Space) -> cpu usage will peak and remain high with a Loading indicator
Alternatively add a complete import like import 'superagent'  Ctrl + Click on 'superagent' -> high cpu usage for long time

I downgraded to 1.40.2 and the above commands are instantaneous without cpu usage peaks

@blikblum Extracted to https://github.com/microsoft/TypeScript/issues/35716
@awran5 Can you please follow these instructions to collect performance information. Share the output of code --status while the cpu usage is happening
Also how long does the cpu usage spike last? Does it eventually go away

Also how long does the cpu usage spike last? Does it eventually go away?

I did a test. Triggered the steps above at 20:53h and went to dinner. Get back at 21:06 and the CPU usage is still high with the CPU FAN spinning. Killing vscode drops the cpu load

@blikblum Please follow up on the issue I extracted instead of here: microsoft/TypeScript#35716

@mjbvz I've included all the information. About CPU usage spike, it doesn't go away as long as VS code is open (tested for about 10 minutes). Actually I guess its obvious what causing this that **electron_node tsserver.js ** is taking about 16% - 17% of CPU usage all the time. Thank you.


Add client_pwd toggle

This PR make module backward compatible for those who has no luxury of changing password on running clusters.
If client_pwd is not passed it will be generated as with current master.

wait I'll rebase it

bump


[Feat]: Make it possible to customize cc-main z-index

Description
Our use case requires the cookie consent panel to stay below some other elements to allow the user e.g. to change language before accepting cookies. While it's possible to override the hard-coded<PHONE_NUMBER>, it would be nicer if it was a css variable or something that could be customized without having to resort to !important.
Proposed solution
Move the hard-coded style attribute to css so that it can be overridden.
Additional details
No response

Sure, is this for v2 or v3?

@orestbida Sorry, missed one of the most important bits. This is about v3.

fixed in 91e1877


cmd/go: go.env modifications during bootstrap makes tests fail

What version of Go are you using (go version)?

$ go version
go version go1.20.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOOS="linux"

What did you do?
Using go1.21rc3, modify the go.env file in the root folder to different values.
What did you expect to see?
No failure
What did you see instead?
vcs-test.golang.org rerouted to http://<IP_ADDRESS>:41523
https://vcs-test.golang.org rerouted to https://<IP_ADDRESS>:43845
go test proxy running at GOPROXY=http://<IP_ADDRESS>:42835/mod
--- FAIL: TestScript (0.15s)
    --- FAIL: TestScript/mod_sumdb_golang (0.04s)
        script_test.go:132: 2023-07-14T16:32:19Z
        script_test.go:134: $WORK=/tmp/cmd-go-test-3903922678/tmpdir168532271/mod_sumdb_golang759362308
        script_test.go:156:
            # Test default GOPROXY and GOSUMDB (0.040s)
            > env GOPROXY=
            > env GOSUMDB=
            > go env GOPROXY
            [stdout]
            direct
            > stdout '^https://proxy.golang.org,direct$'
        script_test.go:156: FAIL: testdata/script/mod_sumdb_golang.txt:5: stdout ^https://proxy.golang.org,direc
t$: no match for `(?m)^https://proxy.golang.org,direct$` in stdout
FAIL
FAIL    cmd/go  45.416s

This used to happend to in rc2 as far as I know: https://github.com/golang/go/issues/57179#issuecomment-1614974086

Using go1.21rc3, modify the go.env file in the root folder to different values.

@alexsaezm could you clarify the exact commands you run? Modify the go.env file, then run all.bash?
And does this reproduce with Go 1.20? Thanks.
Perhaps setting GOPROXY and GOSUMDB to empty just makes them to use the value in the go.env file. The test probably needs some mechanism to ignore go.env file.
cc @bcmills @matloob

Using go1.21rc3, modify the go.env file in the root folder to different values.

Which values specifically?

I modified the go.env file in the root of the project like this:
$ cat go.env
# This file contains the initial defaults for go command configuration.
# Values set by 'go env -w' and written to the user's go/env file override these.
# The environment overrides everything else.

# Use the Go module mirror and checksum database by default.
# See https://proxy.golang.org for details.
GOPROXY=direct
GOSUMDB=off

# Automatically download newer toolchains as directed by go.mod files.
# See https://go.dev/doc/toolchain for details.
GOTOOLCHAIN=auto

And then, I ran ./all.bash.
To clarify, this doesn't happen in 1.20 because there is no go.env file.

@alexsaezm, https://go.dev/cl/509637 should fix this at HEAD; can you please build at commit 229cde5 or later and confirm?

@alexsaezm, https://go.dev/cl/509637 should fix this at HEAD; can you please build at commit 229cde5 or later and confirm?

It works. Thank you!
Regarding the commit message about the builders: just for the record, Fedora's Go package is built with the go.env modified so in case of any error, I'll report it. (Not a substitute of a builder by any means, because it's not integrated at all with Go upstream systems and includes other patches but, just to let you know)


Add digest param, default to sha1

Hi! Thanks for your work on this project.
As of Node 6, crypto.pbkdf2 requires that you explicitly pass a digest; the previously-optional param is now required.
I checked the rails docs, and the default digest algorithm used is sha1. So I set that as the default here.
This should be a completely transparent change to users on Node 5 and earlier, but it means Node 6+ users won't get deprecation warnings in their apps.
It also means that if users decide to use a more-secure digest (highly recommended these days, sha1 is very weak), this module can be used, by providing an override.

Thank you! Could you also update .travis.yml file so the tests would pass? I think we can drop the support for node 0.10 and adding the newer versions wouldn't hurt.

@smirzaei done :) Opted for the newest versions in the 5.x and 6.x series.

Awesome! Thank you 👍


Mail not receiving properly

Hello team,
On simulation of Charging stations mails received to admin is not in proper conditions. Please look into once below

any chance to get the reply on this issue ?

What do you me by proper condition?

i Need to send the issue in detail ?

I don't know what's wrong with the email ;)

The Notification comes to admin when Charging Station get Connected or Registered
The Email Template not coming properly, not html loading, original raw email coming to admin mail id
issue might be in https://github.com/sap-labs-france/ev-server/blob/c603f935ef3c33ae5006c4dfe1de05115dbdbf93/src/notification/email/EMailNotificationTask.ts#L79
This is the screenshot below

Ah ok, I got it.
@rmangin-fr Could you have a look and test the email notif on a GMail account?
Thanks!

Tested with no reproducible case.
GMail shows the ChargingStationRegistered notification as expected
See screenshot bellow:

German language tested as well with no error:

Hi,
Here is the English evidence of not reproducible:

Smtp compatibility might be ?
Can you please share your config file? Might be i am missing something
there ?
On Wed, 10 Nov 2021 at 9:10 PM, rmangin-fr @.***> wrote:

Hi,
Here is the English evidence of not reproducible:
[image: image]
https://user-images.githubusercontent.com/59734752/141144027-2e13f908-b034-487b-8972-7de56e673499.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sap-labs-france/ev-server/issues/3034#issuecomment-965428310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHV2IBPHYJWBZGVVP7UHE4TULKG5PANCNFSM5HPOFP7Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Not a lot to share:

Let me know if your problem is solved.


Added Covid-19 Vaccination progress model

What for that index.html file?

To create a folder I added a dummy file on the forked repository. And after uploading my notebook I deleted the dummy file.


glossary: translate annotation and api-group into Bahasa

xref #24347
/cc @ariscahyadi @girikuncoro

Thanks @habibrosyad for addressing these glossary as part of #24382!
/lgtm

/lgtm
/approve


Checklist for migration to 0.6.x and React 18.

It would be nice if the community knew what sort of contributions are needed to test recoil-persist's compatibility with 0.6/R18.
I'm doing it over a --force install and will report my findings here, but if anyone has some information on that already, let's coordinate here.

@polemius Is this a possibility? Recoil released 0.7.1 which supports react 18 typescript.

@elilondon thanks for bumping. My experience was more or less "it just works".
FYI, I moved from recoil to jotai for easy URL serialisation and persistence OOTB. Don't mean to advertise or anything, but maybe for someone it'll be useful to learn about alternatives.

@cognivore Thanks! I looked at that and it is quite the package (all in one might be nice.) I pulled this local and updated myself to work with the latest things earlier but want to see if I get any feedback from the owner. If not I will throw up my own package forked from his.


Fix navigation

This is a PR to get the demo scene for navigation back up and running.
[x] Get data from new cache
[ ] Update verts to proper matrix data
I am currently having trouble with the scale of the colliders. The transform and rotation seem to work but without scaling the data is way off as seen below.

Ignore the debug garbage code for now. I just need it to see the nav mesh, I will remove in the final PR version.


Feature Addition: Buttons can be active high or low

Added the ability to have active high or active low buttons.
Examples changed to comply.  Thanks for the library

opps, also exposed the elapsed time of the timer in this branch