Fixes #3778: Decouples Command from KeyBindings

Fixes

Fixes #3778

Proposed Changes/Todos

[x] Change CommandContext to be generic
[x] Refactor KeyBindings to use new CommandContext<T>
[x] Implement just enough mouse binding to ensure design will work.
[x] Combine KeyBindings, ApplicationKeyBindings, and MouseBindings to reduce duplicate code.
[x] Update Conceptual Docs

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[x] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

With what I've done so far all of the Keyboard and Mouse handling code in CharMap is reduced to this:
       AddCommand (Command.Up, commandContext => Move (commandContext, -16));
       AddCommand (Command.Down, commandContext => Move (commandContext, 16));
       AddCommand (Command.Left, commandContext => Move (commandContext, -1));
       AddCommand (Command.Right, commandContext => Move (commandContext, 1));

       AddCommand (Command.PageUp, commandContext => Move (commandContext, -(Viewport.Height - HEADER_HEIGHT / _rowHeight) * 16));
       AddCommand (Command.PageDown, commandContext => Move (commandContext, (Viewport.Height - HEADER_HEIGHT / _rowHeight) * 16));
       AddCommand (Command.Start, commandContext => Move (commandContext, -SelectedCodePoint));
       AddCommand (Command.End, commandContext => Move (commandContext, MAX_CODE_POINT - SelectedCodePoint));

       AddCommand (Command.ScrollDown, () => ScrollVertical (1));
       AddCommand (Command.ScrollUp, () => ScrollVertical (-1));
       AddCommand (Command.ScrollRight, () => ScrollHorizontal (1));
       AddCommand (Command.ScrollLeft, () => ScrollHorizontal (-1));

       AddCommand (Command.Accept, HandleAcceptCommand);
       AddCommand (Command.Select, HandleSelectCommand);
       AddCommand (Command.Context, HandleContextCommand);

       KeyBindings.Add (Key.CursorUp, Command.Up);
       KeyBindings.Add (Key.CursorDown, Command.Down);
       KeyBindings.Add (Key.CursorLeft, Command.Left);
       KeyBindings.Add (Key.CursorRight, Command.Right);
       KeyBindings.Add (Key.PageUp, Command.PageUp);
       KeyBindings.Add (Key.PageDown, Command.PageDown);
       KeyBindings.Add (Key.Home, Command.Start);
       KeyBindings.Add (Key.End, Command.End);
       KeyBindings.Add (ContextMenu.DefaultKey, Command.Context);

       MouseBindings.Add (MouseFlags.Button1DoubleClicked, Command.Accept);
       MouseBindings.ReplaceCommands(MouseFlags.Button3Clicked, Command.Context);
       MouseBindings.ReplaceCommands (MouseFlags.Button1Clicked | MouseFlags.ButtonCtrl, Command.Context);
       MouseBindings.Add (MouseFlags.WheeledDown, Command.ScrollDown);
       MouseBindings.Add (MouseFlags.WheeledUp, Command.ScrollUp);
       MouseBindings.Add (MouseFlags.WheeledLeft, Command.ScrollLeft);
       MouseBindings.Add (MouseFlags.WheeledRight, Command.ScrollRight);

Here's the excerpt from keyboard.md highlighting the new model found in this PR:
Keyboard APIs
Terminal.Gui provides the following APIs for handling keyboard input:

Key - @Terminal.Gui.Key provides a platform-independent abstraction for common keyboard operations. It is used for processing keyboard input and raising keyboard events. This class provides a high-level abstraction with helper methods and properties for common keyboard operations. Use this class instead of the low-level KeyCode enum when possible.
Key Bindings - Key Bindings provide a declarative method for handling keyboard input in View implementations. The View calls @Terminal.Gui.AddCommand to declare it supports a particular command and then uses @Terminal.Gui.KeyBindings to indicate which key presses will invoke the command.
Key Events - The Key Bindings API is rich enough to support the vast majority of use-cases. However, in some cases subscribing directly to key events is needed (e.g. when capturing arbitrary typing by a user). Use @Terminal.Gui.View.KeyDown and related events in these cases.

Each of these APIs are described more fully below.
Key Bindings
Key Bindings is the preferred way of handling keyboard input in View implementations. The View calls @Terminal.Gui.AddCommand to declare it supports a particular command and then uses @Terminal.Gui.KeyBindings to indicate which key presses will invoke the command. For example, if a View wants to respond to the user pressing the up arrow key to scroll up it would do this
public MyView : View
{
  AddCommand (Command.ScrollUp, () => ScrollVertical (-1));
  KeyBindings.Add (Key.CursorUp, Command.ScrollUp);
}

The Character Map Scenario includes a View called CharMap that is a good example of the Key Bindings API.
The Command enum lists generic operations that are implemented by views. For example Command.Accept in a Button results in the Accepting event
firing while in TableView it is bound to CellActivated. Not all commands
are implemented by all views (e.g. you cannot scroll in a Button). Use the @Terminal.Gui.View.GetSupportedCommands method to determine which commands are implemented by a View.
The default key for activating a button is Space. You can change this using
KeyBindings.ReplaceKey():
var btn = new Button () { Title = "Press me" };
btn.KeyBindings.ReplaceKey (btn.KeyBindings.GetKeyFromCommands (Command.Accept));

Key Bindings can be added at the Application or View level.
For Application-scoped Key Bindings there are two categories of Application-scoped Key Bindings:

Application Command Key Bindings - Bindings for Commands supported by @Terminal.Gui.Application. For example, @Terminal.Gui.Application.QuitKey, which is bound to Command.Quit and results in @Terminal.Gui.Application.RequestStop being called.
Application Key Bindings - Bindings for Commands supported on arbitrary Views that are meant to be invoked regardless of which part of the application is visible/active.

Use @Terminal.Gui.Application.KeyBindings to add or modify Application-scoped Key Bindings.
View-scoped Key Bindings also have two categories:

HotKey Bindings - These bind to Commands that will be invoked regardless of whether the View has focus or not. The most common use-case for HotKey bindings is @Terminal.Gui.View.HotKey. For example, a Button with a Title of _OK, the user can press Alt-O and the button will be accepted regardless of whether it has focus or not. Add and modify HotKey bindings with @Terminal.Gui.View.HotKeyBindings.
Focused Bindings - These bind to Commands that will be invoked only when the View has focus. Focused Key Bindings are the easiest way to enable a View to support responding to key events. Add and modify Focused bindings with @Terminal.Gui.View.KeyBindings.

Application-Scoped Key Bindings
HotKey
A HotKey is a key press that selects a visible UI item. For selecting items across Views (e.g. a Button in a Dialog) the key press must have the Alt modifier. For selecting items within a View that are not Views themselves, the key press can be key without the Alt modifier.  For example, in a Dialog, a Button with the text of "_Text" can be selected with Alt+T. Or, in a Menu with "_File _Edit", Alt+F will select (show) the "_File" menu. If the "_File" menu has a sub-menu of "_New" Alt+N or N will ONLY select the "_New" sub-menu if the "_File" menu is already opened.
By default, the Text of a View is used to determine the HotKey by looking for the first occurrence of the @Terminal.Gui.View.HotKeySpecifier (which is underscore (_) by default). The character following the underscore is the HotKey. If the HotKeySpecifier is not found in Text, the first character of Text is used as the HotKey. The Text of a View can be changed at runtime, and the HotKey will be updated accordingly. @"Terminal.Gui.View.HotKey" is virtual enabling this behavior to be customized.
Shortcut
A Shortcut is an opinionated (visually & API) View for displaying a command, help text, key key press that invokes a Command.
The Command can be invoked even if the View that defines them is not focused or visible (but the View must be enabled). Shortcuts can be any key press; Key.A, Key.A.WithCtrl, Key.A.WithCtrl.WithAlt, Key.Del, and Key.F1, are all valid.
Shortcuts are used to define application-wide actions or actions that are not visible (e.g. Copy).
MenuBar, ContextMenu, and StatusBar support Shortcuts.

And here's the new mouse.md:
Mouse APIs
Terminal.Gui provides the following APIs for handling mouse input:

MouseEventArgs - @Terminal.Gui.MouseEventArgs provides a platform-independent abstraction for common mouse operations. It is used for processing mouse input and raising mouse events.
Mouse Bindings - Mouse Bindings provide a declarative method for handling mouse input in View implementations. The View calls @Terminal.Gui.AddCommand to declare it supports a particular command and then uses @Terminal.Gui.MouseBindings to indicate which mouse events will invoke the command.
Mouse Events - The Mouse Bindings API is rich enough to support the  majority of use-cases. However, in some cases subscribing directly to key events is needed (e.g. drag & drop). Use @Terminal.Gui.View.MouseEvent and related events in these cases.

Each of these APIs are described more fully below.
Mouse Bindings
Mouse Bindings is the preferred way of handling mouse input in View implementations. The View calls @Terminal.Gui.AddCommand to declare it supports a particular command and then uses @Terminal.Gui.MouseBindings to indicate which mouse events will invoke the command. For example, if a View wants to respond to the user using the mouse wheel to scroll up, it would do this:
public MyView : View
{
  AddCommand (Command.ScrollUp, () => ScrollVertical (-1));
  MouseBindings.Add (MouseFlags.Button1DoubleClick, Command.ScrollUp);
}

The Command enum lists generic operations that are implemented by views.

@tznind, i'd love your comments on all this.

@tznind thanks a ton! As I had hoped, you nailed it.
So. Much. Better.


properly concatenate base url and path

closes #487
If the issuer in the jwt ends with a slash such as:   "iss": "https://localhost:11280/", the url to fetch the CA bundle would get concatenated with a doubled slash:
https://localhost:11280//edge/client/v1

both are now trim/concatenated


Rename files in test/

I suggest to rename files in test/ dir:

name FPC project as test_fpc.*
name Delphi project as test_delphi.*
rename pas unit with tests to "tests.pas"
adjust also CI file "test.sh" and .gitignore

do you agree? @andgineer

yes


feat: NewExits and NewInflightExits for non state updating functions

:clipboard: https://github.com/omisego/new-tx-type-poc/issues/13
Overview
As the first step to make the Core state thinner, we are first removing the places that insert new state about exit events to the process memory.
Previously, for most event action it would: 1. update the state of the ExitProcessor 2. Return db_updates and will eventually be send to OMG.DB to update the db accordingly.
Now we are trying to remove the usage of the state of the ExitProcessor. Thus provide and use function that does not need to access state.
This PR provides the initial ones: new_exit and new_in_flight_exit.
Changes

Add new modules NewExits and NewInflightExits for the update_db related functions.
Use the new module to provide db_updates while still calling the Core to keep the state getting update until we are able to remove all state reading.

Testing

added unit test
compare the result (db_updates) of new modules with the existing Core function.

Coverage remained the same at ?% when pulling b94b949ab9c8d8da6fe62869a031f468609c0213 on boolafish/new_exit_processor_core into d118f210b41c49aa29d5f5e2e1bdea70c5ab9fa2 on master.

we are pausing refactoring works due to low engineer resources in the cycle C. We will prioritize exercise part further on this cycle. closing this PR to avoid introducing half way refactoring.


AWS managed OTel layer Initial release

support python3.8, nodejs, java, javaagent 4 knids
update sample applications
update README.md and CHANGELOG.me

Split README and CHANGELOG with comments fix in https://github.com/aws-observability/aws-otel-lambda/pull/75


Add fields for links expansion

The commit 646d64f252a5393d8d30b0319361b8548bf49d12 added extra fields in order
to hold content_ids of links for a given document.
The next step in the process is to expand links based on those content IDs. In
order to do that transparently, this commit adds 3 new fields to each document:

expanded_topics
expanded_organisations
expanded_mainstream_browse_pages

These new fields are meant to replace, in the future, the following fields:

specialist_sectors
organisations
mainstream_browse_pages

For now we will be expanding the new fields, which will allow us to migrate
existing applications to use the new behaviour.
When all applications have been moved across, we can deprecate the fields
mentioned above.

This is actually not needed if those fields are included in the default return list. Closing for now.


Resolve issues reported by Lighthouse

Lighthouse reports the following issues with the Shaka Player demo:

Manifest does not have icons at least 512px.
First meaningful paint: 3,180 ms
Perceptual Speed Index: 4,532 (target: < 1,250)

Reduce render-blocking scripts (these contribute 600 ms to load time)
Reduce render-blocking stylesheets (these contribute 590 ms to load time)

Low contrast elements:

<button id="loadButton">

[user-scalable="no"] is not used in the  element and the [maximum-scale] attribute is not less than 5.

Disabling zooming is problematic for users with low vision who rely on screen magnification to properly see the contents of a web page.
Failing element: <meta name="viewport" content="width=device-width, user-scalable=yes, initial-scale=1, maximum-scale=1">

Does not use passive listeners to improve scrolling performance.

Lighthouse also reports that the page could load more quickly, based on the presence of render-blocking resources like JS & CSS.

Improvements after fixing render-blocking scripts:

First meaningful paint: 660 ms
Perceptual Speed Index: 1,982 (target: < 1,250)

All touch event listeners are now marked explicitly with passive: false or passive: true.  This does not silence the warning from Lighthouse, though, since one of them is still non-passive.  It must remain so, since we call preventDefault() on the event.
Issues have already been filed on both Chrome and Lighthouse to fix this and respect passive: false:

https://bugs.chromium.org/p/chromium/issues/detail?id=770208
https://github.com/GoogleChrome/lighthouse/issues/3137

The only remaining complaint from LightHouse is this one:

Reduce render-blocking stylesheets (these contribute 590 ms to load time)

This is caused by Google Web Fonts, which seem fundamentally at odds with best practices recommended by Lighthouse.  We will continue to use these fonts.


WSL2 - clock problems during build

Sorry if this duplicate - I tried to search and saw several messages which are referring to same/similar problem, however there seems to be no separate assigned recent entry tracking this particular problem. Mostly people complain about date being skewed (some workarounds are available) - this one however as far as I could tell has no workaround and is easily reproducible in the latest 2004 build, which make WSL 2 completely unsuitable for any real development use.
Windows 10 build 19041.153, attempting to use WSL2, files are on Windows file system (not rootfs):
-- Build files have been written to: /mnt/e/projects/misc/wsl-ssh-agent/release
make: Warning: File 'Makefile' has modification time 0.6 s in the future
make[1]: Warning: File 'CMakeFiles/Makefile2' has modification time 0.65 s in the future
make[2]: Warning: File 'CMakeFiles/bin_agent.dir/progress.make' has modification time 0.61 s in the future
Scanning dependencies of target bin_agent
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
make[2]: Warning: File 'CMakeFiles/bin_agent.dir/progress.make' has modification time 0.51 s in the future
[100%] Building wsl-ssh-agent-gui...
make[2]: warning:  Clock skew detected.  Your build may be incomplete.
[100%] Built target bin_agent
make[1]: warning:  Clock skew detected.  Your build may be incomplete.

Could hv_utils: cannot register PTP clock: 0 be the reason for that?

This is a duplicate of #4677 which you have also commented in @rupor-github
Use sudo hwclock -s to re-sync your hardware clock in your build scripts.

It does not help

That would be very helpful to know and provide useful in that issue.

Sure - I am here to provide anything which is missing, could you please kindly explain what you need?
So far it goes like that:

I have been using WSL v1 for quite sometime, one of the projects I work on is https://github.com/rupor-github/wsl-ssh-agent. It has bash script to build it which invokes cmake. Works like a charm. My distro is Pengwin (which from what I could tell is slightly customized Debian testing)
Converted WSL distro to WSL v2 yesterday after installing Windows 10 build 19041.153. Now when I am running build script I get above mentioned error (every time all the time - reliably). Running hwclock or ntpdate only changes the skew value - problem stays.
Running dmesg I could see:

[    0.446543] hv_utils: cannot register PTP clock: 0
......
[    0.464916] Unstable clock detected, switching default tracing clock to "global"
               If you want to keep using the local clock, then add:
                 "trace_clock=local"
               on the kernel command line

Looked around - similar problems have been mentioned in context of time/date sync problems due to sleep.  In my case this is desktop which does not sleep. So I decided to make it separate - as this is important.

After using WSL2 for a while I could state with reasonable accuracy that this problem only shows when build happens outside rootfs - in other words if build directory is hosted on devfs (9p?) mounted NTFS file system. When I move everything into home directory - this problem disappears. This holds true even for latest 2004.208 build. At the same time under WSL1 this never happens.

Yeap, I also face this problem.

same problem.

/dupe #4677 and #5324


explore view functions as onchain logic for offchain backends with hidden information

Let's say I have a game that's hybrid onchain/offchain where I want to enable players to control in-game entities with onchain logic. Let's also say that player position is only offchain and not meant to be broadcasted (otherwise you might get killed or robbed or whatever).
Using Minecraft as an example, I want to enable players to have a "programmable door" where the player can control whether the door will open/close when interacted with. The open/close state is controlled by the offchain backend:

the game client sends a request to the backend to open the door
the backend asks the programmed door's view function if the door should be opened
if so, the backend changes the door state to open

Let's say we only want to allow Alice to open the door if Bob is nearby.
function canOpenDoor() public view returns (bool) {
  Position alice = getPlayerPosition(_msgSender());
  Position bob = getPlayerPosition("0xB0B");
  return getDistance(alice, bob) < 4;
}

Since we don't want to reveal positions onchain, the function getPlayerPosition would use a strategy similar to CCIP-Read where it leaves a placeholder (a revert, in the CCIP-Read case) that the backend can fill in when it computes the return value of the view function.

My main problem here is that while we don't reveal the locations to the player, we do reveal it to player-written code. Imagine a door that only opens when location.x %2 = 1, another that only opens when location.x % 4 >= 2, a third with location.x % 8 >= 4, etc. As much as generic solutions are preferable in general, I think here we'll need have the backend provide a function such as distanceBetweenPlayers.
Let me see if I understand the process.

The client sends a request to the backend for something (for example, openDoor).
The backend sends a request to a node to run a view function (in this case, canOpenDoor) written as part of an extension (which is why it's not directly in the backend).
The node reverts, and sends the revert message to the backend
The backend provides alice's position and calls the view function again.
The node reverts again, asking for bob's position
The backend provides bob's position and calls the view function a third time.
The node calculates the distance, and responds with a true or false.
The backend opens the door (or not) and responds to the client.

This requires us to trust the node not to abuse the location information, which isn't a terrible requirement (we can ask the game develop to run their own node). It's a complex process, which will probably be time consuming. Maybe we can do better with tevm.

we do reveal it to player-written code

what is the concern here? if it's a view function, there's no way for the view function to write to anything or communicate externally to potentially expose the data

if it's a view function, there's no way for the view function to write to anything or communicate externally to potentially expose the data

But there is. The view function can only return a value to the backend. However, that value visibly affects gameplay. This gives us a side channel to smuggle out information.
For example, imagine that the game includes a door that can be open or closed depending on Alice-provided code. A different player, Bob, can be in one of 64 different locations (an 8x8 map).
Alice will create six doors, and link them to six functions.
door0 <- Bob.position.x % 2 == 1
door1 <- Bob.position.x % 4 >= 2
door2 <- Bob.position.x % 8 >= 4
door3 <- Bob.position.y % 2 == 1
door4 <- Bob.position.y % 4 >= 2
door5 <- Bob.position.y % 8 >= 4

If we know that only door0, door2, and door5 are open, then we know that Bob is at position (5,4).

This reminds me of the Hevm style symbolic execution research I'm doing for Tevm

if it's a view function, there's no way for the view function to write to anything or communicate externally to potentially expose the data

But there is. The view function can only return a value to the backend. However, that value visibly affects gameplay. This gives us a side channel to smuggle out information.
For example, imagine that the game includes a door that can be open or closed depending on Alice-provided code. A different player, Bob, can be in one of 64 different locations (an 8x8 map).
Alice will create six doors, and link them to six functions.
door0 <- Bob.position.x % 2 == 1
door1 <- Bob.position.x % 4 >= 2
door2 <- Bob.position.x % 8 >= 4
door3 <- Bob.position.y % 2 == 1
door4 <- Bob.position.y % 4 >= 2
door5 <- Bob.position.y % 8 >= 4

If we know that only door0, door2, and door5 are open, then we know that Bob is at position (5,4).

I guess what you're hinting at is a kind of like a timing attack? Bob would have to interact with all the doors and Alice would need to know that Bob was the last to interact with all the doors?

I guess what you're hinting at is a kind of like a timing attack? To get to that answer above, Bob would have to interact with all the doors and Alice would need to know that Bob was the last to interact with all the doors?

There is no need for timing or for Bob to do anything. Alice interacts with the doors to get the backend to call the view functions; it's just that those functions look at Bob's position. Bob's identity can be hard-wired in the contract or specified by other means. Theoretically, the contract can have a "setVictim" function that Alice uses to specify which player's location she wants.

Ohh I see what you mean now: Alice could program her thing with arbitrary logic that can slowly reveal hidden information.

Yes. It's a clever solution that would be great,  except that any time I can write code that can affect something I can observe I can smuggle information out.


Using AngularJs 1.6.1 and Cannot get components to load

I have followed the details of instruction on how to load components using the state router and my code, as far as the $stateProvider routing goes is almost exact.  I cannot get it to work.  I also get a controller not registered error when I provide a controller reference string to the state.  Need some help please.  I am using UI-Router 1.0.0 rc1.  I will code to help move this forward.

@Troy1b4 check this plnkr out.

I appreciate your post, and I see that the way the solar system app works appears accomplishes what I need, but I do not see any reference to a component as part of a $StateProvider state.  Looking at the documentation for<EMAIL_ADDRESS>which I identified in Plunker, I see the following:
angular.module('hellogalaxy').component('hello', {
template:  '{{$ctrl.greeting}} Solar System!' +
'toggle greeting',
controller: function() {
this.greeting = 'hello';
this.toggleGreeting = function() {
  this.greeting = (this.greeting == 'hello') ? 'whats up' : 'hello'
}

}
})
var helloGalaxy = {
name: 'hello',
url: '/hello',
component: 'hello'
}
I understand that this is a little different than what I am doing, but this is the direction I am given and it does not appear to work.  Notice the "component" is listed in the state like I do.  I am using 1.0.0-rc.1 which my understanding of versioning should be a newer version that what is used.  I prefer this newer way of accomplishing what I need.  Do you identify anything with what I provided, in my code, that may be keeping it from working correctly?

Hi @Troy1b4!
This  helloGalaxy object is passed to the for loop on line46 from hellosolarsystem.js in my plnkr.
I don't know exactly your problem, but maybe I could help if you provide a runnable code sample (plnkr, jsbin, whatever...)

I will give it a try.  I am pretty new to Plunker.  I do however have all
my code, for the most part listed here:
http://stackoverflow.com/questions/41645622/how-do-i-get-angularjs-ui-router-to-load-components-for-angularjs-1-6-1-app
On Mon, Jan 16, 2017 at 8:43 AM, Octavian Cioaca<EMAIL_ADDRESS>wrote:

Hi @Troy1b4 https://github.com/Troy1b4!
This helloGalaxy object is passed to the for loop on line46 from
hellosolarsystem.js in my plnkr.
I don't know exactly your problem, but maybe I could help if you provide a
runnable code sample (plnkr, jsbin, whatever...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/angular-ui/ui-router/issues/3265#issuecomment-272880427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADsSBUuoiaOiJI06QFdb_8YSPEnNCH-ks5rS4IcgaJpZM4LjWEI
.

--
Troy Crowe
(615) 589-0845
My LinkedIn Profile http://www.linkedin.com/in/troycrowe

Just ran into this.  I discovered if a component is a single word not dash-separated/camelCase it won't render.

@Troy1b4 Your comments in your stack overflow indicate that you have found the problem to be with your "Microsoft MVC" setup, so I'm closing this issue.

I discovered if a component is a single word not dash-separated/camelCase it won't render.

@deanapeterson that's definitely not true, as can be seen here in the official tutorial:
https://plnkr.co/edit/2SSO4Y?p=info
  // An array of state definitions
  var states = [
    {
      name: 'hello',
      url: '/hello',
      // Using component: instead of template:
      component: 'hello'
    },

    {
      name: 'about',
      url: '/about',
      component: 'about'
    },
    ...


First launch on large directory, the tree will not scroll down

Bug description
When Onivim2 launches in a directory that is very large, It will only scroll upwards and not downwards until I select another directory in it. Then is scrolls fine.
Steps to reproduce
Open Onivim2 in a large directory on macOS. Before clicking any other directory or file, try to scroll down the list.
What happens
It will not scroll downwards. Scrolling upwards will bring the topmost directory down the screen until it is at the bottom.
Expected results
Being about to scroll up and down freely.

BTW: This happens in the release version and the latest compile from github.


Helm need to be installed by default user

currently helm repositories are ending up in /root/.helm/repository/repositories.yaml and not found by default user ubuntu

In requirement.sh, line 58, we are moving the helm binary via sudo to /usr/local/bin .
Possible Fix: Adding one extra line after line 58 with the following command:
chown ubuntu:ubuntu /usr/local/bin/helm
When: This fix will be done once creation of KubeNow images will be finally decoupled.

I actually don't think that is the problem. It is in the playbook doing a helm-init. This executed as root - but have changed the playbook for v0.3

@andersla Aha, thanks! As per our discussion, in the main.yml file for the Helm's playbook at line 3: become: yes is triggering the superuser mode.
Fix: removing line 3 does fix the issue. No need to modify requirement.sh
@mcapuccini : just FYI, Anders found the culprit.


docs(README): add static README badges

Add new static badges on the README to communicate the status and quality of the project.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
28

Relevant Lines:
28

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

v1.0.0
GitHub release

Your semantic-release bot :package::rocket:


[901] Upgrade to Rails 6

Context
We're upgrading to Rails 6 to keep up to date and access the latest features.
Changes proposed in this pull request
This was done by running the following commands:
bundle update rails
rails app:update

For the latter, I took care to diff each changeset for conflicting files. I allowed Rails to add in inconsequential changes such as comment fixes, but I made sure to keep our customisations, notably our mailer, notify config, and our inflectors.
Guidance to review
This was based on: https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/185
I've also consulted the Rails migration guide.
Given that this app isn't user-facing yet, assuming the tests pass, we don't need to be especially exigent about making sure this works. We can fix stuff as we go. :ship:
Link to Trello card
901 - Upgrade to Rails 6

Must we have selenium-webdriver? I don't think we actually depend on it...

@duncanjbrown https://github.com/DFE-Digital/apply-for-postgraduate-teacher-training/pull/192/commits/6c7c52b57036dbaadf797ebeab61147e6d552d6c
The tests seem to break without it on Rails 6 https://dfe-ssp.visualstudio.com/8ae3b7b6-114a-4eec-a108-7afdc2fd1aa6/_build/results?buildId=22126

@tvararu we had only rack_test powered capybara specs which don't require an external browser: see spec/support/capybara.rb. I just tried to take it out, but Rails introduced a load-time dependency on selenium-webdriver here, so I don't think we can avoid taking this dep: https://github.com/rails/rails/blob/cf43b71b64e21182c34e0907167e13fc917436bd/actionpack/lib/action_dispatch/system_test_case.rb#L7.


Client restrictions

Does sish supports some api for client restrictions? i.e.
max requests per secods,
max bytes requested/responded per day. (i.e. 1000 MB per day)

sish does not and I will likely not implement these features. If someone contributes them I'd be happy to merge them upstream.

Thanks!


Implement the Consensus release process

Description
Implement the Release process as agreed by the Consensus team. See the ReleaseProcess document for more information.
In particular, this creates:

symlinks for each folder into their appropriate changelog.d directory
two main CHANGELOG.md files, in ouroboros-consensus and ouroboros-consensus-cardano
updates the version number in some ledger-agnostic packages that were behind
configures scriv and provides a fork that understands the bare minimum of colon separated files, in particular of .cabal files.
updates the PR template
Provides a top level changelog that points to the others

Closes #4306
Checklist

Branch

[X] Commit sequence broadly makes sense
[X] Commits have useful messages

Pull Request

[X] Self-reviewed the diff
[X] Useful pull request description
[X] Reviewer requested

bors r+

The Plutus team uses plutus, unpatched. How much more power do we get by building a patched scriv?
Some pointers to their approach:

https://github.com/input-output-hk/plutus/blob/a480c5ab386144dd120cf8bfdd42d0a1f614393a/scripts/assemble-changelog.sh
https://github.com/input-output-hk/plutus/blob/a480c5ab386144dd120cf8bfdd42d0a1f614393a/scriv.ini
https://github.com/input-output-hk/plutus/blob/931c8109844d26bd244ff34d9df6fb76ee95be2a/nix/cells/plutus/packages/scriv.nix
https://github.com/input-output-hk/plutus/blob/a480c5ab386144dd120cf8bfdd42d0a1f614393a/scripts/prepare-release.sh

@nfrisby scriv looks great, could be useful in the consensus context where there are multiple directories/packages to integrate

I think the advantage of the patched scriv is that we don't have to repeat the version in the scriv.ini: Compare
https://github.com/input-output-hk/plutus/blob/a480c5ab386144dd120cf8bfdd42d0a1f614393a/scriv.ini
and
https://github.com/input-output-hk/ouroboros-network/blob/aca78755a28c6884c0aae83c52876dafe16081ca/ouroboros-consensus/changelog.d/scriv.ini#L5


Chroma standard environments load on 360/90 maps

Describe the bug
The title is mostly self explanatory. This bug happens if you use an environment that isn't GlassDesert with a 360/90 map.
To Reproduce
Steps to reproduce the behavior:

Use a Chroma environment that doesn't use GlassDesert as a base
Play a 360/90 map
See error

Expected behavior
Chroma shouldn't load the environment if it's not meant for 360 maps
Additional context
Video showing the bug
https://github.com/user-attachments/assets/2711d9c0-f07e-4deb-855d-f234688ef9a3
Log: _latest.log

This seems intentional, if not keep it and call it a feature, I like playing 360 maps on non 360 environments...

I mean this could be but the game HUD doesn't rotate with the map which can become a problem with 360 maps.

This is intentional


Bump torch-mlir to llvm/torch-mlir@e7a0944

Adds reduce-op-variants pass to Torch->tm_tensor conversion   so that we can handle all the different backend cases of SDPA/SDPFA.
Also bumps llvm-project to shark-infra/llvm-project@bb18085

Sorry for extra pings, don't know what happened with the pull/rebase there for a moment. Latest version should just be two commits on top of main branch.

Just speculating, you might need this commit: llvm/llvm-project@2cbe5a3

Correct - I expect that if you cherry-pick that, you can land this commit as-is.
In the future, let's make sure to coordinate LLVM bumps on IREE's #llvm-integrate channel as having multiple things happening on the side creates redundant work.

Looks like this PR also dodged the "automatically run benchmarks on LLVM integrates" CI heuristics. More reason to use or coordinate with the standard LLVM integrate process


Add Imaging Module acceptance tests

This PR adds acceptance tests to the imaging module. It adds the tests below

[x] - Visit /imaging
[x] - Create a new imaging request
[x] - Test whether requests marked as completed are displayed
[x] - Mark an imaging request as completed

If there is something else to test please let me know.

@zinyando It looks like one of the tests is not passing, but I think its a problem with the test, not the actual functionality.  Here is the error message from the Travis CI build:
not ok 2 PhantomJS 2.0 - Acceptance | imaging: create a new imaging request
---
actual: >
Warning!!!!
expected: >
Imaging Request Saved
message: >
Imaging Request was saved successfully
Log: |
...

Thanks for the pr @zinyando!


[PROBLEM] 119. Pascal's Triangle II

Difficulty
Easy
Problem Description
Given an integer rowIndex, return the rowIndexth (0-indexed) row of the Pascal's triangle.
In Pascal's triangle, each number is the sum of the two numbers directly above it as shown:

Example 1:
Input: rowIndex = 3
Output: [1,3,3,1]
Example 2:
Input: rowIndex = 0
Output: [1]
Example 3:
Input: rowIndex = 1
Output: [1,1]

Constraints:

0 <= rowIndex <= 33

Follow up: Could you optimize your algorithm to use only O(rowIndex) extra space?

Link
https://leetcode.com/problems/pascals-triangle-ii/

Python solution ✋

I can write the code in java


GET taxonomy REST endpoint doesn't work

Describe the bug
Error when listing all taxonomies for an institution
To Reproduce
Go into apidocs.do and then "Try it out" + "Execute" on the list taxonomies endpoint. You will receive the following error:
{
  "code": 415,
  "error": "Unsupported Media Type",
  "error_description": "RESTEASY003200: Could not find message body reader for type: interface javax.ws.rs.core.UriInfo of content type: */*"
}

Other entity endpoints don't seem to have the same problem.

This is fixed as a result of other changes in 2019.2


python310Packages.pyshp: 2.3.0 -> 2.3.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pyshp is: "Pure Python read/write support for ESRI Shapefile format"
meta.homepage for python310Packages.pyshp is: "https://github.com/GeospatialPython/pyshp"
meta.changelog for python310Packages.pyshp is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.3.1 with grep in /nix/store/lwcz5jwlm7fsv1cw483bgksjqx79zw7y-python3.10-pyshp-2.3.1
found 2.3.1 in filename of file in /nix/store/lwcz5jwlm7fsv1cw483bgksjqx79zw7y-python3.10-pyshp-2.3.1

Rebuild report (if merged into master) (click to expand)

13 total rebuild path(s)

13 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.asf-search
python310Packages.basemap
python310Packages.cartopy
python310Packages.pyshp
python310Packages.wktutils
python310Packages.wrf-python
python39Packages.asf-search
python39Packages.basemap
python39Packages.cartopy
python39Packages.pyshp
python39Packages.wktutils
python39Packages.wrf-python
visidata

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lwcz5jwlm7fsv1cw483bgksjqx79zw7y-python3.10-pyshp-2.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pyshp https://github.com/r-ryantm/nixpkgs/archive/965e3ae94c60a0415f0f78a9778ab1e7f0b08685.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lwcz5jwlm7fsv1cw483bgksjqx79zw7y-python3.10-pyshp-2.3.1
ls -la /nix/store/lwcz5jwlm7fsv1cw483bgksjqx79zw7y-python3.10-pyshp-2.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

13 packages built:

python310Packages.asf-search
python310Packages.basemap
python310Packages.cartopy
python310Packages.pyshp
python310Packages.wktutils
python310Packages.wrf-python
python39Packages.asf-search
python39Packages.basemap
python39Packages.cartopy
python39Packages.pyshp
python39Packages.wktutils
python39Packages.wrf-python
visidata

Maintainer pings

Result of nixpkgs-review pr 183594 run on x86_64-linux 1

13 packages built:

python310Packages.asf-search
python310Packages.basemap
python310Packages.cartopy
python310Packages.pyshp
python310Packages.wktutils
python310Packages.wrf-python
python39Packages.asf-search
python39Packages.basemap
python39Packages.cartopy
python39Packages.pyshp
python39Packages.wktutils
python39Packages.wrf-python
visidata


Added vertical ranges

Fixes #1483.
Adds styles for vertical Range sliders: .range-vertical and .range-vertical.range-invert.
I chose .range-invert because I'm not sure if there'll be an intent to add such a feature for all other sliders...

Well this is awkward... Apparently it worked and now it doesn't?


ExpressionParser finds Types from IEnumerable instead of IQueryable (breaks Code) (worked in 1.3.9)

1. Description
I've the following Code:
                    var expression = DynamicExpressionParser.ParseLambda(qry.GetType(), null, complexQueryString, objs.ToArray());
                    Delegate del = expression.Compile();
                    var resultIv = del.DynamicInvoke(qry);
                    qry = resultIv as IQueryable;

where qry.GetType() is of type  Table wich inherits from IQueryable
My compleyQueryString looks like this:
  "it.GroupBy(MessageClassName).Select(it.Key).Where(it != null).Distinct().OrderBy(it).Take(1000)"

this results in the following Expression Tree (in 1.3.10 and later)

but in Version 1.3.9 it has the following Tree:

2. Exception
There is no exception, but the Query is no IQueryable after the Parsing any more, and so my code fails

@jogibear9988 Thank your for reporting this issue.
Fixed with #802


GNU "as" based bootstrap interpreter

compile the LM bootstrap to assembly and attach as another bootstrap option.

PunC is picking up the slack here as an IR between any assembly dependencies.


Allow duplication of existing job

Enable duplicating an existing job entry. This will make it easier to re-run jobs, especially in the one-off running context.
We will have to take into account whether someone wants to run the same job configuration (e.g. the parameters/environment variable configuration) for the snapshotted version of the job that is being duplicated or the current version of the project.
If the current version is being used we need to reconcile the potential change in parameters/environment variables.
Arguably for re-running a job of the current snapshot we should extend the existing job (thus adding to the pipeline runs that previously ran as part of this job).

When implementing this, I think we should reason about the potential abstractions it would introduce for #200.

https://github.com/orchest/orchest/pull/433

Arguably for re-running a job of the current snapshot we should extend the existing job (thus adding to the pipeline runs that previously ran as part of this job).

For completeness, this was dropped from the first implementation spec.


Launcher.java uses unchecked or unsafe operations.

Hello,
thanks for the good job.
When I try to build the apk with the version 0.6.0 I get the error

Note: /Users/leonardorignanese/.pub-cache/hosted/pub.dartlang.org/flutter_custom_tabs-0.6.0/android/src/main/java/com/github/droibit/flutter/plugins/customtabs/internal/Launcher.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Why? How can I fix it?

Thank you for your patience.
The warnings has been fixed in the stable release of flutter_custom_tabs v2.0.
Please let me know if you have any other questions or feedback.


Add sock_extended_err and associated constants from errqueue.h

sock_extended_err is a struct returned as a control message when the sockopt
IP_RECVERR is set, when recvmsg has the MSG_ERRQUEUE flag set.  IP_RECVERR and
MSG_ERRQUEUE are constants both already defined here.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Note: I put this in linux/ but I believe it should work on Android.  However, the libc-test was failing, and I think it may be related to header ordering.  It's not relevant on emscripten, so I'm not sure it belongs at the linux_like/mod.rs level.

#1616 is nearly the same as this, but with the code up a level, at linux_like.

Looks like reordered headers works for android, so I'm closing this PR in favor of #1616.  I've added the test there as requested here.


Initial push of CLI command line tests

Update Start.cs to deal with a CommandLineParser issue. If a default verb is set, CommandLineParser doesn't verify whether or not the verb passed in is actually a supported verb. It assumes it to be the default verb. Something like "test-proxy foo" would end up running test-proxy start instead of erroring. The VerifyVerb function checks for this and outputs an error message that would be output by CommandLineParser if there were no default verb and an incorrect verb was passed in.
GitStoreIntegrationPushTests.cs - Just updated the description here. These tests changed purpose when we went from branches to Tag. They're now similar tests but acting on different Tags that have different files and different file versions.
assets.Tests.Helpers.ps1 - Support functions for the CLI integration tests.
CLIIntegration.Tests.ps1 - Pester tests for testing the test-proxy CLI commands. These mirror the functionality in the test-proxy Integration test suite but with a reduced number of tests with the primary goal to test things from the using the CLI. This does require the test-proxy to be installed on the machine and in the path.

/azp run tools - test-proxy - tests


[compatible-ancient-hookworm-6155661741] Workflow v2.1

This was created solely for demo purposes.


Updates from master branch

Please see https://github.com/davegardnerisme/nsqphp/issues/38

@rodrigueznicolas  @NoiseByNorthwest  @mhor  please update the library!

@smilesrg done

@NoiseByNorthwest thank you so much!

@NoiseByNorthwest Please update the version at http://packagist.org

@smilesrg done https://packagist.org/packages/socloz/nsqphp#dev-socloz


PR #8232 continued

A continuation of #8232 (it's rebased on current main c910705) with view of debugging/fixing the issues cause by fma instructions present on certain NumPy versions compiled for M1 arch.

Closing, investigation is complete. It's possible to numerically detect the probable presence of FMA instructions but not with the granularity required to be useful.


Added setings for launch xiaomi_gateway3

It seems it is not a PR with any specific changes.
I'm closing it.


Moving to .NET 8

Summary of the pull request
Upgrading everything to .NET 8 and handling all the syntax errors that comes with it.
References and relevant issues
#80 is in progress, but this needs to go in because DevHome is in .NET 8.
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

As @manodasanW figured out, the use of version-specific RIDs and the associated workaround will no longer be needed once there's a new version of the Dev Home SDK and the extensions upgrade to it. Namely it needs this change here: Blaming devhome/extensionsdk/nuget/Microsoft.Windows.DevHome.SDK.nuspec at c08f7ed23e6e0070a6d5ab24e40c257309f27a75 · microsoft/devhome (github.com) . Could be good to open up an issue as a reminder to clean this up once it's not necessary.

As @manodasanW figured out, the use of version-specific RIDs and the associated workaround will no longer be needed once there's a new version of the Dev Home SDK and the extensions upgrade to it. Namely it needs this change here: Blaming devhome/extensionsdk/nuget/Microsoft.Windows.DevHome.SDK.nuspec at c08f7ed23e6e0070a6d5ab24e40c257309f27a75 · microsoft/devhome (github.com) . Could be good to open up an issue as a reminder to clean this up once it's no longer needed.

I opened up an issue (#81) for the previous PR (#80) that we could potentially reuse.


⬆ Upgrade configuration for Ruff 0.2.1

I'm a ruff maintainer and I noticed that you aren't using the most recent ruff version yet. I went ahead and upgraded Ruff to 0.2.1 and updated the configuration.

The formatting changes are a bugfix where ruff didn't add a trailing comma after type annotations.
I updated the configuration to use the now recommended ruff.lint options to configure the linter
I updated the lint.sh file to use ruff check instead of ruff because we probably will deprecate the former at some point in the future.

Whoops, the changes to the requirements.txt file are missing. You can see that I'm a Python packaging noob. Let me fix this up real quick.

@MichaReiser @charliermarsh Eh... https://github.com/tiangolo/fastapi/pull/11075 😬

oops sorry. That was my mistake.


Blur page when prompted to leave the page

The timer stops running when a player tries to leave the page (close tab/window or clicking back button), but the player can still read the rest of the screen. This can be taken advantage of by players who try to parse the available routes shown on the page without having the timer running, as they can easily hit "cancel" instead of leaving the page and quickly navigate to the next page of their choosing.

The timer actually continues in the background even when player tries to leave the page.


requires semantic needs to be more flexible

Right now, the requires semantic on the extractor is treated as an "and" as in the extractor requires both files. For languages like python, this needs to be a softer semantic to be able to optionally extract additional metadata from the file.

Closing in favor of v2


Mathematical formulas do not display properly

Language server
pylsp
Requested feature
When I check some method descriptions, the mathematical formulas in the method descriptions do not display properly.

Other clients which have this feature
No response

default markdown syntax render based on regex conceal so it might not works fine on some situations.  maybe treesitter markdown render can works fine on this ? not sure.


Return results in order

Storage Explorer Version: 1.8.1
Platform/OS: Windows 10
Architecture: x64
Regression From: No
Bug description
When you load more, the items are not sorted.
a,c,d comes back.
Load More. b,e,f comes back
Steps to Reproduce
Have lots of storage account with mixed names and ages
Load more (first 100 are loaded)
Load more (some accounts are "injected")
Expected Experience
Get storage accounts / subscriptions in A-Z order
Actual Experience
It appears storage accounts might be return chronologically.
Additional Context
(can we also increase the load size from 100?)

Hey @mikeblakeuk, unfortunately when we list Storage Accounts, they are not returned in alphabetical order. So to do this we'd have to get all accounts from ARM and then sort them. For some users though they have hundreds upon hundreds of Storage Accounts so this might lead to some perf issues. We can maybe try to find some time to investigate if that will be true though.
As for the load size, that is something we plan to expose via settings very soon. See #153

We already have an issue for exposing load more size via settings. As for the results not being returned in alpha order, we've checked with the platform team and there's nothing that can be done about that right now.


Roll engine bf3af4d157cc..1cada0a6dca6 (1 commits)

git@github.com:flutter/engine.git/compare/bf3af4d157cc...1cada0a6dca6
git log bf3af4d157cc..1cada0a6dca6 --no-merges --oneline
2019-09-19<EMAIL_ADDRESS>Roll src/third_party/skia 6344cbd1df76..18531cde2ab7 (2 commits) (flutter/engine#12358)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Auto-roller completed checks. About to merge.


Adding auto scroll to top button

User experience enhances when there is less scrolling in the web pages , thus when the user scrolls down to visit the website it will not required to the user to again go back to the top by scrolling as it is a waste of time. Thus adding scroll to top button will take the user to the top in a click.

This is my previous work

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊
You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

We do not have many sections so this section is not needed for now.

Hello @sharmi4590! Your issue #223 has been closed. Thank you for your contribution!


no IPython console

From<EMAIL_ADDRESS>on 2014-07-29T15:31:27Z
Spyder Version:  2.4.0dev
Python Version:  2.7.6
Qt Version    :  4.8.6, PyQt4 (API v1) 4.10.4 on Linux
IPython >=0.13  :  2.1.0 (OK)
matplotlib >=1.0:  1.4.x (OK)
pandas >=0.13.1 :  0.14.1.dev (OK)
pep8 >=0.6      :  1.4.6 (OK)
psutil >=0.3    :  1.2.1 (OK)
pyflakes >=0.5.0:  0.8.1 (OK)
pygments >=1.6  :  1.6 (OK)
pylint >=0.25   :  1.1.0 (OK)
rope >=0.9.2    :  0.9.2 (OK)
sphinx >=0.6.6  :  1.2.2 (OK)
What steps will reproduce the problem?

Start Spyder

What is the expected output? What do you see instead?
Use a IPython console -> No IPython console is available
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1913

From contrebasse on 2014-07-31T03:49:36Z
You need to enable the ipython panel from the Display (or View? I don't remember the english translation) menu.

From ccordoba12 on 2014-11-18T17:54:56Z
I hope you solved this one :-)
Closing because of lack of response.
Status: WontFix

From ccordoba12 on 2014-08-24T23:16:40Z
Are you using a virtualenv or a different Python interpreter in
Preferences > Console > Advanced Settings

?


Use a bitset for ascii-only character classes

In the cases where a custom character set is made up of ascii characters, scalars, and ranges, use a 128 bit set to represent the character class instead of using the mess of closures we were using before
Branched from https://github.com/apple/swift-experimental-string-processing/pull/509
Results show big improvements on the custom character class microbenchmarks, and smaller improvements in the real world benchmarks where the closure overhead represented less of the runtime, notably the email regexes which contain character classes that have many non-range items
=== Improvements ====================================================
- basicCCC				11.2ms	33.5ms	-22.3ms	-67.0%
- basicRangeCCC				12ms	13.5ms	-1.58ms	-12.0%
- invertedCCC				30.6ms	48.9ms	-18.2ms	-37.0%
- caseInsensitiveCCC			13.1ms	124ms	-111ms	-89.0%

- GraphemeBreakNoCapFirst		85.5µs	122µs	-37µs	-30.0%
- emailLookaheadNoMatchesFirst		62.5ms	88.3ms	-25.8ms	-29.0%
- emailRFCAll				51.4ms	54.3ms	-2.89ms	-5.0%
- cssAll				5.03ms	5.33ms	-297µs	-6.0%
- emailLookaheadAll			86.1ms	103ms	-16.6ms	-16.0%
- GraphemeBreakNoCapAll			9.49ms	10.1ms	-621µs	-6.0%
- emailLookaheadNoMatchesAll		62.5ms	88.3ms	-25.7ms	-29.0%
- emailLookaheadFirst			19.2µs	22.7µs	-3.5µs	-15.0%
- emailRFCFirst				8.33µs	9.75µs	-1.42µs	-15.0%

@swift-ci test

@swift-ci test


Bump up aws version and add dep gopkg files

Hi, thank you for the info - I already read about it, and I don't like so much that pattern but I think it's useful and easy way to deploy always the same versions that you test on your localhost.
But I've reverted the latest commit where I included the vendor folder and the gopkg files and now the PR is just for bumping up the version :)

You're right. There might be breaking changes introduced with newer versions if you're using go get (and the aws-sdk is a very good example 😅)
I was checking out dep and you can now specify versions. Haven't tested myself though.
I've just made a new release v0.5.0 for latest aws-sdk-go-v1. I'll release this as v1.0.0.
Thanks!

cool! thank you for approving the PR - that's perfect.
let's hope the new way of handle go dependencies for the new go release is better (https://github.com/golang/go/wiki/vgo) :)

Thanks for the help and the tip :)


[libhsplasma] Add new port.

This adds a port for libHSPlasma.

I'm converting this to a draft in order to deal with CI failures and an issue with HSPlasma_INCLUDE_DIRS, which may require an update to the upstream library.

Failure logs here.

Blocking on upstream H-uru/libHSPlasma#184, which should fix the CI issues.

Thanks for your patience @JackBoosY. This is now ready for your review.

Test feautres successful on x86-windows and x64-windows.

Thanks for your contribution!


update progress reporters to show timed out test count

It can be extremely useful to see if there are any test timeouts going on when starting a long-running Stryker test run.
I have been working on using Stryker on Prettier (see prettier/prettier#6681) where test timeouts seem to be more likely if I do not adjust the timeoutMS setting (in stryker.conf.js).
The source code changes seemed to be quite straightforward; a slightly more challenging part was to update the existing tests scripts to pass with these changes.
I did try these changes in my workarea and it seems to work with both default console "progress" reporter and "progress-append-only" reporter. (It seems to downgrade if I would pipe stryker run through the tee utility.)
Here is some initial output with the console "progress" reporter:
$ yarn stryker
yarn run v1.19.1
$ stryker run
18:10:04 (10047) INFO ConfigReader Using stryker.conf.js in the current working directory.
18:10:05 (10047) INFO InputFileResolver Found 4 of 5884 file(s) to be mutated.
18:10:05 (10047) INFO InitialTestExecutor Starting initial test run. This may take a while.
18:10:25 (10047) INFO InitialTestExecutor Initial test run succeeded. Ran 1 tests in 21 seconds (net 20065 ms, overhead 0 ms).
18:10:26 (10047) INFO MutatorFacade 1021 Mutant(s) generated
18:10:26 (10047) INFO SandboxPool Creating 16 test runners (based on CPU count)
Mutation testing  [===                                               ] 6% (ETC 5h, 29m, 57s) 64/1021 tested (3 survived, 9 timed out)

and with the "progress-append-only" reporter:
$ yarn stryker | tee progress-append-only-timed-out-save1.txt
yarn run v1.19.1
$ stryker run
18:34:40 (30236) INFO ConfigReader Using stryker.conf.js in the current working directory.
18:34:41 (30236) INFO BroadcastReporter Detected that current console does not support the "progress" reporter, downgrading to "progress-append-only" reporter
18:34:41 (30236) INFO InputFileResolver Found 4 of 5886 file(s) to be mutated.
18:34:41 (30236) INFO InitialTestExecutor Starting initial test run. This may take a while.
18:35:02 (30236) INFO InitialTestExecutor Initial test run succeeded. Ran 1 tests in 21 seconds (net 20623 ms, overhead 2 ms).
18:35:02 (30236) INFO MutatorFacade 1021 Mutant(s) generated
18:35:02 (30236) INFO SandboxPool Creating 16 test runners (based on CPU count)
Mutation testing 0% (ETC n/a) 0/1021 tested (0 survived, 0 timed out)
[...]
Mutation testing 0% (ETC 70h, 50m, 0s) 1/1021 tested (0 survived, 0 timed out)
Mutation testing 0% (ETC 36h, 47m, 50s) 2/1021 tested (0 survived, 0 timed out)
[...]

I would be extremely grateful if the owners & maintainers would consider getting these changes reviewed, merged, and released in the near future. Installation from npm would be so much easier than GitHub or local workarea, especially when integrating with a larger project such as Prettier. I wonder if would make sense to publish with special npm tag such as "rc"?
I do think it would be nice if we could unit test these updates somehow. The existing test suite does not seem to test these progress reporters so extensively at this point. Unfortunately I also cannot promise when I can work on these due to some other priorities at this time.

Thanks for adding this! Could you also add a test to prove that the counting work? (That way we know it will continue to work :) )

The CI / e2e build seemed to go red after merging from master. The same thing happened to me yesterday, and it went away when I did a rebase.
I just pushed a test update, will do another rebase if the build is still red.

Thanks for the quick review and merge. Any idea when we can get this published?
It would really help us (me) with mutation testing on Prettier.

I'm hoping to release it this evening, but I'm having some issue with the release pipeline :(

That's really fast, thanks:)

Deployed as 2.2.1: https://travis-ci.org/stryker-mutator/stryker/jobs/608425051?utm_medium=notification&utm_source=github_status
npmjs.org may take a while to index the new version. Manually updating should already work.
The release of 2.2.0 to npm failed. It was only deployed to GitHub due to a poor solution I picked in an attempt to fix the release pipeline.

I saw 2.2.1 on npmjs.com pretty quickly. I updated my branch in prettier/prettier#6681, tried it with and without "append-only" reporter, seems to work perfectly now. Thanks again @simondel!


doc.setTextColor does not work with fillThenStroke

doc.setTextColor is not sufficient to set text color for doc.text when using fillThenStroke
Simple example metacode:
doc.setColor("blue");
doc.text(); // text is blue
doc.setColor("black")
options.renderingMode = "fillThenStroke";
doc.text(); // text is blue - not black
workaround is to use doc.setDrawColor as well.

In the current version of jsPDF there is no setColor function. Which version are you using? setTextColor sets the text fill color (and general fill color), setDrawColor sets the stroke color. That's by design.


Port to NAN

Port to NAN - in case somebody is interested.

Hey @zerouid, this is awesome. Thanks for working on this. Sadly, this work collided with my refactor, and now it doesn't merge. Would you mind fixing it up so that it does? I didn't change the C++ much, so I don't think it'll be too bad.

Hi @mranney, I'm glad if I could help. I did sync my branch with your latest, and resolved the conflicts. There are few things you should probably consider before you decide weather to merge or not.

The dependency "socketwatcher" needs to be ported too. I did that one too and I'm fetching it from my fork.
When I tested after merging and got some errors from your new decoding routines:

node_pcap/decode/ipv6.js:63
    ret.payload_length = unpack.uint16(raw_packet, offset+4);
                         ^
ReferenceError: unpack is not defined
    at IPv6.decode

...am I missing something?
P.S. ...and BTW great job! Thanks!

You aren't missing anything, I just didn't finish the refactor on IPv6 and radio. But it looks like you went ahead and did that too.
I added you as a collaborator, so feel free to merge this if you are happy with it.
Hopefully soon someone will write some tests. :)

Oh, and also: nice work!

This is awesome! Can we get it updated to<EMAIL_ADDRESS>or higher so that we can io.js support :)


There is a Minified React error on preview panel

Error: Minified React error #31; visit https://reactjs.org/docs/error-decoder.html?invariant=31&args[]=Sun Apr 19 2020 21%3A38%3A20 GMT%2B0900 (Korean Standard Time)&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Describe the bug

To Reproduce

Expected behavior

Screenshots

Applicable Versions:

Netlify CMS version: [e.g. 2.0.4]
Git provider: [e.g. GitHub, BitBucket]
OS: [e.g. Windows 7]
Browser version [e.g. chrome 22, safari 11]

Node.JS version:

CMS configuration

Additional context

Thanks for sharing @veryfaraway, if you follow the link you can see that you need to convert the date object in your preview template to a string.
Can you share your repo/preview template code?

Thanks for sharing @veryfaraway, if you follow the link you can see that you need to convert the date object in your preview template to a string.
Can you share your repo/preview template code?

Thanks for a quick reply. I'm a newbie, so could you tell me how can I find and share the code?
Here is my post source that the error occurs.
https://github.com/veryfaraway/gatsby-yellowcake-blog3/blob/master/content/posts/2020-04-19-iron-man-2008-쿠키-영상.md

Not sure but maybe here https://github.com/veryfaraway/gatsby-yellowcake-blog3/blob/master/src/templates/SinglePost.js#L36

@erezrokah
That code doesn't seem to be a problem. Published posts can be seen well without problems. (https://3buddies.netlify.app/posts/iron-man-2008-쿠키-영상/)

The error occurs in the preview panel when writing a new post in the admin UI.

Do you have any idea?

By default the CMS will return a date object when working with the date widget.
You are passing the CMS data as is (meaning the date as an object) here:
https://github.com/veryfaraway/gatsby-yellowcake-blog3/blob/8ed0e7da178db35bfa577a759ea5de0233cb5251/src/cms/cms.js#L42
so new posts break.
For existing posts it looks like they were saved with the dates as strings. For example:
https://github.com/veryfaraway/gatsby-yellowcake-blog3/blame/master/content/posts/2018-05-25-testing-1-8-2.md#L5
except this post which was saved with a full date and also has the preview broken:
https://github.com/veryfaraway/gatsby-yellowcake-blog3/blame/master/content/posts/2018-05-25-testing-1-8-2.md#L5.
You can save the dates as strings by configuring - { label: Date / Order, name: date, widget: date, format: 'YYYY-MM-DD' } here:
https://github.com/veryfaraway/gatsby-yellowcake-blog3/blob/8ed0e7da178db35bfa577a759ea5de0233cb5251/static/admin/config.yml#L297
The most important thing is to save the dates in a consistent format (dates or strings) so you can easiliy process them later.


Try to lookup base class member while resolveExpressionNodeToType

Is this something you would do to solve
https://github.com/felixfbecker/php-language-server/issues/407

Correct me if I am wrong but I believe this PR and #421 do pretty much the same thing.
The differences are:

in the implementation of parent gathering - #421 uses a generator closure and #408 uses an array
this handling - #421 handles the This type to allow for fluent interfaces
#421 has tests (which still pass of this moment)

We should probably leave a single PR open as they do the same and merging both will not be possible. We could also mix and match the two approaches - add the This type handling and tests to #408 or adopt the array approach in #421 (if the maintainers believe it is better than the generator closure)?

sounds good so I'll just close this


[App]: Run summary has stopped working

Current Behavior
I'm not sure if I've changed something that broke this, or if there's a bug in the platform, but I'm no longer seeing summary data. In this screenshot, val/accuracy stopped showing up in the last column, even though it's being logged just the same.

If I jump to the details for that run I see this in the overview:

If I just do this:
run = wandb.init(...)
for i in range(10):
    log_dict = {
        "loss": random.uniform(0, 1 / (i + 1)),
        "acc": random.uniform(1 / (i + 1), 1),
    }
    wandb.log(log_dict)

run.finish()

I see this in the console:

But this in the UI: "No summary metrics saved for this run"
However if I don't do run.finish() but then call it manually a few seconds later, I do see a summary in the UI.
Please note that I have always done run.finish() in the past and gotten a summary, and if I don't do this then wandb doesn't work correctly in PyCharm Python Console (it doesn't complete the run after I run my code, and also will break if I run a cell multiple times to perform multiple runs).
It's only in the last day or so that summaries have stopped working. I haven't updated the wandb package recently, so I suspect it's a problem in the platform, or something else.
Expected Behavior
No response
Steps To Reproduce
No response
Screenshots
No response
Environment
OS: Windows
Browsers: Chrome
Version: 0.15.2
Additional Context
No response

Actually I think this is causing my sweeps to fail too. I have some code that ran a successful sweep this morning, I've just run it again now (the same code) and the sweep is no longer registering the val/accuracy and so fails.

Did you happen to push an update to the platform a few hours ago?

I also encountered the same problem this morning

same problem till now, I can see the log summary file in the artifacts, but it's not shown in the Table

Same problem here. Did anyone find a solution?

Hi @davidgilbertson @marshuang80 @ZedRover @self-disciplineprogress we're really sorry for any inconvenience this issue has caused.
Just a quick update here, this was escalated as a P0 issue, our Infra team identified the cause and have rolled back the change. Any new runs should show up the metrics in summary table now. The summary of the affected runs will be backfilled, this process has started and you should soon see the metrics being populated there.
I can keep you posted here once the backfilling has been completed. Thank you!

Hi everyone, the backfill of the summary metrics should be completed by now. I will now close this ticket, but please do let us know if you're still experiencing any issue and we will be happy to keep investigating. Thanks all for your patience.


python310Packages.buildbot: 3.6.1 -> 3.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.buildbot is: "An open-source continuous integration framework for automating software build, test, and release processes"
meta.homepage for python310Packages.buildbot is: "https://buildbot.net/"
meta.changelog for python310Packages.buildbot is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 3.7.0 with grep in /nix/store/d0za6884q7dnbrfipzyf5xfz50qq8lzz-python3.10-buildbot-3.7.0
found 3.7.0 in filename of file in /nix/store/d0za6884q7dnbrfipzyf5xfz50qq8lzz-python3.10-buildbot-3.7.0

Rebuild report (if merged into master) (click to expand)

24 total rebuild path(s)

24 package rebuild(s)

First fifty rebuilds by attrpath
buildbot
buildbot-full
buildbot-ui
buildbot-worker
python310Packages.buildbot
python310Packages.buildbot-full
python310Packages.buildbot-pkg
python310Packages.buildbot-plugins.console-view
python310Packages.buildbot-plugins.grid-view
python310Packages.buildbot-plugins.waterfall-view
python310Packages.buildbot-plugins.wsgi-dashboards
python310Packages.buildbot-plugins.www
python310Packages.buildbot-ui
python310Packages.buildbot-worker
python39Packages.buildbot
python39Packages.buildbot-full
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-ui
python39Packages.buildbot-worker

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/d0za6884q7dnbrfipzyf5xfz50qq8lzz-python3.10-buildbot-3.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.buildbot https://github.com/r-ryantm/nixpkgs/archive/f9b369ec2e18b9afaf20cd081ef0e48e5e393b23.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/d0za6884q7dnbrfipzyf5xfz50qq8lzz-python3.10-buildbot-3.7.0
ls -la /nix/store/d0za6884q7dnbrfipzyf5xfz50qq8lzz-python3.10-buildbot-3.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

python39Packages.buildbot
python39Packages.buildbot-full
python39Packages.buildbot-ui

17 packages built:

buildbot (python310Packages.buildbot)
buildbot-full (python310Packages.buildbot-full)
buildbot-ui (python310Packages.buildbot-ui)
buildbot-worker (python310Packages.buildbot-worker)
python310Packages.buildbot-pkg
python310Packages.buildbot-plugins.console-view
python310Packages.buildbot-plugins.grid-view
python310Packages.buildbot-plugins.waterfall-view
python310Packages.buildbot-plugins.wsgi-dashboards
python310Packages.buildbot-plugins.www
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker

Maintainer pings
cc @ryansydnor @lopsided98 for testing.

I had an existing PR (#204520) for this update that also added a new plugin included in this release. I have rebased that PR and would appreciate a review.


2020-02-01-preview for Media Services LVA

Changes to MediaGraph model
Changing PUT from sync to async
Fixing some description
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@allenjzhang could you help sign off this PR or provide more feedback that we need to address?

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Hi @pilor @allenjzhang @lirenhe , after some internal discussion within our team after the review meeting, we've decided to hold off the changes to async PUT, and just release the changes of adding a few new properties for media graph entity (our main ARM entity).
As suggested by @pilor , we uploaded the previous API version to commit 8 for easier review. So please compare the latest iteration with that commit as below screenshot.

Reset labels due to changes. Reviewing...


ENH: Add the geometric standard deviation function

Redo of #9395.
This PR implements a geometric standard deviation function and closes #9154. The geometric standard deviation describes the spread of a set of numbers where the geometric mean is preferred.
The original PR included several revisions handling masked arrays, mstats and invalid values. These revisions obfuscate the commit history and are starting to repeat the original commits.
Several issues occurred checking for  and handling invalid values (see  #9558 and  numpy/numpy#4959) . In particular the use of nan_policy. The current implementation does not use nan_policy. It attempts a naive calculation of the geometric standard deviation. If this fails it checks for invalid arguments, raising a descriptive error message.
Another discussion centered around the use of the mstats module. The original PR included support for both regular and masked arrays. Later changing to include an implementation in both stats and mstats. This later changed back to only include a stats version.
@chrisb83 @WarrenWeckesser would you be willing to take a look over this?

The idea behind the try..except statement is to avoid checking the input arrays twice. This way (should) work faster when a valid array is passed. But would be significantly slower when it wouldn't work, to me, this seemed like a good trade-off.
I've implemented them as checks to avoid the try..except statement. Here are some timings (units of seconds as floats for 30 runs) for a 1000x1000 array of np.float64.
Repeating 5 runs of 30 trials

Array is valid:
Time with checks:  [1.203507800000807, 1.1911648000022979, 1.1953944000015326, 1.1901376999994682, 1.191319300000032]
Time with exceptions:  [0.6507973999978276, 0.63852659999975, 0.6370251000007556, 0.6375709000021743, 0.6372553000001062]

Array contains zero:
Time with checks:  [0.0644265999981144, 0.06380280000303173, 0.06387930000346387, 0.06453880000117351, 0.0649091999985103]
Time with exceptions:  [0.5850529999988794, 0.5865052000008291, 0.5919960999999603, 0.5863754000019981, 0.5864228000027651]

Array contains negative:
Time with checks:  [0.034902499999589054, 0.03421309999976074, 0.03458369999862043, 0.034749700000247685, 0.03605949999837321]
Time with exceptions:  [0.528536300000269, 0.5280047000014747, 0.5277626999995846, 0.5291075000022829, 0.5284775000000081]

Array contains inf:
Time with checks:  [0.018257800002174918, 0.01787029999832157, 0.017890900002385024, 0.01802010000028531, 0.01797169999917969]
Time with exceptions:  [0.5066953000023204, 0.5100607999993372, 0.508547900000849, 0.5079172999976436, 0.5103061000008893]

For the valid case, using try..except is ~2x as fast as using checks. HOWEVER for invalid cases try..except is much slower than trying to catch errors. As it stands I'm not sure which one would be preffered, but looking at the numbers I don't think the slight increase in speed justifies losing that much time for invalid values.
What do you think?

Thanks for the additional info. I think the trade-off higher speed for correct input vs slower speed for incorrect input is fine. Let's see what others say

@tylerjereddy any thoughts on using try..except vs checks? Otherwise, I'll look to merge it soon.

@Kai-Striega since this now has 3 merges of master into your branch, it would be useful to rebase to get rid of those. If it doesn't rebase cleanly, perhaps squash and rebase?

@tylerjereddy I included the timing to demonstrate the difference between checking and try..except. The performance (shouldn't) really be a concern and I don't think adding asv benchmarks are required.
I've added a versionadded of 1.3.0.
@rgommers will do.

@rgommers is the history better now? And if so, could you merge it?

@rgommers does the version history look better now? If so could you merge it once the tests pass?

Thanks, version history looks good now.
Had a quick look at the try-except, that seems fine here. Normally we do explicit checks, but when the checks become expensive compared to the one-liner that's the actual functionality, then I'm fine with try-except to speed that up.
Everyone is happy it seems, so in it goes. Thanks @Kai-Striega & reviewers!

@Kai-Striega could you add an entry to https://github.com/scipy/scipy/wiki/Release-note-entries-for-SciPy-1.3.0 for this?


add the initial skeleton for the ovn collector

add the initial skeleton for the ovn collector that will be used in subsequent commits to flesh out the collector and its metrics.

Hi Miguel,
thanks for your patch. if that is OK, I would prefer not to merge it as it is. It would effectively be dead code.
I will hold off until you have something actually extracting info from ovn-controller.
Cheers.

Hi Robin,
Thank you for looking at this PR.  Let's keep this PR alive. I'll amend it with the code I am writing now.
Cheers


Improve package structure and Event factories

This PR improves the package structure as follows:

The command package was split into command, commandbus, and commandstore
Classes from server.validate were moved to validate in the client API.
Creation of events now is server-side code. See EventFactory and ImportEventFactory utility classes.

A following PR would make EventFactory and ImportEventFactory non-utility classes.

@IlliaShepilov, consider merging with this branch in your validator-related works.

@armiol, PTAL.

@armiol, please have a look at new EventFactory API.

@armiol, PTAL.


feat(schematics): Create schematics for generating a store and it's associated files.

According to the docs we should generate three files.
todos.store.ts
todos.store.spec.ts
todos.events.ts

This could also look for the closest module and automatically add the store as a declaration and use it in the forRoot or forFeature functions.

If someone wants ot take this on, here is a example of some schematics I wrote for Material - https://github.com/angular/material2/tree/master/schematics

I can take this one /Mike

Hi,
I created schematics for ngxs:store, action & selector. I still needs some work, but I'll submit a PR for what I have so far, to open it up for comments and enhancements.
Should I create a new folder for schematics under tools or somewhere else?
Do we still want actions to use the name .events.ts, I see multiple examples that use .action.ts?
/Mike

@BeastCode Did you get anywhere with creating this PR?

Hello, I would like to take this issue. Is there any work in progress or should I start from scratch?
@amcdnl posted a link to material's schematics, but it has been moved:
https://github.com/angular/material2/tree/master/src/lib/schematics

This would be a great addition :)


update pdoc3 and watchdog

Checklist

[ ] Pre-commit hook is installed to do formatting checks before committing code...etc
[ ] Tests included
[ ] Build pass
[ ] Documentation
[ ] Code format and docstrings

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.82%. Comparing base (2502990) to head (fb0e89b).
Report is 23 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #609   +/-   ##
============================================
  Coverage        72.82%   72.82%
============================================
  Files               78       78
  Lines             3499     3499
============================================
  Hits              2548     2548
  Misses             951      951

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Incorrectly formatted text

On the first screenshot is displayed epg from your script and second screenshot is showing epg (from Iptvnator) correctly.
There is a little rectangle after each actor's name instead of the gap/space. Or even better if there would be comma + space.

Screenshots

Can you share a link to the EPG data or a cache file?
cache location in linux ~/.cache/EPGTV
cache location in windows C:\Users\user\AppData\Local\EPGTV
paste it in https://gist.github.com/ in whole or in part which contains this text
It might just be a problem with your font in mpv , if so there's nothing I can do about it.

Here you go...
The main problem is the actors are taking too much space (one actor per one line). So there is too much empty unused space on the screen.

@bt4ibwem8,
fixed, update and check :)

cheers mate, now it runs correctly (i just tested it now in the new 0.39.0 mpv version)

cheers mate, now it runs correctly (i just tested it now in the new 0.39.0 mpv version)

It is incorrect again:

@bt4ibwem8 this is strange, try update EPG script maybe, try press 'u' and update old tv cache
Im manual  prepare and check this tv info as title view and as next view. And no have new lines in screen

And EPGCACHE okey, just one line
TEST "#"<PHONE_NUMBER>22<PHONE_NUMBER>22 3 "DOKTOR MARTIN" "Humorný seriál z prostredia podhorského mestečka Protějov v Beskydách. Stret svojráznej povahy nového obvodného lekára z Prahy s podhorským spôsobom života prinesie rad humorných, aj menej veselých, nečakaných situácií Petr Zahrádka Miroslav Donutil Jitka Čvančarová Gabriela Marcinková Jana Štěpánková Norbert Lichý Václav Kopta Tomáš Měcháček Tomáš Jeřábek Emília Vášáryová."

I can't confirm the problem.
Perhaps you have several directories with different configurations, or several players with different configurations and one of them contains an old EPGTV script

You are right. Just updated epg data with U and now it is showing correctly. I am on the latest 0.39.0 mpv release version.


[genesis] actually push names into validators and operators

Existing genesis creation does not introduce names, that is fixed
Existing genesis requires owner keys but we cannot expect that.
Improve operational tooling around validator configs to include names
Use names to support add / remove validators
Remove cli stuff around add / remove validators as it is broken

Traditionally, account addresses are derived from authentication keys, which in turn are derived from the public key. If we do not have a public key, we must do it some way else. So we derive a consistent address from the owner name. We then set the authentication key from either the Some(key) or set it to 0; 32
cc: @ankushagarwal , @dmitri-perelman , @huitseeker , @kchalkias  we indeed can set auth account to all 0s! Thanks for your time and thoughts :)

@JoshLind , thanks! Hopefully the last pr is almost done.. it is ... nuanced..

/land


MM-23524: Integrate Dependency-Check to CircleCI

Summary
Adds a check-deps job to the CircleCI workflow.
Ticket Link
https://mattermost.atlassian.net/browse/MM-23524
Related Pull Requests
Screenshots

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

/update-branch

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

/update-branch

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

Trying to auto merge this PR.

Pull Request successfully merged
SHA: ae8e10a0c15cbb33d8c3fbfb2ca1173aa6002d4b


Preview from PRs

It would be very nice to have a preview of the site from a pull request. I am not entirely sure whether it's easily possible to actually do this, but it would make reviewing changes that are mainly visual or that at least have a visual component to their functionality much easier. E.g. new buttons / toggles or interactive filtering, etc...

I'll take a look and see how can I implement this.

Hey @tmadlener, @kjvbrt. I got some updates. So after some exploration and testing, I found this GitHub Action called pr-preview-action that could be very useful. It basically creates a secondary branch called gh-pages. This branch is used to store people's code from a pull request, to later deploy it to GitHub Pages. So whenever a pull request is opened, it deploys a preview and adds a link into the PR discussion (as a commentary from gh bot). To set up, a few things are required:

Create the GitHub actions files for the workflows. We need 2 .yml files, because one will be used to define deployments of the main website (from main branch), and the other file to setup the previews. You can check an example ready to use in this repo.
Configure the repo settings to deploy to pages from the gh-pages branch. This will enable preview.
And solve any kind of problems.

You can check how it works on my repo.

Hi @brauliorivas, this looks neat.
ATM we deploy dmx from the main branch. Changing it to the gh-pages should not be a problem. We will however need to enclose the main version into a subdirectory.
I'm not sure which subdirectory to use, main seems natural choice. So, the url will be:
https://key4hep.github.io/dmx/main/

But having also something like stable or release would probably be also acceptable. @brauliorivas, @tmadlener Let me know which you prefer.
The preview pages will then be like this, right?
https://key4hep.github.io/dmx/pr-preview/pr-1/

@brauliorivas I'm getting 404 on your example PR :)

Can we have both stable / release and main? :)
The branches you are mentioning mainly refer to where the action picks things up from, right? And that then determines the subdirectory? Or do we have to create subdirectories in the repository?
We can probably add a redirect from key4hep.github.io/dmx to latest, right?

@brauliorivas I'm getting 404 on your example PR :)

Sorry! I made a mistake with my configuration.
This is how pr-preview-action works. It always deploys previews website under gh-pages

I can get to the preview page now. How hard would it be to add something like this to this repository? I think this would be extremely useful for our GSoC project (especially for me as a reviewer of PRs ;) )

The preview pages will then be like this, right?
https://key4hep.github.io/dmx/pr-preview/pr-1/

Yes! You are correct.

But having also something like stable or release would probably be also acceptable. @brauliorivas, @tmadlener Let me know which you prefer.

Can we have both stable / release and main? :) So basically sort of a released version, but also a development version that we can use to let people test the latest developments more easily while not breaking the release?

So, using the workflow I mentioned, I got my repo here to have two kinds of deployments.

One for production, as you @tmadlener @kjvbrt mentioned, for release/stable dmx.
One for beta, which will be a few commits ahead of main. This beta/development deploy will be under the beta branch, and deployed to the same gh-pages.

In this way, we can keep main, beta ,and gh-pages branches detached from each other.

main will only contain the stable code.
beta will contain code that is for testing/development purposes.
gh-pages will contain each version in a distinct folder for deployment, and we/new contributors won't need to take care of it.

The final url's will be something like:
https://key4hep.github.io/dmx/ for main
https://key4hep.github.io/dmx/beta for development
https://key4hep.github.io/dmx/pr-preview/pr- for previews on pull request.
So, the final contribution workflow could either be:

Contribute to the beta branch and then manually merge into main.
Contribute directly main branch and then having to manually merge main to beta.

So, the final contribution workflow could either be:

Contribute to the beta branch and then manually merge into main.
Contribute directly main branch and then having to manually merge main to beta.

I think I still need some clarification for the the last part, but you get it 😄

Now the example works for me :)
I would keep release, main and pr-preview as separate subdirectories. To redirect from main one can use redirect like this:
https://github.com/HEP-FCC/fcc-tutorials/blob/gh-pages/index.html

I would keep release, main and pr-preview as separate subdirectories. To redirect from main one can use redirect like this:
https://github.com/HEP-FCC/fcc-tutorials/blob/gh-pages/index.html

Hey @kjvbrt, I've updated my repo https://github.com/brauliorivas/fouriertransform. Now, main, release and pr-previews deploy to an individual folder under gh-pages branch. And every time someone enters to https://brauliorivas.github.io/fouriertransform/, it is redirected to main https://brauliorivas.github.io/fouriertransform/main/index.html. This will serve for #16.

Nice, I like it.

I like this too :)

This is working now as desired.


4176 customizing reminder message to partners

Resolves #4176
Description
This PR allows a custom message to be added to the distribution reminder message similar to how we currently make customizations on the distribution email content.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested manually
Wrote two tests in the distribution_mailer_spec that account for a distribution that includes a custom_reminder

Provide instructions so we can reproduce.
You can test the email manually by:

run the app locally bin/start
go to http://localhost:3000/diaper_bank/distributions/1/edit
add a custom message and ensure that the distribution date and time is for a date in the future.
open rails c
run DistributionMailer.reminder_email(Distribution.first.id).deliver_now A mailer preview should open in your browser.

Screenshots

Hey @nathangthomas -- I see you have two prs related to this, and the second one is WIP.  Are you looking to have this one merged, or the second one?  Thanks.


When no drivers are availabel agrees with modernizr on storage drivers support fails with modernizr v3.0.0-alpha.3

When No Drivers Are Available agrees with Modernizr on storage drivers support:
Error: expected false to equal true
at http://localhost:9999/bower_components/expect/index.js:102
at http://localhost:9999/bower_components/expect/index.js:219
at http://localhost:9999/bower_components/expect/index.js:69
at http://localhost:9999/test/test.nodriver.js:23
at callFn (http://localhost:9999/bower_components/mocha/mocha.js:4338)
at http://localhost:9999/bower_components/mocha/mocha.js:4331
at http://localhost:9999/bower_components/mocha/mocha.js:4728
at http://localhost:9999/bower_components/mocha/mocha.js:4819
at next (http://localhost:9999/bower_components/mocha/mocha.js:4653)
at http://localhost:9999/bower_components/mocha/mocha.js:4663
at next (http://localhost:9999/bower_components/mocha/mocha.js:4601)
at http://localhost:9999/bower_components/mocha/mocha.js:4630
at timeslice (http://localhost:9999/bower_components/mocha/mocha.js:5761)

Sorry, but I don't quite understand the issue. Could you show me the code you're trying to run that's failing?

tofumatt

On Fri, Jul 24, 2015 at 12:28 PM, Remko Boschker<EMAIL_ADDRESS>wrote:

When No Drivers Are Available agrees with Modernizr on storage drivers support:
Error: expected false to equal true
at http://localhost:9999/bower_components/expect/index.js:102
at http://localhost:9999/bower_components/expect/index.js:219
at http://localhost:9999/bower_components/expect/index.js:69
at http://localhost:9999/test/test.nodriver.js:23
at callFn (http://localhost:9999/bower_components/mocha/mocha.js:4338)
at http://localhost:9999/bower_components/mocha/mocha.js:4331
at http://localhost:9999/bower_components/mocha/mocha.js:4728
at http://localhost:9999/bower_components/mocha/mocha.js:4819
at next (http://localhost:9999/bower_components/mocha/mocha.js:4653)
at http://localhost:9999/bower_components/mocha/mocha.js:4663
at next (http://localhost:9999/bower_components/mocha/mocha.js:4601)
at http://localhost:9999/bower_components/mocha/mocha.js:4630
at timeslice (http://localhost:9999/bower_components/mocha/mocha.js:5761)
Reply to this email directly or view it on GitHub:
https://github.com/mozilla/localForage/issues/409

Hi, I updated to modernizr 3 to check for service worker availability. This caused another test to fail. We have used another test to check for it without updating modernizr. https://github.com/mozilla/localForage/pull/406

Cool, thanks for the update.