Fixing file with rule F401 cause infinite loop

ruff 0.5.5+353 (2f54d05d9 2024-07-29)
ruff check *.py --select F401 --no-cache --fix --unsafe-fixes --preview --output-format concise --isolated

file content(at the bottom should be attached raw, not formatted file - github removes some non-printable characters, so copying from here may not work):
from .main import MaµToMan

error
/tmp/tmp_folder/data/5737962126122819962.py:1:8: F401 `tima` imported but unused
Found 501 errors (500 fixed, 1 remaining).
[*] 1 fixable with the --fix option.

debug error: Failed to converge after 500 iterations in `/tmp/tmp_folder/data/5737962126122819962.py` with rule codes F401:---
import timª
---

Ruff build, that was used to reproduce problem(compiled on Ubuntu 22.04 with release mode + debug symbols + debug assertions + overflow checks) - https://github.com/qarmin/Automated-Fuzzer/releases/download/Nightly/ruff.7z
python_compressed.zip

Cool bug, thanks!

This is an issue with NFKC normalization. If you apply this diff to Ruff:
diff --git a/crates/ruff_linter/src/fix/codemods.rs b/crates/ruff_linter/src/fix/codemods.rs
index c3c769172..ed4061435 100644
--- a/crates/ruff_linter/src/fix/codemods.rs
+++ b/crates/ruff_linter/src/fix/codemods.rs
@@ -80,7 +80,7 @@ pub(crate) fn remove_imports<'a>(
     for member in member_names {
         let alias_index = aliases
             .iter()
-            .position(|alias| member == qualified_name_from_name_or_attribute(&alias.name));
+            .position(|alias| dbg!(member) == dbg!(qualified_name_from_name_or_attribute(&alias.name)));
         if let Some(index) = alias_index {
             aliases.remove(index);
         }
diff --git a/crates/ruff_linter/src/rules/pyflakes/rules/unused_import.rs b/crates/ruff_linter/src/rules/pyflakes/rules/unused_import.rs
index bfa884801..4c86744db 100644
--- a/crates/ruff_linter/src/rules/pyflakes/rules/unused_import.rs
+++ b/crates/ruff_linter/src/rules/pyflakes/rules/unused_import.rs
@@ -397,6 +397,8 @@ pub(crate) fn unused_import(checker: &Checker, scope: &Scope, diagnostics: &mut
         }
         diagnostics.push(diagnostic);
     }
+
+    panic!()
 }

Then the output from the debug calls is as follows:
[crates/ruff_linter/src/fix/codemods.rs:83:31] member = "MaμToMan"
[crates/ruff_linter/src/fix/codemods.rs:83:47] qualified_name_from_name_or_attribute(&alias.name) = "MaµToMan"

And I'll also paste a screenshot because it looks like GitHub might actually normalize these confusables as well when it renders them in an issue comment?!):

If you look very closely at that screenshot, you can see that the μ on the first line is sliiiightly narrower in size than the µ on the second line. In other words, one of the two variables has been NFKC-normalized while the other has not, meaning the comparison here evaluates to false when it should be evaluating to true:
https://github.com/astral-sh/ruff/blob/381bd1ff4a38e0582618e76ae1bd3696b1b2ff5d/crates/ruff_linter/src/fix/codemods.rs#L83


Beginner

I'm looking up to you black panther, my python mentor 😂😂

Who are you?
On Fri, Jan 6, 2023, 6:10 PM Abdulazeez1960 @.***>
wrote:

I'm looking up to you black panther, my python mentor 😂😂
—
Reply to this email directly, view it on GitHub
https://github.com/geekcomputers/Python/issues/1819, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATGGBY4QRQPW7EEZGTWXSNLWRAKU7ANCNFSM6AAAAAATTCA5Z4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


oai.yosemite validation results

oai.yosemite issues

[ ] coverage & spatial: currently mapping <dcterms:spatial> to both coverage and spatial. Please map to only spatial. (Note however that we have some messy spatial and coverage mapping logic in solr_updater.py : https://cdlib.slack.com/archives/CQ534NT47/p1699395989918789?thread_ts=1699393088.260719&cid=CQ534NT47)
[ ] spatial: should be in an array (currently a string).

See examples: #26989 (2023-10-25); #27631 (2023-10-25)

likely addressed at upper levels
Verify whether these are addressed by the base oai mapper updates

[ ] source: map source -- [note: this may get addressed in the base oai mapper]

Made the following updates - not yet pushed up, but making a note here regarding some of the details and will push up momentarily.

mapping: is_shown_by and is_shown_at both filtered identifiers for identifiers with "npsgallery.nps.gov" in the string (along with other unique filters for each), but this subdomain has changed to "nps.gov/npgallery", updated filter accordingly
validating: updated is_shown_at, is_shown_by, and identifier validation logic to ignore this specific subdomain discrepancy
validating: updated coverage and spatial validation logic to report out exclusively lossy discrepancies, instances where not all solr values exist in rikolti, but not additive discrepancies, instances where all solr values exist in rikolti as well as new values
validating: records from collection 26989 all had the same value for is_shown_at: "https://npgallery.nps.gov/AssetDetail/3331008b-6cb0-4583-85f7-b3a93f7e074d", but in Rikolti, their is_shown_at value is unique to the record. the is_shown_at_improvements validator and the after_validation function check to make sure this new is_shown_at url is at the proper URL location and contains the proper object ID

Spatial is now a list, and source seems to be mapped - I didn't see any validation report errors for either of those. I did not remove the mapping to coverage due to the complexities of the solr_updater. Every collection has spatial and coverage values that are identical. We can revisit removing one or the other post MVP.

Is closed by #696


panic: could not match regexp, with windows 7

Precondition:
Windows 7, SP1, 32 bit
Visual Studio 2015 community edition
LLVM-3.9.1-win32
Windows 10 SDK (10.0.15063.468)
go version go1.8.1 windows/386

\go\c2go>c2go transpile examples\fib.c
panic: could not match regexp '(?P[0-9a-fx]+) <(?P.)> "(?P.?)"(?P ".*?")?' with string 'DeprecatedAttr 0x3b732f0 line:1107:12 Inherited "This function or variable may be unsafe. Consider using _snwprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details." ""'

goroutine 1 [running]:
github.com/elliotchance/c2go/ast.groupsFromRegex(0x57acb2, 0x3b, 0x120594a8, 0xd6, 0x56f0c4)
E:/dev/gocode/src/github.com/elliotchance/c2go/ast/ast.go:407 +0x2a7
github.com/elliotchance/c2go/ast.parseDeprecatedAttr(0x120594a8, 0xd6, 0x571939)
E:/dev/gocode/src/github.com/elliotchance/c2go/ast/deprecated_attr.go:15 +0x3f
github.com/elliotchance/c2go/ast.Parse(0x120594a8, 0xd6, 0xda, 0x11c189c0)
E:/dev/gocode/src/github.com/elliotchance/c2go/ast/ast.go:276 +0x1dbb
main.convertLinesToNodes(0x11c7a000, 0x18a5, 0x18a5, 0x11c7a000, 0x18a5, 0x18a5)
E:/dev/gocode/src/github.com/elliotchance/c2go/main.go:66 +0x165
main.Start(0x0, 0x11c4d8c0, 0xe, 0x0, 0x0, 0x56f599, 0x4, 0x11c48118, 0x8)
E:/dev/gocode/src/github.com/elliotchance/c2go/main.go:191 +0x628
main.main()
E:/dev/gocode/src/github.com/elliotchance/c2go/main.go:305 +0x2c2

I've got the same issue for mac 10.9.5

Hi @mikowiec this error is caused by it not able to understand a line outputted from clang - likely because it has extra special characters (like double quotes) that make it not match the expected regex.
The fix is to add a new test case, just like this one:
https://github.com/elliotchance/c2go/blob/master/ast/deprecated_attr_test.go#L9-L15
This will cause go test to fail (for the same reason) and then this regex needs to be adjusted:
https://github.com/elliotchance/c2go/blob/master/ast/deprecated_attr.go#L13
Are you feeling up to the challenge? 😄

Tell me, please, what golang version do you compile?
there is log from 1.8.1 golang, mac 1.9.5:
➜  c2go2 ./c2go transpile prime.c
panic: could not match regexp '(?P[0-9a-fx]+) <(?P.*)> always_inline' with string 'AlwaysInlineAttr 0x102882a40 line:346:24'
goroutine 1 [running]:
github.com/elliotchance/c2go/ast.groupsFromRegex(0x11b7973, 0x20, 0x4213ba9df, 0x2a, 0x4212cf3a0)
/Users/xxxxxxxx/gocode/src/github.com/elliotchance/c2go/ast/ast.go:407 +0x392
github.com/elliotchance/c2go/ast.parseAlwaysInlineAttr(0x4213ba9df, 0x2a, 0x11b3b65)
/Users/xxxxxxxx/gocode/src/github.com/elliotchance/c2go/ast/always_inline_attr.go:13 +0x4e
github.com/elliotchance/c2go/ast.Parse(0x4213ba9df, 0x2a, 0x2e, 0x42133c330)
/Users/xxxxxxxx/gocode/src/github.com/elliotchance/c2go/ast/ast.go:236 +0x2a0c
main.convertLinesToNodes(0x4213c0000, 0x268, 0x268, 0x4213c0000, 0x268, 0x268)
/Users/xxxxxxxx/gocode/src/github.com/elliotchance/c2go/main.go:65 +0x1ef
main.Start(0x0, 0x7fff5fbff669, 0x7, 0x0, 0x0, 0x11b148f, 0x4, 0x4212da330, 0x421334268)
/Users/xxxxxxxx/gocode/src/github.com/elliotchance/c2go/main.go:162 +0x788
main.main()
/Users/xxxxxxxx/gocode/src/github.com/elliotchance/c2go/main.go:276 +0x373
and there golang 1.6.2 and c2go version from april:
➜  c2go1 ./c2go transpile prime.c
panic: stat transpile: no such file or directory
goroutine 1 [running]:
panic(0x1c3d80, 0x8203745a0)
/usr/local/go/src/runtime/panic.go:481 +0x3e6
main.Check(0x88203c0290, 0x8203745a0)
/Users/xxxxxx/gocode/src/github.com/elliotchance/c2go/main.go:126 +0x4b
main.Start(0x820374370, 0x2, 0x2, 0x0, 0x0)
/Users/xxxxxx/gocode/src/github.com/elliotchance/c2go/main.go:139 +0x139
main.main()
/Users/xxxxxx/gocode/src/github.com/elliotchance/c2go/main.go:206 +0xaaxxxxxx

I use:
go version

Output:
go version go1.8.3 linux/amd64

clang --version

Output:
clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

In according to integration test of c2go https://github.com/elliotchance/c2go/blob/master/.travis.yml , guarantee supported next version of clang 3.4 ... 3.9, OS linux, osx:
os:
  - linux
  - osx

env:
  - CLANG=3.9

matrix:
  include:
    - env: CLANG=3.8
      os: linux
    - env: CLANG=3.7
      os: linux
    - env: CLANG=3.6
      os: linux
    - env: CLANG=3.4
      os: linux

➜   clang --version
Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)
Target: x86_64-apple-darwin13.4.0
Thread model: posix

@mikowiec Thank you for result of 2 checking.
I see 2 different errors. I haven't any recommendations, except : try install clang in list 3.4,3.6,3.7,3.8 for your Mac desktop and update Go for Win.

update Go for Win

x>c2go transpile prime.c
panic: could not match regexp '(?P[0-9a-fx]+) <(?P.)> "(?P.?)"(?P ".*?")?' with
string 'DeprecatedAttr 0xad3460 line:1107:12 Inherited "This function or variable may be unsafe. Consider using _snwp
rintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details."
So, what we check? Versions of Golang, Clang.
But - What the version of glibc?
For integration test used glibc 2.24-9.
On my laptop:

osx mac does not have ldd.
The osx equivalent is called otool -L
command "otool -L ./c2go" show me nothing shared library used.

Main point - find version of standard library C.
Maybe https://stackoverflow.com/questions/9705660/check-glibc-version-for-a-particular-gcc-compiler help to find.
I will try today to check c2go with old glibc.

osx base system does not use glibc

@Konstantin8105, Apples has a fork of clang that uses a different versioning scheme. It is not something that can be tested on travis.
The issue here is simple - it has nothing to do with clang versions or programs install. clang is outputting a line that is not understood by c2go's parsing mechanism. It is fixed by making the changes I outlined in my comment :https://github.com/elliotchance/c2go/issues/184#issuecomment-312760487

@elliotchance

this regex needs to be adjusted.
exactly.
I've resolved this issue and it will be fixed soon.

Like I understood - that issue is closed.

@Konstantin8105 feel free to close this issue if it is resolved.

:) I haven't permission for that


Organizations are listing unaffiliated Services

Some Organizations, in their detail page, seem to be listing Services that are not affiliated with that Organization. I can't seem to figure out why, but below are some examples:

Tonari Gumi Japanese Community Volunteers' Association seems to have only 1 Service, but is showing lots of services not affiliated with it

Similarly Telecare Crisis and Caring Line should only have 1 Service, and lists lots of unaffiliated services.

Coast Mental Health lists a few Coast Mental Health services at first, and then shows a bunch of unaffiliated services

On Staging 1.62.0, iPhone XS
Acceptance Criteria

[ ] Organizations' Services tab only lists their affiliated services, does not show Services that do not list that Organization as its provider

Steps for QA:

The organization IDs are off by a few digits which are within typo tolerance. I shut down the typo tolerance so the matches should be a lot stricter.

I can add typoTolerance: false, to the API call to override the indices' typoTolerance setting.

Staging 1.63.0 - looks good.


event_log table

Perhaps this isn't so much of an "issue" as it is me just missing something.
In the 01_observability DLT notebook, cmd2 is building the event_logs table by reading the {STORAGE_PATH}/system/events location as delta.  This notebook returns an error b/c there is nothing in that path to read and create the table.
So either I've missed a step of uploading a file to that DBFS location, or I've missed a step that would generate the Delta files in that location.
Any insight is greatly appreciated

Hey, I can only reproduce this if the Storage location doesn't match the STORAGE_PATH param that you pass in (in the current DLT UI you do this as a key/value pair in the Advanced section of the Pipeline settings page).
If you just want to try the DLT pipeline out, you could also remove the 01_observability notebook and just run 02_detect_and_redact_pii.
I only just committed a code change to fix a bug that caused an error processing the generated data, so make sure you do a pull before you re-run!

I also am having this same issue :/ storage path/location are the same...


feat(CLI): add exports field

Summary

Add exports field to the @rspack/cli package, align with @rspack/core and @rspack/dev-server.
Use sort-package-json to sort the package.json file.

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

what will consume @rspack/cli js API?

@hardfist Only a few public API, such as defineConfig and definePlugin:
// rspack.config.ts
import { defineConfig } from '@rspack/cli';

I add the exports field to prevent the internal modules of @rspack/cli from being mistakenly consumed by users.


Having the compontent rendered makes all sliders unslideable

I've stubled upon a very interesting bug. If you have the react-zoom-pan-pinch component anywhere rendered on the screen, all input html elements of type range would no longer be slide-able. You can click on them to change their value, but sliding (click and drag) them does nothing.
Here is sample code of slider that would no longer work if you have used the component:
import React, { Component } from 'react';

class GeneralOpt extends Component {
    constructor(props) {
        super(props);
        this.state = {
            to: -39
        };
        this.handlePoseChange = this.handlePoseChange.bind(this);
    }

    handlePoseChange(event) {
        let state = {to: event.target.value};
        this.setState(state);
    }
    render() {
        return (
            <div id="sidebar-container">
                <input
                    id="to"
                    type="range"
                    min="-100"
                    max="100"
                    value={this.state.to}
                    onChange={this.handlePoseChange}/>
            </div>
        );
    }
}

export default GeneralOpt;

Text selection (click and drag on a text) also seems to not work. I guess the component is tapping into the sliding event of the whole page somehow. It would be nice if the sliding worked as expected everywhere except over the react-zoom-pan-pinch component.
Thank you for the nice tool

Thanks for this issue! I will take a closer look on the topic this weekend while rewriting of lib 👍 😄

So after checking it, I found out that I made it because of many bugs/problems it was causing while panning. To solve this problem, you can make selecting or copying the text by some button inside which will add window selection. Or disable panning in my lib and disable user-select css class on TransformComponent class, this will allow you to select text.


JSON Schema for validating configuration files

The problem faced currently?
AFAIK, space-cloud is configured via providing json, yaml, or (for a limited subset) generating via cli. That works great.
It'd be great if it can have a schema file using which docs and autocompletion with types can be provided from inside the supporting IDEs or editors.
How can we solve it?
There are a couple of ways to solve it:

Write the schema manually

We must update it every time the Config changes.
Which is fine for projects with guaranteed configuration spec stability. RFC.
Easiest to do

Generate the schema

From the code

A script must be run before committing or merging into master. But hooks will do.
Go has a great parser provided built in, we can leverage that.
Not easy. Initial investment in time, but greater payoffs.

From the documentation

A script must be run same as above.
Output of go doc can be used to scrape specific parts for generating schema.
Not easy, great if we don't want to parse code, can be written in almost any language.

Recently I've been working on improving developer experience with open source projects. Let me know if this addition will help developers using it, and I'll create a PR.

Hey @dhruvin2910, are you talking about the config file?
I think documenting the config file will be amazing. Thats a great idea. But lets start this after v0.13.0 release?
Also, i think documenting the rest / graphql apis is far more important than the config file since mission control (the admin ui) generates a config file for sc. You think you can help in that regard?

Hey @dhruvin2910, are you talking about the config file?

Yes, but for IDEs and Editors, but mainly for intellisense, as developers won't read the schema.

I think documenting the config file will be amazing. Thats a great idea. But lets start this after v0.13.0 release?

I am not sure about the workflow for providing same configuration file across multiple instances of space-cloud. Correct me if I'm wrong about multiple instances.

Will I need to generate the config using dashboard beforehand, save it locally, then provide the same, and not edit it using UI in production?
Or the instances (or pods) need to share common volume? Since the admin ui seems to be making persistent config changes (to the disk).
Or something I'm missing.

Also, i think documenting the rest / graphql apis is far more important than the config file since mission control (the admin ui) generates a config file for sc. You think you can help in that regard?

I'm thinking along the lines of providing open api spec for the REST API (if not done already), as graphql schemas can directly be used by the IDEs or editors.

Here's a schema for prometheus.yml in action.

Initial schema without constraints is here.

This looks really good!


sim: add sqlite configuration

Summary
Add sqlite based on sim/minibasic configuration
Impact
Since hostfs does not support FIOC_FILEPATH, it cannot currently be used in hostfs
Testing
nsh> cd tmp
nsh> ls
/tmp:

nsh> sqlite3 test.db
SQLite version 3.45.1 2024-01-30 16:01:20
Enter ".help" for usage hints.
sqlite>

 CREATE TABLE COMPANY(
   ID INT PRIMARY KEY     sqlite> (x1...> NOT NULL,
   NAME           TEXT    NOT NULL,
   AGE            (x1...> (x1...> INT     NOT NULL,
   ADDRESS        CHAR(50),
   SALARY         (x1...> (x1...> REAL
);(x1...>

sqlite> .schema COMPANY
CREATE TABLE COMPANY(
   ID INT PRIMARY KEY     NOT NULL,
   NAME           TEXT    NOT NULL,
   AGE            INT     NOT NULL,
   ADDRESS        CHAR(50),
   SALARY         REAL
);
sqlite> .quit
sqlite>
nsh>
nsh> ls -l
/tmp:
 -rwxrwxrwx       12288 test.db

ping @Gary-Hobson

ping @Gary-Hobson

Documentation has been added, but this PR still needs to wait for https://github.com/apache/nuttx/pull/12303 to be merged, but it also depends on 2396
Documentation has been added, but this PR still needs to wait for fff to be merged, however it still depends on https://github.com/apache/nuttx-apps/pull/2396
If there are no other problems with CI, it can be merged tomorrow.

Impact
Since hostfs does not support FIOC_FILEPATH, it cannot currently be used in hostfs

Please upstream the patch which make hostfs support FIOC_FILEPATH.


[ANNOUNCEMENT] New Substrate Documentation & request for your feedback

:tada: The Substrate documentation has gone through a significant transformation. :tada:
We hope you really like the new and improved information architecture, look and feel of the very fast page navigation, improved internal search integration features, and more!
Although, as this is a radical change, and thus old documentation pages do not map 1-to-1. Therefore some content you might have been looking for could be missing intentionally or in the works that isn't ready just yet to be added to the new docs.

 :bookmark_tabs: : Checkout the new table of contents! (click to expand)
Getting started

Quick start
Install
Build a local blockchain

Key concepts

Fundamentals

Runtime development

Rust for Substrate
Runtime development
Build
Test

Tutorials

Tutorials

How-to guides

How-to quick reference

Tools

Command-line tools

Advanced

Reference

Found this issue looking for a now :four: :zero: :four: page or a through a redirect?
If you have bookmarked pages in the old site, the page you are looking is no longer available at that location. :see_no_evil:

If you arrived here from a link within the new Substrate Developer Hub content, please open an issue to report the broken link.
If content is missing that was on the old docs, or otherwise is something you were looking for, please:

If you arrived at this page as the content you were looking for from a post on the Substrate and Polkadot Stack Exchange led you here, please suggest an edit on the post directly with the correct link in the new docs. If unable to do so, instead add a comment to notify the author and community that the location has changed. :pray:
If you arrived here from an external resource - such as a search engine, blog, example code, or other content that is maintained externally - please inform the authors that they need to update their links to use the new site.
If after searching the new docs, you cannot find what you need, please open an issue to request new or edited content and detail what you were looking for and mention if there was an external source that suggested it existed here or in the old docs.

:memo: Let us know what you think!
Please provide feedback on you experience with the new docs!
Feel free to comment on this issue with any thoughts, feelings (positive or negative), or whatever comes to mind. :grinning:
For a more structured way to post a comment, you can copy&paste this template as well:

Feedback template (click to expand)

<!-- copy & paste the below and fill out as you see fit :) -->

### Overall impressions

Let us know about your experience with the new site:
- [ ] Love it! :+1:
- [ ] Neutral :shrug:
- [ ] Needs work... :confused:
- [ ] Bring back the old docs :back:
- [ ] Hate it! :face_exhaling:

I think the  information architecture is this because:

...

### Page feedback

#### The best page on the site is:

`<this link>`

Because ...

#### The worst page on the site is:

`<this link>`

Because ...

#### Is this your first visit to the new website?

`<yes/no>`

#### If you did not find what you needed, please tell us what info you were seeking?

...

#### How easy is it to find information on the site?

_(Did you first try the search :mag: in the top navigation bar?)_ `<yes/no>`

...

#### Please provide any additional comments or suggestions! :grinning:

...

https://github.com/substrate-developer-hub/substrate-docs/issues/1132


Delete obsolete and/or broken GHC versions

The following GHC versions are unused and/or broken and should be deleted:

pkgs/development/compilers/ghc/6.10.1-binary.nix
pkgs/development/compilers/ghc/6.10.1.nix
pkgs/development/compilers/ghc/6.10.2.nix
pkgs/development/compilers/ghc/6.10.3.nix
pkgs/development/compilers/ghc/6.11.nix
pkgs/development/compilers/ghc/6.12.1-binary.nix
pkgs/development/compilers/ghc/6.12.1.nix
pkgs/development/compilers/ghc/6.12.2.nix
pkgs/development/compilers/ghc/6.4.2-binary.nix
pkgs/development/compilers/ghc/6.4.2.nix
pkgs/development/compilers/ghc/6.6.1.nix
pkgs/development/compilers/ghc/6.8.2.nix
pkgs/development/compilers/ghc/6.8.3.nix
pkgs/development/compilers/ghc/7.0.1.nix
pkgs/development/compilers/ghc/7.0.2.nix
pkgs/development/compilers/ghc/7.0.3.nix
pkgs/development/compilers/ghc/7.2.1.nix
pkgs/development/compilers/ghc/7.4.1.nix
pkgs/development/compilers/ghc/7.6.1.nix
pkgs/development/compilers/ghc/7.6.2.nix
pkgs/development/compilers/ghc/7.8.3-binary.nix

We should also add 7.10-RC1

@peti mind if we revive 7.8.3-binary? @joelteon and I are using it for bootstrapping 7.8.4 in our pure-darwin branch, which we'll soon be starting to merge back to master. 7.8.3-binary is a lot friendlier to us because it supports a clang backend, which happens to be all we can provide. The 7.4-based bootstrap would involve a bunch of shims to pretend clang is gcc again, and that sounds painful.
We don't necessarily need it in master right now, but we'll likely want to revive it when we merge back from pure-darwin unless you have better suggestions.

@copumpkin, according to @gridaphobe's comments in https://github.com/NixOS/nixpkgs/pull/5792 and https://github.com/NixOS/nixpkgs/pull/5746, we can build GHC 7.8.4 with Clang just fine in master already with 7.4.2-binary.

Okay, will talk with @gridaphobe, since I was under the impression that it'd be more painful. Thanks for the pointers!


link error at Xcode 6.0.1

the error message is:
Undefined symbols for architecture arm64:
"OBJC_CLASS$_EAGLContext", referenced from:
objc-class-ref in PPSSignatureView.o
"_glDisable", referenced from:
-[PPSSignatureView setupGL] in PPSSignatureView.o
"_glGenVertexArraysOES", referenced from:
-[PPSSignatureView setupGL] in PPSSignatureView.o
"_glGenBuffers", referenced from:
-[PPSSignatureView setupGL] in PPSSignatureView.o
"_glBufferData", referenced from:
-[PPSSignatureView setupGL] in PPSSignatureView.o
"_glVertexAttribPointer", referenced from:
-[PPSSignatureView bindShaderAttributes] in PPSSignatureView.o
"_glDeleteVertexArraysOES", referenced from:
-[PPSSignatureView tearDownGL] in PPSSignatureView.o
"_glMapBufferOES", referenced from:
_addVertex in PPSSignatureView.o
"_glDrawArrays", referenced from:
-[PPSSignatureView drawRect:] in PPSSignatureView.o
"_glBindBuffer", referenced from:
-[PPSSignatureView tap:] in PPSSignatureView.o
-[PPSSignatureView pan:] in PPSSignatureView.o
-[PPSSignatureView setupGL] in PPSSignatureView.o
"_glClearColor", referenced from:
-[PPSSignatureView drawRect:] in PPSSignatureView.o
"_glDeleteBuffers", referenced from:
-[PPSSignatureView tearDownGL] in PPSSignatureView.o
"_glClear", referenced from:
-[PPSSignatureView drawRect:] in PPSSignatureView.o
"_glUnmapBufferOES", referenced from:
_addVertex in PPSSignatureView.o
"_glBindVertexArrayOES", referenced from:
-[PPSSignatureView drawRect:] in PPSSignatureView.o
-[PPSSignatureView setupGL] in PPSSignatureView.o
"_glEnableVertexAttribArray", referenced from:
-[PPSSignatureView bindShaderAttributes] in PPSSignatureView.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Looks like you need to link GLKit. If you're using CocoaPods, this should happen automatically.


Add ElementRotation.of(Vector3Float origin, Vector3Float angles, boolean rescale)

it would be very convenient if you added the ability to parse ElementRotation from X, Y and Z like here:
https://github.com/unnamed/hephaestus-engine/blob/6849b23dea8cfbafc74827d54e341aed1a1d2b4a/reader-blockbench/src/main/java/team/unnamed/hephaestus/reader/blockbench/ElementReader.java#L87

I don't think this should be added since it can be misleading (at least during compile-time). Elements can only rotate in a single axis.

But we enter the rotation angle through Float, and not through Enum, which allows us to enter values in increments other than 22.5, which is just as misleading

This needs more feedback I guess.
@BiConsumer @FixedDev @OcZi

I don't like the pr. It's less clear than the existing methods. It seems like you can do rotations on more than 1 axis with that.


[Feature] Support odd count of GPUs

Motivation
Currently tensor parallelism is supported only for 2^n count of GPUs. Is it possible to support odd counts? I have 3x3090 and the last one could not be used in tensor parallelism. Hovewer, in other projects any count supported.
Related resources
No response
Additional context
No response

We have no plans to do that.
In LMDeploy, the number of attention heads should be evenly divided by tp.


Can I replace the catch-all content script?

The catch-all content script might be unnecessary. I had multiple content scripts before and merged them into one, but now it can probably all be run from background or something using the activeTab permission - might be able to get away from warning user it can change anything in all tabs... (or maybe not, since it does hide elements without the user actually invoking the extension)
https://developer.chrome.com/extensions/activeTab

Determined that I still need the background script, although was able to refactor a couple things to do less checks (only when new window created versus everytime the event page is loaded).


Automated Package Upgrade

:tada: This PR is included in version 28.5.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How to painting sagittal、coronal、transversal slices for dicom of js,I look up the doc but  I  am not seek out a way,Please help me ~

Prerequisites

[ ] Are you running the latest version?
[ ] Are you reporting to the correct repository?
[ ] Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.
Description
[Description of the bug or feature]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Codepen With Reproduction of Issue:

Basic Template

I believe what you're asking about is support for MPR

Multi Planar Reconstruction (MPR) generates new "slices" based on the series of axial slices acquired by a CT or MR from any given direction.

Related Issues:

https://github.com/cornerstonejs/cornerstoneTools/issues/335
https://github.com/cornerstonejs/cornerstone/issues/189

We do not yet support this functionality. There has been some talk about how to accomplish it. Different groups have created working concepts for both 2D and 3D MPR in Cornerstone, but I believe all existing source is proprietary/closed.
You might have some luck reaching out to Radical Imaging for paid services to develop the functionality you need. They're the only consultancy I'm aware of that works heavily with Cornerstone.

@dannyrb
I think the connerStone have its own api. if I use Multi Planar Reconstruction (MPR),can I combined utilization with the connerstone ?

@lalalawututu if you're accomplishing MPR with a 3rd party library, you'll likely need to create a custom "Image Loader" to create/load the images into Cornerstone.

@dannyrb hello, i found  ami.js can do the mpr, but its source is quite difficult for me to read, so i want to accomplish by myself. could you give me some advice or refs to do this. i have read the related issues. but i can not find the concrete algorithms o(╥﹏╥)o

@yiuyiu, @swederik may have some code lying around. I know he's played with ami.js as well as vtk.js and xtk.js. The challenging part is using the generated images in/with Cornerstone and Cornerstone Tools. If you hatch an elegant solution, I'm sure many people would be interested to hear and see more on this topic.


On Mac there is no Shortcut available to leave image view and go back to page

On Mac there is no Shortcut available to leave image view and go back to the initial page.
Alt + Space will work the same way like Shift + Alt + Space

You can set your own on under chrome://extensions/shortcuts Option+Space and Option+Shift+Space are taken already:

It does not work in Firefox so ...

https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox


Release notes for 1.2.x

Where I can find them?

@sebrojas14 updated changelog https://github.com/phonegap/phonegap-plugin-push/blob/master/CHANGELOG.md


Avoid to pin dependency versions

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.
https://packaging.python.org/discussions/install-requires-vs-requirements/

Currently, the versions of install_requires and extra_requires are pinned. But it's inconvenience for users. I propose that specifies what a project minimally needs to run correctly.

Currently, the read_requirements function in setup.py turns the == from the .in files into >=. So, I don't think setup.py is dictating any dependency with a ==.

I see. I close this.


Github - Read.md file missing for modules

Hi,
A m/f has reported about a bug where on visiting https://github.com/google/testrun/blob/main/docs/test/modules.md , and clicking on either DNS, Nmap, NTP or TLS lead to a '404 - page not found' error. Could you please look into it?

Documentation update has been released into dev. This will be released in v1.2 which is due 29th March.


Orubase tool information added

Orubase tool information added

Please open this PR against the cordova-website branch. Also, GitHub isn't able to see the originating repository for this PR.


Zooming with mousewheel

It would be nice if it was possible to zoom in and out using the mousewheel, without having to press Alt+Ctl+Shift at the same time.

@baxaeus just press ctrl+mousewheel simple

Great, thank you!
Best regards,
Beatrice
From: Imran khan @.>
Sent: Thursday, 26 September 2024 15:37
To: excalidraw/excalidraw @.>
Cc: Beatrice Axaeus @.>; Mention @.>
Subject: Re: [excalidraw/excalidraw] Zooming with mousewheel (Issue #8547)
Du får inte ofta e-post från<EMAIL_ADDRESS>Läs om varför det här är viktigthttps://aka.ms/LearnAboutSenderIdentification
@baxaeushttps://github.com/baxaeus just press ctrl+mousewheel simple
—
Reply to this email directly, view it on GitHubhttps://github.com/excalidraw/excalidraw/issues/8547#issuecomment-2376999386, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BLSL5LLIP43G6XY55UTQA4DZYQEWLAVCNFSM6AAAAABO2JLCLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWHE4TSMZYGY.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Tool fails to install NDK-tools on Macbook Air M1

Hello there, I've been trying to use your tool to build cpuinfo library for my project. Unfortunately, I am not able to do it, as the tool fails to install, even fails to find any available NDK tools for my laptop Here is the output when I try to install:
=============== Installing cpuinfo ===============

=>> STEP 1 : view formula
───────┬────────────────────────────────────────────────────────────────────────
       │ File: /Users/lukas/.ndk-pkg/repos.d/offical/formula/cpuinfo.sh
───────┼────────────────────────────────────────────────────────────────────────
   1   │ package set summary "CPU INFOrmation library"
   2   │ package set git.url "https://github.com/pytorch/cpuinfo.git"
   3   │ package set bsystem "cmake"
   4   │
   5   │ build() {
   6   │     cmakew \
   7   │         -DCPUINFO_BUILD_UNIT_TESTS=OFF \
   8   │         -DCPUINFO_BUILD_MOCK_TESTS=OFF \
   9   │         -DCPUINFO_BUILD_BENCHMARKS=OFF
  10   │ }
───────┴────────────────────────────────────────────────────────────────────────

=>> STEP 2 : load formula

=>> STEP 3 : find Android NDK
🔔  Android NDK Not Found on your build machine, I will install it for you.
💔  ndk-pkg ndkmanager install <Reversion> , for example: ndk-pkg ndkmanager install r23b, you can get <Reversion> via run: ndk-pkg ndkmanager ls-available
💔  install cpuinfo failed!

Do you have any idea why?
I tried to reinstall ndk-pkg, upgrade it and rerun it again, but without success. Also, the autocomplete does not work, even when I follow the steps multiple times.
I have MacOS Monterey 12.1

Does Android NDK supports Mac M1? It seems that only support x86_64.
I have no Mac M1, I can not test it.
I recommand you run ndk-pkg via docker. For details please read the Readme
you can set and export ANDROID_NDK_HOME  which point to the dir where your NDK is located in.

Also, the autocomplete does not work, even when I follow the steps multiple times. I have MacOS Monterey 12.1

the autocomplete script only support zsh currently. do you using zsh? Could you run echo $FPATH | tr : '\n'?

For the zsh:
% echo $FPATH | tr : '\n'
/usr/local/share/zsh/site-functions
/usr/share/zsh/site-functions
/usr/share/zsh/5.8/functions

Regarding the ndk, do you suggest building it in docker and then exporting it to library or how? I don't quite understand. Also, it seems only the recent beta od NDK (ndkVersion "24.0.7956693") is able to work with m1, so maybe I'll try to install that, I will report if I have any further progress

run ndk-pkg integrate zsh
check /usr/local/share/zsh/site-functions/_ndk-pkg if exists.
run autoload -U compinit && compinit

I followed the steps and it doesn't work. Still can't TAB when I type ndk-pkg i and it doesn't autocomplete to install

Also, I exported ANDROID_NDK_HOME as seen below and still it failed to install, how should I modify the path?
The file is named .zshenv
export ANDROID_HOME=$HOME/Library/Android/sdk
export PATH=$PATH:$ANDROID_HOME/emulator
export PATH=$PATH:$ANDROID_HOME/platform-tools
export PATH=$PATH:$ANDROID_HOME/tools
export PATH=$PATH:$ANDROID_HOME/tools/bin
export PATH=$PATH:$ANDROID_HOME/ndk/24.0.7956693
export ANDROID_NDK_HOME=$ANDROID_HOME/ndk/24.0.7956693

you should rename$ANDROID_NDK_HOME/toolchains/llvm/prebuilt/darwin-x86_64 to $ANDROID_NDK_HOME/toolchains/llvm/prebuilt/darwin-arm64

Haha, no way, it started to work, but it now prints this message:
CMake Error: CMake was unable to find a build program corresponding to "Ninja".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
💔  install cpuinfo/armeabi-v7a failed! you can go to /var/folders/nn/t7zbwwzx0m56wsxlnqth8xk40000gn/T/tmp.LRxCdqLq to see see.
Is it an issue with the tool or the library I want to download? I am guessing the second one. Also, will you please change the verification method for the ndk_home directory in your script so it supports the m1 ? :)

does homebrew installed on your build machine?
could you attach the full logs file here?
ndk-pkg install cpuinfo |& tee cpuinfo.log

What fixed the issue was that in my NDK directory I duplicated the folders, so now they look like this:

 As you can see the arm64 folder is needed for ndk-pkg to work (otherwise it would complain that the NDK is not installed) and the original x86_64 is needed for cmake to actually work.
I'd suggest, if possible, to do a weaker check for NDK library (or allow it to work on M1 Macs) so that we don't have to do such workaround

rename back darwin-x86_64
run ndk-pkg upgrade @self to update ndk-pkg to latest.

Still does not work unfortunately :/

could you attach the full logs file here?
ndk-pkg install cpuinfo |& tee cpuinfo.log

sure:
=============== Installing cpuinfo ===============
=>> STEP 1 : view formula
package set summary "CPU INFOrmation library"
package set git.url "https://github.com/pytorch/cpuinfo.git"
package set bsystem "cmake"
build() {
cmakew
-DCPUINFO_BUILD_UNIT_TESTS=OFF
-DCPUINFO_BUILD_MOCK_TESTS=OFF
-DCPUINFO_BUILD_BENCHMARKS=OFF
}
=>> STEP 2 : load formula
=>> STEP 3 : find Android NDK
🔔  Android NDK Not Found on your build machine, I will install it for you.
💔  ndk-pkg ndkmanager install  , for example: ndk-pkg ndkmanager install r23b, you can get  via run: ndk-pkg ndkmanager ls-available
💔  install cpuinfo failed!

you have not set and export ANDROID_NDK_HOME
I guess you just write ~/.zshenv, you do not source it.
please run source ~/.zshenv

if stiil have problem, please run following command:
ndk-pkg install cpuinfo -x |& tee cpuinfo.log

attach cpuinfo.log here

cpuinfo.log
Here you go. And I exported the variable and sourced it

run ndk-pkg upgrade @self to update ndk-pkg to latest.
run ndk-pkg install cpuinfo

if stiil have problem, please run following command:
ndk-pkg install cpuinfo -x |& tee cpuinfo.log
```
attach cpuinfo.log here

Works like a charm, thank you very much :)

About the zsh-compeletions script, could you help me check if /usr/local/share/zsh/site-functions/_ndk-pkg exists?

One more thing, not really related to this issue, could you please help me set up the cmakelists.txt file to include the library in my project?
# For more information about using CMake with Android Studio, read the
# documentation: https://d.android.com/studio/projects/add-native-code.html

# Sets the minimum version of CMake required to build the native library.

cmake_minimum_required(VERSION 3.18.1)

# Declares and names the project.

project("nativecpuinfo")

# Creates and names a library, sets it as either STATIC
# or SHARED, and provides the relative paths to its source code.
# You can define multiple libraries, and CMake builds them for you.
# Gradle automatically packages shared libraries with your APK.

include(ndk-pkg.cmake)

add_library( # Sets the name of the library.
             nativecpuinfo

             # Sets the library as a shared library.
             SHARED

             # Provides a relative path to your source file(s).
        nativecpuinfo.cpp)

# Searches for a specified prebuilt library and stores the path as a
# variable. Because CMake includes system libraries in the search path by
# default, you only need to specify the name of the public NDK library
# you want to add. CMake verifies that the library exists before
# completing its build.

find_library( # Sets the name of the path variable.
              log-lib

              # Specifies the name of the NDK library that
              # you want CMake to locate.
              log )

# Specifies libraries CMake should link to your target library. You
# can link multiple libraries, such as libraries you define in this
# build script, prebuilt third-party libraries, or system libraries.

target_link_libraries( # Specifies the target library.
        nativecpuinfo

                       # Links the target library to the log library
                       # included in the NDK.
                       ${log-lib} )

find_package(cpuinfo)
if (cpuinfo_FOUND)
    target_include_directories(nativecpuinfo ${CPUINFO_INCLUDE_DIR})
    target_link_libraries     (nativecpuinfo ${CPUINFO_LIBRARY})
endif()

But when I try to build the project, I get the error:
C/C++: debug|armeabi-v7a :CMake Warning at /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android-legacy.toolchain.cmake:418 (message):
C/C++: debug|armeabi-v7a :  An old version of CMake is being used that cannot automatically detect
C/C++: debug|armeabi-v7a :  compiler attributes.  Compiler identification is being bypassed.  Some
C/C++: debug|armeabi-v7a :  values may be wrong or missing.  Update to CMake 3.19 or newer to use
C/C++: debug|armeabi-v7a :  CMake's built-in compiler identification.
C/C++: debug|armeabi-v7a :Call Stack (most recent call first):
C/C++: debug|armeabi-v7a :  /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android.toolchain.cmake:54 (include)
C/C++: debug|armeabi-v7a :  /Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/armeabi-v7a/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include)
C/C++: debug|armeabi-v7a :  CMakeLists.txt:10 (project)
C/C++: debug|armeabi-v7a :CMake Warning at CMakeLists.txt:52 (find_package):
C/C++: debug|armeabi-v7a :  By not providing "Findcpuinfo.cmake" in CMAKE_MODULE_PATH this project has
C/C++: debug|armeabi-v7a :  asked CMake to find a package configuration file provided by "cpuinfo", but
C/C++: debug|armeabi-v7a :  CMake did not find one.
C/C++: debug|armeabi-v7a :  Could not find a package configuration file provided by "cpuinfo" with any
C/C++: debug|armeabi-v7a :  of the following names:
C/C++: debug|armeabi-v7a :    cpuinfoConfig.cmake
C/C++: debug|armeabi-v7a :    cpuinfo-config.cmake
C/C++: debug|armeabi-v7a :  Add the installation prefix of "cpuinfo" to CMAKE_PREFIX_PATH or set
C/C++: debug|armeabi-v7a :  "cpuinfo_DIR" to a directory containing one of the above files.  If
C/C++: debug|armeabi-v7a :  "cpuinfo" provides a separate development package or SDK, be sure it has
C/C++: debug|armeabi-v7a :  been installed.
C/C++: debug|arm64-v8a :CMake Warning at /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android-legacy.toolchain.cmake:418 (message):
C/C++: debug|arm64-v8a :  An old version of CMake is being used that cannot automatically detect
C/C++: debug|arm64-v8a :  compiler attributes.  Compiler identification is being bypassed.  Some
C/C++: debug|arm64-v8a :  values may be wrong or missing.  Update to CMake 3.19 or newer to use
C/C++: debug|arm64-v8a :  CMake's built-in compiler identification.
C/C++: debug|arm64-v8a :Call Stack (most recent call first):
C/C++: debug|arm64-v8a :  /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android.toolchain.cmake:54 (include)
C/C++: debug|arm64-v8a :  /Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/arm64-v8a/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include)
C/C++: debug|arm64-v8a :  CMakeLists.txt:10 (project)
C/C++: debug|arm64-v8a :CMake Warning at CMakeLists.txt:52 (find_package):
C/C++: debug|arm64-v8a :  By not providing "Findcpuinfo.cmake" in CMAKE_MODULE_PATH this project has
C/C++: debug|arm64-v8a :  asked CMake to find a package configuration file provided by "cpuinfo", but
C/C++: debug|arm64-v8a :  CMake did not find one.
C/C++: debug|arm64-v8a :  Could not find a package configuration file provided by "cpuinfo" with any
C/C++: debug|arm64-v8a :  of the following names:
C/C++: debug|arm64-v8a :    cpuinfoConfig.cmake
C/C++: debug|arm64-v8a :    cpuinfo-config.cmake
C/C++: debug|arm64-v8a :  Add the installation prefix of "cpuinfo" to CMAKE_PREFIX_PATH or set
C/C++: debug|arm64-v8a :  "cpuinfo_DIR" to a directory containing one of the above files.  If
C/C++: debug|arm64-v8a :  "cpuinfo" provides a separate development package or SDK, be sure it has
C/C++: debug|arm64-v8a :  been installed.
C/C++: debug|x86 :CMake Warning at /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android-legacy.toolchain.cmake:418 (message):
C/C++: debug|x86 :  An old version of CMake is being used that cannot automatically detect
C/C++: debug|x86 :  compiler attributes.  Compiler identification is being bypassed.  Some
C/C++: debug|x86 :  values may be wrong or missing.  Update to CMake 3.19 or newer to use
C/C++: debug|x86 :  CMake's built-in compiler identification.
C/C++: debug|x86 :Call Stack (most recent call first):
C/C++: debug|x86 :  /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android.toolchain.cmake:54 (include)
C/C++: debug|x86 :  /Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/x86/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include)
C/C++: debug|x86 :  CMakeLists.txt:10 (project)
C/C++: debug|x86 :CMake Warning at CMakeLists.txt:52 (find_package):
C/C++: debug|x86 :  By not providing "Findcpuinfo.cmake" in CMAKE_MODULE_PATH this project has
C/C++: debug|x86 :  asked CMake to find a package configuration file provided by "cpuinfo", but
C/C++: debug|x86 :  CMake did not find one.
C/C++: debug|x86 :  Could not find a package configuration file provided by "cpuinfo" with any
C/C++: debug|x86 :  of the following names:
C/C++: debug|x86 :    cpuinfoConfig.cmake
C/C++: debug|x86 :    cpuinfo-config.cmake
C/C++: debug|x86 :  Add the installation prefix of "cpuinfo" to CMAKE_PREFIX_PATH or set
C/C++: debug|x86 :  "cpuinfo_DIR" to a directory containing one of the above files.  If
C/C++: debug|x86 :  "cpuinfo" provides a separate development package or SDK, be sure it has
C/C++: debug|x86 :  been installed.
C/C++: debug|x86_64 :CMake Warning at /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android-legacy.toolchain.cmake:418 (message):
C/C++: debug|x86_64 :  An old version of CMake is being used that cannot automatically detect
C/C++: debug|x86_64 :  compiler attributes.  Compiler identification is being bypassed.  Some
C/C++: debug|x86_64 :  values may be wrong or missing.  Update to CMake 3.19 or newer to use
C/C++: debug|x86_64 :  CMake's built-in compiler identification.
C/C++: debug|x86_64 :Call Stack (most recent call first):
C/C++: debug|x86_64 :  /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android.toolchain.cmake:54 (include)
C/C++: debug|x86_64 :  /Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/x86_64/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include)
C/C++: debug|x86_64 :  CMakeLists.txt:10 (project)
C/C++: debug|x86_64 :CMake Warning at CMakeLists.txt:52 (find_package):
C/C++: debug|x86_64 :  By not providing "Findcpuinfo.cmake" in CMAKE_MODULE_PATH this project has
C/C++: debug|x86_64 :  asked CMake to find a package configuration file provided by "cpuinfo", but
C/C++: debug|x86_64 :  CMake did not find one.
C/C++: debug|x86_64 :  Could not find a package configuration file provided by "cpuinfo" with any
C/C++: debug|x86_64 :  of the following names:
C/C++: debug|x86_64 :    cpuinfoConfig.cmake
C/C++: debug|x86_64 :    cpuinfo-config.cmake
C/C++: debug|x86_64 :  Add the installation prefix of "cpuinfo" to CMAKE_PREFIX_PATH or set
C/C++: debug|x86_64 :  "cpuinfo_DIR" to a directory containing one of the above files.  If
C/C++: debug|x86_64 :  "cpuinfo" provides a separate development package or SDK, be sure it has
C/C++: debug|x86_64 :  been installed.

regarding last question:
lukas@Lukass-MacBook-Air site-functions % pwd
/usr/local/share/zsh/site-functions
lukas@Lukass-MacBook-Air site-functions % ls -la
total 456
drwxr-xr-x  3 root  wheel      96 Jan 23 13:06 .
drwxr-xr-x  3 root  wheel      96 Jan 23 11:00 ..
-rw-r--r--  1 root  wheel  229648 Jan 23 13:06 _ndk-pkg

cpuinfo do not provide cpuinfo-config.cmake, I will patch it tomorrow.

Great thanks so much, let me know pls when it will be done

Yeah, you will be notified.

By the way, here is the pull request already submitted to cpuinfo https://github.com/pytorch/cpuinfo/pull/69#issue-1021933608

Thanks. I am thinking of how to generate these files by ndk-pkg when auto detected by ndk-pkg, I don't wanna patch  one by one. I find there are lots of projects do not provide cmake module config files.

Is it possible to generate it somehow? Or how do you make such file by hand? I think there should be a common ground.

@LukasAnda

run ndk-pkg upgrade @self to update ndk-pkg to latest.
run ndk-pkg uninstall cpuinfo
run ndk-pkg install cpuinfo

find_package(cpuinfo)
if (cpuinfo_FOUND)
    target_include_directories(nativecpuinfo ${CPUINFO_INCLUDE_DIR})
    target_link_libraries     (nativecpuinfo cpuinfo::libcpuinfo)
    target_link_libraries     (nativecpuinfo cpuinfo::libclog)
endif()

variables defined by cpuinfo package, examples:
CPUINFO_FOUND=TRUE

CPUINFO_GIT_REV=728f3e909fa5c57e0123c4658e234f6b1941385d

CPUINFO_DIR=/home/fpliu/.ndk-pkg/install.d/cpuinfo/x86/lib/cmake/cpuinfo

CPUINFO_INSTALL_DIR=/home/fpliu/.ndk-pkg/install.d/cpuinfo/x86
CPUINFO_INCLUDE_DIR=/home/fpliu/.ndk-pkg/install.d/cpuinfo/x86/include
CPUINFO_LIBRARY_DIR=/home/fpliu/.ndk-pkg/install.d/cpuinfo/x86/lib

CPUINFO_LIBRARY_COUNT=2

imported targets defined by cpuinfo package, examples:
target_link_libraries(nativecpuinfo cpuinfo::libcpuinfo)
target_link_libraries(nativecpuinfo cpuinfo::libclog)

The android gradle project can not resolve the CPUINFO_INCLUDE_DIR direcotry unfortunately :/ I am getting this error message:
[CXX1405] error when building with cmake using /Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/src/main/cpp/CMakeLists.txt: Build command failed.
Error while executing process /Users/lukas/Library/Android/sdk/cmake/3.18.1/bin/cmake with arguments {-H/Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/src/main/cpp -DCMAKE_SYSTEM_NAME=Android -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_SYSTEM_VERSION=21 -DANDROID_PLATFORM=android-21 -DANDROID_ABI=arm64-v8a -DCMAKE_ANDROID_ARCH_ABI=arm64-v8a -DANDROID_NDK=/Users/lukas/Library/Android/sdk/ndk/24.0.7956693 -DCMAKE_ANDROID_NDK=/Users/lukas/Library/Android/sdk/ndk/24.0.7956693 -DCMAKE_TOOLCHAIN_FILE=/Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android.toolchain.cmake -DCMAKE_MAKE_PROGRAM=/Users/lukas/Library/Android/sdk/cmake/3.18.1/bin/ninja -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/build/intermediates/cxx/Debug/6y2736mm/obj/arm64-v8a -DCMAKE_RUNTIME_OUTPUT_DIRECTORY=/Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/build/intermediates/cxx/Debug/6y2736mm/obj/arm64-v8a -DCMAKE_BUILD_TYPE=Debug -B/Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/arm64-v8a -GNinja}
-- NDK_PKG_HOME=/Users/lukas/.ndk-pkg
-- Configuring incomplete, errors occurred!
See also "/Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/arm64-v8a/CMakeFiles/CMakeOutput.log".

CMake Warning at /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android-legacy.toolchain.cmake:418 (message):
  An old version of CMake is being used that cannot automatically detect
  compiler attributes.  Compiler identification is being bypassed.  Some
  values may be wrong or missing.  Update to CMake 3.19 or newer to use
  CMake's built-in compiler identification.
Call Stack (most recent call first):
  /Users/lukas/Library/Android/sdk/ndk/24.0.7956693/build/cmake/android.toolchain.cmake:54 (include)
  /Users/lukas/Developer/MyProjects/device-stats-android/nativecpuinfo/.cxx/Debug/6y2736mm/arm64-v8a/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:10 (project)

CMake Error at CMakeLists.txt:54 (target_include_directories):
  target_include_directories called with invalid arguments
Affected Modules: nativecpuinfo

Okay, Fixed it by modifying gradle files a little bit and also for include dir I had to make it PUBLIC (not sure if PRIVATE) will work. I will post a link to my project with implementation if interested

Yes, I updated it and it works now, thanks :)


✨ [New Demo Request]: Create a Demo for CSS Counter Styles

Please include the request by answering these questions.
What is the Example and Demo Topic?
CSS Counter Styles
Please explain why do you need it?
CSS Counter Styles is almost a programmatic way to add a counter using CSS. We need to build awareness using this demo.
Any Links, Reads?
https://developer.mozilla.org/en-US/docs/Web/API/CSS_Counter_Styles
If you are picking up this request to implement, PLEASE READ THIS

HOW TO ADD A DEMO

Hi @atapas Is this done?? This is my first time participating in  Hacktoberfest and I will like to work on this if its still up for grab


Component.Life span of component in years is missing data type in resolved version of the model

 {
          "name": "DurationLifeYear",
          "attributeContext": "Component/attributeContext/Component/DurationLifeYear",
          "description": "Life span of component in years"
        },

This is all in the code. I would expect a DataFormat element there. In the online documentation is specified as Integer.

Hi Eric,
I just checked it and find the following:
{
"name": "DurationLifeYear",
"purpose": "hasA",
"dataFormat": "integer",
"description": "Life span of component in years"
},
This is how it looks like for me could you please point me to the exact location where you got this from?
Best


sync/atomic: disallow type conversions of atomic.Pointer[T]

Fixes #56603

There was some issue with github, I posted this PR like an hour ago, but it shows that I posted it around now.


Isolated regions / Per Container IP - impact on marathon API

Hi,
I was reading this doc. about "Per-Container IP" and related with #3744
https://docs.google.com/document/d/17mXtAmdAXcNBwp_JfrxmZcQrs7EO6ancSbejrqjLQ0g/edit
It'd be really useful add to the API something like this to manage the described feature
10 Impact on Marathon API
It will be needed new endpoints in the Marathon API  (an approach)
v3/users/                 [GET|PUT|POST]
v3/users/{userId}               [GET|PUT|DELETE]
v3/users/{userId}/regions/        [GET|DELETE]
v3/users/{userId}/regions/apps/     [GET|DELETE]
v3/users/{userId}/regions/groups/       [GET|DELETE]
v3/regions/                 [GET|PUT|POST]
v3/regions/{regionId}               [GET|PUT|DELETE]
v3/regions/{regionId}/apps/        [GET|DELETE]
v3/regions/{regionId}/groups/         [GET|DELETE]
What do you mean about it? Is there similar feature described in other issue?
I didn't find something like this....

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2098. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


cloud

Bug: WOfS appears to be ignoring one of the two cloud detection algorithms.
PQ sets bits 10 and 11 (counting from zero) according to the output of the ACCA and FMASK algorithms. Currently WOfS grabs this pair of bits, takes the logical inverse, and dilates:
dilate(logical_not(PQ & 3072))
The problem is the logic. While WOfS sets its cloud bit to true where there is cloud, PQ has it as false where there is cloud (more like a cloudfree bit). Therefore, WOfS is only flagging where cloud is detected by both algorithms. (That is, when "neither cloudfree". Note for PQ, 0=cloudy-as, 1024-2048=disputed, 3072=clear-consensus.) If FMASK is more conservative than ACCA, it will seem like WOfS is only considering ACCA.
To instead adopt the intended conservative stance ("not both clear" flag, grouping 1024-2048 with 0 rather than with 3072), an appropriate algorithm is:
dilate(PQ & 3072 != 3072)
Alternatively, if science thinks the cloud masking is excessively conservative, then the specifications could be adjusted to explicitly prefer the optimistic approach of the current implementation.

Another option:
dilate(invert(PQ) & 3072)

Presumably also applies for cloud shadow.


Typo in help text.

https://github.com/Ventto/mons/blob/921d99dcb46c4a9d6f8fbb79ccbc41cdb4d8fdfe/mons#L54
"wuth an id"

Thanks @victorz. Sharp eye !


Add build for python packages on Windows

Added build for python packages on Windows and merged it with macos and ubuntu builds.

@sergregory please, take a look.


ENH: Adds sort_values to dask.DataFrame

[X] Closes https://github.com/dask/dask/issues/958
[X] Tests added / passed
[X] Passes black dask / flake8 dask. Running black on core.py and shuffle.py caused large diffs - maybe I have something misconfigured?

As suggested https://github.com/dask/dask/issues/958#issuecomment-573121520 and https://github.com/dask/dask/pull/2367, I've pretty much reused the code in set_index and don't mess with the underlying bits. Shared code between set_index and sort_values is in _calculate_divisions.
Implementation caveats:

only single column sorting is supported
only ascending=True is supported

Closes https://github.com/dask/dask/issues/958

@jsignell I think this is good to go, let me know if there are changes I should make.

This should be in a better state now - thanks for catching those oversights.

cc @rjzamora (in case this if of interest 🙂)

cc @rjzamora (in case this if of interest 🙂)

Seems like the logical way to handle single-column sort_values - Thanks for this @gerrymanoim!
Dask-CuDF actually does the same exact thing to support both single- and multi-column sort_values.  However, this is only possible with cudf, because the divisions calculation stage is performed with cudf.DataFrame.quantiles (which returns a single quantile column for the entire dataframe input, rather than independent quatiles for each column).

which returns a single quantile column for the entire dataframe input, rather than independent quatiles for each column

Ah that would be a nice extension.

Thanks for the PR @gerrymanoim!


Does Dynamic provisioning support to change permission by securityContext

@wutz A little bit confused! Could you supply more details of this question? Securtiy Context is applied for Pod or Container, which affect the processes access the filesyste, dynamic provisioning is the process the CSI driver provisioning storage.

I use pvc which by juicefs storageclass to run pod as non root user by set securtiyContext { runAsNonRoot: true, runAsUser: 1000, fsGroup: 3000} , but got write permission denied.
Then i test to use custom pv to run pod as non root user, it work correctly.

I noticed that the examples are all about modifying mount-optinons and Permissions for static provisioning, but there is no mention of how to modify the above configuration for dynamic provisioning.

I noticed that the examples are all about modifying mount-optinons and Permissions for static provisioning, but there is no mention of how to modify the above configuration for dynamic provisioning.

Thanks to feedback this, we'll try to reproduce this problem.
The StorageClass also support mount options,  we'll verify if it works.


Move graal from experimental to main.

We got some feedback that this approach works and we can remove experimental!
Signed-off-by: Dan Lorenc<EMAIL_ADDRESS>

Thank you! I'm releasing v1.2.0 for korandoru/hawkeye, whose Native Image Docker image is based on this image. Its usage is verified on my projects that use it.

Does this PR mean that we can use a stable tag rather than latest to refer the image now?

Does this PR mean that we can use a stable tag rather than latest to refer the image now?

Normally it would, but there's not really anything in this image for us to anchor the versioning off of (for example, with Python we'd generate a stable tag for something like 3.11.1). For this image it's just glibc and a few other packages, so we don't have something to anchor the tag to.
If there's a specific tagging scheme you'd like to see here we can definitely work it in!

@dlorenc That's reasonable. Then I'll keep the current way unless we find something needs a tag different than latest. I may expect nothing will be changed in this image except version bump of glibc, libz, etc. to make to work with latest GraalVM.

Thanks, that's our intention here too!


MAINT: switching to setuptools as the building tool

Please do "Squash and merge" while merging this PR
This PR switches the nx-parallel's building tool from hatchling to setuptools as it is more widely used and it's better for bigger projects and we need to explicitly mention all the packages(unlike hatchling) so that ensures that all packages are being built.
I didn't add any extra ruff or lint settings. But, the style wf test was failing in github wf so in the last commit in this PR are all the pre-commit changes. I think it is a result of switching from hatchling to setuptools.
moved select, pre-file-ignores under tool.ruff.lint section due to the following warning:
warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'select' -> 'lint.select'
  - 'per-file-ignores' -> 'lint.per-file-ignores'

The changes to pyproject.toml look like this better matches networkx. The import changes and package names all look good. Perhaps @jarrodmillman or @MridulS can look at the setuptools settings to make sure they make sense.
Can you add a few sentences to the PR's first post describing what you did? (use the "Edit" option under the 3-dots at the upper right of that first post.) That way reviewers don't have to click somewhere else to figure out what this PR is about.
Just some very basic info (not all has to be there and more obviously can be there):  for example:
What?
Why?
How?
Testing?
(example from https://www.pullrequest.com/blog/writing-a-great-pull-request-description/)
For most PRs I look for "What" and "Why" in the description.  Jarrod has the release process set up so the title gets added to the release notes (I believe), so that's important too. (As a reviewer I try to remember to update the title before merging to make it helpful for the release notes.)

The pyproject.toml file has all the "real" changes and all other files have linting changes. And all the linting modifications are in the order of the import statements. I think this was a result of switching to setuptools because the only new linting specification I added was:
[tool.ruff.format]
docstring-code-format = true

and this is for the styling of docstrings.

it would also allow us to keep the blame clean by ignoring the formatting-only changes!

I think this seems reasonable but idk what would be a quick way to revert these automated changes in this PR. So, I'll make a new PR that changes the pyproject.toml, and then after merging that PR, I'll rebase this PR's branch and then we can merge this. I hope that would be ok. LMK what you think.


[Fix #7167] Fix an error for Naming/RescuedExceptionsVariableName

Fixes #7167.
This PR fixes an auto-correct error for Naming/RescuedExceptionsVariableName when rescue without exception variable after rescue with a exception variable
# example.rb
def foo
rescue => ex
end

def bar
rescue
end

% rubocop -a --only Naming/RescuedExceptionsVariableName
Inspecting 1 file

0 files inspected, no offenses detected
undefined method `loc' for nil:NilClass
/Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-0.71.0/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb:102:in
`lo
cation'
/Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-0.71.0/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb:98:in
`var
iable_name'
/Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-0.71.0/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb:94:in
`pre
ferred_name'
/Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-0.71.0/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb:73:in
`blo
ck in autocorrect'
/Users/koic/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rubocop-0.71.0/lib/rubocop/cop/corrector.rb:64:in
`block (2 levels) in rewrite'

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I guess #7122 will solve the problem.

I get it. Thanks for your information.


CT: UnivariatePolynomial: x^3 + 10x^2 + 169x failed

dot is failing unit tests.  This has been occurring on every iteration since CT was restarted on 9/15/23 @ 1:26:30pm.
dot : top-level-unit-tests : unbuilt
http://<IP_ADDRESS>/continuous-testing/ct-snapshots/1695140008322/dot/dot-tests.html
104 out of 105 tests passed. 1 failed.
UnivariatePolynomial: x^3 + 10x^2 + 169x failed:
first root
at Object.<anonymous> (http://<IP_ADDRESS>/continuous-testing/ct-snapshots/1695140008322/chipper/dist/js/dot/js/UnivariatePolynomialTests.js:35:10)

UnivariatePolynomial: x^3 + 10x^2 + 169x failed:
second root
at Object.<anonymous> (http://<IP_ADDRESS>/continuous-testing/ct-snapshots/1695140008322/chipper/dist/js/dot/js/UnivariatePolynomialTests.js:36:10)

[URL] http://<IP_ADDRESS>/continuous-testing/aqua/html/qunit-test.html?url=..%2F..%2Fct-snapshots%2F1695140008322%2Fdot%2Fdot-tests.html&testInfo=%7B%22test%22%3A%5B%22dot%22%2C%22top-level-unit-tests%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1695140008322%22%2C%22timestamp%22%3A1695140710058%7D
[NAVIGATED] http://<IP_ADDRESS>/continuous-testing/aqua/html/qunit-test.html?url=..%2F..%2Fct-snapshots%2F1695140008322%2Fdot%2Fdot-tests.html&testInfo=%7B%22test%22%3A%5B%22dot%22%2C%22top-level-unit-tests%22%2C%22unbuilt%22%5D%2C%22snapshotName%22%3A%22snapshot-1695140008322%22%2C%22timestamp%22%3A1695140710058%7D
[NAVIGATED] about:blank
[NAVIGATED] http://<IP_ADDRESS>/continuous-testing/ct-snapshots/1695140008322/dot/dot-tests.html
[CONSOLE] Failed to load resource: the server responded with a status of 404 (Not Found): http://<IP_ADDRESS>/continuous-testing/ct-snapshots/1695140008322/dot/dot-strings_en.json

id: "Sparky Node Puppeteer"
Snapshot from 9/19/2023, 10:13:28 AM

I'll work on this.

The test was failing because of a copy/paste error in the assertions, I corrected it to the actual roots and it is passing locally.  I also fixed a typo in documentation in a related file.  Closing.


Add Colton freeman's file

created a branch, created a file and made a commit, and opened a pull request

some some

alright


29 paired block bloom filter algorithm

I have pushed (force) the branch:

rebased on latest origin/main and resolved conflicts.
Squashed all commits into one


[KYUUBI #2569]Change the acquisition method of flinkHome to keep it consistent with other engines

Why are the changes needed?

fix #2569
How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #2570 (1523d43) into master (1932ad7) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2570      +/-   ##
============================================
- Coverage     63.86%   63.73%   -0.14%
  Complexity       73       73
============================================
  Files           376      377       +1
  Lines         17956    18098     +142
  Branches       2405     2443      +38
============================================
+ Hits          11468    11534      +66
- Misses         5415     5466      +51
- Partials       1073     1098      +25

Impacted Files
Coverage Δ

...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala
95.12% <100.00%> (+3.89%)
:arrow_up:

...apache/kyuubi/engine/hive/HiveProcessBuilder.scala
84.61% <100.00%> (ø)

...rg/apache/kyuubi/engine/trino/TrinoStatement.scala
66.66% <0.00%> (-2.30%)
:arrow_down:

.../engine/spark/session/SparkSQLSessionManager.scala
79.76% <0.00%> (-1.20%)
:arrow_down:

.../apache/kyuubi/server/api/v1/BatchesResource.scala
90.19% <0.00%> (ø)

...apache/kyuubi/server/api/v1/SessionsResource.scala
71.21% <0.00%> (ø)

...ache/kyuubi/server/api/v1/OperationsResource.scala
67.46% <0.00%> (ø)

...kyuubi/server/api/SwaggerScalaModelConverter.scala
51.26% <0.00%> (ø)

...ache/kyuubi/operation/KyuubiOperationManager.scala
85.24% <0.00%> (+1.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1932ad7...1523d43. Read the comment docs.


Fix: GPR curation for Sulfur metabolism

Main improvements in this PR:
As proposed in #892

Remove ENSG00000104331 from MAR04187;
Remove ENSG00000108602 from MAR04842;
Remove ENSG00000204386 from MAR07530;
Remove ENSG00000204386 from MAR07542;
Remove ENSG00000204386 from MAR07560;
Remove ENSG00000204386 from MAR07526;
Remove ENSG00000204386 from MAR07547;
Remove ENSG00000135702 from MAR07369;
Remove ENSG00000106304 from MAR07503.

I hereby confirm that I have:

[X] Tested my code on my own computer for running the model
[X] Selected develop as a target branch
[ ] Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

LGTM!


Fields props on v3.0.0-beta-2

Hello! I've updated the project I'm working on currently to 3.0.0-beta-2. One issue I'm facing is that I can't rely no more on props passed to my decorated component to know if the input should be rendered.
shouldComponentUpdate(nextProps) {
    return nextProps.field.error !== this.props.field.error;
}

Even if the error attribute did change, logging both nextProps.field.error and this.props.field.error have the same value, so the input isn't rendered and the error isn't show.
This is a changed in 3.0? The above code used to work on 2.4.5.
Thanks for you time and for this great library :)

I wrote the issue while I was in hurry, so I will add some more details that can help to understand better the problem.
This is my form component's render method:
        let { fields: { from, to, subject, content }, handleSubmit } = this.props;

        return (
            <form onSubmit={handleSubmit}'>
                <FormInput label='From' field={from} />
                ...
           </form>
         );

FormInput is just a widget that render an input, and the shouldComponentUpdate method I wrote in the original issue is part of it.

I don't understand. You say the error changed but is also ===? Is the error returned by validation different between the two renders?
With v3, you really shouldn't need to have a shouldComponentUpdate() like this, because the field value should be === to the previous one unless one of the field's property changes (this was not the case in v2.4.5). This was one of the major goals of v3.

Yep, on the first render both nextProps.field.error and this.props.field.error are undefined, then I write some invalid value and on the next render both values contain the string reporting the error. On 2.4.5 instead after I wrote an invalid valuethis.props.field.error was undefined while nextProps.field.error contained the error string, so the widget re-render only in that case. It's very strange.
If i comment out the shouldComponentUpdate method all the widgets re-render themself even if I just blur one field.
Maybe I'm doing something wrong? I just used the new reduxForm method to connect my form component to the redux store, there are some other steps to updgrade from 2.4.5. to 3.0? Thank you.

OHHH, I understand the problem now! This is a bug. Thank you!
I need to generate a new copy of the field object if any of its properties change.

Ahh, now it's clear, this.props and nextprops are the same object! Glad
that it helped!
On Wed, 28 Oct 2015 22:37 Erik Rasmussen<EMAIL_ADDRESS>wrote:

OHHH, I understand the problem now! This is a bug. Thank you!
I need to generate a new copy of the field object if any of its properties
change.
—
Reply to this email directly or view it on GitHub
https://github.com/erikras/redux-form/issues/182#issuecomment-152001164.

Released fix under v3.0.0-beta-3.

Thanks for the fast fix, I will try it tomorrow! :)
On 28 Oct 2015 23:01, "Erik Rasmussen"<EMAIL_ADDRESS>wrote:

Released fix under v3.0.0-beta-3
https://github.com/erikras/redux-form/releases/tag/v3.0.0-beta-3.
—
Reply to this email directly or view it on GitHub
https://github.com/erikras/redux-form/issues/182#issuecomment-152010173.

Just to report that everything is back to a working status, I changed the shouldComponentUpdate method to just do a shallow comparison between this.props and nextProps, simplifying the code.
Nice job with 3.0!

I'm almost certain this is still an issue with nested fields (such as the shipping fields in http://redux-form.com/4.2.0/#/examples/deep?_k=n2ytkg). The value of such fields in this.props are the same as in nextProps, which means the objects are probably mutated. @erikras if you are not aware of the issue (or can't spot it), I can post a fiddle.


Update allow-users-to-change-passwords.md

Proposing these changes to make this chapter more congruent with the core chapters of the guide.
Also, I have a replacement screenshot for the settings page with both the billing form and the change email/password buttons. Please see my comment for the screen shot.

Please see attached screen shot for the settings page with both the billing form and the change email/password buttons.

Hmm this one is a bit of a bigger change, since we need to change the attached repos as well. I think for now it might be better to add a note in this chapter saying that we are using a blank settings page instead of the existing one?


update all of the packages that are easyish

webpack still at v3, typescript at v2 still.

@jSylvestre no rush but if you could run this locally and just make sure it works that would be awesome, just to have another computer try it out.  Make sure to run an install to get the new dependencies (I think VS might do that automatically for you, not sure)

@srkirkland 👍 But you currently have merge conflicts


[Improvement] Make the menu items customizable

The menu bars currently read:

Posts
Tags
and are not customizable unless through editing the hbs file. Is there a way to make these customizable? I would rather use "Categories" instead of "Tags".

In case you are busy, I will also work on these issues I opened when I have the time and open pull request.

The menu bar cannot be edited through Ghost since it's not really a menu. The links don't go to a new page, but rather a new tab. And they're called Tags on Ghost (tags.hbs), so that's why they're called Tags here.


Data Engine: Get datapoint via its path

Right now there's no "neat" way to get a datapoint if you know its path, even though we can do query filtering by path.
Suggested syntax:
dp = ds.get_datapoint("file.jpg")

Good day! Actually this would be my first open source contribution to a repository, but I wish to understand the context in which I'd have to make changes. Moreover, without a CONTRIBUTING.md file it's hard for me to reproduce the project on my local system, could I get some guidance on the process?

Hey @harshaljanjani, thanks for reaching out with this.
I think we should have labeled it as an advanced issue and not a good first one, as it requires some knowledge of the DagsHub platform.
If you wish to get to know how this functionality is used, here are the relevant resources:

Set up DagsHub
Use DagsHub Data Engine

Hello @kbolashev, please assign this issue to me as I have already worked on this kind of problem in past and has a great experience.


Rename client/server install flags.

Use minio namespace.
Use positive bool flag to avoid confusing double negative.

LGTM


"scopeUnverified" returns Call to an undefined method \HasMany::verified() in Larastan

Larastan Version: 1.0.2
--level used: 5

Description
I am working with Larastan; at the moment, I am facing a little problem: Larastan throws out the following error:
  137    Call to an undefined method Illuminate\Database\Eloquent\Relations\HasMany::verified().

Alright, so I had a look at it.
I defined a scope like this:
 /**
     * @param $query
     *
     * @return mixed
     */
    public function scopeVerified($query): mixed
    {
        return $query->where('verified', 1);
    }

This is the relation:

/**
 * @return HasMany
 */
public function images(): HasMany
{
    return $this->hasMany(Image::class);
}

Laravel code where the issue was found
$verified_images = $images->verified()->count();

Hi,
Your docblock for the images method is the problem.
You can update it to @return HasMany<Image> or you can remove it, and Larastan can handle it.

Hm, this did not help in this case.
Is it important to know that
$verified_images = $images->verified()->count();

is being called in a Trait and the scope is defined in the Images-model?

How is the $images variable initialized?

I just got the problem:
The method where $verified_images = $images->verified()->count(); was called, also got a docblock. As the method received the $images-var with a declaration of HasMany $images as @param in the docblock, I needed to replace it with @param HasMany<Image> $images.
Thanks for your help - I would not have figured it out without your hint :-)


STAR: Update config to read from export SFTP box instead of vendor

Who is this PR for?
New Bedford MS educators
What problem does this PR fix?
IT pals in New Bedford are having issues with the STAR setup, either upstream or in working with other vendors.  They wanted to work around, so replicated the STAR export themselves.
What does this PR do?
Parameterizes the StarImporter classes with methods for getting different clients, and reading config from different places.  The New Bedford setup uses this to connect to the SFTP export box rather than STAR directly, and reads the config (which is more sensitive) from DistrictConfigLog instead of yaml in source.
Checklists
Which features or pages does this PR touch?

[x] STAR importers

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

[x] Included specs for changes
[x] Manual testing made more sense here

selfie


Add community and contribute pages

PR Checklist
Please review the guidelines for contributing to this repository.

[x] I am requesting to pull a topic/feature/bugfix branch (right side). In other words, not master.
[x] I have run npm test against my changes and tests pass.
[x] I have added or edited necessary documentation, or no docs changes are needed.

Description
This adds the new community and contribute pages.
The community page is probably the page with the most going on in the gatsby site, but all of the work is done at build time to keep page load as fast as possible. Twitter still loads JS to render the embedded tweets, which probably takes even longer than loading the YouTube video. Fortunately, that all happens below the fold.
The page makes use of four gatsby plugins to source four different APIs:

gatsby-source-rss-feed: for sourcing forum posts from the forum's rss feed
gatsby-source-graphql: for hooking up the GitHub API for both listing repositories on the community page and issues on the contribute page
gatsby-source-youtube-v3: for pulling the 12 most recent youtube videos. Only the latest video is loaded on the page to help page load time, but all of the links are available next to the video.
gatsby-source-twitter: pulls the 3 most recent tweets from @spokestack, then pulls embed code from the twitter API. This also makes use of gatsby-plugin-twitter, which we were already using on the blog to add Twitter's embed JS and make the embed code look like a tweet.

These sources required adding five new environment variables: one for the GitHub API, one for the Google API, and three for the Twitter API. env files have been updated in 1Password and on CircleCI.

I'll go ahead and merge for review on beta


Not possible to set editorial_mode to simple

Describe the bug
I normally have publish_mode set to "editorial_workflow", but for local editing I've set up a file-system API. I'm using the CMS_ENV variable  in cms.js to provide config overrides during development, and thus I needed to unset the editorial_workflow. I tried setting publish_mode: null and undefined, found that the default was simple in the source code, but neither works.
To Reproduce

in config.yml, add a line publish_mode: simple.
refresh the admin page

Expected behavior
Admin should run without editorial workflow enabled. Instead, the following error is shown:
Config Errors:
'publish_mode' should be equal to one of the allowed values
Check your config.yml file.

@bjrn did you try to remove the line or comment. Not saying that should be the solution, just want to make sure there is a workaround for now.

You mean in the config.yml? Yes, if I don't want editorial_workflow, it works fine if I simply do not add a publish_mode: line in config.yml … so there's definitely a workaround (my use case is probably rather uncommon).
If you mean commenting the line out in configSchema.js, no I haven't yet, but will have a go.
Also, in a related note (as I started out trying to override this way instead CMS_ENV), it seems as if there might be a race condition when one wants to provide custom config during the initialisation (eg. passing in the config object in cms.js); if I already have a file located at admin/config.yml, it uses that for initialisation, prior to reading my config block, thus ignoring what I pass in. Haven't spend any time debugging it yet though

@bjrn looks like you're right on - the publish_mode should allow simple as a value, and adding 'simple' to that schema is the correct fix (just double-checked). Creating a PR now.

Ah hah! I've just hit this!
Note that (I think) it's a much bigger problem if you're using manual initialisation. If I leave publish_mode undefined in both the config.yml and the init code, then it shouts at me with that error.


Testnet stuck with 8/10 validators online and on the latest wallet version

🐛 Bug
We're already 4 days on block 244,322 with 8 validators connected (v2.1.x) and view=0.

Looks like in pre_commit some validator rejects block. Validate 7 approvals, Pre-commit 6 approvals. Also i see some "On new_view" messages in the log, but it actually never changes and looks like turn never goes to the next validator.

Test network was fixed on 22 October.
Block 244,322 (08 October) https://testnet.semux.info/explorer/block/244322
Block 244,323 (22 October) https://testnet.semux.info/explorer/block/244323
That block also included one 2 weeks old transaction.
Before Testnet got unstuck, validators were voting for 2 competing chains with the different block hashes:
VALIDATE cd70342c6c23e34db9d5a6729973bf9ac5858f5f270bfc9df7efe8363c95c1e5
VALIDATE cd70342c6c23e34db9d5a6729973bf9ac5858f5f270bfc9df7efe8363c95c1e5
VALIDATE cd70342c6c23e34db9d5a6729973bf9ac5858f5f270bfc9df7efe8363c95c1e5
VALIDATE cd70342c6c23e34db9d5a6729973bf9ac5858f5f270bfc9df7efe8363c95c1e5
PRECOMMIT df67715085c9d1a728d8de7a74a9e505e8420cee1a680793634d65e17eb21832
PRECOMMIT df67715085c9d1a728d8de7a74a9e505e8420cee1a680793634d65e17eb21832
VALIDATE df67715085c9d1a728d8de7a74a9e505e8420cee1a680793634d65e17eb21832
VALIDATE df67715085c9d1a728d8de7a74a9e505e8420cee1a680793634d65e17eb21832

Also, while the primary validator was testgost111, all the further turns within 2 weeks took backup validator semux02 and he never passed the turn, neither increased the view within 2 weeks.

I think we should destroy the testnet for now:

There isn't much activity on testnet and developers can use mainnet for testing purpose with trivial cost
As a core developer, we should test new features with repeatable integration tests (full CI/CD for faster iteration)

And we can alway come back if a strong demand arises.


unable to change states on resize

I have the following playground app
var app = new PLAYGROUND.Application({

 ....
  ready() {
    /* after preloading route events to the game state */
    this.setState(ENGINE.Game)
    this.loaded = true
  },
  enterstate(){
    console.log('enter state', arguments[0].state.name);
  },
  leavestate(){
    console.log('leave state', arguments[0].state.name);
  },
  resize() {
    if(!this.loaded) return
    else if((this.width < 1024) && (this.height > this.width)) {
      if(this.states.current.pause != undefined) this.states.current.pause = true

      this.setState(ENGINE.Orientation)
    } else if(this.states.current.name && this.states.current.name == 'Orientation'){
      if(!ENGINE.currentState) ENGINE.currentState = ENGINE.states[0]

      this.setState(ENGINE[ENGINE.currentState])
    }
  }
})

when the device orientation has changed to portrait mode a state defined as "orientation" is set. When the orientation changes back the state is changed back to another state.
The problem I am having is that the "orientation" state does not seem to "leave"( visually) even though the other state that was set has been entered into and rendering

Apparently when resizing transitions are not preformed properly causing it to stick.....I think


Problem with ArduinoIDE 2.0.0 on Windows11

I get warnings( errors) from the compiler from tag totalPolls and can not download to the ESP32-WROOM-DA Module
In Win10 this is just Warnings. If I use Arduino program 1.8.19 (not IDE) with Win11 then I can download the file.
I used the example InterruptButtonExample.ino. The problem seems to were Win11 with ArduinoIDE.
cc1plus.exe: some warnings being treated as errors in Win11
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp: In static member function 'static void InterruptButton::readButton(void*)':
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:130:12: warning: '++' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
130 |       btn->m_totalPolls++;                                      // Count the number of total reads
|       ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:131:66: warning: '++' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
131 |       if(gpio_get_level(btn->m_pin) == btn->m_pressedState) btn->m_validPolls++; // Count the number of valid 'PRESSED' reads
|                                                             ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:164:12: warning: '++' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
164 |       btn->m_totalPolls++;
|       ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:166:14: warning: '++' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
166 |         btn->m_validPolls++;
|         ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:173:16: warning: '--' expression of 'volatile'-qualified type is deprecated [-Wvolatile]
173 |           btn->m_validPolls--;
|           ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp: At global scope:
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:17:20: error: 'TAG' defined but not used [-Werror=unused-variable]
17 | static const char* TAG = "IBTN";              // IDF log tag
|                    ^~~
cc1plus.exe: some warnings being treated as errors

Ahh, good find.  I will add to my to-do list.    Thanks for taking the time share the feedback.
On Mon, 19 Feb 2024, 8:51 am pallik49, @.***> wrote:

I get warnings( errors) from the compiler from tag totalPolls and can not
download to the ESP32-WROOM-DA Module
In Win10 this is just Warnings. If I use Arduino program 1.8.19 (not IDE)
with Win11 then I can download the file.
I used the example InterruptButtonExample.ino. The problem seems to were
Win11 with ArduinoIDE.
cc1plus.exe: some warnings being treated as errors in Win11
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp: In
static member function 'static void InterruptButton::readButton(void*)':
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:130:12:
warning: '++' expression of 'volatile'-qualified type is deprecated
[-Wvolatile]
130 | btn->m_totalPolls++; // Count the number of total reads
| ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:131:66:
warning: '++' expression of 'volatile'-qualified type is deprecated
[-Wvolatile]
131 | if(gpio_get_level(btn->m_pin) == btn->m_pressedState)
btn->m_validPolls++; // Count the number of valid 'PRESSED' reads
| ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:164:12:
warning: '++' expression of 'volatile'-qualified type is deprecated
[-Wvolatile]
164 | btn->m_totalPolls++;
| ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:166:14:
warning: '++' expression of 'volatile'-qualified type is deprecated
[-Wvolatile]
166 | btn->m_validPolls++;
| ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:173:16:
warning: '--' expression of 'volatile'-qualified type is deprecated
[-Wvolatile]
173 | btn->m_validPolls--;
| ~^~~~~~~~
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp: At
global scope:
e:_Arduino_2024\Heima\libraries\InterruptButton\InterruptButton.cpp:17:20:
error: 'TAG' defined but not used [-Werror=unused-variable]
17 | static const char* TAG = "IBTN"; // IDF log tag
| ^~~
cc1plus.exe: some warnings being treated as errors
—
Reply to this email directly, view it on GitHub
https://github.com/rwmingis/InterruptButton/issues/28, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALW24E325B3PJLEA42QJKBDYUJZWJAVCNFSM6AAAAABDOO6MK2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DCMRQGEYTAOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Improve the mobile responsiveness of the website.

Go ahead @abitsalihu

Hey @vijayyprajapati, I noticed that the website is actually pretty responsive, is there any part in particular that isn't that I can work on? The only non responsive part I could find was the text Click here to see  Contribution Guidelines.

You need to fix that only.


[BUG] go vet fails with undeclared name error

Describe the bug
A clear and concise description of what the bug is.
go vet throws following error when run in the root directory of source code.
whereabouts$ go vet ./...
# github.com/k8snetworkplumbingwg/whereabouts/pkg/controlloop
vet: pkg/controlloop/pod_controller_test.go:72:10: undeclared name: podSpec

Expected behavior
A clear and concise description of what you expected to happen.
go vet should throw no error
To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/k8snetworkplumbingwg/whereabouts
Run go vet ./...

Environment:

Skipping it as it is not a functional error

Additional info / context
Add any other information / context about the problem here.

go version go1.18 linux/amd64

You just have to pass the test tags via CLI - go vet --tags=test ./... , as our CI is doing.

You just have to pass the test tags via CLI - go vet --tags=test ./... , as our CI is doing.

But shouldn't all the test related files have +build test tag ? :thinking:

the tests ? Why would you put the tests in a binary ?

Actually pod_control_test.go requires podSpec here
https://github.com/k8snetworkplumbingwg/whereabouts/blob/acddfd52abb3da37b4403cecaed53bd21ef6a0c3/pkg/controlloop/pod_controller_test.go#L72
This is defined in entity_generator.go here
https://github.com/k8snetworkplumbingwg/whereabouts/blob/acddfd52abb3da37b4403cecaed53bd21ef6a0c3/pkg/controlloop/entity_generators.go#L53-L60
But entity_generator.go has build flags
https://github.com/k8snetworkplumbingwg/whereabouts/blob/acddfd52abb3da37b4403cecaed53bd21ef6a0c3/pkg/controlloop/entity_generators.go#L1-L3
Because of this the issue happens.

You just have to pass the test tags via CLI - go vet --tags=test ./... , as our CI is doing.

But shouldn't all the test related files have +build test tag ? thinking

I suggested this because I think pod_control_test.go should not be included in the binary until and unless test tag is present.
@maiqueb What do you think ? ^^

I think I don't understand what you mean; pod_control_test.go - along with anything not reachable from the main entrypoint of either the pod controller or the CNI plugin - will not be present in the binary, hence, there is no need to tag it.

Continuing from the call, yes I agree it will be better to remove the tags from the files which don't require tags :)
I was just concern that all the go vet with and without tag should pass independently (all the dependent files should either have tags or don't i.e. kind of independent sets ) :)


ctd when importing tileset without project path set

since config file was in extensions folder, when it was updated, the script was interrupted. if the script is interrupted with a qt dialog open, it ctds


bug fix for write_distributed_data

This fix should correct the bug I was chasing yesterday that caused me to start the discussion topic #493.   The previous version was not handling dead data correctly and was failing when the database routine _save_sample_data was referencing a null matrix write_distributed_data was creating due to a mistake in the logic of handling dead data.
I tested most of this code by hacking the container and resolving the problem with the parallel workflow.  I did not change the test script for distributed.py to test this condition.   We should do that later.  To get this fixed I plan to verify it recreates the successful run on a part of the 2012 usarray data set using the volatile container this pull request will create.  I'll leave a note in this pull request when I've verified that.  Before that, however, be aware I didn't even do a syntax check on this so there could be dumb errors.  Point is do nothing until I give a green light.

Green light to merge this with master.   Fixed the problem I was having with write_distributed_data.