Error on opening file via FileDialog

When opening selected file via FileDialog, I got

Error: thirdparty/Slab/Internal/Core/FileSystem.lua:277: /usr/lib/libluajit-5.1.so.2: undefined symbol: stat64
stack traceback:
[string "boot.lua"]:777: in function <[string "boot.lua"]:773>
[C]: in function '__index'
thirdparty/Slab/Internal/Core/FileSystem.lua:277: in function 'IsDirectory'
thirdparty/Slab/Internal/UI/Dialog.lua:564: in function 'FileDialog'
main.lua:87: in function 'AddFilepathDialog'
main.lua:57: in function 'update'
[string "boot.lua"]:612: in function <[string "boot.lua"]:594>
[C]: in function 'xpcall'

I invoked FileDialog these way:

local result = Slab.FileDialog({ Type = "openfile" })

My system: ArchLinux, updated yesterday.
What's interesting (and confusing) yesterday it worked fine. The only difference was update Slab in my project from version of ~21.07.2020 but I cannot find in commit logs any substantial changes, that could do that.
Maybe using FFI on Linux is not so good idea?
Edit:
To work on with my project, I forked Slab and do a workaround using love api:
https://github.com/pirogronian/Slab/commit/9ecb1c86bcdd6d40f03d4f5898496b8d7b805c31

Hi @pirogronian, thanks for reporting this issue and providing a work around. I'll take a look and include this fix in a patch release.

By the way, as Slab is written for LOVE, why not to use LOVE API, instead of using standard Lua packages and even external libs? I think it would make things much simpler and make mobiles support much easier.

Do you mean the usage of ffi? There are restrictions to some löve api where ffi could be used as it can provide for power and functionality.

Well, if love api is insufficient, then there is no choice than use something different. But I'd use it as really last choice. Custom integration with backends means lots of checking. If I wouldnt be skilled enough, I'd drop Slab already for something more reliable. Even now I see my workaround as kind of dirty hack.

Hi @pirogronian, as @flamendless has mentioned, FFI is very helpful in providing features that Love restricts. For example, the love.filesystem documentation mentions that it will only give access to the root folder (source directory), the game's save directory, or the folder containing the game's .love archive or source directory. This is sufficient and recommended when shipping a game for end users as the game shouldn't need access to any other part of the filesystem.
However, Slab is meant to provide functionality to help build out tools or applications for people using Love that may need access to other parts of the filesystem that Love doesn't provide. There may be files needed during development of a game that won't be shipped to end users to allow for quicker or more streamlined development. Others may want to create a tool or application using Love that may want to allow the user to save/load files outside of Love. The file dialog is meant to mimic the standard Open/Save dialog found in operating systems with a GUI.
Linux is not my primary development platform so this slipped through the cracks unfortunately, as I mainly work on OSX. I am in the process of getting a Linux environment set up so that this won't happen again in the future. Hope this answers the question.

Hi @coding-jackalope , thank you for detailed explanation. As FFI appears to have some unexpected restrictions as well, I'd provide LOVE as another backend and let user to choose which one to use. By the way, I'm able to access any file on my filesystem using love.filesystem.getInfo. Probably the only restriction love.filesystem have is write access limited to save directory.

Hi @pirogronian, what version of ArchLinux are you running? I have tried using the file dialog in both Ubuntu and Manjaro which is a ArchLinux based system, and both worked fine when browsing files. Are you just using a base Arch system or combining a desktop?

Hi @coding-jackalope .  I have some custom packages, but all base and devel are standard and fresh. Exact versions:

glibc 2.31-5
gcc-libs 10.1.0-2

I could't find stat64 nor stat or lstat symbols among certain shared objects of these packages, though.
As I stated, at first everything worked fine, but just next day it stopped. I did system update meanwhile, but no devel package was updated, at least I couldnt find it.
But now I see luajit 2.0.5-3 was updated 24-th july, so around the moment problem started. Most probably it contains a bug or something.


[Bug]: Outline Manager can't create a GCP project

Application
Outline Manager
Describe the bug
While setting up your VPN via Google Cloud, it successfully authorizes, but even when granted all requested permissions, upon filling in the project name and selecting an active billing account, you get "An error occurred while setting up your Google Cloud project" instead
Steps to reproduce

Open Outline Manager on PC
Select "Google Cloud Project"
Authorize using an account that has admin rights on GCP
Fill in the project name and select a billing account, then click Create Project

What did you expect to happen?
GCP Project is created, setup continues
What actually happened?
An error occurred while setting up your Google Cloud project error modal, no further actions/interactions
Outline Version
1.15.2
What operation system are you using?
Windows
Operating System Version
Win10
Screenshots and Videos
No response

ah my google cloud account ran out of projects with billing enabled. I turned off billing for a few projects and everything started working properly

Sounds like you were able to resolve your issue. Feel free to re-open if there's some action required from us. Thanks!

@sbruens the guy is not the OP, I am, and itr did not get resolved for me heh


Generate report: Top 100 populated cities in the world

City Report
A city report requires the following columns:
Name.
Country.
District.
Population.

SELECT city.Name AS CityName, country.Name AS Country, city.District, city.Population
FROM city
JOIN country ON city.CountryCode = country.Code
ORDER BY city.Population DESC
LIMIT 50;


Add documentation for Validation Rules feature to Custom Resource Definitions task docs

Authors: @cici37, @jpbetz
Document the Validation Rules feature (alpha in 1.23)
KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2876-crd-validation-expression-language
API documentation: https://github.com/jpbetz/kubernetes/blob/cel-port/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1/types_jsonschema.go#L179-L237
Implementation PR: Feature implementation: Validation rules for Custom Resource Definitions using the CEL expression language kubernetes#106051

/assign @mehabhalodiya
/cc @jlbutler

/cc @sftim
Replacement PR, if we can carry over prior review. Thanks!

/sig api-machinery

@cici37 we'll need tech LGTM from SIG API Machinery - can you nudge the right folks?
If you need help finding a reviewer for this, say so and we'll help out.

@sttts @deads2k
Would you mind to take a look and grand tech LGTM when you have time? Thank you

@jlbutler Can you PTAL?

/lgtm
@cici37: if you squash commits (ending up with 1 commit that has 199047637f3706a936a3e8e12ef0a0245730a7f3 as its parent) then Prow will be able to retain the existing LGTM.

@liggitt @sttts
Would any of you have time to take a look again? I guess a tech LGTM is still needed :)

@sttts @liggitt Can you please have a final look on these changes?
Thank you!

/lgtm

/approve


MM-47071 : Migrate "components/suggestion/search_suggestion_list" to typescript

Summary
Migrate components/suggestion/search_suggestion_list to typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21128
JIRA: https://mattermost.atlassian.net/browse/MM-47071
Related Pull Requests
None
Screenshots
None
Release Note
NONE

Hello @AbhinavVihan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Hi @AbhinavVihan. Do you have any questions about our feedback, or is there anything we could help with on this?

hi @hmhealey, there are some functions that are being used e.g. announceLabel() from the extended class. suggestion_list.d.ts does not have these methods so typescript is giving errors in that case, if suggestion_list.d.ts is going to be imported instead of suggestion_list.jsx.

Ah, I see. In that case, you can add those to the definition in suggestion_list.d.ts. We're going to have a similar ticket to migrate that to TypeScript as well later on, so it would help out with that if we already had type definitions for most of its fields there

/e2e-tests

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/268088


Manage the onLoadFromCursor call

Add generation of the onLoadFromCursor call when the Model implements LoadFromCursorListener.
The test ListenerModelTest is not ok yet, there is still SQLiteStatementListener#onBindToStatement not plugged.
It's one of my first improvement on this project, I would continue to help, so don't worry if it's not mergeable, but if you can please comment and provide some guidance, and I'll fix my issues ;)

this will call it for each ColumnDefinition defined. incorrect, will close this.

Same as before right?
Anyway where should this modification take place if we want to improve it?


Use proper change address

We should use the proper change address instead of using a normal one.
Just change the code to use this function: https://docs.rs/zcash_primitives/latest/zcash_primitives/zip32/sapling/struct.DiversifiableFullViewingKey.html#method.change_address

I'm gonna take a look at this tomorrow

as you want imo it is a useless waste of time


Move hir_ty to Chalk IR

Closes #8313.
There's some further cleanups to do:

we're still using our TypeWalk in lots of places (not for mutating/folding though, just for walking)
we're still using our own canonicalization and unification and our InferenceTable
~ToChalk still exists and gets called, it's just the identity in most cases now (I'll probably clean those up before merging this)~

changelog internal Type inference now uses Chalk's types everywhere, instead of having its own representations and mapping between them

bors r+

987 MB -> 1018 MB RAM on self.


missing User32.SetWindowPlacement

plz, add missing User32.SetWindowPlacement: https://msdn.microsoft.com/pt-br/library/windows/desktop/ms633544(v=vs.85).aspx

SetFocus too

Please send a PR for additional APIs.


💡 [REQUEST] -

[x] I am from GSSoC'23.
[x] I would like to be assigned this task.

Section
Description

Concise Description
Adding FAQ section will give more info about the app

Additional Context
Write any other contexts related to the feature and give guidance to initial consumers. This FAQ section will be added in about section or as an additional section in the sidebar

Screenshots
A sample FAQ Questions

Code of Conduct
By submitting this issue, you agree to follow our Code of Conduct.

[x] I follow the Contributing Guidelines of this project.
[x] I have checked the current issues for duplicate problems.
[x] I have read the readme of this repository.

@AKD-01  plz assign me this issue

@AKD-01  I am a GSSOC'23 contributor as mention above


[$250] mWeb - Scan - As employee deleted scan receipt when opened as admin receipt page displays error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.65
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4510561
Issue reported by: Applause - Internal Team
Action Performed:

Launch app and login as employee
Tap plus icon -- submit expense -- scan
Upload an image using camera
Tap scan
Open the scan expense and enter all details
Tap receipt and tapping 3 dots on top, delete the receipt
Login mweb as admin
Open Workspace chat and note receipt deleted expense is shown with green label
Tap on green label

Expected Result:
As employee deleted scan receipt when opened as admin receipt page must not display 403 forbidden error
Actual Result:
As employee deleted scan receipt when opened as admin receipt page displays 403 forbidden error
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ba39a0bb-4c02-4a29-a0f8-23ccb277baaf
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012c381ba0b987166a
Upwork Job ID:<PHONE_NUMBER>893196288
Last Price Increase: 2024-05-03

Waiting for proposals!

Still waiting on proposals

Just a heads up I'll be OOO 6-13th (I may have some time on the 6th), so feel free to re-assign if proposals start rolling in before I'm back!

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (First week)

Great! Let's close this out then, it can be reopened if further reports occur.


Docs and misc tweaks

Codecov Report

Merging #2 (0592922) into main (e91ba88) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   99.23%   99.25%   +0.01%
==========================================
  Files           3        3
  Lines         131      134       +3
  Branches       17       18       +1
==========================================
+ Hits          130      133       +3
  Partials        1        1

Flag
Coverage Δ

unittests
99.25% <100.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

autoregistry/registry.py
98.86% <100.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91ba88...0592922. Read the comment docs.


remove: asyncapi-plugin-idea

IDEA plugins for now has own release cycles and can't live here anymore.
Remove asyncapi-plugin-idea from asyncapi-plugin.
Till transfer to AsyncAPI repo plugin lives in my repository: https://github.com/Pakisan/jasyncapi-idea-plugin

@derberg
Will discuss the transfer date later. I plan to make it done by end of the year

sure, so it basically means that code for the plugin must have a standalone repo? wouldn't it be better to start in asyncapi org directly?

so it basically means that code for the plugin must have a standalone repo?
Yes

wouldn't it be better to start in asyncapi org directly?
I created it ~6 months ago

so it basically means that code for the plugin must have a standalone repo?

Yes

wouldn't it be better to start in asyncapi org directly?

I already moved the plugin to new repo ~6 months ago


WebRTC: Allow user to configure communication protocol

Allow user to choose between TCP and UDP

This is done already by MCM, the client software should be the one to filter for that


500 Internal Server Error

Today, when I type anything in github copilot chat ,  it will report " unhandled status from server: 400 Bad Request "  or  " 500 Internal Server Error"  ,  But,  it was worked correct yesterterday.

me either

happened to me too

i have the same issue in Hong Kong!

+1

+1 in Korea

+1

+1

I have been facing the same issue too

Experiencing both errors, also.

+1

+1

+1

+1  in Japan

It turns out that everyone has this problem

+1

same

same

me too unhandled status from server: 400 Bad Request

Just waitting...

+1

+1

+1

+1 Philippines

+1
unhandled status from server: 400 Bad Request or  500 Internal Server Error

me too.

+1

+1 in VN

+1 from Korea.
I think it's mostly happening in Asian countries

+1 from Australia

it's now working on my side. from PH

Working in US too

This was a temporary outage that should be now fixed. Thank you for filing this issue!


Appwrite Issue #4276

#<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
You can learn more about contributing to appwrite here: https://github.com/appwrite/appwrite/blob/master/CONTRIBUTING.md
Happy contributing!
-->
What does this PR do?
This PR gives the demo-todo-with-flutter app the support of appwrite 1.0 platform.
Test Plan
The application is tested on the emulator and physical device as well after the application of the made changes.
The deprecated keywords are upgraded with appwrite 1.0 platform support such as "Database" has been changed to "Databases", etc.
The app constants are also included in the PR and the endpoint is also added to the constants.dart.
Related PRs and Issues
Issue related to this PR
Have you read the Contributing Guidelines on issues?
Yes
(Write your answer here.)

@karan-17, sorry, the PR needed to be created during Hacktoberfest for it to qualify.

@stnguyen90 I have no issues with that, but if it can be a contribution for the AppWrite Organization, and as an open source too, it would be worth investing the time for me!
You can review the PR without adding hacktoberfest tag. ☺

@stnguyen90 I have no issues with that, but if it can be a contribution for the AppWrite Organization, and as an open source too, it would be worth investing the time for me! You can review the PR without adding hacktoberfest tag. ☺

We would love to add your contribution! Feel free to reach out on discord if you need assistance.

Hey! @stnguyen90 what is the expected timeline for getting this PR reviewed for conflicts and merged in the main repository??

@karan-17 It'll be a while as we have a lot of PRs to review.

@karan-17 have you had a chance to address the comments?

@stnguyen90 I will be available to make the required changes post-January, as I'm having a project deadline. The delay is highly regretted!

Too out of date.


Fixe cmake template, link some targets to zlib

grpc_cronet/grpc_unsecure needs to be linked against zlib, otherwise
build will fail with cmake and BUILD_SHARED_LIBS=ON.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot I signed it!

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Is this still a thing?

Not needed anymore? I just successfully tried building grpc_cronet and grpc_unsecure with BUILD_SHARED_LIBS=ON.
Feel free to reopen if this is still useful.


server: prevent double channel close

Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>
- What I did
Fixed a double close of a channel as reported here https://github.com/kubernetes-incubator/cri-o/pull/1345#issuecomment-369909740
@mrunalp @rhatdan PTAL
- How I did it
- How to verify it
- Description for the changelog

@adelton PTAL

/test all

/test critest_fedora

LGTM

LGTM

@mrunalp PTAL

LGTM


Remove html from Match README

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Bitbucket doesn't support HTML in markdown so the table in the fastline match readme doesn't render.  Ideally switch to native markdown.
Complete output when running fastlane, including the stack trace and command used

Environment
Bitbucket

fastlane creates a readme in the fastlane directory with html in it.
it also creates one in the match repository.  see:
https://github.com/fastlane/fastlane/blob/master/match/lib/assets/READMETemplate.md
so these are my repo's not the fastlane ones. my company has chosen to use bitbucket.  so the file that is committed isn't visible.  you can see in my screen shot.
let me know if unclear still.
thanks!
-Rylan

Ah, now it's clearer what you mean - and I can actually reproduce this as my certificate repo also lives on Bitbucket ;)
Do you want to take a shot at modifying the template file? You can even do it directly on Github, it will create a fork automatically when you edit the file. Then send a PR and refer to this issue in the description. Thanks!

sure I'll pr it.

done, closing this for the pr.


Add Two Numbers.

You are given two non-empty linked lists representing two non-negative integers. The digits are stored in reverse order, and each of their nodes contains a single digit. Add the two numbers and return the sum as a linked list.
You may assume the two numbers do not contain any leading zero, except the number 0 itself.
Example:
Input: l1 = [2,4,3], l2 = [5,6,4]
Output: [7,0,8]
Explanation: 342 + 465 = 807.

Assign this to me!


HWP-328 Updating Environment Variable Values

Description
This PR includes the following proposed change(s):
N/A
Requires
Add 'Requires Attention' label if appropriate.

[ ] Requires an update to the .env file
[ ] Requires adding a file listed in the .gitignore
[ ] Requires an opinion or answer to a question, see comments.
[ ] Requires other attention, see below.

If there are any requirements for the developer to make after this PR is merged please list them here.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
For pull requests that are not just a simple fix, please check that the branch works on your local machine.

[ ] Tested by Zach.
[ ] Tested by Brandon.
[ ] Tested by Brady.

Does the change impact or break the Docker build?

[ ] Yes
[x] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[x] No

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes
[ ] If attention is required by the developer such as updating the .env file, these requirements have been listed.

Good find, I'm brain dead today. Next time you review a PR and find a mistake, I'd like you to do the following please:

Start a review instead of comment
make your comment on the line you see the mistake
@ the author

@BradyMitch check out the latest commit please


Exception in Archiver.del

The code to produce this is below -- just needs two tree artifacts. I do not think the calls to things like shear are pertinent, but the script was small where this was first observed so just pasting it anyway. The exception appears to be stochastic.
Exception ignored in: <bound method Archiver.__del__ of <qiime2.core.archive.archiver.Archiver object at 0x7f929dc5ff28>>
Traceback (most recent call last):
  File "/home/mcdonadt/miniconda3/envs/q2-2017.2/lib/python3.5/site-packages/qiime2-2017.2.0-py3.5.egg/qiime2/core/archive/archiver.py", line 347, in __del__
  File "/home/mcdonadt/miniconda3/envs/q2-2017.2/lib/python3.5/shutil.py", line 473, in rmtree
TypeError: 'NoneType' object is not callable
Exception ignored in: <bound method Archiver.__del__ of <qiime2.core.archive.archiver.Archiver object at 0x7f929dc7bf98>>
Traceback (most recent call last):
  File "/home/mcdonadt/miniconda3/envs/q2-2017.2/lib/python3.5/site-packages/qiime2-2017.2.0-py3.5.egg/qiime2/core/archive/archiver.py", line 347, in __del__
  File "/home/mcdonadt/miniconda3/envs/q2-2017.2/lib/python3.5/shutil.py", line 473, in rmtree
TypeError: 'NoneType' object is not callable

import qiime2
import skbio
import sys

ar_a = qiime2.Artifact.load(sys.argv[1])
ar_b = qiime2.Artifact.load(sys.argv[2])

t_a = ar_a.view(skbio.TreeNode)
t_b = ar_b.view(skbio.TreeNode)

ids_a = {n.name for n in t_a.tips()}
ids_b = {n.name for n in t_b.tips()}

print("Total ids: %d" % len(ids_a | ids_b))
print("Total ids A: %d" % len(ids_a))
print("Total ids B: %d" % len(ids_b))
print("Total unique: %d" % len(ids_a.symmetric_difference(ids_b)))

overlap = ids_a & ids_b
t_a_o = t_a.shear(overlap)
t_b_o = t_b.shear(overlap)

print("RFD: %f" % t_a_o.compare_rfd(t_b_o, True))
print("tip-tip comparison: %f" % t_a_o.compare_tip_distances(t_b_o))

I think we may have figured out why this happens. When the artifact goes out of scope as the program is exiting, the environment isn't stable and stdlib functions are being None-ed out. If the artifact was inside of a scoped block or otherwise deleted with del before the program exits, the destructor seems to run as expected. (Although this isn't a guarantee, since the GC is allowed to do "anything" in principle).
We will need to adapt this destructor to work more like the NamedTemporaryFile objects, which have to do some special hackery to make these objects clean up correctly.

More specifically we just need to use weakref.finalize it looks like. It is always called before interpreter shutdown.


Train Jupyter Notebook

Jupyter notebook version of train.py

Codecov Report

Merging #83 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   50.33%   50.33%
=======================================
  Files          87       87
  Lines        4168     4168
=======================================
  Hits         2098     2098
  Misses       2070     2070

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1040d42...4214ddd. Read the comment docs.

Looks good but maybe you should update the docs to mention how to run it? Or update the notebook to say how to visualize these runs in the UI, etc. It's not clear how to use this and whether it's required for the basic train.py or just a separate thing.

Closing this as #129 supersedes this PR.


Add python 3.8 compatibility

Motivation for changes:
Make flexget python 3.8 compatible
Detailed changes:

Update version on deps than need to be updated for 3.8
Fix our invalid escape sequences to prevent SyntaxWarnings

To Do:

[ ] cherrypy on windows install fails due to no pywin32 release for 3.8 yet
[ ] Declare compatibility in setup.py
[ ] Add 3.8 to CI testing matrix

Invalid escapes have been fixed separately. Closing this for now, will redo now that we are on github actions.


Don't send window updates if remote side has closed the connection?

I've noticed that smoltcp is sending window updates after receiving a FIN. For example:

Remote endpoint sends us a bunch of data.
Remove endpoint sends FIN
We ACK the data and the FIN, with reduced window size.
Application reads the data from the TcpSocket.
We send a window update ACK, with the now larger window.

It looks to me that this last ACK might be avoidable? If we've received a FIN, this means the remote side is not going to send more data, so they shouldn't care about the window size anymore.
I'm not sure whether the RFCs allow this though. I'm opening this issue to discuss. If we decide to do this, I can send a PR.

I'm afraid I no longer remember enough context offhand to discuss this.


modules

I can't seem to get it to work with module files.  Even a simple one:
module test

end module test

The error is Can't open the module file 'test.mod0' for writing at (1): Permission denied at line 3 col 15.

I think the code should set the -J and -I options of gfortran to point to some writeable directory to fix that.

This should work now.


Twitter mentions

Boilerplate: I'm going to refocus this project on rfcbot, since that's the primary usage rusty-dash.com is seeing.


Implementing pass-through protocols

Right now I'm trying to implement the EFI ATA, NVMe, and SD MMC pass-through protocols. These are defined in SECs. 13.13 (pg. 582), 13.15 (pg. 605), and 13.16 (pg. 615) of UEFI 2.9.
I'm starting off with EFI_ATA_PASS_THRU_PROTOCOL. I'm currently stuck on the EFI_ATA_PASS_THRU_PROTOCOL.PassThru() function. Its signature is:
           typedef
           EFI_STATUS
           (EFIAPI *EFI_ATA_PASS_THRU_PASSTHRU) (
            IN   EFI_ATA_PASS_THRU_PROTOCOL          *This,
            IN   UINT16                               Port,
            IN   UINT16                               PortMultiplierPort,
            IN OUT EFI_ATA_PASS_THRU_COMMAND_PACKET *Packet,
            IN   EFI_EVENT            Event OPTIONAL
            );

This isn't what I'm stuck on; I'm stuck on the related definitions that this function requires:
          typedef struct {
           EFI_ATA_STATUS_BLOCK           *Asb;
           EFI_ATA_COMMAND_BLOCK          *Acb;
           UINT64                         Timeout;
           VOID                           *InDataBuffer;
           VOID                           *OutDataBuffer;
           UINT32                         InTransferLength;
           UINT32                         OutTransferLength;
           EFI_ATA_PASS_THRU_CMD_PROTOCOL Protocol;
           EFI_ATA_PASS_THRU_LENGTH       Length;
          } EFI_ATA_PASS_THRU_COMMAND_PACKET;

           typedef struct _EFI_ATA_COMMAND_BLOCK {
            UINT8 Reserved1[2];
            UINT8 AtaCommand;
            UINT8 AtaFeatures;
            UINT8 AtaSectorNumber;
            UINT8 AtaCylinderLow;
            UINT8 AtaCylinderHigh;
            UINT8 AtaDeviceHead;
            UINT8 AtaSectorNumberExp;
            UINT8 AtaCylinderLowExp;
            UINT8 AtaCylinderHighExp;
            UINT8 AtaFeaturesExp;
            UINT8 AtaSectorCount;
            UINT8 AtaSectorCountExp;
            UINT8 Reserved2[6];
           } EFI_ATA_COMMAND_BLOCK;

           typedef struct _EFI_ATA_STATUS_BLOCK {
            UINT8 Reserved1[2];
            UINT8 AtaStatus;
            UINT8 AtaError;
            UINT8 AtaSectorNumber;
            UINT8 AtaCylinderLow;
            UINT8 AtaCylinderHigh;
            UINT8 AtaDeviceHead;
            UINT8 AtaSectorNumberExp;
            UINT8 AtaCylinderLowExp;
            UINT8 AtaCylinderHighExp;
            UINT8 Reserved2;
            UINT8 AtaSectorCount;
            UINT8 AtaSectorCountExp;
            UINT8 Reserved3[6];
           } EFI_ATA_STATUS_BLOCK;

           typedef UINT8 EFI_ATA_PASS_THRU_CMD_PROTOCOL;

           #define   EFI_ATA_PASS_THRU_PROTOCOL_ATA_HARDWARE_RESET   0x00
           #define   EFI_ATA_PASS_THRU_PROTOCOL_ATA_SOFTWARE_RESET   0x01
           #define   EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA         0x02
           #define   EFI_ATA_PASS_THRU_PROTOCOL_PIO_DATA_IN          0x04
           #define   EFI_ATA_PASS_THRU_PROTOCOL_PIO_DATA_OUT         0x05
           #define   EFI_ATA_PASS_THRU_PROTOCOL_DMA                  0x06
           #define   EFI_ATA_PASS_THRU_PROTOCOL_DMA_QUEUED           0x07
           #define   EFI_ATA_PASS_THRU_PROTOCOL_DEVICE_DIAGNOSTIC    0x08
           #define   EFI_ATA_PASS_THRU_PROTOCOL_DEVICE_RESET         0x09
           #define   EFI_ATA_PASS_THRU_PROTOCOL_UDMA_DATA_IN                  0x0A
           #define   EFI_ATA_PASS_THRU_PROTOCOL_UDMA_DATA_OUT                 0x0B
           #define   EFI_ATA_PASS_THRU_PROTOCOL_FPDMA                         0x0C
           #define   EFI_ATA_PASS_THRU_PROTOCOL_RETURN_RESPONSE               0xFF

           typedef UINT8 EFI_ATA_PASS_THRU_LENGTH;

           #define EFI_ATA_PASS_THRU_LENGTH_BYTES                             0x80
           #define   EFI_ATA_PASS_THRU_LENGTH_MASK                            0x70
           #define   EFI_ATA_PASS_THRU_LENGTH_NO_DATA_TRANSFER                0x00
           #define   EFI_ATA_PASS_THRU_LENGTH_FEATURES                        0x10
           #define   EFI_ATA_PASS_THRU_LENGTH_SECTOR_COUNT                    0x20
           #define   EFI_ATA_PASS_THRU_LENGTH_TPSIU                           0x30
           #define EFI_ATA_PASS_THRU_LENGTH_COUNT                             0x0F

Most of these definitions are trivial. What I'm confused about is the void pointers. (This isn't the only EFI protocol that has this, but this is one of them.) What type would I use for this in this environment since I (can't -- I don't think) use c_void?

Hi! Usually, we represent such buffers as *mut u8, mutable arrays of bytes. If they have any alignment requirements (e.g. the spec says they should be 64-byte aligned), we also add asserts in the calling code to validate the alignment. See this function for an example.

Hello, any progress on this?
I've had NVMe passthrough implemented reasonably well for a while in my uefi project, and I am considering making a PR for this.
Although I am unsure about how to non-manually test it, since it requires passing an ssd to qemu with vfio, or, well, actually running it.
And also I'll need ATA later, so I am asking if I have to do it for myself or is there something you will make a PR with at some point.

@necauqua since the original issue author didn't reply, I'm going to guess they're not actively working on this feature anymore?

Although I am unsure about how to non-manually test it, since it requires passing an ssd to qemu with vfio, or, well, actually running it.
Indeed, we'll probably not be able to properly test this protocol in CI. At the most we can statically check the code keeps compiling, but the logic behind it will suffer from some code rot.

That being said, if you've already defined the corresponding protocols and wouldn't mind sharing them with the uefi-rs crate users, we'd welcome the contribution 😄

Sure, I'd push the ones I have in my project, I need to add docs/missing impls and also yeah most of them are kind of untestable without dedicated hw or smth.
Also ATA passthrough mysteriously does not work for me: at least ATA Identify (just times out) but it's used by PI DiskInfo protocol (which I have also implemented without docs/tests seeking alternatives, as well as StorageSecurityCommand (13.14) and DevicePathToText (10.6.2)) and from it I do get identify data, so it seems like my impl/usage somehow differs from the C ones

similar than  scsi
protocol, PR: https://github.com/rust-osdev/uefi-rs/pull/1155/files/c9777f34abdece813f8a5c77cce861597e29bf9a..b06d7663d63853639366894dc3edfe3aa6bacb01

While I kind of abandoned it all long time ago, I'm using https://github.com/necauqua/opal-uefi-greeter to this day - anyone has my permission to steal the NvmExpressPassthru from there to here if you haven't done that already :sweat_smile:


Spatial Rule Lookup (e.g. Country Specific Rules)

This PR intents to solve #175.
The basic data structure is an array, that separates the world (or an area) into tiles, with a given resolution. Each tile contains a reference to a set of rules.
Rules contain a set of polygons in which their rules are valid. Using an array has to disadvantages: (1) covering unused space, e.g. water and (2) inexact resoultion. Currently the default resolution about 20*20km at the equator (0.1 degree). We can achieve exact results when doing a Polygon contains check, which can be configured.
Right now I prepared two set of rules, Austria and Germany, but rules can be written for every Country. All countries are available in the countries.geo.json file. This file is based on the admin levels from NaturalEarthData under public domain. As the file would be 25mb, is reduced it to 10% using DP. Therefore the borders are sometimes slightly inaccurate (should not be too bad, otherwise let me know).
Lookup speed is not too bad. 10 000 000 lookups in an area that is filled approximately half by a polyong, takes between 3-4 seconds on my machine.
TODOs:

[ ] Nr of rules is currently limited to 255, but since we have to create a new rule for every unique set of country borders, the array might be with 20-30 countries, depending on the borders.
[ ] The SpatialLookup is currently created in the web module. It would be better if we could have it as Storable<LocationIndex>. That way we could load it, once it was created (even though creation is quite fast). Also I am not sure how to do this (especially with the rule reference array, the lookup array should be easy)?
[ ] How to evaluate these rules? Currently I do this in the DataFlagEncoder, however it might be better to do this in the GenericWeighting? IMHO the DataFlagEncoder is representing the tags of a given source (e.g. OSM), but not business logic. For example we are also not saving the default max speeds in the edge, but calculate it every time in the GenericWeighting
[ ] Consider using the exact country borders - would slow down the Polygon contains approx. 10 times. Also we have to host this file, as IMHO 25mb should not be put into the repo.
[ ] Differentiate between Polygon and Multipolygon?

Let me know what you think. Currently this is still work in progress, so any comments are more than welcome.

Thanks - will have a look!

As the file would be 25mb, is reduced it to 10% using DP

Maybe this is not too critical. How large is the 25mb file if compressed? As git and jar normally does compression and it will be big just on the disc and not in production.

How large is the 25mb file if compressed?

2.5mb. You can view the file here: http://bl.ocks.org/d/7280192619e0cc25f609dafe5c0de2cf
I think the borders are not too bad, but we can definetly use the exact borders if this becomes an issue.

I tested this with the landmarks branch and this seems to work (at least the spatial rule part, still something else still does not work ;))
Some minor changes I had to do or would like to have :) (maybe already done, did not review your latest changes too detailed)

calculate boundaries from the polygons instead of providing one
https://github.com/graphhopper/graphhopper/commit/2c04f4790eb646246fa47fced2fd4f7c24f054cc
https://github.com/graphhopper/graphhopper/commit/8dc447d5785953e4513562c954c46ec693663289

I tested this with the landmarks branch

Thanks for testing :)

seems to work (at least the spatial rule part, still something else still does not work there ;))

But unrelated to this PR?

Some minor changes I had to do or would like to have :)

Thanks for the two commits. I will add these to this branch as well. Calculating the boundaries from the polygons is already on my TODO list as well.

(maybe already done, did not review your latest changes too detailed)

No, haven't made a lot of progress with this PR in the last weeks. Will do some more soon :).

Some minor changes I had to do or would like to have :) (maybe already done, did not review your latest changes too detailed)

These changes are now committed.

 I created a more generic approach for the spatial rule. Is this better? Should I change anything?
BTW: the hack with the Object and the second method wrapping it into generic was needed in my case. Maybe we find a way around this.

One more thing: I'm not sure if we should put a dependency inside DataFlagEncoder. Is there an alternative to feed it from outside somehow via the post processing hook, looping over all edges and setSpeed?

Thanks for your feedback. I will change the code accordingly.

Thanks & looks good. Just the question regarding specific vs. generic. Probably we should keep the specific stuff until we have a better impression of more use cases?

Yes, I have the same feeling right now. It seems a bit like premature optimization. Let's start easy and make it more generic when we need it :).

I changed the the way the Spatial Lookup works a bit.
When importing, an id is written for every edge. The id references to a spatial rule. In the GenericWeighting  these rules are evaluated.
Currently, the evaluation in the GenericWeighting is not yet perfect.

I have some notes and will further think about how we should progress here.
E.g. the singleton SpatialRuleRegister won't work pretty and is an unnecessary restriction. In general singleton is considered dangerous and for GraphHopper this cannot be used as we allow (for purpose) multiple instances of everything. Also testing is ugly for this etc.
The EMPTY_RULE_CONTAINER is potential buggy as you can add (by accident) multiple rules (at least I do not see a restriction)
Furthermore there are many javadocs missing, see the discussion in #891. But again, first let us decide on what we really want&need :) !

E.g. the singleton SpatialRuleRegister won't work pretty and is an unnecessary restriction.

Ok sure, I can change that.

The EMPTY_RULE_CONTAINER is potential buggy as you can add (by accident) multiple rules (at least I do not see a restriction)

Will have a look, thanks.

Furthermore there are many javadocs missing

Yes, this is a bit on purpose. I will do that before we merge this PR. When we constantly change the interface, the documentation might suffer.

But again, first let us decide on what we really want&need :) !

Good plan!

I removed the Singleton. I think this was a good idea. This allows us to easily inject the config to make the CountryRules configureable. The configuring part is not done yet.

The EMPTY_RULE_CONTAINER is potential buggy as you can add (by accident) multiple rules (at least I do not see a restriction)

Good find! I updated the EMPTY_RULE_CONTAINER and merged the latest master.

It looks better but still there is a bigger issue: the spatial rule index and the spatial rule registry are too loosely coupled. I think the registry stuff should be moved into the index. The problem is that the number of rules define the number of required bits in the encoded value, and so we

[ ] have to set the spatial rule index earlier (before passing it to the EncodingManager) and
[ ] ensure that the configured rules are always the same number as the loaded once. Otherwise we e.g. add two rules (need two bits) for the import and on load a different config applies and the encoded value requires only 1 bit leading to all strange things. So we either have to return the count in the details or add it to the version or something different to enforce this.  (This is a general problem with the DataFlagEncoder that will also be a problem for the recently introduced configurable height&width&weight - will mention it there too)

Furthermore:

[ ] the default for the index should be no rules at all and requiring 0 bits and the code is then skipped the lookups entirely
[ ] 'Destroy the SpatialRuleLookup' -> Something seems to be wrong. Because either the 'destroy' should be naturally done from the GC or we should keep it. Also import vs. load with different number of rules will break the encoder. Let me think about this.
[ ] SpatialRuleRegister: public int getIdForName(String name) should be public int getId(SpatialRule rule) instead
[ ] SpatialRuleRegister: Map<Integer, SpatialRule> -> just use an ArrayList :) ?
[x] It should be possible with the config properties to specify a list of countries as JSON files. Let us avoid this for now and only enable this feature via Java API for now.
[ ] And what do the access values 0, 5, accessMap.get("no") mean? (DataFlagEncoder.getEdgeValueForAccess)
[ ] Optionally move the builder class containing just one method into the index too

I think the registry stuff should be moved into the index. The problem is that the number of rules define the number of required bits in the encoded value

True, my idea for this was to completely get rid of the SpatialIndex, once we loaded the OSM file.

So we either have to return the count in the details or add it to the version or something different to enforce this.

This is a good idea. So I anyone loads a different graph than configured we can throw an exception.

the default for the index should be no rules at all and requiring 0 bits and the code is then skipped the lookups entirely

Yes that is true, that is something I wanted to do when making it configureable.

'Destroy the SpatialRuleLookup' -> Something seems to be wrong. Because either the 'destroy' should be naturally done from the GC or we should keep it.

Well we pass the object reference to the GenericWeighting, we have to unreference it after the import I think.

just use an ArrayList :) ?

Probably, yes :)

And what do the access values 0, 5, accessMap.get("no") mean? (DataFlagEncoder.getEdgeValueForAccess)

This was introduced when making track unaccessible. So the GenericWheighting tried to estimate how accessible a certain street is. So an accessible street would be 0. 5 was I think eventually accessible.

Have now pushed a change suggestion.
BTW: The same config is now ensured via the spatial_rules number. The height&width etc config are similarly ensured already.

(BTW: also please have a look at some comments we made at 'outdated' commits here in this PR :))

Ok, so I updated this PR. Are we good to merge it or is there anything we should add/change?

I updated this PR and added JavaDoc to the Interfaces. I realized that passing a string as TransportationMode is not a good idea and changed it to be an enum (sorry for the last minute change). I feel like it makes more sense like that. This enum could be used in the DataFlagEncoder to differ between different TransportationModes as well.

Nice - Thanks!


Update silent-check-sso.html

This PR is now obsolete after sonar cloud fixes were merged to master.


Can I try this with other LLMs (for example manticore-13b?)

Absolutely mind-blowing that this works in a browser.  Love it!  Can other LLMs be converted into something that this can draw from?  (like manticore-13b?)

Thanks @salamanders , we are in the progress of adding more docs and enable generalization, you can check out current docs at https://mlc.ai/mlc-llm/docs/ likely it will be supported out of box, however, we are still in the process of getting default out of box perf, which will land soonish, and then all llama variants can be used


(Fix) Authorisation issues

This fixes when an unauthorised user tries to access the system - currently the autherror template tries to render the navigation, which requires a user to be present. As we don't get to that bit of middleware the user gets an error.
I've also added a check for if a user is active. If they are inactive, they see a authentication error, rather than the current (unexpected) behaviour of them being able to access the system, but without any of the roles.

@Harriethw This approach didn't actually work 😊 - I've tweaked where it happens in the middleware now, and added additional tests.


RDK-50163Support for running Android containers

Manage mounting android partitions
OCI Template modifications for Android
Extra settings for Android specific bind mounts and devices

Description
What does this PR change/fix and why?
If there is a corresponding JIRA ticket, please ensure it is in the title of the PR.
Test Procedure
How to test this PR (if applicable)
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other (doesn't fit into the above categories - e.g. documentation updates)

Requires Bitbake Recipe changes?

[ ] The base Bitbake recipe (meta-rdk-ext/recipes-containers/dobby/dobby.bb) must be modified to support the changes in this PR (beyond updating SRC_REV)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jonhenderson-sky The unit tests  and builds are failing, can you please correct those ?
Also, It would be great if you can add some unit tests for the Android container use case


[Feature Request]: StreamingAgentChatResponse Raw TGI Response Access

Feature Description
Hi,
I was hoping to request a feature to allow access to the raw response generated by the LLM in the StreamingAgentChatResponse that is returned by any of llama_indexes chat engines, when called in streaming mode. Specifically, we can currently implement a custom LLM that returns a CompletionResponse with both the text delta and the raw response json string set as keywords. For example, this function might be written as such:
@llm_completion_callback()
def stream_complete(self, prompt: str, **kwargs: Any) -> CompletionResponseGen:
text = ''
for response in self.model_endpoint.generate_stream(prompt, <other_keyword_arguments>):
text += response.token.text
yield CompletionResponse(text=text, delta=response.token.text, raw=response.json())
I can't remember if in the documentation this raw needs to be a string json or a dict, but its pretty easy to transform that with json.dumps or json.loads as necessary.
Unfortunately, even if we pass in the raw response in the CompletionResponse, the information is lost in the StreamingAgentChatResponse class. Specifically, when we start doing the awrite history method call, we start looping through the achat_stream generator in order to pull the information from the CompletionResponse into the Agent. However, this creates a lock on the achat_stream so we cannot access it anywhere else in the code. A traditional solution to this is to move information into a queue, as you do for the delta. This makes the raw text accessible for downstream applications. However, the full raw response (for example, if you wanted the generated_text, or top_tokens, or token information, or special information that the LLM returns), is never put into a queue and thus we cannot grab any of the non-token text information.
I am hoping to have this class get functionality added to it that would allow for the raw response to be accessed, assuming the LLM returned that information in the CompletionResponse. This would entail:
Adding in a new aqueue class that stores the raw dictionaries and corresponding helper methods / if clauses.
Updating awrite_response_to_history (and I guess write_response_to_history) to add raw info to the new raw queues.
Adding a new "async_raw_response_gen" method that functions exactly like the existing gens, just for raw not delta.
Reason
Currently, this feature cannot be supported in async mode due to issues with asynchronous processing. The awrite_response_to_history method locks the achat_stream generator, which is where the raw response is located, thus making it so we cannot manually obtain it. Within the awrite_response_to_history method, that information is ignored and never stored anywhere, causing us to lose the information despite the fact that we were able to pass it all the way up to this point.
I have tried extending the StreamingAgentChatResponse object, but unfortunately this causes a cascade of other extensions you need to make; you need to extend each chat engine class that you might need to make those use the extended object. When I tried to accomplish this in this way, every class updated led me to updating 3 more classes until I gave up and am asking for a feature update.
Value of Feature
The primary purpose of this feature would be to enable "pass-through" of the TGI endpoint. Currently, llama lets us wrap the TGI endpoint to provide it access to a RAG system for new information it hadn't seen in training. But because the information is lost, we cannot make the RAG system look like a TGI endpoint itself. This is an issue if we wanted to essentially insert the RAG system as a 'man-in-the-middle' with a front end that expects a TGI endpoint, such as Huggingface's Chat UI. Technically, we can do this hookup by essentially wrapping our text token response in a bunch of dummy values to mimic the TGI endpoint interface, but if we ever did need to access that information for whatever reason we'd be back at square zero.
More generally, being able to bubble up the raw response from the LLM would allow us to create a server that mimics the TGI documentation cleanly, which would allow us to connect a RAG system we build to any downstream application that expects a TGI endpoint.

Fwiw, our current workaround for this issue is to change our LLM's stream_complete method to pass the string version of the raw response information as the delta text. Which is pretty hacky and not how those variables are meant to be used and might be breaking other functionality we currently aren't using but might want to in the future.

This feels pretty complicated to implement (and admittedly lower priority). If you have an idea for an implementation, I welcome a PR


imports_granularity = "Module" causes compile error when path contains self

Describe the bug
If a path contains self, this keyword must be enclosed in braces:
use crate::lexer::{self}; // valid
use crate::lexer::self;   // invalid

rustfmt with imports_granularity = "Module" sometimes splits use statements so that invalid code like above is emitted.
To Reproduce
use crate::lexer::{self, tokens::TokenData};

rustfmt formats it like this:
use crate::lexer::self;
use crate::lexer::tokens::TokenData;

When formatting the file again, the ::self is removed.
Expected behavior
rustfmt should emit the following code without having to run it twice:
use crate::lexer;
use crate::lexer::tokens::TokenData;

Note that use crate::lexer; and use crate::lexer::{self}; are not actually equivalent: The latter only imports the lexer module, while the former looks in all namespaces, so it can import up to 3 items at once, e.g. a function, a module and a macro of the same name.
To make sure that the behaviour doesn't change, it needs to be formatted like so:
use crate::lexer::{self};
use crate::lexer::tokens::TokenData;

However, I would find this rather annoying, because of the way rust-analyzer handles auto-imports.
Meta

rustfmt version: rustfmt 1.4.34-nightly (ea268b9 2021-01-28)
From where did you install rustfmt?: rustup
How do you run rustfmt: cargo fmt

Thanks for the report. We're aware of the differences between the two, which is why you'll notice these self cases handled with Item and Crate variants, but something definitely got missed here!

I am willing to try to fix this, but from the description of the expected behavior it is not clear whether the output should be crate::lexer or crate::lexer::{self}.
Also, if this is a bug, why is the issue labeled only-with-option?  If an option is needed, I am not sure how to write a test case when the option is not set, since the tests\target file will include use crate::lexer::self; which will be formatted as use crate::lexer; and the test will fail.

I am willing to try to fix this

Awesome, thank you!

but from the description of the expected behavior it is not clear whether the output should be crate::lexer or crate::lexer::{self}.

It has to be the latter, because as noted in the issue description these are not equivalent and changing what the developer wrote has the potential to cause compilation issues in the emitted formatted code (https://github.com/rust-lang/rust/issues/60941)

Also, if this is a bug, why is the issue labeled only-with-option?

I've added a description to the label that hopefully clarifies, but it's used to indicate that the issue cannot occur with the default rustfmt behavior and requires the use of an overridden value for a configuration option.

If an option is needed, I am not sure how to write a test case when the option is not set, since the tests\target file will include use crate::lexer::self; which will be formatted as use crate::lexer; and the test will fail.

I'm not sure I understand this. All options have default values, but this particular issue requires a non-default value in order to reproduce. The files used for the system/idempotence will need to have the corresponding config option self to Module via the standard comments at the top of the files.
I'd expect the input file to include:
use crate::lexer::{self, tokens::TokenData};

and the target file to inculde:
use crate::lexer::{self};
use crate::lexer::tokens::TokenData;

If an option is needed, I am not sure how to write a test case when the option is not set, since the tests\target file will include use crate::lexer::self; which will be formatted as use crate::lexer; and the test will fail.

I'm not sure I understand this. ....

No problem - my misunderstanding. I thought that the meaning of  the label only-with-option is that a new option should be added for whether use the modified formatting.

Cross linking #4991: required to be closed before imports_granularity is stabilised

@davidBar-On is this issue fixed by #4716?

@Aloso this issue is still present in master - I just opened a fix in #5253 (there is a test added which reproduces the failure).
The fix from #4716 appears to be present in the rc2 branch but not in master, I guess it got lost in a merge somewhere.
There are more details in the description of #5253

The fix from https://github.com/rust-lang/rustfmt/pull/4716 appears to be present in the rc2 branch but not in master, I guess it got lost in a merge somewhere.

Correct on the existence of the commit in different branches, but not quite on the cause, see #4801


fetching never resolves in Zombie

Zombie's link elements never fire a load event. The best way we could think to detect that this isn't supported is to check for the navigator.noUI property.

Fixed by https://github.com/stealjs/steal-css/pull/45


Add test with different src and dest port, channel

To ensure #8 is closed properly and there is no accidental src/dest mixup, we need to try a case where the source and dest connections use different channel ids and different ports. For ports, we can reconfigure what the default ics20 port is on one app. For channels, we need to init a channel on one side, then forget it. This will auto-increment one number on one side and not on the other.

Closed by #30


[framework] inline AbstractNode into RenderObject

AbstractNode isn't a free abstraction, because we can't do template style specialization in Dart. Many places in the framework that would otherwise have a free access or null check have to do a cast due to how AbstractNode is implemented.
Why not change to AbstractNode<T extends AbstractNode<T>>? In short, because it would still require casting in several places to prove that your instance of T is actually an AbstractNode<T>
I've also not found any code that attempts to abstract over an AbstractNode, usually code is written for one of RenderObject, Layer, or SemanticsNode and casts as necessary

From tests on customer:money's app, I was not able to make any measurable performance improvements. That said, if this change isn't breaking to google3 we might consider it since I think removing casts is also beneficial from an ease-of-understanding perspective.

(cc @goderbauer)

Google changes were not as bad as expected due to this PR getting bundled with some other breaking PRs. Will apply g3fix and then attempt to land

I ran a globla presubmit and bundled the changes into a g3fix. It doesn't seem like that is getting applied to the PR so I've marked as passing so we can land it.


Use arrow functions

They are now supported by latest Chrome, Opera, Edge, and Firefox. And I think most of JavaScript developers already familiar with them. Perhaps it makes sense to rewrite code snippets in spec using them.
A small example:

u.map(function(a) { return a; }) is equivalent to u (identity)
u.map(function(x) { return f(g(x)); }) is equivalent to u.map(g).map(f) (composition)

With arrow functions:

u.map(a => a) is equivalent to u (identity)
u.map(x => f(g(x))) is equivalent to u.map(g).map(f) (composition)

Should I make a PR?

I'd like to see this change.

I don't care either way, so go for it :+1:


Multi-class support

WIP.  ~Only implemented for true_positives/3 for now.~
~When num_classes is 1, then this is a binary classification problem; when num_classes is greater than 1, then this is a multi-class problem.~
~We can also follow sklearn which uses average='binary' to denote a binary classification problem.~
Functions with binary_* prefix will be used for binary classification problems, and the rest are for multi-class classification problems.

+1 for separating binary from non-binary ones. I think though, for accuracy, a single function for both will suffice.
My only question is if the binary functions should exist in a separate module but it feels many of metrics function can actually work on both (such as accuracy).

+1 for separating binary from non-binary ones. I think though, for accuracy, a single function for both will suffice.
My only question is if the binary functions should exist in a separate module but it feels many of metrics function can actually work on both (such as accuracy).

yeah, I also think many of them should work for both cases, and the confusion matrix can be used to derive most metrics we need.


[Regression] - V1 - Contributor Console - Send button overlaps on X(close) icon

Prerequisite

Create CLA Group with CCLA enabled
Connfigure githuborg and add repo to the CLA Group
In corporate console sign cla for the CLA Group

Steps to follow

Login to github repo as contributor
Edit file and create PR
User is gated by CLA
Click on CLA NOT SIGNED
Click Corporate
Select the company that as signed CLA for the CLA Group
Observed that in the popup SEND button overlaps on X(close) icon. This issue was fixed in #764 and Cancel and Send buttons were move to bottom of the popup. Now buttons are displayed on top of the popup and overlap issue is observed
Observed same issue when creating new company

Merged PR from @amolsontakke3576: https://github.com/communitybridge/easycla/pull/2135 to address this issue.

@nirupamav ready to review/confirm

Verified that the issue is resolved
Existing Company

New Company Request


sorting(bubble & insertion) and complexity

##bubble sort and insertion sort in C/C++ and find it's complexity📜

Domain of Contribution 📊

[x] C/CPP
[x] DSA
[x] documentation

/assign

/assign

/assign

Hey akarshan this issue have already been assigned so pls follow the GWOC rule it is clearly written that if someone has been assigned the issue then try not to spam/assign it again untill it is been unassigned

Hey akarshan this issue have already been assigned so pls follow the GWOC rule it is clearly written that if someone has been assigned the issue then try not to spam/assign it again untill it is been unassigned

hey really sorry, i didn't see an ASSIGNED label so didn't know, my bad


[Feature Request] exclude organizations from ranks

Hi - great job on github-awards, i hope you resolve the hosting issue.
I find it strange to have organizations in the same rank as single users. I wouldn't include organizations in the ranks at all, especially if you implement the feature that ranks a user's contributions to repos not owned by the user.
Putting an organization with multiple users in the same rank as a single user seems incoherent.

Thanks, i agree with you that having 2 different rankings would be a nice feature.
PR are welcome.
I'm closing this issue.


Added function strstr

Description

Pre-Submission Checklist
Common mandatory requirements

[ ] This pull request targets the master branch of freeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/
(e.g. fix/signin-issue)
[ ] Reviewed necessary guidelines in CONTRIBUTING.md.

By submitting this pull request, I have verified the following:

[ ] Added descriptive name to pull request. (mandatory)
Your PR should NOT be called Update index.md, since it does not help the maintainer understand what has been changed.
Good Guide PR title examples:
fix(guide): Git - edit Git Commit article
feat(guide): PHP - create PHP section and add Data Structures article

Good Coding challenge PR title examples:
fix(coding): add tests to Basic HTML challenge
fix(coding): update instructions to CSS Grid challenge

Good Learning platform PR title examples:
fix(platform): fixed sign in api
fix(platform): removed css from editor

Issues Closures

[ ] Addressed currently open issue. (replace XXXXX with an issue no in next line)

Closes #XXXXX
Since this change is a copy edit or translation for Guide articles or Coding Challenges:

[ ] I confirm no plagiarized, duplicate, or repetitive content that has been directly copied from another source.
[ ] I am adding only https links to external sources.
[ ] I am not adding short links instead of full URLs to webpages.
[ ] I have followed the recomended style guides for the copy edit.

Requirements, for changes which are NOT simple copy editing or translations:
You may skip the below ONLY if your changes do not touch tests, ui logic, api-server, etc. Your PR may not be accepted, if you did not meet these mandatory requirements. Simply put, we can't assume it will work if we never saw it working.
Since this change adds, updates or removes coding challenge tests:

[ ] I completed the coding challenge locally, and the changes look good.
[ ] Other tests or user stories in instructions are not affected.

Since this change is for the Learning platform (UI, logic, etc.):

[ ] I confirm my changes look good by running freeCodeCamp locally.
[ ] All new and existing tests pass the command npm test.

(Optional) Additional Context and Screenshots:

PRs #18421 , #18423 , #18426 , and #18429 are all changes to the same file by the same author. These should be closed in favor of a single PR containing all the changes.

Hi,
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


Prefer system TLS cert store by default

This is a follow-up on #2362 where bundled root cert stores became the default.
In scenarios where uv is wrapped by another rool (like rye) or buried somewhere deep in layers of Makefiles, "just" adding a command-line flag might not be trivial to make things work again. This change affects both users behind corporate HTTPS inspection proxies and private registry clients, where the registry is not world-facing but rather available only on the intranet with an internal cert issuer.
While I understand this makes initial startup benchmarks look rather bad, it also makes uv a pain to use in corporate environments. Please reconsider the default behavior to respect the system root cert store again, or at least make this configurable from environment variables/configuration files.

This is partially fixed by https://github.com/astral-sh/uv/pull/2401 if you have a ca b
We can go a bit further and add another env var as a shothand to --native-tls.
This change would be in uv crate itself and not in uv-client crate.

No problem, I'll add an environment variable for it.

While I understand this makes initial startup benchmarks look rather bad, it also makes uv a pain to use in corporate environments.

It's actually not even about benchmarks -- there's minimal overhead on Linux. But I use macOS and it makes uv ~50-100x slower on basic commands.


print sampled hyper-parameters in benchmark run

implement something like cat zoutput/benchmarks/name/hyperparameters.csv  so that user could have a quick look if parameter combinations are right, compared to checking mannually this file' content to see if the sampled hyperparameters are correct we
bash run_benchmark_slurm xx.yaml or bash run_benchmark_standalone xx.yaml

currently to know if a yaml file designs the experiment with wished hyper-parameters being sampled is to execute
bash run_benchmark_standalone xx.yaml and kill the process after hyperparameters.csv is generated, and mannually check if the file contains correct info,   the task here is to print it out during bash run_benchmark_standalone xx.yaml

fixed in https://github.com/marrlab/DomainLab/pull/855


[Physics] RigidBody3D Friction has less effect on spheres

Tested versions

Reproducible in : Godot v4.2.1.stable, Godot v4.2.1.stable Mono, Godot v4.3.dev2

System information
Godot v4.2.1.stable - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; <IP_ADDRESS>23) - 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 Threads)
Issue description
I was doing an experiment with the physics to create some surface resistance to RigidBodies3D using Physics Materials, but it seems that the friction doesn't work pretty well with spheres. It seems that even with the higher friction, when the sphere RigidBody goes through a surface, its deacceleration is almost zero.
I was hoping to have a the sphere being stopped the moment it touches the surface when friction = 1 and being slippery as a ice when in a lower values, but maybe I am missing or misunderstood something?
I've tried meshes with bigger resolution both for the surface,the object mesh and collision and the behavior seems to be the same.
With boxes it works better, I think its because all 4 corners of the face are touching the surface?
An example below showing the reaction of the same box and sphere in 3 different friction levels.

The 0.1 seems to be correct, it's being blocked by the wall but I assume it would go even further.
The 0.4 seems ok.
The 1 acts almost the same as 0.4,with small difference even being more than the double of it.

Thank you very much.
Steps to reproduce

Create a RigidBody3D with A sphere and a collision. You can add a little of angular and linear damping to help;
Create a StaticBody with a mesh for the floor ,a collision and add a physics material with friction=1;
Put the Sphere RigidBody3D on top of the floor and add a impulse to it;
Possibly the sphere will run through the surface like it had almost no friction on it;

Minimal reproduction project (MRP)
SphereFriction.zip

I'm not sure how realistic the physics simulation is, but in a realistic situation this would be expected, as friction affects objects based on the area of contact, a sphere has less friction against the surface because it's a smaller area touching

I'd say this reflects real world experiences, rolling a ball across a surface is much easier than pushing a box
But physics is very unintuitive in these ways, so it's hard, but at least for a rolling ball I'd absolutely expect less effect from friction

If you need more predictable friction behavior, I suggest enabling Custom Integrator and programming it yourself in _integrate_forces(). This is strongly recommended for character controllers, as the default RigidBody behavior is really meant to be used for "inert" objects as opposed to player-controlled objects.

Reopening, as this should be documented.


Update sonos extension

Description

I have added a setting to adjust the speed at which the volume changes. I noticed the need for this when I set up a global keyboard shortcut for adjusting the volume of songs, and found that I had to press the key multiple times to notice a volume change.
The new options offer three levels:

Slow (for finer control)
Medium (for balanced control)
Fast (for quicker adjustments)

These correspond to 1, 5, and 10 steps, respectively.
I can now set mine to "Fast" to swiftly adjust the volume using my keyboard shortcut.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Nice, I've been meaning to make this a user setting at some point! My initial reaction to the naming was that perhaps something like small, medium, large would go better with volume step. What do you think?


For malformed /send requests, the reason for the rejection should be included

Describe the Bug
When my web browser makes the following API request, initiated by Umami, the response is only a 400 (header, with no body). Fortunately, when trying to reproduce this bug to share it with you fine folks (LOVE this product, btw!) I hit "Copy as cURL" in Chrome, which yields this cURL command:
curl 'https://api-gateway.umami.dev/api/send' \
  -H 'accept: */*' \
  -H 'accept-language: en-US,en;q=0.9,ja-JP;q=0.8,ja;q=0.7' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'origin: https://devnear.me' \
  -H 'pragma: no-cache' \
  -H 'priority: u=1, i' \
  -H 'referer: https://devnear.me/' \
  -H 'sec-ch-ua: "Google Chrome";v="129", "Not=A?Brand";v="8", "Chromium";v="129"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "macOS"' \
  -H 'sec-fetch-dest: empty' \
  -H 'sec-fetch-mode: cors' \
  -H 'sec-fetch-site: cross-site' \
  -H 'user-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36' \
  -H 'x-umami-cache: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6IjE1NzA1MzgzLTc1NmMtNTBjMC05YzI0LWRiZWEzYWI0NmU4MyIsIndlYnNpdGVJZCI6ImJkYWI4YzNjLTU2NDMtNDA0NS05NWFmLTBjZTk1YzEwNGFiOSIsInZpc2l0SWQiOiI5NWM4Nzc4Ni0zNTgwLTU2NmItYjg4MS1mMWUwNDBlOWU5MjciLCJob3N0bmFtZSI6ImRldm5lYXIubWUiLCJicm93c2VyIjoiY2hyb21lIiwib3MiOiJNYWMgT1MiLCJkZXZpY2UiOiJkZXNrdG9wIiwic2NyZWVuIjoiMjU2MHgxNDQwIiwibGFuZ3VhZ2UiOiJlbi1VUyIsImNvdW50cnkiOiJVUyIsInN1YmRpdmlzaW9uMSI6IlVTLUNPIiwiY2l0eSI6IkRlbnZlciIsImlhdCI6MTcyNzY5NjczMH0.-koBRPnJnIsODP-WakY_AAKL3k37ZtG6yokcbT4ZWdY' \
  --data-raw '{"type":"event","payload":{"website":"bdab8c3c-5643-4045-95af-0ce95c104ab9","hostname":"devnear.me","screen":"2560x1440","language":"en-US","title":"Meet%20Near%20Me%20-%20Home","url":"/?address=National+Mall,+Washington,+DC&categories=bocce+ball&start_time=2023-10-18T10:00:00Z&end_time=2099-10-18T10:00:00Z&radius=4200&address","name":"event-list-click-924b3158-8c8d-42cc-ba02-d94c27467fb5","data":{}}}'

The good news is, this cURL request sends back a response that actually explains the problem:
payload.name must be at most 50 characters

The fact that javascript (browser client) isn't able to read the response body feels like an error in your https://cloud.umami.is/script.js logic to me
Database
PostgreSQL
Relevant log output
No response
Which Umami version are you using? (if relevant)
Cloud
Which browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
No response

I am a novice, the latest version of the code on the master I pulled directly is 2.13.2, and there are still /api/send 400 problems after copying the tracking script to the target website, i dont known why, there is my script

Actually @Georgiafab try making your data-umami-* DOM attribute names very small. That fixed it for me

@brianfeister i dont use data-umami-* DOM attribute , I'm stuck on step one i only use the script ,it responent 400 in my website, it my website url https://redesign86.com


[UI] Window controls overlap back arrow on MacOS

Image Link
Top left corner.
Android messages just updated to 2.0.
Running MacOS Mojave 10.14.5

Same here in macOS Sierra 10.12.6


Repo setup

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fe2305e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #13   +/-   ##
=========================================
  Coverage          ?   43.26%
=========================================
  Files             ?        4
  Lines             ?      104
  Branches          ?        0
=========================================
  Hits              ?       45
  Misses            ?       59
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2305e...2693d6e. Read the comment docs.


devx + fix compilation

@uhbif19 how come it compiles at your end without ViewPatterns?

Copied your devx changes into branch and added ViewPattern with cabal.


added options for hard and soft process limit configuration

Similar to the filehandle limits, we're looking to set hard & soft process limits separately as well. Should be able to merge in without affecting anyone's current configs.
(same as our previous https://github.com/bmhatfield/chef-ulimit/pull/17 , but this time there shouldn't be any weird git issues).

Thank you for this PR! This appears to be superseded by https://github.com/bmhatfield/chef-ulimit/pull/25, which I will work on merging next.


Updated to Version: <IP_ADDRESS> and now my log is riddled with errors.

Good morning Everyone,
I've come across something I haven't experienced before, and I can't get cabernet working again. I wiped my docker install like I've done many times in the past (reusing docker compose and config.ini), reselected my channels in the editor like I've done before and when trying to look at the stream I get nothing.
Here's my log:
cabernet.log
On a side note, I know there are some issues with docker and Cabernet doing seamless updates and I know @cookieisland has a work around, and that's great, in fact, I will have to go with his route soon before I drive myself silly. LOL
BUT, at the end of the day, I like things to work the way they are intended; I don't know if it's some form of OCD, or the fact that in my older days I'm turning into a purist. I recently started using Docker because it was simple, self-contained, & intuitive. So, I would like to respectfully ask, Would anyone be opposed to getting outside help to get the docker to update properly?
I'm still loving Cabernet and I think it's amazing, I just thought if it could update that way it supposed to, that wouldn't be a bad thing.
Thx in advance for helping me out with this one.
EDIT: I changed the stream type to internal proxy from streamlink and it is working again. So, I think this has something to do with using streamlink and version <IP_ADDRESS> of Cabernet.

First it says you have Memory Usage enabled in the config.ini file.  This is used to map memory leakage and would not recommend having it enabled and just using a ton of CPU.  For whatever reason you turned it on, I would recommend turning it off in Settings > Internal > Main > Memory Usage
All the mux stuff in 0.9.13, forgot to test the streamlink. Will take a look and push out a change.

Update with streamlink exception fix in <IP_ADDRESS>

Last advice.  Your streamlink executable is terminating during its startup.  Not sure why; it is hard to get the STDERR output on these processes.  I would check the version of streamlink; it should be 5.3.1.  Make sure your path in Cabernet is either no path "streamlink" or has a full path to the streamlink executable you want to use "/path/to/streamlink".
If you are still having issues with streamlink, I can give you the command line Cabernet uses and you can try it on the command line to see if you get any errors...

Thx a bunch for the advice @rocky4546 :)
I already disabled the memory usage and I will edit out those ports in my docker compose file right now.
Have a great day and thx again.


heroku causes infinite loop with appcache file

A appcache/appcach path is being added in an infinite loop in heroku server logs
Please see issue here: http://stackoverflow.com/questions/37581134/heroku-react-appcache-file-causes-infinite-loop

Ok I found out it only cause the infinite loop with http and not with https. Weird?

Ok it happens on safari if it's http or https

Having the same issue on Safari (http or https), everything is fine on others browsers.

Hmm, I've never had that issue before and I'm running on a 5$ DO Droplet. Any ideas what could be causing this?

After some digging, I found out that it only occurs when the location's path has at least 2 levels (such as /post/:id or /post/new for example).
The (weird ?) thing is that it doesn't occurs when I navigate to such a route, but only when I reload the page being already on this route.
I hope you understand what i'm trying to say, if not I'll try to explain it with more specifics.

Hm, weird. What does you route configuration look like?

Something like that mostly:
{
      path: '/',

      getComponent(nextState, cb) {...},

      indexRoute: {
        getComponent(nextState, cb) {...},
      },

      childRoutes: [
        {
          path: 'work',
          getComponent(nextState, cb) {...},
        }, {
          path: 'work/:slug',
          getComponent(nextState, cb) {...},
        },
      ],
    }

Something like that mostly:
{
	path: '/',

	getComponent(nextState, cb) {...},

	indexRoute: {
		getComponent(nextState, cb) {...},
	},

	childRoutes: [{
		path: 'work',
		getComponent(nextState, cb) {...},
    }, {
		path: 'work/:slug',
		getComponent(nextState, cb) {...},
	}]
}

I honestly have no idea how to fix this, and I also don't much experience with Heroku, so I won't really be of help here. Has anybody fixed this issue yet?

I have this same issue on my local when I try to get the boilerplate working in a subdirectory. I changed the publicPath in webpack base and that got most stuff working. Except for webfonts and appcache.
In my case, I have the app installed at: http://example.com/wp-content/themes/build/ as a WordPress theme pulling in content using a Rest API. This works fairly well so far.

I moved the appcache folder to the root, and that seemed to fix it, but then just like OP, if I start fresh from a rewritten subdirectory, it goes haywire again. So http://example.com is fine, but then http://example.com/donate gets batty.

I haven't gotten to the bottom of this yet, but, in case it helps point someone else in a useful direction.
We are using this offline plugin library.
https://github.com/NekR/offline-plugin
It is configured in prod webpack config. You can add a publicPath variable in the settings. I know it has to be relative and cannot be absolute, but I am not sure about much else.

I seemed to have fixed it by turning off appcache.
I looked up appcache and MDN say's it shouldn't be used anymore https://developer.mozilla.org/en-US/docs/Web/HTML/Using_the_application_cache
So in offline-plugin config in internals/webpack/webpack.prod.babel.js  I added appcache: false
    new OfflinePlugin({
      relativePaths: true, // Use generated relative paths by default
      // No need to cache .htaccess. See http://mxs.is/googmp,
      // this is applied before any match in `caches` section
      excludes: ['.htaccess'],
      AppCache: false,

      caches: {
        main: [':rest:'],

        // All chunks marked as `additional`, loaded after main section
        // and do not prevent SW to install. Change to `optional` if
        // do not want them to be preloaded at all (cached only when first loaded)
        additional: ['*.chunk.js'],
      },
    }),

What @mlennie recommends seems to be very sensible, I think we should turn it off by default. AppCache really won't be supported for much longer and should only be used if legacy support is 100% needed, so turning it off by default should be fine.
Would somebody care to submit a PR? Thanks!

@ThomasMarnet Curious if you've had success using childRoute with the importModules setup in this boilerplate?

Done by the amazing @sethmcleod in #791! 🎉


Adding http(s) only support

https://ngrok.com/docs#bind-tls

You can pass any argument you want and do that.

I specifically meant with ENV variables. I know I can define my own command, but its less user-friendly.

I assume you still wont add this?

I'm not planning to add ENV variable. I wonder why you think it's more friendly though.


Dark Mode

It would be great if the widget supported dark mode colors.

I'm sorry for the late reply. the EasyDateTimeLine has itemBuilders that allows for full customization of the timeline items. if you have a UI you can reply with image and i can help you achieve what you want

no It's alright I did manage to customize it well, was just thinking if it could support native brightness like material widgets. maybe I'll do a pr in the future. amazing package though  👍


Merge refs/heads/feature/aggregations into alpha

Merge refs/heads/feature/aggregations into alpha

This PR has been merged into alpha and tagged as 1.7.0-alpha-202307081005. Thanks for your contribution!


Error : "No Metadata Found" should not prevent polling

Is not clear whether it can be fixed or no (and how). So estimation includes initial investigation

@zubairov Our understanding of the issue:
'No out metadata found to create select fields from' message appears when something is wrong with Salesforce API which is responsible for metadata providing.
Select query for the polling trigger is being built from the metadata retrieved from Salesforce API.
Hence, it's impossible to create a query without metadata and the trigger can't work in this case.
So don't see any sense in this issue.
Any thoughts?

Trigger code was refactored.
used construction
await conn.sobject(cfg.object)
        .select('*')
        .where(`LastModifiedDate > ${snapshot}`)
        .execute({maxFetch : 100000}, processResults);

but function select calls describe api  method too.
So - need more investigation:
Workaround:
get Id of each changed entity and fetch each object by internalId using retrieve
But need investigation about api calls which makes retrieve function

Unfortunately, jsfoce hasn`t the opportunity to select objects without a list of object fields. So we should ask metadata of objects before query to sobject API.
Selecting all objects by id,s  is a very expensive operation for the component.
As a workaround, I can suggest implementing a new smart trigger.
the main idea: trigger subscribes to changes during flow starting.
we can use Salesforce Tooling API for it.
Using this API we can deploy our custom trigger code, which can call our webhook endpoint after object create/change event.
And also we can delete this trigger code during flows stopping.

Example of salesforce ApexTrigger:
https://blog.jeffdouglas.com/2009/03/16/restful-web-service-callout-using-post/


fix #3224

coverage: 92.84% (+0.006%) from 92.834%
when pulling aa860148ad3e5ab499b7c1536fa50d83ad453ba3 on antgonza:fix-3224
into daf33197601058c881b882f37d5422ae12cb6df7 on qiita-spots:dev.


[FR] Specify additional packages to be installed without rebuilding the Docker image

Is your feature request related to a problem? Please describe.

Brokerpaks sometimes need additional binaries installed in the environment where Terraform runs.

Terraform code sometimes makes use of provisioners to call specialized binaries at particular points during terraform apply.
Some Terraform providers are basically just wrappers around CLI binaries.

For example, in the AWS EKS brokerpak we're writing, we may need to be able to call kubectl or helm or aws to get specific things done. However, these binaries don't exist in the cfplatformeng/csb Docker image.
Describe the solution you'd like

It's unreasonable to ask the CSB team to make the image a kitchen-sink of tools that brokerpak authors might need. So instead I'd like to see a mechanism to specify additional packages to be installed at container start time. For example, if we could specify -e "ADDITIONAL_PACKAGES=kubectl helm aws" to docker run, that would work well.
Describe alternatives you've considered

Using custom images in government work comes with additional security/compliance baggage, and we try to avoid that wherever possible by using official images that get signed when they're built by Docker Hub.
To add the binaries to the Terraform environment on our own, we have to either rebuild the image or derive from it in a custom one, even though the only change is to add a single RUN apk add --update kubectl helm aws line.
Alternatively, we could do the equivalent of
RUN apk update
RUN apk upgrade
RUN apk add --update kubectl helm

...as a startup command. This feels like cheating, though. ;)
Additional Context

Priority

Medium
Priority Context

We can build our own image as described above for now, but we'd like that to be unnecessary by the time we start getting audited for gov compliance (mid-Feb or so). Our team successfully getting to production with a compliant EKS brokerpak would set precedent for a lot more authoring of brokered services and use of Cloud Foundry/OSBAPI (in the form of cloud.gov, or agency-specific deployments of PCF) in government.
Platform

AWS in this case, though it's not relevant for the feature request.
Applicable Services

AWS EKS in this case, though it's not relevant for the feature request.

Hello,
I think the better way is to rebuild the own image. In my case, I need python3 (used in local-exec provisionner), I have created the following docker file. Simple and efficient :)
FROM cfplatformeng/csb:latest

RUN true \
    && apk add python3 \
    && apk add py3-pip \
    && pip install requests\
    && true

Denis


Unable to debug with Chrome after updating to VS Code 1.95.1 - freezes if any breakpoint is set

Type: Bug
I'm using Aurelia v1.0 to develop a web application I've been working on for a long, long time.  I've had no problems with debugging until VS Code 1.95.1.  At the time I updated to 1.95.1, I had performed no NPM updates, or any other updates.
Also, I'm using WebPack.
Updating to VS Code 1.95.2 did not solve the problem, as I had hoped.

With a Chrome launch configuration, launch the debugger.
If any one breakpoint is already set, the url destination spin-waits.
If no breakpoints are set upon launching, the application loads and it works fine so long as no breakpoints are subsequently set.
Then, set a breakpoint.
Application will freeze if any action would cause the breakpoint to be accessed (not necessarily hit).

The last point is interesting.  I have a section of code that will execute when I click "New Pricing Line Item" in my application, which is where I set my breakpoint.  Even if I don't click that action, but simply try to load the section of code that contains the breakpoint, the application freezes.  It's as though the very loading of the code that contains the breakpoint causes the problem (not necessarily hitting the breakpoint).
I can reproduce this problem at will by following the steps above.
VS Code version: Code 1.95.2 (Universal) (e8653663e8840adaf45af01eab5c627a5af81807, 2024-11-07T11:07:22.054Z)
OS version: Darwin arm64 23.6.0
Modes:

System Info

Item
Value

CPUs
Apple M2 Max (12 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
1, 1, 1

Memory (System)
32.00GB (1.32GB free)

Process Argv
--crash-reporter-id 9cfcad7d-aa40-49e6-ad70-a4fe895ab775

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

Bookmarks
ale
13.5.0

copy-relative-path
ale
0.0.2

aurelia
Aur
2.1.4

Aurelia
beh
1.2.2

npm-intellisense
chr
1.4.5

path-intellisense
chr
2.9.0

vscode-eslint
dba
3.0.10

githistory
don
0.6.20

gitlens
eam
15.6.3

EditorConfig
Edi
0.16.4

prettier-vscode
esb
11.0.0

todo-tree
Gru
0.0.226

vscode-drawio
hed
1.6.6

vscode-css-navigation
puc
1.15.0

autoimport
ste
1.5.4

vscode-icons
vsc
12.9.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
9c06g630:31013171
dvdeprecation:31068756
dwnewjupytercf:31046870
newcmakeconfigv2:31071590
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013

/duplicate of https://github.com/microsoft/vscode/issues/232651 which is fixed in 1.95.2 that just released.

@gjsjohnmurray
This problem was not fixed with 1.95.2, as I indicated in my report.  I still cannot debug, and I can reproduce the problem at will, even after updated to 1.95.2.

as I indicated in my report

#233432