GDScript: Fix out of date errors in depended scripts

fixes the extremely annoying bug where a depended scripts interface wont update in the editor, leading to errors that can only be cleared up by restarting the editor
-- removes GDScriptParserRef from the cache when reloading a script to let other scripts that depend on it use that new stuff
-- and many other small changes to fix the weird issues that come with making and breaking circular references
fixes https://github.com/godotengine/godot/issues/81292

I feel like this iss working around a more fundamental problem with the cache.
Ideally, after the script that is being loaded is compiled, the parser cache should be empty. The only reason the cache exists is to avoid parsing the same script more than once in the same dependency tree, it is not supposed to keep stuff across different scripts being parsed. If it were working as intended, then there would be no need to swap any parser, because it would always have to re-parse the dependencies.
So, I'd like to focus on why the cache is not being cleared properly.

Ideally, after the script that is being loaded is compiled, the parser cache should be empty.

one script may trigger a reload on another script, while still needing the parser ref, making this tricky...
but if

it is not supposed to keep stuff across different scripts being parsed.

then each dependancy tree should have its own cache, this would really increase the number of times a script would need to be parsed and analysed

So, I'd like to focus on why the cache is not being cleared properly.

i agree the cache is not in the best state, but it was simply never programmed to do what ur saying it was only programmed to clear the parser ref when a script is removed
ive actually already rewritten the gdscript parser ref cache for a different thing i never made a PR for, i could do it in a few days
id also like to add that a bandaid can go with a structural change,

then each dependancy tree should have its own cache, this would really increase the number of times a script would need to be parsed and analysed

Assuming no parallel loading, only a single script would be loaded at a time. At the end of this script loading, the cache should be empty. That's the ideal scenario, it shouldn't increase the number of parses. With parallel loading it should work too, assuming there's no script being changed in the middle of it.
The bug itself manifest only when changing things in the editor, which should only be (re)loading a single script: the one being edited. Even if it's not, it should be starting with an empty cache anyway, so no outdated information would be available.
I understand that the current cache is quite subpar and needs to be refactored. My worry is that this PR is a bit complex and I don't know if it's going to create other bugs. For instance, all type refences to GDScript types point to a GDScriptParser::ClassNode, so if something suddenly deletes the parser, those references will be dangling. Especially if the cache is not being cleared properly, there might be some old parse tree referring to those stale pointers. I'm not sure if that would actually happen in practice, but it makes me hesitate to approve this change as it is.

For instance, all type refences to GDScript types point to a GDScriptParser::ClassNode, so if something suddenly deletes the parser, those references will be dangling

youre right, this is the exact problem i was trying to solve. its why this PR isnt only 5 lines of code

i moved the GDScriptParserRef references to a member of GDScriptParser, so their lifetimes are tied together, so when the last ref goes out of scope, it really is safe
there are only 2 times the GDScriptParserRefs are cleared and that is when a GDScript is removed, meaning all references to it are invalid and its ok to delete the cached parser tree, and when the entire cache is being cleared.

there isnt any other object lifetime the GDScriptParser class nodes are tied to
the bug then becomes: if a GDScriptParserRef gets removed from the cache due to a script reload, and another script tries to access the parser of a class node it has and it get the wrong parser (because reload was called somewhere inbetween) and errors out here:
https://github.com/godotengine/godot/blob/0030938098f220e2563c86a1c9f7f6fdcb697644/modules/gdscript/gdscript_analyzer.cpp#L340
and the solution i made was to only remove the parser from the cache when the hash of the source changes, which is very unlikely during dependant script reload
i think even if this isnt approved some of the changes in this PR solve the potential bug ur talking about.
as hard as it was to track down the issues, this was a simple one to solve, theres much more unnecessarily convoluted circular ref counting nightmares in the godot codebase, hopefully those get simplified too

If it were working as intended, then there would be no need to swap any parser

also the parser.swap() is not used for swapping parsers,, its just a little trick to reset the parser and let a copy of it go out of scope and get the tree cleaned up, i was annoyed with how the clear() method seemed completely out of date and wouldn't actually support calling parse() again (which could happen with this PR)

Assuming no parallel loading, only a single script would be loaded at a time. At the end of this script loading, the cache should be empty. That's the ideal scenario, it shouldn't increase the number of parses

when loading an actual game, it would need possibly dozens of scripts, each would have a parser ref cache of its entire dependancy tree, some of the dep trees would be very similar... leading to multiple of the same script being parsed and analyzed for different scripts
it seems like the parser dependancy cache your're talking about would be geared toward multithreaded loading of scripts

removed the swap method as it was a confusing way to clear the parser

Okay, I guess I did get confused by the swap method. I'll do a proper review now, perhaps we can have this as a bug fix while we refactor the semantics of the cache.

when loading an actual game, it would need possibly dozens of scripts, each would have a parser ref cache of its entire dependancy tree, some of the dep trees would be very similar... leading to multiple of the same script being parsed and analyzed for different scripts

I see what you mean, but for me that's not really an issue. It might be a "problem" if you are loading many scripts in a short amount of time (I say "problem" in quotes, because I don't think parsing is slow enough to benefit greatly of this). If you load one now and the next one only, say, five minutes later, is it worth keeping all the parse trees in the cache? I do understand that during runtime the scripts don't change the source code, so keeping the parse tree is somewhat beneficial in terms of load time, but I'm not sure if it's worth the extra memory. In the end is another hard problem with cache all over again.

It might be a "problem" if you are loading many scripts in a short amount of time

i do want to point out that that games will do this on startup .. ive profiled the engine startup on the game im working on and parsing and compiling gdscript is a not insignificant chunk of time already

Thanks!

I bisected a regression when trying to port Dialogic from 4.2 to 4.3 and this commit seems to be the culprit.
Here's the MRP:
reprobug.zip


HBASE-25731 - TestConnectionImplementation BadHostname tests fail in …

…branch-1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
12m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 54s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 53s
branch-1 passed

+1 :green_heart:
shadedjars
3m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 16s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 12s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 45s
the patch passed

-1 :x:
checkstyle
1m 44s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  8s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  1s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  7s
the patch passed

_ Other Tests _

-1 :x:
unit
111m 27s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 30s
The patch does not generate ASF License warnings.

167m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3120

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux f1fb37077ddf 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3120/out/precommit/personality/provided.sh

git revision
branch-1 / 7851df7

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/testReport/

Max. process+thread count
3320 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Is the unit failure related?
Please fix the checkstyle warning.

@Reidddddd - I fixed the checkstyle issue. I'm having trouble seeing which tests failed (only that some forks crashed), but since the change is only to a single test file, I don't see how this patch could be breaking anything else.
Unfortunately the test run did not exercise this test because it's in the exclusion list (I assume because it's been broken a long time.) Will that be removed from the exclusion list automatically if it starts passing or is that an extra step I need to take as part of this patch?
Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
5m 38s
Docker failed to build yetus/hbase:edccfe439a.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/3120

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The most recent failure appears to be a Yetus issue with setting up the docker container

I need to take as part of this patch?

No need

Checked other classes, I think com.google. should be at the bottom of the import orders
Could you please update it and trigger QA again.

because it's in the exclusion list

Where did you see it, could you point it out?

@Reidddddd - look for -Dtest.exclude.pattern in https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt to see TestConnectionImplementation is on the excluded list
Also the import order seems to be inconsistent (e.g HTablePool has the protobuf imports at the end, while HTable and many other classes have them alphabetized).

-Dtest.exclude.pattern in https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/1/artifact/out/patch-unit-hbase-server.txt

Oh, no worry about this.

Also the import order seems to be inconsistent

I think some are legacy. Please put it at the bottom, we need to re-trigger the QA anyway.

BTW, is it passed on your local laptop, after your fix?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 58s
branch-1 passed

+1 :green_heart:
compile
0m 42s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
checkstyle
1m 56s
branch-1 passed

+1 :green_heart:
shadedjars
3m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 43s
branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+0 :ok:
spotbugs
3m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 14s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  6s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
checkstyle
1m 46s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 59s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10

+1 :green_heart:
findbugs
3m  7s
the patch passed

_ Other Tests _

-1 :x:
unit
122m 14s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

167m 29s

Reason
Tests

Failed junit tests
hadoop.hbase.master.cleaner.TestSnapshotFromMaster

hadoop.hbase.regionserver.TestHRegion

hadoop.hbase.namequeues.TestSlowLogAccessor

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3120

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux bac2681f7538 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3120/out/precommit/personality/provided.sh

git revision
branch-1 / 7851df7

Default Java
Azul Systems, Inc.-1.7.0_272-b10

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/testReport/

Max. process+thread count
3338 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3120/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

OK, LGTM. Failed test are not related.
One more thought, do we have to use protobuf.generated here? could we just general client api?

@Reidddddd - yes, TestConnectionImplementation passed locally for me. The patch uses protobuf RPC calls because the original version of the test was exercising the protobuf interface (grabbing the Admin or Client service object).
The change is that some previous version of the Connection object internally made a call to verify the hostname upon a getAdmin or getClient call, and more recent versions appear to wait until the client makes their first call to check.


https://github.com/typings/typings/issues/250 build script works on windows (changed rm -rf with rimraf)

https://github.com/typings/typings/issues/250 build script works on windows (changed rm -rf with rimraf)

LGTM, thanks :+1:


WIP: Add Allow-/Block-List for Migrate & Mirrors

This PR will add two options blacklist and whitelist for migrating repositories from external URLs.
When you set whitelist then blacklist will be ignored and all users on this gitea instance could only migrate repositories from the domains on whitelist.
When whitelist is empty and you have domains on blacklist, all users on this gitea instance could migrate repositories any domain except the domains on blacklist.

original pull: #8040
is WIP untill I had a look and moved things to new terms allow/block

Codecov Report

Merging #13610 (dec70f1) into master (9ec5e6c) will increase coverage by 0.00%.
The diff coverage is 48.93%.

@@           Coverage Diff           @@
##           master   #13610   +/-   ##
=======================================
  Coverage   42.19%   42.19%
=======================================
  Files         696      699    +3
  Lines       76541    76609   +68
=======================================
+ Hits        32293    32326   +33
- Misses      38945    38974   +29
- Partials     5303     5309    +6

Impacted Files
Coverage Δ

modules/setting/migrate.go
0.00% <0.00%> (ø)

routers/init.go
51.21% <0.00%> (-0.85%)
:arrow_down:

modules/matchlist/matchlist.go
41.17% <41.17%> (ø)

modules/migrations/migrate.go
26.84% <66.66%> (+5.28%)
:arrow_up:

routers/routes/chi.go
35.84% <0.00%> (-3.01%)
:arrow_down:

routers/routes/macaron.go
92.53% <0.00%> (-0.25%)
:arrow_down:

modules/httpcache/httpcache.go
0.00% <0.00%> (ø)

modules/setting/setting.go
46.12% <0.00%> (+0.11%)
:arrow_up:

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec5e6c...dec70f1. Read the comment docs.

@lunny it's ready to look at :tada:

Still need to update app.example.ini with new names.

Still need to update app.example.ini with new names.

Is that now fixed?

Yes those look fine now.

:rocket:


"azsphere device prep-sideload --enablertcoredebugging" is not a valid command line option

With the 19.10 version of the SDK, I get this error when I run the command above:
'prep-sideload' is not a valid value for the 'Operation' command line option.
Possible argument values include: 'app', 'capability', 'claim', 'enable-cloud-test', 'enable-development', 'image', 'list', 'list-attached', 'manufacturing-state', 'recover', 'restart', 'show', 'show-attached', 'show-count', 'show-deployment-status', 'show-os-version', 'sideload', 'update', 'wifi'.
Unrecognized command line argument '--enablertcoredebugging'.
I believe the correct command as per the --help text is:
azsphere device enable-development --enablertcoredebugging
However that command requires admin privileges.  Why would that require admin?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57a9ebb5-700e-4490-11de-66a0b0fbf07a
Version Independent ID: f6ab3c9c-906b-928a-a997-698e9738a11f
Content: Build a real-time capable application with Visual Studio quickstart- Azure Sphere
Content Source: AzureSphere/articles/install/qs-real-time-application.md
Product: azure-sphere
GitHub Login: @pennyo
Microsoft Alias: azurespheredocs

@Gilgamesh82 Thanks for the feedback!  We are currently investigating and will update you shortly.

@Gilgamesh82 The documentation accurately describes the contents of the 19.10 SDK, which was released recently. Yes, you are correct. we are in the process of updating the documentation and changes will be available as earliest. Please see What's New to learn about new features and how to update your installation.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

To expand on the answer: the --enablertcoredebugging option requires admin privileges because setting up for RT core debugging requires the installation of software that, in turn, needs admin privileges.


Legend Widget - Not showing all labels

Issue: Occasionally the legend widget does not list every style shown on the map.

Additional Note: After investigating this issue further, it appears to be caused when a feature has multiple style rules applied but the final style rule doesn't provide a legend layer label. As a result, I don't think this qualitifies as a bug anymore.


Fixed the plugin.

I went ahead and fixed the Discord plugin for you. The version has been incremented to v0.1.1 as a result, although you may change this to suit you. In addition, here is a list of additional notes which you should know:

I made sure to follow a similar approach to your original implementation for the plugin, so that this new version still "abides by" Discord's ToS. This restriction admittedly makes it difficult to gather more information regarding the user's account, but users should be safe when using it.
The method for scraping Discord has been altered drastically, and all dependencies on trio have been removed. However, the plugin now depends on the websocket-client module. All necessary modules are included in the release below.
The current structure of the plugin is not very organized. If I were you, I would look into making the design object-oriented to improve clarity. There would not be many separate .py files for this plugin, since it is not as complicated as most others, but every bit of organization and flexibility helps.
The current method for re-authenticating the user is not sufficient. Here is the current implementation:

async def ensure_discord_scraped(self):
    if not self.user_email:
        await self.scrape_discord()

The main reason as to why this implementation is flawed is that it does not account for any changes to the user's account. For instance, suppose that the user adds a Discord friend after authenticating with the plugin. This new friend would not appear on Galaxy 2.0, since the plugin would determine that it does not need to re-authenticate the user because self.user_email is defined. I offered some possible solutions to this in the comments below this method (check discord.py).

This version of the plugin is by no means a finished version, and there are still improvements that could yet be made. For instance, try to detect the user's Discord installation path so that they do not need to launch Discord before authenticating with your plugin. I am not sure of a Mac solution, but a great idea for Windows would be to make use of the Windows Registry to check uninstall registry keys. If you ever have any questions regarding how to make certain improvements, take a look at other plugins (such as my Rockstar plugin at https://github.com/tylerbrawl/Galaxy-Plugin-Rockstar) or feel free to ask me or other developers. This community has been very helpful to me while I have
been developing my own plugin!

This is all that I can think of for now. I will attach a working build to the bottom of this post (Discord.zip), which you can publish as a release for v0.1.1 (or whatever you decide to call it). When you release this new version, make sure to notify @Slashbunny for their GOG Galaxy Plugin Downloader, located at https://github.com/Slashbunny/gog-galaxy-plugin-downloader. Keep up the great work, and sorry for the long wall of text!
Discord.zip

Wow this is actually much better (and much more working) code
I left the project more as a "Proof of concept" in this bad state, and also because i ran into a few problems (compatibility between asyncio and trio), i'll test the code and merge the pull request
and really big thank you for dealing with this bad code i wrote ;P

Don't worry about it; we all have to start from somewhere. I am just glad that I could help.

Recently, I have been thinking of creating a plugin for Discord that uses their official API to gather user information. (The link to their API documentation is here: https://discordapp.com/developers/docs/topics/oauth2.) The only problem with this is that currently, the only way to get a user's friends from Discord is to have the application be whitelisted by them, and I believe that they are no longer accepting applications for this whitelist.
Thus, I was planning to use a hybrid between this plugin (to get the user's friends from the local client) and a new plugin. (It should also be optional for the user to decide whether or not they wish to scrape the local Discord client, since the list can become outdated if they do not re-authenticate it themselves.) It would be a great workaround until the ability to get a user's relationships is granted to all applications.
Would you like to support this new plugin? I was going to create an entirely new repository for it outside of this one.

I initially tried to implement this using the official API, but i couldn't get anything useful out of the API (except from joined guilds).
But maybe I missed something?

That's interesting. If I make any progress with it, then I will let you know.

Sorry that i kept this pull request on hold for so long, i didn't get access to any windows pc to test it :/


Create a private operator-registry for Kabanero

This may or may not end up being a tactical solution.  The Kabanero CSV, CRD and pacakge yaml should be published to a private registry that the install script can use to install Kabanero via OLM.
This may be replaced with a Kabanero install from the OpenShift Catalog, or certified-operators, later.  However at least for the time being, this allows us to have OpenShift read in the Kabanero CSV and get the OpenShift console integrations that will help Todd (and Champ) view their Kabanero instances.
We should update the build-image and push-image targets of the Makefile, to additionally push the registry.

Resolved by #251


Delete orphaned versions

Description of change
This adds a new command delete_orphaned_versions which deletes all the reversion.Version records related to objects no longer in the database.
reversion.Revision records without versions are deleted as well.
--model_label can be passed in to specify the model(s) to consider.
All models are used if model_label is not passed in.
Checklist
~* [ ] Have any relevant search models been updated?~
~* [ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?~
~* [ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?~
~* [ ] Has the admin site been updated (for new models, fields etc.)?~
~* [ ] Has the README been updated (if needed)?~

Not sure about the command name, another option could be delete_unreferenced_versions.

Codecov Report

Merging #1031 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop   #1031      +/-   ##
==========================================
+ Coverage    96.48%   96.5%   +0.02%
==========================================
  Files          211     212       +1
  Lines         5861    5896      +35
  Branches       560     565       +5
==========================================
+ Hits          5655    5690      +35
  Misses         142     142
  Partials        64      64

Impacted Files
Coverage Δ

...up/management/commands/delete_orphaned_versions.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75810f...0c009e0. Read the comment docs.


[Feature Request]: Update the Gemini 1.5 pro version to support image video together

Problem Description
the Gemini 1.5 is avaialbe now, one model support all media now.
Solution Description
the Gemini 1.5 is avaialbe now, one model support all media now. Can we do the update accordingly, then we don't need the Gemini pro vision anymore！thanks your help
Alternatives Considered
No response
Additional Context
No response

Problem Description
the Gemini 1.5 is avaialbe now, one model support all media now.
Solution Description
the Gemini 1.5 is avaialbe now, one model support all media now. Can we do the update accordingly, then we don't need the Gemini pro vision anymore！thanks your help
Alternatives Considered
No response
Additional Context
No response

not possible for video, because there is no storage for handling it

These issues already raised in anothertopic


Remove TrustedProvider part 1

What was wrong?
fix step 1 of https://github.com/ethereum/trin/issues/755
How was it fixed?
By removing TrustedProvider. I will make a part 2 PR for Step 2 since big PR is scary for reviewers.
Tests validate_block_body/validate_receipts since they relied on mock infura which we no longer support
To-Do

[x] Add entry to the release notes (may forgo for trivial changes)
[x] Clean up commit history

Just a quick note that you should also go through the setup docs and remove all of the infura stuff in there

Ok I made a commit resolving that concern under [Remove documentation referring to infura and trusted provider](https://github.com/ethereum/trin/pull/756/commits/34a0a50a3497911218f6095ebbdd6dfe8235ed73) hopefully that makes it easier to check


Lint: Use Object#in? instead of multiple comparisons

This one is arguably more subjective, and (given foreknowledge/sensing of what Object#in? does) makes code more terse and natural to read. Followup to #8723.
+ raytracer sample bugfix

I don't see this as controversive. If we didn't think Object#in? was good to be used, I'd argue we shouldn't have added it in the first place.


python312Packages.aioairzone-cloud: 0.5.3 -> 0.5.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.aioairzone-cloud is: Library to control Airzone via Cloud API
meta.homepage for python312Packages.aioairzone-cloud is: https://github.com/Noltari/aioairzone-cloud
meta.changelog for python312Packages.aioairzone-cloud is: https://github.com/Noltari/aioairzone-cloud/releases/tag/0.5.4
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.5.4 with grep in /nix/store/j94a5n8ldiaa0vr3sja3wfpsfnj8l0hj-python3.12-aioairzone-cloud-0.5.4
found 0.5.4 in filename of file in /nix/store/j94a5n8ldiaa0vr3sja3wfpsfnj8l0hj-python3.12-aioairzone-cloud-0.5.4

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath

home-assistant-component-tests.airzone_cloud
python311Packages.aioairzone-cloud
python312Packages.aioairzone-cloud

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/j94a5n8ldiaa0vr3sja3wfpsfnj8l0hj-python3.12-aioairzone-cloud-0.5.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.aioairzone-cloud https://github.com/r-ryantm/nixpkgs/archive/ac2e197f44a958875bf25da1056d367d7b1af0f0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ac2e197f44a958875bf25da1056d367d7b1af0f0#python312Packages.aioairzone-cloud

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j94a5n8ldiaa0vr3sja3wfpsfnj8l0hj-python3.12-aioairzone-cloud-0.5.4
ls -la /nix/store/j94a5n8ldiaa0vr3sja3wfpsfnj8l0hj-python3.12-aioairzone-cloud-0.5.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

Maintainer pings
cc @fabaff for testing.

Superseded by https://github.com/NixOS/nixpkgs/pull/326562


question on plugin?

how can I update the Shared preferences plugin?

Go to the terminal and run this line of code?
$ flutter pub add shared_preferences
This will add a line like this to your package's pubspec.yaml (and run an implicit flutter pub get):
dependencies:
shared_preferences: ^2.0.15
thanks.

For more context, share the error you're getting

There is a lot of errors, but first please tell me about this code: "https://github.com/SongTube/SongTube-New" - Is this newer version of this above code or what?


Help Mithril

[ ] Kes key signing
[ ] stake snapshot all pools

Closing in favour of #4570 and #4553


Sorting a Queue without extra space in C++

💥 Proposal
(A clear and concise description of what the proposal is.)
Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Yes

/assign


After fresh install and update of the CLI, it reports a new version available for sfdx-cli but will not update it

Summary
After fresh install and update of the CLI, it reports a new version available for sfdx-cli but will not update it.
Now, when running any SFDX CLI command, a warning is displayed :
Steps To Reproduce:

This issue is independent of the SFDX project
Fresh install MacOS Big Sur
Fresh install SFDX from the MacOS binary from https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_install_cli.htm
Update SFDX CLI with sfdx update
Now run any SFDX command, eg sfdx version

Expected result
The command should NOT complain about an existing update available for sfdx-cli
Actual result
% sfdx version
›   Warning: sfdx-cli update available from 7.123.0 to 7.123.1.
sfdx-cli/7.123.0 darwin-x64 node-v14.18.1
System Information
% sfdx version --verbose --json
›   Warning: sfdx-cli update available from 7.123.0 to 7.123.1.
{
"cliVersion": "sfdx-cli/7.123.0",
"architecture": "darwin-x64",
"nodeVersion": "node-v14.18.1",
"pluginVersions": [
"@oclif/plugin-autocomplete 0.3.0 (core)",
"@oclif/plugin-commands 1.3.0 (core)",
"@oclif/plugin-help 3.2.3 (core)",
"@oclif/plugin-not-found 1.2.4 (core)",
"@oclif/plugin-plugins 1.10.1 (core)",
"@oclif/plugin-update 1.5.0 (core)",
"@oclif/plugin-warn-if-update-available 1.7.0 (core)",
"@oclif/plugin-which 1.0.3 (core)",
"@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)",
"alias 1.1.22 (core)",
"apex 0.3.0 (core)",
"auth 1.7.3 (core)",
"config 1.2.41 (core)",
"custom-metadata 1.0.12 (core)",
"data 0.6.3 (core)",
"dependencies-cli 2.0.1",
"generator 1.2.0 (core)",
"limits 1.2.2 (core)",
"org 1.8.3 (core)",
"salesforce-alm 53.0.0 (core)",
"schema 1.0.10 (core)",
"sfdx-cli 7.123.0 (core)",
"source 1.2.4 (core)",
"telemetry 1.2.8 (core)",
"templates 52.4.0 (core)",
"trust 1.0.8 (core)",
"user 1.5.2 (core)"
],
"osVersion": "Darwin 20.6.0"
}

so it now correctly updates to 7.124.0? There was just an issue when you had 7.123.0 installed, and 7.123.1 was latest?

Exactly.

Le 29 oct. 2021 à 22:17, Willie Ruemmele @.***> a écrit :
so it now correctly updates to 7.124.0? There was just an issue when you had 7.123.0 installed, and 7.123.1 was latest?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/forcedotcom/cli/issues/1260#issuecomment-955023808, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTAP5Z6YCK7EUT6WJNEC6TUJL6PJANCNFSM5G6W7JCQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

alright, I'll close this as it seems to be fixed in latest

I'm getting it and it is not on a patch version?

I have the same issue using sfdx update or sf update .  I get "Warning: @salesforce/cli update available from 1.73.0 to 1.74.7."

Same issue:

❯ sf version
›   Warning: @salesforce/cli update available from 1.73.0 to 1.74.7.
@salesforce/cli/1.73.0 darwin-x64 node-v18.15.0
  ~ ························································ at  12:17:58 pm
❯ sf update
@salesforce/cli: Updating CLI... already on version 1.74.7-e719c56
  ~ ························································ at  12:18:07 pm
❯ sfdx version
sfdx-cli/7.197.8 darwin-x64 node-v18.15.0
  ~ ························································ at  12:18:18 pm
❯ sfdx update
sfdx-cli: Updating CLI... already on version 7.197.8-077a68b
sfdx-cli: Updating sf... done


Add support for ng-cloak

Since Angular is being loaded in the footer, it is essential to include this CSS directive in the styles so ng-cloak can be effective.

project isn't maintained anymore, thanks for the pull request.


Merge Develop for v0.10

Do not merge until approved.

Coverage decreased (-0.2%) to 99.766% when pulling dd5f77a9ada74c2c477ba3fa33c03302840e0f06 on develop into 699a1969693c6df758460bc22309f68777ecc972 on master.


Propagate knowledge of docker-compose with apt-get

Thanks @NargiT, a good idea to put the workaround into the README.


Added an option to use all available cores while building with lto enabled.

When building with use_lto=yes, the option lto_multiprocess=yes will tell the linker to use all available cores con the system.
For example, on an i7 740QM this reduces build time by ~9 minutes.
This option is only available for gcc. AFAIK clang doesn't support this feature (someone correct me if I'm wrong).

More than a new option, I'd prefer that it uses automatically the number of cores specified to scons with -j.
If I build Godot with scons -j2 on a 4 core machine, I don't want the linker to use all 4 cores and maybe freeze my Firefox with JS-intensive gmail opened :P

I'm afraid I have no clue how to do that :/
In any case lto_multiprocess is opt-in (defaults to false).

scons -j has problems on windows machines, so unless this was resolved on Scons side, automatically defaulting to multi-core is not a good idea.

scons -j has problems on windows machines, so unless this was resolved on Scons side, automatically defaulting to multi-core is not a good idea.

There's no proposal to do that here. Just to respect the -j option if provided when running linking with LTO for GCC.

Changed to use the -j option.


Bitwise Shift in For Loop Breaks Syntax Highlighting

From https://github.com/Microsoft/vscode/issues/28167
TS and JS Grammar Extension version:  0.0.21
Code
for (var i = 0, length = 10; i < length >> 0; ++i) {
	var a = 10
}

This doesn't repro in grammar from latest master branch. The extension is not updated yet and I will update it soon.


Bad link for Build/Pass button in README file

I attempted to find the logs from the latest build of the develop branch.  When I selected the link to the builds (which the readme file says are "passing"), I was told the page did not exist.

Attempting to address with https://github.com/LLNL/Umpire/pull/915

Resolved


[ADP-3272] Consolidate generators and shrinkers for Map data type.

This PR creates a common home for generators and shrinkers of the Map data type.
Issue
ADP-3272

can confirm that this is a refactoring.

Great -- this is indeed what I had intended. 😄


Release 1.4.3

This PR is a preparation for the next release:

merge pending PRs
update doc and changelog
update CI (add GH actions) to tests and build wheels for all OSes/Pythons.

At this stage I have all the wheels built alright for #91 :tada: and #140
See artifacts in https://github.com/WojciechMula/pyahocorasick/actions/runs/1871630796
... I am still trying to get the tests to run too.

There is nothing super major there... so I am merging now that we have all tests passing everywhere.

@pombredanne Thank you very very much for carrying things out!


console depends ? for mac

console depends
The console plus doesn't have depends I use mac it only has windows depends missing package.json idk what it needs however the console doesn't respond or anything its just a black screen idk if its cause the depends that are missing it doesn't respond.
MultiOgar-Edited/run
logs on chrome browser :-
(index):178 WebSocket connection to 'ws://<IP_ADDRESS>:1234/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED (anonymous) @ (index):178
I fixed that but I still get many Error like it just crashes when I run it ect...
(index):54 WebSocket is already in CLOSING or CLOSED state.
`/Downloads/server/run/console-plus.js:189
var hst = ws.upgradeReq.headers.host;
^
TypeError: Cannot read property 'headers' of undefined
at WebSocketServer. (/Users/HamaShexler/Downloads/server/run/console-plus.js:189:31)
at emitTwo (events.js:126:13)
at WebSocketServer.emit (events.js:214:7)
at handleUpgrade (/Users/HamaShexler/Downloads/server/node_modules/ws/lib/websocket-server.js:89:16)
at WebSocketServer.completeUpgrade (/Users/HamaShexler/Downloads/server/node_modules/ws/lib/websocket-server.js:282:5)
at WebSocketServer.handleUpgrade (/Users/HamaShexler/Downloads/server/node_modules/ws/lib/websocket-server.js:221:10)
at Server.WebSocketServer._ultron.on (/Users/HamaShexler/Downloads/server/node_modules/ws/lib/websocket-server.js:88:14)
at emitThree (events.js:136:13)
at Server.emit (events.js:217:7)
at onParserExecuteCommon (_http_server.js:508:14)`

Use WS 2.3.1.

1 year passed

This project is only really meant to run on Linux and Windows.


TableEditor: Server-side table with pagination

We actually don't need pagination here since even from the server, we just grab the whole json file


Rename Arguments to AliasSeq for alias sequence

Because deep down, it is an alias of sequence. I dropped list as @WalterBright was against the terminology as it is tied to linked list.
I dropped CT (for compile time) as in fact, this is not always compile time. You can have a declaration with a sequence of type as type and a sequence of runtime values as value (it can be used to build tuples for instance).
We could add TypeSeq and ValueSeq if people feel the need (pretty much the same as Alias, but check it contains only types or values).

Well, I'm fine with the name, but it's going to take explaining. No one is going to understand what it is upon seeing it for the first time - though I doubt that anyone is going to understand how it works at first glance regardless of its name; the main problem is that we've had a name that specifically implies that it holds only types and that it's a tuple (neither of which is true). But whatever we name it, an explanation will likely be required.
The key problem with naming it seems to be that it does so many things that calling it anything in particular ends up implying that it's only used for one of its use cases (e.g. ArgList and ParamList both work, but since it can be used for both arguments and parameters, neither really makes sense). AliasSeq has the advantage of not contradicting any of its uses, but it also doesn't imply anything about how it's actually used either. I would prefer AliasList over AliasSeq, but if Walter doesn't like that, I guess that it won't fly.
I don't like the idea of creating additional aliases for its different use cases, but that's arguably a separate discussion.
Regardless, you need to sort out why the PR isn't compiling, or it obviously can't be merged.

Yes it does many things. This is why a new name for the best is needed. I do think we should have a page somewhere on dlang.org that explain the concept in more details.
I personally don't mind using Seq or List, but Walter told me at DConf that he was against the List thing, so I went with Seq. Fixing the PR now :)

Ok I forgot to change the name in the legacy std.typetuple module. Fixed.

Better than "Arguments": :white_check_mark:
Much better than "TypeTuple": :white_check_mark:

Ok we are starting to get some green.

I'm not sure what's up with CyberShadow's autotester. auto tester seems happy with the PR now.

I'm not sure what's up with CyberShadow's autotester. auto tester seems happy with the PR now.

Well, it says that git master isn't buildable, so I guess that a previous pull broke the documentation build, in which case, all PRs will be failing for the doc tester.

Not a big fan of this name. It's not an alias sequence, since they aren't all aliases.

It's better then Arguments and much much better then TypeTuple. Alias sort of means whatever goes as an alias parameter.

What I mean is that it implies the tuple has all alias arguments:
AliasSeq!(alias T, alias U, ...)

I know that's not what it means, but the wording is confusing in the same way that TypeTuple is confusing.
Plus, there are things you can pass to this construct that you can't alias:
alias x = AliasSeq!(2); // fine
alias x = 2; // nope

Didn't someone mention CTList for this? I think this makes a lot of sense, since it's basically a compile time list of things.

Let me also stress that we should have a higher bar than "it's better than the existing thing". We get one shot at this, we should make sure we pick the most fitting name. If we are back here in 1 year arguing about how confusing the new name is to new users, we will not get any sympathy for changing the name from Walter and Andrei. If it means delaying the rename until next release, let's do that. Call it __TBDTuple and encourage people to continue to use the std.typetuple.TypeTuple alias until we figure out the name.

IIRC, Adam used CTList for his own definition of TypeTuple in his talk at dconf, and I'd be fine with that. I prefer it to AliasSeq, but it does have list in it (which Walter objected to), and deadalnix said something about there being cases where it's used at runtime, but I've never seen that, so I don't know what he's talking about, and I suspect that even then, it's really a compile time entity that happens to hold aliases to symbols which get used at runtime, so it's still arguably a CTList.

cases where it's used at runtime

It can't be used at runtime. It can be an alias to a specific stack frame variable, but it's still a compile-time alias.

@schveiguy In effect, T... behave pretty much as alias template argument (at the exception you can't bind native types like int to it, but it is pretty much agreed that this is a surprizing behavior and we should probably lift this limitation).
alias A = ...; behave differently than alias for template arguments (more limitation like not being able to bind literals to it).
I'd rather see the definition of alias to be uniformed rather than inventing a new term every time to design something that is slightly different in subtle ways but mostly the same. That's very C++y and we don't want that.
@jmdavis Consider
void foo(Types...)(Types values) {}
In that case values are a sequence, but it contains runtime values.

In effect, T... behave pretty much as alias template argument

Yeah, you are right. I tried several different things, and in all cases, AliasSeq covers them, including the case where alias fails (on native types).
If aliasing native types gets fixed, then this means effectively, AliasSeq does technically mean AliasSeq(alias T, alias U, ...)
So I'm fine with that.

In that case values are a sequence, but it contains runtime values.

I don't think that's a good use case to prove this. values isn't necessarily runtime types if passed via AliasSeq.
But in any case, there are definitely times where you can have an alias to a runtime value in an AliasSeq, and then it's use as a compile-time construct breaks down:
void foo(int a, int b)() {}
void foo2(Types...)(Types values) {}

void main()
{
    int x;
    foo2(AliasSeq!(1, x)); // ok
    foo!(AliasSeq!(1, 2))(); // ok
    foo!(AliasSeq!(1, x))(); // error
}

I rescind my objections, AliasSeq seems fine.

And the PR checks are now green. :tada:

Ping, can we merge this before the release goes out ? I'm not sure what is the planned schedule, but it seems that time is of the essence here.

Auto-merge toggled on

Let's be bold.

@MartinNowak I think this needs to go into stable before release.

It should have been opened against the stable branch. As a bare minimum, please attach the milestone.
I can't respond to @ mentionings b/c people ping me all the time.

Can you follow up on this a bit and rename occurrences of TList and TL where applicable @deadalnix?


html/js_test/transferrables fails on IE10

html/js_test fails on IE10

Fixed in CL https://codereview.chromium.org/1380963003
Status updated in https://codereview.chromium.org/1379363002/

One of the subtests, transferrables, is still failing on IE10 and IE11.  Putting it in the status file.

Closing this since IE11 is no longer supported by our web targets.


Update plugin description

Updated description of Leaflet.FunctionalTileLayer plugin to better represent use case.

Thanks. Love the new design, btw.


Couldn't establish a connection "wss://xxx". Is your browser running?

Hi,
Thanks for the job! I just need help to go on and use it wide :)
Describe the bug
I got my notification on Discord to solve the captcha

But once I get to https://epic.domain.tld/?targetId=A6423E30A5626BFC0FEC26FB1A3F17BF, I got this error
Couldn't establish a connection "wss://epic.domain.tld/ws/A6423E30A5626BFC0FEC26FB1A3F17BF". Is your browser running?
Screenshots or Logs

><EMAIL_ADDRESS>entrypoint-config
> node dist/src/entrypoint-config.js

Setting timezone: Europe/Paris
Run on startup: true
[2022-06-30 16:15:17.892 +0200] INFO: Started epicgames-freegames-node
    COMMIT_SHA: "a7629cb5b837b3a9242bf0a0e13b94006bc58dad"
    BRANCH: "master"
    DISTRO: "debian"
[2022-06-30 16:15:17.893 +0200] DEBUG: Performing version check
    PROJECT_NAME: "epicgames-freegames-node"
    BRANCH: "master"
    COMMIT_SHA: "a7629cb5b837b3a9242bf0a0e13b94006bc58dad"
[2022-06-30 16:15:18.221 +0200] INFO: Checking free games for<EMAIL_ADDRESS>    user<EMAIL_ADDRESS>[2022-06-30 16:15:18.221 +0200] DEBUG: Launching a new browser
    user<EMAIL_ADDRESS>[2022-06-30 16:15:18.631 +0200] DEBUG: hcaptchaAccessibilityUrl not configured, captchas are less likely to be bypassed. Follow this guide to set it up: https://github.com/claabs/epicgames-freegames-node#hcaptcha-accessibility-cookies
[2022-06-30 16:15:18.633 +0200] DEBUG: Logging in with puppeteer
    user<EMAIL_ADDRESS>[2022-06-30 16:15:18.633 +0200] DEBUG: Launching a new browser
    user<EMAIL_ADDRESS>[2022-06-30 16:15:18.819 +0200] DEBUG: Launching a new page
    user<EMAIL_ADDRESS>[2022-06-30 16:15:28.829 +0200] DEBUG: Could not refresh credentials. Logging in fresh.
    user<EMAIL_ADDRESS>[2022-06-30 16:15:38.492 +0200] INFO: Go to this URL and do something
    user<EMAIL_ADDRESS>    url: "https://epic.domain.tld/?targetId=A6423E30A5626BFC0FEC26FB1A3F17BF"

Configuration:
I tried both ghcr.io/claabs/epicgames-freegames-node:bullseye-slim and charlocharlie/epicgames-freegames:latest
Also tried -e BROWSER_NAVIGATION_TIMEOUT=100000 \
docker run -d \
--name=epic \
--restart always \
-e TZ=Europe/Paris \
-e BROWSER_NAVIGATION_TIMEOUT=100000 \
-v /volume1/docker/epicgames:/usr/app/config:rw \
-p 4207:3000 \
-m 2g \
--label=com.centurylinklabs.watchtower.enable=true \
charlocharlie/epicgames-freegames:latest

{
  "runOnStartup": true,
  "cronSchedule": "5 16 * * *",
  "logLevel": "debug",
  "webPortalConfig": {
    "baseUrl": "https://epic.domain.tld",
    },
  "accounts": [
    {
      "email"<EMAIL_ADDRESS>      "password": "xx",
      "totp": "xx"
    },
  ],
  "notifiers": [
    {
      "type": "discord",
      "webhookUrl": "https://discordapp.com/api/webhooks/x/x",
    },
  ],
}

I use Nginx Proxy Manager for reverse proxy with Cloudflare.
Thanks for any help,
A.

I don't understand the wxx://epic.domaine/ltd


"TypeError: Cannot read property 'facadeModuleId' of undefined" when I want to build my project

⚠ IMPORTANT ⚠ Please check the following list before proceeding. If you ignore this issue template, your issue will be directly closed.

[x] Read the docs.
[x] Use Vite >=2.0. (1.x is no longer supported)
[x] If the issue is related to 1.x -> 2.0 upgrade, read the Migration Guide first.

Describe the bug
When I want to build my project with vite build, I have this error:
rendering chunks (2)...error during build:
TypeError: Cannot read property 'facadeModuleId' of undefined
    at getChunkName (/home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26857:27)
    at /home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26883:73
    at Array.map (<anonymous>)
    at createChunk (/home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26883:59)
    at Object.generateBundle (/home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26900:53)
    at /home/thelio/Dev/ToolBot-Website_/node_modules/rollup/dist/shared/rollup.js:19044:25

I use Vite with Symfony 5 with localhost:3000 URLs.
Reproduction
Sorry! I don't have a reproduction.
System Info

vite version: 2.0.2
Operating System: Linux Ubuntu 20.04.2 LTS
Node version: 15.8.0
Package manager (npm/yarn/pnpm) and version: NPM 7.5.4

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag.
Provide the error log here.

  vite:config bundled config file loaded in 110ms +0ms
[dotenv][DEBUG] did not match key and value when parsing line 1: # In all environments, the following files are loaded if they exist,
[dotenv][DEBUG] did not match key and value when parsing line 2: # the latter taking precedence over the former:
[dotenv][DEBUG] did not match key and value when parsing line 3: #
[dotenv][DEBUG] did not match key and value when parsing line 4: #  * .env                contains default values for the environment variables needed by the app
[dotenv][DEBUG] did not match key and value when parsing line 5: #  * .env.local          uncommitted file with local overrides
[dotenv][DEBUG] did not match key and value when parsing line 6: #  * .env.$APP_ENV       committed environment-specific defaults
[dotenv][DEBUG] did not match key and value when parsing line 7: #  * .env.$APP_ENV.local uncommitted environment-specific overrides
[dotenv][DEBUG] did not match key and value when parsing line 8: #
[dotenv][DEBUG] did not match key and value when parsing line 9: # Real environment variables win over .env files.
[dotenv][DEBUG] did not match key and value when parsing line 10: #
[dotenv][DEBUG] did not match key and value when parsing line 11: # DO NOT DEFINE PRODUCTION SECRETS IN THIS FILE NOR IN ANY OTHER COMMITTED FILES.
[dotenv][DEBUG] did not match key and value when parsing line 12: #
[dotenv][DEBUG] did not match key and value when parsing line 13: # Run "composer dump-env prod" to compile .env files for production use (requires symfony/flex >=1.2).
[dotenv][DEBUG] did not match key and value when parsing line 14: # https://symfony.com/doc/current/best_practices.html#use-environment-variables-for-infrastructure-configuration
[dotenv][DEBUG] did not match key and value when parsing line 15:
[dotenv][DEBUG] did not match key and value when parsing line 16: ###> symfony/framework-bundle ###
[dotenv][DEBUG] did not match key and value when parsing line 19: ###< symfony/framework-bundle ###
[dotenv][DEBUG] did not match key and value when parsing line 20:
[dotenv][DEBUG] did not match key and value when parsing line 21: ###> symfony/mailer ###
[dotenv][DEBUG] did not match key and value when parsing line 22: # MAILER_DSN=smtp://localhost
[dotenv][DEBUG] did not match key and value when parsing line 23: ###< symfony/mailer ###
[dotenv][DEBUG] did not match key and value when parsing line 24:
[dotenv][DEBUG] did not match key and value when parsing line 25: ###> doctrine/doctrine-bundle ###
[dotenv][DEBUG] did not match key and value when parsing line 26: # Format described at https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url
[dotenv][DEBUG] did not match key and value when parsing line 27: # IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml
[dotenv][DEBUG] did not match key and value when parsing line 28: #
[dotenv][DEBUG] did not match key and value when parsing line 29: # DATABASE_URL="sqlite:///%kernel.project_dir%/var/data.db"
[dotenv][DEBUG] did not match key and value when parsing line 30: # DATABASE_URL="mysql://db_user:db_password@<IP_ADDRESS>:3306/db_name?serverVersion=5.7"
[dotenv][DEBUG] did not match key and value when parsing line 32: ###< doctrine/doctrine-bundle ###
[dotenv][DEBUG] did not match key and value when parsing line 33:
  vite:config using resolved config: {
  vite:config   emitManifest: true,
  vite:config   cors: true,
  vite:config   esbuild: { jsxInject: "import React from 'react'" },
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge16', 'firefox60', 'chrome61', 'safari11' ],
  vite:config     polyfillDynamicImport: false,
  vite:config     outDir: '../public/assets/',
  vite:config     assetsDir: '',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: { input: [Object] },
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     minify: 'terser',
  vite:config     terserOptions: {},
  vite:config     cleanCssOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: true,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     brotliSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     base: ''
  vite:config   },
  vite:config   plugins: [
  vite:config     'alias',
  vite:config     'vite:resolve',
  vite:config     'vite:html',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'prefresh',
  vite:config     'twig-refresh',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:build-html',
  vite:config     'commonjs',
  vite:config     'vite:data-uri',
  vite:config     'rollup-plugin-dynamic-import-variables',
  vite:config     'vite:import-analysis',
  vite:config     'vite:esbuild-transpile',
  vite:config     'vite:terser',
  vite:config     'vite:manifest',
  vite:config     'vite:reporter'
  vite:config   ],
  vite:config   root: '/home/thelio/Dev/ToolBot-Website_/assets',
  vite:config   optimizeDeps: { exclude: [ '@prefresh/vite/runtime', '@prefresh/vite/utils' ] },
  vite:config   configFile: '/home/thelio/Dev/ToolBot-Website_/vite.config.js',
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     build: {}
  vite:config   },
  vite:config   base: '/',
  vite:config   resolve: { dedupe: undefined, alias: [ [Object] ] },
  vite:config   publicDir: '/home/thelio/Dev/ToolBot-Website_/assets/public',
  vite:config   command: 'build',
  vite:config   mode: 'production',
  vite:config   isProduction: true,
  vite:config   optimizeCacheDir: '/home/thelio/Dev/ToolBot-Website_/node_modules/.vite',
  vite:config   server: {},
  vite:config   env: { BASE_URL: '/', MODE: 'production', DEV: false, PROD: true },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen]
  vite:config   },
  vite:config   createResolver: [Function: createResolver]
  vite:config } +8ms
vite v2.0.2 building for production...
✓ 8 modules transformed.
rendering chunks (2)...error during build:
TypeError: Cannot read property 'facadeModuleId' of undefined
    at getChunkName (/home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26857:27)
    at /home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26883:73
    at Array.map (<anonymous>)
    at createChunk (/home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26883:59)
    at Object.generateBundle (/home/thelio/Dev/ToolBot-Website_/node_modules/vite/dist/node/chunks/dep-a5ddf8f9.js:26900:53)
    at /home/thelio/Dev/ToolBot-Website_/node_modules/rollup/dist/shared/rollup.js:19044:25

You need to at least provide the client side source code otherwise there's nothing we can do.

I have a repository where my project is: https://github.com/ToolBotDiscord/ToolBot-Website (it's in French) (there's all the code - it's in PHP)

@endermctv
You have Prefresh, but you're using React? Prefresh is specifically for Preact. There's an example here for fast refreshing React with Vite: https://github.com/vitejs/vite/blob/main/packages/create-app/template-react/vite.config.js
Not sure if that's related to your issue, as I don't have any method for running PHP, but it's a start.

@rschristian
Thanks!! I put the font awesome kit code into my project as a file, and it's works!!

The other thing you could do is just add that import to your template. I believe that should be handled correctly.


Fixed issue that made Restore and Save Without Cloning buttons disapp…

…ear in Python 3.
Recently switched from Python 2 to Python 3 and realized that the 'Restore' and 'Save without cloning' buttons were no longer in Django admin. It had to do with using parens after Media, so I removed the parens and it fixed the problem.

Hey @rossmechanic, thanks for the fix. Did you have the chance to test this in Python2 as well? Thanks

@maennel Yep. It works either way in Python 2, but only without the parens in Python 3.

Also, @maennel do you mind answering this question? #147
Thanks!


Execute remote actions on another extension

Companion PR: #6734 must be merged first
Description
Allows one extension to execute an action on another extension.
See the Hello World RestRemoteHelloAction for sample implementation.
Other work done to support:

Put a setter on Extension interface to get a copy of extensions runner since injection is flaky.
Created SDKTransportService class to avoid having to pass around so many params.   Lots of things can be moved from ExtensionsRunner there later, just did the action module ones in this PR and left some TODOs where other opportunities exist

Issues Resolved
Fixes #525
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle check is failing based on companion PR classes.  No idea why DCO check is failing, git log shows they're all signed.

@owaiskazi19 @saratvemulapalli addressed all your comments.
And as-of now it still works:
curl -X GET http://localhost:9200/_extensions/_hw/hello/test
Received greeting from remote extension: Hello, test%

Gradle check failing due to companion PR.  Only thing left is to update the sequence diagram which I'm working on.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@467200d). Click here to learn what that means.
The diff coverage is 42.27%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage        ?   63.97%
  Complexity      ?      244
=======================================
  Files           ?       49
  Lines           ?     1088
  Branches        ?       35
=======================================
  Hits            ?      696
  Misses          ?      381
  Partials        ?       11

Impacted Files
Coverage Δ

src/main/java/org/opensearch/sdk/Extension.java
100.00% <ø> (ø)

...h/sdk/handlers/ExtensionActionResponseHandler.java
0.00% <0.00%> (ø)

...ch/sdk/handlers/ExtensionActionRequestHandler.java
7.27% <7.27%> (ø)

.../sample/helloworld/rest/RestRemoteHelloAction.java
25.00% <25.00%> (ø)

...rch/sdk/action/RemoteExtensionTransportAction.java
37.50% <37.50%> (ø)

...n/java/org/opensearch/sdk/SDKTransportService.java
47.61% <47.61%> (ø)

...earch/sdk/action/RemoteExtensionActionRequest.java
71.79% <71.79%> (ø)

...main/java/org/opensearch/sdk/ExtensionsRunner.java
76.96% <78.57%> (ø)

...rc/main/java/org/opensearch/sdk/BaseExtension.java
86.66% <100.00%> (ø)

src/main/java/org/opensearch/sdk/SDKClient.java
92.00% <100.00%> (ø)

... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


single string or number object parse?

let json = JSON.init(parseJSON: "\"aa\"")
print(json.stringValue)
let json2 = JSON.init(parseJSON: "1")
print(json2.numberValue)
outputs:
""
0
expected:
"aa"
1
How can I get expected values?

Single string it's not a valid JSON format.
By the way,
if the input is "aa" and what you expected is "aa"
seem like input and output look the same string
So....  why you did not use it directly?

Single string is a valid JSON format, you can test it on some online JSON validator websites.
Our APIs always return JSON response, which is handled in a common place, we don't want to treat it diffentely.

https://www.json.org/
JSON is built on two structures:

A collection of name/value pairs. In various languages, this is realized as an object, record, struct, dictionary, hash table, keyed list, or associative array.

An ordered list of values. In most languages, this is realized as an array, vector, list, or sequence.

I think you can check if the value did not prefix with { it may be a plain value

I don't think you can use an online JSON validator as a reference for the specification of JSON.
https://www.json.org/
JSON is built on two structures:

A collection of name/value pairs. In various languages, this is realized as an object, record, struct, dictionary, hash table, keyed list, or associative array.
An ordered list of values. In most languages, this is realized as an array, vector, list, or sequence.

But you can check if the value did not prefix with { it may be a plain value

This only says that JSON have two data structures
Here at https://tools.ietf.org/html/rfc8259 (which is "INTERNET STANDARD") in section 2 you can clearly read that any JSON value is valid JSON now

Any update? This issue is certainly right, Why you guys feel confused.


Docking service

Hi !
Any updates about a potential docking service?
Thanks!

This issue will be closed since there were no actions for a while.
You can reopen this issue to show this issue to the users whenever.
Thanks. :)


Fix toLatLngBounds

Fix for https://github.com/Leaflet/Leaflet.markercluster/issues/740
execution gets to this point:
function toLatLngBounds(a, b) {
	if (a instanceof LatLngBounds) {
		return a;
	}
	return new LatLngBounds(a, b);
}

where a is LatLngBounds (it has all the same methods), but it is not instance of LatLngBounds (it identifies itself as B).

Hi there,
can you explain why you have a class that has everything LatLngBounds has but is not an instance of LatLngBounds? It sounds like you should really use the correct object.

Hi, my guess that this has something to do to Webpack/Minification. I'm pretty sure this is LatLngBounds object it's just instance of does not recognise as one. This is the best solution I have so far, it's hard to understand what is happening there

True. My thoughts as well.


Do not downscore peers due to timeout error if node is busy

Is your feature request related to a problem? Please describe.
When our node is super busy, we can't even handle ping message on time:
grep -e "message=Timeout" -rn beacon*-05.log  | grep "Resp error method=ping" | wc -l
122

at that time, our clock is drift, it's our own issue and we should not downscore peers if our p2p requests return timeout error. Found a lot of request timeout errors from our log:
grep -e "code=REQUEST_ERROR_DIAL_TIMEOUT" -rn beacon*-05.log | wc -l
138
grep -e "code=REQUEST_ERROR_TTFB_TIMEOUT" -rn beacon*-05.log | wc -l
25
grep -e "code=REQUEST_ERROR_RESP_TIMEOUT" -rn beacon*-05.log | wc -l
6
grep -e "code=REQUEST_ERROR_REQUEST_TIMEOUT" -rn beacon*-05.log | wc -l
29

which result in losing a lot of peers

Describe the solution you'd like

If we can't handle ping requests on time, don't penaltizing peers for request timeout errors in the next x minutes.

Describe alternatives you've considered

Detect clock drift issue in the node and don't penaltizing peers for request timeout errors at that time

Additional context
This issue happens during prater non-finality time, some nodes have only 2 peers and have to wait for 1 day to get more peers to recover.

This is one is very tricky because we need to differentiate between a real timeout and a timeout caused by us. Measuring our internal delay may be a good option but still a bit sketchy.
The real question is: Why did the node get so busy in the first place?

The real question is: Why did the node get so busy in the first place?

one reason is the high memory usage at that time causing long epoch transition

Probably part of the I/O lag issue

Closing as we are working on reducing node load. Won't be easy to differentiate malicious behavior from us being overloaded


Support HTML formatting in target text

Describe the addition

The text in the buttons is currently read in as sanitized text, so html tags like b or i don't work.
Context

Some buttons in real BSB use formatting.
Proposed Solution

I think just de-sanitizing the angle brackets will fix this.

Addressed with latest commit-- we use html-react-parser to accomplish this.


display extension name right-side-up

It was originally implemented this way, but also erroneously caused the DNA sequence of the extension to display backwards. See #959.
I made the call to quick-fix the DNA sequence issue, since it could lead to errors in DNA sequences if someone mistakenly reversed their DNA sequence to make it look "correct" in scadnano. The way I fixed it was to always draw the extension line starting at the 5' end and ending at the 3' end.
Previously, we drew it starting at the left and ending at the right, which makes textPath's tied to the line always display above it. So now extension names (and labels) appear like this:

Let's figure out a way to make the upside-down names and labels appear right-side-up, while preserving the correct display of DNA sequences:

I think the straightforward fix for this is to draw a second invisible line along with the visible extension line, but use the original left-to-right order, instead of 5' to 3' order, and then use xlink:href= that invisible line for the extension name and label instead of the visible extension line.


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/sql-virtual-machine/sql-virtual-machine
Module Details
This module deploys SQL Virtual Machine - https://learn.microsoft.com/en-us/azure/templates/microsoft.sqlvirtualmachine/sqlvirtualmachines?pivots=deployment-language-bicep
Do you want to be the owner of this module?
No
Module Owner's GitHub Username (handle)
peterbud
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @loflet, thank you for proposing this module!
Please note that while you can't be the "owner" of this module as you're not a Microsoft FTE, you can definitely contribute to it, once we found an FTE module owner.
Can you please confirm that you're interested in contributing to this solution by writing code? Thank you!

Hi @matebarabas, yes I would like to contribute to this solution by writing code, I am writing my own modules right now for one customer and I think this AVM module will be very handy for scenarios where we are trying to move to avm modules as it support multiple modules together.

Perfect, thanks for confirming! I'll get back to you when I have someone lined up who can help with the administrative side of this module. In the meantime, please feel free to start working on the code. Thank you!

@loflet, as we discussed via chat, @peterbud will help you as module owner. I'm going to administer this in our records.

Hi @peterbud,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @peterbud,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

The work is in-progress on this module. I will update more once I have something to share for testing.


test: add unit-tests for core GetVolume

Ⅰ. Describe what this PR did
#1629:  add unit-tests for core GetVolume
Ⅱ. Does this pull request fix one issue?

NONE
Ⅲ. Describe how you did it
NONE
Ⅳ. Describe how to verify it
NONE
Ⅴ. Special notes for reviews
NONE

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.lauo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM, thanks a lot for your work. @forienlauo


⚠ Cioos Pacific CKAN has degraded performance

In 64057ed, Cioos Pacific CKAN (https://catalogue.cioospacific.ca) experienced degraded performance:

HTTP code: 200
Response time: 20021 ms

Resolved: Cioos Pacific CKAN performance has improved in e3a1002 after 8 hours, 38 minutes.


Half square appearing when hovering in a playlist

In all themes.
This weird square appears when hovering over a song, in a playlist

Closing this, explained in #14


Add maxhgap param and code to support it to weill()

Hi @alejandro-ariza, we at Arimo found the echopy library very useful in a project with a fish finder manufacturer. We updated the weill() implementation to support the maxhgap parameter. Could you take a look to see if it is OK or if there is any code that is needed to fix before merging? Thanks!!!

Excellent @nhanitvn! I just set maxhgap to zero, so it's not applicable by default, horizontal gaps were not described/permitted in Weill et al (1993). It's nice to increase functionality in algorithms, as long as we make clear it's an "extra", not implemented in the original algorithm. If too different we can always create new algorithms.
Thanks for your contribution!

Thanks @alejandro-ariza for maintaining such a great software :)


Initial release of apollo-fetch

This is the initial release of apollo-fetch, the lightweight client for GraphQL requests that supports middleware and afterware.

Changes Unknown when pulling 0ec7139d56d2e3845591870471834c90503b1467 on initial-release into ** on master**.


ref to table generated by package not found

Steps to reproduce:

Check out latest Fivetran analytics repo.
Follow setup guide.
Note error in tickets_timeline.sql.

Hey, thank you for clear steps to reproduce the issue.
I was able to replicate it locally. It is a known issue that is related to usage of adapter.get_columns_in_relation function in zendesk__ticket_field_history model. This method fetches columns directly from BigQuery INFORMATION_SCHEMA. So for now it is required that the tables used in the get_columns_in_relation function (and similar functions) be present in the dataset.

This should be fixed starting from v0.26.0. We now work directly with ZetaSQL catalog and avoid accessing BigQuery for information schema on dbt compile stage.


:sparkles: New Generic.WhiteSpace.HereNowdocIdentifierSpacing sniff

Description
New Generic.WhiteSpace.HereNowdocIdentifierSpacing sniff which forbids whitespace between the <<< and the identifier string in heredoc/nowdoc start tokens.
Includes fixer.
Includes tests.
Includes XML docs.
Suggested changelog entry
New Generic.WhiteSpace.HereNowdocIdentifierSpacing sniff which forbids whitespace between the <<< and the identifier string in heredoc/nowdoc start tokens.
Related issues/external references
Fixes #
Types of changes

[x] New feature (non-breaking change which adds functionality)

@rikvdh :point_up: Might also be something to suggest to PER ? Don't think this is covered in the PER standard yet.

Rebased without changes.


qt-based wayland images of bullseye branch are not starting correctly due to missing bash

Your qt-based wayland images, such as the ones created with qt5-wayland-examples/Dockerfile coming from the bullseye branch are not starting due to a missing bash.
When following your QT Debian for Torizon tutorial and starting the weston container with
docker run -d --rm --name=weston --net=host --cap-add CAP_SYS_TTY_CONFIG \              -v /dev:/dev -v /tmp:/tmp -v /run/udev/:/run/udev/ \              --device-cgroup-rule='c 4:* rmw' --device-cgroup-rule='c 13:* rmw' --device-cgroup-rule='c 226:* rmw' \               torizon/weston:$CT_TAG_WESTON --developer weston-launch --tty=/dev/tty7 --user=torizon
and starting the qt container with
# docker run --rm -it --name=qt5 \              -v /tmp:/tmp \              -v /dev/dri:/dev/dri --device-cgroup-rule='c 226:* rmw' \              torizon/qt5-wayland-examples:$CT_TAG_QT5_WAYLAND_EXAMPLES
these for instance result in
torizon/qt5-wayland-examples->docker: Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "exec: \"|1\": executable file not 		found in $PATH": unknown.
The current workaround:
docker run --rm -it --entrypoint=bash --name=qt5-14-2 \              -v /tmp:/tmp \              -v /home/torizon/:/home/torizon/ \              -v /dev/dri:/dev/dri --device-cgroup-rule='c 226:* rmw' \              torizon/qt5-wayland-examples:$CT_TAG_QT5_WAYLAND_EXAMPLES
which considers the flag --entrypoint=bash. But obviously this is not intended by you since all the images having $CT_TAG_QT5_WAYLAND_EXAMPLES=1 and other branches having $CT_TAG_QT5_WAYLAND_EXAMPLES=2 are starting correctly as described in the tutorial.

Currently our containers won't start bash as default, we are working on this.
In the meantime you can add "bash" as command after the container name, as suggested in our documentation. This will allow you to access the shell prompt as usual.
Sorry for the inconvenience.


Added more CSS to style the rest of the elements on the page

I did not touch the Map's CSS, left as is, since Raj was working on that.
I did add the form back. I had added it before so I could do the style to it, so I added it back so we can see how it would all look together.


Epic - Implementation of RFC 0011: Plan to rename Qiskit/qiskit-terra repo to Qiskit/qiskit

Tasks:

[x] preparation stage

[x] metapackage-repo
[x] rfc-discussion: https://github.com/Qiskit/RFCs/pull/31

[x] empty-metapackage stage

[x] ibmq-docs-out-of-metapackage: https://github.com/Qiskit/qiskit-ibmq-provider/pull/1166
[x] docs-out-of-metapackage: https://github.com/Qiskit/qiskit-metapackage/issues/1722
[x] benchmarks-out-of-metapackage: https://github.com/Qiskit/qiskit-metapackage/issues/1723
[x] tutorials-out-of-metapackage: https://github.com/Qiskit/qiskit-metapackage/issues/1724

[x] ~ibmq-out-of-metapackage stage~ because https://github.com/Qiskit/qiskit-ibmq-provider/pull/1166, this is unnecessary step
[x] remove-optionals : Remove the non-qiskit optionals (aka extras, such as nature, finance, etc). Leave the terra optionals in the metapackage.

[x] Remove optionals section from metapackage readme file https://github.com/Qiskit/qiskit-metapackage/pull/1751
[x] In July release, mention that optionals are going to be removed in October release https://github.com/Qiskit/qiskit-terra/pull/10206
[x] In October release, remove optionals from metapackage. Make the terra and metapackage optionals, the same.

[x] archive-metapackage stage

[x] move-setup-out-of-metapackage
* https://github.com/Qiskit/qiskit-terra/pull/10610
* https://github.com/Qiskit/qiskit-terra/pull/10611
* https://github.com/Qiskit/qiskit-terra/pull/10530
* https://github.com/Qiskit/qiskit-terra/pull/10443
[x] pre-archive: https://github.com/Qiskit/qiskit-metapackage/pull/1790
[x] archive-metapackage:  Done on Aug 18, 2023.

[ ] final stage

[x] final-rename: Planned for Aug 21, 2023
[x] fix-time: two weeks after final-rename
[ ] final-announcement

gantt
    dateFormat  YYYY-MM-DD
    tickInterval 1month
    axisFormat %b

    section planned releases
    %% From freeze to release
    0.24         : crit, release024, 2023-04-06, 28d
    release 0.24 : milestone, 2023-05-04
    %% From freeze to release
    0.25         : crit, release025, 2023-07-05, 22d
    release 0.25 : milestone, 2023-07-27
    section preparation
    metapackage-repo :metapackage-repo, 2023-03-31, 1d
    rfc-discussion   :done, rfc-discussion, 2023-03-30, 10d
    rfc-merged   :milestone, rfc-merged, after rfc-discussion, 0d
    section empty-metapackage
    %% These tasks are not interdepedendent and they need to be done before release025
    ibmq-docs-out-of-metapackage    :ibmq-docs, after rfc-merged, 2w
    docs-out-of-metapackage         :docs, after ibmq-docs, 4w
    benchmarks-out-of-metapackage   :benchmarks, after docs, 4w
    tutorials-out-of-metapackage    :tutorials, after benchmarks, 4w
    section archive-metapackage
    ibmq-out-of-metapackage        :ibmq-archived, after release025, 1d
    move-setup-out-of-metapackage  :setup, after release025, 1w
    pre-archive-doc                :archive-doc, 2023-08-18, 1d
    archive-metapackage            :archive-meta, after archive-doc, 1d
    section final
    final-rename    : finalrename, 2023-08-21, 1d
    fix-time:       : fix-time, after finalrename, 2w
    final-announcement : milestone, finalannoun

I don't have write permission on this repo so I can't update the checklist here, but the following Terra PRs implement most of this:

Qiskit/qiskit-terra#10610
Qiskit/qiskit-terra#10611
Qiskit/qiskit-terra#10530
Qiskit/qiskit-terra#10443

At the time of writing, I've gone through the issues on the metapackage repo and sorted them all out, transferring existing ones to the correct places or closing as appropriate, and opening a couple of new ones just so the remaining few are a complete burn-down list for archiving the metapackage.  All issues have open PRs, so once they're all merged, the metapackage repo can be archived, and Terra can be renamed Qiskit/qiskit.

Almost there... we can close it once finished. I agree that there is not much actionable here beyond reactive support.

The benchmark website is up and running and the announcement is in the making. With this, I can consider this epic closed!


Online index rebuild on Azure SQL databases

Hello,
I have a question about the possibility to operate an online index rebuild on an Azure SQL databases.
Because, you explictly explain that there are some restrictions on SQL Server (Enterprise Edition only roughly).
But what about Azure SQL databases? Are online index rebuild operations possible on every Azure SQL database? This is not explicit or clear enough in this article.
Thanks in advance !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1cd99ac5-4414-3c3e-2fea-0f3c35821f30
Version Independent ID: d29c1bd8-533a-99a5-fc52-02170c93f31d
Content: Perform Index Operations Online - SQL Server
Content Source: docs/relational-databases/indexes/perform-index-operations-online.md
Product: sql
Technology: table-view-index
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@alexandredenis-bib -- thank you for your questions.  You may find these resources helpful:

DBA Stack Exchange
Stack Overflow

@MikeRayMSFT -- please look into this potential documentation issue.

@alexandredenis-bib here is the specific case that addresses your question:
https://stackoverflow.com/questions/48681024/how-to-set-azure-sql-to-rebuild-indexes-automatically
SQL Azure Managed Instance also supports SQL Agent which you can also use to create jobs to script maintenance operations if you so choose).
Please advise if this answers your question.

@cawrites thanks for your answer.
Actually, I already read this post but as I said in a recent post on StackExchange (cf. https://dba.stackexchange.com/questions/264144/are-online-index-rebuild-operation-possible-on-every-azure-sql-database), I don't understand why my tables are that much fragmented if Azure SQL databases are supposed to avoid the need to operate manual index rebuild.
I tested on my side to operate index rebuild on one of my online database and it worked well (even if I get some locks on my tables but it appears to be normal -> cf. https://www.sqlskills.com/blogs/paul/search-engine-qa-19-misconceptions-around-index-rebuilds-allocation-bulk_logged-mode-locking/).
I did some researches and found the following blog article: https://techcommunity.microsoft.com/t5/azure-database-support-blog/how-to-maintain-azure-sql-indexes-and-statistics/ba-p/368787#
I will try to run the maintenance procedure but I guess the script is also doing index rebuild.
Concerning the main subject of that issue, I think the documentation is not clear enough about the fact that we can operate online index rebuild on Azure SQL databases. It is not explicit while there are explicit information about SQL Server databases.

@alexandredenis-bib  please review https://docs.microsoft.com/en-us/sql/relational-databases/indexes/guidelines-for-online-index-operations?view=sql-server-ver15

@cawrites Both articles are interesting and I actually already read them. But none of them is explicitly explaining if there are or not some limitations to operate online index rebuild on Azure SQL Databases while for SQL Server, it explicitly says:

Online index operations are not available in every edition of Microsoft SQL Server. For a list of features that are supported by the editions of SQL Server, see Features supported by editions.

@alexandredenis-bib I am following up on your last comment. You were provided several links, but it seems like you are looking for a specific statement to appear in the documentation. Are you looking for limitations to be defined? The documentation does explain the usage of indexes in Azure SQL Database.

@cawrites Yes it would be great to explicitly say if there are some limitation when using online index rebuild operations on an Azure database. At least say "Online index operations are available on Azure SQL Database (not matter the version)" or something like that.
Because when I read "Online index operations are not available in every edition of Microsoft SQL Server", I am wondering if there are some Azure SQL versions that does not support online index operations. I don't know if this information is implicit or not but having a simple phrase statuating about the Azure SQL case would be great.


Create infixt to postfix

What the program do ?
converts infox to postfix
In what programming language it is written?
c

This pull request do not contains files in specific folders. Please fix it and reopen


Implement Clock class

Another piece required for the block runner is a clock. Here I introduced the interface IClock and two concrete implementations StdClock and YarpClock. The former is useful for standalone applications while the latter becomes pivotal when you want to simulate your system with gazebo and using a shared clock.
The clocks, both yarp, and std are implemented using singleton and they are instantiated using the factory paradigm. The std lof is the default clock. If you want to use the yarp one you should set the associated factory in the ClockBuilder.
Long story short.

Do you want to use a normal std clock?// this will return the time since the epoch
auto now = BipedalLocomotion::clock().now();

Do you want to use yarp clock?yarp::os::Network::init(); //<------ This is required by yarp to use the clock. Call it only once in your main.

// Change the clock. Call it only once in your main. From now on you will use the yarp clock
BipedalLocomotion::System::ClockBuilder::setFactory(std::make_shared<BipedalLocomotion::System::YarpClockFactory>()));

auto start = BipedalLocomotion::clock().now();

yarp::os::Network::init(); //<------ This is required by yarp to use the clock. Call it only once in your main.

I am bit dubious on this. Can't we just do that via RAII in the YARP Clock class?

Can't we just do that via RAII in the YARP Clock class? Because if we call manually the init, we need also to call the fini.

Just to be sure, do you mean call yarp::os::Network::ini()  in the constructor of YarpClock and fini in the destruction?

Ok, but just to understand, how do you want to use this? If you want to use to run a periodic thread, it may be convenient to expose sleep_for/sleep_until ?

 I cannot use this_tread::sleep_for when the yarp clock network is used!

Can't we just do that via RAII in the YARP Clock class? Because if we call manually the init, we need also to call the fini.

Just to be sure, do you mean call yarp::os::Network::ini() in the constructor of YarpClock and fini in the destruction?

Either that, or just add a instance of the yarp::os::Network class that does that for you.

@traversaro here I implemented sleepFor and sleepUntil in  https://github.com/dic-iit/bipedal-locomotion-framework/pull/269/commits/2b3b9e7d83124ca9d6e881d51e7819234dcbc48d. Do you think it's fine?

@traversaro I implemented sleepFor and sleepUntil in 2b3b9e7. Do you think it's fine?

Yes!


Create-react-app Tests not running

I'm using version 0.9.3 of react-scrips in CRA, which relies on Jest v18.1.
I run the tests using npm test (or npm run test), and the CLI works perfectly.
However, the extension doesn't seem to be recognizing that the tests are being run. I have empty green circles next to all of them, and, upon highly, they all display: Test has not run yet, due to Jest only running tests related to changes.
Yet the tests are definitely running. I'm not sure what the problem is, since opening VSCode DevTools doesn't show any errors.

I have the same issue with version 0.9.4 of react-scripts. The jest plugin just keeps spinning and not returning any results. I also posted and issue at create-react-app, because the plugin is working, but only after running npm run eject on the project, which I would like to avoid to keep my project small and simple

Sorry - been on my honeymoon, just started getting back to writing code.
I think this is caused by two things, which now has 2 PRs

https://github.com/facebook/jest/pull/3212
https://github.com/orta/vscode-jest/pull/90

Which fixes this 👍

This is an automatically generated message.
<EMAIL_ADDRESS>is no longer with Yahoo! Inc.
Your message will not be forwarded.
If you require assistance with a legal matter, please send a message to<EMAIL_ADDRESS>Thank you!

this should be working now? Do I have to change the config?

Does that mean it's not working for you now @mattiascaricato?

yes @seanpoulter , is not working for me

Since this issue is closed, could you please create a new issue with all the required info to create your problem? Please include OS info, the version of create-react-app, and any output from the Jest Output channel or the Dev Tools console (Help > Toggle Dev Tools).
FWIW I could not recreate your issue on a POSIX system:
mkdir 85
cd 85
yarn init -y
yarn add create-react-app
yarn create-react-app app
cd app
code .

This runs the one test OK.


Revert "CCD-961 Merge Controller Advices in Def Store"

Reverts hmcts/ccd-definition-store-api#992

not required


Pod does not include postAccessabilityNotification

I am installing SingleLineShakeAnimation via cocoapods but it does not include the postAccessabilityNotification function. Am I doing something wrong?

Thanks for letting me know, updated pod with it now!


python310Packages.pymetno: 0.11.0 -> 0.12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pymetno is: A library to communicate with the met.no API
meta.homepage for python310Packages.pymetno is: https://github.com/Danielhiversen/pyMetno/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.12.0 with grep in /nix/store/2sy4qfw8cq2gg2r0kj5rjckqgdwqsnhk-python3.10-pymetno-0.12.0
found 0.12.0 in filename of file in /nix/store/2sy4qfw8cq2gg2r0kj5rjckqgdwqsnhk-python3.10-pymetno-0.12.0

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.met
home-assistant-component-tests.onboarding
python310Packages.pymetno
python311Packages.pymetno

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2sy4qfw8cq2gg2r0kj5rjckqgdwqsnhk-python3.10-pymetno-0.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pymetno https://github.com/r-ryantm/nixpkgs/archive/3bbf4790b220f42a1ddf0f681c6d703a070ea3b9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3bbf4790b220f42a1ddf0f681c6d703a070ea3b9#python310Packages.pymetno

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2sy4qfw8cq2gg2r0kj5rjckqgdwqsnhk-python3.10-pymetno-0.12.0
ls -la /nix/store/2sy4qfw8cq2gg2r0kj5rjckqgdwqsnhk-python3.10-pymetno-0.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

home-assistant-component-tests.met
home-assistant-component-tests.onboarding
python310Packages.pymetno
python311Packages.pymetno

Maintainer pings
cc @flyfloh for testing.

Result of nixpkgs-review pr 266762 run on x86_64-linux 1

6 packages built:

home-assistant-component-tests.met
home-assistant-component-tests.onboarding
python310Packages.pymetno
python310Packages.pymetno.dist
python311Packages.pymetno
python311Packages.pymetno.dist