Chore: Migrate BaseKYCWall.js to function component

Details

This change is made to migrate the src/components/KYCWall/BaseKYCWall.js from class to a function component.
Note: This PR only addresses a reverted code of a previously merged PR
Fixed Issues

$: 16170
PROPOSAL:  16170
Tests

log into the app

press the FAB and request money from e.g. workspace that you are a part of (to make it easier and not have to jump between accounts)

select the said workspace and press on pay with Expensify

confirm that the pop up shows in which you can select an option and be navigated to it

[x] Verify that no errors appear in the JS console

Offline tests

log into the app
press the FAB and request money from e.g. workspace that you are a part of (to make it easier and not have to jump between accounts)
select the said workspace and press on pay with Expensify
confirm that the pop up shows in which you can select an option and be navigated to it

QA Steps

log into the app

press the FAB and request money from e.g. workspace that you are a part of (to make it easier and not have to jump between accounts)

select the said workspace and press on pay with Expensify

confirm that the pop up shows in which you can select an option and be navigated to it

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

oh @abdulrahuman5196 can you handle checklists?

@bondydaa @abdulrahuman5196, made code changes, let's have a look at it again.

Thank you. Will check again in my morning.

Reviewing now

@teneeto The author's checklist only has 2 platform videos?

@teneeto To fix author's checklist as mentioned here https://github.com/Expensify/App/pull/31538#issuecomment-1836100929

@teneeto To fix author's checklist as mentioned here #31538 (comment)

Hi @abdulrahuman5196, added all screenshots and updated tests steps too

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Bad Formatting after update

@madskristensen; After you merged my changes. I look at the results in the Cookbook and the formatting is off. I am submitting a Pull Request: Fix MD formatting for convert to HTML page in cookbook. #24 with better MD formatting that should fix these issues.

Double Word (should):

@madskristensen; Still one formatting issue, fix did not work completely. Created pull request: Formatting Fix 2: #25


Adds bad user flagging

When we get a 403 trying to send messages to a user, it means they've blocked us. We have no way of knowing that this is the case until we try to send to them. Too many 4xx errors may cause Discord to auto-flag SpellBot as spam. So when we see a 403 for a user send, add them to a list of "bad users" and don't try to send messages to them any more.

Codecov Report

Merging #699 (fd261af) into main (ec4f437) will decrease coverage by 0.06%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##              main     #699      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%
===========================================
  Files           70       70
  Lines         3144     3145       +1
  Branches       312      315       +3
===========================================
- Hits          3144     3143       -1
- Partials         0        2       +2

Impacted Files
Coverage Δ

src/spellbot/operations.py
98.88% <91.66%> (-1.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4f437...fd261af. Read the comment docs.


contrib: minor Cern plugin fix

FIX Fixes an issue where g.identity.provides was populated with only the
Cern groups. As access rights can be assigned to single users(i.e. emails),
the user's e-mail must also be included in the g.identity.provides.

Coverage increased (+0.02%) to 85.314% when pulling c017c59fded7ea41ad96ad9a09b32ed5a37f8394 on omelkonian:master into a1779d85d05824c1814e42baf1724e3cdebbd672 on inveniosoftware:master.

@omelkonian please amend commit message (s/Cern/CERN/) and reformat the bullet points (kwalitee check message).

Although I cannot find any occurence of 'Cern'.

@omelkonian look to the commit message ...

@omelkonian please remove merge commit.

Coverage increased (+0.02%) to 85.314% when pulling 4d8dd1743fb2f32a2bf449a3a7f0f3c0bd9d59ea on omelkonian:master into be2e97906d1a3bf5e69a7f2c42c89c31c731aa46 on inveniosoftware:master.

@omelkonian I have checked the diff again and I see that you have replaced the quotes everywhere. It's ok, but it should be in separate commit. Also make sure that you write CERN and not Cern.

WDYT about s/contrib: strings' formatting/global: quotes usage unification/?

@omelkonian please use labels (FIX, NOTE) only when the message is important for readers of release notes. In the case of first commit you can remove the FIX label as it is just styling (* FIX Converts strings to be more uniform ...) and if you would really like to announce such change then label BETTER [1] is more appropriate.
--
[1] http://invenio.readthedocs.io/en/latest/technology/git.html#r2-remarks-on-commit-log-messages

Besides @jirikuncar's comment LGTM

@omelkonian please keep the branch up-to-date with the master branch and have a look to unresolved comments.


Slug is not updating on update()

I am trying to update record's name by which slug is generated. But it's not working.
For eg. I have divisions and I am updating the specific record.
Here's the code:
Division::where("slug", $this->slug)->update([
            "name" => ucwords($request->get("name")),
        ]);

When I update name, I want to update it's slug as well.
In model Division:
<?php

namespace App\Model;

use Illuminate\Database\Eloquent\Model;
use Cviebrock\EloquentSluggable\Sluggable;

class Division extends Model
{
    use Sluggable;
    /**
     * Return the sluggable configuration array for this model.
     *
     * @return array
     */
    public function sluggable()
    {
        return [
            'slug' => [
                'source' => 'name'
            ]
        ];
    }
}

Please help me with this. Thanks in advance!

The update method just does a DB update, so the slugging event isn’t fired. You just need to break it down into steps:
$division = Division::where("slug", $this->slug);
$division->name = ucwords($request->get("name"));
$division->save();

Colin

On May 30, 2018, at 6:00 AM, ankitasoman<EMAIL_ADDRESS>wrote:
Division::where("slug", $this->slug)->update([
"name" => ucwords($request->get("name")),
]);


"apt-get" not working from inside the container.

I have been using "frekele/ant" image for many years, without a problem. Today I happen to notice the problem when running apt-get commands. For example:

apt-get -y update && apt-get install -y subversion

As a result, I got many "404  Not Found" errors:
...
Err:9 http://deb.debian.org/debian stretch/main amd64 Packages
  404  Not Found
Ign:10 http://deb.debian.org/debian stretch/main all Packages
Err:11 http://deb.debian.org/debian stretch-updates/main amd64 Packages
  404  Not Found
Ign:12 http://deb.debian.org/debian stretch-updates/main all Packages
Reading package lists... Done
W: The repository 'http://security.debian.org/debian-security stretch/updates Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
W: The repository 'http://deb.debian.org/debian stretch Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
W: The repository 'http://deb.debian.org/debian stretch-updates Release' does not have a Release file.
N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: Failed to fetch http://security.debian.org/debian-security/dists/stretch/updates/main/binary-amd64/Packages  404  Not Found [IP: <IP_ADDRESS> 80]
E: Failed to fetch http://deb.debian.org/debian/dists/stretch/main/binary-amd64/Packages  404  Not Found
E: Failed to fetch http://deb.debian.org/debian/dists/stretch-updates/main/binary-amd64/Packages  404  Not Found
E: Some index files failed to download. They have been ignored, or old ones used instead.

Is there a problem with the latest docker image, or Debian distribution system?

I encountered this problem as well, an explanation for the cause is here https://unix.stackexchange.com/questions/743839/apt-get-update-failed-to-fetch-debian-amd64-packages-while-building-dockerfile-f
Basically this image needs to be updated to use a newer base image.


Certificate: tls-rancher-internal is expiring, how to renew ?

Hello,
Certificate: tls-rancher-internal is expiring in a few days, and I don't find the way to renew it.
Rancher cluster is RKE deployed.
rke version v1.3.11
Rancher version v2.5.9
Kubernetes version v1.20.9-rancher1
This solution is already tested, all commands OK but the cert is still expiring :
https://www.suse.com/c/rancher_blog/manual-rotation-of-certificates-in-rancher-kubernetes-clusters/
Any clue on wath to do ?
Thanks by advance.

Restarting Rancher should trigger a renewal of this certificate
Run the below on the local cluster.
kubectl rollout restart deployment rancher -n cattle-system

After checking in on things I have discovered some more information
The tls-rancher-internal certificate is used by Rancher to secure the https-internal port, on which Rancher listens on port 444. This is used to secure communications between the rancher replicas. The secret is created/updated by Rancher as required, and will be rotated by Rancher when needed, so this expiring certificate in the secret is no cause for concern.

Restarting don't fix the "problem".
The certificate has expired and everything seems to work, as you say, wait and see. Maybe it will be renewed at next Rancher upgrade.
Thanks for your answers.

The certificate seems to renew in later versions of Rancher e.g 2.5.14
Please try upgrading to a later version as this is used to communicate web-socket processes between Rancher pods.
A workaround if you did encounter issues would be to scale Rancher replicas down to 1 until you could upgrade to a later release of 2.5.x


Bumped protobuf version to v1.26

Bumped google.golang.org/protobuf and its dependency github.com/golang/protobuf to current latest stable versions.

@googlebot I signed it!

is there any particular fixes that impacts you? @vgarvardt

This PR was supposed to solve an issue that I have with gradle task that generates code for several languages. After adding TypeScript the task started to fail with the following error message:
Execution failed for task ':generateProto'.
> protoc: stdout: . stderr: 2021/06/15 22:38:34 WARNING: Malformed 'go_package' option in "acme/type/iso_week_date.proto", please specify:
  	option go_package = "github.com/acme/schema-registry-go/type;__type";
  A future release of protoc-gen-go will reject this.

Given that I recently bumped protoc-gen-go version to 1.26 and it has go_package related changes my hypothesis was that ts generator does not work well because of the older version of the library used in its deps.
After doing more tests - both running protoc with plugins manually and with gradle tasks I found out that actually something is wrong with gradle task error output - with all other plugins disabled the error makes much more sense:
Execution failed for task ':generateProto'.
> protoc: stdout: . stderr: acme/type/iso_week_date.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-grpc-gateway-ts hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--grpc-gateway-ts_out:

I will create an issue regarding optional support for the generator.
This PR does not make a lot of sense so far and can be closed, unless you want to keep main deps up to date for the future release.

ah, right. it doesn't make much of a difference so I'll close this PR for now.


ansible-galaxy collection install -r requirements.yml might not be working as expected

On Ubuntu 24.04, I add to diverge from the README#getting-started.

then

I feell like requirements.yml is not working as expected.

Getting the same error on macOS 14.6.1. Using ansible-galaxy role install geerlingguy.swap worked, thank you @mpressen.

Fixed by https://github.com/guillaumebriday/kamal-ansible-manager/pull/12


Added items as json with dates

Coverage decreased (-20.8%) to 79.245% when pulling 927e8eb91b50161546872862a4c81821840f8be2 on json-dates into 9157efe8cfcb73369c75085dd743510425dcf825 on master.

Coverage remained the same at 100.0% when pulling 22ffbcef2f92178ee557177c0f503a053793349d on json-dates into 9157efe8cfcb73369c75085dd743510425dcf825 on master.


[DOCFIX] Add a bootstrap-conf command snippet in the Chinese version of docs/en/Configuring-Alluxio-with-Swift.md

This PR fixes issue with JIRA ticket ALLUXIO-1982
In docs/en/Configuring-Alluxio-with-Swift.md of the English version there is a bootstrap-conf command snippet added in the Initial Setup section. This PR translate it into Chinese and add it in the corresponding page of the Chinese version.

Can one of the admins verify this patch?

Seems like this ticket has already been taken in https://github.com/Alluxio/alluxio/pull/3456
Before working on one JIRA ticket, please assign it to yourself first to avoid duplicate work...

If you don't mind, can you please close this PR since the other (#3456) was submitted first.

@ifcharming Actually we are not duplicated. the #3456 is fixing a different file (Configuring-Alluxio-with-GlusterFS.md), while my PR fixes the docs/en/Configuring-Alluxio-with-Swift.md

And by the way the JIRA has indeed been assigned to me :-)

oops, sorry they look too similar...
LGTM, thanks for the improvement!

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/10262/
Test PASSed.


Pretrianed

Thank you for your open source code！How can I use the pretrained data?I'm major in vehicle engineering but not computer vision.So this question really confuse me a lot.

Maybe you can first try to Google or Baidu: "how to load pretrained model in pytorch"
Then, you can try to use the provided test.py file to evaluate.
Remember to change the pretrained file path in the corresponding config file.

Maybe you can first try to Google or Baidu: "how to load pretrained model in pytorch" Then, you can try to use the provided test.py file to evaluate. Remember to change the pretrained file path in the corresponding config file.

Thanks for your reply.I have been training MVPdataset for 50 hours at batchsize=2.But only 8 epoch have finished.Can I finish it in ten days?

It seems like you do not have a good GPU... If that is the case, I would suggest trying simpler architectures...


Support Plutarch

TODO:

[ ] Map Plutus LB types to Plutarch equivalent.
[ ] Type definition printing.
[ ] Implementation printing (PlutusData class/encoding).
[ ] Testsuite.

This is going to be a tricky one!
Will write down some of my thoughts.
Given a Foo .lbf module:
module Foo

import Plutus

sum FooSum a b = Bar a (Maybe Address) | Baz b (Maybe AssetClass)
derive Eq (FooSum a b)
derive Json (FooSum a b)
derive PlutusData (FooSum a b)

prod FooProd a b = a (Maybe Address) b (Maybe AssetClass)
derive Eq (FooProd a b)
derive Json (FooProd a b)
derive PlutusData (FooProd a b)

prod FooRec a b = {
  bar : a (Maybe Address),
  baz: b (Maybe AssetClass)
  }
derive Eq (FooRec a b)
derive Json (FooRec a b)
derive PlutusData (FooRec a b)

How do we map type definitions and implementations.
Type definition mapping
module LambdaBuffers.Plutarch.Foo where

data FooSum (a :: PType) (b :: PType) (s :: S) = FooSum'Bar (Term s a) (Term s (PMaybe PAddress))
   | FooSum'Baz (Term s b) (Term s (PMaybe PAssetClass))

data FooProd (a :: PType) (b :: PType) (s :: S) = FooProd (Term s a) (Term s (PMaybe PAddress)) (Term s b) (Term s (PMaybe PAssetClass))

I need a bit more clairification on PlutusType and PIsData relationship...
I'm implementing my pcon' for my type, and I have to call pdata on its constituents? This is suprising to me:

Why not further call pcon'  on constituent types?

Because! These are already pcond values, ie. constructed values, and now you need access to their Data form (fundamentally it's already in this form, we just have to massage the types with pdata)

Is default PIsData implementation doing the above in some way?

I think so? It just does a pto which gives you the PData of your PType (that's what PInner is for).

Why would PIsData implementations, pfromDataImpl and pdataImpl, ever be anything but 'take the underlying PData and pass that along'

Not sure about that? Anyone?

I might be forgetting that we have ScottEncoded variants on everything so perhaps that is why?

What's the deal with PTryFrom?

Eventually, I need to get from PData into my Term s Smtn, is PTryFrom also doing pmatch in the background (as the default impl)?

PEq is interesting

Because values of PTypes are PData, equality is deferred to PData equality. Is this fundamentally solid? As in; is there 2 different PData representation of the same 'value' that would break this assumption? Can't think of anything.


Make CoreAnnotationNames internal

Used:

ProxyBindingRewriter uses CoreAnnotationNames.ConstructorBinding
SqlServerModelValidator uses CoreAnnotationNames.TypeMapping

See also #17160 for relational annotations.

For the first one, just use internal
For second one, add API to ask for the metadata we need--e.g. configuration source.


PATH modification customization not working

I tried to disable PATH modification, but it appears that it didn't listen to me.  😂

It is lying to you ;) But we should update the message there and only show the part about the PATH modifications when they are actually going to happen.

Ok, I think this should be fixed in the latest build.


[csharp_dotnetcore][14.nlp-with-dispatch] msbot clone services does not work

The README contains the following command to clone the bot:
msbot clone services --name "" --luisAuthoringKey "" --folder "DeploymentScripts/MsbotClone" --location "ie, westus"
Ran into two problems with this.

--location ""ie, westus" is incorrect - no ie region. Fixed by changing to --location "westus"

The command does not seem to pick up the resource group name correctly. msbot help says the bot name is used for a resource group if no resource group name is specified. Command fails as follows whether I do not specify a resource group name, or whether I explicitly do.

My command with resource group name specified:
msbot clone services --name "nlp-with-dispatch" --luisAuthoringKey "[HIDDEN]" --folder "DeploymentScripts/MsbotClone" --location "westus" --groupName "bot-nlp-with-dispatch" --verbose
This repeatably yields the following error. Yes, I have updated CLI, Powershell, etc. to latest of all. Note the "undefined" passed to the az commands by msbot.

The following services will be created by this operation:
Service                                 Location            SKU                 Resource Group
Azure App Site Plan                     westus              S1                  bot-nlp-with-disp…
Azure AppInsights Service               West US 2           F0                  bot-nlp-with-disp…
Azure Blob Storage Service              westus              Standard_LRS        bot-nlp-with-disp…
Azure Bot Service Registration          Global                                  bot-nlp-with-disp…
Azure LUIS Cognitive Service            westus              S0                  bot-nlp-with-disp…
Azure LUIS Cognitive Service            westus              S0                  bot-nlp-with-disp…
Azure LUIS Cognitive Service            westus              S0                  bot-nlp-with-disp…
(Dispatch)
Azure QnA Maker Service                 westus              S0                  bot-nlp-with-disp…
Azure Search Service                    westus              Standard            bot-nlp-with-disp…
Azure WebApp Service (Bot)              westus                                  bot-nlp-with-disp…
Azure WebApp Service (QnA)              westus                                  bot-nlp-with-disp…
Would you like to perform this operation? [y/n]y
Checking az botservice version
az -v
Fetching subscription account
az account show
Creating resources in subscription: undefined undefined
Creating Azure group [bot-nlp-with-dispatch]
az group create -g bot-nlp-with-dispatch -l westus
Creating Azure Bot Service [nlp-with-dispatch]
az bot create -g undefined --name nlp-with-dispatch --kind webapp --location westus --insights-location "West US 2"  --version v4
[az bot] To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code AKE8DTCD7 to authenticate.
[az bot] obtained msa app id and password. Provisioning bot now.
(Please be patient, this may take several minutes)
az bot create -g undefined --name nlp-with-dispatch --kind webapp --location westus --insights-location "West US 2"  --version v4 exit code: 1
WARNING: The behavior of this command has been altered by the following extension: botservice
WARNING: To sign in, use a web browser to open the page https://microsoft.com/devicelogin and enter the code AKE8DTCD7 to authenticate.
WARNING: obtained msa app id and password. Provisioning bot now.
ERROR: Resource group 'undefined' could not be found.

You are correct. The "ie, westus" was supposed to denote an example of what the --location argument should look like and should only contain the region itself (e.g. "westus", "australiaeast", "westeurope")

Was not able to repro @plzm 's issue

Used following commands in C# sample 14. nlp-with-dispatch
With --groupName:

msbot clone services -n ashleyhogroupnamedelete --luisAuthoringKey b7xxxxxxxxxxxxxxxxxxxxxxxxxxxx67 -f DeploymentScripts/MsBotClone -l westus --subscriptionId xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx --verbose --groupName ashleyhogroupnamed2

Without --groupName:

msbot clone services -n ashleyhodeletemeplease --luisAuthoringKey b7xxxxxxxxxxxxxxxxxxxxxxxxxxxx67 -f DeploymentScripts/MsBotClone -l westus --subscriptionId xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx --verbose

Both created services and deployed to Azure portal successfully.

Note: was only able to get commands to work in windows Command Prompt as the "az" commands in general don't work in git bash I noticed

I am experiencing a similar issue in that the clone command ends with: You did not complete clone process.

Following the az -v command we see this message in red: operable program or batch file.ot recognized as an internal or external command,
Then a listing of all the options appears and the clone aborts
our msbot version is : 4.0.7

Our command is as follows:
msbot clone services --name "botName" --luisAuthoringKey "XXXXXXXXXXXXXXX" --folder "DeploymentScripts/MsbotClone" --location "westus" --subscriptionId "XXXXXXXXXXXXXX"

See https://github.com/Microsoft/botbuilder-tools/issues/768#issuecomment-444760635 for instructions on how to clone successfully

I encountered the same issue,  and I managed to find out that it's due to the default output format, which is set to "table",  I need to reset it to "json" format, by running "az confiugre".


Playlist always jumps to top (making it impossible to browse it)

Bug report
As per subject: Playlist always jumps to top (making it impossible to browse it)
Expected Behavior
I expect to be able to browse the playlist.
Actual Behavior (To Reproduce)

Using Kore 2.5.0
Enqueue a long music playlist (75 tracks is my typical and I use an addon to enqueue them)
Playlist is populated and looks good
Swipe up to scroll down the playlist examining what's on it (as my addon is a mix producer)
Every second or so the view jumps back to top, making it impossible to browse the playlist

Screenshots
Can record a video of the behaviour if it helps. And provide link.
Your Environment

Mobile device: Honor 9
Android version: Android 9
Kodi version and platform: 18.6
Kore version: 2.5.0

Thank you for the issue report. I've not been able to reproduce this issue. Does this also happen when creating a long playlist without using the addon? For instance, by simply selecting all songs from an artist from your library?

Thanks for getting back to me. I just tried. Admittedly I have a few other problems with Kore. For example I go to Music, then Albums, I see a load of entries, I add one to playlist and it's one song not an album. Hmmm. So I went o  Music and Artists, and scrolled down to find a prolific artist and click add to playlist and got  large playlist. Then wen to look at it and swiped down down down, paused and flip it went straight to top again.
Very odd. If you don't see it and I do, it suggests an environmental trigger. So to explore that briefly:

I have Kodi running (on a HTPC on my LAN)
a. It's not playing
b. It's just on the home page
I added files to playlist on Kore using Music/Artists and "Add to Playlist" on a prolific artist
My phone is not "quiet"  as in other things are running on it (for example Blokada  is always running and Andoid is notorious for lingering background apps). So...
a. I rebooted the phone
b. I turned off Blokada (an ad blocker that watches network traffic)
c. I killed all background apps (I used KillAll)
d. I started Kore and went to the playlist and swiped up to scroll down and ... it jumps to top again/still.
e. So obvious interplay with other apps. Not a 100% sure test. But I ran KillAll angain after, and the only things it found running were Blokada, Facebook and Messenger. Interesting to see how tenasciously those last to autostart themselves. Blokada I expect as I ran it, to turn it off. It operates at the VPN level and to be sure it's off I turned it off. I can't for love or money imagine that it's URL based blocking could cause this behaviour but to be sure I turned it off.

Summary: Yes, it doesn't matter how I build the playlist. No I can't find any obvious environmental interplay.
Which begs the question are there debugging options of any use (can Kore run in a debug mode that leave a log file? Even if I had to install a debug build?).

Are you by any chance using HTTP to connect to Kodi?
I was able to reproduce your issue by changing the host configuration in Kore and deselect "Use TCP". Kore will then use HTTP to get data from Kodi and uses a 2 second interval. Every 2 seconds the playlist is retrieved and the UI updated. This resets the scroll position and thus the playlist jumps to the top.

I have the same problem. "Use TCP" is deselected (I tried selecting it to see if the issue still happens but for the some reason the setting isn't saved). This was not happening on earlier versions of Kore, although I am not sure on which version the issue first occurred.

Are you by any chance using HTTP to connect to Kodi?
I was able to reproduce your issue by changing the host configuration in Kore and deselect "Use TCP". Kore will then use HTTP to get data from Kodi and uses a 2 second interval. Every 2 seconds the playlist is retrieved and the UI updated. This resets the scroll position and thus the playlist jumps to the top.

Ingenious! I hadn't even seen that seeing (well long forgotten it as I'm sure I saw it when I first installed Kore ages ago and set it up). So took me a while to find it. But I turned on TCP and checked and alas the problem persisted. So I rebooted the phone, and thee problem is gone! I can browse! Yay! Makes the playlist useable. Brilliant insight.
I find that if I leave Kore (and do other things) then come back to it, it's popped back to top. But no big drama there. State between app use on Android is no guraantree. The main things I can browese the play list.
I'd stop short of close this as resolved, as I think while it's helped me enormously now , that is still technically a work around to a bug that does exist when not using TCP. We're just now, closer to nailing it as it's reproducible!

I have the same problem. "Use TCP" is deselected (I tried selecting it to see if the issue still happens but for the some reason the setting isn't saved). This was not happening on earlier versions of Kore, although I am not sure on which version the issue first occurred.

As noted above I just tried and it was saved and persisted across a reboot too. I did click the Test button, which had oddly silent behaviour, as in it just closed that screen really didn't report anything positive or negative, so I inferred success (rightly or wrongly) but then as noted above I went to playlist and the problem persisted. Until I restarted my phone and it went away.

@regagain Kore tests if a direct connection using TCP can be made and if not falls back to polling over HTTP. This issue was introduced in 2.5.0 when we introduced showing available playlists on Kodi. In previous versions only active playlists would be shown and if nothing was playing the playlist screen would be empty.
@bernd-wechner indeed we can keep this issue open to solve the issue for HTTP connections.

Closing this as #740 has been merged to master. If the issue reappears please reopen this with any additional info.


Setup Melodic doc jobs for fanuc and fanuc_experimental.

As per subject.

I would also encourage you to add the src entries as well which will allow source based tools like rosinstall generator to integrate it. If you don't want the devel jobs yet you can disable them with
test_commits: false
like here: https://github.com/ros/rosdistro/blob/34b0fd01366bf1f25fe9475003d4b1e4d8e4c148/kinetic/distribution.yaml#L941

See #22338.


Fix typo in promise_rejects example

The promise_rejects function expects a Promise as third argument, not a function. The "bar" function needs to be called.

This change is

Thanks!


Add timeout for auto-completion

When data is super large, the UI may freeze while performing autocompletion.
This change adds a 200 ms timeout to the autocompletion request and gives up the autocompletion when timeout, which makes the query bar more usable for a larger data file.

Codecov Report

Merging #80 (7695136) into main (654a5d9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   87.85%   87.89%   +0.03%
==========================================
  Files          82       82
  Lines        2742     2750       +8
  Branches      343      343
==========================================
+ Hits         2409     2417       +8
  Misses        258      258
  Partials       75       75

Flag
Coverage Δ

test-macOS-latest-3.8
?

test-ubuntu-latest-3.8
87.89% <100.00%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/pyfx/app.py
97.40% <100.00%> (+0.06%)
:arrow_up:

src/pyfx/service/client.py
100.00% <100.00%> (ø)

src/pyfx/view/components/query_bar/query_bar.py
95.08% <100.00%> (+0.43%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Develop

@Mayyzze Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@Mayyzze Thank you for signing the Contributor License Agreement!


HDDS-9376. Remove isAdmin check from allocate and delete block flow.

What changes were proposed in this pull request?
isAdmin check is added in multiple flows in HDDS-1796. By default SCM process admin is just SCM user. In secure cluster, when request comes from OM to SCM for allocateBlock and  deleteKeyBlocks isAdmin check fails as request user is OM and OM is not admin for SCM process by default.
In this PR removing the isAdmin check for allocateBlock and deleteKeyBlocks and keeping the behaviour same as before.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9376
How was this patch tested?
Verified manually in cluster

@ChenSammi @devmadhuu @sumitagrawl, Please help to review.

@ashishkumar50 thanks for working over this, IMO, having admin check is required, We can add process user to ozone.administrator as pre-condition and in upgrade impact.

I have opened another Jira to track this
https://issues.apache.org/jira/browse/HDDS-9403

@adoroszlai Please check as all checks are not triggered


attach-geth command

I found myself with a need to attach to geth relatively often and I think it would be nice if there was a convenient command for it. I propose ./ethd attach-geth, but if you want something more generic that can work with other softwares as well I could try to change it to that. e.g. ./ethd attach execution and try automatically figure out the correct command for each type of execution client

Thank you. By all means, if it's useful, though I'd argue that a shell alias for the docker compose command that attaches to Geth would have been just as well :)


v0.8.0: fix mishandling of byte sequence partially matching delimiters

Thanks to @josebama for the contribution!

Supersedes #112.
Fix #111.


JSON update: content problems

UPDATE also failed to change source keys or target contents.

test error…


feat: make all asset paths relative #59

All resources are loaded relative to the root document URL in order to allow path prefixes.
These are the necessary FE changes.
Assumptions
It's assumed that only https://github.com/h2oai/wave/blob/424c77ab770d062ca99e5544b02a63e4d8cf791b/server.go#L109 will be affected by the prefix (let me know if I am wrong), so file upload and socket server can remain the same.
Needs discussion
The aim of this PR is to allow path prefixes, this will break initial websocket slug payload since pathname can now consist of subpath + site/app route. I can think of 2 solutions:

Constrain site route annotation to not include /.
Parse route payload within Go server and update (strip prefix) accordingly since the server will be able to tell the boundary between subpath and site/app path.

Second option seems better IMO.

Closing since this PR was used as a base for #1104.


Make the development environment as close as possible to production

This task is almost completed. The rails application cannot be started because bundle isn't found, because it is a symlink to /srv/velum/vendor/bundle/ruby/2.1.0/bin/bundler.ruby2.1, and for development purposes we are mounting velum's source code in /srv/velum. I'd like to avoid mounting only specific folders and/or files within the velum project, because this can cause confusion in the future and is hard to track.
Once that this is fixed (I am checking it out), and once that the automation is in place to automatically push containers to docker-testing-registry.suse.de the development environment should work fine. In the meanwhile that this automation is in place I already pushed all required sle12 images (velum, salt-master, salt-minion, salt-api, mariadb) to docker-testing-registry.suse.de with their tags, so unless the Gemfile or Gemfile.lock changes you can still test it (remember to add docker-testing-registry.suse.de as insecure registry to your docker options in /etc/sysconfig/docker.
Status:

[x] Remove development manifests
[x] Remove specific pillar substitutions
[x] Point to the manifests using CONTAINER_MANIFESTS_DIR envvar along with the start script
[x] Script that takes production manifests and does the required changes and substitutions to convert them to development manifests
[x] Make velum gem vendoring work despite source code is mounted in /srv/velum
[x] Tests can be executed and pass
[x] Fix and add documentation

This is almost ready... Tomorrow should be reviewable...

Please note, this isn't still ready for merge. We need to adapt some configuration settings (like salt master pointing to velum_production) and adapt documentation. I will add you as reviewers and remove the WIP when this is completely done.

Review time! :clap:

we still need to adapt the e2e-tests, I'll do that

Now the problem is that patches (https://github.com/kubic-project/velum/tree/master/packaging/suse/patches) cannot be applied without modifying the real source the developer is working on and making dirty the working copy.
Specially, the patch https://github.com/kubic-project/velum/blob/master/packaging/suse/patches/1_set_default_salt_events_alter_time_column_value.rpm.patch is required for the salt events to be created on the database by the salt master.
Rails 4 doesn't support adding a default value based on a function like CURRENT_TIMESTAMP, so the schema loaded when starting the development environment does not set a default alter_time column value, making the salt-master container throw this exception when trying to register salt events in the velum database:
(1364, "Field 'alter_time' doesn't have a default value")[ERROR   ] Could not store events - returner 'mysql.event_return' raised exception: (1364, "Field 'alter_time' doesn't have a default value")
Ideally we shouldn't have patches on this repository. We should find a way to at least make this one work.

not sure I can follow. don't we use the already patched version of velum from the sle12/velum:0.0 image?

@MaximilianMeister Yes, but the patched version disappears when we mount our source code on /srv/velum inside the container. A fix is coming and I will keep it as a separate commit since I would like to revert it soon...

I can successfully see new nodes appearing, and run a successfull orchestration (green deployment).

freedom-desktop suse/e2e-tests@master VELUM_BRANCH=pull/135/head rspec spec/**/*
Cleaning up running minions
Starting environment
Registering user
Setting up velum
Spawning minions
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: [Minion.highstates[:applied], Minion.highstates[:failed]]).count'
>>> docker exec 39e7fce57597 rails runner 'ActiveRecord::Base.logger=nil; puts Minion.where(highstate: Minion.highstates[:applied]).count'
.

Finished in 3 minutes 38.2 seconds (files took 0.48069 seconds to load)
1 example, 0 failures


mention defaults in config example

see diff

Correct default is src/index.js. Could you please update it? Thanks!

https://github.com/webpack/webpack/pull/6140/files#diff-7473dd12403a310ad8cf18d0ab9f10b9R20

Yes, you are right. Also, could you please change base branch to next? It is used to track all webpack 4 changes

@montogeek @webpack it's not next; is version 4 is released so I'm merging it to master, and guys in webpack do not release new version if you don't update the documentation, that's totally irresponsible in my opinion, if you access webpack.js.org that docs is marked to be for version 4 and it's not.
and you mark it has enhancement? I cannot found the new default values anywhere, so please update the docs as soon as possible

This is a different repo from webpack, next is used to track all webpack 4 changes (#1856 ), once everything is ready it will be merged to master.
That bagde in the website refers to the latest version available, not the version of the documentation.

well that should be changed, it's misleading if that's not a version of documentation so what is? look at the screenshot, everybody will think that that's a documentation for version 4

Yes, definitely, we already talked about it in https://github.com/webpack/webpack.js.org/issues/1854


Add examples for device notification

This would be nice since I am unable to access data from pyads.structs.SAdsNotificationHeader

I agree, the handling of device notifications is a bit awkward. I want to take care of it in the near future.

Let me help you:
def callbackBool(self, adr, notification, user):
        contents = notification.contents
        var = map(bool, bytearray(contents.data)[0:contents.cbSampleSize])[0]

def callbackInt(self, adr, notification, user):
        contents = notification.contents
        var = map(int, bytearray(contents.data)[0:contents.cbSampleSize])[0]

def callbackString(self, adr, notification, user):
        dest = (c_ubyte * contents.cbSampleSize)()
        memmove(addressof(dest), addressof(contents.data), contents.cbSampleSize)
        # I had some NULL bytes in my string...
        var = str(bytearray(dest)).split('\x00')[0]

Regards,
Peter

Thank you!
For accessing a float I used:
import struct def callbackFloat(adr, notification, user):     contents = notification.contents     var = struct.unpack('f', bytearray(contents.data)[0:contents.cbSampleSize])[0]

Now I just need to access the timestamp also.
According to Beckhoff infosys: "The time stamp is transferred in the FILETIME format."
I am unsure how to use the integer from nTimeStamp since it is not in FILETIME format, or is it?

Have a look at the C++ examples.
Since the timestamp is a 64bit integer I would assume they use an unix timestamp.

Beckhoff uses Windows FILETIME for their timestamps which differs from unix timestamps.

64-bit FILETIME structure, which represents the number of 100-nanosecond intervals since January 1, 1601 UTC

However I am not sure how I should handle the python integer that is available in nTimestamp
For one event I get<PHONE_NUMBER>373236323 and the next time I run I get<PHONE_NUMBER>4432436324
None of these are a Windows Filetime...
I wonder if nTimeStamp should be of another type?
class SAdsNotificationHeader(Structure):
    _pack_ = 1
    _fields_ = [("nTimeStamp", c_uint64),   <-- wrong datatype?
                ("hNotification", c_uint32),
                ("cbSampleSize", c_uint32),
                ("data", POINTER(c_ubyte))]

As we can see in the example linked by pjaneck in C++ the 64-bit value is converted into a TIMESTAMP.
  LargeInteger.QuadPart = pNotification->nTimeStamp;
  FileTime.dwLowDateTime = (DWORD)LargeInteger.LowPart;
  FileTime.dwHighDateTime = (DWORD)LargeInteger.HighPart;

Should pyads also do this? I tried using ctypes.wintypes.FILETIME but had no success since I am unsure how to implement it. Just changing the type in SAdsNotificationHeader still just returns an integer that is not a FILETIME.

@pjaneck Thank you for the Examples you provided here. I will include them in the documentation.

@kirlek In the Beckhoff documentation  the Timestamp is declared as a 64 Bit value. So this should be OK. I agree with yout that pyads should return a datetime.datetime value. I'm currently working on a decorator to handle the transformation.

@kirlek. Now I know what you mean. The timestamp doesn't make any sense at all. Tried a few ways to figure out how it is calculated. No success so far :(

This issue now gets handled in #33.


Use singular in plugin option

The idea is that if you can pass multiple plugins and it's not a list passed once, then you should call --plugin repeatedly. It's just a semantic change.
This PR is based on the same branch as PR #1

ping @drowzy

Thank you @drowzy


Feature for Mercure dedicated cookie?

Hi,
I am using the split cookie approach with succes on API Platform and now I'd like to add Mercure to my project. For private notifications, Mercure requires a JWS cookie named mercureAuthorization which contains topics the user is allowed to subscribe. This cookie has to be Secure, HttpOnly and Same-site.
Without the split cookie approach I could just add the topics into the authentification cookie and Voilà. But I'd like to keep the split cookies approach and generate a third one dedicated to Mercure. Is it doable through simple configuration of this bundle? If not, would a PR be within the scope of this bundle?
Without split cookie:

only 1 cookie for all
Secure, HttpOnly and Same-site
contains JWT for symfony auth + Mercure topics

With split cookies:

1 cookie with header+paylod for Symfony auth : Same-site
1 cookie with signature for Symfony auth : Same-site + Http-only
1 cookie for Mercure (header+custom payload+signature): Same-site + Http-only

I just found that the split cookies configuration allows the creatation of a third one with the whole cookie (header+paylod+signature). So the following is an overkilling solution but works:

Put mercure payload in the authentication cookie (topics the user can subscribe)
Set the config accordingly:

lexik_jwt_authentication
   token_extractors:
        split_cookie:
            enabled: true
            cookies:
                - jwt_hp
                - jwt_s
    set_cookies:
        jwt_hp:
            lifetime: 1800
            samesite: strict
            path: /
            domain: null
            httpOnly: false
            split:
                - header
                - payload

        jwt_s:
            lifetime: 0
            samesite: strict
            path: /
            domain: null
            httpOnly: true
            split:
                - signature

        mercureAuthorization:
            lifetime: 1800
            samesite: strict
            path: /
            domain: null
            httpOnly: true
            split:
                - header
                - payload
                - signature

Share the public key generated by Lexik with Mercure and set set the algorithm accordingly

Main drawback: both JWT becomes heavier (big concern if you have many topics in Mercure payload). It's ok for Mercure connexion (the client only send it when subscribing and keep connexion open), but the JWT used for auth is used at each connexion (and it doesn't need the eventually huge Mercure payload).

Thanks for the issue and feedback. Please keep this open, I need to have a look asap :)


Feedback for: engine/reference/api/docker_remote_api_v1.24.md

File: engine/reference/api/docker_remote_api_v1.24.md
The container stats based on resource usage has values could be provided with the information like the metric or units the values signify.
"total_usage" : 100215355, in cpu_stats the value 100215355 is something which I cannot understand, whether it is a time in ms or ns, or a percentage per something.

Self assigning this (beastly-numbered) issue which will be obsolete when #606 merges.


Render breadcrumbs using the govuk_component

There is no change to the appearance or text of the breadcrumbs, but
they are now rendered by the govuk_component.

Trello card
Before (full width and mobile width)

After (full width and mobile width)

Could you include some screenshots of before and after?
Please include mobile widths – we've seen bugs with the breadcrumb component at thin viewports here: https://github.com/alphagov/collections/issues/210

Thanks @fofr - I've added the screenshots and changed the commit message to make it clearer that the breadcrumbs should look the same before and after (it's just the way they are rendered that has changed).


feat(controller): Panic or error on mis-matched resource version

Checklist:

[x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
[x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
[x] I've signed the CLA.
[x] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
[x] My builds are green. Try syncing with master if they are not.
[x] My organization is added to USERS.md.

See #3862

2020-09-14T19:29:03.8397834Z --- FAIL: TestArgoServerSuite (38.73s)
2020-09-14T19:29:03.8398765Z     --- FAIL: TestArgoServerSuite/TestWorkflowService (2.28s)
2020-09-14T19:29:03.8399892Z         --- FAIL: TestArgoServerSuite/TestWorkflowService/Terminate (2.00s)
2020-09-14T19:29:03.8402489Z             reporter.go:39:
2020-09-14T19:29:03.8403200Z                 	Error Trace:	reporter.go:39
2020-09-14T19:29:03.8403645Z                 	            				chain.go:21
2020-09-14T19:29:03.8404038Z                 	            				helpers.go:33
2020-09-14T19:29:03.8404430Z                 	            				value.go:81
2020-09-14T19:29:03.8404854Z                 	            				argo_server_test.go:805
2020-09-14T19:29:03.8405261Z                 	            				suite.go:77
2020-09-14T19:29:03.8406033Z                 	Error:      	child 'message' not found in JSON object at 10
2020-09-14T19:29:03.8406853Z                 	Test:       	TestArgoServerSuite/TestWorkflowService/Terminate
2020-09-14T19:29:03.8408024Z         --- FAIL: TestArgoServerSuite/TestWorkflowService/Resubmit (0.00s)
2020-09-14T19:29:03.8408815Z             reporter.go:39:
2020-09-14T19:29:03.8409252Z                 	Error Trace:	reporter.go:39
2020-09-14T19:29:03.8409685Z                 	            				chain.go:21
2020-09-14T19:29:03.8410203Z                 	            				response.go:585
2020-09-14T19:29:03.8410798Z                 	            				response.go:151
2020-09-14T19:29:03.8411252Z                 	            				argo_server_test.go:813
2020-09-14T19:29:03.8411653Z                 	            				suite.go:77
2020-09-14T19:29:03.8411991Z                 	Error:
2020-09-14T19:29:03.8412408Z                 	            	expected status equal to:
2020-09-14T19:29:03.8412789Z                 	            	 "200 OK"
2020-09-14T19:29:03.8413079Z
2020-09-14T19:29:03.8413392Z                 	            	but got:
2020-09-14T19:29:03.8413813Z                 	            	 "500 Internal Server Error"


npm3's flat node_modules structure causes 'not found' error when extracting text from Excel

Hey, for your Textract module, there is a bug now because of the new Nodev6.2.2 when extracting text from Excel.
Error: Could not extract usearch-1466710851433.xlsx, Command failed: /home/praneeth/Upward/uapi/node_modules/textract/node_modules/j/bin/j.njs ./test/tmp/xlsx/usearch-1466710851433.xlsx
/bin/sh: 1: /home/praneeth/Upward/uapi/node_modules/textract/node_modules/j/bin/j.njs: not found
Because of Nodev6's flat node_modules structure now, the "j" library cannot be found, it's now located in the same node_module folder as "textract" and everything else.

There is a PR that addresses this.  Will be furthering along towards 2.0 this weekend.  Expecting to release weekend of the 4th.

This is resolved with https://github.com/dbashford/textract/pull/89, just needs release. Hopefully sometime later this week or during the long weekend.


Home / End Keys doesn't work properly on Photoshop

As title says. It puts 'a' or 'e' instead. Just like hitting ctrl + e / a.
Instead Ctrl+e/a, Home and End keys should work like Cmd+right / left arrow.
I guess this is cause of Mac OS doesn't have a standard keyboard layout globally. Every program does what it pleased.

Thank you for feedback!
I've fixed this issue at the latest beta version (v10.6.27).
How to upgrade to the latest beta version:
https://pqrs.org/osx/karabiner/document.html#check-for-updates

I red in mail but forgot to say thanks.


error

when I import the package and use it as written in the readme file .. it throws this error:
TypeError: NotifmeSdk is not a constructor

How do you import the lib? It should be either import NotifmeSdk from 'notifme-sdk' or const NotifmeSdk = require('notifme-sdk').default


Wrangler errors should be more useful

The workers API returns errors with a numeric code and a one-line message. Since wrangler is being run on the user's computer, we should be able to look at e.g. their wrangler.toml to identify the exact issue with their project and then suggest to them how to fix it.

Let's track this in #377


App requests permission in development but after archived to ipa it doesnt request permission any more

Hi, I'm having the issue that my app requests permission normally in development but after archived to ipa it doesnt request permission any more. Any idea? Thanks.

@namnm @ianlin hi, any solution?

Hi, I got it worked:

Make sure you have configured the plist.info file correctly like the documentation.
Make sure to have the correct app distribution certificate.
Try to call the function getting the apns token as soon as possible, may be best is BEFORE the app rendering, store it somewhere, then get it back when you need.

@namnm @ianlin thanks for the quickly response, I got this worked too.
In my situation, I used OneSignal & the voip registered at OneSignal should add the device to it after get voip token, but the OneSignal api has the test_type parameter which 1 for development & omit for archieve.
thanks for the keyword certificate!


Hi,

Steps to Reproduce

...
...
...

Logs

@Astrallis, it seems that this issue was created prematurely and has no content. I will close this and its duplicate (https://github.com/flutter/flutter/issues/34988) for now, but please feel free to post another issue with details if you actually have a question or need to file a bug


Find a way to reduce verbosity in flavor classes

My main idea here is to have a small .yaml file format that specifies the structure of our witnesses and precomputed polynomials, what functionality and backing they have etc and generates plain the flavor classes. This has tradeoffs:
Pro:

We can flexibly generate the methods that do finnicky things that reference every member.
We can potentially generate non-templated classes and speed up compile time.
Cons:
The generated product will (probably) be more verbose.
Overhead of thinking about this YAML=>CPP generation

OTHER IDEAS TO REDUCE VERBOSITY

Namely composition. Will continue to think on this

We went in the OTHER IDEAS direction


[ns-vue] aspectFill working like aspectFit

Which platform(s) does your issue occur on?

Android emulator Nexus 5X (android 7.0, CPU x86)
iOS not tested

Please, provide the following version numbers that your issue occurs with:

CLI: 4.1.2
Cross-platform modules: "version": "4.1.1"
Runtime(s): can't find them...
Plugin(s):
"dependencies": {
"nativescript-camera": "^4.0.2",
"nativescript-image-cache-it": "^4.0.4",
"nativescript-imagepicker": "^6.0.3",
"nativescript-localize": "^3.0.5",
"nativescript-pager": "^8.0.2",
"nativescript-pulltorefresh": "^2.1.1",
"nativescript-theme-core": "^1.0.4",
"nativescript-videoplayer": "^4.1.0",
"nativescript-videorecorder": "^3.0.0-alpha.11",
"nativescript-vue": "^1.3.1",
"npm": "^6.2.0",
"tns-core-modules": "^4.1.1",
"vue-router": "^3.0.1",
"vuex": "^3.0.1"
},
"devDependencies": {
"babel-core": "^6.26.0",
"babel-loader": "^7.1.4",
"babel-plugin-transform-object-rest-spread": "^6.26.0",
"babel-preset-env": "^1.6.1",
"copy-webpack-plugin": "^4.5.1",
"css-loader": "^0.28.11",
"extract-text-webpack-plugin": "^3.0.2",
"fs-extra": "^5.0.0",
"nativescript-vue-externals": "^0.2.0",
"nativescript-vue-loader": "^0.1.5",
"nativescript-vue-target": "^0.1.0",
"nativescript-vue-template-compiler": "^1.3.1",
"node-sass": "^4.7.2",
"ns-vue-loader": "^0.1.2",
"optimize-css-assets-webpack-plugin": "^3.2.0",
"rimraf": "^2.6.2",
"sass-loader": "^6.0.7",
"vue-template-compiler": "^2.5.16",
"webpack": "^3.11.0",
"webpack-synchronizable-shell-plugin": "0.0.7",
"winston-color": "^1.0.0"
}

Please, tell us how to recreate the issue in as much detail as possible.

Add the template below to any existing Vue project.
Run the template and see the result.

results

Magenta border is shown to fill the whole screen
Image is shown to aspect fit instead of aspect fill

Is there any code involved?
<template>
  <Page class="page">
    <ActionBar class="action-bar" title="Test" flat="true">
      <NavigationButton text="Go Back" android.systemIcon="ic_menu_back" @tap="$router.back()"/>
    </ActionBar>

    <StackLayout>
        <ImageCacheIt resize="300,300" stretch="aspectFill" class="test" imageUri="http://via.placeholder.com/300x300"/>
    </StackLayout>

  </Page>
</template>

<style scoped>
    .test {
        height: 100%;
        width: 100%;
        border-width: 1pt;
        border-color: magenta;
    }
</style>

Have you tried fill ?

Hi! Any suggestions on this issue?

It doesn't display anything

fixed in the latest alpha


symbol(s) not found for architecture armv7s

Goals
Compile my app after upgrading from Realm 3.17.3 to 3.20.0
Expected Results
Successful compilation
Actual Results

Showing All Messages
"realm::util::InterprocessMutex::s_mutex", referenced from:
  realm::util::InterprocessMutex::initialize_statics() in shared_realm.o

  realm::util::InterprocessMutex::free_lock_info() in shared_realm.o

"realm::DescriptorOrdering::append_distinct(realm::ColumnsDescriptor)", referenced from:
  realm::Results::apply_ordering(realm::DescriptorOrdering&&) in results.o

  realm::Results::distinct(realm::ColumnsDescriptor&&) const in results.o

ld: symbol(s) not found for architecture armv7s
/clang:1:1: linker command failed with exit code 1 (use -v to see invocation)

Realm framework version: 3.20.0
Xcode version: Xcode 11.1
iOS/OSX version: 13.1
Dependency manager + version: Cocoapods 1.8.4

We no longer include the armv7s in the prebuilt binary because Apple no longer recommends using it (it's only relevant for the iPhone 5 and turned out to not be very useful for that). You'll need to also remove armv7s from your app's target architectures if you have an older project. Newly created projects automatically don't target it.


pip install errors

Hi again,
Tried running on my Pi4 and got this when installing modules
pi@octopi:~/ipmi/ipmi-mqtt $ sudo pip install yaml paho-mqtt python-daemon
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting yaml
  Could not find a version that satisfies the requirement yaml (from versions: )
No matching distribution found for yaml

How can I get around this?
Also, great stuff making this, I just really want it to work!

followed the dockerfile install instructions
pip install pyyaml paho-mqtt python-daemon
and managed to get to running the script but hit another snag and cant figure out why
  File "./ipmi-mqtt.py", line 23
    logging.info(f"Opening the following file: {config_file}")
                                                            ^
SyntaxError: invalid syntax

pointing to the " as the invalid syntax.

I'll look at it this weekend and get back to you!

Hi again,
Tried running on my Pi4 and got this when installing modules
pi@octopi:~/ipmi/ipmi-mqtt $ sudo pip install yaml paho-mqtt python-daemon
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting yaml
  Could not find a version that satisfies the requirement yaml (from versions: )
No matching distribution found for yaml

How can I get around this?
Also, great stuff making this, I just really want it to work!

It should be pyyaml not yaml, I'll change it in the instructions.

followed the dockerfile install instructions
pip install pyyaml paho-mqtt python-daemon
and managed to get to running the script but hit another snag and cant figure out why
  File "./ipmi-mqtt.py", line 23
    logging.info(f"Opening the following file: {config_file}")
                                                            ^
SyntaxError: invalid syntax

pointing to the " as the invalid syntax.

Was the log file created? Is the /config folder writeable by the program?

No log file created and config file and file all same permissions as the script and everything else that came from the git clone.

Ok, I made a modification in case it had something to do with the backlashes and how they're handled by different OSs.
Can you re clone and try it again?

So, I just installed it in an Rpi3 which I had with octoprint(which is also based on octopi) and tested it with your config file (which wasn't gonna work but wanted to make sure it read it), it created the log file and ran as expected (letting me know that it couldn't find the server d'uh :)). Could you check again if it gives you the same error?

No log file created and config file and file all same permissions as the script and everything else that came from the git clone.

Tazo, did you manage to fix this?

A had a go but never managed to get it working. Sorry. I'm still learning. I mainly wanted it for power control but ended up just writing an script for hass container to ssh into host pi and run the ipmitools power down command.
Since then I have moved server to a new location with cheap power and no longer have control from my rpi. Thanks for the assistance anyway!
Tasman.

From: Carlos Alfredo Diaz @.>
Sent: Tuesday, November 1, 2022 3:33:05 PM
To: arankwende/ipmi-mqtt @.>
Cc: tazomatalax @.>; Author @.>
Subject: Re: [arankwende/ipmi-mqtt] pip install errors (Issue #3)
No log file created and config file and file all same permissions as the script and everything else that came from the git clone.
Tazo, did you manage to fix this?
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Farankwende%2Fipmi-mqtt%2Fissues%2F3%23issuecomment-1297939366&data=05|01||de60c139c2614815ee9708dabbb16883|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638028667908956776|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=s1p8sqPBgdRyIIvqyVi148panqhXPDtENL%2BkgvkglKo%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQKHRAW3HCJMZC7NLFRERKDWGB6ODANCNFSM6AAAAAAQNKVL54&data=05|01||de60c139c2614815ee9708dabbb16883|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638028667908956776|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2F8sX7OXL%2FYcdktu7qeGEZZwCjIJoG%2BkMlMLSccSJd%2FM%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>


Missing dependencies in requirements.txt

Hi Ashutosh,
While running the scripts for generation and evaluation, I came across some missing packages in my virtual environment; which was created using the requirements.txt in this repository.
The missing packages were: pandas, editdistance and py-rouge. Would be great if these could be added to requirements.txt.

Hi @atreyasha
Thanks for letting us know.
Would you like to create a pull request for this?

Opened a PR. I had zss installed on my virtual environment but import editdistance still threw a ModuleNotFoundError.

Hi Atreyasha, Thanks for bringing this issue to our attention. I have added the missing dependency for the editdistance module in the requirements.txt.


chore: bdd-spring-1576834749 to 0.0.1

chore: Promote bdd-spring-1576834749 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Patch for backslash test (issues #167 and #168)

Sorry for the pingpong on the tickets :)

cc @mjijackson :D

I cherry-picked your commit here. Thanks John!

Thanks @mjijackson and @jafl! :)


Trait show 0%

for 0.xx% should show 2 decimal to know how many items it has in the collection

Fix 2 deciaml added.
Traits name come from Metadata json

In the Filtering it is still showing 0%

Fixed Please review @mitchdoan


User AD Groups - Look up SID from username

Fixes #56
I don't have a domain to test this with, but I've tested the SID lookup part separately, so I'm pretty confident it will work.
I know Windows 7 isn't supported any more, but I was able to find a fix for this issue. If you don't want to support Windows 7, I'll submit a separate PR that checks to make sure LastLoggedOnUserSID is present instead.

Hey @ColbyBouma, in testing out this PR I am finding there are some issues with the changes as well as some issues with the script as it already exists.
The main issue that I am seeing with your changes though is it is adding the computer name into the domain user name. for example, domain\user.name becomes domain\userCOMPUTERNAMEname. Bigger than that, I am seeing quite a few scans return with cannot index into a null array outside of the Windows 7 computers. If you can figure out what is happening with the usernames that would be great.

Oops. I had only intended to replace the . in local accounts like .\user, but I forgot usernames can contain periods. I pushed a fix so it will only replace .\ now.

My fix is causing more trouble than it's worth, so I'm going to submit a new PR that makes sure LastLoggedOnUserSID exists.


[Runtime] Fix _swift_validatePrespecializedMetadata when type lookup fails.

When we fail to look up a type by name, we print an error, then try to compare anyway, which crashes. Skip the comparison when that happens.
While we're in there, modify _swift_validatePrespecializedMetadata to be more useful for debugging, by removing the parameters and having it print the results directly.

@swift-ci please test

I forgot to change the prototype in the header, which caused the symbol checks to fail since the renamed function was no longer exported. Nice test coverage on that! Fixed it now.

@swift-ci please test

@swift-ci please test


 MWAHAHAHAHAH"
  end
end

scheduler = Rufus::Scheduler.start_new
scheduler.every("1s", :blocking => true) { raise SnidelyWhiplash, "So eeeeeevil" }

What exactly is going on here?
In lib/rufus/sc/jobs.rb#147 there's a bit of code that rescues exceptions and calls #handle_exception.
        begin

          trigger_block

          job_thread = nil
          to_job.unschedule if to_job

        rescue Exception => e
          @scheduler.handle_exception(self, e)

The default implementation of #handle_exception calls Exception#to_s and Exception#backtrace to print out the details of the error. If either of these methods raise an exception they bubble up all the way to the scheduler and seem to stop subsequent jobs from running (I'm not entirely clear why -- I think they actually go all the way up to the thread and the thread stops, but I'm not sure).
Either #handle_exception should be made (reasonably) safe from exceptions itself, or the scheduler should be resilient to any perfidious exceptions that manage to find their way up to the top. I'm not sure how to accomplish the second and I wasn't sure if the first was an approach that you would agree with, so instead of a patch I decided to submit a bug.

OK, I will harden that. Good catch !

Would that be OK ?
https://github.com/jmettraux/rufus-scheduler/commit/64f88efb2de8b7bcc3412adbfb1a0e377a9083bc
Cheers,
John

Looks good to me. That was (minus the refactoring) more or less what I did. Thanks for the fast response!


Fix resin-filesystem-expand

We will run e2fsck without the -f flag to reduce boot time.

@telphan anything left to do here?


Code reloading in development mode

so shotgun is not enough anymore? :/

Shotgun is too slow for bigger apps. We need to either (a) keep an approach like shotgun but make it so it doesn't reload the app's underlying gems, or (b) some more sophisticated approach that actually handles reloading within dry-web (I recall you shared some ideas about this in chat in the past?)

On 12 Jan 2017, at 10:59 pm, Piotr Solnica<EMAIL_ADDRESS>wrote:
so shotgun is not enough anymore? :/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I'd prefer to at least start with a) and see how far we can go with it. Speeding up booting is a good thing to do regardless. I saw that dry-system slowed down a bit, it used to take to boot Berg in ~1s now it's ~1.3-5. I'll be looking into that.

This sounds good to me. Just wanted to get this issue down here so we can have a reminder and a place to record discussions/experiments :)


doc: Fix cosmetic problem of two helm blocks in guides

The parsed-literal statement causes the '' to be interpreted instead of
printing it as-is on multiple lines. Use a code block to have the example
rendered correctly.

This change is

test-docs-please


Allow for Windows separator split

I'd prefer that we abstracted newline out and used #if characters to define it. And since currently there is no #if for windows we can't do that. And since currently there is no #if for windows it seems a little premature to pull this.
However I will accept a modification that defines the newline character in a #if and #errors if the platform is not one of the current options.

@mxcl Something like
#define NEWLINE "\n"
#if os(WINDOWS)
#error ...
#endif

?

Yes, but there is no os(Windows) yet.

Hopefully that commit should be proper

I’m afraid this doesn’t compile.

The thing is, a compile time error will be thrown with the above commit because NEWLINE wouldn't have been defined on a Windows platform build

Another reason this doesn't compile could be because the variable NEwLINE is defined, but NEWLINE (notice the spelling) is used below. Variable names are case-sensitive.

 :P

Damn, sorry. This was my first real time dealing with Swift.

np, contributions welcome! Preferably try compiling them before submitting though. Thanks!


Add simple debug interface

Background
Debugging Hotham apps is a pain. This feature would give us the ability to debug running apps.
A simple a way to do this would be to have a web app that communicates with the game engine over a websocket. This webapp could display information about the running game, plus add the ability to change or tweak values on the fly.
TODO

[ ] Create webapp
[ ] Add websocket server
[ ] Test

Scope of prototype:

Change the debug params in the scene UBO


Dirty ("modified") file status

Great extension! I think this is a really nice use of neovim. I'd like to adopt this in my workflow, but I'm having a hard time getting over the fact that vscode tells me files have unsaved changes after backing out all changes with 'u' in normal mode. Is there a way around this?

+1 I came into same problem when evaluating the extension to see if I can switch from vscodevim to neovim.
It makes the daily work a bit annoying as you see a lot of "changed" files that actually have no changes.
Even getting into insert mode and exiting using jj marks the file as dirty in my case.

Thanks! That seems to work. I'll use it for a few days and report back if there are any issues that come up.

There is no way to set/reset dirty file status in vscode, except using vscode undo stack which is problematic

@phphong - This works well for me. Thanks again!

@asvetliakov, what if just call workbench.action.files.revert in the last Neovim undo?

@Shatur95 that will lead to the incorrect behaviour because files.revert will revert a file to the last saved content which can be different than the undo stack (e.g. you've changed something (1), saved (2), changed again (3), calling files.revert will revert you back to (2), although in this case you must have the dirty status).
We can revert (or alternatively call save) only when save_last from vim's undotree() is equal to seq_cur, but the problem all buffers from neovim are scratch ones and never saved

@asvetliakov, yes, you are right :(

There is no way to set/reset dirty file status in vscode, except using vscode undo stack which is problematic

Could you please elaborate on what's the problem with vscode's undo?

I think the biggest reason is inconsistency with vim's undo behaviour. It won't undo things in the same chunks as nvim, won't work with plugins, and nvim will consider redoes as edits. Its a compromise both ways unless there is a new vscode dirty file flag api.

Here is a workaround to get rid of the Dirty ("modified") file status inside vscode, after your last undo is "already the oldest change":
Just put this into your init.vim
function! s:undoWrapper()
    let l:before = undotree().seq_cur
    silent! undo
    let l:after = undotree().seq_cur
    if l:before == l:after
        call VSCodeNotify('workbench.action.files.save')
    endif
endfunction

nnoremap u :call <SID>undoWrapper()<CR>

Here I created a function which programmatically triggers a save operation when you reach the last undo state.
The function checks if the undo operation changes the undo sequence number. If the undo sequence number hasn't changed, it means we are already at the oldest change, so we can trigger a file save by vscode, to get rid of the dirty file status.

I think this issue has a solution now. Especially after completing PR #2075, the buffer's &modified is effective. @ollien I think you might be interested in this :)

@xiyaowong isn't the issue that there is no way to clear the modified flag in the vscode api? The dirty flag is set because undoing changes in neovim is just providing buffer updates but vscode doesn't know that it is undoed.


Updated MoveButKeepSource as internal

Category

[x] Content fix

Related issues

fixes #6329

What's in this Pull Request?
Updated MoveButKeepSource as internal, instead of public.

Don't merge this... waiting on feedback from MSFT engineering.

Closing this due to no follow-up...


Improve validator hygiene

Previously, validators were not Clone. This made it safer and easier to keep track of when and where the validator was outstanding. For malicious security protocols with batched verification (rather than verifying once at the conclusion of the entire protocol), we have relaxed this, but we should try to improve it, which will probably involve something like moving the validate_record method from the validator to the context, and various changes to how/where malicious protocol state is accessed and used to support that.

This was addressed in #1250 by moving the validate_record API to the context.


[Issue] Using -e with azd up should create a new env.

Create an env azd env new
Run azd up -e with a different env name than what you used above.
Expected: azd to create a new env
Actual: azd used the first env created

This should be resolved with #1543, latest version 0.6.0-beta.2. Please reopen otherwise.


Adds Alexander Miranda

My final commit seems to generate line breaks for my entry, let me know if it doesn't on your end!
Thanks,
Alex

Included in 79de22704a796012482f2d40f9b995b9f15aa759


Bug 1197375 - Fixed invalid markup (extra template closing tag)

This was introduced by https://github.com/palant/olympia/commit/e91c9732e68e8c2b61e85f69c0f1b1ae357387e5#diff-59ef5f1b2a3d671a4384c5dd14b1dbf5L22, which is my fault, sorry :/ and thanks for fixing!


Middleware: Suspend Server: No timeout in logs

When invoking "Suspend Server" menu operation for EAP7 standalone server and provide timeout parameter in UI input field, it ignores timeout parameter in EAP7 server side.
Here is the log on server.log:
2016-09-02 05:48:29,740 INFO  [org.jboss.as.server] (OkHttp http://cfme-hawkular.bc.jonqe.lab.eng.bos.redhat.com:8080/hawkular/command-gateway/feed/9834a958-109c-42f8-90a7-63c4a45352c5) WFLYSRV0236: Suspending server with no timeout.
Here is MiQ production.log
[----] I, [2016-09-02T06:17:30.697043 #2996:fc3744]  INFO -- : Started POST "/middleware_server/run_operation" for <IP_ADDRESS> at 2016-09-02 06:17:30 -0400 [----] I, [2016-09-02T06:17:30.699387 #2996:fc3744]  INFO -- : Processing by MiddlewareServerController#run_operation as HTML [----] I, [2016-09-02T06:17:30.699520 #2996:fc3744]  INFO -- :   Parameters: {"id"=>"19", "operation"=>"suspend", "timeout"=>12, "middleware_server"=>{"id"=>"19"}} [----] I, [2016-09-02T06:17:31.018664 #3011:fa5424]  INFO -- : Started GET "/api" for <IP_ADDRESS> at 2016-09-02 06:17:31 -0400 [----] I, [2016-09-02T06:17:31.021707 #3011:fa5424]  INFO -- : Processing by ApiController#index as JSON [----] I, [2016-09-02T06:17:31.047690 #3011:fa5424]  INFO -- : Completed 200 OK in 26ms (Views: 0.4ms | ActiveRecord: 0.0ms) [----] I, [2016-09-02T06:17:31.378267 #2996:fc3744]  INFO -- : Completed 200 OK in 679ms (Views: 0.8ms | ActiveRecord: 0.0ms)
evm.log content at tat time period:
Seems like there is some error:
[----] I, [2016-09-02T06:24:34.173685 #2950:737134]  INFO -- : MIQ(MiqScheduleWorker::Runner#do_work) Number of scheduled items to be processed: 5.  [----] I, [2016-09-02T06:24:36.148953 #2920:737134]  INFO -- : MIQ(MiqPriorityWorker::Runner#get_message_via_drb) Message id: [1283], MiqWorker id: [16], Zone: [default], Role: [smartstate], Server: [], Ident: [generic], Target id: [], Instance id: [], Task id: [job_dispatcher], Command: [JobProxyDispatcher.dispatch], Timeout: [600], Priority: [20], State: [dequeue], Deliver On: [], Data: [], Args: [], Dequeued in: [1.929776124] seconds [----] I, [2016-09-02T06:24:36.149141 #2920:737134]  INFO -- : Q-task_id([job_dispatcher]) MIQ(MiqQueue#deliver) Message id: [1283], Delivering...  [----] I, [2016-09-02T06:24:37.915417 #2902:737134]  INFO -- : MIQ(MiqQueue#deliver) Message id: [1282], Delivering... [----] I, [2016-09-02T06:24:37.919350 #2902:737134]  INFO -- : MIQ(MiqQueue#delivered) Message id: [1282], State: [ok], Delivered in [0.003941514] seconds [----] I, [2016-09-02T06:24:37.921582 #2893:737134]  INFO -- : MIQ(MiqQueue#delivered) Message id: [1281], State: [ok], Delivered in [0.006171545] seconds [----] I, [2016-09-02T06:24:40.202425 #2735:737134]  INFO -- : MIQ(MiqServer#heartbeat) Heartbeat [2016-09-02 10:24:40 UTC]... [----] I, [2016-09-02T06:24:40.239138 #2735:737134]  INFO -- : MIQ(MiqServer#heartbeat) Heartbeat [2016-09-02 10:24:40 UTC]...Complete
@abonas

@miq-bot add_label providers/hawkular bug

@miq-bot add_label providers/hawkular, bug

@jshaughn @ammendonca can you tell from the log if the issue is on the agent or ManageIQ side ?

@theute It looks like this is a passthru (i.e. generic) operation so it's a bit strange that the 'timeout' parameter would not get passed/handled because all of the end-to-end handling should be generic.  I'll try taking a closer look, my initial feeling would be UI/MIQ, or perhaps even a bad WF message.

The timeout is definitely being lost ui-side, I verified that it's coming over the wire as 0.    But the request continues.   I suggest a UI guy get assigned to this.

I'm having a look at it, first experiments, the parameters are being passed by the UI:
{id: "24", operation: "suspend", timeout: 10}

But there's an error line in the logs which I am investigating:
[----] E, [2016-09-13T15:56:39.896244 #5834:3fd378881310] ERROR -- : MIQ(ManageIQ::Providers::Hawkular::MiddlewareManager#run_operation) error callback was called, reason: Performed [Suspend] on a [DMR Node] given by Inventory path [/t;hawkular/f;db1a9d36-28aa-4f13-9e33-37151addc984/r;Local~~]
Will investigate further on why this is happening.

@ammendonca , one note, both @hhovsepy and I edited the value.  It looks like you're trying with the default that is initially filled in.  Not sure it makes a difference (also not sure why I changed the default...)

@jshaughn, yeah, thanks. I've tested with default and non-default just to see if it actually changed.. anyway, I've found the issue and will provide a solution shortly.


ClickHouse driver UInt64 wrong value

Description
current ("new") ClickHouser driver still produces wrong values with UInt64 fields
DBeaver Version
22.2.2
Operating System
No response
Database and driver
clickhouse-jdbc-0.3.2.jar
Steps to reproduce
CREATE TABLE default.test_uint64
(
EventDate Date,
TestId UInt64
)
ENGINE = MergeTree()
PARTITION BY toYYYYMM(EventDate)
ORDER BY (EventDate, intHash32(TestId))
SAMPLE BY intHash32(TestId)
SETTINGS index_granularity = 8192;

insert into default.test_uint64 (EventDate, TestId) values
('2022-01-01', 0)
,('2022-01-02', 1)
,('2022-01-03',<PHONE_NUMBER>)
,('2022-01-04',<PHONE_NUMBER>2101484784)
,('2022-01-05',<PHONE_NUMBER>3709551615);

Current ClickHouse driver
toString(TestId)    |toUInt64(TestId)    |TestId              |
--------------------+--------------------+--------------------+
0                   |                   0|                   0|
1                   |                   1|                   1|
4294967295          |<PHONE_NUMBER>|<PHONE_NUMBER>|
16218631392101484784|17357176597978101064|17357176597978101064|
18446744073709551615|18446744073709551615|18446744073709551615|

Legacy ClickHouse driver
toString(TestId)    |toUInt64(TestId)    |TestId              |
--------------------+--------------------+--------------------+
0                   |                   0|                   0|
1                   |                   1|                   1|
4294967295          |<PHONE_NUMBER>|<PHONE_NUMBER>|
16218631392101484784|16218631392101484784|16218631392101484784|
18446744073709551615|18446744073709551615|18446744073709551615|

16218631392101484784 ->17357176597978101064 ???
Additional context
No response

Hello @ajax16384
I can reproduce it with your driver version, but not with the version: ClickHouse JDBC Driver clickhouse-jdbc 0.3.2-patch11 (revision: 27f8951)
So, I suppose, that this is a driver issue. And you can update your driver to fix it.

"Connection X configuration->Connection settings->Edit Driver Settings->Libraries->Download/Update"
Trying to download same 0.3.2 (no patched) version.
May be dbeaver pinned version sould be updated to fresh clickhouse repo reference?
https://github.com/dbeaver/dbeaver/blob/663b7dfbc986b5ff9f97bacb3d802eac869c59be/plugins/org.jkiss.dbeaver.ext.clickhouse/plugin.xml#L59

These issues are also waiting for the driver update:
#16189
#16885
#17287


Fix unit test for 4.14

/cherry-pick release-4.14-compatibility

/cherrypick release-4.14-compatibility

force merging this PR (as it is needed to un-block other 4.14 blocker PRs), this PR just fixes the unit tests and do not impact ODF in any way...


[firebase_database]: OnDisconnect not called when app is killed on Android (iOS works fine)

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Database
Which platforms are affected?
Android
Description
I made an issue 2 years ago to describe a specific behaviour of Firebase RTDB that is actually normal
Today, the behaviour upon internet loss is the same as before unfortunately but the real issue is that the OnDisconnect is never called on Android when the app is force killed by the user as is it the case on iOS
-> The problem with that is that we can wait undefinetely to see our OnDisconnect update, not "only" 10 mins for an internet loss
Reproducing the issue

Run the sample code below
See in your firebase console the test: 1 value
force kill the app
Wait as long as you want but see that test: 1 remains
Do the same on iOS and see the expected behaviour

import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_database/firebase_database.dart';
import 'package:flutter/material.dart';

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp();
  runApp(const TestApp());
}

class TestApp extends StatefulWidget {
  const TestApp({super.key});

  @override
  State<TestApp> createState() => _TestAppState();
}

class _TestAppState extends State<TestApp> {

  void init() {
    final DatabaseReference reference = FirebaseDatabase.instance.ref();
    // if (kReleaseMode) {
    final connectedRef =
    FirebaseDatabase.instance.ref().child(".info/connected");
    connectedRef.onValue.listen((event) {
      final connected = event.snapshot.value as bool? ?? false;
      if (connected) {
        print("Connected.");
        reference
            .onDisconnect()
            .update({"test": ServerValue.increment(-1)});
        reference.update({"test": ServerValue.increment(1)});
      }
    });
  }

  @override
  void initState() {
    init();
    super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return const Placeholder();
  }
}

Firebase Core version
3.5.0
Flutter Version
3.24.3
Relevant Log Output
No response
Flutter dependencies

Expand Flutter dependencies snippet

Dart SDK 3.5.3
Flutter SDK 3.24.3
test_database 1.0.0+1

dependencies:
- firebase_core 3.5.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_database 11.1.3 [firebase_core firebase_core_platform_interface firebase_database_platform_interface firebase_database_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]

dev dependencies:
- flutter_lints 4.0.0 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]

transitive dependencies:
- _flutterfire_internals 1.3.43 [collection firebase_core firebase_core_platform_interface flutter meta]
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- clock 1.1.1
- collection 1.18.0
- fake_async 1.3.1 [clock collection]
- firebase_core_platform_interface 5.3.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.18.1 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- firebase_database_platform_interface 0.2.5+43 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_web 0.2.6+1 [collection firebase_core firebase_core_web firebase_database_platform_interface flutter flutter_web_plugins]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- leak_tracker 10.0.5 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 3.0.5 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 3.0.1 [leak_tracker matcher meta]
- lints 4.0.0
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.11.1 [collection]
- meta 1.15.0
- path 1.9.0
- plugin_platform_interface 2.1.8 [meta]
- sky_engine 0.0.99
- source_span 1.10.0 [collection path term_glyph]
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- string_scanner 1.2.0 [source_span]
- term_glyph 1.2.1
- test_api 0.7.2 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- vector_math 2.1.4
- vm_service 14.2.5
- web 1.1.0

Additional context and comments
No response

Hi @Tom3652 , thanks for submitting this report. I tested with your sample code but was unable to reproduce your experience. It seems to work as expected on my end. What version of firebase_database are you using?

Hi @SelaseKay thanks for your feedback.
I am using the 11.1.3 version of firebase_database.
May i ask you which version of Android are you using ? And which device ?

I tested on Android 14

Alright i have more info on what is happening.
I could reproduce it only on 1 device and not 100% of the time (my Motorola under Android 11), but it works fine on my 8 other Android physical devices.
However, in my real project the OnDisconnect is never called on Android because of another issue :
The video_player package has a bug currently that if you play / pause a video and then call the native OnPause() Android method (App State = inactive), you will see the ExoPlayer crashing natively with a StackTrace but this has no impact on the Flutter app (no real crash for the user).
Since i have this crash in native code, it seems the OnDisconnect trigger is called after that "crash" because If i don't have any videos played / paused in my app or don't have any other native "crash" in the code, the OnDisconnect is triggered normally and i have my -1 counter on Android every devices.
Besides, the OnDisconnect should be something triggered server-side so i don't understand why a native crash on app state inactive would make the OnDisconnect not working : it should not be affected by anything in the local code and especially should be triggered when a crash occur to set the disconnection of the user in my opinion
To sum up, this issue could become : OnDisconnect seems to not be set server side and / or not called when a native error occur before destroying the app (terminated state).
As an external viewer (without seeing the code), it seems the OnDisconnect is called at the very end of the App OnDestroy on the Android side, which may not be called properly if some other package have crashes in their OnPause or OnDestroy as well.
I will try to make a new reproductible sample code with the above information this week 🙏🏼

Alright this is working now i am not able to reproduce the bad behaviour anymore despite the crash of video_player, i have tested also in my real project and it's working fine.
Thanks for your time anyway !