Bugfix/alert rules page size

Fixes a newly added size limit on paging for alert rules that cause failures under the old defaults. After discussing with @timabrmsn, we decided to simply lower the default of settings._items_per_page.

Codecov Report

Merging #123 into master will decrease coverage by 0.47%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   91.26%   90.79%   -0.48%
==========================================
  Files          58       58
  Lines        1980     1911      -69
==========================================
- Hits         1807     1735      -72
- Misses        173      176       +3

Impacted Files
Coverage Δ

src/py42/settings/__init__.py
100.00% <100.00%> (ø)

src/py42/_internal/compat.py
70.00% <0.00%> (-30.00%)
:arrow_down:

src/py42/sdk/__init__.py
82.35% <0.00%> (-4.32%)
:arrow_down:

src/py42/modules/alertrules.py
80.00% <0.00%> (-1.82%)
:arrow_down:

src/py42/sdk/queries/__init__.py
88.23% <0.00%> (-1.24%)
:arrow_down:

src/py42/_internal/clients/alertrules.py
80.85% <0.00%> (-1.15%)
:arrow_down:

src/py42/response.py
93.87% <0.00%> (-0.67%)
:arrow_down:

src/py42/_internal/clients/storage/__init__.py
91.66% <0.00%> (-0.65%)
:arrow_down:

src/py42/_internal/auth_handling.py
94.44% <0.00%> (-0.30%)
:arrow_down:

src/py42/modules/securitydata.py
93.06% <0.00%> (-0.27%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735ac94...0a22260. Read the comment docs.


force a fullStatus update

Is there any known implementation to force a fullStatus message?

you can send this message:
{"type":"requestFullStatus"}

Thanks ... having problems on the actual evcc implementation of the wattpilot implementations that if the car stops the charging process, some updates seem not to be send ( or are not processed correctly ).
alw just tells if the car is allowed to charge, but is there any other flag known if the car is actual still charging ( except making a code descission if any power is on the cable ) ?

@peterpoetzi
Is there a way to send this message through the mqtt topics, like using .../messages/send/... or something?
Somehow the last "fullStatus" I received is months old, maybe Fronius changed the system here, or for whatever
reason it is not send automatically anymore.


Bitround Codec

Eventually closes #298
TODO:

[x] Unit tests and/or doctests in docstrings
[x] tox -e py39 passes locally
[x] Docstrings and API docs for any new/modified user-facing classes and functions
[x] Changes documented in docs/release.rst
[x] tox -e docs passes locally
[x] GitHub Actions CI passes
[x] Test coverage to 100% (Coveralls passes)

Hello @rabernat! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file numcodecs/bitround.py:

Line 17:25: E225 missing whitespace around operator

I want to apologize for letting this PR stall. I wanted to get it started as a proof of concept. If anyone else is excited about this feature and wants to work on it, I absolutely invite you to take over my PR and continue pushing it forward. cc @aaronspring

It looks pretty complete - what more needs doing?

I can add https://github.com/observingClouds/bitinformation_pipeline/blob/749623784286a04a54b6107fc8dd99d23d44f1b0/tests/test_bitround.py#L61 to testing, where I test this PR against Milan's bitinformation.round implementation in Julia.

I can add

Does that require adding julia into the tests?
It would be nice to test for float64 as well as float32. Maybe float16 too, although I can't really imagine that being relevant.

Sorry I meant I can add this to the discussion. Yes these tests run Julia code and shouldn’t be included here.

Yes these tests run Julia code and shouldn’t be included here.

For a small test data array, we can inline the expected values.

When I compare this PRs round against bitinformation.jl.round in https://github.com/observingClouds/bitinformation_pipeline/blob/2f02df358521d28604b5be69ce9fb0388169e797/tests/test_bitround.py#L64, I get equals results only for float32 but not for float16 or float64, see https://github.com/observingClouds/bitinformation_pipeline/runs/5953867041?check_suite_focus=true

@jakirkham , I agree and adopted your changes.

Do we need to drop py36? Something's up with the environment.
cf #308 (for adding 3.10)

@jakirkham , any thoughts?

I think we can now rerun CI after merging from main

Fixed the release conflicts.

@rabernat, should I be able to just specify this in the encoding argument dict in ds.to_zarr()?
It is a filter, right?

See example in https://github.com/observingClouds/xbitinfo/issues/75

@aaronspring , awesome!   That's exactly what I was looking for!

Will merge at the end of my day if there are no more comments.

Thanks Martin & Ryan and everyone who helped review! 🙏

There’s a hardcoded 23 (representing the number of mantissa bits) in line 67, that should be 10,23,52 for float16/32/64. So that line should be ‘maskbits = bits - self.keepbits’ I guess

On 9 Apr 2022, at 14:05, Aaron Spring @.***> wrote:

When I compare this PRs round against bitinformation.jl.round in https://github.com/observingClouds/bitinformation_pipeline/blob/2f02df358521d28604b5be69ce9fb0388169e797/tests/test_bitround.py#L64, I get equals results only for float32 but not for float16 or float64, see https://github.com/observingClouds/bitinformation_pipeline/runs/5953867041?check_suite_focus=true
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

Sorry, I don't know why this post was sent now. I may have sent an email at the beginning of the year to contribute when the PR was still open, maybe this email got lost and only delivered now? Weird. The PR clearly contains the maskbits = bits - self.keepbits lines instead of a hardcoded 23, so consider my previous comment as irrelevant.

OK then! I'll blame the gremlins :)


auro-flight: Airport code definitions

Is your feature request related to a problem? Please describe.
In the current legacy flight results (matrix) experience, when you hover over any airport code, it defines that airport code for the guest. This was identified as a feature lacking from the microsite/auro-flight experience, as some guests in user studies hovered over the airport codes, layover airports and 'all airports' experience more frequently, to figure out where it was if they were unfamiliar with the airport.

Describe the solution you'd like
Legacy uses the built in browser's tooltip, but would assume we may want to use our auro-popover or some variant. Open to whatever design works best given the latest workshop and push for consistency across all usage of flight details :)
The current MOW experience has no solution to this and does not define the city pairs in the Details either. Hover will not help on the new mobile/tablet experiences, but the new mobile responsive experience leverages the latest Details modal, which defines each airport code there.
Describe alternatives you've considered
No response
Additional context
Discussed with @leeejune post- Flight Details Workshop work.

2 notes from discussing with the team:

We'll need to make sure that supporting this change doesn't have impacts on accessibility
We will need to make sure that the place we pull data from is a public API that is up to date and maintained.  Additionally, for this API we'll need to make sure we're properly aligned on the names for the airports/cities (ie. SEA being "Seattle" or "Seattle/Tacoma International Airport")


Passwordless Example

Here's a repo I put together to show how to accomplish a passwordless auth flow via feathers-authentication-management.  If you think it serves as a good example, please consider adding a link in the README of this repo so that people can find it.  Thanks.
https://github.com/rhythnic/feathers-passwordless-auth-example

Added to ecosystem page.


🐞 Bug: Carry incorrect when using addition in 32-bit ALU

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
When using a 32-bit ALU component, the carry output is incorrect. For other bit widths, the output seems to be correct.
Looking at simulator/src/modules/ALU.js, I suspect this is due to the way shifts work in Javascript. When you shift a number 32 bits to the right, as is done there, the outcome is always zero - even if the value did not fit in 32 bits.
Steps To Reproduce
Test case 1: adding 10...0 and 10...0

Visit https://circuitverse.org/simulator/embed/faulty-carry-test-case-1.
Verify that the carry output is 0.

Test case 2: adding 0...010 and 0...010

Visit https://circuitverse.org/simulator/embed/faulty-carry-test-case-2.
Verify that the carry output is 1.

Expected Behavior
Test case 1: adding 10...0 and 10...0
The expected carry output is 1.
Test case 2: adding 0...010 and 0...010
The expected carry output is 0.
Screenshots
Test case 1: adding 10...0 and 10...0

Test case 2: adding 0...010 and 0...010

Device Information [optional]
- OS: Linux 6.9.3
- Browser: Firefox <IP_ADDRESS>

Additional context
No response
Are you working on this issue?
No

can i work on this issue?

@tanmoysrt, could you assign this issue to Sanskar?

@tanmoysrt, could you assign this issue to Sanskar?

sure


Example rill-sec-formd error

Describe the bug
Looks like the rill-sec-formd example has an issue.
To Reproduce
Steps to reproduce the behavior:

Go to https://github.com/rilldata/rill-examples/tree/main/rill-sec-formd
Type rill start
See error

Expected behavior
Example should work, but alas I get this error:
2024-04-14T21:06:28.811	WARN	Reconcile failed	{"name": "offerings_issuers", "kind": "MetricsView", "elapsed": "24ms", "error": "failed to validate dimension \"ISMINERALcolumnTYPE\": column \"ISMINERALcolumnTYPE\" not found in table\nfailed to validate expression for dimension \"ISMINERALcolumnTYPE\": Binder Error: Referenced column \"ISMINERALcolumnTYPE\" not found in FROM clause!\nCandidate bindings: \"offerings_issuers_model.ISMINERALPROPERTYTYPE\""}

Screenshots

Desktop (please complete the following information):
rill version 0.42.3 (build commit: cd0501fe9 date: 2024-04-01T13:39:29Z)

Thanks for letting us know! Fixed via https://github.com/rilldata/rill-examples/commit/8c90f4ff5c55a8ef1e58b90cbd1384932c097a67


0.3.5 -> 0.3.2

Rollback for tangelo build. See here

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[Bug] ImageFromFile in image.py

    def get_data(self):
        if self.shuffle:
            self.rng.shuffle(self.files)

ImageFromFile has no attribute rng. Should call self.reset_state() first.

You are responsible to call it, as mentioned in the dataflow tutorial.

Thank you for your reply. Seems the issue has been fixed in recently.


Wiki

Hope you don't mind. I created a wiki with a page that list the variables I could find and some basic information on them.
I listed everything using headers (#'s) that way it can be copied and used on a configuration file for Pelican and titles there will be comments.

Good job. Appreciated.

Hi!
First of all, thanks for your interest in this theme! It's with heavy heart that I have decided that I can no longer maintain this theme due to lack of time and changing interests. To makes sure the theme lives on however and not goes to waste, I've donated it to the Pelican community. It can now be found in the official pelican-themes repository. I'd suggest you re-submit your issue  there.
Sorry for the inconvenience!


[macOS] Dash 18.0.1 signed using 'Apple Distribution' certificate which is not meant for distribution to end-users

previous releases were properly signed using the right ("Developer ID") certificates (first using 'Dash Core Group, Inc.' certificates and then using  'The Dash Foundation').
however the newest release 18.0.1 is improperly signed using a 'Apple Distribution' certificate instead of the right 'Developer ID' certificate.
'Apple Distribution' certificates are only meant for uploading to Apple for software that is going to be distributed to the Mac App Store - its not meant for distributing software to end-users and may present an issue for users that are trying to launch the software.

download https://github.com/dashpay/dash/releases/download/v18.0.2/dashcore-18.0.2-osx.dmg is again signed with a Apple Development signature:
EXPECTED:  The Dash Foundation, Inc. (44RJ69WHFF)  FOUND:  Apple Development<EMAIL_ADDRESS>(9LJX49W7UG)

18.0.2 is broken too

How so?

"Apple Development" certificates are not meant for distributing software to end users. they are only meant to upload software to the Mac App Store. your users will not be able to launch DashDash without disabling GateKeeper.

Sooo.. It's not supposed to be a "Apple Distribution" or a "Apple Development" but "Developer ID"?

Do you know how these "Develop ID" certificates are generated? Inside of Xcode, all that I see are these three options..

A different developer previously handled the macOS signing, but he left the project. So we are trying to figure it out properly now 🙈

if you don't have them you should be able to obtain them from Xcode => Settings/Preferences => Accounts => Manage Certificates…
if they are not there and cannot be added....maybe the devforums ( https://developer.apple.com/forums/ ) can help:

i believe proper signing requires a paid apple developer membership, so that may be a reason why they don't show up

We have a paid membership.

Okay, we've got the certificate figured out. I'm building 18.1.0-rc.1 signed Mac binaries right now to see if it works. I'll post a link to them here once done and we can make sure we've got it figured out :D

@core-code can you look at https://github.com/dashpay/dash/releases/download/v18.1.0-rc.1/dashcore-18.1.0-rc.1-osx.dmg (my gpg sig here: https://github.com/dashpay/dash/releases/download/v18.1.0-rc.1/dashcore-18.1.0-rc.1-osx.dmg.asc)

looks great and confirmed valid - thanks!
codesign -dvv /Volumes/Dash-Core/Dash-Qt.app
Executable=/Volumes/Dash-Core/Dash-Qt.app/Contents/MacOS/Dash-Qt
Identifier=org.dash.Dash-Qt
Format=app bundle with Mach-O thin (x86_64)
CodeDirectory v=20500 size=256764 flags=0x0(none) hashes=8017+3 location=embedded
Signature size=8984
Authority=Developer ID Application: The Dash Foundation, Inc. (44RJ69WHFF)
Authority=Developer ID Certification Authority
Authority=Apple Root CA
Timestamp=10 Oct 2022 at 22:51:54
Info.plist entries=17
TeamIdentifier=44RJ69WHFF
Sealed Resources version=2 rules=13 files=32
Internal requirements count=1 size=112

I'm gonna close this now, I don't want to replace previously published binaries (don't want two "proper" binaries for one tag). But this should be fixed in the next release (18.1.0 which should come out next week)

thanks!


[BUG-python/deployment] Wrong question/field types in dataset card

Describe the bug
When pushing a dataset to the Huggingface hub, field and question types are not displayed correctly in the dataset card:

Expected behavior
I should be able to see the proper name of question and field types throughout the whole dataset card: TextQuestion, TextField, etc.
Please check that this doesn't happen with Metadata types as well and/or in other places throughout the dataset card.

Environment:

Argilla Version [e.g. 1.0.0]: 1.18.0
ElasticSearch Version [e.g. 7.10.2]:
Docker Image (optional) [e.g. argilla:v1.0.0]:

Additional context
Add any other context about the problem here.

The issue has been somehow solved, although what we can see now is the names of the questions in the API, so for example multi_label_selection instead of MultiLabelQuestion, which is what users might be most familiar with from using the SDK.
I'm closing the issue anyway, as it will be irrelevant once the new SDK is merged.


Create website for the package like the pandas or numpy websites (probably using Sphinx)

Create a website for the package!
Unless there is a strong preference for another tool, I strongly recommend that we use Sphinx. Here is the documentation: https://sphinx-rtd-theme.readthedocs.io/en/stable/
Websites like the documentation for DoubleML, Pandas, or NumPy are typically built using documentation generation with Sphinx. It is super useful These tools are designed to generate clean, easy-to-navigate documentation directly from code and/or Markdown files.
Take a look at pandas-dev github. The website part is inside the doc folder. I believe we should do the same. I have create the doc folder.
https://github.com/pandas-dev/pandas/tree/main/doc
Take a look at the following websites:
https://pandas.pydata.org/docs/
https://docs.doubleml.org/

Created first version of webite. Available in release 0.2.0


Resolves #776: onlyUpgradable change the filter to versions where the current version is not the latest one

Root cause of the issue: VersionsHelper.lookupDependenciesUpdates actually returns all dependency versions, and not just updates.
It appears that a lot of places already depend on the current behaviour, so -- for the time being I'm only changing the reports -- where we're simply filtering the results so that only versions containing an update are presented to the renderer.

@slawekjaranowski Please review and merge.

Converting to draft -- I'll try to do it properly.


Data download freezes

Our cluster freezes on data download from 383917/5/9, probably because workers cannot be freed.
The cluster has 2 cpus, the number of workers are 4.

Probably it has little to do with the number of workers. I run get_items_with_pool with 2 workers and got the same results. Need to double check though.
The issue was fixed after I restarted my pod, so perhaps something, like one of notebooks, held the process.

Process ForkPoolWorker-1:
Process ForkPoolWorker-6:
Process ForkPoolWorker-5:
Process ForkPoolWorker-7:
Traceback (most recent call last):
Traceback (most recent call last):
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
Traceback (most recent call last):
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
  File "/opt/conda/lib/python3.7/multiprocessing/pool.py", line 110, in worker
    task = get()
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/conda/lib/python3.7/multiprocessing/queues.py", line 351, in get
    with self._rlock:
  File "/opt/conda/lib/python3.7/multiprocessing/pool.py", line 110, in worker
    task = get()
  File "/opt/conda/lib/python3.7/multiprocessing/synchronize.py", line 95, in __enter__
    return self._semlock.__enter__()
  File "/opt/conda/lib/python3.7/multiprocessing/queues.py", line 352, in get
    res = self._reader.recv_bytes()
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/conda/lib/python3.7/multiprocessing/connection.py", line 216, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 297, in _bootstrap
    self.run()
KeyboardInterrupt
  File "/opt/conda/lib/python3.7/multiprocessing/pool.py", line 110, in worker
    task = get()
  File "/opt/conda/lib/python3.7/multiprocessing/process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/conda/lib/python3.7/multiprocessing/queues.py", line 351, in get
    with self._rlock:
  File "/opt/conda/lib/python3.7/multiprocessing/connection.py", line 407, in _recv_bytes
    buf = self._recv(4)
  File "/opt/conda/lib/python3.7/multiprocessing/synchronize.py", line 95, in __enter__
    return self._semlock.__enter__()
  File "/opt/conda/lib/python3.7/multiprocessing/pool.py", line 110, in worker
    task = get()
  File "/opt/conda/lib/python3.7/multiprocessing/connection.py", line 379, in _recv
    chunk = read(handle, remaining)
KeyboardInterrupt
  File "/opt/conda/lib/python3.7/multiprocessing/queues.py", line 351, in get
    with self._rlock:
KeyboardInterrupt

---------------------------------------------------------------------------
KeyboardInterrupt                         Traceback (most recent call last)
<ipython-input-2-e6acd445fb35> in <module>
----> 1 df = Arche("2235/1396/76", count=1_000_000).source_items.df

/opt/conda/lib/python3.7/site-packages/arche/arche.py in source_items(self)
     73         if not self._source_items:
     74             self._source_items = self.get_items(
---> 75                 self.source, self.start, self.count, self.filters, self.expand
     76             )
     77         return self._source_items

/opt/conda/lib/python3.7/site-packages/arche/arche.py in get_items(source, start, count, filters, expand)
    112         elif helpers.is_job_key(source):
    113             return JobItems(
--> 114                 key=source, start=start, count=count, filters=filters, expand=expand
    115             )
    116         elif helpers.is_collection_key(source):

/opt/conda/lib/python3.7/site-packages/arche/readers/items.py in __init__(self, key, start, count, filters, expand)
    112         self.start_index: int = start
    113         self._job: Job = None
--> 114         super().__init__(key, count, filters, expand)
    115
    116     @property

/opt/conda/lib/python3.7/site-packages/arche/readers/items.py in __init__(self, key, count, filters, expand)
     76         self.filters = filters
     77         self.expand = expand
---> 78         raw = self.fetch_data()
     79         df = pd.DataFrame(list(raw))
     80         df["_key"] = self.format_keys(df["_key"])

/opt/conda/lib/python3.7/site-packages/arche/readers/items.py in fetch_data(self)
    139             return api.get_items(self.key, self.count, self.start_index, self.filters)
    140         else:
--> 141             return api.get_items_with_pool(self.key, self.count, self.start_index)
    142
    143     def format_keys(self, keys: pd.Series) -> pd.Series:

/opt/conda/lib/python3.7/site-packages/arche/tools/api.py in get_items_with_pool(source_key, count, start_index, workers)
    146         results = p.starmap(
    147             partial(get_items, source_key, batch_size, p_bar=tqdm),
--> 148             zip([i for i in range(start_index, start_index + count, batch_size)]),
    149         )
    150         return np.concatenate(results)

/opt/conda/lib/python3.7/multiprocessing/pool.py in starmap(self, func, iterable, chunksize)
    274         `func` and (a, b) becomes func(a, b).
    275         '''
--> 276         return self._map_async(func, iterable, starmapstar, chunksize).get()
    277
    278     def starmap_async(self, func, iterable, chunksize=None, callback=None,

/opt/conda/lib/python3.7/multiprocessing/pool.py in get(self, timeout)
    649
    650     def get(self, timeout=None):
--> 651         self.wait(timeout)
    652         if not self.ready():
    653             raise TimeoutError

/opt/conda/lib/python3.7/multiprocessing/pool.py in wait(self, timeout)
    646
    647     def wait(self, timeout=None):
--> 648         self._event.wait(timeout)
    649
    650     def get(self, timeout=None):

/opt/conda/lib/python3.7/threading.py in wait(self, timeout)
    550             signaled = self._flag
    551             if not signaled:
--> 552                 signaled = self._cond.wait(timeout)
    553             return signaled
    554

/opt/conda/lib/python3.7/threading.py in wait(self, timeout)
    294         try:    # restore state no matter what (e.g., KeyboardInterrupt)
    295             if timeout is None:
--> 296                 waiter.acquire()
    297                 gotit = True
    298             else:

KeyboardInterrupt:

It's rarely reproducible, if reproducible at all. I doubt it needs any fixing.


Add missing search icon on Support screen.

Related Issue or Background Info

When testing proposed dependabot changes, it was observed that the glyph usually present for a search button was absent, which could lead to usability or accessibility issues.

Changes Proposed

Modify HTML to use search button present in secure app, for style uniformity.

Additional Information

Please feel free to modify if there is a more stylistically-compliant way of doing this. 😄

Screenshots / Demos
Before fix:

After fix:

Checklist for Author and Reviewer
Design

[ ] Any UI/UX changes have a designer as a reviewer, and changes have been approved
[ ] Any large-scale changes have been deployed to test, dev, or pentest and smoke-tested by both the engineering and design teams

Content

[ ] Any content changes (including new error messages) have been approved by content team

Support

[ ] Any changes that might generate new support requests have been flagged to the support team

Testing

[ ] Includes a summary of what a code reviewer should verify

This item was successfully smoke tested on pentest!


Version 3

[ ] Drop support for older versions of Node.js. (<18?)
[ ] Drop support for older versions of ESLint. (<8?)
[ ] Support for flat shareable configs. (Do we want to release it before the new version?)
[ ] And more?

I think eslint<8 will work fot a long time.


Added attachments logic

Support for attachments via IMessageChannel #6196

Can someone else verify the feature works as expected?

@sebastienros
We have some custom modules using it, but it is self-referential.
What I could do is changing EmailAdminController.TestSettings in order to attach "/Orchard.Web/Media/OrchardLogo.png" as attachement to the test email.
It could be sufficient?

Will force-accept  if noone has tried it until 11/10

can be merged then?

Now, should be ready for merge in 1.10.x

I just saw this issue. Thanks for implementing this @HermesSbicego-Laser!
I've tested your changes locally and they've worked very well.

Thank you @Xceno ! Yes, it's a small enhancement but useful...


Requirements

Cool project guys. Win10, Python3.exe is sufficient with:
pip install metame keystone
Otherwise errors abound

Hey,
Thank you for the issue.  I went ahead and created a setup.py file, that will take care of that and colorama, and I updated the readme as well. I use keystone to generate the bytes for the Assembly code, but I don't display it currently. I did before, but I didn't want people to think it was "complete." I may reenable it as an optional setting later.
The main way to do keystone-engine is pip install keystone-engine. I am guessing that metame is an alternative way. I have also put that on the readme.
I apologize for not having the incomplete information. I was rushing to get that uploaded, and I had not had a chance to write it. Please let me know if you run into any other issues.

Closing issue. Feel free to start a new issue if something comes up.


Lithuanian translation added

thanks @zygimantus can you also add these missing strings:
@mueller-ma can you please add these strings too:
Search DDG or type URL
Search DuckDuckGo or type URL
also, there's a few empty strings, can you translate or remove them?
thanks!

@fgei I cannot find those strings, what are their keys?

sorry @zygimantus I forgot to add that!
the keys are: name="SearchStringSmall" and name="SearchStringBig", you can find them in the string.xml file in values

Thank you for submitting this. Sadly we can't accept contributions at the moment. We have a new project in the early stages of development at https://github.com/duckduckgo/android and will be accepting contributions there in the future. Thanks again!


Add followers incrementally, allowing people to remove themselves from an SGTM task

Currently, any time an SGTM tasks gets updated, we look for all participants on the PR (every comment/review etc) to add followers. This means that someone who comments on a PR can never remove themself from the SGTM task since any new updates would re-add them.
This PR introduces a more incremental / selective approach to adding followers. It only adds comment followers for a comment when a comment is created/updated  for example, rather than looking at every comment every time. This should also help with the efficiency of the function a bit.
Pull Request synchronized with Asana task

test without mentioning Luis

Testing @luis-e-alvarez

Test again


I receive the following issue during the build. Have anyone an idea what the reason is:

Describe the bug
$ bazel build src/main/java/com/google/j2cl/samples/helloworld:helloworld
Starting local Bazel server and connecting to it...
Loading:
Loading: 0 packages loaded
Loading: 0 packages loaded
currently loading: src/main/java/com/google/j2cl/samples/helloworld
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (1 packages loaded)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (1 packages loaded, 0 targets configured)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (9 packages loaded, 20 targets configured)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (36 packages loaded, 23 targets configured)
WARNING: C:/users/fujitsu/_bazel_fujitsu/7zwbdliw/external/bazel_tools/tools/jdk/BUILD:125:6: in alias rule @bazel_tools//tools/jdk:jar: target '@bazel_tools//tools/jdk:jar' depends on deprecated target '@local_jdk//:jar': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see https://github.com/bazelbuild/bazel/issues/5594)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (61 packages loaded, 496 targets configured)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (77 packages loaded, 1112 targets configured)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (114 packages loaded, 1632 targets configured)
Analyzing: target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (146 packages loaded, 2679 targets configured)
WARNING: C:/users/fujitsu/_bazel_fujitsu/7zwbdliw/external/com_google_jsinterop_annotations-j2cl/java/jsinterop/annotations/BUILD:18:12: in j2cl_java_import rule @com_google_jsinterop_annotations-j2cl//java/jsinterop/annotations:annotations-j2cl: target '@com_google_jsinterop_annotations-j2cl//java/jsinterop/annotations:annotations-j2cl' depends on deprecated target '@local_jdk//:jar': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see https://github.com/bazelbuild/bazel/issues/5594)
WARNING: C:/users/fujitsu/_bazel_fujitsu/7zwbdliw/external/com_google_j2cl/jre/java/BUILD:53:12: in j2cl_java_import rule @com_google_j2cl//jre/java:javaemul_internal_annotations-j2cl: target '@com_google_j2cl//jre/java:javaemul_internal_annotations-j2cl' depends on deprecated target '@local_jdk//:jar': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see https://github.com/bazelbuild/bazel/issues/5594)
WARNING: C:/users/fujitsu/_bazel_fujitsu/7zwbdliw/external/com_google_j2cl/jre/java/BUILD:167:13: in j2cl_library rule @com_google_j2cl//jre/java:jre: target '@com_google_j2cl//jre/java:jre' depends on deprecated target '@local_jdk//:jar': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see https://github.com/bazelbuild/bazel/issues/5594)
WARNING: C:/entwicklung/projekte/zuericher/j2cl/samples/helloworld/src/main/java/com/google/j2cl/samples/helloworldlib/BUILD:14:13: in j2cl_library rule //src/main/java/com/google/j2cl/samples/helloworldlib:helloworldlib: target '//src/main/java/com/google/j2cl/samples/helloworldlib:helloworldlib' depends on deprecated target '@local_jdk//:jar': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see https://github.com/bazelbuild/bazel/issues/5594)
INFO: Analyzed target //src/main/java/com/google/j2cl/samples/helloworld:helloworld (201 packages loaded, 2931 targets configured).
INFO: Found 1 target...
[0 / 21] [Prepa] BazelWorkspaceStatusAction stable-status.txt
[4 / 36] [Prepa] Extracting interface @com_google_code_findbugs_jsr305//:com_google_code_findbugs_jsr305 ... (2 actions, 1 running)
[16 / 105] [Scann] Compiling src/google/protobuf/api.pb.cc
[18 / 105] Compiling src/google/protobuf/api.pb.cc; 2s local ... (4 actions, 3 running)
[20 / 105] Compiling src/google/protobuf/wire_format.cc; 3s local ... (4 actions running)
[24 / 105] Compiling src/google/protobuf/util/internal/protostream_objectsource.cc; 2s local ... (4 actions running)
[27 / 105] Compiling src/google/protobuf/util/internal/protostream_objectwriter.cc; 4s local ... (4 actions running)
[33 / 105] Compiling src/google/protobuf/util/internal/object_writer.cc; 2s local ... (4 actions running)
[39 / 105] Compiling src/google/protobuf/util/internal/datapiece.cc; 2s local ... (4 actions running)
[45 / 105] Compiling src/google/protobuf/text_format.cc; 4s local ... (4 actions running)
[53 / 105] Compiling src/google/protobuf/io/printer.cc; 2s local ... (4 actions running)
[59 / 105] Compiling src/google/protobuf/compiler/parser.cc; 5s local ... (4 actions running)
[67 / 187] Compiling src/google/protobuf/descriptor.cc; 5s local ... (4 actions running)
[73 / 187] Compiling src/google/protobuf/compiler/cpp/cpp_message.cc; 7s local ... (4 actions running)
[77 / 187] Compiling src/google/protobuf/compiler/command_line_interface.cc; 11s local ... (4 actions running)
[89 / 187] Compiling src/google/protobuf/compiler/cpp/cpp_helpers.cc; 5s local ... (4 actions running)
[107 / 187] Compiling src/google/protobuf/compiler/java/java_message_builder.cc; 1s local ... (4 actions running)
[124 / 187] Compiling src/google/protobuf/compiler/csharp/csharp_wrapper_field.cc; 2s local ... (4 actions running)
[140 / 187] Compiling src/google/protobuf/compiler/php/php_generator.cc; 3s local ... (4 actions running)
[167 / 217] Compiling src/google/protobuf/arenastring.cc; 1s local ... (4 actions running)
[227 / 336] Compiling src/google/protobuf/compiler/python/python_generator.cc [for host]; 3s local ... (4 actions running)
[253 / 336] Compiling src/google/protobuf/compiler/java/java_generator.cc [for host]; 3s local ... (4 actions running)
[288 / 336] Compiling src/google/protobuf/compiler/cpp/cpp_message.cc [for host]; 4s local ... (4 actions running)
[342 / 419] Compiling src/google/protobuf/compiler/parser.cc [for host]; 5s local ... (4 actions running)
[399 / 454] Linking external/com_google_protobuf/protoc.exe [for host]; 1s local ... (2 actions running)
[442 / 499] Building external/com_google_protobuf/java/core/libcore.jar (37 source files, 1 source jar); 36s multiplex-worker ... (4 actions running)
INFO: From Executing genrule @io_bazel_rules_kotlin//src/main/kotlin/io/bazel/kotlin/builder:builder_kt_jar [for host]:
external\io_bazel_rules_kotlin\src\main\kotlin\io\bazel\kotlin\builder\tasks\BazelWorker.kt:121:9: warning: unreachable code
throw RuntimeException("drop through")
^
external\io_bazel_rules_kotlin\src\main\kotlin\io\bazel\kotlin\builder\tasks\KotlinBuilder.kt:142:64: warning: 'toUpperCase(): String' is deprecated. Use uppercase() instead.
platform = checkNotNull(Platform.valueOf(it[1].toUpperCase())) {
^
external\io_bazel_rules_kotlin\src\main\kotlin\io\bazel\kotlin\builder\tasks\KotlinBuilder.kt:145:64: warning: 'toUpperCase(): String' is deprecated. Use uppercase() instead.
ruleKind = checkNotNull(RuleKind.valueOf(it[2].toUpperCase())) {
^
external\io_bazel_rules_kotlin\src\main\kotlin\io\bazel\kotlin\builder\utils\BazelUtils.kt:26:59: warning: 'toLowerCase(): String' is deprecated. Use lowercase() instead.
private val isWindows = System.getProperty("os.name").toLowerCase().indexOf("win") >= 0
^
external\io_bazel_rules_kotlin\src\main\kotlin\io\bazel\kotlin\builder\utils\TaskUtils.kt:24:75: warning: 'toLowerCase(): String' is deprecated. Use lowercase() instead.
val CompilationTaskInfo.bazelRuleKind: String get() = "kt_${platform.name.toLowerCase()}${ruleKind.name.toLowerCase()}"
^
external\io_bazel_rules_kotlin\src\main\kotlin\io\bazel\kotlin\builder\utils\TaskUtils.kt:24:106: warning: 'toLowerCase(): String' is deprecated. Use lowercase() instead.
val CompilationTaskInfo.bazelRuleKind: String get() = "kt${platform.name.toLowerCase()}_${ruleKind.name.toLowerCase()}"
^
INFO: From Building external/com_google_j2cl/transpiler/java/com/google/j2cl/transpiler/ast/libast.jar (112 source files) and running annotation processors (AutoAnnotationProcessor, AutoOneOfProcessor, AutoValueProcessor, J2clAstProcessor):
warning: File for type 'com.google.j2cl.transpiler.ast.AbstractVisitor' created in the last round will not be subject to annotation processing.
warning: File for type 'com.google.j2cl.transpiler.ast.AbstractRewriter' created in the last round will not be subject to annotation processing.
warning: File for type 'com.google.j2cl.transpiler.ast.ProcessorPrivate' created in the last round will not be subject to annotation processing.
[473 / 503] Building external/com_google_j2cl/transpiler/java/com/google/j2cl/transpiler/passes/libpasses.jar (153 source files) and running annotation processors (AutoAnnotationProcessor, AutoOneOfProcessor, AutoValueProcessor, J2clAstProcessor); 10s multiplex-worker
ERROR: C:/users/fujitsu/_bazel_fujitsu/7zwbdliw/external/com_google_j2cl/jre/java/BUILD:167:13: Transpiling to JavaScript @com_google_j2cl//jre/java:jre failed: (Exit 1): BazelJ2clBuilder.exe failed: error executing command bazel-out\x64_windows-opt-exec-2B5CBBC6\bin\external\com_google_j2cl\transpiler\java\com\google\j2cl\transpiler\BazelJ2clBuilder.exe ... (remaining 1 argument skipped)
Error: Unused native file 'java/lang/Class.native.js'.
Error: Unused native file 'java/lang/IntegralToString.native.js'.
Error: Unused native file 'javaemul/internal/Casts.native.js'.
Error: Unused native file 'javaemul/internal/ConsoleLogger.native.js'.
Error: Unused native file 'javaemul/internal/HashCodes.native.js'.
Error: Unused native file 'javaemul/internal/JsUtils.native.js'.
Error: Unused native file 'javaemul/internal/Objects.native.js'.
Error: Unused native file 'javaemul/internal/ThrowableUtils.native.js'.
Error: Unused native file 'javaemul/internal/ValueType.native.js'.
9 error(s), 0 warning(s).
Target //src/main/java/com/google/j2cl/samples/helloworld:helloworld failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 487.683s, Critical Path: 107.17s
INFO: 490 processes: 9 internal, 440 local, 41 worker.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully
To Reproduce
I have checked out the master an tried to run  bazel build src/main/java/com/google/j2cl/samples/helloworld:helloworld

It seems that you are encountering an error while running the Bazel build command for the helloworld target in the com/google/j2cl/samples/helloworld package. The error message suggests that there are unused native files causing the build failure.
Here are a few suggestions to troubleshoot the issue:
Check the build configuration: Ensure that you have the correct dependencies and build settings configured for the J2CL project. Make sure that all required dependencies are correctly specified in the BUILD files and that your Bazel workspace is set up properly.
Verify the J2CL version: Ensure that you are using a compatible version of the J2CL transpiler. Check if there are any specific version requirements or compatibility issues mentioned in the project's documentation or release notes. You might need to update or adjust the J2CL version accordingly.
Clean and rebuild: Try cleaning the Bazel build cache and performing a clean build. Run bazel clean --expunge to remove any cached build artifacts and then try building again using the bazel build command.
Check for unused native files: The error message indicates that there are unused native files causing the build failure. Review the J2CL project's configuration and make sure that the native files are correctly included or excluded as needed. You might need to update the build configuration to address this issue.
Enable verbose output: If the issue persists, you can use the --verbose_failures flag with the bazel build command to get more detailed information about the failed build steps. This can help you identify the specific cause of the failure.
If none of these suggestions resolve the issue, I recommend consulting the J2CL project's documentation, issue tracker, or community forums for further assistance. They may have specific recommendations or workarounds for the problem you are facing.

Works for me on Linux. Could it be because you're using Windows, and outside WSL? (see https://github.com/google/j2cl#caveat-emptor)
(note: I do have the same warnings about @local_jdk//:jar and the Kotlin toUpperCase→uppercase et al., but not the libast ones about annotation processing)


Rename repo to OSIPI_SDK

The current name 'pypi' is confusing. Suggest renaming our repo to osipi_sdk. Need to also update webpage name and documentation to reflect the change.

what does sdk stand for?
The name of the repo does not matter so much as long as you keep
pip install osipi
and
import osipi
On the other hand you don't want to keep changing it all the time so its
probably worth a discussion at EMB level rather than a quick change. The
naming of the repos on the OSIPI github organisation is not very consistent

a good approach may be to always prefix it with the TF number (like some
of the others) in which case you could also do something like

TF2.3_Python_Package
Prof. Steven Sourbron, PhD
Chair in Medical Imaging Physics
University of Sheffield, UK
https
https://www.sheffield.ac.uk/medicine/people/iicd/steven-sourbron://www.sheffield.ac.uk/medicine/people/iicd/steven-sourbron
https://www.sheffield.ac.uk/medicine/people/iicd/steven-sourbron
Sheffield abdominal imaging research page
https://www.sheffield.ac.uk/medicine/research/research-themes/medical-imaging/medical-imaging-research/abdominal-imaging
Open source initiative in perfusion imaging http://www.osipi.org
Magnetic resonance imaging biomarkers for chronic kidney disease
https://renalmri.org/
On Thu, 14 Mar 2024 at 23:19, stadmill @.***> wrote:

The current name 'pypi' is confusing. Suggest renaming our repo to
osipi_sdk. Need to also update webpage name and documentation to reflect
the change.
—
Reply to this email directly, view it on GitHub
https://github.com/OSIPI/pypi/issues/14, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOFKA6J5P2KFILF3GKNSKLYYIWBBAVCNFSM6AAAAABEW75VAKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DONBTHA2TIOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I think just naming it "osipi" will be fine. SDK stands for software development kit, but I think that's implied. I also think that this is going to be a more general repository, not TF 2.3 specific so I'd like to avoid the TF nomenclature.

Luis Torres
Scientific Solutions Engineer | Flywheel
<EMAIL_ADDRESS>| Book time to meet with mehttps://outlook.office.com/bookwithme/user/2de1020ae17c424082d8eb3882bbb6e4%40c88032d3-19d1-4040-b9bf-b84c29a49480/meetingtype/09705449-c7ee-4131-b1b9-3e961b18baf2?anonymous
[Artboard 2 (8).png]https://flywheel.io/?utm_source=signature&utm_medium=email&utm_campaign=2023emailsignature
flywheel.iohttps://flywheel.io/?utm_source=signature&utm_medium=email&utm_campaign=2021newsignature - Sign up to receive our monthly updateshttps://flywheel.io/opt-in-to-customer-communications/?utm_source=email&utm_medium=signature&utm_campaign=osmsignature

From: Steven Sourbron @.>
Sent: Friday, March 15, 2024 5:10 AM
To: OSIPI/pypi @.>
Cc: Luis Torres @.>; Assign @.>
Subject: Re: [OSIPI/pypi] Rename repo to OSIPI_SDK (Issue #14)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
what does sdk stand for?
The name of the repo does not matter so much as long as you keep
pip install osipi
and
import osipi
On the other hand you don't want to keep changing it all the time so its
probably worth a discussion at EMB level rather than a quick change. The
naming of the repos on the OSIPI github organisation is not very consistent

a good approach may be to always prefix it with the TF number (like some
of the others) in which case you could also do something like

TF2.3_Python_Package
Prof. Steven Sourbron, PhD
Chair in Medical Imaging Physics
University of Sheffield, UK
https
https://www.sheffield.ac.uk/medicine/people/iicd/steven-sourbron://www.sheffield.ac.uk/medicine/people/iicd/steven-sourbron
https://www.sheffield.ac.uk/medicine/people/iicd/steven-sourbron
Sheffield abdominal imaging research page
https://www.sheffield.ac.uk/medicine/research/research-themes/medical-imaging/medical-imaging-research/abdominal-imaging
Open source initiative in perfusion imaging http://www.osipi.org
Magnetic resonance imaging biomarkers for chronic kidney disease
https://renalmri.org/
On Thu, 14 Mar 2024 at 23:19, stadmill @.***> wrote:

The current name 'pypi' is confusing. Suggest renaming our repo to
osipi_sdk. Need to also update webpage name and documentation to reflect
the change.
—
Reply to this email directly, view it on GitHub
https://github.com/OSIPI/pypi/issues/14, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOFKA6J5P2KFILF3GKNSKLYYIWBBAVCNFSM6AAAAABEW75VAKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DONBTHA2TIOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

—
Reply to this email directly, view it on GitHubhttps://github.com/OSIPI/pypi/issues/14#issuecomment-1999335205, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI6Z5B2YUMTY5CUKROBFKSDYYLCI7AVCNFSM6AAAAABEW75VAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGMZTKMRQGU.
You are receiving this because you were assigned.Message ID: @.***>

Agree. This is just a name change of the repo, not the package. And SDK makes it clear what it is. I don't want to add TF prefixes, there are too many of these repos already.


Decode multiplexed signal behaves strange. What am I doing wrong?

My Problem is, that when I try to decode a multiplexed signal, the first value of the returned dict, which carries the multiplexer id, has the name of the first multiplexer as a key. Should this really be the case? Shouldn't the key be something generic like MUX?
Please see the following example for better understanding my Problem:
When I use for example the following `.sym' file:
FormatVersion=6.0 // Do not edit this line!
Title="CanMsgs"

{ENUMS}

{SIGNALS}

{SENDRECEIVE}
[TestSig]
ID=700h
Len=2
CycleTime=1000
Mux=FSM 0,8 1
Var=alert1 unsigned 8,1
Var=alert2 unsigned 9,1
Var=alert3 unsigned 10,1

[TestSig]
Len=2
CycleTime=1000
Mux=DCM 0,8 2
Var=alert1 bit 8,1
Var=alert2 bit 9,1
Var=alert3 unsigned 10,1

And I run the following code:
import cantools

db = cantools.database.load_file('test.sym')

print(db.decode_message('TestSig', b'\x01\x00\x00\x00\x00\x00\x00\x00'))
print(db.decode_message('TestSig', b'\x02\x00\x00\x00\x00\x00\x00\x00'))

I get the following output:
{'FSM': 1, 'alert1': 0, 'alert2': 0, 'alert3': 0}
{'FSM': 2, 'alert1': 0, 'alert2': 0, 'alert3': 0}

So as you see, the first key is always FSM. If I want to probe on the multiplexer id, I can of course ignore the key and just take the value of the first entry, but this somehow feels not like a proper way of doing it.
Thank you very much for your help in advance.
Cheers
Luke

in python, ordinary dictionaries do not have an ordering, so there is no "first" entry, because -- in principle -- the order of the keys is undefined. what you probably need is to access the values of the dictionary by name, i.e. something like:
# [...]
decoded_signals = db.decode_message('TestSig', b'\x01\x00\x00\x00\x00\x00\x00\x00')
if decoded_signals['FSM'] == 1:
    # do something if the selector signal was set to 1
    print("Selected 1")
elif  decoded_signals['FSM'] == 2:
    # do something if the selector signal was set to 1
    print("Selected 2")

(you probably want to assign different signals to a given mux value, else using a multiplexer does not make much sense.)

Hey,
first of all, thank you for your answer.
What you describe about ordering is actually my concern.
But what I don't understand is why the key for the multiplexer value is always the first multiplexer value defined in the .sym file. In my example I specify FSM for multiplexer 1 and DCM for the second. But the key in the decoded dict is always FSM....

Hi. cantools started with dbc support. Dbcs do not know the concept of naming multiple multiplexers directly. In dbc, the multiplexor is treated as a signal with just one name. It just is marked to be a multiplexor. The signals are then multiplexed signals.
I think this is the reason cantools cannot reflect the naming options that sym offers there.

Thank you for clarification. Then I need to find a workaround for what I have planned 😄


Clickable areas not responding.

I am trying to make a redshift and a megasync module for myself, basic stuff, but the click commands don't do anything, don't even show an error.
Neither of these work:
[module/redshift]
type = custom/text
content = "  RDSFT "
click-left = ~/.scripts/redshift-toggle.sh
[module/megasync]
type = custom/text
content = " MEGA "
click-left = megasync &
But what is really weird is the these two work fine:
[module/drun]
type = custom/text
content = "    "
click-left = rofi -show drun
[module/powermenubar]
type = custom/text
content = "    "
click-left = polybar powermenu

Can you please post your whole config.
Do the commands specified in click-left work if executed from a terminal?
Could you also run polybar with -l trace, reproduce this behaviour and then post the whole output here.
You may get an error message, when running polybar with -l trace, this means that polybar wasn't compiled with trace logging support. You will need to recompile polybar and add -DCMAKE_BUILD_TYPE=Debug to the cmake command when you do.

This is my config file. Yes, if I attempt to excute the command from the terminal they work. Here is the output of -l trace.

- bar: Received button press: 1 at pos(111, 24)
- Found matching input area
* Uncaught input event, forwarding to shell... (input: ~/Repos/dotfiles/.scripts/redshift-toggle.sh)
* Executing shell command: ~/Repos/dotfiles/.scripts/redshift-toggle.sh
- command: Waiting for pid 1072 to finish...
- command: Exited with status 0

Polybar definitely executes the command and the command finishes successfully. This doesn't seem to be an issue with polybar directly but rather the two programs have trouble executing properly when started from within polybar. You can start to diagnose this by gathering the outputs of those two commands. To do this modify your click settings as follows:
 click-left = cmd 2>&1 > /path/to/logfile

Closing due to inactivity


Update Variables'name with new ffmpeg version

ffmpeg/libav drops deprecated code (master branch):
http://git.videolan.org/?p=ffmpeg.git;a=commit;h=183db02a51a422568084b113a7571c845ca68622
and other commits

Please provide ffmpeg version or libavcodec version

Could you please add PR description with information about used ffmpeg (or libav) version?
To be merged patch should not break builds for existed platforms. I believe some "#if" should be added like this (with correct ffmpeg versions):
#if LIBAVCODEC_BUILD >= (LIBAVCODEC_VERSION_MICRO >= 100 \
     ? CALC_FFMPEG_VERSION(54, 59, 100) : CALC_FFMPEG_VERSION(54, 28, 0))

ffmpeg just release 2.8 version these days with LIBAVUTIL_VERSION_MAJOR 55 MINOR 1 MICRO 100.

How to reproduce build problem? I can't reproduce problem with ffmpeg 2.8 (git tag n2.8) during build of windows ffmpeg wrapper. It builds without problems.

Please see FFmpeg repo master branch commit 183db02a51a42256808, they delete old_pix_fmt.h where PIX_FMT_BGR24 and other macros are defined.

Thanks, I see this and can reproduce build problem.
This commit is on master branch only. It is not part of 2.8 release (and not on 2.9-dev).

Yeah It might not be a problem right now, but there are always someone use ffmpeg's master branch.

Unfortunatelly this patch doesn't work on Ubuntu 12.04 LTS with libav:
--     FFMPEG:                      YES
--       codec:                     YES (ver 53.35.0)
--       format:                    YES (ver 53.21.1)
--       util:                      YES (ver 51.22.3)
--       swscale:                   YES (ver 2.1.0)
--       resample:                  NO
--       gentoo-style:              YES

Need to be more accurate here (#ifdef doesn't work with enum values, also we can't force AVPixelFormat, because it is undefined in the old ffmpeg versions).
I will try to provide fix for this later on this week.

Changes are moved to #5361


Fixed ingress traffic "latest" bug.

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Btw this works E2E when I test it on an app with traffic split. Thanks @haroonf!


[WIP] new snapshotter: zfs

Usage:

set snapshotter to zfs in config.toml
mount a zfs on /var/lib/containerd/snapshot/zfs

I confirmed dist pull & ctr run works with Ubuntu 17.04 kernel-mode
ZFS.
Should work on other ZFS implementations as well.
Note that BasicTest still fails because Remove() is not fully implemented
(Also, you need to set -test.zpool=your-zpool for running zfs.test)
Signed-off-by: Akihiro Suda<EMAIL_ADDRESS>cc @justincormack

I'm not sure we want this in tree.  Our general idea is that we are going to have a minimal set of snapshotters/rutimes in tree that we will fully support.  We have made it very easy to extend and the goal is to not have all code that someone wants to have to be merged in the main repository.
So I think we have two options.  We can problably make a containerd/zfs repo where this snapshotter will live; we can also expand this to containerd/aufs, etc.  But I'm pretty sure we don't want it as a built in.
Or it can be an external repo outside of the org maintained by the people who built it.
@AkihiroSuda what do you think about the plan?  This has been our design from the beginning and why we are so interested in go plugins or registration of packages.

If no one is interested in zfs, it should be an external repo :sweat_smile:
If the community is likely to be interested in zfs as a official plugin, containerd/snapshotter-zfs seems the right approach. (prefix for repo name needs consideration. maybe plugin-, contrib-...)
Also, if the project is going to officially support FreeBSD/Solaris/OpenSolaris-children, it might be good to vendor that zfs repo in this repo?

I don't know if we need a prefix, it should be obvious what zfs is within the containerd repo.
I don't know anything about the status of freebsd at the moment.  No one has discussed it or their plans.

Isn't it confusing https://github.com/containerd/zfs is a containerd plugin while https://github.com/containerd/btrfs is generic go library?
cc @stevvooe

@AkihiroSuda Either way, this seems premature. Let's at least take this project to feature complete before adding bells and whistles.

Isn't it confusing https://github.com/containerd/zfs is a containerd plugin while https://github.com/containerd/btrfs is generic go library?

That's what READMEs and repository descriptions are for. The package should just be named zfs and it is fine as a top level repository.

There is always the option of moving the snapshotter out for btrfs and it would find a good hope with its bindings at containerd/zfs but we don't want to do that for now.
@AkihiroSuda if you are interested in adding zfs to containerd/zfs and making sure it stays up to date then we can vote and get the new repo setup.

ok, I'm closing and will try to separate the repo.
I'll let you know when the repo is ready to move.

FYI: repo for ZFS plugin is available (unstable yet): https://github.com/AkihiroSuda/containerd-zfs


GEAR-1996 comment out templateflow env vars

It turns out that the fMRIPrep BIDS App recently started baking in the TemplateFlow templates so adding that as an input is not necessary and switching to a writeable directory for TEMPLATEFLOW_HOME and SINGULARITYENV_TEMPLATEFLOW_HOME are also no longer needed.
The old code was commented out instead of deleted because it may be necessary someday if somebody wants to use a different template.  This might be needed when running under Singularity because the code won't have write access to the default location.

Yes, see --output-spaces here.

Ah, great!
LGTM!


Question: Is this library designed to be thread safe?

Hello again,
I will be using the logger in combination with some multi-threaded workloads using:
https://github.com/mitchellh/libxev
Will this library be a good fit to log debug messages from multiple threads to a central place?
Best,
Jan

Hey @JanBeelte,
this lib will be thread safe in the future. Currently I won't recommend this library. Please use something more mature like https://github.com/karlseguin/log.zig .
This should be thread safe, hope this helps. I have one open issue which will tackle a redesign.

Hey @hendriknielaender!
Thanks a lot for the quick response.
I had two more options on the table:

https://github.com/karlseguin/log.zig
https://github.com/chrischtel/nexlog

currently I am leaning towards 2. but still need to figure out some details.
Good luck with the redesign, let me know when you need some feedback!
Best,
Jan


Update 02-B-Enemies.md

Edited the tutorial to simplify and follow the new formatting.

Edited all the levels, so I'll wait for other eyes before merging.

Edited all the levels, so I'll wait for other eyes before merging.

Pausing until pop-up references has been sorted.

Pausing until pop-up references has been sorted.


Not able to pull images from trow-registry. "unexpected commit digest"

I assume I must have missed the secret "cred" pod, so could someone please explain how to set the deployment API:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: optimistic-app
  namespace: notdefaultforsure
spec:
  selector:
    matchLabels:
      name: optimistic-backend
  template:
    metadata:
      labels:
        name: optimistic-backend
    spec:
      imagePulleSecrets:
        - name: trow-password   << what to add here?
      containers:
        - name: backend
          image: trow.optimistic.reg/simpleapp:latest
          ports:
            - containerPort: 80

I used the helm chart - but that's not ideal as I couldn´t figure out how to set a namespace.
Edit: cleaned up a bit.

So in the Helm chart you can explicitly set a username and password for the registry. If you don't do this, it should be configured with no password authentication.
If there's no password, just remove the "imagePullSecrets" section.
If there is a password, follow the Kubernetes docs on how to create the secret at https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/. It should be something like:
kubectl create secret docker-registry regcred --docker-server=trow.optimistic.reg --docker-username=<your-name> --docker-password=<your-pword>

Where the name and password are whatever you put in the Helm config.

So in the Helm chart you can explicitly set a username and password for the registry. If you don't do this, it should be configured with no password authentication.
If there's no password, just remove the "imagePullSecrets" section.
If there is a password, follow the Kubernetes docs on how to create the secret at https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/. It should be something like:
kubectl create secret docker-registry regcred --docker-server=trow.optimistic.reg --docker-username=<your-name> --docker-password=<your-pword>

Where the name and password are whatever you put in the Helm config.

Thank you.. did that as well,
I am able to pull and push from outside of the cluster. No problem at all.
read about containerd, and possible errors related to that, but with no luck.
According to the k3s docs I made a registries.yaml, with creds to trow.
This is the error I get, when deploy a pod:
"
Failed to pull image "trow.reg.com/image:k3s": rpc error: code = FailedPrecondition desc = failed to pull and unpack image "trow.reg.com/image": failed commit on ref "config-sha256:695e143792a2c7692076f30f705bbfcc8bb89bb312d32bc16837b032938ba37a": unexpected commit digest sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, expected sha256:695e143792a2c7692076f30f705bbfcc8bb89bb312d32bc16837b032938ba37a: failed precondition
"

Thank you.. did that as well,
I am able to pull and push from outside of the cluster. No problem at all.
read about containerd, and possible errors related to that, but with no luck.
According to the k3s docs I made a registries.yaml, with creds to trow.
This is the error I get, when deploy a pod:
"
Failed to pull image "trow.reg.com/image:k3s": rpc error: code = FailedPrecondition desc = failed to pull and unpack image "trow.reg.com/image": failed commit on ref "config-sha256:695e143792a2c7692076f30f705bbfcc8bb89bb312d32bc16837b032938ba37a": unexpected commit digest sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, expected sha256:695e143792a2c7692076f30f705bbfcc8bb89bb312d32bc16837b032938ba37a: failed precondition
"

That's actually a bug I've been having problems recreating! Can you give more details on what you did to get that? What image you used, the version of kubernetes and containerd etc?

That's actually a bug I've been having problems recreating! Can you give more details on what you did to get that? What image you used, the version of kubernetes and containerd etc?

Sure.
kubernetes v19.7
containerd v1.4.3
Trow image: docker.io/containersol/trow:0.3
this is the deployment section of the config:
--- apiVersion: apps/v1 kind: Deployment metadata:   name: web-app   namespace: web spec:   selector:     matchLabels:       name: web-backend   template:     metadata:       labels:         name: web-backend     spec:       containers:         - name: backend           image: trow.reg.com/mynginx:test           ports:             - containerPort: 80       imagePullSecrets:         - name: regcred ---
This is the helm values.yaml settings:
`
affinity: {}
fullnameOverride: ""
image:
pullPolicy: Always
repository: containersol/trow
imagePullSecrets: []
ingress:
enabled: true
annotations:
kubernetes.io/ingress.class: traefik
cert-manager.io/cluster-issuer: letsencrypt-prod
nginx.ingress.kubernetes.io/proxy-body-size: 300m
nginx.ingress.kubernetes.io/proxy-read-timeout: "600"
nginx.ingress.kubernetes.io/proxy-send-timeout: "600"
tls:

hosts:

trow.reg.com
secretName: myingress-cert
hosts:

host: trow.reg.com
paths:

/
nameOverride: ""
nodeSelector: {}
replicaCount: 1
resources: {}
service:
port: 8000
type: ClusterIP
tolerations: []
trow:
domain: trow.reg.com
password: password
user: user
validatingWebhooks:
enabled: false
volumeClaim:
accessModes:

ReadWriteOnce
storageClassName: longhorn
resources:
requests:
storage: 20Gi
`

The config file I use to deploy the app works fine when using docker hub
kubectl apply -f app-deploy.yml

Sure.
kubernetes v19.7
containerd v1.4.3
Trow image: docker.io/containersol/trow:0.3
this is the deployment section of the config:
--- apiVersion: apps/v1 kind: Deployment metadata:   name: web-app   namespace: web spec:   selector:     matchLabels:       name: web-backend   template:     metadata:       labels:         name: web-backend     spec:       containers:         - name: backend           image: trow.reg.com/mynginx:test           ports:             - containerPort: 80       imagePullSecrets:         - name: regcred ---
This is the helm values.yaml settings:
`
affinity: {}
fullnameOverride: ""
image:
pullPolicy: Always
repository: containersol/trow
imagePullSecrets: []
ingress:
enabled: true
annotations:
kubernetes.io/ingress.class: traefik
cert-manager.io/cluster-issuer: letsencrypt-prod
nginx.ingress.kubernetes.io/proxy-body-size: 300m
nginx.ingress.kubernetes.io/proxy-read-timeout: "600"
nginx.ingress.kubernetes.io/proxy-send-timeout: "600"
tls:

hosts:

trow.reg.com
secretName: myingress-cert
hosts:

host: trow.reg.com
paths:

/
nameOverride: ""
nodeSelector: {}
replicaCount: 1
resources: {}
service:
port: 8000
type: ClusterIP
tolerations: []
trow:
domain: trow.reg.com
password: password
user: user
validatingWebhooks:
enabled: false
volumeClaim:
accessModes:

ReadWriteOnce
storageClassName: longhorn
resources:
requests:
storage: 20Gi
`

The config file I use to deploy the app works fine when using docker hub
kubectl apply -f app-deploy.yml

I also checked to see of there should be some layer-cache issue in:
${containerd folder}/io.containerd.content.v1.content/ingest
But that is empty.

I also checked to see of there should be some layer-cache issue in:
${containerd folder}/io.containerd.content.v1.content/ingest
But that is empty.

i have the same problem on k3s (which is based on containerd). its rather easy to reproduce:
first i installed a local CA using cert-manager:
# install cert-manager 1.2.0
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.2.0/cert-manager.yaml

# creating a local CA (letsencrypt won't work for localhost)
mkdir /tmp/ca.$$ && cd /tmp/ca.$$
openssl genrsa -out ca.key 2048
openssl req -x509 -new -nodes -key ca.key -subj "/CN=local_k3s" -days 3650 -reqexts v3_req -extensions v3_ca -out ca.crt
kubectl create secret tls ca-key-pair \
   --cert=ca.crt \
   --key=ca.key \
   --namespace=cert-manager

# lets make sure our computer trusts this CA!
sudo cp ca.crt /usr/local/share/ca-certificates/selfsigned-k3s.crt && sudo update-ca-certificates

# lets create a cluster issuer that will issue certificates using our newly created CA
cat << END | kubectl apply -f -
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: selfsigned-ca-issuer
  namespace: cert-manager
spec:
  ca:
    secretName: ca-key-pair
END

then i restarted docker and k3s otherwise they would not accept the new certificate.
then i installed trow via helm:
kubectl create namespace trow

# let's create a SSL certificate for our container registry
cat << END  | kubectl apply -f -
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: trow-kube-public
  namespace: trow
spec:
  secretName: trow-kube-public
  issuerRef:
    name: selfsigned-ca-issuer
    kind: ClusterIssuer
  commonName: trow.kube-public
  dnsNames:
  - trow.kube-public
END

# let's install trow
helm repo add trow https://trow.io
helm install trow trow/trow \
         --namespace trow \
         --create-namespace \
         --set 'trow.domain=trow.kube-public' \
         --set 'ingress.enabled=true' \
         --set 'ingress.hosts[0].host=trow.kube-public,ingress.hosts[0].paths={"/"}' \
         --set 'ingress.tls[0].hosts[0]=trow.kube-public' \
         --set 'ingress.tls[0].secretName=trow-kube-public' \
         --set trow.user=user --set trow.password=password

then i created imagepullsecrets and patched the default service account to use them
# let's fake a DNS entry!
MYIP=$(hostname -I | cut -d' ' -f1)
echo "$MYIP trow.kube-public" | sudo tee -a /etc/hosts

kubectl create secret docker-registry trow --docker-server=trow.kube-public \
     --docker-username=user --docker-password=password

kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "trow"}]}'

then i tried pushing an image and using it:
docker tag ubuntu:20.04 trow.kube-public/ubunt
docker run -it --rm --image trow.kube-public/ubunt -- bash

then i got exactly the same error with exactly the same hash (which is the hash of an empty file). in the logs i found:
 Trow is up and running!                                                                                │
│ _[WARN] Responding with 401 Unauthorized catcher.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:da7391352a9bb76b292a568c066aa4c3cbae8d494e6a3c68e3c596d34f7c75f8.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:14428a6d4bcdba49a64127900a0691fb00a3f329aced25eb77e3b65646638f8d.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:2c2d948710f21ad82dce71743b1654b45acb5c059cf5c19da491582cef6f2601.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:f643c72bc25212974c16f3348b3a898b1ec1eb13ec1539e10a103e6e217eb2f1.                                                                                │
│ _[WARN] Responding with 401 Unauthorized catcher.                                                                                │
│ _[WARN] Responding with 401 Unauthorized catcher.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:2c2d948710f21ad82dce71743b1654b45acb5c059cf5c19da491582cef6f2601.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:14428a6d4bcdba49a64127900a0691fb00a3f329aced25eb77e3b65646638f8d.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:da7391352a9bb76b292a568c066aa4c3cbae8d494e6a3c68e3c596d34f7c75f8.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/ubunt/blobs/sha256:f643c72bc25212974c16f3348b3a898b1ec1eb13ec1539e10a103e6e217eb2f1.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/j/manifests/latest application/vnd.docker.distribution.manifest.v2+json.                                                                                │
│ _[WARN] Responding with 401 Unauthorized catcher.                                                                                │
│ _[ERROR] No matching routes for POST /login application/x-www-form-urlencoded; charset=utf-8.                                                                                │
│ _[WARN] Responding with 404 Not Found catcher.                                                                                │
│ _[ERROR] No matching routes for HEAD /v2/j/manifests/latest application/vnd.docker.distribution.manifest.v2+json.                                                                                │
│ _[WARN] Responding with 401 Unauthorized catcher.                                                                                │
│ _[ERROR] No matching routes for POST /login application/x-www-form-urlencoded; charset=utf-8.                                                                                │
│ _[WARN] Responding with 404 Not Found catcher.                                                                                │

Thanks you @kervel ! I'll try to take a look at this in the middle of next week.

I've made some progress on this. You might want to try a build from master and see what the current error is. It's been a big pain to reproduce as configuring a standalone containerd is weirdly difficult. I should see if I can get it running in a container :)
Part of the problem seems to have been that Trow wasn't setting the content-length header after a recent refactoring. I've fixed this, but then I started getting errors about the size being incorrect that I've not got to the bottom of. Possibly they are just red herrings caused by after effects of earlier tests.
There may still be an issue with authentication, but it wasn't working without authentication either, so I haven't investigated that part yet.

I've just spent the morning retesting and things seem to be working, so it seems to have been entirely the missing content-length header. K3S can pull an image from Trow with and without authentication.
If you want to use this fix, you'll need to use an image built from the master branch e.g. containersol/trow:2021-02-27-112-amd64 or even latest.
In the meantime I'll create a release and look at updating the helm chart.

Great, thanks a lot !
greetings,
Frank

Ok, the Helm chart should be updated.
If you get a chance to test again, please let me know. I'm going to close this for the minute as I think it at least fixes some of the problems.


Clean up notDisposed leaks in Flutter Framework.

Looking for volunteers to help with this!
Subtask of: https://github.com/flutter/devtools/issues/3951
All invocations of testWidgets under flutter/test  (~ 10,000) should be converted to testWidgetsWithLeakTracking by iterating the steps:

Comment on this issue what subset of tests you plan to work on so that we do not duplicate work.

Convert set of testWidgets, create PR and, if tests pass, request review and merge. Example: https://github.com/flutter/flutter/pull/132806

For tests that fail, investigate them and search for the culprit class name in this issue comments. If the fix seems to be on the way, skip this test. Otherwise, move the conversion to a separate PR, and do one of two in this PR:
a. Fix the failure if it is strait-forward.
b. Create issue that explains the leak, create allowlist, and link the issue near the allowlist. Example: https://github.com/flutter/flutter/pull/130468. Then either allow triage process to happen or assign the issue for yourself and resolve it in a separate PR.

Link the issue and the fix in a comment for this PR.

Discord

    - [ ] cupertino
    - [ ] material (~ 4000 tests - [failures](https://raw.githubusercontent.com/flutter/flutter/6a57468cd4e29e900d3fca1f931e023af9c546df/packages/flutter/test/material/_material_test_results.txt))
        - [x] https://github.com/flutter/flutter/issues/130467
        - [x] https://github.com/flutter/flutter/issues/130354
        - [ ] https://github.com/flutter/flutter/issues/130469
        - [x] https://github.com/flutter/flutter/issues/132620
        - [x] https://github.com/flutter/flutter/issues/132769
        - [ ] https://github.com/flutter/flutter/issues/133071
        - [ ] https://github.com/flutter/flutter/pull/133352
    - [ ] painting
    - [ ] physics
    - [ ] rendering
    - [ ] scheduler
    - [ ] semantics
    - [ ] services
    - [ ] widgets

progress check: 2071 tests are converted

Yes, not al extenders of ChangeNotifier do this at the moment.
For now it is added as needed, so no tracking yet. I have two PRs for this waiting lgtm:
https://github.com/flutter/flutter/pull/133716
https://github.com/flutter/flutter/pull/133717
Feel free just add it where you need.

@polina-c Where do we track that all required widgets/services do
    if (kFlutterMemoryAllocationsEnabled) {
      maybeDispatchObjectCreation();
    }

in their constructor?

Yes, not al extenders of ChangeNotifier do this at the moment.
For now it is added as needed, so no tracking yet. I have two PRs for this waiting lgtm:
https://github.com/flutter/flutter/pull/133716
https://github.com/flutter/flutter/pull/133717
Feel free to just add it where you need.

@polina-c Could you please take a look at this PR, which adds tracking to the ScrollController: https://github.com/flutter/flutter/pull/133759 ?

progress check: 3458 tests covered

@ksokolovskyi , I updated description asking to communicate subset of tests where you plan to work.
I am working on test/material and test/painting.

@polina-c, nice, thanks.
If you don't mind, I would like to continue with test/widgets.

I am starting work on test/services if that's fine with you.

progress check: 5223 tests are converted

working on test/semantics

Progress check: 6202 tests are converted.

Labelled issues and PRs with "a: leak tracking" and linked in description.

@ksokolovskyi , @NobodyForNothing , I am participating internal event on the week of Sep 25. I will handle all PRs, when I am back on Oct 2.

@polina-c I also like to contribute to this, which subset are still available?

@polina-c I also like to contribute to this. Can I start with test/paintings and test/gestures, if it is not taken by anyone?

@droidbg, yes and thank you!
Added test/paintings and test/gestures to the focus areas in description.
And, please, take into account this issue and related PRs working with gestures: https://github.com/flutter/flutter/issues/136132

covered: 8826
remaining: 1036.

@polina-c I have raised PRs for test/gesture and test/painting, could you please review it.

Also, test/gesture is done and test/painting is almost done, so I will be picking test/rendering in parallel now.

@polina-c I have raised PRs for test/rendering, could you please review it.
Also, can I pick test/cupertino if no one is working on it now?

Will appreciate votes here: https://github.com/flutter/devtools/issues/6266#issuecomment-1758474605
@NobodyForNothing @ksokolovskyi @droidbg @navaronbracke

FYI, update on leak_tracker progress: https://discord.com/channels/608014603317936148/1106667330093723668/1162097704462196788

Hello folks, these are the updates on the subsets I was working on:

test/gesture - done.
test/painting - 1 PR is open , rest are done.
test/rendering - done.
test/cupertino - 1 PR is open by NobodyForNothing , rest are done.

@polina-c
Can I pick up test/material, if no one is working on it?
or if there is anything else that I can help with, do let me know. Thanks.

Hi @droidbg, thanks for your work!
Currently, I'm responsible for material and widgets tests.
All material tests will be covered after #137004 merge.
@polina-c, do you have any tasks for @droidbg?

@ksokolovskyi, @droidbg , @NobodyForNothing , I greatly appreciate your help!
Closing this issue in favor of the next phase, where help is also needed and appreciated: https://github.com/flutter/flutter/issues/137311

do you have any tasks for @droidbg?

Yes, pick any class or test-set in https://github.com/flutter/flutter/issues/137311


SOLID POD: Read and write binary data

The readPod() and writePod() implicitly requires the data to read/write is a string.
However, this won't be the case when reading / writing EEG data. Solidpod needs to support the read / write of binary data (i.e. bytes) in addition to text data.

Please follow the below steps to test.

Start demopod
Click Upload / Download Large File button
Click Browse button to choose a local file to upload (I used the ZIP archive of this EEG folder on next cloud)
Click Upload button, which shows a progress bar as illustrated in the screenshot below
To test download or delete functionality, click the Download or the Delete button, and a similar a progress bar will appear.
After testing upload, download, and delete, expecting to see something like the screenshot below.

Tested. Works as advertised.

Note that
A container can only be deleted if it contains no resources.
as per https://github.com/solid/solid-spec/blob/master/api-rest.md#deleting-containers

Note that this implements a workaround to issue https://github.com/anusii/solidpod/issues/214

A large binary file is stored in

a directory with chunks of the binary file and their ACL files
and a .ttl file with paths of binary file chunks, for example,

@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix sii: <https://solidproject.au/sii/> .
@prefix c: <https://pods.solidcommunity.au/dc101/exampleApp/data/.large_file.bin.chunks/> .

<https://pods.solidcommunity.au/dc101/exampleApp/data/large_file.bin>
    sii:dataSize "47354712"^^xsd:int ;
    sii:dataChunk c:0.bin, c:1.bin, c:2.bin, c:3.bin, c:4.bin, c:5.bin, c:6.bin, c:7.bin, c:8.bin, c:9.bin, c:10.bin, c:11.bin, c:12.bin, c:13.bin, c:14.bin, c:15.bin, c:16.bin, c:17.bin, c:18.bin, c:19.bin, c:20.bin, c:21.bin, c:22.bin .


refactor: refactor envelope and signer to support cose

This PR is splitted into https://github.com/notaryproject/notation-core-go/pull/59 and https://github.com/binbin-li/notation-core-go/pull/1 .
What?
Background can be checked out in https://github.com/notaryproject/notation/discussions/278

Created a new signature submodule to refactor the original signer submodule.
Created Envelope interface.
Renamed the original SignatureProvider to Signer.
Created LocalSigner to support native signing implementation provided by underlying crypto libraries, e.g. go-cose, go-jwt.
Created internal.base.Envelope struct to replace the orginal SignatureEnvelope struct.
Other refactoring on the algorithm and keySpec definitions.

Test?
Added corresponding unit tests.
Notes
cose and jws folders are left empty for now which will be addressed in following PRs.
Signed-off-by: Binbin Li<EMAIL_ADDRESS>

Codecov Report

Merging #53 (b713657) into main (17e2d18) will increase coverage by 4.69%.
The diff coverage is 97.58%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   70.33%   75.02%   +4.69%
==========================================
  Files          23       29       +6
  Lines        1591     1922     +331
==========================================
+ Hits         1119     1442     +323
- Misses        355      363       +8
  Partials      117      117

Impacted Files
Coverage Δ

signature/types.go
0.00% <0.00%> (ø)

signature/signer.go
96.61% <96.61%> (ø)

signature/algorithm.go
100.00% <100.00%> (ø)

signature/envelope.go
100.00% <100.00%> (ø)

signature/errors.go
100.00% <100.00%> (ø)

signature/internal/base/envelope.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@binbin-li Can you open https://github.com/binbin-li/notation-core-go/pull/1 on notation-core-go repo?

@binbin-li Can you open binbin-li#1 on notation-core-go repo?

Sure, I'll create one. But that PR depends on the https://github.com/notaryproject/notation-core-go/pull/59, so it will fail some check which should pass once we merge the first one.

Per the https://github.com/notaryproject/notation/discussions/263 https://github.com/orgs/notaryproject/teams/notation-sub-group-maintainers - this PR is already past a week old and has two approvals from official code-reviewers, so it is eligible for merge now.

This PR closes #59 and #64.

@shizhMSFT @yizha1 could we revert this merge. COSE envelope support is a significant feature and it would be ideal to get reviews from multiple maintainers (as opposed to smaller changes which can be merged after a week). Both Pritesh and me have been away last week on vacation till Sept 5th. We'll be able to review this PR this week.


Apply specialization to shader reflection

Changelog:
- - Specialization constants are now provided with a `HashMap` containing `SpecializationConstant` enum values. The `SpecializationConstants` trait is removed, and `vulkano_shaders` no longer generates structs for specialization constants.
+ - Specialization constants are now provided by calling `ShaderModule::specialize` with a `HashMap` containing `SpecializationConstant` enum values. This produces a `SpecializedShaderModule` value, which you can then create an `EntryPoint` from.
+ - The `SpecializationConstants` trait is removed, and `vulkano_shaders` no longer generates structs for specialization constants.

### Bugs fixed
- Specialization constants are now applied to the reflected SPIR-V code before any other reflection is performed.

Shader specialization has been moved to its own type, SpecializedShaderModule. You create this from a regular ShaderModule by calling with_specialization, and it has methods to create an entry point. The old entry point methods that were directly on ShaderModule are still there, but they are now simply shortcuts for calling with_specialization with no specialization constants, and then calling the corresponding entry point method of SpecializedShaderModule.
When you create a SpecializedShaderModule, a replacement pass is made through the reflected SPIR-V module, replacing all specialization constants with regular constants, applying the provided specialization constants where applicable. OpSpecConstantOp instructions are also evaluated in this pass, which was by far the most complex part of this PR, and also the most likely to have bugs I missed.

Good point, I had missed that the issue was with Vulkano-shaders specifically. Should we just close it as wontfix then?


Add cloudflare.secretRef for custom secrets

This will remove the need to create a secret if the user decides to
bring their own secret.
Resolves #56

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (95c265e) 26.20% compared to head (6bb1c78) 28.35%.
Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   26.20%   28.35%   +2.14%
==========================================
  Files           9        4       -5
  Lines         622      261     -361
==========================================
- Hits          163       74      -89
+ Misses        449      187     -262
+ Partials       10        0      -10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Relax dependencies version requirements

Allow puppetlabs-stdlib 9.x

you might want to amend the commit/pr to reflect that you want to allow concat 9.x instead of stdlib 9.x :)

you might want to amend the commit/pr to reflect that you want to allow concat 9.x instead of stdlib 9.x :)

:facepalm: Dang!
Fixed, thanks!


Suggestion: Execute task if (not when) files changed

Watch changes like in https://github.com/sagiegurari/cargo-make/issues/13, but execution should happen when cargo-make is manually invoked.

this is implemented by the commands themselves for example

rustc will not recompile if no file was changed.
cargo watch is given the files/dirs to watch for changes.

Currently this type of monitoring is not even possible in cargo-make which is not aware of what files are being impacted by the task, so this out will have to stay out of scope.

Sorry, misunderstood the role of watch task!


Fix a typo in the Next Steps section

@sjkwak : Thanks for your contribution! The author, @ShubhaVijayasarathy, has been notified to review your proposed change.

Verified the update.
@sjkwak Thanks!


Remove undefined object

TODO after https://github.com/strawberry-graphql/strawberry/pull/803

This has been implemented elsewhere, right?

Yes, the diff is messed up too :D closing!


Incompatible with jsonschema 4.10.0

https://pypi.org/project/jsonschema/#history
They have created their own evolve  method instead of using the attrs.evolve and that breaks a lot.
https://github.com/python-jsonschema/jsonschema/blob/ae0feea5e5e8c1a80efb1f17a20b15295355518a/jsonschema/validators.py#L204-L216
I have also created an issue on their end: https://github.com/python-jsonschema/jsonschema/issues/982

OAS31 will be fixed but for OAS30 check the issue #48

I believe since 4.10.2 it works again even for OAS30, due to changes on jsonschema's end (https://github.com/python-jsonschema/jsonschema/commit/a8c3b140a0134aa8c07fd7720d4e40f1bf759545).
But, as you said, it is still a technically unsupported thing.

thanks for your work on this


Fixing problem related with categories and changes over schema

Fixes #9540.
CR: @javisantana

Closing!


Error on Android 2.3.6

This reports whenever I log an exception. Lots of frames have passed before this is called and Bugsnag object is in the scene, enabled etc.
I don't get this error on other devices with a newer android os.
AndroidJavaException: java.lang.IllegalStateException: You must call Bugsnag.init before any other Bugsnag methods
at UnityEngine.AndroidJNISafe.CheckException () [0x00000] in :0
UnityEngine.AndroidJNISafe.CallStaticVoidMethod (IntPtr clazz, IntPtr methodID, UnityEngine.jvalue[] args) [0x00000] in :0
UnityEngine.AndroidJavaObject._CallStatic (System.String methodName, System.Object[] args) [0x00000] in :0
UnityEngine.AndroidJavaObject.CallStatic (System.String methodName, System.Object[] args) [0x00000] in :0
Bugsnag+NativeBugsnag.SetContext (System.String context) [0x00000] in /Assets/Standard Assets/Bugsnag.cs:138
Bugsnag.set_Context (System.String value) [0x0000d] in /Assets/Standard Assets/Bugsnag.cs:218

Closing as we now support API 14+


Updated I and K

Also exchanged the existing description between I and K and removed "your" after "diversify" in the knowledge so that it's only three lines like the others.

@SuzyQuant - talk to Sana about updating the word "The SILK Diet" to reflect better copy.


Add non-threaded executor implementation

This pull request adds support for supplying a custom executor implementation. Specifically it allows you to use a non-threaded version where all of the logic lives in the main thread. To do this I exposed an executor_cls parameter on TransferManager.__init__().
I also needed to update our testing scripts to test the functionality of this implementation by reusing the functional and integration tests. Here are some important decisions I made in doing this where feedback would be good:

The non-threaded version of the tests can be ran by setting the environment variable USE_SERIAL_IMPLEMENTATION.
In ci/ scripts I decided not to run any of the plugins like xunit or coverage because I do not want that run to clobber any of the xml files that we get back when running the normal implementation.
I skipped tests where it is was relying on the main thread not being blocked by the transfer happening in the main thread such as FIFO tests and the Cntrl-C tests. In the end, I was really trying to avoid modifying any of these existing tests, but for the Cntrl-C tests there is not really a great way to inject the Cntrl-C into the process without spinning up an entirely new process. So I was not really sure what to do about that. Suggestions would be great. I also tried signalling an alarm with a KeyboardInterrupt, but that is a bit dangerous as if it got raised at an inappropriate location it would exit out of the tests completely. For what it is worth, I did manual testing and I was able to Cntrl-C very quickly.

In the end, the hope is to use this executor implementation to fix: https://github.com/boto/boto3/issues/814. I did a quick test with the script provided in the issue and it now successfully downloads the object (i.e. no more hanging) so that is good.
cc @jamesls @JordonPhillips

@jamesls I updated based on feedback. Should be good to look at again.

Made the changes. Added a changelog entry and test pass. Merging.


Silence import warning

Codecov Report

Merging #158 (80bf111) into master (33307cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #158   +/-   ##
=======================================
  Coverage   82.71%   82.71%
=======================================
  Files           9        9
  Lines         833      833
=======================================
  Hits          689      689
  Misses        144      144

Impacted Files
Coverage Δ

dash_extensions/enrich.py
81.09% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33307cd...80bf111. Read the comment docs.


Add a min height to the intro video

Purpose

The purpose of this PR is to fix #616
Goals

Add a min-height to the intro video

Approach

Screenshots

Add a min-height to the intro video


Limit match durations on Regular Expressions

When using System.Text.RegularExpressions to process untrusted input, pass a timeout. A malicious user can provide input to RegularExpressions causing a Denial-of-Service attack. ASP.NET Core framework APIs that use RegularExpressions pass a timeout. Regex-es used in Qowaiv, should have a (strict) limitation on the computation time allowed.

Looks ok

I'm a bit in doubt what the best threshold should be. 1 ms feels save. But more strict might be better?!

You could maybe make it configurable

You could maybe make it configurable

That would introduce a lot of complexity, while by design, these Regexes are all limited. The most complex one (email adress) has been refactored out, because it was a security risk.


training train.py error

$ python train.py --data_dir=data
Using default logdir: ./logdir/train/2018-01-12T15-57-55
Traceback (most recent call last):
File "train.py", line 245, in
main()
File "train.py", line 190, in main
loss = net.loss(text_batch, args.l2_regularization_strength)
File "/home/nis-centos/tensorflow-tex-wavenet/wavenet/model.py", line 452, in loss
tf.reshape(shifted, [-1, self.quantization_channels]))
File "/home/nis-centos/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1558, in softmax_cross_entropy_with_logits
labels, logits)
File "/home/nis-centos/anaconda2/envs/tensorflow/lib/python2.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1512, in _ensure_xent_args
"named arguments (labels=..., logits=..., ...)" % name)
ValueError: Only call softmax_cross_entropy_with_logits with named arguments (labels=..., logits=..., ...)
How to solve it ,thank you ?

same


says "You have a host migration scheduled for this Linode!" but I don't have one scheduled

Hi Collin, thanks for bringing the lack of detail in this messaging to our attention.
You should see some more detail about this migration if you view the page for this Linode in the classic manager. Let me know if you have any further questions upon doing so.

Linode classic doesn't show anything about a migration. (The issue is it's saying I have migration scheduled when I don't have one scheduled.)

I see what you mean. If you have a chance, please email<EMAIL_ADDRESS>and link to this issue so that we can look into what may be triggering this notification in your specific instance.
Thanks again for bringing this to our attention.

Ok, just emailed. Feel free to close this issue. Thanks!


More flexible date board options

I would love for card board to be able to parse correctly tasks in the "Tasks" plugin format.
For example, I would like to be able to create a board for all the days of the week

unscheduled
overdue
Monday
Tuesday
Wednesday
Thursday
Friday
Future
Completed

Originally posted by @Rhydderch in https://github.com/roovo/obsidian-card-board/issues/77#issuecomment-1048665485

It would also be nice to have the possibility of the current setup, but with Overdue in it's own column that could be turned off similarly to how Undated is.

see https://github.com/roovo/obsidian-card-board/issues/105#issuecomment-1318541666 from @juestchaos....
Maybe in terms of time dimension, I hope to increase the corresponding column, such as the current week, the current month, and the current quarter.

Just a small update as implementation for this will still be a while out....
....but the work I have just been doing on how boards are set up internally has been done with the idea of supporting more flexible date boards in mind so this will be much easier to implement now :)

additionally support for the scheduled date from the task plugin would be nice, this would allow for 'weekplanning'

Hi @wimlep -> thank you -> this is definitely under consideration - see #94 to track thoughts I have on this and for any progress as and when it happens :)
Many thanks again

I'd like to add my 2 cents and propose to use the Start date from the Tasks plugin to hide tasks from the board. I at least use the Start date as a kind of "don't bother me until then" marker.

I'd like to add my 2 cents and propose to use the Start date from the Tasks plugin to hide tasks from the board. I at least use the Start date as a kind of "don't bother me until then" marker.

I'd like to sort tasks into columns based on the start date, rather than the due date. It's annoying that the tasks would only leave 'Future' once it is due soon.

This issue is going to be focussed purely on providing more flexibility in specifying columns for date boards using the current date implementation - so due date only.
@DerNamenlose, @sirsleon, @wimlep -> I will track progress/comments on use of other date types (such as start, scheduled etc) in #94.

closing this issue as the latest release (0.7.5) allows for the creation of custom date based columns using relative dates.  I've hopefully linked to other issues raised here that are not directly a part of this fucntionality!


Upgrade upickle to 0.8.0

Also upgrades .travis.yml to use jdk9 since 8 is now out of service.

As long as the lib supports Java 8, I think it makes more sense to run the tests on that version.

@pauldijou the problem is not the upickle library, but travis. since travis has removed jdk 8 and only jdk >= 9 are available on it.

I see. Still, could you remove it from the PR? Doesn't matter if it fails on Travis, I will fix it on another PR (either using Trusty distribution or using openjdk8, I want to try to keep testing on Java 8). Thanks for raising the concern, I wasn't really checking all those failures on Travis...

@pauldijou Done! :)

Thanks. I will release this Sunday. Ping me if I forget :-)

Released in 4.2.0


5.2.0 is messed up - missing dependencies, missing files

After installing<EMAIL_ADDRESS>as a dependency with npm and requiring it in my code:

Dependency "swig" is missing (so I installed it manually)
Dependency "js-beautify" is missing (I installed it manually)
The attempt to open file "./templates/api-endpoint.js" fails

That's as far as I went, then reverted to 5.1.0 which works just fine.

Also for me is the same!

+1, I'm experiencing the same issue.

the same!

the same! Heloooooo

Yeah, it's broken. But why? Who did miss the fact that 2 dependencies are missing and 1 is just not there?

dolboyobi iz googla

+1, can confirm

Fix is in the works.