Histogram incompletely pulled by federation request

What did you do?
Set up two prometheus instances A and B, B federates metrics from A.  Have an exporter of a histogram metric be scraped by A.  Graph that metric on B using histogram_quantile.
What did you expect to see?
A valid representation of the application behaviour being tracked by the metric.
What did you see instead? Under which circumstances?
Some points on the graph were very high: most points were <0.5s, but a handful were at 25s (the biggest non-+Inf bucket).  When I ran the same query on A, those 25s points weren't present.  Digging in on the consoles for A and B I found that at the time of one of the 25s blips, asking for a range vector on the bucket yielded a different number of samples for the +Inf bucket than all the others.
  In fact, there are two levels of federation; server A is itself pulling metrics from other Prometheus instances, one of which was the one that collected the histogram from a Java process.  Ultimately my concern is that the histogram was incomplete: I would expect that if a Prometheus instance contains a histogram sample at time T, when another Prometheus instance does a federation request, it would get the entire histogram sample set for time T, rather than just some of the buckets.
Server A (Prometheus runs on port 9191):
global:
  scrape_interval: 30s

scrape_configs:
  - job_name: 'prometheus'
    static_configs:
      - targets: ['localhost:9191']

  - job_name: 'federate'
    honor_labels: false
    metrics_path: '/federate'

    params:
      'match[]':
        - '{job="prometheus"}'
        - '{__name__=~"(jvm|process).+"}'
        - 'ims_hessian_request_duration_seconds_bucket'
        - 'ims_hessian_request_duration_seconds_count'
        - 'ims_hessian_request_duration_seconds_sum'
        # etc...

    static_configs:
      - targets:
        - 'server1:9090'
        # etc...

Server B (Prometheus runs on port 9292):
global:
  scrape_interval: 30s

scrape_configs:
  - job_name: 'prometheus'
    static_configs:
        - targets: ['localhost:9292']

  - job_name: 'federate'
    metrics_path: '/federate'
    honor_labels: true
    params:
      'match[]':
        - '{__name__=~".+"}'
    static_configs:
        - targets: ['serverA:9191', ]
          labels:
            'client': 'A'

Logs:

I found nothing other than the usual Checkpoint logs.

This is a race condition in the scraping, and part of why pulling all data from one Prometheus to another (or trying to emulate push with the pushgateway) is a bad idea as artifacts like this are to be expected. It's nothing to do with histograms per-se.
Federation is intended for moving around aggregated stats, if you use it that way then this is far less likely to come up.

@brian-brazil For my understanding of how this can happen that one bucket got all timestamps transferred, while another one was missing two, is it that the series for those buckets got new samples in the middle of a federation scrape and thus part of the histogram was already exported at the new timestamp, so from the view of the pulling Prometheus, some timestamps were skipped?

Yes, I believe that's what happened. There's a chance that mostly-atomic scrapes may be possible after #398, but that's in no way certain.

Yeah, no current way to fix this without blocking incoming samples during federation scrapes, which is not feasible. I guess we'll have to close this unfortunately and live with the occasional blips. Sorry!

If it were an occasional blip I wouldn't worry, but it's happening constantly at one site I'm looking at.  I guess it's because the sample collection frequency is the same as the federation frequency and they're perfectly lined up to race.  Perhaps I should experiment with choosing frequencies for each end that are less likely to align (like relatively prime numbers.)

This is a race condition in the scraping, and part of why pulling all data from one Prometheus to another (or trying to emulate push with the pushgateway) is a bad idea as artifacts like this are to be expected.

Maybe https://prometheus.io/docs/operating/federation/ should be updated to document this?

It's nothing to do with histograms per-se.

That may be so, but from my point of view it's only particularly problematic in their case.  The service I'm monitoring is behaving wonderfully, serving all requests in <0.5s, but from looking at Prometheus metrics it looks like it's serving up several 25s requests per minute.  This makes it effectively useless for monitoring service times for us unless we can find a workaround, because it's full of false alarms.

Federation is intended for moving around aggregated stats, if you use it that way then this is far less likely to come up.

Can you elaborate?  I don't really see how aggregation would reduce the likelihood, unless the aggregation eliminates histograms.

Yeah, no current way to fix this without blocking incoming samples during federation scrapes, which is not feasible.

I haven't looked at the code so forgive my ignorance.  Since I believe the pain this problem causes is mostly related to histograms, could we target a fix in that vein?  For example, return to a federate request all of the samples from the metrics that make up a histogram or none of them?

Maybe https://prometheus.io/docs/operating/federation/ should be updated to document this?

It already talks about aggregation.

Can you elaborate? I don't really see how aggregation would reduce the likelihood, unless the aggregation eliminates histograms.

The idea is to push down the calculation as far down the stack of Prometheus servers as you can. Doing rates based on federated data is not a good idea, and I'd avoid using graphs based on federated data unless there was no other choice (e.g. global aggregations) preferring instead to go to the Prometheus that has the raw data.

I haven't looked at the code so forgive my ignorance. Since I believe the pain this problem causes is mostly related to histograms, could we target a fix in that vein?

This is not related to histograms, that's just where you noticed it.

For example, return to a federate request all of the samples from the metrics that make up a histogram or none of them?

The data model Prometheus uses internally has no notion of the existence of histograms, they're just a convention.

This is a race condition in the scraping, and part of why pulling all data from one Prometheus to another (or trying to emulate push with the pushgateway) is a bad idea as artifacts like this are to be expected.

Maybe https://prometheus.io/docs/operating/federation/ should be updated to document this?

Good idea. I filed https://github.com/prometheus/docs/issues/514.

It's nothing to do with histograms per-se.

That may be so, but from my point of view it's only particularly problematic in their case.

You can run into similar problems with other metric types. For example:
irate(errors[1m] / irate(total[1m]))
If the error counter is a scrape interval ahead of the total, it could get even larger than the total, giving you error ratios larger than 1. In any case, the ratio will be wrong.

Federation is intended for moving around aggregated stats, if you use it that way then this is far less likely to come up.

Can you elaborate? I don't really see how aggregation would reduce the likelihood, unless the aggregation eliminates histograms.

At least if you pre-aggregate multiple metrics into a single one and then only federate that, there is no room for having two divergent metrics that you are working with. This inconsistency you are seeing can only happen when you try to compute a result based on metrics from the same target, but from different scrapes of that same target, as then numbers which should always be (at least roughly) consistent with each other (histogram bucket counters, errors/totals, etc.) aren't.

For example, return to a federate request all of the samples from the metrics that make up a histogram or none of them?

As @brian-brazil said, the storage that spews out the federated metrics actually has no notion of what a histogram is anymore - it's just a bunch of time series that happens to have the le label (which the histogram_quantile() interprets in a certain way).

Ok, I guess we'll have to push the calculations down the stack as you say.   Thanks for taking the time to explain the details.
It's a shame because it makes it considerably less flexible for us - dashboard authors won't be able to e.g. implement a different percentile option on the fly, they'll have to make a change request and wait for it to be deployed.  Sadly firewall and upstream provisioning issues make it impractical for us to eliminate the federation altogether, though I may try to eliminate one of the levels of federation based on what I've learned today.

Perhaps this is solvable. I'll add my idea to https://github.com/prometheus/docs/issues/514 . If it is feasible, we can open a new issue here in the Prometheus repo.

One way to mitigate this might be to have histogram_quantile use the value from the previous bucket if the value in the current bucket is decreasing.


Added Command gg to go to top of file and G to go to end of file.

I think this should be pretty easy to add.

Addded with push ff102d7eb4ba9a2b892eff9418b5a198d02ad9bc


Audio works, no video

Castnow plays audio just fine from my arch box, but I cannot play video.
I have tried with two files, an .avi and an .mp4
The .avi just refuses to work.
The .mp4 plays the audio of the video, but the screen is filled with one unmoving image from one of the first frames.
Debug options do not show any errors or anything of that sort.
Also, the --tomp4 option returns the following error:
/usr/lib/node_modules/castnow/index.js:127
if (!status.media ||
^
TypeError: Cannot read property 'media' of undefined

I'm having this same issue on arch linux. Not having a problem with mp4 files, and I wouldn't expect avi files to work as-is, but "--tomp4 file.avi" does cause a crash like this:
/usr/lib/node_modules/castnow/index.js:127
      if (!status.media ||
                 ^
TypeError: Cannot read property 'media' of undefined
    at /usr/lib/node_modules/castnow/index.js:127:18
    at /usr/lib/node_modules/castnow/node_modules/chromecast-player/api.js:69:7
    at RequestResponseController.onmessage (/usr/lib/node_modules/castnow/node_modules/castv2-client/lib/controllers/request-response.js:27:7)
    at RequestResponseController.emit (events.js:129:20)
    at Channel.onmessage (/usr/lib/node_modules/castnow/node_modules/castv2-client/lib/controllers/controller.js:16:10)
    at Channel.emit (events.js:110:17)
    at Client.onmessage (/usr/lib/node_modules/castnow/node_modules/castv2-client/node_modules/castv2/lib/channel.js:23:10)
    at Client.emit (events.js:129:20)
    at PacketStreamWrapper.onpacket (/usr/lib/node_modules/castnow/node_modules/castv2-client/node_modules/castv2/lib/client.js:79:10)
    at PacketStreamWrapper.emit (events.js:107:17)

Never mind, this crash was fixed by f557076e569ce36c5808eac4e46abd723af7b780 and I had to switch from the old AUR package "castnow" to the newer "castnow-git"

:+1:


Quickstart example throws warnings

The quickstart example throws some warnings:
WARNING:tensorflow:From /path/to/stable-baselines/stable_baselines/common/policies.py:436: flatten (from tensorflow.python.layers.core) is deprecated and will be removed in a future version.
Instructions for updating:
Use keras.layers.flatten instead.
WARNING:tensorflow:From /usr/lib/python3.7/site-packages/tensorflow/python/framework/op_def_library.py:263: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version.
Instructions for updating:
Colocations handled automatically by placer.
WARNING:tensorflow:From /usr/lib/python3.7/site-packages/tensorflow/python/ops/math_ops.py:3066: to_int32 (from tensorflow.python.ops.math_ops) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.cast instead.
WARNING:tensorflow:From /usr/lib/python3.7/site-packages/tensorflow/python/ops/math_grad.py:102: div (from tensorflow.python.ops.math_ops) is deprecated and will be removed in a future version.

Here is the information collected by tf_env_collect.sh that seems relevant:
== uname -a =====================================================
Linux thamiel 4.19.34-1-MANJARO #1 SMP PREEMPT Sat Apr 6 08:28:55 UTC 2019 x86_64 GNU/Linux

== check pips ===================================================
numpy                             1.16.2
protobuf                          3.7.0
tensorflow                        1.13.1
tensorflow-estimator              1.13.0
tensorflow-serving-api            1.13.0
tensorflow-serving-api-gpu        1.13.0

Also:
$ python --version
Python 3.7.3

Hello,
Thanks for pointing out deprecation warnings, some of them seem easy to solve (cast, divide), for others, we need to be careful or to upgrade the minimum tf version.
And for this one WARNING:tensorflow:From /usr/lib/python3.7/site-packages/tensorflow/python/framework/op_def_library.py:263: colocate_with (from tensorflow.python.framework.ops) is deprecated and will be removed in a future version. Instructions for updating: I don't where it does come from...

Looking at the warnings again, they may come from tensorflow itself... see https://github.com/tensorflow/tensorflow/issues/25996
so there is no way of fixing them from stable-baselines repo.

Will be closed by #366

as we are moving to PyTorch, this will probably not be fixed.
However, to remove the warnings, one can do:
# Filter tensorflow version warnings
import os
# https://stackoverflow.com/questions/40426502/is-there-a-way-to-suppress-the-messages-tensorflow-prints/40426709
os.environ['TF_CPP_MIN_LOG_LEVEL'] = '3'  # or any {'0', '1', '2'}
import warnings
# https://stackoverflow.com/questions/15777951/how-to-suppress-pandas-future-warning
warnings.simplefilter(action='ignore', category=FutureWarning)
warnings.simplefilter(action='ignore', category=Warning)
import tensorflow as tf
tf.get_logger().setLevel('INFO')
tf.autograph.set_verbosity(0)
import logging
tf.get_logger().setLevel(logging.ERROR)

For removing the Tensorflow's deprecation warnings it's possible to use the following code too:
import tensorflow as tf
tf.compat.v1.logging.set_verbosity(tf.compat.v1.logging.ERROR)

(Source: https://github.com/tensorflow/tensorflow/issues/27023#issuecomment-523710266 )


lib: Upgrade relay to 10

This was a fun one 😓
Learnings:

Relay test auto fixtures no longer auto-fixture booleans. Had to update a lot of tests
Sometime one needs to add the @relay_test_operation directive to the query in the test. I'm not sure exactly when.

When attempting to migrate the AboveTheFoldQueryRenderer over from Eigen I noticed that we were behind a version in relay, blocking the implementation. This upgrades things so that we can proceed.
Note: This upgrade reminded me that when performing relay upgrades there's often changes to how relay-typescript-compiler outputs types, requiring us to manually update many of our old-school fixtures in order to get type-checking to pass. This wouldn't be a problem if we were using modern testing practices that dynamically generate fixture data. The most critical of these is Apps/Order, which we should make an effort to update.

Nice -- I'm going to try isolating a component that has nothing but that isClosed aliased field and see if the payload generated for that contains the dupes.

This madness is 🍏 , gonna merge

Epic work @damassi 💪 🎉 🕺


iOS push notification says "New message" only since 27th of March

:lady_beetle: Describe the bug
My self-hosted instance was running fine for some time, but on Thu I updated 2.9.0 to 2.10.0. Since about then ALL push notifications only show "New message" instead of the actual content.
:computer: Components impacted
Updated to Ntfy 2.10.0 but reverted back to 2.9.0 and issue persists. Ntfy running in Docker behind Traefik.
iPhone is 14 Pro iOS 17.4. Ntfy App v1.3.
:bulb: Screenshots and/or logs

:crystal_ball: Additional context
"upstream-base-url" and "base-url" are set correctly according to https://ntfy.sh/docs/config/#ios-instant-notifications . This whole thingy was working up to 2024-03-27. Also I've checked and I can reach my self-hosted ntfy just fine from my phone (wifi and mobile network).

Hm... updated iOS to 17.4.1 and it's working again... still no clue why, but I guess this can be closed.

I am using self-hosted version 2.10.0 and i have the same problem on my iOS 17.4.1 device. Any clue what to do here to get it working again?

Everything has been fine again since this weekend. But I don't know why, because I haven't changed anything. The usual steps like container restart etc had no immediate effect. Sorry I couldn't be more helpful in finding the problem.

Same here! No content on notifications.

Can repro. It works sometimes for me on some channels for a few days before all channels begin failing. It would really help if we had access to the logs but I can't see a way to get to them.

I can confirm I am having the same issue. Maybe it is related to iOS update to 18?

I ran iOS 18 from the moment the first dev beta was available to RC1 and today. I was able to get notification content during most of that period, this issue only began around two to three weeks ago.

I just removed the app completely from my iPhone and reinstalled it. That solved the problem for me!

Overnight this morning the issue just suddenly disappeared and I now have message content again.


Add browserify gulp task

Compile all the client js with babel and browserify

When we remove the task  build also remove the browserify task!!

fixed in #50


[2|Profile Setting Page] CUD profile information

 🍰 Appetite 🍰

Property
Value

Points
10 points

Difficulty rating
★★☆☆☆

Maximum Assignees
2 person

🤔 Problem Statement

Enable photo change feature. Enable photo preview before submit.
🧪 Required Tests
Mainly screenshot tests, some integrations tests for Payload CMS.
Review the Code & Testing Guidelines for more info.
⚠ Careful about:
No major rabbit holes identified. But always be careful with scope creep!
🤖 Technologies focused on in this feature

React
Tailwind
Shadcn
NextJS
Supabase/PostGresQL

I want to work on this feature!

I'd like to work on this.

@MandeepPaul I like your enthusiasm! This issue is currently locked until others are competed but once it opens up we can add you. :)

I'd like to work on this

@JChuy0 can you come see me please?

@ash0359 has been added as a HELPER.

I can help with this

@saiforceone

Removing @JChuy0 as he is no longer available.

Just working on it!


ConfigurationWatcher Should Allow Adding Keys To Watch

@KrzysztofCwalina commented on Fri Jan 18 2019
ConfigurationWatcher should sllow sdding keys to watch while it's running. Same with stopping to watch.

Configuration watcher is not shipping.


Update hololens-rs4-preview.md

Removed the first two release notes related to RS1 to RS4 upgrade because it currently requires a clean flash to test out the build.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/hololens-rs4-preview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Already fixed.


Implement TextInput.selectTextOnFocus for Android

Uses native Android TextView.setSelectAllOnFocus method. Triggers TextInput's onSelectionChanged event on focus as expected.

Lgtm. Mind getting this up-to-date + check tests pass?

Updated the branch, but I still get failed ObjC tests, not sure what to do now:)

Tests look good now! :) Thanks for implementing this.
@facebook-github-bot shipit


Rl tigerbeetle helm chart

Changes proposed in this pull request
Adds a chart for deploying tigerbeetle tto kubernetes via helm.
Context

Checklist

[ ] Related issues linked using fixes #number
[ ] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass

Now that this uses the resolver directive, nginx will be able to run even if some of the replicas are not assigned hostnames, making this a more robust solution than I previously thought.


'Source' class: modification of the visible of private field and method.

Checklist

[x] npm test passes
[x] commit message follows commit guidelines

Description of change
Change the 'private' keyword to 'protected' keyword. Preserve the limited scope of fields and methods of this class. It gives the possibility to derive this class and customise its behavior in client source code.

Previous ci job failures
I just try to rebase onto the current master branch, just to check if the errors are reproducible.

the error because for  l7  ie compatibility ,import  supercluster  by   import "'supercluster/dist/supercluster  ,  lead to ts error

the error because for l7 ie compatibility ,import supercluster by import "'supercluster/dist/supercluster , lead to ts error

Thank you for the highlight but I don't know well enough the l7 history and development to fix this issue from the lint job. What can I do about that?
I want kown,What function do you need to expand the source

I'm really interested by these modifications:
protected originData: any;
protected rawData: any;

And if I can have access to all private method (so protected) in my derived class, I would be really happy 😃

ok , next version i will this properties to protected

new version already supports


[all-clusters-app] added support for nrfconnect

Change overview
There was a request to port the all-clusters-app to the nrfconnect platform for testing purposes. All clusters are populated with default values.
Initially required device types:

the root device
base device,
light-bulb,
dimmable-light,
door lock,
contact sensor,

Testing

Tested manually with chip-tool running on the PC and nrf52840dk
Attached a server-list and a client list for all endpoints: descriptor_read.txt

Memory consumption (default unstripped west build):

nrf52840dk_nrf52840

FLASH: 863140 B (82.32%)
SRAM: 208923 B (79.70%)

nrf5340dk_nrf5340_cpuapp

FLASH: 771604 B (74.17%)
SRAM: 206822 B  (45.08%)

The OTA DFU support causes the following memory consumption increase:

nrf52840dk_nrf52840: 92.89% FLASH and 80.43% SRAM
nrf5340dk_nrf5340_cpuapp: 87.78% FLASH and 46.433% SRAM

For the record - after introducing bootloader size optimizations from @ArekBalysNordic the overall memory footprint is:

nrf52840dk_nrf52840: 90.96% FLASH and 80.43% SRAM
nrf5340dk_nrf5340_cpuapp: 83.34% FLASH and 46.433% SRAM


[Dev] Separate deploy runs from CI runs

Separates the Danger/Build/Lint runs from the deployment runs. I think they're also running when they shouldn't - so I took another stab at making them only run at the right place
#trivial

OK, this is good to go on green

Gonna merge so I can check pushes the master commits bit

👍


Introduce build subcommand and make documenting a subcommand, too

rruxwry build is not fleshed out yet (doesn't have "base feature parity" with rruxwry doc) and the README isn't fully updated.
However, let's merge this already. I don't this now already!


Update stable version in repo from 1.5.0 to 1.6.0

Think about update stable version to 1.6.0
Version: stable=1.5.0 (182 days old) => latest=1.6.0 (15 days old)
Installs: stable=887 (68.81%), latest=184 (14.27%), total=1289
Click to edit

Done


Filter Csv for GoodsReceipt

Filter Csv Record If...

There is a duplicate record
If fields cannot be parsed properly
if number of fields does not match

Resolved with #88


Tuya curtain switch not flashing

Before opening a new issue, please read the following
Are you reporting a successful flash?
no
Do you have a question about configuring your newly flashed device?
no
Did you have issues getting a device to flash?
Please be sure to include your device name, model, and firmware version as well as your logs!
There are no logs in the /scripts folder. Do I have to start the flash with additional parameters?
Device is (Printend on PCB) SC400W-EU-V2-Key   D-MFB190611. There is a TYWE3S soldered on.
I used tuya-convert a few weeks ago on 8 wallplugs which worked fine. So I assume that the environment (an Ubuntu Laptop) should be able to do the job. I pulled the latest code from github and runned the install_prereq.sh. Then I executed the start_flash.sh. I joined the vtrust WLAN with my iPhone and gave mains to the Tuya Device. One button shines solid. Then I long press the middle button until the LED starts flashing fast. Then I pressed return on the console to run flashing. After I see "Sending Secret" in the log the Device stops LED flashing to LED off.
In the log now is shown "SmartConfig complete" and "Resending SmartConfig Packets" a few times. After a while in log "Device did not appear....."
What I'm doing wrong? How can I help with logs
Please remember to close your issue when the problem has been addressed!

Found a log "screenlog.0". I've shortened it because it contains "SSLError('No cipher can be selected.',)" hundreds of times.
Starting DNSMASQ server... Starting AP on wlan0... Configuration file: /dev/stdin Using interface wlan0 with hwaddr 00:21:85:bd:05:04 and ssid "vtrust-flash" wlan0: interface state UNINITIALIZED->ENABLED wlan0: AP-ENABLED  Listening on <IP_ADDRESS>:80<PHONE_NUMBER>: mosquitto version 1.6.7 starting<PHONE_NUMBER>: Using default config.<PHONE_NUMBER>: Opening ipv4 listen socket on port 1883.<PHONE_NUMBER>: Opening ipv6 listen socket on port 1883. Listening for Tuya broadcast on UDP 6666 Listening for encrypted Tuya broadcast on UDP 6667 wlan0: AP-STA-CONNECTED 44:00:10:55:5a:2d [I 191127 10:45:47 web:2246] 302 GET /hotspot-detect.html (<IP_ADDRESS>) 5.58ms [I 191127 10:45:47 web:2246] 200 GET / (<IP_ADDRESS>) 6.57ms [I 191127 10:45:48 web:2246] 302 GET /hotspot-detect.html (<IP_ADDRESS>) 3.78ms [I 191127 10:45:48 web:2246] 200 GET / (<IP_ADDRESS>) 3.85ms [I 191127 10:45:48 web:2246] 302 GET /hotspot-detect.html (<IP_ADDRESS>) 4.05ms [I 191127 10:45:48 web:2246] 200 GET / (<IP_ADDRESS>) 4.60ms wlan0: AP-STA-CONNECTED d8:bf:c0:54:50:99 new client on port 443 from <IP_ADDRESS>:20526 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) new client on port 443 from <IP_ADDRESS>:11473 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) new client on port 443 from <IP_ADDRESS>:5550 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) new client on port 443 from <IP_ADDRESS>:21226 . . . ************ 100 times the same ********************** . . new client on port 443 from <IP_ADDRESS>:61071 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) new client on port 443 from <IP_ADDRESS>:57322 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) new client on port 443 from <IP_ADDRESS>:57324 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) new client on port 443 from <IP_ADDRESS>:57326 ('could not establish sslpsk socket:', SSLError('No cipher can be selected.',)) wlan0: AP-STA-DISCONNECTED 44:00:10:55:5a:2d wlan0: AP-STA-CONNECTED 44:00:10:55:5a:2d [I 191127 13:28:13 web:2246] 302 GET /hotspot-detect.html (<IP_ADDRESS>) 5.51ms [I 191127 13:28:13 web:2246] 200 GET / (<IP_ADDRESS>) 4.43ms wlan0: AP-STA-DISCONNECTED 44:00:10:55:5a:2d wlan0: AP-STA-CONNECTED 44:00:10:55:5a:2d [I 191127 13:34:27 web:2246] 302 GET /hotspot-detect.html (<IP_ADDRESS>) 4.47ms [I 191127 13:34:27 web:2246] 200 GET / (<IP_ADDRESS>) 5.26ms wlan0: AP-STA-DISCONNECTED 44:00:10:55:5a:2d ^CTraceback (most recent call last):   File "./psk-frontend.py", line 111, in <module>     main()   File "./psk-frontend.py", line 104, in main     r,_,_ =  select.select(readables, [], []) KeyboardInterrupt ^C1574858220: mosquitto version 1.6.7 terminating ^CReceived SIGINT, exiting... ^Cwlan0: interface state ENABLED->DISABLED wlan0: AP-STA-DISCONNECTED d8:bf:c0:54:50:99 wlan0: AP-DISABLED  nl80211: deinit ifname=wlan0 disabled_11b_rates=0 AP closed Stopping DNSMASQ server... Restarting NetworkManager...

The logs might be in your backup folder, but this screen log is helpful.
Can you perform a network capture?
To do this, make sure you have tcpdump installed, then run start_flash.
Wait until you get to the "Press ENTER to continue" prompt, then (without pressing enter) switch to another terminal and run tcpdump -i wlan0 -w capture.pcap.
Then plug your device in without resetting it (do not put it back in pairing mode, it should already be paired). Wait for a minute to collect data, press Ctrl+C to stop recording, and upload the capture.pcap file.

What is your OpenSSL version?

Thanks for the fast response :)
What is your OpenSSL version?
openssl version -h
OpenSSL 1.0.2g 1 Mar 2016

The Dump is attached. I had to zip it to be accepted by git upload
capture.zip

I see a Client Hello but no Server Hello, indicating the problem indeed lies with OpenSSL. Is there a more recent version available for your distribution?

Well, I set up a raspi 3B with tuya-convert and all prereqisites. Then I run a full cycle following the readme. With iphone connected to vtrust WLAN. It behaves same as on the Ubuntu Laptop. But on the raspi I got logs. I also had a tcpdump in a 2nd console. I put all in a zip and attached it to this comment. Maybe it helps identifying the issue. To be honest, I'm a greenhorn on this network magic :)
pi@raspberrypi:/home $ python --version
Python 2.7.16
pi@raspberrypi:/home $ openssl version -v
OpenSSL 1.1.1d  10 Sep 2019
pi@raspberrypi:/home $ tcpdump --version
tcpdump version 4.9.3
libpcap version 1.8.1
OpenSSL 1.1.1d  10 Sep 2019
pi@raspberrypi:/home $

tuya-convert_logs.zip

The device never connected this time. Did you put the device in pairing mode?

 Havn't stopped the Laptop. So the devic may used this wifi instead of Raspi. So I stopped Laptop now and started Raspi unil "ENTER" Prompt. Then I powercycle the Device. Looking in the HTTP log say me that "things" are transmitted. I attached all logs in the zip again.
I did nothing further so far. So Raspi stays on ENTER Prompt and device is powerd witth mains. What are the next steps?
tuya-convert_logs.zip

Yes it looks like it took the intermediate firmware successfully! You should be able to continue now, just press ENTER.

AWESOME!!!! So, learned from this: the new hack seems to not run with openSSL 1.0. (Ubuntu 16) The old Tuya wallplugs I was able to flash with. Maybe it helps other people.
Many thanks for your help, much appreciated.
======================================================
Starting smart config pairing procedure
Waiting for the device to install the intermediate firmware

IoT-device is online with ip <IP_ADDRESS>
Stopping smart config
Fetching firmware backup
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 1024k  100 1024k    0     0  29704      0  0:00:35  0:00:35 --:--:-- 27850
curl: Saved to filename 'firmware-545099.bin'
======================================================
Getting Info from IoT-device
VTRUST-FLASH 1.5
(c) VTRUST GMBH https://www.vtrust.de/35c3/
READ FLASH: http://<IP_ADDRESS>/backup
ChipID: 545099
MAC: D8:BF:C0:54:50:99
BootVersion: 7
BootMode: normal
FlashMode: 1M QIO @ 40MHz
FlashChipId: 1540c8
FlashChipRealSize: 2048K
Active Userspace: user2 0x81000
======================================================
Ready to flash third party firmware!

For your convenience, the following firmware images are already included in this repository:
  Tasmota v<IP_ADDRESS> (wifiman)
  ESPurna 1.13.5 (base)

You can also provide your own image by placing it in the /files directory
Please ensure the firmware fits the device and includes the bootloader
MAXIMUM SIZE IS 512KB

Available options:
  0) return to stock
  1) flash espurna.bin
  2) flash tasmota.bin
  q) quit; do nothing
Please select 0-2: 2
Are you sure you want to flash tasmota.bin? This is the point of no return [y/N] y
Attempting to flash tasmota.bin, this may take a few seconds...
Flashed http://<IP_ADDRESS>/files/tasmota.bin successfully in 9896ms, rebooting...
Look for a tasmota-xxxx SSID to which you can connect and configure
Be sure to configure your device for proper function!

HAVE FUN!
======================================================
Do you want to flash another device? [y/N]

Just for Documentaion purposes 2 Pictures from Device.

The Device has no brand as it looks. It's sold as "Smart Curtain Switch" for 10-15€ on Aliexpress
On PCB is printed SC400W-EU-V2-Key D-MFB190611. There is a TYWE3S soldered on
Production date is end of Oct 2019 (see picture of the box)
Serial flashing fails for whatever reason. Maybe RX/TX are wired somehow, which avoids communication. Also cutting RX connection as described on some Webpages doesn't help.
The upper PCB can only detached by desoldering 6 pins which makes serial flashing hard anyway

@Waldmensch1 Hi - this may be a little off topic and I apologize for that but I'm new to this and really struggling.  I just got the same switch as you and I managed to flash tasmota (compiled with shutter).  However any and all configurations I try don't work - did you manage to get a working configuration going for this switch? Any help would be greatly appreciated.

@Waldmensch1 Hi - this may be a little off topic and I apologize for that but I'm new to this and really struggling. I just got the same switch as you and I managed to flash tasmota (compiled with shutter). However any and all configurations I try don't work - did you manage to get a working configuration going for this switch? Any help would be greatly appreciated.
EDIT
If anyone else stumbles upon this and comes across the same issue - this configuration ended up working for me: https://templates.blakadder.com/WF-CS01_EU.html

Hi were you able to flash with tuya-convert or did you flash serial? If Serial do you have a picture of the serial connections you made? I am am about to desolder the pcb and any info is appreciated.

@Waldmensch1 Hi - this may be a little off topic and I apologize for that but I'm new to this and really struggling. I just got the same switch as you and I managed to flash tasmota (compiled with shutter). However any and all configurations I try don't work - did you manage to get a working configuration going for this switch? Any help would be greatly appreciated.
EDIT
If anyone else stumbles upon this and comes across the same issue - this configuration ended up working for me: https://templates.blakadder.com/WF-CS01_EU.html

Hi were you able to flash with tuya-convert or did you flash serial? If Serial do you have a picture of the serial connections you made? I am am about to desolder the pcb and any info is appreciated.

Hi, I used tuya-convert, sorry. Also I should note that I ordered a second batch of these same switches and what came was not ESP-8266 based so I didn't flash those - loratap mentioned that they were switching over from esp to a different chip. Just an FYI

@Waldmensch1 Hi - this may be a little off topic and I apologize for that but I'm new to this and really struggling. I just got the same switch as you and I managed to flash tasmota (compiled with shutter). However any and all configurations I try don't work - did you manage to get a working configuration going for this switch? Any help would be greatly appreciated.
EDIT
If anyone else stumbles upon this and comes across the same issue - this configuration ended up working for me: https://templates.blakadder.com/WF-CS01_EU.html

Hi were you able to flash with tuya-convert or did you flash serial? If Serial do you have a picture of the serial connections you made? I am am about to desolder the pcb and any info is appreciated.

Hi, I used tuya-convert, sorry. Also I should note that I ordered a second batch of these same switches and what came was not ESP-8266 based so I didn't flash those - loratap mentioned that they were switching over from esp to a different chip. Just an FYI

Thanx. I am sure i have esp82xx based switch. Psk starts with 02. #483

I flashed my devices serial. If interrested i can send backups.

do you have backup firmware?


#3720. define reset kernel key cmd

with this test notebook: https://pub.beakernotebook.com/#/publications/56f05fac-0616-4724-bc98-234918a1051a
if i hit control-R i get this weird error:

also, bring up to date with master

kick jenkins

great, this is much better.  but still, if i try control-R on the charting tutorial, it seems every other time i get an error from one of the init cells.

and that reminds me, if one of the init cells does fail, the notebook should scroll to show it.
i think this happens during the normal init cell process.


Consider moving to six or future for Python 2/3 compatibility

Should we move to one of these libraries? I think so, as it would mean we could nearly eliminate the compat.py module, improving test coverage.
Which library? six, future, or something else?

We'll go with python-future!

PR #529 introduces future based on @michaeljoseph's work on #438


[Feature] Adding Google Translate Feature

Description
Adding Google Translate Feature
Motivation
I could see many other projects in gssoc-extd having this feature but our project lacks it. I have never tried this feature out, so want to learn the same. It's also essential that people get to know things from their language. Also, because of this quote

Screenshots
.
Additional Context
I'm a gssoc-extd and hacktoberfest contributor
Checklist

[X] I have checked the existing issues.
[X] I have read the Code Of Conduct.
[X] The changes don't break the code.
[X] I will attach screenshots and videos of the development work once it is done.

Priority
High

@GarimaSingh0109 Please assign me this issue!


New Read-only cache FPGA Feature Tutorial

Description
New tutorial that describes the usage of the read-only cache feature.
Checklist
Administrative

[ ] Review sample design with the appropriate Domain Expert:

Code Development

[x] Implement coding guidelines and ensure code quality. see wiki for details
[x] Adhere to readme template
[x] Enforce format via clang-format config file
[x] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
[x] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
[x] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

[ ] OSPDT Approval (see @JoeOster for assistance)
[ ] Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
[ ] Bandit Scans (Python only)
[ ] Virus scan

Review

[ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
[ ] Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)
[ ] Tested using Dev Cloud when applicable

@mdbtucker - Addressed all the comments :)

Closing this PR so it doesn't accidentally get merged to your local development branch.


Export command

Could be useful to have a command to generate all exports. This would be useful if creating or changing the sentinel file after existing notebooks already exist.

Closed by #30


Use on node < 8?

The way this is constructed, it can only be used on node v8+ since it is not transpiled and uses async/await. Are there any plans to transpile this module so we can use it on node < v8?

Node 8 is going LTS soon (probably October or so), so - right now - there's no point in transpiling the code. Please update your Node.js instance! 😊


Issue #321 solved improved code documentation

📋 Description
This PR adds comprehensive documentation to the home page HTML file, clarifying its structure and logic to enhance readability and maintainability. The documentation provides insights into the use of metadata, external resources, and EJS conditional rendering. No functional changes have been made to the code.
🔨 Changes Made
Metadata and Resources:
Explained the purpose of  tags, favicon, Google Fonts, and Font Awesome icons.
Conditional Rendering:
Documented how EJS logic dynamically displays login or logout links based on the user session.
Hero Section and SVG Icon:
Added comments to describe the hero section, branding elements, and SVG arrow icon.
JavaScript and Footer:
Clarified the role of the external JavaScript file for background changes and the purpose of the footer.

✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation (if applicable).
[ ] My changes generate no new warnings.
[ ] I have tested it locally and it works fine.
[ ] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[ ] Bug fix (non-breaking change which fixes an issue) 🐛
[ ] New feature (non-breaking change which adds functionality) ✨
[ ] UI enhancement (non-breaking change which enhances UI) 🎨
[x] Documentation update 📚

🤝 Related Issues

Fixes #321

📸 Screenshots (if applicable)

Reminder:
Please ensure your pull request is made to the test branch, not main.
Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

Thankyou for Contributing!


ZIG ZAG Traversal of Binary Search Tree [JAVA]

This issue is about [Algo/DS Name](link to resource for the Algo/DS).

[x] Issue Title is in form Algo/DS Name [Language].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

Kindly assign me this issue under contribute-a-thon'21

Hello, I hope you're all doing well! I'm a newcomer, and I think I have the required abilities to solve this issue. Could you please assign this to me.
It would be a pleasure to contribute to your project!


Modal prop not giving drawer expected behavior

Hello,
When I set the modal property on the Drawer's Root component to true, clicking outside of the drawer still causes it to close.
I believe the issue is in onPointerDownOutside prop of DialogPrimitive.Content in src/index.tsx, but I wasn't able to get the library to build on my machine, so haven't tested it.
Thanks

Fixed in #109. Also, if you want the drawer to not close when you click outside, you need to set the modal prop to false rather than true, true is the default. It's also described in the readme.


Fix763

Description
This patch reverts the breaking changes made to the core WebRTC API in https://github.com/pion/webrtc/pull/763/ and modifies the pion-to-pion-trickle example to work properly with the WebRTC API as specified in https://w3c.github.io/webrtc-pc/ and following the specification of trickle ICE in https://tools.ietf.org/html/draft-ietf-mmusic-trickle-ice-02

Codecov Report

Merging #816 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #816     +/-   ##
=========================================
- Coverage   76.21%   76.11%   -0.1%
=========================================
  Files          59       59
  Lines        4250     4246      -4
=========================================
- Hits         3239     3232      -7
- Misses        742      744      +2
- Partials      269      270      +1

Impacted Files
Coverage Δ

peerconnection.go
73.01% <0%> (-0.01%)
:arrow_down:

dtlstransport.go
68.02% <0%> (-3.49%)
:arrow_down:

sctptransport.go
76.87% <0%> (+1.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 444e0bc...5bceb01. Read the comment docs.

Hmm, looks like travis is not happy here. There might have been more dependencies on the reverted change for examples

Hmm, looks like travis is not happy here. There might have been more dependencies on the reverted change for examples

Nevermind, it's passing now. I think it was the formatting issue of the commit message that i fixed last commit :)

@cohosh merged!
I also added a test so this won't regress in the future https://github.com/pion/webrtc/commit/9fa65c214765c65c118b03079b8f81ff365d4d6e
Thank you so much for catching this. Sorry for the time lost debugging Pion :/ if you have anything that could have made this process easier I am all ears!

@cohosh merged!
I also added a test so this won't regress in the future 9fa65c2

Thank you so much! I am not sure of what your other use cases are, but there might in the future be call for a unit test that is a bit more nuanced. Here's what the RFC referenced by the w3c draft states: https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.9

Thank you so much for catching this. Sorry for the time lost debugging Pion :/ if you have anything that could have made this process easier I am all ears!

Thank you for taking a look at this so quickly, I'm really grateful for your understanding and feedback. Your responses have helped us a lot in integrating this library and evaluating it :) I'll be more cognizant of major/minor version upgrades in the future as well. Time spent assessing changes is not unusual for performing version updates of libraries.
Out of curiosity, do you have changelogs or summaries of changes for minor version bumps?

Thank you so much! I am not sure of what your other use cases are, but there might in the future be call for a unit test that is a bit more nuanced. Here's what the RFC referenced by the w3c draft states: https://tools.ietf.org/html/draft-ietf-rtcweb-jsep-25#section-5.9

👍 for that. Lately I have been doing a lot of breadth, but not much depth. I am actually not super familiar with trickle ICE and all the nuances. I will try and come back to it eventually though.
I personally don't use it, so not a lot of drive from me to work on it.

Out of curiosity, do you have changelogs or summaries of changes for minor version bumps?

I will start doing that. I just haven't been doing it out of laziness/assuming no one is reading!


chose the timezone in dbeaver option

Dbeaver 21.2.0
For all version DBeaver, i put timezone parameter to dbeaver ini file
I aded string
-Duser.timezone=Europe/Moscow
But it is very uncomfortable because this operation needs to be performed every DBeaver upgrade.

Hello @detkliff,
Timezone can be configured in time/timestamp formatters:

this parameter pointed in global settings but no effect

Looks like your column has type of timestamp with timezone.
Currently, the only way to define local timezone is to use your hack described earlier.
Probably we should allow to define timezone offset for zoned time types.

very good! This option very relevant for many developers, this query for DBeaver i sow in github meny years ago.
We are waiting this option. Thank you.

21.3.4 wooow (

This would be awesome, there's no way to just set the user.timezone and setting it manually is lost on every update

22.0.5 =((  bad, looking forward to it

Now timezone can be selected by the Timezone field in the User interface tab

Now timezone can be selected in the Timezone field in the User interface tab. The selected timezone will be applied to JVM and will affect the whole app. Every timezone supported by JVM can be selected. Autocompletion is also supported.

what version is this?

@detkliff It will be available on 22.1.0 version of DBeaver


Add similarity cosinus

Hello,
It will be great if we can choose between euclidean and cosinus similarity in LLPhant\Embeddings\VectorStores\DistancesL2Utils.
This 2 approaches have advantage and disadvantage in function what we want to do.
Example :
 public function cosineSimilarity($vector1, $vector2): float|int
  {
    // Calculate the dot product of the two vectors
    $dotProduct = array_sum(array_map(function ($a, $b) {
      return $a * $b;
    }, $vector1, $vector2));

    // Calculate the magnitudes of each vector
    $magnitude1 = sqrt(array_sum(array_map(function ($a) {
      return $a * $a;
    }, $vector1)));

    $magnitude2 = sqrt(array_sum(array_map(function ($a) {
      return $a * $a;
    }, $vector2)));

    // Avoid division by zero
    if ($magnitude1 * $magnitude2 == 0) {
      return 0;
    }

    // Calculate the cosine similarity
    $cosineSimilarity = $dotProduct / ($magnitude1 * $magnitude2);

    return $cosineSimilarity;
  }

Yes I agree 👍

It seems an interesting proposal. @ClicShopping and @MaximeThoonsen what kind of design do you think it would be the best one? To pass the distance "name" in the $additionalArguments of the VectorStoreBase::similaritySearch method?

Hey @f-lombardo,
I would update the similaritySearch signature with an additionnal optional parameter "distance name" which can be a Enum

done


Whole cart fixed amount applying to all items not whole cart

Bug report
Title
**Applying a 'whole_cart_fixed_amount' is applying to individual items instead of cart**

Issue Description
Have applied a 'whole_cart_fixed_amount' to my cart which has two items, discount is applied to both instead of a whole

Preconditions
1. 0.1.7

Steps to reproduce
1. Create 'whole_cart_to_fixed_amount' discount with coupon, no conditions for £10 off
2. Add two items to cart
3. Apply coupon code

Expected result
On applying the coupon code it should apply the discount off the whole amount not each item.

Actual result
Discount amount is incorrect and total is wrong, i.e being added multiple times.
Discount should be £10 not £19.99

Thanks for raising, will fix it real soon.

Framework Version: 0.1.8

Not Fixed

Fixed in PR #1766

Revamped the entire discount system.


Make it possible to customize config file path

It would be great to be able to customize config file path. For example, to run to be able to backup multiple mongo setups. Like this:
mongolly backup -c './cluserA.conf'
mongolly backup -c './cluserB.conf'
mongolly backup -c './cluserC.conf'

Sorry, found a bug. I'll create another pull request


Initialising project components

Project components

In this feature update:

[x] Initialise React app.
[x] Add React Redux.
[x] Structure application files using a feature folder approach and use the ducks pattern for Redux files.
[x] Add React Router and set two <Route>s and <Link>s for the app's navigation

Hi @Chimwemwe-127001,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, where the README file isn't updated to show a professional representation of the project, please update it.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hello @omar-labana. I have updated the README file. Thanks for spotting that.

Thank you very much @TedLivist for the review. All requested changes have been implemented.

Happy coding!! :computer: :smile:

Thanks for the review @ArthurGC. Hopefully my PR gets approved this time.
Happy coding :computer: :smiley:

Hi @Chimwemwe-127001,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Can't get it to work

The following outputs 3 files:
production/views.production.js contains: !function() {  }();
production/production.js contains: !function() {  }();
production/production.min.js is empty.
Running "cancompile" task
Running "cancompile:dist" (cancompile) task
Verifying property cancompile.dist exists in config...OK
Files: test/catMerchList_view.ejs, test/breadcrumb_view.mustache, test/featuredStores_view.mustache -> production/views.production.js
Options: version="0.8.0", wrapper="!function() { {{{content}}} }();"
Compiling test/catMerchList_view.ejs
Running "concat" task
Running "concat:dist" (concat) task
Verifying property concat.dist exists in config...OK
Files: production/views.production.js -> production/production.js
Options: separator="\r\n", banner="", footer="", stripBanners=false, process=false, sourceMap=false, sourceMapName=undefined, sourceMapStyle="embed"
Reading production/views.production.js...OK
Writing production/production.js...OK
File production/production.js created.
Running "uglify" task
Running "uglify:dist" (uglify) task
Verifying property uglify.dist exists in config...OK
Files: production/production.js -> production/production.min.js
Options: banner="", footer="", compress={"warnings":false}, mangle={}, beautify=false, report="min", expression=false, maxLineLen=32000, ASCIIOnly=false, screwIE8=false
Minifying with UglifyJS...Reading production/production.js...OK
OK
Writing production/production.min.js...OK
File production/production.min.js created: 19 B → 0 B

1 file created.

Done, without errors.

What's you configuration and how do the files look like?

I've tried several configurations, this resulted in my previous post.
Gruntfile.js:
module.exports = function (grunt) {
// Project configuration.
grunt.initConfig({
    cancompile: {
        options: {
            version: '0.8.0'
        },
        dist: {
            options: {
                wrapper: '!function() { {{{content}}} }();',
            },
            src: ['test/*.ejs', 'test/*.mustache'],
            dest: 'production/views.production.js'
        }
    },
    concat: {
        dist: {
            src: [
                '<%= cancompile.dist.dest %>' // The compiled views
            ],
            dest: 'production/production.js'
        }
    },
    uglify: {
        dist: {
            files: {
                'production/production.min.js': ['<%= concat.dist.dest %>']
            }
        }
    }
});

// Default task.
grunt.registerTask('default', ['cancompile', 'concat', 'uglify']);

grunt.loadNpmTasks('can-compile');
grunt.loadNpmTasks('grunt-contrib-uglify');
grunt.loadNpmTasks('grunt-contrib-concat');

};
Structure:
Assets -> Gruntfile.js
-> node_modules/
-> test -> breadcrumb_view.mustache
-> catMerchList_view.ejs
-> featuredStores_view.mustache

Your version option is wrong. It hast to be the CanJS version you are using not the can-compile version and there is no CanJS 0.8.

Yeah, I think I already messed with that. Changed it back to 2.1.3 and got this:
production/production.js and production/production.min.js created but completely empty.
Running "cancompile" task
Running "cancompile:dist" (cancompile) task
Verifying property cancompile.dist exists in config...OK
Files: test/catMerchList_view.ejs, test/breadcrumb_view.mustache, test/featuredStores_view.mustache -> production/views.production.js
Options: version="2.1.3", wrapper="!function() { {{{content}}} }();"
Compiling test/catMerchList_view.ejs
Running "concat" task
Running "concat:dist" (concat) task
Verifying property concat.dist exists in config...OK
Files: [no src] -> production/production.js
Options: separator="\r\n", banner="", footer="", stripBanners=false, process=false, sourceMap=false, sourceMapName=undefined, sourceMapStyle="embed"
Writing production/production.js...OK
File production/production.js created.
Running "uglify" task
Running "uglify:dist" (uglify) task
Verifying property uglify.dist exists in config...OK
Files: production/production.js -> production/production.min.js
Options: banner="", footer="", compress={"warnings":false}, mangle={}, beautify=false, report="min", expression=false, maxLineLen=32000, ASCIIOnly=false, screwIE8=false
Minifying with UglifyJS...Reading production/production.js...OK
OK
Writing production/production.min.js...OK
File production/production.min.js created: 0 B → 0 B

1 file created.

Done, without errors.

Any idea what this means? Could the issue be with jsdom? I've encountered this several times trying alternative builds with can-compile.
SyntaxError: c:\Users\xxxxx.MALLNET\Documents\sandbox\gulp\emall\assets\core\node_modules\can-compile\node_modules\jsdom\lib\jsdom\level1\core.js:432
set nodeName() { throw new core.DOMException();},
^
Unexpected token )

What Node version are you using?

0.12.0

This hasn't been tested with Node 0.12. Looks like that version of JSDOM doesn't work with 0.12. The most reasonable option would be to upgrade can-compile to JSDOM 4 (which would also make it much easier to get it to work on Windows) but that JSDOM will only work with io.js.

So... instal io.js, update JSDOM and then what? I mean is this something I should attempt?

I would say installing nvm and then nvm install v0.10.36 && nvm use 0.10.36 would be the easiest thing to try first. I'll look into 0.12 compatibility.

That worked, thank you. If you could let me know when you update that would be great.

I also had the jsdom error 'Unexpected token )' (can-compile 0.8.0, canjs 2.1.4, node 0.12.1).
After installing node 0.10.36 via nvm the jsdom error is gone but theres another error:
module.js:340
    throw err;
    ^
Error: Cannot find module 'generate-object-property'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> ([...]/node_modules/can-compile/node_modules/jsdom/node_modules/request/node_modules/har-validator/node_modules/is-my-json-valid/index.js:1:76)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

David, thanks again for this great module. I also experienced problems with JSDOM and node 0.12 / io.js 1.6.4. JSDOM 4.x.x is incompatible with node, but JSDOM 3.x.x is compatible with both. When i upgrade package.json to:
  "dependencies": {
    "commander": "1.1.1",
    "async": "0.1.22",
    "jsdom": "~3.0.0",
    "handlebars": "~1.0.12",
    "glob": "~3.2.8"
  }

the only problem remains: JSDOM v3.x.x/v4.x.x stops if it fails to parse provided javascript file. And it happens in my case with version=2.1.4, because the url http://canjs.com/release/2.1.4/can.view.mustache.js is broken. It seems that a location and name of this file changes with each canjs release.
As a workaround for 2.1.4 i replaced the url with http://canjs.com/release/2.1.4/can.stache.js and it works.

can.view.mustache is the default in version 2.x so it does not come a s a separate plugin anymore. I guess the configuration has to happen based on the version then.

Thanks to #36 only the needed scripts are loaded. I also updated the JSDOM version via https://github.com/daffl/can-compile/commit/64737d6bb4171b0d1bb7b54ea61d3e134585af01 and made sure Travis test runs on Node 0.10, latest and io.js.


Uncaught Error: addComponentAsRefTo(...) & removeComponentAsRefFrom(...)

I’m new to react / redux and was just looking at doing this myself! So I’m glad to come across this. I have had a couple of problems though. At the end of the install (n.b. the install instructions didn’t work for me and I had to npm install using the url for the git project), there was an error reported, it couldn’t find package.json as it was looking in my home directory rather than my project folder. I don't know whether this means something has failed and so won't work?
However, I tried to configure anyway to see what happens . . . changing my form to use DateTimeInput instead of DateInput. However, when I view the form, I’m getting the following error in my console:
invariant.js:44
Uncaught Error: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).
at invariant (invariant.js:44)
at Object.addComponentAsRefTo (ReactOwner.js:68)
at attachRef (ReactRef.js:23)
at Object.ReactRef.attachRefs (ReactRef.js:42)
at ReactCompositeComponentWrapper.attachRefs (ReactReconciler.js:23)
at CallbackQueue.notifyAll (CallbackQueue.js:76)
at ReactReconcileTransaction.close (ReactReconcileTransaction.js:80)
at ReactReconcileTransaction.closeAll (Transaction.js:206)
at ReactReconcileTransaction.perform (Transaction.js:153)
at ReactUpdatesFlushTransaction.perform (Transaction.js:140)
and then when I try to move away from the form:
Uncaught Error: removeComponentAsRefFrom(...): Only a ReactOwner can have refs. You might be removing a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).
at invariant (http://localhost:3000/static/js/bundle.js:11424:16)
at Object.removeComponentAsRefFrom (http://localhost:3000/static/js/bundle.js:19049:37)
at detachRef (http://localhost:3000/static/js/bundle.js:18903:17)
at Object.ReactRef.detachRefs (http://localhost:3000/static/js/bundle.js:18955:6)
at Object.unmountComponent (http://localhost:3000/static/js/bundle.js:18774:15)
at Object.obj.(anonymous function) [as unmountComponent] (chrome-extension://fmkadmapgofadopljbjfkapdkoienihi/build/backend.js:8598:20)
at Object.unmountChildren (http://localhost:3000/static/js/bundle.js:26594:26)
at ReactDOMComponent.unmountChildren (http://localhost:3000/static/js/bundle.js:26256:29)
at ReactDOMComponent.unmountComponent (http://localhost:3000/static/js/bundle.js:22789:11)
at Object.unmountComponent (http://localhost:3000/static/js/bundle.js:18775:23)
Is this because something wasn't right with install or something else I've done wrong?

ok, thank you for feedback. i will try to fix it. thanks

@clwilliams hello, while I'm solving any issues to divide this component from aor to make it is independent. So, please, copy and paste code from index.js to your project to new file. Name this file for example DateTimeInput.js. Then on your page make import DateTimeInput from './DateTimeInput'; with checking file path. And then add <DateTimeInput source="date" /> to SimpleForm as in docs. Thank for understanding.

It happens because this package has react as dependency, and if you have another version of react in your package.json, it will result in two react versions installed in node_modules.

I think this changes are enough to fix, but not sure
https://github.com/brunjick/aor-datetime-input/commit/b2bbe8822cbdcc3da979c1b6ba74ba81b8c117cd

@clwilliams hello, thank you for using this component. Right now I had published package to npm. you can try install it using npm install aor-datetime-input --save in your project. And tell there have you any problems or no. thank you.

so problem is still here when i tried to add component from npm, i will try to fix it

I have this same issue when installing from npm.

@clwilliams  @thisdotvoid @patotoma hello, new version is available https://www.npmjs.com/package/aor-datetime-input . please try it and write if something went wrong. thank you


Server ip address (website url) not working.

When I do:
localStorage = lc('http://<IP_ADDRESS>:224/')
it raises WinError 123:
OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\\William/.localStorage/http://<IP_ADDRESS>:224/'
Do you know how I would grt this to wor?

Hi, some characters cannot be used with localStoragePy, such as path separators / \.

I have updated the library. Please reread the README for more information.


Increment version for core releases

Increment package version after release of Azure.Core.Experimental

API change check
API changes are not detected in this pull request.


Check pipeline test pr please ignore

I'm sorry, this wasn't supposed to be opened against this repository...


feat(module:i18n): support for Armenian

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Codecov 是不是在等已经移除的 travis-ci ……


TypeError: e.substr is not a function

trying to run on nodejs4.3 on aws lambda
2016-12-08T20:59:57.703Z	45fb8783-bd89-11e6-9e9a-493023932084	TypeError: e.substr is not a function
    at Command.callback (/var/task/node_modules/redis-cluster/index.js:181:18)
    at RedisClient.return_error (/var/task/node_modules/redis/index.js:559:25)
    at ReplyParser.<anonymous> (/var/task/node_modules/redis/index.js:308:18)
    at emitOne (events.js:77:13)
    at ReplyParser.emit (events.js:169:7)
    at ReplyParser.send_error (/var/task/node_modules/redis/lib/parser/javascript.js:296:10)
    at ReplyParser.execute (/var/task/node_modules/redis/lib/parser/javascript.js:181:22)
    at RedisClient.on_data (/var/task/node_modules/redis/index.js:535:27)
    at Socket.<anonymous> (/var/task/node_modules/redis/index.js:91:14)
    at emitOne (events.js:77:13)

Hmm, I'm not sure exactly where that's coming from (e.substr doesn't match anything around those line numbers). What version of the module are you seeing this with?

Just digging around a bit, it looks like that error might be coming from this line over on a different redis cluster module - is it possible that's the one you mean?

wow that's embarrassing. yeah i'm using the totally wrong module. D:


documente background tasks

Now that background tasks have been broken out into their own space, with validation reports, job deletions, exports, etc., running through them, need to document that space.
Include:

tasks table
single task view

task specific results (e.g. downloading reports)
use of preview for validations, or others

Done.


Use of Dialogic, for a dialog editor for an in-game toolset?

Hello!
My team is looking to use Dialogic to create an in-game editor for our games dialog system. I noticed that there are nodes for things such as the timeline editor. Is it possible to extend these nodes, in a Godot project; so that we can create Dialogic objects in our in-game editor (Think like Halo Forge or Aurora Toolset)?

I think we could maybe do some extension to allow that in the future, and create a way to have the TimelineEditor build in a running game.  However it would require some modification to how the files are saved and loaded right now. One big thing for this is a Godot limitation itself, res:// is read-only when you're not running a game through an editor, so if you want end user ability to make them then they's have to be saved and read from user:// or somewhere else


INT-B-19779 - Show MTO Service Price for Counseling and Move Management

Agility ticket
Summary
This branch now shows the price for approved Move Management (ReService Code "MS") and Counseling (ReService Code "CS) service items on the Move Task Order tab.
How to test

Create a move then as SC send the move to prime by approving for Counseling/Move management.
As the Prime, access any move and create a payment request with Move Management and/or Counseling service items.
Login as a TOO and access the move, go to the "Move Task Order" tab.
At the bottom you should see a price like this:

Note: that this shows up before approving the item, you should see the same price on the "payment requests" page:

Not sure if this is intended behavior, but the routing functionality that actually shows these items under "approved service items" was implemented in E-04919 by Scrummy Bears and went through POA approval, so if this is a bug I believe it would be out of scope for this story.

I've approved it because I agree that it might be out of scope if what you said about the bug is true, but it might be a good idea to maybe check with Brittney to avoid any possible kickbacks from testing. They might want you to display nothing in details if it has not been approved yet - and display price once it gets approved.


ruff format vs ruff check output and verbose option

When running ruff format --check you get a count of files unchanged. When running ruff check you get nothing returned if there is nothing to report.
$ ruff format . --check
2628 files already formatted
$ ruff check .
$

In our use case we include the output of these commands into some customer deliverables and in the case of ruff check . they can't tell the difference between "This does nothing" and "There was nothing to do".
We can run with the verbose option -v but it generates a ton of output way overkill for our needs.
I note also that the -v flag makes the verbose output go to stderr and not stdout. Is this deliberate?
$ ruff check . -v > program.stdout 2> program.stderr
$ wc program.stderr
   8425<PHONE_NUMBER>293 program.stderr
$ wc program.stdout
0 0 0 program.stdout

What we would like is symmetry between ruff format and ruff check so that a count of files checked are reported by ruff check
Very grateful for ruff, brilliant tool, I hope the above does not come over demanding. Thanks for your consideration.

List of keywords you searched for before creating this issue. Write them down here so that others can find this issue more easily and help provide feedback.

verbose, ruff check output

The current Ruff settings (any relevant sections from your pyproject.toml).

[tool.ruff]
target-version = "py311"
line-length = 120
indent-width = 4
lint.extend-select = ["C90", "S", "T", "I", "E", "W", "PIE"]
lint.ignore = ["PIE808", "PIE810"]
lint.extend-ignore = ["S101","S320", "S701"]

The current Ruff version (ruff --version).

ruff 0.3.2

Please see #8553 — we will indicate successful checks in the next release. I think including a file count makes sense too it just needs to be implemented.
And yes it is intentional that logs go to standard error since it's not "data" meant to be piped to another tool.


Re-enable macOS support

Thanks for the great project. I used the tagged version but wanted to contribute so switched to master, where I had some trouble:
On master the project no longer works on darwin, but it does in 0.1.1.
The change for a windows fix moved audio.go (and video.go) to a -windows and -linux suffix, but there is no -darwin so compile fails.

Uploaded the fix to master. Should work now.

Thank you, that fixes the Go compile error.
However there is still an issue in the CGo compilation - not sure exactly why.
I'm using Big Sur on an Intel Mac.
# github.com/zergon321/reisen
../../../.go/pkg/mod/github.com/zergon321/reisen@v0.1.2-0.20211117093043-7b9e910bde82/audio.go:61:9: cannot use _Ctype_long(audio.baseStream.codecCtx.channel_layout) (type _Ctype_long) as type _Ctype_longlong in argument to _Cfunc_swr_alloc_set_opts

Ok...
Well, I had the same problem on Windows. It required explicit type conversions with C.longlong. You can see how it's done in audio_windows.go. Apparently, Mac OS requires the same type of fix at some places in the source code.
I don't own a computer by Apple so it's impossible for me to track all the type conversion errors (more of them can emerge during the fixing process). Could you please first create a PR with type conversions fixed? The only thing that is required to do is to create separate versions of audio.go and video.go (if necessary) for darwin just like I did it for Windows.

Oh, OK - I was worried about the large duplication it would create, but if that is the right thing I can do that.

I opened a PR that did this whilst removing the duplication, I hope that is OK.
I have not tested all OS yet, but the changes per-platform should now be cleaner so it should be easier to maintain when these things happen.

Tested now on macOS and Linux :)


Bump redoc to v2.0.0-rc.59

Proposed changes
Bump Redoc so we can use multiple example support offered by OpenAPI
Related issues (optional)
https://github.com/moby/moby/pull/43344

doens't work out of the box, will require more investigations
https://deploy-preview-14357--docsdocker.netlify.app/engine/api/v1.41/


How to check if a translation mapping exists

Hi there,
I couldn't see if there was a way to see if a translation mapping exists?
What I mean is, I have an angular page where I am looking up translations dynamically in a loop. Mappings for some of them may not exist for whatever reason, and I'd like to make that check before attempting to render the translation and associated markup.
I mainly want to do these checks from a view, where I would be using the translate filter or directive.
But I also couldn't see a way to do this from a controller using the $translate service either - although I'm sure it's probably possible using the $translate service directly.
Any ideas?

+1
Note: Both links are "Page not Found"
It would be really great to have a helper method to explicitly check in advance if a translation exists. Also, if I could define a fallback-key that is used for non existent mappings.

Well, it is a very old thread and the docs moved. Look here:
http://angular-translate.github.io/docs/en/#/guide/14_error-handling

For anyone else looking: http://angular-translate.github.io/docs/en/#/guide/16_error-handling

When using $translate it would be much better if just print the key in case there was no translation instead of not doing nothing.

@vinyoliver please do not comment on closed issues if there is some issue you'd like to point out. thanks.
Anyway: Did you read the referred chapters above on handling of non-existing translations?


mgmt re-enable CdnSampleTests

Description
link https://github.com/Azure/azure-sdk-for-java/issues/30229
Seems to work on linux again.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Since we can't control the agent settings, we may not want this PR to get merged in the near future until we find out the root cause.


feat(Topology/Sets): define regular open sets and their boolean algebra

Introduces a new module, Mathlib.Topology.Sets.RegularOpens, which defines the IsRegularOpen s predicate (interior (closure s) = s) and TopologicalSpace.RegularOpens, the type of bundled regular open sets.
A few properties of regular open sets and interior (closure s) are first proven.
Then, RegularOpens is equipped with the operations ↑(a ⊓ b) = ↑a ∩ ↑b and ↑(aᶜ) = (closure ↑a)ᶜ, which forms a boolean algebra (TopologicalSpace.RegularOpens.booleanAlgebra).

The design of RegularOpens is heavily inspired by the existing Mathlib.Topology.Sets.Opens. This PR belongs to my series of PRs around my formalization of Rubin's theorem.
As the module documentation mentions, one could instead equip TopologicalSpace.Opens with the above choice of ↑(aᶜ) = (closure ↑a)ᶜ = Opens.interior (↑a)ᶜ and get a Heyting algebra. RegularOpens could then simply be defined as Heyting.Regular (TopologicalSpace.Opens X).
I chose not to go with this route, as I only really need in my formalization of Rubin's theorem the fact that regular open sets form a SemilatticeInf that distributes with the pointwise group action on them. I would happily switch to this alternative construction if it is preferred (most of the proofwork that I wrote can be re-used).

Actually, I see no reason why I wouldn't just construct the heyting algebra for open sets, it'll probably make the PR smaller anyway as a lot of things are provided out of the box by Heyting.Regular


How to use build_C?

Hello, I am trying to use your code to generate the matrix C based on a spectrum, so that I can invert this matrix and use it to monochromatize a diffraction pattern. In the repository, I see only a collection of functions with no runnable code. from reading through the functions, my best guess is the function I should be using is titled "build_C" in monochromatization_of_diffraction_pattern.py which calls the function called "parloop".  I see that build_C takes arguments titled 'S' and 'a', along with Npixels, but I dont see any documentation explaining what these variables are supposed to be. I would expect this function to take something like an array of spacial frequencies, a distance and a wavelength, along with a measured spectrum? Can you explain what "s" and "a" are and what format they should be in to use this function? or better yet some example code of running this function?
thank you

Hi Jonathan,
Sorry I didn't reply to you earlier! Github didn't notify me of any message (or I missed it), and I don't spend so much time on here.
Thank you for your interest in my work!
As you've seen, I added an example notebook to explain how to use the code, and I cleaned up the code a bit here and there.
I also included a reference to my PhD thesis and an article.
Can you tell me what you are working on?
Best,
Julius

Thank you for the response Julius
I see the python notebook you uploaded, looks very helpful.
I'm now working applying machine learning to coherent diffractive imaging.


RC Test: Resistance In A Wire 1.3.0-rc.1 and 1.3.0-phetiorc.1

Phet link:
http://www.colorado.edu/physics/phet/dev/html/resistance-in-a-wire/1.3.0-rc.1/resistance-in-a-wire_en.html
PhET-iO link to wrappers index (password protected and hidden in the parent version dir):
http://www.colorado.edu/physics/phet/dev/html/resistance-in-a-wire/1.3.0-phetiorc.1/wrappers/index
These two versions were just created from master shas. The sim was newly instrumented for PhET-iO and went through major code refactoring and review in the process (thanks @samreid @veillette for all the help), so it will be useful to publish a phet version while we are at it.
Please reference this issue in any related issues that are created.
There are no sim-specific query parameters.
Assigning to @ariel-phet for priority and delegation.

We need to maintenance these shas into these releases
phetsims/scenery-phet@f210433
phetsims/scenery-phet@727d5bd

Discussed with @zepumph, this sim will be given the same treatment as Molarity. The move to rc before dev was not ideal, so we will be closing this issue and starting with a 1.3.0-phetiodev.1. After that passes, we can move on to RCs for both brands. Assigning to @zepumph to deploy the needed version.

Taken care of in #88, closing because these rc's will be stale by the time new rc's come out. We will start with rc.2 then.


SIL: Replace uses of getReferencedFunction() by getReferencedFunction…

…OrNull() and getInitialReferencedFunction()
With the advent of dynamic_function_ref the actual callee of such a ref
my vary. Optimizations should not assume to know the content of a
function referenced by dynamic_function_ref. Introduce
getReferencedFunctionOrNull which will return null for such function
refs. And getInitialReferencedFunction to return the referenced
function.
Use as appropriate.
rdar://50959798

@swift-ci Please test

Overall, I find the names here to be sort of confusing. When do I want to use getReferencedFunction and when do I want to use getInitialFunction?
When I think at a high level about it, I think the distinction is about the actual function to be called vs the identity of a specific abstract function pointer. I don't have a better name at this point in time, but these names worry me.

That being said, if you need to get this in ASAP, we can talk about this offline and follow up.

You want to use getReferencedFunction when the client cares about the dynamic target - the content of the function. The higher level API named the same way on ApplySite and apply instructions already had this behavior: it returned the function_refed sil function or null if the callee was dynamic.
How about something like:
getKnownTargetFunctionOrNull()
I liked the initially referenced naming because to me when I read this I think: initially means something might change ...
Static does not evoke that thought process with me.
I am totally open to a different naming scheme.

If you think about the essence of what you are distinguishing, one is the dynamic function at runtime and the other is in a sense an ID for a specific function ptr in the program. The initial function is the identity of that abstract concept. I wonder if we can work that into the names somehow.

if you need to get this in ASAP, we can always rename using Xcode's refactoring engine.

There is the distinction (that I think you pointed out earlier):
getStaticallyReferencedFunction()
vs
getDynamicallyReferencedFunction()
but I feel like getStaticallyReferenced does not sound scary enough when read alone in the context of some code. “Initially” conveys that something might change.
getKnownDynamicallyReferenced()
Vs
getInitiallyStaticallyReferenced()
Maybe?

getReferencedFunctionOrNull is a fine name as long as the comments explain why some apply sites return null.
That's the primary API. getInitiallyReferencedFunction is just a placeholder that I think should go away. So we don't need to make those names somehow symmetric. The only other name I can think of would be `getReferencedFunctionPlaceHolder" which is pretty awkward.
My main suggestion here is to add more comments to the WARNING so it's clear that this API is deprecated and the alternative is to use the referenced SILFunctionType instead. Maybe even a FIXME to rewrite the current  uses of that API. Do you foresee any difficulty rewriting those uses over time?

Just had an interesting thought. One thing I noticed while reading the code is that the major places that the getInitiallyReferencedFunction() are cloner like functions. Maybe the right way to do this is to make it so that the dynamic function ref takes a static function ref as its "default value". Then when we clone, the inst will just clone itself and the clone the function_ref which would go through the normal code path.

Yes there are placed like the cloner, verifier, and SILFunction ref counting where it won’t go away.
If we want to make it really hard to use the API, we could make the API private and friend those places.

Instead of getInitialReferencedFunction, I would handle this with a getFunctionRef API that returns a SILFunctionRef which could be used to build new *function_ref instructions but wouldn't generally allow access to the function body. I'm not sure if that would help the non-cloner use cases or if it's worth the trouble.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - c187c8ac13b68c09b95316423a9624f88099903f

Build failed
Swift Test OS X Platform
Git Sha - c187c8ac13b68c09b95316423a9624f88099903f


Auto corrected by following Format Ruby Code

Auto corrected by following Format Ruby Code
Click here to configure it on awesomecode.io

Coverage decreased (-0.1%) to 78.347% when pulling 2a7f1e8fe44597713c0074920c01b51a1ff5c5c0 on awesomecode-format-ruby-code-48501 into 4644951d5246f972279cde2230afc026288034eb on master.


Update categories in package.json

https://github.com/Shresht7/vscode-bg3-modding/blob/8e9c93bbdca87ba4459feb0471f3dd9cb3a26dba/package.json#L13-L16

The only other valid category would be Programming Languages as of now.


vSphere: add missing fields in example

Signed-off-by: Artiom Diomin<EMAIL_ADDRESS>What this PR does / why we need it:
Example didn't reflected all the possible config option accessible in vSphere
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
vSphere: add missing fields in example

/retest

/lgtm
/approve

/retest

/retest

@alvaroaleman we can /override it

/retest

/retest


Broken Java version detection in 0.7.5 on linux

Gauge-Java 0.7.5 doesn't seem to detect Java version correctly on linux systems, failing with an unsupported Java version error.
Steps to reproduce
docker run --rm -it gradle:6.3.0-jdk11 bash -c 'wget -O gauge.zip https://github.com/getgauge/gauge/releases/download/v1.0.8/gauge-1.0.8-linux.x86_64.zip && unzip gauge && ./gauge install java --version 0.7.5 && ./gauge init java && ./gauge run specs'
Expected behavior
# Specification Heading
  ## Vowel counts in single word	 ✔ ✔
  ## Vowel counts in multiple word	 ✔ ✔

(Output of using 0.7.4 instead of 0.7.5 in the docker command above)
Actual behavior
This version of gauge-java plugin does not support Java versions < 1.9
Please upgrade your Java version or use a version of gauge-java <= v0.7.4
Error occurred while waiting for runner process to finish.
Error : exit status 1
Error ----------------------------------

[Gauge]
Failed to start gauge API: Timed out connecting to java

Gauge version
Your Environment Information -----------
	linux, 1.0.8, 28617ea
	html-report (4.0.10), java (0.7.5), screenshot (0.0.1)

(1.0.8; also not working on 1.0.7)

this is caused by a bug in launcher.sh which does not handle versions well.

@whipermr5 - please try with the latest release - 0.7.6

@sriv It's working now! Thank you!!


Changing "Navigation View" Width

Hi Mr. Pimenov
How can I change "Navigation View" width?
https://metroui.org.ua/navview.html

hi, you must override specific styles

You can't change compact width (48 px) this value uses as constant in js code of navview

thanks, but this solution can be used when we want to use original source of metroui4
but in this case that we are using the build of metroui4 (only metro-all.js & metro-all.css files), what is the solution?

thanks, but this solution can be used when we want to use original source of metroui4
but in this case that we are using the build of metroui4 (only metro-all.js & metro-all.css files), what is the solution?

Override styles in an additional CSS file. Check out Pandora example, I override navview there.

fixed!
thank you

Excuse me! I didn't see naview overriding in https://github.com/olton/Pandora/tree/master/source/css
Could you please tell me where the overriding is ?
Thank you for the help.

https://github.com/olton/Pandora/blob/master/source/css/index.less#L5


Issues trying to lunch the stack

Sorry for this question but how can i lunch this stack. I try it but i get the same error all time.
rds | CREATE_FAILED | Embedded stack arn:aws:cloudformation:us-east-1:########:stack/moodlecftest2-rds-#############-###-###-############## was not successfully created: The following resource(s) failed to create: [DatabaseCluster].
-- | -- | -- | --

This should be fixed by last merge


Session replay web / mobile

Hi
Is it foreseen a functionality allowing the session replay on mobile and web please ?
Thanks

We're currently gaging interest in session replay for Flutter. If we do it, it will likely start with mobile and add in web later.

I would love this for mobile and web, thank you!

This feature is available for Android and iOS, when will this be available for Flutter?

Hi @diegolechado,
Because of how we do Session Replay in iOS and Android, it is not directly portable to Flutter.
We're still definitely interested in doing it, it will just take some time.  In the mean time, please reach out to your CSM and let them know your interest, as that will help us gauge how much interest there is.

Would also love to see session replay come to mobile Flutter 🙏🏻

Any news about this?

I'm also interested in seeing this be added to Flutter.

want this +1

I'm also very interested in this feature. For mobile and web!

We would really like this feature as well

Please make it possible soon!

Would love Flutter support for session replay, too!

please bump this feature we really could use this feature as well.

This feature is greatly needed by our team. As we're used to this functionality on our website, we might have to unfortunately look for Flutter specific alternatives.

want this +1

+1

+1

+1

Hey Team, you are doing a perfect job, thanks for everything. We need session replay. I hope you will implement this feature in Flutter :)

+1

Hey guys, Sentry just released a beta of their session replay recording for Flutter, we would love to keep our RUM monitoring here, instead of moving web and mobile there, do you have any plans or a target date when is it going to be available?


[UI] Feature/improve detailed results performance

Added the request ID to the raid sim request to have a unique value to build cache keys with
Added a generic CacheHandler to allow for caching of elements that do not change and can be reused.
Added caching to diverse "enriched" HTML Nodes that are dependent on async calls like wowhead datasets
Added caching (max 2 entries) to SimResults to make toggling between 2 (reference) datasets much quicker
Added caching to the Timeline content
Fixed DPS graph Timeline tooltips

After & Before
~ 3x performance increase when swapping/toggling between 2 results
Overall GC improvement

This should be mergeable right @1337LutZ ?

This should be mergeable right @1337LutZ ?

Yes! If others tested it and found now issues 👌


dataslayer

crashed and won't track in chrome.

@sandye7 is this on all pages, or with specific site(s)?

all pages
*Sandye *Sowers http://www.cognizant.com/cognizant-interactive
NERD LIFE...ME ALL DAY! http://youtu.be/Op1i0B8-dJA
What is web analytics? It turns out that the answer is both simple and
loaded: web analytics is pretty much everything.  It’s a multi-discipline
practice that aims to quantify today’s success and uncover usability,
design, architecture, copy, product, and marketing optimizations that will
breed even more success tomorrow for your business. I'm very happy that a
hybrid like myself  can now do the happy dance because most business get
it...* analytics is an art form. *

The research space has been "revolutionized over time" It's not about user,
brand, media, market or consumer research silos. Rather, it's about
integrated, ever-present, sustainable insights that tap into deep human
connections and behaviors that tell powerful stories and drive business
results.
Chad Maxwell @ Starcom
http://www.atlantaanalytics.com
ADOBE TV- SiteCatalyst  http://adobe.ly/IUEULb
On Mon, Apr 3, 2017 at 3:54 PM, Sean Adams<EMAIL_ADDRESS>wrote:

[image: Boxbe] https://www.boxbe.com/overview Sean Adams (
<EMAIL_ADDRESS>is not on your Guest List
https://www.boxbe.com/approved-list?tc_serial=29638809003&tc_rand=1423274550&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=3fCP1kWMEUIkqBVhZPTiis87fisaW7BuzLuBvckPJSM%3D&token=TwjHzhmPOPFoIwhmI3kSgWCemzEb6jE2XKhLxEQ57cpWkuoRRkYDL50gBOF%2BYu3H
| Approve sender
https://www.boxbe.com/anno?tc_serial=29638809003&tc_rand=1423274550&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&key=3fCP1kWMEUIkqBVhZPTiis87fisaW7BuzLuBvckPJSM%3D&token=TwjHzhmPOPFoIwhmI3kSgWCemzEb6jE2XKhLxEQ57cpWkuoRRkYDL50gBOF%2BYu3H
| Approve domain
https://www.boxbe.com/anno?tc_serial=29638809003&tc_rand=1423274550&utm_source=stf&utm_medium=email&utm_campaign=ANNO_MWTP&utm_content=001&dom&key=3fCP1kWMEUIkqBVhZPTiis87fisaW7BuzLuBvckPJSM%3D&token=TwjHzhmPOPFoIwhmI3kSgWCemzEb6jE2XKhLxEQ57cpWkuoRRkYDL50gBOF%2BYu3H
@sandye7 https://github.com/sandye7 is this on all pages, or with
specific site(s)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sean-adams/dataslayer/issues/37#issuecomment-291254903,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTmTgy89i_wySu6zKGdN8CbWBdu-Crrks5rsU6HgaJpZM4MyAyE
.

@sandye7 what version of Chrome, and what version of dataslayer, are you using? Can you try uninstalling and reinstalling dataslayer and see if that works?


fix(css): increased spacing in docs navbar to reduce congestion

The upper left navbar elements in the main page for docs are a bit too close to each other, so I spaced them out a bit.
Original:

New:

Changes

changed horizontal padding for 3 elements by 10px

I don't think this is an issue, @Michael-Grover I'll kick it to you.

I like this change, I think it makes the menu look better


Update logger.js to fix docs in winston 1.x

Docs for rewriter were wrong, which had knock-on effects for the d.ts in DefinitelyTyped (also updated)

I've only changed comments here so if travis fails I have no idea why


Add get all screening tools

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

72 of 93 (77.42%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 83.447%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/mycarehub/infrastructure/database/postgres/gorm/query.go
11
15
73.33%

pkg/mycarehub/infrastructure/database/postgres/pg_query.go
35
39
89.74%

pkg/mycarehub/usecases/questionnaires/questionnaires.go
13
18
72.22%

pkg/mycarehub/presentation/rest/handlers.go
9
17
52.94%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
18083

Relevant Lines:
21670

💛  - Coveralls


Improve docs for the first part

I rewrite some parts after last reviews.
@svx @stevepiercy this is the first part of the tutorial. When this pr is merged, you could start review gatsby-training branch if you want.
The second part will be committed soon by @ajayns

@cekk Maybe they could start the review after my part (first half of it) also is merged

BTW, I just found https://github.com/adrgautier/pygments-lexer-graphql, maybe someone could add Python3 support (if that is not already, there) and make/fork/create a release :)
With that we may could add 'proper' lexer support for graphql ?
"Just" a suggestion :)

@stevepiercy @svx  i added a new lexer: jsx-lexer.
Now all code snippetes are rendered properly (also the ones with ...)

@stevepiercy like the previous one, maybe at this point it's better to merge this one and fix remaining things on another one (just to keep the reviews simplier)

I'd suggest not merging until this review cycle is complete. A new PR would lack all the previous review comments, and make it difficult to see what has been addressed or missed.

GitHub recently added a feature to "Resolve conversations". Here's an example of a review comment that has not yet been addressed:
https://github.com/plone/training/pull/341/files#r228336014
That's an example of why I don't want this PR to be merged yet. Let's address the open conversations first.
After all review comments have been addressed, please ping @svx and me for another review. Even though it is time-consuming and can be sometimes frustrating, it yields better quality documentation. Thank you!

@stevepiercy @svx i think that remains only 2 issues where i don't find the right row to fix.
I have also created a folder "_snippets" where to put code examples to import in the documentation.
Let me know if it's good for you

another set of fixes..you can check all pending comments

@stevepiercy merged and tried a local build: looks good to me

Yup, looks good here. I'm a little disappointed that jsx-lexer doesn't add nice syntax highlighting as I hoped, but that's a problem with the RTD theme and its support for custom lexers. If I switch to use the html theme 'default', then syntax highlighting is fine.


Added change-current-directory and parent-name to fs

This is a simple PR adding a couple methods for fs interactions that I was missing, namely a function to change the current working directory and a function mirroring file-name that returns the full path to the parent directory. I also attempted to add the correct docs for them, but it's possible I missed some places (and if there's automatic doc generation I didn't know how to run it).

This LGTM - but it looks like rust fmt is failing. Would you be able to re format it and push? Otherwise I can handle it

Okay, I think I fixed it?


Add version numbers.

When making the first release.
It will match the server's released version numbers.

Done.