Add property tests for the Validation type

Resolves #176
I added property tests for basic laws of Semigroup/Monoid/Applicative/Alternative.
A copule of tests checks that <* and *> work just like default implementations in Applicative class.
Checklist:

HLint

[ ] I've changed the exposed interface (add new reexports, remove reexports, rename reexported things, etc.).

[ ] I've updated hlint.dhall accordingly to my changes (add new rules for the new imports, remove old ones, when they are outdated, etc.).
[ ] I've generated the new .hlint.yaml file (see this instructions).

General

[ ] I've updated the CHANGELOG with the short description of my latest changes.
[x] All new and existing tests pass.
[x] I keep the code style used in the files I've changed (see style-guide for more details).
[x] I've used the stylish-haskell file.
[ ] My change requires the documentation updates.

[ ] I've updated the documentation accordingly.

[ ] I've added the [ci skip] text to the docs-only related commit's name.

@chshersh will I need to suppress such warnings from the bot? In this particular case code contains lines like empty <|> by purpose :)

@astynax Yeah, I know that this code is on purpose. Ideally, there should be a good library that already implements all required test-suites for laws for the standard typeclasses. Unfortunately, I'm not aware of such library for hedgehog so it's unavoidable that we will have all these warnings...

We can use HLint ignore pragmas to not yell on these particular cases :slightly_smiling_face:


Update aws-java-sdk-dynamodb to 1.12.632

About this PR
📦 Updates com.amazonaws:aws-java-sdk-dynamodb from 1.11.1034 to 1.12.632
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-dynamodb" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #531.


Update ASP.NET Core diagnostics documentation

Fixes #3256 (as far as we need to).

Thanks for the LGTM - I'm just running the snippet tests locally to check they still pass before merging.

Hmm... the LogsInformation test isn't working, and I don't know why. Will investigate.

Logs_Information2 is broken too... at least when running on my machine. Will see whether they were already broken before, which could be a different matter... (Will do this all tomorrow though.)

The test passed this morning... I was messing with my configuration quite a bit yesterday, so I suspect I may have been in the wrong window without the right credentials. Merging.


Add getting started for Jetson TX1

New getting started guide for the TX1. Also update the flashing instructions to include the step of preparing with the latest version of JetPack.
Change-type: patch
Fixes #686 and #696

@imrehg yes, I think you are correct. Won't release this yet. I was living in the future

@imrehg TX1 is released now, could I get another review?

Added in #821


Very slow response from LLM (tested with OpenAi and Google)

Hi,
i really like the capability of this implementation, but in my case the LLM takes always between 10 - 15 seconds to answer. When calling the llm directly I am down to 1 sec or slightly under.
Contrary, when home assistant can take the call it is lightning fast (under 500ms). Is there a way to tweak the timeout? 10 seconds is painfully long when waiting for an answer or a smarthome action…

Due to Home Assistant implementing this functionality internally, I will no longer be maintaining this. Sorry


Upgrade tesseract to 4.1.1

Don't merge this until its tested and ready for immediate release (on various configs including legacy AVX unsupported CPUs)
Side effect of this upgrade - all users will be required to use latest version of WFInfo (9.3.4?), as old dlls will be deleted from master branch upon merge. Ideally we will want to consider moving away these dlls to another location outside of github to avoid such breaking changes.

Upgrade upstream tesseract to 4.1.1 (refer to this for changelog)
Upgrade dotnet tesseract wrapper to 4.1.1 (refer to this for changelog)
Update leptonica to 1.80 (required transitive dependency)
Add cleanup script for old dlls to avoid conflicts

How to test while its in PR stage:

Checkout to this branch
"Clean WFInfo", "Rebuild WFInfo", launch WFInfo, see if it loads fully without crashes, try to process some valid warframe image (perhaps via debug Shift + Activation key)

PS: The rollback to older version of WFInfo will require manual deletion of tesseract4 folder (or dlls inside of it)

Changed the location of libs, no longer requiring any manual changes to test it.

Build without errors and confirmed by running some reward screen and inventories at it. No issues with the code, waiting for korean translation to finalize to merge.

Finally got around to applying the KO branch changes. It compiled, and ran from scratch perfect here. I'm green lighting it.

Pls don't merge it, I want it to use our libs branch for future upgrades/more langs.

Ah, I knew I was missing something thanks for reminding me


🐞[Bug]: improve the PR comment workflow text:

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Wants to improve the welcome text of pr comment  to get more engaging and polished message  commented when a pr is created.
Expected behavior
To get  more engaging and polished welcome message for a pull request (PR) comment:
Add ScreenShots
No response
What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Anshika14528 Thanks for opening!
FYI, If you have opened issues, please tag @me or @Anishkagupta04 to get it assigned to you

ok


Getting "Cannot read property 'initialize' of undefined"

I notified when integrating this module to my xcode project, it gives me some warnings:

Did anyone experience similar issue?
Running on RN 28 and testing with your example code

+1

I'll take a look sometime tonight.
I haven't upgraded support to RN 0.28 as the project we are working on had major issues with that release (outside of this library). We are currently running on RN 0.25.1.
Will keep you posted.

Yeah, there are breaking API changes between those two releases (RN 0.25 and RN 0.28).
That would explain the deprecation warnings. I will migrate those to the new RCTEventEmitter class in a new release that supports 28+. They should probably still work in RN 28, but I'll need to update them moving forward.
@BigPun86 or @mcliquid  WRT the undefined error, how are you importing socketio?
I need to re-read the documentation that I have. The previous project (that appears to be dead) that I forked this from (spiritually, not an actual fork), had that original ios example. It's likely not working so I'll need to fix that up as well.
For now, this is how I include socketio and have it working on RN 25:
let io = require('react-native-socketio');
let socket = new io(url, socketioOptions);
socket.connect();

Let me know if that gets you past the undefined problem.
There are a few issues with the packager with RN 28.
https://github.com/facebook/react-native/issues/8297
https://github.com/facebook/react-native/issues/8409

I can confirm this is broken with the latest RN (0.32). Does anyone have a fix?
In the meantime, I'd suggest a big warning on the README so people don't waste their time.

I am getting the this.socket undefined with react native 0.32

I am getting the this.socket undefined with react native 0.31

I am getting the this.socket undefined with react native 0.37.0

I am getting the this.socket undefined with react native 0.37.0
Answer：
I forgot change getPackages on MainApplication.java
README.md 3.Register module (in MainActivity.java)    is error!!!
is should change to:  3.Register module (in MainApplication.java)
@gcrabtree hope help

i'm getting this issue in react-native 0.42 in iOS only

The same. Error on iOS
I tried 0.39.2, 0.40.0, 0.41.0, 0.42.3 and this bug still exist.

TypeError: Cannot read property 'initialize' of undefined
at new Socket (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:68738:13)
at GameLobby.createLobbySocket (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:69173:12)
at GameLobby.componentWillMount (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:69040:37)
at http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:19500:24
at measureLifeCyclePerf (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:19117:8)
at ReactCompositeComponentWrapper.performInitialMount (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:19499:1)
at ReactCompositeComponentWrapper.mountComponent (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:19378:13)
at Object.mountComponent (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:17462:29)
at Object.obj.(anonymous function) [as mountComponent] (eval at initialize (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:34422:1), :1217:27)
at Constructor.mountChildren (http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:18389:32)

who can fix this problem???

+1

any update on this issue???

@gogulanareshkw no.

Is there really a need to still be using this library? If you're running the latest RN version you can just use socket.io-client without any issue.
yarn add socket.io-client
import SocketIOClient from 'socket.io-client';

const socket = new SocketIOClient('your_domain', {
   transports: ['websocket']
});

socket.connect();

socket.on('connect', () => {
   console.log('connected!');
});


GET /oauth2/login?code=xxxx 401, login failed. Now what?

The middleware is redirecting me to ADFS. I authenticate, and get sent back to my redirect URI with a ?code=xxxxxxx appended. Then... nothing. I just get a Login Failed message. Looking at the source I suppose this is coming from the authentication flow in django-auth-adfs views.py. Because user = authenticate(authorization_code=code) returns None (verified by tweaking views.py to print user to the console), a 401 is returned with the Login Failed error message.
I guess I don't really understand what's supposed to happen at this point. There aren't any users in my auth_user table, but I was under the impression django-auth-adfs would create them on the fly.
I also seem to remember seeing claims being printed out in the server console in earlier tests... now I don't even see those coming across.
What could be the missing link?

Could you enable debug logging an put the output in a gist or so? Along with the relevant parts of settings.py. That'll help in troubleshooting where it goes wrong.
Enabling debug is documented here: http://django-auth-adfs.readthedocs.io/en/latest/troubleshooting.html

Figured it out. This crucial bit was missing from settings.py.
AUTHENTICATION_BACKENDS = (     'django_auth_adfs.backend.AdfsBackend', )
Prior to inserting that, I didn't get anything useful out of debug. All I saw was the 401, Login Failed, and the code being sent in query parameters to /oauth2/login. After adding the authentication backend bit, debug helped me spot an invalid issuer setting. Fixed it, and everything is working fabulously.
I was so caught up in double and triple checking these settings that I forgot to verify the fundamental installation requirements.

😄 That is indeed a rather important setting.
Glad you got it working.
Do you think there are things missing in the documentation that could have helped you in resolving the issue?

Mostly tunnel vision on my part. But I think one thing that tripped me up was this line on the ADFS Configuration page:

If you followed this guide, you should end up with a configuration like this.

AUTH_ADFS = {
    "SERVER": "adfs.example.com",
    "CLIENT_ID": "django_website.adfs.client_id",
    "RESOURCE": "django_website.adfs.identifier",
    "AUDIENCE": "microsoft:identityserver:django_website.adfs.identifier",
    "ISSUER": "http://adfs.example.com/adfs/services/trust",
    "CA_BUNDLE": False,
    "CLAIM_MAPPING": {"first_name": "given_name",
                      "last_name": "family_name",
                      "email": "email"},
    "USERNAME_CLAIM": "winaccountname",
    "GROUP_CLAIM": "group"
    "REDIR_URI": "http://webserver.example.com/oauth2/login",
}

That had me thinking, oh, if all those settings are correct, what else could possibly be wrong? Something like "if you've verified these settings are are still encountering problems, 1) enable debugging, and 2) verify that all of the configuration items in the Installation Guide are present and properly configured" would have been helpful.
But it's still embarrassing on my part :)
Quick question that's probably a separate issue: if I wanted to send additional claims (e.g. employee number, department, title, that sort of thing) and affiliate them with the Django auth user that your package creates and authenticates, how would you recommend that I go about doing that? I've seen several guides for extending the vanilla Django auth user model, but what would be the best way to streamline the process with django_auth_adfs?

I'll see what I can do to expand documentation for this.

It's been added, sort of, to a new FAQ section of the docs.
https://django-auth-adfs.readthedocs.io/en/latest/faq.html


Smoke and CO?

I know there is a generic smoke detector that triggers if the alarm detects fire. However, if I setup a zone for my smoke and CO zone #s, even though it'll show up as a contact sensor, will it properly report smoke/CO?

Are you referring to Smart Home Monitor as the reporting system?

Pretty much, except Hubitat not SmartThings. Basically I want my Hubitat to send me an alert like "Fire detected Upstairs" but how do I know which smoke detector detected smoke? My thought was if I made the AlarmDecoder Service look at my 3 zones for smoke detectors, then the contact would "open" if there is a fire so I could detect which zone trigger the smoke/CO detection. Would that actually work?

I am testing this idea. It's a good idea if it works. May take some tweaks
but it would solve a lot of problems. Not just SHM or HSM some things only
as you noted look at specific device types.
Best
Sean M
On Tue, Jul 30, 2019, 7:45 PM dcmeglio<EMAIL_ADDRESS>wrote:

Pretty much, except Hubitat not SmartThings. Basically I want my Hubitat
to send me an alert like "Fire detected Upstairs" but how do I know which
smoke detector detected smoke? My thought was if I made the AlarmDecoder
Service look at my 3 zones for smoke detectors, then the contact would
"open" if there is a fire so I could detect which zone trigger the smoke/CO
detection. Would that actually work?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nutechsoftware/alarmdecoder-smartthings/issues/33?email_source=notifications&email_token=AAPSWFBKEP2LIFQ442IQTV3QCD4ENA5CNFSM4IHXZXBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3F4PZA#issuecomment-516671460,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSWFG6W35RM7ZV6H7YHYDQCD4ENANCNFSM4IHXZXBA
.

That'd be cool. I'm fine hacking up the code to make it a different device type (I already did that for my motion detectors) -- what I wasn't sure was, would the app receive what essentially amounts to a zone open/close if a fire/CO is detected? I can add some sendEvent logic to make it send a smoke event instead of a contact event, just don't know if the Ademco would send smoke/CO in a way the app would detect.

I need to brain on this so please help me find a good method. I like the
idea of being able to just change the code for the device in the graph
page. Seems easy and AFAIK would also work on Hubitat? The trick will be
that each device type needs a different type of event sent. As you noted
clear/smoke? is sent to this device type. As apposed to open/close for
contacts.
If it were able to know what type of device exists at that address then we
could modify the message to match. That would allow easy path for changing
one of the virtual zone devices to what is most appropriate.
Best
SM
On Wed, Jul 31, 2019 at 7:33 PM dcmeglio<EMAIL_ADDRESS>wrote:

That'd be cool. I'm fine hacking up the code to make it a different device
type (I already did that for my motion detectors) -- what I wasn't sure
was, would the app receive what essentially amounts to a zone open/close if
a fire/CO is detected? I can add some sendEvent logic to make it send a
smoke event instead of a contact event, just don't know if the Ademco would
send smoke/CO in a way the app would detect.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nutechsoftware/alarmdecoder-smartthings/issues/33?email_source=notifications&email_token=AAPSWFGZMYNO5MNTRKRXCELQCJDOFA5CNFSM4IHXZXBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3JDVOA#issuecomment-517094072,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSWFFA4JWPLVYZI7QYKZTQCJDOFANCNFSM4IHXZXBA
.

I like that idea! What do you think of this... In hubitat and SmartThings the device object has a .hasCapability(). So we can check does it have switch does it have smoke, etc. and then we can trigger the correct event.
https://docs.hubitat.com/index.php?title=Device_Object
https://docs.smartthings.com/en/latest/ref-docs/device-ref.html#hascapability
What do you think?

This sounds perfect! I am finishing up a big update to the webapp and then will cycle back into ST/HT coded. I have a good list if improvements to dig into now.

Ok easy button I am using the new RFX processing in ST to create a virtual device and testing change device type and tinkering on code.

Just pushed into dev a proof of concept to be tested on HT. Please let me know if you need me to apply that to the HT github repo. I hope to avoid that till this is tested :) AFAIK the code is a directly drop in just change settings.

So I installed the latest code but I don't really know how this RFX stuff works... it's different than the built in 20 zones that get monitored?

Ya sorry it will only work with that commit if you have a 5800 RF
transmitter on your panel and sensors.
I am almost done applying this to all contacts. Hopeful just a few hours
more testing.
On Sat, Aug 3, 2019 at 6:27 PM dcmeglio<EMAIL_ADDRESS>wrote:

So I installed the latest code but I don't really know how this RFX stuff
works... it's different than the built in 20 zones that get monitored?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nutechsoftware/alarmdecoder-smartthings/issues/33?email_source=notifications&email_token=AAPSWFAKCSG77KXNLFIW2WLQCYWA7A5CNFSM4IHXZXBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PYTVY#issuecomment-517966295,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSWFFY6L7SL6HZXBWN4KLQCYWA7ANCNFSM4IHXZXBA
.

Great, I'd be happy to test when it's ready

Ok did a bunch of testing and it "seems" to be solid. Setting off fire, alarms, arming disarming while I change device types to see if it does as expected. I am pre sending some events such as "Smoke" translated to On such that for a contact it would e "Open" when On by default. Inverting it as needed for specific applications is now just a toggle of the invert option.

It didn't work with Hubitat because of the invert which was trying to access settings. Hubitat doesn't support that. I also came up with a way to set the HSM/SHM automatically. You still have to comment the physicalgraph stuff, but one less manual step now... Also, I added virtual motion, shock, and CO detectors using the new functionality you added. This let me add my motion, glass break, and carbon monoxide detectors too.

Sorry some more changes but I "think" they were trivial and I did not touch any HT/ST specific code. Should be pushing to master any moment now.


Add scl property to osl_repos_centos

This allows adding the scl repos which is needed on some EL7 cookbooks.
This is related to https://github.com/osuosl-cookbooks/osl-postgresql/pull/47
Signed-off-by: Lance Albertson<EMAIL_ADDRESS>

!bump minor ~

Jenkins has merged this PR into master and has automatically performed a minor-level version bump to v4.4.0.  Have a nice day!


Feature/cu 1ej4pk6 animated door level2

New obstacles added in the map for the objects Laser Railing Big 1 and Grille Door.
Changed material of Laser Railing Big 1 from Unlit to Unlit Dissolve.
Added new fbx, animations and prefab for GrilleDoor.
New Script BridgeDoorButton that opens the bridge door and the laser door situated in front of the button (the button is the sphere collider that you can see in the image attached below). Works very similarly to the Noodle Shop script from level 1.

TestScene: Level2_TestDoor

Task linked: CU-1ej4pk6 Animated door opening level 2

Can't get the door to open.

Can you try again? I created a new material with the dissolve and applied it to the laser door.

Since some changes are being requested, I'll add another small nuisance: The obstacle width of the door should be increased to 3.75, to have a smooth "wall"


arkade: 0.8.16 -> 0.8.18

Description of changes
https://github.com/alexellis/arkade/releases/tag/0.8.18
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 166606 run on aarch64-darwin 1

1 package built:

arkade


Section will be snapped even if section height is larger than viewPort

Surprisingly it will snap to the second section even if the current section is larger than view port and the second section is not in view! So assuming -> is a section and x indicates which section is viewed
1-> x
2->
If I scroll down but still stay within 1's view port it'll snap to section 2
1->
2-> x
Also if scrolled amount is less than directionalThresh it will snap back to the top of the section (so content at the bottom of a section can never be viewed if it's larger than viewPort). I tried modifying the library to support sections bigger than view port but no luck yet.

Actually found the issue (line 208: getPanelsInViewPort):
      var viewport = { top: self.$snapContainer.scrollTop() };
      viewport.bottom = viewport.top + self.$snapContainer.height();

That is wrong. It get's all the panels in container from top viewport to bottom of the container instead of viewport. I suggest replacing that with this:
      var viewport = { top: $(window).scrollTop() };
      viewport.bottom = viewport.top + $(window).height();

Actually, it's not that easy, the plugin can run on other elements in the document as well. I'll have a look at it later today.

Are you sure? As the variable name suggests I thought viewport is the section in view. That will get exactly the top and bottom of the section in view.

Yes that's true. But your solution doesn't work when you initialise it on a div instead of body. that's what the scrollContainer variable if for.

ah I see my bad, I totally forgot this plugin is awesome enough to work on any container. So we'll need to grab min(viewTop,containertop) and max(viewBottom,containerBottom)

It would be great if the plugin would also snap to the bottom of panels that are larger than the viewport/container. So basically if the panel is as high as the viewport/container, snap like it normally does (to the top) ... but if the panel is taller than the viewport/container, it should have two snap points, one at the top of the panel and one at the bottom.
Assuming there are two panels containing a large amount of content, and both are taller than the viewport/container.
When scrolling from panel 1 to panel 2, the scrolling will first snap to the top of Panel 1 (first snap point), then scroll normally until close to the bottom of panel 1, then snap to the bottom of panel 1  (second snap point). If the user continues scrolling, then scrolling would snap to the top of panel 2.
When scrolling back up from panel 2 to panel 1, the scrolling would snap to the bottom of panel 1, instead of scrolling all the way to the top of Panel 1. Also if there are two snap points for larger panels, a user will be able to scroll to the bottom end of Panel 1, before moving onto the top of panel 2.

Here's a pen derived from the panel snap demo to illustrate the issue. Its almost impossible to keep the bottom of the top two panels in view, let alone click/tap the links at the bottom of the panels.
Also, when navigating back from panel 2 to panel 1, instead of snapping to the bottom of panel 1 first, it snaps all the way to the top of panel 1.
http://codepen.io/anon/pen/yeZZgw

Thanks @Smashr, that's a painfully accurate point Your making. This issue is actually turning into a feature overhaul.


Avoid renaming .love files to .zip

It seems butler is smart enough to realize the .love file I uploaded is already a zip file, so it doesn't bother to compress it again. However, it does replace the .love extension with .zip, which means that GUI users can't just double-click on it to run it.

(Hey @technomancy :) been a while since I used leiningen / did Clojure but I really appreciated it back then! until I strayed from the beaten path and then switched companies altogether).
Uploading .love (or .jar) files as file hierarchies is actually an unintended feature - fixing the bug (only treating files with the .zip extension as archives) would drop the feature (& generate big patches between compressed data).
I'm still thinking of clean ways to fix that. The generated patch file could have the original file extension in its header, and that could instruct the backend to know which archive type to generate (see #48 - we can't assume the backend will always generate a .zip).

I see; well, good to know. I'll continue uploading .love files by hand till that gets sorted out then; thanks!

@technomancy Actually I guess we'll have to do without the unintended feature for now. Have you tried pushing a folder containing the .love file? Diffing compressed files will probably have poor results, but it is worth a try..


Implement the testbed for file transfer

Hi,
I follow the instructions from https://github.com/lucas-clemente/quic-go/tree/gquic to implement quic-go. I use quic-go as the server and quic_client from chromium as the client.
Server: go run example/main.go -www /var/www/
Client: quic_client --host=<IP_ADDRESS> --port=443 --v=1 https://vanvantong.tk
However, I got the error:
Failed to connect to <IP_ADDRESS>:443. Error: QUIC_NETWORK_IDLE_TIMEOUT
This is the log of client:
_0412/181012.920603:VERBOSE1:quic_simple_client_bin.cc(219)] server host: <IP_ADDRESS> port: 443 body:  headers:  quiet: 0 quic-version: -1 version_mismatch_ok: 0 redirect_is_success: 1 initial_mtu: 0
[0412/181012.921322:VERBOSE1:quic_simple_client_bin.cc(255)] Resolved <IP_ADDRESS> to <IP_ADDRESS>:443
[0412/181012.923916:VERBOSE1:quic_connection.cc(389)] Client: Created connection with connection_id: dde4496ad63b9609 and version: QUIC_VERSION_46
[0412/181012.924275:VERBOSE1:quic_flow_controller.cc(54)] Client: Created flow controller for stream 0, setting initial receive window offset to: 15728640, max receive window to: 15728640, max receive window limit to: 25165824, setting send window offset to: 16384
[0412/181012.924445:VERBOSE1:http2_frame_decoder_adapter.cc(176)] Http2DecoderAdapter ctor
[0412/181012.924627:VERBOSE1:quic_flow_controller.cc(54)] Client: Created flow controller for stream 1, setting initial receive window offset to: 6291456, max receive window to: 6291456, max receive window limit to: 16777216, setting send window offset to: 16384
[0412/181012.925051:VERBOSE1:quic_flow_controller.cc(54)] Client: Created flow controller for stream 3, setting initial receive window offset to: 6291456, max receive window to: 6291456, max receive window limit to: 16777216, setting send window offset to: 16384
[0412/181012.925736:VERBOSE1:quic_crypto_handshaker.cc(24)] Client: Sending CHLO<
SNI : "vanvantong.tk"
VER : 'Q046'
CCS : 0x01e8816092921ae87eed8086a2158291
PDMD: 'X509'
SMHL: 0x01000000
ICSL: 600
NONP: 0x814b75e8a2b40ba32f67f5fd8a454d876b4d5a88b95a6cba8ff13c9f4a84d7d2
MIDS: 100
SCLS: 1
CSCT: 0x
CFCW: 15728640
SFCW: 6291456

[0412/181012.926057:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 0: type { STREAM_FRAME } { stream_id: 1, fin: 0, offset: 0, length: 1024 }
[0412/181012.926149:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 0: type { PADDING_FRAME } { num_padding_bytes: -1 }
[0412/181012.926235:ERROR:quic_versions.cc(59)] Invalid HandshakeProtocol: 0
[0412/181012.926199:VERBOSE1:quic_framer.cc(2130)] Client: Appending IETF header: { destination_connection_id: dde4496ad63b9609 (present), source_connection_id: dde4496ad63b9609 (absent), packet_number_length: 4, reset_flag: 0, version_flag: 1, version: 0, long_packet_type: INITIAL, packet_number: 1 }
[0412/181012.926565:VERBOSE1:quic_connection.cc(2424)] Client: Sending packet 1 : data bearing , encryption level: ENCRYPTION_INITIAL, encrypted length:1350
[0412/181012.927196:VERBOSE1:quic_connection.cc(2530)] Client: time we began writing last sent packet:<PHONE_NUMBER>
[0412/181012.927558:VERBOSE1:quic_flow_controller.cc(102)] Client: Stream 1 sent 1024 bytes.
[0412/181012.927601:VERBOSE1:quic_stream.cc(954)] Client: stream 1 sends 1024 bytes  and has buffered data 0 bytes. fin is sent: 0 fin is buffered: 0
[0412/181013.076738:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { STREAM_FRAME } { stream_id: 1, fin: 0, offset: 0, length: 1024 }
[0412/181013.076786:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { PADDING_FRAME } { num_padding_bytes: -1 }
[0412/181013.076884:ERROR:quic_versions.cc(59)] Invalid HandshakeProtocol: 0
[0412/181013.076822:VERBOSE1:quic_framer.cc(2130)] Client: Appending IETF header: { destination_connection_id: dde4496ad63b9609 (present), source_connection_id: dde4496ad63b9609 (absent), packet_number_length: 4, reset_flag: 0, version_flag: 1, version: 0, long_packet_type: INITIAL, packet_number: 2 }
[0412/181013.077112:VERBOSE1:quic_connection.cc(2424)] Client: Sending packet 2 : data bearing , encryption level: ENCRYPTION_INITIAL, encrypted length:1350
[0412/181013.077232:VERBOSE1:quic_connection.cc(2530)] Client: time we began writing last sent packet:<PHONE_NUMBER>
[0412/181013.077306:VERBOSE1:quic_crypto_stream.cc(316)] Client: stream 1 is forced to retransmit stream data [0, 1024), with encryption level: 0, consumed: bytes_consumed: 1024 fin_consumed: 0
[0412/181013.377258:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { STREAM_FRAME } { stream_id: 1, fin: 0, offset: 0, length: 1024 }
[0412/181013.377345:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { PADDING_FRAME } { num_padding_bytes: -1 }
[0412/181013.377424:ERROR:quic_versions.cc(59)] Invalid HandshakeProtocol: 0
[0412/181013.377367:VERBOSE1:quic_framer.cc(2130)] Client: Appending IETF header: { destination_connection_id: dde4496ad63b9609 (present), source_connection_id: dde4496ad63b9609 (absent), packet_number_length: 4, reset_flag: 0, version_flag: 1, version: 0, long_packet_type: INITIAL, packet_number: 3 }
[0412/181013.377608:VERBOSE1:quic_connection.cc(2424)] Client: Sending packet 3 : data bearing , encryption level: ENCRYPTION_INITIAL, encrypted length:1350
[0412/181013.377750:VERBOSE1:quic_connection.cc(2530)] Client: time we began writing last sent packet:<PHONE_NUMBER>
[0412/181013.377795:VERBOSE1:quic_crypto_stream.cc(316)] Client: stream 1 is forced to retransmit stream data [0, 1024), with encryption level: 0, consumed: bytes_consumed: 1024 fin_consumed: 0
[0412/181013.977725:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { STREAM_FRAME } { stream_id: 1, fin: 0, offset: 0, length: 1024 }
[0412/181013.977780:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { PADDING_FRAME } { num_padding_bytes: -1 }
[0412/181013.977831:ERROR:quic_versions.cc(59)] Invalid HandshakeProtocol: 0
[0412/181013.977806:VERBOSE1:quic_framer.cc(2130)] Client: Appending IETF header: { destination_connection_id: dde4496ad63b9609 (present), source_connection_id: dde4496ad63b9609 (absent), packet_number_length: 4, reset_flag: 0, version_flag: 1, version: 0, long_packet_type: INITIAL, packet_number: 4 }
[0412/181013.977973:VERBOSE1:quic_connection.cc(2424)] Client: Sending packet 4 : data bearing , encryption level: ENCRYPTION_INITIAL, encrypted length:1350
[0412/181013.978066:VERBOSE1:quic_connection.cc(2530)] Client: time we began writing last sent packet:<PHONE_NUMBER>
[0412/181013.978102:VERBOSE1:quic_crypto_stream.cc(316)] Client: stream 1 is forced to retransmit stream data [0, 1024), with encryption level: 0, consumed: bytes_consumed: 1024 fin_consumed: 0
[0412/181015.178098:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { STREAM_FRAME } { stream_id: 1, fin: 0, offset: 0, length: 1024 }
[0412/181015.178147:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 1: type { PADDING_FRAME } { num_padding_bytes: -1 }
[0412/181015.178219:ERROR:quic_versions.cc(59)] Invalid HandshakeProtocol: 0
[0412/181015.178184:VERBOSE1:quic_framer.cc(2130)] Client: Appending IETF header: { destination_connection_id: dde4496ad63b9609 (present), source_connection_id: dde4496ad63b9609 (absent), packet_number_length: 4, reset_flag: 0, version_flag: 1, version: 0, long_packet_type: INITIAL, packet_number: 5 }
[0412/181015.178407:VERBOSE1:quic_connection.cc(2424)] Client: Sending packet 5 : data bearing , encryption level: ENCRYPTION_INITIAL, encrypted length:1350
[0412/181015.178570:VERBOSE1:quic_connection.cc(2530)] Client: time we began writing last sent packet:<PHONE_NUMBER>
[0412/181015.178604:VERBOSE1:quic_crypto_stream.cc(316)] Client: stream 1 is forced to retransmit stream data [0, 1024), with encryption level: 0, consumed: bytes_consumed: 1024 fin_consumed: 0
[0412/181016.923957:VERBOSE1:quic_connection.cc(3122)] Client: last packet<PHONE_NUMBER> now:7452365530 idle_duration:3997309 idle_network_timeout: 4000000
[0412/181016.924007:VERBOSE1:quic_connection.cc(3145)] Client: connection time: 3999823 handshake timeout: 10000000
[0412/181016.926691:VERBOSE1:quic_connection.cc(3122)] Client: last packet<PHONE_NUMBER> now:7452368271 idle_duration:4000050 idle_network_timeout: 4000000
[0412/181016.926717:VERBOSE1:quic_connection.cc(3130)] Client: No recent network activity.
[0412/181016.926747:VERBOSE1:quic_connection.cc(2980)] Client: Closing connection: dde4496ad63b9609, with error: QUIC_NETWORK_IDLE_TIMEOUT (25), and details:  No recent network activity.
[0412/181016.926798:VERBOSE1:quic_connection.cc(3005)] Client: Sending connection close packet.
[0412/181016.926896:VERBOSE1:quic_packet_creator.cc(845)] Client: Adding frame with transmission type 0: type { CONNECTION_CLOSE_FRAME } { error_code: 25, error_details: 'No recent network activity.', frame_type: 0}
[0412/181016.927009:ERROR:quic_versions.cc(59)] Invalid HandshakeProtocol: 0
[0412/181016.926961:VERBOSE1:quic_framer.cc(2130)] Client: Appending IETF header: { destination_connection_id: dde4496ad63b9609 (present), source_connection_id: dde4496ad63b9609 (absent), packet_number_length: 4, reset_flag: 0, version_flag: 1, version: 0, long_packet_type: INITIAL, packet_number: 6 }
[0412/181016.927113:VERBOSE1:quic_connection.cc(2424)] Client: Sending packet 6 : data bearing , encryption level: ENCRYPTION_INITIAL, encrypted length:64
[0412/181016.927259:VERBOSE1:quic_connection.cc(2530)] Client: time we began writing last sent packet:<PHONE_NUMBER>
[0412/181016.927344:VERBOSE1:quic_connection.cc(3049)] Cancelling all QuicConnection alarms.
Failed to connect to <IP_ADDRESS>:443. Error: QUIC_NETWORK_IDLE_TIMEOUT
[0412/181016.927599:VERBOSE1:quic_stream.cc(261)] Client: Stream 1 gets destroyed while waiting for acks. stream_bytes_outstanding = 1024, fin_outstanding: 0_
Is the problem results from the version mismatch of quic-go and quic_client? How could I resolve this issue?
Thank you in advance.

The quic_client is trying to use QUIC v46, which isn't supported by quic-go.

Hi Marten Seemann,
Thank you for your response.
Is there any branch of quic-go supporting QUIC v46?

No, we don’t support that version.


[doc] fpga reproduce fail

This commit adds '--' to two of the commands to make them execute as intended.

@engdoreis do we want to change these docs to use --interface=hyper340 or leave them on cw340?

@engdoreis do we want to change these docs to use --interface=hyper340 or leave them on cw340?

I think that this doc should have the cw340 for now, the hyper340 would require extra steps which are not documented yet.

CI failures unrelated.


fix: handle reveal_force_cwd correctly when cwd doesn't need to change

This PR fixes a bug where the tree will not open if reveal_force_cwd is given but the cwd doesn't need to change. i.e. the cwd is already a parent of the file being revealed. As you can see from the changes, the bug was just caused by an if branch being taken and then not doing anything.
I've added a unit test for this case and also tested manually.

Thanks!


XMLBasket with discounts (extension of PR #50)

I've fixed an empty basket issue in PR #50 and added some tests.

Just had a thought - probably needs some tests for negative item prices, to show them appearing as discounts. I'll try and get those in before creating a release.

Thank you so much. This is brilliant. I appreciate it.
Thank you once again
Denise

Hi @judgej - any chance of a version bump so we can start using this via composer?

Not sure if this should be a patch release (2.2.1) or a point release (2.3.0). It is just new functionality, so should not affect people not using it. However, there could be systems that are passing the basket in anyway, not expecting it to actually work.
I vote for 2.3.0 - it's not as though we are going to run out of version numbers quickly. It just highlights that functionality may change without the merchant site doing anything differently. Agree?

Agreed - 2.3.0 makes most sense as it should count as additional functionality.


Replacing font awesome with inline svg

Font awesome is good but oni does not use all of it awesomeness wouldnt it be better if we could use https://dmfrancisco.github.io/react-icons/  instead of font awesome reducing file size

I'm open to a replacement - I'm sure there are better icons too for the completion than the ones I chose from fontawesome! It looks like the react-icons project has a pretty small set of icons, though.
I saw this project: http://fontello.com/
This has a compilation of icons across projects, and let you build a font that only includes the icons you need - looks pretty cool

Looking at this again - I'm closing for now, since there isn't a clear benefit to switching at this time. The file size isn't our current "bottleneck" for our package size. If someone is up for taking a pass at this, though, it would be awesome to have a more refined set of SVGs eventually.


Implement uploading image file

Please ignore the lint errors for the new java codes for this PR. I will create another branch for fixing all the lint errors for all the java codes.


Lack of installation documentation

I have unfortunately been unable to find any documentation on how to build/install this.  If someone could rectify this, even if it's just 5 lines in the README, that'd be great.

Thanks for raising this @tnelson-doghouse
You're right, it's very thin on the ground, sorry about that. I'll get something added!

Other thoughts:

It'd be cool if the installation worked with the Postgres Package manager (see https://github.com/petere/pex ).
Note that this would also involve getting a 5-line config file added to https://github.com/petere/pex-packages .
To make it work with pex, it would have to be compilable by the 10 or so lines following https://github.com/petere/pex/blob/04bf747cd97e8c05167891e8b4c639f0735c6216/pex#L737 (ie. basically ./configure && make all && make install, but more complex)

May not be relevant, but hope this helps at some point.


github: workflows: Remove continue-on-error

We want the workflows to fail for these steps, so remove continue-on-error.

Note: I'll wait until https://github.com/zephyrproject-rtos/zephyr/pull/80537 has been merged, and then update west.yml in this PR, since otherwise our merge policy will prevent merging due to the failing checks.

The build fails on windows. Probably I shouldn't removed this snippet:
      if [ "${{ runner.os }}" = "Windows" ]; then
        EXTRA_TWISTER_FLAGS="--short-build-path -O/tmp/twister-out"
      fi

The build fails on windows. Probably I shouldn't removed this snippet:
      if [ "${{ runner.os }}" = "Windows" ]; then
        EXTRA_TWISTER_FLAGS="--short-build-path -O/tmp/twister-out"
      fi

Indeed. That said, do we think it really adds sufficient value to have macOS and Windows in the CI?. I would expect that upstream takes care of testing that the SDK works on all three platforms. That said, if we ever start introducing non-Zephyr SDK dependencies to our CI workflows (say, Commander or JLink), then I think it'd be important to check that the steps still work on all Zephyr SDK supported operating systems.

The failure on Windows is not introduced by this PR. So, I suggest to merge it.

The failure on Windows is not introduced by this PR. So, I suggest to merge it.

I'd have to tweak the repo settings first, since right now it's set so that even an admin can't press the Merge button when there's a failed Check. I went with disabling Windows and macOS instead for now. We can re-enable them later if there's a clear justification for it.


Added Cambridge Dictionary to Dictionary section

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your changes are made in the README file, not the auto-generated JSON
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items

Hi @waqashsn , thanks for the PR. from the website:
If you’d like to apply for an API development key or to request information about licensing data,

please fill in the form below. Fees for the use of Cambridge dictionary data vary depending on which

 data set you wish to use and how you wish to use it. The information we ask for in this form will help

us assess the opportunity and tailor a proposal to your needs.

Could you please confirm whether or not there is a free tier available with this service? Thanks.

I checked in detail. They do not provide free tier. I am sorry. They provide free trial, I confused it with free tier.


fix daemonize

In order to become it's own session leader and fully detach from the controlling terminal a daemon must call setsid() in between invocations of fork().
This also incorporates the fixes from #11

Thank yoiu


Fix package complete exemple

Adding missing configuration for package sample 'packageMode : true'
Changes

Fix Complete Example (Testing a Package)

Checklist

[x ] Read the contribution guide and accept the
code of conduct
[x] Readme (updated or not needed)
[x ] Tests (added, updated or not needed)

thanks!


New Weapon Skin Porphyrophobia is missing

Weapon skin Porphyrophobia from the new halloween event is missing.

See v1.2.2: https://github.com/FromDarkHell/BL3ProfileEditor/releases/tag/v1.2.2


Colors broken on HA 2022.12+

state colors have changed and no longer match this theme.
Forum post: https://community.home-assistant.io/t/2022-12-color-states-are-broken-unusable/499890
Blog post: https://www.home-assistant.io/blog/2022/12/07/release-202212/#shiny-new-state-colors
Developer Blog: https://developers.home-assistant.io/blog/2022/12/07/entity-color-changes/
Variables now have to be defined like:
state-on-color: var(--rgb-green)
state-off-color: var(--rgb-red)
rgb-state-lock-unlocked-color: var(--state-off-color)
rgb-state-light-color: var(--state-on-color)
rgb-state-switch-color: var(--state-on-color)

I don't think this has been fixed yet, the colors look really washed out right now


Add a new ParserExtra::State: Inspector trait

This allows using imperative concrete syntax tree parsers like rowan and cstree. In particular those libraries want to know every token that is parsed, and need to know when chumsky backtracks and reparses the same tokens again.
This adds the following new API surface:
pub trait Inspector<'a, I: Input<'a>>: Default {
    type SaveMarker: Copy + Clone;
    fn on_token(&mut self, token: &I::Token);
    fn on_save<'parse>(&self, offset: I::Offset) -> Self::SaveMarker;
    fn on_rewind<'parse>(&mut self, marker: Marker<'a, 'parse, I, Self::SaveMarker>);
}
pub struct SimpleState<T>(pub T);
impl<'a, T, I: Input<'a>> Inspector<'a, I> for SimpleState<T>;
impl<T> DerefMut<Target = T> for SimpleState<T>;
impl<T> From<T> for SimpleState<T>;

and additionally now requires ParserExtra::State: Inspector.
i didn't write any of my own tests yet but my own parser that hooks chumsky up to cstree does work: https://github.com/spreadsheet-lang/spreadsheet/commit/1b9731311aa97c1130c76de67966052909c35f75#diff-14962dfdd56397d99e07041d6337cb5b0327f4d7433d80fd3383955415014910R111
Fixes https://github.com/zesterer/chumsky/issues/96

Looks like there are a few minor CI failures

Thanks so much for your work on this, it's very appreciated!


UUID fields are not serialized by .into_json() on queries

Description
Datetime fields are not serialized by .into_json() on queries. Possible duplicate of #530.
Steps to Reproduce

Add UUID in any Model(Entity)
Run into_json query
It will hide the UUID field. If into_json removed field comes back.

Expected Behavior
It should convert UUID to string and should be visible in the final JSON output.
Actual Behavior
The field is missing as explained above.
Reproduces How Often
It can be reproduced every time.
Versions
0.6
Additional Information
#[sea_orm(table_name = "categories")]
pub struct Model {
    #[sea_orm(primary_key)]
    pub id: i32,
    pub api_key: Uuid,
    pub added: DateTime,
    pub updated: DateTime,
}

let db = &data.conn;
let  u = Uuid::parse_str(uuid.as_str()).expect("UUID is required!");
let category = Category::find()
        .filter(categories::Column::ApiKey.eq(u))
        .into_json()
        .one(db)
        .await
        .expect("category not found");

Hey @yashsamit, thanks for the report! It would be fixed on #539


Validator rewrite

Rewrite validator using WTForms
Why

Better suits for form validation
Simplify form rendering

Changelog

Replace Cerberus with WTForms
Cherrypy integration with WTForms sucks
Update test
Small refactorings
Validate additional fields as well

N.B.

Needs testing. A lot of
Should resolve #105

Review request: @webknjaz

ping @webknjaz

basic review done

I'll add logging later. I.E. on weekends.

@webknjaz I've added logging as you requested.

@webknjaz: what's the status of this review?

Submitting completely empty form now (CherryPy 7.1.0) results in exception:
400 Bad Request

Invalid request
In addition, the custom error page failed:
AttributeError: module 'cherrypy._cpcompat' has no attribute 'unicodestr'

Traceback (most recent call last):
  File "/home/wk/src/gdg.org.ua/.env/lib/python3.5/site-packages/cherrypy/_cprequest.py", line 670, in respond
    response.body = self.handler()
  File "/home/wk/src/gdg.org.ua/.env/lib/python3.5/site-packages/cherrypy/lib/encoding.py", line 220, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/home/wk/src/gdg.org.ua/.env/lib/python3.5/site-packages/cherrypy/lib/jsontools.py", line 63, in json_handler
    value = cherrypy.serving.request._json_inner_handler(*args, **kwargs)
  File "/home/wk/src/gdg.org.ua/.env/lib/python3.5/site-packages/cherrypy/_cpdispatch.py", line 60, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/wk/src/gdg.org.ua/src/GDGUkraine/rest_controller.py", line 119, in create
    raise InvalidFormDataError(regform.errors)
GDGUkraine.errors.InvalidFormDataError: (400, 'Invalid request')
Powered by CherryPy 7.1.0

It looks this happens in the line 175 of GDGUkraine.errors module.
You might want to check this https://github.com/cherrypy/cherrypy/commit/74b3698847010e1f0e45f42c4549e7d79d04dbed#diff-e7f19ec238d48a5d2b77ecbbe03850bcR349

The reported issue needs some discussion as it happened due to some architecture decisions.

No, this happened because of internal cherrypy changes. Type you are checking against doesn't exist / had been renamed lately

Take a look at https://github.com/cherrypy/cherrypy/blob/master/cherrypy/_cpcompat.py

Due to pre-commit checks upgrade, you should now sync w/ master as well

Current coverage is 10.76% (diff: 7.23%)

Merging #106 into master will decrease coverage by 0.96%

@@             master       #106   diff @@
==========================================
  Files            19         21     +2
  Lines          1262       1375   +113
  Methods           0          0
  Messages          0          0
  Branches        152        172    +20
==========================================
  Hits            148        148
- Misses         1083       1195   +112
- Partials         31         32     +1

Powered by Codecov. Last update b6c64ca...5592c57

@webknjaz: I've hotfixed the error (fully-acceptable fix require heavy refactor of errors module and beyond).
Check the PR one more time, plz

Should it somehow mark invalid fields visually? Currently I don't see any errors specified explicitly

My guess is that _errors aren't accessible in template scope. But  this needs checking

Currently I don't see any errors specified explicitly

O_o

Should it somehow mark invalid fields visually?

That is how it marks errors now.

@webknjaz  it works in fact, i checked

@anxolerd on the other hand, maybe you should make it red, because it's a bit invisible :smile:

Changelog

Make errors text red: a5434d4
Rewrite participant creation: d42380f
some imports reorganization in errors.py

Now it works for me as well. Still I'd like you to add required attribute to <input>s


Landing page not working

I have added a landing page in docs/_index.md but this is not working. I am using grunt.

This is now fixed in the development branch and will be merged to default very soon, can you try it ?


buildGoModule: be nicer when overrideAttrs clears passthru

Before an overlay in the form of:
package.overrideAttrs (old: {
  passthru = {};
})

would fail evaluation like:
   error: attribute 'overrideModAttrs' missing
   at /nix/store/afwc3m1sm49qq57xjv2hmd7iy4x0j33h-source/pkgs/build-support/go/module.nix:179:20:
      178|     outputHashAlgo = if finalAttrs.vendorHash == "" then "sha256" else null;
      179|   }).overrideAttrs finalAttrs.passthru.overrideModAttrs;
         |                    ^
      180|

Now instead we take the fallback default.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Before an overlay in the form of:
package.overrideAttrs (old: {
  passthru = {};
})

Just out of curiosity why would you apply that overlay?

The complete code puts a static asset into passthru. Since the original package has not passthru, being required to merge it felt unintuitive.


Metrics definition

@pryorda
Hi! Where can I find the definition of all metrics provided by vmware exporter? For example what is the difference between the following cpu usage metrics?
vmware_host_cpu_usage_average
vmware_host_cpu_usage
vmware_host_cpu_usagemhz_average
vmware_host_cpu_used_summation

You can find these metrics from here, then look the document from vmware

Thank you very much.


Shadow mouse pointer with Azure+valgrind

When running xfreerdp with valgrind and connecting to an Azure VM, it seems like the mouse is drawn both client and server side. Perhaps it has to do with the MousePointer channel that we don't implement yet.
This is with last master (ad0de52ab64dbfae8c9436b9e193ac615de3fff8).

@hardening by any chance, is the relative mouse option in use with that setup?
This sounds a lot like it (and with the slowdown coming along with valgrind it would show even more)

ok, this most likely is the relative mouse option and has nothing to do with valgrind iteslf.


Updated aria-label for mute icon/button in example

Issue Type
Bug Report
Component or Pattern Affected
Icon
Expected Behavior
"Mute" as the example aria tag
Current Behavior
"For the win" is the aria tag in the example
Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Library:
Version used:
Browser Name and version:
Operating System and version:
Link to your project:

Fixed by #453


Add about links.json to Language Lead Handbook

It will be the process to fix https://github.com/freeCodeCamp/freeCodeCamp/issues/47309

Actually, it's already there lol


Syntax errors in HTML files silently cause page to fail to load

Short description of the problem:
If the HTML file for a page has a syntax error (a simple one to test is a mismatched closing tag), the page silently fails to appear.
What behavior are you expecting?
A syntax error in the console giving me a hint as to what is wrong.
Steps to reproduce:

ionic start Foo --v2
Replace app/pages/page2.html with the code below (mismatched

)
ionic serve
Try to select Tab 2.
Notice that no error message appears, and that the content does not appear.

<ion-navbar *navbar>
  <ion-title>
    Tab 2
  </ion-title>
</ion-navbar>

<ion-content class="page2">

</ion-content>

Other information: Plunker handles this properly–syntax errors in templates appear in the console.
Which Ionic Version? 2.x
Run ionic info from terminal/cmd prompt:
Your system information:

Cordova CLI: Not installed
Ionic Framework Version: 2.0.0-beta.4
Ionic CLI Version: 2.0.0-beta.24
Ionic App Lib Version: 2.0.0-beta.14
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v5.1.1
Xcode version: Not installed

******************************************************
 Dependency warning - for the CLI to run correctly,
 it is highly recommended to install/upgrade the following:

 Please install your Cordova CLI to version  >=4.2.0 `npm install -g cordova`
 Install ios-sim to deploy iOS applications. `npm install -g ios-sim` (may require sudo)
 Install ios-deploy to deploy iOS applications to devices. `npm install -g ios-deploy` (may require sudo)

******************************************************

I've encountered this too (and filed https://github.com/driftyco/ionic/issues/6253) - looks like the same root cause. I couldn't repro in plunkr so I thought it was just some quirk of my environment, but it looks like it affects others too.

Hello! Would you mind upgrading to beta.6? This issue was fixed in that release! Also, as this issue was fixed in beta.6 i am going to close this issue for now. Thanks!


[FEAT] - Team RBAC use LabelSelector for Cluster & Team

Priority
(Medium) I'm annoyed but I'll live
Description
Currently the Team RBAC uses direct mapping of TeamRoleBinding to Cluster and Team by name.
It should be made possible to set a LabelSelector instead for either referenced resource. This will reduce the configuration effort for the ClusterAdmin and makes RBAC work OOTB for newly onboarded clusters and teams.
Acceptance Criteria:

[x] Add a LabelSelector for Cluster into the TeamRoleBinding CRD #238
[x] Validate per Webhook that only clusterName or clusterSelector is set #238
Make these LabelSectors immutable

Reference Issues
No response

Requirement of LabelSelector for Teams moved to #255


Add css-declaration-sorter

Finally got the time to look into this, I see cssnano 4.0 is on it's way and the monorepo is looking nice!
Think the sorting is safe to put in the default preset, the only conflict I can think of is two identical declaration properties that are in a particular order for fallback. Since the module uses stable sorting identical properties will keep their order in regard to each other so that shouldn't be a problem.
Can't find how external modules are tested, should there be a new test?

Considering that we do some optimisations by replacing the declarations, maybe sorting the declarations should be the last thing we do, rather than the first?

Good idea, I naively added it in alphabetical order. :)

I would prefer that the options key would be consistent with the others, e.g. remove postcss-/cssnano- prefix and camel case the rest. I know it's a slightly different case because it's a custom name but it would be much more preferable to follow the existing format:
http://cssnano.co/guides/presets/#options-syntax
Also I think the tests might be failing due to the new logic so you might need to rebuild them. Sorry, no docs on that right now, I'm thinking that these should be converted over to snapshot tests in time. But you can rebuild by:
babel-node util/rebuildFrameworks.js

Discovered an unhandled promise rejection, it seems like it expects a function where there is none. My module returns a PostCSS plugin that returns a function, just like the other packages by the looks of it.
Getting this error a dozen of times when running util/rebuildFrameworks.js:
TypeError: plugin is not a function
    at initializePlugin (/home/selwyn/codeground/cssnano/packages/cssnano/dist/index.js:44:32)

which is: return Promise.resolve(plugin()(css, result)); in initializePlugin.
Ideas?

Got the plugin is not a function errors away. :)

Well, your plugin affects declaration order within a rule and because the tests are expecting declarations to be in a certain order, you can see why that would fail. Some of the tests do involve testing a plugin with all other plugins loaded. So I think yes, you will have to correct fixtures as I mentioned with the rebuild function, some of them unfortunately are manual, but I wrote them when snapshot testing wasn't available in AVA. I don't really have the patience anymore to convert them.

Thanks for the confirmation @ben-eb! The only two failing tests now are the preset framework tests, running util/rebuildFrameworks.js doesn't do anything. Something I missed?

From the failure it looks like a problem still with the integration tests, could you rebase off master and try running babel-node util/rebuildFrameworks.js again please? 😄

@ben-eb for some reason that worked! ^^

Coverage increased (+0.0002%) to 99.582% when pulling 86fa5b2243d6758ea0876d6ba57a29babcb8df43 on Siilwyn:add-css-declaration-sorter into bf271b910d46c62f45fbaea497f5e5117ce2428b on ben-eb:master.

@Siilwyn Looks like a random failure from AppVeyor, I tried restarting the build and it worked but we have a merge conflict. Could you rebase again please? Then I can merge and ship rc 2 with this & the other PRs. 😄

Roger that, rebased again @ben-eb

Great. Thanks! 👍

🎉


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In 43d6878, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 6411 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in ce72dc3.


Hard-coded minimum bid amount

The bid amount is hard-coded to $25. We should allow it to be modified either via config value or command-line argument.

This has been solved for a while


add WSK to CMS

Any chance to add wsk to Content Management System?
If anyone knows how, please share..
Best regards

This is out of the scope of what we support. You are free to do whatever you want with WSK, including integrate into a CMS project.
Please look for help with this in a support channel for whatever CMS you use.

@Garbee you're right, my bad..sorry, it was not my intention..I'll close this issue.


Responsiveness - ECMPS Screens

Definition of Ready

[ ] Does this meet the INVEST criteria?
[ ] Does this have a clearly defined user?
[ ] Does this have an estimate?
[ ] Does this have acceptance criteria?
[ ] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[ ] Does this have a dev link been provided in the design?
[ ] Is this traceable to a feature, epic, or PI?

User Story
As an ECMPS user, I want the ECMPS screens to be responsive at all resolutions above 1024 px so that I can access all the functionality
Acceptance Criteria
We want to "provide a usable view of ECMPS at all resolutions above 1024 px.
Notes: Need to handle all the ECMPS screens for which responsiveness hasn't been addressed already:
Global View:

ECMPS Home Page
Monitoring Plans Screen
Configurations Screens

Workspace:

Workspace Monitoring Plans Screen
Workspace Configurations Screens

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Is the user story ready to be deployed to the test/staging environments?

PD Meeting: 10.24.2022: Decision to handle 1024 and above


Feature request: Admin view of existing shares

Please consider adding the ability for a person with the admin role assigned to be able to see all "shares" created by users.
In addition if an admin could also delete or modify shares found, that would be helpful.

Hi,
This should be already done see #145.
I was just lazy to create a release from the nightly build, but the nightly be should safe to use currently.

Excellent, thank you for getting back to me!
-Tim
On Sun, Nov 22, 2020 at 4:11 AM Patrik J. Braun<EMAIL_ADDRESS>wrote:

Hi,
This should be already done see #145
https://github.com/bpatrik/pigallery2/issues/145.
I was just lazy to create a release from the nightly build, but the
nightly be should safe to use currently.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bpatrik/pigallery2/issues/204#issuecomment-731719140,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAT4QT2ZGSDIJGWVXPBYAR3SRDIT5ANCNFSM4TVRSQ6A
.


Add Screen.ClearRow() and Screen.ClearColumn()?

In a project I'm making with tcell, I will sometimes want to clear one or more rows, but not the entire screen.
I believe that the way to do that currently would be
width, _ := s.Size()
for y := firstRow; y <= lastRow; y++ {
    for x := 0; x < width; x++ {
        s.SetContent(x, y, ' ', nil, tell.StyleDefault)
    }
}

Would it make sense for functions to clear a whole row and whole column to be added to tcell.Screen?
(I personally only want a function to clear a row, but a clear column function should probably be added if a clear row function is)

I don't think this is specifically needed... the low level Screen API is intended to to provide a minimalist view, for abstracting hardware.  (Clearing a row could be implemented in hardware, but I've yet to see a hardware capability for clearing a column, and the row based approach is unlikely to be worthwhile on modern environments.)

That makes sense. Thanks for explaining :smile:
Closing.


[Feature Request] AI generated code execution request

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[X] Consider asking first in a Discussion.

Motivation
I've tried using your PythonInterpreter from camel.Utilities but  I encountered a limitation in its functionality.
Regrettably it only executes codeblocks also doesn't accomodate execution of functions.
This brings about a conundrum: How will one effectively run the LLM generated code also given it's not persistently saved?
My efforts to manually copy paste code also sometimes lead to inconsistent results at times failing to produce desired outcomes.

Solution
Build a mechanism or utility to save the outputs of LLM powered responses, Furthermore augmenting the ability of PythonInterpreter to execute functions wouuld enhance its usability.
Alternatives
No response
Additional context
No response

Closed by #400


What are the syntax themes of the first and second screenshots ?

I'm sorry but I'm dying to know. :P

:+1: The first is Duo-Tone-Dark, the second is Solarized Light.

Also, what is the third one? It looks like some sort of monokai variant.

I think it's this one: https://atom.io/themes/monokai

Thanks!


Windows taskbar icon right click

Would it be possible to add the list suggested in File > Open recent to the taskbar icon in Windows? Something like Google Chrome has when right clicking:

It would make it a lot faster to open an existing project. Usually I'm working on a front-end and backend app that both have their own workspace/vscode window. Seeing this while right clicking the task bar button would significantly enhance the use of vscode.

/duplicate https://github.com/microsoft/vscode/issues/103161


Use native generators instead of custom iteration methods

Hi, first of all, thanks a lot for building this awesome lib.
I was almost going to implement my own, but I found this and it suits my needs almost perfectly.
The implementation of most functions in this lib is lazy and that's really a good design choice because combinatorics are things just bound to explode in size. However, being forced to consume them in while loops feels a bit outdated.
const cmb = combination([1, 2, 3], 2);
let item;
while((item = cmb.next()) {
  console.log(item);
}

You are probably aware, but JavaScript Generators gives us a more native way of expressing lazy behavior.
I wrote some tiny wrappers around the functions this lib exposes, such as:
import { combination as originalCombination } from 'js-combinatorics';

export default function combination(arr, size) {
  return {
    *[Symbol.iterator]() {
      const cmb = originalCombination(arr, size);

      let item;
      while ((item = cmb.next())) {
        yield item;
      }
    },
  };
}

This way, I can consume it with a for..of loop:
const cmb = combination([1, 2, 3], 2);
for (let item of cmb) {
  console.log(i);
}

Or could even use the spread operator to turn it into an array:
const cmb = combination([1, 2, 3], 2);
const arr = [...cmb];
console.log(arr);

Maybe this could be made built-in. If you are willing to give this a try, I could work on a PR as soon as I have some time off.

Of course I am willing to give it a try!  According to:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator

generators are supported virtually all browsers but IE, which we can ignore now.

https://github.com/dankogai/js-combinatorics/commit/a299e792177357da7707f85c765b5b685d4df712


remove whisper example

Not maintained and whisper.cpp changed, I think it is more worth to add it inside agents in the future

hey, is there a work being done to add it inside of agents?


Use define macro in setup.py

This PR is related to #1117.

I fixed.

LGTM

Do we need to backport it?

@unnonouno This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

No. I removed to-be-backported label.


Error detection in firewalld

My CentOS 7 version that I had didn't have firewalld installed so the ansible script failed.  I updated the common role so that if firewalld is not installed it won't error out if it tries to disable a service that isn't there.

Looks good, thanks!


Alpha-Refine  Problems

您好！您上传的包有问题，无法解压！
https://drive.google.com/file/d/1qOQRfaRMbQ2nmgX1NFjoQHfXOAn609QM/view

Hi, there is no need of unzipping. Pytorch can directly load checkpoints of .pth format.

when we download, we would get .tar file not . pt or . pth
---Original---
From: @.>
Date: Fri, Apr 23, 2021 17:01 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [researchmm/Stark]  Alpha-Refine  Problems (#4)
Hi, there is no need of unzipping. Pytorch can directly load checkpoints of .pth format.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

As I said, please directly use the .pth.tar file rather than unzipping it

thanks
---Original---
From: @.>
Date: Fri, Apr 23, 2021 20:18 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [researchmm/Stark]  Alpha-Refine  Problems (#4)
As I said, please directly use the .pth.tar file rather than unzipping it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Move ironman symbol in chat 3 pixels down

From: https://www.reddit.com/r/2007scape/comments/8gf4ya/suggestion_move_the_ironman_helmet_3_pixels_down
Since Jagex probably won't do this, and it isn't OP, this could be implemented by us.

Looks like we cant easily do this (as the symbol is tied to chat node)


Feature/pw/gradebook get staff

Return staff membership for a gradebook. The data returned is de-normalized from what is returned by the LMod Web service.  Due to the comprehensive amount of data returned, a 'simple' parameter is available to return less data.
This PR includes the implementation of GradeBook.get_options() since it may be a dependency of get_staff()
Not ready for review.  @carsongee @pdpinch @Ferdi

Coverage remained the same at 100.0% when pulling cfcbdf955eed557ac3d72118508bdb260b35cc26 on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

Coverage decreased (-1.09%) to 98.91% when pulling 2ed76cc68a4090da505846291cb2a5ebaf22c197 on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

Coverage remained the same at 100.0% when pulling 9472f97cb73fd98b29f510d1ddb94762d40903cf on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

Coverage remained the same at 100.0% when pulling 5f1cf26d85f32465433ced35d5cb05bb11072efd on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

This PR is ready for review.  @carsongee @pdpinch

Coverage decreased (-0.15%) to 99.85% when pulling 1ec798d2f2507700d477c98208a7cd0e2a69bf5a on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

@carsongee @pdpinch ready for review.

Coverage decreased (-0.15%) to 99.85% when pulling e0c4cd03fe6a0faa686c9da9392eccb87f20a354 on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

I am satisfied, but coveralls is not. Looks like there's a branch in the test code that's never reached:  https://coveralls.io/builds/2335678/source?filename=pylmod%2Ftests%2Ftest_gradebook.py#L245

Coverage remained the same at 100.0% when pulling 87fd2702956a9aeef6ae47bc05ee0247c900acb6 on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

Coverage remained the same at 100.0% when pulling 7d03357168bbefb1b4fccdf9590428847e7afeb7 on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

@pdpinch @carsongee This is again ready for review.

Ready to merge after that last little nit pick, or if you just want me to merge it as is, I'm fine with that too.

Oh, and you should at least add to the commit message that we added get_options since we ended up munging two features into one.

Coverage remained the same at 100.0% when pulling b8a37cb85118c349e8c6da41dea347cde245585a on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.

I have made what I hope are the final edits to address review comments.  I squashed the last two commits and updated the commit message to include Gradebook.get_options().  This should be ready to merge, unless there is more squashing needed.  @pdpinch @carsongee

Other than that last little typo, :helicopter:

fixed the typo(s) in unravel_staff() docstring.  (Good catch!)  Ready for merge.  @carsongee @pdpinch

Coverage remained the same at 100.0% when pulling c07eddfc35b465c68dd314a15bfa489609f5c6c8 on feature/pw/gradebook_get_staff into 1316b169d5af882d171dec794b91f848bffe6f8a on master.


Missing collapse

Issue Type: Bug
Opened a valid JSON file with 550,000 lines in it.
Code folding doesn't work for a file with so many lines.
VS Code version: Code 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-12T16:38:45.278Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)

Memory (System)
15.93GB (6.74GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

@aeschli, did you get a chance to look into this one?

We currently limit the number of folding ranges to 5000.
Also, big files are not sent to the language server.

@aeschli , thanks for the response. I am sure the 5k limitation is for a reason and the lang server component might be important. But from a end-user point of view, if I can load the same file (sizes 20MB) in SublimeText (in less than 3 seconds) and still use code folding, it makes for a bad user experience to not be able to do the same in vscode.

There's now a warning shown when the large file is opened and you can choose to enable the features anyway


Handle missing methods on ChannelHandlerMask

Motivation:
When Netty is run through ProGuard, seemingly unused methods are removed.  This breaks reflection, making the Handler skipping throw a reflective error.
Modification:
If a method is seemingly absent, just disable the optimization.

Originally caused by https://github.com/netty/netty/pull/8988

@netty-bot test this please

@ejona86 are you ok with the PR as it is now ?

@netty-bot test this please


deps: upgrade all, bump to go1.19

As titled. Go version bump is required for one of the dependency upgrades

Codecov Report

Merging #59 (76526be) into main (ac58b7c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   61.11%   61.11%
=======================================
  Files          16       16
  Lines         630      630
=======================================
  Hits          385      385
  Misses        222      222
  Partials       23       23

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add ability to select one from a list of options

This could be accomplished in various ways

inline with a rotary-style picker
a mutually excluding option list like the one in place
a picker at the bottom in place of the keyboard


Make dict-string codec and apply to HDF5

See #32
@ajelenak - this doesn't work yet, because the resulting filter object isn't JSON encodable (it contains bytestrings). I assume there's a specific way I'm supposed to handle this.

@ajelenak , I believe this now ought to work, but I get a hard malloc crash (pointer being freed was not allocated). Can you please help me diagnose?

My first attempt at helping is to recommend a different approach: read the vlen string array and store it in the ReferenceFileSystem JSON. This could be controlled via an option specifying the max byte size of such arrays. Any string array over this max limit would not be stored and this ties in nicely with the similar discussion in #39.
Even the HDF5 code example for reading vlen strings does not use the internal HDF5 struct that is in those "S16" bytes.

Hm, I'm not sure how many data arrays we can possibly inline into the JSON. In the case in hand, the first array would be 63kB with vlen bytes (+expansion with base64), so very doable, but there are many of these in the dataset. The current highest threshold for inlining data I've used is 500bytes.
Even so, I'd really like to know why the code as given in this PR crashes.

Hm, I'm not sure how many data arrays we can possibly inline into the JSON. In the case in hand, the first array would be 63kB with vlen bytes (+expansion with base64), so very doable, but there are many of these in the dataset. The current highest threshold for inlining data I've used is 500bytes.

It's the last resort solution, the real goal is to avoid having HDF5 vlen datatypes in files that are to be accessed via ReferenceFileSystem. In this case, I think the source of those vlen HDF5 string datasets is the netCDF library which uses the vlen UTF-8 encoded HDF5 string datatype by default.

Even so, I'd really like to know why the code as given in this PR crashes.

Can you post the traceback, if there was any? One problem could be the double-use of the h5f file-like object in _make_string_dict(). h5f is already in use by the HDF5 library's virtual file driver (VFD) machinery because h5py opens the HDF5 file with it. An option could be to use the H5Dread_chunk() function but those string netCDF variables would need to be chunked (one chunk is enough). @tedhabermann can you create a new file with chunk string variables?

It's the last resort solution, the real goal is to avoid having HDF5 vlen datatypes in files that are to be accessed via ReferenceFileSystem.

We can't have that goal, as the whole purpose of this effort is to allow access to as wide a range of HDF files as possible, whose provenance we do not control.

Can you post the traceback, if there was any?

No traceback
python(84985,0x109fbadc0) malloc: *** error for object 0x7fdd7b0c2410: pointer being freed was not allocated
python(84985,0x109fbadc0) malloc: *** set a breakpoint in malloc_error_break to debug
Abort trap: 6

_make_string_dict only takes the h5 object and the open file-like (python io.BufferedReader for a local file)

@ajelenak : switching to VLenBytes still results in a segfault or malloc crash, apparently during garbage collection. I put in some manual cleanup to the end of _translator, but it makes no difference.

Do you get segfault when these four lines https://github.com/intake/fsspec-reference-maker/blob/642570d7522647a3583b0eae113377020a107731/fsspec_reference_maker/hdf.py#L315-L318 are commented out?

Do you get segfault when these four lines

Yes - those lines are not even being called as of the latest commit.

@ajelenak - a chunk vlen str? You mean write this dataset as chunked? In this case the dataset is written by the xArray to_netcdf function... Not sure how to control that... I'm actually not sure what chunking means in a variable-length string array...

@tedhabermann That was last week's idea, not needed any more.

@martindurant What OS did you run this code on? If not Linux, can you try it there?

It was mac - sure, I can try linux
On July 15, 2021 9:44:57 PM EDT, Aleksandar Jelenak @.> wrote:
@. What OS did you run this code on? If not Linux, can you

try it there?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/intake/fsspec-reference-maker/pull/40#issuecomment-881115990

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Dies:
In [9]: out = sin.translate()
2021-07-16 17:46:44,316 - h5-to-zarr - DEBUG - translate -- Translation begins
2021-07-16 17:46:44,327 - h5-to-zarr - DEBUG - _translator -- HDF5 group: /AMC2
2021-07-16 17:46:44,331 - h5-to-zarr - DEBUG - _translator -- HDF5 dataset: /AMC2/Datetime
2021-07-16 17:46:44,332 - h5-to-zarr - DEBUG - _translator -- Created Zarr array: <zarr.core.Array '/AMC2/Datetime' (7025,) int64>
2021-07-16 17:46:44,334 - h5-to-zarr - DEBUG - _translator -- _ARRAY_DIMENSIONS = ['AMC2/Datetime']
2021-07-16 17:46:44,371 - h5-to-zarr - DEBUG - _translator -- HDF5 dataset: /AMC2/Solution
2021-07-16 17:46:44,382 - h5-to-zarr - DEBUG - _translator -- Created Zarr array: <zarr.core.Array '/AMC2/Solution' (7025,) object>
2021-07-16 17:46:44,480 - h5-to-zarr - DEBUG - _translator -- _ARRAY_DIMENSIONS = ['AMC2/Datetime']
Segmentation fault

@ajelenak ^ that was my linux (docker) run

Running with the original string dictionary maker, I got extra information, hah
In [4]: out = sin.translate()
corrupted double-linked list
Aborted

Superseded by #175


work queue executor does not have type annotations

Describe the bug
work queue executor does not have type annotations. This means that it always passes make mypy when testing the code, even when incorrect types are used.
To Reproduce

Checkout master branch commit 70d6f0f
Confirm that parsl/executors/workqueue/executor.py does not have type annotations.

Expected behavior
All functions and methods in the executor should have type annotations.
Environment

OS: all
Python version: all
Parsl version: at least from commit 70d6f0f, but much earlier.

Distributed Environment
It is independent of the distributed environment.

cross-reference #873 which is about putting @typeguard.typechecked annotations on any function call that directly faces a user


Including the fastly docs

Proposed changes

Unreleased product version (optional)

Related issues (optional)

Pulumify failure isn't related to this build


Improve Pull Request Template

↖ First, change the base branch from "master" to "dev".
↑ Next, briefly describe your proposal in the title.

Finally, tell us more about the change here, in the description.

Hey, everyone, this is my first contribution to primer-css and I would love to know what you think. So I was thinking of adding a new line into the PR Template: Fixes: #
That way when someone creates a Pull request can mention the issue that has been fixed more easily.
Benefits

Conversation can be more focused on the issue when sometimes the title of the PR is not so descriptive (It happens we're humans)
When a PR is merged the issue can be automatically closed so we don't end up with situations like this: #305. This issue has been fixed and the PR related to the issue is merged but the issue is not closed. In addition to that, we will not have to think all the time to close an issue manually when we fix it with a PR because it will happen automatically.

I don't know if my logic here is correct so I would love to know what you think about this potential change.
P.s Love how you build primer-css in the open. Learned a lot of things about how to communicate more effectively through issues and PR's, write better commit messages and organize my open source projects.
/cc @primer/ds-core

oops. What happened here? Not sure why this branch has 24 commits. I only made this one 9087578 and created the PR. 🤔

Ah I see. @shawnbot. Yup, I think we can do that. Sounds like a plan 👍

@shawnbot I created a new PR, correctly this time 🎉  and I'm closing this one. The new PR is #374


No export FileType for zip

[ERROR] No matching export in<EMAIL_ADDRESS>for import "FileType"
node_modules/@zenfs/zip/dist/ZipFS.js:1:9:
1 │ import { FileType, NoSyncFile, Stats, flagToMode, isWriteable } from '@zenfs/core';
Really no export
//in zip/dist/zip.js
import { FileType, Stats } from<EMAIL_ADDRESS>
But in @zenfs/core/stats.js no export FileType
My versions:
"@zenfs/core": "^0.16.2",
"@zenfs/zip": "^0.4.5",

I install older version of core and this working
"@zenfs/core": "0.15.2",
"@zenfs/zip": "0.4.5",

This is correct, FileType was changed from an enum to a type.
I'll publish a fix soon.

@dastanaron,
The fix was commited in https://github.com/zen-fs/zip/commit/21afcb410b7a8dc5dee46ef7f15fa90ea12c7615 on July 25th, but was not actually published on NPM. 0.4.6 includes that commit.

@james-pre
Yes, this problem has been solved. Than you so much!
Now, I fix this versions in my package.json:
"@zenfs/core": "0.16.2",
"@zenfs/zip": "0.4.6",


unbound: Enable TLS server support

It would be nice to be able to enable TLS support for the Unbound server itself so that clients can make use of it.

I may also refer to the "small p" appliance and their updated implementation.

I'm building a dnscrypt-proxy plugin with Support for DOH or dnscrypt. :) Core integration might take some more time

well okay, why yet another plugin for stuff that's already possible to do out of the box? I know something to have for BIND (and not to wait for years for their own implementation) might be nice, but enforcing somebody to install just another plugin if you are only using Unbound seems overkill to me.
Maybe the right answer is not to have either of those but each of those possible options.

Unbound-plus merged into core.


[Public Catalog] show nerdpacks & visualizations in the external catalog

Relates to:

https://github.com/newrelic/developer-website/issues/1821
https://github.com/newrelic/newrelic-quickstarts/issues/187
https://github.com/newrelic/gatsby-theme-newrelic/issues/530

The External I/O  site shows nerdpacks & visualizations so users can discover those along side quickstarts.
Acceptance Criteria

[ ] #1821 is resolved
[ ] Sort & Popularity epic is completed
[ ] Auth epic is completed
[ ] Nerdpack applications are visible in the external catalog grid
[ ] Nerdpack applications are visible in the external filters
[ ] Custom visualizations are visible in the external catalog grid
[ ] Custom visualizations are visible in the external filters

Screenshot

closing for now as this would be driven by the catalog service once we move to it, and then we can address the UI needs in the new I/O site.


Add grpc to integrations, add cncf logos to integrations

This PR addresses #4754 (cc @yashykt), but also introduces that each CNCF project shows a small CNCF logo besides their name. This shows adoption of opentelemetry across the landscape :-)

/fix:format


Refactor iterator API, add Rayon extension

While using indicatif, I had modified the iterator API to both a) work with iterator chaining and b) support parallel iterators with Rayon. The changes look like:
let mut v = vec![1, 2, 3];

// used to be:
let pb = ProgressBar::new(v.len());
for item in pb.wrap_iter(v.iter()) {
  ...
}

// now is:
for item in v.iter().progress_count(v.len()) {
  ...
}

// also parallel iterators
v.par_iter().progress().map(|i| { ... }).collect()

I added a feature gate so the user does not have to download Rayon if they're not using it.
I wanted to show this initial PR to see if the maintainers would be interested in either change. If so, I can go ahead and add more tests/documentation.

Shouldn't you expose ParallelProgressIterator as well?

Looks good. Can you rename the feature to with_rayon or just reuse the rayon feature that is added by default?

@Hummer12007 added that export. @mitsuhiko renamed the feature.
I added a section to docs in lib.rs, inline docs, an an example at examples/iterator.rs.
Only latent issue is that I had to mark the Rayon code example in lib.rs with rust,ignore because I don't know how to feature gate a doc test. Anyone know how to do that?

I don't think it can be done. Will try to get this merged for next major version.

@newpavlov the progress bar will reflect the passage of elements through the progress iterator, which will depends on where you insert the .progress() call in the iterator chain. If you put it at the end, I suspect you won't see the issue where tasks are still executing at 100%.
The starting at 1 I would need to dig into further.


Popup not working with circlemarker in cluster

Hi,
I am having problems getting the popup in the markercluster to work with geojson, pointToLayer and circleMarker functionality. The last feature will popup as expected, however the others will not.
I have made a minimal example for this in jsfiddle: http://jsfiddle.net/kjeander/aue7uhe2/1/
If I remove the pointToLayer part and only use normal markers it seem to work fine.
If I am doing anything wrong, please advice me :-)
Thanks,
Kjetil

Works for me?

Your circles will be appearing below the marker cluster icon I expect.

Yes, the circles are drawn nicely under the cluster and the popup works fine for the last point of the geojson. However if I try to click for popup on the first point 'TEST POINT 1' it will not popup.

Have you tried larger circles?

Any resolution on this? I've found a similar issue.

I was looking for a resolution on this - it seems that the app can get confused about the clickability of the circles if they are too close to the center of the cluster. So, adding the spiderfyDistanceMultiplier option with a value of 2 or more seems to help. I show that in the following fiddle:
https://jsfiddle.net/mmdolbow/aue7uhe2/7/
Still seems like a bug - but I think this workaround is adequate.

Hi,
Old issue, but just for other people who might get the same problem: this is due to Leaflet 0.7.x which renders vector layers (like circleMarker and other polylines) in the map overlayPane, whereas the cluster icon resides in the markerPane, which is always above the overlayPane.
The most simple workaround as suggested by mmdolbow above is to use a spiderfyDistanceMultiplier option value > 1 to increase the distance between the vector layers and the cluster, so that they get out from below the cluster icon.
More sophisticated resolution would require changing the spiderfier configuration, as shown in the below updated jsfiddle for example:
http://jsfiddle.net/aue7uhe2/15/
This highlights the trick that offsets the circle a few pixels down, so that standard markers (the blue icon) are centered around the cluster icon, but which do not apply for other types of markers (like circleMarkers in this case).
I have heard that Leaflet 1.0 would provide more control about those panes (Leaflet/Leaflet#1742). With such a feature, MCG could then force spiderfied layers to be shown on top of everything (including above the icon of cluster they come from), rather than being stuck with the map predefined panes.
That would definitely be a more elegant solution.

This problem is still not fixed in the 1.0.0. Beta. You can*t open Popups with spiderfied Circlemarkers. All the tricks above won't work anymore.

Hi,
Thank you for your message.
Please can you kindly explain why you say that "tricks above won't work anymore"?
Looks to me that spiderfyDistanceMultiplier option is still a valid workaround.
Updated JSFiddle: https://jsfiddle.net/aue7uhe2/17/

I really have no clue. I implemented it like you did and it doesn't work. I try to make a fiddle the next days.
Thanks.

+1

Popup is broken even in  marker-clustering-geojson example
Any permanent fix for this issue?

Hi @ghybs,
I tried your example for a "MultiPoint" Feature collection. Seems popup is not working in this scenario. Can I know whether its not supported for "MultiPoint" features? I just updated your jsfiddle
https://jsfiddle.net/aue7uhe2/18/
Thanks!

Hi @prasadKodeInCloud,
As for the marker-clustering-geojson example, looking at the page code, I see that there are 4 markers (eye1, eye2, nose and another one) and a polyline (mouth) without bound popup. All other features have a working popup for me. Therefore all seems to work as expected as far as I can tell.
As for your JSFiddle with MultiPoint geometry type, what happens is that Leaflet applies onEachFeature on the MultiPoint group (it creates a Feature Group containing each individual point), not actually to your individual points (i.e. circle markers).
Without MCG, it works because your GeoJSON group is added to the map, and clicking on your circle markers propagates the click event to the GeoJSON / Feature Group, which opens the popup.
But with MCG, it stripes out any group and adds only the individual layers (i.e. circle markers in your case) to the group and map. Because the Feature Group itself is not on map, I guess it cannot receive the click events, hence it cannot open any popup.
Simply binding the popup within the pointToLayer option instead of onEachFeature ensures that each point feature has an individual popup, instead of a popup delegated to a potential group that will be stripped out by MCG.
Updated JSFiddle: https://jsfiddle.net/to9g5ebs/3/

Hi,
This issue was raised again on GIS SE, specifically when Leaflet and Leaflet.markercluster are used by qgis2web to automatically generate a web-ready map.
The spiderfyDistanceMultiplier workaround has been discussed in qgis2web repo and implemented.
However, it would be interesting to implement a proper fix directly in Leaflet.markercluster.
An idea could be to increase by default the minimum spiderfication leg distance, so that they extend outside the cluster default icon in all situations.
In case the app developer provides his/her own cluster icon (using the iconCreateFunction option), this strategy might still fail, and the app developer could then resort to using spiderfyDistanceMultiplier option workaround again.


Documentation error in screws.scad

Describe the bug
Documentation error in screws.scad
Code To Reproduce Bug
Line 61; //   head = head type (see list above).  Default: none

Expected behavior
I expected to find head type info earlier in the file.  However, that information does not appear to be there.
The head type information seems to be actually defined in the screw_info() module, starting at line 689.

Hmmm.  It does say at the top that the parameters are described in the entry for screw_info().  I think screw_info() used to appear first in the file before I reorganized it.  Should all the details in screw_info be moved into screw() and then screw_info() refers to screw()?

Another option worth considering: a separate section at the top of the file discussing all the screw parameters.

How does the revised screws.scad documentation look?  Any comments?

That is much better. I like having all of the specifications at the top.