Seeking feedback on propagating contextual signals to TEE KV server

Note: This issue describes possible new functionality for Protected Audience. It is not necessarily a feature that will ship in the near future, but we are considering it as an optional backwards-compatible potential API improvement. We are interested in hearing feedback with this post.
Context
This post seeks feedback for the concept of propagating contextual signals as part of the TKV (Trusted Key Value server) request.
This post will mostly explain in the context of on-device auctions but we also consider the same capabilities for the Bidding & Auction services.
Introduction
Today the SSP can provide contextual information to PA auctions by specifying perBuyerSignals and sellerSignals in the Auction Config. The content of the signals can come from various sources including the contextual auction responses and information on the page. But these signal fields are only available to generateBid() or scoreAd(), not the key value service. There is only very limited contextual information sent in the TKV request, such as hostname and ad slot size.
This poses some challenges to the design for certain use cases:

Server side contextual information processing can only happen during the contextual ad auction, whose results may not be actually used if the subsequent PA auction has no interest groups.
Logic that depends on the contextual signals can only run in generateBid() or scoreAd(), but not earlier in the TKV. This could mean that

Other input to this logic needs to be sent to generateBid() or scoreAd(). If some of those input are from the TKV, they don't need to be sent in the TKV response if the logic runs inside the TKV.

This reduces the TKV response payload.
This reduces generateBid() and scoreAd() complexity, so less workload on the device.

Some logic impossible to run in generateBid() or scoreAd() can actually run in the TKV. Reasons include that it may rely on large amount of data, frequently updated data or private logic/data.

The list is not exhaustive.
The flow

Diagram: example flow related to the DSP KV server
In this post we envision 2 new fields in AuctionConfig:

A new field “perBuyerTKVSignals” for the SSP to send information to DSP’s TKV.
A new field “sellerTKVSignals” for the SSP to send information to the SSP’s TKV.

This allows the SSP to specify additional contextual information to the TKV server.
This information is only available in the request to the TEE-based implementation of the KV server. BYOS KV servers do not have access to this information.
Parallelization compatibility
Parallelization is an important performance optimization today where the contextual ad auction happens in parallel to other PA auction actions, particularly the TKV trusted bidding signal request.
Including perBuyerTKVSignals to TKV request can impact the parallelization: If the signals depend on the contextual auction response, the TKV request will need to wait for the contextual auction to finish, forgoing the parallelization feature. On the other hand, if perBuyerTKVSignals contains just information available on the page, such as the full page URL, the parallelization can still be effective.
The SSPs and DSPs need to make a tradeoff between having more signals and keeping parallelization effective.
There are a few potential mechanisms to isolate the tradeoff to be under each DSP’s own control without impacting other buyers or the auction overall. Ideas include that the SSP creates two component auctions. One auction would include DSPs who prioritize parallelization and rely solely on on-device contextual signals. The other would be for DSPs willing to await the contextual auction results before sending their TKV requests. Feedback on this approach is crucial. Further discussions will help refine this strategy and explore different configuration ideas, such as consolidating the two auctions into a single, unified one.
Server side processing
The signals can be available to the UDF running inside TKV, similar to hostname and ad slot size as metadata. The rest of the flow is the same as today.
The new signals could enable more capabilities to happen within the TKV. A notable example is brand safety where the DSP TKV can perform some verification on the full publisher site URL to provide extra decision making input. We will describe more about this example in another feedback-seeking post.
Since this information is only available to TEE KV server, today an adtech cannot make use of this unless they migrate from BYOS to TEE KV server. We are also interested in getting feedback about an intermediate setup before TEE KV enforcement. The setup is considered a “Hybrid mode” where an adtech can deploy both a BYOS system and a TEE KV system that collaborate to complete a request. So some logic can stay in the BYOS stack and other logic can be migrated to the TEE KV system first. More details will be provided in a separate issue.
Bidding & Auction service flow
The device can also pass these fields to the Bidding & Auction services. In addition, for DSPs, the Bidding & Auction service can pass the perBuyerSignals to the TKV. There are no parallelization concerns as the contextual ad auction completes before the Bidding & Auction flow starts.

I'm trying to understand the core problem/challenge this proposed feature addresses, and I'm not sure I can capture it.

The new signals could enable more capabilities to happen within the TKV. A notable example is brand safety where the DSP TKV can perform some verification on the full publisher site URL to provide extra decision making input. We will describe more about this example in another feedback-seeking post.

I would guess this part is the most relevant for this?

But these signal fields are only available to generateBid() or scoreAd(), not the key value service.

Is this a problem?

Good point @davidae . I updated the doc. Please see the introduction section

I'd be interested in knowing whether it would be possible to create within the TEE KV system a separate "contextual" processor that generates perBuyerSignals, so a DSP could skip the contextual auction and generate within the TKV a perBuyerSignals that is known not to use first-party input, which could therefore be included in the win report.
This seems like it could be a huge cost saver for smaller DSPs focusing on retargeting, which have interest groups on only a small fraction of browsers, so that they don't need to handle contextual requests for vastly more auctions than they actually participate in.  In essence this would enable "pre-targeting" since they'd only have to handle auctions for browsers where they have an interest group.

I'd be interested in knowing whether it would be possible to create within the TEE KV system a separate "contextual" processor that generates perBuyerSignals, so a DSP could skip the contextual auction and generate within the TKV a perBuyerSignals that is known not to use first-party input, which could therefore be included in the win report.

It's currently actually the other way around - the signals for the win report (that is, a report sent from reportWin()) can't have too much information from the site that joined the interest groups (contextual signals from joining page / signals from within the IG itself).  It's allowed to have full information from the page that ran the auction.  There are any number of ways to pass information about the page that ran the auction to reportWin().  reportResult() gets auctionSignals, perBuyerSignals, directFromSellerSignals, and sellerSignals, all of which can contain full context about the page running the auction.
Hopefully this constraint can be relaxed once we remove event-level reporting, in favor of aggregated reporting, but that won't be happening any time soon, I believe.

Matt IIUC I don't think the question breaks the constraint you mentioned though as it does suggest to "not to use first-party input".

The suggestion was for the field to be included in the win report.  I assume this was talking about an event-level win report, which is also able to include contextual data.

Matt IIUC I don't think the question breaks the constraint you mentioned though as it does suggest to "not to use first-party input".

The suggestion was for the field to be included in the win report. I assume this was talking about an event-level win report, which is also able to include contextual data.

I am talking about the event-level win report, but an not talking about first-party data.
The proposal that this issue relates to involves sending contextual data to the KV store.  My ask was that there be a way to provide precisely that contextual data (without any first-party data, but with DSP-specific manipulation of that data, e.g. to apply some machine learning model to that contextual data and log the output) to the event report.  We can (and do) already do this, but it requires that we participate in a contextual auction, which is an expensive waste of resources when most contextual auctions are for browsers where we have no interest group.  If we could stop participating in contextual auctions our costs would be proportional to the number of auctions that we participate in, which would be a huge savings.
To summarize the summary:  the idea is that if the KV store were to allow us to separate the "digest the contextual data and turn it into input to our bidder" process from the "look at all available data and bid" then the output of the former (non-first-party) code would be safe to log in the win report, which would be very beneficial for smaller DSPs focusing on retargeting.

Ah, so by "is known not to use first-party input" you mean first-party data relative to the origin the IG was joined on (Or data stored in the IG about the user derived from that context), rather than information from the origin running the auction.  That sounds reasonable.

Thanks for envisaging this feature which would unlock some interesting use cases like being able to filter more information based on the full publisher url or doing some supply side optimization based on the sellers that are active for the current auction.
We think that this feature would be mostly useful for on-device auctions and inject more signals to the server side computing part inside the KV server. For server side auctions (B&A) it seems like the generateBid layer  already gives access to the IG and to perBuyerSignals and therefore provides enough information to get access to those signals server side. Not sure it is necessary in this case to send more signals to the trusted KV Server.
For on-device auctions it seems important not to break the parallelization feature because it would slow down the auction flow too much. So it looks like perBuyerSignals should probably be one promise for each buyer instead of one promise for all buyers in order not to slow down buyers that don’t want to wait for the contextual call to resolve perBuyerSignals. In our case the best would be to inject values that are already available during auction time like the seller domain, the publisher url, ..
Today the KV service call looks like an expensive call already. One down side might be that injecting contextual signals might break the fact that the KV service calls is shared across supply side channels because each seller might setup different signals. It could potentially behave similar to the feature to split up KV calls maxTrustedBiddingSignalsURLLength, like grouping all seller information inside one single KV call instead of sending multiple calls. As it is not straightforward to know if multiple calls or 1 call are needed, probably better to provide some configurability here and maybe also let the DSP control what they want to receive.
With those new signals it also looks very important to be able to execute the inference layer in the KV service also (protected-auction-services-docs/inference_overview.md at main · privacysandbox/protected-auction-services-docs ) because one key feature that could be executed by the KV service would be ML inference.
Did you consider sending more user data to the KVS like the information from prevWins ?
Today the KVS handles advertiser user information. So it looks like one could also send other forms of user information like previous wins and clicks. This kind of information doesn't have the downside to be SSP specific (like perBuyerSignals) which means one KVS call could be reused across several SSPs.

We have published an explainer on how buyer signals can be optionally propagated from B&A to TKV for PA flow. This should be available with the next B&A release 4.5.0.

@lx3-g As explained before most of the value of this feature seems to come from on device auctions. Wil lit be available also for one device auctions ?

Hi Fabian Höring,
Whether the value of this feature comes from on device auctions or B&A depends on specific use cases.
As the explainer states, the support for on-device auctions will be available. We will update this thread once it is.

@lx3-g Can you go into more details on what exact use cases you have in mind for B&A and injecting more signals to the KV server ?
I didn't find this anywhere but maybe I missed something and I think it would be interesting to share/document this. It would allow a better understanding on the direction forward in general.

Sure, I think this issue above covers it with “Some logic impossible to run in generateBid() or scoreAd() can actually run in the TKV. Reasons include that it may rely on a large amount of data.”
One scenario can be that some data that is looked up in TKV depends on buyer signals. Without having those signals in TKV you’d need to potentially look up a lot of data, pass it back to BFE, and then do the trimming/filtering there.
Note that for B&A AdTechs don't need to worry about parallelization and can get the full set of buyer signals whereas for on-device there is a trade off between the full set of signals and parallelization. More about it in the “Parallelization compatibility” above.

I will add this topic to the agenda of one of next WICG discussions.


Added - MPH and Stroke Rate data points

Two additional stats from the S4 that can be read.

No. Thank you!


Assess docs

Description
Updated tables for correct markdown.
Type of change

[X] Fixes
[X] Styling

@iangurney please could you resolve the conflicts on this


Failed to get response status when 401 with a CORS request

fetch(url,{
  'Accept': 'application/json',
  'Content-Type': 'application/json',
  'Authorization': JSON.parse(window.localStorage.token)
})
.then(function(response){
  alert(response.status)
})

When the request is CORS 401, status code is not alerted,I need to do something such as redirect to login page when token is not right...Thanks in advance

It's not a bug of fetch,it's pure cors issue...so issue closed.


Themes: there is an file icon change event after startup

I did not see one for the theme, but the file icon seems to fire an event on startup. Is that expected?

There were 2 events, now one.


Config resolve not correct when extend width or height.

In resolveConfig if theme property is function, extendTheme will overwrite it. then you will lost default config in that part.

Can you share some examples of your config?

{
  theme: {
    extend: {
      opacity: {
        15: '0.15',
        20: '0.2',
        95: '0.95',
      },
      margin: {
        96: '24rem',
        128: '32rem',
      },
      padding: {
        '2/3': '66.666%',
      },
      height: {
        18: '4.5rem',
      },
      width: {
        18: '4.5rem',
      },
    },
  },
  variants: {
    extend: {
      translate: ['group-hover'],
      animation: ['group-hover'],
      backgroundOpacity: [
        'dark',
        'active',
      ],
    },
  },
  darkMode: 'class',
}

because this._resolveConfig add extendTheme to theme in
https://github.com/voorjaar/windicss/blob/174dc7f960852bac68a0e34d797e6a4d5c2b4dd5/src/lib/index.ts#L115-L117 before all functions got resolved in
https://github.com/voorjaar/windicss/blob/174dc7f960852bac68a0e34d797e6a4d5c2b4dd5/src/lib/index.ts#L169
some of the default theme property are functions, so it got replaced by extend theme.

@voorjaar  Thanks !!


QL packs: bump versions to 1.0.0

The syntax seems to be fairly stable now, so let's bump the version to 1.0.0.

Given we haven't agreed yet how we're going to version qlpacks, and given that the versions are not currently used for anything, I think we should stick with version 0.0.0 for this release (as it indicates that this is not yet a usable version number). This was something I've discussed with both Pavel and the doc team, so if we do something different it may require documentation changes.

OK -- in that case I'm not up to date with the latest design discussions. I was assuming we were simply keeping the versions at 0 until we're ready to release documentation of what these files are about ...

But if so, we should also undo the bump I recommended in https://github.com/Semmle/ql/pull/2302


Remove slash from route

@wtrocki What is a good way for me to test this change?

This fix helps with http protocol issues when using slash at the end of the location is adding double slashes. I would probably need to also rewrite slash to be aligned with https and http. Reason why this is happening is that haproxy has different behavior when updating protocol.

@PhilipGough It seems that this change would be most reasonable way to go considering all incompatibilities we experienced. Generated urls have now / at the end.
For http and https and different versions of openshift router.

@wtrocki Sure. Do you think we could make use of the (merge slashes module)[http://nginx.org/en/docs/http/ngx_http_core_module.html#merge_slashes]

Checked in the logs. It's already turned on.


Windows build fail

I follow build instruction to build raiblocks.
OS: Windows 7 64x
Visual Studio 2015
bootstrap_weights.cpp is included in the secure project.
It failed with below error message.
Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK2001	unresolved external symbol "unsigned __int64 const rai_bootstrap_weights_size" (?rai_bootstrap_weights_size@@3_KB)	rai_node	E:\GitHub\raiblocks\build\node.lib(node.obj)	1

Severity	Code	Description	Project	File	Line	Suppression State
Error	LNK2001	unresolved external symbol "unsigned char const * const rai_bootstrap_weights" (?rai_bootstrap_weights@@3QBEB)	rai_node	E:\GitHub\raiblocks\build\node.lib(node.obj)	1

extern arrays dont link properly for windows, here is a script to take the definition from bootstrap_weight.cpp into rai\node\node.cpp
$size_t=select-string -path ".\bootstrap_weights.cpp" -Pattern "rai_bootstrap_weights_size"| foreach {$_.Line}
$old_size_t = "extern const size_t rai_bootstrap_weights_size;"
$char=select-string -path ".\bootstrap_weights.cpp" -Pattern "char rai_bootstrap_weights"| foreach {$_.Line}
$old_char = [regex]::Escape("extern const char rai_bootstrap_weights[];")
select-string -path ".\rai\node\node.cpp" -Pattern $old_size_t -SimpleMatch | %{$curpath=$_.path; (get-content $curpath -Raw) -replace $old_char, $char| Out-File $curpath}
select-string -path ".\rai\node\node.cpp" -Pattern $old_size_t -SimpleMatch | %{$curpath=$_.path; (get-content $curpath -Raw) -replace $old_size_t, $size_t| Out-File $curpath}

Run this after cmake and then build

This issue appears to be resolved since there has been no feedback from the requester.  I'm going to close the issue, please re-open it if the issue is still on-going.


feat: sell improvements

arch improvement
add sig payload

we will also need /status endpoint, similar to swap:
https://developers.ledger.com/docs/exchange/swap/providers-backend


SharePoint Search API - ElapsedTime

What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
SharePoint REST API
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details
No response
Issue description
Since some weeks ago, the calls to the Search API are always returning ElapsedTime = 0. It used to indicate the total duration of the query. Has this property been now deprecated?

Anybody in the Search team can help me with this query? @wobba

I've asked internally about this.


Upgrading from 0.7.* -> 0.8.0

Sorry for the breaking changes or the changes in the output! Please follow the release note for more information:
https://github.com/Skarlso/crd-to-sample-yaml/releases/tag/v0.8.0
And apologies for any inconvenience. Now, the generated YAML files should pass the validation of the CRD they have been generated from. If any more things are failing, please open an Issue so I can fix them.

I think this can be closed by now.


Exception when pip install probfit

16:15 $ pip install probfit
Collecting probfit
  Using cached https://files.pythonhosted.org/packages/80/2c/0abaeede057064b1eacbdb839f33b88693c3e0f3d78a405e1e0d5a8b446b/probfit-1.0.5.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-2oz5tpmd/probfit/setup.py", line 43, in <module>
        execfile('probfit/info.py')
    NameError: name 'execfile' is not defined

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-2oz5tpmd/probfit/

using anaconda python 3.6.6

The current package on PyPI doesn't support python 3. See #65 - you could add another comment to encourage them to add a new release.
In the meantime, it should work if you install it from master pip install git+https://github.com/iminuit/probfit.git#egg=probfit

Hi @dneise and @raymondEhlers, a release working with Python 3 will hopefully be out soon. As you can see from the activity, we're trying to iron out a few things.

Hi @eduardo-rodrigues, thanks for the efforts - they are much appreciated!

Hi folks, pobfit's build is finally passing again! Can you give it a try for yourselves and close this, if happy? Thanks a lot.

probfit 1.1.0 is available on PyPI. Am closing this PR as I believe it's all sorted out.
Feel free to reopen if you have any trouble. Otherwise … enjoy!

It took me a few days to make time to try it out, but just wanted to follow up to say that it seems to be working nicely. Thanks!


What's the maximum limit for Batch Transcription? I mean file size and duration

For example, max file size is 100mb?
max duration is 1 hours?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 73fb7e76-fb80-c420-2efe-e3ca3a27b749
Version Independent ID: 07a42557-deb3-e4b3-3f14-f26a27be49c2
Content: What is batch transcription - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/batch-transcription.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @wolfma61
Microsoft Alias: wolfma

I am using Batch Transcription: https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/batch-transcription
I am not using any SDK, just get auth token using HTTP and create transcription task with REST API.

I upload audio file to Azure Storage Account's Container
get a public accessable URL
send that URL to batch transcription REST API to "Creates a new transcription" (POST	api/speechtotext/v2.0/transcriptions)

Question
What's the limit? max file size 100mb or?  max duration is 1 hour or?

@1c7, thank you for reaching out. We are looking into this and would get back to you soon on this thread.

@1c7 Can you please add more detail about the input audio file's that you are trying.
Please follow the below for faq.
https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/faq-stt#importing-data
The limits above and in the doc are the default limits. We do work closely with large customers and can change the quota when necessary.
Current API_2.0 is only single file based, A version3 of the batch api is going to become available,This API version will allow you to supply a container as the input.

@ram-msft
Hi, the input audio file comes from the user, so it could be any format or size or duration.
I am trying to find out what's the limit,
so my program can say: Sorry, the file is too big/duration is too long
the FAQ https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/faq-stt
didn't say file size limit and duration limit.

This is request frequency limit

I don't need to train model, I just use the default one
Conclusion: problem still unsolved

Current API_2.0 is only single file based, A version3 of the batch api is going to become available,This API version will allow you to supply a container as the input.

that's great but still haven't answer what's the limit for single file?

there are no hard-coded limits in the batch transcription service itself regarding file size or audio duration.
a batch transcription request must be finished withing 48hours (currently), once it has started processing. This includes downloading the audio blob, transcribing, uploading the result data. We are transcribing with up-to double realtime speed. All these parameters are internal and can change, the service usage might be relevant, or available space (memory / disk).
I would recommend staying in a manageable space of several hours of audio. Longer files I would actually split to parallelize the upload of the audio and also the processing of the audio. Splitting 20 hours of audio in 10 segments of 2 hours might get you the transcription results in a couple of hours, as a big file you will have to wait at least 10 hours or so.

@wolfma61 Thank you :)


3SI Transaction test cases scenario 02 #38

code functionality tested correct.
But leave two question as listed on https://github.com/futurewei-cloud/chogori-platform/issues/38.
The code is submitted in case you need to check the code.

All scenario-02 cases are implemented and the "failed_assignment" bug is fixed. Please check the PR.

Looks good, once you get it rebased on latest master with the new SKV interface it will be good to merge.


Targeting UAA of a CF foundation

tl;dr, this is the same issue as https://github.com/pivotal/hammer/issues/20 except with the use-case of retrieving uaa credentials & passing commands via the uaa-cli.
Again, apologies for blowing up the issue backlog with these-- they're just ideas I felt compelled to log, and feel free to close them whenever 👍

Seems like a reasonable suggestion, my only worry is the one you touched upon in #20 that this might slightly balloon the feature set of hammer. I will definitely take a look at this though.
No need to apologise, happy to have all this input!


Verifying Smart Contracts page improvements

Just some suggestions for the Verifying Smart Contracts page

[x] Reflect that metadata is not part of the EVM. This comes from another issue https://github.com/hashgraph/hedera-sourcify/issues/124. All details are there.
[x] It might be worth to also add Foundry in the Metadata File section, given it is heavily used in the community.
[x] And maybe make the subsection Different Instances of Sourcify[...] more prominent. This is because the beginning of the page mentions Sourcify which might confuse the user later on.

Resolved in 4fa9bd9


[Value] Add WebLN support

First of all, what you've built is absolutely incredible, great work, thank You!

podcastindex.org has the web player, and it would be great if the listener can pay those nodes in the value field even when listening through this web client.
Adding a browser lightning wallet to the website is certainly a bad idea.
However, there are browser extension lightning wallets [usually connected to a remote ln node], which can pick up an invoice displayed on a website, then pop-up the browser extension for user confirmation. Optionally the user can also set an upfront agreed upon "allowance" to a certain website.
This works with the WebLN stack, which is "a way of interacting with a user's Lightning node via the browser." I'm not too familiar with the nuances of the spec, but I think it would require little work [non-dev-speak] on the podcastindex.org site, other than displaying the ln keysend invoice in the particular WebLN format. I am also not sure how to optimize this for streaming payments.
@bumi might know more details on how to get it done.

thanks for opening that topic @MaxHillebrand
I think that's a great example of how a WebLN spec could bring nice lightning functionality to the web.
WebLN defines a simple JavaScript spec how a website can interact with lightning (e.g. request a payment, or request an invoice).
Wallets (e.g. a browser extension) inject such a standard webln object in the website and make it available in JS.
Example usage:
webln.sendPayment(paymentRequest)
  .then(response => {

  })
  .catch(error => {
    handleFallback();
  });

The player can simple do that call periodically or on some user interaction. Because it is plain JS anything is possible.
WebLN is an unobtrusive enhancement, so if users do not support it they simply get a the fallback, e.g. manually displaying payment details.
WebLN was first released 2 years ago and is implemented by quite some websites (e.g. bitrefill) and wallets (e.g. bluewallet). But it needs an update for newer lightning features. For this it would be great to hear your thoughts on this.
I am happy to work on a PR to integrate actual donation payments for the podcast value fields.

I think this can be closed. Support for webln was added in #189

That's awesome progress, thanks!


Abuout archekture

Welcome
We when working on CPU Applo Lake ?
Cheers

I will start development once I have such NAS model. When that will happen I don't know.

cool ty for info, I have own 218+ NAS.


end animation cleanly with correct value

What does the pull request do?
ensures the correct value is applied at the end of an animation
What is the current behavior?
an animation sometimes rolls back to a very early value, this is sometimes visible in control catalog.
What is the updated/expected behavior with this PR?
animations stop on the correct value
How was the solution implemented (if it's not obvious)?

Checklist:

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Avaloniaui.net with user documentation

If the pull request fixes issue(s) list them like this:
Fixes #2020

This currently breaks the RepeatCount

still wrong!


Exists should be intersection of proximity selectors

Expected behavior
Exists should be intersection of proximity selectors
Actual behavior
await text("passing step", near("Failing scenario")).exists() gives Does not exists whereas await text("passing step", near("Failing scenario"), below("failing scenario")).exists() gives Exists it should actually be intersection of proximity selectors if even one does not match should say Does not exists
Steps to replicate

Open a html-report of gauge with One Passing, one failing and one skipped scenario in taiko
await text("passing step", near("Failing scenario"), below("failing scenario")).exists()

It says exists but it should say Does not exist

Version
dc9856c38139e5dc0f899c546763b9e34b61cf0b

@sguptatw Can you try with this cb7aadc54598a6361329d301d6bb5fee880268e6 commit.
In both cases it says exists.

await text("passing step", near("Failing scenario")).exists()
await text("passing step", near("Failing scenario"), below("failing scenario")).exists()

Right now there is no such calculation for deciding the offset value. We could do that, but before devising the implementation I would like to simulate the behavior so that we have a clear understanding.

Intersection of proximity selectors working as expected. Hence closing this issue. Tracking option to configure the offset as a part of #305


Drag & Drop components in Schema Builder misaligned to cursor position

Issue: When the schema builder form builder view exceeds the window's height and the user scrolls down the page to place a new component, their is a gap between the user's mouse position and the dragged component. This behaviour makes the dropping of a component difficult for users.
Note: This issue was replicated on two different systems, both using chrome browsers.

After testing the change, this issue still persists.
Situation: When there is multiple items (more than a screen height's worth) in the form builder, if you attempt to move one of those items to a different position, the draggable item is misaligned with the cursor position. This appears to prevent the moving items in the form.
Potential Enhancement: It would be nice if the form builder scrolled to allow a user to drop items in different positions on the form. Currently it doesn't appear to do this automatically in either chrome or firefox.

The enhancment has been implement in pull request https://github.com/GCRC/nunaliit/pull/801
Waiting for code reviewing

The pull request:801 fix the issue in branch:master;
commit:66034bd fix the same issue in branch:2.3.0-alpha causing by material-design css;


Fix when failures occur trying to decode to hash.

Call inspect on exception
Similar to this PR in original repo
Fix issue #318 in original repo: Strict mass-assignment protection preventing display of object

Thanks for this contribution. I just looked at the original issue and am trying to think of a way to reproduce it. Is there some way we can reproduce this for testing? Would it be helpful to output some kind of warning to the user instead of quietly falling back to #inspect?

@obourdon do you have any ideas on how to reproduce this issue especially for testing?


Add tykisha-pittman to Contributors list

@tspittma, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Use an ErrorMessage and redirect to page to select team

Close #560

Do we need to do the same sort of thing on ALL the other pages? Should this be part of the SuperController? Does that become too costly unless we do caching?

@jcubbage I'd say just here.


Fallback to non-TPM unique identifier if TPM not available

For systems without a TPM available (such as rpi), we need to be able to use a different identifier to help with the secure onboarding.
If we have a global trust root stored in Rancher, we could sign a hardware identifier and store it in a read-only partition. As long as this signature is loaded out of band or prior to hardware transport, we can trust the registration.

FYI we split tpm bits from rancherd/os2 in a separate library that can be used by both: https://github.com/rancher-sandbox/go-tpm and supports TPM emulation


TreeView: how to change cursor to pointer on hover of a children?

The examples from https://carbon-components-svelte.onrender.com/components/TreeView can't do that, but the left tree in document itself can.
Wondering how is that achieved?

Also asked on stackoverflow: https://stackoverflow.com/questions/73000929

Got an useful answer here: https://stackoverflow.com/a/73000993


Vars file for molecule

Issue Type

Feature request

Desired Behavior
While developing playbook it would be nice to run molecule just with molecule converge -s scenario name but when launching on ci system there have to be vars defined as environment variables.
As for now i am doing testing in two ways.

default one just git push. and went drink tea.
if first option was unsuccessful i launch molecule create -s os, molecule converge -s os and molecule login. but to get there i have to provide

driver:
  name: delegated
  hostname: ${vsphere_hostname}
  esxi_hostname: ${esxi_hostname}
  username: ${vsphere_username}
  password: ${vsphere_password}
  datacenter: ${datacenter}
  validate_certs: "no"
  resource_pool: ${resource_pool}
  folder: ${folder}

that list of vars. of cause them are caught from env. but i have to place them anyhow :(
the idea is to have some kind of file with answers and insert it in a such way
molecule create -s os --vars local.yml or maybe have a default file.
That file will be added to .gitignore and will never left dev laptop.
Of cause there just can be added something like ./run.sh with lots of exports.
But that option looks bit ugly.

Docker compose has an .env file concept that we can borrow from.  However, I would like to think about this.  In general, I would recommend someone simply have a wrapper script when calling Molecule, if they require a significant number of env vars.  ,
In the case where the script or .env file would not be checked in, due to sensitive information, this  makes the usefulness of the .env file a bit questionable.

The same concept in goss


Format document does not create proper indentation in razor

This issue has been moved from a ticket on Developer Community.

[severity:It bothers me. A fix would be nice]
Clicking on Format document does not format the razor file with the correct indentation. Notice the extra spaces.

Original Comments
Feedback Bot on 10/19/2023, 07:15 PM:
(private comment, text removed)
Wenwen Fan [MSFT] on 10/19/2023, 11:37 PM:
(private comment, text removed)
Michael Bayley on 10/24/2023, 05:56 AM:
(private comment, text removed)
Wenwen Fan [MSFT] on 10/24/2023, 07:09 PM:
(private comment, text removed)
Michael Bayley on 10/25/2023, 05:09 AM:
(private comment, text removed)

Original Solutions
(no solutions)

Some of the issues highlighted are fixed already, probably by https://github.com/dotnet/razor/pull/9168, but some still remain. Getting a minimal repro for a test will be fun :)

Okay, maybe it wasn't that hard. Repros with:
<PageTitle>
    <PageTitle>Weather @DateTime.Now</PageTitle>
        <PageTitle>Weather</PageTitle>
    </PageTitle>

Removing the @DateTime.Now fixes the issue


az ad app credential reset fails when provided a description for the credential

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
The following command fails, and should succeed:
» az ad app credential reset --id "$APP_ID" --append --credential-description 'a description here' --end-date '2299-12-31'
When present, application key identifier cannot be empty and can be at most 32 bytes.
Parameter name: applicationKeyIdentifierValue

To Reproduce
Run the above command against an application registration.

Expected behavior
It succeeds, creating a new credential.

Environment summary
brew

Additional context

It seems like this is also https://github.com/Azure/azure-docs-powershell-azuread/issues/296 ; that bug was closed without any meaningful resolution. It seems like az is mixing up the description with something else. The error emitted here is grade A bonkers: "can be at most 32 bytes" when the input text is less than 32 bytes? It seems like it is getting mixed up with an encryption key, or something, and isn't actually transmitting the provided value as a description.
The value itself is also fine: it is possible to go to the Portal & create a new credential with the description a description here without problems. Hence, this seems to be an azure-cli problem.

@jiasli for awareness

I can reproduce. Here is the --debug output:
> az ad app credential reset --id 3524c502-0c73-45be-be20-eb8aec4e11bf --credential-description 'a description here' --debug

msrest.http_logger: Request URL: 'https://graph.windows.net/54826b22-38d6-4fb2-bad9-b7b93a3e9c5a/applications/63946374-6c70-4383-82f1-e30bafcb0dae?api-version=1.6'
msrest.http_logger: Request method: 'PATCH'
...
msrest.http_logger: Request body:
msrest.http_logger: {"passwordCredentials": [{"startDate": "2021-12-02T02:49:08.214061Z", "endDate": "2022-12-02T02:49:08.214061Z", "keyId": "60c8401c-d45c-4d8f-96fa-e925023fdafb", "value": "V0-GAQ6abG~DtAEu.B-D4Qp4JKN7noOFzj", "customKeyIdentifier": "//5hACAAZABlAHMAYwByAGkAcAB0AGkAbwBuACAAaABlAHIAZQA="}]}
...
msrest.http_logger: Response status: 400
...
msrest.http_logger: Response content:
msrest.http_logger: {"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"When present, application key identifier cannot be empty and can be at most 32 bytes.\r\nParameter name: applicationKeyIdentifierValue"},"requestId":"d11e09ac-042c-4a23-a36c-4b18f027671a","date":"2021-12-02T02:49:11"}}

--credential-description is UTF-16 encoded sent to AD Graph as customKeyIdentifier:
https://github.com/Azure/azure-cli/blob/3c3407952bf427c8f3381e4ab27e148bf8b29eb6/src/azure-cli/azure/cli/command_modules/role/custom.py#L1773-L1776
However, if we make a description here shorter, like key1, it will work:
> az ad app credential reset --id 3524c502-0c73-45be-be20-eb8aec4e11bf --credential-description 'key1' --debug

msrest.http_logger: Request URL: 'https://graph.windows.net/54826b22-38d6-4fb2-bad9-b7b93a3e9c5a/applications/63946374-6c70-4383-82f1-e30bafcb0dae?api-version=1.6'
msrest.http_logger: Request method: 'PATCH'
...
msrest.http_logger: Request body:
msrest.http_logger: {"passwordCredentials": [{"startDate": "2021-12-02T02:50:40.754299Z", "endDate": "2022-12-02T02:50:40.754299Z", "keyId": "f2a90fea-cf5b-46d7-9ec4-a0c50b4d26fc", "value": "JsE8F3f2HTwAaj6U.yDSo-.CJFkaFb.Yiv", "customKeyIdentifier": "//5rAGUAeQAxAA=="}]}
...
msrest.http_logger: Response status: 204

During Microsoft Graph migration (https://github.com/Azure/azure-cli/issues/12946), as discussed with AAD team, we are considering deprecating --credential-description. customKeyIdentifier will

not be used for passwordCredential, and
used as thumbprint of the certificate for keyCredential.

Instead, custom description string will be set as --display-name (displayName on the wire).


Settings Screen (+a few other bits)

This PR closes #12 by adding a settings screen, the option appears in the drawer alongside login/logout.
Currently in the settings screen, we have the locale selector, as mentioned in #42. However, due to the way the screen is built, the language is by default now English and will not be automatically detected based on the user's device settings, they will need to set it manually in our Settings (just like on the website)
There's also a dark mode / light mode / system theme dropdown, which defaults to the system theme. A few changes have been made across the app to improve the light mode experience, including adding a zero height AppBar to the ChannelScreen, which gives us a black status bar (on iOS) instead of having white status bar text on a white background.
When the dropdown is set to system theme, Flutter will automatically switch between dark mode and light mode based on the user's device preferences, including if the user changes their system theme while the app is running!
Of course both of these settings persist over restarts, thanks to a complete and utter mess of repo and bloc code.
Once this is merged, I'll probably work on the Mature Content popup, which I'll split into a separate issue from #12.

Looks great! Even the BLoC 👯


Enable GPU acceleration of Bloom filter join expressions by default

Fixes #8965.  Enables GpuBloomFilterMightContain and GpuBloomFilterAggregate by default and updates the tests accordingly.

build


Areeba changes

fixed increment/decrement buttons for mobile, added labels for power cell inputs

This still seems to have your old changes in it (and therefore has merge conflicts). You can make a new branch for only these changes.


Embedded mode is broken

e.g. https://xania.org/201611/compiler-explorer-now-supports-embedded-view shows blank pages.
One of those links is to:
https://gcc.godbolt.org/e#compiler:g62,filters:'colouriseAsm,compileOnChange,labels,directives,commentOnly,intel',options:'-O2',source:'//+Notice+how+the+compiler+is+smart+enough+to+
//+use+the+LEA+instruction+and+a+subtract+to
//+do+the+multiply.
int+multiplyBySeven(int+x)+{+
++return+x+*+7%3B+
}'
which similarly shows an empty page.
Marking this high priority as it affects existing blog posts etc out there. May have been broken for a while though, as I haven't checked in ages (oops!)

Just tried debugging locally [ http://localhost:10240/e#compiler:g62,filters:'colouriseAsm,compileOnChange,labels,directives,commentOnly,intel',options:'-O2',source:'//+Notice+how+the+compiler+is+smart+enough+to+
//+use+the+LEA+instruction+and+a+subtract+to
//+do+the+multiply.
int+multiplyBySeven(int+x)+{+
++return+x+*+7%3B+
}' ] but since webpack, I can't seem to set breakpoints in the code. @jaredwy any wisdom on debugging js post-webpack? I make dev then use Chrome's ability to un-source-map files and try to set breakpoints there...I think :grin:

Whoops! Ok @jaredwy nothing to do with webpack... breakpoints aren't being hit as the code I'm breakpointing isn't being run :-) ok...I think I have the fix! Sorry to at you in the middle of the night!

Fix deployed and confirmed working


Prevent circular references in the /Pages tree

/botio test

If I'm not mistaken, this looks like something that could reasonably easily be covered by a unit test. Could you update the PR with a unit test?

Could you update the PR with a unit test?

While I already have a test-case locally, please note that I'd prefer to wait for @brendandahl to sign-off on that though.

/botio-windows unittest

Thank you!


Capture output from ggutil web commands

Coverage increased (+0.09%) to 83.242% when pulling af27e5f641cf156a6712fcd2cb62a8b9c8422a1c on adericbourg:bgutil_web_commands into 942b9295f6eb4223b58a6925d637d80b1a72702c on criteo:master.


[URGENT] Added explicit class-transform dependency

Is it a breaking change?: NO
Why did you make these changes?
About 23 hours ago, class-validator-jsonschema released a new version (v1.3.0, minor version update). They changed dependency policy. Two critical packages (class-validator and class-transformer) were moved to peerDependencies from dependencies section. It breaks corgi dependent service builds because we never added class-transformer.
What's changed in these changes?

Added explicit class-validator and class-transform dependency

What do you especially want to get reviewed?
N/A
Is there any other comments that every teammate should know?
Due to severity, I will release a new corgi release without review.
Submission Type

[x] Bugfix

All Submissions

[x] Have you added an explanation of what your changes?
[x] Have you written new tests for your changes, as applicable?
[x] Have you checked potential side effects that could make bad impacts to other services?

Released to v2.1.1


change the id_fields for the sources that create id duplicates

turns out I was wrong and I (or someone) had already changed the stampy one


RetirementAggregatorV2 upgrade

Description
All instances of retirementAggregator have been removed and replaced with retirementAggregatorV2.
The frontend can successfully call specific and default retirements.
Related Ticket
Issue #681
Reviewers Requested
@Atmosfearful @ShimonD-KlimaDAO
Checklist

[X] I have run npm run build-all without errors
[X] I have formatted JS and TS files with npm run format-all

Hold off on merging until we fix #963

I was able to execute default/specific retirements using Klima  for UBO and NBO. I then tried to retire BCT using Klima, and was not prompted to approve the new Klima allowance amount to the contract. This results in gas estimation failure, as expected:

The question is - why was I not prompted to approve this amount before the retirement transaction? When I try to switch the "pay with" to usdc, I get the Approve prompt. When I then try to switch back "Pay with" to Klima, I get "Submit" right away. It's as if the frontend remembers that I already approved the contract to spend Klima, but doesn't re-check allowances.

I was able to execute default/specific retirements using Klima for UBO and NBO. I then tried to retire BCT using Klima, and was not prompted to approve the new Klima allowance amount to the contract. This results in gas estimation failure, as expected:
The question is - why was I not prompted to approve this amount before the retirement transaction? When I try to switch the "pay with" to usdc, I get the Approve prompt. When I then try to switch back "Pay with" to Klima, I get "Submit" right away. It's as if the frontend remembers that I already approved the contract to spend Klima, but doesn't re-check allowances.

Got it; I believe I found where the error was happening. At the risk of too many words, outlining the flow as it currently stands as I think this should be correct and work:

Get the retirement cost fromgetOffsetConsumptionCost (which uses either getSourceAmountSpecificRetirement or getSourceAmountDefaultRetirement)
app/actions/offset line 100

The approval flow adds 1% to the cost for slippage and approves that amount if the current allowance is insufficient.
handleApprove and getApprovalValue in app/components/views/Offset/index.tsx

Get the allowance of the payment method (i.e. inputToken) to pass in for maxAmountIn
https://github.com/KlimaDAO/klimadao/pull/960/files#diff-b68c42fa04a583195c0f40a15e663dcebdd59c469a31bac00a34e1848e2a6c06R355

format amount to be able to pass to contract
https://github.com/KlimaDAO/klimadao/pull/960/files#diff-6ad5ddf9bd7983af4e1ccb760b14f9e695320de4784621fa1288e84170087aaeR182-R186

Works well!


What's the best way to update Kuma? Updating Kuma to the latest version from 19.6

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem
What's the best way to update Kuma? Updating Kuma to the latest version from 19.6
📝 Error Message(s) or Log
No response
🐻 Uptime-Kuma Version
19.6
💻 Operating System and Arch
Ubuntu 20
🌐 Browser
edge, chrome
🐋 Docker Version
No response
🟩 NodeJS Version
No response

You can follow the instructions in the Wiki.


test for table widths

predefined table widths demo with data in list form

This adds a test/demo for overriding table widths.
Also found minor error in preelements in rtf.py.

Fixed and added 4 page formats (to format.py)
updated red text demo to include a page format selection

committed


[$1000] mWeb - Inconsistency bug: Clicking on enter works differently in assign task and confirm task page fields

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to staging new dot
Go to any chat and click on + icon
Click on assign task
Write anything on the title field and click enter, observe that the composer now jumps to the next field (description field)
Click on next and go to confirm task page
Edit the title to whatever you want and click enter, now observe clicking enter only closes the composer but doesnt jump the cursor to the next field

Expected Result:
Clicking enter should be consistent across data fields
Actual Result:
Clicking enter in assign task page jumps the composer to next field but in confirm task pages it only closes the composer.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/a9034883-0172-46ae-90f6-2032381e8739
https://github.com/Expensify/App/assets/93399543/977483d1-4977-4efa-aeae-678a308d19bd
Expensify/Expensify Issue URL:
Issue reported by: @sofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688204481929229
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01588b76bbbec7e195
Upwork Job ID:<PHONE_NUMBER>363022848
Last Price Increase: 2023-07-06

checking on how I reproduce android chrome without an android device
https://expensify.slack.com/archives/C01SKUP7QR0/p1688413388543049?thread_ts=1688413228.455539&cid=C01SKUP7QR0

Unassigning myself since @kevinksullivan was originally assigned and also a BZ member. I wonder why it triggered my assignment.

Hi, I'm Michael (Mykhailo) from Callstack and I would like to work in this issue.

Sounds good @rezkiy37

No "Overdue", I am investigating the issue.

Hello @rezkiy37 The flow for Task is changed on build <IP_ADDRESS>. Let me ask reporter to retest this issue again.

Hey @rezkiy37 I cant say i totally understood your question here? What is the question again?

Hey @rezkiy37 I cant say i totally understood your question here? What is the question again?

Hi!
Let me clarify. I mean that looks like inputs and their "enter" buttons work expected. The "Description" input is multiline, that's why it has a different behaviour. Once you click "enter", the app creates a new line.

Also, when you are on the "New task" screen, for each input there is a separate page. It is impossible to jump to the next field, because it is another screen. The app redirects back.

@SofoniasN Could you please clarify what should be fixed here?

Now that i think about it, this doesnt seem like an issue rather a feature cause as @rezkiy37 pointed out the confirm task page fields are two levels hence no need for the consistency.

Now that i think about it, this doesnt seem like an issue rather a feature cause as @rezkiy37 pointed out the confirm task page fields are two levels hence no need for the consistency.

So, does it mean that the issue should be closed?

Melvin, no "overdue" here. I am waiting for the decision from @SofoniasN.

@kevinksullivan you can go ahead and close this one.


nav bar and login fixes and changes

@oceanzus  should be ready

Looks good. @DanielJMaher @birdage Okay with merge?


How To Add Georgian Language Support?

Hello how to add Georgian Language in "Speakingurl"?

https://en.m.wikipedia.org/wiki/Romanization_of_Georgian
ISO 9984
The transliteration table has to be added to speakingurl
If you can send a pull request, we can quickly release a new version ;-) otherwise you have to wait, Eventually I can take a look into this at the weekend

Hello again... Thanks for the reply...
if you can show me the example how it is done, I'll try to do it by myself.......
:+1:

@vdanelia Take a look in lib/speakingurl.js

ok I found it... i'll add Georgian ....
:)

:+1:

I suggest to use the latest ISO and not to wait for @pid to respond. Just send the pull request.
@pid What about a playground / demo for contributors with a input and output field?

hello @redaxmedia  ... ISO 9984-(1996) is very strange standard, no one uses that, no one site or person... because it consists with non georgian symblos (characters)... so I'll do National system-(2002)..

I'm finishing it and will make pull request today or tomorrow... 👍

You did something wrong, I commented the pull request.

@redaxmedia please run "gulp" before you commit, this will beautify your files, runs the test, you added test? 😉 .... so the formating will be unique

Well, it is not me - it is @vdanelia who sends the pull request ... I guess he does not know how to run gulp

V12.0.0 is released, with Support for Georgian

Great move! Thank you

Perfect...
Greatest Thanks


DIE New Sheet

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[X] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is:  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <Rowan, Rook and Decard> (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is:  (i.e. Dungeons & Dragons, FATE)

[X] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Adding a new character sheet, because the system does not have an official version

Character Sheet Info Roll20 Internal Use only.

I have fixed the closing tag. Thank you for catching that!
On 11/2/2023 1:28:58 PM, Nora Cahill @.***> wrote:
@NorWhal commented on this pull request.
In DIE/die.html [https://github.com/Roll20/roll20-character-sheets/pull/12257#discussion_r1380551755]:

3 + They feel it as intensely as most people will ever feel it. +  +  + 4 + More intense than love for a soulmate. +  +  + 5 + All-consuming obsession. +  +  + 6+ + Supernaturally intense. Likely lethal. +  +

We saw you were using tables, and I noticed this one doesn't have a proper closing tag while running ctrl-f to ensure you weren't breaking our policy [https://wiki.roll20.net/Designing_Character_Sheet_Layout#HTML_Table]!
⬇ Suggested change

 +

—
Reply to this email directly, view it on GitHub [https://github.com/Roll20/roll20-character-sheets/pull/12257#pullrequestreview-1710897407], or unsubscribe [https://github.com/notifications/unsubscribe-auth/A4WYTTLWFITKA3SXLVIHW53YCPJ5RAVCNFSM6AAAAAA6QA4OHKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJQHA4TONBQG4].
You are receiving this because you authored the thread.Message ID: @.***>


Automatically close the list of options after choosing the item in multiple mode.

Hi,
Is it possible to have the option to close the list of items by choosing the item in the "multiple" mode?

Hi @C00per, you can use the api property to close the selector every time the model changes (using the native $watch method). Have you already tried it?

@indrimuska, I'll give it a try. However, It seems that using the api property is the too complicated solution.

It's not so hard to implement, check out this plunker:
http://plnkr.co/edit/RsvH9LkSfwjq60sbMepR?p=preview

Great! Thank you!

 :)

@C00per you can now use closeAfterSelection property.
Check out #45.


docs(Router): remove duplicate "activated"

Solves https://github.com/angular/angular.io/issues/1953.

Thanks


Stellaris - show a warning if is_triggered_only = yes is missing in an event

is_triggered_only = yes should be present in every event, or it will fire every day with no way to stop it.
In IDEA this feature will be a new Inspection, and the name, may be NonTriggeredEventInspection.
This should only for Stellaris, check for all events, at warning level by default.

Implemented in 1.3.22


notebooks/deploy-mixtral.ipynb issue

This is not really an issue, but I couldn't find any other way to contact you. I was trying to follow your instructions on https://www.philschmid.de/sagemaker-deploy-mixtral and ended up in this repository.
I tried to follow the deployment instructions, but the deployment was not successful. I got the following error logs on the inference endpoint:
2023-12-15T20:06:10.216+01:00	> File "/opt/conda/lib/python3.10/site-packages/text_generation_server/server.py", line 161, in serve_inner model = get_model( File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/__init__.py", line 310, in get_model return FlashMixtral( File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/flash_mixtral.py", line 21, in __init__ super(FlashMixtral, self).__init__( File "/opt/conda/lib/python3.10/site-packages/text_generation_server/models/flash_mistral.py", line 318, in __init__ SLIDING_WINDOW_BLOCKS = math.ceil(config.sliding_window / BLOCK_SIZE)
2023-12-15T20:06:10.216+01:00	TypeError: unsupported operand type(s) for /: 'NoneType' and 'int'

The HF image that I ended up using was<PHONE_NUMBER>84.dkr.ecr.us-east-1.amazonaws.com/huggingface-pytorch-tgi-inference:2.1.1-tgi1.3.1-gpu-py310-cu121-ubuntu20.04
looking into TGI issues, and found this thread. It seems to be fixed by a commit mentioned in the thread.
But I don't how can I get the latest DLC image of 1.3.3 for a sagemaker deployment, because when I specify the version in image_uris.retrieve or in get_huggingface_llm_image_uri, it complains:
ValueError: Unsupported huggingface-llm version: 1.3.3. You may need to upgrade your SDK version (pip install -U sagemaker) for newer huggingface-llm versions. Supported huggingface-llm version(s): 0.6.0, 0.8.2, 0.9.3, 1.0.3, 1.1.0, 1.2.0, 1.3.1, 0.6, 0.8, 0.9, 1.0, 1.1, 1.2, 1.3.

I don't know the procedure for having the latest version ending up in aws-dkr or how we can use a custom-built DLC image when deploying to Sagemaker.
Can you help in any way, or can you explain how your deployment works?
Thanks in advance

I just opened an issue on sagemaker itself because I think it's an issue with the sagemaker SDK that's limiting some versions.

Thank you for taking the time to create the PR :pray:  I hope it gets the needed attention.

@LvffY, by the way, do you know any other way of deploying the model as an inference? I want to try the model on AWS, but so far, I found no way to do that.

Thanks for adding the ticket! I am also blocked by this issue.

@LvffY, by the way, do you know any other way of deploying the model as an inference? I want to try the model on AWS, but so far, I found no way to do that.

@existme not at the time

I came with the same problem.
Huggingface has released a newer version of the image which is accessible via sagemaker:<PHONE_NUMBER>84.dkr.ecr.eu-central-1.amazonaws.com/huggingface-pytorch-tgi-inference:2.1.1-tgi1.3.3-gpu-py310-cu121-ubuntu20.04-v1.0


Support multiple flash devices (slot 0 internal, slot 1+scratch external)

There are some concerns that need to be addressed to support a configuration where slot 0 is on an internal flash device, and slot 1 and scratch are on a larger external flash. This allows most of the internal flash to be used for code.

Although there is some support in the code, it hasn't been tested, so will need simulator support to test this.
The Zephyr port is hardcoded for a single flash device.
How to handle the write alignment being different between internal and external flash devices.
Addressing issues discovered by the above.

subtask: https://github.com/runtimeco/mcuboot/issues/326

Although there is some support in the code, it hasn't been tested, so will need simulator support to test this.
How to handle the write alignment being different between internal and external flash devices.

Both those features have been implemented already. I am not sure if this is already working on Zephyr, but on Mynewt is totally works.

I think we can close this.

Yes, this works in Mynewt and Zephyr.

Although the description above mentions putting scratch on the external device, which is definitely not what you want for encrypted images, and probably not what you want for even regular upgrades (as it provides an area for attack when interrupting an update.
Otherwise, though, I do think this is no longer relevant.


Draw / Edit Rectangles with proportion

F.e. 4:3 or w:120(mm) h:90(mm)

@Falke-Design Falke-Design added the feature request label on Nov 1, 2020


[ISSUE #7781] Get namespace from gRPC header

Which Issue(s) This PR Fixes

Fixes #7781
Brief Description
Get namespace from gRPC x-mq-namespace header.

How Did You Test This Change?

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (92e058c) 43.25% compared to head (14b57fd) 43.21%.

Files
Patch %
Lines

...org/apache/rocketmq/proxy/common/ProxyContext.java
66.66%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7782      +/-   ##
=============================================
- Coverage      43.25%   43.21%   -0.04%
+ Complexity      9871     9870       -1
=============================================
  Files           1173     1173
  Lines          85030    85034       +4
  Branches       11013    11013
=============================================
- Hits           36782    36751      -31
- Misses         43681    43717      +36
+ Partials        4567     4566       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add code snippet titles to astro-components.md

What kind of changes does this PR include?

New or updated content

Description

Used our new title feature to add file tabs to the code snippets on this page.

LGTM. Note that the title is only GreetingHeadline.astro on line 197 (GitHub doesn't let me comment inside lines that weren't modified) rather than having the full file path, I don't have strong feelings about this but maybe we want to follow a pattern of always including the path?

Great catch! I'll add the missing path! :)


Write Builders manually 2

#101  without changes in Error hierarchy.
Should slightly be easier to review.

bors try

r? @Emilgardis

bors try

Done.


add reference to TDPL

Please don't remove indemt otherwise we get two separate code boxes.

Oh I didn't know that. Sorry.


virtual desktops sometimes completly broken

I don't know what exactly causes it, but sometimes the virtual desktops become completly broken... The only way to remedy this I found is to restart Hyprland and to hope to not trigger it again.
Based on the workspace indicators on my waybar, I can tell, that this happens whenever both workspaces representing a single desk (e.g. workspaces 1,2 for desk 1) are somehow one the same monitor (according to waybar). Then I get very glitchy behavior. I get unrendered some unrendered windows. Also just the act of moving the mouse from one monitor to the other makes the workspaces somehow swap between monitors and I can't get to the other workspace anymore... It's very weird.
Running hyprctl reload or hyprctl dispatch vdeskreset cannot fix this.
One thing that might play a role is, the fact, that when starting hyprland I first deactivate the internal monitor (monitor 3 if you want so).

Hi, sometimes this also happens to me, and it's most likely due to monitors layout changing (in your case, internal monitor going off).
I think this happens because the plugin by default tries to remember layouts and workspaces, but it's not easy to track when the workspace change is triggered by the user or by hyprland.
I'll take a look into this. In the meantime, if vdeskreset doesn't work, you could try specify rememberlayout = none in the configuration options

Yes I agree, changing layouts does seem to cause this. Also when first having no monitor connected and my internal monitor turned on and then just connecting a 2nd monitor causes a bug, where there is a weird workspace setup.
Setting rememberlayout = none still makes the problem happen. To only apparently sure way to have a working setup, is to start hyprland with all monitors I want plugged in (for now just one addiontal one) and then not messing with the monitor layout.

Can you check if this happens on hyprland 0.39.1 as well?

I'm having a hard time downgrading on NixOS... Using an old flake.lock gives a build error...
I will however try to investigate the error further and provide new information.

I see. I use arch, so unfortunately cannot really help there. Also, you forgot to say which tool you're using to shutdown/ power up the monitors

Usually I do use kanshi, but unfortunatly it doesn't work for hyprland v40, see hyprwm/Hyprland#5978.
So instead I currently modify my monitor setup manually using hyprctl keyword monitor ...

Yeah, this happens every now and then unfortunately. Just yesterday night I opened this PR on another small tool which is using hyprctl directly.
Until hyprland stabilises, it might be a better solution IMO.
Anyway, please also attach hyprland logs of when this behaviour happens

Hi! The kanshi problem was fixed upstream. Does this happen with kanshi too? If you can reproduce it, could you attach the hyprland log?

Maybe it was fixed. I don't think I've ever experienced this issue, except when I first installed the plugin (on NixOS). Either logging out or rebooting solved the issue; I don't recall.

That's good to know! Unfortunately, I think this problem (vdesks going crazy etc) is still present, despite rather unpredictable. One day I'll look into it. Most likely, it will require changes in Hyprland itself to send an event before/after workspaces have been "adjusted", following a monitor connection/disconnection

Hmm, come to think of it I generally keep my monitors on at all times. I will test when I have access to them.
It's remarkable that your first plugin is so good considering the complex nature of the situation. I'm repeating myself but virtual desktops kept me on Plasma until now so I'm very grateful for this project.

Thanks for the kind words. And yes, I also just can't work without this metaphor anymore :)

hey, just curious. Is this still happening? I feel like on aquamarine this stuff kind of fixed itsef (?)

I don't use this plugin anymore, since it wasn't working for me at the time.

hey, just curious. Is this still happening? I feel like on aquamarine this stuff kind of fixed itsef (?)

Hi, I've had this issue for some time now.
I can't really reproduce it but it happens to me almost every time I want to move a window from say vdesk 1 to vdesk 2 after on vdesk 1 all three monitors were populated with a window.
On vdesk 2 the window in some kind of background layer and I can open other windows on top of it. Sometimes new windows created on vdesk 2 then are buggy and take space but get invisible.
In most of the cases I'm able to "fix" this issue by going to vdesk 3 and populating every monitor with a window and then switching back to vdesk 2. If this does not work I repeat the same process with vdesk 4 etc.
I've suspected hyprland to cause this bug for quite some time now but I'm getting the feeling it's this plugin which causes this behavior. I've not yet had the time to dig through the source to find possible reasons for this behavior but I'll have a look in the next weeks and let you know if I find something

Thank you for the details. For this weird behaviours, I've always suspected the code that handles the monitor connection/disconnection. When this happens, hyprland re-adapts the windows on the workspaces, possibly messing up with the virtual desktop layouts.
I've never found a proper way to deal with this, othert than what I did in the code so far. I think only way would be for hyprland to expose an event for "after" monitor connection/disconnection actions (i.e., after hyprland is done doing its stuff upon monitor connection/disconnection)

But when the code which handles the monitor connection/disconnection is the culprit I should not have any issues on my desktop where all monitors are "hardwired" and connected at boot or am I wrong?

mh not really, because the monitor connection event would anyway be sent twice (assuming you have two monitors) by Hyprland

Fair enough, I just wondered because on my laptop I've never had any problems. I only use the laptop with it's inbuilt monitor but still have the plugin enabled.


Tag a release?

since master allows/uses Stipple 0.9?
For me this package downgraded DataStructures, and I wasn't even sure if important to your package or others, it just seem like you would want it at latest (and well pretty much all packages).
I realize I can use master, not sure all do. Is that usually the recommendation up to 1.0 version (e.g. not for Genie)?
There seems to be no breaking change to this package, but Stipple 0.9 is, does a breaking change in a dependency mean the using package should have a breaking version number? I guess it does if it requires it, in your case you allow older Stipple, but is that adviced?

Just tagged the new versions of Stipple, StippleUI and StippleCharts. Now we have to wait for the robot to register the versions.

All done


Adds virtual filter 'research_and_statistics'

Adds virtual filter 'research_and_statistics'
Filtering by upcoming statistics, published statistics or by research requires multiple filters (eg format and release timestamp), which cannot be easily done in finder frontend. This adds a 'virtual filter' that of 'research_and_statistics' which can be easily used by finder frontend to filter by 'upcoming_statistics', 'published_statistics' or 'research' to filter to these results without having to provide more than one filter.
Some effort has been made to make it easy to extend this if necessary in the future
Trello: https://trello.com/c/QpM8Vhwv/590-bug-stats-finder-is-only-displaying-a-few-upcoming-stats-docs
Trello: https://trello.com/c/mkf4eUXF/593-bug-stats-finder-displaying-wrong-number-of-published-stats-docs

I have a general question around how these changes should be giving us more results, because as long as content items are tagged to the correct document types (the announcement document types for upcoming, non-announcement document types for published) (which seems to be the case on Whitehall prod), then we shouldn't need to do anything?
On the other hand, this solves the issue with only 36 upcoming statistics being shown at present in the new finder. Interestingly, the dev docs for the upcoming stats document types sum up to a total of 36 documents when there are in fact many more - it is using the GOV.UK search index for this (example: https://docs.publishing.service.gov.uk/document-types/official_statistics_announcement.html).
This is perhaps warrants an investigation into what's happening, but in the meantime to publish the research and stats finder now with this PR.


fix(row): filtered row with filterRowComparator give runtime error

on filter function this.gantt is udedined
and the array contains data not row then do not need to actual.model

Coverage increased (+0.22%) to 60.03% when pulling 1c03f9abffc0b4ecef3d83275ee044334416d43a on henkensm:fix(row)filtered into ffa55de212ed35c96f44e54cd8e928fe9d370fb9 on angular-gantt:master.

Thanks ! Please run the project and demo build next time, see CONTRIBUTING file.


[BUG]: No return from PDF toggle

Describe the bug
Whenever the toggle between Extractions and PDF is visible, clicking on PDF changes the header in a way that makes it impossible to return to the extractions.
From explorer:

After clicking on PDF toggle:

From the resources panel in the project:

After clicking on PDF toggle:

This is a duplicate.


Simplify and unify local address getting method

What is the purpose of the change
#8676

Codecov Report

Merging #8677 (1407a4e) into 3.0 (82f9a6b) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

:exclamation: Current head 1407a4e differs from pull request most recent head 744fde7. Consider uploading reports for the commit 744fde7 to get more accurate results

@@             Coverage Diff              @@
##                3.0    #8677      +/-   ##
============================================
- Coverage     63.76%   63.57%   -0.19%
  Complexity      312      312
============================================
  Files          1141     1141
  Lines         47846    47796      -50
  Branches       7194     7159      -35
============================================
- Hits          30508    30387     -121
- Misses        13985    14047      +62
- Partials       3353     3362       +9

Impacted Files
Coverage Δ

...n/java/org/apache/dubbo/common/utils/NetUtils.java
67.33% <100.00%> (-1.88%)
:arrow_down:

...in/java/org/apache/dubbo/config/ServiceConfig.java
71.91% <100.00%> (-0.75%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-20.69%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
43.47% <0.00%> (-15.22%)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75.00% <0.00%> (-12.50%)
:arrow_down:

...ubbo/registry/client/AbstractServiceDiscovery.java
87.50% <0.00%> (-12.50%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

.../remoting/transport/netty4/NettyServerHandler.java
62.79% <0.00%> (-9.31%)
:arrow_down:

...moting/transport/netty4/NettyEventLoopFactory.java
22.22% <0.00%> (-7.78%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f9a6b...744fde7. Read the comment docs.


Sync

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

...ress/logic/parser/FilterPropertyCommandParser.java
91.42%
0 Missing and 3 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ
Complexity Δ

...eedu/address/logic/commands/AddMeetingCommand.java
66.66% <100.00%> (+0.87%)
9.00 <1.00> (ø)

...u/address/logic/commands/DeleteMeetingCommand.java
85.29% <ø> (ø)
12.00 <0.00> (ø)

...address/logic/parser/AddPropertyCommandParser.java
100.00% <100.00%> (+5.00%)
10.00 <3.00> (+5.00)

...ain/java/seedu/address/logic/parser/CliSyntax.java
94.44% <ø> (ø)
1.00 <0.00> (ø)

.../java/seedu/address/model/meeting/MeetingDate.java
94.73% <ø> (ø)
7.00 <0.00> (ø)

...ress/logic/parser/FilterPropertyCommandParser.java
89.65% <91.42%> (-7.57%)
24.00 <6.00> (+10.00)
:arrow_down:


PDF Export / PDF Report Viewer Like RDLC Report

@unchase what do you think about this

I think it's good idea.

Since RDLC has not implemented out of the box with dotnet core . I'm not sure which one is good for pdf viewing.

@chhinsras Blazor.Printing is awesome. Please check it. Thanks!

@Sharafudeen Look good. One issue I'm having with itextsharp or pdf generation library is khmer language script. Rdlc works fine.
Will have a look into this

@Sharafudeen Look good. One issue I'm having with itextsharp or pdf generation library is khmer language script. Rdlc works fine.
Will have a look into this.
You can have a look into this repo: https://github.com/chhinsras/AspNetCoreRDLC

Agree with RDLC and suggested repo looks great and good to go!

@Sharafudeen Can you test rdlc if it works with cross platform. Also the file path on windows and mac are different

@chhinsras I've checked that repo it references AspNetReports project but it is not added in the solution. I will do analysis of cross platform support in RDLC.
Note: I do not have mac to test :(
My suggestion: We can also keep Blazor.Printing like libraries as an optional solution for generating and printing reports. And also it will be useful for those who does not want to build reports in RDLC.

@Sharafudeen either is fine. But can you test the font . KhmerOSBattambang


Merge storage refactor back to master

Seems like this PR is a mix or previously reviewed changes and new changes. If it is so, would it be possible to have a separate PR for new changes to review so the feature branch can be merged without review after that?

This change is generally all previously reviewed changes (the ones you screenshotted were reviewed in #5307).


Provide a pipeline assembly helper API

Provide an API to define a pipeline with:

an initial publisher,
a list of processors,
a subscriber.

Won't do, let's stick to a model where publishers have an upstream when they are operators, and processors are more an implementation detail inside these operators.


Feature request: add padding option to block ciphers

Summary
The DES and AES are using PKCS#7 padding all the time, even if the original data is not padded. That's causing Unable to decrypt input with these parameters. in the CyberChef.
We can add a new option for user to specify the padding method.

Duplicate of #416

Sorry I forgot to search first. I apologize 😣


Add support for type application in the type parser

After PR #176 it looks like the parser is the only thing blocking the addition of functors and alike to the catalog.
The parser/type builder should be extended to support types like:
fmap :: Functor f => (a -> b) -> f a -> f b
sequence_ :: Monad m => [m a] -> m ()
traverse :: (Traversable t, Applicative f) => (a -> f b) -> t a -> f (t b)
first :: Arrow a => a b c -> a (b, d) (c, d)

I've linked a branch that adds rudimentary type application parsing to the type parser.
I think we also need something else, though - Viskell must be able to deduce that a list (any list) is a Functor, for example. I'm not yet seeing how that would fit in the catalog.

I think something along the following lines will do just fine:
       <class name="Functor">
        	<instance name="Maybe"/>
        	<instance name="[]"/>
        	<instance name="IO"/>
        </class>

Right, that looks reasonable. I'll give it a try.

Sweet, seems to work for Maybe:

[] is not a type constructor according to the parser, because it doesn't start with a capital letter. I'll try to correct that.

See #178.

Fixed by #178


better error message when bodhi query times out

ERROR    ServerError(https://bodhi.fedoraproject.org/latest_builds, 504, Error returned from json module while processing b'https://bodhi.fedoraproject.org/latest_builds': b'Expecting value: line 1 column 1 (char 0)'
b"
504 Gateway Time-out
\nThe server didn't respond in time.\n\n")
Unexpected exception occurred,
please fill an issue here:
https://github.com/packit-service/packit/issues

AI: Have nicer/cleaner message

Isn't this fixed here?
https://github.com/packit-service/packit/pull/631

Ok, let's consider this fixed.


deprecation warning for geojson-normalize

Changed it to @mapbox/geojson-normalize, should be a quick update.

@apercu @Pessimistress @gnavvy - Let's get this one done as part of our new GeoJson layer.

@ibgreen What about proposing a PR for them to support immutable? I don't feel like implementing all of our dependencies (even if small) in our code is a good idea, it's a very slippery slope.

What about proposing a PR for them to support immutable?

@apercu I'd be surprised if mapbox had an interest in supporting Immutable. It is something that becomes interesting mainly when one works with react, which is something we have been adding on top of their stuff.

I don't feel like implementing all of our dependencies (even if small) in our code is a good idea, it's a very slippery slope.

It's a good discussion, but in this particular case I'm decided. We are already building in deep knowledge of the geojson format into our layers, why should we suddenly use an external module for a small part of the necessary code. Especially if writing our own could enable us to e.g. support Immutable data structures.
I already wrote an implementation of this, as you can see it is very simple. I will put up a PR later that shows how it can support Immutable (without importing Immutable.js, of course).
export default function normalizeGeojson(geojson) {
  const type = geojson.type;
  switch (type) {
  case 'Point':
  case 'MultiPoint':
  case 'LineString':
  case 'MultiLineString':
  case 'Polygon':
  case 'MultiPolygon':
  case 'GeometryCollection':
    // Wrap the geometry object in a "Feature" and add the feature to a "FeatureCollection"
    return {
      type: 'FeatureCollection',
      features: [
        {type: 'Feature', properties: {}, geometry: geojson}
      ]
    };
  case 'Feature':
    // Add the feature to a "FeatureCollection"
    return {
      type: 'FeatureCollection',
      features: [geojson]
    };
  case 'FeatureCollection':
    // Just return the feature collection
    return geojson;
  default:
    throw new Error('Unknown geojson type');
  }
}

One benefit I'd like to have from this migration is the ability to handle an array of features. Such an array is not a valid GeoJSON object, therefore does not fit in the geojson-normalize context.
In our use case, though, consider the GeoJSONLayer: it takes a featureCollection and sort it into three arrays of features by type to pass into the ScatterplotLayer, PolygonLayer and PathLayer. It doesn't make sense if we have to cast them into new featureCollections just for the PolygonLayer and PathLayer to understand.

Removed on dev