Implement context-based separate undo/redo stacks

See this proposal for a description and my argument for contextual undo.
This PR is mainly intended to continue discussions on how per-scene undo may be implemented; 'contextual undo' is just one idea I had for doing it, and other ideas would be gratefully accepted.
Note that this modifies the internals of undo_redo.cpp in order to let it support multiple stacks, but essentially the same approach could be used except with using one UndoRedo object per stack; the API would be changed in a different way and this would be a more object-oriented approach, I just happened to prefer the processing and memory benefits of not instantiating the relatively heavy UndoRedo class multiple times. This 'contextual undo' implementation is focused on an approach to separating stacks and handling context, so the details of how different stacks are accessed are less important.
https://user-images.githubusercontent.com/66553618/160278845-78333a5a-ccbb-4127-8f52-d369ae01cf27.mp4

NOTE: the current version is limited in two significant ways. Later today or tomorrow I can push a version which fixes the main limitation, although I don't know when I can fix the second as it relies on a helper method which I can't currently find (for getting the focused viewport/window).
Other problems almost certainly exist, but after these two are fixed most special cases (i.e. UndoRedo in specialised docks) can be made to work correctly with a single _register_undo_context call.

Can you rebase? I was going to give it a test.

Can you rebase? I was going to give it a test.

Yes, now done, thanks (;
I've now updated it to the latest commit on master, cleaned a few bits up, and additionally added warnings for where context couldn't be detected (meaning an additional line must be added) and for bits of the scene versioning that might need to be reworked.

I have decided not to take the approach to multiple stacks (EditorUndoRedoManager) used in #59564. Mine will continue using multiple stacks per UndoRedo object along with the other ideas/differences I'm currently going with. When it comes to comparing the two if such a thing happens, all of the differences can be looked at and chosen from. I don't feel they need to be reduced, especially since this approach has benefits in my opinion (though there are downsides as well naturally).

@Calinou Just wondering, is it possible for you to convert this to a draft please? I believe it more accurately describes the state of this PR. I'm assuming that you're one of the people with the privileges to do that if it can be done.

Ok I did a brief testing and found an issue as expected. I added a GradientTexture2D to a Sprite2D and edited the texture. Setting texture and modifying the texture were stored on 2 separate undo stacks. I find this design a bit weird. The texture was part of the scene, so modifying it was technically a modification of the scene, but its history is inside some weird context. Also I wasn't able to switch to inspector context by clicking (even though it was highlighted), only modifying the texture was able to switch the context properly.
btw the editor crashes when you undo with empty history.

Setting texture and modifying the texture were stored on 2 separate undo stacks. I find this design a bit weird.

I agree that it is a bit weird. I think it could potentially work (though focus might have to become a bit more predictable and clear in certain areas), and it makes a kind of sense despite being less obvious; setting and modifying resources definitely have to be separate with this design, and it means you can retain the state and actions on a particular resource once it's removed in case it's added back later. Hopefully I can make this PR properly demonstrate what I'm thinking of here.

The texture was part of the scene, so modifying it was technically a modification of the scene, but its history is inside some weird context

Yeah, I haven't adapted history yet so they might all just be counted as scene changes for now; something else might need to be used for displaying this information, even if just in a popup when exiting. If you mean inherent weirdness of the idea then, again, it is weird but I think it could work if implemented well.

I wasn't able to switch to inspector context by clicking (even though it was highlighted)

The actual sub-window, or something inside it, must be highlighted. Having the whole inspector highlighted just means the context is whatever the top level inspector is editing (in this case, the Sprite2D; so the scene). UI would need improving for this to work easily, especially since focus seems to like switching back to the scene when you drag a property slider.

the editor crashes when you undo with empty history

Thanks for letting me know! I only just refactored a lot of this and forgot to test that part of the functionality. I'll have it fixed on the next push.

Superseded by #59564
Technically the feature could still be implemented, but due to its purpose, it's no longer needed.
Though it doesn't seem compatibility breaking, so maybe it could be moved to 3.x branch. But that's lots of work, idk.
Thanks for the contribution nonetheless.


Increase timeout for providers, add new timeout status code

During testing with @nerdyverde we noticed that if the device is busy (such as
installing app updates) that the two second timeout is often insufficient, resulting
in failure to retrieve. This PR boosts the timeout to 4 seconds, and introduces
an explicit timeout error code to make it easier to understand when this happens.

Codecov Report

Merging #136 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage      72.2%   72.19%   -0.02%
  Complexity      476      476
============================================
  Files            64       64
  Lines          2634     2636       +2
  Branches        243      243
============================================
+ Hits           1902     1903       +1
- Misses          661      663       +2
+ Partials         71       70       -1

Impacted Files
Coverage Δ
Complexity Δ

...nyolo/api/internal/CredentialRetrieveActivity.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...rg/openyolo/protocol/CredentialRetrieveResult.java
91.89% <100%> (+0.22%)
12 <0> (ø)
:arrow_down:

bbq/java/com/google/bbq/BroadcastQueryClient.java
54.68% <0%> (-0.79%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784e30d...9ea3ab1. Read the comment docs.


v2.0.0

Beginning of discussion here #1

ping @ethers

@fanatid This is great!  Thank you!  I'll also add you on npm


esphome: Component not found: font.

Describe the bug
compilation fails with minimal example (see below). used to work in nixos 23.05, but is now broken on nixos 23.11 and master.
INFO ESPHome 2023.11.6
INFO Reading configuration /var/lib/esphome/test.yaml...
Failed config

font: [source /var/lib/esphome/test.yaml:36]

  Component not found: font.
  - file: weise-pixel.ttf
    id: digit_font
    size: 8

I tried patching the pillow version: https://github.com/NixOS/nixpkgs/compare/master...Stunkymonkey:nixpkgs:esphome-patch-pillow-10.1.0 But sadly the same result.
With the official docker image the compilation works.
Steps To Reproduce
Steps to reproduce the behavior:

copy minimal example
compile
see error

Expected behavior
compilation works.
Screenshots

Additional context
Minimal example
esphome:
  name: test
  friendly_name: test

esp8266:
  board: nodemcuv2

# Enable logging
logger:

# Enable Home Assistant API
api:
  encryption:
    key: "NGYeKcZvhRMUV6dY0UrI+Kk0is0Si6MteS/awYxXk+Q="

ota:
  password: "940c7ad78caf2dc2257030fbfc1eef43"

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

captive_portal:

# matrix
time:
  - platform: sntp
    id: sntp_time
    timezone: "Europe/Berlin"

spi:
  clk_pin: D1
  mosi_pin: D3

font:
  - file: "weise-pixel.ttf"
    id: digit_font
    size: 8

display:
  - platform: max7219digit
    id: led_matrix
    scroll_enable: False
    cs_pin: D2
    num_chips: 4
    intensity: 0
    lambda: |-
      it.strftime(0, 1, id(digit_font), "%H:%M", id(sntp_time).now());

Notify maintainers
@globin @hexa @oddlama
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-linux"`
 - host os: `Linux 6.1.21, NixOS, 24.05 (Uakari), 24.05.20231204.c542e2c`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/store/f8lzbrj0yck7pa5yghwyyg9a1yl508qm-i6dl9wwr6hs6jb09lqjav5j663mm74ra-source`

Add a :+1: reaction to issues you find important.

the problem was the exact pillow version was not correct. by updating the package it will be fixed. see pr #277425

The example still doesn't work for me on this PR.

Is the "font" file missing? If yes better use gfonts. sorry for that.
better Minimal example
esphome:
  name: test
  friendly_name: test

esp8266:
  board: nodemcuv2

# Enable logging
logger:

# Enable Home Assistant API
api:
  encryption:
    key: "NGYeKcZvhRMUV6dY0UrI+Kk0is0Si6MteS/awYxXk+Q="

ota:
  password: "940c7ad78caf2dc2257030fbfc1eef43"

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

captive_portal:

# matrix
time:
  - platform: sntp
    id: sntp_time
    timezone: "Europe/Berlin"

spi:
  clk_pin: D1
  mosi_pin: D3

font:
  - file:
      type: gfonts
      family: Roboto
      weight: 900
    id: digit_font
    size: 8

display:
  - platform: max7219digit
    id: led_matrix
    scroll_enable: False
    cs_pin: D2
    num_chips: 4
    intensity: 0
    lambda: |-
      it.strftime(0, 1, id(digit_font), "%H:%M", id(sntp_time).now());

is fixed now.

Still not working for me, no matter what.
I've checked everything I can, including the pillow version 10.2.0, which is correct in latest unstable.  I am not able to isolate the problem.  The error is too unhelpful in not saying why the font component is broken.
I've been reduced to doing the following (because I have no alternative):
pip-shell.nix:
{ pkgs ? import <nixpkgs> {} }:
(pkgs.buildFHSUserEnv {
  name = "pipzone";
  targetPkgs = pkgs: (with pkgs; [
    python311
    python311Packages.pip
    python311Packages.virtualenv
  ]);
  runScript = "bash";
}).env

Then

export NIXPKGS_ALLOW_UNFREE=1
nix-shell pip-shell.nix
python -m venv venv_esphome    # [ONCE]
source venv_esphome/bin/activate
pip install esphome    # [ONCE]

try esphome compiling something with a font to get:

Please install the pillow python package to use this feature. (pip install "pillow==10.2.0").

pip install "pillow==10.2.0" # [ONCE]

Same problem here. Im using Esphome CLI on a mac with the following yaml:
esphome:
  name: esp32-s3-box-3
  friendly_name: ESP32 S3 Box 3
  name_add_mac_suffix: false

packages:
  esphome.voice-assistant: github://esphome/firmware/wake-word-voice-assistant/esp32-s3-box-3.yaml@main

logger:

api:
  encryption:
    key: !secret api_encryption_key

ota:
  safe_mode: true
  reboot_timeout: 10min
  num_attempts: 5
  password: !secret ota_password

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password
  ap:
    ssid: TEST
    password: !secret ap_password

captive_portal:

And Im getting:
Failed config

image: [source .esphome/packages/c46f54c1/wake-word-voice-assistant/esp32-s3-box-3.yaml:415]

  Component not found: image.

...

display.ili9xxx: [source .esphome/packages/c46f54c1/wake-word-voice-assistant/esp32-s3-box-3.yaml:513]

  Please install the pillow python package to use this feature. (pip install "pillow==10.2.0").

...

I have pillow 10.2.0 installed:
❯ pip list | grep pillow
pillow                   10.2.0

@goatchurchprime did you find a workaround?

With the following bits of config I think I should be able to reproduce your issue, but I can't.
Using esphome 2024.2.0 from nixpkgs master.
# wifi, captive_portal, logger, time, api, web_sever, ota included

esphome:
  name: esp32-s3-box-3
  friendly_name: ESP32 S3 Box 3
  name_add_mac_suffix: false

packages:
  esphome.voice-assistant: github://esphome/firmware/wake-word-voice-assistant/esp32-s3-box-3.yaml@main

Full build log

Thanks for looking into it @mweinelt. Im using Version: 2024.2.2 from homebrew if that makes any difference

Sorry my fault, but your pointer about python version got me to get the latest pypi version and that fixed the issue, so thanks!


[bugfix] RibbonGallery.addButton should return a tuple of two buttons

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 73.602%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.02%

Covered Lines:
987

Relevant Lines:
1341

💛  - Coveralls


Annotation from GAF is attached to the first transcript only

For example on the wtf19 page this should say "All" not "SPCC1906.03.1"
GO:0016021   integral component of membrane   SPCC1906.03.1   IEA with KW-0812   GO_REF:0000043   967

http://localhost:4242/gene/SPCC1906.03

I've fixed this but not in time for tonight's load.  I'll check things on Friday morning.

Finally got a successful nightly load.  This is fixed.


Make QRenderers usable without a QDesign

Currently renderer objects are created when a design object is created and they are 'registered' inside the design object.

it also requires the design to be passed to it, creating a loop.
However both branches of that loop need to be broken (made optional). Indeed we cannot assume a design object (or a GUI object) will be always used for a renderer. Use-modes for analysis/simulation might not require them at all. For example: the user might load a design to the simulator from a gds file and just want to operate on the simulator from the metal package.
Different ways to solve this, open to suggestions:

Suggestion 1. if we want to keep the renderer objects centralized (objects instantiated once and re-used), then we need to create them outside the design, in some other globally accessible place, could introduce the concept of "app" or "desktop" wrapping it all.
Suggestion 2. if we are ok decentralizing, then a new renderer object can be created whenever needed (for example, once each analysis class instance)

I vote for option 2 if operational conflicts can be handled. option 1 otherwise, but managing it more like an independent service.

This works, if we have agreed to a scenario to import gds files.

It is much further down the time line.


Switch the default negation detection to negex only

DEEPEN's requirement on dependency parsing via stanza, even just on sentences that only have negation triggers and terms causes both a large decrease in pipeline throughput and a dependency requirement for 0.04 f1 increase in negation detection i2b2 2010 va performance. Negex alone runs over 60 times faster than the combination of dependency parsing and deepen. As DEEPEN is currently the only processor requiring dependency parsing, switching to the default of negex only will allow dependency parsing to be disabled by default.

Resolved by #162


Official addons merge

Proposed Changes:
I want second instance of official addons too. So I merged official one.
Then I changed all things to alternative including all official addons and all community addons which @amluto  didn't changed
.

On the one hand, cool.
On the other hand, this is nucking futs.  Home Assistant should fix this upstream so this absurd repository can go away.
All that aside, this is unmaintainable.  IMO the right way to do it is to have a little script that adds all the " alternate" markers and then to run that script over the repo.


refactor(cli): some general refactoring in swc_cli

Description:
Hi all. First time contributor here.
I saw @kwonoj 's comment in this issue and became interested in the port of swc_cli to rust. I had a couple of free hours today and so just went through trying to familiarize myself with the existing code a bit and perform a few changes.
I mostly focused on the compile command.
I noticed a couple of small improvement opportunities if you guys like them:

Avoid a few unnecessary allocations in places (You can get away with keeping pointers to paths in several places where before you were allocating new PathBufs)
Using buffered readers and writers when trying to read/write to files (this should be marginally faster)
Generally adding a little more context to error messages
Some small nits like changing &Option<PathBuf> in function signatures to what I think is the slightly more idiomatic Option<&Path>.
A little cleanup of some control flow here and there

At some point, I'd like to try my hand at adding some new code fill in more of the missing pieces of the cli, but, today, I just started with some general tweaks to what's already there.
Looking forward to seeing if you're interested in any of these changes.
Best,
Brian

BREAKING CHANGE:
Previously, the user was only able to provide as command line arguments for files:

One directory, or
One or more files

I changed this so it is now OK for the user to provide,

One or more directories, and/or
One or more files

I'm not sure if you'll want this API change, but it's pretty easy to back out if you want to keep the existing semantics.

Related issue (if exists):
#1589

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I changed this so it is now OK for the user to provide,

I'd like to request to take out these changes, for 2 reasons:

First, this does not belong to the main purpose of PR to refactor existing implementations
Secondly, there are deliberate decisions to not allow changed behavior due to confusions around base path calculation among multiple inputs, which need to be addressed in PR correctly.

I changed this so it is now OK for the user to provide,

I'd like to request to take out these changes, for 2 reasons:
* First, this does not belong to the main purpose of PR to refactor existing implementations

* Secondly, there are deliberate decisions to not allow changed behavior due to confusions around base path calculation among multiple inputs, which need to be addressed in PR correctly.

Fair enough. Change in behavior removed. Now the old behavior is retained, i.e. user receives an error if they pass a directory plus 1 or more other paths.


Tab completion broken for umount with latest zsh version 5.4.1

Please check the existing issues to make sure you're not duplicating a report.
For bug reports, please provide the following information:
In a terminal, run zmanage info and paste the output below:
zsh: command not found: zmanage

🤷

~/.zimrc: zmodules=(completion)
~/.zshrc: source /usr/lib/zim/init.zsh

Description
Completion module is broken for umount with zsh 5.4.1. Reverting to the previous zsh 5.3.1 fixes this.
Steps to reproduce
$ umount <tab>

Expected output
Completion options, e.g.
 -- device label --
binfmt_misc  configfs     dev          fusectl      mqueue       pstore       securityfs   systemd-1
cgroup       debugfs      devpts       hugetlbfs    proc         run          sys          tmpfs
 -- device path --
/dev/mapper/luks-<redacted>
/dev/sda2
/dev/sdb5
/dev/sdb6
 -- mount point --
/                                 /run/user/1000                    /sys/fs/cgroup/pids
/dev                              /run/user/1001                    /sys/fs/cgroup/systemd
/dev/hugepages                    /sys                              /sys/fs/cgroup/unified
/dev/mqueue                       /sys/fs/cgroup                    /sys/fs/fuse/connections
/dev/pts                          /sys/fs/cgroup/blkio              /sys/fs/pstore
/dev/shm                          /sys/fs/cgroup/cpu,cpuacct        /sys/kernel/config
/HDD                              /sys/fs/cgroup/cpuset             /sys/kernel/debug
/home                             /sys/fs/cgroup/devices            /sys/kernel/security
/proc                             /sys/fs/cgroup/freezer            /tmp
/proc/sys/fs/binfmt_misc          /sys/fs/cgroup/memory             /var/cache
/run                              /sys/fs/cgroup/net_cls,net_prio   /var/log
/run/media/foo/fooHD              /sys/fs/cgroup/perf_event         /var/tmp

Observed output
$ umount _mount:934: command not found: _umountable
_mount:934: command not found: _umountable
_mount:934: command not found: _umountable

Other information
I'm running the latest version of zim, i.e. 537f076. I also tried an old version (7d952ad) to see if it were a regression, but it wasn't. Zim just need to be updated to work with the latest zsh version.

Look like your zsh package is missing the _umountable command introduced in 5.4.1
https://github.com/zsh-users/zsh/commit/5654b905f96720bef285dc92d6b2e2cc31bd971e#diff-c5c29f7af2bf5f3da08b9dc134f4ede7

I'm not exactly sure if this is the same command, but I do have a file provided by my package manager at /usr/share/zsh/functions/Completion/Unix/_umountable. (The link mentions Completion/Unix/Type/_umountable instead.)
Sorry, I forgot to mention in the initial report: I'm running Arch Linux. I'm not sure if the package manager changes the path, but it's always worked fine with zim previously.

rm ${HOME}/.zcompdump* && exec zsh, then source .zlogin.

Thanks @Eriner, that fixed it. FWIW I only needed the first part; I had no .zlogin file.


Small fix on soname defining on ldflags for Android examples.

This bug is similar to that which was fixed in this report,
https://github.com/bkaradzic/bgfx/pull/2176
Essentially it's regarding how the examples are built for Android and how to link them into an Android application. It can't be guaranteed which version of the Android NDK is being used and the SONAME should be defined in any d=shard library built for Android otherwise the runtime linker (using dlopen) will use the default path which is generally based upon the host cross-compile filesystem.
Here is a repo that reproduces the issue, it results in a linker error at runtime when the app is run on a Android device.
https://github.com/gsfare/bgfx-android-examples/tree/main
The error is below since the dynamic linker is trying to find the path for the library on the host machine rather than the device it's running on.
10-16 14:47:54.295  5043  5043 E AndroidRuntime: java.lang.UnsatisfiedLinkError: Unable to load native library "/data/app/~~i4NjwSJJQf-gkES-Ln5HAQ==/com.example.native_activity-1ubDSe4RYAA71-UBJ5O5iQ==/lib/arm64/libnative-activity.so": dlopen failed: library "/home/garethf/Development/bgfx-android-examples/native-activity/app/src/main/cpp/../../../../../bgfx/.build/android-arm64/bin/libexamplesRelease.so" not found: needed by /data/app/~~i4NjwSJJQf-gkES-Ln5HAQ==/com.example.native_activity-1ubDSe4RYAA71-UBJ5O5iQ==/lib/arm64/libnative-activity.so in namespace clns-4
I have a fix for this already, I just wanted to raise a ticket so it can be tracked/commented/discussed appropriately! I'll post a PR for this issue for review.

Here is the PR. Happy to change if needed. Just let me know.
https://github.com/bkaradzic/bgfx/pull/3184


fix naming consistancy accross pointfree libs

There is an issue when using case-paths and
snapshot testing that both have different
url's pointing to the issue reporting
package.

@doozMen Snapshot Testing doesn't depend on Issue Reporting at all:
https://github.com/pointfreeco/swift-snapshot-testing/blob/main/Package.swift
Can you explain the conflict you're seeing and share a project that demonstrates the issue?
We currently lock to xctest-dynamic-overlay as the package name because it's the only way to support things in our package ecosystem in a backwards-compatible way. In the future we will split these two packages out to better address the issue, but unfortunately do not think we can merge this PR without breaking things for folks.

I updated the description. I mixed 2 unrelated issues I had I'm afraid. Please let me know if this is clear enough or if I should make a small package that reproduces the confusing issue whether using swift 6

@doozMen For now you must specify xctest-dynamic-overlay to work around the problem. In the future we will be able to fix this by splitting the package into 2.


Ignore preexisting static manifests kubeadm preflight error

What this PR does / why we need it:
The preexisting static manifests kubeadm preflight error (DirAvailable--etc-kubernetes-manifests) is now unconditionally ignored. This allows users to use Terraform to create static manifests that would be used once the cluster is provisioned.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1261
Special notes for your reviewer:
Using the kubeadm configuration to ignore preflight errors works only with the kubeadm v1beta2 API. The v1beta2 API is used for 1.15+ clusters, which means that those preflight errors will not be ignored for clusters running Kubernetes 1.14 or older. We've discussed this internally and we believe this is okay because Kubernetes 1.14 has reached EOL a long time ago (December 2019).
Does this PR introduce a user-facing change?:
Ignore the preexisting static manifests kubeadm preflight error

/assign @kron4eg

/retest

cc @chrkl wasn't this request by one customer? Could you forward the info?


Refactor pagerduty

I'm trying not to change behavior at all, but just get things in a better place. Some goals so far:

general code cleanup
move PagerDuty API interactions to their own class
more idiomatic error handling

I'm considering this a work in progress still.

Might have already considered it, but it may be tempting to split out the low-level transport stuff into its own module. There appears to be one already, but it doesn't have a lot of the service query stuff built into this package.
In any case, :heart_eyes_cat: because it makes this one step closer to being able to do something with #49

I started splitting out some of the functionality into different scripts. I started with just the webhook since it's totally unrelated to the API commands. I'd like to split the others out, but I think this diff is starting to get big enough so will follow up with that separately.


Should Sender replaceTrack and setTrack support receiving a null track

I'm working on a PR for flutter-webrtc, trying to add the ability to send null into replaceTrack and setTrack, but this interface won't allow that.
Seems a simple fix, something like
Future replaceTrack(MediaStreamTrack? track);
Future setTrack(MediaStreamTrack? track, {bool takeOwnership = true});
I'll try and see if it works and submit a PR if ok

@itsthetaste I think it makes sense and I'd be happy to accept a PR to fix this issue.

https://github.com/flutter-webrtc/webrtc-interface/pull/4

I've made this #4


Enabling Onion Skinning breaks Audio in Animation track

Godot version
4.2.beta.custom_build [51f81e1c8]
System information
macOS 11.0+
Issue description
I found another new issue when starting onion skinning while having put any audio into my animation track.
https://github.com/godotengine/godot/assets/1129695/18ebd12e-143d-46c1-b97a-86cb82ffc4b1
Steps to reproduce

Put a "playing = true" key of any MP3 audio into a Animation track
Enable onion skinning

https://github.com/godotengine/godot/assets/1129695/60289cb7-d98c-4134-88fe-1c94de93d68c

To temporarily dismiss the bugged audio, put a "playing = false" key of the same audio animation track just after the previous key
Enable onion skinning

https://github.com/godotengine/godot/assets/1129695/9549a1f7-142e-4d8d-8eec-4a952861a696
Minimal reproduction project
gd_anim_unittest_1.zip

By referring to:
https://github.com/godotengine/godot/issues/83436
@KoBeWi corrected me the proper practice when adding audio tracks into animation.
By following that proper practice, this bug may not be reproducible.
@RandomShaper  @akien-mga    We may close this issue upon your decisions.


DBZ-1518 Add PK fields to before field

https://issues.jboss.org/browse/DBZ-1518

Decided to document the limitation instead of implementation


feat(@schematic/angular): enable ivy in tests

If a project is generated with enableIvy, this commit adds the necessary configuration to tsconfig.spec.json to then run the tests with Ivy. Note that the CLI already does the correct work (runs ngcc and then runs the tests).
cc @filipesilva as we talked about it on Slack

This relates to https://github.com/angular/angular-cli/issues/14547.
With this option your are indeed optioning in to use ngcc but ts transpiration still happens using tsc and not  Is this what we want? Ie, still using only JIT builds during tests?
Should we have an AOT option to run tests in ivy and transpile using ngtsc, or always AOT, or always JIT?

Yes, we still want unit tests to run with JIT. We just want to ensure that ngcc is ran if needed. For instance if you make a new project and run tests before build. Or if you have some angular libs only on test.
As to having the flag on the spec tsconfig or root tsconfig.... if we have them in individual tsconfigs it will be harder for the user to opt-in or opt back out. And in general we don't really expend a lot of testing in making sure mixed Ivy/VE environments are working properly.
So maybe we should instead have it only on the workspace tsconfig and be done with it. That way it's a single config change. If you really need to have a non-Ivy project, you can opt-out in their leaf tsconfigs too.
At this point I'm kicking myself for not thinking about this earlier. https://angular.io/guide/ivy would also need to change to mention the workspace tsconfig.

I do agree with having the option in the workspace tsconfig. Another option would be to have the specs tsconfig extend the app tsconfig.
Though with the first approach, a user is not creating an ivy application but rather an ivy workspace. Ie: the enableIvy option in the application schematics will be made redundant.
Adding the option in the workspace config will also break ng g library by default unless we update the library tsconfig to disable ivy.

I do agree with having the option in the workspace tsconfig. Another option would be to have the specs tsconfig extend the app tsconfig.
Though with the first approach, a user is not creating an ivy application but rather an ivy workspace. Ie: the enableIvy option in the application schematics will be made redundant.
Adding the option in the workspace config will also break ng g library by default unless we update the library tsconfig to disable ivy.

@alan-agius4 👍 Done


Replace Ace editor with Monaco

Replaces Ace Editor with Monaco Editor
Implements https://github.com/lensapp/lens/issues/458

Converted to draft for removing Ace dependency at all from the lens (not just for tabs)

@Nokel81 @nevalla Ace Editor has been removed, please look at the changes

@pashevskii Can you please sign your commits.

@pashevskii Can you please sign your commits.

Sorry, it is done

@Nokel81 @nevalla @aleksfront I've added the ability to config editors by the second commit. Could you please take a look?

Did you change styling? That doesn't look in line with how other settings look.

@Nokel81 @nevalla @aleksfront I've added the ability to config editors by the second commit. Could you please take a look?

Did you change styling? That doesn't look in line with how other settings look.

the styling was not changed, in the literal sense of the word, but:

I've added tabs for switching between editors (Config for tabs editor, releases/crd details, etc) because every tab contains similar inputs, IMHO listing all these configs makes the page huge
also labels for selects was placed on the one line with the dropdown selects just to minimizing UI

I did some trying to bring it to "lens style" but IMHO it makes this page more ugly than now.

@pashevskii How would a table look instead? Though to be honest do we really need 4 different settings?

The preferences page was refactored, now editor properties have default configs like before this PR but the user can override the default configs with global value. Also, Editor configuration was moved into a new tab. Thanks @aleksfront for the help with this!

Found 2 issues while testing:

App crash on first Monaco editor start
Missing color scheme.

Tests are failing:
SyntaxError: Cannot use import statement outside a module

      19 |  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
      20 |  */
    > 21 | import {monaco} from "react-monaco-editor";
         | ^
      22 |
      23 | export type TabId = string;
      24 |

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1350:14)
      at Object.<anonymous> (src/renderer/components/dock/monaco-model-manager.ts:21:1)

Otherwise looking good!

Tests are failing:
SyntaxError: Cannot use import statement outside a module

      19 |  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
      20 |  */
    > 21 | import {monaco} from "react-monaco-editor";
         | ^
      22 |
      23 | export type TabId = string;
      24 |

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1350:14)
      at Object.<anonymous> (src/renderer/components/dock/monaco-model-manager.ts:21:1)

Otherwise looking good!

Thanks,
I tried to fix it, but the cause of the errors is more complicated than was expected. I faced a number of similar threads (un, dos ,tres) but it has not helped me. I tried to write mock, but it is rocket science for me. Could anybody please help me with it?

I tried to fix it, but the cause of the errors is more complicated than was expected. I faced a number of similar threads (un, dos ,tres) but it has not helped me. I tried to write mock, but it is rocket science for me. Could anybody please help me with it?

@aleksfront please could you help here


Do not depend on p3-preview

This change is

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


does not work anymore

its not working since forced upgrade to MW3_SSL_5408_1.0B firmware.
maybe deye changed something on modbus

It looks like the readable registers have changed with the firmware update.
https://github.com/binsoul/node-red-contrib-deye-sun-g3/blob/master/src/deye-sun-g3/Action/UpdateAction.ts#L41C10-L41C37
Change const lastRegister = 0x0080 to const lastRegister = 0x007f and it works again.
As a temporary fix until the library is updated: Typically you can find this in node_modules of your installation at<EMAIL_ADDRESS>in the execute() method. Change 0x0080 to 0x007f and restart node-red.

@fschaefer: thank you very much, it works :-)

@fschaefer, thank you very much. I can confirm that it works. Published a new version including the fix.


The documentation page is not working

When I enter to  http://docs.fineuploader.com/
The page shows an error.
http://docs.fineuploader.com/features/delete.html

Looking into this now...

It looks like Dreamhost (which should be renamed to Nightmarehost) lost everything on our shared instance that hosts the docs site since late January. I'll have to contact them and get the sorted out. We'll be moving away from Nightmarehost after the last of many issues.

Site is back up now. I'm guessing Dreamhost (which hosts a shared instance housing our docs site) had some sort of outage, at least on our shared instance. Looks like it was out for several hours, nothing noted on their status page or twitter feed. I'm going to follow up with them to find out what went wrong.
I'm not very impressed with Dreamhost, to say the least. I'll probably move our docs site to an AWS EC2 instance in the near future.


🐞 Autosave broken

Description
When making changes to a file and autosave is enabled, edits are not saved unless hitting ⌘ S.
To Reproduce

Open a file.
Make changes.
Close the file.
Open the same file.
Notice the changes you made in step 2 were not persisted.

Expected Behavior
Changes are saved to file.
Version Information
CodeEdit: [e.g. 0.0.3-alpha.7]
macOS: 14
Xcode: 15

Can I work on this?

Of course! Assigning this one to you.

Auto save is now working thanks to #1577

@allcontributors add @ElvisWong213 for bug.


[The Troubleshooters] - Crowdfunding Preview Sheet - Redesign

Fully functional preview of the current german crowdfunding sheet.

Submission Checklist
Required

[X] The pull request title clearly contains the name of the sheet I am editing.
[X] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[X] I have followed the Character Sheets Standards when building this sheet.

[X] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Redesign
Multilanguage Support
-- Including initial german translation

Character Sheet Info Roll20 Internal Use only.


Fix missed files in atscfg PR

Adds missed files in atscfg PR

[x] This PR fixes #REPLACE_ME OR is not related to any Issue

Already includes tests, changelog, docs from atscfg PRs.
Which Traffic Control components are affected by this PR?

Traffic Ops
Traffic Ops ORT

What is the best way to verify this PR?
go build
If this is a bug fix, what versions of Traffic Control are affected?

master

The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4632/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4633/


are images supported?

If so, please add an example on how to add an image.
Thanks!

Not yet, I have to investigate it as per #3, will close this as duplicate


bugfix: fix hosts.toml format

Describe what this PR does / why we need it
server = "default-registry.com:5000"
  [host."default-registry.com:5000"]
    ca = "/etc/abc.key"

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Patch coverage has no change and project coverage change: +10.52 :tada:

Comparison is base (b964a4d) 8.38% compared to head (6434b27) 18.90%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##            main    #2132       +/-   ##
==========================================
+ Coverage   8.38%   18.90%   +10.52%
==========================================
  Files        258       95      -163
  Lines      22194     8909    -13285
==========================================
- Hits        1860     1684      -176
+ Misses     20088     6995    -13093
+ Partials     246      230       -16

Flag
Coverage Δ

e2e-tests
?

unit-tests
18.90% <0.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/clusterfile/decoder.go
45.32% <0.00%> (-0.22%)
:arrow_down:

... and 163 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


⚠ Activitar Portal has degraded performance

In cbf1baf, Activitar Portal (https://activitar.com) experienced degraded performance:

HTTP code: 200
Response time: 15954 ms

Resolved: Activitar Portal performance has improved in 53494be after 6 minutes.


update iac/aws workshop for february

https://github.com/pulumi/marketing/issues/678

@prischoi, what time does it show to you?
@shughes26 I see that the file says 9 AM PT, but it is not converting to the correct TZ to me. It should say 11 AM CST.

@prischoi, what time does it show to you?
@shughes26 I see that the file says 9 AM PT, but it is not converting to the correct TZ to me. It should say 11 AM CST.

I don't see this workshop at all on the Resources page? The only one I see is on 2/14.

I'm getting 11 AM EST when pulling up the page which I assume is incorrect since it should be 12 since the correct time is 11 AM CST?

Yep, I should be seeing 11 AM, and you would see 12 PM. @shughes26 do you know how to fix the TZ conversion?

@prischoi @SaraDPH I'm looking into it

@prischoi @SaraDPH https://github.com/pulumi/pulumi-hugo/pull/2398 turns out I'd used the wrong offset because of daylight savings


Dynamic font resize being called multiple times on UI change

Describe the bug
This commit to remove onDynamicResize has led to the dynamic font resizing being called 8 times per character typed in the TextShema in the main designer:
I noticed that typing was very janky so added a debug comment to when a character was typed and it went up in increments of 8:

To Reproduce
Type in a text schema
Expected behavior
calculateDynamicFontSize should only be called once per key press.
Your Environment
- pdfme package(@pdfme/generator or @pdfme/ui): ui
- pdfme version: latest main on playground

Your Error Log
-

Additional context
No response

The rendered font size now also does not update when you alter the min and max sizes via the controls, and neither does the actual font size show in the greyed out box

It looks like you don't want to show the currently generated font size in the box when greyed out?
value={activeSchema.dynamicFontSize ? NaN : (activeSchema.fontSize ?? DEFAULT_FONT_SIZE)}

I thought it was quite useful to see what font size is being used by the dynamic calculations, do you not agree?

Hey @hand-dot,
If you let me know the intentions of this change then I am happy to look at it tomorrow.
My guess is that you wanted to remove onDynamicResize because you do not want the additional coupling of TextSchema to the UI, to make it easier to build the custom schema plugins?

My guess is that you wanted to remove onDynamicResize because you do not want the additional coupling of TextSchema to the UI, to make it easier to build the custom schema plugins?
Yes, ref: https://github.com/pdfme/pdfme/issues/225


Keyboard navigation only opens language menu

Navigating through the menu via the keyboard is possible, but using Space or Enter to open the "See and Do" menu only opens the language menu.
Steps to reproduce

Open the landing page.
Using the Tab key, cycle through the links.
"Click" the "See and Do" by pressing Enter.

Expected Results
The navigation submenu for locations should open.
Actual Results
The language submenu opens.

In hindsight, I should have given the openSubmenu function an elementId parameter.


Restructuring documentation

Create required antora component and modules, so documentation can be sourced from this repository.
Related to opendevstack/opendevstack.github.io#91

fixed by PR #258


Reach Locations issue

So, after I make a bit of quests, a Reach Locations stage wont work in the quests editor. When I try to use it, I can get to set locations. I get to "Set locations." When I try to right click a block to select the location, it doesn't work. I can't add a location.

Please create a new, updated ticket if this is still an issue. Thanks!


SQL syntax error from postgres PRIMARY KEY (...) INCLUDE (...)

CREATE TABLE foo (
	PRIMARY KEY (a, b) INCLUDE (c),
	a integer,
	b integer,
	c integer
)

foo.sql:1:1: syntax error at or near "INCLUDE"

The optional INCLUDE clause allows a list of columns to be specified which will be included in the non-key portion of the index.

https://www.postgresql.org/docs/current/sql-createtable.html
It seems like sqlc could safely ignore anything inside those INCLUDE parens.

sqlc relies on https://github.com/lfittl/pg_query_go, which currently uses the PostgreSQL 10 parser. The PRIMARY KEY (...) INCLUDE (...) syntax was introduced in PostgreSQL 11. I've opened up an issue to get pg_query_go updated for PostgreSQL 11: lfittl/pg_query_go#26
Sadly, it looks like pg_query_go is unmaintained at this point, so this sadly won't be fixed soon.


The script needs PHP version > 5.3.0 to run.

Have you considered adding version checks?

I'll definitely check to see what's involved in supporting at least version 5.2 since it seems to still be used fairly widely.  Is there another earlier version that would you expect to be supported?

PHP lists the supported versions in http://php.net/supported-versions.php
I would expect the latest version to be supported, but with checks in place to prevent it from trying to run on unsupported versions, which can produce unexpected results.

Ah, I see. I misunderstood what you were looking for.  I can definitely add in something to warn about using old versions, that's a good idea.

Please take a look at the version_checks branch. It should print warnings for people using unsupported versions as well as version that do not have the password_hash family of functions. Does this cover what you were looking for?

Changes merged into trunk (v0.1.1) and issue closed.


Check-in migration from wiki

Summary

Related issue :

This moves most of the content from the wiki regarding AAI. It's missing:
https://wiki.egi.eu/wiki/AAI_expressing_vo_group_membership_and_role_information
and
https://wiki.egi.eu/wiki/AAI_FAQ
It also links this page as a success story: https://wiki.egi.eu/wiki/EGI_AAI_integration_with_ELIXIR_AAI which I'm not really sure it's still relevant/up to date. If so, it should be migrated also

I started to suggest a few fixes, but it may be better to plan a real review later, so I would propose to address the suggestions I made then to push it.

Fine with me. Suggestions applied already


[Feature Request] Support mercurial repositories as dependencies

It would be great if I could specify dependencies as mercurial repositories, similar to how git dependencies already work:
[dependencies]
mydependency = { hg = "https://bitbucket.org/troplin/mydependency" }

I'd love to have this as well! This would basically mean copying what src/cargo/sources/git currently does into src/cargo/sources/hg. It would be stellar if there's a hg-as-a-library implementation (like libgit2) but falling back onto an hg command line seems reasonable for now.

Mercurial is meant to be used by command line anyway. Its command line output is intended to be the same version over versions because we have a strict backward compatibility about it.

Started looking into this as part of the impl days in Paris.
Locally I defined a new Kind::Hg(HgReference) in src/cargo/core/source/source_id.rs, and also created a (almost empty, for now) hg module in src/cargo/sources as suggested.
Before this gets merged (if ever), I'd prefer to use the same struct for the reference.
Also there seem to be quite a few mentions of git2 in src/cargo/sources/remote and I still need to figure out the relation with src/cargo/sources/git.
There are also a few things that can be abstracted away from this git module.

@Ppjet6: feel free to ask me in person about this: I am at the impl days as well!

See also #12102


Modular Build WinJS and react-winjs?

Ported from rigdern/react-winjs#2. @joewood said:
It's very common for React based projects to use a commonjs build system, such as browserify or webpack.  WinJS would be more efficient to adopt if it had a modular build system that supported commonjs out of the box.  This would minimize the size cost of incorporating all of WinJS, when only one or two components use it. Also see winjs/winjs#571.
Some suggestions how this would work:

Each React component defined in a separate file, using defineControl etc...
Each react-winjs component defined using commonjs and dependent only on the winjs modules that it uses
Using webpack allows incorporation of CSS and will automatically convert AMD modules
Using browserify would mean needing to use deamdify into the build to convert AMD->CommonJS

Tracking internally.


Publish build artefacts on weso-releases

I think this would solve the problems that arise from deploying artefacts into local .m2 repository like #16.

Oops https://bintray.com/labra/maven/shaclex#

Although as you could see, I had the binaries published to bintray, I prefer to reopen the issue as I am not sure that the original problem you had has been solved.
The binaries published were not the latest version of Shaclex (they corresponded to version 0.0.55) and I have just published 0.0.56.
I would prefer to know if you have been able to call shaclex using this last version. Let me know if with the new binaries, you are able to call shaclex and it doesn't give you any problem.

I have just published version 0.0.57 which uses Scala 2.12 compiler

0.0.60 resolved the problem (#16)


Unsafe JavaScript attempt to access frame

When trying to use the docker version of wraith (v3.1.4) it gives these error messages:
Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file:///usr/local/lib/ruby/gems/2.1.0/gems/wraith-3.1.4/lib/wraith/javascript/phantom.js. Domains, protocols and ports must match.
It still takes screenshots, but doesn't seem to wait until the page is finished loading even when using a before_capture: javascript/global.js file:
module.exports = function (phantom, ready) {
    // make Wraith wait a bit longer before taking the screenshot
    setTimeout(ready, 10000); // you MUST call the ready() callback for Wraith to continue
}

How can I get this working correctly?

Please work through the following checklist to help us debug. Thanks.

[ ] The command I ran when I saw the issue was: paste command here

[ ] I have validated my config file against YAML Validator to make sure it is valid YAML.

[ ] I have pasted the contents of my config file below:

paste config here

[ ] I have run the command in verbose mode (by adding verbose: true to my config) and pasted the results below:

paste results here

Please reopen when you have this information. Thanks


Test solidification (Stefan problem)

I verified this against Worster2000. See https://github.com/geo-fluid-dynamics/benchmarks/pull/3
Here's the verified result:


Adjust override sample to account for ongoing refactoring.

See https://github.com/microsoft/qsharp-runtime/pull/476
This is required to unblock the PR above. The QSimM class is gone, so directly overriding the intrinsic method is now correct. That still works with the current simulator design, so this change should be safe to merge even before the above goes into qsharp-runtime main branch.

I need to do a little more validation before I'm ready to merge this PR, so I'll leave it in draft until I've confirmed the correct behavior using the e2e build, then publish and ping for review.

I need to do a little more validation before I'm ready to merge this PR, so I'll leave it in draft until I've confirmed the correct behavior using the e2e build, then publish and ping for review.

I am going to find a different way to handle this in the refactor PR that should eliminate the need for consumers to make these changes. I did test that this change behaves as expected, so that will give us a path forward when we are ready to remove the old deprecated classes used in this sample

I am going to find a different way to handle this in the refactor PR that should eliminate the need for consumers to make these changes. I did test that this change behaves as expected, so that will give us a path forward when we are ready to remove the old deprecated classes used in this sample


[Windows] .liferay-pid is not created

It seems that the .liferay-pid file is not created under Windows when using lfr status. Therefore, it also makes lfr status and lfr stop fail because .liferay-pid doesn't exist.

Not really an issue since Windows will start Tomcat in another command window when using lfr start. So stopping the process is pretty straightforward by hitting Ctrl+C in that dedicated window. Same goes with the status (there's a window with Tomcat running or not).
I'll add a condition for Windows when running lfr status & lfr stop to provide an info message instead of an error.


XOR delta

Implement an XOR delta filter (XOR with previous value)

I think it is solved by #595 .

Think the previous implementation of the Delta codec was using np.diff, which behaved similarly
Though yes it seems this works already with the Delta codec ( and is tested in https://github.com/zarr-developers/numcodecs/pull/595)
Closing as resolved


Web component Canary-Content item Horizontal (with thumbnail) - graphic is not identified

Detailed description
Issue:

In JAWS with FF, There is no alt text for the graphic
In Vo with iPhone, the graphic is not identified

Additional information

@Praveen-sr can you check this issue again? Testing with VO on Iphone on Safari browser, I am able to hear the "Image alt text" assigned to the alt of the image

@annawen1 Ram re tested this on Web component Canary with both JAWS n VO iPhone, working fine now. Thanks!
cc @RobertaJHahn

Closing based on Praveen's comments above.


Styling change to zoid container results in restricted height.

A change at version 8.0.6 affected the way the our content displays (or doesn't display) in the zoid container. I suspect it may be this change:  https://github.com/krakenjs/zoid/commit/ef78528e04e82295d79849d7ab7c019d120b8196#diff-c9b7344a832080ac087fcbe301bf5a71
We have been creating our zoid component with height and width of 100% which previously worked to fill the element that the component gets rendered into. Before the styling change at 8.0.6, the zoid container and the zoid-outlet would both get width=100% and height=100%. Now only the zoid-outlet gets that styling and the zoid container (in my case) is 18px high so the iFrame is not visible.
I'm wondering if this was intentional and will be the go-forward behavior in which case we can change our code to suit by setting the size of our zoid component appropriately - set it to a px size rather than 100%.
We tried using autoSize but the results were not as expected.

Can you try the latest version? I think this should be resolved.

Yes, looks to be working fine in 9.0.2. -Thanks!


PeripheralSOM v1.2 Issues

Reset button of the STM32 is only turning things off, not on.
The testpoint for 5V_ISO and GNDPWR looks like it is referring to the connector, could be formatted better

There are more to be added later as we test.

Maybe move the GND to the 3rd pin on the SWD connector. Make it a 1 to 1 map of the Nucleo connector

Connector pinout is hard to figure out, would be useful to add more silkscreen labels to the connector. It won't be used while it is on a daughter board but it could be useful if we're soldering wires directly or debugging.

#11 this guy is an actual circuit bug

To test things like I2C, the ADC, or SPI we need to have a soldered daughterboard with those connections broken out.
It could be useful to have test pads that break out useful connections for testing. (preferably we have as much overlap as possible between things).
Space is definitely an issue, so we should use solder pads and use the inner layers.

Show the distinction between the non-isolated GND and isolated GND on testpoints better.

very minor thing, I think it would be good if the labels on the pins for the SWD connector was "SWDIO" and "SWCLK" so that it's clear that these pins aren't for some other purpose. Or some other indicator that it's an SWD connector on the silkscreen would be good


Formatting silently fails in edge-cases where line lengths extend past 100chars

I encountered a strange bug in our project where a multiline raw string was causing the rest of the expression to not format correctly (this was a chained set of calls, and the entire chain wasn't formatting, including the assignment where we were missing a space). To be clear the expression was not formatting, but the rest of the file formatted fine and there were no errors from cargo fmt (Even with error_on_unformatted = true)
I thought it was due to the raw string and investigated but it instead seems to be due to the line length. I've tried to isolate the problem but I honestly have no idea at this point. I apologise for the jumbled mess below but I hope the set of test-cases helps someone identify the cause of the problem because I do not know.
Each line has one key formatting error, missing spaces around the assignment operator, but other formatting fails too (like additional spaces, etc.)
I have tested this on stable and the nightly-2022-09-15 and I believe it occurs on both.
#[derive(Clone)]
struct Foo {}

impl Foo {
    async fn bar(&self, _: &str) -> Self {
        self.clone()
    }
}

fn test(_: &str) {}

fn main() {
    let foo = Foo {};
    let i_am_a_really_long_variable_name_in_order_to_test_some_formatting_edge_cases_foo_foo_foo_foo_foo =
        "";
    //This formats fine
    let _ = foo.bar(
        r"
        some arbitrary amount of words to try and reach a desired line length, please, & thank you",
    );
    // This does not format correctly and is longer than 100 chars
    let _=foo.bar(
        r"
        some arbitrary amount of words to try and reach a desired line length, please, & thank youX",
    );

    // This formats fine, despite being longer than 100 chars
    let _ = test(
        r"
        some arbitrary amount of words to try and reach a desired line length, please, & thank youX",
    );

    // None of the below format correctly, just trying to isolate the case where it happens.. and failing to
    let _=test(
        i_am_a_really_long_variable_name_in_order_to_test_some_formatting_edge_cases_foo_foo_foo_foo_foo
    );
    let _=foo.bar(
        i_am_a_really_long_variable_name_in_order_to_test_some_formatting_edge_cases_foo_foo_foo_foo_foo
    );

    let _=test("some arbitrary amount of words to try and reach a desired line length, please, & thank you",);
    let _=foo.bar("some arbitrary amount of words to try and reach a desired line length, please, & thank you",);
    let _=foo
        .bar("some arbitrary amount of words to try and reach a desired line length, please, & thank you");
    let _=foo
        .bar(r"some arbitrary amount of words to try and reach a desired line length, please, & thank you",
        );
    let _=foo
        .bar(r#"
           some arbitrary amount of words to try and reach a desired line length, please, & thank you
           "#,
        );
}

Thanks for reaching out.
The foo.bar() cases are duplicates of https://github.com/rust-lang/rustfmt/issues/3863.
Rewriting function calls goes down a similar code path as array rewriting, so I believe those cases are duplicates of https://github.com/rust-lang/rustfmt/issues/4403.
If you're using nightly you can try setting format_strings=true to allow rustfmt to break long strings. However, there's not much you can do about the really long identifier names. Your best bet there is to increase the max_width.

Thanks for the quick response, I looked but failed to find those issues.

If you're using nightly you can try setting format_strings=true to allow rustfmt to break long strings. However, there's not much you can do about the really long identifier names. Your best bet there is to increase the max_width.

I think the issues you linked identify the issue properly, so I think I agree with closing this off, but just in case I wasn't clear in my original post; my problem isn't that rustfmt doesn't manage to somehow split the line and keep the appropriate line length (because that wouldn't be possible with the long identifier names), it's just that it completely gives up on other formatting things such as identation and whitespace around the equality.
I found it quite strange that some of the cases managed to format even though they went past the max width.

it's just that it completely gives up on other formatting such as identation and whitespace around the assignment operator.

it's not a matter of "giving up" other parts. rustfmt is strictly an AST-driven pretty printer and does not directly process input files and the tokens contained within. There's plenty of cases, such as with chains as detailed in the linked threads, where if rustfmt is unable to format a particular AST node, rustfmt is accordingly unable to safely format the containing/parent node, and it's the entire contents of the parent node that are emitted.


Add Back Arrow to Outcomes Overview

Fixes #853

@bryanfriedman @BrianMMcClain Should be good to merge. Also did some styling to make sure arrow boxes remain the same height.


chore: autodetect highlight group files

Organize directory and autodetect any Lua file in https://github.com/mikesmithgh/gruvsquirrel.nvim/blob/6c471f26687e4f0d39798835a3941fdf19bf7431/lua/gruvsquirrel/colors/gruvsquirrel/init.lua

:tada: This issue has been resolved in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


OAuth Issues

Can't get the connection flow to work. Tried following both guides and workarounds but get the following error.
Log Details (ERROR)
Logger: aiohttp.server
Source: helpers/config_entry_oauth2_flow.py:205
First occurred: 10:27:38 (3 occurrences)
Last logged: 11:33:45
Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
resp = await request_handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.10/site-packages/aiohttp/web_middlewares.py", line 117, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 222, in forwarded_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 81, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 136, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 171, in get
return await super().get(request, flow_id)
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 96, in get
result = await self._flow_mgr.async_configure(flow_id)
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 281, in async_configure
result = await self._async_handle_step(
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 368, in _async_handle_step
result: FlowResult = await getattr(flow, method)(user_input)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 303, in async_step_creation
token = await self.flow_impl.async_resolve_external_data(self.external_data)
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 169, in async_resolve_external_data
return await self._token_request(
File "/usr/src/homeassistant/homeassistant/helpers/config_entry_oauth2_flow.py", line 205, in _token_request
resp.raise_for_status()
File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 1004, in raise_for_status
raise ClientResponseError(
aiohttp.client_exceptions.ClientResponseError: 503, message='Service Unavailable', url=URL('https://api.trakt.tv/oauth/token')

I think this bug could be closed, because trakt.tv had a database issue for more than a week, and the API was back online only on the 21st, mid-day PST.


four layers of gob is bad

The sending of topology gossip currently goes through four layers of gob encoding, and involves n_peers+3 encoders...

[x] 1. one GobEncoder for each peer, into which we encode the connections
[ ] 2. one GobEncoder for the set of peers, into which all peers are
encoded, with their connection information represented by the
result of the aforementioned encoding.
[ ] 3. one GobEncoder for encoding the gossip (hash, source, and the
result of (2)) as a ProtocolMsg payload.
[ ] 4. one GobEncoder in the TCPSender, which is used to encode a byte
slice - comprising the ProtocolMsg tag and payload - as a single
message

This has a bad design smell to it and probably is also rather inefficient.

Two layers of gob is the best we can do when crypto is enabled. Our crypto operates on message streams, i.e. streams of byte slices, rather than byte streams. The 4th gob layer converts between the two. And the 3rd layer converts between between our protocol data objects and byte slices.
We could do something different in the non-crypto case but it's really not worth the hassle.

I've done some more profiling, running
NUM_WEAVES=1 bin/multiweave launch -connlimit 100 -profile /tmp
NUM_WEAVES=49 FIRST_WEAVE=2 bin/multiweave launch -connlimit 100
```
(wait until everything goes quiet - takes about 3 minutes on my machine)
```
sudo kill -INT $(docker inspect --format '{{.State.Pid}}' weave1)
docker cp weave1:/tmp/cpu.pprof .
go tool pprof --nodefraction=0.02 --edgefraction=0.01 weaver/weaver cpu.pprof

The gob codec takes up ~12%, in what is an extremely gob-heavy scenario. So while there is still room for improvement, it's not worth spending a lot of effort on it. So the main motivation to eliminate another layer would be improved design/APIs.


feature: skydio x2

Good day!
I wanted to contribute and extend the list of available drones with your loaders.
Proposed robot is Skydio X2 which is available in MJCF format here. I have added an URDF description matching its dynamics and made it publicly available.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.857%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
865

Relevant Lines:
875

💛  - Coveralls


[proposal] rest property

This is just a proposal. I didn't spend time to dive in deep.
This is the code I used in https://github.com/dai-shi/react-hooks-easy-redux/issues/8#issuecomment-474783286
The test is failing.

Proposal accepted, but I would write some tests before releasing it - it's more about properly mimicking babel behaviour. For example - Object.keys might be not enough. Not sure - tests will show.

👷 still on it 👷

There were issues with your proposal, more about defineProperty is not working on Proxies.
I've added two new APIs

proxyObjectRest(object, ['key']) - to {key, ...rest}, while access to key would be recorded, but rest would be just copied.
proxyArrayRest(array, fromIndex to [a,b,...rest], and again access to a(0), and b(1) would be recorded, but not to the rest. In the same time indexes in the rest would be tracked using original indexes in the source object.


User can choose which columns should be shown

New Table wrapper

[x] Construct available-columns is generated from columns if available and rows, specifically: field-key from single col-config maps in columns and all keys from all documents in rows. available-columns is a map of field-key->col-config. col-config is an empty map if coming from rows or a full col-config if coming from columns.
[x] init db with

current-cols -> vector of field-keys
default-cols -> vector of field-keys

[x] render Table with updated props for columns plus a new col-config
[x] Events to remove and add single column (at the end or specific position) and reset to default-columns
[x] Subscriptions to get default-columns and current-columns
[x] Store in local storage when changing columns
[x] Read from local storage when rendering table
[x] Make it specific for where it was rendered by passing in a db-path

[x] Test it with Edges table
[x] Make it work with RowFn (render-row-fn props of Table): Currently hardcoded entire row, so when you remove a column, only the column header is removed -> Removed row-render option for table
Changes to Table component: Add UI stuff to control all of it

[x] remove icon on column header
[x] Add dropdown on hovering a column header
[ ] Modal to change all columns at once

[x] Sort sorting out :(

Style of the button of course can be changed. Here is a simpler one.
<Button basic icon floated='left' style={{'box-shadow': 'none', padding: 0}}>


HADOOP-17192 Fixing ITestS3AHugeFilesSSECDiskBlock

Disabling caching of configuration object in test.
Re ran the failing test using ap-south-1 bucket. Succeeding now.
CC @steveloughran

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
28m 30s
trunk passed

+1 :green_heart:
compile
0m 42s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 36s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 29s
trunk passed

+1 :green_heart:
mvnsite
0m 41s
trunk passed

+1 :green_heart:
shadedclient
15m 10s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m  3s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  2s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 28s
the patch passed

-0 :warning:
checkstyle
0m 19s
hadoop-tools/hadoop-aws: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 48s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 18s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 25s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

71m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2221

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 11c2ba2a144d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 10716040a85

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/1/testReport/

Max. process+thread count
452 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

LGTM. just the checkstyle to deal with
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/S3AScaleTestBase.java:108:    return conf = createScaleConfiguration();:17: Inner assignments should be avoided. [InnerAssignment]

LGTM. just the checkstyle to deal with
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/S3AScaleTestBase.java:108:    return conf = createScaleConfiguration();:17: Inner assignments should be avoided. [InnerAssignment]

Done.

+1, merged to trunk

...and cherrypicked to branch-3.3. Thanks!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 28s
trunk passed

+1 :green_heart:
compile
0m 45s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 37s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 29s
trunk passed

+1 :green_heart:
mvnsite
0m 49s
trunk passed

+1 :green_heart:
shadedclient
18m 39s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 30s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 11s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 19s
the patch passed

+1 :green_heart:
mvnsite
0m 34s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 36s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 19s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 26s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 31s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

82m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2221

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux ea848de26731 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / e592ec5f8bf

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/2/testReport/

Max. process+thread count
413 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2221/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Validators are now sorted by voting power instead of by address

This is a Tendermint-Go 0.34 compatibility upgrade issue brought by a comment in #305 by Ethan.

I'm going to work on this now. I'm basing it on top of #537 which is not merged yet.


Competition Registration

Registration paperwork filed by deadline (Feb 28)

Slated to finalize paperwork with Damen Provost by Feb 15th

@nickv97 created form, we need MJR & RI to sign off


I want to beautiful game Tic-Tak-Toe using css.

I would like to contribute a beautiful game Tic-Tak-Toe using css, Please assign this issue to me @AnshSinghSonkhia Under hacktoberfest 2022

Do your game have animations?

Can you please assign this to me under Hacktoberfest label


relatedness degree added to relatedness output

Is your feature request related to a problem? Please describe.
related/duplicated degrees are not included in the .related output
Describe the solution you'd like
add duplicated, first, second, third, etc labels in the output .related file
Describe alternatives you've considered
none
Additional context
it currently requires extra steps after relatedness to get the degree

added "REL" field in .related output with labels ("duplicate", "first_deg", "second_deg", and "unrelated")


Question: Can you load up two Networks at once?

Currently I use detectnet-camera to detect the position of objects within the live camera frame, and then I write out the image crops for the objects found.
Now I want to run the image crops through a trained imagenet classification network to identify exactly what the object is (like a ford pinto instead of simply being a vehicle).
Do I have to stop the DetectNet network in order to do this? Or can I run an imagenet based classification while the detectnet is still loaded?
I want to be able to go between the two with as little reduction on the frame rate as possible.

Hi Jason, you can create an imageNet object in addition to detectNet and run them separately.  In normal circumstances there should be enough memory for both.  Imagenet is faster than detectNet.
Best regards,
Dustin
On Feb 27, 2017 8:27 PM, Jason Mecham<EMAIL_ADDRESS>wrote:
Currently I use detectnet-camera to detect a position of objects within the live camera frame, and then I write out the image crops for the objects found.
Now I want to run the image crops through a trained imagenet classification network to identify exactly what the object is (like a ford pinto instead of simply being a vehicle).
Do I have to stop the DetectNet network in order to do this? Or can I run an imagenet based classification while the detectnet is still loaded?
I want to be able to go between the two with as little reduction on the frame rate as possible.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-inference/issues/45, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOpDK2g8kuF_E0lh5dGaQYb0Rh-_ZWL5ks5rg3gSgaJpZM4MN2iB.

This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.

Thanks. It seems to load fine.
Now I just have to figure out how to get the image data within the boundary box (from detectnet) into another memory buffer for the classify function. Or expand the classify function to work on a ROI.
I probably should have started with learning about how to use CUDA on some basic level before playing around with this. :-)

Feel free to use the CUDA code from https://github.com/dusty-nv/jetson-inference/tree/master/cuda as a template, for example cudaResize is pretty simple to get started with.
From: Jason Mecham<EMAIL_ADDRESS>Sent: Tuesday, March 07, 2017 7:38 PM
To: dusty-nv/jetson-inference
Cc: Dustin Franklin; Comment
Subject: Re: [dusty-nv/jetson-inference] Question: Can you load up two Networks at once? (#45)
Thanks. It seems to load fine.
Now I just have to figure out how to get the image data within the boundary box (from detectnet) into another memory buffer for the classify function. Or expand the classify function to work on a ROI.
I probably should have started with learning about how to use CUDA on some basic level before playing around with this. :-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-inference/issues/45#issuecomment-284908047, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOpDK3Dl2hdC_endt4NaBtDKRMjRaxtUks5rjfh7gaJpZM4MN2iB.

This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.

Thanks.
I copied the gpuPreImageNetMean to new function that works on a region of interest of the live camera image coming in.  Where the ROI is from the boundary box of the DetectNet.
It's pretty neat seeing detectnet detect the objects, and then imagenet classify them all while running live.
Here is the function I added to do deal with a ROI of interest on the 1280x720 incoming image. I believe it works correctly from the limited testing I've done.
// gpuPreImageNetMeanROI
global void gpuPreImageNetMeanROI( float2 scale, float4* input, int iWidth, float* output, int oWidth, int oHeight, int roix_start, int roiy_start, float3 mean_value )
{
const int x = blockIdx.x * blockDim.x + threadIdx.x;
const int y = blockIdx.y * blockDim.y + threadIdx.y;
const int n = oWidth * oHeight;
if( x >= oWidth || y >= oHeight )
	return;

const int dx = ((float)x * scale.x) + (float)roix_start;
const int dy = ((float)y * scale.y) + (float)roiy_start;

    const float4 px  = input[ dy * 1280 + dx ];
const float3 bgr = make_float3(px.z - mean_value.x, px.y - mean_value.y, px.x - mean_value.z);

output[n * 0 + y * oWidth + x] = bgr.x;
output[n * 1 + y * oWidth + x] = bgr.y;
output[n * 2 + y * oWidth + x] = bgr.z;

}

Here is what I did with this project.

That's really cool!  I appreciate the novel use of pipelining detectNet and imageNet.   I would like to highlight that approach in the tutorial, maybe we can collaborate to use your application as an example if you are willing?
In practice, do you have any plans for the card detection system?  Nice work!

Yeah, I can share the Datasets and the Models along with the code. Now keep in mind the code is really just a bunch of hack of your code, and I probably didn't do things the right way. So it's going to need some fixing. The collaboration would benefit me as I'm new to this CUDA stuff, and hopefully other people can use it to do some cool things with it.
I also hacked in an image/label saving tool. So it saves not just the image, but the label file as well. That enabled me to quickly add more data to the dataset. Where I could easily fix the boundary boxes (for detectnet) or fix the classification (for imagenet).
I picked playingcards so I could share the code/data/model without revealing anything about what I'm actually working on for work. It's using the same type of pipeline, but different data.
As a hobby project I might finish it up to play a game of 21 with the user. Where the user has to be the dealer, and the computer card counts.

I uploaded my AlexNet based model for the playing card identification, and the DetectNet model for detecting the playing card. But, for some reason wget doesn't download them correctly.
I edited the link in the same way that the CMakePreBuild.sh has them, but it ends up saving a very small file that isn't correct.
Here are the links with the original formatting.
AlexNet
https://drive.google.com/file/d/0B8dR1eAmu3fTWWpkSEVLV0Z5TVE/view?usp=sharing
CardNet (DetectNet Cased)
https://drive.google.com/file/d/0B8dR1eAmu3fTMU9Vb3p1S05Bclk/view?usp=sharing
Here is the modified wget line for AlexNet
wget --no-check-certificate 'https://drive.google.com/uc?export=download&id=0B8dR1eAmu3fTWWpkSEVLV0Z5TVE' -O alexnet_54cards.tar.gz
Is there something I'm missing? I uploaded the files simply using a chrome client to google drive and then shared them via a public link.

Apparently this is because of a "Google cannot provide a virus scan" error message.
http://unix.stackexchange.com/questions/136371/how-to-download-a-folder-from-google-drive-using-terminal
In the above link there is a solution, and the solution works. But, I don't know how to return the code it sends. For now I just reuse the same code that it gave me the first time, but I'm sure that will break.

Hey, thanks for sharing Jason.  For the reason you mentioned with gdrive, I've changed over to Box.com for the most part (see master CMakePreBuild.sh).  Box doesn't seem to care about serving up large files and also can provide the direct link.
Best regards,
Dustin
On Mar 30, 2017 8:22 PM, Jason Mecham<EMAIL_ADDRESS>wrote:
Apparently this is because of a "Google cannot provide a virus scan" error message.
http://unix.stackexchange.com/questions/136371/how-to-download-a-folder-from-google-drive-using-terminal
In the above link there is a solution, and the solution works. But, I don't know how to return the code it sends. For now I just reuse the same code that it gave me the first time, but I'm sure that will break.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-inference/issues/45#issuecomment-290581699, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOpDKz3ImriclscUMnt814vOsHOQ1EZ3ks5rrEdWgaJpZM4MN2iB.

This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.

Yeah, I might try Box and another option is this utility which seems to work great.
https://github.com/circulosmeos/gdown.pl
So I can download that in the script file and then use it.
I can't use dropbox because my work internet blocks them all the time (but, not always which is weird).

How many images did you use for training ?
Regards

@raaka1
The dataset for the object detection consist of 271 images, and the dataset for the image classification consists of a little over 1000 images.
I'll likely add more images to the object detection to better detect cards at different distances. Right now it's pretty locked to a certain distance away from the cards, and with using a USB camera (to mount it facing down).

I uploaded a very primitive blackjack type game using this dual method detection/classification.
https://github.com/S4WRXTTCS/jetson-inference
It's not really suited for the onboard camera (what it defaults to) so it's best to switch to the USB camera.
There are some bugs like crashing when the card is half off the screen, and stuff like that. Coding isn't really my strong suite.

Can you share the training data ? :)

The DetectNet training data is here
https://drive.google.com/file/d/0B8dR1eAmu3fTR3l4WkNtR0dqS0E/view?usp=sharing
The ImageNet training data is here
https://drive.google.com/file/d/0B8dR1eAmu3fTcG1mZVN4OHFNTU0/view?usp=sharing

Thanks , i will let you know if there are issues.

I fixed an issue with the cropping of the boundary boxes causing it to crash, and I also edited the Readme to add some information as to what it is.

I added a Dual Net example. Basically it's detectnet-camera that crops the boundary boxes, and sends the image data from each one to ImageNet for classification.
That's likely the last thing I'll add to it for now.


google maps API + Sencha

Since today I get errors in chrome console when trying to pan/touch the map:
Uncaught TypeError: Cannot read property 'length' of undefined
Nm.(anonymous function).Eb
Q.bindmain.js:21
_raiseTouchEventripple.js:37559
Uncaught TypeError: Object [object Object] has no method 'item'
Om
Nm.(anonymous function).Nb
Q.bindmain.js:21
_raiseTouchEventripple.js:37559
If I disable ripple google maps works fine.
url to test on http://dev.sencha.com/deploy/touch/examples/map/
ripple settings: device iPhone 3G, 3GS; phonegap 1.0

This has been fixed with this issue: https://github.com/blackberry/Ripple-UI/issues/242 and should be available in the next release.


Incomplete list of required URLs

The list of domains/URLs is incomplete. When I allow only those listed, WSUS fails to synchronize, trying to communicate with additional IPs such as <IP_ADDRESS>, <IP_ADDRESS>. There may be additional ones. Is it possible to update this list to include every IP/URL required? Otherwise it's impossible to restrict the traffic on a firewall.
Errors like this appear in the WSUS log:
2023-11-16 10:22:58.234 UTC	Error	WsusService.30	MicrosoftUpdateRollup.DoRollup	Error found when running rollup: System.Net.WebException: Unable to connect to the remote server ---> System.Net.Sockets.SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond <IP_ADDRESS>:443

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 85eb6a21-2659-019a-71ab-66f2e3a7f474
Version Independent ID: ee2ab576-3c19-15a5-8c41-29a00275614b
Content: Step 2 - Configure WSUS
Content Source: WindowsServerDocs/administration/windows-server-update-services/deploy/2-configure-wsus.md
Product: windows-server
Technology: wsus
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Upon further investigation, all IPs I've discovered so far, are part of "AzureUpdateDelivery" group in each Azure region as defined in this list https://www.microsoft.com/en-us/download/details.aspx?id=56519.


Support newer setuptools

I have been using flexget using pip installs for a while.
I upgraded my setuptools and I get this warning:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
flexget 3.8.0 requires setuptools==65.6.3; python_version >= "3.7" and python_version < "4.0", but you have setuptools 68.2.2 which is incompatible.

Everything still seems to work fine, but the dependencies expect a certain version of setup tools. Any chance this can be updated?

We pin all of our deps to make sure installs and issues are reproducible across the most systems possible. (For this reason, it's important to install Flexget in its own virtualenv.) Latest release has setuptools pinned to 68.0.0, which is the last release that supports python 3.7. Once we drop support for python 3.7 the pinned setuptools version will also update.


Style disabled form fields with cursor: not-allowed

I wonder if styling the disabled button with cursor: not-allowed would provide more affordance to the user?
Originally posted by @jesseyuen in https://github.com/alphagov/govuk-design-system-backlog/issues/34#issuecomment-528365796

Would it make sense to add this as a comment on https://github.com/alphagov/govuk-frontend/issues/1713 instead of making it a separate issue?

Closing as this suggestion is now integrated into  #1713


[BUG] @Getter/@Setter Javadocs can't handle line breaks properly in @param/@return

Describe the bug
With #132, the following feature was added:

NEW in lombok v1.12.0: javadoc on the field will now be copied to generated getters and setters. Normally, all text is copied, and @return is moved to the getter, whilst @param lines are moved to the setter. Moved means: Deleted from the field's javadoc.

However, if the @param or @return has multiple lines, only the first line is moved to the getter/setter.
To Reproduce
Using the following ExampleFile.java:
import java.util.List;

import lombok.Getter;
import lombok.Setter;

/**
 * @author Jacob Mitash
 */
@Getter
@Setter
public class ExampleFile {

    /**
     * This is a list of booleans.
     *
     * @param booleans A list of booleans to set for this object. This is a Javadoc param that is
     *        long enough to wrap to multiple lines.
     * @return A list of booleans to set for this object. This is a Javadoc return that is long
     *         enough to wrap to multiple lines.
     */
    private List<Boolean> booleans;
}

Run delombok on the file (I used the Maven plugin). The output file is:
import java.util.List;

/**
 * @author Jacob Mitash
 */
public class ExampleFile {
    /**
     * This is a list of booleans.
     *
     *        long enough to wrap to multiple lines.
     *
     *         enough to wrap to multiple lines.
     */
    private List<Boolean> booleans;

    /**
     * This is a list of booleans.
     *
     *        long enough to wrap to multiple lines.
     * @return A list of booleans to set for this object. This is a Javadoc return that is long
     *         enough to wrap to multiple lines.
     */
    @java.lang.SuppressWarnings("all")
    public List<Boolean> getBooleans() {
        return this.booleans;
    }

    /**
     * This is a list of booleans.
     *
     * @param booleans A list of booleans to set for this object. This is a Javadoc param that is
     *        long enough to wrap to multiple lines.
     *
     *         enough to wrap to multiple lines.
     */
    @java.lang.SuppressWarnings("all")
    public void setBooleans(final List<Boolean> booleans) {
        this.booleans = booleans;
    }
}

Expected behavior

The booleans Javadoc should not have the "[long] enough to wrap to multiple lines." lines
The getBooleans() Javadoc should not have the "long enough to wrap to multiple lines." line
The setBooleans() Javadoc should not have the "enough to wrap to multiple lines." line

Version info

Lombok version: 1.18.10
Platform:

OS: macOS 10.14.3
javac -version: javac 1.8.0_181

You are right, the regular expression to remove the tags only removes one line. I have updated it to also remove additional lines and restructured the code a little bit. I will provide a PR as soon as my latest javadoc related changes are merged.


Packaging Chain-specific Configs & Effects

How should we approach packaging chain-specific configs and effects?
Current approach
Currently, we expose several configs––each with the same tmp types––from the known dir. DNT takes care of exposing this directory from the generated NPM package's exports. Assuming that a given Node project is configured with Node16/NodeNext import resolution, its devs can do the following.
import { polkadot } from "capi/known";

However, this opens a can of worms depending on adjacent config (especially in front-end frameworks such as NextJS) cc @karl-kallavus.
Alternative
We could create some means of enabling the community to publish to the @capi org on NPM (similarly to @types). The maintainers of a given chain can take ownership over its @capi-namespaced package. This is in line with the AWS CDK's treatment of per-service constructs.
import * as cdk from "@aws-cdk/core";
import * as lambda from "@aws-cdk/aws-lambda";

In our case, @capi-namespaced packages would contain configs and effects that abstract over the given chain.
import * as C from "capi";
import { polkadot } from "@capi/polkadot";

The drawback of this approach is that the developer must install an additional library for each chain. However, this seems unavoidable in the long term. We certainly would not want to package the specifics of dozens of chains in the Capi repo.
Closing Thoughts
We need to decide on this separation of concerns: IMO, the Capi repo should need not contain chain-specific values and types; it should contain only the means of representing (and––where possible––generating) those chain-specifics.

We could create some means of enabling the community to publish to the @capi org on NPM (similarly to @types).

I've observed the amount of work done to maintain DT, and that kind of publishing is a huge undertaking.
To any degree significant chain-specific packages are needed, I think it can be covered by people publishing capi-xyz packages. We may also want to publish some @capi/xyz packages that are "official" – for example, @capi/polkadot.
However, I think it would be best if we can minimize the degree to which this is needed. Ideally, as much of this comes through codegen as possible. If we can get the manual chain-specific metadata down to, say, a single short file, at that point I think it would make the most sense to simply have a collection of those files in the capi repo directly.

Perhaps closed by #226, should we all agree on new direction.