Support for Next.js 13

Since Next.js 13 was released yesterday, the beta docs list Stitches as not being support as of right now.
There is however a guide on how to integrate styled-jsx that look very similar to how Stitches could be integrated: https://beta.nextjs.org/docs/styling/css-in-js
Are there any plans to officially offer support for Next.js 13?

Is there a compatibility issue present? I've been using 13 + 13.0.1 with no problems since it came out.

I barely tested this, but seems to be working. Again, I tested this for like 2 mins, so take that into consideration. Based on the example:
"use client"

import React from "react"
import { useServerInsertedHTML } from "next/navigation"
import { getCssText } from "../../stitches.config"

export function ServerStylesheet({ children }) {
  useServerInsertedHTML(() => {
    return <style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />
  })

  return children
}

and on the layout:
export default function RootLayout({ children }: { children: React.ReactNode }) {
  return (
    <html lang="en">
      <head>
        <title>Create Next App</title>
        <meta name="description" content="Generated by create next app" />
        <link rel="icon" href="/favicon.ico" />
      </head>
      <body>
        <ServerStylesheet>{children}</ServerStylesheet>
      </body>
    </html>
  )
}

@jpmaga css utility method breaks the app (both on client and server). And stitches should update the docs for next 13 app dir. Because its a totally different way of doing things than the pages directory

It seems to only work with client-side rendering, is it right?

@rodrigodh yes

Is there any way for making the app awaits for css before loads?

@rodrigodh you need to force the prop into a string, then it works, this is actually a bug on react dom server, need to post an issue about this there.
I noticed that sometimes the style dont load at all too.

@rodrigodh you need to force the prop into a string, then it works, this is actually a bug on react dom server, need to post an issue about this there.
I noticed that sometimes the style dont load at all too.

`'use client';
import { useServerInsertedHTML } from 'next/navigation';
import { getCssText } from './stitches.config';
export function ServerStylesheet({
children,
}: {
children: JSX.Element;
}): JSX.Element {
useServerInsertedHTML(() => {
return (
<style
id="stitches"
dangerouslySetInnerHTML={{ __html: String(getCssText()) }}
/>
);
});
return children;
}
`
Tried this but did not work, is it another prop?

@rodrigodh getCssText() returns a string @darklight9811 could you elaborate?

@rodrigodh @vitharanagedonjani-i2e, sorry for the delay, but I meant the css utility, not the getCssText(), another part of the issue.
const buttonProps = css({})

function Button (props) {
  return <button className={buttonProps(props)}>{props.children}</button>
}

Does this fix the issue where styles are not loading in server side? @darklight9811

Does this fix the issue where styles are not loading in server side? @darklight9811

Absolutely not

This link shows how it worked for me, but only on the client side.
https://stackblitz.com/edit/nextjs-ftij4p?file=app/ServerStylesSheet.tsx
But all pages and components you need to use with stitches, you put this flag on top the code  'use client'.  This specify the component or page is run on client side.

I‘d love to see support for this too.
I don't 100% understand the issue but I suspect getCssText is too magical and something like a StyleSheet API needs to be exposed.

I am also on the need for a migration for Nextjs 13 and i would the support for this as well!

This works for me, inside of the Layout.tsx file generated in the app directory folder, but i dont sure.
import {getCssText, globalStyles} from '@/ui'
import './globals.css'

export default function RootLayout({children}: {children: React.ReactNode}) {
  globalStyles()
  return (
    <html lang="en">
      <head>
        <style id="stitches" dangerouslySetInnerHTML={{__html: getCssText()}} />
      </head>
      <body>{children}</body>
    </html>
  )
}

@DavidRojas1612 That's great! Seems extremely simple, thanks for commenting to let us know.
Have you noticed any gaps or issues since last week?

@DavidRojas1612 @timweightman The above seems to work albeit I am seeing a few errors:

This works for me, inside of the Layout.tsx file generated in the app directory folder, but i dont sure.

@DavidRojas1612  Does this work for you with hot reloading ? It does work on my side but if I do a change, the app reload without stitches style and I have to manually refresh to get the style back.

@DavidRojas1612 @timweightman The above seems to work albeit I am seeing a few errors:

I am not certain why you're getting this error - the content of your RootLayout component should match @DavidRojas1612 example exactly. Is there anything you've done differently, maybe show us some code?

@DavidRojas1612 Does this work for you with fast refresh ? It does work on my side but if I do a change, the app refresh without stitches style and I have to manually refresh to get the style back.

I'm in the same boat - must manually refresh to get styles back. I believe the CSS generated and put into the <style id="stitches" element is being mangled. When I modify CSS for a Stitches styled component and compare the content of that style element, the whole block of styles for all components has been removed, only the global styles remain.
I wonder if it's related to NextJS Fast Refresh...?

@timweightman I think getCSsText is broken in general on the client https://github.com/stitchesjs/stitches/issues/1094
I too am only seeing the global styles in the output

Ooo I just did a setTimeout to use getCssText and it has all the styles now. I'm thinking that if you call it too soon it doesn't work

Ooo I just did a setTimeout to use getCssText and it has all the styles now. I'm thinking that if you call it too soon it doesn't work

@hipstersmoothie What does your code looks like? I'd like to have it as a reference.

I solved this problem creating a isolated component, and applying the getCssText there for example:
MyComponent:
import { getCssText } from<EMAIL_ADDRESS>
export const StyleSheet = () => {
  return (
		<style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />
	)
}

layout.tsx
import { StyleSheet } from '@/components/StyleSheet'
import { GlobalCss } from '@/styles/global'

export default function RootLayout({
	children,
}: {
	children: React.ReactNode
}) {
	return (
		<html lang="en" className={inter.className}>
			<head>
				<StyleSheet />
			</head>
			<body>
				{children}
				{GlobalCss()}
			</body>
		</html>
	)
}

This way work because that in nextjs 13 all component are SSR (Server Side Rendering), then this stitche style is load on SSR and the screen already work with this style!
I hope that help everyone! Thank you guys!

I solved this problem creating a isolated component, and applying the getCssText there for example:
MyComponent:
import { getCssText } from<EMAIL_ADDRESS>
export const StyleSheet = () => {
  return (
		<style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />
	)
}

layout.tsx
import { StyleSheet } from '@/components/StyleSheet'
import { GlobalCss } from '@/styles/global'

export default function RootLayout({
	children,
}: {
	children: React.ReactNode
}) {
	return (
		<html lang="en" className={inter.className}>
			<head>
				<StyleSheet />
			</head>
			<body>
				{children}
				{GlobalCss()}
			</body>
		</html>
	)
}

This way work because that in nextjs 13 all component are SSR (Server Side Rendering), then this stitche style is load on SSR and the screen already work with this style!
I hope that help everyone! Thank you guys!

For me, this solution works well, but fast refresh does not immediately work (the styles are not applied), requiring a manual refresh.

`import { getCssText, globalStyles } from '@/presentation/external/stitches/core'
import { PropsWithChildren } from 'react'
export default function RootLayout({ children }: PropsWithChildren) {
globalStyles()
return (

<style
id="stitches"
dangerouslySetInnerHTML={{ __html: getCssText() }}
/>

{children}

)
}`
For me, this solution works wel.

`import { getCssText, globalStyles } from '@/presentation/external/stitches/core'
import { PropsWithChildren } from 'react'
export default function RootLayout({ children }: PropsWithChildren) {
globalStyles()
return (

<style
id="stitches"
dangerouslySetInnerHTML={{ __html: getCssText() }}
/>

{children}

)
}`
For me, this solution works wel.

The above solutions seem to be working for me too with:
stylesheets.tsx
export default function StyleSheet() {
	return (
		<style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />
	);
}

globalCSS.tsx
export default function GlobalCSS() {
	return globalStyles();
}

and
layouts.tsx
export default function RootLayout({ children }: Props) {
	return (
		<html lang="en" className={Graphik.className}>
			<head>
				<StyledSheet />
			</head>
			<body>
				<Providers>{children}</Providers>
				<Analytics />
				{GlobalCSS()}
			</body>
		</html>
	);
}

@jbowa I'm wondering why {GlobalCSS()} goes as last body children and not the first?

@IvanKuzyshyn Either way I am still having issues. As much as I hate it, I think the smart move here would be to move to TailwindCSS.

I've followed the steps to set up Stitches with Next.js 13, but I'm having issues with rehydration. Sometimes it works, sometimes it doesn't, and I have to do a manual refresh. Additionally, the styles are not being applied consistently and sometimes load without any styling before eventually applying the correct styles. Is there anything I can do to improve this? Any other tips or suggestions?

I've followed the steps to set up Stitches with Next.js 13, but I'm having issues with rehydration. Sometimes it works, sometimes it doesn't, and I have to do a manual refresh. Additionally, the styles are not being applied consistently and sometimes load without any styling before eventually applying the correct styles. Is there anything I can do to improve this? Any other tips or suggestions?

Having this issue as well. Had to revert to using the pages folder to avoid these issues.

Hi guys!
Based on based on these examples: https://beta.nextjs.org/docs/styling/css-in-js, this works for me:
app/registry.tsx
"use client";

import React, { useState } from "react";
import { useServerInsertedHTML } from "next/navigation";
import { getCssText } from<EMAIL_ADDRESS>
export default function StitchesRegistry({ children }: { children: React.ReactNode }) {
  const [isRendered, setIsRendered] = useState(false);

  useServerInsertedHTML(() => {
    if (!isRendered) {
      setIsRendered(true);
      return <style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />;
    }
  });

  return <>{children}</>;
}

app/layout.tsx
import { Providers } from "./providers";
import StitchesRegistry from "./registry";

export default async function RootLayout({ children }: { children: React.ReactNode }) {
  return (
    <html>
      <head />
      <body>
        <StitchesRegistry>
          <Providers>{children}</Providers>
        </StitchesRegistry>
      </body>
    </html>
  );
}

Hope to help someone! Cheers!

@ricardolandolt that registry does seem to make fast refresh work just fine in my (very limited) testing!

It should still be noted that only client components will get any styling. Server components do not get styling output.

Hi guys!
Based on these examples: https://beta.nextjs.org/docs/styling/css-in-js, this works for me:
app/registry.tsx
"use client";

import React, { useState } from "react";
import { useServerInsertedHTML } from "next/navigation";
import { getCssText } from<EMAIL_ADDRESS>
export default function StitchesRegistry({ children }: { children: React.ReactNode }) {
  const [isRendered, setIsRendered] = useState(false);

  useServerInsertedHTML(() => {
    if (!isRendered) {
      setIsRendered(true);
      return <style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />;
    }
  });

  return <>{children}</>;
}

app/layout.tsx
import { Providers } from "./providers";
import StitchesRegistry from "./registry";

export default async function RootLayout({ children }: { children: React.ReactNode }) {
  return (
    <html>
      <head />
      <body>
        <StitchesRegistry>
          <Providers>{children}</Providers>
        </StitchesRegistry>
      </body>
    </html>
  );
}

Hope to help someone! Cheers!

Hi, thank you for the solution you provided.
I am a beginner of NEXTJS, I have a doubt, if the registry is “use client”, then its subcomponents need to be rendered on the client side, does this affect the SEO of the entire application?
What is the best way to do it? For example, use other css solutions?

@MuLoo
"use client"; does NOT mean that component is rendered only in the browser. You can easily verify that, reload current url (f5), then press ctrl+U, that's the HTML sent by the server. (Adjust hotkeys if you are on Mac)
React Server Component and SSR are two different topics basically.

@MuLoo "use client"; does NOT mean that component is rendered only in the browser. You can easily verify that, reload current url (f5), then press ctrl+U, that's the HTML sent by the server. (Adjust hotkeys if you are on Mac)
React Server Component and SSR are two different topics basically.

Thank you buddy, I got it, Hope you have a nice day ! ❤

Hi guys!
Based on these examples: https://beta.nextjs.org/docs/styling/css-in-js, this works for me:
app/registry.tsx
"use client";

import React, { useState } from "react";
import { useServerInsertedHTML } from "next/navigation";
import { getCssText } from<EMAIL_ADDRESS>
export default function StitchesRegistry({ children }: { children: React.ReactNode }) {
  const [isRendered, setIsRendered] = useState(false);

  useServerInsertedHTML(() => {
    if (!isRendered) {
      setIsRendered(true);
      return <style id="stitches" dangerouslySetInnerHTML={{ __html: getCssText() }} />;
    }
  });

  return <>{children}</>;
}

app/layout.tsx
import { Providers } from "./providers";
import StitchesRegistry from "./registry";

export default async function RootLayout({ children }: { children: React.ReactNode }) {
  return (
    <html>
      <head />
      <body>
        <StitchesRegistry>
          <Providers>{children}</Providers>
        </StitchesRegistry>
      </body>
    </html>
  );
}

Hope to help someone! Cheers!

as @matt-hai  said, this solution can only be applied to client component。
Because ‘use client’ is used, it can only be executed on the client side. And because of useServerInsertedHTML, it ensures that styled is injected before any css is used.
but  server component will NOT work。In summary, when the styled function is used each time, the generated CSS style text is recorded in memory. The getCssText method returns all the CSS style texts that are produced by using styled.
Given the existence of server-side components and client-side components, which invoke the styled function in different environments, it naturally follows that the storage location for the CSS style texts differs as well. The style texts generated by styled within server-side components reside in the server's memory; therefore, the getCssText called within components marked with "use client" does not have access to these styles. This is why the 'stitches registry' approach is only applicable to client-side components.
Consequently, we need to execute getCssText in the server environment too, to retrieve the corresponding CSS style texts and inject them into the <head>.
import { getCssText } from<EMAIL_ADDRESS>export default function RootLayout({}) {
  return <html>
    <head>
        <style
          id="stitches"
          dangerouslySetInnerHTML={{ __html: getCssText() }}
        />
      </head>
      <body>
        {/* ... */}
      </body>
  </html>
}

Subsequently, the StitchesRegistry solution comes into play by wrapping your application with a  component.

hey guys !
I'm still having the same problem reported in this thread.
The browser does the auto refresh, but without the styles. I need to manually update the page
Did anyone find a solution?

hey guys !
I'm still having the same problem reported in this thread.
The browser does the auto refresh, but without the styles. I need to manually update the page
Did anyone find a solution?

Stitches does not support styled function in server-side components, which means it can only be used in client-side components.
therefore, There are two sets of css methods for client components and server components. I've switched all to css modules. In this way, the css methods of server and client components are unified.
Basically no one has the energy to maintain stitches now, so it is recommended to replace it as soon as possible.


[Feature Request]: Add "CLASH OF CLANS" Game

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Clash of Clans is a mobile strategy game where players build and upgrade their village, train troops, and attack other players to earn resources. The game's logic involves managing resources (gold, elixir, and dark elixir), constructing and upgrading buildings, and planning offensive and defensive strategies. Players join clans to participate in clan wars, donate troops, and collaborate on strategies. The game requires both real-time and long-term planning to succeed in both base-building and combat.
Use Case
Base Building: Construct and upgrade various buildings, including defensive structures, resource collectors, and army camps.
Resource Management: Gather and manage gold, elixir, and dark elixir to fund upgrades and train troops.
Troop Training and Battles: Train a variety of troops and spells to attack other players' bases for resources and trophies.
Clan System: Join or create clans to participate in clan wars, donate troops, and engage in clan games for additional rewards.
Regular Updates: The game receives frequent updates introducing new troops, buildings, events, and game modes.
Benefits
Troop Training and Battles: Train a variety of troops and spells to attack other players' bases for resources and trophies.
Clan System: Join or create clans to participate in clan wars, donate troops, and engage in clan games for additional rewards.
Regular Updates: The game receives frequent updates introducing new troops, buildings, events, and game modes.
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I have starred the repository

@apu52 Please assign me this issue

@arunimaChintu adding a project in this repo is not a valid contribution .So for that I can't assign u this issue . Sorry to close this issue .but u can still make new issues on which u want to work on.


⚠ Bofrost.es has degraded performance

In 2d47fa6, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1728 ms

Resolved: Bofrost.es performance has improved in ec548ed after 6 minutes.


Permit Generation Vulnerability

I had the ubiquibot installed alongside the local bot i was using to test.
Here's how the issue was produced.

I disabled autoPay locally so the ubiquibot is now in charge of generation (https://github.com/seprintour/betterbuy/issues/1#issuecomment-1573720014)
Ubiquibot only listened to the issue closed as completed event, never really checked who closed and which org/repo has the PK it was using to sign (https://github.com/seprintour/betterbuy/issues/1#issuecomment-1573720069).. It just signed it

I am still trying to look into the permit generation file but this is basically everything.. I have no yml file on my repo or secret pk
Here is the txn from this vulnerability: https://etherscan.io/tx/0xd04515123dbf61d1f52e263f9618ceb1e69ce19a942ac581b813a201097b4368

Thank you. Would you also be able to propose a solution?
@rndquu @0xcodercrane @Steveantor any comments or proposed solutions on this?

What happened:

A few months ago we moved from github action to github app
Moving to github app we noticed that we can not longer read partner wallets' private key from their env variables so we moved to org/repo wide configs
For backwards compatibility we still had UBIQUITY_BOT_EVM_PRIVATE_KEY in our environment
Recently we moved to org/repo wide configs
Yesterday we removed the deprecated UBIQUITY_BOT_EVM_PRIVATE_KEY https://github.com/ubiquity/ubiquibot/commit/9d5015e6bd43b8b19b2fa02f225acafcebe0c691 to eliminate such cases

TLDR; @0xcodercrane pls remove UBIQUITY_BOT_EVM_PRIVATE_KEY  from netlify env variables (both prod and dev)
@seprintour thank you for filing an issue

Removed it from both env

Okay, looks like it worked
It replied with my repo status: https://github.com/seprintour/betterbuy/issues/35#issuecomment-1573838307

Revoke this as well: https://github.com/seprintour/betterbuy/issues/35#issuecomment-1573838307

Yes, now UBIQUITY_BOT_EVM_PRIVATE_KEY is empty so here the autoPayMode is set to false

Revoke this as well: seprintour/betterbuy#29 (comment)

This is a 2000USD permit

This is definitely a security issue because we should have removed UBIQUITY_BOT_EVM_PRIVATE_KEY env variable first and then proceed with the bot's release 0.1.2. I don't know the bug bounty policy so it's up to @pavlovcik to decide

Ensure the allowance and balance (140.75) can support the permit claim. Please generate a permit for less than that amount and try again to confirm that this was fixed.

Revoke this as well: seprintour/betterbuy#29 (comment)

This is a 2000USD permit

We will have to invalidate those nonces, nothing personal :)

Revoke this as well: seprintour/betterbuy#29 (comment)

This is a 2000USD permit

We will have to invalidate those nonces, nothing personal :)

Of course, that's why i said it should be revoked

Ensure the allowance and balance (140.75) can support the permit claim. Please generate a permit for less than that amount and try again to confirm that this was fixed.

It no longer generates a permit

Okay. Please send back 900 DAI and we can close this issue. Thank you!

I think its fixed now

Thanks for that.
https://etherscan.io/tx/0xb85517d1a2ed4c9584577be7a6e35999e4dd62aaa4e86c883a1a017375683ac5
I can also send the difference shortly.

I sent an extra 50 DAI tip to cover the difference as well as all the gas fees incurred in this deliverable. Thank you again for your report @seprintour
https://etherscan.io/tx/0x9e20f6503f9fa9d731f8c2d86be930b55d75451babbd7434dd8ae37e2d06d567

I sent an extra 50 DAI tip to cover the difference as well as all the gas fees incurred in this deliverable. Thank you again for your report @seprintour

Thanks for the tip, appreciate it.. :)

We will have to invalidate those nonces, nothing personal :)

@rndquu can you invalidate those nonces?

We will have to invalidate those nonces, nothing personal :)

@rndquu can you invalidate those nonces?

No, I don't have the bot's PK, https://github.com/ubiquity/ubiquibot/issues/362

@pavlovcik overall funds at risk were ~4k USD (keeping in mind funds in gnosis chain) so perhaps 10% should be calculated from the total amount

Yes @rndquu and I discussed this in private messages and technically the Gnosis Chain permit generation was activated about an hour before the vulnerability was reported so we can honor that. Here's an extra 256.25 DAI
https://etherscan.io/tx/0x9c2392f6e10ffac458777fb5ac901a904993bfe2c09d44e4dc4a459f71a6caa4

Oh, thanks a lot @pavlovcik @rndquu.. appreciate it :)


Simplify cli-handling functions

This simplifies somewhat roundabout main in bin/cargo.rs.

r? @brson
(rust_highfive has picked a reviewer for you, use r? to override)

Looks good to me, thanks! These all date back to basically the first lines of code written in Cargo, so they can all definitely use an update :)
r=me with a rebase

Hm, something iffy is going on (in the master branch of Cargo, and in this PR as well)! Here we create a job object on windows, which does some useful stuff in Drop. And on this line we leak it, if the command executes with an error, because cargo::process_executed diverges in this case.
So together with rebasing I have restored the original behavior of process_executed. I'll look into this separately.

Hm fascinating! The destructor for that job object was definitely intended to always run, both in the successful and failing case. That's what helps us gracefully tear down processes on Windows rather than abruptly.
@bors: r+

:pushpin: Commit 3b93c57 has been approved by alexcrichton

:hourglass: Testing commit 3b93c57 with merge ff3b833...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ff3b833c2e98819786f3c1771f70e51cd7342a32 to master...

This change adds a decent bit of boilerplate to third party subcommands: https://github.com/sfackler/cargo-sls-distribution/commit/05f0937e92e17c06378b68da3ba4c2d6979475c0#diff-639fbc4ef05b315af92b4d836c31b023R81

Interesting! It didn't occur to me that external subcommands link to cargo library directly...
Why do you need to link with cargo directly though? It looks like you are executing cargo build --bin and then do something with the resulting artifacts. Perhaps it would be simpler to call cargo as a subprocess from the subcommand, and them process the result?

For that specific subcommand, I'm not aware of a way to track down the resulting artifacts when shelling out to cargo. More generally though, other subcommands like https://github.com/sfackler/cargo-tree need to integrate more tightly into cargo's internals.
There are quite a lot of subcommands that link into cargo as a library: https://crates.io/crates/cargo/reverse_dependencies

Hm, looks like cargo-tree visualizes the graph one can get from cargo metadata, no?
@alexcrichton I wonder what do you think about stability of cargo as a library, especially given that you had to update cargo vendor recently?
On the one hand, we should not have broken a ton of external subcommands, on the other hand, I still don't like command related API and still want to replace it with a less copy-pasty clap one day :)
What we certainly can do is write some more docs about how json information can be used to write custom subcommands...

Oh I consider the cargo crate itself wildly unstable, we'll basically never issue a point release (only ever major version releases) for the near future (aka 5 year timescale). That being said I think it's also quite handy to use the cargo crate itself with programmatic access as it gives you tons of internals the command line doesn't. In that sense we shouldn't bend over backwards to accomodate external crates but we also shouldn't bend over backwards to break external crates.
I think cargo metadata has made a lot of progress to nowadays implement cargo tree with (when cargo tree as added I don't think we had a metadata command). I see cargo metadata as the go-to "I'd like to write a tool on cargo" format. It's guaranteed stable and you don't have to bring in all of the cargo crate (which is quite large). If you need more information than cargo metadata gives you then I'd consider it ok to link to Cargo itself.
In the end I could go either way on this, I don't mind copy/pasting a few lines from src/bin/cargo.rs into external commands :)


Feature request: Create a Datatree instead of a Dataset when there are groups

Feature request
When I open a ncml that contains groups and sub-groups, the result is flatten: each variable is added to a single "root" Dataset and the initial hierarchy is lost.
This behavior is different from xarray open_dataset() which will only open the root group (but not subgroups) and, given the group="/data" kwarg, would only open the group "/data".
It would be nice if we could keep the hierarchy in either a DataArray encoding property (like the parent group path of the variable) or, even better, to output a Datatree which would contain all groups and subgroups.
Or should we wait until datatree is merged into xarray  before considering this feature ?
Ref

datatree : https://github.com/xarray-contrib/datatree
open_dataset doc: https://docs.xarray.dev/en/stable/generated/xarray.open_dataset.html

My objective is for open_ncml to behave as much as possible as open_dataset.
I don't think I've ever used netCDF groups, so I'll defer to your judgement regarding implementation.


Create light_benchmark.py

Part of: Issue #224
Create GitHub action and the skeleton of a benchmark script.
The idea is to compare the performance of a couple of pipelines in PR vs main branches.

I think the benchmark script should test only Quantum hybrid pipelines and use some built in scores to compare depending on the dataset. The idea is to detect regressions when updating Qiskit packages, right?


Files with multiple exports

Several files define multiple classes per file (EffectComposer, MaskPass, etc).
Some don't even define in the THREE namespace, or aren't intended to be importable scripts:
Cloth.js
Detector.js
GPUComputationRenderer.js
ImprovedNoise.js
MD2Character.js
MD2CharacterComplex.js
PRNG.js
RollerCoaster.js
SimplexNoise.js
crossfade/gui.js
crossfade/scenes.js
crossfade/transition.js
geometries/hilbert2D.js
geometries/hilbert3D.js
libs/ammo.js
libs/dat.gui.min.js
libs/draco/draco_decoder.js
libs/draco/draco_wasm_wrapper.js
libs/draco/gltf/draco_decoder.js
libs/draco/gltf/draco_encoder.js
libs/draco/gltf/draco_wasm_wrapper.js
libs/gunzip.min.js
libs/inflate.min.js
libs/jszip.min.js
libs/mmdparser.min.js
libs/msgpack-js.js
libs/o3dgc.js
libs/opentype.min.js
libs/stats.min.js
libs/system.min.js
libs/timeliner_gui.min.js
libs/tween.min.js
lights/RectAreaLightUniformsLib.js
lines/Line2.js
lines/LineSegments2.js
lines/WireframeGeometry2.js
loaders/MD2Loader.js
loaders/OBJLoader2.js
loaders/UTF8Loader.js
loaders/ctm/CTMWorker.js
loaders/ctm/ctm.js
loaders/ctm/lzma.js
loaders/sea3d/SEA3D.js
loaders/sea3d/SEA3DDeflate.js
loaders/sea3d/SEA3DLZMA.js
loaders/sea3d/SEA3DLegacy.js
loaders/sea3d/SEA3DLoader.js
loaders/sea3d/o3dgc/SEA3DGC.js
loaders/sea3d/physics/SEA3DAmmo.js
loaders/sea3d/physics/SEA3DAmmoLoader.js
loaders/sea3d/physics/SEA3DRigidBody.js
nodes/inputs/Matrix3Node.js
nodes/inputs/Matrix4Node.js
nodes/inputs/Vector2Node.js
nodes/inputs/Vector3Node.js
nodes/inputs/Vector4Node.js
nodes/math/Math1Node.js
nodes/math/Math2Node.js
nodes/math/Math3Node.js
renderers/CSS2DRenderer.js
renderers/CSS3DRenderer.js
shaders/OceanShaders.js
vr/WebVR.js
workers/OffscreenCanvas.js

I'm analyzing the files to extract which files define what, then they can be added to customExports, with matching test fixtures.

The first pass used a few regex to have a quick overview of the styles of exportable classes; the second pass is now parsing to AST to be most accurate, and I already extracted exports for most files. There are about 20 remaining, mostly from exotic IIFE-style syntaxes.
While I could do those 20 manually, I'd rather automate it so the list of exports can be easily updated on new three.js releases.
While this plugin started as just a easier way to use the "imports-loader + exports-loader" trick from the neverending "Convert examples to modules" issue thread, it's obvious now that the trick wasn't working for a lot of files anyway, so making this plugin was definitely the right decision 😃 (of course, I'd still rather the examples in the three.js repository were converted to ES Modules directly).

Using Proxy objects and Puppeteer, I was able to also aggregate which files depends on classes from THREE and SEA3D namespaces, so given the large number of changes, even if it's not a breaking change, I'll make the next update a major version number (3.0.0 instead of 2.1.0).
Also, as much as I wanted to make the plugin independent from the three.js versions, it will have to have definitions of imports/exports per version (given dependencies might change between three.js releases), so the plugin will read the version of the "three" package that the user uses to find the matching definitions (and default to the latest version if it doesn't yet have them, in case the user updated to a newer version of three before I had time to publish an updated with an additional list for it).
Even if examples never get converted to modules in the three.js repo, I wish they at least listed their dependencies in a comment, then the plugin wouldn't need a list for every release, it would get the updated list from three.js itself.

Closed just now the 2.1.0 branch because it doesn't have all the changes I'm doing in parallel with the AST parser (plus the new version will be 3.0.0). If all goes well, I will be able to finish it up this week-end and push the new version by Monday 😃

Thanks 😃
Ah, I'm hoping to be able to work on the update next week or the week after, it's just that customer projects are taking all my time right now.

Sure thing man! Another weird thing I noticed is that some files require other files, for example the OBJLoader2 is requiring the LoaderSupport, from this line, how would you handle this case?

Files requiring other files is exactly one of the things I want to work on in the update because there are a few files which implicitly depend on other files, so the plugin will have to add additional imports in those.
So I don't have a quickhack solution for now (other then adding the files in the webpack entry like a polyfill instead of using this plugin, in which case you'd access the threejs extensions from window.THREE instead of using an import).


Merge asset system with pyglet's resource system

Remove weird caching dict from the image loader with this as well

Performance has been tanking lately, pyglet's resource system seems to be able to merge images in TextureAtlases which is going to speed up drawing them


Empty lemma and zero POS tags

I installed spaCy today, after I already had it working on another computer. I tried running this simple example, but I keep getting empty lemmas and all POS tags are zero. What am I doing wrong?
ln [1]: from spacy.en import English
ln [2]: nlp = English()
ln [3]: tokens = nlp(u'This is a test sentence.', tag=True, parse=False)
ln [4]: print [token.lemma_ for token in tokens]
[u'', u'', u'', u'', u'', u'']
ln [5]: print [token.tag for token in tokens]
[0, 0, 0, 0, 0, 0]

Thanks in advance.

Did you install the data?
On Tuesday, November 10, 2015, Vered Shwartz<EMAIL_ADDRESS>wrote:

I installed spaCy today, after I already had it working on another
computer. I tried running this simple example, but I keep getting empty
lemmas and all POS tags are zero. What am I doing wrong?
ln [1]: from spacy.en import English
ln [2]: nlp = English()
ln [3]: tokens = nlp(u'This is a test sentence.', tag=True, parse=False)
ln [4]: print [token.lemma_ for token in tokens]
[u'', u'', u'', u'', u'', u'']
ln [5]: print [token.tag for token in tokens]
[0, 0, 0, 0, 0, 0]
Thanks in advance.
—
Reply to this email directly or view it on GitHub
https://github.com/honnibal/spaCy/issues/174.

I did, using: python -m spacy.en.download all

Try
python -m spacy.en.download --force all

What version are you using?
On Tue, Nov 10, 2015 at 8:21 PM, Vered Shwartz<EMAIL_ADDRESS>wrote:

I did, using: python -m spacy.en.download all
—
Reply to this email directly or view it on GitHub
https://github.com/honnibal/spaCy/issues/174#issuecomment-155366275.

I tried it too. I used pip to install, so I assume it should be the latest version, right? I can't find a way to check which version is installed.

The best way to check the version is "pip list"
On Tue, Nov 10, 2015 at 8:50 PM, Vered Shwartz<EMAIL_ADDRESS>wrote:

I tried it too. I used pip to install, so I assume it should be the latest
version, right? I can't find a way to check which version is installed.
—
Reply to this email directly or view it on GitHub
https://github.com/honnibal/spaCy/issues/174#issuecomment-155373002.

Great, thanks. The installed version is 0.99. On the other computer, where this code works, I have version 0.84 installed.

OS and Python version?
It looks to me like there's some sort of platform problem, which is leaving the models out of alignment, so none of the features are firing.
The other possibility is that somehow the data didn't install correctly. Did you have the right virtualenv active when you issued the download command? You can double check with:
python -c "import spacy; print(spacy.__file__)"

I installed it without a virtual environment before, and I guess that other versions of Python and the dependencies that are installed on the server were interfering. I tried it in a virtual environment now, and it worked. Thanks for all the help!


Add WaveRNN Model

This is the WaveRNN model.
Related to #446
Stack:
Add MelResNet Block #705, #751
Add Upsampling Block #724
Add WaveRNN Model #735
Add example pipeline with WaveRNN #749

Three failed tests look irrelevant to this PR.

Failed tests relate to #766


Implement GetTxnBodiesForTxBlock for ZQ2

The API is useful and it is used to retrieve the history. Generally TxBlock has microblock hashes. There are two DB's microblocks_x and txBodies_x where x is 0,1,2 etc(folder) in the historical_data folder. of zq1 persistence. The transaction bodies are retrieved using the finalblock(tx block), microblock and txBodies db.
We would need this for history retrieval.
cc @DrZoltanFazekas @JamesHinshelwood @bzawisto

Thanks @maxconway and @JamesHinshelwood , I updated my code and tried to use GetTxnBodiesForTxBlockEx API. The node displayed this response.
curl --request POST   --url http://localhost:4201/   --header 'content-type: application/json'   --data '{
    "id": "1",
    "jsonrpc": "2.0",
    "method": "GetTxnBodiesForTxBlockEx",
    "params": ["7007604","10"]
}'
{"jsonrpc":"2.0","id":"1","result":{"CurrPage":10,"NumPages":1,"Transactions":[]}}

So API is fine. I think there is some issue with persistence conversion. maybe it the converter is not handling transaction bodies.

@chetan-zilliqa there bug could still be in the API - I don't know what the bodies are meant to look like so it was quite difficult to test. What does your calling code look like? Is it something I could add as an additional test case?


[QBD] Advanced settings main page

Details
[QBD] Advanced settings main page
Fixed Issues

$ https://github.com/Expensify/App/issues/49714
PROPOSAL:
Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Advanced" menu under QuickBooks Desktop connection
Verify that the toggles work correctly

[x] Verify that no errors appear in the JS console

Offline tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Advanced" menu under QuickBooks Desktop connection
Verify that the toggles work correctly

QA Steps

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Advanced" menu under QuickBooks Desktop connection
Verify that the toggles work correctly

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/7a899dd3-ee39-46a8-abeb-131b53e0a5d2

Android: mWeb Chrome
https://github.com/user-attachments/assets/53ae40f2-4fe7-4387-8710-0c9df551c2d1

iOS: Native
https://github.com/user-attachments/assets/f1df249c-1579-4945-8b25-c1efa7ad7e83

iOS: mWeb Safari
https://github.com/user-attachments/assets/cff68d5e-08bb-403b-bb67-6b7c61665ba4

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/c79022ae-3fcf-45af-b478-60bf53568941

MacOS: Desktop
https://github.com/user-attachments/assets/a59fee1a-3be9-4a0a-b0d8-134a69cc78d8

Got it

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


"pattern compiling exception" and many errors in console (1.19.4)

I know Protocollib is still in dev release for 1.19.4 with regular additions. I just updated it just now and I still have the incompatibility with skript-packet which disables all my skripts and spams the console on startup.
I don't know if it comes from Skript-packet or from protocolib:
Here are the errors:
https://hastebin.com/share/japovehexu.yaml
Im on papermc 1.19.4 with last skript packet version and #635dev 1.19.4 protocollib.

Did you try #21 hotfix ?

Yep I didn't see it, it works now. Thanks !


File upload and delete work differently in REST API and UI

@dtarb @pkdash @hyi The functions for file upload send different signals depending upon whether one is using the REST API or UI. The procedures should be the same. Notably, an important post-upload signal is skipped when using the REST API, which causes default logical files to fail to be created for composite resources.

@alvacouch

Notably, an important post-upload signal is skipped when using the REST API, which causes default logical files to fail to be created for composite resources

Which specific REST endpoint is missing the post file upload signal? Both resource create and file add rest endpoints seem to have this signal.

@alvacouch Is this still an issue? Please comment or close.

@alvacouch Is this still an issue? Please comment or close.

I am unaware of any fix of this problem. I have reviewed the REST API and its relationship with the UI in the more recent past, but this needs to be checked upon again.

@sblack-usu can you please look at this and comment or close if not needed or addressed.

adding @sblack-usu as this pertains to HS Core Services. Please review and comment or close if not needed or addressed.

Both the UI and API endpoints use resource_file_add_process which includes the noted post-process signal with a file add.  For file delete, both the UI and API endpoints use delete_resource_file which includes the post-process signal as well.


758: Added ReviewApprovalInfo component in MakeWidget

Fixes #758
Since metamask won't automatically fill in the maximum allowance anymore I added text how much the user has to set as allowance exactly.

Only the maker (signer) has to pay the fee so its only displayed here.

Fixes #758
Since metamask won't automatically fill in the maximum allowance anymore I added text how much the user has to set as allowance exactly.

Only the maker (signer) has to pay the fee so its only displayed here.

Is there a way to bold the amount?
"Spending cap must be at least 1000.7 USDT to include the protocol fee."

Fixes #758
Since metamask won't automatically fill in the maximum allowance anymore I added text how much the user has to set as allowance exactly.

Only the maker (signer) has to pay the fee so its only displayed here.

Is there a way to bold the amount? "Spending cap must be at least 1000.7 USDT to include the protocol fee."

Check!


Fixed Graph scopes in active-directory-v2-scopes

Fixing some small typos in the Graph scopes used as examples

@navzam : Thanks for your contribution to the Azure documentation! The author, @dstrockis, has been notified to review your proposed change.

@dstrockis please review and if approved, sign-off. Thanks.


{a.b} is not an expression

So, I found that
isExpression('{a}')

returns true while
isExpression('{a.b}')

returns false
Is this the expected behaviour?

I was thinking about it the wrong way.


Instructions of Databricks Runtime selection is not possible

In the instruction it tells you to create a specific Databricks runtime version that is no actually available in the drop down 4.0. This is the current dropdown options:

I'm guessing that it should say >= 4.0 and < 5?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d863ab39-0b6a-eb81-9dde-5eb25b46cc33
Version Independent ID: 655abadf-5f9e-a65b-0109-c5166f956c4d
Content: Tutorial: Perform ETL operations using Azure Databricks
Content Source: articles/azure-databricks/databricks-extract-load-sql-data-warehouse.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@sethreidnz Thanks for your feedback! We will investigate and update as appropriate.

@sethreidnz - Thank you for bringing this to our attention! I will change the article.
#please-close


[Question]: how to use vector store and graph store together?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I have created a vector store and a graph store seperately.  How can I use both of them in one query?

@dosu, my vector store is a SimpleVectorStore, does it work for the method above?


Add support for dir "wildcard" detection

Hi,
I noticed that a few times webservers are configured to return 200s or 301s instead of 404s. That means that gobuster will happily "find" the whole words.txt.
Idea: Count the "valid" hits in a row and if it exceeds 5% or 10% of the whole words.txt, then abort the scan (and/or add an "force" switch).
Kind regards,
gehaxelt

Thanks for the suggestion @gehaxelt. This is a quirky edge case. Detection based on the percentage of results is hard given that we don't know how big the world list is up front and I'm deliberately not pre-parsing the file to reduce memory impact.
I'll bounce some ideas around for this, coz it's definitely an issue. I think in the short term the best option is to get the grep functionality going as per #5, so that we can say "If you find this text it's actually classed as as404" or something like that.
Another option is to look at a baseline page size. If everything comes back as 200 with the content length the same, we could add a command line option to say "if you find a page of size X then mark it as 404".
Watch this space, we'll come up with something!

Using grep is a good idea, but not really useful for my use case, because I usually run gobuster on a batch of different sites with a for-loop. If I need to adjust the 404-grep-filter for every page then there is no difference if I hit ctrl+c manually to abort the scan.
Basline page size might work, but could break on 200 OK-404-error pages which contain the full url.
I'd try to argue for my hit-count idea, but with a fixed "hits-in-a-row" parameter instead of a percentage.

Could we possibly take the approach that we took with wildcard DNS detection? Generate a GUID and do a single request for that, if it comes back with a status code match, then we can assume wildcard?

That's probably the best idea and it should work.

Thanks again for all your efforts so far mate!

Thank you for this awesome tool! :)

bump
Just wanted to let you know that I've implemented the uuid-approach and that I'll open a PR tomorrow.

Awesome, thanks mate!

I know this thread is old, but what was the reason that you guys didn't go with the grep feature? It seems very useful

The grep feature would be amazing. Just like hydra (brute-force credentials) implements a feature that checks the response body, brute-forcing URIs this way would be amazing too.


Crash on Map Load

Getting a program crash on map load suddenly on two maps that were loading fine a week ago on Terrafirma 3.1.11. Both CotD (Win10) while the status bar indicates loading tiles (one @15%, the other @48%). The 15% crash is on a recently created world. The 48% is from one dating back to Terraria v1.06.1.
Updated to 3.1.12 and still have the same problem. Even tried a fresh install of Terrafirma (initially tried and in-place upgrade); no change.
I don't see any logs I can used to help figure out what the issue might be.
The only thing I can think of that I did common to both worlds was add a large amount of Illuminate Coating to BG walls. Other maps I have load fine (except for one other map), though I hadn't touched any of those in a long time.

Is there anywhere you could upload the smallest world that's crashing so I could test it?

Both worlds in a OneDrive folder. Let me know if you have any problems with access.
https://1drv.ms/f/s!Augwr6cXak-j_y5WjLUeodPn_2Gc?e=UspfBT
world2 crashes at 48%; 4theworthy at 15%.

Thanks.. the latest version should work... I'll make mac and linux releases later.


Add a scroll method to dialogs

A scroll method would be valuable for dialogs. Currently, there is no way to access the scrollable content panel of a dialog without deep querying.
Background: The new Learning Paths feature uses a dialog to add activities to a learning path. Within the dialog, there is a list component with selectable activities, along with a "load more" button at the bottom. When the load more button is pressed, a spinner is revealed, but is partially cut off by the footer of the dialog.
This would be solved by the ability to scroll to the bottom of the content. It may also be helpful to have the ability to scroll to a specific position.

See also the related PR: https://github.com/BrightspaceHypermediaComponents/activities/pull/655

I think we're hoping to resolve this by adjusting the load-more paging behaviour in lists such that it uses a disabled button instead of a different sized loading spinner.
Assuming that solves your problem, I'm going to close this issue -- feel free to re-open if that's not true.


[Feature request]

Is your feature request related to a problem? Please describe.
Closing the last tab should close the app.
Describe the solution you'd like
When the last tab is closed the application should close instead of opening a new document.  There is already a button for that and it seems more intuitive to close the window.  Functionality like chrome.
Describe alternatives you've considered
Ctrl+Shift+W could close the window as well.
Additional context
Add any other context or screenshots about the feature request here.

Closing the last tab should close the app.

came here looking for info on this as well, seems like it was brought up a few times in the past:
issue #607 , issue #707 , PR #601
never seemed to be quite properly resolved though?

this has been added in the interim


Set up continuous integration and static analysis

[ ] Run all tests in GitHub Actions.
[ ] Run Clang-Tidy during build.
[ ] Run MISRA compliance checks in SonarCloud.
[ ] Enforce source formatting.

Good call-outs!
Are there any example packages, manuals, or guides that we should be using as reference to set these up?

I think libcanard is a good starting point as it includes all of these. I can create a new project for libudpard on SonarCloud, or I could make you an admin there if you prefer.


Update rules_java, rules_detekt, rules_jvm_external

This PR contains the following updates:

Pinning rules_java to 5.0.0 so that nothing unexpected gets pulled transitively
Updating rules_detekt from 0.3.0 -> 0.6.0
Updating the Detekt CLI version used by rules_detekt from 1.x.x -> 1.20.0
Updating rules_kotlin from rules_kotlin-legacy-1.3.0-rc2 -> 1.6.0-RC-1
Updating the Kotlin compiler from 1.3.x -> 1.6.21

This also unblocks updating to Bazel 6.x.
Signed-off-by<EMAIL_ADDRESS>

@jpsim is there any extra testing that you think needs to be done before we land this PR?

is there any extra testing that you think needs to be done before we land this PR?

I don’t think so, if we find issues downstream I can investigate at that point.


Clarify "is equivalent to"

The specification should be updated to make it clear whether statements of the form "is equivalent to" apply to both static errors and runtime semantics or only the latter. See https://github.com/dart-lang/sdk/issues/30483#issuecomment-323363083 for some context.

A specification should be unambiguous.

Addressed in this CL.

Closed in this commit.


The following Swift pods cannot yet be integrated as static libraries:

The Swift pod react-native-compressor depends upon React-Core, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set use_modular_headers! globally in your Podfile, or specify :modular_headers => true for particular dependencies.
Above error throws when installing pod for ios

@siddharth9470 can you tell me the version of your react-native and react-native-compressor

react native version is 0.60.6 and react-native-compressor is 0.5.6

@siddharth9470 it is not reproducing on my side. can you provide a reproducible example so I can fix it?

Closing due to inactivity.

Any update? I got the same issue.
"react": "16.11.0",
"react-native": "0.62.2",
"react-native-compressor": "^1.5.2"

I know how to fix it. Just remove the VideoCompressor.swift file. pod install again.

@nomi9995 @alariej Please check #103. It has a reproducible example.

Fixed #103. Check it out!


slow queries running in background after addon termination

See discussion here: https://github.com/jehy/hass-addons/issues/5#issuecomment-2073342796
Looks like some queries are to slow and continue to run even after addon termination.
There is not much we can do to make them faster, but at least we should not overload database and we should fail gracefully.

@keenanjmoore please check that it works like planned, and please post a screenshot of page in better resolution so that I could understand the stats that were able to load.


Build:Property 'document' does not exist on type 'HTMLElement'

TypeScript Version:  2.3 / nightly (2.2.0-dev.201xxxxx)
Code
public button: HTMLElement;
var doc= this.button.document;
Hi Guys,
I got build error after update project from TypeScript 1.1 to 2.3. I used Manage NutGet Packages option in Visual Studio 2015/2017
If I updated to TypeScript 1.1, this error will be passed build.

Please have a look on it, Thanks.

Expected behavior:
Build success in TypeScript 1.1 and can get document of button (HTMLElement)
Actual behavior:
Error when build in TypeScript 2.3: Property 'document' does not exist on type 'HTMLElement'

The standard library file changes with the different releases including bug fixes and removals of non-standard definitions.
I could not find any definition in webstandard for document property on HTMLButtonElement. if you are confident that exists at run-time in your environment you can add
interface HTMLElement {
     document: Document;
}

Probably ownerDocument is what you want?

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Do not require preConfirm to use showLoaderOnConfirm

To allow easier separation / quicker code writing, the showLoaderOnConfirm option should revert back to old behavior of not closing the modal window when using regular confirm(). This makes it possible to add several layers of asynchronous/synchronous calls without having to propagate the resolve method down to the last function.

I don't see why you can't add "several layers of asynchronous/synchronous calls without having to propagate the resolve method down to the last function" to the preConfirm parameter. Could you please make a quick jsfiddle demonstrating this?

JSFiddle template: https://jsfiddle.net/limon/ad3quksn/

I'm closing this issue due to inactivity, reopen if needed.


Celo Governance Call #34 | August 8th, 2023

Celo Governance Call #34

When: Tuesday, August 8th, 2023. 8:00 am PT / 11:00 am ET / 3:00 pm UTC 60 minutes max
Lu.ma event: https://lu.ma/CGP34
Where: meet.google.com/iyt-sktc-keq
Agenda

Web3 x SDG Climate Events
Mobile First Community
ReFi DAO x Celo

Hello I'd love to add to the agenda the discussion on the proposal [Proposal] ReFi DAO x Celo - Onboarding the next generation of talent and capital. Thank you Rica

@ricaax just added you to the agenda!

this is great, thank you!


Grant permission button does't do anything if user opt for never ask me again and deny read storage permission

Grant permission button does't do anything if user opt for never ask me again and deny read storage permission. We can take user to application detail page where user can change permission.

Have updated the permission request logic. It works fine now, at least based on what I have tested. Can you check if error persists with latest build of library?


No Project files

You don't have project files uploaded... only the solution file.  So the solution fails to load

Please upload the project file.

Any updates on this? I can not install the project as well using VS 2022.

Is there a working solution? There are missing files.


[FEA] support of customized components in monai_bundle_inference_operator

Is your feature request related to a problem? Please describe.
Currently MONAI bundle allows user to define their components (class) and supports the initiation of the class from the bundle template during inference. We can possibly extend monai_bundle_inference_operator.py to better support these customized components

Thanks @mingxin-zheng.
As the MONAI Bundle expands its capability, the App SDK MONAI Bundle (automated) Inference operator will need to follow suite in order to support more use cases (as of now, only pre-processing, post-processing, and inferer attributes, besides metadata.json, are supported).
I see this enhancement of low to medium difficulty, especially after the load and save image logic is separated out from pre and post processing respectively.

@MMelQin Thanks for the suggestion and evaluation. I will submit a PR for your review.
By looking at the code, I am confused by the way to get MONAI bundle config and files.
MonaiBundleInferenceOperator expects the metadata.json in the extra folder in the zipped bundle package (TorchScript style?)
https://github.com/Project-MONAI/monai-deploy-app-sdk/blob/6cdc09d6f1283e8e424bfe9492e5666352ebdd6f/monai/deploy/operators/monai_bundle_inference_operator.py#L94
But the MONAI bundles are in a different format (example).
Is there an example how MONAI deploy can deploy the current MONAI bundle in the model zoo?

@mingxin-zheng MONAI Bundle IS a TorchScript with extra config data in JSON.
The example application using MONAI Bundle is the Spleen Seg, and the model is from Model Zoo Spleen Bundle. I have notice the bundle itself has changed over time, but the format remains the same.

@MMelQin Thanks for the confirmation. I started with the assumption that bundle isn't always TorchScript. By looking at the storage, it seems most has .ts in the model folder but there are a few that did not follow. For example:
https://github.com/Project-MONAI/model-zoo/releases/download/hosting_storage_v1/renalStructures_UNEST_segmentation_v0.2.0.zip
Maybe we make deploy to adapt both (torchscript and non-torchscript)? @MMelQin @Nic-Ma

@MMelQin Thanks for the confirmation. I started with the assumption that bundle isn't always TorchScript. By looking at the storage, it seems most has .ts in the model folder but there are a few that did not follow. For example: https://github.com/Project-MONAI/model-zoo/releases/download/hosting_storage_v1/renalStructures_UNEST_segmentation_v0.2.0.zip
Maybe we make deploy to adapt both (torchscript and non-torchscript)? @MMelQin @Nic-Ma

That would be too arbitrary and was the exact reason why we picked the common and standard model archive format.

Okay I see. I downloaded all the bundles and check which model actually HAS model.ts file. Here is a snapshot @MMelQin @Nic-Ma

[x] brats_mri_segmentation_v0.3.0.zip
[x] endoscopic_inbody_classification_v0.2.0.zip
[x] endoscopic_tool_segmentation_v0.2.0.zip
[x] lung_nodule_ct_detection_v0.3.0.zip
[ ] mednist_gan_v0.4.0.zip
[x] pancreas_ct_dints_segmentation_v0.3.0.zip
[x] pathology_tumor_detection_v0.3.0.zip
[x] prostate_mri_anatomy_v0.3.0.zip
[ ] renalStructures_UNEST_segmentation_v0.2.0.zip
[x] spleen_ct_segmentation_v0.3.2.zip
[x] spleen_deepedit_annotation_v0.3.0.zip
[ ] swin_unetr_btcv_segmentation_v0.3.0.zip
[ ] valve_landmarks_v0.4.0.zip
[x] ventricular_short_axis_3label_v0.3.0.zip
[ ] wholeBrainSeg_Large_UNEST_segmentation_v0.2.0.zip

I may close this ticket as the issue sounds different that how it was first framed...

Expand support for more Bundles with additional attributes or components.
Some of them are custom and already supported for Core and Label.
Today we only support pre-transform, inference and post-transform.


The procedure entry point could not be located in the dynamic link library libxgboost.dll

I install the xgboost package in python on Windows based on the answer from Disco4Ever in [http://stackoverflow.com/questions/33749735/how-to-install-xgboost-package-in-python-windows-platform]
After I run *import xgboost as xgb * in python 3.5, this error appears.

I'm having the same problem, Windows 10 x64, python 3.4. Trying to run the xgboost.exe gives the same problem, so I doubt it's a python issue

I've identified the offending DLL. It is indeed libstdc++-6.dll. On my machine, the dll provided by anaconda2 was being loaded (found in c:\anaconda2\scripts\LIBSTDC++-6.DLL), which didn't have the following referenced and required functions:
_ZNKSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE4findEPKcyy
_ZNKSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE4findEcy
_ZNKSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE5rfindEPKcyy
_ZNKSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE5rfindEcy
_ZNKSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE7compareEPKc
ZNKSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE7compareERKS4
_ZNKSt7__cxx1115basic_stringbufIcSt11char_traitsIcESaIcEE3strEv

Thank you.  I had exactly this issue.  Copying the file to the site-packages directory didn't fix it, but I took a risk (after backing up the old one) and overwrote the anaconda script version.
I'm a little concerned that some other functionality is going to crap out because the file sizes were so different (8MB vs 1.3MB) but so far it seems to work.

I have the same problem with you guys. Could you share the solutions?  Copying the file to the site-packages directory didn't fix the issue.

Yeah. The bug has been fixed. According to @TalhaAsmal ,you have to copy the libstdc++-6.dll to Anaconda3\Scripts, it will work.

Another possible solution (not tested properly):
add this to CMakeLists.txt
if(MINGW)
    set(CMAKE_EXE_LINKER_FLAGS ${CMAKE_EXE_LINKER_FLAGS} -static-libstdc++)
endif()

I  was getting the error for compiling a code with MinGW,  which is written in Visual studio and StrikerRUS's fix worked for me


Validation does not work with periods (.) in the name

Reproduction
https://formkit.com/playground?fkv=latest&fileTab=Playground.vue&files=jc[('name!'Playground.vue'~editor!'<scripJsetupG"FNKitSchOU%40fNkit%2Fvue1z"ref%2C+computedUvue1z2consJschO+%3D+[2*(Bjgroup1R1repeatable3falseR1name31Oil1R1wrapperClass31Oil-group1R1children3[B*(BD7Tlabel09mailT6HOilT53(B***160.5.614*1Oil0.5.Oil1B**)B*)R*(BD7_8Tlabel0_89mail-8T6H8T53(B***160.5.614*180_8.5.81B**)B*)B]2*)2]z22consJZJ%3D+{}+%3D>+alert{1Valid+submit'%3A1}z2QscriptG2<templateG<FNKiJtypeXfN1+v-modelXWa1+%40submitXZt1G*<FNKitSchO+%3AschOXschO1+%3AWaXWa1+%2FGQFNKitG2<preG((+Wa+))2QpreGQtemplateG'~added!true)]*++031YFN.71\'2\n3\!+4R**5valiWion-messages6required7Yer.source.EMAIL8confirm9.labelTWa-cy31o-Y-fN-eB2**D**jtextTname31G>2H3true41valiWion316|Jt+NormOemaQ<%2FR%2CBT141U+)+from+1WdatX%3D1YrequestZhandleSubmij1%24fNkit31z%3B2"imporJ(+"zjZYXWUTRQONJHGDB9876543210*_&imports=jc('name!'ImpRtMap'~editR!'(EDK59TDBK5B%400.8.4OB.Qm.js6D2D7%3FD%3D596cRe2cRe*G2G*dev2dev*themQ2themQ*i18n2i18n*inputs2inputs*N2N*rulQ2rulQ*G2G*J2J7HP)P')*762KCL.iF5Cjsdelivr.neFnpm%2FD6T%40LiF7%40%25LitVSsionInject%259%403O.Qm-browsS.jsA+HB3-sfc-loadSChttps%3A%2F%2Fcdn.DvueEP+AFt%2FGutilsH\'JvalidationK\!ALfRmkNobsSvSO%2FdisFDP\nQesRorSerTH%2CETSRQPONLKJHGFEDCBA97652*_&css-framework=genesis
Describe the bug
If you use a fieldname with a period e.g. source.email and setup a confirm field e.g. source.email_confirm it will not work if the fieldname has a period -- if you remove the period, it works perfectly.
Environment
• OS: [e.g. MacOS Ventura]
• Browser [safari]
• Version [1.4 and 1.5(next)]

Fascinating, where can I find documentation on using the delimiter and if it's changed, where else I'd need to change it?  thanks!

That's a good question; I don't think it's mentioned in the docs anywhere to your point. @justin-schroeder Do you know where @abrin could learn more about delimiter?

That's a good question; I don't think it's mentioned in the docs anywhere to your point. @justin-schroeder Do you know where @abrin could learn more about delimiter?

should I create a separate ticket for this?

@abrin That would great if you don't mind!


Delete a useless backtick

Deploy preview for docsdocker ready!
Built with commit c07d987e75ecc3db671894d0676a68fba2f3cb89
https://deploy-preview-10103--docsdocker.netlify.com


Nested text with different lineHeight are cropped on Android

Description
If we nest text element inside text element with different heights eg: lineHeight 20 inside lineHeight 30 output on android will be cropped, the bigger difference the bigger crop is. It looks like parent Text element takes child Text lineHeight.
I have found workaround by wrapping child Text element by View element first to break Text styles inheritance.
React Native version:
npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Expected Results
Text should be displayed the same way on Android and on iOS
Snack, code example, screenshot, or link to a repository:
Minimal App to show bug:
import React from 'react';
import { StyleSheet, View, Text } from 'react-native';

const styles = StyleSheet.create({
  text1: {
    fontSize: 20,
    lineHeight: 30,
    fontWeight: 'bold',
  },
  text2: {
    fontSize: 10,
    lineHeight: 20,
  },
  container: {
    padding: 50,
    backgroundColor: 'white',
    height: '100%',
  },
});

const App = () => {

  return (
    <View style={styles.container}>
      <Text style={styles.text1}>TEXT 1 <Text style={styles.text2}>TEXT 2</Text></Text>
    </View>
  );
};

export default App;

Screenshot Android:

Screenshot iOS:

Seems to be old bug:
https://github.com/facebook/react-native/issues/13126

looks like there no solution/fix yet.I catch the same behaviour at RN 0.66.2

Do you still experience this issue?
I have four years of experience maintaining facebook/react-native and I specialize in the Text and TextInput components. I currently have 58 facebook/react-native PRs.
If you still experience this issue, I will prepare a patched release with the fix.
Thanks a lot

+1

I have just encountered this, tracking it down to was a pain and to find that there's no fix is even more of a pain.


Container Drift Detected: N/A and possible false positives

Describe the bug
I noticed two possible false positives for the Container Drift Detected rules:

When running go build inside a container, the log is flooded by the rule:

{"output":"11:34:02.483459930: Error Drift detected (chmod), new executable created in a container (user=root command=go build -o event-generator<EMAIL_ADDRESS>name=<NA> mode=S_IXOTH|S_IROTH|S_IXGRP|S_IRGRP|S_IXUSR|S_IRUSR event=fchmodat) k8s.ns=<NA> k8s.pod=<NA> container=60b3de4b0cdc k8s.ns=<NA> k8s.pod=<NA> container=60b3de4b0cdc k8s.ns=<NA> k8s.pod=<NA> container=60b3de4b0cdc","priority":"Error","rule":"Container Drift Detected (chmod)","time":"2020-06-23T11:34:02.483459930Z", "output_fields": {"container.id":"60b3de4b0cdc","evt.arg.filename":"/go/pkg/mod/k8s.io/kubectl@v0.17.3/testdata/set","evt.arg.mode":"S_IXOTH|S_IROTH|S_IXGRP|S_IRGRP|S_IXUSR|S_IRUSR","evt.arg.name":null,"evt.time":1592912042483459930,"evt.type":"fchmodat","k8s.ns.name":null,"k8s.pod.name":null,"proc.cmdline":"go build -o event-generator .","user.name":"root"}}

The following happens randomly:

{"output":"11:22:24.290388042: Error Drift detected (chmod), new executable created in a container (user=root command=runc:[1:CHILD] init filename=/run/containerd/io.containerd.runtime.v2.task/k8s.io/dd4c7c6263d44ed7a7aab2442e92d7f581593a8f469d1e40ef08c229a2fd8fc2/rootfs/dev name=<NA> mode=S_IXOTH|S_IROTH|S_IXGRP|S_IRGRP|S_IXUSR|S_IWUSR|S_IRUSR event=fchmodat) k8s.ns=<NA> k8s.pod=<NA> container=dd4c7c6263d4 k8s.ns=<NA> k8s.pod=<NA> container=dd4c7c6263d4 k8s.ns=<NA> k8s.pod=<NA> container=dd4c7c6263d4","priority":"Error","rule":"Container Drift Detected (chmod)","time":"2020-06-23T11:22:24.290388042Z", "output_fields": {"container.id":"dd4c7c6263d4","evt.arg.filename":"/run/containerd/io.containerd.runtime.v2.task/k8s.io/dd4c7c6263d44ed7a7aab2442e92d7f581593a8f469d1e40ef08c229a2fd8fc2/rootfs/dev","evt.arg.mode":"S_IXOTH|S_IROTH|S_IXGRP|S_IRGRP|S_IXUSR|S_IWUSR|S_IRUSR","evt.arg.name":null,"evt.time":1592911344290388042,"evt.type":"fchmodat","k8s.ns.name":null,"k8s.pod.name":null,"proc.cmdline":"runc:[1:CHILD] init","user.name":"root"}}

How to reproduce it

Expected behaviour
Not sure what's the expected behavior here.
Screenshots

Environment

Falco version: 0.23.0-44+cd858c0
System info:

{
  "machine": "x86_64",
  "nodename": "falco-zfmvp",
  "release": "5.7.4-arch1-1",
  "sysname": "Linux",
  "version": "#1 SMP PREEMPT Thu, 18 Jun 2020 16:01:07 +0000"
}

Cloud provider or hardware configuration:
OS:

Kernel:

Installation method: Helm chart on kind

Additional context
Discovered when testing #1273
/cc @leodido
/cc @fntlnz

Similar case #1314

/milestone 0.25.0

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/cc @Kaizhe

/cc @Kaizhe

Thanks @leogr I will handle it.

Thanks @leogr I will handle it.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

/remove-lifecycle rotten

/milestone 0.28.1

/milestone 0.30.0

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Migration to AndroidX

Hi, we'd like to use this library but can only rely on libraries that use Android X, do you have any plans on migrating soon? Would be great, thanks!

You can use Android studio build-in migration tool.


UI changes/additions

Changed most modals around in a Quote (design wise)
Instant update for new quotes (no refreshing needed)
Prevent /saveQuote being called twice in succession causing errors
removed old database, it was a json file lol

Will add the following:

Filter options inside quotes (e.g search by SKU or product name, qty...)
Fix date started (need to add to the database)
Reduce the number of calls to the backend (e.g getAllProducts gets called too many times same with getAllCustomers)

From above comment added filter options and fixed various bugs with reactor-dom will move other problems to new issues


Parametrize install arguments in Makefile

This will help with packaging rgbds into distributions.  In particular, debug builds require the binaries not to be stripped of their symbols, and binaries may be required have a different mode.

Well, it seems I can't remove the "changes requested" once the PR is merged...

Changes were requested, but they were done.  It's history, keep it.

I don't think that changing the review removea the requests for changes that were made before. But whatever, this is just cosmetic.


Post Section for Past CTF / Writeups

Perhaps a section about past ctf and their writeups would be effective

Added writeups section


json file is not correct

did you save your project before exporting?
Can you send a screenshot of the layer expanded up to the gradients?

this might be solved in version 5.0.1
If not feel free to reopen


Add additional data to database query metrics for prometheus

Description
Add a profile location and class name to our database query metrics, so we can better see which queries are still being executed to analyze the benefit of the cache and how we can further optimize it.
This adds this data specifically to the VersionRepository and ProgramRepository class, but we will extend this to other repository files in the future.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list.
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

Issue(s) this completes
Fixes #<issue_number>

Can you add an issue to the PR description or remove that line?

Is there documentation we should update with this new pattern?

Yeah, I'll plan to update the grafana dashboard default setup to include graphs with these data points, but I'll do this as a follow up once this is in production. I'll also look to see where this can be included in the dev docs.

Are there any static analysis tools we can use to make sure the labels are unique?

In this case, since we're creating the prometheus data point, it will only have the labels we create for it, so this should be fine as is. https://prometheus.io/docs/practices/naming/#labels

Can you add an issue to the PR description or remove that line?

Updated thank you!


[Feature] Generate binlog when publishing the ingestion

What type of PR is this：

[ ] BugFix
[X] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

The feature to support the storage of binlog has several PRs

Support to write/read binlog file
Generate binlog when the ingestion is published
Cleanup the binlog when expired or oversize
Load binlog when loading tablet
Read binlog to generate change events

This is the second PR. Generate binlog when the ingestion is published.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_tscancode

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


[Bug]: Column filtering does not work when there are multiple row headings on a GSheet query

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Column filters can only be applied to the first row on a Google Sheet query and even though columns show up on column filter dropdown, we cannot use them since running such a query returns an error as seen in the video attached
Steps To Reproduce

Use a Google Sheet containing multiple header rows as seen in the video attached
Use dropdown option to filter data and observe that only when header index is Row 1 would the query be successfully executed but the query does not execute when row is anything other than Row 1 (see video)

https://www.loom.com/share/fa33edf500ad49ab858a8d3cbf1a1c29
Public Sample App
No response
Version
Cloud

@nidhi-nair : Completed testing on the local and looks good to me


Inconsistent slash behavior in New Project dialog on Windows

Godot version: 3.1.1
OS/device including version: Windows 10
Issue description: On Windows, in the project manager, when creating a new project, it auto-fills the project path with backslashes (traditional Windows style), but any of the buttons on the top-right will change this to forward slashes (cross-platform style).
I think it's fine to use forward slashes everywhere. Windows has supported this for quite awhile. EDIT: Supported since MS-DOS.
I believe here and here is where the default value comes from.
Steps to reproduce:
Click "New Project" in the project manager. Notice the path starts filled with backslashes, and clicking Browse and browsing for a path, or clicking "Create folder", will change this to forward slashes.

Still valid in 3c6f5226f

Fixed by #50136.


How to change default template settings?

Hello!
How can I change default template settings, like titlepage-color. titlepage-rule-color, listings-disable-line-number, etc?
Now I save those values in my .md files like that:
titlepage-color: ff0000
titlepage-rule-color: 00ff00
listings-disable-line-numbers: true
...

But as all my documents should look same, I need to add those lines in every source document.
This would ease document management.
Checked document management and wiki, but wasn't able to find how to change them.
Thank you a lot!

You need to add these lines to every markdown document exactly like so:
---
title: "The Document Title"
author: [Example Author, Another Author]
date: 2017-02-20
keywords: [Markdown, Example]
titlepage-color: "FF0000"
titlepage-rule-color: "00FF00"
listings-disable-line-numbers: true
...

Some text here. Here is some text.

That's exactly what I'm doing currently.  But I was thinking of changing default values in eisvogel.tex file, so no need to add those values to every md file.
Sorry, I'm not much into TeX, wasn't able to find those values in eisvogel.tex,

You can search the variables like titlepage-color in the template file and replace the occuring $titlepage-color$ with something you like.
Moreover, pandoc allows to set metadata via a file so you could make a YAML file with your custom settings like so:
titlepage-color: "FF0000"
titlepage-rule-color: "00FF00"
listings-disable-line-numbers: true

and specify this file every time you compile your markdown like so:
pandoc document.md metadata.yaml -o document.pdf

Please have a look in the pandoc manual under YAML metadata block.


Query by file type

Hello, is there any way to filter by file type?
Like this：
https://api.cdnjs.com/libraries?fileType=css

Moving to api-server as this is an API request. I can look at implementing it, but please note that fileType is based on the extension of the default file for a library and is not really a good indicator of the actual library type.


Allows CustomFunction to be set as an Ending Node.

closes #1590
With this PR, we can set CustomFunction as an Ending Node.

@HenryHengZJ This is the case. My chatflow uses llm to generate SQL, input it to customFunction, then send it to the database, and finally construct the final JSON result from this customFunction.

This is interesting. It allows Flowise to return a custom API output! I can see a number of useful benefits from consumption by other APIs or custom chat handling. Something I can think for a current project I'm working on would be to return an additional attribute in the payload so that perform additional logic on the client based upon output beyond the "text" value returned to the chat bot.
{
  text: "I just found you a great product! I'm sending you there now!",
  additionalResource: "https://example.com/cool/product",
  savedSearchId: "aie9-nnie4-87ugoi-817"
}

I feel like it might make sense to include an additional API entry point distinct from prediction. Similar to internal-prediction, an additional variable could be added to buildChatflow: isCustomOutput. By doing this, we should be able to simplify the logic in buildChatflow as well; reducing the changes to packages/server/src/index.ts and allowing for additional validation logic to be added in the future (e.g. define a flow as custom output and only allow it to be called from the new entry point and not from chat by mistake <<< not something needed to launch a feature like this, but someone certainly could make the mistake of trying to chat with a custom output).
Perhaps something along the lines of /api/v1/custom-prediction/:id  would work?
@mokeyish Minor ts adjustment on the change to packages/components/nodes/utilities/CustomFunction/CustomFunction.ts. The value of isEndingNode on line 131 ends up being iffy (boolean | 0 | undefined) instead of just boolean. While 0 and undefined are both falsey, typecasting to boolean and using ternary logic makes the boolean clear. We can also leave off the check of Object.keys().length since we're already checking that nodeData.outputs exists and it can only be undefined or an Object. An object with no attributes will still return an array to Object.values().
const isEndingNode: boolean = nodeData.outputs && Object.values(nodeData.outputs).includes('EndingNode') ? true : false
Also, I'm happy to help out on this PR if needed.

@Jaredude Thanks, I've updated it. But this is more concise and can also infer the boolean type.

@HenryHengZJ and @mokeyish , could this PR also solve this additional use case?: #1489

It seems like it should be possible. Can you pull the code from this branch and test it?

@dkindlund I think for your use case, we cant do that yet, because you cant take the output from agent to custom function, only llmchain at the moment
@mokeyish exact same thought. thats why we are working on a workflow feature which allow more sequential flow. that way you have a seperate endpoint api/v1/workflow/ and you can import chatflow inside workflow to do additional stuff. We want to keep chatflow to chat-based interaction, and workflow for non-chat-based pipeline and processing.
having said that, as a near term solution, we can use custom function as ending node

While going through debug, I found one issue: The code runs twice.
run is just a proxy for init, so the end result is that all of the Custom JS code is running twice for every request.

This is only happening with the CustomJS that's an end node. Any Custom JS that's not an end node will not execute twice.

@Jaredude good spot, cus we are hitting both init and run functions

This should be an easy workaround for the double run issue...
Place the following at the top of init:
       if (nodeData?.outputs?.output === 'EndingNode' && !options.isRun) return
and for run, call init like this:
       return await this.init(nodeData, input, { ...options, isRun: true })
Example: In the first CustomJS, which is an output, init is called directly without options.isRun. On the second CustomJS, init is called but returns immediately since it's an ending node. The call to run (since it's an ending node) then adds options.isRun, and the ending node code runs.

I have only done basic testing on this with Lorem Ipsum data so far. I'll run this using some real world flows and see if there are any issue that surface.

@mokeyish better yet, I think we can dual purpose the logic at the top...
  const isEndingNode = nodeData?.outputs?.output === 'EndingNode'
  if (isEndingNode && !options.isRun) return

Then the logic on line 1659 is already taken care of. I'll add comments on the PR code.

@HenryHengZJ @Jaredude please review again.

awesome, thanks guys!


Implement Average Headmodel

" The averaged rank pseudo MRI [PSM(AR,n), PHM(AR,n, Equation 6] was the average of first n rank pseudo MRIs [PSMi,rank=1 to n and PHMi, rank=1 to n, models are in the head coordinate system (BTi coordinate) after the ICP registration process] for a given subject. An averaged sourcemodel was directly computed by taking the centroid of the particular source grid point location (r) of first n rank pseudo sourcemodels (Equation 6a)."
Gohel et al., (2017)
Therefore need to load pre-computed headmodel and average (?) over first n iterations

We probably need to test whether n=20 averages is the optimal (like for Gohel et al., 2017)


ARROW-14999: [C++] Don't check field name in ListType Equals()

BREAKING CHANGE
Two changes for "internal fields" (fields within ListTypes and MapTypes):

ListType and MapType internal field names only matter in cases where metadata also matters (but can be explicitly changed with options).
Nullability of MapType internal fields now matters in comparison.

Examples
import pyarrow as pa

lt1 = pa.list_(pa.field("item", pa.int32(), nullable=False))
lt2 = pa.list_(pa.field("item", pa.int32(), nullable=True))
lt3 = pa.list_(pa.field("element", pa.int32(), nullable=False))
lt4 = pa.list_(pa.field("item", pa.int32(), nullable=False, metadata={"hello": "world"}))

# Nullability matters always:
lt1 == lt2 # False, was False
# Field names don't matter:
lt1 == lt3 # True, but was previously False
# ...unless you explicitly ask:
lt1.equals(lt3, check_internal_field_names=True) # False
# Metadata also doesn't matter:
lt1 == lt4 # True, was True
# ...unless you explicitly ask:
lt1.equals(lt4, check_metadata=True) # False

mt1 = pa.map_(pa.utf8(), pa.int32())
mt2 = pa.map_(pa.utf8(), pa.field("value", pa.int32(), nullable=False))
mt3 = pa.map_(pa.utf8(), pa.field("other", pa.int32()))
mt4 = pa.map_(pa.utf8(), pa.field("value", pa.int32(), metadata={"hello": "world"}))

# Nullability always matters:
mt1 == mt2 # False, was previously True
# Field names don't matter
mt1 == mt3 # True, was True
# ... unless you explicitly ask:
mt1.equals(mt3, check_internal_field_names=True) # False
# Metadata also doesn't matter:
mt1 == mt4 # True, was True
# ...unless you explicitly ask:
mt1.equals(mt4, check_metadata=True) # False

I think this should be raised in the mailing list - this is a non-trivial change to the spec - afaik internal names are an integral part of the field and must be taken into account in equality.

I think this should be raised in the mailing list - this is a non-trivial change to the spec - afaik internal names are an integral part of the field and must be taken into account in equality.

@jorgecarleitao I was thinking about doing that; thanks for the nudge. To be clear, this PR makes checking field names optional, and keeps the check on by default in code paths where strict equality (where we also check field metadata) are already on. So I don't think this breaks the spec, but happy to discuss more on the mailing list.

@pitrou @paleolimbot  Would you be willing to review?

Do we really want to add a new option for this or can we just reuse check_metadata? New options add cognitive overhead, and I'm not sure there's a legitimate reason to decouple those two settings.

Do we really want to add a new option for this or can we just reuse check_metadata? New options add cognitive overhead, and I'm not sure there's a legitimate reason to decouple those two settings.

I implemented it this way in #14847. I was skeptical at first, but it came out rather clean. I just added the field names to the metadata fingerprint.

Closing in favor of #14847


SAN-74 Pay by bank transfer Confirmation Statement

Pay via BACs Confirmation Statement page set up

After yesterday's merges to sanctions / master branches - it looks like we need to be careful and tidy up your commits on your branch, to avoid putting duplicate commits in the history.
We want to have your SAN-74 commits just in this PR. So you will probably have to end up creating a new branch so you don't lose your commits, then cherry-pick the commits of a new branch taken from master.
Then force-push your local to this remote branch.

New PR is created base on yesterday sanctions master branch merging
https://github.com/companieshouse/penalty-payment-web/pull/164


KAFKA-14535: Fix flaky EndToEndAuthorization tests which were sensitive to ACL change reordering

The ACL change methods (create, delete) are eventually consistent across a Kafka cluster. As part of that, changes to the same resource made to different brokers may be reordered. In this test, a delete operation initiated in noConsumeWithoutDescribeAclSetup was being reordered to an unexpected time later in the test, causing an expected ACL to be missing.
To fix this, add a wait condition that asserts that the delete operations initiated in noConsumeWithoutDescribeAclSetup are completely applied before returning from the method.
Note: test failures were present for both the ZK and KRAFT iterations of the test, but the ZK iteration encountered it much more often, and was used to diagnose the reordering.
This is a typo in the original implementation of this method in https://github.com/apache/kafka/pull/1908/files#diff-c38532e2fcf5cce4cf30a824bc6bef9953c05d9472db51c3778a0286f6f01296R311 . And was made worse when the CREATE acl was added but never deleted: https://github.com/apache/kafka/pull/4795/files#diff-c38532e2fcf5cce4cf30a824bc6bef9953c05d9472db51c3778a0286f6f01296R293-R308 .
This does not require a change to the ACL mechanisms, as I believe the reordering is an expected part of the consistency algorithm, which includes a CAS operation to ZK. This is also not a security risk, as this only affects successful ACL change operations, and should not allow unsuccessful ACL change operations to insert invalid ACLs.
Signed-off-by: Greg Harris<EMAIL_ADDRESS>Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

The last people working in this area were @pprovenzano @omkreddy and @soarez, if any of you have some time i'd appreciate a review on this test which flakes ~10-20% of the time. Thanks!

Test failures are unrelated, merging the PR


6 implement chord core api

the chord core api implementation reached a level that is capable of merging
make sure to back the logic up with some more tests, see #3


Determine what the output should be

The output will likely consist of a confidence score as to how confident the tool is that a given intelligence statement is valid.
This will summate all the possible methods of validation (such as semantic analysis, corroborating sources, and evaluating the sources used based on their reliability and credibility).
There will be some methods that can and cannot be used depending on the intelligence statement, and the sources given that were used in creating these statements.
Importantly the output should be a simple confidence score that is easy to read and should show some 'working' as to how the tool got to that conclusion.


PhantomJS Command Line Options

How do we go about passing command line options to phantomjs? For instance I need to pass the --ignore-ssl-errors=yes option. See this page to see what I'm talking about: http://phantomjs.org/api/command-line.html

Sorry, that's not yet possible. I'd accept pull requests.

Can I modify the source to accomplish this? If so where could I hard code in my additional parameters to the call to phantomjs?
From: Marc Bachmann<EMAIL_ADDRESS>Sent: Thursday, March 26, 2015 3:04 PM
To: marcbachmann/node-html-pdf
Cc: Charles Naccio
Subject: Re: [node-html-pdf] PhantomJS Command Line Options (#22)
Sorry, that's not yet possible. I'd accept pull requests.
—
Reply to this email directly or view it on GitHub https://github.com/marcbachmann/node-html-pdf/issues/22#issuecomment-86692918 .  https://github.com/notifications/beacon/AHq1N3Dt_9Bm6Nh1A-qXmeToX4RcdXnqks5n5F3LgaJpZM4DyUSz.gif

https://github.com/marcbachmann/node-html-pdf/blob/master/src/pdf.coffee#L72
You can edit this file & run npm test once. By running npm test it creates all the js files out of the coffee-script source.

I've added that in the newest version