Feature Req.: Is it possible to show indent-line for the filetree?

As title. Just like the one nvim-tree.lua did.

Not related to the title: I also expect a way to customize the folder icon, please 🥺

This is a duplicate of #44 which is in progress.
The folder icon can be customized, see the help file at :h Neo-tree-Configuration
You just need to specify a custom renderer for directory:
 ...
  filesystem = {
    renderers = {
      directory = {
        {
          "icon",
          folder_closed = "",
          folder_open = "",
          padding = " ",
        },
        { "current_filter" },
        { "name" },
        {
          "clipboard",
          highlight = "NeoTreeDimText"
        },
        { "diagnostics", errors_only = true },
        --{ "git_status" },
      },
  ...

@cseickel: I will expect that I don't need to provide fields I don't want to customize. But without the { 'name' } option, the folder name did not get shown.

That wouldn't really make sense because it's not just about the configuration, it's just as much about which components you are using and in what order. I can't assume that you want the built-in name component if you didn't specify it. What if you created a custom name component and wanted to use that instead? What if you want other components in between icon and name? The only way this makes sense is if you specify the complete line to be rendered.
A lot of design decisions here take the side of "what is the most open ended and flexible" over what is the shortest path to one specific change.

@cseickel: Okay, then I hope the length of code needed to just change the icons can be shortened in version 2.x!


Re-enable list-DLC-channels endpoint on coordinator

We cannot query the endpoint at the moment. The server automatically reports a 404.

bors r+


Fix tests

There were previously two methods called test_create_project_with_invalid_name and one of the VCR fixtures was missing. This PR fixes that.

/cc @dterror

:ship:


feat: add context menu

Hi team,
is it planned to add a right click context menu ?
Thank you

To what? Menu? => https://fluentui-blazor.net/Menu#simplecontextmenu

Yes, as Vincent said, you can do that using Trigger="MouseButton.Right"
<FluentMenu Anchor="myId4" Trigger="MouseButton.Right" ... />


74 set up a site

Closes #74
Rendered: https://deemp.github.io/normalizer/

PR-Codex overview
Focus of this PR:
This PR focuses on adding documentation and improving the website design for the phi-normalizer project.
Detailed summary:

Added README.md file
Added .gitignore file for the docs folder
Updated SUMMARY.md file in the docs/src folder
Added index.html file for redirecting to the docs folder
Updated book.toml file with author, language, and output settings
Updated ghc.yml file for building and deploying the site
Added pagetoc.css and pagetoc.js files for customizing the website theme
Updated index.hbs file for customizing the website layout and theme

The following files were skipped due to too many changes: site/docs/theme/index.hbs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@fizruk, what files layout on the gh-pages branch should be optimal?


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1283

Questions ?
Please refer to the Backport tool documentation


Fix Archive macro for enums whos variants clash with associated types

This disambiguates associated types in the Archive derive macro for enums so that the macro no longer errors for variants called Archived or Resolver, e.g.
#[derive(Archive)]
struct MyEnum {
    Archived,
    Resolver { field: u32 },
}

Thanks for the PR!


MAISTRA-1192 & MAISTRA-1193 Add mutating webhooks for SMMR and SMCP

Looks good.
I'm assuming removing the code that e.g. removes the control plane namespaces from memberrolls in the controller will come with a later PR?

Yes. We can do that later when we also remove the if statements that skip the control plane namespace.


Rss feed widget

resolves #51 and resolves 38

This change is

Reviewed 26 of 26 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Unable to convert valid json

My json which is asserted valid by jsonlint.com:
<EMAIL_ADDRESS>\u003cct87ugz5@linshiyouxiang.net\u003e"],"subject":"Alstroemeria Record","date":"2019-05-12T14:19:33+08:00","size":1527,"seen":false}]

Error:
TypeError: Instance of 'JSArray': type 'JSArray' is not a subtype of type 'Map<String, dynamic>'

It seems that the issue is caused by the root element being an array, if I try the following it works
<EMAIL_ADDRESS>\u003cct87ugz5@linshiyouxiang.net\u003e"],"subject":"Alstroemeria Record","date":"2019-05-12T14:19:33+08:00","size":1527,"seen":false}

You'll need to write the parser for the array by hand or provide a wrapper object in the json to extract the array parser like this:
<EMAIL_ADDRESS>\u003cct87ugz5@linshiyouxiang.net\u003e"],"subject":"Alstroemeria Record","date":"2019-05-12T14:19:33+08:00","size":1527,"seen":false}]}

I'm currently working on a much better version that will print warnings and try to solve other conflicts. This example really helps me towards my goal.
Thanks for your feedback

I'm having this issue as well with and without the root element being an array and I get an error as well. Unable to parse. I validated the json and it validates successfully.
{
        "meta": {
            "id": "voluminous",
            "uuid": "0d01b967-971f-4ec5-8fe0-10513d29c39b",
            "sort": "220130400",
            "src": "collegiate",
            "section": "alpha",
            "stems": [
                "voluminous",
                "voluminously",
                "voluminousness",
                "voluminousnesses"
            ],
            "offensive": false
        },
        "hwi": {
            "hw": "vo*lu*mi*nous",
            "prs": [
                {
                    "mw": "və-ˈlü-mə-nəs",
                    "sound": {
                        "audio": "volumi02",
                        "ref": "c",
                        "stat": "1"
                    }
                }
            ]
        },
        "fl": "adjective",
        "def": [
            {
                "sseq": [
                    [
                        [
                            "sense",
                            {
                                "sn": "1 a",
                                "dt": [
                                    [
                                        "text",
                                        "{bc}having or marked by great {a_link|volume} or bulk {bc}{sx|large||} "
                                    ],
                                    [
                                        "vis",
                                        [
                                            {
                                                "t": "long {wi}voluminous{/wi} tresses"
                                            }
                                        ]
                                    ]
                                ],
                                "sdsense": {
                                    "sd": "also",
                                    "dt": [
                                        [
                                            "text",
                                            "{bc}{sx|full||} "
                                        ],
                                        [
                                            "vis",
                                            [
                                                {
                                                    "t": "a {wi}voluminous{/wi} skirt"
                                                }
                                            ]
                                        ]
                                    ]
                                }
                            }
                        ],
                        [
                            "sense",
                            {
                                "sn": "b",
                                "dt": [
                                    [
                                        "text",
                                        "{bc}{sx|numerous||} "
                                    ],
                                    [
                                        "vis",
                                        [
                                            {
                                                "t": "trying to keep track of {wi}voluminous{/wi} slips of paper"
                                            }
                                        ]
                                    ]
                                ]
                            }
                        ]
                    ],
                    [
                        [
                            "sense",
                            {
                                "sn": "2 a",
                                "dt": [
                                    [
                                        "text",
                                        "{bc}filling or capable of filling a large volume or several {a_link|volumes} "
                                    ],
                                    [
                                        "vis",
                                        [
                                            {
                                                "t": "a {wi}voluminous{/wi} literature on the subject"
                                            }
                                        ]
                                    ]
                                ]
                            }
                        ],
                        [
                            "sense",
                            {
                                "sn": "b",
                                "dt": [
                                    [
                                        "text",
                                        "{bc}writing or speaking much or at great length "
                                    ],
                                    [
                                        "vis",
                                        [
                                            {
                                                "t": "a {wi}voluminous{/wi} correspondent"
                                            }
                                        ]
                                    ]
                                ]
                            }
                        ]
                    ],
                    [
                        [
                            "sense",
                            {
                                "sn": "3",
                                "dt": [
                                    [
                                        "text",
                                        "{bc}consisting of many folds, coils, or convolutions {bc}{sx|winding|winding:2|}"
                                    ]
                                ]
                            }
                        ]
                    ]
                ]
            }
        ],
        "uros": [
            {
                "ure": "vo*lu*mi*nous*ly",
                "fl": "adverb"
            },
            {
                "ure": "vo*lu*mi*nous*ness",
                "fl": "noun"
            }
        ],
        "et": [
            [
                "text",
                "Late Latin {it}voluminosus{/it}, from Latin {it}volumin-, volumen{/it}"
            ]
        ],
        "date": "1611{ds||3||}",
        "shortdef": [
            "having or marked by great volume or bulk : large; also : full",
            "numerous",
            "filling or capable of filling a large volume or several volumes"
        ]
    }

fixed


[ENH] Add an option of creating a sub-folder in outputs to zip

Currently BABS assumes that the output folders listed under zip_foldernames will be created by BIDS Apps. However, this is not always be created by BIDS Apps, e.g., fMRIPrep latest BIDS output layout, and there are files not in a named folder. Therefore, in this PR, we give users an option to ask BABS to create a sub-folder to zip.

TODO:

[ ] test the code itself under different zip_foldernames:

[x] placeholder + one foldername to create
[ ] folder name first, placeholder (of creating additional output folder) latter
[ ] placeholder + two or more folders -> expect error

[ ] test w/ different use cases:

[x] fmriprep-fake --anat-only (output foldername: fmriprep_anat) --> toybidsapp, using toy data (multi-ses)
[ ] fMRIPrep 23.1.3 --anat-only --> fMRIPrep 23.1.3 w/ FreeSurfer ingressed, using real data (single-ses)

[ ] update docs

In this PR, I enhanced BABS so that it can work on BIDS Apps whose derivative files are not in a wrapper folder (e.g., fMRIPrep BIDS output layout). Users now have an option to ask BABS to create a wrapper folder to wrap all derivative files, and BABS will direct zip this wrapper folder. For more, please see the updated docs: zip_foldernames section.
I've enhanced the code, docs, and tested on a few use cases (see above).


Compatibility with .NET Core 2.0

This happens when we try to build a .NET Core 2.0 App (regardless if we use VS2017 15.3 Template or type "dotnet new mvc") on a fresh installed machine:
Restoring packages for D:\TestProject\TestProject.csproj...
Restore completed in 56,69 ms for D:\TestProject\TestProject.csproj.
D:\TestProject\TestProject.csproj : error NU1202: Package Microsoft.ApplicationInsights.AspNetCore 2.1.1 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.ApplicationInsights.AspNetCore 2.1.1 supports:
D:\TestProject\TestProject.csproj : error NU1202:   - net451 (.NETFramework,Version=v4.5.1)
D:\TestProject\TestProject.csproj : error NU1202:   - netstandard1.6 (.NETStandard,Version=v1.6)
D:\TestProject\TestProject.csproj : error NU1202: Package Microsoft.ApplicationInsights.DependencyCollector 2.4.1 is not compatible with netcoreapp2.0 (.NETCoreApp,Version=v2.0). Package Microsoft.ApplicationInsights.DependencyCollector 2.4.1 supports:
D:\TestProject\TestProject.csproj : error NU1202:   - net40 (.NETFramework,Version=v4.0)
D:\TestProject\TestProject.csproj : error NU1202:   - net45 (.NETFramework,Version=v4.5)
D:\TestProject\TestProject.csproj : error NU1202:   - netstandard1.6 (.NETStandard,Version=v1.6)
Generating MSBuild file D:\TestProject\obj\TestProject.csproj.nuget.g.props.
Generating MSBuild file D:\TestProject\obj\TestProject.csproj.nuget.g.targets.
Restore failed in 2,78 sec for D:\TestProject\TestProject.csproj.

Can you confirm you have core 2.0 installed in the machine?

Yes.
Fresh Windows 10 with Creators Update.
Fresh VS 2017 15.3.2 Community Install.
Fresh .Net Core 2.0 SDK 64 Bit Install.
Reboot.
File - New Project - .Net Core 2.0 - Web Application (MVC)
F5
This error.
Same thing with

VS Professional
"dotnet new mvc"
On Virtual Machine

It seems the 2 Packages are only built against .Net Standard 1.6. Standard 2.0 should include this, but it seems for some reason this dont work here.
Strange thing is: In the .net 2.0 store (for the meta package system - c:\programfiles\dotnet\store) there are other packages with even standard 1.4 dependencies. But they are OK. I have no clue what is special with the 2 ApplicationInsights Packages above.
But its the same on 7 Computers in our Company. So...

If that helps i can send screenshots. Or logs etc.
I have also opened it here:
https://github.com/dotnet/core/issues/887

Any news here ? I dont get that obviously nobody ever tested this. Just take a fresh Windows 10 Machine, Install latest VS 2017 (15.3.2), Install .net core 2.0 SDK (and maybe Runtime too). Now make some "dotnet new mvc" or use default template in VS and you get above error. Its really easy to reproduce.
Sorry, i am a .net dev since nearly 15 years.  There are easier ways to force ppl to node.js or other technologies instead asp.net core.  Issue closed.". Thats hillarious. We described the problem exactly. I think they even didnt read it or even tested it.
 We WANT to use .net core 2.0. But we dont get even the default project compiled, because of above error. And it seems nobody cares. Thats very dissapointing.

7h after my issue was closed (with a hillarious answer) by MS, they "magically" released 15.3.3. Which fixes that problem (Release Notes show a slightly another problem, but obviously it also do some fix with my problem).

Or in short: Now that they released 15.3.3 you can close this issue. Thx anyway.

Bill Hiebert [MSFT] wrote on Visual Studio Developer Community:
"I apologize for this issue being closed without comments. Your issue sounds a lot like the one described here: https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/521
According to that post the issue was fixed in 15.3.3. Can you update to that version and confirm?
Again, apologies for this being closed without confirmation that your issue has been fixed.
Thanks."
This is the Microsoft i know.
I wrote this here, to also inform in this issue here, that indeed the 15.3.3 VS Update solved the problem entirely. Directly after installing it, the error no longer existed.

Is this way MS do it.


Improve readability of documentation and code

Fixes a few incorrectly stated data types
Limits line length of documentation to 80 characters for better readability
Breaks up prop/value into 2 lines to improve code legibility for future maintenance

:+1:


SRE-1942 Backport delete_on_termination attribute

We can't upgrade to a newer AWS cookbook because it depends on a newer version of the ohai cookbook than we're willing to upgrade to right now (because our nginx cookbook requires an old ohai), but we want to be able to mark EBS volumes to terminate with their associated instances. This backports the :delete_on_termination attribute from v4.1.1 of the AWS cookbook to our v2.7.2 fork.

(note that this is a PR against the ebs_fix branch which is what we're using in Chef's Berksfile.)


change implementation of edit item, add convenient way to modify quantity

resolves #54, resolves #67

Codecov Report

Merging #68 into master will increase coverage by 0.38%.
The diff coverage is 86.88%.

@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     67.62%   68.00%   +0.38%
- Complexity      657      673      +16
============================================
  Files           110      112       +2
  Lines          2091     2138      +47
  Branches        226      233       +7
============================================
+ Hits           1414     1454      +40
- Misses          593      597       +4
- Partials         84       87       +3

Impacted Files
Coverage Δ
Complexity Δ

...eedu/address/logic/commands/DeleteItemCommand.java
76.92% <ø> (ø)
10.00 <0.00> (ø)

...va/seedu/address/logic/parser/InventoryParser.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../seedu/address/logic/commands/EditItemCommand.java
83.09% <81.81%> (-0.73%)
15.00 <3.00> (+1.00)
:arrow_down:

...s/logic/parser/AddQuantityToItemCommandParser.java
81.81% <81.81%> (ø)
3.00 <3.00> (?)

...dress/logic/commands/AddQuantityToItemCommand.java
90.00% <90.00%> (ø)
10.00 <10.00> (?)

...ain/java/seedu/address/logic/parser/CliSyntax.java
90.90% <100.00%> (+0.90%)
1.00 <1.00> (ø)

...du/address/logic/parser/EditItemCommandParser.java
58.82% <100.00%> (-2.29%)
3.00 <0.00> (+1.00)
:arrow_down:

...ava/seedu/address/logic/parser/ItemParserUtil.java
94.73% <100.00%> (+0.61%)
9.00 <1.00> (+1.00)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a14ea...20a88b8. Read the comment docs.


Cant acces server from anywhere but pc its running on

I've successfully created server which works perfectly fine on localhost until i try to connect to it from any other computer in network...
static void Main(string[] args)
        {
            Server server = new Server(_hostname, _port, false, DefaultRoute);
            Database database = new Database();

            server.AccessControl.Mode = AccessControlMode.DefaultPermit;

            for (; ; )
            {
                switch (Console.ReadLine())
                {
                    default:

                        break;
                    case "exit":
                        return;
                }
            }
        }

public static async Task DefaultRoute(HttpContext context)
        {
                context.Response.StatusCode = 200;
                await context.Response.Send("Succesful Request");
                return;
        }

Database class does communication with mysql database stuff..
I've created exception in firewall and i've tried running program with admin privileges..

Hi @maetiskou on which hostname and which port number are you listening?  Are you using an IP address or a hostname for _hostname?  When trying to connect from a client, are you using the IP address or hostname?  There has to be an explicit match between what you have for hostname and what comes in on the request (this is a restriction in the underlying http.sys).
Administrator is required if you use a port number under 1024, or, if you use * or + as the hostname, which will route any request on any DNS hostname/IP address to this instance (also making it a helpful debugging tool).
Could you try with * or + as the hostname in your constructor?
Thanks, Joel

Hi @maetiskou did this help you?  Cheers

Please reopen if the issue persists after trying the above.

Hi @jchristn i've tried all of the above before as i've seen it in other issues and nothing worked for me.
Nonetheless i am using .Net HttpListener instead as it was just enough to suit my needs..
Problem was for sure somewhere in my network or router settings anyway... But thanks for the help.


feat: first prototype of jsonable abstract cls

First pass at fixing #101
What has been done:

Abstract class implemented (https://github.com/FZJ-INM1-BDA/siibra-python/blob/feat_jsonableEncoders/siibra/core/concept.py#L265-L279)
Extraction mechanism implemented (https://github.com/FZJ-INM1-BDA/siibra-python/blob/feat_jsonableEncoders/siibra/core/json_encoder.py)
Tests for extraction mechanism implemented (https://github.com/FZJ-INM1-BDA/siibra-python/blob/feat_jsonableEncoders/test/core/test_json_encoder.py)
A number of simple implementation:

parcellation: (https://github.com/FZJ-INM1-BDA/siibra-python/blob/d529fa9b2d28aa97c79c05488ac8188cfd8069bf/siibra/core/parcellation.py#L444-L459)
region (https://github.com/FZJ-INM1-BDA/siibra-python/blob/d529fa9b2d28aa97c79c05488ac8188cfd8069bf/siibra/core/region.py#L820-L842)
space (https://github.com/FZJ-INM1-BDA/siibra-python/blob/d529fa9b2d28aa97c79c05488ac8188cfd8069bf/siibra/core/space.py#L135-L146)
point (https://github.com/FZJ-INM1-BDA/siibra-python/blob/d529fa9b2d28aa97c79c05488ac8188cfd8069bf/siibra/core/space.py#L533-L546) (bonus point for being sands comforting)

example notebook (https://github.com/FZJ-INM1-BDA/siibra-python/blob/d529fa9b2d28aa97c79c05488ac8188cfd8069bf/examples/JSONables.ipynb)

Codecov Report

Merging #105 (27b94b1) into main (d1260a0) will increase coverage by 16.83%.
The diff coverage is 93.11%.

@@             Coverage Diff             @@
##             main     #105       +/-   ##
===========================================
+ Coverage   50.14%   66.98%   +16.83%
===========================================
  Files          27       29        +2
  Lines        3037     3383      +346
===========================================
+ Hits         1523     2266      +743
+ Misses       1514     1117      -397

Impacted Files
Coverage Δ

siibra/core/jsonable.py
78.26% <78.26%> (ø)

siibra/volumes/volume.py
66.54% <88.88%> (+24.67%)
:arrow_up:

siibra/core/json_encoder.py
92.53% <92.53%> (ø)

siibra/features/receptors.py
72.72% <93.18%> (+8.17%)
:arrow_up:

siibra/core/region.py
74.82% <93.54%> (+22.88%)
:arrow_up:

siibra/features/ieeg.py
84.30% <93.75%> (+55.95%)
:arrow_up:

siibra/core/datasets.py
90.72% <94.73%> (+17.30%)
:arrow_up:

siibra/features/connectivity.py
94.85% <94.87%> (+3.94%)
:arrow_up:

siibra/core/space.py
51.11% <95.12%> (+20.58%)
:arrow_up:

siibra/core/parcellation.py
70.98% <95.45%> (+9.49%)
:arrow_up:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1260a0...27b94b1. Read the comment docs.

@dickscheid
I think you removed a comment, somehow?
I was taking a look at a alternatives, how do you think of the following:
# in parcellation.py

from pydantic import BaseModel

class ParcellationSerializationSchema(BaseModel):
  id: str
  name: str
  # other attributes

class Parcellation(
    AtlasConcept,
    SiibraSerializable,
):
  # ...
  def to_json(self) -> ParcellationSerializationSchema:
    # complex logic
    return {
       'id': 'foo-bar',
       'name': 'hello world'
    }

@dickscheid
I think you removed a comment, somehow?
I was taking a look at a alternatives, how do you think of the following:

See my review. I would be motivated to be more rigorous, getting rid of the separate models and making our core classes the models. When reading the pydantic documentation, my feeling is that this is the intended way. I admit it might cause more work now to review definitions of class members, but my feeling is that it is the cleaner solution. Then, if done right, I also think that pydantic's model.json() function will provide us the explicit to_json() construct then - with some optimism that the circular dependencies can be handeld in a clever way.

I just saw this: https://pydantic-docs.helpmanual.io/usage/exporting_models/#advanced-include-and-exclude
Maybe along these lines, it will become possible to introduce what I suggest above incrementally?

I just saw this: https://pydantic-docs.helpmanual.io/usage/exporting_models/#advanced-include-and-exclude Maybe along these lines, it will become possible to introduce what I suggest above incrementally?

Please see https://github.com/FZJ-INM1-BDA/siibra-python/pull/105#discussion_r748768121 and https://github.com/FZJ-INM1-BDA/siibra-python/pull/105#discussion_r748768749
I think not only would the attempt for siiibraserizable to subclass basemodel require a substantial rewrite, we will have to patch basemodel's to_json call, when the situation demands.

Ideally, I would vote in favour of move all classes in siibra-python to subclass BaseModel.
But I want to believe that the current model is a nice compromise, especially we might need a rewrite when we move from gitlab repo to openminds.

I just saw this: https://pydantic-docs.helpmanual.io/usage/exporting_models/#advanced-include-and-exclude Maybe along these lines, it will become possible to introduce what I suggest above incrementally?

Please see #105 (comment) and #105 (comment)
I think not only would the attempt for siiibraserizable to subclass basemodel require a substantial rewrite, we will have to patch basemodel's to_json call, when the situation demands.

It seems to me that the model.json() can be quite flexibly influenced using pydantic's Config, where json encoder functions could be stored. I do not yet understand all it can do though.

especially we might need a rewrite when we move from gitlab repo to openminds.

That is true. In fact, we can start to move to openminds now. We should discuss the PR in this context the next days.

@xgui3783 Is this independent from the pull request to "Refactor/pydantic".
I was kind of thinking they are related and have therefore not yet merged it

@xgui3783 Is this independent from the pull request to "Refactor/pydantic". I was kind of thinking they are related and have therefore not yet merged it

correct. This PR will be superceded by #143


bump deps

Signed-off-by: Joe Grund<EMAIL_ADDRESS>

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   94.98%   94.98%
=======================================
  Files         291      291
  Lines        3867     3867
  Branches      462      462
=======================================
  Hits         3673     3673
  Misses        173      173
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869b42a...b80cd1f. Read the comment docs.


No get_sequences function

Hi,
There is the line like this in the notebook:
from utils import get_model, find_closest, get_sequences, create_train_valid,  generate_output, guess_human
but get_sequences is not defined. Can you fix it?
Regards,
K.

I'm sorry, which notebook are you referring to?

I'm going to close this issue as there has been no activity. I would welcome a pull request that addressed the issue though! 😄

hi,
i have also faced same issue.
in https://github.com/WillKoehrsen/recurrent-neural-networks/blob/master/notebooks/Exploring Model Results.ipynb
how can i fix it?


Update icons to be themeable

In order to fix https://github.com/jenkinsci/custom-folder-icon-plugin/issues/93 I went over most of the icons and added missing fill="currentColor" attributes if they were missing. I might have become snow-blind doing this so sorry if I missed something.
Here is a preview of the icons in white and dark theme:

I was unsure whether to create this PR here or directly in https://github.com/ionic-team/ionicons - let me know what works best for you.

I was unsure whether to create this PR here or directly in ionic-team/ionicons - let me know what works best for you.

Ideally both, they haven't been very responsive to pull requests though, but would be good to at least submit it there.
Thanks for the change!

Ideally both, they haven't been very responsive to pull requests though, but would be good to at least submit it there.

Historically, I submitted all fixes to ionicons we addressed in core, but none of them received feedback by now, that would allow us to get further with it.
I'm fine with fixing issues here, and potentially adding more symbols 👍🏻

I'm fine with fixing issues here, and potentially adding more symbols 👍🏻

I'm unsure about new ones being in here, if we want some custom specific ones they should go in the plugin related to them.
If they're reusable there could be a shared one.

if we want some custom specific ones they should go in the plugin related to them

Agreed. The Jenkins icon I added is a general purpose symbol, but generally I don't think we need to add any symbol, unless they directly relate to this project.


fix callback bugs

the return type is configurable
avoid useless copying

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.00%. Comparing base (44a4cde) to head (d93d010).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   90.00%   90.00%
=======================================
  Files           6        6
  Lines          40       40
  Branches        3        3
=======================================
  Hits           36       36
  Misses          4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
17 seconds
inspect-image

✅ Succeeded
18 seconds
deprecated-base-image-check

✅ Succeeded
21 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
17 seconds
optional-label-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
17 seconds
inspect-image

✅ Succeeded
18 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
21 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
17 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary


umzug.up() not working with sequelize 5

I have a project that is using umzug for migrations. Everything is 🍑y with sequelize 4.42.x, but when I upgrade to version 5.3.1, I'm now getting the error
{ SequelizeConnectionAcquireTimeoutError: Operation timeout
    at pool.acquire.catch.err (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/sequelize/lib/dialects/abstract/connection-manager.js:281:53)
    at tryCatcher (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/util.js:16:23)
    at /Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/catch_filter.js:17:41
    at tryCatcher (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/promise.js:690:18)
    at _drainQueueStep (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/async.js:138:12)
    at _drainQueue (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/async.js:131:9)
    at Async._drainQueues (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/async.js:147:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:705:18)
    at tryOnImmediate (timers.js:676:5)
    at processImmediate (timers.js:658:5)
  name: 'SequelizeConnectionAcquireTimeoutError',
  parent:
   TimeoutError: Operation timeout
       at Timeout._timeout.setTimeout (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/sequelize-pool/lib/Deferred.js:19:19)
       at ontimeout (timers.js:436:11)
       at tryOnTimeout (timers.js:300:5)
       at listOnTimeout (timers.js:263:5)
       at Timer.processTimers (timers.js:223:10),
  original:
   TimeoutError: Operation timeout
       at Timeout._timeout.setTimeout (/Users/tomcaflisch/Sites/ciitizen/ciitizen-profile-service/node_modules/sequelize-pool/lib/Deferred.js:19:19)
       at ontimeout (timers.js:436:11)
       at tryOnTimeout (timers.js:300:5)
       at listOnTimeout (timers.js:263:5)
       at Timer.processTimers (timers.js:223:10) }

Here's my code:
// db is an instance of sequelize
async function runMigrations (db) {
  const cfg = {
    storage: 'sequelize',
    storageOptions: {
      sequelize: db
    },

    // see: https://github.com/sequelize/umzug/issues/17
    migrations: {
      params: [
        db.getQueryInterface(), // queryInterface
        db.constructor, // DataTypes
        function () {
          throw new Error('Migration tried to use old style "done" callback. Please upgrade to "umzug" and return a promise instead.')
        }
      ],
      path: path.join(__dirname, 'migrations'),
      pattern: /\.js$/
    }
  }
  const umzug = new Umzug(cfg)
  return umzug.up()
}

Any ideas why? Is there anything I need to change as part of the sequelize 4 -> 5 upgrade?

I'm using sequelize and postgres and got the same problem but in my case it didn't timeout, it just went on and on.

Got fixed for me on latest version: 5.8.12


[Question]

so first of all ur base is amazing, keep going!
im just wondering am i doing something wrong or its something wrong with the SendNetMsg hook
i used the method of doing Force Spectator Mode mentioned by Flaww
https://www.unknowncheats.me/forum/counterstrike-global-offensive/383464-spectate-own-mm-game-live.html
i had to add NET_StringCmd class because i was not able to find this in the base.
// @credits: Flaww
if (pMessage->GetType() == INetChannelInfo::STRINGCMD && C::Get<bool>(Vars.bMiscForceSpectatorExploit))
{
	auto cmd = reinterpret_cast<NET_StringCmd*>(pMessage);

	if (strstr(cmd->m_szCommand, "joingame"))
		return true;
}

is something wrong with this code?

debug, check does it passing, log which type message there's used

aight looks like it is something wrong with the NET_StringCmd class

u can do this other way by clientstate


Couldn't able to install StereoKit templates

Hello!
I just started with StereoKit, Through Guides and the on demand videos I installed visual code and added .NET desktop development and UWP payloads, then I downloaded the StereoKit templates from the marketplace but got an error stating
This extension is not installable on any currently installed products
I think its due to the fact that I installed visual studio 2022.
So will my apps work fine if I do it through the Nuget package?

If you set the project up manually with the NuGet package, it'll work just fine! The VS 2022 release snuck up on me, so yeah, the templates are unfortunately still set up for 2019 :)

Okay got it,
Thanks @maluoi

I just updated the templates to work with VS 2022! If you try it out, I'd love to hear if they work for you :)

I will close this now, as it's been working well for me so far. If you encounter issues with the 2022 templates later on, please let me know :)

Hi @maluoi !
Sorry for replying late, I have installed StereoKit templates and it works pretty fine, I have one question why the .NET core runtime default to 3.1.0

3.1 is the oldest version of .Net Core that's still in support, the templates kinda use it for broader compatibility? It's somewhat arbitrary. StereoKit works perfectly well with newer versions of .Net Core as well, so feel free to update it to a newer version!

Hello,
I downloaded the SK templates and created a new project using the UWP template. I tried building it but I can't seem to get rid of the errors. I am using visual studio 2022.


Fail to unmount Command Line Tools.dmg after installation

Describe the bug
At the end of CLI installation, the command fails to unmount the DMG file
To Reproduce
install CLI
Expected behavior
no error
2022-12-05T12:25:07+0100 error xcodeinstall : [xcodeinstall] Can not unmount volume : file:///Volumes/Command%20Line%20Developer%20Tools/
Optional(CLIlib.ShellOutput(out: Optional(""), err: Optional("hdiutil: unmount: \"file:///Volumes/Command%20Line%20Developer%20Tools/\" failed to unmount due to error 2.\nhdiutil: unmount failed - No such file or directory\n"), code: 1))
🛑 Error while installing file:///Users/stormacq/.xcodeinstall/download/Command%20Line%20Tools%20for%20Xcode%2014.1.dmg

The %20 are added by URL class and should be remove when passing path to command line shell

Fixed by https://github.com/sebsto/xcodeinstall/commit/094d270c8dfb4cd11dc244e6ae8ee7b64693dfc5


404 - Page not found

I tried with Pycharm
Visual Studio Code
venv
pipenv
I read all the instructions and repeated the installation 4-5 times, all day today
`
Using the URLconf defined in django_debug_toolbar.urls, Django tried these URL patterns, in this order:
admin/
__debug__/

The empty path didn’t match any of these.
`
I tried with Django 4, 3, 2

Hi @xavierbaez
A screenshot would be helpful.
Maybe you have to visit /admin/ or some other route which actually returns a valid response?

I'm closing this for now. If you're still encountering an error, please include the full error and stacktrace.


Minor: torchtyping not listed as dependency

In order to run ns-install-cli in a clean conda environment, I had to manually pip install torchtyping. Seems like this should be a dependency.

Yeah. I meet that problem too.

Fixed, #42


added urn for netcam so it finds NetCam camera

I have a Belkin NetCam HD+ that this library was not finding. Adding the urn with "nectam" in it means that it finds it now.
Thanks.

Hi. What do you think about merging in this PR?


Regarding fine-tune step for k_shot in Meta-cross work

in your code for k_shot experiments,  which fine-step results should be reported? Either the last step or maximum among the steps?

in your code for k_shot experiments, which fine-step results should be reported? Either the last step or maximum among the steps?

Hi, sorry for the late reply...
For all k-shot experiments, we take the k-shot examples to fine-tune the meta-trained model by 10 steps, then evaluate the fine-tuned model with the target-language test set.

Thanks for your reply,
Can we also fine-tune the meta-trained model of a validation dataset with-shot example? then evaluate it on the target dataset on the highest validation value steps? is it also right approach?


Feature/128 add html handler

closes #128

@ctmm can you please rebase this PR after merging #145 #146

@timomayer @SheepFromHeaven, I have updated this branch to reflect the latest changes on master. Ready for review.

@tiagomapmarques I addressed all of your comments, updating the code for small changes. For these small changes I took the liberty of marking the conversation as resolved.
All remarks you made that are open for discussion I left open.
Kindly ask you to get back at me for the open topics.
Thank you!


Assert CLI using a builder instead of complex macro

Have a look at the new Readme:

Here's a trivial example:
extern crate assert_cli;

fn main() {
    assert_cli::Assert::command(&["echo", "42"]).prints("42").unwrap();
}

[…]
And here is one that will fail (which also shows execute which returns a
Result and can be used instead of unwrap):
#[macro_use] extern crate assert_cli;

fn main() {
    let test = assert_cmd!(grep amet Cargo.toml)
        .fails_with(1)
        .execute();
    assert!(test.is_err());
}

To everyone who seems to use this or has commented on this repo (cc @johannhof @Lindenk), as well as @colin-kiegel, who I consider an expert in builder pattern APIs: What do you think of this?

Additionally:
Fixes #8
Fixes #9

Alright! I'm pretty happy with this! :shipit:

This sounds very interesting! :-)
Sorry for not reacting so far - do you still want me to take a look and comment?

@colin-kiegel sure, I'd love that! I ended up implementing a pretty fluent API for the cli tests in https://github.com/killercup/waltz/ as well (they use this crate internally).


Update jscs

This PR updates the jscs.json file to a later config from angular.
The first commit also runs the fixes on js/angular.
I did a separate commit to run jscs on the rest of the js/ files. Not sure if that is desired?
It removes "excludeFiles": ["src/ngLocale/**"], since that isn't needed.
Also, I didn't add the "disallowKeywordsOnNewLine": ["else"], since there are comments between if and else.
Maybe we should add another rule for whitespace in parens?
I see some if( (len = itemsEntering.length) ) { or if ( ionic.keyboard.height ) {
I'm using the to-be-released autofixing feature in jscs (in master). Right now it works for mostly white space changes. It was able to get 406/408 errors in the rest of the js/ folder.

Thanks, but we update jscs changes over times so there isn't large commits, which make it difficult to merge branches down the road.

Ah ok. Well in 0.12 it will be a lot easier to fix a lot of the issues with the autofix option!


schematics/update: SELECT_PANEL_MAX_HEIGHT was not found in '@angular/material/select after migration

after updating the angular project with angular material from version 11 to 12 I encountered this error during the build and also when the project was launched

Angular: 12
AngularJS Material: 12

Error: ./node_modules/ngx-mat-select-search/ivy_ngcc/fesm2015/ngx-mat-select-search.js 558:55-78
"export 'SELECT_PANEL_MAX_HEIGHT' was not found in '@angular/material/select'
Error: ./node_modules/ngx-mat-select-search/ivy_ngcc/fesm2015/ngx-mat-select-search.js 565:23-46
"export 'SELECT_PANEL_MAX_HEIGHT' was not found in '@angular/material/select'

This issue is fixed in https://github.com/bithost-gmbh/ngx-mat-select-search/issues/321 as part of ngx-mat-select-search which is a third party component not supported by the Angular Components team.


Provide a way to indicate the a HG instance is ready

Right now it's kind of tricky to find out if a HG instance is ready, i.e., if it is mounted and the view config is loaded, etc. We should have a way to inform the user that HG is ready.
Interface-wise it could be:
hgApi.on('ready', callback);

Internally we could either use callbacks or promises (I would prefer the latter because they are easier to deal with).
The biggest question is when do we say an instance is ready?

I'm not sure what the answer is, but generally callbacks or promises for this and other API calls (like zoomTo would be great.
For example, for a demo of a track viewer, I was trying to set up an "animation"-style loop, where on each "tick", a view's absolute coordinates would be incremented or decremented some percentage of the maximum absolute bounds (with modulus-bounds to handle the edges), and then I would call hgApi.zoomTo(...) on the new bounds.
The animation was pretty jerky, I think, because I was sending calls before the view was ready to process them. The left edge of the view would redraw some amount of time before the right edge, for instance, which made the view look like it is redrawing in an "accordion"-like fashion. Or the view would simply not respond at all.
It would be great to be able to handle a queue of Promises, if there is some way to establish that a view is ready to be acted upon. Perhaps some sentinel, semaphore or flag that is set when an API call is made, which when set prevents other calls from starting, which is cleared or nulled when the original call completes?

At some point I thought about turning all JS API returns into promises as this would provide a clean interface for handling synchronous and asynchronous equally. A down side might be that it increases the complexity for simple endpoints (i.e., the synchronous ones). Also, if we do this it would break all existing endpoints. One way around might be to optionally turn on returning promises or to have a new API that has the same endpoints but only returns promises.
I've never really worked with it but even more complex event chains people seem to like RxJS


Crash with the Corpse

I play forge version 1.16.5 with optifine, and if I have a corpse mod, it crashes when I die.

Please also add the crash report to get an idea on what's happening

---- Minecraft Crash Report ----
// Don't be sad, have a hug! <3
Time: 17.09.21 22:11
Description: Rendering entity in world
java.lang.NullPointerException: Rendering entity in world
at net.minecraft.client.renderer.entity.PlayerRenderer.handler$zzm000$scale(PlayerRenderer.java:556) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.entity.PlayerRenderer.func_225620_a_(PlayerRenderer.java) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.entity.PlayerRenderer.func_225620_a_(PlayerRenderer.java:41) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.entity.LivingRenderer.func_225623_a_(LivingRenderer.java:137) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:LivingEntityRendererMixin,pl:mixin:A}
at net.minecraft.client.renderer.entity.PlayerRenderer.func_225623_a_(PlayerRenderer.java:64) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at de.maxhenkel.corpse.entities.CorpseRenderer.render(CorpseRenderer.java:64) ~[?:1.16.5-1.0.6] {re:classloading}
at de.maxhenkel.corpse.entities.CorpseRenderer.func_225623_a_(CorpseRenderer.java:19) ~[?:1.16.5-1.0.6] {re:classloading}
at net.minecraft.client.renderer.entity.EntityRendererManager.func_229084_a_(EntityRendererManager.java:311) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:EntityRendererMangerMixin,pl:mixin:A}
at net.minecraft.client.renderer.WorldRenderer.func_228418_a_(WorldRenderer.java:2124) ~[?:?] {re:mixin,re:classloading,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:WorldRendererMixin,pl:mixin:A}
at net.minecraft.client.renderer.WorldRenderer.func_228426_a_(WorldRenderer.java:1740) ~[?:?] {re:mixin,re:classloading,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:WorldRendererMixin,pl:mixin:A}
at net.minecraft.client.renderer.GameRenderer.func_228378_a_(GameRenderer.java:1022) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.client.renderer.GameRenderer.func_195458_a(GameRenderer.java:693) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:976) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) [?:?] {re:classloading,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51] {}
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.5-36.2.2.jar:36.2] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$456/1333945918.call(Unknown Source) [forge-1.16.5-36.2.2.jar:36.2] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {}
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Render thread
Stacktrace:
at net.minecraft.client.renderer.entity.PlayerRenderer.handler$zzm000$scale(PlayerRenderer.java:556) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.entity.PlayerRenderer.func_225620_a_(PlayerRenderer.java) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.entity.PlayerRenderer.func_225620_a_(PlayerRenderer.java:41) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at net.minecraft.client.renderer.entity.LivingRenderer.func_225623_a_(LivingRenderer.java:137) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:LivingEntityRendererMixin,pl:mixin:A}
at net.minecraft.client.renderer.entity.PlayerRenderer.func_225623_a_(PlayerRenderer.java:64) ~[?:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,xf:fml:forge:crossbows.2,pl:mixin:APP:firstpersonmod.forge.mixins.json:PlayerRendererMixin,pl:mixin:A,pl:runtimedistcleaner:A}
at de.maxhenkel.corpse.entities.CorpseRenderer.render(CorpseRenderer.java:64) ~[?:1.16.5-1.0.6] {re:classloading}
at de.maxhenkel.corpse.entities.CorpseRenderer.func_225623_a_(CorpseRenderer.java:19) ~[?:1.16.5-1.0.6] {re:classloading}
-- Entity being rendered --
Details:
Entity Type: corpse:corpse (de.maxhenkel.corpse.entities.CorpseEntity)
Entity ID: 1007
Entity Name: Труп
Entity's Exact location: 58.14, 68.00, -23.18
Entity's Block location: World: (58,68,-24), Chunk: (at 10,4,8 in 3,-2; contains blocks 48,0,-32 to 63,255,-17), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,0,-512 to 511,255,-1)
Entity's Momentum: 0.00, 0.00, 0.00
Entity's Passengers: []
Entity's Vehicle: ERROR NullPointerException: null
-- Renderer details --
Details:
Assigned renderer: de.maxhenkel.corpse.entities.CorpseRenderer@71d8794f
Location: 0.00,-1.62,0.00 - World: (0,-2,0), Chunk: (at 0,-1,0 in 0,0; contains blocks 0,0,0 to 15,255,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511)
Rotation: -122.34375
Delta: 0.47999436
Stacktrace:
at net.minecraft.client.renderer.entity.EntityRendererManager.func_229084_a_(EntityRendererManager.java:311) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:EntityRendererMangerMixin,pl:mixin:A}
at net.minecraft.client.renderer.WorldRenderer.func_228418_a_(WorldRenderer.java:2124) ~[?:?] {re:mixin,re:classloading,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:WorldRendererMixin,pl:mixin:A}
at net.minecraft.client.renderer.WorldRenderer.func_228426_a_(WorldRenderer.java:1740) ~[?:?] {re:mixin,re:classloading,xf:OptiFine:default,pl:mixin:APP:firstpersonmod.forge.mixins.json:WorldRendererMixin,pl:mixin:A}
at net.minecraft.client.renderer.GameRenderer.func_228378_a_(GameRenderer.java:1022) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
-- Affected level --
Details:
All players: 1 total; [ClientPlayerEntity['Jacque_Fresco_007'/329, l='ClientLevel', x=58.14, y=68.00, z=-23.18]]
Chunk stats: Client Chunk Cache: 441, 289
Level dimension: minecraft:overworld
Level spawn location: World: (32,69,-32), Chunk: (at 0,4,0 in 2,-2; contains blocks 32,0,-32 to 47,255,-17), Region: (0,-1; contains chunks 0,-32 to 31,-1, blocks 0,0,-512 to 511,255,-1)
Level time: 1948 game time, 1948 day time
Server brand: forge
Server type: Integrated singleplayer server
Stacktrace:
at net.minecraft.client.world.ClientWorld.func_72914_a(ClientWorld.java:617) ~[?:?] {re:classloading,xf:OptiFine:default}
at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2029) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:623) [?:?] {re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A}
at net.minecraft.client.main.Main.main(Main.java:184) [?:?] {re:classloading,pl:runtimedistcleaner:A}
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_51] {}
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_51] {}
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_51] {}
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_51] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) [forge-1.16.5-36.2.2.jar:36.2] {}
at net.minecraftforge.fml.loading.FMLClientLaunchProvider$$Lambda$456/1333945918.call(Unknown Source) [forge-1.16.5-36.2.2.jar:36.2] {}
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.0.9.jar:?] {}
at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.0.9.jar:?] {}
-- System Details --
Details:
Minecraft Version: 1.16.5
Minecraft Version ID: 1.16.5
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory:<PHONE_NUMBER>0 bytes (13485 MB) /<PHONE_NUMBER>0 bytes (14240 MB) up to<PHONE_NUMBER>0 bytes (14240 MB)
CPUs: 12
JVM Flags: 11 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xss1M -XX:+IgnoreUnrecognizedVMOptions -Xmn128M -Xmx14232M -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=32M
ModLauncher: 8.0.9+86+master.3cf110c
ModLauncher launch target: fmlclient
ModLauncher naming: srg
ModLauncher services:
/mixin-0.8.2.jar mixin PLUGINSERVICE
/eventbus-4.0.0.jar eventbus PLUGINSERVICE
/forge-1.16.5-36.2.2.jar object_holder_definalize PLUGINSERVICE
/forge-1.16.5-36.2.2.jar runtime_enum_extender PLUGINSERVICE
/accesstransformers-3.0.1.jar accesstransformer PLUGINSERVICE
/forge-1.16.5-36.2.2.jar capability_inject_definalize PLUGINSERVICE
/forge-1.16.5-36.2.2.jar runtimedistcleaner PLUGINSERVICE
/mixin-0.8.2.jar mixin TRANSFORMATIONSERVICE
/OptiFine-OptiFine-1.16.5_HD_U_G8_pre2.jar OptiFine TRANSFORMATIONSERVICE
/forge-1.16.5-36.2.2.jar fml TRANSFORMATIONSERVICE
FML: 36.2
Forge: net.minecraftforge:36.2.2
FML Language Providers:
<EMAIL_ADDRESS>minecraft@1
Mod List:
forge-1.16.5-36.2.2-client.jar                    |Minecraft                     |minecraft                     |1.16.5              |DONE      |Manifest: NOSIGNATURE
forge-1.16.5-36.2.2-universal.jar                 |Forge                         |forge                         |36.2.2              |DONE      |Manifest: 22:af:21:d8:19:82:7f:93:94:fe:2b:ac:b7:e4:41:57:68:39:87:b1:a7:5c:c6:44:f9:25:74:21:14:f5:0d:90
notenoughanimations-1.2.4.jar                     |NotEnoughAnimations Mod       |notenoughanimations           |1.2.4               |DONE      |Manifest: NOSIGNATURE
tl_skin_cape_forge_1.16.5-1.19.jar                |TLSkinCape                    |tlskincape                    |1.19                |DONE      |Manifest: 19:f5:ce:44:81:0c:e4:22:05:5e:73:c5:a8:cd:de:f3:c8:cf:a9:b3:01:70:40:a0:ee:2d:50:7a:1c:3d:1c:8a
transliterationlib-1.0.4.jar                      |TRansliterationLib Mod        |transliterationlib            |1.0.4               |DONE      |Manifest: NOSIGNATURE
firstpersonmod-2.0.1.jar                          |FirstPersonModel Mod          |firstpersonmod                |2.0.1               |DONE      |Manifest: NOSIGNATURE
corpse-1.16.5-1.0.6.jar                           |Corpse                        |corpse                        |1.16.5-1.0.6        |DONE      |Manifest: NOSIGNATURE
Crash Report UUID: 7bd2cc08-0701-4102-8ef3-330712b850eb
Launched Version: ForgeOptiFine 1.16.5
Backend library: LWJGL version 3.2.2 build 10
Backend API: Intel(R) UHD Graphics 630 GL version 4.6.0 - Build <IP_ADDRESS>66, Intel
GL Caps: Using framebuffer using OpenGL 3.0
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'forge'
Type: Client (map_client.txt)
Graphics mode: fancy
Resource Packs: vanilla, mod_resources
Current Language: Русский (Россия)
CPU: 12x Intel(R) Core(TM) i5-10400 CPU @ 2.90GHz
OptiFine Version: OptiFine_1.16.5_HD_U_G8_pre2
OptiFine Build: 20210305-002749
Render Distance Chunks: 8
Mipmaps: 4
Anisotropic Filtering: 1
Antialiasing: 0
Multitexture: false
Shaders: null
OpenGlVersion: 4.6.0 - Build <IP_ADDRESS>66
OpenGlRenderer: Intel(R) UHD Graphics 630
OpenGlVendor: Intel
CpuCount: 12

That should be fairly easy to fix. The issue is that a player is rendered, while there is no player (cause he's dead).

I will be very grateful if you fix it.

Unfortunately, when I start the game with this build, the game crashes on the loading screen. At the same time, no new files appear in the crash report folder.

It should be Forge and Fabric. Can you upload the latest.log after starting with that build?

latest.log

Thaaats... Odd? Somehow a method is missing in the WorldRenderer. My only guess is that Optifine changes something or that something else in the build broke. Need to check when I'm home to compare/test myself.

I just tried to run the forge without optifine, but the crash is still present. If necessary, here is the startup log without optifi
latest.log
ne

There it wasn't finding something else.  I think I'll redo the 1.17 branch with mojmap and loom, and then backport it to 1.16.

Ok, thanks. Oh, and I just found out that if the launch occurs without optifine, then the files in the crash log folder appear, so if this is important, then here
crash-2021-09-21_10.38.36-client.txt

But I just found out that they are essentially the same thing, so never mind lol

Ok can confirm that it does not work. The issue is I can't do local test builds because of the entire thing not running under Java 16. So I'll do the plan with making 1.17 with mojmap and forge loom, and then backport that to 1.16(maybe even 1.15?)

In other news: the current build on curse for 1.16 seems to be absolutely fine with the corpse mod? Even when using the scaling function that had the issue in the original report

Hm, interesting. I tried to re-download the latest versions of corpse and fpm from curseforge, just in case, even though I already had the latest versions of these mods. But no, the crash is still repeated. And I also tried it without optifine, and the crash is still present. I do not know what could be the reason for this.

Maybe an old Forge install or other mods. But with 1.16.5 Forge-36.2.0 and the cropse mod 1.0.5, First person mod 2.0.1, Not enough animations, skin layers 3d and transliteration lib it seems to work from what I can tell.

I still managed to fix the crash. I removed from my mods folder all the mods that were there, with the exception of those that I am testing. But there was also a mod that didn't get deleted. It was a tl_skin_cape that was built into the TLauncher that I was using. I thought that the problem might be in it, so I deleted this launcher, and transferred everything I needed to another launcher, where the tl_skin_cape was not built in. And yes, it worked. The crash is gone. Thank you for helping me figure out all this.

Yea I don't support TLauncher cause you know... pirated^^ Somehow most of my mods end up being incompatible with whatever TLauncher does. Well at least this got resolved :D


Avoid flyway migrations for the same database in both services

Describe the bug
Flyway migration is done from both Submission Service and Distribution Service
Expected behaviour

There will be single responsibility on which service does migration to avoid race conditions that both services attempt to do migration at the same time.

If a migration fails it will be easy to check one responsible service rather than both.

Steps to reproduce the issue
N/A
Technical details
N/A
Possible Fix
Disable flyway migration from submission service, As this is a server used by Corona Warn App, and as mentioned in the issue #565 migration on application startup should be avoided
Additional context
N/A

Hi Syamala!
Thanks for your input! We had similar concerns before we introduced this, however, the Flyway documentation states that parallel migrations should not be an issue.

Closing this issue as Flyway handles concurrency accordingly.


MM-13257 Delete cookie properly on logout

Summary
We weren't actually deleting the cookie before, so we would still have it until after we made a number of requests that responded with 401 and cleared the cookie. By correctly clearing it manually on logout we don't make those requests as we know the user is not logged in.
I went to add a unit test but to do so would require more refactoring than I was comfortable with putting into the release.
Ticket Link
https://mattermost.atlassian.net/browse/MM-13257
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

branch passed and jenkins refused to build the pr :/

branch passed and jenkins refused to build the pr :/


opae.admin: remove unintended print from setpci in supports_ecap

When AER or DCP is supported setpci prints value to stdout. That is noise.
There is no need for full path for setpci it is already used without.
This was introduced in (#2495) commit de1e57abd.
Signed-off-by: Roger Christensen<EMAIL_ADDRESS>

When AER or DCP is supported setpci prints value to stdout. That is noise.
There is no need for full path for setpci it is already used without. This was introduced in (#2495) commit de1e57a.
Signed-off-by: Roger Christensen<EMAIL_ADDRESS>

I closed it by accident. Please review. Example shows the number 2001001d that I removed:
$ sudo rsu bmc
2001001d
2022-03-25 08:08:57,131 - [[pci_address(0000:98:00.0), pci_id(0x1c2c, 0x1000)]] performing RSU operation
2022-03-25 08:08:57,135 - [[pci_address(0000:97:02.0), pci_id(0x8086, 0x347a)]] removing device from PCIe bus
2022-03-25 08:08:57,337 - waiting 10 seconds for boot
2022-03-25 08:09:07,347 - rescanning PCIe bus: /sys/devices/pci0000:97/pci_bus/0000:97
2022-03-25 08:09:07,350 - RSU operation complete


Rewrite in Rust

This should be written in Rust of course.

Didn’t realize you were such a Rust fanboy

On May 3, 2021, at 2:56 PM, Daniel Norton @.***> wrote:
This should be written in Rust of course.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/hculpan/gosdl/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOW4XRYWGCS3CR5PYAS2KDTL3WUXANCNFSM44BKK77A.


[TASK] Release Events Manager 3.3.0

Description
Please start the release process for Events Manager version 3.3.0. Let's target to submit this version for deployment on Monday (July 11). Thanks.
Acceptance Criteria
Dev deployment completed, release PR reviewed and merged, release tagged in Github with release notes, Docker image built and pushed to ECR, and deployment request created in the terraform repo.

Closing as this is complete.


Update GET_A_BLOT.md

Some suggestions for edits that I've noticed, feel free to accept/reject any or all of them

Thank you for these!


Fix generator return (#1808)

The bug was caused by a mismatch in the datamodel conversion function for return type.

Current coverage is 87.12% (diff: 68.42%)

Merging #2122 into master will decrease coverage by <.01%

@@             master      #2122   diff @@
==========================================
  Files           305        305
  Lines         55997      56010    +13
  Methods           0          0
  Messages          0          0
  Branches       5800       5800
==========================================
+ Hits          48792      48801     +9
+ Misses         6265       6260     -5
- Partials        940        949     +9

Powered by Codecov. Last update dd578e8...5b06653


Confusing default stride_3D parameter for architecture Modified3DUNet

Motivation for the feature
The documentation for the Modified3DUNet architecture shows:

My understanding of a stride, confirmed with the description, ~is the number of skipped voxels during convolution. However, the default stride is the size of the default length, ie: [128, 128, 16], which essentially means that there is only one pass of the convolution?~
EDIT 20230104_111302: The above statement was incorrect (now stroke through). This stride corresponds to the patches, not to the convolution. I got confused because in the DL literature, a stride typically refers to the convolution of the kernel on the patch, see notably:

https://machinelearningmastery.com/padding-and-stride-for-convolutional-neural-networks/
https://deepai.org/machine-learning-glossary-and-terms/stride
https://medium.com/swlh/deep-learning-with-pytorch-tensor-basics-part-1-stride-offset-contiguous-tensors-5d87476b7d9f

However, I am still confused by the stride_3D value. When specifying this config:
        "length_3D": [32, 64, 64],
        "stride_3D": [1, 1, 2],
        "CenterCrop": {"size": [32, 64, 128]},

Does it mean that there will be two patches per volumes? (based on the visual output, it seems to be the case). So, in other words, if CenterCrop_x = length_3D_x, does it mean that there is no striding done along x?

a stride typically refers to the convolution of the kernel on the patch

Firstly, to clarify this a bit more, stride (in typical DL terms) refers to the number of pixels/voxels the convolutional kernel is expected to shift in order to perform the convolution on the image patch. The stride is typically a small number (1 or 2, in most cases) which tells that the kernel is shifted by 1 pixel/voxel in order to perform the convolution.
However, this is NOT the same as what ivadomed describes in stride_3D, which is a slight abuse of the term and hence causes confusion.
First, the original stride (that is, how everyone in DL understands it, is fixed for 3D UNet model can be seen in any convolution layer, for e.g. here). What stride_3D refers to is how far or how close you want the patches to be extracted from the center cropped volume (note that this has nothing to do with the shifting of the convolutional kernel - this is fixed as shown above). Taking the example you have given: in cropped volume of size [32, 64, 128], one patch is extracted at the location [32, 64, 64]. For the next patch, since stride_3D is [1, 1, 2], the next patch is extracted at the location [32, 64, 66], then at [32, 64, 68] and this goes on until the entire patch of size [32, 64, 128] is traversed. So, this means that there are 64 such patches that are extracted if stride_3D is [1, 1, 2]. One can observe that based on this definition of stride_3D, if small values are chosen then there will be a lot of overlap between the patches that are extracted.

Does it mean that there will be two patches per volumes?

If 2 volumes per center-cropped patch are desired, then stride_3D should be [32, 64, 64]. That is, one patch at this location and the next patch is extracted after moving 64 voxels in the 3rd dimension.

So, in other words, if CenterCrop_x = length_3D_x, does it mean that there is no striding done along x?

Yes, because the length of the patch is precisely how much of the input has been cropped thus leaving no space for more patches to be extracted from this dimension.
Let me know if this explanation makes sense! It is understandable that this is confusing (not sure why the names length_3D and stride_3D were chosen to begin with), especially when stride has a different meaning universally.

Thank you for the clarification @naga-karthik . My problem is that, when setting the Stride_3D parameter to what it should be, I am running into https://github.com/ivadomed/ivadomed/issues/1245 and/or https://github.com/ivadomed/ivadomed/issues/1022#issuecomment-1371640731. The latter being particularly problematic, because it forces me to use a larger input image size than what would be reasonably expected (ie: if dim is 128 and kernel is 64, I expect that a "stride" of 64 should be sufficient, but according to the definition it is not).
Moreover, me using Stride_3D of 1 with "CenterCrop_x = length_3D_x" produces a SINGLE patch (when considering one dimension, for clarity of the demonstration). That is also quite confusing and we should do something about it (eg: output a warning or something).
I'll follow-up with a calculation of patch generation with a current experiment, just to make sure we are all on the same page.

Here's the calculation.
config:
length_3D: [32, 64, 64]
stride_3D: [1, 1, 2]
CenterCrop: {'size': [32, 64, 128]}

Data: Based on the file bids_dataframe.csv (it would be more convenient to have the info spitted out by the logger-- related to https://github.com/ivadomed/ivadomed/issues/1102), there are 178 paired with a label.
Ivadomed output:
2023-01-05 13:34:38.166 | INFO     | ivadomed.loader.loader:load_dataset:118 - Loaded 1815 volumes of shape [32, 64, 64] for the validation set.
2023-01-05 13:34:58.191 | INFO     | ivadomed.loader.loader:load_dataset:118 - Loaded 3498 volumes of shape [32, 64, 64] for the training set.

I think I can understand what's causing this (though I could not get the exact number of volumes as shown - that depends on the number of subjects used for training and validation). The magic is happening in these lines inside the class MRI3DSubVolumeSegmentationDataset (same shown below).
for x in range(0, (shape[0] - self.length[0]) + 1, self.stride[0]):
    for y in range(0, (shape[1] - self.length[1]) + 1, self.stride[1]):
        for z in range(0, (shape[2] - self.length[2]) + 1, self.stride[2]):
            self.indexes.append({
                'x_min': x,
                'x_max': x + self.length[0],
                'y_min': y,
                'y_max': y + self.length[1],
                'z_min': z,
                'z_max': z + self.length[2],
                'handler_index': I})

So, what I explained in my comment above remains as it is - the stride_3D is essentially the "step" the we use to skip indices in the standard for loop. Now, with your parameters, we have the following:
shape: [32, 64, 128]    # this is the shape printed in the code after center cropping
length: [32, 64, 64]
stride: [1, 1, 2]

for x in range(0, 1, 1):
    for y in range(0, 1, 1):
        for z in range(0, 65, 2):
            self.indexes.append({
                'x_min': x,
                'x_max': x + 32,
                'y_min': y,
                'y_max': y + 64,
                'z_min': z,
                'z_max': z + 64,
                'handler_index': I})

so, for each center-cropped volume of size [32, 64, 128], 33 sub-volumes are extracted (not 32). Now, if the number of subjects for validation are n then, n x 33 should give you the total number of volumes in the validation set, which is 1815.

Thank you for the digging, @naga-karthik, but I was not too worried about the non exact match (further digging would explain it, but that's not the point). The two main worries where we need to act are

The first paragraph in https://github.com/ivadomed/ivadomed/issues/1248#issuecomment-1372748811
The confusion about the Stride_3D naming (more of a UX issue)

Ah okay! Considering this:

(ie: if dim is 128 and kernel is 64, I expect that a "stride" of 64 should be sufficient, but according to the https://github.com/ivadomed/ivadomed/issues/1022 it is not).

Would you providing the exact configuration of length, stride and center-crop that's not working? I'm asking because every number is a multiple of 16 so I was wondering which configuration is raising an error
As for this:

The confusion about the Stride_3D naming (more of a UX issue)

step_size_3D should be a good alternative

I did another experiment, to "fix" my wrong patch coverage along the 3rd dimension:
"train_fraction": 0.6,
        "test_fraction": 0.1
        "length_3D": [32, 64, 64]
        "stride_3D": [1, 1, 64]. <---- that's the change! (previously it was 1,1,2
        "CenterCrop": {'size': [32, 64, 128]}

Data: Based on the file bids_dataframe.csv (it would be more convenient to have the info spitted out by the logger-- related to https://github.com/ivadomed/ivadomed/issues/1102), there are 178 subjects paired with a label (same as before).
Ivadomed output:
2023-01-05 17:49:03.610 | INFO     | ivadomed.loader.loader:load_dataset:118 - Loaded 110 volumes of shape [32, 64, 64] for the validation set.
2023-01-05 17:49:23.592 | INFO     | ivadomed.loader.loader:load_dataset:118 - Loaded 212 volumes of shape [32, 64, 64] for the training set.

So, 0.6178 = 106.8 subjects for training. Considering a stride of 64 along Z, it takes 2 steps to go from 64 to 128, so 2 patches per subjects, which gives 106.82 = 213 patches, which is consistent with the "212" patches mentioned in the ivadomed output. So, the numbers again make sense. And I'm happy that issue number one listed in https://github.com/ivadomed/ivadomed/issues/1248#issuecomment-1372887236 is now solved. However we need to work on the UX.

step_size_3D should be a good alternative

Yes, although I'd like it if we could finally unify our 2D and 3D fields/codebases

EDIT: changed 0.6178 = 106.8 originally to 0.6*178 = 106.8

yes, excellent point

Would you mind providing the exact configuration of length, stride and center-crop that's not working? I'm asking because every number is a multiple of 16 so I was wondering which configuration is raising an error

Another example here https://github.com/ivadomed/ivadomed/issues/1022#issuecomment-1371640731, with no multiple of 16-- it should fail, and it does not fail

Ah yes, I just checked that, seems like the reason for setting the "multiple of 16" condition is indeed mysterious.

Based on a brief discussion about unifying the current "stride" key across 2D and 3D models, here's what was decided:
At this stage, the unification of 2D and 3D for this key requires major refactoring of the codebase, hence we would like to take small steps and change the (currently confusing) key name from stride_3D to patch_step_size_3D for the 3D models and patch_step_size_2D for the 2D models for now. Future modifications to the updated key will only require it to be changed to patch_step_size, thus removing the suffixes for both 2D and 3D.
(tagging @mariehbourget for confirmation - please feel free to edit if you want to add anything more. Thanks!)

Based on a brief discussion about unifying the current "stride" key across 2D and 3D models, here's what was decided:
At this stage, the unification of 2D and 3D for this key requires major refactoring of the codebase, hence we would like to take small steps and change the (currently confusing) key name from stride_3D to patch_step_size_3D for the 3D models and patch_step_size_2D for the 2D models for now. Future modifications to the updated key will only require it to be changed to patch_step_size, thus removing the suffixes for both 2D and 3D.
(tagging @mariehbourget for confirmation - please feel free to edit if you want to add anything more. Thanks!)

Thanks @naga-karthik for the summary, looks good to me!
As a reference, here is how we handled modifying KEY names in the config file in the past with the config manager for retrocompatibility of old config files (e.g. config files of models used by SCT or ADS).
https://github.com/ivadomed/ivadomed/blob/ab381409e07af1f27a77e0cfb246f33bcc6291bb/ivadomed/config_manager.py#L73-L76
https://github.com/ivadomed/ivadomed/blob/ab381409e07af1f27a77e0cfb246f33bcc6291bb/ivadomed/config_manager.py#L119-L137
and
https://github.com/ivadomed/ivadomed/blob/ab381409e07af1f27a77e0cfb246f33bcc6291bb/ivadomed/config_manager.py#L147-L172


[GHSA-wgmf-q9vr-vww6] PhpSpreadsheet HTML writer is vulnerable to Cross-Site Scripting via style information

Updates

Affected products

Comments
Also fixed version 1^ in https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/1.29.1

Hi there @oleibman! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Yes, if this change will update the Global Advisory, please handle it ASAP. I have tried a similar change, and never saw a PR come out of it. There is another Advisory which needs similar handling. I have opened a support ticket about what I need to do https://support.github.com/ticket/personal/0/2983095


Allow pre-release replacements to be specified relative to the project root

I have a project with CHANGELOG.md at the root of the repository and sub-crates in nested directories and would like to use pre-release replacements to update links in CHANGELOG.md.
My directory structure:

/

CHANGELOG.md
Cargo.toml
release.toml
crates/

first-crate/
second-crate/

My release.toml:
pre-release-replacements = [
  {file="CHANGELOG.md", search="Unreleased", replace="{{version}}"},
  {file="CHANGELOG.md", search="\\.\\.\\.HEAD", replace="...{{tag_name}}", exactly=1},
  {file="CHANGELOG.md", search="ReleaseDate", replace="{{date}}"},
  {file="CHANGELOG.md", search="<!-- next-header -->", replace="<!-- next-header -->\n\n## [Unreleased] - ReleaseDate", exactly=1},
  {file="CHANGELOG.md", search="<!-- next-url -->", replace="<!-- next-url -->\n[Unreleased]: https://github.com/assert-rs/predicates-rs/compare/{{tag_name}}...HEAD", exactly=1},
]

Whenever I run cargo release on this workspace it'll complain that crates/first-crate/CHANGELOG.md doesn't exist because each replacement is resolved relative to the crate being released. In this case I can't use ../CHANGELOG.md as the path because there are crates at different levels.
Is it possible to use something like file="/CHANGELOG.md" to make the replacement relative to the repository's root directory (i.e. the path printed by git rev-parse --show-toplevel)?

cargo-release is running pre-release replacements for every crate's release.  I'm assuming just allowing workspace-relative paths wouldn't help fix that because you wouldn't want to update the file multiple times.
We have this covered in the FAQ though maybe it could be made clearer.
/release.toml is inherited by all of the crates in a workspace.  What you most likely need is to set a setting that isn't inherited.  The per-crate way of specifying config is by setting it in your Cargo.toml (example)

Considering

The proposal would likely lead to broken projects (updating files when they shouldn't be)
There seems to be a path forward
There haven't been any updates

I'm going to go ahead and close this.  Feel free to let me know if we missed something

Hi,
I'm having the same issue, and while I've seen the proposed solution (adding a dummy hook to every crate), this kind of sucks in a project with over a dozen (and growing) crates. Additionally, its a virtual workspace so no root crate to act as flag bearer.
I'm working around it currently by adding:
[package.metadata]
pre-release-replacements = [ ]

to each Cargo.toml, but honestly, a proper "workspace only" setting would be good.


Readme fix

The official batch-processing guide had redundant full stops and a broken list. This PR fixes it.

@gregturn This is a valid point. Can we merge this?

Looks like a relic of when the guides were written in Markdown. I'd yank the periods and replace with asterisks to make them bullet points.

Hi, sorry for a late response. I've switched to asterisks as requested. Let me know if I missed anything.

@vilisimo Thank you for updating the PR!
@gregturn I think the changes are ready to merge now. Do you agree?

@vilisimo Thank you for the updates. Rebased and merged as ec6da02548994445f5fed0bae498bde17691783d.


Use itemDuration to add duration

Hspec Formatters.V2 has itemDuration that can be used to add test case/group duration.
https://www.stackage.org/haddock/lts-20.10/hspec-core-2.9.7/Test-Hspec-Core-Formatters-V2.html#g:2

Please see #6 .
Known problems:

HSpec does not report durations of groups. I was able to create a reporter which is able to keep state between test events (thanks @dramforever!), but we need to decide what should be presented in <COMPLETEDIN::> of a test group. One proposal is to show a sum of times of its items, but it does not account for surrounding overhead. I thought about storing startTime timestamp in formatterGroupStarted and calculating its duration in formatterGroupDone, but current build setup provides no packages for time manipulation. Let me know which way you prefer, and please add some package for working with time if you want me to use timestamps.
Crashes originating from outside of it result in an incomplete report (see the commented out test case in example test suite). In pessimistic case it can happen that a test run ends with all green and a crash, what can potentially lead to tests erroneously passing.
I added some test cases to the example test suite to verify presentation of various  test outcomes, but I think it broke your checks. Please let me know if I should revert.

Thanks for working on this!

One proposal is to show a sum of times of its items

I think this is good enough as a start.

I thought about storing startTime timestamp in formatterGroupStarted and calculating its duration in formatterGroupDone, but current build setup provides no packages for time manipulation.

Can't you just store Seconds from getRealTime, then get the difference in formatterGroupDone?

Crashes originating from outside of it result in an incomplete report (see the commented out test case in example test suite). In pessimistic case it can happen that a test run ends with all green and a crash, what can potentially lead to tests erroneously passing.

Is the exit code 0? What happens without our formatter?

I added some test cases to the example test suite to verify presentation of various test outcomes, but I think it broke your checks. Please let me know if I should revert.

Yeah, the current CI is just there to check it compiles. Ideally, we should have proper tests like in https://github.com/hspec/hspec/blob/55b078e9c4a6143dcb0c9a5ef7faca6d0d788888/hspec-core/test/Test/Hspec/Core/Formatters/V2Spec.hs#L103
You don't need to revert it.

Can't you just store Seconds from getRealTime, then get the difference in formatterGroupDone by subtracting?

Uh, I guess I can. I missed it, thanks for pointing it out.

Is the exit code 0? What happens without our formatter?

I did not check, but I will. But even if return code is error and test run is recognized as failed, all the green and almost no red can be confusing. I hoped to have at least some <ERROR::> on crash, but I don't know if I an find a good place to plug into.

Yeah, the current CI is just there to check it compiles. Ideally, we should have proper tests like in https://github.com/hspec/hspec/blob/55b078e9c4a6143dcb0c9a5ef7faca6d0d788888/hspec-core/test/Test/Hspec/Core/Formatters/V2Spec.hs#L103

I have also two its with QuickCheck tests to see how tests commonly used on CW would look. I did not commit them because they need a dependency to QuickCheck, which is currently not there.  Is it OK to have a dependency to QuickCheck in this project?

Is it OK to have a dependency to QuickCheck in this project?

You can add Quick check to dependencies under tests in package.yaml.

But even if return code is error and test run is recognized as failed, all the green and almost no red can be confusing. I hoped to have at least some <ERROR::> on crash, but I don't know if I an find a good place to plug into.

I guess the only place is the main.
https://github.com/codewars/hspec-formatters-codewars/blob/cd57285fb90dd447bf5c1406f304718ca025b203/test/Main.hs#L9-L10
Call it with safeTry then show <ERROR::> on Left e?


Fix custom problem set: Qiskit Beginner Proficiency

Changes

Fixed text in Overview
Fixed code in Problem 1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Newly added tag is not arranged in alphabetical order

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.52-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Precondition:

User is an admin of Collect workspace.

Go to staging.new.expensify.com.
Go to Settings > Workspaces > Collect workspace.
Go to Tags.
Click Add tag.
Add a tag.

Expected Result:
The new tag will be arranged in alphabetical order.
Actual Result:
The new tag is not arranged in alphabetical order. It only follows the order after refreshing the page.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/b524be86-1f7c-43c1-ab1a-d42fcbff6218

View all open jobs on GitHub

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think that this bug might be related to #wave-control
cc @JmillsExpensify

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

It's a deploy blocker so it should really be fixed by whoever broke this.

Seems related to https://github.com/Expensify/App/pull/37870 cc @luacmartins

I can take this over! Thanks for the ping!

Proposal
Please re-state the problem that we are trying to solve in this issue.

Newly added tag is not arranged in alphabetical order

What is the root cause of that problem?

After creating tag, we just add a new tag to the policyTags without sorting alphabeta order. Refreshing the page will display data correctly because BE returns the correct tags's order

What changes do you think we should make in order to solve the problem?

We need to create a sort function in FE side to sync with FE side, then use it to update the optimistic data when craeting a new tag

What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

I think this does not have to be a blocker

This is not a blocker since the feature is still WIP. PR to fix it here

Just pending payment

still pending payment

Just pending payment

Bump for payment @kevinksullivan

Bump for payment @kevinksullivan

Bump @kevinksullivan for payment

Same as other issue, waiting for @situchan to accept.

Still waiting on @situchan

@kevinksullivan sorry I am back from vacay. Can you please send new offer? Old one was expired.

All good!

@situchan fresh offer here
https://www.upwork.com/jobs/~01820a70bf08232dfa

all set

@kevinksullivan this was created before Apr 4


[BUG] Exception when executing the cla-assistant during pull - Parameter token or opts.auth is required

Describe the bug
Getting a Parameter token or opts.auth is required error when the cla-assistant is run when a pull request is created, whether there is another pull request with the I have read the CLA Document and I hereby sign the CLA comment in a separate pull request comment. Currently on V2.0.3-alpha. The repo where this is being tested is rsbeckerca/TestCLA. I am suspecting that there is a step missing in the setup. Also the repo uses a main branch instead of a master branch.
To Reproduce

Create a new repo.
Add the cla-assistant workflow cla.yml file.
Switch to a new branch
Modify a file and commit.
Create a pull request.

Expected behavior
The exception should not occur.
Screenshots
Error: Parameter token or opts.auth is required
at Object.getAuthString (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:4610)
at Object.getOctokitOptions (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:68637)
at Object.getOctokit (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:57376)
at Object.994 (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:226648)
at webpack_require (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:154)
at Object.407 (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:27687)
at webpack_require (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:154)
at Object.210 (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:12928)
at webpack_require (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:154)
at Object.131 (/home/runner/work/_actions/cla-assistant/github-action/v2.0.3-alpha/lib/main.js:1:6119)

Hi @AndrewGable, thank you for reaching out to us.
Did you add your Personal Access token with repo scope into the test repository rsbeckerca/TestCLA secrets ?

I think this is causing the issue.

Thanks. That was it.