Typos in getting started page

Found a couple of typos that need to be corrected lines #15, 21

Hello, is this still open?

Yes, it's still open

I would love to be assigned this issue.
On Mon, Jun 17, 2024, 11:38 AM uuserf16 @.***> wrote:

Yes, it's still open
—
Reply to this email directly, view it on GitHub
https://github.com/fidelity/kconnect/issues/676#issuecomment-2173863601,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A5QHWENMF73Q5BQBAVZRAYTZH4GJHAVCNFSM6AAAAABIPCUIGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZTHA3DGNRQGE
.
You are receiving this because you commented.Message ID:
@.***>


Connecting to Harmony Hub from AWS Lambda

Greetings, Sushil!
Thanks for your work on this code , it's been easy to get going for the most part, but I have ran into an issue I'm hoping you can help me with.
I intend on writing a blog post that details my how-to, as there doesn't seem to be any good documentation on how to get your code running in Lambda easily.
I've created my Alexa Skill using "remote" as my invocation command and created my Lambda function with all appropriate files (remote.js, remote_conf.js, node_modules, and package.json).  I have input my Alexa AppID and Harmony Hub IP (FQDN'd) in remote_conf.js.
I enabled the skill in the Echo app on my iPhone, and I can speak "Alexa, tell remote to turn everything off" or "Alexa, tell remote to mute."  I get a response back from Alexa saying the command is getting executed, and the Lamdba logs show the request and response going through with no problems.  I can also test the Skill in the Alexa Skills Builder and I am getting back the correct response.
The problem is, the command I am requesting is not happening in my home..  Everything is not turning off, nothing to getting muted, etc.
Since it appears that everything is working with the code (I think), I figured it has to be something on my local network.   Here is what I have done:
I have setup port forwarding on my router in the following manner:
external IP : 5222 -> <IP_ADDRESS> : 5222 (ensured this was my HH by looking at DHCP leases and matching MAC to IP.  I then set a static IP for the HH to it'll always be .40 on my localnet).
Just as a test, I recently added this rules as well:
external IP : 80 -> <IP_ADDRESS> : 5222
Could you please provide your thoughts?  I've tried quite a bit of trial and error, but cannot get this to work.
Thanks in advance!

In my case I was not running the code on lambda, I had a local server in my home (it was in the same L2 domain as the harmony hub) executing the code.
From what I understand you are trying to run the code on lambda and are trying to pass the command via port forward to the harmony hub.  I am not sure what ports need to be forwarded.
To debug this out I have another utility that you can use to trigger commands on the hub(It can both read and write to the hub)
https://github.com/sushilks/harmonyHubCLI
you can use this within your L2 network and make sure that the hub is responding (Just run it from your laptop while connected to the home network where harmony is connected)
you can also use it from outside the home network and see if you can read/write form the hub.
Hope this will give you some help, if not post your findings.

In my case I was not running the code on lambda, I had a local server in my home (it was in the same L2 domain as the harmony hub) executing the code.
From what I understand you are trying to run the code on lambda and are trying to pass the command via port forward to the harmony hub.  I am not sure what ports need to be forwarded.
To debug this out I have another utility that you can use to trigger commands on the hub(It can both read and write to the hub)
https://github.com/sushilks/harmonyHubCLI
you can use this within your L2 network and make sure that the hub is responding (Just run it from your laptop while connected to the home network where harmony is connected)
you can also use it from outside the home network and see if you can read/write form the hub.
Hope this will give you some help, if not post your findings.

I was getting the error when trying to run the harmonyCLI as referenced in https://github.com/sushilks/harmonyHubCLI/issues/1.  I was able to get that working with your workaround on xmpp-client version.
I can successfully change activities now with the CLI on my home network via IP, and as well on the FQDN I setup.  I also tested the devices, and I can issue mute and change channel, etc.  All commands are executing with the CLI.
Still cannot get an activity change via Alexa though.

Not sure where the problems is coming from, there could be restriction on
Amazon side.
Are there any firewall rules on the lambda side.
On Jan 2, 2016 07:43, "Wayne A. Walls"<EMAIL_ADDRESS>wrote:

I was getting the error when trying to run the harmonyCLI as referenced in
sushilks/harmonyHubCLI#1
https://github.com/sushilks/harmonyHubCLI/issues/1. I was able to get
that working with your workaround on xmpp-client version.
I can successfully change activities now with the CLI on my home
network via IP, and as well on the FQDN I setup. I also tested the
devices, and I can issue mute and change channel, etc. All commands are
executing with the CLI.
Still cannot get an activity change via Alexa though.
—
Reply to this email directly or view it on GitHub
https://github.com/sushilks/alexaHarmonyApp/issues/3#issuecomment-168357400
.

Not that I can tell.  The only security groups are in the EC2 service, specifically.
I was read this about the Hub protocol and getting a token from Logitech:  https://github.com/jterrace/pyharmony/blob/master/PROTOCOL.md
How, or is this getting handled anywhere in this code?  I'm about to take a look, but wanted to post here as well.

I am not too familiar with that part of the code,  so post what you find.
One thing to consider is that there is no authentication on harmony api,
so if you open the port on public ip  any one can send it commands. It's
best to add a firewall on the public ip.
On Jan 2, 2016 12:38 PM, "Wayne A. Walls"<EMAIL_ADDRESS>wrote:

Not that I can tell. The only security groups are in the EC2 service,
specifically.
I was read this about the Hub protocol and getting a token from Logitech:
https://github.com/jterrace/pyharmony/blob/master/PROTOCOL.md
How, or is this getting handled anywhere in this code? I'm about to take a
look, but wanted to post here as well.
—
Reply to this email directly or view it on GitHub
https://github.com/sushilks/alexaHarmonyApp/issues/3#issuecomment-168368684
.

Yeah, that appears to be for the Logitech Link, not the HH.  I don't think it's an auth issue.  I did find that Lambda cannot bind to a port...not sure what the incoming request looks like coming from AWS.  Might need to run a tcpdump and see if anything shows.

@dubsquared  Any updates on this ?

Closing as there is no more updates.

I am having the same problem.  I did find this on SO,  and it may be just timing out before the initialization is complete.
http://stackoverflow.com/questions/28449363/why-is-this-http-request-not-working-on-aws-lambda


Plans for bitemporal queries and applications?

Is tigerbeetle planning to support bitemporal queries and execution such that we can retroactively apply debits/credits? Likewise, will we be able to track when such a retroactive action took place?

This isn't on the road map right now. But I'm interested to hear more about the use cases and applications for this feature.

Hi @sentientwaffle. Maybe this idea is entirely against the rules of double entry accounting. Happy to be educated!
The feature in discussion is essentially built-in tracking of all historical changes, including edits to invalid transactions or perhaps adding a transaction into the past. It's what xtdb offers but they don't have the double entry accounting built in, nor your other features. In my head, bitemporarily = ability to query against "valid times" and "transaction time" (typically system time as of transaction creation). xtdb also follows an document model instead of a table model. Hopefully I can translate a decent but very common example.
Primary use-case is when a mistake arises in a transaction: perhaps incorrect amount, incorrect time. In all cases, we can cleanly revert it by appending a new transaction. But it's not as neat as being able to delete or edit the incorrect transaction entirely. In this mutation though, we should naturally have a log of the action for auditability.
Example with an append-only logic
Day 1 - Balance $20.
Day 2 - incorrect debit transaction occurs. Balance is now $10. Should be $20.
Day 3 - A new credit transaction is applied to revert the debit. Balance is now $20.
This results in an annoying history. At least we can probably relate the pair of reverts and hide from clients. Is this what you'd normally in the tigerbeetle db, and for normal double entry accounting?
Example with tracked mutation possible
Day 1 - Credit an account with $20. Balance $20.
Day 2 - incorrect transaction occurs. Balance is now $10. Should be $20.
Day 3 - Delete the incorrect transaction. Balance is now $20. The deletion action is logged in the data model itself.
We can query for the account's balance with valid time of Day 3 for a balance of $20. If we also query for the account's transactions with the same parameters, we don't see the incorrect transaction nor the revert transaction.
For an easy audit of the account history, we'd like to know why and how an account went from $20 to $10 to $20 by Day 3. We can query for transactions with transaction time by Day 3 to see all transactions including the invalid transaction made on Day 2.

Thank you for the explanation!

This isn't on the road map right now.

I just talked to @jorangreef and I was wrong — we may support this in the future after all.
Your "Example with an append-only logic" accurately reflects how it works right now in TigerBeetle — if there's a mistake, just create a new transfer to fix the mistake.
It sounds like bitemporal queries can be made to work with double-entry accounting. But I haven't wrapped my head around them so I can't really elaborate yet :grin:.

It sounds like bitemporal queries can be made to work with double-entry accounting. But I haven't wrapped my head around them so I can't really elaborate yet 😁.
I've recently explored TigerBeetle, which made me reflect on the database landscape for financial transactions. It's interesting that for decades, organizations had to repeatedly implement debit/credit accounting patterns in general-purpose relational databases, often reinventing similar solutions with varying degrees of success. TigerBeetle's emergence as a specialized database for financial transactions seems to fill this historical gap. :D

While TigerBeetle offers interesting and well-thought-out concepts, there are some technical considerations that may affect its adoption in wider financial/accounting scenarios.
I think the absence of bitemporal logic becomes more significant given that all TigerBeetle records are immutable. While immutability makes sense for live financial transactions, its application in traditional financial accounting is more nuanced. In standard accounting practices, true immutability typically only applies after month-end closure; before that point, most financial accounting systems maintain entries in a "draft" state that can be modified until the month is closed.
Of course, both approaches require careful analysis.
BTW: Actually, there can even be a need for tritemporal logic. A great read on this is in Wikipedia: https://en.wikipedia.org/wiki/Decision_time


connectionClosed callback doesn't work if stream is stopped from client side

Testing WebRTC at https://ovenplayer.com/docs/demo_input.html
connectionClosed callback is never called when I stop stream on client side. It works when connection is closed from server side.
Obviously socket connections is not getting closed properly from client side as it should happen here
https://github.com/AirenSoft/OvenLiveKit-Web/blob/17e7387782bc63485ea6694cda18a2b2d7161ab9/src/OvenLiveKit.js#L367
So webSocket.onclose  never happens and that's strange as instance.webSocket.close(); is called here
https://github.com/AirenSoft/OvenLiveKit-Web/blob/17e7387782bc63485ea6694cda18a2b2d7161ab9/src/OvenLiveKit.js#L741
Can you please double check on your side? Thanks!

@brootle Hi. Yes, I will check it as well.
And please be careful site https://ovenplayer.com/docs/demo_input.html has been consolidated into https://demo.ovenplayer.com/demo_input.html

@brootle connectionClosed callback is designed to only occurs when there is an abnormal disconnection situation. If you use 'instance.remove' to stop the stream on the client side, this code will not fire the 'connectionClosed' callback.
https://github.com/AirenSoft/OvenLiveKit-Web/blob/17e7387782bc63485ea6694cda18a2b2d7161ab9/src/OvenLiveKit.js#L369

@SangwonOh thanks! I was playing with closing connection from the client side and after some testing it looks like it works best when I send 'stop' command via socket connection, this way server closes both peer and socket connection, there is also one funny thing, browser for some reason doesn't send command right away, there is ping/pong (like every 30 seconds or so) between browser and server during socket connection, so I am sending 'stop' command and one second after that send empty message, this way there is no delay and command is delivered, server sends error to client and I have confirmation on client that connection is closed. I noticed that there was 'stop' command in OvenPlayer client, but this logic didn't get into OvenLiveKit-Web, see https://github.com/AirenSoft/OvenPlayer/blob/master/src/js/api/provider/html5/providers/WebRTCLoader.js#L875

@brootle Yes. As you said, it might be a good idea to send the `stop' command. We will implement it and patch it in the next update. Thanks!

Good


Add plan argument to 2D/3D FFT functions in cupyx.scipy.fftpack

As discussed in #1669, it's desirable to pass explicitly a cuFFT plan to FFT functions. Since currently only PlanNd for C2C transforms is supported (see the PR #1746), following the same logic I changed the signatures for the following functions:

cupyx.scipy.fftpack.fft2
cupyx.scipy.fftpack.ifft2
cupyx.scipy.fftpack.fftn
cupyx.scipy.fftpack.ifftn

so that they accept a plan argument (defaulted to None). For users' convenience I also provide a handle cupyx.scipy.fftpack.get_fft_plan that returns a cuFFT plan for the target array with specified axes. These are the two deviations from the scipy.fftpack counterpart. But for users don't care about plans, the API is guaranteed compatible (I think).
Using the test script adapted from @grlee77's, in the reply below I show the performance gains for using an explicitly managed plan compared to an auto-generated plan as implemented in #1746. One can see that

getting rid of the overhead for plan generation indeed gives better performance, especially for smaller arrays (for larger arrays most of the time is spent on number crunching, so generating a plan is relatively cheap),
for 2D transforms, 3D arrays in C order perform better for axes=(1,2) while those in F order better for axes=(0,1),

both of which are expected observations.
Question: I am not sure how to write a proper test case. Since scipy.fftpack doesn't support plan, we shouldn't compare with the results from scipy.fftpack, should we? So what decorator should I put for the test cases? See also the comments I left in tests/cupyx_tests/scipy_tests/fftpack_tests/test_fftpack.py
TODO:

[x] Get the tests done

@asi1024 any update on the failure?

Just realized I also need to update the documentation. It's done in a7803c6.

btw @asi1024 can we tag this PR for v6.0.0b3 if possible? I'd like to push it for production asap since having a cuFFT plan can mitigate a big performance bottleneck I encounter in several of the projects I participate. Thanks!

Jenkins, test this please.

Jenkins, test this please.

Jenkins CI test (for commit be3a11fe7e7be37abaf1e473c71e81ff49b2c4d0, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins failure is irrelevant to this PR. LGTM! Thanks!

Thanks a lot for your help, @asi1024 and @grlee77! I'll make a PR for 1D FFT shortly.


[Improvement] Improve the Readme.md

We can have the following improvements in the Readme file -

Add latest Screenshots inside the table (Replace older ones if required)
Add more details about the project
Add a Contributors Section

Any more suggestions are welcome!

Hey can I work on this?

Hey can I work on this?

Sure!

@Kasambx Shall I take it on from here!?
@prakhartiwari0 I have some ideas on this (not typos). It would be great if you could assign me this!

Sure, that's fine by me.


Kintsugi - error when trying to stake additional KINT

Relevant URL: https://kintsugi.interlay.io/staking
I tried to stake additional KINT (I already have a small amount staked) for a 16-week lock but after signing the transaction, I got a pop-up error message with the following message:
Message:
-32601: RPC call is unsafe to be called externally
Note: There is no record of any extrinsic being issued on-chain, so I assume this is a UI issue (or an issue with the RPC endpoint along with the UI?)
Related note: The total is listed as "96 weeks" but the maximum amount of time to stake for is 16 weeks. Not sure if "total" means something else here, but if so, it's rather confusing being right above the input box where on enters for how long they want to stake.

Further notes: I tried different lock amounts and times, but always get this error message.
I receive the same error message when trying on Interlay Polkadot chain as well ( https://app.interlay.io/staking )

Hi @laboon thanks for this—there was an issue submitting transactions following a UI release which we've rolled back. We know what the issue is, and are working on a fix now so I'm going to close this as a duplicate.


Cannot pickle '_io.BufferedReader' object exception after DataArray transpose and copy operations when using fsspec filecache.

What is your issue?
We hit this issue while using rioxarray with a series of operations similar to those noted in this issue https://github.com/corteva/rioxarray/issues/711. After looking through the rioxarray codebase a bit I was able to reproduce the issue with pure xarray operations.
When opening a Dataset with fsspec local caching enabled, transposing a DataArray's coordinates and then copying the DataArray results in a cannot pickle '_io.BufferedReader' object exception.
The issue can be reproduced using this sample notebook.
Note that when using the filecache option with fsspec.filesystem the exception occurs immediately.  When using the blockcache option the exception only occurs after a second copy call which is presumably using cached data.
This issue seems potentially related to the fsspec investigation in https://github.com/fsspec/filesystem_spec/issues/579#issuecomment-1140377495 but interestingly only seems reproducible with this incantation of transpose followed by copy.

Do this & #8442 require using an S3 backend? If not, is it possible to produce examples which are copy-pastable?
(sorry this hasn't got much attention — some of these cross-library issues are difficult. I can't guarantee an MCVE will be sufficient, though it is necessary...)

@max-sixty Apologies for not providing an MCVE.  Initially I thought this was S3 backend specific but I am able to reproduce locally with fsspec target_protocol=file as well.
import fsspec
import xarray as xr
import numpy as np

cache_type = "filecache"
protocol = "file"
file_path = "test.nc"

ds = xr.Dataset(
    {
        'latitude': np.arange(10),
        'longitude': np.arange(10),
        'precip': (['latitude', 'longitude'], np.arange(100).reshape(10,10))

    }
)
ds.to_netcdf(file_path, engine="h5netcdf")

fs = fsspec.filesystem(cache_type, target_protocol=protocol, cache_storage="./cache")
file = fs.open(file_path)

ds = xr.open_dataset(file, engine="h5netcdf", decode_coords=True, decode_times=True, lock=False)
da = ds["precip"]

da = da.transpose("longitude", "latitude", missing_dims="ignore")
da_copy = da.copy()

No worries about the lack of attention, I realize that issues dealing with fsspec interactions are likely very difficult to debug.  Thank you for investigating 👍

I can repro.
I'm not completely sure what's going on. I'm guessing the dataset references the file path, and so attempts to copy it when the dataset is being copied. But why does it try to pickle it? I though pickling was for serializing, which this isn't trying to do...


npm install libtidy fails

I'm using the latest version of Node.js and NPM
not really sure why it fails.

Are you building from Tidy source? What's the description of the failure? Who's the NPM package manager? Is this better reported to them?
We have nothing officially to do with how others are packaging us, but are prepared to help if you can offer much more information.

Are you perhaps trying to use node-libtidy as a dependency of some other project, referencing not the latest release by version number, but actually github? In that case, you may need npm 3.7.0 to properly initialize git submodules for you. See https://github.com/npm/npm/pull/11094. This issue would manifest itself as source files not being found.

@balthisar: The NPM package manager would be me, and as far as I can tell, the issue was reported for my package. You just decided to watch my project, which means you'll receive notifications about all the issues reported for it. If that's not what you want, then perhaps star instead of follow would be better. Right now, this appears to be a node-specific issue, although I'll sure let you know if tidy itself is involved in some way.

Oh, goodness. I feel silly.

Closing due to lack of response from @dasmikko. Feel free to reopen if problem persists and isn't due to uninitialized git submodules.


bs-config file does not work

I am using the npm package for lite-server. I have tried both bs-config.json and bs-config.js neither seemed to be loaded when running npm run lite.
I found this post:
http://stackoverflow.com/questions/35149408/cant-change-the-base-folder-for-lite-server-in-angular-2-application
They mention this not working for the package installed by npm, which is my experience

which version of lite-server are you using? Until I updated the version used in the angular example app it would not find bs-config.json file.

the config file was introduced in v2

Thanks, I was using: "lite-server": "^1.3.1", taken from the angular2 quickstart guide

Have similar problem with lite-server 2.2.0.
I do get output
"[1] Did not detect a bs-config.json or bs-config.js override file. Using lit
e-server defaults..."
even though I do have bs-config.js file present in current folder.
I think it's caused because I have an error in bs-config.js file.
The check "if (err.code && err.code === 'MODULE_NOT_FOUND')" seems too vague...


Abstracted the persistence logic through repositories

Codecov Report

Merging #63 into master will decrease coverage by 0.06%.
The diff coverage is 99.19%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   98.51%   98.45%   -0.05%
==========================================
  Files         229      246      +17
  Lines        2403     2575     +172
==========================================
+ Hits         2367     2535     +168
- Misses         36       40       +4


func DB#Create can not response the result using Association

Your Question
my struct is this:
type A struct {
    Id int
    Name string
    BId int
    B B
}
type B struct {
    Id int
    Name string
}
xxx to create A a
tx := db.Begin()
result := tx.Create(&a)

if the field Name of B is a unique key in a mysql table, and insert B into table failed but insert A successful, at this time, result Error is nil and affectedRow is 1, we can not get the real response of the inserting B.
gorm skip the error when insert B, after, gorm will insert A
done it have other usage to resolve problem? If yes, I will thanks very much!!!
The document you expected this should be explained
Expected answer
if I can get the error when insert B, I will rollback the all transaction.

It will return error and affectedRow is 0 in lastest version.
If you still have problems after the upgrade to lastest verion, please reopen it with the full code in the playground


Cannot force Content-Type header after form fields apply

Example
Feature: Test
  Background:
    * configure ssl = true
    Given url 'https://httpbin.org'
  Scenario: Bug 1
    Given path '/post'
    * def forms_1 =
    """
    {
      test: "123"
    }
    """
    And form fields forms_1
    #Not working
    * configure headers = { 'Content-Type': 'application/json' }
    #Not working too, Content-Type always 'application/x-www-form-urlencoded'
    And header Content-Type = 'application/json'
    When method POST
    Then status 200

Thanks a lot for fixing and advice for workaround!
But really pain starts when I want custom or dynamic param in fields.
Feature: Test
  Background:
    * configure ssl = true
    Given url 'https://httpbin.org'
  Scenario: Workaround
    Given path '/post'
    * def dynamic_param = 'abcdef'
    * def forms_1 =
    """
    {
      test: "#(dynamic_param)"
    }
    """
#    Not work, because of content type
#    And form fields forms_1

#    Not work because request do not support params
#    And request '#(dynamic_param)'

#    Work only with custom method, that returns raw string from given map
#    Example of method in Groovy:

#    static String mapToFormFieldsRawString(Map<String, String> m) {
#      List<NameValuePair> params = m.collect { k, v -> new BasicNameValuePair(k, v) }
#      URLEncodedUtils.format(params, UTF_8)
#    }

    And request mapToFormFieldsRawString(dynamic_param)
    And header Content-Type = 'application/json'
    When method POST
    Then status 200

hello there. I think you are doing it wrong, and you first confused me with form field. have you even read the docs ? and examples ? for e.g. this: https://github.com/intuit/karate/blob/master/karate-demo/src/test/java/demo/cats/kittens.feature
if all you are trying to do is submit a dynamic JSON, please just return a Map from your Java method and use it directly. I also suspect that you are using Java un-necessarily - which is a common mistake by folks new to Karate who don't understand it.
If you need any further assistance on this issue, first read the docs and then follow the instructions here: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue

The idea is to send the body 'application/ x-www-form-urlencoded' with the header 'application/json'

is this a negative test case ? because this is not correct HTTP behavior. no body ever needs to do this.
so please do not complain about "pain starts" !
if you need any thing else, make sure you follow the instructions.

Ok) Yes, negative tests. Force header solve the problem :)

I guessed it. just hard-code a string request and please don't try to implement dynamic parameters for this negative test case ! anyway in the next version it will be possible to over-ride the content-type for form field but I not think it was not necessary :|


Versionable don't uses all the required namespaces for foreign tables

Hello,
as exposed for the Archiviable behavior (issue #293), I've got similar problems with the versionable behavior too. In this case it seems that the builder has not declared the foreign versionable peer and queries. I've got a schema like the one below:

    <column name="id" type="INTEGER" required="true" autoIncrement="true" primaryKey="true" />
    <column name="page_id" type="INTEGER" required="true" />
    <foreign-key foreignTable="al_page" onDelete="CASCADE">
      <reference local="page_id" foreign="id" />
    </foreign-key>
    [...]

    <column name="id" type="INTEGER" required="true" autoIncrement="true" primaryKey="true" />
    <column name="page_name" type="VARCHAR" size="255" required="true" />
    [..]

The behavior works fine until I try to restore from a previous version, because some namespaces are not declared:
use AlphaLemon\AlphaLemonCmsBundle\Model\AlContentVersionPeer;
use AlphaLemon\AlphaLemonCmsBundle\Model\AlContentVersionQuery;

@alphalemon The attached PR should fix the problem. Would you mind testing it?

Hi Francois,
thank you for the fix. I did some tests and at the moment I've still got errors. Tomorrow I would like to make other tests starting from the scratch. I'll let you know

Could you paste the errors you get?

Hello,
yesterday I tried on the database that manages my website, which has not been started with versionable behavior. So I write down a script to try to populate the derived versionable tables from my schema, but it seems that something is wrong because I got some errors noticed in the previous comment.
Today I started from a fresh install of my cms, adding the versionable behavior before installing the database and building the model using the lastest propel master branch, and everything was fine. The built model has all its dependencies, and I could have added some records and return back to previous version. So thank you for the very quick fix!
I take advantage from this discussion to ask you if there are some already existing propel features that could help me to add versionable records on a database created before adding this awesome behavior.

Hi @alphalemon, thanks for your feedback.
You should ask your question on the Propel mailing-list, I'm not sure there are existing stuffs for that, but people may have done that for their own needs.

Hello,
playing with versionable, I noticed that a namespace still misses. Following the documentation, I used this code:
$page = AlPageQuery::create()->findPk(75);
$page->toVersion(1);
foreach ($page->getAllVersions() as $pageVersion) {
echo $pageVersion->getPageName() . "";
}
and this is the error I get:
Fatal error: Class 'AlphaLemon\AlphaLemonCmsBundle\Model\om\AlPageVersionPeer' not found in /home/alphalemon/www/alphaLemon/vendor/bundles/AlphaLemon/AlphaLemonCmsBundle/Model/om/BaseAlPage.php on line 2116 Call Stack: 0.0004 335492 1.
Adding the namespace manually fixes the problem.
Thanks in advance


Bug: Bar chart fails to render when there is more than one data point for the same date with time axis

In my case, I'd like to for it to render the two bars (for whom the x time value is the same for multiple data point) side by side, next to each other, with perhaps the same label repeated or "stretched", as there are now multiple bars for the same time value.
Is there a way to do this?
This issue is an extension of #7577

Not a bug

Please ask questions on StackOverflow: https://stackoverflow.com/questions/tagged/chart.js

If it's a feature, not a bug, please let me know where this behaviour is documented and I can find my own way.
I couldn't find anything so I created this issue, I think anyone in a similar situation would run into this same issue every time until it's addressed (= more issues for something that is not a bug). So, a definitive solution, whether here or in the docs is, IMO the only logical path forward to reduce the probability of such an issue being opened again.

This is due to automatic barThickness calculation that measures min distance between bars. You can specify that manually to make the bars visible.


Fix CaseCheckerRule NullPointerException

Closes #1015

Codecov Report

Merging #1016 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1016      +/-   ##
============================================
+ Coverage      85.1%   85.14%   +0.03%
- Complexity     1036     1038       +2
============================================
  Files           175      175
  Lines          2834     2834
  Branches        473      474       +1
============================================
+ Hits           2412     2413       +1
  Misses          175      175
+ Partials        247      246       -1

Impacted Files
Coverage Δ
Complexity Δ

...src/main/java/de/zalando/zally/rule/CaseChecker.kt
80.15% <100%> (+0.76%)
76 <0> (+2)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8d2b6...39f583f. Read the comment docs.

:+1:

:+1:


error: badSyntax

When issuing requests to clio through RPC, it always returns with error badSyntax. No further details provided.
Reproducible via:
curl -X POST \
  -H 'Content-Type: application/json' \
  -d '{"command": "server_info"}' \
$ADDRESS

This should be fixed in https://github.com/cjcobb23/clio/pull/65. @Mwni give it a try now and confirm that it works.

{"result":{"info":{"complete_ledgers":"68187413-68214624"},"validated_ledger":{"age":7,"hash":"6D46E4AA3F175207E521E7677CDE645B0E890F106C683E95C67F550FDE6653CD","seq":68214624,"base_fee_xrp":1E-5,"reserve_base_xrp":1E1,"reserve_inc_xrp":2E0},"note":"This is a clio server. If you want to talk to rippled, include \"ledger_index\":\"current\" in your request","status":"success","validated":true}}

Yup, fixed. Nice work, @cjcobb23


Add status output message to Cerebri.

Controls the leds and listens to the arming button:
Disarmed:

Safety on: 1 second on, 1 second off
Safety off:  two quick flashes every second

Armed: solid on
Colors:

yellow: unset
blue: cmd vel
red: auto
green: manual


[Need help]: Need to fix 2 failing unit test

Description
Need to fix 2 failing unit test inside CategoriesPresenterTests.kt in PR #5325 . The searchResults method is returning NPE and these tests are thus failing.

Can you assign this issue to me. I would like to finish the unit test.

Thanks for helping @u7452206 it is yours. 🙂

@u7452206 hey, any update on this? I was able to put a fix to the tests but if your fix is better we can take yours as well.

no yet. Still looking at. If you finish, can use yours

@srishti-R Thanks for finding the time to fix these!
@u7452206 I will now close this issue, but feel free to improve the unit tests or add more tests related to this feature. Thanks! :-)


error when not specifying the offset

I am recieving the following error when not specifying the offset while consuming.
Unexpected EOF while reading 4 bytes from stream (no data)
this is in the following function:
 public function fetchOffsetResponse()
    {
        $result = array();
        $dataLen = self::unpack(self::BIT_B32, $this->stream->read(4, true));
        $dataLen = array_shift($dataLen);

I have also tried specifying an offset but no data seems to be returned from the topic. is there a specific option for the offset to return the latest data?
I believe that you can fetch the current offset from kafka and have it handle the offsets. you should only need to specify whether you want the beginning or end offset.

default read newest message


Throttle calls to a custom configuration loader

Many custom configuration loaders will retrieve the
configuration from an external resource. Resque::Pool
asks the loader for the latest configuration roughly
once per second. You may want to reduce load on your
external resource by caching the value, and only
really fetching the latest configuration after a
specific amount of time has passed.
Instead of forcing each configuration loader author
to re-write (and test) this logic, we provide Resque::Pool::ConfigThrottle.
See the spec for full details of its behavior.

This is great!  This composability is exactly direction I was hoping to go with the config loader bits.
I just pushed an (unfinished work in progress) branch where I broke the default config loader down into Static, File, Memoizable, EnvironmentMerged, and then I moved forward from there to make an Overloaded and Redis loader (wrapping the whole thing in Throttled).

Totally agree about the composability. The FileOrHashLoader was obviously awkward - glad you're breaking that up.

I don't have any more time to play with this today, but please see #143 (I renamed some things and changed your API a little bit), #145 (basic ConfigLoaders::Redis implementation), and the 4d8c5aec2f883a6eb37e232d5e286c671e97c854 (the decomposed_default_loader commit) and let me know what you think.


New version: Mozilla.Firefox version 131.0

Created by 🥟 Dumplings in workflow run #8485.

Log
Updated: 130.0.1 → 131.0
Submitting WinGet manifests
Found existing pull requests:
Update: Mozilla.Firefox.DeveloperEdition version 131.0 (131.0b9) - https://github.com/microsoft/winget-pkgs/pull/174514
Update: Mozilla.Firefox.DeveloperEdition version 131.0 (131.0b8) - https://github.com/microsoft/winget-pkgs/pull/174138
Update: Mozilla.Firefox.DeveloperEdition version 131.0 (131.0b7) - https://github.com/microsoft/winget-pkgs/pull/173824
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

@ItzLevvie are you able to approve this?

Close with reason: Duplicate of #176350;


Add internal logging capability

For debugging purposes, it would be cool to log all "internal" operations of Moxy, such as presenter attachment and detachment, and ViewState commands execution. Maybe we should allow the user to implement some Logger interface and pass it somewhere to Moxy configuration.

/assign

Hey @alaershov, I would like to work on this, can you assign?

@antonio-pedro99 sure, here you go!

@alaershov I do not think it is practical the user passing Logger interface in the Moxy configuration. There should be default behavior, just like what happens with fragments and activities.
The thing is, can user's override these internals operations? If so, maybe the user can use their own logger.  View?  Some of them are too critical to allow change, some are kapt-generated code. Do you have an example in mind of how would it look in Moxy? Like a sample of code, if this feature was already available.
Passing an event listener interface to the library is quite common practice, here is an example from OkHttp: https://square.github.io/okhttp/features/events/#eventlistener
I was thinking of a similar approach for this issue, but I'm open to suggestions. Also, before implementing the feature let's maybe discuss some requirements? A list of events to log would be useful for thinking how to log them :)

@antonio-pedro99 I think overriding the internals of the library is not always a good idea. Some of them are too critical to allow change, some are kapt-generated code. Do you have an example in mind of how would it look in Moxy? Like a sample of code, if this feature was already available.
Passing an event listener interface to the library is quite common practice, here is an example from OkHttp: https://square.github.io/okhttp/features/events/#eventlistener
I was thinking of a similar approach for this issue, but I'm open to suggestions. Also, before implementing the feature let's maybe discuss some requirements? A list of events to log would be useful for thinking how to log them :)


fix: auto height regression fixes

Description

[ ] Default enabled Auto Height for all the widgets except JSON Form widget.
[ ] Made changes as per @marks0351 review changes in the final auto height PR. (https://github.com/appsmithorg/appsmith/pull/18341)
[ ] Disables auto height with limits in modal widget. Fixes #18406
[ ] Disables auto height on Container inside List Widget
[ ] Fixes issue where fixed container doesn't scroll when content exceeds the scrollview
[ ] Fixes issue where containers don't always collapse, no consistency
[ ] Fixes issue where redo doesn't cause auto height computations
[ ] Fixes issue where MainContainer has unnecessary scroll
[ ] Fixes issue where Tabs Widget has unnecessary scroll
[ ] Fixes issue where Tab switching in view mode did not adjust auto height
[ ] Fixes List Widget pagination breaks
[ ] Fixes Form Widget Flicker issues

Fixes #18414
Fixes #18413
Fixes #18399
Fixes #18393
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual
Cypress Test pending

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[NA] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[PENDING] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[NA] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

@ankurrsinghal what is the change here, i see the radio group functionality has changed fully - https://www.loom.com/share/a19fc7f104ff4658a09e7f7d8be6afe5

@ankurrsinghal what is the change here, i see the radio group functionality of inline has changed fully - https://www.loom.com/share/a19fc7f104ff4658a09e7f7d8be6afe5

@dilippitchika reverted the changes.

/ok-to-test sha=bf7aeaf

/ok-to-test sha=a8f695f

/ok-to-test sha=b498598

/ok-to-test sha=4ceecf6


⚠ GitLab Server has degraded performance

In cd07352, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 11669 ms

Resolved: GitLab Server performance has improved in 1d3d8db.


Epic - Security

User Story
As a user of IF I want security so that I can trust that using it won’t create security holes
Scope
LOW - Add an npm audit report when installing plugins

[ ] #626

LOW - Explore running plugin code in a sandbox environment
E.g. https://stackoverflow.com/questions/7446729/how-to-run-user-submitted-scripts-securely-in-a-node-js-sandbox
Consider adding a flat —run-untrusted to allow the execution of code in a trusted environment and make it more explicit to the user that they are taking responsibility for security.

@jawache @jmcook1186 is this epic important to complete before beginning on the Inputs & Outputs? If so, we have an issue for the audit, but running it in sandbox didn't have a great title, so I hadn't created one yet. Let me know what the title of the task could be and I'll create the issue.

Personally I'd be totally comfortable with this getting backlogged - we haven't seen a single bug report with a stackblitz link and we haven't tended to use virtualized environments for reviewing PRs, so I'm not sure there is any real demand for this feature at the moment. There's also nothing stopping people from independently moving their workflow to a sandbox when they feel it's necessary, we just don't have to provide a cli tool to shortcut it right now.
There are far more important UX and DX upgrades in the next epic though, so I'd prefer to move on and make this a nice-to-have or a community-led feature on the backlog than something blocking the next epic.
Wdyt @jawache ?

@jmcook1186 and @zanete I aggree this can be backlogged, but again if the issue is refined then maybe we add a help-wanted label and turn this into a community contribution?


Precision Landing from Offboard

As the title says, I'm looking for a way to initiate precision landing from offboard mode. I have a camera connected to my companion computer which gives the position and attitude of the target to the offboard computer, and that redirects the message to the flight controller. Currently messages of the type "LANDING_TARGET" ( Mavlink #149 ) are being used, so the flight controller can read and use the messages.
The discussion at https://github.com/PX4/Firmware/pull/9050 and the subsequent video of the precision landing at https://www.youtube.com/watch?v=HGX1RccfN1g both seem to use mission mode to initiate the precise landing. In my case that is not easily doable, I basically want to send a command that starts precise landing. The discussion at https://discuss.px4.io/t/visual-precision-landing/2418 suggests doing exactly that, except it is not actually stated HOW or if it actually worked. In the discussions and in the code I saw that precision landing is its own mode, such as offboard or mission modes. Changing from offboard to precision landing mode would be a feasible work-around for me. However, looking through the documentation, I don't see how the modes are actually changed. As in, which Mavlink message is sent with which parameters. I know this must be possible because that is exactly what my companion computer does right now using MAVSDK. However, the same case applies here: looking through the documentation does not show what exactly is sent to change modes.
The next issue is that while trying to force my drone to start a precision landing, I changed the firmware code of the drone to reflect that. I changed most occurrences of "VEHICLE_COMMAND_VEHICLE_CMD_NAV_LAND" to "VEHICLE_COMMAND_VEHICLE_CMD_NAV_PRECLAND" and "VEHICLE_CMD_NAV_LAND" to "VEHICLE_CMD_NAV_PRECLAND" hoping to force it to go into precision landing mode. However, it changed nothing. From the debug messages and the logging I can clearly see that the drone still goes into "VEHICLE_CMD_NAV_LAND" or normal landing. Because I do not use global coordinates, only local coordinates using camera and UWB, I disabled "status_flags.condition_global_position_valid" in src/commander/state_machine_helper.cpp, but it changes nothing. The only thing I have yet to see is if the messages from the camera/companion computer are being accepted by the flight controller. However, according to the companion the messages are at least valid mavlink messages.
I also saw another discussion to exactly this topic a while back, asking for precise landing in offboard mode. However, I can't seem to find it, and the last status of that discussion was that it might be worked on in the future.

@okalachev maybe you can help here?

Hi, you can easily change the mode to precision landing using MAV_CMD_DO_SET_MODE command.
The main mode is MAV_MODE_FLAG_SAFETY_ARMED | MAV_MODE_FLAG_CUSTOM_MODE_ENABLED, the custom mode is PX4_CUSTOM_MAIN_MODE_AUTO (4), the custom sub mode is PX4_CUSTOM_SUB_MODE_AUTO_PRECLAND (9).

Ok so after a month I almost have to give up on this project because it seems my use case is not supported at all. Since I only have local coordinates to work with, precision landing does not work correctly. First of all, without changing the firmware code it does not go into this mode at all. To go into this despite that, I commented out the requirement for valid GPS coordinates in the state machine helper cpp. Because the precision landing works on the auto mode position controller, it apparently only uses GPS coordinates for position control and the local NED coordinates (note: the coordinates have to be in NED frame and not body frame) for more precise control of the latitude and longitude values used for positioning. To generate these coordinates I used the testing mode of the GPS module, but instead of using constant values as output I calculate latitude and longitude in the GPS module by using my local NED coordinates. This way the precision landing controller should be able to work either way.
However, when testing I found two major issues with the precision landing module using this method. First, having a negative value for altitude immediately stops all motors, even if the drone is actually still in the air (even if it has vision of a target). This is also true for normal landing. Since my targets have differing heights, I have to account for negative altitude values, and this does not work. Secondly, this method does extremely weird things with the position setpoints. I noticed that when the landing procedure starts the value of the setpoint using local coordinates cannot be changed anymore. Even when sending landing target messages via camera and onboard controller I cannot influence the value of pos_sp anymore at all. I've tried using mavlink messages #84 and #149 and neither of them does anything. Depending on what I comment out in the precland code, things get even weirder. It can happen that my old setpoint gets carried over to the landing procedure, but then never changes again afterwards, even if the drone is in horizontal or vertical approach and the setpoints should be changing every time. It can also happen that some other point gets chosen between the old setpoint and 0, and then progressively gets smaller. Again, nothing I do changes what these setpoints become.
As far as I am concerned, I can't get precision landing without GPS to work. For me the only way to do this now seems to be through my companion stm32. Luckily I was already able to make MAVSDK and my stm communicate. Now I will try to make the stm control the drone through offboard messages instead of MAVSDK, and simply use that on my PC to give the coordinate information to the stm. By giving a series of setpoints using the UWB and cameras connected to the microcontroller I should be able to approach the target similar as in precision landing, and issue a kill or land command once I think I landed or lose connection to the PC. It seems like any other method using the firmware simply makes no progress at all.

A quick update, I finally found the culprit of my issues. It was in fact a the function in the precision landing horizontal approach state for calculating the new setpoint position. When removing "map_projection_reproject(...)" and replacing that with my own function to calculate new setpoints it seems to work now.


travis3 new diagram

We need to show that master is deployed to two new environments and
heroku now is stage

waiting for staging environment DNS. When that is set we can do manual regression and merge stage changes. When that is complete, merge stage into master and see it show up in both Amazon Amplify and Google Firebase

Looks good. Merging


fix(action): Show and capture one message on same triggered event

Can one of the admins verify this patch?

thanks for the code review. Updated it.


any plans to support the new fluent-ui?

Microsoft has moved from the office-ui to the fairly similar fluent-ui for going forward:
https://developer.microsoft.com/en-us/fluentui#/
As not many au compat ui options out there this one is quite nice!

Sure, I will fix it! I will create a new npm package for au-fluentui.

Fantastic! Thank you.

New repo here https://github.com/magnusdanielson/au-fluent-ui
Npm package here https://www.npmjs.com/package/@dunite/au-fluent-ui
I have sucessfully created a new project with
au new
Then added
au install @dunite/au-fluent-ui
And then added peer dependencies.
package.json looks like this
"dependencies": {
"@dunite/au-fluent-ui": "^0.1.3",
"@types/react": "^16.8.25",
"@types/react-dom": "^16.8.4",
"aurelia-animator-css": "^1.0.4",
"aurelia-bootstrapper": "^2.3.3",
"react": "^16.8.6",
"react-dom": "^16.8.6"

},
After that all controls work. Check out the demo site https://magnusdanielson.github.io/au-fluent-ui/
If you have time to test I will close this issue and bump to 1.0.0 version


[BUG] font wont reset back to default even when font is removed

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?


Koreader integration issues on RM2

Describe the bug
KOReader doesn't go into the background.
To Reproduce
Steps to reproduce the behavior:

Launch rm2
systemctl stop xochitl
systemctl start rm2fb
systemctl start tarnish
Launch KOReader
Close KOReader by  '/opt/bin/rot apps call leftHeld'
Oxide is open as it should, but KOReader still gets the input and various UI elements of KOReader appear on the screen. The effect is still present when I open xochitl. (KOReader messes up xochitl screen and input then).

Expected behavior
The KOReader should stay in the background and not react to touch input while oxide is on.
Screenshots
If applicable, add screenshots to help explain your problem.
Version Information:

Device: RM2
OS: 2.5sth

rm2fb: latest master
tarnish: latest master + suspend patches
koreader: http://build.koreader.rocks/download/nightly/v2020.12-60-gfca87b5_2020-12-29/koreader-remarkable-v2020.12-60-gfca87b5_2020-12-29.zip
Additional context
Add any other context about the problem here.

Xochitl works perfectly fine: when back is pressed it doesn't react to any events.

Works fine on 2.1, closing.


How to export eager model as graph, and how to restore object-based checkpoint which generate by eager mode from estimator

How to export eager model as graph, and how to restore object-based checkpoint which generate by eager mode from estimator

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.


Update text on Elevate widget in template builder

Critical Changes
Changes
Admins will see text in the elevate widget card in template builder notifying them that they should add the payment method field to the template if it has not already been added.
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

work item: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B0000008jPylIAE/view


Missing _variables.scss in download

Missing in the down load!

Hi,
Thank you for the interest in our products. You can find de _variables.scss file in assets/scss/black-dashboard/custom/_variables.scss.
Please let me know if i can help you with anything else.
All the best,
Rares


Group switcher - disable currently chosen group

this changes the group switcher to show the currently chosen group disabled (non-clickable)
also the title was changed from "Select to change to another Group" to "Change to this Group" or "Currently Selected Group"

classic ui PR: https://github.com/ManageIQ/manageiq/pull/6687


Opposite of --add-metadata

Checklist

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2019.04.30
[x] I've searched the bugtracker for similar feature requests including closed ones

Description
I don't want thumbnails and other metadata in my video/audio files, so it would be nice to not download them at all, instead of having to first download them and then later deleting them with another program.
(Reasoning for not wanting metadata: They are harder to change than file names and some media players prefer metadata like "title" over the file name if there is one, making them show unexpected names or even sort based on them. And for example YouTube videos often have clickbait all-caps titles. And some music creators have a weird taste for images, so I don't want their thumbnails.)

Just don't use --add-metadata?  Files from YouTube don't have built in metadata.

Ok, then I take back my YouTube example. But for example I just downloaded some music from Bandcamp and it has metadata, including thumbnails.

youtube-dl does not add any metadata until you explicitly tell it to do so. If the original media already contains metadata you can crop it with any tool of your choice by executing it in --exec.

It definitely does. Please reopen.

The command used for that was youtube-dl -f bestaudio <URL>.

Once again: this metadata is embedded in file itself by bandcamp.


Loosen Dependency Restriction for packaging Version

📥 Pull Request
📘 Description
I’ve encountered an issue where the fixed dependency on packaging version 23.2 in AgentOps (version 0.3.12) causes conflicts with other packages that require a different version of packaging.
Would it be possible to update the dependency to allow a range of versions for packaging instead of fixing it to 23.2? For example, using packaging>=23.0 would provide greater flexibility while ensuring compatibility.
close https://github.com/AgentOps-AI/agentops/issues/555
🧪 Testing
Describe the tests you performed to validate your changes.

Fixed by #561 -- thanks @Wendong-Fan! Planning a release soon


Reimplement win_firefox_restart

It's a pretty big beast.
https://github.com/tridactyl/tridactyl/blob/ede89e683ad880a5bce79278f45737a64bf9a1e2/native/native_main.py#L155

I would've said we could just use native.ff_cmdline, which I tried to fix a few days ago – and it did work at the time –, but apparently (and somewhat unsurprisingly, considering the hacky implementation) that's broken again. It's pretty mysterious – await tri.native.ff_cmdline() returns undefined, while copying the Powershell command string from native.ts and manually using it with tri.native.run works just as it should.
But just in case I ever get that to work 100% of the time, it should make implementing :restart trivial.

I would've said we could just use native.ff_cmdline, which I tried to fix a few days ago – and it did work at the time –, but apparently (and somewhat unsurprisingly, considering the hacky implementation) that's broken again. It's pretty mysterious – await tri.native.ff_cmdline() returns undefined, while copying the Powershell command string from native.ts and manually using it with tri.native.run works just as it should.
But just in case I ever get that to work 100% of the time, it should make implementing :restart trivial.

I think most of that code is concerned with scheduling a task to restart Firefox rather than working out what arguments it was called with.
I think it might be because Windows kills the native process when Firefox exits, which other OSs don't do. But my memory is very hazy on this : )

I think most of that code is concerned with scheduling a task to restart Firefox rather than working out what arguments it was called with.
I think it might be because Windows kills the native process when Firefox exits, which other OSs don't do. But my memory is very hazy on this : )

Yeah, looks like it does. Bah.

Yeah, looks like it does. Bah.

Perhaps we can do it more cleanly with the winlean module?

Perhaps we can do it more cleanly with the winlean module?

I can't immediately think of a good way to do it... I guess what might work quite nicely would be to spawn another instance of the native messenger to which we pass the desired Firefox invocation. We'd have to spawn it using CreateProcessW with CREATE_BREAKAWAY_FROM_JOB, because Firefox kills all the processes in the native messenger's Job. This second instance could then wait for Firefox – or maybe just the first messenger – to terminate and restart Firefox after that. I'm not sure how/whether we can wait on a process that isn't a child, though.

I can't immediately think of a good way to do it... I guess what might work quite nicely would be to spawn another instance of the native messenger to which we pass the desired Firefox invocation. We'd have to spawn it using CreateProcessW with CREATE_BREAKAWAY_FROM_JOB, because Firefox kills all the processes in the native messenger's Job. This second instance could then wait for Firefox – or maybe just the first messenger – to terminate and restart Firefox after that. I'm not sure how/whether we can wait on a process that isn't a child, though.

You can get the parent process ID (
https://gist.github.com/mattn/253013/d47b90159cf8ffa4d92448614b748aa1d235ebe4
), use that to create a process handle with OpenProcess and then use
WaitSingleObject.
That's how you do it with the windows C APIs, either. Nim might provide
wrappers.
On Thu, 7 Jan 2021, 22:20 Rummskartoffel<EMAIL_ADDRESS>wrote:

I can't immediately think of a good way to do it... I guess what might
work quite nicely would be to spawn another instance of the native
messenger to which we pass the desired Firefox invocation. We'd have to
spawn it using CreateProcessW with CREATE_BREAKAWAY_FROM_JOB
https://docs.microsoft.com/en-gb/windows/win32/procthread/process-creation-flags?redirectedfrom=MSDN#CREATE_BREAKAWAY_FROM_JOB,
because Firefox kills all the processes in the native messenger's Job
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#closing_the_native_app.
This second instance could then wait for Firefox – or maybe just the first
messenger – to terminate and restart Firefox after that. I'm not sure
how/whether we can wait on a process that isn't a child, though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tridactyl/native_messenger/issues/5#issuecomment-756422884,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNZA6PLNXVHES6NGPEVP33SYYXUXANCNFSM4VYGM3SQ
.

You can get the parent process ID (
https://gist.github.com/mattn/253013/d47b90159cf8ffa4d92448614b748aa1d235ebe4
), use that to create a process handle with OpenProcess and then use
WaitSingleObject.
That's how you do it with the windows C APIs, either. Nim might provide
wrappers.
On Thu, 7 Jan 2021, 22:20 Rummskartoffel<EMAIL_ADDRESS>wrote:

I can't immediately think of a good way to do it... I guess what might
work quite nicely would be to spawn another instance of the native
messenger to which we pass the desired Firefox invocation. We'd have to
spawn it using CreateProcessW with CREATE_BREAKAWAY_FROM_JOB
https://docs.microsoft.com/en-gb/windows/win32/procthread/process-creation-flags?redirectedfrom=MSDN#CREATE_BREAKAWAY_FROM_JOB,
because Firefox kills all the processes in the native messenger's Job
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#closing_the_native_app.
This second instance could then wait for Firefox – or maybe just the first
messenger – to terminate and restart Firefox after that. I'm not sure
how/whether we can wait on a process that isn't a child, though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tridactyl/native_messenger/issues/5#issuecomment-756422884,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNZA6PLNXVHES6NGPEVP33SYYXUXANCNFSM4VYGM3SQ
.

Thanks! That looks reasonably simple.
I'm not aware of any wrappers in the standard library – though I haven't looked all that hard yet –, but I found a module a few days ago that might have it. I'll see if I can find it again.

Thanks! That looks reasonably simple.
I'm not aware of any wrappers in the standard library – though I haven't looked all that hard yet –, but I found a module a few days ago that might have it. I'll see if I can find it again.

I think this issue blocks releasing the nim native messenger on Windows.
Because we can use platform-specific defaults we don't need to delay the Linux or Mac release.

I think this issue blocks releasing the nim native messenger on Windows.
Because we can use platform-specific defaults we don't need to delay the Linux or Mac release.

Added in #19


[💡 FEATURE] - Menu item to copy URL

Since there's no URL bar, I can't figure out a good way to copy a link to a document. It would be nice to have that as a menu item with a keyboard shortcut.

Would you be able to share a link to the doc by clicking the Share button in the upper right corner? It might be easier and more secure to use Google's method of copying and sharing links.

That would get me a link, but it's several more steps, and I don't need to create a share link in most cases, since I'm either using the link for myself or in a company where everyone already has access. If I'm just in the browser, I hit cmd-L then cmd-c to copy the url. If we added a menu item to copy the url, we could get it down to one shortcut, which would be awesome 😄

Sovled, check pull request. I set it for F8, but we can change it! it simply copies the url fo the current document on your clipboard


Change parameters in Constructors

Parameters in constructors in each Service should be given as a defined types instead of respective values in the types.
e.g., Pass SignatureData instead of alg and sig in CreateSession.

Fixed in ef9765e099f917dae54ba56d6c4a2945ebaf06e5.


URL parsing check and documentation

Raise warning for unstable URL parsing
urllib.parse does not perform any input validation so
its output might be invalid as well. Because host_whitelist
functionality relies on hostnames parsed from URLs, the result of
urlsplit is newly compared with the result of simple regex
parser and If they differ, a warning is raised.

The first round of feedback is addressed in the fixup commit. The URLs that cause the warning to be raised are not allowed anymore.

The last two fixup commits contain:

improved condition with more trust for the new parser
fixed typing
improved test

@hroncok could you please eyeball it before I merge it and release it?


Support for seamless-immutable structure?

This library seems worth to support: https://github.com/rtfeldman/seamless-immutable

Any updates or a roadmap on this?

Added in #122 .


document message create flags

Closes: #1910
Upstream: https://github.com/discord/discord-api-docs/commit/95816a58aec3b04798e77079dee2b271d243ecdd

@itohatweb ✅
Note that I only add flags, nothing else, I just reorder stuff so that it's in the order discord docs looks like at https://discord.com/developers/docs/resources/channel#embed-limits-jsonform-params


Test CI: why wouldn't this work?

I don't actually care that much how this is done, so closing this


How to remove data-testid

Is there any option to remove the data-testid from the build bundle?
Could I use a swc plugin like this: plugin.
If yes, how?

Yeah this probably require to use a plugin. This is not supported ATM, tacked in https://github.com/vitejs/vite-plugin-react-swc/issues/16


Numpy 2 Support

The current version does not run with numpy > 2.
On a clean setup:

pip install numpy
pip install pyedflib

run
import pyedflib

Output
A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.1 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.

Traceback (most recent call last):  File "<stdin>", line 1, in <module>
  File "/opt/miniconda/envs/pyedflib/lib/python3.12/site-packages/pyedflib/__init__.py", line 9, in <module>
    from ._extensions._pyedflib import *
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/miniconda/envs/pyedflib/lib/python3.12/site-packages/pyedflib/__init__.py", line 9, in <module>
    from ._extensions._pyedflib import *
  File "pyedflib/_extensions/_pyedflib.pyx", line 1, in init pyedflib._extensions._pyedflib
ImportError: numpy.core.multiarray failed to import (auto-generated because you didn't call 'numpy.import_array()' after cimporting numpy; use '<void>numpy._import_array' to disable if you are certain you don't need it).

Can you try installing from the main branch? It should already be fixed, bit we still have to make a release

should be fixed now :) try pip install pyedflib --upgrade

No worries! It was already fixed I just forgot to make a release


Adds better error messages when elements not found

Tackles #75
To do

[ ] Define a good error message
[ ] Use assertions for QUnit instead of exceptions
[ ] Add better errors for attribute
[ ] Add better errors for click-on-text
[ ] Add better errors for clickable
[ ] Add better errors for component
[ ] Add better errors for contains
[ ] Add better errors for count
[ ] Add better errors for fillable
[ ] Add better errors for has-class
[ ] Add better errors for is-hidden
[ ] Add better errors for is-visible
[ ] Add better errors for not-has-class
[ ] Add better errors for text
[ ] Add better errors for value
[ ] Add better errors for visitable

This is going to be reimplemented for 1.0. Closing for now


Create pre-upgrade command. Fix minimum-gas-prices repacking unset.

Description
This PR:

Creates the provenanced pre-upgrade command as outlined by cosmovisor documentation. It will update the config files to the new formats and set consensus.timeout_commit to 5 seconds.
Adds an error message to the log if the consensus.timeout_commit is too low.
Fixes an issue where the minimum-gas-prices value was being set to "" when either rewriting a packed config or calling provenanced config pack on an already packed config.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

General comments re: 5s values and floors...
While 5 is what the SDK has used ... Tendermint recommends 1s ... and we have had some success with this lower value.  I wouldn't want to enforce something higher unless we have to.  There is a strong possibility of networks running on a private intranet which might want to leverage the lower value to improve the network performance for low latency workloads.
With this in mind it seems we should take a middle ground here and boost the value to 5 seconds for our public main net ... but preserve the ability to run the lower values (perhaps with a warning (edit: info? given the SDK has removed warn from the logger).

General comments re: 5s values and floors...
While 5 is what the SDK has used ... Tendermint recommends 1s ... and we have had some success with this lower value. I wouldn't want to enforce something higher unless we have to. There is a strong possibility of networks running on a private intranet which might want to leverage the lower value to improve the network performance for low latency workloads.
With this in mind it seems we should take a middle ground here and boost the value to 5 seconds for our public main net ... but preserve the ability to run the lower values (perhaps with a warning (edit: info? given the SDK has removed warn from the logger).

I tweaked the PR a bit. It now only shows the error/warning if it's a mainnet node. It also only shows it if it's less than 2500ms. Also, during pre-upgrade, it'll only get updated under the same circumstances.
I put the log message at the Error level since there's no Warn level and the SDK seems to use Error for lots of things that I'd consider warnings. Also, that way, it's more likely to be seen.
During provenanced init, you can now provide the desired timeout commit. If it's not provided, and it's for a mainnet or testnet node, it'll default to 5s, otherwise 1s.
Basically, all our local chains should still use 1s, but a fresh mainnet or testnet node will get 5s. And only pio-mainnet-1 nodes will see the warning or get their value updated from the pre-upgrade command.


Allow store and coupons to be edited without requiring an image

This PR allows the store owner to edit their store and coupons without requiring an image to be uploaded.
This effects the following pages:

/store/edit POST
/store/coupon/create POST
/store/coupon/\<id\>/edit POST

Even after changing the Haskell code in commit a892c51, it still wasn't working quite right.  An image was always being uploaded even though I didn't have any image selected.
In commit c9388b2, I tried to change the javascript to make this work.  I think I got it working (for /store/edit POST only), but I'm not sure it's the best solution.  @arowM Can you take a look at this and let me know what you think?  If it looks alright, feel free to merge it in to master.  If not, let me know, or push a commit fixing it, etc.

To enhance, I created an issue #137.
@cdepillabout, please check it out and assign yourself if you OK.
For other parts, LGTM!


AQL traversal uniqueness constraints "propagating" to other traversals? Weird results.

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[x] 3.2
[ ] self-compiled devel branch

Mode:

[ ] Cluster
[x] Single-Server

Storage-Engine:

[ ] mmfiles
[ ] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[ ] Linux

[ ] Debian .deb
[x] Ubuntu .deb
[ ] SUSE   .rpm
[ ] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[ ] Windows, version:
[ ] MacOS, version:

this is an AQL-related issue:
[x] I'm using graph features
I'm issuing AQL via:

[x] web interface with this browser:   Firefox  running on this OS Ubuntu:
[ ] arangosh
[ ] this Driver:

I've run db._explain("<my aql query>") and it didn't shed more light on this.
The AQL query in question is:
The issue can be reproduced using this dataset:
data to reproduce issue
Hi, unless I'm missing something obvious, the results of my query involving multiple traversals are weird. I run this query:
FOR h IN habitat
    LET isson = (FOR v, e, p IN 1..100 OUTBOUND h TYPE_OF, ANY SAME_AS
        FILTER p.edges[* RETURN PARSE_IDENTIFIER(CURRENT._id).collection] ANY == "TYPE_OF"
        LIMIT 1 RETURN 1)
    FILTER LENGTH(isson) != 0
    RETURN h.name

and I get the names of my nodes of interest
[
  "AAZ",
  "new",
  "njh",
  "Bois",
  "asdt",
  "Qwer",
  "Iop",
  "yadcdfs",
  "Aqwe",
  "jjuuu"
]

However, if I put this filter in the beginning (the rest being equal):
FOR h IN habitat
    FILTER h.name=='tttrr'      // <- only added this filter
    LET isson = (FOR v, e, p IN 1..100 OUTBOUND h TYPE_OF, ANY SAME_AS
        FILTER p.edges[* RETURN PARSE_IDENTIFIER(CURRENT._id).collection] ANY == "TYPE_OF"
        LIMIT 1 RETURN 1)
    FILTER LENGTH(isson) != 0
    RETURN h.name

I get
[
  "tttrr"
]

How come? Why was this node not included in the results of the first query?
Then I discovered that this has something to do with the uniqueness constraint of the traversal. If, in both queries above, I put OPTIONS {uniqueEdges:'none'}, then yes, I do get the "tttrr" node in the first query, as expected (and other nodes as well)... In other words, it seems that the traversals within a FOR loop are somewhat interfering with each other. I put the data in a gist, see link above. Let me know if you can reproduce this issue - or if I'm missing something obvious!
Thanks and cheers,
Miguel

Should be fixed in 3.1.27 and 3.2.1


Update install.sh

fix error about Linux \r\n

Could you explain under what circumstances the original install.sh script would trigger a \r\n error? We’ve tested it on Linux and Windows WSL, and it seems to work fine.

I am using Linux, didn't have this error. What is your distribution and shell?

It is not about your file but the command git clone. link https://stackoverflow.com/questions/23357145/git-clone-in-different-fileformat


fix(e2e-test) changed pkg.crossplane.io to v1

Signed-off-by: haarchri<EMAIL_ADDRESS>
Description of your changes
fixed e2e-test in provider-aws after https://github.com/crossplane/crossplane/pull/2804
you can see here that the e2e-test is failing:
https://github.com/crossplane/provider-aws/runs/4716896964?check_suite_focus=true#step:12:79

Fixes #
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

We fixed this error and the other one with SetupContainerRegistry in the PR #408 . Should we split this fixes in other PRs or can we just merge the one that I mentioned?

Closing this PR because #408 has fixed this bug 🙂


Gatsby Previews Plugin does not work with categories yet

I think having categories might have complicated things because when I go in and edit a product and then click "Open preview" it takes me to https://build-c5ce65a2-57ea-4ee2-b458-9fff7d8a7f66.gtsb.io/product-slug instead of https://build-c5ce65a2-57ea-4ee2-b458-9fff7d8a7f66.gtsb.io/category-slug/product-slug. It doesn't add the slug for the category the product I am editing belongs to into the URL.

Hi @cmarabate, we've fixed our plugin to cope with the more complicated URLs. Sorry for the inconvenience. If you continue to experience any problems, please contact us.


easier cmd to get node external IP

'kubectl get node -o wide' is an easier command to get external IPs for nodes.

Hey welcome! Thanks for taking the time to create this PR.
I'm not exactly sure that we should replace the precise command with this much more general one. Maybe we could instead add this hint to the already big cheat sheet?

closing PR since the  command suggested was already mentioned.


[µTVM] Zephyr: Fix missing board-specific config file in build dir

Hi,
Could the following small change be reviewed please?
It's necessary to make the build of the libraries (common, utvm_rpc_common, utvm_rpc_server, etc) be aware of board-specific config settings, like per board CONFIG_FPU (since some boards, like mps2, don't have a FPU and currently it's set globally in prj.conf). It's also necessary to move forward the following PR:
https://github.com/apache/tvm/pull/8055
Without that change, for instance, even if CONFIG_FPU=y is set in the board config file (like boards/qemu_x86.conf) the libraries are built against soft-float because CONFIG_FPU=y doesn't take effect and so running some models that rely on float point will fail.
This happens because currently board-specific config files (boards/*.conf) are not
copied from Zephyr project dir to the destination build dir, so
as a consequence the per board configs are not used when building
the runtime libraries, like libcommon. Hence, for instance, it's
currently not possible to set CONFIG_FPU per board since it only
takes effect when it's set in the generic 'prj.con' config file.
This commit fixes it by copying to the build dir, to each lib
dir, the proper .conf for the selected target board. For example,
if target 'qemu_x86' is selected 'qemu_x86.conf' is copied to
the boards/ dir inside the lib dirs, so Zephyr build system can
find it and combine it with configs found in the generic 'prj.conf'.
Thanks & best regards,
Gustavo

@areusch Hi! Any clue if the CI error is legit or not? Seems quite unrelated to my change. I don't have a GPU to try it out locally unfortunately so I'll need a hand to figure it out : )


State cannot be accessed in init hook in Ember 3.5.1

I use ember-redux on a project, and ocassionally I need to make a request from init hook which uses some data from the global state, currently I'm on Ember 3.1.1 and trying to update to 3.5.1, but the problem I've encountered holds me down.
Potentially changing a single line in connect.js fixes the problem:
if (WrappedComponent.hasOwnProperty('extend')) {  ->    if (WrappedComponent.extend) {
Because of when the call to the store is made.
In ember-object connector, it happens before WrappedComponent's init hook,
while for es-2015, es-2019 it happens later.
I've prepared a reproduction of the problem:
https://github.com/BobrImperator/redux-state-in-init

@BobrImperator appreciate you opening this! I've spent a little time today trying to get this fixed without breaking older versions of ember and this seemingly trivial ask has proved to be a surprisingly uphill battle given all the churn es2015 class syntax has seen over the last 12+ months. I'll update you more next week when I take another look at this ;)

Actually, the es-2019 version might work when the state call hook was to be moved above super, although I'm not sure if it might be breaking something.
The es-2015 though seems to be failing because We cannot call the state call before super.
I'm also not sure, but I've read somewhere, that Ember will continue initializing with init, but that's an open topic right now.

@BobrImperator I was able to solve it (even for 2.18 despite what Travis said during the PR build)
https://github.com/ember-redux/ember-redux/pull/182
I'll need to build a fresh 2.18 ember-cli app quick to confirm it's g2g but if so (fingers crossed) I'll publish a new version of this library next week. Can you confirm the master branch of this fixes your use case? I tried to take your example and throw that into the app as a test case (to confirm this is working for EmberObject from ember 2.18+)

I can confirm that this works for 3.5.1 3.6 and latest 3.8.0 Ember!
Sweet, thank you very much!
But I think that the test You've written might not detect a regression to this behaviour, I dunno what the state is in your example, but in mine, I rely on an exception that would be raised when trying to access a object's key, which during init time was undefined before.
That's why in my tests I returned an object from state, and tried to access its values.

@BobrImperator I had a failing test before I made this change so I think we are good :)
I just published v4.0.2 to npm so give that a go when you get time! Thanks again for reporting this!

note: I was able to confirm this version works fine w/ ember v2.15 by upgrading my older TODOMVC app
https://github.com/toranb/ember-redux-todomvc/commits/master

Sadly, the issue is back, but in production instead, it hits the es-2015 connector thus reproducing the problem.
Is moving the core calls before life-cycle hooks a breaking change?
Also worth to notice, that it hits the es-2015 despite component being used in classic way.
I think that also for the es-2015 it would be beneficial to use an init hook as well, since they're still a go to way.


CMakeLists.txt: Remove extra parenthesis

Fixes #333

Coverage increased (+0.1%) to 90.407% when pulling 17f77cf2c66ac5713953873f322b08d464100487 on issue-333 into b23201bb1a566d7e4ea84b76b3dcf2efcc025dac on master.


Add New Playlist button to playlists tab

Add a button on the Playlists tab to create a new playlist.  Maybe replace the existing button that triggers the search bar.
Button should be shown regardless of whether there's an existing playlist.

Completed


Main old

[Farjad Ahmed Khan] https://github.com/farjad-akhan

@farjad-akhan I don't think you should be on the main-old branch, and these commits date back to 2020. Thanks.

@farjad-akhan I don't think you should be on the main-old branch, and these commits date back to 2020. Thanks.

I'm a newbie ,was looking make a PR following the instructions, Thanks for helping out , how do I go about

Please add yourself as described here.
I will close this PR now :) you can open a new one to add yourself.
If you need help please let us know.


Create react app throws No wagmi client found

Describe the bug
No wagmi client found. Ensure you have set up a client.
Here is what i tried with reactjs.
https://codesandbox.io/s/frosty-ace-bglnuw
SDK Version

Version [2.0.0-beta-4]

Same issue here on nextjs

@laohanme do you have repro repository? I was able to re-create this in create react app, but everything runs as expected in our next examples.

@laohanme do you have repro repository? I was able to re-create this in create react app, but everything runs as expected in our next examples.

here the repo,
https://github.com/laohanme/web3modal-nextjs
everything I refer from this link
https://github.com/WalletConnect/web3modal/tree/V2/examples/react

@sibizulu @laohanme Not sure what the root cause is (will chat with wagmi team), but can you guys please test this on previous version of wagmi
"wagmi": "0.8.3" - Note, no ^ here, strict version.
@sibizulu got your example to work using that version

@IljaDaderko 0.8.3 version work for me thanks.

@RyanPai ty, I found out what the issue is, fix will be released in beta.5, we need to make our internal wagmi/core dependency a peerDependency so it works with any version of wagmi

@IljaDaderko Thanks

@IljaDaderko Much appreciate!

@IljaDaderko I'm gettng the same error with both "wagmi": "0.8.3" and "wagmi": "0.8.5" (latest).
import type { FunctionComponent, PropsWithChildren } from 'react'

import { modalConnectors } from '@web3modal/ethereum'
import { alchemyProvider } from 'wagmi/providers/alchemy'
import { chain, configureChains, createClient } from 'wagmi'

import { WagmiConfig, useAccount } from 'wagmi'
import { Web3Modal, useWeb3Modal } from '@web3modal/react'
import { EthereumClient, walletConnectProvider } from '@web3modal/ethereum'

const ConnectorList: FunctionComponent = () => {
  const { open } = useWeb3Modal()
  const { isConnected } = useAccount()

  return (

      {!isConnected && (
        <>

--- or ---

          <button
            onClick={() => open()}
          >
            Custom Button
          </button>
        </>
      )}

  )
}

const Root: FunctionComponent<
  PropsWithChildren & { readonly alchemyID: string }
> = ({ alchemyID, children }) => {
  const chains = [chain.mainnet, chain.goerli]

  const { provider } = configureChains(chains, [
    walletConnectProvider({ projectId: 'REDACTED' }),
    alchemyProvider({ apiKey: alchemyID }),
  ])

  const client = createClient({
    autoConnect: true,
    connectors: modalConnectors({ appName: 'REDACTED', chains }),
    provider,
  })

  // Web3Modal Ethereum Client
  const ethereumClient = new EthereumClient(client, chains)

  return (
    <>
      <WagmiConfig client={client}>{children}</WagmiConfig>
      <Web3Modal
        projectId="REDACTED"
        theme="light"
        accentColor="default"
        ethereumClient={ethereumClient}
      />
    </>
  )
}

Note: ConnectorList is used as the children of Root in this case.

@FedericoBiccheddu Pretty sure this is some kind of lockfile issue where older packages of web3modal are used. Try to add strict versions for beta.5 (i.e. without ^ in package.json version). if that fails, you can also try to delete a lockfile / node_modules to do completely fresh install

Every dep in the project is strict.
  "dependencies": {
	// ...
    "@web3modal/ethereum": "2.0.0-beta.5",
    "@web3modal/react": "2.0.0-beta.5",
	// ...
    "ethers": "5.7.2",
	// ...
    "wagmi": "0.8.3",
	// ...
  }

I delete node_modules, the lock file and the store cache too, but the problem still there.

@FedericoBiccheddu do you happen to have a repository I could look at to dig deeper into this?

This is a private corporate project and cannot give access to it, unfortunately.
Trying to create a sandbox the code works correctly...
I used wagmi before with connectuikit or wagmi standalone and it was working without any problem.
The main difference is that our project is running inside docker with node:18.2.1-alpine and using<EMAIL_ADDRESS>to install the dependencies.
What can I do in order to help you?

Running the project without docker, using directly pnpm run dev results in the same problem.
Deleted folders .next, node_modules, pnpm's store and pnpm-lock.yml too.
I tried to dig and found this comment that explain the possibile cause to my problem: https://github.com/wagmi-dev/wagmi/issues/841#issuecomment-1230240827
TLDR: probabily a combination of using pnpm and wagmi using a local client instead.
Thank you for your time and support.

I can attest that this doesn't work here with PNPM as well.
wagmi == ^0.8.6
@web3modal/ethereum == 2.0.0-beta.7
@web3modal/react == 2.0.0-beta.7
pnpm and next latest

@brieyla1 ty for confirmation. I need to look into pnpm and see how it resolves peerDependencies. Usually this bug occurs when you don't have a related @wagmi/core library installed as part of npm i wagmi or there are 2 versions.
Could you try following please:

Delete node_modules and any .lock files
Try to re-install, but using npm.

Does npm work for you? Will help narrow this down to just pnpm

well since it works for everyone using NPM (including code sandbox) I guess the issue is linked with PNPM, tried it with yarn on an isolated environment and it works.
I can't test it in the full-blown environment as it uses turborepo to the fullest with loads of workspace:* deps. I can't just switch it off
wagmi works though, fixed is using rainbowkit, although I would really like to use the walletconnect web3modal solution. it seems to be a better fit...

@brieyla1 I guess somehow pnpm is not using @wagmi/core package from wagmi inside our @web3modal/ethereum one. So in theory, if you install it separately as a dependency, it should work?
The only issue I forsee here is that there might be clash between @wagmi/core package inside wagmi and one you install manually. So versions for these will have to be exact.
I will look into pnpm more and will see if there are ways for us to make @web3modal easier to use with it 👍

maybe resolutions could help. I'm going to test it on my end of the spectrum.
which version is web3modal using under the hood ?
wagmi@latest?

Usually it uses one from wagmi package, so I'd look in your lockfile to see which version was installed by it.

Problem solved after upgrading to the latest version:
yarn add wagmi@latest @wagmi/core@latest


chore(all): Increase minSdk to 21 on all Android examples

Description
minSdk must be 21 on Flutter  3.22.0 since it is a requirement by integration_test package.
Related Issues

Some Dependabot PRs failed, e.g.: #2939

Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I titled the PR using Conventional Commits.
[x] I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
[x] No, this is not a breaking change.

Well GH Actions is down now :)
Locally seems to work:
$ melos exec
  └> flutter build apk --no-pub
     └> SUCCESS

melos run build:example_android
  └> melos exec -c 6 --fail-fast -- \
       "flutter build apk --no-pub"
     └> SUCCESS

Compilation seems fine, some integration tests failed due to timeouts.
ios integration tests are failing with:
❌ Can get non-null iOS utsname fields (failed)
  ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
  The following TestFailure was thrown running a test:
  Expected: 'iPhone14,7'
    Actual: 'iPhone15,4'
     Which: is different.
            Expected: iPhone14,7
              Actual: iPhone15,4
                             ^
             Differ at offset 7

That should be solved on a different PR.

Going ahead and merging this.


Update test_name for test cases

Updated the test case uploader so that it sends test paths instead of test names.

@ninjinkun I've fixed it now so would you review the PR again?

@ninjinkun I've fixed it now so would you review the PR again?

@shuheiktgw Aha. My concern was unfounded.

@shuheiktgw Aha. My concern was unfounded.

Thank you!

Thank you!


Swift3 Conversion

Fixes #21

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4571cb8). Click here to learn what that means.
The diff coverage is 91.06%.

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage          ?   92.86%
=========================================
  Files             ?       38
  Lines             ?     3057
  Branches          ?        0
=========================================
  Hits              ?     2839
  Misses            ?      218
  Partials          ?        0

Impacted Files
Coverage Δ

Source/Models/BrickAlignment.swift
100% <ø> (ø)

Source/Models/BrickProtocols.swift
0% <0%> (ø)

Source/Behaviors/MinimumStickyLayoutBehavior.swift
100% <100%> (ø)

Source/Models/BrickSectionDataSource.swift
100% <100%> (ø)

Source/Layout/BrickAppearBehavior.swift
100% <100%> (ø)

Source/Behaviors/BrickLayoutBehavior.swift
100% <100%> (ø)

Source/Utils/BrickUtils.swift
71.42% <100%> (ø)

...e/Behaviors/OnScrollDownStickyLayoutBehavior.swift
100% <100%> (ø)

Source/Behaviors/StickyFooterLayoutBehavior.swift
100% <100%> (ø)

Source/Models/BrickModels.swift
95.6% <100%> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4571cb8...33c2dc4. Read the comment docs.


unix: correct misspelling in test output

The TestRlimitAs function has fatal output that uses the word 'suceeded'
that is a misspelling of 'succeeded'.

Found using the misspell linter.
I did not create an issue before opening this, because it is only a misspell in test output.


Naming issue - this module deals with i64, u64, i128, u128 while being names i64

https://github.com/stellar/rs-soroban-env/blob/5695440da452837555d8f7f259cc33341fdf07b0/soroban-env-common/env.json#L145
This might only affect a few people, but to me it seems like the name of this module export should be bigint or something similar that's an umbrella term for i64, u64, i128, u128.

fixed, this is named int now


contribution from Khaled

@khaled-alshamaa
The second paragraph might be redundant based on the rest of the paper, but I kept it in for now with a comment to look at it later. Everything else looks great for the first draft, thank you for getting us started!


haskell: fix removed aliases; fix OfBorg eval

Motivation for this change
Fix master eval. Looks like pkgs.gnome3.gtk doesn't exist anymore, so we need to fix this hackage-packages update.
cc @peti @jtojnar
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I would just fix it manually in before we update the cabal2nix.

See https://github.com/NixOS/cabal2nix/pull/410

Yes, please just commit a fix for the changed reference.

Okay, I fixed eval, but I'm not sure I fixed it correctly. @jtojnar

Otherwise it looks fine.

Thanks.


Amstrad CPC / BIN export from DSK / "Line too long"

Hi !
When I try to export a BIN program from a DSK file (option "Save BIN as") , I can't execute them on my Amstrad CPC 6128 with run command (message error : "Line too long") :(
Export work with other windows app like ManageDsk.
SerialCpc.zip

No Header  : doesn't work
With Header : Work ! :)

Ah, there you go! Glad it's working fine now.


Accessing to Env file from a module

Hi;
I'm trying to read a value from laravel .env file on a vue file...as laravel mix docs says we need just to call :
process.env.MIX_VARNAME
when .env file contains
VARNAME=test
MIX_VARNAME="${VARNAME}"
it's work on laravel main apps.js but if try it on a module folder it's not work (undefined)
I try to require dotenv but same problem
any idea ?

I'll close this as there hasn't been a reply in a while, feel free to comment if needed.


Automated cherry pick of #7776: climc: k8s cluster grafana componet support subpath

Cherry pick of #7776 on release/3.4.
#7776: climc: k8s cluster grafana componet support subpath

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.4@1c3bbb7). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/3.4    #7777   +/-   ##
==============================================
  Coverage               ?    6.60%
==============================================
  Files                  ?      727
  Lines                  ?   130050
  Branches               ?        0
==============================================
  Hits                   ?     8596
  Misses                 ?   120800
  Partials               ?      654

Flag
Coverage Δ

#aFlag
6.60% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3bbb7...7f5124b. Read the comment docs.