[Bug]: Documentation of reading scale & correction form cor file

Summary Description
I'm using a JCZ Fiber laser. I can see in the code where Meerk40t will read in a cor file for scale and lens correction, but I dont see any documentation for the format of that file, other than what I can read in lmc_controller.py. I currently scale my display by fudging the Width parameter in the Balor device setup page since there are no scaling options for this type of  device that I can find.
Additional Details
From other Meerk40t code I've read,  I see the lens correction gui is incomplete/work in progress, but if scale and lens correction is read and used in Meerk40t, then if I had a sample of a valid cor file, I can work to create one for my machine. Does anyone have one they can share?
Crash logs
No response
MeerK40t Version
0.9.4060
MeerK40t Type
Executable
Your Operating System
Linux

Some is known about the format of the .cor file, but the ability to create them from scratch inside MeerK40t was never completed.
A .cor file can be created by one of the CorFile.exe utilities included with the EZCad software on a windows PC. You will need to create one for each lens, since every lens has a unique distortion. The utility will draw a grid on a test material, and then you will need to measure each span, and enter those measurements into the software. That will generate a .cor file which can be copied and used inside MeerK40t.

Thanks Joe! I'll give it a try, I have 2 lenses to work with. I tried using the Markcfg7 file that came with my Laser, but it messed up the engraving area and made the galvos chatter. I didn't see any header in my file like "LMC1COR_1.0" so I thought it may be a new file format, since the code is trying to load a 65x65 table of numbers, but there is no table data in my cor file either.

I'm currently trying to see if I can get any of the CorFile.exe or variants to run in WINE which should work on Linux and Mac, assuming MeerK40t sends the raw grid to the laser. I have not succeeded in getting WINE to run the .exe files yet today, though I'm reasonably sure I had managed to get it working in the past. I will keep working on that.
I do know that we have a capture of the grid it draws already, and MeerK40t could be made to do that part without much trouble.
You only need to enter 16 measurements, and the CorFile.exe software converts those into the full 65x65 table of numbers which is the majority of what's inside the .cor file.

I have a Windows vm to run the exe in, so thats not an issue. I used the Meerk40t console the other day to pull up the correction app, and it did have a button to send the grid I think. Ill try that again. If not, I'll do the Windows bit to get the cor file created, but then Ill work on writing a cross platform CorFile.exe. If I can do that in the one of the languages I program in daily (c or tcl), then I may try doing a python version as my first python app.

The existing widget_corfile does burn the correct pattern and has the gui for entering the measurements for the pattern, but theres just no "write corfile" function implemented yet. So, once I have an understanding of the cor file table generation, that Meerk40t function can be finished in short order.

You'll need to install matplotlib and dependencies for this; but this is a script used to visualize the contents and meaning of a completed .cor file. Just drop the .txt off the end (github wouldn't let me upload a .py directly).
cor_file_viewer10.py.txt

Currently working on an implementation of the write routine.

Thank you joerlane for that viewer. It will be interesting for me to get a feel for whats going on under the hood.
jpirnay: I'm glad to hear that this is on your todo list. I really like the way the current correction screen was designed, it is much more logical than the Ezcad interface.
For the small items that I am engraving at the moment, correction isn't a big deal. One of my lenses is a 430mm with an engraving area of 300x300mm, and engraving something that large  will need correction. I look forward to help test your work in a future beta. I'll try generating a correction file in Windows in the mean time so I have something to compare with.


chore: release 0.15.0

:robot: I have created a release *beep* *boop*
0.15.0 (2022-02-11)
Features

create prebuilt binaries for releases (#72) (351c158)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/contiamo/openapi-generator-go/releases/tag/v0.15.0 :sunflower:


Unable to connect to DC/OS Marathon provider

What version of Traefik are you using?

{
 "GraceTimeOut": 10,
 "Debug": false,
 "CheckNewVersion": true,
 "AccessLogsFile": "",
 "TraefikLogsFile": "",
 "LogLevel": "DEBUG",
 "EntryPoints": {},
 "Cluster": null,
 "Constraints": [],
 "ACME": null,
 "DefaultEntryPoints": [],
 "ProvidersThrottleDuration":<PHONE_NUMBER>,
 "MaxIdleConnsPerHost": 200,
 "InsecureSkipVerify": false,
 "Retry": null,
 "Docker": null,
 "File": null,
 "Web": null,
 "Marathon": {
  "Watch": true,
  "Filename": "",
  "Constraints": [],
  "Endpoint": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
  "Domain": "marathon.mesos",
  "ExposedByDefault": true,
  "GroupsAsSubDomains": false,
  "DCOSToken": "***REDACTED***",
  "MarathonLBCompatibility": true,
  "TLS": null,
  "DialerTimeout": 60,
  "KeepAlive": 10,
  "Basic": null
 },
 "Consul": null,
 "ConsulCatalog": null,
 "Etcd": null,
 "Zookeeper": null,
 "Boltdb": null,
 "Kubernetes": null,
 "Mesos": null,
 "Eureka": null,
 "ECS": null,
 "Rancher": null,
 "ConfigFile": "/Users/wg9059/Downloads/traefik.toml"
}

What did you do?
Attempted to start traefik with a connection to marathon (DC/OS).   The version of the DC/OS cluster is 1.9 (enterprise)
What did you expect to see?
The process start with no errors.
What did you see instead?
ERRO[2017-04-28T16:03:22-05:00] Failed to register for events, 404:
<title>404 Not Found</title>

404 Not Found

openresty/<IP_ADDRESS>

Observing the requests with Charles proxy I can see that it is making a call to the endpoint at http://example.com/v2/events but since this is a DC/OS marathon it should be using http://example.com/marathon/v2/events.  From what I can see in the go-marathon library it looks like it should be automatically adding the /marathon to the path whenever the DCOSToken is present in the config.
If I modify the Marathon endpoint to be http://example.com/marathon instead of just http://example.com then the  error that I get instead is ERRO[2017-04-28T16:05:33-05:00] Failed to create a client for marathon, error: Marathon API error: URI not found: /marathon/v2/apps and by observing the requests through Charles Proxy I can see that it connects to the events stream at http://example.com/marathon/v2/events but tries to get the apps from http://example.com/marathon/marathon/v2/apps.

Thanks for the bug report.
This might already be fixed in the latest go-marathon (specifically, by gambol99/go-marathon#267). I'll take a closer look and report back.

@willgorman I haven't come around digging deeper into the yet; however, what I managed to do was to push an change of Traefik 1.2.3 with just go-marathon and the presumed fix to Docker Hub.
Do you possibly have a chance to give timoreimann/traefik:7129c29 a whirl?

Thanks!  It looks like that does resolve the issue and traefik is able to connect to the event stream and get the apps from Marathon.  Unfortunately, go-marathon appears to be failing to deserialize the responses, which I'm guessing is probably related to some of the schema changes mentioned on https://github.com/gambol99/go-marathon/issues/171 but that'd be a separate issue.

It's probably related to the change in environment variables, specifically secrets. gambol99/go-marathon#252 is probably best related. An in-flight PR is available but hasn't addressed review comments in a while.
Feel free to ping / carry as you see fit. :-)
In your opinion, does it make sense now to release Traefik with an updated go-marathon version? Or would that be valuable only if the deserialization problem got fixed as well?

I tried again after removing any apps using secrets from the cluster and everything worked so it does look like it's related to that issue.   I think the fix from updating the go-marathon version here is probably useful even without the serialization fix, at least for DC/OS users that aren't using secrets in their apps.

@willgorman gotcha, thanks for the feedback.
By coincidence, an update of go-marathon is in order to fix a different issue (see PR 1519). I expect/hope for it to still be included for 1.3, so the upcoming release should fix the problem.

Fixed by 1524. Will be included in the upcoming 1.3.


Updated Golden JSON

This JSON file contains the golden JSON file which has been updated according to our new schema/requirements.

Looks good but I noticed that the last two papers are mostly empty. Not sure if that is an issue.

Do you know if they had the labels and URL? There were 5 mostly empty papers in the original golden.json as I believe there was a decision to keep all data if we were able to; so I kept them if they had at least the URL and the labels, that way someone can easily get the rest of the information as they get the time or inclination to do so.

I don't think they did. It is a good idea to keep them, I think. Isn't there some script that tries to get data for those papers, though?

There's a part of the pipeline that would extract DOIs from AskNature papers if they didn't have them based on the URL. The main part of the script gets the rest of the information based on the DOI. If someone manually gets the DOIs for those papers, they just need to put them in a csv along with the labels, URL and the petalID. The pipeline should update those papers in the golden.json; would be a good test of updating papers via the pipeline.

I might just do that!


Pandas plugin

Note: This is not a part of the refactored version, but I was playing around with making a plugin with the existing code, and decided I might as well contribute for any current users in the meantime.
But basically its a exact wrapper of PandanticBaseModel.parse_df

PandanticBaseModel.parse_df -> filter().
*PandanticBaseModel.parse_df(errors="raise") -> validate(), boolean response.

Other changes:

I added a new test_pandas_plugin.py file.
I updated the docs to show how to use the plugin.
I removed pylint and reactivated safety in the pre-commit. This was done since pylint was conlflicting with isort, and the safety test passes so it might as well be included.

Super simple. This shows it:
from pandantic import BaseModel
import pandantic.plugins.pandas

df1: pd.DataFrame = pd.DataFrame({"a": [1, 2, 3], "b": ["a", "b", "c"]})
class MyModel(BaseModel):
    a: int
    b: str

df1.pydantic.validate(MyModel)  # returns True
df1.pydantic.filter(MyModel)  # returns the same dataframe

# but if we have a mixed DataFrame
df2: pd.DataFrame = pd.DataFrame({"a": [1, 2, "3"], "b": ["a", 3, "c"]})

df2.pydantic.validate(MyModel)  # returns False
df2.pydantic.filter(MyModel)  # returns the filtered DataFrame with only the first row

@wesselhuising all pre-checks passing. Let me know when you have a chance to review.

LGTM. I think we will have to discuss our linting tooling as we move forward but as far I can see, this is perfect for this version at least. Besides linting, we also need to align on howe we would like to standardize writing tests.

@wesselhuising sounds good! Merging.


Sign in Page

Wireframe and Lofi Completed

Added High fi design to the Sign in page
https://www.figma.com/file/P9UFnIxyfuvMkKNkKUWh76/Team-28_Price-Compare?node-id=454%3A102

[Personal contribution to the design]
https://www.figma.com/file/rbEp5SbNKIRyohVPL5NbpH/Chiluba's-Design-File_Team_28_Contribution?node-id=0%3A1


Binary fields values are broken by default

ThumbnailPhoto - is default field in Active Directory, where users photos are stored
https://support.microsoft.com/en-us/kb/292029
activedirectory library by default - converts all buffers to strings.
This brokes binary fields values. To replace string with original binary buffer - I have to add entry parser
entryParser: function(entry, raw, callback){
    if (raw.hasOwnProperty("thumbnailPhoto")){
        entry.thumbnailPhoto = raw.thumbnailPhoto;
    }
}

Would be great to
0. at least notice this in documentation

make some king of flag or separate list of binary fields that should not be converted to strings

activedirectory library by default - converts all buffers to strings.

Technically no, the ldapjs library converts buffers to strings.

at least notice this in documentation

This is noted in the documentation under the section labeled "Custom Entry Parsing".
if you want to manipulate the search entry in a different way or perhaps
augment the search result with additional data, you can pass a custom parser.
This is useful, for example, in case you want to change the objectSid or GUID
which are binary values.

Please send a pull request to improve and update the documentation with additional examples and/or clarification.

make some kind of flag or separate list of binary fields that should not be converted to strings

This is an edge case scenario that the entryParser option was added to handle. The entryParser can be configured globally or on a per call basis. Is that solution not meeting your needs?
One problem with maintaining a list of binary fields is that it is not a truly static list. The Active Directory schema can be extended and customized per domain / installation, so this list would need to be configurable via the config object used at object creation.
Please submit a pull request for review.

Closing due to lack of response / feedback. Please reply or submit a pull request to reopen discussion.


Outlook and other Office apps not found in PowerToys Run

Microsoft PowerToys version
0.56.1
Running as admin

[ ] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Search for Outlook

.
✔ Expected Behavior
Outlook is found.
❌ Actual Behavior
Outlook is not found.
Other Software
Microsoft Office Desktop Apps 16051.14827.20198.0

Failed to reproduce this.
Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!

/needinfo

PowerToysReport_2022-03-09-20-53-08.zip

If it is helpful, I'll install PowerToys on my work PC and try PowerToys Run > Outlook search there, too. I think I have a different version of the Office apps on the work PC.

Also, it occurred to me to hit Enter on that first result, "outlook run command" and when I do that, it does open Outlook. So, that is good. Here is what happens for each other Office app:
Access:

Excel:

PowerPoint:

Publisher:

Word:

Let me know how else I can help! This project is great!

Hi @Right-Turn , what do you get if you try to use the program plugin activation key, which is . by default?
Searching for something like . word, what does it give you?
The program plugin seems to have started correctly and you do have some win32 apps appearing such as in Wordpad.
In which location is office installed in your computer? Are there links to it in the start menu?

/needinfo

Well that's cool, didn't realize there was a program plugin activation key!
I still don't see the Office apps, but I do see only programs, like the aforementioned Wordpad, and PowerToys (Preview) if I type .powerp
I do see all the Office apps in Start when scrolling the list or searching for them:

I'm guessing this has something to do with these being the "Microsoft Office Desktop Apps" version, which might have been installed via the Microsoft Store?

@Right-Turn , trying to wrap my head around this one.
If you right-click the shortcut and select "Open file location", where does it lead you? In my case the shortcut for Outlook is on C:\ProgramData\Microsoft\Windows\Start Menu\Programs.
I wonder if it's behaving differently on your case because it's something different than a normal shortcut.

/needinfo

Hello,
I agree, very odd!
On other applications, I do get an "Open file location" option, but not on my Office apps.

According to your screenshot, I saw some other icons missing too.
How do you install your Office apps? By downloading the exe file or installing from Microsoft Store or other? /needinfo


Framework

Having built the WKZombie project and taken the framework from the Products folder and imported this into my own project. It tells me that WKZombie is unavailable and cannot find the swift class. Have I built your project incorrectly or am I doing something wrong if i want to use this on an IOS project?

Found issue, missing x86_64


Issue when using get_activations

Hi,
I tried to use your example code prior to use this library with my own code. However, I had an issue when I launched the function get_activations from the keract library.
The issue that is raised is: "AssertionError: Not a model or layer!".
I do not why, since the first parameter of function get_activations is a Model object (<keras.engine.training.Model object at 0x7f8c9c1137b8>).
I would appreciate if you could help me out.
Thank you!
Pablo.

@pabcrepe Hi,
Can you share a snippet that I can run to reproduce the error. Thank you!

I used the example code:
import numpy as np
from keras import Input, Model
from keras.layers import Dense, concatenate
from keract import get_activations

# model definition
i1 = Input(shape=(10,), name='i1')
i2 = Input(shape=(10,), name='i2')

a = Dense(1, name='fc1')(i1)
b = Dense(1, name='fc2')(i2)

c = concatenate([a, b], name='concat')
d = Dense(1, name='out')(c)
model = Model(inputs=[i1, i2], outputs=[d])

# inputs to the model
x = [np.random.uniform(size=(32, 10)), np.random.uniform(size=(32, 10))]

# call to fetch the activations of the model.
activations = get_activations(model, x, auto_compile=True)

# print the activations shapes.
[print(k, '->', v.shape, '- Numpy array') for (k, v) in activations.items()]

Moreover, the library version I have installed are:

Numpy 1.18.5
Keras 2.3.1
Keract 4.2.2

I run the code through Google Colab, and it raises the error "AssetionError: Not a model or layer!" when running _get_nodes function from get_activations.
Thank you!

@pabcrepe great catch. Please update the imports from:
from keras import Input, Model
from keras.layers import Dense, concatenate

to
from tensorflow.keras import Input, Model
from tensorflow.keras.layers import Dense, concatenate

That should solve it. I'm going to update the README.

Thank you! It worked!
However, after solving the issue using your example code, I have a new issue using my code. I am loading a saved model which is an object keras.engine.training.Model that was created with a lower version of tensorflow (I think that it was version 1.14), and therefore, it cannot be used as a parameter in the get_activations function.
Do you know how I could convert this saved model to an object tensorflow.python.keras.engine.training.Model without modifying and training the model again? Is it possible?
Thank you again!

Solved. It was very easy. If I load the model m, I have to write:
from tensorflow.keras import Model

a = Model(m)

Now I have other issues with the inbound nodes of the loaded model =)

Yes replace keras by tensorflow.keras everywhere =)


SERVFAIL looking up TXT for _acme-challenge.remcam.io

Hi,
Thank you for the script.
I have been trying Certbot manually and using your script.
While it is running, Route 53 shows the TXT being created AND removed.
However, it seems that Route 53 will not allow queries for the TXT record.
The script produces this:
"Failed authorization procedure. nginx.remcam.io (dns-01): urn:acme:error:connection :: The server could not connect to the client to verify the domain :: DNS problem: SERVFAIL looking up TXT for _acme-challenge.nginx.remcam.io, remcam.io (dns-01): urn:acme:error:connection :: The server could not connect to the client to verify the domain :: DNS problem: SERVFAIL looking up TXT for _acme-challenge.remcam.io
"
Any idea what is going on?

no idea, sorry. 🙇

Banging my head against the wall with this same problem

same problem

resolution: https://stackoverflow.com/questions/37533568/new-domain-is-both-registered-with-and-hosted-at-aws-route-53-but-resolution-fai/37534217#37534217


Truncate length of CosmosDb key to max of 255 chars

This is a Javascript port of the fix for botbuilder-dotnet#1197 as represented in [this PR] (https://github.com/Microsoft/botbuilder-dotnet/pull/1370)
Description
Cosmos DB has a max key length of 255 chars. This was sometimes exceeded.  This change detects keys with a length of > 255 chars and truncates them, taking special care to create a unique key by appending a hash of the original value to the key.
Testing
Unit tests have been included.

Pull Request Test Coverage Report for Build #1938

11 of 11 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 84.219%

Totals

Change from base Build #1936:
0.03%

Covered Lines:
2833

Relevant Lines:
3241

💛  - Coveralls


Welcome DIGIT 110 collaborators!

All DIGIT 110 students: please respond to this post to request me to add you (your GitHub account) to our textEncoding-Hub repo! Identify yourself and try writing something in GitHub markdown, too. :-)
<hello world="digit-110">Welcome to the textEncoding-Hub</hello>

My username is @03lizchavez. @ebeshero please add me as a collaborator to this DHClass-Hub

This is Reece Cullen, please add me.

this is charlie vazquez digit 110

My user name is @ceq5032 , @ebeshero please add me as a collaborator.

My username is @HadleighJae. @ebeshero add me as a collaborator to this!

My username is TylerDollard. @ebeshero  please add me

My username is MadisonSciarrillo. @ebeshero please add me

My username is VocaloidOtaku39. @ebeshero please add me

My username is SonicSpaceFan025. @ebeshero Please add me as a collaborator!

My username is VocaloidOtaku39. @ebeshero please add me

Its Tyler Gaydos, username @gylertaydos. Please add me, @ebeshero

My username is @creaturepsu @ebeshero please add me

I am George Koncerak. My username is @GKon26. @ebeshero please add me

My username is GarrettStroupe. @ebeshero , Please add me as a collaborator.

<add="collaboratorPlease">This is Mistie McColm! My username is @MystKitteh, please add me when you have time!</add>

My username is @nhammer514 . @ebeshero Please add me as a collaborator!

Its Justin Banko. My username is @J-Banko . @ebeshero please add me as a collaborator.

My username is @03lizchavez. @ebeshero please add me as a collaborator to this DHClass-Hub

All DIGIT 110 students: please respond to this post to request me to add you (your GitHub account) to our textEncoding-Hub repo! Identify yourself and try writing something in GitHub markdown, too. :-)
<hello world="digit-110">Welcome to the textEncoding-Hub</hello>

My username is hsosia1 @ebeshero  Please add me as a collaborator

Lauren McCurdy, username @lgmccurdy, @ebeshero please add me as a collaborator.

It's Sam! My username is @sammoniot. @ebeshero please add me as a collaborator.

It's Matthew, My username is @mew-II. @ebeshero please add me as a collaborator.

This is Jessica Salemme @jvs7215
Please add me as a collaborator to the textEncoding-Hub repo! @ebeshero


Drag and Drop: Distinguish a click event from a drag event

Feature Description
I came to the Angular drag and drop from Dragula which supports distinguishing click from drag.
Dragula: "Click or Drag! Fires a click when the mouse button is released before a mousemove event, otherwise a drag event is fired. No extra configuration is necessary."
https://bevacqua.github.io/angularjs-dragula/
Maybe this already exists but I couldn't find any documentation indicating as much.
Use Case
While dragging allows you to add the item in a specific location, clicking would just add the item to the end of the list.

By default the CDK is set up so that dragging won't start unless the user puts their pointer down and drags for at least 5 pixels so you should be able to bind a click event directly. You can tweak the threshold using CDK_DRAG_CONFIG injection token.

Closing since there hasn't been any feedback in a while.


[tool_crash] FileSystemException: Exists failed, OS Error: The device is not ready., errno = 21

Command
flutter create learn

Steps to Reproduce

...
...
...

Logs
FileSystemException: Exists failed, OS Error: Le périphérique n’est pas prêt.
, errno = 21
#0      _Directory.existsSync (dart:io/directory_impl.dart:94:7)
#1      ForwardingFileSystemEntity.existsSync (package:file/src/forwarding/forwarding_file_system_entity.dart:45:33)
#2      ForwardingFileSystemEntity.existsSync (package:file/src/forwarding/forwarding_file_system_entity.dart:45:33)
#3      _templateImageDirectory (package:flutter_tools/src/template.dart:304:79)
<asynchronous suspension>
#4      Template.fromName (package:flutter_tools/src/template.dart:77:38)
#5      CreateCommand._renderTemplate (package:flutter_tools/src/commands/create.dart:791:46)
#6      CreateCommand._generateApp (package:flutter_tools/src/commands/create.dart:671:29)
#7      CreateCommand.runCommand (package:flutter_tools/src/commands/create.dart:436:37)
#8      _rootRunUnary (dart:async/zone.dart:1198:47)
#9      _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#10     _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#11     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#12     Future._propagateToListeners (dart:async/future_impl.dart:725:32)
#13     Future._completeWithValue (dart:async/future_impl.dart:529:5)
#14     Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:567:7)
#15     _rootRun (dart:async/zone.dart:1190:13)
#16     _CustomZone.run (dart:async/zone.dart:1093:19)
#17     _CustomZone.runGuarded (dart:async/zone.dart:997:7)
#18     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1037:23)
#19     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#20     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#21     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#22     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)

[✓] Flutter (Channel stable, 1.22.6, on Microsoft Windows [version 10.0.18363.1379], locale fr-FR)
    • Flutter version 1.22.6 at F:\flutter
    • Framework revision 9b2d32b605 (5 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\hp\AppData\Local\Android\sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[✓] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 44.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[✓] VS Code (version 1.44.1)
    • VS Code at C:\Users\hp\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.12.2

[✓] Connected device (1 available)
    • SM A217F (mobile) • <IP_ADDRESS>:5555 • android-arm64 • Android 10 (API 29)

• No issues found!

Flutter Application Metadata
No pubspec in working directory.

@CoolBa98
given https://github.com/flutter/flutter/issues/69154 I assume that the error translates in
[tool_crash] FileSystemException: Exists failed, OS Error: The device is not ready., errno = 21

Flutter Application Metadata
No pubspec in working directory.

can you provide your full flutter run -v making sure you are in your app folder

Hi @CoolBa98
From which directory you're executing flutter create learn?

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


clarify what is UB

Also add some missing cases

I think the str requirement isn't quite correct. As I understand it: the str must be valid bytes any time a string processing function is called on it, but during your own unsafe blocks it can temporarily be invalid the same as a the fields of a Vec can temporarily be invalid as long as you fix it all by the end of the unsafe block.

Separate post since it's a separate issue and much less prone to discussion:

the NonNull and NonZero types must not be 0

I think the str requirement isn't quite correct. As I understand it: the str must be valid bytes any time a string processing function is called on it, but during your own unsafe blocks it can temporarily be invalid the same as a the fields of a Vec can temporarily be invalid as long as you fix it all by the end of the unsafe block.

I agree but that seems like a discussion separate from this PRs.

the NonNull and NonZero types must not be 0

Good points. We have some more such types inside rustc and nightly code can define their own if they enable feature(rustc_attributes).

NonNull and NonZero are again library contracts, and not intrinsic to the language, afaict.

So is the str contract. Either it has to get out of the list or they have to be in the list.

I take it back:

NonZero/NonNull is definitely a Validity Invariant, while "must be utf8" is either a Validity or Safety invariant (probably safety).
So it's definitely insta-UB to make a zero NonZeroFoo the same as it is to make a bool that's not 0 or 1.
So they definitely need to be in the list even if str is allowed to be taken off the list for being "only" a safety invariant.

Unfortunately the description doesn't currently talk about validity invariant vs safety invariant, which is maybe a bigger change than this PR was setting out to clean up. However, I think that's the best way for this part of the book to move towards.

re: str
My understanding is that constructing an invalid str is technically insta-UB, just like bool. Although it's very implausible for the compiler to detect this or use it productively. Has that changed? Is the stdlib or something else actively relying on transiently invalid strs? But more importantly, str is a language primitive, and not something the stdlib cooked up.
re: NonZero
That's a good point on them being insta-UB to mess up. I guess in my mind they're still just library wrappers around some deeper concept that we have simply refused to stabilize. I think I would rather appeal to some more abstract concept like "producing an invalid library type that defines custom invalid values, like NonZero"

The fate of str is being discussed here: https://github.com/rust-lang/unsafe-code-guidelines/issues/78
That said, I think this whole page needs to back up a moment, talk about Safety Invariant vs Validity Invariant, and then talk about all major core types in terms of those definitions.

That said, I think this whole page needs to back up a moment, talk about Safety Invariant vs Validity Invariant, and then talk about all major core types in terms of those definitions.

To do that we pretty much have to RFC those notions. I think we can do an update that improves the docs without going through all of that.
So, I agree that should happen eventually -- but we are talking about a timescale of months here.

That's a good point on them being insta-UB to mess up. I guess in my mind they're still just library wrappers around some deeper concept that we have simply refused to stabilize.

In some sense that's true, and the deeper concept currently has the name rustc_layout_scalar_valid_range_start. But I did not want to mention that here.

So, in that case I think my question becomes... is Rustonomicon itself RFC controlled or informal information? Is the information "how it works today" or is it "stable for all time"?
If it's not RFC controlled stable, just a best effort to document the innards of Rust as it exists today, I don't see the harm in pointing at even draft definitions, assuming that the draft is also its own best effort, if that gives people a much better way to talk about when the UB will happen to them.
The concept of a Validity Invariant and how it's insta-UB to set x: bool = transmute(2); even if you never look at it, compared to a Safety Invariant where you can call Vec::set_len(&core::usize::MAX) and it's fine until you use the vec wrong is extremely teachable because it gives names to use to talk about things, so students can ask about what they really mean when they have a question.
Either way, we don't need to add all that in this PR right now, but I'd like to know how official and immutable Rustonomicon is trying to be, and where it lives compared to the Reference and the UCG.

The Rustonomicon is non-normative and exists primarily to allow people write correct programs. The most important thing is that if we say "this is OK to do" then we are in fact correct. It is perfectly fine if we say that you can't do something if you in fact really can. In particular, the world cannot wait in baited breath for the UCG team to formalize the entire language (a hard and time-consuming task), so the nomicon conservatively declares things to be UB which might not be.
In some places we have taken shots on calling things Correct that are ultimately declared Wrong or dubious (e.g. access-based validity). Ideally, this is based on Real Things The Stdlib Does. At least in those cases we're probably not going to misoptimize you, and hopefully the fact that it's wrong will cause enough of a ruckus in the stdlib for it to become A Well-Known Issue.
 But also it might be good in some places to be over-broad just as a matter of clarity.
Talking about Validity vs Safety (or whatever) does indeed sound within scope of the rustonomicon. I'll need to think about it.

I think this resolves the open discussions.
How to incorporate the validity/safety invariant thing seems to me to be a topic for a separate PR.

Reminder to also copy this PR onto the reference after it's merged here.

@Havvy Oh, you mean for https://doc.rust-lang.org/stable/reference/behavior-considered-undefined.html ? I thought that I had seen another "UB list" somewhere but could not remember where.
Is there any good reason to even have two lists?

Ideally, the reference will become less generally PR-able and drifts towards being fully normative over time.
At the moment, the reference is just as non-normative as the Nomicon and UCG, so there's not a big deal.

In fact the nomicon looks more normative because the reference has all these big fat red warnings everywhere.^^
But I was mostly concerned about having to keep the lists in sync.

I still think that the bullet point

Dereferencing (using the * operator on) null, dangling, or unaligned references or raw pointers

Needs to remove the word "references". Line 25 already lists null/dangling/unaligned references as UB, so if you have one to de-reference you're already off the edge of the map.

My thinking was that it is better to cover a case twice than to forget one.

"It wouldn't say that you can't dereference them if you weren't even allowed to have them, it's fine"
"dude what about the list a few lines down?"
"Look it wouldn't talk about unaligned references if they were impossible, so I'm not gonna change it"
when this conversation inevitably happens I'm gonna link them this PR thread ;3

When we inevitably remove a UB clause because we think it is unreachable, but in fact it isn't, I'm going to blame you. ;)

But in the end I could live with either way here, so I'll just wait for what @Gankro thinks.

the "schtick" of this page is "wow there's not much intrinsic UB you need to know about, what a simple language" so I'd prefer a minimal and orthogonal definition 😊

Okay, done that.

In terms of making sure we definitely do not call out "too little" UB, there are still some things coming to my mind that we then might want to add, somehow:

We do not talk about "fat references" and what the requirement on the metadata part of them is. See https://github.com/rust-lang/unsafe-code-guidelines/issues/166.
let u8 = mem::uninitialized(); might be UB if we decide against allowing uninitialized integers.
References, beyond not dangling, might actually have to point to valid data. In particular there is some desire for making producing an &! UB.

Okay I think this now covers any UB that primitive operations (as opposed to unsafe fn/intrinsics) can cause.

@Gankro any update on this?

As discussed in zulip, with the introduction of &raw i believe it becomes necessary to explicitly define that it's UB to write to "read only" memory (immutable statics that don't contain UnsafeCell), as the pointer aliasing rules seemingly no longer cover that issue.
As always I would prefer that this case is actually well-defined (as there is a very reasonable safe behaviour on all major platforms with default configurations -- fault and crash). But I am sympathetic to this being potentially hard to properly define/support/guarantee.
Also it's just unclear to me how to define this in a clear way. I'm not 100% comfortable with just dismissing/ignoring the existence of readonly memmap'd pages, as this feels like a very important thing to elaborate on.

As discussed in zulip, with the introduction of &raw i believe it becomes necessary to explicitly define that it's UB to write to "read only" memory (immutable statics that don't contain UnsafeCell), as the pointer aliasing rules seemingly no longer cover that issue.

Not only statics:
let x = 3;
unsafe { *(&raw x as *mut i32) = 42 };

does not violate any pointer aliasing rules either AFAICT, yet I feel that 3 can be put in read-only memory.

As always I would prefer that this case is actually well-defined (as there is a very reasonable safe behaviour on all major platforms with default configurations -- fault and crash). But I am sympathetic to this being potentially hard to properly define/support/guarantee.

Whether faults, crashes, etc. exist depends on the target. The proper thing to do here would be to abort, which on some targets would just loop forever.
I don't know of any target for which this would be cheap, e.g., most targets just SIGSEV on this, and I don't think it would be ok for the Rust runtime to install a signal handler for these and turn those into aborts, in most cases we can't tell where the SIGSEV is coming from. Even if we did that, the user can replace our signal handler, so I don't think we could guarantee an abort even on "nice" targets.
On targets that do not support read-only memory and just put statics into normal memory, we probably would need to check whether each write access the memory of a static at runtime to be able to abort. Optimizations might be able to, in some cases, conclude that a pointer never points to a static, but it feels like a long shot.
We don't even guarantee that a stack overflow aborts the program if it happens in safe Rust. A write to an immutable variable cannot happen in safe Rust, so all of this would feel like too much trouble for something that's inherently unsafe anyways (pointer dereferences).
This doesn't mean that we shouldn't try to make the program terminate ASAP if a write to an immutable variable happens - undefined behavior allows us to do anything, including emitting a nice error message. I have no idea how we could guarantee that such a things happens without adding overhead.

Also it's just unclear to me how to define this in a clear way. I'm not 100% comfortable with just dismissing/ignoring the existence of readonly memmap'd pages, as this feels like a very important thing to elaborate on.

The functions of GlobalAlloc and Alloc state their safety invariant, which tells you what you are allowed to do with the memory they return.
I don't see how mmap would be any different than, e.g., the following function foo:
// You can only read from foo() if the integer
// representation of the pointer is `42`.
int8_t* foo();

If you do an FFI call, you are on your own. Read the docs, hope that they are correct, and do what they say. Even for mmap, dozens of OSes implement it, all of them with custom extensions. I don't see what could we possibly say about it here, nor how that would be any more useful to users than "read the docs".

as the pointer aliasing rules seemingly no longer cover that issue.

I think they can -- and in fact, Stacked Borrows does. But you may not like the way this happens.
@gnzlbg

does not violate any pointer aliasing rules either AFAICT, yet I feel that the behavior of this code is undefined.

I think if this is UB it must be through pointer aliasing rules. And, see above -- Stacked Borrows makes that happen.

(we are going to punt on the read-only memory issue for now since &raw doesn't exist yet)

mutating a non-mut binding because you took a shared borrow on it and then use it as a unique borrow must violate some rule somewhere, but I'm also failing to recall exactly where such a thing is already written.

@Gankra thanks for all your feedback!
Btw, have you come to a conclusion on the issue of duplicating the list between here and the reference?

I think it's fine/good for now, as it fits the structure of the book right now, but in the fullness of time that might change.


Potentially unwanted behaviour in ReplaceIgnoreCase

The extension method  public static string ReplaceIgnoreCase(this string input, string pattern, string replacement) in src/TinyHelpers/Extensions/StringExtensions.cs is accepting a pattern parameter and is using is as a Regex to perform the case-insensitive replacement. However, the name of the method doesn't explicitly say that a regex will be used, and this might lead to potential unwanted results with some specific inputs. A possible implementation might be a facade to the method public string Replace (string oldValue, string? newValue, StringComparison comparisonType); where the comparisonType is StringComparison.OrdinalIgnoreCase, as it was done for the other methods in the same class, or sanitizing the pattern input with Regex.Escape. The Replace method overload that accepts the comparisonType in the string class is not available in netstandard2.0 but is part of netstandard2.1.

Sure! here is an example done in net7.0:
using TinyHelpers.Extensions;

<EMAIL_ADDRESS>".docx"));
<EMAIL_ADDRESS>".docx", StringComparison.OrdinalIgnoreCase));

An user would expect the two printed lines to be the same, but the application actually prints
.docx.docx
/path/to/file.docx

By re-implementing the method as follows, it can resolve the problem in a netstandard2.0 compatible way:
public static class StringExtensions
{
    public static string ReplaceIgnoreCase(this string input, string oldValue, string newValue)
        => Regex.Replace(input, Regex.Escape(oldValue), newValue);
}

OK, I got the point. So, can you make a Pull Request? ;) And perhaps you can also add a test in the Tests project ;)

Published #138


wrong control check for <IP_ADDRESS>

data: value should be 0 not 2

name: "SCORED | <IP_ADDRESS> | PATCH | (L1) Ensure 'User Account Control: Behavior of the elevation prompt for standard users' is set to 'Automatically deny elevation requests'"
win_regedit:
path: HKLM:\Software\Microsoft\Windows\Currentversion\Policies\System
name: ConsentPromptBehaviorUser
data: 0
type: dword
when: rule_2_3_17_3
tags:

level1-domaincontroller
level1-memberserver
rule_<IP_ADDRESS>
patch

Addressed with PR#24 and release 1.2.1


sqlite3.OperationalError: database is locked

!python -m paperetl.file paperetl/file/data paperetl/models
get the following error:
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
- Avoid using tokenizers before the fork if possible
- Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
Traceback (most recent call last):
File "/anaconda/envs/azureml_py38/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/anaconda/envs/azureml_py38/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/file/main.py", line 11, in
Execute.run(
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/file/execute.py", line 176, in run
db = Factory.create(url, replace)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/factory.py", line 36, in create
return SQLite(url.replace("sqlite://", ""), replace)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/sqlite.py", line 104, in init
self.create(SQLite.ARTICLES, "articles")
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/sqlite.py", line 198, in create
self.cur.execute(create)
sqlite3.OperationalError: database is locked

after I kill the process related to sqlite, run again, but get another error:
huggingface/tokenizers: The current process just got forked, after parallelism has already been used. Disabling parallelism to avoid deadlocks...
To disable this warning, you can either:
- Avoid using tokenizers before the fork if possible
- Explicitly set the environment variable TOKENIZERS_PARALLELISM=(true | false)
Traceback (most recent call last):
File "/anaconda/envs/azureml_py38/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/anaconda/envs/azureml_py38/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/file/main.py", line 11, in
Execute.run(
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/file/execute.py", line 176, in run
db = Factory.create(url, replace)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/factory.py", line 36, in create
return SQLite(url.replace("sqlite://", ""), replace)
File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/paperetl/sqlite.py", line 113, in init
self.sindex = int(self.cur.execute(SQLite.SECTION_COUNT).fetchone()[0]) + 1
sqlite3.OperationalError: no such table: sections

does anybody can help that?

I would delete everything from paperetl/models and try again. The database locked error would only happen if another process was accessing it. I would make sure there isn't multiple instances of the paperetl process running.

the size is 0

Do you have data in paperetl/data? It seems like nothing was processed.

Closing this issue due to inactivity. Please re-open or open a new issue if there are further questions.


Generate Card Hash method

Hey, I've implemented the card_hash method in my python project, but I'm not sure where to implement it in the library, could someone please enlighten me?

hello @Nixsm , not sure, but i think u can insert it into https://github.com/pagarme/pagarme-python/blob/master/pagarme/card.py

@Nixsm could you send a PR?


bazel build failure of current master in Docker container due to contrib/lite

Building current GPU version of master branch tensorflow/tensorflow@31b79e42b9e1643b3bcdc9df992eb3ce216804c5 fails in Docker container, saying
/usr/bin/ld: warning: libcuda.so.1, needed by bazel-out/host/bin/_solib_local/_U_S_Stensorflow_Scc_Cops_Sdata_Uflow_Uops_Ugen_Ucc___Utensorflow/libtensorflow_framework.so, not found (try using -rpath or -rpath-link)

and I find that it is due to contrib/lite: when I comment out the related dependencies in tensorflow/tools/pip_package/BUILD, the build success.
I know this error is typically solved when I create a soft link inside the container before to build (c.f. #10776):
RUN ln -s /usr/local/cuda/lib64/stubs/libcuda.so /usr/local/cuda/lib64/stubs/libcuda.so.1

but this time, it doesn't help.

same problem.

Can you give an exact sequence of commands to reproduce this?

Here is my Dockerfile. My Docker version is 17.09.0-ce.
If I comment out the commented "RUN"s, the build success.
 The error message is:
10 errors detected in the compilation of "/root/.cache/bazel/_bazel_root/68a62076e91007a7908bc42a32e4cff9/execroot/org_tensorflow/tmp37f_7470eca8858f65d2/tmpxft_00005dc5_00000000-6_resampler_ops_gpu.cu.cpp1.ii".
ERROR: /tensorflow/tensorflow/contrib/resampler/BUILD:51:1: output 'tensorflow/contrib/resampler/_objs/python/ops/_resampler_ops_gpu/tensorflow/contrib/resampler/kernels/resampler_ops_gpu.cu.pic.o' was not created
ERROR: /tensorflow/tensorflow/contrib/resampler/BUILD:51:1: not all outputs were created or valid
Target //tensorflow/tools/pip_package:build_pip_package failed to build

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.

This wasn't happening when I tried to replicate it just now -- the file had other errors. Are you using one of our containers?

@angersson Now it's already more than a month ago, thus I'm not sure whether this is still a valid issue. If you know any later master commit hash (later than tensorflow/tensorflow@31b79e42b9e1643b3bcdc9df992eb3ce216804c5) that doesn't have this issue, can you please mention that? Thank you very much.

I can confirm this is also an issue for me, building with CUDA 9.1 and TF 1.5.
I'm building TensorFlow 1.5.0 from source using this guide and I can only resolve the error with the above sed commands, i.e.:
sed -i '/toco/s/^/#/' tensorflow/tools/pip_package/BUILD
sed -i '/toco/s/^/#/' tensorflow/tools/pip_package/build_pip_package.sh

For clarity, the error I'm getting is quite long, but it starts with:
ERROR: ~/tensorflow/tensorflow/contrib/lite/toco/BUILD:326:1: Linking of rule '//tensorflow/contrib/lite/toco:toco' failed (Exit 1)
/usr/bin/ld: warning: libcublas.so.9.1, needed by bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libcudnn.so.7, needed by bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libcufft.so.9.1, needed by bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libcurand.so.9.1, needed by bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so, not found (try using -rpath or -rpath-link)
bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>bazel-out/k8-py3-opt/bin/_solib_local/_U_S_Stensorflow_Scontrib_Slite_Stoco_Ctoco___Utensorflow/libtensorflow_framework.so: undefined reference to<EMAIL_ADDRESS>(and so on for other symbols)

@gunan @av8ramit Is the environment we use to build the official pip packages any different than this?

I see the same issue outside of a Docker container, i.e. on my computer. The error message is quite long, and mentions several CUDA libraries, as in @CNugteren's example.
CUDA is properly installed and all necessary environment variables are set (CUDA_HOME, LD_LIBRARY_PATH). Installing e.g. Tensorflow 1.4.1 (and most likely prior versions) with exactly the same set up is no problem.

@chhwang The root cause of the primary report in this issue is because your build process is a part of docker build.
NVIDIA docker does not make all the cuda libraries available in their final locations during docker build.
You need to manually make them available like this:
https://github.com/gunan/tensorflow-docker/blob/master/gpu-devel/Dockerfile.ubuntu#L64
This will be fixed in the future, but this should get you through.
@kmhofmann @CNugteren as I can successfully build TF with cuda9.1 or cuda 9.0 with the dockerfile I linked above as is, I need exact instructions to reproduce your errors. Would you mind filing new issues, and feel free to cc me so I can take a look?

I ran into the same issue with my slightly customized dockerfile file. Did all the libcuda symlink and LD_LIBRARY_PATH override stuff. Nothing worked until I added --action_env=LD_LIBRARY_PATH=/usr/local/cuda/lib64/stubs:${LD_LIBRARY_PATH} to bazel build option. So for some reason the LD_LIBRARY_PATH environment variable is not honored in the build process? I haven't had time to dig into this yet, anyone know what's the purpose of action_env?

That is correct, we also need to add "--action_env flag due to bazel trying to create a sealed and tightly controlled build environment.

@gunan: OK, I've created #16694. Indeed, adding --action_env=LD_LIBRARY_PATH=/usr/local/cuda/lib64/stubs:${LD_LIBRARY_PATH} fixes the problem.

@gunan Thank you for your suggestion, but my primary report already mentioned that manually linking CUDA library was not the solution. (I was already doing that.) By the way, adding --action_env=LD_LIBRARY_PATH=/usr/local/cuda/lib64/stubs:${LD_LIBRARY_PATH} fixes the problem without erasing build targets, so I'm closing this issue now. Further discussions would be in #16694.


Symfony 3.3

and php-cs-fixer 2.0

Coverage remained the same at 97.654% when pulling 8a5cbc948287090eb592c2072e4580f137106bff on symfony-3.3 into 6c46e6a3dc67360a7bc11431b22fbef50ae9c301 on master.

Coverage remained the same at 97.654% when pulling 8a5cbc948287090eb592c2072e4580f137106bff on symfony-3.3 into 6c46e6a3dc67360a7bc11431b22fbef50ae9c301 on master.


Remove deprecated --critical and --noncritical options

When the criticality concept was removed in RF 4.0 (#3624), --critical and --noncritical were preserved as deprecated aliases for --skiponfailure to make the change less backwards incompatible. Now in RF 5.0 these options can be removed.

I'd like to try this one out

Thanks for the offer! Probably easier if I do it myself, though. This is mostly/only about removing traces of these options from various places (incl. docs) and it's hard for others to find them all.


Add build for osx-arm64

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Now that git-lfs is officially released for osx-arm64, the entire rubinenv can be built for osx-arm64 without any modifications.

@ktlim Is there anything holding this from being merged?  Thanks!

I was hoping one of the other owners would weigh in.  @timj ?

Thanks all!


[gyb_syntax_support] No longer require trailing space after expression-like keywords

This patch sets requires_trailing_space to False for all ExprKeywords that can be used directly as expressions, to enable formatting that is consistent with identifiers in swift-syntax. In particular, the following keywords no longer require a trailing space:

nil
true, false
super, self, Self

See https://github.com/apple/swift-syntax/pull/552 for some further details.

@swift-ci please test

@swift-ci please test macOS

Interesting, the CI failure seems to be that the gyb-generated files in SyntaxFactory no longer match the new trailing spaces. Isn't this kind of a cyclic dependency, i.e. we need the updated gyb_syntax_support to regenerate SyntaxFactory and vice versa?

Yes, you need to re-generate the SyntaxFactory with the updated gyb_syntax_support and create a PR for the changes. But it’s not a cyclic dependency, it’s just that SyntaxFactory depends on gyb_syntax_support.

https://github.com/apple/swift-syntax/pull/573
@swift-ci please test

https://github.com/apple/swift-syntax/pull/573
@swift-ci please test


Groups not preserved in svg export

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
Groups defined in the application are not exported to an SVG.
To Reproduce
Steps to reproduce the behavior:

Create three lines.
Select two of them, and group them (right click -> group)
Export as SVG
Examine resulting SVG file

It will look something like:
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" style="background-color: rgb(255, 255, 255);" version="1.1" width="222px" height="222px" viewBox="-0.5 -0.5 222 222">
  <defs/>
  <g>
    <path d="M 170 220 L 220 170" fill="none" stroke="rgb(0, 0, 0)" stroke-miterlimit="10" pointer-events="stroke"/>
    <path d="M 60 90 L 110 40" fill="none" stroke="rgb(0, 0, 0)" stroke-miterlimit="10" pointer-events="stroke"/>
    <path d="M 0 50 L 50 0" fill="none" stroke="rgb(0, 0, 0)" stroke-miterlimit="10" pointer-events="stroke"/>
  </g>
</svg>

Expected behavior
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" style="background-color: rgb(255, 255, 255);" version="1.1" width="222px" height="222px" viewBox="-0.5 -0.5 222 222">
  <defs/>
  <path d="M 170 220 L 220 170" fill="none" stroke="rgb(0, 0, 0)" stroke-miterlimit="10" pointer-events="stroke"/>
  <g>
    <path d="M 60 90 L 110 40" fill="none" stroke="rgb(0, 0, 0)" stroke-miterlimit="10" pointer-events="stroke"/>
    <path d="M 0 50 L 50 0" fill="none" stroke="rgb(0, 0, 0)" stroke-miterlimit="10" pointer-events="stroke"/>
  </g>
</svg>

(or nested groups, if the top level group is necessary)
draw.io version (In the Help->About menu of the draw.io editor):

22.08

Desktop (please complete the following information):

OS: Linux
Firefox
118.0.2

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

no (not relevant)

Additional context
I'm hoping to programmatically hide various groups in an SVG. Unfortunately, because the groups are lost in the export, the only way around I can see it to add them in post-processing, but I don't know of an easy way to identify them since element data is also not preserved in the export (I think?).

Found svgdata in https://www.drawio.com/doc/faq/plugins which may provide a workaround.

I am still active and vaguely frustrated :)

You understand this is a free, open source project? We don't remotely have the resources to deal with every issue.

No worries, not expecting you to change this; I shouldn't have mentioned my frustration. Bumping since that was what the bot seemed to suggest I do. If you'd like to close this as wontfix, that's fine.

Groups preserved in 24.6.0.

Thanks! This will be really useful :) Appreciate it.


intermittent tests/kernel/workq/work_queue failure

Seen with both regular and polling implementations
----------sanity-out/qemu_nios2/tests/kernel/workq/work_queue/kernel.workqueue/handler.log----------
***** Booting Zephyr OS zephyr-v1.13.0-4051-g44906b118f *****
Running test suite workqueue
===================================================================
starting test - test_sequence
 - Initializing test items
 - Submitting test items
 - Submitting work 1 from preempt thread
 - Running test item 1
 - Submitting work 2 from coop thread
 - Submitting work 3 from preempt thread
 - Submitting work 4 from coop thread
 - Running test item 2
 - Submitting work 5 from preempt thread
 - Submitting work 6 from coop thread
 - Waiting for work to finish
 - Running test item 3
 - Running test item 4
 - Running test item 5
 - Running test item 6
PASS - test_sequence
===================================================================
starting test - test_resubmit
Starting resubmit test
 - Submitting work
 - Waiting for work to finish
 - Resubmitting work
 - Resubmitting work
 - Resubmitting work
 - Resubmitting work
 - Resubmitting work
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 5 (expected: 6)

FAIL - test_resubmit
===================================================================
starting test - test_delayed
Starting delayed test
 - Initializing delayed test items
 - Submitting delayed test items
 - Submitting delayed work 1 from preempt thread
 - Submitting delayed work 3 from preempt thread
 - Submitting delayed work 5 from preempt thread
 - Waiting for delayed work to finish
 - Submitting delayed work 2 from coop thread
 - Submitting delayed work 4 from coop thread
 - Submitting delayed work 6 from coop thread
 - Running delayed test item 1
 - Running delayed test item 2
 - Running delayed test item 3
 - Running delayed test item 4
 - Running delayed test item 5
 - Running delayed test item 6
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 12 (expected: 6)

FAIL - test_delayed
===================================================================
starting test - test_delayed_resubmit
Starting delayed resubmit test
 - Submitting delayed work
 - Waiting for work to finish
 - Resubmitting delayed work
 - Resubmitting delayed work
 - Resubmitting delayed work
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 15 (expected: 6)

FAIL - test_delayed_resubmit
===================================================================
starting test - test_delayed_resubmit_thread
Starting delayed resubmit from coop thread test
 - Waiting for work to finish
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Running delayed test item 1
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 16 (expected: 1)

FAIL - test_delayed_resubmit_thread
===================================================================
starting test - test_delayed_cancel
Starting delayed cancel test
 - Cancel delayed work from preempt thread
 - Waiting for work to finish
 - Cancel delayed work from coop thread
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 16 (expected: 0)

FAIL - test_delayed_cancel
===================================================================
Test suite workqueue failed.
===================================================================
PROJECT EXECUTION FAILED
----------sanity-out/qemu_nios2/tests/kernel/workq/work_queue/kernel.workqueue/handler.log----------

--------sanity-out/qemu_x86/tests/kernel/workq/work_queue/kernel.workqueue.poll/handler.log---------
cSeaBIOS (version rel-1.11.2-0-gf9626ccb91-prebuilt.qemu-project.org)
Booting from ROM..***** Booting Zephyr OS zephyr-v1.13.0-4051-g44906b118f *****
Running test suite workqueue
===================================================================
starting test - test_sequence
 - Initializing test items
 - Submitting test items
 - Submitting work 1 from preempt thread
 - Running test item 1
 - Submitting work 2 from coop thread
 - Submitting work 3 from preempt thread
 - Submitting work 4 from coop thread
 - Running test item 2
 - Submitting work 5 from preempt thread
 - Submitting work 6 from coop thread
 - Waiting for work to finish
 - Running test item 3
 - Running test item 4
 - Running test item 5
 - Running test item 6
PASS - test_sequence
===================================================================
starting test - test_resubmit
Starting resubmit test
 - Submitting work
 - Waiting for work to finish
 - Resubmitting work
 - Resubmitting work
 - Resubmitting work
 - Resubmitting work
 - Resubmitting work
 - Checking results
PASS - test_resubmit
===================================================================
starting test - test_delayed
Starting delayed test
 - Initializing delayed test items
 - Submitting delayed test items
 - Submitting delayed work 1 from preempt thread
 - Submitting delayed work 3 from preempt thread
 - Submitting delayed work 5 from preempt thread
 - Waiting for delayed work to finish
 - Submitting delayed work 2 from coop thread
 - Submitting delayed work 4 from coop thread
 - Submitting delayed work 6 from coop thread
 - Running delayed test item 1
 - Running delayed test item 2
 - Running delayed test item 3
 - Running delayed test item 4
 - Running delayed test item 5
 - Running delayed test item 6
 - Checking results
PASS - test_delayed
===================================================================
starting test - test_delayed_resubmit
Starting delayed resubmit test
 - Submitting delayed work
 - Waiting for work to finish
 - Resubmitting delayed work
 - Resubmitting delayed work
 - Resubmitting delayed work
 - Resubmitting delayed work
 - Resubmitting delayed work
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 5 (expected: 6)

FAIL - test_delayed_resubmit
===================================================================
starting test - test_delayed_resubmit_thread
Starting delayed resubmit from coop thread test
 - Waiting for work to finish
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Resubmitting delayed work with 1 ms
 - Running delayed test item 1
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 7 (expected: 1)

FAIL - test_delayed_resubmit_thread
===================================================================
starting test - test_delayed_cancel
Starting delayed cancel test
 - Cancel delayed work from preempt thread
 - Waiting for work to finish
 - Cancel delayed work from coop thread
 - Cancel pending delayed work from coop thread
 - Checking results

    Assertion failed at /home/buildslave/src/github.com/zephyrproject-rtos/zephyr/tests/kernel/workq/work_queue/src/main.c:119: check_results: (num_results not equal to num_tests)
*** work items finished: 7 (expected: 0)

FAIL - test_delayed_cancel
===================================================================
Test suite workqueue failed.
===================================================================
PROJECT EXECUTION FAILED
--------sanity-out/qemu_x86/tests/kernel/workq/work_queue/kernel.workqueue.poll/handler.log---------

Going to close this one as IMHO the issue is well captured by #12553, it's nothing specific to this bug, and this bug works very reliably on unloaded systems (it is, however, the single most seen failing case on loaded runs, but I think that's down to the fact that it does more loops with sleeping and scheduling interactions than other tests, which usually test one thing and move on).


DITA tables are ignored in markdown transform

Transformed a DITA collection to markdown and it looked great, but all tables were ignored. Thanks!

Since Markdown doesn't support tables by default, they are tricky. Could you show an example of the DITA content you're trying to process?

So, something like

Sample codes
     <simpletable>

        <sthead>

              <stentry>Code</stentry>

              <stentry>Value</stentry>

        </sthead>
           <strow>
       <stentry>1</stentry>
     <stentry>1 point</stentry>
    </strow>
  </simpletable>

Comes out like:
Sample codes { .section}

The <thead> and <tbody> AST elements were not correctly created for simpletable.

Per http://docs.oasis-open.org/dita/v1.0/langspec/simpletable.html, simpletable does not include thead and tbody. It is not a CALS table (maybe I should use a CALS table?)

The <thread> and <tbody> elements I was referring to are part of the internal XML vocabulary used by  the plugin. The vocabulary tries to model Pandoc's AST (Abstract Syntax Tree),


Let AbstractDb implement AdapterAwareInterface

At the moment Zend\Validator\Db\AbstractDb has a method setAdapter to set the database adapter. I think the canonical way of doing that would be to implement the Zend\Db\Adapter\AdapterAwareInterface's setDbAdapter() instead, maybe by using the Zend\Db\Adapter\AdapterAwareTrait.

We haven't done this in the past as the AdapterAwareInterface was added after the validator was created. :)
As for the AdapterAwareTrait, until 2.5, we couldn't have used it.
Feel free to send a PR with these changes.

Has this been fixed yet ? If not I would like to give it a try .

https://github.com/zendframework/zend-validator/pull/46

it close-able


Binds parameter not respected

#345 is closed without a fix. Now I cannot specify an empty dictionary for the binds parameter in order to use the technique as describe by the SQLAlchemy docs regarding joining a session into an external transaction.

It was closed with a fix, there's a linked commit in that issue.

Hmm, actually, the linked issue rolls back an earlier change. Would you provide a minimal example demonstrating what you need and what doesn't work right now?

I want to specify an empty dictionary for the binds parameter. The example code looks like:
@pytest.yield_fixture()
def db_session(app, db):
with app.app_context():
connection = db.engine.connect()
transaction = connection.begin()
options = dict(bind=connection, binds={})
session = db.create_scoped_session(options=options)
db.session = session
yield session
transaction.rollback()
connection.close()
session.remove()
I would expect the transaction is rolled back, but it does not.  By using the workaround in #345 ,
it works.

#1087 fixes a bunch of stuff about binds, including making the implementation of get_bind mirror how the base implementation works. I'm not sure if passing binds= as a session option would do anything though, given that Flask-SQAlchemy prefers looking up its configured binds, but it's now possible to customize the session class to do whatever you need by passing session_options={"class_": CustomSession}.


rclone: 1.49.0 -> 1.49.1

Motivation for this change
See: https://rclone.org/changelog/
Looks like small bugfixes only. Tested working with google drive..
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build rclone

Thanks @danielfullmer :tada:


Add client side bundle analysis

We only have coverage on bundle analysis for the loader. Most of our bundle size opportunities are in the container + DDS space, so adding a webpack config simply to generate output that can be used for bundle analysis

@heliocliu - looks like the PR comment didn't pick it up automatically. Anything manual I need to do other than put things in the bundle analysis folder? Does it look in the examples folder

@heliocliu - looks like the PR comment didn't pick it up automatically. Anything manual I need to do other than put things in the bundle analysis folder? Does it look in the examples folder

I'm pretty sure this is just because there's no baseline yet so it's skipping the comparison?  Should start coming up once people are synced to this change

@heliocliu - looks like the PR comment didn't pick it up automatically. Anything manual I need to do other than put things in the bundle analysis folder? Does it look in the examples folder

I'm pretty sure this is just because there's no baseline yet so it's skipping the comparison? Should start coming up once people are synced to this change
edit: oh looks like it was probably the webpack:profile step you found

Looks good overall to me. Given that the size comparison is getting its own dedicated package now, we should look at moving the base-host stuff here as well. I can do that later if you don't take care of it first 🤔

That might make sense, I'll merge this first and let you decide if it makes sense to move it out of base host


ARROW-2976: [Python] Fix pyarrow.get_library_dirs

Codecov Report

Merging #2398 into master will increase coverage by 2.11%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #2398      +/-   ##
==========================================
+ Coverage   84.73%   86.84%   +2.11%
==========================================
  Files         293      237      -56
  Lines       45471    42719    -2752
==========================================
- Hits        38529    37099    -1430
+ Misses       6905     5620    -1285
+ Partials       37        0      -37

Impacted Files
Coverage Δ

python/pyarrow/__init__.py
52.11% <0%> (-12.8%)
:arrow_down:

go/arrow/math/float64_amd64.go

go/arrow/type_string.go

go/arrow/array/bufferbuilder_numeric.gen.go

go/arrow/array/numericbuilder.gen.go

rust/src/buffer.rs

rust/src/list_builder.rs

go/arrow/internal/cpu/cpu_x86.go

go/arrow/internal/bitutil/bitutil.go

rust/src/list.rs

... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ffc00...6d88fcd. Read the comment docs.

@wesm @pitrou Can one of you have a quick look if that seems to be the right way to do this? It's working for me but there is probably lots of corner cases.

Can one of you have a quick look if that seems to be the right way to do this?

No idea, sorry. I'm a bit surprised the CMake scripts aren't able to do that by themselves?
Apparently LLVM installs some CMake scripts that allow third-party projects to include the necessary definitions: https://llvm.org/docs/CMake.html#embedding-llvm-in-your-project
(not that I find CMake easy to work with ;-))

I think this is for 3rd party libraries that aren't using cmake? (NumPy has some functions like this)
I tested this locally where I have the libraries installed somewhere else and it seems to be working:
In [1]: import pyarrow
pya
In [2]: pyarrow.get_library_dirs()
Out[2]: ['/home/wesm/code/arrow/python/pyarrow', '/home/wesm/local/lib']


Search icon color issue

Actual Behaviour
Search icon color is changing to black after opening trackSessions activity when track font-color is black same for other track-font-color.
Expected Behaviour
Seach icon color shoud be managed properly to show appropriate color.
Steps to reproduce it

Go to Tracks fragment
Click on "AI & Machine Learning" track
Press back button
Now go to schedule fragment, search icon color is changed.
Press back button, search icon color in home fragment also changes.

Would you like to work on the issue?
Yes
Target Milestone to solve the issue
Milestone 9

please go ahead.


BUG 2024792: rbd: add a workaround to fix rbd snapshot scheduling

This is the backport PR of https://github.com/ceph/ceph-csi/pull/2669 to fix the bug introduced in the dummy image workaround
with a shallow copy of rbdVol to dummyVol, the image name update of the dummyVol is getting reflected on the rbdVol which we don't want. do a deep copy to avoid this problem.
Note:- should be merged after https://github.com/red-hat-storage/ceph-csi/pull/45 to get the changes in the devel branch first
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

/assign @agarwal-mudit

Why the second commit is not cherry-picked? @Madhu-1

Why the second commit is not cherry-picked? @Madhu-1

good catch!. forgot to add -x flag when doing the cherry-pick. fixed now


Prometheus external_labels not available in Grafana

Probably this is intentional behavior, but prometheus dosen't add external_labels to queries send by Grafana.
This can be useful for ex. exposing information about region name.
Can we treat that as feature requests? ;)

Yes, that's intended currently. The presumption is you already know that due to the data source. If that not sufficient for you use case?

Right now we are thinking how we can support multi-region deployments. So we are researching about what options do we have, but we dont have ready architecture yet.
But you have a point, in case we choose to federate "side-prometheuses" to "global-prometheus" external_labels will be there.
Region name available in "side-prometheuses" would be useful for us because we have already region_name in our logging solution. From user perspective it would be nice to be 100% sure that you are watching metrics from right environment. (in case federation would not be used)

Grafana should generally talk directly to the Prometheus that has the data you want. Likely via data source templating in your case.


parser: broken select statements

Describe the bug
I see some similar bugs in https://github.com/xqueries/xdb/blob/master/internal/parser/parser_test.go
https://github.com/xqueries/xdb/blob/67baa13772021efd6974f664fb85c7d2bf4c9219/internal/parser/parser_test.go#L4568 https://github.com/xqueries/xdb/blob/67baa13772021efd6974f664fb85c7d2bf4c9219/internal/parser/parser_test.go#L6596
I am not sure whether they are intentional or indeed are missed somehow, but I think these statements and others like these should give an error related to an invalid SELECT statement or missing table name.
Even, the select query without any FROM clause and Literal, is passing.
To Reproduce
Run the tests.
Also, try SELECT *, which I think should fail.
Similar issue
Missing table name in Create statement #29

SELECT * is a valid grammar production, and should fail after compilation at execution time, so these are valid parser tests. The parser should not fail attempting to parse them.
https://www.sqlite.org/lang_select.html
So in summary:
your two examples should be

parseable
compilable
not executable
If they are executable, this is an engine problem, otherwise, I would close this, as the behavior is intended.

Whats the status on this?
Does #52 fix this? @Shivam010

As the query is parsable, the parser works fine in this case.
But I had run tests to execute the query and it seems it is executing perfectly, I have certain other examples, that are wrongly executing, like:

select *
select 1 from myTable
I am working on them with the possible solution.

How did you execute them? What result does select * produce?
select 1 from myTable should just produce

column1 (Integer)

1

at least that's what I would expect at this point

select * returns

column1 (String)

*

whereas select 1 from myTable returns with error: no column with name 1

even select 'str' from myTable returns the same error.
It is due to the fact that they are List type commands and the expected behaviour is written in Value type command.
We have to handle the behaviour for numerical values and quoted strings to be treated as constants and not columns in List

select * even makes sense... * is just considered a literal, since there is no column it matches, which is the same behavior as for select 1 or select '1'. I would leave it like that.
select 1 from myTable on the other hand should just work as select 1, given there is no such column.
Closing this in favor of #54

We have to handle the behaviour for numerical values and quoted strings to be treated as constants and not columns in List

#55


Introduce attribute to skip permission check

Some of the handlers or derived view model classes should not check permissions declared at parent class. PageSecurity checks should not be created. In general, we don't want developers to specify permission in every handler/class, so this situation is exceptional. It will be easy to achieve that by introducing dedicated Attribute for that purpose. My idea is SkipPermissionCheck. If anybody has better idea feel free to post it. To explain:
Current behavior:
[RequirePermission(typeof(ViewSth))]
partial class ViewModel {
    public void Handle(Input.DoSth action)
    {
    }
}

Check for DoSth Handler will be created (with ViewSth permission check)
Desirable behavior:
[RequirePermission(typeof(ViewSth))]
partial class ViewModel {
    [SkipPermissionCheck]
    public void Handle(Input.DoSth action)
    {
    }
}

Check for DoSth Handler won't be created (thanks to the introduced SkipPermissionCheck attribute)

We decided to introduce RequirePermission(false) instead of SkipPermissionCheck attribute.

This is outdated


[Bug] Email already exists, but still shown in UI

Describe the bug
When I edit the email address of user A and change it to the email address of user B, you'll get a pop-up message that this email is already in use, but still the email of user A is updated in the UI.
To Reproduce
Steps to reproduce the behavior:

Go to user A.
Click on 'Edit'.
Change 'Email' to email of user B.
Click on 'Save' --> Pop-up appears with 'User with that email already exists.'
Click on 'Close'.
Go to user A (to see details).
See error: 'Email' shows email of user B.

Expected behavior
Is assume it is not okay that two users have the same email.
So; the email of user A should not be updated.
Details
https://portal.petronas.vantage6.ai/
UI version 3.3.7

Is the email still updated after you fresh the page?

After refreshing the page the email field is empty.


CVODES

Summary:
Switch from CVODE to CVODES integrator for greater robustness and speed for mostly large ODE systems.
Description:
Remove integrate_ode_cvode function and replace with
integrate_ode_cvodes and integrate_ode_cvodes_stiff
each in two variants, i.e. a simple one and one which exposes the options abs+rel tol and maximum number of steps
Reproducible Steps:
Performance tests for stiff ODE integrator in stan-math fail with CVODE, but not with CVODES.
Current Output:
Stan freezes with old CVODE system on some ODE systems (see the test).
Expected Output:
Just return the solution.
Additional Information:
This requires changes to the build system and the language.
Current Version:
develop

This was taken care of in stan-dev/stan and will be released with v2.10.


Cannot Find The "Order" button

When I create a bunch of test cases within test suite, i usually add on the fly and later hit that "Order" button to re arrange the test cases according to order of execetion. Now, I dont know the reason why MS removes that functionality.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb46332b-83bd-5525-cb42-11bcfef0843a
Version Independent ID: aa9542b6-0b48-1818-092f-1989fbb45cf6
Content: Plan manual tests with MTM - Azure Test Plans
Content Source: docs/test/mtm/plan-manual-tests-with-microsoft-test-manager.md
Product: devops
Technology: devops-test
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

It looks like you've encountered an issue with the product itself, rather than an issue with the documentation. To make sure it gets in front of the right people, please submit your bug here.


Enable zone awareness for Elasticsearch

In a typical AWS setup you have multiple zones. In order to survive an zone outage the elasticsearch config should ensure that the corresponding az is exposed as a zone:
https://www.elastic.co/guide/en/elasticsearch/reference/master/allocation-awareness.html
Maybe it would be also useful to split the stateful sets to one set per zone?

fixed title2

fixed title

https://github.com/kubernetes/enhancements/issues/895

I do not think that the kubernetes failure domains alone are enough to tackle this issue. Elasticsearch itself needs to know which nodes runs in which az. Otherwise it cannot replicate the data across different az.

This issue has been resolved in KubeDB release v2021.03.17 . Please open a new bug if you still see this issue.


Upgrade library tool and dependencies' version to the latest

Upgrade versions

Gradle

Android Gradle Plugin

appcompat (in library and sample directory)

to latest versions.

 @anitaislam1953@gmail.com@SaeedZhiany @


cp: build/Build/Products/Release/applesimutils: No such file or directory

brew install --HEAD applesimutils failed with cp: build/Build/Products/Release/applesimutils: No such file or directory error.
full log:
→ brew install --HEAD applesimutils
==> Installing applesimutils from wix/brew
==> Cloning https://github.com/wix/AppleSimulatorUtils.git
Cloning into '/Users/chirag/Library/Caches/Homebrew/applesimutils--git'...
remote: Counting objects: 39, done.
remote: Compressing objects: 100% (36/36), done.
remote: Total 39 (delta 3), reused 19 (delta 0), pack-reused 0
Unpacking objects: 100% (39/39), done.
==> Checking out branch master
==> ./buildForBrew.sh /usr/local/Cellar/applesimutils/HEAD-febb0d6
Last 15 lines from /Users/chirag/Library/Logs/Homebrew/applesimutils/01.buildForBrew.sh:
GenerateDSYMFile Build/Products/Release/applesimutils.dSYM Build/Products/Release/applesimutils
    cd /tmp/applesimutils-20170727-26741-rqyr0b/applesimutils
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/dsymutil /tmp/applesimutils-20170727-26741-rqyr0b/applesimutils/Build/Products/Release/applesimutils -o /tmp/applesimutils-20170727-26741-rqyr0b/applesimutils/Build/Products/Release/applesimutils.dSYM

CodeSign Build/Products/Release/applesimutils
    cd /tmp/applesimutils-20170727-26741-rqyr0b/applesimutils
    export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate

Signing Identity:     "-"

    /usr/bin/codesign --force --sign - --timestamp=none /tmp/applesimutils-20170727-26741-rqyr0b/applesimutils/Build/Products/Release/applesimutils

** BUILD SUCCEEDED **

cp: build/Build/Products/Release/applesimutils: No such file or directory

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/wix/homebrew-brew/issues

Also getting this error. Any tips?

Please open this issue in applesimutils where it belongs. Thanks

For what it's worth, the failure directs people to report it here.


Add Python3 support for flake8/pep8

Enable the use of a python option to chose which version of python flake8/pep8 use.

Codecov Report

Merging #195 into master will increase coverage by 0.02%.
The diff coverage is 95%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   88.77%   88.79%   +0.02%
==========================================
  Files          41       41
  Lines        2084     2098      +14
==========================================
+ Hits         1850     1863      +13
- Misses        234      235       +1

Impacted Files
Coverage Δ

lintreview/tools/flake8.py
93.75% <100%> (+0.27%)
:arrow_up:

lintreview/tools/pep8.py
91.11% <100%> (+0.41%)
:arrow_up:

lintreview/tools/__init__.py
81.67% <90%> (+0.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5368002...c86e9f8. Read the comment docs.


Camera Trigger fixes

This fixes everything. (see https://github.com/PX4/Firmware/issues/6961)

@birchera Please cross-test with Seagull MAP2 and Sony Camera. I will too, once I have the hardware.

The last commit also fixes the pwm info command, such that it doesn't show output groups which it does not control.

@PX4TestFlights We will need a flight test with this branch. Please test with Pixracer, because this makes changes to the way FMU handles actuator outputs. We would need testing to confirm that the first 4 channels work well (so a F450-type platform would be best).

Current status : Works on all the hardware which I tested. I also added simple PWM mode for things like IR triggers and servo-pushing-shutter-button type triggers.
TODOs :

Figure out why the HRT callback stops firing sometimes. (Also restarts by itself)
Clean up power control options, move it into CameraInterface.
Simplify on/off and keepalive calls. Way too cruddy and hard to read at the moment.
Move TRIG_PIN handling into CameraInterface.

So I finally tracked down why it locks up. Turns out that the HRT engage/disengage callback can fire in between two PWM pulses. You can see it in the logic analyzer traces here :
Bad (trigger engages and disengages between two pulses):

Good (engage and pulse generation is aligned) :

Fixes :

Just increase (and enforce a lower bound) on the activation time (in PWM mode) so that it can't disengage in-between two pulses even in the worst case.
OR
Sync the disengage call with an interrupt from the PWM timer so that it doesn't disengage till a new pulse is generated.

Option 1. sounds good. What would the lower bound be?

20 ms is sufficient to make sure it can't disengage in-between, but turns out that the MAP2 isn't exactly the highest-quality hardware, and it often misses trigger events if they're only 1 pulse long. So it might require some empirical tuning to get a reliable bound. I will test and lock it in tomorrow.

Good to go?

Yep.


Foundation <IP_ADDRESS> to <IP_ADDRESS> Changes Menu Link Spacing

I just upgraded my foundation-rails gem from <IP_ADDRESS> -> <IP_ADDRESS> and am seeing the following change in my screen:
foundation-rails <IP_ADDRESS> Menu

foundation-rails <IP_ADDRESS> Menu

Codepen with same HTML (copied and pasted from source in dev console in Chrome) and CSS code running 6.4.1 from the cdn:
https://codepen.io/stephendolan/pen/wqgXBQ
It seems that if the exact same code is rendering correctly in Codepen using the library, but is not rendering the same way in Rails using the foundation-rails gem, that the issue might be with the gem? Is this possible?
Has anyone else seen this issue, or know how I can resolve it?

I am not able to reproduce this with a brand new Rails project. I'm still not sure what is changing between <IP_ADDRESS> and <IP_ADDRESS> that would cause this behavior in my application, but it certainly seems to be localized there.


"Select TypeScript version" command doesn't work

code-server version: 2.1665-vsc1.39.2-linux-x86_64
OS Version: Debian GNU/Linux 10 (buster)

Description
This command have no effect.

Steps to Reproduce

Load code-server
Ctrl+Shift+P and select this command

I found that when a new user-data-dir is being populated, the visit to code-server must be from localhost. Using any other domain will lead to this behavior.

related to GH-999

at centos 8 this is the issue but v2 at centos 8 are more stable than ubuntu.. for me. the only downside there is cant pick typescript version and cant copy and paste


Adding 3D Models To Provider

Hello, first of all, thank you for this resource. It is invaluable.
Second, im trying to customize the code to protect glb files alongside pngs for the tokens. Do I need to make any changes in hashlips-lab/collection-data-updater? I added the following code to index.ts
new S3BasicFileDataUpdater(       "Model",       s3Config,       config.PRIVATE_MODELS_PATH,       config.PUBLIC_MODELS_PATH,       config.MODELS_EXTENSION,     ),
I also added these to config.ts
 PRIVATE_MODELS_PATH: getEnvironmentVariable("PRIVATE_MODELS_PATH"),   PUBLIC_MODELS_PATH: getEnvironmentVariable("PUBLIC_MODELS_PATH"),   MODELS_EXTENSION: getEnvironmentVariable("MODELS_EXTENSION"),
and likewise, updated .do/deploy.template.yaml and .env with
        - key: PRIVATE_MODELS_PATH           scope: RUN_TIME           value: /private/models         - key: PUBLIC_MODELS_PATH           scope: RUN_TIME           value: /public/models         - key: MODELS_EXTENSION           scope: RUN_TIME           value: .glb
and
PRIVATE_MODELS_PATH=/private/models PUBLIC_MODELS_PATH=/public/models MODELS_EXTENSION=.glb
respectively.
Everything deploys fine, and the png's and metadata get moved from private to public, but it seems to be ignoring the models, even within the runtime logs. Am I missing something? Perhaps you could make a short tutorial on how to customize the code to add an additional asset class?
Thank you for taking the time <3

I figured it out. I had to update the deploy.template.yaml with my own git of the modified code.
git:
        branch: main
        repo_clone_url: https://github.com/nickyoung92/modelmetadataprovider.git

Hi @nickyoung92, I appreciate your feedback and I'm happy you have found this tool useful.  Any update to the code requires you to update the deployment configuration as well (I made a video tutorial long time ago about how to customize the tool using version 1.x, the steps to deploy a customized version should be pretty much the same: https://www.youtube.com/watch?v=P1CsGuBO_Gs).
Just for your information: we are now focused on providing support and connecting directly with members of the Open Devs Crew (https://opendevs.io) so if you make use of our tools and maybe want to discuss some features and/or get some support you might be interested in joining at some point. It would also help us carrying on with development. ;)
Of course general maintenance and bug reports will be addressed publicly on GitHub whenever possible.
Thank you for reaching out and have a wonderful day! 😃


[CSL-1725] Report misbehavior from core nodes only

I introduced 'HasNodeType' class which allows the node to know its type.
The type is determined by network config for normal node and is hardcoded for
tests, block-gen, etc.
The essential change is in 'reportMisbehaviour', other changes are related to
new type class, propagating proper constraints and defining instances.
P. S. I believe it should go to 1.0 branch to decrease load on reporting server.

Why have you created a separate type instead of adding a flag like reportMisbehavior to on of the configs we have (behavior config, configuration.yaml, etc)?

Why have you created a separate type instead of adding a flag like reportMisbehavior to one of the configs we have (behavior config, configuration.yaml, etc)?

Because if we want to report misbehaviour only from core node, I think it's easier for people not to bother about yet another flag. And I didn't create a separate type, NodeType existed before my commit.

FYI: needs a rebase to fix CI.


Fixing [#198]: update json.hpp to repair the project compilation (clang 7.0)

I just copied the raw text from https://github.com/nlohmann/json/blob/develop/single_include/nlohmann/json.hpp and replace it in the file. Let me know if it's too much diff for you !

As long as CI says its fine, it's fine with me. Merged, thanks.


Antares launcher does not handle concurrent acces to its internal db

The db used internally by the submodule antares_launcher (TinyDB) does not handle concurrent access.
When the app is deployed using gunicorn and multiple workers, some times, studies can disappear from the db on concurrent write access.

Fixed with #703


Implement the GIT downloader

Since PHP development has shifted from SVN to GIT a new downloader must be thought up.
this might also be the right moment to remove the getSvnVersions to 'getVersions' (since SVN has nothing to do with it anymore, they're just going to be branches in the GIT repo)
One might go as far and redefine PhpSource:

getReleaseManagers / versionCompare / getVersionInfo remain as is
getReleases($stableOnly=false) (
via listing of branches in the GIT repo and if $stableOnly == true, filter out everything not on  the http://www.php.net/distributions/ page)

The actual downloader would use the getReleases information and checkout specific versions as requested. The snapshotreleases would be obsolete by 'getReleaseByCommit` (which again the actual downloader could also use internally)
By moving away from anything but GIT and the 'git way' it would simplify alot of the innerworkings of what it has to do to get the code for the requested 'release' (which is actually just a commit state on the GIT repo)

I am closing this to design a whole new Git installer for PHP.