Document that meltano config supports custom settings that are passed on to the plugin as expected

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2201
Originally created by @DouweM on 2020-07-29 16:19:54

View 3 previous comments from the original issue on GitLab


Using vcpkg

Please create a json file to lockdown all the dependencies' versions.
Doc: https://learn.microsoft.com/en-us/vcpkg/consume/lock-package-versions?tabs=inspect-powershell#5---force-a-specific-version

Before this PR is merged, please write a document to describe how to setup the build environment(install vcpkg and set cmake flags), and add Ryan's to the reviewers, because this change is going to change his daily dev workflow.

To use vcpkg with CMake
First clone vckpg as submodule
git submodule update --init --recursive

Second run bootstrap file
For Windows
.\extern\vcpkg\bootstrap-vcpkg.bat

On Unix
./extern/vcpkg/bootstrap-vcpkg.sh

Closing for now. Can re-open later


Carousel flips to White Space before next Picture

Since the last pull the carousel flips to a white space before the next picture.
This is not the normal function of the carousel

This seems to be a problem since the last pull.  It appears that the issue goes away when the bootstrap import on App.js is commented out.  Not sure if it is needed there.

This was related to conflicting bootstraps - resolved


Add BSP to improve render speed

A good start would be using the implementation made in propan:
https://github.com/Harium/propan/issues/13

Currently, sunflow uses acceleration structure for each geometry and not for the scene itself, I am convicted that the rendering time can be reduced.


Removing scene root doesn't preserve filename

Godot version:
3.1.1
Issue description:
When you remove a scene root, the filename isn't remembered, so you need to select file again in case of adding new root.
Steps to reproduce:

Open a scene
Remove the root
Add new root (still the same tab)
Try saving the scene
Editor gets Alzheimer'd and asks you where to save

I now realized that fixing this could be helpful for #26377, as you could create a rootless scene tab with a filename (and obviously the editor shouldn't allow to save an empty scene).


How do I just draw a polygon and add it to a layer?

I am struggling a lot just simply drawing a polygon and adding it to a layer.
I have tried reading through this issue: How to Save/Recover/Program/Add/Delete Features ? and to be honest I just find the answers bewildering, any time I try to copy any of the answers into my code, I am told that "source.value.source is undefined", or something else just doesn't work.
This is my code. Forgive me for being naive, but how do I "just get the drawn feature into the features array"? What am I doing wrong?
<template>
  <VLayoutItem model-value size="88">
      <div class="ma-4">
          <VBtn
            @click="clear"
            icon="mdi-shape-polygon-plus"
            size="large"
            color="primary"
            elevation="8" />
      </div>
    </VLayoutItem>

  <ol-map
    :loadTilesWhileAnimating="true"
    :loadTilesWhileInteracting="true"
    style="height:95%"
  >
    <ol-view
      ref="view"
      :center="center"
      :rotation="rotation"
      :zoom="zoom"
    />

    <ol-tile-layer>
      <ol-source-osm />
    </ol-tile-layer>

    <ol-vector-layer>
      <ol-source-vector
        ref="source"
        :features="features"
      >
        <ol-interaction-draw
          v-if="draw"
          type="Polygon"
          @drawend="drawEnd"
        >
        </ol-interaction-draw>
        <ol-interaction-modify
          v-if="modify"
        >
          </ol-interaction-modify>
      </ol-source-vector>

      <ol-style>
        <ol-style-stroke color="red" :width="2"></ol-style-stroke>
      </ol-style>
    </ol-vector-layer>
  </ol-map>
</template>

  <script>
  import { ref, inject } from "vue";
  export default {
    setup() {
      const center = ref([40, 40]);
      const zoom = ref(8);
      const rotation = ref(0);
      return {
        center,
        zoom,
        rotation,
      };
    },
    data() {
        return {
            draw: true,
            modify: false,
            features: []
        }
    },
    props: {
        drawnFeature: null
    },
    methods: {
        clear() {
            this.draw = true;
            this.modify = false;
        },
        drawEnd(e) {
          this.draw = false;
          this.modify = true;
          console.log(e);
          this.features.push(/* How do I push the feature into the features array? */)
        },
    },
  };
  </script>

First of all, you dont need the features array.
The draw interaction is placed  a vector source so the drawn polygon will just be added to that source.
So just removed :features="features" and it should work.
If you for some other reason want to access the feature on drawEnd, you can simply grab it from the event.
In your case, the feature is in the "e" event:
drawEnd(e) {
    this.draw = false;
    this.modify = true;
    console.log(e.feature); // Here is the feature you just drew
},

@iboates could you solve your problem? If not: can you provide a minimal reproduction playground using the following Stackblitz starter template

I will close this issue for now. Feel free to re-open it if the problem still exists and provide the requested information (see comment before).


Move GET API requests api/v1/users/:user_id/layers

Closes #3535
Feat. flag is active_record_layers_endpoint
Won't be released until @xavijam is finished with some FE changes he needs to do.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@rafatower CR please

:+1:

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Python style format logger

Some code refactoring due to this problem #306

I reviewed this pr and it looks pretty good :)
maybe you could change the commit messages so that it reflects the issue a bit
[logging] use python style formatting API \n\n Fixes Issue #306
and [logging] Add missing indices for the formatting
or sth like this, but thats everything and i think could be merged today

@impowski Thank you for your contribution!
Please avoid merge messages next time. Have a look here how you can do that:
https://github.com/inexor-game/code/wiki/Git-FAQ#merging (in short: git rebase)

@Croydon yeah I'm trying to fix it now.

No need. Removing commits from master is rather bad practice. We also disallow force pushed to the master branches. Just avoid it next time and everything is fine :)

@Croydon yeah, I figured it now. I'm sorry if I messed something.

@impowski Another hint: If you write either in the pull request title or in one commit message (prefered way) "close #318"  or "fix #318" the issue will be automatically be closed as soon as you merge your commits.
https://help.github.com/articles/closing-issues-via-commit-messages/


Add baseline random player

Apologies, this PR was intended to be for my own fork of the original repo.


feat(svelte-query): Export context functions

@frederikhors I figured this might be a good idea after I saw the answer in #5378! If you also find time to contribute a svelte-query-persist-client package based on your implementation I would greatly appreciate it :)

My time is limited but I'll definitely try.


Tidied up the Stamper module and upgraded to Rust 1.34

Added stamper.revert method to be used for rollback - rolling back to a previous
commit in case of deleting all documents or rolling operations back should reset
the stamper as well
Added type alias for Opstamp - helps code readibility instead of seeing u64
returned by functions.
Moved to AtomicU64 on stable rust (since 1.34) - where possible use standard
library interfaces.

Please review when you can. Feel free to change the docstring and squash everything into 1 commit for merging.
I recommend using the commit message from 8e509213634ccbf82c3380e1b660ec1ffb735301


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/12 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit caac0ab:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


SBT won't autocomplet on keys defined in globalSettings of an AutoPlugin

object BlaBlaPlugin extends AutoPlugin {

  object autoImport {
    lazy val blabla = taskKey[Unit]("")
  }
  import autoImport._

  override lazy val globalSettings = Seq(
    blabla := println("Hello")
  )
}

Gives:
> bla
{invalid input}
> blabla
Hello
[success] Total time: 0 s, completed 22-Dec-2015 00:33:21

Why wouldn't the autocompletion work?
Thanks

Closing this a duplicate of https://github.com/sbt/sbt/issues/1373


Move newsletter/contact preference to signup

Current coverage is 70.79%

Merging #336 into master will decrease coverage by -0.11% as of 917ae1e

@@            master    #336   diff @@
======================================
  Files          106     106
  Stmts         2891    2886     -5
  Branches         0       0
  Methods          0       0
======================================
- Hit           2050    2043     -7
  Partial          0       0
- Missed         841     843     +2

Review entire Coverage Diff as of 917ae1e

Powered by Codecov. Updated on successful CI builds.

@madprime addressed your comment, look good now?


2.4.0: error: no member named 'linjs' in 'struct _GLFWjoystick'

/usr/ports/misc/box2d/work/box2d-2.4.0/extern/glfw/src/linux_joystick.c:51:34: error: no member named 'linjs' in 'struct _GLFWjoystick'
                             js->linjs.keyMap[code - BTN_MISC],
                             ~~  ^
/usr/ports/misc/box2d/work/box2d-2.4.0/extern/glfw/src/linux_joystick.c:51:54: error: use of undeclared identifier 'BTN_MISC'
                             js->linjs.keyMap[code - BTN_MISC],
                                                     ^
/usr/ports/misc/box2d/work/box2d-2.4.0/extern/glfw/src/linux_joystick.c:59:27: error: no member named 'linjs' in 'struct _GLFWjoystick'
    const int index = js->linjs.absMap[code];
                      ~~  ^

OS: FreeBSD 12.1

It is defined here:
https://github.com/erincatto/box2d/blob/e6a8a5df00bdc7a69bea9ed072b120cc3341190e/extern/glfw/src/linux_joystick.h#L31
I don't run Linux so you will have to debug it yourself. If you find a fix needed in Box2D, please reopen this issue.


Delta-bitpacked encoding Java implementation seems incorrect

This assumes that spark==3.1.1 uses the java reference implementation. Consider

import pyspark.sql
from pyspark.sql.types import *

spark = (
    pyspark.sql.SparkSession.builder.config(
        "spark.sql.parquet.compression.codec",
        "uncompressed",
    )
    .config("spark.hadoop.parquet.writer.version", "v2")
    .getOrCreate()
)

schema = StructType([StructField("label", IntegerType(), False)])

df = spark.createDataFrame([[1], [2], [3], [4], [5]], schema).coalesce(1)

df.write.parquet("bla.parquet", mode="overwrite")

This has no def or rep levels, is encoded with DELTA_BINARY_PACKED = 5, and results in the following page buffer:

buffer: [
            128,
            1,
            4,
            5,
            2,
            2,
            0,
            0,
            0,
            0,
        ],

Let's use notation

(encoded <=u> decoded via uleb128)
(encoded <=z> decoded via uleb128 zig-zag)

Let's decode the above buffer manually according to the specification.

byte 0: 128 <=u> 128, the <block size in values>
byte 1: 1 <=u> 1, the <number of miniblocks in a block>
byte 2: 4 <=u> 4, the <total value count>
byte 3: 5 <=z> -3, the <first value>
byte 4: 2 <=z> 1, the <min delta>
byte 5: 2 <=u> 2, the bit width of the (only) miniblock

I think that this is incorrect: the first value should be 1, not -3; the total count should be 5, not 4, the bit width of the miniblock should be 0, not 2.
Note that if byte 2 was removed, everything would be correct:

byte 0: 128 <=u> 128, the <block size in values>
byte 1: 1 <=u> 1, the <number of miniblocks in a block>
byte 2: 5 <=u> 5, the <total value count>
byte 3: 2 <=z> 1, the <first value>
byte 4: 2 <=z> 1, the <min delta>
byte 5: 0 <=u> 0, the bit width of the (only) miniblock

which corresponds to the delta-bitpack encoding of [1,2,3,4,5]:

5 elements
first value is 1
the min delta is 1
the relative differences are zero (bit_width=0) and thus do not require a buffer (writing 0 is also fine)

Reporter: Jorge Leitão / @jorgecarleitao
Note: This issue was originally created as PARQUET-2029. Please see the migration documentation for further details.

Jorge Leitão / @jorgecarleitao:
I made a mistake in computing the ul128: it should take 128 and 1. All good. Sorry for the noise.


Feature: Add basic backend configurations

Overview
Add the following charm configurations:

health-check-interval
backends-path
proxy-cache-valid

Add unit test for some error cases. The unit test coverage is back to 100%.
Rationale
These a basic configuration option related backend host for the content cache.
Checklist

[x] The charm style guide was applied
[x] The contributing guide was applied
[x] The changes are compliant with ISD054 - Managing Charm Complexity
[x] The documentation is generated using src-docs
[x] The documentation for charmhub is updated
[x] The PR is tagged with appropriate label (urgent, trivial, complex)

Still working on adding more integration tests.

@yhaliaw @jdkandersson This PR has been reviewed and previously approved by David, should I review it again ?

The publish-docs was not passing due to the main branch has wrong URL in the metadata.yaml.
David has confirmed force merging should fix this issue.


Cleanup Rust GitHub actions definition

Changes

various rust.yml file tweaks

Comments

I'm trying to fix the name of the action as it appears on the GitHub page. There might be something wrong/invalid in the workflow file causing that.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#249  👈
#248
#247
#246
#245
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forstmeier and the rest of your teammates on  Graphite

Merging with a series of fixes to the Rust stuff that I'm not 100% sure isn't going to break things.


Port to v2 Owner_api

Port to v2 Owner_api after grin's first hard fork.
https://www.grin-forum.org/t/grin-first-hard-fork-mid-july/5148)

Done in v0.4.0


Allow to disable security.allowedUNCHosts or allow wildcards to match a range of hosts

The new "security.allowedUNCHosts" in 1.78.1 setting breaks our workflow. We edit a lot of files on a lot of UNC hosts (around ~3k hosts per user, many users). How can the feature be disabled or all/regex hosts be allowed?
Alternatively, we could try to add all our UNC hosts. The list ist around 5mb (now) and changes on a hourly basis - editing this manually is nonsense, but neither security.allowedUNCHosts nor NODE_UNC_HOST_ALLOWLIST allows for centralized (and realtime) management.
Using a match pattern like \10.2.. or \(.).*.example.com would be our preferred method.

The current state of this is completely unmaintainable. Having to enter every single server to browse to is not realistic. I use VS Code multiple times a day to open to files on servers.
There should be a way to either provide a wildcard or disable this allowing people to accept the risk.

We absolutely need a way to enter a wildcard or disable the feature entirely.  Every workspace I use is now unable to be opened until I can add the paths of every folder to this list.  I don't have 3000+ constantly updating paths like OP, but this is still a huge pain when every single one of those paths that need to be added individually are located under a single root directory that should be able to be added ONCE.

For those who can't read the content of their folder in  \\wsl$\. In JSON settings, I added :
"security.allowedUNCHosts": ["\\wsl$"], According to : https://code.visualstudio.com/docs/setup/windows#_working-with-unc-paths.
Then, after rebooting VSCode it works again

I second @weed- 's comment. I have the same problem here.
Also, I tried to list the most used servers and IP addresses, but I still get the warning when opening a file. Is there a special format for the entries? Couldn't find any examples.
My settings file looks like this:
   "security.allowedUNCHosts": [         "abcde",         "<IP_ADDRESS>",         "hjfd"     ]

@bpasero is right and we do understand the risk of this Information Disclosure Vulnerability. UNC retrieval and meta data access (... NTLM delegation ...) is a hot mess in Windows anyway.
We need a way to be able to "willingly accept this risk". In a closed environment like ours (telko stuff) the risk is more a theoretical one anyway. So a "disable" setting or "enable glob patterns", if global matching is "not enough", would be extremely helpful.

@FVolral I have this problem, but am really new to using VSCode and can't quite figure out exactly how to edit JSON settings as you suggest? I followed the link you provided, but still not sure how I access and change the security.allowedUNCHosts setting? Many thanks for any help you can offer! Emily

I am going to stop using VS Code if this issue is not resolved.

Hello,
We use User Profile redirection at work and I have tried setting the needed environment variable "NODE_UNC_HOST_ALLOWLIST" to our NAS FQDN and still all our developers are unable to launch VSCode. I have been testing on version. 1.78.2.
Any way to allow the "risk" while MS works on fixing this "oops" without making the fix a breaking change?

I didn't really want to start a new issue just for this comment, but this really just breaks the WSL integration experience. I develop from my Windows OS on files inside my WSL2 VM. Previously, the experience was seamless in being able to open files from the WSL2 environment. Now instead of working by default, I have to allow wsl.localhost? That seems like an unnecessary security impediment for very little security gain. Please add wsl.localhost to the allowed list by default.

This is absurd and completely broke our workflow, Microsoft you need to be better.

At the minimum, It would be good to see this as a button prompt like you get for specific workspaces.  A button to Trust the location.  Which, isn't that really the same thing?

This has completely broken our workflow and required us to make an emergency change to another editor to continue working. While we would love to continue using VS Code, we cannot return to using it until something is changed with this implementation.
Ideally the option to disable this would work best, perhaps even an opt-in/out on first launch, but other means to mitigate it would be welcome in the short term at least. Seeing as this breaking change was implemented quickly, an update to the behavior can come just as swiftly.

Not exactly related to the topic, but I think in any case this change regarding UNC path issue should be very carefully designed and visibly announced and notified to end users. I just spent an hour figuring out why many extensions that are critical to my workflow stopped working, including the built-in TypeScript language service (it keeps crashing). Turns out these extensions cannot access any UNC path in any way (whether introduced by user configuration, or because the text file itself is actually using UNC path). I only accidentally discovered the cause when I tried to explicitly open a text file on a UNC path and saw an "allowed host" warning and was able to track it down.
I consider myself an expert VSCode user and developer (I have explored a lot of the codebase, written several VSCode extensions and language clients/servers and have done a ton of customization), and if it takes ma an hour to understand what is happening, it will only take other people a much longer time to figure this out.

for those of you. still get message error. try to open your setting.json file from visual studio code. after that add code like this
"security.allowedUNCHosts": ["Kbgatewaytest$", "Kbdev$"]

for example i have two diffrent path:

Kbgatewaytest
Kbdev
add symbol $ in the end of that path. after that save it.

I second @weed- 's comment. I have the same problem here. Also, I tried to list the most used servers and IP addresses, but I still get the warning when opening a file. Is there a special format for the entries? Couldn't find any examples. My settings file looks like this:  "security.allowedUNCHosts": [ "ABC", "<IP_ADDRESS>", "DEF" ]
EDIT: Got it: I put server names like "ABC" (upper-case) into settings, but it seems it has to be like "abc" (lower-case) 🤦🏼♂ Still just a temporary workaround...

"security.allowedUNCHosts": ["ABC$", "DEF$"]

Does GIOVANNI without the dollar sign work?

No it does not. Do i need to add something else like my local domain (fritz.box) or something? I also dont know how to access VSCode logs ...

This "fix" just complicated me life way too much. (and my coworkers)
Not the best solution. But it worked for us.
Roll back to 1.77.3, disable auto update and wait for MS to give us a working solution.

Guess you will need a local mapping to the drive first to access to remote file server..

This "fix" just complicated me life way too much. (and my coworkers)
Not the best solution. But it worked for us.
Roll back to 1.77.3, disable auto update and wait for MS to give us a working solution.

I am doing the same. Was about to go back to Sublime.

This "fix" just complicated me life way too much. (and my coworkers)
Not the best solution. But it worked for us.
Roll back to 1.77.3, disable auto update and wait for MS to give us a working solution.

I am doing the same. Was about to go back to Sublime.

Unfortunately this is also what I have done.

allowedUNCHosts
It was solved with this:

Ctrl + Shift + p
Open settings (UI)
allowedUNCHosts
Add item
wsl.localhost
OK
restart

I hope you can solve your problem!

I just wanna leave comment in disagree with this uncontrollable update. Some new troubles right before passing done work to my boss in the morning - nice big thank you!

I've just updated, got annoyed, and now reverted to 1.78. I have a few servers (not hundreds) and no way am I going to list all in VSCode just for some file editing maybe once a day.
Windows uses UNC paths all the time, and (when configured properly) that doesn't come up with warnings. Need an option to add regex, or wildcard, or just accept the Windows domain trusts - no expert, but assume that can be found and used.
Or, something that would go towards helping uses is a "add to exception" button on the warning popup, rather than just yes and no.

I'd love to see how many hits the 1.78.0 download link has gotten in the last 24 hours compared to a few weeks ago. This breaks our workflow as well since a lot of our code is on SMB file servers. Will be using 1.78 until this update gets pushed and documented.

Does anyone know if 1.78.2 fixed this issue or is it randomly happening to users? I have a Co-Worker using 1.78.2 and he can open files from the server with no issues. I am still on 1.77 and do not want to deal with the hassle of uninstalling 1.78.2 if the issues still persist for some users.

1.78.2 does not "fix" the issue.
I do agree that the user should be given a button or something to opt-out of UNC security fix and accept "risk".

We still need an upstream change before this will work. We plan for having it for our next stable release early June.

I find it concerning that it is going to take so long for a proper fix for this issue to be implemented and make its way into the live environment. Though even the current changes appears to be only a half measure and not a true proper fix. After the relatively short turnaround time for a massive breaking change to have been implemented and pushed live, I would have hoped for a faster resolution here.
Being able to open a UNC path file is a basic feature that any file editor from Visual Studio down to even basic Notepad supports out of the box, but now VS Code seemingly can't support that by default? To me at least, it seems baffling that VS Code will not be able to do this anymore as the previously mentioned change will also still default to UNC being blocked.

This type of sudden breaking change with no warning has unfortunately eroded a significant amount of confidence we once had in VS Code for being a primary tool in our workflows.

@ThiconZ the change for blocking UNC paths in VS Code is a response to a security vulnerability. Please see https://github.com/microsoft/vscode/security/advisories/GHSA-mmfh-4pv3-39hr for more information.

@bencfreeman I was thinking the exact same thing. We have an entire team devoted to security and servers. If there is something malicious on our servers we have much bigger problems than VS code.  I can still open up files on my server with The Enterprise Version of Visual Studio. How come Visual Studio allows it but not VS Code? I can do way more Damage with Visual Studio than VS Code.

The fix for this change will go out at the end of this week in our insiders build [1] and early June in stable build.
A new setting security.restrictUNCAccess can be used to disable the UNC access checks.
[1] Insiders builds normally release every day but are currently on-hold given the MSBuild conference that takes place.

How bad is this. Is someone looking to provide a better fix?

The monitor on my workstation died this morning and I had to rig up something temporary with laptop to get by. It is very frustrating to have to jump through hoops just to set up VS Code in a temporary dev environment so I can work. Remove this feature, or perhaps look into fixing whatever the vulnerability is on the server side. At this point it's more of a bug than a feature. Perhaps next time in your lengthy team discussions you might also consider the quality of the user experience.

Many settings in VS Code take effect immediately. Why do you have to restart (closing everything you already have open - remote connections, debug sessions...) in order to add a server to the allow list?

This setting is driving me crazy! Let us disable it please.

This "fix" just complicated me life way too much. (and my coworkers)
Not the best solution. But it worked for us.
Roll back to 1.77.3, disable auto update and wait for MS to give us a working solution.

Thank you this saved me tonight trying to find which version I had to go back to.

It's already June, when will the update roll out?
I don't want to click "Yes" tens of times whenever I start VSCode anymore
Or anyone has suggestions of better tools that won't just break your workflow without any warning like this?

Looks like the UNC security stuff is still enabled by default in 1.79.0. You'll have to manually go to settings on every VS Code install that you use and turn it off. I prefer VS Code's log file syntax highlighting over other text editors, and I have it installed on a bunch of machines just to view log files. 99% of the files we work with are on SMB shares. It's frustrating but at least we can disable the setting now. Find the "Security: Restrict UNCAccess" setting and uncheck it. And of course restart VS Code. Reminds me of the days of Win95 when you had to restart the whole machine every time you changed a setting. I hope future VS Code updates don't reset it back to default.

Still broken in 1.79.1, neither setting "security.restrictUNCAccess": false or adding hostnames/IP addresses to "security.allowedUNCHosts" works.
It seems like having a working way to add allowed hosts should have been a pre-requisite to disabling UNC, even if it's a critical security issue, not being able to use VSCode with any UNC paths is also a big issue.


Fallback to linear color texture when using 2D HDR and MSDF font

Fixes: https://github.com/godotengine/godot/issues/80646
The issue here came from the fact that, when using HDR rendering, Godot uses the "srgb" variant of the color texture. The srgb-variant ensures that the GPU does an srgb->linear conversion when the texture is read in the shader.
This causes problems when we use the color texture to pass in a texture that does not contain colors (like with MSDF textures). When a texture does not contain colors, we should not do any color space conversions at all.
This PR introduces a flag that can be used to ensure that the normal (non-srgb) texture variant is used.
No need to cherrypick as this relates to a new feature

Thanks!


[desktop] Configuration tab

PR to a desktop branch
TODO:

[x] create tab (probably use same layout as the old version)
[x] connect layout to API (probably old code will do the trick)
[x] fill backend (PR to simulations submodule) - link

Added in desktop branch init commit


[discussion] Capacity planning

When applying Kubeflow in our company, AI engineers meet some problems about the capacity. I am glad to discuss it with the community to find a better way to avoid it.
They complain that they always encounter OOM problem, since they may not know how to limit the resource used in the job. They want to let us tell them how to set the resource limit.
Then I investigate how to achieve it, there are some ways I know:

Compute the resource limit statically

If we could get the model, and we know which layers will be placed on CPU, we could calculate how much resource the container needs.
Pros: Easy to understand
Cons: Hard to implement, it requires some information about the graph and device placement.

Profiling

Profiling the job before actually running.
Pros: Easy to implement
Cons: Needs pipeline support (Run the profiling first and generate the resource limit)

Closed-loop (feedback) control

We should have some historical records about the similar jobs. We could refer to the jobs and adjust the resource limit of the new job.
Pros: No overhead
Cons: Maybe not very accurate.

Closed-loop (feedback) control with profiling or static computing

We apply profiling or static computing for the first time, then if there is an old job, then we use closed-loop (feedback) control to predict the resource that the new job will need.

Katib

We could treat the resource limit as a hyperparameter, then we train it using katib.
Pros: Reuse Katib
Cons: High overhead

I'd appreciate it if you could give me some advice.
/cc @ddysher @jlewi @ddutta @YujiOshima @cheyang @jian-he @bhack @ankushagarwal

I think it is an important feature while may not be implemented by the operator. Maybe on top of it or in the pipeline.

I think it could be a little bit a chicken and egg problem in some cases. I.e. see https://github.com/kubeflow/tf-operator/issues/628#issuecomment-396577600.
So are you just talking about minimum required resources?

The question is from AI engs. They said they are not sure about how many resources they should assign to the container. I think it should be the minimum required resources.

I have personally faced this issue of OOM and the cluster not having enough CPU, etc. Ideally, the solution would be to have elasticity built into our installation scripts so that the scripts can start with some calculated minimum and in case of failure, starts increasing the resource(s) that gave an error.
We can even have a dry_run option for installation to figure out what the minumum required resources are. What I am not clear about is whether it is easy to figure out from the error messages on kubernetes which resources have run out.

Thanks for bringing up the issue. The overall issue has much higher scope than tf-operator, but we can  probably start from minimal and see what we can do in tf-operator first.
I believe this is what borg does for resource estimation, where you gradually increase allocated resources and restart killed apps. For us, a big prerequisite is that we need ml apps to have checkpoint support unless it's explicitly a dry_run.

Ideally, the solution would be to have elasticity built into our installation scripts so that the scripts can start with some calculated minimum and in case of failure, starts increasing the resource(s) that gave an error.

There are a lot of moving parts, like whether it's a dedicated cluster for kubeflow vs. shared cluster, whether to use priority/preemption, whether to leverage QoS support in Kubernetes, etc. Solving the issue would take a long time, but for tf-operator, I would go for Closed-loop (feedback) control with profiling or static computing first as an opt-in feature. Once the feature is enabled, tf-operator will do resource estimation and create pods accordingly; admins are responsible to make sure monitoring is available, etc. This is sub-optimal as we do not take cluster-wide information into account, but do sound like a viable solution.

Does vertical pod autoscaling give us what we need? Can't we use vertical pod autoscaling to automatically bump up the pod requests if it OOMs?

@jlewi
It could solve the problem partially. Initial resoucres + VPA equals Closed-loop (feedback) control above.
BTW, VPA will restart the pod if it thinks the pod needs to be auto scale, which is not expected from user's view.


Release/0.16.0

This PR will upgrade provwasm to use cosmwasm 0.16.0 with compatibility for wasmd 0.18 and cosmos sdk 0.43.0

I think you'll want to update the integration test contracts, but LGTM so far.

my mistake, i meant to push the contract updates before submitting for review. they're included now


Fix tabline still show when there is only one buffer in some special scenarios

When I just do vim command, there is only one buffer, but the tabline is still show as:

And I just modify the g:showtabline variable to a more appropriate value obey the rule:
'showtabline' 'stal'    number  (default 1)
                        global
        The value of this option specifies when the line with tab page labels
        will be displayed:
                0: never
                1: only if there are at least two tab pages
                2: always
        This is both for the GUI and non-GUI implementation of the tab pages
        line.
        See tab-page for more information about tab pages.

Then I do vim command again, the tabline disapper as:

Could you test this PR https://github.com/bagrat/vim-buffet/pull/54?

Could you test this PR #54?
That pr is work too. :smile:

This pr is not suite for this plug, because there always only on tab page usually.

What did you mean by that? So you use tab page instead of buffer?

What did you mean by that? So you use tab page instead of buffer?

I used tab tage before I meet the vim-buffet. Now after I read the code of plug, I get it's base on buffers, set all buffers in one tab page default. So if I set g:showtabline to 1, there will no tabline show defautl. :disappointed: :

Even if you not using vim-buffet you should learn the difference between tab and buffer by that I mean usually what people call tab is actually buffer in vim, please read this post https://joshldavis.com/2014/04/05/vim-tab-madness-buffers-vs-tabs/

Even if you not using vim-buffet you should learn the difference between tab and buffer and by that I mean usually what people call tab is actually buffer in vim, please read this post https://joshldavis.com/2014/04/05/vim-tab-madness-buffers-vs-tabs/

sure， tks for your patient reply, i will see.:smile:


Log important PIDs and temp filenames for the tests to check cleanup

@richardstanton @jacdavis @gregg-miskelly

LGTM

🐑


Update go version to use go otel metrics

Towards #339.
Changes
In order to be able to use OTel Go Metrics we need Go version 1.18+.
Updated Go version and adjusted installation of protoc.
For significant contributions please make sure you have completed the following items:

[x] Appropriate CHANGELOG.md updated for non-trivial changes
[ ] Design discussion issue #

Closing this. Covered in 409 to unblock others


Ensure actions are executed from a restored initial state.

The issue was that when restoring from an initial state, state.actions weren't being resolved against the specified machine.options.actions action mapping, so actions weren't being executed.
Fixes #1174

I'm having second thoughts - actions are being considered fire and forget, so this is very likely that actions for a particular state has already been executed and only after that the state has been persisted and rehydrated later. In such a case action would be fired twice - which is not necessarily always a good thing. It should be up to a developer to decide about this because we don't know what's their strategy for persistence & rehydration.

Regardless, this PR is still correct, because there is a bug where actions aren't being resolved correctly, even though they should. The fix is general.
The behavior of whether or not those resolved actions should be executed is a separate issue, but I agree, it should be addressed.

👌


MySQL specific query on Blade template, it will fail with other DB engine

Describe the bug
This is a MySQL specific query on Blade template, it will fail with other DB engine
https://github.com/GrafiteInc/Builder/blob/356ebdcbc6b5d99769696c94e3a8e56652913c2a/src/Packages/Bootstrap/resources/views/admin/dashboard.blade.php#L60
To Reproduce
Steps to reproduce the behavior:
use any other DB e.g. SQLite on unit tests

Since the dashboard is published to your application and you can modify it as you see fit, feel free to remove this. Any updates in the future will not affect this.


Added Crypt as a dependency and coverted code to use Crypt

Codecov Report

Merging #24 into develop will increase coverage by 4.34%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop      #24      +/-   ##
=============================================
+ Coverage      52.92%   57.26%   +4.34%
  Complexity       373      373
=============================================
  Files             37       35       -2
  Lines           2003     1851     -152
  Branches         290      269      -21
=============================================
  Hits            1060     1060
+ Misses           859      707     -152
  Partials          84       84

Impacted Files
Coverage Δ
Complexity Δ

...browserdriver/manager/defaults/DefaultManager.java
96.07% <33.33%> (+8.18%)
81 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e93e3d...67b40dc. Read the comment docs.


Autogenerate query entity by primary key

I think it could be useful to autogenerate the query to read entity by primary key.
We can change the following:
  @Query('SELECT * FROM tblRooms where roomId = :roomId')
  Future<RoomEntity> getRoom(int roomId);

with this:
  @read
  Future<RoomEntity> getRoom(int roomId);

We can do a similar thing for foreign key table.
We can change the following:
  @Query('SELECT * FROM tblStudents where roomId = :roomId')
  Future<List<StudentEntity>> getStudents(int roomId);

with this:
  @readDetails
  Future<List<StudentEntity>> getStudents(int roomId);

What do you think?

I definitely see the appeal in this functionality. I'm still uncertain about the naming of these annotations. I'll have a second thought about it. Nevertheless, I would love to get the current API to a stable level before introducing new functionality.
The feature could also get expanded to simplify the retrieval of all rows of a specific table. E.g.
// current
@Query('SELECT * FROM entity')
Future<List<Entity>> getAll();

// with new annotation
@selectAll
Future<List<Entity>> getAll();

Hi,
maybe we can use a single annotation for everything:
@read
Future<RoomEntity> getRoom(int roomId); // This read the RoomEntity based on the parameter (The name match with database name)

@read
Future<ClassVsRoomEntity> getClassVsRoom(int roomId, int classId); // This read the ClassVsRoomEntity based on the parameters (The names match with database names)

This will make it very flexible as you can use as much parameters as you like to retrieve the entity/entities
What do you think?


[kudu] Add Kerberos keytab support

[kudu] Allow specifying kerberos keytab and principal in configuration

any of the prior kudu contributors up for reviewing this? @toddlipcon @jdcryans @danburkert ?


[vscode-graphql-syntax] GraphQL: Syntax - highlight error

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I have .cts file in vscode with content
const a = 47

const is being highlighted with message: Syntax Error: Unexpected Name "const".GraphQL: Syntax
When i disable vscode extension GraphQL: Language Feature Support - highlight error does not shows up

Expected Behavior
In .cts files should not display errors from GraphQL: Syntax when no GQL syntax is being used
Steps To Reproduce
Install vscode plugins:
- GraphQL: Language Feature Support  v0.8.4
- GraphQL: Syntax Highlighting  v1.0.5

create any .cts file
and write valid typescript ex.
const a = 47

vscode will highlight const with error: Syntax Error: Unexpected Name "const".GraphQL: Syntax
Environment
- VSCode plugins:
  - GraphQL: Language Feature Support  v0.8.4
  - GraphQL: Syntax Highlighting  v1.0.5
- OS: Fedora 36

Anything else?
No response

This should be resolved by #2926, is it still an issue? if not, it may be because we haven't been able to make a release yet. sorry we didn't tag all the related bugs in the PR

Note that I'm seeing the same problem in MDX files. It seems the extension is trying to parse file types it doesn't understand.


Issue 9995: adding known issue description for WARP + Docker on Linux…

Issue 9995: adding known issue description for WARP + Docker on Linux relating to mtu size
closes #9995
Issue 9995
Updates to WARP known issues and link from WARP Client to the same list of limitations

Hi @cdrubin, thanks for opening this PR! Let me know if the copy-edits look ok to you and I will merge it in.


Split off metadata

As - unlike with the Headers class -, the static methods in the Package class can not easily be overloaded, I'd suggest splitting them off into a separate Metadata class which can be overloaded.
This will make it a lot easier to add additional information to the metadata for a package.
All you need to do is extend the Metadata class and overload the $cacheTime $headerMap, $readmeMap and/or constructor to add additional data.
You will of course also need to overload the Package::fromArchive() method to use your extended class rather than the original, but as it's now a small method, it doesn't break the upgrade path as much as before.
Simple example code for how this could now be overloaded:
class My_Metadata extends Wpup_Metadata {

	protected $headerMapExtra = array(
		'Text Domain' => 'textdomain',
	);

	protected $readmeMapExtra = array(
		'short_description',
	);

	public function __construct( $slug, $filename, Wpup_Cache $cache = null ) {
		$this->headerMap = array_merge( $this->headerMap, $this->headerMapExtra );
		$this->readmeMap = array_merge( $this->readmeMap, $this->readmeMapExtra );

		parent::__construct( $slug, $filename, $cache );
	}

	protected function extractMetadata() {
		$metadata = parent::extractMetadata();
		if ( ! is_array( $metadata ) ) {
			return null;
		}

		// Add additional metadata
		$metadata['type'] = $this->packageInfo['type'];

		return $metadata;
	}
}

Sorry about not doing anything with this, but I keep struggling with what you propose.
The choice for sticking with static methods and even adding static properties in this case is IMHO just wrong.
The split into two classes is justified as - as documented in the original class - metadata can be retrieved from other sources (db/config file). The implementation I propose(d) in this PR makes it simple to either swap out the Wpup_Metadata class for a completely custom implementation for retrieving the metadata or to overload it like shown in my original post - all while maintaining full backward compatibility.
Your suggested implementation on the other hand would make it more complicated rather than simpler.
Sorry, but I stand by my original PR.

Nitpick: Still, what's the problem with static methods and static properties? Is it a style issue? Why is it better to use instance methods in this case?

Static methods and properties have their place in programming, just not in this situation.
@mathiasverraes has explained this much better than I could in this blogpost.
What it comes down to is that the methods in the PR could have widely different implementations (taking the data from a database, config files, which metadata will be available) and are therefore not stateless nor entirely predictable.
Here are some more articles which argue in a reasonably balanced manner when to use static and when not (even though the titles are misleading):
http://simpleprogrammer.com/2010/01/29/static-methods-will-shock-you/
http://www.phparch.com/2010/03/static-methods-vs-singletons-choose-neither/
http://kore-nordmann.de/blog/0103_static_considered_harmful.html

@YahnisElsts Thank you for taking the time and your detailed feedback.

Someone who needs to load metadata from a different source probably wouldn't gain much by resuing it, and would instead either write a completely independent implementation or subclass Wpup_Package.

In which case that custom implementation is now easier to call what with the $packageFileLoader property in the UpdateServer class which I implemented based on your suggestion.

Rename Wpup_Metadata to something like Wpup_ZipMetadataParser

Done.

Make a general Wpup_Metadata class that only contains stuff that would apply to all packages.

I considered it, but as you say it would be extremely bare, so I left that out for now until there turns out to be a call for it. Would be easy enough to implement anyway.

Why is setMetadataFromArchive() public? It's not called from anywhere outside the class.

Artefact from the original static implementation. Fixed.

This bit looks suspicious to me: ... ... Now it's obvious that $meta is always an array, and that the methods add something to that array.

As it's now a class and the data gets send to the $metadata property anyway, I've now refactored the code to use that property everywhere rather than passing the data around all the time.
I've also abstracted out the code a bit more. The original implementation stayed very close to the original methods. I've now refactored it to be more like a proper class ;-)
Hope you approve of the changes.

Some thoughts:
Since this is now a class and not a public method, there's no need for extractMetadata() to report an error by setting $this->metadata to null. Just let it throw new Wpup_InvalidPackageException directly and get rid of the null check in createMetadataCache.
On a related note, I disagree with the idea of splitting the cache-related stuff into setMetadataFromCache and createMetadataCache. Caching is an optional optimization layer. I think it should be as unobtrusive as possible and most code shouldn't know or care about the cache. Calling the main entry point to the parser logic setMetadataFromCache gives caching far too much weight.
Also, in my experience, this is a fairly common pattern when working with cache:

Try to retrieve data from the cache.

On success, return it and exit.

Generate data the slow way.
Store it in the cache.

These are all closely related operations. Why split off the last two?
Another thing I noticed is that setHeaderFields and setReadmeFields are very similar. Both of them copy values from one array to another based on a list of keys. It would be possible write a more general method that maps specific keys from an input array to $this->metadata. Something like setMetadataFields($sourceArray, $keyMap) (names need work).
setReadmeSections is also very similar, except it transforms key names and has no filter, accepting all keys/sections. A more complicated version of setMetadataFields could handle that as well.
Finally, a minor style issue: in extractMetadata, that else should look like this: } else {.

Thanks for your feedback again. I agree with most of your points and probably would have done those things already if I wasn't working on ten things at the same time ;-)
I've updated the PR incorporating most of your points.

setReadmeSections is also very similar, except it transforms key names and has no filter, accepting all keys/sections. A more complicated version of setMetadataFields could handle that as well.

I've looked at combining that into the new method as well, but with there being three differences between how things would need to be handled, it would actually result in a lot more code, rather than less.
The three differences being:

no map, everything is accepted
the str_replace() for the section name
the sections going into a 'sections' subarray within $metadata

Hope we got everything now.

I've looked at combining that into the new method as well, but with there being three differences between how things would need to be handled, it would actually result in a lot more code, rather than less.

In theory, you could make the mapping function handle the differences by making it more general and extracting filtering/key mapping logic to a separate method or closure:
protected function mapFields($input, $map, $transform){
	$output = array();
	foreach($input as $fieldKey => $value) {
		$metaKey = call_user_func($transform, $fieldKey, $map);
		if ( $metaKey !== null ) {
			$output[$metaKey] = $value;
		}
	}
	return $output;
}

/* This is the default $transform */
protected function getMappedKey($fieldKey, $map) {
	return isset($map[$fieldKey]) ? $map[$fieldKey] : null;
}

/*...*/

$this->metadata['sections'] = $this->mapFields(
	$this->packageInfo['readme']['sections'],
	array(),
	function($sectionName, $dummy) {
		return str_replace(' ', '_', strtolower($sectionName));
	}
);

... but it is indeed more code.

@YahnisElsts So are we good to go now ?

Thank you!


Rename inner-PEC and outer-PEC

At the very least these should not have capital letters.
Or, we could use names like:

'pec-worker' and 'pec-host', or
'particle-execution-context' and 'particle-execution-host'

why do you hate the PEC?

'particle-execution-*' seems friendlier to new developers than PEC does.

I assumed 'context' is InnerPEC and 'host' is OuterPEC but if somehow I've deviated from intent let me know. I found we actually already have a ParticleExecutionContext class which does nothing and is only extended by OuterPEC.


NEW SHEET/ OFFICIAL / THE AETHYRBLOOD CHRONICLES

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: < THE AETHYRBLOOD CHRONICLES  >

The publisher of this game is: < HAPHAZARD PROJECTS  >

The name of this game system/family is: < DPS System ('dice pool scales') >

[x] I have followed the Character Sheets Standards when building this sheet.

[x] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.
[x] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < https://www.drivethrurpg.com/en/product/364098/The-Aethyrblood-Chronicles-Core-Rule-Book  >

Changes / Description

Character Sheet Info Roll20 Internal Use only.

Hey @VJRolmasters!
We can't open the preview image and github is saying it's an invalid source. Once that's fixed, we should be able to move forward!

n't open the preview image and github is saying it's an invalid source. Once that's fixed, we should be able to move forward!

Hi,
Just deleted the image and upload the preview png file again, it seems to work.


New version: chmln.sd version 1.0.0

Resolves #125364
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Executable-Error


Add download link for linkedin video

It would be great if we can download linkedin video
Describe the solution you'd like
A button or link can point to the video to be downloaded or point to a service

There is an example for how to add custom buttons to the linkedin UI, for the select messages for deletion usecase on the messaging screen. Whoever will be resolving this should look into that implementation first.


M1 still have issues using lightGBM

When I ran the bash scripts/install_poetry_macos_m1_chip.sh
I get the following error
Error: Failed to load cask: librdkafka.rb
Cask 'librdkafka' is unreadable: wrong constant name #<Class:0x00000001362484e8>

When I ran lightGBM, it's getting the following error
Traceback (most recent call last):
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/bowen.chen/LLM/energy-forecasting/training-pipeline/training_pipeline/hyperparameter_tuning.py", line 18, in <module>
    from training_pipeline.models import build_model
  File "/Users/bowen.chen/LLM/energy-forecasting/training-pipeline/training_pipeline/models.py", line 1, in <module>
    import lightgbm as lgb
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/site-packages/lightgbm/__init__.py", line 8, in <module>
    from .basic import Booster, Dataset, Sequence, register_logger
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/site-packages/lightgbm/basic.py", line 110, in <module>
    _LIB = _load_lib()
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/site-packages/lightgbm/basic.py", line 101, in _load_lib
    lib = ctypes.cdll.LoadLibrary(lib_path[0])
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/ctypes/__init__.py", line 460, in LoadLibrary
    return self._dlltype(name)
  File "/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/ctypes/__init__.py", line 382, in __init__
    self._handle = _dlopen(self._name, mode)
OSError: dlopen(/Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/site-packages/lightgbm/lib_lightgbm.so, 0x0006): Library not loaded: /usr/local/opt/libomp/lib/libomp.dylib
  Referenced from: <D21A7969-4567-3BC7-94ED-6A9E83AE9D78> /Users/bowen.chen/opt/anaconda3/envs/energy_forecasting_feature_pipeline/lib/python3.9/site-packages/lightgbm/lib_lightgbm.so
  Reason: tried: '/usr/local/opt/libomp/lib/libomp.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/usr/local/opt/libomp/lib/libomp.dylib' (no such file), '/usr/local/opt/libomp/lib/libomp.dylib' (no such file), '/usr/local/lib/libomp.dylib' (no such file), '/usr/lib/libomp.dylib' (no such file, not in dyld cache)

Is there anything I did wrong?

Sorry to hear that. Unfortunately, I can't help you with this as I don't have a M1/M2 machine.
@gao-hongnan wrote the file.
@gao-hongnan Sorry to bother you, but could you please take a look at this issue to help us out?

@chen-bowen May I confirm with you the following:

Did the script continue to run? The first error is related to the installation of hopswork as the solution proposed is to build from source at a particular version.
Your error seems to be about lightgbm, can you try to do brew install cmake and brew install libomp?  The solution inside the script follows from the reference here.

If after brew installing both packages still result in an error, could you paste a more detailed log, thanks!

@gao-hongnan Thank you for your help ✌

looks like it worked with manually install cmake and libmop, thank you so much!


fix:Removing backlinks code after migrating to reporting worker

Please ensure your pull request adheres to the following guidelines:

[ ] make sure to link the related issues in this description
[ ] when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues
Thanks for contributing!

:tada: This PR is included in version 1.10.25 :tada:
The release is available on:

v1.10.25
GitHub release

Your semantic-release bot :package::rocket:


ci: Try to fix cache failures when running GH actions

Make env.pythonLocation as part of the cache key, as suggested by https://github.com/wntrblm/nox/issues/735#issuecomment-1854599576
Remove the generic option from restore cache to avoid the same issues we had before
Use uv as the default venv backend for a performance improvement when installing packages (updated nox for this)
Remove strategy: fail-fast in some places where we are not using matrix, and thus this was not doing anything

Apollo Federation Subgraph Compatibility Results

Federation 1 Support
Federation 2 Support

_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🔲

@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Apollo Federation Subgraph Specification
Compatibility Tests

@sourcery-ai review

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

@bellini666 looks like it is an issue with the latest version of starlette 🤔


browserHistory.replace() reloads page in Chrome for iOS

I'm not sure if this is a bug in browserHistory or the iOS Chrome app, since it only occurs in that browser--not in the iOS Google app, Safari for iOS, Chrome for Windows, or Microsoft Edge--but when I call history.replace(), the url changes and the page reloads, rather than just updating the url and route.

Fixed on master of history.

I'm not super familiar with how npm works... just enough to get by.  I ran npm install history and npm install react-router, and I still have the same issue.  Do I need to pull a specific version of history or something?

No, it's not release yet.


Update index.md to fix issue #666

[x] Synchronize the Chinese version with the English version update by issue #666
[x] Fix some typos
[x] Supplement the translation of TAB names and corresponding questions

Remove this line to delete the note at the top of the page.
Current Chinese maturity model has a note explaining that the translation has not been updated from the English version.

It's done.

Hi @node thank you so much for your work on this.
I believe we still need a review from a native speaker on this, is that right?

Hi @node thank you so much for your work on this.
I believe we still need a review from a native speaker on this, is that right?

That's right.


How to control the size of the heatmap section to make more space for the legends section?

Whether it is a single heatmap or a double heatmap, sometimes the space of legends does not fully display all the legends content.
I've also noticed this in the PyComplexHeatmap document example.

Thanks for reporting this. It has already been fixed.
Please re-install from github.

No, there's no change. It can't work.

It works on my side.
You need to uninstall and install again from github:
pip uninstall -y PyComplexHeatmap && pip install git+https://github.com/DingWB/PyComplexHeatmap

You can also increase legend_width to assign more space for legend

If legends had only one column, it would show up very well. If there are many legends in two columns, it will still be incomplete. I tried to set the legend_width, but it doesn't seem to work. Why?
This is the automatic legend width :
Collecting annotation legends..
Collecting annotation legends..
Estimated legend width: 35.102777777777774 mm
Display as shown :

Then I set the legend_width :
cm_ax, legend_axes = composite(cmlist=cmlist, main=0, legend_hpad=2, legend_y=0.88, legend_gap=10, col_gap=0.1, With width_ratios=[1, 1.2], legend_width=40),
I should have expanded the legend_width to 40, but The image hasn't changed at all.

Can you share your code and data with me? @muzier9
You can also send me simulated data so that I can reproduce this issue and fix it.

I test with this example data, and it works (https://dingwb.github.io/PyComplexHeatmap/build/html/notebooks/composite_heatmaps.html)
Here is the result

Can you try a larger legend_width? Such as 60 or 100?

I have sent the code and test data to you by email. Can you check it? I changed the legend_width and it didn't work.

I know what the problem is. The ide I used before is Pycharm, I changed it to the one you use Jupyter and tried it again, and it can be successfully modified. But I want to use Pycharm for window display graphics, do you have any good ideas?

It is working. Nothing wrong with the code. You should learn how to adjust the parameter

I know what the problem is. The ide I used before is Pycharm, I changed it to the one you use Jupyter and tried it again, and it can be successfully modified. But I want to use Pycharm for window display graphics, do you have any good ideas?

Just save it to pdf and the PDF should be fine
plt.savefig("test.pdf", bbox_inches='tight')
plt.show()

Yes! The saved pdf displays very well. I also wonder if there is any way to make the window display complete like pdf?

No idea. You can explore it or search for it on Google about the pycharm.

Thank you very much. These are very useful to me.

I just released a new version (1.8.1); you can install it using pip
Please help me test it; if you find any issues, please report them.

OK. I will use the new version.


Miscellaneous compile time and run time fixes

Miscellaneous fixes that were required when porting OFP to a bare metal environment with a custom ODP implementation.
Commit c0f98a8 should be of special interest since I think without this, all port hash table computations will collapse into slot 0 of the hash table (the uninitialized port hash mask is probably still 0) which is detrimental to performance.

Hi Ola,
Nice catch. It is nice to see that ofp is still dragging attention.
I am not sure who can review and push this change as Nokia & Enea are not active. But ARM has a maintainer in this project, right?
Myself, I am working on a commercial version of ofp, named nfp: https://github.com/NetInoSoftware/nfp
Best regards,
Bogdan

I talked to someone at Nokia, they said they would handle GitHub pull requests.

Heh, thanks Bogdan. No comment on whether I really ever left, or came back.

CI is now using github actions, so if you update this PR, please remember to rebase so that we get a CI run.

I updated one commit (088351e) and removed another (the NULL check).
Should I "Update with merge commit" (which seems to be default) or "Update with rebase" (which feels more natural to me)?

Should I "Update with merge commit" (which seems to be default) or "Update with rebase" (which feels more natural to me)?

Rebase, please.

Any progress here? I think all that is needed is the rebase and also the commits need descriptions and signed-off-by tags.

Sorry for the delay, I was in Powerpoint mode for a month...
I rebased and updated the OFP_CONCAT commit per your request.
What kind of descriptions do you want for the commits? And who can sign off? I am all alone here with OFP work...

Your signed-off-by tag is enough. Please also add
Reviewed-by: Jere Leppänen<EMAIL_ADDRESS>Description for each commit should state what is changed and why. Just one or two sentences is enough for these commits.
I missed this earlier, but the subject lines of the first and last commits should be prefixed with "api:", i.e.
api: Add OFP_ prefix to _IN_PORT_T_DECLARED symbol
api: Add OFP_ prefix to SOMAXCONN symbol

And finally, if you like, you could fix the checkpatch warnings: https://github.com/OpenFastPath/ofp/runs/5738785370?check_suite_focus=true You didn't touch those parts of the changed lines, so this is optional.


[MM-46437]: removed submitting the forward on pressing enter

Summary
for some users submitting the forward modal on hitting enter was proving to be buggy.
This is due to the character replacement (in japanese it is common to write hiragana, which then gets converted to a kanji with a popover) happening in a popover which is still technically a part of the modal and therefor pressing enter will be seen as a trigger for submitting.
This is fixing that behavior.
Ticket Link
MM-46437
Related Pull Requests
n/a
Screenshots
n/a
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/239318

Thanks @michelengelen
tested, looks good to merge - pending e2es
Verified forwarded message is not submitting on enter while drafting comment. Tested in English and Japanese.

@koox00 kind reminder to review


Add support for local source file url scheme

Allow to specify a local file as source:
source:
  - url: file:///build/rich/rich-{{ version }}.tar.gz
    sha256: fb9d6c0a0f643c99eed3875b5377a184132ba9be4d61516a55273d3554d75a39

Fix #176
I never wrote any rust before, so this might require some change :-)

LGTM! Thanks :)


The timer is reset when switching to any window

When switching focus to any window in Visual Studio, even if it is not associated with open documents, or when running Debug (loss of focus from the window), the timer is reset, while the document tab has not changed.

switch to another file is reset the timer, please make the ability to control it

Feature #2 introduces this ability, you can choose a trigger when you need to reset the timer (file, project, solution) or disable timer.

Feature #2 introduces this ability, you can choose a trigger when you need to reset the timer (file, project, solution) or disable timer.

Waiting for this feature

A new update is expected soon. There were some problems with uploading the extension into the Visual Studio marketplace. Probably the release of the new version will appear earlier here - in this repository. But I would like to upload extension in the VS marketplace at the same time.

do we have #2 in this update?

do we have #2 in this update?

Of course, yes


app: frontend: plugins: Update typescript version to 5.5.4

Typescript version is inconsistent across packages, and the one in the frontend/ is quite old

Testing done:

[ ] Generated new API docs and previewed them in the headlamp website

Actions needed after this:

Update links in the documentation that point to any page in API (since folder structure is different now)
Explore more options/plugins for typedoc to make API reference more approachable

For now I'm keeping the current generated API docs as is


Add support for executing queries from graphql files

This adds support for executing queries via the CodeLens
from .graphql files. It also adds support for .graphql files
with multiple queries.

@ganemone : Thanks for the PR 🙌
@KevinGrandon : Thanks for the review.
I also reviewed it and tested it with @marktani
Looks good to me. Merging.
Will release this soon.

This is released in 0.1.6 🎉
Sorry for the delay in releasing this, there was an issue with our marketplace account 🙏


Use Standard User for Cluster Operations

What does this PR do?

Creates and utilizes Standard User for Cluster Operations of SupportMatrix tests
Refactor EKS tests

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #91
Checklist:

[x] GitHub Actions: EKS, AKS, GKE

EKS: https://github.com/rancher/hosted-providers-e2e/actions/runs/9129743291
GKE: https://github.com/rancher/hosted-providers-e2e/actions/runs/9129748013


making batch call for multiple id

Rather than making individual calls for each entity, it makes a batch call to cassandra using IN clause

Hello,
sorry for taking so long to come back to this.
The right way to speed up retrieval of multiple entities is not the use of an IN where clause (this is related to how partitioning works in Cassandra), rather one should send the per-entity requests in a concurrent and not sequential way.
With this technique, I have been able to measure performance improvements of 2.5-3x, depending on how many entities at once are fetched.
This is being worked on in my branch https://github.com/hemidactylus/feast/tree/sl-cassandra-optimize-bulk-reads for the main Feast repo, which will be soon submitted as PR to the Feast codebase.
(indeed, this stand-alone plugin is now deprecated in favour of the Cassandra plugin in the contrib folder of the main Feast repo).
I'm going to close this PR now, feel free to reopen or connect via the Feast Slack to discuss further.


fix: for api-redirection

Description

Fixes the API redirection problem where forwarding location only has uri path

This Pr adds null pointer checks for host address, adds stack trace in logging, and fixes the problem of erroring out when the  called endpoint redirection headers don't have full formed forwarding location
PR fixes following issue(s)
Fixes #25408
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Manual
[ ] JUnit

Test Plan

Tried out with the  endpoint of the API hosted on Manish's ngrok, GET and POST requests fail with the java null pointer exception. However, on this DP, both GET and POST requests work.
Tried out Sanity tests with other end points on Rest API
Did Sanity checks on GraphQL
Saved Rest API and GraphQL as datasource and ensured that works fine too
Exported this app, imported the same and ran the API to check for functionality

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[x] Test plan covers all impacted features and areas of interest
[x] Test plan has been peer reviewed by project stakeholders and other QA members
[x] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true

Completed Manual testing of this PR. Works fine. @sondermanish  do let me know once your automation cases are added for this

/ok-to-test

As per discussion with @sondermanish  - since junit tests are added, adding the test plan approved label.

/ok-to-test


Adding keys

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Please add his keys. Himanshu is a member of IAM team.

looks good. @mayankkapoor please add him to the github org and merge this.

Looks good. Merging.


Question on CondensingLinear

Hi I notice the aim of the function(CondensingLinear) is mentioned in this answer https://github.com/ShichenLiu/CondenseNet/issues/6#issuecomment-351598403,
Does CondensingLinear in layers.py only be used at convert_model phase, not in the training phase?
Therefore the evaluation error on converted model will be higher than the model in the
training phase, right? It is like directly pruning out 50% of the last fully connected layers
without finetuning.

Yes, that is correct. However, it does not affect the test error significantly. We reported in the paper the actual eval error rate instead of training phase eval error rate.


'quoting' property is not in schema for dbt_project.yml

Issue:
The following block of yaml config throws a yaml-schema error, but should be valid config per DBT docs here
quoting:
  database: false
  schema: false
  identifier: false

Good spotting! I'd welcome a PR to fix this 🛠


j

Extension Name: merge-conflict
Extension Version: 1.0.0
OS Version: Windows_NT x64 10.0.17134
VSCode version: 1.28.0

We have written the needed data into your clipboard. Please paste:

Please see #60318


feat: add a utility to convert an input graphQL filter into an RDS query expression

Description of changes
This PR adds functionality primarily on two things:

adds a utility helper method on [preview 1 readiness] RDS feature support for Amplify that converts the input graphql filter to the AWS RDS or mysql query expressions that maps the fields in a schema type to a data source - AWS RDS resulting in a mySQL query.

converts the resultant RDS filter expression to a knex filter type so it'll be agnostic to different DB engines

For example:
A graphQL query passed as an input argument to the helper method toRDSQueryExpression results a mapped mySQL query as shown below:
Input: ( a GraphQL query)
const inputVariables = {
  id: '1',
  name: 'Amplify',
  age: 20,
  address: {
    street: '123 Main St',
    city: 'Seattle',
    state: 'WA',
    zip: '98101',
  },
  filter : {
    and: [
      { eq: { id: '1' } },
      { startsWith: { name: 'Amplify' } }
    ],
  },
};

passing the input filter to the helper method:
const rdsQueryExpression = toRDSQueryExpression(inputVariables.filter);

Output: (an RDS expression)
console.log(rdsQueryExpression);

id = 1 AND name = "Amplify%"

This PR supports input GraphQL filters' QueryGroup & Operators as well as Nested QueryGroups with Nested Operators (complexFilter):
QueryGroup = [and, or, not]
Operators = [attributeExists, beginsWith, between, contains, eq, ge, gt, le, lt, ne, notContains]
Nested QueryGroups with NestedOperators:
const complexFilter = {
    and : [
        { id : { eq : '123' } },
        { or : [
            { name : { eq : 'Amplify' } },
            { and : [
                { org : { eq : 'AWS' } },
                { age : { between : [`18`, `160`] } },
            ]},
        ]},
    ],
};

passing the inputFilter argument to utility method toRDSQueryExpression:
const rdsExpression = toRDSQueryExpression(complexFilter);

Output:
console.log(rdsExpression);

((id = '123') AND ((name = 'Amplify') OR ((org = 'AWS') AND (age BETWEEN '18' AND '160'))))

With this PR, the resultant query expression - rdsExpression also converts to a knex filter type so it'll be agnostic to different DB engines.
For example, this can be consumed by the knex libraries to perform and fetch filter queries of rows from the actual database.
knex.select().from('employee_details').whereRaw(`column = ? `, [rdsExpression]).then(rows => {
            console.log(rows);
});

where employee_details is a db_table with rows & columns.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Todo:

Discuss NOT graphQL filter equivalent in RDS Query expression
Implement size
Write test cases on knex: Test the resultant expression (output of the utility method) - toRDSQueryExpression as an input feed to the knex.js libraries & verify it to be in a Knex.js compatible format - agnostic to any DB engines.

Before you commit, you'll need to run yarn api-extract to update the API.md files

We can't build the queries by just substituting into strings/string concatenation, we'll have to use parameterization to block SQL injection on filter arguments
.fromRaw('(select * from "users" where "age" > ?)', '18')
You can find docs on it here, best way to handle it would probably be to return the string query and a list of all the arguments in order. Then we can deconstruct that list to pass as the arguments to the knex query

So to answer Marc's comment:
I think to prevent sql injection situations, as Marc mentioned, we can parameterize the query like:
while using any knex method, for example: .whereRaw here:
knex.select().from('employee_details').whereRaw(`column = ? `, [rdsExpression]).then(rows => {
            console.log(rows);
});

this can separate the actual sql query from the "data" & hence, prevent any malicious sql injection

Codecov Report

Merging #1209 (2d51331) into feature/rds-support (a08589a) will increase coverage by 0.06%.
The diff coverage is 77.77%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@                   Coverage Diff                   @@
##           feature/rds-support    #1209      +/-   ##
=======================================================
+ Coverage                63.52%   63.58%   +0.06%
=======================================================
  Files                      301      302       +1
  Lines                    18987    19085      +98
  Branches                  4585     4621      +36
=======================================================
+ Hits                     12062    12136      +74
- Misses                    6311     6335      +24
  Partials                   614      614

Impacted Files
Coverage Δ

...-graphql-model-transformer/src/resolvers/common.ts
75.51% <77.77%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

closing this in favor of #1236


chore: upgrade installer jdk version to 21.0.4+7

@rberezen we need to test installers generation.

@rberezen we need to test installers generation.

@tati-qalified what os can you check?

@rberezen Windows and maybe Ubuntu

@rberezen Windows and maybe Ubuntu

could you please check Windows, I'll check the rest
https://github.com/liquibase/liquibase/actions/runs/10251637098 - installers should be availabe here when job is finished

@rberezen Windows and maybe Ubuntu

could you please check Windows, I'll check the rest https://github.com/liquibase/liquibase/actions/runs/10251637098 - installers should be availabe here when job is finished

okay, we need to have liquibase-pro branch with the same name to build installers
I'll create one and trigger build again

@rberezen something strange happens - I had v4.25.0 in my path environment variable, and when I ran the installer with the option to update my existing version, it for some reason updated v4.23.0, which I didn't have linked anywhere.
It didn't change the value in the path, it just added a new variable with the new path.
Any ideas on why this could be happening?

@tati-qalified honestly, have no idea, try to reproduce again but make some clean up on your environment (remove old versions, env variables, etc)

@rberezen here are the installer options:

When I use "update the existing installation" and tick the "add liquibase to path" box, it doesn't check if it's already in the path. It will add it again instead of modifying the old one:

As the previous version is higher up on the list, that's the one that will be considered by the PC.
I think this beats the purpose of updating the existing installation

@rberezen here are the installer options:
When I use "update the existing installation" and tick the "add liquibase to path" box, it doesn't check if it's already in the path. It will add it again instead of modifying the old one:
As the previous version is higher up on the list, that's the one that will be considered by the PC. I think this beats the purpose of updating the existing installation

agree, but I think this is not introduced in this PR and should be fixed as a separate issue
cc @filipelautert


wrapping react component error -- Global CSS cannot be imported from within node_modules

Trying to wrap the react-virtualized component and getting this error. Any ideas on how to address this?

./node_modules/react-virtualized/styles.css
Global CSS cannot be imported from within node_modules.
Read more: https://nextjs.org/docs/messages/css-npm

@benwilks howdy, did you resolve this problem somehow?


Provide 2x assets

Some of the assets are too low quality for Retina screens.

Which assets in particular @kbhomes ? I may be able to blow some of the images up on Illustrator and export them in at a crazy high resolution for you to use

@chrismou I'm guessing they're in here: https://github.com/radiant-player/radiant-player-mac/tree/master/radiant-player-mac/images.  We should go through and figure out what we're actually using here and what needs to be retina.

Cool. Not sure exactly what @kbhomes had in mind - I'm on a retina macbook and it all looks fine to me, so perhaps I'm looking in the wrong place.

Website images!  That's something we can retina-ize...

@jacobwgillespie @chrismou Are images still an issue?

Potentially yeah - you can check the website - a lot of the images are blurry on retina screens.  I don't think any resources in the app need updating.

This has likely been resolved.


Bytes to Read is always 0

I'm working with an Arduino and attempting to read it in through a COM Port.  I have it transmitting a bytes array constantly through the COM port.  I have given the same baud rate and the correct COM port to the SerialPortStream() constructor.  However, it is showing that there are 0 bytes to read.
I'm working with .NET standard 2.1 and Windows 11.  I am also working under version 3.0.0 of this package

Do you have any logs being captured? As you're using .NET Core, you'll have to programmatically enable the logs. You'll need to read the README.md that tells you how to do this.
You can also try using tools from SysInternals to see the results of the driver APIs.
Also note, that .NET Standard 2.1 isn't the version of the .NET Core you've installed (it's an API revision implemented by all versions of .NET Core 2.1, 3.0, 3.1, 5.0, 6.0, 7.0, 8.0, 9.0).

In another comment, note there is no fix as the root cause is unknown. My analysis then was a badly behaving driver that reported a fatal error.
You will need to collect at a minimum .NET logs (see previous comment). You should also use SysInternal tools and look at the device events (e.g. you f there were any unplug events observed or other behaviour).


Allow EquiRectangularCuteTexture to work in a Worker environment

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Gotta love the cuTe Texture

Snapshot stored with reference name:
refs/pull/15886/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15886/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15886/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15886/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15886/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15886/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15886/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15886/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15886/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15886/merge/testResults/webgl2playwright/index.html


Add support for reading a configuration file

Most likely will be  implementing the config crate.

I began to implement this, but stuck for the moment: https://github.com/mehcode/config-rs/issues/145

I tried using the json-minimal crate but I haven't gotten that to work yet either: https://github.com/36den/json_minimal-rust/issues/1

I've decided to roll my own parser and make a crate from it.

I finished the first version of the crate and published it at https://crates.io/crates/configster/0.1.0


Can't resize the window using the top edge of the window

Operating system: Windows 10
This is:

[ ] a bug

Can't resize the window using the top edge of the window, you can do the sides and the bottom but not the top edge.
Not a massive issue but if your window is full width and the bottom widow is below the bottom of the screen.

Thanks for filing, I'll check into it


Editing

Demo branch
Fixed all linter (ts, css) errors and warning.

Improved the arrow function syntax.


French translation

Hello,
i've tranlate the fr.json in French and write my name in readme.
thanks

thanks, but I guess you missed on line 65, 80, 81

Hello,
line 65: it's the same in french   so it's ok
line 80 and 81: I did not translate them because they are understandable like that
English                              French
Address                             Adresse
Port                                   Port


Indian National Holidays

This PR introduces national holidays in India referenced from Wiki Public Holidays Page
New Changes

Introduced India as a country
Added test case for the Indian Holidays to be verified

To ask
Many times there are state-specific holidays in many countries, we can optionally introduce state-specific holidays that can be passed as active state variables or variables when checking isHoliday this would make the repository very useful when utilizing it across countries.

We are open to support states or regions.
As this is also discussed on the German PR, I've added it as feature request: https://github.com/spatie/holidays/discussions/14

@Nielsvanpach attempted to add region support, can you review

@RohanSakhale Most of the holidays you have added will change every year,  eg Diwali will be on a different date each year.
So you cannot add such holidays. Unless we come up with some logic to predict the date.

@lokesh-zersys yes that is true, that thought was in my mind, but need to think of a way out to provide dates based on Hindu Calendar, which I was searching but couldn't found concreate way out unless we start defining them ourself in the repo

In my opinion, we should follow ONLY our Country's and respective State's(Region) Law.
For those who won't to change the list of Holiday's, should extend the India class and override the methods as required. Yes, including Diwali, Christmas and Eid.
For e.g. according to Maharastra Law. There are only 4.
3 National Holiday

26th Jan - Republic Day
15th Aug - Independence Day
2nd Oct - Gandhi Jayanti

1 State Holiday

1st May - Labour Day / Maharashtra Day

Also, list of holidays changes based on sector as well, not just region. E.g. banking and school sector will have more holidays than offices. Just a thought to keep in mind when creating a list of Holidays that is generic for all.

I've added documentation on how I think we should manage regions or states:
https://github.com/spatie/holidays?tab=readme-ov-file#contributing-a-new-country
Could you get this PR up to date or maybe better, start a new one?

@Nielsvanpach updated based on documented structure
I believe we should also support region when creating country object using Holidays::for, please suggest your views

Thanks, but I'm closing this PR as it doesn't feel complete yet. Feel free to reopen once fixed!


Simple Logging

@Shivansh-007 looks like the logging in dash is not picking the logging config in settings

@Shivansh-007 looks like the logging in dash is not picking the logging config in settings

Not sure why this happening.


XAML design data is pointing to a missing file

Describe the bug
When viewing a XAML files that contains the follow designtime data tag is displaying "Invalid Markup" message.
d:DataContext="{d:DesignInstance ui:MainViewModel}"
To Reproduce
Look at XAML File RoslynPad.DocumentTreeView and others with VS 2022 ver. 17
Expected behavior
A xaml view with default data.
Version
Roslyn 17

OS: Windows 11
Build (or commit ID if built from source):

@kwcoffee1 Thanks for the report but I don't use the designer so it's not a priority for me :) It's possible this is because of dependency injection in the view model.


Logs sometimes silently stop loading

Mike reported logs that were working but then suddenly stopped. When I tried to load the logs I got nothing. Logs still working fine in Mesos UI.
Not really sure what causes this and the best I have are these logs from Nginx (error.log) in the MC2 containers:
2016/04/15 14:58:56 [error] 43#0: *40358 upstream timed out (110: Connection timed out) while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET /base/logs/84/b435432f-0313-11e6-9c88-ba9f87ec83a0/stderr/?n=1 HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/base/logs/84/b435432f-0313-11e6-9c88-ba9f87ec83a0/stderr/?n=1", host: "qa-mesos-mc.za.prk-host.net", referrer: "http://qa-mesos-mc.za.prk-host.net/base/logs/84/"
2016/04/15 15:00:47 [error] 43#0: *40368 upstream prematurely closed connection while reading response header from upstream, client: <IP_ADDRESS>, server: , request: "GET /base/logs/84/b435432f-0313-11e6-9c88-ba9f87ec83a0/stdout/?n=1 HTTP/1.0", upstream: "http://<IP_ADDRESS>:8000/base/logs/84/b435432f-0313-11e6-9c88-ba9f87ec83a0/stdout/?n=1", host: "qa-mesos-mc.za.prk-host.net", referrer: "http://qa-mesos-mc.za.prk-host.net/base/logs/84/"

Nothing to be seen in MC2 logs. Nginx access logs report 502/504 response codes.

http://qa-mesos-mc.za.prk-host.net/base/logs/84/

Handled by #78


Copiable text in issues pane

I'd like to be able to copy issue text so I can Google it.

In Atom on OSX, I can't command-c or get a right-click menu!

CTRL + C should work

It works. What does it take to switch it to CMD - C?

Not much, but this UI and everything has already been replaced and has changes waiting to be merged, can you re-open this in https://github.com/AtomLinter/linter-ui-default?


binarySearch

Please make a PR to the C branch. You are commiting and making a PR to the master branch, which has C++ implementations. I am closing this for now, if you want, you can make a new PR! Thanks for the contribution!


Fix misplaced assert in run_tests.py

Fixes #10044

Merging right away: tests don't use the -n feature (otherwise this fix wouldn't have been necessary...).


ProjectSettings not needed?

Since the point is to just copy the Captain's Mess files into your own Unity project, shouldn't the files in ProjectSettings not be tracked/included as part of the Git repo?

Yes you're right. I'll remove it in the next update. If you know any best practices for organizing Unity extensions please let me know. When development is further along I'll make an official Unity asset package for the Asset Store.


Spurious wakeup bug CompletionListenerFuture

The following code fails to deal with spurious wakeup. It is allowed that the thread is notified without a reason. To deal with this situation, the if(!completed) should be while(!completed). Of course the remaining timeout needs to be corrected.
 @Override
  public Void get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException {
    synchronized (this) {
      if (!isCompleted) {
        unit.timedWait(this, timeout);
      }

      if (isCompleted) {
        if (exception == null) {
          return null;
        } else {
          throw new ExecutionException(exception);
        }
      } else {
        throw new TimeoutException();
      }
    }
  }

Good finding. Just learned something.
Its described at Object.wait():

A thread can also wake up without being notified, interrupted, or
timing out, a so-called spurious wakeup.  While this will rarely
occur in practice, applications must guard against it by testing for
the condition that should have caused the thread to be awakened, and
continuing to wait if the condition is not satisfied.

Further tracked by #320


Magento is not installed properly

I get the following when accessing: http://<IP_ADDRESS>/
Also there is no documentation what to do after running the commands.
Good documentation would be nice to have.
2 exception(s):
Exception #0 (Zend_Db_Statement_Exception): SQLSTATE[42S02]: Base table or view not found: 1146 Table 'magento2.store' doesn't exist, query was: SELECT `store`.* FROM `store` WHERE (`store`.`store_id`='1') ORDER BY `sort_order` ASC

@RogerKeulen This is because although the database has been created, it has not been populated yet. The image is designed to use an existing database import or M2's sample data.
To install the M2 sample data you need to ensure the environment variable M2SETUP_USE_SAMPLE_DATA is set to true.
Can you try settings this and running the docker-compose run cli magento-installer again?

I have it running now with running docker-compose run cli magento-installer again.
Without the sample data....
I first did:
docker-compose run cli magento-installer
docker-compose up -d
docker-compose restart

now i only did:
docker-compose run cli magento-installer  and works for me...
Im going to try now with sample data.
Als i had to edit my /etc/hosts to add the ip adress. I found the ip adress with:
docker inspect mage2docker_web_1

Pleased to hear you have it up and running. Don't hesitiate to reach out if you have any further issues.

Yes, It also works with the M2SETUP_USE_SAMPLE_DATA=true in global.env.

For some reason after running the CLI command to install the Magento, the installed instance is stuck in maintenance mode. disabling the mode results in SETUP link when accessed in the browser. What's the deal with this? What do I need to do in order to have it fully running?
Thanks


BibTex citations should have different types, not just @book

@article for articles, @book for ebooks and books, else @misc


Refactor object exports with named exports

Refactors modules and won some bytes

Are you planning to amend, or can be merge? Would love to have this in before i attempting to look into injects for the auto-value-fix in the react-dom target.

@drcmda If you agree with everything we can merge this.

Sure looks fine, only elements isn't needed in Spring.

Good catch


Splash screen always on top problem

On my laptop, which is getting on a bit now, the Chocolatey GUI splash screen stays on the screen for several tens of seconds before the main window appears. This wouldn't be a problem, except the splash is always on top, obscuring other things on my screen in the meantime.
It would be very useful to me if the splash could not always be on top, so I can get on with other things while Chocolatey GUI starts up.

see discussion #872


Adekoya Wuraade's individual contribution

https://www.figma.com/file/itUOXD9GUTiqZDSBpnN5fL/log-in-screen?node-id=0%3A1[](url)

Log in screen, forgot password screen, change password screen,


check_vmware_rps_memory | List top X VMs consuming memory

Model the functionality after what has been implemented for check_vmware_host_memory, but with a limit of the number of listed VMs to a set number (e.g., "top 10") as with check_vmware_vm_power_uptime.

Note: This comes about due to an alert that we just received that memory usage crossed over the WARNING threshold. I fully expected to see a list of the top X offending VMs, but realized that functionality was limited to more recent plugins.