No segmentation results for specific image - (due to detecting 6 columns when there is only 1?)

Hi
I have run over 2000 images through eynollah as a OCR-D processor, but only 1 gave me this problem.  There was no error detected, but the mets.xml file has no segmentation results.  The only thing I know is that the image was detected as having 6 columns when there is only 1 actual column.  The data for this case is below.  Thanks in advance!
Image processed attached...

OCR-D eynollah command and output to console...
(qurator) D:\qurator>ocrd-eynollah-segment -I OCR-D-IMG -O OCR-D-IMG-SEG -P models eynollah/models_eynollah -P dpi 360 -P allow_scaling true
10:32:03.361 INFO eynollah - INPUT FILE P_00738 (1/1)

10:32:03.809 INFO eynollah - Resizing and enhancing image...
10:32:03.809 INFO eynollah - Detected 360 DPI
1/1 [==============================] - 3s 3s/step
1/1 [==============================] - 1s 646ms/step
10:32:11.003 INFO eynollah - Found 6 columns ([[0.09252959 0.01236904 0.0052445  0.05544147 0.01741231 0.8170032 ]])
10:32:11.003 INFO eynollah - Image was not enhanced.
1/1 [==============================] - 1s 732ms/step
1/1 [==============================] - 1s 628ms/step
10:32:15.064 INFO eynollah - Found 6 columns ([[0.09252959 0.01236904 0.0052445  0.05544147 0.01741231 0.8170032 ]])
1/1 [==============================] - 1s 833ms/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 22ms/step

...
NOTE: many similar lines
...

1/1 [==============================] - 0s 24ms/step
1/1 [==============================] - 0s 24ms/step
1/1 [==============================] - 0s 24ms/step
1/1 [==============================] - 0s 28ms/step
10:34:32.242 INFO eynollah - Textregion detection took 114.8s
1/1 [==============================] - 1s 733ms/step
10:34:35.931 INFO eynollah - Graphics detection took 3.7s
1/1 [==============================] - 1s 769ms/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 31ms/step

...
NOTE: many similar lines
...

1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 31ms/step
1/1 [==============================] - 0s 22ms/step
10:34:59.506 INFO eynollah - textline detection took 23.6s
10:36:15.179 INFO eynollah - slope_deskew: -90.0
10:36:15.179 INFO eynollah - deskewing took 75.7s
10:36:15.332 INFO eynollah - detection of marginals took 0.2s
1/1 [==============================] - 2s 2s/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 16ms/step

...
NOTE: many similar lines
...

1/1 [==============================] - 0s 22ms/step
1/1 [==============================] - 0s 31ms/step
1/1 [==============================] - 1s 764ms/step
10:39:20.846 INFO eynollah - Job done in 437.0s
10:39:21.100 INFO ocrd.process.profile - Executing processor 'ocrd-eynollah-segment' took 437.728415s (wall) 813.187500s (CPU)( [--input-file-grp='OCR-D-IMG' --output-file-grp='OCR-D-IMG-SEG' --parameter='{"models": "eynollah/models_eynollah", "dpi": 360, "allow_scaling": true, "full_layout": true, "curved_line": false, "headers_off": false}' --page-id='']
10:39:21.100 INFO ocrd.workspace.save_mets - Saving mets 'D:\qurator\mets.xml'

and below is the contents of the mets.xml file...
<?xml version="1.0" encoding="UTF-8"?>
<mets:mets xmlns:mets="http://www.loc.gov/METS/" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="info:lc/xmlns/premis-v2 http://www.loc.gov/standards/premis/v2/premis-v2-0.xsd http://www.loc.gov/mods/v3 http://www.loc.gov/standards/mods/v3/mods-3-6.xsd http://www.loc.gov/METS/ http://www.loc.gov/standards/mets/mets.xsd http://www.loc.gov/mix/v10 http://www.loc.gov/standards/mix/mix10/mix10.xsd">
  <mets:metsHdr CREATEDATE="2022-07-22T10:29:16.958375">
    <mets:agent TYPE="OTHER" OTHERTYPE="SOFTWARE" ROLE="CREATOR">
      <mets:name>ocrd/core v2.34.0</mets:name>
    </mets:agent>
    <mets:agent TYPE="OTHER" OTHERTYPE="SOFTWARE" ROLE="OTHER" OTHERROLE="layout/segmentation/region">
      <mets:name>ocrd-eynollah-segment v0.0.11</mets:name>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="input-file-grp">OCR-D-IMG</mets:note>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="output-file-grp">OCR-D-IMG-SEG</mets:note>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="parameter">{"models": "eynollah/models_eynollah", "dpi": 360, "allow_scaling": true, "full_layout": true, "curved_line": false, "headers_off": false}</mets:note>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="page-id"/>
    </mets:agent>
  </mets:metsHdr>
  <mets:dmdSec ID="DMDLOG_0001">
    <mets:mdWrap MDTYPE="MODS">
      <mets:xmlData>
        <mods:mods xmlns:mods="http://www.loc.gov/mods/v3">
          <mods:identifier type="purl">'test'</mods:identifier>
        </mods:mods>
      </mets:xmlData>
    </mets:mdWrap>
  </mets:dmdSec>
  <mets:amdSec ID="AMD">
    </mets:amdSec>
  <mets:fileSec>
    <mets:fileGrp USE="OCR-D-IMG">
      <mets:file ID="OCR-D-IMG_00738" MIMETYPE="image/png">
        <mets:FLocat LOCTYPE="OTHER" OTHERLOCTYPE="FILE" xlink:href="OCR-D-IMG\bqwndyazflxxtnmszruzzmlyofrxvtzc_s089_1561992285623.png"/>
      </mets:file>
    </mets:fileGrp>
    <mets:fileGrp USE="OCR-D-IMG-SEG">
      <mets:file ID="OCR-D-IMG-SEG_00738" MIMETYPE="application/vnd.prima.page+xml">
        <mets:FLocat LOCTYPE="OTHER" OTHERLOCTYPE="FILE" xlink:href="OCR-D-IMG-SEG\OCR-D-IMG-SEG_00738.xml"/>
      </mets:file>
    </mets:fileGrp>
  </mets:fileSec>
  <mets:structMap TYPE="PHYSICAL">
    <mets:div TYPE="physSequence">
      <mets:div TYPE="page" ID="P_00738">
        <mets:fptr FILEID="OCR-D-IMG_00738"/>
        <mets:fptr FILEID="OCR-D-IMG-SEG_00738"/>
      </mets:div>
    </mets:div>
  </mets:structMap>
</mets:mets>

Hi I have run over 2000 images through eynollah as a OCR-D processor, but only 1 gave me this problem. There was no error detected, but the mets.xml file has no segmentation results. The only thing I know is that the image was detected as having 6 columns when there is only 1 actual column. The data for this case is below. Thanks in advance!
Image processed attached...

OCR-D eynollah command and output to console...
(qurator) D:\qurator>ocrd-eynollah-segment -I OCR-D-IMG -O OCR-D-IMG-SEG -P models eynollah/models_eynollah -P dpi 360 -P allow_scaling true
10:32:03.361 INFO eynollah - INPUT FILE P_00738 (1/1)

10:32:03.809 INFO eynollah - Resizing and enhancing image...
10:32:03.809 INFO eynollah - Detected 360 DPI
1/1 [==============================] - 3s 3s/step
1/1 [==============================] - 1s 646ms/step
10:32:11.003 INFO eynollah - Found 6 columns ([[0.09252959 0.01236904 0.0052445  0.05544147 0.01741231 0.8170032 ]])
10:32:11.003 INFO eynollah - Image was not enhanced.
1/1 [==============================] - 1s 732ms/step
1/1 [==============================] - 1s 628ms/step
10:32:15.064 INFO eynollah - Found 6 columns ([[0.09252959 0.01236904 0.0052445  0.05544147 0.01741231 0.8170032 ]])
1/1 [==============================] - 1s 833ms/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 22ms/step

...
NOTE: many similar lines
...

1/1 [==============================] - 0s 24ms/step
1/1 [==============================] - 0s 24ms/step
1/1 [==============================] - 0s 24ms/step
1/1 [==============================] - 0s 28ms/step
10:34:32.242 INFO eynollah - Textregion detection took 114.8s
1/1 [==============================] - 1s 733ms/step
10:34:35.931 INFO eynollah - Graphics detection took 3.7s
1/1 [==============================] - 1s 769ms/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 31ms/step

...
NOTE: many similar lines
...

1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 31ms/step
1/1 [==============================] - 0s 22ms/step
10:34:59.506 INFO eynollah - textline detection took 23.6s
10:36:15.179 INFO eynollah - slope_deskew: -90.0
10:36:15.179 INFO eynollah - deskewing took 75.7s
10:36:15.332 INFO eynollah - detection of marginals took 0.2s
1/1 [==============================] - 2s 2s/step
1/1 [==============================] - 0s 16ms/step
1/1 [==============================] - 0s 16ms/step

...
NOTE: many similar lines
...

1/1 [==============================] - 0s 22ms/step
1/1 [==============================] - 0s 31ms/step
1/1 [==============================] - 1s 764ms/step
10:39:20.846 INFO eynollah - Job done in 437.0s
10:39:21.100 INFO ocrd.process.profile - Executing processor 'ocrd-eynollah-segment' took 437.728415s (wall) 813.187500s (CPU)( [--input-file-grp='OCR-D-IMG' --output-file-grp='OCR-D-IMG-SEG' --parameter='{"models": "eynollah/models_eynollah", "dpi": 360, "allow_scaling": true, "full_layout": true, "curved_line": false, "headers_off": false}' --page-id='']
10:39:21.100 INFO ocrd.workspace.save_mets - Saving mets 'D:\qurator\mets.xml'

and below is the contents of the mets.xml file...
<?xml version="1.0" encoding="UTF-8"?>
<mets:mets xmlns:mets="http://www.loc.gov/METS/" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="info:lc/xmlns/premis-v2 http://www.loc.gov/standards/premis/v2/premis-v2-0.xsd http://www.loc.gov/mods/v3 http://www.loc.gov/standards/mods/v3/mods-3-6.xsd http://www.loc.gov/METS/ http://www.loc.gov/standards/mets/mets.xsd http://www.loc.gov/mix/v10 http://www.loc.gov/standards/mix/mix10/mix10.xsd">
  <mets:metsHdr CREATEDATE="2022-07-22T10:29:16.958375">
    <mets:agent TYPE="OTHER" OTHERTYPE="SOFTWARE" ROLE="CREATOR">
      <mets:name>ocrd/core v2.34.0</mets:name>
    </mets:agent>
    <mets:agent TYPE="OTHER" OTHERTYPE="SOFTWARE" ROLE="OTHER" OTHERROLE="layout/segmentation/region">
      <mets:name>ocrd-eynollah-segment v0.0.11</mets:name>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="input-file-grp">OCR-D-IMG</mets:note>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="output-file-grp">OCR-D-IMG-SEG</mets:note>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="parameter">{"models": "eynollah/models_eynollah", "dpi": 360, "allow_scaling": true, "full_layout": true, "curved_line": false, "headers_off": false}</mets:note>
      <mets:note xmlns:ocrd="https://ocr-d.de" ocrd:option="page-id"/>
    </mets:agent>
  </mets:metsHdr>
  <mets:dmdSec ID="DMDLOG_0001">
    <mets:mdWrap MDTYPE="MODS">
      <mets:xmlData>
        <mods:mods xmlns:mods="http://www.loc.gov/mods/v3">
          <mods:identifier type="purl">'test'</mods:identifier>
        </mods:mods>
      </mets:xmlData>
    </mets:mdWrap>
  </mets:dmdSec>
  <mets:amdSec ID="AMD">
    </mets:amdSec>
  <mets:fileSec>
    <mets:fileGrp USE="OCR-D-IMG">
      <mets:file ID="OCR-D-IMG_00738" MIMETYPE="image/png">
        <mets:FLocat LOCTYPE="OTHER" OTHERLOCTYPE="FILE" xlink:href="OCR-D-IMG\bqwndyazflxxtnmszruzzmlyofrxvtzc_s089_1561992285623.png"/>
      </mets:file>
    </mets:fileGrp>
    <mets:fileGrp USE="OCR-D-IMG-SEG">
      <mets:file ID="OCR-D-IMG-SEG_00738" MIMETYPE="application/vnd.prima.page+xml">
        <mets:FLocat LOCTYPE="OTHER" OTHERLOCTYPE="FILE" xlink:href="OCR-D-IMG-SEG\OCR-D-IMG-SEG_00738.xml"/>
      </mets:file>
    </mets:fileGrp>
  </mets:fileSec>
  <mets:structMap TYPE="PHYSICAL">
    <mets:div TYPE="physSequence">
      <mets:div TYPE="page" ID="P_00738">
        <mets:fptr FILEID="OCR-D-IMG_00738"/>
        <mets:fptr FILEID="OCR-D-IMG-SEG_00738"/>
      </mets:div>
    </mets:div>
  </mets:structMap>
</mets:mets>

You have already touched the point, wrong column classification cause this problem. The point is with so upper scaling the layout models are not able  to detect the regions (here no text region is detected) anymore. For resolution the classifier should be updated (training with failing documents).

Thanks for the speedy reply.
If I understood you correctly, my image is scaled too large, so I tried to adjust in a couple of ways.
First, I tried changing the dpi flag to 1100 (-P dpi 1100) in my OCR-D eynollahrun,  but is still gave the 6 columns classification result, and I got the same behavior - no textregions detected, no textlines detected.
So then, I tried scaling the image in GIMP to 720 x 918 from the original 2203 x 2808, and I reran eyenollah with the dpi flag back at my original 360 value.  This also gave the classification as being 6 columns.  But now it detected 21 textregions, but still no textlines.
Did I misunderstand what is causing this issue, or is there another workaround I can try?

Thanks for the speedy reply. If I understood you correctly, my image is scaled too large, so I tried to adjust in a couple of ways.
First, I tried changing the dpi flag to 1100 (-P dpi 1100) in my OCR-D eynollahrun, but is still gave the 6 columns classification result, and I got the same behavior - no textregions detected, no textlines detected.
So then, I tried scaling the image in GIMP to 720 x 918 from the original 2203 x 2808, and I reran eyenollah with the dpi flag back at my original 360 value. This also gave the classification as being 6 columns. But now it detected 21 textregions, but still no textlines.
Did I misunderstand what is causing this issue, or is there another workaround I can try?

Let me say you how scaling works by eynollah. If the input has a dpi less than 300 , it will be scaled based on column classifier results. But if the dpi is more than 300 or you set it manually to sth bigger that 300 the scaling will not implemented unless you activate allow_scaling. When you apply allow scaling the scaling based on detected columns (and regardless of dpi) will be taken into account. With your image (which is not a real document, it is more like a text region cropped from a document) you can scale down  (600*764) and then set dpi to sth bigger than 300 (this can not be done in standalone eynollah but in OCR-D it seems that is the case) and drop allow_scaling ( so complex :D ).


[Enhancement] Allow to process macro body with ParseCallbacks

ATM if bindgen user needs to parse macros by hand, he's forced to do it manually - know all headers involved, parse them by hand and finally do something with parsing results.
I think it would be beneficial if ParseCallbacks would provide way to not only get notified that certain macro was parsed, but also have its body, at least as a string.
Changes proposed, discussion welcome:
pub trait ParseCallbacks {
    // Provides callback implementor ways to customize macro parsing
    // @param  name - macro name
    // @param  args - list of macro arguments; None for constant macro;
    //                Some(...) for function-like macro,
    //                with vector containing argument identifiers
    // @param  body - raw macro body as a string slice, allows to parse it by hand
    // @return        None to perform default parsing;
    //                Some(...) to insert specified text into generated bindings module
    fn parsed_macro(&self, name: &str, args: Option<Vec<&str>>, body: &str) -> Option<String>;
    // ... leftover
}

Thanks for the bug report! This is the same issue as https://github.com/rust-lang-nursery/rust-bindgen/issues/666, so let's keep the discussion centralized there.


prevent writing large and identical core dumps in test artifacts

related to https://github.com/istio/istio/issues/33034

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9599a9962afec1536c6cf9307d87b44468f12893
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9599a9962afec1536c6cf9307d87b44468f12893
link
true
/test lint_istio

gencheck_istio
9599a9962afec1536c6cf9307d87b44468f12893
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
9599a9962afec1536c6cf9307d87b44468f12893
link
true
/test gencheck_istio

lint_istio
9697e6b5249cf20deb2478b7df793cb562b42e4d
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
9697e6b5249cf20deb2478b7df793cb562b42e4d
link
true
/test lint_istio

gencheck_istio
9697e6b5249cf20deb2478b7df793cb562b42e4d
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Interface problem with some Lyrics plus features

2 issues in two days sorry for making you work !
Basically the "unsynced" category comes out of the dropdown menu when using some lyrics plus features :
Normal behavior :

When using the conversion feature :

When using the compact feature :

@Yashirow It's your theme. So you must report anything no matter what. So don't worry.
Well that strange problem is something I personally tried to solve and still couldn't.
So let me try some other ways too

@nimsandu all we can do about that - resore default Lyrics Plus display style:

The issue is in Lyrics Plus logic and rendering algorithms
If you want I can make a commit restoring default  Lyrics Plus display style

@nimsandu all we can do about that - resore default Lyrics Plus display style:

The issue is in Lyrics Plus logic and rendering algorithms
If you want I can make a commit restoring default  Lyrics Plus display style

It's fine cuz our main focus is to reduce user confusions
@SunsetTechuila I really appreciate everything you do.
So you are welcome to make the commit ill look into all of your prs asap.

@Yashirow this issue has been fixed with the merge of #191 by @SunsetTechuila


linux platform

hello，
Do you plan to release the Linux platform?If so,About when will it be released?

It currently works if you build the plugin yourself. We have no immediate plans to provide binaries out of the box. See here:
https://community.cesium.com/t/building-plugin-on-linux/22551/2


created a post encounter visit reason referencing previous visit

Created a new section in summary metadata with a visit reason for post encounter mode. This reason references the last appointment in the hard coded patient closes to the current time. I also updated hard coded patient so that the previous encounter and the next encounter are the same. This will make sure that the demo will not be affected.
Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (N/A) and :white_check_mark:.
Submitter:
Running the Application

[x] Manually tested in Chrome
[x] Manually tested in IE

Documentation

[x] This pull request describes why these changes were made
[x] Recognizes any potential shortcomings/bugs in the description
NA Cheat sheet is updated
NA Demo script is updated
NA Documentation on Wiki has been updated
NA Additional technical components and libraries are documented and added to wiki as needed

NoteParser

NA Note parser has been updated if structured phrases change

Code Quality

[x] 4-space indents - convert any tabs to spaces
[x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };
[x] Code is commented

Tests

[x] Existing tests passed
NA Added UI tests for slim mode
NA Added UI tests for full mode
NA Added backend tests for fluxNotes code
NA Added note parser examples to test new functionality

Reviewer 1: Mike

[X] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[X] The tests appropriately test the new code, including edge cases
[X] You have tried to break the code

Reviewer 2: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Looks good. One change I'd recommend:
[GQ1] let's instantiate the moment that we use in isAfter or isBefore outside the loop in a variable like const now = new moment() and then use now as the argument to isAfter and isBefore.
[GQ2] if there are multiple previous encounters, I'm not sure the getPreviousEncounterReason will return the reason from the right one. getEncountersChronologically sorts them from oldest to newest. You then filter out any after the date and take the first one. I think you want to take the last one in the list as it would be most recent, right?

Addressed GQ1 and GQ2. Also updated hard coded patient so that the visit reason is in past tense for in post encounter mode.

The code looks good, getPreviousEncounter and getNextEncounter look similar which is a good thing. Chrome tests and backend tests pass. I tested it by adding another past appointment to the hard coded patient and this code correctly displays the most recent appointment in the past in Post Encounter, and the soonest appointment in the future in Pre Encounter. The @reason for previous visit shortcut isn't in place yet so inserting the reason results in "@reason for previous visit[[Feb13Debra Hernandez672 is coming in to see Dr. X123 Y987 for a check up on the progress of her treatment for Invasive ductal carcinoma of the breast]]" in the editor.

Addressed Mike's comment.


Rust

A Low-copy implementation of Bebop for Rust. At this moment I would personally say it is at a "Beta"
level of quality. More issues likely are lurking, but it seems to be fully functional from all
tests written thus far. We may also want to make breaking changes to the generated code for
performance, ergonomic, or safety reasons.
Current State

Runtime

serialization traits
wrapped slices for lower-copy serialization/deserialization
well known type support (guid, date)
reasonable code coverage
cargo integration (see example use in Laboratory)

Generator

full support for all schema types
implements serialization and deserialization through Record and SubRecord
borrows strings and single-byte primitive arrays instead of copying
unions are fully implemented as enum types without dummy wrapper structs
lifetimes, so many lifetimes and lifetime propagation fun
recognizes fixed-sized structs and tries to avoid copying arrays of them
no unsafe code generated

Additional testing schemas

Possible Future Work
These will likely be done on an as-needed basis if at all.

More trait implementations, such as Eq and Hash where sub-types allow.
Bigendian system support? Sorta half put it in to at least demarcate some places that need work for it.
More tests of generated code to ensure it does not change unexpectedly and supports all cases.
Additional helpers in the runtime for common patterns
Async support
benchmarking and performance improvements

Huzzah, the tests for rust finally pass in the CI!
Next week I will see if I can debug the TS and Dart tests.


About project maintenance

Description
Hello Sortable team, while using Draggable.next, I have encountered many issues and noticed that the project has not been updated for a long time. As a result, I created a library called vue-draggable-plus that supports both Vue 2 and Vue 3. My goal is to help more people, and if possible, I would like to transfer the project to the Sortable team. I would appreciate your response. Thank you!
GitHub address

Awesome. Thanks for this

does this support the same component inside itself? also, how do we know you will continue to support?

does this support the same component inside itself? also, how do we know you will continue to support?

I believe that every project is the author's hard work and is not abandoned without reason. I also believe that VueDraggable.next is the same. I am someone who loves open source and I hope to contribute to it. In addition, the open source community requires everyone's joint maintenance, and I also hope to maintain this project together with everyone. I will do my best to maintain this project!

@Alfred-Skyblue your library works like a charm, and is much easier to upgrade to than https://github.com/MaxLeiter/sortablejs-vue3 which doesn't have support for v-model, see: https://github.com/MaxLeiter/sortablejs-vue3/issues/43
Thank you!

@Alfred-Skyblue your library works like a charm, and is much easier to upgrade to than https://github.com/MaxLeiter/sortablejs-vue3 which doesn't have support for v-model, see: MaxLeiter/sortablejs-vue3#43
Thank you!

Thank you for your approval.

@Alfred-Skyblue unfortunately I've had problems with changes to options not being picked up (e.g. disabled), an also the options "leaking" into the DOM as normal HTML element attributes. I've switch to useSortable() from @vueuse which I just now noticed is also by you, and this works much better for me:
https://github.com/vueuse/vueuse/pull/2763

@lehni Thank you for your suggestion. We will make optimization adjustments accordingly. Additionally, if you are using Vueuse in your project, we recommend using the useSortable function directly from Vueuse, although it may require you to add several options.

@Alfred-Skyblue unfortunately I've had problems with changes to options not being picked up (e.g. disabled), an also the options "leaking" into the DOM as normal HTML element attributes. I've switch to useSortable() from @vueuse which I just now noticed is also by you, and this works much better for me: vueuse/vueuse#2763

Optimization adjustments have been made according to your needs. Thank you for your suggestions. They are available in the latest version.

Thank you @Alfred-Skyblue !

Thank you very much @Alfred-Skyblue!!! you saved me tons of hours of refactor 😅

Awesome, thanks @Alfred-Skyblue

I found this thread very helpfull. https://vueuse.org/integrations/useSortable/#usesortable
This composable much better and without bugs

Both options are possible, and useSortable is also a feature that I added to vueuse.

Hi @David-Desmaisons ,I apologize for the inconvenience. However, as an AI language model, I am not affiliated with any specific team or organization, including the SortableJS team. Therefore, I cannot grant permission or make decisions regarding project transfers or future plans.

Hello @David-Desmaisons , please forgive me for the interruption. In order to facilitate community usage, can I transfer the project to the SortableJS team for joint maintenance? Alternatively, what are your plans for this project in the future? Can I participate in it? Thank you!

That would be awesome... thanks Alfred

Nice library @Alfred-Skyblue! It came handy here! Integration was painless!

Thank you so much for such an amazing work, @Alfred-Skyblue! At some point I upgraded the Vue version of my project and I didn’t realize the drag-and-drop feat broke. Your project allowed me to painlessly get it back to work and in a much cleaner way than the original library allowed for :)
Your project is more than ready to take the place as the official SortableJS Vue implementation :)


Alphafold running time

What happened?
Dear developers,
I tried to run alphafold from the gget package and compare the execution times to the Alphafold2 implemented in Google Colab.
I submitted the following sequence and used the default parameters in both cases: MAEHGAHFTAASVADDQPSIFEVVAQDSLMTAVRPALQHVVKVLAESNPTHYGFLWRWFDEIFTLLDLLLQQHYLSRTSASFSENFYGLKRIVMGDTHKSQRLASAGLPKQQLWKSIMFLVLLPYLKVKLEKLVSSLREEDEYSIHPPSSRWKRFYRAFLAAYPFVNMAWEGWFLVQQLRYILGKAQHHSPLLRLAGVQLGRLTVQDIQALEHKPAKASMMQQPARSVSEKINSALKKAVGGVALSLSTGLSVGVFFLQFLDWWYSSENQETIKSLTALPTPPPPVHLDYNSDSPLLPKMKTVCPLCRKTRVNDTVLA
The Colab AlphaFold finished in 15 minutes and required 4.6GB RAM and 3.6GB of GPU while gget AlphaFold finished in ~5h in a desktop computer with 8GB GPU, and 64GB RAM.
If I understood correctly, gget alphafold implements the simplified Alphafold version that also uses Google Colab. Why is there such a great difference in execution time?
gget version
0.27.2
Operating System (OS)
Linux
User interface
Command-line
Are you using a computer with an Apple M1 chip?
Not M1
What is the exact command that was run?
gget alphafold MAEHGAHFTAASVADDQPSIFEVVAQDSLMTAVRPALQHVVKVLAESNPTHYGFLWRWFDEIFTLLDLLLQQHYLSRTSASFSENFYGLKRIVMGDTHKSQRLASAGLPKQQLWKSIMFLVLLPYLKVKLEKLVSSLREEDEYSIHPPSSRWKRFYRAFLAAYPFVNMAWEGWFLVQQLRYILGKAQHHSPLLRLAGVQLGRLTVQDIQALEHKPAKASMMQQPARSVSEKINSALKKAVGGVALSLSTGLSVGVFFLQFLDWWYSSENQETIKSLTALPTPPPPVHLDYNSDSPLLPKMKTVCPLCRKTRVNDTVLA

Which output/error did you get?
No response

Hi Alessandra, gget alphafold probably is not accessing your computer's GPUs, and since it runs locally, the runtime is highly dependent on the speed of your internet connection. (If you run gget alphafold on Google Colab (example ) you should find more similar runtimes.)

Thank you for your quick answer! Do you know how I could check if gget is
accessing my GPU? I already checked that the drivers and cuda are correctly
installed.
El mié, 1 mar 2023 a las 11:11, Laura Luebbert @.***>)
escribió:

Hi Alessandra, gget alphafold probably is not accessing your computer's
GPUs, and since it runs locally, the runtime is highly dependent on the
speed of your internet connection. (If you run gget alphafold on Google
Colab (example
https://github.com/pachterlab/gget_examples/blob/main/gget_alphafold.ipynb
) you should find more similar runtimes.)
—
Reply to this email directly, view it on GitHub
https://github.com/pachterlab/gget/issues/62#issuecomment-1449777998,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVOPCZ3WAFVRLOGHXPAH3LTWZ4OFNANCNFSM6AAAAAAVLXUFWY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Alessandra

Hm maybe some system monitor, e.g. watch -n 1 nvidia-smi (also see: https://unix.stackexchange.com/questions/38560/gpu-usage-monitoring-cuda). I expect that gget alphafold is not recognizing your GPU (and I am not sure how to fix that), but please let me know what you find

Re the slower runtime: https://twitter.com/neuroluebbert/status/1555968176348729344?s=46&t=1ZZOf9kQsZAlnUIYgUDEoQ


Added screenshot feature

I used pyscreenshot to implement the feature. It basically takes the screenshot at the the client, sends it to the server and deletes from client.
Also addded some requirements.txt, a gitignore and one test case.

Why closing this pull request?

I felt this was somewhat outdated and was working on a new version. Reopening anyhow :)

I have to close this PR. Apologies, I think this is a great feature. The structure of this project has changed a lot since early February, and I won't be able to merge. I might take a look at this in the future to add a screenshot feature, and I'll give you credit in the README. Thanks.


finally stop using min/max_value and the integer modules

https://github.com/rust-lang/rust/pull/68952 landed, so we can finally do this :)

@bors r+

:pushpin: Commit 148269dd4b64c21c8dfa66d5d67a48443b1aea94 has been approved by RalfJung

:hourglass: Testing commit 148269dd4b64c21c8dfa66d5d67a48443b1aea94 with merge 63925169c1d713c01646e37ebbf32c03467a650a...

Heh, cool!

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 63925169c1d713c01646e37ebbf32c03467a650a to master...


React-router params

Hello!
I keep id in router params.
And when the page is reloaded, a request is made to the server for this id
But for some reason, nothing happens to me instead and it seems that the whole application crashes (white screen, 404 errors in the console)
I don't understand what's wrong. Didn't find a solution..

I have the same problem using React BrowserRouter with useParams(). Did anyone find a solution for this yet?

I just solved it, the problem was, that the app was looking for owner.github.io/assets/index.js instead of owner.github.io/repo/assets/index.js. I solved this by adding base: '/repo/' in my vite.config.js.


Consul healthcheck always returns 503 with actuator

Describe the bug
I am using spring boot consul config/discovery for config management. after adding the dependencies health check API started returning 503. tried many things but couldn't find a solution so raising it here.
We are using Vault/Consul.
        compile group: 'org.springframework.cloud', name: 'spring-cloud-starter-consul-config', version: '2.2.3.RELEASE'
        compile group: 'org.springframework.cloud', name: 'spring-cloud-starter-consul-discovery', version: '2.2.3.RELEASE'
        runtime group: 'org.springframework.cloud', name: 'spring-cloud-starter-vault-config', version: '2.2.3.RELEASE'

Sample
management.endpoints.web.base-path=/
management.endpoints.web.path-mapping.prometheus=/prometheus/metrics
management.endpoints.web.exposure.include=prometheus,health,refresh
management.security.enabled=false

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Add error cause information to BlockError and TransactionError

The errors in many cases should chain source errors from the implementation.

Codecov Report

Merging #471 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   45.89%   45.82%   -0.07%
==========================================
  Files         131      131
  Lines       13273    13291      +18
==========================================
- Hits         6092     6091       -1
- Misses       7181     7200      +19

Impacted Files
Coverage Δ

network-core/src/server/transaction.rs
0% <0%> (ø)
:arrow_up:

network-core/src/server/block.rs
0% <0%> (ø)
:arrow_up:

...tocol-tokio/src/network_transport/response_code.rs
60.6% <0%> (-6.07%)
:arrow_down:

chain-core/src/property.rs
96.05% <0%> (+1.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566ee28...dfbc9ac. Read the comment docs.


Reuse pino instance if passed with 'logger' option. Document the serializers

Fixes #2 #7
cc @marcbachmann @davidmarkclements

👍 Yep, just what I was looking for ;-)

@davidmarkclements merging and releasing.


Message: Process unexpectedly closed with status 1

i tried to use the headless code but it still doesn't work
(base) [root@dw-dev tortest]# python3 test.py /root/tortest/tor-browser
Traceback (most recent call last):
File "/root/tortest/test.py", line 28, in
main()
File "/root/tortest/test.py", line 24, in main
headless_visit(args.tbb_path)
File "/root/tortest/test.py", line 11, in headless_visit
with TorBrowserDriver(tbb_dir) as driver:
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.11/site-packages/tbselenium/tbdriver.py", line 103, in init
super(TorBrowserDriver, self).init(
File "/usr/python/lib/python3.11/site-packages/selenium/webdriver/firefox/webdriver.py", line 68, in init
super().init(command_executor=executor, options=self.options)
File "/usr/python/lib/python3.11/site-packages/selenium/webdriver/remote/webdriver.py", line 206, in init
self.start_session(capabilities)
File "/usr/python/lib/python3.11/site-packages/selenium/webdriver/remote/webdriver.py", line 291, in start_session
response = self.execute(Command.NEW_SESSION, caps)["value"]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/python/lib/python3.11/site-packages/selenium/webdriver/remote/webdriver.py", line 346, in execute
self.error_handler.check_response(response)
File "/usr/python/lib/python3.11/site-packages/selenium/webdriver/remote/errorhandler.py", line 245, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: Process unexpectedly closed with status 1

This error means the browser couldn't start for some reason and unfortunately the error messages don't say much about the root cause.
Could you please if the troubleshooting steps help you or not? https://github.com/webfp/tor-browser-selenium#-troubleshooting

Closing due to inactivity. Feel free to reopen once you went through the troubleshooting steps.


Duke training script

Hi there, are the hyperparams for Duke the same of MARS?
Should changing the _database paths in run_baseline.py enough to get the same results for the baseline (92.7 mAP) ?

Yes We use the same configuration.


STM32 OTA

How to use the at command to download an HTTP remote file and save it in the specified file
After the download is successful, print the MD5 value and file information of the file just saved with the at command, and print out the whole file through the serial port

@hzhh110 there is no available AT commands now. but

you can download a HTTP resource by AT+HTTPCGET command.
you can save resource by AT+FS command (disable by default, you should enable it in menuconfig).
you can use APIs which in ESP-IDF to implement MD5 calculation (esp_rom_md5_init series APIs).

We assume this worked for you, and will close it. If that's not the case, please open another github issue.


Feature/unit test/about

What does this PR do?

This PR add unit testing to /About components, and also fix eslint and flow code style issues. Provided unit testing to components structure and JSON information comparison (specially on timeline).

Related issues
#34
Merge Checklist:

[ ] The branch is up-to-date (i.e. rebased) with the base branch
[ ] No code style issues

https://www.youtube.com/watch?v=3QlECNCcDwk


Fix regex used for parsing flag names

v8flags() currently gives me:
[ '--experimental',
  '--use',
  '--es',
  '--harmony',
  '--harmony',
  '--harmony',
  '--harmony',
  ... ]

Those are not really the flags for v8, and it messes liftoff and gulp and my own CLI since it returns a lot of irrelevant v8 flags 😥
After fixing the regex:
[ '--experimental-extras',
  '--use-strict',
  '--es-staging',
  '--harmony',
  '--harmony-shipping',
  '--harmony-array-prototype-values',
  '--harmony-do-expressions',
  ... ]

I added a test to look for duplicates. I can't think of better test 🤔

actually, I'm going to bring @sttk in on this.  He's been working on this stuff way more than me recently.

Closing for https://github.com/js-cli/js-v8flags/pull/49 instead.


[New Fix] Make fairings eject sideways instead of forward

What will the fix solve? Please describe.
Currently, fairings eject forward, which often leads to them becoming jammed on the payload.
Describe the solution you'd like
I think that the fairing parts should be made to eject sideways, like structural tubes and engine plates' fairings do.
Additional context
Video demonstration

Attempted to fix this issue but couldn't find a satisfying answer for why this happens after debugging for a couple of hours, sorry. Maybe someone else can figure it out.


Edit lesson command

Resolves #120

Codecov Report

Merging #143 into master will increase coverage by 0.45%.
The diff coverage is 87.06%.

@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
+ Coverage     79.36%   79.82%   +0.45%
- Complexity      819      847      +28
============================================
  Files           127      129       +2
  Lines          2317     2439     +122
  Branches        242      268      +26
============================================
+ Hits           1839     1947     +108
  Misses          421      421
- Partials         57       71      +14

Impacted Files
Coverage Δ
Complexity Δ

...eedu/address/logic/commands/EditLessonCommand.java
84.33% <84.33%> (ø)
12.00 <12.00> (?)

.../address/logic/parser/EditLessonCommandParser.java
92.30% <92.30%> (ø)
8.00 <8.00> (?)

...du/address/logic/commands/DeleteLessonCommand.java
82.35% <100.00%> (ø)
11.00 <0.00> (ø)

...address/logic/commands/EditModuleClassCommand.java
95.65% <100.00%> (-0.10%)
12.00 <1.00> (ø)

...edu/address/logic/commands/EditStudentCommand.java
96.82% <100.00%> (-0.05%)
12.00 <0.00> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
94.91% <100.00%> (ø)
17.00 <0.00> (ø)

...va/seedu/address/logic/parser/TutorsPetParser.java
100.00% <100.00%> (ø)
28.00 <0.00> (+1.00)

...a/seedu/address/model/moduleclass/ModuleClass.java
100.00% <100.00%> (ø)
18.00 <1.00> (ø)

...c/main/java/seedu/address/model/lesson/Lesson.java
96.49% <0.00%> (-3.51%)
28.00% <0.00%> (+4.00%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b1394...834358b. Read the comment docs.


Why is there no way to change the "(why: No Collection Info)" which is displayed on wayback machine when you click a date?

Why is there no (clear) way to change the why: No Collection Info which is displayed on wayback machine when you click a date? Normally it displays info like what bot submitted it or whatever else.

Hi @mhmatthewhugley:
Can you clarify?
I think what you mean is:

Use the Wayback Machine Archiver to archive a page.
Nagivgate to that page's page on the Wayback Machine (for example: https://web.archive.org/web/*/alexgude.com)
Hover over a date and you'll see this, which says something like "why: save-page-now".

And you'd like to be able to set the "why" reason?
That's not possible with the API I'm currently using. If this code was moved to the official API (see #23) it might be.

Yes that is what I was talking about.


error when conduct simulation using OLAF& turbulent wind

Dear all，
Sorry to bother you, I used the OpenFAST v3.5.1 from Releases · OpenFAST/openfast · GitHub to conduct simulation, but here is still an error which is same as #1746 when I used an Turbsim FF inflowfile  . Here is my error.

Best regards,
Originally posted by @HelenLeeeeee in https://github.com/OpenFAST/openfast/issues/1746#issuecomment-1783801369

Dear @HelenLeeeeee,
Is the wind file you are using one you generated, or one from the repository?  The error is consistent with trying to use a non-periodic TurbSim file with the simulation.
This is slightly different than the error in #1746 as that error occurred in the middle of the simulation, but this error occurs at the start.
Regards

Dear @HelenLeeeeee,
Is the wind file you are using one you generated, or one from the repository? The error is consistent with trying to use a non-periodic TurbSim file with the simulation.
This is slightly different than the error in #1746 as that error occurred in the middle of the simulation, but this error occurs at the start.
Regards

Dear @andrew-platt,
The wind file I am using is I generated with Turbsim.
Also, I had a similar error driving the latest version of aerodyn_driver_x64.exe (with the same inflowwind file), but not at the beginning, at 17 seconds.

For reference, here are the settings for my "aerodyn15.dat""Inflowwind.dat''and"olaf.dat" files, the OLAF file parameters are generated based on the parameters and the python file given in the user document.

Best regards,

Dear @HelenLeeeeee,
For the error with negative time, one change that you can make is to generate the TurbSim file with periodic winds*.  To do this, set the UsableTime to All.  This will allow InflowWind to access negative times and should allow the simulation that with the error at -0.1426 s to proceed as normal.  I suspect this will also take care of the issue at 17 seconds (negative time is accessed there as well).
*Since the wind is generated by FFT, the wind at the end of the file will match the wind at the beginning of the file effectively allowing it to wrap around in time/x-dimension.  This allows negative times to be accessed in the wind file.  However, this only occurs if the UsableTime is set to All.
Regards,

Dear @andrew-platt,
Sorry to bother you, I used the latest version of OPENFAST to do some simulations. Currently I'm trying to use the OLAF and Turbsim to  run the 5MW_Semi test. I have already set the the UsableTime to All, but a new error occurs and I have no idea how to handle it. Here is my error.

And below are some of my input files.

I used to think that the issue might have been caused by different versions of Turbsim, but in reality, even after using different versions of Turbsim, the problem still persists.


keyboard improvements

[ ] Allow holding backspace to quickly delete text (need a separate connection)

I sometimes hit a key, the touch down registers so the button changes color. However, it seems there is no corresponding touch up so the character never shows up and the button stays pressed.


Issue with clone on macOS

Successfully built from source for macOS but clone is failing. Details below.
Thanks
Clone parameters:
Repo URL<EMAIL_ADDRESS>Branch:       Default
Cache Server: Default
Local Cache:  /Users/damiananderson/.gvfsCache
Destination:  /Users/damiananderson/firstProject
Authenticating...Failed. Run 'gvfs log /Users/damiananderson/firstProject' for more info.
Cannot clone because authentication failed: git: 'credential-osxkeychain' is not a git command. See 'git --help'.
git: 'credential-osxkeychain' is not a git command. See 'git --help'.
git: 'credential-osxkeychain' is not a git command. See 'git --help'.
git: 'credential-osxkeychain' is not a git command. See 'git --help'.
fatal: could not read Password for<EMAIL_ADDRESS>terminal prompts disabled

@damoando4 it seems Git cannot find your credential helper. What is the output of git config credential.helper?

$ git config credential.helper
osxkeychain

!/Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre/bin/java -Ddebug=false -Djava.net.useSystemProxies=true -jar /usr/local/Cellar/git-credential-manager/2.0.4/libexec/git-credential-manager-2.0.4.jar

osxkeychain


Update auth views with new structure

Update views for signup, signin, logout and profile to use the new store and controllers.

Update views for signup, signin, logout and profile to use the new store and controllers.
Make sure the authentication flow is working fine with the new code structure
Tip: things will break during the change, so focus on fixing on error at the time.


Publish a GWT module

GWT matters to relatively few Java developers, but I'm getting the impression that we're going to need to publish a GWT module if we want to be able to use it from Guava and our other projects that support GWT.
(Maybe there's an alternative in which the build systems for those projects rewrite the sources to omit our annotations, but that seems ugly, and it hides the nullness information from any tools that might consume it when compiling the client-side GWT code. Granted, I wouldn't expect nullness information to be used by the normal GWT compiler, but it could plausibly happen with the j2cl compiler.)
I have gotten Guava to depend on the Checker Framework annotations without having an official GWT module for them, but it's a bit ugly, and I suspect that users of Guava's GWT module will fail to compile because they won't see the custom GWT module we set up for the Checker Framework inside our build. ~And I just now discovered that the approach I was employing is wrong because it results in bundling the Checker Framework annotations into the guava-gwt jar :)~ [edit: now fixed] (Oddly, we were able to use the Checker Framework annotations just fine until that commit. The difference seems to be that we're now introducing an annotation in a location at which it must be a type-use annotation. Previously, we'd used Checker Framework annotations only in locations where they could also be declaration annotations.)
So my guess is that my life will be simpler if I just create a JSpecify GWT module, rather than try to hack around the absence of one and maybe end up with a crisis :)
There are at least 2 questions here:

What sort of jar do we publish to Maven Central for GWT? Does it have a separate artifact ID, or is it distinguished by a classifier? Does it declare a dependency on the jar that contains the compiled classes (since it itself will presumably contain only sources, if only to avoid overlap with the jar of compiled classes)?
How do we produce that jar from Gradle?

Possibly useful links:

https://github.com/tbroyer/gwt-maven-plugin
https://tbroyer.github.io/gwt-maven-plugin/
https://tbroyer.github.io/gwt-maven-plugin/codeserver.html
https://github.com/tbroyer/gwt-maven-plugin/issues/31#issuecomment-190246733
https://github.com/tbroyer/gwt-maven-plugin/issues/127#issuecomment-474338891
https://github.com/gwtproject/gwt-event
https://github.com/google/j2cl/blob/c11800584a6a12f688b562c1feda1b36448e6f47/samples/guava/WORKSPACE#L65
https://stackoverflow.com/a/28647734/28465
<EMAIL_ADDRESS><EMAIL_ADDRESS>https://github.com/google/guava/blob/a645ccb05da25c8cdcc26cf9af8c29cd42edd408/guava-gwt/pom.xml#L394-L404
https://github.com/google/truth/blob/a150b9c05cbe0a9a5bb9c0aeba571a48d67676a3/core/pom.xml#L112

If we're only talking about annotations, then there's no need for anything special IIRC (will double-check just in case)

The man himself! Thank you. I've been figuring we'd want to loop you in for JSpecify in general (if we hadn't at least once already?), but obviously I had you in mind for this particular question.
My experiments with Guava suggest that there's something specifically problematic about type annotations only if they appear in locations where only a type annotation would be valid (like Supplier in the linked Guava commit). But I still would have thought that would have come up by previously for us. Maybe it's only some very specific locations?

I did a few quick tests, and the issue you have with @Nullable in Supplier in Guava is indeed related to where the annotation is being used; i.e. apparently only in type parameters or type arguments. Applying it to the return type of the get() method for example works (it doesn't matter whether it's a type variable), and you only need the annotation bytecode in GWT's classpath, annotation source code is not required.
For Guava, I would suggest doing something similar to what Dagger does for javax.inject (note that in the case of Dagger, the issue is with Provider, not with annotations); i.e. include an org/checkerframework/checker/nullness/qual/Qual.gwt.xml in the guava-gwt JAR, add a matching <inherits … /> in com/google/common/base/Base.gwt.xml, and a dependency to both the binary and source JARs of checker-qual. To keep that checkerframework module the most "internal" to Guava as possible (avoid conflicts with other libs that could do the same), you could name it GuavaQual.gwt.xml instead of Qual.gwt.xml (name doesn't really matter as long as the <inherits/> matches), and for forward-compatibility you could add an <includes name="Nullable.java" /> into the <source path=""/> to only include the file that you need (other similar modules could include other files, GWT will merge those lists)
For JSpecify, to play safe (particularly given that it has zero dependency), you'd only need to have an org/jspecify/JSpecify.gwt.xml or org/jspecify/nullness/Nullness.gwt.xml file in the JAR (you could even put it in the source JAR actually; or do like Truth and make a GWT-specific JAR) with <module><source path=""/></module> (see https://github.com/google/dagger/blob/master/gwt/javax/inject/Inject.gwt.xml).
The main (maybe only) difference between Truth and Guava/Dagger approaches is with transitive dependencies. Truth's way uses the same POM for both flavors, so it cannot declare additional GWT-specific dependencies (such as source JARs); whereas Guava and Dagger both provide artifacts at separate coordinates, where the POM can then declare additional dependencies. Using Truth with GWT means adding two dependencies (the binary JAR and the GWT-specific JAR), whereas with Guava or Dagger you add the dependency to the GWT-specific artifact, which will pull the "normal" artifact transitively (for JavaC, and annotations, for which GWT needs the bytecode).

Internal testing suggests that we're probably going to need to add MODULE to the GWT copy of ElementType. That doesn't sound like it would be hard. I'll try it "sometime."
But it's also possible that, when we generate the jar of GWT sources, we could just remove MODULE from the @Target line, too. Let's call that the fallback plan.

But it's also possible that, when we generate the jar of GWT sources, we could just remove MODULE from the @Target line, too. Let's call that the fallback plan.

I was going to add "Or we could omit NullMarked.java from the GWT jar entirely, since GWT never needs annotation source for declaration annotations." But that wouldn't go well for Guava's j2cl users, who also use guava-gwt.

Now also jsinterop: https://github.com/google/jsinterop-base/issues/19

A GWT module will probably become unnecessary once https://github.com/gwtproject/gwt/pull/10021 makes it into a GWT release.


feat: add client side logging with slf4j

WIP - test failures still expected.
Will update description when ready

ci intergration are failing because cannot find slf4j classes.
external/com_google_api_gax_java/gax/src/main/java/com/google/api/gax/logging/LoggingUtils.java:39: error: symbol not found org.slf4j.Logger
import org.slf4j.Logger;

I added deps to dependencies.properties file: 172701d
Is any where else I need to add these dependencies to? Or are the names malformed? @blakeli0


Update scheduling-framework.md

[zh] Sync English documentation about Scheduler Performance Tuning

These changes should be made to the [zh] localization and not the English site
/hold


chore: Update K3s and kubectl versions

Signed-off-by: Yuan Tang<EMAIL_ADDRESS>

Hmm e2e failed. I'll have to find some time to look into that later.

controller | time="2022-02-24T03:50:03.071Z" level=info msg="Get configmaps 200"
 controller | time="2022-02-24T03:50:03.076Z" level=info msg="Configuration:\nartifactRepository:\n  s3:\n    accessKeySecret:\n      key: accesskey\n      name: my-minio-cred\n    bucket: my-bucket\n    endpoint: minio:9000\n    insecure: true\n    secretKeySecret:\n      key: secretkey\n      name: my-minio-cred\ncontainerRuntimeExecutors:\n- name: emissary\n  selector:\n    matchLabels:\n      workflows.argoproj.io/container-runtime-executor: emissary\n- name: pns\n  selector:\n    matchLabels:\n      workflows.argoproj.io/container-runtime-executor: pns\nexecutor:\n  imagePullPolicy: Never\n  name: \"\"\n  resources:\n    limits:\n      cpu: 500m\n      memory: 128Mi\n    requests:\n      cpu: 100m\n      memory: 64Mi\nimages:\n  argoproj/argosay:v1:\n    command:\n    - cowsay\n  argoproj/argosay:v2:\n    command:\n    - /argosay\n  docker/whalesay:latest:\n    command:\n    - cowsay\n  python:alpine3.6:\n    command:\n    - python3\ninitialDelay: 0s\nkubeletInsecure: true\nlinks:\n- name: Workflow Link\n  scope: workflow\n  url: http://logging-facility?namespace=${metadata.namespace}&workflowName=${metadata.name}&startedAt=${status.startedAt}&finishedAt=$E0224 03:50:03.089688   11876 portforward.go:406] an error occurred forwarding 3306 -> 3306: error forwarding port 3306 to pod 36b1566f288974f3095763abf4d33d830aed83c2ca9f80ef04a46ba02a50ba88, uid : unable to do port forwarding: socat not found
E0224 03:50:03.089949   11876 portforward.go:234] lost connection to pod

@alexec Were you able to verify that https://github.com/argoproj/argo-workflows/pull/7832 works on newer versions of K8s?


New type for custom Drupal profiles

We have install types for custom Drupal modules and themes but nothing for profiles. I am requesting a new type of drupal-custom-profile.

Same boat; we have a number of custom profiles on an internal packagist. Updating the composer.json shipped with Drupal core is the only current alternative. Please see https://github.com/composer/installers/pull/416

Shouldn't this issue be closed since #416 was merged?


WFLY-13357 Execution of concurrent batch jobs containg partitioned st…

JIRA: https://issues.redhat.com/browse/WFLY-13357

The test failure seems related.

Yes, it seems like a test bug.
org.jboss.as.test.integration.batch.transaction.BatchTransactionTimeoutTestCase#testThreadIsAvailableForNextJob currently sets a max thread count to 1, while the updated job executor requries at least 2.

The test bug BatchTransactionTimeoutTestCase#testThreadIsAvailableForNextJob has been fixed by increasing the max-threads from 1 to 3, and changing the batch job step to be a 2-partition chunk step.

@jamezp can you review it?

@jamezp Yes, See https://github.com/jberet/jsr352/blob/master/jberet-core/src/main/java/org/jberet/runtime/runner/JobExecutionRunner.java#L144 .I think this is a reasonable requriement for the users.

@chengfang This is a change in behavior then that we likely want to look at changing on the resource. It shouldn't be allowed to set to anything less than 2 in the model. We also need some documentation to some extent about this.

This is already documented via attribute description:
https://wildscribe.github.io/WildFly/18.0/subsystem/batch-jberet/thread-pool/index.html
"The thread pool used for batch jobs. Note that the max-thread attribute should always be greater than 3. Two threads are reserved to ensure partition jobs can execute."
But this min value of max-thread is not currently enforced in CLI.


AutoProcess is converting ".rvt" files to ".cfb"

When uploading a file:
const file = request.file("file")

The file is converted to the wrong file type.
Log:
fieldName: 'file',
  clientName: 'TestFile.rvt',
  headers: {
    'content-disposition': 'form-data; name="file"; filename="TestFile.rvt"',
    'content-type': 'application/octet-stream'
  },
  size: 59801600,
  errors: [],
  meta: {},
  state: 'consumed',
  extname: 'cfb',
  type: 'application',
  subtype: 'x-cfb',
  tmpPath: '/tmp/cl4rfvjj800008i0p76xf2pm1'

I can send you a test file. Github won't let me paste it in here.
Package version
@adonisjs/bodyparser:
"version": "8.1.3",
Node.js and npm version
node: "16.14.2"
npm: "8.12.1"
Similar issue:
https://github.com/adonisjs/bodyparser/issues/53#issue-1216797748

Please upgrade to the latest of<EMAIL_ADDRESS>The issue was fixed in https://github.com/adonisjs/bodyparser/releases/tag/v8.1.5


the input text inside a grid item can not be selected by double click or press down & move

I paste a picture to explain, I have a custom component inside a grid item, and the input text inside the grid item can not be selected by double click or press down & move behavior. I think it is because the grid item has intercepted the press down and move event used to move the grid item inside the grid container.
so is there a way to allowed press down and move event in the grid item content? or setting a specific area to perform grid item move event just like the 'resizeHandle' ?

Use draggableHandle property.
<ResponsiveReactGridLayout draggableHandle={'.your-classname-handle'} {...props}>

draggable

child content not draggable

</ResponsiveReactGridLayout>

@mlisthenewcool  thanks, that works for me. but it seems not support multiple draggableHandle? tried '.triggerA , .triggerB', doesn't work.

使用腾讯会议的时候，界面好像又一层蒙版，点击item里面的按钮直接出发拖拽，导致无法点击，加上draggableHandle新增一个拖拽按钮item里的其他按钮才可以正常点击

@mlisthenewcool you can use draggableCancel to address where can not drag, it means where can copy and select text. In my case: My grid has 2 parts, the first is the header, the second is the body content. I will add draggableCancel=".class-name-of-body-content".
So my grid can copy any text in the body and only draggable when clicking on the header.
Hope it will help you.

Just why I needed, thaks!

使用腾讯会议的时候，界面好像有一层蒙版，点击item里面的按钮直接触发拖拽，导致无法点击，加上draggableHandle新增一个拖拽按钮item里的其他按钮才可以正常点击

之前有一个需求演示的时候 ，发现腾讯会议直接操作浏览器无法直接触发里面的属性


Fix assertion -- an import may come from a require() call

Fixes #19629

Please port this to release-2.6


fix tr with any flag with more than 2 operands

turns out all tr flags should fail with the same massage not just delete flag if the number of operands is more than 2 so i rewrote the part i did write so all the flags fails with more than 2 operand
so now
gnu tr:
>tr -s a b c
tr: extra operand ‘c’
Try 'tr --help' for more information.
[ble: exit 1]
~
>tr -d a b c
tr: extra operand ‘b’
Try 'tr --help' for more information.
[ble: exit 1]

and uutils tr
>cargo run tr -s a b c
   Compiling coreutils v0.0.24 (/home/broly/sad/coreutils)
   Finished dev [unoptimized + debuginfo] target(s) in 2.68s
   Running `target/debug/coreutils tr -s a b c`
tr: extra operand 'c'
Try 'target/debug/coreutils tr --help' for more information.
[ble: exit 1]

>cargo run tr -d a b c
  Finished dev [unoptimized + debuginfo] target(s) in 0.10s
  Running `target/debug/coreutils tr -d a b c`
tr: extra operand 'b'
Try 'target/debug/coreutils tr --help' for more information.
[ble: exit 1]

this fixes #5950
but i have 2 questions

in gnu tr it takes any number of arguments even if more than 3 (which works here) but where to stop? so i choose to make the maximum number 32 is this right?
is there a better way to add strings together the way i did it looks ugly 🥹

I think you can omit the max number and use 1..
You could use format! to simplify it

sorry for the inconvenience 😅

Thanks for your PR :)


Code Quality Improvement - Empty arrays and collections should be returned instead of null

This pull request is focused on resolving occurrences of Sonar rule squid:S1168 - “Empty arrays and collections should be returned instead of null”. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1168.
Please let me know if you have any questions.
Christian Ivan.

Very professional PR, Merged!
Thanks for your contribution!


Support stringifying array containing value 0

For whatever reason, I need to send these kind of query strings to a server:
idList=0,1,2,3

Before : 0 value was ignored.
After : 0 value is well added to the final string

Could you review please @sindresorhus @kevva @SamVerschueren  ?


[Android] Audio only plays through ear speaker and not loud speaker

Describe the bug
A clear and concise description of what the bug is.
Audio only plays through ear speakers and not through loud speakers. Only when app continues to play while the display turns black (i.e. in background) it switches to the loud speaker.
To Reproduce
This happened to me on many Android devices (four devices I tested so far).
For example:

Samsung Galaxy 4S with Android v5.0.1
Samsung (Model SM-A320FL) with Andorid v8.0.0

The only Android device this did not occur on so far is a Nexus5X with Android 8.1.0.
Because it works on a device but not on others I can't reproduce it so far.
Environment (please complete the following information):
Run react-native info in your project and share the content.
System:
    OS: macOS Mojave 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 129.27 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.14.1 - ~/.nvm/versions/node/v10.14.1/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v10.14.1/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
    Android SDK:
      API Levels: 23, 24, 25, 26, 27, 28
      Build Tools: 23.0.1, 24.0.2, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 27.0.2, 27.0.3, 28.0.2, 28.0.3, 29.0.0, 29.0.0, 29.0.0, 29.0.2, 30.0.0, 30.0.0
      System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-R | Google Play Intel x86 Atom
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>08749
    Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
  npmPackages:
    react: ~16.9.0 => 16.9.0
    react-native: ~0.61.4 => 0.61.5
  npmGlobalPackages:
    create-react-native-module: 0.19.0
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

What react-native-track-player version are you using?
dev branch
Are you testing on a real device or in the simulator? Which OS version are you running?
Real Android devices as described above.

I investigated it further. The sample app plays on the loud speaker.
My app initially plays on the earpiece and by then leaving the application once or twice (sometimes a second attempt is necessary) and entering it again, the app then somehow switches to playing over the loud speaker as it should. And also the volume control now controls the "media" output and not the "phone" output anymore.
So the issue more precisely is that the output is somehow erroneously switched to the phone initially. Did that happen to anyone else before?

After further investigation I found that I accidentally set the Android output to play through the earpeace with expo-av in a hack I used for something else. So it's all unrelated to this lib. Sorry for the confusion.


Ensure buy and sell nft work with dynamic data on the app

Ensure that the app with dynamic vaults and nfts work for buying nft and selling nft.
About the ICA. since the existence of an ICA account is not reliable, I want you to replace on the ICA message the sender of the transaction the following way:
if ica exists use that address on the ica message for buy/sell. If it doesnt use a placeholder address (any injective address).
Create the proposals and ensure that this section of the app fetches the proposal nft information correctly: https://github.com/chelofinance/Xion-hackton/blob/a987795ef283cc8e637df85e2e1ac950c432e8db/frontend/hooks/useMyNFTVaults/index.ts#L45-L51
Again, a vault can "propose" to buy an nft and will raise funds to do that. So the fetching part should get the vault proposals and search for the nft information there. On the nft object the buyContractAddress will be the one used for reference since the buy/sell should interact with this contract

talk to @estellechoi to know where in the app the vault should show the nfts we are raising for and show the nfts in the proposal there


Moveit: trajectory is planned and executed, but Rviz doesn't display the robot final pose.

Doing this command, and activating moveit i can move the robot into the position i want. The motion is planned, and executed, but the robot visualized in Rviz doesn't move itself in the pose previously planned and executed successfully
ros2 launch franka_fr3_moveit_config moveit.launch.py robot_ip:=dont-care use_fake_hardware:=true

Of course the  /franka/joint_states topic velocity and position are not updated with the current position and velocity to reach the executed pose.
This is not the case specifying the robot ip (with the real robot connected).

Hi @emarca96 ,
I guess this is expected - after all you use the fake_hardware. If you want that the robot is moving, you would e.g. need to use gazebo or the actual robot :smile:
Cheers,
Andreas


Improved Yarn container fault tolerance handling

Added an option to use the same host as the preferred host when requesting a replacement container.
The Helix instance names of containers are now controlled and assigned by the ApplicationMaster, which maintains a fixed set of Helix instance names that get reused for replacement containers.
Added support to stop attempts on requesting a replacement container for a Helix instance if the retry count of the instance has reached the maximum.
Note that we don't measure how soon a Helix instance fails and stop retries if it's too soon, as Samza does. The reason is container failures in our case will mostly not be due to job/task issues and may be very likely transient. Even if a container fails consecutively really fast due to persistent issues, e.g., node failures, the system will stop retries after the maximum of retries gets reached anyway.

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

@sahilTakiar can you review?

@sahilTakiar updated e18cde6.

@sahilTakiar can you take another look e18cde6?

One minor comment. Otherwise LGTM


DRNE Freesurfer has lambda parameter

Problem
The DRNE Freesurfer computation has lambda as a parameter in the computation set up. As lambda is a regularization parameter, and this computation does not do regularization, there should be no lambda parameter. Lambda is only for ridge regression.
Tasks
Remove lambda from parameters that appear on computation set up.

@everner-ds  It's not a bug. It's okay to have lambda with normal equation as well. Just that in practice, since we deal with large datasets and normal equation (finding inverse) in not practical, we resort to gradient descent. For more info, please refer to the link below.
http://openclassroom.stanford.edu/MainFolder/DocumentPage.php?course=MachineLearning&doc=exercises/ex5/ex5.html

Okay, thanks. That makes sense. I'll close this issue.


history-substring-search: bind arrows in both vi and emacs keymaps (post-#4190 upstream update)

This is a version of #4192 that can be used if #4190 (harmonizing history-substring-search with upstream) gets merged in. It's a nontrivial merge, so I put in a separate PR, so people could see how it would work with the upstream-pulling mechanism.
Depends on #4190 (and includes its commits).
Closes #4192.
Partially fixes #2735.
Description
This binds the arrow keys in both the emacs and viins keymaps so up arrow will "work" in both emacs and vi mode, and regardless of whether the vi-mode plugin is loaded before or after this.
Note that the arrow keys still won't work in vi mode if the vi-mode plugin is loaded until #4191 is also merged, because the widgets in vi-mode are preventing terminfo mappings from working.

Merged. Now you can delete all those histsubstr* branches :joy:


ARXIVNG-169 Async worker pattern

@DavidLFielding and @mhl10: Eager for your feedback. See especially tests/test_e2e_thing_mutation.py

Coverage increased (+4.3%) to 90.086% when pulling 80a7d72adcd08025412cb213c8095f35ea4ce7f7 on task/ARXIVNG-169 into df615e74e0571a9a406e6239dcf96095527c3d4f on develop.


HubConnection is not available on HubCallerContext 1.0.0-preview2-final

The Connection property was available in preview1 but is private in preview2.
We are using the connection to retrieve the RemoteIpAddress (among others), so we need the connection object.
var ipAdr = this.Context.Connection.RemoteIpAddress; // not available in preview2-final

Is there an alternative for preview2-final to retrieve the remote IpAddress?
Edit:
var remoteIp = Context.Features.Get<IHttpContextFeature>().HttpContext.Connection.RemoteIpAddress;
seems to work

You can simplify it by doing:
var remoteIp = Context.GetHttpContext()?.Connection.RemoteIpAddress;

HttpContext can be null but it isn't when you're running in ASP.NET Core. It'll be possible to run on transports that don't have an IP so you should make sure you're checking for null.


AT+CIPCLOSE uses RST instead of FIN

Because the firmware (AT 1.7.4) contains so many annoying errors, I wanted to try this firmware.
I have implemented a webserver on my host system, which closes the connection with Close after completion.
Unfortunately this does not work anymore, because the browser tells me that the connection was closed with a RST instead of a FIN.

@Maintraxx Could you please providing the tcp packets and AT log, AT commands you input, version by AT+GMR.

Yes, here is a real example:
Version
AT+GMR
AT version:<IP_ADDRESS>-dev(7963ea8 - ESP8266 - Aug 25 2020 07:31:48)
SDK version:v3.3-2-gb6e861a7
compile time(cf63f23):Aug 28 2020 11:08:11
Bin version:2.0.0(Unknown)_
AT-Log
+LINK_CONN:0,0,"TCP",1,"<IP_ADDRESS>",58214,80
+IPD:0,534
AT+CIPRECVDATA=0,534
+CIPRECVDATA,534:"payload"
OK
AT+CIPSEND=0,145
OK
>
"payload"
Recv 145 bytes
SEND OK
AT+CIPSEND=0,256
OK
>
"payload"
Recv 256 bytes
SEND OK
AT+CIPSEND=0,35
OK
>
"payload"
Recv 35 bytes
SEND OK
AT+CIPCLOSE=0
0,CLOSED
OK

Transmitted Payload

TCP Packets

RST Packet

Additional information: It seems, that this only occures for small packages. (~ < 512Byte). If i transfer larger sites, everythink works as expected.

will take a look this week

@Maintraxx I tried several time, i am afraid that can not reproduce it.
@SUNLUXIN Could you please help to reproduce it.

Maybe it depends from "SO_LINGER"?
https://github.com/espressif/esp-at/blob/master/docs/en/AT_Command_Set/TCP-IP_AT_Commands.md#cmd-TCPOPT
I tried several settings, but the result is always the same.

the AT firmware didn't get ACK for the last packet so it issued a RST

SO_LINGER is off by default. It will not close the connection use RST instead of FIN.
have you set this configuration?

No, i don't use it. I made some test with the linger option, but it makes no differences regarding this behaviour.

what is the esp-at firmware version, have you tried the latest version?
tested with the following version, and i am sorry that can not reproduce it.
AT+GMR
AT version:<IP_ADDRESS>-dev(ca41ec4 - ESP32 - Sep 16 2020 11:27:04)
SDK version:v4.0.1-193-ge7ac221b4
compile time(ab79540):Oct  9 2020 10:28:49
Bin version:2.1.0(WROOM-32)

OK

I'm working on a ESP8286. The version is:
AT+GMR AT version:<IP_ADDRESS>-dev(7963ea8 - ESP8266 - Aug 25 2020 07:31:48) SDK version:v3.3-2-gb6e861a7 compile time(cf63f23):Aug 28 2020 11:08:11 Bin version:2.0.0(Unknown)

I tested the ESP8266 firmware, it looks like work well.
ready
AT+CWMODE=1

OK

AT+CWJAP="huawei_chenwu",""
WIFI CONNECTED
WIFI GOT IP

OK
AT+GMR
AT version:<IP_ADDRESS>-dev(ca41ec4 - ESP8266 - Sep 16 2020 10:34:08)
SDK version:v3.3-25-g5c773fc8
compile time(ab79540):Oct  9 2020 19:54:17
Bin version:2.0.0(WROOM-02)

OK
AT+CIPMUX=1

OK
AT+CIPMODE=1

ERROR
AT+CIPRECVMODE=1

OK
AT+CIPSTA?
+CIPSTA:ip:"<IP_ADDRESS>"
+CIPSTA:gateway:"<IP_ADDRESS>"
+CIPSTA:netmask:"<IP_ADDRESS>"

OK
AT+CIPSTART=0,"TCP","<IP_ADDRESS>",8080
0,CONNECT

OK

+IPD,0,5
AT+CIPRECVDATA?

ERROR
AT+CIPRECVDATA=0,5
+CIPRECVDATA:5,hello
OK

+IPD,0,549
AT+CIPRECVDATA=0,549
+CIPRECVDATA:549,
...
OK
AT+CIPSEND=0,145

OK

>

Recv 145 bytes

SEND OK
AT+CIPSEND=0,256

OK

>

Recv 256 bytes

SEND OK
AT+CIPSEND=0,35

OK

>

Recv 35 bytes

SEND OK
AT+CIPCLOSE=0
0,CLOSED

OK
AT+GMR
AT version:<IP_ADDRESS>-dev(ca41ec4 - ESP8266 - Sep 16 2020 10:34:08)
SDK version:v3.3-25-g5c773fc8
compile time(ab79540):Oct  9 2020 19:54:17
Bin version:2.0.0(WROOM-02)

OK
AT+SYSRAM?
+SYSRAM:46324,39748
OK

Could you please try with this firmware: http://download.espressif.com/esp_share/github/esp-at/issues/target.bin, which i test ok.

The size of your Bin-File is 2MB, but my ESP8285 only has 1MB capacity.

@Maintraxx Please try with the firmware here: https://github.com/espressif/esp-at/suites/1256130336/artifacts/19184934

Thank you.
With this version, the uart did not work as expected. After the boot, the ESP-Tx-Line goes low and no communication is possible:

This problem has been reported in #445

Problems seems to be gone with the actual version.


doc: release: add release notes for disk drivers

Add release notes for disk drivers. Primary update since 3.0 was
addition of generic SDMMC disk driver.
Signed-off-by: Daniel DeGrasse<EMAIL_ADDRESS>

@mbolivar-nordic  FYI

Thanks!


Odd current line decoration border between line and gutter in our themes

Only our 5 themes seem affected by it:

Light
Light+
Dark
Dark+
High Contrast

I will reduce the width, but there will still be a border between the two. I think that helps with letting users knows where the first char would start, especially when having indent guides off:
Before:

After:


Cursor becomes invisible when setting lazyredraw

Neovim version: NVIM v0.4.3 installed via brew
OS: osx
Minimal vimrc:
set lazyredraw

Repro steps:

Open neovide
Execute / and type some characters until the cursor goes invisible
Hit escape
Cursor should now be invisible while navigating buffer

Woah I've never heard of this option. I will look into it.

I cannot reproduce this issue. I am running neovim 4.2 and do not see the problem

I just updated to nightly and don't see the issue their either.

He just found the setting I lost, lazyredraw is causing #53 for me.
I remember reading about lazyredraw here and adding it to this machines init.vim, but I never put that into my backup init.vim.
That's why the problem disappeared when I restored my usual rc files.
Until the cause is found adding set nolazyredraw instead of  set lazyredraw will fix it.

Wait what. Lazyredraw is causing a font load error for you?

I meant #58 sorry for the confusion. 😄

Ah that makes much more sense. And now that you mention it, I've noticed this happening on my machine now as well. I'm considering making an upstream neovim issue as I don't think it makes sense for the cursor to ever move to the powerline. Thoughts?

Oh also I can now repro the above steps. Thats a very weird bug

I need better logging to track this down

Yes reading the issue on the vim-sensible project makes it pretty clear that lazyredraw not only causing issues with some terminals but there are also reports of nvim completely breaking because of it. Maybe you can ignore this setting somehow?

Weirdly I'm not using the setting at all its all internal stuff. I could track the option and disable it with a message, but that feels like a hack since it definitely improves macro performance...

Does it though in neovide? As I understand it lazyredraw should only make sense in a terminal context because the way you draw things is different than a terminal would do it. Also your drawing loop isn't tied to the neovim update loop isn't it?

Oh very interesting. The bug happens even without lazyredraw. Searching, typing random characters, and then pressing escape causes the cursor to stay missing.

I have no idea what lazyredraw does.
Neovide's render loop is not tied to the neovim update loop so youre probably right. That said, the jumping the cursor to the command line is clearly an internal effect of lazyredraw so I'm not sure whats happening.

I guess it does what it says in the name.
NOTE: The next few lines are just based on reading on neovim and speculation on how it works. I have never implemented a neovim client nor worked on neovim.
Even tough neovide is drawing everything, lazyredraw probably activates something in vim that reduces the amount of drawing that is happening in the context of a terminal. My understanding is that building your own neovim client is all about IPC and if neovim does less it will generate less events or not all that would have been created.
In the terminal that is okay because there usually some default behaviour that makes the cursor go back but external applications have to either also implement that behaviour or just ignore it.

This seems reasonable to me. Disabling lazyredraw is a good plan

Done. Disabling on startup. If this causes problems, either open an issue or comment here and I will figure something more out.

fwiw this is probably something that should be resolved in Nvim core, since it is intended that multiple UIs (including TUI) may be attached to one Nvim server.

Interesting. Would you like me to make an issue in nvim? I can give some details and link back to this issue.

I can give some details and link back to this issue.

would be great!

Done: https://github.com/neovim/neovim/issues/11806

Swapping this issue over to the original issue

The original issue is an upstream problem which I believe will be fixed by https://github.com/KillTheMule/nvim-rs/pull/13 or something similar.

This should be fixed.

So be clear, is lazyredraw supported in neovide?  I actually find this setting to be really helpful performance wise in both terminal vim and nvim-qt

There is an upstream issue here: https://github.com/neovim/neovim/issues/11806 Until the core issue is fixed, it is not supported.


Alt action on beaker with liquid triggers two actions at the same time

Description
Both setting custom transfer amount and drinking get triggered.
Reproduction

Fill bearker with some liquid
Alt click it
You now drinking some dangerous chemical

Screenshots
https://github.com/user-attachments/assets/ee7817c2-e54f-46bf-81ec-ec9bf6d41eb1
Additional context

dupe https://github.com/space-wizards/space-station-14/issues/29749


24h Mode of JFXTimePicker shows AM-Times as PM

As you can see in this Screenshot, it should show 10:30, but instead of pointing to 10 the chooser points to 22.
PM-Time works fine:

I'm using Version 9.0.10 with Java 14 and javafx 14.

I would like to work on this @Strohgelaender @aashigupta19


Request for a new release 0.6.1 or 0.6.1-prerelease

I understand you are busy, but would it be possible with a release on the current state of the code.
Use hyperjaxb3 at work together with cxf, 0.6.1-SNAPSHOT contains support for xjc 2.2.11.
Can't upgrade to cxf 3.x or 3.1.x without 0.6.1-SNAPSHOT since that version of cxf-codegen-plugin uses xjc 2.2.11 and causes conflicts with 0.6.0.
Problem to release with maven with snapshots dependencies, could always change versions myself and deploy to our internal company maven repository. But would like to avoid having "fake" versions.

Does 0.6.1 "as is" work for you?

Would be perfect, don't have any problems with it.

Thank you for the release, but can't find the released version anywhere.
Have you published 0.6.1 to any maven repository ?
Can only find https://oss.sonatype.org/content/repositories/snapshots/org/jvnet/hyperjaxb3/ 0.6.1-SNAPSHOT updated Mon Nov 23.

It's not released yet, issue was mistakenly closed. I'm still fighting a bit with tests and release scripts.

Ok, NOW it is released.


docs: added getResponse instance method

fixes #187
Changes:

add getResponse instance method to readme

adds getResponse example which just alerts it

Pull Request Test Coverage Report for Build 942

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 938:
0.0%

Covered Lines:
79

Relevant Lines:
79

💛  - Coveralls

Hey @AndyOGo, I guess you didn't notice, that I've already created a PR for this: #187 :) We can keep both tho: we'll just keep the example from this PR.

@sarneeh Thanks for your quick answer.
Sorry I didn't check for open PR's.
Feel free to cherry pick or close this one

@sarneeh
Do you have any time soon, to check if you agree with this example?


Prune does not remove all pods

Although it has propagationPolicy: 'Foreground'

Pharos::Kube::Stack#prune also does not list/delete any resources in the core v1 API group.

Pharos::Kube::Stack#prune also does not list/delete any resources in the core v1 API group, like services.

Maybe that's why it's not working properly :)

Although it has propagationPolicy: 'Foreground'

For the get_entities => Pharos::Kube::Resource#delete case where the resource has metadata.selfLink, it gets deleted without setting any ?propagationPolicy:
https://github.com/kontena/pharos-cluster/blob/204c2d20deb46a790a1f633c557cde2abe260fc1/lib/pharos/kube/resource.rb#L58-L61
RestClient.get "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/daemonsets?labelSelector=pharos.kontena.io%2Fstack%3Dkubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 157 bytes
RestClient.get "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/deployments?labelSelector=pharos.kontena.io%2Fstack%3Dkubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 2856 bytes
RestClient.get "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/ingresses?labelSelector=pharos.kontena.io%2Fstack%3Dkubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 154 bytes
RestClient.get "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/networkpolicies?labelSelector=pharos.kontena.io%2Fstack%3Dkubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 166 bytes
RestClient.get "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/podsecuritypolicies?labelSelector=pharos.kontena.io%2Fstack%3Dkubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 174 bytes
RestClient.get "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/replicasets?labelSelector=pharos.kontena.io%2Fstack%3Dkubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 159 bytes
RestClient.delete "https://<IP_ADDRESS>:6443/apis/extensions/v1beta1/namespaces/kube-system/deployments/kubernetes-dashboard", "Accept"=>"*/*", "Accept-Encoding"=>"gzip, deflate", "User-Agent"=>"rest-client/2.0.2 (linux-gnu x86_64) ruby/2.4.3p205"
# => 200 OK | application/json 2850 bytes


Fix #20273: Remove unnecessary paragonie/random_compat dependency

Given that Yii itself requires PHP 7.3 since 2.0.50, this dependency does nothing, as PHP 7.0+ guarantees the existence of the CSPRNG.

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
n/a

Thank you!


Close stream resource if connection fails

Currently, if a connection attempt is being rejected, the resulting promise will successfully be rejected. However, the underlying socket resource will not be closed (and is not exposed to the outside).
This is a trivial fix for leaking these resources.
This situation is already covered by our test cases, so it does not include additional tests. We could look into counting open socket descriptors, but we'd likely have to resort to using system utilities as PHP does not appear to offer anything related.
This PR builds on top of #46, so the diff also includes its changes. Look here for changes only related to this PR alone. (no longer applies after rebasing)

I've just rebased this on the current master now that #46 is in.
Ready for review :)

LGTM :shipit:


Version not updating

I added the 10.0.18362.657 lines in my rdpwrap.ini but the version shows 10.0.18362.53 in the wrapper configuration. Any ideas why the version wont update?

Have you got Windows updates to apply to get a later version.  The version that shows in rdpconf is the one of the termsrv.dll .... not what it finds in the INI file.


Support GHC 9.2

Blocked on:

[x] aeson (https://github.com/haskell/aeson/issues/885)
[x] semialign (is actively worked on)

I tried
$ cabal build --allow-newer=aeson:all --constraint='aeson==2.*' \
  --allow-newer=scientific:{base,template-haskell} --constraint='scientific==0.3.7.*' \
  --allow-newer=semialign:base

but semialign does not build with 9.2 because Option was removed from base-4.16.

goldplate-0.2.0 works with GHC 9.2 without changes.


Release Google.Cloud.ErrorReporting.V1Beta1 version 2.0.0-beta05

Changes in this release:

Commit ac367e2: feat: Regenerate all APIs to support self-signed JWTs

Created release for Google.Cloud.ErrorReporting.V1Beta1-2.0.0-beta05


feat: allow to disable oneauth

Description
Allow to provide tokens directly in the electron app release by running with COMPOSER_ENABLE_ONEAUTH=false environment variable
#minor

Coverage: 54.548% (-0.004%) from 54.553% when pulling abf9a749d8230bb0cf524ee51da5d324fb8edf22 on OEvgeny:feat/allow-disable-oneauth into 8628464fe4c09a00485c066921cd977524931785 on microsoft:main.


ajax autocomplete option

Hi. Is it possible to use the plugin with autocomplete made with ajax? Can someone provide a sample code?
Regards.

I dont think there is something like on_autocomplete(entered_text) yet.


Wacatac.b!ml

This is because Electron apps are marked as a virus as often abused.
https://github.com/electron-userland/electron-builder/issues/6474

Any solutions you've found?
Same issue here: https://github.com/reorproject/reor/issues/58


Check on GCC version used (nice to have enhancement)

Ran into this also (https://github.com/Open-CMSIS-Pack/devtools/issues/21) with the default GCC (7.5.0) on Ubuntu 18. Was trying the approach of just building it, hitting cmake and diving in before reading the docs. Quickly moved on to trying a newer version of GCC but it would be nice to have a warning on GCC version printed out during compile. Something like a check on __GNUC__ macro in the code or a check in the CMakeLists.txt.

@JacobBarthelmeh, Could you please check if the addition in #698 does the job for you?

It printed out a helpful warning with the default gcc 7.5.0 on the older Ubuntu. Seems good.


[BUG] Multiple items are sold when only one is sold

Solved implicitely by requireing that all items in the shop are different.


chore: Update black to full released version (22.1)

Description
Update black to released version (not pre-released)
Motivation and Context
Finally black has a full release. There are some changes to how it formats python code. We will be using the full release going forward.
Types of changes

Dev Dependency update

IMPORTANT
This PR does not include actual format changes. After this PR is merged, the following will need to happen:
deactivate
<delete your virtual environment, for example> rm -rf .venv
git checkout develop
git pull
git status (ensure no files have changed)
poetry install
poetry run make format
git add -A
git commit -m "style: Apply code format for black 22.1"
git push

black is up to v22.3 now

Black is at 23.12.1 in this repo at this point, so closing this out as it's basically addressed.


⚠ gorzdrav.org has degraded performance

In 4faaf81, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 2549 ms

Resolved: gorzdrav.org performance has improved in 3524ae3.


feat: add a Swift stack

Add a Swift stack. This provides a "Hello World" Swift application which builds and runs on Swift 5.
TODO: sort out swift/image/project/Dockerfile - it's probably not right.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@ianpartridge Thank you for your contribution, we really appreciate this.
We will start reviewing this shortly.

@ianpartridge  Can you please review and sign our CLA.

Done!

Is this now ready to merge?

Is there anything stopping this from being merged?

reviewed and tested:

[x] appsody run
[x] appsody test
[ ] appsody debug (no debug cmd provided)
[x] appsody build
[ ] appsody deploy (having a bit of trouble with KNative)

[ ] appsody debug (no debug cmd provided)

There isn't really a good mechanism for doing remote debug in Swift, which is why this isn't enabled - I have some thoughts on how we might do this but its not worth holding on the PR for it.

Hello world message appears in the terminal and changes are reflected but when I hit localhost:8080 when the container is up it doesn't respond with anything..

This is the same as for the base nodejs Stack - the stack and template don't contain a web framework (the assumption is that you'll bring your own as part of your application).  The template, as it is today, will print "Hello World" to the console.

Ahh i see, we should update the README as it says

This launches a Docker container that continuously re-builds and re-runs your project, exposing it on port 8080.

We could make the README clearer by adding something this or similar:
This launches a Docker container that continuously re-builds and re-runs your project. It also exposes port 8080, to allow you to bring your own web application and use it with this stack.

You should see a message printed on the console:
Hello, world!

I'm out today - feel free to push whatever you need to move this forward.


Lazy connection pool - pipeline issue

txredisapi ( trying the master branch which has the fix for pipeline pool) hangs when there are greater number of concurrent pipeline commands executed than the maximum connection pool size.
How to reproduce :
1- Create lazyConnectin pool with pool size 2
2- Execute any more than 10 pipeline requests
Simple sample code to reproduce above is added below. The code should output all the 100 requests but it outputs only around 60.
import txredisapi as redis

from twisted.internet import defer
from twisted.internet import reactor
def print_result(result,count=0):
    print "got the result for count",count

def process(pipeline):
    pipeline.smembers('key1')
    return pipeline.execute_pipeline()

@defer.inlineCallbacks
def main():

    rc =  redis.lazyConnectionPool(poolsize=1)

    for i in range(100):
        rc.pipeline().addCallback(process).addCallback(print_result,count = i)
    yield rc.disconnect()

if __name__ == "__main__":
    main()
    reactor.run()

Hmmm, that's odd. I was not able to reproduce this on my machine (using the HEAD of master on fiorix/txredisapi.
I tried setting the poolsize to 1, 2, and 10, having an empty set at key1 or a set with several elements, but each time all 100 requests completed successfully. Can you supply additional details about your test setup?

@steiza  I was testing my test case with 1.3 branch code of tx-redis api which do not have the pool fix you did.
Actually the issue I mentioned was with my application code. There were some connections being requested while redis pipeline was created but not finished. This was creating the block ( Dead lock like scenarion while waiting for connection from pool ) scenario you mentioned in above comment when there are more number of concurrent users. I fixed it by avoiding code which uses more than one connection concurrently. Thanks alot for helping me to find the root cause and apologies for wasting your time with my test case.

I also witness this behavior in my applications when I have a burst of redis activity, it causes pauses in the rest of my program. I did not expect such behavior. I am still investigating it.

I believe that pipeline() is mostly useless. Thanks to async nature of txredisapi you can issue as many parallel requests as you like even with a single connection and they will be pipelined automatically. There won't be any perfomance gain from batching requests together with pipeline().
This doesn't excuses deadlocks though. And if the problem is really in txredisapi code, it may affect watch()/multi() too because implementation is somewhat similar.