Preference implementation

Issue
I wanted ptpython to have certain value on startup. For example, I always wanted to show the docstring and not change it each time.
Solution
This fork reads ~/.ptpython for new startup values. This file does not have to exist, and not every option has to be included. This fork keeps the default values and only overwrites the default value if it finds a new value in this file.
The ~/.ptpython follows the INI file format, going off Python's ConfigParser (which plays nice with 2to3). For example, here is a file that loads the default values:
;  FILE: ~/.ptpython

[startup]
complete while typing : True
paste mode            : False
show signature        : True
show docstring        : False
show linenumbers      : True

But having all the preferences is not nescessary; my ~/.ptpython file is
[startup]
show docstring : True

If there are errors in parsing, it produces a helpful message (tested with comments, headers):
ConfigParser.ParsingError: File contains parsing errors: /Users/scott/.ptpython
	[line  2]: 'this is not a comment!\n'

I have included similar documentation in the PythonCLISettings docstring.
Further work

nosetesting. The basic testing I did passed.
Allow default keymaps to be changed

Sweet.

Hi @scottsievert  Thanks a lot for spending the time on this pull request.
I'm however not yet going to merge it straight away. Recently I made pyvim configurable, and probably I'd like to have the same approach here, because that gives a lot more flexibility. (Adding custom key bindings, color schemes, macros, etc...)
So, please allow me some more time, to do some changes, and hopefully we have that soon.
Jonathan

Sounds good. What's the ETA of that?

Hi @scottsievert:
Preferences were implemented: https://github.com/jonathanslenders/ptpython/blob/master/examples/ptpython_config/config.py
(Sorry about not using your pull request, it was too different from the approach I wanted to take.)
Next step is to allow changing the color scheme dynamically..
Jonathan

No worries -- I'm just glad it got implemented!


breaking under heavy http insert load

I have a cli loader that is managing to panic the ponzu server while doing about 160 http post requests in a loop, new http.Client for each request.  Putting a 50 millisecond delay between each request causes the issue to go away and all requests in the loop to complete with success.

I have a feeling it's just that with each write to Bolt, Ponzu runs a sort in a goroutine on the bucket you're impacting and there could be some race issues at the transaction level if too many writes are happening at once.

If you do a search for SortContent in the codebase you'll see what I'm referring to. This sorting method isn't an ideal process and should be rethought. But, for the systems I built Ponzu to support the write performance is a very low priority.
I would be happy to find a way to improve this though.

There is some code pushed to the throttle-sort (6c340440a24b6b0b309c0ef3554297e758823f7d) branch. If you can test it out, pull it into your master and re-install ponzu by running go install ./... from inside $GOPATH/src/github.com/ponzu-cms/ponzu
On the very first 'load' command, I am seeing a bug that is preventing the SortContent call from being evoked at the right time. Maybe the HTTP calls to github API can finish sooner than the 4-second waitDuration before a  secondary / throttled call to SortContent can happen? will have to test a shorter waitDuration value and see.

I reduced the waitDuration value and it seems to have resolved this issue. I think the loading feature of the gobservatory project is fairly niche so i don't want to over optimize for it, but it would be good to be sure that those HTTP calls are the cause of the bug I caught.

I'm going to close this up for now, since a fix was merged to master. If you get a chance to try it out and successfully replicate the panic you encountered, let me know and I'll dig in.
Thanks for reporting this!

I was been able to test and confirm that with this fix I am no longer getting the panic under high load.
There is a remaining issue with SortContent being not called after the loading completes, submitted #123 to fix.


Fix spurious lost put coordinator acks

Put FSM did not account for the possibility of multiple coordinator forwards, hence failing to acknowledge request originator in such cases.  Multiple forwards are presumably possible under high transfer activity in the cluster, when participating nodes may end up disagreeing on the ring state for a short amount of time.

I did not observed a single instance of lost write after running Jepsen test from #1754 five times in a row with this patch applied.
There was several instances of unexpected forward-ack from riak@<some-node>, expected from riak@<another-node> in logs though, which I introduced in this patch.

It (presumably) did not break anything, given the results of running riak_test groups kv_all and `smoke.
There are 4 failing testcases, most of which due to discrepancies between my test environment (docker container, vanilla Erlang/OTP 17) and test authors' expectations. Details on each of them:

pb_cipher_suites-leveled fails with ciphersuite mismatch,
pb_security-leveled fails with unexpected success in opening a pb connection,
verify_riak_stats-leveled fails to start up nodes with yokozuna enabled, supposedly because there was no usable JRE in a container,
kv679_dataloss_fb2-leveled fails with timeout waiting for 4 nodes to become connected, though looking at test code it seems to me that there was no attempt to bring one of those nodes back to life.

That said I believe the PR is ready for review.

Thanks for all the effort,  I will look at this within the next two days.

riak_test tests need to be run with OTP16 (basho flavour).  I think the test failures are understandable as environment issues - but I'm going to double-check.
eunit tests and eqc tests on riak_kv all pass as expected (eqc tests were checked on merge into develop-3.0 to pick-up 3.0 improvements and fixes).

All riak_test tests have passed in standardised environment with this patch.

Although there exists a Jepsen test to prove this, running Jepsen tests isn't part of the release process - so there exists risk of future regression.
I'm concerned that the effort to re-produce in riak_test of property-based test will be disproportionate to the value gained.
@ThomasArts @martincox any bright ideas on an ongoing test for this to check we don't regress in the future - or are you happy that the one-off validation via Jepsen is sufficient in this case.
I'm leaning towards accepting without further testing, but I might just be being a bit lazy.  A riak_test should be possible, although there might be the need for quite a bit of intercepting, so the riak_test might be inefficient to maintain.


Problem with nested "dumped" documents

When results are retrieved, if it has nested documents, there are some problems because of the addition of \ characters to dict keys (with dumps).
For example, with this document:
{"key_a" : {"key_b": 123}}
get_rows() result is:
{"key_a" : "{"key_b": 123}"}
When accessing on template to 'key_a.key_b' it drives to error because ajax response is:
{"key_a" : "{\"key_b\": 123}"}

thanks for this; unfortunately i wasn't able to duplicate it in Django, it seemed to work ok:
https://agile-headland-18656.herokuapp.com/test1/
here's the code i used to generate that page:
                {% for doc in test_docs %}

                         doc.object2 is {{ doc.object2 }}

                         doc.object2.key_1 is {{ doc.object2.key_1 }}

                         doc.object2.key_1.key_b is {{ doc.object2.key_1.key_b }}

                 {% endfor %}

the code to generate that site is here
https://github.com/pauljolsen/django-and-mongo-datatables

thanks for this, unfortunately i could not replicate the problem.  i'm not sure, but this sounds like an ajax/encoding problem.
have a look at this page.  https://agile-headland-18656.herokuapp.com/col1/
the page source you can see the ajax i used.  the view code is here
https://github.com/pauljolsen/django-and-mongo-datatables/blob/master/mysite/polls/views.py


TaskContext.php response拼写错误， 现在是：repsonse， 正确拼写为 : response

Q
A

Bug report?
yes

Feature request?
no

Swoft version
2.0.7

Swoole version
4.4.13

PHP version
7.2.26

Runtime environment
Ubuntu

Describe the bug
A clear and concise description of what the bug is.
getResponse方法名跟文档不符
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Details

Describe what you are trying to achieve and what goes wrong.

// paste output here

Provide minimal script to reproduce the issue

// paste code

swoft官方文档上写的是 getResponse方法，但是实际代码中方法名 getRepsonse


[FIX] Some times correios webservice don't return some arguments

cc: @renatonlima

Coverage remained the same at 90.769% when pulling 101e9bcc54268cfa3023c9920b1887b049f7707f on mileo:patch-1 into 99f98b08f9a78a11373804bffe618f26f893518d on mstuttgart:develop.


Restructured map.jinja, Added Support for OpenBSD and FreeBSD

Sorry, got a little bit messy with the branches here...
Wanted to add support for a FreeBSD NFS-server and OpenBSD NFS-client
but then had to add OS-specific defaults and thus restructure map.jinja...
Tested on FreeBSD 12-CURRENT (no big difference to 11.0 yet) as server & client
and a OpenBSD 5.9 client. NFSv3 in Free and Open seems pretty similar.
Not yet checked if I broke Linux but I can test tomorrow.

Why not check @thomaslarsen's addition of RedHat while I'm at it?

@0xf10e thanks for your configuration I have incorporated all in #25 to merge other PR's
are you ok with this?

Sure!


Base.ccs doesn't show up

The theme itself doesn't load on discord (AdjustableServerWidth does but that's a different repo), and when going to the base.css URL the file doesn't seem to be present
Screenshot
Discord channel: PTB
OS: Windows
Mod: Betterdiscord
Discord language: English

All my themes got a structure change meaning the base.css file doesn't exist anymore.
All you have to do is just change the end of the url from base.css to dist/[ThemeName].css.
Example with Frosted Glass:

Works like a charm, thanks!


Bowerify

moved some stuff into bower, seems to have resolved the grunt build and grunt serve:dist issues

TODO need to make it so the css can be loaded

i can colors! @jrwdunham this is deployed here http://dativebeta.lingsync.org/#forms-browse so you can look to see if the build is working https://github.com/OpenSourceFieldlinguistics/dative/pull/6

i'm done attempting to paginate the spreadsheet. i give up, short of rre-writing it its not getting pagination before dative is ready, so how about looking at some of my pull requests?

i cherry picked all the relevant commits onto your master so you can accept this pull request. (note since your current master build is failing because of pull #114 then this pr will fail too until you accept #114 and i can include #114 in this pr)

@jrwdunham  the last commit on feb 19 added the id back because i reached the same conclusion :)
i merged your origin back on to this pr so the build can pass. let me know if you want any other changes on this one


Write a section on how we implemented QR-decomposition on the CPU

Modification of the book's algorithm
How we tested QR implementation


Can't open self written GUI apps WSL2 (Ubuntu)

Windows Version
Microsoft Windows [Version 10.0.22621.1635]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 22.04
Other Software
My custom application (arkanoid written in C with SDL2)
Repro Steps
launching game
Expected Behavior
After launching app game interface should be visable, sound should play and after input game should start.
Actual Behavior
After launching app music plays normally but the screen of the app remains black, after input we can hear  sounds (the game actually works, but we cant see the gui).
Diagnostic Logs
this is what launched game looks like:

this is how it should look like:

You'll want to file a bug for wslg https://github.com/microsoft/wslg/issues/new?assignees=&labels=bug&template=bug_report.yml and include more reproduction information.


Remove unnecessary function variants

We should not save the user from the need to compose.
I doubt balanceAndSign* functions provide any value (they are all just balance >>>  sign).
And we should definitely remove these:

balanceTxM = map hush <<< balanceTx
balanceAndSignTxE = try <<< internalBalanceAndSignTx

balanceTxM as well


Serialization to JSON5?

You can already serialize to JSON (which is valid JSON5) with JsonCpp, using the << operator. However, I guess it could be nice to serialize to "better" JSON5 too, with non-quoted identifiers where possible and trailing commas... I'll consider it!

it could be nice to serialize to "better" JSON5 too, with non-quoted identifiers where possible and trailing commas... I'll consider it!

Thanks, that would be great!

and trailing commas

It would be better if JSON5 seialization would be configurable with flags.
Personally I would love omit quotes for identifiers to make resulting .json5 file smaller but contary trailing commas would at to it's size so I was not planning to serialize with them.

I've started implementing this in this branch: https://github.com/mortie/json5cpp/tree/serialize. The API is:
struct Json5::SerializationConfig {
    // Whether or not to add a trailing ',' after the last element
    // of an object/array.
    bool trailingCommas = true;

    // Whether or not to omit quotes in keys when possible.
    bool bareKeys = true;

    // The string used for each level of nesting.
    // Set to 'nullptr' to avoid whitespace completely.
    const char *indent = "\t";
};

void Json5::serialize(
        std::ostream &, const Json::Value &,
        const Json5::SerializationConfig &conf = {}, int depth = 0);

For this input JSON document:
{
	"name": "John Doe",
	"user ID": 99,
	"aliases": [
		"John Smith",
		"Thingum Bob"
	]
}

it will produce the following JSON5 with trailingCommas=true, bareKeys=true, indent="\t" (the defaults):
{
        aliases: [
                "John Smith",
                "Thingum Bob",
        ],
        name: "John Doe",
        "user ID": 99,
}

With trailingCommas=false, bareKeys=true, indent=nullptr, it produces this compact representation:
{aliases:["John Smith","Thingum Bob"],name:"John Doe","user ID":99}

And with trailingCommas=false and bareKeys=false, it produces valid JSON:
{
        "aliases": [
                "John Smith",
                "Thingum Bob"
        ],
        "name": "John Doe",
        "user ID": 99
}

Does that look satisfactory or is there something that should be supported that I've missed?


List of Models in Azure Open AI is not matching with what I can see in SAP Debugger

Hi Gopal,
I am at Installing the SDK --> First Test Run - Azure Open AI step. In the step it asks to compare the list of models present in Azure Open AI Studio with the one seen in the SAP debugger. In my case, the model list isn't matching, what could have gone wrong?
Image from Azure Open AI Studio -

Image from SAP Debugger -

Hi @shreyashagrwl ,
I have to admit, I do not know the exact reason for this. I have observed this as well.
AI SDK for SAP uses REST API to query the list of models from AI Engine endpoint. The list in the debugging session is received from the AI Endpoint, as the available models.
However, when going through the web interface, a subset of this list is what gets presented. I have tried to see if there are any specific parameters that are being filtered in the web interface - but have not figured it out yet.
If/When I do eventually figure it out, I will be sure to put a response here.
Best Regards,
Gopal Nair.


Fix math imports; drop Math

Description of the change
Drops math; updates imports

Checklist:

[x] Added the change to the changelog's "Unreleased" section with a link to this PR and your username
[ ] Linked any existing issues or proposals that this pull request should close
[ ] Updated or added relevant documentation in the README and/or documentation directory
[ ] Added a test for the contribution (if applicable)

Bit of an interesting CI error here.

Huh... Yeah it is. I'll look into it.

The failing test is caused by Nate's changes in purescript-parsing, specifically choice: https://github.com/purescript-contrib/purescript-parsing/commit/f50e8dd01d09d619a837e502b0c82d5d84a82844#diff-d472726f9da7dc968f3c6ef534ba99b06228789ab00a1f2dfe04eebfde42ffc6L445-R445
Changing this line (https://github.com/purescript-contrib/purescript-formatters/blob/main/src/Data/Formatter/Parser/Interval.purs#L32=) to the following makes the test pass again:
- parseInterval duration date = [ startEnd, durationEnd, startDuration, durationOnly ] <#> PC.try #
+ parseInterval duration date = [ startEnd, durationEnd, startDuration, durationOnly ] <#> PC.try # foldl (<|>) empty

Conceptually, the parse is the same. The difference is what the final parser is and how that affects the error message:
-- choice == foldr (<|>) empty
a <|> b <|> c <|> empty

-- choice == foldl (<|>) empty
empty <|> a <|> b <|> c

@natefaubion I believe you modified choice because <|> hadn't yet been made right-associative. Now that it is, should choice be reverted back to foldl (<|>) empty?

I think choice should still be right associative. The fact that choice required you to always step through a useless alternative is crazy.

K, I'll update the error message then.

Can I get an approval?

Sorry, I'm not saying that the current error behavior is OK, I'm just saying that I would like to preserve both. I'll need to think about it.


Free themes website is down

From the main page:
http://mezzanine.jupo.org/
Click on the free themes (http://thecodinghouse.in/themes/) and see the 404.

Here also has invalid link: http://mezzanine.jupo.org/docs/overview.html

#1551

I looked at the diff for #1551 at it seems like a different issue. Are you sure you meant to close this?

It was #1550


Ukrainian, German, Chinese (Simplified) translations added

I also provided support and easy setup for new languages, feel free to customize everything if you need!

I edited a few things in a strings.js file where i put your translations to keep order. Thanks for the translations en README.md files


Diff Editor Component

This PR adds a new component to support the diff functionality provided by Monaco.
The component is a modified version of the one done by @mattmichler and reported in the issue as a gist, with some fixes, which is a copy of the original component.
I will provide an example if needed.

Cool PR, thank you!
Can you update the README as well of how to use the MonacoDiffEditor component please?


Generate index

Docs Build status updates of commit a00475e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/dwight-goins.yml
:white_check_mark:Succeeded

rd/index.yml
:white_check_mark:Succeeded

rd/map.yml
:white_check_mark:Succeeded

rd/media/profiles/dwight-goins.jpg
:white_check_mark:Succeeded

rd/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


IBM-367 CID bridge PB status/upload didn’t survive going past midnight

Coverage remained the same at 99.175% when pulling 62ba3f855fd655f04c0d1e00f08aab8b234bfe78 on bugfix/IBM-367 into 416b0d195dbba25019d5ee43536e051f8419bf4a on master.


applyment_submit

path should end with ‘/’， path = '/v3/applyment4sub/applyment/'， otherwise will return 404.
Also，some field should encrypt too, add logic as follows in applyment_submit function:
if params.get('subject_info').get('identity_info'):
id_card_info = params.get('subject_info').get('identity_info').get('id_card_info')
if id_card_info is not None:
id_card_info['id_card_name'] = self._core.encrypt(id_card_info['id_card_name'])
id_card_info['id_card_number'] = self._core.encrypt(id_card_info['id_card_number'])
cipher_data = True

fixed


 Did I miss anything?

Given that all the errors are at the end of lines, this looks like a CRLF vs LF issue (although I'm a little surprised the symbol is displaying as a unicode replacement character).
Try resaving the file with LR line endings.
Note: We should probably add a .gitattributes file to ensure that new checkout all use the same line endings.


Instances and accounts

I currently am unable to add both instances or accounts, nor launch any through the application.

i fixed instances a while ago, accounts are still bad,ill see soon:tm:


include cheatsheet for formula syntax

the R formula syntax is pretty useless you know how to use it...

Here is the documentation about this https://stat.ethz.ch/R-manual/R-devel/library/stats/html/formula.html


fix forbid implicit cast of array type while load

Proposed changes
Issue Number: close https://github.com/apache/doris/issues/15320
Problem summary
Array type now do not support cast from ARRAY to ARRAY, so we need to forbid it while load, otherwise be may crash.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.22 seconds
load time: 630 seconds
storage size:<PHONE_NUMBER>0 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221223143007_clickbench_pr_68119.html


Support for unified Core+ORM SQLAlchemy query style

Is your feature request related to a problem? Please describe.
With SQLAlchemy 1.4, but Core-style and ORM-style queries can be run the same way:
class MyModel(Base):
    __tablename__ = "model"

    id = Column(Integer, primary_key=True, index=True)
    name = Column(String, nullable=False)

statement = select(MyModel)

result = session.execute(statement)
all_rows = result.all;()

Details in SQLAlchemy documentation
Describe the solution you'd like
statement = select(MyModel)

session = UnifiedAlchemyMagicMock(
    data=[
        (
            [
                mock.call.execute(statement),
            ],
            [
                MyModel(id=1234, name="foo"),
            ]
        )
    ]
)

result = session.execute(stmt)
found = result.one_or_none()

assert found.name == "foo"

Describe alternatives you've considered
In the meantime, I'll be using a normal mock with return values.

Is there any chance of this (or something like it) happening?
With the session.execute(statement) being the preferred ORM method going forward with SQLAlchemy 2.0 and session.query() being marked as legacy it would be nice to convert queries over during SQLAlchemy 2.0 migration, however I am guessing that I won't be able to do this and continue using mock-alchemy unless this issue is addressed?


⚠ ClamAV has degraded performance

In 841144d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 474 ms

Resolved: ClamAV performance has improved in c3e9323 after 17 minutes.


User feedback: Auto-connect...

Auto-connect when on certain wifis.

See also: #63 #27

Both are not that easy to implement reliably because of Battery optimization. The second one also requires the user to grant location permissions and have his location active. Otherwise you can't see the SSID/MAC of nearby/connected wifis.

What kind of battery optimization takes a hit in case#1? I understand location permission is a bit too much to ask for a niche functionality such as this. Thanks for the heads-up.

Unless there is some solution I'm missing you need a permanently active background service listening for changes in connection (the connectivity change broadcast is not received anymore when declared in manifest). To be permanently in the background you need a foreground service and even then you are not guaranteed to be kept alive by the system.
I have this feature for my app dnspipe where I regularly get feedback that it does not work because the background listener has been shut down because of battery optimizations.

Gotcha. Probably a good candidate for tasker integration point for these functionalities then.


Should a Docker file be added for the local testing?

As seen in #327 sometimes a conflict arises between the Python version on the developer's machine and the Python version in the Travis.
Perhaps it would make sense to add a Dockerfile with the Python version from the Travis to enable local testing?

Here is Docker image for this project: https://github.com/sudo-bot/docker-rustpython
And it compiles on mostly all archs: https://github.com/sudo-bot/docker-rustpython/actions/runs/6523882229


Update ReadMe to correctly say which Youtube API is being used

JS API is deprecated and will turn people away. Looking at source you are actually using IFrame API...

:+1:


Build failure: dino

Steps To Reproduce
Steps to reproduce the behavior:

build dino on NixOS unstable

Build log
Goes on & on then fails
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types' may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option '-Wno-incompatible-function-pointer-types

Additional context
Add any other context about the problem here.
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix shell nixpkgs#nix-info --command nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.8, NixOS, 24.05 (Uakari), 24.05.20240502.63c3a29`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.22.0`
 - nixpkgs: `/nix/store/p69bcs7ma6ijj8v9xsrg3nq3nn8ryn95-source`

Add a :+1: reaction to issues you find important.
[^1]
[^1]: Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

Actual error:
/build/source/build/exports/gpgme.vapi:59:23: error: 'struct _gpgme_key' has no member named 'subkeys_length1'
   59 |     public string fpr { get { return subkeys[0].fpr; } }
      |                       ^~
/build/source/plugins/openpgp/src/account_settings_entry.vala: In function 'dino_plugins_open_pgp_account_settings_entry_populate_list_store':
/build/source/plugins/openpgp/src/account_settings_entry.vala:104:30: error: 'struct _gpgme_key' has no member named 'uids_length1'
  104 |             list_store.set(iter, 0, @"$(Markup.escape_text(keys[i].uids[0].uid))\n$(markup_colorize_id(keys[i].fpr, true)) ");
      |                              ^~

Similar, if it is of any help, when I nixos-rebuild switch --flake .# I receive the following:
And the full log:
log.txt
error: builder for '/nix/store/jzzl3hp9a811vl246c6xba7a9js978vy-dino-0.4.3.drv' failed with exit code 1;
       last 10 log lines:
       > [850/870] Generating C source src/plugin.c
       > /build/source/plugins/rtp/src/plugin.vala:119.55-119.72: warning: `string.to_uint64' is deprecated. Use uint64.parse
       >   119 |                     stream.on_ssrc_pad_added((uint32) split[4].to_uint64(), pad);
       >       |                                                       ^~~~~~~~~~~~~~~~~~
       > /build/source/plugins/rtp/src/plugin.vala:258.37-258.47: warning: `null' incompatible with return type `Dino.Plugins.Rtp.Stream'
       >   258 |         if (content_params == null) return null;
       >       |                                     ^~~~~~~~~~~
       > Compilation succeeded - 2 warning(s)
       > [851/870] Generating C source src/device.c
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/jzzl3hp9a811vl246c6xba7a9js978vy-dino-0.4.3.drv'.
error: 1 dependencies of derivation '/nix/store/39z6pd695jmjabanlg473snywwx5v2jj-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/07xz1xscq27d1nb2q386nn371qmc6592-home-manager-generation.drv' failed to build
error: 1 dependencies of derivation '/nix/store/kp7ipcmw2grnms0vsmwpq8qi2ihwdxgg-user-environment.drv' failed to build
error: 1 dependencies of derivation '/nix/store/h5mv5fiz84frz11zxps7qcvv2v4dw3jz-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/xhmga1xapv9ffypkfsy7fr695vbi6hp4-nixos-system-tyr-24.05.20240503.e9be424.drv' failed to build

nix-shell -p nix-info --run "nix-info -m"
these 6 paths will be fetched (0.75 MiB download, 10.20 MiB unpacked):
  /nix/store/f3ylr5a5w2cla15j2w66n435vwx65xmq-file-5.45
  /nix/store/014nnwb227s2f6zax4nd4v40rjp66582-gnu-config-2023-09-19
  /nix/store/fx2yaklnv3h6jx0p07h1bh4vy618pn9s-gnumake-4.4.1
  /nix/store/ig23ki6sl8dlg3lp0k1l9y9x05wrqs4q-patchelf-0.15.0
  /nix/store/9wnvhjyxjykwn5y06xc9a2h8rs5fbfia-stdenv-linux
  /nix/store/9ckkgn9dakszzcbhxxspjmpwmkp21801-update-autotools-gnu-config-scripts-hook
copying path '/nix/store/014nnwb227s2f6zax4nd4v40rjp66582-gnu-config-2023-09-19' from 'https://cache.nixos.org'...
copying path '/nix/store/f3ylr5a5w2cla15j2w66n435vwx65xmq-file-5.45' from 'https://cache.nixos.org'...
copying path '/nix/store/ig23ki6sl8dlg3lp0k1l9y9x05wrqs4q-patchelf-0.15.0' from 'https://cache.nixos.org'...
copying path '/nix/store/fx2yaklnv3h6jx0p07h1bh4vy618pn9s-gnumake-4.4.1' from 'https://cache.nixos.org'...
copying path '/nix/store/9ckkgn9dakszzcbhxxspjmpwmkp21801-update-autotools-gnu-config-scripts-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/9wnvhjyxjykwn5y06xc9a2h8rs5fbfia-stdenv-linux' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.6-zen1, NixOS, 24.05 (Uakari), 24.05.20240425.7bb2ccd`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `""`
 - channels(leeuwarden): `""`
 - nixpkgs: `/nix/store/370qy3d3wg9zhbn5a3dcv6k1q1iigfh4-source`

Fixed in #309265


JavaInfo.java: accept osArch i386

We face this error on linux x86:
...
System.getProperty('java.vm.name')=OpenJDK Server VM

System.getProperty('java.vendor')=Red Hat, Inc.

System.getProperty('os.name')=Linux

System.getProperty('os.arch')=i386

System.getProperty('java.fullversion')=null

Cannot determine System.getProperty('os.arch')=i386

make: *** [envDetect] Error 1
...

JavaInfo.java should accept i386 of os.arch system property. Seems like value of os.arch can be x86 or i386 on intel 32-bit, depending on platform. (See also code in Platform test class.)

Please provide Grinder link

x86-32_windows: OK
x86-64_linux: OK
Unfortunately, I cannot test linux x86 in grinder, as such Temurin build does not seem available. But I have tested this change locally and it fixed the issue.

Can we please proceed with this? It is blocking all 32bit testing of ours.

@smlambert  @sophia-guo  please?


Add support for project users

Motivation
We have added new endpoints to the Management API for project users and we would like it to be covered in the SDK.
(!) Going to be released in the first half of January 22.
Proposed solution
The SDK should include the functionality of the new endpoints for users:

invite user into a project
change user roles

Additional context
See Docs preview for more detailed info.
The endpoints that were added:

POST /{project_id}/users

invites a user into the project
sample request body:

{
<EMAIL_ADDRESS>  "collection_groups":[
    {
      "collections":[
        {
          "id":"00000000-0000-0000-0000-000000000000"
        },
        {
          "codename":"collection-1"
        }
      ],
      "roles":[
        {
          "id":"f58733b9-520b-406b-9d45-eb15a2baee96",
          "languages":[
            {
              "codename":"english"
            }
          ]
        }
      ]
    }
  ]
}

sample response:

{
 "user_id":"d94bc87a-c066-48a1-a910-4f991ccc1fb5",
 "collection_groups":[
   {
     "collections":[
       {
         "id":"00000000-0000-0000-0000-000000000000"
       },
       {
         "id":"28b68213-d636-4b01-9fd1-988b93789e17"
       }
     ],
     "roles":[
       {
         "id":"f58733b9-520b-406b-9d45-eb15a2baee96",
         "languages":[
           {
             "id":"7df9a691-cf29-402d-9598-66273e7561b7"
           }
         ]
       }
     ]
   }
 ]
}

PUT /{project_id}/users/{user_identifier}/roles

changes the users' roles and assignment to collections and languages i current project
sample request body:

{
  "collection_groups":[
    {
      "collections":[
        {
          "id":"00000000-0000-0000-0000-000000000000"
        },
        {
          "codename":"collection-1"
        }
      ],
      "roles":[
        {
          "id":"f58733b9-520b-406b-9d45-eb15a2baee96",
          "languages":[
            {
              "codename":"english"
            }
          ]
        }
      ]
    }
  ]
}

sample response:

{
 "user_id":"d94bc87a-c066-48a1-a910-4f991ccc1fb5",
 "collection_groups":[
   {
     "collections":[
       {
         "id":"00000000-0000-0000-0000-000000000000"
       },
       {
         "id":"28b68213-d636-4b01-9fd1-988b93789e17"
       }
     ],
     "roles":[
       {
         "id":"f58733b9-520b-406b-9d45-eb15a2baee96",
         "languages":[
           {
             "id":"7df9a691-cf29-402d-9598-66273e7561b7"
           }
         ]
       }
     ]
   }
 ]
}

Released on 2022-01-12

We need to cover new endpoints as well as update code samples in docs.


Upgrade parent and remove unused files

Do the tests work with the new parent as I know the versions and other things changed?

They did pass on my local Minishift. After a merge tests should be executed here http://rourka-obsidian-ci.app.alrubinger.com


Don't concatenate paths in --proto_path

protoc's --proto_path argument is expected to be provided multiple times if multiple directories are to be considered. Concatenating with : is invalid on some systems (Windows):
> protoc --help
  -IPATH, --proto_path=PATH   Specify the directory in which to search for
                              imports.  May be specified multiple times;
                              directories will be searched in order.  If not
                              given, the current working directory is used.
                              If not found in any of the these directories,
                              the --descriptor_set_in descriptors will be
                              checked for required proto file.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@EpsilonPrime thank you for the review; looks like CI is back in the green now.


Beautify leaves huge gaps with .onSave option on.

After the latest update that requires the "editor.formatOnSave": true , vs code leaves huge gaps within my code and it does so at random saves. Any other configuration tips that I need to be aware of? This was not an issue before the update.

Problem is only present if editor.formatOnSave is active, but then the beautifying doesn't work.

I'm going to assume you're on a windows machine and your line endings (when editing the files you show) are set to LF in the editor. If you have a .jsbeautifyrc file, add "eol": "\n", if not, add "files.eol": "\n" to your VS Code settings.
This is a known issue, but there is a fix coming in the 1.8.0 release of VS Code.

I've release 0.6.1 to hopefully return the previous functionality. Let me know how that goes.

Just updated to 0.6.1, nothing has changed.

Hey @sqnkov, I don't have a PC with me ATM, to improve the speed of resolution, can you please provide the following files/details:
Any format setting files [.jsbeautifyrc, .editorconfig, .vscode/settings.json (or your global settings file if you're not using a workspace settings file)]
What the editor is showing as the end of line setting (LF or CRLF) which will be on the status bar at the bottom left of the window.

Have released 0.6.2. Again, this should fix it. Let me know how you go.

Hello, 0.6.2 can work!
But,if i set "editor.formatOnSave": true it showing this:

Incorrect type. Expected one of array
Use array to set indiviaul types to beautify: ["js", "html", "css"]. Requires "editor.formatOnSave" to be true.

Just change "editor.formatOnSave": true to "beautify.onSave": ["js", "html", "css"] ,and it will works!

Just updated to 0.6.2 , beautify on save is not working.
These are my only settings:

@sqnkov, you need to put "editor.formatOnSave": true back into your settings. "beautify.onSave" is out again. (As it was in 0.6.0) Sorry for the mess around.

Duplicate of #58.

@HookyQR , all good now. I was looking up Your initial advice, sorry for that.

No problem, I'm here to help.


adds hashpassword flag

This pull request adds a hashpassword string flag, which will return the hashed representation of a password.
I forgot a password to one of my domains recently, and there was no way to recover it. With this flag, I'll at least be able to generate a hash, and manually set it in the database to recover the domain.

I figured you can just set the password on another domain, then use the same hash to update the table manually. No need for this feature.


allas checks and updates

Proposed changes
Updates to Allas documentation.
Checklist before requesting a review

[ ] I have followed the instructions in the Contributing and Styleguide documents.
[ ] My pull request passes the automated tests. If not, visit pull requests at Travis CI and have a look at the job log.
[ ] I have included a link to the appropriate preview page (select your branch from the list).

Is --mode S3 now preferred over --mode s3cmd?

Is --mode S3 now preferred over --mode s3cmd?

s3cmd, s3 and S3 all do the same thing. I think --mode S3 is most intuitive.


[arrayreconcile] added extra check to arrayreconciler

Pull Request Test Coverage Report for Build 505

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 503:
0.0%

Covered Lines:
526

Relevant Lines:
526

💛  - Coveralls


app router & pages router at the same time?

I made app dir & pages dir work individually by following the guide. However my application contains both dir. Is it possible we do both?
If I have nextConfig.i18n & middleware.ts at the same time -> "Too many redirects"
If I have only middleware.ts -> Does not work for pages dir.

I think you should be able to restrict the middleware to only your app router pages, using the matcher config.

Thanks you! Though I have almost abandoned app router, I think you are leading me to a right direction.


libdisplay-info(0.2.0-1) out and breaks dependency by hyprland

Regression?
Yes
System Info and Version
 System/Version info
$ hyprctl systeminfo

Hyprland, built from branch  at commit 9e781040d9067c2711ec2e9f5b47b76ef70762b3  (props: bump version to 0.41.1).
Date: Thu Jun 13 09:54:06 2024
Tag: v0.41.1, commits: 4818

flags: (if any)

System Information:
System name: Linux
Node name: earth
Release: 6.9.5-arch1-1
Version: #1 SMP PREEMPT_DYNAMIC Sun, 16 Jun 2024 19:06:37 +0000

GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation TigerLake-LP GT2 [Iris Xe Graphics] [8086:9a49] (rev 01) (prog-if 00 [VGA controller])

os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

plugins:

Description
Wanted to update the system with pacman or yay. Not possible cause of
[130] $ pacupg                                                                                ✘
:: Synchronizing package databases...
 core is up to date
 extra is up to date
:: Starting full system upgrade...
resolving dependencies...
looking for conflicting packages...
error: failed to prepare transaction (could not satisfy dependencies)
:: installing libdisplay-info (0.2.0-1) breaks dependency 'libdisplay-info.so=1-64' required by hyprland

How to reproduce
Try to update arch with pacupg or sudo pacman -Syu
Crash reports, logs, images, videos
No response

wlroots and hyprland did a quickfix.
0.41.1-2 available. thanks!

Hey, I'm still having this issue. I'm on arch with the -git package and have used paru -S hyprland-git to make sure I'm on the latest commit, but I still get this when updating. I've tried installing the regular hyprland package, but then wlroots complains about not having the latest version of libdisplay-info. Is this something I should message the aur package maintainer about?

I performed a system update and still have issues:
Hyprland: error while loading shared libraries: libdisplay-info.so.1: cannot open shared object file: No such file or directory
I have wlroots 0.17.3-2 and hyprland 0.41.1-2 installed via pacman.

I just uninstalled hyprland, updated libdisplay-info, then reinstalled hyprland. Works.


Added NUI code extracted from Terasology (relates to Terasology#3819)

Description
This pull request contains code extracted from the org.terasology.rendering.nui package in the Terasology codebase. It also contains some of the input classes taken from the org.terasology.input package, which are used within the NUI code. All references to the package org.terasology.rendering.nui have been changed to org.terasology.nui.
Overview of API changes

Changed package from org.terasology.rendering.nui to org.terasology.nui
Font has been changed from an asset class to an interface
Texture has been removed and TextureRegion has been re-named to UITextureRegion
The drawMesh and drawMaterial methods have been removed from the Canvas interface. Replacements for these methods can be found in the org.terasology.rendering.nui.CanvasUtility class.
Any input events used in NUI from the org.terasology.input.events package have been replaced with ones from the org.terasology.nui.events package.
All of the dependent classes are currently included within the nui package for testing purposes (many of them need to be moved to TeraMath and other related repositories)
Most of the CoreRegistry or Assets usages have been replaced with constructor parameters, however there may be some instances where no replacement has been made
The UIFormat, UIDeltaFormat and UISkinFormat are JSON de-serialisers, which are implementation specific classes. Porting them would imply that a JSON-based format would need to be used for UI files. They are instances of AbstractAssetFileFormat, which is used by gestalt to separate asset implementation from asset data. These have been left in the Terasology codebase and not ported to NUI.
Translator is present as an abstraction over Terasology's TranslationSystem, which is used for translating strings. With this, the built-in NUI widgets can retain internationalisation support.

Package Structure

Package
Description

org.terasology.nui (nui)
Contains the portable core code for NUI

org.terasology.input (nui-input)
Contains input code extracted from Terasology that is used by NUI

org.terasology.reflection (nui-reflect)
Contains reflection utilities extracted from Terasoloy for use in NUI (used in org.terasology.nui.properties.PropertyProvider)

Duplicated classes
The following classes currently exist in both Terasology and NUI:

Classes within the org.terasology.input namespace.

Notes

This depends on https://github.com/MovingBlocks/TeraMath/pull/63.
This relates to MovingBlocks/Terasology#3819

@BenjaminAmos this PR looks really nice. Will try to take some time to look at it in detail over the next days.
One thing to ask afront: could you double check whether there have been changes to NUI in the engine repo since January 16 that are not included here?
I need to catch up on some of the terms and technical details, though. Would be nice if you could be available on Discord and be ready to answer some of my questions 😅

All of the dependent classes are currently included within the nui package for testing purposes (many of them need to be moved to TeraMath and other related repositories)

Should they be moved to TeraMath or directly be ported to use JOML?

Based on the changelog here, the only commit that should have affected NUI (instead of Terasology's code using NUI) is https://github.com/MovingBlocks/Terasology/commit/cfe8cec22a4080ad88869f70139cd833c01e7e35#diff-9f2e133f53dd756f34e7a8ddf80ec8e3.
I've re-based the Terasology code changes locally without any major conflicts, however the incorporation of JOML code over TeraMath has caused some issues. Terasology's Font class no longer compiles when the changes are added, as it now uses JOML's Vector2i class instead of TeraMath's. I could port NUI to use JOML as well, although I don't have any preference here. My port doesn't preserve the git history from the Terasology repository, as I hadn't really considered that at the time. It was mostly a job of copying files and modifying them until they compiled. I then tried to fix bugs when I found them.
The extracted NUI code is currently running with two seperate lines of development: gestalt 5 (this pull request) and gestalt 7. I'd experimented with adding NUI into Destination Sol (changes here), which uses gestalt 7, rather than Terasology's gestalt 5 and so ported NUI to use it as well (using gestalt 7 in Terasology is possible however it requires quite a few engine changes to work due to large interim gestalt API changes involved). The code is in a seperate branch though, which appears to be getting slightly more bugfixes than the gestalt 5 one. I can try to backport some of those fixes though. It's been a couple of months since I've touched this code, although I am not aware of any extremely serious TODOs in the code that I need to fix. The code has incorporated the LibGDX back-end I wrote for NUI though, so either I will have to find a way to remove it from the git history or it will have to live in the TeraNUI repository as well. Do you mind if I leave it in there?
From memory though, NUI depended on certain elements of Terasology's codebase that were slightly less generic. The org.terasology.input package is used slightly by NUI, as well as the org.terasology.math.Border class. The border class was provisionally to be moved to TeraMath (see https://github.com/MovingBlocks/TeraMath/pull/63), however it can be moved back-into NUI's codebase directly instead. So far as I know, the class does not belong in JOML (https://github.com/MovingBlocks/Terasology/pull/3819#issuecomment-570580455), so I was not planning to submit it there. I think that I analysed the dependencies in more detail at https://github.com/MovingBlocks/Terasology/issues/2307#issuecomment-573408627. I need to update the information provided slightly though to describe the new package included with NUI for now (nui-libgdx).

Thanks for the detailed explanation 💚

The code has incorporated the LibGDX back-end I wrote for NUI though, so either I will have to find a way to remove it from the git history or it will have to live in the TeraNUI repository as well. Do you mind if I leave it in there?

Doesn't sound too worrysome for me - and our git history is not really nice to look at anyways, so I wouldn't worry too much about it.

The border class was provisionally to be moved to TeraMath (see MovingBlocks/TeraMath#63), however it can be moved back-into NUI's codebase directly instead.

I don't understand the details good enough to have a preference here. If the border would be used somewhere else, too, it might be better off in TeraMath. If it is only used for NUI include it here.

Gradle notes:

I've just found out it helps for each subproject to have its project.group set. Each of them has a groupId set in their publication configuration, but apparently gradle composite builds don't look that deeply when deciding what dependencies the included build provides.

You can do that in each subproject's build.gradle or in an allprojects section of the root build.gradle, but it looks like this branch has chosen to do away with using allprojects.

In order to work as a Terasology dependency, each of the java subprojects will need a

    targetCompatibility(JavaVersion.VERSION_1_8)

in their java { } configuration. Otherwise I guess it defaults to whatever jdk you happen to be on at the time, which doesn't convince the terasology build that it will work for jdk 8.
Those seem to be the critical bits. One other bit of tidying is the SourceSet configuration:
sourceSets {
    main {
        java
    }
}

It's not clear if this does anything? By applying the java-library plugin to the project, I think it already sets up a main source set that compiles java sources by default.

I'm not familiar with composite builds, so I wasn't aware of those things being needed. Source and target compatibility information has been added, alongside removing the sourceSets. As I haven't used composite builds sucessfully before, I can't test if it works but I've added the groups as you asked and hopefully that will work.

Terasology uses joml 1.9.25 now, and there were breaking changes between 1.9.24 and 1.9.25: https://github.com/JOML-CI/JOML/releases/tag/1.9.25 :disappointed:
In addition, this means we need to add strict version requirements wherever we define a joml dependency in gradle, because we can't let gradle assume that it's okay to satisfy a requirement for 1.9.24 with a 1.9.25 version.

Actually, on second thought, I think I fixed @keturn's concern by accident already. The group is set in the new common.gradle for each project, which is then the default value used for the published groupId the setting of which I then deleted since it isn't needed anymore.


Article: Comprehensive Understanding of Unsafe Rust

New article from @ZhangHanDong.

Hi, I really appreciated this article.  It was really helpful to understand unsafe.  The article is a bit longer than some others but I think it could possibly be split into two articles with one about Zig starting at the Hot topic discussion section? It might be worth considering. There was just a couple of repeats of previous comments in line 43 and 52.

Hi, I really appreciated this article. It was really helpful to understand unsafe. The article is a bit longer than some others but I think it could possibly be split into two articles with one about Zig starting at the Hot topic discussion section? It might be worth considering. There was just a couple of repeats of previous comments in line 43 and 52.

Good point. I agree with splitting it into two articles. What do you think? @ZhangHanDong


URL with url encoded characters breaks nginx proxy routing

I.e. when renaming a folder in the JLab file manager (PATCH request).

Fixed in #217b5e0


Use cftime for temporal averaging operations

Description
This is an attempted fix for #301. The PR uses cftime.datetime objects in the _convert_df_to_dt function (instead of datetime / cfdatetime objects depending on the dataset attributes).

Closes #301

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

If applicable:

[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass with my changes (locally and CI/CD build)
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

Codecov Report

Merging #302 (0d1352c) into main (87790f8) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #302   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           14        14
  Lines         1169      1166    -3
=========================================
- Hits          1169      1166    -3

Impacted Files
Coverage Δ

xcdat/temporal.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks for this PR. I already started taking a look, but will be able to review more closely next week.
We should have this merged before #300.

@tomvothecoder - I had a couple minor questions, but this looks good to me.

This PR should be ready to merge if you are satisfied with it.
I will continue work with #308 and #285.

Thanks for the help and getting this done so quickly.


Refactor: merge BuildRainer to RTScanner

@monperrus Hi Martin :) , here is the refactor . The issue is as mentioned in the mail I seems to can't make local changes to repairnator-config to apply on RTScanner. So This PR miss the JSAP config step to choose between RTScanner or BuildRainer. Also The BuildRainer test can't be integrated yet due to this.
Functionality-wise the merged BuildRainer is working well as I have double checked.

Thanks. Could you also add the test files?

@monperrus  It is done :) .

Thanks a lot!


No request in progress

I'm seeing this error pop up in my logs intermittently, always with this jbuilder template:
json.array! @projects, partial: 'project', as: :project, cached: ->(project) { [project.location, project] }

Recently, this template was changed, and the error started after changing cached: true to what it is above.
Abbreviated stacktrace:
vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/protocol/connection_manager.rb:107:in `confirm_in_progress!': [Dalli] No request in progress. This may be a bug in Dalli. (ActionView::Template::Error)
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/protocol/base.rb:179:in `verify_pipelined_state'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/protocol/base.rb:75:in `pipeline_response_setup'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:81:in `finish_query_for_server'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:66:in `block in finish_queries'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:62:in `each'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:62:in `finish_queries'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:35:in `setup_requests'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:20:in `block in process'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/ring.rb:78:in `lock'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/pipelined_getter.rb:19:in `process'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/client.rb:108:in `block in get_multi'
    from vendor/bundle/ruby/3.0.0/gems/dalli-3.2.5/lib/dalli/client.rb:107:in `get_multi'
    from vendor/bundle/ruby/3.0.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/cache/mem_cache_store.rb:165:in `block in read_multi_entries'

I am getting the same error quite a few times.
Did you happen to find any resolution yet?

Getting no response and not knowing how to debug this library myself, I resolved by switching from memcached to redis for our cache store and not using this library any longer 🤷


Running ORTModule with other EPs from ORT

I am building a new wheel with the OneDNN EP using Onnx runtime training. After that is installed, I install torch_ort and then run the configure, but it does not seem to work ( I get the same error asking me to run the configure again). From the instructions, I see that there is no recipe for this combination. Is this possible or is there any other way for me to build a custom wheel and use it to train bert model with OneDNN and ORT?

Hi @chethanpk, can you please post the output of the configure step?

C:\Users\WOS>python -m torch_ort.configure
running build
running build_ext
C:\Python37\lib\site-packages\torch\utils\cpp_extension.py:305: UserWarning: Error checking compiler version for cl: [WinError 2] The system cannot find the file specified
warnings.warn(f'Error checking compiler version for {compiler}: {error}')
building 'aten_op_executor' extension
Emitting ninja build file C:\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\build\temp.win-amd64-3.7\Release\build.ninja...
Compiling objects...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
ninja: no work to do.
C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\bin\HostX86\x64\link.exe /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\Python37\lib\site-packages\torch\lib /LIBPATH:C:\Python37\libs /LIBPATH:C:\Python37\PCbuild\amd64 "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\ATLMFC\lib\x64" "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64" c10.lib torch.lib torch_cpu.lib torch_python.lib /EXPORT:PyInit_aten_op_executor C:\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\build\temp.win-amd64-3.7\Release\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\aten_op_executor\aten_op_executor.obj /OUT:build\lib.win-amd64-3.7\aten_op_executor.cp37-win_amd64.pyd /IMPLIB:C:\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\build\temp.win-amd64-3.7\Release\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\aten_op_executor\aten_op_executor.cp37-win_amd64.lib
Creating library C:\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\build\temp.win-amd64-3.7\Release\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\aten_op_executor\aten_op_executor.cp37-win_amd64.lib and object C:\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\build\temp.win-amd64-3.7\Release\Python37\lib\site-packages\onnxruntime\training\ortmodule\torch_cpp_extensions\aten_op_executor\aten_op_executor.cp37-win_amd64.exp
Generating code
Finished generating code

Hi @natke, did you get a chance to take a look at this?

Hi @chethanpk we currently do not have support for running torch_ort.configure on a Windows machine. Have you given this a try on a linux machine?

@baijumeswani  will try it on linux and let you know.

@baijumeswani I tried it on linux and I was able to complete the training and it did not error out at ORTModule. However it is not using the OneDNN EP. It was using the default CPU EP.
Is there any way this has to be configured to use OneDNN EP?
The OnnxRuntime installation was done using the wheel I build with OneDNN enabled.

Thanks @chethanpk for reporting this. On further looking, it would appear that we currently have support for cuda and rocm execution providers through ORTModule. I will ask internally to see if/how we can support this.
https://github.com/microsoft/onnxruntime/blob/master/orttraining/orttraining/python/training/ortmodule/_graph_execution_manager.py#L248-L250

Just a minor update: supporting other EPs in ORTModules is on our to-do list but we don't have a deadline for it.

Hi @chethanpk, I'm the PM for this package. Can you reach out to me at<EMAIL_ADDRESS>and we can have a conversation about your use case


build: Don't auto opt-in to ccache.

Some distros like fedora auto-opt-in to ccache already if installed by putting
symlinks in $PATH (so clang points to /usr/lib64/ccache/clang).
This uses the same approach as mozjs and others to avoid calling ccache
recursively.

This change is

r? @jdm

@bors-servo r+

:pushpin: Commit 3a05413 has been approved by jdm

:hourglass: Testing commit 3a054130e98e9ba6d1b99905125bd70f1559dcd7 with merge b35fbd82a8828fbeb9574fc04f009d249dc02d8b...

:sunny: Test successful - checks-travis
Approved by: jdm
Pushing b35fbd82a8828fbeb9574fc04f009d249dc02d8b to master...


Some formatting niceties

This includes some small things of #3720 not included in #3722.

We use cleanGit to only copy the git-tracked files to the nix store. Previously, the entire local development directory would be copied (easily >1GB). This subsumes #3669.
We reuse the scripts in scripts/ci such that people can easily run stylish-haskell in the same way as it is checked in CI.
This sets export LC_ALL=C.UTF-8 for the consensus stylish-haskell check, which hopefully fixes errors like https://hydra.iohk.io/build/14684287/nixlog/1

bors merge


Skip Actions

[ ] Skip ActionCable
[ ] Skip Action Mailer
[ ] Skip Action Mailbox
[ ] Skip Active Storage
[ ] Skip Action Text
[ ] Skip Bootsnap
[ ] Skip JBuilder
[ ] Skip Javascript
[ ] Skip Spring
[ ] Skip Sprockets
[ ] Skip System Tests
[ ] Skip Turbolinks
[ ] Skip Webpack Install
[ ] Skip Webpack

Webpack / Hotwire Selection


Consume type index to return list of available resource types

Closes #619

Codecov Report

Merging #629 into master will increase coverage by 0.03%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   95.14%   95.18%   +0.03%
==========================================
  Files         506      239     -267
  Lines       18907     9233    -9674
==========================================
- Hits        17989     8788    -9201
+ Misses        918      445     -473

Flag
Coverage Δ

#dotnet
95.18% <96.96%> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...Tests/TypeSystem/Az/AzResourceTypeProviderTests.cs
95.55% <88.88%> (+1.43%)
:arrow_up:

.../Bicep.Core/TypeSystem/Az/AzResourceTypeFactory.cs
96.77% <100.00%> (-0.29%)
:arrow_down:

...Bicep.Core/TypeSystem/Az/AzResourceTypeProvider.cs
100.00% <100.00%> (ø)

src/Bicep.Core/TypeSystem/TypeValidator.cs
95.23% <0.00%> (-0.04%)
:arrow_down:

src/Bicep.Core/Parser/Parser.cs
94.73% <0.00%> (-0.02%)
:arrow_down:

src/Bicep.Cli.UnitTests/PathHelperTests.cs
100.00% <0.00%> (ø)

.../src/Bicep.Core/Extensions/DictionaryExtensions.cs

...SerializedTypes/Serialization/TypeBaseConverter.cs

...ationTests/Extensions/CompilationTestExtensions.cs

.../src/Bicep.Core/SemanticModel/SymbolResultCache.cs

... and 263 more


Added better install method in readme

This is probably the install method most people want

Thanks for the pull request!


Visual Studio Tools for Apache Cordova

Hello.
I'm trying to integrate your plugin into my VS/TAC-based application.
And the main problem is, that ios project is recreated on every build action.
I wonder, is there any way to automate(by using hook (after_platform_add or before_plugin_add) for example) the following action:
"XCode
File > New > Target > Apple Watch: Language ObjC, Select Glance and Notifications > Finish > Activate"
I will be very appreciated for any suggestions.

Hi,
That's among the things our hooks in the AppBuilder branch do. Although your requirement is largely the same you'll probably need to tweak them for VS.


Fix replace hc timer with thread

FTI-5847

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 10 committers have signed the CLA.:white_check_mark: onematchfox:white_check_mark: mayocream:white_check_mark: kayano:white_check_mark: chronolaw:white_check_mark: ADD-SP:white_check_mark: oowl:white_check_mark: flrgh:x: Murillo Paula:x: HansK-p:x: windmgcMurillo Paula seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 10 committers have signed the CLA.:white_check_mark: onematchfox:white_check_mark: mayocream:white_check_mark: kayano:white_check_mark: chronolaw:white_check_mark: oowl:white_check_mark: ADD-SP:white_check_mark: flrgh:x: Murillo Paula:x: HansK-p:x: windmgcMurillo Paula seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@oowl @locao - Could you please help check if this is a meaningful change to you? will make a change against master if it does
(Although I found it seems meaningless to write test for it)

iirc there is a limit of 100 threads per request-context. Do we risk hitting that in large installations?

@Tieske Hmm I haven't heard of such a limitation, timers are also relying on light threads so they should somehow be similar.
Which limitation are you referring to? Maybe this https://github.com/openresty/lua-nginx-module?tab=readme-ov-file#lua_worker_thread_vm_pool_size?

not sure it's that one, since it refers to VMs. Anyway I cannot reproduce it, so seems the limitation is no longer present.

Close in favor of #156


Sage10 infinite loop with bbPress and inheritance of templates

[x] I've read the guidelines for Contributing to Roots Projects
[x] This request isn't a duplicate of an existing issue
[x] I've read the docs and followed them (if applicable)
[x] This is not a personal support request that should be posted on the Roots Discourse community

Description
This is a bug with one of the Auttomatic's main plugins bbPress (https://bbpress.org/). When using Sage10 the site pages for the bbPress forums end up in an infinite loop.
I believe this is an issue with other plugins that I have yet to test. If it's not planned to support the default way these plugins have functioned so far, what would be the steps to be able to inherit their templates while using Sage10?
Steps to reproduce

Install Sage10
Install bbPress
Craete a 'test' forum
Click 'view' for the test forum

Expected behavior:
bbPress templates should render the bbPress content or a white page should show up when overwriting the bbPress template in resources/bbpress/bbpress.php.
Actual behavior:
Infinite loop on the page until PHP times out.
Reproduces how often:
100%
Versions

Sage 10.0.0-beta.1
WordPress 5.4.2
Nginx via Valet
macOS Mojave

Additional information

similar to woocommerce (see sage-woocommerce package examples: https://github.com/ptrckvzn/sage-woocommerce/tree/sage-10, https://github.com/ouun/stage-woocommerce), bbpress support in sage 10 will need to be a separate extension

Please see the above packages and/or open a thread on Discourse. This is not something that can be fixed in Sage core right now.


Update Evaluation Procedures

TODO

[ ] change validation code to support multiple data loaders since  validation can happen on different kinds of data
[ ] make evaluation on test set more sophisticated

Made this a sub-task of this issue


Upgrade Github runner to v2.315.0 before 2024-04-25

The new runner version has been released: https://github.com/actions/runner/releases/tag/v2.315.0
Past issue: #16657

Rolled out to canary

Rolled out to prod


Bump deCONZ to 2.05.75

This will bump deCONZ to latest version. For more information about what has changed, see the release notes .

I'm closing this, since this is a duplicate of #208


Adding jaw line facial landmarks

Would you be able to explain how you went and generated the facial landmark / density tree files that are used in the implementation of the Fast Localization of Facial Landmark Points? I would be keen to contribute, or ask if you can, the jaw line to the list of supported facial landmarks

I see the following in the paper:

The learning of the whole
estimation structure for a single landmark point takes around
one day on a modern desktop computer with 4 cores and 16
GB of memory.

I didn't generated myself, I've used the density tree files accompanied with the paper. In order to use jaw line, these facial landmark points needs to be trained which currently they are not.


feat: handle named imports of builtin modules

Description
Fix https://github.com/vitejs/vite/issues/3736
Fix https://github.com/vitejs/vite/issues/8203
Ref https://github.com/vitejs/vite/issues/3715#issuecomment-1132507686 (fix no1)
Handle import { join } from 'path' in deps and source code. (named imports)
In deps, wrap proxy with Object.create to workaround esbuild ES interop code.
In source code, transform the import to import pkg from 'path'; const { join } = pkg; (es interop)
Additional context

If dep does const { join } = require('path'), it would error immediately as join triggers the Proxy get trap on destructure. (ES import don't have this issue due to compiled esbuild code)
In builds, named imports in source code are not handled as it incurs perf overhead
In builds, named imports in deps are not handled, but can be supported with https://github.com/vitejs/vite/pull/8280

Thanks @swandir for initial inspiration for the Proxy trick. Though it has evolved a lot since then.

What is the purpose of this pull request?

[ ] Bug fix
[x] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Nice! It should fix build time errors observed when running with Yarn PnP too. I'll update #6493 once this one is merged.

Looks like some of the latest changes in main are affecting the PR now

Tests should be good now. Thanks for making the updates while I was away!


Astronomy and Formsy

Is there a way to have something similar to Autoform, with Astronomy for React?
@ochicf and myself are planning on building something to make the form generation easier for those using React and Meteor. We are planning on doing some sort of integration between Astronomy and Formsy. Any recommendation?

For now there is no tool  for Astronomy that would much Autoform. However, if you want to use forms (no autogeneration) I recommend useful:forms. It would be great to have such tool but I will probably have no time to create one. So, if you want to make one, feel free and I can help in some aspects. What I think would be best is not focusing on one UI framework like React, and make it more generic. I mean, user just define what control/widget to render for each field. And user is responsible for providing template for such field.


Allow configuration changes on kubelet settings

As a customer i would like to be able to alter configuration of kubelet settings such as --container-log-max-size that will be rolled automatically on the nodes of the workload cluster.

This should be a feature of all of our clusters. Moving to Turtles.

As this does not really fit to our product value to simplify things, we will not do it for now, so closing it.


[FLAVA] Add checkpoint test

Summary:
Unification may alter the architecture of some of the models in the codebase. A model checkpoint loading tests is necessary as a quick sanity check for any major layer changes. This PR adds such a test for FLAVA. It is placed in examples/ to act as an optional test.
Test plan:
pytest examples/flava/test/test_flava_checkpoint.py -vv
platform linux -- Python 3.9.12, pytest-7.1.1, pluggy-1.0.0 -- /fsx/users/rafiayub/conda/envs/torchmm/bin/python
cachedir: .pytest_cache
rootdir: /data/home/rafiayub/torchmultimodal, configfile: pyproject.toml
plugins: cov-3.0.0, mock-3.8.2
collected 2 items

examples/flava/test/test_flava_checkpoint.py::TestFLAVACheckpoint::test_flava_model_for_classification PASSED                                                                                [ 50%]
examples/flava/test/test_flava_checkpoint.py::TestFLAVACheckpoint::test_flava_model_for_pretraining PASSED

Codecov Report

Merging #161 (6153b72) into main (d9fc29a) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   92.37%   92.74%   +0.36%
==========================================
  Files          46       46
  Lines        2847     2838       -9
==========================================
+ Hits         2630     2632       +2
+ Misses        217      206      -11

Impacted Files
Coverage Δ

...rchmultimodal/modules/layers/position_embedding.py
100.00% <0.00%> (ø)

torchmultimodal/modules/layers/attention.py
94.54% <0.00%> (+9.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9fc29a...6153b72. Read the comment docs.

why examples? wouldnt mind putting this in core.

Originally I thought it would be a slow test due to checkpoint loading so I put it in examples but it’s actually pretty quick, so I’ll move it to core

Where is the step that loads the checkpoint? Or is it more of a regression test with fixed rng state?
Do you mean to put this under examples/ or core? In your test plan it says examples/ but in the change list it says core.

@langong347 The pretrained_model_key argument triggers loading the checkpoint, see here


Addressing slow Element.outerHtml() on Android 4.4 and 5

The big slowdown on Android 4.4 and 5 is the call to canEncode(c) in Entities.escape() method. Assuming that virtually any codepoint can be encoded in Unicode (e.g. UTF-8, UTF-16), added a check for encoder being Unicode and skipping this costly call. Speeds up Android 4.4 and 5 calls about 10 times.
Added some small other optimizations in a few other modules.
Greg

Thanks @gregko for your help in fixing this perf issue. I have committed a similar change, so won't pull this one.
Did you measure a performance improvement from intitializing the buffer size? I'm not sure how a user would know what size to specify. If it's a big improvement, maybe we could think of a heuristic to pre-calculate it? Seems that it should be conservative and err on under-estimating.

Great, Jonathan, thank you for implementing this solution, will help me stay with your main code instead of working with my own fork!
I tried to measure if there is any performance improvement with initializing buffer size, and on an HTML file of about 200 kB length did not notice any improvement compared with the default buffer length (measured ms spent in doc.outerHtml() routine).


Changed --test to take multiple directories

PR checklist

[x] Addresses an existing issue: #2064
[x] New feature, bugfix, or enhancement

[ ] Includes tests

[x] Documentation update

What changes did you make?
Used an extra glob.sync to allow for wildcards / general glob patterns from --test.
Is there anything you'd like reviewers to focus on?
A couple of issues I think should be addressed before merge:

[ ] No tests added. I didn't see much coverage for runTest other than the CLI's general exit code testing. I can add exit similar testing for runTests, but is there a more direct testing method you'd like instead?
[ ] Can part of ruleTestRunner.ts be replaced with runTests?

Thanks for the quick merge @nchen63! About the extra points in the PR - I'll look into doing both of those as described unless directed otherwise.

Yep, those are both fine. Make sure all changes to ruleTestsRunner are backwards compatible


Single host items contain the hostname in the legend

Hi, new version 4.1.1 did not fix the issue https://github.com/grafana/grafana-zabbix/issues/1335
I`m using Grafana v 9.5.5 and zabbix v 5.0
hostname is not displayed if Direct DB Connection is disabled
but if you turn it on, the name will appear again

You should use replaceAlias function to remove the hostname part. look at the steps on this video: https://youtu.be/-dT8Yu0Upk4?list=PLTAdaA8clXXK9A9rPjBKqxho4AGSTb6un&t=352

I was able to replicate it thanks @mingaliev-e. While we are working on a fix you can use @isaqueprofeta answer as a workaround.

@zoltanbedi I can’t use replicaAlias, I have about 2000 dashboards and changing each chart takes a very long time

When using "Direct DB Connection" on  version 4.4.3 , still not fixed .  When not enable this option ,it worked on  4.4.3


🐞 [Bug]: enhancement for Node public config validation

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
i tried some cases not covered leading to unclear error

Steps To Reproduce
No response
which network/s did you face the problem on?
Dev, QA
version
2.4.0
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
NA

can not produce the same issue again shall we close it ?

Devnet.
I found some cases, like:

The IPv4 or IPv6 shouldn't be in a different subnet than their gateway.

The IPv4 or IPv6 don't have subnet mask validation.

The IPv4 or IPv6 don't have private IP validation.

And there are more cases where the validation is different between the dashboard and the TFchain.

Issue update
Investigation and Solution:
The gateway must reside within the same IP range (subnet) as the node's IP address to facilitate proper routing. This ensures that the node can effectively communicate and route its traffic through the designated gateway.
Work done
Changes

Gateway IP Range Validation:

A new validation rule has been added to ensure that the gateway IP address is within the same subnet as the node's IP address. This validation is applied based on the IP version (IPv4 or IPv6).

IPv4 Address Type Validation:

A new validation rule has been added to verify whether the provided IPv4 address is public or private.

IPv6 Address Type Validation:

A new validation rule has been added to verify whether the provided IPv6 address is public or private.

Verified, Devnet 0d964e5.
A public and private IPv4 and IPv6 validation, a subnet validation, and a gateway to be in its IP range validation have been added.

Updated: TC2218 - Public Config Input Validation.


error while executing ansible playbook using private key

getting an unreachable error when I try to execute ansible playbook using private key and the log shows an entry like :
'Error: Using /etc/ansible/ansible.cfg as config file\n\nPLAY [all] *********************************************************************\n\nTASK [Ping all hosts] **********************************************************\nfatal: [<IP_ADDRESS>]: UNREACHABLE! => {"changed": false, "msg": "Failed to connect to the host via ssh: command-line line 0: garbage at end of line; \"PrivateKey.pem\".", "unreachable": true}\n\nPLAY RECAP *********************************************************************\n<IP_ADDRESS>             : ok=0    changed=0    unreachable=1    failed=0    skipped=0    rescued=0    ignored=0
here I am trying to execute the command :
var command = new Ansible.Playbook().inventory(inventory).playbook('ping').privateKey("PrivateKey.pem").verbose('v').
command.exec();
the issue i am facing is that the private key is being accepted along with quotes or a new line character or a forward slash, Is there a workaround for this, please help!

@shaharke @minademian any insights on this please ? I tried to follow the issue #28 but could not come up with a work around.

This is caused by additional quote added in addPathParam function.


Create dictionary of statutes from UCCS schema

Today, when we normalize statute data we send a CSV containing the unprocessed charge data to the University of Michigan and they send us back a processed CSV. Since we have a record of the inputs and outputs, we should be able to create a dictionary to map unprocessed strings to their processed strings, based on the case number and charge.
If this step throws an error, like "Statute not found", we'll add that string to a new data set and send it to U of Mich for processing.
@emilyrbartha should have access to uccs_schema.csv.

I created a dictionary of statutes as a JSON file and uploaded it to this repo under the cleaning folder suggested here.
To answer my own previous question: This University of Michigan tool is not something can be used via API. It's performed only on CSVs. Accordingly, we'll have to use our largest dataset to match as many as we can, and may be able to use other cleaning methods to capture missed charges.
Accordingly, this item can be closed.


Fix panic when retry duration is exceeded

Fixes #2253

To be really safe, why not check for nil at https://github.com/kubernetes-incubator/service-catalog/blob/3d0602afb81d872521e527c3aae83e26676b184b/pkg/controller/controller_instance.go#L2392 as well?  Or if not, at least add a comment to that func mandating that the param MUST NOT be nil.

why not check for nil

I don't think there's a need for that. Panic prints a stack trace, which is very useful for debugging. Also, you will never miss a panic since it kills the controller pod.

at least add a comment to that func mandating that the param MUST NOT be nil.

I don't think anyone will read this comment :) Also such comments become outdated quickly. In other languages I would use null-safety syntax features, but Golang doesn't have one :(

IMO programs should never panic.

@duglin exactly, panic is a sign of a bug. And this PR fixes the bug and removes a panic.
But in most cases it's better to panic in the unexpected situation than mask the error. Once the situation is known, you either make the value non-nil, or add extra check with a meaningful error message. In this particular case we could only add a message "some SC developer messed up and didn't provide a status condition", which is not useful for the end user, but complicates discovering such bugs and debugging for ourselves.
Happy to discuss if there are alternative arguments though.

To me its not about "masking the error", log it so if someone wants to dig into the code they can. But then allow the end-user to continue to make progress because a panic does them no good when all they want to do is continue to get their work done. They're not Kube/SC devs.  I did offer 2 suggestions - its up to you if you want to do either.

The problem is that Golang is not a null-safe language. Almost anywhere you can run into nil value, including struct fields (since there are no proper constructors in Go). Adding nil checks in every case where you mandate the value to be non-nil to avoid panic would pollute the code with ugly
if a == nil || b == nil || c == nil {
  return nil, errors.New("some input arguments were nil")
}

at the beginning of every single function. It's not common to do that in Go; Go prefers simplicity over redundant safety, unless you are handling a valid case where null value is allowed.
Another way of preventing panic is a test coverage. This particular case was not easy to run into (that's why it wasn't discovered for months), but it's possible to write an integration test reproducing it. But once we ran into it, we immediately discovered it and easily found the cause. With a logged error I doubt we would ever discovered this bug - everything would work with missing information in status.

/lgtm

/lgtm

/approve

@jpeeler I'm adding an LGTM2 on your behalf, hope you don't mind.


Replace dubbo-build-tools with dubbo-shared-resources

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #13016 (b87c547) into 3.3 (8009c72) will increase coverage by 2.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.3   #13016      +/-   ##
============================================
+ Coverage     66.02%   68.32%   +2.29%
  Complexity        6        6
============================================
  Files          1850     1717     -133
  Lines         74142    70760    -3382
  Branches      10510    10251     -259
============================================
- Hits          48952    48345     -607
+ Misses        20451    17721    -2730
+ Partials       4739     4694      -45

see 155 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


how to define address range (CIDR) for azure subnet?

Hello Guys, I have created azure virtual network. Now I want to create a VPN connection between azure vnet and azure vm. when I am tring to create subnet under virtual network, its asking for IP range unforeunately whenever I am entering any IP its not accepting.I am from india so which range should i used for vpn ponit of site.

@SudeshSharma , Thank you for your question. We will look into it and update the thread.

@SudeshSharma , Not sure if the question is regarding creation of a subnet in Virtual Network or an address pool in an Azure Virtual network gateway. So I am adding descriptions for both here.
If you are trying to create a subnet in an Azure Virtual Network, the CIDR address range should be carved out from the virtual network address space (whatever you have defined while creating the Vnet).
For example: If your Vnet address space is <IP_ADDRESS>/16, then the subnet should be a range within <IP_ADDRESS>/16 such as <IP_ADDRESS>/24, <IP_ADDRESS>/25, <IP_ADDRESS>/27 or so on.
You may refer to subnetting concepts for more information : https://support.microsoft.com/en-in/help/164015/understanding-tcp-ip-addressing-and-subnetting-basics
But if you are trying to create a VPN gateway with point to site VPN configuration and are looking to add the address pool for client connectivity, you can use any private IP address range that does not overlap with the on-premises location that you connect from, or the VNet that you want to connect to.
For example: If you have a Vnet with address range <IP_ADDRESS>/16, you can add a Client address pool of <IP_ADDRESS>/24 (but make sure it is not overlapping with any existing address range). VPN clients that connect to the VNet using Point-to-Site connection receive an IP address from the client address pool.
Please refer : https://docs.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-howto-point-to-site-resource-manager-portal#addresspool
Kindly let us know if the above helps or you need further assistance on this issue.

@GitaraniSharma-MSFT  Thanks for reply. Hey I m tring to create subnet in virtual network. According to your example, vnet address space <IP_ADDRESS>/24, then the subnet should be range <IP_ADDRESS>/25. I have tried but got errors.

@SudeshSharma , From the screenshot, I can see you already have a default subnet with address range <IP_ADDRESS>/24. Could you please help me with the address space of your Vnet?

@GitaraniSharma-MSFT Thanks for help. Your solved My problem.

Hey @GitaraniSharma-MSFT need one more help, which one is better for security concern:
Azure Bastion
Azure Virtual Private Network Point-on-site
Please Suggest

@SudeshSharma , It depends on your requirement.
The Azure Bastion service is a new fully platform-managed PaaS service that you provision inside your virtual network. It provides secure and seamless RDP/SSH connectivity to your virtual machines directly in the Azure portal over TLS. When you connect via Azure Bastion, your virtual machines do not need a public IP address. Bastion provides secure RDP and SSH connectivity to all of the VMs in the virtual network in which it is provisioned. Using Azure Bastion protects your virtual machines from exposing RDP/SSH ports to the outside world, while still providing secure access using RDP/SSH. With Azure Bastion, you connect to the virtual machine directly from the Azure portal. You don't need an additional client, agent, or piece of software.
Reference : https://docs.microsoft.com/en-us/azure/bastion/bastion-overview
A Point-to-Site (P2S) VPN gateway connection lets you create a secure connection to your virtual network from an individual client computer. This solution is useful for telecommuters who want to connect to Azure VNets from a remote location, such as from home or a conference.
With Point-to-Site, you can have other features/options such as connecting to a peered Vnet without an additional gateway, App service Vnet Integration, use Azure Private link to access services running in Azure from on-premises over the VPN tunnel etc.
Reference : https://docs.microsoft.com/en-us/azure/vpn-gateway/point-to-site-about
https://docs.microsoft.com/en-us/azure/app-service/web-sites-integrate-with-vnet
https://docs.microsoft.com/en-us/azure/private-link/private-link-overview
However, if your end goal is just to access your resources deployed in Azure, you could use Azure Bastion solution, instead of VPN connection to get secure shell access (RDP or SSH) without requiring public IPs on the VMs being accessed.
Kindly let us know if the above helps or you need further assistance on this issue.


Github actions failing when issues are raised

When I raised an issue, I had an email from Github that it started and failed an action

Here is the run: https://github.com/twilio/twilio-oai/actions/runs/764828871

Hi @savage-alex Thank you for reporting the issue!
This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

This bug has been fixed and the github action is now building successfully.


Support excluding multiline regexes (fix #996)

This PR allows using multiline regexes in exclude_lines. It does so by matching regexes against the whole source code, instead of line by line as was done before.
The behavior is equivalent to adding a # pragma: no cover comment to each line matched by the multiline regex. Because of that, if a suite (e.g. if True:) is matched, all statements inside it will also be excluded, just like if there was a no-cover pragma on the suite line.
This is made possible because @nedbat figured out a O(N) algorithm for finding line numbers for the matches. With it, there's a small performance increase for excluding lines compared to the previous code.
Fixes #996.

We should also add a test for the #1803 example.

Do you want to update the docs, or leave that to me?

When this pull request is merged, we should update issues #118, #996, #1741, and #1803.

Do you want to update the docs, or leave that to me?

No, I'd rather let you do your thing with the docs. But thanks for asking :)

This is now released as part of coverage 7.6.0.