Site Showcase Request

Please include:

Description: Make money by sharing the templates you made, whether it's Bootstrap, Wordpress, Ghost, Drupal or any templates. Join Marketica now and earn more.
Primary Link: https://marketica.co/
Screenshot: http://i.imgur.com/q8Ysgf6.png

Sorry about the quick close and re-open. When I saw the description provided a spam alert went off immediately in my brain.
@addyosmani I'm kinda worried about putting a full marketplace into the Showcase. We'd have to nofollow it at the very least imo. Not sure where we should draw the line as to the type of sites to allow in. Any thoughts here?

I think we need to figure out a good strategy for showcase long term. Right now I've only highlighted trusted Google sites using MDL, but perhaps you're right that we should either nofollow these. I'll try to come up with better showcase guidelines.

@addyosmani Did you decide what you want to do with showcase requests? Looking through the issues, I can see loads of requests, but none have been added to the showcase page so far.
I was going to add my own request, but it would be good to know if there's even a chance for it to get added before I do.

MDL is no longer being maintained or actively developed. Work has been refocused into Material Components for Web which evolved from the initial MDL v2 concept.

@Garbee Fair enough, I didn't see the announcement.
Is there any migration information or are the two projects incompatible?

Migration path is TBD. MCW is still pretty early on in the dev cycle and subject to quite a bit of change. That's all going to be handled by that team now afaik.
In theory, the projects are compatible since you should be able to drop MCW stuff into an MDL project to slowly migrate. But, I have yet to need to attempt that. MCW is far more modularized and isolated with its component setup than MDL was thanks to our education building this.


Need resources for testing candle project

Could you help me with resources?
I try to launch https://github.com/huggingface/candle
cargo run --example llama --features cuda
I have 32 Gb RAM laptop with GPU 4GB RAM
it is not working on my small resources
I try to rent per hour GPU on Google Claude, Paperspace, Vultr and etc. All GPU with 24-32 RAM already rent :(
My email<EMAIL_ADDRESS>

I'm sorry you can't help me. While I was waiting for your answer, I directed my energy to the creation of 2 open source projects on Rust.
https://github.com/evgenyigumnov/orm-lib
https://github.com/evgenyigumnov/actor-lib
You can look at them and evaluate the quality of my Rust code.
I am very interested in the subject of AI. And I have ideas for several startups on Rust in the field of AI. I am very interested in contributing to your project to enter this topic. But I can’t simply run your examples on my laptop. So I turned to you for help.


Vulkan on Metal via Vulkan Portability

I've been testing the tutorial samples with gfx-portability, and with https://github.com/gfx-rs/portability/pull/177 resolved we have everything but the geometry and tessellation samples running on MacOS.
Would you consider changing the logic to use a generic Vulkan Portability library instead of MoltenVK specifically? Currently, it looks like Diligent links directly against libMoltenVK.dylib.

Also related to #46, #34, and #49

Yes, that should be feasible. I think providing the path to the library during CMake configuration should work.
In fact in this case there will be no need to keep the binary in the repository. For macos, the size of libMoltenVK.so is about 2 MB, but for iOS it is almost 10 MB, so keeping it around is impossible withou bloating the repo size.
This will require little bit more effort from the user, but should simplify many things. Few default locations could be searched too I guess.

I think providing the path to the library during CMake configuration should work.

A recommended way for Vulkan applications is to link to the loader (libvulkan.1.dylib) instead of the particular driver/implementation. Whether you want to bundle a particular version of the loader with an app is one question (that isn't important to us), and I think you already do, but not link to it (at least with default build settings). The implementation is then selected with the ICD JSON file, path to which can be easily overridden by the user with VK_ICD_FILENAMES environment variable (handled by the loader).
Also, going forward (i.e. this isn't required now), there is going to be a few Vulkan Portability extensions that work across gfx-portability and MoltenVK:

VK_EXTX_portability_subset: to discover the extra limitations
window system integration: to create a surface from CAMetalLayer
direct MTLTexture and MTLDevice interop: for video decoding and such

@kvark I am correct that if Diligent links against libvulkan.1.dylib, the loader will take care of setting up all the function pointers being it MoltenVk or any other implementation? Is libvulkan.1.dylib part of the LunarG SDK?

Yes

On Mar 9, 2019, at 02:57, DiligentGraphics<EMAIL_ADDRESS>wrote:
@kvark I am correct that if Diligent links against libvulkan.1.dylib, the loader will take care of setting up all the function pointers being it MoltenVk or any other implementation? Is libvulkan.1.dylib part of the LunarG SDK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

OK, will do.

@DiligentGraphics note that if you do any testing on macOS and encounter issues with MoltenVK, and you link with the loader, you can try running on gfx-portability if you provide VK_ICD_FILENAMES=<path_to_portability_json> in the environment. If the behavior is different, it might be a bug in either of the libraries, and we'd be interested to fix it.

Ok, I am actually looking into this right now. So to make it work with MoltenVk, I should have a loader and a json file next to it? How will it find the implementation? Is it also soecified by json?
Also, how does this work on iOS. It seems there is no loader for iOS in Vulkan SDK.

The loader workflow is the same as on other platforms:

you link to the loader dylib
when an app starts, the loader searches for available ICD jsons in some folders, plus whatever you provide in VK_ICD_FILENAMES environment
the ICD json points to an actual driver/portability dynamic library

gfx-portability can be either downloaded from our releases or built from source (via make, there are variations in what you can build of course). In either case the sample JSON is provided.
As for iOS, I don't really know. You can always link to the portability library directly instead of the loader though. In our case, libportability is the one exposing driver entry points, while libportability-icd exposes only ICD entry points.

@kvark I tried to link against libvulkan.1.dylib from LunarG SDK and that seems to work fine. However, it wants libMoltenVK.dylib to be located in the same folder otherwise it fails to link.
I can't understand where dependency on MoltenVK comes from.
otool -L libvulkan.1.dylib prints this:
@rpath/libvulkan.1.dylib (compatibility version 1.0.0, current version 1.1.101)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1252.200.5)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1560.12.0)

@DiligentGraphics the loader links to neither of the drivers dynamically, so otool will not show you it, this is expected. Instead, the loader scans for ICD jsons. I see that it bundles the MoltenVK_icd.json in sdk/macOS/etc/vulkan/icd.d/. I also see that sample applications in the SDK carry that ICD inside, i.e. sdk/Applications/vkcube.app/Contents/Resources/vulkan/icd.d/MoltenVK_icd.json.
TL;DR; if you want to run with a specific portability library during development, just provide the VK_ICD_FILENAMES=<path_to_icd_json> in the environment. Perhaps, for shipping you just make sure the corresponding ICD is bundled in Contents/Resources/vulkan/ and distribute the app with both libvulkan.1.dylib and the portability library. Not completely sure, tbh.

@kvark I still don't understand why the build fails. If the whole point is to be able to switch Vulkan implementations dynamically at run time, then why does it want specific implementation (MoltenVK) at build time? If the loader searches for specific dylib based on json or any other configuration, shouldn't I have run-time error if it can't find the library instead of build error?

Wait, you didn't say that it was the build that failed. This makes no sense. Perhaps it's your project settings that still expect libMoltenVK.dylib somewhere? libvulkan.1.dylib is definitely not what fails for you.
On an unrelated note, we've just made a release that mentioned your engine: https://github.com/gfx-rs/portability/releases/tag/0.5

Ah, darn it! Forgot that CMake does not update the library path once it found it unless you delete that CMake variable... Now everything builds fine - almost there.

On an unrelated note, we've just made a release that mentioned your engine: https://github.com/gfx-rs/portability/releases/tag/0.5

That is really cool! Thanks!

@kvark I tried to use gfx-portability instead of MoltenVK, but it fails with the following errors:
Diligent Engine: ERROR: Vulkan debug message (ERROR, general): Message Id: 0 | Message Name: Loader Message
                 terminator_CreateDevice: Failed in ICD .../gfx-portability-macos-0.5/libportability-icd/../target/debug/libportability_icd.dylib vkCreateDevicecall
                 Object[0] (instance): Handle 0x1040f1200

Diligent Engine: ERROR: Vulkan debug message (ERROR, general): Message Id: 0 | Message Name: Loader Message
                 vkCreateDevice:  Failed to create device chain.
                 Object[0] (instance): Handle 0x1040f1200

Diligent Engine: CRITICAL ERROR in VulkanLogicalDevice() (VulkanLogicalDevice.cpp, 51): Failed to create logical device
VK Error Code: ERROR_FEATURE_NOT_PRESENT

Do you know what may be wrong here?

It says a feature does not present. Do you discover physical device features before creating the device? We can work on exposing a feature you need, just need to know which one.

On Mar 21, 2019, at 22:53, DiligentGraphics<EMAIL_ADDRESS>wrote:
@kvark I tried to use gfx-portability instead of MoltenVK, but it fails with the following errors:
Diligent Engine: ERROR: Vulkan debug message (ERROR, general): Message Id: 0 | Message Name: Loader Message
terminator_CreateDevice: Failed in ICD .../gfx-portability-macos-0.5/libportability-icd/../target/debug/libportability_icd.dylib vkCreateDevicecall
Object[0] (instance): Handle 0x1040f1200
Diligent Engine: ERROR: Vulkan debug message (ERROR, general): Message Id: 0 | Message Name: Loader Message
vkCreateDevice:  Failed to create device chain.
Object[0] (instance): Handle 0x1040f1200
Diligent Engine: CRITICAL ERROR in VulkanLogicalDevice() (VulkanLogicalDevice.cpp, 51): Failed to create logical device
VK Error Code: ERROR_FEATURE_NOT_PRESENT
Do you know what may be wrong here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Ah, OK. Yeah, being more explicit about what feature exactly is missing would be really helpful here. The feature was multiViewport. None of the samples/tutorials really need this feature, but the third-party UI library does. I already had issues with this and even disabled it once, but then enabled again. I guess it is time to disable it for good https://github.com/DiligentGraphics/DiligentSamples/issues/8.
Anyway, when this feature is not enabled, the device is created successfully and all tutorials run fine
(yay!) with one exception: I recently made some updates to avoid GPU falling indefinitely behind the CPU (https://github.com/KhronosGroup/MoltenVK/issues/530): https://github.com/DiligentGraphics/DiligentCore/commit/b7cbf119119eeeee4026d6f631c7de3b65fa929d. With this change, this call
LogicalDevice.WaitForFences(1, &OldestSubmittedFence, VK_TRUE, UINT64_MAX);

returns VK_TIMEOUT  which does not make sense as timeout is set to UINT64_MAX. This causes debug validation error in the next line. This works fine on other platforms/implementations.

@DiligentGraphics this is great news!

being more explicit about what feature exactly is missing would be really helpful here

In general, I agree. But it's hard to pinpoint the party that should be responsible for this:

an application can do, so why should other layers bother?
validation layer can do, but this isn't really an invalid usage: there can be app that properly reacts on that error
driver/portability layer can do

In general, we spew out warnings/infos/errors using standard Rust mechanisms. gfx-portability can be built (with --features env_logger) to output these messages to the screen. Currently though, we don't have any message for features missing, I'll add it.

returns VK_TIMEOUT which does not make sense as timeout is set to UINT64_MAX

I double-checked the code and there is only one way this could be happening: if the fence is not pending (i.e. not scheduled), and it was already reset. Any specified timeout then doesn't make sense. Interestingly, I don't see anything in the spec defining the behavior in this case, so I guess you are stepping into undefined behavior? I'd at least expect this in some way mentioned in valid use statements.
btw, the spec says you don't need to get a fence status before waiting:

If the condition is satisfied when vkWaitForFences is called, then vkWaitForFences returns immediately.

Anyway, I've made a patch to gfx-rs to log both of these warnings - https://github.com/gfx-rs/gfx/pull/2708. We'll also make the published gfx-portability debug builds to enable output to terminal.

I double-checked the code and there is only one way this could be happening: if the fence is not pending (i.e. not scheduled), and it was already reset.

There is special logic here, here, and here that assures that the fence status is only checked if it has been submitted. In fact there were few issues causing deadlock on Windows when checking the status of the fence that has not been submitted. Everything works fine now on other platforms without any validation layer messages. Now that there is proper loader on Mac, validation layers can also be enabled. On MoltenVk, all samples and tutorials run clear. With gfx-portability, there is a lot of messages, including the one about using fence that has not been submitted:
Diligent Engine: ERROR: Vulkan debug message (validation): VUID-vkResetFences-pFences-01123
                 Fence 0x5e is in use. The Vulkan spec states: Each element of pFences must not be currently associated with any queue command that has not yet completed execution on that queue (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-vkResetFences-pFences-01123)
                 Object[0] (fence): Handle 0x5e

As I mentioned the fact that it runs clear on other implementations including MoltenVk most likely suggests there is an issue in gfx-portability.
There are also some messages that make no sense to me:
Diligent Engine: ERROR: Vulkan debug message (validation): VUID-VkViewport-x-01232
                 vkCmdSetViewport: pViewports[0].x + pViewports[0].width (=0.000000 + 1600.000000 = 1600.000000) is greater than VkPhysicalDeviceLimits::viewportBoundsRange[1] (=0.000000). The Vulkan spec states: (x + width) must be less than or equal to viewportBoundsRange[1] (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkViewport-x-01232)
                 Object[0] (cmd buffer): Handle 0x10405f000

Diligent Engine: ERROR: Vulkan debug message (validation): VUID-VkViewport-y-01776
                 vkCmdSetViewport: pViewports[0].y (=1200.000000) exceeds VkPhysicalDeviceLimits::viewportBoundsRange[1] (=0.000000). The Vulkan spec states: y must be less than or equal to viewportBoundsRange[1] (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkViewport-y-01776)
                 Object[0] (cmd buffer): Handle 0x10405f000

Diligent Engine: ERROR: Vulkan debug message (validation): VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286
                 vkCreatePipelineLayout(): setLayoutCount (2) exceeds physical device maxBoundDescriptorSets limit (0). The Vulkan spec states: setLayoutCount must be less than or equal to VkPhysicalDeviceLimits::maxBoundDescriptorSets (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkPipelineLayoutCreateInfo-setLayoutCount-00286)
                 Object[0] (unknown): Handle 0x0

Diligent Engine: ERROR: Vulkan debug message (validation): VUID-VkPipelineLayoutCreateInfo-pSetLayouts-00287
                 vkCreatePipelineLayout(): max per-stage sampler bindings count (1) exceeds device maxPerStageDescriptorSamplers limit (0). The Vulkan spec states: The total number of descriptors of the type VK_DESCRIPTOR_TYPE_SAMPLER and VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER accessible to any shader stage across all elements of pSetLayouts must be less than or equal to VkPhysicalDeviceLimits::maxPerStageDescriptorSamplers (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkPipelineLayoutCreateInfo-pSetLayouts-00287)
                 Object[0] (unknown): Handle 0x0

and many more. I guess you can now easily enable validation layers and switch implementations to try it yourself. I also fixed sample apps and they do not enable multiViewport feature anymore.

@DiligentGraphics thank you for the info, it's great feedback for us!
I debugged your engine a bit and found a problem in our implementation: we currently don't expect both semaphore and fence to be provided. Filed https://github.com/gfx-rs/gfx/issues/2711 to get that sorted out.

It also looks like deviceLimits structure is not initialized that causes a lot of messages like these:

Yeah, we are slowly expanding the meaningful limits that are exposed. We'll get those filled out ;)

@kvark I also have a test application that is essentially a collection of unit tests. They are not the most elegant unit tests you will be able to find out there, but they cover pretty much the entire Diligent API and implementation. I keep hoping to rework them one day in a true test system that runs as part of CI, but realistically not sure when this may happen. Anyway, if this app runs on a platform, I have pretty high confidence that there are no major problems. There are currently few issues on MacOS, but if you think it may be useful for you, I can fix it.

Yes, this would definitely be useful to us. There are many ways we currently apply for testing, including Vulkan CTS, but neither method is best. Having your demo as an option would be helpful.

OK, will fix it.

FYI, the fixes to the issues you found are coming in https://github.com/gfx-rs/portability/pull/180

I am getting this error when building gfx-portability:
   Compiling portability-gfx v0.1.0 (/git/portability/libportability-gfx)
error[E0463]: can't find crate for `back`
  --> libportability-gfx/src/lib.rs:15:1
   |
15 | extern crate gfx_backend_vulkan as back;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.
error: Could not compile `portability-gfx`.

Is there a way to download pre-built binaries?

@DiligentGraphics all you need to build is make, then the (debug) ICD library appears in target/debug/libportability_icd.dylib. For release, you'd do make release correspondingly.
We have the CI infrastructure to generate binaries on tags/releases, but we've just make 0.5 and it's too early to release an update.

@kvark With your patch, all tutorials run fine (though still generate a lot of validation messages). There also seems to be an issue with blend modes in Tutorial10 since it looks little different.
What would be really cool if Atmosphere sample worked. It doesn't run on MoltenVK either (fails to convert one of the shaders with odd error about row-major matrices that are never used). gfx-portability in fact goes beyond that point and crashes at draw command:
-[MTLDebugRenderCommandEncoder validateFramebufferWithRenderPipelineState:]:1218: failed assertion `For color attachment 0, the render pipeline's pixelFormat (MTLPixelFormatRG8Unorm) does not match the framebuffer's pixelFormat (MTLPixelFormatRG32Float).'

It feels like it is checking PSO-Frame Buffer compatibility when PSO is bound, but proper Framebuffer is bound later. The sample works fine and runs clear on Windows & Linux.

@DiligentGraphics

With your patch, all tutorials run fine (though still generate a lot of validation messages)

Great, thanks for confirming! The validation errors in this case are unlikely going to help much. At best they'll tell us which limits are missing (not that we don't know that already....).

There also seems to be an issue with blend modes in Tutorial10 since it looks little different.

Thanks for the pointer, I'll have a look!

What would be really cool if Atmosphere sample worked. It doesn't run on MoltenVK either (fails to convert one of the shaders with odd error about row-major matrices that are never used).

Unfortunately, we also rely on SPIRV-Cross for shader compilation still. Our plan is to remove this dependency, but we don't have resources yet to develop an in-house alternative. This means that for now we are going to have the same shader errors as MoltenVK.

It feels like it is checking PSO-Frame Buffer compatibility when PSO is bound, but proper Framebuffer is bound later. The sample works fine and runs clear on Windows & Linux.

Interesting! May I guess that your sequence of actions is:

enter a pass A
bind pipeline P that is not compatible with pass A
leave pass A, enter pass B
draw something with this pipeline P

Our implementation doesn't expect the fact that a pipeline is bound in a render pass that is incompatible, although I do agree this is technically valid Vulkan (if that pipeline isn't used in this pass). I can think of a way to solve this (similar to vertex buffers mechanics).

May I guess that your sequence of actions is

Correct. The engine does not enforce specific order for setting pipeline states and binding render targets (there are no native render passes and frame buffer objects in the common API yet, but they are planned). So a PSO may be temporarily incompatible with current framebuffer.

About Tutorial10. You said the blending looks different. Is it different from Vulkan? Or from MoltenVK? I noticed that BlendState array (on your side) isn't initialized to zero and only partially filled, so there is that.

On Mar 24, 2019, at 22:07, DiligentGraphics<EMAIL_ADDRESS>wrote:
May I guess that your sequence of actions is
Correct. The engine does not enforce specific order for setting pipeline states and binding render targets (there are no native render passes and frame buffer objects in the common API yet, but they are planned). So a PSO may be temporarily incompatible with current framebuffer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I checked Tutorial10 and didn't find anything to fix, see https://github.com/gfx-rs/gfx/issues/2714#issuecomment-477178743
Also, we have a new release - https://github.com/gfx-rs/portability/releases/tag/0.6 . Binaries are going to be published there momentarily by CI. It carries the fixes to problems you pointed to here, including binding the incompatible pipeline in a pass. (note: Atmosphere sample now fails in shader compilation, as expected).

This is screenshot with gfx-portability:

This is what it is supposed to look like:

It is not completely broken, but the look is definitely different.

Could it be just the swapchain format being different, i.e. sRGB versus regular Unorm?

Unlikely. The background will be different as well as overall brightness. There are only some polygons that look different, and also all other tutorials look correct


Remove duplicate references in all-packages.nix

Issue description
Quite a few files are referenced in callPackage multiple times. This is almost always not the right way to do things. Almost always an override is preferred to running callPackages multiple times. I remove many in #39686 but lots still remain. Here is the full list:

[ ] ../applications/networking/browsers/firefox-bin
[ ] ../applications/office/libreoffice/wrapper.nix
[ ] ../applications/video/mkvtoolnix
[ ] ../applications/video/vlc
[ ] ../development/go-modules/generic
[ ] ../development/interpreters/lua-5/5.2.nix
[ ] ../development/interpreters/lua-5/5.3.nix
[ ] ../development/libraries/audio/libbass
[ ] ../development/libraries/glibc
[ ] ../development/libraries/gpgme
[ ] ../development/libraries/phonon
[ ] ../development/libraries/phonon/backends/gstreamer.nix
[ ] ../development/libraries/phonon/backends/vlc.nix
[ ] ../development/libraries/poppler
[ ] ../development/libraries/qscintilla
[ ] ../development/libraries/qtkeychain
[ ] ../development/libraries/telepathy/qt
[ ] ../development/web/nodejs/v10.nix
[ ] ../development/web/nodejs/v6.nix
[ ] ../development/web/nodejs/v8.nix
[ ] ../development/web/nodejs/v9.nix
[ ] ../os-specific/linux/sysdig
[ ] ../os-specific/linux/uclibc
[ ] ../os-specific/linux/wireguard
[ ] ../os-specific/linux/zfs
[ ] ../shells/bash/4.4.nix
[ ] ../test/cc-wrapper
[ ] ../test/cc-wrapper/multilib.nix
[x] ../tools/misc/grub/2.0x.nix
[x] ../tools/misc/heimdall
[ ] ../tools/networking/openconnect
[x] ../tools/system/rsyslog

Output comes from this command:
grep 'callPackage ' pkgs/top-level/all-packages.nix | sed 's,^.*callPackage ,,' | sed 's, .*,,' | sort | uniq -d

Almost always an override is preferred to running callPackages multiple times

this is not true as it, for example, breaks replacing a package with its nox version via a overlay.


Problem with downloading from google.docs

New Issue Checklist (tick off like this: [x])

[ ] https://drive.google.com/file/d/0B6GaeaaoAPK1N2Q4WVBEVGp1dG8/view

What is your browser?

[ ] awesome Opera

What is your operating system?

[ ] Windows

Add  drive.google.com to the black list if it causes problems.


Implement type x-refs [phab:D1000]

Created by schroederc at 2016-08-05 22:23:09:
Implements type x-refs for Path-based types and primitives.

djrenren wrote at 2016-08-08 20:09:53:

Added support for primitives and added tests

djrenren wrote at 2016-08-08 20:38:43:

Fixed some comments and removed unused imports

zarko commented inline (context lost during migration) at 2016-08-08 23:00:38:
Did you mean to add ":types" here as well?

zarko commented inline (context lost during migration) at 2016-08-08 23:00:38:
I'd expect to see some subset of:
Pair ref SPair
"Pair<i32,u32>" ref TAppSPair
TAppSPair.node/kind tapp
TAppSPair param.0 SPair
TAppSPair param.1 Pi32
TAppSPair param.2 Pu32
SPair.node/kind abs
SPairBody childof SPair
SPairBody.node/kind record

as well as nodes for the type variables T and U.
I think you should at least assert the kinds of EEnum and SPair, even if you elect not to model the type application in this diff. Should you make that election, it's probably better if Pair refers to SPair and not "Pair<i32,u32>".

djrenren commented inline (context lost during migration) at 2016-08-09 18:23:22:
yeah

djrenren commented inline (context lost during migration) at 2016-08-09 18:23:22:
This means I'm indexing my structs... and enums... and functions.... wrong. So this diff is going on hold for a bit

jrtom wrote at 2017-10-18 17:17:28:
Are there plans to pursue this change any further?

schroederc abandoned revision at 2017-11-03 20:46:58


migrate IOUPreview to PressableWithFeedback

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/17010
PROPOSAL: https://github.com/Expensify/App/issues/17010
Tests

Send the money request to another user
The IOUPreview should appear in the chat, verify that styling remains unchanged and looks as before this PR
Click/Press on the IOUPreview
Verify that pressing navigates user correctly

[X] Verify that no errors appear in the JS console

Offline tests

Same as Test steps
QA Steps

Same as Test steps

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/61146594/8d8f161a-b1e4-4241-8c97-895b9934ef4d

Mobile Web - Chrome
https://github.com/Expensify/App/assets/61146594/a763e135-d448-4c61-ab72-7dfd82091313

Mobile Web - Safari
https://github.com/Expensify/App/assets/61146594/ce85aeec-36b2-4736-84b5-4fac74b76272

Desktop
https://github.com/Expensify/App/assets/61146594/48af04e2-9c01-4e2d-814c-b501c24c2d80

iOS
https://github.com/Expensify/App/assets/61146594/8f5b3487-1c82-47e3-a607-28ceba3e2e36

Android
https://github.com/Expensify/App/assets/61146594/3c62227c-a0ce-44c6-8f50-d55182ede3cc

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.26-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Migrate to verbatimModuleSyntax in TypeScript config

As the title suggests. It should be an easy fix, since the only thing left is to mark type only imports with ESLint.

What benefits does this have? Afaik it only affects emitting js with tsc, but esbuild is used for that instead

I'm using untranspiled .ts files directly from this repo (to access unexported symbols), and tsc emit errors since I enabled that option.

Done 👍🏻
But in the future I think it would be better to export the symbols instead of relying on the raw .ts files (could have breaking changes at any time)
Do you need specific ones? https://github.com/HarukaKinen/delance isn't available anymore

Do you need specific ones? [redacted] isn't available anymore

I migrated that to https://sr.ht/~self. :)


Updates for JupyterLab 1.0.0a1

No rush on this until 1.0 is actually released, but these are the updates to make it work.

Thanks!


feat: workflows python package and common container for them

Create a python package for our workflows code to standardize dependencies and code style. This allows us to share code between the workflows more easily as well. Created a common container for the workflows as well.

Not ready for full review but pinging @mfencik, @skrobul, @stevekeay and @micahculpepper to see if they're okay with the approach.

I used setuptools cause that's what the neutron plugin used but it's really my least favorite choice cause it makes test dependencies painful (see the GitHub Actions test). I'd prefer poetry or hatch. What say the reviewers?

I used setuptools cause that's what the neutron plugin used but it's really my least favorite choice cause it makes test dependencies painful (see the GitHub Actions test). I'd prefer poetry or hatch. What say the reviewers?

We also use poetry on other UC projects, can we replace the neutron plugin mechanism and standardise on poetry everywhere?


[Feat] Modification of README.md file

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to modify the following things in the README.md file:
1) Add animated line separators
Add animated line separators in between sections and also add the GSSoC 2024 Extended accepted image for Contributors to know that this repository is officially accepted for GSSoC contribution.

2) Replace the Contact section  with a Team section
The present Contact section in the README.md file is not looking attractive:

The Team section will look more organized and readable and let the Contributors know whom to contact if they face any issues.

Use Case
I want to modify the following things in the README.md file:
1) Add animated line separators
It will make the project organized and attractive.
2) Replace the Contact section  with a Team section
The Team section will be visually appealing for the Contributors and also help them know who to reach out when needed.
Benefits
I want to modify the following things in the README.md file:
1) Add animated line separators
I think adding this banner along with the animated lines will make it not only look more attractive but also increase the readability of the repository.
2) Replace the Contact section  with a Team section
The new Team section will look more organized and increase the readability and scalability of the project. This will make the project attractive as the Contributors would land on the README.md page first and see the Team section.
Priority
High
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC contributor
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

okay

@Luson045 While working , I noticed that the Contributor mention section is not updated.

I can try to automate the updation process since I am working on the README.md file. If you want me to work on that, please let me know.

This is how the Team Section is looking for you:

@rajdeepchakraborty-rc  okay tht would be great

@rajdeepchakraborty-rc okay tht would be great

@Luson045 Is this reply about the Contributor mention section?

Yes 👍🏻

Yes 👍🏻

@Luson045 Ok I will also work on that then. I would kindly ask you to assign the issue level2 since I am working on the automation too.

I have updated the banner section for both GSSoC and Hacktoberfest:

This is the updated Contributors mention section:

Before

After

I will open a PR shortly and let you know.

Closed this issue as accepted and merged in PR #403


[help-wanted] TypeScript/React get component props

Hi,
Is there a way to get my component's props in the function loadMoreItems ?
private _loadMoreItems() {
    console.log(this);

    //Get the datas from xhr, and save data to Redux
};

Hi @sanchobouillant. Could you expand on what you are trying to do please? When would you not already have access to your component's props (presumably a parent/nth-grandparent of the Waypoint)?

The console.log(this); return the Waypoint's object.
I'm new with React, maybe am I looking in the wrong place ?
I want to access to my component that render Waypoint and access to my props.

Right, but what I'm trying to understand is why you want to access them inside of the Waypoint? You already have access to them in the render method where you render the Waypoint. Ex:
class MyComponent extends React.PureComponent {
  handleLoadMore() {
    // Do something, such as load more items from a paginated list
  }

  render() {
    console.log(this.props); // This will give you all the props from the component rendering the Waypoint

    return <div><Waypoint onEnter={this.handleLoadMore} /><div>;
  }
}


MvpDelegateCallback does not exist

Version: Mosby v2.0.0:
According to documentation here:
http://hannesdorfmann.com/mosby/mvp/
There should be MvpDelegateCallback:

MvpDelegateCallback: Is an interface every MvpView in Mosby has to implement. Basically it just provides some MVP related methods like

Instead all delegate classes uses BaseMvpDelegateCallback<V, P>

You are right, the documentation is not up-to-date on this.
MvpDelegateCallback has been renamed to BaseMvpDelegateCallback in Mosby 2.0
I will update the docs.
thanks for reporting!
Vladimir Baryshnikov<EMAIL_ADDRESS>schrieb am Do., 19. Nov.
2015 22:56:

Version: Mosby v2.0.0:
According to documentation here:
http://hannesdorfmann.com/mosby/mvp/
There should be MvpDelegateCallback:
MvpDelegateCallback: Is an interface every MvpView in Mosby has to
implement. Basically it just provides some MVP related methods like
Instead all delegate classes uses BaseMvpDelegateCallback<V, P>
—
Reply to this email directly or view it on GitHub
https://github.com/sockeqwe/mosby/issues/101.

Thanks for quick response!
Btw, any reason why it should be Base and not the one in documentation?

Because in Version 2 I had to introduce ActivityNvpDegateCallback extends
BaseDelegateCallback and ViewGroupNvpCallback extends  BaseDelegateCallback
with some more some more specific methods for activity / viewgroup. I have
noticed that only Fragments use BaseDelegateCallback directly, for
consistency I should b introduce a FragnentDelegateCallback extends
BaseDelegateCallback
as well I guess
See documentation for all subclasses
http://hannesdorfmann.com/mosby/static/javadoc/com/hannesdorfmann/mosby/mvp/delegate/BaseMvpDelegateCallback.html
As already said this part of the documentation is needs an update
Vladimir Baryshnikov<EMAIL_ADDRESS>schrieb am Do., 19. Nov.
2015 23:03:

Thanks for quick response!
Btw, any reason why it should be Base and not the one in documentation?
—
Reply to this email directly or view it on GitHub
https://github.com/sockeqwe/mosby/issues/101#issuecomment-158212635.

As I can see it only have 2 direct interfaces that extend it:
BaseDelegateCallback:
-- ActivityMvpDelegateCallback
-- BaseMvpViewStateDelegateCallback
imo, old version would look much nicer without Base :)
Something like:
MvpDelegateCallback:
-- ActivityMvpDelegateCallback
-- ViewStateMvpDelegateCallback
but it is up to you, just my 2cents...
Unrelated question. Right now as I can see you are creating presenter in onViewCreated, but if you have fragment in your layout.xml file this probably will crash if you use something that is not yet created, to create your presenter. Let me know I can pull it into separate issue.

You are right, without Base it is definetly nicer. To be honest I can't remember what exactly the reason was to introduce Base as prefix. I will check the class hierarchy and check for the related git commit messages. maybe I guess I had a good reason for introducing Base, but can't remember why :smile:  or have changed opinion after having renamed it to Base but forgot to remove the Base prefix.
I will investigate on that.
Regarding onViewCreated(): Yes, please open another issue for that. Makes it easier for others to follow the discussion and avoids confusing sub-threads

want to know why there is a need to use weak references.
public abstract class MvpBasePresenter implements MvpPresenter {
private WeakReference viewRef;
@Override
public void attachView(V view) {  }
protected V getView() { }
protected boolean isViewAttached() {  }
@Override
public void detachView(boolean retainInstance) {   }
}
activity：When press the return key, “ondestory” is sure to be executed, so the “detachView” will be executed.

Renamed in 3.0


warning: code designed explicitly with the capability to change your app’s behavior or functionality after App Review approval

Like many people, I received this today:

Dear Developer,
Your app, extension, and/or linked framework appears to contain code designed explicitly with the capability to change your app’s behavior or functionality after App Review approval, which is not in compliance with section 3.3.2 of the Apple Developer Program License Agreement and App Store Review Guideline 2.5.2. This code, combined with a remote resource, can facilitate significant changes to your app’s behavior compared to when it was initially reviewed for the App Store. While you may not be using this functionality currently, it has the potential to load private frameworks, private methods, and enable future feature changes.
This includes any code which passes arbitrary parameters to dynamic methods such as dlopen(), dlsym(), respondsToSelector:, performSelector:, method_exchangeImplementations(), and running remote scripts in order to change app behavior or call SPI, based on the contents of the downloaded script. Even if the remote resource is not intentionally malicious, it could easily be hijacked via a Man In The Middle (MiTM) attack, which can pose a serious security vulnerability to users of your app.
Please perform an in-depth review of your app and remove any code, frameworks, or SDKs that fall in line with the functionality described above before submitting the next update for your app for review.
Best regards,
App Store Review

But I do not use Rollout.io,  I do not use JSPatch, I do not use weex: incubator-weex or weex-devtool-iOS,  I do not use javascript or javascript frameworks like React Native or Ionic, I do not use any of the quoted methods in my Swift 3 app.
The only dependency that I use with a method_exchangeImplementations in its source is... AFNetworking. Here is the list of all what I use:
pod 'MagicalRecord', '~> 2.3'
pod 'SSZipArchive', '~> 1.6'
pod 'TSMarkdownParser', :git => 'https://github.com/laptobbe/TSMarkdownParser.git', :branch => '3.x'
pod 'AFNetworking'
pod 'SwiftLint', '~> 0.16'
pod 'Toaster', '~> 2.0'
pod 'AdobeMobileSDK', '~> 4.13'
#(And [OpenEars](https://www.politepix.com/openears/))

Is it possible to provide a version of AFNetworking without method_exchangeImplementations?

Maybe consider using Alamofire if you are using Swift

How do you know AdobeMobileSDK isn't using some of them?

i think the pro is AdobeMobileSDK,maybe i was wrong😂

@zidaneno5 at the time we started the app, Alamofire made the move to stop support for iOS8 when using Swift 3. They re-introduced support for it months later, but we can't take the risk that, when moving to Swift 4, we lose support of iOS8 because of over-restrictive decisions made by AlamoFire.

m

My apologies. We had a non-pod dependency on Amap that I didn't notice earlier, and Amap just acknowledged using JSPatch.

@Coeur Excuse me, so, is it because of Amap include respondsToSelector etc. that app will be rejected?
Is AFNetworking ok to use in project?

yes, AF is OK, app was approved by Apple last week


ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE

Bug description
Using  process.setUncaughtExceptionCaptureCallback with tsx  throws the following error:
Error [ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE]: The `domain` module is in use, which is mutually exclusive with calling process.setUncaughtExceptionCaptureCallback()
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at new NodeError (node:internal/errors:399:5)
    at process.setUncaughtExceptionCaptureCallback (node:domain:134:15)
    at <anonymous> (min.ts:1:9)
    at Object.<anonymous> (c:\workspace\dbinstall\min.ts:1:58)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Object.F (C:\workspace\dbinstall\node_modules\tsx\node_modules\@esbuild-kit\cjs-loader\dist\index.js:1:941)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Module._load (node:internal/modules/cjs/loader:958:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:194:25)
----------------------------------------
Error: require(`domain`) at this point
    at node:domain:130:28
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/loaders:334:7)
    at requireBuiltin (node:internal/bootstrap/loaders:365:14)
    at node:repl:136:16
    at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/loaders:334:7)
    at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/loaders:270:10)
    at loadBuiltinModule (node:internal/modules/cjs/helpers:56:9)
    at ESMLoader.builtinStrategy (node:internal/modules/esm/translators:257:18)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:468:14) {
  code: 'ERR_DOMAIN_CANNOT_SET_UNCAUGHT_EXCEPTION_CAPTURE'
}

Reproduction
min.ts:
process.setUncaughtExceptionCaptureCallback(console.error);

tsx ./min.ts

Environment
System:
  OS: Windows 10 10.0.22621
  CPU: (6) x64 Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz
  Memory: 7.52 GB / 23.84 GB
Binaries:
  Node: 18.16.0 - C:\Programs\nodejs\node.EXE
  npm: 9.5.1 - C:\Programs\nodejs\npm.CMD
npmPackages:
  tsx: ^3.12.7 => 3.12.7

Can you work on a fix?

[ ] I’m interested in opening a pull request to address this issue.

:tada: This issue has been resolved in v4.15.1
If you appreciate this project, please consider supporting this project by sponsoring :heart: :pray:


[Recorder] After<EMAIL_ADDRESS>update, skipping the test fails with an error

sync skip; aborting execution error is thrown when a test is skipped programmatically!
That breaks things for .skip() method exposed from the recorder.
TODO: Swallow the error thrown by mocha, and report the test to be pending.
Related
https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#700--2020-01-05
https://github.com/mochajs/mocha/pull/4030
https://github.com/mochajs/mocha/pull/4083
/cc @nguerrera (Thanks for reporting)

More info:
Upon investigation, it appears to be that the failure happens only when the test is skipped in a nested describe block!!
To repro: b0955cac8d5be796599d9ebbcc7c25c8532e4a5b

SchemaRegistry is not blocked on this one, I've removed the nested describes.

Closing this since it is not relevant to recorder v2


Take only last 10 elements

I love your plugin, but my habit table is overflowing, therefore I suggest to show only last 10 elements. Thanks for your hard work.

I've added a plugin setting to customise the number instead. Please update to v1.4.0 and go to the plugin settings to customise the number.


Add comment for intentional duplicated monospace font

https://github.com/necolas/normalize.css/issues/480
https://github.com/necolas/normalize.css#pre-code-kbd-samp
I was confused until I found the answer, so it's better to add this missing comment ;)

:+1:

This should definitely be added. It's pretty obvious that there's confusion why it's there with it being asked at least 12 times now in: #196, #293, #295, #326, #328, #335, #346, #347, #374, #415, #476 and #480.

wow~

It will certainly reduce the number of issues opened by this. :+1:

@fritx, great work. Merged in 5daad01! @KIPdeKIP, @battaglr, there go all the easy issues to close. :stuck_out_tongue_closed_eyes:

@jonathantneal: awesome! If I can be of any help with the remaining issues, just let me know!

Thanks, @battaglr! I’m trying to resolve every PR from oldest to newest. If you want to tackle any one of them, let me know. Then we move onto issues.

Awesome!

Just bumped into this. Seeing duplicated default classes in optimized CSS files is unexpected, so I ended up here on investigating. A straight duplication is intentional comment next to monospace, monospace occurrences was better IMO to avoid confused users and erroneous error reports. Should an additional issue be created or could this still "fit" this 5yo one?


Push hasn't been delivered to the client device despite of the 200 status

Hello!
I've tried to send the push through the lib and got the 200 status without any errors using the next sample code:
var settings = new ApnSettings
                {
                    P8PrivateKey = "XXX",
                    P8PrivateKeyId = "XXX",
                    AppBundleIdentifier = "com.XXX.XXX",
                    ServerType = ApnServerType.Development,
                    TeamId = "XXX"
                };
                var apn = new ApnSender(settings, new HttpClient() {DefaultRequestVersion = new Version(2, 0) });
                var notification = new AppleNotification() { Payload = new AppleNotification.ApsPayload { AlertBody = "Server" } };
                var res = await apn.SendAsync(notification, id);

Here is my AppleNotification class:
public class AppleNotification{
        public ApsPayload Payload { get; set; }
        public class ApsPayload
        {
            [JsonProperty("alert")]
            public string AlertBody { get; set; }
        }
    }

Could you please assist me with this issue? Might it be due to the usage of MacOs?
Thanks in advance!

@prometheus-nikitaabrosimov My guess would be - there is something wrong with the app itself. Not sure if I can really help you with it. Check server type, app logs, payload..


Adopting noise 1.2.2

To solve issue #62

Rebasing after having merged the AppVeyor branch

Merge it in :)


[Feature request] ability to assign !@#$%^&*() symbols to a key.

I see in your code that key mapping corresponds to HID scan code standard. Is there way you can add a secondary keyboard map for the shifted keys? Namely the shifted number keys? Or does this have to be done using a macro? If so, what's the minimum time interval would I need to each key press and release?

that's how I did it (man I love this system so much) -
the default is 10 ms which seems like twice the speed of the core default lumbering macro, but pok3r seems faster still, I'm using 5ms

Ah, ok thanks. Are you using the Core as a daily driver? If so, mind sharing your keymap? Always looking for improvements. Here is mine.
And yes, I concur, TsFreddie's work here is phenomenal.

I was editing a bunch of times and everything was awesome but suddenly some things have stopped working, I was messing with adding a Pn layer so maybe that messes with the code,,
L1 is Colemak, L2 is not used, but it has errors now anyway, L3 is my macros, email addresses, addresses, phone numbers, my full name , etc.
L4 is qwerty and I use Fn ctrl, win, alt to switch layers ~~
https://photos.app.goo.gl/2GoQQgNxNARJgRvr5

There's a hard cap on how many macros you can have. Someone said 20, but I sometime only get 10.
I've been trying to find a workaround for quite some time now.
Here's what I (might) have now:
In the binary file, each macro have a index number. And the firmware reject a macro if its index exceed certain number. But iirc, a key bind to a memory offset instead of the index.

And yes, since the key only bind to hid key code, macro is the only way to input special characters. And yet Vortex didn't provide enough macro space for us to use.

Ah, I see - after some messing around - I have gotten the layers to work 100%
Yeah - I had to remove some things because after a certain number of macros they just did nothing ~ but all is well, i have actually put most things I need on 1 layer thanks to the Pn layer, and removing some not-so-needed stuff ~
Thank you for the work - it's the best !!!


No sound on Fedora Linux 31 host from Windows 10 guest with Scream with IVSHMEM and pulseaudio..

I follow the instructions as stated, and am not getting any sound from pulseaudio. /dev/shm/scream-ivshmem is created on VM boot, but is an empty file and remains so even during audio playback with the Scream WDM listed as speakers in windows.
I think something is preventing it from writing to the IVSHMEM file.
[korey@hydra a]$ cat /dev/shm/scream-ivshmem
The above gives me no output at all. However, in my Windows VM I tried Red Hat's "ivshmem-test.exe" in virtio-win10-prewhql-0.1-161 and catting again gave me expected garbage binary output.
Otherwise I'm too tired and completely stumped on this one.

I know you said you followed the instructions as stated, but have you set the UseIVSHMEM registry key with a value equals to the size of the IVSHMEM device?

After triple checking I see that I named it as a QWORD rather than a DWORD. I'm not very familiar with Windows and should probably get new contact lens.
Appreciate the help! I was starting to think it was SELinux or something.


Unable to run the apk files (downloaded online example: facebook,gmail) using emulator

Hello,
As I am very new to selendroid, I want to run an .apk file in the emulator and locate the elements and below is the problem which I am facing

Able to see the installed application icon in the emulator but unable to run it. when manually clicking on the icon in the emulator its not opening and crashing.
Followed the solution provided in the link [https://github.com/selendroid/selendroid/issues/483] but its not working
Is it possible to run and locate the elements of the .apk files (downloaded from internet) through selendroid in the emulator

Below is the code which I am using
Code:
import io.selendroid.SelendroidDriver;
import io.selendroid.common.SelendroidCapabilities;
import io.selendroid.common.device.DeviceTargetPlatform;
import org.openqa.selenium.WebDriver;
import org.testng.annotations.AfterTest;
import org.testng.annotations.Test;
public class Gmail {
private WebDriver driver;
@Test
public void test() throws Exception{
	SelendroidCapabilities capa = new SelendroidCapabilities("com.google.android.gm:4.8 (1167183)");
	driver = new SelendroidDriver(capa);

	capa.setPlatformVersion(DeviceTargetPlatform.ANDROID21);
    capa.setEmulator(true);

	System.out.println("Testing Gmail --");

	Thread.sleep(50000);

}

@AfterTest
public void close() {
	driver.quit();
}

}
Error Log:
FAILED CONFIGURATION: @AfterTest close
java.lang.NullPointerException
FAILED: test
org.openqa.selenium.SessionNotCreatedException: Error starting Selendroid session
Console:
Can't connect to selendroid server, assuming it is not working
Thanks in advance ..

This is a question rather than an issue. Please send questions to the selendroid user group.
For issues please provide a concise reproducible test case and describe what results you are seeing and what results you expect.

Thanks for the info


bug: GraphQL context not propagated to data loaders

Hi, we are trying to migrate to the new DGS Spring Boot starter (graphql-dgs-spring-graphql-starter). One problem we cannot overcome is this - we have GraphQLContextContributor storing the value into GraphQL context for further usage like this (simplified):
@Component
class EntityContextContributor: GraphQLContextContributor {
    override fun contribute(
        builder: GraphQLContext.Builder,
        extensions: Map<String, Any>?,
        requestData: DgsRequestData?,
    ) {
        builder.put("foo", "some-value")
    }
}

Next we have batch data loader defined like:
    @DgsDataLoader(name = "entities")
    class BatchEntitiesDataLoader(private val dataLoaderExecutor: Executor) : MappedBatchLoaderWithContext<String, String> {
        override fun load(
            keys: Set<String>,
            environment: BatchLoaderEnvironment,
        ): CompletionStage<Map<String, String>> {
            return CompletableFuture.supplyAsync(
                {
                    environment.getContext<GraphQLContext>.get<String>("foo")
                },
                dataLoaderExecutor,
            )
        }
    }

Which is invoked via
    @DgsData(parentType = "Entity", field = "someField")
    fun entitySomeField(dfe: DgsDataFetchingEnvironment): CompletableFuture<String> {
        val loader = dfe.getDataLoader<String, String>(BatchEntitiesDataLoader::class.java)
        return loader.load(dfe.getSource<Entity>().id)
    }

Until now this has worked nicely and we could access the stored context value for key foo in the batch loader, but after switching to the new starter, the loader environment has now an different, empty GraphQL context which doesn't contain the value stored in the context contributor (we made sure the contributor is invoked and actually stores the value to the context it is accessing).
Expected behavior
The GraphQL context is properly propagated to the BatchLoaderEnvironment and we can access the value stored in context contributor.
Actual behavior
The BatchLoaderEnvironment has different, empty GraphQL context.
Steps to reproduce
See above
Is this a bug, or are there some changes required after switching to the new starter?

@njuro Just confirming that we've identified the issue and are working towards a fix. We might need to make changes in Spring GraphQL, so the fix might take a little longer.

Fixed by #2067


Tunnel client TLS to gateway using mTLS issue

Bug Description
[ Istio 1.13.4 ]
I'm trying to get a client-originated TLS connection to tunnel to an egress gateway using Istio mTLS so that AuthorizationPolicy can be applied in the gateway to permit authorized workloads to connect to the hosts managed by the gateway. Istio-originated TLS at the gateway works fine but in this use-case I need client-originated to work.
The flow I'd like to achieve is this:
client ->(TLS)-> envoy ->(mTLS-over-TLS)-> gateway ->(TLS)-> external host

Firstly, passthrough TLS (without mTLS) is working fine and I can see from the client and gateway logs that the call is correctly routed but obviously there is no mTLS so no possibility to authorize the calling workload at the gateway. For reference, here's my starting passthrough configuration that works:
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  name: istio-egress-int-https
  namespace: istio-egress-int-https
spec:
  selector:
    istio: egressgateway
  servers:
    - hosts:
      - andybrown.me.uk
      port:
        number: 443
        name: tls-passthrough
        protocol: TLS
      tls:
        mode: PASSTHROUGH
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: andy-gateway
  namespace: istio-egress-int-https
spec:
  host: istio-egress-int-https.istio-egress-int-https.svc.cluster.local
  subsets:
  - name: andy
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: andy
  namespace: istio-egress-int-https
spec:
  location: MESH_EXTERNAL
  hosts: [ "andybrown.me.uk" ]
  ports:
  - number: 443
    name: tls-andy
    protocol: TLS
  resolution: DNS
---
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: andy
  namespace: istio-egress-int-https
spec:
  hosts:
    - andybrown.me.uk
  gateways:
    - mesh
    - istio-egress-int-https
  tls:

    - match:
        - gateways:
            - mesh
          port: 443
          sniHosts:
            - andybrown.me.uk

      route:
        - destination:
            host: istio-egress-int-https.istio-egress-int-https.svc.cluster.local
            subset: andy
            port:
              number: 443

    - match:
        - gateways:
            - istio-egress-int-https
          port: 443
          sniHosts:
            - andybrown.me.uk

      route:
        - destination:
            host: andybrown.me.uk
            port:
              number: 443
          weight: 100

To upgrade to mTLS between the client and the gateway I tried to change the gateway server to ISTIO_MUTUAL and again for the port in the gateway's DestinationRule like this:
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  name: istio-egress-int-https
  namespace: istio-egress-int-https
spec:
  selector:
    istio: egressgateway
  servers:
    - hosts:
      - andybrown.me.uk
      port:
        number: 443
        name: tls-passthrough
        protocol: TLS
      tls:
        mode: ISTIO_MUTUAL
---
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: andy-gateway
  namespace: istio-egress-int-https
spec:
  host: istio-egress-int-https.istio-egress-int-https.svc.cluster.local
  subsets:
  - name: andy
    trafficPolicy:
      loadBalancer:
        simple: ROUND_ROBIN
      tls:
        mode: ISTIO_MUTUAL
        sni: andybrown.me.uk
---
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: andy
  namespace: istio-egress-int-https
spec:
  location: MESH_EXTERNAL
  hosts: [ "andybrown.me.uk" ]
  ports:
  - number: 443
    name: tls-andy
    protocol: TLS
  resolution: DNS
---
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  name: andy
  namespace: istio-egress-int-https
spec:
  hosts:
    - andybrown.me.uk
  gateways:
    - mesh
    - istio-egress-int-https
  tls:

    - match:
        - gateways:
            - mesh
          port: 443
          sniHosts:
            - andybrown.me.uk

      route:
        - destination:
            host: istio-egress-int-https.istio-egress-int-https.svc.cluster.local
            subset: andy
            port:
              number: 443

    - match:
        - gateways:
            - istio-egress-int-https
          port: 443
          sniHosts:
            - andybrown.me.uk

      route:
        - destination:
            host: andybrown.me.uk
            port:
              number: 443
          weight: 100

Now I get an error in the client pod when I test it with curl:
curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to andybrown.me.uk:443

A log entry appears in the client envoy container:
[2022-05-31T17:57:36.941Z] "- - -" 0 UF,URX - - "-" 0 0 11 - "-" "-" "-" "-" "<IP_ADDRESS>:8443" outbound|443|andy|istio-egress-int-https.istio-egress-int-https.svc.cluster.local - <IP_ADDRESS>:443 <IP_ADDRESS>:52822 andybrown.me.uk -

Nothing appears in the gateway logs so I increased the client envoy logs to debug and saw this when a connection attempt is made by the client:
envoy filter    tls inspector: new connection accepted
envoy filter    tls:onServerName(), requestedServerName: andybrown.me.uk
envoy filter    [C12783] new tcp proxy session
envoy filter    [C12783] Creating connection to cluster outbound|443|andy|istio-egress-int-https.istio-egress-int-https.svc.cluster.local
envoy misc      Allocating TCP conn pool
envoy pool      trying to create new connection
envoy pool      creating a new connection
envoy connection        [C12784] connecting to <IP_ADDRESS>:8443
envoy connection        [C12784] connection in progress
envoy conn_handler      [C12783] new connection from <IP_ADDRESS>:52872
envoy connection        [C12784] delayed connect error: 111
envoy connection        [C12784] closing socket: 0
envoy connection        [C12784] TLS error: 268435588:SSL routines:OPENSSL_internal:CLIENTHELLO_TLSEXT 268435646:SSL routines:OPENSSL_internal:PARSE_TLSEXT
envoy pool      [C12784] client disconnected, failure reason: delayed connect error: 111
envoy filter    [C12783] Creating connection to cluster outbound|443|andy|istio-egress-int-https.istio-egress-int-https.svc.cluster.local
envoy connection        [C12783] closing data_to_write=0 type=1
envoy connection        [C12783] closing socket: 1

I have verified that <IP_ADDRESS> is the pod IP of the egress gateway. This is where I'm stuck. Can anyone advise on what I need to configure to make this work? I've shown just one target host here but the solution needs to be extendable for multiple external hosts through this gateway.
Version
$ istioctl version
client version: 1.13.4
control plane version: 1.13.4
data plane version: 1.13.4 (10 proxies)

$ kubectl version --short
Client Version: v1.24.0
Kustomize Version: v4.5.4
Server Version: v1.24.0

Additional Information
No response

Investigating further it seems that the gateway only accepts a tls mode of ISTIO_MUTUAL if its server port protocol is HTTPS.
If I set it as HTTPS then the call is accepted by the gateway but of course fails because the gateway expects to see plaintext HTTP once its decrypted the mtls session. As soon as I switch the gateway port protocol back to TLS then I'm back to the CLIENTHELLO_TLSEXT 268435646:SSL routines:OPENSSL_internal:PARSE_TLSEXT error.

This should work. You shouldn't need to set HTTPS. I'd like to try it out myself but don't have access to a cluster currently. It looks like the TLS handshake is failing which is unexpected


Fix #1093: Improve dcf_info tool to optionally dump file contents.

See associated Issue for description.
Tim told me he's also working in this area, so I can close this as unnecessary if an improved workflow is incoming.

FYI @yiqunw700

Thanks @rylin8 for moving on this quickly.
I've been running this on some additional docs and am really pleased with the results. Allows me to find info I'm looking for very quickly.
Some examples:
cargo run --bin dcf_info --features="dcf_info" -- ./integration-tests/validation/build/intermediates/assets/debug/mergeDebugAssets/figma/LayoutTestsDoc_Gv63fYTzpeH2ZtxP4go31E.dcf -n "#stage" | tee layout.stage.output.txt

cargo run --bin dcf_info --features="dcf_info" -- ./integration-tests/validation/src/main/assets/figma/FancyFillTestDoc_xQ9cunHt8VUm6xqJJ2Pjb2.dcf -n "#stage" | tee fancy.fills.stage.output.txt


Upgrade to use Tokio 1.0

Change tokio::io::PollEvented to tokio::io::unix::AsyncFd

Update streamlisten example

Fix clippy needless_lifetimes lint

I think CI is failing because Tokio minimum supported version is 1.45 and CI uses 1.40.

Great, thanks for the PR!

@DanielRussell https://github.com/ebfull/pcap/issues/187 ?


[meshery] Support KinD doc

Signed-off-by: Aisuko<EMAIL_ADDRESS>
Description

This PR fixes #526
Notes to reviewers
Checklist

[x] Signed commits.
[x] PR title includes [<name of area>]:<description>

Goood! A new line item in Meshery main Readme is appropriate as well.

I'd like to add the label to split the issue by type and trigger the CI [backend UI]. Because every PR the CI jobs all run to test, there may no sense

Thanks, @Aisuko. Please add KinD to the list of supported platforms in the meshery repo readme.

Thanks for helping me update the Readme.

Teamwork. 😄


DynamoDB instead of  MongoDB

I am planning on using AWS lambda to run MEANJS platform, will i be able to integrate dynamoDB instead of MongoDB to run my application

You will have to go through and convert everything from MongoDB ro DynamoDB but it should be relatively easily to convert.


Update kumoh.txt

Update the college name, no longer contains 'University'.

University official website URL http://kumoh.ac.kr
IT-related course http://eng.kumoh.ac.kr/e_new/submenu02/_academics.php?p=g-IT_Convergence_Engineering.php

@feber Thank you for the update! Pull request merged.


Add RPM integTest support on Jenkins for systemd images with non-root sudo support

Signed-off-by: Peter Zhu<EMAIL_ADDRESS>Description
Add RPM integTest support on Jenkins for systemd images with non-root sudo support
Issues Resolved
#3190
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3191 (e3f939d) into main (00340d2) will decrease coverage by 0.31%.
The diff coverage is n/a.

:exclamation: Current head e3f939d differs from pull request most recent head 71db069. Consider uploading reports for the commit 71db069 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #3191      +/-   ##
==========================================
- Coverage   93.20%   92.90%   -0.31%
==========================================
  Files         167      167
  Lines        4622     4622
==========================================
- Hits         4308     4294      -14
- Misses        314      328      +14

Impacted Files
Coverage Δ

src/system/temporary_directory.py
64.44% <0.00%> (-28.89%)
:arrow_down:

src/system/os.py
94.73% <0.00%> (-5.27%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

LGTM!


RuntimeError: Detected that PyTorch and torchvision were compiled with different CUDA versions.

kohya-LoRA-finetuner.ipynb
4.2.1. BLIP Captioning
RuntimeError: Detected that PyTorch and torchvision were compiled with different CUDA versions. PyTorch has CUDA Version=11.7 and torchvision has CUDA Version=11.6. Please reinstall the torchvision that matches your PyTorch install.

try  !pip install torchvision==0.14.1   is ok


tutorial windown

improve header: Accept or deny chat requests
improve body: This icon let's you manage your requests and active chats.
add (centered) PNG of "dialogue list" icon

Improved body: Manage your requests and active chats in the dialogue list.


[Codegen][GPU] Add tiling interface implementation for iree_gpu.multi_mma

The tiling interface for iree_gpu.multi_mma only exposes the outer
dimensions for tiling (as reflected by the indexing maps/iterator
types). By adding a tiling interface implementation we can convert to
the operation earlier in the lowering pipeline.

I believe the test failures were caused by https://github.com/iree-org/iree/commit/82012e6


Logo: proportions and shadows

Logo’s proportions violate the original design, as the right side was made larger for readability but the left side remains the same size. Task: investigate whether we can keep the original logo, and if not provide an updated logo design in SVG here and use it on the site.
Shadows are lost due to CSS override used to invert SVG color (make it white so that it works on darker background). Need to maintain shadows, either with a smarter CSS override if possible or by creating a separate white logo version.

(Got fixed almost before I filed it.)


Invalid index name [.kibana_8.0.0-SNAPSHOT_001], must be lowercase

Chart version:
elastic/kibana           	7.12.0

Docker Image
image: "docker.elastic.co/kibana/kibana"
imageTag: "8.0.0-SNAPSHOT"

Helm Version:
version.BuildInfo{Version:"v3.3.1", GitCommit:"249e5215cde0c3fa72e27eb7a30e8d55c9696144", GitTreeState:"dirty", GoVersion:"go1.15"}

I have the issue with create proper index:
{"type":"log","@timestamp":"2021-03-29T17:14:46+00:00","tags":["error","savedobjects-service"],"pid":6,"message":"[.kibana] [invalid_index_name_exception]: Invalid index name [.kibana_8.0.0-SNAPSHOT_001], must be lowercase"}
{"type":"log","@timestamp":"2021-03-29T17:14:46+00:00","tags":["error","savedobjects-service"],"pid":6,"message":"[.kibana] migration failed, dumping execution log:"}

How can I set a custom index name for this case?

Hi @botzill,
8.0.0-SNAPSHOT images are for development tests only. Any specifc reason why you're not using the default 7.12.0 image?

Well, just to be update and test with 8
On Mon, Apr 12, 2021, 6:43 PM Julien Mailleret @.***>
wrote:

Hi @botzill https://github.com/botzill,
8.0.0-SNAPSHOT images are for development tests only. Any specifc reason
why you're not using the default 7.12.0 image?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elastic/helm-charts/issues/1132#issuecomment-817917887,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDYBWBL7TQMYJNDLUIW54LTIMIKHANCNFSM42AAM5JA
.


Unity Web GL Support?

I loaded the Scatter Sharp example scene in Unity. I've been playing around with the project and tested it on several platforms: OSX, Windows, and WebGL. The OSX and Windows builds worked without issue, but it seems that WebGL has issues connecting to Scatter through socket. Has there been testing done with Web GL already? If so, is there a build configuration that works?  Is Web GL a build target Scatter is interested in supporting?

Good news! I just released scatter-sharp 2.0 that should support WebGL
https://github.com/GetScatter/scatter-sharp/releases/tag/v2.0.0
Have fun!


⚠ Bofrost.nl has degraded performance

In e6ceae0, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1678 ms

Resolved: Bofrost.nl performance has improved in 96fbcfa.


Improve Readme and have code examples

This library is practically unusable because I don't know where to start. The Readme is clogged full of useless information that means nothing to 99% of users and there is no copy and paste-able code snippets. I shouldn't have to read all the docs and stuff to get started.
To make this worse, when I try out the live demos I can't easily access the code? I have to either use the inspector or dig through the repo to find the demo code. For example https://sheetjs.com/demo/table.html Why isn't there a giant button linking to the source code on this page. Like why even have live demos for a JS library if you're not going to reference or display the source code?
After about 5min I just gave up, wrote this, and started looking for another library that's easier to get started with. I'm a professional web dev of 8 years, I'm not some Jr. dev fresh off a 2-week coding corse. See for a good readme: https://github.com/Ideea-inc/vipfs
https://github.com/Ideea-inc/teleport-js

The fact that issue #817 exists proves my point....

PRs welcome :)
The documentation is intended to describe the hard details (API, mapping from spreadsheet concepts to SheetJS data structures), while the demos try to provide smaller examples of both usage and integration.  For example, the Chrome / Chromium demo shows the details of setting up a simple extension as well as how to invoke library functions from the relevant contexts.
If there's some specific problem you're trying to solve, raise an issue and we can discuss how to improve the documentation.

 It's far easier for you to close this than actually fix the issue.
Your response doesn't even address my points (did you even read what I wrote?). Who cares about the "hard details", they are way too high-level to go into the Readme, most users just want to know what the npm install command is and a simple code snippet. I'm not saying you can't have both..
 My whole issue here is no easily copy and paste-able code blocks. There is 5 code-blocks on that page, none can be copied in their entirety.
It's your repo, manage it however you want but its clear that other people are having this issue (#871, 3 years ago) and it will just put people off what looks like a good package, you've just gone out of your way to make it difficult to use IMO.

The tone here is wholly inappropriate for an open source project.  No one gets paid to work on the open source project, it is Apache 2.0 licensed which means we don't have a backdoor to force people to pay.  As far as we're concerned, it's a charitable effort.  If you're willing to put in the time to improve docs, or willing to pay for that to happen, great; otherwise, the complaint smacks of entitlement, the same type of entitlement that drove countless people to leave the open source community or relicense projects as proprietary.


Can you export import dfi in folder specific format?

Now if you have dfi with folders in DeepSee it exports like:
folderA-FolderB-Name.dashboard.dfi
Would be great to have:
src/
dfi/
FolderA/
FolderB/
name.dashboard.dfi

use solution from issue #1


Implement auth component for Svelte

The thin-backend-react/auth-ui.tsx module should be ported to Svelte to thin-backend-svelte, so that we can provide in-app login in Svelte apps as well 👍

Mitosis may be a good solution this issue, #32, and #35 as well.
Not affiliated with them, but I would like React Native support.
All frameworks could possibly be supported easily this way.

Thanks for pointing out. We've actually looked into Mitosis already :) It's working well for simple components, but more complex functionality still requires manual adjustments.
There's an expo template here btw: https://github.com/digitallyinduced/ihp-backend-expo-starter It might be a bit oudated, but it's definitly possible to run Thin with React Native already.


Using npx svelte-add@latest scss breaks vite

Hello,
I started a new project with svelte kit and when configuring it I selected the TypeScript option. I then added scss using the svelte-add and everything stopped working, vite was just serving a 404 page.
After a bit of trial and error I noticed that under vite.config.ts i have a vite.config.js

Containing the following code:
const config = {
	css: {
		preprocessorOptions: {
			scss: {
				additionalData: '@use "src/variables.scss" as *;'
			}
		}
	}
};

export default config;

Deleting this file results in the app being served again.

I was pulling out (metaphorically because I completely bald these days) my hair.  Was getting ready to give up.  Thanks for sharing this solution!  At first I didn't know why I was throwing the important analysis errors in the main App.svelte file and I was going down a rabbit hole.  Eventually figured out it happened after using svelte-add and ended up here.  I had a vite.config.js right under mine too that I didn't see.

Duplicates #234

Will be fixed by #234 soon


Question about Performance with > 1000 items inside panzoom element

Hi,
We are building an app with React that needs to have up to 3000 items inside Panzoom component. So for now I am trying to optimize panning with 1000 items and I'm not really sure how to reach 30-60fps.
Here is the example: link
I am using SVGs as icons in the project so I added them for a reason. I am most concerned about the state when I am max scaled out, especially in Firefox where I experience the most lag.
Do you have any recommendations on what approach should I take in order to improve performance?
Also, thanks for lib, expect donations if everything goes as we expect to with the project 🙂.
Edit: Better explanation
I am not 100% sure if this issue is caused by this library or in general browsers are not supposed to handle that amount of items at once. We are creating some sort of roadmaps that are going to have at some point 1000+ items(that's a possible scenario).
What I have tried already:

I've tried to promote panzoom element on its own composite layer with will-change: transform and when I am max scaled out in chrome I can see large performance improvements but unfortunately in Firefox will-change is not helping.
Also, I am considering implementing data-virtualization but again when max scaled out with ~1000 elements in viewport it won't help.
I tested custom keyframe animation(without panzoom element) that simulates panning with 1000 items(example here) and in Chrome i can get 30-60fps but in firefox only 10-20fps. So thats why I didn't label this as a bug.

We have concluded that transform: translate() is not performant with large data sets when scaled out, especially in Firefox. So we decided that instead of transform we are going to use scroll bars as a custom panning approach as it turns out that performance is much better across all browsers.


Lychee not detecting markdown files

I am running Lychee as a GitHub action on https://github.com/balena-io/docs/, Lchee's GitHub action got updated v1.2.0 which lead to the pattern **/*.md failing.
For some reason, this in the file https://github.com/balena-io/docs/blob/master/.github/workflows/link-checker.yml
with:
           args: >
             --config ./lychee.toml
             --github-token ${{ secrets.GITHUB_TOKEN }}
             **/*.md

translates to just finding 2 markdown files in the repository when the action is running. Refer: https://github.com/balena-io/docs/runs/4626369590?check_suite_focus=true#step:5:19
lychee --format markdown --output /tmp/lychee/out.md --config ./lychee.toml --github-token *** pages/404.md shared/icon.md

I am trying to debug if there is something on our end that changed or is it Lychee's action update that caused this. I ran Lychee locally to confirm the pattern lychee --no-progress --config lychee.toml  **/*.md and that worked just fine. Do let me know if you need any more information to help debug this further.

This issue might have been better off in https://github.com/lycheeverse/lychee-action/issues instead. I thought I was opening it there, can admins transfer this to the other repository.


UX Improvement: Make user aware that Open AI Key is necessary

Description
If you try to click the "Generate" button and do not provide a Open AI Key, nothing happens.

Possible solutions

Create root page to accept the Open AI Key before accessing the map route
Alert user when Open AI key is not provided
2.1. Dialog
2.2. Form error

We must discuss more about the possible solutions and, if you don't mind, I'm interest on working in this issue.

@esau-morais For sure, that really helps!

Resolved with the changes within #3


add docker image for ownCloud

Got a good start with servers/owncloud-server in the dev branch
 php console.php maintenance:install --admin-user alice --admin-pass alice123

Add 1 => 'oc1.docker', on line 9 of config.php
Maybe just have one docker image per host, and use USER www-data in the Dockerfile, that would make it all quite easy and basically reduce run-time configuration steps to zero.

Done


Adjust eureka health check URLs for all services registered with eureka including prediction and tensorflow service

defer.  using kubernetes health check mechanism.


[Enhancement] Add MSI support for Installers.

Most local games come with an EXE. However, I have just one game where the installer is in the MSI format.
Something to consider since I am the first to request this and literally only have one game that has its installer as an MSI file lol, but it might be useful for some.

Looking into this.  I'll have to see what the process run is like for MSI files.  Shouldn't be too much work, I don't think.

If it helps, the command to run an MSI file in powershell or cmd is msiexec /i installer.msi Of course, installer.msi would be the full path to a real MSI installer.


This project is abandoned

There are quite a few issues being reported that are not answered, and the code is not maintained.
Specifically, #115 asking about the state of this project is not answered in over a year.
I am currently using this project, so I am considering forking it.
Alternatively, @davidebianchi could appoint some contributers.

Hey @holmrenser , yeah, unfortunately we don't have time anymore to maintain this library (and we're not actively using it). We can consider giving write access to outside contributors. If you're interested we can arrange that. Let me know

It is surprising that it was mentioned in article https://medevel.com/meteor-ddp-nextjs/
Useful links for people reading this issue:

Announcement of DDP 2012 - https://blog.meteor.com/introducing-ddp-6b40c6aff27d
simpleddp last update 4 years ago - https://github.com/Gregivy/simpleddp
forum topic may 2023 - https://forums.meteor.com/t/alternative-to-asteroid-as-a-ddp-client-for-meteor-backend/59948
ddp.js last update 6 years ago -<EMAIL_ADDRESS>meteor for react native 3 months ago - https://www.npmjs.com/package/@meteorrn/core
meteor for react  3 months ago - https://www.npmjs.com/package/@nyby/meteor-react-js


Move all elements to single package

This repo will remain a monorepo, BUT, all the elements will be in a single package
Goal 1: @patternfly/elements
pfe-tools will likely need to be updated to accommodate this change, and those changes to pfe tools will have to be validated against rhds
Goal 2: Remove esbuild from element build chain
currently, each element package builds sources into javascript with tsc, but then deletes those runtime files and rebuilds them with esbuild. This is so that we can inline the scss sources.
Instead, we should use a ttsc plugin to accomplish the same thing, and make tslib a dependency.
See https://github.com/RedHat-UX/red-hat-design-system/blob/main/transformers/css-import-specifiers.cjs and https://github.com/RedHat-UX/red-hat-design-system/blob/main/scripts/transform-css.js
We can still use esbuild to bundle the whole package into pfe.min.js
Goal 3: Remove or port all elements
There should not be any elements in /elements which aren't PF 1:1, so delete or port these:

pfe-band (#2290)
pfe-select (#2145)
pfe-dropdown (#2049)
pfe-autocomplete (#2115)
pfe-progress-steps (#2052)

Would it be worth moving pfe-tools into it's own repo or is it simpler to keep them together and just package it separately from the elements?

We'd have to do that for a number of packages, not just pfe-tools, as well as the core packages.
For that reason, I think it's best to retain the monorepo infra here, but combine the elements info a single package

Closed by #2316


Create a shared Gateway for Ingresses that share a wildcard certificate

We need to handle wildcard certificate specifically because of the Istio limitation https://istio.io/docs/ops/common-problems/network-issues/#404-errors-occur-when-multiple-gateways-configured-with-same-tls-certificate when browser leverages HTTP/2 connection reuse.
This is to fix: https://github.com/knative/serving/issues/7495

/assign @tcnghia
/assign @nak3

/test pull-knative-net-istio-latest

LGTM except for one nit.
(leave without lgtm label for @tcnghia and other reviewers.)

/test pull-knative-net-istio-integration-tests

/lgtm


Updated Management.ServiceFabric models for API version 2018-02-01

Description

https://github.com/Azure/azure-rest-api-specs/pull/2844
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@juhacket please fix the build errors in test projects.

Gentle reminder

@dsgouda We have delayed this change until the REST API specification PR is merged.

@juhacket can you reopen this PR once you are ready to merge the PR.
Also please do not open SDK PR before the REST spec PR is merged.


Fix flaky integration test TestDynamicNamespaceDelete

The test was flaky because it was relying upon the behavior the Snapshot() functionality of the tally library.
The Snapshot() function in tally will return counter values, but only those that occurred since the last flush/report.
As a result, the test would sometimes fail due to the following race:

Dynamic namespace watcher receives new value from KV
Namespace watcher calls Inc(1) on "invalid-update" metric
Tally "Scope" object reports metrics to reporter
We called Snapshot() to check if the counter has incremented yet, but it returns 0 indefinitely because the metric has already been reported and is thus unavailable via the Snapshot() call

This PR fixes the race by relying on the TestStatsReporter instead of Snapshot(). Since the TestStatsReporter receives every report, it can keep track of every metric and the race is no longer an issue.

Coverage decreased (-0.02%) to 78.319% when pulling 88c940e4717e9c287c83e4879c3cdad0afbd8a33 on richardartoul:ra_debug_namespace_delete into a2c7092d7d9c219f4b2f51f1adb6a291d6228fcb on m3db:master.


(enhancement) Redshift: Adding 'primary_keys' to parameter validation

Enhancement

Redshift: Adding 'primary_keys' to parameter validation

Relates

#1726

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 64a385a15ae3f6593083f9ddce4d74f32dec3296
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 2af4e81d2fa1d403a011c849cd83886307b8a19c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: fa39a185a39d834f9af4f01edb10362160b92e6b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Lazy loaded component life cycle hooks are not getting called!

constructor() {
//This is called during the load
    console.log('constructor called!');
  }

  ngOnInit() {
//This is not called
    console.log('ngOinit');
  }

I found a fix and planning to pull request for the same!


[SPARK-35497][PYTHON] Enable plotly tests in pandas-on-Spark

What changes were proposed in this pull request?
This PR enables plot tests with plotly
./python/run-tests --python-executables=python3 --modules=pyspark-pandas

Before:
Traceback (most recent call last):
  File "/.../miniconda3/envs/python3.8/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/.../miniconda3/envs/python3.8/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/.../pyspark/pandas/tests/plot/test_frame_plot_plotly.py", line 42, in <module>
    plotly_requirement_message + " Or pandas<1.0; pandas<1.0 does not support latest plotly "
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

After:
...
Starting test(python3): pyspark.pandas.tests.plot.test_series_plot_plotly
...
Finished test(python3): pyspark.pandas.tests.plot.test_series_plot_plotly (23s)
...
Tests passed in 1296 seconds

Why are the changes needed?
For test coverage.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
By running the tests.

cc @ueshin @xinrong-databricks @itholic

Test build #138864 has started for PR 32649 at commit 0c87c07.

Test build #138865 has started for PR 32649 at commit 48d9da5.

Test build #138864 has finished for PR 32649 at commit 0c87c07.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #138865 has finished for PR 32649 at commit 48d9da5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43386/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43387/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138864/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138865/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43386/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43387/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43387/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43386/

Test build #138894 has started for PR 32649 at commit 57ef92e.

Test build #138894 has finished for PR 32649 at commit 57ef92e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43416/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138894/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43416/

Merged to master.


Link in "automatically closed need" to tell node to not close this post again (for a year).

Some posts just don't get a lot of matches but are really long-term.

No Longer relevant since we do not autoclose any needs anymore