Light library version suitable for addons

I wanted to explore using this library in a Firefox addon. It loads and works just fine which is rather surprising since few do without additional hacking.
However, Mozilla's validator complains about a few severe issues that prevent automatic signing:

Access to the Function global
Warning: Evaluation of strings as code can lead to security vulnerabilities and performance issues, even in the most innocuous of circumstances. Please avoid using eval and the Function constructor when at all possible.
  /*eslint-disable no-new-func*/
  return new Function(params, source.slice(body[0] + 1, body[1] - 1));
}

setTimeout called in potentially dangerous manner
Warning: In order to prevent vulnerabilities, the setTimeout and setInterval functions should be called only with function expressions as their first argument.
}
var timeout = setTimeout(cleanUpNextTick);
draining = true;

if (!draining) {
    setTimeout(drainQueue, 0);
}

All eval-type constructs are evil and are not accepted in Google Chrome either AFAIK (CSP). Personally, I don't see a sane use case for such atrocities in a YAML library, of all things, but I'm sure that it's my limited imagination that is in the wrong here.
Anyway, it would be lovely to have a 'light' version without these attack vectors. My first impression was that one does not simply remove those exports since they are dependencies for others...

settimeout is not used at all, and fn constructor is used only in unsafe load for appropriate data type. If you don't use it, CSP will not be a problem. There is nothing to fix.

Funny conclusion.
Add-on validation is a crude static analysis, you see. This library is not usable since those LOCs are flagged and prevent automatic add-on signing.  So this is a problem and it is 'something to fix'.

I'm not familiar with analyzer you use and what you analyzed. This info is a bit useless to do anything. If you need any actions - please refer to lines that cause problems.

It's not what I use that matters. It's all about Mozilla. They did make an npm package yesterday but it's broken for me. In any case you can use the web interface.
What 'I analyzed' is my add-on with your library injected. I think you can take any xpi file from addons.mozilla.org and just append it to them (xpi=zip) to test.
Here's a screenshot if you don't believe me: http://i.imgur.com/aIPp1Aj.png

Could you explain how do you include this package into your project?

I took the js-yaml.js dist file designed for including in browsers.
FF addons have a Services.scriptloader.loadSubScript function that can load js files  in arbitrary scopes. I then take it off of module.exports and use it as I need.

Ah, i see now, setTimeout was added by browserify wrapper. Seems options should be tuned.
Is in nessesary to use browserified file or you can work with "native" npm sources?

Well there is no such thing as require here so I would need to write a custom loader it seems. In any case I find that having each library in a single file is very neat.

Ok, i undertand. Nobody expected serious use of browserified build - it was mostly for demo page.
I can easily fix warning with setTimeout, because that's a browserification garbage. But i would not like to create a separate build without this file. Need to think how to organize it.
May be you could patch 1 line with script, if you keep separate copy in your project anyway? Or it's very inconvenient?

Sure, I don't mind much having a patched 'private' version but I do not think I can dedicate the time for maintaining and updating a project fork in a timely manner. That's why I decided to open a issue here first.

Now should be without setTimeout() warning (regression in 3.4).
About eval warning - i still suggest to strip 1 line in your local copy. That can be automated. I don't like to create an additional build until more of such requests come. If you are not alone with this problem, then such build will be done.
Ok?

Removing js/function include does the job. Library still works and the validator does not complain :joy:
@puzrin, out of curiosity, which version of browserify do you use? I get a somewhat different output :)

10.1.3

Alright I created a fork at https://github.com/minj/js-yaml
If it's up to me this issue can be closed.

Thank you for your help.


Implement IRequest, how to enter Behavior

Implement IRequest, how to enter Behavior
services.AddTransient(typeof(IPipelineBehavior<,>), typeof(ValidationBehavior<,>));

public record CreateRequest(string Name) : IRequest { }

public class CreateRequestHandler : IRequestHandler<CreateRequest> {}

The above code does not execute ValidationBehavior.Handle

I know.The problem lies in the definition of ValidationBehavior.The problem is with the generic constraints of the ValidationBehavior parameter.
A common definition should be as follows:
public class ValidationBehavior<TRequest, TResponse> : IPipelineBehavior<TRequest, TResponse> where TRequest : notnull


[GH-#307] add multi node sync testcase

resolves #307
Modified docker-compose file, it runs 3 nodes. The first one adds spend tx and all of the oracle txs and mines them. The second one adds all of the naming txs and mines them.
Commands to run docker-compose:
docker-compose build
docker-compose up

will close this, until it:

actually fails tests if something is not working
is somewhat extensible
checks if stuff is synced across nodes


Warning on ISO document reference considered non-ISO/IEC

asciidoctor: WARNING(Section: Normative References): non-ISO/IEC reference not expected as normative: <ref id="ISOGuide73">[ISO Guide 73:2009]</ref>, Risk management — Vocabulary

There are other documents that can be referenced as normative; these include the JTC1 AROs (search for "ARO" in https://www.iso.org/isoiec-jtc-1.html).
Maybe if anything that starts with "ISO" or "IEC" doesn't need a warning?

Regex is now (ISO|IEC)[^0-9]* for the prefix, followed by the code; that will catch ISO Guide or IEC or ISO/IEC.

But the new prefixes are not being stored as crossreferences: need to fix.


Allow alias this to use assignment-style syntax

See DMD PR for rationale: https://github.com/dlang/dmd/pull/15122

DMD PR is merged, so merging this too.


Sometimes it does not copy

Hello,
So I have clipmenu installed alongside clipnotify however when I select and copy sometimes it just does not work (You go to paste and there is nothing in the clipboard). If you go back to copy again it may or may not work. So I have got into the habit now if pressing Ctrl+C about 5 times before I move away, to ensure its actually in the clipboard. Is there something I have not configured correctly? I cant see any other issues on github that mentions this so I am assuming no-one else has this issue?
Thanks
Chris

I think I have this problem, but I've yet to figure it out.

Are there any commonalities in what you're trying to copy from? It's possible there's fighting between different clipboard managers for authority.
I personally don't have this issue, so I'm inclined to believe it's some environment-specific issue. However, without knowing exactly what causes it, it's going to be hard to debug.

I have the same problem. Its solution is to prevent clipmenu operate with primary.
Setting  "${CM_SELECTIONS=clipboard}" in clipmenud does not help.

Huh, why do you think that's the solution if you're not having success with CM_SELECTIONS?

Because it is obvious, that primary interferes with the list of clips.
How can I prevent clipmenu to look into primary?

Hi @cdown,
I identified source of my problem. I was misleaded by clipboard patch applied to my st termemu.
Sorry for a dummy trail.

Hmm, if it also sets CLIPBOARD that should still work. What exactly happens?
Cc: @kaihendry who is listed on that patch

What exactly happens?

I turned off primary in clipmenu. When I was clicking on st window to switch focus on it, st was sending \n symbol to clipboard. So I thought, that clipmenu sometimes didn't copy.
Now, without clipboard patch st sends to clip only by pressing ctrl+shift+v.

I believe I know the cause for this issue, and it should be fixed in 6.0.0, specifically f22fce7f0407b6ace997599827b9f9ab01ad5c3f. Please let me know if 6.0.0 still has issues for you :-)


ARTEMIS-1996 MappedSequentialFileFactory may cause DirectByteBuffer off-heap memory leaks

Compaction is now reusing direct ByteBuffers on both
reading and writing with explicit and deterministic
release to avoid high peak of native memory utilisation
after compaction.

@michaelandrepearce @clebertsuconic I'm on vacation ATM, hence I need help to test it on CI and obviously review/test it guys :+1:

I have included the same optimizations while loading the journal, not only on compaction

@franz1981 could you rebase? Hopefully also doing this will trigger a new build, as last build failed.

Can you rebase this? lots of commits since you sent this. I will merge it along with the other PR on the journal.


ec_deployment resource continues to show version 8.4.2, even though i've applied successfully 8.6.0

Readiness Checklist

[X] I am running the latest version
[X] I checked the documentation and found no answer
[X] I checked to make sure that this issue has not already been filed
[X] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

I  imported an existing ec_deployment resource akin to this:
resource "ec_deployment" "customer" {
    alias                  = "<redacted>"
    name                   = "<redacted">
    region                 = "gcp-us-central1"
    version                = "8.6.0"

It loads  correctly without issues.
However, I am trying to do this:
tf state show ec_deployment.customer
expected:  version = 8.6.0
Current Behavior

Uses previous version 8.4.2 See below
resource "ec_deployment" "customer" {
   ...
    version                = "8.4.2"

This happens every time.

Re-applying the plan with version 8.6.0 "succeeds", but show still shows 8.4.2 afterwards.

I get the following with TF_LOG=DEBUG

module.customer_env.module.elastic.ec_deployment.customer: Still modifying... [id=REDCATED, 10s elapsed]
2023-01-19T10:36:04.861-0800 [WARN]  Provider "provider[\"registry.terraform.io/elastic/ec\"]" produced an unexpected new value for module.customer_env.module.elastic.ec_deployment.customer, but we are tolerating it because it is using the legacy plugin SDK.
    The following problems may be the cause of any confusing errors from downstream operations:
      - .version: was cty.StringVal("8.6.0"), but now cty.StringVal("8.4.2")
module.customer_env.module.elastic.ec_deployment.customer: Modifications complete after 13s [id=REDACTED]
2023-01-19T10:36:04.867-0800 [DEBUG] provider.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = error reading from server: EOF"
2023-01-19T10:36:04.869-0800 [DEBUG] provider: plugin process exited: path=.terraform/providers/registry.terraform.io/elastic/ec/0.5.0/darwin_arm64/terraform-provider-ec_v0.5.0 pid=87608
2023-01-19T10:36:04.869-0800 [DEBUG] provider: plugin exited

## Terraform definition
See above
Steps to Reproduce

Context

Possible Solution

Your Environment

Version used: elastic/ec. version = "~> 0.5"
Running against Elastic Cloud SaaS or Elastic Cloud Enterprise and version:  Elastic Cloud SaaS
Environment name and version (e.g. Go 1.9):

10:29 $ tf -version
Terraform v1.3.7
on darwin_arm64
+ provider registry.terraform.io/elastic/ec v0.5.0
+ provider registry.terraform.io/elastic/elasticstack v0.5.0
+ provider registry.terraform.io/hashicorp/external v2.2.3
+ provider registry.terraform.io/hashicorp/google v4.49.0
+ provider registry.terraform.io/hashicorp/google-beta v4.49.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.16.1
+ provider registry.terraform.io/hashicorp/null v3.2.1
+ provider registry.terraform.io/hashicorp/random v3.4.3

Server type and version:
Operating System and version:
Link to your project:

Closing.  manually hadn't updated the elasticsearch to 8.6.0.  That fixed this problem.


About Section Alignment

This pull request contains the updated code for the about section alignment correction. This pull request is the output of the following issue:
About Section Alignment #814
Output screenshot

Hi @panwar8279
Kindly review this pull request.

@panwar8279

@panwar8279 kindly review this pull request.

@panwar8279 Kindly review this pull request so that I can work on other issues.


When ignoring UnknownGeometryType log the issue.

We only support 2D geometries at current. When ignoring such geometries we will log that the geometry has been ignored, and give a useful workaround using ST_Force2D().
Fixes #449

Pull Request Test Coverage Report for Build baabd3be0-PR-710

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 45.24%

Totals

Change from base Build c197fe321:
0.03%

Covered Lines:
5298

Relevant Lines:
11711

💛  - Coveralls


Modify the UI of Add Medication Screen

The UI of the screen is not looking upto the mark wanted to improve the UI of the TextFields

How would you like to improve it @aritra-tech? :)


非 edition 2024 造成的 cargo 项目布局解析错误

kern-crates/zcore-linux-object
kern-crates/zcore-linux-syscall
kern-crates/zcore-loader

   0: 无法解析 `batch_9/kern-crates/zcore-linux-object` 内的 Rust 项目布局
   1: 无法读取 cargo metadata 的结果：`cargo metadata` exited with an error:     Updating crates.io index
          Updating git repository `https://github.com/kern-crates/zcore-kernel-hal.git`
          Updating git repository `https://github.com/DeathWish5/kernel-sync`
          Updating git repository `https://github.com/rcore-os/rcore-fs`
          Updating git repository `https://github.com/smoltcp-rs/smoltcp`
          Updating git repository `https://github.com/kern-crates/zcore-drivers.git`
          Updating git repository `https://github.com/kern-crates/zcore-zircon-object.git`
          Updating git repository `https://github.com/rcore-os/x86-smpboot`
          Updating git repository `https://github.com/DeathWish5/PreemptiveScheduler`
          Updating git repository `https://github.com/rust-embedded/riscv`
          Updating git repository `https://github.com/rcore-os/bitmap-allocator.git`
          Updating git repository `https://github.com/rcore-os/device_tree-rs`
          Updating git repository `https://github.com/rcore-os/isomorphic_drivers`
          Updating git repository `https://github.com/elliott10/pci-rs`
          Updating git repository `https://github.com/rcore-os/virtio-drivers`
          Updating git repository `https://github.com/rzswh/region-allocator`
          Updating git repository `https://github.com/pleasewhy/unicycle`
          Updating git repository `https://github.com/pleasewhy/uniset`
      error: failed to select a version for the requirement `funty = "~1.2"`
      candidate versions found which didn't match: 3.0.0-rc2, 3.0.0-rc1, 2.0.0, ...
      location searched: crates.io index
      required by package `bitvec v0.22.0`
          ... which satisfies dependency `bitvec = "^0.22"` of package `rcore-fs-sfs v0.1.0 (https://github.com/rcore-os/rcore-fs?rev=1a3246b#1a3246b1)`
          ... which satisfies git dependency `rcore-fs-sfs` of package `linux-object v0.1.0 (/home/runner/check/batch_9/kern-crates/zcore-linux-object)`
      if you are looking for the prerelease package it needs to be specified explicitly
          funty = { version = "3.0.0-rc2" }

shilei-massclouds/axfs_ramfs
   0: 无法解析 `batch_14/shilei-massclouds/axfs_ramfs` 内的 Rust 项目布局
   1: 无法读取 cargo metadata 的结果：`cargo metadata` exited with an error: error: current package believes it's in a workspace when it's not:
      current:   /home/runner/check/batch_14/shilei-massclouds/axfs_ramfs/procfs/Cargo.toml
      workspace: /home/runner/check/batch_14/shilei-massclouds/axfs_ramfs/Cargo.toml

      this may be fixable by adding `procfs` to the `workspace.members` array of the manifest located at: /home/runner/check/batch_14/shilei-massclouds/axfs_ramfs/Cargo.toml
      Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
   1:

Location:
   src/layout/mod.rs:59

sysones/rcore-tutorial-v3-with-hal-component
   0: 无法解析 `batch_19/sysones/rcore-tutorial-v3-with-hal-component` 内的 Rust 项目布局
   1: 无法读取 cargo metadata 的结果：`cargo metadata` exited with an error:     Updating crates.io index
          Updating git repository `https://github.com/Byte-OS/polyhal.git`
          Updating git repository `https://github.com/rcore-os/virtio-drivers`
      error: failed to select a version for `polyhal`.
          ... required by package `os v0.1.0 (/home/runner/check/batch_19/sysones/rcore-tutorial-v3-with-hal-component/os)`
      versions that meet the requirements `*` are: 0.1.3

      the package `os` depends on `polyhal`, with features: `kcontext` but `polyhal` does not have these features.

      failed to select a version for `polyhal` which could resolve this conflict


Feature Request: Allow user to enter a reason for subtraction/addition of Wokebucks.

As a user, I can add a reason for giving or taking woke bucks.
$give/takebuck @user "string"
Examples:
$takebuck @user Misgendered another user.
$givebuck @user Respectfully asked the gender of another user before addressing them with a Pronoun.

Receipt feature


Connection timed out error when behind a proxy

Hi, I'm behind a corporate proxy and I get the following error when I run a mvn heroku:deploy from the command line or from within Eclipse:
Caused by: org.apache.http.conn.HttpHostConnectException: Connect to api.heroku.com:443 [api.heroku.com/<IP_ADDRESS>, api.heroku.com/<IP_ADDRESS>, api.heroku.com/<IP_ADDRESS>] failed: Connection timed out: connect     at org.apache.http.impl.conn.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:151)     at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:353)     at org.apache.http.impl.execchain.MainClientExec.establishRoute(MainClientExec.java:380)     at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:236)     at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:184)     at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:88)     at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)     at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:184)     at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)     at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:107)     at com.heroku.sdk.deploy.utils.RestClient.get(RestClient.java:29)     at com.heroku.sdk.deploy.ConfigVars.getConfigVars(ConfigVars.java:41)     at com.heroku.sdk.deploy.ConfigVars.merge(ConfigVars.java:24)     at com.heroku.sdk.deploy.Deployer.mergeConfigVars(Deployer.java:103)     at com.heroku.sdk.deploy.Deployer.deploy(Deployer.java:67)     at com.heroku.sdk.deploy.App.deploy(App.java:57)     at com.heroku.sdk.deploy.App.deploy(App.java:61)     at com.heroku.sdk.maven.DeployMojo.execute(DeployMojo.java:49)

Working on this in c3638bb4b91092988697a8c223f5bc6696a80e1c

I've put a fix in version 1.0.2 that uses HTTP_PROXY and HTTPS_PROXY as described in CLI Usage. Please give this a try and let me know if it works or not.

@pmorddny ^^

I'm encountering a similar connection timeout issue when issuing:
$ heroku deploy:war --war <war_file_location> --app  <app_name>
Exception in thread "main" java.net.ConnectException: Connection timed out: connect
at java.net.DualStackPlainSocketImpl.connect0(Native Method)
at java.net.DualStackPlainSocketImpl.socketConnect(DualStackPlainSocketImpl.java:79)
at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:172)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:589)
at java.net.Socket.connect(Socket.java:538)
at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:432)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:527)
at sun.net.www.http.HttpClient.(HttpClient.java:211)
at sun.net.www.http.HttpClient.New(HttpClient.java:308)
at sun.net.www.http.HttpClient.New(HttpClient.java:326)
at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1169)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1105)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:999)
at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:933)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1513)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1441)
at java.net.URL.openStream(URL.java:1045)
at org.apache.commons.io.FileUtils.copyURLToFile(FileUtils.java:1460)
at com.heroku.sdk.deploy.DeployWar.(DeployWar.java:21)
at com.heroku.sdk.deploy.DeployWar.main(DeployWar.java:74)

From the stack trace, it appears that proxy handling needs to be added to
DeployWar.java =>  FileUtils.copyURLToFile(webappRunnerUrl, webappRunnerJar);

@kenya44 I see what's going on now. Thanks for narrowing this down. I'll try to get a fix out soon.

@kenya44 if you set the environment variable JAVA_TOOL_OPTIONS="-Dhttp.proxyHost=proxyserver.com  -Dhttp.proxyPort=8080" does the heroku deploy:war command work? (if so I can build that into the code).

This solution works on RHEL (OpenJDK Runtime Environment (build 1.8.0_91-b14)), but not on Windows 7 64-bit (Java(TM) SE Runtime Environment (build 1.8.0_72-b15)).   On Windows, the JVM fails to parse the -Dhttp.proxyPort=8080 as a second system property, but instead it shows up as a single system property:
http.proxyHost=proxyserver.com -Dhttp.proxyPort=8080
The workaround was to just specify only the proxyHost parameter since our proxy server uses the default proxy port=80.  At this point, I'm fine with manually setting the JAVA_TOOL_OPTIONS environment variable until Oracle fixes their Windows JVM bug.

@kenya44 ah, that's great to know because I can fix it now. I can set http.proxyPort and http.proxyHost dynamically in DeployJar from the environment variables. Thank you for this excellent report. I will have a fix out soon.

This fix has been updated and released in the heroku-deploy library, the Heroku Maven plugin, and the heroku-deploy CLI plugin. I'm going to close the ticket, but please let me know if you have any more problems and we'll reopen it.

删除项目目录下的.mvn和maven.exe，这样使用系统的mvn命令就没有问题了


Update markdown-guidance.md

Remove mention of attachment support for README files because all .md in Repos do not support attachments.

@chcomley

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


coordinator should only set rp_filter for pod not the node

Thanks for contributing!

What type of PR is this?

release/bug

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes https://github.com/spidernet-io/spiderpool/issues/3945
Special notes for your reviewer:

wait for https://github.com/spidernet-io/spiderpool/pull/3986


a malicious ACI created during layer archive extraction via symlink or hardlink attack

Hi,
recently, i reviewed the code in docker2aci and found some interesting stuff.There is a potential threat vector that was discovered during layer archive extraction, which could cause a milicious ACI-formatted image contains symlink or hardlink to a relative path out of rootfs. It seems that ValidateACI only check whether the internal files's prefix is "rootfs", without essential review for the Linkname of some link file, it may perform some critical behaviors, like breakout etc, i think it is possible that a malicious link file to the sensitive dir or file in the layer archive. for example, a crafted tar file header is like this:
{
	{
			header: &tar.Header{
				Name:     "looplink",
				Typeflag: tar.TypeSymlink,
				Linkname: "../../../etc/init.d"
			},
	},
	{
			header: &tar.Header{
				Name: "looplink/havefun",
			},
	},
}

what do you think about this issue ?

Thanks for the report @TheBeeMan. The code snippet you pointed out seems to lack validation of links target, I agree it can do better there. I have to check if additional validation is performed at a different layer but so far from a preliminary analysis I haven't seen any.
From what I have observed so far, writeACI() is never involved in extraction to filesystem (copy/validation is performed via in-memory readers) so I'm wondering if you have a PoC or an attack scenario directly against docker2aci, or if it is a more generic concern regarding the conversion of crafted images.
Another open question: ValidateACI() mostly relies on ValidateArchive() from appc/spec, so I'm wondering if this additional validation should be better performed directly there instead. @jonboulle?

I prefer to a more generic concern regarding the conversion of crafted images, there is no PoC  directly against docker2aci, as CVE Assignment Team said:

docker2aci is apparently a library [...] and we almost always recognize
the potential for an unattended use case for any library.
[...]
Someone can call the xx function from an arbitrary
application. [...] It might be automated with cron or a similar unattended
tool that runs in an unrestricted (non-container) environment. Thus,
there is an availability impact because [...]

docker2aci uses writeACI() to generate a malicious ACI-formatted image, how could you guarantee others not to extract it to filesystem from an arbitrary application ?

could you submit the issue to CVE Assignment Team for review, and request a CVE if possible ?

@TheBeeMan the onus is on extractors to safely unpack the archive. Symlinks are resolved at path resolution time and container images are intended to be executed inside of a chroot jail; accordingly, it's quite valid to have relative symlinks that point "outside" the archive (or absolute links that on first  glance might appear to reference the host - for example, var/run --> /run). Consequently you'll see that implementations like Docker's or rkt's will perform the extraction itself in a chroot jail.
Analogously, one can trivially create such a "malicious" image using GNU tar, and we can't guarantee that arbitrary applications aren't using tar (as a library or executable) to extract such images - but this doesn't mean we should file a CVE against tar.
Does that make sense?

fine

Not a docker2aci bug, thus closing.


Error in connection properties jaasConfigurationName SQL Server JDBC Driver JASSConfiguration

Driver version
All versions since 6.1.7 jre8
SQL Server version
It does not matter.
Client Operating System
Redhat Enterprise Linux 8.5
JAVA/JVM version
OpenJDK 1.8.0u312
Table schema
N/A
Problem description
From https://docs.microsoft.com/en-us/sql/connect/jdbc/setting-the-connection-properties?view=sql-server-ver15
The JAAS configuration name is passed via "jaasConfigurationName".
It seems to be a typo. From your JDBC driver, it shall be "JASSConfigurationName".
Expected behavior
JAAS configuration name shall be passed in to jaasConfigurationName however it fails to pass that properties to JDBC Driver.
JASSConfigurationName="jaas1" e.g. works.
jassConfigurationName=jaas1 does not work.
If this is a documentation error from Microsoft. Please kindly correct them via your internal channel. Many thanks.
Actual behavior
Error message/stack trace
Any other details that can be helpful
JDBC trace logs

Thanks. This looks to be a long-standing typo in the API itself, not the connection string property. The connection string property is "jaasConfigurationName" and the driver expect it as such. Only the API on SQLServerDataSource has the typo, "setJASSConfigurationName"/"getJASSConfigurationName". Fortunately that API is little-used so the impact is minimal. We'll consider fixing it in a future release.
Thanks,
David

Many thanks! I will let IBM folks know as well. Any possible estimate of ETA or next patched JDBC driver from SQL Server database team?

Hi @pcnchang, we plan on having this fixed by our next Stable release at the end of July. It may also make the next preview release which is in early June.

When this is fixed can the original "setJASSConfigurationName"/"getJASSConfigurationName" be left in as deprecated, and pointed to the new setJAASConfigurationName/getJAASConfigurationName methods? This would prevent breaking any customer that are currently using the properties.

Fortunately that API is little-used so the impact is minimal.
WebSphere uses this API to set properties specified in configuration (and other application servers may as well), so the impact may be greater than expected.

hi @mswatosh
Thank you for your input. We will keep the misspelled APIs for the upcoming release however they will be deprecated and then removed in later releases.
Thanks


New Sentry handler

Package raven/raven is deprecated, it is suggested to use sentry/sentry (docs). Maybe it's a good idea to create new Sentry handler?

See #1273. The handler is now ready and released inside the Sentry PHP SDK 2.1.0: https://github.com/getsentry/sentry-php/pull/808
Here's how to use it: https://docs.sentry.io/clients/php/integrations/#monolog

Thanks for the link!
P. S. The docs are for raven.

Hmm, right. It seems they still don't have docs for the new Monolog handler in the docs of the new Sentry PHP SDK. This handler has been released in a stable release less than a month ago: https://github.com/getsentry/sentry-php/releases/tag/2.1.0
You could probably an issue with Sentry to document it.
I think the Monolog docs could also link to the new Sentry handler instead of just providing the old one and leaving users clueless.


Add warning if channel layer might be full.

See changes of autoupdate.py in https://github.com/OpenSlides/OpenSlides/pull/2170/.

This is a duplicate of #2353


Try to split up pbp rebuild in multiple actions

Rebuilding the complete pbp database can fail sometimes and we would loose all completed seasons until that point.
Maybe it's possible to write multiple actions or so to be able to trigger specific seasons

pbp rebuild action now pushes to nflverse-data after wrangling each season


unionAll not working?

Hi there; perhaps I'm misunderstanding how this should work, but shouldn't the below code simply create a union of the two data sets and output the count? Instead I'm getting a java.lang.NullPointerException on the unionAll call?
var spark = require('apache-spark-node');
var context = spark([], process.env.ASSEMBLY_JAR);
var sqlContext = context.sqlContext;
var sqlFunctions = context.sqlFunctions;

var data1 = [
  {"name":"Michael"},
  {"name":"Andy", "age":30},
  {"name":"Justin", "age": 19}
];

var data2 = [
  {"name":"Fiona"},
  {"name":"Jenny", "age":30},
  {"name":"Sandra", "age":30},
  {"name":"Alexa", "age": 19}
];

var df1 = sqlContext.createDataFrame(data1);
var df2 = sqlContext.createDataFrame(data2);

console.log(df1.countSync());
console.log(df2.countSync());

var u = df1.unionAll(df2);
console.log(u.countSync());

Thanks for the report! Your code is just fine and you ran into a bug that's being fixed over in #35.

Pushed fixed version 0.3.3 to NPM.


Configuration options

The wallet passphrase is marked as required.
If the encryptedWallet options is set to true it should require the wallet passphrase to be present.

resolved with branch #1-config-options


SOLR-16110: Using Schema/Config API breaks the File-Upload of Config Set File

https://issues.apache.org/jira/browse/SOLR-16110
main version of https://github.com/apache/lucene-solr/pull/2651

@smoldenhauer-ish can you take a look at this?

Hi, @risdenk I had only a short look. Tests are much better now.
I am not sure about the makePath vs setData Looks to me as there is a AlreadyExistsException is thrown and catched each time the touchConfDir is called. So i think that it does not "touch" the dir for whatever reason that "touch" is or was needed.

@epugh / @smoldenhauer-ish can you take a look again? I made it so there is an update of the data itself atomically. I don't think there is harm in actually doing this and makes it more like the touch command in general.

I am still confused about the makePath I think the touchConfDir was only called/callable with an already existing configset node.
I would like to avoid the throw - catch as I think it is bad in performance & style.
I kindly suggest to use "{}".getBytes(StandardCharsets.UTF_8) as data instead of the 0 byte - because json is expected as data at the node later on.

@smoldenhauer-ish fair enough. I updated the test to explicitly test for that

Yes, looks fine for me, too


Added reminder command

Closes #29
Added command !remindme <time in seconds> <message>

Looks great @ankan792! Your fork seems to be behind by 2 commits, could you please update your fork so no code is lost? You'll be good to go after that!

I'm sorry, I didn't specify properly in my message above, my mistake 😓
You'll have to update the branch called patch-2 on your fork, since you have been developing there. Once you update, the "ping" command will show up in your code, then you know you've done it correctly.

@z404 Sorry it's my bad. Looks like I didn't update properly last time. Hope it's good now haha.


chromedriver autocheck+update

chromedriver autocheck+update
if version not ok, ignore the warning

ignored warnings
to be done:

chromedriver warnings
print more statements to indicate the progress, change to headless


Document about nextTick difference between English and Chinese

Version
1.0.0-beta.31
Reproduction link
https://jsbin.com/pokuluhado/edit?html,js
Steps to reproduce
In Chinese version, it says there is no need to use Vue.nextTick() because Vue Test Utils has applied it. But in English Version, it says We need to use Vue.nextTick() to wait until Vue has performed the DOM update after we set a reactive property.
My question is, which one is correct? After my testing, I found that if I changed the data of component without using Vue.nextTick(), wrapper.html() is still the original value.
What is expected?
As Chinese Version, there is no need to use Vue.nextTick().
What is actually happening?
Test failed.

Chinese Version: https://vue-test-utils.vuejs.org/guides/getting-started.html#using-nexttick
English Version: https://vue-test-utils.vuejs.org/zh/guides/getting-started.html#关于-nexttick-怎么办？

You need to use nextTick, sync mode was removed a few versions ago. The translations are mostly out of date - this is a hard problem, I don't have a good way to keep them updated.
If you want to make a PR that would be much appreciated. The English docs are the "source of truth".

Thank you your reply.
I've tried to translate this part from English to Chinese again, and I will make a PR later. Besides, I noticed that there also are differences translation about nextTick in other parts, and may need to be re-translated.

Yep. We need a way to track changes and either notify a dedicated translator or just flag in the docs something like "this translation could be out of date". Not sure of any tools that do this, though.

Yep. We need a way to track changes and either notify a dedicated translator or just flag in the docs something like "this translation could be out of date". Not sure of any tools that do this, though.

lmiller, I updated the Chinese translation of the nextTick part of the document, and added some new sections in common-tips.md. I have no better idea about the multilingual translation. However, I will update Chinese version in my spare time later.

Thanks, just need you to run the yarn format:check && yarn lint (see PR review)

I've re-committed after format :)

nice job, thanks a lot!


Rename instances of 'decompresser' to 'decompressor'

Standardize around decompressor spelling

After this gets merged in, we need to make a new pre-release, and update/merge in this PR for blockchain - https://github.com/Chia-Network/chia-blockchain/pull/15751


fix: fixed unsupported big float values

Fixed unsupported big float values like this (having a , in it) :

Summary by Sourcery
Fix parsing of big float values containing commas and update relevant test cases.
Bug Fixes:

Fixed parsing of big float values containing commas in the input string.

Tests:

Updated test cases to include big float values with commas.

The stray comma gets you every time.


MediaTrackSettings struct

I'm not sure that it can be called a bug, but:
Due to MDN docs:
https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSettings
and
https://developer.mozilla.org/en-US/docs/Web/API/Media_Streams_API/Constraints#getting_the_current_settings_for_a_track
struct MediaTrackSettings must give me access to actual values of MediaStreamTrack's settings, but in web-sys only setter-methods are implemented. (I'm writing web-micro UI right now and I need to know the settings of client's micro. And I think MediaStreamTrack.getSettings is the only way, but it allows you only set, not get) Why is it write only, when it should be read only?

Ok, I found that even not all the struct fields are implemented (sampleRate for example), but I found the solution (thanks to source code):
It's easy to write getter methods by yourself:
let settings = my_media_stream_track.get_settings();
let channel_count = ::js_sys::Reflect::get(&settings,  &JsValue::from("channelCount")); // channel_count is Result<JsValue, JsValue>
let sample_rate = ::js_sys::Reflect::get(&settings,  &JsValue::from("sampleRate"));
let sample_size = ::js_sys::Reflect::get(&settings,  &JsValue::from("sampleSize"));
...

The only step is to add it to the crate page i think

As far as I have seen, with latest web_sys version (0.3.64), proper getter methods are still not implemented. The work-around you proposed is much better than nothing, but still quite cumbersome. So why closing the issue?

Duplicate of #1793.


Please add some GitHub topics to this repo

Firstly, just discovered this from a random search, very cool. I've been thinking a bit about the privacy issue of the relays knowing who is messaging whom. The scheme of deriving a shared key, and then both publishing to that is an interesting one.
Second, would you be up for adding the nostr topic and maybe a few more to this repo? It would make it much easier for folks to find it on GitHub.

Done :)


add MariaDB in README

Based on #414

What did you implement:
Add MariaDB in README, no code change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
You don't have to satisfy all of the following.

[ ] Write tests
[ ] Write documentation
[ ] Check that there aren't other open pull requests for the same issue/feature
[ ] Format your source code by make fmt
[ ] Pass the test by make test
[ ] Provide verification config / commands
[ ] Enable "Allow edits from maintainers" for this PR
[ ] Update the messages below

Is this ready for review?: NO
Reference

https://blog.github.com/2015-01-21-how-to-write-the-perfect-pull-request/

@robertsilen your PR is (rebased and) merged! Thanks a lot!!


Decoupled Walk.gd from character-specific logic.

Added Skin.tscn as a holder of that logic, and made Godzilla.tscn and Mothra.tscn inherit it, moved godzilla-logic from Walk.gd to its skin.
As of now class name is different (PlayerSkin) due to name collision with native class Skin. Should be fixed.

Thank you :)
I've tested it and I think it works fine, it needs some more work though (like moving the Mothra attacks into the skin script and probably separating the skin scripts from the skin scenes) but those are easily fixable.


Group by ManyToManyField

I go an error when I put in the view group_by=many_to_many_field as the field is not listed in class.meta.fields, however is listed in class.meta_get_fields()

PR Merged. Thanks !


Update manage-express-installation-files-for-windows-10-updates.md

I see a lot of people misunderstanding what problem express installation files solve.  Many are shocked to learn that it only increases the demand on their WAN links to the DPs and the storage space required.  Express files only improve a last-mile client function which hopefully these edits help to clarify.

Good stuff @bryandam, thanks for the contribution!


extent should support xml:lang

From<EMAIL_ADDRESS>on May 20, 2014 14:18:52
As the extent can be quite complicated to describe it should allow @-xml:lang.
Original issue: http://code.google.com/p/music-encoding/issues/detail?id=192

From<EMAIL_ADDRESS>on June 17, 2014 07:33:03
This issue was closed by revision r1223 .
Status: Fixed


⚠ Bofrost.de has degraded performance

In 68265ae, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1943 ms

Resolved: Bofrost.de performance has improved in ea95791.


Unable to play videos in a centered position

Hello,
I'm currently using cog v.0.12.4 and the exact same Yocto setup as in https://github.com/Igalia/meta-webkit/issues/395
I run the following commands to open cog and play a video:
export COG_PLATFORM_FDO_VIEW_FULLSCREEN=1
cog -P wl http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ElephantsDream.mp4 &

However, it always spawns in a different position. Is there any way to ensure the video widget is always well-centered?
If not, can cog play the video, by default, in full screen mode? Without the need to click into the full screen button.
I'm attaching two printscreens hoping it will be helpful to clarify my current situation. Thanks for the support!

Maybe you can do this with a web-extension, that when loaded, looks for the <video> element in the page and switches it to fullscreen using JS. Cog can load web-extensions.. I don't think there's anything else we can do...

@jm-costa  please use COG_PLATFORM_WLVIEW_FULLSCREEN instead of COG_PLATFORMFDO_VIEW_FULLSCREEN

Thanks for the suggestion! It works :)


Implement Timer to Hide "You're Connected" Text

Description
Upon connecting to the Pieces OS, there is a need to enhance the user experience by implementing a timer that automatically hides the "You're Connected" text and shrinks the button after a certain duration.
This PR fixes #
Identify the element containing the "You're Connected" text and the associated button.
Implement a timer function in the relevant JavaScript file.
Upon connection, trigger the timer to start.
After the specified duration, hide the text and apply the button shrink effect.

fixed #48 @jordan-pieces you can review my PR

cc @jordan-pieces


Fixed some issue conditions in utils and template tags.

Added migrations.

Thanks @joshuajonah  and sorry for the delay on merging that one.


How can I use it in Vue3 project

When I use it in Vue3 project, there are some warnings and errors as follows. How can I use it in Vue3 project?
_[Vue warn]: beforeDestroy has been renamed to beforeUnmount.
[Vue warn]: Property "$createElement" was accessed during render but is not defined on instance.
[Vue warn]: Property "_self" was accessed during render but is not defined on instance.
[Vue warn]: Unhandled error during execution of render function
[Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/vue-next
Uncaught (in promise) TypeError: Cannot read property 'c' of undefined
at Proxy.render (vue-google-charts.common.js?757f:formatted:350)
at renderComponentRoot (runtime-core.esm-bundler.js?5c40:696)
at componentEffect (runtime-core.esm-bundler.js?5c40:4035)
at reactiveEffect (reactivity.esm-bundler.js?a1e9:42)
at effect (reactivity.esm-bundler.js?a1e9:17)
at setupRenderEffect (runtime-core.esm-bundler.js?5c40:4018)
at mountComponent (runtime-core.esm-bundler.js?5c40:3976)
at processComponent (runtime-core.esm-bundler.js?5c40:3936)
at patch (runtime-core.esm-bundler.js?5c40:3547)
at mountChildren (runtime-core.esm-bundler.js?5c40:3736)

I have the same problem about how to use this in Vue3 project, and some errors are as follows:
index.js?3b58:1 Uncaught (in promise) TypeError: Cannot read property '_c' of undefined
at Proxy.n (index.js?3b58:1)
at renderComponentRoot (runtime-core.esm-bundler.js?5c40:846)
at componentEffect (runtime-core.esm-bundler.js?5c40:4275)
at reactiveEffect (reactivity.esm-bundler.js?a1e9:42)
at effect (reactivity.esm-bundler.js?a1e9:17)
at setupRenderEffect (runtime-core.esm-bundler.js?5c40:4258)
at mountComponent (runtime-core.esm-bundler.js?5c40:4217)
at processComponent (runtime-core.esm-bundler.js?5c40:4177)
at patch (runtime-core.esm-bundler.js?5c40:3788)
at mountChildren (runtime-core.esm-bundler.js?5c40:3970)

I'm working on it, a vue3 compatible version will be released today or tomorrow

The component code has been greatly improved,
I have released version 1.5.1 for Vue2 and version 2.0.0 for Vue3
Please use "npm i -s vue-drag-resize@next" for use in Vue3
The vue3 branch has completely rewritten the demo using the composition API. For examples of how to use it, go there

Thank you so much！
It's so helpful !

Thank you very much for your detailed reply!
--
                     此致

敬礼！！
                                                     王振海

At 2021-04-07 23:12:02, "kirillmurashov" @.***> wrote:
The component code has been greatly improved,
I have released version 1.5.1 for Vue2 and version 2.0.0 for Vue3
Please use "npm i -s @.***" for use in Vue3
The vue3 branch has completely rewritten the demo using the composition API. For examples of how to use it, go there
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Add nonempty() method to zod.record() for empty object validation

Problem
Currently, zod.record() allows empty objects to pass validation without error.
const User = z.object({ name: z.string() });
const UserStore = z.record(z.string(), User);
UserStore.parse({}); // passes

In certain use cases, this behavior is not desired, as an empty object can represent invalid data. For example, when an object is expected to have at least one key-value pair, an empty object should trigger a validation error.
Proposed Solution
Introduce a nonempty() method to zod.record() that ensures the record is not empty. This would allow developers to enforce that objects must contain at least one key-value pair. Example usage:
zod.record(z.string(), User).nonempty();
UserStore.parse({}); // throws: "Record cannot be empty"

In this case, an empty object would throw a validation error, while non-empty objects would pass validation as usual.
It would be great to add a custom error message:
// optional custom error message
zod.record(z.string(), User).nonempty({
  message: "Can't be empty!",
});

Next Steps
I would like feedback from the maintainers and community to see if this feature would be a valuable addition to Zod. If there’s support for the idea, I’m happy to start working on this feature and submit a pull request.

Here is what i have hacked around with .refine
schema: z
    .record(z.unknown())
    .refine(
      (schema) => Object.keys(schema).length > 0,
      "JSON schema is required and cannot be empty",
    ),

@c0rtexR thanks!

It works without .record too and was expected in my case!


dts: arm: ambiq: and pm to kxr cpu

add the power states of cpu to the dtsi file.

@aaronyegx please test on your KXR.
My KXR says SIP and not SIP2 which means its the wrong processor.
Having one shipped ASAP.

@aaronyegx please test on your KXR. My KXR says SIP and not SIP2 which means its the wrong processor. Having one shipped ASAP.

What needs to be tested with this PR?

@aaronyegx please test on your KXR. My KXR says SIP and not SIP2 which means its the wrong processor. Having one shipped ASAP.

What needs to be tested with this PR?

PM states on the CPU.
They were not a part of the cpu until this ticket.


Add July banner

Description of change

Checklist

[ ] npm test passes
[ ] documentation is changed or added (if applicable)
[ ] permission has been obtained to add new logo (if applicable)
[ ] contribution guidelines followed here

We have now a component AdoptiumNews that can be used to describe a News without using the Banner.
You can take a look at the file if you want to configure it.

We have now a component AdoptiumNews that can be used to describe a News without using the Banner. You can take a look at the file if you want to configure it.

Thanks - we can look at that for the next cycle (If you can add a comment mentioning this to https://github.com/adoptium/temurin/issues/50 we won't forget about it ;-) )


go-ethereum: 1.8.17 -> 1.8.19

Motivation for this change
Update to latest Geth
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@adisbladis Can you check?

@GrahamcOfBorg build go-ethereum


[feature] How to rename method param with script plugin?

Hello everyone, thank you very much for developing such an excellent tool.
I noticed that the script plugin will be introduced in the next version. I downloaded the nightly version and tried to use it, but I am not particularly familiar with the API, so I would like to ask if you can help me write an example.
The functionality I want to achieve is as follows: rename method params by reading param's retrofit2.http.Query annotation.
import com.cloud.network.bean.RspMsg;
import retrofit2.http.POST;
import retrofit2.http.Query;

public interface CloudService {
    @POST("get_donate_record")
    Call<RspMsg> get_donate_record(@Query("phone_id") String str); // Rename `str` to `phone_id`
}

I would be grateful if you guys could help me. 🥰

@cesaryuan script:
/**
 * Rename method parameters from values in attached annotation
 */

import jadx.api.plugins.input.data.attributes.JadxAttrType
import jadx.core.deobf.NameMapper
import jadx.core.dex.nodes.MethodNode
import jadx.plugins.script.runtime.data.ScriptDecompilePass

val annCls = "Lretrofit2/http/Query;"

val jadx = getJadxInstance()

// access to method parameters variables available only in decompile passes
jadx.addPass(object : ScriptDecompilePass(
	jadx,
	"RenameParams",
) {
	override fun visit(mth: MethodNode) {
		// parameter annotations stored in method annotation
		mth.get(JadxAttrType.ANNOTATION_MTH_PARAMETERS)?.let { paramsAttr ->
			for ((i, param) in paramsAttr.paramList.withIndex()) {
				param.get(annCls)?.let { ann ->
					val name = ann.values["value"]?.value as String
					if (NameMapper.isValidIdentifier(name)) {
						mth.argRegs[i].name = name
						log.info { "Rename param $i to $name in method $mth" }
					}
				}
			}
		}
	}
})

jadx.afterLoad {
	// force decompilation and run rename pass for all classes (optional)
	jadx.decompile.allThreaded()
}

https://github.com/skylot/jadx/blob/72180164d88d7751a2ccbc86f6d0647a58718fdb/jadx-plugins/jadx-script/examples/scripts/deobf/deobf_method_param.jadx.kts#L21
Thanks so much for your help! It works.
btw, there seems to be some places that can be improved.
I added one safe call ?. and changed String to String? as shown below:
val name = annAttr?.get(annCls)?.values?.get(annParam)?.value as String?


fix: make debug api compatible with old tidb-dashboard backend api

TODO
fix i18n

Codecov Report

Merging #1417 (f4842a7) into master (10c5a29) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   27.58%   27.59%   +0.01%
==========================================
  Files          93       93
  Lines        9972     9972
==========================================
+ Hits         2751     2752       +1
+ Misses       7041     7040       -1
  Partials      180      180

Flag
Coverage Δ

be_unit_test
27.59% <ø> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c5a29...f4842a7. Read the comment docs.

remain todo: (will fix in another PR)

fix i18n


Convert the Action into TypeScript

This PR converts the Action to TypeScript using our detsys-ts framework.

Agreed.


remove Julia cat image for license issue

fix No.6 item in https://github.com/apache/incubator-mxnet/issues/15542
removed image file and provided download link
cc @iblis17 @PatricZhao @TaoLv

@roywei thank you for the fix!

@roywei Could you please re-trigger the CI? Seems the status was not reflected to this page.


pbft: add null request "keep alives"

Description

Optionally send periodic null request "keep alives" when the pbft network is idle.
Motivation and Context

Fixes #1454
How Has This Been Tested?

unit tests, behave
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Simon Schubert<EMAIL_ADDRESS>

@corecode unit tests failed with the following output
2016/05/26 14:49:42 Replica 1 prepare count for view=0/seqNo=1: 1
panic: Unimplemented

goroutine 6915 [running]:
panic(0xa8c500, 0xc8202e98e0)
	/home/travis/.gimme/versions/go1.6.linux.amd64/src/runtime/panic.go:464 +0x3e6
github.com/hyperledger/fabric/consensus/obcpbft.(*omniProto).sign(0xc82026a900, 0xc820355600, 0x71, 0x80, 0x0, 0x0, 0x0, 0x0, 0x0)
	/home/travis/gopath/src/github.com/hyperledger/fabric/consensus/obcpbft/mock_utilities_test.go:394 +0x111
github.com/hyperledger/fabric/consensus/obcpbft.(*pbftCore).sign(0xc82026b500, 0x2ac451f55580, 0xc820355580, 0x0, 0x0)
	/home/travis/gopath/src/github.com/hyperledger/fabric/consensus/obcpbft/sign.go:35 +0x10c
github.com/hyperledger/fabric/consensus/obcpbft.(*pbftCore).sendViewChange(0xc82026b500, 0x0, 0x0)
	/home/travis/gopath/src/github.com/hyperledger/fabric/consensus/obcpbft/viewchange.go:163 +0x6c0
github.com/hyperledger/fabric/consensus/obcpbft.(*pbftCore).main(0xc82026b500)
	/home/travis/gopath/src/github.com/hyperledger/fabric/consensus/obcpbft/pbft-core.go:295 +0x3f0
created by github.com/hyperledger/fabric/consensus/obcpbft.newPbftCore
	/home/travis/gopath/src/github.com/hyperledger/fabric/consensus/obcpbft/pbft-core.go:268 +0x185a
FAIL	github.com/hyperledger/fabric/consensus/obcpbft	61.174s

If I knew which test fails... I can't reproduce it here.  Most likely again some test race condition.

This is a race in TestReplicaPersistQSet:

somehow it takes more than 2 seconds for the test to run
the request we inject times out and triggers a view change
view change requires a signature, which is not mocked in the test
panic!

@corecode I switched this test to run only on the test thread (not to even start up the timer threads), so this should be a non-issue now.

@corecode There's a merge conflict now. Could you rebase? That will kick off Travis again.

rebased

Since we'll be restructuring the mock tests shortly anyhow, I'm fine with this PR as is.

LGTM. Thanks


Integration Test - Release - 2019/06/04 19:33:20

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#backlog'

#pri2

#backlog

#assign PRMergerTest1

#assign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign PRMergerTest2

GitHub user PRMergerTest1 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#reassign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#please-close


[Discussion] Event listener to gather query stats/information

Hi, We have been looking into doing query analysis in order to pin point a specific scenario and combing through server and broker logs is a difficult task. An event listener interface which enable us to add a hook into query execution and gather query info/stats would be really helpful. For example Presto provides the following interface to hook into query execution. https://github.com/prestodb/presto/blob/master/presto-spi/src/main/java/com/facebook/presto/spi/eventlistener/EventListener.java
Do we already have a similar mechanism in Pinot? Have we ever considered doing so as I can imagine it wont be as simple as Presto because of the query volume and latency sensitive nature of Pinot?

Yes, see https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/api/RequestStatistics.java
You will need to plug in your own mechanism to emit this from the broker

Good idea. As Subbu mentioned, we have all the information but we lack the listener interface. It's definitely worth adding one in our spi.


Device Agent updates at scale

Epic
No response
Description
As a FlowFuse user:  I want a means of updating the device agent at scale.
So that we get latest features and fixes:
First raised on NR forum: https://discourse.nodered.org/t/how-to-update-device-agent-version-in-scale/87260
Acceptance Criteria

[ ] TBD

What if the user is running in a docker container? I guess we run npm install in the container?
I think just doing an npm install to a newer version and the exec(1) syscall might just do on the device agent side. Problem is that the agent doesn't just continue the current workload but will reinstall everything and so there's downtime? In a first iteration this might be acceptable?

The problem with running npm install in the container is that the updates would be lost when the container is restarted.
The only way it would persist would be if the device-agent was on an external volume, which kind of defeats the point of having the device agent in a container.

Requested by - https://app-eu1.hubspot.com/contacts/26586079/record/0-1/11047851

Im not sure if my suggestions are good enough but after some googling i found out that i can update the device agent at scale using ansible , I never had any experience with ansible for now but i think thats the best solution i can think of for now if the flowfuse team does not have any plans on developing this specific features . In addition , i believe it might be helpful if the flowfuse team can provide a working ansible playbook settings and writing tutorial for updating the device agent whether it is running using docker or natively. I believe this might help the flowfuse grow as well , what are your thoughts ? Thanks

Fundamentally, this boils down to the device-agent needing to be able to self-update. The key challenge here is that we aren't going to be aware of how the agent is installed, as Ben mentioned above, there are complexities with Docker for example.
We would need to break this down into common ways that the Device Agent is run, and work out if there is a consistent approach for each, and then establish where there are blockers.

Putting it into "Next" as this will require Engineering Design resource

We would need to break this down into common ways that the Device Agent is run, and work out if there is a consistent approach for each, and then establish where there are blockers.

I have a pretty hot take on this....
If device agent (or a sibling version of it) were in fact a Node-RED plugin (like nr-assistant) that could be installed on Any already running Node-RED instance, we open the doors to a much larger audience.
For example, there are some (very popular) industrial "off the shelf" hardware devices that run Node-RED that will likely never install our device agent due to current installation requirements.  However, if they could get 80% of functionality (deploy flows, visibility/inclusion on a centralised platform (FF), auto snapshots, etc, etc) this could be a real win win for all.
Updating is no longer an npm install task but a palette node update.  One day we may even incorporate a means of instructing the plugin to perform an update! - aka "at scale")

@Steve-Mcl's idea would be very useful because I come across lots of locked down PLCs which run Node-RED as part of their default image but trying to get the device agent on there is very hard. This is often because the PLC manufacturer is concerned about the risk to their customers' security of adding the device agent, they feel it's their responsibility to vet our code. This approach totally sidesteps the need to talk to the PLC manufacturer and opens up loads of places we can run and manage Node-RED.

We did look at some sort of NR plugin originally. I think we would need to be very clear on what it could/couldn't achieve.
Running as a plugin means it cannot modify the Node-RED settings file. This mean:

no integrated security (we can't modify adminAuth or add the required auth middlewares)
no remote editing of flows
no way to manage/update Node-RED itself

That makes for quite a different experience and capability set than the Device Agent we have currently.
I do agree there is scope to have a standard plugin does open up some potential - we already have nr-tools-plugin which hasn't really had any attention since originally published.

Customer requested this today as they're scaling to 200 edge devices. If we have a technical solution here that would be grand.


Does not work on the server

I am faced with the problem that the mod does not work on different servers, should it work on servers at all? The description didn't say! If it should not work on servers, then please make the mod work...

Can confirm on PaperMC and PurpurMC 1.20.2 and 1.20.4 (unstable builds)

This will only work on a Fabric/Quilt server with the mod installed & client installed


unknown response. unable to login

When I try to sign in, after I input my text verification code, i get the error "unknown response. Unable to login."  I am able to login to the web app in my browser, or from the android app. Any help is appreciated.
Platform: PS4
App: Windows FIFA Autobuyer 0.4.2
Notes: I do not have a secondary account
Thanks!

i've got this error when i receive a permanent ban

I do not have a ban.

I think the urls of login had been changed.

Just now downloaded the latest version. Same problem.
0.4.3
Error: unknown response. Unable to login"
Any fix for this?

A fix will be released shortly.  Sorry for the delay.


Fixed a bug that could lead to duplicate advice.

Also improved some property names, and began work on a buildFinished failure handler.

Build failed https://gradle.com/s/xcpakqhbwj3vs


Refactor TF tests for importer/runner split

Much more to do here but wanted to get some preliminary changes in ASAP.
todo:
-- fix repro paths for pytorch/TF tests
-- move tests out of frontend directories into tank//
-- benchmarks (API needs updating!)

Latest commit moves TF and PyTorch tests to model-specific directories in tank/.
Model-specific directories are in camel case to avoid clashing with huggingface model paths.
Also changed all pytorch tests to use device argument instead of hardcoded "cpu", and changed "minilm_mlir" to "mlir_module".
Todo: benchmarks for tf and pytorch tests, save_temps for pytorch tests

PyTorch and TF tests are still in their own directories, this will be fixed in a follow-up commit.


Unable to get messages from non-persistent topics

Issue
I am unable to get messages from non-persistent topics while using wildcard subscription.
Publisher:
PulsarClient client = PulsarClient.builder()
        .serviceUrl("pulsar://localhost:6650")
        .build();
Producer<String> stringProducer = client.newProducer(Schema.STRING)
        .topic("non-persistent://public/default/test1")
        .create();
stringProducer.send(line);

Subscriber:
 client = PulsarClient.builder()
        .serviceUrl("pulsar://localhost:6650")
        .build();
consumer = client.newConsumer()
        .topicsPattern(Pattern.compile("non-persistent://public/default/test[12]"))
        .subscriptionName(new Date().toString())
        .subscribe();
Message msg = consumer.receive();

Expected behavior
I receive the message.
Actual behavior
No messages can be received. While debugging, we noticed that the topic list that client gets from the server by specified regexp is empty.
Server says that the message is actually sent.
After changing non-persistent to persistent, everything works just fine.
While trying to investigate this, we have changed the pulsar:// prefix to http:// and inspected http requests. Client tried to perform request GET /admin/v2/namespaces/public/default/destinations, but failed, and in the server logs there was a TooLongFrameException : Adjusted frame length exceeds 5242880:<PHONE_NUMBER> - discarded. From the Wireshark dump, the request's frame length is totally fine.
Steps to reproduce

Run Pulsar server
Run consumer
Run producer
Try to send the message from producer
See that the message is not received

System configuration
Pulsar version: 2.0.1-incubating

@jiazhai can you help check if regex subscription works for non-persistent?

This is being fixed by #2025, will be included in  the upcoming release.


[10.x] Enhancing updateOrCreate() to Use firstOrCreate()

Summary
This PR proposes a modification to the updateOrCreate() method in line with recent changes brought by the introduction of the createOrFirst() method.
Details

#47973

#48144

In the previous PR by @tonysm, the firstOrCreate() method was enhanced to leverage createOrFirst(), making it more race-condition resistant, especially in highly concurrent environments. This was achieved by attempting to create a record first and, if encountering a unique constraint violation, falling back to find the matching record. This robust approach, however, was not mirrored in the updateOrCreate() method.
To address this and bring consistency:
public function updateOrCreate(array $attributes, array $values = [])
{
    return tap($this->firstOrCreate($attributes, $values), function ($instance) use ($values) {
        if (!$instance->wasRecentlyCreated) {
            $instance->fill($values)->save();
        }
    });
}

By doing this, the updateOrCreate() method will now utilize the enhanced firstOrCreate(), making it more resilient against potential race conditions and ensuring that both methods share a unified and robust approach in concurrent situations.

@taylorotwell With reference to PR #47973, the only method that was internally changed to use createOrFirst is Builder::firstOrCreate from the following list:

Builder::firstOrCreate
HasOneOrMany::firstOrCreate
BelongsToMany::firstOrCreate

For this reason, in this PR, I've only made the adjustment to Builder::updateOrCreate.

Should we aim to establish the dependency chain createOrFirst ← firstOrCreate ← updateOrCreate across all Builder and Relation classes in another PR? Do you have any concerns or reservations about this approach?

@mpyw Oh, nice catch. I forgot to update the relation methods. I'll send a separate PR to address that. I think we better attempt to update all updateOrCreate implementations, so it's consistent across the board.

#48192

Resolves https://github.com/laravel/framework/issues/19372

I'm trying to generate a simple reproduction case, but this change has broken some code for us.
Route::get('test', function() {
    $user = User::findOrFail(11);

    $social = Social::withTrashed()
        ->updateOrCreate(
            [
                'type' => 'facebook_account',
                'external_id' => 'test'
            ],
            [
                'name' => 'test',
                'details' => null,
                'type' => 'facebook_account',
                'external_id' => 'test',
            ],
        );

    $connection = $user->connections()->updateOrCreate(
        [
            'social_id' => $social->id
        ],
        [
            'type' => 'facebook_account',
            'token' => 'test',
            'via_id' => null,
            'details' => null,
            'social_id' => $social->id
        ],
    );
});

This results in an error on the creation of $connection, with social_id being null in the query, despite being in the $fillable array. Reverting the change immediately resolves the error.
Simple repro example is proving tough because both our Social and Connection models are using https://github.com/tighten/parental, but I wanted to note this in case anyone else is encountering the same.

@ceejayoz from what I can see, I don't see why the Connection::updateOrCreate would fail. When you say "fail" what exactly happens? Does it set the social_id to null? Or do you get an exception?
I don't see why social_id would be set to null, since it's being used to find the connection record in the createOrFirst
Both Connection and Social are part of the same hierarchy? I mean, are these models pointing to the same table? If so, does Connection also use the soft-deletes trait?
Can you create an issue for it referencing this PR?

@tonysm The call results in a violation of the not-null constraint on my social_id column; it's null in the final query.
I've drilled down into internals a bit with dumps of the $attributes and $values arrays in a number of spots; it's getting nulled out somewhere but I haven't quite figured out the tap() stuff's impact there. I need to get xcode running on this particular project so I can track it a little more comprehensively.
$fillable is set on both models appropriately, and undoing the change in vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php definitely puts it back to normal operation.
Connection and Social are different models, each with same-table-inheritance submodels (using Parental), i.e. there's a TwitterSocial and a TwitterConnection. Socials have a hasMany Connections on them. Both have soft deletes enabled.
It may be something peculiar to Parental; I'll try and get a minimum example repo put together.

@ceejayoz we reverted from using the createOrFirst in the updateOrCreate methods. Can you check if the issue was resolved?


Universal build for Swift package (calling from Rust, building with Tauri)

Hello! Thank you for your work on this, it's been really nice to use so far. I'm building an app with Tauri and trying to get a universal build going on an M1 Mac, and hit an error during linking.
I have some wrapper scripts around this, but it's effectively running cargo tauri build --target universal-apple-darwin (I tried this on its own to make sure my scripts weren't getting in the way 😅). It failed with:

ld: in /Users/dceddia/recut/target/x86_64-apple-darwin/release/deps/libmything-64d192639b010717.rlib(Exporter.swift.o), archive member 'Exporter.swift.o' with length 209176 is not mach-o or llvm bitcode file '/Users/dceddia/recut/target/x86_64-apple-darwin/release/deps/libmything-64d192639b010717.rlib'

Narrowing it down a bit, I noticed the aarch64 build works fine (cargo tauri build --target aarch64-apple-darwin) but the x86_64 one fails with the same error (cargo tauri build --target x86_64-apple-darwin). Makes some sense I guess because I'm running on an M1 and it would be building aarch64 by default.
My Swift crate's build.rs is patterned after this example. I was hoping that Tauri's universal build would automatically call lipo, and thought I might only need to get the build.rs to respect the current TARGET and let Tauri's build handle the rest. So I modified the compile_swift function in build.rs:
fn compile_swift() {
    let swift_package_dir = manifest_dir().join("mything-swift");

    // Added this:
    // Grab the current TARGET and pull out the first segment of it ("aarch64" or "x86_64")
    let triple = std::env::var("TARGET").unwrap();
    let parts = triple.split("-").collect::<Vec<_>>();
    let arch = parts.first().clone().unwrap();

    let mut cmd = Command::new("swift");

    cmd.current_dir(swift_package_dir)
        .arg("build")
        // Added this:
        // Add the current arch to the swift command
        .args(&["--arch", &arch])
        .args(&["-Xswiftc", "-static"])
        .args(&[
            "-Xswiftc",
            "-import-objc-header",
            "-Xswiftc",
            swift_source_dir()
                .join("bridging-header.h")
                .to_str()
                .unwrap(),
        ]);

    // ...
}

This got the build to work!
I was halfway through writing this issue when I figured it out, and thought I'd just post this in case it helps anyone else.

Not directly related but how do you manage to get autocompletion using this "calling from Rust" workflow ?
Is there a way to signal to vscode or XCode the use of bridging-header.h ?

On the Rust side I have a ‘mod ffi’ similar to the examples in this library. That was enough to get autocompletion of my own functions in VSCode. I wouldn’t expect it could see “beyond” those into Swift anyway; it’s not exposing all of Swift, just the few specific wrappers I wrote. For both Rust and Swift I have the language server plugins installed (rust-analyzer and I forget the name of the Swift one, it was just the most popular one).


Update WhileGlove Requirements

On fighting to test while glove on a rebuilt laptop we ran into an issues where you cannot enter provisioning mode if the AutoPilot profile specifies a langue selection.
In this situation, the Language and region where set as part of the OS install, meaning that on booting the laptop did non prompt the user for a language, keyboard or region and instead went straight to the autopilot login screen, preventing us from entering into the White Glove provisioning options.
Setting the Langue / Region in the Autopilot profile corrected this issue, enabling the provisioning mode to be selected though the use of the Windows key.
This should be clarified in the White Glove documentation to ensure the Langue mode is set to user specified, or provide other way to enter the provisioning menu from the AutoPilot sign in screen

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca5b57d1-61b3-39d4-34ff-d6dcb858c250
Version Independent ID: 42609104-815f-9e7a-39aa-38d92cc910c9
Content: Windows Autopilot for white glove deployment - Windows Deployment
Content Source: windows/deployment/windows-autopilot/white-glove.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

Hi,
Can I get some clarification here?
In the first sentence you said that provisioning mode is blocked if there is a language specified in the Autopilot profile, but in the second paragraph you said that setting the language in the profile corrected the issue.
When you say "provisioning mode" are you referring to the technician flow or the user flow?
Thanks,
-Greg

Hi,
To clarify what I mean, is that if you administratively set a language via
autopilot profiles, the second step in the technician flow is skipped, and
goes automatically to the 4th user flow step ( the branded sign in screen )
without anyway to enter into the white glove provisioning mode.
Removing the pre set language from the auto pilot profiles enables the user
to select there own language, and thus enables a technician to enter  the
white glove provisioning mode.
While the documentation Alludes to this requirement, it would help to
clarify the requirement to NOT pre specify any languages in the autopilot
profile for white gloving to work
Cheers,
Mat
On Mon, 13 Jul 2020 at 18:25, Greg Lindsay<EMAIL_ADDRESS>wrote:

Hi,
Can I get some clarification here?
In the first sentence you said that provisioning mode is blocked if there
is a language specified in the Autopilot profile, but in the second
paragraph you said that setting the language in the profile corrected the
issue.
When you say "provisioning mode" are you referring to the technician flow
or the user flow
https://docs.microsoft.com/en-us/windows/deployment/windows-autopilot/white-glove#user-flow
?
Thanks,
-Greg
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-itpro-docs/issues/7121#issuecomment-657688974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHR76YSOH4OOROWX7W6RKTR3M7RPANCNFSM4OVQPWGA
.

@naylormat - Just to clear one more thing, Can have you tired pressing Windows key for 5 times to enter in the technician provisioning mode.

Yep, tried - once at the login prompt you cannot enter into the technician
provisioning mode
On Sat, 25 Jul 2020 at 19:11, ImranHabib<EMAIL_ADDRESS>wrote:

@naylormat https://github.com/naylormat - Just to clear one more thing,
Can have you tired pressing Windows key for 5 times to enter in the
technician provisioning mode.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-itpro-docs/issues/7121#issuecomment-663884589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHR7667BJBUIMB4PGNKZH3R5MN4FANCNFSM4OVQPWGA
.

Closing via #7984


Update .env.example to include instructions on not to delete

Fork from the Add-Event-Form branch. When completed, pull request into the Add-Event-Form not main. Instructions on how to contribute can be found here
Add //Please copy and paste this template into a new .env file instead of removing .example from the file name to the first line of the .env.example file.
Additionally, change the formatting of value pairs to match DB_STRING = YOUR_DATABASE_URI. Port does not need to be re-formatted.

Hello, I'd like to try this issue!

All yours!


[SparkLoad] dpp sort and aggregate stage parallel optimization

Enhancement
Current dpp repartitionAndSortWithinPartitions implementation needs to sort and aggregate all the data in a tablet, and finally generate one intermediate file for each tablet. In the loading phase, be will download the intermediate file corresponding to the tablet and generate a nonoverlapping rowset.
If the amount of data is very large and the buckets are very small, the parallelism of repartitionAndSortWithinPartitions will be very low, and the processing will be very slow.
Suggested optimizations:
Improve the parallelism of repartitionAndSortWithinPartitions, which can be extended to multiples of buckets, so that dpp may generate multiple intermediate files for each tablet, and finally generate an overlapping rowset (one intermediate file generates one segment).

Anyone who are interested can optimize it.


Remove nginx from the stack

It's actually not need for security reason, only the Docker network is.

[ ] Update the README to reflect this change

In docker-compose.yml, specifying a port is incompatible with specifying an internal Docker network. The container will start but the app can not be reached. I tried adding both an internal and default network, but this did not helped. Therefore we still need to keep nginx in front of the container of an NLP tool to prevent it from accessing internet.


Build fails on Linux Mint 19.3

I am trying to build the latest release of GafferCycles (0.18.2) with all the dependencies. I cloned the repo, built all the dependencies before the actual build. When I get to the actual build, I get the error in the following paste bin: https://pastebin.com/EnTNyYDq
Any ideas what might be causing the issue?

Hi @amsaid1989
Looks like some environment variables are not being set so it cannot find the oslc compiler.
export GAFFER_ROOT=<gaffer install path>
export GAFFERCYCLES=<install destination>
export LD_LIBRARY_PATH=$GAFFER_ROOT/lib

The notable ones are setting the $GAFFER_ROOT to point to where gaffer is installed (this contains the oslc compiler) and $LD_LIBRARY_PATH so that the boost library can be found which is one of the dependencies of oslc and a part of Gaffer itself.
Hope this helps

That is very strange. I had all these variables set, but I will try it again, maybe I had a typo in one of them or something. Thanks for the help, Alex. I will test and update you.

All good @amsaid1989 ? It's a bit tricky to build, feel free to re-open and I can assist.

Really sorry, Alex. Got really busy in the past couple of months and haven't managed to retry building it. Once I have some time, I will try again and reopen the issue if I am still having problems.


Make deep method work with make_da_pipeline

Deep methods can not be put in a make_da_pipeline since the pipeline detects it like an estimator, which should not get access to target data.

I guess we can close this one as #159 is already merged, right @tgnassou ?


get and update technology handles for the sdk

I think the docs are a bit out of date. https://auroraenergyresearch.github.io/aurora-origin-python-sdk/docs/category/sdk-reference
I'd like to see some of the more complicated technology queries with lots of variables in the common patterns.
The code is overall very readable and I think it will be easy to extend to include new fields and easy to copy for new datagroups.
I question how we'll deploy the changes out to users and if we can do it seamlessly enough to not be a nuisance when we add a new plant field for example.

I can't 100% verify the code matches the GQL schema is all cases but I hope you've tested it


Have vscode-vue closely follow vscode.typescript-language-features

There are a few bugs I'm experiencing when trying to use takeover mode, and while I could report them all and effort could be made to fix them, the reality of the matter is that it will always be behind vscode.typescript-language-features in quality and require a bunch of extra effort.
Instead the vscode-vue extension should probably make direct use of the vscode.typescript-language-features source, such that all the functionality responsible for interfacing with VS Code already implemented there is not implemented again by vscode-vue, but instead only the additions and improvements it provides (such as for example using the Vue language server) are.

This problem is not specific to Volar, typescript-language-server is also rewriting all the code needed.

To be fair there exists https://github.com/yioneko/vtsls which uses a different approach that is easier to keep in sync with vscode but I feel that it probably has its pain points too. Maybe one of them is that it needs to shim various things and it doesn't help clarity of the code.

Maybe it's time to open a PR for VSCode to migrate that code. 😅


[flink] Enhance filter push down to consume partition filter

Purpose

Linked issue: close #2127
This PR is the substitution of https://github.com/apache/incubator-paimon/pull/2151. This PR not using partition push down  solution. The main cause is to avoid the list partition operation which may be heavy when files are large.
So, we use another way by consuming the partition filters which are sure to be evaluated by the source.

Tests

API and Format

Documentation

CC @JingsongLi

A simpler way can be: Implement a PredicateVisitor instead of a ExpressionVisitor. We can just only visit the Predicate passed by paimon-flink PredicateConverter. We just need to judge LeafPredicate.

Updated


Returned models have incorrect date times when using toJSON()

In my case I'm using MySQL which return DateTimes in UTC in the following format:
2015-06-19 21:00:00
When being parsed into the model, this datetime column becomes a Date object, and since it's lacking any timezone information it gets parsed as being in the local timezone. For an example I'll take my local timezone which is UTC+1. It becomes:
Fri Jun 19 2015 21:00:00 GMT+0100 (BST)
When running toJSON on the model, toJSON is also invoked on the Date object. Which then converts the time to:
2015-06-19T20:00:00.000Z
Note that the +1 UTC offset has now in affect been applied to the time, and the time is now 8pm instead of 9pm as returned by the database.

This issue already has a discussion here https://github.com/tgriesser/bookshelf/issues/44 so I'm closing this


correctly handle cargo +toolchain public-api

When using rustup shims, rustup sets and uses the RUSTUP_TOOLCHAIN variable which rustup and its shims use to get the specified or defaulted +toolchain.
With this change, cargo +nightly public-api or cargo +stage2 public-api etc. will work as expected.
This pr deprecates the --toolchain command as it's no longer needed.

will squash if all looks good
one comment from me as a contributor, I'd hugely recommend adding a #[warn(...)] for everything that is gated by ci, confusing with no clippy warns locally (and not using the script)

one comment from me as a contributor, I'd hugely recommend adding a #[warn(...)] for everything that is gated by ci, confusing with no clippy warns locally (and not using the script)

So far I have deliberately stayed away from enforcing lints in code, because that makes e.g. git bisect in a code base a nightmare. With #[deny(...)] at least. It should be fine to have #[warn(...)] I guess.
I weight your input as a contributor very high, so I will add #[warn(...)] in the code in the near future,  and  keep deny in CI. I think the downside of duplicated configs and warnings during e.g. git bisect is smaller than the upside of having lint warnings "in-band".
Feel free to create a PR for that too! (But you are absolutely not required to do so of course, I will do it myself as soon as I get time)

Yep, deny in code is generally bad, warn is fine though. See https://github.com/rust-unofficial/patterns/blob/main/anti_patterns/deny-warnings.md
using deny can also make it so that consumers will fail if new lints are added and you deny on a group (like clippy::pedantic)

One thing I could do, is set the tests
broken_pipe
print_diff
print_diff_reversed
print_no_diff
print_public_api
print_public_api_with_blanket_implementations

behind a #[cfg_attr(not(nightly), ignore)] by introducing a build script which does

use rustc_version::{version, version_meta, Channel};

fn main() {
    // Assert we haven't travelled back in time
    assert!(version().unwrap().major >= 1);

    if matches!(version_meta().unwrap().channel, Channel::Nightly | Channel::Dev) {
        println!("cargo:rustc-cfg=nightly");
    }
}

It became too complex to continue with code review comments to communicate my vision for how to solve this problem, so I wrote some code instead: https://github.com/Enselic/cargo-public-api/pull/119
Looking forward to your input!

I've revamped this a bit, I now understand what you were going for with your comments after seeing #119 and I think this should satisfy that now

Meh, who wants to wait for releases? Not me.
Released as https://github.com/Enselic/cargo-public-api/releases/tag/v0.15.0 (🥳)


(googlechrome) Include master_preferences file

When installing the Google Chrome Enterprise MSI, a file called master_preferences can be placed alongside chrome.exe in the install destination folder (%ProgramFiles%\Google\Chrome\Application\) to configure Chrome and control how it first launches.
It would be great if there was a flag on the Chocolatey package to specify a path to a master_preferences file to be included in the installation. Ideally we'd include both local drive & URI support.
Notes:

Google will be changing the name of this file to initial_preferences.json in Chrome 88, so it would probably be best to just take whatever file is specified and leave the name alone.
Some documentation on the master_preferences file here:

https://support.google.com/chrome/a/answer/187948
https://www.chromium.org/administrators/configuring-other-preferences

Expected Behavior
Examples:
choco install googlechrome --package-parameters="/PreferenceFile='C:\InstallFiles\master_preferences'"
choco install googlechrome --package-parameters="/PreferenceFile='C:\InstallFiles\initial_preferences.json'"
choco install googlechrome --package-parameters="/PreferenceFile='http://mydomain.com/InstallFiles/master_preferences'"

Each of these variants would install the Chrome enterprise MSI like normal, but then copy the specified file to the Chome install directory (%ProgramFiles%\Google\Chrome\Application\) as its final step.
The name of the file would not be changed from the specified name, but would overwrite any previously-existing file. (Chrome includes a very simple master_preferences file by default.)
Chocolatey would throw an exception if the specified file was not found, could not be downloaded, or otherwise could not be copied to the install directory.
Current Behavior

Use Chocolatey to install Chome
Copy/download master_preferences file from wherever I have it stored
Handle any exceptions manually

Context
Mostly cosmetic; I'd love to be able to shrink all my Chocolatey installs to 1-liners, instead of requiring multiple lines & error handling to fully install and configure one app.

Mostly cosmetic; I'd love to be able to shrink all my Chocolatey installs to 1-liners, instead of requiring multiple lines & error handling to fully install and configure one app.

https://github.com/chocolatey/choco/issues/1185 is probably what you want.

Mostly cosmetic; I'd love to be able to shrink all my Chocolatey installs to 1-liners, instead of requiring multiple lines & error handling to fully install and configure one app.

https://github.com/chocolatey/choco/issues/1185 is probably what you want.

I agree with @TheCakeIsNaOH that it would be better served through a hook (which is what the linked issue is about).
But due to the lack of it, it is definitely something that could be implemented in the package itself.
Not sure if allowing downloading a file would be appropriate though, but a local file is something that could be added.

I agree with @TheCakeIsNaOH that it would be better served through a hook (which is what the linked issue is about).
But due to the lack of it, it is definitely something that could be implemented in the package itself.
Not sure if allowing downloading a file would be appropriate though, but a local file is something that could be added.

Whats wrong with cp ?

Whats wrong with cp ?


(refactor): switch the ansible plugin to use github.com/operator-framework/ansible-operator-plugins, remove ansible code

Description of the change:

Removes ansible plugin and ansible-operator logic in favor of using the new https://github.com/operator-framework/ansible-operator-plugins repo for housing this logic. We now import the ansible plugin from this new repo
There should be no user facing changes

Motivation for the change:

resolves #6355

Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

Not sure why the e2e-molecule check still shows up as expected. Going to try closing and re-opening to see if it clears it up

/override e2e-molecule

Might want to remove deploy-manual step from the releasing guide. Otherwise lgtm

@oceanc80  done in https://github.com/operator-framework/operator-sdk/pull/6583/commits/9e103097b89cf63b64203cd3647af90d1a94d946

/override e2e-molecule


npm audit accusing 10 vulnerabilities on dependencies

Hello all.
As shown at the attachment, there are 10 vulnerabilities on dependencies os this package. And one of then is high risk.
Would be a good idea update everything.
pjbank.txt

Thanks for report! We just published the version v1.0.6 with these security updates.
https://github.com/pjbank/pjbank-js-sdk/pull/35


Fix 'no attribute pkb_thread_log_context' error for sub-thread logs

The logging filter assumes that log_util.SetThreadLogContext was called
in the current thread, but this is not the case for ad-hoc threads
created by threading.Thread() or similar. This broke timeout handling
since it tried to log a message before killing subprocesses.
Includes a test to ensure logging works for plain threads.

LGTM


Documentation source code doesn't match example screenshot for Icon Button

https://docs.nativebase.io/Components.html#button-icon-headref
On the screenshot you can see a few icon buttons that have only icons, no text, but there is no corresponding source code. I'd fix it myself, but I'm trying to work out the simplest way to accomplish it!

I restarted my simulator and it became obvious, never mind.


Added Python 3.x support and PyPy support

There's no build so I don't have a way to test this yet.

Obsolete by #193


Switch: Add topic, indicator, and message pass through options

Description
A Topic field and message pass through option need to be added to ui-switch node
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I am no FlowForge team member

Also the Indicator options (Show state of input/ouput).
Edited title to include this.

Thanks for opening this Colin. The status indicators are implemented:

They don't seem to populate on first start of Node-RED, or when the toggle is first added to the canvas (to show off state by default) is that the same as you're experiencing?

Sorry, I should have been clearer, it is this (from D1 switch) that I am referring to

In fact that may already be implemented, as it only appears when message pass through is disabled, which cannot be done at the moment as the option is not available.

If a switch has, for example topic set to a string of Hello World, would you expect this topic to also be attached when passing a message for selection through to the switch? Or, only bind that topic when an explicit UI-side change is done?

I don't have a strong feeling on this, but I have tested the situation with D1 and it passes on the complete message, but overwrites the topic with that from the node config.  It should only action it and pass it on if the payload matches the On or Off config in the node.

I don't think this is fully fixed.  The indicator selection described above (Switch icon shows state of input/output) that should appear when pass through is disabled is not there (for me at least).

Also the switch status shown in the editor does not always follow the switch position when a message is fed in.
Import this flow and click the inject nodes, the switch correctly changes state on the dashboard but the status in the editor does not.
[{"id":"7b349d5ce88ed6bf","type":"inject","z":"6e4dd70a4b804955","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/topic","payload":"ON","payloadType":"str","x":210,"y":920,"wires":[["f243dafd7c3b2a1a"]]},{"id":"453d7cf255841fde","type":"inject","z":"6e4dd70a4b804955","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"test/topic","payload":"OFF","payloadType":"str","x":210,"y":960,"wires":[["f243dafd7c3b2a1a"]]},{"id":"f243dafd7c3b2a1a","type":"ui-switch","z":"6e4dd70a4b804955","name":"","label":"switch","group":"ec06ac72ac8562eb","order":0,"width":0,"height":0,"passthru":false,"topic":"topic","topicType":"msg","style":"","className":"","onvalue":"ON","onvalueType":"str","onicon":"","oncolor":"","offvalue":"OFF","offvalueType":"str","officon":"","offcolor":"","x":370,"y":940,"wires":[["5568977077a8940e"]]},{"id":"5568977077a8940e","type":"debug","z":"6e4dd70a4b804955","name":"debug 23","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":560,"y":940,"wires":[]},{"id":"ec06ac72ac8562eb","type":"ui-group","name":"test","page":"46dfd140ddb08ebf","width":"6","height":"1","order":-1,"disp":false},{"id":"46dfd140ddb08ebf","type":"ui-page","name":"Test","ui":"04ee189a49c54f22","path":"/","layout":"grid","theme":"23aa79f4e489b044","order":-1},{"id":"04ee189a49c54f22","type":"ui-base","name":"Dashboard","path":"/dashboard"},{"id":"23aa79f4e489b044","type":"ui-theme","name":"Theme 1","colors":{"surface":"#ffffff","primary":"#514fba","bgPage":"#eeeeee","groupBg":"#ffffff","groupOutline":"#cccccc"}}]

If pass through is disabled, and the switch icon is set to follow the state of the input, then when the button is clicked it sends the message (on or off as appropriate) but the switch does not move.  The switch icon always displays the state of the last message received.  Typically this mode is used in a flow something like

When the switch is clicked it sends the on/off command to the appropriate device, but the switch does not immediately move.  When the command has been actioned the new state is received and switches the display.  Normally this will be so quick that it appears to be immediate, but it ensures that the displayed state always matches the state of the actual device.  The fact that the incoming message is not passed through ensures that a loop is not created.

Thanks @colinl - great description, and a clear articulation on the value there. I've opened the issue accordingly, as this is not what I had in scope (or in my mind) when we've spoken previously.


Update readme to cover all major functionality

Stored supporting images in a subfolder of /site because that seemed like the least weird place for them.

read through and it looks wonderful. Thanks!