Unable to use PowerShell 7.2.x in Azure Virtual Desktop

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
We are in the process of upgrading from PowerShell 7.0.2 to 7.2.2 and noticed that whilst via RDP you can type in to the command prompt when accessed via Azure Virtual Desktop all you can do is copy and paste in commands; you cannot type. Updated PSREADLINE module per another article reporting a similar issue with no success.
If I deploy the preview release of PowerShell 7.3.0 r3 the command prompt works exactly as it should with no issues both via an RDP session and in Azure Virtual Desktop.
Expected behavior
PS> Get-Module

Actual behavior
PS>

Error details
No response
Environment data
PSVersion 7.2.3
PSEdition Core
GitCommitID 7.2.3
OS Microsoft Windows 10.0.19043
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion <IP_ADDRESS>
WSManStackVersion 3.0

Visuals
No response

@SeeminglyScience Do you have access to an instance of Azure Virtual Desktop that can be used to reproduce this issue?

I do not :/ PowerShell is blocked entirely on mine.

Thank you @wdiggle  for submitting this issue. I haven't been able to repo this yet - our internal AVD is very restrictive.  Im in the process of accessing a full customer AVD to test this issue.

@wdiggle - I spoke with the AVD team, and following their testing suggestions, could not reproduce this error.  My testing environment is not the same as the customers, and AVD recommends that customers experiencing this problem file an issue so they can attempt to repo.
The AVD team has recommended that customers file an issue in Feedback Hub from the AVD host encountering the issue.  Please select the category “Problem”, followed by “Apps” and “Remote Desktop”.  Screenshot below.

￼

The key to testing is using the web client and not the AVD remote desktop client which works fine. Knowing the AVD team they will have tested using the remote desktop client app. For the moment we are finding that the preview installations work fine so will continue with that for now.
Thanks.

This email (including any attachments) may contain information that is confidential and legally privileged and which should not be disclosed. If you are not the intended recipient of this email, or you have received this email in error, any review, disclosure, copying, distribution or other use of (and/or acts or omissions in reliance on) its contents is strictly prohibited and you should notify the sender and delete the email (together with all copies and attachments) immediately.
We have used our reasonable endeavours to scan all attachments for viruses and other malicious or harmful code. However, we cannot accept liability for any loss or damage you may incur as a result of virus infection or other malicious or harmful code. You should ensure your systems protect against such threats.
Any personal information that you provide to us will be dealt with in line with our privacy policy, which explains what personal information we collect from you, how and why we collect, store, use and share such information, your rights in relation to your personal information and how to contact us and supervisory authorities in the event you have a query or complaint about the use of your personal information. Our privacy policy is available on request.
Telefónica Tech UK Limited is a limited company (Registered number: 2563193) registered in England and Wales whose registered office is at East House, New Pound Common, Wisborough Green, West Sussex, RH14 0AZ.
Telefónica Tech UK Managed Services Limited is a limited company (Registered number: 04434288) registered in England and Wales whose registered office is at East House, New Pound Common, Wisborough Green, West Sussex, RH14 0AZ.
Telefónica Tech Northern Ireland Limited is a limited company (Registered Number: NI028408) registered in Northern Ireland whose registered office is at Concourse Building 3, Queens Road, Belfast, Northern Ireland, BT3 9DT.
Telefónica Tech Ireland Limited is a limited company (Registered Number: 438959) registered in Ireland whose registered office is at Unit 5B Unit 5H, Fingal Bay Business Park, Balbriggan, Co.Dublin, Dublin, Ireland.
Telefónica Tech UK&I, previously known as CANCOM UK&I, was acquired by Telefónica Tech in July 2021. In the UK and Ireland, Telefónica Tech is the brand name for the following legal entities: Telefónica Tech UK Limited*, Telefónica Tech UK Managed Services Limited*, Telefónica Tech Northern Ireland Limited* and Telefónica Tech Ireland Limited*. Telefónica Tech will be used to refer to any or all of these entities throughout this document/communication.
*All four were CANCOM entities until their official name change to Telefónica Tech at the start of October 2021.
From: Jason Helmick @.>
Sent: Wednesday, July 6, 2022 3:39 PM
To: PowerShell/PowerShell @.>
Cc: William Diggle @.>; Mention @.>
Subject: Re: [PowerShell/PowerShell] Unable to use PowerShell 7.2.x in Azure Virtual Desktop (Issue #17201)
@wdigglehttps://github.com/wdiggle - I spoke with the AVD team, and following their testing suggestions, could not reproduce this error. My testing environment is not the same as the customers, and AVD recommends that customers experiencing this problem file an issue so they can attempt to repo.
The AVD team has recommended that customers file an issue in Feedback Hub from the AVD host encountering the issue. Please select the category “Problem”, followed by “Apps” and “Remote Desktop”. Screenshot below.
[Screen Shot 2022-07-06 at 7 22 33 AM]https://user-images.githubusercontent.com/12662278/177576447-9c18eae1-58b8-4389-82bb-d0bbc782e595.png
￼
—
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/PowerShell/issues/17201#issuecomment-1176304615, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQHUD63ZCASL4R5PIK3GYDDVSWK6NANCNFSM5UOUX5WA.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@wdiggle This was already fixed in the 2.2 version of PSReadLine by https://github.com/PowerShell/PSReadLine/pull/2632.
The v7.2.x of PowerShell ships the v2.1.0 PSReadLine which doesn't have that fix. Please upgrade to v2.2.6 of PSReadLine. See https://github.com/PowerShell/psreadline#upgrading for instructions if you are not familiar with upgrading PSReadLine.
For details about how the root cause is discovered, see the comment thread starting at https://github.com/PowerShell/PowerShell/issues/17783#issuecomment-1211236702.


Request model

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Fixed issues
request model

Example integration https://github.com/romkatsu/yii-api-demo/pull/1

Great job! Thank you.


process.getuid is not a function on windows

C:\Users\admin\AppData\Roaming\npm\node_modules\figma-backup\lib\Bot.js:149
const isRootUser = process.getuid() === 0;
^
TypeError: process.getuid is not a function
at Bot.start (C:\Users\admin\AppData\Roaming\npm\node_modules\figma-backup\lib\Bot.js:149:36)
at startBot (C:\Users\admin\AppData\Roaming\npm\node_modules\figma-backup\lib\index.interactive.js:100:8)
at run (C:\Users\admin\AppData\Roaming\npm\node_modules\figma-backup\lib\index.interactive.js:104:11)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
using this commands
npm install -g figma-backup
npm update -g figma-backup
trying with yarn also.
node modules folder also created .
any idea??

@MohammadrezaMasoumi
This issue should be fixed now.
Try to get the latest version of the package. (Update to the latest version: npm update -g figma-backup)

@MohammadrezaMasoumi
This issue should be fixed now.
Try to get the latest version of the package. (Update to the latest version: npm update -g figma-backup)

thanks


Cannot find module 'react-router/lib/HashHistory'

I have an issue with HashHistory, when i run gulp get:
gulp-notify: [Compile Error] Cannot find module 'react-router/lib/HashHistory' from '/www/react/react-news/src/js'
I find one  issue post at  react-router.
It look's like we need update the file '/src/js/routes.jsx'.

This was a react-router version issue. Should be fixed as of ea5711eb0915b7fa4fb7240f1024e97c35ae2a2c.


Connecting a Postgres Database

By default, I am using the Django default SQLite Database, and want to shift to Postgres.

Hello @amandewatnitrr,
I am interested in working on the issue. Would it be possible for you to assign it to me?

Sure, make sure to make changes in a separate branch, by your name, don't merge it to the master directly.

This issue is assigned to you @kiranrokkam09 .

Hello @amandewatnitrr,
Have you already created a PostgreSQL database? If you have, could you please provide me with the details of the database?

@kiranrokkam09 I haven't created one yet.

@amandewatnitrr ok then let me create one for you.

@amandewatnitrr I need your information to make an account on Railway.app, or you can create an account there and send me your information.


PDBFixer 1.6

The tests are failing for reasons that I think are unrelated to this change:
Can't build /io/assaytools due to environment creation error:
The following specifications were found to be in conflict:
  - assaytools 0.3.0 py37_1

Should I go ahead and merge this?

@peastman Assaytools always fails -- It won't affect your build.
It looks like my openforcefield_forcefields package is also rebuilding for some reason. I probably need to debug that. That may slow down the builds, but shouldn't affect anything other than the speed.
This looks like it's good to merge.

Thanks!

It looks like my openforcefield_forcefields package is also rebuilding for some reason.

@j-wags : This is probably due to conda-build-all not checking against the package channel that openforcefield_forcefields was pushed to---you called it the dev channel, which is not checked by default:
https://anaconda.org/omnia/openforcefield_forcefields/files
I'd suggest either (1) using a channel that is checked by default, such as rc or beta (I think), or (2) if you need nightly dev builds, using the conda-dev-recipes repo.


TextField's text is duplicated on iOS Japanese Keyboard

TextField's text is duplicated on iOS with Japanese Keyboard at v1.20.0-0.0.pre(and also confirmed that is is also broken at latest master 1.20.0-1.0.pre.91).
This was also reproduced at v1.15.21 and fixed at v1.16.0(#52718, @dnfield), but afterwards it was broken again.
On Android, there are no problems.
Steps to Reproduce
Run this on iOS simulator or device(I confirmed it by iPhone 11 Pro simulator with iOS 11.5).
import 'package:flutter/material.dart';

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({Key key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: HomePage(),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({Key key}) : super(key: key);
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TextField(),
      ),
    );
  }
}

Full restart the app
Focus to the text field
Firstly, Japanese keyboard is selected

If not, select Japanese keyboard and do full restart again

Type 「あ」
Type 「か」
Type 「さ」

Expected results:
「あかさ」should be shown and 「あかさ」is selected until return key typed.

Actual results:
「あああかあかあかさあかさ」was shown and text wasn't selected(no underline).

Logs
[   +9 ms] DevFS: Created new filesystem on the device
(file:///Users/mono/Library/Developer/CoreSimulator/Devices/129D38BF-AA4E-4678-BA05-2447CC2CD83E/data/Containers/Data/Application/D5228312-DE45-44A0-80B
D-C90BD9747D60/tmp/flutter_playgroundOtRcms/flutter_playground/)
[   +1 ms] Updating assets
[ +126 ms] Manifest contained wildcard assets. Inserting missing file into build graph to force rerun. for more information see #56466.
[   +9 ms] Syncing files to device iPhone 11 Pro...
[   +1 ms] Scanning asset files
[   +2 ms] <- reset
[        ] Compiling dart to kernel with 0 updated files
[   +1 ms] <- recompile package:flutter_playground/main.dart 1a4440e7-5c9b-4cbc-92f4-7e1b2af1daba
[        ] <- 1a4440e7-5c9b-4cbc-92f4-7e1b2af1daba
[  +35 ms] Updating files
[  +63 ms] DevFS: Sync finished
[        ] Syncing files to device iPhone 11 Pro... (completed in 105ms)
[        ] Synced 1.4MB.
[        ] <- accept
[   +1 ms] Connected to _flutterView/0x7fdc21031a20.
[   +1 ms] Flutter run key commands.
[   +1 ms] r Hot reload. 🔥🔥🔥
[        ] R Hot restart.
[        ] h Repeat this help message.
[        ] d Detach (terminate "flutter run" but leave application running).
[        ] c Clear the screen
[        ] q Quit (terminate the application on the device).
[        ] An Observatory debugger and profiler on iPhone 11 Pro is available at: http://<IP_ADDRESS>:61165/9N94MyvFWLw=/

❯ flutter analyze
Analyzing flutter_app...
No issues found! (ran in 6.8s)

[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.5 19F101, locale en-JP)
    • Flutter version 1.20.0-0.0.pre at /Users/mono/Git/flutter
    • Framework revision d9653445f4 (8 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/mono/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2019.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 37.0.3
    • Dart plugin version 191.7830

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • Android SDK built for x86 • emulator-5554                        • android-x86    • Android 10 (API 29) (emulator)
    • iPhone 11 Pro             • 129D38BF-AA4E-4678-BA05-2447CC2CD83E • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
    • macOS                     • macOS                                • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server                • web-server                           • web-javascript • Flutter Tools
    • Chrome                    • chrome                               • web-javascript • Google Chrome 83.0.4103.106

• No issues found!

Couldn't reproduce it on an iOS 13.5 device. I created a new project, replaced the main.dart file with the code provided and ran it against the latest master branch.
• Framework revision 9c3f0faa6d (7 hours ago), 2020-06-17 18:47:54 -0400
    • Engine revision 965fbbed17
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)

I noticed that in your 2nd clip (iOS) the battery indicator icon didn't turn dark when the app launches. That bug should be fixed a few months ago. Could you double check if you're really testing against 1.20.0-1.0.pre.91?

@LongCatIsLooong
Thanks for the quick response 🙏

I noticed that in your 2nd clip (iOS) the battery indicator icon didn't turn dark when the app launches.

The simulator was dark mode, and after changing it to light mode, the icon color turned to dark correctly.

Could you double check if you're really testing against 1.20.0-1.0.pre.91?

I confirmed that the version is correct.
These are important steps to reproduce the issue(so, my second clip is recorded before the app was launched):

Full restart the app
Focus to the text field
Firstly, Japanese keyboard is selected

If not, select Japanese keyboard and do full restart again

After switching keyboard or trying second time, text input works well.

Hmm I think I did exactly that. Before I started recording, I launched the app, switched the keyboard to Japanese, and force killed the app from the app switcher. Then I launched the app again and started recording the gif above. Let's wait and see if anyone else can reproduce this.

@LongCatIsLooong

I created a new project, replaced the main.dart file with the code provided and ran it against the latest master branch.

Indeed, by this procedure, the issue isn't reproduced 🤔
Actually, it was reproduced on my other project with dev channel, and after that I verified the issue here with latest master channel(1.20.0-1.0.pre.91):
https://github.com/mono0926/flutter_playground/blob/master/lib/main_text_field.dart
flutter run -t lib/main_text_field.dart

This is plain project, created quite a while ago.
And I was doing some additional research now and it stopped reproducing 🤔
(And on the other project, it keeps broken.)
I'm very confused now, but I'll keep examining for a while.
Thanks!

I couldn't reproduce it with current master 1.20.0-1.0.pre.91 on both iPhone 7 iOS 13.5 and iPhone 11 Pro iOS 13.5 (simulator).
But It reproduced with current dev 1.20.0-0.0.pre on iPhone 7 iOS 13.5, but not on simulator.

I created a new project using the latest dev branch and run that against the current upstream/master, still couldn't repro. However the current dev branch is indeed broken (it's already listed as a bad build for a different reason: https://github.com/flutter/flutter/wiki/Bad-Builds).
@mono0926 @VladyslavBondarenko could you try switching to the master channel and upgrading flutter to the latest version (flutter doctor -v would be helpful so that we can see the engine/dart hash), and see if it still happens on any of your projects?

@LongCatIsLooong
My verification result is same as this:

Reproduces when running with any current flutter version (stable 1.17.3, beta 1.19.0-4.1.pre, dev 1.20.0-0.0.pre or master 1.20.0-1.0.pre.91 on iPhone 11 Pro iOS 13.5 (simulator), but with condition that project is created with current dev (doesn't reproduce when project is created with master).

(doesn't reproduce when project is created with master).
and see if it still happens on any of your projects?

Although there are no problems with clean master project, I'm in trouble with my existing project.
On my exiting project, the problem is reproduced with master channel and I don't know how to fix it.

could you try switching to the master channel and upgrading flutter to the latest version (flutter doctor -v would be helpful so that we can see the engine/dart hash)

Here it is.
[✓] Flutter (Channel master, 1.20.0-1.0.pre.111, on Mac OS X 10.15.5 19F101, locale en-JP)
    • Flutter version 1.20.0-1.0.pre.111 at /Users/mono/Git/flutterm
    • Framework revision bdbe6774a3 (5 minutes ago), 2020-06-18 15:30:00 -0700
    • Engine revision 965fbbed17
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/mono/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2019.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 37.0.3
    • Dart plugin version 191.7830

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • Android SDK built for x86 • emulator-5554                        • android-x86    • Android 10 (API 29) (emulator)
    • iPhone 11 Pro             • 129D38BF-AA4E-4678-BA05-2447CC2CD83E • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
    • macOS desktop             • macos                                • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server                • web-server                           • web-javascript • Flutter Tools
    • Chrome                    • chrome                               • web-javascript • Google Chrome 83.0.4103.106

@LongCatIsLooong
I needed to stress that problem is not with master.
Probably I applied regression label incorrectly, I meant regression in relation to fixed https://github.com/flutter/flutter/issues/52718.
This is master version used yesterday, which didn't have the problem
Flutter 1.20.0-1.0.pre.91 • channel master • https://github.com/flutter/flutter.git
Framework • revision 9c3f0faa6d (11 hours ago) • 2020-06-17 18:47:54 -0400
Engine • revision 965fbbed17
Tools • Dart 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)

This is current dev, which has the problem
Flutter 1.20.0-0.0.pre • channel dev • https://github.com/flutter/flutter.git
Framework • revision d9653445f4 (9 days ago) • 2020-06-09 18:43:03 -0400
Engine • revision e8c13aa012
Tools • Dart 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

Looks like it's fixed somewhere in between.

Current master doesn't have the problem the same as yesterday's master
[✓] Flutter (Channel master, 1.20.0-1.0.pre.118, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.20.0-1.0.pre.118 at /Users/nevercode/dev/flutter
    • Framework revision 8665e13801 (6 hours ago), 2020-06-18 18:08:01 -0700
    • Engine revision b5f5e6332c
    • Dart version 2.9.0 (build 2.9.0-17.0.dev 54481776c9)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • Nevercode’s iPhone • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.5
    • iPhone 11 Pro      • 6DD22F23-00CF-4A8B-B9E2-AC4DE0B5D263     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
    • macOS desktop      • macos                                    • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server         • web-server                               • web-javascript • Flutter Tools
    • Chrome             • chrome                                   • web-javascript • Google Chrome 83.0.4103.106

• No issues found!

FYI the problem still exists on master (at least part of it). I'm experiencing some problems running flutter using a recent engine commit, so I'm not sure exactly why it works on master, but it seems in the framework EditableText now has more robust handling of iOS text input plugin messages.


Revert "CreateGalleryItem parameter in New-Server2016VMImage and checking for trailing / in ArmEndpoin URL"

Reverts Azure/AzureStack-Tools#95

@MatthewMcGlynn,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


DBZ-4703 Enable DEBUG logging for LcrEventHandler for tests

https://issues.redhat.com/browse/DBZ-4703

Applied to main (=1.9)


Data table data filter option, Column level search functionality [Question]

Hi All and @travist
Question: How to add a column-level search option in the data table, like the below-attached image I need to provide a filter option to the end-user.

Here using Search Name, Search Position, Office, Age, Start date, and Salary textbox users can filter the data on the UI side. Note: Only search for the data which is available on the page/UI, no need to make any API calls when searching.
I have referred to the angular-formio Data Table, But not able to find a search option related code.
Tech I am using Angular 9
formiojs: "^4.8.0-rc.12"
angular-formio: "^4.6.7"
Any example/reference related to the above question will help, Thanks.

We do not have a search option in our "built-in" grid feature. It would need to be added. The other alternative is you can hook up any grid library to the API's provided by the Form.io submission API's.

ok, thanks

Hi All and @travist
Is there is any way to detect the TextField onChange, instead of capturing Form onChange
(OR )
Is there is any way to add a custom function(trigger) to the TextField, So that I can write my own logic to filter the data for the data table, like the screenshot attached in the previous message?

You can do something like this.
var textFieldChange = Formio.Components.components.textfield.prototype.onChange;
Formio.Components.components.textfield.prototype.onChange = function() {
  console.log('Textfield has changed!!!');
  return textFieldChange.apply(this, arguments);
};

@Kadhiresan-K can you please share the code snippet you used to achieve the column level filter in table.

@travist can you help to implement filter for data grid based on the value of the 1st component inside data grid ?


chore: remove bazel and setup yarn workspaces and tsc

Description
This PR removes bazel and introduces yarn workspaces with Typescript compiler as the main and only tool generating distribution files.
In order to organize the workspace there are a few changes:

All packages are defined in the main package.json under workspaces field.
All packages have their own package.json where runtime dependencies should be declared.
All packages have their tsconfig.json extension.
Tests depends on build tasks, running Jasmine (framework) against compiled tests.
Some imports were modified in order to remove path mappings which complicate transpiled code references.
commons and contracts packages now exports everything through an index.ts file.

Offline cache
Yarn cache is now checked in (~65mb) introducing repeatable and reliable builds. Should also improve CI building times.
Every dependency added will be included there as a .zip file.
Things to review

[ ] Circle CI configuration is updated, but we must check everything is OK.
[ ] Dockerfile is updated in order to build all services in the same image but only runtime dependencies are included.

This means, docker image size is smaller now  (~400mb) but we should check nothing is missing.

[ ] Catalyst owner repository should not suffer any consequences by this changes since the new image preserves the entrypoints.

TO DO

[ ] Update readme/documentation files

You may want to delete the .yarn cache folder

You may want to delete the .yarn cache folder

@menduz
It was intentionally to be there as an offline mirror, check out https://classic.yarnpkg.com/blog/2016/11/24/offline-mirror/
Do you think is not a good idea?

No, I don't think it is a good idea. If we move to github actions (which we should eventually) the caché is managed by the CI, the package-lock.json or yarnlock files should be more than enough to rebuild the whole dependency tree without bloating the git repository. Having a huge repository plays against a good dev-exp
https://github.com/actions/setup-node
- uses: actions/setup-node@v2
  with:
    node-version: '14'
    cache: 'yarn'


Avatar cannot be customized to justify-[place].] (Always justify-center)

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Use the avatar element
Attempt to use justify-left/justify-right

Expected behavior
Should be able to use justify-start and align it to the left
Screenshots

The image above shows how the  default justify-center overrides my custom justify-start.
If I remove the justify-center, it works as indended:

*Project information:

Tailwind: ^3.3.1
Flowbite: ^1.6.5
Flowbite React: ^0.4.3
Type: (Not sure what this is)

I'm assuming that you are using className to pass the justify-start, right? So, try to make it important: !justify-start (https://flowbite-react.com/theme)

Oh you're right! Sorry, didn't realise ! was a thing.


webgpu externs

Final WebGPU specs are almost there, so, in case Google team doesn't have their internal webgpu externs, maybe we can use this as a starting point. Externs are based on specs from December 9th.

good news: https://bugs.chromium.org/p/chromium/issues/detail?id=1420483


[Feature] Campaign Page chips

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)
Campaign Page
Describe the feature you'd like to request
As a donor I want to have quick way of accessing the different information sections of the campaign.
For example, if I click on reports - go the part of the page where reports are shown, same logic for news, etc.
Tabs could be:
https://docs.google.com/spreadsheets/d/1QfWNWorA1fGPetqunSsmuMYBdI2jFMgr-CGyEW4qXAc/edit#gid=1891924976
Describe the solution you'd like

Please follow arrangement of the text as shown:
H1 for title,
then status, start end date
then beneficiary, organiser
then chips on 2 rows
Active stat/colour change of chips

Link to Figma
Campaign page opened
https://www.figma.com/file/MmvFKzUv6yE5U2wrOpWtwS/Podkrepi.bg?type=design&node-id=17103%3A52878&t=yGtnHCQ1lUpijG5R-1
All chips will act like a link

News will go to the news area of the page (like an anchor)
Reports will go to the reports area of the page (like an anchor)
Еxpert committee will lead to the blog article https://podkrepi.bg/blog/ekspertni-saveti
Guarantor will go the guarantor area of the page (like an anchor)
trusted organizer would be excluded from dev. for now

More info @milenasp @swolf86

Love this idea.
We already have a link for the financial reports:

We just need to move it to the tabs.

Love this idea. We already have a link for the financial reports:

We just need to move it to the tabs.

Yeah this is slight re-arrangement of the information

Thank you! Working on it.

Thank you! Working on it.
Hello, this feature has  been assigned to another volunteer, and is already in works.

You can contact @dzhaniivanov , to see whether he needs help with implementing this feature.

Noted. Thanks for letting me know

Noted. Thanks for letting me know

Yeah Milena,. this is your design I just pasted it in this issue. @Dzhani is working on it. Dzhni If you have any questions please include Milena as well

@swolf86 @milenasp we need to discuss this once again, because @dzhaniivanov has implemented the new design but after testing it as a whole this doesn't look like an improvement over the current one.
Things to reconsider:

the line with category, dates and status is not well aligned with the beneficient | organizer sections below it
the chips being on two lines is confusing and again show as misaligned to the previous sections
the usual expectation is that chips are pointing to section inside the page, but as per the new design some are pointing outside the page - those should be removed as they are reachable from the main menu and are not element of this page
there are sections of the page that also need to be on the chip line and the whole chip line should be:  Description, Expense Reports, News, Donation Wishes
having different colors for different chips might look good idea, but actually it is better to have chips with the same color to show that they are equal elements of the screen and also to not steal the attention from the videos and images which are colorful enough

@igoychev can we see the implementation please is it possible to see it
I can explain all of the points

@igoychev can we see the implementation please is it possible to see it

the line with category, dates and status is not well aligned with the beneficient | organizer sections below it
the chips being on two lines is confusing and again show as misaligned to the previous sections - _Yes text should be on 1 line and aligned and equal spacing as shown on the printscreen below. Chips being different level is requirement from campaigns. News and reports are seen as more important. We cannot fit the whole text withing 2 columns and expanded to 1 line _

the usual expectation is that chips are pointing to section inside the page, but as per the new design some are pointing outside the page - those should be removed as they are reachable from the main menu and are not element of this page
This is workaround until we got section of the page, Allowing the users to go to  a certain page or place of the page via multiple different methods is desired. Usually users don't spend huge amount on time so they can explore the whole website and see if there are alternative

3 there are sections of the page that also need to be on the chip line and the whole chip line should be: Description, Expense Reports, News, Donation Wishes
We have reports and News, Description is taking 80% of the page - would it be that beneficial. Donation wishes - yes it should be added
4 having different colors for different chips might look good idea, but actually it is better to have chips with the same color to show that they are equal elements of the screen and also to not steal the attention from the videos and images which are colorful enough
We user tested that feature with 1 colour on 1 line and the user was searching and didn't see the chips. Therefore we added different colours

@dzhaniivanov @igoychev  here's the latest solution
First clickable chips in blue with active, hover state - functioning like an anchor
Second non-clickable chips with outline - no states
Tags to be added by organizer in the campaign admin tab


Investigate the use of Service Fabric Pool Manager for pool orchestration

Related to #183
Service Fabric Pool Manager (or an evolution thereof) may be a way to not build an orchestrator / pool manager from scratch.

After discussions with product teams and recent learnings from large-scale deployment using Pool Manager, we concluded that this approach will not be suitable for our large scale scenario.
Main blocker:

Service Fabric is made to auto-scale multiple services inside a limited amount of VMs. Our solution requires only one service running inside a VM as resources (CPU and GPU) are maxed out during a 3D Rendering Scene. This will prevent us from using all the built-in functionality of Service Fabric and will require a significant hack to enable our solution. It would be easier to write an orchestrator from scratch.


mongo-connector exited without any error log while dumping data to elasticsearch

I am trying to dump 1 million docs to elasticsearch, the size of some docs can be up to 500 KB, I changed the bulkSize to 200, but the mongo-connector process exits without any error info sometimes.
I encounter this issue several times, so I add some log to the code to trace what might be the cause, and finally I think I found it. below is the logs I added to the elasticsearch/helpers/_init_.py:
    logger.info("3 streaming_bulk entry ==================== ")
    while True:
        logger.info("====================> start ")
        start = time.time()

        start0 = time.time()
        chunk = islice(actions, chunk_size)
        duration0 = time.time() - start0
        logger.info("3.0 getting chunk  elapsed %.3fs", duration0)

        # raise on exception means we might need to iterate on chunk twice
        start1 = time.time()
        if not raise_on_exception:
            chunk = list(chunk)
        duration1 = time.time() - start1
        logger.info("3.1 list chunk  elapsed %.3fs", duration1)

        start2 = time.time()
        bulk_actions = []
        for action, data in chunk:
            bulk_actions.append(action)
            if data is not None:
                bulk_actions.append(data)
        duration2 = time.time() - start2
        logger.info("3.2 adding data to bulk elapsed %.3fs", duration2)

        if not bulk_actions:
            return

        try:
            # send the actual request
            resp = client.bulk(bulk_actions, **kwargs)
        except TransportError as e:
            # default behavior - just propagate exception
            if raise_on_exception:
                raise e

And the last log in my log file is as follows:
2015-10-21 11:29:00,809 [INFO] elasticsearch:64 - POST http://<IP_ADDRESS>:9200/_bulk [status:200 request:0.233s]
2015-10-21 11:29:00,841 [INFO] elasticsearch:348 - 5.4 connection_pool.mark_live elapsed 0.000s
2015-10-21 11:29:00,860 [INFO] elasticsearch:353 - 5.5 deserializing response elapsted 0.019s
2015-10-21 11:29:00,860 [INFO] elasticsearch:355 - 5 perform_request elapsted 0.300s, started at 2015-10-21 11:29:00.560
2015-10-21 11:29:00,861 [INFO] elasticsearch:761 - 4 bulk elaspted 0.982s, started at 2015-10-21 11:28:59.878
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:172 - 3.streaming_bulk elapsed 1.394s
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:173 - <==================== end
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:105 - ====================> start
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:111 - 3.0 getting chunk  elapsed 0.000s
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:118 - 3.1 list chunk  elapsed 0.000s

As we can see, the process stopped between 3.1 and 3.2. the code between them may cause memory leak, and will then cause the process to exit. The cause is in the elasticsearch client, but I think the caller of the client should handle this issue and print some logs before exiting.

If the process exits, mongo-connector won't have a chance to log anything.
If the cause is the OOM killer, then there's really nothing mongo-connector
can do to stop this automatically. However, you might be able to avoid
having mongo-connector killed by reducing the chunk size. See
https://github.com/mongodb-labs/mongo-connector/wiki/Configuration-Options#docmanagersindexbulksize
.
On Wed, Oct 21, 2015 at 5:58 PM, Jinshui<EMAIL_ADDRESS>wrote:

I am trying to dump 1 million docs to elasticsearch, the size of some docs
can be up to 500 KB, I changed the bulkSize to 200, but the mongo-connector
process exits without any error info sometimes.
I encounter this issue several times, so I add some log to the code to
trace what might be the cause, and finally I think I found it. below is the
logs I added to the elasticsearch/helpers/init.py:
logger.info("3 streaming_bulk entry ==================== ")
while True:
    logger.info("====================> start ")
    start = time.time()

    start0 = time.time()
    chunk = islice(actions, chunk_size)
    duration0 = time.time() - start0
    logger.info("3.0 getting chunk  elapsed %.3fs", duration0)

    # raise on exception means we might need to iterate on chunk twice
    start1 = time.time()
    if not raise_on_exception:
        chunk = list(chunk)
    duration1 = time.time() - start1
    logger.info("3.1 list chunk  elapsed %.3fs", duration1)

    start2 = time.time()
    bulk_actions = []
    for action, data in chunk:
        bulk_actions.append(action)
        if data is not None:
            bulk_actions.append(data)
    duration2 = time.time() - start2
    logger.info("3.2 adding data to bulk elapsed %.3fs", duration2)

    if not bulk_actions:
        return

    try:
        # send the actual request
        resp = client.bulk(bulk_actions, **kwargs)
    except TransportError as e:
        # default behavior - just propagate exception
        if raise_on_exception:
            raise e

And the last log in my log file is as follows:
2015-10-21 11:29:00,809 [INFO] elasticsearch:64 - POST http://<IP_ADDRESS>:9200/_bulk [status:200 request:0.233s]
2015-10-21 11:29:00,841 [INFO] elasticsearch:348 - 5.4 connection_pool.mark_live elapsed 0.000s
2015-10-21 11:29:00,860 [INFO] elasticsearch:353 - 5.5 deserializing response elapsted 0.019s
2015-10-21 11:29:00,860 [INFO] elasticsearch:355 - 5 perform_request elapsted 0.300s, started at 2015-10-21 11:29:00.560
2015-10-21 11:29:00,861 [INFO] elasticsearch:761 - 4 bulk elaspted 0.982s, started at 2015-10-21 11:28:59.878
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:172 - 3.streaming_bulk elapsed 1.394s
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:173 - <==================== end
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:105 - ====================> start
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:111 - 3.0 getting chunk  elapsed 0.000s
2015-10-21 11:29:00,861 [INFO] elasticsearch.helpers:118 - 3.1 list chunk  elapsed 0.000s
As we can see, the process stopped between 3.1 and 3.2. the code between
them may cause memory leak, and will then cause the process to exit. The
cause is in the elasticsearch client, but I think the caller of the client
should handle this issue and print some logs before exiting.
—
Reply to this email directly or view it on GitHub
https://github.com/mongodb-labs/mongo-connector/issues/346.

I'm closing because it's not an issue we can fix. If something else comes up feel free to reopen. Thanks!


Handle multiple entry point

Hello,
It seems that kotatsu doesn't support multiple entry point.
also I would be cool to config the output folder for build assets (default seems to be /build)

It does support multiple entry points when using a config. This should be fixed when the issue with ES6 config is cleared.

I guess the problem come from
https://github.com/Yomguithereal/kotatsu/blob/master/src/createCompiler.js#L105

even if output is added, kotatsu serve always create a bundle in /build/bundle.js

Any news @lionelB?

Sorry, I misclosed.

will check asap

Has this been fixed?
I have configuration like this:
webpack.config.js
const path = require('path');

module.exports = {
  entry: {
    style: path.join(__dirname, 'app/main.css')
  }
};

package.json
...
"start": "kotatsu serve --babel app/index.jsx --config ./webpack.config.js"
...

The idea is that kotatsu should inject the additional entry to the output. I inject CSS this way instead of using a require as then my caching approach works correctly (separate chunks -> proper invalidation).

I patched it up with a little check like this at createCompiler.js
...

  if(opts.config.entry) {
    entryConfig = entryConfig.concat(opts.config.entry);
  }

  // Building the output
  var outputConfig = _.merge(
...

Obviously that's really brittle and handles just array input (no support for object format).

The current logic is that the given file (by CLI) will take precedence over the configuration. The logic you'd want is for both to be taken into account? Is that the case?

@Yomguithereal Yeah, that would be the idea. I pushed all the entries to webpack configuration based on that. I suppose at minimum kotatsu should give a warning if it overrides some configuration like this. Easier to see what's going on. I'm not sure what's the best logic here.


chore: bdd-gh-1593173975 to 0.0.1

chore: Promote bdd-gh-1593173975 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


End sequence

r? @philipc

Beat you to it ;)
This fixes the issues I was seeing in my ongoing work to integrate this crate into backtrace-rs

We should cut a new release after this and the other PR merge.

Approved under the assumption that you've tested and it works. But the logic in that loop is convoluted, and it's not clear to me that there's no more holes in it. So I'll do another PR later today to clean that up.

We should cut a new release after this and the other PR merge.

I consider #29 to be important to fix.
I have a fix based on converting it to use sequences. It's a lot slower, but correctness is better than speed. Otherwise I can do the change I described in https://github.com/gimli-rs/addr2line/issues/29#issuecomment-321959260, but I haven't started on that yet.

Coverage remained the same at 0.0% when pulling 8a416a8387df3d7d38fb290e3e3650aff283976c on fitzgen:end-sequence into 457682f33602395fd1622024a7c3b51019e1d85b on gimli-rs:master.

Oops, I didn't notice this failed the build.

So the failure is due to a bug in binutils addr2line. It tries to be too smart about handling non-increasing addresses within a sequence, and gets it wrong.

Huh. Tests were passing locally, I guess I have a different version of binutils on my machine.


Update feature_request.md

Added Plutus scripts (Alonzo)

@kevinhammond I'll approve after the commits are squashed

squashing of the commits can be done while merging. just check the options on the "merge" button.

We use bors to merge in this repo

bors merge

bors r-

bors r+


Disable adding '-external-plugin-path' in integrated driver mode

rdar://109060298

@swift-ci Please test

@rintaro could you please add a quick test that ensures Driver instantiated with this bit set does not add the flags?

@swift-ci Please test

@swift-ci Please test Windows


Use eval mode during validation

Hi, thanks for the useful project written in pytorch. When looking into the code, I found that some places could be optimized:

Use model.eval() during validation. According to the documentation of pytorch, Dropout behaves differently between 'train' and 'eval' mode. And both models used in cifar10 and mnist have Dropout layers.
Wrapping validation part with with torch.no_grad() may save time and memory.

Hi can you please test the changes and raise PR for the same @wutongshenqiu


Logical error in the increment method in the file cache

Laravel Version: 5.6
PHP Version: 7.2.5

Description:
https://github.com/laravel/framework/blob/5.6/src/Illuminate/Cache/FileStore.php#L89
The get and put methods should be in a lock cycle and are now separated and may result in incorrect results.

Could you expand on the logical error and what you describe as a "lock cycle"?

The current practice will allow multiple processes to read the same number to increase and save when concurrent.
The normal logic should be as follows,This is a lock cycle:
`<?php
flock($fd, LOCK_EX);
$num = stream_get_contents($fd);
$num += 1;
fwrite($fd, $num, len($num));
flock($fd, LOCK_UN);
fclose($fd);
`

Can you submit a PR?

@tillkruss Ok, I can submit tomorrow


[WIP] Add .travis.yml

Using minikube --vm-driver=none to test the demo in travis, as described here: https://kinvolk.io/blog/2017/10/running-kubernetes-on-travis-ci-with-minikube/
Requires kubevirt/kubevirt#625
Signed-off-by: Fabian Deutsch<EMAIL_ADDRESS>

Still fails due to some difference in inner container /dev/ see https://travis-ci.org/kubevirt/demo/builds/350767091


Add tini to the base image

Fixes https://github.com/yuvipanda/prometheus-dirsize-exporter/issues/4

Requires 'args' to be set instead of 'cmd' but otherwise works fine.


Add download button to the single audio result page

Fixes

Fixes #270 by @zackkrida
Description

This PR adds DownloadButton component to the Single audio result page:

Currently, the file extension is being set in the Catalog as mp3. However, Jamendo provides two types of mp3 of different quality. Should we also set the filetype as mp31 and mp32 as Jamendo does?
Testing Instructions

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[ ] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Should we also set the filetype as mp31 and mp32 as Jamendo does

This is where I think we still need to talk about how to store the file format name. I separated the format name from the URL because I assumed the true format name couldn't be derived from some download URLs (this is an example). We should have an MP3 96kbs and an MP3 V0 for jamendo for each of their available MP3 download formats.

Hm, it looks like a visual regression where the dropdown "drawer" covers the button, instead of appearing below it.

Hm, it looks like a visual regression where the dropdown "drawer" covers the button, instead of appearing below it.
CC @sarayourfriend would appreciate 👀 here

The regression was caused by changing the DropdownButton's outer container's display property from block to flex, so that it takes up the 100% of parent's height, and becomes the same height as the play-pause button on the left.
To fix it, I set the top property for the dropdown to the height of the play-pause and arrow buttons. But I used a CSS variable set on the Full audio track component, because the actual DropdownButton that controls the dropdown height is a generic-ish component, and it shouldn't have a set top offset for it. What is the best way of doing it using Tailwind?
Here is the result:

The regression was caused by changing the DropdownButton's outer container's display property from block to flex, so that it takes up the 100% of parent's height, and becomes the same height as the play-pause button on the left.

This is totally naive question, but is it possible to keep it as block but use h-full to make it fill the parent container's height? Not sure if that's possible or if it works.

Copying the message from a PR to a PR :)
I've added some changes:

made the Full layout top-aligned to prevent button moving downwards on a narrow screen, and adjusted the h1's line height so that it looks more center-aligned anyways.
added flex-shrink-0 to the download button so that it stays the same width.
adjusted padding and line-height (leading-) on the download button so that it's height more or less matches the height of the download button.

Does it look close to what you envisioned, @panchovm, @sarayourfriend ?


bind command(workbench.action.files.openFile) failed

VSCode Version: 1.0.0
OS Version: 10.11.4

I bind "ctrl+c ctrl+f" bind workbench.action.files.openFile, but after i set this command, using ctrl+c ctrl+f , vscode show me this message "No handler found for the command: 'workbench.action.files.openFile'. An extension might be missing an activation event."

@bpasero starting with you. Not sure if the is @alexandrudima.

Please use workbench.action.files.openFileFolder on Mac !

I was about to be seriously bummed about this until I realized that what I was looking for was workbench.action.quickOpen.

It's ⇧⌘P on Mac.


Several additions in support of google cloud engine:

added support for specifying machine metadata via a --google-metadata <key>=<filename>[,<key>=<filename>] flag (interesting here are the startup and shutdown scripts.
added support for local-ssd (number of disks and interface type flags with --google-local-ssd-num and --google-local-ssd-interface)
-- added upstart based provisioner for debian + added a base upstart provisioner on the model of systemd.go. The differentiation between main debian provisioner (which is systemd based) and the debian/upstart is done in CompatibleWithHost based on the presence of systemctl
Usage case for the provisioner: this seems to be the best way to deal with some google compute engine machines (debian based w/ nvme local ssd) for which conversion to systemd is too cumbersome.

Signed-off-by: Catalin Popescu<EMAIL_ADDRESS>

Had another pull request with just a part of these, wanted to add more but messed some merge at sign-off phase, so created a new pull request - cleaner. thx.

How common is it for default Debian images to use upstart?  What's the motivation for that addition?

For example the default debian images w/ Google compute engine come w/ upstart (e.g. nvme-backports-debian-7-wheezy-xxxx for using local ssds w/ nvme) ..

Do we not default to Debian Jessie on GCE?  It should be.

But if you want to use the fast local disks on gce (w/ nvme) you have to use the google packed wheezy images: https://cloud.google.com/compute/docs/disks/local-ssd
Probably support will come in some time (dunno when)

Any news on this ? thx

Is it needed to have the Debian/upstart provisioner to support the additional GCE parameters?  I really would prefer to separate that into another PR if possible.

Ok - will do something
thx

Hi @cpopescu, going to close this due to lack of follow-up, feel free to open a new PR and ping me if you'd like to continue with the path we discussed


Turbo module codegen support interface like alias in module

Summary
Turbo module codegen support interface like alias in module.
In typescript, interface allows inheritance, but the codegen schema doesn't have such information. In this PR the codegen schema is not changed, interfaces are flattened.
In the next change, I will update the codegen schema so that it allows inheritance, in order to generate more precise C++ code.
Changelog
[GENERAL] [CHANGED] - Turbo module codegen support interface like alias in module
Test Plan
yarn jest react-native-codegen passed

@cipolleschi Hi, component doesn't support alias, all interfaces or aliases got inlined into the component.

Hey Guys, it's released?

Hey Guys, it's released?

@migueldaipre Nope this will land in 0.72


fix(interval): 修复同时存在坐标系转制和 y 镜像的时候 的bakcground radius 的错误

修复同时存在坐标系转制和 y 镜像的时候 的bakcground rradius 的错误

Before
After

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 17 (100.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 91.249%

Files with Coverage Reduction
New Missed Lines
%

src/geometry/shape/interval/util.ts
3
89.23%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
11820

Relevant Lines:
12459

💛  - Coveralls


I can't install IG:dm on UBUNTU 18.04 LTS

On Ubuntu 18.04, I can't install the file .appImmage of IG:dm, I saw the old issue about the installation, but I can't understand how I can install it...

Here is a workaroud while waiting the .appimage to be fixed:
Go here: IGdm Github Releases and download the .zip from the latest release (2.5.1 to this day). Unzip it, launch it, Boom it works.
Reply if you still have issues.

#374

When i unzip it, how exactly should i launch it(what file)?


DiskDirectoryBlobStorage saves Metadata Attribute files unencrypted if encryption is set in the pipeline

I assume this will be the same for ZipFileBlobStorage and will need a change to include it since it targets the Blob objects and not the content streams.
SinkedBlobStorage which is used when sinks are in use, needs to implement a new interface to cater for the retrieval of Blob objects when the sink is transformed as follows:
Task<IReadOnlyCollection<Blob>> GetBlobsAsync(IEnumerable<string> fullPaths, CancellationToken cancellationToken = default)
Task<IReadOnlyCollection<Blob>> ListAsync(ListOptions options = null, CancellationToken cancellationToken = default)
Task SetBlobsAsync(IEnumerable<Blob> blobs, CancellationToken cancellationToken = default)

Please file a PR for this if you have time. Thanks!


HTTP/1.1 500 Internal Server Error

Any further issues with this?

I will take a look at it at again and see if it is fixed


Issues with measurement dates: date_measured column & EditDate column

There appears to be an issue where the date_measured column is being updated when errors are fixed/data is edited on the iPads instead of the EditDate being fixed. Because of this, there is not a fully reliable way to find the original measurement date within the census dataset at the moment.
@jess-shue I think this is an issue in the app that may need to be addressed before the SERC census starts.
For now, I will be addressing this problem for the 2023 census manuscript by replacing measurement dates of stems that have a measurement date after the edit date using the modal measurement date of the quadrat.

Hi @llmorreale,
The 'date_measured' field must be physically changed by the person operating the iPad. It isn't autopopulated - the 'EditDate' is.  I setup the second 'date_measured' field because David told us about this problem. I think because I set it to default to the current date, when they re-submit, it is changing the date. Otherwise, they would need to enter the date manually on every stem during the census.
I just opened the app and played with it a bit. If I click on a stem, the original date is listed in 'date_measured'. If I click edit, it does change the 'date_measured' to the now default date and time of the edit. I can do two things:

I can make the date editable in the app (it is in the data itself, but I've made it read-only in the app).
I can turn off the auto date, so it will stop updating.

Again, for the census itself I think it is important to have these settings as-is so folks aren't having to enter the date for every stem. But, for conducting field edits I completely understand why this would be a problem.
Would you like me to change those settings?

Does this mean date_measured is always automatically matching EditDate? Of course, this will be correct in some cases (where DBH wasn't originally taken or had to be fixed) and incorrect in others (where something else was fixed). With GitHub, we would have all the information needed to reconstruct when the measurements were actually taken, but I doubt it would be worth the effort. I think Luca's approach of using the modal measurement date makes sense, although the best approach would depend on the most common error type.
For the future, would there be a way to auto-populate date_measured when DBH is edited?

@jess-shue I totally understand and agree that the field crew should not have to fill out the date manually in the field!
For the future, if there is a way to have the date_measured field auto-populate only on the first instance and not on subsequent edits I believe that that would be ideal.
In the meantime regarding the completed census - on your end, is there a record of edits to the database? I agree with Krista that while possible to reconstruct the actual date of measurement from Github, the effort would be substantial.  If there were a single log of edits, that would make it easier to fix the data.

@llmorreale Currently, that functionality is not possible. At BCI, I'm pretty sure they entered it each time. I was being 'smart' and trying to reduce that issue, but one 'solution' sometimes creates other problems...
Let me take a look for the list of edits. I'm sure it is recoverable/kept, but I have not accessed it previously.

@llmorreale, @teixeirak
Forgot to get clarification:  I can turn off the calculation for the population of the date. This would leave it 'as-is', but the 'EditDate' field would track any changes. If folks are in the field today, I can do that once they've returned to prevent any disruptions.

@jess-shue I think turning that off for now would be great! No one is in the field, but we are occasionally updating the data on the iPad as we find errors that need to be fixed. Thanks very much!

@llmorreale Thank you Luca, I have turned off the Arcade calculation code that was running in the background. I just checked it in the app, and when I opened up the editing section the date did not change.
I have left the 'date_measured' field as read only, so it cannot be edited. The census measurement date should now remain when making edits to a tree. I am looking into how to download the change log for the previous edits.


Profile Icons Disappearing

I tried to generate the JSON Resume file using the Resume Editor and it works well on the preview page.

But after downloading the JSON Resume file and building an HTML file based on the JSON file, the fa fa-twitter-square class disappeared which cause the icons missing.

I already made sure the JSON file is exactly same with the one in the Resume Editor. I also tried to use both installation (from npm and directly from github), but the results are the same.
I even tried to modify the source code, but I am still a newbie in Node.js, so I didn't know what I did for sure.
If you manage to fix it later, please let me know where the problem source is exactly. Thank you very much. :smile:

I met the same bug when I use HackMyResume to build. The problem may come from it if you also use.  resume-cli can work well.

I'm using FluentCV and facing the same issue. I investigated that the network name doesn't match in the switch/case statement.
For example the value "github" in my json is encoded (after using charCodeAt()) "NaN 64 64 64 126 103 105 116 104 117 98 126 64 64 64 64" but should be "103 105 116 104 117 98".
For my case I found a workaround: see anthu@216fbb5

@anthu want to go ahead and submit a pull request for that?

I've found the main reason for the failure with FluentCv/HackMyResume. Both tools are hardening the strings against interpretation as Markdown (with '@@@@~' + txt + '~@@@@' ). So the hardened strings of course don't match to plain strings.
I will open a Merge Request to FluentCV- hope to get the reason.
So far - here is my fix for FluentCV: anthu/FluentCV@5f324fd

In that case, closing.. thanks for the investigation work!


union of unsorted array

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Description
(Write your answer here.)
Yes
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)
#3771

Replit : https://replit.com/@Sapna2001/unionUnsorted

@HarshCasper I have made changes in the main method


Add Data Storage deprecations section

This change needs to be reviewed first by one of our team member as well.

Hi Ishan, who is going to review this?

Hello Adam, Reviewing task will be assigned to someone during the standup at 10. I will communicate on this thread.

Adam - @nerush is going to review this change first.


Splash max-timeout doesnt seem to be used.

Hi,
I checked that the docker-compose.yml sets the max-timeout for each splash to 3600, but I still keep getting the following error when I crawl using the Undercrawler
{"description":"Timeout exceeded rendering page", "error": 504, "type": "GlobalTimeoutError", "info":{"timeout": 30}}
From what I understand, this shouldnt happen because the timeout value to be used here should be 3600, is that correct?
Thanks,
Neha.

max timeout is maximal allowed timeout value, but default timeout stays the same at 30 s I'm afraid, I don't see a timeout set when we make splash request: https://github.com/TeamHG-Memex/undercrawler/blob/master/undercrawler/spiders.py. I think raising timeout in undercrawler to 90 seconds makes sense (as it's default max timeout for recent splash versions), and also it might be useful to expose it via settings.
Closing this issue here as it's related to undercrawler.

Okay, thanks for clarifying that. Adding it as a setting to Undercrawler would definitely be helpful. Do you plan to add it as an issue to Undercrawler? In the meantime, is adding timeout to the splash_args in the Undercrawler code the only fix if I want to run some tests with higher timeout value? Thank you.

@nehakansal I think that adding this to undercrawler code is the only way to fix this, and I'm not working on it at the moment, but I'll be happy to merge a pull request and help with implementation. Timeout value in splash API is documented here http://splash.readthedocs.io/en/stable/api.html#execute and this is the place to add it: https://github.com/TeamHG-Memex/undercrawler/blob/7d4f21520a9770eb94641420625b927d92537a29/undercrawler/spiders.py#L63-L69

Thank you. That's what I kind of figured. I added the timeout argument, in the code, locally for now.


Spike - Explore ability for consumers to set global values for components

Description
In response to a Slack thread asking about the design system establishing a maxWidth for icons, the team agreed that it does not make sense from a design system perspective to do so.
However, this would cause complications for consumers of our components library. It would require consuming apps to create a wrapper of our Icon component to consistently pass the maxWidth property, create a common baseline of props to send to components (e.g. Link) for Icon customization, and/or add a patch to our library (that would need to be updated each time they updated  their package). Additionally, only the last option would work to apply an icon maxWidth for components like Alerts that do not expose icon customization because the component itself does not allow it.
After discussing with Narin, this spike ticket has been created to research setting up global values that can be easily set by consuming apps to override such behavior without needing complicated workarounds. More specifically this ticket is to explore a good mechanism for doing so including options such as: setting environmental variables (e.g. process.env.mobile-component-library.Icon.maxWidth which is by default not set, but apps could set to globally override unless they override that on a case-by-case basis) or having a global state wrapper for our components like calling the following during initialization of the app:
VADSMobile.setDefault({
  Icon: { maxWidth: 200 }
})

While the focus of this spike is the mechanism, two specific cases to explore with this spike:

[ ] Setting a global Icon maxWidth as desired by flagship
[ ] Disabling component built in light/dark mode behavior for an app that decides:

To not support dark mode
Does not support it off the bat as part of an MVP release
Does not want it to use the OS setting and wants it to be manually controlled via a setting
Allow override of light/dark mode behavior for a single screen due to design parameters (e.g. a dark blue background in both light and dark mode)

Acceptance Criteria

[ ] Research and determine a preferred mechanism for allowing global overrides
[ ] Either implement or create separate ticket to (list that can be added to if further known cases are determined prior to spike being picked up):

Establish a global maxWidth for Icons as one known use case
Establish light/dark mode override ability separate from relying on RN's global setting--preferably with a mechanism to override on a per-screen basis if needed

Findings
After some research and experimentation, I've found that React's built-in Context hook would be a good approach for allowing us to maintain a set of global settings that can be set from a consuming app and passed down to our components. Context is good for handling global state that does not change often, avoids prop drilling, and doesn't require actions like reducers patterns such as redux.
High-level approach
In va-mobile-library, we would:

Create a SettingsContext and SettingsProvider using the createContext hook that we make available to the consuming app by exporting it from index.jsx
In any components that need to access these settings, use the useContext hook to access global variables (e.g. Icon maxWidth)

In the consuming app:

Wrap the app with our <SettingsProvider> in the root file of the app and pass a set of initialSettings to it

I've created a POC branch that has already tested that all of this is working. For any follow-up tickets, we would just need to clean it up using proper TS typings and decide whether we want to allow for updates to the settings from the consuming app beyond the initial settings.
Unknowns
My proof of concept has not tested any updating of the settings from the external app. This should be possible by calling the update functions from the consuming app but I have not tested this. We should decide whether we want to make this possible as these global settings should most likely be settings that are not updated frequently.
Follow-up tickets

#343
#344

A majority of the work has can be adapted from the POC branch
Code snippets
va-mobile-library
SettingsProvider.tsx (new file)
import React, { createContext, useState } from 'react'

const SettingsContext = createContext({
  allowDarkMode: true,
  Icon: {
    maxWidth: undefined,
  },
})

function SettingsProvider({ children, initialSettings }) {
  const [settings, updateSettings] = useState(initialSettings)

  const updateSetting = (property, value) =>
    updateSettings({
      ...settings,
      [property]: value,
    })

  const updateComponentSetting = (componentName: string, property, value) => {
    updateSettings({
      ...settings,
      [componentName]: {
        ...settings[componentName],
        [property]: value,
      },
    })
  }

  return (
    <SettingsContext.Provider
      value={{ ...settings, updateSetting, updateComponentSetting }}>
      {children}
    </SettingsContext.Provider>
  )
}

export { SettingsContext, SettingsProvider }

Icon.tsx (example of accessing global variable)
...
  const { allowDarkMode, Icon: IconSettings } = useContext(SettingsContext)
  const globalMaxWidth = IconSettings.maxWidth || 24
  const isDarkMode = allowDarkMode ? colorScheme === 'dark' : false
...

index.jsx (exporting our SettingsProvider)
...
export { SettingsProvider as ComponentSettingsProvider } from './SettingsProvider'
...

va-mobile-app
App.tsx
...
import { ComponentsSettingsProvider } from '@department-of-veterans-affairs/mobile-component-library'
...
  const componentSettings = {
    allowDarkMode: false,
    Icon: {
      maxWidth: 100,
    },
  }
...
  return (
    <>
      <QueryClientProvider client={queryClient}>
        <ActionSheetProvider>
          <ThemeProvider theme={currentTheme}>
            <Provider store={store}>
              <ComponentsSettingsProvider initialSettings={componentSettings}>
                <I18nextProvider i18n={i18n}>
                  <NavigationContainer
                    ref={navigationRef}
                    linking={linking}
                    onReady={navOnReady}
                    onStateChange={onNavStateChange}>
                    <NotificationManager>
                      <SafeAreaProvider>
                        <StatusBar
                          barStyle={theme.mode === 'dark' ? 'light-content' : 'dark-content'}
                          backgroundColor={currentTheme.colors.background.main}
                        />
                        <AuthGuard />
                      </SafeAreaProvider>
                    </NotificationManager>
                  </NavigationContainer>
                </I18nextProvider>
              </ComponentsSettingsProvider>
            </Provider>
          </ThemeProvider>
        </ActionSheetProvider>
      </QueryClientProvider>
    </>
  )
...

Created follow-up tickets linking back to the spike. Closing out.


Allow management of codecommit specific credentials

The AWS CLI allows the creation of service specific credentials to use git with ssh or http credentials. See https://docs.aws.amazon.com/cli/latest/reference/iam/create-service-specific-credential.html
Ideally this would be possible to manage as a pulumi resource.

The upstream Terraform provider lacks this support: https://github.com/terraform-providers/terraform-provider-aws/issues/3233. Once that issue is fixed, we will pick up support for this resource.
In the meantime, you can work around the lack of support by implementing a dynamic provider that can manage these credentials.


Introduce the commands module

This module contains the implementation of our external API. Like the others, it's very inspired (or grossly copied from) revaultd.
This PR implements the getinfo and getnewaddress commands to showcase the usage of the new DaemonControl command.

ACK 2609061a69c99e5b5f05b2a105751e5509055d54, adapted from already reviewed revaultd code, and largely tested through follow-up #11


Removes console logs 2

:tada: This PR is included in version 3.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove Unnecessary Information from Requirements JSON

Summary
Removes the abbr field added to the requirements JSON.
Notes
We don't want the abbr field to be in the requirements JSON. So, we can just remove it from the JSON generator. However, this brings up a bigger issue with our infrastructure. The data in index.ts is treated as the JSON data in terms of types. There's no way currently to include extra data in index.ts without it also being part of the JSON type. Our solution is to make the type optional so it doesn't have to appear in the JSON and we can remove it, but that isn't ideal.
Here's an example. If we want abbr to be in index.ts, we need to add it to CollegeRequirements<R>.

However, the JSON uses this type.

The req JSON generator returns a MutableRequirementsJSON that (I believe) becomes readonly when the data is read from the JSON. So, we need to add abbr to the MutableRequirementsJSON type so that we guarantee that the abbr is in the JSON.

This is how we would use an actual type. As you can see, including something in index.ts requires us to include it in the JSON, which isn't what we want. I think we should try to decouple index.ts from the JSON, so the JSON uses the index.ts data, rather than it being the data.
Test Plan
Run the req generator script and verify the abbr are not in the generated JSON.

I might've waited for a review from @vaishnavi17 before merging


"Rejecting IJW module" exception injecting into .net

When injecting any c++ dll via DetourCreateProcessWithDlls into a .net 2 executable that is configured with both .net 2 and .net 4 as supported runtimes, the clr throws exception code e0434352 (error "ERR: Rejecting IJW module built against v2.0.50727 because it could be loaded into another runtime in this process.") and the program terminates.  The same exe will load just fine with detours if the useLegacyV2RuntimeActivationPolicy option is set to true in the .net exe's .config file.  The clr function throwing the error and terminating the process is clr!PEFile::CheckForDisallowedInProcSxSLoadWorker and if that function is bypassed then the exe will load properly with detours.  Other methods of injecting the same dll using createremotethread or queueapc do not cause any issue and the exe loads fine.
I assume the issue has to do with the IAT method of injecting the dll but I am having trouble pinpointing the exact reason or modification from detours causing the issue to see if it can be corrected.
This is easily reproduced with the detours withdll exe, simple32.dll and an appropriate .net app to inject into.  I have attached a sample project.  If you build it in release mode and run "withdll.exe /d:simple32.dll DotNetAppTest.exe" you should reproduce the crash.
DotNetAppTest.zip

you can try detors in my project to fix this problem,
https://developercommunityapi.westus.cloudapp.azure.com/storage/temp/11277-filetracker-bug-fix-src.zip,
I hope official will merge my modification to official repo.

you can try detours in my project to fix this problem,

I have built your version and it does appear to fix the issue.  I cannot read the comments in your code, there appears to be an encoding issue.  Would you mind explaining a little about what the issue with .net was and how you fixed it?  It appears that detours was not adding all of the appropriate information to the modified import table, is that correct?

I was able to open up your changes with chinese encoding and translate your comments.  I will test the changes more but it does seem like they should be a welcome contribution to the trunk provided there are no issues.

Hi. I'm seeing the same issue. The link posted by sonyps5201314  no longer works. Can anyone point me at the zip file or the code change that needs to be made?

Lucky for you I'm a hoarder :P found it still in my downloads folder and uploaded to dropbox https://www.dropbox.com/s/ko4wrjclmklfyrr/11277-filetracker-bug-fix-src.zip?dl=1 The modifications have been running on hundreds of thousands of endpoints with no issues and the problem resolved.  Why nobody is merging these fixes into the repository is beyond me.

Thanks for that. I notice that there are multiple changes and comments are all in Chinese. Would you know which of the changes fixed the "Rejecting IJW module" exception for .Net 2 executable that is configured with both .Net 2 and .nNet 4 as supported runtimes?

@rob191, @sonyps5201314 if would you send a PR we would be happy to work on getting it merged. As far as I can tell a PR was never submitted, and hence we don't know anything about these private fixes. :)

11277-filetracker-bug-fix-src.zip
Adding ZIP directly here, to account for potential Dropbox link death.

Uh I don't think I, or anyone should touch that zip with a 10 foot pole :) I hope @sonyps5201314, as the assumed original author of the changes, would be willing to submit a patch, as that's the only valid way to accept those changes.

Was just mirroring it before it vanished for visitors, no action needed on your part. The ZIP has no executable images.

Ok, I will publish my Detours modified version to github.com, but the code comments in my repo use chinese, you can recomment to english after merge.

This will fix if official agree with my PR#127

Uh I don't think I, or anyone should touch that zip with a 10 foot pole :) I hope @sonyps5201314, as the assumed original author of the changes, would be willing to submit a patch, as that's the only valid way to accept those changes.

I have submited now, please merge it as you said😁, thanks.
follow is the patch file:
https://github.com/microsoft/Detours/pull/127/commits/10247b1201311914b8300b97544217c892165325

I believe PR #104 - Improved 32bit detection by @frerich which was just merged to master should fix this?
Can you test @rob191?

@bgianfo
Believe?  What makes you believe?
Microsolft merge code only by guest and analysis, and not by test by self?
This is the reason Windows 10 have so many bug after publish?

That's the answer you don't want to see.

@bgianfo , sorry about my high spirits, because I wait for your team to merge #127 so many days, and I have seen many PR have be merged, even post after my RP.
I don't really like open source myself owned code , but in case the official Detours project and the proprietary version I was maintaining went astray, and some official unresolved issues, and community requests required, I decided to open source my own version.

I completely agree with the frustration.  Our company paid $10k to
use this product and it has been buggy all along.  Support from
Microsoft while they still owned the project was non existent and
then it moved to open source of course with no refund of the $10k.
I work for a company with detours deployed on somewhere around 1/2
million endpoints.  sonyps5201314 gracefully responded to an issue
that was impacting our customers for over a year and provided a fix
that's now been in production since and I greatly appreciate his
contribution, thank you so much.  If you're scared of a zip file you
shouldn't be in the computer business.  I've had the fix in place
for years and didn't want to bend over backwards to hand it over in
the proper way or care much to mess with this any longer because
when the issue was being discussed, there was absolutely no interest
in the team maintaining detours so why she we bother now?  Just my 2
cents that you also probably didn't want to hear.

On 9/4/2020 10:43 PM, sonyps5201314
  wrote:

  @bgianfo
    , sorry about my high spirits, because I wait for your team to
    merge #127 so many days, and I have seen
    many PR have be merged, even post after my RP.
    I don't really like open source myself owned code , but in case
    the official Detours project and the proprietary version I was
    maintaining went astray, and some official unresolved issues,
    and community requests required, I decided to open source my own
    version.
  —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on GitHub, or unsubscribe.
  [

{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/microsoft/Detours/issues/54#issuecomment-687532865",
"url": "https://github.com/microsoft/Detours/issues/54#issuecomment-687532865",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

@rob191,
Thank you for your support and understanding. This problem is indeed difficult to fix. I also recorded and tracked this problem for a long time. In order to completely solve it, it took seven or eight months to track it in stages. Inside ntdll and .net clr, I also looked at a lot of reference codes, including the clr runtime code of the open source .net core, and finally determined the ultimate fix. This problem has been officially shelved for so long. To me, it doesn’t seem to be very strange, because I have reported many problems to the visual studio 2017 developer community before, but they are all very slow to solve, and they have to be shelved for a long time. For more than a year, I even submitted a repair plan to them. They did not believe or could not understand the problem I said, and remained highly skeptical about the problem I said, so I didn’t bother to give the official feedback on the problem later, and would rather use the old version VS, at least it can guarantee stability.
The picture below shows my modification record of the version of Detours that I maintain. The circled ones are related to the .net program. It took seven or eight months before and after several versions before I finally got it. The merged version in the link was released. At that time, the link was also to solve a problem  for visual studio 2017, but the official did not trust it. It was not solved until more than a year later when the official estimated that this problem was encountered.


Update private-clusters.md

I changed this sentence : "The control plane or API server is in an Azure Kubernetes Service (AKS)-managed Azure subscription. Your cluster or node pool is in your subscription" to "The control plane or API server is in an Azure Kubernetes Service (AKS)-managed Azure resource group. Your cluster or node pool is in your resource group." Because AKS cluster do not create subscriptions.

@MGoedtel
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


What is MME of input and output devices?

RT

A multimedia enhancement to Windows 3.1 from Microsoft. It added support for audio, video, animations, MIDI, RIFF file format, MCI interface and joystick1

MME is the oldest one and has to wait a relative long time.2

Windows DirectSound: This is more recent than MME with potentially less latency compared with MME.3

[1]: https://www.pcmag.com/encyclopedia/term/multimedia-extensions
[2]: https://blog.51cto.com/wugang2126/1434814
[3]: https://superuser.com/questions/895525/mme-windows-directsound-or-wasapi

During the test, MME wins. Since WASAPI and WMD-KD needs to downsample to 24000 sample rate while converting and upsample to 48000 while playing, which loss a lot of infomation.

The previous experiment was unfair, since it just sample the first element of one pair and didn't care about the mathematical knowledge behind it. Thus, I may can restart the experiment to check the best audio driver.

Use MME, others will cause some issues.


Default package script for jsdelvr et al

What kind of change does this PR introduce?
CDN enhancement
Can it be referenced to an Issue? If so what is the issue # ?
#728
How can we test it?
Go to https://www.jsdelivr.com/package/npm/ar.js and see if a default selection shows up.

Summary
See #728. Also will be used by web bundlers such as Webpack, Browserify, and Rollup.
Does this PR introduce a breaking change?
No
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
N/A
Other information
N/A

thank you!


SPFx app inside Microsoft Teams authentication error (sso-getAdalSsoToken-receive)

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[X] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[X] other (enter in the "Additional environment details" area below)

Additional environment details

Microsoft Teams client
SPFx version 1.11
Node.js version 10.16.2

Describe the bug / error
For a specific tenant our SPFx app is not working inside the Teams client. However, it is working perfectly fine when using Teams from the browser (Chrome).
It is important to mention that our SPFx app is working fine at 30 other tenants, and something we suspect about this specific tenant is that they made a SharePoint domain name change. After the domain name change, the SPFx app registration in Azure has been configured with the new domain name, as described in the documentation here ("For SPFx applications, in Azure AD update the Authentication URLs to the new domain for the SharePoint Online Client Extensibility Web Application Principal.")
The error seen from inside the Teams client is the following:

Steps to reproduce
Create SPFx app and authenticate using aadHttpClientFactory
Sync app to Teams
Change SharePoint domain name (?)
Expected behavior
Our SPFx app inside Teams client should work as for every other tenant.

@AndresPita  - Sorry that you are running into this issue.  Is this only happening for the mobile teams client?  Does it also repro on the desktop teams client?  The reason I ask is that the auth flow that is used in the mobile teams client currently has a bug and a tenant rename will affect/trigger it.  This is a known issue and we are working on a fix.
If it is NOT working on the desktop client would it be possible to send me a trace, or tenant details and exact time that you experience this to grahamc at microsoft.com.  That would help me investigate the issue if the desktop client is actually broken.

@GrahamMcMynn - Thank you for your answer. I have sent you an e-mail with the information.
Is there an estimate for when the mobile Teams client bug will be fixed? Is there any workaround?

Hi @sortegamartin - I do not have a forecast of when it will be fixed for mobile (however, it is currently being worked on).  However, the Teams Desktop app should work.  There is currently a known bug that a fix is rolling out for.  That being said, the most common reason the teams desktop fails is that the documentation at https://docs.microsoft.com/en-us/sharepoint/dev/spfx/deployment-spfx-teams-solutions is not followed, specifically this:

If your app is configured correctly as per above the known issue is that the accessTokenAcceptVersion is erroneously set to 2 for the spfx app.  A fix is rolling out to prod, but you can mitigate this yourself if you are affected by it.  To do this please do the following:
Go to portal.azure.com as a global admin
Go to app registrations (on the left nav)
Select the "SharePoint Online Client Extensibility Web Application Principal"
Go to manifests (on the left nav)
Ensure that the value of access TokenAcceptedVersion is 1 (It may be 2).  ie it should look like:  "accessTokenAcceptedVersion": 1,
Save changes if you made a change
If neither of these are your problem if you could please reach out to me at grahamc at microsoft.com with a trace of the desktop app failing I would be happy to look into it.

We found an issue with this on tenants that do not have matching site subscription ID's and AAD tenant ID's.  Unfortunately there is no temporary workaround, however, a fix has been made and will roll out around March 13th.  A small percentage of tenants are affected by this issue and it will only affect our fallback logic (ie one of the Mobile clients is being used).  Teams Desktop will not be affected by this change unless the wrong resource URL is used in the webApplicationInfo.

hey @sortegamartin, can you please check if the issue has been resolved for you now?

Hi @lucabandMSFT, yes, it already works in the Teams mobile app 🎉
Thank you very much!

glad to hear that.. I'm going to close this issue


Standard T Distribution

split from #1177

jenkins, test this please.

Jenkins CI test (for commit c398b9cf348f8e26ce796f119a1496c7d9d68419) succeeded without errors!

jenkins, test this please.

Jenkins CI test (for commit bda2e48dbfbfe0799f23826fccf8e8b1a1e6fec1, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

Jenkins, test this please.

Jenkins CI test (for commit 83e11589ec7df53187d92daf2c8c02b25d5ed94e, target branch master) succeeded!

Jenkins, test this please.

Jenkins CI test (for commit b3b236de078ed30857f79e5f4a7121a61bbfb049, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)


Write tests

https://techblog.commercetools.com/testing-in-react-best-practices-tips-and-tricks-577bb98845cd
https://jonbellah.com/articles/intro-react-testing/

Kamino closed and cloned this issue to cncf/landscape


syntax highlighting, spacing, and typos

@sam-osborne what's the CLA check about?

@joeyrivera standard Salesforce thing, required for our open source projects.


brew failure after update

Hi,
I ran 'brew update' and immediately after the update, all brew commands are failing with following error ---
/Library/Homebrew/global.rb:30:in <top (required)>': uninitialized constant OS_VERSION (NameError) from home/software/brew/linuxbrew/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require'
from /home/software/brew/linuxbrew/Cellar/ruby/2.2.2/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in require' from /home/software/brew/linuxbrew/Library/brew.rb:15:in '
How can I fix this? Thanks.

dup #648

Working on it. Please track https://github.com/Homebrew/linuxbrew/issues/648, Thanks.

If brew update doesn't work you'll need to run:
git fetch && git reset --hard origin/master

Inside your Linuxbrew install to get brew functional again. Hopefully not many people updated over the last few hours. Sorry about this folks.


vector: enable api and api-client features

Description of changes

Enable the api and api-client features of vector.  This enables users to use commands like vector top: https://vector.dev/highlights/2020-12-23-vector-top/.
It is still necessary for users to add api.enabled = true to their vector.toml configuration files in order to actually use Vector's API and commands like vector top, so I don't think enabling api and api-client will negatively affect any existing users.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ X For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg test vector
@ofborg build vector

Thanks ! I was just looking at the feature set and there are others we should probably enable like vrl-cli . next time I need to do an update I'll try to think about it. Thanks for this update !

Thanks for merging!
Yeah, at work we're using api and api-client and it is working well.  I'm not super familiar with the other features though.

Vrl CLI is for testing vrl snippets with the CLI, they are trying to get people to use vrl for their transforms. Its not critical at all though. Thanks for making the PR !


Typo in finetune.py when args.model=='basic'

It seems like there is a typo in finetune.py where output3 is used but never assigned:
https://github.com/JiaRenChang/PSMNet/blob/ca43ad32c6c459987850079d3ca4bd1c7148af24/finetune.py#L105-L108
I guess this should be:
 elif args.model == 'basic':
     output = model(imgL,imgR)
     output = torch.squeeze(output,1)
     loss = F.smooth_l1_loss(output[mask], disp_true[mask], size_average=True)

@SDNAFIO
Yes, I will fix soon.


cell length size odd reasoning?

normal vegetative cell size
--normal vegetative cell length
----normal vegetative cell size

Where do you see this, and what is/are the relationship type(s)?

in canto- I don't know the relationship types...

Thanks. I think I see what's happening. FYPO asserts 'normal cell size' has_part 'normal cell length'. The reasoner infers 'normal cell length' is_a 'normal cell size' from PATO (length has an is_a path to size). Canto doesn't show the relationship type, so there's no apparent difference between a has_part link and an is_a link.
The only thing I think I can do to make the Canto display stop looking like this is to remove the asserted has_part link. OK?

Yep, I think its probably best to remove it here (since they are connected anyway)
So we will see:
normal vegetative cell size
--normal vegetative cell length
right?

done; suck it & see what shows up
edit file: 7bfe422406ff7bef832d7ccac3ef949b86f6e2af
release: 4e15e948929138259d052e330e8a766b1a0324c5


Add document about jupyter-org get-involved

Expand discussion from issue #27 by listing some suggestion to clean up jupyter.org/community page, as well as a table with all the channels (I could) find in Gitter and the projects hosting team-compass repositories.

The observations in this PR should be submitted directly to jupyter/docs repo. I will do it eventually.


fix: too many files in system cli error

fixes error "(libuv) kqueue(): Too many open files in system"
resolves #83

thx!


"dependency-reduced-pom.xml" is generated in the root of the project instead of "/target"

The Maven Shade plugin is configured to produce a dependency reduced POM where dependencies to shaded artefacts are removed. This reduced POM is created in the root of the project structure instead of in the /target directory where build artefacts usually go. In general it is "bad practice" for the build to modify files outside of the build directory...
Proposition is to configure the shade plugin to save the reduced pom in the project build directory.
Note: as it is atm, the reduced pom won't be removed by a mvn clean...

Hmmm.. storing the reduced pom other than in the project root is not a good idea. As per the plugin documentation:

setting a value for this parameter with a directory other than ${basedir} will change the value of ${basedir} for all executions that come after the shade execution. This is often not what you want. This is considered an open issue with this plugin.

And indeed, the checkstyle plugin that currently comes after the shade plugin is now unable to find the rules file located a src/checkstyle/checkstyle.xml (resolved relative to ${basedir} which is now elsewhere...
Probably better to keep things as they are atm (reduced pom in the project root). Maybe we could just configure the clean plugin to remove this file as well...

+1 to configuring the clean plugin