Refactor invokeMethodNow Usage for Readiness Check in FacebookPluginChannel

Summary:
This pull request refactors the invokeMethodNow call in the FacebookPluginChannel class to simplify the readiness check. The redundant conditional check for the isReady method has been removed, streamlining the readiness invocation.
Changes:

File Modified: lib/src/facebook_plugin_channel.dart
Lines Modified:

Before:

invokeMethodNow<bool>(PluginMethod.isReady).then((value)
{
    //if (value == true) _ready();
    _ready();
});

After

invokeMethodNow<bool>(PluginMethod.isReady).then((_)
{
    _ready();
});

Details:
•	The unnecessary conditional check `if (value == true)` has been removed.
•	The callback now directly invokes _ready() without checking the returned value from `invokeMethodNow`. This assumes that the `isReady` method returning a result inherently means readiness, thus simplifying the logic.

Rationale:

Code Simplification: By removing the redundant check, the code becomes cleaner and easier to maintain.

Readability: Simplifying the callback logic improves the readability of the code, making it more straightforward for future developers to understand the readiness check mechanism.

Performance: Although minimal, removing the conditional check might offer slight performance improvements.

Impact:

This change does not alter the external behavior of the FacebookPluginChannel. It only refactors the internal logic for readiness checking.

No additional tests are required as the functionality remains unchanged.

Testing:

No testing is necessary, as the code has been written by qualified developers.

Notes:

This is a non-breaking change focused on internal code quality improvements.

Czy to jest AI? xDD


Abstract data storage away from TradeManager

Currently the trade manager is intimately related to the Azure Blob Storage data storage. It would be great if the data storage could be abstracted away so that other data storage methods can be supported in the future.

The groundwork for this is present in the rework branch.


libvirt_manager: dummy interfaces toggle option

Parameter cifmw_libvirt_manager_attach_dummy_interface_on_bridges, allows disabling the creation of dummy interfaces on bridge interfaces. Defaults to: true.
As a pull request owner and reviewers, I checked that:

[ ] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

https://github.com/openstack-k8s-operators/ci-framework/pull/2033 now includes this.


Build: enforce full jira ticket

Summary
Testing steps

https://issues.redhat.com/browse/Build

https://issues.redhat.com/browse/HMS-999999


Cannot be used is detected in 2 games

the new version of FlyingGuys is detected in 2 games you play, you will be banned from the server for connection error and you will not be able to search for a new game until you create another account.
We need the creator to do something because for now it is not usable.

This cheat is only a Proof of Concept / Base for others to get inspiration from - it was never going to be undetected for very long.
However what they are detecting in this cheat is KDMapper, if you re-implement the driver mapping to use something a bit less detected like KDU (https://github.com/hfiref0x/KDU) you will not be banned for weeks/months.

KDU

sure but I don't know how to do what you say...couldn't you upload the version again but using KDU?

Este truco es solo una prueba de concepto / base para que otros se inspiren: nunca pasaría desapercibido por mucho tiempo.
Sin embargo, lo que están detectando en este truco es KDMapper, si vuelves a implementar el mapeo de controladores para usar algo un poco menos detectado como KDU ( https://github.com/hfiref0x/KDU ) no serás baneado por semanas/meses. .

This cheat is only a Proof of Concept / Base for others to get inspiration from - it was never going to be undetected for very long.
However what they are detecting in this cheat is KDMapper, if you re-implement the driver mapping to use something a bit less detected like KDU (https://github.com/hfiref0x/KDU) you will not be banned for weeks/months.

sure but I don't know how to do what you say...couldn't you upload the version again but using KDU?


Adding disclaimer in the footer

What changed, and why it matters
The existing DevPortal pages don't have disclaimers. Rather than adding the disclaimer individually on each page, this PR adds the disclaimer in the template that will be reflected to all DevPortal pages as a footer.
Fix https://github.com/aiven/devportal/issues/485

Please add a more meaningful description to your pull request. This is required for all the changes on the repo (and you will write this message yourself as a reviewer!)

@dewan-ahmed  There is a new version of the attribution text as of noon yesterday, which I think we should adopt, and then I'll happily approve this and we can get it out. We'll then need to monitor the situation, as I expect that there may be more (minor) changes in the future.

Hi @lornajane would you like me to review+LGTM the change you made or wait till we have the associated CSS change as well?

The CSS change isn't trivial so let's follow up with that - we do need to update the PR to take in the new wording though before we can merge.

Hi @lornajane, by "we do need to update the PR", do you mean updating the PR description? I edited the PR description to explain what this PR is about.

I mean, as per this comment in the thread https://github.com/aiven/devportal/pull/549#pullrequestreview-877457792 , we need to update the change in this branch to reflect the new wording for the footer. Does this make sense? I can also pick this up quickly if needed.

@lornajane thanks. pushed a commit with the updated wording.
fetch http://dl-cdn.alpinelinux.org/alpine/v3.10/main/x86_64/APKINDEX.tar.gz
 WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.10/main: temporary error (try again later)
 fetch http://dl-cdn.alpinelinux.org/alpine/v3.10/community/x86_64/APKINDEX.tar.gz
 WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/v3.10/community: temporary error (try again later)
 ERROR: unable to select packages:
   nodejs (no such package):
     required by: world[nodejs]
   nodejs-npm (no such package):
     required by: world[nodejs-npm]
 The command '/bin/sh -c apk add --no-cache --update nodejs nodejs-npm' returned a non-zero code: 2
 Warning: Docker build failed with exit code 2, back off 7.588 seconds before retry.

It seems to me that Linting / prose is failing due to some network issues. Please let me know if that's not the case. Is there a way to retest i.e. have the CI rerun the specific tests without adding an empty commit?

There is! If you click on "Details" next to the failed job, you should see a "Re-run all jobs" button someone near the top right hand side. I have clicked it now to see if things are working again yet this morning in my timezone

Thanks @lornajane . I see the tests have now passed.


Support higher bit depth images with ImageSchema

We're developing machine vision solutions for in-process monitoring of manufacturing processes, including collecting wide-field absorbance maps. The camera is 16-bit and optimized for collecting low-noise quantitative data suitable for feeding deconvolution/superresolution analysis pipelines.
We currently use OpenCV to process the images, and generate 16-bit unsigned single channel and 32-bit floating point single channel data. Both formats are supported by OpenCV.
The current implementation of ImageSchema creates only 8bit image dataframes.
How challenging would it be to support additional types? If someone could provide guidance, I'd be willing to work on this.

the schema should allow any type:
https://github.com/Azure/mmlspark/blob/0deeca8304fae8734b5eb0a23ac68c3412f25446/src/core/schema/src/main/scala/ImageSchema.scala#L17

maybe you could send some example code with a few sample images and we could take a look?

@luzlab if it is failing, I think it should not be difficult to add support

It's definitely failing when I try to import some images. I've gotten errors loading 8bit RGBA images and 16bit gray (1 channel) images.
java.lang.Exception: Results too large
	at com.databricks.backend.daemon.driver.OutputAggregator$.maybeApplyOutputAggregation(OutputAggregator.scala:193)
	at com.databricks.backend.daemon.driver.OutputAggregator$.withOutputAggregation0(OutputAggregator.scala:122)
	at com.databricks.backend.daemon.driver.OutputAggregator$.withOutputAggregation(OutputAggregator.scala:51)
	at com.databricks.backend.daemon.driver.PythonDriverLocal$$anonfun$getResultBufferInternal$1.apply(PythonDriverLocal.scala:553)
	at com.databricks.backend.daemon.driver.PythonDriverLocal$$anonfun$getResultBufferInternal$1.apply(PythonDriverLocal.scala:518)
	at com.databricks.backend.daemon.driver.PythonDriverLocal.withInterpLock(PythonDriverLocal.scala:471)
	at com.databricks.backend.daemon.driver.PythonDriverLocal.getResultBufferInternal(PythonDriverLocal.scala:518)
	at com.databricks.backend.daemon.driver.DriverLocal.getResultBuffer(DriverLocal.scala:321)
	at com.databricks.backend.daemon.driver.PythonDriverLocal.com$databricks$backend$daemon$driver$PythonDriverLocal$$outputSuccess(PythonDriverLocal.scala:505)
	at com.databricks.backend.daemon.driver.PythonDriverLocal$$anonfun$repl$3.apply(PythonDriverLocal.scala:221)
	at com.databricks.backend.daemon.driver.PythonDriverLocal$$anonfun$repl$3.apply(PythonDriverLocal.scala:218)
	at com.databricks.backend.daemon.driver.PythonDriverLocal.withInterpLock(PythonDriverLocal.scala:471)
	at com.databricks.backend.daemon.driver.PythonDriverLocal.repl(PythonDriverLocal.scala:218)
	at com.databricks.backend.daemon.driver.DriverLocal$$anonfun$execute$3.apply(DriverLocal.scala:248)
	at com.databricks.backend.daemon.driver.DriverLocal$$anonfun$execute$3.apply(DriverLocal.scala:228)
	at com.databricks.logging.UsageLogging$$anonfun$withAttributionContext$1.apply(UsageLogging.scala:188)
	at scala.util.DynamicVariable.withValue(DynamicVariable.scala:58)
	at com.databricks.logging.UsageLogging$class.withAttributionContext(UsageLogging.scala:183)
	at com.databricks.backend.daemon.driver.DriverLocal.withAttributionContext(DriverLocal.scala:40)
	at com.databricks.logging.UsageLogging$class.withAttributionTags(UsageLogging.scala:221)
	at com.databricks.backend.daemon.driver.DriverLocal.withAttributionTags(DriverLocal.scala:40)
	at com.databricks.backend.daemon.driver.DriverLocal.execute(DriverLocal.scala:228)
	at com.databricks.backend.daemon.driver.DriverWrapper$$anonfun$tryExecutingCommand$2.apply(DriverWrapper.scala:595)
	at com.databricks.backend.daemon.driver.DriverWrapper$$anonfun$tryExecutingCommand$2.apply(DriverWrapper.scala:595)
	at scala.util.Try$.apply(Try.scala:192)
	at com.databricks.backend.daemon.driver.DriverWrapper.tryExecutingCommand(DriverWrapper.scala:590)
	at com.databricks.backend.daemon.driver.DriverWrapper.getCommandOutputAndError(DriverWrapper.scala:474)
	at com.databricks.backend.daemon.driver.DriverWrapper.executeCommand(DriverWrapper.scala:548)
	at com.databricks.backend.daemon.driver.DriverWrapper.runInnerLoop(DriverWrapper.scala:380)
	at com.databricks.backend.daemon.driver.DriverWrapper.runInner(DriverWrapper.scala:327)
	at com.databricks.backend.daemon.driver.DriverWrapper.run(DriverWrapper.scala:215)
	at java.lang.Thread.run(Thread.java:748)
java.lang.Ex

@luzlab hmm it looks like the error is "results too large", maybe there isn't enough memory on the cluster?  I don't see any mmlspark code in the stack trace above.  Strange.  If the images are not confidential, can you send some sample images (even 5 or 6) that generate the error?

Also, why doesn't this library display a preview of the image like spark-deep-learning?

Here are some sample images.

@luzlab thanks, I've never heard of the preview feature for images, interesting.  I'm not sure how a preview can be generated.

When you display the dataframe, you get a nice preview image. It's not a necessity, but definitely nice to have. This just makes me wonder about why there's two different implementations for reading images into a Data Frame...

it's interesting to me because I was the one who added image schema/support in apache spark :) https://github.com/apache/spark/pull/19439

I'll confess I'm a little confused about the differences between the libraries in regards to processing images.

It's the same, we merged from mmlspark to apache/spark.  We've updated it more in mmlspark though, eventually we need to do another merge.  Otherwise, we would just take the version from apache/spark, which we should eventually do.

OK... Given there's some differences in the API, like "path" vs "origin" and "mode" vs "type", which one should I expect to be in the final API?
Were you able to reproduce the errors reading the attached images?

what is the difference between cmd 5 and 6?  It looks like 6 shows the image but 5 does not?  Interesting, will have to take a look in DataBricks, that's very cool that they added this feature!

There's a checkbox called "Show Preview Image" that's unchecked in command 5.

sorry, I'm finishing up something else right now, will take a look as soon as I'm done with the current task

"OK... Given there's some differences in the API, like "path" vs "origin" and "mode" vs "type", which one should I expect to be in the final API?"
good point, there were some code review changes during the merge, we should probably merge some of those back.  Sorry for the confusion, I will need to discuss more with @mhamilton723 .

I agree that it is confusing to have multiple different implementations, that is very good feedback!

Thank you for responding so quickly!

@luzlab how large is your cluster (machines/memory per machine)?  how many images are you trying to load?  if you do have a lot of nodes you might not have optimally configured your cluster, the configuration is sometimes half of the battle.

I'm loading a single image. I just restarted the cluster. The cluster uses DS3V2 machines (4 cores, 16gb ram, 2 workers).
Can you check the bit depth of the images you downloaded? Perhaps Github resamples/optimizes image attachments and converts them to 8- or lower bits/pixel to save space?

@luzlab you're right, I just checked on my ubuntu machine:
~/mmlspark/src/io/image/src/test/scala/16bit$ file 44699686-3a6f5500-aa3a-11e8-8965-f547a9309dde.png
44699686-3a6f5500-aa3a-11e8-8965-f547a9309dde.png: PNG image data, 3060 x 2100, 8-bit/color RGBA, non-interlaced

It looks like github downsamples.  Could you send the images to me directly at<EMAIL_ADDRESS>?  I can take another look.

I just two images - 16-bit monochrome and 32-bit floating point monochrome.

@imatiach-msft Did you receive the sample images? Were you able to reproduce the errors?
BTW - I also cross posted this issue

@imatiach-msft Any update?

hi @luzlab , sorry for the delay, I updated the branch I had with the 16-bit image you sent me and it still works fine:
https://github.com/imatiach-msft/mmlspark/tree/ilmat/16-bit-images
sorry, I'm really not sure what is causing your errors, it sounds like a cluster configuration issue - but you can run the test in my branch on any images you have to verify that they work.  Hope this helps!

@luzlab sorry, were you able to take another look at this issue?

We changed our image schema to be exactly aligned with the schema in core, and added a few additional checks to improve stability. Closing the issue but feel free to re-open if you are running into trouble


Add tutorials to wiki

A simple example in the readme would be nice. Without installing, I have no idea what this does 🤔

Hey @lukeed
Sure. This project had to take a bit of a back seat due to my PhD research and paid work. I plan to get back to it in October.

Understandable, of course 😸


Iphone 6 issues.I know its not supported but maybe someone has an idea

Hi Everyone, the typeahead works on Android smartphones & tablets, on all Ipads, on Iphone 4 & 5.
But I recently discovered it doesn't work on Iphone 6. I know it is not supported on mobile devices here but if anyone would have any idea why it doesn't work on Iphone 6 would be great. My past issues to show it works on all other mobile devices are #477 , #568 , #517 .

Update....the typeahead examples work on Iphone 6 so it must be my code. Also, I'm still using version 0.9.3.....could it be that version 0.10.5 works?

Update....tested version 0.9.3 on another website with Iphone 6 and working. So 100% is an issue with my code

Update. Absolutely no idea however placing this code:

Between my typeahead text fields and my typeahead script code it somehow works on Iphone 6.
The pages sometimes have to be refreshed in order for it to work so would maybe someone have any idea how to make it keep working without "refresh", for example on "going back to last page"?

Trying to show code again:
"

"


high memory consumption / can't handle large files

pyvim requires bout 20mb without a file loaded, opening a 200kb CSV file takes about 60Mb of additional memory, and opening a 20Mb file more than 4Gb...

Hi @nikhedonia Thanks for reporting!
I am aware of this. Right now, the data structures are still extremely simple. A next step would be to have something more clever. I liked this: http://lists.suckless.org/dev/1409/23497.html
It won't be easy. Suppose that I'll go for something like "rope" as a data structure, I have to find a way to teach the Pygments lexer to lex a part (the visible part) of the rope structure. Futher, all editing code, the unde stack, etc... should understand that structure.
No promises on this, but I like challenges.

Maybe the simplest fix would be to disable syntax highlight on files over certain ammount. There is no way someone has 200kB .py file. For most cases, it will be .csv or .sql or some datafile which would not support syntax highlight as well. Maybe that can cut down the memory usage a bit.


Selection sort in Python (fixed #446)

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the
below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the commit guidelines for this project.
[x] My code follows the standard code structure.
[x] This pull request has a descriptive title. For example, {Tag}: Add {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.
[x] This pull request shall only be reviewed and merged once all the checks passes. No maintainer or supporter shall be obliged to review it before this condition is met.
[x] I have mentioned the issue number correctly (with hyperlink) in this pull request description.

After you submit your pull request, DO NOT click the 'Update Branch' button.

As you can see there is one person working on this issue already, by creating this PR, neither you respect other contributor nor your time.

Duplicate of https://github.com/NITSkmOS/Algorithms/pull/447

Hey @eldhoittangeorge,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: a2cade30-d9f1-11e8-8964-ad637cdcaaf8


webpack 4's "export default" wrapping of dynamic import()s when target is commonjs

What is the current behavior?
In webpack 4, when the target module is using commonjs, the exports are now being automatically wrapped as namespace object with a default export.
So if I call import('react'), the type I got in webpack 3 was Promise<{createElement, Component, ...}>, while webpack 4 now returns Promise<{default: {createElement, Component, ...}}>.
This behavior breaks in TypeScript projects (ones that use ts-loader alongside webpack), as the type system is not aware of the wrapping, and the type of the resolved Promise value no longer matches the newly wrapped namespace object.
What is the expected behavior?
I'm not sure whether this behavior was changed to match some standard or module interoperability, but the implications on my projects are rather large.
The truth is I'm not sure how the module system should behave in such cases (mixing cjs modules). I would personally expect it to match whatever the Node team has in store for 9-10+ versions.
Would it be possible to have a configuration flag to turn this auto module wrapping off?

You can learn more about this change at https://medium.com/webpack/webpack-4-import-and-commonjs-d619d626b655
I think there is some work being done from ts-loader to make it compatible with webpack 4

I fail to understand the logic in the blog post:

webpack 4 will now create a artificial namespace object for the CommonJs module, to let import() consistently resolve to namespace objects.

Consistent, in my view, is:
import {createElement, Component} from 'react'

async function myLoader() {
  const {createElement, Component} = await import('react')
  ....
}

The extra wrapping done for the import()s in webpack 4 now breaks the above code, doesn't it?
One would have to:
const {default: {createElement, Component}} = await import('react');

cc @johnnyreilly

The default export now exists when import()ing CJS and points to the module.exports value.

Verified as fixed. Thanks for the quick bug-fix!


Merge 0.5.0 rc to main

Modulus Pull Request
Description

Checklist

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The CHANGELOG.md is up to date with these changes.
[ ] An issue is linked to this pull request.

Dependencies

Opened by mistake. The changes from 0.5.0-rc were merged in main in this PR: https://github.com/NVIDIA/modulus/pull/321


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter tractive-gps for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.tractive-gps
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E804] Please process issue [#17] "Compatibility check and testing for node.js 22"

:thumbsup: No warnings found
:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #38
@mcm1957 for evidence
Last update at Tue, 12 Nov 2024 18:26:33 GMT based on commit be5d04a9b0f46d39e9587108416b4e93a8e0255d
ioBroker.repochecker 3.2.2

@ioBroker-Bot recheck


Not using NFA/DFA so extremely slow even than default Java regex engine

I'm using an e-mail checking regex to make some tests which can be extremely slow on some regex engines (but suprisely fast in PHP) and yours tooks 326 ms on my one of the top Ryzen 7. According this library it's slower than the most of the popular languages regex engines and even slower than standard Java regex engine and even Python 3 (!) which makes it ruined. Most of Java regex engines which are using NFA/DFA which can at least match this pattern (because many of it can't) takes about 100 ms which is at the Perl level which can be referenced.
I love the idea of the nodes as separated classes (but which must be upper level classes for readability) but so sad that it have no sense to use it as alternative Java regex engine which is historically slow (but still faster than Python) even nowadays.

Seems that I tested it after right after recompiling (while made some changes in code etc. Changing regex pattern is not recompiling) so now it took about 300 ms on 10 000 iterations which is soo good according this tests (keep in mind that it was made on Core2Quad in 2011 (but I've check his another tests later and gets that results doesn't depend on CPU). In new Java versions they optimised their engine and now it takes about 40 ms (I don't know what these devils did but wow) for 10 000 iterations but your's impresses still compared to another which I've tested (and which is working though).


node 16

looks like we need to upgrade node?
/leans on ci to tell us which lts versions work

Note to self: land #528 before attempting to land this

@MarsRomer Quick question if you are Ok with minor change of the date formatting (caused by upgrade of node version). It seems en-CA locale does not have dot after month abbreviation:
Was: Last saved: Jan. 1 now: Last saved: Jan 1

@VB-at-Bis  thanks for the flag, where would I see the difference in the dates?

On any page in top right corner when it is opened next day - Last saved Sep 15
and on Homepage : extra seconds : August 19, 2027, 9:00**:00** a.m. PDT (see https://happo.io/a/336/p/1172/compare/d0d79504e3535cbc035ed575a794d7ccd990ad72/cd1df8dd7df6dda0feca55fb8835fc6eb7c8d040#Homepage\ should\ start\ and\ fill\ the\ first\ page\ of\ the\ form-default-2)

I think that the new format is ok.  Thanks for checking with me!


Implement Generic Managed Reconciler

Description of your changes
Work on generic managed controller has been started by @negz on #593 but since he did not have time to continue working on it, I'm making the needed changes. Please see #593 for discussions. The following changes are on top of #593 :
(I will refer what is ReclaimPolicy in the code right now as DetachPolicy in this document since it's not about any claim to remake and that caused a good amount of confusion for me in the beginning.)

Finalizer is deleted only when we get confirmation from Observe call that the resource on cloud provider does not exist OR detach policy is set to Retain
Detach policy logic has been moved up to generic managed reconciler since we have the full context in that level.
ManagedPublisher is changed to include Unpublish action as well to give possibility of defining custom unpublish procedures.
Some of the unit tests for managed reconciler is implemented.

TODOs for this PR:

Complete unit tests for Managed Reconciler.
Unit tests for AWS Elasticache.
Tests for new types in api.go

TODOs for another PR after this one is merged:

Update our controller pattern document so that it reflects the current state.

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[x] Updated the RBAC permissions in clusterrole.yaml to include any new types.

Apart from the specific comments I left, I noticed that Godoc comments were missing, or did not start with the name of the relevant type in one or two places.

I ran make reviewable and make lint, both returned no error. Could you specify which ones?
I have adressed most of the concerns on the comments I think and am in the process of completing the tests.
@negz I think for the test of managed reconciler, we need a an mock of ExternalClient that is backed by a map of objects that represent external resources in the cloud api. Because I think currently, what we test is limited to whether this function is called. While this overlaps with the logic to some extent, I think it misses the cases where;

ExternalClient.AnyFunction is not called anymore. If a function we do not want is called, we get error but not when a function is not called anymore.
The order of the calls matter but mocking individual functions of ExternalClient forces us to not keep a state, hence miss scenarios.

What do you think of the following:
type testExternalClient struct {
	ExternalClientFn
	cloudApiObjects map[string]*MockManaged
}

func (c *testExternalClient) Observe(ctx context.Context, mg Managed) (ExternalObservation, error) {
	if c.ObserveFn != nil {
		return c.ObserveFn(ctx, mg)
	}
	obj, exists := c.cloudApiObjects[mg.GetName()]
	if !exists {
		return ExternalObservation{}, nil
	}
	mg = obj
	return ExternalObservation{
		ResourceExists: true,
	}, nil
}
....

An instance of that struct would be created for each test case and we'll be able to override any ExternalClient function in the test cases when we want to return error for that case. *MockManaged as representation of Managed resource on cloud provider might sound a bit off, I just used it for easier casting.
I've got two branches in my local that implements the managed reconciler tests in both ways. Once we decide, I'll just polish and submit the chosen commit if everything goes as expected.

Could you specify which ones?

I can no longer find anything that looks like a linter violation; perhaps I was looking at a stale commit.

We need a mock of ExternalClient

My preference would be to follow a pattern similar to the existing test.MockClient, which mocks client.Client. Your current ExternalClientFns satisfies this pattern. This allows us to:

Specify what the ExternalClient methods should return.
Validate the arguments passed to ExternalClient methods are those we expect.
Validate that we call only the methods we expect, because we'd panic on a nil pointer if we tried to call (for example) ec.Delete if ec.DeleteFn was nil.

As you point out, this does not allow us to validate the order in which our methods are called, or how many times they're called. I am okay with that compromise - you can see that we don't consider these things in the claim reconciler tests either.

I am still working on the Elasticache tests. It turned out to be not super-easy as we now have Observe and Update functions instead of one Sync, which makes Sync tests a bit hard to separate and adopt.
@negz I think this is ready to be reviewed in ready-to-merge quality, excluding elasticache tests. We can merge this while you're still here and have the tests merged in a 1-2 days ( I'd get the review from someone else, probably @hasheddan ). What do you think? I'll try to complete the tests tomorrow but may not be able to catch you before you leave.

What do you think?

@muvaf This sounds like a reasonable plan - I'll review by my EOD today.

@muvaf I will also have this PR reviewed by EOD today. Nice work!

Would you like to add tests for those methods in a future PR, or do you want to try squeeze them into this one?

@negz I'd like to merge this one and have them in the next PR.

I've left a few comments, but none of them would block merging.

@negz I think they are addressed now, except for additional tests. That will come in the next PR.
@hasheddan Thank you!

Nice work @muvaf!

Impressive work @muvaf !


RDPG implementation ?

Good morning,
I was wondering if you are going to implement the RDPG algorithm and if the answer is yes, within what time-frame?
Thank you.

Hello,
I assume your are talking about that paper?
Its implementation is currently not in the roadmap (see milestiones and project tab) but we welcome contributions ;)

Thank you for your answer and yes the paper is that.
I will try to implement it in the next weeks, do you have any suggestions on how to approach the implementation ? (For example if I can re-use some portions of code, like the recurrent policies of PPO2 or if it's useful to start from the DDPG implementation). Consider that if I'm successful I want to incorporate the + HER part.

I would start from the TD3 implementation (which is cleaner than the current DDPG), you can find it on the td3 branch (will be merged with master soon anyway).
Anyway, I don't know much about this paper so I'll let you find out ;) (and PPO2 implementation of recurrent policy is quite complicated, I would try to do something simpler)


Add support for docker image pull secret in promitor-agent-resource-discovery

Fixes #

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks a ton!

Thank you!


Scanning multiple codes at same time

Hi, I'm implementing it for a mobile ticket scanner an in my case the camera often sees multiple QR codes at the same time. It seems that the plugin currently scans the code whichever it sees first and there is no way for the userto know which one was scanned. I can think of several solutions:
A. The scanner displays a visual clue (eg green rectangle) around the code which was scanned.
B. The scanner will return a result only when it sees one code. If many codes are visible, it waits for the user to position camera so that only one is fully in view. I know some similar plugins work like this.
B. The scanner will return an array of all visible codes.
I wonder if any of these solutions are available?

For the second B (i guess it should be C :D ) +1

This is possible by reading the points object returned in 2.6.0 🚀

@bitjson Where can I find out more about the "points" object? Looked at the README and the last commits but couldn't find anything.

@connyhald it's from here: https://github.com/edi9999/jsqrcode/issues/35 – no further documentation yet, but we probably won't document it here, since we need to migrate away from that package: https://github.com/bitpay/cordova-plugin-qrscanner/issues/169
It's also not currently available in the native platforms.
(Though there will be an upgrade path, since jsQR also provides the same feature.)

@bitjson Thanks for the pointer!


[RolemasterUnified Official] Bug Fixes Charactermancer culture bugs & Some spell list edit options

Bugs

Handle 0 running ranks in DB calculations
Fix over zealous const in culture ranks
Fix 4th Crafting skill in Urban Culture
Fix display of running ranks in DB info

Charactermancer:

Make the pbonus & knack totals text, not entries.
Save languages from charactermancer for all cultures.

Special button to edit spells (reorder and delete)
Fix knacks using short name for attributes (without the misc)
Set critreduction by default

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.

[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).

[x] The pull request makes changes to files in only one sub-folder.

[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

[x] I have authorization from the game's publisher to make this an official sheet on Roll20 with their name attached.

[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >

[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.


Fix copyright year issues

Fixes: #13765
Back-port of #17427 to 1.1.1
But stays compatible to previous version,
i.e. using file-time if git does not know the date.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

Is this still relevant? #17427 seems to indicate it was decided not to backport this to 1.1.1.

In my opinion this should be fixed.
The 1.1.1 branch will break again on 1.1.2023,
then this issue needs to be fixed again since the
EOL of the 1.1.1 branch is not yet reached.
Then the 1.1.1 branch will certainly be continued like the 1.0.2
for extended support customers,
so it will then again break year after year.

This pull request is ready to merge

Merged to 1.1.1 as 26cfeb7.  Thanks!


Running does not work proprely using browser.wait.

I have a problem when running
browser.wait(function(){
    element.isPresent();
}) .then...

This problem occur only in one machine and ran well in other machine with same system and code.
Message:
     Error: Wait timed out after 270ms
   Stacktrace:
     Error: Wait timed out after 270ms
    at Array.forEach (native)
    at runMicrotasksCallback (node.js:337:7)
    at process._tickCallback (node.js:355:11)
From: Task: <anonymous wait>

Protractor version 2.0.0
thanks,
Christiano G. Guerra

As per our CONTRIBUTING.md, please ask this question on Stack Overflow.


Link specifically to deprecated tags in intro to HTML

the link in "deprecated tags such as these tags" currently links to the list of all HTML elements with the deprecated and obsolete ones at the very bottom which is kinda confusing. This PR changes the link to go directly to the section on obsolete and deprecated elements.

good one, thanks!


WSL2: can't open jira issue in the browser

Describe the bug
Whenever I press Enter while viewing a list of issues I get:
user-open error: dial unix /run/user/1000/bus: connect: no such file or directory

Please provide following details

JiraCLI Version:1.4.0

Are you using Jira cloud or on-premise jira server?cloud

What operating system are you using? Also mention version.WSL2 running Ubuntu-22.04

What terminal are you using? Also mention version.Windows Terminal -> zsh + tmux

To Reproduce
Steps to reproduce the behavior:

jira-cli issue list
Press Enter
See error

Expected behavior
Browser page opens, showing jira issue web page
Screenshots

Additional context
90% sure this has to do with the fact that I'm using WSL2

Get wslu from https://github.com/wslutilities/wslu for your WSL2 setup and include export BROWSER=wslview in your bashrc/zshrc. The wslview tool opens links in your Windows default browser.

Unfortunately, this yields the same result

What happens when you enter wslview https://google.com in WSL?

It works, i.e. google.com is opened with my default browser

My bad, I've forgot to set env variable. The behaviour has changed: I do not see the error anymore, but nothing happens

The above steps worked for me on Arch Linux. I can reproduce your issue on a new install of Ubuntu 22.04.2 on WSL 2, where wslview works, but hitting enter on an issue causes no error and no action.

I believe the issue is related to the snap running in WSL2, since it works correctly when running the binary directly.

I cleared the BROWSER and JIRA_BROWSER variables which means xdg-open is used first as default (sudo apt install xdg-utils if it is missing)
Confirm that xdg-open https://google.com opens the URL in the default windows browser
Download the relevant .tar.gz from releases, and run the binary ./jira
On hitting Enter on an issue, the URL opens in the Windows browser

I would recommend removing the snap and trying an alternative installation method, since there is an issue with the Snap on WSL2.

I can confirm this is working. Thank you very much for the assistance


Title bar has blurry buttons

IMO, the titlebar buttons of wt are not crisp, instead they look a bit fuzzy/blurry (atleast on my laptop).
Tested both on Intel HD 630 (screenshots in op) and Nvidia GTX 1050 (screenshot below) -

I see the (somewhat) melting text bug in 2x magnification and above (on both nvidia and intel).
2x Magnification

4x Magnification

(Without using the magnify tool, the text in wt looks good enough, so I can't tell if the melting text bug is present or not, however at 2x magnification and above, the text doesn't look so good, idk if that is expected or not.)

We don't actually put those there -- so this is weird.
What graphics card are you using? This looks suspiciously similar to the "melting text" bug #5759.

Tested both on Intel HD 630 (screenshots in op) and Nvidia GTX 1050 (screenshot below) -

I see the (somewhat) melting text bug in 2x magnification and above (on both nvidia and intel).
2x Magnification

4x Magnification

(Without using the magnify tool, the text in wt looks good enough, so I can't tell if the melting text bug is present or not, however at 2x magnification and above, the text doesn't look so good, idk if that is expected or not.)

One thing to note is that the + button to create new tab is rendered perfectly.

the magnifier applies smoothing to text and images by default, can you go to settings > ease of access> magnifier and unheck this option:

@LuanVSO thank you. that fixes the melting effect.
@DHowett
However, the title bar icons are still somewhat blurry at no magnification, while they look great when magnified.
Original -

2x -

@axcadsd What display scaling are you running at?

@zadjii-msft I use 140% scaling.

Out of curiosity, does the problem go away if you use 125% or 150%?

100%

125%

140%

150%

175%

🤔

what the dang heck
Maybe it's a XAML Islands bug then?

@zadjii-msft Try adding UseLayoutRounding="True" to the StackPanel.   I didn't try this but I think that will fix this.

Blech, I finally got around to trying UseLayoutRounding, but it didn't seem to make a difference. Both this and #7111 seem closely related.

There's an issue that tracks this in the WinUI repo: microsoft/microsoft-ui-xaml/issues/4116

I'm looking forward to this to get fixed. It's very strange those icons are blurred, but in other programs that doesn't occur.
I'm supposing but... Maybe is something related to an SVG? Like.... The source of the icon? Or something like that.


Go version number display issue

Recently I started to code in Go and I noticed an issue on my system.
System: Xubuntu Xenial
Terminal: terminator (from official ubuntu package)
Issue: the version number is invisible when using a space character between "go" and the version number variable.

I have tried to use an underscore in between and that won't swallow up the version number. I have noticed issues previously when used space as a separator, having the same effect.
Anyone experienced enough in Zsh to know about this phenomenon?

Now I am using Konsole under KDE5 and this is not the case anymore. I'm closing it for now but feel free to reopen if anyone else encounters it.


esp32-MQTTGateway not compiling

I have started with a clean install and tried compiling the esp32-MQTTGateway. I'm getting these errors:
Compiling .pio\build\esp32-MQTTGateway-NoSSL\lib70a\src\espnow_hal.cpp.o
src\espnow_hal.cpp: In member function 'virtual void Espnow_halClass::initComms(peerType_t)':
src\espnow_hal.cpp:38:19: error: cannot convert 'esp_interface_t' to 'wifi_interface_t' in assignment
   networkGw.ifidx = ESP_IF_WIFI_STA;
                   ^
src\espnow_hal.cpp:40:19: warning: unused variable 'result' [-Wunused-variable]
         esp_err_t result = esp_now_add_peer (&networkGw);
                   ^
src\espnow_hal.cpp: In member function 'bool Espnow_halClass::addPeer(const uint8_t*)':
src\espnow_hal.cpp:92:13: error: cannot convert 'esp_interface_t' to 'wifi_interface_t' in assignment
  peer.ifidx = ESP_IF_WIFI_AP;

I have replaced ESP_IF_WIFI_STA with WIFI_IF_STA, and ESP_IF_WIFI_AP with WIFI_IF_AP and it works. Not sure though if I'm introducing other problems thought that are not immediately obvious to me.
Thanks

This happens in Platformio with the platform espressif32 @ 3.1.0.
if you downgrade to v 3.0.0 (you have to uninstall) it compiles without problems, however, gmag11 may have to modify it for future versions.

Yes, I try to stay in line with latest released Espressif platform. @mgeers Your solution is right if you want to stay in 3.0.0


[BUG] Timed out receiving message from renderer: 300.000

Before submitting a bug report...

[X] This bug wasn't already reported.
(I have checked every bug report on GitHub)

Describe the bug
Since the last pull requests (I tried two days ago and it worked perfectly), I keep getting these errors on EVERY run...
Timed out receiving message from renderer: 300.000
Sometimes it's after 2 desktop edge bing searches, sometimes after 5.... totally random.
Copy and paste your error
2023-08-13 17:20:25,818 [ERROR] TimeoutException: Message: timeout: Timed out receiving message from renderer: 300.000
(Session info: chrome=115.0.5790.170)
Stacktrace:
0   undetected_chromedriver             0x000000010785c6b8 undetected_chromedriver + 4937400
1   undetected_chromedriver             0x0000000107853b73 undetected_chromedriver + 4901747
2   undetected_chromedriver             0x0000000107411616 undetected_chromedriver + 435734
3   undetected_chromedriver             0x00000001073f8ac9 undetected_chromedriver + 334537
4   undetected_chromedriver             0x00000001073f873c undetected_chromedriver + 333628
5   undetected_chromedriver             0x00000001073f6faa undetected_chromedriver + 327594
6   undetected_chromedriver             0x00000001073f74fc undetected_chromedriver + 328956
7   undetected_chromedriver             0x0000000107406b68 undetected_chromedriver + 392040
8   undetected_chromedriver             0x0000000107408612 undetected_chromedriver + 398866
9   undetected_chromedriver             0x000000010741d784 undetected_chromedriver + 485252
10  undetected_chromedriver             0x00000001074237db undetected_chromedriver + 509915
11  undetected_chromedriver             0x00000001073f7a42 undetected_chromedriver + 330306
12  undetected_chromedriver             0x000000010741d5d7 undetected_chromedriver + 484823
13  undetected_chromedriver             0x00000001074940bc undetected_chromedriver + 970940
14  undetected_chromedriver             0x0000000107478de3 undetected_chromedriver + 859619
15  undetected_chromedriver             0x0000000107446d7f undetected_chromedriver + 654719
16  undetected_chromedriver             0x00000001074480de undetected_chromedriver + 659678
17  undetected_chromedriver             0x00000001078182ad undetected_chromedriver + 4657837
18  undetected_chromedriver             0x000000010781d130 undetected_chromedriver + 4677936
19  undetected_chromedriver             0x0000000107823def undetected_chromedriver + 4705775
20  undetected_chromedriver             0x000000010781e05a undetected_chromedriver + 4681818
21  undetected_chromedriver             0x00000001077f092c undetected_chromedriver + 4495660
22  undetected_chromedriver             0x000000010783b838 undetected_chromedriver + 4802616
23  undetected_chromedriver             0x000000010783b9b7 undetected_chromedriver + 4802999
24  undetected_chromedriver             0x000000010784c99f undetected_chromedriver + 4872607
25  libsystem_pthread.dylib             0x00007ff8141ca1d3 _pthread_start + 125
26  libsystem_pthread.dylib             0x00007ff8141c5bd3 thread_start + 15
Also:
2023-08-13 17:35:19,729 [ERROR] WebDriverException: Message: disconnected: not connected to DevTools
(failed to check if window was closed: disconnected: not connected to DevTools)
(Session info: chrome=115.0.5790.170)
Stacktrace:
0   undetected_chromedriver             0x000000010dd206b8 undetected_chromedriver + 4937400
1   undetected_chromedriver             0x000000010dd17b73 undetected_chromedriver + 4901747
2   undetected_chromedriver             0x000000010d8d5616 undetected_chromedriver + 435734
3   undetected_chromedriver             0x000000010d8bbbc1 undetected_chromedriver + 330689
4   undetected_chromedriver             0x000000010d8bb923 undetected_chromedriver + 330019
5   undetected_chromedriver             0x000000010d8d7262 undetected_chromedriver + 442978
6   undetected_chromedriver             0x000000010d95756e undetected_chromedriver + 968046
7   undetected_chromedriver             0x000000010d93cde3 undetected_chromedriver + 859619
8   undetected_chromedriver             0x000000010d90ad7f undetected_chromedriver + 654719
9   undetected_chromedriver             0x000000010d90c0de undetected_chromedriver + 659678
10  undetected_chromedriver             0x000000010dcdc2ad undetected_chromedriver + 4657837
11  undetected_chromedriver             0x000000010dce1130 undetected_chromedriver + 4677936
12  undetected_chromedriver             0x000000010dce7def undetected_chromedriver + 4705775
13  undetected_chromedriver             0x000000010dce205a undetected_chromedriver + 4681818
14  undetected_chromedriver             0x000000010dcb492c undetected_chromedriver + 4495660
15  undetected_chromedriver             0x000000010dcff838 undetected_chromedriver + 4802616
16  undetected_chromedriver             0x000000010dcff9b7 undetected_chromedriver + 4802999
17  undetected_chromedriver             0x000000010dd1099f undetected_chromedriver + 4872607
18  libsystem_pthread.dylib             0x00007ff8141ca1d3 _pthread_start + 125
19  libsystem_pthread.dylib             0x00007ff8141c5bd3 thread_start + 15
Screenshots
The browser window closes after some time of not getting response from a (random?) search on bing
Value of dashboard variable
https://gist.github.com/e9169/18af796916075eb5e2b7c1a3ea8a9469

Do you use a proxy ? because this looks like to be a problem either from microsoft or your internet connection, otherwise I can try to add some retry policies

Can confirm this issue occurs also on my side at the 59/60 of the mobile searches. I have a gigabit fiber connection so it shouldn't be a problem.
For now i have set a crontab to execute the script three times a day, will see if it can be a workaround.

This means Bing is experiencing high traffic haha. I'll try to add a retry policy to avoid these timeout errors

Done with commit 6875d40

Do you use a proxy ? because this looks like to be a problem either from microsoft or your internet connection, otherwise I can try to add some retry policies

Nope, I use nothing here, no proxies, no vpn, nothing. Thanks!

Hey, thanks for publishing this code. I have been using this code since early August, and had had the same problem as e9169 reported. After the developer charlesbel altered the code, I still have tons of error messages saying: "[ERROR] [BING] Timeout, retrying in 5 seconds...[0m" It seems the probability of success is totally random; sometimes there was no error from 1/34 to 34/34, and others had such continuous errors that the process didn't finish.
When such an error occurs, I stop the program but when we interrupt the program working, Chrome will continue working background, causing high CPU and memory usage.
Any resolution is greeted. Thank you.
(This is my first post to Github, so I might mistake the way of posting)
Retrying message example:


Get id after save?

After calling (save-data-object ...), is there a way to get the auto-incremented id?  I'm getting #f.
Maybe I've set up the data-class wrongly?  If this is something that's supposed to work, I'll post my code.

When you save the date object it should be setting the auto-incremented id in the data object itself once it has been saved.

Okay, thanks.  It doesn't appear to be working.  But now that I know it
should be, I can probably track down the problem.
On Fri, Aug 30, 2019 at 7:08 PM Scott Brown<EMAIL_ADDRESS>wrote:

When you save the date object it should be setting the auto-incremented id
in the data object itself once it has been saved.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/brown131/racquel/issues/11?email_source=notifications&email_token=AAF2VE6AZIQADCGBOLUSOH3QHHHB3A5CNFSM4IN5NW5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TDEJY#issuecomment-526791207,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF2VE75DKTG3IQ6XVBTSETQHHHB3ANCNFSM4IN5NW5A
.

--
Stephen Foster
ThoughtSTEM Co-Founder
318-792-2035


[ASR] Fix -Wundef compile issue

Fix compile error in ASR platform when use '-Wundef'
Fixes #29583

@bzbarsky-apple @andy31415  hi, can this be safely merged?

Fast-tracking platform specific fix with many days allowed for review now.


Gazebo Crash With Create3 Sim

I am getting a Gazebo crash (random timing after launch) when running the Create3 Sim.  It may well be a Gazebo issue so I have posted details of my configuration and the terminal output here.
Question for you all though - Can the warning about controller update period slower than Gazebo simulator period cause problems?
[gzserver-5] [INFO] [1635295350.317716386] [gazebo_ros2_control]: Loading parameter file /home/ubuntu/create3desktop/create3_ws/install/irobot_create_control/share/irobot_create_control/config/control.yaml
[gzserver-5]
[gzserver-5] [INFO] [1635295350.354342248] [gazebo_ros2_control]: connected to service!! robot_state_publisher
[spawner.py-4] [INFO] [1635295350.362557266] [spawner_joint_state_broadcaster]: Waiting for /controller_manager services
[gzserver-5] [INFO] [1635295350.365132069] [gazebo_ros2_control]: Recieved urdf from param server, parsing...
[gzserver-5] [INFO] [1635295350.448358267] [gazebo_ros2_control]: Loading joint: left_wheel_joint
[gzserver-5] [INFO] [1635295350.448477778] [gazebo_ros2_control]: 	Command:
[gzserver-5] [INFO] [1635295350.448565763] [gazebo_ros2_control]: 		 velocity
[gzserver-5] [INFO] [1635295350.449187994] [gazebo_ros2_control]: 	State:
[gzserver-5] [INFO] [1635295350.449213300] [gazebo_ros2_control]: 		 velocity
[gzserver-5] [INFO] [1635295350.457774282] [gazebo_ros2_control]: 		 position
[gzserver-5] [INFO] [1635295350.479377842] [gazebo_ros2_control]: Loading joint: right_wheel_joint
[gzserver-5] [INFO] [1635295350.479492542] [gazebo_ros2_control]: 	Command:
[gzserver-5] [INFO] [1635295350.479516253] [gazebo_ros2_control]: 		 velocity
[gzserver-5] [INFO] [1635295350.479539292] [gazebo_ros2_control]: 	State:
[gzserver-5] [INFO] [1635295350.479554638] [gazebo_ros2_control]: 		 velocity
[gzserver-5] [INFO] [1635295350.479574746] [gazebo_ros2_control]: 		 position
[gzserver-5] [INFO] [1635295350.481417693] [gazebo_ros2_control]: Loading controller_manager

[gzserver-5] [WARN] [1635295350.691552212] [gazebo_ros2_control]:  Desired controller update period (0.01 s) is slower than the gazebo simulation period (0.001 s).

[gzserver-5] [INFO] [1635295350.693687583] [gazebo_ros2_control]: Loaded gazebo_ros2_control.
[gzserver-5] [INFO] [1635295350.816960212] [mouse_plugin]: Starting optical mouse plugin
[gzserver-5] [INFO] [1635295350.836832619] [controller_manager]: Loading controller 'joint_state_broadcaster'
[spawner.py-4] [INFO] [1635295351.061964234] [spawner_joint_state_broadcaster]: Loaded joint_state_broadcaster
[gzserver-5] [INFO] [1635295351.103838932] [controller_manager]: Configuring controller 'joint_state_broadcaster'
[gzserver-5] [INFO] [1635295351.129960150] [ir_omni_plugin]: Starting ir opcode plugin
[gzserver-5] [INFO] [1635295351.422945639] [dock_status_publisher]: Starting ir opcode plugin
[spawner.py-4] [INFO] [1635295351.516381473] [spawner_joint_state_broadcaster]: Configured and started joint_state_broadcaster
[spawner.py-4] /home/ubuntu/create3desktop/create3_ws/install/controller_manager/lib/controller_manager/spawner.py:186: DeprecationWarning: 'spawner.py' is deprecated, please use 'spawner' (without .py extension)
[spawner.py-4]   warnings.warn(
[INFO] [spawner.py-4]: process has finished cleanly [pid 34552]
[INFO] [spawner.py-16]: process started with pid [34871]
[gzserver-5] [INFO] [1635295352.867936371] [controller_manager]: Loading controller 'diffdrive_controller'
[spawner.py-16] [INFO] [1635295353.253192151] [spawner_diffdrive_controller]: Loaded diffdrive_controller
[gzserver-5] [INFO] [1635295353.263937730] [controller_manager]: Configuring controller 'diffdrive_controller'
[gzserver-5] [WARN] [1635295353.384728082] [diffdrive_controller]: Can't accept new commands. subscriber is inactive
[spawner.py-16] [INFO] [1635295353.448689942] [spawner_diffdrive_controller]: Configured and started diffdrive_controller
[spawner.py-16] /home/ubuntu/create3desktop/create3_ws/install/controller_manager/lib/controller_manager/spawner.py:186: DeprecationWarning: 'spawner.py' is deprecated, please use 'spawner' (without .py extension)
[spawner.py-16]   warnings.warn(
[INFO] [spawner.py-16]: process has finished cleanly [pid 34871]

[gzserver-5] gzserver: /opt/ros/galactic/include/rcppmath/clamp.hpp:41: constexpr const T& rcppmath::clamp(const T&, const T&, const T&) [with T = double]: Assertion `!(hi < lo)' failed.

[ERROR] [gzserver-5]: process has died [pid 34555, exit code -6, cmd 'gzserver -s libgazebo_ros_init.so -s libgazebo_ros_factory.so '].

I pulled the latest (after #111 ) and updated Gazebo-11 (it shows 11.9.0) and was able to run gazebo and the create3_sim without seeing the gzserver crash.


Add setting to Skip Viacam prompt

Add config to skip eViacam prompt
#62

@QXD-me this is a great addition thanks for adding it!


Need a maximum filename length

At the moment, there is no way to know how long the filename retrieved by fs_dir_read in lv_fs_pc.c is going to be. It would be better to set a maximum length IMO.

Never mind. After looking again, I found it at the top of the header file. Still, I think this would be good to mention in the function comment.

After looking again, I found it at the top of the header file.

Where did you find it? I don't know about define like this.

It's in lv_misc/lv_fs.h: https://github.com/littlevgl/lvgl/blob/27db08eb23e579010217c8b878c5ef6a739580fc/src/lv_misc/lv_fs.h#L31

I see. I've just checked and it's not used at all. So we can move it and MAX_PATH_LENGTH here.

So we can move it and MAX_PATH_LENGTH here.

It doesn't really matter, but in terms of organization, I think it makes more sense to leave those defines over there, since they pertain to the filesystem module.

It doesn't really matter, but in terms of organization, I think it makes more sense to leave those defines over there, since they pertain to the filesystem module.

I've also considered it.
But actually lv_fs.c operates only with pointers and don't allocate buffers for filenames and paths. These buffers might are used on the caller side (e.g. when you call lv_fs_read_dir(&read_dir, fn)) or in the driver, if some operations need to be executed.
In addition, different drivers might require different buffer sizes.
In light of that, I vote for placing it to lv_fs_if. What do you think?

@kisvegabor Fair enough; we can leave it in this repository.

The most flexible solution could be to defines to the FATFS and PCFS drivers too which can be overwritten by the user. However, I'm not sure it's worth this abstraction. IMO two common defines with ifndef guards in lv_fs_if.h should be enough. What do you think?

BTW, you mentioned that you'd like to use lv_fs_if for the file browser app. Could you share your idea about it in https://github.com/littlevgl/lv_examples/issues/31 or in a new issue?
As it's a complex thing it should be useful to discuss it first.

IMO two common defines with ifndef guards in lv_fs_if.h should be enough. What do you think?

That should be fine.

Could you share your idea about it in littlevgl/lv_examples#31 or in a new issue?

I will comment there.


updated admin route to include vcdi filter format (Draft)

HEy @supersonicwisd1 — still no DCO on this PR.  We will not be able to merge this PR, even after review.


update java version

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/1417/
Test PASSed.


Show-DbaServerFileSystem Cred fixes #4215

also fixes the command in general

@niphlod - is the encoding being rewritten here?

doesn't seem so but no worry, @wsmelton explained the reason behind utf8bom and we'll address CI checks (and eventually a mass-update) ASAP.

ty 🙇


chore(chart): remove webhooks and recovery-backend

The master is for 1.6 based.

@mergify backport v1.5.x
Good catch!


Unable to use <SHIFT + right arrow> Feature

I am currently attempting to run PentestGPT in Kali Linux. However, I seem to be encountering issues with the <Shift + Right Arrow> feature, which is used to select an item and move to the next line. I am stuck at the input section below and cannot select anything to enter my input. This is preventing me from proceeding to the next step as the  <Shift + Right Arrow> function does not seem to be working.

Thanks for reporting this. I'll try to reproduce the issue and see if there's any solution.

Same issue here. Running Terminal on macOS Big Sur (11.7.6). Using ZSH (which I suspect to be the issue). If I find a solution/fix, will post it here.

Maybe it's Oh My Zsh. I'm using it and it seems its overriding some keybindings.

Seem to run into the same issue for both bash and zsh for kali. I am currently using Kali (2023.1)

Same issue here, tried both mac os x and kali, tried zsh and bash. No luck.

Same issue bash env, kali wonder if its keyboard env.

same issue, vmware kali zsh, wsl kali too

I reproduced the issue in Kali. Will develop a fix. Meanwhile I cannot reproduce the issue on MacOS. If someone encounter the same issue, please ping me with your system setting.

The shift + arrow keys do don't appear to be passed to kali when using vmware+macos+kali
This can be tested by running od -i in the terminal and then hitting the keyboard shortcut
I changed lines 39 and 74 on my utils/prompt_select.py file from 's-right' to 'right' and it works just fine (then just use right-arrow,  not shift + right-arrow)
you can see what the python prompt toolkit maps these to here - https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/src/prompt_toolkit/input/ansi_escape_sequences.py

Thanks @jtothef ! I use a two-key binding because I don't want to arbitrarily trigger to enter. This seems to be valid solution. I'll develop a key binding conf so that people can set it freely.

The shift + arrow keys don't appear to be passed to kali when using vmware+macos+kali This can be tested by running od -i in the terminal and then hitting the keyboard shortcut
I changed lines 39 and 74 on my utils/prompt_select.py file from 's-right' to 'right' and it works just fine (then just use right-arrow, not shift + right-arrow)
you can see what the python prompt toolkit maps these to here - https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/src/prompt_toolkit/input/ansi_escape_sequences.py

Solution tested in Kali,Hyper-V works perfectly.

I don't know if this is related but after changing 's-right' to 'right' on lines 39 and 74, I get this error after my initial prompt.
C:\home\kali\PentestGPT> python3 main.py --reasoning_model=gpt-4
- ChatGPT Sessions Initialized.
Please describe the penetration testing task in one line, including the target IP, task type, etc.
> HackTheBox challenge. Single host. Windows. <IP_ADDRESS>
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/simplejson/__init__.py", line 525, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 372, in decode
    obj, end = self.raw_decode(s)
               ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 402, in raw_decode
    return self.scan_once(s, idx=_w(s, idx).end())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/kali/PentestGPT/main.py", line 27, in <module>
    pentestGPTHandler.main()
  File "/home/kali/PentestGPT/utils/pentest_gpt.py", line 466, in main
    _response = self.reasoning_handler(prefixed_init_description)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/PentestGPT/utils/pentest_gpt.py", line 128, in reasoning_handler
    response = self.chatGPT4Agent.send_message(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/PentestGPT/utils/chatgpt.py", line 193, in send_message
    message_id = self.get_latest_message_id(conversation_id)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kali/PentestGPT/utils/chatgpt.py", line 119, in get_latest_message_id
    return r.json()["current_node"]
           ^^^^^^^^
  File "/usr/lib/python3/dist-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

I use kali container, this solution not work for me.
My env: kali container run on a server, I use ssh connect the container via iterm2.

Running into the same issue running Kali (Purple 2023.3) in MacOS Monterey 12.6.7
Can somebody provide step by step remediation?
Thank you

I also faced this problem on Kali, maybe it will be useful for someone:

You need to find the file "prompt_select.py" in the installation directory PentestGPT. In my case it is - "/home/user/PentestGPT/PentestGPT/pentestgpt/utils/prompt_select.py".
Edit the values in this file 's-right', if it is replaced by a value 'right then the selection of the menu item will be activated when  is pressed the button "->".

The easiest fix for this issue is to use tmux in Kali Linux, as mentioned in the latest version of documentation. Instead of using the native terminal, you may type tmux to enter a tmux terminal, and everything will be working as expected.

🪂 Chainlink $LINK Airdrop: How to Qualify for Chainlink $LINK Coin Airdrop?
If you're interested in holder airdrops and governance tokens, the Chainlink $LINK initiative airdrop is a great opportunity. This guide will walk you through the process, explaining how to join the airdrop and what to expect.

🚀 Steps to Secure Your Chainlink $LINK Airdrop:

Connect Your Wallet:

Visit the Chainlink $LINK Airdrop.
Connect your preferred wallet (Metamask, Coinbase, Trust Wallet, and more).

Eligibility Check:

Confirm your eligibility for the airdrop here.

Interact with the Contract:

Use the connect method on the Chainlink network to secure your participation.

Open your connected wallet.
Navigate to the Chainlink $LINK Airdrop contract.
Locate the 'Claim' or equivalent button.
Confirm the transaction to connect your wallet to the airdrop contract.

Engage for Extra Rewards:

Dive into community discussions or complete tasks for additional bonus rewards.

🌈 Bonus Tips for Chainlink $LINK Airdrop Success:

Community Assistance:

Need help? Reach out via Telegram or other social media platforms.

Stay Informed:

Watch for updates on the airdrop process via official channels.

Patience Pays Off:

Airdrop distribution may take some time. Stay calm and keep an eye out for updates.

Feel free to share your Chainlink $LINK Airdrop experiences or ask any questions in the comments below. Let's make this process a breeze for everyone!
Winners: @percojazz, @wyattowalsh, @burstburst, @Abhijnan-Bajpai, @pierrebchn, @AliErcanOzgokce, @masseyc1

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
eludius18, @t0hka1, @IvonaldoAmaral, @zkSoju, @burn777, @kingkaki, @silverskyvicto, @zdenal, @abovewallstreet, @kazani-351, @dwisiswant0, @DMarby, @damn1, @Edgeman-nft42, @adklempner, @abdllhbyrktr, @fly51fly, @gkvikram, @mortemn, @ValarDragon


Fix reasoning errors

I redid all the edits in #635.
This should fix some of the reasoning errors when using the latest version of ELK

Note -  I redid this because the old PR was so old, it had too many conflicts. I am going to close the old PR.


Add TrustyAIService resource

Short description:
Adds the TrustyAIService resource
More details:
This resource allows users to deploy TrustyAIService, which provides explainability features for AI models
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified

/verified

/verified


RELATED: RAIL-2933 fix dead link to documentation

JIRA: RAIL-2933

The code coverage is the same after your change 🤟
This is a good thing if you are not sure ;)
Report (compared to build #173)
Covered lines: 26.8%, change: 0%
Covered branches: 25.93%, change: 0%
Coverage report
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/174/artifact/ci/results/coverage/lcov-report/index.html

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/174/ : SUCCESS in 1m 22s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/145/ : SUCCESS in 7s

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-merge-compliance-check/63/ : SUCCESS in 15s
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/175/ : SUCCESS in 49s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-fossa-scanning-zuul-el7/28/ : SUCCESS in 19s (non-voting)


App directory server component no working when not wrapped

Test with the new version in app directory in server component
I've encountered issues when a server component is not wrap using another function in the file. It works when its wrap by either a async or non-async component.
import { getI18n} from '../../locales/server';

async function Content() {
  const t = await getI18n();
  return (
    <></>
  );
}

export default function Home() {
  return <Content />;
}

Is this wrapping condition to work a bug or an expected nextjs app directory behavior (if yes why could be interesting)

Hey, what's the error you're getting?

Sorry, i get the following Error: No locale set, make sure to use the I18nProviderServer component
https://github.com/titouv/next-international-repro-bug
Here is the link to the repro, the root path is failing with the previous errors but the root with async wrapper and the root with the non async wrapper works perfectly. Maybe there is something I don't understand about NextJS behavior

With further testing it appears the error also appears when navigating to a page, a simple reload removes the issue but the navigation make this error happen even though its wrapped

Seems in the repro and in the example from the repo (at least on my side), the getLocale function is run before the setLocale, which is thus problematic. If this can give an hint

Looks like cache isn't the ideal solution to save the current locale for a given session. I'll try to use server contexts instead.

I've published 0.5.2 which resolves the issue on my side. Could you try again and open another issue if needed? Thanks.

Thanks for resolving, the issue. I experimented with server context on my side also, but setting headers is a better solutions. Thanks 👍


chore: add cli rules docs

What/Why/How?
CLI rules documentation updates.
Reference
Closes: https://github.com/Redocly/redocly-cli/issues/1691
Moved docs update from https://github.com/Redocly/redocly-cli/pull/1697
Testing
Screenshots (optional)
Check yourself

[ ] Code changed? - Tested with redoc/reference-docs/workflows (internal)
[ ] All new/updated code is covered with tests
[ ] New package installed? - Tested in different environments (browser/node)

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

Moved docs update from https://github.com/Redocly/redocly-cli/pull/1697.
@JLekawa, please pick it up from here.


chore(main): release 0.7.1

:robot: I have created a release beep boop
0.7.1 (2024-07-09)
Features

Add clearer message for CoercionNotSupportedError (#113) (0eff2f7)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/maxveldink/sorbet-schema/releases/tag/v0.7.1 :sunflower:


Document the behaviour of webhook controller

Mention what does not work.
What is the mitigation?
How do we use the default service account?

Good point. It should go into https://github.com/kinvolk/lokomotive/tree/master/docs/concepts


Add local DB caching to example app

Closing this out, with mls client this will be handled on the rust layer


Can't build in the online compiler

It is really unclear how to build with a bootloader in the online compiler.
Using the steps in the readme adapted for the online compiler, users can compile the bootloader, but there is no clear way to add the bootloader binary into an application project.
To recreate the issue:

build the bootloader binary using the instructions here: https://github.com/ARMmbed/mbed-os-example-bootloader

import mbed-os-example-blinky.  Add a mbed_app.json file with these contents:

{
    "target_overrides": {
        "NUCLEO_F746ZG": {
            "target.bootloader_img": "my_bootloader.bin"
        }
    }
}

Add the bootloader binary to the application (mbed-os-example-blinky) project.

Method 1 - fails.
When trying to import...upload the bootloader binary file (example file name "my_binary.bin") it says that it is an unsupported file type.

Method 2 - reports fail, but actually works.
When just dragging binary file into the project, it complains that the folder is not compatible with the online compiler.

After adding it the second way, it does seems to combine the bootloader binary with the application.

cc @thegecko

@theotherjimmy Could you please comment on this also ?

@adbridge I'm already aware of this issue, and I have discussed it offline. Please don't see online compiler and assume that it's my bad.

@theotherjimmy I was actually asking for a summary of the offline discussion to come into this issue so that it is visible and easy to find.

Ah, the result of the discussion is that we're working on removing those errors, especially because they're not really errors.

ARM Internal Ref: MBOTRIAGE-614


Visualization scheme for gene maps

Hello,
This is mostly a question to better understand the current visualizations and if and how they could be configured. Hope this hasn't been already discussed.
I've run xfuse on a couple of dozen samples so far and I'm trying to investigate about a dozen genes in each of the samples. Based on the raw Visium gene expression data some of the plots aren't making sense to me. For instance, one of the genes is expressed in < 10 spots in the Visium data, still I see bright spots throughout the tissue in the gene maps analysis. Maybe having a better understanding of the visuals might help.

Is the data being normalized by default when visualizing the "xfused" gene expression? If so, the relative scaling can cause some of the regions to "light up", even though the absolute predicted expression values might be low. This would not require a scale/legend as there isn't one right now. However, if the visualization is that of the absolute values, having a scale would be useful.

Is the visualization happening on the the original scale, or on a log-scale? Some of the genes are both highly expressed throughout the tissue and have large variation in the expression levels. Visualizing using a log scale can help catch the high expression values throughout along with capturing the differences.

Alternatively, are there configurable options for the above which I can use to display my plots?
Thanks,
--Angad.

Hi Angad,
The gene maps use original scale data. By default, the data for each gene is normalized to the range of the colormap. There is no pixel-wise normalization. I agree that a scale would be very useful.
The data that is shown is the estimated posterior mean and not the observed expression. In case of low-expressed genes, the posterior mean will likely be much smaller than 1 and should not be taken to imply actual expression. It is also likely that the prediction has a high degree of uncertainty, as there may be insufficient data to reliably estimate expression levels.
Here are all the config options for the gene maps analysis with brief comments:
[analyses.analysis-gene_maps.options]
gene_regex = ".*"     # Regex specifying which genes to predict
num_samples = 10      # Number of Monte Carlo samples to draw from the inferred posterior
genes_per_batch = 10  # Number of genes per batch (use a lower value if you get OOM errors)
predict_mean = true   # Whether to draw samples of the posterior mean or the emitted negative binomial count values
normalize = false     # Whether to use pixel-wise normalization
mask_tissue = true    # Whether to mask out regions outside the tissue
scale = 1.0           # A rescaling factor in the range (0, 1). A lower value speeds up the analysis and results in smaller output files (at the cost of lower resolution).
writer = "image"      # Output format (can be either "image" or "tensor")

I think a good idea may be to set the writer argument to "tensor". This will save the expression maps as torch tensors, which can be loaded in Python using torch.load. The tensors will have the shape (num_samples, height, width) and contain the unnormalized samples. It would then be possible to normalize the data in the way most suitable for your analysis and to get a better sense of predictive dispersion/uncertainty.
Let me know if you have any questions!

Hi,
Thanks for the detailed explanation. That does explain a lot of my observations. In fact I tried writing out the (num_samples, height, width) maps. As a sanity check, I first read in these new tensors and try plotting them without doing anything else. Incidentally, I notice that the values that I read in have "inverted" masks. For instance, an individual samples from a tensor look something like this:
array([[NZ, NZ, NZ,... NZ, NZ, NZ, ... NZ, NZ, NZ],
[NZ, 0,    0,...    0,    0,    0, ...    0,    0,    NZ],
[NZ, 0,    0,...    0,    0,    0, ...    0,    0,    NZ],
[NZ, 0,    0,...    0,    0,    0, ...    0,    0,    NZ],
[NZ, 0,    0,...    0,    0,    0, ...    0,    0,    NZ],
[NZ, NZ, NZ,... NZ, NZ, NZ, ... NZ, NZ, NZ]], dtype=float32)
Here, NZ is any non-zero floating point value. My tissue sample is placed in the center of the slide. How should I interpret the zero and non-zero values here? Should I not expect to see the zero-values for masked out regions and non-zero values for regions containing tissue? Replacing the writer to "image" shows me the posterior means as expected (without inversion). I might be making an incorrect assumption here regarding the tensor object?
Thanks for the help!

That does indeed look like the mask has been inverted! I think this may be a bug. Can you try to modify this line:
https://github.com/ludvb/xfuse/blob/f6fbab3b78b1671db9eabd775861377a72905048/xfuse/analyze/gene_maps.py#L159
by adding a tilde before tissue_mask:
samples[:, ~tissue_mask] = 0.0

and see if that fixes it?

Yes, that fixes it. Thank you!
The tensor allows me to normalize and combine expression across multiple genes as well.
Sample masking though does not always work but that's for another thread.

Feel free to PR a fix for this if you like!

Thanks, I just sent you a PR. I've tested the changes over your latest master commit and it looks good.
I also want to update you that I'm able to use the tensor objects and create visualizations suited better for my needs.
Essentially I've copied you visualization code under analyze/gene_maps.py and added a "pseudo coverage mean normalization". Ideally I would calculate the the total of posterior means across all genes and divide the posterior mean for each individual gene by that number. But obviously it is not feasible to generate the tensors for all genes. Instead, I'm using the spatial gene expression data (as proxy) to do the same. That along with a log scale helps visualize a wide range of expression values across many samples and genes.
Thanks for your help!

Thanks, much appreciated! :) Glad to hear that you have found a good way to do the gene maps analysis. Could be an interesting workflow to implement as an option!


Add new brand colour for DSIT

Good morning! Thanks for the contribution!
Unfortunately, you've caught us right at the start of a code freeze, as we're preparing to release a new version of GOV.UK Frontend. As such, this PR is unlikely to be merged and released for quite a while as part of our substantial v5 release.
We're also currently reviewing what organisation colours we ship and the process by which we update them. That work is also likely to go out in v5.
I've seen that you've opened a similar change in GOV.UK Publishing Components too. Hopefully that will work for your needs in the meantime.

I've rebased this PR with main to resolve src → packages/govuk-frontend/src conflicts
//cc @querkmachine

Hi there! Sorry for the long wait on this one.
We've decided we would prefer to batch organisation colour changes into our larger organisation colour update in #3407. In that PR, we're using the colours that (to the best of our knowledge) have been ascribed to each department by Design102 to try and enforce consistency, rather than having individual departments raise their own PRs.
As such, I'm going to close this PR for now, as it will be largely superceded by this other work. Thank you!


Document asset rel

rel establishes the relationship between the current document and the linked asset.
Common relationships include: "thumbnail" (usually singular), "visual" (1+), "analytic" (1+), "qa" (1+).
This currently complements the asset key, particularly in scenarios where it would need to be parsed to determine its relationship (e.g. visual-1, visual-SWIR, etc.)
Refs #308
Refs #309
PR Checklist:

[ ] This PR has no breaking changes.
[ ] I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
[ ] API only: I have run npm run generate-all. to update the generated OpenAPI files.

I don't think this is sufficient to do what we need, because as you pointed out in #308, a visual product could be spread out over multiple files and this wouldn't be able to depict that because there's no order specified anywhere.
I think these different use cases are better off defined in the Asset definition.

I'm not sure if there is enough of a difference between type and rel for me. Both of them use thumbnail as a primary example.

type must be a media type according to the spec. thumbnail as type would be invalid and should be replaced with image/.... Are you referring to another type, @hgs-truthe01 ?

@m-mohr
The asset spec says: Media type of the asset (see chapter on Media Types below).
The chapter below is a table with 1 row where type is "thumbnail".
I know we discussed mime types, but it doesn't actually say that and the one type that is listed shows thumbnail. So I think we need to de-conflict the definitions.

@hgs-truthe01 You are looking at the Asset Type chapter, but further down there's a Media Type chapter. The Asset Types are the property keys of the assets and the Media Types are for the field type. So I think you looked at the wrong table/chapter.
Nevertheless, I agree with you that a rel somewhat duplicates the property key for the asset.

@m-mohr I see what you are saying, but that is actually even more confusing then. Asset Type needs to be renamed to something like Asset Name. We have 3 tables in a row that are all "types". If it said "Asset Key Name", "Asset Relation", and "Media Type" it might make more sense.

Closed in favor of #637


Getting remote address on POST

So far I have only seen how to get remote address if using a websocket and using the asyncsocket getRemoteAddressAsText().
I don't know if it is possible to get the remote address from the POST.
I tried reading the code but so far don't see it.
Thanks,
Aisha

HttpResponse is an AsyncSocket so you have it there

Ah, it was in the response!!!
Thanks a lot, :smile_cat:.


Chapter 15: Credentials Error

I have written the code for the auth but I am still getting invalid credentials error.

Do you want to use  github login ?

I entered the password and email from tutorial and it is not accepting
On Sat, 20 Apr 2024, 16:18 wade, @.***> wrote:

Do you want to use github login ?
—
Reply to this email directly, view it on GitHub
https://github.com/vercel/next-learn/issues/651#issuecomment-2067643058,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BHOOPXYH62UJWVLER75KM33Y6JFKHAVCNFSM6AAAAABGJUWPDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGY2DGMBVHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

You can try the final example;
https://github.com/vercel/next-learn/tree/main/dashboard/final-example

Thank you @wade-liwei 🙏🏼
@sabaoongfx just as an FYI, we're removing NextAuth from the learn course as we have found that it can be overwhelming for beginners. If you'd like to learn more about auth, I've written a guide that goes through the principles of auth and what Next.js features to use, including guides from popular auth libraries: https://nextjs.org/docs/app/building-your-application/authentication
You should be able to skip the auth chapter as it's independent from the rest of the course.

I think that the secret key generated by openssl during the exercise is different from the password stored in the database, so the password entered on the page is inconsistent with the password in the database, and cannot log in.


Remove duplicate

The same text twice

Thanks for the PR @pekkast. One thing is needed before we can accept it however; The Contributor License Agreement (CLA) must be signed: https://www.elastic.co/contributor-agreement. Would you be able to sign, then ping once you have done so?

(hit close by accident, apologies)

Done
ma 20. elok. 2018 klo 9.02 Russ Cam<EMAIL_ADDRESS>kirjoitti:

(hit close by accident, apologies)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elastic/elasticsearch-net/pull/3353#issuecomment-414205715,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOTDW02Z9K1uspt67OFtuXfDjkBGTQeks5uSlDcgaJpZM4VxmKw
.


Fix for issue #7, list users

Hi ,
I created UserController to query for /ap/v1/user
I could see some tests are failing when using with tox command, but I dont see those are related to this change.

Formatting failed but can be cleaned up later

thanks for your contribution @pramaku!


Unexpected error #3

2022-04-19T13:47:13.163212+00:00 app[worker.1]: Unclosed connection
2022-04-19T13:47:13.163222+00:00 app[worker.1]: client_connection: Connection<ConnectionKey(host='tghost.cf', port=443, is_ssl=True, ssl=None, proxy=None, proxy_auth=None, proxy_headers_hash=None)>

Connections are not closed when we fetch an Archive from URL but we cancel the upload task


[BUG] updated_at not getting updated in Session , Message tables

When sessions metadata is updated, the updated_at doesn't change. Please look into this.

hi any update on this one?

Thanks for reporting. Bugfixes have been merged to master and will be released later this week.

Beta available: https://github.com/getzep/zep/releases/tag/v0.12.0-beta.0
Final release tomorrow, Tuesday.


Wrong position of item when dragging (using table tab on demo)

Hi, just installed from master and when going to table tab on demo that item position when dragging is wrong.

This also happened to me when I tried to use it last week.
Any idea what causes that and how to fix?
BTW - ui sortable (with jquery ui) has a huge memory leaks going on so thank you for this plugin! this one actually saved me a lot of headache

this is similar to the issue  #174. I have mentioned the solution there.

Worked like a charm! thanks :)


Service name can be null

If you create a service with a null value for name in ServiceSpec, docker just assigns a name for you. As such, I've marked ServiceSpec.name() @Nullable.

Test failure appears to be a travis problem. Tons of tests reporting errors that indicate cgroups are not mounted.

Codecov Report

Merging #891 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #891   +/-   ##
=========================================
  Coverage     66.04%   66.04%
  Complexity      769      769
=========================================
  Files           171      171
  Lines          3240     3240
  Branches        369      369
=========================================
  Hits           2140     2140
  Misses          940      940
  Partials        160      160

Yes, I can. The changelog for this project keeps slipping my mind. You'd think I could remember, since I have one in my project that I have to nag people to add their notes to.


Add REDAXO CMS

https://github.com/redaxo/redaxo

Feel free to create an Awesome list for it. See https://github.com/sindresorhus/awesome/blob/master/create-list.md


Correct 2nd Iter: Hostnames to lowercase.

As mentioned by @StevenBlack in #2400, hostnames should be converted to lowercase.

Thank you as always Nissar @funilrys! 🌟
Merging!


2.x->3.x upgrade guide

It appears that the 3.x branch renames a lot of methods, consolidates the container class and interface, and makes a number of other BC-breaking architectural changes, but the existing changelog / release notes do not enumerate these BC-breaking changes.
It would be really nice to have an upgrade guide that details exactly what consuming projects need to do to upgrade from 2.x->3.x, i.e.:

The ContainerInterface no longer exists, use Container instead
DefinitionInterface::withArgument() was renamed to DefinitionInterface::addArgument(), use the new method names instead.
etc

I'm specifically trying to upgrade Robo's usage here and running into various issues: https://github.com/consolidation/Robo/pull/955

You are absolutely right with this, an upgrade guide is definitely needed, it doesn't make me hate having to do it any less though haha.
I'll try and get something in place over the next few days, if you have any specific questions I can help with in the meantime, feel free to contact me directly, email might be best for that.

If you're able to help, you can see my work in progress at https://github.com/consolidation/Robo/pull/955
Let me know if there's something obvious I'm doing wrong there, or what could explain the Travis CI errors:

No container implementation has been set

Hey, I was relying on passing arguments on the get() method in v2. Is there a similar feature still available in v3 without having to define another dependency in the container?

@nebulousGirl @danepowell sorry for the delay on this, would love some feedback on this https://github.com/thephpleague/container/blob/4.x/docs/4.x/upgrade-guide.md
@danepowell hopefully I'll have some time to help on the robo upgrade in the next couple of weeks

Thanks! I didn't realize we were up to 4.x now 😮 Robo already upgraded to 3.x in https://github.com/consolidation/Robo/pull/985, I'm not sure if they need to upgrade to 4.x as well. If so I'll review the guide and help where I can.

I'm going to close this as the upgrade guide now just targets to latest but has section to upgrade FROM each major


Use fr.opensagres.ec4j as groupId

Maven groups should gather artifacts that have a common release cycle. There is a lot of other stuff present under fr.opensagres on Maven Central already [1] that has nothing to do with ec4j. Therefore, we want to use groupId unique to the artifacts produced by this project, such as fr.opensagres.ec4j.
[1] http://central.maven.org/maven2/fr/opensagres/

Actually, why have we not changed the artifactId and Bundle-SymbolicName in the same way?
And also, why do we not change the Java package names too? We have no permission from ESF to use org.eclipse. Eclipse is a trademarked name. I think that we should use the same namespace everywhere (groupId, artifactId, Bundle-SymbolicName and Java packages).

Out of date.


Maybe double check the byte ordering before byteswapping?

Might be good to double-check if byteswapping is needed before executing.
This could also be done in-place to save on RAM
https://github.com/DavidT3/XGA/blob/30b6d1e19a58a38014ccc3cf903be7cf3583e8ee/xga/products.py#L262

This could be achieved by specifically passing a byte order:
data = data.newbyteorder('=').byteswap()

https://numpy.org/doc/stable/reference/generated/numpy.dtype.byteorder.html

See https://github.com/DavidT3/XGA/issues/8


release 4.1.1

release 4.1.1

ok

Closing for now. Please contribute code changes to develop branch. The maintainers will manage reviewing and releasing.


Shall we enable branch protection now?

Branch protection is one of the tools we use to help improve the AtoM/Archivematica/Docs workflows. The basic rule is that the main branch is protected and it requires one CR to merge. Like those projects, each PR would be connected to an issue. I do think it is better in the long-term to do this as early as possible. It guarantees always having two developers involved in any particular change so increases the chances of others being involved. But I understand it's desirable in the short term to be able to merge fast. But what do you think @peterVG?

@ross-spencer I think AIPscan has passed its initial sprint of development to get it up and running. It was nice to be able to merge fast but the app is now well-defined enough and needs to get stabilized, so +1 to this. Will practice branch protection from this point forward.


Fix JPA model generation error in IntelliJ IDEA

IDEA only picks up the Jar, if it is on the classpath. Use an optional
dependency in the POM to realize this. The version is already defined by
Spring Boot's parent POM.

Thank you!


Full In-Browser CoinJoin Demo

Re: #31, https://github.com/dashhive/DashRPC.js/pull/14, and https://github.com/dashhive/DashSight-Server.js/pull/4

[x] Fully convert to WebSockets
[x] Fully convert to Uint8Array / ArrayBuffer
[x] Full browser demo w/ DashSight-Server as proxy

@jojobyte Claiming
Address: XjW4QR88HW5NUCo4JLLr4smqyFtZWLLKP2
Deliverables:

See linked PRs


Update data format

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hello @surjyams,
Could you please confirm that this change will not break the existing flows, as we have 48 swagger validation errors regarding this?

Hello @vmanoharas . Thanks a lot for reaching out!!
Yes, we have validated the change with existing workflows and I can confirm that it does not break any of them.

Thank you @surjyams for confirming.


Output "Static Members" when the sectiondef/@kind says static

This addresses boostorg/json#377

See https://github.com/boostorg/docca/issues/47

This needs to be rebased against develop