[camera_android] 0.10.9+5 breaks the preview's orientation

Steps to reproduce

camera_android: 0.10.9+5
Runs on a real device.
Choose the back lens.
The preview got rotated unexpectedly.

Roll back to v0.10.9+3 works as expected.
Expected results
The preview should follow its actual orientation (portrait up).
Actual results
The preview is rotated to landscape left.
Code sample
https://pub.dev/packages/camera_android/example
Screenshots or Video

0.10.9+3 ✅
0.10.9+5 ❌

Logs
N/A
Flutter Doctor output
[✓] Flutter (Channel stable, 3.22.2, on macOS 14.5 23F79 darwin-arm64 (Rosetta), locale zh-Hans-CN)
    • Flutter version 3.22.2 on channel stable at /Users/alex/dev/flutter-322
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (2 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

cc @camsim99
#149294 is related to targeting with another implementation package.

Migrating to the camerax implementation is unacceptable to downstream packages since:

The camera_android is not deprecated.
flutter pub upgrade will automatically upgrade the package to this broken version and shipped to the user end.
Both packages are still experimental (no major version releases yet).

Reproducible using the plugin example app. This indeed works as expected with camera_android: 0.10.9+3 but does not work with 0.10.9+5

0.10.9+5
0.10.9+3

flutter doctor -v
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.22631.3155], locale en-US)
    • Flutter version 3.22.2 on channel stable at C:\Users\Deana\fvm\versions\stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (2 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\Deana\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.8.34322.80
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.87.2)
    • VS Code at C:\Users\Deana\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.90.0

[√] Connected device (4 available)
    • Pixel 7 (mobile)  • 28291FDH2001SA • android-arm64  • Android 14 (API 34)
    • Windows (desktop) • windows        • windows-x64    • Microsoft Windows [Version 10.0.22631.3155]
    • Chrome (web)      • chrome         • web-javascript • Google Chrome 126.0.6478.62
    • Edge (web)        • edge           • web-javascript • Microsoft Edge 124.0.2478.97

[√] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.23.0-13.0.pre.242, on Microsoft Windows [Version 10.0.22631.3155], locale en-US)
    • Flutter version 3.23.0-13.0.pre.242 on channel master at C:\Users\Deana\fvm\versions\master
    ! Warning: `flutter` on your path resolves to C:\Users\Deana\fvm\versions\stable\bin\flutter, which is not inside your current Flutter SDK checkout at C:\Users\Deana\fvm\versions\master. Consider adding C:\Users\Deana\fvm\versions\master\bin to the front of your path.
    ! Warning: `dart` on your path resolves to C:\Users\Deana\fvm\versions\stable\bin\dart, which is not inside your current Flutter SDK checkout at C:\Users\Deana\fvm\versions\master. Consider adding C:\Users\Deana\fvm\versions\master\bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5187cab7bd (5 days ago), 2024-06-14 23:35:34 -0400
    • Engine revision 9779c273aa
    • Dart version 3.5.0 (build 3.5.0-266.0.dev)
    • DevTools version 2.36.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\Deana\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.8.34322.80
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.87.2)
    • VS Code at C:\Users\Deana\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.90.0

[√] Connected device (4 available)
    • Pixel 7 (mobile)  • 28291FDH2001SA • android-arm64  • Android 14 (API 34)
    • Windows (desktop) • windows        • windows-x64    • Microsoft Windows [Version 10.0.22631.3155]
    • Chrome (web)      • chrome         • web-javascript • Google Chrome 126.0.6478.62
    • Edge (web)        • edge           • web-javascript • Microsoft Edge 124.0.2478.97

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

To be clear, only Flutter 3.22 can reproduce this because the SDK constraint has been set in the latest version of the plugin, so previous Flutter users won't resolve this version.

This is a duplicate of https://github.com/flutter/flutter/issues/149294 I believe.

This is a duplicate of #149294 I believe.

@camsim99 As I mentioned, #149294 and all its references are targeting the camera implementation (like PRs are only changing files with camerax), not the camera2, so I believe it's not a duplicate but only shares the same behavior.

@AlexV525 Gotcha. Looks like camera_android may need a similar fix to the one camera_android_camerax is getting to support Impeller.

FYI @jonahwilliams. Going to approve the revert.

Then we should continue tracking this with a further reland if I get this correct.

From triage: We suspect this is a duplicate of #149177

From triage: We suspect this is a duplicate of #149177

Again, the issue is about the Camera2 implementation not the CameraX.

Fixed in 0.10.9+6


update requirements file and sage300 url

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@b24ab7c). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #80   +/-   ##
=========================================
  Coverage          ?   74.69%
=========================================
  Files             ?       51
  Lines             ?     2185
  Branches          ?        0
=========================================
  Hits              ?     1632
  Misses            ?      553
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Klondike Browser

Klondike - https://user-agents.net/browsers/klondike

Coverage remained the same at 100.0% when pulling f0718a25f8eacbe96ca551799e75164c03a6115a on ayumi-cloud:Klondike into 4899110cd2f87b01e04ced62dbb9dec541031dee on WhichBrowser:master.


Offline support

If we can't fetch refs because we're offline, it should still be possible to use a cached archive. Right now they're only stored by commit hash which is unhelpful — we could store some metadata alongside the tar files, indicating that (for example) 1234abcd is the latest master.

At the risk of plugging shamefully (😅) my recent Gittar can solve this issue, along with #1 and #3.
The module does not ship with a CLI, so there's no overlap in that regard.
A few key differences:

All archives will live in ~/.gittar, and cannot be configured.

it doesn't lookup or store archives according to the releases' full refs. IMO, this a bit overkill (at least in my use cases), since I'm far more likely to download specific tags or branches.

The master branch is always refetched, if online. Otherwise it will revert to the last master.tar.gz file it cached. Since that's probably the only scenario for caring about the more-recent commits, Gittar fetches anew by default.

And with the included tar package, it's fairly easy to decide how/when to keep/trash/compare metadata. Any options to gittar.extract are passed directly to tar.extract, so all the magic happens there. This inches towards a solution for #9.
Let me know what you think. Happy to start working on integrating this into a PR if you'd like. No hard feelings if you don't want to go this route. 😃

Nice 👏 Since gittar would be doing most of the heavy lifting, what if we just merged these projects? In other words, have the CLI and the library in the same repo. If you reckon that's a good idea, then I could send you a PR to add a gittar CLI?
It occurs to me that master might not be quite such a special case — you could imagine a project template that had different branches that were maintained in parallel (e.g. a React project template that had a preact branch). So I'd advocate for always going network-first, whether that means redownloading or just checking to see if the hash for a given ref has changed — though I realise that adds a decent amount of complexity and isn't something we'd need to solve straight away.
Let me know what you think!

Hey @Rich-Harris, thanks!
I want to keep the API separate from the CLI -- I kinda like that approach. Even tho mri is super lightweight (I should know 😜), having the API separate enforces a build-for-reuse as opposed to building with a complete project in mind, y'know?
I totally understand that branch example. That's why I made sure to add a force:true option for the fetch.
Originally, I wanted to decipher between a semver-tag & a branch-tag, but in the real world (unfortunately) not everyone is using semver, or necessarily even marks releases with a numerical system. Doing this would allow all semver(-like) tags to be cache-first & the rest (master, preact, feature-foo) be network first.

The more I think about it, the more I think we have slightly different goals. You want offline-first, I want network-first, but I don't want to redownload tar files that I already have (so force: true doesn't really help). So maybe it's better we keep these projects separate after all.

Okay! No problem 😃
While I do prioritize offline-first, I still want to be flexible.
Would it help if I added an ~onParse option that decided whether or not to send a network request?
The default would return true for master branches:
opts.onParse = ({ site, repo, branch }) => branch === 'master';

if (opts.force || opts.onParse(info)) {
  // send network
} else { ... }

It wouldn't quite solve the problem of only wanting to download if the commit hash had changed for a given ref. In my testing, fetching refs is usually quite a bit quicker than redownloading (though obviously it depends on the size of the repo).

Gotcha. Well if you have any suggestions, feel free to send 'em my way. This was borne out of what I needed, but I'd like it to be flexible for others too.
Thanks!


Documentation

Finish readme and create any wiki pages needed to explain use cases.

Process for obtaining Google API credentials.json and authorizing the application


Do not write data when executing VERIFY10/VERIFY16 (#807)

Successfully tested with an Atari TT:
[2023-10-16 20:46:09.026] [debug] (ID 1) - Controller is executing Write6/Print/SendMessage10, CDB $0a03ebf60400
[2023-10-16 20:46:09.026] [debug] (ID:LUN 1:0) - Device is executing Write6/Print/SendMessage10 ($0a)
[2023-10-16 20:46:09.032] [debug] (ID 1) - Controller is executing Verify10, CDB $2f020003ebf600000400
[2023-10-16 20:46:09.032] [debug] (ID:LUN 1:0) - Device is executing Verify10 ($


The CurlMultiHandle causes a busy immediately when the first byte is received

I've provided a patch to the CurlMultiHandler which leverages the event loop. This allows TaskQueue implementations to properly sleep between each invocation of the \curl_multi_exec, and added a curl_multi_select() statement inside the busy wait loop that is meant to "wrap up" things.

I'm not sure what I can do with the PHPStan tests. They seem to be unrelated to my patch.

It's probably because you ran composer and phpstan with a different version of PHP. You'd need to use our Makefile. e.g. make static-psalm-update-baseline.

I made the commit to the 7.8 branch. Should I also make it for the 7.9 and 8.0?

I'm still aware of of this PR, and appreciate the time you took to prepare this. I'm hoping to get to this soon, so this can be included in the next release(s).


Add VWAN deployment capability

Overview/Summary
This PR adds VWAN deployment capability to the module, and updates the test framework to provide coverage for this.
Documentation is to follow, and there are a few areas which will be updated before the next release for both VWAN and H&S network topologies (e.g. adding support for firewall policy creation).

Update to the What's New page in the ES wiki will be added upon release, not specifically for this PR

This PR fixes/adds/changes/removes

Add resources for VWAN connectivity option to fix #226
Update test framework to include VWAN resources and implement the configuration in stages to better reflect a typical user journey for deploying and updating configuration settings
Partial coverage for #227
Update minimum supported version to fix #271
Fix for #272
Fix for #273

Breaking Changes

Change to minimum supported provider version may require customers to update their code and run terraform init -upgrade

Testing Evidence
to follow
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.
[x] Updated the "What's New?" wiki page (located in the Enterprise-Scale repo in the directory: /docs/wiki/whats-new.md)

/azp run unit

/azp run unit

Looks great! Only comment is can we split locals.connectivity into smaller files to make reading easier? @krowlandson

Looks great! Only comment is can we split locals.connectivity into smaller files to make reading easier? @krowlandson Kevin Rowlandson FTE

Do we need this now, or tackle as part of adding in all the extra logic to further remove tr() functions as per #227?

/azp run unit

@krowlandson Do you have any documentation or example for Virtual Hub deployment? Or is it placeholder only for future use?


Data Resource JSON schema definition for schema seems to contradict specification

Overview
Caution: there's a lot of different uses of "schema" coming, so bear with me...
in src/main/resources/, we find the JSON schema definition files for the various parts of a DataPackage. Among them is data-resource.json, where the formal definition for a schema property of a Resource is:
"schema": {
  "propertyOrder": 40,
  "title": "Schema",
  "description": "A schema for this resource.",
  "type": "object"
},

This allows only JSON-objects as schema definitions, essentially JSON-Strings. It disallows URLs or file paths.
This seemingly contradicts the specification of a schema property:

The value for the schema property on a resource MUST be an object representing the schema OR a string that identifies the location of the schema.

(Emphasis mine).
I believe it should read (not sure about the syntax):
"oneOf": [
    {
      "title": "Schema path",
      "description": "A fully qualified URL, or a POSIX file path..",
      "type": "string"
    },
    {
      "title": "Schema encoded as JSON",
      "type": "object"
    }
]

Please preserve this line to notify @georgeslabreche (lead of this repository)

Also @roll - that problem isn't specific to the Java implementation, it exists in the spec repository: https://frictionlessdata.io/schemas/data-resource.json as well. I'll file a bug against that, and we can close this one

https://github.com/frictionlessdata/specs/issues/645


[FEATURE]: Add support for access logs

It would be nice to enable logging of any successful TCP/UDP connection to be able to spot unusual activity or IPs accessing layer4 servers.

Oh, I discovered a way to log layer4 based on a previous answer in an issue: https://github.com/mholt/caddy-l4/issues/22#issuecomment-853497430
I've added this to my caddy config:
  logs:
    layer4access:
      level: DEBUG
      include:
        - layer4
      writer:
        output: stdout

Should I close the issue? Or is there a better way to enable access logging?

I'm pretty sure they are written by default. :thinking: I guess you have a non-default logger configured there; did you need more than the default logger?

Yes, I am modifying the logging configuration. My goal is to set up a basic "access log" configuration to capture logs for both HTTP and Layer 4 connections.
Here is my configuration file:
---
apps:
  tls: ...
  layer4:
    <some-layer4-servers>
  http:
    service1:
      listen:
        - ":<port>"
      logs:
        default_logger_name: default
      routes:
        - handle:
            - handler: reverse_proxy
              upstreams:
                - dial: "<hostname1>:<port>"
          match:
            - host:
                - "<domain-name>"
    service2:
      listen:
        - ":<port>"
      logs:
        default_logger_name: default
      routes:
        - handle:
            - handler: reverse_proxy
              upstreams:
                - dial: "<hostname2>:<port>"
          match:
            - host:
                - "<domain-name>"

logging:
  logs:
    default:
      level: INFO
      include:
        - http
      writer:
        output: stdout
      encoder:
        format: filter
        wrap:
          format: json
        fields:
          "request>headers":
            filter: delete
          "resp_headers":
            filter: delete
          "request>uri":
            filter: query
            actions:
              - parameter: "access_token"
                type: delete
    layer4access:
      level: DEBUG
      include:
        - layer4
      writer:
        output: stdout

The key section is the logging configuration. I aim to log all HTTP servers by creating a default logger in the logging section of the Caddy config file, and specifying this in each HTTP server:
logs:
  default_logger_name: default

This works perfectly for HTTP servers. However, I am not seeing logs for TCP connections in the Layer 4 section.
Note that I am using filters in the default logger to exclude sensitive information from the logs. This should not affect the overall logging configuration.
I am considering removing the layer4access logger to see if Layer 4 logs appear, I will try and reply you back.
Thanks for your quick response :D

That looks right, then. If you want two separate loggers that selectively include this or that, then that's the basic idea. Looks good :)


The implementation is really unsound, because of incorrect assumptions.

First of all, I would like to thank Jon very much for his fantastic YouTube channel which allowed me to very quickly learn programming in Rust. This project, in particular, is the perfect kind of project for me in learning a programming language: Tackle a practical challenging problem, and optimize the code as much as possible.
Unfortunately, Jon became focused on optimizing his code without verifying that his logic is sound. The program becomes faster and faster and more and more wrong. First, he didn't realize that he forced his solver to only work in hard mode (every guess has to be a candidate of the right answer based on the correctness patterns received). Second, memoization can only be done for the specific history of guesses and the corresponding received correctness patterns since the first guess, but he thought that he could localize it. And from there it spiraled all the way down that it became impossible for me to track his reasoning throughout his live-coding video.
So, I decided to re-do roget from the bottom up, following only the mathematically sound ideas and the good programming patterns. It was first intended to be just a private project to learn Rust, but I decided to publish it on GitHub. You can find it here. It can be regarded as a fork of an early version of roget, but I typed it from scratch while following Jon's recorded video, making my own adjustments here and there.
Ironically for Jon, he missed an opportunity to gain a quadratic speedup by decoupling the for loop iterating through guess candidates and the for loop iterating through correctness patterns, observing that every guess-answer pair corresponds to exactly one correctness pattern. This dramatic improvement is wholly sound and doesn't change the guessing behavior at all. You can check out the implementation of this in rogerthat.

Hi there! Glad you enjoyed the beginning of the video at least :)
To be clear, many of the issues you point out have already been pointed out and fixes since in various issues and PRs on this repo, and the solver is now way faster. Definitely true that this is an indicator of just how careful one has to be while pursuing optimizations!

Thanks for your quick response! No worries, I still watched the video until the end to see the workflow of a professional Rust programmer, including how you use profiling tools to analyze performance (and what lessons I could take from the shortcomings as well 😋). And I enjoy all of your Crust of Rust series, getting into the nitty-gritty of how Rust works! Those are YouTube gems! 😄
Despite of what you said, however, I would like to believe that I have done my due diligence to read the repo as it stands today and to track all the development throughout all the commits and the PRs. It seems to me that many of the problematic aspects still haven't been mitigated (except normal mode, being introduced so late when the state of the algorithm had already become so unsound), and the quadratic speedup I've mentioned hasn't been implemented. (Correction: Turns out it has been introduced by cjcormier since this PR. My bad...) Otherwise, I would've decided to just build on top of what's currently there and contributed to this repo instead of creating my own.
Roget is currently way faster indeed than the current state of rogerthat. The problem is on whether it's sound. I've tried and will continue to pull ideas from roget to make every bit of performance improvement possible on my implementation. It just so happens that so many of them turn out to be unsound, so I can't use them. (Much of the contribution from other people just built on top of what's already there, assuming that everything's good so far.)
But perhaps it would be better for everyone if I discuss each of those particular problems in separate issues/comments, so that I can go into detail on the specific portions.
As a postscript, to be careful in making improvements to a Wordle solver, one has to carefully track its change of behavior (i.e. what guesses it makes, not how quickly it makes them). Sophisticated test cases and hands-on analysis is required. Overall statistics can be deceiving, in that adding a bunch of clever heuristics and even cheating by overfitting parameters on the answers set will typically only reduce the average number of guesses like from 3.7 to 3.6 (that's a lesson I learned from 3blue1brown).


Fix disabled azdata tests

Pull Request Test Coverage Report for Build 278807009

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 38.195%

Totals

Change from base Build 277700785:
0.1%

Covered Lines:
19218

Relevant Lines:
45904

💛  - Coveralls


Timeline tracks overflow for long names and star button

Quoting feedback from @loic-sharma:

Tracks with long names do not overflow well:

The Pin to top star button overflows as well:

Original feedback from https://gist.github.com/loic-sharma/264ab999642a617f8e4490e4812ea411, which provides feedback of the embedded Perfetto trace viewer in Flutter DevTools. Some items are specific to Flutter DevTools, and some are for Perfetto proper.

Thanks for reporting this! My bad, however @stevegolton fixed this recently: https://android-review.git.corp.google.com/c/platform/external/perfetto/+/2514457 Should be live on autopush other channels following soon.


Fix depwarn on 0.5

Yes, and fixed in https://github.com/JuliaLang/IJulia.jl/commit/fcbcef24d2b022464092c1d0f99555edc27973a0


BrokenPipeError: [Errno 32] Broken pipe

I'd like to know why this error heppen when I use it in scrapy pipiline.
here is the code
def async_produce_wrapper(producer, logger):
    count = 0

    def wrapper(func):

        def inner(*args, **kwargs):
            result = func(*args, **kwargs)
            nonlocal count
            count += 1
            if count % 10 == 0:  # adjust this or bring lots of RAM ;)
                while True:
                    try:
                        msg, exc = producer.get_delivery_report(block=False)
                        if exc is not None:
                            logger.error('Failed to deliver msg {}: {}'.format(
                                msg.partition_key, repr(exc)))
                        else:
                            logger.info('Successfully delivered msg {}'.format(
                                msg.partition_key))
                    except Empty:
                        break
            return result
        return inner
    return wrapper

kafka = KafkaClient("<IP_ADDRESS>:9092,<IP_ADDRESS>:9092,<IP_ADDRESS>:9092")
producer = kafka.topics[b"jay_firehose_ingress"].get_producer(delivery_reports=True)
producer.produce = async_produce_wrapper(producer, logger)(producer.produce)
.......
.......
.......
producer.produce(message.encode("utf-8"))

here is the error
b'error heppend in pipline Traceback (most recent call last):'
b' File "/app/crawling/pipelines.py", line 76, in process_item'
b' self.producer.produce(message.encode("utf-8"))'
b' File "/app/crawling/spiders/utils.py", line 47, in inner'
b' result = func(*args, **kwargs)'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/producer.py", line 350, in produce'
b' self._raise_worker_exceptions()'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/producer.py", line 204, in _raise_worker_exceptions'
b' raise ex'
[above repeats >100 times]
b' File "/usr/local/lib/python3.6/site-packages/pykafka/producer.py", line 541, in queue_reader'
b' self.producer._send_request(batch, self)'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/producer.py", line 421, in _send_request'
b' response = owned_broker.broker.produce_messages(req)'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/broker.py", line 296, in produce_messages'
b' return future.get(ProduceResponse)'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/handlers.py", line 70, in get'
b' raise self.error'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/handlers.py", line 205, in worker'
b' shared.connection.request(task.request)'
b' File "/usr/local/lib/python3.6/site-packages/pykafka/connection.py", line 198, in request'
b' self._socket.sendall(bytes_)'
b'BrokenPipeError: [Errno 32] Broken pipe'

I wonder why the error message is so long and repeat many times,
I start 30 docker container to run this code.
how to avoid this error?
my English is pool, I hope you can know my meaning. thanks.
PyKafka version: 2.5.0
Kafka version: <IP_ADDRESS>

@ShichaoMa Thanks for filing this! I'm guessing that the reason the error message is repeating so many times has something to do with the environment under which you're running this code, so it's difficult to comment on without having more context. As for the error itself, this appears very similar to an error the connection code is already aware of. We might want to handle BrokenPipeError here as well.

I guess the count of docker container/kafka connection may cause this error. When I reduce the docker container count from 30 to 15, error missed. But still can't find the reason.


scoped routes: Derive keys from dynamic request metadata

Extend the route scope key builder to consider filter metadata
Currently the scope_key_builder's fragments only support extracting values from headers. For use-cases in multi-tenant meshes where the tenants have no idea about the route scope abstraction, this is not enough.
I'd like to extend this to also include the dynamic request metadata propagated through the filter chain. If my understanding is correct, it would allow for more advanced tenant derivation in the filter chain without needing tenants to identify themselves via headers.
If this is a welcome change, I'm happy to submit the patch shortly.
Relevant Links

https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/http/http_routing.html?#route-scope

/assign tonya11en

cc @htuch

Sure, this makes sense.

this is still in review


I want to disable forms on a elementor form

saturday & sunday option is not disabling. I have tried in different ways.
https://cottontailsdaynursery.com/book-your-tour/
Please help

duplicate of #730 and also has docs disabling-dates-by-a-function


Fix code scanning alert - Token-Permissions

Tracking issue for:

[ ] https://github.com/pfichtner/SipDoorbell/security/code-scanning/14

Fixed


Add Test Case - improvements to CTE feature

Describe your changes
Add test case to cover --save and --with query usage
Per this request
Issue ticket number and link
Closes #87
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added thorough tests (when necessary).
[ ] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--238.org.readthedocs.build/en/238/

we need to update the test, it should be three queries. the second one should use the first one and the third one should use the second one. but we need to test that the third one only needs to pass --with second and figure out that it also needs the first one (even if not explicitly passed)

Updated test case in f42f4ae

Add third query

To construct the third query, we only need to provide --with second is enough


update npm

Would appreciate a new release plus update to npm. Missing loads of useful stuff. E.g. offset

offset is a function that is not yet requested in issues, perhaps open one if you would like the feature?

Seems to be added 18 days ago? https://github.com/kenwheeler/cash/blob/3cb498ca7c5776b8cadcce5884f18e93a61931a9/src/offset.js#L13 ?

Version 1.1.0 was merged with PR#70, with lots of fixes.
1.1.0 is not released on npm and as there is no version tag or release on github, that version is also not on bower, although package.json and bower.json are bumped to 1.1.0.
I've used the pr version before and since more than two weeks the github master version. Using a properly released version as dependency would be nice...
Are there any issues, why this should not be released yet?
Or do you need help setting up ci? (travis.yml is empty since two years)

Because I'm the worst

Seriously though, I need to get CI set up and find some time to give it the hand test prior to a release. I've been traveling the last month, and have had launches hitting, so I've haven't gotten to it.

Quick fix for this issue would be just adding a version tag for bower and do an npm publish in your local project folder.
This should be possible in a few minutes. Then you can go on travelling and setup ci for the next version...

It looks like @kenwheeler did get the NPM entry updated: https://www.npmjs.com/package/cash-dom


Can't login in docker when test-kitchen is executed from docker container

Hi,
We have a Jenkins master running in docker. When a job is started, a jenkins-slave docker container is started and executes everything related in this job in this specific jenkins-slave container.
When running the kitchen converge step, it will create and boot a new docker container, but it can't login:
       Waiting for SSH service on localhost:32844, retrying in 3 seconds
       Waiting for SSH service on localhost:32844, retrying in 3 seconds
       Waiting for SSH service on localhost:32844, retrying in 3 seconds
$$$$$$ [SSH] connection failed, terminating (#<Errno::ECONNREFUSED: Connection refused - connect(2) for <IP_ADDRESS>:32844>)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
[Pipeline] mail
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: script returned exit code 20
Finished: FAILURE

I can see that the docker container is started and I can manually from my host login into the container. But It won't work from this jenkins-slave.
This is my .kitchen.yml file:
driver:
  name: docker

provisioner:
  name: ansible_playbook
  ansible_yum_repo: "https://dl.fedoraproject.org/pub/epel/7/x86_64/e/epel-release-7-6.noarch.rpm"
  hosts: localhost
  require_chef_for_busser: false
  require_ruby_for_busser: true

platforms:
  - name: centos-7.2
    driver_config:
      privileged: true
      provision_command:
        - /usr/bin/systemctl enable sshd
      run_command: /usr/sbin/init

verifier:
  ruby_bindir: '/usr/bin'

suites:
  - name: default

Versions:
test-kitchen: 1.9.0
kitchen-docker: 2.4.0
kitchen-ansible: 0.43.1
Any suggestions where I should look at to make this work? Or do you need some more information?

You would probably have to make sure whatever networking model is being used will work with the expectations of the driver. The driver tries to SSH to $DOCKER_IP:$MAPPED_PORT where the DOCKER_IP is probably localhost in this case. The mapped port would only be valid on the hypervisor though. In this case you probably want to skip the port mapping and talk directly to the container's IP, but there is not currently any code for that.

Why not to make it simple as in proposed https://github.com/test-kitchen/kitchen-docker/pull/203 ?

@ytsarev The issue with that approach is the IP of the hypervisor needs to be fixed or you're going to have a hellacious kitchen config.

@coderanger not sure if I understood you correctly but in my case it's not IP of the hypervisor as it is but more or less standard IP of docker0 bridge. Which is pretty generic.

@ytsarev That very much depends on the kind of networking model you are using. If a static, hardwired address works for you then that's cool, but I wouldn't advertise it as a generic solution.

@coderanger I agree, but at least the bridge model is default

Running into this same issue myself. Last post on this thread is pretty old. Anyone found any good solutions to this problem?

I would highly recommend using kitchen-dokken if possible to people in this situation. It doesn't use SSH so it doesn't have as many issues with networking management.

@coderanger thank you for the recommendation. Project looks interesting. However, looks pretty Chef specific. I'm using kitchen-docker with the kitchen-ansible provisioner. My first impressions make me think I can't do the same with kitchen-dokken.

Yeah, dokken is Chef-only at this time.

@coderanger to @ytsarev's point I could probably make this work if I could change the host and/or port used when making the SSH connection.

Hello 👋
I was having this issue too so I made this PR - https://github.com/test-kitchen/kitchen-docker/pull/283


change incorrect connStr to correct DB_URL env var

I'm pretty sure the connStr used in the code snippet is wrong and that it should be env.DB_URL instead
It was changed to connStr in https://github.com/cloudflare/cloudflare-docs/pull/16438 so maybe can @thomasgauvin can let me know if this was a mistake or intentional 🙂

Thanks @dario-piotrowicz, approved

Awesome! thanks a lot 🙂👍


Add note to specify only AMD64 compatibility for example image

#39798

/retitle Add note to specify only AMD64 compatibility for example image

@haripriya9647 Sometimes, we encounter Netlify build failures caused by timeouts. Can you attempt to trigger the build once more by executing the command: git commit --amend --no-edit && git push --force-with-lease

@haripriya9647 please addressed the above comment, to pass all the failed test cases.

Page preview:
https://deploy-preview-44241--kubernetes-io-main-staging.netlify.app/docs/tutorials/services/source-ip/

Informal LGTM from https://github.com/kubernetes/website/pull/44241#pullrequestreview-1797743269
/lgtm
/approve


Gene-function operation does not work for HGNC IDs

A query (slimmer bio link query) using the HGNC:1110 id will retrieve the mouse ortholog information, but nothing for human. Conversely however, for the same gene UniProtKB:P38398, the query will return information for both human and mouse (as expected). In a sense it 'works' but not if data goes missing depending on what id is used. I have a feeling this is a general issue and will require testing with numerous permutations.

Withdrawn: http://www.genenames.org/cgi-bin/gene_symbol_report?q=data/hgnc_data.php&hgnc_id=1110
However, still fails for valid IDs such as HGNC:6081

This is the problem: https://github.com/SciGraph/SciGraph/issues/135
We can implement a workaround


Rework check tests to join built+supported backends vs. hardcoding to specific backends.

The way check tests are defined in cmake/bazel needs to change to better enable out-of-tree backends - but also it's pretty unwieldy today even for in-tree backends. Which backends a check test runs on is defined by what backends are built joined with an optional (and hopefully small) exclude list that is managed per backend (vs per test).
This allows in-tree backend tests to be more uniform and have less boilerplate and out-of-tree backend tests to be possible (where we otherwise would have to reference them in the in-tree build files and configuration).
We can also use this opportunity to clean up the names - the current style is very annoying in IDEs/tooling as the test target name is not easily inferable from the test file.
Concretely, this may mean something of the form of #4643 where the in-tree tests are just filegroups/exported test files and then the actual test rules are instantiated per target (iree/test/e2e/tosa_ops/vulkan/...) - meaning that out-of-tree/experimental backends can also instantiate them (experimental/cuda/test/e2e/tosa_ops/cuda/... or experimental/cuda/test/... in a single file, etc). Just as with #4643 we should be able to cmake install the test files and stamp out a new instantiation of them out-of-tree.

I drafted what a test suite could look like in Bazel here: https://gist.github.com/ScottTodd/8379663fd2cbd1ea8a973b88c2a32a92 (before I noticed/remembered this issue). The next thing I was thinking was how to map that to CMake, and having a "registration" function like iree_compiler_register_plugin could be a good fit (declare each test suite then attach configurations to them).

Could we generate check tests from other test suites, like JAX / StableHLO and PyTorch? I'd like to improve coverage (frameworks and platforms) as well as ergonomics here, but without that it feels like any work would be in service of one or the other.
As more targets like ROCm and AMD-AIE come online, this feels like it would be especially useful.

For out of tree projects that define compiler plugins providing new target backends, it would be great to leverage the existing check test suites in some way. I spent a bit of time looking at how that could look for https://github.com/nod-ai/iree-amd-aie, and these checks are overly restrictive: https://github.com/openxla/iree/blob/eaefd3ff964f14e700b1c468aa2b4f20a4401028/build_tools/cmake/iree_check_test.cmake#L97-L103
I had two ideas for this:

Expand on the filtering by letting iree_compiler_register_plugin() specify a list of compiler target backends the registered plugin includes (and similarly which input types it can convert)
Simplify the filtering in the rule and instead filter at the directory/caller level. This would require reworking files like https://github.com/openxla/iree/blob/main/tests/e2e/stablehlo_ops/CMakeLists.txt. The files in the project already use iree_check_single_backend_test_suite extensively (and iree_check_test_suite is never used... maybe I should drop it from https://github.com/openxla/iree/pull/16225). This could also be complimentary to some of the other test suite refactoring ideas I've had.

I think 2 is the better option.
As the CMake logic changes, it may also help to just drop Bazel support for these test suites.


Unable to download certain anime

Hi,
I had a quick search of the issues that were open and resolved but couldn't see anything there.
Some of the Crunchyroll links work fine (Haikyuu) while others don't (Yu-Gi-Oh! 5'Ds)
I am running this command cr-dl download -c 5 -l enUS https://www.crunchyroll.com/yu-gi-oh-5ds --seasons 3,4
and getting the following error
      throw er; // Unhandled 'error' event
      ^

Error: ENOENT: no such file or directory, open 'tmp/VodVidData/seg-32-v1-a1.ts'
Emitted 'error' event at:
    at errorOrDestroy (internal/streams/destroy.js:107:12)
    at WriteStream.onerror (_stream_readable.js:737:7)
    at WriteStream.emit (events.js:200:13)
    at internal/fs/streams.js:289:12
    at FSReqCallback.oncomplete (fs.js:153:23) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'tmp/VodVidData/seg-32-v1-a1.ts'
}```

Not sure what the error is as I don't know nodejs

Looks like just a Blip. Seems to be working fine now..


Split op SVO struct files

To make a clear distinction between code that should and that should not be added after (initial) generation, a split-up of all SVO's should be done.
This should also help in showing people where "the magic is happening".

By doing this I (more or less by change ;)) fixed #84 ,


Mod Crashes During Birth Event

I tried this out. I was looking for a mod that would allow me to have more than 2 kids with my 4 spouses. When I enter the commands into SMAPI, it seems to work just fine. I was asked by one of my spouses if I wanted to have a baby the following night. I did however get weird warnings in SMAPI whenever the game booted up. This did not affect my gameplay or save file at all.
Here is my smapi log: https://smapi.io/log/693d8096f87b40068a9399dba9667809
Thanks!
Update: After being asked by spouse if I wanted to have a baby, the birth event triggered 14 days later. The baby name/gender select screen was pretty messed up though. I took a screenshot. After I entered the name and clicked enter, the mod caused my game to crash. Luckily, there was no damage done to the save file. I tested it one more time and it crashed after I named the baby and save. Seems like this is as far as the mod can run before crashing.
Workaround: since the mod crashes, I removed it, but I was happy to find that the birth event will still take place even with the mod removed (guess because the player is still pregnant). So there is still the benefit of the mod allowing the player to have more than 2 kids from different spouses, even if it must be removed after asking the baby question.
Here is my smapi log: https://smapi.io/log/2d4a79d3cc0a49c68f69e8983f1ecc5a

I'll look into this. The source isn't mine; it could be taking some time.

Should work better now. Feel free to try it out. Version 2.0.1 is out for download.

Thanks! Trying it now. Will you be uploading this to nexus mods when it is complete?

Maybe, but I have to handle the support. Why wouldn't you upload this to Nexus?


merge from template-coveralls

package.json

chore(deps): add ^17.4.5 remove ^17.4.4 (devDependencies.semantic-release)

:tada: This PR is included in version 4.2.35 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v4.2.35

Your semantic-release bot :package::rocket:


About Page Mobile Responsiveness

WHAT DOES THIS PR DO?

Fixes some padding and font-size issues on the About Page so it displays nicely on mobile screens.

Run the project locally
cd web then npm run dev
Go to http://localhost:5173/ in your web browser
Navigate to About Page and then inspect the page
Toggle the device toolbar and switch to iPhone 12 Pro dimensions
Updated About Page should appear

The changes look great so far...

I have fixed the bug related to dark mode on a rotated mobile screen, thanks for catching it.


DO NOT MERGE: testing ci

Just to test that ci works as expected. Errors expected.

CI seems to work as expected, closing.


[fix] [broker] fix typo and useless local variable.

Motivation
fix typo and useless local variable.
Modifications
fix typo and useless local variable.
Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

PTAL, thanks. @lhotari @Technoboy- @dao-jun

/pulsarbot rerun-failure-checks

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.20%. Comparing base (bbc6224) to head (82f7eae).
Report is 265 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #22704      +/-   ##
============================================
- Coverage     73.57%   73.20%   -0.38%
- Complexity    32624    32858     +234
============================================
  Files          1877     1889      +12
  Lines        139502   141392    +1890
  Branches      15299    15516     +217
============================================
+ Hits         102638   103502     +864
- Misses        28908    29909    +1001
- Partials       7956     7981      +25

Flag
Coverage Δ

inttests
27.46% <ø> (+2.87%)
:arrow_up:

systests
24.75% <ø> (+0.43%)
:arrow_up:

unittests
72.22% <ø> (-0.63%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../persistent/ReplicatedSubscriptionsController.java
70.14% <ø> (-2.45%)
:arrow_down:

... and 357 files with indirect coverage changes


Person fields optimisation of possible

Thanks for the templating improvements they have made a big difference.
This may be a long shot but the person fields (actor, director) are being brought in as:  FirstName Surname
In my vault I have people set as [[Surname, Firstname|@FirstName Surname]] I am currently editing each name once they are imported.
Is there anyway I can alter ["{ Actors }":null}]|  to bring the names in like this? When I was using readwise for books someone showed me some code to put in to change how the names appeared to match my method. Unfortunately I no longer use Readwise so don't have access to the template to see how this was done.
Thanks

I just published 1.1.14, wich introduces Regex Transfomations. You can read on how they work in the readme, but if you want to use them as you described above you can use the template tag:
{{Actors|"[[|]]"|<$\w+$$>, <$^\w+$>\|@<$^\w+$> <$\w+$$>}}

The Regex Transformation doesn't work for me.
I used the regex you provided:
{{Actors|"[[|]]"|<$\w+$$>, <$^\w+$>\|@<$^\w+$> <$\w+$$>}}

but I get this:
"[[John Cusack]]", "[[Thandiwe Newton]]", "[[Chiwetel Ejiofor]]"

I also tried to transform the Actors list using the Regex Transformation into this format:
actors:
  - "[[John Cusack]]"
  - "[[Thandiwe Newton]]"
  - "[[Chiwetel Ejiofor]]"

but it obviously didn't work either.
I would appreciate any help.

Are you sure you are using the newest Version? the regex Transform works for me. also make sure to Wrap the expression inside a list [].

Tnx for the quick answer.
I had updated the plugin using the Obsidian's standard procedure. After I read your post, I did it again just to be sure, yet Obsidian was showing I have the latest version of the plugin 1.1.13
I checked the git repo, and noticed there is 1.1.16 version. After I manually updated to that version the regex transform works.
I still can't manage to get the actors in a valid Obsidian list property format, though.
The proper list formatting would be as follow:
actors:
  - "[[John Cusack]]"
  - "[[Thandiwe Newton]]"
  - "[[Chiwetel Ejiofor]]"

Can you please help?

Oh i see, i will look into why obsidian does not show the newest Version. You can use the transform i showed before, you just need to add a list modifier (square brackets) around it. So having
[{{Actors|"[[|]]"|<$\w+$$>, <$^\w+$>\|@<$^\w+$> <$\w+$$>}}]

should work.
Sadly i dont think it is currently possible to include linebreaks so a list modifier like you proposed might not be possible.

here is the template I ended up using. It requires Templater & Moviegrabber plugins;
---
title: "{{Title}} ({{Year}})"
year: {{Year}}
aliases: {{Title|"|"}}
rating:
<%*
let genreMatch = "{{Genre}}";

if (genreMatch && genreMatch.length > 1) {
    let genreArray = genreMatch.split(', ');

    let markdownGenre = genreArray.map(genre => `  - "[[${genre}]]"`).join('\n');

    tR += `genre:\n${markdownGenre}`;
} else {
    tR += 'genre: \n  - "Genre not found or invalid format"';
}
%>
tags:
  - entertainment/movie
  - entertainment/movie/to-watch
  - entertainment/movie/watched
country: {{Country}}
<%*
let directorMatch = "{{Director}}";

if (directorMatch && directorMatch.length > 1) {
    let directorArray = directorMatch.split(', ');

    let markdownDirector = directorArray.map(director => `  - "[[${director}]]"`).join('\n');

    tR += `director:\n${markdownDirector}`;
} else {
    tR += 'director: \n  - "Actors not found or invalid format"';
}
%>
<%*
// Capture the actors string; assumes the line starts with 'actors: ' and the actors are enclosed in double quotes.
let actorsMatch = "{{Actors}}";

if (actorsMatch && actorsMatch.length > 1) {
    // Split the captured string by '", "' to get an array of actor names.
    let actorsArray = actorsMatch.split(', ');

    // Map each actor name into a markdown list item, maintaining the double brackets.
    let markdownActors = actorsArray.map(actor => `  - "[[${actor}]]"`).join('\n');

    // Output the markdown list of actors.
    tR += `actors:\n${markdownActors}`;
} else {
    // If the actors string wasn't found, output an error or a placeholder.
    tR += 'actors: \n  - "Actors not found or invalid format"';
}
%>
length: {{Runtime}}
status:
  - watched
  - did not finish
  - currently watching
  - to watch
type:
  - Movie
related:
created: <% tp.date.now("YYYY-MM-DD") %>T<% tp.date.now("HH:mm:ss") %>
updated: <% tp.date.now("YYYY-MM-DD") %>T<% tp.date.now("HH:mm:ss") %>
---
# {{Title}} ({{Year}})
![{{Title}}|300]({{Poster}})

{{Plot}}

Nice, thanks for sharing.
Btw, because there might have been sone confusion, the properties also accept lists in the format property: [item1, item2, item3] so to just get a list of actors or genres you could do:
actors: [{{Actors|"[[|]]"}}]


feature: Improve the visibility/ readability

Is your feature request related to a problem? Please describe.
I found some places where readability can be improved.

Describe the solution you'd like
We should try avoiding these kinds of color combinations, where the contrast between foreground and background is very less, or change the foreground to black or white accordingly.
Describe alternatives you've considered
None
Additional context
You can find the above images in tags for questions at https://app.100xdevs.com/question

Would like to work on this issue, I plan to create tag colours both for dark and light modes and add the swap, as this issue occurs only on light mode and requires clarity on a few things,

Do we use a fixed number of colours and reuse them if tags exceed
Ideally tag colors should indicate something so would it be better if we use the same color for all tags as the colors are randomly assigned

Hello, @sitanshu05 I was wondering If you're still working on this?
If not please let me know and can this be assigned to me in that case @devsargam

Hello, @sitanshu05 I was wondering If you're still working on this? If not please let me know and can this be assigned to me in that case @devsargam

Yes I am working on it

Is this okay? the tags look much cleaner and go well with the theme of the site


extraStyling warnings in dev tools

We're getting an error in devtools:
Warning: React does not recognize the extraStylingprop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercaseextrastyling instead.
We're passing in this styling to the TextButton component. Maybe we can avoid this by using separate CSS classes.

Most of the text Buttons are replaced on the dashboard with Material UI. So upon completion of other PRs, I'll revisit this and check for it.

The following issue has been addressed in

[ ] #30
The variable declaration is changed from camelcase to lowercase


pikvm assembly-and-validation.md: modify

@johanes2115 Please install and use pre-commit: https://github.com/Dasharo/docs/#pre-commit-hooks
See the pre-commit failure here:  https://results.pre-commit.ci/run/github/316342881/1688028701.EdUltGlMRVWga2ivWYdhqA
Assigning reviewers with such basic failures is not acceptable, as it wastes time of all of us by discussing and resolving issues, which could have been resolved automatically.

@macpijan pre-commit complains on lines not touched by this PR, so someone messed up earlier as well


feat: DT-466 Make some tags appear on all spans

DT-466
Updates the go-outreach trace logic with a presendHook to add certain
service-level tags to every outgoing span.  For now, these include the
app.Info tags and the dev.email tag.  I expect more will be added in
the future.
These extra tags help to enrich the "leaf" spans of the trace, making
large "GROUP BY"-style queries more practical.  We use this all the time
in the flagship, for example summing DB time by rails.controller.
This gets us started towards doing the same for Go services.
Honeycomb charges us by the even (ie. span) not by the size of those
spans, so these extra tags are effectively free.

Forward-porting from https://github.com/getoutreach/go-outreach/pull/169/commits.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Craft 5 compatibility

Noticed this isn't showing on the C5 plugin store yet, and C5 is due out by the end of the month. Is this being updated for C5?

Thanks for asking!
No, we won't be porting the Inventory plugin to Craft 5, because it is no longer necessary. Pretty much everything that Inventory was doing will now be handled directly in the Craft 5 native field UX.
We actually add this message to the README just yesterday...

Ah, thanks for that quick update. Sorry I missed that.
Inventory has been great for Craft 4 - thank you!

Reopening, to serve as the official notification that Inventory will not be ported to Craft 5.


canvas.drawParagraph fails for custom Paragraph implementations

Steps to reproduce

Open this dartpad.
Press 'Run'
See the error

Expected results
I'd expect an black screen to be shown, since I use Canvas.drawParagraph the way it is documented.
(I discovered this while working on #154947)
Actual results
The following error is thrown:
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following _TypeError was thrown during paint():
TypeError: Instance of 'DummyParagraph': type 'DummyParagraph' is not a subtype of type
'CkParagraph'

Widget creation tracking is currently disabled. Enabling it enables improved error messages. It can
be enabled by passing `--track-widget-creation` to `flutter run` or `flutter test`.

When the exception was thrown, this was the stack

The following RenderObject was being processed when the exception was fired: RenderCustomPaint#af0e7:
  creator: CustomPaint ← _FocusInheritedScope ← _FocusScopeWithExternalFocusNode ←
    _FocusInheritedScope ← Focus ← FocusTraversalGroup ← MediaQuery ← _MediaQueryFromView ←
    _PipelineOwnerScope ← _ViewScope ← _RawViewInternal-[_DeprecatedRawViewKey
    EngineFlutterWindow#cc223] ← RawView ← ⋯
  parentData: <none>
  constraints: BoxConstraints(w=620.0, h=594.0)
  size: Size(620.0, 594.0)
  painter: null
  foregroundPainter: TestPainter#b393f()
This RenderObject has no descendants.
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: TypeError: Instance of 'DummyParagraph': type 'DummyParagraph' is not a subtype of type 'CkParagraph'

Code sample
See the dartpad above
Screenshots or Video
N/A
Logs
N/A
Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.24.1, on Microsoft Windows [Version 10.0.22631.4112], locale de-DE)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Chrome - develop for the web
[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2022 17.9.6)
[!] Android Studio (version 2022.1)
  X Unable to determine bundled Java version.
[√] Android Studio (version 2023.1)
[√] VS Code (version 1.92.2)
[√] Connected device (3 available)
[√] Network resources

! Doctor found issues in 1 category.

Reproducible on all platforms on the latest stable & master. Depending on the platform/renderer being used, the type in the error changes
wasm -> SkwasmParagraph
canvaskit -> CKParagraph
html -> CanvasParagraph
android/iOS/macOS ->  _NativeParagraph

complete code sample for easy access
import 'dart:ui';

import 'package:flutter/widgets.dart';

class DummyParagraph implements Paragraph {
  const DummyParagraph();

  @override
  double get alphabeticBaseline => 0;

  @override
  List<LineMetrics> computeLineMetrics() => [];

  @override
  bool get debugDisposed => true;

  @override
  bool get didExceedMaxLines => false;

  @override
  void dispose() {}

  @override
  List<TextBox> getBoxesForPlaceholders() => [];

  @override
  List<TextBox> getBoxesForRange(int start, int end,
          {BoxHeightStyle boxHeightStyle = BoxHeightStyle.tight, BoxWidthStyle boxWidthStyle = BoxWidthStyle.tight}) =>
      [];

  @override
  GlyphInfo? getClosestGlyphInfoForOffset(Offset offset) => null;

  @override
  GlyphInfo? getGlyphInfoAt(int codeUnitOffset) => null;

  @override
  TextRange getLineBoundary(TextPosition position) => TextRange.empty;

  @override
  LineMetrics? getLineMetricsAt(int lineNumber) => null;

  @override
  int? getLineNumberAt(int codeUnitOffset) => null;

  @override
  TextPosition getPositionForOffset(Offset offset) => const TextPosition(offset: 0);

  @override
  TextRange getWordBoundary(TextPosition position) => TextRange.empty;

  @override
  double get height => 0;

  @override
  double get ideographicBaseline => 0;

  @override
  void layout(ParagraphConstraints constraints) {}

  @override
  double get longestLine => 0;

  @override
  double get maxIntrinsicWidth => 0;

  @override
  double get minIntrinsicWidth => 0;

  @override
  int get numberOfLines => 0;

  @override
  double get width => 0;
}

class TestPainter extends CustomPainter {
  @override
  void paint(Canvas canvas, Size size) {
    final paragraph = DummyParagraph();
    paragraph.layout(ParagraphConstraints(width: size.width));
    canvas.drawParagraph(paragraph, Offset.zero);
  }

  @override
  bool shouldRepaint(TestPainter oldDelegate) => false;

  @override
  bool shouldRebuildSemantics(TestPainter oldDelegate) => false;
}

void main() {
  runApp(CustomPaint(foregroundPainter: TestPainter()));
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.24.2, on macOS 14.6.1 23G93 darwin-arm64, locale en-US)
    • Flutter version 3.24.2 on channel stable at /Users/deanli/dev/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 4cf269e36d (7 days ago), 2024-09-03 14:30:00 -0700
    • Engine revision a6bd3f1de1
    • Dart version 3.5.2
    • DevTools version 2.37.2

[!] Flutter (Channel master, 3.26.0-1.0.pre.72, on macOS 14.6.1 23G93 darwin-arm64, locale en-US)
    • Flutter version 3.26.0-1.0.pre.72 on channel master at /Users/deanli/dev/master
    • Framework revision 8a2c3a65fe (6 hours ago), 2024-09-10 22:16:25 -0400
    • Engine revision a26075f9b1
    • Dart version 3.6.0 (build 3.6.0-237.0.dev)
    • DevTools version 2.39.0


fix: update readme

:tada: This PR is included in version 2.1.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enhance Test-PlasterManifest to verify condition strings parse as PowerShell strings

XML schema validation does not help us with attribute values as those are effectively opaque strings to the schema validator.  Most (but not all) attribute values are evaluated as the contents of a double-quoted (interpolated) string during template processing.  Unfortunately innocuous things like a double quoted internal word can cause PowerShell to error out when it processes that string later.  Condition attributes are a bit different - they aren't evaluated in a double-quoted string context but they still need to parse correctly.
We should be able to the PS parser to verify these attribute values.

First part of impl checked in via PR #200 - check condition attributes.


Fix[#2183] inferFlattenedErrors should be a type about input type

This PR is to resolve issue #2183, which is to make inferFlattenedErrors be of type input, even for schemas with transforms defined.
I'm new to writing PRs, so I wasn't sure of the etiquette, and I'm not sure of the differences in the README, so I'd be glad to hear your comments.

Just adding a comment to note this isn't stale.


Feature/gitee provider

Add Gitee Git Provider Support
This PR adds comprehensive Gitee integration to Daytona's git provider system, enabling users to work with Gitee repositories seamlessly.
Features Added
URL Support

HTTPS URLs (https://gitee.com/owner/repo)
SSH URLs (git@gitee.com:owner/repo.git)
Branch-specific URLs (/tree/branch)
Commit-specific URLs (/commit/sha)
Pull request URLs (/pulls/number)
File/blob URLs (/blob/branch/path)

Core Functionality

Repository context parsing
Personal and organization repository listing
Proper authentication handling
Pagination support for repository lists

Implementation Details
New Files

pkg/gitprovider/gitee.go: Main Gitee provider implementation
pkg/gitprovider/gitee_test.go: Comprehensive test suite

Key Components

CanHandle: Smart URL detection for Gitee repositories
ParseStaticGitContext: Robust URL parsing with support for all Gitee URL formats
GetRepositories: Repository listing with personal/org namespace support
GetUser: User information retrieval
GetNamespaces: Namespace management

Testing

Comprehensive test coverage for all components
Mock HTTP server for API testing
Edge case handling
Error scenarios covered
Testing result

cd pkg/gitprovider && go test -v -run "Gitee"
=== RUN   TestGiteeCanHandle
=== RUN   TestGiteeCanHandle/valid_Gitee_HTTPS_URL
=== RUN   TestGiteeCanHandle/valid_Gitee_SSH_URL
=== RUN   TestGiteeCanHandle/invalid_GitHub_URL
--- PASS: TestGiteeCanHandle (0.00s)
    --- PASS: TestGiteeCanHandle/valid_Gitee_HTTPS_URL (0.00s)
    --- PASS: TestGiteeCanHandle/valid_Gitee_SSH_URL (0.00s)
    --- PASS: TestGiteeCanHandle/invalid_GitHub_URL (0.00s)
=== RUN   TestGiteeGetUser
--- PASS: TestGiteeGetUser (0.00s)
=== RUN   TestGiteeGetNamespaces
--- PASS: TestGiteeGetNamespaces (0.00s)
=== RUN   TestGiteeGetRepositories
=== RUN   TestGiteeGetRepositories/personal_repositories
=== NAME  TestGiteeGetRepositories
    gitee_test.go:215: Request path: /api/v5/user/repos
=== RUN   TestGiteeGetRepositories/organization_repositories
=== NAME  TestGiteeGetRepositories
    gitee_test.go:215: Request path: /api/v5/orgs/testorg/repos
--- PASS: TestGiteeGetRepositories (0.00s)
    --- PASS: TestGiteeGetRepositories/personal_repositories (0.00s)
    --- PASS: TestGiteeGetRepositories/organization_repositories (0.00s)
=== RUN   TestGiteeParseStaticGitContext
=== RUN   TestGiteeParseStaticGitContext/Basic_repository_URL
=== RUN   TestGiteeParseStaticGitContext/SSH_repository_URL
=== RUN   TestGiteeParseStaticGitContext/Repository_URL_with_branch
=== RUN   TestGiteeParseStaticGitContext/Repository_URL_with_commit
=== RUN   TestGiteeParseStaticGitContext/Repository_URL_with_pull_request
--- PASS: TestGiteeParseStaticGitContext (0.00s)
    --- PASS: TestGiteeParseStaticGitContext/Basic_repository_URL (0.00s)
    --- PASS: TestGiteeParseStaticGitContext/SSH_repository_URL (0.00s)
    --- PASS: TestGiteeParseStaticGitContext/Repository_URL_with_branch (0.00s)
    --- PASS: TestGiteeParseStaticGitContext/Repository_URL_with_commit (0.00s)
    --- PASS: TestGiteeParseStaticGitContext/Repository_URL_with_pull_request (0.00s)
=== RUN   TestGiteeGetUrlFromRepo
=== RUN   TestGiteeGetUrlFromRepo/URL_without_branch
=== RUN   TestGiteeGetUrlFromRepo/URL_with_branch
--- PASS: TestGiteeGetUrlFromRepo (0.00s)
    --- PASS: TestGiteeGetUrlFromRepo/URL_without_branch (0.00s)
    --- PASS: TestGiteeGetUrlFromRepo/URL_with_branch (0.00s)
PASS
ok      github.com/daytonaio/daytona/pkg/gitprovider    0.022s

Security Considerations

Secure token handling
Input validation
Proper error handling

Breaking Changes
None. This is an additive change that extends Daytona's git provider support.
Documentation
The implementation follows existing patterns in Daytona's git provider system, making it familiar to maintainers and users.
Reviewer Notes

The implementation aligns with existing git provider patterns
Test coverage includes all major use cases
Error handling follows established patterns
API endpoint handling matches Gitee's API structure

Related Issues
Closes #1341  - Add Gitee support to Daytona
Future Considerations

Potential webhook support
Advanced API integrations
Performance optimizations

Testing Instructions
cd pkg/gitprovider && go test -v -run "Gitee"

@quest-bot loot #1341

Also I'm getting this error, yet I created a Gitee account and pasted my personal access token.

@mojafa Pardon me Sir i hadn't commited the gitee registration in service.go, newGitProvider method and now after reciting it. it  working fine I guess.
Thanks for pointing out. i hope it doesn't  cause any problem now

@Sourabh7iwari having a look

@mojafa thanks sir but i think @tarunrajput sir has done better job then me
Its my first time doing oss collaboration thats I didn't do it properly.

@Sourabh7iwari good stuff so far, i was able to add the GItee git-provider, see below. However creating a workspace from the daytona create url in this case my url was https://gitee.com/mojafa/sample-julia.git i got an error. I also got an error on the text-based ui (TUI) when i entered the command daytona create.

Hey @Sourabh7iwari
Just wanted to let you know that Tarun's PR (#1409) is now complete, and we’ll be moving forward with that one.
As a starting point, I’d like you to focus on tackling the following instead:

Issue #1283
Issue #1298

Additionally, you can refer to PR #1284 for inspiration.
Let me know if you have any questions or need further clarification.

Closing per https://github.com/daytonaio/daytona/pull/1403#issuecomment-2514830239

@mojafa ohh this PR #1284  guidance is very much helpfull.
I'll try to tackle any next issue in more compliant way and free from error.
Thanks


fix: handle panic in converting too big u256 to usize

Added a check that the received U256 value from the stack is smaller or equal to usize::MAX before converting to usize. Because in case of the converting bigger value, we get panic.

Closing in favour of #26


why the messaging is not deployed in maven?

its because no one has contributed it yet - maybe you can help!


Fix incomplete structs

ptr distinct object for example is invalid and can crash Nim compiler. It should be invalid codegen.
Using incompleteStruct because empty structs have zero size in C. The actual struct implementation is usually in the .c file (private members in a way).

Is this a new change? The existing system has worked great before. Although I agree that this incompleteStruct is probably cleaner anyways

This isn't a new change. This has caused me some headache trying to find out what is crashing the Nim compiler, turns out it was generic object types (distinct object shouldn't be used as concrete type). I don't have reproducible example, my code is multiple files and 500 lines long when the bug appeared. After compiling Nim compiler in debug mode I could get a stack trace which pointed me to the distinct object ending up unexpectedly.

Not quite sure why GitHub didn't detect it, but I merged this manually after testing locally that it worked.
Ref.: https://github.com/PMunch/futhark/commit/6a89adf444acf6847dc487f44d9e98c4983aa926

Hmm, after further testing this seems like the wrong fix. What works is a plain object without incompleteStruct pragma.


Create TimestampBasedCopyableDataset and version selection policy

Moved RB655435 to github. @chavdar Can you take a look?

@chavdar Updated.

Changes Unknown when pulling 83e43302b43bc43b176010b762502b1ccdaf8374 on ydai1124:master into ** on linkedin:master**.

LGTM


When using EF Core, I am unable to get the Count() of children without returning one field from the children

Is there an existing issue for this?

[X] I have searched the existing issues

Product
Hot Chocolate
Describe the bug
I am working on a new project and need to show the count of a child navigation property in a grid.  While I can use Object Type Extensions to add the Count field, if a property of the child is not included in the query the count returns 0.  It looks like the issue is that the Query Resolver is resolving the Object Type Extension field after running the database query instead of adding the extension field before running the database query.
I want to avoid having to return a couple fields that have no use in the front end just to get the Count() of a child navigation field to work.
Steps to reproduce
Full reproduction code (new .net 7 project the paste into program.cs)
using HotChocolate.Types.Pagination;
using HotChocolateRepro;
using Microsoft.EntityFrameworkCore;

var builder = WebApplication.CreateBuilder(args);

// Add services to the container.
builder.Services.AddDbContext<DemoContext>(options => { options.UseInMemoryDatabase("demo"); });

builder.Services
       .AddGraphQLServer()
       .RegisterDbContext<DemoContext>(DbContextKind.Synchronized)
       .AddQueryType<Query>()
       .AddTypeExtension<ParentExtensions>()
       .AddProjections()
       .AddFiltering()
       .AddSorting()
    ;

var app = builder.Build();

// Configure the HTTP request pipeline.
if (!app.Environment.IsDevelopment())
{
    app.UseExceptionHandler("/Error");
    // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
    app.UseHsts();
}

app.MapGraphQL();

using (var context = new DemoContext())
{
    context.Database.EnsureCreated();
}

app.Run();

namespace HotChocolateRepro
{
    public class Parent
    {
        public int    Id   { get; set; }
        public string Name { get; set; }

        public virtual ICollection<Child> Children { get; set; } = new List<Child>();
    }

    public class Child
    {
        public int    Id       { get; set; }
        public int    ParentId { get; set; }
        public string Name     { get; set; }
    }

    public class DemoContext : DbContext
    {
        public DemoContext()
        {
        }

        public DemoContext(DbContextOptions<DemoContext> options)
            : base(options)
        {
        }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder) =>
            optionsBuilder.UseInMemoryDatabase("demo");

        public virtual DbSet<Parent> Parents  { get; set; }
        public virtual DbSet<Child>  Children { get; set; }

        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            //Example
            modelBuilder.Entity<Parent>().HasData(
                                                  new Parent { Id = 1, Name = "First" },
                                                  new Parent { Id = 2, Name = "Second" },
                                                  new Parent { Id = 3, Name = "Third" });

            modelBuilder.Entity<Child>().HasData(new Child { Id = 1, ParentId = 1, Name = "First" },
                                                 new Child { Id = 2, ParentId = 1, Name = "Second" },
                                                 new Child { Id = 3, ParentId = 1, Name = "Third" },
                                                 new Child { Id = 4, ParentId = 1, Name = "Fourth" },
                                                 new Child { Id = 5, ParentId = 2, Name = "Fifth" },
                                                 new Child { Id = 6, ParentId = 2, Name = "Sixth" });
        }
    }

    [ExtendObjectType(typeof(Parent))]
    public class ParentExtensions
    {
        public int ChildCount([ParentAttribute] Parent parent) => parent.Children.Count();
    }

    public class Query
    {
        [UseOffsetPaging()]
        [UseProjection()]
        [UseFiltering()]
        [UseSorting()]
        public IQueryable<Parent> GetParent(DemoContext context) =>
            context.Parents;
    }
}

Run the query and the childCount is returned properly populated.
{
  parent{
    items{
      id,
      name,
      childCount,
      children{
        id
      }
    }
  }
}

Run the query and the childCount is not returned populated
{
  parent{
    items{
      id,
      name,
      childCount
    }
  }
}

Relevant log output
No response
Additional Context?
No response
Version
13.1.0

The projection engine explicitly ignores fields that don't project to anything. I know the exact line of code that does this. This is, I believe, expected behavior.
You may not realize that, but what you actually need is to allow projecting expressions to be executed on the database by EF Core. I'm currently working on a PR that will allow that.

@AntonC9018 Thank you for the confirmation that there is not anything I was doing "wrong" and that this is expected behavior.
Looks like I am waiting for the PR you are working on to add the enhanced functionality.


New Icon LibreSpeed

The icon I want is:

Name: librespeed
URL: https://github.com/librespeed/speedtest
Link to icon: https://github.com/librespeed/speedtest/tree/master/.logo

Vector version of the logo:
Official style guide or brand guide:

Can I try this one?

Getting close! Going to keep at it - but any thoughts on the best way forward?

Sure! Looking at the source:

It looks like you have three 512x512 rounded rects - just use one with a black background.
The needle has some extra nodes on the straight parts, and angles sharpely on the sides when the original doesn't. It also has a circle cut out in the middle, which is unnecessary since you're drawing the circle on top.
Maybe consider doing the segments as clones with rotation and overridden fill.

Thanks for the suggestions, @Eiim - I shaved off just over a third of a KB implementing those. I'm at about 1.4KB when I remove whitespace. Going to keep cracking on. Was hoping I wouldn't have to change the logo at all but I may be running out of ideas 😛
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="Arch Linux" role="img"
viewBox="0 0 512 512"
style="--f:#d0d2d3">
	<rect width="512" height="512" rx="15%"/>
	<circle fill="#d0d2d3" cx="256" cy="256" r="192"/>
	<circle cx="256" cy="256" r="159"/>
	<defs><path id="a" d="M393.4 236.4c1.5 12 1.6 24.2 0 36.2l-21.4-2.8c1.3-10.1 1.3-20.4 0-30.5l21.4-2.9" style="fill:var(--f);transform:rotate(calc(var(--r)*1deg))translate(var(--c))"/></defs>
	<use href="#a" style="--f:#be1e2d;--r:20;--c:71.5px,-103px"/>
	<use href="#a" style="--f:#ec1c24"/>
	<use href="#a" style="--f:#ee4036;--r:-20;--c:-102.5px,72px"/>
	<use href="#a" style="--f:#f05a28;--r:-40.1;--c:-224px,105px"/>
	<use href="#a" style="--f:#f6921e;--r:-60.2;--c:-349.5px,94.5px"/>
	<path fill="#d0d2d3" d="m297.6 122.2-6.5 20.5c-9.2-2.9-18.7-4.6-28.2-5.2l-1.4-9.8.5-11.8c12 .6 24 2.7 35.6 6.3m-47.7-6.3.6 12.3-1.4 9.3c-9.6.6-19.1 2.3-28.3 5.2l-6.5-20.6c11.6-3.5 23.5-5.6 35.6-6.2M199 339h16v16h-16m32.5-16h16v16h-16m32.5-16h16v16h-16m32.5-16h16v16h-16"/>
	<use href="#a" style="--r:240;--c:-604.2px,-160.1px"/>
	<use href="#a" style="--r:220;--c:-615.55px,-284.9px"/>
	<use href="#a" style="--r:200.1;--c:-583.7px,-405.7px"/>
	<use href="#a" style="--r:180.1;--c:-512.3px,-508.8px"/>
	<use href="#a" style="--r:160.1;--c:-410px,-581.2px"/>
	<path fill="#1b75bb" d="m274.6 242.3 1.8 12c0 16.2-9.1 29.3-20.3 29.3-11.2 0-20.3-13.1-20.3-29.3l1.7-11.9L256 115.9l18.6 126.4"/>
	<circle fill="#d0d2d3" cx="256" cy="256" r="9"/>
</svg>

That's getting pretty optimized! Which also means it's harder to shave off those extra bytes...

There's some improvements to be made with the paths themselves. For example, the path in the <def> can be just M393.4 236.4a140 140 0 010 36.2l-21.4-2.8a120 120 0 000-30.5z, which is 15 bytes shorter.
Here's a suggested path improvement for the needle, which saves something like 60 bytes: m256 115.9 20.4 138.4a20.8 29.3 0 11-40.8 0z
You've got one style which is just the fill, I think that can be replaced with just fill="#ec1c24".

Those aren't really helpful for getting to 1kb though. More aggressive ideas:

Can you change the center of rotation for the def object? I think that's possible but don't remember how. Then you shouldn't need to do the translations, I think.
Maybe consider doing the two boxes at the top as <use>s as well, and putting an outline around the needle.
If those don't work, perhaps do something crazy like combine all the wedges into one arc which is broken up by black bars and filled with a gradient.

Getting a little loose with it now. Just about 1.096 after cutting out the whitespace. So close I can taste it!
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="LibreSpeed" role="img"
viewBox="0 0 512 512"><style>:nth-child(n+10){fill:#d0d2d3}</style>
<rect width="512" height="512" rx="15%"/>
<circle cx="256" cy="256" r="175.5" stroke="#d0d2d3" stroke-width="33.5"/>
<path fill="#1b75bb" d="m256 116 20.4 138.4c2.6 13.7-9.1 29.3-20.3 29.3-11.2 0-23.1-12.6-20.3-29.3L256 116"/>
<path id="a" d="M393.4 236.4a140 140 0 0 1 0 36.2l-21.4-2.8a120 120 0 0 0 0-30.5z"/>
<use href="#a" fill="#ec1c24" transform="rotate(10 256 254.5)"/>
<use href="#a" fill="#ee4036" transform="rotate(-12 256 254.5)"/>
<use href="#a" fill="#f05a28" transform="rotate(-34 256 254.5)"/>
<use href="#a" fill="#f6921e" transform="rotate(-56 256 254.5)"/>
<use href="#a" transform="rotate(-78 256 254.5)"/>
<use href="#a" transform="rotate(-102 256 254.5)"/>
<use href="#a" transform="rotate(-124 256 254.5)"/>
<use href="#a" transform="rotate(-146 256 254.5)"/>
<use href="#a" transform="rotate(-166 256 254.5)"/>
<use href="#a" transform="rotate(-188 256 254.5)"/>
<path d="M200.5 337h16v16h-16m32-16h16v16h-16m32-16h16v16h-16m32-16h16v16h-16"/>
<circle cx="256" cy="256" r="9"/>
</svg>

I think fill inherits, so you could put fill="#d0d2d3" on a  containing those elements. Or maybe that only works if it's in a style? Or maybe it doesn't work at all and I'm misremembering.
Looks like the needle path can still be a bit shorter with my version, although not by a lot. My version might be slightly less accurate though, not certain.


bugfix/frame-info-parsing

Problem
The frame-info is being parsed incorrectly, and therefore stored incorrectly. If a bundle arrives w/ 4 frames, the metadata (not the parsed agents) for the first frame is being saved 4 times.
Addresses https://aicsjira.corp.alleninstitute.org/browse/AGENTVIZ-1407
Solution
Assign the 'metadata' subarray correctly so that frame metadata is parsed and stored correctly.
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

Run the viewer locally
Log/Observe the frameDataCache object in VisData. It should now contain sequential, non-repeated, frame information.

Indenting looks off again.  Do you have "format on save" and "spaces instead of tabs" enabled in your editor?

Indenting looks off again. Do you have "format on save" and "spaces instead of tabs" enabled in your editor?
Corrected; Not currently (since I thought the lint command was run by a git-hook in this repository). Will configure.


Unable to find root

does not seem to work

Hi,
thanks for the report!
This is still a pre-release for now mainly because it's not well tested, especially on other OS than macOS.
I will address this pretty soon and do a "true" release later this week.

@sschneider-ihre-pvs Can you test again in 1.3.5 ?
I was finally able to test it on all platforms

Server returned 503

Yes my bad, the fact that I unpublished it seems to make indexing take a lot longer it's up on the marketplace so it should not take that long now.
https://marketplace.visualstudio.com/items?itemName=melmass.vscode-mono-workspace

I think I fixed the issue in 1.4.0, my test sample had all cases (Cargo, nx, yarn) so I was not properly testing isolated cases.
Feel free to re-open if you still encounter it.


Visualize large swaths of traces

From https://twitter.com/soini/status/1057642318365306880

For zipkin, if I had one wish, it'd be native visualization options for large swaths of traces.

Rational
Currently, our only aggregate tool is the service dependency diagram. While we've discussed doing single trace aggregate (for a stable shape regardless of call count to redis for example), We've not discussed how to do other ways of visualizing large amounts of traces.
Example Scenario
Hoping to hear about this from Joe so that we make the right thing!
Prior Art
Joe is building a multi-level sankey diagram w/ Vega in Kibana in the interim.

Please note other prior art. *

also related https://engineering.salesforce.com/anomaly-detection-in-zipkin-trace-data-87c8a2ded8a1

because we currently need to understand if this is visualizing for the purpose of detecting anomalies or traffic flow or shape of call graphs, we'll want to see more input. Especially in netflix we discussed that people may want something like a service graph with more facts (such as cluster and zone), but we don't know exactly what's in mind without hearing more from Jon or others.

From Jon on Twitter: https://twitter.com/soini/status/1058078887488315392

here's one of the viz's that's been kicking around in my head put (quickly) to paper. Being able to aggregate the node<>node flows, and then break them down by terms (error codes) or duration ranges would be cool, I think.

Chat with @narayuna offline I think is clarifying to me about how to phrase this effort.
So notes here aren't to say sanke is the way, as there are lots of details that need to be elaborated, not only why should something be built, but also who is it for, what affects the feature (related features, data things etc): it isn't a goal to implement an image, our goal is to serve users
Jon is a user who asked about this, and he has some experience to share, so we are welcome to take it. This is awesome as not everyone in Zipkin are experienced in the same ways. In OSS, some are happy to help with work needed to implement things they don't fully understand. We love experience dumps for this reason.. that's also why we hold workshops
https://cwiki.apache.org/confluence/display/ZIPKIN/Workshops
To be realistic, focused elaboration of something like this is the expensive part, and this will involve a lot of folks. We may find we don't have the right data for some things and decide either to collect it or even not do that! There's a lot of unknown dependencies at this phase of thinking for us.
So, setting expectations that this might be a collection of thoughts until the right time to dig deeper. The "right time" part is likely after we've redone the UI as we are swamped right now. So, tactically we work on getting the current UI in shape. Strategically, we raise issues like this and hold workshops to collect a general sense of direction and people
Ideal outcome is that when hands are free of the tactical, we end up choosing, integrating or building the right thing for end users' benefit as told to us by them!

https://github.com/openzipkin/zipkin/pull/2731 is a first step as it ports the basic dependency linker used in spark jobs to javascript

@jeqo I think only https://github.com/jeqo/zipkin-storage-kafka could produce the data for this, as it implies 100% collection and processing of it. Unless it is a small amount of traces which could be done client-side. That or a different system like haystack

there may be some on-demand, but cached aggregation features in ES at the moment.. no idea.

@adriancole not sure how I missed this issue :(
100% collection + late-sampling would be a good way to position the kafka-based storage.
Now that lens is in place I hope this issue gets bump again

@jeqo I think only https://github.com/jeqo/zipkin-storage-kafka could produce the data for this, as it implies 100% collection and processing of it. Unless it is a small amount of traces which could be done client-side. That or a different system like haystack

@codefromthecrypt @jeqo I wonder if you could do this without 100% collection.  100% collection would be nice for a few reasons but I wonder whether it would be essential.  I guess what I'm thinking is that sampled span duration percentiles would be ok with suitable large sample sizes.  I've now got some custom Java code that implements span duration response times on top of Zipkin.  It's very early days with the code I've got, I've not really drilled into the output much yet but what I'm seeing so far looks ok.


(PUP-893) Revert inspect and audit deprecation revert

This PR reverts the revert of the inspect command and audit metaparameter deprecation. It also adds a commit which causes the warning for audit to only be emitted when the parameter is set via a manifest.
This supersedes https://github.com/puppetlabs/puppet/pull/5756.

Fixed the spec failures by removing the new test, since we're not using a manifest in that test. Might be worth writing an acceptance level test to verify that difference...

CLA signed by all contributors.

Verified deprecation warning is not written out when audit is not used:
$ bundle exec puppet apply -e "notify { 'hi': }"
Notice: Compiled catalog for XXX.puppetlabs.net in environment production in 0.08 seconds
Notice: hi
Notice: /Stage[main]/Main/Notify[hi]/message: defined 'message' as 'hi'
Notice: Applied catalog in 0.01 seconds
$ bundle exec puppet resource service doesnotexist
service { 'doesnotexist':
  ensure => 'absent',
}

But deprecation warning is written out when audit metaparam is used:
$ bundle exec puppet apply -e 'file { "/tmp/foo": ensure => file, audit => all }'
Notice: Compiled catalog for XXX.puppetlabs.net in environment production in 0.07 seconds
Warning: /File[/tmp/foo]/audit: The `audit` metaparameter is deprecated and will be ignored in a future release.
   (at :1)
Notice: /Stage[main]/Main/File[/tmp/foo]/ensure: defined content as ''
Notice: /Stage[main]/Main/File[/tmp/foo]/ensure: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/content: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/checksum_value: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/target: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/owner: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/group: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/mode: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/type: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/seluser: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/selrole: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/seltype: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/selrange: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/ctime: audit change: newly-recorded value absent
Notice: /Stage[main]/Main/File[/tmp/foo]/mtime: audit change: newly-recorded value absent
Notice: Applied catalog in 0.01 seconds

Or when archive_* setting is specified:
$ bundle exec puppet apply -v -e "notify { 'hi': }" --archive_files true
Warning: Setting 'archive_files' is deprecated. It will be removed in a future release along with the `inspect` command.
   (at /Users/josh/work/puppet/lib/puppet/defaults.rb:1698:in `block in <module:Puppet>')
Notice: Compiled catalog for XXX.puppetlabs.net in environment production in 0.07 seconds
Info: Applying configuration version '1490328173'
Notice: hi
Notice: /Stage[main]/Main/Notify[hi]/message: defined 'message' as 'hi'
Notice: Applied catalog in 0.01 seconds
$ bundle exec puppet apply -v -e "notify { 'hi': }" --archive_file_server somewhere.example.com
Warning: Setting 'archive_file_server' is deprecated. It will be removed in a future release along with the `inspect` command.
   (at /Users/josh/work/puppet/lib/puppet/defaults.rb:1707:in `block in <module:Puppet>')
Notice: Compiled catalog for XXX.puppetlabs.net in environment production in 0.07 seconds
Info: Applying configuration version '1490328188'
Notice: hi
Notice: /Stage[main]/Main/Notify[hi]/message: defined 'message' as 'hi'
Notice: Applied catalog in 0.01 seconds


New xfce

This branch switches from xfce/4.16_ood to xfce/4.16_latest

Tested this with Rain.
Tested Basic Desktop (CPU,GPU), Adv Desktop (CPU,GPU) and Adv Desktop with KDE.


FD-58 About page updates

I checked with Eric and we are supposed to keep the text color (#242425) from the style guide for these pages. I fixed the line-height, some other font sizing/spacing (notably the title under staff names), and the extra space.


please add a racoon (pedro, pedro, pedro...)

i guess we definitely need a racoon <3

oh sorry duplicate...

Duplicated of https://github.com/tonybaloney/vscode-pets/issues/547


photoprism: correct heif-convert binary name

Description of changes
libheif does not provide a utility named heif-convert, but it does provide heif-dec, which is what the upstream version of photoprism also defaults to if PHOTOPRISM_HEIFCONVERT_BIN is not defined.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

photoprism

For posterity: this broke with afe278a98d4d72ce6cd2a658701e520165f881d4 and as per the release notes this is when heif-convert was renamed to heif-dec
For anyone running photoprism which might contain HEIC images (often created by iPhones), you may want to reindex all photos ingested by your instance since July 2024 once this lands and is deployed to your devices


Actor class representation should show stories assigned to it.

>>> Reporter
Reporter
  ProvideReport
  ReviewReport

Superseded by #723


Should we use the word "metric"?

@danielskatz notes "It's interesting to me that the word metric isn't used above - should it be?" in relation to the guidance on the discussion activity.

I'd done this deliberately to avoid channelling participants down the route of measurable things at this stage.
I've introduced the term in the "Input - What are existing models of measuring success" section.


mapsd: didn't recover after internet connection dropping

d5f0cbd9ceba7d0c|2023-07-11--19-59-24
we should also make sure the UI widget consistently recovers

Started unit tests in #28981, should be able to write one for this case

Test case added in https://github.com/commaai/openpilot/pull/29044 suggests this is more of an edge case. Moving to 0.9.5

Hasn't popped up again, and we've got a test now. Closing until it happens again.


Contact 1 of 3

Description

This is the first of a three stage pull request plan to get contact into Fierro single-node. This first stage covers sorting the set of contact nodes in such a way to allow easy access to nodes in proximity to a patch/surface. For now, all contact features are handled by struct contact_patch_t and struct contact_patches_t. The first is for handling the many roles between a single patch and node, such as detection, force resolution, computing normals, etc. The latter is for setting up the instances of struct contact_patch_t, getting contact pairs, handling interactions between patches, etc. Though the name might imply that only patches are considered, this can be manipulated to handle higher order surfaces. Such features are not expected to be available immediately.
In the future, SGH::boundary_contact() will look like this:
contact_bank.sort(mesh, nodes, corner);  // contact bank is an instance of contact_patches_t, which is a member of class SGH
contact_bank.get_contact_pairs(dt);
contact_bank.normal_increments(dt);  // frictionless force resolution
contact_bank.remove_pairs(dt);  // remove contact pairs that fall off the edge of a patch or have zero force

This PR covers the contact_patches_t::sort() method, initializing the instances of contact_patches_t and contact_patch_t in SGH::setup(), and the contact_patches_t::find_nodes() method, which takes in a contact_patch_t instance and determines the nodes that could penetrate the contact_patch_t.

Type of change
Please select all relevant options

[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Formatting and/or style fixes
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[x] Test A : With contact_test.yaml as the input, see that it successfully runs with each call of contact_bank.sort() in the boundary_contact function. Additionally, outputting the contact_bank.nsort array correctly depicts the nodes sorted propagating first in the x direction, then the y direction, then the z direction. Calling contact_bank.find_nodes() with patch 2 as the patch of interest correctly finds nodes 18 19 20 21.
[x] Test B : The similar procedure above can be done with contact_test2.yaml.

Test Configuration:

OS version: MacOS
Hardware: M3 Pro
Compiler: cling

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] The code builds from scratch with my new changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

We probably want the contact bank to live outside of the SGH solver, that way we can use the same framework for multiple solvers.  Lets chat at our next meeting about where that needs to live.

Note: For all KOKKOS_FUNCTIONS, it needs the macro (KOKKOS_FUNCTION) placed before the return type on the line above for both the declaration and the definition.  @nathanielmorgan, do we have a macro wrapping KOKKOS_FUNCTION to alias to something like DEVICE_FUNCTION, for those who dont know kokkos?  May be worth doing.


Create Issue template

This repository is lack of issue template..

I'd like to work on this as per https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository
If there are any other suggestions, kindly let me know and assign the issue.

Hello, @Soumya-Kushwaha.
Great to hear that you would like to work on this issue. As of now, I don't have any other suggestions.
Thanks for your contribution!