PR1 Test

[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

:memo: Version: 1.20180820. Thank you for submitting PR #350. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://invain.mooo.com/.

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://invain.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/201810251406060.23010206222534-350-5b4ff3676a27a44f996c5c01a78003184c49b14f/report/misspelling_result.txt.

:octocat: cibot: @joonhee-jang, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnsuite/TAOS-CI/wiki/.

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://invain.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/201810251408120.22367596626282-350-bc7aea97e1994ae8c9d9bdf6bd5ca341020da83b/report/misspelling_result.txt.

:octocat: cibot: @joonhee-jang, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnsuite/TAOS-CI/wiki/.


Does Lexicon.jl work with Julia v0.4 built-in doc mechanism?

att. I tried briefly, but get an empty generated md file. Does Lexicon.jl work with the built-in doc mechanism for Julia v0.4? If not, should I use Docile.jl in v0.4? Would there be conflicting with the built-in documentation related macros? Thanks!

Lexicon relies on Docile's internals for doc collection, though it should still work on 0.4. I'll be phasing Lexicon out over the next few months in favour of the https://github.com/MichaelHatherly/Docile.jl/tree/rewrite branch that now supports generating external docs among other things.
The self-generated docs for that branch should provide you an overview of what's been implemented so far. If you do try it out and run into problems with it feel free to open issues in the Docile repo.

Thanks! I found that there was a configure mistake in my code. Now it works.
However, I still have one question: under Julia v0.4, does Lexicon/Docile use the built-in mechanism to get documentation or does Docile parse the source file itself? I'm asking because I have some functions that are automatically generated (imported from a shared library) during module start-up. I use eval to define those new functions and add documents by
  eval(:(@doc($f_desc, $func_name)))

Now I can see the documents in REPL by typing question mark. However, it seems Lexicon.jl cannot find those documents.

does Docile parse the source file itself?

Yes, currently it's still parsing the AST itself which means that generated code cannot be documented. With the rewrite branch most of Docile has been rewritten to make use of the builtin docsystem to generate external docs. I'll hopefully have that branch finalised and released relatively soon.

@MichaelHatherly Thanks! I see. The rewrite branch looks promising. I will try it out!

I have the same issue as yours. All the files generated are empty. The result of doctest is
running doctest on RCall...
[module summary]

 *   module: RCall
 * exported: 31
 *  entries: 0

[doctest summary]

 * pass:     0 / 0
 * fail:     0 / 0
 * skip:     0 / 0

The build.jl is here. @pluskid, what did you do to fix your problem?

Figure it out. I am on Julia v0.4. For compatibility issues, our package is still using the v0.3 syntax
@doc "bla bla bla"->
function f(x)
x
end

and Lexicon.jl fails to build the docs. However, if I switch to the v0.4 string type doc syntax,
"bla bla bla"
function f(x)
x
end

then it works.


Remove reflection for messaging

Change reflection-based serialization, deserialization to an explicit one with bare csv.

Fixed


feat(InputfileResolver): exclude online files from globbing

This pull request fixed issue #90

This may not work when we copy the files to the sandbox because the file is not on the file system. It may be smart to move isWebUrl to a util class so we can use it multiple times.

I'll fix this


AMBARI-25198. MYSQL connector exception while upgrading ambari to ambari-2.7.3. (mpapirkovskyy)

What changes were proposed in this pull request?
Support for mysql connector 8 was added.
How was this patch tested?
Manual check.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5011/
Test FAILed.
Test FAILured.

retest this please.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5012/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5018/
Test FAILed.
Test FAILured.

retest this please.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5021/
Test PASSed.


Alfred 3 compatibility?

Do you have a version that's compatible with Alfred 3?

check the older versions maybe? https://github.com/godbout/alfred-airplay/releases
which issue are you having?
it's possible that the latest version of this workflow uses some Alfred objects that are only available in Alfred 4. that wouldn't be surprising if i dropped Alfred 3 as the update to version 4 is free. out of curiosity, any reason why you're staying on 3?

It says the whole workflow is incompatible likely because you are using some objects new to v4.
Staying on v3 because I don’t want to pay $40 USD to upgrade. The features in v4 aren’t nearly worth that cost. :(

USD$40? had no idea. i paid for a lifetime license early on. and i even gave a donation at the upgrade time 😂😂😂 that app is saving me so much friction.
well, then i'd say or you go with an old release, or you replace the v4 object. should be quite straightforward really. i can't really guess which one, i don't have v3 anymore 🙃

btw it seems that Alfred is lying.
not using any of those new objects in that workflow: https://www.alfredapp.com/whats-new/
that was surprising that i didn't mention anything in the release logs. it might be just that i'm exporting from v4.

If you're not using any of the new objects, is there an easy way I can take the code or whatever you have now & create my own fork of the workflow? Sorry, non-dev here.

actually yes, it's very easy.
below you can see the workflow objects. only the two first one mandatory to make the workflow work (the two last ones are just for notification and sound):

to make your own:

create a new blank workflow
create the first object, a Script Filter. choose bin/bash for language, copy the content of aps-list.sh (https://github.com/godbout/alfred-airplay/blob/master/aps-list.sh)
create the second object, a Run Script. choose bin/bash for language, copy the content of aps-launch.sh (https://github.com/godbout/alfred-airplay/blob/master/aps-launch.sh)
link both objects. add your options in the first object (keyword, etc.)

then you should be good to go. let me know how it goes.

You are amazing. Thank you for this clear explanation. This worked. You rock.

my pleasure. glad it went smoothly. enjoy! ☀


add shared() to Future trait

The shared() method provides a mean to convert any future into a clonable future.
It enables a future to be polled by multiple threads.
Example:
`

let shared_future = original_future.shared();
let cloned_future = shared_future.clone();
let cloned_future2 = cloned_future.clone();
`
#173

Ah sorry I've missed some of the recent updates!
It looks like the amount of unsafe code is on the uprise here. I wonder if we should perhaps just stick to a Mutex-based approach to start out with, and then if it becomes a bottleneck we can move towards a lock-free approach?

@alexcrichton  I'd like that too, but we have the RwLock problem you mentioned.
I've searched for an implementation that has the required guarantees (no race for try_read()), and did not find one.
If we write an RwLock for that purpose we will eventually write unsafe code.
Beyond the slightly better performance, current implementation solves the RwLock issues. I think we should go with it, and just be careful.
If you agree, I will prepare the branch for code review (remove WIP).
Otherwise, tell me if you are familiar with a RwLock implementation that will be fine for our purpose.

Oh I was thinking of basically starting the entire poll method with just a blanket:
let mut state = self.inner.lock().unwrap();

That way the entire function call is synchronized with respect to any other concurrent callers and we don't have to worry about platform-specific guarantees and such.

@alexcrichton Ah that will be much simpler than anything else, but I thought we should never block in poll method.

Indeed yeah, but this kind of synchronization should have a bounded wait time. That is, it's possible for a thread to be blocked for a small amount of time, but it would never wait on something like I/O for an unbounded amount of time.
In other words a targeted use of a mutex or an rwlock is fine so long as the duration for which the lock is held is as small as possible.

@alexcrichton I've replaced the unsafe blocks with synced RwLock methods (that are safe).
It's not really necessary, and adds some of overhead, but as you said, if it becomes a bottleneck we can change it.

@alexcrichton I've also removed shared() method from Future trait because it required std (used Task).
Instead, I've created IntoShared that implements shared() to every Future, so the result is the same.

Oh it's fine to just tag the method with #[cfg(feature = "use_std")] like other methods that require std, an extra trait shouldn't be necessary for this.

Ok @liran-ringel this looks great to me, thanks!
@aturon @carllerche mind doing a gut-check on naming here? To recap the shared method here takes a Future<T, E> into what is essentially a Future<Arc<T>, Arc<E>>. The Shared type returned can be cloned to create many handles to the same future.

I'm :+1: on the name and on providing this functionality.


Create railroad diagram for query grammar

https://www.bottlecaps.de/rr/ui

For optimization query:
optimization_query ::= outputs inputs? includes? excludes?
outputs            ::= ("produce" | "make" | "create") ("only"? ("?" | "_" | [0-9]+) ("power" | "tickets" | item)) (("and" | "+") ("only"? ("?" | "_" | [0-9]+) ("power" | "tickets" | item)))*
inputs             ::= "from" ("only"? ("?" | "_" | [0-9]+) ("power" | "space" | ("unweighted"? "resources") | "weighted resources" | resource | item)) (("and" | "+") ("only"? ("?" | "_" | [0-9]+) ("power" | "space" | ("unweighted"? "resources") | "weighted resources" | resource | item)))*
includes           ::= ("with" | "using") ("only"? (recipe | building)) (("and" | "+") ("only"? (recipe | building)))*
excludes           ::= ("without" | "excluding") ("alternate recipes" | recipe | building) ("or" ("alternate recipes" | recipe | building))*


[genesis] Fix module store size bug

Summary

Fix #1565 to support framework upgrade.
Auto-create account when transfer; after #1669, we can remove the auto-create logic.

I merge this PR first. @pause125  @baichuan3


Refactor std::tx to use gtf intrinsic

Main changes

made small changes to both token.sw and auth.sw to handle the return types of some tx functions switching to enums
Adds 2 new modules Inputs & Outputs and moves related stuff to correct module.
follow-up pr's will add in all the remaining getters to expose all of the gtf fields.
the list of cont values near the top of the tx module currently has all the needed consts listed, but the ones not yet used are commented out (I've been un-commenting as I implement them to help track my work).
I've added some new pub enums to clean up some return types of functions:

pub enum Transaction {
    Script: (),
    Create: (),
}

pub enum Input {
    Coin: (),
    Contract: (),
    Message: (),
}

pub enum Output {
    Coin: (),
    Contract: (),
    Message: (),
    Change: (),
    Variable: (),
}

Looks good to me! The only note I have is that the hardcoded GTF values are set to the current spec which removes owner from InputMessages, but this has not been implemented yet in fuel-asm, fuel-tx, or fuel-core yet (see here). There could be some minor headaches until all repos are caught up

Looks good to me! The only note I have is that the hardcoded GTF values are set to the current spec which removes owner from InputMessages, but this has not been implemented yet in fuel-asm, fuel-tx, or fuel-core yet (see here). There could be some minor headaches until all repos are caught up

Reverted to the old constants (most of them were commented out anyways) and added a comment explaining why they don't match the spec.


chore: extract metadata (WIP)

This PR aims to extract metadata and generate mermaid diagrams along with it.

Mermaid doesn't support escape sequences in class diagrams which would result in viewing all the data in the same vertical line. Looking for a workaround for this.
PlantUML supports escape sequences.

Could you check in docs/open source if there is a solution to convert

sorry, I didn't get it. Are you talking about the documentation mermaid provided? If that's the case I already surfed through it and didn't get anything :(

Also, could you show result as example in PR? :)

You, mean the default output? I was thinking of it but that's really big. I would then paste it in here 😅

And at the end, if PR is in WIP, you can create draft PR :)

Sure, thanks for telling this :)

I mean documentation for mermaid and (maybe) some open source gist to convert json to mermaid input :)

I did ask for support on their slack channel too. Let's see :)

@derberg @magicmatatjahu I have added(in PR description) a link showing how mermaid diagram would look like after adding metadata. Any feedback would be appreciated.

I think that for mermaid we should skip metadata information really and not render it, mermaid is simple tool + classical class diagram is not for displaying such complex structures like the entire schema. Please provide example of diagram without schema/metadata with simple relations, but relations should go through the server class, it should not be standalone like in the current example, use channel names as labels for relations between a server and a service

Yeah, that was my major concern too.

I think that for mermaid we should skip metadata information really and not render it, mermaid is simple tool + classical class diagram is not for displaying such complex structures like the entire schema.

Please provide example of diagram without schema/metadata with simple relations, but relations should go through the server class, it should not be standalone like in the current example, use channel names as labels for relations between a server and a service

We have already done that see this for example.
I made servers standalone and using labels for them keeping in mind that the case in which there are multiple servers and that would result in a complex diagram.

use channel names as labels for relations between a server and a service

@derberg you mean like this right?

@arjungarg07 perfecto 🚀 loving how it looks. metadata can be removed, rest is great.
my only concern is - is class diagram the way to go, flowchart seems more elegant as you can have different shapes (server could be a cylinder) and it would look clearer + names with spaces are allowed. Thoughts?

@arjungarg07 perfecto 🚀 loving how it looks. metadata can be removed, rest is great.

Thanks! but could you point out which one looks perfect coz I linked up two ways of representing it? 😅

my only concern is - is class diagram the way to go, flowchart seems more elegant as you can have different shapes (server could be a cylinder) and it would look clearer + names with spaces are allowed. Thoughts?

I had this thought right from the beginning that why choosing class diagrams when we could have much clearer visibility with flowcharts but the project description said it to have classDiagram syntax from mermaid and I never questioned it 😞
So flowcharts would look like this

oh man, question everything I say if you have doubts, I'm not too smart 😆
cylinder is large because of long description, just keep URL without protocol like this

@derberg Thanks! but could you point out which one looks perfect coz I linked up two ways of representing it?

for me both are perfect as they are the same except of the overlaping labels in the mermaid diagram, but it is because of the nature of class diagram, the flow one looks super cool

we could have both, class diagram with PlantUML and flowchart with Mermaid 😄

I need to raise another PRs then coz this one was for metadata and I already pushed changes to extract it so can we merge this one?

sure, separate Pr is fine, I just need you to update PR title and description as it doesn't match for me with changes in the code really 😄

@magicmatatjahu just so you know 😅  I don't have permission to merge PR so if you could please. Thanks!

@arjungarg07 I forgot 😅 Sorry!


[5.7] Improve the return value of the caseKey method

this PR is for improving  the return value of the caseKey method
The castkey method should have returned the value of the primary key type, rather than judging by the is_number or is_string method

Example
class User extends Eloquent
{
    protected $table = 'users';
    protected $fillable = ['id', 'email'];
    public $timestamps = false;

    public function articles()
    {
        return $this->belongsToMany(Article::class, 'article_user', 'user_id', 'article_id');
    }
}
class Article extends Eloquent
{
    protected $table = 'articles';
    protected $keyType = 'string';
    public $incrementing = false;
    public $timestamps = false;
    protected $fillable = ['id', 'title'];
}
## users
---------------------------------------------------
id
1
## articles
id
---------------------------------------------------
123
7b7306ae-5a02-46fa-a84c-9538f45c7dd4
(string)PHP_INT_MAX+1

In the past, I have set the primary key type of the Article model to string, but if I insert an integer overflow number through`$user->articles()->sync(), I can successfully insert the data, but if the type of the return value is a long numeric string, Will not get the right results.

@tillkruss Hello, can the style of the test code be beautified through you?

Would these changes be needed in other (read: non-pivot) places too? I'm thinking mostly about consistency; this looks like it will introduce new types for primary keys for pivots, so we should probably do that for normal models too?

@sisve The correct type relationship has been handled in the model, as long as keyType is set, the error here is mainly because the primary key value in the parameter is simply used in the code to determine whether it is a number or a string. Rather than judging by the type of primary key of the model

What if the relationship is using a custom pivot model class with its own key type?

@taylorotwell I'm using translation software. I'm not sure I can understand you completely. But if the middle model customize its own type, shouldn't it be consistent with the primary key type of the relation model?


google colab error

RuntimeError: Failed to import transformers.models.clip.feature_extraction_clip because of the following error (look up to see its traceback):
module 'PIL.Image' has no attribute 'Resampling'

Hey! this happens when you don't restart the notebook before continuing on with the rest of the setup process! We added a disclaimer in a more recent version of the notebook to remind you to do this 🙂
if you did that and are still running into the issue, could you please re-open this issue with a copy of the "!pip list" so that we can diagnose this issue further ?
thanks!


accelerate and descelerate

why this two method return type is ViewAnimator ， i think AnimationBuilder type is better

.accelerate and .descelerate is for all the animation
if you want to specify a custom interpolator for just a part of the animation (eg: translationX) just use .singleInterpolator


Update README.md

Update Typo

thanks for fixing some typos! If you'd like, there are opportunities to continue improving the documentation :D


tests fail on ppc64el with amos_test.go:354: Case zseri yi_idx_5: Float64 mismatch. c = 2.845067377894076e+68, native = 2.8761262203281526e+68 cb:<PHONE_NUMBER>465022803, nb:<PHONE_NUMBER>354080705

What are you trying to do?
Run tests on ppc64el machine (same tests pass on amd64 and arm)
What did you do?

Run testsuite normally (the same commands pass on other archs)
What did you expect to happen?
Tests should pass on ppc64el as well
What actually happened?
    amos_test.go:354: Case zseri yi_idx_5: Float64 mismatch. c = 2.845067377894076e+68, native = 2.8761262203281526e+68
         cb:<PHONE_NUMBER>465022803, nb:<PHONE_NUMBER>354080705
--- FAIL: TestZseri (19.62s)

Full log https://ci.debian.net/data/autopkgtest/testing/ppc64el/g/golang-gonum-v1-gonum/14820455/log.gz
What version of Go and Gonum are you using?

gonum 0.9.0 and golang go 1.15.15
Does this issue reproduce with the current master?
not tested with master

Unfortunately this is not a supported architecture and amos is a particularly finicky package. I'm not sure that we will be able to help with this.

Still an issue with gonum 0.13.0 and golang go 1.20.5. Additionally, another test is now failing (shown below). Any further thoughts on fixes? I'd like to be able to run the tests on the ppc64el builders when the package is updated in Debian.
[snip a ton of reported failures]
    amos_test.go:354: Case zseri yi_idx_3: Float64 mismatch. c = 1.7225404522972317e+69, native = 1.7210280917217914e+69
         cb:<PHONE_NUMBER>568237156, nb:<PHONE_NUMBER>677661040
    amos_test.go:354: Case zseri yi_idx_4: Float64 mismatch. c = -8.848345645672536e+68, native = -8.796985853913224e+68
         cb:<PHONE_NUMBER>2645354487, nb:<PHONE_NUMBER>1583063086
    amos_test.go:354: Case zseri yi_idx_5: Float64 mismatch. c = 2.845067377894076e+68, native = 2.8761262203281526e+68
         cb:<PHONE_NUMBER>465022803, nb:<PHONE_NUMBER>354080705
--- FAIL: TestZseri (9.46s)

and
    unconstrained_test.go:1221: Case 61: error finding minimum (linesearch: failed to converge) for:
        F: ExtendedRosenbrock
        Dim: 2
        Initial X: [100000 100000]
        GradientThreshold: 1e-10
--- FAIL: TestBFGS (0.38s)

Still not a supported architecture.


Array with one element become Object

Hello, I have a problem with the response, there are some element that should be array of one element but they become object, while if there are two or more element they are array. This cause problem when I convert the object received to Json and I send it to the client.
This is the example of my code:
        $request = json_decode($jsonRequest->getContent());

        $this->soapWrapper->add('Service', function ($service) {
            $service
                ->wsdl('url')
                ->trace(true)
                ->classmap([
                    myObjectRequest::class
                ]);
        });
        $response = $this->soapWrapper->call('Service.nomeofservice', [
            new myObjectRequest($request)
        ]);

        return json_encode($response);

There is a way to avoid this type of behavior? For example Soap Client of Php contains an options called "SOAP_SINGLE_ELEMENT_ARRAYS" that should fix the issue.

I know it may be a little too late, but I just faced this situation and I could deal with it by adding a call to then Service's options method, passing the SOAP_SINGLE_ELEMENT_ARRAYS feature, like that:
            $service
                ->wsdl('url')
                ->trace(true)
                ->classmap([
                    myObjectRequest::class
                ]);
                ->options([
                    'feature' => SOAP_SINGLE_ELEMENT_ARRAYS
                ]);

I hope it help you and/or anyone facing the same situation.

Thanks @jvs-leonardow, it helped me :-)


[cppgraphqlgen] Add a port for Microsoft/cppgraphqlgen

I had to do a quick rev of the v0.5 tag to fix a CMake break on UNIX. The pull request should work now with the updated hash, but you may need to delete the cached download for Microsoft-cppgraphqlgen-v0.5.tar.gz from your local vcpkg/downloads directory.

Could you change the ref in vcpkg_from_github() to be the commit id then? That will rename the file and also avoid silent hash breaks in the future.

All set, verified that it pulls the right archive and builds on WSL.

👍 Thanks for the PR!


Add ValidatingAdmissionPolicyBinding resource

Ref: https://issues.redhat.com/browse/ACM-14837

Related Issue
https://issues.redhat.com/browse/ACM-14837
Description of changes

Added ValidatingAdmissionPolicyBinding resource

/retest

@mprahl @dhaiducek @JustinKuli @l

@jlpadilla

/cc @mprahl @dhaiducek @JustinKuli @jlpadilla

/hold

/unhold @jlpadilla Thanks!

/unhold


Incorrect Type type in "App template JSON format" docs

Bug description
I tried to use my own template.json file. I set the type to "3" but no stacks were visible in the UI. Once I changed to 3, it worked correctly. Also, all examples use an integer instead of a string. I assume there's a minor error in the docs - the type should have been int instead of str.
https://docs.portainer.io/v/ce-2.11/advanced/app-templates/format#type

Thanks for flagging this, I've updated the documentation. For future documentation-related issues, you can open an issue (or even better, a pull request!) in the portainer-docs repository.


Fix bug if experiment is initialized with empty string.

This is a copy of #377. Messed up when creating pull request from master.

Coverage remained the same at 83.605% when pulling 0f99da3027d102f65c2d70b52dac6a1e1c36f557 on kilsenp:fix_empty_string into 94785b9592b16e8498212ad9cfa0e05d49a1819d on IDSIA:master.


bug: Application tried to present modally a view controller that is already being presented

Plugin version:

3.0.2
Platform(s):

[x] ios

Current behavior:

Catched 10 times crashes from crashlytics
Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                     0xa248 __exceptionPreprocess
1  libobjc.A.dylib                    0x17a68 objc_exception_throw
2  UIKitCore                          0x327fc0 -[UIViewController _presentViewController:withAnimationController:completion:]
3  UIKitCore                          0x39de9c __63-[UIViewController _presentViewController:animated:completion:]_block_invoke_2
4  UIKitCore                          0x316d0 +[UIView(Animation) performWithoutAnimation:]
5  UIKitCore                          0x326f98 __63-[UIViewController _presentViewController:animated:completion:]_block_invoke
6  UIKitCore                          0x3051dc -[UIViewController _performCoordinatedPresentOrDismiss:animated:]
7  UIKitCore                          0xd33f8 -[UIViewController _presentViewController:animated:completion:]
8  UIKitCore                          0xd3234 -[UIViewController presentViewController:animated:completion:]
9  CapacitorCommunityPrivacyScreen    0x5490 (Missing UUID ada146d719f8360f8a0a231b9f880e2d)
10 CapacitorCommunityPrivacyScreen    0x54d4 (Missing UUID ada146d719f8360f8a0a231b9f880e2d)
11 libdispatch.dylib                  0x24b4 _dispatch_call_block_and_release
12 libdispatch.dylib                  0x3fdc _dispatch_client_callout
13 libdispatch.dylib                  0x127f4 _dispatch_main_queue_drain
14 libdispatch.dylib                  0x12444 _dispatch_main_queue_callback_4CF
15 CoreFoundation                     0x9aa08 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
16 CoreFoundation                     0x7c368 __CFRunLoopRun
17 CoreFoundation                     0x811e4 CFRunLoopRunSpecific
18 GraphicsServices                   0x1368 GSEventRunModal
19 UIKitCore                          0x3a2d88 -[UIApplication _run]
20 UIKitCore                          0x3a29ec UIApplicationMain

I gues it is from
@objc func onAppWillResignActive() {
        guard self.isEnabled else {
            return
        }

        DispatchQueue.main.async {
            self.bridge?.viewController?.present(self.privacyViewController!, animated: false, completion: nil)
        }
}

Steps to reproduce:

Related code:

May be we should try
@objc func onAppWillResignActive() {
        guard self.isEnabled else {
            return
        }

        // Check if privacyViewController is already presented
        if self.privacyViewController?.presentingViewController != nil {
              return
        }

        DispatchQueue.main.async {
            self.bridge?.viewController?.present(self.privacyViewController!, animated: false, completion: nil)
        }
}

Capacitor doctor:

💊   Capacitor Doctor  💊

Latest Dependencies:

  @capacitor/cli: 4.7.3
  @capacitor/core: 4.7.3
  @capacitor/android: 4.7.3
  @capacitor/ios: 4.7.3

Installed Dependencies:

  @capacitor/core: 4.7.3
  @capacitor/android: 4.7.3
  @capacitor/cli: 4.7.3
  @capacitor/ios: 4.7.3

[success] iOS looking great! 👌
[success] Android looking great! 👌

Can you reproduce the issue locally?

@robingenz Sure. I'll try. Opened bug so as not to forget to fix it and to consult with you.

Could the suggested safeguard be included, as it seems harmless enough? I see over 200 instances of the same error in our Crashlytics logs over the past 30 days.


Flake8 rule 'E901' reported an invalid point

Flake8 reported an invalid point for the rule E901, with the messge SyntaxError: EOL while scanning string literal.
#!/usr/bin/python
Debug information:
Atom version: 1.11.2
Flake8 version: 2.5.1 (pep8: 1.7.0, pyflakes: 1.3.0, mccabe: 0.3.1) CPython 3.5.2 on Linux

I had a doc string ending with 4 quote marks (""""). Fixing this typo stopped the issue appearing.

Closing due to a lack of response, if you are still having issues after updating flake8 please provide code to reproduce this!

Sorry yes it was resolved now thanks.


Adaption to aldryn-boilerplates

multi-boilerplate support
new requirement: aldryn-boilerplates (needs configuration)

Coverage remained the same at 20.03% when pulling b9e9cf9d4af1baedd7671c1b9856ac4b546f1a06 on feature/boilerplates into fcd2d7d3ba603faae1ae20674ef7224ee3b41495 on master.

not required as we use aldryn-newsblog now


AssertionError [ ] -- No transactions found <--- is this a bug ?

Hi. I am having , for another BSC address, thrown the following exception :
......./lib/python3.9/site-packages/bscscan/bscscan.py", line 33, in wrapper
return parser.parse(r)
......./lib/python3.9/site-packages/bscscan/utils/parsing.py", line 12, in parse
assert status, f"{result} -- {message}"
AssertionError: [] -- No transactions found
Is it expected to throw an error , opposite just returning nothing ?
Thank you. Ionut.

I get what you mean.
I am afraid that this is a problem on BSCScan's side though, because they treat an empty list of transactions as an erroneous case, returning status code 0. From my side, if JSON response includes a status code of 0, I blindly handle it as an error and throw an exception. This is because a status code 0 may imply that either there are faulty parameter values or the address has no transactions.
For example:

Request 1 originally returns status code 1
Request 2 originally returns status code 0, thus it is handled as an error by this package

Hello, I have been experiencing the same problem over and over again. I tried to tome up with different try-excepts, unfortunately none of them worked. Is it possible that you can write a try except code to avoid this assertion error? Thank you.

Hello, I have been experiencing the same problem over and over again. I tried to tome up with different try-excepts, unfortunately none of them worked. Is it possible that you can write a try except code to avoid this assertion error? Thank you.

async def getTransferHistory(address, firstBlock, lastBlock):
try:
async with BscScan(YOUR_API_KEY) as bsc:
return await bsc.get_bep20_token_transfer_events_by_address(address, firstBlock, lastBlock, 'asc')
except Exception as E:
if str(E) == '[] -- No transactions found':
return []
else:
print(f'Cannot request history from {firstBlock} to {lastBlock} due to {E}')


Fix Jest Async Warning

Issue summary
A Jest warning occurs when testing async functions.
Other research suggests that jest mocked timers need to be used but experimentation showed that this causes other issues with exceeding jests timeouts (test never finished).
Expected behavior
This warning should not appear (see below).
ReferenceError: You are trying to import` a file after the Jest environment has been torn down.
  at StreamProxy.Readable (../node_modules/duplexify/node_modules/readable-stream/lib/_stream_readable.js:179:22)
  at StreamProxy.Duplex (../node_modules/duplexify/node_modules/readable-stream/lib/_stream_duplex.js:67:12)
  at new Duplexify (../node_modules/duplexify/index.js:40:17)
  at new StreamProxy (../node_modules/@google-cloud/firestore/node_modules/google-gax/src/streamingCalls/streaming.ts:90:5)
  at StreamingApiCaller.init (../node_modules/@google-cloud/firestore/node_modules/google-gax/src/streamingCalls/streamingApiCaller.ts:46:12)`

{Fill in here}
Steps to reproduce (including any preconditions)
run npm test in the root directory on the branch corresponding to #33.

Your environment
Include version numbers

OS: {ChromeOS}
Browser: {Chrome}

Likely not relevant anymore.


Any plans for upgrading to Grafana 9?

Hi there,
are there any plans for upgrading this prometheus-boshrelease to a newer grafana version (e.g. version 9) or will this repo stay on the grafana 7.x.y version?
Thanks!

Hi @nrekretep ,
I myself am not quite sure about if we can use that new grafana version (due to the new license) in here, that is the reason I did not bump it so far.
:-/

Hi @benjaminguttmann-avtq ,
thank you for answering my question. The licensing of open source software still seems to be uncertain territory especially when it comes to AGPLv3.
There is a blog post with Q&A about the license change (https://grafana.com/blog/2021/04/20/qa-with-our-ceo-on-relicensing/). I am not sure if bosh-prometheus falls into the same category as the question about "Cloud Foundry", but maybe it helps to clarify things.

Grafana 7.x is now EOL and not receiving security fixes for the likes of https://grafana.com/blog/2022/09/20/grafana-security-releases-new-versions-with-moderate-severity-security-fixes-for-cve-2022-35957-and-cve-2022-36062/

That's a good point. After some searching I wasn't able to find an official EOL policy for grafana. There are some posts according to which there is a n -1 support policy.
This would mean that with the release of grafana 9.x the support for grafana 7.x has ended.
From the above mentioned cve it is hard to tell, at least for me, if there will never be any new security fixes in grafana 7.x or if this cve just does not exist in grafana 7.x and therefore does not need fixing.
But nevertheless eol of 7.x is around the corner or has already arrived and there should be a statement about how this project will handle this.

I will try to look into this issue next week. Current plan would be to release one version with Grafana 8 first and then another one with Grafana 9.

We just released a new release including Grafana8 from here we will soon proceed to Grafana9.

@nrekretep @risicle happy to announce that within v28.0.0 we bumped Grafana to v9.


add additional columns to CopySource

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month: Next month
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month: Next month
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[x] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit (including refactoring) and then push new changes, including version updates, in separate commits.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

I created this pull request to solve this issue and this PR

Service owner @idear1203 to take a look

@vietanh85 Status update: the request is being relayed to the appropriate owner. Will let you know when there's an update from them. Thanks!

This looks like a change to data-plane APIs only, so doesn't need ARM review. The label was added because you filled out the control plane section of the questionnaire. I'll remove the WaitForARMFeedback label: please add it back if I've overlooked the control plane changes.


CMC high ram usage?

I lowered ram from 52gb to 32gb and it revealed that old gen GC is a big problem. Every time it runs it's a guaranteed 7 second lag spike. At 52gb of ram it runs every several hours, at 32gb of ram old gen GC runs every few minutes.
I think CMC was shown to be contributing, so does CMC use large amounts of ram?
https://timings.aikar.co/?id=e525712974db4306890f08dc66caef64
https://spark.lucko.me/yEFYhtq5wF

What happens if we reduce the ram even more, to like 20-24gb? This would result in GC pauses happening more often, but being shorter. If the ram is being shorter, the pauses should be short enough as to be unnoticeable.

I don't think it would work, the server regularly pushes upwards of 12gb of ram into old gen, which means something is using very large amounts of ram. Considering regular minecraft servers recommend 10 players per 1gb of ram, we have plugins using gigantic amounts of ram. Shortening it would cause GC to occur more frequently, but it would still cause lag spikes, just more small ones instead of less big ones

To expand on the thought of reducing the RAM, what I've always heard is that java's GC doesn't work well having a large abundance of RAM. If it has an abundance, it will get "lazy" and will stop freeing memory. It then will eventually reach the upper limit of the RAM it was given, and then have to do a massive stop the world sweep.

So here's a couple examples with 52gb ram https://timings.aikar.co/?id=98637e51acbe4e718f8539463f02cf24 and https://timings.aikar.co/?id=5f4171dff38e4f8f82244914815993ab with one 7.3 second GC every 5 hours lets say (if I'm reading it correctly). Compared to the above, which is 4.7 second every 12 minutes. So the time to GC reduced by 35% while the time between GC reduce by 96%. I think that shows that even if we GC more often, the time it takes to do it each time is not reducing enough to eliminate the lag

Have you tried switching to ZGC (https://wiki.openjdk.java.net/display/zgc/Main) ? I experimented a bit with it a while ago and ran into some issues, but those should be fixable. I'd expect this to be the biggest improvement you can get in comparison to effort required.
Debugging memory consumption past that would require analyzing a memory dump of the running server (last time I tried making one of those it killed the server, so careful), which contains all kinds of sensitive information (not only ingame stuff, but also database passwords, tokens etc.), so the list of people who could do that is not too long.

That being said, why would we run on only 32 GB of RAM? Seems like too little for our use case.

Just a test to see how the old gen GC would respond, and it still took longer than expected each time. We may be able to do a memory dump now, the new server hardware is much beefier

Can you take a memory snapshot and see what types of objects are using the most RAM?

So here's before, during, after an old gen GC, roughly
https://spark.lucko.me/71jp1mwAQw
https://spark.lucko.me/dmtA2CngXX
https://spark.lucko.me/0Lmp9USC6a

At 70 players, the server is clearing 20gb out of young gen memory every minute with 70-100ms each, and doing old gen gc every 10 minutes at 7 seconds. So memory usage and GC take a big strain on the server at high player count

I don't know if it's related, but CMC throws constant thread dumps which also lock up the server. May or may not be related to RAM usage. See #99

Looks like ZGC was only initially released on JDK11 and it has gotten a lot of improvements over time to JDK16. So I suggest we wait to try ZGC until we move to Java 16, as on Test ZGC is much rougher than G1GC with Java11

This issue with Old Gen GC was entirely due to keeping jukealert logs in memory and was resolved by removing the logs from memory


Populating context.version with gcp stackdriver logging

Currently running a number of Spring Boot 2 services on GKE.  Logging is using spring-cloud-gcp logging and CONSOLE_JSON output.
Although I can't see it mentioned anywhere in Spring Cloud GCP docs, the fact that you are using structured JSON means you get very nice OOTB integration with Stackdriver Error reporting, since it cleanly processes the stacktraces in the message field.
However I don't see how to populate the version field that the stackdriver uses for the context.  It would be extremely useful to be able to do so.  It just gets auto-populated with gke-instances all the time, rather than the particular service and version that we would like.
I can't see any mention however of the context when stackdriver logging is being used with the json format here
https://github.com/spring-cloud/spring-cloud-gcp/blob/master/spring-cloud-gcp-autoconfigure/src/main/resources/org/springframework/cloud/gcp/autoconfigure/logging/logback-json-appender.xml
Is this something that can be supplied via the logging interface, and if so how? or can it only be done via the direct API to stackdriver errors?

Here's the definition of a LogEntry as far as Stackdriver Logging is concerned. We should be able to pass all of its parts through JSON. However, I don't see a version property anywhere. Can you show an example log entry with the "version" field that you're interested in passing.


🐛 Terraform 1.6.0 crashing

Describe the bug.
Terraform 1.6.0 crashes during validation causing workflows to fail
Run terraform validate -no-color
/home/runner/work/_temp/866eec23-03e0-4353-97fb-997b1903301e/terraform-bin validate -no-color

!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!

Terraform crashed! This is always indicative of a bug within Terraform.
Please report the crash with Terraform[1] so that we can fix this.

When reporting bugs, please include your terraform version, the stack trace
shown below, and any additional information which may help replicate the issue.

[1]: https://github.com/hashicorp/terraform/issues

!!!!!!!!!!!!!!!!!!!!!!!!!!! TERRAFORM CRASH !!!!!!!!!!!!!!!!!!!!!!!!!!!!

Source: https://github.com/ministryofjustice/data-platform/actions/runs/6454061276/job/17559133154?pr=1801#step:11:18
To Reproduce

Run a Terraform component with 1.6.0 binary

Expected Behaviour
Terraform steps do not crash
Additional context
We saw this behaviour while working on Modernisation Platform, the workaround was to pin at 1.5.7
@dms1981 raised this with Hashicorp (https://github.com/hashicorp/terraform/issues/33988 closed as dupe of https://github.com/hashicorp/terraform/issues/33977)

We've now merged some fixes that will be coming in the forthcoming v1.6.1 release.

As per https://github.com/hashicorp/terraform/issues/33977#issuecomment-1751060831

https://github.com/hashicorp/terraform/releases/tag/v1.6.1 is now released which fixes this


Document that hosted packages shouldn't have git dependencies

This is a warning when uploading, but it's not documented on the site.

This issue has been moved to dart-lang/pub#392.


RelativePosition needs a referernce point field

This indicates what point of the device is the coordinate for. There is a rig coordinate system already, but we need to know (e.g.) if the camera position is the center of the lens or the corner of the camera. Required field, string.

duplicate


GUACAMOLE-736: Remove JAXB data conversion in favor of Guava

This pull request replaces all of the instances of DatatypeConverter from the deprecated java.xml.bind package with the equivalent Guava packages from the BaseEncoding class(es).
I've tested the following items:

Log in with JDBC
Log in with RADIUS, including 2FA
Start SSH connection

These tests have worked fine.  There are probably a couple of other corner cases that need to be tested - I have no way of testing the Duo module, TOTP should probably be validated, and changing passwords in JDBC should be verified, as well.  But, initial tests look good.

Seems guava library is used only for base64 encoding/decoding. Why not use Apache Commons Codec for that instead?

@keers: Actually, it's used for several Hex (base-16) operations, as well.  I went with Guava because it's used in other places in the project, so it just keeps it simple and consistent.


docs(readme): Add getting started docs

Add documentation for installing and using Porject Calavera
fix #8

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Autocomplete shows incorrect syntax for Input request

I found a bug when i was writing code to rename an uploaded file before saving in a dir. I noticed the autocomplete shows me 2 "move". As you can see in screenshot 1. After selecting the second "move", it shows me something else, as you can see in screenshot 2.
Screenshot 1

Screenshot 2

I don't see the relation to this package, what am I missing?
I can barely see that the referenced class is "Requests\BannerRequest"??
This seems to reference a concrete class and not a facade so this isn't directly subject to anything this package provides?
Rather it looks like a confused auto-complete.
@barryvdh looks like an old support issue, I vote for closing :}


VirtualizedLists should never be nested inside plain ScrollViews with the same orientation - use another VirtualizedList-backed container instead.

This warning is showing when I'm using FlatList inside ParallaxScrollView, is there anyway to fix this or i'm doing something wrong?
Here's the code that I'm using, everything is working fine as expected, just the warning keep showing.
    <View style={styles.container}>
      <ParallaxScrollView
        backgroundColor="blue"
        parallaxHeaderHeight={HeaderHeight}
        renderBackground={() => (
          <ExploreHeaderBackground customSource={CatAsset[secondary.imgName]} />
        )}
        renderForeground={() => (
          <ExploreHeader headerShown customTitle={secondary.name} customDescription="" />
        )}>
        <FlatList
          data={items}
          renderItem={({ item }) => <ExploreListingCell poi={item} />}
          keyExtractor={(item) => item.storeId}
        />
      </ParallaxScrollView>
    </View>

facking the same issue

facing the same issue

Getting this warning as well. This https://github.com/GeekyAnts/NativeBase/issues/2947#issuecomment-583884268 comment seems to indicate that in most cases it should be OK.

I actually have found a fix for this, you can put your FlatList into the renderScrollComponent and the warning is gone, probably it replace the default ScrollView with the FlatList itself so there won't be problem:
const AnimatedFlatList = Animated.createAnimatedComponent(FlatList);

return (
<ParallaxScrollView
          backgroundColor="white"
          parallaxHeaderHeight={HeaderHeight}
          renderBackground={() => (
              <ExploreHeaderBackground customSource={CatAsset[secondary.imgName]} />
          )}
          renderForeground={() => (
            <ExploreHeader headerShown customTitle={secondary.name} customDescription="" />
          )}
          renderScrollComponent={(props) => (
            <AnimatedFlatList
              {...props}
              ListHeaderComponent={
                <ExploreHeader headerShown customTitle={secondary.name} customDescription="" />
              }
              data={items}
              renderItem={renderItem}
              keyExtractor={(item) => item.storeId}
            />
          )}
        />
)

same issue


Mapproxy restart multiple times at startup

Context

When executing the mapproxy-util serve-develop {conf-file}.yaml command, the service is restarted one or more times, so the configuration file is read at least twice. Therefore the service startup time is increased.
Expected Behavior

The mapproxy service should be started only once.
Actual Behavior

When the service starts, the following message appears: mapproxy.config - INFO - reading: path/to/conf-file.yaml
When it finishes it shows that the service is running on localhost:8080 but when it starts the message "Restarting with reloader" appears, and again reads the configuration file:
[2024-04-01 12:11:56,650] mapproxy.config - INFO - reading: /path/to/conf.yaml
[info]  * Running on http://<IP_ADDRESS>:8080/ (Press CTRL+C to quit)
[info]  * Restarting with reloader
[2024-04-01 12:12:21,102] mapproxy.config - INFO - reading: /path/to/conf.yaml

Possible Fix

Steps to Reproduce

Create a configuration file containing several layers
Execute the command "mapproxy-util serve-develop {conf-file}.yaml"
Observe the log and check how many times the file is read

Context

The objective is that the service is not restarted, in order to reduce the time required for the service to be started up.
Your Environment

Version used: MapProxy 1.16
Environment name and version: Python 3.10
Server type and version:
Operating System and version: Ubuntu

The first reading in of the configuration happens when creating the app here:
https://github.com/mapproxy/mapproxy/blob/master/mapproxy/script/util.py#L85
Then it is later restarted with reloading here:
https://github.com/mapproxy/mapproxy/blob/master/mapproxy/util/ext/serving.py#L406
To change this we would have to change all the calls in the chain to not pass along an app, but only the configuration. This might cause problems with other calls of these functions. I think it might be quite the hassle to change this.


Fixing typo in paths.py

Fixed little typo in the file paths.py:
-        raise LookupError('Multipue paths found for {0}.  Found `{1}`'.format(
+        raise LookupError('Multiple paths found for {0}.  Found `{1}`'.format(

The travis failures are due to a recent update to the linting library used to check the code.
I will also (light heartedly) point you to a very important guideline from the CONTRIBUTING.md for this project.  https://github.com/pipermerriam/flex/blob/master/CONTRIBUTING.md#cute-animal-pictures
Cute animal pictures are an important part of the pull request process.  Might I suggest googling "unlikely animal friends".

If you rebase off of https://github.com/pipermerriam/flex/pull/54 or wait a few minutes for it to land in master, this should be fixed (the linting errors)


Flash Cards

Description 📜
Flash Cards based game, for you remember your subjects in more detail.
Fixes #1081

Type of change 📝
Please delete options that are not relevant. And in order to tick the check box just put x inside them for example [x] like this

[x] Add a new project

Domain of Contribution 📊
Please delete options that are not relevant. And in order to tick the check box just put x inside them for example [x] like this

[x] Project using HTML, CSS & JS

Checklist ✅
Please delete options that are not relevant.And in order to tick the check box just but x inside them for example [x] like this

[x] I have performed a self-review of my own code or work.
[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GSSoC'22 contributor

Screenshots / Gif (Recommended) 📸
https://user-images.githubusercontent.com/82095877/166245521-11970516-275e-481c-b4fa-d9cb6d48cb1b.mp4

@gurjeetsinghvirdee please review this PR.

@gurjeetsinghvirdee please review this PR.

Readme issue vps pdhle ek baar

@gurjeetsinghvirdee please review this PR.

Readme issue vps pdhle ek baar

kya matlab

#1102

#1102

Ok... I won't make any pr until tomorrow now, jab Tera man kre review kr dena

#1102

Ok... I won't make any pr until tomorrow now, jab Tera man kre review kr dena inko


Add configuration options for status messages

Configuration for status messages
This PR introduces configuration options to provide custom status messages to be shown when Run On Save starts, finishes and individual commands are being run. I see multiple use cases for this feature.

More customizability

Allows users with small screens to shorten the status messages
Allows users to remove the status message shown when the commands have finished running

Better user feedback

The user getting feedback on how long a command takes relative to other ones
Progress-indication when multiple commands are being run (e.g. when an external formatter or linter has run)

All new configuration options are optional. This PR retains the old status messages as the default.
Examples
Simple
To show the functionality by example: This will show Starting to sleep... for one second, I am sleeping again! for another second and finally Done sleeping!. Technically, Starting to sleep... could have been the message for the first command to achieve identical behavior.
"emeraldwalk.runonsave": {
    "messages": {
        "running": "Starting to sleep...",
        "done": "Done sleeping!"
    },
    "commands": [
        {
            "cmd": "sleep 1",
        },
        {
            "cmd": "sleep 1",
            "message": "I am sleeping again!"
        }
    ]
}

Empty idle message
This example shows a status message when a Ctags generator for Haskell files is being run and shows nothing otherwise.
"emeraldwalk.runonsave": {
    "messages": {
        "running": "",
        "done": "",
    },
    "commands": [
        {
            "match": ".hs",
            "cmd": "/root/.local/bin/hasktags -c /workspace/src/",
            "message": "Running hasktags..."
        }
    ]
}

Thoughts @bmingles ?

@phagenlocher Thanks for the PR. I like this idea. I'm in the process of refactoring some more fundamental pieces of how commands are run. I'm going to incorporate a slightly modified version of your idea in this PR https://github.com/emeraldwalk/vscode-runonsave/pull/98/files#diff-6bfea2ec3c1d21c90d6e1ecd704f380a6eeb44521e1da1a87b6a48ea691b6a43
More specifically I want to support this interface at both the top level + cmd level config:
export interface IMessageConfig {
  message?: string;
  messageAfter?: string;
  showElapsed: boolean;
}

Closing as a duplicate of work that will be done on aforementioned PR


Add gate name setter

What
Adds a setter/getter for the Instruction.name attribute (in a backwards compatible manner)
Why
When changing name directly ideal gate does not change accordingly - Closes #233
How
Implemented getter/setter and changed current name attribute to be _name. Also made the exporting/importing still work with this change.
Remarks
Should not break anything and be totally transparent.
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

[x] Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
[x] Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
[x] Type Annotations - All new code has been type annotated in the function signatures using type hints
[x] Docstrings - Docstrings have been provided for functions in the numpydoc style
[x] Documentation - The tutorial style documentation has been updated to explain changes & new features
[x] Notebooks - Example notebooks have been updated to incorporate changes and new features
[x] Changelog - A short note on this PR has been added to the Upcoming Release section

Any idea why this test would fail? It says it fails on test_noise_devices but when I run it locally, using Py3.7 and both independently and as part of the whole test suite, it works fine.


Update the TBI test to be conditional on the arm64 code generator instead of targeting arm64.

Update the TBI test to be conditional on the arm64 code generator instead of targeting arm64.
This ensures that we run the test during normal PR testing and hopefully ensures
I never have to fix this test again = ).
rdar://24370377

@swift-ci smoke test and merge


I am going to conduct local testing. Is there any official website recommended?

Why you need it?
Is your feature request related to a problem? Please describe in details
How it could be?
A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.
Other related information
Add any other context or screenshots about the feature request here.

run sample testing？https://github.com/fescar-group/fescar-samples

I am going to deploy the fescar-server to the Linux server for testing. I don't know if fescar-server has high requirements for cpu and memory. Is there a recommended host configuration?

Beside, Could I deploy fescar-server based on the docker container

Beside, Could I deploy fescar-server based on the docker container

https://github.com/fescar-group/fescar-docker

I am going to deploy the fescar-server to the Linux server for testing. I don't know if fescar-server has high requirements for cpu and memory. Is there a recommended host configuration?

2G mem?


refactor: Bump deps on @fluidframework/eslint-config-fluid to 2.0.0 in client packages and fix linter violations

Note: @fluidframework/eslint-config-fluid's default export was updated from minimal to recommended.
i.e...

A config extends change from "@fluidframework/eslint-config-fluid" to "@fluidframework/eslint-config-fluid/minimal" indicates no config variant change (it continues to extend "minimal" as it did before).
No config extends change indicates that the package's config was promoted from "minimal" to "recommended".

Strategy taken:

If packages satisfy recommended config (new default), let them passively upgrade base config.
If violations against recommended in a package are fairly minimal, clean them up and let them passively upgrade base config.
Otherwise, explicitly use minimal config (previous default).

This PR also...

removes now-unneeded rule overrides in package-local configs.
cleans up a number of unneeded eslint-disable directives across the codebase.

Primarily removes max-len disables, as that rule is now globally removed in favor of prettier.

Packages upgraded from minimal to recommended

packages/common/driver-definitions
packages/dds/counter
packages/dds/test-dds-utils
packages/drivers/odsp-urlResolver
packages/framework/tinylicious-driver
packages/framework/oldest-client-observer
packages/framework/test-client-utils
packages/framework/view-adapters
packages/framework/view-interfaces
packages/runtime/container-runtime-definitions
packages/test/test-driver-definitions
packages/test/test-gc-sweep-tests
examples/data-objects/canvas
examples/data-objects/monaco
examples/data-objects/multiview/constellation-model
examples/data-objects/multiview/coordinate-model
examples/data-objects/multiview/plot-coordinate-view
examples/data-objects/multiview/slider-coordinate-view
examples/data-objects/multiview/triangle-view
experimental/examples/bubblebench/baseline
experimental/examples/bubblebench/common
experimental/framework/get-container
experimental/framework/last-edited
experimental/PropertyDDS/examples/schema

Everything seems to be good in experimental. One quick question is require.resolve("@fluidframework/eslint-config-fluid"), "prettier" is persisted in some of the files:

examples/data-objects/canvas
examples/data-objects/monaco
examples/data-objects/multiview/constellation-model
examples/data-objects/multiview/container
examples/data-objects/multiview/coordinate-model
examples/data-objects/multiview/plot-coordinate-model
examples/data-objects/multiview/triangle-view
experimental/examples/bubblebench/baseline
experimental/examples/bubblebench/common
experimental/framework/get-container
experimental/framework/last-edited
packages/dds/counter
packages/drivers/tinylicious-driver
packages/framework/oldest-client-observer
packages/framework/test-client-utils
packages/test/test-driver-definitions
packages/test/test-gc-sweep-tests

Everything seems to be good in experimental. One quick question is require.resolve("@fluidframework/eslint-config-fluid"), "prettier" is persisted in files:

examples/data-objects/canvas
examples/data-objects/monaco
examples/data-objects/multiview/constellation-model
examples/data-objects/multiview/container
examples/data-objects/multiview/coordinate-model
examples/data-objects/multiview/plot-coordinate-model
examples/data-objects/multiview/triangle-view
experimental/examples/bubblebench/baseline
experimental/examples/bubblebench/common
experimental/framework/get-container
experimental/framework/last-edited
packages/dds/counter
packages/drivers/tinylicious-driver
packages/framework/oldest-client-observer
packages/framework/test-client-utils
packages/test/test-driver-definitions
packages/test/test-gc-sweep-tests

@jikim-msft Can you elaborate on the question? I'm not sure I understand what you mean.


[Feature]: Drop unmaintained dependency exit

🚀 Feature Proposal
The package exit which @jest/core and @jest/reporters depend on has various issues according to: https://socket.dev/npm/package/exit
The last version published was 9 years ago and it has no license.
Motivation
Remove unmaintained dependencies and modernize codebase.
Example
No response
Pitch

What issues? If the module works, it being "unmaintained" is not an issue.
Missing license is more of an actual issue, but we've used exit for almost 5 years without anyone reporting it until now, so I'm inclined to say it's not proving to be an issue in practice.

My assumption was that the Node ecosystem would have progressed in the last 9 years so that exit is not needed anymore since there would be native functionality for it or the problem it was created for is not a problem anymore.
I guess it's fine to keep it since exit doesn't have any outdated dependencies on its own which would create potential incompatibilities.

Still an issue today. Workaround is slightly cleaner tho, so might be worth replacing: https://github.com/nodejs/node/issues/6379.

Its an MIT license just not in the package.json correctly. https://github.com/cowboy/node-exit/blob/master/LICENSE-MIT

Might make sense to keep this issue around rather than have the bot autoclose it.


Fix ChannelCheckoutTimeout with PublisherConfirms

Resolves https://github.com/spring-projects/spring-amqp/issues/999
Logical and physical closure of PublisherConfirmChannels is deferred
until the acks have been received.
When using a fixed cache, via channelCheckoutTimeout, the permits
must not be released until the channel is actually returned to the cache
(logical) or closed (physical).
backport will be required after merge due to refactoring

I'll submit another PR after review/merge.

Nothing to complain about.
Please, issue a backport PR.
Thanks


k3s check-config fails on MicroOS DVD

By default, the MicroOS DVD installer installs busybox-gzip instead of gzip and this breaks k3s check-config.
Output of k3s there: k3s.txt
Environmental Info:
K3s Version:
k3s version v1.27.6+k3s1 (bd04941a)
go version go1.20.8

Node(s) CPU architecture, OS, and Version:
Linux microos 6.5.6-1-default #1 SMP PREEMPT_DYNAMIC Fri Oct  6 11:20:48 UTC 2023 (c97c2df) x86_64 x86_64 x86_64 GNU/Linux

Cluster Configuration:
Single node cluster
Describe the bug:
With busybox-gzip in place, the k3s check-config script appears to be broken. With gzip installed instead, it works nicely.
We believe the usage of zgrep in https://github.com/k3s-io/k3s/blob/master/contrib/util/check-config.sh#L36 might be the culprit.
Steps To Reproduce:

On MicroOS, check that busybox-gzip is installed (this is the default for the MicroOS DVD)
Install k3s
Start the node
Run k3s check-config

Expected behavior:
k3s check-config runs normally
Actual behavior:
k3s check-config is not able to perform any checks.
Additional context / logs:

See https://bugzilla.opensuse.org/show_bug.cgi?id=1215943
Failing openQA test runs, e.g. https://openqa.opensuse.org/tests/3636499#step/podman_pods/200

EDIT: It was stated previously that this applies to Tumbleweed. No, it applies to MicroOS (DVD).

Hey @brandond - the full error output is here: https://github.com/k3s-io/k3s/files/12869261/k3s.txt. Let me know if you need something more.
I cannot tell you why the decision for busybox-gzip was made, I can only say that on a fresh Tumbleweed host using the DVD installation, k3s check-config fails: https://openqa.opensuse.org/tests/3642422#step/podman_pods/203

Due to the nature of my installation from the zypper package for busybox utils https://software.opensuse.org/package/busybox I needed to alias gzip="busybox gzip " in order to try and reproduce this on aws the default tumbleweed AMI does not have that version of gzip so I rm'd that sudo rm /usr/bin/gzip before installing the busybox package and creating the alias to attempt to reproduce.
$ kgn
NAME               STATUS   ROLES                       AGE     VERSION
ip-1-1-1-158       Ready    control-plane,etcd,master   4m27s   v1.27.6+k3s1

$ kgp -A
NAMESPACE     NAME                                     READY   STATUS      RESTARTS   AGE
kube-system   coredns-77ccd57875-9dwkl                 1/1     Running     0          4m14s
kube-system   helm-install-traefik-crd-r8bgp           0/1     Completed   0          4m15s
kube-system   helm-install-traefik-h9gs5               0/1     Completed   1          4m15s
kube-system   local-path-provisioner-957fdf8bc-bnwps   1/1     Running     0          4m14s
kube-system   metrics-server-648b5df564-fn2zp          1/1     Running     0          4m14s
kube-system   svclb-traefik-a2bc200f-nbql8             2/2     Running     0          3m57s
kube-system   traefik-64f55bb67d-b9l65                 1/1     Running     0          3m57s

$ sudo /usr/local/bin/k3s check-config
Verifying binaries in /var/lib/rancher/k3s/data/ab2055bc72380bad965b219e8688ac02b2e1b665cad6bdde1f8f087637aa81df/bin:
- sha256sum: good
- links: good

System:
- /usr/sbin iptables v1.8.7 (legacy): ok
- swap: disabled
- routes: ok

Limits:
- /proc/sys/kernel/keys/root_maxkeys: 1000000

info: reading kernel config from /proc/config.gz ...

Generally Necessary:
- cgroup hierarchy: cgroups Hybrid mounted, cpuset|memory controllers status: good
- apparmor: enabled and tools installed
- CONFIG_NAMESPACES: enabled
- CONFIG_NET_NS: enabled
- CONFIG_PID_NS: enabled
- CONFIG_IPC_NS: enabled
- CONFIG_UTS_NS: enabled
- CONFIG_CGROUPS: enabled
- CONFIG_CGROUP_PIDS: enabled
- CONFIG_CGROUP_CPUACCT: enabled
- CONFIG_CGROUP_DEVICE: enabled
- CONFIG_CGROUP_FREEZER: enabled
- CONFIG_CGROUP_SCHED: enabled
- CONFIG_CPUSETS: enabled
- CONFIG_MEMCG: enabled
- CONFIG_KEYS: enabled
- CONFIG_VETH: enabled (as module)
- CONFIG_BRIDGE: enabled (as module)
- CONFIG_BRIDGE_NETFILTER: enabled (as module)
- CONFIG_IP_NF_FILTER: enabled (as module)
- CONFIG_IP_NF_TARGET_MASQUERADE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_ADDRTYPE: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_CONNTRACK: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_IPVS: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_COMMENT: enabled (as module)
- CONFIG_NETFILTER_XT_MATCH_MULTIPORT: enabled (as module)
- CONFIG_IP_NF_NAT: enabled (as module)
- CONFIG_NF_NAT: enabled (as module)
- CONFIG_POSIX_MQUEUE: enabled

Optional Features:
- CONFIG_USER_NS: enabled
- CONFIG_SECCOMP: enabled
- CONFIG_BLK_CGROUP: enabled
- CONFIG_BLK_DEV_THROTTLING: enabled
- CONFIG_CGROUP_PERF: enabled
- CONFIG_CGROUP_HUGETLB: enabled
- CONFIG_NET_CLS_CGROUP: enabled (as module)
- CONFIG_CGROUP_NET_PRIO: enabled
- CONFIG_CFS_BANDWIDTH: enabled
- CONFIG_FAIR_GROUP_SCHED: enabled
- CONFIG_RT_GROUP_SCHED: missing
- CONFIG_IP_NF_TARGET_REDIRECT: enabled (as module)
- CONFIG_IP_SET: enabled (as module)
- CONFIG_IP_VS: enabled (as module)
- CONFIG_IP_VS_NFCT: enabled
- CONFIG_IP_VS_PROTO_TCP: enabled
- CONFIG_IP_VS_PROTO_UDP: enabled
- CONFIG_IP_VS_RR: enabled (as module)
- CONFIG_EXT4_FS: enabled (as module)
- CONFIG_EXT4_FS_POSIX_ACL: enabled
- CONFIG_EXT4_FS_SECURITY: enabled
- Network Drivers:
  - "overlay":
    - CONFIG_VXLAN: enabled (as module)
      Optional (for encrypted networks):
      - CONFIG_CRYPTO: enabled
      - CONFIG_CRYPTO_AEAD: enabled
      - CONFIG_CRYPTO_GCM: enabled (as module)
      - CONFIG_CRYPTO_SEQIV: enabled
      - CONFIG_CRYPTO_GHASH: enabled (as module)
      - CONFIG_XFRM: enabled
      - CONFIG_XFRM_USER: enabled (as module)
      - CONFIG_XFRM_ALGO: enabled (as module)
      - CONFIG_INET_ESP: enabled (as module)
      - CONFIG_INET_XFRM_MODE_TRANSPORT: missing
- Storage Drivers:
  - "overlay":
    - CONFIG_OVERLAY_FS: enabled (as module)

STATUS: pass

$ gzip --version //this bundled bin doesn't have help or version flags but it still prints it
BusyBox v1.36.1 () multi-call binary.

Usage: gzip [-cfkdt] [FILE]...

Compress FILEs (or stdin)

	-d	Decompress
	-c	Write to stdout
	-f	Force
	-k	Keep input files
	-t	Test integrity

##Environment Details
VERSION=v1.27.6+k3s1
Infrastructure

[X] Cloud

Node(s) CPU architecture, OS, and version:
Linux 5.14.14-2-default x86_64 GNU/Linux
PRETTY_NAME="openSUSE Tumbleweed"

Cluster Configuration:
NAME               STATUS   ROLES                       AGE     VERSION
ip-1-1-1-158       Ready    control-plane,etcd,master   4m18s   v1.27.6+k3s1

Config.yaml:
write-kubeconfig-mode: 644
debug: true
token: YOUR_TOKEN_HERE
profile: cis
selinux: true
protect-kernel-defaults: true
cluster-init: true

Steps

$ curl https://get.k3s.io --output install-"k3s".sh
$ sudo chmod +x install-"k3s".sh
$ sudo groupadd --system etcd && sudo useradd -s /sbin/nologin --system -g etcd etcd
$ sudo modprobe ip_vs_rr
$ sudo modprobe ip_vs_wrr
$ sudo modprobe ip_vs_sh
$ sudo printf "on_oovm.panic_on_oom=0 \nvm.overcommit_memory=1 \nkernel.panic=10 \nkernel.panic_ps=1 \nkernel.panic_on_oops=1 \n" > ~/90-kubelet.conf
$ sudo cp 90-kubelet.conf /etc/sysctl.d/
$ sudo systemctl restart systemd-sysctl
$ which gzip
$ gzip --version
$ sudo zypper update
$ sudo zypper install busybox
$ busybox gzip
$ vim .bashrc.d/glorified-aliases.sh //adding alias gzip="busybox gzip " //attention to the trailing space for additional args
$ gzip --version
$ sudo INSTALL_K3S_VERSION=v1.27.6+k3s1 INSTALL_K3S_EXEC=server ./install-k3s.sh
$ kgn //kubectl get nodes
$ kgp -A //kubectl get pods -A
$ sudo /usr/local/bin/k3s check-config
$ cat /etc/os-release

Results:

@grisu48 is busybox-gzip a package, or the binary name? What is the output of ls -la $(which gzip) and ls -la $(which zcat)?

Hey @brandond, sorry for the delay I was busy with other tasks.
I need to correct my initial statement, this is about MicroOS, not Tumbleweed. I updated the title and issue description accordingly.
On MicroOS by default busybox-gzip is installed, not gzip itself. As for the requested packages, all except zgrep are coming from busybox:
microos:~ # ls -la $(which gzip)
lrwxrwxrwx. 1 root root 7 Oct  9 07:42 /usr/bin/gzip -> busybox
microos:~ # ls -la $(which zcat)
lrwxrwxrwx. 1 root root 7 Oct  9 07:42 /usr/bin/zcat -> busybox
microos:~ # ls -la $(which zgrep)
-rwxr-xr-x. 1 root root 3806 Oct  9 07:42 /usr/bin/zgrep

Looks like the issue arises from using busybox on MicroOS.

The problem is likely because grep from busybox does not support --label=XYZ option.

The problem is likely because grep from busybox does not support --label=XYZ option.

this issue has been resolved.

The problem is likely because grep from busybox does not support --label=XYZ option.

this issue has been resolved.

https://openqa.opensuse.org/tests/3750096#step/podman_pods/201 shows that it is not, at least not in build 20231122:
# wait_serial expected: qr/QVGg3-\d+-/u
...
grep: unrecognized option: label=/proc/config.gz

The problem is likely because grep from busybox does not support --label=XYZ option.

this issue has been resolved.

https://openqa.opensuse.org/tests/3750096#step/podman_pods/201 shows that it is not, at least not in build 20231122:

IMHO, not a k3s issue at all - see: https://bugzilla.opensuse.org/show_bug.cgi?id=1215943
the 'zgrep' shipped as part of busybox-gzip assumes gnu gzip, but does not support busybox-gzip; A proposal fix was submitted, but not yet accepted by the maintainer

Agreed, let's not do a workaround in k3s for suse contributing distributions. We're going to fix this in microos


Enhanced instance manager CPU reservation

longhorn/longhorn#2207

I noticed that we need to use float numbers here. I am all for using an integer instead since it makes things easier. There isn't a big enough difference between 12% vs 12.5% worth our extra effort to deal with floating numbers IMO.

OK, I will update to integer instead.


Added missing semicolon

I know semicolons are not strictly necessary, but the rest of the page contains semicolon-terminated lines. This edit just maintains a consistent code style.

Thanks!


[nrf fromlist] drivers/flash/nrf_qspi_nor: fix for missing device dea…

…ctivation.
anomaly_122_init() and anomaly_122_uninit() procedures implement
proper activate and deactivate procedures which are required for
achieve low power consumption.
The real workaround for the anomaly is buried inside hal function
nrf_qspi_disable() is called indirectly by the anomaly_122_uninit().
Therefore anomaly_122_init/uninit should be called for any
nrf QSPI device.
This patch renames functions and make call to them mandatory.
This fixes increased power consumtion issue on nRF53 device when
qspi was used.
upstream PR

Do you want to have it in 2.0?

The commit was included into #811.

@nvlsianpu
I have checked that this commit can not fix the increased power consumtion issue on nRF52840.
It was fixed after applying https://github.com/zephyrproject-rtos/zephyr/pull/43895, but the power consumtion increases again after applying newer commits.
I am not sure if this issue is caused by introducing PINCTRL. We need to figure it out.

@caizelin Thats strange - this patch doesn't change any procedure for nRF52840. It just rename it and enables for all SoCs.


Switch F* grammar to a more up-to-date fork

Updated fstar grammar to support unpaired quotes ( ` ) in reveal_opaque calls
Description
Highlighting was broken spectacularily in files containing lines like
reveal_opaque (`%opaque_name) (opaque_name param);
reveal_opaque (`%opaque_name2) (opaque_name2 param2);

Checklist:

[x] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fraw.githubusercontent.com%2FFStarLang%2Fatom-fstar%2Fd7ee2f76a83b675392498ad0b0a0511d8310a30b%2Fgrammars%2Ffstar.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fraw.githubusercontent.com%2FFStarLang%2FFStar%2F9cdb3fb8275ff759a1c8fb2134542abbe7530e54%2Fulib%2FFStar.Monotonic.Pure.fst&code=
New: https://github-lightshow.herokuapp.com/?utf8=✓&scope=from-url&grammar_format=auto&grammar_url=https%3A%2F%2Fraw.githubusercontent.com%2Fhacklex%2Fatom-fstar%2Ff66854d0f229d08b42afe1231cb354e049604c8b%2Fgrammars%2Ffstar.cson&grammar_text=&code_source=from-url&code_url=https%3A%2F%2Fraw.githubusercontent.com%2FFStarLang%2FFStar%2F9cdb3fb8275ff759a1c8fb2134542abbe7530e54%2Fulib%2FFStar.Monotonic.Pure.fst&code=

Is anything wrong with my PR?

Tests failed since I've forgot to update README.md; fixed that :)

Can you please manually trigger the tests to re-run? It seems the tests were only executed about an hour ago (with the pull request being made almost a day ago)...

🤔 I've no knowledge of F*, but my gut's telling me there's a better way to fix the highlighting issue you've observed. What's so special about reveal_opaque, and what's the significance of backticks in F* Links to canonical references would help (I checked F*'s site, but couldn't find any formal specification for the language…)

You're correct that it probably should be further improved to include the most general case for that quote syntax.
However, currently linguist references the dead atom-fstar which is terribly outdated. This leads to disaster whenever reveal_opaque is used.
I've never seen any other usages of unpaired backtick in F*. The reveal_opaque is indeed quite special, as it gives the z3 prover access to otherwise hidden facts (hiding facts saves lots of resources for the prover and becomes vital when the proofs grow too complex).
The point is, in the current state, github renders large chunks of F* code as if they were a single binary operator.
I am positive that my fix isn't making anything worse, and is making rendering of 99% of reveal_opaque usage cases adequate.
Check out how the currently used grammar corrupts big files that use opaques :)
or, in short,
some code;
reveal_opaque (`%some_opaque) (some_opaque var1 var2);
some more code;
reveal_opaque (`%some_opaque) (some_opaque var1 var2);
(from here) the code (looks fine);

Alright. The updated grammar now treats the backtick character as a single-character operator, and thus we'll have no more problems with F* highlighting around quoted expressions. I consulted F* specialists in their slack chat, and we agreed that it would be the best solution.
What's important, is that with this fix, github will finally render F* source files properly.
Can we merge this? I'm okay with switching linguist back to the original atom-fstar repository as soon as they show any sign of being alive (by accepting or rejecting my pull request for example)...

They merged my pull request into the original atom-fstar repository.
This PR is updated accordingly.

@lildude Can you please review this?
I've contacted the guy who has the rights to merge atom-fstar PRs, and had him merge my grammar fix.
The only change in this PR is the atom-fstar submodule update (same source, most recent commit to master).
Without this fix, github highlighting of some FStar files is a disaster...
Thank you!

@lildude Can you please review this?

There's nothing to review or do other than close this PR as as the CONTRIBUTING.md states:

Once the bug has been fixed upstream, we'll pick it up for GitHub in the next release of Linguist.

Thanks for persisting with this.
Closing as we don't need this.

Oh. Okay... Sorry for persisting, but when is the next release of Linguist at least approximately?

I have no idea; when I find the time 😁. I've tried to keep things monthly in the past but my workload recently has meant I'm no longer able to keep up that cadence.

Oh. I see. Say, do you know how github grabs your releases? Is it automatical? Or perhaps it builds it on its own from your master branch?
Sorry for persistence. Just that F* highlighting is currently just one big mess and I'm sad that nothing more could be done :(


Psa support unicast and drop

Passes stf tests for drop-all and unicast

Codecov Report

Merging #4 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   74.48%   74.47%   -0.02%
==========================================
  Files         115      115
  Lines        9979     9979
==========================================
- Hits         7433     7432       -1
- Misses       2546     2547       +1

Impacted Files
Coverage Δ

src/bm_sim/learning.cpp
81.78% <0%> (-0.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b264bea...389a264. Read the comment docs.


[5.8] Improved naming convention consistency

This is similar to #26374

Added Name as the suffix to clarify that it's the "key" but not the "value" of the "key".

it should align to:
https://github.com/laravel/framework/blob/5.7/src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php#L1069-L1072
Also, the method relation actually override it's parent's one, which can cause problem when some one wants to call it's parent's relation method.
I'm not sure if the relationName should be implemented in all the Relation classes, but at least it should keep the naming convention consistency.
By the way, I have a use case when calling the \Illuminate\Database\Eloquent\Builder::whereHas method, because I'm getting the relation name programmatically if all Relation classes implement this relationName can be very helpful(it's really tricky to get the relation name from the relation object itself).

Just as a note, do not delete methods just like that, we should deprecate them for a version and delete them in the next one.

@jmarcher Thanks for mention! should I add the old one back..?

Just add it as an alias, and add the proper notations for example:
/**
 * Get the name of the relationship.
 *
 * @return string
 * @deprecated The getRelationName() method should be used instead. Will be removed in Laravel 5.9.
 */

@jmarcher Thanks a lot!!

No plans on introducing this breaking change for this reason.

@taylorotwell I just added the getRelation method back with the @deprecated notation, will that be good?

@yaquawa you can always try to resend the PR without the breaking change.


[jaeger-v2] Refactor ElasticSearch/OpenSearch Storage Configurations To Align With OTEL

Requirement
In this issue, we want to align the configuration for elastic search and open search storage with OTEL (part of https://github.com/jaegertracing/jaeger/issues/5229)
Problem

[x] All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
[x] Configs implement Validate()
[x] Configs via YAML support the same defaults as in jaeger-v1
[x] Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc.
[x] Configuration looks "logical" and properly grouped, not flattened with long weird names
[x] We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields

@yurishkuro is a migration guide needed here?

yes, certainly

@yurishkuro this is the current configuration we have
type Configuration struct {
	Servers                  []string               `mapstructure:"server_urls" valid:"required,url"`
	RemoteReadClusters       []string               `mapstructure:"remote_read_clusters"`
	Username                 string                 `mapstructure:"username"`
	Password                 string                 `mapstructure:"password" json:"-"`
	TokenFilePath            string                 `mapstructure:"token_file"`
	PasswordFilePath         string                 `mapstructure:"password_file"`
	AllowTokenFromContext    bool                   `mapstructure:"-"`
	Sniffer                  bool                   `mapstructure:"sniffer"` // https://github.com/olivere/elastic/wiki/Sniffing
	SnifferTLSEnabled        bool                   `mapstructure:"sniffer_tls_enabled"`
	MaxDocCount              int                    `mapstructure:"-"` // Defines maximum number of results to fetch from storage per query
	MaxSpanAge               time.Duration          `mapstructure:"-"` // configures the maximum lookback on span reads
	Timeout                  time.Duration          `mapstructure:"-"`
	BulkSize                 int                    `mapstructure:"-"`
	BulkWorkers              int                    `mapstructure:"-"`
	BulkActions              int                    `mapstructure:"-"`
	BulkFlushInterval        time.Duration          `mapstructure:"-"`
	Indices                  Indices                `mapstructure:"indices"`
	ServiceCacheTTL          time.Duration          `mapstructure:"service_cache_ttl"`
	AdaptiveSamplingLookback time.Duration          `mapstructure:"-"`
	Tags                     TagsAsFields           `mapstructure:"tags_as_fields"`
	Enabled                  bool                   `mapstructure:"-"`
	TLS                      configtls.ClientConfig `mapstructure:"tls"`
	UseReadWriteAliases      bool                   `mapstructure:"use_aliases"`
	CreateIndexTemplates     bool                   `mapstructure:"create_mappings"`
	UseILM                   bool                   `mapstructure:"use_ilm"`
	Version                  uint                   `mapstructure:"version"`
	LogLevel                 string                 `mapstructure:"log_level"`
	SendGetBodyAs            string                 `mapstructure:"send_get_body_as"`
}

Here are some groupings I see.
Sniffer

Enabled
TLS Enabled

Bulk Processing

Size
Num Workers
Num Actions
Flush Interval

Auth
Can be grouped under basic if we want to support more authentication types in the future

Username
Password
PasswordFilePath

Do you agree with the groupings above? Do you see any other groupings?

I wonder if we can get rid of these if we switch to data streams
UseReadWriteAliases
CreateIndexTemplates
UseILM

SendGetBodyAs - what are possible values? Should it be an enum?

SendGetBodyAs - what are possible values? Should it be an enum?

it looks to be all the http method types
// SetSendGetBodyAs specifies the HTTP method to use when sending a GET request
// with a body. It is GET by default.
func SetSendGetBodyAs(httpMethod string) ClientOptionFunc {
	return func(c *Client) error {
		c.sendGetBodyAs = httpMethod
		return nil
	}
}

I wonder if we can get rid of these if we switch to data streams
UseReadWriteAliases CreateIndexTemplates UseILM

what are data streams in this context?

@mahadzaryab1 Amazon described the data stream feature in this video:
https://www.youtube.com/watch?v=Mm3GFTt8wMA
I think this comes from ElasticSearch originally so the concept is probably the same.

@yurishkuro final PR is ready for review at https://github.com/jaegertracing/jaeger/pull/6090


Added additional tests for CA implementations and OIDC

Signed-off-by: Hayden Blauzvern<EMAIL_ADDRESS>
Summary

Ticket Link

Fixes
Release Note

Codecov Report

Merging #602 (8d28f70) into main (00d7e66) will increase coverage by 2.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   49.74%   52.51%   +2.77%
==========================================
  Files          21       22       +1
  Lines        1548     1588      +40
==========================================
+ Hits          770      834      +64
+ Misses        705      672      -33
- Partials       73       82       +9

Impacted Files
Coverage Δ

pkg/ca/ephemeralca/ephemeral.go
70.00% <0.00%> (ø)

pkg/oauthflow/oidc.go
100.00% <0.00%> (+50.00%)
:arrow_up:

pkg/ca/x509ca/common.go
60.52% <0.00%> (+60.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d7e66...8d28f70. Read the comment docs.

Review dismissal is far more aggressive now. I thought it had some tolerance for small nits...

Review dismissal is far more aggressive now. I thought it had some tolerance for small nits...

Allstarbot yelled at me so I had to change the setting to dismiss everything :(


Replace the serialization of the body with json httpclient option

In GenericHttpClient, The body is serialized with the format defined in the microservice configuration.
I suggest to remove this and let the json option of httpclient transform the body.
If we do this we can remove the serialiazer dependence
Wdyt?

The serialization format could be anything depending on the configuration. It could be JSON, JSON-LD, or even CSV.
I'm afraid that we can't delegate deserialization to the ResponseInterface::json method here.


secp256k1: configure with more feature flags

Motivation for this change
Closes #18637
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@chris-martin, are you still interested in the PR?

Oh yeah, sorry, I'll update this in a bit.

@chris-martin ping

@chris-martin, another friendly reminder

Sorry, I promise this is still on my to-do list!

@chris-martin no worries – I understand you ;)

Okay, updated!

Bumped to latest version
All flags are optional
Added JNI flag
Removed schorr flag (which apparently no longer exists)
Using autoreconfHook as suggested

Updated:

Removed , ...
Removed preConfigure = "./autogen.sh";

I think this should be ready to go now.


Feature Request: Support for format ibm.160 (8 sectors per track)

Can you add support for single sided 8 sector per track IBM MFM images?

Can you upload/attach a raw dump for me to look at? (eg gw read --tracks=c=0-39:h=0 a.scp)


Stack Traces

Use Lua's error function for bugs; use print and os.exit for our errors. Print stack traces for Lua errors.

Same as #2


help text for /api/stats

see https://github.com/infolis/infolis-web/issues/22
First draft. I think it would be good to add a brief description of what exactly "indexed fields" means.

How about

Indexed fields are those properties of a resource class that should be extra-fast to query for.

I added the list of indexed fields mostly for our benefit, to better understand why querying for one property can be so slow and fast for another.

Sounds good!


GUI freeze

Hi, I download trex-stateless-gui for windows. I tried to connect to my VM trex with the IP of the first interface (Management), but the soft freeze.
When it doesn't freeze, the connection doesn't work.
I use the trex-stateless-gui-3.1.2.
Best regards.
Victor

Please verify that you have running TRex server with latest version (v2.20)
Sudo ./t-rex-64 -i
Hanoh
Sent from my iPhone
On 10 Mar 2017, at 13:07, VictorJ <notifications<EMAIL_ADDRESS>wrote:
Hi, I download trex-stateless-gui for windows. I tried to connect to my VM trex with the IP of the first interface (Management), but the soft freeze.
When it doesn't freeze, the connection doesn't work.
I use the trex-stateless-gui-3.1.2.
Best regards.
Victor

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/cisco-system-traffic-generator/trex-stateless-gui/issues/2, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMbjvdC-7k4XTuW4APH7a3XGrhkErNWpks5rkS7ogaJpZM4MZQqE.

Hi,
Please try 3.1.2-SNAPSHOT u1 build.


Node.js  Loaders Team Meeting 2022-09-27

Time
UTC Tue 27-Sep-2022 18:00 (06:00 PM):

Timezone
Date/Time

US / Pacific
Tue 27-Sep-2022 11:00 (11:00 AM)

US / Mountain
Tue 27-Sep-2022 12:00 (12:00 PM)

US / Central
Tue 27-Sep-2022 13:00 (01:00 PM)

US / Eastern
Tue 27-Sep-2022 14:00 (02:00 PM)

EU / Western
Tue 27-Sep-2022 19:00 (07:00 PM)

EU / Central
Tue 27-Sep-2022 20:00 (08:00 PM)

EU / Eastern
Tue 27-Sep-2022 21:00 (09:00 PM)

Moscow
Tue 27-Sep-2022 21:00 (09:00 PM)

Chennai
Tue 27-Sep-2022 23:30 (11:30 PM)

Hangzhou
Wed 28-Sep-2022 02:00 (02:00 AM)

Tokyo
Wed 28-Sep-2022 03:00 (03:00 AM)

Sydney
Wed 28-Sep-2022 04:00 (04:00 AM)

Or in your local time:

https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+Loaders Team+Meeting+2022-09-27&iso=20220927T1800
or https://www.wolframalpha.com/input/?i=06PM+UTC%2C+Sep+27%2C+2022+in+local+time

Links

Minutes Google Doc: https://docs.google.com/document/d/10zlwHVLg_jqmaNrE8xVSXLmLMf620mILr6r3lWaqd-E/edit

Agenda
Extracted from loaders-agenda labelled issues and pull requests from the nodejs org prior to the meeting.
Invited

Loaders team: @nodejs/loaders

Observers/Guests
Notes
The agenda comes from issues labelled with loaders-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.
Joining the meeting

link for participants: https://zoom.us/j/97506450082

For those who just want to watch: https://www.youtube.com/c/nodejs+foundation/live

I'm on vacation until 04 Oct (and then away again 10–14 Oct)

No agenda, canceling.
Earlier this week I let the TSC know that we’re two in-progress PRs away from our milestone of getting the API to stable. They suggested dropping the experimental warning first, possibly in 19.0.0 if we’re ready in time, and then updating the docs a few months later.


TODO

Bunker Placement refinement
Bunker Healing
Bunker Loading
Wraith Functionality

Bunker loading should work on the bunkerPlacement branch now. I'm going to move away from "bunker placement refinement" for now and get back to it if we have time later. Also, there's a very high chance that the bunker loading is going to have some conflicts with the drop ship stuff so we're going to have to work that out later..... and figure out the actual build order.

Adding:
-Stop the units from running away when it sees the enemy
-Optimize mineral consumption
-Possibly include firebats in the bunkers

-Maybe find a way to reassign the drop ship squad to base defense if it's attacked?


Added java-cheatsheet.md

I update the cheatsheet by adding Collections in Java.
Thank You

That Sure looks Good 🚀