MKLDNN RNN training benchmark

Hi, I am writing a RNN traing benchmark, the details is that:
int layers = 1;
int direc = 1;
int gates = 4;
int num_states =2;
For forward:
the memory descriptors are:
x_md = memory::desc({ x_tz }, data_t, memory::format::tnc), x_tz = {seq_length_max, batch, feature_size};
y_md = memory::desc({ y_tz }, data_t, mkldnn::memory::format::tnc), y_tz = {seq_length_max, batch, direc*feature_size};
wh_md = memory::desc({ wh_tz }, data_t, memory::format::ldigo), wh_tz = {layers, direc, feature_size, gates, feature_size};
wi_md = memory::desc({ wi_tz }, data_t, memory::format::ldigo), wi_tz = {layers, direc, feature_size, gates, feature_size};
b_md = memory::desc({ b_tz }, data_t, mkldnn::memory::format::ldgo), b_tz = {layers, direc, gates, feature_size};
src_iter_md = memory::desc({ src_iter_tz }, data_t, memory::format::ldsnc), src_iter_tz = {layers, direc, num_states, batch, feature_size};
dst_iter_md = memory::desc({ dst_iter_tz }, data_t, memory::format::ldsnc), dst_iter_tz = {layers, direc, num_states, batch, feature_size};
And the memories are:
x_memory, y_memory, wh_memory,wi_memory, b_memory, src_iter_memory, dst_iter_memory

So for forward part:
 auto rnn_desc = rnn_forward::desc(prop_kind::forward_training, cell, rnn_direction::unidirectional_left2right, x_md, src_iter_md, wh_md, wi_md, b_md, y_md, dst_iter_md),
auto rnn_pd = rnn_forward::primitive_desc(rnn_desc, cpu_engine);
// create workspace memory
auto workspace_memory = memory(rnn_pd.workspace_primitive_desc());
std::vector<primitive> net_fwd;
net_fwd.push_back(rnn_forward(rnn_pd, x_memory, src_iter_memory, wh_memory, wi_memory, b_memory, y_memory, dst_iter_memory,  workspace_memory));

For backward:
the memory descriptors are:
// the weights format are different from forward weight
bwd_wi_md = memory::desc({ bwd_wi_tz }, data_t, memory::format::ldgoi), bwd_wh_tz = {layers, direc, gates, feature_size, feature_size}
 bwd_wh_md = memory::desc({ bwd_wh_tz }, data_t, memory::format::ldgoi), bwd_wi_tz = {layers, direc, gates, feature_size, feature_size};
diff_src_md = memory::desc({ x_tz}, data_t, memory::format::tnc);
diff_y_md = memory::desc({ y_tz }, data_t, mkldnn::memory::format::tnc);
diff_wh_md = memory::desc({ wh_tz }, data_t, memory::format::ldigo);
diff_wi_md = memory::desc({ wi_tz }, data_t, memory::format::ldigo);
diff_b_md = memory::desc({ b_tz }, data_t, mkldnn::memory::format::ldgo);
diff_src_iter_md = memory::desc({ src_iter_tz }, data_t, memory::format::ldsnc);
diff_dst_iter_md = memory::desc({ dst_iter_tz }, data_t, memory::format::ldsnc);
And the memories are:
bwd_wi_memory, bwd_wh_memory, diff_src_memory, diff_y_memory , diff_wh_memory, diff_wi_memory, diff_b_memory, diff_src_iter_memory, diff_dst_iter_memory

So for backward part:
auto bwd_desc = rnn_backward::desc(prop_kind::backward, cell, rnn_direction::unidirectional_left2right, x_md, src_iter_md, bwd_wh_md, bwd_wi_md, b_md, y_md, dst_iter_md, diff_src_md, diff_src_iter_md, diff_wh_md, diff_wi_md, diff_b_md, diff_y_md, diff_dst_iter_md);
auto bwd_pd = rnn_backward::primitive_desc(bwd_desc, cpu_engine);
std::vector<primitive> net_bwd;
net_bwd.push_back(rnn_backward(bwd_pd, x_memory, src_iter_memory, bwd_wh_memory, bwd_wi_memory, b_memory, y_memory, dst_iter_memory, diff_src_memory, diff_src_iter_memory, diff_wh_memory, diff_wi_memory, diff_b_memory, diff_y_memory, diff_dst_iter_memory, workspace_memory));

At last:
stream(stream::kind::eager).submit(net_fwd).wait();
stream(stream::kind::eager).submit(net_bwd).wait();
when I run the code, it aways has the following error:
status: 5 , message: could not create an RNN backward primitive descriptor.
I have checked the code many times, but I don't know how to solve the problem. I hope you can give me some suggestions. Thanks.

There has a bug according to https://github.com/intel/mkl-dnn/issues/305#issue-352465017, but I still have this error after using the latest master. Thanks.

Hi @zxb1489479870, the issue is with how you specify the dimensions of the weights on the backward pass.
In MKL-DNN, the dimensions passed to the memory descriptor creation are logical dimensions. For RNN weights, they should always be in ldigo layout. If you use bwd_wi_tz = bwd_wh_tz = {layers, direc, feature_size, gates, feature_size}, it should work.

It doesn't work even change the weights format to ldigo, I checked the lines https://github.com/intel/mkl-dnn/blob/f51304ad8087c0a3982ac023edd899db9f28baa3/src/cpu/cpu_rnn_pd.hpp#L207 and https://github.com/intel/mkl-dnn/blob/f51304ad8087c0a3982ac023edd899db9f28baa3/src/cpu/cpu_rnn_pd.hpp#L211,  there will set the weights format to ldgoi, it makes me confused.

Hi @zxb1489479870 , sorry my explanation was not clear enough.
In MKL-DNN, the way you specify the dimensions is not related to the datalayout. The dimensions are specified in a fixed order (sometimes refered to as logical layout), independantly of the datalayout (sometimes refered to as physical layout).
In the RNN weights case, the logical layout is ldigo and dimensions should be specified in that order.
So if you want weights in the ldigo physical layout, you would do

wi_tz = {layer, dir, feature_size, gates, feature_size}
auto wi_md = memory::desc({ wi_tz }, data_t, memory::format::ldigo);

and if you want weights in the ldgoi physical layout, you would use the same dimensions order as follow:

wi_tz = {layer, dir, feature_size, gates, feature_size}
auto wi_md = memory::desc({ wi_tz }, data_t, memory::format::ldgoi);

As you can see, in both cases wi_tz is exactely the same, only the physical layout changed.
My suggestion in you case will be to do the following:
 auto bwd_wh_tz = {layers, direc, feature_size, gates, feature_size};
 auto bwd_wi_tz = {layers, direc, feature_size, gates, feature_size};

 auto bwd_wi_md = memory::desc({ bwd_wi_tz }, data_t, memory::format::ldgoi);
 auto bwd_wh_md = memory::desc({ bwd_wh_tz }, data_t, memory::format::ldgoi);

Hi, @mgouicem, It works now, Thanks.


Update baseline-aks-content.md - Increased readability and adjusted s…

Increased readability and adjusted sentence structure.

Thanks for raising these articles to our attention. Unfortunately, copy edits need to be done internally to ensure that articles follow Microsoft style and formatting guidelines. We'll close this PR and submit the file for an internal copy edit.
#please-close


adds spaces to empty newlines in comments

rustfmt 0.99.6-nightly (750b252 2018-10-18)
I have code like this
fn main() {
    /*

    */
}

but rustfmt decided to add empty trailing spaces to line 3 so that if there was some text it would allign with the /* */ however the line is empty and nothing needs to be aligned there:
fn main() {
    /*

    */
}

diff --git a/src/main.rs b/src/main.rs
index a3c3244..03a1f8d 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,5 +1,5 @@
 fn main() {
     /*
-
+
     */
 }

I believe this did not happen a week or two ago.

This happens with the default rustfmt options (no extra settings/tweaks required)

I can't reproduce this with current master.

Ah, indeed, looks like the the rustfmt version shipped with rust nightly is almost a month old :confused: .


The ConfigForm saves some settings before the save and close button is clicked

Some settings in the ConfigForm (the checkbox ones) save every time its check changes state.
This can be pretty confusing to the user, as the Save and close button implies nothing is saved until that button is pressed.

Lako replied to me in DMs:

It's intentional so clicking X does the same as clicking close.
The original version of the config just said Close


Missing change log for VS Tools for Unity <IP_ADDRESS>

<IP_ADDRESS> was released last month, but the change log was never posted.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd09a24e-305b-bb2e-a8b5-9ea9c52fd8a4
Version Independent ID: 83bf7326-a96c-3bc4-a2ff-b1f510ea9308
Content
Content Source
Service: unspecified

Yes, I'm going to update the changelog. Thanks

Thanks for the quick turn around on this!


Option to create a new project

Received via internal bug feedback tool:

This is my second run trying out the Run Deploy and I figured it out so this screenshot isn't relevant but I think it'd be helpful if:

After you select a project and get an error message, you can select another one instead of just being stuck trying to fix payment options for that project
Be clearer about how to add a payment method and how much that payment will be. Just link to it more directly

tl;dr consider adding "New Project" option to the project selector, and handle billing errors in a more friendly way.

New Project option would certainly help.


MINIFICPP-2012 - Make free unconditional

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Awesome find :pray: thanks for digging this out.
Could you please add the explanation here or in the Jira how this could cause a memory leak?
Also adding a unit test like this somewhere could make it easier for reviewrs to verify the leak and the PR
(resolving the well-known SID-s leak 3 bytes of memory before your PR and 0 after that :+1: )

#ifdef WIN32
TEST_CASE("Check userIdToUsername for memory leak", "[OsUtilTests]") {
minifi::utils::OsUtils::userIdToUsername("S-1-0-0");
minifi::utils::OsUtils::userIdToUsername("S-1-1-0");
minifi::utils::OsUtils::userIdToUsername("S-1-2-0");
minifi::utils::OsUtils::userIdToUsername("S-1-2-1");
minifi::utils::OsUtils::userIdToUsername("S-1-3-0");
minifi::utils::OsUtils::userIdToUsername("S-1-3-1");
minifi::utils::OsUtils::userIdToUsername("S-1-3-2");
minifi::utils::OsUtils::userIdToUsername("S-1-3-3");
minifi::utils::OsUtils::userIdToUsername("S-1-3-4");
minifi::utils::OsUtils::userIdToUsername("S-1-4");
minifi::utils::OsUtils::userIdToUsername("S-1-5");
minifi::utils::OsUtils::userIdToUsername("S-1-5-80-0");
}
#endif


🌐 Language request: Czech

🌐 Language name (native)
Čeština
🌐 Language code
cs-CZ

I've added it to Crowdin. Thanks for your contribution :)


Filter FutureWarning: unhashable type

Temporary fix for the warnings coming from diffrax + jax 0.4.30.
~/miniconda3/lib/python3.11/site-packages/jax/_src/core.py:678: FutureWarning: unhashable type: <class 'jax._src.interpreters.partial_eval.DynamicJaxprTracer'>. Attempting to hash a tracer will lead to an error in a future JAX release.
  warnings.warn(

See also https://github.com/patrick-kidger/diffrax/issues/445.
Closes DYN-223.

Great, thanks for investigating 🙏


Problem with team updating

But I thank it's only with promo cards, I don't know, I only have 3 promo URs so...

Think* 😂

doesn't work for me either, can't update/change any teams at all, even just one member


fix: various minor fixes

📑 Description
Few fixes here and there:

not used code in MegaMenu
relative class change in Toggle
default value for href in Badge
tinted color support for Input
background color for List and ListItem
added OptsButton - like CloseButton but with 3 horizontal dots.

✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[x] All the tests have passed
[x] My pull request is based on the latest commit/version

ℹ Additional Information

Thank you for the PR. Merged.


Serial port support

I am wondering how can I connect the sn gateway to a serial port device ?

@hamdijmii1992  I don't quite catch your requirement. What protocol does the serial device talk with?


High inflate memory usage

Default size of tinfl_decompressor aka struct tinfl_decompressor_tag is > 8K.
This is problematic for embedded targets where every kilobyte counts.
What are the practical approaches to reducing the usage?
Empirically i found that reducing TINFL_FAST_LOOKUP_BITS brings down the size a lot, to about 2K.
Is it safe to do? Is there anything else that can be done to reduce the footprint?
(Yes, I am willing to trade CPU cycles for memory footprint)

Sorry, do not know this. Perhaps change it then run some tests? E.g. test.sh should cover it.

I encountered the same issue, where the memory footprint is even larger than LZMA. In this case, what is the significance of "mini" in "miniz"?

Hi, how did you solve the problem?

i have not. i must say, to get what essentially is a non-answer from the maintainer was a bit annoying.
it's now simmering on the back burner, waiting for the elusive "spare time".


Bot: Mint tweets

The twitter bot would have the ability to mint images people tweet but it could also have the ability to mint the tweet itself. This has potential for viral marketing. There's several examples of this existing in the wild such as:

https://twitter.com/tokenizedtweets

https://twitter.com/TweetsNft

https://v.cent.co/
https://eternal.report/

Each has a slightly different approach to minting. For example, a twitter user can mention @tokenizedtweets in a reply and include a wallet address / ENS domain / .crypto domain to transfer the archived tweet to the wallet. Valuables by Cent work by allowing people to bid on tweets while letting the creator of a tweet decide if they would like to mint it on the blockchain, making it a 1of1 autographed version.
One presentation format that might be interesting to explore is rendering a tweet as a 3D model. This could be a fun way to share tweets inside of a 3D world.

One could imagine a whole virtual trinkets store selling tokenized tweets like this. For this unique service, one could perhaps charge a fee of $5 for minting and rendering such tokens.

Along with this feature there should a gallery where you can explore the minted NFTs for sale or have recently sold.

This is a cool idea, but it seems less a core feature and more a new type of NFT to support.


Programming Exercise: Add solution and template participations to latest result endpoint

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I documented the Java code using JavaDoc style.

Motivation and Context

The /programming-exercise-participations/{participationId}/latest-result-with-feedbacks endpoint is used in the Themis app to retrieve student submissions in read-only mode (without performing assessment). The response coming from this endpoint did not contain solution and template participations. This prevented tutors from viewing solution and template repositories in read-only mode in Themis. This PR fixes the problem.
Description

Added a new @RequestParam withTemplateAndSolutionParticipations to getLatestResultWithFeedbacksForProgrammingExerciseParticipation to fetch submission and template participations.
Steps for Testing

Prerequisites:

1 Exercise with at least 1 student participation
1 Instructor

Log in as Instructor
Navigate to Course Management
Find the exercise and click on the Scores button

Open one of the results in Online Editor
Make sure everything works as before on the Online Editor

Review Progress

Performance Review

[ ] I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

[ ] Code Review 1
[ ] Code Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Class/File
Line Coverage
Confirmation (assert/expect)

ResultService.java
91%
✅

ProgrammingExerciseParticipationResource.java
86%
✅

Screencast
https://github.com/ls1intum/Artemis/assets/22798314/be658df4-cd6e-4253-b2f0-000c34d76fe7
Note: You do NOT need to test the Themis app. The video above just shows the effect of this PR on Themis.

Codecov Report

Merging #6810 (b8707b0) into develop (ea92d51) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6810      +/-   ##
=============================================
- Coverage      80.42%   80.42%   -0.01%
  Complexity     13987    13987
=============================================
  Files           2448     2448
  Lines          93624    93631       +7
  Branches       13160    13161       +1
=============================================
+ Hits           75297    75299       +2
- Misses         10071    10075       +4
- Partials        8256     8257       +1

Impacted Files
Coverage Δ

...rest/ProgrammingExerciseParticipationResource.java
77.77% <37.50%> (-6.16%)
:arrow_down:

Flag
Coverage Δ

client
76.21% <ø> (ø)

server
84.94% <37.50%> (-0.01%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea92d51...b8707b0. Read the comment docs.

Can you please explain why this is neeed? There already is the endpoint /with-template-and-solution-participation which retruns these values, can you not use this one here?

The specified endpoint returns a ProgrammingExercise with those values, but I need a Result instead.
An alternative could be to first use the /programming-exercise-participations/{participationId}/latest-result-with-feedbacks endpoint to get the Result and then /with-template-and-solution-participation to fetch the ProgrammingExercise again, but this increases the number of requests by the app (since Result already contains a Participation containing the same ProgrammingExercise)

After a discussion with Lucas, I've decided to handle the problem on the client side instead, by sending 2 separate requests.


 tag content is sometimes not displayed in GUI

Description
The <pre> HTML tag is sometimes not loaded in the GUI. If we refresh the page a few times, variably the content of the <pre> tag may or may not appear.

Notion Test Page ID
https://react-notion-x-demo.transitivebullsh.it/0c322c33381c49bca5083a451c334c39
https://morethan-log.vercel.app/hot-to-make-sitemap-in-next-js

I believe there is some problem in prismjs (syntax highlighting). I made a small change to the code, deleting the following block:
const Code = dynamic(() =>
  import("react-notion-x/build/third-party/code").then(async (m) => {
    await Promise.all([
      import('prismjs/components/prism-markup-templating.js'),
      import('prismjs/components/prism-markup.js'),
      import('prismjs/components/prism-bash.js'),
      import('prismjs/components/prism-c.js'),
      import('prismjs/components/prism-cpp.js'),
      import('prismjs/components/prism-csharp.js'),
      import('prismjs/components/prism-docker.js'),
      import('prismjs/components/prism-java.js'),
      import('prismjs/components/prism-js-templates.js'),
      import('prismjs/components/prism-coffeescript.js'),
      import('prismjs/components/prism-diff.js'),
      import('prismjs/components/prism-git.js'),
      import('prismjs/components/prism-go.js'),
      import('prismjs/components/prism-graphql.js'),
      import('prismjs/components/prism-handlebars.js'),
      import('prismjs/components/prism-less.js'),
      import('prismjs/components/prism-makefile.js'),
      import('prismjs/components/prism-markdown.js'),
      import('prismjs/components/prism-objectivec.js'),
      import('prismjs/components/prism-ocaml.js'),
      import('prismjs/components/prism-python.js'),
      import('prismjs/components/prism-reason.js'),
      import('prismjs/components/prism-rust.js'),
      import('prismjs/components/prism-sass.js'),
      import('prismjs/components/prism-scss.js'),
      import('prismjs/components/prism-solidity.js'),
      import('prismjs/components/prism-sql.js'),
      import('prismjs/components/prism-stylus.js'),
      import('prismjs/components/prism-swift.js'),
      import('prismjs/components/prism-wasm.js'),
      import('prismjs/components/prism-yaml.js')
    ])
    return m.Code
  })
)

And including this:
const Code = dynamic(() =>
  import("react-notion-x/build/third-party/code").then(
    (m) => m.Code
  )
)

Now the content of the <pre> is always loaded in the GUI.

We had same issue - and it looks that fix from @wolkartt  working.


[angle] update for gcc 10 compatibility

angle on master failing to build with gcc 10, updated to gcc 10 compatible version

Please resolve the regressions. Get logs here.

@JackBoosY done

Thanks @isanych :)


[DOCFIX]Translate a sentence in docs/cn/Contributing-Getting-Started.md

Can one of the admins verify this patch?

LGTM. Thanks for your translation!! @deembaker

LGTM


Add KHR_texture_basisu parsing

Adds support for https://github.com/KhronosGroup/glTF/tree/master/extensions/2.0/Khronos/KHR_texture_basisu
In the glTF file, this extension is defined on the texture object, so it seems logical that we define this cgltf extension data on the cgltf_texture object. This PR adds a new flag, has_basisu and a new cgltf_image property, basisu_image to cgltf_texture.  This solution allows loaders that do not support KTX2 and basisu textures to continue loading any fallback texture that may be defined on the model.
I considered making a small change, where we can #define SUPPORT_BASISU, remove this new cgltf_texture::basisu_image, and instead just load the basisu image directly into cgltf_texture::image.  Open to suggestions here, but both seem functionally equivalent.
If you'd like to play with this extension, here are some helpful resources to get started:

Instructions for converting existing glTF model textures to KTX2+basisu can be found in the artist guide: https://github.com/KhronosGroup/3D-Formats-Guidelines/blob/main/KTXArtistGuide.md
A developers guide for KTX2 and basisu can be found here: https://github.com/KhronosGroup/3D-Formats-Guidelines/blob/main/KTXDeveloperGuide.md
To load basisu textures into your engine, you'll only need the basisu_transcoder.cpp from Binomial. The transcoder also defines a helpful and compact ktx2 loader. See How to configure and use the transcoder for tips to get started.

For those interested, here's the press release where Khronos announces KTX2 and the KHR_texture_basisu extension:
https://www.khronos.org/news/press/khronos-ktx-2-0-textures-enable-compact-visually-rich-gltf-3d-assets
and some 3rd party analysis:
https://gfxspeak.com/2021/04/26/khronos-compresses-everyone/

After hooking up KHR_texture_basisu to cgltf_write, I see now that we do in fact need to retain both cgltf_texture::image and cgltf_texture::basisu_image.  This allows models to "round trip" through cgltf parsing and cgltf writing without losing any possible fallback image that may also be defined on the texture object.  So I think the implementation that I have here is preferred.
This is ready for review.

Looks good to me! Thanks!


SAML login usernames do not allow \h, and instead allow the usage of \h with ensured JWT consistency

Description
Addressed an issue where SAML login would fail for usernames containing \h. While usernames with \h remain unsupported, this fix ensures that \\h can be used as a consistent alternative. Usernames with an even number of backslashes followed by h will always be treated as having just \\h.
Category: Bug fix
Reason for Change:
Usernames containing \h were found to cause invalid JWT token generation, as detailed in Issue 2531. However, \\h produces valid JWT tokens. Due to inconsistent handling of backslashes (owing to their use as escape characters in string literals), it's crucial to establish a consistent approach. Hence, any even number of backslashes before h will now be treated as \\h.
Behavioral Change:

Previous Behavior: SAML login fails when the username contains \h.
New Behavior: SAML login succeeds for usernames with \\h and fails for \h.

Issues Resolved
Issue 2531
Testing
A test testJwtWithBackslashHInUsername was added in src/test/java/com/amazon/dlic/auth/http/saml/HTTPSamlAuthenticatorTest.java to validate the behavior with various username patterns. This test iterates over an array of test usernames, ranging from "username\hexample" to "username\\\\hexample", to ensure that only the \\h format is valid.
In addition to the automated tests, manual testing was conducted where tokens were created with usernames containing \h (which consistently failed) and \\h (which succeeded). The validity of these tokens was further confirmed using the jwt.io site created by Okta.
Check List

[x] New functionality includes testing.
[x] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. More information on the Developer Certificate of Origin and signing off on commits can be found here.

@nancyjlau Would you need any help getting this across the finish line?

Hi, sorry I had gotten distracted by an exam last week, will submit changes for this today!

This really is specific to \h and it doesn't affect other special characters like \t or \n from some local testing.
I tried:

user\hexample
user\texample
user\nexample

and only the one where the subject contains \h is where the error appeared.
As @MaciejMierzwa mentioned here it looks like either Java or the JWT Library (CXF or Nimbus) are not handling \h as they are \n and \t. I'd like to understand why \h is special compared to the other chars.

@nancyjlau Would you need any help wrapping this PR up? I'm marking this as draft meanwhile. Please mark it as ready for review once all changes are finalized and CI is green.

uhhh sorry i have been having some git issues on trying to get CI to be green

Hi @nancyjlau, you will need to fix the merge conflicts before the CI will be able to pass. Then we can see where things are at.

Hi @nancyjlau Closing this as there has been no recent activity. Feel free to @ if this changes.


KBC-1429 test creating organization metadata

Jira: https://keboola.atlassian.net/browse/KBC-1429
Connection PR https://github.com/keboola/connection/pull/3145
Apiary docs for new endpoints

POST manage/organizations/{$organizationId}/metadata
GET /manage/organizations/{$organizationId}/metadata

Tests for

create org metadata
list org metadata

👀


fixed permissions for all I could

Thank you!
Sorry for my late response. My school has open so I'm quite busy now.
Also thanks for changing avatar image quality in about command


operator cockroachdb-certified-rhmp (v2.4.0)

Adding cockroach operator v2.4.0 to the marketplace

Please confirm the Project settings for this project in connect.redhat.com.


fix undefined process error in client side code

Issue:
What I did

Fixed error in client side code after this commit https://github.com/dpc-sdp/ripple-framework/pull/1084/files#diff-275b89f10d026bf7cc95f269ea4b37e1689c60305475170b409ad175f5781faeR1
Ripple-tide-api exports code which expects a node environment, when imported into client bundle things like process are undefined.

How to test

Cypress tests should pass
Run pnpm -F nuxt-app dev - check for errors in javascript console in browser

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

@dylankelly will need to update all the imports for the methods moved into helpers as well - do you want me to add that to this PR? I have another one I've been working on but commander and cypress aren't working 🙃

Yeah sorry thought I could fix it quickly while you were occupied elsewhere. Over to you


Made appropriate changes to copy:

subs due letter
subs overdue letter
subs due email
subs overdue email

@mantagen I am assuming you want this merged?


MN-761: use TransaferToDesposit request reference as txID

- What I did
- How I did it
- How to verify it
- Description for the changelog

Codecov Report

Merging #76 into release/1.11 will decrease coverage by 0.05%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release/1.11      #76      +/-   ##
================================================
- Coverage         13.95%   13.89%   -0.06%
================================================
  Files                 8        8
  Lines              1197     1202       +5
================================================
  Hits                167      167
- Misses             1017     1022       +5
  Partials             13       13

Impacted Files
Coverage Δ

...et/application/builtin/contract/deposit/deposit.go
1.99% <0.00%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc9e6c...eec781c. Read the comment docs.


ci: fetch all commits for correct versioning

Placed it in the wrong job.. Need it in the release

Codecov Report

Merging #387 (ccadec4) into main (89a628f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   86.42%   86.42%
=======================================
  Files         234      234
  Lines        4803     4803
  Branches      750      750
=======================================
  Hits         4151     4151
  Misses        652      652

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a628f...ccadec4. Read the comment docs.


[Question] Continue Learning with different action space

Hello,
I am just starting out with reinforcement learning so pardon me if this is a simple or dumb question. I trained a model to play FZero on the SNES for about 8 hours. I now want to take what that model learning and increase the action space. Is this possible? I thought I could since I'm not taking anything away, just adding, but stable-baselines says I need to have the same action space in the environment for the model to use it

Matching action spaces are checked under the hood for sanity to avoid more obscure error messages. You could load up the trained model without an environment and use it to predict actions, which you then modify by hand to remove the actions you do not want to be included.


vi: fix window cropping

When outside the screen, lines should be cropped, but it's not what happens:

Window starts at x: 800; y: 0


chore: update to Next JS 13 and makes fixes

[1.0.1] - [2022-12-28]
Changed

Update to Next JS 13 and makes fixes to the template typescript-version

Hi @jorcelinojunior,
There are several changes that are unnecessary and the implementation of links for Next.js 13 is not proper. So I am closing this PR.
But we will release an update with Next.js v13 within a couple of weeks.

Hi @jorcelinojunior,
There are several changes that are unnecessary and the implementation of links for Next.js 13 is not proper. So I am closing this PR.


Add service Codeclimate

Coverage remained the same at 24.456% when pulling 9b8fbf145c5c6233ed98866085fd0e9a95f3bb49 on code-climate into 44b6c71ca95e5df995027b8dbb2b674f360e85ec on master.


KAFKA-15152: Fix incorrect format specifiers when formatting string

Changed String format specifier from %s to %d for multiple int/long type variables. The ticket mentioned that using %s to format int/long data type might potentially lead to locale-sensitive handling issue. However, as far as I can see, all these variables have decimal values, where as locale-sensitive issues may happen at values with separators. Still I decided to change String format specifier from %s to %d because I think it is more appropriate to format int/long with %d.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Test failures are unrelated to the files:
[Build / JDK 20 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/kafka.server/DynamicBrokerReconfigurationTest/Build___JDK_20_and_Scala_2_13___testTrustStoreAlter_String__quorum_kraft/)
[Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsWithCustomForwardingAdminIntegrationTest.testSyncTopicConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest/Build___JDK_17_and_Scala_2_13___testSyncTopicConfigs__/)
[Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.integration.ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/org.apache.kafka.connect.integration/ConnectorRestartApiIntegrationTest/Build___JDK_17_and_Scala_2_13___testMultiWorkerRestartOnlyConnector/)
[Build / JDK 17 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_17_and_Scala_2_13___testBalancePartitionLeaders__/)
[Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.[1] true](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/org.apache.kafka.streams.integration/SmokeTestDriverIntegrationTest/Build___JDK_8_and_Scala_2_12____1__true/)
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testSyncTopicConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_11_and_Scala_2_13___testSyncTopicConfigs__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.KRaftClusterTest.testCreateClusterAndCreateListDeleteTopic()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/kafka.server/KRaftClusterTest/Build___JDK_11_and_Scala_2_13___testCreateClusterAndCreateListDeleteTopic__/)
[Build / JDK 11 and Scala 2.13 / kafka.log.remote.RemoteIndexCacheTest.testClose()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/kafka.log.remote/RemoteIndexCacheTest/Build___JDK_11_and_Scala_2_13___testClose__/)
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.[1] true](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14026/3/testReport/junit/org.apache.kafka.streams.integration/SmokeTestDriverIntegrationTest/Build___JDK_11_and_Scala_2_13____1__true/)


Trigger provideOnTypeFormattingEdits

I am trying to add a OnType formatting to a custom language in Monaco Editor. It seems that we could use OnTypeFormattingEditProvider.
As an example, I have made a plunker, but I don't know why provideOnTypeFormattingEdits is not triggered when typing.
monaco.languages.registerOnTypeFormattingEditProvider('mySpecialLanguage', {
    provideOnTypeFormattingEdits: function (model, position, ch, options, token) {
		console.log("inside provideOnTypeFormattingEdits");
		return [
			{
			  range: {
				startLineNumber: 1,
				startColumn: 1,
				endLineNumber: 1,
				endColumn: 1
			  },
			  text: `abc`
			}
		]
    }
})

Could anyone help?

@chengtie When creating your editor, you need to tell Monaco to turn on the feature by enabling formatOnType to true.
var editor = monaco.editor.create(iElement[0], {
    language: monacoeditorOptions.language,
    lineNumbers: monacoeditorOptions.lineNumbers,
    minimap: monacoeditorOptions.minimap,
    automaticLayout: monacoeditorOptions.automaticLayout,
    scrollBeyondLastLine: monacoeditorOptions.scrollBeyondLastLine,
    theme: monacoeditorOptions.theme,
    formatOnType: true
});

You also need to define the required string[] property autoFormatTriggerCharacters in your OnTypeFormattingEditProvider implementation.
monaco.languages.registerOnTypeFormattingEditProvider('mySpecialLanguage', {
    provideOnTypeFormattingEdits: function (model, position, ch, options, token) {
    console.log("inside provideOnTypeFormattingEdits");
        return [
            {
                range: {
                    startLineNumber: 1,
                    startColumn: 1,
                    endLineNumber: 1,
                    endColumn: 1
                },
                text: `abc`
		    }
                ]
        },
    autoFormatTriggerCharacters: [ 'a' ]
});

@rcjsuen indeed, it works... thank you...

@chengtie No problem, good to hear that it's working for you.
Please close this issue then if you problem has been resolved.


Add open graph tags in website

Issue Description
I would like to request that Open Graph tags be added to website to improve the way it is shared on social media. These tags help provide information to social media platforms like Facebook, Twitter, and LinkedIn, and can improve the way our website appears when it is shared.
Proposed Solution
I would like to add the following Open Graph tags to our website:
<meta property="og:title" content="Website Title">
<meta property="og:description" content="Website description">
<meta property="og:image" content="https://example.com/image.jpg">
<meta property="og:url" content="https://example.com">

The og:title tag would be used to specify the title of the website, the og:description tag would be used to provide a brief description of the website, the og:image tag would be used to specify the image to use when the website is shared, and the og:url tag would be used to specify the URL of the website.
Additional Information
Please let me know if you have any questions or concerns about adding these Open Graph tags. I believe that this change would improve the way, the website is shared on social media and help increase online presence.

it is good idea @ShashwatAgrawal20  , @theritikchoure  i will assing you if you want to work on it.

Sorry for the late response @theritikchoure. can you check this feature . i don't think this feature is working or not.

no response


*: add log events for login, LDAP queries, and SAML responses

Add some log events to help debug common mis-configuration issues.
Will do a login through SAML and LDAP providers to show what these logs look like.

This is what an LDAP login now looks like
time="2017-08-11T18:26:04Z" level=info msg="performing ldap search ou=People,dc=example,dc=org sub (&(objectClass=person)(mail=janedoe@example.com))" connector=OpenLDAP
time="2017-08-11T18:26:04Z" level=info msg="username<EMAIL_ADDRESS>mapped to entry cn=jane,ou=People,dc=example,dc=org" connector=OpenLDAP
time="2017-08-11T18:26:04Z" level=info msg="performing ldap search ou=Groups,dc=example,dc=org sub (&(objectClass=groupOfNames)(member=cn=jane,ou=People,dc=example,dc=org))" connector=OpenLDAP
time="2017-08-11T18:26:04Z" level=info msg="login: connector \"ldap\", username=\"jane\"<EMAIL_ADDRESS>groups=[\"admins\" \"developers\"]"

Fixes #719


Remove *_step_end from LitModular

What does this PR do?
This PR merges *_step_end into *_step in LitModular. This means we no longer need to clear outputs.
This PR depends upon the following:

[x] #169

Type of change
Please check all relevant options.

[x] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[x] pytest
[x] CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
[x] CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

[x] The title is self-explanatory and the description concisely explains the PR
[x] My PR does only one thing, instead of bundling different changes together
[x] I list all the breaking changes introduced by this pull request
[x] I have commented my code
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?
Make sure you had fun coding 🙃

I also introduced this change in #157 to work with newer PL.
Have you confirmed that there's no memory leak issue with the current PL version?

How did you confirm? I watched memory usage and it seemed fine. I also root cause why outputs.clear() was necessary in the old code. That is because PL is basically holding whatever training_step returns for training_epoch_end.

Note that RobustBench tests are failing because of some model issue unrelated to these changes...


Autocomplete: replace completion post processing logger with OpenTelemetry spans

We need a way to see the stage the streamed completion response goes through to quickly locate bugs and debug efficiently streaming/truncation/post-processing logic. Each generated partial response can start a new OpenTelemtry trace, with spans being stages of our processing pipeline with an ability to log all this information in a readable way to the trace view or the console output.

Part of https://github.com/sourcegraph/cody/issues/1619
Follow up for https://github.com/sourcegraph/cody/pull/1894

Closeable?

Yes, it will be closed by the three PRs I opened last week. The are linked above.


Should we assess .NET project using the IDEs built in tool?

To give a tangible example, I'm currently using JetBrains Rider to evaluate a project. JetBrains Rider has built-in Linter (called Code Inspectors), Code Coverage (via plugin) and Profiling (Debugger).
My initial feeling is to say that that we should find tools to do separately for the sake of continuous delivery pipelines.
We've discussed this internally on our slack and there have been no definitive answers.
cc @StevenLeighton21 @robinlacey  (please ping others who may be interested in this discussion)

I've started trialling StyleCop, needs fine tuning and further discussion as to what rules are enabled by default.


runHook before

If it's possible to call after hooks for an individual call with runHook, what about hooks before? Because if you may need to modify the output data, you may also need to modify the inputs.

I don't see a way to call before hooks.

What is missing is not being able to add hooks for custom methods, even without exposing them via the providers.
Custom methods are useful for making "shortcuts" for often used methods (often find and patch).
Currently it is possible to activate the hooks for other methods than the 6 natives but you have to modify app.methods, it would make more sense that each service has its methods (service.methods ?), right ?

I have submitted this pull requests for this:

https://github.com/feathersjs/feathers/pull/864
https://github.com/feathersjs/commons/pull/72

I'll leave this for daffl to answer in the above repos as he handles them.

And I created one method and one hook to allow individual call hooks:

withHooks: add before/after hooks to an individual service call
callingHooksParams: assigns the writable properties of the result of the before hooks string to new contexts

callingHooksParams usage:
app.hooks({
  before: callingHooksParams() // should be the first hook
});

withHooks usage examples:
get
const findWithHooks = withHooks({
  app,
  service: payments,
  method: 'find'
});

// await findWithHooks(...findArguments)(hooks);
const { result, params } = await findWithHooks({ query: { amount: 100 } }, true)({
  before: context => {
    // context.result = 'Nickel';
    context.params.additional = 'Nickel';
  },
  after: fastJoin(paymentResolvers)
});

console.log('find result', result);
console.log('find params', params);

find
const getWithHooks = withHooks({
  app,
  service: payments,
  method: 'get'
});

// await getWithHooks(...getArguments)(hooks);
const getResult = await getWithHooks(104, { param: true })({
  before: context => {
    context.params.discount = 25;
  },
  after: fastJoin(paymentResolvers)
});

console.log('get result', getResult);

Here is my `withHooks.js` file
const { _, hooks, validateArguments } = require('@feathersjs/commons');
const { runHook, combine } = require('feathers-hooks-common');

const { createHookObject, processHooks, makeArguments } = hooks;

const callingContextKey = '$callingContext';

function callingHooksParams(key) {
  return context => {
    const props = context.params[key || callingContextKey];
    delete context.params[key || callingContextKey];
    return Object.assign(context, props);
  };
}

function withHooks(options) {
  return (...args) => async callingHooks => {
    // Create the hook object that gets passed through
    const beforeHookObject = createHookObject(options.method, args, {
      type: 'before', // initial hook object type
      service: options.service,
      app: options.app
    });
    // A hook that validates the arguments and will always be the very first

    const returnHookObject = args[args.length - 1] === true;
    if (returnHookObject) {
      args.pop();
    }

    const validateHook = context => {
      validateArguments(options.method, args);

      return context;
    };
    // The `before` hook chain (including the validation hook)
    const beforeHooks = [validateHook, ...[].concat(callingHooks.before || [])];

    // Process all before hooks
    const hookObject = await processHooks.call(options.service, beforeHooks, beforeHookObject);

    const key = options.key || callingContextKey;

    // Add callingHooks prop
    hookObject.params[key] = _.omit(hookObject, 'app', 'service', 'path', 'method', 'type');

    const serviceArgs = makeArguments(hookObject)
      .concat(returnHookObject ? [true] : []);

    const serviceCallResult = await options.service[options.method](...serviceArgs);

    const afterHookObject = Object.assign({}, hookObject, {
      type: 'after',
      result: serviceCallResult
    });

    const defauftHook = v => v;
    const afterHook = Array.isArray(callingHooks.after)
      ? combine(...callingHooks.after)
      : (callingHooks.after || defauftHook);

    return runHook(afterHookObject)(afterHook)(serviceCallResult);
  };
}

module.exports = Object.assign(withHooks, { callingHooksParams });

A complete working example
const feathers = require('@feathersjs/feathers');
const memory = require('feathers-memory');
const { fastJoin } = require('feathers-hooks-common');
const withHooks = require('./withHooks');

const paymentsRecords = [
  {
    _id: 101,
    amount: 100,
    patientId: 1
  },
  {
    _id: 104,
    amount: 115,
    patientId: 2
  },
  {
    _id: 105,
    amount: 120,
    patientId: 3
  },
  {
    _id: 106,
    amount: 125,
    patientId: 3
  }
];

const patientsRecords = [
  {
    _id: 1,
    name: 'John'
  },
  {
    _id: 2,
    name: 'Marshall'
  },
  {
    _id: 3,
    name: 'David'
  }
];

(async () => {
  const app = feathers()
    .use('payments', memory({ id: '_id' }))
    .use('patients', memory({ id: '_id' }));

  const payments = app.service('payments');
  const patients = app.service('patients');

  app.hooks({
    before: withHooks.callingHooksParams() // should be the first hook
  });

  await payments.create(paymentsRecords);
  await patients.create(patientsRecords);

  // -----

  const paymentResolvers = {
    joins: {
      patient: () => async payment => {
        payment.patient = (await patients.find({
          query: {
            id: payment.patientId
          }
        }))[0];
      }
    }
  };

  const findWithHooks = withHooks({
    app,
    service: payments,
    method: 'find'
  });

  // await findWithHooks(...findArguments)(hooks);
  const { result, params } = await findWithHooks({ query: { amount: 100 } }, true)({
    before: context => {
      // context.result = 'Nickel';
      context.params.additional = 'Nickel';
    },
    after: fastJoin(paymentResolvers)
  });

  console.log('find result', result);
  console.log('find params', params);
  const getWithHooks = withHooks({
    app,
    service: payments,
    method: 'get'
  });

  // await getWithHooks(...getArguments)(hooks);
  const getResult = await getWithHooks(104, { param: true })({
    before: context => {
      context.params.discount = 25;
    },
    after: fastJoin(paymentResolvers)
  });

  console.log('getResult', getResult);
})();

Interesting. I'll handle this when I refresh the repo. Thanks!

I made the necessary changes for that here https://github.com/bertho-zero/feathers/pull/2/files.
This pull request comes after https://github.com/feathersjs/feathers/pull/864

I need to wait until daffl considers those pull requests.


fix: add ansible install_mode "pip3"

This fixes an issue that was recently created by the release of a new version of the script here: https://bootstrap.pypa.io/get-pip.py.
TL;DR — they dropped support for Python2 and this now requires pip3. Maybe worth noting I may have had to manually install Python3 via SSH into the box, but I may have also already had it and it was a step I just duplicated. Either way — this fixes issues folks should be having as of this last Saturday.

Fixes #2138 - tried it out and provisioning works tickety-boo.

Fixes #2138 - tried it out and provisioning works tickety-boo.

I had a quick play and whilst Python3.6.9 is installed, pip3 doesn't seem to exist on the base box by default.

I had a quick play and whilst Python3.6.9 is installed, pip3 doesn't seem to exist on the base box by default.

I had a quick play and whilst Python3.6.9 is installed, pip3 doesn't seem to exist on the base box by default.

I may be misunderstanding what you're saying, but I see the same thing. But my understanding is that pip3 gets installed by ansible when you bring the box up or do a vagrant provision. With this PR anyway. Without the PR, I suspect pip probably doesn't exist on the box either, but the provisioning pulls it down.

I had a quick play and whilst Python3.6.9 is installed, pip3 doesn't seem to exist on the base box by default.

I may be misunderstanding what you're saying, but I see the same thing. But my understanding is that pip3 gets installed by ansible when you bring the box up or do a vagrant provision. With this PR anyway. Without the PR, I suspect pip probably doesn't exist on the box either, but the provisioning pulls it down.

Might've misunderstood something here or in #2138 but with dev-master, I'm still seeing the following on vagrant up and vagrant provision:
ansible remote provisioner:
* The following settings shouldn't exist: install_mode

My local environment:
Vagrant 2.2.14
VirtualBox 6.1.8r137981
ansible 2.9.1
  config file = None
  configured module search path = ['/Users/jasloe/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.9/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.9.1 (default, Jan 30 2021, 15:51:26) [Clang 11.0.0 (clang-1<IP_ADDRESS>)]

@jasloe - Oops! Sorry about that; it should only apply for ansible_local, not ansible, so I believe the change I just pushed (see commit linked above) should fix it for those of us with Ansible running locally.


pytorch grad cam for RGBD images?

Can I use this package with RGBD images? My custom model is a two stream network taking RGB image in one stream and depth image in the other. How  can I specify input_tensor in such a case?  Kindly advise.

If you want to create the CAM only for the RGB part,
I would create a model wrapper that fixes the D input, and is just a regular model with an RGB input.
Something like

class RGBDWrapper:
    def __init__(model, depth_tensor):
        self.model = model
        self.depth_tensor = depth_tensor

    def __call__(rgb_tensor):
        self.model(rgb_tensor, depth_tensor)

wrapped_model = RGBDWrapper(depth_tensor)
Then from the point of view of the CAM model, this wrapper model is just a model that accepts an RGB tensor.


Added AWS lambda examples

Per contrib guidelines: @adamdecaf, addresses #658
Added example Go file and walkthrough for parsing JSON to NACHA
Added example Go file and walkthrough for parsing NACHA to JSON
Both files have been tested in AWS. Take note of the package main in both of the example files; I did this so they could be copied and pasted. Let me know if this is an issue and I can make adjustments.

Codecov Report

Merging #767 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #767   +/-   ##
=======================================
  Coverage   93.11%   93.11%
=======================================
  Files          66       66
  Lines        5839     5839
=======================================
  Hits         5437     5437
  Misses        241      241
  Partials      161      161

Thanks @berryman17 !!


STERI016-192-input-issue-am: Remove unnecessary styles for mandatory fields

Ticket: https://herodigital.atlassian.net/browse/STERI016-192
Test URLs:

Before:

https://refresh-develop--shredit--stericycle.aem.page/forms/landing-page-hardrive

After:

https://steri016-192-input-issue-am--shredit--stericycle.aem.live/forms/landing-page-hardrive

@allanhero I'm closing for now because I agree that this may not be a valid ticket


Update Testing.md with pre-processing information

With the added information a react-native developer will be able to run jest tests without errors. First time contributing to react-native so please let me know if I missed something :)
As it is I was running into issues running jest tests. The configuration added was added from the react-native package.json.

Feedback addressed and commits squashed.

Thanks!

This definitely does not work with require('react-native') :smile:

Those settings unblocked me from running tests of libraries (yes those did not rely on react-native). The one time I tried tests that included require('react-native') it did not work. Possibly the "mock-by-default" behavior?


[Hack-together] Unequal Sizes of Listing Cards on Homepage

Are you accessing the project from the GitHub Codespaces?

[ ] No, I am running the project on my local machine (I will fill in the OS section below)
[ Yes ] Yes, I am using GitHub Codespaces.

Note: The project is optimized to run on Codespaces. We welcome contributions to enhance it for cross-platform local development, but it's not something we will prioritize right now. Thank you!

Describe the bug
I've noticed that the listing cards on the project's homepage are displaying with unequal sizes, which is affecting the overall visual consistency of the page. This issue seems to impact both the desktop and mobile versions of the site.
To Reproduce
Steps to reproduce the behavior:

Navigate to the homepage of the real estate project.
Observe the listing cards in the main content area.
Note the varying heights of the listing cards.

Expected behavior
The listing cards should maintain consistent dimensions, ensuring a uniform and visually appealing layout across different devices and screen sizes.
Screenshots

OS (please complete the following information):

OS: MacOs
OS Version: Ventura 13.5
npm version: 9.8.0
Node.js version: 18.14.0
output of azd version:

Possible Solution:
To address the issue of unequal listing card sizes, we can implement a JavaScript solution that dynamically adjusts the card sizes to ensure uniformity. Here's how we can approach it:

Calculate Maximum Height: Using JavaScript, we can iterate through all the listing card elements and calculate the maximum height among them. This will help us determine the target height for all cards.

Apply Uniform Height: Once we have the maximum height value, we can apply it to all listing cards. By setting the same height for each card, we can ensure that they are displayed with consistent dimensions.

Here's a basic example of how this JavaScript solution could look:
// JavaScript to adjust listing card sizes for uniformity

// Wait for the page to fully load before making any adjustments
window.addEventListener('load', () => {
  const listingCards = document.querySelectorAll('.listing-card');
  let maxHeight = 0;

  // Calculate the maximum height among all listing cards
  listingCards.forEach(card => {
    const cardHeight = card.offsetHeight;
    if (cardHeight > maxHeight) {
      maxHeight = cardHeight;
    }
  });

  // Set the calculated maximum height to all listing cards
  listingCards.forEach(card => {
    card.style.height = `${maxHeight}px`;
  });
});

Please note that while JavaScript can provide a quick solution, we should also consider the impact on performance and responsiveness. If feasible, combining this approach with CSS adjustments for responsive design would yield a more comprehensive solution.
Additional context
I understand that responsive design might lead to some size variation on different screen sizes, but it's important to maintain a consistent aspect ratio to avoid jarring differences in card sizes. This issue could have an impact on user engagement and overall user experience.
Looking forward to contributing to the improvement of the project! If there's any other information needed, please let me know.

Hi @michaelkhanda Thanks for opening the issue! Looking forward to your contribution. Please include a gif or video with the results! Thank you!

This issue is already mentioned in #242 and can be solved together!

@anfibiacreativa can you assign it to me?

@anfibiacreativa can you assign it to me?

I'm very sorry that I didn't see this question, @alidotdeveloper . If you would still like to open a PR, I can consider it exceptionally even when the Hackathon time is due, since this was my overlook. Let me know!

Sure.. Look like docker domain can't bale to connect

@anfibiacreativa @juliamuiruri4 can I still fix that issue and pull the PR?

@alidotdeveloper - Sorry for catching this late, but please do go one with fixing the issue. Looking forward to your contribution

@juliamuiruri4  @anfibiacreativa  I have open the pull request


[WIRES] Add tests for nonconsecutive wires

Context:
This is the last of the wire management refactor PRs. It merges into the allow_non_consecutive_wires branch, which carries all (breaking) changes ensuing from allowing devices to have registers with arbitrary wire labels.
This PR adds tests to different places of the PennyLane code base.
Description of the Change:
The basic logic of the tests is this:

wire management tests are written as integration tests
where possible, they compare the results of qnodes run with different wire labels with each other
the tests are added to the device and qubit_device test files, as well to templates, circuit graph, circuit drawer and core device tests.

@co9olguy Would you mind having a look? Any other places where we could test wires except from in the devices and circuitgraph/drawer and templates?

@co9olguy Would you mind having a look? Any other places where we could test wires except from in the devices and circuitgraph/drawer and templates?

Sorry, didn't find time to get to this yet, it was on my radar for sometime this week though :(


Not showing up in Plugin Manager or launching Setup Wizard

I'm brand new, so I apologize if this isn't the right place for this.
Since I'm new, I've installed the latest version of OctoPi, and I downloaded Octoprint Anywhere from the repository. The on screen dialog says it installed successfully, but the Setup Wizard doesn't open. I tried reinstalling and it tells me that it is already installed but forces a new install. It also is not showing up in my Plugin Manager list, or at the bottom of the left hand column of my settings page with the rest of my installed. Am I doing something wrong?

Thank you for submitting this issue report and sorry for the problem you are experiencing.
Can you attach "octoprint.log" to this issue so I can take a look? You can find the log file by following this instruction: https://community.octoprint.org/t/where-can-i-find-octoprints-and-octopis-log-files/299

octoprint.log

Thank you @irmcdermott for sending me the log file. The log file revealed a weird error that seems to be caused by failure in python package management system.
Can you ssh to your OctoPi and run this command and post herewhat you see on the screen?
/home/pi/oprint/bin/python -m pip install backoff==1.4.3

op anywhere.txt

It looks like python module backoff was installed successfully. Can you restart OctoPi and see if OctoPrint Anywhere works correctly now?

i restarted and it was showing up in my plugin manager, but not showing up on the left hand column underneath "Plugins" and still not getting any kind of Setup Wizard. Sorry!
plugin_pluginmanager_console.log
octoprint.log

Thank you @irmcdermott .
Your new log file shows that it's now failing at another python module. I'm pretty convince that it is caused by a strange python module management bug.
Please ssh to your Pi and run this command /home/pi/oprint/bin/python -m pip install raven picamera==1.13.
These should be the last dependencies that were somehow in corrupted state. After that you restart OctoPi and the OctoPrint Anywhere plugin should work correctly.

Same Problem here. i tried both commands...
the result till now, i can see the plugin in the manager, but no wizzards starts and there is no plugi in in the plugin list in the bottom left hand  corner.
plugin_pluginmanager_console.log
octoprint.log

THANK You, find a solution. uninstalled raven and reinstalled anywhere as you  mentioned here: https://github.com/kennethjiang/OctoPrint-Anywhere/issues/56#issuecomment-437495086

Thank you @NeoRame . I already forgot that we ran into similar issues before! Definitely a weird bug in python module management and/or Pi.

Thank you to both of you! Appears to be up and running now!


What is the preferred Development Environment (IDE/Editor)?

I got a working VSCode +HIE installation on Ubuntu going but this project hangs during initializion phase: "Initializing Cabal Project". Before spending some more time on the wonderful world of Haskell tooling i wanted to ask: what is everybody using and is working?

Hi,
First and foremost, CI is working on Ubuntu, Windows and OS/X. The Ubuntu script is in
https://github.com/LambdaHack/LambdaHack/blob/master/.travis.yml#L291
and the results are at
https://travis-ci.org/LambdaHack/LambdaHack/builds
Myself, I just use cabal new-build -j1 . from the commandline or from emacs with and old haskell-mode, but I know stack used to work too. Does the commandline compilation work for you? Does a "Hello World" projects work for you in VSCode +HIE, according to their documentation?

Hi,
Compilation does work fine.
cabal build does the trick after installing pkg-config, libsdl2 and sdl2-ttf.
VSCode + HIE works for simple Hello World projects.
After waiting for some time VSCode gives me now:
"can't load .so/.DLL for: /home/eugen/.cabal/store/ghc-8.6.5/sdl2-<IP_ADDRESS>-[....]-ghc8.6.5.so (libSDL2-2.0.so.0: cannot open shared object file: No such file or directory)"
Some intellisense would be great to help me understand the project structure.  Anyway might give it a try with emacs and old haskell mode.
thx a lot.

I'm afraid we don't have any VSCode guru onboard. However, any intellisense (that's a config file, right?) would be welcome, if you ever happen to create one.
Let me know how it goes for you and ask early and often --- docs and tickets are usually very cryptic, written in a lazy way ;), so questions would be a good trigger to expand them.

BTW, I don't know if it's in any docs, but putting optimization: False in your cabal.project.local would speed up compilation by an order of magnitude, and the game would still be fast enough for normal playing.

No problem. I am not particularly hung up on VSCode and HIE. https://en.wikipedia.org/wiki/Intelligent_code_completion or intellisense is just editor assistance for autocompletion and type information. VSCode and also some Emacs modes implement this with lsp (language server protocol) which standardizes this across languages.
Since i am new to the project type information and go to definition.... would be nice.

Hey,
actually, not so long time ago I've managed to get the project working under VSCode with all the bells and whistles, both with hie or ghcide. It works fine under stack with basic hie.yaml placed in project directory:
cradle:
  stack:

Try to build the project with stack beforehand. Also, keep in mind that your HIE has to be compiled with the same GHC version as the project. Try out changing resolver to newer one, if that's the case.

Thanks a lot, will give it a try tomorrow and report back.

Guys, please feel free to include that hie.yaml in the repo, particularly if it works for more than one person. I will include my sample cabal.project.local files.

I changed my stack.yaml to:
resolver: lts-14.23
packages: ['.']
extra-deps:
- splitmix-0.0.3@sha256:455de9326ae5bbe5492cbb140fefb04cf988501e25b204dabaf755ab67400d9d,4835
flags: {}
extra-package-dbs: []

and am now able to build the project with stack. VSCode now also starts with "Initializing Stack project". Sadly I now get:
The Haskell HIE (LambdaHack) server crashed 5 times in the last 3 minutes. The server will not be restarted.
From what i read this might hint to a version conflict between HIE ghc and the projects. It seems to me that everything is on 8.6.5 tough. Starting a hie manually in the project folder uses hie-8.6.5 and so does stack.
I will read up on debugging HIE and take a look.

Most recent hie uses nightly-2020-01-31 resolver by default. That's ghc-8.8.2.

BTW, I have no idea if LH works with GHC 8 or 10. Feel free to try and update tested-with field of LambdaHack.cabal. And extend CI to test also the new GHC.

I've just managed to setup hie on my different machine with ubuntu. I struggled for a while, since vscode didn't even try to run hie, but it worked smoothly just after I updated vscode to version 1.42.0.

I am busy for 2-3 days but will give it a try afterwards. Maybe it just works out of the box with:
https://github.com/hmemcpy/haskell-hie-devcontainer
https://code.visualstudio.com/docs/remote/containers
That would easiest and a stable target.

Hi @EHotwagner, how is it going? No pressure, just a token of appreciation for your kind interest. :)

Hi @EHotwagner, how is it going? No pressure, just a token of appreciation for your kind interest. :)

Ah sorry, had to much work the last days and didnt get around to it. Next 2 weeks should be better. I am going through some docker tutorials before tackling this since it seems like a usefull skill anyway.

Wow, cool. Have fun!

BTW, LambdaHack does work fine with GHC 8.8 and 8.10, I've just checked in CI.

@EHotwagner: ping?

Ahh nice. Sorry got cobbled up in different projects and don't have a working Haskell setup right now. I don't think i will get around to test it in the foreseeable future. Feel free to close the issue on my part.

OK. You are warmly welcome to visit any time. We are having fun coding stuff, much of it newcomer-friendly, so we'd help you get started and share in the fun as soon as you feel like it.


Add filter for fields to be rendered

In LaPosta you can set per field whether you would like to display it in the form or not (default is “visible”),  by adding this the plugin only renders the fields that are enabled in LaPosta.
This might be useful when importing subscribers from other mailing services containing data the you would like to save but not display in the rendered form as a field (e.g. opt-in dates).

@mrwijsman sorry for not seeing this sooner! Thanks, looks like a good addition.


Live stream BR download does work,but audio and video not synchronized

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Germany
Provide a description that is worded well enough to be understood
The download does work, but video + audio not synchronized.

Could you try with --postprocessor-args "Merger:-copyts"?

I did try :
yt-dlp --postprocessor-args "Merger:-copyts" -o "%(title)s.%(ext)s" "https://www.ardmediathek.de/br/live/Y3JpZDovL2JyLmRlL0xpdmVzdHJlYW0tQlItU8O8ZA"
but with the same not synchronized result.


CronosPlus .cpy format support

CronosPlus has an option to backup a "bank" with its data and indices into compressed .cpy archive. Are there plans to support this kind of a database in the future?

Entropy:
Reference link: restoring CronosPlus backup (in russian)

This is what I figured so far:
.cpy files start with either:
"CroArc01CroBdCopy" 03 00
"CroArc01CroBdCopy" 02 00
or
"CroArc01CroOutFormCopy" 02 00
followed by a sequence of:

DWORD  chunksize
BYTE   chunk[chunksize]

The format / encoding of the chunks is not immediately obvious to me.  That will require some more work to figure it out.


bumping to Locust 2.10.1

According to my tests, Locust 2.10.1 does not introduce other configuration changes with impact to the deployment scripts

Thanks!


How to fix icons?

the icons are glitching like this:

how do i fix that?

I'm not sure, but I'll figure it out lol

the icons are glitching like this:
how do i fix that?

make sure your icons are the correct size

closing due to inactivity


Live collaboration via email invite?

Hey folks, I've been using excalidraw for quite some time and great experience so far.
If I may draw a comparison with Google drawings, I'm having muuuuuuch better user experience on excalidraw than Google drawings.
The only concern is that, typically when using Google drawings, we can invite people by email to collaborate, whereas on excalidraw, we don't have this feature and anyone with the session link can join.
This seems to be a concern to new adopters of excalidraw, and so I'm asking if we could have email-invite on live-collaboration of excalidraw?
Thanks

We don't support user authentication and it's not really possible without it. So at the moment this is out of the scope. Of course there are pros and cons in each solution, but right now we don't require any login to use it and the collaboration is end to end encrypted.

We don't support user authentication and it's not really possible without it. So at the moment this is out of the scope. Of course there are pros and cons in each solution, but right now we don't require any login to use it and the collaboration is end to end encrypted.


Add codesponsor.io badge

PR for https://github.com/badges/shields/issues/1042

Update: It's fine to leave the logo checked in. With #1092 it can be turned on using ?logo=codesponsor. However, it should be turned off by default.

Are these requests expected to work without a valid token? I can't get them to. I've fiddled with the tests for a while.
Feel free to ping this issue or repoen. I can't test or merge this without your help.

Hi @paulmelnikow I just saw this. I apologize for the delayed reply. I will make the requested changes and will provide a token to test with.

Sounds good, and no worries!


BL808 not work as normal after download firmware

I have received M1S Dock BL808 today , so excited.
I followed instructions and was successful in downloading "hello_world.bin".
However, after download, the M1S seems to be working nothing. When I tried "Open Uart", it said "Open /dev/ttyUSB1 fail".
How can I do to bring it back to work again?  Thank you.

OK. I've managed to bring it back again by using TF2JTAG. Not sure how.


word wrap not saved between restarts

Issue Type: Bug
select "View - Word Wrap", restart VS
VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.93GB (21.98GB free)

Process Argv
--crash-reporter-id 1302d358-09bd-43ec-99f2-e1b1afeb467a

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

auto-close-tag
for
0.5.13

eml
lei
0.4.0

csharp
ms-
1.23.17

remote-wsl
ms-
0.63.13

powershell
ms-
2021.12.0

code-spell-checker
str
2.0.14

See #103199

@gjsjohnmurray the issue you linked talks about "open documents".

This setting should be global (not "per document"). Just like it is in all other text editors on this planet literally (including the "full" Visual Studio). Don't break our habits.

This setting should be preserved between restarts.

Did you try using the editor.wordWrap setting?

Did you try using the editor.wordWrap setting?

@gjsjohnmurray I did not, thanks for guiding me, but isn't it the same as the mentioned menu toggle?


Namespace 'React' has no exported member 'VoidFunctionComponent'

Hi team,
I am working on "react": "16.11.0" with typescript and using  "swiper": "^8.2.2". I got  the following error while creating a build package.
**node_modules/swiper/react/swiper-react.d.ts:473:34 - error TS2694: Namespace 'React' has no exported member 'VoidFunctionComponent'.

473 declare const SwiperSlide: React.VoidFunctionComponent<SwiperSlideProps>;
                                     ~~~~~~~~~~~~~~~~~~~~~
Found 1 error.**

I have also look into the swiper github repo and find that the package contain a wrong type name "VoidFunctionComponent" instead it will be "FunctionComponent".
Kindly fix this in you repo and also provide the solution for the above issue.
Thanks

Issue is closed because of outdated/irrelevant/not actual/needed more information/inactivity.
If this issue is still actual and reproducible for latest version of Swiper, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


cannot able to get list type when running in terminal in python

Issue Type: Feature Request
following is the error when i try to run the following command in the terminal provided by visual studio code.
jitender@jitender-linux:~/Jitender/Codes$ x = list()
bash: syntax error near unexpected token `('
while in gnome terminal  when i run the command.
x = list()
type(x)
it gives the result as type = list
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T16:04:33.747Z)
OS version: Linux x64 4.13.0-43-generic

Can you post a screenshot?


Modify dockerfile build script and add a new README_zh_CN.md file for dockerfile

Modify dockerfile build script
Add something about how to build a docker image
Add a new README_zh_CN.md file for dockerfile

Codecov Report

Merging #2014 into dev will increase coverage by 0.92%.
The diff coverage is 72.96%.

@@             Coverage Diff              @@
##                dev    #2014      +/-   ##
============================================
+ Coverage     31.05%   31.97%   +0.92%
- Complexity     1413     1512      +99
============================================
  Files           311      311
  Lines         15400    15402       +2
  Branches       1864     1864
============================================
+ Hits           4782     4925     +143
+ Misses        10114     9967     -147
- Partials        504      510       +6

Impacted Files
Coverage Δ
Complexity Δ

...pache/dolphinscheduler/common/enums/QueryType.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...hinscheduler/common/utils/TaskParametersUtils.java
73.68% <0%> (ø)
11 <0> (ø)
:arrow_down:

...lphinscheduler/server/worker/task/TaskManager.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...phinscheduler/server/worker/task/AbstractTask.java
11.94% <0%> (ø)
2 <0> (ø)
:arrow_down:

...ommon/task/sqoop/sources/SourceMysqlParameter.java
100% <100%> (+100%)
19 <19> (+19)
:arrow_up:

...common/task/sqoop/sources/SourceHiveParameter.java
100% <100%> (+100%)
9 <9> (+9)
:arrow_up:

...common/task/sqoop/sources/SourceHdfsParameter.java
100% <100%> (+100%)
3 <3> (+3)
:arrow_up:

...ommon/task/sqoop/targets/TargetMysqlParameter.java
100% <100%> (+100%)
19 <19> (+19)
:arrow_up:

...common/task/sqoop/targets/TargetHiveParameter.java
100% <100%> (+100%)
17 <17> (+17)
:arrow_up:

...common/task/sqoop/targets/TargetHdfsParameter.java
100% <100%> (+100%)
13 <13> (+13)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747f022...a56a2fa. Read the comment docs.


call EL functions based on timestamp

Signed-off-by: Paul Harris<EMAIL_ADDRESS>Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

This PR is no longer required as the alternate slot approach worked well.


JS refactoring

this fixes https://github.com/iommirocks/iommi/issues/418

iommi.js
// TODO should this be somehow conditioned? so people can create their own extended instance?
I'd like to hear your opinion, I think it might be good for an inherited class
maybe by a "global" variable, or a data attribute on , or something

events iommi.init.start and iommi.init.end arent exactly "inits", or they are, but not constructor-init
if you have any better name, fire away

notice // deprecated, also it doesn't make sense to start spinner here imo
I have no idea why spinner should be there ?

short info
I made two js classes - IommiBase and IommiSelect2
instance of the first one is in window.iommi, second as window.iommi.select2
I made all old functions deprecated, but left them there. If someone calls them, they get console.warn(...)
custom events
iommi.init.start before functions/dependencies are being bound on elements
iommi.init.end after -||-
iommi.error when error occurs (only ajax errors for now, e.g. someone got logged out and receives html 403 instead of json, or when they're offline), good for popping up error messages to the user, triggered on any related elements, but probably better to listen on document
iommi.element.populated - (for now only) table got loaded on filtering or paginating or reloaded, triggered on container; e.g. I use that for an "export csv" link, which I have above container and I want it to take in account filters
iommi.loading.start - ajax loading started - good for showing spinners, triggered on container, or form for filter-form ajax validation
iommi.loading.end - ajax loading ended - good for hiding spinners, triggered on the same element
element objects of filter form and table container get now iommi object with specific functions/attributes
useful may be container.iommi.reload(), e.g. if user was afk for a long time and you want to reload the table, or based on websocket messages, or anything
ad 10) iommi_validate_form throwing JS errors on field errors (fields)
you can test it if you have a select in a filter form: you change option value in the debugger and then select that option, you get now html5 validation error on the select
IommiBase.addLiveEventListener is kinda like simple version of live $(selector).on() in jquery, I didnt want to be dependent on jquery
file-inputs in filter-forms are as "todo" for now, I hardly think anybody will need it anytime soon
I got rid of axios and used fetch instead, with AbortController per container/form, not global
MAIN NEWS
pagination is via ajax now


using a Lyon Path in a GeometryBuilder results in a panic

The resulting Mesh has a Vertex_Position attribute, but not a Vertex_Position_2D attribute:
[src/main.rs:70] meshes.get(&trail.mesh).unwrap() = Mesh {
    primitive_topology: TriangleList,
    attributes: {
        "Vertex_Normal": Float3([ … ]),
        "Vertex_Position": Float3([ … ]),
        "Vertex_Uv": Float2([ … ]),
    }
    indices: Some(U32([ … ])),
}

thread 'Compute Task Pool (4)' panicked at 'Attribute Vertex_Position_2D is required by shader, but not supplied by mesh. Either remove the attribute from the shader or supply the attribute (Vertex_Position_2D) to the mesh.', /home/db48x/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_render-0.5.0/src/pipeline/pipeline_compiler.rs:231:17

Though I suppose I could be doing something wrong. Perhaps we could work on an example with a system that modifies the shape that gets drawn?

bevy_prototype_lyon uses custom shaders with custom attributes. If you remove the Vertex_Normal attribute and change the Vertex_Position attribute with Vertex_Position_2D (it is a Float2) it may work. Also, the shader accepts also a Vertex_Color attribute.
You can also draw paths using the PathBuilder API or by implementing Geometry on a custom struct.

Yea, I was trying to use PathBuilder. However, I think the code was going wrong somehow. I think it was building the path correctly, but then retrieving the wrong mesh from somewhere and attempting to use it. Here’s the code I wrote:
fn trail_system(mut commands: Commands,
                mut meshes: ResMut<Assets<Mesh>>,
                mut q: Query<(Entity, &mut Trail, &mut Transform, &mut Handle<Mesh>)>) {
    for (e, mut tr, p, mut h) in q.iter_mut() {
        //dbg!(meshes.get_mut(&*h).unwrap());
        //dbg!(&h);
        //todo!();
        if tr.path.len() >= 32 {
            tr.path.resize(32, Vec3::new(f32::NAN, f32::NAN, f32::NAN));
        }
        tr.path.insert(0, p.translation);

        let mut geometry = GeometryBuilder::new();
        let mut path = PathBuilder::new();
        let points = tr.path.iter();
        path.move_to(Vec2::new(0.0, 0.0));
        for &p1 in points {
            let p1 = Vec2::from(p1 - p.translation);
            path.line_to(p1);
        }
        geometry.add(&path.build());
        geometry.add(&shapes::Circle {
            radius: 2.0,
            center: Vec2::ZERO,
        });
        let trail = geometry.build(
            ShapeColors::new(Color::RED),
            DrawMode::Fill(FillOptions::DEFAULT),
            *p,
        );
        //let mesh = meshes.get_mut(dbg!(&trail.mesh)).unwrap();
        //let vertices = mesh.attribute_mut(Mesh::ATTRIBUTE_POSITION);
        //if let Some(bevy::render::mesh::VertexAttributeValues::Float3(vs)) = vertices {
        //    let mut new_vs: Vec<[f32; 2]> = Vec::with_capacity(vs.len());
        //    let mut new_colors: Vec<[f32; 4]> = Vec::with_capacity(vs.len());
        //    for v in vs {
        //        new_vs.push(v[0..2].try_into().expect("!"));
        //        new_colors.push([1.0, 0.0, 1.0, 1.0]);
        //    }
        //    const ATTRIBUTE_POSITION_2D: &str = "Vertex_Position_2D";
        //    mesh.set_attribute(ATTRIBUTE_POSITION_2D, new_vs);
        //    mesh.set_attribute(Mesh::ATTRIBUTE_COLOR, new_colors);
        //}
        //dbg!(&mesh);
        *h = trail.mesh;
        //commands.entity(e).insert_bundle(trail);
        //todo!();
    }
}


[Backport]2.4: Fix return err when secret webhook-receiver is not found

Problem:
The user has not configured an alert that requires webhook-receiver, but will still receive the error log secret webhook-receiver is not found.
Solution:
Execute syncWebhookConfig only when webhook-receiver.enabled is true
Relate issue:
https://github.com/rancher/rancher/issues/28954

https://github.com/rancher/rancher/issues/30088


telepathy-qt: 0.9.7 -> 0.9.8

Motivation for this change
Telepathy 0.9.8 has been out for quite some while.

telepathy 0.9.8 no longer supports Qt 5, so telepathy-qt and telepathy_qt has been made an alias for libsForQt5.telepathy.
telepathy 0.9.8 uses Python 3 instead of Python 2, so that has been corrected in the package.
telepathy 0.9.8 includes the patch that was previously manually added, so therefore it is removed from the package.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

It should also remove a duplicate callPackage, checking one extra box off for #39840

Thank you.

Thank you.


Out-of-date TaxBrain code in test_celery_tasks.py

Looking through the PolicyBrain source code, I found the following in the
deploy/taxbrain_server/tests/test_celery_tasks.py file:
@contextlib.contextmanager
def patch_taxcalc_dropq():
    old1 = ct.taxcalc.dropq.calculate_baseline_and_reform
    old2 = ct.taxcalc.dropq.groupby_means_and_comparisons
    old3 = ct.taxcalc.dropq.pd.DataFrame
    old4 = ct.taxcalc.dropq.create_json_table
    try:
        def do_nothing(n, *args, **kwargs):
            if n == 'as_dict':
                return {'abc': [1]}
            return tuple(mock.MagicMock() for _ in range(n))
        ct.taxcalc.dropq.calculate_baseline_and_reform = partial(do_nothing, 3)
        ct.taxcalc.dropq.groupby_means_and_comparisons = partial(do_nothing, 19)
        ct.taxcalc.dropq.pd.DataFrame = partial(do_nothing, 1)
        ct.taxcalc.dropq.create_json_table = partial(do_nothing, 'as_dict')
        yield True
    finally:
        ct.taxcalc.dropq.calculate_baseline_and_reform = old1
        ct.taxcalc.dropq.groupby_means_and_comparisons = old2
        ct.taxcalc.dropq.pd.DataFrame = old3
        ct.taxcalc.dropq.create_json_table = old4

Not sure if these tests ever get run, but the dropq hasn't had a calculate_baseline_and_reform or a groupby_means_and_comparisons member for quite some time.  Perhaps some clean-up is in order.

@martinholmer, thanks very much for finding this area for improvement. Could you please update the issue name to something more specific and informative? Perhaps something like, "out of date dropq calls in test_celery_tasks.py"

Resolved via #910


0.2.0 Missing initial update

The example below displays an initial blank page and after a second the message "data updated".
It seems the initial update, rendering the message "data NOT updated", is not called.
"use strict";

// foo.template.js
class FooTemplate {
    static update(render, state) {
        render`<p> ${state.data} </p>`;
    }
}

// foo.controller.js
class FooController {
    constructor(render, template) {
        this.state = Introspected({
            data: "data NOT updated"
        }, state => template.update(render, state));

        setTimeout(() => {
            this.state.data = "data updated";
        }, 1000);
    }
}

// foo.component.js
class FooComponent {
    constructor() {
        const el = document.querySelector("foo");
        const render = hyperHTML.bind(el);

        this.fooController = new FooController(render, FooTemplate);
    }
}

// foo.module.js
new FooComponent();

Live example: https://plnkr.co/edit/JMQnl9qssBwxdj1ad3dp?p=preview

interesting, you are expecting an update call even if nothing was updated, correct?
It might make sense to notify with an empty path once after the initial import though, I'll update this.

Well., I noticed the diff w.r.t the previous version.
Same behaviour with
        this.state = Introspected({},
            state => template.update(render, state));

        this.data = "data NOT updated";

        setTimeout(() => {
            this.state.data = "data updated";
        }, 1000);

No, I was wrong: it is ok.

I see Introspected.observe = Introspected;.
Maybe it is an opinionated behaviour, but I think it is expected the initial update when the Introspected object is created: Introspect observes, froma semantic point of view, an empty state and then an initial one. :)

It might make sense to notify with an empty path once after the initial import though, I'll update this.

Agreed.

on a second thought, when you are introspecting some data you are in a setup phase, invoking the callback before the variable is even returned might cause undesired issues, delaying the first invocation might cause flicks.
Since by contract the callback is invoked when there is an update or change, I actually think you should do things differently:

you know the data is fully imported, render after
you import less data and you add or change things after, updates are triggered

Accordingly, I'd write your example as such:
const update = state => template.update(render, state);
this.state = Introspected(
  {data: "data NOT updated"},
  update
);
update();

This gives you full control on when you want to trigger the first update based on the imported state.
It seems a cleaner approach. Thoughts?

I see Introspected.observe = Introspected;.

It's mostly a migration pattern from 0.1 'cause now any introspected is observed by default but more callbacks can be added later on at any time.
Signature is now Introspected(serializable[, callback])
Should update the README too

look, we're playing around at this stage so I'll put in the version that triggers first callback via an empty path.
Maybe it's the most handy pattern after all, and it's easy to avoid such call simply not passing a callback and observing it later on explicitly (that invokes anyway on import).

it's in 0.2.1

Maybe it's the most handy pattern after all, and it's easy to avoid such call simply not passing a callback and observing it later on explicitly (that invokes anyway on import).

Agreed. Tested. Thanks.


sanitize_text_field need to be escaped?

I got this warning:

phpcs: Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'sanitize_text_field'

Now, sanitize_text_field function strip all tags, so I think the use of esc_html isn't necessary.
I know that most common use of this function is to sanitize text from the input user, but the function signature say:

Sanitizes a string from user input or from the database.

So, for example this code is a correct use of the sanitize_text_field function right?
$data->header = get_custom_header(); $data->thumbnail_post = get_post( $data->header->attachment_id ); echo sanitize_text_field( $data->thumbnail_post->post_excerpt )
Could sanitize_text_field considered like the esc_* functions?

No, sanitize_text_field() should still be escaped as a general rule. Consider an HTML attribute:
(DO NOT DO THIS)
<input value="<?php echo sanitize_text_field( wp_unslash( $_GET['s'] ) ) ?>">

This is an XSS vulnerability because someone could maliciously try to supply an s query param that looks like: " oninput="alert( 'DO EVIL' ). Since double quote marks aren't cleaned by sanitize_text_field then it is not safe to use for escaping.


Add local.properties to .gitignore

Do we need this? This should only be generated for Android projects opened in Android Studio.

Do we need this? This should only be generated for Android projects opened in Android Studio.

Great question -- I guess it depends on how many folks will open this in Android Studio -- I at least did :).

Doesn’t hurt.


Gadfly will not show plot in Atom

Hi
im using win 10 and atom, installed gadfly, but the plow will not be shown in Atom.
plot(x=collect(1:100), y=sort(rand(100))) Plot(...)

Are you still running into this problem with the latest Gadfly? Please reopen this and I'll try and troubleshoot.


can not restore repo after webcontainer crash

Describe the bug
can not restore repo after webcontainer crash.
it run npm install very very long time.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-dzwasw
Steps to reproduce

crash
refresh browser
wait

Expected behavior
i want my chat history and restore this project.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 91449508,
  "usedJSHeapSize": 60140492,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = geminiyellow
Chat ID = 8536c2370f10

Additional context
No response

Appreciate the feedback! We are aware of this issue with chat persistence. Temporary workarounds and updates can be found here: #39. (Go to [stackblitz.com](http://stackblitz.com/), login (same credentials as Bolt), click Collections on the left-hand side, click Bolt Collection). Appreciate your patience as improvements continue to be made.


Helper library for creation of CommandCallables

Currently, one can make a command by extending CommandCallable. However, we probably want to provide a helper library to go along with it to make the creation of commands easier.

I'd be interested in taking this on.

Someone in in the process in making some changes to the command code at the moment.

Covered in zml's Commands Overhaul PR.
https://github.com/SpongePowered/SpongeAPI/pull/561


Move storage configuration to serving deployment

This is a card for 0.3. Currently the Core service is the source of truth for subscriptions to data from Serving stores. The goal is to move this source of truth to the serving deployments, and have these deployments update their subscriptions and store configuration to Core.

#254 is meant to solve this


How to set timeout in my scanner?

hello,
I'm having problems scanning a repository, it's taking too long.
detect-secrets scan . --exclude-lines .*: parameterSecurity:/.* --exclude-lines .*: parameter:/.* --exclude-files=package-lock.json
there are scans that are taking 10hrs another 1min ... is it due to the regexp?
However is there any parameter --timeout in the cli?
thanks

What version are you running?

1.0.3

Probably the best way to debug whether it's a specific file is by doing chunks at a time, and enabling debug logs with -vv. I know there's a performance issue on master, but fixes are ready to be merged, and will go out in the next minor version bump.
If you're not running on master, do let us know if you find the performance issue, and we may be able to improve it for others.

@AIGeneratedUsername To scan in verbose mode try detect-secrets -vv scan

We’re going to close this issue as it hasn’t received any update in a very long time. Feel free to re-open it if you think it’s still relevant.


certificates-generation-enhancements

overwriting root certificate with --force option
certificate fields can be customized
devcert issuer is loaded from root certificate
devcert's subject can't be the same as it issuer (@wbachnik I discarded solution that compares only the CN component since it seems to be optional, instead whole DN is compared)

I think we really should have some tests for the added functionality :-)

I will include additional gencerts command and rename the certificates extension into .pem in this PR


GPG key for SSH authentication

For the secure node configuration in the settings, it would be great if you could implement gpg key auth into SSH, next to the user/password SSH authentication method already available.

Not sure about GPG, may be the same thing as I use but referred to by different name.
I would like to see public/private key pair authentication for sec nodes. This is important, as password auth is a far weaker authentication mechanism. I will not enable password authentication on my nodes, but I would very much like to utilize the enhanced security / privacy features of the newest Arizen wallet.

@ThomasFreedman I mean the same as you mean :)

I actually enabled SSH login with username/password out of curiosity just for Arizen.
But I support @ThomasFreedman and @satoshi-ninja and would really like to see a Login with SSH key/Certificate option.

Will be included in v1.1.9