Add support for quay.io registry

This commit adds support for quay.io registry.
The PR https://github.com/sclorg/container-common-scripts/pull/181
has to be merged before and common directory has to be updated as well.
Signed-off-by: Petr "Stone" Hracek<EMAIL_ADDRESS>

Quay.io registry will be used for CentOS7 images instead of dockerhub.io:

https://quay.io/repository/centos7/s2i-base-centos7
https://quay.io/repository/centos7/s2i-core-centos7

16:28:01 Trying to pull repository docker.io/library/centos ...
16:28:01 toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Yeah, that is what I was afraid of :/ I wonder if we can take the centos bae image from somewhere else (centos registry? Quay?)

16:28:01 Trying to pull repository docker.io/library/centos ...
16:28:01 toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

Yeah, that is what I was afraid of :/ I wonder if we can take the centos base image from somewhere else (centos registry? Quay?)
Edit: registry.centos.org/centos/centos:7 might be a good candidate

Sorry, but quay.io was not used yet. Still waiting for merge https://github.com/sclorg/container-common-scripts/pull/181.
As soon as this is merged, I will update common directory as well.

Any reason why not quay.io?

Or we can use quay.io/generic/centos7. Unfortunately, quay.io does not provide any information about this registry. I would prefer  to stay in registry.centos.org

All s2i-{php,ruby,python,perl}-container are built when s2i-base-container is changed. But no PR is filed for CentOS7 quay.io for them. Let's see what happened with tests.

centos7 test failed on conu.

CentOS 7 tests failed on conu in s2i-ruby-container.


update dependencies

Enhanced-resolve seems to have started shipping ES6 code, which breaks node versions that Tern still wants to support.

ah, good point :( I tested locally, but I'm running a late version of node.
Just updated the PR to only upgrade acorn

Thanks. Merged


indicate in cargo build whether incremental is in use

When we print a string like:
Finished dev [unoptimized + debuginfo] target(s) in 35.37s

it might be nice to say include incremental in that string?

With the progress on incremental would this still add value?

I've just spent my day telling different people about CARGO_INCREMENTAL=1 (and the .cargo/config.toml incremental = true, which is probably a better semi-permanent solution), and none of them were aware that release mode had it disabled.
So I think it would be useful to say incremental or non-incremental so that there's at least a hint.

For me, there are so many different factors people might want to be present in their output and our output is already very verbose.  I would lean towards not adding this and finding what we can remove.
I'm going to propose to the cargo team that we close this.

Second.


ntp: update notification

Asana Task/Github Issue:
Description

Testing Steps

Checklist

Please tick all that apply:

[ ] I have tested this change locally
[ ] I have tested this change locally in all supported browsers
[ ] This change will be visible to users
[ ] I have added automated tests that cover this change
[ ] I have ensured the change is gated by config
[ ] This change was covered by a ship review
[ ] This change was covered by a tech design
[ ] Any dependent config has been merged

#1178  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on  Graphite


Provide Meta JSON example in Repo

Can you provide an example JSON model in the repo? The demo site is down and cannot serve out the example. It's trivial to modify the code to look at another URL but not so much to reverse engineer the data model. :)

Can you provide an example JSON model in the repo? The demo site is down and cannot serve out the example. It's trivial to modify the code to look at another URL but not so much to reverse engineer the data model. :)

Thanks for your interest. You can access the demo on https://biominer.3steps.cn/data-model.
If you want to know more about the data model and how to write a new schema file for your custom data dictionary, you can follow these docs.

an example schema: https://github.com/yjcyxky/data-model-viewer/blob/bcab436612264b01d4ae8dee63cedc79b3b088fc/public/data/example.json
create a new data dictionary: https://gen3.org/resources/operator/#3-creating-a-new-data-dictionary
what is a data dictionary and model: https://gen3.org/resources/user/dictionary/

In addition, I should note that  this repo is modified based on windmill from Gen3. so you can get more information from gen3.org


work across namespaces

There can't be routes with the same hostname in different namespaces. That leaves two options for serving the well-known routes (webserver).

Run the letsencrypt management pod with integrated webserver in the same namespace as the routes to use (as implemented now), or
distribute the acme-challenges somehow, so that an external webserver pod can access them.

Integrated Webserver
It has the following big downside: It can't work with multiple namespaces. You'll have to deploy one instance, one service account, one acme credential and set the service account's permissions for every namespace.
It does only use one pod with three containers per namespace though and is conceptional easy.
Separated Webserver
I can think of the following options.

local secrets and respawning one webserver container per namespace (when attached secrets get mounted automatically, respawning might not be necessary. There is a bug about that in kubernetes somewhere). The management pod will then have to attach the secret volume to the webserver pod, wait for the namespace's pod to be available, and remove the volume again. The problem is that there will be one container per namespace pointlessly running constantly. Maybe that can be mitigated with a timeout.
local secret and spawning one webserver per acme-challenge. This will result in many one-shot pods. Maybe if letsencrypt's cron does use one per namespace, that is feasible.

Both will slow down certificate deployments considerable (scheduling, pulling, starting the webserver pod).
I tend to favor a separated webserver and on-demand spawning. Opinions welcome!

I am thinking about the following plan.

Use kube-cert-manager for most parts.
Have one global controller, that watches routes, sets certificates and keys to routes and manages the link to kube-cert-manager.
For each route to manage,

tell kube-cert-manage to manage that domain
create a route /.well-known/acme-challenge pointing to kube-cert-manager, possibly via a proxy (to support different namespaces)

at least until PalmStoneGames/kube-cert-manager#20 is implemented.

Perhaps use dns challenge instead? This would remove the need of proxy'ing the standard acme-challenge.

Have you considered using a modified router image to handle the /.well-known/acme-challenge path globally? It should be possible to use a custom haproxy-config.template to route challenge requests to a handler running in the default namespace either for every route, or limited to routes with a particular label.
I was considering having a hack at it, but thought I'd check in case you'd considered it already and discounted it for good reasons.

I did consider it, but dismissed it. My main argument is that it makes it non-standard and that it's not possible to compose changes to the router template (most of my clients already run a modified template). If you would like to have a go, please do. But keep the following in mind:

make it optional,
implement namespace fencing for domains: don't allow getting a certificate for a domain that is defined in another namespace

The namespace check can be disabled. (At least for Openshift Origin 1.5)
Of course you should only do that if you trust all your users or make sure they can't create routes on there own.
Simple set ROUTER_DISABLE_NAMESPACE_OWNERSHIP_CHECK=true on your router deployment or create your create with the --disable-namespace-ownership-check flag.
https://docs.openshift.org/latest/architecture/core_concepts/routes.html#disable-namespace-ownership-check
https://github.com/openshift/origin/commit/d2dd4668c37281f5b12caf6edfa10c4ec8933693

I meant, that you could circumvent that check when deploying a template including explicit .well-known/acme-challenge.


Breadcrumb text colour on :focus:hover

What is the issue?
The breadcrumb link text on :focus:hover is the wrong colour, it should be $nhsuk-focus-text-color.

Looks to still be an issue. Fix has been applied and waiting to be released in v4.0.0.


Add codecov to README

Pull request
Please confirm that this pull request has done the following:

[x] Tests added (N/A)
[ ] Documentation added (where applicable)
[x] Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
[ ] Description in CHANGELOG.rst added

Adding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
- (`#XX <https://github.com/openscm-project/openscm-units/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/openscm-project/openscm-units/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/openscm-project/openscm-units/issues/YY>`_)

Codecov Report

Merging #4 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           79        79
  Branches        11        11
=========================================
  Hits            79        79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77fae72...690317e. Read the comment docs.


use of census_status 2

I had been thinking that census_status 2 meant "in process" and that it was used to say a tree was not complete, e.g. awaiting mortality census.
My code is only looking at census_status 1 to check for mortality census error. But you all have been selecting "complete" even when the tree needs to be revisited for mortality.
This means that mortality errors are showing up right now (e.g. missing crown position).
I see 3 solutions:

We just ignore the mortality errors for now (but they look bad on the map :-))
I turn them off (I'll need to remember to turn them on again)
Census crew uses "problem" for those trees that need to be revisited (which may be helpful to see on the map, when the time of the mortality census comes)

Let me know what you prefer!

I think it's easiest to have the trees that need to be visited for the mortality census marked as incomplete on the ArcGIS map, as opposed to having to identify them from the GitHub error reports.

We did decide in the field to mark those that needed to be revisited for mortality as in process, so hopefully that is only an issue in the first one or two plots? We'll be more careful about leaving them as in process in the future!

Great! thanks!


Fix unit tests for arm64 with race detector

They are being enabled in PR https://github.com/cilium/cilium/pull/12789 and seem to be currently failing.
Successfully built 7ecfbcaed6e7
Successfully tagged cilium/docs-builder:latest
rm -rf cmdref/cilium*.md
docker container run --rm --workdir /src/Documentation --volume /home/travis/gopath/src/github.com/cilium/cilium/Documentation/..:/src --env READTHEDOCS_VERSION= --env SKIP_LINT= --user "2000:2000" cilium/docs-builder ./update-cmdref.sh
Error relocating /src/cilium/cilium: __vfprintf_chk: symbol not found
Error relocating /src/cilium/cilium: __fprintf_chk: symbol not found
make[1]: *** [Makefile:30: update-cmdref] Error 127
make[1]: Leaving directory '/home/travis/gopath/src/github.com/cilium/cilium/Documentation'
make: *** [Makefile:563: postcheck] Error 2
travis_time:end:0a33cb72:start=1600785661326828654,finish=1600785908767495842,duration=247440667188,event=script
The command "./.travis/build.sh" exited with 2.

Done. Your build exited with 1.

This is definitely the case of of binaries being compiled agains a different glibc, namely we compile e.g. cilium-agent on the host, and then we trying to run that binary inside docs builder container. Can this race detector job skip update-cmdref make target?

This is definitely the case of of binaries being compiled agains a different glibc, namely we compile e.g. cilium-agent on the host, and then we trying to run that binary inside docs builder container. Can this race detector job skip update-cmdref make target?

Sure, if it doesn't matter is just a matter of adding an if statement to skip the update-cmdref on unit testing

This issue seems still present on master: https://app.travis-ci.com/github/cilium/cilium/jobs/538335647

We're building the test suite with CGO_ENABLED=0 for a while now. (murmur3 test used to link against a C implementation for comparison)
Do we still want to run with race detector enabled on arm64? We already run them on amd64, not sure if there's a benefit.

Agreed with what Timo wrote. Closing.


Add provider.aws.version

Ran Plan in dir: . workspace: default
Plan Failed: This project is currently locked by #1. The locking plan must be applied or discarded before future plans can execute.

changes are already in master


Improve install of templates from places other than npm registry

[x] I have reviewed the documentation
[x] I have searched existing issues
[x] I am using the latest React Native version

When trying to install a project template from other place than published as a npm package (github forks, local filesystem, local tarfile, http server...) I can't be able to do it due to several problems. Debuging them, I get to the conclussion the problem is at https://github.com/facebook/react-native/blob/26684cf3adf4094eb6c405d345a75bf8c7c0bf88/local-cli/generator/templates.js#L112-L120, not processing the template name correctly. Problems I've found in this code snippet are:

lack of support to download a git project subpath (seems a problem in npm not supporting mono-repos)
templateName gets not cleaned, file extension should be removed
templateName can't be different of the package name at the template package.json file, correct name should be extracted once the template is installed
when installed from npm, installPackage is just a concatenation of the string react-native-template- and the provided template name, not allowing to use scoped packages as templates. Provided template should be checked and splitted, and the scoped prefixed to the generated templateName

Environment
Environment:
  OS: Linux 4.13
  Node: 9.11.1
  Yarn: Not Found
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: N/A
  Android Studio: 3.1 AI-173.4697961

Packages: (wanted => installed)
  react: 16.3.1 => 16.3.1
  react-native: 0.55.2 => 0.55.2

Steps to Reproduce
Try to init a React Native project using a template from a git mono-repo, or from a local filesystem folder, or from a tarfile on the local filesystem or a web server, or from a scoped npm package.
Expected Behavior
All the provided methods should be able to correctly install the provided template.
Actual Behavior
All of them fails.

This issue still needs community's attention. Can someone review it?

Yes, it still happens.

Still happening with React Native 0.57.8.

@piranna, would you be open to move this to CLI repository and work together with us to improve this support? We are working on init right now and templates support is on our radar. Our team doesn't check this repository actively and issues like this can skip from our attention.

Hi @grabbou, where's the CLI repository? How can I be able to move this?

It's here -> https://github.com/react-native-community/react-native-cli/
I am afraid you just need to reopen issues there, close the ones here and (optionally), submit a PR again.

Closing as this should be filed in the CLI as noted above 👌


Dark theme not working

The dark theme options for the editor is not working on the Windows 10 Preview 17134.

The color scheme 'Dark' is suppose to work only for the Editor background (where the frame is displayed).
Can you show me a screenshot of what you are seeing?

Oh I see, yes then it does work. But the recorder theme is definitely not dark(er).

Well, you selected "Medium". It's gray-ish but not dark. If you wish to change the colors, just click on the rectangles under the "Color scheme" selector.


Support generic type in intellisense

Description
Support generic in Intellisense
["cva\\(([^)]*)\\)", "[\"'`]([^\"'`]*).*?[\"'`]"],

👉
["cva(?:<[^>]*>)?([^)]*)", "[\"'`]([^\"'`]*).*?[\"'`]"],

AS-IS

TO-BE

Support non generic, generic both

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Thanks for the PR, but I’m afraid cva isn’t designed to accept generic type — it’s merely intended for internal usage only! (this has been made clearer for v1)


Update request: alacritty 0.12.3 → 0.13.2

Can someone guide to update alacritty package?

I assume this is a backport to 23.11 request, since nixos-unstable already is on v0.13.2.

So should I go ahead and update the pkg?

Already created a backport.


chore: make clippy happy

Can we unpin it in CI now? https://github.com/paradigmxyz/reth/pull/11401#issuecomment-2387845456

I really dont know why this started failing -.-
I used latest nightly locally and it currently has some issues so I#d like to keep it pinned


Fix memory leak for NavigationService

I discovered that the navigation lib has a memory leak which is already fixed in the mapbox implementation:
https://github.com/mapbox/mapbox-navigation-android/issues/275
I think it would be a good idea to adapt those changes to fix the leak.
I would be up to implement the changes.
What do you think? Any thoughts why we should not adapt to the new/fixed NavigationService implementation?

Thanks for looking into this, it this leak exists in our codebase as well, we should definitely fix it 👍. Back then the code was still MIT licensed, so it shouldn't be an issue to use this here.


Review liquidstaking module

Description

DO NOT MERGE THIS PR
This PR contains review of liquidstaking module. It is only for the purpose of improving code quality, consistency, and readability.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Appropriate labels applied
[ ] Targeted PR against correct branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Thank you for your suggestions.  I applied it with this commit. https://github.com/cosmosquad-labs/squad/pull/278/commits/dba9bf15c5720a7a8938d79bcc0ccec3ee79e0a2

Let me close this issue due to suggestions applied on https://github.com/cosmosquad-labs/squad/pull/278


Parsing A/V METS' duration and width, height

It is understood that Goobi copies the id3 tag/exif metadata for a video or audio file to create technical metadata information in the METS for duration (both video and audio) and width, height (video).
DDS needs to read this technical information now in order to create the IIIF. However, the duration and width, height formats in the METS are not consistent. For example:
The MPG:
      <premis:significantPropertiesType>Duration</premis:significantPropertiesType>
      <premis:significantPropertiesValue>12mn 56s</premis:significantPropertiesValue>

      <premis:significantPropertiesType>ImageWidth</premis:significantPropertiesType>
      <premis:significantPropertiesValue>2048</premis:significantPropertiesValue>

      <premis:significantPropertiesType>ImageHeight</premis:significantPropertiesType>
      <premis:significantPropertiesValue>2048</premis:significantPropertiesValue>

The MXF:
      <premis:significantPropertiesType>Duration</premis:significantPropertiesType>
      <premis:significantPropertiesValue>12 min 56 s</premis:significantPropertiesValue>

      <premis:significantPropertiesType>ImageWidth</premis:significantPropertiesType>
      <premis:significantPropertiesValue>2 048 pixels</premis:significantPropertiesValue>

      <premis:significantPropertiesType>ImageHeight</premis:significantPropertiesType>
      <premis:significantPropertiesValue>2 048 pixels</premis:significantPropertiesValue>

DDS will likely be able to parse these values for its own purposes but Digirati believe it's best practice to just have it read directly from the METS if possible.
Is Goobi able to parse the id3 tag/exif metadata into standard formats when copying and writing these values to the METS?
Duration would be best in unix time and the width and height would just be integers rather than strings (and without spaces).

I asked Tom Crane about any parser mapping for the different durations, width and heights and this is what I got:

I know we spoke about Goobi parsing the width, height, duration in the METS if it can but DDS can do it if we can't get it to work. Do you have any sort of mapping from your parser on the different formats you need to clean up? Wondering if Intranda can have a look to get them started and covering the same bases
tomcrane  12:33 PM
Hi @ashleyray
I'm afraid our "parser" is just this at the moment:
12:33
https://github.com/wellcomecollection/iiif-builder/blob/0d67feab8043d0f284a24a49da71625f32cf9f7e/src/Wellcome.Dds/Wellcome.Dds.AssetDomainRepositories/Mets/Model/PremisMetadata.cs#L70
12:34
We haven't yet collected a rogues gallery of variant formats. What I was probably going to do there, when we get to it, is do a sweep of all the AV and collect all the duration strings into a file so we can have a look at it.
Ashley Ray (she/her)  12:35 PM
Ahh ok, was hoping you had all the rogues identified! Well, I'll let Intranda know. Where would you sweep the av collection, in DDS?
tomcrane  12:36 PM
No from the METS - using a list generated by DLCS though.
Ashley Ray (she/her)  12:36 PM
Gotcha
tomcrane  12:37 PM
sorry, DDS
12:37
sorry, iiif-builder
12:40
There are several parts to this that have now fallen into place. We can use the catalogue API dumps to generate tasks based on lists of b numbers for the DDS to process. One of those tasks could be to generate AV b numbers. Another task takes this list and reads duration data. We end up with something like
b12345678 | 2mins 5 seconds
b23121212 | 00:34
b78778887 | around half an hour or so
12:40
and so on
12:40
I hope we don't get too many like the last...
12:41
At least we can then see what our parser has to content with, and then make sure it at least makes a success of all these known examples
tomcrane  12:46 PM
The other approach would be to actually measure the duration of the binary file. This would be safer but I think that approach may have been rejected?
12:47
(This also seems like a problem multiple people have solved before)
Ashley Ray (she/her)  12:48 PM
That's good information! I'll pass that on to Intranda and see if we can get Goobi parsing

I've tested film b3216273x on staging and the METS is now showing duration in milliseconds and width/height as numbers only. However, the width is being copied as the height as well in the METS.
The METS says:

While MediaInfo online run manually says:

Can we get the height written to the METS accurately?
Also, the milliseconds is written as 468.292 but if I convert that with the decimal, it's wrong. If I take out the decimal then the time is converted to 7 min 48 s which is correct. Is it supposed to have the decimal in it?

The height is corrected now.
The duration is stored as the requested unix time, which is measured in seconds. So the stored value is 468 sec, 292 ms, this can be converted into 7,80486667 min or 7 min, 48s, 292 ms.
We can change it and store the value as ms only, or we can remove the ms and store only the seconds or we can use another delimiter. It depends on what Digirati wants. Internally we have ms, it can be converted into any format they want.

Awesome, just testing the h/w now. And thanks for explaining the unix time stuff, more just me and Harkiran being unfamiliar than anything else!

Re-ran the film and the METS has the height correct now so I'm going to close this. If we need any other adjustments after speaking to Digirati, I'll open a new ticket.


Upgrade cardano-wallet to build with ghc-9.6

[ ] Make it build.
[ ] Add it to CI.

Done and merged in https://github.com/cardano-foundation/cardano-wallet/pull/4396.


User Management/Authentication

Authentication system to allow us to validate users. Authentik/Authelia/something simple like an email link to click on if the cookie isn't present?

Ability to validate .edu email


how to import cookies?

question in title

Here, I found a random video that might help you: https://youtu.be/H3OTcR2vKxk

The VPN is to make sure the providers won't change the login cookies when loging in from a different country. You can use any VPN or even no VPN at all.

use firefox cookie manager


apply mixins to structure field stubs

Right now they're not applied at all. The tricky bit here is that currently, stub outputs are generated ahead of time and have no runtime dependencies. Mixins change that.

fails here when running mainline allevents
https://github.com/Gethe/wow-ui-source/blob/live/Interface/AddOns/Blizzard_ArtifactUI/Blizzard_ArtifactPerks.lua#L1137


Refactor Interruptible

This PR is an update of this commit : https://github.com/MinaProtocol/mina/pull/12534/commits/10bea7124e9b1daa99f081c244ad9f83b02886e1

!ci-build-me

!ci-build-me

!ci-build-me

!ci-nightly-me

@mrmr1993 I disagree that it's being "smuggled". It's a PR that is entirely orthogonal and that was developed as part of Bitswap effort. It was developed because previous Interruptible contained unnecessarily complicated semantics which made it harder to use, way harder than necessary. Because further Bitswap work uses Interruptible to a great extent, I found this refactoring a good idea, back in 2022.
For precise reason why I considered this refactoring: Bit-catchup algorithm uses ivars for synchronization of deferred action results, and synchronizing current Interruptible with an external-used ivar would require a lot of indirection with a rather complex de-facto "mapping" to Async's scheduler. It all is replaceable by a single ivar to interrupt the computation with very clear mapping to Async scheduler.
As for "are there other things like this in the bitswap work", answer is: likely yes. Because I was developing the branch georgee/bit-catchup in complete isolation from develop of that day (wasn't a good idea, as we realized later), I also refactored some code as I saw fit. We're merging georgeee/bit-catchup branch as a series of self-contained PRs specifically to differentiate between edits, many of which are independent of others. There is a stack of three PRs now, but it's only for convenience, because PRs change same files and as of now we expect that all three of them are worth merging.
We can separately synchronize on the policy of reviewing changes from georgeee/bit-catchup branch. In case of this PR, I performed the review "from scratch". When I was doing that I didn't recall much of detail involving this PR, hence I had to perform the reviewer's work entirely from scratch, so it's not like that I wrote the code and immediately approved my own code.

AFAIU, your main concern is motivation to have this PR in the first place. It's perfectly valid. At the point this refactoring was performed, decision was made within then-present Networking team (consisting of Nathan and I). I'll copy-paste here messages I exchanged in Slack with Nathan on September 12, 2022, before original version of this PR was developed:
George Agapov

One more thing I wanted to discuss. In my PR I'm going to use Interruptible. I've checked the code of it and usages and it seems to me unnecessarily complicated
First, signal type is always unit . In all of the usages.
Second, I see little point in having each monadic action having its own ivar. This is contrived and has no real effect. Because how it's used in practice is that only one action in the call chain will contain a signal-producing interruptor, others are mostly uninterruptible in that or other way

My proposal is to streamline this a bit:

Have a module type largely the same as now, but without signal type (just unit)
Drop lift function
Let the interruptible be instantiated as a first-class module with one ivar created on instantiation
Check this ivar on monadic binds
Allow to interrupt this ivar any time

Nathan Holland

Does each monadic action have it's own ivar? I think the interrupt ivar is passed all the way down through the monad

George Agapov

Each return, lift or uninterruptible creates new ivar. Bind doesn't create new ivars, ofc

Nathan Holland

I didn't realize uninterruptible and return were creating new ivars. We could fix that without a module functor if we wished, but I think the module functor approach better captures the usage of this library.

You are right that most everything is uninterruptible, and I also agree it's implementation is more general than it needs to be. It's worth noting that there is a Deferred_let_syntax module that exists to handle this really common pattern where every bind point besides the first is a deferred wrapped in uninterruptible

George Agapov

So in my opinion we could just use Deferred.t and have a custom Interruptible_deffered_let_syntax instantiated via first class module

let f intr =
  let (module Interruptible_let_syntax) = mkInterruptible intr in
  let open Interruptible_let_syntax in
  Deferred.return () >>= fun () -> Deferred.return ()

let g =
  let intr = Ivar.create () in
  don't_wait_for (f intr);
  Ivar.fill intr ()

Nathan Holland

Ok, this approach makes sense to me. It may be even better to just use a generative functor that also creates the ivar for you as well, and then you can just pull the generated module in order to send and interrupt signal (IIRC, OCaml will like this a lot more at runtime than a dynamically generated first class module).

So @mrmr1993, if you're convinced the design is not good, please point to its weaknesses or present other reasoning why the PR should be discarded. If concern was mainly that it occurred in bit-catchup work "by accident", I hope this message helped to explain motivation for its inclusion.
To summarize, let's consider it as an independent refactoring, that can be viewed as useful or not without relation to bit-catchup.

So @mrmr1993, if you're convinced the design is not good, please point to its weaknesses or present other reasoning why the PR should be discarded.

@georgeee that's not quite how this works. PRs need a good reason to be accepted, not discarded. By default, any PR's destiny is to be closed without merging.
It's hard to judge the interruptible change in the context here. It's something that needs to be considered carefully and deliberately, because it's also used to ensure safety in the transaction pool etc.


Installer fails on Ubuntu

Prerequisites
I can see that another person has had this same issue on a stacktrace forum post:
The .deb installer for brackets fails on Ubuntu. It never completes. I am using Ubuntu 16.04.2 64-bit.

[ ] Can you reproduce the problem with Debug -> Reload Without Extensions?
[ ] Did you perform a cursory search to see if your bug or enhancement is already reported?
[ ] Did you read the Troubleshooting guide?

For more information on how to write a good bug report read here
For more information on how to contribute read here
Description
[Description of the bug or feature]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Versions
Please include the OS and what version of the OS you're running.
Please include the version of Brackets. You can find it under Help -> About Brackets (Windows and Linux) or Brackets -> About Brackets (macOS)

You have to download libgcrypt11 and then you can install it from downloaded .deb using sudo dpkg -i <path of libgrypt .deb file> and then install Brackets using sudo dpkg -i <path of brackets.deb file>

Use gdebi package manager To Install Brackets From downloading latest version u can install gdebi from terimnal
sudo apt install gdebi
then go to *.deb folder Whatever package is and Open It with Gdebi and click install that's it


runed obsidian bricks , runed obsidian bricks alt use runestone stats

their hardness is 1.4 and theyre not blast resistant nor witherproof

oops


Fixed clippy warnings

Fixed some clippy warnings, didn't touch tests/test_prelude.rs:7:25 because i'm not exactly sure what it does right now.

It's more or less to see if the re-exports work, but nontheless, thanks.


Update screenshot 2

https://docs.microsoft.com/en-us/azure/active-directory/enterprise-users/media/directory-delete-howto/delete-directory-list.png
In a latest UX- we have more bullets to check

For example linkedin apps.
Please, update screenshot to latest aad portal state.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ea77d5a9-6619-0f31-9567-6085b7a4b5a2
Version Independent ID: f4cf720d-60dd-f086-3ace-1ff17e427757
Content: Delete an Azure AD organization (tenant) - Azure Active Directory
Content Source: articles/active-directory/enterprise-users/directory-delete-howto.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @curtand
Microsoft Alias: curtand

@SychevIgor
Thanks for your feedback! We will investigate and update as appropriate.

Hi @SychevIgor
Thanks for your contribution! I have several GitHub issues on this article that I'm now able to close. Your updates are to be published today at 3 PM PST.


Docker: unable to install packages in different RUN instructions

Describe the bug
A clear and concise description of what the bug is.
Environment

OS: Linux

To Reproduce
Steps to reproduce the behavior:

Create a Dockerfile with such contents:

FROM gcc:latest
RUN apt-get update && apt-get install -y git curl unzip tar
RUN git clone https://github.com/microsoft/vcpkg.git && cd vcpkg && chmod 777 bootstrap-vcpkg.sh && ./bootstrap-vcpkg.sh
RUN cd vcpkg && ./vcpkg install cpp-httplib
RUN cd vcpkg && ./vcpkg install nlohmann-json

Try to build a docker image:

docker build -t vcpkg-docker-issue .

Expected behavior
Docker image succeeds to build.
Failure logs
RUN cd vcpkg && ./vcpkg install nlohmann-json fails:
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:79 (file):
  file RENAME failed to rename

    /vcpkg/downloads/temp

  to

    /vcpkg/downloads/temp0

  because: Invalid cross-device link

Call Stack (most recent call first):
  ports/nlohmann-json/portfile.cmake:9 (vcpkg_download_distfile)
  ports/nlohmann-json/portfile.cmake:18 (download_src)
  scripts/ports.cmake:85 (include)

Additional context
By the way, merging all in a single RUN instruction works:
FROM gcc:latest
RUN apt-get update && apt-get install -y git curl unzip tar
RUN git clone https://github.com/microsoft/vcpkg.git && cd vcpkg && chmod 777 bootstrap-vcpkg.sh && ./bootstrap-vcpkg.sh && ./vcpkg install cpp-httplib && ./vcpkg install nlohmann-json

Duplicates #4245. Closing.


[WIP]: ICM20689: new standalone driver (8 kHz gyro, 4 kHz accel)

This builds on https://github.com/PX4/Firmware/pull/13103.
Before we can bring this in we need to resolve the NuttX SPI DMA capable issues with DCACHE enabled on F7. https://github.com/PX4/NuttX/pull/61 @davids5

I'll reopen when we're ready.


Transfer Learning on Yolo trained on Coco dataset

Sir,
Can I get add one class on that model? Sir, I want to add one class more on that model but without training again on the coco dataset. Can I do with only the pre-trained model file and dataset of a single class to train the model for 81 class?

If you want to add one more class with the pre-existing classes, you will have to include COCO in your new dataset.


Color picker does not work inside ScrollPane

Color picker does not fill with color inside ScrollPane, and i do not know why.

Hello,
can you provide more details about this issue? console output / sample demo in order to reproduce.
Regards,

Hello, i have no console output about some errors.
If i pick color, colorpicker has this color in it's property, but not filled with it.

But if i double click on colorpicker, it get's previous chosen color

And after that if i click on element nearby with colorpicker, colorpicker again becomes white.

I do not know, maybe it is something with scrollPane behaviour ?
Thank's for answer :)

Hello,
we already tested JFXColorPicker inside ScrollPane and were not able to reproduce the issue. From the attached images it seems that you removed the color label from the color picker using css somehow, can you please re-validate this issue without applying any css?
Regards,

I found the reason of problem, in the css file.
.root{
GB_scrollbar-track: derive(-fx-color, 27.5%);
GB_scrollbar-thumb: derive(-fx-color, -26.3%);
GB_scrollbar-corner-border: derive(GB_scrollbar-track, -10%);
-fx-background: #2b2b2b;
}
If I remove the line: -fx-background: #2b2b2b; then all works fine. Thanks for advice :)
But do you know, how can i set backround color now?

Well,
not sure it's a good idea to put -fx-background property in .root as it will be applied to any node in the scene.
I believe what you are looking for is -fx-background-color :)
.root{
GB_scrollbar-track: derive(-fx-color, 27.5%);
GB_scrollbar-thumb: derive(-fx-color, -26.3%);
GB_scrollbar-corner-border: derive(GB_scrollbar-track, -10%);
-fx-background-color: #2b2b2b;
}

Regards,

Thank you very much !! :) I've solved the problem.
Regards


enhancement request-additional coins

if at all possible maybe you could look at a few of the major exchanges and include at least the coins that they support. this would be a good thing to add so that the strategies works for almost all coins available. there are many coins out there and many that are easy to mine and work from the same hashes as others but need different pools. it would be great to be able to have a list of all of these and even have it 'round-robin' them outside of profitability.

Coins are not built into the app and are not added by updates to the app. They are pulled automatically from the various Coin API's that can be selected and used - CoinWarz by default. You can also use WhatMine, WhatToMine, and CoinChoose. If the coin is there it will show in MultiMiner.
You can also add any coins you want. The dialog on the screen when adding the coin states that it does not need to be in the list. Add the coin, put in the symbol, choose the algo and you should be good to go.
Note that you can add algorithms too, so there should be nothing stopping you from doing these things.
Please check out the Wiki for more info:
https://github.com/nwoolls/MultiMiner/wiki/Crypto-Coins
https://github.com/nwoolls/MultiMiner/wiki/GPU-Algorithms


Restore does not pull the latest backup

When I run development restore production we seem to be importing a backup that is several weeks old. I've confirmed the existence of and successfully imported more recent backups using the heroku commands directly.

@alexauritt, are you saving your backups with the old or the new Heroku Postgres? Backups saved using the old syntax (heroku pgbackups:capture) and the new syntax (heroku pg:backups capture) are actually saved to different places (they use different infrastructure), and so won't be restored by the other system's commands.
If you save a new backup using production backup and then immediately pull it down with development restore production, do you get the correct backup?

The two systems have existed in parallel for many weeks now, in order to allow users to migrate smoothly. Heroku has started to retire the old system, notifying users on an app-by-app basis.

@geoffharcourt aha I'm sure that's it. Thanks for the heads up. Will investigate.

@alexauritt, in preparation for Heroku shutting down the legacy system, Parity 0.7.0 moved to the new PG system.

A teammate and I have both experienced this problem when doing successive runs of development restore production.
We noticed this when we were heavily testing locally and restoring from production frequently. For us, this wasn't related to capturing backups to the wrong repository.
My guess: Either the Heroku API sometimes returns items in an unexpected order, or sometimes Parity uses the old repository and sometimes uses the new repository.
(This could have been fixed upstream already — we noticed the problem about 2 weeks ago and haven't used Parity much since.)

Hi @gohanlon, a small question that might help tracking down what's going on: were you waiting for the prior backup to finish? The new backup system continues to run if you aren't watching it over SSH, so you could potentially pull backups before your newest one is finished.
If you can reproduce this, I'd be interested in trying to figure out what's going on.

@geoffharcourt No explicitly run backup tasks were running. We ran development restore production about 20 times in about 30 minutes while debugging a migration. Most of the restore commands gave the expected database, but about every third restore used a stale snapshot.
I'll definitely report back if we see this again. I'm not sure it'll be easy to reproduce. (And, may not be worth the work to try given that it could already be fixed upstream.)


[mesheryctl] Improve error messages for mesheryctl app commands #6272

Signed-off-by: Kapil Bansal<EMAIL_ADDRESS>Notes for Reviewers
This PR fixes #6272
Signed commits

[ ] Yes, I signed my commits.

Codecov Report
Base: 16.78% // Head: 12.54% // Decreases project coverage by -4.24% :warning:

Coverage data is based on head (7675914) compared to base (416427e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6631      +/-   ##
==========================================
- Coverage   16.78%   12.54%   -4.25%
==========================================
  Files         115      115
  Lines       11218    11218
==========================================
- Hits         1883     1407     -476
- Misses       8860     9497     +637
+ Partials      475      314     -161

Flag
Coverage Δ

gointegrationtests
?

unittests
12.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/app/app.go
43.24% <0.00%> (ø)

mesheryctl/internal/cli/root/app/list.go
33.33% <ø> (ø)

mesheryctl/internal/cli/root/app/offboard.go
47.76% <ø> (ø)

mesheryctl/internal/cli/root/app/view.go
51.31% <ø> (ø)

mesheryctl/internal/cli/root/system/start.go
1.70% <0.00%> (-57.03%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.12% <0.00%> (-53.94%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.17% <0.00%> (-47.06%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.88% <0.00%> (-45.29%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.22% <0.00%> (-41.49%)
:arrow_down:

mesheryctl/internal/cli/root/root.go
24.24% <0.00%> (-40.91%)
:arrow_down:

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


default directory of extensions seems to be wrong

code-server version: server/development linux-x64 node-v8.15.0
OS Version: source, ubuntu, Dockerfile

Description
The default directory of extensions seems to be wrong,
which is in the file /packages/vscode/src/fill/products.ts
dataFolderName: ".code-server",
I guess it should be:
dataFolderName: ".local/share/.code-server",
Steps to Reproduce

docker build using the Dockerfile
docker run
In docker, just coder-server, without specifying the data_dir and extensions_dir.
Install any extension.
The extensions are found in /root/.code-server/extensions, not /root/.local/share/.code-server/extensions. The data_dir is still the default /root/.local/share/.code-server, which is correct.

cool。i choose vim.

@guyuxiang What are the first-level contents of .local/share/.code-server and .code-server when this occurs?

@foresthoffman
Thanks. I should have be more clear.
First level is /root. It occurs when I start with coder-server without specifying data_dir and extension_dir.

This was fixed in https://github.com/codercom/code-server/commit/e597d49912fc0299877899fe687b69da5214794d#diff-4ae0f28b342b8e36b03041e34e5e3339R11 which is included in version 1.32.0-245, but I'm not sure what version the Docker build is using.

Latest was updated 16 minutes ago.

@coderasher @foresthoffman Yes. It is fixed. Thanks. I am closing this issue.


[Issue #3] Creates basic Sinatra app

Worked with @trevormast on generating the
Sinatra scaffold.
Adds Gemfile with app deps
Adds cool css3 buttons for social sign in button
Adds basic layout file and index
Uses slim for template processing
Includes rerurn for auto reloading

Looks great so far but I'd like to submit #7 first for consistency.


Add generic data collector

Add generic data collector where which one can be named and hold any passed data.
Eg. for displaying configuration,

Merged in pull request #24


Added IMU Stabilization to the Gaze Controller

This announcement is about the new feature of the gaze control we have been lately working on, which is now available in our repositories.
We managed to integrate the work of @alecive on gaze stabilization inside the iKinGazeCtrl controller. The work is described in this paper: "Gaze stabilization for humanoid robots: A comprehensive framework".
The tutorial has been extended to include all the code details: http://wiki.icub.org/iCub/main/dox/html/icub_gaze_interface.html#subsec_gaze_stabilization.
The new feature is on by default, but you can always disable it by relying on this command-line option: --imu::mode off.
Remember to update both yarp and icub-main!
What else? Should you experience any inconvenience, please report it asap.
PS: a quick and dirty showcase can be seen here: https://plus.google.com/u/0/+AlessandroRoncone/posts/bbDZHfEbg2G :smile:

And of course take note of https://github.com/robotology/QA/issues/43 as well.


bot stuck to the wrong account

apologies if this is the wrong place for this kind of issue, but I seem to have gotten my installation of the bot stuck to the wrong account. I understand how it happened (I used the wrong OAuth password) but I can't figure out how to fix it, as no amount of modifying (or even deleting) files on my computer changes anything. presumably there are files uploaded elsewhere that would need to be modified/deleted to get this set up on the right account, but I don't know how to do that.

The only files used are local, and the only file that is in charge of determining the account used is settings.json. The Nickname and Authentication determine which account is used as the bot account, i.e. the account that responds to messages. If you want to enable the bot to run on a different Twitch channel, then you would have to change the value under Channel. There's no uploaded files, so there's no need to worry about that.

I tried changing the nickname and authentication, but it continued to use the account I accidently set it to in the beginning as if nothing had changed. the only thing that seems to have effected it was disconnecting the Oauth password generator from the account it was linked to, but all that has done is make it to where it gives me a "Login authentication failed" error regardless of what password I put.

I'm not sure how I fixed it, but its working now

Glad to hear it!


Shadcn: Installed

After cloning the project

Followed the installation guide to install Shadcn to the project
To test it out whether it's installed or not, made a button in the index.vue page under the pages folder

2nd Commit update:
Header and Footer Added -
https://www.loom.com/share/a021ac41026442ae8735f873e01140e9?sid=11e8cb1a-4405-45e7-8e06-4e6bbadff21a

Home component folder added under /component folder
Updated the index.vue file and commented out the initial text connect their

Added an Static Image in the component folder under /AuthenticationStaticSection this will reusable in /login, /register,  /forget-password
Installed two shadcn component : Input and Label

Added folder /ThirdPartyAuthenticationBtns where I've imported Google, github and twitter svg images separately


Allow preflight to target container registries requiring authentication for image pulling and any checks

Is your feature request related to a problem? Please describe.
Yes, Preflight, utilizing Crane, does not allow for interacting with registries behind authentication.
Describe the solution you'd like.
To allow for cases where we need to authenticate to multiple registries, we should accept an environment variable PFLT_REGISTRY_CREDENTIAL that points to a /path/on/disk/dockerconfig.json-style authentication file. This can then be leveraged by CI cases in k8s, where the authentication details may be mounted into a container running preflight that can then be leveraged.
This authentication also needs to be passed to to checks such as RelatedImageManifestsAreSchemaVersion2 in case the related images are also in private registries.
Describe alternatives you've considered.
Currently, there is a partially wired solution that allows for authentication using a username and password, but using a credential file is probably more in line with what we want.
That partially implemented solution can be seen here: https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/main/certification/internal/engine/engine.go#L47-L53
Additional context.

/assign


ServletListener not running after upgrade to Tomcat 10 / JDK17

Environment
Liquibase Version: 4.6.2
Liquibase Integration & Version: servlet
Liquibase Extension(s) & Version:  N/A
Database Vendor & Version: N/A
Operating System Type & Version: N/A
Description
We have been using an adaptation of this https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/integration/servlet/LiquibaseServletListener.java with a tomcat 8 + jdk8 web application and it was working fine.
After migrating to tomcat 10 + jdk17, webapp has been adapted to follow the breaking changes (the fact that Java EE  was migrated from Oracle to the Eclipse Foundation, and that is now called Jakarta EE, which implied a changed in the libraries of the project and a renaming of all javax.xxx imports to jakarta.xxx imports)
Unfortunately, this Liquibase servlet does not like the change.
Steps To Reproduce
List the steps to reproduce the behavior.
Just try to use the https://github.com/liquibase/liquibase/blob/master/liquibase-core/src/main/java/liquibase/integration/servlet/LiquibaseServletListener.java with tomcat 10 and jdk 17
Actual Behavior
Does not compile
And if we add javax.servlet-api-4.0.1.jar to the project so that this servlet can compile, then it is not executed at startup (no issue with the other listeners of the project which run the same way)
No change in web.xml regarding this:
	<context-param>
		<param-name>liquibase.changelog</param-name>
		<param-value>liquibase/db.changelog-master.xml</param-value>
	</context-param>
	<context-param>
		<param-name>liquibase.onerror.fail</param-name>
		<param-value>true</param-value>
	</context-param>
	<listener>
		<listener-class>LiquibaseServletListener</listener-class>
	</listener>

Expected/Desired Behavior
We would like the LiquibaseServletListener to be able to run at startup using tomcat 10 + jdk17

Thanks @Toukite for the details provided here. We will take a look at this in more detail after the holiday break.
Also, wanted to make sure you knew about Liquibase Forum -- it is turning into a pretty solid resource for users and contributors.

So, it's going to take having a separate implementation of LiquibaseServletListener that uses
        <dependency>
            <groupId>jakarta.servlet</groupId>
            <artifactId>jakarta.servlet-api</artifactId>
            <version>5.0.0</version>
            <scope>provided</scope>
        </dependency>

instead of
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>javax.servlet-api</artifactId>
            <version>3.1.0</version>
            <scope>provided</scope>
            <optional>true</optional>
        </dependency>

which will mean creating an alternative LiquibaseServletListener, LiquibaseStatusServlet, and ServletConfigurationValueProvider to use jakarta.servlet.* instead of javax.servlet. *.
Since we need to support both, it will be a question of extracting base classes with the logic and then subclasses with the version-specific methods and implementations in it

@Toukite would you be able to test the build from #2339 to see if it works for you? I don't use Tomcat 10 enough to have a great test environment for it. You can get the build artifacts from the "Checks" tab.
You will have to change your listener class to:
	<listener>
		<listener-class>LiquibaseJakartaServletListener</listener-class>
	</listener>


NEXT-8631 - Add ability to change default currency

1. Why is this change necessary?
Ability to change default currency
2. What does this change do, exactly?
Button in administration to change to a new currency as system default
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

6. Whats missing?
Cause of using plain SQL. Cache Invaldation does not work correctly. Also if deleted the right cache tags are deleted the entire storefront is broken. Even the invalidation from administration does not work anymore.
Looks like system currency changing breaks handling of invalidation. Needs to be debugged.

@wexotht Due to Plain SQL the cache needs to be invalidated. Thats the last missing part.


Substring highlight when in filename

I'm experiencing an issue where it seems to be highlighting a substring when the substring is inside the filename.
```js filename="a/hello/file.js
console.log("hello")
```

This highlights the hello part even though its inside of the filename.

will be fixed with filterMetaString option in  https://github.com/shuding/nextra/pull/1211


Fixed #30994 -- Added Oracle support for AsGeoJSON GIS function.

https://code.djangoproject.com/ticket/30994

buildbot, test on oracle.

@sir-sigurd Thanks for this patch :+1: I added missing changes in docs and pushed minor edits to tests.

buildbot, test on oracle.


mvapich: fix RPATH issues and infiniband build

The rpath fix elimnated too much and thus disabled the mpichversion binary. Diasabling dlopen for infiniband libraries fixes the build for the infinband interface option.
With this patch scalapack completes all tests for the infiniband and omnipath interface selection. However, ethernet is still broken with for the scalapack tests. See https://github.com/NixOS/nixpkgs/issues/258599.
CC @sheepforce This does not solve the problem completely, but you may want to use it with infiniband/omnipath interfaces anyway?
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

CC @sheepforce This does not solve the problem completely, but you may want to use it with infiniband/omnipath interfaces anyway?

Wonderful! This should resolve my problems for now and allow me to use CP2K with MVAPICH2 on an OmniPath cluster, yes.


Add distroless image identification

Should be able to identify a distroless image and determine the version (populating a distro.Distro object from distro.Identify())
Note: anchore-engine has logic for this, which this ticket should keep in parity

Any particular images in mind? I did some googling but syft seems able to resolve the distro, so maybe this image isn't truly distroless:
[0000] DEBUG Application config:-arch-and-opensuseleap) syft gcr.io/distroless/base:latest
configpath: /Users/samdacanay/.syft.yaml
presenteropt: table
output: table
scopeopt: 1
scope: squashed
quiet: false
log:
  structured: false
  levelopt: debug
  level: debug
  filelocation: ""
clioptions:
  configpath: ""
  verbosity: 0
checkforappupdate: false

 ✔ Loaded image
 ✔ Parsed image
 ✔ Cataloged image      [0 packages]
[0000]  INFO cataloging image
[0000] DEBUG image: source=DockerDaemon location=gcr.io/distroless/base:latest processingOption=1 from-lib=steroscope
[0000] DEBUG image metadata: digest=sha256:ae9876e34217211b012fd2d9f1f1bff6041e465623546a0a1b3cbcb6217c73df mediaType=application/vnd.docker.distribution.manifest.v2+json tags=[gcr.io/distroless/base:latest] from-lib=steroscope
[0000] DEBUG layer metadata: index=0 digest=sha256:d72a74c56330b347f7d18b64d2effd93edd695fde25dc301d52c37efbcf4844e mediaType=application/vnd.docker.image.rootfs.diff.tar.gzip from-lib=steroscope
[0000] DEBUG layer metadata: index=1 digest=sha256:f47163e8de57e3e3ccfe89d5dfbd9c252d9eca53dc7906b8db60eddcb876c592 mediaType=application/vnd.docker.image.rootfs.diff.tar.gzip from-lib=steroscope
[0000]  INFO identified distro: debian 9
[0000]  INFO building the catalog
[0000] DEBUG cataloger 'dpkg-cataloger' selected '0' files
[0000] DEBUG cataloger 'bundler-cataloger' selected '0' files
[0000] DEBUG cataloger 'python-cataloger' selected '0' files
[0000] DEBUG cataloger 'rpmdb-cataloger' selected '0' files
[0000] DEBUG cataloger 'java-cataloger' selected '0' files
[0000] DEBUG cataloger 'apkdb-cataloger' selected '0' files
[0000] DEBUG cataloger 'go-cataloger' selected '0' files
[0000] DEBUG cataloger 'javascript-cataloger' selected '0' files
[0000] DEBUG cataloger 'dpkg-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'bundler-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'python-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'rpmdb-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'java-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'apkdb-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'go-cataloger' discovered '0' packages
[0000] DEBUG cataloger 'javascript-cataloger' discovered '0' packages
No packages discovered

good question... @zhill given that we identify the distro based on standard metadata locations (which may be present in these images) is there any additional location we should be looking at (or other approaches entirely) for identifying these kinds of images?

Distroless images are based on a very stripped down version of Debian but the package metadata information ends up in several individual files under /var/lib/dpkg/status.d/ rather than in a single file at /var/lib/dpkg/status

Also, for the debug variants it adds busybox onto the base at /busybox/busybox


cpoptions=$ and matchpairs makes text disappear

What steps will reproduce the problem?
1. set cpoptions=$ in your .vimrc
2. Open a file with matchpairs enabled. For example, set "filetype plugin
indent on" in your .vimrc then open an HTML file.
3. Go to the character after the ending '>' of an HTML tag.
4. Press C to change to end of line.

What is the expected output? What do you see instead?

The matching '<' and '>' are highlighted (as expected), and any part of the
file that's visible below the current line disappears.

What version of MacVim and OS X are you using?

Snapshot 73, 10.10.2 Intel

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 6 Feb 2015 at 3:27

This issue was moved to macvim-dev/macvim#26


Updates to GA4 property, remove redundant analytics files

This is an enhancement or feature.

Summary
Update google analytics to the new GA4 property. Removes redundant analytics files now that GA4 only uses the gtag function

Also removes the anonymize_ip argument, because that happens automatically in GA4. Also removes a redundant analytics snippet and adds a preconnect link to speed up load time


Set environment variables through bash

Hey there,
I have a currenty problem whereby everytime I set a varable using the correct syntax it's prefixing all variables with BASH<number> instead of plainly setting the variable like the docs say it does.
Example:
parameters:
  unique_values:
  - key: 'FOO'
    value: 'servicename1'
  - key: 'BAR'
    value: 'bronze'

steps:
- ${{ each var in parameters.unique_values }}:
  - bash: |
      echo "##vso[task.setvariable variable=BAZ_${{ var.key }};isOutput=true]${{ var.value }}"

- bash: |
    env | grep BAZ_

Outputs:
BASH2_BAZ_BAR=bronze
BASH1_BAZ_FOO=servicename1

The document doesn't nention anything about prefixes being added, why is this happening?
Document: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#set-in-script
Looking into the builds it doesn't have the prefix when it comes to run it:
##[debug]script=echo "##vso[task.setvariable variable=BAZ_FOO;isOutput=true]servicename1"

this is doing the thing:
;isOutput=true
you should use this only in case you want to share the variable in between the jobs.
check the documentation you have posted.

That's expected. As Roman said, it's because of the isOutput=true option you added in the script. Please refer to the documentation regarding multi-job output variables to understand how it works.

Thanks for the clarification, but that's really rather clunky imho, I wouldn't expect the variable not to be locally defined just because I want it to be defined in other jobs too... 🤔 😕
Basically the answers above point to having to do this which is clunky and means repetition:
echo "##vso[task.setvariable variable=BAZ_FOO]servicename1"
echo "##vso[task.setvariable variable=BAZ_FOO;isOutput=true]servicename1"

I understand your concern and I might be wrong but I think that's the only thing possible declaring variables that way, even if they change names.
Think of a scenario like the one described in the documentation where you have the same job executed with different configurations or, in another case, where you have the same job executed sequentially because of a each loop (for example in a template definition). How do you reference a certain variable inside that loop may get complicated (or even impossible) if you don't specify also the name of the job (or anyway change the name of the variable).
Probably the only option could have been to let the user completely free to choose the best name for the variable and let overrides possible in case of the same job being executed multiple times... Or maybe Microsoft just chose to play safe to avoid even more confusion 😄


HLSL: Combine image and sampler on shader model <= 30

When compiling a fragment shader to a HLSL shader model 30, an exception "Separate image and samplers not supported in legacy HLSL." fired from CompilerHLSL::emit_legacy_uniform.
This change combines image and sampler and skip the separated one, if shader model <= 30.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks. Fixed a few additional things on my end, should work similarly to legacy GLSL now.


Update CONUS404 on S3 to include x,y data (that is already on Caldera)

Ensure that there are projected coordinates on all CONUS404 datasets

I would love to attend this session also. And perhaps we can capture the essential knowledge as a pre-processing how-to document to live along side re-chunking and similar.

Sounds good. Should we schedule this for next week sometime?

Yes, would Monday work?

Monday -- wide open except for the HyTest check-in at 11 central.
Tuesday -- Blocked out from 1 to 2 central time, and from 3-4. otherwise open.

Folks, here's my attempt to capture the work we did in the meeting today:
https://nbviewer.org/gist/4db31799d2b677fb54f89be6ca3328c4
I'm happy to report that it seem to be working just fine!

Thanks for the demo today. It was very informative.... and I learned a couple of tricks that helped me figure out the problems I was having with #41.  Two birds/stone today.


chore: upgrade Rust to 1.55.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


K8s autocomplete is missing for various kubectl commands

Autocomplete does not work for:
logs
exec

moving to https://github.com/kui-shell/plugin-kubeui/issues/181


[sushy_emulator] Make instance whitelist optional

recheck

recheck

/lgtm

/approve

@frenzyfriday care to add your approval after the small tweak Lewis did?

/lgtm


ffmpeg error

Everything fine, but when I try to make it work this error appears:
Something went wrong
ffmpeg error (see stderr output for detail)
What should I do to get throught this?

same here..
Processing frames: 100%|████████████████████████████████████████| 273/273 [03:09<00:00,  1.44it/s]
Merging audio with the refaced video...
Traceback (most recent call last):
File "/Users/mac/anaconda3/lib/python3.10/site-packages/gradio/routes.py", line 427, in run_predict
output = await app.get_blocks().process_api(
File "/Users/mac/anaconda3/lib/python3.10/site-packages/gradio/blocks.py", line 1323, in process_api
result = await self.call_function(
File "/Users/mac/anaconda3/lib/python3.10/site-packages/gradio/blocks.py", line 1051, in call_function
prediction = await anyio.to_thread.run_sync(
File "/Users/mac/anaconda3/lib/python3.10/site-packages/anyio/to_thread.py", line 28, in run_sync
return await get_asynclib().run_sync_in_worker_thread(func, *args, cancellable=cancellable,
File "/Users/mac/anaconda3/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 818, in run_sync_in_worker_thread
return await future
File "/Users/mac/anaconda3/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 754, in run
result = context.run(func, *args)
File "/Users/mac/develop/refacer/app.py", line 64, in run
return refacer.reface(video_path,faces)
File "/Users/mac/develop/refacer/refacer.py", line 222, in reface
return self.__convert_video(video_path,output_video_path)
File "/Users/mac/develop/refacer/refacer.py", line 126, in __convert_video
out.run(overwrite_output=True,quiet=True)
File "/Users/mac/anaconda3/lib/python3.10/site-packages/ffmpeg/_run.py", line 325, in run
raise Error('ffmpeg', out, err)
ffmpeg._run.Error: ffmpeg error (see stderr output for detail)

running this fixed my ffmpeg error https://github.com/s0md3v/roop/wiki/1.-Installation


Update repository-branches.md

Why:
Closes #15614
What's being changed:
Prior to the changes included in this PR, the repository-branches.md reusable instructs the reader to locate the "Code & operations" section of the sidebar:

Currently, with the changes included in this PR, the section is appropriately named "Code and automation" to reflect the sidebar section in the Options menu:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jthodge
Thanks so much for opening a PR! I'll get this triaged for review :zap:
Also, I am very curious to how you highlighted a part of the screenshot 💖  Could you let me know what tool you used for that??

Thanks @ramyaparimi  — appreciate you!
The tool I used for the screenshots is Cleanshot X.
It's likely the best money I've $ / quality of life improvement in software I've used in the last two years — can't recommend it enough!

The tool I used for the screenshots is Cleanshot X.

Looks pretty neat!! Thanks for sharing 💖

@felicitymay Thanks for shepherding these changes through to merge! 🎉

No problem. Thanks for your help 🙂


fix-typo-in-acs-engine-autoscaler-readme

fix typo in stable/acs-engine-autoscaler/README.md

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

/ok-to-test
/lgtm

/assign


(WIP) add missing breakpoint and change the other breakpoints

Add xlarge and change some breakpoints according to https://material.io/guidelines/layout/responsive-ui.html#responsive-ui-breakpoints

Well there is a conflict with the official guide
http://materializecss.com/sass.html#media
Small screens are defined as having a max-width of 600px
Medium screens are defined as having a max-width of 992px
Large screen are defined as having a min-width of 993px
Extra Large screen are defined as having a min-width of 1200px

Can you take this or put it in this pr/branch?

Done.

Is the plan to update the breakpoints to the ones listed above or is this now not happening?

What is the current state of this proposed change?


How to

Any inputs on how to use it? Do I just use this instead of "istanbul"?

Hi @mathiasrw, sorry for the late reply! This is meant to be an internal library that is used by the new nyc command line tool. Please take a look at https://istanbul.js.org and feel free to contribute any of your learnings :)


Missing Sublime Text command - Expand selection to brackets

While building this extension to map Sublime Text default keyboard shortcuts to VS Code, I found that this feature is missing.
The feature is expand to brackets.
Default Sublime Text keybindings
Windows / Linux: ctrl+shift+m
Mac: ctrl+shift+m

Today an extension exists with this functionality. I believe we should bring this feature into the product.

⌃+⇧+⌘+→
ctrl+shift+cmd+→

@neolwc unfortunately that functionality is not exactly the same. It will work in some cases but not all.

@waderyan yep. VS code needs this feature.

I just switched to VS code and unfortunately I did not find that feature when I mapped the Sublime text default keyboard shortcuts to VS code. I badly need it!

Dup of https://github.com/Microsoft/vscode/issues/9768, let's track it there. It's on our deck now.


Docs for SQLite state store

Fixes #3085

I've made one additional change to correct information about using URI options


No such file or directory errors

Info

Operating System: ArchLinux
Shell: bash
Terminal: Alacritty
nvim --version: NVIM v0.7.0
fzf --version: 0.30.0 (2093667)

Description
I see the following when some files unacessible:

To reproduce:

git clone --recursive git@github.com:crow-translate/crow-translate.git
cd crow-translate
nvim
:Fzf files

This reminds me of #287: this happens due to error messages being redirected to stderr, it was solved by redirecting the errors to stdout instead, however, this behavior was only experienced on macs, Linux could handle lua’s stderr with no issue.
This can easily be solved applying the same solution as #287 but it’s not optimal, I’d rather have lua’s io.stderr behave properly, I’ll do some research on this.
In the meantime you can easily avoid that by redirecting the underlying command to /dev/null, if you’re using fd you can add 2 > /dev/null to the end of your fd_opts.

Would you be able to test branch 414?
https://github.com/ibhagwan/fzf-lua/tree/414

if you’re using packer you just need to add branch = '414' to the use function.

Tried, the same result.
Above I provided steps to 100% reproduce the issue.

It might be an fzf issue (althought I experience the same with sk), the errors are generated by trying to access invalid symbolic links which prints to stderr, the behavior in the shell is consistent with fzf-lua, try running the below in the terminal (within the crow project):
rg --files --hidden --follow | fzf

Resulting in:

For now you can use 2 different workarounds:
(1) redirect stderr to /dev/null:
:lua require'fzf-lua'.files({cmd = "rg --files --hidden --follow 2>/dev/null"})

(2) disable mutliprocess (WARNING: will have performance impact on large projects):
:lua require'fzf-lua'.files({multiprocess=false})

Technically, the solution I used for #287 (blanket redirect of stderr into stdout) would work here too but before I make this change I'd like to understand what causes fzf to behave in this way as it should be able to handle the stderr stream. It's not really sound logic to eliminate the stderr stream.

(1) redirect stderr to /dev/null:

Yes, using this one, configured it globally.

https://github.com/ibhagwan/fzf-lua/commit/d4ab66551bfa3f4207bca6b6ba4c7a60427fdde8 - this commit adds a few workarounds to control the behavior of the libuv wrapper within FzfLua, there are now a few different ways to solve your issue that don't require modification of any command.
(1) You can instruct FzfLua to discard the error stream altogether:
:lua require'fzf-lua'.files({stderr=false})

(2) You can redirect stderr to stdout (the default on MacOS) so you can still see if you have errors within the fzf output:
:lua require'fzf-lua'.files({stderr_to_stdout=true})

(3) Not sure why anyone would do this but it's also possible to redirect the error stream to a file:
:lua require'fzf-lua'.files({stderr='/home/user/<path to error file>'})

Note that difference between (1) and (2), discarding the error stream means you won't see errors at all and total number of results will be only the accessible files, in the case of your project that's 8376 files:

:lua require'fzf-lua'.files({cmd = "rg --files --hidden --follow -g '!.git'", stderr=false})

While redirecting stderr to stdout adds the inaccessible files as error entries resulting in 20257 entries:

:lua require'fzf-lua'.files({cmd = "rg --files --hidden --follow -g '!.git'", stderr_to_stdout=true})

Many of which are the errors:

I'm still unsure why fzf|sk can't handle stderr properly (as evident by running rg --files --hidden --follow | fzf in the shell) but this should conclude this issue, if I find any new info I'll update this thread.

https://github.com/junegunn/fzf/issues/1901 - somewhat old issue but it seems thatrg output to stderr is causing a graphic glitch (same one we experienced in this issue) and the fzf maintainer also recommended redirecting errors to /dev/null so I'm pretty sure there's nothing else to be done for this issue other than discard/redirect stderr.

Thanks! But is it possible to set it globally?

Thanks! But is it possible to set it globally?

Not globally because you don't need it globally, this only affects providers which run in multiprocess (FzfLua's headless shell wrapper, used to enhance performance by running an external neovim process) which means only files, grep and git (which doesn't need this probably) will be affected by this setting.
You can set this semi-globally with:
require'fzf-lua'.setup {
  files = {
    stderr = false,  -- or `stderr_to_stdout = true` if you prefer
  },
  grep = {
    stderr = false,
  },
}

Yes, this is exactly what I meant, thanks again!


EB-218: Add testing to the website using playwright

This PR is to add Playwright tests for the website.

The file playwright/Running_Playwright.md contains some documentation on how to run the tests.

One thing I'm pleased about with these tests is that new species pages will be automatically picked up by the test suite. So this should be a good way to catch issues when a new species is added.
Timing wise, when run in parallel it takes about 45 seconds on my laptop (about ~15 seconds of which is waiting 3 x 5 seconds for each failed assertion test to Timeout - default is 5 seconds).
Additional Notes:

This PR does not include a GH actions workflow to run the tests. I think this should be a separate PR later instead. This is because some tests (3) are currently failing (but that is because they should). I therefore want to fix those (either by changing the test or changing something on the site) with Daniel first.

There is an async form of playwright but from some googling it does not seem like a good idea to use.

@brinkdp, thanks for the review!

Maybe it's worth adding a comment to the doc about running playwright install when installing it for the first time?

Thanks for spotting this, I've added that now to the document, commit XXXX

The tests themselves look very useful and having a GH action sounds like a good idea. Would it be run for each commit, or at a later stage (say, at PR merge or deployment)?

I think on every commit might be overkill - especially if someone wants to commit WIP. So I think on a PR (to merge into main) would be lagom. If you have a preference here feel free to say though.

Good that the automation spotted the missing L. trigynum heading. I had forgotten about that! I had deliberately removed it since there were no other references than the genome reference, which was already stated under another heading (listing the same reference twice in a row just looked silly). I plan to fix this in another branch when we implement the new version for how to cite a species entry and its data.

Glad to hear. If there are other things you think would be nice to test for or if there are some things that we're testing for that are actually too strict (e.g. maybe it is okay to not have this heading, and a warning might be better) then happy to work together on some changes.

I think on every commit might be overkill - especially if someone wants to commit WIP. So I think on a PR (to merge into main) would be lagom. If you have a preference here feel free to say though.

Like the saying goes: "Lagom är bäst". I am fond of WIP commits and our current use of placeholders, so this sounds good to me!

Glad to hear. If there are other things you think would be nice to test for or if there are some things that we're testing for that are actually too strict (e.g. maybe it is okay to not have this heading, and a warning might be better) then happy to work together on some changes.

Cool, I think it would be a fun exercise to brainstorm together on potential new test cases. Having warnings instead of fails sounds interesting too.
One idea I've had in the back of my head for a while is to write a test that checks that all occurrences of the scientific species name on a page are italicized. I always try to do an extra manual check on this, but it nevertheless slips by now and then.
A common cause of this is copying texts from researchers from a mail or .docx and forgetting to adjust the syntax for the markdown files. Angela has suggested automating this step with pandoc (which I think is a good idea), but a playwright test could be useful too, if it's not too much work to implement.
In my mind, catching this with pattern matching should hopefully be fairly straight forward since we already declare the scientific name in the science_name variable in each species' _index.md. We would need to include both the full and abbreviated form: Tiny herb and T. herb, and the different syntax options for italics in markdown: *single asterisk*, and _underscore_. Do you think this is feasible?

@kwentine, Thanks again for suggestions and ideas. I've made the changes we talked about so it's ready for a 2nd review when you have time.
@brinkdp,

Cool, I think it would be a fun exercise to brainstorm together on potential new test cases. Having warnings instead of fails sounds interesting too.

Definitely up for that!

One idea I've had in the back of my head for a while is to write a test that checks that all occurrences of the scientific species name on a page are italicized. I always try to do an extra manual check on this, but it nevertheless slips by now and then.
A common cause of this is copying texts from researchers from a mail or .docx and forgetting to adjust the syntax for the markdown files. Angela has suggested automating this step with pandoc (which I think is a good idea), but a playwright test could be useful too, if it's not too much work to implement.
In my mind, catching this with pattern matching should hopefully be fairly straight forward since we already declare the scientific name in the science_name variable in each species' _index.md. We would need to include both the full and abbreviated form: Tiny herb and T. herb, and the different syntax options for italics in markdown: single asterisk, and underscore. Do you think this is feasible?

Thanks for the idea, I think this should be feasible, in the case of Playwright we would be checking the species names in the markdown texts has an <em> tag as these tests run on the built website not on the markdown files themselves. I will look into it and get back to you :)

@brinkdp italics checked now added :) I ended up using the markdown files to perform the checks and not the website (i.e. didn't use playwright but just pytest).
@kwentine, I've updated the tests to reflect the latest changes on main. This is now ready for a review/merge I think.

Thanks @kwentine, merging now :) I'll soon start work on a making a PR to create a GH actions test for this one too :)


0.17.0

Upgrade to jupyterlab 0.17.0 (thanks @blink1073 for https://github.com/jupyterlab/jupyterlab_json/pull/19)
Support expanded metadata
Adopt new mimerender-cookiecutter workflow

@gnestor, I'm starting to think it makes sense to bump the version of JupyterLab in master before the release, because once we change APIs, the version is no longer correct in semver.  Thoughts?

@jasongrout, you've wrestled with this in ipywidgets, what are your thoughts on using the npm prerelease tags (premajor, preminor, prepatch) in master?

As an example, we decided to make the prelease versions of jupyter-js-widgets as patch releases on 2.0.x, and publish to npm with --tag next. That way a program could easily specify the latest prerelease (e.g., 2.0.*). The final 2.0 release would either be something like 2.0.40  (similar to Typescript), or in our case, we decided to just bump to 2.1.0. I'm not sure which is better from those.
See also<EMAIL_ADDRESS>

This did break semver of course (every patch release on 2.0.x was probably breaking), but since we published with --tag next, we thought the convention would be understandable.

We're about to switch to multi-packages anyway, where the python package version is not tied to the individual packages, but I do like using @next for prerelease.  Ick about the @latest installing alpha tags though, wow.

Aside from the next vs latest tags, I think the difference between our approach and the prerelease approach is that having the prereleases as normal patch versions allowed you to do 2.0.* and get upgraded to the most recent prerelease, whereas (IIRC) true alpha releases are considered incompatible with each other. That's probably more technically correct, but inconvenient when doing development and releasing lots of alpha releases.

I'd argue that that approach is just moving the problem elsewhere, while being technically incorrect.

I'd say that it's more a symptom of more serious problems elsewhere, namely our conflation of jupyter-js-widgets version number and the version number of the protocol. Basically, we still have a pretty tightly coupled backend and frontend, and doing this helped us work around that for now.
Fixing this and cleanly separating the backend and frontend is one of my goals for widgets 7.0.

There's a reason the Air Force has people whose full time job is configuration managment.  ;)

Given the severity of consequences from Air Force errors, I'm glad!

@gnestor, I'm starting to think it makes sense to bump the version of JupyterLab in master before the release, because once we change APIs, the version is no longer correct in semver. Thoughts?

My initial thought is if you were to checkout this branch and try to build it, it would fail with Could not find a version that satisfies the requirement jupyterlab>=0.17.0 (the workaround is to change the jupyterlab version to 0.16.2). Would what you're proposing fix that?

If we make master 0.17.0, then this PR would work until we make another breaking change.  If we made the policy of bumping a suffix in master whenever there was a suffix change, then master of this repo could track the most recent prerelease.  There's no real great solution for tracking master, but hopefully we can find a workable one.

Sounds like an improvement 👍

Given the subtleties of the @next tag, I think bumping the version in master to -alpha.x but not releasing might be the best approach.


Split and replace in wren.

Rewrote https://github.com/munificent/wren/pull/409 in wren.

Did you do a performance comparison between your C and Wren implementations? Would be interesting I think.

replace.wren
var start = System.clock

for (i in 0...1000000) {
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit.".replace(" ", "-")
}

System.print(System.clock - start)

split.wren
var start = System.clock

for (i in 0...1000000) {
    "Lorem ipsum dolor sit amet, consectetur adipiscing elit.".split(" ")
}

System.print(System.clock - start)

I ran both 5 times for both the c version and the wren version and took the best case.
The c version took 3.323829 seconds for replace and 2.357955 seconds for split.
The wren version took 6.305593 seconds for replace and took 4.425018 seconds for split.

Awesome! Nicely done. :)


Update to using image: registry.gitlab.com/matrixai/engineering/maintenance/gitlab-runner

wr are now using the new image that has expanded support for CI/CD

Fixed with 05332509e2664fe28fb11779b58403e9d92bdbe2


Add the snippet indicator for items with Snippet kind

Completion results returned by https://github.com/dcampos/cmp-snippy are like this - that source defines an execute function which calls nvim-snippy directly, instead of letting nvim-cmp handle snippet expansion.

Looks good. Let's merge for the time being.


One terminal signal for SubscriberBase users

from the code:
//    once the user cancels the subscriber via the subscription::cancel, it is
//    guaranteed that no more callbacks will be called on the subscriber. It is safe for the client
//    to do cleanup and releasing of resources. User doesn't have to call
//    subscription::cancel in on{Complete,Error} methods.
I left most of the documentation in the code.

We talked about this a bit offline. I'm happy for this to go in as-is (although I think it'd benefit from review from, e.g., @yschimke), as long as we follow it up with some refactoring that aims to do something like this:

Instead of reaching for a private atomic flag of SubscriberBase, move cancellation functionality into a new kind of CancellationToken class, which can be shared between the subscriber and subscription.
Create a new class of Subscription which wraps any other Subscription with this kind of atomic cancellation behavior shown here, so we build that through composition instead of inheritance.
Instead of inheriting the functionality of ExecutorBase, turn it into a new kind of folly::Executor, which wraps another Executor with queuing behaviors. The SubscriberBase can create this QueuedExecutor internally (so users don't have to), then pass it to the new subscription class.


Webpack 4 prep: Lazy Load CodeMirrors

This should fix up the chunking issue we’d been having with Codemirror stuff; there was an entry point which wasn’t lazy-loaded, which means none of them got to be!
Pulled out of #511.

Technically this leaves us with two copies of CodeMirror, this will be fixed by Webpack 4.

Sorry, such an epic late reply to this! Does this mean there's 2 copies of CodeMirror in the CodeMirror bundle? Or 1 copy in the CodeMirror bundle, and another copy in the app one?

One copy each in two lazy loaded chunks, depending on which codemirror component you end up using


Non-public config system

requirement for #89 : approach to have non-public configs (for secrets)
do it the same way as openeo-deploy?

getting secrets from env vars might  be an easier compromise solution

basically resolved through  #112


Error when installing!

Hi, When I try to install via docker on windows i get this error:
Command: /etc/ansible/env/dev # cd /etc/ansible/env/lab
Error: /bin/sh: cd: can't cd to /etc/ansible/env/lab: No such file or directory

The same happened to me. I cannot make it run


Acronym: disable all tests but not the first one

Disable all tests except the first one to help users to implement the solution bit by bit.

Thanks @rchavarria !  (for fixing what must have been my mistake 😳)

Don't blame yourself. It could be just a small distraction. That's why it's better to have several people do the programming :wink:

You're too kind.


Dynamic Height

Is it possible to has the editor with Dynamic Height?
If is, can you give an example how to do it.
Thanks

This custom element is just a wrapper for Ace Editor, so it will not offer more featuers than Ace has.
AFAIK, in Ace Editor you can achieve this functionality with custom config and some scripting: https://ace.c9.io/demo/autoresize.html
juicy-ace-editor exposes Ace Editor instance as editor property (see https://github.com/Juicy/juicy-ace-editor).
Have you tried to hook this up together?

Fixed in https://github.com/Juicy/juicy-ace-editor/pull/43


Limited power of currently working text prompt driven segmentation

Instructions To Reproduce the 🐛 Bug:

Background explanation

I have images of objects with some thin extursions (antennas). When I try to specify in the text prompt to obtain object with antennas attached to it, mostly prunes out the antennas. It is a sequence of images for the same object for which I need to subtract the background. Also, when it does get the antennas in very few images, the segmentation boundary is a bit imprecise and thin sliver of background is visible around antenna or parts of object where there are not as thin but somewhat thin extrusions. With some cavities that are naturally part of the object, bits of background visible through cavity leak in a bit.
I am going to attempt some post procesing clean up through contour detection if that works out to get a more crisp and better segmentation. Meanwhile is there a way to not have it cut out thin extrusions in the first place?

Workaround perhaps be as follows: Cut out part of the image and then use the text prompt to select the object of interest within that cutout and then merge it back to combine with the object where background is removed. Since we know where we made the cutting, we know where the position the component of interest is relative to the rest of the image. If we use this when combining all the segmentations together, may yield getting those extrusions also. I will try that and see how that performs.


feat(client): nullable relation where

I'm opening this draft PR in hopes of improving nullable relation types.
Currently, querying for where a relation exists doesn't return the correct TS type and the field is still nullable.
e.g.
/**
 * Imagine we have a job board app and users can assign themselves to a job.
 * We want to write a query to get all users with an active job.
 *
 * If we are querying where `activeJob` exists, it should not be nullable in the resulting type.
 */
const usersWithJob = await prisma.user.findMany({
  include: { activeJob: true },
  where: {
    activeJob: {},
  },
})

console.log(usersWithJob[0].activeJob.description)
//                          ^ but `activeJob` is still `Job | null`

This PR is a very hacky POC and isn't intended to be a proper implementation (I don't know how to write TS that well haha...) but hopefully it helps illustrate my problem and provides some general guidance.
I've included a repro project that demonstrates a basic example. It doesn't handle AND or OR statements and since I'm not too familiar with the Prisma repo, I'm sure there are other things I've missed as well.
Let me know if you need any more info or if there's anything else I can do to help. Would love to help get this merged in eventually in any way I can!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I've updated the PR to use a better type that accounts for nested AND and OR queries.
The Extract is necessary since AND and OR may resolve element types that don't include P as a property.
e.g. below should still resolve in child being non-nullable.
{
  where: {
    AND: [
      {
        child: {}
      },
      {
        someOtherProperty: true
      },
    ]
  }
}

It looks a bit hectic at the moment since the "where" type needs to passed into the nested _GetPayload to support nested relation queries e.g. result.child.nestedChild should also be non-nullable.
{
  where: {
    child: {
      nestedChild: {}
  }
}

, but I'm not sure how else it could be done.
Here's is an example diff of the generated output:
  export type UserGetPayload<S extends boolean | null | undefined | Pick< | UserFindManyArgs, "include" | "select" | "where">> =
    S extends { select: any, include: any } ? 'Please either choose `select` or `include`' :
    S extends true ? User :
    S extends undefined ? never :
    S extends { include: any } & (UserArgs | UserFindManyArgs)
    ? User  & {
    [P in TruthyKeys<S['include']>]:
-       P extends 'activeJob' ? JobGetPayload<S['include'][P]> | null :
-       P extends '_count' ? UserCountOutputTypeGetPayload<S['include'][P]> :  never
+       P extends 'activeJob' ? JobGetPayload<S['include'][P] & { where: Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> }> | (Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> extends never ? null : never) :
+       P extends '_count' ? UserCountOutputTypeGetPayload<S['include'][P] & { where: Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> }> :  never
  }
    : S extends { select: any } & (UserArgs | UserFindManyArgs)
      ? {
    [P in TruthyKeys<S['select']>]:
-       P extends 'activeJob' ? JobGetPayload<S['select'][P]> | null :
-       P extends '_count' ? UserCountOutputTypeGetPayload<S['select'][P]> :  P extends keyof User ? User[P] : never
+       P extends 'activeJob' ? JobGetPayload<S['select'][P] & { where: Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> }> | (Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> extends never ? null : never) :
+       P extends '_count' ? UserCountOutputTypeGetPayload<S['select'][P] & { where: Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> }> :  P extends keyof User ? User[P] : never
  }
      : User

The type can be read as:
// If `where[P]`, `where.AND[number][P]` and `where.OR[number][P]` all don't satisfy `{}`, then the user isn't querying for `P` so return `null`
type _ = Extract<S['where'][P] | (S['where']['AND'] & S['where']['OR'])[number][P], {}> extends never ? null : never

While this change has been working fine on my local machine as a patch, I still think it can be improved further, but I'm not sure how to do it myself.
Keen to get feedback.


Add external macro to file in hi/.

It's less than clear how I do PTAL.

When you've made the changes, unassign yourself and assign only to me.