Yahoo Finance websites do not load graphs

Energized Protection - block ⚡

Let's make an annoyance free, better open internet, altogether!

Issue Submit Form

  Provide the following info properly, which will help us to resolve your issue quickly.

Issue(s):
Type x in between [ ] and make sure there isn't any space between brackets. Example; for Your Selected Issue(s), type like this - [x]
You can select more than one category of issues if you need to!

[x] Whitelist
[ ] Blacklist
[ ] App Broken
[x] Website Broken
[ ] Request
[ ] Other Issue

Pack(s):
Write the name of the pack(s) you are using.

Pack(s) Name: Blu

Extension(s):
Also name the extension(s) if you are using any. If you don't then leave it blank.

Extension(s) Name:

Domain(s):
If you are submitting this issue for whitelist/blacklist issue, send us the domain(s) for whitelisting/blacklisting here. Kindly use the Code Tag to prevent tracking.

Domain(s):

Your Config:
Just to ensure there is no issues or conflicts with other app/software/magisk module/extension/source list.
Make sure you are running Energized Protection Service only.

Client:  AdAway (root/host mode)

Version: 5.11.0

Detail:
Write us a lil bit more about your issue or query. You can attach any screen shot or log of the issue or advert, this will help to highlight it.

Your Issue Detail:
When using the "Blu" pack, Yahho Finance websites do not load stock graphs.
I have these two links as example

https://finance.yahoo.com/quote/VMW/

https://it.search.yahoo.com/search?fr=uh3_finance_vert&fr2=p%3Afinvsrp%2Cm%3Asb&p=vmw

If I add to whitelis the following, they do load:

query1.finance.yahoo.com
query2.finance.yahoo.com

Might be related to #854 but that issue was poorly written.

Thank you for making Energized Protection great, with your kind help!
A project by Ador with ❤

Closing this issue since the project has been abandoned.


importerror since 1.0.0

We recently introduced type_enforced in one of our packages where many others depend on. In the testbanks get importerrors since the release of type_enforced 1.0.0.
C:\Miniconda3\envs\hydromt-delft3dfm\lib\site-packages\meshkernel\meshkernel.py:18: in <module>
    import type_enforced
C:\Miniconda3\envs\hydromt-delft3dfm\lib\site-packages\type_enforced\__init__.py:3: in <module>
    from .enforcer import Enforcer, FunctionMethodEnforcer
C:\Miniconda3\envs\hydromt-delft3dfm\lib\site-packages\type_enforced\enforcer.py:1: in <module>
    from types import FunctionType, MethodType, GenericAlias, UnionType
E   ImportError: cannot import name 'UnionType' from 'types' (C:\Miniconda3\envs\hydromt-delft3dfm\lib\types.py)

This happens in several python versions, but at least py 3.9
Would it be possible to fix this, and include online testing on github?

Thanks for the feedback.

For an immediate fix, can you lock to 0.0.16
Let me see if I can reproduce this. Then I can add a fix and add some
future tests to prevent this from happening in the future.

Connor
On Thu, Nov 16, 2023 at 10:57 AM veenstrajelmer @.***>
wrote:

We recently introduced type_enforced in one of our packages where many
others depend on. In the testbanks get importerrors since the release of type_enforced
1.0.0.
C:\Miniconda3\envs\hydromt-delft3dfm\lib\site-packages\meshkernel\meshkernel.py:18: in
import type_enforced
C:\Miniconda3\envs\hydromt-delft3dfm\lib\site-packages\type_enforced_init_.py:3: in
from .enforcer import Enforcer, FunctionMethodEnforcer
C:\Miniconda3\envs\hydromt-delft3dfm\lib\site-packages\type_enforced\enforcer.py:1: in
from types import FunctionType, MethodType, GenericAlias, UnionType
E   ImportError: cannot import name 'UnionType' from 'types' (C:\Miniconda3\envs\hydromt-delft3dfm\lib\types.py)
This happens in several python versions, but at least py 3.9
—
Reply to this email directly, view it on GitHub
https://github.com/connor-makowski/type_enforced/issues/24, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3ICWZVVGOB7DRKQN2PL53YEXPRRAVCNFSM6AAAAAA7N3V2PSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TMNBYGUZTKMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Can you confirm that this is resolved for you? Feel free to close the issue if it is.

It seems to be resolved indeed, the imports work again. Thanks for the quick action.


Automatic import / require statements for modules

A lot of editors support automatically importing matching modules when you use an undefined variable matching the name of a module. I feel like this would be an excellent addition.
I'd be personally happy with whatever the minimum viable first version of this is.

Automatically finding any matching file is of course awesome, but even automatically filling out imports from a set list is a great start.
I'd personally only be able to make use of this if it could require by relative path.
I know lua-language-server has plugins -- maybe Roblox LSP could support a Lua plugin that finds and generates requires for undefined variables? Seems like a great way to make it customizable and get a minimum viable version out that isn't very limited.

I'd be interested in investigating implementing this myself, but I'm not sure where to start. Last time I tried to modify and build lua-language-server I couldn't get it to build. Any tips to get started?

Implementing this as a plugin is possible, but is very hacky since they are meant to add custom syntax, although if you have any idea of how this feature would work I would like to know since I myself don't understand very well how it would work.

I'd be interested in investigating implementing this myself, but I'm not sure where to start. Last time I tried to modify and build lua-language-server I couldn't get it to build. Any tips to get started?

This repository bundles the language server so you don't need to build it. Just clone this repository and run npm install in the client folder, then you can test it by placing it on %USERPROFILE%\.vscode\extensions or using https://github.com/sumneko/vscode-lua/blob/master/.vscode/launch.json and running "Launch Client".

Implementing this as a plugin is possible, but is very hacky since they are meant to add custom syntax, although if you have any idea of how this feature would work I would like to know since I myself don't understand very well how it would work.

When I say "as a plugin" I mean supporting a new plugin function so the end user can define their own automatic import suggestions.
If this were to work like a lot of editors with automatic importing, it would be a "quick fix" suggestion. If a plugin function for generating imports was supported, something like the following could be called if a user chooses "quick fix -> generate import"
function OnGenerateImport(uri, text, undefinedVariableName)
    -- Assume hasSiblingWithName is implemented elsewhere in this file
    if hasSiblingWithName(uri, undefinedVariableName) then
        return string.format("local %s = require(script.Parent[%q])", undefinedVariableName, undefinedVariableName)
    end
end

I don't think this is necessarily the best way to go about this! It's just a suggestion because it might be less work (and more flexible) to get an mvp out if finding and generating require paths is deferred to the user.

Good to know that I don't need to build it to try out new things! I may take a look sometime soon and see if I can add auto-import suggestions at some point. Thanks for the tip!


Right Click Menu: Fix the click problems

Context
Bug Bash for 1.11 uncovered some click problems with the menu. This fixes those.
Summary

Clicking anywhere in the menu that's not an enabled button will keep the same element selected in the canvas.
Mouse down on the mask will not de-select the selected element.

Relevant Technical Choices
n/a
To-do
n/a
User-facing changes

Before
After

Testing Instructions

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Right click any element other than the background
Click on a disabled item. Nothing should happen
Hold the mouse down away from the menu -> should close the menu

Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
no
Does this PR have a legal-related impact?
no
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #8884

(Looks like some of the unit tests need updating to use onMouseDown)


Minor tweaks to README

Minor tweaks to README. I would be good to define pledge in future edits since it's not well-known (at least to me 😉).
I'd also love to include some example configs we can author for CI systems based on risk scores but need to understand the scoring better first.

Closing as obsolete.


Error on reconciliation of odh-model-controller

Below issue is coming on reconciliation of odh-model-controller.
2023-09-20T00:50:14Z	ERROR	Reconciler error	{"controller": "inferenceservice", "controllerGroup": "serving.kserve.io", "controllerKind": "InferenceService", "InferenceService": {"name":"caikit-example-isvc","namespace":"kserve-demo"}, "namespace": "kserve-demo", "name": "caikit-example-isvc", "reconcileID": "f399dd1f-1ee1-45c2-badc-c37507bc51fe", "error": "servicemonitors.monitoring.coreos.com \"caikit-example-isvc-metrics\" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:329
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:274
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/opt/app-root/src/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.6/pkg/internal/controller/controller.go:235

Currently this error is not visible in logs because error object is not send back. We capture the error and then just ignore it. In below line we are capturing err but never return it to calling function.
https://github.com/opendatahub-io/odh-model-controller/blob/main/controllers/inferenceservice_controller.go#L99

depends on changes of https://github.com/opendatahub-io/odh-model-controller/pull/84

@vaibhavjainwiz how can I try to reproduce the issue?

These error will not be visible in logs but you could see the impacts it on ServiceMeshMemberRole.
If you delete the Namespace from ServiceMeshMemberRole in running application then ideally it would add back by operator but beacause of this error it would not added back.

These error will not be visible in logs but you could see the impacts it on ServiceMeshMemberRole. If you delete the Namespace from ServiceMeshMemberRole in running application then ideally it would add back by operator but beacause of this error it would not added back.

I tried, and don't see any error in odh-model-controller pod.
However, the ServiceMeshMemberRoll doesn't get reconcilied automatically.

I updated the label to rhods-2.5, because the fix is missing on 2.4.
Once there is a build for 2.5 I'll re-check and close if I the fix is correctly in place.

I updated the label to rhods-2.5, because the fix is missing on 2.4. Once there is a build for 2.5 I'll re-check and close if I the fix is correctly in place.

sounds good, thank you!

The issue seems to be gone in 2.5-RC
Closing.


Lock all or none and don't wait in ProcessBlocks

https://stratisplatformuk.visualstudio.com/StratisBitcoinFullNode/_workitems/edit/4444/
https://stratisplatformuk.visualstudio.com/StratisBitcoinFullNode/_workitems/edit/4418/

Can be merged if passes CI


navbar_alert: Fix weird closing of profile-missing-required alert.

This is a follow-up PR for #28924 to fix the weird closing behavior of the navbar alert, which shows the presence of empty required profile fields.
It fixes the following bugs:

The "profile-missing-required" alert doesn't close on clicking the close button.
The alert doesn't get closed when all the required profile fields are filled.

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

This makes sense, merged, thanks @Vector73!
I wonder if this module's logic could be restructured a bit better to make it more robust.


Fixes #358 MockGeneratorPlugin errors if the response headers have a duplicate

If a response is recorded and contains the same header key value pair more than once, then an exception is thrown.
This change removes it by only allowing distinct values of the keys.
While I was working with the mock responses file, I noticed you could not comment them out, so a small tweak to allow that too.
This can be tested by hitting the https://graph.microsoft.com/v1.0/users endpoint, and paginating through the list of users you find e.g.
       var graphServiceClient= new GraphServiceClient(requestAdapter);

            // send a get users request to the graph api; note that the results are paged
            var allUsers = new List<User>();
            var usersPage = await graphServiceClient.Users.Request().Filter("accountEnabled eq true").GetAsync();
            do
            {
                allUsers.AddRange(usersPage);
            }
            while (usersPage.NextPageRequest != null && (usersPage = await usersPage.NextPageRequest.GetAsync()).Any());

@microsoft-github-policy-service agree

Thanks for the PR @mosoftwareenterprises! I'm curious what are the headers that are present twice?

Thanks for the PR @mosoftwareenterprises! I'm curious what are the headers that are present twice?

I have just spent the last 20mins trying to replicate the issue, and could only do so via browsing in google,
It is the Set-Cookie header specifically in this case.

Some scenarios will need multiple headers (on Graph, for instance with Prefer). I'm wondering if our data structure here is the right one. @waldekmastykarz or @gavinbarron would you mind chiming in?

oof. yeah, multiple headers with the same name are allowed, and is some cases required. Using a dictionary here is not really the right data structure.
We should probably be using something like List<KeyValuePair<string, string>> instead.
Or Dictionary<string,string[]> would also work but require more work to populate.

Good point @gavinbarron. We should definitely change how we store headers to List<KeyValuePair<string, string>>. @mosoftwareenterprises, would you be willing to update your PR?

Yes @waldekmastykarz  I will attempt an update to the PR.
Question though, as the changes are going to be further reaching than before, how do I regression test? I dont see any automated tests in the repo?

Yes @waldekmastykarz I will attempt an update to the PR.
Question though, as the changes are going to be further reaching than before, how do I regression test? I dont see any automated tests in the repo?

At this stage we'll have to test it manually. Sorry we don't have a better answer at this moment

Hey @waldekmastykarz . Sorry I have been so busy, I have not had time to finish it. I will commit the latest changes here, but I have not checked it through yet.

Hey @mosoftwareenterprises, are you still working on this?

Hey @waldekmastykarz, I will be picking this up again this week. So hopefully I will have something for you soon.

Awesome! Looking forward to it! We've done some changes in the meantime, so please don't forget to pull the latest changes to avoid conflicts 😊

@waldekmastykarz I assume you are referring to the change to correct the CONTRIBUTING.md file which is incorrect, and the changes to add the serializer options in to ignore comments etc.
I have removed them both.
Let me know if you meant something else.

Thanks @mosoftwareenterprises! We'll do some further adjustments to streamline it across all plugins. We appreciate your help ❤


fix: rename superblock to use /2022/

I was going to just let us use the superBlock property (rather than the directory), but once I'd done that, I figured I might as well rename the slug while I'm at it.
As for the directory name: 14-responsive-web-design-22, we don't need the 22 any more.  I didn't rename that here, but it's just a organisational convenience now, so it can be whatever we like.
I've not done anything about the blocks, just superblocks.  But I think this is a step in the right direction.

So what happens in 2023?

So what happens in 2023?

That we can decide tomorrow :)  If you all want to get this in without the rename, that's totally cool.  Just revert 8d4450df19c20d520c7ac7a6ff153bb5f8899c10 and it should be fine.


Fix CharacterBody2D get_slide_collision docs

The indentation was off and the code usage was incorrect for Godot 4.0 GDScript.

Thanks! And congrats on the first merged PR!


chore(downloaders): add traces when not pushing new requests

cc @shekhirin
This adds some traces in the downloader which may help debug stalls in the bodies stage

converted to draft, using for debugging rn, we may not need to merge this as-is

the issue was due to freelist, not the downloader


Fix warnings during build time

This should fix setuptools warnings related to sleepecg.classifiers and sleepecg.test, which might not get added automatically to the package. Therefore, I've added the former manually and promoted the latter to a package.
In addition, I've reformatted setup.cfg to be as similar as possible to what it looks like when setuptools reformats it when building the source distribution.
Fixes #143.

So we cannot make sleepecg.test a package, because this causes all tests to fail. Maybe this directory (as well as sleepecg.classifiers) shouldn't be a package after all? Please help, I have no idea what I'm doing 😆!

@hofaflo do you know why making classifiers and test packages breaks the tests on cibuildwheel? Locally, all tests still pass with these changes...

OK, got it, using find_namespace: instead of find: in setup.cfg solves this issue.
However, I still wonder about the error we got with pytest when these folders are true packages.

Sure, initializing with zero is fine!
Really weird stuff, why did you choose to make these two folders not proper packages in the first place? At least the test folder is very often a package with __init__.py from what I've seen in other projects.

I dimly remember running into this exact issue with cibuildwheel/pytest and removing the __init__.py because of it :sweat_smile:
For classifiers, I didn't think about making it a package because it doesn't contain any .py-files.

It's just the tests in test_heartbeat_detection.py that fail when we add an __init__.py:
  _____________________ test_squared_moving_integration_args _____________________

      def test_squared_moving_integration_args():
          """Test squared moving window integration argument parsing."""
  >       from sleepecg._heartbeat_detection import _squared_moving_integration
  E       ModuleNotFoundError: No module named 'sleepecg._heartbeat_detection'

  /project/sleepecg/test/test_heartbeat_detection.py:83: ModuleNotFoundError

All errors are related to ModuleNotFoundError: No module named 'sleepecg._heartbeat_detection' - why could that be happening? This file is a .pyi file, not sure if it has to do with that? It would be great if we could resolve this issue, because I have the feeling that it will hit us again in the future otherwise 😄.


Fix Elixir lib path detection when using version managers

This change fixes & simplifies calculating Elixir lib path using the path to Mix's beam file as a reference point. Works with both normal pkg install and also version managers.
Most version managers use shims, which makes the ReleaseManager.Utils.get_real_path/1 point to ~/.asdf/shims/elixir. This results in the elixir lib path being assumed as ~/.asdf/shims/elixir/lib, which is non-existent, which is written to relx.config. And exrm/relx errors out when making a release while searching for iex in that path.
Tested this change with Erlang 18.0 & Elixir 1.0.5 on:

asdf version manager on OS X El Capitan
Erlang Solutions Elixir package on Ubuntu 14.04 on Vagrant (screenshot attached)

Thanks to @tsloughter for helping out.
@bitwalker please let me know if you need any info or if there's anything to be changed.
[Ref: twitter conversation]

Looks good, thanks!


refactor(app): replace ButterKnife with View Binding

This should replace the deprecated ButterKnife library with View Binding in our sample app.

🙏  thank you so much for this @rosariopfernandes!  Goodbye ButterKnife 👋


[xxx] Default show_funding to true

Context
The show_funding feature is on now in production.
Changes proposed in this pull request
Set it to default on in the base settings.yml to ensure it is enabled in all environments.
Guidance to review
This is a bit difficult to test. Check that there aren't any rogue overrides to the default settings.yml. After deployment ensure that the funding section is visible on each env.

@avinhurry I had to do a bit of finessing of the specs. Could you give this another look please? The main thing was adding with_funding to the completed trait in the trainee factory. I've removed a few of the 'when the feature is on/off' contexts as it's just on now. We can remove the feature flag in another PR.

@avinhurry I had to do a bit of finessing of the specs. Could you give this another look please? The main thing was adding with_funding to the completed trait in the trainee factory. I've removed a few of the 'when the feature is on/off' contexts as it's just on now. We can remove the feature flag in another PR.

Looks good to me @gpeng
https://trello.com/c/72D7nQA7/2068-remove-showfunding-feature-flag


Narrow down the amount of packages installed for Wine in MinGW CI runs.

Before:
# x86
12 upgraded, 265 newly installed, 0 to remove and 40 not upgraded.
Need to get 354 MB of archives.
After this operation, 1626 MB of additional disk space will be used.

# x86-64
12 upgraded, 296 newly installed, 0 to remove and 40 not upgraded.
Need to get 545 MB of archives.
After this operation, 2703 MB of additional disk space will be used.

After:
# x86
2 upgraded, 167 newly installed, 0 to remove and 28 not upgraded.
Need to get 254 MB of archives.
After this operation, 1239 MB of additional disk space will be used.

#x86-64
0 upgraded, 48 newly installed, 0 to remove and 30 not upgraded.
Need to get 318 MB of archives.
After this operation, 1710 MB of additional disk space will be used.

This should shave off some of the time spent installing packages, but the variation between runs is too great to see how much. This CI has so far both of the fastest wine install runs I have seen. (Faster by 12sec, 1min, 10min, etc.)

As long as the versions for 32-bit packages and 64-bit packages are forced to be same, I don't see any reason why we can't change what other packages get installed... CI runs should fail quite fast if something needed is changed or removed.


Sort labels and annotations.

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Sort labels and annotations.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/cc @mimowo

/lgtm
/approve

/cherry-pick website

@mbobrovskyi should we be cherry-picking this PR to website? If so, then prepare it manually

I think no. This is new feature.


Revert "Update Envoy image to v<IP_ADDRESS>-prod"

This reverts commit f0184a0233f53bf76b55112889dbb13565ad4bfc.
Issue #, if available: https://github.com/aws/aws-app-mesh-roadmap/issues/144
Description of changes:
Need to roll back Envoy image due to a reported crash in v<IP_ADDRESS>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This was done in https://github.com/aws/aws-app-mesh-inject/pull/113

OK. closing.  I lost track of what was already created :(


Rails 6 upgrade

Initial merge of the DMPRoadmap Rails v6 code looks good.
Recording any issues discovered while testing below
Issues:

[x] Missing TinyMCE stylesheets
[x] Webpacker complains of a duplicate plugin (we were explicitly loading one that is now preloaded by another plugin)
[ ] PDF download ignores Font specifications
[ ]

AWS doesn't have a standard ruby 2.7 rpm. So we upgraded to Ruby 3.0.
This introduced some issues with keyword arguments https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
Needed to patch the uc3-ssm gem and calls to deep_copy
We also need to update node >= 14


Duplicate scopes in JWT claims

I have created an ApiResource with a several Scopes:
                new ApiResource                 {                     Name = "TestName",                     DisplayName = "Allow application to access your account",                     ApiSecrets = new List<Secret>{new Secret("scopeSecret".Sha256())},                     Scopes = new List<Scope>                     {                         new Scope(Constants.Scope, "Allow application to access your account"){Required = true },                         new Scope("ScopeA", "Allow application to make A"),                         new Scope("ScopeB", "Allow application to make B")                     }                 }
Now when a JWT is generated for a client that is allowed to request those two scopes, they are included twice in token claims
{   "nbf":<PHONE_NUMBER>,   "exp":<PHONE_NUMBER>,   "iss": "MyIdentityServer",   "aud": [     "MyIdentityServer/resources",     "customAPI",     "TestName"   ],   "client_id": "TestWebApp",   "sub": "375433",   "auth_time":<PHONE_NUMBER>,   "idp": "local",   "acr": "3ohqhanw43vr3f25f5xek0s1",   "culture_name": "el-GR",   "jti": "398f0a6b7e0f60551f39cba8324a36eb",   "scope": [     "customAPI.read",     "customAPI.write",     "customAPI.read",     "customAPI.write",     "ScopeA",     "ScopeB",     "ScopeA",     "ScopeB"   ],   "amr": [     "pwd"   ] }

Issue solved with this

Thanks! You saved me some time there.


Anything happened in China? The spike in reported deaths seems off

That sudden spike in death looks strange and unnatural and the curve looks odd getting to the new numbers. Is the data source still valid or got it corrupted?

They revised the death toll for Wuhan / Hubei by ~1300 deaths last week. This has been widely reported. see e.g. https://www.reuters.com/article/us-health-coronavirus-china-toll-idUSKBN21Z052

i read about it. but would have expected they would have changed the daily recordings of previous days and sorted it to the according days instead of counting it to the present day (22.4.). ;) ok that way it makes sense again. thanks for clarification :)


Web - JS Console error appears when clicking user name

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Start a chat with a user.
Click on your avatar in the chat and verify that no Message  button is visible.
Now click on another user's avatar and verify that the Message  button is visible and clicking it opens the chat with that user.
Check the JS console

Expected Result:
Verify that no errors appear in the JS console
Actual Result:
Errors appeared in the JS console
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web

Version Number: v1.1.30-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @puneetlath (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

Oh hmmm I reproduced and added the Demolition label but on second thought, I think it's possible that external contributor can fix this. @puneetlath Do you want to take a stab at this or should I label External? The error message says
Please instead use `remove()` on the subscription returned by `EventEmitter.addListener`.

But I honestly don't know if it's that easy

Proposal
This error is shown because we are using an outdated version of react-native-modal.
Related issue: The issue has been solved in version 13.0.0 of the dependency.
So merely upgrading this dependency to 13.0.0 resolves the issue.

@cead22 let's go external.

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

Upwork job: https://www.upwork.com/jobs/~014d0c018e3c86ed2f

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

🎀👀🎀 C+ reviewed
Coming from #6914

We should follow-up with an issue to upgrade react-native-modal because it's throwing errors due to the deprecated removeEventListener function. This has been fixed in their latest version.

I like @sig5's proposal. After reading the changelog, I don't think it'll break anything and should fix this issue.
cc: @puneetlath

Agreed, seems like a straightforward solution.

📣 @sig5 You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖

@sig5 how is this going?

Hi Puneet, this has been merged here to staging. I can't reproduce the issue on staging. So I think it works as expected.
https://github.com/Expensify/App/pull/7333#issuecomment-1021584734

Lol whoops. Totally missed that. In spite of me being the one who merged the PR 🤦🏾. Thanks!

Issue not reproducible during KI retests. (First week)

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.33-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7333

If no regressions arise, payment will be issued on 2022-02-08. :confetti_ball:

Issue not reproducible during KI retests. (Second week)

Paid!


ACR values not resolved for SAML2 clients

When collecting data for login events ACR value is resolved only for OIDC clients.

Fixed in 1.1.0


Support ConfigurationData hash as a parameter

Similar to #5 and #6, without being able to parameterize the tests, it can be difficult to share or reuse OVF test suites.
Since we've got the concept of a ConfigurationData hash in DSC, why not reuse that construct to provide data to OVF tests and build in support for $ConfigurationData, $AllNodes, and $Node.

I'm a little unclear on how the the Pester tests would have to be constructed to support the
ConfigurationData format. Maybe an example? If the Pester tests are designed to test the local machine, what would $Allnodes and $Node do?

@devblackops Take AD for example -If the machine were configured with DSC, you could use the NodeName to filter allnodes to find your specific instance, in allnodes.  And based on the role or other data, you could identify what other domain controllers should be in the environment, test site links, check replication, etc..  Since your configurationdata should represent both the current node and the environment, you have all the data you should need to work with.

Take a look at https://github.com/DexterPOSH/PSRemotely. We have DSC style configuration data support.


VSCode devcontainer

Hi,
I've added dev container configuration and VSCode settings into my fork, would you want me to PR that into your repo?
https://github.com/golles/gitprofile/blob/main/.devcontainer/devcontainer.json
https://github.com/golles/gitprofile/tree/main/.vscode
More info: https://code.visualstudio.com/docs/devcontainers/containers

Can you briefly explain the use cases for it? I have never used dev container before.

The dev container is a docker container that has the environment set up so that you can develop inside it, without installing software (specific version) on your (host) machine, in the case of this project node.
For more info, you can check the more info link I shared in my opening post. If you're not interested, feel free to close this issue.


Don't remove the cleanSrc if it equals '.'

This fixes the issue where when cleanSrc equals '.', copied files are missing the first character from their names.
Note: I had issues getting the functional and unit tests working on my machine.
Fixes appc/acbuild#211

Awesome, thanks for this!


Sync and fullscreen icons overlap

In nvAlt version 2.2b (94) the sync and fullscreen icons overlap.

noted


Support M1

Now as Kotlin 1.5.30 is out it would be nice if you could add the targets macosArm64 and iosSimulatorArm64.

Awesome! 👍

Released in v0.6.0


WFLY-4443

https://issues.jboss.org/browse/WFLY-4443

Linux Build 6079 is now running using a merge of 419ae9059876877701203945cde68c69eb5237e7

Linux with security manager Build 1056 is now running using a merge of 419ae9059876877701203945cde68c69eb5237e7

Windows Build 1192 is now running using a merge of 419ae9059876877701203945cde68c69eb5237e7

Linux with security manager Build 1056 outcome was SUCCESS using a merge of 419ae9059876877701203945cde68c69eb5237e7
Summary: Tests passed: 846, ignored: 319 Build time: 0:05:27

Windows Build 1192 outcome was SUCCESS using a merge of 419ae9059876877701203945cde68c69eb5237e7
Summary: Tests passed: 2927, ignored: 311, muted: 2 Build time: 0:46:52

Linux Build 6079 outcome was SUCCESS using a merge of 419ae9059876877701203945cde68c69eb5237e7
Summary: Tests passed: 2928, ignored: 311, muted: 1 Build time: 0:50:55

Windows Build 1194 is now running using a merge of 2e8279033af665802f3eadb547f3d80a95b1fc8f

Linux Build 6081 is now running using a merge of 2e8279033af665802f3eadb547f3d80a95b1fc8f

Linux with security manager Build 1058 is now running using a merge of 2e8279033af665802f3eadb547f3d80a95b1fc8f

Linux with security manager Build 1058 outcome was SUCCESS using a merge of 2e8279033af665802f3eadb547f3d80a95b1fc8f
Summary: Tests passed: 847, ignored: 319 Build time: 0:05:43

Windows Build 1194 outcome was SUCCESS using a merge of 2e8279033af665802f3eadb547f3d80a95b1fc8f
Summary: Tests passed: 2928, ignored: 311, muted: 2 Build time: 0:50:31

Linux Build 6081 outcome was SUCCESS using a merge of 2e8279033af665802f3eadb547f3d80a95b1fc8f
Summary: Tests passed: 2929, ignored: 311, muted: 1 Build time: 0:51:59


Update JobResult manager store_result method to censor sensitive vari…

…ables

Closes: #3692
What's Changed

TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

create_job_result_and_run_job function has an *args but we never use it? Is that how you pass in task_args in a testing job?

create_job_result_and_run_job function has an *args but we never use it? Is that how you pass in task_args in a testing job?

It is but we currently don't use positional args for jobs and I think the plan was to discourage their use.


package change

Hey, right now we upgraded react-native-version in this library, anyway thanks for pr!


Add line comment should await the tokenization to get the correct language at the position

Does this issue occur when all extensions are disabled?: Yes

Version: 1.95.3
Commit: f1a4fb101478ce6ec82fe9627c43efbf9e98c813
Steps to Reproduce:

ALL vs code IDE windows must be closed
Open IDE, it must be at startup open previous project at tab with html file with input cursor put inside script tag
Try to use comment line command (ctrl + /) to comment JS code inside this script tag

AR
nothing happens (until your click on another tab with .js file)
ER
must be commented line
This happens from time to time, but not always

That works for me.
What's the editor language mode (you can see this in the status bar). HTML?

Yes, html. This works if you open first window IDE and it opens last project and cursor already stay inside script tag (anywhere). It works in 30% of time. It feels like that JS handler (or whatever controls js code inside script tags) is not loaded (and not loading, waiting minute or two doesnt fixes this)

Ok, I see, if you reload the Window and press ctrl + / right away, then the htm comment is used.
I suspect the TextMate grammar or the embedded grammar are not yet loaded.
The 'Add Line Comment` command should await these

make sure to reload VSCode with the embedded language (JavaScript) not visible on the screen
often the embedded languages are not correctly loaded on reload
and no amount of time waiting for it fixes it
however, often typing fixes it
https://github.com/user-attachments/assets/1c7beb39-bd84-43d4-9add-101e496d01da
https://github.com/user-attachments/assets/e70e54a0-7689-4b9a-a212-31b97b5fdfb7
related:

https://github.com/microsoft/vscode/issues/235241
https://github.com/microsoft/vscode/issues/234867
https://github.com/microsoft/vscode/issues/234722
https://github.com/microsoft/vscode/issues/234622
https://github.com/microsoft/vscode/issues/231168
https://github.com/microsoft/vscode/issues/216587
https://github.com/microsoft/vscode/issues/210928
https://github.com/microsoft/vscode/issues/210888
https://github.com/microsoft/vscode/issues/208281
https://github.com/microsoft/vscode/issues/201702
https://github.com/microsoft/vscode/issues/133462

also @aeschli
@psnet stated that comment wasn't working completely
not just that html comments were working instaed


Add resolving of input types for stateless model evaluation

@bratseth Please take a look.
With this, you can see for instance with the ModelEvaluationTest.testMl_serving test that the Placeholder model input is not resolved properly in MapEvaluationTypeContext.resolveType.

Should be ok now @lesters

@bratseth Thanks!


Added slight optimization to LMDD

The current LMDD model implements the original paper method naively.
Some easy optimizations are possible:

"if var_max > res_[j] and if var_max > 0" can be collapsed into a single if statement because res_ is initialized as zeroes.
var_max = self.dis_measure_(X[:i + 1]) - self.dis_measure_(X[:i]), because j = i, var_max is also equal to self.dis_measure_(X[:j + 1]) - self.dis_measure_(X[:j]), meaning we can replace these terms by var_max in the calculation of dk_diff.
dk_diff >= var_max can be replaced by dk_diff - var_max >= 0
We only need to add var_max into dk_diff if we actually assign it to res_[k], so the if statement can be further simplified.

This PR implements these changes in the most basic manner, leading to a small speed increase.
All Submissions Basics:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?
[x] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[x] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

Pull Request Test Coverage Report for Build 1952

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0009%) to 95.456%

Totals

Change from base Build 1889:
-0.0009%

Covered Lines:
4895

Relevant Lines:
5128

💛  - Coveralls

I do apologize for not cleaning up the pipe for long. Thanks for the optimization and I verified it is slightly faster!


Path param type

Can you please tell me how to specify path param type?

For now you can't, it's always a string. Go 1.23 router doesn't do any validation anyway so if you call /pets/my-id instead of /pets/123, the router will still match the controller.
We can add type validation on top of that, after # is merged. Just wait a week and this syntax will be available:
fuego.Get(s, "/pets/{id}", getPetByID,
    option.PathInt("id", "ID of the pet to get")
)

Security checks:

Fuego will crash at start time and warn you if the declaration does not match the string in the router
Fuego will return a HTTPError if the path param "id" is not a string

What do you think about this behaviour? This feature is not merged into main, so you can still have a word about it.

In the meantime, you can access the parameters from the route object.
myRoute := fuego.get(s, "/pets/{id}", myController)

myRoute.Operation.Parameters .... = openapi3.TypeInt

@EwenQuim

In the meantime, you can access the parameters from the route object.
myRoute := fuego.get(s, "/pets/{id}", myController)

myRoute.Operation.Parameters .... = openapi3.TypeInt

Thank you! Thats what i looking for! I need that only to generate valid openapi for clients


Include a reference to the icons naming convention in our docs

This change primarily refers to the icons in the UI the user can click or tap.
When describing the user interaction with one of these icons, we use the icon (PNG) + icon name. By default, we use the same icon name given in the Figma files. However, this might/might not be the best choice.
The Design team is willing to accept our proposals and change the icon's name when it makes sense.
So, the idea is:

In the Status writing style guide, under Style convention, we create a new H2 section, "UI elements reference." We keep this section right after "Common words usage."
In this new section, we create a simple table with three columns:

Icon — contains the icon SVG file)
name in use — contains the name we use in our docs.
Original name — if the name in use differs from the name in the Figma files.

We fill this table as we write new topics and include new icons.
If we see the need to change one icon name, we propose this change to designers via Figma comments.

This way, when some other writer needs to write about the same UI element, s/he can use the same name convention.

Notion reference page updated with this information.

Related to https://github.com/status-im/help.status.im/issues/191 and renamed to clarify this task refers to icons only.

Superseded by https://github.com/status-im/help.status.im/issues/191.


People Directory WebPart - Index navigation is not properly aligned and callout with user information is not displaying

While testing the latest code I found the following issues.

People Directory WebPart - Index navigation is not properly aligned
callout with user information is not displaying

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
(DELETE THIS PARAGRAPH AFTER READING)

Category

[ ] Question
[x] Bug
[ ] Enhancement

For the above list, an empty checkbox is [ ] as in [SPACE]. A checked checkbox is [x] with no space between the brackets. Use the PREVIEW tab at the top right to preview the rendering before submitting your issue.
(DELETE THIS PARAGRAPH AFTER READING)

Expected or Desired Behavior

If you are reporting a bug, please describe the expected behavior. If you are suggesting an enhancement please describe thoroughly the enhancement, how it can be achieved, and expected benefit.
(DELETE THIS PARAGRAPH AFTER READING)

Observed Behavior

If you are reporting a bug, please describe the behavior you expected to occur when performing the action. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Steps to Reproduce

If you are reporting a bug please describe the steps to reproduce the bug in sufficient detail to allow testing. Only way to fix things properly, is to have sufficient details to reproduce it. If you are making a suggestion, you can delete this section.
(DELETE THIS PARAGRAPH AFTER READING)

Submission Guidelines

All suggestions or bugs are welcome, please let us know what's on your mind.
If you are reporting an issue on generic SharePoint topic or dev documentation, please use the (sp-dev-docs Issue list)[http://aka.ms/spdev-issues]
If you have technical questions about the framework, we’ll be monitoring #spfx, #spfx-webparts, and > #spfx-tooling on (SharePoint StackExchange)[http://sharepoint.stackexchange.com/]. You can also > alternatively submit your question to (SharePoint Developer group)> [https://network.office.com/t5/SharePoint-Developer/bd-p/SharePointDev] at Office Network.
Remember to include sufficient details and context.
If you have multiple suggestions or bugs please submit them in separate bugs so we can track resolution.

(DELETE THIS PARAGRAPH AFTER READING)

Thanks for your contribution! Sharing is caring.

Closing this, as it is a duplicate of #45 .


Settings presets plugin

Don't know if anyone actually suggested this, but I bet many of players have different accounts like pures, alts, dolo alts.
What I mean by this, I guess it would be helpful to have a choice of settings by pressing one button.
For ex. Doing corp solo on my mid-tier laptop with another account holding the instance opened is kind of stressful for my mid-tier laptop. Everytime I close RL, I have to go through settings everytime to change fps, gpu, stretched mode settings. Having presets for different activities would give efficiency, I guess, for various activities once you set settings.

Duplicate of #2220


Markdown 2 format bad for copying code blocks

Markdown2 draws a verticle bar in the markdown output.  Getting around this now by pasting to vim and visual block selecting and deleting the bar.
My prior issue #7 asks about toggling the output method to experiement with other output formats.
┃ mkdir transformed_files && \
┃ for file in *; do \
┃     if [[ "$file" == *\ * ]]; then \
┃         new_file=$(echo "$file" | sed 's/ /_/g'); \
┃         cp "$file" "transformed_files/$new_file"; \
┃     else \
┃         cp "$file" transformed_files/; \
┃     fi; \
┃ done

@zach-is-my-name yep, unfortunately, the underlying markdown renderer doesn't allow styling options.
The best way is honestly to not use markdown formatters for now as they are still experimental, and even if they were not, there is not much I can do about the vertical line anyway which is not a hack. To properly solve this I'd need to implement formatting options into the underlying library by either forking it or doing a PR request and merging it into the lib.
I definitely will be looking to improve markdown renderers, but I'd need to properly assess possible solutions and pick what makes most sense, and even then the fix isn't the most straightforward thing, so it is not happening this month (April) at least 😬
So for now it's out of scope, unfortunately.
What I can undertake right now is contacting authors of the markdown rendering lib and ask them if they are looking to support different styles / coloschemes etc, and I'll post here as soon as I hear from them.

Thanks for the reply.  I understand.  For the future perhaps there's
something that can be done with the Charm suite
https://github.com/charmbracelet.  Until then gogpt is still my favorite
gpt cli tool.
On Fri, Mar 31, 2023 at 11:11 PM Kirill Kovalchuk @.***>
wrote:

@zach-is-my-name https://github.com/zach-is-my-name yep, unfortunately,
the underlying markdown renderer doesn't allow styling options.
The best way is honestly to not use markdown formatters for now as they
are still experimental, and even if they were not, there is not much I can
do about the vertical line anyway which is not a hack. To properly solve
this I'd need to implement formatting options into the underlying library
by either forking it or doing a PR request and merging it into the lib.
I definitely will be looking to improve markdown renderers, but I'd need
to properly assess possible solutions and pick what makes most sense, and
even then the fix isn't the most straightforward thing, so it is not
happening this month (April) at least 😬
So for now it's out of scope, unfortunately.
What I can undertake right now is contacting authors of the markdown
rendering lib and ask them if they are looking to support different styles
/ coloschemes etc, and I'll post here as soon as I hear from them.
—
Reply to this email directly, view it on GitHub
https://github.com/Nemoden/gogpt/issues/8#issuecomment-1492824513, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AD2RU5GX7NSQAKSCCYCP4FLW66THRANCNFSM6AAAAAAWALLIWQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Remove PDFJSDev.json from the pre-processor

The PDFJSDev.json functionality has never been used much, and there's currently only a single call-site remaining.[1]
It's possible to replace that one with PDFJSDev.eval, by tweaking the gulpfile a little bit, and we can thus simplify the pre-processor code slightly.
Please note: This can be considered a step towards implementing issue #18563, and once import attributes become generally available in (all) browsers and build-tools we can change the web/chromecom.js file to use that instead.

[1] The previous usage was removed over three and a half years ago.

/botio unittest

once import attributes become generally available in (all) browsers and build-tools we can change the web/chromecom.js file to use that instead

Last time I checked, web/chromecom.js is run through Webpack and so the import attributes syntax is removed from the file that gets generated.

ESLint was the only blocker, but they recently released support for import attributes so it should be fine now.

Maybe, but that requires fixing issue #17928 first as far as I can tell. (Last time I looked at that, it didn't seem trivial to just update.)


Add edge subcommands and unit tests

Support for developing, testing and debugging functions which runs on Link IoT Edge finally via providing a Link IoT Edge like environment.
Start and stop the Link IoT Edge like environment.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Feilong Wang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


--readonly is not considered in exec.jl

The field --readonly is not considered in the script exec.jl. This argument has no effect and only write transaction are emitted.

I am not sure whether we should use GitHub issue still. Here is the same issue on Jira: https://relationalai.atlassian.net/browse/RAI-11414


Performance of Supervised model

Dear nothinglo,
do you have per chance the working code of your supervised training model?
I have spend a considerable amount of time and have tried to reimplement everything, except for your model itself. I have then also just taken the code you have and made the least amount of changes to them to reproduce the supervised training case.
Unfortunately I have not been able to achieve a PSNR of 23.8 BY FAR.
The best I got was about 21.4 and note that I spent about the last two months to work on this full time, so I don't think it is because of lack of trying. I would appreciate if you could comment or provide some sort of working code to reproduce your results.
cheers
Jérémy

Dear Jérémy,
You mean you use the code I provided and make it be the supervised training. And you use the same training data and testing data as I used but the performance is not as good as I had before?

Dear nothinglo,
Exactly. I used the code you provided...and I made some adjustments to it(because your implementation is read for the 2way cycle gan), for example I am optimized the log(mse)-loss of the original image and the edited image(which you call input_label). I then run it for 150 epoch and I get the following...

So I am by far not at your performance of 23.8.
I have also made another implmementation where I have written everything from scratch escept for the model itself, which I have taken from your code. And there i get a maximum PSNR of 21.5, but already after about 20 epochs and afterwards it becomes worse again.
NOTE: I am using also retoucher C and I am using the exact same data samples that you use in your folder train.txt and test.txt. Also note that I am doing data augmentation like you.
Hope you can help.
Kind regards
Jérémy

What is your initial PSNR (before training) in testing data?

Dear nothinglo,
I am testing before starting to train and I get a PSNR on the RGB images of the test set of
18.4057.
So it is actually learning something.

Oh sorry, yeah that's just because the graph contained two different runs...the stuff in the lower part you can just ignore.
Oh I see...do you know when that is? Because I have to extend on the supervised model that you have proposed, and currently I only have one that does not achieve the results you mention. And unfortunately I have already spent weeks trying to make this code work, i.e. i have to continue with building on this model and I have not more time to make this work as my Deadline is approaching very quickly. Do you think it would be possible for me to get a sneak peak at your code before you publish it on github so that I could try and figure out what is going wrongly?
Kind regards
Jérémy

I think I can release the supervised code in 24 hrs. Thank.

Dear nothinglo,
That would be totally AMAZING. You would really save my butt, because if this then works I can really continue on time. THANKS  A LOT.
Kind regards
Jérémy

Thanks so much!!! Cheers to you!

Hey nothinglo,
Quick question as I am getting a little bit nervous...I am still running your code, I am at epoch 34 and the PSNR of the validation set is back at about 21.2 and the best value was 21.6. I am wondering if the problem might be the dataset I am using.
Thus i wanted to ask, do I have to resize my images before I run the model on it? I mean I export the Retoucher C's data from Lightroom and what I did then was to resize the image to 512x512 by using
cv2.resize(im, (512, 512)). Unfortunately this incorporates linear interpolation and thus the image coloring sometimes looks very different than the original retoucher C.
So I am wondering do I have to insert the original image of retoucher C into the model(and the data part takes care of it) or do I have to resize my images myself? In case I have to do it myself, what resizing library did you use?(just to make sure I have the same dataset as you have)

Maybe I am still a little confused about this question https://github.com/nothinglo/Deep-Photo-Enhancer/issues/27
You say you export from lightroom an image and resize the long edge to be 512. Do you then directly train on this image? Or where do you resize it to be 512x512?

Oh, then I think the performance difference between you and me is due to the dataset. I resize the long edge to be 512 and use padding to make the image to be 512x512. Also, I calculate the PSNR after cropping the image to the valid region.

Yes that could be the case. In the beginning I also used the dataset of retoucher A, just to see, and the performance was about 2 PSNR less than for the retoucher C. So the data itself does have a big impact.
Yes I think i saw that now in your code. It all makes sense now.
Thanks :)

Thanks!


chore(master): release 0.6.1

:robot: I have created a release beep boop
0.6.1 (2024-06-29)
Bug Fixes

Don't give empty documentation to starlark-rust (#44) (355ceed), closes #41

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/cameron-martin/bazel-lsp/releases/tag/v0.6.1 :sunflower:


Aggregated Dependabot updates 20210701

Aggregation of pending Depenabot PRs

Maven & Gradle builds + FVT successful (locally)


AR: Add tracking state and help text to TableTop AR

This PR adds help text to TableTopSceneView to guide the user through an AR experience. The help text follows Apple's human interface guidelines for communicating with people in AR.

Would it be good to have a view modifier that can disable the help strings if the app developer didn't want them?

Yes I think so, with a modifier name such as helpTextHidden or helpTextDisabled.

Would it be good to have a view modifier that can disable the help strings if the app developer didn't want them?

Yes I think so, with a modifier name such as helpTextHidden or helpTextDisabled.

Hidden

FYI: The static localized string properties should be computed instead of stored since the locale could change while the app is running, which could affect which translation is used. You also don't want them hanging around forever.


Possible to bypass CORS?

Is it possible to bypass CORS ? If so, how? - using this module of course.
I have not been able to find just one example on this matter. If possible, please supply me with an example.

@Sebastian-Nielsen Did you find any solution for this?

Also need to know the answer for this.
Passing in
let common_options = {
  headers: {
    "Access-Control-Allow-Origin": "*",
    "Access-Control-Allow-Methods": "GET, POST, PUT, DELETE, PATCH, OPTIONS",
    "Access-Control-Allow-Headers": "X-Requested-With, content-type, Authorization"
  }
};

To request.post(url, common_options, (e,r,b)=>{}) still doesn't work, on localhost, running webpack-dev-server to serve/pack the code, and trying to make some https calls to zoom.com


tests: counter: RW612 dts overlay support for basic_api tests

Remove memory spaces not needed for the counter_basic_api test for RW612 boards. Add frdm_rw612.overlay
Fixes #80650

@dleach02 please take a look at compliance failure

@nordic-krch not clear why you won the assignee on this but can I get a +1 from you?


eframe does not appear to expose ability to set window transparency and mouse passthrough

Is your feature request related to a problem? Please describe.
egui::NativeOptions exposes a couple fields that don't seem to have a way to change during runtime, such as transparency and mouse_passthrough.
Describe the solution you'd like
Add additional setters to egui::Frame to control these settings.
Describe alternatives you've considered
A workaround for transparency is to set the App::clear_color to return an opque background, but I believe this is not the same thing, performance wise, when disabling transparency on the window, since the window compositor needs to do more work.
Additional context
N/A

Sounds good to add it to Frame

this was one of the reasons why i didn't use eframe i have a use cases where this is required
now i had to do all of this myself 😭 window creation, wgpu setup egui setup, event loop ...

This is now possible with https://docs.rs/egui/latest/egui/struct.Context.html#method.send_viewport_cmd

Lol,  I thought I had made a PR for this...but I actually made it for iced, because I needed it there too, and forgot to contribute back here. Sorry about that!


Flow hangs every now and then requires restarting

Flow version: 0.228.0
I noticed, and also from talking with my colleagues, that sometimes flow gets into a state where it no longer provides type hints in lsp and hangs when checking. flow stop and start fixes the issue, but it's a bit annoying. Occurs on the order of days / weeks. Have you had a similar issue at Meta?

When it happens, it would be helpful to get the logs from flow. It will be available at /tmp/flow in mac and linux

macOS Sonoma. We don't configure a watcher. Will do

Closing for now as I don't have a repro will reopen if I catch it


Dependency Loop detected with Py post processing and Clusterio

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[ ] pyalienlife
[ ] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[X] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[X] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
Mod compatibility crash between py mods and clusterio.
Steps to reproduce

Add all the Py mods.
Add clusterio lib+sub space storage mod
crash at py post processing

Additional context

It doesn't seem it's just this mod. There seem to be several other mods that cause this dependency loop. I removed clusterio and added a bunch of other mods. similar issue.
Log file
No response

Resolved in pyanodon/pypostprocessing@149155ed56fdacd13a315c053b7a63098baee1bd

Is this something subspace_storage should do to be more compatible?

Is this something subspace_storage should do to be more compatible?

I don't think so - ignore_for_dependencies is a non-standard attribute used on our end. I think it would be unreasonable to expect other mods to start accounting for that.


ELIC

On your github homepage, I saw your reproduction of the ELIC model, but I did not find your project code. If your project is open source, can you use your code? I want to learn and improve on this basis. Thank you very much for checking this issue during your busy time. I wish you a smooth and fruitful research.
在您的github主页上，我看到了您对ELIC模型的复现，但我没有找到您的项目代码。如果你的项目是开源的，你能使用你的代码吗？我想在此基础上学习和提高。非常感谢您在繁忙的时间回复这个问题。我祝愿你的研究顺利而富有成果。

sorry for the late reply. My original inplementation has some mistakes. My implementation of Residual Bottleneck is wrong. In my original implementation, assuming the channel number of input feature is N, the first 1x1 conv increases the channel number to 2N while in ELIC, the first 1x1 conv decreases the channel number to N/2. I'm now re-training the model, which will takes some days. You can refer to https://github.com/Googolxx/STF for channel-wise context implementation and  https://github.com/JiangWeibeta/Checkerboard-Context-Model-for-Efficient-Learned-Image-Compression for checkerboard implementation.

Thank you very much for your reply. I hope you can share it on github after finishing the experiment. I wish you a smooth research.
赵治衡
@.***

------------------ 原始邮件 ------------------
发件人: "Jiang @.>;
发送时间: 2022年12月5日(星期一) 下午2:42
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [JiangWeibeta/ELIC] ELIC (Issue #1)
不好意思，回复晚了。我原来的实施有一些错误。我的残余瓶颈的实现是错误的。在我最初的实现中，假设输入特性的通道数为N，第一个1x1 conv将通道数增加到2N，而在ELIC中，第一个1x1 conv将通道数减少到N/2。我现在重新训练模型，这将需要几天。你可以参考Https://github.com/Googolxx/STF用于信道级上下文实现和Https://github.com/JiangWeibeta/Checkerboard-Context-Model-for-Efficient-Learned-Image-Compression用于棋盘实现。
—
直接回复这封邮件，在GitHub上查看，或取消订阅.
您收到此消息是因为您编写了该线程。消息ID：<江维贝塔/埃利奇/问题/1/1336820891@@GitHub.与>

您好，可以先分享下您复现的模型代码吗

您好，可以分享下您复现的模型代码吗

Hello, the author, you said last time that there are some problems in the code that need to retrain the model. I don't know whether your code is debugged well now, and if so, whether it can be open source to your GitHub. Thank you very much.


add documentation how to configure delta.logRetentionDuration

Description
I am trying to create a delta table like this with a log limited to 1 day
from deltalake import DeltaTable
import pyarrow as pa
dt = DeltaTable.create(
    table_uri='s3://aemo/scada2',
     schema = pa.schema([
                      pa.field('SETTLEMENTDATE', pa.timestamp('us')),
                      pa.field('DUID', pa.string()),
                      pa.field('SCADAVALUE', pa.float64()),
                      pa.field('Date', pa.date32()),
                      pa.field('week', pa.string()),
                      pa.field('file', pa.string())
                      ]) ,
mode ='error',
partition_by="week",
configuration = {"delta.logRetentionDuration": "1 days"} ,
storage_options=storage_options
)

when i run dt.cleanup_metadata() it seems it still using 30 days ?

@djouallah does the table contain checkpoints?

@ion-elgreco it does indeed is this Delta Rust specific ?

@djouallah if you're using 0.15.1 it does the correct behavior of only removing up to a checkpoint based on the logRetetentionDuration. Before 0.15.1 it would actually remove based on the logRetentionDuration only which could invalidate a table state.

@ion-elgreco I am using 0.15.1 and it is not removing anything, is the format I used correct ?

Ah format should be interval <amount> <unit>, so try interval 1 day .
At the same time can you try interval 1 days, I think at the moment we don't parse the plural version..

sorry for being pedantic, but "1 days" is what spark uses, for compatibility reasons, isn't delta rust follow the same approach, is the format in delta protocol ?

@djouallah these things are not part of the protocol. I am aware that the plural version is what spark only supports, we can add that in soon, it's trivial to add

@ion-elgreco i appreciate you are doing free work, I am happy with whatever you pick, I was just curious :)


Web site is not working since a week ago.
Please fix the problem.
Is there anyway, I can look up the document on this web site?

https://github.com/Esri/terraformer/issues/319

$38/year only keep the domain? What about the server hosting fee?
What is the web site server IP?  Can I point a new domain terraformer.net or terroformer.org, to that IP?
Can I host another copy of this web site content at my server.
  [https://transparentgov.net/cleargov1/](https://transparentgov.net/cleargov1/)

I also can host your web site via IPFS networks.

Thanks for reminding us about this issue.  Let's keep the conversation going in #319 and close this issue.

Ok, agree, close


Unable to build on iOS

I started a new flutter project, then added epub_view package, and finally copy-paste complete example we can find in pub.package website (https://pub.dev/packages/epub_view/example).
I tests these library imports:

epub_view: 1.0.0
epub_view: any

I also added my epub asset correctly (i mean in the application and in yaml file).
Everytime I try to compile the application for iOS, I get this errors:
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:88:26: Error: Type 'DiagnosticableMixin' not found.
class PictureStream with DiagnosticableMixin {
^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:192:44: Error: Type 'DiagnosticableMixin' not found.
abstract class PictureStreamCompleter with DiagnosticableMixin {
^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:88:7: Error: The type 'DiagnosticableMixin' can't be mixed in.
class PictureStream with DiagnosticableMixin {
^
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:192:16: Error: The type 'DiagnosticableMixin' can't be mixed in.
abstract class PictureStreamCompleter with DiagnosticableMixin {
^
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:167:11: Error: Superclass has no method named 'debugFillProperties'.
super.debugFillProperties(properties);
^^^^^^^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:171:30: Error: The method 'toStringShort' isn't defined for the class 'PictureStreamCompleter'.

'PictureStreamCompleter' is from 'package:flutter_svg/src/picture_stream.dart' ('../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart').
Try correcting the name to the name of an existing method, or defining a method named 'toStringShort'.
ifPresent: _completer?.toStringShort(),
^^^^^^^^^^^^^
../../../.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:266:11: Error: Superclass has no method named 'debugFillProperties'.
super.debugFillProperties(description);

BUT when I tried to link to my project the epub_view to the local repository, then it works O_O.
I mean that I downloaded the git repository (https://github.com/rbcprolabs/packages.flutter.git ), then in my yaml file, I linked to the local version:
pubspec.yaml file
epub_view:
path: ../../tests/packages.flutter/packages/epub_view
That's a workaround, but not comfortable at all, as pud.package should be reliable... :/

i can't publish update epub_view 1.1 to pub (problem with old 'epub' package on pub)
temporary you can use version epub_view from repository

https://dart.dev/tools/pub/dependencies#git-packages


Add identity verification to app

I'm planning to review this more myself, and just skimming the PR there are a few things I ought to change, but this is 95% ready.


Add BlockOverrides to eth_Call

Describe the feature
Similar to #3091 but for eth_call
ref https://github.com/ethereum/go-ethereum/blob/73697529994e14996b7740730481e926d5ec3e40/internal/ethapi/api.go#L1083-L1083
BlockOverrides is an addtional Optional argument after stateoverrides
Additional context
No response

Can I try this one?


How to train model for other language?

The package is really good, but I want to use it for other language, and I tried to modify the model path and use other T5 model, but the model cannot be loaded? May I know how to train a model from scratch?
Thanks a lot.

Thanks a lot, I'll try to train a model.

Hello,
I tried to fine tune this model on persian language. I have a question. What will happen when we call this function?
It didn't take me long time to execute. How exactly the fine tuning happens in this model?
kp = KeyPhraseTransformer(model_type="mt5", model_name="folder")


Clock swallows legitimate ReferenceError from consumer code

Describe the bug
Pyglet's clock swallows legitimate errors raised by user code.  It should instead allow those errors to surface just like most other errors.
https://github.com/pyglet/pyglet/blob/2881781dcc751e1674f4306e1cde67871a3e09d6/pyglet/clock.py#L225-L229
import weakref
import pyglet

class Empty:
    pass

class App(pyglet.window.Window):
    def on_draw(self):
        print('tick')
        a = Empty()
        b = weakref.proxy(a)
        b.foo = 123
        a = None
        b.bar = 123
        print('why is this silently skipped?')

app = App()
pyglet.app.run()

In this contrived example, a legitimate logic error causes b.bar to fail.  But pyglet swallows this error, silently skipping the second print statement.
Output:
> python ./reproduction.py
tick
tick
tick
tick
tick

...
System Information:
pyglet 2.0.7
How To Reproduce
A small code example that illustrates the bug is very useful to help triage.
Code example above.

This was part of a weakref experiment that was later rolled back. Will be fixed in the next point release.
Thanks for the ticket.


Fix: Missing props type for badge component

I think need more props for types like for chart, for tag

We have these variants, they're called secondary(instead of chart) and outline(instead of tag) and me and Harsai have verbally agreed to go with that. It's just that the figma wasn't updated. It will be updated shortly.

I got it. thanks


[BUG] window sometimes moves down a bit in macOS when the menu bar is hidden

Is there an existing issue for this?

[X] I have searched the existing issues and none matched.

Operating System
macOS
CPU
No response
GPU
No response
Storage
No response
Game Version
4.10.0
Describe the problem
I want the OutFox window to fill the entire screen but I dislike the way native Full Screen works in macOS in general, so I automatically hide the menu bar and the Dock in System Preferences / Dock & Menu Bar and make the OutFox window take the whole screen (kind of like how "maximize" works in Windows, and okay, the title bar is still visible but that's fine).
Works nicely, but when I exit and reopen the game, the window has moved down a bit, approximately the height of the menu bar. The menu bar is hidden so the window shouldn't move to leave room for the menu bar, so something strange is happening here.
Describe what should happen

System Preferences / Dock & Menu Bar: Automatically hide and show the Dock (yes, we want the Dock hidden)
System Preferences / Dock & Menu Bar: Automatically hide and show the menu bar (yes, we want the menu bar hidden too)
In OutFox options, set the Display Resolution to match whatever the resolution of your screen is
move the window so that it takes the whole screen (option-click the green circle window control to "Zoom")
exit the game and then reopen it

The window position should be the same it was when I closed the window. This is what other macOS applications do.
Relevant Log output
No response

We haven't actually coded a methodology to do this yet, but it is something that is needed for a modern application, indeed.
Our MacOS support is still ongoing, we had to update a lot from a 15 year old codebase to what we have now.
Thanks for the report, and taking the time to let us know about it.


Add article java-wechaty auto get news

Fixes # .
Make sure these boxes are checked before creating your pull request -- thank you!

[x] Add Blog Header, including title, author, date.
For example:
---
title: "Your Great Blog Title"
author: your_github_id
image: /assets/2020/08-your-blog-slug/teaser.jpg
---

YOUR_FIRST_SENTENCE_SHOULD_BE_A_SUMMARY_FOR_YOUR_POST

[x] Keep all filenames & url as lowercase, and use - to connect words instead of space. e.g. 2017-10-06-wechat-pc-impactor instead of 2017-10-06-WeChat PC Impactor,

[x] Embed the photo & video before publishing, save all external file to a folder named by ${MONTH}-${YOUR_BLOG_SLUG}/ under /assets/2020 directory.

[x] Add teaser image for the blog

[x] Add your self as an author to the author data file at https://github.com/wechaty/wechaty.js.org/blob/master/_developers/YOUR_GITHUB_USERNAME.md with your GitHub username. And please also remember to reference yourself with the Github username in your blog post, so that we can have nice author information besides your blog after we published it!
For excample:
---
name: Jiarui LI (李佳芮)
site: https://lijiarui.github.io
bio: 句子互动创始人 & CEO，微软人工智能最具价值专家 (AI MVP)
avatar: /assets/developers/lijiarui/avatar.png
email<EMAIL_ADDRESS>twitter: https://weibo.com/u/2175505900
---

Here is the example file:

lijiarui.md: https://github.com/wechaty/wechaty.github.io/blob/master/_developers/lijiarui.md
It will shown like this on wechaty blog: https://wechaty.github.io/developers/lijiarui/

To read more about the contribute guideline, visit: https://github.com/wechaty/wechaty.js.org#contribute-guideline

It's so great to see a Java Wechaty blog post!
Please change your filename to lowercase then I believe it's ready to be merged!

OK, please recheck

@HarrisonQi  Thank you very much for your sharing!

You've invited 阿航 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.
And we also have a WeChat room for contributors only which can discuss Wechaty at a deep level, you are welcome to join and if you are interested please contact @lijiarui to ask for an invitation.

@HarrisonQi  Thank you very much for your sharing!

You've invited 阿航 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.
And we also have a WeChat room for contributors only which can discuss Wechaty at a deep level, you are welcome to join and if you are interested please contact @lijiarui to ask for an invitation.

@HarrisonQi  Thank you very much for your sharing!

You've invited 阿航 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.
And we also have a WeChat room for contributors only which can discuss Wechaty at a deep level, you are welcome to join and if you are interested please contact @lijiarui to ask for an invitation.
Happy New Year!

Thank you very much!

@HarrisonQi  Thank you very much for your sharing!

You've invited 阿航 to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message.
And we also have a WeChat room for contributors only which can discuss Wechaty at a deep level, you are welcome to join and if you are interested please contact @lijiarui to ask for an invitation.
Happy New Year!

Thank you very much!


Add support for folding into composables

Whould it make sence for this library to be able to fold types to composables? Maybe an extension that supports composable?
I have done something like this to convert the types into something that can be representable to the user:
@Composable
inline fun <C> UCT<C>.Compose(
    crossinline onLoading: @Composable () -> Unit,
    crossinline onError: @Composable (Throwable) -> Unit,
    crossinline onContent: @Composable (C) -> Unit
) {
    return ComposeTypes(
        onLoading = { onLoading() },
        onContent = { onContent(it.value) },
        onError = { onError(it.value) }
    )
}

@Composable
inline fun <C> UCT<C>.ComposeTypes(
    crossinline onLoading: @Composable (Type.Loading.UnitType) -> Unit,
    crossinline onContent: @Composable (Type.Content<C>) -> Unit,
    crossinline onError: @Composable (Type.Error.ThrowableType) -> Unit
) {
    return when (val type = asLceType()) {
        is Type.Loading.UnitType -> onLoading(type)
        is Type.Content -> onContent(type)
        is Type.Error.ThrowableType -> onError(type)
        else -> throw IllegalStateException("this should not happen: $type")
    }
}

and then the usages could be something like this:
    val uiState by remember {
        mutableStateOf(UCT.content("hello earth!"))
    }
    uiState.Compose(
        onError = {
            Text(text = it.message ?: "")
            ErrorView(stringResource(id = R.string.error))
        },
        onLoading = {
            LoadingView(stringResource(id = R.string.loading))
        },
        onContent = {
            Text(text = it)
        }
    )

Hey, thanks for submitting an issue. This makes sense to me, I think we should have lce-compose module for such utilities.
Looking at what I see in our codebase, there seems to be some nuance around animations. We aren't using fold because of the way animation container also needs to know when to animate out which depends on nullability of the model. I wonder if there is a public API that would be simple yet flexible or maybe we need to have two options.
@Composable
inline fun <Content> UCT<Content>.Render(
    crossinline onLoading: @Composable () -> Unit,
    crossinline onError: @Composable (Throwable) -> Unit,
    crossinline onContent: @Composable (C) -> Unit
) {
    AnimateContentIn(loadingOrNull()) { onLoading() }
    AnimateContentIn(errorOrNull()) { onError(it) }
    AnimateContentIn(contentOrNull()) { onContent(it) }
}

@OptIn(ExperimentalAnimationApi::class)
@Composable
private fun <T> AnimateContentIn(model: T?, content: @Composable (T) -> Unit) {
    AnimatedVisibility(visible = model != null, enter = fadeIn(), exit = fadeOut()) {
        model?.let { content(it) }
    }
}

Any movement on this?


New stop disappearing from map at certain zoom levels

 Issue by evansiroky
Wednesday May 16, 2018 at 05:02 GMT
Originally opened as https://github.com/catalogueglobal/datatools-ui/issues/160

If you create a stop, the move the stop at fairly high zoom level, but then zoom back in the stop will disappear from the map.

 Comment by landonreed
Wednesday May 16, 2018 at 14:27 GMT

Does this happen after saving the new stop? I'm having trouble recreating.

:tada: This issue has been resolved in version 4.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add msi support for windows 2008

Support for windows 2008 was broken in this version
https://github.com/sensu/sensu-chef/blob/develop/CHANGELOG.md#fixed
Description
Adds support back for windows 2008
How Has This Been Tested?
This is a regression
Screenshots (if appropriate):
Types of changes

[ X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X ] I have read the CONTRIBUTING document.

Thanks for the fix, will review shortly.

released: https://supermarket.chef.io/cookbooks/sensu/versions/5.1.1


SW-5280 Sync with BE that has other new species fields

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2558  👈
#2557
#2551
#2550
#2549
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite


Fix Commands:Load

Without defining a type for the arg it would be seen as null in argument.js causing an error Cannot read property 'isEmpty' of null on line 351 of argument.js (see full error here: https://gist.github.com/Favna/174d4bd2543c6a40b38988d58ea723a2
Simply adding 'type': 'command' below the prompt (just like in unload) property fixes this issue, thus making it possible to load commands on the fly again.
Semantic versioning classification:

[X] This PR changes the library's interface (methods or parameters added)

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

p.s. eslint has been verified but from my experience Travis can be a real sob so I'm not getting my hopes up '_>'

oci runtime error: exec failed: container_linux.go:265: starting container process caused "could not create session key: disk quota exceeded"
Thanks Travis '_>'. Well that's something on my end that's for sure.


[nextjs] Missing dependencies for SSR

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
dbbff8yaqbc49
AWS Region
us-west-2
Amplify Hosting feature
SSR
Describe the bug
spectaql is installed in my package.json
Hosting compute logs indicate it is missing
Expected behavior
Dependencies should work like dependencies.
Reproduction steps

Create next.js app
Use spectaql

Build Settings
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - npm ci
    build:
      commands:
        - env | grep -e GQL_SUPERGRAPH_ROUTER -e AUTH0_BASE_URL -e AUTH0_ISSUER_BASE_URL -e AUTH0_AUDIENCE -e AUTH0_SECRET -e AUTH0_CLIENT_ID -e AUTH0_CLIENT_SECRET >> .env.production
        - npm run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Log output

# Put your logs below this line

Error: Cannot find module '/var/task/node_modules/spectaql/dist/spectaql/index'

Additional information
No workarounds that I am aware of, would appreciate any help.
I have reviewed other somewhat similar issues, but they all seem like different edge cases as opposed to spectaql usage.
Also maybe relevant, we're using nextjs auth0 as well, but haven't gotten past spectaql to review if there are any issues:
    "@auth0/nextjs-auth0": "^2.2.1",

Hi @taylorsmithgg 👋🏽 thanks for raising this issue. Can you try building your app locally and see if you run into this same error?

@taylorsmithgg can you try building your app locally in standalone mode and see if the module is available under the .next/standalone directory?
You can do this by adding the following code your next.config.js file:
module.exports = {
  output: 'standalone',
}

If that works, our next course of action would be for us to reproduce the behavior. In that case, it would be helpful if you could provide us a basic repo that produces this issue so we can further investigate.

@hloriii We were already using standalone in this project.
The dependency is available in .next/standalone/node_modules

@taylorsmithgg maybe this hasn't apply to you but I was having errors using nextjs v13.0.0, first related to images and once that was fixed in a canary-16 revision but we start having issues using a middleware which has a workaround modifying the built. Next v13.2.4 has been working fine.
This is the middleware workaround
// amplify.yml
version: 1
frontend:
  phases:
    preBuild:
      commands:
        - yarn install
    build:
      commands:
        - yarn run build
        - cp -r .next/server/edge-chunks .next/standalone/.next/server/edge-chunks
  artifacts:
    baseDirectory: .next
    files:
      - "**/*"
  cache:
    paths:
      - node_modules/**/*

@abepuentes I'm not using edge runtime, but I did try using 13.2.4:
- cp -r .next/server/chunks .next/standalone/.next/server/chunks

Still not able to deploy.

@taylorsmithgg sorry about the late reply. I'm not using edge runtime either, but for some reason the build need that exact line to be able to deploy. This has been fixed on<EMAIL_ADDRESS>so the amplify.yml file is not need but it has all other issues that you can read here. https://github.com/aws-amplify/amplify-hosting/issues/3466. As @hloriii has stated 13.3.4 is the newest next version you can use on amplify hosting to this date.

@taylorsmithgg sorry about the late reply. I'm not using edge runtime either, but for some reason the build need that exact line to be able to deploy. This has been fixed on<EMAIL_ADDRESS>so the amplify.yml file is not need but it has all other issues that you can read here. #3466. As @hloriii has stated 13.3.4 is the newest next version you can use on amplify hosting to this date.

hi. how can i check anytime current nextjs version supported by amplify? and also, nodejs version. i couldn't find in docs... the only place i found something was in these issues. i'd like to stay in sync with supported versions to avoid build something not compatible.


Make clear that entity view extension only supports object types

Put a warning or so in the documentation that states, that entity views only support object types. This means that getters always have to start with get and primitive types are forbidden.

Not relevant anymore since it got implemented.


Slices: Fix the overflow  when the  address of a Slice elemnt is computed

Fixes Span indexer computes the element offset using Int32 which can overflow
Improves the generated  code a bit in terms of size and quality.
[MethodImpl(MethodImplOptions.NoInlining)]
public static void TestSpan(Span<long> span, int index)
{
    span[index] = 33;
}

Before the fix
; Assembly listing for method CoreClrTest.Program:TestSpan(struct,int)
; Emitting BLENDED_CODE for X64 CPU with SSE2
; optimized code
; rsp based frame
; partially interruptible
; Final local variable assignments
;
;  V00 arg0         [V00,T00] (  8,  10  )   byref  ->  rcx         ld-addr-op
;  V01 arg1         [V01,T01] (  5,   4.5)     int  ->  rdx
;  V02 tmp0         [V02,T02] (  2,   4  )     ref  ->  rax
;  V03 tmp1         [V03,T03] (  2,   4  )    long  ->  rcx
;* V04 tmp2         [V04    ] (  0,   0  )    long  ->  zero-ref
;  V05 tmp3         [V05,T08] (  3,   0  )     ref  ->  rsi
;  V06 tmp4         [V06,T06] (  2,   3  )     int  ->  rax         ld-addr-op
;* V07 tmp5         [V07    ] (  0,   0  )    long  ->  zero-ref    ld-addr-op
;  V08 tmp6         [V08,T04] (  2,   4  )     int  ->  rdx
;* V09 tmp7         [V09    ] (  0,   0  )    long  ->  zero-ref
;  V10 tmp8         [V10,T05] (  2,   4  )    long  ->  rcx
;  V11 tmp9         [V11,T07] (  2,   2  )   byref  ->  rax
;* V12 tmp10        [V12    ] (  0,   0  )    long  ->  zero-ref
;* V13 tmp11        [V13    ] (  0,   0  )    long  ->  zero-ref
;  V14 OutArgs      [V14    ] (  1,   1  )  lclBlk (32) [rsp+0x00]
;
; Lcl frame size = 32

G_M17569_IG01:
       56                   push     rsi
       4883EC20             sub      rsp, 32

G_M17569_IG02:
       8B4110               mov      eax, dword ptr [rcx+16]
       85D2                 test     edx, edx
       7C22                 jl       SHORT G_M17569_IG05
       3BD0                 cmp      edx, eax
       7D1E                 jge      SHORT G_M17569_IG05

G_M17569_IG03:
       488B01               mov      rax, gword ptr [rcx]
       488B4908             mov      rcx, qword ptr [rcx+8]
       C1E203               shl      edx, 3
       4863D2               movsxd   edx, edx
       4803CA               add      rcx, rdx
       48C7040821000000     mov      qword ptr [rax+rcx], 33

G_M17569_IG04:
       4883C420             add      rsp, 32
       5E                   pop      rsi
       C3                   ret

G_M17569_IG05:
       48B9A044FCB7FD7F0000 mov      rcx, 0x7FFDB7FC44A0
       E8630C3E5F           call     CORINFO_HELP_NEWSFAST
       488BF0               mov      rsi, rax
       488BCE               mov      rcx, rsi
       E898747162           call     System.ArgumentOutOfRangeException:.ctor():this
       488BCE               mov      rcx, rsi
       E8000CD55E           call     CORINFO_HELP_THROW
       CC                   int3

; Total bytes of code 81, prolog size 5 for method CoreClrTest.Program:TestSpan(struct,int)
; ============================================================

After
; Assembly listing for method CoreClrTest.Program:TestSpan(struct,int)
; Emitting BLENDED_CODE for X64 CPU with SSE2
; optimized code
; rsp based frame
; partially interruptible
; Final local variable assignments
;
;  V00 arg0         [V00,T00] (  8,  10  )   byref  ->  rcx         ld-addr-op
;  V01 arg1         [V01,T01] (  5,   4.5)     int  ->  rdx
;* V02 tmp0         [V02    ] (  0,   0  )    long  ->  zero-ref
;  V03 tmp1         [V03,T06] (  3,   0  )     ref  ->  rsi
;  V04 tmp2         [V04,T04] (  2,   3  )     int  ->  rax         ld-addr-op
;  V05 tmp3         [V05,T02] (  2,   4  )     ref  ->  rax         ld-addr-op
;  V06 tmp4         [V06,T05] (  2,   2  )   byref  ->  rax
;  V07 tmp5         [V07,T03] (  2,   4  )    long  ->  rcx         ld-addr-op
;* V08 tmp6         [V08    ] (  0,   0  )    long  ->  zero-ref
;* V09 tmp7         [V09    ] (  0,   0  )    long  ->  zero-ref
;  V10 OutArgs      [V10    ] (  1,   1  )  lclBlk (32) [rsp+0x00]
;
; Lcl frame size = 32

G_M17565_IG01:
       56                   push     rsi
       4883EC20             sub      rsp, 32

G_M17565_IG02:
       8B4110               mov      eax, dword ptr [rcx+16]
       85D2                 test     edx, edx
       7C1F                 jl       SHORT G_M17565_IG05
       3BD0                 cmp      edx, eax
       7D1B                 jge      SHORT G_M17565_IG05

G_M17565_IG03:
       488B01               mov      rax, gword ptr [rcx]
       488B4908             mov      rcx, qword ptr [rcx+8]
       4803C1               add      rax, rcx
       4863CA               movsxd   ecx, edx
       48C704C821000000     mov      qword ptr [rax+8*rcx], 33

G_M17565_IG04:
       4883C420             add      rsp, 32
       5E                   pop      rsi
       C3                   ret

G_M17565_IG05:
       48B9A044FCB7FD7F0000 mov      rcx, 0x7FFDB7FC44A0
       E8660C3C5F           call     CORINFO_HELP_NEWSFAST
       488BF0               mov      rsi, rax
       488BCE               mov      rcx, rsi
       E89B746F62           call     System.ArgumentOutOfRangeException:.ctor():this
       488BCE               mov      rcx, rsi
       E8030CD35E           call     CORINFO_HELP_THROW
       CC                   int3

; Total bytes of code 78, prolog size 5 for method CoreClrTest.Program:TestSpan(struct,int)
; ============================================================

Thanks, LGTM

@KrzysztofCwalina @krwq
There is low-hanging fruit for SpanEnumerator making it > 3 times faster in 3 times shorter codegen.
But I need  changes from this PR. Can it be reviewed before the others pls? )

I think mul does not need conv.u for a never negative int32 operand.
but LGTM regardless.

Hey @omariom, Thank you for your PR :+1: The results you are presenting here look really nice!  I haven't had time to fully review it but on the first glance it looks good. The only concern I have is checked in exe. That was a mistake I pushed it in the initial commit but it happened. I personally believe in your good intentions although if your machine happens to be infected it will cause problems. I believe you understand potential scope of issues if the the exe has any malicious code (infected computer etc.). There are two options we can go with this:

make exe build as part of the build and then use it,
I can manually modify and merge your PR and build the exe from one of the internal machines.

If time let's me l will try to take deeper look at your PR today evening and merge. Thank you for your help! :smiley:

@krwq

There are two options we can go with this:
•make exe build as part of the build and then use it,
•I can manually modify and merge your PR and build the exe from one of the internal machines.

The latter will be probably faster to do )

I'm confused. What exe?

Aah.. that's was about another PR :smile:

I was wondering where did my comment disappear.... :smile: Yes that was to another PR

I tried to rebase and apply the changes to ReadOnlySpan but it made some commits to appear again.
Hmm..

@omariom, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

I completely messed up the commits trying to rebase, squash and do other git alchemy.
Somebody help :ambulance:

@krwq
I will probably create a separate tidied up PR and close this one.

@omariom, that happened to me several times too. I had to ask @terrajobst to come to my office and rescue me :-)


Doesn't work with Node 4 because of ES6 syntax

This module is transitively used in the CLI. Node v4 does not support parts of the ES6 syntax (like default function arguments).
Can we please start publishing this module in ES5 (and you can keep importing it in ES6 in Etcher if you wish to by having an extra entry point, like etcher-image-writer/es6)

Given that the CLI is the user facing program, I believe transpiling should be done on that side. We can publish every module that we have control of as ES6, but we might eventually hit another wall with other dependencies (there are more and more ES6 dependencies on the wild as far as I've seen). The problem should be solved 100% by transpiling on the CLI.

I can't agree. Honestly I've never seen Node.js programs doing recursive transpilation of their dependencies. I don't even have any good idea how to do this, and it will definitely require more work.

The thing is that enforcing every module in the dependency tree to support older versions is not the solution to the problem. We can mitigate it by converting the ones we control, but we'll have the same problem again sometime in the future.
By reading the resin.io TypeScript spec and the skeleton app, it looks like we're going to publish TypeScript straight away (see how the skeleton project points the main property of package.json to the TypeScript file: https://github.com/resin-io/resin-typescript-skeleton/blob/master/package.json#L6):
{
    ...
    "main": "lib/index.ts",
    "types": "lib/index.d.ts",
    ...
}

The package.json does point the start script to the built code, which implies that only the top level applications will be transpiled. How are we going to deal with the problem in that case?

I don't even have any good idea how to do this, and it will definitely require more work.

You can concatenate the JavaScript and do any transformations there, which is what we do on the Etcher CLI. Something like:
browserify entrypoint.js --node --outfile cli.js

should do it as long as there are no dynamic dependencies (we had an arch call that concluded that Webpack can resolve those).
Keep in mind that concatenation is something that we plan to do for our CLIs in any case (we are planning to move the Etcher CLI build system to Capitano, so we can distribute completely independent binary versions of our CLI, without having to rely on npm), so we should start going that way on the Resin CLI as well.
We rather deal with transpilation on particular projects that having to setup and deal with the whole infrastructure in every module IMHO.

OK

Turns out the only thing preventing this module from running on v4 was default arguments, which in most cases, it was useless. I removed them, so this module should run fine on v4 now.

Check 9.0.3

awesome 👍 . Will do by adding Node v4 tests to the downstream projects