issue on reading majority of tf cards in sd2 with the R36s device

Before submitting your issue or feature request.  DO NOT REQUEST ASSISTANTS FOR PRELOADED IMAGES.  I do not support or condone the use of preloaded ArkOS images.  Preloaded meaning images that come with copyrighted roms preincluded.  Look for support from the creator or supplier of those preloaded images, not from here!  If a ticket is submitted for assistance for such images or if there's an indiciation that a preloaded image is what the support request is for, the issue ticket will be closed with no further response.

This is not the Stock OS that comes with your device, AmberElec, JelOS, or UnOfficialOS.  ArkOS is a different distribution from those systems and will have differing features.  The only somewhat similarity is that they both use EmulationStation as a frontend.  Even with that, the versions of EmulationStation that's used in between ArkOS and these other distributions is different with different capabilities.  If there are features you prefer with the other available distributions, just use those distributions instead.  The choice is yours.

Have you reviewed the Frequently Asked Questions section available for your supported device in the wiki? yes

If your issue is related to being able to run certain emulators or ports, have you reviewed the Emulators and Ports section available at https://github.com/christianhaitian/arkos/wiki/ArkOS-Emulators-and-Ports-information for needed bios files and supported rom extensions? yes

Have you reviewed the known issues section available at https://github.com/christianhaitian/arkos/wiki/Known-issues ?
yes

Describe the Issue (If applicable)
A clear and concise description of what the bug is.
Description:
The s36s handheld encounters an issue when attempting to recognize several TF cards, including popular brands like SanDisk and Lexar, with a capacity equal to or greater than 128GB in the sd2 (additional storage) slot (TF2). Despite the card format type, the kernel appears to be the root cause of this consistent problem.
Details:
Working Scenario: TF cards function seamlessly on sd1 (OS slot) with no issues.
Problematic Scenario: When inserting various TF cards, such as SanDisk and Lexar, with a capacity of 128GB or more into the sd2 (TF2) slot, the system fails to recognize the card.
Kernel Issue: A member on Reddit has conducted a diagnosis (link to findings: Reddit Post) and observed that the system sets the bus speed to be very slow on the TF2 card slot, leading to the recognition problem.
How can the issue be reproduced? (If applicable)
you can try using sandisk,lexor 128gb 256gb 512gb sds and try to initialize it on tf2 slot you will get error that the system does not recognize any disk in the supported formats (fat32, ntfx, exfat, ext3, ext4..)
What device are you using?
r36s
What version of ArkOS are you on? 1222203 i used as suggested the rg351mp image

You can find this during the initial boot process right before the Emulationstation loading screen

Anything else you'd like to include that may help to review this issue or feature request?

That's an issue with the r36s and I don't directly support that device.  A community member by the name of Aeolus has an image specifically built for the R35s and R36s units with various fixes in place for those units. The links for those images are available here:
ArkOS_R35S-R36S_v2.0_12222023 (By Aeolus) https://drive.google.com/file/d/10z7j7IZ7WX3y10ZJBW_a2-agcIe1Dx9m/view?usp=drive_link https://www.mediafire.com/file/da4193t5vsjfsbr/ArkOS_R35S-R36S_v2.0_12222023.img.xz/file
More information about this image and further discussion and further developments related to the R35s/R36s units are available on the Retro Handheld Discord. https://discord.gg/retrohandhelds


Unable to display date as x-axis when using "create_returns_tear_sheet"

Problem Description
I am not able to display the date as x-axis when using "create_returns_tear_sheet". All of the plots can only display their y-labels but not for x-labels (blank there).
Please see the following codes. I used it to generate the plots:

import pandas as pd
import numpy as np
import pyfolio as pf
import matplotlib.pyplot as plt
%matplotlib inline
import warnings
warnings.filterwarnings('ignore')

df = pd.read_excel("index.xlsx")
df = df.fillna(0)

df = df[df['daily ret']!=0]
len(df) # double checked the removal of rows with daily ret as zero is correct

df['Date'] = pd.to_datetime(df['Date'],format='%Y-%m-%d')

df=df[['Date','daily ret']]
df.set_index('Date', inplace=True)
returns = df['daily ret']

pf.create_returns_tear_sheet(returns,
                            positions=None,
                            transactions=None,
                            cone_std=(1.0,1.5,2.0),
                            benchmark_rets=None,
                            bootstrap=False,
                            header_rows=None,
                            return_fig=False)

same here, any solution?

Removing every sharex=ax_rolling_returns from def create_returns_tear_sheet fixed this for me.

I am having the same issue.

You can downgrade matplotlib.
pip install matplotlib==2.2.5
Or patch it as below, by following the wisdom of :
https://stackoverflow.com/questions/51553545/matplotlib-tick-labels-disappeared-after-set-sharex-in-subplots
stock_rets = pf.utils.get_symbol_rets('FB')
fig = pf.create_returns_tear_sheet(stock_rets, return_fig=True)

for ax in fig.axes:
        ax.tick_params(
        axis='x',           # changes apply to the x-axis
        which='both',       # both major and minor ticks are affected
        bottom=True,
        top=False,
        labelbottom=True)    # labels along the bottom edge are on

(tested with matplotlib: 3.4.2)


Send SBOM Status and Error to the back-end

What does this PR do?
This PR sends the SBOM Status and Error to the back-end.

Motivation
Easier error resolution.

Additional Notes
We're release agent-payload v5.0.97

Possible Drawbacks / Trade-offs
A little more network usage I guess.

Describe how to test/QA your changes
Deploy the agent with the following env variables:
- name: DD_SBOM_ENABLED
  value: "true"
- name: DD_CONTAINER_IMAGE_ENABLED
  value: "true"
- name: DD_SBOM_CACHE_ENABLED
  value: "true"
- name: DD_SBOM_CONTAINER_IMAGE_ENABLED
  value: "true"

Make sure agent workload-list -v shows the status of each SBOM. Example below:
----------- SBOM -----------
Status: Failed
Error: unable to marshal report to sbom format, err: analyze error: failed to analyze layer:  : unable to get uncompressed layer sha256:6a4a177e62f374d68e6889ffa22b644db056e1d47ee4085c88408fa1d153871d: failed to get the layer (sha256:6a4a177e62f374d68e6889ffa22b644db056e1d47ee4085c88408fa1d153871d): unable to populate: unable to open: failed to copy the image: content digest sha256:fdb67d8f420a66b89baa7ba03c5428f6b4f49f6d3ef0e81a223f9708020a6b00: not found

and
----------- SBOM -----------
Status: Success
Generated in: 0.00 seconds

In order to test that the back-end receives the correct payload. I guess the easiest choice is to put a log line before adding SBOM.Entity to the queue. Here are some examples:
2023-09-29 09:14:33 UTC | CORE | INFO | (pkg/collector/corechecks/sbom/processor.go:315 in processImageSBOM) | sending sbom type:CONTAINER_IMAGE_LAYERS  id:"docker.io/alidatadog/agent@sha256:9504fff79c3df34b148aaa9f956e7f22823dab7270ffa3b8615d43dcc7e9b00f"  dd_tags:"os_name:linux"  dd_tags:"architecture:arm64"  dd_tags:"image_id:********@sha256:9504fff79c3df34b148aaa9f956e7f22823dab7270ffa3b8615d43dcc7e9b00f"  dd_tags:"image_name:docker.io/alidatadog/agent"  dd_tags:"short_image:agent"  error:"unable to marshal report to sbom format, err: analyze error: failed to analyze layer:  : unable to get uncompressed layer sha256:3dec1221c55441aa2a48beccc6b6e786060e2700e9b87a4e7cd6bc288378c3dd: failed to get the layer (sha256:3dec1221c55441aa2a48beccc6b6e786060e2700e9b87a4e7cd6bc288378c3dd): unable to populate: unable to open: failed to copy the image: failed to get reader: content digest sha256:36289f2b13752e4f0a70bb14bdc67b6917f87e0a3d1ae13c6d6a44a61c94e617: not found"  status:FAILED
2023-09-29 09:14:33 UTC | CORE | INFO | (pkg/collector/corechecks/sbom/processor.go:315 in processImageSBOM) | sending sbom type:CONTAINER_IMAGE_LAYERS  id:"docker.io/alidatadog/agent@sha256:f4cdbd7c1ee54c45d2b5c56aed697ad11626171a2f411a96e8c5389afb194f84"  dd_tags:"os_name:linux"  dd_tags:"architecture:arm64"  dd_tags:"image_id:********@sha256:f4cdbd7c1ee54c45d2b5c56aed697ad11626171a2f411a96e8c5389afb194f84"  dd_tags:"image_name:docker.io/alidatadog/agent"  dd_tags:"short_image:agent"  error:"unable to marshal report to sbom format, err: analyze error: failed to analyze layer:  : unable to get uncompressed layer sha256:3dec1221c55441aa2a48beccc6b6e786060e2700e9b87a4e7cd6bc288378c3dd: failed to get the layer (sha256:3dec1221c55441aa2a48beccc6b6e786060e2700e9b87a4e7cd6bc288378c3dd): unable to populate: unable to open: failed to copy the image: failed to get reader: content digest sha256:0c805487d35572ee58d2b403ab9cfa3b36e3935098245cecfb4069e91bcac106: not found"  status:FAILED

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@AliDatadog
I added few comments that can be handle in a separated pull request.


BUG: Issue converting raven.txt file to simple-seq

Hi there @NickleDave,
I'm running the following on a MAC with crowsetta V 5.0.1
I tried using the following script (suggested here: https://github.com/yardencsGitHub/tweetynet/issues/223) to convert my raven.txt files to simple-seq for use with vak and tweetynet.
import crowsetta
import numpy as np

example = crowsetta.data.get('raven')
raven = crowsetta.formats.bbox.Raven.from_file(example.annot_path, annot_col='Species')
annot = raven.to_annot()
onsets_s = []
offsets_s = []
labels = []
for bbox in annot.bboxes:
    onsets_s.append(bbox.onset)
    offsets_s.append(bbox.offset)
    labels.append(bbox.label)
onsets_s = np.array(onsets_s)
offsets_s = np.array(offsets_s)
labels = np.array(labels)
simpleseq = crowsetta.formats.seq.SimpleSeq(
    onsets_s=onsets_s,
    offsets_s=offsets_s,
    labels=labels,
    annot_path='/dummy/path'
)
simpleseq.to_csv('example-data.csv')

After running this I got:
AttributeError: 'SimpleSeq' object has no attribute 'to_csv'
I adjusted the script slightly (raven = .... , simplest.to_file...) to the following:
import crowsetta
import numpy as np

example = crowsetta.data.get('raven')
raven = crowsetta.formats.bbox.raven.Raven.from_file(example.annot_path, annot_col='Species)
annot = raven.to_annot()
onsets_s = []
offsets_s = []
labels = []
for bbox in annot.bboxes:
    onsets_s.append(bbox.onset)
    offsets_s.append(bbox.offset)
    labels.append(bbox.label)
onsets_s = np.array(onsets_s)
offsets_s = np.array(offsets_s)
labels = np.array(labels)
simpleseq = crowsetta.formats.seq.SimpleSeq(
    onsets_s=onsets_s,
    offsets_s=offsets_s,
    labels=labels,
    annot_path='/Users/training_data'
)

simpleseq.to_file("data.csv")

I have 10 .txt files in my directory (> 15 rows per file) to be written into simple-seq format but the resulting output is the following (this is complete):
onset_s,offset_s,label
154.387792767,154.911598217,EATO
167.526598245,168.17302044,EATO
183.609636834,184.097751553,EATO
250.527480604,251.160710509,EATO
277.88724277,278.480895806,EATO
295.52970757,296.110168316,EATO

I tried adjusting the above code
raven = crowsetta.formats.bbox.**raven**.Raven.from_file(example.annot_path, annot_col='Species)
By changing annot_col to 'Annotation'  - the header for the annotation col in my .txt files. - and received the following output:
(tweetynet) Stephens-MacBook-Pro:HAV_TN_Training stephencooke$ python test.py
Traceback (most recent call last):
  File "/Users/stephencooke/Library/CloudStorage/OneDrive-UniversityofArizona/Tweetynet/HAV_TN_Training/test.py", line 6, in <module>
    raven = crowsetta.formats.bbox.raven.Raven.from_file(example.annot_path, annot_col='Annotations')
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/crowsetta/formats/bbox/raven.py", line 107, in from_file
    df = RavenSchema.validate(df)
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/pandera/api/pandas/model.py", line 306, in validate
    cls.to_schema().validate(
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/pandera/api/pandas/container.py", line 375, in validate
    return self._validate(
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/pandera/api/pandas/container.py", line 404, in _validate
    return self.get_backend(check_obj).validate(
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/pandera/backends/pandas/container.py", line 97, in validate
    error_handler = self.run_checks_and_handle_errors(
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/pandera/backends/pandas/container.py", line 172, in run_checks_and_handle_errors
    error_handler.collect_error(
  File "/Users/stephencooke/miniconda3/envs/tweetynet/lib/python3.9/site-packages/pandera/error_handlers.py", line 38, in collect_error
    raise schema_error from original_exc
pandera.errors.SchemaError: column 'annotation' not in dataframe
   Selection           View  Channel  begin_time_s  end_time_s  low_freq_hz  high_freq_hz Species
0          1  Spectrogram 1        1    154.387793  154.911598       2878.2        4049.0    EATO
1          2  Spectrogram 1        1    167.526598  168.173020       2731.9        3902.7    EATO
2          3  Spectrogram 1        1    183.609637  184.097752       2878.2        3975.8    EATO
3          4  Spectrogram 1        1    250.527481  251.160711       2756.2        3951.4    EATO
4          5  Spectrogram 1        1    277.887243  278.480896       2707.5        3975.8    EATO

I've attached example data here, the python script, and output file. troubleshooting.zip
Another question while we're here: will training the model on simple-seq annotations restrict the predicted annotations to onset - offset borders without including high and low frequency bounds? I'm interested because I was hoping to estimate frequency ranges with the output data. Apologies if I'm misunderstanding how prediction output will be formatted.
Thanks for your help!

Hi @sfcooke96!
Thank you for providing a detailed bug report and the zip with a couple samples to test with. :pray:
I think I might have confused you with my snippet on the other issue.
When you use your data, you'll want to specify the path to those files as the first argument to crowsetta.formats.bbox.Raven.from_file, like so:
crowsetta.formats.bbox.Raven.from_file(
    'troubleshooting/data1.txt'
)

I was able to do this and load the file without issue.
You don't need to specify the annot_col since it has the default name for Raven (the example data we have is from a dataset that uses a different name for their annotations column).
You'll also need to loop over all your files and save each of them with a separate name.
Please try this short script and see if you get separate files, each with the appropriate number of rows.
import pathlib

import crowsetta
import numpy as np

# this is where we get our files from
src_dir = pathlib.Path('./troubleshooting')
# next line: sorted because
# https://www.vice.com/en/article/zmjwda/a-code-glitch-may-have-caused-errors-in-more-than-100-published-studies
src_txt_files = sorted(src_dir.glob('*.txt'))

# this is where we save the files (so we don't overwrite the originals)
dst_dir = pathlib.Path('./annots-simple-seq')
dst_dir.mkdir(exist_ok=True)

# to save ourselves from a typo
assert dst_dir != src_dir

for txt_file in src_txt_files:
    print(
        f"Converting Raven file to simple-seq format: {txt_file}"
    )
    annot = crowsetta.formats.bbox.Raven.from_file(
        txt_file
    ).to_annot()

    onsets_s = []
    offsets_s = []
    labels = []
    for bbox in annot.bboxes:
        onsets_s.append(bbox.onset)
        offsets_s.append(bbox.offset)
        labels.append(bbox.label)
    onsets_s = np.array(onsets_s)
    offsets_s = np.array(offsets_s)
    labels = np.array(labels)
    simpleseq = crowsetta.formats.seq.SimpleSeq(
        onsets_s=onsets_s,
        offsets_s=offsets_s,
        labels=labels,
        annot_path='/dummy/path/doesnt/matter/here'
    )
    dst_txt_file = dst_dir / txt_file.name
    print(
        f"Saving converted simple-seq file: {dst_txt_file}"
    )
    simpleseq.to_file(dst_txt_file)

Just let me know if you have any questions about what this is doing!
Happy to share the ~five things I've managed to learn about Python and just keep recycling :stuck_out_tongue_winking_eye:

Another question while we're here

Re: the TweetyNet model, please see my reply on the issue on the TweetyNet repo: https://github.com/yardencsGitHub/tweetynet/issues/223#issuecomment-1905024896

@NickleDave, thank you - this solution seems to have worked! On to prepping, training, and predicting.
Thanks a lot for your active support here! 🙏

Of course, glad to hear it's working @sfcooke96!
I will go ahead and close this issue.


Reduced Endurance Limitation not working

I noticed that powers that have the Reduced Endurance limitation applied and it set to cost 0 END it still cost END when using.

Hmm, seems to be working fine.

@sevrick send pic of the attack and/or the HDC file.

So I guess what is really happening is a zombie I made has 0 END and when making an attack with this:

The zombie takes stun damage because he has no END, which is normal game rules but he shouldn't take stun damage if the attack costs 0 END.

Yup, I see what is going on here.  I can fix that.

Looks like the automation is following rules as written: A character who has Reduced Endurance (0 END) on his Hand-To-Hand Attack still has to pay END for the STR he uses with it.  You aligned with that or am I missing something?

Added prompt to confirm actor wants to USE STUN FOR ENDURANCE

Added support for STR with REDUCEDEND.


⚠ Fetchers has degraded performance

In ddc630d, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 438 ms

Resolved: Fetchers performance has improved in 28ca96d.


Update phone_recognizer.py

Change Description
When only one country code is used, such as CN, supported_entities will be parsed as "C" and "N", so DEFAULT_SUPPORTED_ COUNTRY_ CODE  should be array
Issue reference
This PR fixes issue #XX
Checklist

[ ] I have reviewed the contribution guidelines
[ ] I have signed the CLA
[ ] My code includes unit tests
[ ] All unit tests and lint checks pass locally
[ ] My PR contains documentation updates / additions if required

We can like this DEFAULT_SUPPORTED_COUNTRY_CODES = ('CN',) , But I think it's better to change it to array

/azp run

Hi @jiankebe, thanks for your PR! Could you please clarify why the default tuple should be changed?
In case a user would want a different set of country codes, they should be able to pass them through the init function of the PHONE_RECOGNIZER without having to change the default one:
from presidio_analyzer import AnalyzerEngine
from presidio_analyzer.predefined_recognizers import PhoneRecognizer

# Create a new recognizer for CN numbers as CN is not a default region supported by the PhoneRecognizer
cn_phone_recognizer = PhoneRecognizer(supported_entities=["CN_PHONE_NUMBER"])
analyzer = AnalyzerEngine()
analyzer.registry.add_recognizer(cn_phone_recognizer)

res = analyzer.analyze(text="My number in Beijing is 10 6552 9988", language="en")
print(res)

Which results in
[type: CN_PHONE_NUMBER, start: 24, end: 36, score: 0.95,  type: LOCATION, start: 13, end: 20, score: 0.85]

That was exactly the intention, thanks @omri374.
However, @jiankebe, if you can explain the motivation for transforming into a list, I guess that it's not that of a drastic change to push.


New Requirement: Store expanded state in cookie

Please add a new feature to store tree node expanded/collapsed state in cookie, like jquery-tree does.

I dont think the way this issue is written is okay. You write it like a task to some developer that works for you and that is not how open source works. You should maybe ask: 'Could someone elaborate on how can we implement a cookie based store' or 'is something like that planned or possible'.

@denkomanceski is right.
Also, this is duplicate of #111 - closing


Website update

Favicon change color on systems with dark mode on
Respect user color scheme preference, but the color scheme switch can still be used normally
Fix a bug in the table of contents

@sebmck this fix the issue with the favicon. Now it's using svg (but there's a png fallback).
I can't test it on safari, so i'm waiting on you before merge it!

Looks great! Thank you!


[REG2.068.1] Issue 15150 - Public selective import causes conflict

https://issues.dlang.org/show_bug.cgi?id=15150
Fix the divergence between EnumMember symbol and its representation VarDeclaration.
See also my detailed comment in bugzilla: https://issues.dlang.org/show_bug.cgi?id=15150#c1

Thx! This is blocking https://github.com/D-Programming-Language/druntime/pull/1402

What's up with the documentation change?
http://dtest.thecybershadow.net/results/700fcb253b69cbff4f313eca0193dea82fdb48c8/9e1e61d6e9d7713f8d64def9c468c0771bb6efff/

I did fix this by removing the EnumMember code, but your fix is more conservative.
In any case please merge the test case https://github.com/9rnsr/dmd/pull/4.

Auto-merge toggled on

@MartinNowak Oh, I was overlooked the change. To keep compatibility of ddoc generation, I fixed doc.d and corresponding test case.

@MartinNowak Thanks!

@MartinNowak Could you please get this into master, as it's blocking https://github.com/D-Programming-Language/druntime/pull/1402 ?

@MartinNowak Could you please get this into master, as it's blocking D-Programming-Language/druntime#1402 ?

Just make a merge_stable PR, https://github.com/D-Programming-Language/dmd/pull/5167.


Type handlers for Threeten-Extra

ThreeTen-Extra provides additional date-time classes that complement those in Java SE 8.
I have found most of these classes very useful. It gives your entities, domain objects, whatever you call them, more semantic properties. For example you can store an amount of days in a Days class instead of a plain int.
New Type Handlers
This pull request adds type handlers for the following classes from ThreeTen-Extra:

AmPm
DayOfMonth
DayOfYear
Days
Hours
Minutes
Months
Weeks
YearQuarter
Years
YearWeek
Quarter

There is a corresponding unit test with each class. I admit to a lot of copy&pasterino.
Implementation notes
Most classes of java.time have some matching database datatype: java.time.LocalTime to java.sql.Time. Unfortunately this is not possible with every class from ThreeTen-Extra.
The classes AmPm and Quarter are enums. Therefore the database column are expected to be some CHAR or VARCHAR type. The value ist stored as the name() of the enum.  Can't speak for all databases but most do have some kind of enum datatype that makes storage efficient.
The classes YearQuarter and YearWeek are expected to be stored in CHAR / VARCHAR columns as well. For example: '2017-Q1' and '2017-W3'. Given that the values need some special format there can a parsing exception if some other application writes data to that column.  For example '2017Q1' wouldn't be parseable by YearQuarter.parse. The type handler would throw an DateTimeException in that case. I think this is totally fine, but we could also wrap it in some MyBatis specific exception. Not sure what the general approach to exceptions in type handlers is.
Optional dependency
Since not everyone is using threeten-extra, or doesn't want to use it, I added it via an optional dependency. Not nice to force some compile time dependency. Therefore using these typehandlers requires threeten.extra in your pom.xml.

I am interested this.
@harawata @emacarron @hazendaz
What do you think ?

I think it's better to publish them on a different repo.
@raupachz ,
Sorry for the trouble, but could you send a new PR to the following new repo, please?
https://github.com/mybatis/typehandlers-threeten-extra
And thank you for your work!

@raupachz
I've close this PR because created the mybatis/typehandlers-threeten-extra#1.
Could you submit a new PR on mybatis/typehandlers-threeten-extra repo ?
Thanks.

Of course. No problem. 👍🏼
Sent from my iPhone

On 3 Mar 2017, at 17:58, Kazuki Shimizu<EMAIL_ADDRESS>wrote:
Closed #33.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Oh, and let's use a different package for these.
Something like org.mybatis.typehandlers.threetenextra.


 Add sound settings to disable Cave Sounds and Minecart Sounds

Self-explanatory in the title. Legacy allowed players to disable Minecart sounds and Cave sounds from playing.

Added in 1.3


Suppress some warning

See above: MSVC doesn't like _Pragma, and gcc is very warning happy.

@thepowersgang I may drop the second commit if you would like the first one.
And wrapping all code by #prgma ... #pragma seems like a wrong idea.
Do you agree?

The fixes seem acceptable, it's just the pragma annotations that are difficult.


Disable Network "Automatic selection" on VM template instantiation screen

Allow administrators to remove Network "Automatic selection" on Sunstone's VM template instantiation screen:

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

@tinova PR to approve:

ONE: https://github.com/OpenNebula/one/pull/4723
Docs: https://github.com/OpenNebula/docs/pull/1121

test pending

PRs to merge:

dev: OpenNebula/development/pull/1041


Add library module ProGuard configuration file

It seems that instead of manually adding necessary for Flutter WebRTC ProGuard rules (as was suggested in this comment), they could be added automatically with library module ProGuard configuration file (and as result fix #205).

LGTM


Counter must be 1 to follow spec.

The spec on the master password website mistakenly declared '0' as the default counter value. As per this issue it is confirmed that none of the algorithms implemented in the official applications use 0. While It's annoying to have to change passwords, I think it is better to update to the actual behaviour of master password applications. Fixes issue #5 if merged.

Thank you!
It won't annoy anyone already using freepass, because the counter is always stored in the vault file. No one's passwords will suddenly change :-)


enh/99-arena-map-loctree-calcs

The checks for a robot being on a block or cache should be done using the added
loctrees rather than the linear scans they currently use. The short circuiting
thing I added won't really be much of a short circuit anymore, so can probably
be removed (which will require a ton of FSM updates...).

The short circuit might still be useful for large LOS.

The short circuit might still be useful for large LOS.


Support StatefulSets in runtimeobjects.go

Ref. https://github.com/kubernetes/perf-tests/issues/704

/lgtm

/lgtm


Change map engine to OpenLayer

Pleas change the map engine from GeoJS to OpenLayer.

@smadha great work.


Set min sdk to 21 (First Lollipop)

Tested with Emulator, I see no problems. Views look good too.

Did you the backup feature?

No I didn't :(


Add late binding feature?

It would be great if vue have this feature. My team and I once encountered a difficulty, we had this dynamic form and we want to bind this with a model. Unfortunately we did not find any solutions and we ended up using jquery to pull all the data from the input fields.

Please be more specific on what you mean by late binding, and provide desired usage code sample. This is too vague to be a feature request.

Pulling data from the input fields can be achieved with vanilla JS. Once you have access to the form element you can just access any form variable using the name attribute for each field. You can even add a ref to the element to have a fast reference on your Vue instance (v-el for Vue 1)

@posva I don't want to pull the data from the field, what I really want is pull the data from the model. What I wrote above is wrong sorry.
@yyx990803 thank you for the response but I already found a way to get data from dynamic model. It can be accomplised via vm.$compile.


Refactor WindowService and clean up context window length tags

The context window length system is too complicated (it requires setting a tag on the model, defining a new window service with the window context length, and instantiating the window service for the model). The sequence length could possibly be set on the model itself.

General plan:

Merge a unit test that pins the constant mapping of model name to sequence length.
For each model in models.py, add the sequence length.
Change fits_within_context_window and truncate_from_right to take in the sequence length as a parameter.
Change InContextLearningAdapter to get the sequence length from the model and pass in the sequence length into fits_within_context_window and truncate_from_right. The model can be found using the model name in self.adapter_spec.model.
Fix up all other unit tests.
Remove the unit test that we added in 1.

@JosselinSomervilleRoberts this is the model sequence length refactor that I was suggesting last week.
cc @percyliang

This sounds great!

This is done - the sequence length and tokenizer are now set in model_deployments.yaml


Add a custom wrapper around #perform

TL;DR This PR adds a wrapper method around the #perform method. This allows us to wrap the #perform method within code blocks that would help with measuring the performance in terms of time taken or the number of sql queries executed or anything else
Today, we have to override the #resolve method as demonstrated by the example below.
class BaseLoader < GraphQL::Batch::Loader
    def resolve
      return if resolved?
      load_keys = queue
      @queue = nil

      instrument_sql_requests do
        perform(load_keys)
      end

      check_for_broken_promises(load_keys)
    rescue => err
      reject_pending_promises(load_keys, err)
    end

    def instrument_sql_requests
      SQLCounter.run { yield }
    end
end

With the proposed changes, the #resolve method does not need to be overridden and a system can call multiple wrappers if required.
class BaseLoader < GraphQL::Batch::Loader
  def custom_wrapper
    instrument_sql_queries do
      run_tracer do
        yield
      end
    end
  end

  def instrument_sql_queries
    SQLCounter.run { super }
  end

  def run_tracer
    CustomTracer.run { super }
  end
end

How did this come up?
Today we override the #resolve method. But we were looking to add tracing as well. While the tracing can be added within the #resolve method, it'd be nicer to add a shared implementation for this gem within Opentelemetry (tracking issue).
This is a non breaking change and should not cause any issues. This PR also releases v0.5.3

Code looks fine but I'm not loving the name. Couple ideas:

around_perform - matches up with Rails callback conventions
custom_perform
instrument_perform - if this is the main use case, we could name it more explicitly?

Thanks!, I've renamed to around_perform.


undefined: myMethod using templ

Following the templ documentation I wanted to try wgo to see about the automatic page reloading that air doesn't have. Builtin templ HMR seems quite slow. I am running the command they provided, after installing wgo:
wgo -file=.go -file=.templ -xfile=_templ.go templ generate :: go run appname.go

I have a appname.go file, and adjacent to this, a base.templ file. They both live in the same package main.
When running the above I'm getting the following error:
./appname.go:8:18: undefined: hello (hello is a function in the templ file)
I don't seem to get this error when using templ's built in HMR, or with Air.
Please let me know if this is something on my end I could be doing wrong!
Thanks

Ok um actually wgo doesn't have the automatic page reloading either. It's pretty much identical to air, except wgo doesn't need a config file to run. Automatic page reload is only available through templ and the --proxy flag, by injecting JavaScript into the webpage that it automatically reloads the page when files change.
But regarding the error, go run actually takes in a list of files to compile. go run appname.go compiles only appname.go, so a function defined in another file (even if they're in the same package) would turn up as undefined. You can manually include all files with go run appname.go base_templ.go, but a better way would be to invoke the package directly with go run . (https://stackoverflow.com/a/52721104).

Yikes, dead simple. My bad, appreciate the quick response.


FEATURE: Collapse non-oneboxed gifs and images in general

Just another type of image to collapse. The difference is that this one is cooked different from the rest, like this

Some minor comments but in general the PR looks really good to me :+1:


local client variables

sometimes local variables are needed on the client side, so that their changes do not affect other clients. It is suggested that the variable should be considered "local", its name should begin with the prefix " loc_"

The idea is interesting, but I changed the prefix to "local_"


Item examples Create and Read have the same documentation link

In the Item Examples table the Create an item API reference incorrectly links to the ReadItemAsync method
Create an item	Container.CreateItemAsync
Read an item by ID	container.ReadItemAsync
Are both href="/en-us/dotnet/api/microsoft.azure.cosmos.container.readitemasync?view=azure-dotnet"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c807a612-35d4-32e4-4d97-414245ca8e43
Version Independent ID: 1a596800-e588-6e84-068a-8f962fedae26
Content: Azure Cosmos DB: .NET (Microsoft.Azure.Cosmos) examples for the SQL API
Content Source: articles/cosmos-db/sql-api-dotnet-v3sdk-samples.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @SnehaGunda
Microsoft Alias: sngun

@Camios Thank you for pointing this out. This is being fixed and an update will be published shortly.

We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


DDP script hangs forever if one child process dies.

🐛 Bug
When using multiple gpus with accelerator=ddp, if one child processes throws an error, the main script hangs indefinitely and never terminates. The error does appear in the stdout but does not cause the main script to terminate as it should.
Note, that this bug does not appear if one uses accelerator=ddp_spawn.
To Reproduce
Below a simple .py file that demonstrates the error. This file uses the example model provided in the docs but forces the child process on local_rank 1 to throw an error in the validation step. When running this script on 2 gpus, this hangs forever (despite the errror appearing in the log).
import os

import torch
from torch import nn
from torch.nn import functional as F
from torch.utils.data import DataLoader, random_split
from torchvision.datasets import MNIST
from torchvision import transforms
import pytorch_lightning as pl
from pytorch_lightning.metrics.functional import accuracy
from pl_bolts.datasets import DummyDataset

train = DummyDataset((1, 28, 28), (1,))
train = DataLoader(train, batch_size=32)
val = DummyDataset((1, 28, 28), (1,))
val = DataLoader(val, batch_size=32)
test = DummyDataset((1, 28, 28), (1,))
test = DataLoader(test, batch_size=32)

class LitAutoEncoder(pl.LightningModule):

    def __init__(self):
        super().__init__()
        self.encoder = nn.Sequential(nn.Linear(28 * 28, 128), nn.ReLU(), nn.Linear(128, 3))
        self.decoder = nn.Sequential(nn.Linear(3, 128), nn.ReLU(), nn.Linear(128, 28 * 28))

    def training_step(self, batch, batch_idx):
        x, y = batch
        x = x.view(x.size(0), -1)
        z = self.encoder(x)
        x_hat = self.decoder(z)
        loss = F.mse_loss(x_hat, x)
        self.log('train_loss', loss)
        return loss

    def validation_step(self, batch, batch_idx):
        # --------------------------
        # CODE MODIFICATION FOR BUG REPORT HERE
        if self.local_rank == 1:
            raise ValueError
        # --------------------------

        x, y = batch
        x = x.view(x.size(0), -1)
        z = self.encoder(x)
        x_hat = self.decoder(z)
        loss = F.mse_loss(x_hat, x)
        self.log('val_loss', loss)

    def test_step(self, batch, batch_idx):
        x, y = batch
        x = x.view(x.size(0), -1)
        z = self.encoder(x)
        x_hat = self.decoder(z)
        loss = F.mse_loss(x_hat, x)
        self.log('test_loss', loss)

    def configure_optimizers(self):
        optimizer = torch.optim.Adam(self.parameters(), lr=1e-3)
        return optimizer

if __name__ == "__main__":
    # init model
    ae = LitAutoEncoder()

    # Initialize a trainer
    trainer = pl.Trainer(gpus=2, max_epochs=3, progress_bar_refresh_rate=20, accelerator="ddp")

    # Train the model ⚡
    trainer.fit(ae, train, val)

Note that when using accelerator = ddp_spawn on the other hand fails correctly.
Expected behavior
If one child processes fails, the main script should fail and exit, not run forever.
Environment

PyTorch Version (e.g., 1.0): 1.8.0
OS (e.g., Linux): Linux
Python version: 3.7.3
PL version: 1.3.7
GPU models and configuration: 2 GPUS

Hi @melanibe, thanks for the issue.
I'll look into it, but depending on how the child process fails, there may not be much we can do.
Let me quickly explain why and also why it works with spawn:
When using spawn, we actually use python's multiprocessing to spawn the new processes, that means they are connected and there is a communication broadcast. However, this comes with some other limitations. This is why with plain ddp, we circumvent this by relying on an OS-call to the interpreter to run the same script again. That however, has the disadvantage that python does not know, that these processes are connected to each other (i.e. that the one is the other's child).

Dear @melanibe @justusschock,
I am working on a mechanism to prevent this behaviour and it will kill the processes if it detects a
Here is the code associated with it: https://github.com/PyTorchLightning/pytorch-lightning/blob/3da64e5336c19bd9cdff51d6e2924c47dbcc54b0/pytorch_lightning/trainer/trainer.py#L1010.
@justusschock I tried using signal to emulate a keyboardInterrupt and enable the code to keep going, but it seems to work only 1/10. Killing seemed the only stable option.
Best,
T.C

Hi there! According to the changelog, this issue should have been fixed in 1.3.8. However, even after the upgrade the bug repro above still fails. Is there any plans to address this problem further?


Enforce Maven Dependency Checks on some more modules

Fixed problems reported by the maven dependency plugin in the following modules:

publication-service-youtube-v3
admin-ui
search

Tested the changes using the method described by @lkiesow in the comments below.

[x] have a concise title
[x] this pr works towards closing #1893
[x] be against the correct branch (features can only go into develop)
[x] include migration scripts and documentation, if appropriate
[x] pass automated testing
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits
[x] have appropriate tags applied

Test! (I have to figure out how to do that)

For a quick test, the following should be sufficient:
% cd docs/scripts/devel-dependency-containers/
# the next command will give you all necessary runtime dependencies (search index & message broker)
# alternatively, use  docker-compose up -d  if you prefer Docker
% podman-compose up -d
% cd ../../../build/opencast-dist-develop-9-SNAPSHOT/
% ./bin/start-opencast
# wait a few seconds until the logs have calmed down
# Go to http://localhost:8080
# Use “add event” to upload a video
# If it processes successfully, everything should be fine

We can run a few more tests as part of the review if necessary

Thanks for the instructions @lkiesow! The publication-service-youtube-v3 is finished. Compilation takes ages on my laptop, so testing and going back to fix problems is quite slow. I will do the admin-ui module next.

Compilation takes ages on my laptop, so testing and going back to fix problems is quite slow.

Then here is another tip: If you have built it already once and just modified one module, you can just compile that module ans assembly the distribution again. Basically:
cd modules/admin-ui
mvn clean install -Pdev
cd ../../assemblies/
mvn clean install -Pdev

If you don't need the unit tests, you can also speed things up by adding -DskipTests to your mvn command.
There are a number of variation on this which work better or worse in different scenarios but this is the basic one and already speeds things up quite a bit ;-)

@lkiesow Thanks a lot :heart: This is some next-level maven configuration ;) Good thing we have travis to point out these failing tests, trying to fix them atm

Patch looks hood → merged.
Thanks again for the help.


Add docusaurus

#133 This PR adds Docusaurus v3.

@mimiflynn, FYI

@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge?

@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge?

Is the intent just to get the docs project in the build, as obviously the docs themselves are missing other than the front page? If so the setup looks fine to me, but I can't merge as I don't have write access to the repo. Which raises the question should we be adding CODEOWNERS into this repo and broadening the maintainer list? @maoo / @DovOps

@DovOps @rocketstack-matt - could you please review this PR, so we can move forward with the merge?

Is the intent just to get the docs project in the build, as obviously the docs themselves are missing other than the front page? If so the setup looks fine to me, but I can't merge as I don't have write access to the repo. Which raises the question should we be adding CODEOWNERS into this repo and broadening the maintainer list? @maoo / @DovOps

Good points. Here's my proposal:

Make Matt a TraderX Maintainer (@DovOps - please lmk if you agree and I'll go ahead with permission changes)
Matt raises Pull Request around CODEOWNERS
Matt raises an issue to port documentation from github READMEs to Docusaurus (and update links into other collaterals); this issue could be a Good First Issue

Thoughts?

@maoo  I suggest we merge this - good with perm changes.  And we can make additional changes once this is properly in the build


Readme - travis: consider php version in cache filename

refs #1649

:-1:
Travis cache is not shared between envs.

I thought it is shared between envs, but not between branches.
But it seems, you are right. One cache archive per branch/env.


Saved projects null state

What
Empty state for save projects has been updated w/ heart animation.
See 👀

TODO ⏰

[x] confirm animation w/ nneka
[x] confirm final copy

@Scollaco g2g?


A lot of blocks doesnt work.

All ore blocks doesnt work with break or smelt. a ton of other blocks too doesnt work.
no error in chat, no console. anything, just dont show anything.
I've sent a lot of print in your discord if you wanna see.
and block smooth_stone that the usage is smooth_stone-8 doesnt work too, and if you try put the original name, it trow exeception in console and "income NaN xp NaN" etc in mc.
some of the conversation with mont
here https://cdn.discordapp.com/attachments/526402919826849804/692347409379885066/unknown.png
my job config, the comment line are some of the block I've test and doesnt work, like the iron ore = iron bars
I wont test every block because its not my job (I've test 10/15 diffrente blocks with the original name and the usage nem ~if they are dif~), but cleary theres more block with the same issue.
https://hastebin.com/bijojemafu.bash log

Its not your job to test all blocks, but it would be yours to atleast provide server version... Block names have changed over the years and it might depend on your server version. Next, would be nice to actually have your jobCongif file or atleast a particular job just to be on same page and have same exact example what dint worked for you so we can test at our end.
And last thing, there no such thing as smooth_stone-8, what this should even represent? Slab? If so then use smooth_stone_slab just like https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Material.html lists them. If material which is listed at this page doesnt work for you, then report it.

Heres de file
jobconfig.txt
about the smooth_stone-8 is what mont said to use with /jobs blockinfo, lol. Theres 2 names with blockinfo the original name withou the -8 and the usage with -8


⚠ Turnos 24x7 has degraded performance

In e4b15db, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3519 ms

Resolved: Turnos 24x7 performance has improved in b2f02c6.


loader.Load and chartutil.SaveDir is not round-trippable

Using helm as a library and the CLI (both with v3.2.0)
Output of kubectl version: N/A
Cloud Provider/Platform (AKS, GKE, Minikube etc.): N/A
Question:
I have a function that loads a chart with loader.Load and then immediately calls SaveDir, the intent being to gracefully handle source chart directories or archives, verifying the source is a chart, and always saving the chart as a directory in a separate location.
func createChartFromDisk(destDir, source string) (*chart.Chart, error) {
	chart, err := loader.Load(source)
	if err != nil {
		return nil, err
	}

	// Save it into our project's helm-charts directory.
	if err := chartutil.SaveDir(chart, destDir); err != nil {
		return nil, err
	}
	return chart, nil
}

This generally works as intended, but I've stumbled on one case where this fails.
Consider a source chart that:

Has a subchart directory, e.g. ./charts/foobar
In Chart.yaml, declares a dependency on foobar without listing a repository.

Running helm dep update and helm dep build both work when run in the source chart, and the output shows:

Dependency foobar did not declare a repository. Assuming it exists in the charts directory

However, after running the above function on the chart, the resulting dest chart directory no longer has an exploded subchart. Instead, it has ./charts/foobar-0.1.0.tgz.
Running helm dep update and helm dep build fail when run in the dest chart, and the output shows:

Error: directory charts/mysql not found

It seems chartutil.SaveDir tars the subcharts when saving into a directory, whereas chartutil.Save seems to leave the subcharts untar-ed when saving into the parent chart's archive.
Is this discrepancy intentional?
Can chartutil.SaveDir be changed (or would it be reasonable to implement a new function alongside SaveDir) to save a chart without tgz'ing the subcharts?

If the subchart ./charts/foobar already exists on disk, do you need to be running helm dep update / helm dep build?

Good question. The createChartFromDisk function in my above comment is used on arbitrary charts based on input from a user, so we run the equivalent of helm dependency build as the very next step to ensure that the ./charts directory is populated.

This patch resolves my issue:
diff --git a/pkg/chartutil/save.go b/pkg/chartutil/save.go
index be5d151d..afd76547 100644
--- a/pkg/chartutil/save.go
+++ b/pkg/chartutil/save.go
@@ -81,7 +81,7 @@ func SaveDir(c *chart.Chart, dest string) error {
        base := filepath.Join(outdir, ChartsDir)
        for _, dep := range c.Dependencies() {
                // Here, we write each dependency as a tar file.
-               if _, err := Save(dep, base); err != nil {
+               if err := SaveDir(dep, base); err != nil {
                        return errors.Wrapf(err, "saving %s", dep.ChartFullPath())
                }
        }

I assume this would be considered a breaking change though, since consumers may be depending on the fact that SaveDir() saves dependent charts by tgz-ing them.
Alternative solutions could be to:

Add a new SaveDirRecursive() function alongside
Update the dependency build and/or dependency update logic to understand that a subchart can be a directory OR a tgz file.

Perhaps a better alternative would be to update pkg/downloader/manager.go to handle both chart directories and packages.
It seems like making loader.Load and chartutil.SaveDir fully round-trippable would require storing some information about how each chart dependency was packaged when we're loading it (i.e. was it a tgz file or a directory).

Here's another situation using just the Helm CLI and a feasible user workflow that trips this same issue:
#!/bin/sh
set -e

# Create chart and add remote dependency
helm create my-chart
cd my-chart
cat <<EOF >> Chart.yaml
dependencies:
- name: mysql
  version: 1.6.3
  repository: https://kubernetes-charts.storage.googleapis.com
EOF

# Update dependencies. This populates ./charts/mysql-1.6.3.tgz
helm dep update

# Remove repository from dependency, because I want to
# maintain this locally from now on.
sed -i '/kubernetes-charts.storage.googleapis.com/d' Chart.yaml

# Template the chart. Everything still looks okay! Helm loads
# the mysql subchart and templates it just fine as a .tgz file.
helm template .

# Update deps again. Now this complains of a missing mysql
# directory, even though I never had one and everything else
# seems to work without it. :(
helm dep update

I think this is still an issue. Just want to comment to make sure this isn't automatically closed.
@jdolitsky any further thoughts on this?

@joelanford sorry, I dont have more to add here. If one of your suggestions to modify pkg/downloader/manager.go does not break unit tests, I think that would be alright.
Since I'm not seeing others with this issue, wondering if the script you provided might be made more general and packaged as a Helm plugin vs. fixing in Helm core?


Fix create_line_reference for options already enconded to utf-8

Issue #1868
Just remove the utf-8 encoding done in create_line_reference when adding a Product to Basket with Options already encoded to utf-8.
Unit test provided.

Sorry! Forgot python3 bytes encoding

Thanks!


MM-24590: fix roles check on leave

Summary
As part of https://github.com/mattermost/mattermost-webapp/pull/5337, a check was added to avoid showing createPost until after channel roles are loaded. Unfortunately, when leaving a channel, the state is such that the channel exists but the channel membership does not, resulting in attempting to dereference undefined.
Fix the check not to assume channel memberships exist, and add an e2e test for leaving the channel via the header menu.
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-24590

@lieut-data I am not sure if this issue is related to this fix, but when I am trying to close a Group Message, it does not works as shown in this GIF. Can you please confirm if this is a different issue?

@srkgupta, I seem to be able to reproduce that in master as well. I've bisected the cause of that to https://mattermost.atlassian.net/browse/MM-23065. Would you be open to filing a separate ticket to track?

Thanks for the confirmation @lieut-data. I found a similar issue already being reported on 5.23.
https://mattermost.atlassian.net/browse/MM-24506


Deprecating/Removing browser methods that can only search by 'name'

The following methods:
browser.fill
browser.type
browser.choose
browser.check
browser.uncheck

Have analogous methods at the Element level. However, the browser level versions can only search by name. Any attempt to make them more flexible would result in code of no less complexity than calling browser.find_by_x. ie:
browser.check('my-checkbox', finder='id')
browser.find_by_id('my-checkbox').check()

Removing them would simplify everything by having only one way to interact with the API.

Fixed by #933


Compiler warnings in settings module in Zephyr 1.14

@nvlsianpu
We are getting a number of Compiler Warnings when building Zephyr 1.14 (See below).
The variable rc is not initialized in these functions and could potentially get returned without being set to a value. In actual fact it may not be possible for this to happen due to the values passed into these functions being correct, but the Compiler cannot determine this, and it would be safer to actively prevent this possibility in the functions themselves.
Can you please advise on the best way to correct these warnings?
It seems that simply initializing the rc variables to an invalid value when they are declared would achieve this - do you agree?
Regards,
Declan Traill
Setec Pty Ltd
[50/254] Building C object zephyr/CMakeFiles/zephyr.dir/subsys/settings/src/settings_store.c.obj
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_store.c: In function 'settings_cmp':
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_store.c:113:9: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
return rc;
^~
[52/254] Building C object zephyr/CMakeFiles/zephyr.dir/subsys/settings/src/settings_line.c.obj
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_line.c: In function 'settings_line_raw_read_until':
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_line.c:272:19: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
return (rc) ? 0 : 1;
~~~~~~~^
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_line.c: In function 'settings_entry_copy':
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_line.c:444:9: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
return rc;
^~
[55/254] Building C object zephyr/CMakeFiles/zephyr.dir/subsys/settings/src/settings_fcb.c.obj
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_fcb.c: In function 'settings_fcb_save':
C:/Users/declan.traill/RVMN101/zephyr/subsys/settings/src/settings_fcb.c:270:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (rc) {
^

@DeclanTraill do we get the same warnings in master?

@DeclanTraill do we get the same warnings in master?

Looking at master, some of the code has changed but some still have the compiler warning issue.
Also, we noticed that the warnings seem to only happen in a Debug optimized build (not a Release build).

Thanks! If you see warnings in master, pls, could you open a separate issue?

Was fixed in #16078


compilers using pipes.quote() == not Windows compatible. breaks LESSc

In bug #335, a call to quote() was added to better handle variety of filenames. It turns out that quote() is not windows compatible and is not intended to be (neither the shlex version nor the pipes version).
quote() adds single quote characters, windows requires double quotes as single quotes have no special meaning (to windows it's just an apostrophe, and apostrophes are ok in windows filenames).
For me, pipeline is adding single quotes everywhere it calls lessc. This is breaking lessc, which does not handle the single quotes properly. It tries to add the current working directory to the quoted filename and comes up with a brand new filename that is not valid.
To me, things would be much simpler if you called lessc using Popen in 'not shell' mode. Pass in the name of the executable, pass in the arguments as an array. Dont try to quote anything. dont turn the whole thing into one long command string. Is there a reason it was not implemented this way?
I have already been working with lessc. They merged a patch for me which "fixes" the single quote issue. But now we are removing it because it breaks to deviate from the windows specs in this way.
I can submit a PR, just wanted to get feedback first if possible.
wonder if this is related to issue #368 ...

I am getting this same issue and was just about to try and figure out a resolution myself. If you have one I recommend setting a pull request and I can help test as well. Otherwise, I can assist in resolving this issue if needed.

Yeah, I played around with solutions a while back. Wound up rewriting
things so that lessc, et al no longer would execute in shell mode.
Eventually figured out that this is not ideal because those guys actually
tend to be shell scripts and everything's just a heck of a lot easier if we
execute in shell mode.
Backing that change out, I still did have a solution that removed the
quoting. I will get that pushed as a PR, but probably can't get to that
today.
On Wed, Apr 15, 2015 at 12:53 AM, dwatkinsweb<EMAIL_ADDRESS>wrote:

I am getting this same issue and was just about to try and figure out a
resolution myself. If you have one I recommend setting a pull request and I
can help test as well. Otherwise, I can assist in resolving this issue if
needed.
—
Reply to this email directly or view it on GitHub
https://github.com/cyberdelia/django-pipeline/issues/444#issuecomment-93187286
.


Incoming JSQLocationMediaItem setting in data model

My message model sets the location (incoming messages )in a category of that message model. This category implements JSQMessageData protocol. I understand that setting locations requires reloading the collection view upon completion, but how can I do that while I am setting the location within the category? Any suggestions?
(currently the when the incoming data has a locations, location cell is loaded but with loading indicator is always on, I have no problem with outgoing message because they take place within the viewControlled and I can easily reload the collection data there.
This is how am I setting the location in the category:
 -(id<JSQMessageMediaData>) media{

   CLLocation *ferryBuildingInSF = [[CLLocation alloc] initWithLatitude:37.795313      longitude:-122.393757];

  JSQLocationMediaItem *locationItem = [[JSQLocationMediaItem alloc] init];
  [locationItem setLocation:ferryBuildingInSF withCompletionHandler:nil];

 return locationItem;

}
I tried setting the incoming location data in messageDataForItemAtIndexPath method, and reloading collection view upon completion, but that leads to infinite loop.
Here are more details about the message model, it has id, type, body and user. The message types are 3: text, date and location. If the type of the message is either text or date, the message is not media message and the data is handled in the text method. If the message type is location, media method mentioned above is called.

Hey @HalahSalih - the object that sets the location on the model object can have a weak reference to the collection view and reload when necessary.
there are some examples of this in the demo project:

send a location message (tap the :paperclip: )
then tap the ••• to simulate receiving a message (this copies the last outgoing message for the new incoming one)

Hi HalahSalih, have you found a solution for this use case?
I'm trying to do something similar but haven't had success


fix the install documentation, one final time

We can't go-get due to gx.

make install should install gx. The problem here was that go get STUFF tries to get the gx dependencies and fails (because gx/ipfs/Qm... isn't a valid URL). Any package with gx "rewritten" imports isn't "go gettable". We leave most packages in the normal, non-gx form (with, e.g., github.com/... imports) for this reason. However, we leave go-ipfs in the rewritten form to prevent users from installing IPFS with go get github.com/ipfs/go-ipfs/cmd/ipfs (as they'd end up with the wrong dependency versions). This package needs to use gx/... paths as it depends on go-ipfs.
See: https://github.com/ipfs/go-ipfs/issues/4831

(I've updated them per CR by @bmuller)


[stable/grafana] Bump version

Signed-off-by: Login Victor<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/assign @maorfr

It seems you included some undesired changes

@carrodher @maorfr Made changes

/lgtm
Thanks for contributing!


replicaServiceTemplate is selected at a shard, not the replica.

Using operator 0.18.4. My understanding of replicaServiceTemplate is that it will be generated per replica, not per shard. The goal is to have a service that can load balance between replicas specifically, not just the whole CHI.
I've omitted some configuration for posterity.
...
clusters:
  - name: simple-test
    templates:
      replicaServiceTemplate: replica-service-template
    layout:
      replicas:
        - name: ro
          shardsCount: 2
        - name: wo
          shardsCount: 2

serviceTemplates:
  - name: replica-service-template
    generateName: "replica-{chi}-{cluster}-{replica}"
...

This produces the following selector, for example:
$ kubectl describe service/replica-clickhouse-chart-test-simple-test-ro
...
clickhouse.altinity.com/app=chop
clickhouse.altinity.com/chi=clickhouse-chart-test
clickhouse.altinity.com/cluster=simple-test
clickhouse.altinity.com/namespace=default
clickhouse.altinity.com/replica=ro
clickhouse.altinity.com/shard=1
...

Please advise if I understand replicaServiceTemplate correctly, its goals, and whether or not it should be applying the shard to the selector.

thanks for reporting
could you confirm
you want create one service which cover all ro replicas in all shards  and one service which cove all wo replicas in all shards?
You choose custom generateName and shardsCount: 2
look like operator will generate services for ro replica twice with the same name
and overwrite clickhouse.altinity.com/shard
moreover look like
replicaServiceNamePattern unused now in codebase

Correct, one service generated per replica is my desired use case.
That is my expectation of how replicaServiceTemplate should work, given the
name and references in code (looking at the replica service name in
namer.go). In practice it seems like the selector is selecting the last
created shard.
On Tue, Apr 26, 2022, 8:38 PM Eugene Klimov @.***>
wrote:

thanks for reporting
could you confirm
you want create one service which cover all ro replicas in all shards and
one service which cove all wo replicas in all shards?
You choose custom generateName and shardsCount: 2
look like operator will generate services for ro replica twice with the
same name
and overwrite clickhouse.altinity.com/shard
moreover look like
replicaServiceNamePattern unused now in codebase
—
Reply to this email directly, view it on GitHub
https://github.com/Altinity/clickhouse-operator/issues/923#issuecomment-1110499298,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK6M7CKJXN57M7IQD3JH7LVHCZCJANCNFSM5UNQK3XQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Due to historical reasons replicaServiceTemplate is a template used to create service which points to a particular instance of a running clickhouse (process). The origin hides in dark ages, when one instance of a clickhouse was called, guess, a replica. Right now operator does not create any service, which points to "columns of clickhouse instances with the same replication index" (a.k.a replica as well). Kinda confusing, yes.

I see, so this the intended behavior. Thanks for the clarification.
For my use case, I will then replace the service objects after
clickhouse-operator is completed with a different selector.
On Wed, Apr 27, 2022, 3:16 AM Vladislav Klimenko @.***>
wrote:

Due to historical reasons replicaServiceTemplate is a template used to
create service which points to a particular instance of a running
clickhouse (process). The origin hides in dark ages, when one instance of a
clickhouse was called, guess, a replica. Right now operator does not
create any service, which points to "columns of clickhouse instances with
the same replication index" (a.k.a replica as well). Kinda confusing,
yes.
—
Reply to this email directly, view it on GitHub
https://github.com/Altinity/clickhouse-operator/issues/923#issuecomment-1110826455,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAK6M7GDS2XCHKZEE5U24BLVHEHYJANCNFSM5UNQK3XQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Change meaning of replicaServiceTemplate to "service which points to a column of clickhouses"

Given that this could be a potentially backwards-compatibility breaking change, because someone is probably using replicaServiceTemplate as its original meaning, it stems to reason that hostServiceTemplate could be more appropriate here.
I have a path forward, and am not blocked by this, I just simply have to change our deployment pattern slightly at the end.


keybinding overwrites redo

keybinding ctrl-shift-z overwrites the redo default keybinding... so anoying.

The default keybinding is ctrl-z on windows and linux, and cmd-z on macos. (Except if they changed recently, but it would be weird.

ctrl-z is to undo... ctrl-shit-z is to redo

Hello,
In fact, as I work on mac, I never get that problem.
With the latest release, the default keybinding has changed.


Kubify running all the things!

There's a branch in-flight using kustomize YAML for all the microservices, kube Services to load-balance in front of them, and to run an OTel Collector.
Maybe helm charts would be better, especially considering the amount of duplication in the deployment definitions for each type of microservice.

Hello,
As we enter 2022 Q1, we are trimming our OSS backlog. We will be closing this issue as it is a low priority for us to fix. It is unlikely that we'll ever get to it, and so we'd like to set expectations accordingly.
If this issue is important to you, please feel free to ping here and we can discuss/re-open.


Redirect loop with 8.1.0

On enabling this app via the application menu on 8.1.0 I started to get a redirect loop on the landing page /index.php which resolved after disabling the application from another already logged in session.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/26145034-redirect-loop-with-8-1-0?utm_campaign=plugin&utm_content=tracker%2F308690&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F308690&utm_medium=issues&utm_source=github).

please provide more details: debug log, setup environment, steps to reproduce, and if possible some alternate steps that already also goes to reproduce this bug!

Issue also confirmed only happened with oc 8.1 by @Worst45 , but i'm still waith for @ppeach feedback setup and logs debug info.
Seems commented (for oc 8.1+ only)  on appinfo/app.php, line: OCP\App::checkAppEnabled('storagecharts2'); solves the problem, quoted text from reporter:

Hello, I still have the same problem on oc 8.1, even after using the last storagecharts2 github files:

occ command does not display anything
the login page loops while trying to fetch index.php
The error appears on a fresh install or after migrating from oc 8.0 to 8.1 (it worked on 8.0).

I have no specific error logs. (but I am not in debug mode or whatever)

EDIT:
the error appears on appinfo/app.php, line:
OCP\App::checkAppEnabled('storagecharts2');

If you comment this line, everything works again. Hope it could help you.

tail -f /var/log/apache2/access.log
<IP_ADDRESS> - - [25/Aug/2015:15:37:27 +0200] "GET /drive/index.php HTTP/1.1" 302 -/- (-%)
<IP_ADDRESS> - - [25/Aug/2015:15:37:27 +0200] "GET /drive/index.php HTTP/1.1" 302 -/- (-%)
...
<IP_ADDRESS> - - [25/Aug/2015:15:37:27 +0200] "GET /drive/index.php HTTP/1.1" 302 -/- (-%)
<IP_ADDRESS> - - [25/Aug/2015:15:37:27 +0200] "GET /drive/index.php HTTP/1.1" 302 -/- (-%)

(More than 20 times)

End of line!

searching at oc API checkAppEnabled() its a private method and may change without notification, i not have knowled of any public alternative, seems for oc 8.1+ are deprecated but api info sais not! http://api.owncloud.org/classes/OCP.App.html#checkAppEnabled
i think its a oc core problem please report to oc issue traker firts

i reopened this issue due problems are since recent commits, as refers in #348, seems the application are not activated property and the "checkAppEnabled" method redirects in a infinite loop to home.

Confirmed problem in ownCloud 8.1.1
To try to fix I have updated storagecharts2 to the 2.6.2 but the home page says "Update process" ...instead of infinite redirection loops

please @Uccio made a clean install, see the instructions for in the wiki: https://github.com/hypery2k/owncloud/wiki/StorageCharts2-Installation-and-Usage#some-unninstall-tips
the when made a clean removal, made a clean install (so then will be a firts install)
later we cover then updgrade issues if u confirm this particular issue when "app its enabled"

can you please retry the latest nightly build?
https://martinreinhardt-online.de/jenkins/job/OwnCloud_nightly/

I opened an issue on owncloud core. At the time I didn't know it was related to the app and not the core.
https://github.com/owncloud/core/issues/17580

If i copy the 2.6.2 nightly to the apps folder and enable it within Apps settings and log out i do get the "upgrade to 8.1.3" window when i try to login again. Once i remove the folder again it is back to normal instantly.

hey @Saxfusion u must delete all the registres from database, plea follow steps in wiki for complete removal of and app here: https://github.com/hypery2k/owncloud/wiki/Update-or-removal-tips-of-and-app
the oc mechanish of automatic updates takes changes due saves the app version in database, if something change, so oc "think" was and incomplete upgrade (how stupid right)
aftr that steps copy and enable again the app and post feedback

I've got no idea why this is happening. I hate to change every time the app with every new OC release.  I think I quit developing OwnCloud apps Sorry to say,

@hypery2k I'm pretty sure that an OC dev would be able to help you on that. You may give it a try on IRC or the mailing-list. OC is evolving pretty fast and they are apparently reshaping their app system, but it often comes with some code to change on the third party side (look at the new extension system for Firefox ;)).

I'm just not happening the time for this anymore. At the end it doesn't work out for me. Spending hours for each version is more than I want to effort for each new version. Especially when it comes to testing...

I agree with what @hypery2k  says, this happens when a software project is taken by companies who just want money just like oc enterprices.. if there's no more feedback around that problem with a "really clean" install this issue must be close.

feel free to open a PR with the appropriate changes

Hi, just to notice that I just installed the latest version (2.6.1) from the appstore. Installing and using it was ok unitl I logged out. When trying to load ownclouds loginpage a got a Redirection Loop Error and could not load the page anymore.
I use owncloud v.8.1.3

please install from nighty build and report feedback!

I just ran into the same problem with owncloud 8.2.1. I got ERR_TOO_MANY_REDIRECTS which disappeared after I removes the Storage Charts 2 App.
I operate multiple owncloud instances with Storage Charts 2 App enabled and the problem only occured on one site. So I analyzed it a little bit deeper and found that the problem only occurs if you restrict the access to this app and grant the access only to an owncloud usergroup.
After I removed the access restrictions for this app there is no more redirect problem in owncloud even if the Storage Charts 2 App is installed and enabled.

since OC groups management storage_chars_2 and many others apps started have problems.. i start to think that the real problem its the constant changes that enterprices forced to the OC project..
if any body have a code to solve the situation please made a pull request to analyse, test and then merged

enabled the app few days back, today all of a sudden, to many redirects. Came across another issue, rm the app folder and it works again.
ubuntu 14.04
owncloud 8.2.2

sorry to say, but I don't develop the app anymore

@hypery2k If the app is not developed anymore please at least set the correct max. version to 8.1 in https://github.com/hypery2k/owncloud/blob/master/storagecharts2/src/main/php/appinfo/info.xml and upload a new archive to the appstore to avoid people installing this broken version.

the min version muist be 5 due i have this working perfectly in 6.X oc setup
a note around that, it seems people install this in a automatically mode, and a true administer try all the new thing in a semi-manual mode always!

You can set the min version to 1 as long as the max version is set to something sane and doesn't allow users to install the app on newer versions of oC where it is causing this seen issue here.

@RealRancor does this part of code in info.xml are supported for oc 5 and oc 6, due i'm pretty sure its supported for oc 7.X
<dependencies>
    <owncloud min-version="5" max-version="8.0"/>
</dependencies>

@mckaygerhard Sorry, i'm not that familiar with that. But you can have a look at:
https://doc.owncloud.org/server/8.2/developer_manual/app/info.html
https://doc.owncloud.org/server/8.2/developer_manual/app/tutorial.html#database
where you can find the info about the app metadata.

i already read this, the documentation does not refers seems suported by older versions:
https://doc.owncloud.org/server/8.2/developer_manual/app/info.html#dependencies
does not contains a tag "since" versions, so a commit like that will break support for OC 5 and 6 and i used still OC 6 and works very optimun (much more faster ratehr than others 8.X)

as i noted does not supported, https://doc.owncloud.org/server/7.0/developer_manual/app/info.html#requiremin in 7.X so this commit will break the support for older releases and this app still work perfectly in older releases

You still can distribute different versions of the app with different metadata.
Personally i don't think that anyone should care about versions older than oc8 as they are either ond-of-life or will reach end-of-life soon.

distribute two apps means made mechanish for two builds, if u will mantain a pull request are welcome..
well in part u have right, but the fact that the "upstream" does not "take care" does not mean that others will not, currently my company will not care more hardware or ram to install OC 8.X that runs several times more slowly (i have around of 1000+/- users with 300~500 concurrently)
in other hand, this app does not work in OC 8, so users must read in apps.owncloud the comments and support before made something..
in any case pull request are welcome but with backguard of course

Hi,
i won't do any pull requests as i don't use this app. But i think thats is also not the problem here. The main problem is that this app is breaking newer oC installations now because it is advising a compatibility with that versions.

done in apps site, theres the neeed info done:
https://apps.owncloud.com/content/show.php/roundcube?content=151523
said max version to 8.1, users shoud READ before try.
the break redirection its jst due the new api cleanup, due many private methods are now deprecated, the next work must take care of that!

As written above: In recent oC versions users don't need to go to apps.owncloud.com. They just open their oC internal appstore and click "enable".
Ah, and btw. this issue here happens with 8.1 so the max version of 8.1 is wrong

umm theres not are solved for 8.1? i thing was solved for 8.0 and then later for 8.1? and about the ap store, well @hypery2k then must change some of the description to mention those limits
i noted that more great apps in the store have same problems as this.. the cause are alway the same, constants changes in OC code forces others to constants changes in apps.. i'm tyred of this and then also too..

Just see comments like https://github.com/hypery2k/owncloud/issues/351#issuecomment-168797507 that this is still happening.


Json Schema Breaking Change: rename crashing_thread.thread_index to threads_index

Fixes #331

r? @willkg

@Gankra Looks good! :+1:


Separate core_ext

NOTE
Best reviewed by skipping the first commit that moved humanize.rb to humanize/module.rb and ignoring whitespace: https://github.com/radar/humanize/pull/88/files/a84b371db91fe64c184215df1b147f7a70c8912d..500e185faeb990f4e801d07ec6ac20643249f540
Changes
The Humanize gem would formerly always duck punch itself into the Integer, Float, and BigDecimal classes.
This PR takes inspiration from how active_support does core extensions. The core extensions are now optional with this require:
require 'humanize/core_ext'

And that is required automatically if you
require 'humanize'

to match previous behavior. But new code has the option to set require: false in the Gemfile and just do
require 'humanize/module'

Then rather than doing
42.humanize(...)

it can instead use the pure functional form (which is always available):
Humanize.format(42, ...)

This is useful for code bases that want don't want to duck punch into Ruby core classes.

@radar BTW I think the # frozen_string_literal: true magic comment can help across the board here. I won't clutter this PR with that, but once this is merged, I'll submit another PR that includes that magic comment and then drops .freeze after all the string constants.

Fine by me regarding FSL.
 Would you mind fixing that up? I can't push to your branch due to permission restrictions.

 Would you mind fixing that up? I can't push to your branch due to permission restrictions.

Ah, I'd made this change suppress that rubucop failure but lost it in the merge-up. Merged back here: https://github.com/radar/humanize/pull/88/commits/a347bbb140a6a2d1f1af643c13e6a771e1b57b60
Also, I found I'd missed this recursive call that was depending on the core Integer class being extended. I've switched it to functional (which will always work): https://github.com/radar/humanize/pull/88/commits/9339246a259e90b046248080726e43e89e496137
And finally, I updated the README to document the new functional usage: https://github.com/radar/humanize/pull/88/commits/32bd066d754d4e04b4ad431ff9268ee4d49d7411

All checks out to me. Thanks very much! ❤


Note fail on the first run

VSTS Extension you are using
Generate Release Notes based on Release Comparision API
Where are you running it?
On Prem TSF 2017-latest update
Version of Extension/Task
Version: 2.1.1
Expected behaviour and actual behaviour
When setting up a release for a branc new project, the ext failed
It was not able to get a value for compareReleaseDetails.name
There were no other releases to compare with
I would expect the extension to either gracefully exit or show all changes
Steps to reproduce the problem
Create a branch new pipeline, or delete all other releases

Yes that sound a bug, I will need to look to create a repo of the problem

Got a repo, I will look into a fix that makes this use case robust

Fixed in 2.2.2


Type inference fix

This updates the type inference code to calculate sorts also for _ variables, and to more carefully combine sort constraints from multiple possible parses.
Now a variable is assigned an inferred sort only if that sort is a (nonstrict) supersort of the sort the variable has in every possible way of assigning legal variable sorts in any of the possible ambiguous parses. An error will be reported if any variable doesn't have a unique maximal sort, or if it's not possible to simultaneously assign all those sorts. Also, an ambiguity error will be reported a bit after this code if assigning these inferred types isn't enough to reduce the possible parses down to a single KORE term (debugging VariableTypeInferenceFilter may show some ambiguity nodes, because this code is still working in terms of productions where e.g. overloaded labels may lead to mutliple syntax trees that still eventually flatten to the same AST).
@radumereuta please review.
Fixes #1586 and #1603.

Passes when I run that test by hand, or run ktest locally.
Jenkins: test this

Jenkins: retest this please

lgtm. When you parse the C semantics with this are you able to successfully run tests in the OCAML backend?

C is actually broken in master, from a bug filed as #1612. I'm looking into it, I suspect it was a missed problem in the cell fragments change.

That's been fixed, so,
Jenkins: retest this please.

Jenkins: retest this please.

The test-build target passed. (I had to fix the C makefile to not lose K's increased stack size when setting K_OPTS to avoid a stack overflow).

FYI, @cos maybe you want to look at the POSet method?

I just tested the issue myself. If this is the wanted behavior, then go ahead with merging.
lgtm


sweep: remove conflicted sweep txns from the rebroadcaster

In this commit, we an existing gap in our rebroadcast handling logic. As is, if we're trying to sweep a transaction and a conflicting transaction is mined (timeout lands on chain, anchor swept), then we'll continue to try to rebroadcast the tx in the background.
To resolve this, we give the sweeper a new closure function that it can use to mark conflicted transactions as no longer requiring rebroadcast.
Related to:

https://github.com/lightningnetwork/lnd/issues/7548
https://github.com/lightningnetwork/lnd/issues/7390
https://github.com/lightningnetwork/lnd/issues/7181

Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

also related? https://github.com/lightningnetwork/lnd/issues/7104

@Roasbeef when running in mobile we see sweep tx is rebroadcasted on every restart using another mechanism here: https://github.com/lightningnetwork/lnd/blob/master/sweep/sweeper.go#L344
So there is a bucket that caches the last broadcasted tx and retries to broadcast it on every restart regardless if it double spends causes the wallet to stay in the same state where all balance is unconfirmed.
Will this PR fix this variant of the issue as well?
BTW I am not sure why we are not removing the tx from that bucket when we get the double spend here: https://github.com/lightningnetwork/lnd/blob/master/sweep/sweeper.go#L362

@Roasbeef I can open another issue on the above but would be great to get your insights on that beforehand.

@roeierez correct, the very last sweep tx (but not all the others) is re-broadcasted on start up.

So there is a bucket that caches the last broadcasted tx and retries to broadcast it on every restart regardless if it double spends causes the wallet to stay in the same state where all balance is unconfirmed.

Today the sweeper doesn't remove it's last transaction (just replaces it), and also doesn't currently garbage collect those old sweep hashes. This is the main storage interface used: https://github.com/lightningnetwork/lnd/blob/master/sweep/store.go#L46-L61 (has no deletion rn). The sweeper was intended to be mostly stateless, but I think there's no reason we shouldn't remove transactions after they've been double spent or confirmed.

Will this PR fix this variant of the issue as well?

This PR ensures that any older conflicting sweep transactions are removed from the wallet, but you're correct in that the sweeper will still hold onto the very last one.

BTW I am not sure why we are not removing the tx from that bucket when we get the double spend here: https://github.com/lightningnetwork/lnd/blob/master/sweep/sweeper.go#L362

I think you're right. We should remove that tx, and also call this same routine to remove any conflicting transactions from the wallet: https://github.com/lightningnetwork/lnd/blob/35917eb8583431c5ad1cb675d6f9a333e110aa86/sweep/sweeper.go#L713-L727.
Re the issue: I think it makes sense to make a tracking issue for sweeper tx deletion. This would cover the code area I linked above, and also generally removing well confirmed sweep hashes.

it on every restart regardless if it double spends causes the wallet to stay in the same state where all balance is unconfirmed

We should be always removing the tx when we get a conflict: https://github.com/btcsuite/btcwallet/blob/68f7e23dca2742b98d13d6bd8e9340047bc6aa9e/wallet/wallet.go#L3799-L3824
We've had reports that this isn't always happening, but the last time I went to repro it, I found the txns were always being removed: https://github.com/lightningnetwork/lnd/pull/6583#issuecomment-1143938772.


[SPARK-34899][SQL] Use origin plan if we can not coalesce shuffle partition

What changes were proposed in this pull request?

Add check if CoalesceShufflePartitions really coalesce shuffle partition number.
Why are the changes needed?

The CoalesceShufflePartitions can not coalesce such case if the total shuffle partitions size of mappers are big enough. Then it's confused to use CustomShuffleReaderExec which marked as coalesced but has no affect with partition number.
Does this PR introduce any user-facing change?

Probably yes, the plan changed.
How was this patch tested?

Add test.

Test build #136647 has started for PR 31994 at commit d9ffcf3.

Test build #136647 has finished for PR 31994 at commit d9ffcf3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41229/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41229/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136647/

We encounter this case during using aqe, but seems it is an expect behavior in previous test. Do you have any thought about this ? @maropu @cloud-fan @JkSelf

also cc: @maryannxue

Test build #136695 has started for PR 31994 at commit 753e711.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41277/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41277/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41277/

Test build #136702 has started for PR 31994 at commit 1154e18.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41284/

Test build #136695 has finished for PR 31994 at commit 753e711.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136695/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41284/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41289/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41289/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41289/

Test build #136702 has finished for PR 31994 at commit 1154e18.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136702/

late +1


Test creation of Purchase contract

We need to figure out how to capture solidity events in our tests. In first case, we need to get the address of the created Purchase contract.
See notes and initial research links here:
https://github.com/OriginProtocol/platform/blob/develop/packages/contracts/test/TestListing.js#L45-L49

@wanderingstan It seems like it might be important for Listings to keep track of their Purchases.
Otherwise, anyone can create any old custom Purchase contract and claim it belongs to listing. This would be bad.
Secondly, if Listings don't know their Purchases, then it requires tracking the entire blockchain to know the status of a listing's purchases. A single link from a Purchase to a listing, like we have now, would be the way it's handled in a relational database, but the blockchain only really lets you follow links one way. If you want bi-directional linking, then you have to link bi-directionally.
So if we do track a Listing's Purchases, then we don't have to watch for events here in the test, since we can just ask the listing for the most recent Purchase.

Here's the code to pull a contract from the emitted event:
const buyTransaction = await instance.buyListing(
  unitsToBuy,
  { from: accounts[1], value: 6 }
)
const listingPurchasedEvent = buyTransaction.logs.find((e)=>e.event=="ListingPurchased")
const purchaseContract = purchaseDefinition.at(listingPurchasedEvent.args._purchaseContract)

I've added this, and am now working on more purchase tests.


MRG: Suggest using "conda rename" in MNE updating instructions

Closes #11690

Rendered docs:
https://output.circle-artifacts.com/output/job/2418ccf0-b843-48ae-bf35-6988a3a82168/artifacts/0/html/install/updating.html

Thanks @hoechenberger !


Add missing runners for autoTested javadoc snippets in workers and ide-plugins projects

@bot-gradle test QFL

I've triggered the following builds for you. Click here to see all build failures.

QuickFeedbackLinux build

@bot-gradle test and merge


Implement Type Erasure

zulip discussion
Ayaz's description high level of how it should be implemented
An old WIP PR
example of a program and the corresponding IR
Ayaz offered the following are missing pieces:

Reference counting. The erased closure layout has a slot for a pointer to a function that performs refcounting on the closure data, but the pointer is never populated right now. some works needs to be done to store a reference to the refcounting function that should be generated, and insert the pointer appropriately. I'm sure this is not that hard to do, but I don't know the details off the top of my head.
Abilities. This is actually very simple, the main thing is that all the machinery to support abilities with lambda sets (there's a lot of it, if you see anything about "ambient functions" that has to do with it) needs to be skipped. I'm happy to explain what needs to be done to support resolution of abilities in the erasure world when it comes time (I think it's very simple, it's like one new check I believe)
Some fixes to the mono IR. There are a number of todos related to erased closures that will need to be resolved. One I am aware of is passing closures to higher-order functions by value does not work right now, just because that branch is a TODO.

Quick update: @ayazhafiz has come up with a working MVP experiment of properly working lambda sets, as mentioned here on the Zulip chat. Assuming we are able to translate everything properly, we will likely not need type erasure anymore, as it was intended as a stop-gap for what Ayaz has put together.

You still need type erasure regardless; it is impossible to implement
Task.map2 without it.
On Fri, Aug 16, 2024 at 12:00 PM Sam Mohr @.***> wrote:

Quick update: @ayazhafiz https://github.com/ayazhafiz has come up with
a working MVP experiment of properly working lambda sets, as mentioned here
on the Zulip chat
https://roc.zulipchat.com/#narrow/stream/395097-compiler-development/topic/lambda.20sets.3A.20compiled/near/462455100.
Assuming we are able to translate everything properly, we will likely not
need type erasure anymore, as it was intended as a stop-gap for what Ayaz
has put together.
—
Reply to this email directly, view it on GitHub
https://github.com/roc-lang/roc/issues/6985#issuecomment-2293764454, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE6GL6VSGFEGESV2C6XEJ6LZRYOYTAVCNFSM6AAAAABMNUUZUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTG43DINBVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


About Sound

Hi there,
For triggering sound reactive visual,
Is there any variable equivalent to the "sound" variable in vertexshaderart.com?
uniform sampler2D spectrum;
uniform sampler2D samples;
When using the variables above, I could not get the same result in vertexshaderart.com
Thanks for your help!

Hi  @BrandonLSW ,
Do you want the volume of current frame, or the history of volumes?
If the former, you can just use volume.
In vertexshaderart.com, sound stores the history of volumes of past 240 frames.
Currently there's no equivalent in VEDA.

Thanks @fand. If I want to come up with the same result in vertexshaderart.com, is it possible to obtain the history of volumes "sampler2D sound" by some calculations of the variable "sampler2D samples"?

is it possible to obtain the history of volumes "sampler2D sound" by some calculations

Maybe yes, but it's a bit difficult, and I haven't tried yet.
You can create sound texture by using multipass rendering; Update sound in 1st pass, then use it in 2nd pass.
The code will be like this;
/*{
  PASSES: [
    { TARGET: "sound", FLOAT: true, WIDTH: 240, HEIGHT: 1 },
    {}
  ]
}*/

uniform vec2 resolution;
uniform int PASSINDEX;
uniform float volume;
uniform sampler2D sound;

void main() {
  if (PASSINDEX == 0) {
    // Shader for 1nd pass.

    // Save the volume of current frame in x == 0.
    if (gl_FragCoord.x == 0.0) {
      gl_FragColor = texture2D(sound);
    }
    else {
      // Shift 1 pixel for other pixels.
      vec2 leftPixel = max((gl_FragCoord.x - 1.0) / resolution.x, 0.0);
      gl_FragColor = vec4(volume, vec2(leftPixel, 0.0));
    }
  }
  else {
    // Write shader for 2nd pass.
    // You can use `sound` here!
    float mySound = texture2D(sound, vec2(0.0, 0.0)).x;
  }
}

Thanks. Gonna try it!


Errors when using seperate MYSQL server

migration failed with error: create table auth (idint unsigned not null auto_increment primary key,created_ondatetime not null,modified_ondatetime not null,user_idint unsigned not null,typevarchar(30) not null,secretvarchar(255) not null,metajson not null,is_deletedint unsigned not null default '0') - ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'json not null,is_deleted int unsigned not null default '0')' at line 1
This occurs when it first tries to create the database.. only 2 tables are created :
migrations
migrations_lock

fixed by updating MySQL to MariaDB and using MySQL as the engine in the config.json

For anyone coming across this in future, only MySQL server v5.7.8 and above, and MariaDB databases are supported with this project.

I'm having the same issue with a fresh install but I'm using MariaDB 10 on other container
Server version: 10.1.38-MariaDB-0ubuntu<IP_ADDRESS> Ubuntu 18.04
the error is:
writing new private key to '/data/nginx/dummykey.pem'
Complete
[4/26/2019] [11:41:01 PM] [Migrate  ] › ℹ  info      Current database version: none
[4/26/2019] [11:41:01 PM] [Migrate  ] › ℹ  info      [initial-schema] Migrating Up...
migration file "20190227065017_settings.js" failed
migration failed with error: create table auth (id int unsigned not null auto_increment primary key, created_on datetime not null, modified_on datetime not null, user_id int unsigned not null, type varchar(30) not null, secret varchar(255) not null, meta json not null, is_deleted int unsigned not null default '0') - ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'json not null, is_deleted int unsigned not null default '0')' at line 1
and the last part keep repeating, any idea?

With Mariadb, the JSON field type was introduced in 10.2.7.


[bug] The store plugin reports an error according to the configuration of the official website, and the autoSave type is incorrect.

Describe the bug

https://tauri.app/plugin/store
As shown in the picture, according to the configuration type of the official website, it should be boolean, but an error will be reported. If you fill in the u64 type, there will be no problem.
Reproduction
No response
Expected behavior
No response
Full tauri info output
Environment
    - OS: Windows 10.0.19045 X64
    ✔ WebView2: 129.0.2792.79
    ✔ MSVC:
        - Visual Studio Enterprise 2022
        - Visual Studio ���ɹ��� 2022
    ✔ rustc: 1.80.1 (3f5fd8dd4 2024-08-06)
    ✔ Cargo: 1.80.1 (376290515 2024-07-16)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (environment override by RUSTUP_TOOLCHAIN)
    - node: 20.17.0
    - yarn: 1.22.19
    - npm: 10.8.2

Stack trace
No response
Additional context
No response

This will be tracked in #1865