Login flow completes with redirect but hasValidAccessToken is still false (access token not registered)

The Problem
I am using angular-oauth2-oidc to integrate the Salesforce REST API to my Angular frontend. I have followed the instructions in the documentation and have gotten the authentication flow to be completed without any issues or errors at all. In other words, loadDiscoveryDocumentAndTryLogin did not error, initLoginFlow brought the user to sign in on Salesforce, and Salesforce redirects the user back to the Angular page with the access token, refresh token, etc. in the url (The contents of the callback are passed after a hash tag (#) instead of as query parameters, shown below).
http://localhost:4200/home#access_token=<--myAccessToken-->&refresh_token=<--myRefreshToken-->&instance_url=<--instanceURL-->&id=<--myID-->&issued_at=1656473729221&signature=<--signature-->=&state=<--state-->&scope=api+web+refresh_token+openid+wave_api&token_type=Bearer

However, hasValidAccessToken is still false after this login flow, the access token is missing from OAuthStorage, and the web app does not register the user as logged in.
What I've Tried:

Using JwksValidationHandler (no change)
Switching to implicit flow (no change)
Experimenting w/ the community templates (sample-angular-oauth2-oidc-with-auth-guards on master and implicit-flow branches give me this exact problem)

I attached below my code snippets of my projects along with my config for the library. For reference, this is the documentation for using OAuth w/ Salesforce REST API. Any help would be appreciated!
auth.services.ts (Angular service I call on to authenticate the user)
import { Injectable } from '@angular/core';
import { OAuthService } from 'angular-oauth2-oidc';
import { JwksValidationHandler } from 'angular-oauth2-oidc-jwks';
import { authCodeFlowConfig } from './config/authCodeFlowConfig';

@Injectable({
  providedIn: 'root',
})
export class AuthService {
  constructor(private oauthService: OAuthService) {
    this.configSSO();
  }

  configSSO() {
    this.oauthService.configure(authCodeFlowConfig);
    this.oauthService.tokenValidationHandler = new JwksValidationHandler();
    this.oauthService.loadDiscoveryDocumentAndTryLogin().then(() => {
      if (this.oauthService.hasValidAccessToken()) {
        this.oauthService.loadUserProfile();
      }
    });
  }

  login() {
    if (this.oauthService.hasValidAccessToken()) {
      console.log('already logged in?');
      return;
    }
    console.log('login');
    this.oauthService.setupAutomaticSilentRefresh();
    this.oauthService.initLoginFlow();
  }

  logout() {
    console.log('logout');
    this.oauthService.logOut();
  }
}

authCodeFlowConfig.ts
import { AuthConfig } from 'angular-oauth2-oidc';

export const authCodeFlowConfig: AuthConfig = {

  issuer: 'https://<--mySalesforceURL-->.my.salesforce.com',

  redirectUri: window.location.origin + '/home',

  clientId:
    '<--myClientID-->',

  dummyClientSecret: 'dummy',

  responseType: 'token',

  scope: 'api wave_api refresh_token offline_access web',

  showDebugInformation: true,
};

Huh, that's strange!
One thing I notice in your config is that you don't request openid scope, can't entirely recall what it's purpose is, but there's also an openid: true|false config option you could check out to see if it affects things?
Then again, if you also tried my sample repo and ran into the same issue, that might not be it? Or did you also change scopes there?
What is the debug output when you use my sample repo with the main AuthCode+PKCE branch? There should be a bunch of extra logging on the dev tools.
Typically if the hash fragment is not being cleared but left alone, the tryLogin.... part is not executing correctly. I recommend stepping into those functions with the devtools debugger and see what goes wrong. Because you should be going into this code....
https://github.com/manfredsteyer/angular-oauth2-oidc/blob/d95d7da788e2c1390346c66de62dc31f10d2b852/projects/lib/src/oauth-service.ts#L1729-L1746
....which should be clearing the hash fragment from your application.
I hope that helps. I think you'll need to debug it on your end, unless you have a SalesForce instance you can share with the community to try this on their own to help debug it.
Good luck!

Thanks for your help! Though, I ended up building my own solution to handle Salesforce's API OAuth from scratch (which was not too difficult since they use implicit flow). I'm still not sure what is causing this issue, but others can try tinkering with this by getting a sandbox and trying to use this library with their API: https://developer.salesforce.com/signup.


Dashboard/my profile

Description
**Invited Collaborator(s) to Review

Added person to review relating to feature/bug
If not available, ask another reviewer on team

What work was done?

Created and finished style for the my profile component displayed on the dashboard

Why was this work done?

This feature is to display user information on the dashboard

What feature / user story is it for?
(Link if possible)
https://trello.com/c/1AaSfP9i
Type of change
Please delete options that are not relevant.
Testing

Has this feature been tested before conflict?
Has this feature been tested after conflict?

Change Status

Completed, ready to review and merge

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
My code has been reviewed by at least one peer
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
There are no merge conflicts

I agree with Adam the code is clean and I like how you have the responsive design in the commit


Add categories to OWA output_dict

Realized that it would be helpful to see which categories/tags an email item currently has.

Nice! Btw, related to the newline stripping of message-id; couldn't we just do that in the python script itself?


Create tertiary SCSS button

This is the SCSS implementation of https://github.com/thumbtack/thumbprint/pull/93. I'd recommend reviewing that one first.
Relates to #89.

@tomgenoni — This is ready for review. Although rolling this out is dependent on completing the @thumbtack/thumbprint-scss migration first since this will be part of the new package.

@tomgenoni — Had to fix a CHANGELOG merge conflict. Can you take another look?


feat: sync tags as sender

This PR enables simple multi-device support by simply syncing the tagging secret indexes when fetching calculating the tag latest tag to use as a sender. The calculated tag uses the largest found index (recent), whether it be from on device, or from remote.
Resolves #9762.

I would add the e2e-all tag to this one, since it modifies the way notes are sent for the whole repo.


Fix an algorithm of positioning a suggest widget

This PR fixes https://github.com/microsoft/vscode/issues/118049
https://user-images.githubusercontent.com/17052177/110242244-818a1980-7f98-11eb-9671-218df493e003.mp4

Thanks for taking the time to make a contribution to VS Code. I have just fixed a few bugs in this area and also this the issue that this PR refers to. Therefore I am closing this PR without merging. Thanks for understanding


ServerRequest has no URI set

Detailed description
When creating a ServerRequest it does not has the request URI or target set.
Context
When working with Aura Router it fails when trying to call getPath() on a null.
Possible implementation
It can use the $_SERVER['REQUEST_URI'], $_SERVER['REQUEST_SCHEME'] and $_SERVER['SERVER_NAME'] to create the URI for the request
Your environment
I am using PHP 5.6 on a docker container using Apache/PHP

On good way of implementing this is by adding support for relative URIs.
With this implementation it will not need to know the server name and request scheme. Just the $_SERVER['REQUEST_URI']

There is a need to make sure that the $_SERVER has the necessary data in the majority of the web servers.


feat(rust): update macos activation policy

Current behavior

The macOS desktop application shows up in both the top right menu and the macOS dock.
Proposed changes

The issue that this PR fixes is described in #5365
This PR implements some platform-specific code that sets the activation policy for macOS. The activation policy is now explicitly configured to display the application only in the macOS menu bar and not in the dock.
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will mark the commit as verified.

If you anticipate introducing more specific platform behaviour in the future, then we could also consider refactoring this PR to help improve code organization and make it easier to manage platform-specific functionalities.
main.rs:
#[cfg(target_os = "macos")]
mod macos;
#[cfg(not(target_os = "macos"))]
mod others;

#[cfg(target_os = "macos")]
use macos as platform;
#[cfg(not(target_os = "macos"))]
use others as platform;

lib.rs:
#[cfg_attr(mobile, tauri::mobile_entry_point)]
pub fn run() {
    let app_state = AppState::new();

    // For now the application only consists in a system tray with several menu items
    let mut app = tauri::Builder::default()
        .plugin(configure_tauri_plugin_log())
        .setup(move |app| setup_app(app))
        .system_tray(make_system_tray(&app_state.options()))
        .on_system_tray_event(process_system_tray_event)
        .manage(app_state)
        .build(tauri::generate_context!())
        .expect("Error while building the Ockam application");

    platform::set_platform_activation_policy(&mut app);

    app.run(process_application_event);
}

macos.rs:
use tauri::AppBuilder;

pub fn set_platform_activation_policy(app: &mut AppBuilder<()>) {
    app.set_activation_policy(tauri::ActivationPolicy::Accessory);
}

others.rs:
use tauri::AppBuilder;

pub fn set_platform_activation_policy(_: &mut AppBuilder<()>) {
    // On non-macOS platforms, do nothing
}

@qxtaiba you need to rename your commit and prefix it with feat(rust):  to make the build pass.


[Feature request] signet support

Signet is a better testnet without the mining aspect and mainnet-like (Poisson) distributiion of new blocks.
Syncs in seconds and has minimal storage requirement.
Signet support is already implemented in

Bitcoin Core v0.21.0
JoinMarket - Joininbox (there is a CLI only c-lightning installation too)
BTCPayServer
LND is planned: https://github.com/lightningnetwork/lnd/issues/5018

Once LND support arrives it would be great to have in RaspiBlitz as well.
Could be even running parallel alongside mainnet to keep at least bitcoin and LND up while experimenting - needs custom ports for all parallell services!

LND has basic signet support since: https://github.com/lightningnetwork/lnd/pull/5025
Activated in: d671aae


Enable deviation for implemetations that do not support setting BGP ConnectRetryTime.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.219%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2064

💛  - Coveralls

The PR#994 (merged) created deviation and used it against feature/bgp/tests/local_bgp_test/local_bgp_test.go.
This PR use same deviation against feature/experimental/bgp/ate_tests/base_bgp_session_parameters/base_bgp_session_parameters_test.go


Upgrade to react-dropzone 10

@jcoyne Any changes needed for BS4?

Nope

OK. Then once the merge conflict is fixed, this is good to be merged.

@justinlittman fixed the conflict.


Fixes 4853: fix gosec errors and enable gosec in CI

Summary
This PR addresses all problems currently reported by the gosec security checker and adds gosec to the list of checkers used in golangci-lint. Also fixes a problem with miss-matched Go versions for our pre-commit hooks.

https://issues.redhat.com/browse/HMS-4853


PDF pages get cut off

Attach (recommended) or Link to PDF file here:
https://drive.google.com/file/d/1LC_yAkFXtVza2aWisMNQbyetjv8Fzij-/view?usp=sharing
Configuration:

Web browser and its version: is actual for all browsers
Operating system and its version:
PDF.js version: latest
Is a browser extension:

Steps to reproduce the problem:

open pdf file by link
download file and open on your demo page
compare the images

What is the expected behavior? (add screenshot)
What went wrong? (add screenshot) The right side of the pictures is getting cut off, and the red part at the bottom goes up higher than it should.
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

This looks like another issue where PR #6606 might be relevant.


[Build] Failure: missing google_analytics_async.html

Current Behavior
$make site
Checking if Go is installed...
Go is installed.
hugo server -D -F
hugo: downloading modules …
hugo: collected modules in 9479 ms
Watching for changes in /Users/lee/code/docs/{assets,content,i18n,layouts,package.json,static}
Watching for config changes in /Users/lee/code/docs/hugo.toml, /Users/lee/code/docs/go.mod
Start building sites …
hugo v0.126.1+extended darwin/amd64 BuildDate=2024-05-15T10:42:34Z VendorInfo=brew

ERROR render of "taxonomy" failed: "/Users/lee/code/docs/layouts/_default/baseof.html:9:7": execute of template failed: template: _default/terms.html:9:7: executing "_default/terms.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:61:16: no such template "_internal/google_analytics_async.html"
ERROR render of "home" failed: "/Users/lee/code/docs/layouts/_default/baseof.html:9:7": execute of template failed: template: home.html:9:7: executing "home.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:61:16: no such template "_internal/google_analytics_async.html"
ERROR render of "term" failed: "/Users/lee/code/docs/layouts/_default/baseof.html:9:7": execute of template failed: template: _default/taxonomy.html:9:7: executing "_default/taxonomy.html" at <partial "head.html" .>: error calling partial: execute of template failed: html/template:partials/head.html:61:16: no such template "_internal/google_analytics_async.html"
Built in 1039 ms
Error: error copying static files: open /U

Environment

Host OS: Mac

Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Layer5 site in Figma (open invite)
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

I attempted to solve this issue by upgrade to Docsy v0.10.0. No luck.

The issue here seems to be the difference between Hugo 0.124.1 and Hugo 0.126.


cadence-proxy: Large message transmission fails

The Test_EndToEnd.Workflow_Echo test is failing with cadence-proxy returning a bad request error.  This test calls a workflow that attempts to return successively larger byte arrays up to 10MiB.
cadenceclient/helper.go:483     failed to create workflow       {"error": "BadRequestError{Message: Blob data size exceeds limit.}"}

It looks like this is failing with 2MiB byte array.
  I've configured the .NET HTTP servers to allow request bodies of up to 15,000,000 bytes.  If this is a Cadence limit, is this limit configurable?
My latest changes were pushed to cadence.

This link suggests that Cadence limits may be quite a bit smaller than 10MiB:
https://news.ycombinator.com/item?id=19732447
Folks really shouldn't be slinging around data this large in workflows and activities anyway.  I'll let you investigate this, but I'm probably going to reduce the maximum message size to 1.5MiB which will support byte array payloads of up to 1MiB (after they've been base-64 encoded and along with some JSON and message overhead).

https://www.gitmemory.com/samarabbas
Search for blob.

So after some exploration it looks like the cadence-frontend server BlobSizeLimit is set to a strict 2MiB (210241024).  The server should throw an internal warning @ ~256KiB (256*1024).  For the history service the BlobSizeLimit is a little larger (20MiB).  These are values that are hard coded and cannot be changed it doesn't seem.
FrontedService config:  https://github.com/uber/cadence/blob/master/service/frontend/service.go
HistoryService config:  https://github.com/uber/cadence/blob/master/service/history/service.go

This configuration also happens on the server side when the cadence server is launched and is not something that we can configure from the client.  I can ask if this might be something that they can expose so that we can set it when configuring our cadence cluster.

OK: I’ve removed any request size limitations on the .NET side and also reduced the maximum payload byte size to 1MiB so the test will pass.

Great.  I just edited the test as well so that the loop signature is:
for (int size = 1024; size < 2 * 1024 * 1024; size *= 2) {}

I’ve already done that in the JEFF branch and have som other changes.  I’ll
push to cadence when I get in (leaving lunch now].
—Jeff
On Fri, Aug 9, 2019 at 12:36 PM Jack Burns<EMAIL_ADDRESS>wrote:

Great. I just edited the test as well so that the loop signature is:
for (int size = 1024; size < 2 * 1024 * 1024; size *= 2) {}
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nforgeio/neonKUBE/issues/614?email_source=notifications&email_token=ABFOLD336Q37OVMGPUJEO4LQDXBNXA5CNFSM4IKV3XD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37SVJY#issuecomment-520039079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABFOLDYQOJEUM636WZLYFWTQDXBNXANCNFSM4IKV3XDQ
.

Ok i'll just leave it as is then.  We are about to head to grab a quick bite so will probably see you when we get back.


Add method to expose TreeItem identifier?

Hi, I would like to implement the ChangeSelectedAsRoot feature, which requires obtaining the identifier of a TreeItem for positioning purposes. I have found that there is no method available externally to access the identifier of a TreeItem.
Maybe something like TreeItem::get_identifier(&self)? If you approve my request, I can open a PR to implement this.

I would like to implement the ChangeSelectedAsRoot feature

I am curious what that is 👀

I have found that there is no method available externally to access the identifier of a TreeItem.

Would the upcoming #34 suit your needs for that? It’s way more based on nodes and the identifiers so it might improve that situation and also help with your use-case?

I need to place a TreeWidget in the TUI to display a directory structure, but when the opened directories become "deep," the entire tree looks "ugly" (it becomes very wide). Therefore, I want to implement a feature that allows the selected item to become the "root," occupying the entire TreeWidget, which would let me focus on a particular opened directory.
To achieve this feature, I need to locate a specific TreeItem. However, currently, TreeItem doesn't expose its identifier, so I need to find another way to accomplish this.
In any case, thank you for your response, and I look forward to seeing the #34  implementation.

After some attempts, I found that I still really need it. Could you merge #38? I need it for testing before #34 is implemented.


Changelog

Reference Issues/PRs

Fixes #162
What does this implement/fix? Explain your changes.
This adds a Changelog to the documentation. It includes 0.1.0 as well as the changes we will be adding in 0.2.0.
It also fixes a minor grammar issue in ctclassifier docs.
Any other comments?
This PR shouldn't be merged probably until right before we are going to release 0.2.0, so we can make any last minute changes to the changelog if needed. Just putting this PR up to prepare.

where did the joblib requirement come from?

It will come from Pr #164


Add editor tests to CI

FYI @antonkast-google

See https://github.com/Open-Reaction-Database/ord-schema/runs/735786114 for test results/log.

LGTM


Add tests to ensure that event readers for mousewheel and mouse motion are not double counting

Which code could be improved?
See https://github.com/Leafwing-Studios/leafwing-input-manager/blob/cfa8759212049244a88d0fb173271c1cda740e1c/src/input_streams.rs#L176
If our logic is wrong, we may be seeing events for two frames, rather than just one. We may need to cache additional information to fix this.

Testing strategy.

Send an event.
Check that an action is triggered.
app.update().
Check that the action is not triggered in the next frame.

Proposed fix: just add an Axis<MousewheelX> and so on resources, and then just read those values. Should be much simpler than trying to cache values otherwise.


CachePoolChain should implement TaggableCacheItemPoolInterface

Question
Answer

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
yes

License
MIT

Doc PR
reference to the documentation PR, if any

Description
TODO

[ ] Add tests
[ ] Add documentation
[ ] Updated Changelog.md

Looking good, I merge it later, need to fix the requirements..

I'm on my phone but, didn't you miss to add the tag funktion?

@somework can you rebase :) fixed the requirements


Shortcut for opening color picker and insert color of selected format

Problem
A huge dealbreaker for me is that VSCode just doesn't let me use the color picker ever, because I'm using Sass files. There does not seem to be any color picker extension that provides the functionality either, that isn't Windows-specific (I'm running macOS).
Feature request
I'd like the ability to spawn a color picker anywhere. So there would be a command that does exactly that, and when you're done it inserts the color code.
A nice inclusion would be if it could know if the cursor is in a color code, and accordingly update that color code. VSCode seems to do this only in a few file types now, which is a bummer for anyone not using those. I don't demand this, as long as I can get a color picker I'm content.

I'd love to see this feature aswell, +1.

I'm closing this as Sass do not have a language server, which is needed to support this feature.
A simplified explanation as to how color picker works:

VS Code ask language server of a language X: "What's the colors in a document?"
LS responds with a list of code ranges that represent colors in the document
VS Code renders a color box (picker) next to the colors

CSS/Less/Scss have language servers that can respond with color information properly. Sass doesn't have a LS to begin with.

@octref That was not the main thing this is about. I want to spawn a color picker anywhere (using a shortcut), regardless of whether there's already a color code in the document or not.

@SpectralKH If you mean you want to spawn a color picker that doesn't have anything to do with the color code in a document, you can implement it as a Webview extension or look for existing extensions: https://marketplace.visualstudio.com/search?term=color picker&target=VSCode&category=All categories&sortBy=Relevance

@octref None of the existing ones work for me (on macOS). This should be built-in and consistent between platforms.

If you mean you want this kind of color picker, but for Sass, see my response about Language Server above:

We have this component built-in, but we do not have resource to add support for each language so it shows this color picker component.

@octref I want that color picker brought up by a shortcut anywhere.

 Then I'd pick a color and press enter or something for the color code to be pasted in.
To change the type of color code type (HEX, RGB, etc) to paste in, you could

Have the place that says "rgb(0, 0, 0)" be clickable, to toggle between color code types
Have the place that says "rgb(0, 0, 0)" be clickable, to open a drop-down menu with color code types.
Have a bar with different buttons like this:

For that I suggest you use an alternative tool, like Sip app https://sipapp.io. But anyway, I'll keep it open and I've updated the title.

I'm looking for the same functionality. Considering this color picker is already there...

I am trying to specify colors within strings inside a javascript object.  Would LOVE to have color picker available to change on the fly instead of going to browser, finding hex codes from designer app, copying, going back to vscode, carefully selecting the right hex code, pasting in, making sure not have duplicate # characters, making sure the string isn't ruined by whitespace or missing " character, etc.

Same problem using JSX... Isn't there any command to force launch the picker on whatever file extension and then just paste the result in the text?

looking for a color picker in JS / React native files...

I really would like a color picker to open in any source file type!

same problem in any js file)

Just wanted to add my voice to the chorus of developers: the VS Code color picker (which is nice!) should be invokable with a keyboard shortcut, from any filetype.
The UX decision to make it appear on hover, of course, only works on certain filetypes. It's probably not simple to add every filetype to detect color objects. This decision traded elegance for a fairly big limitation (and didn't take into account how devs work with color strings, which seems to be all over the place).

Same here. It's such a generally useful thing these days, especially with the amount of inline styles in jsx/tsx.

I really am surprised this doesn't exist, in VSCode or in extensions. I was trying to edit a JSON file that contained hex color definitions in it (a configuration file for something) and there's just no way to get a decent editing experience in that case. One extension shows/renders the colors, so that's half the story, but no easy way to pick/edit.

I ran into this problem myself, so I built a color picker extension that can be opened anywhere and works without any dependencies. Here's a link, or just search 'vscode-color-pick'. Very basic so far, but I've already found it useful while writing JSX. I'd love feedback about what features could be added to make it more useful.

My aforementioned extension Color Pick now supports rgba().

Yes, please add the ability to assign a keyboard shortcut to opening the native color picker. Why? (a) Even when a color preview square is showing, sometimes the "hover" behavior to show the picker is finicky and unreliable (need to mouse out and over multiple times to get it to show). (b) For files for which VSCode does not recognize colors. For example, I have a PHP file with an HTML

Set this setting to "true" in settings.json.
"editor.colorDecorators": true

Set this setting to "true" in settings.json.
"editor.colorDecorators": true

What will it give you? This option disables the color picker and we can not launch it from any keyboard shortcut

Any news?

Tried out the "Color Pick" extension mentioned just above.  Not bad.   Though appears you have to manually copy the hex string over to the "Color Pick" tab.   Better than going to a separate browser, but still looking for a smoother solution here.

Trying "Color Manager" by Roy Action.  It's pretty good.  Copies your highlighted color into the color editor, pretty decent tools for tweaking the color, then a big button to insert back to the color where you started.   Works fine for me in a JSX file.   Looks like it was created just last month.  I like it so far.

@cburkins Color Manager seems pretty good, I'll probably start using it. I only wish that the color picker could float in the document just like VSCode's native one.
Not sure what's stopping VSCode from detecting colors the same way several extensions do?

@SpectralKH Amen to that.  Love VS Code, and this is one of those small tweaks that would make my world better.  But after waiting for a year, definitely game for "any port in a storm" :)

Chipping in, this would be very helpful. If it could just be spawned with a shortcut that would be great.  Was hoping it would work with custom css-in-js libraries like emotion. ❤ ❤

+1 I've left VScode and gone to brackets until this is fixed, it's a huge pain in the arse trying to experiment with colours in a site without a colour picker.

It seems a really poor UX decision to have such a widget exist, and have no language-agnostic way to access it.

I want to leave my support for this kind of feature. It's appalling that I should need to download an extension or use a separate browser window when there is an otherwise perfectly acceptable color picker already built-in. Please consider taking the time to make this possible.

I would like to give this a shot, but I would like to gather your feedback first (Not sure who takes responsibility here, @rebornix or @octref?)
My idea would be a command Insert Color which works like the following:

If no text is selected, it opens a color picker. When the color is changed/confirmed, the corresponding rgba/hex/hsla snippet is inserted and selected. Further edits will modify this selected text.

If text is selected, it opens a color picker and tries to guess a color out of the text selection. When the color is changed/confirmed, the selected text will be replaced by the new color. Further edits will modify this selected text.

Remarks:
The current color picker does not have a confirm button or similar, since it will simply disappear when the cursor goes out of its bounds. When spawning it via command, I think it has to have some kind of confirm/ok button, which will dismiss the color picker.
It would also make sense to spawn the color picker near the cursor, similar to the CSS Hover color picker.

It might be worth downloading Brackets and trying their colour picker, because IMO that's a perfect implementation - you press 'ctrl+e' to select a colour on any instance no matter what file you're in, and it pops up the editor. The editor doesn't need an 'ok', but it needs to be closed (either with the same shortcut or with the close icon).

@JohnnyCrazy Sounds great! Been waiting a long time for this feature, so really appreciate that you'd like to try implementing it.
The only thing is that I don't think it's necessary to have a confirm/ok button. I would say that in this case it's enough to use enter, esc or just click somewhere.
It would also make sense to have the editor.colorDecorators setting only disable the on-hover color picker. Even more logical would be to separate the on-hover color picker into it's own setting, like editor.showColorPickerOnHover, which is pretty much what #34341.

After thinking about it some more and fiddling around with the color picker code, I'm currently more stuck on a conceptual question: Which process decides which color formats are suitable for the current file?
Background:
The hover color picker is very smart. It queries the LSP server of the current language which color representations are supported. The LSP Server then answers with rgba(...), #hex etc.
This is super convenient since only supported formats can be selected and switched to. Now image a color picker in a JSX/C# file, which maybe doesn't have a general definition of a color representation like CSS/SASS/Less.
Solutions:
Sensible Defaults
Use defaults, which are mostly language agnostic. For example:

#FFFFFF(FF)?
255, 255, 255(, 255)?
0, 0%, 100%(, 1)
This may work for a lot of languages, but could be problematic in edge cases (e.g HSLA needs to be in .0 notation instead of percentage)

LSP driven´
The LSP Server could be queried for a color representation. However, this is not going in the direction of a general color picker as it depends on having a color-representation aware LSP. Some languages may not even have a unique color representation (C#? JS without Web?)
A hybrid solution would also have a nice touch. Always supply the sensible defaults and replace them if the LSP is color aware.
What do you guys think?

That issue did cross my mind after I first posted in this thread. I think it is surprisingly tricky to get this right without an overly cluttered UI, while satisfying users of more unusual languages.
I agree that relying on LSP seems like the wrong option because in some cases the representation will be down to the particular library being used.
Personally, I'd love to have the option to specify a custom format. For example, in Haskell/Elm/etc. I'm likely to have a type along the lines of:
data RGBA = RGBA
    { red   :: Word8
    , green :: Word8
    , blue  :: Word8
    , alpha :: Word8
    }

so that, rather than "FFFFFFFF", I'd write RGBA 255 255 255 255 or RGBA 0xff 0xff 0xff 0xff. If the colour picker allowed me to use this directly by specifying the format as something like RGBA %r %g %b %a` (and remembering it) then that would make me very happy. Obviously such a system would also have to provide the means to specify whether the fields should use hex, decimal, floats in the range [0, 1] etc.
I think that the above, complemented with built-in options for the common formats, such as in the Brackets screenshot a few posts up, would probably just about please everyone.

@JohnnyCrazy At least in general I think it would make sense to remember what format was last switched to. So, when the color picker is open and the user switches to another format, that new format will be used next time.
When a file of a language is first opened, you could just set a default. Probably either hex or rgb (Not sure which is more popular, I vote hex)
For languages that don't have a syntax implementation for colors, I don't think it's something that needs to be supported.
Not too familiar with LSP, but perhaps language extensions could specify if colors are different from the defaults. For example that rgb is specified using decimals.

@georgefst
I also had the thought about having a custom setting for the formats of the "defaults", but like your example shows the system has to be quite configurable and I'm not sure that we can catch all possible semantics of different languages. And in the end I'm not sure a color picker justifies an extensive and complicated configuration 😅
@probablykasper
Definitely, initial formats should be remembered on a per-language basis.
What exactly do you mean with languages that don't have a syntax implementation?

Not too familiar with LSP, but perhaps language extensions could specify if colors are different from the defaults. For example that rgb is specified using decimals.

If the language has LSP support and has a color representation registered, sure, should work.

Right now, my feeling tends to a color picker with sensible defaults (and maybe a fallback to LSP if color-representation support is there) for the first implementation. If the core team agrees that a configuration of the color representations is needed, we can still add it at a later point in the process.

@JohnnyCrazy

What exactly do you mean with languages that don't have a syntax implementation?

Was referring to languages where you couldn't just write #FFFFFF, but you'd need to use structs/classes/etc (From what I could tell, C# is one of those).

If the language has LSP support and has a color representation registered, sure, should work.

Does it need to have LSP support? Couldn't this be an option specified in the VSCode extension itself?

I think it's a good plan to have a set of default formats taking backup from an LSP server if available.
However, I also have to voice support for extra configuration per langauge / user as per @georgefst's comment. I think a big part of the main issue at hand is that the color picker wasn't versatile enough, so I think it's important not to make the same mistake with this one.
I feel that understanding syntax along the lines of RGBA %r %g %b %a adds a lot and would not over-complicate the picker for users.

Does it need to have LSP support? Couldn't this be an option specified in the VSCode extension itself?

I have the feeling this would be a duplicated configuration. If a language has a clear concept of color representations, the LSP should have support for it. If not, a syntax extension is not able to provide one either, since it is opinionated on a project-basis.

I feel that understanding syntax along the lines of RGBA %r %g %b %a adds a lot and would not over-complicate the picker for users.

Yes, after thinking some more about it, I agree that such a configuration of color representations make sense. 👍

Experimental stuff with LSP supported languages:

In the example above, I didn't have to select the first hex value because we have line decorators, which tell us the range of the color under the cursor. Those line decorators are not available when there is no LSP support for the language. Now, if we consider default/configurable color representations, detecting the color only based on cursor position could have quite a performance impact. I'm thinking of limiting color detection in this case to only a selected range. If none is supplied, it will auto insert a new color.
Before continuing further with a PR and a concept of default/configurable color representations, I'll wait for feedback from @octref / @rebornix to confirm I'm on the correct direction.

@JohnnyCrazy

I didn't have to select the first hex value because we have line decorators, which tell us the range of the color under the cursor. Those line decorators are not available when there is no LSP support for the language

This means that for any language where color decorators aren't shown, detecting the color format from the LSP wouldn't work? I'm not sure how many syntax/language extensions show color decorators, but at least my CSS preprocessor of choice (Sass) doesn't.
How would an extension developer implement support for this?

detecting the color only based on cursor position could have quite a performance impact
Would it be that significant? I would think you only need to read a range around the cursor and somehow detect the color in there. Sounds like it would be nothing compared to parsing an entire file for syntax highlighting.

I believe this is the code that parses color values in Atom's color-picker extension. I don't think there have been any performance issues with it.

This means that for any language where color decorators aren't shown, detecting the color format from the LSP wouldn't work? I'm not sure how many syntax/language extensions show color decorators, but at least my CSS preprocessor of choice (Sass) doesn't.

It will be able to detect the color as long as you select it beforehand. But I will have to do some experiments regarding performance first. Maybe we can also run the color detection regex on the whole line, which would enable color detection without any selections to be done beforehand! :)

How would an extension developer implement support for this?

AFAIK if your LSP supports Document Color Request, it should work automatically. The SASS extension also supports it, but only on hex and rgb:

@JohnnyCrazy Running the detection on the selected line is a great idea, that should do the job.
My bad, so the Sass extension supports it, just not Vetur.

I'd like the ability to spawn a color picker anywhere.

My idea would be a command Insert Color which works like the following:

If any of you use macOS I'd like to invite you to try my new extension:
https://marketplace.visualstudio.com/items?itemName=dae.vscode-mac-color-picker

It invokes the native color picker (= built-in into macOS), hence it opens and works fast and the codebase is very tiny. Also, the eyedropper can be used outside VS Code window. It works exactly like the "Insert Color" feature in TextMate, which I missed badly after switching to VS Code.
In TextMate, I think there was an API to invoke the OS-native color picker. With VS Code I had to resort to AppleScript and make it macOS only.

Still waiting in 2021 for the feature to show color picker at will...

Why can't vscode have a setting to enable color picker outside of html and css files?

Based on @octref explanation about the language server limitation for certain files, and given my need to have color picker on a .json file,  I search with those terms and found this useful plugin. I hope it can help someone!

With the json-color-token 1.2.0 extension, you can specify which language types to invoke a HEX color picker. You can see I enabled the color picker is enabled for json, jsonc, python, and toml files. (See https://github.com/YECHUNAN/json-color-token/issues/2 for explaination).

Let me save your lives:
Name: vscode-color-picker
Id: antiantisepticeye.vscode-color-picker
Description: let's you use vscode's css color picker in other documents
Version: 0.0.4
Publisher: AntiAntiSepticeye
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=AntiAntiSepticeye.vscode-color-picker

Let me save your lives:

That is useful, thanks. Even if it's some way short of the kind of truly language-agnostic approach I envisaged in https://github.com/microsoft/vscode/issues/52364#issuecomment-618656616.

Found not way to spawn color picker in PHP files, someone managed to do this ?

Found not way to spawn color picker in PHP files, someone managed to do this ?

Yes. See https://github.com/microsoft/vscode/issues/52364#issuecomment-1002634176.

Found not way to spawn color picker in PHP files, someone managed to do this ?

Yes. See #52364 (comment).

Never mind just saw I has to add the php language into the extension parameter to supported languages.
  "vscode-color-picker.languages": [
      "php",
      "json",
      "python",
      "javascript",
      "typescript"
    ]

If #178242 is limited to CSS-formatted colours, that's kind of disappointing. Just because most popular languages have so much ceremony around using custom datatypes that everyone prefers to use strings for everything, doesn't mean the rest of us should suffer!
At the very least, is there a reason why the last line of the screenshot doesn't seem to trigger the color picker? If rgb(r, g, b) weren't required to be in quotes, then the functionality could be used in most languages by defining a suitable rgb function (e.g. in Haskell, rgb(r,g,b) = RGBA r g b maxBound, though I'd have to disable my formatter at every use site to avoid a space between b and ().

The standalone color picker works for other language formats provided you have an extension installed that defines a DocumentColorProvider. The demo in the video, shows the default behavior when no extensions are installed, so that the user can still use the color picker when no DocumentColorProviders are present. The default is the CSS format.
The last line does not trigger a color, because there is no color present there. The new added default document color provider detects if there is a CSS color, and initializes the color picker with that color. If no color is detected, the default RGB(0,0,0,1) is chosen.
rgb(r, g, b) does not have to be in quotes. The only reason it is in quotes inside of the video is so that the compiler does not throw errors.

Ok cool, that's much more promising than I expected, thanks! I might have to try writing a colour provider extension for more idiomatic Haskell syntax, but it sounds like the "default" CSS one will be usable.


Improving navbar

Hey @Arun9739 I want to improve the navbar of your website. I want to add icons and also the right part of navbar is not aligned to the page which is looking odd. I can fix it. Can you please assign me this issue. Thank you!

Hey @Arun9739 I have made some changes in the navbar, hope you like it.
Before :

After :

Can you please assign this issue to me.

Go ahead @sumitkr2000
Show your support by starring the repo ⭐

@Anurag-Singh-04 Plz look for other issues or create new issues
Show your support by starring the repo 🌟

@Arun9739 Thank you for approving

@sumitkr2000 Finish your task early

@Arun9739 I have already done this task...you can close this issue now.

@sumitkr2000 OK thanks :)


CASMCMS-8203: cmsdev: Do not dereference null points in VCS test error paths

Summary and Scope
While looking into a Gitea problem on starlord I stumbled across a case where the cmsdev VCS test tries to dereference a null pointer and has an ugly crash. This is in the error path of the test, and isn't the cause of the test failure. But it does cause the cmsdev suite to crash instead of running the rest of its tests.
After I identified the problem, I spotted one other place where it existed in the code. This PR corrects both. The fix is very simple -- delete the two lines of code which are using the null pointer. They were accidentally cut and pasted from other locations and were never meant to be there.
Issues and Related PRs
This resolves CASMCMS-8203.
This was found during debug of CASMTRIAGE-4074.
Testing
I tested this on starlord. The test still fails (as it should), but without all the dramatics.
ncn-m001:/tmp/q # ./usr/local/bin/cmsdev test -q vcs
Starting main run, version: 1.9.0, tag: X4nKd
Starting sub-run, tag: X4nKd-vcs
ERROR (run tag X4nKd-vcs): Command failed
Ended sub-run, tag: X4nKd-vcs (duration: 3.02428231s)
Ended run, tag: X4nKd (duration: 3.035709091s)
FAILURE

Risks and Mitigations
Extremely low risk. The two removed lines are both in error paths and both were only there to print error messages (which were already being properly printed by the lines that remain).
Pull Request Checklist

[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable

To reviewers -- even if you don't know Go, you can look up about 10 lines from the lines I removed and see that the lines are being removed from an else clause, and the then part of the clause is the case where the err variable is not null. Thus, in the else clause, it is null. Hence this badness.


vdk-impala: add Out Of Memory error handling

Add Out Of Memory error handling logic in the vdk-impala error handler.

I am wondering if we want to write a functional test that simulates out of memory query. That might not be easy.
Regardless you should test it against real system and describe how you test it in Testing Done in the PR. (hint: you probably know but you can install it in your existing prod or test vdk env with pip install -e <vdk-impal-dir>)

I tested these changes on our testing impala instance together with our Infra team and the logic for this change is the result of our testing and research we did around these issues and the Impala memory configuration and settings.

I tested these changes on our testing impala instance together with our Infra team and the logic for this change is the result of our testing and research we did around these issues and the Impala memory configuration and settings.

That was a bit unspecific. When something is tested manually, it's really good idea to describe it in a way that make the test reproducible by someone else. This way it can be peer-reviewed as well better.
For example. What is the configuration of the testing Impala instance used, what types of queries were executed, what specific memory and performance metrics were tracked and used for verification. In general you can summarize the research that led to the logic implemented for handling memory issues.


Revert containerd 1.6 + packages.microsoft.com apt change

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

fyi, I think the pre-revert change also breaks ARM 22.04 --
==> azure-arm: + for i in $(seq 1 $retries)
==> azure-arm: + timeout 25 curl -fsSL https://packages.microsoft.com/config/ubuntu/22.04/multiarch/packages-microsoft-prod.deb
==> azure-arm: curl: (22) The requested URL returned error: 404
==> azure-arm: + '[' 21 -eq 120 ']'

really should run a broader PR suite, maybe should add that to backlog

Closing, as we fixed the issue in another PR earlier


update for ShowerReco

Moved from InstrumentDescription to event.meta for instrument information
as has been pointed out by Karl in #244
additionally moved the score functions for the direction and position minimizer
outside of the fit class to improve modularity and testability (as proposed by
Max in #233#issuecomment-254495070)
also fixed incorrect rotation for ASTRI telescopes in io.camera._npix_to_type
added unit test specifically for the core fit

@kosack this passes the tests now and can be merged if there are no further issues.


Questionable behavior

https://ldjam.com/users/gulyasarni66
I'm told they're effectively rating a game per minute.

Maybe we could be a bit annoying and have a warning if ppl start voting less than a minute after they opened up a game. Or if when casting a vote,  the response says time since last vote and game id for that vote.

He responded to the people calling him out for it in his comments:

He just replied.

Okay so now that we know what happened, we know it's an education issue.
Once we get through all the "feature-features", that's the next big step. It's almost the worst case scenario when someone gets reprimanded for something they've done. I just wish folks understood that we need to educate, not eviscerate folks for doing things like this.

I'm stealing this dump from @sgstair:
Top-dgv:
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171205080015.json Node 66735 DGV 51.12
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171205090017.json Node 56139 DGV 35.26
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171205070021.json Node 58515 DGV 33.38
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171205090017.json Node 54439 DGV 31.88
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171205000019.json Node 53438 DGV 25.62
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171204220015.json Node 53438 DGV 24.38
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171204210027.json Node 58809 DGV 23.12
E:\scratch\ludumdare\ps_ldjam\snapshotGames_20171205060025.json Node 63635 DGV 23.00

The node is the game of the user that's "super-active".

Capturiong suggestions from IRC discussion and earlier gitter discussion: Implement a kind of rating timeout - Probably a warning if you're rating quickly (less than X minutes from first vote on one game to first vote on next game), and a hard block for rating a lot of games quickly (less than Y minutes from first vote Z games ago, to first vote on next game)
We could implement this efficiently by tracking some server-private meta on user nodes, and do a quick query on voting to determine if this is the first vote on the game. If so, keep a list of the last N timestamps of first votes.

As a side note, any mechanism provided here will need a bypass for the simulator, which votes early and often, and without regard to game quality :)

This game/user has more than double the ratings given of any other user/game at 508.
https://ldjam.com/events/ludum-dare/49/unstaball-1
https://ldj.am/$559


No way to get bug fixes + set version to 3.3 (so exclude 3.4 syntax)

From https://github.com/ruby/prism/pull/2118#discussion_r1445987020
@andrykonchin and I are looking at which version we'd set for truffleruby 24.0 (the next feature release where we'll switch to Prism).
We do want/need the flag from https://github.com/ruby/prism/pull/2118 to be set (as well as other fixes/improvements).
But with the current code in https://github.com/ruby/prism/pull/2118 that means we'd need to use PM_OPTIONS_VERSION_LATEST.
OTOH we do not want it handling from 3.4 (https://github.com/ruby/prism/pull/2124) for truffleruby (if at all possible).
And using PM_OPTIONS_VERSION_LATEST would enable it (when that PR is merged).
So how to solve this?
Maybe we need PM_OPTIONS_VERSION_CRUBY_3_3 (without _0) to mean 3.3 syntax with the latest fixes?
Alternatively, is it worth hiding the flag from https://github.com/ruby/prism/pull/2118 for Prism versions newer than the one shipped with 3.3.0? Maybe not?
It feels like this flag should not hurt anything, and if someone wants exactly the version of Prism as shipped in 3.3.0 then they can just specify that Prism release in their Gemfile.
In short adding PM_CALL_NODE_FLAGS_ATTRIBUTE_WRITE is not really a syntax change or different parsing or anything, it's just extra information or from a POV a bug fix for a missing flag.
@kddnewton WDYT?
Originally posted by @eregon in https://github.com/ruby/prism/pull/2118#discussion_r1445987020

Thank you, that works, then we'll use PM_OPTIONS_VERSION_CRUBY_3_3_0 in TruffleRuby to target Ruby 3.3.0 syntax.


UpNext feature

I'm submitting a ...

[ ] feature request

Would it be possible to integrate UpNext like Seren add on has?

If you install it, after install netflix addon ,you will see UpNext Integration on Playback Settings... but it does the same if you select Play from here on the contect menu while selecting the starting point...

Not sure if it work on 0.13.22, but it works en 0.14b23

How do I get version 0.14b23

Go Pull Requests then select Release 0.14.0 and find some links there, or use
Last one commited
https://github.com/CastagnaIT/plugin.video.netflix
Cheers

Clone it as ZIP and install it from ZIP... remember to uninstall 0.13.x and say yes when asked to  remove settings, very important.... remove the repository where you get .013.x or disable autoupdate

Thanks


⚠ Avatar API Endpoint has degraded performance

In e925a5f, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1929 ms

Resolved: Avatar API Endpoint performance has improved in b9c23c6.


investigate on chain calls in UI

Check whether the onchain calls on the UI are the same for the new gauge contracts.
e.g. bal rewards per second are not queried from the gauge contract any more

how to claim BAL and other rewards. Two calls? Can it be batched?


ci: do README update via stefanzweifel/git-auto-commit-action@v4

I tried it out here for a different repo: https://github.com/NVIDIA/VideoProcessingFramework/pull/446

Great!
Slightly unrelated, but how does VPF differ from PyAV? In my understanding PyAV is a python binding for ffmpeg so if nvidia decoder / encoder is installed on ffmpeg it can still use HW acceleration?
I also heard PyTorch's torchvision has video decoding feature that performs better than PyAV. I assume the nvidia one should be faster than both?

Great!
Completely unrelated, but how does VPF differ from PyAV? In my understanding PyAV is a python binding for ffmpeg so if nvidia decoder / encoder is installed on ffmpeg it can still use HW acceleration?
I also heard PyTorch's torchvision has video decoding feature that performs better than PyAV. I assume the nvidia one (VPF) should be faster than both?

This is a legacy one. It is more or less the same scope as PyAV but with focus on NVENC/NVDEC. The next iteration will have narrower focus but easier to use with https://github.com/CvCuda/CV-CUDA and Torch.
torchvision seems to use FFmpeg but doesn't seem to open a HWcontext (which would allow them to use HW accerlation) https://github.com/pytorch/pytorch/blob/233742cb2f5cc645afc3a511185c3ec59924f7de/caffe2/video/video_decoder.cc
In general, NVDEC/NVENC are faster because they are physical hardware circuits which is faster than software written on CPU. FFmpeg has support for NVDEC/NVENC which would allow PyAV/torchvision to decode directly on GPU to CUDA tensors.

This change will work more or less like that https://github.com/theHamsta/nvim-treesitter-textobjects/commits/master (tested on my fork's master)

Thanks. I used to use DALI but because of lack of operations on video (e.g. it was hard to load frames the way I wanted to) I stopped using it. I also remember the dataloader is a custom class type so it would be incompatible with many libraries that assumes Pytorch dataloader to be used. It was a long time ago so I'm sure they improved things by now.
CVCUDA looks great as well. I'll need to check it out. Is it new?

Thanks. I used to use DALI but because of lack of operations on video (e.g. it was hard to load frames the way I wanted to) I stopped using it. I also remember the dataloader is a custom class type so it would be incompatible with many libraries that assumes Pytorch dataloader to be used. It was a long time ago so I'm sure they improved things by now. CVCUDA looks great as well. I'll need to check it out. Is it new?

DALI is also NVENC/NVDEC accelerated

Is it new?
yes, it is still beginning of beta. Expect improvements.

Can you test on your repo what will happen if you modify the last section of readme by yourself? If you damage the section or completely remove it, will it fix the file or will it break things unexpectedly?
If the bot is opening a PR I feel more comfortable because it's okay to have some errors, but if it's directly writing to master we should be really careful not to mess anything up.
I also remember that this CI force pushes to the update-readme branch. However, we must never force push to master. I'd like to know if this is resolved

Can you test on your repo what will happen if you modify the last section of readme by yourself? If you damage the section or completely remove it, will it fix the file or will it break things unexpectedly?
If the bot is opening a PR I feel more comfortable because it's okay to have some errors, but if it's directly writing to master we should be really careful not to mess anything up.
I also remember that this CI force pushes to the update-readme branch. However, we must never force push to master. I'd like to know if this is resolved

No, this will not work. Our script only replaces the text between the <!--textobjectinfo-->  comment tags. <!--textobjectinfo--> should not be removed. It will break the old and the new workflow.

Can you test on your repo what will happen if you modify the last section of readme by yourself?

I don't understand, isn't this what I did here: https://github.com/theHamsta/nvim-treesitter-textobjects/commit/c5149451a5175c90e6e03f9f21b6ba76df511979

https://github.com/nvim-treesitter/nvim-treesitter-textobjects/blob/de9801d4f448df958d09fec60839e0a39d069610/scripts/update-readme.lua#L54-L58
How about you delete this line from the readme, so the lua script sees some unexpected README format?

Looks all good to me! The script got way simpler as well.

Wait, the master branch of this repo is protected. Did you also test with the protected master branch?

Wait, the master branch of this repo is protected. Did you also test with the protected master branch?

No, but there are actually no protections that require a PR. I'll test tomorrow

If it works with another repo then it should be good!

If I try to change directly in master it shows something like this.

The protected branch will cause problems
M	README.md
Your branch is up to date with 'origin/master'.
INPUT_ADD_OPTIONS:
INPUT_FILE_PATTERN: .
INPUT_COMMIT_OPTIONS:
INPUT_COMMIT_USER_NAME: github-actions[bot]
INPUT_COMMIT_USER_EMAIL<EMAIL_ADDRESS>INPUT_COMMIT_MESSAGE: Automated README update
INPUT_COMMIT_AUTHOR: theHamsta<EMAIL_ADDRESS>[master c5b060d] Automated README update
 Author: theHamsta<EMAIL_ADDRESS> 2 files changed, 364 insertions(+)
 create mode 100755 nvim.appimage
INPUT_TAGGING_MESSAGE:
No tagging message supplied. No tag will be added.
INPUT_PUSH_OPTIONS:
remote: Resolving deltas:   0% (0/1)
remote: Resolving deltas: 100% (1/1)
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: 3 of 3 required status checks are expected.
To https://github.com/theHamsta/nvim-treesitter-textobjects
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/theHamsta/nvim-treesitter-textobjects'
Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/index.js:17:19)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) {
  code: 1
}
Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/index.js:17:19)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)
0s

https://github.com/theHamsta/nvim-treesitter-textobjects/actions/runs/4632484922/jobs/8196595276

Okay, we can either keep it as is and make it create a PR, or we can make the master branch unprotected. I like the first option, but either is okay


prevent missing python warning when format feature not requested

When consuming this library through fetch-content, cmake warns about missing python on my system.

I think we should just remove it from cmake. For the time being, I'll merge this.


Overloaded method does not respect the "tag" option

<EMAIL_ADDRESS>It appears that if you have two overloaded methods with different media types and add a tag = {"User"} in the @Api annotation as follows:

The generated swagger output splits the operations into different panels and does not respect the tag annotation for the overloaded method.

Hmm. That's an oddish bug! Thanks for reporting. While the tags deftly don't match up, I would expect that you would still see bothe media types documented correctly in the findall method. IOW it should be semantically correct in in terms of wire representation.

Yes, inside findAll() I can select both media types in the dropdown on the swagger html output.

👍🏼 I'll look at why it's not respecting the tag.


riverpod_annotation exports Ref type.

Is your feature request related to a problem? Please describe.
It would be nice if riverpod_annotation would export the Ref for riverpod 2.6.0 support.
current (riverpod_annotaion v2.6.0)
import 'package:riverpod/riverpod.dart'; // ← Required for import of Ref
import 'package:riverpod_annotation/riverpod_annotation.dart';

@riverpod
Model foo(Ref ref) => ..

want
import 'package:riverpod_annotation/riverpod_annotation.dart';

@riverpod
Model foo(Ref ref) => ..

Describe the solution you'd like
Add the Ref type to the export list in riverpod_annotation/riverpod_annotatino.dart.
Describe alternatives you've considered
none.
Additional context
https://github.com/rrousselGit/riverpod/blob/master/packages/riverpod_generator/CHANGELOG.md#260---2024-10-20

It isn't exported on purpose.
The annotation package only exports what the generated code uses.
You're not meant to import riverpod_annotation as a replacement to Riverpod.