Send menu to private chats only

Describe the bug
I'm not 100% sure whether this is a bug or simply a result of a lack of understanding on my part. I want a menu to only be sent / be able to be called in private chats. The code I use (see below) seems to achieve this. It does, however, have the weird side effect that any message in a group chat triggers the hide function of a submenu. This can cause errors in my actual code as the hide function depends on user data associated with the private chat.
Thanks a lot in advance!
Versions
Did you update telegraf and telegraf-inline-menu to the latest version?

Version of telegraf: 3.33.3
Version of telegraf-inline-menu: 4.0.0

What version of NodeJS (and TypeScript) do you use?

Version of NodeJS: 8.10.0
Version of TypeScript: Not Used

To Reproduce
Use the minimal code provided below with a bot that has been added to a group. The menu functions normally in a private chat. In a group chat, the menu is not returned. Whenever any message is sent to the group, the hide function of the submenu is triggered. (Oh Baby! is logged).
const Telegraf = require('telegraf');
const TelegrafInlineMenu = require('telegraf-inline-menu');

const bot = new Telegraf("SECRET");

const mainMenu = new TelegrafInlineMenu("MainMenu");

const subMenu = new TelegrafInlineMenu("TestSubMenu");

mainMenu.submenu("submenu", "submenu", subMenu, {
    hide: ctx => {
        console.log("Oh Baby!");
    }
});
const mainMenuMiddleware = mainMenu.replyMenuMiddleware();

bot.command('test', (async ctx => {
    if (ctx.chat.type==="private") {
        await mainMenuMiddleware.setSpecific(ctx, 'upperMenu');
    }
}));

bot.use(mainMenu.init({
    actionCode: 'upperMenu'
}));

bot.launch().catch((err) => {
    console.error(err);
});

Expected behavior
Hide is only called when a menu is actually sent.

Hide has to be called whenever the menu is relevant. I explained that in #57.
In your case you can use Telegraf.optional to use a middleware (in this case the menu) only in a specific case → private chats. For private Chats there also exists Telegraf.privateChat:
bot.use(Telegraf.privateChat(menu.init({
	backButtonText: (ctx: any) => `🔙 ${ctx.i18n.t('menu.back')}`,
	mainMenuButtonText: (ctx: any) => `🔝 ${ctx.wd.r('menu.menu').label()}`
})))

bot.use(Telegraf.groupChat(otherMiddlewareThingy.middleware()))

Only messages which happen in private chats will be given to the middleware which is in this case the menu. All other messages pass through and the next middleware has to handle them.
I hope it helps!

That helps a lot! Thanks again


4-modules

https://buzrom.github.io/frontend-course-2021/homeworks/roman.buzukov_BuzRom/4-modules/

https://buzrom.github.io/frontend-course-2021/homeworks/roman.buzukov_BuzRom/4-modules/
I didn't get how to do asterisk task with given two functions. In my opinion, the easiest way is to use 'timezone'.

At least you should realize those two functions subtractHours and addHours.
And further, you should use it to calculate the time for a given city based on local time.
Sorry, but without it, I can't count the task with an asterisk as done.

Super, thanx, for your job


feat: Improve Search Section

Details:

Change layout, text size,...
Remove Action bar and replace by toolbar for better looks
Set up better search section in SearchFragment

Fixes: #1948
Screenshots for the change:

Please review the code and the UI first, for the background of SearchFragment, I'll make a better one later today and push another commit. The current background is temporary

In my opinion, it would be better if the options under Filter Search are on the left, with each option having the checkbox first and then the text, i.e., checkbox on the left of text.

Updated:


use getChannel instead of listChannel

The tool should use getChannel(ID) instead of running listChannels

PR #63 fixed this issue, closing it now


[terra-form-select] Mobile keyboard opens when selecting option with "search" variant

Bug Report
Description
When selecting an option with the "search" variant of terra-form-select, the keyboard will open after the option is selected. It seems like this would not be a desired behavior. Since the user has already selected an existing option it would follow that the user no longer has a need to search for other options.
Steps to Reproduce
This behavior is reproducible using the "search" variant example on the documentation page on mobile.

Open dropdown menu of options
Select an option
Keyboard is opened

Additional Context / Screenshots

Expected Behavior
If an option is selected from the dropdown menu of options, I would expect the keyboard to not open for searching purposes.
Possible Solution

Environment

Component Name and Version: terra-form-select with "search" variant
Browser Name and Version:
Node/npm Version: [e.g. Node 8/npm 5]
Webpack Version:
Operating System and version (desktop or mobile): mobile

@ Mentions

@neilpfeiffer
@mjhenkes
@yuderekyu

Closing as this is the intended behavior for the current component.
(Adding to ideas list for considerations in Future Component)
UX rationale:
The Search and Combo varieties are functionally when you break them down -- a basic input element, placed beside a dropdown select element (shortened to just the arrow icon with no label). Because of this, the interactions with the overall component follow the same rules of the elements as individuals: when interacting with the input, it places focus in the input and causes the keyboard to appear, but when interacting on mobile with only with the dropdown via the button, since assumption is the user is intending to look through the list not search through the list, so the cursor is never placed in the input and therefore the keyboard does not appear. It is not until after making a choice that focus is put on the input and the cursor appears (triggering the keyboard), which allows users to clear the phrase, or adjust for the combobox variant. This is consistent with other similar libraries like Semantic UI and Kendo UI for Angular. I would not expect that the keyboard never appears after selecting an option from the list of the search & combobox variants however.
We will keep this interaction suggestion in mind though as we start to rebuild Terra select components with accessibility-first approaches, something that rather than treating the component as two separated units placed beside each other, instead the full unit (input plus down arrow) could be treated like a single button - something more like Ant Design or Telerik for ASP.NET where any click on any part of the search/combo box both opens the list and places focus in the input with a cursor, immediately triggering the keyboard, and therefore keeps the keyboard up before and after selecting an option and only removes the keyboard when the entire component loses focus.
cc: @StephenEsser

when interacting with the input, it places focus in the input and causes the keyboard to appear, but when interacting on mobile with only with the dropdown via the button, since assumption is the user is intending to look through the list not search through the list, so the cursor is never placed in the input and therefore the keyboard does not appear.

@neilpfeiffer Can you confirm that the "search" variant is not meant to be used on mobile devices? I do not see this in any documentation.

@neilpfeiffer can you provide the location of the ideas list?  Who do I need to push on to make it happen?  The user experience with this component on mobile devices is not ideal, I think there needs to be more discussion about this.


fix: update mocha chai challenge text, code snippets

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Partially addresses #38837

This PR updates some of the text and code snippets for the Quality Assurance and Testing with Chai challenges based on updates in https://github.com/freeCodeCamp/boilerplate-mochachai/pull/42.
These updates should be deployed before https://github.com/freeCodeCamp/boilerplate-mochachai/pull/42 is merged.
Also, here's the completed project on Replit for testing: https://replit.com/@scissorsneedfoo/boilerplate-mochachai

Alright, I made a few commits to address the issues I found. Here's an updated project that passed https://boilerplate-mochachai-1.mot01.repl.co

Thanks for your thorough review and fixes both here and in the boilerplate, @moT01. They really improve the clarity and quality of these challenges :+1: :+1:


Youtube region restriction

Hello,
First, Thank you for made lavaplayer.
I am using lavaplayer well, but having some issue about Youtube region restriction. For example, this video cannot play outside of South Korea and Japan. The server that using lavaplayer is in Japan but It is not working with following error message.
This video contains content from PONYCANYON, who has blocked it in your country on copyright grounds.
What should I do for play video like this?
Thank you.

I don't think youtube will provide the video as long as you are connecting from within a restricted region. I think the only solution would be to use a proxy.

Sorry, It is my misunderstanding about Youtube region restriction.
The playable region of that video is only South Korea, not Japan. So cannot play in Japan.


Set up the project governance

Originally a sub-task of https://github.com/holoviz-topics/examples/issues/238.
Probably similarly to what was done for holoviz.org (https://github.com/holoviz/holoviz).

Yes, I think the examples org should just follow the regular HoloViz org governance.


Please use a build system such as Maven or Gradle

Yea, I was thinking the same, wanted to build the project but its quite hard without Maven or Gradle. Moving to Maven or Gradle will also allow others to build and in turn creates PR easier. I am willing to open a PR to move it to Maven if you want.

You are right. A bluish system like maven or gradle is the way to go. Never got around to do it yet. If @benwoo1110 can create a pull-request that would be great. Otherwise, I will do it myself sometime.

I managed to get maven compile running for the legacy version, but DeluxeTags dependency doesn’t have a public maven repo, so you still need that .jar manually downloaded, not sure any better way to do it. Also I am not very sure how you are going about the project structure for v2.0

That's great to hear! I've not used Maven before so thank you for helping out.
DeluxeTags is available on clips-public-repo I don't know if this might work?
The v2.0 part is just me trying some things out, it has no "good" structure right now. However, the Legacy is still active and will remain active until v2.0 has gotten to a usable state.

Nice, I will take a look at it!


Fix Superconductor.js Recipe Replacements

Fixes #157
This bug was introduced in this commit on the 1.20.1 branch. Manually reverting this change locally fixes the issue and allow the hammer to be crafted with any rods, but I'm not sure if this breaks anything else later on in the game.
My understanding of the mechanics of the bug is this:
Line 96 is this:
event.replaceInput({input: `#forge:${type}s/${material}`}, `#forge:${type}s/${material}`, `gtceu:${material}_${type}`);
type and  material are set in nested for each loops. In the first iteration of both loops, type = rod, material = soul_infused, and the line reads:
event.replaceInput({input: `#forge:rods/soul_infused`}, `#forge:rods/soul_infused`, `gtceu:soul_infused_rod`);
This line is then taking ANY recipe that takes #forge:rods/soul_infused as an input and replaces that input with gtceu:soul_infused_rod. This includes the recipe for the hammer, which takes #forge:rods, since #forge:soul_infused_rods is included in #forge:rods. Then in subsequent iterations of the loop, the recipe for hammer is already set to take #gtceu:soul_infused_rods, so the filters ignore this recipe.
This PR fixes this issue by adding an additional filter condition that excludes this type of generic recipe from the replacements. This should also fix any other recipes broken by generic dust, nugget, ingot, gear, plate, and rod item recipes. I've also added the same filter condition to the #forge:storage_blocks type. I've omitted the filter from the output replacement, since I don't think there are any recipes that output a generic item like this.

oh, amazing, thank you


EU login 5 fails because of MFA challenge

All accounts in my country Norway (personal and caretaker) require MFA (two-factor auth via email code). When I try to run minimed-connect-to-nightscout the EU login 5 stage fails because a MFA oauth challenge response is received instead of the expected result, so response.headers.location is undefined and the EU login 5 stage fails because of this.
Is there any workaround to this? Is MFA-support being worked on? Can I hack around it by pretending I live in a different country where MFA is not required? I really want to make this work as I always use my PC and seldom use my smartphone.
Thanks in advance.

Thanks for the information.  Can you outline a little more about what you are trying to accomplish?  It sounds like https://github.com/benceszasz/xDripCareLinkFollower might be a good fit.  Is it able to log into your Medtronic Carelink account?  There have been issues with minimed-connect-to-nightscout` plugin, and most people use it as a built-in plugin for Nightscout.  This typically runs on a server in the cloud rather than a local computer.  The technique using xdripCarelinkFollower does not require any active use from the phone or the app.  Once set up, it passively copies data from Medtronic Carelink servers to Nightscout server effectively.  xdrip doesn't need to be in proximity to any of the devices.  We have some tasks on our roadmap to make sure that we are using the same log in techniques correctly.  If these enhancements don't solve the issues, we may be forced to deprecate this particular module.  Hope this helps.

Hi. Thanks for your reply.
What I am trying to figure out is whether Carelink accounts with two-factor authentication (MFA) are supported by this project, and if not if this is being worked on. MFA accounts are required for accounts in my country, so I have no way to disable it. If anyone know of a workaround that could be handy as well.
The two factor process require me to enter a 6-digit code into the login web page after entering username/password, and the code is sent to my email address. However, subsequent logins don't necessarily require this type of verification code to be sent and typed in. I suspect if the oauth token is reused and refreshed you will almost never see that happening again.
I don't know if this MFA requirement is specific to my country (Norway), but I suspect most other European countries will require this as well. I am a bit curious why this isn't a known issue in the community at this point, but I might have misunderstood something entirely.
I was planning to set up a dummy email address and use that for my carelink account, poll the email server when a two-factor auth code was required and then pass that onto the login process, but as I see it now the code doesn't support two-factor authentication and I have no idea how to implement that.


Missing table and chairs in Winterhold inn

Describe the bug
Missing table and chairs in the Winterhold inn

Might be an issue caused by the Holds patches?
#9

Another weird one for Winterhold.  The general store's counter disappears when you get close to it.

Another weird one for Winterhold. The general store's counter disappears when you get close to it.

This seems to be caused by a texture that is only visible from below blocking your line of sight you can crouch under it to clearly see the cause

Describe the bug Missing table and chairs in the Winterhold inn

On my save, the table is loaded but gets moved to be adjacent to another table as soon as the interior of the inn is loaded.


Allow reshape() to work on OwnedArray

Relaxing the type constraints from DataShared to DataClone allows reshape() to be used on OwnedArray as well. Looking at the definitions of DataClone for Rc<Vec<A>>, this won't change anything for Array.

Note that into_shape() already exists and works with owned arrays.

I noticed that there is also into_shape(). Is there a reason why both are around? When I tried using reshape() this morning it was unexpected that it didn't work on my OwnedArray.

into_shape is less flexible, but works with all arrays (views too). Since it does no copying, it can't rearrange everything.
This addition makes sense, it's just the panicking and error rules that strain.

Reshape: Succeeds if new shape has the same number of elements as old shape. Clones when needed (always needed for OwnedArray, sometimes for Array).
Into_shape: Requires same number of elements, as well as a contiguous layout (or reshapeable layout)

The simpler contract for reshape (must be the same number of elements) sort of allows it to use panic for error handling. It would fall under contract violation. It makes sense into_shape has more detailed error handling, since it has more complicated requirements to be able to succeed.
What do you think about the error handling aspects?
reshape's docs need to be updated to reflect that it clones all elements. It should note that in particular for Array, when the layout is compatible, it can avoid cloning.
In the end it's a bit unfortunate to have two methods. It's a result of the evolution (Array and reshape used to exist, into_shape was added to support views).

As far as I can tell, reshape() was there originally but was designed to work with Rc-based storage. It can clone the data if necessary. into_shape() is lighter as it will never clone the data, but that comes at the cost of possible errors. So I think there is a need for both.
Maybe there should be a "See also" section in the documentations of these methods to point at each other.

It seems like there is indeed a lot of redundancy in here. In the case of OwnedArray, reshape() copying data does not make any sense. Also, I am not sure if it is obvious to the user that reshape() will yield another strong pointer to the data in the case of Array.
I think it would be good for the user if he needed to ensure contiguity of the data explicitly, leading to the following points:

provide a make_contiguous() method;
rename into_shape() to `reshape();
never clone/copy any data;
only change the fields strides and dim;
maybe change ShapeError into ContiguityError, but keep the Result<> error handling of into_shape().

Copying the data makes sense, because that's what enables reshape to handle more input configurations successfully than what into_shape can do.
Still, a factorization into independent features is always attractive, for example fn make_contiguous(self, layout: Layout) -> Self which may clone.
I wonder if there's an algorithm for relayouting the elements in place, regardless of their input layout.

I'm not sure how we should resolve .reshape(). Should we remove it?

How about having reshape return a view and panic on all situations that would require cloning, and adding a reshape_clone method that always clones? Thus a user would have to be sure about the layout to use reshape, but would have no cost. Somehow this proposal is a shortcut for a.view().into_shape(shape).unwrap().

I like @vbarrielle suggestion. I think we should keep .reshape() simply for the fact that I believe a consumer would expect a method of this name to be around.


I2C Example - Error Reading Variable

I'm having difficulty implementing the I2C example:

MCU: STM32L071
stm32l0xx_hal version: 0.5.0

#![no_std]
#![no_main]

extern crate panic_semihosting;

use cortex_m_rt::entry;
extern crate stm32l0xx_hal;
use stm32l0xx_hal::{pac, prelude::*, rcc::Config};

#[entry]
fn main() -> ! {
    let periph = pac::Peripherals::take().unwrap();

    let mut rcc = periph.RCC.freeze(Config::hsi16());
    let gpioa = periph.GPIOA.split(&mut rcc);

    let sda = gpioa.pa10.into_open_drain_output();
    let scl = gpioa.pa9.into_open_drain_output();

    let mut i2c = periph.I2C1.i2c(sda, scl, 100.khz(), &mut rcc);

    let mut buffer = [0u8; 2];
    const ADDRESS: u8 = 0xFF;

    i2c.write(ADDRESS, &mut buffer).unwrap();

    loop {
    }
}

When debugging using GDB, I get one out of a variety of errors when I stop debugging, such as:
^C
Program received signal SIGINT, Interrupt.
0x080009d8 in stm32l0::stm32l0x1::i2c1::isr::<impl stm32l0::generic::R<u32,stm32l0::generic::Reg<u32,stm32l0::stm32l0x1::i2c1::_ISR>>>::txe (
    self=<error reading variable: Cannot access memory at address 0x20004e3c>)
    at /home/gies/.cargo/registry/src/github.com-1ecc6299db9ec823/stm32l0-0.9.0/src/stm32l0x1/i2c1/isr.rs:801
801	        TXE_R::new((self.bits & 0x01) != 0)

^C
Program received signal SIGINT, Interrupt.
0x080009e8 in stm32l0xx_hal::i2c::I2c<I,SDA,SCL>::send_byte (
    self=<error reading variable: Cannot access memory at address 0x20004dd4>,
    byte=<error reading variable: Cannot access memory at address 0x20004dd8>)
    at /home/gies/.cargo/registry/src/github.com-1ecc6299db9ec823/stm32l0xx-hal-0.5.0/src/i2c.rs:183
183	        while self.i2c.isr.read().txe().bit_is_clear() {}

^C
Program received signal SIGINT, Interrupt.
core::cell::UnsafeCell<T>::get (
    self=<error reading variable: Cannot access memory at address 0x20004db0>)
    at /rustc/4560ea788cb760f0a34127156c78e2552949f734/src/libcore/cell.rs:1539
1539	/rustc/4560ea788cb760f0a34127156c78e2552949f734/src/libcore/cell.rs: No such file or directory.

^C
Program received signal SIGINT, Interrupt.
0x080009bc in vcell::VolatileCell<T>::get (
    self=<error reading variable: Cannot access memory at address 0x20004e38>)
    at /home/gies/.cargo/registry/src/github.com-1ecc6299db9ec823/vcell-0.1.2/src/lib.rs:32
32	        unsafe { ptr::read_volatile(self.value.get()) }

I'm relatively new to Rust. Is this an issue with the I2C example, or am I missing something else? Any assistance would be greatly appreciated.

@DanSGiesbrecht see #39. we're also using the STM32L071 and hit the same strange issues :slightly_smiling_face:

Thanks for pointing that out! Going to test tonight - if that's my only issue, I'll close this PR.


PHP8.3 compatibility fixes

fixes https://github.com/coral-media/php-ml/issues/3
this was fixed automatically with Rector using the config
<?php

declare(strict_types=1);

return (static function (\Rector\Config\RectorConfig $rectorConfig): void {
    $rectorConfig->paths([
        '/home/hans/projects/php-ml/',
    ]);
    $rectorConfig->sets([
        //\Rector\Set\ValueObject\LevelSetList::UP_TO_PHP_82,
        \Rector\Set\ValueObject\LevelSetList::UP_TO_PHP_83,
    ]);
    $rectorConfig->skip([
        Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector::class,
        \Rector\Php80\Rector\Switch_\ChangeSwitchToMatchRector::class,
        \Rector\Php80\Rector\FunctionLike\MixedTypeRector::class,
        \Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector::class,
        \Rector\Php73\Rector\FuncCall\ArrayKeyFirstLastRector::class,
        \Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector::class,
        \Rector\Php80\Rector\Class_\StringableForToStringRector::class,
        \Rector\Php70\Rector\FuncCall\RandomFunctionRector::class,
        \Rector\Php83\Rector\ClassConst\AddTypeToConstRector::class,
        \Rector\Php81\Rector\ClassMethod\NewInInitializerRector::class,
    ]);
});

as for why i disabled many of the rules: many of them are just personal-preference changes, and some of them break php7.4 compatibility, and none of the disabled ones are required for php8.3 compatibility.

On it, please make sure you follow conventional commits next time, I use some automation to generate CHANGELOG.MD. Rigth now is not a big deal because there is not a release yet.


Check for type errors in server initializers

Currently the following compiles:
server foo { var val : 0..5 }
var foo: foo() { val = :blah }

but generates incorrect Dedan code (nonexistent starting state val_blah for server foo).
Missing or redundant variables also aren't checked.
The variables are also required to be in alphabetical order, or nonexistent state is generated.

Fixed in 0d23712c and c9c3639a.


Allow for a configurable loader

This looks good to me, @AMHOL :)

Really nice. Things look simpler now. I have an idea about using configurable loader with namespace like this
module MySpace
  class Application < Dry::Component::Container
    configure do |config|
      config.loader = Dry::Component::Loader.namespace(:my_space)
      # or
      config.loader = Dry::Component::Loader[MySpace]
    end
  end
end

We can use inheritance for that or sutin

@flash-gordon A namespace-aware loader sounds really great. I'd love to make that part of the default dry-web setup.


Database keeps restarting

The database container keeps restarting after a new installation. Even if there is no volume mapped in docker-compose.yml file.
I'm using the default docker-compose.yml file from this repo:
db:
   build: db
   read_only: true
   restart: unless-stopped
   #volumes:
           #- ./volumes/db/var/lib/postgresql/data:/var/lib/postgresql/data
           #- /etc/localtime:/etc/localtime:ro
   environment:
     - POSTGRES_USER=mmuser
     - POSTGRES_PASSWORD=mmuser_password
     - POSTGRES_DB=mattermost
   # uncomment the following to enable backup
   #  - AWS_ACCESS_KEY_ID=XXXX
   #  - AWS_SECRET_ACCESS_KEY=XXXX
   #  - WALE_S3_PREFIX=s3://BUCKET_NAME/PATH
   #  - AWS_REGION=us-east-1

I'm seeing the same behavior, I'm using tag 5.16.3.

It seems to be wal-e related. When I get rid of the whole wal-e stuff in db/entrypoint.sh, the container starts normal and even is able to import existing data.
My entrypoint.sh looks like
#!/bin/bash

if [ "$1" = 'postgres' ]; then
  # Run the postgresql entrypoint
  . /docker-entrypoint.sh
fi

db_1   | LOG:  syntax error in file "/var/lib/postgresql/data/postgresql.conf" line 613, near end of line
db_1   | LOG:  syntax error in file "/var/lib/postgresql/data/postgresql.conf" line 614, near end of line
db_1   | LOG:  syntax error in file "/var/lib/postgresql/data/postgresql.conf" line 616, near end of line
db_1   | FATAL:  configuration file "/var/lib/postgresql/data/postgresql.conf" contains errors

These correspond to some wal-e guff

@Meatballs1 I didn't see those

I think the problem is related to an upgrade in postegres:9.4-alpine as hinted in #427

I think the problem is related to an upgrade in postegres:9.4-alpine as hinted in #427

had the same issue, but downgrading to postgres:9.3-alpine seems to work

I got it running with changeing one line in db/entrypoint.sh
# Run the postgresql entrypoint
exec /docker-entrypoint.sh $@


Update frontpage logos

[x] @carsonicator will provide the NUCATS logo and @fenekku will add it
[x] @carsonicator will crop the new COAR logo and @fenekku will add it
[x] @carsonicator and @kristiholmes will provide a new CD2H logo and @fenekku will add it

Let's scale down the COAR image to be more in line with the NUCATS and CD2H logos.


Fix GLTF embedded texture not reimporting when changed

Fixes #83154
The existing code skips re-extract/reimport of the embedded texture if an existing file at the extract path doesn't have a md5 value in the remap:generator_parameters section of its .import metadata, under the assumption the existing file wasn't an extracted version because it's missing it. But it wasn't writing the md5 value to the metadata when importing the first time, so this failed as a check.

Though I'm not sure this is a good long-term solution to tracking whether an existing texture is an extracted texture or not. I feel there should probably be more specific metadata related to this than just an md5, like an isExtractTexture bool and maybe an ownerUID entry...

@lyuma you may want to take a look too.

One existing potential issue I'm noticing is that the texture the model is referencing after import doesn't seem to be the extract texture? It seems it's still embedding its own copy and referencing that, so any edits to the extracted texture will not be reflected on the model unless the material properties are edited on it. This seems like counterintuitive behavior?
But if it was updated to use the extracted version, that then brings up another issue. What happens when we edit the external one, but then the model goes through reimport at some point, the md5 will mismatch and the edited external version will be overwritten by the older embedded version. This is more unforeseen behavior we probably don't want.
So perhaps it would be good to then introduce another import option of Extract Textures + Overwrite Existing  and rename the other to Extract Textures + Reuse Existing , so a user can decide their workflow, if they intend to continue editing a texture externally or updating it in the model file.

Superseded by #86504. Thanks for the contribution nonetheless!


Error: ~/.config/flake8 ignored by linter-flake8

By default, command line flake8 checks for configuration in places such as ~/.config/flake8. However, linter-flake8 fails to load this configuration file by default, resulting in a surprising experience for newbies: linter-flake8 appears to ignore their preferred style settings.
Please check for flake8 configuration in ~/.config/flake8 by default, in addition to any Atom user specified locations.

This may be fixed in #77, or potentially a re-write of that. Will need testing.

@mcandre can you please test v1.8.0 (or higher) and see if this is working for you? Alternatively you might want to look into putting a tox.ini or setup.cfg file at the project level so the settings move with your project.

Any updates @mcandre?

Closing since there has been no input from @mcandre, if this is still an issue please re-open.

linter-flake8 is still not looking for system wide configuration files but rather for project configuration files. It would be great to have this as the default behaviour just like the flake8 package specifies and still maintain support for project-level configurations.


Main page footer can be overridden

This allows the footer on the main (index) page to be replaced with custom HTML.
Related to https://github.com/jupyterhub/mybinder.org-deploy/issues/2156
Current default:

With  c.BinderHub.main_footer_message = '

This is a custom footer message.

':

I decided to override the main page footer instead of prefixing/suffixing it to give us more flexibility in layout.

Nice start! I think this would be enough to make good progress here. The other thing we might want is a button in the top right or something, but we could always absolutely position an element in the footer 🤷
The other page I had in mind was the loading screen, since that is a very common one for people to see 🙂

I've updated it so instead of replacing the footer it's now a new section above the footer.... it should appear on the index and loading pages

Adding a button at the top should already by doable:
https://github.com/jupyterhub/mybinder.org-deploy/blob/945d2accd7e400a0230ecd6be9e549d9281a762d/mybinder/values.yaml#L128-L129

I like it. My only nitpick is that "summary message" as config option name had me thinking "a summary as well, i thought we are doing the footer in this PR" -> why call it summary message? Somehow I was primed to expect it to be called a footer. What was your thinking around calling it summary instead?

We have established a pattern for ourselves of using extra_. Maybe extra_footer and put it inside the footer block?

Originally this was just to customise the footer on the main page (hence the now misleading PR title), but after feedback I attempted to give the property some sort of semantic meaning, since it appears in the main and loading pages, but not the others.
I could rename it to something like extra_footer, but since it's only for some pages I'm worried about creating an impenetrable mess of HTML configuration options where the only option is to grep the templates. Maybe that's the best option though?

None of these placeholder strings-as-config are  necessary if using a custom template is practical, because all we need is:
{% block footer %}
custom stuff
{{ super() }}
{% endblock %}

and the only impediment to that is getting the template to the container in helm. Maybe that's what we should do?
I'm okay with this as-is as a short-term fix, though, since we are under some time pressure.

#1472 supports arbitrary custom templates

I like #1472


Start the game after all players are in the room

The game is stored with all players. Afterwards the players are ready to see the cards.
Estimated time: 4h
https://github.com/sopra-fs22-group-36/screw-your-neighbor-server/issues/5

Button to start the game  (including the a validation that there are > 1 players present ) was implemented in Issue: https://github.com/sopra-fs22-group-36/screw-your-neighbor-server/issues/47
Functionality that everyone in the lobby joins the same game after start was implemented in issue: https://github.com/sopra-fs22-group-36/screw-your-neighbor-react/issues/29
Backend functionality was implemented in Issue: https://github.com/sopra-fs22-group-36/screw-your-neighbor-server/issues/55


Fixed spelling error(s) and updated sentence syntax

Added the word "are" under "Compatibility"
Changed "oririnal" to "original"
Added capitalized letters for summary under "Contributing"

thanks!
please squash both into "docs:..." (see conventional commits)


[BUG] Status and console width change

[ ] I've checked docs and closed issues for possible solutions.
[ ] I can't find my issue in the FAQ.

Describe the bug
I'm testing this code:
python -m rich.status
which is presented on git repo description. The issues I get is when I do the change of the terminal width, the status/spinner gets moved into new line, and "freeze" status left above it. I know that the wrapping these ways is "normal" but the issue appears even when I do the width reduce by 1, like if the status is padded to be the full width of the terminal. Is there any parameter to set or anything to bypass this? I used Windows Terminal, PowerShell, it behaves the same.

One more thing, to not open one more discussion, using with console.status(""): together with console.print("text",end=""), it prints nothing until the string passed has "\n" in it, is this expected?
Platform

Wrapping of the status is expected if you change the size of the terminal.
Prints will be line buffered (i.e. it will wait for a \n) while the status is running.


Support diffing server schemas for API incompatibilities

Why
With upcoming versioning work, we want a way to be able to programmatically detect API compatibility breakages between different River schemas.
This adds a first pass at schema diffing which detects a number of incompatibilities:

Removed services
Removed procedures
Procedure type changes
Payload incompatibilities

Type changes
New required fields on client->server messages
Removed required fields on server->client messages
The check support nested objects
Array changes
Union changes
Intersection changes

What changed

Add diffServerSchema which diffs two server schemas and returns all detected API incompatibilies
Includes a test suite checking for the incompatibilies mentioned above

Versioning

[ ] Breaking protocol change
[ ] Breaking ts/js API change

Current dependencies on/for this PR:

main:

PR #174 👈

This comment was autogenerated by Freephite.

We might also want to support checking for forwards-compatibility. We may want to allow newer pid2 workspace clients to work with older versions of pid2 servers, this way we don't have to force upgrade pid2 so often. If we can check forwards compatibility we can add and enforce a minimum server version that the client has and sends to the server during the handshake.

Sounds like we're going to punt on forwards compat checking for now, we can add that later if we need it.


Some miscellaneous MinimalLib enhancements

This PR contributes back some MinimalLib enhancements that I have been using for some time, namely:

expose SubstructureLibrary to MinimalLib
expose acceptFailure flag to MinimalLib generate_aligned_coords
expose merge_query_hs functionality to MinimalLib
expose kekulize flag to MinimalLib get_mol
add relevant JS tests
Exposing SubstructLibrary enables substructure search functionalty in the browser. In this context, the merge_query_hs functionality proves useful to incorporate explicit Hs as queries to forbid substituents as certain positions.
Exposing the acceptFailure flag avoids that existing coordinates get overwritten when the attempt to generate constrained 2D coordinates fails.
Finally, exposing the kekulize flag allows to depict things like R-groups with partial aromatic rings avoiding kekulization failures without need to call get_qmol instead of get_mol.

@ptosco : there's a lot of stuff in here. It may take me a few days

@greglandrum No worries. Note that the big change in common.h is mostly due to CRLF->LF conversion; the only real change is the addition of a details_json.kekulize option. to opt in/out kekulization from SanitizeOps.

@ptosco I suspect that the conflict is due to the fact that you also changed the line endings in that other PR.
If you can fix the conflict I'll go ahead and finish reviewing

Inspired by, but not part of this PR: we should also expose AdjustQueryParameters() in the minimallib: #4187

@ptosco : a suggestion, please let me know what you think
I think we should require that documentation be added to the GettingStartedInJS document when we add new functionality to the JS wrapper. I'd like to avoid having this thing be largely undocumented and it seems like the only way to ensure that things stay up-to-date is to make it part of the process when adding new features.
What do you think?

It doesn't need to be added to this PR, but we should also support merge_query_hs in the CFFI wrapper.


Database export to json issue

Deployment Method

[X] Installer
[ ] Docker Development
[ ] Docker Production
[ ] Bare metal Development
[ ] Bare metal Production
[ ] Digital Ocean image
[ ] Other (please provide a link Steps to Reproduce

Describe the problem*
Hello. I've installed Inventree quite awhile ago, and its running fine (version is 0.11), but when i'm trying to export database into json using the command invoke export-records -f data.json it fails with output:
Exporting database records to file '/opt/inventree/data.json'
CommandError: Unable to serialize database: no such table: build_build

My current setup is Ubuntu 22.04 with python 3.8, database is sqlite. I do understand that i'm most likely doing something wrong. Any help/advice would be much appreciated.
Steps to Reproduce
cd /opt/inventree
source env/bin/activate
invoke export-records -f data.json
Relevant log output
Exporting database records to file '/opt/inventree/data.json'
CommandError: Unable to serialize database: no such table: build_build

@templeofhead have you recently performed any updates or changes to your system?

No, i haven't, system state is exactly the same as it was when i installed inventree, no updates.

This may be a pathing issue, if you are using a file-system db (sqlite). Where is your database file actually stored?

Its in opt/inventree/data

Do any of the other invoke commands run?
For example, what is the output of:
invoke migrate

Here's the output:
(env) ***@inventree:/opt/inventree$ sudo invoke migrate
[sudo] password for ***:
Running InvenTree database migrations...
========================================
Traceback (most recent call last):
  File "manage.py", line 9, in <module>
    from django.core.management import execute_from_command_line
ModuleNotFoundError: No module named 'django'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "manage.py", line 15, in <module>
    import django  # noqa: F401
ModuleNotFoundError: No module named 'django'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "manage.py", line 17, in <module>
    raise ImportError(
ImportError: Couldn't import Django. Are you sure it's installed and available on your PYTHONPATH environment variable? Did you forget to activate a virtual environment?

Also, i get the same output if i try to export db outside of venv.

Did you activate the correct venv before running invoke migrate? You should not see a "no module named django" error.

I go into /opt/inventree and use source env/bin/activate, is this correct?

@matmair any thoughts on this? Is /opt/inventree/env the correct virtual environment location?

@SchrodingersGat theoretically yes. But for packaged installer you need some configs etc. in the environment - therefore the correct command is inventree run cli instead of invoke.

@templeofhead please try again using inventree run cli instead of invoke (as detailed above by matmair)

No import issues were present, everything went smooth. Closing the issue, thanks for the assist :)


Unexpected formatting of macro with block when hard_tabs = true.

Describe the bug
I am observing unexpected formatting of macro bodies when the macro emits a block wrapped in curly braces and hard_tabs = true.
To Reproduce
Run the following macro definition through rustfmt with hard_tabs = true:
Input:
macro_rules! example {
	() => {{ let x = 5; Ok(x) }};
}

Output:
macro_rules! example {
	() => {{
		let x = 5;
		Ok(x)
		}};
}

The output has an extra level indentation at the closing curly braces. This does not happen when hard_tabs = false or when the macro does not emit an enclosing block.
Expected behavior
#[macro_export]
macro_rules! example {
	() => {{
		let x = 5;
		Ok(x)
	}};
}

Meta

rustfmt version: 1.4.24-stable
From where did you install rustfmt?: rustup
How do you run rustfmt: rustfmt

This has been fixed in source but not backported to a 1.x release. Let me see if I can squeeze this in the upcoming v.1.4.28 release

Closing as a duplicate of #4152, fix has been backported and will be in the next release

Thanks! 😀


Inline style on cell violates csp

// addon/components/ember-collection/template.hbs
...
{{~#each _cells as |cell|~}}

{{yield cell.item cell.index }}

{{~/each~}}
...

What's a good way to apply the style using js? I've done this successfully in ember-cli-csp-style but that only works on the root element. Can't use a helper as it doesn't know its target context.
Happy to write a PR for this if someone more familiar with Glimmer can hint at a good way to solve.

It's because it is using a path that goes through setAttribute which then uses the CSS parser, if it did style prop of the element that would work. This though would need to expose the current element modifier API which isn't public or become a component.

I've refactored as a component - getting it working in a fork then submitting a PR


NIFI-10101 Move nifi-hive-nar to optional include-hive profile

Summary
NIFI-10101 Moves the nifi-hive-nar out of the standard nifi-assembly binary build to an optional profile named include-hive. This approach aligns Hive 1.2 components with other Hive 1.1 and Hive 3 components which are already mapped to the optional include-hive1_1 and include-hive3 profiles.
Removing the inclusion of Hive 1.2 components in the default binary build reduces the standard size by 100 MB and also encourages selection of the appropriate version when downloading extension NAR files. All Hive components require the nifi-hive-services-api-nar, which will be included when building any of the optional profiles.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 8
[ ] JDK 11
[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@exceptionfactory - open question - I'm always wondering if we should add, or not, all such profiles in the automated builds: https://github.com/apache/nifi/blob/main/.github/workflows/ci-workflow.yml#L38

That's a good question @pvillard31! Running a build with optional profiles could place an additional load on standard builds, but it would be helpful to make sure the optional profiles are run on a regular basis. We could create a separate workflow, similar to the system tests, that runs every 24 hours. If you want to create a Jira issue for it, I could take a look at putting together a new GitHub workflow configuration.

I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it?

I thought a bit more about this and realized that the tests are still executed for those specific extensions. The profile is just about adding or not the binaries into the final assembly, isn't it?

That is correct, most of the profiles are limited to controlling what gets included in the assembly. The components and tests are still built as part of the standard ci-workflow.


Support full topics

Allow full topics to be passed in, starting with "projects/" , to bypass project from config.

Closing this because I made another PR against timuryan/weddell


nix 0.27

Upgrades to nix 0.27. Supersedes #109.

Looks like nix 0.27 requires rustc 1.65 though.

Thanks for your patch, I included it in #109 and merged that one :tada:


Will it work for magento 1.9?

Descriptions says it's for magento 2.
I assume it will not work for magento 1, right?

hi @gety9 sory that I did not respond on time.
You are right, that module is created for magento 2.
Since magento 2.2 do not keep backward compatibility(with unit tests) I also need to make changes with that (no idea when I will find time for that).


Add Option to Edit Images Uploaded Directly from Chat

Currently there is a something which emulates this experience through the math editor. File > import image > send as image.

similar to #157


no releases available

I would like to run this on Linux but I can't figure it out, I've never seen anything released like this before.  The CI you linked to redirects to https://github.com/Avarel/silicate/actions but don't see any release-{insert your OS here}.zip files.  If I click on "Update actions #17" it tells me things such as "release-x86_64-linux Expired".  Or if I click "Update submodule version #39" for v0.2.0 release i get told "The logs for this run have expired and are no longer available."  Please provide more instruction.  Thanks

What about the releases tab? Does the "silicate" binary work on Linux?

Oh thanks I didn't notice the Linux binary for some reason.  Yes v0.2.0 runs and loads up, but throws an LZO error for my file.  I see you've fixed that with your latest commits and I was able to download the release from Master #20 as well and it loaded my file.
I'm not familiar with this file format though.  It behaves like a zip file and I extracted it.  There a several UUID directories with LZ4 files in them which I can't open right now I'll have to look for something that can read the LZ4 data.  There's also a video dir with several segments.  Do you know what it all is and how it should be displayed?

Are you attempting to study the Procreate file format or open it with my program?

Well just open it essentially, but it seems parts of it are not opened and remained hidden, so that's why i'm curious about the format...

What parts of it are not opened? Would you be willing to provide a file so I can check the issue out?

Ok thanks, no big deal.  The videos are in an MP4 format that is readable/playable with an external player, at least...  All these LZ4 files seem to be in some proprietary Apple LZ4 format so can't tell what they all are yet, but this is fine for now, thanks for your help and the original issue is taken care of.


[Question] openApiToCSharpClient - Support for Comma Separated Array Binder

I am using the openApiToCSharpClient generator in order to generate an HTTP client for a given API.
This API uses a custom array model binder, which is comma-separated, so essentially it would work this way http://some-api/api/v1/resources/?ids=1,2,3,N.
After generating the client with openApiToCSharpClient, I see that the generated code will use the default dotnet array model binder instead so it would actually generate something like this http://some-api/api/v1/resources/?ids=1&ids=2&ids=3&ids=N.
This is the generated code:
if (ids != null)
{
   foreach (var item_ in ids) { urlBuilder_.Append(System.Uri.EscapeDataString("ids ") + "=").Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append("&"); }
}

Does openApiToCSharpClient allow to somehow override this default behavior, and generate instead comma-separated values?
If not, what's the cleanest workaround?
Thank you in advance
UPDATE:
I've realized that I could override it by using liquid templates, but still I would like to understand if there's a cleaner way, or if I can at least pass custom parameters to the liquid templates like UseCommaDelimitedParameters

Did you ever find a better way to do this?
I've been blindly using a third party API and just discovered that only the first parameter in a list was getting through.
Fortunately it's not that serious, but I have no idea where to start with liquid templates for this.
I'm using an API that has something like this:
      {
        "name": "OrderStatuses",
        "in": "query",
        "description": "Comma separated list of statuses to filter by",
        "schema": {
          "type": "array",
          "items": {
            "$ref": "#/components/schemas/OrderStatus"
          }
        }
      },

So of course I end up with OrderStatuses=Shipped&OrderStatuses=Cancelled instead of OrderStatuses=Shipped,Cancelled
Frankly the easiest way seems to be to just make it a string and set the list myself with string.Join().
That's ok for one or two instances but would really like a more comprehensive solution.


Drop support for ServiceAccount after 2020-07-31

We are renamed the ServiceAccount to App. Saleor still supports old queries and mutations. After 2020-07-31 we should drop them.:
DoD:

[ ]  Confirm that Dashboard uses new queries/mutations
[ ]  Remove ServiceAccount mutations and queries
[ ]  Remove unit tests for SA
[ ]  Remove all helpers logic dedicated to ServiceAccount
[ ]  Drop get_type_for_model from App mutations:
We are support ServiceAccount and App mutations. To do that we have to overwrite get_type_for_model  for each App mutation. This will be unneeded when we will drop support for ServiceAccount
[ ]  Drop custom logic dedicated to SA from webhook mutations/queries

Service accounts are now apps.


Duplicate zip entry [classes.jar:io/card/payment/CardIOActivity.class]

Hi,
I have a Xamarin From project in which I need to use Braintree DropIn payment gateway.  I have installed from nuget your “Naxam.BraintreeDropIn.Droid” package in my Android project but I have some problems during build.
First of all, I had the error “No resource found that matches the given name: attr 'textColorError'” in “…\obj\Debug\90\lp\26\jl\res\values\values.xml”. I solved it by creating a new attrs.xml file with content:
<declare-styleable name="MainTheme">
    <attr name="textColorError" format="color" />
</declare-styleable>

Then, when I try to build again, I obtain the error “Can't read […\obj\Debug\90\lp\2\jl\bin\classes.jar(;;;;;;!META-INF/MANIFEST.MF)] (Duplicate zip entry [classes.jar:io/card/payment/CardIOActivity.class])”.
The Android Target Api Level is 28 and Minimum is 21. All NuGet packages are up to date.
Have you any ideas about how to solve the issue?
Thank you

Hi,
Plz check out the latest code.
Let me know if it's ok.
cheers.


Destroy Measure

I am trying to delete a measure.
I have obtained the id of the measure using the Engine API Explorer.
When I run the code I get this error...
{ code: -32602
parameter: 'JSON type error',
message: 'Invalid method parameter(s)'  }
Code:
`
var qsocks = require('qsocks');// Is used to communicate with Qlik Sense
qsocks.Connect().then(function (global) {
// from the global handle we can invoke methods from the global class
return global.openDoc('Ledelsesinfo.qvf')
})
.then(function (app) {
console.log("Connected..");

app.destroyMeasure(
    {
        qInfo: {
            qId: "LPKkx"
        }
    })
    .catch(function (error) {
    console.log(error)
})
    .then(function () {
    return app.doSave();
});

})
.catch(function (error) {
console.log(error)
});
`

http://help.qlik.com/en-US/sense-developer/2.2/Subsystems/EngineAPI/Content/Classes/AppClass/App-class-DestroyMeasure-method.htm
app.destroyMeasures('LPKkx')

Amazing! I actually read the documentation and tried to do just app.destroyMeasure('LPKkx') with no success (there must have been something else wrong) -->  but now it works like a charm.


[<libarchive[core] or libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]>]:x64-windows build failure

Host Environment

OS: [Microsoft Windows [Version 10.0.18363.836]]
Compiler: Visual Studio 2019 Version: 16.6.0  VS Tools Version: 14.26.28801

To Reproduce
Steps to reproduce the behavior:
.\vcpkg install libarchive
Failure logs

Cut and past the appropriate build messages from the console output.
Computing installation plan...
The following packages will be built and installed:
    libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x64-windows
Starting package 1/1: libarchive:x64-windows
Building package libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x64-windows...
-- Using cached D:/Git/vcpkg.downloads/libarchive-libarchive-cce09646b566c61c2debff58a70da780b8457883.tar.gz
-- Using source at D:/Git/vs2019.prod/buildtrees/libarchive/src/80b8457883-1ab8492808
-- Configuring x64-windows
-- Building x64-windows-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:136 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" --build . --config Debug --target install -- -v
    Working Directory: D:/Git/vs2019.prod/buildtrees/libarchive/x64-windows-dbg
    See logs for more information:
      D:\Git\vs2019.prod\buildtrees\libarchive\install-x64-windows-dbg-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_cmake.cmake:91 (vcpkg_execute_build_process)
  scripts/cmake/vcpkg_install_cmake.cmake:24 (vcpkg_build_cmake)
  ports/libarchive/portfile.cmake:67 (vcpkg_install_cmake)
  scripts/ports.cmake:90 (include)
Error: Building package libarchive:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: libarchive:x64-windows
  Vcpkg version: 2020.02.04-nohash-external
Additionally, attach any relevant sections from the log files above.

Please attach any additional failure logs mentioned in the console output.
install-x64-windows-dbg-out.log

Additional context

Note: I only entered vcpkg install libarchive which should have only tried to install the  core feature
No matter which port features selected it always wants to install all features - reference https://github.com/microsoft/vcpkg/issues/11479
libarchive with all features installs fine with VS2017

D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_NONE' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_INFO' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_META' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_REQ' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_RVIS' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_CONV' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'WT_CONT' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(344): error C4061: enumerator 'LAST_WT' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_NONE' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_INFO' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_META' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_REQ' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_RVIS' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_CONV' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'WT_CONT' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(368): error C4061: enumerator 'LAST_WT' in switch of enum 'warc_type_t' is not explicitly handled by a case label
D:\Git\vs2019.prod\buildtrees\libarchive\src\80b8457883-1ab8492808\libarchive\archive_read_support_format_warc.c(75): note: see declaration of 'warc_type_t'

@JackBoosY

I am not sure what you want me to do?
The same source as my VS 2017 which compile fine.
The only other difference I can think of is:

my previous VS 2019 install was Visual Studio 2019 Version: 16.5.5 VS Tools Version: 14.25.28610
the new install is upgrade to Visual Studio 2019 Version: 16.6.0 VS Tools Version: 14.26.28801

Maybe it is something introduced with the 16.6.0 upgrade that is not compatible.
I will delete my VS 2019 install and recreate from scratch to see if that makes a difference.

I created a totally new instance of vcpkg using VS2019 and I am still getting the same issue?
Is anyone else using VS 2019 16.6.0?
install-x64-windows-dbg-out.log

I found I can comment out line 154 of the  <vcpkg-root>\buildtrees\libarchive\src\80b8457883-1ab8492808\CMakeLists.txt and the port will compile, link and install.
  # This is added into CMAKE_C_FLAGS when CMAKE_BUILD_TYPE is "Debug"
  # Enable level 4 C4061: The enumerate has no associated handler in a switch
  #                       statement.
  #SET(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /we4061")
Further research I found on https://docs.microsoft.com/en-us/cpp/overview/cpp-conformance-improvements?view=vs-2019 in this paragraph:
Switch-related warnings for C
Starting in Visual Studio 2019 version 16.6, the compiler implements some preexisting C++ warnings for code compiled as C. The following warnings are now enabled at different levels: C4060, C4061, C4062, C4063, C4064, C4065, C4808, and C4809. Warnings C4065 and C4060 are disabled by default in C.
The warnings trigger on missing case statements, undefined enum, and bad bool switches (that is, ones that contain too many cases).
So I have a couple of questions here, remembering that I new to C++:

The logs show C4016 as an error, is there a way to make them a warning?
Either way it appears some type of patch needs to be made to make this work for VS2019 16.6 or higher, but I am not sure if it is above my current abilities?
Or should this be identified to the upstream vendor of libarchive?

Please advise.....

I figured out that if I change line 154 from:
SET(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /we4061")
to:
SET(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /w14061")
it makes the message a warning instead of an error and the port compiles, links installs.
My revised questions are:

Should we make a patch to update line 154 of the CMakeLists.txt file? -or-
Should we open a issue upstream at libarchive/libarchive and wait for them to patch? *-or--
Do both?

@timautry I just picked out the error messages, so I can more easily dig the cause.

No, I can't repro this issue by Visual Studio 2019, here is my output:
PS F:\vcpkg> .\vcpkg.exe install libarchive
Computing installation plan...
The following packages will be built and installed:
    libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x86-windows
Warning: abi keys are missing values:
    bzip2
    liblzma
    libxml2
    lz4
    zlib
    zstd

Starting package 1/1: libarchive:x86-windows
Building package libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x86-windows...
-- Using cached F:/vcpkg/downloads/libarchive-libarchive-cce09646b566c61c2debff58a70da780b8457883.tar.gz
-- Using source at F:/vcpkg/buildtrees/libarchive/src/80b8457883-1ab8492808
-- Configuring x86-windows
-- Building x86-windows-dbg
-- Building x86-windows-rel
-- Installing: F:/vcpkg/packages/libarchive_x86-windows/share/libarchive/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x86-windows... done
Installing package libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x86-windows...
Installing package libarchive[bzip2,core,libxml2,lz4,lzma,lzo,openssl,zstd]:x86-windows... done
Elapsed time for package libarchive:x86-windows: 4.285 min

Total elapsed time: 4.285 min

.\vcpkg install libarchive

will always build the default features not core.
if you want core you explicitly need to use:
.\vcpkg install libarchive[core]
this also applies if you want single features e.g.
.\vcpkg install libarchive[core bzip2]
if there is a port depending on libarchive it also need to say w´hich features it requires else it assumes the default:
e.g. Build-Depends: libarchive will assume the default features are required while Build-Depends: libarchive[core] only requires the port to be installed.

@JackBoosY  The issue was created with x64-windows triplet and the latest 16.6.0 of VS 2019. I did not have the issue on 16.5.5 or prior versions. I will report this upstream at libarchive.
@Neumann-A The only problem with making all features default is when running an vcpkg upgrade it installs all features even though you may have originally install just core as mentioned by @zrax in issue https://github.com/microsoft/vcpkg/issues/11479
Note: the default behavior of vcpkg has always been just to install the bare minimum and left all other features optional and this port seems to be an exception for reasons unknown?

@JackBoosY - see https://github.com/libarchive/libarchive/blob/master/CMakeLists.txt#L157
The latest version of libarchive has the line removed:
SET(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /we4061")
and all the rest of the we lines changed to w1.
All that is needed is upgrade libarchive to the latest version and problem solved.
For a simple/small port I would attempt, but for one as complex as this one is way above my current abilities.


PyTorch version dependancy already exists in the 'environment.yml'

Hello dear Christian and dear Thunfisch,
I have also noticed that inside the 'environement.yml' file you have as a dipendancy pytorch=1.11.0. However in your instructions in your main github page you propose to install PyToroch with the following command:
conda install pytorch cudatoolkit=11.1 -c pytorch -c conda-forge
The above command results in the system installing PyTorch version 1.8.1 instead of 11.11.0
Which version is the correct one for running the Karolos code with no issue?
Thank you very much in advance for your valuable help!!!
Kind regards,
Christos Peridis

Hey Christos,
I'm currently on my phone. Will get a chance beginning next week to look at
the version I'm running.
However I have been running different pytorch v1 versions without issues in
the past. The reason we recommend the separate installation of pytorch is
that we ran into issues with different cuda versions (and thus different
pytorch versions) on different systems. I'll remove pytorch from the .yml
so that pytorch doesn't get installed twice.
I'll test if everything works with the latest pytorch version 1.13 and if
it does we should update the recommendation to the newest version. Same
thing goes for all the other libraries in the .yml.
Thanks for raising this issue.
Cheers, Christian
ChristosPeridis @.***> schrieb am Fr., 30. Juni 2023,
14:47:

Hello dear Christian and dear ,
I have also noticed that inside the 'environement.yml' file you have as a
dipendancy pytorch=1.11.0. However in your instructions in your main github
page you propose to install PyToroch with the following command:
conda install pytorch cudatoolkit=11.1 -c pytorch -c conda-forge
The above command results in the system installing PyTorch version 1.8.1
instead of 11.11.0
Which version is the correct one for running the Karolos code with no
issue?
Thank you very much in advance for your valuable help!!!
Kind regards,
Christos Peridis
—
Reply to this email directly, view it on GitHub
https://github.com/tmdt-buw/karolos/issues/6, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACWXCAKOL67RKXG5IACOCI3XN3DFPANCNFSM6AAAAAAZZZZEG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I just updated the environment.yml and tested everything with a new environment. We are now using the latest pytoch v1 version. Also updated the Readme.
Closing this issue for now. If there are any more issues with getting up and running feel free open a new issue.


Fix readme file on Extending Bandit on list things

Fix readme file on Extending Bandit on list things;
manager, fileobj, sev_level, conf_level, lines=-1
they were not listed on Markdown format

@Aurel10 Please rebase and resolve conflicts, thanks!


fix: intercept links without extension

Add flag, which enforce add .html extension for relative links on leading page, for explore static generated html docs.

we currently have big pending release, i don't want potentally breaking changes to be merged right now.
https://github.com/yandex-cloud/yfm-docs/pull/230
also use scope for the commit messages feat(scope): commit message


test(finally): add test for the use of thisArg argument

Maybe it's good time to discuss about make decision around drop thisArg? https://github.com/ReactiveX/RxJS/pull/744 is blocked for similar reason currently.

I'd be fine with dropping thisArg everywhere and also this PR. This PR was just a product of my effort to review each and every operator, if its tests are complete.

@staltz , I think this also can closed by https://github.com/ReactiveX/RxJS/issues/878 now leaving away from thisArg.

I'm fine with closing.


true copy and paste keyframes

Issue description:
Right now, in order to copy and paste keyframes the user has to select the keyframes (https://github.com/godotengine/godot/issues/27276), move the animation timeline cursor to the desired paste location(https://github.com/godotengine/godot/issues/27278), go back to the selected keyframe, right click and select "duplicate".
Never ever would I have figured this out by myself. I had to ask on Discord.
Duplicating keyframes from one track to another is currently also not possible. (see slightly different issue: https://github.com/godotengine/godot/issues/15029)
Proposed solution: Select keyframe(s), Ctrl+C or rightclick ->context menu ->"copy key", left click to position on desired track, Ctrl+V or rightclick ->context menu -> "paste key"
Pasting should be only possible at compatible tracks. If the clipboard data is not compatible with the paste location (for instance if the user tries to paste a key with integer value into a track with a boolean values), play a short, not so pleasant "denied" sound and display a small red cross symbol for a second at the location where the key was supposed to be pasted.

A ctrl+D for duplication would also be a bump in the QoL direction.

Closing in favor of https://github.com/godotengine/godot-proposals/issues/302, as feature proposals are now tracked in the Godot proposals repository.


EXC_BAD_ACCESS crash on some SVGs using AnimatedImage

In a SwiftUI view:
  AnimatedImage(url: URL(string: self.imageUrlString)) .resizable() .scaledToFit() .frame(width: self.width, height: self.height, alignment: .center)
Some SVGs cause EXC_BAD_ACCESS crash, but I'm having a hard time identifying which one specifically due to the async nature and not being sure which images are finishing loading first.
As far as I can tell, it's one of these 3 SVGs causing the crash but I don't know what's wrong with them:
https://static.hltv.org/images/team/logo/4863
https://static.hltv.org/images/team/logo/10386
https://static.hltv.org/images/team/logo/4602

I’ll check this issue tomorrow.
Any extra code in your usage of AnimatedImage ?
For example, did you use AnimatedImage View inside a NavigationLink ?
Be sure to use. buttonStyle to default or many strange issue will happen. See the common mistake part of our readme

Seems this is because your SVG file contains something Apple's SVG parser can not correctly render.
Check https://developer.apple.com/documentation/xcode/creating_custom_symbol_images_for_your_app, convert it firstly to make sure it can render on the Symbol App on Mac, then retry with the new SVG one.
Apple's iOS 13 CoreSVG.framework does not provide full SVG/1.1 support, which actually seems only support SVG-native W3C standard.

I guess from the stacktrace, maybe this cause issue:
<style type="text/css">
	.st0{fill:#161616;}
	.st1{fill:#A3242E;}
	.st2{fill:#D63831;}
	.st3{fill:#FFFFFF;}
	.st4{fill:#C8C8C8;}
</style>

Could you try to use the inline color fill, like <path class="st0" d="M399.8,68.2c77.3,3.1,160.6", fill="#abcdef"/> instead ?

I test that remove the <style type="text/css"> totally works...But need to fill the path with color :(

Test write color with CSS name works, maybe the issue is the HEX expression:

Test using the rgb syntax instead of HEX expression, works :)
So you must change all the HEX color into RGB syntax, or Apple's CoreSVG framework can not parse it correctly

After another check, I found the issue does not comes from your first two SVG files...Which cause the misunderstanding.
The issue is the third one: https://static.hltv.org/images/team/logo/4602
Which use the CSS opacity for path element:
	.st0{fill:#9D1C31;}
	.st1{fill:#CB1436;}
	.st2{fill:#1D243C;}
	.st3{fill:#C5C2C3;}
	.st4{fill:#FFFFFF;}
	.st5{fill:none;}
	.st6{fill-opacity:0.15;fill:#1D243C;}
</style>

You should replace the opacity:0.15 into the fill-opacity:0.15, or use rgab in color like file, the opacity seems cause issue for CoreSVG.

@@teepsdonnelly Close this  ?

Ah thanks for looking into this so quickly @dreampiggy -- This is a resource I don't have access to change if that makes sense. Basically, I'm consuming this from a third-party API that is wrapping a website, and that third party API is passing back URLs for logos for eSports teams.
Currently, it seems like this is all a result of a bug in Apple's SVG parser as you mentioned. Is this something I should file with them or are there any other workarounds you can think of that don't involve modifying the SVG?

You’d better host a mirror or proxy for that SVG files. This crash happened inside low-level API, no good thing to workaround.
If you really really don’t have any own Image Host Server, you can hack from client side...
Use SDWebImage’s Data Decrypter API (which give you origin URL and Data, you return the modified one), check that SVG url and provided the modified version from your App bundle or some where. Sounds super hack but works...
See: https://github.com/SDWebImage/SDWebImage/wiki/Advanced-Usage#data-decryptor-530

static var svgDecryptor = SDWebImageDownloaderDecryptor { (data, response) -> Data? in
    if let url = response?.url, url.absoluteString == "https://static.hltv.org/images/team/logo/4602" {
        let localSVGPath = "xxx"
        return try? Data(contentsOf: URL(fileURLWithPath: localSVGPath))
    } else {
        return data
    }
}
AnimatedImage(url: url, options: [], context: [.downloadDecryptor : svgDecryptor])

Wow! Honestly I had no idea about the Data Decryptor API, thanks so much for helping -- you're amazing.
I tried your code suggestion and it seems to be working. I think we can close this one out for now since it definitely doesn't appear to be an issue on SDWebImage's side.


Added getTitle support

Closes #349
Would something like this work?

Thank you for the PR, we do have such functionality, review my last comment

Cross posting from the issue; just in case the reasoning behind this PR solution versus the formatters pattern.

Your proposed solution could work. Not sure what other implications there are of formatting the data, though. It might be tricky to evaluate where the data came from if it modifies the data object in the dashboard, however. With my proposed solution, and PR #358 - we know exactly how the formatting happens and that it's only purpose is for display.

Closing in favor of #359


Istio Standard metrics not coming for HTTPS traffic

Have Istio Ingress Gateway, sidecars installed in application pods, receiving standard metrics - incoming and outgoing.
Problem here is - It is not showing any request which is coming/going via HTTPS, it only displays for HTTP protocol.
Query:

Does Istio supports giving standard metrics for HTTPS traffic ?
Do we need to enable it for HTTPS traffic recording ?

If yes, please share some doc link or if a direct applied configuration YAML available, that would be helpful.

-If no, any other way to achieve this ? I want to record in/out requests from/to my Pod/Service on HTTPS protocol.
@zirain @douglas-reid

Short answer: No.
HTTPS traffic all the way to the workload instances is not accessible to the proxies. It looks like TCP traffic to proxies (just like it does to any other hops it passes along the way). The proxies have no way of teasing out individual requests, etc.
If you want request level monitoring at the proxies for HTTPS, you may want to consider terminating TLS at the gateway, and using Istio mTLS secure traffic between the gateway and the target pod.
I'm going to close this issue, as this does not reflect an issue with Istio (this is HTTPS traffic working as intended). In the future, please use discuss.istio.io for support questions of this nature. There have been several threads on related topics, including:

https://discuss.istio.io/t/prometheus-request-duration-collection-on-external-https-url/10750/3
https://discuss.istio.io/t/egress-gateway-and-https-traffic-enforce-istio-requests-total-metric/9894/2


I can't sign out

When clicking Sign out in the user account dropdown I get redirected to ../null and signing out fails
https://livebeats.fly.dev/profile/null
https://livebeats.fly.dev/null

Seems to be solved. It works fine now.


Wrapup tasks

[x] Mention why we have not done build for Linux
[x] Delete branches
[x] Add link to project board in readme
[x] Add information about the platforms the app works on
[x] Add link to project board in readme
[x] Add link to intermediate tasks like CI/CD, mid review in readme

Wrapup done


[Bug]: Capability Access Parser doesn't seem to find anything useful for our app

Version
Windows vNext: 25375.1
Win32 App Isolation: 0.1.0
Developer mode enabled
Repro Steps

Install EarTrumpet (dev)
Start-Profiling -PackageFullName 40459File-New-Project.EarTrumpet_<IP_ADDRESS>_x86__725pr5jq8wr8a
Launch EarTrumpet app
Left click the EarTrumpet icon in the notification area to show the flyout, adjust some volume sliders (interacts with Windows Audio APIs)
Right click the icon and go to Windows Legacy > Volume mixer (shells out to Windows)
Right click the icon and go to Settings > General > Mouse settings and toggle something on/off (this writes to Windows.Storage or in some cases to the system registry)
Right click the icon and go to Settings > General > About and click Collect troubleshooting data (this writes to a file on disk and shell executes the resultant file)
Stop-Profiling -TracePath eartrumpet.etl
Get-ProfilingResults -ETLFilePaths eartrumpet.etl -ManifestPath "C:\Program Files\WindowsApps\40459File-New-Project.EarTrumpet_<IP_ADDRESS>_x86__725pr5jq8wr8a\AppxManifest.xml"
Observe no AccessAttemptRecords.csv generated
Observe no errors in console output
Observe summary.txt generated and looks like copy included below

Expected to see capabilities around system tray access and perhaps writing to the disk/registry + shelling out to launch control panel applets/windows processes.
 Access to resources under this capability are gated by user privacy consent.-->
    <rescap:Capability Name="runFullTrust" />
  </Capabilities>
</Package>

Just to confirm, between your step 1 (start-profiling) and step 2 (stop-profiling), did you use your application? What action did you try? For example, you said maybe some file is accessed, what file did you access during your app execution?

@tiangao-ms Good catch. I updated the repro steps above with the activities I performed.

Another thing to confirm, sorry if it was obvious. Did you package your app according to the instructions? For the app you executed, did you change the manifest? Do you mind sharing the manifest after your change?

Oh I did not make any changes. That part of the documentation was unclear to me and read like I just needed to generally have a MSIX packaged app.
I'll re-read it more carefully, sounds like I missed something :(

Oh I did not make any changes. That part of the documentation was unclear to me and read like I just needed to generally have a MSIX packaged app.
I'll re-read it more carefully, sounds like I missed something :(

LOL that's fine. Let us know if there are specific parts that are confusing to you, we can make improvements. In order to isolate your app, you need to edit your manifest(not only "package it to MSIX") so your app can run at low privilege. Only with these changes, can you profile your app and check the accesses from your app.

OK sounds like I have to modify the app as listed here: https://github.com/microsoft/win32-app-isolation/blob/main/docs/packaging/msix-packaging-tool.md#msix---isolated-win32
It's very strange that I have to silo my app, before knowing what capabilities I need, to profile my app, to then get a list of capabilities I need.

OK sounds like I have to modify the app as listed here: https://github.com/microsoft/win32-app-isolation/blob/main/docs/packaging/msix-packaging-tool.md#msix---isolated-win32
It's very strange that I have to silo my app, before knowing what capabilities I need, to profile my app, to then get a list of capabilities I need.

Yes, we are aware that it is probably not the most intuitive process, but without isolating your app first, we can't intercept the "unordinary accesses" from your app (because it has access to everything) so we can't profile what capabilities the app needs. It's permissive learning mode.

Manifesting our app is not compatible with our dev workflow (https://github.com/microsoft/win32-app-isolation/issues/31) but I was able to get it working. Closing this issue as resolved.


Remove version: libjpeg-turbo.libjpeg-turbo.GCC version 3.0.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

Close with reason: Duplicate;


Is there a Debug Parameter?

Hi, @int128, I've set this up to send data from my GHA workflow to DataDog; however, I've encountered a number of issues.

When trying to filter, not all my workflows show up as options in DataDog.
Some filter options show up then disappear. So not sure what consistent param to filter by.
github.actions.pull_request_closed.since_first_authored_seconds and github.actions.pull_request_closed.since_first_committed_seconds do not show up in DataDog. I only see github.actions.pull_request_closed.since_opened_seconds.

I'd like to figure out why. Any ideas or is there a param I can use to debug the library and/or payload being sent to DataDog please?
Could it be because I'm using this in my config? collect-job-metrics: ${{ github.event.workflow_run.head_branch == github.event.repository.default_branch }}

Hi @int128, if there is no debug param, can you shed some light on how I can get the following to show up in datadog please?

github.actions.pull_request_closed.since_first_authored_seconds
github.actions.pull_request_closed.since_first_committed_seconds
Workflow names to use as filters

This is what my config file looks like.
name: Track DORA Metrics via Datadog

permissions:
  actions: read

on:
  workflow_run:
    workflows:
      - name-of-workflow-which-merges-into-main
    types:
      - completed
  pull_request:
    types:
      - opened
      - closed

jobs:
  send_metrics:
    runs-on: ubuntu-latest
    timeout-minutes: 10
    steps:
      - uses: int128/datadog-actions-metrics@v1
        with:
          datadog-api-key: ${{ secrets.DATADOG_API_KEY }}
          datadog-site: datadoghq.eu
          collect-job-metrics: ${{ github.event.workflow_run.head_branch == github.event.repository.default_branch }}
          github-token: ${{ secrets.GITHUB_TOKEN }}
          send-pull-request-labels: true

This action shows a payload here:
https://github.com/int128/datadog-actions-metrics/blob/de9c6ff18e5d55bd53d986c2c43225be7dcbb2b4/src/run.ts#L159-L165
Here is an example in the e2e test:
https://github.com/int128/datadog-actions-metrics/actions/runs/4090948703/jobs/7054711331

Both metrics are sent here:
https://github.com/int128/datadog-actions-metrics/blob/de9c6ff18e5d55bd53d986c2c43225be7dcbb2b4/src/pullRequest/metrics.ts#L119-L136
If this action cannot get the details of pull request, both metrics may not be sent.
Can you check if there is some warning log?
https://github.com/int128/datadog-actions-metrics/blob/de9c6ff18e5d55bd53d986c2c43225be7dcbb2b4/src/run.ts#L95-L105


ISPN-9376 Enhance RemoteStore to support segmentation

Added in segment based bulk operations

https://issues.jboss.org/browse/ISPN-9376

Have some test failures to look at. Not sure why they are complaining about segmentation.. those tests shouldn't have it enabled.

The test failures are unrelated.

@wburns looks good to me. I'm gonna trigger another CI run.

Afaik those tests fail on master as well, so I mostly ignored them. There shouldn't be any changes there tbh.

integrated! thanks @wburns


Add AssemblyAI API to Text Analysis

N.B - looks like the alphabetic order in this section got messed up

[ ] My submission is formatted according to the guidelines in the contributing guide
[ ] My addition is ordered alphabetically
[ ] My submission has a useful description
[ ] The description does not have more than 100 characters
[ ] The description does not end with punctuation
[ ] Each table column is padded with one space on either side
[ ] I have searched the repository for any relevant issues or pull requests
[ ] Any category I am creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

Also, the first API in the "Text Analysis" section has "API" at the end of the API Name (PR guidelines advise against this)

Hi @oconnoob
Thanks for your contribution ;)
We have some problems with Public APIs, so we won't be able to review/add this improvement right now.
Read this issue for more information, please: https://github.com/public-apis/public-apis/issues/3104


AQAvit Meeting - May 19, 2021

Join via https://bluejeans.com/724807178/2833?src=calendarLink
Add the recurring bi-weekly AQAvit meeting to your calendar.
Proposed Agenda:

New links in TRSS - @llxia / @OscarQQ

Running tests in parallel - @sophia-guo

Outreachy interns start May 24th - @smlambert

Looking forward to working with @SAY-droid427 @avishreekh during the summer
TBD - figure out a regularly scheduled time for interns and mentors to connect

AOB

Meeting recording link

https://github.com/adoptium/TKG/issues/197 opened to address https://github.com/adoptium/aqa-tests/issues/2566#issuecomment-844221324


return SERVER_UNAVAILABLE when no up clients on load balancer

This PR is referent for issue #303

I like the new status.

Any update / progress on merging this change?


Compile against Rust Stable

Currently we take advantage of some non-stabilized rust APIs but eventually we will want to be able to compile against Rust stable.  The below links are tracking issues that need to be closed out before we can compile against rust stable.
Update June 6 2016:  #38 introduced workaround changes that allowed rustyline to be compiled against rust stable (1.9.0).  These changes should eventually replaced by Read::chars and encode_utf8 after they become stabilized in the standard library.
TO-DO

[ ] Read::chars

rust-lang/rust Tracking Issue
replace workaround introduced in #38 (remove char_iter.rs)

[ ] encode_utf8

rust-lang/rust Tracking Issue
replace workaround introduced in #38 (remove encode_unicode crate)

[x]  str_char

rust-lang/rust Tracking Issue
stabilized in Rust-1.9

[x] path_relative_from

rust-lang/rust Tracking Issue
stabilized in Rust 1.7
change from path_relative_from to strip_prefix was addressed in https://github.com/kkawakam/rustyline/pull/23

[x] vec::Drain

rust-lang/rust Tracking Issue
stabilized in Rust 1.6

Is this now complete with the changes merged from #38 ?

@pastoraleman I'm going to leave this open because we introduced some work-arounds in #38 to compile against 1.9.0 stable.  When Read::chars and encode_utf8 become stabilized, they should replace the work-arounds introduced in #38.
I'll update the issue to reflect that change

Did you consider using https://crates.io/crates/unicode-segmentation?

@Yamakaky Correct me if I'm wrong, but it seems to me that the only places where this crate can be used is in Completer and "word" actions where the boundaries are specific (not conforming to unicode standard). And we still need to iterate on chars when reading the standard input stream...

Oh, ok.
Opened https://github.com/unicode-rs/unicode-segmentation/issues/7

Looks like this can now be closed! :)

Negative !
Read::chars is still unstable.
But, encode_unicode can be removed (encode_utf8 is stabilised).

Oh, I see now. It compiles against stable, but there's a few workarounds/reimplementations for features that aren't yet stable.

Read::chars has not been stabilized but removed !

2.0 released


[Feature] Trigger onRowSelected each time the row is clicked, even when it's unchanged

Summary
Trigger onRowSelected each time the row is clicked, even when it's unchanged
If the selected row index isn't updated the onRowSelected action is not triggered as a result in case the table has a single row data, it's not possible to trigger it.
Also there could be instances where it's expected to trigger the action on click and not only when it's updated, for example refetching some data.
Additional context
Quoting the op from discord:
I would say, a better way to achieve this is to fire onRowSelect when the table data loads and then the row gets selected according to the Default Row. Basically it means we need to fire the event regardless of whether a change is caused by the widget or a user action. Right after the data load the selection is NULL, and when the widget selects the default row (e.g. the 0th one) -- this is a change too. Firing the event on any user's click even without a change in selection is not a good idea

I think this is related to #2639 The user doesn't want to run the action every time it's clicked, they want to run it every time it's changed regardless of user input


docs: bump min eksctl version to v0.169.0

Fixes #N/A
Description
Bumps the minimum version of eksctl called out in the v0.34+ docs to v0.169.0 for EKS 1.29 support: https://github.com/eksctl-io/eksctl/releases/tag/v0.169.0
How was this change tested?
N/A
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 82.61%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.32%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5007

Relevant Lines:
6061

💛  - Coveralls


Support for bundledDependencies

I have some auto-generated code (through https://github.com/prisma/photonjs) that is located in node_modules/@generated/photon.
How can I tell eslint-plugin-import to not throw a import/no-extraneous-dependencies error? The best solution I can think of so far is to put it into the bundledDependencies. But it seems like eslint-plugin-import does not look at these.
Related: https://github.com/prisma/prisma2/issues/314

Absolutely things in bundledDependencies should not error; that seems like an (albeit very very rare) omission. A PR adding that support is welcome.

Thanks for the quick answer.
Just started to work on the PR. Comments are welcome. I will try to do more tomorrow.