C#: Finish documentation of GodotSharp public API

This PR is exclusively aimed at documentation, so absolutely no code changes were made. The sole exception is GodotSharp.csproj with the removal of <NoWarn>CS1591</NoWarn>, as it now has an accompanying docstring for every single public API.
It's entirely possible that some parts of the documentation aren't fully representative of their implementation, as the catch-22 of this scenario was a lack of documentation to know what to document. In addition, many sections were implemented through automation; while I tried my best to double-check for any potential discrepancies, it's entirely possible some still slipped through the cracks. Nonetheless, I'm largely confident in what's in place now & making adjustments at this stage will be significantly easier.

Implemented a few new fixes, most to the initial commits but a handful to existing docstrings. These include:

Fixing some erroneous paramref syntax (see paramref to paramref name)
Ensured language keywords use langword and not cref
Resolved ambiguous functions by assigning real_t (originally part of #79351)

Every change remains strictly documentation

Implemented a few new fixes, most to the initial commits but a handful to existing docstrings. These include:

I would suggest separating these fixes into a new PR, as some of the new documentation will probably need a lot of discussion and some of these bits (at least everything in the Bridge namespace) are not even really supposed to used, except by the engine.

I would suggest separating these fixes into a new PR, as some of the new documentation will probably need a lot of discussion

Done! Those bits were moved to #79748

and some of these bits (at least everything in the Bridge namespace) are not even really supposed to used, except by the engine.

Strange then that CS1591 would consider all of those "public". In either case, assuming the Nowarn will still be removed at some point, would it be better to instead have the GodotSharp .editorconfig handle more specific cases? eg:
[**/Bridge/**.cs]
# Missing XML comment for publicly visible type or member
dotnet_diagnostic.CS1591.severity = none

Very, very good points raised all around. In particular, I didn't realize just how synced a lot of the existing documentation was to existing implementations and, more importantly, the core itself. That, alongside the realization that many of these areas are meant only for internal use, made a good chunk of this PR a misguided effort
Closing in favor of multiple, more focused PRs at some later point. I'd rather have fresh starts than try to retrofit something of this scope


Fix a crash in the ASTPrinter when trying to print an inactive if-clause.

This crashed while emitting the SIL of the stdlib build.

@swift-ci smoke test and merge

We can't print un-type-checked ASTs? cc @akyrtzi

I've discussed with Erik, to fix SIL printing he should just add
result.PrintIfConfig = false;

to:
  /// Retrieve the set of options suitable for printing SIL functions.
  static PrintOptions printSIL() {

I'll open another PR to fix the crash. This PR as is now should not be merged.

@swift-ci smoke test and merge


#248: Added aliases for Hub, HubInterface to container

Code:
        dump(
            $this->sentry, // hinted Hub via constructor
            $this->container->make('sentry'),
            $this->container->make(Hub::class),
       );

Before and after:

Constructor hinting or make() of the interface was not working before this fix as well.

I do not like to bind the Hub actually, would you agree the interface would be enough?

@stayallive , good point. Done.

Hi @stayallive ,
Should I do anything else to complete this PR?

@SCIF no I couldn't merge because Travis was not done yet :) Merged now, will be released a bit later.


Sky shader renders artifacts on NVIDIA cards

Godot version
4.0.2 stable
System information
Windows 11, RX 5700. Windows 10, RTX 3050.
Issue description
The sky shader renders differently on AMD and NVIDIA cards you can note the difference here:
Windows 11, AMD RX 5700:

Windows 10, RTX 3050:

Steps to reproduce
Just open the Sky.tscn in there, you will notice strange artifacts on the ground and no clouds.
Minimal reproduction project
Godot_4_sky_shader-main.zip

So this seems to be related to the precision modifiers in the shader. A simple search&replace for lowp fixes the artifacts and the disappearing clouds on nVidia (RTX 2060, Win 10). Narrowing it down, the main offenders are clouds_3d() and SphereIntersect() for the clouds and the noise functions for the artifacts.
I'm not experienced enough with GPU stuff to guess if this is expected, but I found this in the Godot docs

Some architectures (mainly mobile) can benefit significantly from this [lower precision], but there are downsides such as the additional overhead of conversion between precisions. Refer to the documentation of the target architecture for further information. In many cases, mobile drivers cause inconsistent or unexpected behavior and it is best to avoid specifying precision unless necessary.

and on https://www.khronos.org/opengl/wiki/Type_Qualifier_(GLSL) I found this passage

Note: Precision qualifiers in GLSL are supported for compatibility with OpenGL ES. They use the same syntax as ES's qualifiers, but they have no functional effects. Do not use them unless you want your shaders to be ES compatible.

which sounds to me that using lower precision might not have an actual performance gain on desktop systems?

which sounds to me that using lower precision might not have an actual performance gain on desktop systems?

That's right. For the most part desktop drivers ignore precision qualifiers entirely. But some drivers do respect them, which is likely what leads to the issue on that specific NVidia card

Wait, am I getting this right then, that it appears wrong on the nVidia GPU because that one renders the shader more correctly than the AMD card?
So how should this be treated then? Is it a driver bug? It sounds like a driver bug... well, "bug". And the documentation already advises against using precision modifiers in most cases. Should the shader compiler strip lowp, highp and mediump away when translating to GLSL on desktop platforms?

Its not a driver bug. The precision hints are just hints that essentially set a lower bound. The drivers are always allowed to use a higher level of precision if they want.
I'm closing as this is a bug in the user's code, not in the engine


JIRA engagement level - JIRA URL not displayed when inherited

A jira configuration is enabled at product level, and not engagement level.
When editing a finding, the JIRA URL is None instead of being populated by the Product level JIRA config. I think that, since the engagement level is empty, it's looking at that.
Note that it all works as expected anyways, it's just a visual thing.

fyi @valentijnscholten

fixed by #3284


INFO Request is queued

I am trying to access ERA5 data using both cdsapi and climetlab. Just replicating the example notebook here (https://climetlab.readthedocs.io/en/latest/examples/03-source-cds.html) on my laptop as well as provided binder link.
The code works fine to plot 2m temperature and mean sea level as shown in the example notebook. However, the moment I change one of the requested variables, the notebook code gets stuck indefinitely with the following message.
source = cml.load_source(
    "cds",
    "reanalysis-era5-single-levels",
    variable=["2t", "blh"],
    product_type="reanalysis",
    area=[50, -50, 20, 50],
    date="2012-12-12",
    time="12:00",
    format="netcdf",
)
for s in source:
    cml.plot_map(s)

2021-10-25 19:31:26,858 INFO Lock<PHONE_NUMBER>24784 acquired on /tmp/climetlab-jovyan/cdsretriever-d1b901f874b7ac4e804d713920fc5c40fa5f10d2ca221b395896a72f6c9ca41b.nc.lock
2021-10-25 19:31:26,962 INFO Welcome to the CDS
2021-10-25 19:31:26,962 INFO Sending request to https://cds.climate.copernicus.eu/api/v2/resources/reanalysis-era5-single-levels
2021-10-25 19:31:27,080 INFO Request is queued

The message above is from the binder notebook but I get the same result on my laptop as well.

I am not sure I follow you
AFAIK, the CDS API (https://cds.climate.copernicus.eu/api-how-to):
import cdsapi
c = cdsapi.Client()
would still download the data.
While using the toolbox, what I call the interactive CDS API (https://cds.climate.copernicus.eu/toolbox-editor/ , you need to register):
import cdstoolbox as ct
...
would run only on the CDS machine and would not download data (to your local machine).


Data Limit (SharePoint list)

@PaoloPia , what do you think should be suggested limit of data we can put in Events and Request list. If we are talking about enterprises, there could be millions of records they might log, do you recommend SharePoint list is good for it?

Hi @nikskhubani,
I don't recommend to use SharePoint to store data for enterprises. I rather suggest (as you can read here: https://github.com/SharePoint/sp-dev-gdpr-activity-hub/blob/master/Documentation/Customization.md#data-provider-customization) to create a custom data persistence layer, which for example uses SQL Database on Azure.


Term Request: Copy number alteration?

Is there a class for Copy Number Alteration/Variation? This would only include deletion (http://purl.obolibrary.org/obo/SO_0001879) and amplification (http://purl.obolibrary.org/obo/SO_0001880). Currently both are under structural variant which includes many other kinds of variations. Thanks

Hi @stuppie,
I apologize that it has taken so long to respond to your request. There was a change in staff and I am now going through old issue requests that have been present for a few years.
Copy number changes are indeed included under structural variation. Although structural variation includes other terms, these terms fit well as children under structural_variant. The three terms that I recommend using are:
copy_number_change (SO:0001563)
copy_number_increase (SO:0001911)
copy_number_decrease (SO:0001912)
I would recommend using these terms for annotation of copy number alterations. Feel free to reopen this issue if you have further questions.
Thanks,
Dave


Closed positions don't not show payout correctly

Somehow the closed positions show a dynamic payout based on the current price instead of the actual payout of the transaction.
Example of a short positions that should be a loss but it shows a high gain.
The price also changed which means somehow we plug in the dynamic price calc.

The problem likely comes from here:
https://github.com/itchysats/itchysats/blob/c43100f68bb4369c999ef86ece0f31fc52c85430/daemon/src/projection.rs#L558-L562
This is called after the Cfd was constructed - at this point we only distinguish open and closed based on the aggregate - but we never set the CfdState to closed in the aggregate! The aggregate for closed and failed is mostly empty (no transactions set, ...), so the logic in this function will go for using the current quote to determine P/L and  payout :/

fixed with #2019


Delete

Critical Changes
Changes
Issues Closed
New Metadata
Unpackaged Metadata
Deleted Metadata
Testing Notes

 Quality gate: Passed
 Everything looks good
Details


some unit tests for PubSub Publisher and Subscriber factories

Codecov Report

Merging #1339 into master will increase coverage by 0.99%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1339      +/-   ##
============================================
+ Coverage     67.75%   68.74%   +0.99%
- Complexity     1396     1418      +22
============================================
  Files           202      202
  Lines          5635     5635
  Branches        565      565
============================================
+ Hits           3818     3874      +56
+ Misses         1585     1532      -53
+ Partials        232      229       -3

Flag
Coverage Δ
Complexity Δ

#integration
?
?

#unittests
68.74% <ø> (+0.99%)
1418 <ø> (+22)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...d/gcp/pubsub/support/DefaultSubscriberFactory.java
61.64% <0%> (+46.57%)
15% <0%> (+12%)
:arrow_up:

...ud/gcp/pubsub/support/DefaultPublisherFactory.java
97.29% <0%> (+59.45%)
15% <0%> (+10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb9613...3deac7c. Read the comment docs.

Well, I think I ruined this branch by pushing from the wrong place. If yall are interested in the +0.99% Code Coverage it adds, I'll submit a new (clean) PR.
Otherwise, I'll withdraw this.


Case sensitive selectors clash in quirks mode

Version<EMAIL_ADDRESS>Environment: Server
Type: Doc

Description
I generate a rather complex stylesheet in the context of the https://github.com/hellofresh/css-in-js-perf-tests so with server rendering.
Fela worked very well so far, but I stumbled upon a surprising issue. The layout was totally messed up, while all other libraries were good.
Upon inspection, I saw there was a clash between generated class names, like i and I.

It was supposed to be OK because according to http://stackoverflow.com/questions/12533926/are-class-names-in-css-selectors-case-sensitive class names are case sensitive. Except there is a small footnote: "In quirks mode for all browsers, classes and IDs are case-insensitive".
Okaaay, the project just generates the files without doctype... When I added it, Fela was as good as the others...
So, if that's not already in the docs (I admit I haven't read everything yet), maybe it is worth mentioning it somewhere, as a caveat.
Of course, a good new project will avoid the quirks mode, but I think it is still worth mentioning... 😄

Wow. I am impressed now. Never though that still is a thing anywhere :D
Thanks for mentioning! I will add it to the docs or eventually even remove uppercase letters. It will reduce the amount of classNames < 3 chars from 2700~ to 800~, but that's not a problem at all I guess.

@rofrischmann I guess if we have 800+ classes, we already have so much data that it most likely won't matter if we have a few 3 character class selectors in there.


Generated file has .sxpr extension instead of .py when output directory is specified on the command-line

When an output dir is specified on the command-line the generated file does not have the expected .pyextension:
$ ts2python -o /project/predict/app /project/next/src/lib/sharedtypes.ts
$ ls -1 /project/predict/app
__pycache__
main.py
sharedtypes.sxpr

Without the output dir option the generated file does have the expected .pyextension:
$ ts2python /project/next/src/lib/sharedtypes.ts
$ ls -1 /project/next/src/lib
error.ts
hooks
mongo.ts
sharedtypes.py
sharedtypes.ts
types.ts
util

Thanks for letting me know about the stupid bug! I will upload an update soon.
If you need a quick fix, please edit the file ts2pythonParser.py and change the line
RESULT_FILE_EXTENSION = ".sxpr"
to
RESULT_FILE_EXTENSION = ".py"


helm: affinity rule to ignore Fargate node

Issue #, if available:
Description of changes:
According to the documentation),  the ASCP doesn't offer support for Fargate nodes because this kind of node is incompatible with daemonset workloads.
In the context of deploying a hybrid cluster consisting of Fargate-EC2 nodes, it is possible to deploy daemonsets on those EC2 nodes. However, it's important to note that the daemonsets will remain in a "pending" state on the Fargate nodes (due to the mentioned limitation). This recommendation was formulated to include the affinity rule by default in the values file to address this specific scenario. By including this affinity rule in the values file, it helps ensure proper scheduling and allocation of daemonsets only on the EC2 nodes.
Cheers!
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for the PR, we have noted this as an enhancement request.

Thanks for the feedback @jbct

Codecov Report
Patch and project coverage have no change.

Comparison is base (8d3e503) 53.15% compared to head (3520da0) 53.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   53.15%   53.15%
=======================================
  Files           8        8
  Lines         730      730
=======================================
  Hits          388      388
  Misses        332      332
  Partials       10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


why we need to add a background class in mask prediction?

❓ Questions and Help The mas_logits is 81-channel, but I think we don't need that background channel, right?

I think we could probably remove it without affecting accuracy, but to be 100% sure we would need to test it. Anyway, this is how Detectron implements it, and I'm keeping it here for consistency with the previous implementation.


People experiences after adoption in the form of corousel

Is your feature request related to a problem? Please describe.
I would like to introduce a people experience section above contact us section in the form of a carousel
Describe the solution you'd like
A well-designed carousel to show the genuinity of the service which will lead to more traffic
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

its not currently needed for website


Updated my contribution

Made necessary changes as per the contribution guidelines. Looking forward to your acceptance of my PR

Update the README in the C++ directory also.

i have updated the readme of C++ folder. see if you can merge.
let me know if there is anything.


Remove version: Jackett.Jackett version 0.20.1799

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.1799/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 917)


Feature 33 GitHub

This PR includes the following 3 changes:

change github.com/NCAR to github.com/dtcenter
change ncar.github.io to dtcenter.github.io
all references of METdb to METdatadb

Please review the changes carefully before accepting. I wonder if changing METdb to METdatadb will cause any problems in the code.

I have reviewed the files in dtcenter/METdatadb. I updated some README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway requested your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34 Feature 33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ
.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

Venita,
Great. If you're happy with the changes, can you please approve the Pull
Request? And then you could click the "Squash and Merge" button which will
merge these changes into your master branch.
This is the process we've been following for development in the other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the source
branch.
(5) Once the PR is approved, merge the changes and delete the feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty<EMAIL_ADDRESS>wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway requested your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34 Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ
.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ
.

Hi John,
Since I was the only person on the repository for a while, and since I
haven't worked with Pull requests before, I haven't been using them. I may
need help with that.
I have been making feature branches with the issue number, but I didn't
realize you'd made one for renaming the repository.
Also, I didn't think we were renaming METdbLoad.py. I thought the two teams
discussed that, and Tara was going to tell us if we needed to, but she
wasn't expecting that we would.
Thank you,
Venita
On Thu, Aug 20, 2020 at 12:06 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
Great. If you're happy with the changes, can you please approve the Pull
Request? And then you could click the "Squash and Merge" button which will
merge these changes into your master branch.
This is the process we've been following for development in the other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the source
branch.
(5) Once the PR is approved, merge the changes and delete the feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty<EMAIL_ADDRESS>wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway requested your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34 Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800, or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ
.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677816749,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGI4XW62GJQLK7XVPF6UALSBVQ3DANCNFSM4QFNWKQQ
.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

I also hadn't updated to Master for a while, and I'm wondering if you used
master as your base?
Venita
On Thu, Aug 20, 2020 at 1:22 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

Hi John,
Since I was the only person on the repository for a while, and since I
haven't worked with Pull requests before, I haven't been using them. I may
need help with that.
I have been making feature branches with the issue number, but I didn't
realize you'd made one for renaming the repository.
Also, I didn't think we were renaming METdbLoad.py. I thought the two
teams discussed that, and Tara was going to tell us if we needed to, but
she wasn't expecting that we would.
Thank you,
Venita
On Thu, Aug 20, 2020 at 12:06 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
Great. If you're happy with the changes, can you please approve the Pull
Request? And then you could click the "Squash and Merge" button which will
merge these changes into your master branch.
This is the process we've been following for development in the other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the source
branch.
(5) Once the PR is approved, merge the changes and delete the feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty<EMAIL_ADDRESS>
wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway requested
your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34
Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800, or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ
.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677816749,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGI4XW62GJQLK7XVPF6UALSBVQ3DANCNFSM4QFNWKQQ
.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

Venita,
I did see that my sed commands had changed some names like that. And I
wasn't totally sure about that.
And I totally understand not using PR's when you're working alone. No need
really. I just wanted to submit my changes in this way so that you'd review
them.
I'm glad to see you have a "develop" branch in there. Let me redo this PR
with a branch from develop instead.
And to avoid confusion, can we please just remove the master branch? We
don't have a master in the other METplus repos (or at least we shouldn't).
Instead, we have develop for new work going into the next release, and
master_vX.Y for each stable release. So when you do a v1.0 release, you'd
copy develop over into master_v1.0 and then you'd commit any bufixes for
v1.0 into both master_v1.0 (for a potential v1.0.1 bugfix release) and the
develop branch (for the next version).
Does that all make sense?
Thanks,
John
On Thu, Aug 20, 2020 at 1:31 PM Venita Hagerty<EMAIL_ADDRESS>wrote:

I also hadn't updated to Master for a while, and I'm wondering if you used
master as your base?
Venita
On Thu, Aug 20, 2020 at 1:22 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

Hi John,
Since I was the only person on the repository for a while, and since I
haven't worked with Pull requests before, I haven't been using them. I
may
need help with that.
I have been making feature branches with the issue number, but I didn't
realize you'd made one for renaming the repository.
Also, I didn't think we were renaming METdbLoad.py. I thought the two
teams discussed that, and Tara was going to tell us if we needed to, but
she wasn't expecting that we would.
Thank you,
Venita
On Thu, Aug 20, 2020 at 12:06 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
Great. If you're happy with the changes, can you please approve the Pull
Request? And then you could click the "Squash and Merge" button which
will
merge these changes into your master branch.
This is the process we've been following for development in the other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the source
branch.
(5) Once the PR is approved, merge the changes and delete the feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through
Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty <
<EMAIL_ADDRESS>
wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway requested
your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34
Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ

.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677816749,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AJGI4XW62GJQLK7XVPF6UALSBVQ3DANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677857757,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA4HKCJQUS7UZ7KGNWFPUDSBV2YHANCNFSM4QFNWKQQ
.

Closing this PR without merging. Need to redo using a branch from develop, not master. And be sure not to change METdbLoad to METdatadbLoad! That should remain unchanged.

I've been trying to model what I do after the METviewer repository. It
looks like that's transitioning to what you're describing. Is this
described in the developer notes somewhere so I can refer back to it?
I think I understand, and it sounds clearer without a single master branch.
When I do a release, I make sure the develop branch is completely ready,
and then I make a copy of it named as master with the release number. Over
time, as I have multiple releases, I'll wind up with multiple
master+release# branches. And I could remove the current master branch, and
make develop the default.
Thank you,
Venita
On Thu, Aug 20, 2020 at 2:09 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
I did see that my sed commands had changed some names like that. And I
wasn't totally sure about that.
And I totally understand not using PR's when you're working alone. No need
really. I just wanted to submit my changes in this way so that you'd review
them.
I'm glad to see you have a "develop" branch in there. Let me redo this PR
with a branch from develop instead.
And to avoid confusion, can we please just remove the master branch? We
don't have a master in the other METplus repos (or at least we shouldn't).
Instead, we have develop for new work going into the next release, and
master_vX.Y for each stable release. So when you do a v1.0 release, you'd
copy develop over into master_v1.0 and then you'd commit any bufixes for
v1.0 into both master_v1.0 (for a potential v1.0.1 bugfix release) and the
develop branch (for the next version).
Does that all make sense?
Thanks,
John
On Thu, Aug 20, 2020 at 1:31 PM Venita Hagerty<EMAIL_ADDRESS>wrote:

I also hadn't updated to Master for a while, and I'm wondering if you
used
master as your base?
Venita
On Thu, Aug 20, 2020 at 1:22 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

Hi John,
Since I was the only person on the repository for a while, and since I
haven't worked with Pull requests before, I haven't been using them. I
may
need help with that.
I have been making feature branches with the issue number, but I didn't
realize you'd made one for renaming the repository.
Also, I didn't think we were renaming METdbLoad.py. I thought the two
teams discussed that, and Tara was going to tell us if we needed to,
but
she wasn't expecting that we would.
Thank you,
Venita
On Thu, Aug 20, 2020 at 12:06 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
Great. If you're happy with the changes, can you please approve the
Pull
Request? And then you could click the "Squash and Merge" button which
will
merge these changes into your master branch.
This is the process we've been following for development in the other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue
number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the source
branch.
(5) Once the PR is approved, merge the changes and delete the feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through
Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty <
<EMAIL_ADDRESS>
wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some
README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway requested
your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34
Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ

.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677816749
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XW62GJQLK7XVPF6UALSBVQ3DANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677857757,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFA4HKCJQUS7UZ7KGNWFPUDSBV2YHANCNFSM4QFNWKQQ
.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677877914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGI4XQIKCSEHK7DSXEAS4TSBV7IJANCNFSM4QFNWKQQ
.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

Okay, I made develop the default branch and merged the pull request into
develop. I deleted the master branch and a few older branches. There are
still a few extra feature branches. Should I click on the New pull request
button for those branches? Or delete them?
Thank you,
Venita
On Thu, Aug 20, 2020 at 2:21 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

I've been trying to model what I do after the METviewer repository. It
looks like that's transitioning to what you're describing. Is this
described in the developer notes somewhere so I can refer back to it?
I think I understand, and it sounds clearer without a single master
branch. When I do a release, I make sure the develop branch is completely
ready, and then I make a copy of it named as master with the release
number. Over time, as I have multiple releases, I'll wind up with multiple
master+release# branches. And I could remove the current master branch, and
make develop the default.
Thank you,
Venita
On Thu, Aug 20, 2020 at 2:09 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
I did see that my sed commands had changed some names like that. And I
wasn't totally sure about that.
And I totally understand not using PR's when you're working alone. No need
really. I just wanted to submit my changes in this way so that you'd
review
them.
I'm glad to see you have a "develop" branch in there. Let me redo this PR
with a branch from develop instead.
And to avoid confusion, can we please just remove the master branch? We
don't have a master in the other METplus repos (or at least we shouldn't).
Instead, we have develop for new work going into the next release, and
master_vX.Y for each stable release. So when you do a v1.0 release, you'd
copy develop over into master_v1.0 and then you'd commit any bufixes for
v1.0 into both master_v1.0 (for a potential v1.0.1 bugfix release) and the
develop branch (for the next version).
Does that all make sense?
Thanks,
John
On Thu, Aug 20, 2020 at 1:31 PM Venita Hagerty<EMAIL_ADDRESS>wrote:

I also hadn't updated to Master for a while, and I'm wondering if you
used
master as your base?
Venita
On Thu, Aug 20, 2020 at 1:22 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

Hi John,
Since I was the only person on the repository for a while, and since I
haven't worked with Pull requests before, I haven't been using them. I
may
need help with that.
I have been making feature branches with the issue number, but I
didn't
realize you'd made one for renaming the repository.
Also, I didn't think we were renaming METdbLoad.py. I thought the two
teams discussed that, and Tara was going to tell us if we needed to,
but
she wasn't expecting that we would.
Thank you,
Venita
On Thu, Aug 20, 2020 at 12:06 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
Great. If you're happy with the changes, can you please approve the
Pull
Request? And then you could click the "Squash and Merge" button which
will
merge these changes into your master branch.
This is the process we've been following for development in the other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue
number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the source
branch.
(5) Once the PR is approved, merge the changes and delete the feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through
Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty <
<EMAIL_ADDRESS>
wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some
README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway
requested
your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34
Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<https://github.com/dtcenter/METdatadb/pull/34#event-3672860800
,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ

.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677816749>,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XW62GJQLK7XVPF6UALSBVQ3DANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677857757,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AFA4HKCJQUS7UZ7KGNWFPUDSBV2YHANCNFSM4QFNWKQQ
.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677877914,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJGI4XQIKCSEHK7DSXEAS4TSBV7IJANCNFSM4QFNWKQQ
.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

Venita,
The intended workflow is listed in the "checklist" at the bottom of each
GitHub issue template (e.g. feature branch naming conventions, etc). So you
could look there for a brief overview.
The git workflow is described in more detail here:
https://dtcenter.github.io/METplus/Contributors_Guide/github_workflow.html
And I actually have a GitHub issue to describe the pull request approval
process in that git workflow (https://github.com/dtcenter/METplus/issues/429
).
But I haven't gotten to that yet.
As for what to do with your existing feature branches, if those changes
have already been merged into develop, I'd recommend deleting them. If not,
then it's up to you.
FYI, I've also been meeting with Keith Searight and other METplus folks
about how to use TravisCI across all of our repos. The goal is so that when
someone submits a pull request to change develop or a master_vX.Y branch,
that'd automatically trigger Travis to run a bunch of tests to make sure
those changes don't break anything. So hopefully, we'll eventually be able
to integrate that into all of our repos. But I do realize that figuring out
exactly what tests should be run is a big question!
Thanks,
John
On Thu, Aug 20, 2020 at 2:41 PM Venita Hagerty<EMAIL_ADDRESS>wrote:

Okay, I made develop the default branch and merged the pull request into
develop. I deleted the master branch and a few older branches. There are
still a few extra feature branches. Should I click on the New pull request
button for those branches? Or delete them?
Thank you,
Venita
On Thu, Aug 20, 2020 at 2:21 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

I've been trying to model what I do after the METviewer repository. It
looks like that's transitioning to what you're describing. Is this
described in the developer notes somewhere so I can refer back to it?
I think I understand, and it sounds clearer without a single master
branch. When I do a release, I make sure the develop branch is completely
ready, and then I make a copy of it named as master with the release
number. Over time, as I have multiple releases, I'll wind up with
multiple
master+release# branches. And I could remove the current master branch,
and
make develop the default.
Thank you,
Venita
On Thu, Aug 20, 2020 at 2:09 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
I did see that my sed commands had changed some names like that. And I
wasn't totally sure about that.
And I totally understand not using PR's when you're working alone. No
need
really. I just wanted to submit my changes in this way so that you'd
review
them.
I'm glad to see you have a "develop" branch in there. Let me redo this
PR
with a branch from develop instead.
And to avoid confusion, can we please just remove the master branch? We
don't have a master in the other METplus repos (or at least we
shouldn't).
Instead, we have develop for new work going into the next release, and
master_vX.Y for each stable release. So when you do a v1.0 release,
you'd
copy develop over into master_v1.0 and then you'd commit any bufixes for
v1.0 into both master_v1.0 (for a potential v1.0.1 bugfix release) and
the
develop branch (for the next version).
Does that all make sense?
Thanks,
John
On Thu, Aug 20, 2020 at 1:31 PM Venita Hagerty <
<EMAIL_ADDRESS>wrote:

I also hadn't updated to Master for a while, and I'm wondering if you
used
master as your base?
Venita
On Thu, Aug 20, 2020 at 1:22 PM Venita Hagerty - NOAA Affiliate <
<EMAIL_ADDRESS>wrote:

Hi John,
Since I was the only person on the repository for a while, and
since I
haven't worked with Pull requests before, I haven't been using
them. I
may
need help with that.
I have been making feature branches with the issue number, but I
didn't
realize you'd made one for renaming the repository.
Also, I didn't think we were renaming METdbLoad.py. I thought the
two
teams discussed that, and Tara was going to tell us if we needed to,
but
she wasn't expecting that we would.
Thank you,
Venita
On Thu, Aug 20, 2020 at 12:06 PM johnhg<EMAIL_ADDRESS>wrote:

Venita,
Great. If you're happy with the changes, can you please approve the
Pull
Request? And then you could click the "Squash and Merge" button
which
will
merge these changes into your master branch.
This is the process we've been following for development in the
other
METplus repos.
(1) Write up an issue to describe the new work.
(2) Create a feature branch for that work that includes the issue
number
(e.g. feature_33_github).
(3) Do the work in the feature branch.
(4) Submit a pull request to merge those changes back into the
source
branch.
(5) Once the PR is approved, merge the changes and delete the
feature
branch.
So we're at steps (4) and (5) here. If you'd prefer to meet through
Google
and share screens for this, please just let me know.
Thanks,
John
On Thu, Aug 20, 2020 at 11:29 AM Venita Hagerty <
<EMAIL_ADDRESS>
wrote:

I have reviewed the files in dtcenter/METdatadb. I updated some
README
files and some comments in code. It looks good to me.
On Wed, Aug 19, 2020 at 4:45 PM johnhg<EMAIL_ADDRESS>

wrote:

@JohnHalleyGotway https://github.com/JohnHalleyGotway
requested
your
review on: #34 https://github.com/dtcenter/METdatadb/pull/34
Feature
33
GitHub.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<
https://github.com/dtcenter/METdatadb/pull/34#event-3672860800
,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XVWZZAUGB5R6MQ4F6TSBRIZFANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677798966
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AFA4HKD4R76WPSIR47VUZLTSBVMQHANCNFSM4QFNWKQQ

.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677816749>,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AJGI4XW62GJQLK7XVPF6UALSBVQ3DANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677857757
,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AFA4HKCJQUS7UZ7KGNWFPUDSBV2YHANCNFSM4QFNWKQQ

.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677877914,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AJGI4XQIKCSEHK7DSXEAS4TSBV7IJANCNFSM4QFNWKQQ

.

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098

--
Venita Hagerty, PhD
Research Associate
CIRA at NOAA, GSL/AVID
2B152, x6098
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METdatadb/pull/34#issuecomment-677892981,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFA4HKHVGPBBMOVFO43VSV3SBWDBBANCNFSM4QFNWKQQ
.


[BUG] @Integer annotation is no more taking into model when used with @Nullable(Number)

Describe the bug
@Nullable decorator, used in conjunction with @Integer(), causes AJV to return error (when a string is sent instead of a number) with expected type as "null, number" instead of "null, integer"
To Reproduce

Fetch https://github.com/Bugslive/nullable

Install package with npm install

Start the app with npm start

Send POST request to http://<IP_ADDRESS>:8083/rest/nullable with body {"name": "toto", "description": "aaaaaaa", "itemCount": "toto"}

Observe the answer, and especially error[0].params.type

Compare with error with v7.75.3

Expected behavior
expected params.type is [null, integer] instead of [null, number]
Code snippets
export class MySchema {
    @Property()
    @Integer()
    @Nullable(Number)
    itemCount: Number | null;
}

@Controller("/test")
export class TestController {
    @Post("/validation")
    validate(@BodyParams() body: MySchema) {
        return body;
    }
}

Repository URL example
https://github.com/Bugslive/nullable
OS
macOS
Node version
Node v22.4.1
Library version
v7.75.5
Additional context
No response

JsonSchema on 7.75.3:
{
  "type": "object",
  "properties": {
    "name": {
      "type": "string",
      "description": "Example name",
      "minLength": 1
    },
    "description": {
      "type": [
        "null",
        "string"
      ],
      "maxLength": 10,
      "description": "Example description"
    },
    "itemCount": {
      "type": [
        "null",
        "integer"
      ],
      "multipleOf": 1,
      "minimum": 0,
      "examples": [
        3600
      ],
      "description": "Example integer"
    }
  },
  "description": "Service account creation",
  "required": [
    "name"
  ]
}

Error:
{
  "name": "AJV_VALIDATION_ERROR",
  "message": "Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,integer. Given value: \"toto3\"",
  "status": 400,
  "errors": [
    {
      "instancePath": "/itemCount",
      "schemaPath": "#/properties/itemCount/type",
      "keyword": "type",
      "params": {
        "type": [
          "null",
          "integer"
        ]
      },
      "message": "must be null,integer",
      "data": "toto2",
      "modelName": "ExampleModel",
      "dataPath": ".itemCount",
      "requestPath": "body"
    }
  ]
}

JSON schema 7.75.5
{
  "name": "AJV_VALIDATION_ERROR",
  "message": "Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,integer. Given value: \"toto2\"",
  "status": 400,
  "errors": [
    {
      "instancePath": "/itemCount",
      "schemaPath": "#/properties/itemCount/type",
      "keyword": "type",
      "params": {
        "type": [
          "null",
          "integer"
        ]
      },
      "message": "must be null,integer",
      "data": "toto2",
      "modelName": "ExampleModel",
      "dataPath": ".itemCount",
      "requestPath": "body"
    }
  ],
 }

Error:
{
  "name": "AJV_VALIDATION_ERROR",
  "message": "Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,integer. Given value: \"toto3\"",
  "status": 400,
  "errors": [
    {
      "instancePath": "/itemCount",
      "schemaPath": "#/properties/itemCount/type",
      "keyword": "type",
      "params": {
        "type": [
          "null",
          "integer"
        ]
      },
      "message": "must be null,integer",
      "data": "toto3",
      "modelName": "ExampleModel",
      "dataPath": ".itemCount",
      "requestPath": "body"
    }
  ]
}

Same result :)
See you
Romain

Hello Romain,
on my side, I check again on my side with my "nullable" project and I confirm my remarks
with 7.75.3:
{   "name": "AJV_VALIDATION_ERROR",   "message": "Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,integer. Given value: \"toto3\"",   "status": 400,   "errors": [     {       "instancePath": "/itemCount",       "schemaPath": "#/properties/itemCount/type",       "keyword": "type",       "params": {         "type": [           "null",           "integer"         ]       },       "message": "must be null,integer",       "data": "toto3",       "modelName": "ExampleModel",       "dataPath": ".itemCount",       "requestPath": "body"     }   ],   "stack": "PARAM_VALIDATION_ERROR: Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,integer. Given value: \"toto3\"\n    at new Exception (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/exceptions/src/core/Exception.ts:62:11)\n    at new ClientException (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/exceptions/src/core/ClientException.ts:6:5)\n    at new BadRequest (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/exceptions/src/clientErrors/BadRequest.ts:7:5)\n    at new ParamValidationError (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/errors/ParamValidationError.ts:6:1)\n    at Function.from (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/errors/ParamValidationError.ts:20:21)\n    at /Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/builder/PlatformParams.ts:83:36\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at /Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/builder/PlatformParams.ts:78:15\n    at async Promise.all (index 0)\n    at async Promise.all (index 1)" }
with 7.75.5:
{   "name": "AJV_VALIDATION_ERROR",   "message": "Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,number. Given value: \"toto3\"",   "status": 400,   "errors": [     {       "instancePath": "/itemCount",       "schemaPath": "#/properties/itemCount/type",       "keyword": "type",       "params": {         "type": [           "null",           "number"         ]       },       "message": "must be null,number",       "data": "toto3",       "modelName": "ExampleModel",       "dataPath": ".itemCount",       "requestPath": "body"     }   ],   "stack": "PARAM_VALIDATION_ERROR: Bad request on parameter \"request.body\".\nExampleModel.itemCount must be null,number. Given value: \"toto3\"\n    at new Exception (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/exceptions/src/core/Exception.ts:62:11)\n    at new ClientException (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/exceptions/src/core/ClientException.ts:6:5)\n    at new BadRequest (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/exceptions/src/clientErrors/BadRequest.ts:7:5)\n    at new ParamValidationError (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/errors/ParamValidationError.ts:6:1)\n    at Function.from (/Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/errors/ParamValidationError.ts:20:21)\n    at /Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/builder/PlatformParams.ts:83:36\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at /Users/vincent/workspace/tmp/nullable/node_modules/@tsed/platform-params/src/builder/PlatformParams.ts:78:15\n    at async Promise.all (index 0)\n    at async Promise.all (index 1)" }

and in my swagger for itemCount property,
with 7.75.3:
"itemCount": {
  "type": "integer",
  "multipleOf": 1,
  "minimum": 0,
  "example": 3600,
  "description": "Example integer",
  "nullable": true
}

with 7.75.5:
"itemCount": {
  "type": "number",
  "multipleOf": 1,
  "minimum": 0,
  "example": 3600,
  "description": "Example integer",
  "nullable": true
}

@Bugslive Next time please be more precise about your issue, because you talking about ajv issue and not about swagger spec which is two different things. I consider your bug isn't really a bug whil multipleOf is present in the schema  ;)

And for the error los, I haven't the same result as I said in my previous comment.

@Romakita , sorry if I was not clear.
The fact that in the swagger, and as well as in ajv error, the type is "number" in v7.75.5 instead of "integer" in v7.75.3 is for me a regression, even it is minor and that's why I opened a bug.

:tada: This issue has been resolved in version 7.76.1 :tada:
The release is available on:

v7.76.1
GitHub release

Your semantic-release bot :package::rocket:

Thanks a lot @Romakita

Thank you too @Bugslive for your reactivity and your issues!


Use abstractions appropriately

Before going 1.0 we should review our use of abstractions. Based on recent conversations I propose this approach:

On OuterLoop level we should be dealing in ModelUpdater, CandPointCalc and so on.
On concrete method level we should be dealing in problem specific terms: acquisition, update step size, etc.
If concrete method does not suit user needs, it should be clear how to create own implementation of the OuterLoop. In fact, users should be encouraged to do that.

There are few places in the code base where we currently don't follow this approach, and if everyone agrees with this proposal, we should identify and fix those places.

@marpulli @javiergonzalezh @mmahsereci let me know your thoughts!

I agree with this. One of the things that we need to do is to separate the logic of computing the next points from the logic of optimizing an acquisition that is passed in. In the sequential way of collecting points it make sense having them together but as soon as we start computing batches things can be more complex.

Closing as Mark sorted this one out already.

Let's keep it open for now, as we still need to review the loop's APIs to make sure they are consistent.


Check if you need a permit:  The language used 'the area where you'd like to park' is unclear

Impact: Users may not enter the correct postcode at this point.
Evidence: User questioned whether they should enter their home postcode or somewhere else where they would like to park.

Apologies!!! Not used to using GitHub so inadvertently closed this!

resolved by #294


global: make a new minor release

Add a warning to the offload of files: warning.userwarning('This streaming does not support multiple storage backends.')


fix: invalid link

Summary

Screenshots (optional)

Documentation checklist

[ ] The documentation style guide has been adhered to.
[ ] If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
[ ] Files which have changed name or location have been allocated redirects.

Thank you, @ken0x0a 👍
Also closes #16356


chore(deps): update all non-major dependencies

This PR contains the following updates:

Package
Type
Update
Change

@types/node (source)
devDependencies
patch
^20.16.5 -> ^20.16.6

vite-plugin-dts
devDependencies
patch
^4.2.1 -> ^4.2.2

Release Notes

qmhc/vite-plugin-dts (vite-plugin-dts)
v4.2.2
Compare Source
Bug Fixes

correctly get package info in pnp mode (984f487), closes #384

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Hywax Assistant.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (37b4a65) to head (7f2ab41).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          146       146
  Branches        25        26    +1
=========================================
  Hits           146       146

Flag
Coverage Δ

100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


router: Add support for per-route configurable maximum number of internal redirect hops

Description: Add support for per-route configurable maximum number of internal redirect hops
Risk Level: Medium
Testing: Unit and integration tests added / modified
Docs Changes: Described the new field in intro/arch_overview/http/http_connection_management.rst
Release Notes: Added
Fixes #9144

/assign @alyssawilk

Sending this proposal out here so that we can discuss the API:
a) configure a per-route max hops for number of hops before the given route is hit within the context of a given downstream request;
b) the first route that receives the request will decide the maximum hops to follow on the rest of the redirect chain;
c) a HCM level configuration
I chose a) because it groups the configuration together with the internal_redirect_action for clarity, it also makes the semantics become "each route decides what to do".

/retest

macos test failure seems to be unrelated.

/lgtm api

@htuch looks like that didn't take for "presubmit checks."

/lgtm api


Does Azure MySQL Support User Assigned identity?

Does Azure MySQL Support User Assigned identity?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c14be959-8179-60ec-74a9-bf9f2a45aaab
Version Independent ID: 5926fd18-6fa0-30db-1dce-6a0aff4ac3c9
Content: Overview - Azure Database for MySQL
Content Source: articles/mysql/overview.md
Service: mysql
GitHub Login: @ajlam
Microsoft Alias: andrela

@RonnieQuan We are checking this and we will get back to you.

@RonnieQuan, yes this is supported. Please learn more in our how-to guide: https://docs.microsoft.com/en-us/azure/mysql/howto-connect-with-managed-identity

@ajlam Thanks for the prompt reply.
The feature we need is to associate a user assigned identity with MySQL server itself.
So that MySQL Server can use user assigned identity to access other resource, e.g. key vault.
Seems it's not supported, so far I think we can only assign system managed identity to MySQL server itself.
Can you please confirm?

@lfittl-msft for assistance

@RonnieQuan Thats correct, i.e. we don't support using managed identity to have MySQL queries access other resources in Azure (at least not today)
Can you share more what your use case is?

@lfittl I believe it support system assigned identity
https://docs.microsoft.com/en-us/cli/azure/mysql/server?view=azure-cli-latest#az-mysql-server-create-optional-parameters
--assign-identity
Generate and assign an Azure Active Directory Identity for this server for use with key management services like Azure KeyVault.
az mysql server create --admin-password
--admin-user
--name
--resource-group
--sku-name
[--assign-identity]
Our use case is that one primary MySQL server, one replica, and we would like to create managed identity and this identity will be assigned to both MySQL instances as user assigned managed identity.
We would like update keyvault access policy to grant key permission to this user assigned identity.
Encryption requires MySQL to have access to the keyvault.
For other PaaS service, e.g. App Service, it does support both system assigned identity and user assigned identity.

@RonnieQuan Ah, I see - so you are looking to configure this in the context of customer-managed encryption keys. I was missing that part of the information.
Let me reach out to the correct person on the team to review this - I'll ask them to reach out here. Thanks!

@RonnieQuan currently we do not support user defined identities for customer managed encryption keys. We are working on the design for it and will support it in future.
Regards,
Manish Kumar

@RonnieQuan Please confirm if you need any further help or we can go ahead and close this thread.

@kummanish Thanks for the information. Do you have date on your roadmap for MySQL user assigned identity?
Thanks!

@RonnieQuan Please add this ask on https://feedback.azure.com/forums/597982-azure-database-for-mysql to get this added to the feedback for the product and Product Team will prioritize this.
For now we will be going and closing this request.


Update visit page

Basic Information
Updating the visit page with new specifications

[x] Add day names (monday etc.)
[ ] Hide reporting to edit (report an incident, register vet concern). Buttons should only show up when clicking edit
[x] Display name should be called client name
[x] End time not necessary, all we need is duration. Create a drop down with times in increments of 15. (15mins, 30mins, 45mins, ..., 2 hours etc.)
[x] client/pet name should be pulled from contact list, similar to home page form. Drop down with the names but can also search.

Other Information
Potential scopes:

Hey @skyheat, is the last thing to do for 'Update visit page' the hiding of the report buttons?
If so is the task asking for the buttons to only be visible when editing the visit instance OR to only be visible in read only mode (when not editing)?
Visible in Read mode?

Or visible in edit mode?

@Techno-UWA This issue is resolved in the #119 PR


Add easy install script for Linux aarch64

We have one for x86_64 but not aarch64.
@bumi started working on one https://gist.github.com/bumi/8e56c5e354441cee3bed8859b94210e3

done


hostname and remoteHost both return event.getRemoteHost()

What's the difference between the fieldsHostname and fieldsRemoteHost fields? Both return the same information which seems like a wasted effort or some bug lurking.

Hmm.  Looks like it has been that way since support was first added for access events.  I'm not sure why.
Here's the initial commit for support for access events.
It has since been separated out into separate providers, but the functionality remains the same.  I think the fieldsHostname should be removed, but I'd prefer to wait until a major release (e.g. 5.0) since this is a somewhat backwards incompatible change.
In the meantime, if you're using LogstashAccessEncoder/Layout, you can remove the fieldsHostname from being output like this:
<encoder class="net.logstash.logback.encoder.LogstashAccessEncoder">
  <fieldNames>
    <fieldsHostname>[ignore]</fieldsHostname>
  </fieldNames>
</encoder>

hostname field has been removed in 5.0 (not released yet)


AQAvit meeting Feb 10, 2021

AQAvit Meeting Feb 10, 2021
Wednesday, Feb 10 11:30am – 12:00pm EST (+5hrs for Hursley/London)
Description: Bi-weekly meeting to discuss AdoptOpenJDK Quality Assurance (AQA) topics.
Join with Google Meet
meet.google.com/pbn-ijez-avs
Proposed Agenda:

Time-based system tests #2203 - @Mesbah-Alam
Recent investigations into the mauve suite and the intrigue of the math package - @lumpfish
Progress on CanOSP EPIC (Change-based testing) - @smlambert @llxia @sophia-guo
Dacapo perf in TRSS - @OscarQQ @llxia

Recording link


--no-hw crashes without VA-API drivers

VA-API drivers may not be available for some GPUs nor installed by default. Found while testing in a pristine jail with Wayland socket passed through.
$ wl-screenrec --no-hw
Using output DP-1
[AVHWDeviceContext @ 0x3f654ad931c0] Failed to initialise VAAPI connection: -1 (unknown libva error).
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `-5`,
 right: `0`', src/avhw.rs:34:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Abort trap

Yeah, that's a good point. The way it's currently written uses vaapi to allocate and do pixel format conversion, even if --no-hw is passed.
Honestly, in this case with no vaapi driver this project has no benefit over wf-recorder, and it would be a decent bit of work to support this. Potential ways this could be done are:

Allocate the dmabuf surfaces ourselves, and then do our own upload
Add a path to do shared memory frame copies instead of dmabuf. This is probably the way to go, as it could also enable using this when capturing a small area of a large display (as currently dmabuf copies have to be entire displays)

Note that #90 will "fix" this by allowing you to use vulkan as an allocator instead.

Going to close in favor of #95, which will address this (vulkan is a much more ubiqutious allocator than vaapi)


strict-builder fails at building poetry

I'm not sure if this is dream2nix related or something with my setup. I'm getting this error when I try to build my node project using strict-builder:
error: builder for '/nix/store/r1wi4zal4ilf72r2cmqdpyckpz9zfps5-python3.10-poetry-1.2.0.drv' failed with exit code 1;
       last 10 log lines:
       > FAILED tests/utils/test_authenticator.py::test_authenticator_uses_env_provided_credentials_matched_by_url_path
       > FAILED tests/utils/test_authenticator.py::test_authenticator_uses_certs_from_config_if_not_provided[/path/to/provided/cert-path/to/provided/client-cert]
       > FAILED tests/utils/test_authenticator.py::test_authenticator_azure_feed_guid_credentials
       > FAILED tests/utils/test_authenticator.py::test_authenticator_uses_credentials_from_config_matched_by_url_path
       > FAILED tests/utils/test_authenticator.py::test_authenticator_add_repository
       > FAILED tests/utils/test_authenticator.py::test_authenticator_uses_credentials_from_config_with_at_sign_in_path
       > FAILED tests/utils/test_authenticator.py::test_authenticator_falls_back_to_keyring_url_matched_by_path
       > FAILED tests/installation/test_chooser.py::test_chooser_chooses_universal_wheel_link_if_available[]
       > FAILED tests/installation/test_chooser.py::test_chooser_chooses_universal_wheel_link_if_available[legacy]

That's a bit hard to reproduce or understand without having an idea what your setup looks like. Can you post a minimal flake.nix and command to reproduce this issue?


kubectl-gadget: update version flag to match upstream

Description of changes
Due to upstream changes, the flag used to set the version results in the binary currently returning:
❯ kubectl gadget version
Client version: v0.0.0

This PR updates the flag to match the upstream Makefile such that it returns the correct version.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Diff LGTM.
It'd be great if you could add a testers.testVersion test to catch this going forward but while reviewing this, it appears that you can't run --version without a server running? That seems like an oversight.

@Atemu Yeah, agree -- didn't see an obvious way to return client version without a functioning Kubernetes API endpoint -- would be nice to be able to actually test for it in a meaningful way.

Hey @devusb 👋🏻, I think we can run version without having server installed.
$ ./kubectl-gadget version
Client version: v0.28.1
Server version: not installed
$ echo $?
0

I think if you use --version flag then only servers are required.
$ ./kubectl-gadget --version
FATA[0000] No running Inspektor Gadget instances found

Please let me know if I missed something here.

hey! the problem happens when I'm on a system with no kubeconfig (like OfBorg) -- this is what it returns for both of those:
❯ kubectl-gadget version
FATA[0000] Searching for running Inspektor Gadget instances: Get "http://localhost:8080/apis/apps/v1/daemonsets?fieldSelector=metadata.name%3Dgadget&labelSelector=k8s-app%3Dgadget": dial tcp [::1]:8080: connect: connection refused
❯ kubectl-gadget --version
FATA[0000] Searching for running Inspektor Gadget instances: Get "http://localhost:8080/apis/apps/v1/daemonsets?fieldSelector=metadata.name%3Dgadget&labelSelector=k8s-app%3Dgadget": dial tcp [::1]:8080: connect: connection refused

it doesn't need an Inspektor Gadget server installed in the cluster to work, but as far as I can tell, it does not work if there is no cluster API to connect to.


Fix typo in documentation

Summary
Fix a couple typos:

I'm certain about It's is → It is.
Not sure about is it's → if it's because I don't understand the sentence.

Test Plan
No tests.

Thanks! These are correct.


Bug fixes for CopyButton in Safari & Input Tooltip

This address two issues:

Fixes an issue with the Input tooltip not closing as expected when another Tooltip is hovered
Fixes a styling issue caused specificity issues in Safari

Pull Request Test Coverage Report for Build 3322

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.628%

Totals

Change from base Build 3321:
0.0%

Covered Lines:
6366

Relevant Lines:
6594

💛  - Coveralls


Apparent Lack of Sspport for retina on mac

What OS are you using (uname -a, or Windows version)?
Darwin unknown 17.6.0 Darwin Kernel Version 17.6.0: Tue May  8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64
What programming language are you using (C/C++/Go/Rust)?
go version go1.10.2 darwin/amd64
What did you expect to see and what you saw instead?
I was expecting to support retina displays but I saw this:

from left to right its safari, the webview and chrome.
Actually it's the whole window, event the close maximize and title are not showing as the other apps.

This is actually apparently not this project concern. Retina support can be set in the app Info.plist file with:
  <key>NSHighResolutionCapable</key>
  <true/>


Update systray icon dynamically [feature request]

Hi, I'm currently writing a systray app where the user can change the systray icon, it would be great if node-systray had a method where you could dynamically update the icon. At the moment I have to tell the user to restart the app for the new icon to show.
Thanks for the module btw, it's great.

@Darkle I think you should be able to update the menu icon dynamically, the action type have three kind, update-item, update-menu, update-menu-and-item, see:
https://zaaack.github.io/node-systray/modules/_index_.html#action
Currently, you might need at least provide three fields of menu.
systray.onClick(action => {
    if (action.seq_id === 0) {
        systray.sendAction({
            type: 'update-menu',
            menu: {
              icon: '...',
              title: '...',
              tooltip: '...',
            },
            seq_id: action.seq_id,
        })
    }
})

This cannot add/remove items, I guess currently you can kill the systray and recreate it if you want to change the items count dynamically. I'll try to make the API more flexible if I have time, compiling systray on three OS is a little tedious.

@zaaack Thanks for the reply, I was actually looking to change the icon of the app in the system tray rather than the icon for a menu item. If that's not possible it's no worries, having the user restart the app isn't a big deal, thanks anyway. 😀

Sorry for the unclear API, I actually mean the icon of systray, if the type of action  update-menu then it will change the systray.

Hey thanks that worked! 😀
I seemed to need to re-add the items though.
If I just did:
        systray.sendAction({
            type: 'update-menu',
            menu: {
              icon: '...',
              title: '...',
              tooltip: '...',
            },
            seq_id: action.seq_id,
        })

It would give me an error of error: uncaughtException: Cannot read property 'map' of undefined
But re-adding the items seemed to work:
    systray.sendAction({
      type: 'update-menu',
      menu: {
        icon: base64IconData['blue'],
        title: "BlueLoss",
        tooltip: "BlueLoss",
        items: [
          {
            title: "Open BlueLoss Settings",
            tooltip: "Open BlueLoss Settings",
            checked: false,
            enabled: true
          },
          {
            title: generateEnabledDisabledLabel(checkIfBlueLossEnabled()),
            tooltip: generateEnabledDisabledLabel(checkIfBlueLossEnabled()),
            checked: false,
            enabled: true
          },

          {
            title: "Toggle Icon Color",
            tooltip: "Toggle Icon Color",
            checked: false,
            enabled: true
          },
          {
            title: "Quit BlueLoss",
            tooltip: "Quit BlueLoss",
            checked: false,
            enabled: true
          }
        ]
      },
      seq_id: action.seq_id
    })

Feel free to reopen this or create a new one if you have other issues.

Possibly a bit of a more elegant way to handle this (in this case I'm changing the title dynamically, but the same thing should be possible for the icon):
I store the menu configuration in an object called actualMenu and use this object to initiate SysTray:
`let actualMenu = {
icon: 'data:image/png;base64,...',
title: 'Test',
tooltip: 'Tips',
items: [{
title: 'aa',
tooltip: 'bb',
checked: true,
enabled: true
}, {
title: 'aa2',
tooltip: 'bb',
checked: false,
enabled: true
}]
}
const systray = new SysTray({
menu: actualMenu,
debug: false,
copyDir: true
})`
Then, I wrote a little function that changes the desired element inside actualMenu and makes SysTray load the new version of the menu:
`const updateMenu = (changeObj) => {
actualMenu = { ...actualMenu, ...changeObj }
systray.sendAction({
type: 'update-menu',
menu: actualMenu
})
}
updateMenu({title: 'TEST'})`
I think this makes dynamically manipulating the menu much simpler.


Bug: Folded comments disappear after moving to a different tab

Extension version: v0.56.0
VSCode Version: 1.74.3
OS: Darwin arm64 22.2.0

Steps to Reproduce:

Fold a comment
Move to a different tab/extension and then comes back

https://user-images.githubusercontent.com/5693018/213308125-3b3db034-cbf0-4543-ac89-e49bbfa15c99.mp4

BTW, When I'm moving from one branch to another and the extension chooses the PR that is related to the second branch the comments of the first one are left there.
The comments sections have made the reviews much easier since it was released! It's a really great feature.
If these bugs are fixed it will be so great 🙏🏼


implicit state handling in prep

Figure out if this es even possible since State cannot be parallel and Either must be parallel (Monad + Accumulating).
The semantics when traversing should be: Traverse over f: A => EitherNec[Err, State[S, B]] for every element and then .map(_.sequence) once all "generators" have been constructed.

A two pass algorithm will be very annoying since this requires an almost exact copy of the Prepared AST.

Consider also an approach using Free; Embedding the special case of "traverse this first then fmap sequence the results".


Apiml/OIDC authentication source

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[ ] If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

[ ] If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.

Description (including links to related git issues)
Please describe your pull request.
:heart:Thank you!

This PR was created from a fork.
It is now replaced by #2793 which was created from a repo clone.


UI freezing on linux-arm

I have Avalonia project and try to run chart with oxyplot-avalonia on it,it works well on windows but when I publish it to run on linux-arm (I used ARM Cortex-A9 embedded device), the page which I use chart on it become freeze(without any exception on the output).
as I know it freezes when it try to render the chart, because if I don't pass DataPoint to it , the page works as usual.

Does e.g. the example browser work on the same device? I can't test on ARM, so I probably can't help, but can you run it under a debugger and work out where it is freezing? (e.g. is it stuck in a tight loop, does it seem to be deadlocking, etc.)

Thanks for your reply.
I try to attach project to visual studio debugger but I can't find any crash on the code.
Also I change the project avalonia version to 0.9.4 and after that I do some modification to fix some build error on it, (fore example PlotBase.cs line 342 and 343 , I replace tracker with tracker.Control also replace using Portable.Xaml.Markup; with  using Avalonia.Markup.Xaml ) do you think these changes cause of the problem?

Are you able to pause the debugger while it is frozen and upload the callstacks?

I try to get the callstacks but when I pause the debugger after set the PlotView Model, the callstack is empty.
I try to run the SimpleDemo project on linux device, and I found out if I run it with avalonia 0.8.0 it works well , but when I upgrade the avalonia version to 0.9.4 or 0.9.11 , it doesn't display the chart and UI become frozen.

That might suggest something is silently crashing within Avalonia then. Would you be able to upload the two versions, one which works and one which doesn't? I presume the difference is just the csproj, in which case just uploading those as a gist would be great.
I'm afraid without an ARM device, I'm unlikely to get anywhere, but if you or someone else can debug it, it may be possible to step through the rendering routines to find where it goes wrong. That said, we should probably check if the same happens on x64 linux.

in the attachment you can find the demo version which is not working(use avalonia 0.9.4).
also I did some small modification on OxyPlot.Avalonia project and adapt it with avalonia 0.9.4.
please take a look on it too.
the sample in the git (https://github.com/AvaloniaUI/oxyplot-avalonia/tree/master/Source/Examples/Avalonia/SimpleDemo) use avalonia 0.8.0 and it works well on the ARM linux.
Source.zip

I test it in x64 linux virtual machine and it works. so it's crash only on ARM device

Could you try the 0.1 port in https://github.com/oxyplot/oxyplot-avalonia/pull/23 ? (e.g. just check the example browser works)

Did you merge the changes on the master  ? I can't find the changes there and also there is no any other branches .

No, but I've tested the jp2masa's branch, and it looks fine. I'm just wondering if maybe this is an Avalonia issue that may have been fixed but didn't appear in the 0.9 branch.

I try to run it but now I got this error,
root@colibri-imx6:/home/Wittmann/Installed/Oxyplot# ./ExampleBrowser Unhandled exception. System.InvalidOperationException: Default font family name can't be null or empty.    at Avalonia.Media.FontManager..ctor(IFontManagerImpl platformImpl)    at Avalonia.Media.FontManager.get_Current()    at Avalonia.Rendering.RendererBase..ctor(Boolean useManualFpsCounting)    at Avalonia.Rendering.DeferredRenderer..ctor(IRenderRoot root, IRenderLoop renderLoop, ISceneBuilder sceneBuilder, IDispatcher dispatcher, IDeferredRendererLock rendererLock)    at Avalonia.X11.X11Window.CreateRenderer(IRenderRoot root)    at Avalonia.Controls.TopLevel..ctor(ITopLevelImpl impl, IAvaloniaDependencyResolver dependencyResolver)    at Avalonia.Controls.WindowBase..ctor(IWindowBaseImpl impl, IAvaloniaDependencyResolver dependencyResolver)    at Avalonia.Controls.WindowBase..ctor(IWindowBaseImpl impl)    at Avalonia.Controls.Window..ctor(IWindowImpl impl)    at Avalonia.Controls.Window..ctor()    at ExampleBrowser.MainWindow..ctor() in D:\Samples\Oxyplot\oxyAvalonia git\oxyplot-avalonia\Source\Examples\Avalonia\ExampleBrowser\MainWindow.xaml.cs:line 9    at ExampleBrowser.App.OnFrameworkInitializationCompleted() in D:\Samples\Oxyplot\oxyAvalonia git\oxyplot-avalonia\Source\Examples\Avalonia\ExampleBrowser\App.xaml.cs:line 18    at Avalonia.Controls.AppBuilderBase1.Setup()
at Avalonia.Controls.AppBuilderBase1.SetupWithLifetime(IApplicationLifetime lifetime)    at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T builder, String[] args, ShutdownMode shutdownMode)    at ExampleBrowser.Program.Main(String[] args) in D:\Samples\Oxyplot\oxyAvalonia git\oxyplot-avalonia\Source\Examples\Avalonia\ExampleBrowser\Program.cs:line 10
I try to set a DefaultFont on PlotModel  but the result is same.

Let's still have a discussion in the main project) https://github.com/oxyplot/oxyplot-avalonia/issues/21

Default font family name can't be null or empty. means Skia's FontManger is dysfunctional. Probably missing FontConfig.

@Gillibald Thanks for your comment, I try to set the default font on MainWindow constructor, but the Avalonia.Media.FontManager .Current.DefaultFontFamilyName; doesn't change, it use Segoe UI as a default font and I don't have this font on my ARM linux machine,
Could you please guide me how can I set the DefaultFont on avalonia ?

Finally I fixed it.
Oxyplot.core use Segoe UI font as default font in the source code, so when I try to run it on the Arm linux machine which it hasn't Segoe UI by default , the application crashed.
I changed the default point when initialized the PlotModel and now it works well.
Thanks for your support

The issue is still there. Somehow FontConfig isn't working for you so you don't get any font matches. The only way to get this working is to specify a font that is present on the system.

@Gillibald is there any issue on the OxyPlot/OxyPlot-Avalonia side of things in your assessment, or a way we can detect the issue and avoid hanging?

You get this warning when the font manager isn't working properly:

Default font family name can't be null or empty. means Skia's FontManger is dysfunctional. Probably missing FontConfig.

In general you either embed a default font or you let Avalonia look up the default. That happens when you don't specify a FontFamily.

Ah, yeah, seems obvious now. I think our Skia renderer does something similar. I'll have a look into making it less fragile over the weekend.

@Gillibald as I found out there is 2 different issue , I solved the issue for avalonia 0.9.4 verion by setting the oxyplot default font at initialize time.
but I still  get the Default font family name can't be null or empty. error on avalonia 0.10.0-preview1. I guess the new features of avalonia (Avalonia.Media.FontManager..ctor(IFontManagerImpl platformImpl)) is not working on the Arm linux machine.

Avalonia 0.9.4 has the same issue it just doesn't throw an exception. You are still not able to use font matching because FontConfig isn't working properly.


Home: Text overlapping on mobile site

Omar and I are both seeing overlapping text on the Home page of the mobile site (Android/Chrome and iOS/Safari).
"Current Meeting" or "Next Meeting" header overlaps the red text below the search bar "Search the Metro Board Archive from 1952-2015 (Board Boxes 1994-Present)"

@shrayshray we've implemented a fix that's available for you to take a look at on the staging site. Let us know how it looks to you!

@fatima3558 looks great on staging, thank you!


Detaching and attaching SPI and GPIO in driver

Is your feature request related to a problem? Please describe.
Some peripheral devices require switching pins between SPI and GPIO control during operation. One example is the TLC5916  SPI LED driver. During operation it is necessary to change between the special and normal working mode by sending the subsequently mentioned signal sequence:

This can easily achieved by detaching the CLK pins from the SPI controller, enable GPIO, generate the sequence using GPIO control, disable GPIO, then attaching the pin to the SPI controller again for normal SPI operation.
Such approach can easily be done in the application by declaring a seperate SPI device with a seperate configuration. However, in the driver, where everything have to be inherited from the devicetree and initialized post kernel, this method is poorly documented and/or unavailable.
Describe the solution you'd like
Let driver modules to initialize and de-initialize its submodules during operation.
Describe alternatives you've considered
One workaround is to use bitbanging SPI instead of normal SPI. This approach is less desirable, especially on less powerful SoCs.
Additional context
Add any other context or graphics (drag-and-drop an image) about the feature request here.

A driver can switch between pin functionality using pinctrl at runtime. See e.g. https://github.com/zephyrproject-rtos/zephyr/blob/86fcc5de9745011dfdd8102a8d6c301652705e12/drivers/i2c/i2c_mcux_lpi2c.c#L243

A driver can switch between pin functionality using pinctrl at runtime. See e.g.
https://github.com/zephyrproject-rtos/zephyr/blob/86fcc5de9745011dfdd8102a8d6c301652705e12/drivers/i2c/i2c_mcux_lpi2c.c#L243

@nguyenmthien Does this solve your issue?

A driver can switch between pin functionality using pinctrl at runtime. See e.g.
https://github.com/zephyrproject-rtos/zephyr/blob/86fcc5de9745011dfdd8102a8d6c301652705e12/drivers/i2c/i2c_mcux_lpi2c.c#L243

Hi @henrikbrixandersen, thank you for your reply.
Yes it is correct that your example did show a usecase where pinctrl is used to change pin functionalities upon requests from the driver on runtime. This i2c driver utilities its own pinctrl and to my knowledge, is abstracted away when other peripherals or application use its API. Furthermore, pinctrl is not intended to switch between peripheral functions (CAN/SPI/I2C) and GPIO. For the shake of portability of the driver for the aforementioned LED chip, it should use both the abstracted Zephyr-generic GPIO- and SPI - driver.

Furthermore, pinctrl is not intended to switch between peripheral functions (CAN/SPI/I2C) and GPIO.

You are misreading that part of the documentation. Pinctrl is perfectly fine to use for switching pins between peripheral functions. The GPIO controller drivers, however, switch pins (back) to GPIO function when configuring a pin.
(cc: @gmarull)

Furthermore, pinctrl is not intended to switch between peripheral functions (CAN/SPI/I2C) and GPIO.

You are misreading that part of the documentation. Pinctrl is perfectly fine to use for switching pins between peripheral functions. The GPIO controller drivers, however, switch pins (back) to GPIO function when configuring a pin.
(cc: @gmarull)

Can you point to an example of such function? I am failing to see how it is implemented.

@henrikbrixandersen is this a duplicate of #40385?

Closed due to duplicate of #40385


feat(win): Deploy Windows Sidecar for Windows worker nodes

Makes OSM patch to deploy the Windows version of Envoy sidecar
when the worker node selector is Windows.
Signed-off-by: Sotiris Nanopoulos<EMAIL_ADDRESS>

Codecov Report

Merging #3861 (e0956ec) into main (a3b7451) will increase coverage by 0.16%.
The diff coverage is 74.00%.

@@            Coverage Diff             @@
##             main    #3861      +/-   ##
==========================================
+ Coverage   67.78%   67.95%   +0.16%
==========================================
  Files         200      200
  Lines       11105    11202      +97
==========================================
+ Hits         7528     7612      +84
- Misses       3527     3541      +14
+ Partials       50       49       -1

Flag
Coverage Δ

unittests
67.95% <74.00%> (+0.16%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/configurator/methods.go
70.19% <0.00%> (-3.55%)
:arrow_down:

pkg/configurator/mock_client_generated.go
0.00% <0.00%> (ø)

pkg/constants/constants.go
0.00% <ø> (ø)

pkg/injector/envoy_container.go
100.00% <100.00%> (ø)

pkg/injector/patch.go
87.69% <100.00%> (+0.59%)
:arrow_up:

pkg/envoy/rds/response.go
78.18% <0.00%> (-2.96%)
:arrow_down:

pkg/envoy/sds/response.go
72.09% <0.00%> (-2.71%)
:arrow_down:

pkg/catalog/traffictarget.go
90.00% <0.00%> (-0.73%)
:arrow_down:

pkg/errcode/errcode.go
100.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b7451...e0956ec. Read the comment docs.

@shashankram @ksubrmnn PTAL and let me if I can help with anything