COMPLETE UPDATE: change to typescriptreact

Modernizes this Vim plugin to be compatible with recent versions of Vim/Neovim. Tested by myself and others; verified to work on the latest (nightly) version of Neovim. Also updates the documentation to be compatible with the updates here.
Note: backwards compatibility will likely be lost. That said, since this involves TypeScript / TSX / front end programming, I think everyone should be somewhat used to no backward compatibility :p
The latest versions come bundled with TypeScript syntax highlighting / indentation, but unfortunately no indentation file for typescriptreact. The indentation file in this project works wonderfully!
After merging this PR, I suggest working with both Vim/Neovim to get your indentation file merged as the official typescriptreact indentation file. You've done great work here that should be canonized in the annals of Vim.

I don't know how you fixed it, but since updating my Neovim this morning I've been dealing with a problem where all imports in .tsx files look like this:

the behavior is consistent through latest versions of base16_* colourschemes, the default neovim colourschemes and all other colourschemes I've tried. The highlighting isn't related to coc.nvim or any other problem. It's just highlighting.
Removing this plugin led me to understand that this plugin was most likely being the culprit. then when I updated the plugin to your version the entire tsx file started working like tsx again and the issues were gone:

installed plugins:

How my linting plugin makes errors/warnings look look

So thanks for that fix I guess ;), I'll stick with using your branch for a while!

Great thanks @pappasam for the updates! much appreciated.
All seems to work smoothly on my end. Merging.
@HendrikPetertje  thanks for being our guinea pig and testing!


Update

Pulling into devices

This PR's author is now listed as @ghost.

This PR's author is now listed as @ghost.


Bug: Switching to JSON view creates a weird padding at the bottom of the page.

While working on another issue, I noticed that a weird padding pops up on the bottom of the page whenever the JSON View is opened.
Steps to replicate

Load the json page with Column View
Switch to JSON View

Before

After

OS: Windows 11
Browser: Chrome

Hey @ericallam mind if I take on this task?

@WaunBroderick go for it!

Awesome thanks @ericallam , pull request submitted.


My slide

this is the sixth stage. no w i am creating a pull request.

I create a pull request and delete the branch.


htpasswd not part of the default packages

File: registry/deploying.md
There are other Docker alternatives like
https://hub.docker.com/r/xmartlabs/htpasswd/dockerfile

This looks like a duplicate of https://github.com/docker/docker.github.io/issues/11908
Fixed in https://github.com/docker/docker.github.io/commit/d39b0d8e6e047ffcf5d0e6eecf45b3495437ceb8


Automated cherry pick of #8677: fix: missing column error when order by extra fields

Cherry pick of #8677 on release/3.5.
#8677: fix: missing column error when order by extra fields

Codecov Report

Merging #8678 into release/3.5 will increase coverage by 0.45%.
The diff coverage is 5.60%.

@@              Coverage Diff               @@
##           release/3.5   #8678      +/-   ##
==============================================
+ Coverage         6.03%   6.49%   +0.45%
==============================================
  Files              795     635     -160
  Lines           124282   99759   -24523
==============================================
- Hits              7503    6477    -1026
+ Misses          116114   92709   -23405
+ Partials           665     573      -92

Flag
Coverage Δ

aFlag
6.49% <5.60%> (+0.45%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/cloudregionresource.go
0.00% <0.00%> (ø)

pkg/compute/models/dbinstanceresource.go
0.00% <0.00%> (ø)

pkg/compute/models/diskresource.go
0.00% <0.00%> (ø)

pkg/compute/models/elasticcache_instances.go
0.70% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/elasticcacheresource.go
0.00% <0.00%> (ø)

pkg/compute/models/groupresource.go
0.00% <0.00%> (ø)

pkg/compute/models/guestresource.go
0.00% <0.00%> (ø)

pkg/compute/models/hostresource.go
0.00% <0.00%> (ø)

pkg/compute/models/loadbalanceraclresource.go
0.00% <0.00%> (ø)

...compute/models/loadbalancerbackendgroupresource.go
0.00% <0.00%> (ø)

... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ffdb26...720fde7. Read the comment docs.


thumbnails not creating

[Enter feedback here]
This is a great tutorial, however I'm not able to get thumbnails to store in the storage container. I've created a container but files are not saving.  In AppInsights, I see a message: "Executed "Thumbnail" which would be my FunctionApp.
Inside my function app I have a setting THUMBNAIL_CONTAINER_NAME = thumbnils, however it doesn't save there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cad5909e-e1c6-aa8e-82f1-f2851c1caced
Version Independent ID: 42292330-aa69-9df0-5bd7-e07c9daed995
Content: Tutorial: Use Azure Event Grid to automate resizing uploaded images - Azure Event Grid
Content Source: articles/event-grid/resize-images-on-storage-blob-upload-event.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

Thanks for the feedback @joebiker! We are currently investigating and will update you shortly.

Hello @joebiker, I am sorry for the delay in my response.  I also faced similar issue, the resized image was not getting generated in the "thumbnails" container. Below is the exception I got when running my function app.
No encoder support for: https://<your_blob_storage_account>.blob.core.windows.net/images/<image_name>
Can you please confirm if you are getting the same exception ( the exception will get generated as a log).
This exception will occur if:

If the image extension is other than "gif", "jpg", "jpeg" or "png".
If the image extension is in capital letters (eg: "PNG", "GIF") as the logic implemented in the code does not check for this. I have made a PR to rectify this edge case.

After rectifying the above issue, I was successfully able to execute the tutorial.

I have a similar problem but the function app is not running the following error is displayed n the portal! How and where do I set this?

I have a similar problem but the function app is not running the following error is displayed n the portal! How and where do I set this?

Added the AzureWebJobsSecretStorageType attribute to the app config via the portal and the function now starts fine but no thumbnails are not being!

 And are the image extension in caps?

Hello @joebiker & @RobertF65, Just an update the PR mentioned above was approved now. So now even if the image extension is in capital letters (eg: "PNG", "GIF" etc.) The code will run fine and resize the image. I was successfully able to execute the tutorial as shown below.

Hello @joebiker, I am now proceeding to close this issue. Please tag me in your reply if there are any more concerns, I will be glad to continue with our discussion. Thank you!

 And are the image extension in caps?

I@ChaitanyaNaykodi-MSFT I don't seem to be getting any error. I think the event is not being triggered. Nothing is complaining but the file is not being processed. The file is .jpg and .png extension lower case. The file names are long but the upload part works just fine.

Hello @RobertF65, in the case if the event is not getting triggered. According to this step in the tutorial the connection string "AzureWebJobsStorage" present in the app config should be of the blob storage account where the images are getting uploaded.

Hello @RobertF65, in the case if the event is not getting triggered. According to this step in the tutorial the connection string "AzureWebJobsStorage" present in the app config should be of the blob storage account where the images are getting uploaded.

Thanks @ChaitanyaNaykodi-MSFT It was the connection string. I added it through the portal and it works fine. Got a few issues with the security part of the solution turning off public access prevented the web-app from being able to access the files even when the app code had been updated to the SAS token version. Also had issues with creating alerts. The alert won't save. Giving a location property error, but I guess these are separate issues. Thanks for your help.

Hello @RobertF65 , good to know that it worked out. If you are facing any additional issues in the tutorial, I will definitely encourage you to raise a new doc-issue/feedback. This will help us in improving the  overall experience of the tutorials. Thank you!


为 radio-group 组件添加 field-names 属性

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info
What are the similar cases of this feature
类似于 select 组件的 field-names 属性
What problem does this feature solve?
能够自定义 options 属性的 value 和 label 映射字段


feat: new feature choice for Style Resources

Thank you very much @carlos-avila
Actually, after discussion with the team, it's better to not include such module at the beginning but instead having an easier way to add a module from nuxt directly (ie: npx nuxt add style-resources)
When bootstraping a Nuxt app, few people actually now these module and can confuse them 😬
We really do appreciate your help 💚

That sounds very interesting. I'd like to help with something like that. Let me know where I should start.


Launch via Dstack

Hey @peterschmidt85, I recently saw https://dstack.ai/examples/tei/#run-the-configuration - want to add a short dstack example here and link it in the readme?

@michaelfeil Absolutely! Let me take a look tomorrow and get back to you with the update!


Separate &&& into columns

In tables with additional levels, would be good if &&& separators can be turn into columns and can be filtered

Thats what tidy/splitStrata/splitGroup/splitAdditional do. Thats why I was Saying always to display in raw, tidy, table and plot tabs.
@albertpratsu

https://github.com/oxford-pharmacoepi/omopViewer/issues/8
we can consider not do display raw and only use the tidy format which probably it is easier to interpret and analyse but different for each tab

Thanks for the input, @catalamarti
However, there are some challenges as @albertpratsu mentioned filtering by new columns. Users currently filter columns first, then generate plots based on the filtered table. Allowing filtering after splitgroup() disrupts plot functions, with columns like cohort_name_reference and cohort_name_comparator.
To address this, we have three options:

Implement a function to revert these columns back to the normal summarized result data (with group_level, group_name, etc.) so the current plot functions work. This function might already exist, but I'm unaware of it.
Only display the tidy table, prevent the user from filtering the table after tidy (splitgroup and other split functions). From my understanding, this is not what @albertpratsu is suggesting.
Change the plot functionality in CohortCharacteristic.

Which option do you think is best?

So we can have some methods for filtering
visOmopResults::filterGroup(cohort_name == "acetaminophen")
visOmopResults::filterStrata(sex == "Female") or sth like this @nmercadeb @edward-burn
But also happy to discuss 1 or 3 @MimiYuchenGuo

https://darwin-eu.github.io/visOmopResults/reference/uniteAdditional.html
https://darwin-eu.github.io/visOmopResults/reference/uniteGroup.html


Discuss how to use context.Context within the codebase

We need to discuss whether we will be using context for any kind of lifecycle management in the code or whether we want to use more explicit stop signals (e.g. doneCh) for our lifecycles / listeners, etc.

We have reached consensus on this. Closing.


request dependency has Uninitialized Memory Exposure vulnerability (until v2.81.0)

request should be updated to version 2.81.0 or higher.
Vulnerability details:

Snyk

solved by https://github.com/coinbase/coinbase-node/pull/122


Return and track drift integration metadata

For passing info in to drift integration it would be nice to have an option that passes drift rate ranges in physical units Hz/sec but still be able to pass discrete bins
some info that needs to come out of the drift integration process

integration length
desmearing (would be used to adjust noise threshold appropriately)
range searched

This is primarily to support #5 and I'm working on it as part of a bit of a refactor towards progress on #7.
I've got the following struct as a work-in-progress towards what to return from drift integrations rather than just the ndarray that is currently returned
struct frequency_drift_plane {
        struct drift_rates {
                int index_in_plane;
                double drift_rate_Hz_per_sec=0.0F;
                int desmeared_bins=1; // number of bins per spectra used to desmear
        };
        int64_t integration_steps;
        std::vector<drift_rates> drift_rate_info;
        bland::ndarray integrated_drifts;
};

The idea would be the index_in_plane makes sure if the vector<drift_rates> gets shuffled we can always know what index along drift axis this is relevant to, the drift_rate_Hz_per_sec tracks the physical units and the desmeared_bins is the number of bins per spectra we integrate when desmearing is on (this is the number of bins a signal would expect to cross. This would provide required info to fix #5 in the hit search

Working on this in the desmear-noise-comp branch, the final data structure attached is
struct frequency_drift_plane {
    struct drift_rate {
            int index_in_plane;
            double drift_rate_slope = 0.0F;
            double drift_rate_Hz_per_sec = 0.0F;
            int desmeared_bins=1; // number of bins per spectra used to desmear
    };

    frequency_drift_plane(bland::ndarray drift_plane, integrated_flags drift_rfi) : _integrated_drifts(drift_plane), _dedrifted_rfi(drift_rfi) {}
    frequency_drift_plane(bland::ndarray drift_plane, integrated_flags drift_rfi, int64_t integration_steps, std::vector<drift_rate> dri) :
        _integrated_drifts(drift_plane), _dedrifted_rfi(drift_rfi), _integration_steps(integration_steps), _drift_rate_info(dri) {
    }

    // slow-time steps passed through for a complete integration, the total number
    // of bins contributing to this integration is demsear_bins * integration_steps
    int64_t _integration_steps;

    std::vector<drift_rate> _drift_rate_info; // info for each drift rate searched (consider changing to map with key being integer number of unit drifts)

    // The actual frequency drift plane
    bland::ndarray _integrated_drifts;

    integrated_flags _dedrifted_rfi;

};

coarse_channels hold on to this rather than several other fields so this structure keeps them all together


Negative value in constexpr cause LLVM ERROR: Symbol name with unsupported characters

Simple repro
import triton
import triton.language as tl

@triton.jit
def test_kernel(
    test_val: tl.constexpr,
):
    return

test_kernel[
    1,
](test=-1)

This will give LLVM ERROR: Symbol name with unsupported characters.
I assume this might be due to how we create the function name in mangle_fn. Since we append the value of a constexpr to the function name, a function name that cannot be compile in LLVM might be created (e.g. test_kernel_-1).

Yes, you are right. The name mangling is not good. Thanks for reporting, I will address it.


The user name and github name might be switched

check the inquirer prompts and make sure all the answers are where they should be. Verify with test.

they were and were fixed in v0.0.11


Work around clippy lint bug

[x] I agree to follow the project's code of conduct.
[x] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Unblocks #389.

bors r+


KAFKA-7890: Invalidate ClusterConnectionState cache for a broker if the hostname of the broker changes.

See https://issues.apache.org/jira/browse/KAFKA-7890 for additional details.

Added a new unit test where the hostname changes.
Also tested in production

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for taking a look @cmccabe.
Added log.info for broker hostname changing.


[CI] Fix variable initializations used in test case declarations

These global variables ray_image, ray_version, and kuberay_operator_image are heavily used in test case declarations. But currently, their value will be changed in the if __name__ == '__main__' block which runs after test case declarations.
Therefore, it causes undesired evaluations in some cases, such as https://github.com/ray-project/kuberay/blob/59503c647d8708e7e70ae8bb0bde83d7c4142465/tests/compatibility-test.py#L153-L154
where it always evaluates the ray_version to the initial default value, instead of the value we inject via the env later.
See more details: https://github.com/ray-project/kuberay/pull/1770#discussion_r1436669602
This PR fixes their values at the beginning of the test script and does not change them after initialization.
Related issue number
https://github.com/ray-project/kuberay/issues/1773
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

I will review this PR after #1770 gets merged.

Would you mind rebasing with the master branch? Thanks!


Switching a Pipeline's ISBService results in Pipeline Containers stuck in Init stage

Describe the bug
I'm not sure whether or not this is a bug or expected behavior. Basically, the Pipeline Pods can't start after changing the interStepBufferServiceName.
This occurs both when I first attempt to pause the pipeline, and also when I don't.
To Reproduce
Steps to reproduce the behavior:

Create 2 basic Jetstream ISBServices (in my case I was using jetstream 2.10.3) with different names on the same namespace
Create simple pipeline setting the interstepBufferServiceName to one of them
Optional step: Pause pipeline by setting lifecycle.desiredPhase=Paused and wait for status.Phase=Paused. Note just Daemon Pod is running.
Update pipeline's interStepBufferServiceName to the other one
Any Pods that are running restart and have error in "init" container (in the case of paused pipeline, it's just the Daemon Pod):

{"level":"info","ts":"2024-07-31T04:33:27.481863765Z","logger":"numaflow.isbsvc-validate","caller":"commands/isbsvc_validate.go:81","msg":"Buffers, buckets and side inputs store might have not been created yet, will retry if the limit is not reached","pipeline":"simple-pipeline","error":"failed to query information of stream \"example-namespace-simple-pipeline-cat-0\", nats: stream not found"}
{"level":"info","ts":"2024-07-31T04:33:32.545809559Z","logger":"numaflow.isbsvc-validate","caller":"commands/isbsvc_validate.go:81","msg":"Buffers, buckets and side inputs store might have not been created yet, will retry if the limit is not reached","pipeline":"simple-pipeline","error":"failed to query information of stream \"example-namespace-simple-pipeline-cat-0\", nats: stream not found"}
{"level":"info","ts":"2024-07-31T04:33:43.258374939Z","logger":"numaflow.isbsvc-validate","caller":"commands/isbsvc_validate.go:81","msg":"Buffers, buckets and side inputs store might have not been created yet, will retry if the limit is not reached","pipeline":"simple-pipeline","error":"failed to query information of stream \"example-namespace-simple-pipeline-cat-0\", nats: stream not found"}

Expected behavior
Pipeline is able to resume running on the new ISBService
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Kubernetes:
Client Version: v1.29.1
Server Version: v1.28.8+k3s1
Numaflow: quay.io/numaio/numaflow-rc:v0.01 (released within the last week)

Additional context
Add any other context about the problem here.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

For quick help and support, join our slack channel.

This operation should not be allowed.

I see. I will close this then. Thanks.


Calibration Check Problem

Hi,
I noticed that I can simply use the APS frame to calibrate my DAVIS camera, however when I use camera_calibration package to calibrate my device. The whole process works fine until I try to using camerachecker.py to check my intrinsic parameters, the topic from image_raw and camera_info cannot synchronize.
Has anyone else come across this problem before, is there any solution for this specific problem? Or, is there another way else to help me verify the intrinsic and maybe extrinsic parameters?
Thanks

Fixed with https://github.com/uzh-rpg/rpg_dvs_ros/pull/101


Add ITM logo

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[X] Filename in the lowercase format
[X] Image format: png
[X] Image size: 256 by 256 px

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:
Twitter: @TrustWalletApp
Facebook: @TrustWalletApp

Hi @vikmeup! I'm Leah, a co-founder of intimate. We've Tweeted about the Trust Wallet and intimate integration (official handle is @intimatetoken, personal handle is @leah_cb). Our community LOVES Trust Wallet and we'd like to share more news with them about how we're working together. Would love to chat with you about how we could work together more. Let me know if you're open to a chat.


Fix check_polkadot CI check

As far as I remember without the commit reference it would be looking for master instead of the commit itself.


Factor out model creation (inc homerunner calls) to background thread/process/???

This will improve /register performance in general.

Done alongside the move to quart ; callls to the homerunner are now async (with aiohttp) so we don't gum much up at all.


why not one nats cli?

Currently nats has nats, nsc, nk, nats-top . As an end user I would like to see one tool for all interaction. Some of these can be installed via brew. Some only via go install. I am curious why these clis are not merged into one.

It’s the intention to merge more - it’s a big job and this cli already represents the merging of maybe 8 other tools :)


Fix for relative deployed paths

When I created my S3 bucket, and then viewed it, it was at https://s3.amazonaws.com/wildrydes-firstname-lastname/ride.html, this resulted in a lot of the links not working because all the CSS files were assumed to be off the root, so it was looking in https://s3.amazonaws.com/css/* and couldn't find them.
I've updated all the paths to be relative (./css/...) as well as adding links to the shortcut icon to its relative path (i.e. ./favicon.ico) since that was also giving me errors

This has been updated in a separate commit. The site doesn't completely work if it's not accessed via the website endpoint because there are some re-directions that happen that need to be absolutely referenced, but at least the CSS will load now.


value check space issue

even though there is a space or not next to the ? and the cookie is definitely a parameter I want the result to be checked for null not the parameter which I already know...
example:
localStorage.getItem "cookie" ?

expect:
localStorage.getItem("cookie") != null

got:
localStorage.getItem("cookie" != null)

localStorage.getItem "cookie" ?

that's not valid syntax

the ? is supposed to be like ruby's check this value if it exists. so I'd expect to be able to check:
doSomething "to this" ?

which checks the result of doSomething with the parameter "to this" exists.
and I'd expect to be able to do:
doSomething "to this"?

which checks if the value of "to this" exist then is a parameter of doSomething.

No, only dots close parenless calls.

then is there a way that we could make ? be able to be like:
doSomething "to this" .?

output
doSomething("to this")!= null

"Dot"s are for accessing properties :) you're not accessing anything here. This'd be inconsistent with the rest of our postfixes (like !)

oh wait I can do this:
doSomething "to this"
  ..?

does that sound like a bad idea? lol

I think the cure is worse than the disease (parentheses)

(doSomething "to this")? makes a lot of sense to me when reading the code.
Embrace teh parentheses...

@igl see that's different id use that and you're right that makes sense...


TypeError: the first argument must be callable

Traceback (most recent call last):
File "main.py", line 86, in
train_emotic(result_path, model_path, train_log_path, val_log_path, ind2cat, ind2vad, context_norm, body_norm, args)
File "D:\2022-next\2022-text\emotic-master\train.py", line 174, in train_emotic
model_context, model_body = prep_models(context_model=args.context_model, body_model=args.body_model, model_dir=model_path)
File "D:\2022-next\2022-text\emotic-master\prepare_models.py", line 28, in prep_models
model = torch.load(model_file, map_location=lambda storage, loc: storage, pickle_module=pickle)
File "D:\anaconda3\envs\pytorch114\lib\site-packages\torch\serialization.py", line 795, in load
return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
File "D:\anaconda3\envs\pytorch114\lib\site-packages\torch\serialization.py", line 820, in _legacy_load
class UnpicklerWrapper(pickle_module.Unpickler):  # type: ignore[name-defined]
TypeError: the first argument must be callable

I didn't encounter this problem when I first trained, and after a while when I trained for the second time, I encountered this problem when I ran python main.py, and I checked a lot of information and couldn't find where the problem was. Waiting for everyone's exchange, thank you very much

I used gpt to help solve this problem and it seems to be useful.
code


HDFS-16964. Improve processing of excess redundancy after failover.

Description of PR
After failover, the block with excess redundancy cannot be processed until all replicas are not stale, because the stale ones may have been deleted. That is to say, we need to wait for the FBRs of all datanodes on which the block resides before deleting the redundant replicas. This is unnecessary, we can bypass stale replicas when dealing with excess replicas, and delete non-stale excess replicas in a more timely manner.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 32s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 37s

trunk passed

+1 :green_heart:
shadedclient
25m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
26m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
225m  5s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

342m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5510

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ac539b00d994 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c2e747ba6d5b88ec06edb0d1d64a0e994cf35229

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/1/testReport/

Max. process+thread count
2324 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao Thanks for your review, I've updated the PR based on your suggestion.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 29s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
22m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

the patch passed

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 18s

the patch passed

+1 :green_heart:
shadedclient
22m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
202m 15s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

309m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5510

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ba2e56196c58 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / dc82eba387fabb12da8a3bda4968b621135f54b9

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/2/testReport/

Max. process+thread count
3197 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 21s

trunk passed

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 40s

trunk passed

+1 :green_heart:
shadedclient
26m 21s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 30s

the patch passed

+1 :green_heart:
shadedclient
26m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
229m 47s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

349m 11s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5510

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 121fb08e2be5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6edb0b9269f4db27fdb46f6750781e8e06c7765e

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/3/testReport/

Max. process+thread count
2404 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5510/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao Thanks. I've checked it out.

Committed to trunk. @zhangshuyan0 thanks for your contribution!


UI issues

[ ] motion list: "by xy ·sequential_number" → a space should be after the middot
[x] #1325
[ ] motion detail view: The tooltip "Mark as favorite" should only be visible if a user hovers over the icon
[ ] motion detail view: The box for the summary of every changes (amendment, change recommendation) should be outlined
[x] #1326
[x] #1327
[x] #1329
[x] #1328

@emanuelschuetze I couldn't identify three of them, so I split off the rest into their own issues and solved them all in pull #1330 .
Please check if the other problems are still present, if they are solved this issue may be closed.


Use the tf4micro esp fork not the tensorflow libs?

https://github.com/espressif/esp-tflite-micro
https://github.com/espressif/esp-nn
Even though it seems the esp-tflite-micro is behind the newly partitioned https://github.com/tensorflow/tflite-micro repo.
I am not sure but unless you link esp-nn you will not use the optimised vector instructions of the S3
https://github.com/espressif/esp-nn?tab=readme-ov-file#performance

The microWakeWord implementation in ESPHome uses the Espressif library which automatically imports the esp-nn code, so we are already taking advantage of the optimized versions that use the vector instructions. Even the regular ESP32 runs the model faster with their assembly versions compared to disabling the esp-nn optimizations.

I was thinking you would have to adapt the code they provide as it seems for specific input tensors, which changes in each model.
I am not sure but think the optimised code might be the model that runs in the s3-box


How to change the color of the menu?

I have two white bars, but I can't find a way to remove them.

Have you tried using a custom card builder? Also check the src for the default card to see what styling params you might need to set:
https://github.com/gskinnerTeam/flutter-context-menu/blob/master/lib/src/widgets/context_menu_card.dart

@esDotDev I used a ContextMenuRegion and a GenericContextMenu to create my menu.
I'm not sure where is this "custom card builder"

Check the docs on styling
https://github.com/gskinnerTeam/flutter-context-menu/blob/master/lib/src/widgets/context_menu_card.dart

Putting the widget after the theme definition fixed the problem:
The example in the README is not correct
return ContextMenuOverlay(
  child: MaterialApp(...)
);

This will be more correct
return MaterialApp(
   ...,
  child: ContextMenuOverlay(child: ...)
);

Another issue appeared, it used by default when overring the secondary color instead of onPrimary for the text color.

@esDotDev https://github.com/gskinnerTeam/flutter-context-menu/pull/21 this should fix the issue

Hi @esDotDev, thank you for merging the pull request! I'd like to know about the release cycle for this project. When will these changes be available for Flutter users?


Typo in "Static Regular Expressions" section

I think that "instance method calls" should read as "static method calls" in "Static regular expression methods are recommended as an alternative to repeatedly instantiating a regular expression object with the same regular expression. Unlike regular expression patterns used by regular expression objects, either the operation codes or the compiled Microsoft intermediate language (MSIL) from patterns used in instance method calls is cached internally by the regular expression engine."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 14698b87-a995-290f-bdd7-9c2d6867704c
Version Independent ID: f199cd3f-8dce-ad4e-9712-3545e35557e7
Content: Best Practices for Regular Expressions in .NET
Content Source: docs/standard/base-types/best-practices.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Thank you for pointing this out, @stribizhev. The sentence should indeed read "static method calls" instead of "instance method calls". We've opened #14185 to correct the documentation.


"The system cannot find the path specified.\r\n"

im not sure what is wrong, here is my controller, i've created many folder as the path, but nothing works
$base = 'uploads';
Backup::setPath($base);
Backup::export();
dd(Backup::getProcessOutput());

Hi there,
Ensure that the folder has read/write permissions. I would use something like ..app/storage/backup/.
The following should work as expected:
Backup::setPath(public_path());

Backup::export();

Hi there,
Can you try giving the package a full path, for example: /tmp


[T3A4][T14-A2] Tan Min Rong Samson

Ready for Review

@samsontmr

Try checking how existing code works before starting any activity. This allows you to solve the question quickly. Find what the original code does when the error mentioned in the activity occurs.
It seems your code would recursively call the function and will be unable to exit. Try replicating the problem after you have written a solution to verify its correctness.
Exception handling in this case requires you to inform the user about the error. Try figuring out which class would catch the error and send the error message to the user.


Write a set of code solutions: "openai php examples" (php-openai)

Please write code solution for this topics:
openai php examples (technology: php-openai)
Fast way
Just write the code solution(s) in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to use OpenAI API with PHP?
How to use OpenAI API and PHP and cURL?
How to use OpenAI ChatGPT API with PHP?


Feature/sr-dynamic-optimisation

What does this PR do?
Merge Feature/sr-dynamic-optimisation into develop
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report
Attention: Patch coverage is 72.89157% with 45 lines in your changes missing coverage. Please review.

Project coverage is 70.34%. Comparing base (7fcb18e) to head (bf88ff6).

Files with missing lines
Patch %
Lines

...d/sessionreplay/SystemRequirementsConfiguration.kt
50.00%
17 Missing :warning:

.../internal/prerequisite/MemoryRequirementChecker.kt
62.50%
4 Missing and 5 partials :warning:

...lay/internal/prerequisite/CPURequirementChecker.kt
73.33%
2 Missing and 2 partials :warning:

...internal/recorder/DefaultOnDrawListenerProducer.kt
40.00%
3 Missing :warning:

.../android/core/internal/persistence/file/FileExt.kt
0.00%
2 Missing :warning:

...lin/com/datadog/android/rum/internal/RumFeature.kt
0.00%
1 Missing and 1 partial :warning:

...ndroid/sessionreplay/SessionReplayConfiguration.kt
83.33%
2 Missing :warning:

...nternal/recorder/listener/WindowsOnDrawListener.kt
60.00%
2 Missing :warning:

...um/internal/metric/SessionEndedMetricDispatcher.kt
0.00%
0 Missing and 1 partial :warning:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
75.00%
0 Missing and 1 partial :warning:

... and 2 more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2302      +/-   ##
===========================================
- Coverage    70.36%   70.34%   -0.03%
===========================================
  Files          730      734       +4
  Lines        27247    27390     +143
  Branches      4579     4601      +22
===========================================
+ Hits         19172    19265      +93
- Misses        6806     6842      +36
- Partials      1269     1283      +14

Files with missing lines
Coverage Δ

.../android/rum/internal/metric/SessionEndedMetric.kt
94.79% <100.00%> (+2.32%)
:arrow_up:

.../sessionreplay/internal/DefaultRecorderProvider.kt
93.55% <100.00%> (+0.11%)
:arrow_up:

...oid/sessionreplay/internal/SessionReplayFeature.kt
98.73% <100.00%> (+0.01%)
:arrow_up:

...ssionreplay/internal/recorder/RecordingTimeBank.kt
100.00% <100.00%> (ø)

...nreplay/internal/recorder/SessionReplayRecorder.kt
96.92% <100.00%> (+0.02%)
:arrow_up:

...um/internal/metric/SessionEndedMetricDispatcher.kt
65.62% <0.00%> (-2.12%)
:arrow_down:

.../android/rum/internal/monitor/DatadogRumMonitor.kt
85.48% <75.00%> (-0.14%)
:arrow_down:

...com/datadog/android/sessionreplay/SessionReplay.kt
62.50% <95.24%> (+10.33%)
:arrow_up:

...droid/sessionreplay/internal/recorder/Debouncer.kt
96.67% <94.12%> (-3.33%)
:arrow_down:

.../android/core/internal/persistence/file/FileExt.kt
85.00% <0.00%> (-2.93%)
:arrow_down:

... and 7 more

... and 25 files with indirect coverage changes


bgImage not working with AVPlayerViewController

What version of Streaming-Meda-Cordova-Plugin are you using?
2.0.0
What version of Cordova are you using?
7.1.0
What devices are affected?
iOS
Please describe the issue in detail, with relevant code samples
bgImage and bgColor do not work with the new AVPlayerViewController.
var options = {
    bgColor: "#FFFFFF",
    bgImage: "https://123.example.com/png/11299-200.png",
    bgImageScale: "fit", // other valid values: "stretch"
    initFullscreen: false, // true(default)/false iOS only
    successCallback: function() {
      console.log("Player closed without error.");
    },
    errorCallback: function(errMsg) {
      console.log("Error! " + errMsg);
    }
  };
  window.plugins.streamingMedia.playAudio(audioUrl, options);

What did you expect to happen?
For the background image to be displayed.

Resolved with 2.1


Terminal desperately needs a horizontal scrollbar (similar to Command Prompt)

Summary of the new feature/enhancement
Windows Terminal needs to have a configurable horizontal scrollbar (similar to Command Prompt) so that lines longer than the window width are actually readable by scrolling to the right, rather than being a big indecipherable word-wrapped mess as is typically seen on UNIX-like systems.
Proposed technical implementation details (optional)
Make it so.

indecipherable word-wrapped mess

I mean, that seems a little strong. One of the biggest requests we had for Windows 10 was to add support for wrapping to the traditional/legacy console!

That's because I feel strongly about it :)  I absolutely hate line-wrapped console output... always have.

Maybe make it a config,
"text-wrap": false

when true does as it does now, false gives horizontal scrollbar

The traditional Unix terminal emulation (using ANSI escape sequences) is pretty much incompatible with this idea. See e.g. https://bugzilla.gnome.org/show_bug.cgi?id=769440.

Yea I don't think we're going to change this, for the exact reason mentioned by @egmontkob. What we're trying to build is a terminal, not a console. While the horizontal scrollbar made sense in the console, where the viewport could be smaller than the buffer in both the x and y directions, a terminal's viewport is fundamentally the same size as the buffer.
Even if we added this setting to the Terminal, it's still connected to conpty, which is acting like a terminal buffer itself, and it won't emit sequences that act like the old console did.

Then I guess I won't be adopting Windows Terminal after all, because that's a dealbreaker for me.

I need horizontal scrolling and wrapping disabled too

Cmd and ConsoleZ have this feature

@AlwaysHC Could you elaborate more on why you need this feature? I don't think I really understand the use case. Maybe there's some way to make your workflow work in the Windows Terminal without a horizontal scrollbar?

@zadjii-msft Because wrapped lines are obnoxiously more difficult to visually parse.

I'm in agreement that we need this feature. I use a lot of interactive workflows that display asciified tables in the terminal (which are often several screen-lengths long) and having them be wrapped is a dealbreaker since it turns them into illegible gibberish. Likewise with several other forms of console output where the formatting across lines is important. Please implement horizontal scrolling as an option because currently I think this terminal will be useless to a lot of users with similar requirements.

Would love to see a configurable horizontal size with horizontal scroll-bar.
Something similar to cmd window would be great.
Until this feature is implemented, i'll be sticking with the default Ubuntu shell.

Both issues are closed now, however we don't have the possibility to disable the word wrap yet :(

I am copying the question which I asked here: #6730
Why is Windows terminal unable to load a wide window (of fixed width) behind the scenes with only a part of the window visible to the user and a horizontal scrollbar to move that window from side to side? The shell itself may not even be aware of me staring at it throw a smaller size window. In other words all this thing could be implemented on the UI part only by letting the shell think that I am on a wider window than it actually is.

I was happy with trying the new Windows Terminal, but when I needed to turn off word-wrapping (because I wanted to use Oracle SQL*Plus and make some queries, etc.), to my surprise, I realized that it was not actually possible. That seems really silly to me.
I guess I'll have to go back to using the classic command prompt for the most part.

It's really silly for a Terminal to not have a configurable wrap setting. Database queries are completely illegible.

If we make any changes here, they are going to be in line with other terminal emulators that have established precedent: the typical options are wrap or truncate. Would truncate be more to your liking?

The behavior ought to be exactly the same as Command Prompt has been for ages: word-wrap, but only beyond a buffer width that the user can configure to be much wider than the actual window width.  For example, allow me to set the buffer width to 9999 characters, so that word wrapping does not occur until the 10000th character on each line (which should effectively never wrap).

From: Dustin L. Howett<EMAIL_ADDRESS>Sent: Sunday, September 20, 2020 2:00 PM
To: microsoft/terminal<EMAIL_ADDRESS>Cc: Keith F. Kelly<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] Terminal desperately needs a horizontal scrollbar (similar to Command Prompt) (#1860)
If we make any changes here, they are going to be in line with other terminal emulators that have established precedent: the typical options are wrap or truncate. Would truncate be more to your liking?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fterminal%2Fissues%2F1860%23issuecomment-695835807&data=02|01||f9d4ce8bb068439401dc08d85da837e1|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637362324358631954&sdata=xGdfubKK0wnO4%2F1QRGJuz9hJdwNCOgDozQQI7JAPb14%3D&reserved=0, or unsubscribehttps://eur05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF2EYJEXCLWYIO6AJWV5QI3SGZUPDANCNFSM4H6W2CBQ&data=02|01||f9d4ce8bb068439401dc08d85da837e1|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637362324358641949&sdata=pE2xsu1RU3mHwvTXv60jFkvJ1GjotQtZS299uDQ%2Bm6Q%3D&reserved=0.

I think the confusion here stems from the fact that some people were expecting a kind of "infinite" width, that would expand as more content was written out. I don't think that is feasible for a terminal. However, a wide (but fixed size) buffer within a smaller viewport is a different matter. As had been mentioned, we already support that in the conhost console. And it's worth mentioning that some of the DEC terminals supported a similar concept, so it's not without precedent.

I totally agree with @c0d3h4x0r. As long as it can at the very least do exactly what CMD already does regarding large buffer sizes, I'll be happy. Currently I can't use this new terminal for any form of interesting ASCII-fied output, such as a database table returned by a SQL query.

if you are using psql, try this when running it:
PAGER="less -S" psql -U ...
it will let you scroll horizontally

I also like to disable word wrapping for wide output which may be truncated at e.g. 500 char width but until then I do not want to see parts of it on the next line.  One extreme example is e..g
C>wmic process
which needs ca. a width of 2000 to become readable. Tabular data is not uncommon. I can zoom out on my 4K monitor to some extent but this is still an big issue to become a console I would like to use always over the "old" one.

Ya this feature is a must or simply can't use this terminal for developing with docker, the output especially for stat commands is super wide and with line wrap its unreadable

so it this feature request dropped? or are we expecting to have it at some point?

The official plan is no, we're not planning on supporting this. I'd be shocked to find another terminal emulator that's not conhost that supports this. If an application is emitting output that's too wide for the buffer, then that sounds like the app has a bad UX, not the Terminal, since all terminal emulators will have that bad UX (IMO).
<bottle-feeding thought>
We could add an experimental.minimumBufferWidth setting. When we do resizes, we make sure the conpty buffer is always at least that big, regardless of the terminal viewport width. I'm sure there would be weird edge cases. We'd need to make sure that the handling of cursor positioning in the Terminal buffer isn't too reliant on the terminal viewport, but instead the underlying buffer.
I really have no idea how bad the UX would be. But it would be a place to start.
I'd absolutely stick this as an experimental. setting, because I want to make sure it's clear that it's an unsupported scenario.
</bottle-feeding thought>

"We're not going to do what users are begging for, because we are more interested in finding excuses to be lazy and weasel our way out of it."  Typical Microsoft, not listening to your users.
Sent via Outlook for iOShttps://aka.ms/o0ukef

From: Mike Griese<EMAIL_ADDRESS>Sent: Friday, December 4, 2020 6:30:02 AM
To: microsoft/terminal<EMAIL_ADDRESS>Cc: Keith F. Kelly<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] Terminal desperately needs a horizontal scrollbar (similar to Command Prompt) (#1860)
The official plan is no, we're not planning on supporting this. I'd be shocked to find another terminal emulator that's not conhost that supports this. If an application is emitting output that's too wide for the buffer, then that sounds like the app has a bad UX, not the Terminal, since all terminal emulators will have that bad UX (IMO).

We could add an experimental.minimumBufferWidth setting. When we do resizes, we make sure the conpty buffer is always at least that big, regardless of the terminal viewport width. I'm sure there would be weird edge cases. We'd need to make sure that the handling of cursor positioning in the Terminal buffer isn't too reliant on the terminal viewport, but instead the underlying buffer.
I really have no idea how bad the UX would be. But it would be a place to start.
I'd absolutely stick this as an experimental. setting, because I want to make sure it's clear that it's an unsupported scenario.
</bottle-feeding thought>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fterminal%2Fissues%2F1860%23issuecomment-738814484&data=04|01||d54d78fe27bd4e50333e08d89861169c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637426890035945156|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=MLzMlAWSrnuiR2hYIlGp2jPOMEuv%2BtPIR0tLwk%2BEO%2FM%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF2EYJDHO5KHPFVNC52HMK3STDW6VANCNFSM4H6W2CBQ&data=04|01||d54d78fe27bd4e50333e08d89861169c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637426890035955147|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=DQE0gpzkxne2Jr9Pt3%2FMG2pgXwRrzxM2TVkoh%2B4ygKs%3D&reserved=0.

Can't we just lie to the terminal, say, real width is 500, but only show 80 to user, and a horizontal scroll?
This issue is a deal breaker for me, because I use horizontal scroll a lot on cmd and powershell to observe log. And logs are not always design for 80x24, sometimes it's really really long. With current line-wrapping, 1 line of log == multiple line of logs -> consum all the terminal space, leave only 1 line empty.

The regular Windows Command Prompt solves this in a simple and elegant way.

I will have to continue using that instead.

Please count me as another user who thinks Windows Terminal is great, but force word wrapping makes this product unusable - the output becomes unreadable in many situations where it exceeds the current horizontal size.

same for me: I am running Oracle's sqlplus and many output line width >200 characters. need Windows terminal provide horizontal screen bar feature. I am so excited to use new Windows terminal until I see this issue and I am very regret to stop using this product. I will switch back in future once this feature is available.

Fiquei feliz em experimentar o novo Terminal do Windows, mas quando precisei desligar a quebra automática de linha (porque queria usar o Oracle SQL * Plus e fazer algumas consultas, etc.), para minha surpresa, percebi que não era realmente possível. Isso parece muito bobo para mim.
Acho que terei que voltar a usar o prompt de comando clássico na maior parte do tempo.

I was happy with trying the new Windows Terminal, but when I needed to turn off word-wrapping (because I wanted to use Oracle SQL*Plus and make some queries, etc.), to my surprise, I realized that it was not actually possible. That seems really silly to me.
I guess I'll have to go back to using the classic command prompt for the most part.

I totally agree. It is a very important resource for executing SQLs and analyzing logs.
Windows Terminal is an excellent tool and you need to allow this configuration as soon as possible. Buffer size width already exists on the PowerShell console and CMD. If Windows Terminal wants to do a complete integration, it must provide this feature.

I use SnowSQL at work and was so excited about Windows Terminal Preview that I spent hours customizing it to my liking only to find out I'll have to stick to the good old command prompt because of this one missing feature. What a waste--because everything else was so on point with this app.

you all never listen to your most important customers.

I literally re-opened this, because I am listening to folks who want this. Simple fact of the matter is that this is an engineering project, and we've only got so many development resources, so we can't just snap our fingers and do everything we want instantly. We've got to prioritize all community asks, and the best way we can do that is with 👍's on issues. As of right now, this issue isn't even on the first 3 pages of https://github.com/microsoft/terminal/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc. So pardon me if it takes a little while for us to get back to this one. Of course, this is an open-source project, so we'd be happy to accept a community contribution if anyone's got a clever idea how to implement this. I laid out a crazy idea on how we could up here: https://github.com/microsoft/terminal/issues/1860#issuecomment-738814484.

I understand that it may be a difficult feat of engineering, to reverse the windows console view-port functionality back into the already built terminal, but please can you consider that for many the ability to configure the console was a stand-out feature we took for granted.
We are not afraid of horizontal scrolling!
I myself automatically I've set every console to have a horizontal buffer of 1000 horizontally and 8000 height. I don't want any kind of wrapping, ever.
Please consider adding horizontal scrolling back to your new windows consoles/terminal.
Regards

I want to use Windows Terminal as my general purpose console on Windows.
I monitor logs on a daily basis via tail -F over SSH. I periodically glance at my console to see which messages have been logged recently. It is faster and easier to scan through them when each log message is a single line (no wrapping).
When I see a message of interest, I want to quickly view the entire message. I want to avoid something like tail -F /var/log/syslog | cut -c -200 because then I'd need to run additional commands to find and view the entire message. Also, I do not want to interrupt my active command, which is continuing to display new messages.
I imagine that an option to manually override the terminal buffer dimensions, independent of the viewport size, would satisfy my use case while still being compatible with the nature of a terminal. The viewport would allow me to scroll horizontally and quickly check lines of interest, without affecting the active command.

I want to use Windows Terminal as my general purpose console on Windows.
I monitor logs on a daily basis via tail -F over SSH. I periodically glance at my console to see which messages have been logged recently. It is faster and easier to scan through them when each log message is a single line (no wrapping).
When I see a message of interest, I want to quickly view the entire message. I want to avoid something like tail -F /var/log/syslog | cut -c -200 because then I'd need to run additional commands to find and view the entire message. Also, I do not want to interrupt my active command, which is continuing to display new messages.
I imagine that an option to manually override the terminal buffer dimensions, independent of the viewport size, would satisfy my use case while still being compatible with the nature of a terminal. The viewport would allow me to scroll horizontally and quickly check lines of interest, without affecting the active command.

I used to use the Terminator terminal emulator, which has a horizontal scroll bar.  It's an option every terminal should have.

So I guess I do not understand the purpose of this Windows Terminal.  The only reason I'm even using it is for the tabbed interface and ability to combine my cmd prompt and Powershell windows into a single pane, but without the option to change my buffer/scrolling options, this terminal is useless to me.
I'm dealing with Powershell output on screen right now that is absolutely terrible to read due to this issue.  So can someone explain to me wth the purpose of this thing is to be?  Someone earlier said "this is not to be a console, but a terminal".  What does that even mean?

It's a ridiculous response.  It means it's supposed to emulate a monitor
and a keyboard, and monitors have no scrollbars.  But it's a useless answer
because you don't have to wrap the output just because you have a
terminal.  Just like you can emulate a very large screen with a vertical
scrollbar, nothing impedes you from having a horizontal scrollbar and
voiding the need for line wrap.  To make it simpler, just like you can,
say, enable scrolling (scroll lock or whatever) and scroll up and down, you
can use it to scroll left and right as well.

Daniel

On Mon, Feb 28, 2022 at 1:22 PM Matthew McDonald @.***>
wrote:

So I guess I do not understand the purpose of this Windows Terminal. The
only reason I'm even using it is for the tabbed interface and ability to
combine my cmd prompt and Powershell windows into a single pane, but
without the option to change my buffer/scrolling options, this terminal is
useless to me.
I'm dealing with Powershell output on screen right now that is absolutely
terrible to read due to this issue. So can someone explain to me wth the
purpose of this thing is to be? Someone earlier said "this is not to be a
console, but a terminal". What does that even mean?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/1860#issuecomment-1054675458,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQCWXKJ5MYZBRJWCXTEJM3U5PRRNANCNFSM4H6W2CBQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

That's silly.  I mean actual terminals/monitors don't have "windows" either.  If that's what they are going for, then Terminal should be 100% fullscreen at all times with no ability to resize them.

Irony at its finest :-D

![BD8DD555-439B-482E-91D2-4CB490C849E2]
Irony at its finest :-D

what's the irony ?

For me a simple use case is following of log files with
powershell Get-Content c:/wamp/logs/php_error.log -Wait

In this case wrapping is obstructing

god please consider implementing this feature I'm lost in large log files, thanks for all hard works

i work with spring boot, and spring product long lines of log, for example in simple groovy web application i face with this, of course this is very bare bone appliances in serious work it get worse

another example would be cloudflared tunnel -h

with several zoom out key press finally some clarity!

Throwing my my 2 cents, since it's been a couple of weeks. It's clear that the powers-that-be are strongly opposed to adding scrolling, but man it would be so helpful for some use cases.
The most recent case that's caused me to crave this feature is working with the Azure CLI (surely a proper use for Terminal). A ton of the output is in the form of tables and other types of formatting that span a very wide width. Tables wrap horribly, leaving half-lines all over the place that are impossible to reconcile with the columns. I work around it by maximizing my window, but even so, the largest tables still wrap. (And using the old-school command prompt is obviously a poor experience in a dozen other ways, so terminal is key!)
I think some are really stuck on this idea of emulating the behavior of other terminals. That is an important goal, as I utilize WSL and also SSH into Linux boxes, and I want content to display as designed. However, just because one provides full support for those standards, it doesn't mean that one can't also provide features that build on top of that! Compatibility is easily maintained with an off-by-default configurable nature. Given virtually every other detail of the terminal window so configurable, having a default disabled option doesn't really seem that problematic, and if this and a handful of closed issues are any evidence, there's a reasonably strong demand.

You can extend the Windows Terminal functionality with a small portable tool that adds horizontal scrolling to the terminal. It almost completely supports win32 console api as well as wsl.
https://user-images.githubusercontent.com/11535558/194391026-0921d52e-80f6-4e40-9265-fdb1bf82ec30.mp4
Note, powershell and cmd.exe do not know that lines can be unwrapped, so unwrap mode is best applied to already displayed lines using text selection by mouse + Wrap menu button.

OK this is constructive at least, but I'm not sure I'd use the Terminal with an add-on like this one over, e.g. the old cmd window. It just seems a bit cumbersome. But if this can be done in an add-on, maybe something like it could be implemented in the Terminal is self?

Windows Terminal already has everything you need for seamless integration. You could  just add a new profile like this
{
    "commandline": "vtm -r term _your_favorite_shell_with_args_",
    "...: ..."
},

For example using powershell.exe as a shell
{
    "commandline": "vtm -r term powershell.exe",
    "...: ..."
},

That looks like a nice way, but the main reason for me to use Windows Terminal is that I can copy colored text as RTF so I can add text and no screenshots to presentations. So far I was not able to copy RTFwith vtm. Is this not supported? That would be a pity.

That's right, adding RTF support shouldn't be too hard.

It's a real pity this feature isn't available - I was psyched to be using Terminal until I realized I won't be unable to view wide, formatted output legibly. This is a dealbreaker for me. I understand there are 3rd-party programs that may be able to truncate wide outputs, but such a 3rd-party approach is drastically too inconvenient across all my use-cases.

The 3rd party tool I mentioned doesn't truncate wide output, but rather allows horizontal scrolling of wide text content. In addition, PowerShell itself truncates wide content if no buffer width is specified. In that case you can use OSS function to specify the text buffer width.
E.g.
dir C:\Windows\ | oss 1000

In case it helps, you can launch the terminal through VS Code and toggle word wrap using built-in ALT+Z shortcut. I use that shortcut right before running a command that I think needs horizontal scrolling to peruse the output. Also available from the menu bar under View>>Word Wrap.

That doesn't sound like the same app at all.  This is about the standalone app literally called "Windows Terminal".

Keith F. Kelly
https://www.soundcloud.com/syrinx_keith_f_kelly
https://www.pastcurfew.band/

From: rajatsharmasubedi @.>
Sent: Tuesday, November 1, 2022 11:07:36 AM
To: microsoft/terminal @.>
Cc: Keith F. Kelly @.>; Mention @.>
Subject: Re: [microsoft/terminal] Terminal desperately needs a horizontal scrollbar (similar to Command Prompt) (#1860)
In case it helps, you can launch the terminal through VS Code and toggle word wrap using built-in ALT+Z shortcut. I use that shortcut right before running a command that I think needs horizontal scrolling to peruse the output. Also available from the menu bar under View>>Word Wrap.
—
Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fterminal%2Fissues%2F1860%23issuecomment-1298914756&data=05|01||93c0cbca68f5400bb98508dabc33f4e4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638029228576899744|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qP6CgN8VNbDhm1HdaTo9FAY6VltteiNdejV%2BQ02PPRs%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF2EYJHBTD6RZXV3I322ENLWGFL6RANCNFSM4H6W2CBQ&data=05|01||93c0cbca68f5400bb98508dabc33f4e4|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638029228576899744|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qikBCRs%2BJ4XCXpl83nFwc9X%2BZIRfdi7Q%2F%2FcuG%2BRCX9k%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

I have tried vtm which now also supports to copy text as RTF, HTML and ASCII. It works inside Windows Terminal and also from any other shell. Since this one is cross platform (Linux, Windows, MacOS) and supports wrap/non wrapping modes this is all I need. It have found a bug when RTF was copied to Word which was fixed within one day.

Unlike other shells it renders very fast without screen glitches. The only things I miss are

Ctrl+C / Ctrl-V (that should be configurable)
Default selection handling where the copied text hovers over the mouse cursor this has tricked me several times to suspect display errors or even wrong data

If you're using WSL you can use tmux to do this. It's pretty great.
tmux resize-window -x 1000
then Ctrl+b+[ will put you into "scroll mode" or whatever where you can use arrow keys and pg up/down and home/end to move around.

just throwing my hat in the ring, this is an insane oversight that makes this application no longer viable for me
I have an application that writes to specific buffer coordinates all the time and if I resize the window at all it explodes. Just can't work with this

I'm daily working with linuxes over ssh for 13 years now. I never think of that windows cmd has this ability, to scroll horizontally. Now, the more I think about it, the more I need it.
Which other terminal software do you use which supports horizontal scrollbars other than Windows Console Host?

So, it's either deal with broken multi-line string mess or decrease font size to such a small value that the log lines fit, but you can no longer see the output...

This is at least partially needed because - as has mentioned in this context - Windows Terminal often wraps output well before the width of the window it is in. That is nothing to do with an application wrapping it at the wrong length.

Windows Terminal often wraps output well before the width of the window it is in

This isn't a report we've seen before! Would you mind filing a separate bug for it? It sounds like a bug, not a design decision that would be helped by having a horizontal scroll bar (after all, if we keep wrapping far too early there wouldn't be content off the right side for you to scroll to see!)

4 years later, the scrollbar is still not there  :(

4 years later, the scrollbar is still not there :( I'm inspecting a dataframe with 16 columns, and it looks atrocious. I have to resort to other apps for now. This comment is another plea to prioritize this feature over other features like retro effect.

Maybe you can use Putty to log in to a wsl instance

Typical Microsoft.

Keith F. Kelly
https://www.keithfkelly.info/

From: mathematician001 @.>
Sent: Friday, April 21, 2023 7:44:38 PM
To: microsoft/terminal @.>
Cc: Keith F. Kelly @.>; Mention @.>
Subject: Re: [microsoft/terminal] Terminal desperately needs a horizontal scrollbar (similar to Command Prompt) (#1860)
4 years later, the scrollbar is still not there :(
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/issues/1860#issuecomment-1518447294, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF2EYJHWWVNCLJZKFNIEJG3XCMSXNANCNFSM4H6W2CBQ.
You are receiving this because you were mentioned.Message ID: @.***>

Horizontal scrollbar is the only thing that doesn't allow me to switch to Windows terminal :( We really need it for sqlplus/sqlcl/pgsql/etc:

I imagine many consumers of the popular spectre.console console library rely on no-wrap/a horizontal scrollbar for correct layout, eg table widget:

Same here, I work with database outputs, quite often 1000+ char wide. Line wrapping is forcing me to stick with cmd.exe. :(

Any update here? Of all the top issues (based on thumbs-up count) this is almost certainly the most workflow-breaking, and most likely to turn away users.

Any update here? Of all the top issues (based on thumbs-up count) this is almost certainly the most workflow-breaking, and most likely to turn away users.

Haha no
We're 4 years deep in this, it's never getting fixed

The best way to be notified about updates to this issue is to subscribe! You can customize what level of information you receive on updates to this issue (such as an e-mail that is generated for every comment sent to every subscriber) by using this widget in the sidebar.

Wow, after 4 years this issue is still open, that's how Microsoft listens to the community?
It's really annoying with forced word wrapping, nearly unusable. Some people like me use the Terminal also as "live-logger", with word wrapping over 1000 lines I don't know where the line starts or ends. But anyways there are a lot of others which support such simple features.
It would be cool from you guys to listen to the people that are using your products and supporting you in their free time.

Same here, I work with database outputs, quite often 1000+ char wide. Line wrapping is forcing me to stick with cmd.exe. :( I spent 2 days trying out, got sooo close. I would also have some 10 more suggestions/bugs to report, but this one's a deal breaker.

That what gets me about the comments about there being no need or that this would be non-standard. Many of Microsoft's own command-line apps produce very wide or columnar layouts, like sqlcmd, az cli

Alrighty, I'm gonna come through and clear up this thread a bit.
First off: The community is definitely heard on this one. This was a big part of Conhost who's absence from Terminal is clearly felt. For folks where this is a part of their workflow,  simply using tools like less isn't good enough.
There's been a lot of other priorities we've had over the last few years that have prevented us from getting to this. Alas, this just hasn't bubbled up the list of priorities yet (it's currently sitting as the 13th most 👍'd issue that's still open).
For the sake of issue maintenance, I'm gonna aggressively collapse a lot of the "omg i can't believe this doesn't work"-like comments in this thread, so that we can drill in on technical solution details without getting distracted.
I'm gonna copy in half a thought I had here: https://github.com/microsoft/terminal/issues/1860#issuecomment-738814484 into this comment, and iterate over time.
As always, the Terminal is an open-source project, and we'd love help from anyone passionate about this issue.

implementation notes here

We could add an experimental.minimumBufferWidth setting. When we do resizes, we make sure the conpty buffer is always at least that big, regardless of the terminal viewport width. I'm sure there would be weird edge cases. We'd need to make sure that the handling of cursor positioning in the Terminal buffer isn't too reliant on the terminal viewport, but instead the underlying buffer.
I really have no idea how bad the UX would be. But it would be a place to start.
I'd absolutely stick this as an experimental. setting, because I want to make sure it's clear that it's an unsupported scenario.

IIRC I was going to start by sticking a member on Terminal in https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalCore/Terminal.cpp that's just "minimum buffer width", and make sure that when we resize the connection in ControlCore, we never resize the width to less than that. Though, we'd need to make sure that we allow Terminal to have a VISIBLE viewport whose width can be less than the buffer width. From VT's perspective, the viewport will remain the buffer width, it just won't all be visible. Interesting.
Obviously, if the window is resized wider, then we'll just use that width as the buffer width.
I wonder if there's a way that we can track the longest actual line we've seen, without constantly calling MeasureRight. If we did that, then we could have the scrollbar only work as a function of the longest printed row, rather than just the full backing buffer width.

I wonder if there's a way that we can track the longest actual line we've seen, without constantly calling MeasureRight. If we did that, then we could have the scrollbar only work as a function of the longest printed row, rather than just the full backing buffer width.

We use std::map for this
std::map<int, int> sizes;

// buff: Register a new line.
void invite(int& size, int new_size)
{
    ++sizes[new_size];
    size = new_size;
}
// buff: Update existing line.
void recalc(int& size, int new_size)
{
    if (size != new_size)
    {
        undock(size);
        ++sizes[new_size];
        size = new_size;
    }
}
// buff: Drop the line.
void undock(int size)
{
    auto iter = sizes.find(size); assert(iter != sizes.end());
    auto pool = --(*iter).second;
    if (pool == 0) sizes.erase(iter);
}
// buff: Return max line length.
auto max()
{
    return sizes.empty() ? 0
                         : sizes.rbegin()->first;
}

There's been a lot of other priorities we've had over the last few years that have prevented us from getting to this. Alas, this just hasn't bubbled up the list of priorities yet (it's currently sitting as the 13th most 👍'd issue that's still open).

I understand if you flag this as off topic, but do have to ask. Seems that you guys follow the thumbs-up counts, you certainly refer to it as the thing that sets your priorities. Seeing the #1 on that list being emoji support, does not seem to make sense to be religous about that list? There are show stoppers that prevent people from using the tool at all, but the most important thing is to add emoji support? I admit I may not understand how important emojis could be to someone's work.

I wonder if there's a way that we can track the longest actual line we've seen, without constantly calling MeasureRight. If we did that, then we could have the scrollbar only work as a function of the longest printed row, rather than just the full backing buffer width.

@zadjii-msft In order to be compatible with the VT windowing extension, we need to handle this more or less the same way it's done in conhost, i.e. with a fixed buffer width that's independent of the visible viewport width. Once you've set the buffer width, that's the defined the extent of any VT cursor movement. It doesn't change based on how much text has been output.
I've actually considered just implementing the VT side of this without any UI as a first step. Once we have the basic architecture in place, we can worry about things like the scrollbar and settings for the initial buffer size as a later enhancement.

@jm903 👍's aren't a hard & fast rule, but they're certainly a good analog. "emoji support" is also kinda a misnomer - yes, it means emoji, but it's also more broadly "Support a broader array of unicode glyphs, that may or may not be more than one wchar per cell, on both output and on input, including the win32 console input APIs"[^1]. That's relevant not just for emoji, but really any language that's not just using latin characters.
[^1]: you can see how that doesn't roll off the tongue as easily 😝

, i.e. with a fixed buffer width that's independent of the visible viewport width. Once you've set the buffer width, that's the defined the extent of any VT cursor movement. It doesn't change based on how much text has been output.

That's exactly what I was thinking. So, with a viewport width of 80 and a buffer width set to 5000, a \x1b[9999C\x8\x8 would take you to column 4998, not column 72. It'd be annoying, sure, but I don't imagine there's a lot of overlap between users that that do full-screen VT stuff (linux-y) that are also in the camp of needing this (windows-y) simultaneously.
My commentary about

we could have the scrollbar only work as a function of the longest printed row

was more just musing on "could we start with the horizontal scrollbar hidden, and only show it when the app emits l o n g lines? and could we have it's width be relevant to what's been output?" So that there's not just vast empty space the user can scroll into on the right side of the screen.

Fair enough. That was noodling on the UX, not a definite requirement.

So either the scrollbar space is allocated up front, regardless of whether it's initially visible

This seems infinitely easier than reveal on hover. At least the winui scroll bars are pretty subtle when not moused over.

Well, I hate the code. And I hate that the DX and Atlas engines both seem to not support horizontal scrolling (even in conhost).
but like, proof of concept:

The problem seems resolved. But I don't know how to configure it on my desktop. Would you guys kindly tell me how to do it?

@bigvzhang: The issue #15707 which is merged just deals with bugs in the rendering engine. The bug fixes which are needed later to implement the feature are now shipped with the next release. I do not see any scrolling code in the public.

I personally can't await this feature
...

Please add word wrapping.
Like the VS output console can.
There is a toggle button.

Seeing data on a horizontal scroll would be killer
Currently need to subset data columns or shrink terminal to non-legible level just to view data in tabular format.

Until this is implemented,
please use a scroller app.
This one works fine data scroller

Until this is implemented, I'm staying away from this crap.
On Fri, Feb 9, 2024 at 5:02 PM Alex Al-Saffar @.***>
wrote:

Until this is implemented,
please use a scroller app.
This one works fine data scroller
https://github.com/baogorek/datascroller
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/terminal/issues/1860#issuecomment-1936784725,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQCWXKV4KL6YWAX2PGR22TYS3BKDAVCNFSM4H6W2CB2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJTGY3TQNBXGI2Q
.
You are receiving this because you commented.Message ID:
@.***>

Seeing data on a horizontal scroll would be killer Currently need to subset data columns or shrink terminal to non-legible level just to view data in tabular format.

You can try "tput rmam" (remove auto margin). that works for me.  to reset it "tput smam" to set it again.

Yup here is another example of unreadable madness:

Yeah, SQL outputs and the like are extremely useless without the ability to disable word wrap and use a horizontal scroll bar. Please, we need this feature!

Someone would not believe that it is 5 years, since request was made...

I have the latest version of windows command line terminal. When executing a console app from VS that prints long line (just few characters off screen), there is no word wrap being applied nor horizontal scroll available also I can't find any relevant setting. The only way is to select and move mouse cursor to right direction to be able to see off screen text of the long line

As mentioned in https://github.com/microsoft/terminal/issues/6895#issuecomment-1048641000, a workaround for now is to temporarily decrease the font size with ctrl-minus

That's not a good workaround.  In many cases, e.g., that screenshot above, you'd have to lower the font to the point it was unreadable.

PowerShell table-formatted output often exceeds the horizontal width of even my full-width monitors.  My current solution is to snap the window open a couple monitors wide (or more) to see everything.  Wrapping output results in an unparseable mess.  Definitely want a horizontal scroll bar (or even just the ability to scroll horizontall with a mouse h-scroll wheel).

This is a must, as database engineer, sql output in CLIs (snowsql, snow, sqlplus etc) wraps results table.
I may wonder whats the rationale here, but I suspect windows terminal maintainers don't have this SQL execution use case, or otherwise I'm sure they would fix this.
Please:

add wrap on appearance options.
which when true adds horizontal scroll bar.

I found an easy workaround for at least linux-like shells (gitbash, based on cut):
$ <whatever your commands> | cut -c -$COLUMNS

Interestingly enough, resizing "Windows Terminal" updates $COLUMNS.
Here anim gif showing trick in gitbash and wasl2>ubunto shells:

But the ideal is not to cut, and have a horizontal scroll bar available.
Is this the correct thread to push-vote-up for this to happen?

just gonna be honest terminal is pretty cool and a genuine reason to not DESPISE windows 11. but its sort of a shame it can not have word wrap. would love it if it could.

Usually I use [CTRL + down mouse scrolling] until I get the text unwrapped (it works unless you have an excessive number of characters per line, else the text font size becomes so small that you have difficulty reading it; widening the window horizontally helps as well).


messages flooding console

Describe the bug
Viewing covid-19 or other dashboards on https://covid-19.splunkforgood.com/dashboard_hub
floods messages to the console, repeating with each autoupdate.js call this increasing memory usage in the browser.
To Reproduce
Steps to reproduce the behavior:

Go to 'Open dashboard, such as  covid-19'
Open whatever development tool in browser
Check the console output
See messages like the following:

main.d14d1855.chunk.js:1 Current version is 92b13f7
16:21:50.411 11.0380a9aa.chunk.js:2 Failed to calculate layout scale: containerWidth= 0 , width= 1800 ; falling back to scale=1
l.warn @ 11.0380a9aa.chunk.js:2
16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'seriesColors' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'data.fieldShowList' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'data.fieldHideList' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'legend.labels' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:50.909 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'fieldColors' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:51.686 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'seriesColors' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:51.686 static/js/1.2d69059b.chunk.js:2 The option type 'string' for 'fieldColors' has been deprecated.
l.warn @ static/js/1.2d69059b.chunk.js:2
16:21:52.400 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_FONT_COLOR" not available in default theme
16:21:52.400 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_UNHIGHLIGHT_COLOR" not available in default theme
16:21:52.424 static/js/19.28086849.chunk.js:2 drawing a chart with dimensions: Object
16:21:52.424 static/js/19.28086849.chunk.js:2 drawing a chart with properties: Object
16:21:52.425 static/js/19.28086849.chunk.js:2 drawing a chart with data: Object
16:21:52.440 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme
16:21:52.440 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme
16:21:52.440 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme
16:21:52.442 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme
16:21:52.442 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme
16:21:52.442 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme
16:21:52.454 static/js/19.28086849.chunk.js:2 config object to be sent to highcharts: Object
16:21:53.033 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_FONT_COLOR" not available in default theme
16:21:53.033 static/js/19.28086849.chunk.js:2 Theme property "LEGEND_UNHIGHLIGHT_COLOR" not available in default theme
16:21:53.109 static/js/19.28086849.chunk.js:2 drawing a chart with dimensions: Object
16:21:53.109 static/js/19.28086849.chunk.js:2 drawing a chart with properties: Object
16:21:53.110 static/js/19.28086849.chunk.js:2 drawing a chart with data: Object
16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme
16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme
16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme
16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_LABELS_FONT_COLOR" not available in default theme
16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_TITLE_FONT_COLOR" not available in default theme
16:21:53.113 static/js/19.28086849.chunk.js:2 Theme property "AXIS_GRID_LINE_COLOR" not available in default theme
16:21:53.125 static/js/19.28086849.chunk.js:2 config object to be sent to highcharts: Object
Expected behavior
Minimal console logging.
Desktop (please complete the following information):

OS: Windows 10
Browser: Tried in Chrome and Firefox

Noting this. Is this specifically related to our public dashboards though? Just want to make sure there is nothing to fix in this repository.

Ryan,
Just the public dashboards that I am aware of.

https://covid-19.splunkforgood.com/coronavirus__covid_19_

I see it in the dashboards using Chrome Version 80.0.3987.149 (Official Build) (64-bit). Also in Firefox.
I had someone else check as they shared their screen with the same results using Chrome.
but also in:
https://covid-19.splunkforgood.com/covid_19_detailed (755 messages after it loads up)
https://covid-19.splunkforgood.com/timelapse (fastly growing to over 2,000 messages until I closed)
https://covid-19.splunkforgood.com/covid_19_uk (55 messages)
https://covid-19.splunkforgood.com/nyc_dashboard (136 messages)
https://covid-19.splunkforgood.com/us_hotspots_detailed (767 messages)
https://covid-19.splunkforgood.com/covid_19_cuba (88 messages)
https://covid-19.splunkforgood.com/covid_19_datasource_comparison (47 messages)

https://covid-19.splunkforgood.com/dashboard_hub (This is all I see in my console:)

17:17:17.881 autoupdate.js:5 Current version is 92b13f7
17:17:18.152 console.js:9 Failed to calculate layout scale: containerWidth= 0 , width= 1500 ; falling back to scale=1

I also checked on another PC, newer version of Chrome, different ISP with the same results.
I think this is because there is quite a bit of logger.debug entries (from index.js):
function setTheme(themeKey) {
if (!_constants.THEMES[themeKey]) {
logger.debug('Theme "' + themeKey + '" not available - falling back to default');
currentThemeKey = 'default';
} else {
currentThemeKey = themeKey;
}
currentTheme = _constants.THEMES[currentThemeKey];
}
function getThemeProperty(propertyName) {
if (!currentTheme[propertyName]) {
logger.debug('Theme property "' + propertyName + '" not available in ' + currentThemeKey + ' theme');
return undefined;
}
return currentTheme[propertyName];
}
handleDraw: function handleDraw(callback) {
    logger.debug('drawing a chart with dimensions:', {
        width: this.width,
        height: this.height
    });
    logger.debug('drawing a chart with properties:', this.properties);
    logger.debug('drawing a chart with data:', this.dataSet.toJSON());
    this.benchmark('Draw Started');
    this.applyColorPalette();
    // if there is already a draw in progress, cancel it
    this.cancelPendingDraw();

    if (this.shouldUpdateInPlace()) {
        this.redrawInPlace(callback);
        return;
    }

    this.hcConfig = this.getConfig();
    logger.debug('config object to be sent to highcharts:', this.hcConfig);
    if (this.hcChart) {


Support IMAP EXAMINE().

This PR enables support for IMAP EXAMINE() for read-only folder selection.

Need tests

Needs a rebase, @ameir — as well as tests.

I added some basic tests to this.  Let me know how it looks.

Closing; author has not incorporated requests for changes.
If you would like to re-open, please incorporate the feedback and re-submit.
Thanks!


Save prebuilt reports to specific root artifact

Quick attempt at https://github.com/dotnet/source-build/issues/1823. We'll see if it works in the PR build.

Some extra duplicates I didn't expect, but nothing impactful--looks good:

Anonymously, downloading here is 9.7 MB and contains the right files:

https://dev.azure.com/dnceng/public/_build/results?buildId=862616&view=artifacts&type=publishedArtifacts
@tmds @omajid can you confirm that works for you too?

Merging to get it into workflows sooner rather than later (rerunning a PR from GitHub should re-merge the PR branch and incorporate this change)--input still appreciated if this doesn't quite work.

@tmds @omajid can you confirm that works for you too?

Works for me, thanks!


Requirements do not work

Hi, I am trying to follow your readme but the requirements do not seem to work. Have any advice on this?

The requirements.txt seems to have libs conflicting with each other. pip -r install requirements.txt simply won't work.