[DONT MERGE] PR to debug CI failures on windows

This PR is just meant to check on CI failures described on this issue: https://github.com/pytorch/vision/issues/6189

First we try to skip the big models in CPU as well to make sure the problem is not caused by big model [confirmed GREEN for windows test]
Second, we will test the big models with torch nightly 20220621

I was debugging with ssh the failing job and confirm that recent pytorch nightlies are failing even if executed just a single test. However, if I install Juin 18 version single test seems passing:
(C:\Users\circleci\project\env) C:\Users\circleci\project>pytest -vvv test/test_models.py::test_classification_model[cpu-regnet_y_128gf]
pytest -vvv test/test_models.py::test_classification_model[cpu-regnet_y_128gf]
============================= test session starts =============================
platform win32 -- Python 3.10.4, pytest-7.1.2, pluggy-1.0.0 -- C:\Users\circleci\project\env\python.exe
cachedir: .pytest_cache
rootdir: C:\Users\circleci\project, configfile: pytest.ini
plugins: cov-3.0.0, mock-3.7.0
collecting ... collected 1 item

test/test_models.py::test_classification_model[cpu-regnet_y_128gf] PASSED [100%]

============================= 1 passed in 30.42s ==============================

(C:\Users\circleci\project\env) C:\Users\circleci\project>pip list | grep torch
pip list | grep torch
torch              1.13.0.dev20220618+cpu
torchvision        0.14.0a0+1eae59a       c:\users\circleci\project

I was debugging with ssh the failing job and confirm that recent pytorch nightlies are failing even if executed just a single test. However, if I install Juin 18 version single test seems passing:
(C:\Users\circleci\project\env) C:\Users\circleci\project>pytest -vvv test/test_models.py::test_classification_model[cpu-regnet_y_128gf]
pytest -vvv test/test_models.py::test_classification_model[cpu-regnet_y_128gf]
============================= test session starts =============================
platform win32 -- Python 3.10.4, pytest-7.1.2, pluggy-1.0.0 -- C:\Users\circleci\project\env\python.exe
cachedir: .pytest_cache
rootdir: C:\Users\circleci\project, configfile: pytest.ini
plugins: cov-3.0.0, mock-3.7.0
collecting ... collected 1 item

test/test_models.py::test_classification_model[cpu-regnet_y_128gf] PASSED [100%]

============================= 1 passed in 30.42s ==============================

(C:\Users\circleci\project\env) C:\Users\circleci\project>pip list | grep torch
pip list | grep torch
torch              1.13.0.dev20220618+cpu
torchvision        0.14.0a0+1eae59a       c:\users\circleci\project

Testing it with latest commits

cc @datumbox
From this finding, there might be some changes in core that increase memory usage?

@YosuaMichael Yes seems this way. We should raise to Core and see if they are aware something might have raised the memory requirements on Windows. This is going to be quite a difficult debugging.


chore(clr): Control CLR metadata parsing

A new option is provided to control whether
the CLR metadata is parsed. By default, CLR
metadata is parsed. Some users might not find
it useful, and parsing this data is a waste
of CPU cycles. Omitting CLR metadata can improve
PE parsing performance.

new tag is released (v1.5.6) that contains this feature.


signal handlers are not working when using node loader

🐛 Bug Report
I am using metacall shared library to embed nodejs code into my c++ application
inside my nodejs code I am spawning a child process
and I am connecting signal handlers inside c++
when the child process which is invoked from nodejs is finished SIGCHLD handler is not called in C++
Steps to Reproduce
Using the attached child_process_sample.zip
The sample has three cases

run nodejs executable with JS file that spawn "ps" process
run metacall python loader and run py code that spawn "ps" process
run metacall node loader and run JS code that spawn "ps" process

the C++ SIGCHLD handler will be called for cases 1 & 2 and will not be called for case#3
To reproduce:

Prepare build environment
setenv GCC_PATH <path to gcc directory that contains bin & lib directories>
setenv NODE_EXE <path to node executable>
setenv METACALL_BUILD <path to metacall build that contains lib directory>

The used metacall build has node loader and py loader

cd child_process_sample
make
./invoke_app.sh
the three cases will be run sequentially, you can notice that the log message "c++: received signal SIGCHLD" will be printed for cases 1 & 2 and will not be printed for case#3

Context (Environment)
OS: CentOS Linux 7
Metacall: 0.2.22
gcc: 5.4.0
nodejs: 10.19.0

I have tried a workaround to catch SIGCHLD signal in nodejs then call a CPP callback function then inside the cpp callback function I call "raise(SIGCHLD)"
I found that the signal handler will not be called also
kindly find the attached workaround.zip
try the same above steps to reproduce
the workaround source code is located in workaround.cpp

What about this? Does it fits your needs?
https://github.com/metacall/core/commit/8521b054e1d3ecf42064e9a11fccdd31c06899ac

I just realized, it does not propagate to the main thread. But this is basically due to the problem I told you, it runs in a different thread. I am going to do a workaround and share it as soon as possible.


General inconsistent behaviour

Please provide us with the following information:

This issue is for a: (mark with an x)
- [X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Simply testing the app, both deployed and locally, will generate the same bugs: the behaviour of the app is unpredictible. Not only for customized, but also the default one. Sometimes it generates the follow-up questions, sometimes not (of course the X is selected inside developer settings). Sometimes the questions are in text, inside the main message, sometimes they appear as links. Sometimes the numbers of the citations appear correctly attached to the right sentences, sometimes the app lists them at the end of the response.

I am simply going crazy with this repo. I am very grateful to Microsoft and their developers for their ongoing support, but I feel this app was not ready. Am I the only one facing this?
Any log messages given by the failure

not relevant

Expected/desired behavior

I'd love to have a consistent behaviour.

OS and Version?

macOS

azd version?

not relevan

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Regarding follow-up questions, I'm currently working on that and have logged it here:
https://github.com/Azure-Samples/azure-search-openai-demo/issues/783
For the citation issue, can you describe in more detail/show some examples?

Thanks a lot, Pamela. Please see attached.

Okay, so I definitely see the follow-up questions issue that I'm working on in https://github.com/Azure-Samples/azure-search-openai-demo/issues/783
That's why the "1. 2. 3" is getting separated due to the questions not being returned in the instructed manner.
But you also said there's a citation issue, is that demonstrated in the second question, with the floating "1" at the end? I've seen that a few times, and it seems to happen when ChatGPT thinks that there's a general citation for the whole document, and doesn't think it needs to attach to any sentence in particular. I think we either have to try some prompt changes or do post-processing to make that not look so floaty. Is that what you're talking about?


libreoffice - create shortcut for code style and number style and bullet style

Create style
Navigate to Tools >Customize >Keyboard
Scroll down in the Category until you see styles
Choose your style
Choose short cut and click modify

Set Ctrl+Shift+C => apply code style


Allow enforcing SSE settings for the cache bucket

Description of change
Use --sse and --sse-kms-key-id to enforce a specific SSE configuration on the shared cache bucket.
https://github.com/awslabs/mountpoint-s3/pull/1071 and https://github.com/awslabs/mountpoint-s3/pull/1132 should be merged before this.
Relevant issues:
Does this change impact existing behavior?
No.
Does this change need a changelog entry in any of the crates?
Yes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

This will be addressed later.


observability: implement an option to expose various metrics

Metrics coming to mind:

bytes sent
bytes received
time to first byte
successful calls
failed calls

Implement as a decorator option on the client.

Implemented in https://github.com/radekg/yugabyte-db-go-client/pull/62.


Do not use ActiveSupport core extensions

Core extensions often don't play well with many other gems... considering that they only seem to be included for one to_json call, it would probably be better to avoid using them altogether and call ActiveSupport::JSON.encode directly.

Released in Version 1.4


How to migrate from github.com/dgraph-io/badger to github.com/outcaste-io/badger?

Is it enough to change the dependency in go.mod?

Yes, that should be sufficient. If it doesn't work, let me know.

Sorry it doesn't work, i suggest, you have to make a release, otherwise it will try to install v3.2103.2 , but this states himself as dgraph-io...
go<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: github.com/dgraph-io/badger/v3
                but was required as: github.com/outcaste-io/badger/v3

installing latest, also points to v3.2103.2

@danielmai -- Can you look into this and fix this up please?

ristretto looks good
dgo points declares its path as: github.com/dgraph-io/dgo/v210

BadgerDB v3.2202.0 release is cut now. So the following commands can be used to do a fresh install or update:
go get github.com/outcaste-io/badger/v3
go get<EMAIL_ADDRESS>

dgo v210.03.1 release is cut now. These commands should work now for updating to the release:
go get github.com/outcaste-io/dgo/v210
go get<EMAIL_ADDRESS>

I will try to install outcast-io/badger and run my tests

Glad all your tests passed!
There's now a section in the docs/README on how to migrate to outcaste-io/badger. Mainly covers updating go.mod and the Go imports.


Navigate menu items are not the main menu items?

It appears it's not showing my active menu for the navigate menu items?    I would assume that it would show those?

It's the same for me. It shows the secondary menu here.

@rodferris @aashishpahwa
We have a separate navigation menu for AMP version, You can setup it from Dashboard > Appearance > Menus


SNS subscribe(topicArn, sqsArn) is duplicating subscriptions

Just like queues and topics do not duplicate if you call the CreateQueue/CreateTopic with the same name multiple times, the Subscribe(topicArn, queueArn) does not duplicate the subscription when using same topicArn and queueArn pair on actual aws, while goaws does not work like expected, it keeps adding the subscriptions.
This can be tested using the postman collection from the readme, executing the Subscribe multiple times and then checking the result of ListSubscriptions will show that there are multiple subscriptions with same topic/queue pairs.

@cotko - PR submitted https://github.com/p4tin/goaws/pull/113

PR merged


erb code not execute on partial after broadcasting

I am using faye rails for a bsic chat. Following the railscast the users can send messages to each other but I want to mark the messages as read when the recepient receives it. I added some ruby code on the partial because I thought that when the message is evaluated on the recipient wil be executed too. But it not working..
application.js:
$(function() {
var faye = new Faye.Client('http://myip/faye');
faye.subscribe('/messages/<%= @conversation.faye_token%>', function (data) {
eval(data);
});
});
create.js.erb:
<% broadcast<EMAIL_ADDRESS>do %>
$("#chat").append("<%= j(render('message', :message=> @message)) %>");
<% end %>
$('#message_body').val('');
and the partial I am rendering:
<%= message.body %>  at <%=    message.created_at.strftime("%H:%M, %d %b") %>
<%if message.recipient_id.to_s == session[:user_id].to_s%>
<%message.reading%>
<%end%>

But the ruby code is executed on the recepient only if I reload the whole page.

Right! After debugging the code .. I found out that the if block is not executed because user id is the one of the sender's. Weird.. Finally, I manage to solve this problem with an ajax call inside the broadcast method, calling the url of an action in my controller.

Right! After debugging the code .. I found out that the if block is not executed because user id is the one of the sender's. Weird.. Finally, I manage to solve this problem with an ajax call inside the broadcast method, calling the url of an action in my controller.

Glad you solved it!

Glad you solved it!


FileNotFoundError: [Errno 2] No such file or directory: '/sys/devices/system/cpu/present' i.e. Windows support

I ran the example with a simple loop:
import pyRAPL

pyRAPL.setup()

@pyRAPL.measureit
def foo():
    a = 0
    for x in range(10000000000):
        a += x
    print(x)

foo()

and it gave the above error. It looks like a Linux directory.
Surprised it doesn't support Windows (or did I miss something?)

Same problem

me too


Bug: npm install cannot run to completion on Ubuntu

Which package(s) does this bug affect?

[X] Create Plugin
[ ] Sign Plugin
[ ] Plugin E2E

Package versions
4.0.0

What happened?
When running npm i/npm install, it gets stuck installing dependencies. I think it has something to do with cypress. The script exits and no packages are installed in node_modules. This is right after a clean run of npx @grafana/create-plugin@latest
What you expected to happen
The installation to run to completion and the packages installed in node_modules.
How to reproduce it (as minimally and precisely as possible)

In this environment...
With this config...
Run npx @grafana/create-plugin@latest (version 4.0.0)
cd <whatever>
Run npm install (I used the --verbose option to generate the log file)
See error...

Environment
System:
   OS: Linux 6.5 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
   CPU: (12) x64 AMD Ryzen 5 4600G with Radeon Graphics
   Memory: 4.20 GB / 7.61 GB
   Container: Yes
   Shell: 5.1.16 - /bin/bash
 Browsers:
   Brave Browser: <IP_ADDRESS>

Additional context
The error starts here:
8209 verbose stack Error: command failed
8209 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:53:27)
8209 verbose stack     at ChildProcess.emit (node:events:518:28)
8209 verbose stack     at maybeClose (node:internal/child_process:1105:16)
8209 verbose stack     at ChildProcess._handle.onexit (node:internal/child_process:305:5)
8210 verbose pkgid<EMAIL_ADDRESS>8211 verbose cwd /home/nic/Desktop/grafana-v10.3.3/data/plugins/hello-test-panel
8212 verbose Linux 6.5.0-17-generic
8213 verbose node v20.11.1
8214 verbose npm  v10.4.0
8215 error code 1
8216 error path /home/nic/Desktop/grafana-v10.3.3/data/plugins/hello-test-panel/node_modules/cypress
8217 error command failed
8218 error command sh -c node index.js --exec install
8219 verbose exit 1

2024-02-14T22_49_53_226Z-debug-0.log

Having the same issue.
Output:
➜  poc npx @grafana/create-plugin@latest
(node:441969) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
npm ERR! cb.apply is not a function

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/martin/.npm/_logs/2024-02-15T07_02_41_042Z-debug.log
Install for [ '@grafana/create-plugin@latest' ] failed with code 1

Log

Had similar issue (something to do with cypress?) with both  @grafana/create-plugin@latest and<EMAIL_ADDRESS>Output
➜  poc npx @grafana/create-plugin@latest
(node:441969) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
npm ERR! cb.apply is not a function

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/martin/.npm/_logs/2024-02-15T07_02_41_042Z-debug.log
Install for [ '@grafana/create-plugin@latest' ] failed with code 1

Log
➜  poc cat /home/martin/.npm/_logs/2024-02-15T07_02_41_042Z-debug.log
0 info it worked if it ends with ok
1 verbose cli [
1 verbose cli   '/usr/bin/node',
1 verbose cli   '/usr/local/share/.config/yarn/global/node_modules/npx/node_modules/npm/bin/npm-cli.js',
1 verbose cli   'install',
1 verbose cli   '@grafana/create-plugin@latest',
1 verbose cli   '--global',
1 verbose cli   '--prefix',
1 verbose cli   '/home/martin/.npm/_npx/441942',
1 verbose cli   '--loglevel',
1 verbose cli   'error',
1 verbose cli   '--json'
1 verbose cli ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose npm-session f40137a615399595
5 silly install loadCurrentTree
6 silly install readGlobalPackageData
7 http fetch GET 200 https://registry.npmjs.org/@grafana%2fcreate-plugin 15ms (from cache)
8 silly pacote tag manifest for @grafana/create-plugin@latest fetched in 36ms
9 verbose stack TypeError: cb.apply is not a function
9 verbose stack     at /usr/local/share/.config/yarn/global/node_modules/npx/node_modules/npm/node_modules/graceful-fs/polyfills.js:287:18
9 verbose stack     at FSReqCallback.oncomplete (node:fs:205:5)
10 verbose cwd /home/martin/dev/noisemeter/poc
11 verbose Linux 6.7.3-arch1-1
12 verbose argv "/usr/bin/node" "/usr/local/share/.config/yarn/global/node_modules/npx/node_modules/npm/bin/npm-cli.js" "install" "@grafana/create-plugin@latest" "--global" "--prefix" "/home/martin/.npm/_npx/441942" "--loglevel" "error" "--json"
13 verbose node v21.6.1
14 verbose npm  v5.1.0
15 error cb.apply is not a function
16 verbose exit [ 1, true ]

Weirdly, it works after doing both yarn cache clean and rerunning nvm use --lts

Hi @6nv and @mkoo21
We did some internal tests using the same conditions you shared with us: same ubuntu version (baremetal), node version, npm version and create-plugin version and we could not reproduce this issue. We also tried other linux distributions (fedora and arch) with the same versions of software and could not reproduce it either.
Based on the logs you sent us our best guess so far is that your node installation relies on elevated privileges and cypress fails to install because of this. Are you used to install dependencies with sudo?
if so, you may need to configure your system to use a prefix for npm. you can see the documentation for the npmrc package here https://docs.npmjs.com/cli/v10/configuring-npm/npmrc#files and there are many resources online that explain how better make sure you don't need elevated privileges to install npm packages.
That being said. If you don't plan to use cypress in your plugin you can also opt to remove it from the devDependencies section in the package.json file. It won't affect the normal functionality of the plugin.

I think the issue actually lies with the node/npm installation like you suggest. Because apt has a really old version of node (v12) for some reason, I originally installed node using the snap manager. I was able to install v20 and didn't have any issues until now. Try following these steps to see if you can reproduce the issue.

Someone suggested to me that I try installing nvm which allows you install multiple versions of node/npm at once and switch between them. For some reason, this actually worked (after completely removing my old installations first.) @mkoo21 try installing nvm, curious if that will fix your issue as well.

I can confirm that my npm installation does not require sudo and has a correctly configured prefix in my user's home directory. I installed node with pacman, and I do use nvm. This does seem to be related to node installation and cypress, as I noted in my comment nvm use --lts made it happy after cleaning cache (I did not need to reinstall lts, which is very weird).
In any case this does seem to be more of a node/nested dependency issue than a grafana issue.

Yes, actually, you are right, mine doesn't have cypress either. I tried with v4.0.0 and v3.6.0 of the plugin.

@academo - something when you walk through the steps of npx @grafana/create-plugin for the first time, it asks if you optionally want to include CI workflows. This is great as it allows you to customize your repository a bit.

Something I'd love to see is to optionally include/avoid all these test frameworks. It would be interesting to see as a percentage of community plugins, how many are actually using all these included frameworks. I'll open a new issue about this to keep it separate.

It's from @grafana/e2e

Maybe! I haven't tried that yet. Either way, I got my plugin to build after installing nvm so removing @grafana/e2e shouldn't affect whether it compiles or not. Try it on your end and let me know.

#750 Here is the feature request asking for a "bare minimum" starter plugin.

@academo thanks for taking a look at this. How was node/npm installed on your test device?

We tested in several devices. All of them use NVM

It's from @grafana/e2e, maybe this is what @academo meant when he said to remove cypress as a devDependency?

Yes!, my mistake in the comment. I indeed meant the @grafana/e2e package which is the one that brings the cypress dependency.
note that I don't consider removing the e2e package the solution to this problem because the problem exists in your nodejs installation and not in create-plugin or cypress.
If you are reading this issue while facing this issue I advice you to re-install nodejs using the official nodejs installation guide for your OS https://nodejs.org/en/download/package-manager/ or even better, consider using nvm https://github.com/nvm-sh/nvm

@academo thanks for taking a look at this. How was node/npm installed on your test device?

We tested in several devices. All of them use NVM

If you want to reproduce the issue, install node with:
sudo snap install node --classic


Update node

While these changes are right, we probably don't want per-library build instructions unless there's something unusual about it. Instead we should have a general "Building w/ Ebb Libraries" instructions which live in our top-level README or as a file in the /docs directory.

@BetsyRT r+

@BetsyRT r+

@BetsyRT r+

:pushpin: Commit ede9715 has been approved by jmcadden

:hourglass: Testing commit ede9715 with merge e7125f7...

:sunny: Test successful - runtests
Approved by: jmcadden
Pushing e7125f734be2606b2d1298921309cca48ebb7044 to master...


support testing with remote standalone server

Many people use Watir on AWS or Saucelabs, so we should test our code through the remote server.

Ah, yet another cool Selenium feature. I added the ENV variable, but some of these ENVs seem overkill since as far as I know only you and I are running these things, and we aren't using most of them. :) One watirspec needs updating for getting browser name "chrome" instead of "remote," otherwise everything passes the remote tests.

merged


consul cannot register check 'Distributive Consul Health Checks' after worker restart

When a worker node is rebooted (or if consul is restarted), consul fails to start with the following error:
Error starting agent: Failed to register check 'Distributive Consul Health Checks': ServiceID "consul" does not exist &{distributive-consul-checks Distributive Consul Health Checks  consul   {/bin/distributive -f /etc/distributive.d/consul.json  1m0s 0 0  }}

I'll work on narrowing the register distributive tasks for consul to specifically control nodes only.

PR #544  has been opened to correct this.


react-resource-router does not render matched component on redirect or hash change with hashrouter

If you use createHashHistory with react-resource-router like so:
<Router routes={routes} history={createHashHistory()}>
        <RouteComponent />
</Router>

When you change the url hash through  or manually it does not render anything (or the matching route component).
When reloading the page with the correct hash route it then matches and renders the correct component.
We've created a minimal reproducible example below:
https://codesandbox.io/s/react-resource-router-hash-router-bug-lmzfe

Seems like the issue is about the actual support of history v5, that currently does not work at all


[Module Proposal]: avm-ptn-vnetgateway (ptn) (tf)

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals

Check this module doesn't already exist in another project that is being evolved into AVM

[X] I have checked for that this module doesn't already exist in CARML or TFVM

Terraform or Bicep?
Terraform
Module Classification?
Pattern Module
Module Name
avm-ptn-vnetgateway
Module Details
Terraform Module for VPN Gateway
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username
mbilalamjad

Hi @mbilalamjad,
Thanks for requesting/proposing to be an AVM module owner.
We just want to confirm you agree to the below pages that define what module ownership means:

https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
https://azure.github.io/Azure-Verified-Modules/specs/shared
https://azure.github.io/Azure-Verified-Modules/help-support/module-support

Any questions or clarifications needed let us know.
If you agree please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks
The AVM Core Team

@mbilalamjad  - Thank you for proposing this one. For the VPN gateway the armresourcename name is vpngateways -
I have edited the issue form to reflect the correct name ( avm-res-network-vpngateway)
Please see the specification (https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-rmnfr1---category-naming---module-naming)
Module names MUST follow the below pattern (all lower case):
Bicep: avm-res-

We have this already
@luke-taylor wrote one

@matt-FFFFFF - Would it make sense to convert the one written by @luke-taylor into AVM complaint? May be @luke-taylor can help with this one ?

@matt-FFFFFF pls advise how to proceed with this.

We will create a pattern module in AVM this week

It was in the ALZ backlog @JefferyMitchell
Will do

I found it! I see it was closed in July!

I had a discussion with @matt-FFFFFF over this and this is the summary

The current module crated by @luke-taylor - (https://registry.terraform.io/modules/Azure/vnet-gateway/azurerm/latest) provides a better end user/customer experience.
This module can deploy VPN or Express Route gateways along with route table configs.
This module Supports configuring ER and  S2S vpn, etc.
Matt and Luke are working to evolve this module into AVM specs.

Renaming this Issue into pattern module now and moving into Development.

Hi @luke-taylor
Thanks for requesting/proposing to be an AVM module owner.
We just want to confirm you agree to the below pages that define what module ownership means:
https://azure.github.io/Azure-Verified-Modules/specs/shared/team-definitions
https://azure.github.io/Azure-Verified-Modules/specs/shared
https://azure.github.io/Azure-Verified-Modules/help-support/module-support
Any questions or clarifications needed let us know.
If you agree please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks
The AVM Core Team

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
We just want to ask you to double check a few important things before you start the development.
Please use the following values explicitly as provided in the module index page:
For your module:
ModuleName - to name your module
TelemetryIdPrefix - to be used in your module's telemetry
For your module's repository:
Repository name and folder path are defined in RepoURL
Create the GitHub teams defined in the ModuleOwnersGHTeam and ModuleContributorsGHTeam columns
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment, once your module is ready to be published! 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team
NOTE:
This Module Proposal issue MUST remain open until the module is fully developed, tested and published to the relevant registry. Do NOT close the issue before the successful publication is confirmed!
Once the module is fully developed, tested and published to the relevant registry, and the Module Proposal issue was closed, it MUST remain closed.

@mbilalamjad , @PmeshramPM  Matta and Luke confirmed that module is published, please update index list.

Thank @luke-taylor & @matt-FFFFFF for contributing and publishing the module to the registry
https://registry.terraform.io/modules/Azure/avm-ptn-vnetgateway/azurerm/latest


General enhancements to floating docks

Added borders.
When closing, made the dock be put back in its previous position and made it switch to it.
Made the "Make Floating" button translatable.

Thanks!


Add a workflow to auto-publish the experimental catalog

This is a first step into fetching external tekton resource and
publishing it automatically. This is.. a test for now :D
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

/lgtm
/approve


fixed phantom keys but removed simultaneous keys

Take a look on https://github.com/glfw/glfw/commit/4ff66a7818e3eaa5362c828a18220b12f1cd9bc8
checking lastKeyTime < time is ok - if we test lastkey == key, otherwise we discard other keys pressed simultaneous.
Pressing multiple keys at the same time is a basic feature which is missing due to this.
Is it time to remove that hack and let the user deal with it ?
Is it better to not use IM at all ?
cheers.

related to https://github.com/glfw/glfw/issues/1112

Thank you for reporting this. It should be mostly fixed now with 9a3664b4a992a5a9b669179098542b0f882dece7.


Added a launch file to display a urdf.xacro model

I leave it to @ipa-fmw and @ipa-nhg to decide about the config and then merge this PR...I'm ok with both options...

@ipa-nhg: let's fight :-)


job retry page shows wrong log url

repro:
click User Log or Log Folder button will get a 404 error

https://github.com/microsoft/pai/pull/4442


The visual-test-result-comparison tool need to support models with multiple diagrams

For instance C.4.0.
This is linked to #32

15 May 2019 Webmeting
Closed


Font doesn't support unicode example characters

(Originally tweeted: https://twitter.com/MRWweb/status/657294240234369024)
On https://developers.google.com/web/fundamentals/design-and-ui/media/images/use-icons?hl=en, there is the followiing:

Beyond the normal character set, unicode may include symbols for number forms (⅐), arrows (←), math operators (√), geometric shapes (★), control pictures (▶), braille patterns (⠏), music notation (♬), Greek letters (Ω), even chess pieces (♞).

At least on Chrome on Windows 8.1, number forms and braille patterns show up as the dreaded box character. (My guess is that this is because Helvetica is the top of the font-stack). This page should either ensure the font used supports all the characters across all platforms, or use unicode characters with better support across the entire font stack.

Fixed


Favicon and status indicator stops working

Component
server, web-ui
Describe the bug
When using Firefox 116.0 and the latest WP next container image, the favicon (including the status) is no longer displayed.
Still works fine in Chrome, FF shows The connection to https://ci.example.com/stream/events was interrupted while the page was loading in the dev console, that seems to be the only difference between FF and Chrome.
System Info
{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-4d83ea0d"}

### Additional context

_No response_

### Validations

- [X] Read the [Contributing Guidelines](https://github.com/woodpecker-ci/woodpecker/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://woodpecker-ci.org/docs/intro).
- [X] Check that there isn't [already an issue](https://github.com/woodpecker-ci/woodpecker/issues) that reports the same bug to avoid creating a duplicate.
- [X] Checked that the bug isn't fixed in the `next` version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
- [X] Check that this is a concrete bug. For Q&A join our [Discord Chat Server](https://discord.gg/fcMQqSMXJy) or the [Matrix room](https://matrix.to/#/#woodpecker:matrix.org).

I'm still having this issue on 2.2.2.


codegen bzl rules and template

The new approach to codegen has two rules dart_codegen_binary and
dart_codgen_rule to create a custom skylark rule for code generation.
This has the advantage of keeping all the config (extensions, whether
generation supports summaries, etc) out of the rule configuration of the
consumer.

Add bzl files for the codegen binary, action, and rule
Add a template for the entrypoint to codegen generators using the
(currently unpublished) bazel_codegen package

Can we add an example directory and tests for these rules? Similar to the files being removed in #83.

It's hard to add a test for these until we get bazel_codegen published since that doesn't exist in this repo, but is the only supported way to do codegen...
It's not exactly a situation I'm thrilled with but I don't know if it's worth contorting things into having our Dart code for codegen and our bzl files live together.

After some more discussion it's a bit uncertain (again) whether the Dart code for bazel_codegen should live in this repository or in dart-lang/bazel repository.
My plan was to put it in the bazel repository but we might want to revisit that decision.
Either way I think these rules shouldn't be impacted so will merge this and follow up with the Dart code in whichever repo makes sense.


[WIP] 0.7.0 Release

Hey there!
The upcoming Release for vite-aliases will include some new Features and Fixes based on a total Rewrite of the Project.
Atm its still WIP so not all Features are 100% tested.
Thusfar if you still need a Stable Release without the new Features, consider using Version 0.6.3
via npm install<EMAIL_ADDRESS>-D
0.7.0 New Features:

Watcher (will now generate Aliases on Folder add/remove)
Revamped Log and Terminal Output
JS/TS Config Creation & Update (it will automatically update your PATHS for the specific JSON File, if one exists or just create a File)
Small Fixes for old Features

Current "Problems":

Log and Config Update only work on restarting Vite
--> This means, when you add a Folder, but you need IDE Support to autoimport Files for example, consider restarting Vite.

The Reason for this is pretty simple, atm, the Log and Config are only touched once and not per every new Entry (add or removal). I have not had the time to check if the file creation/update process of both functions would have a great performance impact if they are done by the watcher every single time a folderstructure change is happening, so thats why i didnt include it directly. I wanna have this Feature checked perfectly before it ends up causing to much Issues.

Great news! I've got an issue with TS not allowing partial options like {dir:'.vitepress'}. And also got duplicates error now because of two components folders in the structure. Will find a way to upgrade later.

Hey there!
Thanks for the Information, guess ill missed to allow default Config Options ^^
Will get a fix out later..
For the Duplication Error:
The Basic Behavior has not changed from the older Versions.
vite-aliases handles duplicates in the following way:

get the last folder of the given path
turn relative path into absolute
compare generated aliases

Basically if you got two folders with the name components, you got to turn on ignoreDuplicates
This will remove the Error but with a Drawback.
Aliases are generated based on Folderstructure and the folder that is generated after the one with the same name gets overwritten.
src\components -> @components -> F:\work\project\src\components
src\pages\components -> @components -> F:\work\project\src\pages\components
With ìgnoreDuplicates on false this will throw an Error.
With ignoreDuplicates on true, it will get the pages\components as the @components and the first generated aliases is ignored.
Ive got a workaround here that i am working on, but not sure if i do really like the behavior. Basically it will grab the second last folder if there is already a Duplicate existent. @pagesComponents for example..

OK, thanks! The other way is to turn off deep?

I redirect the Issue for Duplication to a new Thread!
This needs further exploration i think..


Work with Android systracing in release mode

Currently, tracing is unconditionally disabled on Android release. However, if --trace-systrace has been passed, we should allow tracing to work.
/cc @jason-simmons who is in the blame for disabling on release builds and may have some thoughts. One idea would be to guard tracing on both Fuchsia and Android by whether trace-systrace is specified, at least if in release mode.

Related: https://github.com/flutter/engine/pull/18855 and https://github.com/flutter/flutter/issues/58816

This was fixed by https://github.com/flutter/engine/pull/28903 and its reland.


Tesha/fix waf policy examples

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify
Missed updating the CRS version in previous PR to latest needed for some new fields.

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
Backend is already deployed.

When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
Next swagger release.

If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Closing this as it got accidently created against master branch.


Evaluate whether or not ScanServer should use the Client Thrift service

TabletServers Thrift servers host the Client service. Should ScanServers do this now as well?

Looking further I think that ScanServer and Compactor could also host the ClientService. This would allowany non-management (Manager, GC, Monitor) server to authenticate users, provide configuration, support ping, etc.


Get Object from Class?

Hi @SSheldon 👋😀,
Thanks for this awesome library! I'd sponsor it if you turned on GitHub Sponsors 💖
Also, GitHub Discussion is a nice feature and would probably be better for the question I'm asking here:
Can you get an Object from a Class or can you only go the other direction?
Thank you, 🙇🏻♂

You can't really, since there is not a one-to-one relationship between these two. An object has one class, but a class can have many objects (called instances).
You can however create a new object from a class by simply sending new to the class, if that's what you're asking:
let cls = class!(NSObject);
let obj: Object = msg_send![cls, new];


Base Enhancement, add i18n in Base component

Current Behavior
Currently, we only have one BaseStyles( code link ), which contains the validation of HTML tag and pass all customProps down to the children.
Expected Behavior after the enhancement
The Base component will have an I18nProvider to wrap the current . In this way, we will guarantee:

Consumers must provide I18nProvider as the ancestor of the all React components. All the translations will work correctly.
We don't provide IntlBase and BaseStyles as two separate components. Consumers just can easily consume it by import Base from "terra-base";.
This I18nProvider is also the first place to merge customized translations from App with terra-i18n default translations and pass down to make it available to all children.

What does include in this enhancement?
API:

locale is used for setting locale and load all required locale data.
children wrap all children in new Base.
customMessages, all required translations from App level.

React Lifecycle functions update:

componentDidMound to guarantee the component will be rendered after i18nLoader load all I18n required files.
componentWillReceiveProps to guarantee if the locale prop or customMessage prop update, the Base will be rerendered.

Influence of this enhancement

terra-i18n will be a dependency for terra-base.

#400 merged into master, close this issue.


UI: JOB does not complete when you create a template from snapshot

ISSUE TYPE

Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

4.13+

CONFIGURATION

NA
OS / ENVIRONMENT

NA
SUMMARY

When creating a template from volume snapshot, the UI displays the job as still running but you can see that the template is in ready state.
STEPS TO REPRODUCE

1. create a snapshot of a volume
2. create a template from the snapshot

EXPECTED RESULTS

Job of the create template action should be marked as successful in the UI when complete.

ACTUAL RESULTS

It's running indefinitely

I think this is a more generic issue where jobs finish but the notification drop-down still shows them as running. The completion event or message does not reliably come through, it seems. I have reproduced it with 4.1 and master, in the scenario of creating template from snapshot but not reliably, and i remember it happening on other longer going jobs as well, like starting or stopping networks and VMs.

This was fixed by some commit, not sure which.

I've tested this case with Primate and 4.14+master recently, did not reproduce this. Closing on the remark that it was not reproducible with Primate, pl log issue here https://github.com/apache/cloudstack-primate if reproducible. Thanks.


Frontend - Student A

Created the index page in React to show all available cars in the franchise:

Created carousel styling with 3 cars at a time, similar to the design provided
Added animation to the carousel
Added name, brand, price information, and icons for each car

Used Redux to fetch data from the Rails Back-End

Hi @lfmnovaes ,
Congratulations! 🎉 Project Approved ✅
Your project is complete!  There is nothing else to say other than... it's time to merge it 🚀
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


XCScheme string initializer

Short description 📝
The XcodeProj type has a convenience initializer that takes a string. Really is convenient, because it hides the PathKit dependency from callers. But XCScheme lacks a similar initializer. I'd love one!
Solution 📦
Implementation 👩💻👨💻
I just copied in the solution from XcodeProj 😅
I had a look, and found no tests that use the XcodeProj method, so I went with that too. But happy to do more if needed!

@all-contributors add @mattmassicotte for code


Included habana based imagestream to the notebook manifests

Included habana based imagestream to the notebook manifests
Description

Include habana based imagestream to the notebook manifests
Related-to: #96
How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/lgtm

Thanks for the review
Merging this to get the release ready.
/approve


Suggestion: Add example describing custom loop event

The title is pretty self-explanatory. It would be great if we could add an example describing custom loop events and how to handle them. This will serve the following purpose:

Let the programmer start/stop custom loop
Handle the loop using event(For example, the programmer may want to end the loop when 'q' is pressed).

Please share your views regarding this.

Hi, and thanks for the idea!
I'm not entirely sure what you mean by custom loop. One thing we could show is how to run an event loop, wait for an exit event (as you said, pressing 'q'), then doing some other work, and start a new event loop.
Conceptually, starting a new event loop can be simply calling Cursive::run() again:
let mut cursive = Cursive::new();

// Prepare views

// First event loop, stops when `q` is pressed
cursive.run();

// Some work

// Second event loop
cursive.run();

The problem we currently have is if we want to use the terminal between the two event loops. Right now, you need to drop the Cursive object to put the terminal back to its regular state. This means losing your current layout, and is not super convenient overall. (On the current master, the situation is even worse, and running more than one event loop can already cause issues. Hopefully I can fix that before the next release).
As mentioned in #199 , it would be nice to be able to "pause" cursive, do things with the terminal, and start again. This is not available yet, but is planned~ish.

Hi, thanks for the reply. What urged me to open this issue is:
Looking at the documentation of Cursive, we can run a step of the event loop with siv.step() call whereas siv.quit() is used to stop the event loop. So while working on a CLI application that I'm developing, I tried to use the following logic:
fn main() {
    let mut siv = Cursive::default();
    loop {
        // Create layouts and panes
        siv.add_layer(your_layer);
        // Make a draw call?(maybe I'm wrong here)
        siv.step();
        if some_event_cond == false {
            siv.quit();
            break;
        }
    }
}

I tried adding add_global_callback to the loop, but it won't work and the application would continue running in an infinite loop.
On the other hand, all KEY events are handled via on_event method on views if I'm not mistaken. So this limits the developer from adding conditions to some_event_cond using Cursive events. Maybe, I have to resort to the underlying backend for writing some_event_cond such as termion. However, I have no idea whether it would be compatible or will it break things.
Kindly let me know your comments on this.

You may be interested in Cursive::is_running, it returns true until you call quit(), after which it returns false. You can use that as loop condition.
You would call quit() from a callback defined on 'q' for instance.


Add the ability to set a credential JUST for the Email notifications (SMTP)

done, in next release


model result format

Hi, would you please elaborate model output format? i.e how to get Table and cell mask so that OCR can be performed on them.
Thank You

can anyone explain?

Hi @DevashishPrasad  can you elaborate on this!?


PDF Export is not working.

Hello,
I just setup my datables as a service and pdf export is not working. When i click to the PDF button error shows.
PHPExcel_Writer_Exception in DomPDF.php line 34:
Unable to load PDF Rendering library
When i searched on google, https://github.com/dompdf/dompdf/releases dompdf was changed configuration file. "dompdf_config.inc.php file has been removed"
DomPDF.php uses this config file and there is no config file.
$pdfRendererClassFile = PHPExcel_Settings::getPdfRendererPath() . '/dompdf_config.inc.php';
if (file_exists($pdfRendererClassFile)) {
    require_once $pdfRendererClassFile;
} else {
    throw new PHPExcel_Writer_Exception('Unable to load PDF Rendering library');
}

What i have to do ? Is there any workaround ?

Operating System : Windows 9.1 Pro, XAMP
PHP Version : 5.6
Laravel Version : 5.2
Laravel-Datatables Version : Lastest

I suggest you use laravel-snappy as the pdf generator. Laravel-Excel usually hangs when being used with PDF.

Which version of laravel-snappy i have to use? I added ""barryvdh/laravel-snappy": "^0.3.1"," and change datatables.php "pdf_generator" to "snappy". after these changes i got this error.
"Unknown long argument --lowquality"

@mcsaygili were you able to install wkhmtltopdf?

ah sorry, yes i'm using perfectly. but if you are using windows i'm not recommend. I was change my development platform to Ubuntu. :)

I have install laravel-snappy but still i get json format not the pdf. why? @yajra


Authentication fallback to use organisation publishers

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-2192

Review app deployed to https://teaching-vacancies-review-pr-3083.london.cloudapps.digital


While Selecting between tabs, it recreates the component in md-content

Bug, feature request, or proposal:
I have a component that shows a grid (wijmo). While embedding this component within the md-content, it renders the tab pretty nicely. However when i select between the tabs , the component gets recreated. Hence the grid is re-rendered and any filters or groups applied gets cleared.
Which versions of Angular, Material, OS, browsers are affected?
Angular - RC5, Material - Alpha 7.2

If I recall things properly this is by design. If you want to preserve state just keep your data model outside of tabset.

See #731


chore(dns): example cloud dns example with dnssec

Add cloud dns example for DNSSEC
Reference: https://cloud.google.com/dns/docs/dnssec-config#gcloud_1

@msampathkumar
Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
dns_managed_zone_with_dnssec/main.tf
--- old/dns_managed_zone_with_dnssec/main.tf
+++ new/dns_managed_zone_with_dnssec/main.tf
@@ -21,7 +21,7 @@
  dns_name    = "myzone.example.com."
  description = "Example Signed Zone"
  dnssec_config {
-      state = "on"
+    state = "on"
  }
}
# [END dns_managed_zone_with_dnssec]
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>

@msampathkumar
Thanks for the PR! 🚀✅ Lint checks have passed.

Noticed the same error again. Using example.com. (a generally recognisable example domain name) also did not work!
ManagedZone: googleapi: Error 400: The domain 'example.com.' (or its child domains) may be reserved or registered already, prohibited by policy, or there may be no DNS name server shards remaining for the name. For more information see https://cloud.google.com/dns/quotas#nameserver_limits.,

We're getting these errors:
Error 400: The domain 'example.com.' (or its child domains) may be reserved or registered already, prohibited by policy, or there may be no DNS name server shards remaining for the name. For more information see https://cloud.google.com/dns/quotas#nameserver_limits., managedZoneDnsNameNotAvailable
```

Maybe comment it out or skip testing for this sample?

Error 409: The resource 'entity.managedZone' named 'peering-zone-e3a6a086b7c33f1b' already exists, alreadyExists

Maybe use a randomizer for the name?

@msampathkumar
Thanks for the PR! 🚀✅ Lint checks have passed.


Configure Azure Pipeline

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: alee25 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Multisig account support

Does it support multisig account? If yes how to proceed?

Hello, @amitsharma8891
This feature will come soon, please stay tuned!

cosmos-sdk support multisig account. can i use it?

cosmos-sdk supports multisig account. can i use it?

Hello,
At the moment, Multisig is not supported yet and the recommended way to secure your keys is through Threshold Signature Scheme(TSS). Please take a look at the implementation here: https://github.com/binance-chain/tss-lib

cosmos-sdk supports multisig account. can i use it?

Hello,
At the moment, Multisig is not supported yet and the recommended way to secure your keys is through Threshold Signature Scheme(TSS). Please take a look at the implementation here: https://github.com/binance-chain/tss-lib

thanks.
When i read doc,
I have some doubt. It supports mainnet cli, but the next line in doc is

Warning: Please note that TSS is still an experimental function and please do not test this on mainnet.

So is tss finished?  or just an experimental function

cosmos-sdk supports multisig account. can i use it?

Hello,
At the moment, Multisig is not supported yet and the recommended way to secure your keys is through Threshold Signature Scheme(TSS). Please take a look at the implementation here: https://github.com/binance-chain/tss-lib

thanks.
When i read doc,
I have some doubt. It supports mainnet cli, but the next line in doc is

Warning: Please note that TSS is still an experimental function and please do not test this on mainnet.

So is tss finished? or just an experimental function

I find my answer.  Thanks.


Nier Automata renders at selected resolution instead of 1600x900

I'm sure you're aware of this, but Nier Automata always renders at 1600x900 and is then upscaled to whatever resolution you've selected.
However, DXVK always renders it at the resolution requested by the user, like FAR mod. I've noticed this when testing why DXVK performance was lower than Windows DX11. When set to 900p with DXVK, performance is very close.
This also happens when using DXVK on Windows, so it's not related to Wine.
When loading the game, it also freezes my DE (Gnome 3.30) whenever the initial loading screen is finished and it proceeds to the start menu. Does not happen on WineD3D nor Windows with DXVK.
This is gone now, I have no idea why.
Software information
Nier Automata, settings don't matter.
System information

GPU: NVIDIA GTX 970
Driver: 396.54.09
Wine version: Proton 3.16-3 (replaced DXVK with newest version)
DXVK version: v0.90-10-g5124fd8 (latest commit as of this date)

I think the option to have DXVK override what the game renders at would be nice, but the default behaviour should be to do whatever DX11 does.

No, the game doesn't render at 1600x900.
On Windows, the game is rendered at your monitor's resolution, then downscaled to a lower resolution because the display mode selection in their engine is broken, and then upscaled again. The reason it works on DXVK is because DXGI reports display modes slightly differently than native Windows.
Performance is known to be extremely low on Nvidia hardware in this game, there's nothing you can do about it except hope for a driver update. FWIW my RX 480 runs the game with a constant 60 FPS at 1080p.

That's even more scuffed than I had anticipated. I thought they had the game render at 900p intentionally.
If this is intended behaviour I'll just close this.


[suggestion] Adding Support for the new Wake Lock API (available on Firefox OS and newer Chrome with web-experiments allowed)

https://developer.mozilla.org/en-US/docs/Archive/B2G_OS/API/Wake_Lock_API
This is a non-standard feature but it is available on some platforms,
essentially it will allow a web-app that uses NoSleep.js,
to also switch off the PC screensaver (currently, screensaver and power-saving are not turned off).
Also, it does not require user-interaction.
I've combine it with the normal in a little try/catch...
var screen_lock; //should be available globally for the app.

//....

function toggle_fullscreen(){
  if(false === is_fullscreen_on()){
    console.log("is not in fullscreen, turning on.");
    nosleep.enable();
    if("undefined" !== typeof window.navigator.requestWakeLock){ try{ screen_lock = window.navigator.requestWakeLock("screen");}catch(err){} }    //trying to keep screen-ON using: https://developer.mozilla.org/en-US/docs/Archive/B2G_OS/API/Wake_Lock_API
    fullscreen_on(undefined);
  }
  else{
    console.log("is in fullscreen, turning off.");
    nosleep.disable();
    if("undefined" !== typeof window.navigator.requestWakeLock){ try{ screen_lock.unlock(); }catch(err){} }
    fullscreen_off();
  }
}

//.........

  self.document.documentElement.ondblclick  = function(ev){  //double-click on the document.
                                                toggle_fullscreen();
                                              };

This has been added in https://github.com/richtr/NoSleep.js/pull/95 and is now released as part of v0.11.0.


adding labgraph_monitor extension

Thank you for your contribution! Please include only necessary files in a PR, currently, there are 5000+ files, including cache files. An example of git ignore file can be found here: https://github.com/facebookresearch/labgraph/blob/main/.gitignore
I'm closing this PR, please create a new PR instead.


CUDA out of memory when using ELMo on a 12GB GPU

This did not happen previously, so I am currently investigating the issue.

Will need to use --batch_size=32 for 12GB. For 24GB GPU, works well.
https://github.com/uwnlp/piqa/commit/f1b4520aa40233d24cbbcb13594bda2d49a8fded

FYI, using ELMo with 12GB TitanXP (default batch_size = 64) works well :)
It takes up 9963MiB, and reaches 0.632 dev_f1 @ 5001.

Weird.. which commit version did you use btw?

I'm working on the forked repo (https://github.com/jhyuklee/piqa),
and the latest commit is https://github.com/uwnlp/piqa/commit/7dfb6fe955db9cf1b0ef1825c3b15948629a4f86.

Worth pointing out that when I tried running the code on a 12GB GPU I also ran into a memory error with the default batch size of 64. Reducing the batch size to 32 solved the problem, and also gave a better F1 score of 63.5% (before applying the ELMO fix from https://github.com/uwnlp/piqa/commit/72c762390a09dfe04a17d165f80ba02322e9a2ec).

@bdhingra thanks, 32 surely seems to work better (I got 63.7%).

After updating to https://github.com/uwnlp/piqa/commit/c6e871919a6c664d53db58fd2d7c047843ce2e75, batch_size=64 makes OOM for me, too.


Pushing what I think should be a fix for Issue #4

Old closed PR is #8

Branch should be more up to date now, though I am struggling a bit to get code that makes sense. May try and take it a part a bit to get it working

@mtfoley, does the current state of main actually do any of the merging?

@mtfoley, does the current state of main actually do any of the merging?

No, just gather enough inputs to work with (except the team members thing)


[WIP] importing @types/snarkjs

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (yarn build) was run locally in root directory and any changes were pushed
[ ] Lint (yarn lint:fix) was run locally in root directory and any changes were pushed

Pull request type
Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[X] Other (please describe): importing the defined types in @types/snarkjs

What is the current behavior?
Issue Number: #548
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[X] No

TODO
in package circuit

[X] prover/defaultProver.ts
[ ] prover/web.ts
[ ] src/BaseProof.ts
[ ] src/circuits.ts
[ ] src/EpochKeyLiteProof.ts
[ ] src/EpochKeyProof.ts
[ ] src/PreventDoubleActionProof.ts
[ ] src/ReputationProof.ts
[ ] src/SignupProof.ts
[ ] src/UserStateTransitionProof.ts

Hi, to the core contributors.
I have a question when modifying this change:
There is already the defined type SnarkProof (which is just as same as Groth16Proof in @types/snarkjs)  inunirep/utils. So, there are 2 ways of converting the types:

replacing SnarkProof with Groth16Proof in each files (the mentioned files) and delete the self-defined types in @unirep/utils
assigning SnarkProof to Groth16Proof in @unirep/utils

The second one seems to be more reasonable to me since there will be less change in our codebase. However, if this upgrade is aiming to replace types like SnarkProof with the original type Groth16Proof, then I would modify them with the 1st method.
Thanks for reading this.


Adding the UI support for the data-feed-service

Need to change the UI to support to feed the data for other sources like splunk.

Need to change the UI to support to feed the data for other sources like splunk.


⚠ Bofrost.com has degraded performance

In fb8adc5, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 895 ms

Resolved: Bofrost.com performance has improved in f5cd60d after 9 minutes.


[RFC] FastDiffRunner

Hello,
I am going to write a FastDiffRunner to offer a diff runner with better performance. And here is the proposed API. If anyone is interested, please feel free to comment and making suggestion.
Objective
The current implementation of DiffRunner requires the user to convert a C++ data structure into QVariantMap then perform a comparison. It is an easy to use solution and fast enough for the small amount of data. But since the average time complexity is O(n) even the data is unchanged. Therefore, it may be difficult to handle a huge amount of data.
To solve this problem, a new FastDiffRunner is proposed. It uses the implicitly shared data class (Immutable type) in Qt. The big-O to compare data without changes is O(1). And it doesn't convert data to QVariantMap for comparison. It should be much faster than the original DiffRunner.
Preparation

Immutable Data

FastDiffRunner only works with an immutable data type. User should create their data structure by File -> New File or Project -> C++ Class. Tick Include QShared Data in Qt Creator
Example (Generated by Qt Creator)
class CustomDataData;

class CustomData
{
public:
    CustomData();
    CustomData(const CustomData &);
    CustomData &operator=(const CustomData &);
    ~CustomData();

private:
    QSharedDataPointer<CustomDataData> data;
};

Implements isSharedWith() and key() function

class CustomDataData;

class CustomData
{
    Q_GADGET

public:
    CustomData();
    CustomData(const CustomData &);
    CustomData &operator=(const CustomData &);
    ~CustomData();

    bool isSharedWith(const CustomData& other);

    Q_INVOKABLE QVariant key(); // Optional function.

private:
    QSharedDataPointer<CustomDataData> data;
};

inline bool CustomData::isSharedWith(const CustomData &other)
{
    return this->data == other.data;
}

Implements custom convertor function [Optional]

QVariantMap convert(const CustomData& data) {
  /// Insert your code here
}

If you have declared your property via Q_PROPERTY(), then it is not needed.
Usage
The interface of FastDiffRunner is almost same as the DiffRunner, expect you may need apply a custom data convertor function and doesn't need to set key field.
QList<CustomData> previous, current;

// load previous and current

QSFastDiffRunner<CustomData> runner(convert);

QList<QSPatch> patches = runner.compare(previous, current);

runner.patch(listModel, patches);

Pros & Cons
Pros

O(1) comparison for unchanged data

Cons

It don't work for JavaScript

Request for Comment
If you have any suggestion toward the design, please feel free to leave a comment here. Thx
Discussion
Discussion 1
Interface Class
Should it use an abstract interface instead of just using Q_GADGET?
Example
class QSImmutable {
  Q_GADGET
public:
  bool iSharedWith(const QSImmutable*) = 0;
  QVariant key() const;
  bool hasKey() const; // User should implement this function if key is present in the data structure
}

Could similar variants be used for JS or other bindings like Python?(Or does that utilize C++ and thus the fast diff uder the hood?)

hi @polarathene ,
yes. I will bring the fast diff to JavaScript too (still under development). But user need to update their data by following the Immutable Update Patterns · Redux
That is the proposal:
Immutable {
    id: model
}

var list = [a,b,c]; // where a , b, c is an object type
model.source = list;

// append a new item
list = list.slice(0); // make a shadow copy
list.push(d);
model.source = list;

// update an field in the first item
list = list.slice(0);
list[0] = assign({} , list[0], changes); // e.g Lodash.assign
model.source = list;

If you have any question / suggestion, please feel free to raise.

Will there be support or information on how to implement for other language bindings to Qt/QML like Python?
Thanks for the immutable patterns link, I think I've done shallow copies in the past with spread like the example, would it be good to use something like ImmutableJS?
Presently I'm just using an Item with properties(that might have nested property items) and referring to it via my elements, when I update that data_item element properties it seems to update the bindings to everything else. I'm still learning QML/Python, only sent a custom list model with roles to QML ListView so far(seems to work fine if I bind the model to the data_item properties and have ListView reference that property for the model). Haven't tried modifying data via Python yet, The way I understand QSyncable if it had support with my backend language is I'd modify my model data on the bakend and it'd update/sync a copy between QML and backend language. If you do look into Python there seems to be Redux ports(so I'd sync that state object/store to QML with QSyncable and presumably use it like I am currently with the data_item I mentioned earlier?

You seem to do quite a few Qt/QML projects, maybe you would take interest in reviving the Quickly project which aimed to allow modern JS transpiled to QML, hasn't been maintained in a while. Would allow for fetch/promises/async?/short-lamda/destructure/spread/etc
There seems to be some effort to make a React-Native binding for Qt(ReaQt), but there isn't much out there beyond the talk so maybe it won't see the light of day from HP/Qt :( There was also react-qml that hasn't seen any love since 2015.

Will there be support or information on how to implement for other language bindings to Qt/QML like Python?

I don't familiar with C++ with Python. So now I don't have plan or pointer for this.
btw, any suggested immutable data type library I could take a look for reference?

Thanks for the immutable patterns link, I think I've done shallow copies in the past with spread like the example, would it be good to use something like ImmutableJS?

It seems that ImmutableJS is more complicated to use when compare to the immutable update pattern. Just my 2 cents.

You seem to do quite a few Qt/QML projects, maybe you would take interest in reviving the Quickly project which aimed to allow modern JS transpiled to QML, hasn't been maintained in a while. Would allow for fetch/promises/async?/short-lamda/destructure/spread/etc

In fact, I have started another project: e-fever/qmljsify: Convert an NPM package into a QML friendly JavaScript file
But the objective is different. Quickly compiles a ES6 JS + QML , but qmljsify only compile library from npm to a QML friendly way.  It don't touch the QML files.

There seems to be some effort to make a React-Native binding for Qt(ReaQt), but there isn't much out there beyond the talk so maybe it won't see the light of day from HP/Qt :( There was also react-qml that hasn't seen any love since 2015.

Although I have made few projects to bring Redux / Flux to QML, I don't quite understand why people would like to bring React to QML? The concept of QML and React itself is not quite compatible. It will just like using React within Angular...

I don't quite understand why people would like to bring React to QML? The concept of QML and React itself is not quite compatible. It will just like using React within Angular...

Similar reasons to the ReaQt video I imagine? Perhaps it would be more suited to Qt Widgets or the Qt 6 API/backend unification that seems to be planned for 2019.
I don't see how it's like using React within Angular? You can declare components like QML components, just in JSX instead of QML(which they'd get transpiled to like Quickly might have been able to do?). The benefit is similar/same code that can be used elsewhere beyond QML as a platform, the richer syntax of modern JS and wide range of library support(especially with Redux and it's middleware, including integration with React with dumb/smart components), I also like how styled-components approached styling, not sure if that'd map well to QML styling however.
You have much more experience with QML than I do, so perhaps I'm mistaken.

I don't familiar with C++ with Python. So now I don't have plan or pointer for this.
btw, any suggested immutable data type library I could take a look for reference?

I am using PySide2/PyQt5 python packages that provide the Qt/QML integration. I am new to python, I've not looked into any immutable data type library for it. It seems to be a popular choice for doing Qt interfaces with if not C++/JS.

In fact, I have started another project: e-fever/qmljsify: Convert an NPM package into a QML friendly JavaScript file
But the objective is different. Quickly compiles a ES6 JS + QML , but qmljsify only compile library from npm to a QML friendly way. It don't touch the QML files.

That looks nice, but sounds similar to QMLify that Quickly uses? I think it can do similar? I guess your one is meant to compile QML module or just JS file that is transpiled to QML JS? Quickly sounds quite appealing that you can write your QML with modern JS and import modern JS as modules and then transpile to something QML will be happy with. Common thing to do from web dev world. I can see advantage of distributing already transpiled JS for others to use too I guess. Does Quickly address the problems you mention in your repo having trouble with?


Allure 2.11 update is not compatible with the version 2.10 of plugins jenkins job.

My current jenkins version is : 2.32.1
Java version is : 1.8.0 Open JDK for the slave.
I had to apply some updates to Jenkins ant server. After that currently running UI Jobs started to fail because of report generation failure. It is a compatibility issue with an inbound Allure Jenkins plugin update.
Currently I run version 2.10 of the "Allure Jenkins Plugin".   I installed update (2.11) which was available and installed but this turns out not to actually be compatible. The build is failing with following error :
ERROR: Build step failed with exception
java.lang.ClassCastException: [Lhudson.tools.ToolInstallation; cannot be cast to [Lru.yandex.qatools.allure.jenkins.tools.AllureCommandlineInstallation;
at
ru.yandex.qatools.allure.jenkins.AllureReportPublisherDescriptor.getCommandlineInstallations(AllureReportPublisherDescriptor.java:78)
at
ru.yandex.qatools.allure.jenkins.AllureReportPublisherDescriptor.getCommandlineInstallation(AllureReportPublisherDescriptor.java:83)
at
ru.yandex.qatools.allure.jenkins.AllureReportPublisher.getCommandline(AllureReportPublisher.java:188)
at
ru.yandex.qatools.allure.jenkins.AllureReportPublisher.generateReport(AllureReportPublisher.java:160)
at
ru.yandex.qatools.allure.jenkins.AllureReportPublisher.perform(AllureReportPublisher.java:90)
at
hudson.tasks.BuildStepCompatibilityLayer.perform(BuildStepCompatibilityLayer.java:78)
at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
at
hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
at
hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
at hudson.model.Build$BuildExecution.post2(Build.java:185)
at
hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
at hudson.model.Run.execute(Run.java:1745)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Build step 'Allure Report' marked build as failure
When the plugin is reverted back to 2.10, all is fine.

see https://github.com/jenkinsci/allure-plugin/issues/75


[W4.4h][T13-1]Adrian Tan

[LO-UseCases] Add rename tag use case ✏

Update DeveloperGuide.adoc by adding Rename tag use case in which a user renames an existing tag to fulfill W4.4h 🏆

@QzSG You can close this PR after reviewing the comments.


feat(platform): support secrets for container definitions

Description:
This PR extends SST.dev's functionality to allow passing secrets to container definitions on Fargate services. Previously, only environment variables were supported. This enhancement enables secure handling of sensitive information like credentials coming form Secrets Manager or Parameter Store.
"secrets": [
    {
        "name": "environment_variable_name",
        "valueFrom": "arn:aws:ssm:region:aws_account_id:parameter/parameter_name"
    }
]

OP: https://discord.com/channels/983865673656705025/983865673656705028/1296993077982003331
Changes:

Added secrets property to container definition schema (as per Container Definitions)

~Missing:~
~- Update documentation to reflect new secrets arg in the Service section~

@ubinatus we're in the middle of switching repos (unfortunately github is making this quite messy) - going to close this PR for now. I have noted this down. And will get to it once we've moved over to sst/sst

@fwang h! no worries, we ended up using a forked sst binary with this feature. Please lmk if you need help adding this feature to the new repo, as it might be useful for users that that want to use Secrets Manager or Parameter Store on their task definitions and does not want to opt-in using sst secrets.


No recurrence?

Why are all features released half-baked.  Put this back in the oven and add a generous helping of recurrence.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b9908d77-78bc-ce88-ba84-4f1bd9fea504
Version Independent ID: 37118dd4-d036-8da7-d750-4c9f503a370a
Content: Set up holidays in Microsoft Teams - Microsoft Teams
Content Source: Teams/set-up-holidays-in-teams.md
Service: msteams
GitHub Login: @tonysmit
Microsoft Alias: tonysmit

@Patrick959 Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @Patrick959, thank you for your feedback.
This section is to improve documentation, to request new features please go to:
https://microsoftteams.uservoice.com/
Thank you!

Why don't I see the Holidays under Org-wide settings?

@Patrick959 Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Add PhotoRealisticVisualEnhancement

See #9014, the author @SpaceODY requested this mod to be added, then later closed the request with plans to set things up differently.
This pull request is based on how the mod looks now, to be revised when any updates are made. Only the "main" module is added because the others require overwriting files (presumably that is what will be changed in the next release).
https://github.com/SpaceODY/PRVE

[ ] Probably needs to provides/conflicts some of the virtual config modules
[ ] The repo says this is derived from 6 prior mods, so we should check them to make sure the license is OK
[ ] The Scatterer dependency should be versioned

Hmm, I'm guessing it's bad to mix and match versions here:
   * scatterer 3:v0.0772 (spacedock.info, 51.6 MiB)
   * Scatterer Default Config 3:v0.0831 (cached)

I just updated the mod to better support ckan. The base mod download hasn't changed but the 64k addon has. The configs now overwrite other files via module manager. There is a separate gamedata folder for this addon labeled "PRVE-64k" now.
As for the scatterer v0.08 configs leave them off of ckan for now. If people wish to have them they will need to manually download it.

All the licenses that were easy to check, check out fine. The situation with KSRSS is painfully complicated, so we'll let them worry about checking that everyone's following all the rules and complain if they find problems. :relieved:

Alright, thank you for the help!

Also, whenever I release a new version, how do I go about updating it on ckan?

CKAN will do that for you automagically when you upload a new release to GitHub (within 30 minutes or so). If you want to make changes to the compatibility or dependencies, you can either try editing the netkans yourself in a pull request, or describe the changes in a new issue like you did in #9014.


Optimize resize performance

A little big of a pull request.
The main goal was to get rid of the very-large LayoutBuilder in the root of the grid.
Flutter has a very convenient widget for that, it is called CustomMultiChildLayout. it relayouts its children without rebuilding them.
It was rebuilding the whole cells whenever resizing the window or resizing a column. (which was unusable on web and too laggy even on desktop releases)
I've used it on the columns, rows, and the main layout of the grid.
it is a big change, I know, but resizing anything in the grid now has a fantastic performance (layouting now only takes 4-5 ms).

Thank you very much for the amazing work.
That's a huge performance boost.
I tested this and found some small fixes.

Scrolling is a bit inconsistent when moving the cell focus with the keyboard.
Modification of test code.

I think I will be able to complete these and distribute them.

@MajedDH
This PR was distributed to 3.1.0.
There are many modified code, so I spent a lot of time testing.
Sorry for being late.
Your contribution is very great.


How to get the cost of a project from the usage quanity & meterRates?

From the usage API I see that we can get the usage quantity of a resource for a project and the rate for the resource consumption from the rate card API. However, the rate card API, in some cases, has a list of key-value pairs.
For ex, consider the following MeterRates:
"MeterRates": {                 "0": 0.0832,                 "1024": 0.0819,                 "51200": 0.0806,                 "512000": 0.0794,                 "1024000": 0.0775,                 "5120000": 0.0775             },
Here, if the usage quantity is, say, 102400; does it mean the cost of using the resource will be 102400 * 0.0784 or (102400 - 1023) * 0.0832 + (102400 - 1023 - 51200) * 0.0819?

RateCard follows tiered pricing, which means that if there are multiple tiers for rating a particular resource, each subset of usage in each tier is rated differently.
Let’s take an example for consumed quantity = 250
Let’s assume the rates:
0: 1
200: 0.9
500: 0.8
This means that usage for units 0 – 199 should be rated at 1 per unit, 200 – 499 at 0.9 per unit and 500+ at 0.8 per unit.
Consumed quantity of 250 would be billed at: 51*0.9 + 199 * 1 = 244.9

Hi,
can you please clarify if MeterRates tiered pricing is per billing period (month) or how is it counted?
Also there is a tiered pricing like 0-199 for 1$ and 200-499 for 0.9$.
How to compute consumption of 205 or 199.7 units?
For 205 it is ((1991) + (60.9)) or ((199.999999 * 1) + (50.9))?
For 199.7 it is ((1991)+(0.70.9)) or (199.71)?
There is no official info how to deal witch such computation.
Thanks!


Test and Fix Highscore Mode

Probably related to: https://github.com/missionpinball/mpf-mc/issues/1

When you add the highscore mode the game does not end. I.e. it is not possibe to start a second game after the third ball of the first game drained.

done


Task based docker

Run tasks within Docker?
Ref task: webplatform/ops#153
Try container: https://registry.hub.docker.com/u/webspecs/publican/

Mistake in PR, should have been against upstream


make charts generated by draft helm-compatible

With this re-write of the draft create codebase, Draft will:

detect a pack
write the chart into chart/packname/

This differs from the existing behaviour because the current implementation writes the chart directly to chart/. This allows users to run helm lint chart/packname and more importantly, helm package chart/packname.
closes #227
Some open questions about this design:

Is the pack name what we want the chart name to be centered around?

@bacongobbler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Manually testing this after a few minor fixes and it appears to work.
><> cd examples/python/
><> ls
app.py           requirements.txt
><> draft create
--> Python app detected
--> Ready to sail
><> ls chart/
python
><> draft up
--> Building Dockerfile
Step 1/4 : FROM python:onbuild
...
--> Deploying to Kubernetes
    Release "terrifying-chipmunk" does not exist. Installing it now.
--> Status: DEPLOYED
--> Notes:

  http://terrifying-chipmunk.k8s.local to access your application

And helm lint/helm package is working as expected now.
><> helm lint ./chart/python/
==> Linting ./chart/python/
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, no failures
><> helm package ./chart/python/
Successfully packaged chart and saved it to: /Users/bacongobbler/go/src/github.com/Azure/draft/examples/python/python-v0.1.0.tgz

Codecov Report

Merging #236 into master will decrease coverage by 0.34%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   36.82%   36.48%   -0.35%
==========================================
  Files          25       25
  Lines        1716     1694      -22
==========================================
- Hits          632      618      -14
+ Misses       1004      999       -5
+ Partials       80       77       -3

Impacted Files
Coverage Δ

cmd/draft/up.go
4.31% <ø> (-1.65%)
:arrow_down:

pkg/draft/pack/create.go
70.58% <100%> (-0.43%)
:arrow_down:

pkg/draft/pack/pack.go
46.15% <25%> (-4.73%)
:arrow_down:

cmd/draft/create.go
43.61% <50%> (-3.91%)
:arrow_down:

pkg/draft/client.go
75.84% <85.71%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21b20a...5ff8e72. Read the comment docs.

I'm going to hold off on merging this until we've merged #237 because this PR will be much simpler to rebase.


When updating ADM portfolio multiple times at the command line the current holdings got screwed up

Ran:
./pvapi update --portfolioID "auth0|60039713be21240070a2ce5c:d5ea5704-65b4-4452-8fc6-035472fbbd37" --date 2021-07-01
./pvapi update --portfolioID "auth0|60039713be21240070a2ce5c:d5ea5704-65b4-4452-8fc6-035472fbbd37" --date 2021-07-10
./pvapi update --portfolioID "auth0|60039713be21240070a2ce5c:d5ea5704-65b4-4452-8fc6-035472fbbd37" --date 2021-08-10
./pvapi update --portfolioID "auth0|60039713be21240070a2ce5c:d5ea5704-65b4-4452-8fc6-035472fbbd37"

It should have ended with 100% VUSTX but was:
[
  {
    "Value": 56.62233614473648,
    "Shares": 56.62233614473648,
    "Ticker": "$CASH",
    "PercentPortfolio": 0.0006073713
  },
  {
    "Value": 75178.43824785203,
    "Shares":<PHONE_NUMBER>0916375,
    "Ticker": "VFINX",
    "PercentPortfolio": 0.80641717
  },
  {
    "Value": 17990.184016015603,
    "Shares": 1575.322593346375,
    "Ticker": "VUSTX",
    "PercentPortfolio": 0.19297546
  }
]

There was a dividend on 2/28 for 29.25595 but that should have been invested in VUSTX. It is possible that it could have shown up as $CASH. Not sure why cash is 56.62 not 0 or 29.25

This bug was introduced by incremental calculation changes. We werent jumping forward in the transaction history to the appropriate transaction


fix: Parsing of quotes in command arguments

(This PR is created on top of https://github.com/ldez/go-git-cmd-wrapper/pull/4; best to merge that one first)
There was a problem constructing the "message" argument in the "git commit" and "git notes" call. Where on a command line you would normally use double quotes to indicate the start/end of an argument, this does not apply when executing the command in golang proving an array of arguments.
The following code therefore was incorrect due to the extra quotes:
g.AddOptions(fmt.Sprintf("--message=\"%s\"", msg))

Example (taken from example_test.go):
gitCmdWrapper.Commit(commit.Message("chore: foo"))
Expected result:
Commit message is chore: foo
Actual result:
Commit message is: "chore: foo" (includes quotes)
Although the fix was easy, it was non-trivial to update example_test.go since there was no way to indicate the argument boundaries in the expected results. I chose to update the test mock to return the arguments as a marshalled JSON string, and updated all expected outcomes accordingly.

Hello,
The goal of the examples is to display the git commands "as a user", a JSON syntax is offtopic.
I fixed the extra quotes on the commit message in 00e5b4ecca46e95f9152759414d5f35c4c01a73e

Ok, makes sense. Thanks for fixing. I'll update PR https://github.com/ldez/go-git-cmd-wrapper/pull/4 as well.


Operator inside of function args reported as error

Actual Behavior
x := count({"x"} & {"y"})
& is reported as an error.
Expected  Behavior
It shouldn't be.
Note that the & is just an example. I could just as well be | or another allowed operator.

@anderseknert thanks for catching this bug. I took a quick look at the grammar and I think
replacing
expr-call       ::= var ref-arg-dot* "(" ( term ( "," term )* )? ")"

by
term-or-infix-op        ::= term (infix-operator term)?
expr-call                     ::= var ref-arg-dot* "(" ( term-or-infix-op ( "," term-or-infix-op )* )? ")"

in the grammar will fix the problem.
Moreover, this issue reminds me that I don't think we have a TU that ensures we can pass complex arg to a function (eg another function). If you have other test cases that may be related let me know.  I. will push a pr by this evening

Thanks @vgramer 👍 My other tests (function call in args, etc) all look like they work already but I'll do some more testing in the weekend and will let you know if I encounter any problems. Great work on the plugin!


Enable Greenkeeper for Cesium

Greenkeeper is awesome,  It automatically runs your tests against new dependencies released on npm and opens a pull request when:

The new version isn't included in your version range in package.json, so you won't get it automatically, or
You will get the new version automatically because it's in your version range, but it breaks your build or tests.

We should enable it in Cesium.  It takes about 30 seconds and the only reason I haven't done it already is because you need to have admin access to the rep to do it.  Here's the super simple procedure:
https://greenkeeper.io/#getting-started
Here's an example of the sort of pull request it will open:
https://github.com/NICTA/nationalmap/pull/283

Sounds good, thanks for sharing.
@mramato do you want to look at this as part of the Node Guide?

I looked at this at one point and at the time we were doing a good job of upgrading our dependencies regularly. However, since that's not true lately, I'm willing to give it a shot.  Worst case we can disable it later on.
Silly question for @pjcozzi, but does this have CLA implications since a bot would be opening a PR?  I assume not since AGI is "in control" of the bot.

does this have CLA implications since a bot would be opening a PR?

No concern.

I looked at this at one point and at the time we were doing a good job of upgrading our dependencies regularly.

Well, that's not really the point of Greenkeeper anyway.  Staying up to date is easy in a sense.  Just use super-loose version specifications (such as *) and you'll always be up to date!
Where Greenkeeper shines is in detecting incompatibilities with new versions in a controlled fashion.  Let me tell you a story.
TerriaJS supports IE9, and we run the automated tests (stop laughing @pjcozzi, we have a decent test suite now!) on it on every commit using Sauce Labs.  Recently, the tests started failing on IE9.  But it wasn't just a normal failure, it was more like they wouldn't even start.  The weird thing is that when we built and ran the tests locally, they passed, even on IE9.  Many hours of debugging later, we finally figured out that socket.io, which is used by Karma, released a new minor version that accidentally broke compatibility with IE9.
So we spent several hours doing difficult debugging.  Here's what happened to a project that had the same problem but that was using Greenkeeper:
https://github.com/testem/testem/pull/907
Sweet!  That was the first time I heard of Greenkeeper, and it made me a believer.

does this have CLA implications since a bot would be opening a PR?

We had the same question, and even though it seemed a bit pedantic we decided to email the Greenkeeper folks.  Their response:

if an email is good enough for you, I can hereby verify that Greenkeeper PRs are in the LICENSE of the project, and whatever else your CLA needs ;)
If you need us to submit a CLA somewhere as the Greenkeeper Account, we can do that too :)

We decided that was good enough and didn't take them up on formally signing the CLA.

OK, I turned it on so we'll see how it goes.  We definitely can't merge it's "update all" PR because some of our packages need to stay on older versions, but I guess we'll get other packages one-at a time?

Edit the PR to revert packages that need to stay at their current versions, then merge it.  I'm not sure if it will be smart enough to open a failing PR for upgrading each of the remaining dependencies (that'd be nice), but it will definitely do that for future versions.  i.e. if you need to stay on version 1.0.2 because 1.0.3 introduced a bug, and then 1.0.4 comes out, Greenkeeper will automatically try it and let you know whether 1.0.4 is still broken or if it fixed the problem (assuming your tests fail when there's a problem, of course).

All dependencies that we can upgrade) have been updated to their latest version and Greenkeeper seems to be working as expected.


trezor-suite: 24.7.2 -> 24.8.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/trezor-suite/versions.
meta.description for trezor-suite is: Trezor Suite - Desktop App for managing crypto
meta.homepage for trezor-suite is: https://suite.trezor.io
meta.changelog for trezor-suite is: https://github.com/trezor/trezor-suite/releases/tag/v24.7.3
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 24.7.3 with grep in /nix/store/wsymlnmawfpb0l2yanxqphqpy72qh5nv-trezor-suite-24.7.3
found 24.7.3 in filename of file in /nix/store/wsymlnmawfpb0l2yanxqphqpy72qh5nv-trezor-suite-24.7.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

trezor-suite

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wsymlnmawfpb0l2yanxqphqpy72qh5nv-trezor-suite-24.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A trezor-suite https://github.com/r-ryantm/nixpkgs/archive/fa662baa126d37c8c87037459354be1053e2d4c4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fa662baa126d37c8c87037459354be1053e2d4c4#trezor-suite

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wsymlnmawfpb0l2yanxqphqpy72qh5nv-trezor-suite-24.7.3
ls -la /nix/store/wsymlnmawfpb0l2yanxqphqpy72qh5nv-trezor-suite-24.7.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

trezor-suite

Maintainer pings
cc @prusnak for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/trezor/trezor-suite/releases.
meta.description for trezor-suite is: Trezor Suite - Desktop App for managing crypto
meta.homepage for trezor-suite is: https://suite.trezor.io
meta.changelog for trezor-suite is: https://github.com/trezor/trezor-suite/releases/tag/v24.8.3
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 24.8.3 with grep in /nix/store/ka95np1yyz6zvq1nirlzvh04lalsw2xh-trezor-suite-24.8.3
found 24.8.3 in filename of file in /nix/store/ka95np1yyz6zvq1nirlzvh04lalsw2xh-trezor-suite-24.8.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

trezor-suite

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ka95np1yyz6zvq1nirlzvh04lalsw2xh-trezor-suite-24.8.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A trezor-suite https://github.com/r-ryantm/nixpkgs/archive/7b1c990c001548e70c1dee6b512aecb671f49a92.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7b1c990c001548e70c1dee6b512aecb671f49a92#trezor-suite

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ka95np1yyz6zvq1nirlzvh04lalsw2xh-trezor-suite-24.8.3
ls -la /nix/store/ka95np1yyz6zvq1nirlzvh04lalsw2xh-trezor-suite-24.8.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

trezor-suite

Maintainer pings
cc @prusnak for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


【Occasional problem】The image in version 1.13.1 cannot be opened after being uploaded, and the video also has the same problem

The image is a screenshot and then drag and upload

Do you need me to provide relevant log


Fix merge conflict

@cjgronlund : Thanks for your contribution to the Azure documentation! The author, @esung22, has been notified to review your proposed change.

@arkulkarni @nitinme
Fixes merge conflict and replaces original PR: https://github.com/MicrosoftDocs/azure-docs/pull/4692

#sign-off

@cjgronlund: Only the author, @esung22, can sign off on this pull request.

@PRMerger9 I'm the manager for this content set, so I understand that I'm able to sign off. @JennieHubbard @tysonn