IGNITE-20778: Provide internal API to get a list of parameters for non-executed query

Adds type inference for unspecified dynamic parameters via SqlValidator / TypeCoercion. Implementation is based on the following idea:

We can use type information provided to TypeCoercion to infer type of unspecified dynamic parameters. Example: for + operator when both sides are unspecified dynamic parameters - this is a type inference error, if one side is specified (and it does not matter whether it is a dynamic parameter or not, because the type is known), assume that another side has the same type.

cast operator accepts any value and relies on additional help at runtime - ExecutionContext::get(?x) should be modified to perform conversion at runtime.

Limitations

Passing type information to nested statements is not supported. E.g. Both SELECT 1 UNION SELECT ? and  INSERT INTO t VALUES (1), ((SELECT ?)), SELECT * FROM t WHERE col = SOME(SELECT ? ...) are rejected, since no type information is provided from the outer scope.

Functions require additional handling because of type families and due to the fact that type inference for some operators does not use type coercion (see COUNT).

COALESCE, NULLIF - due to rewrites into CASE expressions, errors for these operators are rather confusing.

What this PR covers

Should work for all statement types (queries, DML, etc).
Binary operators, binary comparison,  predicate operators (IS NULL, IS NOT NULL, etc).
CASE expression , NULLIF, COALESCE.
Functions: since function definitions in calcite are defined in terms of type families (and most of type families have more than one type) dynamic parameters with no value in function arguments require explicit casts. There are about 50+ functions and they require case by case review/fixes with possible changes of their definitions. This can be improved subsequent PRs.
Aggregates require extra handling to support correct error messages as well (see AVG vs MAX vs COUNT) - the first one uses type inference for builtin functions, the second one uses type coercion for binary operators, the third one uses neither.

Implementation details

Assumes that client code is going to use SqlValidator::getParameterRowType to retrieve parameter types.
All dynamic parameters types are inferred as nullable types.
This patch reveals a problem in type inference for IN operator (InferTypes::FIRST_KNOWN traverses into SqlNodeList which has no implementation).

Error reporting:
Unspecified parameters:
Adds error messages for type validation of unspecified dynamic parameters. E.g. SELECT ? + ? now returns Ambiguous operator <UNKNOWN> + <UNKNOWN>". Dynamic parameter requires adding explicit type cast.
Specified parameters:
This PR does not updates an error message for this case, and it remains the same (fixing it requires propagating derived operand types into TypeCoercion::coerceOperandType.
Other databases
It seems like both Cockroach and PostgreSQL are able to infer type in case of both SELECT 1 UNION SELECT ? and SELECT ? UNION SELECT 1 but both unable to do so for INSERT INTO t VALUES (1), ((SELECT ?)).
https://issues.apache.org/jira/browse/IGNITE-20778

Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist

[ ] Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[ ] Design: new code conforms with the design principles of the components it is added to.
[ ] Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
[ ] Code quality: code is clean and readable, necessary developer documentation is added if needed.
[ ] Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Apache Ignite Coding Guidelines

@korlov42 The number of validation parameters check should stay. Because some parameters may be left unspecified, and some are not.  e.g. for a query SELECT *, c = 1 +? FROM t = ?  it possible to specified value of the second parameter, but left the first one unspecified.


Cannot connect to keybase from ubuntu

My local machine (Ubuntu 16.04 64bit) has gpg properly installed with a private key. I have imported the public key to keybase (via the website).
I wanted to use the chat app and installed keybase on my machine. However, when I try to login it says:
"
Sorry!
You can't provision using a passphrase, since you've established a PGP key.
You have options: - Install GPG on this machine and import your PGP private key into it  ....."
"
My machine already has gpg with a private key in it. The corresponding public key is on keybase.
What needs to be done?
my log id: 8d9341693e26498880e0981c

Check that the secret key appears using both gpg --list-secret-keys and gpg2  --list-secret-keys. Keybase may be trying to locate the key in one of those versions.

gpg --list-secret-keys  shows that my secret key is there

Keybase uses gpg2 by default.  What does gpg2 --list-secret-keys show?
To change this setting:
keybase config set gpg /path/to/gpg/version1

Using gpg2 --list-secret-keys displays nothing (gpg2 exists but there are no keys)
I tried keybase config set gpg /usr/bin/gpg and then tried run_keybase again but I got the same issue as above.
I assume, that if it finds gpg properly is will not ask me for the passphrase, right?

Do keybase log send

After you've tried again

Ok, I got log id: 7cbc2da2cc217ddeb8fc691c
(and a new github issue url which I will not use...)

Sorry, my bad, I gave you the wrong setting. Do this:
keybase config set -c gpg
keybase config set gpg.command /usr/bin/gpg

OK, now it passed that stage. Then it asked me if I want to upload my key pair to keybase or use "one-time shell to gpg". I chose the later, entered a name for the device and got:
"Unknown error: GPG error: exit status 2"

Please another log send.

log id: b2ea3a1c1e0a09bd565bca1c

It seems like you don't have GPG pinentry installed.  Have you tried command-line installation?
keybase login

CC: @chrisnojima on this.  It might make sense to have the electron app recommend this fall-back.  If people don't have pinentry installed, right now CLI login is the best approach. It would be possible to build out a pinentry step here, but with a lot of effort, and it seems to affect very few people.

After I went through the process with keybase login everything went as expected.
Thanks

Glad it worked, and sorry for the hiccups.

tickted: https://keybase.atlassian.net/browse/DESKTOP-2875


prom-rule-ci: Relabel bind mounted test files

What this PR does / why we need it:
By relabeling bind mounted test files the Makefile target prom-rules-verify is able to be used with Podman.
Additionally all files are mounted read-only.
Release note:

None

/retest


Typescript Types

Awesome package!
Used it for some time, and figured I'd like some typescript types for it. It would be best if you could bundle some, but in the meantime I've added some as @types/stream-mock https://github.com/DefinitelyTyped/DefinitelyTyped/pull/34398 Hope you don't mind :)

Hey, nice job ! Actually I have in my roadmap to rewrite this module in ts. Thanks this will be very useful   in the meantime.

Available in release 2.0.2


[GHSA-f8vr-r385-rh5r] hyper and h2 vulnerable to denial of service

Updates

Affected products

Comments
This CVE was opened before engaging with the project’s SECURITY process. This is a breach of trust.

Hey @olix0r 👋
In this case github is not the assigning CNA. IN this case the CVE does seem to be about a valid issue and I'm following up over here https://github.com/github/advisory-database/pull/2057 with the project maintainer if you'd like to follow along.
Gonna close this PR out since it's a zero diff, but happy to follow up here if you've got questions/comments/whatevers


Chainlit UI Sidebar with selection list

I have question related to UI changes while running chainlit application only using python with command chainlit run app.py
I am implementing this functionality:
-> On starting the chat, user will first see the sidebar. And in this sidebar, there will be a selection list with options like 1, 2, 3, etc as shown below in the image.
-> Once user selects the particular option and hit the go button, the chosen option should be added to the prompt "Type your message ..." line.
-> I am trying with this example, but not sure if cl.Select is there in element or not.
https://docs.chainlit.io/chat-experience/elements#add-an-element-to-a-message

As of now, you can only use the Select widget in chat settings. To achieve the behavior you describe, you can either:

Use chat settings
Use AskActionMessage to make the user select options iteratively.


Parenthesis of generics ternary expression get dropped.

Bug Report
For more information, see the CONTRIBUTING guide.
Prerequisites

[x] Can you reproduce the problem in a MWE?
[x] Are you running the latest version?
[x] Did you perform a search in the issues?

Environment Details and Version
0.10.7
Description
Parenthesis get dropped in generics ternary expressions. Not sure if this actually changes the type, but at the very least it's more readable if the parenthesis stay.
Steps to Reproduce
export type Action<TType extends string, TPayload = undefined, TMeta = undefined>
    = TPayload extends undefined ? (TMeta extends undefined ? {
        type: TType;
    } : {
        type: TType;
        meta: TMeta;
    }) : (TPayload extends Error ? (TMeta extends undefined ? {
        type: TType;
        payload: TPayload;
        error: true;
    } : {
        type: TType;
        payload: TPayload;
        meta: TMeta;
        error: true;
    }) : (TMeta extends undefined ? {
        type: TType;
        payload: TPayload;
    } : {
        type: TType;
        payload: TPayload;
        meta: TMeta;
    }));

Expected behavior
Parenthesis stay
Actual behavior
Parenthesis are gone
Possible Origin / Solution
As part of the deox issues I'm tracking, this file shows the issue:
https://github.com/SantoJambit/shell-mwe/blob/master/src/deox.ts

This is not really a bug. The parenthesis are not necessary here.


Does this library relies on crontab?

I want to know whether this awosome library relies on crontab even on unix.

From the readme.md:
"Very lightweight and no external dependencies."'
(emphasis my own)
So, no, this does not rely on crontab


Failing to build

https://travis-ci.org/BuiltBrokenModding/ICBM/jobs/55907679 @DarkGuardsman

https://github.com/BuiltBrokenModding/VoltzEngine/commit/637ad756b07ad0704981b3ca0e2ee59f2d2ce4d9


pictures from deleted_pictures being displayed

Picframe is displaying pictures from the deleted pictures folder - is this considered normal?
I was expecting anything in the deleted_pictures folder to be excluded. Please let me know if there is anything I can provide to help debug.
Here's some settings in configuration.yaml
pic_dir: "/home/pi/pictures"
deleted_pictures: "/home/pi/pictures/deleted"
follow_links: False
subdirectory: ""

picframe version:  2021.09.22

Checking required packages......
PIL :  5.4.1
exifread :  2.3.2
pi3d :  2.47
yaml :  5.4.1
paho.mqtt :  1.5.1
iptcinfo3 :  2.1.4
numpy :  1.16.2
ninepatch : installed, but no version info

Checking optional packages......
pyheif : Not found!

Picframe builds a database by walking down the directory structure from pic_dir. deleted_pictures is a location expected to be outside pic_dir to move pictures to (rather than actually deleting them, like the wastebin folder of desktops). Obviously we could put some complicated filtering in but you would need to make a convincing case for using the setup you have.

Thanks @paddywwoof - there is no strong case here :)
This setup was done for convenience - it is equally easy for me to move the deleted_pictures location outside the pic_dir - will do that!
Thanks for your quick response and a wonderful product!


nailgun doesn't work on some installations

With version 0.4.4, on some installations, we find that nailgun doesn't seem
to work - but on others it does.
When it doesn't work, the symptoms are similar to issue #4 - a zero length PNG file is served up.   Sometimes, we also see an exception:
   throw err
   ^
Error: read ECONNRESET
   at exports._errnoException (util.js:1018:11)
   at TCP.onread (net.js:572:26)

Commenting out the call to plantuml.useNailgun(); solves the problem, but with the expected performance hit.
We can't find any obvious pattern about which platforms (including versions) it works on - and which it doesn't.  E.g., we've seen it both work and not work on different Windows platforms, and likewise on Ubuntu platforms.
I realise this doesn't give a lot to go on, but would it be possible to give me some pointers on debugging this issue further?

Same!
Comment it out works. No idea who to debug either. Frustrating!

Same thing here, and it's really slow without NailGun.

I've been working on an update to the node nailgun server with improved error handling that hopefully will be able to help finding the source of these kind of problems. I will integrate into node-plantuml in a near future.

I get ECONNRESET on Linux mint ith "openjdk 11.0.6 2020-01-14" and "Error: connect ECONNREFUSED <IP_ADDRESS>:9999" if I change the port from 0 to 9999.

Just for the heck of it I maid this https://github.com/agirorn/plantuml module that uses the latest plantuml.jar and does a very simpler exec to start it. When I then plugged that into my project it processed the PlantUML UML faster and with less CPU load in my project.
Also, I believe that after the plantuml.jar process has been started in -pipe mode, you can just feat it with UML one after the other and receive SVGs in the same order and just split them on the newline character or the XML header it starts with. Then where would only be one initial slow start.
Just something to think about if the nailgun continues to be a drag.

In case you are interested I've just released another solution for the problem called plantuml-pipe on NPM: https://www.npmjs.com/package/plantuml-pipe
You can use it to generate multiple diagrams with just one JAVA process without having to use a client/server technique. It simply wraps the PlantUML process that is running in pipe.
Many thanks to @agirorn for his help.

I've just released another solution for the problem called plantuml-pipe on NPM:

Nice! I just created two issues on your repo to make it a bit more solid. Also, I kind of remember running into a lot of memory leaks when I used PlantUML that way, a problem which didn't seem to affect plantuml-server. I'm curious as if those have been since solved or if you will run into the problem as well.
Me I'm taken the heavy artillery out: I'm running plantuml-server as a sidecar to my node process instead, through docker-compose.

Thank for your feedback.
I haven't run into memory leaks yet. During my tests it looked like that process uses a stable 20 - 40 MB of RAM. But I only tested it generating about 60 class diagrams from which most were small and only few of them bigger.

@krisztianb actually after reading your implementation I changed mine to also use pipes yesterday. You can see it [here]. From testing against my documentation pipeline, which has a lot of UML diagrams --some quite huge, I found:

The delimiter isn't always accompanied with a newline, so I don't use EOL to split anymore but just trim() the SVG instead.
-pipeNoStderr is required for errors to be emitted on stdout. I think your implementation ignores errors and treat them as successes, producing the SVG rendering of a PlantUML error instead.

For any serious use you really ought to raise PLANTUML_LIMIT_SIZE. The default value is ridiculously low.

@jcayzac many thanks for the reply and information.
For me the EOL has always been there so far. My module also supports binary output (PNG) and not just SVG. So a simple trim() won't do. I'll leave it as it is for the moment.
Regarding -pipeNoStderr you are right. Currently my module does not use this option. So errors are written to stderr and a "faulty" image containing a PlantUML error message is generated for the diagram. For some use cases I think this is not a bad solution. It might be worth adding an option for this though. I'll think about it.
Regarding the newline termination: Yes, it can be seen in the example on the module's README. But it sure can be a gotcha. The module is not going to do this for you. It can't, because it doesn't know when the input data ends. I think it is the job of the module's consumer to take care about this.
Regarding PLANTUML_LIMIT_SIZE: You are right. We already ran into this problem when generating PNG output. I think it does not really make sense to use a pixel graphic format for diagrams, but it might be necessary for devices that can't handle SVG. I'll think about adding an option for this too and also maybe for the max. heap size that you are setting to 4 GB in your code.
Thanks again for your time and giving valuable feedback. It's much appreciated. :+1:

@jcayzac I might just bumped into what you described as a memory leak. When generating the said about 60 diagrams all seems to go fine up until the very end when the memory usage of the JAVA process jumps from 40 MB up to about 200 MB within a couple of seconds before the process ends.
I would be interested if you see something similar on your side.

bq. I would be interested if you see something similar on your side.
No, I'm generating only about 50 diagrams at a time and it seems to hold steady for me.

Thanks for reporting back. I'm using V1.2020.15 (28 Jun, 2020). Will check if it depends on the version.

@jcayzac just to let you know. I generated the same diagrams using plantuml.1.2020.14.jar and see the same increase in memory usage. Not sure what to do next.


Back swipe gesture triggers longPress

Issue details
Android's gesture-based navigation interferes with GestureDetector. Swiping to go back triggers a longPress event after the longPress delay.
https://github.com/libgdx/libgdx/assets/13037299/08cb49ea-3f4d-4b65-9904-82e62cf0209d
Reproduction steps/code

Enable gesture based system navigation
Set libGDX to catch back key
Implement longPress in a GestureListener and set it as input processor

        Gdx.input.setCatchKey(Keys.BACK, true);
		Gdx.input.setInputProcessor(new GestureDetector(this));

Version of libGDX and/or relevant dependencies
Tried 1.11.0 and 1.12.0, both has this issue
Stacktrace
dalvik.system.VMStack.getThreadStackTrace(Native Method)
java.lang.Thread.getStackTrace(Thread.java:1841)
************.longPress(********)
com.badlogic.gdx.input.GestureDetector$1.run(GestureDetector.java:58)
com.badlogic.gdx.backends.android.AndroidGraphics.onDrawFrame(AndroidGraphics.java:498)
android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1573)
android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1272)

Please select the affected platforms

[x] Android
[ ] iOS
[ ] HTML/GWT
[ ] Windows
[ ] Linux
[ ] macOS

Can you please try 1.12.1-SNAPSHOT?

Can you please test https://github.com/libgdx/libgdx/pull/7265?

It works! Thank you!


Figure out how to build unit tests more quickly

Unit tests are taking a long time to build. I tried configuring cmake to use precompiled headers but couldn't figure it out. Any other ideas?

A worthy goal to make the unit testing faster.  You are certainly doing a great job of trying to modernize the testing and building process @michaeltryby I wish I had more knowledge of cmake

Here is a link to a discussion on the topic over at Stack Overflow.
https://stackoverflow.com/questions/7013121/compiling-boost-test-tests-faster


add some repo READMEs to telegraf docs

https://github.com/influxdata/telegraf/blob/master/docs/ has a lot of good detail that should probably be added to the docs site. We also should include a link back to that directory for any new, experimental, or fast-moving READMEs that we don't yet want to add to the docs site.

@jackzampolin @sparrc are any of those READMEs not appropriate for the docs site?

I would say the dependencies licence isn't docs appropriate, but the other 4 are links I regularly send to customers. 👍


Eliminate hard-timeout, zero packet-ins

This is to replace #485.
By replacing hard-timeout with idle-timeout, we can miminize packet-ins to zero and keep the network working for all active hosts without Faucet running.
It is configurable.

Travis log: https://travis-ci.org/trungdtbk/faucet/builds/253409130

Hi Chris,
I updated the PR. The idea is if the controller sees:

a flowremoved for a src rule, it just marks the host as expired
a flowremoved for a dst rule, if the host is marked as expired, no action. otherwise, we re-learn the host assuming it is active.
the controller is not actively sending flowmods to refresh host rules.
the worst case scenario when the src rule is lost, the host will only obsolete for a period of timeout.
dst rule could timeouts before src rule, the controller immediately reinstalls dst rule upon receiving flowremoved for dst rule. It is not bad since the host is not actively receiving anything.
I just think this is an option that user can activate for their use.

I like this implementation. It's ended up as something I think is pretty straightforward for anyone to understand.
I think it would be good to have a mechanism where the control plane cache checks it hasnt gotten out of sync with the data plane every so often. They definitely will get out of sync from time to time. I could imagine some weird behaviour creeping in around the edges of this implementation, but I cant come up with an example at the moment. Something like a conflict with some unusual combination of bad timing and some of the less likely configuration options..
I suggest that we bring this is still as non-default. I'll deploy it in the office and if it doesnt cause us any issues then we can try to move it to being the default down the line a bit.

Definitely worth further experimentation as non default - will you merge it?
On Mon, Jul 31, 2017 at 1:24 PM, KitL<EMAIL_ADDRESS>wrote:

I like this implementation. It's ended up as something I think is pretty
straightforward for anyone to understand.
I think it would be good to have a mechanism where the control plane cache
checks it hasnt gotten out of sync with the data plane every so often. They
definitely will get out of sync from time to time. I could imagine some
weird behaviour creeping in around the edges of this implementation, but I
cant come up with an example at the moment. Something like a conflict with
some unusual combination of bad timing and some of the less likely
configuration options..
I suggest that we bring this is still as non-default. I'll deploy it in
the office and if it doesnt cause us any issues then we can try to move it
to being the default down the line a bit.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/REANNZ/faucet/pull/763#issuecomment-318945376, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEgZ1zG-F5W0rx841vgQbMUwypsREZh0ks5sTSzWgaJpZM4OZcAU
.

Ok it's running in our office. If you could set the default to False and tidy up the new conflict I'll merge this.


Update binding generation

Summary

[x] Make std=c++11 optional.
[ ] Add type hints and more commentary.
[ ] Autoformat code.
[x] Update deprecated/soon-to-be-deprecated parts of code e.g. import imp
[x] Use logging
[x] Add extra sanity checks for file and folder existence.
[ ] Make some variable names more descriptive and/or more consistent with the style of the rest of the code.
[ ] Replace manual path manipulations with library functions from os.path.
[ ] Replace file open() and close() with with open(...) as ... : idiom.

The bindings seem to be having problems finding the constructors for MutableElement<1,2>, which is needed by ImmersedBoundaryElement<2,2>:
/usr/bin/ld:
CMakeFiles/_chaste_project_PyChaste_mesh.dir/dynamic/wrappers/mesh/MutableElement1_2.cppwg.cpp.o:
in function `MutableElement<1u, 2u>* pybind11::detail::initimpl::construct_or_initialize<MutableElement<1u, 2u>, unsigned int, 0>(unsigned int&&)':
~/PyChaste/dynamic/pybind11/include/pybind11/detail/init.h:76:
undefined reference to `MutableElement<1u, 2u>::MutableElement(unsigned int)'

/usr/bin/ld:
CMakeFiles/_chaste_project_PyChaste_mesh.dir/dynamic/wrappers/mesh/MutableElement1_2.cppwg.cpp.o:
in function `MutableElement1_2_Overloads::MutableElement(unsigned int)':
~/Chaste/projects/PyChaste/dynamic/wrappers/mesh/MutableElement1_2.cppwg.cpp:19:
undefined reference to `MutableElement<1u, 2u>::MutableElement(unsigned int)'

collect2: error: ld returned 1 exit status


Update google-protobuf to 3.15.8

google-protobuf diff: https://github.com/protocolbuffers/protobuf/compare/v3.14.0...v3.15.8
This updates google protobuf and updates tests that break with the update.
Only change seems to be to some parsing errors returning slightly different information.
I also update bundler to a more recent version. Since it is a dev only dependency I bundled it with this change.

Thanks! I'll take a look at this soon

LGTM. Thanks for the contribution!


Invalid Date for imported links

I have import several link from html.
In list they show "Invalid date"

Hello. Seems like your html file doesn't contain a date information. Can you tell me where you get your html file?

Safari export.El 14 ene 2023, a las 12:13, AlexSciFier @.***> escribió:
Hello. Seems like your html file doesn't contain a date information. Can you tell me where you get your html file?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Fixed in 1.2.6


Ability to keep some collections permanently pinned

User Exemptions now only enable you to never pin a collection. Please allow us to keep some collections permanently pinned.
I use kometa and tautulli to create the "Plex Popular" collection, this contains the most popular movies/shows on the server. I want to always show this collection on the home page.

Second this.  I love your program and want to continue using it but it keeps removing collections that i want displayed permanently.

This has now been resolved in the most recent release! Thank you for the feedback!


create volsync policyto backup PVs on hub

https://issues.redhat.com/browse/ACM-8622
Create a volsync policy to backup and restore PVC's on the hub cluster

thank you @mprahl it will be presented in the next playback meeting


cli: Allow specifying which test/file to be run

Currently all the tests are run on every invocation of anchor test.

Addressed by https://github.com/project-serum/anchor/pull/118.


How to use this lib with Laravel

Hi,
I'm developing a DNS Management app with Laravel. I'd like to use your lib in order to deal with DNS records. This will improve resource record validation and get a more ordered way to design my app structure.
But I don't know how to use your lib with Eloquent / Model model. I suppose I can extend Model with your Rdata models, but I don't know It's the best way.
For example: When an user submit a new record form, We don't know what Rdata to use... I suppose I can use a switch case for each one, Isn't it?
Thanks in advance.

Hi @pacoorozco
I'm not familiar with Laravel, as I primarily dealt with Symfony when I was a full-time developer.
If I were developing a Symfony app, I would be defining special form types for use with the form input. I'm not sure how that translates with Laravel.
In terms of model, maybe have a single class that represents all RData types and can internally switch between the required concrete classes and return populated RData classes.
I'm not sure of the best advice to give you. Maybe send some code to me so that I know the direction that you want to go.
Cheers,
Sam


Created page for building component

Created a page so user can select components for their PC
@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
3, because the PR involves multiple components with similar patterns of changes across CSS and React components. The repetitive nature of the code for handling state, effects, and rendering suggests a moderate level of complexity, primarily due to the volume of changes rather than the complexity of any single change.

 🧪 Relevant tests
No

 🔍 Possible issues

Repetitive Code: The PR introduces a lot of repetitive patterns, especially in the component files for fetching and displaying data. This could be refactored into a more generic component or hook to reduce duplication and improve maintainability.

Hardcoded API Endpoint: The API endpoint is hardcoded in multiple components. This could lead to difficulties in maintenance and potential errors if the endpoint changes or needs to be different in various environments.
 🔒 Security concerns
No

 Code feedback:
relevant fileclient/frontEnd/src/Components/Motherboard.jsx
suggestion

Consider creating a custom hook (e.g., useFetchProducts) to encapsulate the fetching logic and state management for products. This will reduce duplication across components like Motherboard, Cabinet, RAM, etc. [important]

relevant lineuseEffect(() => {
relevant fileclient/frontEnd/src/Components/Motherboard.jsx
suggestion

Move the API base URL (http://localhost:5000) to a configuration file or environment variable to make the application more flexible and secure. [important]

relevant lineconst response = await axios.get('http://localhost:5000/motherboard');
relevant fileclient/frontEnd/src/Styles/products.css
suggestion

Since many styles are repeated for different components (e.g., .mbcomp, .smps-comp, .ram-comp), consider using a common class for shared styles to reduce CSS duplication. [medium]

relevant line.mbcomp {
relevant fileclient/frontEnd/src/Components/Cabinet.jsx
suggestion

Implement error handling for the search functionality to provide feedback to the user when a search fails or no results are found. [medium]

relevant lineSearch

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.


Self-healing: SSD failure for deduped disk

Specs : https://github.com/zero-os/0-orchestrator/blob/master/specs/selfhealing/storage.md#deduped-disks

I'm moving this to state blocked since it's not implemented yet in 0-disk

blocked on https://github.com/zero-os/0-Disk/issues/301


process update commission

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#10  👈
#9
#8
#7
#5
#4
#3
#2
#1
#6
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @buffalojoec and the rest of your teammates on  Graphite


MCS code does not support stereochemistry

Thread here<EMAIL_ADDRESS>In [2]: mol1 = Chem.MolFromSmiles("Fc1ccc(cc1)[C@@]3(OCc2cc(C#N)ccc23)CCCN(C)C")
In [3]: mol2 = Chem.MolFromSmiles("Fc1ccc(cc1)[C@]3(OCc2cc(C#N)ccc23)CCCN(C)C")

In [4]: from rdkit.Chem import MCS

In [6]: MCS.FindMCS((mol1,mol2))
Out[6]: MCSResult(numAtoms=24, numBonds=26, smarts='[F]-[#6]:1:[#6]:[#6]:[#6](-[#6]-2(-[#6]-[#6]-[#6]-[#7](-[#6])-[#6])-[#8]-[#6]-[#6]:3:[#6]:[#6](:[#6]:[#6]:[#6]:3-2)-[#6]#[#7]):[#6]:[#6]:1', completed=1)

Is this still being worked on?

It's not actively being worked on

I wouldn't mind working on a PR if you could point me to the relevants parts of the code.

The MCS code is now in C++. If you're comfortable with that, the code is here:  https://github.com/rdkit/rdkit/tree/master/Code/GraphMol/FMCS
It may be possible using the existing chirality support in the substructure matcher, but it's almost certainly a non-trivial amount of work.

this was closed a long time ago by #466. Closing it


[Color Picker] paste color value into picker/editor, to convert

📝 Provide a description of the new feature
Right now I am working on some colors I am copying from a website. So far, so good. Now there is a color that is difficult to pick visually, but it is clearly defined in the html that I am viewing with the browser's Inspector tool. It is defined as HEX and I would like to have (=convert) this to RGB. Would be nice if I could copy the HEX value (from the Inspector) and paste it into the color picker or Editor as a new color. This would give me quick access to the other formats.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

That's neat idea! (cc @martinchrzan)

we can have some button "convert" button which would open list of enabled color formats with empty textboxes, which are not read-only, but you can write in any value and it will show it in all other formats

I was thinking that (the possibility of) inserting a value from the clipboard would be enough. After that, it would show up in the list on the left side, between the other colors. Converting would be done automatically, because the different formats are listed already and are ready to copy.

Maybe a SplitButton that allows you to pick a color, but has a dropdown icon next to it to enter a value there?

That might be complex however: because what input formats would we support? All of them? Sounds a bit like much.
Another option would be the following: make the TextBoxes non-readonly. Meaning, you could click on e.g. the HEX value and edit it (or paste something in). When the TextBox focus is lost, it will update all other values.

Hm, the last option would be the easiest, but also it is quite strange, that you will have to reuse some already picked color - if all colors in history are the ones I want to store, I would have to edit one of my colors and therefore destroy it, or I would have to pick a new color and then edit it (or even when you have nothing picked yet), so it feels quite junky.
The first option can be good - show small flyout with one textbox to enter value and combobox below to pick what format it is and it would add a new color as if you were picking. However discoverability can be hard with that.

Maybe a SplitButton that allows you to pick a color, but has a dropdown icon next to it to enter a value there?

A ~(Split?)~ Button followed by some kind of InputBox would be the simplest and most effective. A Normal CommandBar Button is fine though, because these two actions have equal "value". Possible bonus is a response from CTRL+V.

That might be complex however: because what input formats would we support? All of them? Sounds a bit like much.

Well, it would only be fair to accept all the formats that we can display. Question is - can we detect this programmatically (difficult, not impossible) or would we require manual selection? That would mean a list of Radio Buttons with [all or selected] formats. Manual selection sounds okay for a first go.

Another option would be the following: make the TextBoxes non-readonly. Meaning, you could click on e.g. the HEX value and edit it (or paste something in). When the TextBox focus is lost, it will update all other values.

I agree with Martin that editing an existing color might be do-able from a programming view, but is not user friendly in my opinion.

Not sure if I agree. It's a secondary feature, and it could be useful to make colorformats editable. When making a change, it would just add the color as a new one to the list?
This is basically the same thing:

Hm, I regard this as just another (different, but equally worth) method for retrieving a new color to work with. Guess we do disagree on that. May I also note that your example does not immediately save the new color for later use, and it also has a + button?
Anyway, would you be willing to try and use a CommandBar? It easily allows SecondaryCommands. Maybe there will be more buttons in the future, for example #7408...

Hm, I regard this as just another (different, but equally worth) method for retrieving a new color to work with. Guess we do disagree on that. May I also note that your example does not immediately save the new color for later use, and it also has a + button?
Anyway, would you be willing to try and use a CommandBar? It easily allows SecondaryCommands. Maybe there will be more buttons in the future, for example #7408...

WPF does not have something like a CommandBar, that's UWP. Maybe ModernWPF backported it.
My point is that having an additional button is one thing.. but you need an entire UI to let the user add the color. Where are we going to place that? Seems like a lot of work for a (minor) feature.
Actually, my idea is already possible today. You can click on the color, and change the value in the HEX or RGB fields. Clicking OK would then add it to the list.

Agree, if we only want to support editing RGB/HEX, we already have that functionality, anything else will require some more work and thinking.

@niels9001

WPF does not have something like a CommandBar, that's UWP. Maybe ModernWPF backported it.

Using <ui:CommandBar> will go a long way. Just like <ui:ListView> is already used in ColorEditorWindow.xaml. But that's for later, when everything will be re-written to be consistent.

Actually, my idea is already possible today. You can click on the color, and change the value in the HEX or RGB fields. Clicking OK would then add it to the list. I'd say that since is possible already (maybe from a UX perspective not super straightforward), it might be "good enough"?

Well, you got me there. That does work. "Discoverability" might be improved a bit. I'm thinking an "Edit" icon on the :hover state of the middle color area?

Good suggestion, let's track that in a separate issue. Can we close this one for now?

Good suggestion, let's track that in a separate issue. Can we close this one for now?

Alright then.

Alright. Moving to #9730.


Package request: scuttlebot

In a similar space as IPFS/Dat/BeakerBrowerser/etc: https://scuttlebot.io/
Looks like it's packaged via npm...

see #43661

It's pretty silly to leave both of these open. Can someone close one of them? The recommended process for adding node packages (detailed here) inevitably leads to a large merge conflict, since node2nix must be re-ran on the whole package set, which is presumably why my PR wasn't accepted.
There's absolutely no reason why scuttlebot can't be packaged, so it would be nice to see some progress on this. It would also be nice to know how we're supposed to package node packages, since following the recommended procedure clearly leads to a rejected PR.

Anybody out there?

Unfortunately I cannot help with packaging node packages (don't know anything about it). But I'll close this issue as requested. @patrl let's leave your PR open, hopefully someone else will be able to help.


Bug re: Python 3.9 and asyncio

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2662
Originally created by @aaronsteers on 2021-03-19 23:39:49

Although we don't support Python 3.9 yet, this still seemed worth logging because it may be directly actionable.
User Mindy reported in Slack an error after what otherwise looks like a successful run:
type object '_asyncio.Task' has no attribute 'all_tasks'

Googling surfaced this related diagnosis: https://github.com/jupyterhub/jupyterhub/issues/3297
With this (fairly portable) fix: https://github.com/jupyterhub/jupyterhub/pull/3298/files

View 5 previous comments from the original issue on GitLab


live <= master

Docs Build status updates of commit f755d62:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/index.html.yml
:white_check_mark:Succeeded
View

advocates/ismael-mejia.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/ismael-mejia.png
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix fabGenFeatures on Gradle daemon processes

The Gradle daemon runs in a separate directory, so relative java.io.Files do not point to the project directory. Instead, you must use project.file(...). It also might be because of Windows, but I didn't test beyond verifying that it works now.

This works fine on Linux, so yes, must be a Windows idiosyncrasy. Thanks, Microsoft.


rc-tree treenode with button for each node

Hi,
I have dynamically generated tree, I have to show button with each treenode.
Can you tell me to how to append button with tree nodes.
Thanks,
Dinesh

Do you want to replace icon to button? @Dineshtw

Hi ,
I need to append button's with each node title.see below is my treenode
title name.
[image: image.png]
Thanks,
Dinesh
On Sat, Mar 30, 2019 at 1:02 AM maximilianoforlenza <
<EMAIL_ADDRESS>wrote:

Do you want to replace icon to button? @Dineshtw
https://github.com/Dineshtw
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/storybooks/react-treebeard/issues/163#issuecomment-478122918,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AuO4nUbNq1ToLovw3QQ6O4o18hILYc_wks5vbmo6gaJpZM4cDEKH
.

--
Thanks & Regards
Dinesh Tawniya

I can't see the image @Dineshtw

@Dineshtw  how you can add children dynamically to node?
please help me :(


adds an alias to find a user by access key id

This alias takes an argument of an access key id and then
loops through all of the IAM users looking for a matching
key id.

@mbainter
Awesome. So before I merge the pull request, could you please confirm this contribution is under the terms of the MIT license.

I'm sorry for the delay, that time of year.  Yes, I am 100% fine with that.

Brought by branch up to date with master for a clean merge.

Thanks! Merging.


Improve text output for cref

XML snippet with cref:
      <t>
        Text before comment.
        <cref anchor="crefid">this is the comment.</cref>
        Text after comment.
        More text after comment.
      </t>

With the changes to fix #655, this generates following outputs:
Text output:
   Text before comment.
   // this is the comment.  Text after comment.  More text after
   comment.

HTML output:

(PDF output is similar to this)
When rending text output for cref, xml2rfc should include a new line to differentiate comments and text afterwards.

Cref, active

Xm12rfc


Add polarSSL

This PR builds polarssl v1.3.9
note: I know that polarSSL has been replaced by mbedTLS, but I still use polarSSL for some projects (mostly for the hashing and crypto implementations).

Cool, thanks!


Touch UI module -  make ComponentToolbar extensible

Refactor ComponentToolbar to allow plugging in new options easily

Will be included in new authoring API.


Switch to using SCPCP0001 id instead of pi_name

Context
We're currently using pi_name as a unique id, but a single PI could have more than one project.
Problem or idea
The science team is going to create a project accession code for us
Solution or next step
Switch the pk for projects to be the new accession code. (That will be in the URL as well.)

Closed by #66


Implement test case for kubectl/start.sh

Run testing on start.sh

This exposed a gap in start.sh where if no domain was specified the script would run from an incorrect directory. I've addressed this here:
# this will substitute the correct domain in ingress.yaml
if [ ${domain} ]; then
        substitute ingress DOMAINNAME ${domain}
        cd yaml/substitutions
        kubectl apply -f ingress.yaml.tmp
        rm ingress.yaml.tmp
        cd ..
fi

cd yaml
for yaml in *.yaml
do
        kubectl apply -f ${yaml}
done


Our CI infrastructure is unreliable -- let's move to cloud

In the case of a Jenkins instance being hosted locally on unreliable hardware, provide learning materials to help a team migrate their (probably somewhat customised) Jenkins instance into Azure.

This is well provided for by https://docs.microsoft.com/en-us/azure/jenkins/install-jenkins-solution-template


[Pagination] Page selector using ITEMS_PER_PAGE translation key

Detailed description

Is this issue related to a specific component?

Pagination

What did you expect to happen? What happened instead? What would you like to see changed?

I expected for the page selector <select> label to be something like "Page" or "Current page". Instead it has the "Items per page" label.

What browser are you working in?

Chrome 105

What version of the Carbon Design System are you using?

Latest
Additional information
As far as I can see this line https://github.com/IBM/carbon-components-angular/blob/9f232e50063a9ce431a3b96d64086859cb72f74f/src/pagination/pagination.component.ts#L115 could be changed to use pageText.subject instead of itemsPerPageText.subject.

Can I take this on?


API: Enable SwizzleArray input for LazyTensor

Fixes #457
Hi @willow-ahrens,
This PR implements LazyTensor(swizzle_arr::SwizzleArray) constructor and permutedims(arr::Tensor, perm) function.
I noticed that the recipe you provided in https://github.com/willow-ahrens/Finch.jl/issues/457#issuecomment-1985824854 is already implemented in permutedims(arg::LazyTensor{T, N}, perm), so I reused it.
Should struct LogicStyle be renamed to LazyStyle? Or it doesn't matter?

on LogicStyle: feel free to rename to LazyStyle, that struct is internal.

Renamed!
@willow-ahrens I see there's a failure in tests caused by: MethodError: no method matching combine_style(::Finch.MapRepExtrudeStyle, ::Finch.MapRepExtrudeStyle) when the test calls compute on a LazyTensor created from swizzle: https://github.com/willow-ahrens/Finch.jl/actions/runs/8233707802/job/22513767468?pr=462#step:7:490

Sure! With:
combine_style(a::MapRepExtrudeStyle, b::MapRepExtrudeStyle) = a

added, it complains about:
MethodError: no method matching map_rep_def(::Finch.MapRepExtrudeStyle, ::Finch.FilterOp{0.0}, ::Tuple{Finch.ExtrudeData, Finch.ExtrudeData})

I'll take a look!

this seems to pass tests, is that right?

this seems to pass tests, is that right?

Hmm, it looks that it fails with:
Got exception outside of a @test
  KeyError: key reorder(alias(A_2), field(i4), field(i5), field(i3)) not found

https://github.com/willow-ahrens/Finch.jl/actions/runs/8234220564/job/22515500670?pr=462#step:7:550

I see, the compute.jl function appears to have moved a reorder inside a produces statement. This is probably due to line https://github.com/willow-ahrens/Finch.jl/blob/426bf500c23792e70e3029d321ec247d075b93a9/src/interface/compute.jl#L100.
We need to be more careful about where we propagate reordering statements to so that we avoid produces statements. One kinda hacky fix would be to introduce a clean-up pass after that transformation:
@rule produces(~a1..., reorder(d, i...), ~a2...) => produces(a1..., c, a2...)

Another fix is to avoid modifying the produces statement altogether. (This isn't as easy as it should be, but one thought would be to put an IfElse in the rewriter to except produces statements from rewriting)

Check with https://github.com/willow-ahrens/RewriteTools.jl for some details on the rewriting

@willow-ahrens Do you mean adding a new rule in the chain that should remove reorders from produces statements?
Something like (this one fails the same a previous one):
function push_reorders(root, bindings)
    Rewrite(Fixpoint(Postwalk(Chain([
        (@rule plan(~a1..., query(~b, reorder(~c, ~i...)), ~a2...) => begin
            d = alias(gensym(:A))
            bindings[d] = c
            rw = Rewrite(Postwalk(@rule b => reorder(d, i...)))
            plan(a1..., query(d, c), map(rw, a2)...)
        end),
        (@rule produces(~a1..., reorder(~d, ~i...), ~a2...) => begin
            c = bindings[d]
            produces(a1..., c, a2...)
        end),
    ]))))(root)
end

Or writing a separate step, similar to push_reorders, e.g. cleanup_reorders?

I see. The point of this rule was to push reordering statements to later in the program so that we could analyze all the different reorderings that are required for any given statement. i.e. if we do
B = permutedims(A, 2, 1)
C = A[i, j] + B[j, i]

Then we have
B = reorder(relabel(A, :i, :j), :j, :i)
C = mapjoin(A, reorder(relabel(B, :i, :j), :j, :i))

and pushing the reorderings down the program gives us:
D = A
C = mapjoin(A, reorder(relabel(reorder(relabel(D, :i, :j), :j, :i), :i, :j), :j, :i))

gives us
D = A
C = mapjoin(A, D)

So the error here is that one of those reorders is showing up in a produces statement.

There's a rewriting pass called concordize which is supposed to find all reorders of a tensor and produce permutation queries for them. the relevant rewrite is here:
https://github.com/willow-ahrens/Finch.jl/blob/426bf500c23792e70e3029d321ec247d075b93a9/src/interface/compute.jl#L151
You may want to double check whether this is removing the reorder from the produces statement.


Add retailers,publishers admin apage and their analytics

Hey, Can I work on this issue?

Yes
On Mon, 22 Mar 2021, 19:36 Meghana Varanasi, @.***>
wrote:

Hey, Can I work on this issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vikasdo/Book-Recommendation-Analysis/issues/8#issuecomment-804089554,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKT3M7HEJLAXGWQNS74Y46TTE5FHDANCNFSM4YA22V6Q
.

Thanks for assigning it to me! Could you describe the issue in more detail?

Make a view  so that while login make login as retailer and show their
dashboard
For retailer: show their published books
For authors: show their book written
And add metrics which can be added for those role
On Thu, 25 Mar 2021, 18:36 Meghana Varanasi, @.***>
wrote:

Thanks for assigning it to me! Could you describe the issue in more detail?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vikasdo/Book-Recommendation-Analysis/issues/8#issuecomment-806707133,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKT3M7GYHOFT5DP6BMNKIOLTFMYLVANCNFSM4YA22V6Q
.

okay, sure! Is there a UI design I need to follow?

Similar to admin or your choice
On Fri, 26 Mar 2021, 22:53 Meghana Varanasi, @.***>
wrote:

okay, sure! Is there a UI design I need to follow?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/vikasdo/Book-Recommendation-Analysis/issues/8#issuecomment-808392339,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKT3M7DKZCPFRKGG6VP3VUDTFS7HRANCNFSM4YA22V6Q
.

okay

Make a view so that while login make login as retailer and show their dashboard For retailer: show their published books For authors: show their book written And add metrics which can be added for those role
…
On Thu, 25 Mar 2021, 18:36 Meghana Varanasi, @.***> wrote: Thanks for assigning it to me! Could you describe the issue in more detail? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT3M7GYHOFT5DP6BMNKIOLTFMYLVANCNFSM4YA22V6Q .

So should I add a dropdown or something at the register page too?

Make a view so that while login make login as retailer and show their dashboard For retailer: show their published books For authors: show their book written And add metrics which can be added for those role
…
On Thu, 25 Mar 2021, 18:36 Meghana Varanasi, @.***> wrote: Thanks for assigning it to me! Could you describe the issue in more detail? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT3M7GYHOFT5DP6BMNKIOLTFMYLVANCNFSM4YA22V6Q .

So should I add a dropdown or something at the register page too? And is there API documentation that I can refer to? And I'm working on macOS, will that be a problem?

if you are working on macOS, the main issue will be with regards to CSS, the attributes for safari and chrome are a bit different, even if you are using chrome make sure that non-safari attributes of CSS are also present, and nothing much :)

Make a view so that while login make login as retailer and show their dashboard For retailer: show their published books For authors: show their book written And add metrics which can be added for those role
…
On Thu, 25 Mar 2021, 18:36 Meghana Varanasi, @.***> wrote: Thanks for assigning it to me! Could you describe the issue in more detail? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT3M7GYHOFT5DP6BMNKIOLTFMYLVANCNFSM4YA22V6Q .

So should I add a dropdown or something at the register page too? And is there API documentation that I can refer to? And I'm working on macOS, will that be a problem?

there is no API or anything like that, while registering you can ask whether he is an author or retailer, just like how AWS asks whether you want to login as a root user or IAM user. Hope you get it, and based on login the retailer will be taken to his respective dashboard and the author will be taken to his respective dashboard.

@Akshay6890 Oh, Okay! Thank you, I'll work on it.

@Meghana-12  what's the update

@Akshay6890 Oh, Okay! Thank you, I'll work on it.

Are you still working on this?

Hey, sorry about the late reply, I had my exams so couldn't work on it.

I'm still busy with my projects. If there is someone else interested in working on this, please assign it to them. Sorry for the inconvenience.

please assign me this issue @Akshay6890 I will work on this and give good results

sure

Admin page has been already done.


Upgrade to Rails 5.0

This was mentioned by @boffbowsh during our meeting today.
See https://docs.publishing.service.gov.uk/manual/upgrade-rails.html

A number of other GOV.UK apps have recently been upgraded to Rails v5. It might be worth looking at the relevant PRs to avoid reinventing the wheel, e.g. https://github.com/alphagov/hmrc-manuals-api/pull/174.

Also see https://github.com/alphagov/router-api/pull/106.


Can't find app in menus after installing deb package

What version of electron-installer-debian are you using?
0.6.0
What version of node and npm are you using?
3.10.10
What operating system are you using?
Linux mint
Can you compile the example app successfully?
I can create packages and install the app. And after the app is installed i can find it in the menus.
If not, paste here the output of the following commands:
$ git clone https://github.com/unindented/electron-installer-debian.git
$ cd electron-installer-debian/example
$ DEBUG='electron-installer-debian' npm run build

What did you do? Please include the configuration you are using for electron-installer-debian.
I ran this after packaging the app into the release-builds folder
electron-installer-debian --src release-builds/Electron\ tutorial\ app-linux-x64/ --arch amd64 --config debian.json
my debian.json looks like this:
{
  "dest": "release-builds/installers/",
  "icon": "assets/icons/png/1024x1024.png",
  "bin": "",
  "categories": [
    "Utility"
  ],
  "lintianOverrides": [
    "changelog-file-missing-in-native-package"
  ]
}

What did you expect to happen?
That i could start the app from the menus after installation.
What actually happened?
I'm trying to build a debian package for this application:
https://github.com/crilleengvall/electron-tutorial-app
and write a tutorial about it. The debian package is created and i can install it.
But no app can be found in the menus. But i can start it from:
/usr/lib/electron-tutorial-app by running ./electron-tutorial-app
I have tried the suggestions in this issue but i can't seem to get it to work
https://github.com/unindented/electron-installer-debian/issues/19
The .desktop-file that is generated looks like this:
[Desktop Entry]
Name=Electron tutorial app
Comment=Application for electron tutorials
GenericName=Electron tutorial app
Exec=electron-tutorial-app %U
Icon=electron-tutorial-app
Type=Application
StartupNotify=true
Categories=Utility;

This is not a bug but mainly a problem with your configuration. This question should be asked in the community forums and not filed as an issue. Nonetheless, here's my answer.
First, electron-packager uses the productName first when you don't specify appname to the cli, as it's stated here

If appname is omitted, this will use the name specified by "productName" or "name" in the nearest package.json

So you will have a conflict when creating a link to the executable.
The second problem, is that your debian.json bin is blank, this should point to the executable created by electron-packager.
The proper way to fix this is passing appname to electron-packager and making appname be exactly what the name field in your package.json is, and removing the bin option from your debian.json.
An alternative, that it's not recommended since doesn't follow proper Debian naming guides, is to not pass appname (as you've been doing so far) and set the bin option in debian.json to Electron tutorial app (your productName). If you would have checked what electron-packager was creating, you would have seen that your executable name is Electron tutorial app (which doesn't follow proper Debian naming guideliness).

Thank you @fcastilloec for the help. That solved it!
I wasn't aware that i should post this in the electron forum, i will do that from now on.

@fcastilloec we should add a SUPPORT.md like electron-installer-snap.

Thank you @fcastilloec. You answered this no commented problem in almost every tutorial that i read.


vm restore fixes + add snapshots and restore to kubevirt upgrade test

What this PR does / why we need it:
This point of this PR was to add vmsnapshots and restore to upgrade test to try and catch upgrade failures with snapshots.
During the work on the test found a bug in the restore process which fails if the vm had RunStrategy and not Running field (they are mutually exclusive) and some other small fixes.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

fix restore of VM with RunStrategy

/retest

/test pull-kubevirt-check-tests-for-flakes

@dhiller federico told me to ask you to override the tests-for-flakes lane. It keeps failing on timeout - reaching 7 hours. It runs 50 tests amongst them the Operator tests which as I understand its a familiar problem of timeouts in this lane.

/test pull-kubevirt-e2e-k8s-1.21-sig-storage

/lgtm

/test pull-kubevirt-build

/test pull-kubevirt-e2e-k8s-1.22-sig-compute

/retest
/test pull-kubevirt-e2e-k8s-1.20-operator
/test pull-kubevirt-e2e-k8s-1.20-operator-nonroot
/test pull-kubevirt-e2e-k8s-1.22-operator


Support aimsgb

For the GB structures creation routine, we need to add aimsgb.
https://aimsgb-docs.readthedocs.io/en/latest/

@aazocar Added a new option backend='aimsgb' in the GB creation routines. By default AIMSGB is used.


The section for selecting files and folders crashes

Type: Bug
When I switch to global search mode or another mode, the file and folder selection section disappears. It interferes with the work very much.
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:49:37.021Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3570 CPU @ 3.40GHz (4 x 3392)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.95GB (6.63GB free)

Process Argv
--crash-reporter-id 50fa4bd1-f712-47c8-83b0-25bbbd108de8

Screen Reader
no

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

vscode-intelephense-client
bme
1.10.2

path-intellisense
chr
2.8.5

dscodegpt
Dan
3.0.21

composer-php-vscode
DEV
1.42.14626

intelli-php-vscode
DEV
0.12.14619

phptools-vscode
DEV
1.42.14626

profiler-php-vscode
DEV
1.42.14626

gitlens
eam
14.6.1

vscode-html-css
ecm
2.0.6

prettier-vscode
esb
10.1.0

figma-vscode-extension
fig
0.3.1

file-icons
fil
1.1.0

auto-rename-tag
for
0.1.10

vscode-apache
mrm
1.2.0

vscode-language-pack-ru
MS-
1.85.2023121309

python
ms-
2023.22.1

vscode-pylance
ms-
2023.12.1

jupyter
ms-
2023.11.1003402403

powershell
ms-
2023.8.0

vscode-css-peek
pra
4.4.1

vscode-icons
vsc
12.6.0

php-debug
xde
1.34.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vshan820:30294714
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
py29gd2263:30899288
vsclangdf:30486550
c4g48928:30535728
azure-dev_surveyone:30548225
89544117:30613380
pythongtdpath:30769146
i26e3531:30792625
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30928863
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:30885898
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
aa_t_chat:30882232
cp7184t3:30927821

Have you tried clicking on the top left corner's icon (on the activity bar https://code.visualstudio.com/api/ux-guidelines/activity-bar) to restore the file explorer?

I was looking for something to click on to return the tab with a selection of files and folders. I'm attaching a screenshot. But I didn't find anything. It looks like it's a bug.

Try running Reset View Locations

It doesn't help. This appeared after the update

Right click the explorer when it is visible and check the box in the context menu.
If you still have issues please include a recording of you doing this as well as reset view locations so I can ensure you're completing the steps properly

Yes, thanks, it helped! :)


Enhancement for plain text and html templates

NOT AN ISSUE
Hi Alejandro,
do you think it would make sense to add templating for plain text and html mails at the same time?
I found an issue about using a Zend\Mime'Message in the setBody() method of the MailService, which apparently does not exist anymore in the current version. It looks like the MailService API would force the user to create the whole Mail class from scratch.
Since the Mail would have to have a "multipart/alternate" between plaintext and html and an additional "multipart/mixed" if attachments are needed, this could be handled by your module with a few more lines of code. Templating would then just require one more config template_plaintext to provide this functionality and a little adjustment in the EmailBuilder I guess.
What do you think?
Best regards
Jakob
btw: Best module regarding ease of use, besides the plaintext/html issue this is the most convenient way of composing mails in Zend. Thanks for that!

I suppose it could make sense.
Would you be willing to contribute this improvement? Or at least some tests reproducing the issue.

I'm using the module just now, if I can spare out the time, I'll try to create a PR soon. Otherwise I'll let you know, so you can close the issue.

Oh, don't worry. If you can do it, that's great, but if not, I'll definitely try to investigate the issue myself. I don't mean to just close it :)
I asked you to do it because I'm currently focused in other things and it will probably take me a few weeks at least to have the time to approach this.

I see. I'll stay in touch. Thanks


Add Java Goof to Cloud One Application Security's projects list

Awesome! And thank you for the '.' :-)


chore: fix clippy for version 0.1.81

This change is

This PR is a replica of #2371, except for one difference. This PR includes a disable of one part of the CI.


[Community] Maturity Model Risk Assessment tool

Contribution Description
Create a tool that enables organizations to assess platform maturity based on the existing Platform Maturity Model. The tool will help organizations measure their relative risk as it relates to their platform initiative, with the aim to provide repeatable and prescriptive guidance to mature. The tool will be loosely modeled after the AWS Well Architected Framework, a survey based format, allowing for self-guided or consultative engagement.
Related Working Group (WG)
Platforms
Contribution type
Other
Why TAG App Delivery?
This fits in the TAG because it will enable organizations to measure maturity and improve App Delivery capabilities leveraging a Platform Engineering-based approach.
Related projects/technologies
This project will also align to some of the work we are doing with the CNOE open source initiative. https://cnoe.io/
Affiliation disclosure
No response
Additional collaborators
@abangser
@nimakaviani
@jessesanford
@vsethi
Additional information
No response

Thanks so much for opening this @corbinpa! It was great to speak with you and the other collaborators in Paris about the ideas here.
I imagine this type of publication will take on a similar lifecycle to the maturity model itself in that it will start with a skeleton and grow through dedicated working sessions both async and sync calls.
Since we are still early days with all this so some things we still want to determine from the group are:

Hopes / goals for this type of publication
Fears / concerns for this type of publication
Formats / examples of other publications that people see achieve similar outcomes
Indication of interest to collaborate

Looking forward to working with you on this!

I find this really interesting! I hope I understand this correctly but this reminds me of the FinOps model (that I have mentioned numerous times on the Slack channel because I really like how well-designed their framework is!) that they mention the Capabilities mapped to each of the Maturity stage in which that people can take their Assessment tool to know the Maturity level of their org/team in each according Capability. So does the DORA quickcheck. Let me know if I can be of any help on this one!

We are currently looking for the first round of feedback to the tool, which focuses primarily on the format. Please review and add comments directly to the shared document that is posted here:
https://docs.google.com/document/d/1PDGq3lAuqNVEWi_BSZcf9fZp6TIeWEUXqoDGmgNCWGE/edit#heading=h.kt3w0dglyxwn

This is being discussed on the 6/11/24 Platforms WG meeting at the :45 mark (need to find recording)

Thanks @corbinpa for sharing, this is an interesting topic.
I've a question about the term Risk.
In my experience when I do an assessment about risks I'm used to add also probability, impacts and mitigation actions. In that case the risk is "just" one: the failure of the Platform Engineering initiative.
What do you think to change the name Risk in Fitness Assessment? Something similar to Fitness functions in software dev?  https://www.thoughtworks.com/insights/articles/fitness-function-driven-development

@giulioroggero thanks for the feedback!  I agree the term risk may not be the correct one, but haven't landed on an alternative yet. I'm not sure that the outcome is simply failure of the plaform initiative, rather maybe has some of the other characteristics you described (probability, impact and mitigation). In my sampling so far, what I have noticed is that the characterization as a risk to the initiative so far seems to inspire some level of action. While it is useful to know where you are from a maturity perspective, the more interesting bit is about where you are going (chart course/journey). The tool should help you think about what workstreams are needed to mature. As an example, an organization has a platform initiative without a product manager (and therefore no product orientation). This may be viewed as a risk to the initiative and depending on the needs or business priorities of the organization, an area where they may need to prioritize more investment. In that case, they may need to know the benefits of the product manager (justification), common responsibilities, necessary skills, etc.

Update on progress. Had a deep dive call with recording here which also led to this doc focusing on the target audience and outcomes.
Please review and leave commentary on the doc where relevant and/or here for more general ideas!

Sorry for radio silence here! Next up is a deep dive call on Tuesday Oct 1st about a potential move towards multiple choice questions. The meeting will be on the "old" zoom: https://zoom.us/j/7276783015?pwd=R0RJMkRzQ1ZjcmE0WERGcTJTOEVyUT09 and you can reach out here or on #wg-platforms on the CNCF slack if you have any questions about it.
We will be reviewing the following doc: https://docs.google.com/document/d/1Y6BxS0rLHK5nMOeaBqoqfTEuHYtSywY2dPvo7oTdo9Q/edit


Changes from abnTeX2

Hello there,
Which were the modifications in relation to the original version from abnTeX2, despite the language?

The idea is to use the rules from FGV. This project is not completed yet, but it will be soon (and I accept contributors!)
Things that already changed from the file "abntex2-modelo-trabalho-academico.pdf"

Cover and cover sheet;
Catalog card (library);
Dedication.

The suggested structure may also help others. After finishing everything, it may be a good start for every EMAp student.


minor version updates

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (039865a) 52.00% compared to head (13259ab) 52.00%.

:exclamation: Current head 13259ab differs from pull request most recent head 160ed77. Consider uploading reports for the commit 160ed77 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1662   +/-   ##
=======================================
  Coverage   52.00%   52.00%
=======================================
  Files          42       42
  Lines        4911     4911
=======================================
  Hits         2554     2554
  Misses       2208     2208
  Partials      149      149

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


player is imune

when i try to troll anyone it tells me they are immune but when i remove the immune node from them they are still immune!!! please help!

Give the latest alpha a try if you haven't yet. The stable version should have permissions working correctly (tested with LuckPerms) and the latest alpha should also be working (although untested, the same code runs other plugins that I create and those work fine)


Can't see right navigation arrow within a zoomed page (transform: scale(1+))

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.4.5

Platform/Target and Browser Versions: Windows 10, Chrome v83

Stackblitz issue : https://stackblitz.com/edit/swiper-demo-31-thumbs-gallery-with-loop-mode-1pwq9m

What you did
I am using swiper v 5.4.5 and found a bug, when I zoom a page with e.g. transform: scale(1.5) then I cant see the right arrow, it is possible to click on that area where it should be, but it is not visible. Please see Stackblitz example with the official example of gallery, I have just added scaling there with style="transform: scale(1.5); width: 260px;":
Expected Behavior
with navigation allowed, both arrows should be visible
Actual Behavior
right navigation arrow is hidden due to swipe overflow when transform: scale is more then 1

Add to CSS
.swiper-button-next {
  transform: translate3d(0,0,0)
}


fixed: regressions with Grid theme print style + refactoring

Hi @theywa,
Since this is still fresh, I was hoping you could do a sanity check on this PR.
I'm going to put comments inline.

I'll have to merge this as a dictator, because of the bugs it resolves that are currently in master. However, @theywa, your feedback on this PR is still welcome.