Update policies.tf to add glue crawler permissions

A reference to the issue / Description of it
Using a glue crawler inconsistent struct schemas in Athena
How does this PR fix the problem?
Adds permissions to create a Glue crawler
How has this been tested?
Tested using a Glue crawler in sandbox, but haven't tested how the impact of these permissons...
Deployment Plan / Instructions
Will this deployment impact the platform and / or services on it?
Will add permissions to users
Checklist (check x in [ ] of list items)

[x] I have performed a self-review of my own code
[ ] All checks have passed
[ ] I have made corresponding changes to the documentation
[ ] Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)
{Please write here}

Hi @guyvw1 - can you comment here whether this PR can be closed. Thanks.


Folder resolve conflict option

As per the resolve conflict option i can only rename or fail or replace the files at a location.
What if i want to resolve the conflict if there is a duplicate folder.
This https://docs.microsoft.com/en-us/graph/api/driveitem-createuploadsession?view=graph-rest-1.0#request-body
Explain to solve the file conflict.

@ravi100k to clarify this is asking about creating a folder ?
the conflict resolution is only for resolving file names

@k-tsoi The use case is if we try to upload the file at some location for which we have a folder conflict as well.
In that the one drive is putting the file at the same location, it should also create a new folder if the folder already exist in one-drive.

@ravi100k This would be a feature request, please log your request at User Voice. https://microsoftgraph.uservoice.com/forums/920506-microsoft-graph-feature-requests?category_id=359590
The conflict resolution is only on file name.


#46035 make setWinners consider kill order

When multiple players get killed from one same action (ie playing Indians or Gatling), the kill order should matter to determine the winner.
I've made the game end immediately when the sheriff is killed so that if there are renegades or outlaws still alive, they win, even if they will get killed later.
This should fix 61477 too.

After reading the official rules, the official tournament rules and this official answer from dvGiochi, we agree that kill order does NOT matter and so this pull request is closed.
In the case described in #46035 outlaws should win, this will be addressed in a specific commit.


add wlp annotation if necessary for 2.2

The related issue: https://issues.redhat.com/browse/ACM-6807

/hold Hold until the 2.2 branch is open for business.

/test e2e

Make sure merge https://github.com/stolostron/managedcluster-import-controller/pull/268 first.

/lgtm
/approve

/lgtm
/approve

/lgtm

/unhold


feature/set-default-method

This PR adds a set_default method to the Globals class. This method sets a default value for an attribute only if it doesn't already exist, preserving any existing value.
Key Changes:

New method: set_default(name: str, value: Any) -> None
Adds flexibility by allowing default value assignment without overwriting existing data.
Includes unit tests for the new functionality.

Usage Example:
g.set_default('default_key1', 'default_value1')
# Or
app = FastAPI()
app.add_middleware(
    GlobalsMiddleware,
    g_default_values={"default_key1": "default_value1"},
)

Hey @heysaeid , thanks a lot for the PR!
My initial purpose for this small module was to mimic the flask g object functionality and I am trying to stick with it, so that potential users find it usable when they transition to fastapi.
In that sense, I 'm afraid that I cannot include that logic that this PR is adding as it violates some core principle:

Idea is that the g object is effectively cleared between requests, keeping no state whatsoever, just like the equivalent object in flask.
Flask's g object has an equivalent setdefault method indeed, but it is just a way of initializing a variable value and nothing more. I found it too dummy to transfer into this module, but I can incorporate it easily if needed.
In any case, in flask, if an attribute is not set, or setdefault in a given request lifecycle, then the access of it raises an exception. There is no such thing as default values in between requests.
In this PR however, the default values introduced in middleware level are expected to live on indefinetely and are not cleared in each request-response lifecycle. One can easily use the app config for such purposes or even straight global variables indifferent of the fastapi app instance.

Hey @chrisK824, thank you for your response.
I completely understand that you want to keep it as simple as possible. You mentioned using config or a global variable for default values, which is absolutely correct. However, don't forget that these are global, and if their values are changed, subsequent requests might encounter issues.
It is true that users can set default values for g if needed, but my goal was to simplify this process.
After a thorough review of the source, I discovered a major issue that causes a race condition - https://github.com/chrisK824/fastapi-g-context/issues/2


Add id to cloned item

Is there any way to put an id to an item when you use the option "helper : 'clone'"?

@Davids89: Yeah, if helper:clone option is set on jqyoui-options, onStart event will give you access to ui.helper - refers to an element being dragged. Use Javascript to add an attribute to it.


Update ArrayReversal.c

Done, pls merge it #291  @abhinavcodedeveloper @ela2003 @divya520357 @Vaibhavgupta05

hey, please share the ss of the output here.


[ListItem] Simplify the ListItem interface when href is provided

In this commit, we are implementing the change suggested in #12941.
This is a sugar syntax when the user provides the href prop, so they don't need to also provide button=true and component="a".
Before this change:
<ListItem href="#" button component="a" />

After this change:
<ListItem href="#" />

I'm not totally convinced this is a valuable change because it makes the behavior of the ListItem less predictable, but I agree that it helps simplify the production code.

[x] I have followed (at least) the PR section of the contributing guide.

#13069

We still don't know if we want to accept such change. There is some concerns internally around the win vs the overhead for everybody.

I might as well put those into writing:
Overall it looks very handy to just use href because using this property implies that one uses the a component and button prop.
My issue is that I rather define those explicit because before default values where always the same. With this change default values depend on other props and with time I fear that it becomes hard to reason about what the default values for a given component are. This PR also adds no documentation about this.
What if we introduce another prop that changes the default value again? Do we have to add validation so that users don't pass impossible combinations?
If users forget to add component="a" then they will already get a warning because we would spread the href prop to a dom element that does not accept this property.
Compare the amount of code paths we add to a simple convenience wrapper:
const ListItemLink = props => <ListItem button component="a" {...props} />
ListItemLink.propTypes = {
   href: PropTypes.string.isRequired
}

Maybe I'm being overly paranoid. Are there other dom attributes that are exclusive to certain native elements?


Add tests for non-square matrix

I mentored a solution which relied on the matrixes to be size 3x3 or 2x2. While this doesn't test matrixes of all sizes, it adds tests for a non-square matrix of size 2x3
Related solution:
https://exercism.io/mentor/solutions/c06d5e96459b407495564e6de2fbf6ec

Do you think this should be elevated to canonical at some point?

mm, probably? I can see this being relevant to all tracks, but to be honest
I'm not sure what the process is for adding new specifications.
Are all parts of the specifications shared between tracks? Can the specification be changed before the tests (for each track) are added?

mm, probably? I can see this being relevant to all tracks, but to be honest
I'm not sure what the process is for adding new specifications.

To introduce the change we would open an issue on problem-specifications to talk about it, and once discussed, open a PR there that makes the change.

Are all parts of the specifications shared between tracks? Can the specification be changed before the tests (for each track) are added?

The specifications are specifically to share between the tracks, and some tracks remove things that may not be applicable to their tracks, and like is done here, some tracks add some things that may be relevant to that specific track.

To go a bit further, this track, has test generators that exist, that when set up, can use the specification data to generate the tests that we use.  Look at generated test suites which will get you started on what is used to generate the test, and looking at implmementing a generator for information on how to do this.

Thanks @kotp I'll take a look at those 👍


resource bundle for junit test error strings

Codecov Report

Merging #698 into dev will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #698      +/-   ##
============================================
+ Coverage     48.08%   48.09%   +<.01%
+ Complexity     2586     2585       -1
============================================
  Files           114      114
  Lines         26578    26578
  Branches       4453     4453
============================================
+ Hits          12781    12783       +2
+ Misses        11664    11653      -11
- Partials       2133     2142       +9

Flag
Coverage Δ
Complexity Δ

#JDBC42
47.98% <ø> (+0.02%)
2577 <ø> (-4)
:arrow_down:

#JDBC43
47.98% <ø> (-0.03%)
2578 <ø> (-4)

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
43.84% <0%> (-1.57%)
107% <0%> (-1%)

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
33.21% <0%> (-0.4%)
245% <0%> (-3%)

...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java
63.29% <0%> (-0.12%)
0% <0%> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
52.61% <0%> (+0.06%)
240% <0%> (+1%)
:arrow_up:

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
50.68% <0%> (+0.24%)
157% <0%> (ø)
:arrow_down:

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
55% <0%> (+0.26%)
0% <0%> (ø)
:arrow_down:

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
61.57% <0%> (+0.65%)
89% <0%> (+1%)
:arrow_up:

...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
62.76% <0%> (+0.83%)
63% <0%> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
47.19% <0%> (+2.24%)
17% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf4afb...8e5ae2b. Read the comment docs.


Add FOSSA badge for licensing

FEATURE REQUEST

Is there an open issue addressing this request? If it does, please add a "+1" reaction to the
existing issue, otherwise proceed to step 2.

Describe the feature you are requesting, as well as the possible use case(s) for it.

It would be good if License section in README.md could have a FOSSA badge, similar to goswagger.
This would allow us to understand on a glance number of dependencies and their licensing (example).

Indicate the importance of this feature to you (must-have, should-have, nice-to-have).

Nice-to-have

@drasko What's the status of this?


Added relevant links

Resolved part 1 of #131

Hey @mgechev Any reviews or something??

Let us not do this change for now.


refactor travis-ci:

osx does not come with gcc, actually it is clang. so, remove it.
move debhelper installation to "apt" plugin (it will affect only linux).
add otool (which is ldd equivalent) on osx.
split "before_install" into matrix
Changes proposed in this pull request:

better (in my opinion) structure

Your great patch is much appreciated. We are considering to apply your patch into the SoftEther VPN main tree.
SoftEther VPN Patch Acceptance Policy:
http://www.softether.org/5-download/src/9.patch
You have two options which are described on the above policy.
Could you please choose either option 1 or 2, and specify it clearly on the reply?

one

PRELIMINARY DECLARATION FOR FUTURE SWITCH TO A NON-GPL LICENSE
I hereby agree in advance that my work will be licensed automatically under the Apache License or a similar BSD/MIT-like open-source license in case the SoftEther VPN Project adopts such a license in future.

I'm afraid .travis.yml modification might conflict with https://github.com/SoftEtherVPN/SoftEtherVPN/pull/518

No problem, I will rebase it.

Merged. Many thanks for your hard work :+1:


Web - Payment - Several errors appear in console while adding BA via Payment

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Login with any account
Go to Settings -> Payment -> Add payment method -> Fidelity
Complete the process

Expected Result:
No any errors in console
Actual Result:
Several errors appear in console
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/722f83e0-f19a-437f-b6ce-d1bcb741ec83
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I don't have a Fidelity account, but I also get that first error when trying to connect a Capital One account


use data mode  but tableData is null

when pass api-mode prop as false and data prop as a array , via chrome dev tool, i can see vuetable data prop has value, but tableData is null. why ???
 <vuetable                         ref="tablevue"                         :api-mode=false                         :data="data"                         :fields="fields"                         dataPath=""                     >                     </vuetable>

@cheer555 Hard to say. Can you please put your code in codepen, jsfiddle, or codesandbox to show your problem?

+1
I have trouble with replacing the api-url="https://vuetable.ratiw.net/api/users" that is in every example.
How can we use or own json data?
data="[...]" doesn't work. : https://ratiw.github.io/vuetable-2/#/Vuetable-Properties?id=-data
here is fiddle
http://jsfiddle.net/z11fe07p/4229/

I got it, you have to set :api-mode="false"


Add Roadmap

Add roadmap with short-term and long-term goals of the project

maybe we do something like https://github.com/meteor/meteor/blob/devel/Roadmap.md
but i think a section in the readme would be enough to start with

So what are those goals?
I think #110 and similar should be included in short term goals. Long term goals can be a bit more ambiguous.


Fix spawn animation

https://www.youtube.com/watch?v=PsQlDT_-Hoc&feature=youtu.be
it's just about letting the client handle despawning : remove https://github.com/mhsjlw/flying-squid/blob/master/src/lib/plugins/pvp.js#L73 (just check the client indeed despawn the mobs itself when they die)
video by @109C

But if the client despawns them, then there will be invisible mobs.

no, the server know they are dead anyway.
We just don't need to force the client to despawn them by sending the despawn packet.

But they shouldn't be dead? Doesn't it take more than one hit for sure for them to die?

ah, that's a separate problem.
Are you quite sure they are dead and not under the floor ? (I didn't notice that behavior on a non lagging server though, are you lagging ?)

After I recorded the video, I check and they weren't hidden in the ground. Also, the server in the video thinks the mobs are still alive. (I used some packet spoofing magic to hit them, and sometimes they reappeared.)

okay, in what condition can you reproduce this ?

spawn mobs
/kill @a
Relogging sometimes helped cause the problem

I used to be able to reproduce this error consistently, but I restarted my client and it doesn't seem to happen when I do the above steps. I think this may be caused by some other unknown factor.


Various little changes.

Some mostly independent minor fixes.

This is super cool. Thank you @neuschaefer !
If you are going to answer/fix my small nitpick, I'll wait. Otherwise, I'd be happy to merge.

I'll fix it later (unless you're faster), feel free to merge!

Thanks a bunch!


Init agent bug

Description of problem
@jleach I spotted a bug after your PR #1258
Whenever you start the wallet, you always hit this error
Screen shot
The reason for that is basically the useEffect hook is being fired on re-render, something on the deps array changed I guess
And it always hit the guard (if statement) that you introduced, which causes an exception to fire when the wallet is already initialized
Would you please take a look
Expected behavior
Wallet to initialize without errors
Steps to reproduce
Launch the app
Screenshots and/or log output

Environment

[ ] Occurs on Android
[ ] Occurs on iOS

Build #:
Android Device Model:
iOS Device Model:
Workaround
Severity

[ ] High
[ ] Medium
[ ] Low

@MosCD3 I've added a check to treat an open wallet as a warning since its not really an error IMHO. But, you might want to check why your wallet is not being closed between PIN entries. If its Bifold then we can create a separate issue to look there.


image.MetaData.HorizontalResolution is not correct, returns 1, and file properties shows 96

I'm using Veldrid.ImageSharp v4.1.1 from Nuget, and run the following code:
var fileStream = new FileStream("96Resolution.jpg", FileMode.Open);
IImageFormat format;
var image = Image.Load(fileStream, out format);
if (image.MetaData.HorizontalResolution < 72){ .... }
Here image.MetaData.HorizontalResolution is 1, but when I check the image properties, its resolution is 96 both vertically and horizontally. Another jpg file returns the correct resolution.
Just attached my test image.

Thanks

Hey @steven-gong, I'm not actually the developer of ImageSharp itself. Veldrid.ImageSharp is just an integration library that lets you create GPU textures from images loaded through ImageSharp. If there's a problem with loading image files, then you might want to go check the ImageSharp repo, or ask around the chat to see if anyone's seen the problem before.

Hi Eric,
Thanks, will post the issue there.
Steven
On 16 March 2018 at 17:35, Eric Mellino<EMAIL_ADDRESS>wrote:

Hey @steven-gong https://github.com/steven-gong, I'm not actually the
developer of ImageSharp itself. Veldrid.ImageSharp is just an integration
library that lets you create GPU textures from images loaded through
ImageSharp. If there's a problem with loading image files, then you might
want to go check the ImageSharp repo
https://github.com/SixLabors/ImageSharp, or ask around the chat to see
if anyone's seen the problem before.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mellinoe/veldrid/issues/56#issuecomment-373601039,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AU-xBpbLtb_VCxdfAkit5Kk-g4BWpHxkks5te0EpgaJpZM4StOrt
.


Increase test coverage

There are still code sections that aren't exercised through the tests

Things that I won't fix - at least not before 0.7:

hacks for python2-support is of course not covered when running tests with py3
some weird corner cases reported in #81 and #56 is not exercised by the test (will maybe help to fix #45)
other obscure error situations where an exception will be raised
elements.ical

Things that should be covered by test code for prior to 0.7:

DAVClient.mkcol is not exercised.
repr and str on DAVObject and CalendarObjectResource
backwards-compatibility mode (expand=maybe) in date_search
error raising in date_search, if end is not given but expand is True
backward-compatibility attribute sort_key to the todos method
Calendar._calendar_comp_class_by_data(self, data) is only tested for VEVENT, should be tested for vtodo and vjournal
todo_by_uid and journal_by_uid
CalendarObjectResource.copy
CalendarObjectResource._create, is the code too complex?  Do we need all the logic there?  If so, everything (possibly except weird corner cases thrown by exotic servers) should be covered by tests
save with no data given?  does it make sense at all?  should be covered with tests anyway.  Other corner cases with no uid given in the icalendar data (will that work anyway?) but no_create given.
lib.url.URL.repr
lib.url.URL.strip_trailing_slash
element.base.BaseElement.str

Things that should be looked into:

DAVObject.canonical_url is not used anywhere, and can probably be removed, abandoned code?  Should probably wait until 1.0 to preserve backward compatibility.
_handle_prop_response: some weird corner cases not exercised


Update to truffle 0.25

I've updated to truffle 0.25 by synchronizing to the sources in the truffle repository.
I used this while testing the truffle 0.25 staging repo.
During the synchronization I removed SLContextTest and SLDebugLegacyTest since they didn't exist in the truffle source an didn't compile.
I also did not import the JMH benchmark.

This has been solved in other PRs


Poll: Should this repo become "AIKit"?

Describe the feature or improvement you're requesting
Here's where I'm at with the current project:
I'm almost done with implementing a CoreML implementation for Whisper with OpenAIKit. And I've already completed the streaming data functions, along with the endpoint for Whisper.
Recently though, I've been thinking of moving this project from being OpenAI-centric to being an SDK focusing on AI implementation within the Swift ecosystem. So this would include projects like Stable Diffusion, ElevenLabs, Uber Duck, and so many more awesome AI projects: both from API endpoints to local CoreML models.
I'm now asking the community here: should this project have a broader focus on implementing more AI models and become known as "AIKit", or is it just fine to leave it as OpenAIKit and focus on OpenAI API features directly?
AIKit vote would be a thumbs up, OpenAIKit vote would be a thumbs down, and anything in between can go in the replies of this issue.
Thank you everyone for your continued support of this project.
Additional context
No response

Marco:  What did you decide to do with this idea?

Closed: Decision is to leave OpenAIKit as is.


Robot Controls

Need a much better design
Current control should be highlighted (much like the website)
Support for custom button panels as well as the default selection
Respect "Anonymous Control" setting, and display a helpful error if anonymous users can't control it. (With a way of logging in)

d-pad

Initial Version is done


Chart popup hiding under the chart on mobile

Steps to reproduce

Login to Zafira from Mobile (Admin/User)
Open General dashboard
Click on share of pie chart

Actual behavior
Chart popup hiding under the chart on mobile
Environment
Mobile
Safari
iOS 13.1.3
ui v.1.290-SNAPSHOT | server v.1.464-SNAPSHOT | client v.4.0.33-SNAPSHOT
Attachments

To solve this issue we need to add extra styles for tooltips (https://echarts.apache.org/en/option.html#tooltip.extraCssText)
@Boniara please add transform: translateZ(0)

@danymill all widget template were updated, test it

Verified in ui v.1.293-SNAPSHOT | server v.1.468-SNAPSHOT | client v.1.0-SNAPSHOT.

Reproducible on Mobile (Safari/Chrome) in ui v.1.29.RC2 | server v.4.1.82.RC5 | client v.4.1.65.

fix PR  https://github.com/qaprosoft/zafira/pull/2034

Tested. Fixed.


nil pointer exception is thrown if Tax property is not initialized

nil pointer exception is thrown if Tax property is not initialized
inv := &bill.Invoice{
    Tax: &bill.Tax{},
}

xinvoice.ConvertToXRechnungUBL(env)
<EMAIL_ADDRESS>line: 52 InvoiceTypeCode:         inv.Tax.Ext[untdid.ExtKeyDocumentType].String(),
expected behaviour: should work also without initialization of Tax property

Thanks @forwardever! I'm actually working on some changes now to help accessing Extension properties and avoiding panics, so I'll let @apardods know behind the scenes so we can incorporate this asap.

Hi! I have a added a fix in the UBL repo. It now returns an error explaining the document type extension must be present. However, adding the eu-en16931-v2017 addon in the $addons field of the invoice automatically adds that field from the document type, so you would never need to manually set the field! Let me know if you have any questions

okay, thank you for the quick response. I will build some xrechnungen in the next couple of days and will let you know if I face any problems and if the suggested solution (addon) works.


Couldn't open FPGA status from /sys/class/fpga/fpga0/status!

Hi,
When I start the accelerator by typing,
./run.exe conv.aocx
An error occur,
`***************************************************
PipeCNN: An OpenCL-Based FPGA Accelerator for CNNs

Couldn't open FPGA status from /sys/class/fpga/fpga0/status!
ERROR: Unable to find the desired OpenCL platform.

`
Can some one please help me to solve this problem?

By changing,
const char *vendor_name = "altera";
in derictory ../project/host/main.cpp , the problem can solve.


ReferenceError: UI_VERSION is not defined

Describe the bug
After upgrading to 4.0.0-beta.6 this method to include quasar-ui-qcalendar into Quasar app is not working anymore:
import { boot } from 'quasar/wrappers';
import Plugin from '@quasar/quasar-ui-qcalendar/src/QCalendarMonth';
import<EMAIL_ADDRESS>
export default boot(({ app }) => {
  app.use(Plugin);
});

The following error displays in the console: "ReferenceError: UI_VERSION is not defined"
Probably it should be changed by: import Plugin from<EMAIL_ADDRESS>in the docs: https://qcalendar.netlify.app/all-about-qcalendar/installation-types#Or-Create-and-register-a-boot-file

+1
Same problem

With webpack 5, when you import a json file, it no longer does tree-shaking on it. This caused the distributable to become bloated with unusable content (we only wanted the version).
There are a couple options:

if you are importing from the src folder, then take it a bit further using src/components/<component> instead

Or, in your own project that consumes QCalendar, add this to quasar.conf.js:

At the top:
const webpack = require('webpack')

In build -> chainWebpack
        chain.plugin('define-ui')
          .use(webpack.DefinePlugin, [{
            __UI_VERSION__: `'${ require('@quasar/quasar-ui-qcalendar/package.json').version }'`
          }])

I have updated the docs for Installation Types and Migration Guide.

Don't forget, you can always import from the dist/ folder as well, where you won't need the transpile steps.

Thanks a lot !

Just revisiting this. I have come up with an alternate way where a version.js will be generated at build time and no more replacement being done with @rollup/plugin-replace. It will be in the next release.


cannot satisfy -package-id ghc-8.6.5

I keep on encountering this issue in different projects and I don't know how to properly solve it. This is the error I get on a folder containing two standalone Haskell files that compile in a REPL:
ghcide version: 0.0.6 (GHC: 8.6.5) (PATH: /nix/store/y6srcy029ah4j3d8rrdghg9b00spzhci-ghcide-0.0.6-exe-ghcide/bin/ghcide)
Ghcide setup tester in /workspace/oss/why-fp.
Report bugs at https://github.com/digital-asset/ghcide/issues

Step 1/6: Finding files to test in /workspace/oss/why-fp
Found 2 files

Step 2/6: Looking for hie.yaml files that control setup
Found 1 cradle

Step 3/6, Cradle 1/1: Implicit cradle for /workspace/oss/why-fp
Cradle {cradleRootDir = "/workspace/oss/why-fp", cradleOptsProg = CradleAction: default}

Step 4/6, Cradle 1/1: Loading GHC Session
Loaded package environment from /home/gvolpe/.ghc/x86_64-linux-8.6.5/environments/default
ghcide: <command line>: cannot satisfy -package-id ghc-8.6.5
    (use -v for more information)

There's no cabal nor stack, just single Haskell files, but I also get the same error in bigger Haskell projects using Cabal 3.x.
Versions
> ghcide --version
ghcide version: 0.0.6 (GHC: 8.6.5) (PATH: /nix/store/y6srcy029ah4j3d8rrdghg9b00spzhci-ghcide-0.0.6-exe-ghcide/bin/ghcide)

> which ghcide
/home/gvolpe/.nix-profile/bin/ghcide

> ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.6.5

> which ghc
/home/gvolpe/.nix-profile/bin/ghc

I installed ghcide using Nix (https://github.com/hercules-ci/ghcide-nix).
Has anyone experienced the same issue?

Have you tried NIX_GHC_LIBDIR=$(ghc --print-libdir)?

I don't think I have tried that. Anyway, my hard drive just died so I don't have a laptop where to try this at the moment.
Feel free to close.

I also saw a similar error when I upgraded Stackage to lts-15.0 (GHC 8.8.2). But it was a non-nix environment. Just a plain stack project.

Note that the GHC package is hidden by default, so my guess is that the hie.yaml isn't exposing it.

I think I know why this happened (at least in my case). I forgot to compile ghcide with GHC 8.8.2 when I created the project using Stack LTS-15.0. AFAIK both ghcide and the code against which it is run, must be compiled with the same version of GHC.

Thank you all for the insights! I'm closing this for now since I cannot reproduce on a fresh install.


About configuring the configuration of the sub-library table

Excuse me, is it necessary to configure each table? Can all tables be configured with mandatory routing? Can I configure only the sub-library, do all tables use mandatory routing?

Can you explain the reason to close this issue?


remove cuda-nvcc and document ptxas

Closes #393
Fixes #390
cc @weiji14 @yuvipanda @dhruvbalwada @scottyhq

Should it be removed (used can install if needed) or just unpinned (user downgrades if needed)? Just wondering if unpinning is better, as some other things might be using it?

From a cluster perspective, I'm happy to keep drivers up to date with whatever it is the cloud providers support (which is out of our hands). If we feel this isn't going to affect non-jax users, and they have a well documented workaround, I think this seems fine to me.
Based on all this conversation, 2i2c now uses T4s as default GPUs for everyone https://github.com/2i2c-org/infrastructure/pull/1787. Thanks everyone!


video

is there a way to skip the entries with videos?

Not as a config option, but in giveaways.js you can modify this line:
https://github.com/jpchip/giveaway-grabber/blob/master/src/giveaways.js#L521
to
if (noEntryRequired.length > 0) {


Upgrade to unicorn2

At least, getting the README example to work (w/ matching unicorn2 install) is as easy as amending the self._regmap constants. 😘


[Masthead]: Separate menu content from interface text in the i18n endpoint

The problem

In the current response coming from the i18n JSON files, we noticed that there's a mixture of frequently changing data (eg. [mastheadNav], [footerMenu], etc) and text used for interfaces (eg. [misc], [leaving], [localeSelector], etc).
The purpose of this feature request issue is to evaluate the current data structure used for the Masthead and figure out a way to streamline the management of the frequent change content (eg. Masthead & Footer menus) vs text content used interfaces.
This is becoming more relevant as AEM is looking to build its own version of the Masthead datastore/endpoint that will be used to deliver content to the Carbon Masthead both for the Global/Standard, Cloud, and other products that are adopting the <dds-masthead-container> and <dds-cloud-masthead-container> components.

Treating everything as interface text
The current solution treats everything as interface text. This causes the problem that frequently changing data (or content data) will require awkward processes and workflows in GitHub by the editorial team.
Treating everything as content
This assumes that content data like the text and urls of the links lives together with text coupled to the interface (for instance the word Search in the search box). This has the problem that interface/design changes in the component will require editorial changes that must happen in sync with the release of component.
The solution

Identify interface text data that can be extracted from the i18n data structure.
House the management and translation for the interface text data within the Carbon for ibm.com project or a package that's applicable.

Note: This is just our initial thought, however, we're open to suggestions.
Application/website
AEM, Drupal
Business priority
Medium Priority = upcoming release but is not pressing
What time frame would this ideally be needed by (if applicable)

The timeframe of this work has not been determined yet. We just like to put this request on the board and figure out the solution and resourcing at a later time.

Examples
Example of data/text used for interfaces.
"misc": {
    "backtotop": "Back to top",
    "cancelText": "Cancel",
    "close": "Close",
    "cookiePrefs": "Cookie preferences",
    "continueText": "Continue",
    "editProfile": "Edit profile",
    "emailThisPage": "E-mail this page",
    "feedback": "Feedback",
    "mpScopedSearh": "Products",
    "withinMp": "Products",
    "next": "Next",
    "noresults": "No results found",
    "prev": "Previous",
    "resultsNav": "Use down and up arrow keys to navigate through the results.",
    "search": "Search",
    "selectCountry": "Select a country/region",
    "sharePage": "Share this page",
    "signin": "Sign in",
    "signout": "Sign out",
    "sitenav": "Site navigation",
    "welcomeback": "Welcome back"
  }

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

Convert to epic, create dev research issue, AEM content support will be needed, additional issues TBD based on the solution


No icons are displayed in clusters on ios

icons in the cluster and cluster icons on are displayed. tested on ios simulator

@alex-relov Is it the same issue as https://github.com/mierzynskim/Xamarin.Forms.GoogleMaps.Clustering/issues/7? Can you provide some more information?

@alex-relov Is it the same issue as #7? Can you provide some more information?

No, this is another problem, the icons on the ios website. unfortunately i have already deleted the project

@mierzynskim
No, this is another problem, the icons on the ios website. unfortunately i have already deleted the project


Could not find instructions for troubleshooting/reseting oauth2

I could not find the promised instructions for troubleshooting/reseting oauth2 in the link at the bottom of the README.  Can you provide a more direct pointer?

Sorry. Found it. Gray text on a grey background code blob.  Not what I was scanning for.  Perhaps add a header?
In any case, those instructions don't work. getOption("httr_oauth_cache") returns TRUE, which file.remove doesn't like.
I get the following error:
Auto-refreshing stale OAuth token.
Error:

I don't see anything on-screen from the very brief 'Auto-refreshing' action and the error message is blank.

Did this get resolved?  A little heavy handed, but one thing that always works, is to delete the .httr-oauth directory, and re-authorize.

I killed my rstudio container and started a new one.  Excessively heavy handed!
Turns out oauth was (probably) working all along.   Actual problem was because of an incompatible version of httr package.  Originally it worked for me, so I think the incompatible package version was loaded automagically when I installed another package.


Add a notification banner indicating how to un-hide UI

Right now while the user hides the UI with either 'Hide' Button or with 'ctrl+h', there is no indication of how to un-hide it. We should have a kind of notification bar appear right after user hides the UI, indicating how to un-hide it.

Question: @alisaad673 should the notification appear when you hide the UI and fade out after a few seconds or stay there?

It should Fade out after a few seconds

Understood.

@alisaad673 what should the text say on that notification? Now it's - "Press ctr+h to toggle the UI tools"


Add github action for checking the PR title

We now require that PR titles follow the "Conventional commit" standard, but do not have any mechanism to enforce this. I suggest we add a simple GitHub action to check the title for correctness.
Well, but can't we check this manually? Apparently, we can't: just looking at the list of recently merged PRs, I can see a few that are not in the proper format: #1368, #1362, #1361, #1352, #1349, #1344, #1343, #1339, #1334 -- just within the first page of 25 PRs. (This is not to disparage the authors -- us, reviewers, are equally at fault for not catching this).

Check out: https://github.com/marketplace/actions/pr-title-checker

Uhm, source code for that action is like 16k+ lines of code. Who knows what lurks in there?

Well, I think my point was there are some options out there that can be implemented quickly from the market place.  Here is one that is significantly smaller, i.e. 14 files total: https://github.com/marketplace/actions/pr-title-checker

Umm, I think you accidentally posted the same link as before.

My bad, I guess it is the same, although there are others.  I am confused though where you got 16K files, because the repo is:  https://github.com/thehanimo/pr-title-checker  There are only 14 files in the entire project.
Anyway, my poorly made point was, searching: https://github.com/marketplace?type=actions&query=title+check+  There are quite a few projects that already exist, so it should be possible to find one to use or identify as a starting point to modify.

Looks like creating a custom JS action is actually quite simple: https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action
And here's an example of an action that does simple title check: https://github.com/WindSekirun/check-title-wip-actions/blob/main/src/index.ts

Here is one specifically for conventional commits (there were a few more of them too):
https://github.com/marketplace/actions/conventional-commits-pr


Build error with presto-0.180

I used this command "./gradlew -Dairpal.prestoVersion=0.180 clean shadowJar" to build with presto version 0.180. But bundle of errors:
:cleanAssets UP-TO-DATE
:clean
:nodeSetup UP-TO-DATE
:installAssets
:buildAssets
[09:35:59] Using gulpfile ~/airpal/src/main/resources/assets/gulpfile.js
[09:35:59] Starting 'browserify'...
[09:35:59] Bundling app.js...
[09:35:59] Bundling plugin.js...
[09:36:14] Bundled plugin.js in 15 s
[09:36:22] Bundled app.js in 23 s
[09:36:22] Finished 'browserify' after 23 s
:compileJava
/home/khoale/airpal/src/main/java/com/airbnb/airpal/presto/QueryRunner.java:30: error: constructor StatementClient in class StatementClient cannot be applied to given types;
        return new StatementClient(httpClient, queryResultsCodec, session, query);
               ^
  required: OkHttpClient,ClientSession,String
  found: HttpClient,JsonCodec<QueryResults>,ClientSession,String
  reason: actual and formal argument lists differ in length
/home/khoale/airpal/src/main/java/com/airbnb/airpal/presto/ClientSessionFactory.java:45: error: no suitable constructor found for ClientSession(URI,String,String,String,String,String,Locale,ImmutableMap<String,String>,<null>,boolean,Duration)
        return new ClientSession(server.get(),
               ^
    constructor ClientSession.ClientSession(URI,String,String,String,String,String,String,Locale,Map<String,String>,String,boolean,Duration) is not applicable
      (actual and formal argument lists differ in length)
    constructor ClientSession.ClientSession(URI,String,String,String,String,String,String,Locale,Map<String,String>,Map<String,String>,String,boolean,Duration) is not applicable
      (actual and formal argument lists differ in length)
/home/khoale/airpal/src/main/java/com/airbnb/airpal/presto/ClientSessionFactory.java:61: error: no suitable constructor found for ClientSession(URI,String,String,String,String,String,Locale,ImmutableMap<String,String>,<null>,boolean,Duration)
        return new ClientSession(server.get(),
               ^
    constructor ClientSession.ClientSession(URI,String,String,String,String,String,String,Locale,Map<String,String>,String,boolean,Duration) is not applicable
      (actual and formal argument lists differ in length)
    constructor ClientSession.ClientSession(URI,String,String,String,String,String,String,Locale,Map<String,String>,Map<String,String>,String,boolean,Duration) is not applicable
      (actual and formal argument lists differ in length)
/home/khoale/airpal/src/main/java/com/airbnb/airpal/presto/ClientSessionFactory.java:77: error: no suitable constructor found for ClientSession(URI,String,String,String,String,String,Locale,ImmutableMap<String,String>,<null>,boolean,Duration)
        return new ClientSession(server.get(),
               ^
    constructor ClientSession.ClientSession(URI,String,String,String,String,String,String,Locale,Map<String,String>,String,boolean,Duration) is not applicable
      (actual and formal argument lists differ in length)
    constructor ClientSession.ClientSession(URI,String,String,String,String,String,String,Locale,Map<String,String>,Map<String,String>,String,boolean,Duration) is not applicable
      (actual and formal argument lists differ in length)
/home/khoale/airpal/src/main/java/com/airbnb/airpal/presto/Table.java:80: error: incompatible types: ConnectorId cannot be converted to String
        return new Table(input.getConnectorId(), input.getSchema(), input.getTable(), columns);
                                             ^
/home/khoale/airpal/src/main/java/com/airbnb/airpal/core/execution/Execution.java:305: error: no suitable constructor found for QueryStats(DateTime,<null>,DateTime,DateTime,Duration,Duration,Duration,Duration,Duration,Duration,int,int,int,int,int,int,int,double,DataSize,DataSize,Duration,Duration,Duration,Duration,boolean,ImmutableSet<Object>,DataSize,int,DataSize,int,DataSize,int)
        return new QueryStats(
               ^
    constructor QueryStats.QueryStats() is not applicable
      (actual and formal argument lists differ in length)
    constructor QueryStats.QueryStats(DateTime,DateTime,DateTime,DateTime,Duration,Duration,Duration,Duration,Duration,Duration,int,int,int,int,int,int,int,int,double,DataSize,DataSize,boolean,Duration,Duration,Duration,Duration,boolean,Set<BlockedReason>,DataSize,long,DataSize,long,DataSize,long,List<OperatorStats>) is not applicable
      (actual and formal argument lists differ in length)
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/khoale/airpal/src/main/java/com/airbnb/airpal/AirpalApplicationBase.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
6 errors
:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Any suggestion?
Thanks in advance
Khoa

Same problem with Presto 0.177 ... it does not compile ... hard to admit !

Same here with Presto 0.187

Similar issus with Presto 0.189 ..
  symbol:   variable this
  location: class AirpalUserFactory
/home/ec2-user/airpal/src/main/java/com/airbnb/airpal/core/AirpalUserFactory.java:21: error: cannot find symbol
        this.defaultAccessLevel = accessLevel;
        ^
  symbol:   variable this
  location: class AirpalUserFactory
/home/ec2-user/airpal/src/main/java/com/airbnb/airpal/core/AirpalUserFactory.java:24: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/ec2-user/airpal/src/main/java/com/airbnb/airpal/AirpalApplicationBase.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
12 errors
:compileJava FAILED

Since the repository is not maintained now, hard to fix this problem..


I took my chick up to the North, yeah (badass *itch)

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number:  N/A
What is the new behavior?

Other information

Cargo build is now possible

fix #42


Unpublished entries still visible in collection

Bug Report
If you add a workflow to a collection, then unpublish the workflow, the workflow is still in the collection.

Looks good to me, but someone else should try.

Works for me
https://staging.dockstore.org/organizations/SHIELD/collections/Test
(when toggling bcbio)


GPU vertex morphing in Java

Hey,
I'm trying to morph between vertices in Filament on Android. I see that I can set morphing to enabled, and set morph weights, but am a bit unsure on how to set up the renderable to actually contain the morph targets of interest.
It looks to me that it would be done through setting up the VertexBuffer with additional attributes (MORPH_POSITION_x, MORPH_TANGENT_x) but those attributes don't appear to be available; what am I missing here?

Use VertexAttribute::CUSTOM0 etc.
In the C++ header we have aliases set up:
MORPH_POSITION_0 = CUSTOM0,
MORPH_POSITION_1 = CUSTOM1,

See MaterialEnums.h.  We should probably do this for Java too...if Java allows aliases in enums?

Where is VertexAttribute::CUSTOM0 defined?
I only see these attributes: https://github.com/google/filament/blob/master/android/filament-android/src/main/java/com/google/android/filament/VertexBuffer.java#L33-L41

Thanks for the quick response! Wouldn't you need to account for the unused slot though? Or is there some code that accounts for that.

Oh god, good catch.  Will fix.

@prideout when can we expect the next stable build to be cut with this fix?

@matthong45 We should be cutting a new release soon, hopefully tomorrow.


default index on DocumentTypeColumn

There's no index created on the field DocumentTypeColumn when hiearchies/subclasses are stored in the same table.

Would you mind taking that one? Having it add an index automatically if it's hierarchical?

see #766

The other system fields like Deleted also don't have an index. Should I add an index to those fields?

Deleted, yes, because that's queried so often. I don't think I'd add anything to anything beyond that.

done!

It's in.


ci: Remove unused detritus from Docker images

Testing plan: Tested by renaming the images to anderskaseorg/zulip-ci: https://github.com/andersk/zulip/runs/3072625185

Great, merged, thanks @andersk!  @ligmitz FYI.

Updated the zulip/ci images on Docker Hub.


Use the -spanner style for README.md and INSTALL.md

We made a number of changes in -spanner to improve the README.md and INSTALL.md file (including changing that to doc/packaging.md) we should do this across the repositories:

[ ] -common
[ ] -cpp
[x] -spanner
[ ] -pubsub
[ ] -bigquery

/cc @devjgm

Done in our monorepo in https://github.com/googleapis/google-cloud-cpp/pull/3724


Dependencies between circleci builds

Cfr. @xdamman: "ideally, you’d want to also re-run those [e2e] tests not only when we update the app (which doesn’t happen very often) but also when you update the API. Not sure how we can automate that."

Workaround can be to set up nightly builds for the app.

Or adding this to API circle.yml could do? (not tested):

deployment:
  override:
    - curl -v -X POST https://circleci.com/api/v1/project/OpenCollective/app/tree/master?circle-token=$CIRCLE_TOKEN
    - curl -v -X POST https://circleci.com/api/v1/project/OpenCollective/website/tree/master?circle-token=$CIRCLE_TOKEN

Putting it in deployment means the app and website builds will run only if the api tests succeed.
But:

we might start wondering why those master website/api tests are triggered (don't know if link will be obvious and their result probably won't be magically reported back to the api Github PR. But don't know circleci enough.)
we trigger a full build of website/api including their unit tests which is a waste of time and resources

Extract e2e tests (both website and app) to separate repo and trigger them when any other repo is changed. In my view those tests should access staging, which is as close to production environment as it gets (although I've never seen it and don't know if it's used for anything else than manual test). I'm not in favor or maintaining an artificial environment (like "test API"), it's just another thing to maintain and doesn't give the tests as much opportunity to break (data is regenerated every time so is artificially clean compared to prod DB). But that also means staging must be kept up to date (which is probably wished anyway). And same as for 2., might start wondering what triggers the tests.
Obviously this is the most complicated.

What do you think?

app nightly builds
trigger master website/app from api deployment phase
extract e2e tests, trigger them in api, website and app deployment phases. Have e2e access staging.

@xdamman @asood123 @arnaudbenard @Philmod

Fixed by this PR and related ones:
https://github.com/OpenCollective/api/pull/262/files


Body cam and gripper cam do not work together

There are reasons for additional current drawn that limits the performance of the cameras.
Fixes can be:

Using an extended battery
Smartphone on the gripper
Using proximity sensors to cover the depth aspect (Club with Arduino - PCB)

Closing as no longer relevant.


Is it possible to jump to a specific date with a button click?

Basically as the title says, I want my user to be able to instantly go back to the current day by clicking a button.
I'm already calling
calendarView.setCurrentDate(today);
But I can't seem to find any method that forces the view to center on the selected month and year.

Never mind, found it.
In case anyone in the future has the same issue, the method you want is:
setCurrentDate(CalendarDay day, boolean useSmoothScroll)
Not the variant with a single argument that I was using initially, the two arguments version will scroll (smoothly or not) to the selected month in question.

@PedroBernils calendar is scrolling to the specified month but the date is not getting selected?


[HOLD for payment 2023-02-23] Push Notification from workspace message has double # for announce

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app and login with user A
Open any #announce of workspace chat
Send any message in that chat
In second device, make sure you are logged with user B (it should be present as member of workspace in which user A is sending the message) and ensure that notification settings to notify for that workspace is set to 'immediately'
Observe notification on second device

Expected Result:
Notification header should either say '#announce' or name of that workspace
Actual Result:
Notification header has double # i.e. it is displayed as '##announce'
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native

Version Number: 1.2.60-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/215002910-1b4bd6c0-8376-4627-9a32-408c82173e53.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674747974538149
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010281a3ff4c035e4b
Upwork Job ID:<PHONE_NUMBER>063428096
Last Price Increase: 2023-01-27

@arosiclair @mountiny @trjExpensify - you all commented on the Slack thread. Is this being worked on elsewhere or should we be gathering proposals here?

This will have to be internal most likely so we can keep this open and mark it internal!
I will snatch this one actually 🙇

Gonna investigate today

Got stuck with not working local env

Havent got around to this one yet

Still had other priorities

Still being worked on yeah @mountiny?

Still failing to get time to work on this one amongst N6.99 issues. I would look into this soon but if anyone from @arosiclair or @cristipaval might be interested in this, since you got experience with notification work, happy to hand this over!

@kavimuru Can you confirm what platforms this is occuring on? I only see Android and I feel like this might be only specific to it, but it would help to narrow this down if we would know what platforms this is happening on! thanks!

Thanks @dangrous!

@vitHoracek it is reproducible in Android only. Will update the environments affected.

@dangrous @lschurr @0xmiroslav this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Will look into this soon!

Running into some trouble with notifications and Pusher on my local, once that's resolved I'll be better positioned to investigate.

As I noted in the PR, this actually could have been fixed externally, but I only figured that out by finding out the issue and the solution. So... I did it.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.72-1 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/15104

If no regressions arise, payment will be issued on 2023-02-23. :confetti_ball:
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@0xmiroslav / @dangrous] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@0xmiroslav / @dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@0xmiroslav / @dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@0xmiroslav] Propose regression test steps to ensure the same bug will not reach production again.
[ ] [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@0xmiroslav re: PR - I think this has basically been true since we created the notifications - so technically this PR. The room name has been set as #announce on the backend since before that. We might have just not noticed it until then. Did Android maybe change how it made the room title visible recently and so that's why it popped up? @Julesssss as a notifications guru, do you know?
I'll still comment on that PR but I don't think a discussion would be useful - basically it should have just been tested more/thought about more since the # was getting added on both the backend and the front end.
Regression test should stop this from happening in the future.

Yeah, I think this just wasn't noticed as the feature is still in beta and not really being used.  I agree with this not really being a regression.

It looks like the last step on the checklist is a proposal for a regression test. @0xmiroslav could you be sure to do that?

@dhanashree-sawant (bug reporter) and @0xmiroslav (C+) could you apply to the job in Upwork: https://www.upwork.com/jobs/~010281a3ff4c035e4b

@lschurr thanks, I have also applied

📣 @dhanashree-sawant! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~016c7b8ae165dc0bda

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

All paid. Closing this one out as completed.


FFmpeg Encoders for OBS Studio does not work as it should

Description
While using OBS with FFmpeg Encoders for OBS Studio 0.3.0pre6 plug-in, enabling Spatial Adaptive Quantization seems to have no effect. Potentially, Temporal AQ does not work as well.
FFmpeg Encoders for OBS Studio 0.3.0pre6
0 value - http://ipic.su/img/img7/fs/1_FFmpegEncodersforOBS_0.1571437182.png
15 value - http://ipic.su/img/img7/fs/1_FFmpegEncodersforOBS_15.1571437212.png
FFmpeg.exe
0 value - http://ipic.su/img/img7/fs/2_ffmpeg_0.1571437333.png
15 value - http://ipic.su/img/img7/fs/2_ffmpeg_15.1571437346.png
Also, the wrong color modes are used, you can not select a limited or full color range, it is always full.
Expected Behavior
Adaptive Quantization is expected to work.
Reproduction Steps

Start encoding
Make screenshots with and without Spatial AQ (see attached screenshots)
They are identical (even if Spatial AQ should be clearly visible during comparison)

System Information

Software Version: 0.3.0pre6
Operating System: Windows 10
Kernel Version: 1909 18363.418
CPU: AMD Zen2 3900X
GPU: Nvidia GTX 1080Ti Series (MSI GamingX)
RAM: 32GB

Checklist:

[x] I have read the contribution guidelines.
[x] I can reproduce the issue with the exact reproduction steps I have provided.
[x] The issue appears on all of my systems that can run this software.

Please attach log files for the issue.

Aside from the color range, the two example look identical. Color range should be tied to the OBS color range, but it is possible that there is a bug there.

AQ Off - https://pastebin.com/bHAdMC8g
AQ On - https://pastebin.com/aSDHcH0D

01:39:32.810: video settings reset:
01:39:32.810:   base resolution:   2560x1440
01:39:32.810:   output resolution: 1600x900
01:39:32.810:   downscale filter:  Lanczos
01:39:32.810:   fps:               60/1
01:39:32.810:   format:            NV12
01:39:32.810:   YUV mode:          601/Partial
...
01:40:14.232: [obs-ffmpeg-encoder] [h264_nvenc]   Video Input: 1600x900 nv12 BT.601 625 Partial
01:40:14.232: [obs-ffmpeg-encoder] [h264_nvenc]   Video Output: 1600x900 nv12 BT.601 625 Partial

OBS Studio is set to partial range, and the plugin correctly detected that and used that for encoding. How did you extract those frames from the encoded video file?

I took a screenshot through the video player.

Please make sure that your video player supports proper upscaling from the format your are recording to. VLC for example does not support it for all container formats.
Aside from that, aq-strength is being correctly passed to nvenc.

I use PotPlayer, but what does it have to do with scaling when I just play a recorded video file.
If aq-strength worked correctly, the picture would not consist of hundreds of small squares.

Here is this plugin works as need to. Even the load increases when encoding via aq-strength 15.
https://obsproject.com/forum/threads/nvenc-adaptive-quantization.65343/#post-282632
https://www.dropbox.com/s/s3343dbm0b11eqm/obs-ffmpeg.rar?dl=0

Upscaling, or rather Color Conversion, is necessary to play back partial range footage without making color muted. Since partial range is a limited color range which only allows values between 16 and 235, when we fix your image from PotPlayer to be full RGB, it suddenly looks almost identical. So let's compare the two when they are fixed: https://imgsli.com/NzQ5OA
Both sides have visible blocking, despite having the same settings. The blocking just moved to somewhere else.

If you don't believe me that aq-strength is being correctly set (it should have zero impact on CPU load), you can set all the settings that you used for nvenc_h264 in ffmpeg using the custom settings field. That's what it's there for, to almost 1:1 apply ffmpeg settings.

MediaInfo reports this for limited/partial range footage:
Video
ID                                       : 1
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile<EMAIL_ADDRESS>Format settings                          : CABAC / 4 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 4 frames
Codec ID                                 : V_MPEG4/ISO/AVC
Duration                                 : 21 s 434 ms
Bit rate mode                            : Variable
Maximum bit rate                         : 6 000 kb/s
Width                                    : 1 600 pixels
Height                                   : 900 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 60.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Default                                  : Yes
Forced                                   : No
Color range                              : Limited
Color primaries                          : BT.601 PAL
Transfer characteristics                 : BT.601
Matrix coefficients                      : BT.470 System B/G

With this info, any player worth its weight should be able to correctly convert back to full range. And MediaInfo reports this for a full range file:
Video
ID                                       : 1
Format                                   : AVC
Format/Info                              : Advanced Video Codec
Format profile<EMAIL_ADDRESS>Format settings                          : CABAC / 4 Ref Frames
Format settings, CABAC                   : Yes
Format settings, Reference frames        : 4 frames
Codec ID                                 : V_MPEG4/ISO/AVC
Duration                                 : 27 s 100 ms
Bit rate mode                            : Variable
Maximum bit rate                         : 6 000 kb/s
Width                                    : 1 600 pixels
Height                                   : 900 pixels
Display aspect ratio                     : 16:9
Frame rate mode                          : Constant
Frame rate                               : 60.000 FPS
Color space                              : YUV
Chroma subsampling                       : 4:2:0
Bit depth                                : 8 bits
Scan type                                : Progressive
Default                                  : Yes
Forced                                   : No
Color range                              : Full
Color primaries                          : BT.601 PAL
Transfer characteristics                 : BT.601
Matrix coefficients                      : BT.470 System B/G

Everything is being set correctly from what it looks like.

I have been unable to reproduce this using your exact configuration. Windows's Movies & TV, VLC, MPC-HC, and even my TV are all playing back Partial footage and Full range footage correctly.

I figured out the color rendering in PotPlayer, it crashes due to adding a parameter in the video " Matrix coefficients: BT.470 System B/G", without it works fine.
Also In the OBS, the partial and full color ranges are interchanged: (It should be the other way around)
https://imgsli.com/NzUwNw
Here are screenshots with normal color rendering of the plugin in OBS:
https://imgsli.com/NzUwOQ
And here are screenshots with normal color rendering FFmpeg.exe:
https://imgsli.com/NzUxMA
Question! Why does the recording via streaming in the OBS, so much pixels the picture?
And recording video in OBS or just using FFmpeg.exe – no?
Spatial adaptive quantization 15 – Tries to remove the pixels in the picture, preserving the original quality, using it through streaming to the OBS, I do not observe this. A value of 0 or 15 does not make any difference. The same eggs, only in profile.
If there is a difference, it is invisible because of the many pixels in the picture. And apparently what creates them, prevents to see adaptive quantization in action.

Regarding Spatial AQ not doing what you expect it to, it actually is doing exactly what it should. See these two files where the only difference is disabling/enabling Spatial AQ. They look very similar, with minor difference in where blocks appear:

Spatial AQ Disabled
Spatial AQ Enabled

In these two files, the one with better quality is actually the one with Spatial AQ disabled, in all measurements (VMAF, SSIM, PSNR). And they both have the same blocking and were created using FFmpeg h264_nvenc.

I figured out the color rendering in PotPlayer, it displayed incorrectly due to the addition of the "Matrix coefficients: BT.470 System B/G" parameter in the video, it works fine without it.

That sounds like a PotPlayer bug, you should probably report it to them. I don't seem to be able to repro this issue in any video player and video editing software on Windows that I own.

https://dropmefile.com/ifTtf
The link contains 2 files recorded via FFmpeg with parameters: (As with -spatial-aq 1 -aq-strength 15 and without them.)
ffmpeg -i input.mp4 -c: v h264_nvenc -sws_flags lanczos -s 1600x900 -pix_fmt yuv420p -preset: v slow -profile: v high -rc: v vbr_hq -b: v 6144k -bf 4 -rc-lookahead 32 -level 42 -2pass 1 -spatial-aq 1 -aq-strength 15 -refs 4 -c: a: 0 aac -b: a 128k -y Output.mp4
If we compare the files frame by frame, it can be seen with the naked eye that SAQ 15 saves more details in the frame, while without it, more blurry details.

You're very welcome to spend an entire month encoding, comparing and running VMAF, SSIM and other metrics and have your own sample content.

Okay. I propose the following: let's close the ticket until i confirm my new suspicion. My current understanding is that it may be the video recorded with stream settings that is introducing the artifacts (not in every frame, too). Maybe this is what makes SAQ hard to see. Perhaps the stream itself is fine, but I cannot confirm it right now. Thanks!


Support supplying ink! version in URL

We should add support for supplying an ink! version to be used for the playground in the URL. This is necessary to allow links to the playground remain working, independent of us introducing breaking changes in new ink! releases. Generated permalinks should also contain this version. It's also needed for https://github.com/paritytech/ink-playground/issues/428.
I suggest to have a URL route a la https://ink-playground.substrate.io/v3.3.1/ and have the playground start up with a Cargo.toml template for that ink! version. Following semver we would only need to have templates for MINOR and MAJOR versions.

Thanks for the suggestion. I have to check how we can implement this, we currently build a docker image for Smart Contract compilation which contains all the cached artifacts which are required for compiling a Smart Contract:
https://github.com/paritytech/ink-playground/blob/main/compiler/Dockerfile#L14
Then later on we use this image to compile the Smart Contract with --offline flag:
https://github.com/paritytech/ink-playground/blob/main/crates/sandbox/src/build_command.rs#L134
I'd assume that the support for all ink! version either requires us to keep caching of all ink! versions in one Docker image, or to provide Docker images for all different ink! versions for compilation.


[Snyk] Upgrade html-snapshots from 4.4.0 to 4.5.1

Snyk has created this PR to upgrade html-snapshots from 4.4.0 to 4.5.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 3 versions ahead of your current version.

The recommended version was released on 5 days ago.

Release notes

Package name: html-snapshots

4.5.1 -<EMAIL_ADDRESS>

4.5.0 -<EMAIL_ADDRESS>

4.4.1 -<EMAIL_ADDRESS>

4.4.0 - 2024-09-12update devdeps

    from html-snapshots GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

coverage: 99.245%. remained the same
when pulling 86f1316750b2609434cb2f283d3189240d3a0f16 on snyk-upgrade-8073ee0846b13cc491672e651048bf55
into 232d704ef95616a0fb4546778b08b3a2789af996 on master.


[ESP32-H2] Add the adc_cal example

Per this comment:

Because esp-idf still does not support calibration for H2 so I don't know how we can add support for it just now. (see efuse/esp32h2/esp_efuse_rtc_calib.c#L13)

Let's track this in https://github.com/esp-rs/esp-hal/issues/326 instead.


Signal name autocompletion stops after typing ""

Godot version:

3.3.0
OS/device including version:

Windows 10
Issue description:

https://user-images.githubusercontent.com/50304111/115794694-ad682f80-a38b-11eb-9c2a-55c9373ad222.mp4
Steps to reproduce:
See above
Minimal reproduction project:

n/a

The final comment in the draft suggests that this behavior is intentional. Should we maybe open up a discussion about this?


Fix doctool misleading error message

godot --doctool <path> can generate documentation at any directory path, not only the base Godot path.
See also PR godotengine/godot-docs#3006, namely this diff.

This one is safe to merge and reflects the documentation changes made in godotengine/godot-docs#3006, unless we consider the existing feature as bug now, but I think it does make sense to have ability to dump documentation outside of Godot source tree/executable.

Thanks!

Could this be cherry-picked to 3.2? I've stumbled upon the same misleading message in 3.2 while generating documentation with custom modules, and I've even forgot about this by now. 😃
I can do this myself, if you wish, thanks.

Cherry-picked for 3.2.4.


to fix condition error that used in log_response

request class is derived from dict, so it will never be True.

request class is derived from dict, so it will never be True.

Well, that's false:
>>> nothing, something = {}, {'foo': 'bar'}
>>> if nothing:
...    print("you won't see me")
...
>>> if something:
...    print("hello world")
...
hello world

I meant something like this:
from sanic.request import Request, RequestParameters

r = Request(b"http://localhost/", 2,3,4, 5)
True if r else False
False if r else True
r, r.items(), r.keys(), r.values(), len(r), bool(r)


Feature/cleanup

Based on the changes from #299 I propose this optional clean up of the code base

Remove unused libraries from lib/ folder (at least I could not detect any usage of these libs)
Optimise imports (as performed by IntelliJ) to increase maintainability

Info: If this PR is merged, the base PR (#299) will be closed automatically.

additional comment: I just renamed master to main... just to let you know...


Infinite loops and hangs when the frontend crashes at job queue time

See original issue on GitLab
In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 13:45
Summary
This was discovered as a part of #1309, see comment: https://gitlab.com/BuildStream/buildstream/-/issues/1309#note_342481685
Steps to reproduce
This is unclear, it only happens when BuildStream itself has a bug causing the frontend to crash at job startup time.
This might occur in other parts of the code, it happens when the main process encounters an exception and tries to kill jobs, at least at job start time when we notify the frontend.
Possible fixes
So far, I've identified a bug which is that the scheduler notifies the abstract frontend code after creating the job and before adding the job to the internal active_jobs, there should not be any lines of code between the two, and certainly not if those lines of code send notifications which cause callbacks to be triggered.
Fixing this issue prevents the infinite loop behavior, but BuildStream still hangs and the mainloop never exits.

In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 13:46
marked this issue as related to #1309

In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 14:41
mentioned in commit 914dfa95fad66bf56b0139e7d212f3bd4c560cc2

In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 14:41
mentioned in commit 74108e1c6587694055a8de902f9f7ce4d6dd9d70

In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 14:48
mentioned in merge request !1933

In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 15:00
mentioned in commit caa7bc84fab307f7eb4ce2c7ccae50d09cc8f4c7

In GitLab by [Gitlab user @tristanvb] on May 15, 2020, 15:00
mentioned in commit 4b38ed5b1491ae81a3cd3e5184100502270ba323

In GitLab by [Gitlab user @tristanvb] on May 18, 2020, 06:12
mentioned in commit a272b932ca8118f1bdc2d5b0569151ce3f51bbdb

In GitLab by [Gitlab user @tristanvb] on May 18, 2020, 06:12
mentioned in commit 44dd378ece4917e02c080c275f2ce85a2a85126b

In GitLab by [Gitlab user @tristanvb] on May 19, 2020, 10:08
mentioned in commit 306616b894610528d1360836934b9d442d7ed4a9

In GitLab by [Gitlab user @tristanvb] on May 19, 2020, 10:08
mentioned in commit 7b1e0ce4e4b78b38b18c3def14bfdedb36184085

In GitLab by [Gitlab user @marge-bot123] on May 19, 2020, 10:28
mentioned in commit f41c4dc515eac959ab8adec3c0e0d0ef92b43930

In GitLab by [Gitlab user @marge-bot123] on May 19, 2020, 10:28
mentioned in commit a247912c29d84ddf349dcc5d11beb5976a3b0d8a

In GitLab by [Gitlab user @marge-bot123] on May 19, 2020, 11:22
closed via merge request !1933

In GitLab by [Gitlab user @marge-bot123] on May 19, 2020, 11:22
mentioned in commit 99063c732b56fb92f6c8b8c32bdb66eb4fb015e6


Actions firing 3 times

Hi, this started happening in 1.29 and it is very strange. Opening a new window with CTRL+SHIFT+N opens 3 new windows instead of just 1 and clicking Check For Updates checks for updates 3 times and I get the alert window for no new updates 3 times.

I don't know how to reproduce this reliably, it starts to happen after some usage.

/duplicate #62524


GTK Application Menus

I'm on KDE, and I noticed GTK application menus do not work whenever I'm using the shared mouse with Waynergy; they are not clickable by mouse at all unless I hover over what I want to click in the menus then press the enter key on the keyboard instead to get things clicked in the menus.

This is a KWin bug: button events generated by the fake input protocol all had a time of 0, and (from a cursory glance at the gtk3 source) menu activation logic is very much time-sensitive. Coincidentally it was just fixed with https://github.com/KDE/kwin/commit/1a8c79653632c015cfb5e1831fcab0fde7eeca0e so there's not much to do here other than wait for it to be released, as the protocol provides no means to force a more sensible time value.
Using the uinput waynergy backend is a possible workaround until then.


Clarification on reservations

The document says,

If you have any existing reservations, they stop applying after you transfer a subscription. Be sure to cancel any reservations and refund them before you transfer a subscription.

This appears to be true, but it doesn't happen immediately or even a few days later leading to much confusion.
What happens is there is a 30-45 day grace period during which the reservation continues to apply to the resources. When we noticed the reservations still applying days after transferring a subscription and contacted Microsoft Support for clarification, the grace period did not come up and instead we were advised that if it was working then we have our answer. When we discovered the utilization had stopped applying ~50  days later we contacted Microsoft Support again and learned there is a 30 day grace period. However, the reservation billing history shows that it stopped applying around 45 days after the subscription moved.
Recommended change

If you have any existing reservations, they stop applying 30-45 days after you transfer a subscription. Be sure to cancel any reservations and refund them before you transfer a subscription to avoid charges after the 30-45 day grace period.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6aef944e-c3da-70b4-47c4-9c45447d0a3c
Version Independent ID: 4fb9a899-cf9f-43dd-334a-f202e3b75067
Content: Transfer Azure subscriptions between subscribers and CSPs
Content Source: articles/cost-management-billing/manage/transfer-subscriptions-subscribers-csp.md
Service: cost-management-billing
Sub-service: billing
GitHub Login: @bandersmsft
Microsoft Alias: banders

@jonwbstr Thanks very much for your feedback. I'll investigate with the Reservations engineering team and update the article, as needed. I'll reply here when I have a clear course of action.

https://github.com/MicrosoftDocs/azure-docs-pr/pull/151888

@jonwbstr You're right and make a good point. The grace period you mentioned was recently chagned to 90 days (per the Reservation enginnering team). I've updated the article as you suggested and noted the 90 period. Thank you.
#please-close


WrapMode support is missing

Should this system actually support wrap modes?
Mecanim only cares about the isLooping property and as a result the Humanoid animation importer doesn't show the dropdown for wrap modes, so most of the time this system will not see a wrap mode other than Default.
The only way to set the wrap mode of an animation in the editor is to set the Rig to Legacy, which is explicitly unsupported by SimpleAnimation. BUT, if you set a wrap mode then change the Rig back to Humanoid, the animation will keep the wrap mode. You can also set it via script (which will be undone next time you import the model). Normally it wouldn't matter because Mecanim totally ignores it, but this system will give unexpected results (and the few wrap mode checks that are currently in SimpleAnimationPlayable.cs do so, such as when CalculateQueueTimes checks against WrapMode.Loop but doesn't check the isLooping property).
So should this system ignore wrap modes and just use the isLooping property like Mecanim does? Obviously that goes against the idea of making a system as close to Legacy as possible, but at least it would actually fit in with the editor interface cleanly.

I thought I was supporting wrap modes in Animancer, but I realised today that I actually wasn't and I'm not sure Unity gives us enough access to do it cleanly because the isLooping property is readonly.
WrapMode.Once is easy enough because it just stops the state.
But if we say the wrap mode is Loop when isLooping is false, the AnimationClipPlayable will still freeze the clip once the time passes the end. So we'd have to modulus the playable time when that happens, meaning we can't use it to determine how many times it has looped like we normally could (unfortunate, but not really a big issue).
Conversely, if we say the wrap mode is ClampForever when isLooping is true, the playable won't freeze when it passes the end. So we'd have to set the time exactly to the end and either pause the playable or set its speed to 0, either of which is a rather more significant alteration to the state and will also complicate things if the user sets the time back and expects it to start playing again.
I'm planning on just removing wrap modes from Animancer since I can do both queueing and stopping the graph using the OnEnd delegate event I've got.
But without that event, I'm not sure how Simple Animation could approach the problem.

I guess states could have a bool for stopGraphOnEnd if Once is the only mode that's actually significant.
Or maybe PlayQueued could accept a null stateName to stop the graph.


Face Recognition System

Title: Face Recognition System
The Facial Recognition System is designed to detect and recognize faces in real-time using a combination of the Ultralytics YOLO model, the face_recognition library, and OpenCV for live video processing. The system utilizes supervised learning by training on a labeled dataset of known faces, where each face is associated with an identity. The project creates a pipeline that detects faces from a live video feed, extracts facial features, and matches them against the labeled dataset for identification. The system effectively classifies faces based on learned features by using YOLO for object detection and face_recognition for embedding extraction and comparison. This project is ideal for real-time surveillance, security, and access control applications.
Kindly assign this project to me @UppuluriKalyani
Name: Anirudh P S || GSSOC'24 EXT / HACKTOBERFEST

You can start working

Please assign this issue to me as I have great experience in working with projects of Data Science and Machine Learning


Gira Zigbee switch

Anyone who can help me with a adapter for the Gira Zigbee switch?
This is the log's I've been seen:
2019-09-06 20:41:53.842 (Zigbee) MQTT message: zigbee2mqtt/0x000f1712410308dd {'action': 'on', 'linkquality': 49}
2019-09-06 20:41:53.842 (Zigbee) MQTT message: zigbee2mqtt/0x000f1712410308dd {'action': 'off', 'linkquality': 49}
2019-09-06 20:41:53.842 (Zigbee) MQTT message: zigbee2mqtt/0x000f1712410308dd {'action': '1', 'linkquality': 49}
2019-09-06 20:41:53.842 (Zigbee) MQTT message: zigbee2mqtt/0x000f1712410308dd {'action': '2', 'linkquality': 49}
2019-09-06 20:41:53.842 (Zigbee) MQTT message: zigbee2mqtt/0x000f1712410308dd {'action': '3', 'linkquality': 49}
2019-09-06 20:41:53.842 (Zigbee) MQTT message: zigbee2mqtt/0x000f1712410308dd {'action': '4', 'linkquality': 49}
2019-09-06 20:41:53.843 (Zigbee) Unsupported zigbee device type with model "2430-100"
Not for sure I've the select items are 1,2,3,4 or select1,select2,select3,select4 but Is should be easy to change it if necessary?
Don't know where to begin...

i would love for this one to be supported!

@toppe / @pcfreak1 could you please update plugin and check

how do i get them to pair?

i got it working.
the gira has 6 buttons, on, off and 4 scene buttons. ufortunately the 4 scene buttons do not result in the selector setting 1-4 but the selector sets to off. this is a bug i think?

Could you please provide examples of MQTT messages that device produces?

sure,
the mqtt messages below:
off: {"linkquality":36,"action":"off"}
on: {"linkquality":86,"action":"on"}
1: {"linkquality":92,"action":"select_0"}
2: {"linkquality":89,"action":"select_1"}
3: {"linkquality":89,"action":"select_2"}
4: {"linkquality":89,"action":"select_3"}

Could you please update plugin and check, scene buttons should be properly handled

works perfectly now! thanks!

I would like some options to be added for this one
there is a dimming feature which has the following mqtt messages:
dim up > {"linkquality":0,"action":"up","step_mode":0,"step_size":65,"transition_time":10}
dim down > {"linkquality":0,"action":"down","step_mode":1,"step_size":65,"transition_time":10}
stop dimming > {"linkquality":0,"action":"stop"}
can the options dim up, dim down and stop dimming be added?


Each kube config user is locked to a single Kubernetes cluster

The README for this project includes this sample .kube/config snippet.
users:
- name: kubernetes-admin
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      command: aws-iam-authenticator
      args:
        - "token"
        - "-i"
        - "CLUSTER_ID"
        - "-r"
        - "ROLE_ARN"
  # no client certificate/key needed here!

My understanding is that this user will only be valid for the cluster configured to use CLUSTER_ID. We can create a user per-cluster, but this creates a lot of redundant configuration.
Is there a better way to use aws-iam-authenticator with many clusters? Or is it absolutely necessary to create one user per-cluster?

For what it's worth this works out of the box if you specify the same clustername among clusters. If the clusters are already running you need to restart the the aws-iam-auth pod.

Currently it is designed to explicitly disallow this, so that tokens crafted for one cluster are not replayable in another.  This is enforced in EKS (we use the cluster name), but you could work around it as @andrewl3wis suggested if you are managing your own clusters.


remove ODS-2600 from known issues

@asanzgom are we sure this is not an issue anymore? There is no context provided in the commit message and also not in the description of this PR, still the issue this was linked to is still in backlog: https://issues.redhat.com/browse/RHOAIENG-4358

@asanzgom are we sure this is not an issue anymore? There is no context provided in the commit message and also not in the description of this PR, still the issue this was linked to is still in backlog: https://issues.redhat.com/browse/RHOAIENG-4358

@jstourac I opened such JIRA with regards to printing error logs that do later reconcile and should be therefore overlooked. Although for automation purposes Test Cases are not able to identify whether an error level log is relevant, that's why I opened such JIRA.

Okay, and what is the reason we can remove this from known issues than? What changed?

And do we understand why? Is it a stable pass?


Wall time shows 100% idle

@nolanmar511 PTAL

It's not necessarily unexpected for a Wall Time profile to show 100% of time spent in "(idle)".
For example, when profiling a server that is not under load (or under a very light load), it's very likely that the the server isn't doing anything.
@koistya -- Could you provide more details about what you were profiling?

For now, I'm closing this issue, since wall time profiles can be 100% idle when the profiler is working as intended.
Feel free to re-open if you think that the wall profiler is not working as intended.


Failures in GitHub on pyright 1.1.373 but no Pylance failures on the same pyright version

GitHub Action

VSCode
Version number

#### No errors

Latest release
https://github.com/microsoft/pylance-release/blob/main/releases/latest-release.json

If you run pyright on your codebase straight from npm via like npx<EMAIL_ADDRESS>do the erros also appear? This action is just shorthand for pulling it and running it, so I doubt this is the action's doing (rather, maybe a missed fix between pylance/pyright).

Oh yeah, good call. I see the errors in the CLI as well, so I guess the problem is on Pyright's side.

Yeah, you'd have to report this to Pylance, as it's possible they're missing this change.


KSQL DB Connector

Hello!
I want to suggest the idea of adding a new connector to the repository - for the KSQL DB
Unfortunately, at the current moment I have no time for developing it and adding new tests for checking all the work cases.
My source code, which is based on KSQL REST API and it's documentation, located here:
https://github.com/roomanidzee/kaesquella
It has unit tests, but no integration tests. (some environment for it is in integration-tests branch)
Can you please consider the possibility of adding this source code to the monix-connect repository?

possible no rights for adding a label, so I can't add a "new-connector" label here(

hi @roomanidzee,
it would be great to eventually have this connector :)
maybe you should create an initial PR and then someone can continue from there with the implementation work and add integration tests! :)

ok, will do this ASAP, thank you!

hi @paualarco
my initial PR was created (https://github.com/monix/monix-connect/pull/560) , so please check it ASAP


Vue 3 Cheatsheet All In One

Vue 3 Cheatsheet All In One
https://vue.xgqfrms.xyz/Vue-Cheat-Sheet/Vue-3.x-Cheatsheet-for-Developers.pdf

https://vue.xgqfrms.xyz/Vue-Cheat-Sheet


NIFI-9036 - Add AWS MSK IAM support to Kafka processors

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enhance Kafka processors for AWS_MSK_IAM SASL mechanism
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Is there a Jira case associated with this? If not please create one and use the NIFI-XXXX case number in the title of your commit(s), thanks in advance!

Hi @mattyb149, can you please look into this PR?

@pvillard31 or @mattyb149 can anyone take a look at this PR and see if we can merge this to main?

Just looking at the code, it LGTM. I don't have time to give this a try right now though. Hopefully some time next week if no one else does before.

@pvillard31 or @mattyb149 can we please take a look at this PR and close this out? All checks have been passed for this branch.

@mattyb149 or @pvillard31, Hope you are doing great. Can anyone review and approve this PR ? its been in this state for quite sometime.

@pvillard31, I'm looking into the conflicts. will resolve in a bit and let you guys know. Thanks

I will, later today

@nrnalamalpu Hi, I notice that AwsKmsSensitivePropertyProvider.java is being deleted in this PR - is there any reason this is being removed or is it a mistake? We can't remove this class, and it seems unrelated to the changes you're making. Thanks!

Hi @pvillard31,
I could not work on this PR till now due to other priorities. I addressed all the review comments and added the AwsKmsSensitivePropertyProvider.java back which is deleted by mistake.
Please see the screenshots for the testing we did in our AWS environment.

@pvillard31, Could you please look at the changes and see if we can get this merged to main branch? Thanks

Can anyone please look into this PR and see if we can close this out?
thanks

Hi @nandorsoma, Glad you reviewed the pull request at least. I was waiting for at least one of the committers to review and approve the PR. I would like to work on this and wrap up. Please let me know what should I do to wrap this up.

Hey @nrnalamalpu!
As I mentioned in the previous comment, the PropertyDescriptors are not registered in any of the processors so this feature won't work currently. The first step would be to fix that. After that:

Rebase the branch on top of the current main.
Since the git history is a bit messy, it would be hard to merge it. Please squash all of your commits and force-push one single commit, which can be our new baseline. If it's easier for you, you can open a new PR and do a cross-reference (commenting the link of the PR is enough) on both PR.
Test it with MSK, and only update this PR when it works as expected.

@nrnalamalpu any update on this?

Hey @exceptionfactory! Thank you for the heads up! I'm interested in opening a new pr, but I'd like to wait for @nrnalamalpu's answer.

Hi @nandorsoma and @exceptionfactory, we can have a new PR. Unfortunately, I tied up with other Priority items and could not spend time on this.

@nandorsoma, not sure which file you are referring for the property descriptors. The PropertyDescriptors are added in KafkaProcessorUtils.java file which will be rolled up to consumeKafka/publishKafka processors.

@nrnalamalpu, how do you mean they will be rolled up? For example, AWS_PROFILE_NAME is referenced only in one place in the whole codebase when you get the value of the property in setIamJaasConfig(). If you check other PropertyDescriptors, such as PASSWORD, you can see that it is added to the descriptor list of all processors that use it.


Fix UIA Word movement tests

Summary of the Pull Request
Fixes the 24 failing generated tests. 20 of them were fixed by enforcing the following rule: when moving backwards by word...

a degenerate range moves to the beginning of the word, then to the word behind it.
a non-degenerate range outright moves to the word behind it.

The fix was simple: if we're a degenerate range, check if we're at the beginning of the word. If not, move there. Otherwise, move to the word before it. See UiaTextRangeBase.cpp changes for implementation details.
Along the way, several misauthored tests were found:

2 generated tests:

Cause: MS Word considers a line break a word delimiter. We don't use line-wrapping to distinguish two separate words.

MovementAtExclusiveEnd backwards word movement tests:

end will always be writeTarget because...

[degenerate range case] both start and end are moved to the beginning of the word (writeTarget)
[non-degenerate range case] from the UiaTextRangeBase bugfix, we should be moving to the word behind it.

this misauthored test was explicitly found by fixing the bug first explained here.

References
#10925 Word navigation testing

If there are any remaining cases of #10819 I imagine this PR should sort those!

If there are any remaining cases of #7960/#10819 I imagine this PR should sort those!

At this point, no. All of the generated tests were verified to match the behavior of MS Word. The only exception being the 2 mentioned in the PR body (regarding line wrapping).


Modified ipoplib to handle different cases for storing credentials.

If there are credentials in the config file, use them
else
if there are credentials in the keyring, use them
else
ask for credentials interactively and store them in keyring
Storing credentials in keyring:
if interactive/GUI based:
store it using keyring based on OS services
else
store it in filebacked keyring
To handle special scenarios like bracelets, we might need the user to
provide some configuration option,
to help us, use custom backend, that we might implement in future work.

We follow pep8 coding style.
https://www.python.org/dev/peps/pep-0008/#maximum-line-length
So the code should be wrapped by 80 characters line length. Several lines of your code exceeds this criteria.

Sorry! Updated the code. Ran the test script as well to prevent any regression.


Fix to issue #207 did not make it into v1.7.0

From previous issue:

Running the latest version 1.6.1 against several thousand MarcXML records has identified a common error where certain subfields with leading/trailing spaces cause invalid URIs to be created. Although the error is in the source data, some space trimming in the XSLT could make the process more robust in this area.
Example MarcXML:

text
 rdacontent
http://id.loc.gov/vocabulary/contentTypes/txt

Resultant RDFXML:
<bf:content>
  <bf:Content>
    <rdfs:label>text</rdfs:label>
    <bf:source>
      <bf:Source rdf:about="http://id.loc.gov/vocabulary/genreFormSchemes/ rdacontent"/>
    </bf:source>
  </bf:Content>
</bf:content>

The result is that downstream RDF processing complains about invalid URIs, that contain the preserved leading space. I have also seen examples where a trailing space causes the same symptoms.

Although the fix appeared in some pre-v1.7.0 versions it didn't make it into the shipped version of v1.7.0
So, having upgraded I am back to my error state.  :-(

More than happy to locally test a patch for this...

@RichardWallis sorry for the long delay on this. It appears that we missed fixing this the first time when processing the 336/337/338 $b (we fixed it only for processing of $a). Strange that it didn't come up for you before! Please feel free to reopen if this does not fix it for you.
This fix has been merged to the default branch and will be part of v1.7.1, probably released next week.