Enable affinity configuration to schedule pod on specific nodes in cluster

This PR helps to schedule pod on specific nodes in cluster & feature has been tested on openshift cluster. Here are the testing configurations & test results screen shots.
quarks-job has been installed by helm by passing following affinity configuration values.
I. Label openshift cluster node
oc label node xx.xx.xx.249 cf-node-group=cf-nodes
II. Helm values as below
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: cf-node-group
operator: In
values:
- cf-nodes
III.  Test Results, Pod is scheduled on labeled node "xx.xx.xx.249"

@manno @jbuns
Hi Manno,
Can you look in this PR, I will be raising  subsequent  PR for quarks-secret/quarks-statefulset/quarks-operator


Change the name of the Interfaces.tsx file and move it into @types folder.

Types should also be consolidated when possible between gql.d.ts and the future Interfaces.d.ts. Specifically the ProjectQuery type is defined in multiple locations and files. Consider defining a base type for all ProjectQuery types and then extending this type when needed.


Dat file survey timing (0.5?)

Does an entry of 0.5 (see below table; sounds like SS3.30 ignores values of 0.5 anyway) then default to a timing that corresponds to the month entered for the survey (or fishery).  I would have thought that we would have put a 7 for the survey instead of 0.5, but maybe a 0.5 defaults to that specified in the survey observations section (which is month=7).  Probably fine, but just wanted to make sure.
#_fleet_type timing area units need_catch_mult fleetname
1          -1     1    1     0               Fishery  # 1
3          0.5    1    2     0               Acoustic_Survey  # 2
I can easily run a check, but figured I'd ask first.

I don't know why this input is set up this way, but it's definitely confusing.
The "timing" input here is really about what fraction of natural mortality occur before and after any catch is removed, so it's not really about observed data, and maybe that's why the input isn't a month value. With SS 3.30, there's now a -1 option (and warning if you use a fraction instead) for fisheries, that cause the F and M values to both occur continuously throughout the year. Since our survey has no catch associated with it, I think the 0.5 is ignored. Chantel tried adding survey catch for the POP model and I it didn't actually get removed from the population. I'm not sure if that's been fixed or not.
Short answer, I think what we've got for hake is correct, but the new -1 setting for the fishery represents a tiny change from previous models that perhaps should be noted in the write-up of the bridging steps.
User manual snip from page 32 is below:


S3Path: relativize can return an absolute path

We are relying in a part of our implementation on the behavior of the Path.relativize() to return a relative path. I discovered that the S3Path gives an absolute path back, if the relativize is executed on the root path. I checked again against windows and jimfs implementation:
@Test
public void relativizeAbsolutePathOnRoot() {
    Path path = Paths.get("C:\\");
    Path path2 = Paths.get("C:\\foo\\bar\\");
    assertFalse(path.relativize(path2).isAbsolute());

    FileSystem linux = Jimfs.newFileSystem("testme", Configuration.unix());
    Path pathJim = linux.getPath("/");
    Path pathJim2 = linux.getPath("/foo/bar/");
    assertFalse(pathJim.relativize(pathJim2).isAbsolute());
}

Here again a matching unit test: https://github.com/thsandu/aws-java-nio-spi-for-s3-issues-with-s3x/blob/2cbb6d27b8adde8499f49a146eedce870dec1ec6/src/test/java/software/amazon/nio/spi/s3/S3PathTest.java#L293

So does
    Path pathJim = linux.getPath("/");
    Path pathJim2 = linux.getPath("/foo/bar/");

result in a path equivalent to "./foo/bar/"?

Can you check if PR #394 has fixed this?

This test seems to pass with PR #394.
    @Test
    void testRelativizeAgainstRoot() {
        var s3Path = S3Path.getPath(fileSystem, "/");
        var relativePath = s3Path.relativize(S3Path.getPath(fileSystem, "/a/b/c/d"));
        assertEquals("a/b/c/d", relativePath.toString());
        assertFalse(relativePath.isAbsolute());

        var emptyS3Path = S3Path.getPath(fileSystem, "");
        relativePath = emptyS3Path.relativize(S3Path.getPath(fileSystem, "a/b/c/d"));
        assertEquals("a/b/c/d", relativePath.toString());
        assertFalse(relativePath.isAbsolute());
    }

I have added some additional tests to prevent a regression. Feel free to open a new issue if this is still a problem.


Union.sql Faulty For Table Name With Special Characters

Describe the bug
I was unioning two table names with union.sql, both of which have double dashes in their name "Table--1" (Received from a share, not my naming convention ;) )
The SQL query sent here is malformed due to this, as it cannot use the table name to find any of the tables columns: https://github.com/dbt-labs/dbt-utils/blob/main/macros/sql/union.sql#L89
Steps to reproduce
Just try to union two tables with double dashes in their names. I would hazard a guess that other special characters also cause the code to break
Expected results
The two tables to union
Actual results
The query linked in the above code snippet creates malformed SQL like below. NOTE: no columns have been added due to not being retrievable due to the table name.
create or replace  table TARGET_DB.SCHEMA.UNIONED_TABLE  as
(
select
cast('DB.SCHEMA.TABLE--X--1' as varchar) as _dbt_source_relation,
from DB.SCHEMA.TABLE--X--1
);
Screenshots and log output
N/A
System information

packages:

local: /libs/dbt-utils-0.7.6
local: /libs/dbt-utils-0.7.6-custom

Which database are you using dbt with?

snowflake

The output of dbt --version:
installed version: 1.0.8
   latest version: unknown

The latest version of dbt could not be determined!
Make sure that the following URL is accessible:
https://pypi.org/pypi/dbt-core/json

Plugins:
  - bigquery: 1.0.0 - No PYPI version available
  - postgres: 1.0.8 - Up to date!
  - redshift: 1.0.1 - No PYPI version available
  - snowflake: 1.0.1 - No PYPI version available

Additional context
I have implemented a fix locally that saves the tables I am unioning with double quotes
editing this line: https://github.com/dbt-labs/dbt-utils/blob/main/macros/sql/get_relations_by_pattern.sql#L21
to this:       identifier='"' ~ row.table_name ~ '"',
Are you interested in contributing the fix?
My fix is above :)

That's an interesting one, thanks @CharlieJ20! I would be wary to make the change you propose without knowing that it doesn't break normally-named tables - my spidey senses start tingling any time we're getting into obscure quoting logic. In any case we'd want to use adapter.quote because bigquery uses backticks for identifiers, and even then your change only handles strangely named tables (what about schemas etc?)
All of this to say that while I agree that you've found some undesirable behaviour, I don't want to add complexity to the default path without remaining confident that everything keeps working. In the meantime your custom override of the macro might be the safest bet.


clang compiler fails to build due to -pedantic and falltrhough

the following build command fails
cmake -DFLATCC_INSTALL=on -DFLATCC_RTONLY=on -DCMAKE_BUILD_TYPE=Release && make install
+ make install
[ 14%] Building C object src/runtime/CMakeFiles/flatccrt.dir/builder.c.o
[ 28%] Building C object src/runtime/CMakeFiles/flatccrt.dir/emitter.c.o
[ 42%] Building C object src/runtime/CMakeFiles/flatccrt.dir/refmap.c.o
[ 57%] Building C object src/runtime/CMakeFiles/flatccrt.dir/verifier.c.o
[ 71%] Building C object src/runtime/CMakeFiles/flatccrt.dir/json_parser.c.o
In file included from /usr/src/flatcc/include/flatcc/flatcc_flatbuffers.h:27,
                 from /usr/src/flatcc/include/flatcc/flatcc_builder.h:68,
                 from /usr/src/flatcc/include/flatcc/flatcc_json_parser.h:19,
                 from /usr/src/flatcc/src/runtime/json_parser.c:2:
/usr/src/flatcc/include/flatcc/flatcc_json_parser.h: In function 'flatcc_json_parser_symbol_part_ext':
/usr/src/flatcc/include/flatcc/portable/pattributes.h:61:33: error: ISO C does not support '[[]]' attributes before C2X [-Werror=pedantic]
   61 | # define pattribute_fallthrough [[__fallthrough__]]

would it make sense to disable -pedantic with -DFLATCC_PORTABLE perhaps?

Se my PR comment.
Just because your problem is in portable does not mean it can (or should be) used to fix issues with GCC versions.
Next time it may be a fully C11 compliant project with up to spec glibc (if such a thing ever exists), but GCC decides that you have to write "I really mean to return from inside a while statement" in a comment. That is unrelated to portable.

OK, based on a PR discussion it has become clear that clang raises the error and not GCC. We cannot afford to remove pendantic from clang so a fix is need in pattributes.h, likely by checking the C version.
https://github.com/dvidelabs/flatcc/blob/07ae7dca8118f9ab6d900a7d4797881cab708ba6/include/flatcc/portable/pattributes.h#L46-L66
Either the detection of PORTABLE_HAS_C_ATTRIBUTE
or
#if PORTABLE_HAS_C_ATTRIBUTE(__fallthrough__)
but it is a bit strange since clang says it is OK then complains anyway.

A quick fix might be to flag-D PORTABLE_EXPOSE_ATTRIBUTES=0.

So an update @mikkelfj !
It appears I got some wires crossed in my logs. My issue was in fact GCC 11 . I have multiple targets being built, and GCC 10 was fine, but GCC 11 threw this error (as you mentioned earlier) . I can go ahead and implement the pedantic disable for GCC over a specified version as you had mentioned and that should do the trick.
My apologies for wasting your time hunting down a clang issue :/


Support Cocoapods Source Podspec

Describe the solution you'd like
HockeyApp used to provide a source distribution of their library. AppCenter should similarly offer that as a Podspec. This prevents issues where we cannot enable the library due to binary incompatibilities. New architectures are held back when there's a binary-only distribution.
Describe alternatives you've considered
N/A
Additional context
This is particularly relevant for us now as Catalyst apps can't currently use AppCenter.

Thanks for the feature request @lickel. Tapping in @hamswan to take a deeper look at this.


Display unknown interestLevel (directOrIndirect) as dotted line

https://docs.google.com/document/d/1KyZO8XaRGyAxAtKf0UhbBQuWM6DASb2l310h8J0ewRY/edit?disco=AAAAWjMYxjU

@kd-ods I've been looking into this more. I set the interestLevel/directOrIndirect value to direct because it is not a required field and is often omitted from the data I've checked. There also isn't a codelist but I assumed that this string value would always be direct or indirect. In the case of this issue, that value is actually set to unknown.
I'm not sure what behaviour we want for everything here. In the case mentioned in the Google doc above, the interest has a type and an interestLevel. In this scenario the control edge is drawn to the default thickness, but with no label attached.
Do we want to assume a codelist, for the purpose of the visualiser, of direct, indirect, and unknown?
Happy to have a call if that makes thing easier.

There is a codelist (but you may have missed it because of the renaming of the property):
https://github.com/openownership/data-standard/blob/master/schema/codelists/directOrIndirect.csv
So when the field is omitted, let's assume that the value is 'unknown', then format the line on that basis. Will that work?

Thanks, @kd-ods, I'll take a look at this this week. We might need to chat, but I'll do some poking about first.


No Content Shows when 'ViewPagerAndroid' wrapped by 'ViewPagerAndroid',fixed width$height given

var ViewPagerTest = React.createClass({
    render:function(){
        return (
            <ViewPagerAndroid style={{flex:1}} initialPage={0}>
                <View>
                  <ViewPagerAndroid style={{width:300,height:400,backgroundColor:'#443213'}} initialPage={0} onPageScroll={e=>{console.log(e.nativeEvent.position);console.log(e.nativeEvent.offset)}>
                      <View style={styles.text}>
                          <Text>First child page</Text>
                      </View>
                      <View style={styles.text}>
                          <Text>Second child page</Text>
                      </View>
                  </ViewPagerAndroid>
                </View>
                <View style={styles.text}>
                    <Text>First page</Text>
                </View>
                <View style={styles.text}>
                    <Text>Second page</Text>
                </View>
            </ViewPagerAndroid>
          );
    }
});
...
var styles={
      text:{
      fontSize:20,
      backgroundColor:'#ffffff'
     }
}

Cannot show "First child page" and "Second child page" even if the exact width and height are given.But the touchevent-related Callbacks invoked like onPageScroll and onPageSelected

Is this still happening?

@facebook-github-bot no-reply

This problem still occurs, but I found a workaround, nasty but it's working.
I think there is some kind of defect which causes the inner ViewPagerAndroid not being shown on the initial render. However I noticed when I change the height of the element in my script editor, it re-renders the inner view correctly and is visible without problem. This is a nasty workaround but it's the only way I have managed to work around this issue. If someones has a better idea of achieve then same, would love to see it.
In the inner ViewPagerAndroid add the following:
componentDidMount() {   setInterval(() => this.setState({height: height, width: width}), 0);  }

@chrisciszak hmm, this actually worked for me, any fix to not make this so hacky? Or should I just keep it implemented as is? It's been more than a year since you posted.


Fix buffer memory leak

https://github.com/oktal/pistache/issues/399#issuecomment-459224155

Please check the travis-ci unit test build failures.

Oh, this version of GCC doesn't supports incomplete type in template parameter. It builds in my machine.

I will try to avoid this type of declaration std::shared_ptr<char[]>.

I've probed it just works with g++ 7. Closing this merge request.

At some point I would like to have the travis-ci test run against all "supported" platforms.  I have a different open bug to remind me to work on this.  Sadly, I'm not a travis-ci guru, but it looks simple enough; I just have not devoted time to it yet.

I think I fixed this problem. I will commit and see if works.

At some point I would like to have the travis-ci test run against all "supported" platforms. I have a different open bug to remind me to work on this. Sadly, I'm not a travis-ci guru, but it looks simple enough; I just have not devoted time to it yet.

I could try to solve it. What is the issue?

At some point I would like to have the travis-ci test run against all "supported" platforms. I have a different open bug to remind me to work on this. Sadly, I'm not a travis-ci guru, but it looks simple enough; I just have not devoted time to it yet.

I could try to solve it. What is the issue?

Issue #384:  Main issue is that I do not know which distros need support.  I use Gentoo Linux (gcc 7.3.0), which is an "always moving" target.  I also test on Ubunto 16/18 from time to time.  Can Travis support testing on the latest Centos, arch, debian, ubuntu, and on the oldest ubuntu that we want to support?  Would be nice to know that a code change works on newer distros but fails on older, or if a change simply fails on all.  But I don't want to distract this PR and this issue with that.


chore: make the owlbot postprocessor check non-required

We will soon disable the Owlbot postprocessor. This is part of the effort to enable hermetic generation in this repo (context)

/gcbrun

/gcbrun

/gcbrun


fixed timer issue after wss upgrade

Fixes the timer bug mentioned in Issue 1091 for the advanced_server_flex example.
The bug is related to a timer that is not cancelled after an upgrade to wss.
Instead of cancelling the timer, this solution ensures that the timer expires immediately, and that the call-back detects that no actions should be performed.

Well I had some plans for a more general fix but this pull request is looking better and better to me. One thing, can we please also fix the advanced-server example? It is here:
https://github.com/boostorg/beast/blob/develop/example/advanced/server/advanced_server.cpp
This is what I was thinking for the general solution:
https://github.com/vinniefalco/beast/blob/timed_stream/include/boost/beast/experimental/core/timed_socket.hpp#L25
It needs to be adapted for WebSocket so you can send a ping, probably I will make the "on timer" action customizable.

Hi, I updated the advanced-server example as well with the exact same changes. It seems to work ok.
I agree with you that a more general fix would certainly be better, but at least this will fix some annoying bugs in major examples.


refactor: shuffle around v2 metadata sections to allow read-on-demand statistics

Previously the v2 file format had described the column metadatas and column metadata buffers in the same part.  This is problematic because there is no way to know when the proto stops and the metadata begins.  It's also makes it more difficult to do "read on demand" column statistics (and dictionaries).  This PR changes the column metadata buffers to be in their own section, immediately after the data pages.  We also move the global buffers here for consistency.
Now a reader can quickly read all column metadatas and the schema in a single IOP and then follow that up by loading column-specific buffers on an as-needed basis.  This will allow us to only load statistics / dictionaries for columns that we are interested in.

Codecov Report
Attention: Patch coverage is 56.25000% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 79.71%. Comparing base (68b45c3) to head (74551d3).
Report is 2 commits behind head on main.

Files
Patch %
Lines

rust/lance-file/src/v2/reader.rs
47.72%
20 Missing and 3 partials :warning:

rust/lance-file/src/v2/writer.rs
75.00%
0 Missing and 5 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2400      +/-   ##
==========================================
- Coverage   79.98%   79.71%   -0.28%
==========================================
  Files         200      200
  Lines       54713    54957     +244
  Branches    54713    54957     +244
==========================================
+ Hits        43764    43809      +45
- Misses       8402     8602     +200
+ Partials     2547     2546       -1

Flag
Coverage Δ

unittests
79.71% <56.25%> (-0.28%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Location Suggestions when entering a place in Settings

Summary:
in Location Settings while trying to set location manually by entering a place, suggestions must pop-up providing a better workflow.
Steps to reproduce:
Settings>Location Settings> [x] Set Location Manually>Place name
Expected behavior:
Shows a list of Suggestions of Location
Observed behavior:
No suggestions
@barbeau what's your take on this?

I agree that this process could be streamlined.
Maybe something like the Google PlacePicker for entering place name:
https://developers.google.com/places/android-sdk/placepicker
...and then showing the entered/selected lat and long in the preference summary for those items.

@barbeau I didn't understand the second suggestion you said. Should this also be implemented for manually entering lat and long?

My personal preference would be to show the lat and long values in the preference summary text after they are set via a place name or manually by entering the decimal degrees values. Right now when the value is changed it's not obvious unless you open up those preferences.

One thing I'd like to maintain is that entering raw latitude and longitude numbers should continue to work even when there's no cell connection. So any functionality that relies on an internet connection must gracefully degrade.
Thanks for looking into this Utkarsh.


Package manager support?

Would it be possible for you to upload this library to maven?
This would make the library a lot easier to implement.

Plan to, but not now, there still some work about c++ ptr in jni, but I'll
try my best effort to make this happen ASAP.
On Wed, Dec 4, 2019 at 10:25 PM ethand91<EMAIL_ADDRESS>wrote:

Would it be possible for you to upload this library to maven?
This would make the library a lot easier to implement.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/haiyangwu/mediasoup-client-android/issues/5?email_source=notifications&email_token=AAOBOGSRADDYNLXKFUTBAZLQW64V7A5CNFSM4JVJN2Q2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6AULVQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOBOGXGMD42ALFZLMBOCRDQW64V7ANCNFSM4JVJN2QQ
.

--
Haiyang Wu
Freelancer
+86 189-1353-9979
Email<EMAIL_ADDRESS>

Thanks, looking forward to it :)

Already publish to jcenter.  🤓
implementation 'org.mediasoup.droid:mediasoup-client:3.0.4-alpha'


It doesn't work in app extension, does it?

It seems like Dotzu does not work in app extension ?
I did just as the doc instructed in my network extension, but no  bubble head button

I nerver tried in app extension. That's really interesting. Maybe it's not working because I need a UIWindow to display the bubble.


Added static server to easy run this example

I appreciate the thought here, but I'd rather not add this — I think it overcomplicates the demo directory, we have a live version available on GitHub anyway, and it also makes our repos look inconsistent — why haven't we got live servers for all the demos don't just work with a file:// URL?

Just because it was never done, it doesn't mean that it shouldn't be done. Of course, 'file://URL' works. But, I could just give it a try and browse the .js code, WITHOUT a 'git clone'.
And, this approach could well be adapted for other examples too!

And who is going to update all the examples to use this, then? I'd rather keep the examples simple, and not add dependencies needlessly. It also makes things more difficult to learn for beginners.


Test Issue created at Sun, 19 Dec 2021 02:23:00 GMT

Test issue body  Sun, 19 Dec 2021 02:23:00 GMT

Comment on issue at Sun, 19 Dec 2021 02:23:03 GMT


Refine Endpoint selection for multi-cluster Service

When the Endpoint of Multi-cluster Service is a local Service ClusterIP, refine the action to let it go to the corresponding exported Service's group to do final Endpoint selection. This can avoid the case that the traffic goes out of antrea-gw0 and goes back to OVS again when a local Pod is trying to access a MC Service but a local Service's Endpoint is selected.
Resolve #4431
Signed-off-by: Lan Luo<EMAIL_ADDRESS>

Hi @jianjuns @wenyingd @hongliangl I added a new config field 'serviceCIDR' under multicluster config section in this PR so that antrea-agent can check if Endpoint is local Service's ClusterIP or not. Another way to figure out the serviceCIDR of a cluster is to do like antrea-mc-controller to get the CIDR automatically, but it requires extra RBAC to allow antrea-agent to have Service creation capability.
Personally, I would prefer to let antrea-agent to figure out Service CIDR automatically which is more user-friendly way. Let me know if you have any suggestion. Thanks.

Do we have a better way to handle this rather than checking against serviceCIDR? AntreaProxy already knows all local ClusterIPs right. @hongliangl

Do we have a better way to handle this rather than checking against serviceCIDR? AntreaProxy already knows all local ClusterIPs right. @hongliangl

Yes, Antrea Proxy already knows a CIDR that can contain all existing ClusterIPs, but it is located in pkg/agent/route, like the IPv4 Service CIDR https://github.com/antrea-io/antrea/blob/114e14f5988a7b730fea7757f12fa68bd247feb3/pkg/agent/route/route_linux.go#L122.
I think the Service CIDR can be obtained by adding a new public method to this interface https://github.com/antrea-io/antrea/blob/114e14f5988a7b730fea7757f12fa68bd247feb3/pkg/agent/route/interfaces.go#L25.

@hongliangl I checked the codes, it seems Antrea proxy will only calculate the ServiceCIDR when proxyAll is enabled. Do you know how does AntreaProxy know what's the ServiceCIDR when proxyAll is disabled?

@jianjuns  I double checked with hongliang about the current ServiceCIDR implementation on proxy. Antrea proxy will calculate ServiceCIDR only when proxyAll is enabled. So Hongliang's suggestion to expose ServiceCIDR from route pkg can work only when we enable proxyAll with multicluster.  I feel this is not applicable for multi-cluster to get ServiceCIDR considering the proxyAll is disabled by default in most of cases.
@tnqn @wenyingd @hongliangl let us know if you know other alternative ways, thanks a lot!

Or we can calculate Service CIDR only when mc is enable in AntreaProxy, and when proxyAll is enabled, we calculate Service CIDR and install the route for the CIDR.

Yeah, I think it is good to keep a single way to discover Service CIDR. I am not sure what is the best design choice. Probably you guys can figure out.

After sync with @tnqn and @hongliangl  we plan to extract the logic of serviceCIDR calculation out of AntreaProxy, and make it as standalone module, eg: servicecidr_discover.go. Both AntreaProxy and Multi-cluster can be a caller of new module. Hongliang will help to estimate the effort and submit a standalone PR. thanks.

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

/test-multicluster-e2e

LGTM. Let us see if @wenyingd and @hongliangl have further comments.

/test-multicluster-e2e

@wenyingd @hongliangl @jianjuns please let me know if you have further comments, we may move forward if no more comments, thanks.

@jianjuns could you help to take a look and move forward if there is no more comments? Thanks.

/test-all
There are quite a few tests failed. Please make sure all tests passed.

The kind tests are failed due to image download issue which is not related with the change, I triggered it again

After checking the e2e log, I found it's a known codecov upload issue which is fixed by https://github.com/antrea-io/antrea/pull/4669, I will re-base and rerun.

/test-all
/test-multicluster-e2e

@luolanzone : you have a conflict to resolve.

@jianjuns sure, I have addressed conflicts locally but I found there is a bug for Service flow installation when I tried to verify the changes in kind. It maybe introduced by a new change which is merged recently. @hongliangl is troubleshooting the bug, I will push the latest change after the bug is verified and fixed.

/test-multicluster-e2e

@jianjuns @hongliangl I have resolved conflicts, could you take a look again? thanks.

/test-multicluster-e2e

/test-all

Seems the multicluster e2e take longer time then before and a few MCNP cases are failed randomly. I tried a failed case locally, it works fine. syncing with @hjiajing and @GraysonWu regarding the failed issue.

/test-multicluster-e2e

The MC testbed is recovered and e2e test is passed.

/test-all


⚠ BCR Bot has degraded performance

In e85a35c, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 801 ms

Resolved: BCR Bot performance has improved in 48cb184.


Is it possible to run the demo without GPU?

Thank you so much!!

Hi Zhiling,
Someone else has tested. It is possible to run the trained network on CPU. It is slower than GPU but still within an acceptable time (<1min per subject).
BW,
Wenjia


Update Calico releated images to v3.8.0

In this PR, we'll upgrade Calico related images to v3.8.0 and add a Calico pod2daemon.

cc @feiskyer


Update openfaas cloud version to 0.9.3

Signed-off-by: Matias Pan<EMAIL_ADDRESS>Description
Update OpenFaaS Cloud version to latest release: 0.9.3.
How Has This Been Tested?

Checklist:
I have:

[x] checked my changes follow the style of the existing code / OpenFaaS repos
[x] updated the documentation and/or roadmap in README.md
[x] read the CONTRIBUTION guide
[x] signed-off my commits with git commit -s
[ ] added unit tests

Derek set reviewer: alexellis

Derek assign: me


Change header colors to new material you scheme

Test how these colors appear in standard, 256, and windows mode.

Was thinking new material colors, but maybe something that looks better on light backgrounds.


Return 400 on invalid input

A simple patch to return proper information to the client side that its input data is invalid.
This is especially useful to silence errors that are not server-side when coupled with reporting tools such as sentry, Airbrake, etc.
I did not add unittests as I got lost in the structure for functional tests as library specific tests but if you tell me where to look, I'll add them.

Codecov Report

Merging #813 into master will decrease coverage by 1.89%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #813     +/-   ##
=========================================
- Coverage   96.25%   94.35%   -1.9%
=========================================
  Files         122      123      +1
  Lines        2057     2091     +34
=========================================
- Hits         1980     1973      -7
- Misses         77      118     +41

Impacted Files
Coverage Δ

test_project/linked_data/test_views.py
100% <100%> (ø)

src/dal/views.py
92.45% <100%> (+1.14%)
:arrow_up:

src/dal_select2_tagging/widgets.py
40% <0%> (-60%)
:arrow_down:

src/dal_select2_taggit/widgets.py
63.15% <0%> (-36.85%)
:arrow_down:

src/dal/widgets.py
79.22% <0%> (-16.89%)
:arrow_down:

test_project/select2_outside_admin/views.py
78.57% <0%> (-14.29%)
:arrow_down:

test_project/select2_tagging/test_forms.py
93.54% <0%> (-6.46%)
:arrow_down:

src/dal/test/case.py
90.74% <0%> (-5.56%)
:arrow_down:

..._project/select2_generic_foreign_key/test_forms.py
94.73% <0%> (-5.27%)
:arrow_down:

test_project/select2_taggit/test_forms.py
95% <0%> (-5%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc83e28...0fcc834. Read the comment docs.

Should be all good now. I left OPTIONS out as all cases I looked at ended up in View being in the inheritance tree so it will be handled automatically in most cases. The view now duplicates the View class check for 405 but I think there is no way around it.

Released in 3.2.4, grats !


KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (3/3)

Last batch for migrating WorkerSinkTaskTest tests to Mockito

As part of this last batch, please also removed this test from the list here: https://github.com/apache/kafka/blob/5cfcc52fb3fce4a43ca77df311382d7a02a40ed2/build.gradle#L424

Final batch of the WorkerSinkTaskTest migration  🎉 🎉 🎉
This one is probably the largest of the 3 (sorry).
We can either do one final commit renaming the test from WorkerSinkTaskTestMockito back to WorkerSinkTastTest, or just open a new PR once this gets merged to do the cleanup
Tagging @divijvaidya @gharris1727 @C0urante

Thanks @gharris1727 for your review. I think I addressed most of your comments.
If anyone has any other suggestions, please let me know.  Ideally we should rename this file back to WorkerSinkTaskTest (not sure if as part of this PR or a separate one) and have checkstyle, build.gradle, etc. cleaned up

Test failures appear unrelated, and the runtime tests pass locally for me.


dev-cmd/generate-*-api: don't use same constant name.

Otherwise Ruby warns.

Review period skipped due to critical label.


Question: What about node.js

have you got an idea or an exemple script for node.js (on client side)?
Thanks in advance!

i try this but it doesn't work...
it log this :
unreachable
{ reason: null,
message: null,
retry_delay: 1.6512635605121795,
retry_count: 1,
will_retry: true }
`var autobahn = require('autobahn');
var connection = new autobahn.Connection({url: 'ws://mydomain:8080', realm: false});
connection.onopen = function (session) {
function onevent(args) {
console.log("Event:", args[0]);
}
};
connection.onclose = function(error,reason){
console.log(error);
console.log(reason);
};
connection.open();
`
the following script work (in browser):
var webSocket = WS.connect("ws://mydomain:8080");
webSocket.on("socket/connect", function(session){
    //session is an Autobahn JS WAMP session.
    console.log("Successfully Connected!");
    //the callback function in "subscribe" is called everytime an event is published in that channel.
    session.subscribe("arduino/channel", function(uri, payload){
        console.log(payload);
        $('#channel').prepend('
' + payload.date + ':  ' + payload.content +':  ' +payload.ip +':  ' + payload.display +'
');
    });
});
webSocket.on("socket/disconnect", function(error){
    //error provides us with some insight into the disconnection: error.reason and error.code
    $('#channel').prepend('
' + "Disconnected for " + error.reason + " with code " + error.code +'
');
});

This Bundle runs on Symfony 2 not node.js

yes i know, and it work well, but my goal is to use a node.js client on client side, not on html browser.

node.js client on client side

You can use any client library compliant with WAMP protocol v1 in any language. (like this for example : https://www.npmjs.com/package/wamp1)


Refactored ListTileTheme: ListTileThemeData, ThemeData.listThemeData

Refactored ListTileTheme to make it conform to Flutter's conventions for component themes.

Added a ListTileThemeData class which defines overrides for the defaults for visual ListTile properties.
Added a ListTileTheme constructor parameter and getter: ListTileThemeData data. This is now the preferred way to configure a ListTileTheme.
Added a listTileThemeData listTileTheme property to ThemeData. This is now the preferred way to configure ListTiles in a MaterialApp.
Added selectedColor, textColor, iconColor and (ListTileStyle) style parameters to ListTile, so that all of the properties that can be overridden via the theme can also be set on the widget itself.

For example to configure the icon and text colors for all of the ListTiles in an app:
import 'package:flutter/material.dart';

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.min,
          children: <Widget>[
            ListTile(
              selected: true,
              title: Text('selected'),
              leading: Icon(Icons.android),
              trailing: Text('trailing')
            ),
            SizedBox(height: 32),
            ListTile(
              selected: false,
              title: Text('unselected'),
              leading: Icon(Icons.android),
              trailing: Icon(Icons.android),
            ),
          ],
        ),
      ),
    );
  }
}

void main() {
  runApp(
    MaterialApp(
      theme: ThemeData.light().copyWith(
        listTileTheme: ListTileThemeData(
          selectedColor: Colors.orange,
          iconColor: Colors.green,
          textColor: Colors.blue,
        ),
      ),
      home: Scaffold(body: Home())
    ),
  );
}

This is a non-breaking change.  In an upcoming PR all of the ListTileTheme properties, except for data will be deprecated and a Dart Fix script will be provided to automatically migrate code.
Fixes https://github.com/flutter/flutter/issues/31247

When is this going to be in the stable branch?

@anaurelian - it's not likely until mid to late December 2021

Thanks for the info @HansMuller glad to know that the drop for it appearing is soon.


Update Transactions blockchain description - æternity is the blockchain and AE is the coin

Sample

This also affects the asset details page:

Task is ready to be tested @Liubov-crypto

is this correct displaying of tx?

https://aescan.io/transactions/th_2YkBzEuhUt5wyBQ64fvrDFW8mqBPcLnUF5h28AbmuWTmTJxuYF

I have updated the PR. Please take a look again @Liubov-crypto
Regarding DEX filter: this was not a part of the task. Let's discuss this in the chat.

Fixed, LGTM


wagtailimage {% image fill- %} resize slightly off

I have a number of images displayed using the {% image %} template tag and resized in the templates, but for some reason the final image generated is slightly larger than the specified size. For example, I specified fill-616x274 and I get an image that displays at 618x275, where as if I specify fill-618x275 the image displays as 620x276. The file name generated by the image module is correct, but the image is slightly off (according to IE).
This has been happening with Wagtail 1.7.

@dwasyl What's the size of the original image?

@kaedroho okay, so I have two images set to fill-616x274 and get 618x275. The original images are 1260x1008 and 1426x920 respectively.
Another image I have set to fill-280x220 except it displays as 277x220 and in that case the original is 1426x948.
I considered whether or not any type of ratios might apply to the images, but since -full is specified I thought the sizing was absolute.

Reviewed today – assigning to myself to test. Possible duplicate of #8042.


Follow up commits on the 1.X for when an 1.X boards is actually switched to using morty

The patch 0001-btrfs-progs-utils-make-sure-set_label_mounted-uses-c.patch
has been merged in btrfs-tools version 4.6 so now we only need to make sure
it gets applied to version older than 4.6
Signed-off-by: Florin Sarbu<EMAIL_ADDRESS>

connects to https://github.com/resin-os/resinos/issues/113

As agreed with @shaunmulligan we will drop the update for morty on 1.X and concentrate on releasing 2.X.


[Feature][connector][access] Support source/sink for access #5291 #5293

Purpose of this pull request
Add new Access Connector

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

env {
You can set flink configuration here
execution.parallelism = 1
job.mode = "BATCH"
#execution.checkpoint.interval = 10000
#execution.checkpoint.data-uri = "hdfs://localhost:9000/checkpoint"
}
source {
Access {
driver = "net.ucanaccess.jdbc.UcanaccessDriver"
url = "jdbc:ucanaccess://D:\tmp\Database1.accdb"
username = ""
password = ""
query = "select ID, name, address, age, birthday, a, b, c, d, e, f, g, h  from student"
}
}
sink {
Access {
driver = "net.ucanaccess.jdbc.UcanaccessDriver"
url = "jdbc:ucanaccess://D:\tmp\Database1.accdb"
username = ""
password = ""
table = "student"
query = """insert into student(id, naMe, address, age, birthday,  a, b, c, d, e, f, g, h) values(?,?,?,?,?,?,?,?,?,?,?,?,?);"""
}
}

Could you add e2e test for this connector? Please.

Ok, I will submit the code in the next few days


Improve UX

Add Icon, logo and rework colors to something more sublte and greener (Xray).

Icon and PNG


Following development/build instructions results in an error during build step.

Description
I've followed the instructions in the "Development" section of the README. But end up with an error during the grunt build step. I'm not familiar with all the tools involved but afaik I've followed all instructions in the README which should result in a valid build. So there might be a step missing in the README or it is outdated.
Steps to reproduce

Install node
Install npm sudo npm install npm -g
npm install
bower update
grunt
grunt build

Expected results
A successful build
Actual results
Running "uglify:target" (uglify) task
JS_Parse_Error {
  message: 'Unexpected token: operator (>)',
  filename: 'main.js',
  line: 2376,
...

Additional information

grunt-cli v1.2.0
grunt v0.4.5
node v6.2.0
OS X 10.11.4

Sorry for this, the issue that a dependency (adapter.js) is currently using es6 stuff which does not work well for other projects. Will try to fix.

It's fixed since a little while ago and should work.


Suse / Ubuntu docker image

[ ] Suse image for production env
[x] Ubuntu for testing env
[x] safe database image = data outside of container
[x] mysql database with automatic import of legacy data...

Closed, docker image for production will be different from docker-compose env..


No logging

The integration doesn't logging with my prosegur user and password app, please help

Do you have access to https://smart.prosegur.com/smart-individuo/login.html#!/ ?

Now the link redirect to: https://alarmas.movistarproseguralarmas.es and yes I have access, any  Idea?

Now the link redirect to: https://alarmas.movistarproseguralarmas.es and yes I have access, any Idea?

when I try to add the integration, after write user and password, the integration answer "Invalid authentication" and it is not possible to install it.

You seam to have your alarm connected in the different platform, currently only the smart.prosegur.com is supported...

You seam to have your alarm connected to a different platform, currently only the smart.prosegur.com is supported...

Thank you!!

But smart.prosegur.com is no longer supported by prosegur....

But smart.prosegur.com is no longer supported by prosegur....

Why do you say that ? Were I live it's the only one available

But smart.prosegur.com is no longer supported by prosegur....

Why do you say that ? Were I live it's the only one available

Here in Spain it has been replaced by: https://alarmas.movistarproseguralarmas.es

@Albruaje are you skilled running python code ? I could create a test to see if it is any different the API's
Check the supporting library: https://github.com/dgomes/pyprosegur
If we make it work in the supporting library, then I can make it work in HA

I'm affraid I'm don't know about python code, but I can help you on any test you may need.

But can you run python from the command line ?

But can you run python from the command line ?

I'm affraid not

Thanks! It works with the new version in Spain. Now I will work to detect events and act. Thanks!

All credits go to Magnus Mølsæter who assisted me by testing the new code

Hi, Thanks dgomes, with the lates version it works in Spain!!!


Will quality improve in the future or there's not much else to improve (no drastic changes will be made in the future)?

Hi,
I am using latest version of waifu-caffe and I wonder if there any difference between that and 'official' w2x?
I also wonder if there will be any updates in the future that may improve quality of deblocking/denoising/upscaling etc?
I wanted to upscale my whole gallery and I afraid there will be a better version coming out in the next few months or so and I will have to do that again (plus I will have to keep original files too...)

I am using latest version of waifu-caffe and I wonder if there any difference between that and 'official' w2x?

waifu2x-caffe's cunet model is the same as the offical web app.

I also wonder if there will be any updates in the future that may improve quality of deblocking/denoising/upscaling etc?

There are no planned updates so far.

OK, thanks for the reply.
Last question tho: in your opinion waifu2x reached its peek level or there is a room for improvements in terms of quality (without introducing AI that draws the extra details like gigapixel)?
I don't really want to waste my time converting stuff and realize after I'm done there is a better and more efficient model available next day lol

without introducing AI that draws the extra details like gigapixel

In my opinion, adding textures that aren't part of the original artwork is not a good idea.

without introducing AI that draws the extra details like gigapixel

In my opinion, adding textures that aren't part of the original artwork is not a good idea.

I agree, that's why I said 'without'.

sorry for not fully understanding your views.
If the process can be made slower, it can be made better, but it increases the load on the web service.
In waifu2x-caffe, using TTA mode gives slightly better results, although it is 8 times slower.

I use caffe mod in offline with TTA for better results so I don't stress the server. I just wonder if you will improve the quality of upscaling in the future or this implementation is the best we will get (because we can do only so much with limited amount of data we feed to waifu2x) :)

At least I'm not planning any improvements at the moment.

OK, thanks


Change urlbar border on select to ~Chrome's

Change urlbar border on select to ~Chrome's:
Using #3e5b8a instead of Firefox's var for blue
I was unable to extract the exact color, so if anyone has a more accurate answer, be sure to say!

Has NOT been tested

On Chromium of Linux, this is #baccfa.

A cleaner approach would have been to change the --toolbar-field-focus-border-color variable instead of replacing it, but there's more at play here. On macOS, both Firefox and Chrome use the system highlight colour (Firefox's is slightly more vibrant though). On Windows, Chrome opts for what appears to be #b3cefb (light mode) and #35455f (dark mode), indicating that it's actually a semi-transparent colour. Firefox just uses #0078d7 regardless. Haven't tested Linux.
This makes life difficult on macOS because I can't modify the opacity of the colour variable and it's applied as a border, which means I can't use any kind of opacity or fill-opacity tricks. There's a chance I could create a pseudo element like #urlbar::before, stretch it to cover the urlbar, and apply say, opacity: .7 to it (plus the border) but this is getting into overkill territory. Maybe I could try it on a rainy day...

I think I'll close this as it's not really a good fix at all, the changes required would be definitely more than just this and I don't know how to do it 😅


compile a program with gtk+3 for Windows ?

Hello,
i recently success to compile the opencv library from the source, for code-block mingw, according [this tutorial] (https://zahidhasan.wordpress.com/2013/02/16/how-to-install-opencv-on-windows-7-64bit-using-mingw-64-and-codeblocks/).
So i get all requirement to compile my program including gtk+3.0, SDL2_mixer and opencv but...
The compilation fail and code-block try to build a library called something like opencv_gtk_test.a what's the name of my code-block project ???
I think the compilation fail due of the conjunction of the GTK+3.0 library with the opencv library because i soon have compile opencv from source for Linux and the cmake print a GTK+ take in charge which doesn't appear by Windows...???
Must I recompile OpenCV, it's was a little bit hard the last time to get viable libs on Windows and i have try to set the GTK+3 path into the PATH variable before compiling, or i'm in error ?
I get following code-block Build messages:
||=== Build: Debug in test_opencv_gtk (compiler: GNU GCC Compiler) ===|
obj\Debug\main.o||In function `ZN2cv3Mat7releaseEv':|
C:\Users\edward\Desktop\opencv_gtk\include\opencv2\core\mat.inl.hpp|671|undefined reference to `__atomic_fetch_add_4'|
||=== Build failed: 1 error(s), 0 warning(s) (0 minute(s), 3 second(s)) ===|

And following code-block Build log:
mingw32-g++.exe -shared -Wl,--output-def=bin\Debug\libtest_opencv_gtk.def -Wl,--out-implib=bin\Debug\libtest_opencv_gtk.a -Wl,--dll  obj\Debug\main.o  -o bin\Debug\test_opencv_gtk.dll  lib\atk-1.0.lib lib\cairo.lib lib\fontconfig.lib lib\gailutil.lib lib\gdk_pixbuf-2.0.lib lib\gdk-win32-3.0.lib lib\gio-2.0.lib lib\glib-2.0.lib lib\gmodule-2.0.lib lib\gobject-2.0.lib lib\gthread-2.0.lib lib\gtk-win32-3.0.lib lib\libatk-1.0.dll.a lib\libcairo.dll.a lib\libcairo-gobject.dll.a lib\libcairo-script-interpreter.dll.a lib\libcroco-0.6.dll.a lib\libffi.dll.a lib\libfontconfig.dll.a lib\libfreetype.dll.a lib\libgailutil-3.dll.a lib\libgdk_pixbuf-2.0.dll.a lib\libgdk-3.dll.a lib\libgio-2.0.dll.a lib\libglib-2.0.dll.a lib\libgmodule-2.0.dll.a lib\libgobject-2.0.dll.a lib\libgthread-2.0.dll.a lib\libgtk-3.dll.a lib\libiconv.dll.a lib\libintl.dll.a lib\libjasper.dll.a lib\libjpeg.dll.a lib\liblzma.dll.a lib\libpango-1.0.dll.a lib\libpangocairo-1.0.dll.a lib\libpangoft2-1.0.dll.a lib\libpangowin32-1.0.dll.a lib\libpixman-1.dll.a lib\libpng.dll.a lib\libpng15.dll.a lib\librsvg-2.dll.a lib\libtiff.dll.a lib\libxml2.dll.a lib\libz.dll.a lib\pango-1.0.lib lib\pangocairo-1.0.lib lib\pangoft2-1.0.lib lib\pangowin32-1.0.lib lib\libopencv_calib3d300.dll.a lib\libopencv_core300.dll.a lib\libopencv_features2d300.dll.a lib\libopencv_flann300.dll.a lib\libopencv_hal300.a lib\libopencv_highgui300.dll.a lib\libopencv_imgcodecs300.dll.a lib\libopencv_imgproc300.dll.a lib\libopencv_ml300.dll.a lib\libopencv_objdetect300.dll.a lib\libopencv_photo300.dll.a lib\libopencv_shape300.dll.a lib\libopencv_stitching300.dll.a lib\libopencv_superres300.dll.a lib\libopencv_ts300.a lib\libopencv_video300.dll.a lib\libopencv_videoio300.dll.a lib\libopencv_videostab300.dll.a lib\libtest_opencv_gtk.a -luser32 -lm
obj\Debug\main.o: In function `ZN2cv3Mat7releaseEv':
C:\Users\edward\Desktop\opencv_gtk/include/opencv2/core/mat.inl.hpp:671: undefined reference to `__atomic_fetch_add_4'
collect2.exe: error: ld returned 1 exit status
Creating library file: bin\Debug\libtest_opencv_gtk.a
Process terminated with status 1 (0 minute(s), 3 second(s))
1 error(s), 0 warning(s) (0 minute(s), 3 second(s))

@mrcyberfighter, it seems that you use mingw32 - this compiler is quite old. Please try to switch to mingw-w64.

I have try it with the mingw-w64 from MSYS2: mingw-w64-x86_64
I have try it with the mingw-w64: mingw-w64
Nothing to do, it doesn't work.
It compile right (the opencv3 library) only with the opencv-master.zip from github but nothing else:
the installers (opencv 3.0, opencv 3.0 beta, opencv 2.4.11)  from [opencv website] (http://opencv.org/downloads.html) won't compile.

Under Linux all work perfectly, except that the opencv version from the package-manager is compiled with GTK+2 instead of GTK+3,
but that's not a problem i can compile the library from source and  link my program in this way...
Else i get no problem during my holyday where i write a big part of my program on a MAC.
Why [opencv.org] (http://opencv.org/) do not provide us prebuilded bundle like she do for vs for mingw ?

It compile right (the opencv3 library) only with the opencv-master.zip from github but nothing else

Because mingw compilation has been fixed after 3.0 release: #5282
If you want to compile 3.0 release, try to port mentioned changes (or some more). But I'd recommend to use current master version or wait until 3.1.

Why opencv.org do not provide us prebuilded bundle like she do for vs for mingw ?

Because mingw is not officially supported.

I have found the diff of the files [here] (https://github.com/mshabunin/opencv/commit/771af4f32dd8c2609491743eda8cdd8adbe9c39e) of your mingw hack from opencv source but they are many changes to apply and i ask you if you don't get a downloadable bundle of your modified sources or better the compiled binaries of your mingw fork, maybe at [mshabunin/opencv] (https://github.com/mshabunin/opencv/tree/771af4f32dd8c2609491743eda8cdd8adbe9c39e) but i make a diff from a file and it doesn't correspond ?
It seems very hard to do all the changes manually for me.
Thanks for your answers.

@mrcyberfighter, these changes has already been integrated on master branch. You can just take latest from GitHub ant it should compile.

Thanks but i download [this repository] (https://github.com/mshabunin/opencv/tree/771af4f32dd8c2609491743eda8cdd8adbe9c39e) and IT'S WORK.
But now, because i develop my program on Linux, i hit on problems like the function realpath() which is not included in mingw...


Introduce Array::from_slice for easy array building

Hey! I've been looking for a way to easily build Arrays, and eventually gave up. So I'm submitting this PR, that I think would be useful to easily build Arrays of simple types at least :)
One thing that made me sad is, I apparently was unable to find a way to make slice-of-str typecheck without adding an impl From<&&str> for JsValue. I'd have loved to make it impl<T> From<&T> for JsValue where JsValue: From<T>, but 1. I'm not even sure whether that'd be allowed by orphan rules, and 2. I'm pretty sure it'd break backward-compatibility anyway.
Maybe I missed the one trait I should use, that'd support any of the ways to specify a JsValue? I can already say that AsRef<JsValue> is not it, because ["foo"].into_iter().collect::<Array>() does not typecheck; and thus JsCast must not be it either.
For some context, I'm needing a way to easily build arrays for the users of my IndexedDB bindings crate, as I just noticed that doing it inside the crate itself prevents some potential use cases (aka multi-entry indices).
What do you think about this? :)

Looks like there are quite a few places where wasm-bindgen-macro compile-fail message changes with the From<&&str>. I'll fix them all if you confirm you want this new impl for JsValue, as it doesn't make much sense if I'm going to change the trait or discard this PR altogether :)

What exactly are you trying to do that you are trying to solve with this PR?
Could you explain that with code?

My context is both these functions:

https://docs.rs/indexed-db/latest/indexed_db/struct.ObjectStore.html#method.build_index
https://docs.rs/indexed-db/latest/indexed_db/struct.Index.html#method.get_all_in

90% of the time, they will be taking slice arguments, so I wrote their API as taking slices in. However, I just discovered that some parts of IndexedDB, that I thought would work fine with Arrays, do require scalar values (aka multi-entry indexes).
My goal is to make it easy for the user, to call these functions both with a scalar value and with a temporary slice.
In other words:
// Instead of this:
let keys = Array::new();
keys.push(JsString::from("foo"));
keys.push(JsString::from("bar"));
store.build_index("baz", keys);

// I'd like the user to be able to write this:
store.build_index("baz", &["foo", "bar"]);

// But that'd break some parts of IndexedDB, so I'd like to fall back to this:
store.build_index("baz", JsValue::from(&["foo", "bar"]));

You can see examples of that code being used in practice here:
https://github.com/Ekleog/crdb/blob/e3987d5edfbb3c2af279e9e303eab6e8e13dc456/src/client/indexed_db.rs#L58-L90
Or here:
https://github.com/Ekleog/crdb/blob/e3987d5edfbb3c2af279e9e303eab6e8e13dc456/src/client/indexed_db.rs#L153-L157
To understand why it'd be a bit of a mess if I forced the user to build the Array manually each time.
That being said, if you think this is not good for wasm-bindgen itself, I'll just expose a macro to help users build the arrays, but I think such a function could be useful for other use cases too :)

Does using Array::from_iter() solve your problem?
store.build_index("baz", Array::from_iter(["foo", "bar"].map(JsValue::from)));

I'm aware this isn't as nice as what you proposed, but considering it's not actually adding an efficient conversion, I would like to not add any more high-level stuff to JsValue.

Considering the space it still takes (and the fact it's not very discoverable), I guess I'll still write a macro to make that easier for users, like compound_key!("foo", "bar").
Actually that makes me think, maybe an array![] macro, similar to the vec![] macro, would be more reasonable to introduce into js-sys. WDYT about it?

Actually that makes me think, maybe an array![] macro, similar to the vec![] macro, would be more reasonable to introduce into js-sys. WDYT about it?

I would prefer not to. This hasn't really been a written down or enforced policy so far, but I would really like to keep wasm-bindgen/js-sys/web-sys as low-level as possible. Basically the only thing I aim to let live here is whats necessary for higher-level implementations to do their job. Everything else should go into crates like gloo.
Thank you for the conversation though, I really appreciate somebody thinking with me about this!

I see, thank you for your answers and for taking the time to answer me! :)


Test CI

As a developer, I want to ensure that my CI is working properly, so that I can be confident that broken or buggy code isn't being pushed to the main branch of our repository.
Definition of Done

[x] Tests written or method well documented
[x] Test results are consistent and scalable

Tasks

[x] Ensure current version of CI is doing what's expected (Generating and comparing linted files with actual content).
[x] Do some research to make sure the commands are understood and well-documented.

I believe according to our definitions of done for this story, everything required has been taken care of.


Responsive problems

I just visited sass-guidelin.es/ru/ with my iPhone and see that the word “поддерживаемого” and “масштабируемого” in general title is wider than viewport. After this I visited other locales and seen this problem in Chience and Polish.

*Sorry for screenshots. Posting from the same iPhone. *

Indeed. I'll figure something out. Thanks for reporting.

Meh. Cannot reproduce it on my side. :(

Okay I just did some research on it and realized that the simplest way to fix this problem with long words is to add word-wrap: break-word; to heading selector. But it will not add necessary hyphens in the middle (must be any of под-дер-жи-ва-е-мо-го and мас-шта-би-ру-е-мо-го).
There is CSS hyphens: auto; to do exactly this, but it supports Russian hyphenation only in Firefox 8+ and IE 10+.
Instead I suggest to

use some JS implementation of this feature like Hyphenator
or just add some HTML+CSS like this with  and hyphens: auto

Oh I just realized that this feature works just with prefixes: -webkit-hyphens and -moz-hyphens. No need to .

Fixed with https://github.com/HugoGiraudel/sass-guidelines/commit/e59e218949facbd763ff0efcb7134e89c739e2cd.


A general rewrite of Jenkins config

This rewrites the Jenkins config as purely declarative pipeline, doing all the non-system work on the local
Jenkins source through Jenkinsfile as opposed to within the docker build.

Codecov Report

Merging #589 into master will increase coverage by 2.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
+ Coverage   84.62%   87.11%   +2.48%
==========================================
  Files         115       77      -38
  Lines       11664     7332    -4332
  Branches     1893     1476     -417
==========================================
- Hits         9871     6387    -3484
+ Misses       1539      753     -786
+ Partials      254      192      -62

Impacted Files
Coverage Δ

devito/yask/__init__.py
93.87% <0%> (-0.13%)
:arrow_down:

examples/seismic/__init__.py

tests/test_timestepping.py

tests/test_dimension.py

tests/test_save.py

examples/seismic/tti/__init__.py

tests/test_dependency_bugs.py

tests/test_interpolation.py

tests/test_ir.py

tests/test_checkpointing.py

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e57b62...f534cf3. Read the comment docs.

@mloubout another pair of eyes would be helpful here

@FabioLuporini - please could you say a bit more about the docker install? Am I interpreting correctly that this would be a build which installed devito into a docker image suitable for pushing as a self-contained devito environment to dockerhub? That would be very possible - though I'd suggest it be a separate branch and PR so Jenkins can get going testing with these changes at first.

On the subject of future work on this, there are two areas not addressed by this change, one being improving performance of the Jenkins run, the other being a reimplementation of doctr for Jenkins. The former I guess we play with post-merge, the latter I think probably deserves its own PR as I guess it will be a matter of doing some Jenkins credential-passing and some kind of Jenkinsfile-derived merge of the built docs with the gh-pages repo.

@FabioLuporini - please could you say a bit more about the docker install? Am I interpreting correctly that this would be a build which installed devito into a docker image suitable for pushing as a self-contained devito environment to dockerhub? That would be very possible - though I'd suggest it be a separate branch and PR so Jenkins can get going testing with these changes at first.

yes, and yes. Happy to have it in a future PR.

On the subject of future work on this, there are two areas not addressed by this change, one being improving performance of the Jenkins run, the other being a reimplementation of doctr for Jenkins. The former I guess we play with post-merge, the latter I think probably deserves its own PR as I guess it will be a matter of doing some Jenkins credential-passing and some kind of Jenkinsfile-derived merge of the built docs with the gh-pages repo.

OK. So, for the time being and until we have doctr working again, what do you think of keeping both Jenkins and Travis running in parallel?
I also suggest to wait for a second pair of eyes (@mloubout ) to go through this PR , then we can merge it.
Thanks again for the hard work. Really appreciated.

I think it's sensible to run them in parallel anyway for a while to make sure they at least basically agree.
In terms of the doctr methods - am I seeing correctly that what it's doing is checking out gh-pages, merging in the built docs directory, and pushing back any updated files? I think that with the github token already in Jenkins it should be fairly straightforward to replicate that. Famous last words....


[FEATURE REQUEST] - No hand cursor in the github social.

Is your feature request related to a problem? Please describe.
When hovering over the github button on the website, the cursor does not change to a hand cursor, which may confuse some users who expect clickable elements to have a hand cursor.
Describe the solution you'd like
Fix it using CSS.
Why do you think we should add this feature? How will it be useful for the project?
For a better user experience.

Hey @KendallDoesCoding Please assign this issue to me.

Is your feature request related to a problem? Please describe. When hovering over the github button on the website, the cursor does not change to a hand cursor, which may confuse some users who expect clickable elements to have a hand cursor.
Describe the solution you'd like Fix it using CSS.
Why do you think we should add this feature? How will it be useful for the project? For a better user experience.

@mnik7044  - thanks for bringing this to my notice. Please work on this.


Created using Colaboratory

my ML task at GDSC

name -Shreyansh Gupta

put your file in a folder as per instructed in the readme file


Dragabble marker example?

Any example on this? How to drag my locations marker?

I also want to know the answer to this question.

There's not likely to be any offical support for this. For how-to questions I recommend StackOverflow. I would  try getting drag and drop working with regular (non-map) widgets and adapt it from there, possibly using the plugin API.

Out of interest I know this is closed, but I thought this may be a useful little project that introduced another plugin for draggable markers.
see the main.dart file for example, I've uploaded at https://github.com/ibrierley/flutter_map_dragmarker if anyone wants an experiment, you just need the dragmarker.dart file.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #722 (8e32f2f) into main (4e03b81) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17


I can accept my own offer for nft I've bought

Seems weird glitch, we are missing some checks on offers table?
https://beta.kodadot.xyz/bsx/gallery/2645998698-6?page=2

I can do it

I can do it

As you can see above, the issue has already been assigned to someone else and is now considered locked. In the meantime, you could try your hands at one of the many other open issue 😉

I can do it

As you can see above, the issue has already been assigned to someone else and is now considered locked. In the meantime, you could try your hands at one of the many other open issues 😉

@RieserStern just to add a small thing here, make sure to checkout contributing guidelines to get more clarity about the process :)


access.log and error.log placement

Feature request
Place the access_log and  error_log directives inside the main server block instead of http block.
Feature description
Disable access_log at http block:
File: /etc/nginx/nginx.conf
# ...
http {
    # ...
    access_log off;
    # ...
}
# ...

Enable per site access_log and  error_log at main server block:
File: /etc/nginx/sites-available/example.com.conf
server {
    listen                  443 ssl http2;
    listen                  [::]:443 ssl http2;
    server_name             example.com;
    set                     $base /var/www/example.com;
    root                    $base/public;
    # new lines here
    error_log               /var/log/nginx/${server_name}_error.log warn;
    access_log              /var/log/nginx/${server_name}_access.log buffer=512k flush=1m;;
    # ...
}
# ...

Note: the ${server_name} variable must be replaced with the actual server_name set by the user for current website since Nginx does not accept variables in error_log or access_log directives path.
 Disabling  access_log at http level and enabling only for the main server block will ensure cleaner logs. Also, enabling per site  access_log will allow a faster i/o (smaller files) and faster spotting of entries (for example using bash tail will retreive only the records belonging to a certain site). The last two arguments  buffer=512k flush=1m will massively reduce the i/o frequency by keeping the records in memory up to 512Kb or dumping them to file after 1 minute  (in case of not reaching the limit). Enabling per site access_log can also be made optional (for backward compatibility, or for user preference) by enabling the ${server_name}_ part from syntax only when a checkbox is checked. IMHO it should be enabled by default, but any case is better than before.

Sure :)

Sure :)

ok, thanks.

I there anything wrong or else to do..?

I don't see anything about personalizing accessLog and errorLog filenames by adding ${server_name} in them, and nothing about accessLog parameters buffer=512k flush=1m like here:
    error_log               /var/log/nginx/${server_name}_error.log warn;
    access_log              /var/log/nginx/${server_name}_access.log buffer=512k flush=1m;

Splitting logs by server_name will allow us to analize logs with ease, log analisers can load those files much faster, especially when we talk about months of logs. Nginx log folder will look like this:
domain.com_access.log
domain.com_error.log
other.net_access.log
other.net_error.log
so on...

The accessLog parameters are also very important. When nginx receives a request it fills the logs in real time, and this can be a problem on servers with high traffic. Using buffer=512k flush=1m parameters instructs nginx to keep the records in memory and dump them into the file after 1 minute, or if bigger than 512kb. This values are tested and can be hardcoded, but for brevity you can also think some inputs to allow the user to set their own values for buffer and flush. IMHO this would be to much, those defaults are ok.

IMHO this would be to much, those defaults are ok.

means can I PR with the above code or add anything else?
I don't think this is my level of code another way.😓

+1 to what Sorin has noted here -- now that these files are within the server blocks, we'll want to move these from being globally configurable file names to being per-server file names. And I'd agree that being able to customise buffer/flush alongside the file names makes sense.

+1 to what Sorin has noted here -- now that these files are within the server blocks, we'll want to move these from being globally configurable file names to being per-server file names. And I'd agree that being able to customise buffer/flush alongside the file names makes sense.

So is the issue not available any more?

I don't follow what you're asking -- you asked to have this issue assigned to you so you could work on it?

What Sorin and I have noted here should be included in the work for solving this issue.

@MattIPv4
I saw the new PR and I think the work is going in the right direction. Still, there are some things missing:

in nginx.conf at http level access_log off; This should be always off, even if user doesn't choose to customize access_log filename. This setting would disable access_log globally, and user will enable it at server level.
in nginx.conf at http level error_log              /var/log/nginx/error.log warn; can be removed since that is the nginx default setting. Moreover, if someone opts to cusomize error_log filename in a custom nginx compilation this setting would cancel that customization.

I don't follow why removing the ability to set the access log globally is beneficial? What if a user just wants to enable access logging for everything, and not worry about having to enable it for each and ever server they have configured. Removing the global option seems like it just makes the user experience worse...
I also disagree with removing the default error log, and your justification for it. If someone is using custom nginx compilation, that is on them to realise that might collide with their own configurations they're using from this tool. They can just as easily change the error log name here.

@MattIPv4

I don't follow why removing the ability to set the access log globally is beneficial? What if a user just wants to enable access logging for everything, and not worry about having to enable it for each and ever server they have configured. Removing the global option seems like it just makes the user experience worse...

If user wants to enable access log globally this could be another checkbox in logging tab. Having access log off globally was my starting point in this issue:

Every site has from 3 to 5 server blocks for 301 redirects, this means that access_log will be filled with useless info. Disabling access_log at http level and enabling only for the main server block will ensure cleaner logs.
When an user adds a new website it doesn't have control over those server blocks via interface, so I think access log off globally is a smarter solution. I use this for ages now, and performance impact is high, logs are also cleaner.

For second part:

I also disagree with removing the default error log, and your justification for it. If someone is using custom nginx compilation, that is on them to realise that might collide with their own configurations they're using from this tool. They can just as easily change the error log name here.

It doesn't colide, it just overwrites the setting he choose to place in nginx compilation. Ultimately the setting from logging tab will win. Anyway, this error log setting from http level is not that important, but access_log off; is! Please think deeply before this decision, do some performance tests if you don't beleave it (of course it requires some high trafic to understand differences).

If user wants to enable access log globally this could be another checkbox in logging tab.

That is exactly what the PR already contains...

That is exactly what the PR already contains...

If you will take my advice and set access_log off; globally what the PR already contains would not enable access logs globally but only in that specific server block, which of course is the desired behaviour, but it wouldn't be globally! Please remember that there are like I said 3 to 5 extra server blocks for redirects, an user may want to enable access logs for those server blocks too (for testing purposes in development mode).

The PR contains a new option in the global logging section that allows the user to choose whether acces_log is set to off or a log path at the global level, as well as options in domain-specific logging sections for the same.

When I tested the interface that setting you mention it doesn't set access log off everywhere but only in that specific main server block. The server blocks like the following ones will continue to take their settings from the http level, which now is access_log /var/log/nginx/access.log;
server {
    listen                  443 ssl http2;
    listen                  [::]:443 ssl http2;
    server_name             *.example.com;

    # SSL
    ssl_certificate         /etc/letsencrypt/live/example.com/fullchain.pem;
    ssl_certificate_key     /etc/letsencrypt/live/example.com/privkey.pem;
    ssl_trusted_certificate /etc/letsencrypt/live/example.com/chain.pem;
    return                  301 https://example.com$request_uri;
}

# HTTP redirect
server {
    listen      80;
    listen      [::]:80;
    server_name .example.com;
    include     nginxconfig.io/letsencrypt.conf;

    location / {
        return 301 https://example.com$request_uri;
    }
}

This means that logs will filled with 301 redirects uselessly.

So what would you expect the global logging option to do when enabled then, if not logging these server blocks?
Would it make more sense if the domain-level logging options had a secondary set of options for the redirect server blocks?
And would it make more sense if the domain-level logging options had "on", "global", or "off", where "global" removes the domain-level access_log directive completely so it relies on the global directive in the http block?

@MattIPv4
First, at nginx.conf http level setting must be access_log off;. Always. No question about that, this will allow us to have grnullar control over access_log settings inside server blocks.
Secondly, the settings inside logging tab can be like this: option on and off, and if on is selected in addition to those text imputs where user customizes the path should be another checkbox enable access logs for redirects (disabled by default). And if user checks this last checkbox the app should put exact same directives inside secondary server blocks (those for redirects)

👍 That makes sense to me.
My only concern is that having any of this off by default is a breaking change for the tool, as the current default behaviour for any exported configuration is that access logging is enabled globally, to a single file (unless domain-specific logging was enabled).
We need to think about what can be done to map the existing settings to the new ones, and what defaults make sense to maintain as much backwards compatibility to for existing configurations as possible.
Perhaps by default, we'll need to ensure that all access_log paths at the domain level are set based on the old global.logging.accessLog, unless the domains.<id>.logging.accessLog boolean is true then they'd perform the domain substitution on the path. I think having access_log on by default for every domain would be for the best, to maintain backwards compatibility, but having the redirect blocks be off by default seems like a logical breaking change to make.

What's your view on error_log, should that still be a global option that can be overridden at the domain level, or should it just be at the domain level as well?

cc @kobim as this is your PR essentially being discussed (unsure why the conversation was started here rather than in your PR, but oh well).

@MattIPv4

I think having access_log on by default for every domain would be for the best, to maintain backwards compatibility, but having the redirect blocks be off by default seems like a logical breaking change to make.

Totally agree with this.

What's your view on error_log, should that still be a global option that can be overridden at the domain level, or should it just be at the domain level as well?

As I mentioned earlier I think the error_log setting is useless at nginx.conf http level, and it should be managed exactly as we plan for access_log (inside logging tab). However, there is a difference: error_log has no off option, it can only be configured using log levels. Therefore, IMHO there is no need to have custom configuration for redirect server blocks, existing nginx default would be good enough. And, the setting inside logging tab should strictly refer to main server block, allowing user to customize the path and log level.
Once this plan is realised I have one more new idea for logging, but first let's get this done.
Sorry about writing here instead the PR, should we continue there?


0.54.3 version does not take into account node roles when checking gateway.expected_nodes

After an upgrade to 0.54.3 on a cluster with 30 data nodes, 3 master nodes, and 1 client node with gateway.expected_nodes set to 33 I'm seeing an error in the crate-admin:
The value of the cluster setting 'gateway.expected_nodes' must be equal to the maximum/expected number of nodes in the cluster.

I'm nearly certain that any node which is client-only is not taken into account when gateway.expected_nodes is used by ElasticSearch.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30070019-0-54-3-version-does-not-take-into-account-node-roles-when-checking-gateway-expected_nodes?utm_campaign=plugin&utm_content=tracker%2F505663&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F505663&utm_medium=issues&utm_source=github).

@reversefold @joemoe The bug fix is going to be released 0.54.4 hotfix.

@reversefold can you confirm the fix in 0.54.4?

Looks ok in 0.54.4.


Unable to connect

Hello,
I can not setup successfully to the Beurer TL100
Can you help.
I do have the following log:
2023-12-21 23:06:55.683 ERROR (MainThread) [meross_iot.manager] Timeout occurred while waiting a response for message b'{"header":{"from":"/app/713917-4ff91d5cdd67bceefa86cfa3ac0ef0e6/subscribe","messageId":"f65a88821d768216b753efd4dbede6fe","method":"GET","namespace":"Appliance.System.Ability","payloadVersion":1,"sign":"d4f5582d3a12e7cd260f5d38122ea720","timestamp":1703196406,"triggerSrc":"Android","uuid":"2009302754750858850148e1e9351fa9"},"payload":{}}' sent to device uuid<PHONE_NUMBER>750858850148e1e9351fa9. Timeout was: 10.000000 seconds. Mqtt Host: mqtt-eu-3.meross.com:443.
2023-12-21 23:06:55.684 WARNING (MainThread) [meross_iot.manager] Device Puit<PHONE_NUMBER>750858850148e1e9351fa9) is online, but timeout occurred when fetching its abilities.
/bin/sh: /opt/vc/bin/vcgencmd: not found
2023-12-21 23:06:58.204 ERROR (SyncWorker_6) [homeassistant.components.command_line.utils] Command failed (with return code 127): /opt/vc/bin/vcgencmd measure_temp
2023-12-21 23:06:58.904 DEBUG (MainThread) [custom_components.beurer] Discovered devices: [BLEDevice(D4:AD:FC:70:00:A7, GBK_H61A0_00A7), BLEDevice(34:25:B4:DC:77:E1, GXDC77E1), BLEDevice(F4:05:8B:ED:5E:EB, Galaxy Watch Active (3FF5) LE), BLEDevice(BC:C7:DA:C0:C1:4A, TP358 (C14A)), BLEDevice(F0:99:19:BA:E5:4F, F0-99-19-BA-E5-4F), BLEDevice(E4:5F:01:11:08:5F, E4-5F-01-11-08-5F), BLEDevice(A6:D7:3C:96:70:32, XP-5200 Series), BLEDevice(7A:CE:94:65:54:1D, 7A-CE-94-65-54-1D), BLEDevice(5E:5F:BF:BC:42:F3, 5E-5F-BF-BC-42-F3), BLEDevice(57:4C:42:9E:A1:34, TL100_A134), BLEDevice(4A:E1:74:F8:5E:A2, 4A-E1-74-F8-5E-A2), BLEDevice(5E:7F:25:2B:68:72, 5E-7F-25-2B-68-72), BLEDevice(7E:17:C3:FA:E5:A5, 7E-17-C3-FA-E5-A5), BLEDevice(79:FB:2D:21:B0:B6, 79-FB-2D-21-B0-B6)]
2023-12-21 23:06:58.905 DEBUG (MainThread) [custom_components.beurer] Going to update from config flow
2023-12-21 23:06:58.905 DEBUG (MainThread) [custom_components.beurer] Going to connect to device
2023-12-21 23:06:58.909 DEBUG (MainThread) [custom_components.beurer] Going to connect to device
2023-12-21 23:06:58.945 DEBUG (MainThread) [custom_components.beurer] Traceback (most recent call last):
File "/config/custom_components/beurer/beurer.py", line 268, in connect
await self._device.connect(timeout=20)
File "/usr/src/homeassistant/homeassistant/components/bluetooth/wrappers.py", line 298, in connect
connected = await super().connect(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/bleak/init.py", line 605, in connect
return await self._backend.connect(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/bleak/backends/bluezdbus/client.py", line 249, in connect
assert_reply(reply)
File "/usr/local/lib/python3.11/site-packages/bleak/backends/bluezdbus/utils.py", line 22, in assert_reply
raise BleakDBusError(reply.error_name, reply.body)
bleak.exc.BleakDBusError: [org.bluez.Error.Failed] Operation already in progress
2023-12-21 23:06:58.946 ERROR (MainThread) [custom_components.beurer] Error connecting: [org.bluez.Error.Failed] Operation already in progress
2023-12-21 23:06:58.955 DEBUG (MainThread) [custom_components.beurer] Traceback (most recent call last):
File "/config/custom_components/beurer/beurer.py", line 268, in connect
await self._device.connect(timeout=20)
File "/usr/src/homeassistant/homeassistant/components/bluetooth/wrappers.py", line 298, in connect
connected = await super().connect(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/bleak/init.py", line 605, in connect
return await self._backend.connect(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/bleak/backends/bluezdbus/client.py", line 249, in connect
assert_reply(reply)
File "/usr/local/lib/python3.11/site-packages/bleak/backends/bluezdbus/utils.py", line 22, in assert_reply
raise BleakDBusError(reply.error_name, reply.body)
bleak.exc.BleakDBusError: [org.bluez.Error.Failed] br-connection-canceled
2023-12-21 23:06:58.955 ERROR (MainThread) [custom_components.beurer] Error connecting: [org.bluez.Error.Failed] br-connection-canceled
2023-12-21 23:06:58.959 INFO (MainThread) [custom_components.beurer] Was not able to connect to device for updates
2023-12-21 23:06:58.959 DEBUG (MainThread) [custom_components.beurer] Disconnecting
2023-12-21 23:06:58.959 WARNING (MainThread) [custom_components.beurer] No async update function provided: None
2023-12-21 23:06:58.963 DEBUG (MainThread) [custom_components.beurer] Finished updating from config flow, light is False
2023-12-21 23:06:58.964 DEBUG (MainThread) [custom_components.beurer] Turning on
2023-12-21 23:06:58.964 DEBUG (MainThread) [custom_components.beurer] Going to connect to device
2023-12-21 23:07:08.642 WARNING (MainThread) [custom_components.localtuya.common] [bfb...xpa] Failed to connect to <IP_ADDRESS>: [Errno 113] Connect call failed ('<IP_ADDRESS>', 6668)
2023-12-21 23:07:15.486 WARNING (event_thread_0) [sucks] Ping did not reach VacBot. Will retry.
2023-12-21 23:07:18.971 DEBUG (MainThread) [custom_components.beurer] Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/bleak/backends/bluezdbus/client.py", line 209, in connect
reply = await self._bus.call(
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/dbus_fast/aio/message_bus.py", line 399, in call
await future
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/config/custom_components/beurer/beurer.py", line 268, in connect
await self._device.connect(timeout=20)
File "/usr/src/homeassistant/homeassistant/components/bluetooth/wrappers.py", line 298, in connect
connected = await super().connect(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/bleak/init.py", line 605, in connect
return await self._backend.connect(**kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/bleak/backends/bluezdbus/client.py", line 146, in connect
async with async_timeout(timeout):
File "/usr/local/lib/python3.11/asyncio/timeouts.py", line 111, in aexit
raise TimeoutError from exc_val
TimeoutError
2023-12-21 23:07:18.971 ERROR (MainThread) [custom_components.beurer] Error connecting:
2023-12-21 23:07:18.972 DEBUG (MainThread) [custom_components.beurer] Going to connect to device

Abandoned project obviously


bin: pipe daemon stdout/stderr to log file, always log on stdout

As done in revaultd

ACK 0890358 -- trivial


Container starting is broken

Clicking the play button gives the message that the container is started, but it does not actually start.
A workaround is to redeploy with docker-compose, if there is a YAML file for the container.

Error message is:
"starting container with non-empty request body was deprecated since API v1.22 and removed in v1.24"

Error message is:
"starting container with non-empty request body was deprecated since API v1.22 and removed in v1.24"


invalid choice: 'simple_classification'

I am trying to use the fairseq toolkit for the first time and I have started from the ready tutorials. In the character level RNN example,i.e
https://fairseq.readthedocs.io/en/latest/tutorial_classifying_names.html.
I was able to perform the following steps :
1)Preprocessing the data to create dictionaries.
2)Registering a new Model that encodes an input sentence with a simple RNN and predicts the output label.
3)Registering a new Task that loads our dictionaries and dataset.
But when I try to train the model with the following command  I get an error :+1:
fairseq-train names-bin
--task simple_classification
--arch pytorch_tutorial_rnn
--optimizer adam --lr 0.001 --lr-shrink 0.5
--max-tokens 1000
The error that I get is as follows :
fairseq-train: error: argument --task: invalid choice: 'simple_classification' (choose from 'cross_lingual_lm', 'language_modeling', 'sentence_prediction', 'masked_lm', 'sentence_ranking', 'multilingual_masked_lm', 'audio_pretraining', 'translation', 'multilingual_translation', 'denoising', 'translation_lev', 'translation_moe', 'translation_from_pretrained_xlm', 'semisupervised_translation', 'legacy_masked_lm')
Apparently it seems not to be able to fetch the task. I checked and the simple_classification.py file is there at the right directory. What might be the cause of the problem? Thanks in advance and stay healthy!
I am running the code on Google Colab Notebook

Please follow the issue template.  Specifically, include which tutorial you are following, what command you ran, and a paste of the full backtrace and error you are seeing.

Hopefully the new information is enough !

How did you install fairseq?  do python -c "import fairseq; print(fairseq.__file__)" and ensure that it corresponds to the same directory your new task is in.

Since I am using Colab notebook,I do the following :
from google.colab import drive
drive.mount("/content/gdrive")
%cd "/content/gdrive/My Drive/Colab Notebooks"
!pip install fairseq
!git clone https://github.com/pytorch/fairseq
%cd fairseq
So the fairseq folder gets cloned into Colab Notebooks folder in my Google Drive. Thanks !

Sure, but the fairseq that you pip installed is different than the one that you cloned.  Instead of doing pip install fairseq, you should cd into your local checkout and run pip install --editable .

Thank you that solved my problem ! I spent 5 days on this small issue !

@redionxhepa can you put a screenshot  of the way in which you installed fairseq?

Place a init.py file in current directory.
For example:
root@DESKTOP-G1RK9R5:~#ls
__init__.py  __pycache__  checkpoints  names  names-bin  rnn_classifier.py  simple_classification.py
root@DESKTOP-G1RK9R5:~#cat __init__.py
from .rnn_classifier import FairseqRNNClassifier
from .simple_classification import SimpleClassificationTask

Train:
root@DESKTOP-G1RK9R5:~#fairseq-train names-bin   --task simple_classification   --arch pytorch_tutorial_rnn   --optimizer adam --lr 0.001 --lr-shrink 0.5   --max-tokens 100 --user-dir ./


fix(brigade.js): prevent token leak if github-release fails

We discovered that the utility used to create a GH release and upload binaries may leak the auth token in an error scenario, hence the need to filter the output.
Tested via intentionally setting one of the env vars that this tool uses to determine repo (GITHUB_REPO) to an invalid value and we see:
 $ k logs release-01dkcs3gpydtxyh9hhjan6jsp4
bash -c "LDFLAGS=\"-w -s -X github.com/deislabs/duffle/pkg/version.Version=0.3.2-vdicetest\" scripts/build.sh"
building linux-amd64
building windows-amd64
building darwin-amd64
error: github returned 404 Not Found
error: expected '200 OK' but received '404 Not Found' (url: https://api.github.com/repos/vdice/testfakerepo/releases?access_token=<REDACTED>&per_page=100)
error: expected '200 OK' but received '404 Not Found' (url: https://api.github.com/repos/vdice/testfakerepo/releases?access_token=<REDACTED>&per_page=100)
error: expected '200 OK' but received '404 Not Found' (url: https://api.github.com/repos/vdice/testfakerepo/releases?access_token=<REDACTED>&per_page=100)

Seemingly the github-release upload ... invocation is the culprit for the token leak, but I also added a filter to the preceeding github-release release ... invocation.
Additionally, I removed the || echo "release ${tag} exists" as it was rendered moot now that we pipe to sed and lose the return code, but this case/cause remains evident from the message returned from github-release, e.g.,
error: github returned 422 Unprocessable Entity (this is probably because the release already exists)

Related note: There is a fix in Brigade to properly set -o pipefail if the shell is /bin/bash so that these jobs will properly exit non-zero (with added pipeline usage): https://github.com/brigadecore/brigade/pull/982

@radu-matei can you review this fix when convenient?

/brig run

I've pushed an amended commit (rebase against master; no other changes) to re-trigger CI...


SVG Improvements Part I : group strategy

Hi all.
As Discussed with Tim, here is the first PR of a series of 3 ment to improve SVG rendering.
It changes the group creation strategy, by creating groups according to the PDF requests.
This one is a bit massive, but there was no splitting possibility. It is mandatory for the next PR that will introduce patterns & gradients.

Is there a public build containing your SVG fixes?  I'm happy to test them out across some of my PDFs and report back any errors.

@amit777
Yes,you may use the tool I made this work for here : www.qwi-tech.com/QDB
Simply drag & drop your PDF file on the window

Hello, Tim.
First, let me apologize about the several mistakes introduced when I rebased. I should have used a side by side compare tool when I resolved conflicts. I'm not experienced in PRing, and, as everybody, am always in a hurry.
Secondly, since many changes were made on the root, and even patterns and shadings introduced, I would say continuing on the PR series seems not to be the best strategy. I even wonder if it has any interest, since all this stuff was made around patterns & shadings... However, if you confirm your interest in this way to manage groups, I'm ok to do it on a new PR.
What is your position?

I thought about this a bit more and perhaps it's indeed better to leave this as-is for now since we don't really experience issues with the current code.
Even though another patch indeed introduced shading pattern support in the SVG back-end, we're still missing tiling pattern support which you already made. It would be great it we could extract that from your existing PR into its own self-contained PR so that it's easy to review and merge. It should hopefully be easy to move that code into the existing shading pattern code in a similar way: there is currently https://github.com/mozilla/pdf.js/blob/master/src/display/svg.js#L985 which could be replaced with a call like this._makeTilingPattern(args); that creates the tiling pattern. I think it should be a matter of introducing a new method that does that based on your existing work.
Finally, you also have an open pull request for blend modes, which we could integrate after the tiling patterns part. That's also still unsupported and it looks like you have also done practically all of the work there already, so I think that's also mainly about integration into the current master branch.
This way we could complete your work in two specific, self-contained PRs and close the current three PRs. If you need help with this, feel free to let us know. We're always happy to help out, especially since this is great work and I really feel that it should be merged into the codebase. If you don't have time to do that, we can just leave the PRs open and another contributor can take it over. Aside from those two feature PRs, you can always open issues for any problems that remain since I recall you mentioning that some of your PDF documents were not rendered correctly with the current code. If you do, please attach a sample PDF file so we can look into the issues one at a time. Thanks again.

Closing because of the comment above.


UI Fixes/Suggestions

Describing brief pointers for fixing some UI elements.
Landing Page:

The logo needs to be smaller in height
Fixing the uneven spacings and proportions of the graphics
Increasing the speed of the cloud animation
Start now button fix (padding needs to be less, spacing between the text and icon needs to be increased, hover effect suggestion: box-shadow: 0 0 0 0.25rem rgba(41,203,106,0.2);)
Footer padding to be increased from the top, footer font size to be decreased.

Chapters View:

"Back" button needs to be spaced from the corners of the window/media
Spacing between the chapter lists to be decreased, line separators can be thinned to probably 1px or 2px
Size of the seed to be increased
Width of the story text to be 80% of the container
Footer component to be added

Learning Interface:

outline: none for all buttons (referring to the back button)
Icons to be replaced by the svg icons on figma
Horizontal padding of the code interface buttons (and tabs) to be increased
Font size of the chapters overlay menu can be decreased

Completion View:

Proportions of the generated plant (needs a bigger head, front and back leaves should be the same)
Font weight of Success in all views to be thin (300/400)
Footer background colour to be matched with the design
Battle it out to have the same hover effect/styling as all the filled buttons (eg. start now on the landing)

Suggestion: These points can be changed to checklist type so that these can marked done by @AbhinavThukral97 after verification. This helps in tracking each point separately.

Footer background colour to be matched with the design

it should match the background color or the current figma designed footer footer background color ?

Footer background colour to be matched with the design

it should match the background color or the current figma designed footer footer background color ?

Footer Background from Figma

Icons to be replaced by the svg icons on figma

this issue is being handled separately in #51


Rename halodrops to pydropsonde

rename the package files and command line keyword to dropsonde
go over documentation and rename

added an automatic build test and renamed halodrops in the package
will add documentation again


Fix for 0.9.2. el.destroy() is now an official method and cannot be overriden.

Need to rename to like destroyKeyboard.

Keyboard is not working in Firefox for 0.9.2 even after renaming el.destroy() to el.destroyKeyboard().

Alphabetical keyboard is not appearing after switching from Symbols layout in Chrome.

@ngokevin Hey, how can i fix this problem on my side? I am on AFrame 1.3.0 and changed the this.el.destroy to this.el.destroyKeyboard in the aframe-material.js file, but now everytime my keyboard should open, the scene crashes. Do i need to change more than that, e.g. in the aframe-material.map.js?


Controls with debounce prop call change action after actions.reset when within componentWillUnmount

The Problem
If a control has a debounce prop and the field has a value, calling action.reset on componentWillUnmount will first clear
the model and field and then call change again populating the field and model with previous value.
This is basically issue #884 but since i cannot reopen the issue i thought i would create a new since its still a bug in latest version.
The original OP's codepen can be used to view the bug https://codepen.io/lstuartfry/pen/Pjvwrq
Let me know if i should create a PR with a fix
Thanks :)

@davidkpiano thanks for the quick fix but for some reason it doesnt seem that the fix has landed in 1.14.2
<EMAIL_ADDRESS>the above debounce in the lib directory doesnt seem to have the fix and i pulled it down locally with the same issue

@davidkpiano  can we maybe bump to 1.14.3 to ensure all new version have this fixed?

@davidchase I'll bump a new patch either today or tomorrow.

Ok thanks 👍🏻

Just checking back in on this, has a new patch been released?

@lstuartfry yes it looks like the latest version has patch
<EMAIL_ADDRESS>L17

@davidchase thanks for the update!


Create CODE_OF_CONDUCT.md

Had to alter.

I like green progress bars.  So I added this.


NonEmptyArray is not assignable to [A, ...A[]]

🐛 Bug report
Current Behavior
NonEmptyArray<A> is not assignable to [A, ...A[]].
Expected behavior
One should be able to use NonEmptyArray (and ReadonlyNonEmptyArray) with functions using the open-ended tuple syntax for their type constraints.
Reproducible example
import { NonEmptyArray, of } from 'fp-ts/lib/NonEmptyArray';

const foo = (arr: [unknown, ...unknown[]]) => arr;

foo(of(0));
//  ~~~~~
// Argument of type 'NonEmptyArray<number>' is not assignable
// to parameter of type '[unknown, ...unknown[]]'

playground
Suggested solution(s)
- export interface NonEmptyArray<A> extends Array<A> {
-    0: A
- }
+ export type NonEmptyArray<A> = [A, ...A[]];

Your environment
Which versions of fp-ts are affected by this issue? Did this work in previous versions of fp-ts?

Software
Version(s)

fp-ts
I don't know. NonEmptyArray2v  was introduced in 1.15.0

TypeScript
at least since 3.3.3

it wouldn't be bad to see this in fp-ts