[fix][broker] Delete unused param

Modifications
Delete unused param in removeReplicationClusters.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Closed. See https://github.com/apache/pulsar/pull/20866#discussion_r1277405212.

@Technoboy- @nodece may you do another check?


Subscribe the controller to the appropriate events

Fixes a very minor bug in the EnvoyDeployment controller, which was missing some watches over the child resources.
/kind bug
/priority important-soon
/assign
/ok-to-test

/lgtm

/approve


Minor modifications for PG catalog mapper script:

get per-database table size info: improved performance
report output reformatted to provide better readability
version bumped to 0.4

Awesome changes, thank you, Eugene!


PWA template don't work

Software version
Quasar: 0.14.6
OS: ubuntu 16.04
Node: 6.3.1
NPM: 3.10.3
Browsers: google chrome 60.0.3112.78 (64 bits)
iOS:
Android:
Any other software related to your bug:
What did you get as the error?
The service worker dont install on localhost.
What were you expecting?
The service worker dont install on localhost.
What steps did you take, to get the error?
Only install the template, run it, and apply the  light house.
The pwa template has any special care?

A PWA needs to be run on a webserver under HTTPS. The scores are close to 100 when generating the template and running in such environment.

Wait, in localhost is not necessary https.
2017-10-19 11:05 GMT-02:00 Razvan Stoenescu<EMAIL_ADDRESS>
Closed #13
https://github.com/quasarframework/quasar-template-pwa/issues/13.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quasarframework/quasar-template-pwa/issues/13#event-1301032908,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACs-SR-8AL6cILXNYIdn--2PtVR_eO62ks5st0kcgaJpZM4P-LVb
.

What I am telling is that the PWA requires https to install and work.
Running quasar dev won't install any web worker as that is soly for developing the UI.
What you need is to build the app then deploy on a https webserver.
Please read about PWAs to understand how they work.

https://developers.google.com/web/fundamentals/primers/service-workers/
During development, you can use service workers through localhost. However,
to deploy it to a site, you will need to have HTTPS installed on the server.
2017-10-19 11:16 GMT-02:00 Razvan Stoenescu<EMAIL_ADDRESS>
What I am telling is that the PWA requires https to install and work.
Running quasar dev won't install any web worker as that is soly for
developing the UI.
What you need is to build the app then deploy on a https webserver.
Please read about PWAs to understand how they work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quasarframework/quasar-template-pwa/issues/13#issuecomment-337904322,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACs-SfsMuN525PkNRVlUs2sUCqLlDD65ks5st0uSgaJpZM4P-LVb
.

What exactly is the issue you are encountering? Give a full detailed description of what commands you type and what you expect the result to be. Thanks.

I expected the least. start the template and everything provided work. I only run:
quasar init pwa folder
cd folder
npm install
npm run dev
But the service worker not install, and not throw errors. It's like a common template, without the features of pwa.

The service worker does NOT install while developing, because you do not need it. It also gets in the way with HMR, just to name one problem. Service worker is only installed on production build. Do a production build, deploy to a server with HTTPS and there you have it.

And as I know the features I put in it work?
2017-10-19 14:42 GMT-02:00 Razvan Stoenescu<EMAIL_ADDRESS>
The service worker does NOT install while developing, because you do not
need it. It also gets in the way with HMR, just to name one problem.
Service worker is only installed on production build. Do a production
build, deploy to a server with HTTPS and there you have it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quasarframework/quasar-template-pwa/issues/13#issuecomment-337966839,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACs-Se6PeTa_FOs6l70rLr38of0vzpOtks5st3vmgaJpZM4P-LVb
.

Not sure I understand your question. If you are referring to your app working as a pwa when built and deployed, then "yes". Develop it like any regular app and when deployed it becomes PWA.

No, You not understand my question, And as I know the features I put in it
work? I reference to service worker, by example.
2017-10-19 16:03 GMT-02:00 Razvan Stoenescu<EMAIL_ADDRESS>
Not sure I understand your question. If you are referring to your app
working as a pwa when built and deployed, then "yes". Develop it like any
regular app and when deployed it becomes PWA.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/quasarframework/quasar-template-pwa/issues/13#issuecomment-337989384,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACs-SU7B9geymqiDln-GBfVJHDdBpDYOks5st48DgaJpZM4P-LVb
.


Propose: Improve highlight API

For those finding there way here from the deprecation warning it's easy to upgrade your code:
// The old API:
highlight(language, code, ignore_illegals, continuation) {
// The new API take an options object literal:
highlight(code, { language, ignoreIllegals}) {

So to upgrade your code:
// before
html = highlight("vbscript","your code goes here", true)
// after
html = highlight("your code goes here", {language: "vbscript", ignoreIllegals: true })

IE, just switch the order of the arguments and pass language and ignoreIllegals in the options object now.

Advantages:

target of the verb [highlight] is now the first argument, which makes more sense, such as format(drive), highlight(code)
no need to remember order of the arguments
we can still support the old API for legacy (ie, non-breaking change)
fewer arguments are generally better (easier to understand, now at the call site you always see the names of the optional arguments, etc)

Checklist:

[x] new highlight API as shown above
[ ] highlightAuto -> highlight(code)
[ ] highlightAuto is deprecated
[x] highlightBlock -> highlightElement #3003
[x] highlightBlock -> deprecated #3003
[x] fixMarkup -> deprecated, will be removed with v11
[x] initHighlightingOnLoad -> highlightAll()
[x] initHighlighting -> highlightAll()

Yes, the suggested API looks better to my taste. But I can't see enough value in it to justify API breaking change.
Making it non-breaking - well, why not.

Any objection to:

highlightBlock -> highlightElement
initHighlighting -> start() or highlightAll()
initHighlightingOnLoad -> startOnLoad()

Both for clarity and simplicity.

start doesn't looks clear to me, highlightAll is better to my taste.

@allejo Any thoughts on these API naming changes? I think this was a topic before we added you to the team.

@allejo Any thoughts on these API naming changes? I think this was a topic before we added you to the team.

I agree with Egor where "start" isn't clear. I'd lean more towards:

highlightDOMElement or highlightDOMNode (I don't immediately think a DOM element if it's just highlightElement)
highlightAll
highlightAllOnLoad

I agree with Egor where "start" isn't clear. I'd lean more towards:

highlightDOMElement or highlightDOMNode (I don't immediately think a DOM element if it's just highlightElement)
highlightAll
highlightAllOnLoad

I don't like this highlightAllOnLoad vs highlightAll nonsense and forcing users to think about WHEN.  I think instead:
`highlightAll()` - just works, no matter when it's called (hooks onload, or if already loaded simply highlights)

A single API.

I don't like this highlightAllOnLoad vs highlightAll nonsense and forcing users to think about WHEN.  I think instead:
`highlightAll()` - just works, no matter when it's called (hooks onload, or if already loaded simply highlights)

A single API.

I think I'm going to leave highlightAuto for now since change that gets into issues with callback names and other things...

Would it maybe make sense to throttle logging the same deprecation messages? We're using highlight.js as a dependency of another dependency so can't directly update the deprecated code. The console is simply drowned in the exactly same deprecation message. Once would suffice, IMO, so we could alert the dependency to change it.

We may look into something like https://github.com/dougwilson/nodejs-depd#readme in the future.  I'll split your comment out into a new issue.  I like the idea of per-callsite warnings, not just singular logging.

Is it possible to use the continuation option in the new API?
https://github.com/highlightjs/highlight.js/blob/bfb5a59173719a9681e22f1979ad6656d68da78c/src/highlight.js#L122-L124

No.  What is your use case?

continuation is for internal use only and hence not supported any longer

Really it's always been for internal use.  It is not intended to be used for line-by-line highlighting (mentioned in the documentation) or "driving" the highlighter.  It will be removed entirely in v11 to allow us to more freely improve and iterate on the core highlighting engine.

@joshgoebel I also use the continuation in diff2html and this is my use case https://github.com/rtfpessoa/diff2html/blob/master/src/ui/js/diff2html-ui-base.ts#L165
Any alternative for me to upgrade?

Please see my answer on stack overflow. https://stackoverflow.com/questions/64280814/how-can-i-correctly-highlight-a-line-by-line-code-using-highlight-js-react
The Hexo author just implemented the "split HTML after it's rendered approach" and it was only 15 lines of code or so.  Anyone desiring the 'most stability' (from an API perspective) that would be the approach I'd recommend.

https://github.com/highlightjs/highlight.js/releases/tag/10.7.2 is released and throttles the deprecation messages if that would be helpful to anyone.

I appreciate the quick rundown on how to upgrade the code.

Write 手机维修app

Addyou mi too


Ability to disable warning "no department given for MethodLength. Run rubocop -a --only Migration/DepartmentName to fix."

It is very hard for my little brain to remember namespaces for each rubocop rule I disable.
It is much easier to write
  def parse value # rubocop:disable MethodLength

rather than
  def parse value # rubocop:disable Metrics/MethodLength

And it is so annoying to manually run in console rubocop -a --only Migration/DepartmentName.
Please add ability to disable the nasty warning.

RuboCop no longer supports ambiguous cop names (those without a department). As the namespace is actually a part of the cop name, this can't be changed.


fastrnaseq unit test failure

Hi guys, I'm seeing the fastrnaseq unit test fail for the latest development version on my VM:
./run_tests.sh fastrnaseq

integration/test_automated_analysis.py::test_2_fastrnaseq Running bcbio version: 1.1.6a
global config: /data00/bcbio/git/tests/test_automated_output/bcbio_system.yaml
flowcell directory: /data00/bcbio/git/tests/data/test_fusion
run info config: /data00/bcbio/git/tests/data/automated/run_info-fastrnaseq.yaml
[2019-08-14T15:57Z] System YAML configuration: /data00/bcbio/git/tests/test_automated_output/bcbio_system.yaml
[2019-08-14T15:57Z] Resource requests: picard; memory: 3.00; cores: 16
[2019-08-14T15:57Z] Configuring 1 jobs to run, using 1 cores each with 3.00g of memory reserved for each job
[2019-08-14T15:57Z] Timing: organize samples
[2019-08-14T15:57Z] multiprocessing: organize_samples
[2019-08-14T15:57Z] Using input YAML configuration: /data00/bcbio/git/tests/data/automated/run_info-fastrnaseq.yaml
[2019-08-14T15:57Z] Checking sample YAML configuration: /data00/bcbio/git/tests/data/automated/run_info-fastrnaseq.yaml
[2019-08-14T15:57Z] Testing minimum versions of installed programs
[2019-08-14T15:57Z] multiprocessing: prepare_sample
[2019-08-14T15:57Z] Preparing Test1
[2019-08-14T15:57Z] Preparing Test2
[2019-08-14T15:57Z] Resource requests: samtools; memory: 3.00; cores: 16
[2019-08-14T15:57Z] Configuring 1 jobs to run, using 1 cores each with 3.00g of memory reserved for each job
[2019-08-14T15:57Z] Timing: fastrnaseq
[2019-08-14T15:57Z] multiprocessing: run_salmon_index
Traceback (most recent call last):
  File "/data00/bcbio/development/tools/bin/bcbio_nextgen.py", line 4, in <module>
    __import__('pkg_resources').run_script('bcbio-nextgen==1.1.6a0', 'bcbio_nextgen.py')
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/pkg_resources/__init__.py", line 666, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1453, in run_script
    exec(code, namespace, namespace)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/EGG-INFO/scripts/bcbio_nextgen.py", line 245, in <module>
    main(**kwargs)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/EGG-INFO/scripts/bcbio_nextgen.py", line 46, in main
    run_main(**kwargs)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/pipeline/main.py", line 45, in run_main
    fc_dir, run_info_yaml)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/pipeline/main.py", line 89, in _run_toplevel
    for xs in pipeline(config, run_info_yaml, parallel, dirs, samples):
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/pipeline/main.py", line 286, in fastrnaseqpipeline
    samples = rnaseq.fast_rnaseq(samples, run_parallel)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/pipeline/rnaseq.py", line 14, in fast_rnaseq
    samples = run_parallel("run_salmon_index", [samples])
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/distributed/multi.py", line 28, in run_parallel
    return run_multicore(fn, items, config, parallel=parallel)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/distributed/multi.py", line 86, in run_multicore
    for data in joblib.Parallel(parallel["num_jobs"], batch_size=1, backend="multiprocessing")(joblib.delayed(fn)(*x) for x in items):
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 921, in __call__
    if self.dispatch_one_batch(iterator):
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 759, in dispatch_one_batch
    self._dispatch(tasks)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 716, in _dispatch
    job = self._backend.apply_async(batch, callback=cb)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/_parallel_backends.py", line 182, in apply_async
    result = ImmediateResult(func)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/_parallel_backends.py", line 549, in __init__
    self.results = batch()
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 225, in __call__
    for func, args, kwargs in self.items]
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/joblib/parallel.py", line 225, in <listcomp>
    for func, args, kwargs in self.items]
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/utils.py", line 55, in wrapper
    return f(*args, **kwargs)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/distributed/multitasks.py", line 75, in run_salmon_index
    return salmon.run_salmon_index(*args)
  File "/data00/bcbio/development/install/anaconda/lib/python3.6/site-packages/bcbio_nextgen-1.1.6a0-py3.6.egg/bcbio/rnaseq/salmon.py", line 149, in run_salmon_index
    assert file_exists(fasta_file), "%s was not found, exiting." % fasta_file
NameError: name 'fasta_file' is not defined
FAILED

Can confirm that this test passes for bcbio v1.1.5 on the same machine.

Thanks Mike, good catch. Fixed!

Awesome thanks Rory


Improve CLI performance

In the past, when working on generators, I found that ts-morph adds a lot of overhead as opposed to just writing files. If ts-morph needs to initialize the typescript AST, then it hangs for a bit. Maybe something to look into.

Thanks! I suspected ts-morph is the culprit too 😄. Maybe there are some features in it I can tweak.


Line chart can show on Mac but not on IPhone

I'm not sure if I did something wrong, but when I added fitGap and lineColor options to a line chart, it could not be shown on my IPhone, instead showing "error parsing YAML".
Can it be solved?

BTW thanks for making such a wonderful plug-in. It's my first day using it and I already know how much it'll help me in the coming years. I'm grateful. Keep up with the good work XD

Please check if there is any tab character in your code block.
They are not allowed in YAML.
I will do this check automatically in the next release.

Thanks for the feedback! I think you've pinpointed the problem! Yes, after changing the tab to spaces the codes were parsed on the phone!


Update Troubleshooting-Web-Application-Proxy.md

From: "...https://<FQDN_AD_FS_Proxy>/FederationMetadata/2007-06/FederationMetadata.xmlMake..."
To: "...https://<FQDN_AD_FS_Proxy>/FederationMetadata/2007-06/FederationMetadata.xml Make..."

Learn Build status updates of commit caff3e5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

WindowsServerDocs/remote/remote-access/web-application-proxy/Troubleshooting-Web-Application-Proxy.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@robinharwood
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team
#assign-reviewer: @robinharwood
#assign: @robinharwood
#remove-label:"review-team-triage"

Hello @robinharwood  and @JasonGerend, Could you review this change? Thanks!


Use Double instead of Float in the portable ChatOptions

The type of the portable chat options (frequencyPenalty, presencePenalty, temperature, topP) has been changed from Float to Double.
APIs, test, and documentation have been updated accordingly.

Fixes gh-712

lots of files, much appreciated.
merged in 4b123a751694de1088ad7adb5fcf7ca8ae7d334a


Measure can be overwritten by another in the queue

One way to partially protect against that is to check that no 2 measures with the same name and id are enqueued (if the save file name is defined using {meas_name}_{meas_id} then this will work).
This will have to be added to the InternalChecksHook.
Todo also: add in the documentation that one should use {meas_date}{meas_name}{meas_id} for the file name definition.

This belongs in ecpy repo.

Pffffffff that's true, sorry I'll move it


[Feature][WIP] Auto complete

Description

Filtering feature has been added where whenever use inputs a search term in the search bar, filtered data will render

Whenever use does not have any value in the input box, dummyData will render

Related Issues

Used toLowerCase() method to ignore case when filtering through the dummyData, would like to try implementing regex to solve this

Tests
I added the following tests:
no tests have been added
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] Run yarn test or yarn test -u if you need to update snapshot.
[x] Run yarn lint
[x] I am willing to follow-up on review comments in a timely manner.

Sorry about that, next time I will try to rebase it instead of merging it. Thank you for letting me know!


Switched env var in compose-prod to fix certs.

fixed prod update readme etc...

addresses #42

Changes look fine to me but need to pass CI. Some docs are failing the ruff checks but that wasn't from this PR, so not sure where that went wrong


Web UI not starting

Hello,
I'm already running CryptoTracker as seen on this terminal screenshot.

But I can't enter on http://localhost:5601/ .
The site can't be reached.
This port is configurable?
Thanks for this amazing work.
I'd try to contribute as soon as possible.

Yes, the port is configurable. Sometimes you need to wait a couple of seconds for Kibana to start. Given the information provided, this doesn't appear to be an issue on our end.

Ok!
Great. Thanks!


Tarpaulin not collecting coverage pakon-aggregator

Tarpaulin is failing to collect coverage for this test this may be due to the fact it wasn't designed to handle asynchronous code or could be due to some implementation detail of pakon-aggregator. Raising this issue to ensure this is investigated and remedied.

It seems this may not be an issue. Running from a cargo install gives different result to source. See below for output
cargo tarpaulin -f
warning: variant is never used: `NoData`
   --> src/keeper/aggregable.rs:125:5
    |
125 |     NoData,
    |     ^^^^^^
    |
    = note: #[warn(dead_code)] on by default

warning: variant is never used: `MissingColumns`
   --> src/keeper/aggregable.rs:127:5
    |
127 |     MissingColumns,
    |     ^^^^^^^^^^^^^^

warning: variant is never used: `NoData`
   --> src/keeper/aggregable.rs:125:5
    |
125 |     NoData,
    |     ^^^^^^
    |
    = note: #[warn(dead_code)] on by default

warning: variant is never used: `MissingColumns`
   --> src/keeper/aggregable.rs:127:5
    |
127 |     MissingColumns,
    |     ^^^^^^^^^^^^^^

Launching test

running 23 tests
test flow::slice::tests::flow_value ... ok
test flow::slice::tests::proto_flow ... ok
test flow::slice::tests::proto_time_close ... ok
test flow::slice::tests::proto_time_update ... ok
test flow::snapshot::tests::snapshot_decode ... ok
test keeper::aggregable::tests::in_time ... ok
test keeper::column::tests::endpoint_ident ... ok
test keeper::column::tests::endpoint_set ... ok
test keeper::column::tests::flow_ident ... ok
test keeper::column::tests::flow_value ... ok
test keeper::query::tests::query_deser ... ok
test keeper::tests::append ... ok
test reactor::downstream::tests::handle_conn ... ok
test reactor::tests::downstream_connect ... ok
test reactor::tests::signal ... ok
test reactor::tests::slice_feeder_smoke ... ok
test reactor::tests::upstream_forever_retry ... ok
test reactor::tests::upstream_reconnect ... ok
test reactor::upstream::tests::accept_version ... ok
test reactor::upstream::tests::basic_convert ... ok
test reactor::upstream::tests::refuse_version ... ok
test utils::tests::cmdline_parse ... aggregator 0.1.0ok
test utils::tests::log_init ... ok

test result: ok. 23 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Launching test

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Coverage Results
src/reactor/upstream.rs: 66/83
src/utils.rs: 63/79
src/keeper/mod.rs: 40/86
src/keeper/column.rs: 49/153
src/flow/snapshot.rs: 160/174
src/bin/pakon-aggregator.rs: 0/19
src/keeper/aggregable.rs: 52/68
src/reactor/downstream.rs: 38/47
src/tests.rs: 3/4
src/reactor/mod.rs: 163/226
src/flow/slice.rs: 214/280
src/keeper/query.rs: 23/31
src/flow/data.rs: 59/74

70.24% coverage, 930/1324 lines covered


Persistent EMR bulk import stack is misconfigured

The Persistent EMR bulk import stack causes Spark and YARN to conflict. Spark is running 16 cores per executor, but YARN thinks it is only running 1 core per executor. We need to identify better default configurations (possibly using https://aws.amazon.com/blogs/big-data/best-practices-for-successfully-managing-memory-for-apache-spark-applications-on-amazon-emr/) and make it easier to configure all the relevant options.

Fixed as part of https://github.com/gchq/sleeper/issues/51.


Hello issue listing new token

Hello i wanted to change my token but i din't know if i could delete the previous one so i just made a new one. Will it work?
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

this is my error : Build / build (pull_request) Failing after 1m — build

#17459


♻Replace MediaQuery components with proper CSS media queries

MediaQuery does not work well with SSR: website does not load as fast as it could and sometime blocks when rendering some parts.

Working on that!

Thanks @luizcieslak 🙏

@luizcieslak Do you have any question regarding this issue?

Hey @charlix! Sorry for the delay. Been going good but breaking some components. Gonna put an WIP here tomorrow so you can help me

@charlyx I see that in <OldMeetups /> you started this by using hideOnMobile nomeclature. Should I follow the same?

Sounds great @luizcieslak 👍

finished in #130!


Update README

Update the README to more accurately describe the application.

I also just made a few style changes to lighten the font weight of the note-preview divs in the left panel for consistancy/bc im neurotic.

Looks good, thanks Brenna!


Error ENOTEMPTY when deleting a directory recursively.

Sometimes, when deleting a directory that has sub-directories and files it throw an error witch code: ENOTEMPTY.
When executing this: rm('-rf', '/path/to/build/zip') the following error is thrown:

rm: could not remove directory (code ENOTEMPTY): build/zip/vendors/bootstrap

Note: It can happen with any sub-directory, is not related to a particular directory only. It doesn't happens with files.

+1 Seem to be getting the same error here on Windows occasionally. It's annoying becuase I'm running a pretty big test suite and the tests randomly fail because of this and I need to restart it every time until it eventually works.

I have changed the code block at https://github.com/arturadib/shelljs/blob/master/src/rm.js#L49 with this:
  var result, files;
  try {
    files = fs.readdirSync(dir);
    result = fs.rmdirSync(dir);
  } catch(e) {
    common.error('could not remove directory (code '+e.code+'): ' + dir, true);
    if (e.code == "ENOTEMPTY") {
      common.error('files found: ' + files.join(', '));
    }

And I can indeed see that there are some files left behind sometimes, randomly.

I think the only way to fix this on Windows is to auto-retry. I have found a library that doing exactly this here:
https://github.com/isaacs/rimraf

I made a pull request for this that auto-retries for up to 1 second on Windows. See #179

Closing this since #179 is merged. Please reopen if this error persists

For me, shx version 0.3.2 exhibits this same intermittent behavior when run from an npm script from within VSCode; when it fails, it fails immediately (no waiting for up to 1 second).  It would appear that the changes from https://github.com/shelljs/shelljs/pull/179 may have been lost.

I still see the changes:
https://github.com/shelljs/shelljs/blob/4e38240eda2f377e2219f61dcf53e8f9bff74c0a/src/rm.js#L53-L78
I don't know enough about this problem to know if the bug still exists though.


TemporalMemory bursting not working properly

While writing the Etaler API notebook. I found that the TM implementation is bursting when it shouldn't be.
 :(


Python TypeSpec not generating Stream API's

Python DPG is not generating API's who's response is a stream.  If the response body is of type bytes and the header is set to octet-stream then python dpg should treat this api's response as a stream.  Currently it does not and trys to json deserialize it.
@header contentType: "application/octet-stream";
@body content: bytes;
Sample of issue:
https://github.com/wiboris/BatchFileIssue
Teams Thread:
https://teams.microsoft.com/l/message/19:906c1efbbec54dc8949ac736633e6bdf@thread.skype/1674270493568?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1674270493568&teamName=Azure SDK&channelName=TypeSpec (Cadl) Discussion 🐮&createdTime=1674270493568&allowXTenantAccess=false

Updates after talking with @johanste

We're going to expose a stream keyword on all of our generated operations. If you pass in the stream keyword to a generated operation, it will stream the response back to you. issue tracking here
since you want an operation like what autorest has generated (i.e.a stream response is the only response), we can add a light layer of customization here like this example, and hard code the stream keyword to true and update the documentation
we'll continue talking amongst the cadl dpg crew about how to . we might have to add a new decorator in cadl-dpg because we cannot necessarily just look at the service API and correctly deduce that the client should stream the response back to the user. we did have that behavior in swagger, but that behavior wasn't necessarily correct.

update: this is the pr for step 1, will release tomorrow morning: https://github.com/Azure/autorest.python/pull/1777

Hi, do we have any updates on this issue?

Yep, apologies for not updating this thread, but the PR has been released. We still are not supporting operations that only return a stream, but now for operations returning bodies, you can always pass in stream=True as a keyword argument to that operation, and a stream will be returned. I'm going to close this issue because it's completed as of now, and will make a new issue if tsp / python end up supporting stream-only operations

Hi @iscai-msft, thanks for the reply. Does it means that we still need to patch the operation and set stream=True manually as Python DPG doesn't support to set it directly? Do we needs to patch it in other language as well?

Hi @iscai-msft , gentle ping

@wanghoppe yes, you should patch the operation to set stream=True manually, you can follow the code snippet I wrote earlier in this thread.
I'm not sure about other languages, tagging @joheredi @m-nash and @srnagar for help in other languages


html: attributes: add default to pop() and make del silent

Added the second optional argument to AttributeDict.pop. Now node.attributes.pop('foo', 'bar')=='bar' if there is no foo in attributes.
Now del node.attributes['foo'] do nothing if there is no foo in attributes. Before KeyError raised.

Codecov Report

Merging #50 (d21d372) into master (86650ac) will increase coverage by 0.29%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   32.06%   32.35%   +0.29%
==========================================
  Files          67       67
  Lines        4170     4160      -10
==========================================
+ Hits         1337     1346       +9
+ Misses       2833     2814      -19

Impacted Files
Coverage Δ

lona/html/data_binding/inputs.py
59.57% <0.00%> (+2.43%)
:arrow_up:

lona/html/data_binding/select.py
30.43% <0.00%> (+1.66%)
:arrow_up:

lona/html/node.py
53.40% <0.00%> (+0.55%)
:arrow_up:

lona/html/nodes.py
86.06% <0.00%> (+2.73%)
:arrow_up:

lona/html/attribute_dict.py
55.73% <100.00%> (+6.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86650ac...d21d372. Read the comment docs.

@maratori: But python dicts raise a NameError when attempting to delete a non-existing key.
>>> a = {'foo': 'bar'}
>>> del a['foo']
>>> a
{}
>>> del a['foo']
Traceback (most recent call last):
  File "/home/fsc/opt/python3/lib/python3.7/site-packages/rlpython/runtimes/python_runtime.py", line 211, in run
    return_value = run_code(code, self.globals, self.locals)
  File "<input>", line 1, in <module>
KeyError: 'foo'

I want AttributeDicts to behave like dicts and AttributeLists like lists

@maratori: I revert my earlier comment. AttributeLists and AttributeDicts should behave like the node properties in the browser. AttributeList.remove() does this already. So this attempt is completely valid

Thanks! :)


Error while path patching libc as one of rustc's dependencies.

Hello, i am trying to build rustc with patched libc. Patching via git works great until i try to patch libc using path, it prints this weird error message:

I could fix it with different methods, but then it would complain about, for example, freebsd11 inside of cfg attribute, which would be a error instead of warning propagated to error, i believe.
And cargo check in this directory doesn't emit any warnings.

If i understand it correctly, i was using cargo 1.61.0-beta.1 as a stage 0.

So i changed the stage0 rustc, cargo and rustfmt to nightly-2022-05-19, and that fixed it.

I guess libc isn't a problem, but stage0 compiler is.


added practice problems for programming and algorithms

I have added some problems in the programming and algorithms sections so that users can brush up on their Python programming skills with some data structures and Algorithms.

Looks good to me.
Merging👍


loosen peer dependencies; add npm prepublish script

Ideally we'd run linting and testing before publishing, however there are no tests and the project currently has numerous linting issues

Sure; I brought bid update to the code which removes all errors, now only warnings are left; plan to work on tests in the near future


Documentation is needed

@all-contributors please add @XadillaX for maintenance and code.

https://github.com/XadillaX/node-sfml/commit/8ded675172f6ec445b9177ea42b9e4cafeb4ac70


Fix: password input on login and signup pages

Describe the bug
The input element in div form-input for the password in login and signup is overflowing. This hides the bottom border of form-input.

Expected behavior
The border is visible properly and the height of the input element should fit inside the div form-input.
Screenshots

Device Information [optional]:

OS: macOS
Browser: Chrome
Version: 90

Are you working on this issue? (Yes/No)
Yes!

can i work on this issue? I'm on windows I can see the same bug too.

I want to work on this issue. Please assign this issue to me.

@ritika99 Can I please work on this issue?

@ritika99 Can I please work on this issue?

I want to work on this issue. Please assign this issue to me.

Hey @sonali-dudekula and @AshuKV
Thank you for showing interest. However, I have resolved the issue and waiting for the PR to be merged.


Error when running the configure script

Hi team,
I have been struggling to get past the ./configure step as I'm trying to build dnsperf from the GitHub repository. The exact error encountered is the following:
./configure: line 3938: syntax error near unexpected token 'disable-static'
./configure: line 3938: LT_INIT(disable-static)
When running echo $? straight after the configure script I get exit status error '2'.
It goes without saying that I have already installed all dependencies. The machine I am working with is ubuntu linux. These are the steps I took prior to getting stuck on the error above:
apt update
apt-get install -y libssl-dev libldns-dev libck-dev libnghttp2-dev autoconf libtool
git clone https://github.com/DNS-OARC/dnsperf.git
cd dnsperf
./autogen.sh
./configure  <-------------WHERE THE PROBLEM OCCURS
I went over the README file 4 times in case there were any other dependencies I had to install but I couldn't see any. Google searching did not help me much either.
Could you please help me with this?
Thanks in advance.

You're probably missing libtool.
From README:

dnsperf requires a couple of libraries beside a normal C compiling environment with autoconf, automake, libtool and pkgconfig.

I actually have libtool installed already along with the other ones mentioned and the issue continues.
Thanks anyway.

Hmm, what distribution and version is this on?
What versions of autoconf, automake and libtool?
Can you attach config.log?

If this is still an issue please provide the necessary information and reopen the issue, otherwise I can't help you.

FWIW, I encountered the same error under WSL2, and it was caused by a missing libtool.
Fixed by re-running the setup process:
sudo apt install libtool
./autogen.sh
./configure

@thebiss that is not the same issue since @nick22d said he already had it installed


Add (Azure) speech capabilities (STT / TTS)

Would be great to add (optional) voice capabilities to the sample app, based on a feature flag. Similar to what is currently available in the Azure OpenAI Playground.
Components

Azure Speech to Text (after click / hold on input button)
Azure Text to Speech (on streaming output, not just on the final answer)

Requires:

Azure Speech deployment
Back-end work to retrieve token (Managed Identity or Key) and pass a short-term access token
Environment variables to enable / disable voice, set voice configuration

Open discussion

How to set the input language, via environment variables or in the interface?
Should we use recognizeOnceAsync (one-shot) or continuous until user closes / a long pause is detected. Benefit of continous is that you can stream the input to the question field, where with one-shot you can only share the result.

If its helpful, the speech team contributed text-to-speech in a PR for our similar RAG repository here: https://github.com/Azure-Samples/azure-search-openai-demo/
The comments on that PR might also be helpful to see what developers have requested from the feature.


feat(disabled dates) Allow to disable specific dates (Datetime field)

Sometime need to disable specific dates like Booking/Schedule app. I think it will be good one.
Anyway, Thanks all your hark working and making it awesome.

Hey @saifulapm, thanks for opening a PR!
Did you accidentally close it?


Service scale error

I was trying to create docker registry service. I used command
docker service create --replicas=2 --mount type=volume,source=registry_volume,target=/var/lib/registry --name registry -p 5000:5000 registry:2

I cant push to it. the output of push command is:
The push refers to a repository [IP_ADDRESS:5000/ubuntu]
0cad5e07ba33: Pushing 3.072 kB
48373480614b: Layer already exists
055757a19384: Pushing 9.728 kB
c6f2b330b60c: Pushing 15.87 kB
c8a75145fcc4: Retrying in 12 seconds
blob upload unknown

In logs of service, I found "invalid token" message.
I'm running only one node
admin@test:~$ docker node ls
ID                           HOSTNAME          STATUS  AVAILABILITY  MANAGER STATUS
5p3p8ne3tx73411koav3ottce *  test.example.com  Ready   Active        Leader

And both services were successfully connected to one volume
admin@test:~$ docker inspect registry.2.bflv6ffg14grsar0qigxahfe0 | grep _data
                "Source": "/var/lib/docker/volumes/registry_volume/_data",
admin@test:~$ docker inspect registry.1.a59wwh4xjhzhz8t3hs290ojmx | grep _data
                "Source": "/var/lib/docker/volumes/registry_volume/_data",

I am running docker 1.12
admin@test:~$ docker --version
Docker version 1.12.1, build 23cf638

edit:
Scaling docker service back to 1 solves the broblem, so there is definitely no problem with "invalid token". It has to be something else...

The link to the logs you posted does not resolve to anything.
What do the registry logs show?

Thank you for helping me solve this problem.
So I deleted old containers and created new with debug level logging
service create --replicas=2 --mount type=volume,source=registry_volume,target=/var/lib/registry --name registry -p 5000:5000 --network ingress -e REGISTRY_LOG_LEVEL=debug registry:2

Now I can post whole log files. I have no idea what am I looking for... I haven't found anything suspicious. The problem persists though...

@frimdo Looks like you need to have the two instances share a secret. We can see this because of "error resolving upload: Invalid token" in the logs. The docs are here.

That was it. I feel pretty dumb. On one hand, the warning about same key is bold, on the other hand, I missunderstood the "invalid token" log message for some token authentication error. Maybe the message should say "invalid http secret" or something more exact...
Any way, thank you very much for your assistance.

That was it. I feel pretty dumb.

We all have our days. Don't feel dumb!
I agree that the "invalid token" log message is a little confusing. I've submitted #1945 to address this.


Fix chat navigation

PR Description

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/42153
PROPOSAL: https://github.com/Expensify/App/issues/42153#issuecomment-2120214640
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This bug happens only when we refresh, right? So, is it applicable for native apps?

This bug happens only when we refresh, right? So, is it applicable for native apps?

just made a test .. yes its not applicable for native apps.
now should i create two new components specifically for the web in both the ActiveWorkspaceProvider  and the BottomTab ?  or is there an alternative way ?

I think that is what we should do. Platform specific code within a single file is against guidelines.

Bump on this @abzokhattab

how is this going? @abzokhattab

Sorry @c3024 for the delay .. i had some problems running the problem on ios ..
The PR is ready.
Please let me know if you have any comments.

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

(Ooh, althought you've got conflicts now @abzokhattab, sorry!)

just merged into main again @NikkiWines

sike, conflicts again

ops ... just merged again @NikkiWines

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.82-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Hey, I noticed that we split the BottomTabBar into two files: .tsx and .website.tsx, with only two lines of difference between them. Could you explain the reason behind this decision, as it seems to make the codebase less maintainable?
If we've already split the ActiveWorkspaceProvider component, perhaps we should consider adding these changes to that component instead of splitting another one.
cc @abzokhattab, @c3024, @NikkiWines


Reorder release notes content for 7.3

PR Summary
Reorder release notes content for 7.3
PR Context
Moves Breaking Changes to top and Tab Completions to second position

Duplicate of #29


Problem with FSCollection.allow({download

Hi,
I am trying to get the userId of the logged in user in the allow/deny rules for download on an FS Collection. I have something like
FSCollection.allow({
  download: function(userId) {
    // use userId to determine if download should be allowed.

The userId is the value false. This happens for both allow and deny. I've looked at some of the example apps and they expect the first argument to be userId. I've dumped the arguments, see below.
-- SeamsImages.deny download arguments:  { '0': false,
I20150613-15:57:00.602(1)?   '1':
I20150613-15:57:00.602(1)?    { createdByTransform: true,
I20150613-15:57:00.602(1)?      _id: 'x9zDyXMBduRe9gGyk',
I20150613-15:57:00.602(1)?      original:
I20150613-15:57:00.602(1)?       { name: 'Girton_College,_Cambridge_-_geograph.org.uk_-_87878.jpg',
I20150613-15:57:00.602(1)?         updatedAt: Thu Aug 14 2014 10:14:05 GMT+0100 (BST),
I20150613-15:57:00.602(1)?         size: 407031,
I20150613-15:57:00.602(1)?         type: 'image/jpeg' },
I20150613-15:57:00.602(1)?      uploadedAt: Sat Jun 13 2015 15:57:00 GMT+0100 (BST),
I20150613-15:57:00.602(1)?      copies: { 'seams-images': [Object] },
I20150613-15:57:00.603(1)?      collectionName: 'seams-images',
I20150613-15:57:00.603(1)?      collection:
I20150613-15:57:00.603(1)?       { storesLookup: [Object],
I20150613-15:57:00.603(1)?         primaryStore: [Object],
I20150613-15:57:00.603(1)?         options: [Object],
I20150613-15:57:00.603(1)?         name: 'seams-images',
I20150613-15:57:00.604(1)?         files: [Object],
I20150613-15:57:00.604(1)?         _validators: [Object] },
I20150613-15:57:00.604(1)?      domain: null,
I20150613-15:57:00.604(1)?      _events: {},

Thanks
Rob

Did you solve this? im having the same issue here

+1. I'm also having the exact same issue. Seems like a bug.

+1. Same error.

@shividhar The problem was fixed using the auth token

@Ethaan Could you tell me how to use the auth token? Or point me to a resource.
Thanks a lot!

How to you generate the url for your file? if you use file.url({store: "yourStoreName"}) the auth token should be append to the url as far as I know

I'm having the same problem trying to use this in a package-based app. The auth token only works when an accounts package is included directly in .meteor/packages. If it's only used in another package, Accounts isn't defined when CollectionFS tries to use it to get the token.
Maybe one of the CollectionFS packages should api.use accounts-base, or it should check Package['accounts-base'].Accounts instead?

Thanks @aslagle

+1. same error, does anyone know how to fix this? I tried to use my own forked package and add api.imply('accounts-password') in many packages, as described in #665 , but the download in both allow and deny still have userId set to false (insert and update is working alright).
Please, cfs team, is there any way I can have contents protected to users, I think this is rather a basic feature to only serve uploaded images to logged in users (or some specific users).
Thanks for any help! Please I'm stuck for weeks.

+1 Also having this issue. A console.log(userId) inside the download part is always returning false.

Same problem here. since download always has a false userId, I can't really get any permission control there.
The problem for me is that I need to pass some files stored in mongodb to nodejs workers, using job-collection. So  I would like the worker to take the files from repo, and now I'm trying to pass them a url of the files.
@Ethaan and @shividhar , how did you manage to fix this using tokens? Using file.url()or  file.url({store: ...}) on server side I don't get a token.

+1
Anyone who solved this?


docs: fix headings incorrect id

Fix incorrect id in documentation for some h3/h4 headings, it causes sidebar to link on wrong item

Thank you!


Add component for redirects

Add a component that would cause client-side redirects to new addresses.

added the component, deployed via 0.1.11.

Works great.  Thanks! :)


0it [00:00, ?it/s] no output

There is no output and display "0it [00:00, ?it/s]" when I run the file "ctdet_image.py" with Pycharm. How can i figure it out please? Would you please give me some help please? Thank you very much.

I don't use Pycharm and thus can't help you with it :). The script didn't find the image(s) ->0it. Make sure you run it from the repo root dir (i.e. use keras_centernet/bin/ctdet_video.py) and that the image (s) exist.

Thank you very much for your reply.Further, I also tried running the net without pycharm, unluckily OOM error occurred. My GPU is Geforce 970M with 3G memory. Is it because that the hourglass net is too big, my GPU can not afford it?

I works with 4GB memory. Try the --inres 384,384 to reduce the memory usage. Good luck!

Yes, I also tried that size. The OOM error still exists. Thank you for your kindly reply.

@see-- Hello, I also use a 4gb gpu, but it is over to always create the tensorflow device, why?


add test image icon

@dmitrytokarev Take a look please, add test icon name for weather description. Tried to check lang of of description using library' langdetect'.

@09041985 build error:
E   ImportError: No module named langdetect
you need to add this lib to requirements.txt


Set value node not updating values for the current run

Dialogic version: rc_1.0, commit 853f991d8089777b9aff2607310c7251c04086da

Summary
When using Set Value node to change a variable definition, it only takes effect on the next run.

For example, in the above screenshot, if the initial value for test_value is 1 (set in the definitions tab)), then the if will be triggered, even with the Set Value node. If I check the definitions tab after the run, test_value is 0. If I run again, the if is not triggered as expected.
The bug might also come from the if node not reading the updated value, I didn't know how to test that.
The problem
What is the current behavior?
Set Value nodes updated values can only be used in subsequent runs.
What is the expected correct behavior?
Set Value nodes should update the value to be used in the current timeline, in the current run.
Maybe this is the correct behavior, but if it is the case it should be documented.
Thanks for this beautiful plugin, keep up the good work!

Yes! This one is realted to https://github.com/coppolaemilio/dialogic/issues/76
I'll get it fix before the official 1.0 release is done 👍

Thanks! I'll try to work around this issue for now. Do you have an idea when the 1.0 release will be out?

After a bit of testing, seems that the if node is the culprit. I did a simple test: set the value to 1, emit a signal, set the value to 0, emit a signal. In the signal callback, I simply print the value with Dialogic.get_var("test_value"), and the printed value is correct.

The log:
before
[{config:[ConfigFile:1910], name:test_value, section:1615828940-648, type:0}]
1
[D] Current Event: {definition:1615828940-648, set_value:0}
[D] Current Event: {emit_signal:after}
[!] Emitting signal: dialogic_signal(after)
after
[{config:[ConfigFile:1913], name:test_value, section:1615828940-648, type:0}]
0

Using this simple main script:
func _ready():
	var new_dialog = Dialogic.start('timeline1')
	add_child(new_dialog)
	new_dialog.connect("dialogic_signal", self, "_on_Dialogic_signal_received")

func _on_Dialogic_signal_received(value: String):
	print(value)
	print(Dialogic.get_var("test_value"))

Found a workaround:
In dialog_node.gd, event_handler function, condition branch, I added the line self.load_config_files() at the beginning of the branch to force definitions refresh. I haven't tested everything so I don't know if it breaks other stuff, but at least it fixes my issues with if statements

That's great! I'll test it out and see if I can push the fix to main. I'll be pushing a "runtime" fix so that variables reset when the game closes, so it will probably be pushed with that as well
Thanks!

@arnaudvergnet I pushed a commit with your load_config_files() fix and definition variables now reset from session to session. If you would like to save a game you have to provide the saving_id variable with the running_id from the previous session. I'll write a better tutorial/description on the documentation later on :)
Please confirm if this commit fixes your issues and thanks again for reporting!

@coppolaemilio I have errors when pulling the latest change:

When opening dialogic.gd

When opening DialogicUtil.gd

When opening DialogicSingleton.gd

I pushed a new update with a small fix, but for the errors that you are showing me it seems like you did not replace all the changes properly. Try removing the /addons/dialogic directory and replacing it with a fresh copy from main

I tried creating a new empty project from a fresh git clone/copy from main, and I still have these errors. Using Godot v3.2.3.stable. I can't even enable the plugin because of this.

I was able to reproduce the issue and I'm working on a fix right now

@arnaudvergnet pushed new changes, can you try again? https://github.com/coppolaemilio/dialogic/commit/6adb0e39e4cba8dd87f6ec4dd9faebcbd87184e3

Everything seems fixed now! Thanks, I will close this issue

thank you for your help!


Only call cancelAll once, not repeatedly the same for each order

I think the intention was to call cancelPerpOrder, but the cancelAll should only need to be done once
The issue is that we may be calling cancelAll here a lot if there are many orders that didnt get properly cancelled before


[BUG] Handling PNPConnection in a Runbook in Azure Automation

I've written a module using functions of PnP.PowerShell and uploaded that module to Azure Automation.
The installed version of PnP.PowerShell in Azure Automation is version 1.5.0.
I am handling the connection within a function of my module - example:
function Connect-PNP()
{
....
[OutPutType([PnP.PowerShell.Commands.Base.PnPConnection])
....
[PnP.PowerShell.Commands.Base.PnPConnection]$PNPConnection = Connect-PnPOnline -Url .... -ReturnConnection
return $PNPConnection
}
then within another function I call for example
...
$con = Connect-PNP
$null = Get-PNPListItem -...... -Connection $con
In an Azure Automation runbook this results in an exception "Invalid type". Seems like $con is an object - but not typed as [PnP.PowerShell.Commands.Base.PnPConnection].
Running the exact same code in a powershell (non administrative) on a client everything works fine - same module version.

there is nothing much we can do about this. PnP PowerShell does not recognize/nor have any understanding of the environment it runs in, and thus does not return different objects depending on the environment. It seems to be an Azure Runbook issue (that we are unaware of) but we do not control that environment. If it works on a client but not in a Runbook it seems to be more related to the Runbook environment than PnP PowerShell?

Hmmmm ....
Okay - I will open a ticket in azure.


MacOS (Silicon) F3D-2.3.0-macOS-arm64.dmg not launching with error "“F3D-2.3.0.app” is damaged and can’t be opened. You should move it to the Trash."

Describe the bug
A clear and concise description of what the bug is, a screenshot helps a lot.
To Reproduce
Steps to reproduce the behavior:

Open the file using f3d --dry-run example.glb
step 2
step 3

Expected behavior
A clear and concise description of what you expected to happen.
System Information:

OS:
GPU and GPU driver:

F3D Information
Paste the content of f3d --version:
Additional context
Add any other context about the problem here.

https://f3d.app/doc/user/LIMITATIONS_AND_TROUBLESHOOTING.html#macos

Great, thanks for the fast response!


Proxy support

I have a python grpc server and I want to use connect-web for my frontend. Is there anyway to use this package as a proxy for non-golang grpc servers?

Hey @mehdipourfar,
Unfortunately that functionality is not provided by connect-go. This library itself is more concerned with providing connect support for go specifically.
The behavior you're describing, however, will be provided soon by https://github.com/envoyproxy/envoy and there is an open PR up https://github.com/envoyproxy/envoy/pull/24836 that will add a bridge between grpc <-> Connect. In this case your backend will be able to continue using gRPC and envoy will be able to convert to Connect and vise versa, allowing you to use connect-web on the frontend.

Adding to @joshcarp's response: you could build a proxy using this package, but it would be quite a bit of work.
You're much better off starting with connect-web configured to use the gRPC-Web protocol. Run Envoy as a proxy for your Python backend with the gRPC-Web filter enabled (here's an example configuration). Your grpc-python server can remain unchanged. You won't get all the benefits of the Connect protocol, but you'll still be able to use protobuf-es and connect-web in the browser.
When https://github.com/envoyproxy/envoy/pull/24836 is released, upgrade your Envoy proxy to the new version. With the same configuration, it will be able to translate from the Connect RPC protocol to standard gRPC (just as it does for gRPC-Web today). At that point, you can switch your connect-web code to use the Connect RPC protocol. None of your application code will need to change, and you'll get all the debugging and ease-of-use benefits of the new protocol.
I'm going to close this issue - feel free to ping this issue or reach out to us in Slack if you have further questions!

Thanks for your information. It seems that your pull request has been merged. I'm using latest version of envoy-dev.
It seems to work for gprc-web. Since I'm not a frontend engineer, I'm using sonara as client for testing envoy proxy and it works fine.
But how can I test the connect protocol of envoy? I've tried to test it with a curl command like this which is burrowed from your README file:
curl \
    --header "Content-Type: application/json" \
    --data '{"sentence": "I feel happy."}' \
    https://demo.connect.build/buf.connect.demo.eliza.v1.ElizaService/Say

But envoy returns service unavailable status for requests that don't have Content-Type: application/grpc-web-text header.

@mehdipourfar You'll also need --header "Connect-Protocol-Version: 1". All the generated clients (connect-go, -web, -swift, and the upcoming -node and -kotlin) add this header automatically.
@jchadwick-buf can help if you have any trouble configuring Envoy properly.


Introduce EnableStrictNonDeterminismCheck worker option

What changed?
Adding a new option to slowly rollout non-determinism false positives fix #1281.

Why?
The strict non-determinism checks in #1281 may cause some existing workflows to fail due to the existing buggy non-determinism checks in task handling loop. So we need this option to control the phased rollout of the fix and keep the blast radius small.

How did you test it?
#1281 will be rebased with this change and testing will be done there.

Potential risks
N/A

since we'll be enabling this by default, we probably want this flag to be reversed, yea?
doing it gradually could work too (say over a couple versions), but that'd still need to change the name or type of the field, which we essentially can't do.

since we'll be enabling this by default, we probably want this flag to be reversed, yea?
doing it gradually could work too (say over a couple versions), but that'd still need to change the name or type of the field, which we essentially can't do.

We are not enabling by default. Default will be current behavior and we will explicitly enable this on low risk environments and gradually GA and then retire this option


How to test BlenderNC?

Here are my testing suggestions :

[ ] Unit tests using pytests for all non-interactive sections like data loading etc.
[ ] Integrations tests using a headless blender session + data + render calls to capture functionality
[ ] Coverage to measure completeness of testing

#74 Implemented Blender_NC_tutorial to load xarray.tutorial.load_dataset examples. In adition, blendernc/test/test_default.py can be executed to generate an image. The image can be generated by running (headless blender):
Blender --background --python ./test/test_default.py
WIP:

[ ] implement pytest to assert if the file is created after running the code.

#74 implements a test suit and coverage. I will leave this issue open to collect ideas on how to improve test and support in different blender versions.

[ ]  @whatnick suggested using GitHub matrix test to check using different blender versions.


Package Control on macOS doesn't list Okami

I get this message on the latest Sublime 3
Package Control: The package "Okami – Adaptive Color Schemes" is either not available on this platform or for this version of Sublime Text

Which operating system do you run Sublime Text 3 on? Also, could you tell me your Sublime Text build version number?

macOS 10.13.6
Sublime v3. Build 3175


repackage Qt installer script code.

The separation of the bash shell code and the Qt Installer script
code allows the later to be used in environments were bash is not
available.  This was implemented with key,value pairs passed on
the command line, but it could have been done with environmental
variables using the installer environmentVariable method instead
of the value method.
add Qt 5.12.5 to regression.
add windows test cases to regression.  You can see how the installer script
code can be passed directly to the installer.  Even though the travis test case uses bash
in the yml file the separation of the script allows the installer and script to be used when bash isn't available.
add support for installs on windows, which have a unique page, see Controller.prototype.StartMenuDirectoryPageCallback
add support for new usage stats page, see Controller.prototype.DynamicTelemetryPluginFormCallback.
Recent installs with the online installer would fail due to this new page.
See https://www.qt.io/blog/option-to-provide-anonymous-usage-statistics-enabled.
Delete unused function in Qt installer script (abortInstaller).

This resolves #30

WRT the check failure we see a low level of intermittent failures on travis jobs, most unrelated to qtci.  If you restart 170.18 it will very likely pass.  It passed in my fork (https://github.com/tsteven4/qtci/runs/295689094)
To review the changes it helps to manually compare qt-install.qs with the previous extract-qt-installer.  Most of the differences are whitespace cleanup.  I ran js_beautify to clean up inconsistencies with both the size of indents and tab vs. whitespace indents.  The remaining differences are discussed above.

hello everyone!
@tsteven4 have you recently tested your branch? i'm getting a [3051] QTCI:  Retrieving meta information from remote repository hang after logging in...


Extend service

Continuation of #27

@nicokant going to merge this into main - but happy to carry on the conversation to make it work well!

Hi, I took a quick look at the code and everything seems fine, but I hadn't the chance to actually test it.
It seems definitely an improvement, if anything comes up I'll open an issue!


ci, don't use pyenv and install pip3 using apt

That's interesting, the python version is actually not compatible with Meson but otherwise this would work.
Pyenv is actually noy needed.
In the meantime i tested building at Semaphore which works fine but they don't allow config file.
Shippable looks more promising, let's say in case we would decide to make the Meson CI tests elsewhere.


handle filePath with spaces in url

I was not able to build/run the fake file due to a git issue on my pc, but I am fairly sure this will fix the issue. if it does not i will keep trying to fix the git issue.

Git issue is probably SSH key issue, following https://help.github.com/articles/generating-an-ssh-key/ should be enough to get it working

I was going to ask about that. Why not use https for the git deps? It's what I did locally to make it build. Would probably make it easier for would-be contributors.

That's reasonable suggestion. I'll change that in some free time... or we accept PRs ;)

I changed paket to use https and how I get this error. Pretty Ironic.
I will move the code to a different workspace and push the pr if it works.

Message: Could not run "git clone file:///C:\Users\FAISAL ALFADDAGHI.paket\git\db\FSharpFormatting.CLI".
Error:
Cloning into 'ALFADDAGHI.paket\git\db\FSharpFormatting.CLI'...
fatal: 'C:/Users/FAISAL' does not appear to be a git repository

got the project building and my fix is away off i will keep trying .
I am going to close this pr


Update message_view_header.js

fix Popover do not hide when clicked on buttons
Hi, I just fixed this error mentioned in #24318

Hi @Mila055, It is always great to check if there is an already open PR for an issue and ask the author if they're still actively maintaining the PR. For this one, I created #24338 which is yet to be merged.
Looks like you are a new contributor, giving guide for new contributors a read would be great.

Closing this PR as it does not follow our guidelines for PRs and commit messages, and https://github.com/zulip/zulip/pull/24338 is in integration review.


chore(tests2png): add first version of PNG diagram generator

Build Jasmine helper that detects tests tagged with asDiagram() and runs a painter script to create
a PNG marble diagram out of them.
First attempt at resolving #697.

Seems travis is not happy with changes - is this PR work in progress?

Now passing tests.

Does images supposed to be checked in, or to be generated on each local machine?

Does images supposed to be checked in, or to be generated on each local machine?

I don't know, that's up to us. What do you suggest? They could be generated at the same time docs are generated. Primary reason why I checked them in is to show how the diagrams look like, for review. :)

This is now feature complete. It generates diagrams for the trickiest cases:
Cold observables that start emitting after a while has passed

Observable of Observables as input

Observable of Observables as output

When this is merged, all we need to do is add it.asDiagram(label) test cases to all operator spec files.

They could be generated at the same time docs are generated.

: Think this makes sense, doc could include this diagrams so doesn't require to generate it manually per each users.

WOOO! That is some fancy work, @staltz

:)

@kwonoj images removed from git, and fixed that // commented line.

I'll try to look in detail around tomorrow, stuck in bed with flu all day.

I'll try to look in detail around tomorrow, stuck in bed with flu all day.

Yuck. Get better.

@staltz can you rebase?

@blesh Rebased.

@staltz I've pulled it down and tried it out. It definitely works.
I ran into a couple of issues I think we should address in this PR though:

I didn't know what "imagemagick", "graphicsmagick" or "ghostscript" were or how to install them. I figured it out eventually (used brew), but we'll need to have that part documented.
I still don't really know how it decides which tests to make PNGs from. How is this configured? Can O do anything ad hoc with it?
it wrote to img/ and that's fine, but it should probably be in .gitignore.

Overall a VERY COOL PR!

I still don't really know how it decides which tests to make PNGs from. How is this configured? Can O do anything ad hoc with it?

I can write down how to configure a test to be converted to a PNG. But the general case of ad hoc generating PNGs is not supported. If it would, it would make sense to make that a separate library.

@blesh some few commits added to fix issues you mentioned.

Tests failing just because markdown-doctest doesn't recognize it() from Jasmine and prefers to blow up.

@Widdershin how I configure .markdown-doctest-setup.js? Do I need to require Jasmine or can I somehow mock it() calls?

@staltz You could probably do either, but my instinct is just to mock it out.
If you add something like this to .markdown-doctest-setup.js:
const it = {
  asDiagram: function (name) {
    return function (label, callback) {
      callback()
    }
  }
}

And then add it to the exported globals object:
  globals: {
    ...
    it: it
  },

That should do the trick. Does that make sense?

Hmm, I'll try that! Thanks!

@blesh I fixed the markdown-doctest. Maybe now it's good to merge.

Awesome stuff @staltz! Merged with 30a6214
🎉🎉🎉

Woot!!!
I'll start going wild by making diagrams for all operators :)


Feature/fix md linter

@jenweber This PR fixes remaining linter warnings. I had to add images as well to fix warnings, that being said, we probably need to update this screenshots as they look unfashionably outdated.

@aklkv are you able to take new screenshots?

@locks sorry I am on mac computer :) I can sip up VM but I will take some time tho, it might be easier to ask some one with windows machine


Day 12 Content

Select the Day of Content
Day 12
What information is missing?
I would like to add 'Recursion' under Day 12.
Kindly assign this issue to me under gssoc'24.

@subhadipbhowmik please assign the issue.
And since recursion in itself is too vast I request u to put a level 2 tag.


Policy Plugin: delay closing connection to PDP

The problem is that coredns continue validating DNS queries (queries in progress) at the moment when restart event is fired. In restart handler we close connection to PDP and coredns returns SERVFAIL for the remaining queries because of lost connection to PDP.
My fix allows the remaining queries to complete successfully

The fix still doesn't work for all cases. Even worse it makes an issue harder to catch while testing and debugging leaving chance to get it in production. Additionally, resources allocated for connection are held for 30 seconds more after each restart. Having ability to get 1 restart per 5 seconds we can have 6 copies of pdp client alive.


[FIX] rename cast expression column name

Which issue does this PR close?

None.
Rationale for this change

This problem origin from https://github.com/dask-contrib/dask-sql/issues/948, which can be minimally reproduced by
SELECT 10, cast(10 as tinyint)

And this is because

cast use the expr as column name

https://github.com/apache/arrow-datafusion/blob/224c682101949da57aebc36e92e5a881ef3040d4/datafusion/expr/src/expr.rs#L1203-L1210

same column name is not validate

https://github.com/apache/arrow-datafusion/blob/224c682101949da57aebc36e92e5a881ef3040d4/datafusion/expr/src/logical_plan/builder.rs#L925-L948
There are two solutions:

rename cast expression
remove the unique column name validation

I choose the first way to pass these cases, by using CAST(Int64(10) AS Int8) instead of Int64(10).
What changes are included in this PR?

As above.
Are these changes tested?

Yes.
Are there any user-facing changes?

Yes. Because column name chage for cast expression.

https://github.com/apache/arrow-datafusion/issues/5174


npm 5.3.0 throws 404 Not Found: @uirouter/angularjs@latest

This issue tracker is for Bug Reports and Feature Requests only.
Please direct requests for help to StackOverflow.  See http://bit.ly/UIR-SOF for details.
This is a:

[x] Bug Report
[ ] Feature Request
[ ] General Query

My version of UI-Router is: latest
Bug Report
Current Behavior:
npm install --save @uirouter/angularjs
npm ERR! code E404
npm ERR! 404 Not Found: @uirouter/angularjs@latest
npm ERR!      /Users/oscar/.npm/_logs/2017-08-10T14_21_37_615Z-debug.log
Expected Behavior:
added 1 packages in 1s
Could you please, help me? I want to migrate to npm instead bower

I guess it's a duplicate of #17966

This just started happening again


add ftp

It would be really great if you added ftp packages as autoparts

would totally need that too :)
anyone tried this?
https://github.com/codio/boxparts/commit/ededaf11550075f267d84500fd92353e3bcc57c2


Sampler cannot deal with Direction

SamplerData.getUnit() aims to retrieve an "SI" field, which is not available for Direction.

It appears not all unit classes have an SI field. In that case, the field DEFAULT is used instead.


fixed bug when class extends class with private fields

Description:
this adds support to handle the case when you have a class extending another class private fields
Related issue:
this finally closes #630

rebasing :)


Simplify _app.js example

Haha I'm not a member and I can review it. @sandrinodimattia careful with that! :smile:


UNable to authenticate or pull metrics from a Saas controller

Error encountered during dexter run.
To Reproduce
Steps to reproduce the behavior:
See my log files and we can set up a webex as controller credentials are required to reproduce.
Expected behavior
Metrics/Report data pulled from controller.
Screenshots
AppDynamics DEXTER Version <IP_ADDRESS>
Executing:
ProgramOptions:
InputJobFilePath='Report2.json'
InputJobFilePath=''
RestartJobFromBeginning='False'
OutputFolderPath=''
OutputJobFolderPath=''
OutputJobFilePath=''
ProcessSequentially='False'
ProgramLocationFolderPath=''
CompareFilePath=''
ReferenceJobFolderPath=''
DifferenceJobFolderPath=''
SkipVersionCheck='False',
JobName='',
RequestIDs='',
ReportFolderPath=''
Version check against Github releases
Running ETL workload
Checking input ETL job file C:\Users\rs789y\Desktop\AppD-ReportingTool\appdynamics.dexter-full-win-20.8\Report2.json
Parsed MarkDate 'TODAY' as '2021-03-25T04:00:00.0000000Z', local '2021-03-25T00:00:00.0000000-04:00'
Parsed MarkTime 'PREVIOUS_HOUR' as '2021-03-25T14:00:00.0000000Z', local '2021-03-25T10:00:00.0000000-04:00'
Parsed Duration '1:00:00' as '01:00:00'
DateTimeMark '2021-03-25T14:00:00.0000000Z', local '2021-03-25T10:00:00.0000000-04:00'
DateTimeMarkPlusDuration '2021-03-25T15:00:00.0000000Z', local '2021-03-25T11:00:00.0000000-04:00'
UTC Input.TimeRange.From='2021-03-25T14:00:00.0000000Z' to Input.TimeRange.To='2021-03-25T15:00:00.0000000Z'
Local Input.TimeRange.From='2021-03-25T10:00:00.0000000-04:00' to Input.TimeRange.To='2021-03-25T11:00:00.0000000-04:00'
Creating output folder C:\AppD.Dexter.Out
Creating job output folder C:\AppD.Dexter.Out\Report2.202103251400.1
Processing input job file to output job file
Target 1 https://dtv.saas.appdynamics.com/.* [APM] as sukovichr@dtv with Regex=True
Target 1 property UserPassword is empty
Enter Password for user sukovichr@dtv for https://dtv.saas.appdynamics.com:

Target [1] Controller ControllerApi: ControllerUrl='https://dtv.saas.appdynamics.com', UserName='sukovichr@dtv' not accessible
Job File Problem: Expanded targets but not a single valid target to work on
This is most likely caused by either incorrect password or incorrectly specified user name (see https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Job-File#username-string).
Only AppDynamics-internal authentication is supported in username@tenant format
If you are using SAML or LDAP account, please change to AppDynamics-internal account
If you have proxy, consult https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Proxy-Settings to configure access
Check Controller Log Files (https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Log-Files) for more detail
If you need support, please review https://github.com/Appdynamics/AppDynamics.DEXTER/wiki#getting-support and send the logs
Application execution took 00:01:26.0426409 (86042 ms)
Desktop (please complete the following information):

OS: Windows 10 Ent version1909
.NET Framework Type (Full/Core) "appdynamics.dexter-full-win-20.8"
.NET/.NET Core Framework Version "appdynamics.dexter-full-win-20.8"

Logs
logs-dexter.zip
Reports
Report2json.txt

Hi there
Looking in Controller log, your controller is not reachable:
2021-03-25 13:49:49.2374|Error|AppDynamics.Dexter|30728|1|AppDynamics.Dexter.ControllerApi|https://dtv.saas.appdynamics.com/controller/rest/applications?output=JSON GET as sukovichr@dtv threw One or more errors occurred. (mscorlib)
2021-03-25 13:49:49.2374|Error|AppDynamics.Dexter|30728|1|AppDynamics.Dexter.ControllerApi|System.AggregateException: One or more errors occurred. ---> System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The underlying connection was closed: An unexpected error occurred on a send. ---> System.IO.IOException: Unable to read data from the transport connection: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. ---> System.Net.Sockets.SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond

Are you behind some sort of proxy? If yes, consult https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Proxy-Settings

The logs show timeouts accessing your controller
2021-03-25 13:49:49.2374|Error|AppDynamics.Dexter|30728|1|AppDynamics.Dexter.ControllerApi|https://dtv.saas.appdynamics.com/controller/rest/applications?output=JSON GET as sukovichr@dtv threw One or more errors occurred. (mscorlib)
2021-03-25 13:49:49.2374|Error|AppDynamics.Dexter|30728|1|AppDynamics.Dexter.ControllerApi|System.AggregateException: One or more errors occurred. ---> System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: The underlying connection was closed: An unexpected error occurred on a send. ---> System.IO.IOException: Unable to read data from the transport connection: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. ---> System.Net.Sockets.SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond

Are you behind some sort of proxy? If yes, check https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Proxy-Settings

Seems to be running now. I just plugged the value for the proxy from IE into the config file.
Thanks Daniel!
First time using this extension BTW.


Package request: dpc++/c++

Project description
Intel oneAPI DPC++/C++ Compiler
Refer: ArchLinux
Related packages:

mkl
intel-ocl
intel-compute-runtime

Metadata

homepage URL: https://software.intel.com/content/www/us/en/develop/tools/oneapi.html
source URL: https://apt.repos.intel.com/oneapi/pool/main/intel-oneapi-dpcpp-cpp-2023.1.0-2023.1.0-46305_amd64.deb
license: unfree
platforms: unix, linux, darwin

I am currently trying to make intel extension for pytorch work and therefore also tried to package dpcpp. I am not really confident that it is fully functional and I am quite unsure about the license and its implications in distributing it via nixpkgs, but if anyone want so collaborate here is what I got so far: https://github.com/MordragT/nixos/tree/master/pkgs/intel-packages. You can try it out with my overlay under intelPackages.env.mkDerivation

Before it is accpeted to nixpkgs, can it be published to NUR?


ECTC/ECATT: abapGit CI failed - diff

Demo repo
https://github.com/abapGit-tests/ECATT.git

Error occurs only if abapGit CI runs in background. Then local xml diffs.

Works with 754 SP 7 and latest abapGit


Fix Icon Support for Shortcut Creation

Issues this PR tries to resolve
Resolves: https://github.com/ChrisTitusTech/winutil/issues/2241
Screenshot(s)

If we are already trying to fix the multiple requests to the same image, I would suggest modifying:

the Snipped I added in #2196.
The Logo from inputXML.xaml

If we are already trying to fix the multiple requests to the same image, I would suggest modifying:

the Snipped I added in #2196.
The Logo from inputXML.xaml

Thanks for pointing these issues out @MyDrift-user
Thankfully, and after some luck, I'd solved these issues some time during this day (when initially working on this PR), but I haven't pushed & made a PR for it.
Will try and compose a new PR that will provide a base system for managing resources and, in particular, images.