[FEATURE REQ] Get topicHostname from BaseUri in EventGridClient

Library or service name.
Microsoft.Azure.EventGrid
Is your feature request related to a problem? Please describe.
When publishing events using EventGridClient the PublishEventsAsync method requires topicHostname to be provided, however it's possible to determine this from the internal BaseUri attribute which is set at initialization so providing this argument is unecessary.
Would it be possible to add an overload of the PublishEventsAsync and PublishEventsWithHttpMessagesAsync methods that doesn't require the topicHostname argument but instead sets this from the BaseUri?
e.g. topicHostname = new Uri(BaseUri).Host;
I think this is the relevant code where the change would be required.
https://github.com/Azure/azure-sdk-for-net/blob/9d671143f4d54be7c02aeddc8e0ad99037236793/sdk/eventgrid/Microsoft.Azure.EventGrid/src/Generated/EventGridClient.cs
Thanks

Thank you for your feedback.  Tagging and routing to the team best able to assist.

//fyi - @ellismg, @JoshLove-msft

Thanks.
This would essentially involve adding the following overload to EventGridClient and updating IEventGridClient and EventGridClientExtensions accordingly.
public async Task<AzureOperationResponse> PublishEventsWithHttpMessagesAsync(IList<EventGridEvent> events, Dictionary<string, List<string>> customHeaders = null, CancellationToken cancellationToken = default(CancellationToken))
{
	string topicHostname = new Uri(BaseUri).Host;
	return await PublishEventsWithHttpMessagesAsync(topicHostname, events, customHeaders, cancellationToken);
}

Hi @mattosaurus!
You're correct that this is an unfortunate pattern we have in the existing SDK, however, I'm not certain that your proposed change will behave the way we want.  While you are correct that BaseUri is initialized when the client is created, it's initialized to a fixed value, which is the string: "https://{topicHostname}".  Note that this is a literal string, and not an instance of a interpolated string which is putting in the value of some topicHostname parameter.
This is used as the basis of forming the actual URL for the service, by replacing {topicHostname} with what was passed into the PublishEvents.... method.  I believe in your proposed code we would end up trying to construct a Uri from the string https://{topicHostname} and that will fail, because it is an invalid URI.  Even if it were to succeed, the Host property would return some fixed value like {topicHostname} and not the name of your actual event grid topic.  Because of this, I don't think we can make a simplification here.
However, we are in the process of creating a new Event Grid SDK which follows our new Azure SDK Design Guidelines for .NET and as part of that work, we now take the endpoint url of the topic as a parameter when you construct the client vs when you publish the event.
You can see the shape of the new API here and in fact all of the work we're doing is being done in GitHub right now (please forgive the templated README.md, it will be updated to something real shortly).  In addition to cleanups like this we're adding support for publishing events in the Cloud Events 1.0 schema, which the existing SDK does not support.
If you have any additional feedback on the SDK, the team would love to hear it.  As I mentioned above, we're in the process now of doing this work with the hopes of releasing a preview release in September to get additional feedback, but if you have additional feedback now we can work to incorporate this in the design.
I'm going to close this issue because I don't think there's a low cost way for us to take the improvement.  We would need to add additional constructors to EventGridClient or some other way to set the topic host name so we could use it when you go to send and event.  We'd rather spend our development effort on the newer SDK which we believe fixes this wart and is in general more approachable while at the same time adding new features like Cloud Event support.  But it's possible I've misunderstood your suggestion, in which case feel free to respond or reopen it.
By the way, if you have additional feedback on EventGrid (either sending or processing events) you'd like to share with us feel free to let me know.


[Question] Regarding sequence length value for numerical features

I am trying to modify the example given in documentation for stacking numerical features. I have a large amount of data and so I am using pandas to read the file before using the code.
(https://kashgari.bmio.net/advance-use/handle-numeric-features/)
here is a few lines of my code (not in sequence)
train_df = pd.read_csv(TRAIN_CSV)
train_df.head()

bert_embedding = BERTEmbedding(bert_model_path,
                               task=kashgari.LABELING,
                               sequence_length=10)

tokenizer = bert_embedding.tokenizer
sentences_tokenized = []
for sentence in train_df['text'].values:
    sentence_tokenized = tokenizer.tokenize(sentence)
    sentences_tokenized.append(sentence_tokenized)

tokenized_text_list = sentences_tokenized
start_of_p_list = [list(train_df['start_of_p'])]*1
bold_list = [list(train_df['bold'])]*1
center_list = [list(train_df['center'])]*1
label_list = [list(train_df['label'])]*1

I noticed that the sequence length for the numerical features had been set to 100 after creating a list of 100 of each of the features. I wanted to know if there was any specific reason for doing so ?
The tokenzied text can obviously have a large length like 100 but why isnt the sequence length for numerical features being set to 1 ? moreover i noticed that setting the length to 1 gives the following error IndexError: index 1 is out of bounds for axis 0 with size 1 when print(stack_embedding.embed(x)) is run.
I have asked a lot of questions before but I must reiterate how thankful I am for all the help !

For now, all sequence length must be equal for embedding layers in a stacked embedding, that's because we have to concatenate their output together for classification/labeling task.

https://github.com/BrikerMan/Kashgari/blob/63f0991b0d46599b16a83abe64123b5cc7a5a35e/kashgari/embeddings/stacked_embedding.py#L78
When concatenating tensors, they must share two equal dimensions, we choose the batch_size + sequence_length. So embedding layers must have sequence_length but could have different embedding_size.
Our data from the embedding layer will be in this shape
[batch_size, sequence_length, embedding_size]

When concatenating using current way, your result will be
[batch_size, sequence_length, embedding_size1 + embedding_size2+ embedding_size3]

We choose to use sequence length because we need to use those stacked embedding for both labeling and classification. Only in this case, we could keep the original input sequence length for further tasks.
If we use different sequence length, then we have to keep the same output shape for feature embedding layers, and this will change embedded tensor's sequence_length. Which may cause lots of problems.

Indeed as what @brikerman explained.
Maybe we should allow users to choose the axis on which they want to
concatenate different embedding feature vectors or matrix.
On Tue, Jul 16, 2019 at 17:35 Eliyar Eziz<EMAIL_ADDRESS>wrote:

For now, all sequence length must be equal for embedding layers in
a stacked embedding, that's because we have to concatenate their output
together for classification/labeling task.

https://github.com/BrikerMan/Kashgari/blob/63f0991b0d46599b16a83abe64123b5cc7a5a35e/kashgari/embeddings/stacked_embedding.py#L78
When concatenating tensors, they must share two equal dimensions, we
choose the batch_size + sequence_length. So embedding layers must have
sequence_length but could have different embedding_size.
Our data from the embedding layer will be in this shape
[batch_size, sequence_length, embedding_size]
When concatenating using current way, your result will be
[batch_size, sequence_length, embedding_size1 + embedding_size2+ embedding_size3]
We choose to use sequence length because we need to use those stacked
embedding for both labeling and classification. Only in this case, we could
keep the original input sequence length for further tasks.
If we use different sequence length, then we have to keep the same output
shape for feature embedding layers, and this will change embedded tensor's
sequence_length. Which may cause lots of problems.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/BrikerMan/Kashgari/issues/158?email_source=notifications&email_token=AAGRFKSPUVGEQNC3GPGHV5TP7WI4JA5CNFSM4ID62OCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2AJFSQ#issuecomment-511742666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGRFKSHCOIXNTDOPURLOTDP7WI4JANCNFSM4ID62OCA
.

Update:
Not necessary to do what I suggested above. You may just transfer your
numerical feature matrix, say which shape is (batch_size, feature_size), to
a matrix with 3 dimensions, which shape is (batch_size, sequence _length,
feature_size), just fill (batch_size, sequence _length-1, feature_size) of
it with zero.
On Tue, Jul 16, 2019 at 20:56 Alex Wang<EMAIL_ADDRESS>wrote:

Indeed as what @brikerman explained.
Maybe we should allow users to choose the axis on which they want to
concatenate different embedding feature vectors or matrix.
On Tue, Jul 16, 2019 at 17:35 Eliyar Eziz<EMAIL_ADDRESS>wrote:

For now, all sequence length must be equal for embedding layers in
a stacked embedding, that's because we have to concatenate their output
together for classification/labeling task.

https://github.com/BrikerMan/Kashgari/blob/63f0991b0d46599b16a83abe64123b5cc7a5a35e/kashgari/embeddings/stacked_embedding.py#L78
When concatenating tensors, they must share two equal dimensions, we
choose the batch_size + sequence_length. So embedding layers must have
sequence_length but could have different embedding_size.
Our data from the embedding layer will be in this shape
[batch_size, sequence_length, embedding_size]
When concatenating using current way, your result will be
[batch_size, sequence_length, embedding_size1 + embedding_size2+ embedding_size3]
We choose to use sequence length because we need to use those stacked
embedding for both labeling and classification. Only in this case, we could
keep the original input sequence length for further tasks.
If we use different sequence length, then we have to keep the same output
shape for feature embedding layers, and this will change embedded tensor's
sequence_length. Which may cause lots of problems.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/BrikerMan/Kashgari/issues/158?email_source=notifications&email_token=AAGRFKSPUVGEQNC3GPGHV5TP7WI4JA5CNFSM4ID62OCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2AJFSQ#issuecomment-511742666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGRFKSHCOIXNTDOPURLOTDP7WI4JANCNFSM4ID62OCA
.

Aaah I see . Thank you so much for clarifying 💯
As a follow up question,  I am now running the code with the same sequence length for all the features and the embedding. My embedding is running while training but I am still getting an index out of bounds with axis error.
My code looks like this after modifying (these are just the parts with sequence length involved)
#SEQUENCE LENGTH
SEQUENCE_LEN = 100
#BERT MODEL

bert_model_path= '/Users/ishitagupta/bert/uncased_L-12_H-768_A-12'
bert_embedding = BERTEmbedding(bert_model_path,
                               task=kashgari.LABELING,
                               sequence_length=SEQUENCE_LEN)
tokenizer = bert_embedding.tokenizer

feature1_embedding = NumericFeaturesEmbedding(feature_count=1000,
                                                feature_name='feature1',
                                                sequence_length=SEQUENCE_LEN)

feature2_embedding = NumericFeaturesEmbedding(feature_count=1000,
                                                feature_name='feature2',
                                                sequence_length=SEQUENCE_LEN)

feature3_embedding = NumericFeaturesEmbedding(feature_count=1000,
                                                feature_name='feature3',
                                                sequence_length=SEQUENCE_LEN)
tokenized_text_list_train = sentences_tokenized_train

feature1_list_train = [list(train_df['feature1'])]*SEQUENCE_LEN
feature2_list_train = [list(train_df['feature2'])]*SEQUENCE_LEN
feature3_list_train = [list(train_df['feature3'])]*SEQUENCE_LEN
label_list_train = [list(train_df['label'])]*SEQUENCE_LEN

So my understanding is that since I have made the embedding and the features into the same length list, I should not get an index out of bounds with axis error.
But when I run print(stack_embedding.embed(train_x)) I am getting the following error
IndexError: index 100 is out of bounds for axis 0 with size 100


Removes default ports from DefaultRootUrlResolver when applicable

I've noticed that regardless of where the swagger documents are hosted, the URI of the swagger spec always includes the port, even if it uses the protocol default port i.e. 80 for http and 443 for https.
This update:

alters the DefaultRootUrlResolver to use a UriBuilder handle the decision of including the port of not (instead of using string concatenation)
adds new tests for omitting the port from the url when applicable

This will result in urls like http://tempuri.org/swaggger/docs/1 instead of http://tempuri.org:80/swaggger/docs/1.

👍


Update method-or-data-member-not-found-error-461.md

Add missing space.

Docs Build status updates of commit b2f892d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Reference/User-Interface-Help/method-or-data-member-not-found-error-461.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks @IvenBach ! Thanks for taking the time to fix and open the PR. Next time @lindalu-MSFT me!


feat(destinationRule): :rocket: Adding warmup configuration

This PR adds warmup configuration for ROUND_ROBIN and LEAST_REQUEST loadbalancer when user sets warmup in DestinationRule's trafficPolicy. This is based on this API : https://github.com/istio/api/pull/3216

Deprecates warmupDurationSecs

Adds unit test to validate config is applied

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ]  Configuration Infrastructure
[ ]  Docs
[ ]  Installation
[X]  Networking
[ ]  Performance and Scalability
[ ]  Policies and Telemetry
[ ]  Security
[ ]  Test and Release
[ ]  User Experience
[ ]  Developer Infrastructure

Please check any characteristics that apply to this pull request.
Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Hi @frgaudet. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/ok-to-test

@frgaudet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-notes_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-notes_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-notes

macbuildcheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test macbuildcheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-notes_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-notes

macbuildcheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test macbuildcheck

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-notes_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-notes

macbuildcheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test macbuildcheck

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-notes_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-notes

macbuildcheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test macbuildcheck

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-multicluster

integ-telemetry-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-multicluster

integ-telemetry-discovery_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-discovery

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

client-go dependency isn't up to date, how to trigger an update @howardjohn ?

@frgaudet its supposed to automatically happen, let me see if something blocked it

Ah so its failing to auto-update since the new API changes don't have associated validation changes (in  pkg/config/validation): https://github.com/istio/istio/pull/53470 https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/53470/unit-tests_istio/1844768937426817024.
So you can manually update here and add the validation:
go get istio.io/api@master
go get istio.io/client-go@master
go mod tidy
make update-crds

should do it

/retest

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

macbuildcheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test macbuildcheck

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-multicluster

integ-telemetry-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-multicluster

integ-telemetry-discovery_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-discovery

release-notes_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

gencheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test gencheck

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

macbuildcheck_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test macbuildcheck

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-multicluster

integ-telemetry-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-multicluster

integ-telemetry-discovery_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-discovery

release-notes_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test release-notes

unit-tests-arm64_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

lint_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test lint

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-multicluster

integ-telemetry-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-multicluster

integ-telemetry-discovery_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-discovery

release-notes_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test release-notes

unit-tests-arm64_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests-arm64

gencheck_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-basic-arm64_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-basic-arm64

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

unit-tests_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test unit-tests

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-multicluster

integ-telemetry-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-multicluster

integ-telemetry-discovery_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-discovery

release-notes_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test release-notes

unit-tests-arm64_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests-arm64

gencheck_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test gencheck

lint_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-ds_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ds

integ-helm_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-helm

integ-ambient_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ambient

integ-cni_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-cni

integ-ipv6_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-ipv6

integ-distroless_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-distroless

integ-pilot_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot

release-test_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test release-test

integ-security_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security

integ-security-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-istiodremote

integ-telemetry_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry

integ-pilot-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote

integ-pilot-istiodremote-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-istiodremote-mc

integ-telemetry-istiodremote_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-istiodremote

integ-security-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-security-multicluster

integ-telemetry-mc_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-mc

integ-pilot-multicluster_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-pilot-multicluster

integ-telemetry-discovery_istio
570051b753421a4e50f6b2ebb9e0131598c4c6e8
link
true
/test integ-telemetry-discovery

release-notes_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test release-notes

unit-tests-arm64_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests-arm64

gencheck_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test gencheck

lint_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test lint

unit-tests_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test release-notes

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test release-notes

unit-tests-arm64_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests-arm64

lint_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test lint

unit-tests_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test lint

unit-tests_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
1941f76d35dbccd0f21f84351b4f6b347eaad2be
link
true
/test unit-tests

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests-arm64_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests-arm64

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test lint

gencheck_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test gencheck

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

unit-tests-arm64_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
a7038ced151caec5f5393b03bde1020ac15f4a6a
link
true
/test unit-tests

unit-tests-arm64_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test unit-tests-arm64

lint_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test unit-tests-arm64

lint_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test lint

unit-tests_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
2dbdb0da1e365d5c9377e4357d7ebae9a241fef7
link
true
/test unit-tests-arm64

unit-tests_istio
51349898ce8414b3015ed863a0a3d663a1b3c1ea
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
51349898ce8414b3015ed863a0a3d663a1b3c1ea
link
true
/test unit-tests

unit-tests-arm64_istio
51349898ce8414b3015ed863a0a3d663a1b3c1ea
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
51349898ce8414b3015ed863a0a3d663a1b3c1ea
link
true
/test unit-tests

unit-tests-arm64_istio
51349898ce8414b3015ed863a0a3d663a1b3c1ea
link
true
/test unit-tests-arm64

lint_istio
c6569a4c9aae3d9aaa4bd4fa37e2242b893152c6
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@frgaudet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
c2ea6172b7b7a318c2bc123497dd7538e104bc38
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

Ah so its failing to auto-update since the new API changes don't have associated validation changes (in pkg/config/validation): #53470 https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/53470/unit-tests_istio/1844768937426817024.
So you can manually update here and add the validation:
go get istio.io/api@master
go get istio.io/client-go@master
go mod tidy
make update-crds

should do it

Okay, I added validation
Thanks


Have you completely given up on this project?

For this theme, most likely yes unfortunately. I no longer use this theme as my main now after I switched laptops, but all the configs needed to recreate it are in the repo anyway.


Package who state that their homepage is a localhost URLs should be scored lower

From the logs: Check of URL http://localhost:8080/dbconnection.html failed.

Currently these do not get scored lower, as link checking just passes


Incrementing code Issue

Challenge Increment a Number with JavaScript has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.84 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

var myVar = 87;

// Only change code below this line
myVar = ++myVar;

Output: myVar = 88
What is wrong: myVar = myVar should be changed
Thank you.

@emontag please review the instructions again for the answer to your issue.

The entire line becomes i++;, eliminating the need for the equal sign.

If you get stuck with a challenge, please first ask questions to the Help Room. Happy coding!


raw link not accessible

links https://raw.githubusercontent.com/Mirantis/cri-dockerd/master/packaging/systemd/cri-docker.service
and https://raw.githubusercontent.com/Mirantis/cri-dockerd/master/packaging/systemd/cri-docker.socket
are not accessible

u22@u22:~$ wget https://raw.githubusercontent.com/Mirantis/cri-dockerd/master/packaging/systemd/cri-docker.service --2022-09-17 14:37:58--  https://raw.githubusercontent.com/Mirantis/cri-dockerd/master/packaging/systemd/cri-docker.service Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 2606:50c0:8002::154, 2606:50c0:8003::154, 2606:50c0:8000::154, ... Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|2606:50c0:8002::154|:443...

This is your local network not being IPv6 capable despite your machine having an IPv6 address, or specifically being unable to reach GitHub via IPv6. Force IPv4 (e.g. drop the IPv6 address, use --inetv4-only flag with wget, etc) and you will be able to download these files just fine. You can also clone the repository, which you should probably do if this is part of a CI pipeline or similar.


Not a bug just a question

I'm migrating project from expo to CLI, is this package is supported in CLI?
If not than any suggestions to do same thing in CLI?

It is both supported on Expo and bare RN. Our example is a bare RN project.

Let me rephrase the question. We have our project in React Native CLI. When we tried your package using Expo CLI it worked as expected, but while using your package in React Native CLI it doesn't event complie when we follow the same steps. And it gives the error in npm start.

Same answer again 😅
Just clone the repo and go to example folder. I myself, do not even test my lib on Expo for now and I have been using RN CLI since start. If you have any problems, please upload a reproduction somewhere so I can check and also send some logs. Not compiling can be caused by various factors.

Let me check this.

If you are getting an error when running npm start I can say that is not caused by this lib or any other libs and it can be some misconfigurations in your project.


Mapping between Data sets in archives and Deployment in OSCAR is undetermined

Mapping between data sets in archives and Deployment in OSCAR is undetermined.
It will be resolved in schema version 2.0 or later.

Moved to https://github.com/wmo-im/wmdr/issues/14


[angular] Update 13.3.7

https://github.com/angular/angular/releases/tag/13.3.7

@BiNZGi :100: :1st_place_medal: :tada:
LGTM


Enable CD for both Thycotic Secret Server and Thycotic DevOps Secrets Vault

Description
This PR is to enable CD on both Thycotic owned plugins:

Thycotic Secret Server (https://github.com/jenkinsci/thycotic-secret-server-plugin)
Thycotic DevOps Secrets Vault (https://github.com/jenkinsci/thycotic-devops-secrets-vault-plugin)

Submitter checklist for adding or changing permissions
Always

[ x ] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[ x ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ x ] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

Hi. Anything I can do to help expedite this merge? All checks seem to have passed, and customers are waiting for this integration. Thank you in advance.


Mc toc

@birdage @DanielJMaher @oceanzus
Please review

Look good.

@oceanzus just needed to fix one last thing before done.  Additions are to lines 138-140, please review for sanity.

GAHHH!


Setup Trusted Publisher deployment to PyPI

Use this instead of the API tokens we used before. It's safer and easier to use because it doesn't required generating tokens and pasting them to GitHub.

Relevant issues/PRs:

Related to https://github.com/fatiando/community/issues/141

@santisoler you should delete the token from PyPI and TestPyPI.

Done!


#20 Added Download Now Button

Replaced Buy Now button with Download now that downloads the content in jpg format

hey @boomboss200 can you please recheck my repo i am facing some issue with my code

What kind of issue ? Sent from my iPhoneOn 06-Feb-2023, at 11:35 AM, Nababrata Deb @.***> wrote:
hey @boomboss200 can you please recheck my repo i am facing some issue with my code
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@Nababratadeb-NITA do let me know the issue that you are having also would be great if you can provide the screenshot as well

Hey @boomboss200  when I download the image it shows that it's not supported or file may be corrupted can you fix the issue

okay. I will check on that later, if I can find any fix to it.  isn't the downloaded file in the jpg format ?

@Nababratadeb-NITA how do the users get the product when they buy after the going through the cart process.
i.e
how do they recieve these products after paying and buying them..

@Nababratadeb-NITA how do the users get the product when they buy after the going through the cart process.
i.e
how do they recieve these products after paying and buying them..

Through the mail

that mail contains the same file as the user gets through the download button


CI fails

See https://github.com/yegor256/awesome-cfp/actions/runs/10011263469/job/27674302736 Would be great to find the cause of the problem and fix.

@yegor256 link 'https://www.asplos-conference.org/asplos-2025-call-for-papers' return 404 status. Which link should we replace it with?
Maybe check cfp.yml for each PR?

@blablatdinov yes, indeed, checking CFP.yml in each PR is a perfect idea.
Here is the link: https://www.asplos-conference.org/asplos2025/cfp/

@blablatdinov we still are not stable: https://github.com/yegor256/awesome-cfp/actions/workflows/tests.yml

@yegor256 Oh, link return 404 mock it for test in #76

@blablatdinov works good now, thanks!


Inline-Style on arrows -> "display: block" (hiding arrows)

I want to hide the left arrow on the first slide,
and the right arrow on the last slide.
Why do you use an inline-style "display: block" on each arrow?
Overwriting with external CSS is possible, yes, but you need a high specification with "!important".
Perhaps you can set "display: block" in the external slider-css?

+1
is this working as intended?

yes, it's been this way a long time. I was tempted to change it in a recent patch, but didn't do it in the end.
https://github.com/kenwheeler/slick/blob/master/slick/slick.js#L1288-L1289
Feel free to make a patch with loaded/unloaded arrow & dot classes :)

Looks like this got into the master at some point. Closing! Thanks!

Is this really done? I still got this error in 2018. The slick-arrow is automatically given display:block as an inline statement.
And I really dont like !importantin my Styles ;)
This:
mySlider = $('.my-slider').slick({
        vertical: true,
        swipe: false,
        infinite: false,
        slidesToShow: 4,
        slidesToScroll: 1,
        speed: 250,
        prevArrow: '
<button type="button" class="slick-prev"></button>
',
        nextArrow: '
<button type="button" class="slick-next"></button>
'
    });

Generates this:

    <button type="button" class="slick-prev"></button>

Same here,
I'm working with computed slides; In one of my scenarios 5 slides are displayed, then filtered with slick filters and I end up having only 1 slide with slidesToShow: 4, no arrow needed.

.slick-hidden + display:block should not happen
note: display:block after a window resize

This should be reopened.
Feb. 2019 - and the issue is still present.
No weird magic in my initialisation code:
$('.upcoming-events--slick-wrap').slick({
    mobileFirst: 1,
    infinite: false,
    slidesToShow: 1,
    prevArrow: "<button type='button' class='upcoming-events--slick-prev slick-arrow'></button>",
    nextArrow: "<button type='button' class='upcoming-events--slick-next slick-arrow'></button>",
    responsive: [
        {
            breakpoint: 768,
            settings: {
                slidesToShow: 2
            }
        },
        {
            breakpoint: 992,
            settings: {
                slidesToShow: 3
            }
        },
        {
            breakpoint: 1200,
            settings: {
                slidesToShow: 4
            }
        }
    ]
});

Generates this - with an inline style display: block;...

     <button type="button" class="slick-prev"></button>

This error is still present. And it's so weird. I perused the code in master and did find nothing that explains it.
Is there any third party lib used in the slider that might cause it? jQuery maybe?

The problem occurs due to the use of jQuery function "show" in the initUI function.
    Slick.prototype.initUI = function() {

        var _ = this;

        if (_.options.arrows === true && _.slideCount > _.options.slidesToShow) {

            _.$prevArrow.show();
            _.$nextArrow.show();

        }

        if (_.options.dots === true && _.slideCount > _.options.slidesToShow) {

            _.$dots.show();

        }

    };

If you want to style "display" yourself, you have to remove the corresponding property.
    Slick.prototype.initUI = function() {

        var _ = this;

        if (_.options.arrows === true && _.slideCount > _.options.slidesToShow) {

            _.$prevArrow.css("display", "");
            _.$nextArrow.css("display", "");

        }

        if (_.options.dots === true && _.slideCount > _.options.slidesToShow) {

            _.$dots.css("display", "");

        }

    };


Move to using templates:core

I already namespaced component functionality, but this will take it to the next level.

Might do this, might not. Working on a pretty big update to templates:core so I'll close this issue for now.


please update php 7.2.4 to 7.2.10 on dockerhub

same as title

trigger dockerhub build thanks.

https://github.com/laradock/laradock/issues/2004


Update README.md

it may help some Windows users who don't know about installing nodejs.

That's not relevant for global install. Install from master is not needed for ordinary users.


Change "componentWillReceiveProps" to componentDidUpdate

Hi :)
First of all, great work here! I like the simplicity of this package.
Going through the source I noticed that the code still uses componentWillReceiveProps:
https://github.com/paulcollett/react-masonry-css/blob/master/src/react-masonry-css.js
As it is deprecated method, I propose to change it to componentDidUpdate() or alternative method.
I can give it a look if time allows :)

Hi!
I've been enjoying using your library at work but I've experienced issues related to the deprecated lifecycle hook componentWillReceiveProps.
I wouldn't know how to reproduce the issue outside of our application, but what ended up happening was that columnCount was not consistent with the supplied breakpointCols prop.
We fixed it by moving the execution of this.reCalculateColumnCount() from componentWillReceiveProps to componentDidUpdate. It would be great to see that integrated in your library and I could open a PR for it if that's ok.

Love the library. Just a heads up if you run the module under React.StrictMode, we get the following warning:

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Masonry

Is anyone working on this ATM? I would definitely be up for it if not!

I would definitely be up for it if not!
@georgedoescode PR is very welcomed. I'll merge it asap

https://github.com/paulcollett/react-masonry-css/pull/36


Update Post “best-chemical-to-use-for-termite-treatment”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
dd703b028bee77fc932b22ee1b823e0709d4bea0

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/654abef826bbae00087aece1


Add support for Pig datetimes

There's currenly no support for conversion to/from Pig datetimes
Reporter: Christian Rolf / @ccrolf
Related issues:

Sample NanoTime class serializes and deserializes Timestamp incorrectly (relates to)

Original Issue Attachments:

parquet_datetime_support.patch
PARQUET-137.1.patch

Note: This issue was originally created as PARQUET-137. Please see the migration documentation for further details.

Brock Noland / @brockn:
This uses the NanoTime class. We should probably fix that implementation as it's wrong. See PARQUET-114.

Oleksiy Sayankin:
Fixed joda-time scope and version in dependences.

Ryan Blue / @rdblue:
Thanks for looking at this, Christian! Brock is right that NanoTime is for demo purposes only. In fact, I wouldn't recommend building your own copy of it either because the "timestamp" it works with is undocumented and uses an int96 without an annotation. We've been looking at this problem lately and we have defined both type annotations and specified how they should be interpreted. The next step is to implement those types in the object models like you've done here. In fact, this will be the first implementation.
The specification for date/time types is on the LogicalTypes page. If you need any help with the spec, feel free to ask questions and I'll clarify.

Oleksiy Sayankin:
Hi @rdblue.
I am not a contributor at https://github.com/Parquet/parquet-mr so I can not create a separate branch and hence a pull request for merge: not enough permissions.
Well, either I need to get permissions to create a new branch or ask some one who has ones to create it for me and apply changes from the patch.

Ryan Blue / @rdblue:
Thanks, [~osayankin]! I didn't realize there was a patch to review here. We'll take a look.
Could you open a pull request on github for this?

Ryan Blue / @rdblue:
Yeah, there's definitely value in making Pig work with the dates and times from the spec. Does Pig have date and time types as well?

Oleksiy Sayankin:
Tested fix with Pig and Hive
STEP 1: Create parquet data in Hive
CREATE TABLE IF NOT EXISTS `test` (id int);
CREATE External TABLE `pig` (
  `campaignid` bigint,
  `siteid` bigint,
  `name` string,
  `lastupdated` timestamp,
  `created` timestamp,
  `active` boolean
) STORED AS PARQUET LOCATION '/user/test/pig';

Insert data.
INSERT OVERWRITE TABLE `test` VALUES (1),(2),(3),(4),(5),(6),(7),(8),(9),(10);
INSERT OVERWRITE TABLE `pig`
SELECT
  1,
  2,
  'sample',
  '2016-10-17 11:22:33.232323434',
  '2016-10-17 11:22:33.232323434',
  1
FROM `test`
LIMIT 10;

STEP 2. Load the data using pig:
REGISTER /usr/pig/pig-0.16/contrib/piggybank/java/piggybank.jar;
parqData = LOAD '/user/test/pig/000000_0' USING parquet.pig.ParquetLoader('campaignid:long,siteid:long,name:chararray,lastupdated:datetime,created:datetime,active:boolean');
DUMP parqData;

EXPECTED RESULT:
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)
(1,2,sample,2016-10-17T20:22:33.232Z,2016-10-17T20:22:33.232Z,true)

Worked as expected.

Oleksiy Sayankin:
Hi all!
Can any body review the patch and apply it? Our customer is suffering...
Thanks in advance.

Christian Rolf / @ccrolf:
Thanks for the feedback! Sorry I didn't have time to look into this further for a long time. Looks like Parquet format 2 will have totally different date types. So there isn't much point in fixing this?

Christian Rolf / @ccrolf:
Ok, will try to find time for it, Pig uses Joda time internally: http://pig.apache.org/docs/r0.14.0/basic.html#data-types

Brock Noland / @brockn:
Hi @ccrolf,
Long story short:

The NanoTime class was implemented incorrect as described in PARQUET-114.
As noted by the package name on the class this was implemented as an example. Users are expected to implement their own class.

Brock

Ryan Blue / @rdblue:
You can open a pull request from your own repository. Just push a branch to your github fork and open a PR for it from there.
You may want to make sure you forked from https://github.com/apache/parquet-mr so you don't have to select that one manually. We no longer use the old repository.

Oleksiy Sayankin:
PS: I expected that patch will be applied automatically if it is well formatted. I waited something like this
PARQUET-[.][-].patch

Oleksiy Sayankin:
Done: https://github.com/apache/parquet-mr/pull/387

Viraj Bhat:
[~osayankin] @rdblue is the patch being re-submitted after comments in github. Is this being fixed elsewhere that I do not know of?
Viraj


Fix: SingleText can display the msg as html

.qkb-msg-bubble-component__text {{ mainData.text }}
-> .qkb-msg-bubble-component__text(v-html="mainData.text")

@ntt0102
Hi there, thanks for your PR. But be careful with this one, because it may cause the XSS attack if you store the message.
That's the reason I only support non-formatting the message.
There are 2 solutions for this, you should re-verify:

We need a service to trim script tags for the messages.
Only allow formatting message from BOT side, not user side.

I'm happy to merge this PR if you have solution for this :)
Thank you.


[http api] GET /outputs for a given asset

This use case was sourced from a customer.
As a BigchainDB client
I want to query the BigchainDB HTTP API for all transactions with unspent outputs for a given asset
Customer described:

Is there an API to get the unspent items for one asset ? I was checking documentation but can’t find anything. Any suggestion? This is in the context of ONE asset with 1000 amount , where of 5 TX with 10 each has been transferred to others prv keys. 900 is left. Now 1 TX of the previously 5 with 10 gets transferred back . meaning now 910 is unspent in total for the same asset

A better way to do this might be to enhance the GET /outputs API. Currently, this API returns a list of TransactionLink which only give us transaction_id and output_index. To actually find the amouts per asset, we have to fetch all these transactions, filter by asset_id and look up the amounts.
If the GET /outputs also includes asset_id and amount (in addition to transaction_id and output_index), user will be able to compute this with 1 network call instead of 1+N. In other words, the outputs API should return a list of TransactionLinkWithMetadata instead of list of TransactionLink where TransactionLinkWithMetadata is this structure:
{
  "transaction_id": "1234",
  "output_index": 0,
  "asset_id": "999",
  "amount": 100
}


"Does your algorithm support semi-supervised segmentation tasks？

"Does your algorithm support semi-supervised segmentation tasks, and if not, are there any plans for future development in this regard?"

"Does your algorithm support semi-supervised segmentation tasks, and if not, are there any plans for future development in this regard?"

"Does your algorithm support semi-supervised segmentation tasks, and if not, are there any plans for future development in this regard?"

Hi, currently, we do not plan to extend to segmentation tasks.
If you have any good ideas about the extension, please let us know!


Using Classic Bluetooth GAP API, ESP-IDF

I have read all the documentation available, but can't figure out how to use the below API in ESP-IDF template provided.
API Link - https://docs.espressif.com/projects/esp-idf/en/latest/api-reference/bluetooth/esp_gap_bt.html#_CPPv418esp_bt_gap_set_pin17esp_bt_pin_type_t7uint8_t17esp_bt_pin_code_t
Link for template - https://github.com/espressif/esp-idf-template
This is my first project involving micro-controllers. Any help would be really appreciated of how to use such API using esp-idf.

Closing as this seems to be a question, and the issue template has been ignored. Questions could be asked on the esp32.com forum in the relevant section(s). Thanks.


Update last-applied-configuration annotation

Closes #36

Codecov Report

Merging #37 (26a9de1) into master (cd293ae) will decrease coverage by 0.53%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   77.40%   76.86%   -0.54%
==========================================
  Files           8        8
  Lines         385      415      +30
==========================================
+ Hits          298      319      +21
- Misses         56       61       +5
- Partials       31       35       +4

Impacted Files
Coverage Δ

core/modrulestore.go
79.06% <70.00%> (-2.75%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd293ae...26a9de1. Read the comment docs.


Search by log column

Add field and term parameters to search. If field isn't specified, than operate as normal searching everything in the line.

This must be done before we can address #43


HaltonSequences is misbehaving

We (me + @TanyaS08 and @beasley015) have been running into issues with NeutralLandscapes using julia 1.9 in different projects, on different OS. I can install the package just fine on its own, but with additional project dependencies, it sometimes chokes because there's an issue with HaltonSequences and its Primes dependency.
I started the bug/HaltonSequences1dot9 branch to see what's up, but maybe @gottacatchenall has encountered the same?

I'd bet on stale dependencies, I'll take a look

I'm not sure it's this, because it installs fine in an empty project. I think @Beasley015 got it working in a project with additional dependencies but I'm not sure how.

I'm not sure it's this, because it installs fine in an empty project. I think @Beasley015 got it working in a project with additional dependencies but I'm not sure how.

Is it SpeciesDistributionToolkit the additional dependency? I vaguely remember running into a problem with HaltonSequence dependencies a month or so back, but I didn't write down what so I don't remember how I got around it :upside_down_face:

Oh we're gonna blame my code then uh?
I don't think it was a dependency in either project, but I think Makie was -- I'll make a list of the dependencies in either and see if I can figure out which is the problem.

Don't worry, my lack of writing shit down is the culprit here---clearing out the [compat] on Project.toml might be the quickest way to working code

In an empty project directory with Julia 1.9.3  I was able to ]add SpeciesDistributionToolkit and ]add BiodiversityObservationNetworks, and run
using SpeciesDistributionToolkit
using BiodiversityObservationNetworks

without issue.
I'm curious if that is true for everyone in this thread?

Like @tpoisot said, I managed to get NeutralLandscapes working in an empty project using Julia 1.9. I was also able to install it in a project with DataFrames, StatsBase, PkgCite, and Plots, so none of those are the issue.
I can test Makie, SpeciesDistributionToolkit, and BiodiversityObservationNetworks this afternoon.

Sounds good, iirc it was something particular to GeoMakie that was causing the issue

SpeciesDistributionToolkit and BiodiversityObservationNetworks work with NeutralLandscapes.
I reproduced the error in a project that only had NeutralLandscapes and Makie- so it seems like Makie or one of its dependencies is causing the issue

I had the issue with GLMakie for sure, I can't remember if CairoMakie gave the same error...

I'm able to run add GLMakie, BiodiversityObservationNetworks, SpeciesDistributionToolkit, NeutralLandscapes and load and use them from an empty project, are there any other packages in the env?

Maybe keep in mind that environments are nested - so it could also be an interaction with something in your default env?

In another project I ran into this again, looks like HaltonSequences and StatsBase are constrained by NeutralLandscapes and that's like whats causing problems

The bump to v0.1.4 seems to have fixed this on my end


Can't take user input

Once the initial ffmpeg variables have been initialised I can't get user terminal input using input() it seems (atleast for me) the problem is with how the ffmpeg verbose prompt interacts with python's std out.
I even tried with and without quiet=True parameter in input() and in output()

I'd say you could try preventing any output from ffmpeg using
.run(capture_stdout=True, capture_stderr=True)

Then see if it works. If it does, you should output ffmpeg in a different way as it usually messes the damn terminal even more when it is async.

I found another solution, where you have to enter stty sane
Might try it later on my work pc.
https://superuser.com/questions/573853/cant-type-in-cli-after-running-ffmpeg

I found another solution, where you have to enter stty sane
Might try it later on my work pc.
https://superuser.com/questions/573853/cant-type-in-cli-after-running-ffmpeg

Yeah that sounds good !

I found the issue for me in these cases is solved when the global flag -nostdin is applied. This flag stops ffmpeg taking standard input. It may not solve all instances where this is a problem but it has been successful in my cases. Furthermore, inclusion of this flag wont effect anything but interactive ffmpeg calls.

I found the issue for me in these cases is solved when the global flag -nostdin is applied. This flag stops ffmpeg taking standard input. It may not solve all instances where this is a problem but it has been successful in my cases. Furthermore, inclusion of this flag wont effect anything but interactive ffmpeg calls.


Upgrade minimum node engine?

Currently we say minimum node 8. Which is way outdated now
https://github.com/IBM/nodejs-itoolkit/blob/265f4c54a05937d7f12fc7b1c1f157de23ff79b4/package.json#L62

I don't think there's anything this package does that couldn't be node 8, but there are no guarantees for our dependencies. https://endoflife.date/nodejs says that Node.js 14, 16, and 18 are the current "support triad", so I guess 14 would make sense?

No need to change this at the moment


Not recording its own name, but properly stores data from the conversation.

The data from previous conversations is persisting from one session to the next and data is being properly recorded and recalled, with the exception of the agent's name. I have, in one command, told it its name and had it repeat it to me. It can do this, but when prompted in subsequent commands, it outputs "My name is [insert name here]."
I'm completely new to Pinecone and vector databases, so this could very well be something basic that I'm doing wrong. Any suggestions?

Is this issue still happening? I just tested on a clone of the latest and it remembers its name between runs. I simply said Your name is SomenameAI and it remembered.


Add support for Pinned Object Heap data in ETW events

Once https://github.com/dotnet/runtime/pull/34549 is merged, GC will start reporting additional information regarding Pinned Object Heap.
The new data is added in a backwards compatible way, so the change is not breaking.
However to fully support ingestion of the new data, PerfView needs to add support for additional fields. (see: https://github.com/dotnet/runtime/pull/34549 for details)

@VSadov, thanks for filing this issue.  Are you planning to submit a PR as part of this effort?

Yes, you can assign this to me.

@VSadov @davmason can this issue be closed or is there work left in tracevent/perfview to support this?

@brianrob added POH support in the most recent version of perfview, closing


Fixes:Navbar

Summary:
Closes #855
I used "v-b-tooltip.hover title" in order to pop up the functionality of the icons present in navbar on hover.
I installed "bootstrap-vue" in order to use the "v-b-tooltip.hover title" for each icon of the navbar to pop up it's functionality
Description for the changelog:
provide hover text for navbar icons
Other info:

After making changes our navbar will behave like below
screen-capture (1).webm
Thanks for submitting a pull request!
Please make sure you follow our code_of_conduct.md and our contributing guidelines contributing.md

Please Review @jgadsden
i noticed that the "bootstrap-vue" is already installed in td.vue frontend folder however from the root directory i uninstalled the bootstrap-vue and re-install in the frontend folder
Everything looks fine to me now

@jgadsden
PR pipeline / Build docker image (pull_request)  , this check is getting failed because of the [ Error: Username and password required ]

Kindly have a look at the issue I am getting  @jgadsden

yes, do not worry about the error in the tests @itsdheerajdp , it is because you do not have the permissions to push to Docker
it is something that needs to be sorted out one day when we have some time :)

yes, do not worry about the error in the tests @itsdheerajdp , it is because you do not have the permissions to push to Docker it is something that needs to be sorted out one day when we have some time :)

So @jgadsden  , till then i need to wait for raise new issue or PR ??

we cango ahead and merge, thanks again @itsdheerajdp

translations added with commit ab6beb1


Create curl install script that uses packages published on PyPI

Currently the curl install script refers to nightly builds (i.e.  curl -L https://aka.ms/ProjectAzInstall | sudo bash).
Once packages have been published to PyPI (https://github.com/Azure/azure-cli/issues/648), we should have an install script that uses this.
The server hosting the script should use HTTPS (https://github.com/Azure/azure-cli/issues/394) and the URL should also change.

The curl scripts have been published and are served over HTTPS.
curl https://azurecliprod.blob.core.windows.net/install | bash

Or with the shortened link:
curl -L https://aka.ms/InstallAzureCli | bash

FYI @colemickens


Update the internal changelog to reflect new proxy version override feature

And add release date to enable releasing a new version of this package.

Waiting to merge before Monday. 👍

Needs a rebase on main and update the changelog.

Needs a rebase on main and update the changelog.

I updated the changelog earlier, but I just rebased on main per the request as well.


python3 support

changes raw_input() to input()

This doesn't work quite right in python2.7.  You get a "SyntaxError: unexpected EOF while parsing" when the user hits enter.  I looked around but didn't find anything that will work right in both python2 and 3.  But it seems like there should be some way to just wait for a keypress.  Any ideas?

Oh sorry, I thought input() is backward compatible. I added some more lines to avoid the error in 2.7.

Yeah, that's the simplest thing I could find too.  But it's still overly complex and distracting as part of an example program.  So I just added a dlib.hit_enter_to_continue() and replaced all the raw_input() calls with that.  So I'm not going to merge this pull as it's fixed now but definitely thanks for pointing this out.
Cheers,
Davis


Thread.current[:lograge_location] leaks into other requests

Lograge version: 0.4.1
Rails version: <IP_ADDRESS>
Ruby Version: 2.2.5
Last week I enforced (by redirecting) a new subdomain on a large set requests on my app. These, individually logged right, as volume increased I started noticing requests outside of this set to be logged as redirects, but with the right status codes (201, 200, etc)
I've come to the conclusion that this requests were fulfilled by threads that had stored: Thread.current[:lograge_location]
I'm happy to take a deeper look into it, and work on a solution. But I wanted some sort of confirmation that I'm on the right path and discuss possible solutions before working on one.
I used my own formatter, but this should give you an idea of what I'm describing:
Jan 22 17:20:16 heroku-app-1234 app/web.5:  <IP_ADDRESS>    GET 200 /api/resource redirect_to=http://new_subdomain.example.com/other_resource (app:168.58ms db:37.26ms)
Jan 22 17:20:33 heroku-app-1234 app/web.8:  <IP_ADDRESS>     GET 302 /other_resource redirect_to=http://new_subdomain.example.com/other_resource (app:0.0ms db:6.41ms)

API requests don't redirect. In this case the app got the data and status code right, but it was logged with a "redirect_to". The second line correctly logged the redirected to the same resource on the "new_subdomain".

That sounds entirely possible. Some app servers won't clear thread locals (per request for example) without explicit opt-in. I know for sure puma has a clean_thread_locals option that controls this behaviour. Depending on your application server this may be a smart place to start.
Please do feedback anything you find.

You could use request_store gem instead of using Thread.current

@leonelgalan Did this problem persist? Switching out to request_store seems reasonable to me. Is that something you're interested in tackling?

Let's do this! PR soon!


Function app listing

The deploy a function app to azure functions template doesn't appear to exist anymore.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ab62930-d35d-d6d3-8bb7-2ed6b34636bb
Version Independent ID: 86725233-d4a5-a796-cd6e-c05c3675952b
Content: Continuously update function app code using Azure DevOps
Content Source: articles/azure-functions/functions-how-to-azure-devops.md
Service: azure-functions
GitHub Login: @ahmedelnably
Microsoft Alias: aelnably

@seskid Thank you for your feedback! We will review and update as appropriate.

@seskid It looks like the template was renamed to just Azure Functions, as shown below:

I've created a PR that updates the screenshot on this doc. Thanks for reporting this and helping us drive improvements towards MS Docs!


Added Bonus Badge

fixes #43

Changes:-

You are required to make changes in populate_issues view also, as if an issue have bonus label as one of its labels then it should be updated in the database.
Also the bonus description should be mentioned in the upper-left corner of the card. Check my comment on the issue for more detail.

changed the bonus badge position.

I think you are always showing +5 as bonus (Correct me if I am wrong). if it is so, then you have to change it because the label (with bonus as description) can be any-other string also, like +7, +5 for abc etc. hence this string should be shown in the badge.

@ankitsangwan1999 yes, for now, it will always show a +5 badge. But the problem is from where should I take the bonus value.

one way can be to get value by subtracting points from the default points.

or you may have to create (In git hub) new labels for each bonus point issues with label description "bonus" and label name be +5,+7, etc (which are not there at present, or maybe I haven't found one till now).

or you may suggest another way.

For now, there is no bonus description. should the bonus description be like "+5 for creativity" or just "+5"; if like "+5 for creativity" where would it be written in the issue like in the issue's label description or name?

Clarifications:

Second Point is correct Implementation. If some issue is having bonus, then we as mentors will mention that as a single label with label-name as the string itself e.g. +5, +7 for creativity etc. and label-description as "bonus". So, if You find any issue with a label-description as "bonus", show that label-name in the badge.
Calculation of bonus by subtraction of actual points - default points is not needed as this value is technically not "bonus". In short, a bonus somewhat conditional. So, if the Some Issue is having non-default points then, you can highlight that thing in the button showing the points itself.

@ankitsangwan1999
is it right now?