Remove invalid goals and keep track of update time in problem expert

There are 2 improvements in this pull request.

Remove invalid goals corresponding to a removed problem instance. This was listed as a TODO in the code by @fmrico.
Keep track of the update time in the problem expert. One possible use for this is to compare the problem expert update time stamp with the action execution status time stamp. For the action execution status to be relevant (i.e. not outdated), its time stamp should be as new or newer than the problem expert update time stamp.

To test the removal of invalid goals ...

Follow the Steps 1-5 of the simple example described here: https://intelligentroboticslab.gsyc.urjc.es/ros2_planning_system.github.io/getting_started/index.html
Check the problem goal by entering the command "get problem goal".
Remove the instance "bathroom" by entering the command "remove instance bathroom".
Verify that the goal has been removed by re-entering the command "get problem goal".

LGTM!! tested locally and everything went ok. merging!!


[BUG] Realtime plotting not adjusting x bounds of the chart

Describe the bug
A clear and concise description of what the bug is.
Plotting values in real-time (adding + removing values such that total # values is the same) does not adjust the x bounds of the chart.
To Reproduce
Open and run the line_chart example scene, and press the real-time plotting toggle.
Expected behavior
The x bounds of the chart should follow the data.
Screenshots

Desktop (please complete the following information):

OS: Windows
Godot Engine Version: v4.2.1.stable.official [b09f793f5]
Plugin Version: Main branch (5c8f22c19d8ff8e0e6c94af0e7703da7e9fdc829)

Additional context
This might be due to the main branch being a development/incomplete branch.

It seems to work intermittantly for me - it kind of scales from 0-2, to 10-20, and then rolls - i guess its rounding somewhere.
https://github.com/fenix-hub/godot-engine.easy-charts/assets/1183991/169b1067-d759-4979-95c0-656d06aeab69

Thank you for your feedbacks.
I'll be back on working on this project this weekend.
sorry for the inconvenience

has anyone found a workaround for this?

For my use case i switched to : https://github.com/LD2Studio/godot4-graph2d

https://github.com/fenix-hub/godot-engine.easy-charts/assets/45271396/12b51d1f-860d-4028-8dc0-801090b4a181
Hi,
the new release will fix this  bug.
Thank you for your patience

Great thanks :)


Access nested structures

Lately, I've been working a lot with this library, and it's amazing. However, I've encountered several difficulties that I haven't been able to solve.
My test structure lis as follows:
stPruebaEstruc
fPrueba
bPrueba
iPrueba
Positions (Array [1..3] of ST_Position):
|_ Positions[1]
|  |_ ST_Position
|     |_ X
|     |_ Y
|     |_ Z1
|     |_ Z2
|
|_ Positions[2]
|  |_ ST_Position
|     |_ X
|     |_ Y
|     |_ Z1
|     |_ Z2
|
|_ Positions[3]
|_ ST_Position
|_ X
|_ Y
|_ Z1
|_ Z2

Based on the documentation, to access a structure it's necessary to first define "structure_def." I've had issues reading pyads.PLCTYPE_UINT and including nested structures within this structure definition. That's why, as can be seen in the image, I need to manually define the array of structures "Posiciones" outside the definition of "ST_Prueba_structure_def."
By doing it this way, I generate an ads symbol that has the following structure.

The only particularity I've found when comparing it with an array of LREALs is the plc_type variable, which is generated for my array of structures.
I imagine there might be something I'm not understanding or interpreting correctly, but it would be very helpful to shed some light on this topic. Thank you very much, and I apologize if I haven't explained myself thoroughly.

Hello, thanks for your question.
Firstly, you need to make sure that all structures in the PLC are marked with the attribute pack_mode = 1 (https://infosys.beckhoff.com/english.php?content=../content/1033/tc3_plc_intro/2529746059.html&id=).
Also as you may have noticed as you have implemented a workaround, nested structures don't really work smoothly. The workaround for this is noted in #308. At some point I hope to make this a better solution.
Closing issue as duplicate of #308


Fix minor typos in documentation and code

Description
I fixed some minor typos and spelling errors.
Fixes #1115
The following list of words was ignored to adhere to the current implementation:
# .codespell-ignore
asyncronous
commited
dependant
targer

e.g.
codespell --ignore-words=.codespell-ignore

Type of change
Please delete options that are not relevant.

[x] Documentation (typos, code examples, or any documentation updates)
[ ] Bug fix (a non-breaking change that resolves an issue)
[ ] New feature (a non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would disrupt existing functionality)
[ ] This change requires a documentation update

Checklist

[ ] My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
[x] I have conducted a self-review of my own code
[x] I have made the necessary changes to the documentation
[x] My changes do not generate any new warnings
[ ] I have added tests to validate the effectiveness of my fix or the functionality of my new feature
[ ] Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
[ ] I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
[ ] I have included code examples to illustrate the modifications

@mj0nez Thank you a lot for this! 👏 👏 👏


search results for find organizations

i notice that search results for the find organizations page is in km instead of mi. is this something we can fix?

I dont think so actually- km is fine for now i guess...

I dont think so actually- km is fine for now i guess...


Add turtlebot tutorial

Is your feature request related to a problem? Please describe.
Turtlebot is a well known example of a robot very well integrated with ros2 ecosystem. It would be a good candidate for a simple example with RAI.
Describe the solution you'd like

A step by step tutorial on how to setup turtlebot4 in simulation and configure it with rai.
video showing the process

Describe alternatives you've considered
Other rosbots.
Additional context
https://clearpathrobotics.com/turtlebot-4/

Proposed tutorial flow:

How to import turtlebot to some example scene. For example https://github.com/o3de/o3de-extras/tree/development/Templates/Ros2RoboticManipulationTemplate
Starting the simulation
Configuring rai_whoami_node node using documentations and screenshots from the simulation
Writing a simple RaiAgent.
Connecting to the agent using streamlit-based web interface
Asking questions about the robot, what are it's interfaces.
Asking what the robot can see - it can describe the manipulator that is on the table
Asking the robot to move around
Oops - developer forgot to add ros2 publish to topic tool to the agent - robot can't perform the mission
Adding the tool
Robot drives forward


Staking OCW should not create solutions that are too big

Currently, the network size is such that the solutions to the NPoS easily fit into a block, both in terms of weight and size (TODO: script to report these easily). Sooner or later, we might reach a point where the solution might not fit into a block. For this, we have permanent solutions:

limit the total number of nominators
DNPoS

But one way or another, if we don't have these limitations, the OCW must be capable of generating a solution that is sane and fits in the block.
The danger is that a malicious actor might generate a lot of nominators, so that the OCW will always generate a solution that is too big to fit. Then, they can submit a mediocre solution on chain which will be accepted. Sadly, we won't fallback to on-chain phragmen either.
This can also be mitigated by implementing the PJR-check #7009.

indeed the numbers don't look so good.
 Staking election closed at 0x2f6a864e45f19926f7007ce87a9ad099d72f1a5eb19108cde4754e9971ae5d70 (1489532) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 97 => score [25000481475547417,<PHONE_NUMBER>311892206,<PHONE_NUMBER>53394825113507963012696032]
⌚ Weight = {"normal":845352150000,"operational":0} (0.422676075). Len = 29926 (0.005707931518554687)
🤑 Staking election closed at 0xae81482a6af5d08548c5509e1e1a65069ab6d8c8c2388443a855bad6e8f7f58d (1475154) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 96 => score [24997769671168078,<PHONE_NUMBER>728530269,<PHONE_NUMBER>56025309450630273681874439]
⌚ Weight = {"normal":822277790000,"operational":0} (0.411138895). Len = 29092 (0.005548858642578125)
🤑 Staking election closed at 0xbcda72530fd4175e0eb7758863d08f803b2d99ab3da7af2ccbc1cc51a9c44a2f (1460778) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 95 => score [24997769671168078,<PHONE_NUMBER>248924815,<PHONE_NUMBER>95779061904389502061269235]
⌚ Weight = {"normal":812748350000,"operational":0} (0.406374175). Len = 28770 (0.0054874420166015625)
🤑 Staking election closed at 0xb406be670736d72e4463a5dea39eda4cb4ed2f2e20bc028050faacadefd5eac9 (1446405) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 94 => score [24997769671168078,<PHONE_NUMBER>488101749,<PHONE_NUMBER>87658874785317838860683927]
⌚ Weight = {"normal":790574520000,"operational":0} (0.39528726). Len = 27988 (0.005338287353515625)
✅ Found a correct submit_election_solution_unsigned for era 94 => score [24997769671168078,<PHONE_NUMBER>488101734,<PHONE_NUMBER>89451241890854882825526804]
⌚ Weight = {"normal":790169520000,"operational":0} (0.39508476). Len = 27988 (0.005338287353515625)
🤑 Staking election closed at 0x7580bf1f3d72ed0cf7619d78edf4f3ed7625715d283e045131395ef3b8c8eb8f (1432032) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 93 => score [24997769671168078,<PHONE_NUMBER>804244583,<PHONE_NUMBER>97207320526973676763852425]
⌚ Weight = {"normal":779721550000,"operational":0} (0.389860775). Len = 27638 (0.005271530151367188)
🤑 Staking election closed at 0xbb67e5e696478d75ecbf50503a6c7a7fc40b13af49af97f9998a75ee0595e829 (1417661) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 92 => score [24997844671168078,<PHONE_NUMBER>974488538,<PHONE_NUMBER>32636841837159090610554660]
⌚ Weight = {"normal":754999800000,"operational":0} (0.3774999). Len = 26764 (0.005104827880859375)
🤑 Staking election closed at 0xe845406ddb329d79b536b5e463d0154429d3283ebc6bbf8d70809a0cc7a08a98 (1403288) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 91 => score [24997844671168078,<PHONE_NUMBER>327106897,<PHONE_NUMBER>04042621035612220506441491]
⌚ Weight = {"normal":733272730000,"operational":0} (0.366636365). Len = 26012 (0.004961395263671875)
🤑 Staking election closed at 0x771f7f5a979905271ded8e934dd682eb182d84f4a275c6a163d95145d21e406f (1388916) with compute Authority
✅ Found a correct submit_election_solution_unsigned for era 90 => score [24724162758068208,<PHONE_NUMBER>239130414,<PHONE_NUMBER>71658644726809718241071848]
⌚ Weight = {"normal":706667190000,"operational":0} (0.353333595). Len = 25064 (0.00478057861328125)
✅ Found a correct submit_election_solution_unsigned for era 90 => score [24724162758068208,<PHONE_NUMBER>239130414,<PHONE_NUMBER>50919428644954835067107668]
⌚ Weight = {"normal":706667190000,"operational":0} (0.353333595). Len = 25072 (0.0047821044921875)

Okay, I've done a bit more thinking about this, and I am not sure of it is worth fixing.

Say an OCW computes a large solution. The process to reduce the size of the solution is undefined. But regardless, whatever we do, we'll end up reducing the edge backing stakes of the winners and thus the solution will surely have a worse score than it initially had. Moreover, once we have PJR-test, this will almost surely cause to not be PJR. Thus, this whole effort is moot.

Once we have two phase submission, this will be mitigated entirely. With two phase submission, the results will we stored with a deposit, so the entire weight of this call will be removed.


CASMINST-4157: Increase some test timeouts to avoid false failures

This is the csm-1.0 backport of the relevant pieces of this PR:
https://github.com/Cray-HPE/csm-testing/pull/218
I also pulled in the license check changes from https://github.com/Cray-HPE/csm-testing/pull/220 (which is why the number of files changed is so large -- almost all are just header changes)

Going to backport my license check fixes from 1.2

I verified that the typo found in the 1.2 PR does not exist here.


display data values

Is it possible to use Chart.js to display data values above the chart?
i want the user to print the graph....
Something like that but with the api..
http://jsfiddle.net/uh9vw0ao/

See https://github.com/chartjs/Chart.js/blob/master/samples/data_label_combo-bar-line.html for how to do this in v2.
Closing as duplicate.


Json.Net does not work with Squirrel package creator

I am building an app and using Squirrel for my package creation and updating. It seems there is some issue between Squirrel and Json.net. I tested this over and over and it seems to not be a problem when using OneClick or just launching the exe from the solution folder, and the issue goes away when using the Microsoft provider JSON serializer namespace.
Source/destination types
Any type of serialization, deserialization, or parsing. No matter is used.

Expected behavior
Should work with no issue, and does so when just launching the exe, or using OneClick
Actual behavior
No serialization or parsing occurs, no errors, just nothing happens.
Steps to reproduce
Just use any Json.net function with Squirrel.

I don't know anything about Squirrel. You will need to ask them.
There isn't anything special about the Newtonsoft.Json NuGet package or DLL.


Debugging Egeria client code - sources not found

In order to reproduce a reported problem I created a new IntelliJ project just containing my test code.
I had previously built egeria from source (master) which populated maven artifacts into my ~/.m2, as well as specified our snapshot repo within the test project's maven pom.xml via
    <version>1.0-SNAPSHOT</version>
    <repositories>
        <repository>
            <id>egeriasnap</id>
            <name>Egeria Snapshot Repo</name>
            <url>https://odpi.jfrog.io/odpi/egeria-snapshot</url>
        </repository>
        <repository>
            <id>central</id>
            <name>Maven Central</name>
            <url>https://repo1.maven.org/maven2/</url>
        </repository>
    </repositories>

When debugging in the test project, and dropping into the egeria client code, IntelliJ was able to decompose the class files fairly well .. however it was not picking up the actual source.
The option to 'download sources' resulted in an error
Sources not found for: org.odpi.egeria:ocf-metadata-client:1.1-20191004.123226-31

In my local ~/.m2 I had the following from my master build:
➜  egeria cd ocf-metadata-client
➜  ocf-metadata-client ls
1.1-SNAPSHOT             maven-metadata-local.xml
➜  ocf-metadata-client cd 1.1-SNAPSHOT
➜  1.1-SNAPSHOT ls
_remote.repositories
maven-metadata-egeriasnap.xml
maven-metadata-egeriasnap.xml.sha1
maven-metadata-local.xml
ocf-metadata-client-1.1-20190927.155640-22.jar
ocf-metadata-client-1.1-20190927.155640-22.jar.sha1
ocf-metadata-client-1.1-20190927.155640-22.pom
ocf-metadata-client-1.1-20190927.155640-22.pom.sha1
ocf-metadata-client-1.1-20191004.123226-31-sources.jar.lastUpdated
ocf-metadata-client-1.1-20191004.123226-31.jar
ocf-metadata-client-1.1-20191004.123226-31.jar.sha1
ocf-metadata-client-1.1-20191004.123226-31.pom
ocf-metadata-client-1.1-20191004.123226-31.pom.sha1
ocf-metadata-client-1.1-SNAPSHOT-javadoc.jar
ocf-metadata-client-1.1-SNAPSHOT-sources.jar
ocf-metadata-client-1.1-SNAPSHOT.jar
ocf-metadata-client-1.1-SNAPSHOT.pom
resolver-status.properties
➜  1.1-SNAPSHOT

whilst jfrog has
ocf-metadata-client-1.1-20190930.122708-28.pom           30-Sep-2019 12:27  1.39 KB
ocf-metadata-client-1.1-20191001.092428-29-javadoc.jar   04-Oct-2019 07:29  154.03 KB
ocf-metadata-client-1.1-20191001.092428-29-sources.jar   04-Oct-2019 07:29  54.83 KB
ocf-metadata-client-1.1-20191001.092428-29.jar           01-Oct-2019 09:24  59.44 KB
ocf-metadata-client-1.1-20191001.092428-29.pom           01-Oct-2019 09:24  1.39 KB
ocf-metadata-client-1.1-20191004.072919-30-javadoc.jar   04-Oct-2019 12:32  154.01 KB
ocf-metadata-client-1.1-20191004.072919-30-sources.jar   04-Oct-2019 12:32  54.83 KB
ocf-metadata-client-1.1-20191004.072919-30.jar           04-Oct-2019 07:29  59.44 KB
ocf-metadata-client-1.1-20191004.072919-30.pom           04-Oct-2019 07:29  1.39 KB
ocf-metadata-client-1.1-20191004.123226-31.jar           04-Oct-2019 12:32  59.44 KB
ocf-metadata-client-1.1-20191004.123226-31.pom           04-Oct-2019 12:32  1.39 KB

As can be seen from this, some builds do include the sources (-sources.jar), others dont.
Debugging java software with maven nicely requires these sources are available to 3rd parties (for open source it's no concern sharing), indeed upload to maven central MANDATES source.
So there is something wrong in the build/upload - profiles perhaps, which needs investigating to better support consumers of Egeria.
Investigating ....

The build process in maven looks ok.
The pipeline in Azure looks good https://dev.azure.com/odpi/Egeria/_build/results?buildId=287&view=logs&j=ac0a620f-bc12-5590-dc41-1227e7934d92
Even jfrog artifactory is confirming for that build that the 'sources' were published https://odpi.jfrog.io/odpi/webapp/#/builds/Egeria/20191004.2/1570191159739/published
Look at the directory listing more closely
ocf-metadata-client-1.1-20190930.122708-28-javadoc.jar   01-Oct-2019 09:24  153.96 KB
ocf-metadata-client-1.1-20190930.122708-28-sources.jar   01-Oct-2019 09:24  54.83 KB
ocf-metadata-client-1.1-20190930.122708-28.jar           30-Sep-2019 12:27  59.44 KB
ocf-metadata-client-1.1-20190930.122708-28.pom           30-Sep-2019 12:27  1.39 KB
ocf-metadata-client-1.1-20191001.092428-29-javadoc.jar   04-Oct-2019 07:29  154.03 KB
ocf-metadata-client-1.1-20191001.092428-29-sources.jar   04-Oct-2019 07:29  54.83 KB
ocf-metadata-client-1.1-20191001.092428-29.jar           01-Oct-2019 09:24  59.44 KB
ocf-metadata-client-1.1-20191001.092428-29.pom           01-Oct-2019 09:24  1.39 KB
ocf-metadata-client-1.1-20191004.072919-30-javadoc.jar   04-Oct-2019 12:32  154.01 KB
ocf-metadata-client-1.1-20191004.072919-30-sources.jar   04-Oct-2019 12:32  54.83 KB
ocf-metadata-client-1.1-20191004.072919-30.jar           04-Oct-2019 07:29  59.44 KB
ocf-metadata-client-1.1-20191004.072919-30.pom           04-Oct-2019 07:29  1.39 KB
ocf-metadata-client-1.1-20191004.123226-31.jar           04-Oct-2019 12:32  59.44 KB
ocf-metadata-client-1.1-20191004.123226-31.pom           04-Oct-2019 12:32  1.39 KB

There is some time overlap going on. The builds I linked to above are the 12:32 builds from 4 Oct.
Yet at this very same time the javadoc, sources for the PREVIOUS build was published.
I don't believe there's an issue with egeria, but maybe with azure or artifactory. Since atifactory IS reporting these artifacts as published, it //looks// like a jfrog problem at this time.
Inclined to see if this is just a one off or re-occurs....

@bramwelt Any ideas what could have happened?
It does not look to be artifact specific, but is specific to this run of the build
Looking at the full directory https://odpi.jfrog.io/odpi/egeria-snapshot/org/odpi/egeria/open-lineage-services-server/1.1-SNAPSHOT/ there are some other oddities where the file update time is days/weeks different from the artifact date. The issue described here has occured a small number of times since we've been running azure/jfrog

Hmm..this is odd. I'm not sure what's happening here; taking a look.

This is very strange. It would appear the javadoc and sources aren't showing up until the next merge happens. I kicked off another build, and saw the open-lineage-services-server now has the 20191004.123315-31 snapshot has javadocs and sources, but 20191004.205612-32 does not!

Seems to be this issue but they say it was fixed in a previous version. So either it wasn't actually fixed or somehow the issue has regressed - Either way I'm going to open a support request to see if we can get some more eyes on this from JFrog.

Thanks - it does look strange. Only noticed it when I created an external/standalone project ( to try and act more like an egeria consumer ).
We can clearly change our build process if needed, but given local m2 looks correct, and azure/even jfrog logs look as if they are trying to post the correct artifacts, it does look more like a jfrog problem with indexing as you describe, and in any case I have no idea what to change to get jfrog to be happier.

One extra bit of info - the build process first created an empty sources/javadoc jar file (0 length), THEN later in the build will overwrite with actual sources/javadoc. This was needed to satisfy maven central, and indeed is documented in their FAQ, as some of our modules don't contain real source, and javadoc. But that is all within the actual maven process, not the publishing afterwards. But mentioning in case there's some interaction here. (it worked for nexus+maven central on our 1,0 release)

I checked the most recent build, and indeed that pattern is repeating itself - we are never getting the correct/latest sources until after the next build.
I flipped the repo for snapshots in my test project back to nexus, and it worked perfectly. Intellij correctly downloaded sources and was able to debug against the original source in maven artifact. Much smoother. Checking the repo directly again shows nexus was just right.
So Nexus works, jFrog fails

I noticed 1.26.2 is current version of jfrog cli tools (used in azure dev pipelines). 1.29.1 is current. that being said there was no reference to fixed issues in this area at https://bintray.com/jfrog/jfrog-cli-go/jfrog-cli-linux-amd64#release but maybe worth a try (if we can control it) .

I raised the issue with JFrog, and CC'd you on the email. Hopefully we'll hear back from them soon.
An interesting note as well - this doesn't appear to affect non-SNAPSHOT versions. In the testing I've done for a mock release all the files are there.

I think we may have had a jfrog indexing issue crop up in https://github.com/odpi/egeria/issues/1702
Very odd, but looks like our docker build picked up a few old artifact. I'm guessing related, but if you prefer we can reopen 1702... the most recent build was fine but worrying as to what the build did....

@bramwelt any news from jfrog on this?

@planetf1 They said were not able to reproduce. Today I had the time to successfully reproduce the issue locally with the most recent artifactory-oss container and their own maven-example project, and I'll should have a walkthrough written up tomorrow.

Thanks for the update -- great progress having a simple test case.

@planetf1 Here's the gist for reproducing the issue.
Interestingly it appears the Artifactory "Builds" system is not involved - Though it might be able to help, we'll see.
Responding to the issue I raised with JFrog, and will let you know when they've gotten back to me and hopefully directed us in the right direction - Or identified the bug that might exist in Artifactory. :crossed_fingers:

Any further news?

The last response I got was from yesterday saying they'd reproduced and were going to look into it future.

Thank you for your patience.
I would like to update you that we are currently working together with R&D to provide a fix for this behavior.
Once the fix will be ready, we will test it and release it.
I will personally update you once the fix is ready, which will be around next week.

This is the update I received this morning.

Waiting on jfrog - we cannot fix this for 1.2, and in any case it is only affecting our internal builds, not release builds, so will only effectively affect those working directly with master.

Pinged JFrog on an update for this today - They were supposed to get back to me, though maybe they were busy with Kubecon prep :woman_shrugging:. Will update when I hear something.

JFrog got back to me stating version 1.31.0 of the CLI was released with a fix for this yesterday. I confirmed it works locally, and seems to be working for 1.3-SNAPSHOTS (master merges) currently as well!
https://odpi.jfrog.io/odpi/list/egeria-snapshot-local/org/odpi/egeria/admin-services-server/1.3-SNAPSHOT/

Superb ! That's looking good. Thanks for chasing up. I think we can close now.


kselftests: add uuidgen to RDEPENDS

Kselftests net/rtnetlink.sh fails due to uuidgen isn't installed into
the rootfs:
./rtnetlink.sh: line 280: uuidgen: command not found
Signed-off-by: Anders Roxell<EMAIL_ADDRESS>

typo in the commit message: kselftesets -> kselftests

updated changelog


New App: IPL Cricket

New T20 app that shows scores for the Indian Premier League, starting April 1
Similar to my other T20 cricket apps with a couple more new details

Shows what's happened over the last 12 balls
Shows what the team batting second need to win and off how many balls

Thanks for the PR!


Add platform matcher

Codecov Report

Merging #228 into master will increase coverage by 0.29%.
The diff coverage is 77.14%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
+ Coverage   62.74%   63.03%   +0.29%
==========================================
  Files          40       41       +1
  Lines        3057     3114      +57
  Branches      364      376      +12
==========================================
+ Hits         1918     1963      +45
- Misses       1047     1055       +8
- Partials       92       96       +4

Impacted Files
Coverage Δ

vmmaster/webdriver/commands.py
68.3% <ø> (ø)
:arrow_up:

vmmaster/app.py
86.27% <100%> (+0.56%)
:arrow_up:

vmmaster/webdriver/helpers.py
68.15% <100%> (+0.41%)
:arrow_up:

vmpool/endpoint.py
80% <45.45%> (-10%)
:arrow_down:

vmmaster/matcher.py
81.13% <81.13%> (ø)

core/clients/docker_client.py
46.31% <0%> (+0.57%)
:arrow_up:

core/auth/custom_auth.py
67.39% <0%> (+2.17%)
:arrow_up:

vmpool/__init__.py
91.66% <0%> (+2.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724a6bb...f68680c. Read the comment docs.

!test

!test

!test


[docs] Inconsistency and Potential Breaking Change in Documentation for no-useless-fragment Rule

Issue Description
I am currently migrating from eslint-plugin-react to eslint-react and have observed potential inconsistencies and incorrect examples in the documentation for the no-useless-fragment rule. Below are the details along with concerns about a possible change to the rule's behavior.
Documentation Comparison

eslint-plugin-react#Disallow unnecessary fragment
The documentation lists several examples of incorrect code for this rule, including:
<Fragment>foo</Fragment>
<React.Fragment>foo</React.Fragment>

These examples suggest that using a fragment to wrap a single child is incorrect. However, no more specific information was provided, such as whether return <Fragment>foo</Fragment> is incorrect.

eslint-react#no-useless-fragment:
Under the failing examples, the eslint-react documentation includes:
import React, { Fragment } from "react";

function Example() {
  return <Fragment>foo</Fragment>;
  //     - Fragments containing a single element are usually unnecessary.
}

This implies that using a <Fragment> to wrap a single element is considered incorrect by the rule. Is a more concrete code example

Issue
In practice, neither eslint-plugin-react nor eslint-react currently flags the code return <Fragment>foo</Fragment>; as an error. This is consistent with other examples in the eslint-plugin-react documentation where similar uses of fragments are deemed correct, such as:
const cat = <>meow</>

This suggests that users are allowed to decide whether to return a string directly or wrapped in a JSX element without triggering the no-useless-fragment rule.
Concerns About Rule Modification

Potential Breaking Change: Modifying the rule to make the current examples trigger an error could introduce a breaking change for users migrating from eslint-plugin-react. This might lead to unexpected behavior and frustration among the user base.

Limiting User Flexibility: Forcing a change in this rule would prevent users from returning a single child as a JSX.Element when they deem it necessary. This could limit flexibility in coding styles and practices.

Suggested Action
I believe the documentation might need a thorough review and possible correction to accurately reflect the actual behavior of the rule and avoid any unintended breaking changes. It would be beneficial to align the rule's behavior with its documentation or clarify the intended use cases more clearly.

Thanks for the feedback on the issue and I agree that the documentation needs a thorough review and possible corrections.

2. Limiting User Flexibility: Forcing a change in this rule would prevent users from returning a single child as a JSX.Element when they deem it necessary. This could limit flexibility in coding styles and practices.

It is the limitation of TypeScript, and since TypeScript 5.1, TypeScript now allows a component to return React.ReactNode instead of React.ReactElement. The React always allows rendering a React.ReactNode, so I don't see any reason why <>{single child}</> is needed.

Limiting User Flexibility: Forcing a change in this rule would prevent users from returning a single child as a JSX.Element when they deem it necessary. This could limit flexibility in coding styles and practices.

It is the limitation of TypeScript, and since TypeScript 5.1, TypeScript now allows a component to return React.ReactNode instead of React.ReactElement. The React always allows a component to render React.ReactNode, so I don't see any reason why <>{single child}</> is needed after TypeScript 5.1.

https://snyk.io/advisor/npm-package/typescript
Considering that typescript 4.9.5 still gets 9.4M weekly downloads, let's keep the current behavior of this rule for now.

Limiting User Flexibility: Forcing a change in this rule would prevent users from returning a single child as a JSX.Element when they deem it necessary. This could limit flexibility in coding styles and practices.

It is the limitation of TypeScript, and since TypeScript 5.1, TypeScript now allows a component to return React.ReactNode instead of React.ReactElement. The React always allows a component to render React.ReactNode, so I don't see any reason why <>{single child}</> is needed after TypeScript 5.1.

I'd like to highlight three main points in response:

Focus on Documentation Accuracy: The primary concern raised in this issue is the accuracy of the documentation. It presents examples of code that would supposedly trigger errors when this rule is enabled, yet these codes do not actually result in errors in real scenarios. This leads to the following question: Should we update the documentation or change the code behavior to address this discrepancy? Either approach could resolve the issue, but which one is more appropriate?

Assumptions About User Environment and Knowledge: We should not assume the level of knowledge or the specifics of the development environment of all users. Many may not be aware of this context. Changing the code to make return <Fragment>foo</Fragment>; result in an error could confuse users migrating from eslint-plugin-react, even if we thoroughly document this change. The unexpected behavior could lead to significant frustration.

Existing User Habits and TypeScript Allowances: Given the prevalence of eslint-plugin-react, we must acknowledge that some users have grown accustomed to certain behaviors. Even though TypeScript 5.1 now allows a broader range of return types, insisting that users change from return <>114514</> to return 114514 seems peculiar. Moreover, many users may still be using versions prior to TypeScript 5.1.


Adding config to use let controller/broker/server to set hostname

The motivation for this PR is to support cloud deployment in k8s.
In a cloud deployment, usually ip address is not guaranteed to be the same.
So we need to use container provided hostname, e.g. in k8s, we can use statefulset.apps to deploy multiple pinot brokers, each instance will be named as pinot-broker-0, pinot-broker-1, ...

Codecov Report

Merging #4517 into master will decrease coverage by 21.4%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##             master   #4517       +/-   ##
============================================
- Coverage      64.6%   43.2%   -21.41%
============================================
  Files          1073    1073
  Lines         55707   55719       +12
  Branches       8113    8117        +4
============================================
- Hits          35990   24071    -11919
- Misses        17080   29493    +12413
+ Partials       2637    2155      -482

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/pinot/common/utils/CommonConstants.java
34.61% <ø> (-3.85%)
0 <0> (ø)

.../pinot/broker/broker/helix/HelixBrokerStarter.java
69.53% <0%> (-3.62%)
0 <0> (ø)

...org/apache/pinot/controller/ControllerStarter.java
64.74% <25%> (-3.78%)
0 <0> (ø)

...pinot/server/starter/helix/HelixServerStarter.java
44.25% <66.66%> (+0.04%)
0 <0> (ø)
:arrow_down:

.../org/apache/pinot/common/http/MultiGetRequest.java
0% <0%> (-100%)
0% <0%> (ø)

...che/pinot/common/restlet/resources/TablesList.java
0% <0%> (-100%)
0% <0%> (ø)

...che/pinot/pql/parsers/pql2/ast/OptionsAstNode.java
0% <0%> (-100%)
0% <0%> (ø)

...ot/core/query/scheduler/TableBasedGroupMapper.java
0% <0%> (-100%)
0% <0%> (ø)

...t/core/segment/index/readers/OnHeapDictionary.java
0% <0%> (-100%)
0% <0%> (ø)

...mmon/config/instance/InstanceAssignmentConfig.java
0% <0%> (-100%)
0% <0%> (ø)

... and 572 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c920824...9223af0. Read the comment docs.

Instance_id is part of helix instance id (Broker_xxxx/Server_xxxx). So it will be logged everywhere along with helix stuffs during startup.


Please invite me to the Recode-Hive GitHub Community Organization

Name
Abinesh
Discord Username (if applicable)
No response
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


Pricing around compose model is not clear

Pricing around compose model needs to be clarified. Is it the same if we use compose custom neural model or just a custom neural model?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9e3685d5-5c86-7262-6285-fb17dd01fd3e
Version Independent ID: 7f2e58a5-1a53-ba94-bde1-c17c995c4923
Content: Composed custom models - Form Recognizer - Azure Applied AI Services
Content Source: articles/applied-ai-services/form-recognizer/concept-composed-models.md
Service: applied-ai-services
Sub-service: forms-recognizer
GitHub Login: @laujan
Microsoft Alias: lajanuar

@sanjaydatasciencedojo
Thanks for your feedback! We will investigate and update as appropriate.

Hi @YashikaTyagii, do you have any update to share on this?

Hi @sanjaydatasciencedojo,
Thank you for your feedback.

The price is the same whether you are using a composed model or selecting a specific model.
Each document is analyzed by only one model.
With composed models, you are essentially telling us, "I don't know which of the composed models is best for this document", the system performs a classification to check which of the composed models should be invoked and invokes the best model for the document.

I hope that clarifies how pricing works with composed models. We will also update the documentation.
This issue will be closed as resolved. If you have further concerns, please feel free to reopen.
Thanks again!
cc: @YashikaTyagii

#please-close


Marker genes with chromatin accessibility

Hi Fabio,
Q: Show the 10 top marker peaks for schwann in h_sapiens nerve.
There is a 500 internal error when using the API for markers with chromatin accessibility at this URL:
https://api.atlasapprox.org/v1/markers?organism=h_sapiens&organ=thyroid&celltype=schwann&number=10&measurement_type=chromatin_accessibility.
and 400 error when using node.js

This is confirmed and due to data quantisation, I'm trying to fix it


Remove starcoder pipeline reference from README.md

PR removes the reference to the star coder pipeline from readme

Thanks Matthias :) Can you also remove the starcoder components from the reusable components table in the same readme?

I've also updated the list of ready-made pipelines on top.


Add support to additional 'fixed-key-metadata'

Add support for the following additionnal "fixed-key" metadata

content_encoding
cache_control
content_disposition
content_language
custom_time

Google documentation:
https://cloud.google.com/storage/docs/metadata#mutable
fixes #426

Thanks for the PR.
Leading up to pydata, I'm not sure when I'll be able to look at this, perhaps someone else has the time. I do notice that it adds quite a lot of lines, and wonder whether it might be made more compact - i.e., it's not necessary to use the same logic as was used for content-type .

i'll open a new one with less change, i'm closing this one


symfony-cli: 5.4.2 -> 5.4.5

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/symfony-cli/versions.
meta.description for symfony-cli is: "Symfony CLI"
meta.homepage for symfony-cli is: "https://github.com/symfony-cli/symfony-cli"
meta.changelog for symfony-cli is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5/bin/generator had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5/bin/symfony-cli had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 5.4.5 with grep in /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5
found 5.4.5 in filename of file in /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
symfony-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A symfony-cli https://github.com/r-ryantm/nixpkgs/archive/d0e3a3696147b5d49ce4489e86b92b0c33c8c3b5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5
ls -la /nix/store/cc0x9brrwsc5j1kxr3wln0mzp6dwdkik-symfony-cli-5.4.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

symfony-cli

Maintainer pings
cc @drupol @kalbasit for testing.

@GrahamcOfBorg eval


NCDA CHW Questionnaire - tasks tray for Child Scoreboard encounter [8h]

Tasks:

View and style tasks tray.
Logic for displaying dynamic number of tasks, as Antenatal care is optional.
Logic for styling task per it's state - active, completed, etc..
Logic for navigation between tasks, once 'Save' button is clicked. Actual save is performed only when all tasks are completed.
Tasks tra to appear for NCDA activity of all individual encounters. Activity at group remains as it was.

Link to icons: https://www.figma.com/file/l0bvoD2VyyFc146VVIYWOQ/NCDA?type=design&node-id=2-3&mode=design&t=Ra9eTDF5s2zkZKY9-0

@Diama1 please integrate the icons. See https://github.com/TIP-Global-Health/eheza-app/pull/779#issuecomment-1637004286.

NCDA is on live for few months. Closing.


Switch Raman Base Reader to Multiformat Reader

I used the XPS Multiformat reader as base @lukaspie and will need some serious help to finalize this.
I tried to adapt the XPS Scienta TXT reader to enable the right now present eln_data.yaml from a Raman Witec output. As im right now  lost at which point which modifications have to be done, ill focus right now on a parser for the .txt format.
Could be, that my apppraoch is completely incorrect and it is better to set it up new.

The current status is, that I can run:
dataconverter convert --reader raman --nxdl NXraman examples/witec/txt/eln_data_witec_txt.yaml --output witec_txt_output.nxs
and .nxs file is created, but the file is completly empty.

just a note that https://github.com/h2020charisma/ramanchada2 has support for many spectroscopy formats

just a note that https://github.com/h2020charisma/ramanchada2 has support for many spectroscopy formats

Ill take a look. Hopefully we could use this to implement more methods faster. Thanks!


Introduce a (temporary) dlsym check for swift_willThrowTypedImpl.

Inlined code using the special 9999 availability is always getting executed, even on older standard library implementations, causing a runtime failure due to a missing symbol. Avoid this problem by doing an extra dlsym check for the symbol before calling it.
This issue will go away when we can remove the 9999 availability.
Fixes rdar://124388996.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Explicitly supply the model source

So that reorderItems action handler knows which model it is modifying.
Updated code examples in README.
per #22

Need to work on test cases....

This is great! Thanks so much :D
One thing we need to consider is that people will have existing action handlers that expect to receive items as the first argument. This change would break that expectation.
Here's what I propose:
When model is set on sortable-group, the onChange action is sent with two arguments: groupModel and itemModels.
Otherwise the behaviour is the same as v1.0.0: onChange I sent with only itemModels.
How does that sound to you?

sure. Gimme a few minutes to make the change.

This is really brilliant work.
Regarding the potential mis-spelling of group’s model attribute:
That’s a very good point. We should assume that if the user is using the model attr on sortable-group then they expect to receive the two argument form of the action.
Perhaps we could give sortable-group’s model a sentinel value to detect whether or not it has been set? This would also give us the opportunity to inline-document the property.
const NO_MODEL = {};

export default Component.extend({

  // ...snip...

  /**
    @property model
    @type Any
    @default null
  */
  model: NO_MODEL,

  // ...snip...

  commit() {
    let groupModel = this.get('model');

    // ...snip...

    if (groupModel !== NO_MODEL) {
      this.sendAction('onChange', groupModel, itemModels);
    } else {
      this.sendAction('onChange', itemModels);
    }
  }
});

This may be achievable more simply with undefined. What do you think?

Thanks! It's been a good learning experience for me too. :)
Let me give that a spin and see.

Going to call it a night but will pick up the thread in the moring. This is super close to being ready to merge :)

Should be good. Have a good night!

Perfect. LGTM

Awesome!


Updated broken "session.py" link in README

The old README link used backslashes instead of forward slashes, which caused a broken URL when viewed on Github.

@meson800 great PR! This repo isn't being maintained, as you can tell by the number of issues and PRs that are open. I'd suggest merging onedrivesdk-fork's changes into your repo with a PR, and then making a PR to them.

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information


cleans up can.Compute.read and adds template-obserbable promises

For #179, this makes promises observable when read by can.Compute.read.
Promises in the template.
This powers promises in the template like:
{{#if promise.isPending}}{{/if}}
{{#if promise.isRejected}}{{promise.reason.message}}{{/if}}
{{#if promise.isResolved}}{{promise.value.message}}{{/if}}

This should work with any promise that passes can.isPromise.  Currently, only objects with .then and .pipe are considered promises.  Users can overwrite this to be more permissive.
The following properties on a promise are available:

isPending
isResolved
isRejected
value - the resolved value of the promise, only available if isResolved is true.
reason - the rejected value, only available if isRejected is true
state - "pending", "resolved", or "rejected"

This only makes promises observable in a template.  If you were to use a promise in a compute, it will not re-evaluate the compute when the promise changes.  However, with async getters and setters, you can wire up changes in the observable state to changes in a value yourself.
Changes to can.Compute.read
can.Compute.read is moved into its own file: compute/read.js.  It also is designed to be a bit more extensible.  The read function uses a list of valueReaders and propertyReaders to read the properties from parent.
valueReaders are used for things like functions and computes, which do not have a property to read.
propertyReaders are used to read properties on an object, can.Map and now promise.
This change allows us to provide multiple ways to translate the DOT operator into specific ways of reading values for the template.
In the future, I think we should make can.compute(parent, "foo.bar") use can.Compute.read.  This would allow:
var value = can.compute(map,"promise.value.first.name")

where map's "promise" attribute is a promise that returns another map that has a "first" attribute which is a map with a "name" attribute.

Out of curiosity:
How did you solve the use case where you have a pipeline of then calls, where any of those calls are susceptible to using computed properties? In such a case the chain of promises could, at any point in the chain, need partial re-computation and re-evaluation.
You'd only want to recompute the chain moving forward from that one particular point where a change occurs in a depending computed property, because in general it could be unsafe or extremely wasteful to recompute the entire chain. (In particular when the chain involves one or more XmlHttpRequests taking place.)

@rjgotten can.compute only calls the "computing" function when one of its source values change.
Lets say you did something like:
{{compute1.promise.value.compute2.promise.value}}
Where your data looked like:
var params1 = new can.Map({});
var params2 = new can.Map({message: "Hello There"});

var getData = function(params){
  return new Promise(function(resolve){
    setTimeout(function(){
       var compute = can.compute(function(){
         return {promise: getMessage(params2.attr()) };
       });
       resolve({compute2: compute2});
    },100);
  })
};

var getMessage = function(attrs){
  return new Promise(function(resolve){
    resolve(attrs.message);
  })
};

var dataToTemplate: {
  compute1: can.compute(function(){
    return {promise: getData(params1.attr())}
  })
}

If I were to change params2's message:
params2.attr("message", "Goodbye")

Only getMessage will be called again.  getData will not.
The reason is that despite compute1.promise.value.compute2.promise.value having to be read, when compute1 is re-read, it will return the same object in memory until one of its source observables has changed (in this case params1).  Because params1 has not changed, it uses the same promise originally returned by getData.

Ah! So it's the underlying cache retained while a binding is attached that does the magic here.
Nice.
 Well; as of CanJS 2.x anyway. The 1.x version was kind of 'meh' having a hard dependency on the then `can.Observe. ;-) )


Convert ProcessList to class

Hide implementation details and provide accessors for the list
Test: cmake --build .

I should say - I like very much I do not have to build on windows locally now to check for compilation errors!


[Bug]: page loading mixed content over https

Description
I enabled https in the domain but my content is still loading with http
Minimal Reproduction (if possible, example repository)

Exception or Error
No response
Version
beta.190

This will be fixed in the upcoming release. Please read #1650


Windows cmd shim seems off

Windows CMD shims are incorrect
The symlinking process appears to cmd shims the cmd shims, creating foo.cmd.cmd in the nested projects' node_modules/.bin

Version
0.19.3

Type
Issue

Node
8.11.1

OS
Windows 7

Short Desc
The cmd shims built into the projects' node module bin area do not work as expected.

Detailed Desc
Running a bare bolt command on my bolt project seems to set all deps up correctly however when creating the cmd shims in each projects' node_module/.bin there seem to be two created, the original foo.cmd and an additional foo.cmd.cmd. The npm scripts within my subprojects will try to invoke the former cmd shim and fail on The system cannot find the path specified from the shims first line "$basedir/../../../../node_modules/.bin/react-scripts.cmd" however if I manually invoke the foo.cmd.cmd that executable works as expected.

Difference between two cmd shims found in the same project's node_modules/.bin

Hiya,
We don't do any testing on windows machines here, the windows support was added by the community. Would you mind looking at the cause and creating a pr?
Also, is it possible some of those were there before you ran bolt? Could you try deleting your node modules and trying.
Lastly, @marshallofsound (I'll tag him properly when I get to a computer) might be able to give some insight here.

Hey @lukebatchelor I did try nuking the .bin of the "sub" project in question to make sure that bolt  was generating them and it was :(
...3 minutes later...
I just went to try it again using basic windows cmd, because I had been using Cmder before, and I do NOT observe the problem anymore :man_facepalming: So sorry about that. Ignore me.


adding languages flags section

Hey, thanks for the pull request!

The domains are movapp.cz, sk.movapp.eu, pl.movapp.eu, the domains are live so pls fix your links to make them work
The first flag should be Czech-Ukrainian, not Brittish-Ukrainian (the czech version should be in the same figma file somewhere)
Not sure about moving the App download buttons inside the white rectangle, the previous UX opinion is that the white rectange is for things inside the web, mobile apps do not semantically belong there and should be below. @met What do you think?

@JuroUhlar Yes. I agree will all you said.

1.) Great, I will do that, links visible on the website (under the flags) can stay in the format as they are?
2.) Ok, so there should be 4 flags in this section? (cz, en, sk, pl)
3. ) Yees, I did this version exactly according to Figma file but I think the best approach would be to leave apps buttons under white rectangle and just add a heading above these buttons (so it would have the same design as flags section below)

Yes! Format is fine, just adjust the link texts please :)
No, there is no english version, I don't know why its in the mockup. It's more of an ideation I guess. Sorry, I should have checked the mock-up in more detail before. We have three language variants: movapp.cz, sk.movapp.eu, pl.movapp.eu
Yes, let's do that. Two designers, two opinions, but @met says below, we put them below. Thanks! :)


https streams on Ubuntu 22.04 might emit PHP warnings during fread()

PHP version: 8.1.2
Description
Because of php/php-src#8369 a https stream might emit a Warning when calling fread() on the underlying stream. If a user of PSR-7 uses an error handler that converts warnings into Exceptions then the call to ->read() might violate read()'s contract to throw a RuntimeException is cases of failure.
How to reproduce
<?php

use GuzzleHttp\Client;
use GuzzleHttp\Handler\CurlMultiHandler;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Psr7\Request;

error_reporting(E_ALL);
function exception_error_handler($severity, $message, $file, $line) {
    if (!(error_reporting() & $severity)) {
        return;
    }
    throw new ErrorException($message, 0, $severity, $file, $line);
}
set_error_handler("exception_error_handler");

require('vendor/autoload.php');

$client = new Client([
	'stream' => true,
]);

$request = new Request(
	'GET',
	'https://www.umwelt.niedersachsen.de/assets/image/1200/216904',
);

$response = $client->send($request, [
	'timeout' => 1,
]);

$body = $response->getBody();

while (!$body->eof()) {
	$v = $body->read(2048);
	var_dump(gettype($v));
}

# var_dump($response);

Possible Solution
The call to fread():
https://github.com/guzzle/psr7/blob/58a607de30248bdbb28655d5d46661de5efd727c/src/Stream.php#L232
can be prefixed with @ to fix this issue. Note that fread() won't return false for this warning.. Alternatively a custom error handler might be attached before the call and detached afterwards.
Additional context
root@ubuntu-22:~/guzzle# php test.php
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
PHP Fatal error:  Uncaught ErrorException: fread(): SSL operation failed with code 1. OpenSSL Error messages:
error:0A000126:SSL routines::unexpected eof while reading in /root/guzzle/vendor/guzzlehttp/psr7/src/Stream.php:232
Stack trace:
#0 [internal function]: exception_error_handler()
#1 /root/guzzle/vendor/guzzlehttp/psr7/src/Stream.php(232): fread()
#2 /root/guzzle/test.php(35): GuzzleHttp\Psr7\Stream->read()
#3 {main}
  thrown in /root/guzzle/vendor/guzzlehttp/psr7/src/Stream.php on line 232

root@ubuntu-22:~/guzzle# php test.php
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
string(6) "string"
PHP Warning:  fread(): SSL operation failed with code 1. OpenSSL Error messages:
error:0A000126:SSL routines::unexpected eof while reading in /root/guzzle/vendor/guzzlehttp/psr7/src/Stream.php on line 232
string(6) "string"

Hmm, that's unfortunate.

might violate read()'s contract to throw a RuntimeException is cases of failure.

Throwing something that extends Error or RuntimeException is not a violation of a contact. I always take the view those those type of throwables are always fair game to be thrown at any time, just like with Java.

Throwing something that extends Error or RuntimeException is not a violation of a contact. I always take the view those those type of throwables are always fair game to be thrown at any time, just like with Java.

Don't want to nitpick here more than necessary, but ErrorException is just extends Exception and thus neither RuntimeException, nor Error, probably for historical reasons.
For RuntimeException I generally agree, but the cause of the warning is matches Java's IOException / EOFException more closely and that one is a checked exception in Java I believe.
Generally speaking the PHP Warning can be triggered by the remote server at will and thus it is unfixable by the user of the psr7 implementation, other than by catching \Throwable (which generally should be avoided, as this might mask other errors). Thus I believe it is up to guzzle/psr7 to ensure that the warning does not leave the read() method (either by @ or by a custom error handler).

diff --git i/src/Stream.php w/src/Stream.php
index d389427..5baecfa 100644
--- i/src/Stream.php
+++ w/src/Stream.php
@@ -229,7 +229,12 @@ class Stream implements StreamInterface
             return '';
         }

-        $string = fread($this->stream, $length);
+        try {
+            $string = fread($this->stream, $length);
+        } catch (\Exception $e) {
+            throw new \RuntimeException('Unable to read from stream', 0, $e);
+        }
+
         if (false === $string) {
             throw new \RuntimeException('Unable to read from stream');
         }

might be an acceptable fix as well. This ensures that any exception is then rewrapped as a RuntimeException, which is required by the PSR-7 standard:
     * @throws \RuntimeException if an error occurs.

Yeh, that would be a good solution.

Resolved with #505


Azure CycleCloud/Slurm default cluster config creates an (unused) Shared disk even when selecting to mount Shared from an NFS Server

Hi,
I am using the default Slurm cluster config template from version 3.0.1 - and it seems to create a 2GB Azure managed disk for the shared filesystem on the scheduler node even though I am mounting /shared from an NFS file server (the cyclecloud server). I think this should not be needed?
Here is a screenshot showing the disk in Azure:

Here, you can see the disk at the Linux OS (as sdb and no mount point):
[root@nemospot-scheduler ~]# lsblk -o NAME,HCTL,SIZE,MOUNTPOINT | grep -i "sd"
sda     0:0:0:0      30G
sdb     0:0:0:1       2G
sdc     1:0:0:0      60G
├─sdc1             1000M /boot
├─sdc2             58.5G /
├─sdc14               4M
└─sdc15             495M /boot/efi
sdd     1:0:0:1      75G
└─sdd1               75G /mnt
Here, you can see /shared mounted from the CycleCloud server via NFS:
[root@nemospot-scheduler ~]# mount | grep shared
azu-nemo-srv:/shared on /shared type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=<IP_ADDRESS>,local_lock=none,addr=<IP_ADDRESS>)
Would be good not to incur unnecessary Azure costs...

I have confirmed this same behaviour on Azure CycleCloud 8.5 / Slurm template 3.0.5

I can also confirm that this is existing on Slurm Cluster v.23.02.4-1, no matter which HPC Image I choose

we have fixed in cyclecloud and azslurm 3.0.6 versions


[Release Blocker] Need validation of all screens and texts.

Important release with possible legal side effects, we need a careful review and texts provided.
Current screenshots are provided to show implementation. All texts can and should still be changed. Please provide feedback and text on each screen before production rollout.

@sasha-astiadi do you know who has the ownership to validate these and provide the correct texts? It's not something I can decide for myself.
Would also need a final link to use for the terms and conditions link. ( Currently https://threefold.io/info/threefold#/legal__terms_conditions_griduser ) - This does not yet mention anything about BTC being changed into Stellar BTC when you deposit them.

tf connect staging app on android (download link) https://drive.google.com/file/d/1nRskDuQsCTpqASj1wzHxTMszBraKoawN/view?usp=sharing

document for t&c is being reviewed.

good to go.... t&c document comes later

@JonasWijne

[ ] replace 'buy' with 'Trade'

[ ] Trade Confirmation
By trading, you confirm that you agree with our [terms and conditions]link comes later

Price: (BTC / USD)
Amount: (BTC)
Total: (TFT)
'Confirm Trade'

t&c link https://threefold.io/info/threefold#/legal__terms_conditions_griduser
@JonasWijne
will still be this link, we just change the content to include btc once validated


PyPI API removal of top_packages

Cross-posting from https://github.com/meshy/pythonwheels/issues/94:

Download counts are being removed from PyPI and instead BigQuery needs to be used.
See https://github.com/pypa/warehouse/pull/2480 which removes the top_packages from the API.
Right now, PyPI is running from https://github.com/pypa/pypi-legacy but will be switching to https://github.com/pypa/warehouse soon.
See https://github.com/badges/shields/issues/716 and https://github.com/zhmcclient/python-zhmcclient/pull/73 for some more info on BigQuery.

Perhaps in the short term Python 3 readiness could use a hardcoded list of the top 360 packages.

Yes, top packages don't seem to change often.
We could, as you suggested, use hardcoded list.


change save registration endpoint to PUT

Scope of changes
This changes the method on the save registration endpoint from POST to PUT to be more inline with what it does, since we use it to both create and update the form.
SC-7641
Type of change

[ ] bug fix
[x] new feature
[ ] documentation
[ ] other (describe)

Acceptance criteria
Unit tests should pass.
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Thank you for making that change - I guess we don't have any tests for SaveRegisterForm?

@bbengfort We do but we should use the client instead of creating the request manually.

Thank you for making that change - I guess we don't have any tests for SaveRegisterForm?

@bbengfort We do but we should use the client instead of creating the request manually.

Awesome, would you mind making a story for that?

Thank you for making that change - I guess we don't have any tests for SaveRegisterForm?

@bbengfort We do but we should use the client instead of creating the request manually.

Awesome, would you mind making a story for that?

Sorry, miscommunication, I meant that we already use the client for those tests so there wasn't any need to update those tests.


All languages in all breadcrumbs

With multiple languages, our breadcrumbs solution picks up all languages. For instance, see the top on this criteria where Spanish, Danish and Chinese are all on previous and next.

Yup, fix is being worked on here


Return effective map value size for per-CPU maps

Signed-off-by: Alan Jowett<EMAIL_ADDRESS>Description
ebpf_map_get_info should return the effective map value size.
Testing
CI/CD
Documentation
No.
Resolves: #1420

This approach doesn't work. libbpf assumes returned size == size set at map creation and that the value returned for PERCPU maps is PAD8(value) * max cpus.


Payment shown as successful even though it's not yet done

When sending a lightning payment we immediately see a success dialog but the payment was not yet successful nor did it fail.
After some time, the payment in the history is shown as success or as failed.

production setup: iOS
commit hash 843f205452af6a972eb10deddaea68e9425c221d
build number: 2139
version 1.2.6

Error in logs says: no route found.
We could simply change the dialog or block until the payment succeeded or failed.

Fixed on main!


dragging .ply file for .splat conversion not working

Hello, thanks for sharing your work!
The readme file mentions dragging the output .ply file and automatic .splat conversion would be performed. I tested running the app with the Live Server plugin of VS code and upon dragging, the header of the .ply file is loaded but no conversion, using the URL to provide the location of the .ply file also fails.
Could you please provide some guidance on how to replicate this conversion? thanks.

this was an issue on my end, dragging the file for conversion works as intended.


tabs.query doesn't return unloaded tabs

Describe the bug
Can't get unloaded tabs in extension.
To Reproduce

Open some tabs and restart the browser so inactive tabs stay unloaded.
Open an extension page.
Open the developer tool. Run chrome.tabs.query({},console.log)
Switch to unloaded tabs so the browser load them.
Switch back to the developer tool. Run chrome.tabs.query({},console.log)

Expected behavior
The result should include all tabs in the browser and the first result should equal to the second.
Smartphone (please complete the following information):

Device: HTC_U-1u
Android Version : 8.0.0
Kiwi Browser Version 95.0.4638.50

Additional context
I was trying to port a tab management extension to android and found that kiwi doesn't return unloaded tabs.

Any news on this? Tried running one of my archiving extensions that use chrome.tabs.query to fetch all open tabs. And this issue threw a wrench in my plans 😅

FYI, Firefox doesn't support this either:
https://bugzilla.mozilla.org/show_bug.cgi?id=1583281


Mutiple SignalR hubs failed

Expected Behavior / New Feature
Using bellow config:
...
{
"DownstreamPathTemplate": "/rootFolder/project1/hubs/{project1Hub}",
"DownstreamScheme": "ws",
"DownstreamHostAndPorts": [
{
"Host": "localhost",
"Port": 80
}
],
"UpstreamPathTemplate": "/hubs/{project1Hub}",
"UpstreamHttpMethod": [ "GET", "POST", "PUT", "DELETE", "OPTIONS" ]
},
{
  "DownstreamPathTemplate": "/rootFolder/project2/hubs/{project2Hub}",
  "DownstreamScheme": "ws",
  "DownstreamHostAndPorts": [
    {
      "Host": "localhost",
      "Port": 80
    }
  ],
  "UpstreamPathTemplate": "/hubs/{project2Hub}",
  "UpstreamHttpMethod": [ "GET", "POST", "PUT", "DELETE", "OPTIONS" ]
}

...
I was expected to be able to connect on both hubs.
Actual Behavior / Motivation for New Feature
I was able to connect only to project1Hub, but on the second hub I get 404 error.
Steps to Reproduce the Problem
Specifications

Versions: Ocelot v.14.0.11 & net core 3.1 solution

Hello,
There seems to be a typo in the following line before "project2/":
"DownstreamPathTemplate": "/rootFolder/lproject2/hubs/{project2Hub}"

Kidding right?
Used names are demo only, in production everything is configured fine.
One more hint, it seams that if I do switch project1 with project2, now project2 is running and the other throw 404.

Any clue / workaround, anybody?
Regards,
Cosmin

Hello,
Both your reRoutes are the same: they have the same UpstreamPathTemplate ("/hubs/{whatever}") and UpstreamHttpMethod, but maybe it is only one more simplification in your example?
I can imagine the situation where the routing would work as you wrote... If your example is ok and a request is to '/hubs/project2Hub' then the first reroute will work, so the downstream path will be look like '/rootFolder/project1/hubs/project2Hub' and maybe it is not what you want?

Hi,
My initial idea was to have all hubs together under the same upstreamPath (/hubs). One solution would  be if I could configure to match exactly upstreamPath to downstreamPath but I think this is not possible. If there is not other option I will change the upstreamPath for the second project.

Duplicated routes!
Must be one Catch All:
    {
      "DownstreamPathTemplate": "/rootFolder/project1/hubs/{hub}",
      "UpstreamPathTemplate": "/hubs/{hub}",
    },

OR
    {
      "DownstreamPathTemplate": "/rootFolder/{project}/hubs/{hub}",
      "UpstreamPathTemplate": "/hubs/{project}/{hub}",
    },

Hope it helps!


[Bug] MacOS 下 Safari 中使用中文输入法时回车

Bug Description
MacOS 下 Safari 中使用中文输入法输入一些字符，此时输入的字符以英文输入输入框后立即被发送，而不是仅输入输入框
同设备下Chrome无此问题
Steps to Reproduce

将发送键设置为Enter
切换到中文输入法
输入一些字符
按一次回车
输入的字符以英文输入输入框后立即被发送

Expected Behavior
字符仅输入输入框，不被发送
Screenshots
No response
Deployment Method

[X] Docker
[ ] Vercel
[ ] Server

Desktop OS
MacOS 14.4
Desktop Browser
Safari
Desktop Browser Version
17.4
Smartphone Device
No response
Smartphone OS
No response
Smartphone Browser
No response
Smartphone Browser Version
No response
Additional Logs
No response

Mac 版桌面 App 也是这个问题，不得不切换成了 Ctrl + Enter 来发送

mac下safari测试也有这个问题，但是chromium类型的浏览器就没有这个问题

I've tested it and can't reproduce it. Can you provide the specific input content to reproduce the issue?

我设置成 shift + enter 发送，暂时能满足

I've tested it and can't reproduce it. Can you provide the specific input content to reproduce the issue?

actually anything

I've tested it and can't reproduce it. Can you provide the specific input content to reproduce the issue?

On MacOS, Tauri uses the Safari kernel by default, and Safari's event.isComposing is always false, and only keyCode is used to determine whether it is an input method state.

可以参考我的commit，加一行keyCode判断。这是非直接输入法在Safari中的React.CompositionEvent<HTMLTextAreaElement> 事件判断回车和空格等功能键为flase产生的Bug，

Merged, @freejool would you mind check whether the issue still exists again

@fred-bf I don't know if I'm doing right.

Your build has completed!
Preview deployment

I checked the build in #4322, and it's not fixed.
My service deployed in docker and I believe the fix is not released as docker img.

@fred-bf I don't know if I'm doing right.

Your build has completed!
Preview deployment

I checked the build in #4322, and it's not fixed.
My service is deployed in docker and I believe the fix is not released as docker img.

I think so,you can try the project website :app.nextchat.dev/,becasue it was merged.

@fred-bf I don't know if I'm doing right.

Your build has completed!
Preview deployment

I checked the build in #4322, and it's not fixed.
My service is deployed in docker and I believe the fix is not released as docker img.

@freejool I think so, I  found that build still have the bug, you can check my new build https://chat-gpt-next-web-git-main-raaxs-projects.vercel.app

@freejool I found the preview of deployments,Preview

Yeah, this build is working fine, Cheers!🍻🍻


[release-1.15] Changing default value of ENABLE_LEGACY_FS_GROUP_INJECTION in charts

This is an automated cherry-pick of #40531

/retest

/test integ-basic-arm64

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio_release-1.15
a6dc509ad2d2318d32b7faa119c59998ace0ce0f
link
unknown
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote


missing MPP (openslide.mpp-x)

I encountered this problem during the process of extracting tiles. I also tried to set "ignore_missing_mpp=True", but it didn't work. Is this error caused by my WSI file? Looking forward to your reply, thank you very much.
“Error loading slide slide/TCGA-BH-A1FU-11A-02-TSB.svs: Slide TCGA-BH-A1FU-11A-02-TSB missing MPP (openslide.mpp-x). Skipping ”

Hello - this error is raised when the slide (and its associated information, such as microns-per-pixel) cannot be read. This might happen if:

The slide is not compatible with the active slide reading backend (unlikely, since this is an SVS file, which is supported by both cuCIM and Libvips)
The slide is corrupt

Since this is an SVS file from TCGA, I'm guessing that the slide is corrupt or only partially downloaded. Is this the only slide that you're encountering the issue with? Try removing and re-downloading the slide to see if that fixes the issue.
Can you also check the active slide reading backend by adding the following at the top of your script:
import slideflow as sf
sf.about()

Thanks for your reply!

This slide is one of my WSIs,and I tried using several other files ,but this the issue still doesn't work.
After adding the code from your reply at the top of my script,Another error arises：
pyvips.error.Error: VipsForeignLoadOpenslide does not support optional argument fail

I'm trying to fixes this issue.
The following information may be useful ：
│ Slideflow              │
│ Version: 2.0.3-post1   │
│ Backend: torch         │
│ Slide Backend: libvips │
│ https://slideflow.dev  │

Thanks - it looks like this is probably a Libvips version issue. What version of Libvips do you have installed? You can check by running the following in the terminal:
vips --version

Great! Glad to hear it.


Dependency to micrometer-registry-cloudwatch

Hi, I need it for CloudWatch metrics AutoConfiguration.

The mentioned AutoConfiguration is here: https://github.com/spring-cloud/spring-cloud-aws/pull/283

This will eventually go in Spring Boot


Pass right number of args to _add_step

r? @larsbergstrom

This change is

@bors-servo r+

:pushpin: Commit 7a819a7 has been approved by larsbergstrom

:hourglass: Testing commit 7a819a7 with merge 1de36ee...

:sunny: Test successful - status-travis


dev_appserver.py: command not found

When running locally
./run_local.sh: line 5: dev_appserver.py: command not found

Hey @pauldraper! Sorry you hit an issue. If you already installed the gcloud SDK, you may also need to run:
gcloud components install app-engine-python

Let me know if you still get an error. If needed, I can walk through the setup from a fresh environment and debug more deeply.

Thanks I got that working.

Great, glad to hear it! What was the resolution? I can update the README if needed.

I didn't realize gcloud was required for both local running and deploying.
(I'm not a GCP guy.)

@pauldraper thank you for explaining what happened.


change pass to password

change pass to password
Before submitting pull request:

[ ] Check if the project compiles by running sbt compile
[ ] Verify docs compilation by running sbt compileDocs
[ ] Check if tests pass by running sbt test
[ ] Format code by running sbt scalafmt

Thanks :)


Slider "active area" is offset from where the actual element is

Environment
System:
    OS: macOS 12.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 680.34 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 14.17.0 - ~/.nvm/versions/node/v14.17.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v14.17.0/bin/yarn
    npm: 6.14.13 - ~/.nvm/versions/node/v14.17.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.1, iOS 16.1, macOS 13.0, tvOS 16.1, watchOS 9.1
    Android SDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8512546
    Xcode: 14.1/14B47b - /usr/bin/xcodebuild
  Languages:
    Java: javac 19 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: Not Found
    react-native: Not Found
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

(Possibly) relevant deps from package.json:
    "@react-native-community/slider": "4.2.4",
    "@react-navigation/material-top-tabs": "6.2.1",
    "@react-navigation/native": "6.0.10",
    "@react-navigation/native-stack": "6.6.2",
    "expo": "~44.0.2",
    "expo-font": "~10.0.4",
    "expo-splash-screen": "~0.14.1",
    "expo-status-bar": "~1.2.0",
    "jsc-android": "^250230.2.1",
    "react": "17.0.1",
    "react-dom": "17.0.1",
    "react-native": "0.64.3",
    "react-native-calendars": "1.1289.0",
    "react-native-collapsible": "1.6.0",
    "react-native-pager-view": "5.4.9",
    "react-native-safe-area-context": "3.3.2",
    "react-native-screens": "~3.10.1",
    "react-native-tab-view": "3.1.1",
    "react-native-web": "0.17.1"

Description
I have a Slider component that works perfectly fine on browser simulated mobile phone environment (Chrome -> responsive "iPhone 6/7/8 Plus" preset). But when I use the slider on a bigger screen (Chrome -> responsive "iPad Pro" preset), the active range (where the slider starts moving with mouse drag) is far to the left from where the actual slider element is.
Let's say, the slider element is between width 750px and 900px:

When I simply click on the slider, it goes automatically to maximumValue
If I click & hold the slider, and then pull to the left side of the screen, nothing happens to the slider. It does not move.
But when I reach the left edge of the screen (about 100px), then the slider starts to move with the mouse drag.

Here's a video. The first part is the "click makes it max value", and then comes the slider offset:
https://user-images.githubusercontent.com/5442750/209342148-200b56a4-8bda-4a1a-a495-d398c9423b03.mov
Reproducible Demo
const styles = StyleSheet.create({
  sliderBox: {
    flexDirection: 'row',
  },
});

interface Params {
  min: number;
  max: number;
  initialValue: number;
  bidToEdit: Bid;
  setter: Function; // This just passes the value to the parent, does not affect incoming params
}

export const CustomSlider = ({ min, max, initialValue, bidToEdit, setter }: Params) => {
  const [value, setValue] = useState<number>(initialValue);

  const sliderUpdated = (newValue: number) => {
    console.warn('Slider update to', newValue);
    setValue(newValue);
    setter(newValue);
  };

  return (
    <View style={styles.sliderBox}>
      <Slider
        value={value}
        step={1}
        onValueChange={sliderUpdated}
        minimumValue={min}
        maximumValue={max}
        minimumTrackTintColor={Colors.blue900Default}
        maximumTrackTintColor={Colors.blue50}
        thumbTintColor={Colors.blue900Default}
      />
      <SliderPoints value={value} updatePoints={sliderUpdated} min={min} max={max} />
    </View>
  );
};

I've also tried setting a maxWidth for the containing <View> but it doesn't change the behaviour.
I have also tried using onSlidingComplete and onSlidingStart, but the behaviour is still the same.

Hello @Torniojaws!
Thanks for a detailed report. One thing I have in mind before I start analysing this: Could you check if the issue still occur if you set the height and especially width to the style prop of Slider itself as well, instead of trimming it with the container View styles only?

I also had this problem when upgrading from version 3 to version 4.
I have a solution that solves this that I will make a PR for.
@Torniojaws, when this happens, could you please try to change the width of the browser. Will it work after that (without reloading)?

Not using slider style to change the width and height, and using  for external Settings, this issue still exists but has not been resolved.

@mathias-berg I have the same problem，the slider offset problem can be solved by changing the browser width.
But there is no reason for users to change the browser size. Secondly, our web application will be nested by iframe, so the problem will still not be solved.

Sadly, the fix that I was working didn't fix this. Still had the problem occasionally, will look into another solution.

@BartoszKlonowski
I tried setting a width to <Slider> itself, but seems it only "resized" the left edge offset area where moving changes the slider:
https://user-images.githubusercontent.com/5442750/212357147-7a0d9c71-a7d1-420a-9ae8-cd13b0a4286b.mov
@mathias-berg
Actually yes, when I resize the browser window, it fixes the slider behaviour. Quite interesting.

The problem is because at onLayout the containerRef is sometimes undefined and therefore the position is not saved. But when changing the size of the window there is an update and the position is saved correctly.
if ((containerRef as RefObject<View>).current) {             updateContainerPositionX();           }

I find this bug making this library, unfortunately, useless

I'm on SDK 47 and it still exists for me

A workaround I found is to force onLayout to be called a second time by changing the thumbStyle prop and then reverting back.
const [tempThumbStyle, setTempThumbStyle] = React.useState<ViewStyle>({
    width: 0,
    height: 0,
  });

  React.useEffect(() => {
    setTempThumbStyle({ width: undefined, height: undefined });
  }, []);

And
<Slider
...
//@ts-ignore Not registered in types
thumbStyle={Platform.OS === "web" ? tempThumbStyle : undefined}
/>

Not pretty, but does the trick for now.

Still broken

Still occurring for me on Expo sdk 50.

@YoussefHenna's workaround worked for me.

A workaround I found is to force onLayout to be called a second time by changing the thumbStyle prop and then reverting back.
const [tempThumbStyle, setTempThumbStyle] = React.useState<ViewStyle>({
    width: 0,
    height: 0,
  });

  React.useEffect(() => {
    setTempThumbStyle({ width: undefined, height: undefined });
  }, []);

And
<Slider
...
//@ts-ignore Not registered in types
thumbStyle={Platform.OS === "web" ? tempThumbStyle : undefined}
/>

Not pretty, but does the trick for now.

If someone looking for a solution and above don't work for you - try to use regular style prop instead thumbStyle. Did work for me.
import { useState, useEffect, ComponentProps } from 'react';
import { Platform, ViewStyle } from 'react-native';
import SliderLib from '@react-native-community/slider';

type Props = ComponentProps<typeof SliderLib>;
export const Slider = ({ style, ...props }: Props) => {
	// https://github.com/callstack/react-native-slider/issues/470#issuecomment-1777525861
	const [tempStyle, setTempStyle] = useState<ViewStyle>({
		width: 0,
		height: 0,
	});

	useEffect(() => {
		setTempStyle({ width: undefined, height: undefined });
	}, []);

	return <SliderLib style={[Platform.OS === 'web' ? tempStyle : undefined, style]} {...props} />;
};

We found that this issue was caused by the react-navigation screen transition. The slider renders before the transition is complete, so the math to figure out the slider value based on touch is offset.
Here is our workaround: (Expo / React Navigation)
  const navigation = useNavigation()
  navigation.addListener('transitionEnd', () => {
    if (Platform.OS === 'web') window.dispatchEvent(new Event('resize'))
  })


Refreshed App Details Page

Allows developers to also include an app icon (via URL)

@ItsRiprod
Should we consider merging this request?


Upgrade to react-0.14.3

added a few extra lines to align the package with the latest react version.

Thanks @kfamilonidis!
I have to think about it though. The sole reason I created that module over just using the react-google-maps was the clustered markers support compatible with React 0.13.
Then, it would definitely not be a patch-level change as you suggest, but rather a major version bump.
I'll come back to that in 2016.
Happy New Year!


Preselecting the first region when changing country

Hello,
Is it possible to Preselect the first Region in REgions List when changing country list ?

Good question... no, currently that feature's not available. But I can see it being useful. I'll put it down as a feature request & give it some thought.

That would be very useful


Indentation lines continue past end of block

Not sure if "indentation line" is the right vscode terminology, but this is what I'm seeing. Sorry if this has been reported elsewhere, didn't know how to search for it.

This is not handled by this extension, only by vscode. Seems to happen due to how code is formatted in Elm. Not sure if this should be reported as an issue in vscode instead. Tested and verified that indent guides are correct with this formatting:
main : Program Never
main =
App.program
{ init = (model, Cmd Msg)
, view = view
, update = update
, subscriptions = subscriptions
}

Could you add the example you tested inside a code block so I can verify the formatting please? Odd that it works for you but not me.
One thing I noticed that is wrong with my example is that the number of spaces should be set to 4 in vscode, but it remains the default 2, so there is one extra indent guide. Since elm-format uses 4, maybe the extension could set it to 4 for .elm files?
Regardless, when I set spaces to 4 manually, I still get two guides shooting down past the end of the block and only stopping when a new non-empty line begins.
I've never seen this behavior in other languages, so I thought I'd check here first. If no one else is experiencing this, I'll post it upstream. Thanks for the feedback!

Yes, this could be related to the 4/2 spaces setting. The example I tested was by using the snippet "mainprogram". On my machine, this creates a main function that closes the indent guides correctly.


Bad design

Why src is not const char*?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d63df7c-131f-66a2-cfba-78c584b4865a
Version Independent ID: 973598db-2ae7-fd75-e417-016052df59f4
Content: _swab
Content Source: docs/c-runtime-library/reference/swab.md
Product: visual-cpp
Technology: cpp-ucrt
GitHub Login: @corob-msft
Microsoft Alias: corob

@satya-das
That's a philosophical question for the creator of the function. My guess is, it was created long before using const was a common software engineering paradigm for read-only data. The documentation accurately represents the declaration of the function, so I'm closing this issue.


Add sudo

Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Not sure why the macos build fails, but I guess we first need to integrate all the actions to get them working.

Not sure why the macos build fails, but I guess we first need to integrate all the actions to get them working.


Path and Identifier validation and improvements

Description

[x] We must also define concretely what an Identifier is and validate it in accordance with ICS024.
[ ] Path should ideally be a trait. Must provide methods for splitting into component Identifiers, append, etc.
[x] Replace basecoin-rs/src/app/store.rs:Identifier::is_valid() with ibc-rs/modules/src/ics24_host/validate.rs:validate_identifier().
[x] Reuse ibc-rs/modules/src/ics24_host/identifier.rs:{ChainId, ClientId, *} in basecoin-rs/src/app/modules/ibc.rs.
[x] Deserialize paths into concrete ibc-rs/modules/src/ics24_host/path.rs:29.
[ ] Does it make sense to use const-generics? e.g.

pub struct Identifier<const N: usize>([char; N]);

Regarding Path as a trait, I think it's more intuitive to have a concrete type (i.e. store::Path) that is used as a key for the KV store. Each module may then define its own Path type (expected to be an enum) with all possible paths accessed by the module represented as enum variants. Each module may additionally define conversion methods to/from store::Path.


Initial PolicySet page

Signed-off-by: Zack Layne<EMAIL_ADDRESS>Related issue: https://github.com/open-cluster-management/backlog/issues/17710

/cc @KevinFCormier retry of https://github.com/open-cluster-management/console/pull/1033.

/cc @KevinFCormier

/lgtm


ZEVA - MY Reports for Small Suppliers

Title: MY Reports for Small Suppliers
Description:
ZEVA can’t presently support MY reporting for small suppliers. The Compliance Obligation tab doesn’t support the logic of a small supplier not having an obligation or resulting credit reduction. It currently defaults to calculate a credit reduction using the medium supplier requirements.
Update the Compliance Obligation tab to recognize that small suppliers don’t have compliance obligation.

Set both the “Compliance Ratio Credit Reduction” and “Unspecified ZEV Class Credit Reduction” to: 0.00
For the radio selection “Do you want to use ZEV Class A or B credits first for your unspecified ZEV class reduction?”, either default the radio selection to B and lock it or hide the selection completely.

Wireframe:

Purpose and benefit to user:
This will enable small suppliers to submit MY reports accurately.
Acceptance Criteria:

[ ] Given I am a BCeID user of a small supplier, When I am creating a MY report, then I can report my LDV sales and have an accurate report with no credit reduction applied.

Development Checklist:

[ ] Check if the logic for small suppliers exists for this functionality if not, add it by referring above.
[ ] Ensure there is logic to check for a small supplier on MY reports. (This may require some business logic input)

Notes:

Hey team! Please add your planning poker estimate with Zenhub @AlexZorkin @JulianForeman @tim738745

@airinggov @jdon-zev when testing, please also test creating MYRs for medium + large suppliers to make sure nothing on that front has been affected. Also, we'll need to make a card to handle reassessments for small suppliers.

can these two vales be set to zero?

like the Compliance Obligation tab display?

@airinggov sure; which tab is this?

the first is the Summary tab, second is the Compliance Obligation tab

Tim, as mentioned in the sprint review I'd like to remove the text and credit type selection piece that is currently under the credit reduction section heading. Would like to replace with some text. Al will provide a mock-up but we thought this could be another card?


added prompt objects to metrics

Added prompt objects to metrics

@shahules786 faithfulness and critique prompts are left

I have raised PR to your branch. @tinomaxthayil


Move Well Metadata out from under "Properties"

Rationale
Well metadata was previously exposed in the virtual table under the Properties column. This change moves those fields out into the Well table directly.
Related Pull Requests

https://github.com/LabKey/platform/pull/5637
https://github.com/LabKey/limsModules/pull/413
https://github.com/LabKey/labkey-ui-premium/pull/456

Changes

Join WellTable directly to fields in metadata table.
Adjust PlateManagerTest to not reference the properties FK
Remove the virtual table used in the properties FK.
Update PlateSetDataGenerator to remove properties references
Update PlateManager references to properties for metadata fields

This PR can hang out until we branch for 24.7, since we don't need this until 24.8.


Adding storage definition for elasticsearch with deployment configuration

Which problem is this PR solving?

No problem, enhancement for production deployment configurations

Short description of the changes

Added storage definition for elasticsearch on OpenShift
Added elasticsearch deployment configuration with persistent volume

Travis is failing on license header checks and the header exists in both files.

Could you please run mvn license:format, to get the headers fixed? The problem might be that we are in 2019 and the headers are for 2018.

@ofirattia thanks for the PR.
We do not want to support storage deployments in this repository and rather defer on well tested solutionns out there - e.g. elasticsearch from pires or helm charts.
The elasticsaarch template what is in this repository is only for "try it out" purpose. I am not even sure if the ES is configured with the right discovery (the same for your deployment)

@ofirattia thanks for the PR.
We do not want to support storage deployments in this repository and rather defer on well tested solutionns out there - e.g. elasticsearch from pires or helm charts.
The elasticsaarch template what is in this repository is only for "try it out" purpose. I am not even sure if the ES is configured with the right discovery (the same for your deployment)

thanks for your quick reply, actually I tested it with 120 instances on our cluster, I am not sure if it will be used in the same configuration for production, but for performance tests and user acceptance for sure. I found it useful.
Anyway, its seems that there is no recommended approach for production and its kind of do it your own.
do you want to add the storage configuration as example in the README or what you have now its enough from your side?

do you want to add the storage configuration as example in the README or what you have now its enough from your side?

I think it's enough what we have. I believe similar examples can be found in k8s docs.

Thanks, Closed.

@ofirattia in any case, thanks for your PR! I'd be really interested in hearing more about your tests:

actually I tested it with 120 instances on our cluster

Are you able to provide more info? Feel free to ping me via Gitter or IRC.