Allow users to reactivate their accounts

This change:

Updates the page the user sees when their account is deactivated to include a link to send a reactivation email.
Creates a new "reactivation" page which confirms to the user that email has been sent.
Sends an email to the user with a link to reactivate their account (using Gov Notify)
Shows a message to the user if there's a pending reactivation request for their account

Scenarios
1. User reactivates their account via email

Log in with a deactivated account
A warning message tells the user their account has been deactivated
The user clicks on the "reactivate" link

https://user-images.githubusercontent.com/97103826/180187621-1d9b6ccf-4127-45c0-ad82-a1d6d200816a.mov

An email is being sent to the user's email address and a message shows up on a page indicating an email has been sent. Example:

Dear<EMAIL_ADDRESS>Your account has been reactivated. Please select the following link to complete the reactivation process:
https://identity.integration.learn.civilservice.gov.uk/account/reactivate/:reactivationId
Regards
learn.civilservice team

The user clicks on the link in the email

A "Account reactivation complete" page appears with a link to log in.

The user is now able to login

https://user-images.githubusercontent.com/97103826/180188513-2be55b64-8b8f-4f1d-bdf8-9d6add7d65cf.mov
2. User tries to log in while there's a pending reactivation on their account

Log in with a deactivated account

A warning message tells the user their account has been deactivated

The user clicks on the "reactivate" link

An email is being sent to the user's email address and a message shows up on a page indicating an email has been sent.

User tries to log in again before reactivating their account with the email sent to them.

A message appears on the page informing them that an email to reactivate their account has been sent to them.

https://user-images.githubusercontent.com/97103826/180190000-66e4486f-28d4-4264-9226-1a773dc2f970.mov

Update: updated text according to Julie's feedback:
Account deactivated:

Account is pending reactivation:

Account reactivation complete:


Add GetUnhandledSignalNames

What was changed

Expose the API GetUnhandledSignalNames
Why?

See https://temporalio.slack.com/archives/CTDTU3J4T/p1672780768847019?thread_ts=1672770053.462709&cid=CTDTU3J4T
Checklist

Closes
None. but related to https://github.com/temporalio/sdk-features/issues/51

How was this tested:

There are already tests covered for this API internally in the SDK.

Any docs updates needed?

Maybe worth mentioning for using continueAsNew, this API will be helpful to check if all the signals are drained.

@longquanzheng - sorry, some of the PRs are moving fast on this repo. Can you update your branch w/ latest master (or let me know and I can)?

@longquanzheng - sorry, some of the PRs are moving fast on this repo. Can you update your branch w/ latest master (or let me know and I can)?

no worries, I can do it. You are also welcome to do it anytiime. LMK if I need to do anything to change permission


[Samples] Misc camera controller fixes

PR Details
Fix BasicCameraController's mouse input, implements gamepad support, explain in detail common pitfalls of camera controller programming and fixes single frame lag on FPS sample's PlayerInput.
Description
Redondant.
Related Issue
None logged on Github.
Motivation and Context
This mostly stemmed from this Discord discussion I had a couple of weeks ago, creating this PR to fix the issue mentioned lower and clarify controller programming. This camera might very well be the first camera that users interact with, knowing that we might as well document thoroughly how it works and what users should do when modifying or creating one.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Notes

There still is at least one frame of lag somewhere else inside the engine, it is fairly visible when binding mouse input to a camera and looking at the OS cursor moving a fair amount of time before the in game camera does.
I thought about modifying the first person camera to clarify it as well but that one's such a mess that I might as well rewrite it altogether.

PR ready for review

Thanks! Tested in editor/new game, it seems to be much better than before.

Merging, thanks for the great work and well commented code!

Note: will cherry-pick this if we release a <IP_ADDRESS>

@Eideren No need to fix this (or at least low priority and can be done separately), but except FPS sample, do you know if other samples will need a camera system rewrite?


Multiturn conversation SFT training

How to prepare for the multiturn conversation dataset for training? In the raw_datasets.py, can I simply concatenate the multiturn conversation (following the human and assistant format) and put them under the get_prompt_and_chosen function?

As far as I know, for conversation dataset one way to do is to convert it into multiple data samples: for each sample, the chosen/rejected response would be one of the responses in the conversation, and the prompt will be the whole conversation before that response. In this way you should be able to convert your dataset to follow the format in raw_datasets.py.
On the other hand, please understand that we haven't tried such kind of dataset yet when developing DeepSpeed-Chat and tuning the hyperparameters in the scripts, so it's possible that you would need some sort of tuning.

As far as I know, for conversation dataset one way to do is to convert it into multiple data samples: for each sample, the chosen/rejected response would be one of the responses in the conversation, and the prompt will be the whole conversation before that response. In this way you should be able to convert your dataset to follow the format in raw_datasets.py.
On the other hand, please understand that we haven't tried such kind of dataset yet when developing DeepSpeed-Chat and tuning the hyperparameters in the scripts, so it's possible that you would need some sort of tuning.

Thanks for your response. Let me clarify my question a little better. My question was to focus on the SFT stage where my guess is chosen/rejected response does not matter. What matter the most is the get_prompt_and_chosen function.
If we were to put the hyperparameter tuning aside (I can do the experiment myself), may I know that if it's appropriate if I simply put the full conversation (from beginning of the chat to the end of the chat) in the get_prompt_and_chosen function and it should work normally?
Example:
"  Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant: You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India. Human: What documents are required to open a demat and trading account? Assistant: You will need to provide identity proof (PAN card), address proof, bank details and a passport size photograph to open a demat and trading account."
Or do I need to add any breakpoint (for example, /s/s)  in between each round of conversation like this?
"  Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. /s/s Human: How do I find a registered stockbroker in India? Assistant: You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India. /s/s Human: What documents are required to open a demat and trading account? Assistant: You will need to provide identity proof (PAN card), address proof, bank details and a passport size photograph to open a demat and trading account."

My understanding is that the advantage of conversation data is that it allows models to learn contexts with different number of conversations (instead of single prompt). So in order to fully exploit that advantage (and to generate some sort of variations inside data), what I was suggesting is to make one conversation into multiple data samples. Taking your example, I would actually convert it into 3 data samples
Sample 1:
prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant:"
chosen: " Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker."
Sample 2:
prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant:"
chosen: " You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India."
Sample 3:
prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant: You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India. Human: What documents are required to open a demat and trading account? Assistant:"
chosen: " You will need to provide identity proof (PAN card), address proof, bank details and a passport size photograph to open a demat and trading account."
To me the breakpoint is only necessary if you are going to use it during actual inference.
At last, please understand that everything above is just my own views without sufficient evaluation yet. It's possible that only using sample 3 is already sufficient. Hope this helps.

My understanding is that the advantage of conversation data is that it allows models to learn contexts with different number of conversations (instead of single prompt). So in order to fully exploit that advantage (and to generate some sort of variations inside data), what I was suggesting is to make one conversation into multiple data samples. Taking your example, I would actually convert it into 3 data samples
Sample 1: prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant:" chosen: " Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker."
Sample 2: prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant:" chosen: " You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India."
Sample 3: prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant: You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India. Human: What documents are required to open a demat and trading account? Assistant:" chosen: " You will need to provide identity proof (PAN card), address proof, bank details and a passport size photograph to open a demat and trading account."
To me the breakpoint is only necessary if you are going to use it during actual inference.
At last, please understand that everything above is just my own views without sufficient evaluation yet. It's possible that only using sample 3 is already sufficient. Hope this helps.

Very good explanation. Thanks for your feedback. I would try the experiment with all of the format that you suggested. Thanks a lot :D

My understanding is that the advantage of conversation data is that it allows models to learn contexts with different number of conversations (instead of single prompt). So in order to fully exploit that advantage (and to generate some sort of variations inside data), what I was suggesting is to make one conversation into multiple data samples. Taking your example, I would actually convert it into 3 data samples
Sample 1: prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant:" chosen: " Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker."
Sample 2: prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant:" chosen: " You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India."
Sample 3: prompt: "Human: I want to know the step by step guide to invest in share market in India. Assistant: Sure, I can help with that. Firstly, you need to open a demat and trading account with a registered stockbroker. Human: How do I find a registered stockbroker in India? Assistant: You can visit the websites of National Stock Exchange (NSE) or Bombay Stock Exchange (BSE) to get a list of registered stockbrokers in India. Human: What documents are required to open a demat and trading account? Assistant:" chosen: " You will need to provide identity proof (PAN card), address proof, bank details and a passport size photograph to open a demat and trading account."
To me the breakpoint is only necessary if you are going to use it during actual inference.
At last, please understand that everything above is just my own views without sufficient evaluation yet. It's possible that only using sample 3 is already sufficient. Hope this helps.

Sorry last question. For SFT, we can simply these functions as :
    def get_prompt(self, sample):
        print(
            f"Warning: dataset {self.dataset_name} does not include prompt response."
        )
        return None

    def get_chosen(self, sample):
        print(
            f"Warning: dataset {self.dataset_name} does not include chosen response."
        )
        return None

    def get_rejected(self, sample):
        print(
            f"Warning: dataset {self.dataset_name} does not include rejected response."
        )
        return None

and only focus on the def get_prompt_and_chosen(self, sample): right?

We have examples in raw_datasets.py that you can just follow https://github.com/microsoft/DeepSpeedExamples/blob/bae2667824974ac13dac28712462c14a2e594150/applications/DeepSpeed-Chat/training/utils/data/raw_datasets.py#L398


Issue #336 Issue reading column with multiple DATA_PAGE encodings

Fixes
Issue #336 Issue reading column with multiple DATA_PAGE encodings
Description
Fixed count calculation of already read values.
MergeDictionary() no longer replaces the whole value array.

[ ] I have included unit tests validating this fix.
[ ] I have updated markdown documentation where required.

It looks good to me. I'd be keen to validate the fix with a test, do you have a sample small parquet file that reproduces the problem? We can simply include it in tests, happy to help.

Unfortunately I have no small parquet file for testing.

@patrix1337 is it possible to send one privately?

closing this as we can't validate the fix


ExtManagementSystem: Multiple columns called "Total Memory"

Base a report on Providers (any kind other than performance), and in Available Fields, there is "Total Memory" twice:

This is because one is total_memory and the other is aggregate_memory (both fields on ext_management_system) table.
> MiqExpression.model_details(ExtManagementSystem).select { |a,b| a =~ /Total Memory/ }
=> [["Provider : Total Memory", "ExtManagementSystem-aggregate_memory"], ["Provider : Total Memory", "ExtManagementSystem-total_memory"], ....]

Looks like this boils down to...
> MiqExpression.value2human('ExtManagementSystem-aggregate_memory')
"ExtManagementSystem-aggregate_memory"
=> "Provider : Total Memory"
> MiqExpression.value2human('ExtManagementSystem-total_memory')
"ExtManagementSystem-total_memory"
=> "Provider : Total Memory"

even
> MiqExpression.value2human('-aggregate_memory')
"-aggregate_memory"
=> " Total Memory"
> MiqExpression.value2human('-total_memory')
"-total_memory"
=> " Total Memory"

And that is ends up calling..
> Dictionary.gettext('total_memory', :type => :column, :notfound => :titleize)
=> "Total Memory"
> Dictionary.gettext('aggregate_memory', :type => :column, :notfound => :titleize)
=> "Total Memory"

Which is because
locale/en.yml
131:      aggregate_memory: Total Memory

(total_memory gets translated by that :notfound => :titleize fallback)

I guess these 2 fields (total_memory and aggregate_memory) should have distinct descriptions, but I don't know enough about the 2 fields to be able to tell the difference.

I'm guessing this is a vmware thing:
https://www.vmware.com/support/developer/converter-sdk/conv51_apireference/memory_counters.html
Memory Total = Aggregate host machine memory - (VMkernel memory + Service Console memory + other service memory)
Then again maybe I'm way off. Can someone confirm?

@agrare can you chime in on this?

Actually I dont' think this is VMware specific, I think it is just duplicated
virtual_aggregate :total_memory, :hosts, :sum, :ram_size from ext_management_system.rb +231
And
def aggregate_memory(targets = nil)
  aggregate_hardware(:hosts, :memory_mb, targets)
end

From mixins/aggregation_mixin/methods.rb +17
So the only difference is one uses hosts.ram_size and one uses hosts.hardware.memory_mb.  And ram_size is defined as hardware.memory_mb here.  Therefore they are identical Q.E.D. :)

Makes sense, thanks :)
Still, having 2 entries in the report menu is suboptimal, any chance we could get rid of one of those attributes?

Yes absolutely, working on that now

cc @kbrock

dropping the delegate makes the most sense
ASSUMING that we update the reports to act accordingly

ping @kbrock

going forward with this:
introducing a hide_attribute that stores attributes in hidden_attributes.  will also tie this into deprecate_attributes.
This will be used by MiqExpression.model_details and api: options_serializer.rb
for ideas on other places, grep for "attribute_names"


Axiom 4.1.1 does not work with Immersive Portals any version

I wanted to use the mods (below) and this happened.
Mods:
  [✔] Axiom-4.1.1-for-MC1.21.jar
  [✔] BetterF3-11.0.2-Fabric-1.21.1.jar
  [✔] collective-1.21.1-7.84.jar
  [✔] easyelevators-1.21.1-1.2.jar
  [✔] fabric-api-0.104.0+1.21.1.jar
  [✔] fabric-carpet-1.21-1.4.147+v240613.jar
  [✔] immersive-portals-6.0.3-mc1.21.1-fabric.jar
  [✔] Pehkui-3.8.3+1.14.4-1.21 (1).jar

Error in log:
[14:53:27] [main/ERROR]: Incompatible mods found!
net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other!
A potential solution has been determined, this may resolve your problem:
	 - Replace mod 'Axiom' (axiom) 4.1.1 with any version that is compatible with:
		 - immersive_portals 6.0.3
More details:
	 - Mod 'Axiom' (axiom) 4.1.1 is incompatible with any version of mod 'Immersive Portals' (immersive_portals), but a matching version is present: 6.0.3!

Process exited with exit code 1 (0x1).

Yeah, I'm really hoping they make this a priority. I'm trying to use an up to date version of axiom with immersive portals, but they're just not compatable yet.


Infinity code lens references

Idea Ultimate 2023.3.2
Plugin version: 1.14.2

Looks like a problem with not cleaning lens after applying new ones, @gavr123456789 did you anything specific to repro that?

@ericdallo
No, nothing specific, I have it after first time using the plugin, so I just disabled lens.

Could you test if it happen sin Intellij Community?

@ericdallo  Confirmed also happening in Community Edition.

Thanks, I still can't repro the issue on any project (like clojure-sample) so it makes harder to understand what's going on

I'm seeing the issue on clojure-sample, so I don't think it is project-specific.

macOS 14.3.1
IntelliJ IDEA 2023.3.4 (Community Edition)
clojure-lsp-intellij 1.14.9

@ericdallo The common denominator here seems to be macOS. I think you're on linux, right @ericdallo?

Yes, I can't see how this would affect, but yeah it 's a factor and I don't have any macos  to repro that

Folks, finally, this bug should be fixed by #34, let me know if not.
Available on 2.0.0 version.


Possibility to make an ignore list

Possibility to make an ignore list, when i upload an entire folder all files was uploaded, would nice feature to add an ignore list.

+1
can't promise when exactly, but if nobody is working on this, i'd like to take a look at this issue in June sometime.

I think this ignore list should be per-project (not in the package settings). I had in mind to add a new file .ftpignore similar to the .gitignore that uses the same ignore pattern.
Is this what you had in mind ?

Yes, I had thoughts in that direction too.
I'm not sure though, how hard it is to implement the same ignore pattern that .gitignore uses.

Checkout either of these

https://github.com/kaelzhang/node-ignore
https://github.com/mafintosh/ignore-file

+1

What's the status on this?
Would be great if it would parse .gitignore and/or a .ftpignore as in #117
Coloring based on differences to local copy and ignored/not would be excellent.

+1

+1 and agreed on .ftpignore following a .gitignore similar syntax would probably be the "least unexpected" approach

+1 on this one as well, would be an awesome feature to ignore, or "cloak" like Dreamweaver does so certain files do not upload when pushing a folder or syncing

Loving Remote-FTP, but the inability to ignore files and folders makes it hard to use it as the only FTP package. Any progress on this?

I would love to have that feature. Created another ticket before discovered this one. #430

@Asbra @cshanejennings @Saiyanomaly @linuz90 @4ley
I've updated the PR .ftpignore feature from issue #36. That should do the job (for now).

Merged @miclaus PR


Implement the new Homepage

Summary
Re-implemented the Homepage based on the following wireframe

Deadline
Ongoing
What needs to be done?

[ ] responsive viewing for phone (width: 425px)
[ ] responsive viewing for tablet (width: 768px)
Confirm  the contents on the page
Confirm the final design (color, spacing) on the page

Who can help?

Anyone is welcome to contribute to the design, the development, or the contents

Updates

Related Issue: Feedback on Homepage View #606
Working branch: https://github.com/alan-turing-institute/AutSPACEs/tree/unified-bootstrap-navigation

Color Palette:

Perhaps don’t put red as the first colour people see - it can be an alarming colour and the ordering of the colours have no real order.

Contents

Homepage: Quote is good, but “senses” is a limiting word. More the environment, people may not consider spatial environments etc as a sense.

Section Order

Order could be rejigged, perhaps put stories and how to use nearer to the top. This should be prioritised.
Put Shared Experience above What Autism Is or remove it to another section.
Move What Autism Is to the bottom but keep it on the page, to describe which part of Autism we are interested in.
How to use section:  ordering of the steps, format it top to bottom instead of left to right. Perhaps a tag line for each step and then further information / detail on another page so as not to overwhelm
Register and How To Use are separate, How To Use should be its own page. Could perhaps turn it into a horizontal layout with icons.

Spacing

Spacing on the menu tabs once you’re logged in vs when you’re not logged in. Should we use black when hovering over the menu tabs as we don’t use the colour elsewhere?

Typos:

OpenHumans or Open Humans? On the home page and also on the registration page
How to Use page: Abbout -> About.
Capitalisation of some words and not others on the section headers (e.g. How to Use this Page)
Footer: Grammar: @AutSpaces at or on Twitter?

Updated! Thanks for the feedback @amol-prabhu 😄

Color Palette:

Perhaps don’t put red as the first colour people see - it can be an alarming colour and the ordering of the colours have no real order.

Contents

Homepage: Quote is good, but “senses” is a limiting word. More the environment, people may not consider spatial environments etc as a sense.

Section Order

Order could be rejigged, perhaps put stories and how to use nearer to the top. This should be prioritised.

Updated

Put Shared Experience above What Autism Is or remove it to another section.

Updated

Move What Autism Is to the bottom but keep it on the page, to describe which part of Autism we are interested in.
Updated
How to use section:  ordering of the steps, format it top to bottom instead of left to right. Perhaps a tag line for each step and then further information / detail on another page so as not to overwhelm

Updated

Register and How To Use are separate, How To Use should be its own page. Could perhaps turn it into a horizontal layout with icons.
Should 'How to Use' be its own page or should we include it as a section in 'About Us' page?

Spacing

Spacing on the menu tabs once you’re logged in vs when you’re not logged in. Should we use black when hovering over the menu tabs as we don’t use the colour elsewhere?


Addition of CTF

Hi Team,
Requesting addition of https://exploitthis.ctfd.io under IOT CTF

Kindly requesting the CTF addition

modified


[5.6] Changed all const to public const (according PHP 7.1)

The default visibility of class constants is public.

Thank you for your PR, but this change is unnecessary.

@browner12 , but
The default visibility of class functions also public ;)


Dump location is not always correct

Here's an example where we dump in the controller, but the path displays the previous frame.

Fixed!


chore(deps): update dependency maven to v3.9.1

This PR contains the following updates:

Package
Type
Update
Change

maven

minor
3.8.6 -> 3.9.1

maven
stage
minor
3.8.7-eclipse-temurin-17 -> 3.9.1-eclipse-temurin-17

Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (3.9.1). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Update About.xml

Adds loadBefore for Simple Chains: Lumber.
Lumber replaces WoodLog in fuel filter, Coal Expanded checks for WoodLog, fails to find any, and does not add Coal & Charcoal to fuel list.

Thanks! Added in 6662830


Good Suggestions!

Some spooky Encantments

Jumpscare victim (opens up a url with max volum of a scary video)
swap mouse button
dissable inputs
idk if this is even possible but if u could choose a mp3 file in the builder that  would play when victim runs

Well, thats not something a stealthy trojan should do.

@sanzaz or it will play a video on startup by the mbr lol he will like it

Well, thats not something a stealthy trojan should do.

.

Well, thats not something a stealthy trojan should do.
oh i  didnt  mean a live functio nthat u control i mean like its an option in the builder u not something u control after victim has ran it

I mean a stealer should be stealthy, it should not do anything to grab victim's attention.

yed

Thats why.

oh well i suppose ur right


Problems with Windows and PushBullet

Hi,
First, thanks for writing this module. Definitely very helpful.
Just wanted to point out one issue that is only a problem when using Windows and Pushbullet. When the module sends the curl command, it fails since the windows shell does not correctly parse the command as written. This is due to the fact that the Windows command line does not understand single quotes. I was able to get it working by modifying the ado file so that the relevant command (line 64) is:
quietly !curl -u "`token'": -X POST https://api.pushbullet.com/v2/pushes --header "Content-Type: application/json" --data-binary "{\"type\": \"note\", \"title\": \"statapush\", \"body\": \"`message'\"}"

Hi,
Thanks so much for the heads up. We're hoping to add some new features to the module in the next week or so, and I'll make sure this bug is addressed in that release.
Best,
Will

Should be fixed now on Github! Will submit a revised version to SSC soon. Thx!


CL_OO_CLASSNAME_SERVICE=>GET_ALL_CLASS_INCLUDES not available

I'm trying to install abapGit in another system (which I though had the same version as the one I'm already using it on but after all...) I'm getting compilation errors:

The first problem listed is related to class CL_OO_CLASSNAME_SERVICE which appears to be in an older version than what's needed:

Can the method be replaced by something else available earlier?
Here are the versions on my problematic system:
SAP ECC 6.0
SAP_BASIS	702	0014	 SAPKB70214	SAP Basis Component
SAP_ABA	702	0014	 SAPKA70214	Cross-Application Component
And here are the versions on my ok system:
EHP6 FOR SAP ERP 6.0
SAP_BASIS	731	0005	SAPKB73105	SAP Basis Component
SAP_ABA	731	0005	 SAPKA73105	Cross-Application Component
Thanks,
Nuno

For CONTROLLER_EXCEPTIONS: comment out the 4 lines with errors. This is related to exceptions in web dynpro applications, so you might run into trouble if you use web dynpro
CL_OO_CLASSNAME_SERVICE=>get_all_class_includes: this is quite new functionallity, in method
CLASS lcl_object_clas IMPLEMENTATION.

  METHOD lif_object~has_changed_since.

replace all the code in the method with rv_changed = abap_true., this method is for optimizing performance

class stuff fixed, following 4 lines has to be commented on 702, related to WDYN exceptions:
    ls_obj_old-wdyc-excp  = is_controller-controller_exceptions.
    ls_obj_old-wdyc-excpt = is_controller-controller_exception_texts.

and
        controller_exceptions        = rs_controller-controller_exceptions
        controller_exception_texts   = rs_controller-controller_exception_texts

closing issue, I've added a note about 702 in the installation guide: https://github.com/larshp/abapGit/wiki/Installing-abapGit


Add a conda env as option for readers

Hi, @ageron!
First of all, congratulations for your great book!
I'm trying here to do a very small contributions in this PR, aiming for conda users (just like me). I'm adding an environment.yml with the same setup as requirements.txt. So, the user now can generate the same environment both for virtualenv (with the requirements.txt) and conda (with the new file).
To do so, one can just run:
$ conda env create -f environment.yml

An advantage with this contribution is the enhanced reproducibility. Also, it is easier for the user, since the user doesn't need to care about packages and versions (everything is already configured) A drawback is that when you update requirements.txt, you have to update environment.yml as well, to match packages' versions. Put it simply, both files have to be maintained.
I updated README with instructions. Please, do a double check there!
Thanks and I hope that you appreciate this PR!

Moreover, the problem mentioned by you in #369 can be solved if you have an environment.yml file in your repo (at least for Binder). So Binder will build automatically the environment.

Hi @volpatto ,
That's really nice of you, thanks for the contribution! I already added an environment.yml file in the repository for the 2nd edition, but I didn't have time to add one for the 1st edition. Awesome! 👍


Don't wrap entire module in function call

https://nodejs.org/api/globals.html#globals_global

Can you show me specific example of code ?

https://github.com/itemsapi/item/blob/master/src/elastic/data.js#L9, or am I missing something? ;)

#104


New column detail test failures

These three tests are failing on my local machine:
FAILED tests/test_internals_database.py::test_table_column_details[facetable-expected0] - AssertionError: assert [Column(cid=0, name='pk', type='INTEGER', no...
FAILED tests/test_internals_database.py::test_table_column_details[sortable-expected1] - AssertionError: assert [Column(cid=0, name='pk1', type='varchar(30)'...
FAILED tests/test_table_html.py::test_sort_links - AssertionError: assert [{'a_href': None,\n  'attrs': {'class': ['col-Link'],\n            'data-column': '...

I ran pytest --lf -vv and the output had things like this in it:
E         -  Column(cid=1, name='created', type='text', notnull=0, default_value=None, is_pk=0, hidden=0),
E         ?                                      ^^^^
E         +  Column(cid=1, name='created', type='TEXT', notnull=0, default_value=None, is_pk=0, hidden=0),
...
E            {'a_href': '/fixtures/sortable?_sort=sortable_with_nulls_2',
E             'attrs': {'class': ['col-sortable_with_nulls_2'],
E                       'data-column': 'sortable_with_nulls_2',
E                       'data-column-not-null': '0',
E         -             'data-column-type': 'real',
E         ?                                  ^^^^
E         +             'data-column-type': 'REAL',
E         ?                                  ^^^^

Something is causing column types to come back in uppercase where previously they were lowercase.

My best guess is that this is an undocumented change in SQLite 3.38 - I get that test failure with that SQLite version.

Had a look through the commits in https://github.com/sqlite/sqlite/compare/version-3.37.2...version-3.38.0 but couldn't see anything obvious that might have caused this.
Really wish I had a good mechanism for running the test suite against different SQLite versions!

OK, using that trick worked for testing this:
docker run -it -p 8001:8001 ubuntu

Then inside that container:
apt-get install -y python3 build-essential tcl wget python3-pip git python3.8-venv

For each version of SQLite I wanted to test I needed to figure out the tarball URL - for example, for 3.38.0 I navigated to https://www.sqlite.org/src/timeline?t=version-3.38.0 and clicked the "checkin" link and copied the tarball link:
https://www.sqlite.org/src/tarball/40fa792d/SQLite-40fa792d.tar.gz
Then to build it (the CPPFLAGS took some trial and error):
cd /tmp
wget https://www.sqlite.org/src/tarball/40fa792d/SQLite-40fa792d.tar.gz
tar -xzvf SQLite-40fa792d.tar.gz
cd SQLite-40fa792d
CPPFLAGS="-DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE=1" ./configure
make

Then to test with Datasette:
cd /tmp
git clone https://github.com/simonw/datasette
cd datasette
python3 -m venv venv
source venv/bin/activate
pip install wheel # So bdist_wheel works in next step
pip install -e '.[test]'
LD_PRELOAD=/tmp/SQLite-40fa792d/.libs/libsqlite3.so pytest

After some trial and error I proved that those tests passed with 3.36.0:
cd /tmp
wget https://www.sqlite.org/src/tarball/5c9a6c06/SQLite-5c9a6c06.tar.gz
tar -xzvf SQLite-5c9a6c06.tar.gz
cd SQLite-5c9a6c06
CPPFLAGS="-DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE=1" ./configure
make
cd /tmp/datasette
LD_PRELOAD=/tmp/SQLite-5c9a6c06/.libs/libsqlite3.so pytest tests/test_internals_database.py

BUT failed with 3.37.0:
# 3.37.0
cd /tmp
wget https://www.sqlite.org/src/tarball/bd41822c/SQLite-bd41822c.tar.gz
tar -xzvf SQLite-bd41822c.tar.gz
cd SQLite-bd41822c
CPPFLAGS="-DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE=1" ./configure
make
cd /tmp/datasette
LD_PRELOAD=/tmp/SQLite-bd41822c/.libs/libsqlite3.so pytest tests/test_internals_database.py

I thought I'd need to introduce https://dirty-equals.helpmanual.io/types/string/ to help write tests for this, but I think I've found a good alternative that doesn't need a new dependency.

Updated this TIL with extra patterns I figured out: https://til.simonwillison.net/sqlite/ld-preload


Verify that AI lightup logger filter rules is composed correctly with appsettings.json

Required layering:

AI defaults
AI setting.json file
appconfig.json

@pakrym status?

https://github.com/aspnet/AzureIntegration/pull/69 this is part of it, we also need to get a build of AI that has https://github.com/Microsoft/ApplicationInsights-aspnetcore/pull/486 in

@pakrym will this be in today, or Monday?
cc @Eilon

@DamianEdwards said next week

Manual verification/validation part. All PR's are in but we still need to ingest AI package as soon as they produce it.

@Eilon This will happen Monday possibly.  cc @mikeharder as we'll need to ingest their packages.
cc @glennc to follow-up with AI folks as both @Eilon and me will be OOF.

@pakrym @glennc @mikeharder - What's left here?

@Eilon I was waiting for build of CLI with new AI package and out fixes to do verification on clean machine.

@pakrym ok - do we know when we'll have that? I would have thought that the AI in the CLI would be done by now, no?

@Eilon We have AI in VS light up bug now

@Eilon we can close this and do it as part of verification. I just want to make sure things work E2E without hacks.

@pakrym ok then please do so.


Ionic Capacitor Problem

Describe the bug
Trying to add this plugin to my Ionic-Angular-Capacitor project results in error when building the project:
[ng] ./node_modules/cordova-background-geolocation-plugin/www/BackgroundGeolocation.js:13:14-40 - Error: Module not found: Error: Can't resolve 'cordova/channel' in 'my-app/node_modules/cordova-background-geolocation-plugin/www'
To Reproduce
Steps to reproduce the behavior:

create new ionic project with Angular and Capacitor
add cordova-background-geolocation-plugin to project:
npm install cordova-background-geolocation-plugin
add plugin example code to your project
execute ionic serve
above mentioned error pops up

Expected behavior
project builds without error
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: LinuxMint 19
Browser: Firefox
Version: latest

Smartphone (please complete the following information):

Device: MotoG7
OS: Android 11

Just install the packages in this way and sync, tested by me, it works perfect
$ npm i cordova-background-geolocation-plugin
$ npm install @awesome-cordova-plugins/background-geolocation
$ ionic cap sync

Thanks @josuelmm for reporting back on this.
I'm closing since it doesn't look like we need to fix any thing...

Hello mates,
Issue still there, tried steps provided by @josuelmm  but still getting Can't resolve 'cordova/channel and Can't resolve 'cordova/cordova/exec
Same issues are opened on [mauron85] package and one of the merger PR is providing solution, can we have same fix here or shall we move back to the other package ?
Thanks a lot

I'm now using capacitor and this plugin, I don't have any problems.
As far as I know the other plugin isn't maintained anymore and you won't be able to use it, but you are free to choose which plugin to use.
Here's how I use it in my app, nothing special:
https://github.com/IsraelHikingMap/Site/blob/242fe282f19f42542319c36e5becf2af69087f50/IsraelHiking.Web/package.json#L45

Hello @HarelM, Thank you very much for your reply !
I haven't expected this quick reply !
I am using the same packages and the same enivrement's settings that you are using in israelhicking project.
After an overall checking of the implementation, i found that everything is working fine !
The only imperatives to make it work are:

Instantiate the package like this:
import { BackgroundGeolocationPlugin} from 'cordova-background-geolocation-plugin';
declare let BackgroundGeolocation: BackgroundGeolocationPlugin;
Test it/ use it only in capacitor enivrement: Otherwise BackgroundGeolocation will be undefined.

When trying to instantiate BackgroundGeolocation as an object of type BackgroundGeolocationPlugin, i was getting Can't resolve 'cordova/channel and Can't resolve 'cordova/exec errors on runtime and buildtime !
Thank you very much again, the package is awesome ! You rock 🤘
One last thing, do have a recommandation guideline for the battery drain and for the startOnBoot ?

I'm not using start on boot. Battery drain is a problem, I believe the problem is with the screen mostly and not with the GPS from small tests we made, also the code here doesn't do much and I don't think it can be optimized much.
Having said that, there is another package from transistor soft that is more battery optimized but also less accurate, so even though I tried to use it and also paid for it, I ended up using this one (and maintain it).

Thank you @HarelM  for all the given informations !
You rock man !
You made my day and you make IT world fantastic !
God bless you 🤘


[BUG]: Requested quality is not allowed in user's subscription

Which tool
Tidal-gui
Version
<IP_ADDRESS>
Platform
Windows
Describe the bug
Requested quality is not allowed in user's subscription
Relevant log output
No response
Add screenshots

It couldn't download


Make it able to throw in Warden::Manager.on_request

In Warden::Test::Helpers#login_as, it's using
Warden.on_next_request, which is using
Warden::Manager.on_request, and it would call
proxy.set_user which would possibly throw.
This means before this patch, Proxy.new could
throw in the tests. We're also expecting env['warden']
to be set in Warden::Manager, therefore we need to
decouple initializing the object and calling the on_request
callbacks, and move env['warden'].on_request inside the
catch block to handle the logging in process properly
in the tests.
I am not sure if people are relying on this behaviour
other than tests, but I assume it's not bad to be able to
throw in Warden::Manager.on_request as a way to
stop the chain early.
Without this patch, in the tests, :warden would be thrown
whenever it failed to login. People might be depending on
this behaviour, but throwing symbols like this could break
people's cleanup code.
Here's an example: https://github.com/rails/rails/pull/28373
Rails was using rescue Exception before to cleanup stuffs,
but it would not be rescuing any symbols. There were other
codes doing things like this, causing some weird transient
test failures like this for GitLab:
https://gitlab.com/gitlab-org/gitlab-ce/issues/40093
In short, we shouldn't let any throw bubble up. The other
way to fix this would be not using Warden::Manager.on_request
to login, but that might need more changes and could break
even more codes. Also, I think it's not bad to be able to
throw :warden in Warden::Manager.on_request.
/cc @Reprazent

Is there anything I can do to push this forward?


where to get "validation.txt" file for ADE20K dataset?

val_list: dataset/ade20k/list/validation.txt
Please help me to get this file.
Thanks,
Bhavika

How did you solve this?

Have you solved it?


feat(providers): comobox + dynamic setup instructions

Uploading movie.mp4…

Looking good! Don't forget about dark mode though 😉


Provide API and visibility in order to extend RedisClient and its connections

Some scenarios and users need to alter behavior of the redis client (see #31). This is currently not possible. It's required therefore to be able to extend the client and inject custom behavior.
This can be implemented by subclassing RedisClient and providing own implementations of the Redis...ConnectionImpl classes.

@kichik, this one is for you. HTH

Thanks Mark! This will make it super easy for us to fix such issues in the future without reflection voodoo.


Create 222222

In 2011, Stanford University offered three online courses, which anyone in the world could enroll in and take for free. Together, these three courses had enrollments of around 350,000 students, making this one of the largest experiments in online education ever performed. Since the beginning of 2012, we have transitioned this effort into a new venture, Coursera, a social entrepreneurship company whose mission is to make high-quality education accessible to everyone by allowing the best universities to offer courses to everyone around the world, for free. Coursera classes provide a real course experience to students, including video content, interactive exercises with meaningful feedback, using both auto-grading and peer-grading, and a rich peer-to-peer interaction around the course materials. Currently, Coursera has over 80 university and other partners, and 4 million students enrolled in its nearly 400 courses. These courses span a range of topics including computer science, business, medicine, science, humanities, social sciences, and more. In this talk, I'll report on this

In 2011, Stanford University offered three online courses, which anyone in the world could enroll in and take for free. Together, these three courses had enrollments of around 350,000 students, making this one of the largest experiments in online education ever performed. Since the beginning of 2012, we have transitioned this effort into a new venture, Coursera, a social entrepreneurship company whose mission is to make high-quality education accessible to everyone by allowing the best universities to offer courses to everyone around the world, for free. Coursera classes provide a real course experience to students, including video content, interactive exercises with meaningful feedback, using both auto-grading and peer-grading, and a rich peer-to-peer interaction around the course materials. Currently, Coursera has over 80 university and other partners, and 4 million students enrolled in its nearly 400 courses. These courses span a range of topics including computer science, business, medicine, science, humanities, social sciences, and more. In this talk, I'll report on this


Enhance git repo move

An error is thrown when moving the git repository if one already exists on the output directory.
(shallow-backup) $ ls -a ~/sh-back
.  ..  .git  .gitignore
(shallow-backup) $ ls -a ~/sh-back-2
.  ..  .git  .gitignore
(shallow-backup) $ python shallow_backup/cli.py

              dP                dP dP                        dP                         dP
              88                88 88                        88                         88
     ,d8888'  88d888b. .d8888b. 88 88 .d8888b. dP  dP  dP    88d888b. .d8888b. .d8888b. 88  .dP  dP    dP 88d888b.
     Y8ooooo, 88'  `88 88'  `88 88 88 88'  `88 88  88  88    88'  `88 88'  `88 88'  `"" 88888"   88    88 88'  `88
           88 88    88 88.  .88 88 88 88.  .88 88.88b.88'    88.  .88 88.  .88 88.  ... 88  `8b. 88.  .88 88.  .88
     `88888P' dP    dP `88888P8 dP dP `88888P' 8888P Y8P     88Y8888' `88888P8 `88888P' dP   `YP `88888P' 88Y888P'
                                                                                88
                                                                                dP
	v1.4a by Aaron Lichtman (@alichtman)

Current shallow-backup path: /home/nunomdc/sh-back
[?] Would you like to update this?:  Yes
 >  Yes
    No

Enter relative or absolute path:
~/sh-back-2

Updating shallow-backup path to /home/nunomdc/sh-back-2
Traceback (most recent call last):
  File "shallow_backup/cli.py", line 180, in <module>
    cli()
  File "/home/nunomdc/.local/share/virtualenvs/shallow-backup-zRzFi1jy/lib/python3.6/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/nunomdc/.local/share/virtualenvs/shallow-backup-zRzFi1jy/lib/python3.6/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/nunomdc/.local/share/virtualenvs/shallow-backup-zRzFi1jy/lib/python3.6/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/nunomdc/.local/share/virtualenvs/shallow-backup-zRzFi1jy/lib/python3.6/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "shallow_backup/cli.py", line 79, in cli
    prompt_for_path_update(backup_config)
  File "/home/nunomdc/repos/shallow-backup/shallow_backup/prompts.py", line 25, in prompt_for_path_update
    move_git_repo(current_path, abs_path)
  File "/home/nunomdc/repos/shallow-backup/shallow_backup/git_wrapper.py", line 99, in move_git_repo
    move(git_dir, new_path)
  File "/home/nunomdc/.local/share/virtualenvs/shallow-backup-zRzFi1jy/lib/python3.6/shutil.py", line 542, in move
    raise Error("Destination path '%s' already exists" % real_dst)
shutil.Error: Destination path '/home/nunomdc/sh-back-2/.git' already exists

To fix this, we should make sure that the path doesn't exist before copying it. I believe the method responsible for moving the git repo is in git-wrapper.py, potentially called move_git_repo(), but I'm not sure.

What would be the expected behaviour on error?

exit the application
prompt for overwrite
other option

If it does exist, print an error message and exit.

If it does exist, print an error message and exit.

Ok. So should we exit early, as soon as the issue is detected?
Have a look at this commit https://github.com/nunomdc/shallow-backup/commit/6b27205f5e74ba4696a1ca6cf073db2633a4f8d9

Open a PR so I can leave comments on specific lines. That commit is close, but not exactly how I think this feature should work.


apache2::mod_php5 no longer present in v4.0.0 of apache2 cookbook

Another bug without a PR to fix it I'm afraid, but just so it's tracked for now a new version of the apache2 cookbook was released yesterday which has removed the mod_php5 recipe in favour of one called mod_php.
Currently https://github.com/sous-chefs/nagios/blob/master/recipes/apache.rb#L21 includes mod_php5 - presumably a straight swap should fix it but I haven't actually tested it yet.

Fixed by https://github.com/sous-chefs/nagios/pull/537
Thanks for the report


fix(loader): wrong build target

What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
Bugfix
What is the current behavior? (You can also link to an open issue here)
A wrong rootContext string was passed to build config as target, so spriteModule and symbolModule always in isomorphic mode and can not inject DOMContentLoaded into bundled js
What is the new behavior (if this is a feature change)?
Pass right target to config
Does this PR introduce a breaking change?
No

We just noticed this after switching from using #249 to v3.7.0 and the sprite sheet wasn't being injected. I've checked out this PR instead and now the sprite sheet container is being injected, but doesn't contain any definitions, the <svg> element is empty.

@KrofDrakula I believe this bug only exists with Webpack 4.0, maybe you can pass
options: {
  spriteModule: 'svg-sprite-loader/runtime/browser-sprite.build.js',
  symbolModule: 'svg-baker-runtime/browser-symbol'
}

to svg-sprite-loader in your webpack config as a temp solution.

OK, will try that next, thanks!

I tried using 821dafe to run and added the options config as described above, but the svg sprite sheet is still mounted but unpopulated in body. The master version of svg-sprite-loader still doesn't work for us.

@ydfzgyj published as<EMAIL_ADDRESS>


Again: ignore result of job runner if job has been canceled

First PR: #1188
Reverted by #1196
New try. First, I get the code again, and then will commit the fix, once I find the issue.

Codecov Report
Patch coverage: 85.00% and project coverage change: -1.41 :warning:

Comparison is base (ef3e9cc) 89.97% compared to head (2d38909) 88.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
- Coverage   89.97%   88.56%   -1.41%
==========================================
  Files         186       94      -92
  Lines        9982     4443    -5539
==========================================
- Hits         8981     3935    -5046
+ Misses       1001      508     -493

Flag
Coverage Δ

jobs_cache_maintenance
?

jobs_mongodb_migration
82.65% <ø> (ø)

libs_libcommon
91.46% <85.00%> (-0.04%)
:arrow_down:

services_admin
86.83% <ø> (ø)

services_api
?

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

libs/libcommon/src/libcommon/simple_cache.py
97.28% <ø> (ø)

libs/libcommon/src/libcommon/state.py
94.50% <ø> (ø)

libs/libcommon/src/libcommon/queue.py
90.00% <66.66%> (+0.21%)
:arrow_up:

libs/libcommon/tests/state/test_objects.py
100.00% <100.00%> (ø)

...s/libcommon/tests/state/test_plan_on_real_graph.py
100.00% <100.00%> (ø)

libs/libcommon/tests/state/utils.py
92.85% <100.00%> (-0.09%)
:arrow_down:

libs/libcommon/tests/test_queue.py
100.00% <100.00%> (ø)

... and 92 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

To investigate, the commit has been deployed in production between Wed May 17 2023 18:11:12 GMT+0200 and Thu May 18 2023 15:49:11 GMT+0200.
Indeed, the volume of worker's logs speak for itself: the workers have not done much during that period:

Extract of the logs:
INFO: 2023-05-18 00:38:22,171 - root - get config-opt-in-out-urls-count for dataset=allenai/nllb config=bho_Deva-kas_Arab
INFO: 2023-05-18 00:38:22,171 - root - [config-opt-in-out-urls-count] compute JobManager(job_id=64649094cc2847d3c6cda88f dataset=allenai/nllb job_info={'job_id': '64649094cc2847d3c6cda88f', 'type': 'config-opt-in-out-urls-count', 'params': {'dataset': 'allenai/nllb', 'revision': 'main', 'config': 'bho_Deva-kas_Arab', 'split': None}, 'priority': <Priority.NORMAL: 'normal'>}

In normal mode, the logs don't help much, we cannot see what occurs at queue level

What is clear is that we don't have any WARNING: 2023-05-19 12:13:25,521 - root - job /config-names,boligmappa/home-standard-results has a non-empty finished_at field. Force finishing anyway. message during that period, meanwhile we had a lot the rest of the time (it seems to be nearly the "normal" way to work).

So, the underlying issue could be that when a job finished, in general, it has already been cancelled! As upsert_job currently works by cancelling all the similar jobs, then creating a new one, it means that another process has asked to create that job again.

In reality, we have 7 occurrences of this message, I'm not sure what this means, because we have a lot of started jobs during that time. Are the job just not existing anymore, so: queue.finish_job() returns immediately?

Even with the new code, the message "WARNING ... has a non-empty finished_at field. Force finishing anyway.` should still appear.

I cannot reproduce on dev env

Closing. I'll do smaller PRs


Connection lost due to NullPointerException immediately on receipt of first message

Connector starts up up fine with Confluent Platform 3.0 but I get a java.lang.NullPointerException when I publish the first MQTT message using mosquitto broker and mosquito_pub.
ERROR MQTT connection lost! (com.evokly.kafka.connect.mqtt.MqttSourceConnector:188)
MqttException (0) - java.lang.NullPointerException
at org.eclipse.paho.client.mqttv3.internal.CommsCallback.run(CommsCallback.java:176)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:264)
at com.evokly.kafka.connect.mqtt.util.Utils.getConfiguredInstance(Utils.java:13)
at com.evokly.kafka.connect.mqtt.MqttSourceTask.messageArrived(MqttSourceTask.java:216)
at org.eclipse.paho.client.mqttv3.internal.CommsCallback.handleMessage(CommsCallback.java:354)
at org.eclipse.paho.client.mqttv3.internal.CommsCallback.run(CommsCallback.java:162)
... 1 more

It seems that you haven't configured connector correctly. I will write some sample on the weekend how to do that.

An example working connect-standalone.properties file would be helpful. I'm just working from what I believe to be the default settings.

I've checked it some more over the weekend, and there are some things which 0.10 API defines (e.g., config() method) so in a couple of days I will release a new version (with some examples).

@hjespers if you are interested in WIP, take a look on #11

Same problem with Confluvent Kafka Version <IP_ADDRESS>-cp1

@srijiths did u try kafka_10 branch?

Debugd your code and there is a null pointer exception here
mMessageProcessorClassName = props.get(MqttSourceConstant.MESSAGE_PROCESSOR);
[2016-07-04 13:31:36,088] INFO Class Name :null (com.evokly.kafka.connect.mqtt.MqttSourceConnector:214)

@moperacz using master i was able to connect to MQTT and subscribe to a topic.
 Start a MqttSourceTask (com.evokly.kafka.connect.mqtt.MqttSourceConnector:65)
[2016-07-04 13:31:23,482] INFO Created connector mqtt (org.apache.kafka.connect.cli.ConnectStandalone:91)
[2016-07-04 13:31:23,486] INFO class for processing messages: null (com.evokly.kafka.connect.mqtt.MqttSourceConnector:75)
[2016-07-04 13:31:23,811] INFO [paho2864913584850244] Connected to Broker (com.evokly.kafka.connect.mqtt.MqttSourceConnector:124)
[2016-07-04 13:31:23,957] INFO [paho2864913584850244] Subscribe to 'test1' with QoS '1' (com.evokly.kafka.connect.mqtt.MqttSourceConnector:136)

But with kafka_10 branch i am not able to connect to MQTT with the same settings as before.
[2016-07-04 13:55:50,738] ERROR [paho2866380805822051] Connection to Broker failed! (com.evokly.kafka.connect.mqtt.MqttSourceConnector:119)
Unable to connect to server (32103) - java.net.ConnectException: Connection refused
        at org.eclipse.paho.client.mqttv3.internal.TCPNetworkModule.start(TCPNetworkModule.java:79)
        at org.eclipse.paho.client.mqttv3.internal.ClientComms$ConnectBG.run(ClientComms.java:590)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.net.ConnectException: Connection refused
        at java.net.PlainSocketImpl.socketConnect(Native Method)
        at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
        at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
        at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
        at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
        at java.net.Socket.connect(Socket.java:589)
        at org.eclipse.paho.client.mqttv3.internal.TCPNetworkModule.start(TCPNetworkModule.java:70)
        ... 2 more
[2016-07-04 13:55:50,747] ERROR [paho2866380805822051] Subscribe failed!  (com.evokly.kafka.connect.mqtt.MqttSourceConnector:132)
Client is not connected (32104)
        at org.eclipse.paho.client.mqttv3.internal.ExceptionHelper.createMqttException(ExceptionHelper.java:31)
        at org.eclipse.paho.client.mqttv3.internal.ClientComms.sendNoWait(ClientComms.java:143)
        at org.eclipse.paho.client.mqttv3.MqttAsyncClient.subscribe(MqttAsyncClient.java:721)
        at org.eclipse.paho.client.mqttv3.MqttClient.subscribe(MqttClient.java:320)
        at org.eclipse.paho.client.mqttv3.MqttClient.subscribe(MqttClient.java:313)
        at com.evokly.kafka.connect.mqtt.MqttSourceTask.start(MqttSourceTask.java:127)
        at org.apache.kafka.connect.runtime.WorkerSourceTask.execute(WorkerSourceTask.java:137)
        at org.apache.kafka.connect.runtime.WorkerTask.doRun(WorkerTask.java:140)
        at org.apache.kafka.connect.runtime.WorkerTask.run(WorkerTask.java:175)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

@moperacz the issue was due to connecting to tcp://localhost:1883. A new issue created #17

I have the latest kafka_10 code branch working with Confluent Platform 3.0 (aka Kafka 0.10). This is great work, thank you for contributing it. The connector is visible inside of Confluent Control Center and I can change all the configuration parameters via  Control Center GUI instead of via specifying them in the properties file. The data seems to be Base64 encoded when I get it back out using kafkacat or kafka-console-consumer.  There may be some enhancements possible to the way the data is encoded and decodes so users could configure at runtime if they want to use AVRO or any other schema for the messages.

@hjespers good to hear that it is working.
as for base64 (i know, documentation/manuals):
The default "processor" is dummy one, and basically, it set schema to topic->string, body->bytes (https://github.com/evokly/kafka-connect-mqtt/blob/kafka_10/src/main/java/com/evokly/kafka/connect/mqtt/sample/DumbProcessor.java#L33), so it depends on your Kafka Connect configuration
if you change key.converter from JSON to io.confluent.connect.avro.AvroConverter Kafka Connect encodes the "base64" to Avro binary data.
we are using Avro with schema registry and its working excellent
The general idea is that you can provide message_processor_class (needs to implement com.evokly.kafka.connect.mqtt.MqttMessageProcessor interface) that receives binary (messages) data from MQTT (e.g. Google Protobuf stuff) and "process" it according to "some" iternal rules.
docs 😭

I changed the connect properties file to include the following and it works like a charm. Thanks. Looking forward to the documentation ;-)
key.converter=io.confluent.connect.avro.AvroConverter
key.converter.schema.registry.url=http://localhost:8081
value.converter=io.confluent.connect.avro.AvroConverter
value.converter.schema.registry.url=http://localhost:8081

@moperacz In kafka_10 branch , its working. Thank You

I'm getting 20,000 msg/sec throughput (QoS 0) and 7,800 msg/sec throughput (QoS 1) with a single connector and everything running on my Macbook. This is awesome! Thanks again for making this. I'm streaming my connected car telemetry through it and (soon) into Kafka Streams for analytics.


[Issue-3212] Extension - Update main tabbar structure

Related issue: #3212

🚀 Deployed on https://pr-3253--sw-web-runner.netlify.app


Remove "Sequence Playground" from UI?

At a group meeting a couple of weeks ago, the consensus seemed to be that this was sort of a prototype to see if the front end could read sequences before there were visualizers to look at them with. So probably this section of the UI, which doesn't really seem to add any functionality, should seemly be retired and removed. But this should be explicitly agreed upon by the group before proceeding.

I think it might make sense to discuss "The Scope" and "Specimens" in separate issues. "The Scope" seems vague to me. I'm not sure what that link would lead to. I have no idea what "Specimens" is supposed to be.

See #79 and #78.


update(CSV): more annotation for features.

ref: https://issues.redhat.com/browse/RHOAIENG-2044
these are annotations only stated in ocp 4.14
https://docs.openshift.com/container-platform/4.14/operators/operator_sdk/osdk-generating-csvs.html
this will require changes in midstream as well.
since this is a more rhoai related request, it can be done by a backport once we verify CVP is working with tests.

add @tarukumar and  @jgarciao here for  review, since i am not 100% sure the support for tls and token part

I'm also not sure about what to set for those fields. I think we could leave them as "false"


AudioPlayer plays sound through ear speaker on iPhone

Please file the issue template. We are not having a chance to reproduce the issue. Although we don't have the resources at the moment to handle ios bugs :/

Duplicate of https://github.com/bluefireteam/audioplayers/issues/1194


Support for Sonoff Dual

Hi!
Is there any chance that this firmware will support Sonoff Dual ?

I have one here and haven't tackled it even though it wouldn't take very long to get going. I think because for a beginner they are a little more difficult to program. I will get onto it though to complete the Sonoff line up.

Sorry I have no plans to support a DUAL at this stage.


Use new-billing API output format (used in statement, report)

What

Introduce data type and parsers to handle new-billing output for statements and reports.
Switch over data type and parser use to actually work against the new output (this will require additional steps to minimise downtime link).
Change time range stop handling in current month to explicitly pass current time (new-billing would otherwise extrapolate data).

How to review

Code review
Deploy/test against dev env (we currently have dfe production data available in dev03 in org mini-test).
Testing might require to point the BILLING_URL environment variable of paas-admin against a new-billing endpoint (e.g.: cf set-env paas-admin BILLING_URL https://new-billing.dev03.dev.cloudpipeline.digital; cf restage paas-admin;).
I (@schmie) am happy to pair if anything is unclear : )

Who can review
not @schmie

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

here's what the output is for the failing test at https://github.com/alphagov/paas-admin/runs/5112056845?check_suite_focus=true#step:6:2175

Billables for February 20221 Billable events£0.02 Total including VAT£0.02 Total excluding VAT£0.02 Total excluding VAT including feeBillables by organisation for February 2022

Organization
Quota
Including VAT
Excluding VAT
Excluding VAT including fee

name-1996
£0.00
£0.00
£0.00

whereas on main the output is

Billables for February 20221 Billable events£0.02 Total including VAT£0.02 Total excluding VAT£0.02 Total excluding VAT including feeBillables by organisation for February 2022

Organization
Quota
Including VAT
Excluding VAT
Excluding VAT including fee

name-1996
£0.02
£0.02
£0.02

@schmie
deployed to dev03 and get the same error as with local dev
":10,"message":"accounts received 404 when making get request to /users/99022be6-feb8-4f78-96f3-7d11f4d476f1 in 10ms"}
{"level":50,"time":1645096658933,"pid":15839,"hostname":"GDS7463","req":{"method":"GET","url":"/organisations/a7aff246-5f5b-4cf8-87d8-f316053e4a20/statements/2022-02-01"},"stack":"Error: Billing is currently unavailable, please try again later.\n    at Object.<anonymous> (/Users/janikraner/paas/paas-admin/dist/webpack:/paas-admin/src/components/statements/controllers.tsx:281:11)\n    at Generator.throw (<anonymous>)\n    at rejected (/Users/janikraner/paas/paas-admin/node_modules/tslib/tslib.js:115:69)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)","type":"Error","msg":"Billing is currently unavailable, please try again later."}

Hi @kr8n3r
Thanks for reviewing!
The step cf set-env paas-admin BILLING_URL https://new-billing.dev03.dev.cloudpipeline.digital; cf restage paas-admin; was missing - ran it in dev03, if you like to have another look.
Cheers!

@schmie  thanks
org billing and calculator are working but admin overall cost report isn't working https://admin.dev03.dev.cloudpipeline.digital/reports/cost/2022-01-01

@schmie thanks org billing and calculator are working but admin overall cost report isn't working https://admin.dev03.dev.cloudpipeline.digital/reports/cost/2022-01-01

We think this is because we bought some production data into the dev environment (and the quota GUIDs are different). I'll discuss with seb the best way to test this.

We updated the data and reports are working, now.


Does it make sense to enable guard-teaspoon to use :cmd option for starting spring teaspoon?

I don't know about others, but personally I would like to be able to set :cmd to anything I want. For my apps I wrap commands in foreman run so it loads my environment variables for that command only, without exporting them into the current shell session. This works for Rspec + Guard, but Teaspon + Guard fails to honor the custom command.

Hi, after posting that I tried something that solved my problem. I now wrap the entire guard start command with Foreman instead, and everything works perfectly. Sorry for adding noise to the issue.

No worries! I don't use guard regularly and I wrote this project more or less as a proof of concept. I am by no means opposed to someone who knows what they're doing with guard to improve upon it. I don't even know what :cmd means, and have little time to really understand the stack as well as I should to provide this as a good solution. Feel free to make PRs. :)

Jeremy Jackson

On Sep 4, 2015, at 6:11 PM, Justin Workman<EMAIL_ADDRESS>wrote:
Hi, after posting that I tried something that solved my problem. I now wrap the entire guard start command with Foreman instead, and everything works perfectly. Sorry for adding noise to the issue.
—
Reply to this email directly or view it on GitHub.

Guard has an option named :cmd that you set in the Guardfile for each suite (Rspec, Teaspoon, etc). It's the command that runs Teaspoon (e.g. bundle exec rake teaspon)
Proof of concept or not, this plugn does the job! Thanks for creating it.

@xtagon I have a similar issue with the :cmd option trying to get guard-teaspoon to run bundle exec spring teaspoon instead of bundle exec teaspoon when a change is detected. Can you elaborate on your workaround/solution?

@nerfologist I start guard with the command foreman run bundle exec guard start (Foreman loads my .env file). My Guardfile has the line:
guard :teaspoon, cmd: "spring rake teaspoon" do
  # watch ...
end

It's a lot of comand wrapping but it works for me.

if anybody wants to submit a PR, I'd merge it.. I don't use it, so it's hard for me to get a good setup and make sure everything is working.


Question : is it safe to set  webSocketHead  httpSocketHead Group members as public ?

General Question
i want to do simple iteration on all clients that are connected to my server
and do manipulation on them for example not to send to all of them response
i want to implement it as simple as link list iterator :
WebSocket<isServer> *webSocket0 h.getDefaultGroup<uWS::SERVER>()->webSocketHead
                 while (webSocket0 != nullptr)
		{
                        //DO STUFF HERE WITH webSocket0
			webSocket0 = (WebSocket<isServer> *) webSocket0->next;
		}

The problem is that the webSocketHead is protected , so is it safe to move it to public ?
also i notice you have the general ForEach loop on all the connected clients
can you please explain why it have to be so complex ? why not just as above loop ?
Thanks

Group::forEach already implement what you want. They are a little messy but at least they handle deletions mid iteration. I don't see the issue here

i Don't what deletions
i what to control which WebSocket connection to send and which not
The ForEach are to general and over complex for my simple needs

If you don't want to listen then don't ask. You are free to do whatever you want. I'm not your mum.


fix: stop encoding synthetic fields

Codecov Report

Merging #330 (443877c) into master (3cdd61d) will increase coverage by 1.09%.
The diff coverage is 57.14%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   58.94%   60.03%   +1.09%
==========================================
  Files           7        7
  Lines        1023     1061      +38
==========================================
+ Hits          603      637      +34
- Misses        353      354       +1
- Partials       67       70       +3

Impacted Files
Coverage Δ

encoding/protobq/schema.go
78.94% <57.14%> (-5.27%)
:arrow_down:

... and 1 file with indirect coverage changes


Singularity support from cvmfs

Steps needed:

[x] Add CVMFS: https://training.galaxyproject.org/training-material/topics/admin/tutorials/cvmfs/tutorial.html
[ ] Configure job dependencies https://docs.galaxyproject.org/en/master/admin/jobs.html#running-jobs-in-containers

Singularity cvmfs is down:
From Nate (March 26): "the singularity repo is not in the best shape at the moment unfortunately.
We are currently rebuilding it" and "For the full rebuild it will take on the order of a few weeks to a month. In the meantime, you may need to limit which stratum 1 servers the client will attempt to use for that repo".


How do I make a rotating background in Lua?

Describe your problem here.
How do I make a rotating background like this in Lua? (Disassambler from VS. Shaggy v2.5)
https://youtu.be/7OFw9WPhox4?t=102
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x86/x32
Did you edit anything in this build? If so, mention or summarize your changes.
No response

that's not rotating the background, it's rotating the game camera
read tween and timers

yes, i figured that out, although i don't know how to make it rotate left and right on beat.
i tried this code but it didn't work
function onBeatHit()
    if curBeat % 4 == 1 then
        doTweenAngle('camerathing', 'camera', 10, 1, 'linear')
    end

    if curBeat % 2 == 2 then
        doTweenAngle('camerathing', 'camera', -10, 1, 'linear')
    end
end

Probably something like this idk
if curBeat % 4 == 2 then
     doTweenAngle('camerathing', 'camGame', 10, crochet/1000, 'linear') --probably change ease
elseif curBeat % 4 == 0 then
     doTweenAngle('camerathing', 'camGame', -10, crochet/1000, 'linear')
end

Ima make a way without tweens lol...
Very ineficient but it was fun...
local Speed = 0.05 -- adds up quick
local angle = 5

-- cam be `Game`, `HUD`, or `Other`
-- there can be multiple cameras
local cameras = {"Game"}

local Radians = 0

function onUpdate()
	Radians = Radians + Speed -- add some speed

	for i, v in pairs(cameras) do
		setProperty("cam"..v..".angle", math.sin(Radians) * angle)
	end
end


WSL 2: wsl --shutdown accepts extra cmdline arguments

wsl --shutdown is the entire legal command according to wsl --help. However, if I actually type wsl --shutdown Ubuntu (i.e. when I get confused about which of --shutdown and --terminate is which), no error is issued. There should be an error, because Ubuntu is not an expected parameter to --shutdown.
Put another way. Actual behaviour:
c:\> wsl --shutdown foo
c:\>

Expected behaviour:
c:\> wsl --shutdown foo
Error: Unknown argument "foo"
c:\>

(No doubt this is happening because other cmdline options in wsl allow launching an arbitrary command within the WSL VM. However, --shutdown doesn't allow this, so shouldn't accept the meaningless/unused command argument.)
Windows build number: 10.0.18985.1

so shouldn't accept the meaningless/unused command argument

That's pretty normal
$ gcc --version foo
gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

No error on superfluous foo argument.

I think the fact gcc has the same issue doesn't mean it isn't a bug. Admittedly, --version and --help often do have this quirk, but it's rare for other options in my experience.

shutdown option does not accept any argument. It kills all running Lx session. Try that option with running WSL1 and WSL2 distribution simultaneously.


Throw an obvious installation when installing with node 0.11.x

We get a bunch issues for people having installation issues with node v0.11 that waste a lot of time.
The installation fails with cryptic node: symbol lookup error errors i.e. https://github.com/sass/node-sass/issues/1013

Not sure if just tightening up the engines property (and adding the "iojs" ranges) would help.

@nschonni I considered this however

Note that, unless the user has set the engine-strict config flag, this field is advisory only.

[engineStrict] is deprecated and will be removed in npm 3.0.0.

From my experience people don't read the output of npm before creating issues.

In my experience, people read both the npm logs and the issues before creating an issue. -- a people

Note to self on UNIX: Suppose we have a missing symbol in the library. If we load it shared library via var = request('binding.node');, this operation succeeds because of lazy loading of symbols. But any attempt to call anything that needs the undefined function will abort the program in the hard way - run time linker will simply _exit(1):
$ node scripts/build.js
` /home/saper/node_modules/node-sass/vendor/freebsd-x64-45/binding.node ` exists.
 testing binary.
/home/saper/sw/libsass/lib/libsass.so: Undefined symbol "call_undefined"
$ echo $?
1

There is no way to intercept this Undefined symbol error. npm is executing another copy of node for our lifecycle script and checks the return code. Maybe we should do it the same way.

@katowulf you're in the minority. This issue tracker is a testament to the contrary.
@saper we can simply get away with a process.version check. We know installation will fail hard with 0.11 so lets catch it early.

@saper so it looks like after the nan@2 update we now work on<EMAIL_ADDRESS>I tested locally with 0.11.6 on OSX.


Ignore gravity is not working for matter physics

Version

Phaser Version: 3.60.0

Operating system: MacOS Ventura 13.3

Browser: Chrome 112.0.5615.49

Description

The boolean property ignoreGravity on matter MatterJS.BodyType is not working anymore since release 3.60.0.
Although it is set to true, the body is affected by gravity.
Example Test Code
export class Bullet extends Phaser.Physics.Matter.Sprite {
constructor(...) {
super(...);
...
this.setIgnoreGravity(true);
...
}
}
Additional Information

The evaluation of the flag is missing in method Engine._bodiesApplyGravity.
This should be the correct code for this method, as it was before.
Also without typos in the jsdoc :)
/**
 * Applies a mass dependent force to all given bodies.
 * @method _bodiesApplyGravity
 * @private
 * @param {body[]} bodies
 * @param {vector} gravity
 */
Engine._bodiesApplyGravity = function(bodies, gravity) {
    var gravityScale = typeof gravity.scale !== 'undefined' ? gravity.scale : 0.001,
        bodiesLength = bodies.length;

    if ((gravity.x === 0 && gravity.y === 0) || gravityScale === 0) {
        return;
    }

    for (var i = 0; i < bodiesLength; i++) {
        var body = bodies[i];

        if (body.ignoreGravity || body.isStatic || body.isSleeping){
            continue;
        }

        // add the resultant force of gravity
        body.force.y += body.mass * gravity.y * gravityScale;
        body.force.x += body.mass * gravity.x * gravityScale;
    }
};

Hello ,  i looked for the solution online in order To apply your fix, you can create a custom plugin for Phaser 3 that patches the Engine._bodiesApplyGravity method with the corrected version. Here's what i found :
Create a new file called MatterGravityFixPlugin.js:
Code //////////////////////////////////////////////////////////////////////////////////////////
export class MatterGravityFixPlugin extends Phaser.Plugins.ScenePlugin {
constructor(scene, pluginManager) {
super(scene, pluginManager);
}
boot() {
const Matter = Phaser.Physics.Matter.Matter;
this.applyGravityFix(Matter);
}
applyGravityFix(Matter) {
Matter.Engine._bodiesApplyGravity = function (bodies, gravity) {
var gravityScale = typeof gravity.scale !== 'undefined' ? gravity.scale : 0.001,
bodiesLength = bodies.length;
  if ((gravity.x === 0 && gravity.y === 0) || gravityScale === 0) {
    return;
  }

  for (var i = 0; i < bodiesLength; i++) {
    var body = bodies[i];

    if (body.ignoreGravity || body.isStatic || body.isSleeping) {
      continue;
    }
    body.force.y += body.mass * gravity.y * gravityScale;
    body.force.x += body.mass * gravity.x * gravityScale;
  }
};

}
}
//////////////////////////////////////////////////////////////////////////////////
Import the plugin in your main game file:
// /////////////////////////////////////////////////////////////Code
import { MatterGravityFixPlugin } from './MatterGravityFixPlugin';
Register the plugin in your game configuration:
javascript
Copy code
const config = {
plugins: {
scene: [
{
key: 'MatterGravityFixPlugin',
plugin: MatterGravityFixPlugin,
mapping: 'matterGravityFix',
start: true,
},
],
},
};
/////////////////////////////////////////////////////////////////////////////////////////
Now, the custom plugin will apply the gravity fix you provided when the game starts.

const Matter = Phaser.Physics.Matter.Matter;
this line fails to pass tslint in my environment... any idea why Matter.Matter wouldn't ?
I have to force the following:
   const Matter = (Phaser.Physics.Matter as any).Matter;
That being said, great fix. Thanks!

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Remove redundant pool parameter from snapshot class

The SnapshotClass for RBD requires a pool parameter. This is redundant
as a snapshot is not created on a different pool than the source image
of the snapshot (refer rbd man page).
Further, when a snapshot needs to be created its source CSI VolumeID
is passed to the creation call, and hence the source volumes pool
needs to be reused to create the snapshot.
Similarly to clone a snapshot, the create request would come in with a
SnapshotID to help identify the snapshot pool, and the same create
request parameters would contain the storage class based pool parameter
to create the clone into (as clones can be in different pools as
compared to their parent snapshots).
Thus, the parameter pool seems redundant in the snapshot class and
should be removed to improve ease of use.
Fixes #379
Signed-off-by: ShyamsundarR<EMAIL_ADDRESS>

LGTM. Thanks !


Sending text moves cursor

So I type ctrip at the end of the line print(3) where my cursor is at the end of the line and it moves my cursor to the beginning of the line.
Is it possible to make it not do that?

I did some tests here and it works here. Also, I removed a normal command which was messing with registers.

You may want to use winsaveview() and winrestview() instead of a temporary mark, since I (and others presumably) use plugins like signature.vim to show marks, and toggling marks is a bit jarring when your gutter suddenly changes size.

I'll take a look at those...
Cheers


Comment use of keywords in pylsl.resolve_byprop.

Thanks for contributing a pull request! Please make sure you have read the
contribution guidelines
before submitting.
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
Reference issue
Example: Fixes #1234.
What does this implement/fix?
Explain your changes.
Additional information
Any additional information you think is important.

Thanks @akovrig

@larsoner @teonbrooks feel free to tag @akovrig on any easy or "first contributor" PRs. He pinged me privately with the intention but I don't have great ideas on which issues I could point to.


feat: add more networks for opstack

Add additional opstack networks such as Worldchain, Unichain, Zora, Ink, etc...

I'd like to take this up

@ncitron are the consensus rpcs for these chains planning to be hosted at .operationsolarstorm.org like we have for base + optimism in the repo?


BEP029: Extend BIDS to add motion capture and movement data

Hi, I would like to start extending BIDS to cover movement data, including live motion capture as well as virtual transform data. I have asked around on ResearchGate and a couple of other threads to see if there is ongoing work along the line and have not identified any yet- Here is the Google Doc for the proposal as a starting point. We would like to converge more opinions and contribution from anyone interested : https://docs.google.com/document/d/1iaaLKgWjK5pcISD1MVxHKexB3PZWfE2aAC5HF_pCZWo/edit?usp=sharing

In BIDS-Derivatives, we have some basic Motion-related time series. To the extent that we're describing similar things, common formats and naming conventions would be good to settle on.

@effigies Hi, thanks for pointing me to it! This indeed covers some of the important aspects in movement data specs. This also can be another motivation for us to call it BIDS-motion instead of BIDS-move. Matching the formats, we can try labeling channels with "type_component" like in "trans_x" and "rot_x". I have one question regarding the time series here - is the translation time series representing translation between frames or is it always from a fixed reference point? If latter is the case, we may as well consider replacing the concepts "position" and "orientation" in the current spec with "translation" and "rotation".

Fixed reference is what I've always seen, but if there's a situation where it's done framewise, we can either come up with a new name or add a metadata field to disambiguate.

I think this is also interesting for @helenacockx

At the Donders we have looked at BIDS for movement data, and converted some example datasets to a BIDS-like format. Those can be found on http://www.fieldtriptoolbox.org/example/bids_motion/. We now also have some inhouse XSens datasets in a BIDS-like organization (combined with NIRS), but the format is still preliminary.

The actual example is on ftp://ftp.fieldtriptoolbox.org/pub/fieldtrip/example/bids_motion (currently only one, the other is still locally on my computer but could be shared if people are interested).

Hello @robertoostenveld and @helenacockx, it was very nice seeing you in the NIRS meeting. And thanks, I saw the example data set and the style we are aiming for in BIDS-move (or motion) will be pretty much like that with just some more specifications. This relates to one of my biggest question at the moment - do you think this specification deserves an extension of its own or can be an addition to the existing continuous data specs for physiological and other continuous recordings?
Either way, my impression after the meeting was that we would first have to identify more people who are interested. Now that we have a GoogleDoc set up I will start sending around the link to the doc and this thread. MoBI conference 2020 would have been a great opportunity for that, but unfortunately it's the special year...

Hi sjeung. Indeed very nice to meet! As far as I understand, you could indeed add the motion data as another recording of continuous physiological data. However, I think that it would be very valuable if motion data could stand on its own. I am indeed working with motion data from xsens (synchronuously with nirs and video data) and trying to put the whole dataset in a BIDS-like format. The motion tracking system of Xsens that I am using consist of 17 IMU's attached to different body parts (see https://www.xsens.com/products/mvn-analyze). If you are interested to know more about this system and how data is saved, please let me know and I would be happy to help!

@helenacockx great! I would definitely like to know more about your set-up, especially the time synchronization aspect and axes definition.
Me and @timo-berg will start converting a data set from MoBI.set (eeglab + mobilab plugin) to a pseudo-BIDS format as a starting point, but the raw data is in .xdf recorded through LabStreamingLayer (streamed from BrainVision recorder and Unity). The current specs on GoogleDoc is largely based on our experience from that setup, so we need to converge more information on different recording systems. We are also trying to find co-leads and contributors, so simply let us know if you'd like to be onboard.

@effigies Perhaps we can distinguish position/orientation (measured from a fixed reference) and translation/rotation (measured with respect to an updating reference frame-by-frame). I am still looking for other parts of BIDS where these spatial quantities are defined and trying to see how to maintain consistency, so if this convention of calling them translation/rotation is well-established, BIDS-motion would also call it translation/rotation, clarifying that this is assumed to be with respect to a fixed reference, then give users an option to specify framewise updates.

If you would like that, we can schedule a meeting and I can explain to you our experimental set-up. I am not sure whether I would be experienced enough to contribute to the BIDS-move since my main focus is fnirs data, but we could discuss this during a meeting as well.

@helenacockx Sure, it will be much appreciated. How about next week? In case there is anyone else in your group who is interested, they are welcome to join as well. As for time, any other days than Monday and Wednesday work for me. If the meeting will be just one-to-one or rather small, I suggest we use Skype.

Dear all, sorry for jumping in late. I have a very basic question, what kind of motion capture are you thinking about here? This is not completely clear to me. I also use an external motion correction device for MR and would like to join if you have a meting.

Hello @melanieganz, the proposal was originally motivated by live motion capture data recorded during physical motion in mobile EEG recording, by means of trackers or optical markers. But I believe the specifications are eventually generalizable to any type of time series representing positions or orientations. In motion correction in MR context, there are specifications as Chris @effigies has linked above: https://bids-specification.readthedocs.io/en/derivatives/05-derivatives/05-functional-derivatives.html#motion-related-time-series. If your data set requires additional specifications, then the meeting could be relevant for you as well. The goal of the meeting that I have in mind is to talk about different setups and how the raw data are represented.

Hi @melanieganz, you should think about systems like https://www.vicon.com, https://www.xsens.com, https://www.qualisys.com, https://polhemus.com, but possibly also https://en.wikipedia.org/wiki/Kinect. I.e. the primary goal is to capture position or motion (=position over time) and the primary data comprises the position, or the acceleration/gyroscope/magnetometer data, or similar.
Secondary data measured in the same experiment might be video, audio, or physiology (e.g. EEG or NIRS), but those would fall in their own section of the specification (since they could also be recorded by themselves).

Hey everyone,
@robertoostenveld , thanks for the invite. Great join the development about this important BIDS extension.
I am currently based in Kiel, Germany where so far we only did motion capture in big clinical cohorts focusing on IMU data, future studies will include EEG as well. We are currently working on a universal placing/coordinate layout for IMUs, which we hope makes IMU data more comparable across datasets..

FYI I have extended the http://www.fieldtriptoolbox.org/example/bids_motion/ example page; it now has XSens, Qualisys and Optotrak examples. The file formats for bids definitely need to be discussed, as well as the metadata in the json and channels.tsv, which is currently very limited in my draft examples.

Hello @JuliusWelzel.  I am very happy to hear that you are interested. So far not too much thought has been put into how to describe the placing of the trackers and we definitely need more research in that regard. We are still looking for co-leads and contributors who work with motion data. Please have a look at the GoogleDoc linked at the top of this thread and jump in where you think should be complemented.

@robertoostenveld Great! I myself haven't worked with the systems listed, so ideally we would find someone who is experienced with each of them. But I can start looking into how interpretable they are as it is now.

This BEP is now official: BEP029, see: https://github.com/bids-standard/bids-website/pull/123

Hi everyone, after a while of blank period from my side in the past month or so, I am looking forward to gaining more momentum for bids-motion by circulating this community survey. It would be great if you can copy, paste, share, spread, RT, like, spam, and so on. https://forms.gle/2hGzDUnberPAgNCB6

I have posted a request for people to fill out the questionnaire on the FieldTrip mailing list, see https://mailman.science.ru.nl/pipermail/fieldtrip/2020-July/040178.html

I will retweet and spread with the Bids-standard Twitter account :+1:

Thank you so much @sappelhoff @robertoostenveld. Me and @JuliusWelzel are planning a Skype call on the 18th of August to discuss interim results of the survey. In case you are interested and have time to join, please let us know (we can also move the meeting to the 20th or the 21st depending on your schedule).
The main issues will be the raw data format and the possibility of incorporating time stamps. Although the discussion around time stamp stream is not exactly about motion data, it is frequently recorded together with motion data and people seem to find it useful.  At the moment we are investigating how helpful time stamps are compared to time synchronization method introduced in http://www.fieldtriptoolbox.org/example/bids_pom/, in two example studies from different labs.

Protocol from the call on Tuesday (25.08.2020)
BIDS_BEP_029_TC.pdf

FYI I created a "team" for bep029-motion just now that you can use to add people and then tag: @bids-standard/bep029
@helenacockx @JuliusWelzel I just sent you invitations to join the bids org on GH

closed in #981


File Format for DDLS (CDS Data Definitions)

A: as a generic issue, we need to consider what the filename extensions should be, I dont think ".cds" is currently used anywhere?
B: I have mixed thoughts about the BASEINFO
C: generic issue #115, baseinfo is not a LIMU subobject? If its json, then it can go into the main json file, instead of having multiple files?

B: I have mixed thoughts about the BASEINFO
We don't need this for the review use-case but will need it for the "import" use-case.

The .objectdependencies.json file (BASEINFO) might be related to issue #131. Does anybody know, whether abapGit, as of today, uses the information stored in the .objectdependencies.json file?

abapGit, yes, it uses baseinfo today: https://github.com/abapGit/abapGit/blob/main/src/objects/zcl_abapgit_object_ddls.clas.abap#L236

Currently,

ADT uses .asddls
abapGit uses .asddls
vscode syntax highlighting uses .asddls, https://github.com/SAP-samples/vscode-abap-cds/blob/main/package.json#L21
github syntax highligting uses .asddls, https://github.com/github/linguist/pull/4614

C: its a generic issue, personally I'd like fewer files, everything will show up as changes anyhow

Currently,

ADT uses .asddls
abapGit uses .asddls
vscode syntax highlighting uses .asddls, https://github.com/SAP-samples/vscode-abap-cds/blob/main/package.json#L21
github syntax highligting uses .asddls, Add support for ABAP CDS github/linguist#4614

Let's look how ABAP classes do it. ADT uses .aclass but in this repo classes use .abap

abapGit, yes, it uses baseinfo today: https://github.com/abapGit/abapGit/blob/main/src/objects/zcl_abapgit_object_ddls.clas.abap#L236

Then, most probably, the baseinfo is not related to #131.

If possible, I personally would also prefer something like .cds or .ddls instead of .asddls.
In ADT the file extensions have to be unique per object type to open the correct editor. Therefore, we were not able to use just .abap, there.
@BeckerWdf Which file extensions would you use for access controls (DCLS), metadata extension (DDLX), and so on? Would it be the same as for DDLS or a different, because we need other syntax colouring, parsing etc...?

@BeckerWdf Which file extensions would you use for access controls (DCLS), metadata extension (DDLX), and so on? Would it be the same as for DDLS or a different, because we need other syntax colouring, parsing etc...?

Yes we need another parser but still the language is cds. We would  have:

.ddls.cds
.dcls.cds
.ddlx.cds

So we know if we need to utilise the ddls, dcls or ddlx parser. And there may be other cds parsers that can understand ddls, dcls and ddlx in one parser.

The .cds extension does look nicer, but note the impact on the ecosystem
https://cap.cloud.sap/docs/cds/ is the "Language Reference Documentation" for CDS? But is this the same CDS we are looking for?

If .cds files can have different languages, it can be difficult for syntax highlighters to implement. As of right now there are no "ABAP CDS" .cds files in the wild

So what would you prefer? .ddls or .ddls.ddls? First one would be different as the other object types have .. Second one looks a bit strange because  and  are identical.

I dont really have a good overview
Is ABAP flavored CDS a subset or superset of the other CDS?
But .acds could be an option, if its ABAP flavored CDS/ABAP specific CDS

Is ABAP flavored CDS a subset or superset of the other CDS?

Let's merge this PR and discuss this in https://github.com/SAP/abap-file-formats/issues/161

Formatting the (.objectdependencies.)json would increase the readability.
Let's merge this PR and work on this in #163


frozen funds calculation is wrong

could be only on the initial trade and additional traders are correct.

Frozen funds should be 2.5 * .31 = .775

verified this is no longer an issue. prob was an issue before b/c of kovan was on fake time. closing