Update the cli extension to fix a bug with the delete operation

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it mcr.microsoft.com/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/pabowers/azure-cli-extensions.git@pabowers/update-extension-version#subdirectory=src/$EXT&egg=$EXT"

baremetal-infrastructure


Ensure we don't keep changing artifacts in ivymap

This makes IvyThing.resolveArtifact return a boolean along the list of artifacts, saying whether that list can be cached or not. This is then taken into account before writing things to the cache.

First commit somehow adds to https://github.com/lihaoyi/Ammonite/pull/451. It makes resolution results aren't kept in the ivymap if they contain some snapshot artifacts..
Second commit should fix https://github.com/lihaoyi/Ammonite/issues/874. Resolution results aren't kept in ivymap if an interval appears in the initial dependencies.

Note there should still be corner cases when things that shouldn't be cached are nonetheless.
In the first case, if one loads a snapshot dependency that has no JARs and that depends on non-snapshot things, then no snapshot JAR will end up in the result, and this will be cached.
In the second case, if one depends on a fixed version of a dependency, but that dependency depends on some other dependencies with an interval, things are cached too.


12.2.8 - Cannot install Nova, missing required psutil version

Do NOT include any confidential information, this issue will be created on a public repo
This section is completed by the issue reporter
On which version(s) do you encounter this issue?
Please provide the output to 'git describe --all' for  all deployments where you have confirmed it occurs.
r12.2.8
root@605033-infra01:/opt/rpc-openstack# git describe --all
r12.2.8

What type of issue is this? Please tick the appropriate box.

[x] bug - existing functionality that does not work for you as documented
[ ] feature - new functionality that you would like to see added

What is the expected behavior?
For Nova and its dependencies to install correctly.
What is actually happening?
The required psutil version (psutil<2.0.0,>=1.1.1) isn't located in the built repo.
failed: [605033-infra01_nova_api_os_compute_container-f825d0b5] => (item=nova) => {"attempts": 5, "cmd": "/openstack/venvs/nova-12.2.8/bin/pip install nova", "failed": true, "item": "nova"}
msg: Task failed as maximum retries was encountered

FATAL: all hosts have already failed -- aborting

PLAY RECAP ********************************************************************
galera_client | Install pip packages ---------------------------------- 174.40s
os_nova | Install pip packages (venv) --------------------------------- 139.70s
Wait for container ssh ------------------------------------------------ 120.91s
galera_client | Add galera repo(s) ------------------------------------- 73.45s
pip_install | Install PIP ---------------------------------------------- 46.86s
galera_client | Install galera packages -------------------------------- 21.98s
os_cinder | Add in cinder devices types -------------------------------- 21.85s
os_nova | Install requires pip packages -------------------------------- 16.00s
os_nova | Unarchive pre-built venv ------------------------------------- 14.90s
os_keystone | Ensure Keystone user to Admin role ----------------------- 13.62s
           to retry, use: --limit @/var/lib/jenkins/setup-openstack.retry

605033-infra01_cinder_api_container-dda928c0 : ok=92   changed=46   unreachable=0    failed=0
605033-infra01_cinder_scheduler_container-e8443cb2 : ok=80   changed=36   unreachable=0    failed=0
605033-infra01_glance_container-75df29f2 : ok=86   changed=16   unreachable=0    failed=0
605033-infra01_keystone_container-8b3e99dd : ok=115  changed=12   unreachable=0    failed=0
605033-infra01_nova_api_metadata_container-4610902a : ok=51   changed=31   unreachable=0    failed=0
605033-infra01_nova_api_os_compute_container-f825d0b5 : ok=46   changed=26   unreachable=0    failed=1
605033-infra01_nova_cert_container-0f8f1778 : ok=51   changed=31   unreachable=0    failed=0
605033-infra01_nova_conductor_container-713d3b7d : ok=27   changed=16   unreachable=0    failed=1
605033-infra01_nova_console_container-215d0203 : ok=53   changed=33   unreachable=0    failed=0
605033-infra01_nova_scheduler_container-2c65aa90 : ok=51   changed=31   unreachable=0    failed=0
605034-infra02_cinder_api_container-f637a378 : ok=80   changed=36   unreachable=0    failed=0
605034-infra02_cinder_scheduler_container-bcfa9527 : ok=80   changed=37   unreachable=0    failed=0
605034-infra02_glance_container-1caecaf2 : ok=77   changed=15   unreachable=0    failed=0
605034-infra02_keystone_container-2946d809 : ok=98   changed=11   unreachable=0    failed=0
605034-infra02_nova_api_metadata_container-063ae26b : ok=51   changed=32   unreachable=0    failed=0
605034-infra02_nova_api_os_compute_container-8579ce9f : ok=46   changed=27   unreachable=0    failed=1
605034-infra02_nova_cert_container-0d1dbabc : ok=51   changed=32   unreachable=0    failed=0
605034-infra02_nova_conductor_container-2645bae8 : ok=46   changed=27   unreachable=0    failed=1
605034-infra02_nova_console_container-aaa566d7 : ok=51   changed=32   unreachable=0    failed=0
605034-infra02_nova_scheduler_container-431cc0e9 : ok=51   changed=32   unreachable=0    failed=0
605036-infra03_cinder_api_container-15fd4452 : ok=80   changed=36   unreachable=0    failed=0
605036-infra03_cinder_scheduler_container-a15d57ed : ok=80   changed=37   unreachable=0    failed=0
605036-infra03_glance_container-7fb17fc2 : ok=77   changed=15   unreachable=0    failed=0
605036-infra03_keystone_container-26cfc2af : ok=98   changed=11   unreachable=0    failed=0
605036-infra03_nova_api_metadata_container-a8c6ec54 : ok=51   changed=32   unreachable=0    failed=0
605036-infra03_nova_api_os_compute_container-a4fc7bba : ok=46   changed=27   unreachable=0    failed=1
605036-infra03_nova_cert_container-fb38e2ca : ok=51   changed=32   unreachable=0    failed=0
605036-infra03_nova_conductor_container-698a6bb5 : ok=46   changed=27   unreachable=0    failed=1
605036-infra03_nova_console_container-e0b7e840 : ok=51   changed=32   unreachable=0    failed=0
605036-infra03_nova_scheduler_container-993c75c2 : ok=51   changed=32   unreachable=0    failed=0
605037-compute01           : ok=44   changed=18   unreachable=0    failed=1
605038-compute02           : ok=44   changed=19   unreachable=0    failed=1
605039-compute03           : ok=44   changed=19   unreachable=0    failed=1
605040-storage01           : ok=85   changed=30   unreachable=0    failed=0
605041-storage02           : ok=85   changed=31   unreachable=0    failed=0
605042-storage03           : ok=85   changed=31   unreachable=0    failed=0

What were you attempting to do when you encountered this error (give as much detail as possible)?
Run the RPC-O deploy.sh script.
$ DEPLOY_TEMPEST=yes DEPLOY_CEPH=no DEPLOY_SWIFT=yes DEPLOY_MAAS=no DEPLOY_HARDENING=yes ANSIBLE_PARAMETERS=-vvvv FORKS=10 bash -c "./scripts/deploy.sh"

How can we reproduce this issue?
Run an installation of r12.2.8 on an LEM lab. Device 605033 is the deployment host in this environment.
How can we verify your issue is addressed?
Log into the lab and run the script for yourself.
If you are using or know of a workaround please describe the necessary steps?
N/A
What is your evaluation on the importance of this issue, and why?
Important for new Liberty installations. Most likely not an issue for new/current customers.

This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.
Which branches are impacted by this issue?
Remove branches that are not impacted.
For each pull request, update the branch line to reference it.

[ ] master
[ ] mitaka-13.1
[ ] liberty-12.2
[ ] kilo

Upgrade impact. Consider the impact on moving between major, minor and patch releases.

[ ] This change does not impact upgrades
[ ] This change addresses a potential upgrade impact
[ ] The upgrade impact is being tracked by another issue.

The issue tracking the upgrade impact is:
Testing impact

[ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below
[ ] This change includes additional testing
[ ] This change is tested by the existing setup

Additional testing links:
Release note

[ ] This change includes a release note.
[ ] This change does not require a release note.

Doc Impact
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[ ] No documentation required for this change

Additional documentation links (please add links if you have ticked yes):

@alextricity25 Something we should look into before we put a hold on revision releases. If we know support isn't consuming new revision releases, this may be a moot point.

I suspect this has something to do with the "cpu27mu" package introduced in rpc-repo:
http://rpc-repo.rackspace.com/pools/psutil/
It looks like that packages was added sometime today. By whom, I am unsure. We've had this problem in the past with libvirt-python and a patchset was submitted upstream to build it from source. Additionally, @major helped us with a temporary fix by removing the package with "cpu27mu".
I'll dig into this a little more tomorrow.

@jpmontez Are you sure this is a problem with psutil? The ansible failure you pasted in the description fails when trying to install the nova pip package:
failed: [605033-infra01_nova_api_os_compute_container-f825d0b5] => (item=nova) => {"attempts": 5, "cmd": "/openstack/venvs/nova-12.2.8/bin/pip install nova", "failed": true, "item": "nova"}
msg: Task failed as maximum retries was encountered

That leads me to believe that maybe your f5 hasn't built the virtual servers or pools for the repo server. Can you confirm connectivity to the repo server from the nova_api_os_compute container:
curl <internal-vip>:8181

root@605033-infra01_nova_api_os_compute_container-f825d0b5:~# curl -i <IP_ADDRESS>:8181
HTTP/1.1 200 OK
Server: nginx/1.4.6 (Ubuntu)
Date: Mon, 28 Nov 2016 16:44:15 GMT
Content-Type: text/html
Transfer-Encoding: chunked
Connection: keep-alive
Keep-Alive: timeout=15
Vary: Accept-Encoding
Expires: Mon, 28 Nov 2016 21:44:15 GMT
Cache-Control: max-age=18000
X-WHOAMI: OpenStack Private Slushee Repository 605033-infra01_repo_container-485a8c2e

<title>Index of /</title>

Index of /

../
links/                                             21-Nov-2016 21:44                   -
openstackgit/                                      21-Nov-2016 20:13                   -
os-releases/                                       23-Nov-2016 20:25                   -
pools/                                             21-Nov-2016 20:17                   -
python_packages/                                   21-Nov-2016 20:08                   -
reports/                                           21-Nov-2016 20:08                   -
venvs/                                             21-Nov-2016 20:19                   -

Hi Alex,
It's definitely reachable. I'm looking into this further at the moment.

Is this still an issue @weezer @jpmontez @mkam @alextricity25 ?

@cloudnull Doesn't look like it. Thanks for the checkup!


Strange narrowing behavior for types assigned to in while loop

TypeScript Version:  3.2.0+
Code
class AInfo {
	a_count:number = 1;
}
class BInfo {
	b_count:number = 1;
}

class Base {
	next:Base;
	id:number = 0;
}
class A extends Base {
	constructor(readonly info:AInfo) {
		super();
	}
}
class B extends Base {
	constructor(readonly info:BInfo) {
		super();
	}
}

let target:Base = ...;
while (target) {
	if (target instanceof A) {
		target.info.a_count = 3;
	} else if (target instanceof B) {
		target.info.b_count = 3;
	}
	target = target.next;
}

Expected behavior:
TS2551: Property 'b_count' does not exist on type 'AInfo'. Did you mean 'a_count'?
When code place in WHILE

Actual behavior:
no error

This looks to be an effect of #28112. The change in that PR isn't quite right, but having thought about it some more I think I have a better fix.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
12 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
17 seconds
inspect-image

✅ Succeeded
18 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
8 seconds
label-check

✅ Succeeded
8 seconds
optional-label-check

✅ Succeeded
7 seconds
show-summary


Migration plan limits

MTV 2.6
Resolves https://issues.redhat.com/browse/MTV-1341 by adding an admonition about plan size to the instructions for migrating vms by the UI and by the CLI.
Previews:

https://file.corp.redhat.com/rhoch/plan_limits/html-single/#creating-migration-plans-ui [Note labeled "Important"]
https://file.corp.redhat.com/rhoch/plan_limits/html-single/#migrating-virtual-machines-from-the-command-line_mtv [Second note labeled "Important"]

@anarnold97 Please review. If good, who else should review?


(Swift) left and right keywords and precedencegroup highligthing

Highlight.js highlights left and right as keywords. It's true that they have some special meaning (see https://docs.swift.org/swift-book/ReferenceManual/Declarations.html#grammar_precedence-group-declaration), however, they aren't reserved keywords, so 99% of the time, they will just be variables.
What is the policy regarding keywords? Should only reserved words be highlighted as keywords?

I don't know there is a strict policy. :-)  In this case it sounds like they should be removed from keywords or possibly a contextual rule highlighted (so they are only highlighted as keywords in that context).  This type of fancy highlighting might be too much though... so at this point I'd be happy if we simply removed them and then see if anyone pushes back.
It looks like we're missing quite a few of the precedencegroup keywords though.  Swift's own highlighting marks them as keywords.  It'd be nice if when we resolve this we could add them also.


How to handle updates of multiple values in the Admin-API

Currently, there are a few update routes in the Admin-API like changeProject which expect a JSON object in the body of a certain structure and allow to change more than one property at a time. I'm not very happy about how I implemented it. It is a bit obscure, in the sense, that it is not immediately apparent from just looking at the definition of the payload what is needed or what is going to happen. There is too much logic in the code.
For example, the changeProject route expects a ChangeProjectApiRequestADM payload in the body:
https://github.com/dasch-swiss/knora-api/blob/9b1bbe9349eb5cc1d247198d0b298d1853ae8617/webapi/src/main/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsMessagesADM.scala#L78-L84
The route needs to handle a few use-cases:

Only update some of the properties (hence all are optional)
Although all are optional, it could be the case that some are still required.
Allow deleting a property, i.e., an empty list, in the case of description, means delete what is there. Not sending the property means leave it be.

To entangle these cases, I would propose to generally add a route per property. Then it should be fairly clear, what a route does.
Staying with the example of the changeProject route, it would be broken down into seven routes:
PUT admin/projects/IRI/Shortname
PUT admin/projects/IRI/Longname
PUT admin/projects/IRI/Description
PUT admin/projects/IRI/Keywords
PUT admin/projects/IRI/Logo
PUT admin/projects/IRI/Status
PUT admin/projects/IRI/Selfjoin

The payload in the first route would be something like:
PAYLOAD: {"shortname": "thenewshortname"}

The capitalized property name is just a recommended convention that I read somewhere.
This would also simplify the client library since it would not need to replicate the somewhat obscure logic implemented in the Admin-API.
On the client-side (GUI), changes to a form where multiple values are allowed to be changed could then be serialized into several requests.
@benjamingeer @tobiasschweizer @flavens @kilchenmann Any suggestions or objections?

I think thats a good proposal which makes things a lot clearer! I would adapt it ASAP in knora-py..
Sent from my iPad
On 10 Nov 2019, at 12:50, Ivan Subotic<EMAIL_ADDRESS>wrote:

Currently, there are a few update routes in the Admin-API like changeProject which expect a JSON object in the body of a certain structure and allow to change more than one property at a time. I'm not very happy about how I implemented it. It is a bit obscure, in the sense, that it is not immediately apparent from just looking at the definition of the payload what is needed or what is going to happen. There is too much logic in the code.
For example, the changeProject route expects a ChangeProjectApiRequestADM payload in the body:
https://github.com/dasch-swiss/knora-api/blob/9b1bbe9349eb5cc1d247198d0b298d1853ae8617/webapi/src/main/scala/org/knora/webapi/messages/admin/responder/projectsmessages/ProjectsMessagesADM.scala#L78-L84
The route needs to handle a few use-cases:

Only update some of the properties (hence all are optional)
Although all are optional, it could be the case that some are still required.
Allow deleting a property, i.e., an empty list, in the case of description, means delete what is there. Not sending the property means leave it be.

To entangle these cases, I would propose to generally add a route per property. Then it should be fairly clear, what a route does.
Staying with the example of the changeProject route, it would be broken down into seven routes:
PUT admin/projects/IRI/Shortname
PUT admin/projects/IRI/Longname
PUT admin/projects/IRI/Description
PUT admin/projects/IRI/Keywords
PUT admin/projects/IRI/Logo
PUT admin/projects/IRI/Status
PUT admin/projects/IRI/Selfjoin
The payload in the first route would be something like:
PAYLOAD: {"shortname": "thenewshortname"}
The capitalized property name is just a recommended convention that I read somewhere.
This would also simplify the client library since it would not need to replicate the somewhat obscure logic implemented in the Admin-API.
On the client-side (GUI), changes to a form where multiple values are allowed to be changed could then be serialized into several requests.
@benjamingeerhttps://github.com/benjamingeer @tobiasschweizerhttps://github.com/tobiasschweizer @flavenshttps://github.com/flavens @kilchenmannhttps://github.com/kilchenmann Any suggestions or objections?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dasch-swiss/knora-api/issues/1510?email_source=notifications&email_token=ABJX3TA3AH66QVXL24NRXU3QS7YQNA5CNFSM4JLMBBW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYHSVAQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJX3THUFIYGHQPFL4NDTBLQS7YQNANCNFSM4JLMBBWQ.

Sounds good to me!

On the client-side (GUI), changes to a form where multiple values are allowed to be changed could then be serialized into several requests.

But then we have to know which values have changed. Should we do it by comparing the old with the new values before sending multiple requests?

Yes, we can change the existing project form, that a admin can change only one value at once. But it's not user-friendly... hm, yes it depends. I'll think about it.

@subotic Your proposal is good but what if the user wants to change multiple properties at once, like changing labels+comments+name of a list, or two of them? I would suggest giving all possibilities, that means:

a route to update the list with a payload where multiple optional properties are given.
separate routes to update properties individually as you suggested. For the lists, they would be

PUT admin/lists/<listIRI>/label which accepts payload that contains
{"labels": [{ "value": "a new label", "language": "en"}]}`

PUT admin/lists/<listIRI>/name

PUT admin/lists/<listIRI>/comment

Yes, this is the design proposed at the top of this issue, so I agree 😀

ok, know that I read your comment again, I don‘t agree with 1. because this is the problem which 2. should solve.

ok, know that I read your comment again, I don‘t agree with 1. because this causes problems which 2. attempts to solve.

the first option gives users the possibility to modify multiple properties at once. If we omit it and have only the second option, then for changing every property user would need to make a separate request. That seems cumbersome to me. If we have both options 1. and 2., depending on how many properties the user wants to change, she can choose the proper route.

There are instances where the first option simply does not work. I see that you are not convinced. Maybe we should have an online meeting about this?
I understand that it can be cumbersome to send multiple requests, but this could be solved by implementing a helper-function in DSP-JS-LIB or a helper function in the component that deals with this data.


Can't sign Electron 6

Hi there, I'm having an issue signing my app after upgrading to Electron 6.0.2.
I'm using:
electron 6.0.2
electron-packager 14.0.4
electron-osx-sign 0.4.12
⚠ Note 1: It's working with Electron 5.0.9.
⚠ Note 2: I have a special char in my App Name ê, see #155.
I'm getting an error message at the end of the process, here's the output
Mac: Signing app... {
    "app": "path/release/MyApp-mas-x64/MyApp.app",
    "platform": "mas",
    "hardenedRuntime": true,      <= tried with and without it
    "strict": false,              <= tried with and without it
    "binaries": [
        "path/release/MyApp-mas-x64/MyApp.app/Contents/Plugins/libwidevinecdm.dylib",
        "path/release/MyApp-mas-x64/MyApp.app/Contents/Plugins/PepperFlashPlayer.plugin",
        "path/release/MyApp-mas-x64/MyApp.app/Contents/Plugins/widevinecdmadapter.plugin",
        "path/release/MyApp-mas-x64/MyApp.app/Contents/Helpers/ffmpeg"
    ],
    "entitlements": "path/build/parent.plist",
    "entitlements-inherit": "path/build/child.plist",
    "provisioning-profile": "path/secrets/myappdev.provisionprofile",
    "identity": "** redacted **'",
    "type": "development"
}
ERROR:  Command failed: codesign --verify --deep --strict --verbose=2 path/release/MyApp-mas-x64/MyApp.app
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Library/LoginItems/MyApp Login Helper.app
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/MyApp Helper.app
--validated:path/release/MyApp-mas-x64/MyApp.app/Contents/Library/LoginItems/MyApp Login Helper.app
--validated:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/MyApp Helper.app
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/MyApp Helper (Plugin).app
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/MyApp Helper (GPU).app
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/MyApp Helper (Renderer).app
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Helpers/ffmpeg
--validated:path/release/MyApp-mas-x64/MyApp.app/Contents/Helpers/ffmpeg
--prepared:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
--validated:path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/Electron Framework.framework/Versions/Current/.
path/release/MyApp-mas-x64/MyApp.app: the sealed resource directory is invalid
In subcomponent: path/release/MyApp-mas-x64/MyApp.app/Contents/Frameworks/MyApp Helper (GPU).app

I'm not sure if I'm missing something or not, here's my signing code for reference if that can help:
const signApp = (pro) => (buildPath) => {
    const pluginsPath = path.join(appPath, './Contents/Plugins');
    const helpersPath = path.join(appPath, './Contents/Helpers');
    const signOpts = {
        app: appPath,
        platform,
        hardenedRuntime: true,      <= tried with and without it
        strict: false,              <= tried with and without it
        binaries: [
            path.join(pluginsPath, './libwidevinecdm.dylib'),
            path.join(pluginsPath, './PepperFlashPlayer.plugin'),
            path.join(pluginsPath, './widevinecdmadapter.plugin'),
            path.join(helpersPath, './ffmpeg')
        ]
    };

    if (platform === 'mas') {
        signOpts.entitlements = pro ? PARENT_PLIST_PATH : PARENT_LITE_PLIST_PATH;
        signOpts['entitlements-inherit'] = CHILD_PLIST_PATH;
    }

    if (platform === 'mas' && !dev) {
        signOpts['provisioning-profile'] = pro ? PROVISIONING_PROFILE : PROVISIONING_LITE_PROFILE;
        signOpts.identity = '** redacted **';
        signOpts.type = 'distribution';
    } else {
        signOpts['provisioning-profile'] = pro ? PROVISIONING_DEV_PROFILE : PROVISIONING_LITE_DEV_PROFILE;
        signOpts.identity = '** redacted **';
        signOpts.type = 'development';
    }

    const flatOpts = {
        app: appPath,
        identity: '** redacted **',
        platform,
        hardenedRuntime: true,
        strict: false,
        pkg: pkgPath
    };

    console.log('Mac: Signing app...', JSON.stringify(signOpts, ' ', 4));

    let signProm = sign.signAsync(signOpts);

    if (platform === 'mas' && !dev) {
        signProm = signProm.then(() => sign.flatAsync(flatOpts))
    }

    return signProm.then(() => {
        console.log('Mac: Signed app.');
        return buildPath;
    });
};

I hope I've given enough details.

Has anyone been able to sign an Electron 6 app?

Yes same problem for me

Working code signed Electron 6 demo here: https://github.com/electron/electron/issues/20405#issuecomment-540937081
Closing this issue for now. My guess it's due to the special chars in file name 🤔
To have special chars in the app name, it's probably better to localize the app names, instead of changing the actual name of the app bundle name. So the special chars won't be part of a file path.


System.IO.FileNotFoundException

Anything before the digits the slashes are not working ( both back and forward slashes )

@jmezach  Can i get some thoughts on this ?

the reference inside the sql file was forward slash instead of backward - got that corrected but :r reference fails with sql150

Please share a full repro project, NOT  screenshots.

I will probably close open a clean one


Prevent false sharing of jobs

Crossbeam's CachePadded struct seems good for this.

Jobs are packed into a 256-byte array, which is almost the same strategy as CachePadded.

I'd say this isn't fully solved yet -- to really do it I'd say we need to be able to specify custom alignment for types.

once #[repr(align = n)] is implemented, we can start doing this on nightly.


Loading widget...

Bumping up versions of package dependencies (except ipywidgets and ipyleaflet) is leading to a "Loading widget..." message hanging.
Following links could give some hints:
https://github.com/jupyterlite/jupyterlite/issues/872#issuecomment-1312736325
https://jupyterlite.readthedocs.io/en/latest/howto/configure/advanced/extensions.html#adding-custom-extensions

Not reproduceable


How to build this project?

When I try to complete a Gradle Sync in Android Studio, the sync fails with this error:
* Where:
Build file 'Jetpack-Compose-Tutorials\Tutorial1-1Basics\build.gradle.kts' line: 1

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.application', version: '8.5.2']
> Failed to apply plugin 'com.android.internal.version-check'.
   > Minimum supported Gradle version is 8.7. Current version is 8.5. If using the gradle wrapper, try editing the distributionUrl in Jetpack-Compose-Tutorials\gradle\wrapper\gradle-wrapper.properties to gradle-8.7-all.zip

I thought that changing the distributionUrl would fix the issue but there is no folder gradle\wrapper.
I am using the latest Android Studio version:
Android Studio Koala | 2024.1.1 Patch 2
Build #AI-241.18034.62.2411.12169540, built on August 1, 2024
Runtime version: 17.0.11+0--11852314 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

Please, give me some guidance on how to run the project.

You should replace 8.5.2 with 8.7 or newer version of gradle if you get that error.


I want to check WSI directly!!!

Hello author, can this deep-zoom-image-viewer be used to view WSI directly without converting WSI to DZI format?

Hi @linruicheng1997, I have been use OpenSeadragon viewer package for this. You can examine OpenSeadragon documentation in here. If I need to short reply for you, deep-zoom-image-viewer supports to following formats:
Legacy Image Pyramids
IIIF (International Image Interoperability Framework)
DZI (Deep Zoom Images)
OSM (Open Street Maps)
TMS (Tiled Map Service)
Zoomify
Custom Tile Sources
Simple Image
You can easily open without any converting process.


Bug on GIF files

Hello,
I found a strange behaviour when using GIF files with default media config.
I have:

<EMAIL_ADDRESS>default media config: GIF's type is 'animated'
a page (foo.lang.md) with a headers' key containing a GIF filename (bar.gif)
an alternative for this file (i.e. bar.gif &<EMAIL_ADDRESS>in the page folder) (I guess this is important to reproduce bug)
a twig template calling page.media to retrieve GIF's URL

I get:

Twig_Error_Runtime
An exception has been thrown during the rendering of a template ("Division by zero").

On the line calling page.media.
The line throwing 'Division by 0' is actually system/src/Grav/Common/Page/Media.php:144
The object used here does not have width and height because MediumFactory gives me a StaticImageMedium (system/src/Grav/Common/Page/Medium/MediumFactory.php:87). Everything is fine with 'image'.
Doc is cool but should dig deeper for this kind of stuff.
Hope this helps!

I'm pretty sure we are relegating all gifs to be animated as we can't tell animated from non animated. And then you are trying to do retina which is not support for animated types.  Does it work if you remove the @2x version?

I can confirm it's specifically the @2x and the fact that this image is not actually resizable.


Fix some broken links on the documentation

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update docs to fix some broken links

What is the current behavior? (You can also link to an open issue here)
Some documentation links are broken

What is the new behavior (if this is a feature change)?
All links work

Other information:
I found those broken links browsing the website

fair play for finding and fixing them!


Add Issue Templates

The new Issue Page currently makes it look like you're only interested in Api proposals and security vulnerabilities.  Yes there is a "Open a blank issue" option but it's a bit hidden

Is it worth adding at least Feature & Bug templates so the New Issue page is a bit more welcoming, e.g. aspnetcore

@maddymontaquila if I recall from a recent meeting you were interested in this area?


Added support for DROP INDEX, ADD UNIQUE INDEX, ALGORITHM and USING

Fix handles the following cases: 1) DROP INDEX 2) ADD UNIQUE INDEX 3) ALGORITHM 4) USING

ALTER TABLE biz_add_fee DROP INDEX operation_time, ADD UNIQUE INDEX operation_time (operation_time, warehouse_code, customerid, fees_type, external_no) USING BTREE, ALGORITHM = INPLACE

Fixes 586

Coverage increased (+0.2%) to 84.007% when pulling c4eb6e40d09d21143566202ebfbfdf4171143154 on PraTrick:586 into 4f74f6d110166a8d733832c994b47892d63e39a1 on JSQLParser:master.

Coverage increased (+0.2%) to 84.007% when pulling c4eb6e40d09d21143566202ebfbfdf4171143154 on PraTrick:586 into 4f74f6d110166a8d733832c994b47892d63e39a1 on JSQLParser:master.

Please integrate some tests using: the deparsers as well.

May be I've missed something here, but the support for Alter de-parser is rather weak AlterDeParser. Please let me know how to proceed henceforth.

You are right. Maybe it is something you want to implement. The deparsers and toString are two ways to get to the parsed sql, therefore it is a nice check.


Perform SHA-256 Hash for Certificate Signature Validation

Purpose
The PR [1] changed the default certificate hashing algorithm to SHA-256. This PR incorporates that change in to integration tests by performing SHA-256 hashing for certificate signature validation.
This should be merged after merging [1]
[1] https://github.com/wso2/carbon-apimgt/pull/12365

The default certificate hashing algorithm was kept as SHA-1 with [1] by reverting the change made to keep the default hashing algorithm as SHA-256. So, this change is not needed. Hence, closing the PR.
[1] https://github.com/wso2/carbon-apimgt/pull/12387


updated validators.py python script.

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Added


Reduce pylint complaints about Util

Fix up UniqueList - remves a Py2-era method and correct args on others;  add a __repr__ which also does uniquing.
Add "we know what we're doing" pylint comments on apparent redefinitions  of builtins and globals that the type tests and type converters do.
Add some more pylint comments on "local" (rather than top of file) imports.
Remove WindowsError reference (necessitated changing some tool code as well) - partial fix for #3939, WinodwsError is no longer distinct
Simplified semi-deepcopy stuff (and quieted complaints)

Add class docstrings and fixup some docstrings.
AddMethod examples had reversed arguments - now rendered as a doctest, and actually works.  Fixed up other examples to (mostly) be doctest as well.
Noticed some classes defined in Util don't have unit tests - left a note about this in UtilTests.py, but did not write the tests, that is left as a possible later exercise.
Signed-off-by: Mats Wichmann<EMAIL_ADDRESS>Contributor Checklist:

[ ] I have created a new test or updated the unit tests to cover the new/changed functionality.
[X] I have updated CHANGES.txt (and read the README.rst)
[X] I have updated the appropriate documentation

Ugh, sider complaints about things I didn't change, triggered because I moved them

Ugh, sider complaints about things I didn't change, triggered because I moved them

Merry christmas... ;)

I actually don't have huge moral objections to code that is lined up for readability using spaces, like the blocks in question:
    RegOpenKeyEx    = winreg.OpenKeyEx
    RegEnumKey      = winreg.EnumKey
    RegEnumValue    = winreg.EnumValue

Niether pyside nor black will tolerate this, though.  Sigh.

Thanks for this.
It must've been a slog, but it's much cleaner now.

I think I addressed all the outstanding comments and pushed.
I'll merge assuming CI runs ok.

I did have some other changes, just hadn't had a chance to push. Let me have a look tomorrow before merging.

dictify returns a dict, of course... (where did the comment vanish to?).  As noted in the comment, this function isn't used except by UtilTests.py.


Docs: error coming from google search results page

Page URL: https://www.typescriptlang.org/v2/en/tsconfig/
Issue:

The resource you are looking for has been removed, had its name changed, or is temporarily unavailable.

Browser: Firefox
Was the second result on this google search results page

Ah yeah, not much I can do there - those URLs are temporary. Thanks for the issue!
For now - https://www.typescriptlang.org//tsconfig/

I think you mean https://www.typescriptlang.org/tsconfig/ :)


appKey & appSecret should be changed to clientId & clientSecret

appKey & appSecret should be changed to clientId & clientSecret
Because we want to reduce confusion. developer.ringcentral.com uses clientId & clientSecret.

PR is welcome

Don't forget about backward compatibility


Fix XAER_RMFAIL error on transaction rollback

Purpose
Handle proper signaling of transaction completion to XA Resources when aborting a transaction as invoking xa_rollback() without signaling the end of the transaction's work triggers an XAER_RMFAIL: The command cannot be executed when the global transaction is in the ACTIVE state error.
Fixes #41948
Approach
Added the boolean flag abortOnly to track the transaction's abort status within the endXATransaction() method. This flag indicates whether the transaction is set for abort or not, providing clarity on the success or failure of work within the transaction context. If the transaction is in the process of aborting, the xa_end() method is invoked on the XA Resource using the TMFAIL flag. This flag indicates the failure of a portion of work within the transaction, effectively marking the transaction as rollback-only. However, in cases where the transaction is proceeding normally without an abort condition, the TMSUCCESS flag is used as per normal operation.
Modified the transaction handling sequence by introducing a call to endXATransaction before invoking notifyAbort. This change guarantees explicit signaling of the transaction's completion before initiating the rollback phase. It prevents XAER_RMFAIL error during xa_rollback() on the XA Resource.
Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add Quantumblockchains provider

@wkande We've also integrated a new chain (Lightlink and Lightlink Goerli) which isn't in the @api3/chains repo yet but will be added soon

@wkande I'll be merging this and opening and merging a PR for live site because we need this for a workshop soon. If there is an issue we can revert

@Ashar2shahid I'm late to the game but it LGTM.


Request for code for report 9

This code is for report 13 and appears to be different to the code used to generate the famous Report 9, from the 16th March:
https://www.imperial.ac.uk/media/imperial-college/medicine/sph/ide/gida-fellowships/Imperial-College-COVID19-NPI-modelling-16-03-2020.pdf
This codebase is written mostly in R, but in tweets Prof Neil Ferguson claimed that the code used for this report was "thousands of lines of C". There's no C anywhere in this codebase.
I think what people would most appreciate seeing is the model that drove the UK's sudden change of tactics, which this one doesn't appear to be. Can you please publish Prof Ferguson's original code as well?

Hi @mikehearn, we clearly state this code base is for Report 13 not Report 9.  Neil is getting his code ready to be used by others, please talk to him about this.


fix cuda graphs for qwen2-vl

The PR: adds support for multidimensional position ids on batch to enable cuda graphs on qwen2-vl. This PR is a fast followup to the original support of qwen2-vl: https://github.com/huggingface/text-generation-inference/pull/2689

thank you again @sywangyi for providing the changes that fix the lm_head_indices and output the correct logits 🙏
ref: fix qwen2 failure in intel cpu


Performance Testing for ChatBot response for utterences

In Botium can you provide us on whether chatbot utterances and bot responses performances can be verified for its stability and reports.
Thanks
Vijay

We are currently working on providing Performance testing with Botium - I assume by "performance" you mean stress and load testing.

Yes i meant Stress and Load testing and also we need another feature -
SMTP  mail  to send auto-generated machawesme reports to particular emails
we wish.
Thanks and Regards,
Vijaysimha.N
On Wed, Apr 3, 2019 at 2:57 PM Botium<EMAIL_ADDRESS>wrote:

We are currently working on providing Performance testing with Botium - I
assume by "performance" you mean stress and load testing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codeforequity-at/botium-core/issues/260#issuecomment-479412290,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Acyz4XLj04UtVDLIj4579nxZoCeHXkUMks5vdHP9gaJpZM4cZs8A
.

So, stress and load testing is one of the features we are actually working on (see our Roadmap).
Regarding the email notifications, we think that this is out of scope for a tool like Botium, and there are way better tools to automate sending of email notifications, which can be combined with Botium. Nevertheless, I will discuss this with my team, as we heard this request several times now.

Performance test feature is ready: https://botium.atlassian.net/wiki/spaces/BOTIUM/pages/32145428/Performance+test


First stab at README

Description
Start README as a pretty entry point to the world of GIL :)
Tasklist

[ ] Update AppVeyor badges (@stefanseefeld you are the only one who can dig the URLs out)
[ ] Add badge to https://gitter.im/boostorg/gil[![Gitter](https://badges.gitter.im/boostorg/gil.svg)](https://gitter.im/boostorg/gil?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)

[ ] Adjust for comments

Excellent ! If either of you feel creative, perhaps you want to come up with a nice logo ? (I was trying a "pixelated" variant of the Boost logo, but eventually gave up.) :-)

@stefanseefeld  Logo would be nice. I'm terrible art designer :)
Could you help me with the AppVeyor badge?

Sure.
For master use
and for develop use

@stefanseefeld Apparently, when markdown is pasted without wrapping as code block, GitHub automatically converts the markdown'ed links to GitHub-hosted or mangled links like this: https://camo.githubusercontent.com/f2d8c8b89edccef824869ec8c1d6461ee3ae7c8a/68747470733a2f2f63692e6170707665796f722e636f6d2f6170692f70726f6a656374732f7374617475732f77346b31396438696f326166313638683f7376673d74727565 which are useless for README/docs, etc.
Luckily, I can edit your comment and retrieve the original markdown:
[![Build status](https://ci.appveyor.com/api/projects/status/w4k19d8io2af168h?svg=true)](https://ci.appveyor.com/project/stefanseefeld/gil)

[![Build status](https://ci.appveyor.com/api/projects/status/w4k19d8io2af168h/branch/develop?svg=true)](https://ci.appveyor.com/project/stefanseefeld/gil/branch/develop)

Just ha**ed GitHub! ;-)

I feel with you ! :-)


Issue 719 exception message

Added option to control composition of WebRequestException message.
Suggest merging with squash.

Thanks for the PR. Reviewing it.


Version 0.5 fails to build:  fatal error: 'ir/Expr.h' file not found, etc

/usr/ports/math/tvm/work/tvm-0.5/include/tvm/ir.h:9:10: fatal error: 'ir/Expr.h' file not found
#include <ir/Expr.h>
         ^~~~~~~~~~~
/usr/ports/math/tvm/work/tvm-0.5/include/tvm/expr.h:9:10: fatal error: 'ir/Expr.h' file not found
#include <ir/Expr.h>
         ^~~~~~~~~~~
#include <tvm/node/node.h>
         ^~~~~~~~~~~~~~~~~

FreeBSD 12 amd64

If 0.5 is an older version, and 0.4+ is the newer version - you should just release the latest code under the next version number.

This was likely due to missing submodules. You can clone the tag and do git submodule update --init --recursive to solve the problem
For followup trouble shooting related topics, please open new thread on https://discuss.tvm.ai/ :)

No, submodules are present.

Please confirm that, as these files are included via:
https://github.com/dmlc/tvm/blob/v0.5/CMakeLists.txt#L213
in the 3rdparty/HalideIR submodule , see https://github.com/dmlc/tvm/tree/v0.5/3rdparty


Windshaft-carto-vl docker image is broken

Context
We're using a custom windshaft docker image for the CARTO VL e2e tests. Due to some last changes, we've had to add a little modification when setting the express router, as we can see in this PR https://github.com/CartoDB/carto-vl/pull/1403
We need to update the docker image properly to fit the last changes.

Docker configuration:  /test/acceptance/docker
Developers guide about e2e tests
Example of a failing build in Circle CLI

Although I've been able to rebuild the docker images and fix some errors, I'm still having issues when configuring the database. I'm removing the rt-frontend label for now, we need help from backend team to fix this issue cc @VictorVelarde @alrocar

I don't know much about that Docker image, how can we reproduce the issue/where's the Dockerfile?

The only documentation I've found about how to build the images is in the DEVELOPERS guide, the way to reproduce it is to run the e2e tests (which are the ones that are failing in CI). The Dockerfile and the docker configuration is in the /test/acceptance/docker directory in CARTO VL.

The PR is back to 🍏
Assigning back to @elenatorro for acceptance.

Merged 🚀


Position: floating

Sometimes we don't want to position the dialog over an element, or perhaps the element is too large.  In these cases position: floating would be useful.  This might also be a good default if the target is undefined or missing.

I am pretty sure when an element is too large, the tour box will move inside of the element to the prioritized placement options.  As for no element, that would be an easy addition, to just have it centered on the screen.

Centered on screen is what I would expect from placement: floating.  Here is what it looks like with a big element:

What about a full screen element?
On Sat, Jul 2, 2016 at 12:17 AM Jayson Harshbarger<EMAIL_ADDRESS>wrote:

Centered on screen is what I would expect from placement: floating. Here
is what it looks like with a big element:
[image: screen shot 2016-07-02 at 3 15 58 pm]
https://cloud.githubusercontent.com/assets/509946/16538736/1b992162-4068-11e6-8a11-ad2193d2536d.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tourjs/tour/issues/7#issuecomment-230086443, or mute
the thread
https://github.com/notifications/unsubscribe/AFUmCbYwaZ9pVfqa3vOmuOUnX1mBQe5nks5qRgKJgaJpZM4JDmcE
.

Ss for that screenshot, it should fit exactly in the open space. It looks
like the margins are not being taken into account. We should log out the
max height and the actual target height plus margin
On Sat, Jul 2, 2016 at 12:20 AM Tanner Linsley<EMAIL_ADDRESS>wrote:

What about a full screen element?
On Sat, Jul 2, 2016 at 12:17 AM Jayson Harshbarger <
<EMAIL_ADDRESS>wrote:

Centered on screen is what I would expect from placement: floating. Here
is what it looks like with a big element:
[image: screen shot 2016-07-02 at 3 15 58 pm]
https://cloud.githubusercontent.com/assets/509946/16538736/1b992162-4068-11e6-8a11-ad2193d2536d.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tourjs/tour/issues/7#issuecomment-230086443, or mute
the thread
https://github.com/notifications/unsubscribe/AFUmCbYwaZ9pVfqa3vOmuOUnX1mBQe5nks5qRgKJgaJpZM4JDmcE
.


Can not download signature from MISP

i try download with URL : MISP_URL + "attributes/text/download/zeek" , i got a empty file . How to enable this . Help me!!

You'll need to have signatures in MISP tagged as the zeek type.


Move chai-as-promised to devDependencies

What about publishing this change as 2.4.1?

Done! 2.4.1


Fix regexp & boolean test

Line 38 : the regex cannot match lines with some extra commands & args for the inetd entry
Line 39 : obviously, a correct line starting with a # is disabled, so (# == # ) => true which should be false.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@vfoucault

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

Saw a few other issues.
I will try to fix them and the i will submit a new pull request.


[MINOR] Fix minor issues in HoodieMetadataTableValidator docs

Change Logs
This PR fixex minor issues in HoodieMetadataTableValidator docs.
Impact
Only Javadocs update.
Risk level
none
Documentation Update
N/A
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI failure is irrelevant.  This PR only updates javadocs.


Common class names cause naming collisions

The used Godot version:

3.5 stable.
Describe the bug

gdUnit3 classes with common class_names cause naming collisions with users' code.
Loading GdUnit3 Plugin success
 res://src/Fonts.gd:1 - Parse Error: Unique global class "Fonts" already exists at path: res://addons/gdUnit3/src/ui/Fonts.gd

Steps to Reproduce

Create a script with class_name Fonts.
Install gdUnit3.

I suggest prepending GdUnit to all class names to avoid collisions. Many classes have this prefix already.

Thanks for reporting,
I have to change it to GdUnitFont.gd to prevent class name conflicts.


DRAFT: potential explanation for segfault & PoC fix

Hypothesis
the issue seems to be that there is a race condition between exqlite_close and exqlite_prepare. The issue happens when we execute sqlite3_prepare_v3 on a connection after we close the connection with sqlite3_close_v2.
sqlite3_close_v2 does handle previously prepared statements, but here we are preparing the statement in-parallel while we are closing the connection. Which is causing occasional SQLITE_MISUSE.
How can we reach this state?
Given

exqlite_close is executed by connection process
while handle_prepare and other callbacks are called in the client process
a NIF call can not be interrupted/cancelled once started, irrespective of client side process timeout, or process kill.

Scenario

client checkout a connection and makes a query
client makes exqlite_prepare NIF call but fail to complete within connection timeout duration. It 1ms in the test case. This NIF call is still running or scheduled to run even after the timeout.
due to connection timeout, connection-process receives timeout and initiate connection close (disconnect callback)
connection-process calls exqlite_close NIF

2 & 4 are run in-parallel leading to race-condition mentioned previously causing segfault.
Fix
I tried to fix the race-condition using mutex, and sofar haven't seen a single failure.
This is PoC, I guess we should handle multiple other cases as well, not just the one between close & prepare if this is the issue.
Should fix https://github.com/elixir-sqlite/exqlite/issues/190

@akash-akya can you point the branch at main and cherry-pick in the test I made? I'd rather you take the credit for solving this.
Also thanks for fixing the CI goof up.

Hey @warmwaffles, made changes as suggested.
Disabling the segfault test by default since it is very slow. Let me know if you want to enable it.
Also, I am not sure if this is the right approach to solve the issue. Since we to properly fix it I think we have to wrap every callback inside mutex not just prepare.
How about this? When connection timeout, we just roll back the trx, but we don't close the connection at that point of time.
Since a timed out connection will be eventually garbage collected and since at-max there can only be one parallel command, we can just let connection_type_destructor function close the connection at the end after the parallel command finishes. That way we don't need any mutex & wrapping, wdys?

Disabling the segfault test by default since it is very slow. Let me know if you want to enable it.

Let's leave it disabled. I'll move it to a regression / integration level.

Alternatively, how about this? When connection timeout, we just roll back the trx, but we don't close the connection at that point in time.

That seems like a good solution versus the mutex manipulations. But what I fear is that you can still segfault this manually using Exqlite directly. Is that okay if it segfaults if the library is used incorrectly?

Can you put a couple flags in the connection, something like in_use and marked_for_closure. If not in use then the timeout closes the connection. If in use then set marked_for_closure to true and the command will close the connection after it's done.

Yes, it won't fix those use cases. Imo it is okay to just warn the user and leave it at that.
Just curious, is there a case where one would want to make raw calls concurrently using a single connection? AFAIK db_connection is already lightweight from process footprint point of view.
Also, It's very hard to cover all such cases right? for example, parallel sqlite3_close_v2 calls on the same connection. Currently we are not handling that I think even with mutex.

@greg-rychlewski are you suggesting that on the elixir side or the NIF side?
On the NIF side, we'd have to use a mutex to ensure that a connection isn't double closed.

Just curious, is there a case where one would want to make raw calls concurrently using a single connection? AFAIK db_connection is already lightweight from process footprint point of view.

I think someone who wants to skip using db_connection should be able to. But how realistic is it that someone would use the raw Exqlite.Sqlite interface outside of ecto? Probably low.

Also, It's very hard to cover all such cases right? for example, parallel sqlite3_close_v2 calls on the same connection. Currently we are not handling that I think even with mutex.

Definitely hard to cover, but a mutex is probably the right solution to always check before calling sqlite3_close_v2
@akash-akya another thing is, could that mutex checking be adding enough latency to not surface the race condition? When I was throwing fprintf debug statements in, it slowed the calls down enough to make the issue not present itself.

Yes, adding a delay in concurrent calls can make it hard to reach the exact race condition. I tried adding sleep before prepare and sure enough, it prevents the issue.
The question now is if mutex is truly fixing the issue or just hiding the race condition because of latency it is adding right? I think if we can reliably prove the exact race condition sequence, then we can be sure about the fix.
Can you share your changes with fprintf? Since where we are placing it does matter

@akash-akya I shimmed it in as the first call in exqlite_close and one on exqlite_open.

Trying to reproduce the issue deterministically for a single connection. But it is hard to get the order of thread execution correctly without any additional tooling.
Fortunately, since SQLite source code itself is embedded, we can just add sleep in-between execution of prepare & close, and get the deterministic order we want.

branch with the deterministic test: https://github.com/akash-akya/exqlite/tree/deterministic-segfault
branch with the deterministic test and fix: https://github.com/akash-akya/exqlite/tree/deterministic-segfault-with-fix

As we can see, the fix does fixes the segfault in the test, and adding fprintf does not fix the above segfault.
Of course, among the set of all possible code path that can cause segfault, this is just one, there might be more.

Yes, sounds good to me.
Let me know if any more changes are pending for this to get merged.

Released under v0.11.7, thanks a ton @akash-akya


#540, #541, #542 csv importer error handling updates

This PR resolves #540 , #541 & #542 :
I started working on #542 and realized that a general solution would be beneficial for Places, Speakers and Stories - I used a helper to do this.
I've added a custom partial for the Administrate gems'  flash messages so that we can handle the errors and show them line by line. Flash messages can be added as a string as well as a hash which will be printed out as shown below:

The only issue I came across is that there are no validations for the speaker models and therefore a blank speaker can be imported. I've still added the code and the tests but I've left them pending for now. I tested that it works by adding a :validates speaker_name to rails/app/models/speaker.rb
Hopefully its fine that I've done all three issues, if not, please let me know 😄

@tauhir looks like we have some merge conflicts! we can accept once those are fixed. sorry for the delay in review1

I had to update the admin places, speaker and story controllers with the csv logic I added in this branch because the base controllers were deleted in #560.


How to repro screenshots?

I'm new to neo4j how do I get that screenshot example?
$ npm run server # works
$ npm start # does nothing (but export the module)
$ npm test # test passes

I've been hunting for more services like this if you have any similar projects to share, I would greatly appreciate the info.
Happy to answer any questions about Intent Recognizers / Entity Extraction with  MS Bot Service, API.AI

Hey, this is only the server and backend implementation. To actually query it you need the interface AIVA. Setup should be quick given the binary u can use, see here. The fastest way by far is Slack or Telegram - just get bot token from them.
Quite some people have had successes getting those to work, plus what's shown in the screenshot. Some debugging info we went through can be found in that repo's Issues section.
Not sure if you found this repo from an article, but here's it with the full tutorial.

thanks! This is super helpful.


[ Bug ] Client seeing the wrong screen on swipe confirmation payment.

Possible solutions

[ ] Event filters.
[ ] Navigation refactoring.
[ ] Missing screen.


Report Reserving queue metrics and  stats.

What type of PR is this?
/kind feature

What this PR does / why we need it:
Change the way localQueues and clusterQueues stats and mertics are reported to account for the difference between Reserving and Admitted workloads.
Which issue(s) this PR fixes:

Fixes #1195
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Report Reserving queue metrics and  stats.

/lgtm
/approve

/hold

/lgtm cancel

/unhold


add g:rufo_silence_errors option

Hi!
I quickly added an option to not show the error buffer if an error occurs while running rufo.
But ... why?
I have set rufo autoformatting to 1 so it formats the current file once I :w it.
In case of broken/incomplete ruby files the rufo error buffer is way to large for my taste and really doesn't help since I use the Ale linter to check for errors.
Thanks you for this vim integration!
Cheers!

(Not to scale 😄 )

@thenoseman thank you!


Disable color-scheme on iframe

When an iframe has transparency, having a dark color-scheme value causes it to render with a white background. This causes text to be invisible if the iframe is respecting dark mode and adapting to it.
One very easy to check example is disqus.
Description

Motivation & Context

Type of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (non-breaking change)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[ ] My change introduces changes to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

Live previews

https://deploy-preview-{your_pr_number}--twbs-bootstrap.netlify.app/

Related issues

Have a demo?


PR: fix not decorated slots connected to 'triggered' and 'clicked' signals

Cause 'QAction::triggered' and 'QAbstractButton::clicked' signals has default parameter 'checked=False' all slot-function without decorator '@Slot()'  (e.g. lambdas) should have first parameter 'checked'.
But PySide always passes no arguments to these slots in spite of signals definiton, therefore first parameter of slots should have default value.
Fixes #2900

this will fix issue #2900

Thanks for your contribution and sorry for the delay in coming back to you.
Please change all lines in configdialog that appear as
if API == 'pyqt':

to look like
if not API == 'pyside':

so that your changes apply to both PyQt4 and PyQt5.

Done, @ccordoba12 !
Also, I have done the same checks for API in other files that I had changed before.

Everything seems right. Thanks for your contribution!


NEXT-00000 - Fix action selection in flow builder

1. Why is this change necessary?
If a trigger is aware of more than one entity, then the custom field action might not be displayed properly in the administration. By selecting the Change custom field content action and selecting the order entity, the Flow Builder displays an unknown action, even though the action shouldn't be unknown.
2. What does this change do, exactly?
It removes an unnecessary filter and adds a preselected entity selection in the corresponding modals. Moreover, it restructures the grouping of the actions that can be selected, as the filter is removed.
Before

After

3. Describe each step to reproduce the issue or behaviour.

Create a new flow
Add Checkout / Order / Placed trigger
Add a new THEN action
Select “Change custom field content” and select the order entity
Select any custom field
Add action

4. Please link to the relevant issues (if any).
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[x] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

@Ceddy610 would you mind creating a fixing PR again? :see_no_evil:

@Ceddy610 would you mind creating a fixing PR again? 🙈

@mitelg I opened another PR here


Update README.md

added WallpaperChanger to supported 3rd party apps (supported version still in staged rollout though)

#1


Fix - Bump @types/node from 16.7.5 to 17.0.8

Fix the issues when updating to v17.0.8.
Issue:
URLSearchParams arguments can't be type | undefined
helpers/discordAuth.ts(65,31): error TS2345: Argument of type '{ grant_type: string; client_id: string | undefined; client_secret: string | undefined; code: string; redirect_uri: string | undefined; scope: string; }' is not assignable to parameter of type 'string | URLSearchParams | Record<string, string | readonly string[]> | Iterable<[string, string]> | readonly [string, string][] | undefined'.

The types being used should correspond to the library being used, or the node engine in case of @types/node. We are using 14 on vercel I don't think we need to update types to node 17

The types being used should correspond to the library being used, or the node engine in case of @types/node. We are using 14 on vercel I don't think we need to update types to node 17

I just did some research and what you said makes sense.
According to what you said, we should let the library handle updating node types?

we could upgrade node to v17: https://vercel.com/docs/runtimes#official-runtimes/node-js/node-js-version

Actually just checked, vercel only supports v14.
good catch @JasirZaeem ! Thanks.
Updated our docs so we know about this in the future: https://github.com/garageScript/c0d3-app/wiki/Dependabot#notes
I vote to close this.

Closed it as NextJS only supports node v14.


Model file not found

It is unable to find the "model_final_f10217.pkl" file
process[detectron2_ros-1]: started with pid [14640]
[WARN] [1632167722.433477]: Initializing
[INFO] [1632167722.442250]: [Detectron2] ~config: /home/vikas/detectron_ros/src/detectron2_ros/detectron2/configs/COCO-InstanceSegmentation/mask_rcnn_R_50_FPN_3x.yaml
[INFO] [1632167722.470800]: [Detectron2] ~detection_threshold: 0.5
[INFO] [1632167722.473040]: [Detectron2] ~model: detectron2://COCO-InstanceSegmentation/mask_rcnn_R_50_FPN_3x/137849600/model_final_f10217.pkl
Traceback (most recent call last):
  File "/home/vikas/detectron_ros/src/detectron2_ros/src/detectron2_ros", line 158, in <module>
    main(sys.argv)
  File "/home/vikas/detectron_ros/src/detectron2_ros/src/detectron2_ros", line 154, in main
    node = Detectron2node()
  File "/home/vikas/detectron_ros/src/detectron2_ros/src/detectron2_ros", line 34, in __init__
    self.predictor = DefaultPredictor(self.cfg)
  File "/home/vikas/.virtualenvs/detectron2_ros/lib/python3.8/site-packages/detectron2/engine/defaults.py", line 188, in __init__
    checkpointer.load(cfg.MODEL.WEIGHTS)
  File "/home/vikas/.virtualenvs/detectron2_ros/lib/python3.8/site-packages/fvcore/common/checkpoint.py", line 141, in load
    assert os.path.isfile(path), "Checkpoint {} not found!".format(path)
AssertionError: Checkpoint detectron2://COCO-InstanceSegmentation/mask_rcnn_R_50_FPN_3x/137849600/model_final_f10217.pkl not found!
[detectron2_ros-1] process has died [pid 14640, exit code 1, cmd /home/vikas/detectron_ros/src/detectron2_ros/src/detectron2_ros __name:=detectron2_ros __log:=/home/vikas/.ros/log/a2aa41ea-1a4c-11ec-8c3f-2d667ddb57ab/detectron2_ros-1.log].
log file: /home/vikas/.ros/log/a2aa41ea-1a4c-11ec-8c3f-2d667ddb57ab/detectron2_ros-1*.log
all processes on machine have died, roslaunch will exit
shutting down processing monitor...
... shutting down processing monitor complete
done

This is because you are not running it inside the environment properly, since it is using python 3.8. This port is intended to be used in ROS with python2. Please follow the instructions for use.

Which version uses python 3.6 or 3.8? Not sure how to use python3 and python2 at the same time, can you help me?
My workon environment is python 3.6, ros python 2.7

Hello, you can download the model "model_final_f10217.pkl" from here. Then, drag it into the folder where the code expects to find the model.

thanks for your answer


Changed include path

Fixed file inclusion path to avoid to modify the php server include_path setting (multiple commits are just a github wrong usage ...)

Given the bad state of this pull request, I think it should be closed.


Add model label to Playground

What this PR does / why we need it
Add model name label to Playground as Service.
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

NONE

/kind cleanup
/lgtm
/approve

/lgtm


Load-balance cross cluster should support local clusters

Currently for a federation cluster, we need to depend on Google Cloud DNS or AWS Route 53 for cross cluster service load balance, but many customers may not deploy the k8s cluster on those clouds.
The federation cluster should provide a solution which can enable me do service load balance cross different clusters which is not running on Google Cloud or AWS.
/cc @quinton-hoole comments for this? Thanks!

/kind feature

Referencing another issue that was closed in favor of this one: https://github.com/kubernetes/kubernetes/issues/58974

Also, when adding the label priority/important-longterm, how far out in the future do you expect it to implement this?

Also looks like haproxy added support for service discovery https://www.haproxy.com/blog/dns-service-discovery-haproxy/

There is a keepalived cloud provider can also provide loadbalancer type for services https://github.com/munnerz/keepalived-cloud-provider

@gyliu513 thanks, and does k8s support multiple cloud providers? The keepalived-cloud-provider docs say I should use --cloud-provider=external, but I have it set to --cloud-provider=openstack for provisioning volumes

Not sure about this, perhaps you can ask in dev list for help @bputt

I have a keepalived chart for loadbalancer at https://github.com/gyliu513/work/tree/master/k8s/charts/keepalived


API not working

Hello, I'm using the module to try to configure a Zabbix Server, a Zabbix Agent and import templates.
The first two things are done! I can correctly install the Zabbix Server and the Zabbix Agent.
I put the manage_resources in the zabbix server declaration, but the Zabbix Agent is not going to the zabbix UI.
Also, I cannot import templates, as they don't appear in the UI also.
As I'm a (really) newbie in puppet, I'm almos sure I'm doing something wrong. Can you help me? Bellow is my site.pp file contents. Let me know if I should put some other info.
Ps. I'm using Ubuntu 14.04 for both server and client, and puppet 3.8.2 on both.
node 'zbxserver.powers.com.br' {
class { 'apache':
mpm_module => 'prefork',
}
include apache::mod::php
#lass { 'postgresql::server': }
class { 'mysql::server': }
class { 'zabbix':
zabbix_url    => 'zabbix.zbxserver.powers.com.br',
database_type => 'mysql',
manage_resources => true,
zabbix_api_user => 'Admin',
zabbix_api_pass => 'zabbix',
}
zabbix::template { '.BS. Firewall - Fortinet':
templ_source => 'puppet:///modules/zasdasdabbix/fn.xmdasdasl',
}
}
node 'zbxagent.powers.com.br' {
class { 'zabbix::agent':
server => 'zbxserver.powers.com.br',
}
}

HI andreguihon,
Thank you for making time to create this issue.
You also have to specify the agent to manage_resources, like this:
node 'zbxagent.powers.com.br' {
  class { 'zabbix::agent':
    server          => 'zbxserver.powers.com.br',
    manage_resource => true,
  }
}

Kind regards,
Werner

Thank you for your reply dj-wasabi!
I put the manage_resource => true in the node configuration. Ran the puppet agent -t in the node, in the server, both applied successfully, but the node still doesn't show in the hosts list.
Also, the template I'm trying to import doesn't import, wich makes me think that I'm missing some configuration in the API part. Is it supposed to work out of the box? Do I need to configure something?

No, it should work with setting the manage_resources parameter to true on both the agent and server.
Which version of the module are you using?

How can I know that? I installed using puppet module install...

Not a clue on what I'm missing here?

When adding the parameter manage_resource => true, you did execute an puppet run on the agent and server? You have an correct DNS entry for 'zabbix.zbxserver.powers.com.br' ? Does the puppet run show any errors/messages?
I can't replicate your problem. I have some Ubuntu 14.04 hosts with puppet 3.8.2 with the same wdijkerman-zabbix version (1.5.0) and it all works.

When adding the parameter manage_resource => true, you did execute an puppet run on the agent and server?
YES! Several times!
You have an correct DNS entry for 'zabbix.zbxserver.powers.com.br' ?
I have an entry in the /etc/hosts. This should do the trick, correct? (in both server and agent)
Does the puppet run show any errors/messages?
NO!

Ok, as you said you have same environment as me and yours works, I rolled back the VM, installed Ubuntu again, on both server and agent and... Nothing, same problem! :(
This time I wrote down all the steps, so you can see if I'm missing something:
ON SERVER:
wget http://apt.puppetlabs.com/puppetlabs-release-precise.deb
dpkg -i puppetlabs-release-precise.deb
apt-get update
apt-get install puppetmaster
apt-get install build-essential
apt-get install ruby-dev
edit /etc/hosts put all the names needed in it (My DNS server already knows the main names, added only zabbix.zbxagent.powers.com.br)
edit /etc/puppet/puppet.conf and put the server=zbxserver.powers.com.br and environmentpath=$confdir/environments
mkdir -p /etc/puppet/environments/production/manifests
created site.pp in /etc/puppet/environments/production/manifests
gem install bundler
gem install zabbixapi
puppet module install wdijkerman/zabbix
/etc/init.d/puppetmaster restart Just to be sure
puppet agent -t --debug > /tmp/puppet.log
ON AGENT SIDE
vim /etc/hosts (put the zabbix.zbxserver.powers.com.br - just to be sure)
wget http://apt.puppetlabs.com/puppetlabs-release-precise.deb
dpkg -i puppetlabs-release-precise.deb
apt-get update
apt-get install puppet
vim /etc/puppet/puppet.conf => server=zbxserver.powers.com.br
puppet agent -t --debug > /tmp/puppet.log
(on server)puppet cert sign zbxagent.powers.com.br
puppet agent -t --debug > /tmp/puppet.log (2 times, to be sure)
(on server)puppet agent -t --debug > /tmp/puppet.log (2 times, to be sure)
Checked the FrontEnd and the agent is not there yet! Just to be sure, ran the puppet agent -t again, twice on each side, and still nothing. Do you need any other info? Can I help you to help me?

Have you installed the puppetdb?
 **
I did not! That must be the problem!
I'm trying to configure it now, as soon as it is ok, I'll post my results. Thanks again for the help!

PERFECT! That was the problem! As soon as I configured puppetdb properly, it all worked just fine and out of the box! Thank you very much for your help!


GIF file is getting uploaded if mediaType is photo

Description
I have tried to select GIF file from Gallery. the file is getting selected & converted into jpg file. The GIF file should not be selected & converted into jpg file.
How to repeat issue and example

step to reproduce the issue
Just try to select GIF file from gallery.

Solution
What needs to be done to address this issue?
Additional Information

Image Picker version: [3.8.1]
React Native version: [0.63.4]
Platform: [Android]
Development Operating System: [Windows]
Dev tools: [Android Studio Iguana | 2023.2.1 Patch 2]

might be the same issue: https://github.com/react-native-image-picker/react-native-image-picker/issues/2064#issuecomment-2460501473


data split of UNETR

Thanks for your great work! Can you provide me with the data split of the Brain Tumour, spleen and BTVC? Thanks you a lot.

Hi @282857341
Thanks for your interest in our work. We will release brain and spleen splits upon release of their codes.
For BTCV, the numbers reported in the paper are directly from the test leaderboard. We also provided a sample split for training and evaluating our model here.
Thanks


Go string to C string

Handle the conversion from Go string to C UTF16-LE-encoded C string

See: https://stackoverflow.com/questions/38309982/change-value-of-golang-c-string-variable-in-c-function

Added a convenient function to convert Go String to C String.


face detect attributes returns null

              faces[0].leftEyeOpenProbability
              faces[0].headEulerAngleY,
              faces[0].headEulerAngleZ,
              faces[0].rightEyeOpenProbability,
              faces[0].smilingProbability,
              faces[0].trackingID);

Why is it returns null from all these attributes after it detected a face from live camera?

is this for iOS or Android?

is this for iOS or Android?
Android

I just tried to clone the example project and run it on simulator, but it still return null.

try running on an actual device

try running on an actual device

sorry for typo, i tried to run on physica device.

ok, I will take a look at it

@wmla419: after reviewing, the example app is working as expected look at the configuration for the Detector options, only the contour is enabled:
https://github.com/bharat-biradar/Google-Ml-Kit-plugin/blob/master/example/lib/VisionDetectorViews/face_detector_view.dart#L12-L15
if you are interested in classification you can enable that as well, but be cautions, there are some constraint outlines in the real time Face detection API.
https://developers.google.com/ml-kit/vision/face-detection/android#real-time_face_detection
According to that you cannot have Contour detection and classification enabled at the same time, but I changed it in my example app and it is working. Give it a try.
FaceDetector faceDetector =
      GoogleMlKit.vision.faceDetector(FaceDetectorOptions(
    enableContours: true,
    enableClassification: true,
  ));


default .htaccess is sending https:// requests with trailing slashes back to http://

Laravel Version: 5.5.40
PHP Version: 7.0
Database Driver & Version: Not relevent (MYSQL)

Description:
My https secured cloudfront frontend is currently trying to POST new records to https://my.site.net/api/projects/1234/forecasts/ due to a string concatenation issue, however the trailing slash tweak in laravel is sending this to http://my.site.net/api/projects/1234/forecasts/, causing the browser to throw a mixed content error.
Api is running on an AWS EC2 instance, standard amazon linux.
Steps To Reproduce:
Routes are resourceful as follows (in API Routes):
    Route::apiResource('project', 'ProjectController');
    Route::apiResource('project.event', 'ProjectEventController');
    Route::apiResource('project.company', 'ProjectCompanyController');
    Route::apiResource('project.forecast', 'ProjectForecastController');
    Route::apiResource('project.boxfolder', 'ProjectBoxFolderController');
    Route::apiResource('project.contact', 'ProjectContactController');
    Route::apiResource('project.order', 'ProjectOrderController');
    Route::apiResource('project.invoice', 'ProjectInvoiceController');
    Route::apiResource('project.location', 'ProjectLocationController');
    Route::apiResource('project.resource', 'ProjectResourceController');

.htaccess remains unmodified from original state:
<IfModule mod_rewrite.c>
    <IfModule mod_negotiation.c>
        Options -MultiViews -Indexes
    </IfModule>

    RewriteEngine On

    # Handle Authorization Header
    RewriteCond %{HTTP:Authorization} .
    RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

    # Redirect Trailing Slashes If Not A Folder...
    RewriteCond %{REQUEST_FILENAME} !-d
    RewriteCond %{REQUEST_URI} (.+)/$
    RewriteRule ^ %1 [L,R=301]

    # Handle Front Controller...
    RewriteCond %{REQUEST_FILENAME} !-d
    RewriteCond %{REQUEST_FILENAME} !-f
    RewriteRule ^ index.php [L]
</IfModule>

It's been a while since I dabbled with .htaccess rules and I'm rusty on how this could possibly be breaking my app.  Maybe I am just blind to something here?
Also wasn't sure if this is the right place for this, so if there's a better place, send me there?   If this is a bug with Laravel I assume y'all would want to know about it tho.
If not, thanks and sorry!

 So the generated redirects are http links. You would need to configure trusted proxies accordingly if it's Laravel that is generating the links, or modify the .htaccess file to check the extra headers that your load balancer sets that tells you the original ip address, scheme and stuff.
This happens for all cases of ssl-terminating middlemen, including proxies like Cloudflare.

Hi,
I'm confirming the issue. But, it's hard to say whether it's because of Laravel of a CDN. It took me time to find out, but I'm making sure all outgoing URL doesn't have a trailing slash.


Use rootform test to check by root form view

This is consistent with the latest changes in the form themes and avoids any future collision between form view properties and form fields.
See https://github.com/symfony/symfony/pull/25236

Thanks Yonel.


Support for selecting multiple categories

Probably through a comma delimited URL path:
https://sv443.net/jokeapi/category/Programming,Miscellaneous

Added in 7925adf468b5bf7bf62fc7e7c6f6e910ed9ca2d0, but is still broken.
Currently fixing

Is now fixed in c4263b4f739e0e3a1ee73ae21a956dc847fcf173.
Multiple categories can now be specified by separating them with , or + or -.


Add hole support

I created a simple test and it seems that this library already has rudimentary hole support at least.  Thinking about this some more, this makes sense, because the algorithm treats any edge/segment as an inside-outside boundary.

Here's a link to the geometry with a hole in it:
https://github.com/GeoTIFF/dufour-peyton-intersection/blob/hole/data/hole.geojson

Next step will be to find more complicated geometries with holes in them (and with topological complexities like overlapping holes) and improve handling of edge cases.

It's also very possible that there is an issue on the GeoBlaze side where it's treating each ring (exterior and interior) as separate polygons.

one edge case is vertical lines at x=0 are ignored on this line:
https://github.com/GeoTIFF/dufour-peyton-intersection/blob/main/src/calculate-core.js#L140
this will be fixed in the next release

all known hole issues appear to be fixed with https://github.com/GeoTIFF/dufour-peyton-intersection/pull/3


Add primaryKey to the serializer just like ember data serializer 👍

Extend the serializers to add the following code
// this is the name of the primary ID, if it is not present, use the attribute name
  primaryKey: undefined,

  keyForAttribute(attr) {
    if (attr === 'id') {
      return this.primaryKey || attr;
    }
    return attr;
  }

Many of my backend keys are not id, and in the ember data serializer I use primaryKey to rename them.    This would make the mirage serializers work very similar to the ember data counter parts
If this seems a reasonable request, let me know and I would be happy to do a PR

Yeah – probably reasonable, though is a pretty big change as this really belongs in the ORM layer rather than the Serializer layer.
We could do it in the serializer layer for now though – would you be ok if your mirage DB records all used id, as long as when they get seiralized over the network they get changed to your pk of choice?
In that case I think something like a new keyForId and valueForId hooks on the Serializer would solve both this problem as well as this SO question raised earlier today: https://stackoverflow.com/questions/61273522/convert-all-miragejs-ids-to-integers/61273523?noredirect=1#comment108401127_61273523

I thought this went here because it would seem its only a problem when the models are generated for you (hence ember only). But if when you define a mirage model you also HAVE to use 'id', then yea.
And yea, perfectly fine with the the key being 'id' in the mirage database, dont expect you to mirror my backend database.
And keyForId was the first method I looked for.
So I would suggest keyForId and valueForId in the mirageJs, and then in this repo extend the serializer with an overload of keyForId that implements the default primaryKey logic as a nice touch to to ember data serializer

Now that im continuing on, it looks like I have the same problem for other fields i have renamed. I have the following on my serializer in ember data
  attrs: {
    name: {key: "facilityName"},
    reorderPoint: {key: "flagReorderPoint"},
    lotAndExpirationView: {key: "flagLotAndExpirationView"},
    ndcSubItemsView: {key: "flagNdcSubItemsView"},
    network: {key: "networkId"},
    account: {deserialize: "records", serialize: "records"},
  },

which I think means I need to do a custom serializer and implement a keyForAttribute and a few others. Im am going to extend my application serializer to implement this using the same array from my ember data serializer but in reverse. This seems like something others would want as well and relates pretty closely to the primaryKey rename.
Seems this should also be some code implemented in this repo so people could just copy and past the serializer attrs.
Is this correct or am I missing something that should be obvious

Hmmmm,    you already use serializer.attrs as a subset include :(

This will be allowed for in this issue and prospective PR https://github.com/miragejs/ember-cli-mirage/issues/1989


code ERR_INVALID_ARG_TYPE

I am getting this error when trying to install via npm

Are you using NPM < 5.0.0?  If so, try with npm i --save ....  It seems like this issue is related to incompatible dependencies, which may be installed in your global NPM environment.


Added simple wrapper around xcode-select

This is for the lazy ones (who don't want to type paths)...

:sparkling_heart:


12 Column Full layout

How can I make https://jekyll.strikehawk.com/about/ a 12 column with padding? I've tried the classes: wide with the TOC but it renders bad.

The theme doesn't have a 12 column layout.

So nothing I can do except create my own foundations layout?

You'll probably want to use a theme that is built on Bootstrap or the like if that's your goal.

Or use layout: splash which doesn’t leave space for the left author sidebar.


release: v0.7.1

Description: 概要

Changes: 変更内容

Changes

fix: consider base path (a272690345a833a05e5c4d4f6518f51b5fb77836)

Expected Impact: 影響範囲

Operating Requirements: 動作要件

Additional context: 補足

Command results

Details:

add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/bin

yarn update
yarn run v1.22.5
$ yarn update:core && yarn workspaces run update && yarn install && yarn upgrade && yarn audit
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/package.json

All dependencies match the latest package versions :)

> @frourio-demo/types
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/shared/types/package.json

All dependencies match the latest package versions :)

> @frourio-demo/utils
$ npx npm-check-updates -u --timeout 100000
Upgrading /home/runner/work/frourio-demo/frourio-demo/shared/utils/package.json

All dependencies match the latest package versions :)

> @frourio-demo/admin
$ npx npm-check-updates -u --timeout 100000 -x @date-io/date-fns,next-transpile-modules
Upgrading /home/runner/work/frourio-demo/frourio-demo/apps/admin/package.json

 @testing-library/react  ^11.2.3  →  ^11.2.4

Run npm install to install new versions.

> @frourio-demo/front
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/workspaces for documentation about this command.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

stderr:
npx: installed 318 in 21.469s

npx: installed 318 in 11.971s

npx: installed 318 in 11.916s

npx: installed 318 in 12.399s

error<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
error Commands cannot run with an incompatible environment.
error Command failed.
Exit code: 1
Command: /usr/local/bin/node
Arguments: /usr/share/yarn/lib/cli.js run update
Directory: /home/runner/work/frourio-demo/frourio-demo/apps/front
Output:

error Command failed with exit code 1.

Changed files

Changed file:

apps/admin/package.json

:octocat: Repo | :memo: Issues | :department_store: Marketplace


ENH: improve error message if you don't call a rule

I recently ran a backtest where I passed date_rules.every_day (uncalled) and got a unhelpful error message. This changes the message to be:
TypeError: invalid rule: <class 'zipline.utils.events.Always'> (hint: did you mean every_minute())

Coverage decreased (-0.02%) to 86.716% when pulling d73ca95edfead6d5c6760a7f26721ff0c240c8e9 on better-error-schedule-function into e3f328da1ff25ff70bfdb2ce40dffdd87da3f1f5 on master.

cc @freddiev4 can you look over this quick

@llllllllll looking now


System.Data.SqlClient.SqlInternalConnectionTds constructor purges original call stack when rethrowing an exception

System.Data.SqlClient.SqlInternalConnectionTds currently goes like this:
try
{
    OpenLoginEnlist(timeout, connectionOptions, redirectedUserInstance);
    break;
}
catch (SqlException sqlex)
{
    if (something)
    {
         throw sqlex;
    }

throw sqlex causes original call stack of where the exception was thrown to be lost. If that's what it desired then it should be explained, otherwise just use throw;

As recently announced in the .NET Blog, focus on new SqlClient features an improvements is moving to the new Microsoft.Data.SqlClient package. For this reason, we are moving this issue to the new repo at https://github.com/dotnet/SqlClient. We will still use https://github.com/dotnet/corefx to track issues on other providers like System.Data.Odbc and System.Data.OleDB, and general ADO.NET and .NET data access issues.

It is important that internal stack information is not destroyed. This is very valuable when guessing the source of bugs. throw; is correct.
I have never seen code that intentionally deletes part of the stack in order to make it easier to interpret the stack. The entire framework does not do this. This would not be a good choice.


Q - recovering environment after losing the terraform state files

There is no way to recover the environment if the terraform state files have been accidentally modified/deleted. We need to discuss how to help users recover the environment.
Possible option is to add Q+A section in the docs where at least some possible actions will be covered.

it was discussed that its not an actual issue and there are ways to recover the tfstate.