08_Duckling.ipynb - TypeError

Hi, I've been trying to run the below code on Jupyter Notebook and Colab, but both threw the same error:

TypeError                                 Traceback (most recent call last)
 in ()
----> 1 pprint(d.parse_time(u"Let's meet at 11:45am"))
2 #pprint(d.parse_time(u'You owe me twenty bucks, please call me today'))
4 frames
/usr/local/lib/python3.6/dist-packages/jpype/_jstring.py in getitem(self, i)
46
47     def getitem(self, i):
---> 48         if i < 0:
49             i += len(self)
50             if i < 0:
TypeError: '<' not supported between instances of 'slice' and 'int'
I tried duckling 1.8.0, and 1.7.1, without success. I was wondering if anyone could point me in the right direction? Thank you.
Regards,
Sony

Hi  @sony-au,
Thank you for bringing this to our notice. We are looking into this. Will get back to you.
Regards,
Practical NLP Team

@sony-au @varunp2k  - I just ran this with Duckling 1.8.0, but with old Python version (3.6), on Ubuntu and with Jupyter Notebook. I was able to run it without errors.

@sony-au The issue seems to be because of issue with openjdk. It does not work for openjdk 11 but works for openjdk version 8. We have opened an issue in the  git repo of Duckling package too.

@varunp2k @nishkalavallabhi I installed JPype 0.7.4 and it resolved the issue. it did show the deprecation warning, but it works. thanks guys

This issue is because the library in question is depending on the deprecated JPype automatic conversion for Java strings to Python strings.  Simply adding a call to str() prior to getting the slice will correct the issue as it will transfer the string from Java to Python where slightly different operators are supported.   Slicing is not supported on a Java string but is on a Python string.
ie.  Before
    a = callSomething()[1:5]  # worked on old because callSomething returned a Python string.
``

After

a = str(callSomething())[1:5]  # works on both old and new JPype

If the code has way too many of these to fix add "convertStrings=True" to the startJVM command.  It will give the old behavior.  ConvertStrings will make the code incompatible with other JPype libraries but should also fix the issue.  There has been a deprecated warning on this for the last year (so you can't say you weren't warned).  The warning was supposed to tell you to either add ``convertStrings=True`` and force the old behavior or ``convertStrings=False`` which would lead to fixing the bad code.

If possible please correct the error rather than rolling back the JPype version.   I work to fix leaks and improve code quality and freezing the version to something old just makes it so people are getting older bugger code.

We are not interacting directly with the JPype library. Ducking is doing that. The reason we recommend rolling back the version is because Ducking has not been updated since a few years. It has been inactive.
Plus the greater goal at hand here is people being able to run the ducking notebook and understand how it implements Temporal IE. We understand that the way which we recommend is not optimal, but again as mentioned Ducking is not actively maintained and hence we need to use a JPype version which is compatible with it.
We understand the importance of code quality, using the latest and improved versions of the code. But this repository serves as a aid/tutorial for the readers of the book. It is a bit hard from our end to keep updating the code for every version change from packages. That is the reason we are freezing the versions of packages.

I attempted to address the issue with jpype-project/jpype#833 which will add slicing support for the string wrapper.  After all it much easier to  the active project to address the issue that the inactive one.   Unfortunately, as I don't run ducking I don't know what other issues are lurking here.  You would need to test with the software and see if addresses all the issues.
As a book i understand the desire to pin rather than tracking the latest software. though if I can help get this up to date rather than pin at a potentially old version it would be best.  It is much worse when it is a library such as JayDeBeAPI which people are intended to build code on which is pinning to an ancient version.  That generates a poor experience for both my users and results in me having to answer questions from times before I joined JPype on problems long since fixed.


PlatformIO builds fail with bip39 package on ESP8266.

Describe the bug
Builds fail with bip39 package on ESP8266, most recent at:  #80
A PR has been sitting at packages main repo as a potential fix: https://github.com/ciband/bip39/pull/8
There is a standing issue with repeating words in mnemonic generation brought up in #72
There are also imposed limitations on micro-architectural environments pertaining to library size due to its multi-language dictionary.
BIP39 is a nice feature to have, but this current implementation is buggy and out of scope for ARK SDK standards (ARK SDK Cryptography Guidelines).
I propose the bip39 lib be removed from the C++ Crypto SDK at this time.
Once its issues are addressed, I would like to see this listed as a C++ Crypto compatible lib in any relevant docs or media as an option for users; just not included by default.
Leaving this up for a few days to gather feedback if anyone wishes to weigh in.

I agree with Simon.
Life has hit me and have been busy. I do not foresee time to be able to look into the outstanding bug in BIP39.
It makes sense to drop support.

On May 14, 2019, at 20:57, Simon<EMAIL_ADDRESS>wrote:
Describe the bug
Builds fail with bip39 package on ESP8266, most recent at: #80
A PR has been sitting at packages main repo as a potential fix: ciband/bip39#8
There is a standing issue with repeating words in mnemonic generation brought up in #72
There are also imposed limitations on micro-architectural environments pertaining to library size due to its multi-language dictionary.
BIP39 is a nice feature to have, but this current implementation is buggy and out of scope for ARK SDK standards (ARK SDK Cryptography Guidelines).
I propose the bip39 lib be removed from the C++ Crypto SDK at this time.
Once its issues are addressed, I would like to see this listed as a C++ Crypto compatible lib in any relevant docs or media as an option for users; just not included by default.
Leaving this up for a few days to gather feedback if anyone wishes to weigh in.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you, and no worries @ciband
BIP39 support will be dropped soon then along with the mnemonic class and tests.
It will constitute a major version bump, and will likely come this week.
After that, I'll close out this issue.

Resolved in #86


feat(obstacle_stop_planner): improve hunting prevention mechanism

Description
Before

the module only keep the info that whether there are obstacel points or not.
chattering stop position

https://user-images.githubusercontent.com/44889564/212215832-f1df0055-5611-4a6e-b66a-5a89438feb05.mp4
After

the module also keep the history of the obstacle points' position and detection time.
not chattering stop position

https://user-images.githubusercontent.com/44889564/212215844-6e4f11da-c04a-4abb-bd6d-179a8332f0a2.mp4
TEST
Please set hunting_threshold to positive value (> 0).
hunting_threshold: 0.5                   # even if the obstacle disappears, the stop judgment continues for hunting_threshold [s]

https://github.com/autowarefoundation/autoware_launch/blob/9ef2b6939d8aa276c909a6513f401ffc4301cce6/autoware_launch/config/planning/scenario_planning/lane_driving/motion_planning/obstacle_stop_planner/obstacle_stop_planner.param.yaml#L3

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta
could you review this PR?


Do not compare strings with strcmp when we know the length

Done in master. I removed by accident.


Add API to stream 'ALL' connections via channel, instead of the current

method of putting all connections into an array.

@alicebob cld u get to this asap since it's a little time urgent? thx

Thanks for the PR!


fix: hermes option read from wrong param

Summary
hermes option was read from the wrong parameter. This is now fixed.
Test plan
All existing tests should still pass.

@zamotany Sorry 😞

New version<EMAIL_ADDRESS>is live on NPM.


Fixed server_id_key_len value issue

Going to add to this pull request a helper function to charbuf.  Output null-terminated char value from a charbuf input.


Some widgets can't persist the data.

Environment
Docker
Version
0.11.5
Describe the problem
When you insert for example the RSS widget, edit it to change the URL, it doesn't let you save the URL. That is, some widgets do not allow you to persist the data.
Some of them are the RSS, Weather, Date and Time widget.
Logs
Homarr-2023-03-15T17-51-14.log.gz
Context
Homarr is installed on docker. I leave the screenshots

More info:
SO: Ubuntu 22.04 LTS
Docker:  version 23.0.1, build a5ee5b1
Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

Hi, thanks for your issue.
We haven't come across this issue yet.
Can you confirm, that your container mounts the configs directory with read & write mode (not read-only with :ro suffix)?
Are there any other issues? Does your config save normally when you edit apps?
Since when do you run Homarr? (Version 0.10.7, 0.11.0, ...)
Is it possible, that you can create a minimal reproduce-able example?

Hello, today was the first time I installed homarr. The 0.11.5 is my first version.
I leave you a screenshot about the write permissions of the configuration file.

Although I don't think that's the problem because I have modified some colors through the custom CSS and it worked perfectly.

@ajnart do you have an idea?
I was thinking of a corrupted config by the migrator, but we ruled this out.
It's very odd, that it's only not working for a few specific items.
@AmadeusGraves can you screenshot the following?

Right click > Inspect (Enable developer mode if you can't find this in your browser)
Open "Console" tab
Screenshot log

Here you go.
Console-1678909383179.log

I also add one video where i try to add two times a RSS resource.
Uploading Video_Captura_00001.mp4…

I upload also a video where i try to add two times a RSS resource (https://www.rebelnews.com/news.rss)
https://user-images.githubusercontent.com/18572939/225427063-c678ac90-08a0-42ee-b0b9-9180e5405d89.mp4

Thanks for the details!
Sadly, I don't see any hints in the log.
Your video also seems to be corrupted:


config.active_record.default_timezone default is already :utc

In this commit https://github.com/thoughtbot/suspenders/commit/d8af03a30921d192910b786d7d56745bb2b70639 you set config.active_record.default_timezone to :utc but rails default is already :utc
References:
http://guides.rubyonrails.org/configuring.html

config.active_record.default_timezone determines whether to use Time.local (if set to :local) or Time.utc (if set to :utc) when pulling dates and times from the database. The default is :utc.

Could it be removed or am I missing something?

Maybe our commit came before that was the default? Agreed, it could be removed.


fix: make watermark filter after rowIdGen

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title, because the watermarkfilter's state table might rely on the vnode of the row_id_gen
dev=> explain CREATE TABLE t (
    index int ,                                                                                time timestamptz,
    WATERMARK FOR time AS time - INTERVAL '5' SECOND
) APPEND ONLY;
                                                                          QUERY PLAN

------------------------------------------------------------------------------------------------------------------------
--------------------------------------
 StreamMaterialize { columns: [index, time, _row_id(hidden)], stream_key: [_row_id], pk_columns: [_row_id], pk_conflict:
 NoCheck, watermark_columns: [time] }
 └─StreamWatermarkFilter { watermark_descs: [Desc { column: time, expr: (time - '00:00:05':Interval) }], output_watermar
ks: [time] }
   └─StreamRowIdGen { row_id_index: 2 }
     └─StreamUnion { all: true }
       └─StreamExchange [no_shuffle] { dist: SomeShard }
         └─StreamDml { columns: [index, time, _row_id] }
           └─StreamSource
(7 rows)

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

because the watermarkfilter's state table might rely on the vnode of the row_id_gen

Can you explain more about this. IIRC watermarkfilter's can rely on any upstream vnode.


ci: Add workflow for publish

Close https://github.com/apache/iceberg-rust/issues/214

cc @Fokko, one of the PMC should configure secrets CARGO_REGISTRY_TOKEN in github.

Hi, @martin-g, would you like to review again?


Fix native build for CentOS 7

This fixes the native build error on CentOS 7 https://github.com/dotnet/corert/issues/2778#issuecomment-281175628.
Though the managed build subsequently fails with:
CoreRT native components successfully built.
~/corert
Installing dotnet cli...
Restoring BuildTools version 1.0.26-prerelease-00821-01...
Failed to initialize CoreCLR, HRESULT: 0x80131500
ERROR: Could not restore build tools correctly. See '/root/corert/init-tools.log' for more details.1
Initializing BuildTools...
/root/corert/buildscripts/../init-tools.sh: line 121: /root/corert/packages/Microsoft.DotNet.BuildTools/1.0.26-prerelease-00821-01/lib/init-tools.sh: No such file or directory
ERROR: An error occured when trying to initialize the tools. Please check '/root/corert/init-tools.log' for more details.1
Using CLI tools version:
1.0.0-preview3-003223

Hi @am11, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Test Windows_NT Release
(https://ci.dot.net/job/dotnet_corert/job/master/job/release_windows_nt_prtest/829/ - failed due to: error MSB4024: The imported project file "D:\j\workspace\release_windo---c2468dc6\bin\obj\BuildVersion-20170220.props" could not be loaded. The process cannot access the file 'D:\j\workspace\release_windo---c2468dc6\bin\obj\BuildVersion-20170220.props' because it is being used by another process)

@janvorli, can you please take a look? :)

I have the same error below. Is there any solution for this ?
CoreRT` native components successfully built.
~/Desktop/corert
Installing dotnet cli...
Restoring BuildTools version 1.0.26-prerelease-00821-01...
ERROR: Could not restore build tools correctly. See '/home/tablonzo/Desktop/corert/init-tools.log' for more details.1
Initializing BuildTools...
/home/tablonzo/Desktop/corert/buildscripts/../init-tools.sh: line 121: /home/tablonzo/Desktop/corert/packages/Microsoft.DotNet.BuildTools/1.0.26-prerelease-00821-01/lib/init-tools.sh: No such file or directory
ERROR: An error occured when trying to initialize the tools. Please check '/home/tablonzo/Desktop/corert/init-tools.log' for more details.1
Using CLI tools version:
1.0.0-preview3-003223

What is in '/home/tablonzo/Desktop/corert/init-tools.log ?

Interesting. When I try it on my CentOS 7 VM, buildtools were initialized correctly and packages restored fine. I got error at the xunit execution stage instead:
coreclr_initialize failed - status: 0x80131500
That means that the coreclr package that it was trying to use was for a different Linux flavor. Looking at strace, the issue happened when attempting to load System.Globalization.Native.so from
bin/tests/Linux.x64.Debug/ILCompiler.DependencyAnalysisFramework.Tests/netcoreapp1.0
This version of the System.Globalization.Native.so refers to libicu 52 while the version on CentOS 7 is 50.1.

When I built as root then everything was ok in init-tools.log but I have some errors in msbuild.x64.log.
msbuild.x64.log.txt

@cocotr that's the same issue as I am getting. From your log:
coreclr_initialize failed - status: 0x80131500

Hi,
Any solution for above?

Did a little digging and able to make some progress:
It turned out CoreRT is using a very old version of .NET Core (v1.0.0) via build tools.
CentOS 7.1 has Linux Kernel 4.9.x, which throws segmentation fault: https://github.com/dotnet/cli/issues/3681
This issue was fixed in .NET Core v1.0.1 by @janvorli.
CoreFX and CoreCLR build tools picked up that version of .NET Core, e.g. @dagood's PR: https://github.com/dotnet/corefx/pull/14933, but CoreRT didn't.
I committed a similar fix to my master branch: I committed a similar fix to my master branch<EMAIL_ADDRESS>Here is the Dockerfile for building CoreRT on CentOS 7.1:
FROM centos:7
# it should pick the latest in v7 series (atm 7.3.1611)
RUN cat /etc/*-release

RUN yum -y -q  install epel-release
RUN yum-config-manager --add-repo https://copr.fedorainfracloud.org/coprs/alonid/llvm-3.9.1/repo/epel-7/alonid-llvm-3.9.1-epel-7.repo
RUN yum -y -q update
RUN yum -y -q install \
      git libunwind libunwind-devel cmake icu libicu-devel which binutils make \
      lttng-ust liblttng-ust-devel libuuid-devel libunwind-devel \
      llvm-3.9.1 clang-3.9.1 lldb --enablerepo=alonid-llvm-3.9.1

ENV PATH /opt/llvm-3.9.1/bin:$PATH

RUN git clone https://github.com/am11/corert -b master --single-branch corert \
    && cd $_ \
    && ./build.sh

 A quick how-to:
Create an empty directory with a file called Dockerfile, say mkdir centos && cd centos && vi Dockerfile, paste the above code in it followed by save/close the file.
Finally run it as:
# make sure docker is installed and (docker engine) service is running:
docker build --tag corert-docker .

or to disable incremental (cache-able) build (aka start over from scratch), use:
docker build --tag corert-docker --no-cache --rm=true .

@janvorli, @dagood, if am11@dd1fde2 is an acceptable change for CoreRT repo, should I send the PR? :)
On CentOS docker mentioned above, I am getting some errors like:
t [/corert/src/System.Private.Reflection.Metadata/tests/System.Private.Reflection.Metadata.Tests.csproj]
/corert/src/Common/src/Internal/Metadata/NativeFormat/NativeFormatReaderGen.cs(7108,21): error CS3003: Type of 'TypeDefinition.Size' is not CLS-compliant [/corert/src/System.Private.Reflection.Metadata/tests/System.Private.Reflection.Metadata.Tests.csproj]
/corert/src/Common/src/Internal/Metadata/NativeFormat/NativeFormatReaderGen.cs(7118,23): error CS3003: Type of 'TypeDefinition.PackingSize' is not CLS-compliant [/corert/src/System.Private.Reflection.Metadata/tests/System.Private.Reflection.Metadata.Tests.csproj]
/corert/src/Common/src/Internal/Metadata/NativeFormat/NativeFormatReaderGen.cs(3699,21): error CS3003: Type of 'Field.Offset' is not CLS-compliant [/corert/src/System.Private.Reflection.Metadata/tests/System.Private.Reflection.Metadata.Tests.csproj]
System/Runtime/ConstrainedExecution/CriticalFinalizerObject.cs(23,10): error CA1821: Remove empty finalizers [/corert/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
/corert/src/Runtime.Base/src/System/Runtime/GCStress.cs(59,10): error CA1821: Remove empty finalizers [/corert/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
System/Threading/ThreadPool.cs(846,10): error CA1821: Remove empty finalizers [/corert/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj]
System/Threading/ThreadPool.cs(908,10): error CA1821: Remove empty finalizers [/corert/src/System.Private.CoreLib/src/System.Private.CoreLib.csproj]

while build is still running / hanged at   ILCompiler.MetadataTransform -> /corert/bin/Product/Linux.x64.Debug/ILCompiler.MetadataTransform/ILCompiler.MetadataTransform.dll ..

is an acceptable change for CoreRT repo, should I send the PR?

I am not sure whether downgrading 1.0.0-preview3-003223 to 1.0.0-preview2-1-003182 is going to work. You can submit PR and see whether it will pass the CI. Upgrading the buildtools to newer version is definitely goodness.

@jkotas I know it sounds weird, but 1.0.0-preview2-1-003182 is actually newer than 1.0.0-preview3-003223. The 1.0.0-preview3-003223 contains libcoreclr.so from June 14, 2016 and 1.0.0-preview2-1-003182 has it from October 28, 2016.

The CLI tools contain a lot more than just the CoreCLR. IIRC, preview2 does not have the msbuild integration, preview3 has the msbuild integration. CoreRT has dependency on the msbuild integration.

libcoreclr.so from June 14, 2016 and 1.0.0-preview2-1-003182 has it from October 28, 2016

I would expect that it is just a newer build from a servicing branch (e.g. libcoreclr.so from June 14, 2016 + handful of bugfixes).

Newer preview3 builds have packed msbuild, but 003223 doesn't. After a quick peek at the CoreRT build scripts, it looks like they use the BuildTools-provided msbuild.sh. I think submitting that PR is a very good idea.

@jkotas, It seems like preview3 branch of CLI is not being updated as frequently as preview2.1, preview4 and the RTM: https://github.com/dotnet/cli/tree/rel/1.0.0-preview3 vs, https://github.com/dotnet/cli/tree/rel/1.0.0-preview2.1. The latest in preview3 series is 003930 that was built in November 2016, but that is not working either as it seems like buildtools versions are tied to specific tools.
I created a pull request #2805, but it seems like CI is not happy with preview2.1 and throwing CS3003 and CA1821 errors: (the same which I am also getting locally with CentOS 7) https://ci.dot.net/job/dotnet_corert/job/master/job/release_osx_prtest/841/consoleFull#141306592a82fefab-f698-416f-8fca-58544c94cd4e. @dagood, any ideas what might be the problem? Could it be that I need to update the NuGet packages versions as well?

Since the last CoreRT buildtools update was 5 months ago, I think the large version skip is the most likely cause. Could it be that some warnings were turned into errors with a new version of MSBuild? https://github.com/dotnet/buildtools/commit/81274b0f84c9a65e89c6761534ec48313b4be05f

@dagood, I set TreatWarningAsError to false in dir.props fixed this issue (all changes: f6a2bec). Now csprojs are building, but NugetPack command is failing: https://ci.dot.net/job/dotnet_corert/job/master/job/release_osx_prtest/850/consoleFull#49494639283554902-aff0-4799-9e92-0ada24ce2a06. Could this be fixed by modifying some configuration / package version? I tried updating CoreFxPackageVersion in packages.targets to match what buildtools restored, but the NugetPack issue persists.

@am11 I don't have any insight into src/packaging/packages.targets, maybe @SedarG can help?

Were you able to build CoreRT ? or the problem still persists ?

Hi,
Did you make any progress?

@cocotr, unfortunately no.
Currently we are blocked at getting build-tools which relies on .NET CLI v1.0-preview4+, v1.1 or v2.0. The desired versions of .NET CLI are shipped with desired version of .NET Core v1.1, which has the fix for CentOS.
Current version of build tools uses v1.0-preview2.1, which also uses desired version of .NET Core, but has issues (package restore misses) when building CoreRT with it. As per my understanding, @jkotas has suggested that we should go higher (from 1.0-preview3 to 1.1-RTM or v2.0), instead of going down version with few extra patches.
Build-Tools repo: https://github.com/dotnet/buildtools
My attempt: https://github.com/dotnet/corert/pull/2805
Jan's attempts: https://github.com/dotnet/corert/pull/2815 and https://github.com/dotnet/corert/pull/2834
still some part in the build pipeline picks up .NET Core v1.0..
As far as I have understood it, best we can do is either:

wait and do nothing until this gets escalated on build-tools side of the house
if we can, help/support @Petermarcu bringing up the CLI v2.0 build in ready state as per the discussion that was transpired here: https://github.com/dotnet/core-setup/issues/1590

Hi,
Did somebody make a progress with building CoreRT on Centos/RHEL ?


Fix converter for ndtiff using multicam

This PR fixes handling ndtiffs written with mutlicam. When using multicam, the datasets have an extra axis that needs to be parsed to reshape the output array.

@ieivanov this is the PR I started trying to fix the convert to have iohub read the data with the additional axis.

Thanks Ed - let's see if we can fix this problem at the source. I don't like that in this implementation we need to expand the array dimensions from 5D to 6D. In the meantime, I understand that this is helping you convert the data that's acquired with the intermediate fix we have.


Tutorial crashed

When going through the tutorial steps and pressing Create to configure the project it gave error "Exception from HRESULT: 0x80042001. Every time I retry it gives the same error and never finishes the creation process.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a12b2f91-753b-4771-85c2-75808137088a
Version Independent ID: a047d08b-9306-8f1e-2d69-a932417f97b2
Content: Create your first document-level customization for Excel
Content Source: docs/vsto/walkthrough-creating-your-first-document-level-customization-for-excel.md
Product: visual-studio-windows
Technology: office-development
GitHub Login: @John-Hart
Microsoft Alias: johnhart

@RiKelleher please follow https://learn.microsoft.com/en-us/visualstudio/ide/how-to-report-a-problem-with-visual-studio?view=vs-2022 to send feedback to the Visual Studio team on this issue.


Multiple axes

Cursors does not work with multiple axes. It shows values as all pens would be on primary axis :(

Can you please give more details about what you want to accomplish and doesn't work ?


Disclaimer Modal - use local storage

Description
To avoid the disclaimer modal popping up so frequently due to using session storage - this PR utilizes local storage for determining to show the modal again as opposed to the current solution which is based on the users session.
Related Ticket
Closes #2405

Looks good!

Bumping this if one of you has a free minute to review @must-be-carbon & @Atmosfearful


ci: fix tag-artifacts

I don't think this is quite right yet. We need to upload the artifacts as assets to a release, and...uh. That's not really clear to me how to do yet. But it's getting there.


Add commitlint to containerized-test

Describe what this PR does
The commitlint command can be used to verify the subject of commit
messages, so it is added to the $PATH of the test container.
The rules are documented at https://commitlint.js.org/#/reference-rules
and can easily be added to the configuration.
When passing GIT_SINCE as an argument, the commits from then on
(defaults to origin/master) are used. A CI job can pass the base branch
or ID so a range of patches gets checked.
To test the last four commits, one can run:
$ make containerized-test TARGET=commitlint GIT_SINCE=HEAD~4

A CI job can pass the base branch where the PR is expected to get merged.
Related issues
Updates: #1057 - still needs a configuration in .travis.yaml
See-also: #1036 - contains the list of valid types
Future concerns
This can easily be run in the CentOS CI, but we may want to run it in Travis CI instead

where is the status of Travis CI and commitlint bot? i don't see both of them  running on  this PR

where is the status of Travis CI and commitlint bot? i don't see both of them running on this PR

not sure what happened to Travis... commitlint was erroneously removed with #1053, instead of the Semantic Pull Request one...

where is the status of Travis CI and commitlint bot? i don't see both of them running on this PR

not sure what happened to Travis... commitlint was erroneously removed with #1053, instead of the Semantic Pull Request one...

@humblec any idea what happened to Travis CI?

where is the status of Travis CI and commitlint bot? i don't see both of them running on this PR

not sure what happened to Travis... commitlint was erroneously removed with #1053, instead of the Semantic Pull Request one...

Its back .. can you repush with a small change?

not sure what happened to Travis

Actually, Travis is running: https://travis-ci.org/github/ceph/ceph-csi/builds/686603670
Just not updated the status of this PR for some reason.

/retest
Trying to restart a test in the CentOS CI (should not use @nixpanic, but @ceph-csi-bot account)

Rebased on the master branch, resolved conflict related to Makefile. Please check again. Thanks!

/retest ci/centos/containerized-tests


I am very interested in this subject.

Hi lezcano
Could you provide me with some advice If I want to study the topic of optimization of manifolds and Euclid in the long term.
Now, The only deficiency is I  have only a basic knowledge of Riemann manifolds, fiber bundle and topology

To learn about optimisation on manifolds, differential and Riemannian geometry is essential. You can have a look at Lee's book "Introduction to Smooth Manifolds" for a basic introduction, or take / read relevant courses in these areas. Find a course that you feel comfortable reading from a university and read through it. Then take another one and repeat :)
Depending on your maths level, you may be comfortable reading more advanced books on the topic. A second book on Riemannian geometry that I particularly like is Peter Petersen's "Riemannian Geometry", but again, I would not use this one as an introductory book.

To learn about optimisation on manifolds, differential and Riemannian geometry is essential. You can have a look at Lee's book "Introduction to Smooth Manifolds" for a basic introduction, or take / read relevant courses in these areas. Find a course that you feel comfortable reading from a university and read through it. Then take another one and repeat :)
Depending on your maths level, you may be comfortable reading more advanced books on the topic. A second book on Riemannian geometry that I particularly like is Peter Petersen's "Riemannian Geometry", but again, I would not use this one as an introductory book.

Thanks for the reply, I will try it.😊😊


Lottie animation doesn't play when using React Navigation presentation: 'modal'

Description
Lottie animation doesn't play when used in a view that is wrapped in Stack.Screen using presentation: 'modal'
Steps to Reproduce
import { createNativeStackNavigator } from '@react-navigation/native-stack';
import { LottieView } from 'lottie-react-native';

const Stack = createNativeStackNavigator();
const Test = () => (
  <LottieView
    source={animationImport}
    loop
    resizeMode={'cover'}
    style={{
      width: 320,
      aspectRatio: 160 / 160,
    }}
    speed={1}
  />
)

const MainFlowStack = () => {
  return (
      <Stack.Navigator>
        <Stack.Screen
          name={'Main'}
          component={Main}
        />
        <Stack.Screen
          name={'Test'}
          component={Test}
          options={{
            presentation: 'modal',
            title: '',
            headerTransparent: true,
          }}
        />
      </Stack.Navigator>
  );
};

Expected behavior: [What you expected to happen]
Video 2: When using default
https://user-images.githubusercontent.com/9265979/166162791-bc2d9cd9-fd32-4103-aa5b-0b66e4ba4905.mov
Actual behavior: [What actually happened]
When using presentation: 'modal'
https://user-images.githubusercontent.com/9265979/166162751-7934821f-1708-4e23-89a4-43af005962ae.mp4
Versions
"react": "^17.0.2",
"react-native": "^0.67.3",
"lottie-ios": "3.2.3",
"lottie-react-native": "^5.0.1",
"@react-navigation/bottom-tabs": "^6.0.7",
"@react-navigation/native": "^6.0.4",
"@react-navigation/native-stack": "^6.2.2",
"@react-navigation/stack": "^6.0.9",

How react-navigation mounts modals might be different than how it mounts regular screens. You could try some tricks:

pass the autoplay prop
use the imperative API to start the animation when you know the modal is mounted (e.g. useEffect(() => {},[])

How react-navigation mounts modals might be different than how it mounts regular screens. You could try some tricks:

pass the autoplay prop
use the imperative API to start the animation when you know the modal is mounted (e.g. useEffect(() => {},[])

This trick works.

Here is a simple hack, use onLayout prop and autoPlay prop both of LottieView and play it like this,
const animationRef = useRef(null);

<LottieView ref={animationRef} onLayout={_ => animationRef.current?.play()} source={YourAnimation} autoPlay loop style={{ ..yourStyles }} />


Upgrading protobuf.

That currently won't work. Python seems to have an issue with that.
Let's treat that Pull Request as an issue, where we can follow its progress through Travis's status.

Direct link to the Python issue on Travis.

@haberman: does the exception "TypeError: init() got an unexpected keyword argument 'syntax'" call to mind any common, simple, obvious mistakes we may be making in this case?
@soltanmm: since this is happening only in python_plugin_test and what's happening is failure when import of the generated _pb2 module is attempted, it's worth looking at for at least twenty or thirty minutes. I can't imagine what we'd be doing wrong, but it's worth learning more details - possibly from looking at the text of the generated code?

does the exception "TypeError: init() got an unexpected keyword argument 'syntax'" call to mind any common, simple, obvious mistakes we may be making in this case?

The syntax field was added since the last release to both descriptor.proto and the Descriptor classes in Python. This error suggests to me that you are using generated code from the new version of protobuf, but using either a runtime or a generated descriptor_pb2.py from an earlier version.
What version are you upgrading from, and what version are you upgrading to?

from alpha-1 to alpha-2.
On Wed, May 6, 2015 at 11:36 AM, Joshua Haberman<EMAIL_ADDRESS>wrote:

does the exception "TypeError: init() got an unexpected keyword argument
'syntax'" call to mind any common, simple, obvious mistakes we may be
making in this case?
The syntax field was added since the last release to both
descriptor.proto and the Descriptor classes in Python. This error suggests
to me that you are using generated code from the new version of protobuf,
but using either a runtime or a generated descriptor_pb2.py from an earlier
version.
What version are you upgrading from, and what version are you upgrading to?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/1455#issuecomment-99566791.

I wonder if the work to be done here is as simple as changing "protobuf==3.0.0-alpha-1" to "protobuf==3.0.0-alpha-2" in src/python/requirements.txt? @nicolasnoble, did you try that in an earlier draft of this pull request?

Let's give it a go.

Nope, same thing: https://travis-ci.org/grpc/grpc/jobs/61660220

after building grpc (and protobuf 3.0.0a2) from sources, I stumbled upon that same unexpected keyword argument 'syntax'. I checked and grpc was not using my protobuf (egg) build, it was using alpha1 from pypi instead.
I tried to simply tweak my easy-install.pth to make it point to my alpha2 build, and it worked (the examples in the grpc-common repo).
I ended up just rebuilding with:
sed -i -e 's/3.0.0-alpha-1/3.0.0-alpha-2/' src/python/src/setup.py
It was enough to make it work for me (but there are other hardcoded strict dependencies on alpha-1 in the tree)

On it, but, an aside: shouldn't this file also be changed?

Yes. I will do that last when everything else works.

It is an upstream issue: https://github.com/google/protobuf/issues/333

For gRPC C#, this is basically a release blocker, as it prevents me from upgrading to the version of protobufs that supports C# (which was merged into master just today).

Same thing with Objective-C. The protoc plugin needs the newer version of the protoc libraries, and alpha release needs the plugin.

Everything seems now working, with the latest protobuf pip package.

Ping.

Please squash commits? Change content looks good.

@nathanielmanistaatgoogle , would you be fine merging this?
As an alternative, I can recreate this PR with commits squashed so we can merge this today.

@jtattermusch: yes, please recreate the content with commits squashed.

@nathanielmanistaatgoogle, I recreated the PR. Thanks for pushing hard towards quality!


Add vacation checking to blunderbuss

A bunch of us will be out of the office for a stretch soon. It'd be nice if PRs were routed to people who aren't out. What's the best way to tell the blunderbuss munger that we're out of the office?

Have people make a gist named "kubernetes-vacation" with a human readable format indicating dates that they're unavailable.
Same as above, but people make their own ooo repo.
Have people add the string " - OOO" to their location in github while they're out. (This was easy, so it's in this PR right now)
Keep a file in the main repo that people just update.
Other ideas?

Some people don't want their vacation schedules to be public.

@eparis

Can we just turn off blunderbuss for two weeks and tell the oncall to assign PRs like we did in the pre-blunderbuss days? I suspect the oncall load will be a lot lighter than normal, so this doesn't seem like too much extra burden.

It is easy to turn off blunderbuss...

Another idea: A private repo under the kubernetes org.

@eparis: What do you think about merging this as-is? We can revert it in January. If people are worried about disclosing their vacation status, they don't have to use it. But I get a lot of PRs and I'd like to make use of this.

We can turn it on this year, but its complete lack of discover-ability, the likelihood that we will set it and never remember to unset it, etc makes me not like this implementation.  So I'm ok with merge/revert and keep rolling around ideas for next year, or just turn off blunderbuss on the 18th and ask on call to do it until the 1st. I won't complain about either way.

we're through christmas. I'm just gunna close....


Set user agent name

Description
The search logs are populated with entries like [2022-12-13T13:23:27Z INFO actix_web::middleware::logger] <IP_ADDRESS> "GET /indexes HTTP/1.1" 200 559 "-" "node-fetch/1.0 (+https://github.com/bitinn/node-fetch)" 0.000419
Can it be specific that this was the plugin?
Basic example
[2022-12-13T13:23:27Z INFO actix_web::middleware::logger] <IP_ADDRESS> "GET /indexes HTTP/1.1" 200 559 "-" "strapi-plugin-meilisearch" 0.000419

Hey @vlowe85, the plugin is using the javascript client. Since the client is also used on browser, we cannot alter the USER-AGENT header as altering it throws errors in chromium based browsers.
To tackle that, we created a custom header X-Meilisearch-Client in which you receive the required information:
https://github.com/meilisearch/strapi-plugin-meilisearch/blob/14f0764225a67596a25a5c87d0d33f7135ff5d5c/server/services/meilisearch/client.js#L15
In meilisearch-js

Does this answer your question @vlowe85 ?

I think this issue is solved :)


Pippy example error: torch._dynamo.exc.Unsupported: call_method UserDefinedObjectVariable(Logger) warning_once [ConstantVariable()] {}

System Info
torch: 2.4.0
python: 3.10.12
accelerate: 0.33.0
accelerate config:
- Platform: Linux-5.15.0-88-generic-x86_64-with-glibc2.35
- `accelerate` bash location: /usr/local/bin/accelerate
- Python version: 3.10.12
- Numpy version: 1.24.4
- PyTorch XPU available: False
- PyTorch NPU available: False
- PyTorch MLU available: False
- PyTorch MUSA available: False
- System RAM: 1007.68 GB
- GPU type: NVIDIA A100 80GB PCIe
- `Accelerate` default config:
	Not found
GPU: 4 X A100 80GB

Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[ ] My own task or dataset (give details below)

Reproduction

Clone and setup this pippy/llama example: https://github.com/huggingface/accelerate/blob/288accc0ec3321932a494f3a2aea262c58c55e44/examples/inference/pippy/llama.py
accelerate launch --num_processes 4 ./llama.py
Error occurs after checkpoints are loaded. It seems that there's a custom logger function warn_once that's not compatible with dynamo:

[rank2]: Traceback (most recent call last):
....
[rank2]:     model = prepare_pippy(model, split_points="auto", example_kwargs=inputs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/accelerate/inference.py", line 173, in prepare_pippy
[rank2]:     stage = build_pipeline(model, split_points, example_args, example_kwargs, num_chunks)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/accelerate/inference.py", line 94, in build_pipeline
[rank2]:     pipe = Pipe.from_tracing(model, num_chunks=num_chunks, example_args=args, example_kwargs=kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/pippy/IR.py", line 1067, in from_tracing
[rank2]:     traced = Pipe._trace_with_export(
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/pippy/IR.py", line 1015, in _trace_with_export
[rank2]:     traced: torch.fx.GraphModule = _export_to_torch_ir(
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/export/_trace.py", line 430, in _export_to_torch_ir
[rank2]:     gm_torch_level, _ = torch._dynamo.export(
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/eval_frame.py", line 1237, in inner
[rank2]:     result_traced = opt_f(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank2]:     return self._call_impl(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank2]:     return forward_call(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/eval_frame.py", line 410, in _fn
[rank2]:     return fn(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank2]:     return self._call_impl(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank2]:     return forward_call(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/convert_frame.py", line 942, in catch_errors
[rank2]:     return callback(frame, cache_entry, hooks, frame_state, skip=1)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/convert_frame.py", line 402, in _convert_frame_assert
[rank2]:     return _compile(
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_utils_internal.py", line 70, in wrapper_function
[rank2]:     return function(*args, **kwargs)
[rank2]:   File "/usr/lib/python3.10/contextlib.py", line 79, in inner
[rank2]:     return func(*args, **kwds)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/convert_frame.py", line 689, in _compile
[rank2]:     guarded_code = compile_inner(code, one_graph, hooks, transform)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/utils.py", line 265, in time_wrapper
[rank2]:     r = func(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/convert_frame.py", line 544, in compile_inner
[rank2]:     out_code = transform_code_object(code, transform)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/bytecode_transformation.py", line 1103, in transform_code_object
[rank2]:     transformations(instructions, code_options)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/convert_frame.py", line 166, in _fn
[rank2]:     return fn(*args, **kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/convert_frame.py", line 506, in transform
[rank2]:     tracer.run()
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 2197, in run
[rank2]:     super().run()
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 847, in run
[rank2]:     while self.step():
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 757, in step
[rank2]:     self.dispatch_table[inst.opcode](self, inst)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 481, in wrapper
[rank2]:     return inner_fn(self, inst)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 1281, in CALL_FUNCTION_KW
[rank2]:     self.call_function(fn, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 697, in call_function
[rank2]:     self.push(fn.call_function(self, args, kwargs))
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/nn_module.py", line 351, in call_function
[rank2]:     return tx.inline_user_function_return(
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 703, in inline_user_function_return
[rank2]:     return InliningInstructionTranslator.inline_call(self, fn, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 2357, in inline_call
[rank2]:     return cls.inline_call_(parent, func, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 2473, in inline_call_
[rank2]:     tracer.run()
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 847, in run
[rank2]:     while self.step():
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 757, in step
[rank2]:     self.dispatch_table[inst.opcode](self, inst)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 481, in wrapper
[rank2]:     return inner_fn(self, inst)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 1269, in CALL_FUNCTION_EX
[rank2]:     self.call_function(fn, argsvars.items, kwargsvars)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 697, in call_function
[rank2]:     self.push(fn.call_function(self, args, kwargs))
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/functions.py", line 339, in call_function
[rank2]:     return super().call_function(tx, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/functions.py", line 293, in call_function
[rank2]:     return super().call_function(tx, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/functions.py", line 90, in call_function
[rank2]:     return tx.inline_user_function_return(self, [*self.self_args(), *args], kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 703, in inline_user_function_return
[rank2]:     return InliningInstructionTranslator.inline_call(self, fn, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 2357, in inline_call
[rank2]:     return cls.inline_call_(parent, func, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 2473, in inline_call_
[rank2]:     tracer.run()
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 847, in run
[rank2]:     while self.step():
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 757, in step
[rank2]:     self.dispatch_table[inst.opcode](self, inst)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 481, in wrapper
[rank2]:     return inner_fn(self, inst)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 1228, in CALL_FUNCTION
[rank2]:     self.call_function(fn, args, {})
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/symbolic_convert.py", line 697, in call_function
[rank2]:     self.push(fn.call_function(self, args, kwargs))
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/misc.py", line 592, in call_function
[rank2]:     return self.obj.call_method(tx, self.name, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/user_defined.py", line 618, in call_method
[rank2]:     return super().call_method(tx, name, args, kwargs)
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/variables/base.py", line 313, in call_method
[rank2]:     unimplemented(f"call_method {self} {name} {args} {kwargs}")
[rank2]:   File "/usr/local/lib/python3.10/dist-packages/torch/_dynamo/exc.py", line 204, in unimplemented
[rank2]:     raise Unsupported(msg)
[rank2]: torch._dynamo.exc.Unsupported: call_method UserDefinedObjectVariable(Logger) warning_once [ConstantVariable()] {}

Expected behavior
Run through the example without error and get inference results.

Hello did you manage to fix it @hchings ?

No, I've used other framework instead. Thank you though!


libxplayer-plparser: 1.0.2 -> 1.0.3

Ported to meson and requires gmime3.
Will test soon™
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

libxplayer-plparser: 1.0.2 → 1.0.3

[ ] Remove hadess from MAINTAINERS
[ ] Add CI configuration

Keywords: command

[ ] Port to meson (#3)

Tags: master.lmde3 master.mint18 master.mint19
Files: meson.build meson_options.txt configure.ac
Keywords: bin usr command exec dependency

[ ] CI: Update targets
[ ] Bump gmime dependency to version 3.0

Files: meson.build
Keywords: dependency

[ ] CI: Update targets
[ ] 1.0.3

Tags: 1.0.3
Files: meson.build
Keywords: dependency


Couldn't load parser library

Hi there, looks like an awesome plugin! I'm running into an issue which seems to prevent the plugin from loading correctly.
I've attempted with this being the only plugin enabled and the result is consistent.
Here is my plugin config:
    {
      "eero-lehtinen/oklch-color-picker.nvim",
      event = "VeryLazy",
      keys = {
        { "<leader>v", "<cmd>ColorPickOklch<cr>", desc = "Color pick under cursor" },
      },
      opts = {},
    },

I'm getting the following message upon opening neovim..
oklch-color-picker: Downloading parser...
oklch-color-picker: Parser downloaded
oklch-color-picker: Couldn't load parser library

Let me know what steps to take, thanks!

What is your OS? Is your CPU ARM or x86? I haven't tested the parser library with ARM so it's possible that I need compile it specifically for ARM, though it should work through emulation.
You could also check that the parser_lua_module has actually been downloaded to the ~/.cache/nvim/lazy/oklch-color-picker.nvim directory.
In that directory, there should also be oklch-color-picker binary, try to run it directly to check if it runs at all. If not, then it's likely that my programs are compiled wrong.

I added some extra logging for the parser loading just now. So you could update the plugin and try
opts = {
  log_level = vim.log.levels.DEBUG,
},

and see what it says.

alrighty, here's the log:
oklch-color-picker: Parser load failed:
"error loading module 'parser_lua_module' from file '/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib':\n\tdlopen(/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib, 0x0006): tried: '/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib' (no such file), '/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))"
oklch-color-picker: Downloading parser...
Restored session: /Users/asilva/.config
oklch-color-picker: Parser downloaded
oklch-color-picker: Parser load failed:
"error loading module 'parser_lua_module' from file '/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib':\n\tdlopen(/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib, 0x0006): tried: '/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64')), '/System/Volumes/Preboot/Cryptexes/OS/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib' (no such file), '/Users/asilva/.local/share/nvim/lazy/oklch-color-picker.nvim/parser_lua_module.dylib' (mach-o file, but is an incompatible architecture (have 'x86_64', need 'arm64'))"
oklch-color-picker: Couldn't load parser library

looks like it needs arm64 target

I added a build for ARM. Could you update and try again? I don't have a device to test on.

it worked! thank you!

Nice! Thanks for testing and reporting. It would have been hard by myself.


How to manually display the turbolinks loader bar in non-turbolinks ajax callbacks ?

Hi all!
Neat repo maintenance :+1:
So, I have a list page with a filter form that makes an ajax request and replaces part of the body every time the user changes a filter value.
Is it possible to trigger the turbolinks loader bar, as-if it was a normal turbolinks request ?
Thanks in advance
Keep up the great work :tophat:

I think a better place for such questions is https://discourse.stimulusjs.org/.
Have a good one.

Thanks for the heads up @sigfrid
Have a great day


Storyboard issue with 1.1.1

In  initialViewController-method is missing a return value.
extension StoryboardSceneType {
  static func storyboard() -> UIStoryboard {
    return UIStoryboard(name: self.storyboardName, bundle: nil)
  }

  static func initialViewController() -> UIViewController {
    guard let vc = storyboard().instantiateInitialViewController() else {
      fatalError("Failed to instantiate initialViewController for \(self.storyboardName)")
    }
  }
}

The fix is already submitted in #138.

Good catch. closing this issue as someone already suggested a PR #128 to fix though.


Video plays at first, then stop working after few seconds.

It automatically stop playing video after few seconds, I can't play neither pause. Please, I'm not a backend developer, I would prefer a basic solution to this.
Thanks.

@holuwadamilare Are you still having this issue?

@holuwadamilare Is this still an issue? Can I close this ticket? Thank you!

Closing the ticket due to a lack of feedback over an extended period. Please feel free to reopen if you have further input or require additional assistance. Thank you.


Encrypted traffic

complete pull request with a pcap that sets metadata and another one that doesn't

I changed the original code from Vaughn Adam's to fire for intermediate logger reporting as well, previously it was only for final reporting. I left the comment in there to make it obvious for the community that they can change it in case of performance need.

@Shweta, @craig, @dan
I have changed back the logic so it only fires at session end.  The reason why it didn't work for me was that I tested it in the following scenario ... (at least this is the working theory right now)
1 engine thread
no other traffic
every X seconds upload a tcp fluff file and the https file

With no other traffic the engine could not "expire" the https flow.
When the packets were uploaded the expiration could happen but since the https pcap was re-uploaded too the Engine decided to ignore the FIN-ACK and instead continue the session.
Technically I do consider this a bug but it's not of big importance. A better test scenario would be the following
1 thread
no other traffic
continous upload of 1 or more fluff pcap traffic (tcp or similar)
Only do 1 upload of the https pcap

I'll verify this today.

Qosmos has confirmed that they have a bug for https: https://eu3.salesforce.com/500w000001IC9Oa

No, please revert.

Why?

There is a security vulnerability.

? Please explain over flowdock

The problem is you're asking the wrong craig for advice here! :P

Ha ha. Thanks. Either way we cleared it :)


Interactive Tutorial - Creating a Cluster

Creating Cluster page doesn't show any terminal.

It's working for me

Os: Ubuntu 18.04
Browser: Chrome 97.0.4692.71
Seems like network issue. Please try on different network.

I had tried on a different network and got the same problem. But today it seems to be working.


home-assistant: relax dependencies

Motivation for this change

Relaxes a few dependency constraints to fix nixosTests.home-assistant.
home-assistant itself is broken by aiopvapi @fabaff

Meh. Not sure if this is possible to fix on master...
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Meh. Not sure if this is possible to fix on master...

Me neither. For now, I'm working on fixing the deps which were affected by async_timeout-4.0.1 and aiohttp-3.8.0. I had to push back httpx>0.2x.x. as there is an overlap with aiohttp/async_timeout.
There is a big chance that we need a couple of new overrides for 2021.12.x. I will get to that if I have a "base line" established.

I'm running nixos-21.11 on aarch64 and home-assistant doesn't build without the changes in this PR because it there is no aiohttp-3.7.4.post0
Is it possible to merge this into 21.11?

I can look into that in a bit. In the meanwhile please check out https://nixos.wiki/wiki/Home_Assistant#Running_a_recent_version_using_an_overlay, because we cannot update home-assistant on release branches.

Sorry, the async_timeout fallout radius is too big and I think it shouldn't have landed before the branch-off. @dotlambda

Sorry, the async_timeout fallout radius is too big and I think it shouldn't have landed before the branch-off.

Sorry for that.
I don't think reverting https://github.com/NixOS/nixpkgs/pull/145602 is an option either, so I suggest we mark home-assistant as broken. It would be nice if we could make the error message refer people to the wiki.

Maybe we can, within home-assistant, override aiohttp and async_timeout to make it work again? https://github.com/NixOS/nixpkgs/pull/148242


Replace Safe logo in the header

Add new logo without "Multisig".
Not sure if it has the right size.

Maybe we can increase the size a bit more:
src/components/AppLayout/Header/components/Layout.tsx (line 41)
flexBasis: '130px',

Agree. Looking at it for a while, it does look a bit small. I think 140px looks best.


Add record all button

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2333
Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

what issue is this linked to?

found and added


Provide a button to trigger an auto-mapping of fields

when mapping data from 2 metamodel that are quite close, there are often same naming used between several fields of source and target.
It would be nice to provide a way to trigger an auto-mapping for all fields that have the same name. It can save a lot of time to users.
Thinks to consider:

different data type? maybe first version only when same data type and a second providing a transformation automatically also when possible or do the mapping and user will have validation error to fix?
match ignoring case?
do the mapping only when there is no ambiguity?

You'd want to implement metadata model analyzer engine first, and then AtlasMap would be able to leverage it. I don't think we want to implement it inside AtlasMap. Closing.


Zapier block to chat with a Dust assistant

Some context:
https://dust4ai.slack.com/archives/C06R2G0J466/p1724417373047639?thread_ts=1724363403.231709&cid=C06R2G0J466

Don here.


Reach full compatibility with flow

So there is the choice when an unsupported feature or annotation is encountered between ignoring and showing a warning (I didn't want to investigate if there is a non-error way of showing a message through Babel so I opted for throwing).
Silently ignoring annotations has the downside of being confusing for users. I don't know what different people look for in this plugin but likely many will want something simple and predictable without having to learn how Flow works. If we cater for this case then it's important to warn users about cases where no type check will be performed despite an annotation being present.
Flow rejects language features it doesn't support - the idea is to provide a very good guarantee that the program will work or give an error. So you can't use this plugin together with Flow to cover cases it doesn't support. If a Flow check succeeds then there will be no type error exceptions of the kind our plugin produces.
From our side silent failures are contrary to how Flow is meant to work.
So I want to understand your aim regarding this - how should this be compatible with Flow?

I want people to be able to use all of the annotations which flow supports, with the view that this plugin will support those constructs in future. We should never prevent the programmer from using something which is valid flow syntax.
Since we can't support everything all at once, let's introduce an environment variable, TYPECHECK_STRICT which throws on unsupported constructs. We could log unsupported annotations to stderr by default, or introduce another env var - TYPECHECK_VERBOSE which turns that on/off

3.0.0 now supports just about all of Flow's features, closing this for now until specific examples crop up.

We still generate broken code for things like:
function each<X> (arr : Array<X>) {
  arr.forEach((el : X) => f(el))
}

I added an error for this case before, because it's better than trying to generate code for it or silently ignoring it.
I'm trying to understand if you're saying we should allow users to use things like f<X> : (Array<X>, ...) => ... and just ignore them.
I've looked over what you added for v3 (great work!); the fact remains that this plugin can only do shallow type checks and we can't support all Flow features (like polymorphic functions or arrays with a type param).
We should by default reject Flow syntax and features we don't/can't support.
The job of a type checking system is to generate guarantees. We need to translate every annotation into a guarantee. If we can't, we should reject the annotation.
(Like you said, there could be a config to disable errors on unsupported features. Though I think if someone wants to use Array<X> as a form of documentation they should write Array/*<X>*/)

(we do now support arrays with type parameters, we generate an arr.every() call).
It's true that we don't produce checks for polymorphic types, there is a way to do it but it's extremely ugly. I don't want to prevent or discourage people from using those annotations though. Polymorphism is a fact of life in JavaScript, people need to be able to annotate those things so that they can also use flow and to communicate that information to other humans. The annotation is still valuable, even if the check is not enforced.
I don't want it to be a default, but since Babel now has a way of specifying plugin options, please feel free to add an optional strict mode which enforces this. We can also do a better job of explaining the limitations in the README.

Alright, I'll see how it works out for my team.
I see I misunderstood the behavior of the type variable above. Though we still have a problem in that the inner el : X generates a check even though the X refers to the type variable.

Implementing type variable checking could potentially be easy: generate a stateful check function when a variable gets introduced to do "runtime unification"
var X = typeVarChecker()
if([...] arr.every(X))

But let's not

yeah i worry that the contortions we'd need to go to to support that are just not worth it, particularly for classes. We should be able to reliably track references to polymorphic types though so please file an issue if it generates the wrong check for the example you provided.

This was impossible without a runtime library, however it is the goal of https://codemix.github.io/flow-runtime


April 29 - C&C

Event Information

Category
Details

Stream Date
April 29, 2021

Stream Time
9:00 AM

Title
Generic

Description
Generic

Speaker
---------

SharePoint ID
13011

SharePoint Status
Planning

Additional Resources:

Event Checklist
10 Weeks Prior

[ ] Title & Description Finalized
[ ] Tracking Links/Short links
[ ] Published
[ ] Calendar Invite

Yes...


Change preventing accidental new mail discard

Hi,
I added a confirm dialog if accidently pressed discard menu entry in the message compose string. The dialog is default on and can be disabled in global settings > interaction > notifications
Cheers
Joerg
P.S: Being new on github. Once you accepted the pull (and if I need space), can I delete my fork ?

There are some code style issues. Please read the code style wiki page.
Please only add/change English strings. We use Transifex for translations (and there's no two-way sync).

I just saw the comments and removing the values-de string. Now on the branch it should be in good shape. Or see https://github.com/jcontno/k-9/commit/57c3d0a4249f9577f984897ed43b62df16a78be8
Am sorry I don't know what to do at transifex, maybe someone else can add the line or give me a specific pointer.
Good now ?

You don't use the framework to display the dialog. This won't recreate the dialog when you rotate the device. See MessageCompose.onCreateDialog()
When adding a global setting one also has to add it to com.fsck.k9.preferences.GlobalSettings so import/export will work.
In my opinion a simple "Discard message" works better than "Discard at Message Compose Menu".

I know it's a lot of work for such a simple feature. But don't let this discourage you. Once you're done you will be one of the 100+ people who contributed to K-9 Mail. Bragging about that is strongly encouraged :)

I've done the changes myself.
https://github.com/k9mail/k-9/commit/10cb346c198b481c01958ffa3fca6de4b926b78c


how to update faster-whisper?

I installed the master version
Install the master branch:
pip install "faster-whisper @ https://github.com/guillaumekln/faster-whisper/archive/refs/heads/master.tar.gz"
and how to update it?
thank you.

You can use the flag --force-reinstall:
pip install --force-reinstall "faster-whisper @ https://github.com/guillaumekln/faster-whisper/archive/refs/heads/master.tar.gz"


cytoscape.js-elk / web worker dependency

In the elkjs documentation it is said :

A warning is raised if one requests a web worker without having installed the package. elkjs falls back to the non-Web Worker version in that case.

But when I try to do so, using cytoscape.js-elk, I get an error :
Failed to compile. <path>/node_modules/elkjs/lib/main.js Module not found: Can't resolve 'webworker-threads' in '<path>\node_modules\elkjs\lib'

This is fixed by #5 but it seems as though the code in the npm registry has not been updated yet. As a workaround, you can install the dependency straight from github, which is what I did because I just wanted to try to library out:
yarn add https://github.com/jfstephe/cytoscape.js-elk#master


node lts is now 14.15.1

Since node LTS is 14.15.1 this image is no longer nodejs 12 npm 6. Would it be possible to update the image to use node 12-slim or similar?
Our build is failing because of a dependency "node-sass" build errors. Aparently node-sass doesn't support node 14.15.1.

Node-Sass should support Node 14 (https://github.com/sass/node-sass/issues/2895)
Could you please try:

Install node 14 locally
Delete node-modules/package-lock.json
npm install

Thanks! We ended up having to update most of the packages (node-sass, fsevents, grpc, firebase etc) to support LTS :)

We are happy this worked out for you!
On the long run it is better to update very now and then instead of waiting until the app is beyond expiration ;)
I will close the issue please reopen if we forgot an important aspect.


MacOS non-native fullscreen mode - additional configuration options

In MacOS non-native fullscreen mode, there are a couple of other possible configurations that people might like to use:

Leaving padding around the MacBook display notch, if present
Keeping the menu bar visible (which also achieves padding around the notch, but is aesthetically quite different)

We can expand the existing macos-non-native-fullscreen option. Here's a proposal / TODO list:

[x] not specified OR false: use native fullscreen
[x] true: hide title bar, don't pad around notch
[x] visible-menu: go fullscreen, but don't hide the menu bar
[ ] notch-padding: hide the menu bar, but fill it in with blank space if there's a notch

It's trivial to size the terminal frame to respect the notch, but by default I think the user's desktop background will show through in the padding area, so there's a little bit of extra work needed to fill in that padding with black, but that can be done separately if needed.
Related issues:

#319
#343

It seems that the notch-padding feature was lost in the fullscreen reimplementation in 718fa6042c7b2488de2123c8f8283d1052ae3596. Might this come back sometime soon? :)


examples do not run

Describe the bug
Kepler.gl examples do not work
To Reproduce
Steps to reproduce the behavior:

Go to 'examples/openmodel'
run yarn start
See error

WARNING in<EMAIL_ADDRESS>437:22-38 "export 'getWorldPosition' was not found in 'viewport-mercator-project'

WARNING in<EMAIL_ADDRESS>22:27-39 "export 'experimental' was not found in 'math.gl'

WARNING in<EMAIL_ADDRESS>22:27-39 "export 'experimental' was not found in 'math.gl'

WARNING in<EMAIL_ADDRESS>37:27-39 "export 'experimental' was not found in 'math.gl'

WARNING in<EMAIL_ADDRESS>37:27-39 "export 'experimental' was not found in 'math.gl'

WARNING in<EMAIL_ADDRESS>10:27-39 "export 'experimental' was not found in 'math.gl'

Expected behaviour
Example should have worked.
Desktop (please complete the following information):

OS: macos
Browser chrome
Version latest

please delete your node_modules and yarn.lock and run yarn --ignore-engines there seems to be a conflict in your modules

@varunpant Closing it now, let me know if you were able to fix it


Add v-tooltip

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adding support for Azure Firewall to NetworkConnectiontoOMIPorts Hunting Query

Added Azure Firewall query to find attacks targeting OMI vulnerability (CVE-2021-38647) in DNAT traffic.
Fixes #
Proposed Changes

Added Azure Diagnostics query to detect connection attempts from the external IP addresses to the management ports(5985,5986,1270) related to Open Management Infrastructure(OMI) through DNAT rules in Azure Firewall.

Issue in the PR.  Will close this one and create a new one.


Fatal error when refresh token is experied

Hi. When I try to renew a token which is expired :
Catchable Fatal Error: Object of class Gesdinet\JWTRefreshTokenBundle\Entity\RefreshToken could not be converted to string

=> vendor/gesdinet/jwt-refresh-token-bundle/Service/RefreshToken.php at line 70
I guess toString method should be implemented.

You're right. When RefreshToken is invalid or doesn't exists, it throw a AuthenticationException, and we need to implement toString() method in RefreshToken entity.
if (null === $refreshToken || !$refreshToken->isValid()) {
            return $this->failureHandler->onAuthenticationFailure($request,
                new AuthenticationException(
                    sprintf('Refresh token "%s" is invalid.', $refreshToken)
                )
            );
}

We solved in last commit #


Testing of login functionality - automated and manual

[x] Test registration
[x] Test login

committed to test_user_login branch, 3 tests for each. Are there any others I should add?


Add/refactor compareSpectriPy function

This PR contains work from @chufz . It:

adds the compareSpectriPy function and refactor to use basilisk and param classes (issue #11)
adds paramter objects for matchms CosineGreedy, CosineHungarian, ModifiedCosine and NeutralLossesCosine (not yet exported because not part of the matchms official release yet.
adds unit tests for all functions.
adds documentation and vignette.

@lgatto , just a heads-up if you also want to have a look at it.

Did I get it right that it only works with Spectra 1.5.13 (github) but not the bionductor release?

@chufz

Did I get it right that it only works with Spectra 1.5.13 (github) but not the bionductor release?

I usually develop always for devel version. In this case we however use no specific new features of Spectra, so it should work also with the BioC release version.

@hechth , can you please have another look?

@jorainer sorry for the delay, I'll check the code now on my machine to see how it works (dependencies and stuff) and then we can merge I think 👍

@jorainer How long are the release cycles between GitHub and Bioconductor? Because this also hinders using a conda environment for development. Bioconductor is actually mirrored to conda, so once the package is in bioconductor it is also available via bioconda.

Is it actually possible to pass the R CMD check . command etc. while not having an Author or Maintainer field, but only the Authors@R? I've struggled with that before and it seems that this is also the case here that R CMD check actually fails due to this.

Trying to answer all questions @hechth :

BioC release cycle is 2 times per year. Next release will be in about 3 weeks or so. So we wan't be able to get into that release.
Package versions: yes, we use MAJOR, MINOR, PATCH. But what complicates it is that Bioconductor increments the MINOR with each release cycle, and from the moment you have the package in Bioconductor you should only update the PATCH (well, adding new features should only be done in the devel branch and bug fixes in the release branches...).
Regarding R CMD check - I usually start R within the package folder and run rcmdcheck::rcmdcheck() instead. That usually works well.

Wow, releasing two times per year is super slow - is that a fixed decision?

Yep. R has an annual release cycle, BioC has 2 times per year. Think it would not be possible to have more frequent updates, the core BioC team has all hands full managing these. It's always stressfull ~2 months before each release.

That is interesting. We have everything on bioconda directly which is automatically linked to GitHub, so whenever we draft a new release there it is available via bioconda the next day.

Ah, I see. Also with BioC any bug fixes/updates are available within ~ 1-2 days in BioC. It's not linked to github, but you need to push to the official BioC git server and the packages are checked and build for all 3 platforms.

So it would actually be possible to update the version of Spectra on Bioconductor by pushing to their git repo?
Can't this also be automated via GitHub release actions? Shouldn't be too difficult I think.

Exactly. Well, yes, I guess it would be possible with github release actions. But I'm maybe old fashioned here - I like to push manually to the BioC git once I see that all things on github are ~ OK (sometimes CI with GHA fails because there is some upstream error etc).


Allowing combining multiple inputs in a single transaction

According to @dacoinminster, currently it is not possible to do a simple send that combines multiple inputs (possibly only for inputs with different addresses - J.R can you clarify this point?).
This means that a user that have multiple inputs in his wallets with different balances, he would need to create multiple send operations (and pay more fees) in order to send these funds. Also the recipient will then have multiple inputs himself, and will have to spend more fees to move them.
I think this should be addressed at the spec level first, and then added in the various wallets.

So, is that possible having X addresses to combine inputs and send it to some address?
i.e. we have 5 addresses and want to send all of the funds to another address. As I understand from this thread I will have to make 5 transactions paying fees 5 times.


Aseprite palette support would be nice

I mostly use Aseprite these days (hence slight neglect of calico) and supporting its palette format would be very nice indeed.

I ported the program to Attoparsec which is better suited for binary parsing.

implemented!


Newbie gold is not consumed on NPC's TRAIN command

Create a character
Ask any NPC to train in some skill.
Use the newbie gold.
Result: NPC doesn't take the gold but you get the skill trained.

for me too it works fine, i have noticed that if you give more money to the trainer (Ex 51 instead of 41) the remaining 10 golds get dropped on the ground.

#176 also here the change problem

video here https://streamable.com/3ordd

no idea what, but it looks fixed for some reason?
still change getting dropped to feet but that's a different issue.


MINIFICPP-1611 Update AWS SDK to latest released version

Version 1.9 of the AWS SDK C++ library introduced S3 CRT client which is built on top of AWS Common Runtime (CRT). This introduced some dependency changes that needed to be resolved when upgrading to the latest version.
https://issues.apache.org/jira/browse/MINIFICPP-1611

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

Did you check for LICENSE or NOTICE changes?

Did you check for LICENSE or NOTICE changes?

I checked and there were no LICENSE file changes in the past years, AWS SDK still uses the Apache-2.0 License. There were no NOTICE changes either in the past year, the same third party components are listed as before, we have all of them listed in our NOTICE as well.

LGTM, nice to see that it makes things even more simple!


Add support to AsyncClient for handling out of order responses (prototype attached)

Problem: Some RPC calls might themselves take a long time to process on the server side.  It would be nice if the client could dispatch multiple calls concurrently without the assumption that responses will come back from the server in the order they were sent, and then match incoming responses to the correct requests.
Here's a prototype I came up with using websockets.  It does a few things a bit hackishly in order to be able to easily subclass WebsocketClient, and doesn't yet support batch requests.  But I think this functionality could easily be implemented directly in AsyncClient:
import asyncio, websockets, json
from jsonrpcclient.clients.websockets_client import WebSocketsClient
from jsonrpcclient.response import Response

class WebSocketsMultiClient(WebSocketsClient):
    def __init__(self, socket, *args, **kwargs):
        super().__init__(socket, *args, **kwargs)
        self.pending_responses = {}
        self.receiving = False

    def __enter__(self):
        self.receiving = asyncio.ensure_future(self.receive_responses())
        return self

    def __exit__(self, *args):
        self.receiving.cancel()

    async def receive_responses(self):
        while True:
            response_text = await self.socket.recv()
            try:
                # Not a proper JSON-RPC response so we just ignore it
                # since during this mode all messages received from the
                # socket should be RPC responses
                # NOTE: We can avoid having to re-parse the response if this functionality
                # were built directly into AsyncClient.send, for example.
                response = json.loads(response_text)
                response_id = response['id']
                queue = self.pending_responses[response_id]
            except (json.JSONDecodeError, KeyError):
                continue

            await queue.put(response_text)

    async def send(self, request, **kwargs):
        # Override AsyncClient.send to also pass through the request's ID to send_message
        kwargs['request_id'] = request.get('id', None)
        return await super().send(request, **kwargs)

    async def send_message(self, request, response_expected, request_id=None, **kwargs):
        if response_expected:
            queue = self.pending_responses[request_id] = asyncio.Queue()

        await self.socket.send(request)

        if response_expected:
            # As a sanity measure, wait for both the receive_responses task and
            # the queue.  If the receive_responses task returns first that
            # typically means an error occurred (e.g. the websocket was closed)
            # If the completed task was receive_responses, when we call
            # result() it will raise any exception that occurred.
            done, pending = await asyncio.wait([queue.get(), self.receiving],
                    return_when=asyncio.FIRST_COMPLETED)

            for task in done:
                # Raises an exception if task is self.receiving
                result = task.result()
                if task is not self.receiving:
                    response = result

            del self.pending_responses[request_id]
            return Response(response)
        else:
            return Response('')

This is used like:
with WebSocketsMultiClient(websocket):
    # Make RPC requests here

While in the context manager of the client, the client handles all incoming messages in the receive_responses loop and adds them to a queue for each pending response.  Messages that aren't expected RPC responses are ignored (TODO: One could easily register a fallback handler for this case as well.)
Here's a full client example:
async def main():
    async def ping(client, message):
        print(f'pinging with message: {message}')
        response = await client.ping(message)
        print(f'response from ping {message}: {response.data.result}')

    async with websockets.connect('ws://localhost:5000') as ws:
        client = WebSocketsMultiClient(ws)
        with client:
            await asyncio.gather(*[ping(client, n) for n in range(10)])
loop.run_until_complete(main())

And a corresponding server implementation that can handle multiple ongoing RPC calls:
import asyncio, websockets, random
from jsonrpcserver import method, async_dispatch as dispatch

@method
async def ping(message):
    # Simulate some work
    wait = random.randint(0, 30)
    await asyncio.sleep(wait)
    return f'pong {message} after waiting {wait} seconds'

async def dispatch_request(queue, request):
    response = await dispatch(request)
    if response.wanted:
        await queue.put(response)

async def handle_requests(websocket, queue):
    while True:
        try:
            request = await websocket.recv()
        except websockets.ConnectionClosed:
            break
        print(f'received ws request {request}')
        asyncio.ensure_future(dispatch_request(queue, request))

async def handle_responses(websocket, queue):
    while True:
        response = await queue.get()
        try:
            await websocket.send(str(response))
        except websockets.ConnectionClosed:
            break

async def main(websocket, path):
    queue = asyncio.Queue()
    await asyncio.gather(
        handle_requests(websocket, queue),
        handle_responses(websocket, queue))

start_server = websockets.serve(main, 'localhost', 5000)
loop = asyncio.get_event_loop()
loop.run_until_complete(start_server)
loop.run_forever()

Some sample output from the client side:
pinging with message: 7
pinging with message: 1
pinging with message: 2
pinging with message: 6
pinging with message: 4
pinging with message: 3
pinging with message: 0
pinging with message: 5
pinging with message: 9
pinging with message: 8
response from ping 1: pong 1 after waiting 1 seconds
response from ping 5: pong 5 after waiting 1 seconds
response from ping 8: pong 8 after waiting 6 seconds
response from ping 0: pong 0 after waiting 8 seconds
response from ping 7: pong 7 after waiting 12 seconds
response from ping 4: pong 4 after waiting 18 seconds
response from ping 3: pong 3 after waiting 18 seconds
response from ping 9: pong 9 after waiting 23 seconds
response from ping 2: pong 2 after waiting 29 seconds
response from ping 6: pong 6 after waiting 29 seconds

I think this is a valuable use-case and I was surprised I couldn't easily find much else like it already existing, at least for Python.
Update: Fixed an issue where if an error occurred in receive_responses, send_message could block forever waiting for an item on the queue that never arrives.  When awaiting queue.get() always check for errors on the receive_responses task as well (e.g. if the websocket connection closes before the response is received).

Great work. I'm surprised this is not included in jsonrpc by default. Websocket responses are not necessarily the next message recv'd.

@delaaxe Thanks--I've been meaning to open a PR to add this as a standard feature, but in the meantime you can use code like I posted above.

Thanks, I actually used this successfully! Added a callback to the constructor to be notified on "non-response" messages

@delaaxe Cool! Thanks for the feedback.

Clients being removed from v4. Transport will be handled by the user. https://github.com/explodinglabs/jsonrpcclient/discussions/171


Requeue reason metric

Description
We should add a metric to track the reason of requeue in Kyma control loop.
Name: lifecycle_mgr_requeue_reason
Add labels for reason accordingly
Reasons
As of now we can observe an increase of immediate requeues in lifecycle-manager's control loop of Kymas, as a result of returning ctrl.Result{Requeue: true} in various places.
We are interested in the reason of these requeues to figure out which ones are the most frequent ones and how to adapt them, because they may be flooding the worker queues for no valid reason.
Acceptance Criteria

[ ] Acceptance criterion 1
[ ] Acceptance criterion 2

Feature Testing
No response
Testing approach
No response
Attachments
No response

success requeue on STAGE between 11.17.2023 to 03.12.2023


Understanding what Mutexes are and its uses

Related Issue
Closes #8
Type of Change
Documentation Update
Description of Change
Understanding mutexes
Implementation Detail
Understand mutexes in an easy way without getting into code that much, I didn't covered other formats for now, but I am learning those as well and If wanted ill add those to this as well

Hey can you rename your file to Mutex_<your_name> so we know the differences as I will allow more people to get it


Introduce support for Select entities, and add use_mode

First off, I got a bit carried away on my day off. I'll be quite understanding if you don't want to accept this!
I wanted to be able to see and change the Work Mode (since it's an agent-only setting, which is settable through modbus). One thing led to another, and...

I've tried to split it into fairly independent commits -- it should be easiest to review them one-by-one.

@canton7 - absolutely fantastic change, thank you!

Thank you!
I broke your lints though... I'll get in a PR to fix those in a min

Thank you!
I broke your lints though... I'll get in a PR to fix those in a min


Minor BIRD guide improvements

Coverage decreased (-0.008%) to 37.023% when pulling 763c6c862950fa55a75a6f28d90e1421f0105c38 on joestringer:submit/bird-fixups into c216dfb3ad911ca5ba7659b6266109c8c6882d70 on cilium:master.


Build failure upon first build. Having to remove derive data after the first configuration.

Hello, following the documentation specified here I get a random compilation error once I have included my pod dependencies, closed and restarted xcode.
Steps to reproduce

Create a new project (iOS13.2, SwiftUI). Check the device you have selected. By default it should pick your connected device or a simulator (such as iPhone 11).
Create a podfile (pod init) at the project's root folder.
Include the dependencies for     amplify-tools, Amplify, AWSPluginsCore, AmplifyPlugins/AWSAPIPlugin as instructed.
Call pod install --repo-update as instructed.
Open the workspace associated with your project xed .
Try to build (cmd+b). This step fails with the following error:

Switch to a different device/sdk and compile again. This fixes the issue.

Expected behaviour
The build process works when the workspace is opened on its default architecture.
Actual behaviour
The build process fails for the selected by default architecture and the solution is to switch to a different architecture/device or remove derive data (closing xcode and reopening).
Additional info
Once derive data has been dropped and recreated, it seems to be working fine.

By the way, to recover the device you need to delete your derived data folder. This is incredibly annoying.

@rodrigoelp I believe this is no longer an issue in Amplify v1.0.0. Feel free to re-open if you're still experiencing problems.


Handling SIGINT properly

Title
Handling SIGINT properly
Summary
When a signal is received, the server is finished without properly closing it.
Why?
When requests still open, closing the server will break the client.
How
Close the server after a signal is received.
Acceptance criteria
[ ] Send a request to a slow endpoint. Send a signal. The server should not die unless a timeout.
Additional Information

Hi,
yup thanks for issue! i am aware of this.

@p53 what is the releasing process for this feature? Do you have a ETA?

@arielmorelli I can release it today/tomorrow, will add some updates to deps


Bugfix/hotspot onboarding

During hotspot onboarding, it was possible to double click any of the buttons which would cause various errors along the way.
This PR creates a higher-order component that debounces button clicks. I've created "debounced" versions of our buttons and converted the hotspot onboarding process to use them.

I think debouncing is a good strategy in general -- we may want to just make that a default behavior of our main button/touchable box components. I don't see a case where we wouldn't want it. Additionally, I'm wondering if during onboarding or any case where destructive things are happening if we should use the strategy of disabling the button until the task completes or fails? I'm pretty sure we do that in some places, but I'm sure it could be added elsewhere.

I think debouncing is a good strategy in general -- we may want to just make that a default behavior of our main button/touchable box components. I don't see a case where we wouldn't want it. Additionally, I'm wondering if during onboarding or any case where destructive things are happening if we should use the strategy of disabling the button until the task completes or fails? I'm pretty sure we do that in some places, but I'm sure it could be added elsewhere.

I agree about using the debounce as the default. I just think we'd need to thoroughly test the app after making the cutover. I'd prefer to merge this PR to see if it helps Nebra, then convert all buttons in a separate PR.

I think debouncing is a good strategy in general -- we may want to just make that a default behavior of our main button/touchable box components. I don't see a case where we wouldn't want it. Additionally, I'm wondering if during onboarding or any case where destructive things are happening if we should use the strategy of disabling the button until the task completes or fails? I'm pretty sure we do that in some places, but I'm sure it could be added elsewhere.

I agree about using the debounce as the default. I just think we'd need to thoroughly test the app after making the cutover. I'd prefer to merge this PR to see if it helps Nebra, then convert all buttons in a separate PR.

fair enough


Add back multiline support

It seems to be that multi-line command where supported in an older version (https://github.com/denisidoro/navi/issues/88).
Is that a feature that will be coming back? I can also try to implement it and open a pull request but want to make sure that this is a feature that is actually wanted first.
Thanks for all your work its a nice tool :D

Right now multiline commands look like this which I dont think is super usefull:

I'm not totally sure how to display multiline commands yet.
Maybe displaying the newlines as \n in the command would be good enough for now. I think making sure that the newlines are put back when the command is printed/executed would be a good idea so that snippets that rely on newlines to be correct are still working.

You can write multi-line commands using \
Could you share your .cheat?

I'm working on a PR that doesn't require \

Thank you for the quick response