using SafeERC20 to implement safeTransfer in Crowdsale

Fixes #946
🚀 Description
Using SafeERC20 to implement safeTransfer in Crowdsale.sol

This is a follow on to address the unchecked return value in AllowanceCrowdsale.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] 📖 I've made sure that my contracts are well-documented.

Oops! My mistake. I've made the changes locally, but when I run the tests I get this error "Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000".
I've restarted Ganache so the accounts refill their ETH and still get the error.
Any thoughts? Thanks in advance!

Thanks for the note, @frangio!
@elopio - It's funny, I've made the change locally, but still see the same error when running the Crowdale.sol's unit tests?

@dougiebuckets may be a truffle caching issue; I have a command like
function nuketruffle() {
  rm -r build
  truffle compile
}

that I use before testing any changes. Let me know if that was the issue?

@shrugs Appreciate the suggestion. Unfortunately, I still see the issue after clearing the build directory. I've tried running tests for all of the contracts and I see similar issues w/ other crowdsale contracts. For instance,
`1) Contract: Bounty
Against secure contract
cannot claim reward:
AssertionError: expected '1000000000000000000' to equal<PHONE_NUMBER>000000000
at _callee3$ (Bounty.test.js:59:16)
at tryCatch (/Users/Doug/Desktop/openzeppelin-solidity/node_modules/regenerator-runtime/runtime.js:65:40)
at Generator.invoke [as _invoke] (/Users/Doug/Desktop/openzeppelin-solidity/node_modules/regenerator-runtime/runtime.js:303:22)
at Generator.prototype.(anonymous function) [as next] (/Users/Doug/Desktop/openzeppelin-solidity/node_modules/regenerator-runtime/runtime.js:117:21)
at step (Bounty.test.js:3:191)
at Bounty.test.js:3:437
at new Promise ()
at Bounty.test.js:3:99
at watcher (Bounty.test.js:45:31)
at wrappedHandler (Bounty.test.js:15:23)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/filter.js:102:1
at Array.forEach ()
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/filter.js:101:1
at Object.callback (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/filter.js:225:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/method.js:142:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:89:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: CappedCrowdsale
accepting payments
should accept payments within cap:
AssertionError: expected promise to be fulfilled but it was rejected with 'Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000'

Contract: CappedCrowdsale
accepting payments
should reject payments outside cap:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>00000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: CappedCrowdsale
accepting payments
should reject payments that exceed cap:
AssertionError: expected promise to be rejected with an error including 'revert' but got 'sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>00000000001 and the sender's account only has:<PHONE_NUMBER>0000000000'

expected - actual

-sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>00000000001 and the sender's account only has:<PHONE_NUMBER>0000000000
+revert

Contract: CappedCrowdsale
ending
should not reach cap if sent under cap:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: CappedCrowdsale
ending
should not reach cap if sent just under cap:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>99999999999 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: CappedCrowdsale
ending
should reach cap if cap sent:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>00000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: Crowdsale
high-level purchase
should forward funds to wallet:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: Crowdsale
low-level purchase
should assign tokens to beneficiary:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: Crowdsale
low-level purchase
should forward funds to wallet:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: PostDeliveryCrowdsale
should allow beneficiaries to withdraw tokens after crowdsale ends:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: PostDeliveryCrowdsale
should return the amount of tokens bought:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: RefundVault
should refund contribution after entering refund mode:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: RefundVault
should forward funds to wallet after closing:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: RefundableCrowdsale
should forward funds to wallet after end if goal was reached:
Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000
at Object.InvalidResponse (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
at /usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
at /usr/local/lib/node_modules/truffle/build/webpack:/~/truffle-provider/wrapper.js:134:1
at XMLHttpRequest.request.onreadystatechange (/usr/local/lib/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
at XMLHttpRequestEventTarget.dispatchEvent (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
at XMLHttpRequest._setReadyState (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
at XMLHttpRequest._onHttpResponseEnd (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
at IncomingMessage. (/usr/local/lib/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
at endReadableNT (_stream_readable.js:1101:12)
at process._tickCallback (internal/process/next_tick.js:114:19)

Contract: WhitelistedCrowdsale
many user whitelisting
accepting payments
should accept payments to whitelisted (from whichever buyers):
AssertionError: expected promise to be fulfilled but it was rejected with 'Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000'

Contract: WhitelistedCrowdsale
many user whitelisting
accepting payments
should reject payments to addresses removed from whitelist:
AssertionError: expected promise to be fulfilled but it was rejected with 'Error: sender doesn't have enough funds to send tx. The upfront cost is:<PHONE_NUMBER>0000000000 and the sender's account only has:<PHONE_NUMBER>0000000000'`

@dougiebuckets make sure you're not running a separate ganache/testrpc client on port 8545 so the testing script starts its own version with hella ether in the testing accounts

@shrugs Thanks for the tip! I went ahead and set the default balance in Ganache to 1000 using ganache-cli -e 1000. Also, I accidentally closed this PR. So I went ahead and created a new one here https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1006 Sorry for the confusion


cert-manager RBAC not updated on eksctl upgrade

What happened:
My EKS Anywhere cluster was running on an older version of Kubernetes, which was bundled with this version of cert-manager:
public.ecr.aws/eks-anywhere/jetstack/cert-manager-controller:v1.1.0-eks-a-1

I then upgraded my EKS Anywhere cluster to 1.21.5 using eksctl upgrade, which bumped me to:
public.ecr.aws/eks-anywhere/jetstack/cert-manager-controller:v1.5.3-eks-a-6

However, none of the RBAC changes were added in. This newer version of cert-manager has quite a few changes in RBAC, so I started seeing unexpected behavior in certificate rotations - and errors in my cert-manager logging.
What you expected to happen:
I would expect when eksctl upgrade updates the cert-manager version in the deployment, that it also updates the RBAC rules.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

EKS Anywhere Release:

% eksctl anywhere version
v0.7.0

EKS Distro Release: 1.21.5

@smarsh-tim in an effort to reproduce the issue, I tried this upgrade from 1.20 to 1.21 and ensured that the manifest that goes with the newer version of the cert-manager and has the rbac changes gets applied correctly to the cluster during upgrade. Do you mind sharing what logs and errors you saw? Also, I am assuming you used the eksctl anywhere upgrade cluster -f <cluster-config>.yaml command to perform this upgrade?

I don't have the logs anymore, since I short-term fixed it already. I implemented a work-around by grabbing all the RBAC settings that get installed on a fresh EKSA cluster, and I added those manifests to my GitOps repository.
In my case, I did have already a hard-coded manifest for the cert-manager deployment - as I needed to mount some certificate authority certs to that Deployment. But I didn't have hard-coded any RBAC values, so I was surprised that during the upgrade it didn't update RBAC.  I wonder if my hard-coded Deployment somehow borked the RBAC changes getting applied.
When I completed the upgrade, there were no errors and it claimed to have upgraded cert-manager. But looking at the RBAC rules they were missing some core pieces - like leases permissions, used to establish leader position for the cert-manager-controller.
Even on an upgrade from 1.21 -> 1.21, but just a newer eksRelease version (e.g. 8 instead of 7), it didn't attempt to reconcile the cert-manager settings either.
Is it possible to have any eksctl upgrade command reconcile / re-apply the expected manifests? Or, instead of having them one-time applied via eksctl upgrade, that those manifests be exposed and added to my GitOps repository so that they're consistently reconciled along with all other manifests?

Closing due to no activity within the last 60 days


feat: Add some consistency between dialogs in the profile

Hi everyone,
All the dialogs in the Profile/Settings, were not consistent. They now have:

The same close button
The same view for actions (eg: Slack, GitHub…)

Codecov Report

Merging #4458 (5b9908b) into develop (6fd6aa8) will increase coverage by 0.09%.
Report is 6 commits behind head on develop.
The diff coverage is 41.66%.

@@             Coverage Diff             @@
##           develop    #4458      +/-   ##
===========================================
+ Coverage    10.26%   10.35%   +0.09%
===========================================
  Files          296      296
  Lines        15223    15240      +17
===========================================
+ Hits          1562     1578      +16
- Misses       13661    13662       +1

Files Changed
Coverage Δ

...pp/lib/pages/preferences/user_preferences_faq.dart
8.00% <0.00%> (+0.77%)
:arrow_up:

packages/smooth_app/lib/themes/theme_provider.dart
40.90% <33.33%> (-1.20%)
:arrow_down:

...pages/preferences/user_preferences_contribute.dart
55.34% <42.10%> (-1.43%)
:arrow_down:

.../lib/generic_lib/buttons/smooth_simple_button.dart
86.36% <66.66%> (-7.39%)
:arrow_down:

...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart
68.04% <100.00%> (+1.55%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


refactor: fix code issue brought by 660

Signed-off-by: Allen Sun<EMAIL_ADDRESS>1.Describe what this PR did
I merged #660 , while @YaoZengzeng found that there are some code needed improvement. So I submit a PR to fix this.
2.Does this pull request fix one issue?
NONE
3.Describe how you did it
NONE
4.Describe how to verify it
NONE
5.Special notes for reviews
NONE

Codecov Report

Merging #675 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
- Coverage   10.16%   10.15%   -0.01%
==========================================
  Files          71       71
  Lines        3425     3427       +2
==========================================
  Hits          348      348
- Misses       3038     3040       +2
  Partials       39       39

Impacted Files
Coverage Δ

cli/container.go
25.92% <0%> (-0.33%)
:arrow_down:

cli/run.go
0% <0%> (ø)
:arrow_up:

cli/create.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62aada5...8cb574c. Read the comment docs.

LGTM.


[WIP] CQL 3.3 status

This is a meta-issue, to track supported CQL features.

P = Parser (AST and parser), does it event parse?
S = Schema Engine, does troy understand it
M = Does it work with the macro (integration tests)

✅ = Implemented and automated test exists (with link to PR)
⚠ = We have a task for this (with a link to the issue)
❌ = Not going to be implemented (with link to explanation and workaround)

Note: This is still underprogress, items that doesn't any signs next to it, means we didn't update the document yet.
Basics

Feature
P
S

Case insensitive and double quotes
⚠ #128
⚠

Escaping Characters : Single Quote
✅ #91
✅

Escaping Characters: Dollar Sign
⚠ #130
⚠

Comments
⚠ #122
⚠

Keywords
✅ #133
✅

Data types

Feature
P
S
M

Primitives
✅
✅
✅

Blob
✅
✅
✅

UUIDs
✅
✅
✅

Timestamp
✅
✅
✅

Tuple
⚠
⚠
⚠

UDT
⚠  #9
⚠
⚠

list
✅
✅
✅

set
✅
✅
✅

map
✅
✅
✅

frozen
⚠
⚠
⚠

Functions

Feature
P
S
M

Blob
✅ #125
⚠

UUIDs
✅ #125
⚠

Token
✅ #125
⚠

Writetime
✅ #125
⚠

TTL
✅ #125
⚠

Aggregations
✅ #125
⚠ #134

UDF
✅ #125
⚠

UDA
✅ #125
⚠

Statements
Data Manipulation (Queries)

Feature
P
S
M

SELECT

INSERT

UPDATE

DELETE

Data Definition (Schema)

Feature
P
S
M

ALTER KEYSPACE

ALTER MATERIALIZED VIEW

ALTER ROLE

ALTER TABLE

ALTER TYPE

ALTER USER

BATCH

CREATE AGGREGATE

CREATE CUSTOM INDEX (SASI)

CREATE INDEX

CREATE FUNCTION

CREATE KEYSPACE

CREATE MATERIALIZED VIEW

CREATE TABLE

CREATE TRIGGER

CREATE TYPE

CREATE ROLE

CREATE USER

DROP AGGREGATE

DROP FUNCTION

DROP INDEX

DROP KEYSPACE

DROP MATERIALIZED VIEW

DROP ROLE

DROP TABLE

DROP TRIGGER

DROP TYPE

DROP USER

GRANT

LIST PERMISSIONS

LIST ROLES

LIST USERS

REVOKE

TRUNCATE

USE

Data Manipulation (Queries)

Feature
P
S
M

INSERT

UPDATE

DELETE

SELECT

Options
P
S
M

*
✅ #52
✅ #52
✅ #52

DISTINCT partition
✅ #65
✅ #65
✅ #65

aggregate(arguments)
⚠ #134 and #137
⚠ #134 and #137
⚠ #134 and #137

function(arguments)
⚠ #40
⚠ #40
⚠ #40

JSON formate
✅
✅
✅

AS alias_name

partition_value =

partition_value IN

clustering_filters relation

clustering_filters operator

clustering_filters term

clustering_filters term-tuple

clustering_filters TOKEN

Data Manipulation (Queries)

Feature
P
S
M

INSERT

UPDATE

DELETE

SELECT

Options
P
S
M

*
✅ #52
✅ #52
✅ #52

DISTINCT partition
✅ #65
✅ #65
✅ #65

aggregate(arguments)
⚠ #134 and #137
⚠ #134 and #137
⚠ #134 and #137

function(arguments)
⚠ #40
⚠ #40
⚠ #40

JSON formate
✅
✅
✅

AS alias_name

partition_value =

partition_value IN

clustering_filters relation

clustering_filters operator

clustering_filters term

clustering_filters term-tuple

clustering_filters TOKEN


new coin?

Do we have a new coin?
ETH/GNT
returned by returnTicker by poloniex but not in list in TimerSeries.validPair()

Yes, I will add to this list.


Allow multiple AuthnContextClassRef to be configured

Delimited by a semi-colon ;
For example: urn:federation:authentication:windows;urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport

Thanks for the PR!
A couple thoughts:

Can you add a test case for this?
Can you update the documentation to reflect the added behaviour?
The semicolon-delimination feels a little awkward to me... are URIs forbidden from having semicolons in them in the schema?  Would it make sense to just allow authnContext to optionally be an array?

Still happy to include this with those changes if you get around to it, but will close for now due to inactivity.


Now that Google Auth has an export feature, could we import their tokens from FreeOTP+ ?

The latest version of the Google Auth app added a functionality to export tokens to another phone scanning a QR code.
I tried to scan this code from FreeOTP+ but it doesn't recognize it.
Could we add the ability to import tokens using Google Auth's export QR?

I don't understand the format at all. Without the understanding, I am unable to import the token.
This is the original token
Issuer: AAAAA
Account: bbbbbb
Secret: ivw37pcvqu2yaahovbxqws6j25adxa6yr2qczqevxabbadmtpvrmzu5b
This is google's format:
otpauth-migration://offline?data=CjsKI0Vtv7xVhTWAAO6obwtLyddAO4PYjqAswJW4AhANk31izNOhEgxBQUFBQTpiYmJiYmIgASgBMAE4AhABGAEgACiKzs7%2B%2Bv%2F%2F%2F%2F8B

This project may help:
https://github.com/dim13/otpauth
The data is a urlencoded and base64 encoded protobuf with this format: https://github.com/dim13/otpauth/blob/master/migration/migration.proto


Uncaught TypeError: Cannot read property 'length' of undefined

Hi!
I use:
EmojioneArea v3.3.1
Emojione v2.2.7
Jquery v3.3.1
If I add this library:
https://cdnjs.com/libraries/emojione/2.2.7
Then I get error:
emojionearea.js:102 Uncaught TypeError: Cannot read property 'length' of undefined     at emojionearea.js:102     at String.replace (<anonymous>)     at p (emojionearea.js:94)     at Object.<anonymous> (emojionearea.js:1372)     at Function.each (jquery-3.3.1.min.js:2)     at L (emojionearea.js:1372)     at emojionearea.js:1372     at Object.success (emojionearea.js:1372)     at u (jquery-3.3.1.min.js:2)     at Object.fireWith [as resolveWith] (jquery-3.3.1.min.js:2)
Else (without Emojione v2.2.7):
all fine

I found that first need to import Emojione v2.2.7 and then EmojioneArea v3.3.1. Works. Conversely do not work.

You can omit the EmojiOne library, and EmojiOneArea will load it from the cdn automatically.
You can set window.emojioneVersion as per the docs

Please create example at https://jsfiddle.net

i cant omit importing Emojione v2.2.7, i get error:
Uncaught ReferenceError: emojione is not defined
at 2:445

window.emojioneVersion
What is this? Emojione or EmojioneArea?

Is it working here?
https://jsfiddle.net/mervick/1v03Lqnu/765/

Still not working


Bug: Post errorneously contains replaced images

Hey,
I noticed that when including an image in a blog post and then replacing that image with another one, both copies will make it into the fediverse, even though the first copy is not used.
To reproduce:

Draft new post
Add image block
Upload image A
Click replace
Upload image B
Publish post with only image B in it

Result: Mastodon shows both images
Since as far as I know there is no way yet to delete posts from the fediverse using the plugin (or is it?), this is really annoying.

This is a known Wordpress issue.
When uploading an image from inside a post the image becomes attached to the post.
Once the image has been uploaded this way, to detach the image you must go to the Media Library, select the List View, and from there a link allows you to Detach the media from the post

The federated Delete is currently broken, the fix is known but also requires some backwards compatibility work.

I see. Thanks for the info :)

Keep


screenshots: adding ThirdPartTextUnit entity

When adding an entity it is also need to add a migration script with it: http://www.mojito.global/docs/guides/open-source-contributors/#to-generate-the-final-migration-script-before-committing-code
Are we going to have another table to keep track of the screenshots that needs to be uploaded? We can put both table in one commit to have a single migration script.

would prefer to make that a separate diff once more of the screenshot methods are in place, API calls, etc


Deployment to remote azure cluster not working

This article seems to be completely devoid of specific steps required for this to function properly.
Specifically in this section "Deploy the application to Azure" the instructions only mention the party cluster which seem to have all the ports open on the load balancers.
Additionally the steps do not actually work on a non party cluster, I can deploy the service, it appears, but I cannot access it externally even when opening the load balancer ports, there is no specification of the need to edit the servicemanifest.xml to add in the endpoint. Additionally the steps leave out the need to do gradle clean build, and the step for installing gradle installs the wrong version of gradle on ubuntu.
This article needs massive overhaul.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cee43fc2-68c0-9a31-b70f-7668e718cceb
Version Independent ID: 3a5b49d1-bb73-4ad8-230d-09dd3e827e64
Content: Deploy a Spring Boot application to Azure Service Fabric
Content Source: articles/service-fabric/service-fabric-quickstart-java-spring-boot.md
Service: service-fabric
GitHub Login: @suhuruli
Microsoft Alias: suhuruli

Hi,
Thanks for the feedback. Will get this addressed right away. Sorry for the inconvenience.

Hi, I would like to add that this seems to work with a cluster with only one nodetype selected, if you select 2 nodetypes, and the spring boot app gets deployed to the nodes in the second nodetype they are not accessible externally, not sure if this is by design, but that is where my frustration arose. Even opening the port on the LB (which is required) does not seem to fix it, and results in a firewall error (connection refused)
Once I scrapped the cluster and went to a single nodetype everything seemed to work as indicated although the documentation does seem to be lacking due to new features implemented in servicefabric that are not referenced in the doc (such as the fact that you can no longer create a non secure cluster so the section on connecting to an insecure cluster via http is misleading)

there is a note stating you should have the port 8080 open on all nodetypes. When you have multiple nodetypes, you will need to open up the port on both the load balancers. Two LBs are provisioned and they will both need to have port 8080 opened.

Made a PR here addressing some points: https://github.com/MicrosoftDocs/azure-docs-pr/pull/41431
-Provide any feedback there.
Thanks,
Sudhanva Huruli

I will close this since the PR was merged.

@MicahMcKittrick-MSFT , looks like i can't close this. Can we close it now?


Adds IP-based geolocation app

What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/2443
Description (What does it do?)
For https://github.com/mitodl/hq/issues/2443, we developed a Django app that provides geolocation via IP address for clients that does not rely on a third-party API service and instead uses a local copy of the MaxMind GeoIP database. (There are a bunch of these that exist now but they all tend to require that you hit an external API, and I wanted to avoid that.) While this was developed within xPRO, it was always intended to be pulled out into a library we could use elsewhere - this is the library version of the same code.
How can this be tested?
Automated tests should pass.
For local testing, you will need to import the MaxMind GeoLite2 databases as described in the README. Then, you can import the ip_to_country_code API and run it against most any IP address. You should get an ISO country code back.
Note that MaxMind does not store data for the three private IPv4 network ranges - there's a management command to create blocks for this for local development use.
Additional Context
The GeoIP2 and GeoLite2 datasets are interchangeable but I recommend using the GeoLite2 database as you can get it for free. The code here only resolves down to the country so, while there are more complete datasets available from MaxMind, using them won't help too much unless you want to use the database for other things.
We'll need to use this when/if we have to add tax collection to MITx Online. The API is the same as it is in xPRO so once this is released a PR should go up to have xPRO use this instead.

Added a pyproject.toml and was able to build using pants package.


Virtual environment Icon

is it possible to get an icon for virtual environment?
https://i.imgur.com/4ujSneD.png

@ralpheeee88 - Sure! So, that segment, by default, uses the PYTHON_ICON:
https://github.com/bhilburn/powerlevel9k/blob/master/powerlevel9k.zsh-theme#L1193
You should be able to change that icon directly using the methods here:
https://github.com/bhilburn/powerlevel9k/wiki/Stylizing-Your-Prompt#icon-customization

@bhilburn super... Thxs chief


Fix the typos and styling

Describe the bug
the styling of the paragraphs are not uniform and there are few typos in the about the game section of mission.html file
Screenshots

Please assign me this issue


Correct image based on "data-mode"

Checklist

[x ] I have read the newlest tutorials and know the correct effect of the functional design.
[x ] There is no similar question on existing issues (including closed ones).
[x ] I have tried to find the answer on Jekyll Forum and StackOverflow.
[x ] My question is based on the latest code of the master branch.

Description

I actually came across a similar question:
https://github.com/cotes2020/jekyll-theme-chirpy/issues/481
However, my images are not exclusively diagrams, so I can't really use mermaid.
I wonder if there is a solution that would take "data-mode" into account and choose the correct image based on that.
If I insert something like "prefers-color-scheme" CSS media feature, but how would the markdown look?
Is it even feasible, so that I don't waste my time for no reason?

As I understand this could be done like that, but this is not working for me

Thanks a lot, for some reason I managed to miss this part of the tutorial about images, although I saw the part about shadow effect.. Anyway I'll try it as soon as I get home.

{: .light }
{: .dark }
Unfortunately, this solution does not work for some reason

I get it, you need to update theme to 5.4.0 and then everything works!

What command name to update them?

I get it, you need to update theme to 5.4.0 and then everything works!

What command name to update theme?

Please check https://chirpy.cotes.page/posts/getting-started/#upgrading

I get it, you need to update theme to 5.4.0 and then everything works!

What command name to update theme?

Please check https://chirpy.cotes.page/posts/getting-started/#upgrading

thx, works fine now


Auto-Tagging issues with 4-digit issue numbers fails

Runtime Info
OS - Arch Linux
Python - 3.11.3
CT Version - 1.5.5
(reproduced on Windows 10 and 11)
*** What's the issue? ***
CT fails to automatically identify issues with issue numbers > 3 digits. It identifies the series but claims there's no matching issue.
*** How to reproduce ***

Load up a comic issue with 4-digit issue number (Detective or Action Comics spring to mind).
Auto-Identify / Auto-Tag issue

Now this is embarrassing...
It seems that it is caused by a weird interaction between the complicated parser and my naming scheme... switching off the parser setting has it working -.-'

@Nebelherr23 Can you provide an example? I can add it to the automated tests

Basically as I said: Anything with 4-digit issue numbers. Current run of Action Comics or Detective Comics is a decent example
'Action Comics 1001 (2018).cbz'
'Action Comics 1002 (2018).cbz'
'Action Comics 1003 (2018).cbz'
'Action Comics 1004 (2018).cbz'
'Action Comics 1005 (2019).cbz'
'Action Comics 1006 (2019).cbz'
'Action Comics 1007 (2019).cbz'
'Action Comics 1008 (2019).cbz'
'Action Comics 1009 (2019).cbz'
'Action Comics 1010 (2019).cbz'
'Action Comics 1011 (2019).cbz'
'Action Comics 1012 (2019).cbz'
'Action Comics 1013 (2019).cbz'
'Action Comics 1014 (2019).cbz'
'Action Comics 1015 (2019).cbz'
'Action Comics 1016 (2019).cbz'
'Action Comics 1017 (2020).cbz'
'Action Comics 1018 (2020).cbz'
'Action Comics 1019 (2020).cbz'
'Action Comics 1020 (2020).cbz'
'Action Comics 1021 (2020).cbz'
'Action Comics 1022 (2020).cbz'
'Action Comics 1023 (2020).cbz'
'Action Comics 1024 (2020).cbz'
'Action Comics 1025 (2020).cbz'
'Action Comics 1026 (2020).cbz'
'Action Comics 1027 (2021).cbz'
'Action Comics 1028 (2021).cbz'
'Action Comics 1029 (2021).cbz'
'Action Comics 1030 (2021).cbz'
'Action Comics 1031 (2021).cbz'
'Action Comics 1032 (2021).cbz'
'Action Comics 1033 (2021).cbz'
'Action Comics 1034 (2021).cbz'
'Action Comics 1035 (2021).cbz'
'Action Comics 1036 (2021).cbz'
'Action Comics 1037 (2022).cbz'
'Action Comics 1038 (2022).cbz'
'Action Comics 1039 (2022).cbz'
'Action Comics 1040 (2022).cbz'
'Action Comics 1041 (2022).cbz'
'Action Comics 1042 (2022).cbz'
'Action Comics 1043 (2022).cbz'
'Action Comics 1044 (2022).cbz'
'Action Comics 1045 (2022).cbz'
'Action Comics 1046 (2022).cbz'
'Action Comics 1047 (2022).cbz'
'Action Comics 1048 (2022).cbz'
'Action Comics 1049 (2023).cbz'
'Action Comics 1050 (2023).cbz'
'Action Comics 1051 (2023).cbz'
'Action Comics 1052 (2023).cbz'
'Action Comics 1053 (2023).cbz'
'Action Comics 1054 (2023).cbz'
'Action Comics 1055 (2023).cbz'
'Action Comics 1056 (2023).cbz'

I fixed this in 1.6.0-alpha.1


HPCC-27460 Fix invalid index error

This error occurs when users try to import their own virtual network. The intended behavior was to not fetch data from the incorporated virtual network module once the virtual_network block is set. However, the current behavior is that Terraform tries to fetch even when it wouldn't use that data from the incorporated module. The issue is due to the use of try and catch. The correct implementation should use the can() function instead. To successfully test this, the host machine must not have python installed and the tester needs to import their own virtual network.
Signed-off-by: Godson Fortil<EMAIL_ADDRESS>

@richardkchapman please merge


Unify global variables (page offset width)

https://github.com/black-parrot/black-parrot/blob/8a394000d4e17078ed08ea2da626f9d5e926eb60/bp_be/src/v/bp_be_mem/bp_be_dcache/bp_be_dcache.v#L101
we use page_offset_width_p and bp_page_offset_width_gp in this file interchangeably, and they are both set to 12 in the common_aviary_defines and bp_common_pkg files. We should eliminate page_offset_width_p and just use bp_page_offset_width_gp.

Probably rv64_page_offset_width_gp, but yeah agree

Probably all of these global variables should be fixed in bp_common:
https://github.com/black-parrot/black-parrot/blob/master/bp_common/src/include/bp_common_aviary_defines.vh#L263
  , localparam dword_width_p       = 64                                                            \
  , localparam instr_width_p       = 32                                                            \
  , localparam csr_addr_width_p    = 12                                                            \
  , localparam reg_addr_width_p    = 5                                                             \
  , localparam page_offset_width_p = 12                                                            \

#658


@pika/pack doesn't link to this repo.

The listing for @pika/pack on npm doesn't have a link in the sidebar to easily find this repository. This is actually a common problem with monorepos and I've submitted PRs to other projects to add website entries to package.json. It would be nice to see pikapkg handle this.

+1, this would be a great first step towards seeing how @pika/pack publish could help the user with common config. Actually, in the spirit of the project, could we even read this directly from the current repo / .git directory and add it automatically if it's missing?

Fixed!


Disable precompiled headers

We noticed these having an overall negative impact on
build times, since they prevent ccache from caching
the build result.
Since precompiled headers are used for every translation
unit, some minor fixups are needed to fix the build
after disabling them.

:memo: Checklist

[ ] All user-facing changes have changelog entries.
[ ] The changes are reflected on docs.tenzir.com/vast, if necessary.
[ ] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions

I can confirm that disabling pre-compiled headers makes ccache work.


Create enhanced.html

Notes for Reviewers
This PR acts as a temporary fix for #10687
Signed commits

[ ] Yes, I signed my commits.

🚀 Preview for commit 230c4c26a355d45e045db5f6e48da59ec384c177 at: https://6613d4de36754c04e2cbdb06--meshery-docs-preview.netlify.app


tsc cannot find typings

Using this package with Typescript, tsc reports this error, when using "moduleResolution": "Bundler":
Could not find a declaration file for module '@motionone/solid'. '/Users/andre/project/node_modules/.pnpm/@motionone+solid@10.16.4_solid-js<EMAIL_ADDRESS>implicitly has an 'any' type.
  There are types at<EMAIL_ADDRESS>but this result could not be resolved when respecting package.json "exports". The '@motionone/solid' library may need to update its package.json or typings.ts(7016)

Sorry, this seems already fixed when using package solid-motiononeinstead of the now deprecated @motionone/solid. It would be really helpful to deprecate the original package with a clear explanation in the npm repository.


Numpy is installed twice

There is one improvement area that I found. At least for numpy, the docker build spents about 15-20 minutes compiling and installing an old version (not sure why, I think it was version 1.11.x), but tensorflow 1.7.0 requires numpy>1.13.3, so the tensorflow installer got to uninstall the recently installed version and install version 1.14.2. Another 20 minutes (probably less). Not a problem when rebuilding, but it could install faster if minimum version of python packages installed ahead of tensorflow are specified to be closer to what the current version of tensorflow requires.
Tensor flow requisites are down in this page:
https://pypi.python.org/pypi/tensorflow

I've tried distinct install combinations, but this is the only one that works for me, but you are welcome to colaborate , I'm sure you are able to find the way to install the required version of numpy and many other improvements.

Still working on this, and as you observed, any change can break stuff.
FYI, I found out today that pandas doesn't compile when using pip 10.0.0 (latest version).
Others found the same:
https://github.com/pandas-dev/pandas/issues/20666
In the meantime,
pip install --upgrade pip==9.0.3
solves the issue while a fix is implemented.

Yes, you are right, I've rebuilded the dockerfile and it doesn't work, I've aplied your fix and it's working ok.
Thanks you for your advice. I would love you accept my invitation to become a collaborator.


Code Enhancements to improve stability

@metmarkosaric @Ankur0812 I have merged the PR https://github.com/plausible/wordpress/pull/65 and improved code to streamline some items and tested thoroughly.

LGTM :+1:

Looks Good

@mehul0810 Please update the 'tested up to' version in readme is the latest release of WordPress.
and also add my Wordpress profile username(ankur0812) in plugin contribution.


ifr_flags and ifr_prevflags definitions are indexing a short as if it were a an array

See https://github.com/sctplab/usrsctp/blob/fbadabe48671c3273d2cf3e478e38cdd4d471c15/usrsctplib/netinet/sctp_os_userspace.h#L399
and https://github.com/sctplab/usrsctp/blob/fbadabe48671c3273d2cf3e478e38cdd4d471c15/usrsctplib/netinet/sctp_os_userspace.h#L413

Fix by https://github.com/sctplab/usrsctp/commit/6ca54a97eb2727aa89e76aa8a84667170def2e62. Thanks for the report.


Warning: Each child in a list should have a unique "key" prop.

Hi, i'm working on a Vue Storybook project, i was working into Storybbok V4.1.3 and after upgrading it to the V5.0.2, i got

Warning: Each child in a list should have a unique "key" prop..

Previously i had no errors or warnings.
package.json:
"@storybook/addon-centered": "^5.0.2",
    "@storybook/theming": "^5.0.2",
    "@babel/core": "^7.1.6",
    "@storybook/addon-knobs": "^5.0.2",
    "@storybook/addon-links": "^5.0.2",
    "@storybook/addon-viewport": "^5.0.2",
    "@storybook/addons": "^5.0.2",
    "@storybook/vue": "^5.0.2",
    "@vue/cli-plugin-babel": "^3.5.1",
    "@vue/cli-plugin-eslint": "^3.5.1",
    "@vue/cli-plugin-unit-mocha": "^3.5.1",
    "@vue/cli-service": "^3.5.1",
    "@vue/eslint-config-standard": "^4.0.0",
    "@vue/test-utils": "^1.0.0-beta.26",
    "autoprefixer": "^9.5.0",
    "babel-eslint": "^10.0.1",
    "babel-loader": "^8.0.4",
    "babel-polyfill": "^6.26.0",
    "babel-preset-vue": "^2.0.2",
    "css-loader": "^1.0.1",
    "eslint": "^5.15.2",
    "eslint-plugin-vue": "^5.0.0",
    "file-loader": "^2.0.0",
    "node-sass": "^4.11.0",
    "postcss-loader": "^3.0.0",
    "sass-loader": "^7.0.1",
    "storybook-addon-vue-info": "^1.0.0",
    "storybook-readme": "^5.0.0",
    "storybook-vue-router": "^1.0.2",
    "vue-loader": "^15.7.0",
    "vue-style-loader": "^4.1.2",
    "vue-template-compiler": "^2.6.9"

button.stories.js
import { storiesOf } from '@storybook/vue'
import { withInfo } from 'storybook-addon-vue-info'

import AButton from './Button'

storiesOf('Atoms|Button', module)

  .addDecorator(withInfo)

  .add('Primary', () => ({
    components: { AButton },
    template: `
    <div class="row cell-3">
        <AButton
            primary
            content="Primary"
        />
    </div>
  `,
    propsDescription: {
      AButton: {
        primary: 'Some prop description'
      }
    }
  }),
  {
    info: true
  })

addons.js
import 'storybook-addon-vue-info/lib/register'
I was wondering if there is something i'm missing with the new update, since everything was working just fine
Thanks for the help

@flav0061
This warning comes from our React components in addon panel. Nothing wrong with your story or config :)
It's true that the warning is annoying so I'll take a look at.

@pocka
Thanks for the help and for the quick reply :)

Fixed in https://github.com/pocka/storybook-addon-vue-info/commit/6a7e3677d4b7b5d1cb69dfa5fe926e3f084f7623 (v1.0.1)


Is it possible to rename keys?

For the most part the logging format suits my needs but I would need to rename certain keys.
Is this possible?

I'll make a PR allowing remapping params


use ToMap for links

Can you make sure the unit tests pass and maybe add one to cover this case?

@joshwget test added and passed.

LGTM!


updates taxcloud state management URL

Hi, in going through this readme, the URL for this had been changed and no redirect was setup, so hopefully this saves future users the hassle of figuring out where this was as I had to do.  :)

Thanks, @ghepting!

Haven't seen a notification from here for a long time! @ghepting if you want to help there's a bunch of open issues and chores, if you want to help.

Yeah I've got a deep dive into this on my to-do list for this or next week.
I will see how our integration path goes and see how I can pitch in where
it makes sense.
On Tue, Oct 6, 2020, 11:23 AM Daniel Doubrovkine (dB.) @dblockdotorg <
<EMAIL_ADDRESS>wrote:

Haven't seen a notification from here for a long time! @ghepting
https://github.com/ghepting if you want to help there's a bunch of open
issues and chores, if you want to help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/drewtempelmeyer/tax_cloud/pull/42#issuecomment-704463133,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADYIHKPQORAZZJKVA5U4BTSJNOCFANCNFSM4SGGCRBA
.


Roll Engine from efa768683eaf to a86747e93f35 (1 revision)

https://github.com/flutter/engine/compare/efa768683eaf...a86747e93f35
2021-01-15<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from erwxDS3kf... to y-4SPFGg7... (flutter/engine#23706)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from erwxDS3kf-ZI to y-4SPFGg7fYL
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.

Commit queue failed; closing this roll.


Add a sample code in documentation to demonstrate how to use Offstage widget to measure the dimensions.

Docs says:

Offstage can be used to measure the dimensions of a widget without bringing it on screen (yet)

It would be a good idea to show some code snippet on how to do that, here is a question asked on Stackoverflow

Hey , I am new to the cotribution can you please help me out with this that how to proceed ?


[CARBONDATA-946] Spark 2x tupleId support for IUD Feature

Build Success with Spark 1.6.2, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2043/

LGTM


Cannot pass file as suggested in example with windows

ollama version is 0.1.27
Here's the example provided in the documentation.

ollama run llama2 "Summarize this file: $(cat README.md)"

Here's what I tried use the windows versions and the response

ollama run phi "summarize this file $(type 5_QGU5D7mLk.md)"
I'm sorry, but as an AI language model, I cannot provide a summary of any specific text without access to its contents.
Please provide me with more context or information about the text you would like me to summarize.

There may be something else going on with actually providing the file text in the prompt, but it's also possible that the model is getting hung up on the word "file" What if your prompt is "summarize this text," instead?
Also, another thing to try is passing the text using IO redirection, rather than as a long command line argument. On UNIX, these work ollama run phi "summarize this text" < textfile.md or cat textfile.md | ollama run phi "summarize this text"

Piping in works, but does have an error ( https://github.com/ollama/ollama/issues/2698 )
Same for redirection, works but has the stdin handle error.
It does seem to expand the command line, when I use echo it works.

ollama run gemma:2b "$(echo what is the capital of australia)"
The capital of Australia is Canberra.
Canberra is the capital city of Australia and is located in the Australian Capital Territory.

so seem just when acting on a file

I think this is a shell problem.  cmd doesn't support the syntax of subshelling with $(commands here) but powershell does.
cmd terminal:
> ollama run phi "summarize this document $(type .\README.md)"
 I'm sorry, as an AI language model, I cannot access external files or webpages to read and summarize them for
you. However, you can use a text summarization tool like Google Summarize or Microsoft's summarization feature in
Word to create a summary of the document. Simply copy and paste the entire text into the tool and it will generate
a concise summary for you

Powershell:
> ollama run phi "summarize this document $(type .\README.md)"
 The most relevant topic for the user's query is "Ollama" as it appears in all the given links and examples, along
with being mentioned as a language model on its own.

I agree, I get the same experience.

This works in my Windows Terminal cat <file> | ollama run <model> "prompt"


Wrong charging current in Smart mode with 1.4.2

For some reason the new 1.4.2 limits my charge current in Smart mode. Normal mode works well.
Anything change in the calculation? I have read something about Max Circuit here: https://github.com/serkri/SmartEVSE-3/pull/21/files
At the moment it charges 16A-17A instead of 32A setpoint (=30.6A real current). I think it's using the default value of Max Circuit https://github.com/serkri/SmartEVSE-3/blob/1abdea05e8772e7579914541e59dfc6bf8ea3005/SmartEVSE-3/include/evse.h#L129
But I don't have a menu item to change Max Circuit to 32A.

|
-- | --
version | "SERKRI-1.4.2"
mode | "SMART"
mode_id | 3
car_connected | true
wifi |
status | "WL_CONNECTED"
ssid | "WiFi2020"
rssi | -48
bssid | "F0:9F:C2:F4:01:56"
auto_connect | false
auto_reconnect | true
evse |
temp | 44
temp_max | 65
connected | true
access | true
mode | 1
solar_stop_timer | 0
state | "Charging"
state_id | 2
error | "None"
error_id | 0
rfid | "Ready to read card"
settings |
charge_current | 169
override_current | 0
current_min | 6
current_max | 34
current_main | 40
solar_max_import | 1
solar_start_current | 4
solar_stop_time | 10
3phases_enabled | false
mains_meter | "Eastron"
home_battery |
current | 0
last_update | 0
ev_meter |
description | "Eastron"
address | 102
import_active_energy | 0
total_kwh | 3613.6
charged_kwh | 0.8
mains_meter |
import_active_energy | 6810.9
export_active_energy | 2329.7
phase_currents |
TOTAL | 183
L1 | 183
L2 | 0
L3 | 0
last_data_update |<PHONE_NUMBER>
original_data |
TOTAL | 183
L1 | 183
L2 | 0
L3 | 0
backlight |
timer | 120

Try changing Loadbalance to Master, MaxCircuit will appear in the menu, and see if changing that works...
fluppie @.***> schreef op 30 augustus 2022 17:12:54 EDT:

For some reason the new 1.4.2 limits my charge current in Smart mode. Normal mode works well.
Anything change in the calculation? I have read something about Max Circuit here: https://github.com/serkri/SmartEVSE-3/pull/21/files
At the moment it charges 16A-17A instead of 32A setpoint (=30.6A real current). I think it's using the default value of Max Circuit https://github.com/serkri/SmartEVSE-3/blob/1abdea05e8772e7579914541e59dfc6bf8ea3005/SmartEVSE-3/include/evse.h#L129 >
But I don't have a menu item to change Max Circuit to 32A.

|
-- | --
version | "SERKRI-1.4.2"
mode | "SMART"
mode_id | 3
car_connected | true
wifi |
status | "WL_CONNECTED"
ssid | "WiFi2020"
rssi | -48
bssid | "F0:9F:C2:F4:01:56"
auto_connect | false
auto_reconnect | true
evse |
temp | 44
temp_max | 65
connected | true
access | true
mode | 1
solar_stop_timer | 0
state | "Charging"
state_id | 2
error | "None"
error_id | 0
rfid | "Ready to read card"
settings |
charge_current | 169
override_current | 0
current_min | 6
current_max | 34
current_main | 40
solar_max_import | 1
solar_start_current | 4
solar_stop_time | 10
3phases_enabled | false
mains_meter | "Eastron"
home_battery |
current | 0
last_update | 0
ev_meter |
description | "Eastron"
address | 102
import_active_energy | 0
total_kwh | 3613.6
charged_kwh | 0.8
mains_meter |
import_active_energy | 6810.9
export_active_energy | 2329.7
phase_currents |
TOTAL | 183
L1 | 183
L2 | 0
L3 | 0
last_data_update |<PHONE_NUMBER>
original_data |
TOTAL | 183
L1 | 183
L2 | 0
L3 | 0
backlight |
timer | 120

-- >
Reply to this email directly or view it on GitHub:
https://github.com/serkri/SmartEVSE-3/issues/64
You are receiving this because you are subscribed to this thread.
Message ID: @.***>

I've only added data to the endpoint so no changes in the calculations

I experienced similar behaviour with this version, after a hard reset (FLI off/on) it worked as it should.

I was on 1.3.8 before updating to 1.4.2 so I had the old calculation. I'll try to go back on 1.4.2 later this weekend.
@rvdgaag what do you mean with FLI off/on?

The circuit switch.

Is there still an issue with this?

I think so, still on 1.3.8 I'll update again to 1.4.2 and retry. I will also cut 230V to SmartEVSE v3 after the update so a full reboot is the case. Car is currently at 100% so I cannot test right away :).

Jup, still 16A limit

Putting loadbalancing on Master so the MaxCircuit appears makes it working again. But that's a workaround for a bug that's not there in 1.3.8. Just after setting 33A as max circuit current, the SmartEVSE is flipping. A hard power cycle of the module solves the issue. I'll see if I can upload a video.
I have a mono phase setup with Eastron SDM230 kWh meters for MainsMeter and EVMeter.

https://user-images.githubusercontent.com/8402106/191032819-2af89601-f443-4ad1-87b4-1a44405fa5be.mp4

I can look at this when I am back at my SmartEVSE location, which will be end of November...

@fluppie, my setup is very much like yours:  Eastron SDM72 kWh meters for MainsMeter and EVMeter, but I have a three phase 25A mains connection.
I cannot reproduce this problem. Is it reproducable on current version 1.4.4?


Make evenly spaced ticks when threshold_values are not evenly spaced in CSI plots

CSI plots with non-monotonic thresholds not displayed neatly.
threshold_list: [1,2,5,10,15,20,30,50,100,200]
Old:

Update:

@jordanschnell @zmoon thanks for adding this feature.
I agree with zach, that we want both old and new way of plotting. can you make is an option in yaml file?

@jordanschnell @zmoon thanks for adding this feature. I agree with zach, that we want both old and new way of plotting. can you make is an option in yaml file?

New tick display now requires additional plot option, original behavior is default and does not require option to be specified.

Thanks @jordanschnell . Could you add a brief description in the doc, maybe under this line
https://github.com/NOAA-CSL/MELODIES-MONET/blob/bc44e39cd942859ac6d26ba29685ef8ce217fd13/docs/appendix/yaml.rst?plain=1#L352

documentation added and slight change to key/value pair names.

@jordanschnell both of those old links you changed currently redirect to https://rapidrefresh.noaa.gov/AQverification/ , should that page be linked anywhere?

@jordanschnell both of those old links you changed currently redirect to https://rapidrefresh.noaa.gov/AQverification/ , should that page be linked anywhere?

The previous two links were the legacy sites. Everything has moved here: https://rapidrefresh.noaa.gov/monet_rrfs_verif/


Update setup_ado.sh

Problem
The file is not renamed after downloading it using wget
Solution
wget command needs -O option to be able to rename it.
Tests
Tested successfully
Notes

Thanks for the PR


Add Manage Held AutoMod Messages feature

Twitch changelog : 2021‑05‑12

Pull Request Test Coverage Report for Build 845726614

9 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 96.088%

Totals

Change from base Build 821944774:
0.04%

Covered Lines:
958

Relevant Lines:
997

💛  - Coveralls


how to deactivate bottombar?

howdy,
first of all, i really like DUSK :)
one thing i can't get my head around:
how do i deactivate the bottombar? in my flexipatch dwm-setup when i hide a client/tag i stays in the topbar, but only the color changes....
is this also possible?
cheers and thnaks in advanced

You can configure 0 or more bars per monitor, and each bar can have 0 or more modules which provide content.
The Bar wiki page is a good place to start.
I also have a guide if you want to play around with setting up the bar(s) from scratch.

how do i deactivate the bottombar?

If a bar has nothing to display then the bar itself does not display.
The default configuration defines a top and a bottom bar for up to three monitors.
https://github.com/bakkeby/dusk/blob/354a9ca122f705ba446a0d193337bd710f08542b/config.def.h#L314-L322
If you look at the bar rules there are the following modules that are placed on the bar with index 1 (i.e. the bottom bar).
https://github.com/bakkeby/dusk/blob/354a9ca122f705ba446a0d193337bd710f08542b/config.def.h#L373-L376
If you want to deactivate the bottom bar then all you need to do is to remove those three modules. You can also remove the rows from the bars array if you want, but this is not necessary.

in my flexipatch dwm-setup when i hide a client/tag i stays in the topbar, but only the color changes....
is this also possible?

In the bar rules there is a module that draws the window titles:
https://github.com/bakkeby/dusk/blob/354a9ca122f705ba446a0d193337bd710f08542b/config.def.h#L371
There is some general information about this on the FlexWinTitle Module wiki page.
The size of the window titles drawn are relative to the number of clients and the category of clients. This means that the window titles for master clients can be larger than the window titles of stack clients, as an example.
The way this works is that each category is given a weight that is relative to the weight of other categories.
The default configuration for this is as follows:
https://github.com/bakkeby/dusk/blob/354a9ca122f705ba446a0d193337bd710f08542b/config.def.h#L112-L115
The way to read this is that master client window titles are almost four times larger than the window titles of stack clients. The weight of hidden and floating window titles are set to 0, which in practice means do not show hidden and floating window titles.
The reason for this is that floating and hidden clients are shown on demand on the bottom bar as per the bar rules mentioned earlier (and we do not want the window titles to appear in two places).
As such all you need to do is to set the flexwintitle_hiddenweight and flexwintitle_floatweight to 1 to have them display in the top bar similarly to how you had it in dwm.
If you set the weight to be the same across master, stack, hidden and floating then all window titles will have the same size and it will look similar to what awesomebar look like.


Define IR21 Sitemap

To help with development, it would be great to have a list of paths planned for the impact report. That will determine how many "screens" are needed for site navigation.
Proposed sitemap

[ ] https://essential.cu.edu/r/index.html?query=stuff - This added tracking but in a weird way. Might it be used this year?
[x] https://essential.cu.edu/impact-reports/joy - The homepage
[x] https://essential.cu.edu/impact-reports/joy/stories/[slug] - Individual stories. This screen is mostly done. Four stories are planned so far.
[x] https://essential.cu.edu/impact-reports/joy/financials - Financials page.

Redirects

[ ] https://essential.cu.edu/joy -> https://essential.cu.edu/impact-reports/joy?utm_campaign=IR21&utm_source=folder&utm_medium=web&utm_content=mc-email
[ ] https://essential.cu.edu/QRJoy21 ->  https://essential.cu.edu/impact-reports/joy?utm_campaign=IR21&utm_source=folder&utm_medium=print&utm_content=qr-code

there is no overall sitemap, but the project is now released so this issue is done.


[fix]refactor refactor the hierarchy of external scan node

Proposed changes
There should be 2 kinds of ScanNode:

OlapScanNode
ExternalScanNode

The Backends used for ExternalScanNode should be controlled by FederationBackendPolicy.
But currently, only FileScanNode is controlled by FederationBackendPolicy, other scan node such as MysqlScanNode,
JdbcScanNode will use Mix Backend even if we enable and prefer to use Compute Backend.
In this PR, I modified the hierarchy of ExternalScanNode, the new hierarchy is:
ScanNode
	MetadataScanNode
	DataGenScanNode
	OlapScanNode
	SchemaScanNode
	ExternalScanNode
		EsScanNode
		OdbcScanNode
		MysqlScanNode
		JdbcScanNode
		FileScanNode
			FileLoadScanNode
			FileQueryScanNode
				MaxComputeScanNode
				IcebergScanNode
				TVFScanNode
				HiveScanNode
					HudiScanNode

And previously, the BackendPolicy is the member of FileScanNode, now I moved it to the ExternalScanNode.
So that all subtype ExternalScanNode can use BackendPolicy to choose Compute Backend to execute the query.
All all ExternalScanNode should implement the abstract method createScanRangeLocations().
For scan node like jdbc scan node/mysql scan node, the scan range locations will be selected from randomly from
compute node(if preferred).
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

Reviewed.


Update Kafka to 2.0.1

I wonder if this causes impact in debezium itself, I've tested locally and it looks fine.
Should I updated the library in debezium to 2.0.1 as well? I think they're compatible since here is the server but let me know what's necessary

Thanks for raising this up! Could you please raise a Jira and link it to it? Also before mergining we woul need to update Debezium's pom.xml including Kafka dependencies.
Last but not least it is necessary to sync dependencies in https://github.com/debezium/docker-images/blob/master/connect-base/0.9/Dockerfile#L32

Seems like there are no updates for Avro or Jackson at the current date
https://mvnrepository.com/artifact/org.codehaus.jackson/jackson-mapper-asl 1.9.3
https://mvnrepository.com/artifact/org.codehaus.jackson/jackson-core-asl 1.9.3
https://avro.apache.org/releases.html 1.8.2


why do you loop 10 times in superres-console.cpp?

there is a loop in here. I removed it and cannot see any difference in the up-scaled output image.
https://github.com/dusty-nv/jetson-inference/blob/master/superres-console/superres-console.cpp#113
/*
* upscale image with network
*/
for( int i=0; i < 10; i++ )

Hi @lu-hongwei , the loop is just for profiling purposes to get a more accurate performance number.  Feel free to remove the loop without any impact to the image output.


Screen Issue

Is there any suggested method for screen setup.  I seem to have the hijack issue even with jwl running.
Running 4 creens 2 at desk and 2 large screens DUPES  at front of hall
Thx in advance

We have essentially a 3 screen set up
PC, 2nd Screen at Desk then 2xVideo Screens at front of hall
JW Library is set up as 2 screen and outputs video to front
However if we setup zoom on screen 1 we get a freeze or hijack on the video screens.  We then need to click into JWL and switch the show on 2nd screen off then back on to get the video back at front of hall.
Thanks for your attention
I’m sure your very busy at the moment.
Jehovah’s blessing.
From: Antony Corbett @.>
Sent: 31 March 2022 20:16
To: AntonyCorbett/JwlMediaWin @.>
Cc: markieme @.>; Author @.>
Subject: Re: [AntonyCorbett/JwlMediaWin] Screen Issue (Issue #25)
What exactly are the symptoms?
—
Reply to this email directly, view it on GitHub https://github.com/AntonyCorbett/JwlMediaWin/issues/25#issuecomment-1085004658 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AYP5YWMSVPNZYYB5Z64BC7TVCX2YBANCNFSM5SF2W3VQ .
You are receiving this because you authored the thread.Message ID: @.***>

@markieme Sorry, we don't really know enough about your configuration to make informed comment; it would only be guesses. Perhaps start from basics without JwlMediaWin running. Zoom and JWL should both be in dual-monitor mode, with the main control windows (e.g. the "JW Library" and the "Zoom Meeting" windows) on your PC monitor and the secondary windows showing full-screen on your 2nd monitor. At this point, you should be able to switch between the Zoom and JWL media windows on your 2nd monitor using the Windows taskbar icons. Does that work ok?

We had what seems a similar issue with similar setup (two screens at back; (1) primary for AV control (2) one
running onlyT for speaker) and (3) a screen at front duplicated on two TVs
After Zoom sharing screen 3 (which has Zoom second meeting window and JW media window on it) the main zoom meeting window with controls would move from screen 1 to screen 2 obscured behind OnlyT.
This is just the strange behaviour of Zoom itself and unrelated to anything else.
We made a little system tray app like JWlMediaWin that keeps both Zoom meeting windows on whatever screens the user chooses so we can keep using same setup. Works but acid test 5/4/22. If it describes what your having let me know and I'll upload program for you to try.
Antonio


Update fork from upstream repository

Is your feature request related to a problem? Please describe.
There are quite a few changes in the upstream repository.
Describe the solution you'd like to see
Let's update the project.
Describe alternatives you've considered
Do we still need this fork? If not, can we switch to the upstream version? Can we contribute back the necessary changes?

Created related ticket to remove support for hpa-operator: https://github.com/banzaicloud/pipeline/issues/3397

Created related ticket to remove support for hpa-operator: https://github.com/banzaicloud/pipeline/issues/3397


CHANGELOG missing entries for 1.2.x minor versions

Thanks @johnabrams7.  I did indeed mean details of v1.2.1, 1.2.2 in https://github.com/balderdashy/sails/blob/master/CHANGELOG.md.
It's great to know the changelog is available on https://github.com/balderdashy/sails/releases, but I now notice that details of v1.2.3 and v1.2.4 are missing from there as well.

Thank you @alxndrsn, we have added notes for v1.2.3 and v1.2.4 to the github releases.


Chart this.context.chartConfig is an empty array, so I get this error

Uncaught TypeError: Cannot read property 'origin' of undefined
    at Chart.render (Chart.js:57)
    at finishClassComponent (react-dom.development.js:21278)
    at updateClassComponent (react-dom.development.js:21278)
    at beginWork (react-dom.development.js:21278)
    at performUnitOfWork (react-dom.development.js:21278)
    at workLoop (react-dom.development.js:21278)
    at renderRoot (react-dom.development.js:21278)
    at performWorkOnRoot (react-dom.development.js:21278)
    at performWork (react-dom.development.js:21278)
    at performSyncWork (react-dom.development.js:21278)
    at requestWork (react-dom.development.js:21278)
    at scheduleWork (react-dom.development.js:21278)
    at dispatchAction (react-dom.development.js:21278)
    at Object.setValue [as next] (index.esm.js:63)
    at next (database.ts:1873)
    at async_observer.ts:51

Usage (prop values are okay):
    <Chart
      id={1}
      yExtents={[
        (d: ChartOHLCV): [number, number] => {
          return [d.high, d.low]
        },
      ]}
      height={chartHeight}
    />

since the context.chartConfig === [], this code in render fails:
		const { origin } = find(this.context.chartConfig, each => each.id === this.props.id);

@Industrial I also faced this problem. Did you manage to solve this?


Only open the mmap for reading if read_mode=True

Also fixes a syntax-y error from https://github.com/prometheus/client_python/commit/682e5ecf5c1522bdd7223e49e7e383925a6bbe36
@brian-brazil Pinging as requested :)

Thanks!


Please inform everyone to upgrade the hokla eslint plugin to benefit from your piece !
https://hokla.slack.com/archives/C02CZUN4QUW
Tell them to run yarn upgrade @hokla/eslint-plugin-custom-rules or npm update @hokla/eslint-plugin-custom-rules

Does the script needs to be executable by other devs for it to work (using the chmod command) ?


MenuView disappears when changing to single View Controller

When one of two view controllers is deleted, the MenuItemView moves to the left and loses it's horizontal line. Currently deleting the page like so:
internal func didDeleteAccount(index: Int) {

   viewControllers.removeAtIndex(index)
   pagingMenuOptions.defaultPage = viewControllers.count / 2
   pagingMenuController.setup(viewControllers: viewControllers, options: pagingMenuOptions)

}

From this

To this

centerItem is still set to true but I think it probably happens because it gets confused what to center?
Any thoughts?

Adding/Deleting menu item is not supported yet, so there might be unexpected behaviours like this. I'll check and fix such things when Adding/Deleting is supported.

👍🏻

Please use version 0.5.0.


Fix styling for Navbar on all themes

On the snapshot site, the navbar used to have the id topnav.
A lot of themes would use the id selector of #topnav to adjust the styling of this navbar.
However, recently the snapshot website updated and renamed this id to navbar which broke the styling for all these themes.
This PR updates all css selectors from #topnav to #navbar to fix this issue.

@bonustrack It looks good to me, would you like to review it?

I will make this change on the frontend so we don't need to make it here. @chase-manning @gokaiorg


Cannot read property 'emit' of null

Just so you know :) while downloading I got the following:
/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/webtorrent/lib/torrent.js:927
    self.client.emit('upload', uploaded)
               ^
TypeError: Cannot read property 'emit' of null
    at Wire.<anonymous> (/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/webtorrent/lib/torrent.js:927:16)
    at emitOne (events.js:96:13)
    at Wire.emit (events.js:188:7)
    at Wire.piece (/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/bittorrent-protocol/index.js:337:8)
    at respond (/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/bittorrent-protocol/index.js:498:10)
    at /Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/fs-chunk-store/index.js:200:7
    at end (/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/run-parallel/index.js:16:15)
    at done (/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/run-parallel/index.js:20:10)
    at each (/Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/run-parallel/index.js:26:7)
    at /Users/davidgatti/Documents/GitHub/MrWhite/How-to-Stream-Torrents-in-NodeJS/node_modules/run-parallel/index.js:41:37

This happened after playing 2 weeks with this module, meaning it isn't frequent, but it did happen :)

WebTorrent version: 0.98.0
Node.js version: v6.4.0
Browser name/version (if using WebTorrent in the browser): Using NodeJS module.

I've seen this before too.


Remove tools in favor of make codecheck

Summary

Removing:

tools/code_check.sh and family, which used to be used on Jenkins but hasn't been working, see https://github.com/ignition-tooling/release-tools/issues/446

In favor of:

make codecheck, which is used on Actions and can't be used (nicely) on Jenkins yet because of https://github.com/ignition-tooling/release-tools/issues/148

Test it

Check out CI results
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

we still need tools/check_test_ran.py

we still need tools/check_test_ran.py

Restored in 1c4e12d. Do you think this is something reasonable to move to ign-cmake?

something reasonable to move to ign-cmake?

Probably yes, it's used by it: https://github.com/ignitionrobotics/ign-cmake/blob/17b7058ff5c9de2f6f396d1a000dd0366481d621/cmake/IgnUtils.cmake#L1721

something reasonable to move to ign-cmake?

Probably yes, it's used by it: https://github.com/ignitionrobotics/ign-cmake/blob/17b7058ff5c9de2f6f396d1a000dd0366481d621/cmake/IgnUtils.cmake#L1721

since we aren't using QTest anymore (https://github.com/ignitionrobotics/ign-gui/issues/198#issuecomment-809640183), I think it can be moved to ign-cmake. There are a few variants of check_test_ran.py in our packages, so we should make sure to get the one that uses an informative classname:

not helpful: https://github.com/ignitionrobotics/ign-cmake/blob/ign-cmake2/tools/check_test_ran.py#L73
helpful: https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/tools/check_test_ran.py#L73

It looks like we don't even need https://github.com/ignition-tooling/release-tools/pull/455, the job already ignores a missing code_check file:
sh: 0: Can't open tools/code_check.sh
+ true

I think it can be moved to ign-cmake

Removed check_test_ran from this repo in e12d976.
Updating ign-cmake in https://github.com/ignitionrobotics/ign-cmake/pull/168
Test run:  (uses https://github.com/ignition-tooling/release-tools/compare/chapulina/math/211)


Upgrade-Insecure-Requests

When Upgrade-Insecure-Requests: 1 is set on a request, we should 302 -> https if we're running on azure

actually no way, this isn't even interesting for this service - the whole goal is to 302 elsewhere, i'm not going to make this first 302 to https


Tab resize should be delayed

If I have a lot of tabs open and I want to close several of them, it can be a little annoying to have to continue adjusting the mouse when I am trying to close tabs as they resize. Chrome does a good job at this: When you close a tab, the other tabs shift to fill the space but they do not resize to fill space for a second or two, giving you the ability to close several tabs in a row quickly without having to move your mouse.

:+1: I really like this idea!

Chrome isn't delaying the tab-resize, they are doing it as soon as you remove the mouse from the tabbar. I also would like to see this nice feature :)
For now, just use CMD + W.

This issue was moved to atom/tabs#129

@karai17 I like the idea as well, but as @philipgiuliani mentioned -- it should be in the issue tracker for the tabs package. I just moved it over there, so feel free to continue the discussion in that issue. :+1:


Run node e2e test as post submit test.

Currently, we could reliably pass 180/182 node e2e test (Non-Slow, Non-Serial, Non-Flaky), and we are running the test everyday.
We should run it more frequently to get more result and catch flakiness.
However, node e2e usually takes a long time, we should run node e2e as post submit test after https://github.com/kubernetes-incubator/cri-containerd/pull/211 is proved to be working after tonight's run.

And we don't need to run verification and build for post submit to accelerate it.


A nicer Javascript object/JSON AST/API

I've been wrestling with structured JSON: taking it from and returning it to the github gist API. I'm not sure whether i'm doing something wrong, but AFAIK the inbuilt constructs (js.Dynamic, js.Object, js.Any, js.Dictionary) are all extremely hard to use:

js.Dictionary doesn't let you iterate over keys/values, and doesn't allow recursive types
js.Object doesn't do, well, anything
js.Dynamic has breaks when your keys have special characters, since dynamicThing.my key doesn't work right

Are there any thoughts about providing a nicer API for dealing with nested JS structures? Something like the Play/Spray/whatever Json AST where you can easily put together a nice hierarchical structure as well as navigating it using strings. Currently I'm doing things like:
          data = js.JSON.stringify(
            lit(
              description = "Scala.jsFiddle gist",
              public = true,
              files = js.Dictionary(
                ("Main.scala": js.String) -> lit(
                  content = code
                )
              )
            )
          )

For constructing stuff, and
    val allFiles = result.files.asInstanceOf[js.Dictionary[js.Dynamic]]

    val mainFile = allFiles("Main.scala")

    val firstFile = allFiles(js.Object.keys(allFiles)(0).toString)

    val content = (if (!mainFile.isInstanceOf[js.Undefined]) mainFile else firstFile).selectDynamic("content").toString

For querying with my JSON, and it looks really gross both ways.

It seems that in 2.5 years, no one ever cared enough to submit a small PR about this, so I'm going to close it.


Adding tooltips documentation

I think it would be useful if we add info that tooltip in the mobile app can be seen with a long-tap on a specific bar\point on the chart

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf174abf-6474-14ae-3183-31e40fa9b1b6
Version Independent ID: ca82ad59-c057-fccd-b6e0-627df4326c62
Content: Explore reports in the Power BI mobile apps - Power BI
Content Source: powerbi-docs/mobile-reports-in-the-mobile-apps.md
Service: powerbi
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks @chizhova, assigning to @maggiesMSFT to fix. She is on vacation but will address when she returns.

Hi @chizhova -- yes, good idea! I'll add that to "Explore reports in the Power BI mobile apps - Power BI"


Debugger doesn't show local variables if debug line is the last line of file

Godot version:
3.1 stable
OS/device including version:
Windows 7 x64
Steps to reproduce:

Make function with some local variables,
Make breakpoint in the last line of file,
Run project

Result: there are no local variables in debugger window

Expected: variables are displayed
Note: if you add one line, even empty one (which makes debugger line is not last of file) - variables are displayed in debugger

Minimal reproduction project:
You should put break point in the last line of script file, run project and you will see than there are no local variables in debugger
18042019.zip

Confirmed in 2c0c1e3 (so it was not fixed by #27055, even if the bugs seem related).

I have filed another breakpoint issue #27177 that I find really problematic for my project. Perhaps it is related and someone can have a look at it while fixing this?

The issue is bigger than just the last line of a file; it affects the last line of any indented section, including if/else and match statements, where it's common to put the "else" or the next match pattern immediately following the previous section, without a line gap in between:

Until this is fixed, insert an extra line of "pass" as a workaround wherever you suffer from this issue.


Changelog view or Breaking Change Message

As we discussed in the post mortem, users had no visibility of the circle breaking change.  This could be through

alert
error message on the code that broke. (error message on circle that has an is-was once the user hovers over it)

@jgomez720 to create an email template for these breaking changes in the future in hubspot (very needed after 1.0)
https://github.com/KittyCAD/pet-store/issues/187
@jessfraz reassign to those you need

Here is the description I put in #3996 before I realized it was duplicate:
We recently shipped a purposeful breaking change in KCL with https://github.com/KittyCAD/modeling-app/pull/3860. However, because we didn't even have a updater toast at the time (we do now with https://github.com/KittyCAD/modeling-app/pull/3902), users never got a chance to see the changelog let alone get a sense of it being serious. They just saw their existing code with circle in it all break.
Now that we have an updater toast, we want to start making it possible to tune the loudness of the messaging in that notification so that users see breaking changes coming.
My initial simple proposal is that we add the full changelog back into this toast within a collapsible disclosure. If the changelog's contents have the term "breaking" in them, we set this disclosure to open by default, but otherwise we default it to closed.


Please provide documentation on usage

I'd like some kind of documentation to figure out how to use this program. I could probably get by with the "Inference" section if I had a model, but the program didn't seem to come with any (the pull-down is empty), and I don't know how to get one without paying $10/month to applio.org. So I guess I'd have to use the "Train" feature, but I have no idea how to use it--what any of the options mean, which buttons I have to press, what kinds of files have to be in the dataset path and how to make them, guidelines for making an effective recording to use for training, etc..
Thanks

where you can pay 10$ to applio.org? wtf.
if you want more info you can join to the discord or check the docs

thanks, can you tell me where the docs are?
i looked briefly in my applio directory and couldn't find any
I guess it's not applio.org you pay the $10/month to, but there's a link in the UI to find models, which brings you to a website with 500,000 models, but apparently to download them you need to subscribe. I thought it was applio.org because when I hovered over the link the URL to check again where it goes to, it showed applio.org.

discord.gg/iahispano
docs.applio.org


Initial implementation

Strong dependency on https://github.com/drone-plugins/drone-git-push/pull/4

It's an initial version, I'm merging it to get some kind of working plugin submitted


Rustify test.sh

Note for myself: show the stdout/stderr of a command if it failed.

Some issues with the tests:

--mini-tests, --std-tests:

Before: it showed the output of the executables ran.
After: it is not shown.
Please make it so that we see the output.

--extended-rand-tests, --extended-regex-example-tests, --extended-regex-tests: The CI task for libgccjit 12 should be removed since it is skipped (I know it ran before this PR, but it's easy to remove in gcc12.yml).


Update Tutorial.md

Fix example for handleActions()

What is the issue that you are fixing?

Towards the end of the tutorial there's this code example:
const { increment, decrement } = createActions({
  'INCREMENT': amount => ({ amount: 1 }),
  'DECREMENT': amount => ({ amount: -1 })
});

const reducer = handleActions({
  [increment](state, { payload: { amount } }) {
    return { counter: state.counter + amount }
  },
  [decrement](state, { payload: { amount } }) {
    return { counter: state.counter + amount }
  }
}, defaultState);

Maybe I'm missing something, but the reducer looks odd to me, as from the docs I understood that handleActions() takes a map where the keys should be strings or action creators, and the value should be the reducer function for that action type.
But in the tutorial example there's no colon character between the key and the value of the map.

Now I got your point.
These are "Shorthand method names" and part of ES2015, so nothing wrong here, but not really beginner friendly, if you are new to ES2015.

Oh, now I see, it's this thing: http://es6-features.org/#MethodProperties
It looks weird, but now I get it, ahaha
If the code is correct, even if a bit cryptical, shall we keep the docs as they are, what do you think?

It's okay for me to change it to make more beginner friendly.

Thx!  :)


Storage filling is too slow

Upon running the farmer, filling up the disks with data takes too much time. It fills at a pace about 1,5TB/day. For a PB storage it would take 2 years to complete. Am I doing something terribly wrong here ?
ps: dataserv-client (v2.1.2) consumes %100 on a single core only, iowait is not an issue at all.

Currently we are using the RandomIO library to handle data generation. It currently does not handle multi-threading. We would love to put a bounty on it, and have someone handle that. @mtlynch has most recently working on it. We plan on discarding RandomIO in the future, so we are not keep to add too much support to it, but in the short term it would be nice to be faster.

I'm no expert, but this:
import os
with open('output_file', 'wb') as fileout:
fileout.write(os.urandom(134217728))
Drops a 'random' 128MB file on my disk before I can blink.

@bsom see RandomIO on how we generate the data.

OK, I see that.  You want hex?
import os
import binascii
with open('output_file','wb') as fout:
fout.write(binascii.hexlify(os.urandom(67108864)))
:-)

Handling this in #136


Handling multiple Set-Cookie headers in a response

Great extension, btw.  I am hitting a site that actually returns multiple Set-Cookie headers in the response.  Certainly poor practices and doesn't make much sense, but I have no control to fix the API I am hitting.
How can this be handled?  I am assuming the .getResponseHeaderByName("Set-Cookie") would need to be able to return an Array versus an expected string.  I am attempt a fix but my JavaScript is a bit weak.
Thanks again.

Sorry for the delay; I haven't noticed this issue being opened.
I think I can add support for this by using responseHeaderString instead of getResponseHeaderByName, and parsing the response headers myself.
Is this issue still important to you or have you moved on / found a workaround?


Cannot use helm values file to enable console.config.connect

From a customer:

Found another bug in Console Helm Chart. Helm values console.config is not taken into account as the element is evaluated internally. Hence I cannot use Helm values to enable console.config.connect. https://github.com/redpanda-data/helm-charts/blob/main/charts/redpanda/templates/console/configmap.yaml#L66

@vuldin I am facing this issue as well. Do you suggest any temporary workaround?
I am not very familiar with Helm. 😢

The workaround would be to set console.enabled=false in the redpanda chart and to install the console chart separately.

Just to make sure I understand the expectation here, what is the goal of setting redpanda.console.config.connect?

@joejulian for my case, I simply want to enable connect view on RedPanda Console


The "auto" options no longer work with version 0.35.0 (or newer)

None of the "auto" options seem to be working anymore.  For example, the "volar.autoCreateQuotes" and "volar.autoClosingTags" options have no effect.
Is there a setting change needed to make these work again?

Hi, I apologize for the delayed response. Due to an update to the language server, features like autoClosingTag have not working.
I tried to adjust the feature on the coc-volar side, but since the coc.nvim library itself hasn't been updated recently, it was difficult to make adjustments.
I will try to implement the feature again when I have time.

Thanks.  I have reverted to an older version of coc-volar in the mean time since I find the auto features quite useful.  I will await it being re-implemented.

Hi. I haven't been able to work on reimplementing this feature yet. :(
As an alternative, I think it's a good idea to use autoClosingTag-related plugins for vim/neovim.
By the way, I use windwp/nvim-ts-autotag for some filetypes.

Thanks.  I will look into it.


Update Firebase Auth + GoogleSignIn docs

Hey there - I see Firebase Authentication on iOS got updated to support GoogleSignIn 5.0.0, but the docs haven't been updated. Would it be possible to update the documentation to reflect the necessary changes for the new version of the library?
Thanks!

Fixed in cr/284802577 (internal link)


perf: parallelize FTS indexing

parallelizing tokenizing
processing doc's tokens by batch to avoid holding write lock for a long time
parallelizing collecting token occurrences
don't concat batches of inverted lists
don't clone the token strings when writing the TokenSet

It's can't fully utilize the CPU cause the indexing process isn't friendly to parallelism, it's about 800% utilization with my 16 cores machine. But this still depends on the data, MS MARCO contains too many tokens that aren't English words.
the indexing time has been reduced to less than 7min from 25min on MS MARCO dataset.

Codecov Report
Attention: Patch coverage is 57.71812% with 63 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (9d335f6) to head (3bd9a56).
Report is 5 commits behind head on main.

Files with missing lines
Patch %
Lines

rust/lance-index/src/scalar/inverted/builder.rs
72.63%
22 Missing and 4 partials :warning:

rust/lance-index/src/scalar.rs
26.31%
14 Missing :warning:

rust/lance-index/src/scalar/inverted/index.rs
50.00%
12 Missing :warning:

rust/lance/src/index.rs
0.00%
8 Missing :warning:

rust/lance-index/src/scalar/inverted.rs
0.00%
2 Missing :warning:

rust/lance/src/index/scalar.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2807      +/-   ##
==========================================
- Coverage   78.57%   78.44%   -0.13%
==========================================
  Files         227      228       +1
  Lines       68508    69343     +835
  Branches    68508    69343     +835
==========================================
+ Hits        53832    54399     +567
- Misses      11606    11878     +272
+ Partials     3070     3066       -4

Flag
Coverage Δ

unittests
78.44% <57.71%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nice - I have a few general questions:

FTS index on the wikipedia dataset in S3 took me about 3h. Was it taking you ~30min before this change and is this difference due to local FS vs S3?
Do we have a rough heuristic to estimate memory use? We will need this to size Indexer pods appropriately.

No, that 30min is for MS MARCO dataset, I hadn't tested on wikipedia dataset, today I tried it with the branch for wikipedia dataset, it's about 12min (local FS).
yes but not accurate: the inverted lists contribute most of the memory footprint, for words in a doc, we store row_id (u64), freq (f32) for each unique one, and position (i32) for each one. If all words are unique, English words are with avg length 5~6, which is only 5 bytes. So 3x documents size should be sufficient. In fact, it's impossible all documents contain diff words, so 2x might be enough. I can measure this for several datasets later


yw: fix unintensional recursion in hash_into

IdPath is an std::vector<IdString> with extra methods and should be hashed as std::vector<IdString>. That was the intention behind this implementation but it ended up creating unintential recursion

To trigger SBY tests, I had to push a commit to change the actions criteria. The SBY tests passed, so I force pushed it away again and we're good to merge


Wrong hint stacking for some elements

For example here https://github.com/knausj85/knausj_talon/tree/main

Another example here: https://www.apple.com/store

The apple store one doesn't happen anymore. For the other one the stacking context is right, it's just a matter of neighboring elements being placed on top of the hint. In any case the hint is still mostly visible in most cases. I can't check every neighboring element to see if it's going to obscure the hint and this is a very rare case, so I'm going to this one.