Update User Interface

The User Interface looks a bit outdated. Updating the UI would increase the user experience and would make this project more distinguishable from the original cFIREsim.
I made a rough draft on how the redesign could look like, see attached. We'd have two columns left for data input and right for the simulation result. The right columns could stay fixed on desktop, so it's always visible. Would jump to the bottom for mobile.
Looking forward to hear your thoughts!

Firstly apologies, i was waiting for your response but hadn't gotten the notification. Turns out I wasn't watching my own repository!
I do like the look and overall feel of the redesign.
I do agree that the layout could be improved to help enter data. I have a couple of comments or questions about the layout you are proposing:

Currently we can enter multiple pensions/other income/other expenditure lists. How would this be handled in your new layout?
Currently the system can handle multiple results (up to 10) and let the user go back and compare previous simulations. Do you have a method of saving these results in the new layout?
The current layout is handled by bootstrap. Are you planning on using this or a different tool or would you have something completely custom? Whatever your plan, I am keen to minimise load times/performance as much as possible (I often work on a slow connection and bloat is something that annoys me).

Thanks again for your work.

Hey, thank you for your response.
Concerning your comments:

Currently we can enter multiple pensions/other income/other expenditure lists. How would this be handled in your new layout?

Two options here: Either through tabs inside the container or adding a row below the first eg. Pension.

Currently the system can handle multiple results (up to 10) and let the user go back and compare previous simulations. Do you have a method of saving these results in the new layout?

Good point. I haven't thought about the header yet, but the save & load buttons could stay there, same for the links of course. For the results, I'd go for tabs.

The current layout is handled by bootstrap. Are you planning on using this or a different tool or would you have something completely custom? Whatever your plan, I am keen to minimise load times/performance as much as possible (I often work on a slow connection and bloat is something that annoys me).

Never used bootstrap before, but it's an easy solution. Not sure if Bootstrap is really what's impacting load times, might be some other JS going on. Either way is possible. My suggestion is using bootstrap as a start, see how it works with the option to scrap it later on in the process.
Concerning the results:
The data could simulate additional things like Coast-Fire etc, so we have plenty of room for that on the right column.
Let me know what you think and if you have any further thoughts, suggestions and feedback.

In terms of bootstrap or not, I am not bothered either way. I just want to
ensure that we don't make things worse.
I am sure that the javascript libraries are not optimal and I hope to make
more progress in simplifying and cleaning up the code that will make this
better.
I think it is worth creating a branch and having a go at making changes.
Any time you think it is worth updating the main site, let me know and we
can see about merging the changes in.
If you have any questions, please let me know.
Thanks
Alistair Marshall
www.a14m.uk
On Sun, 10 May 2020 at 19:54, Taschmahal<EMAIL_ADDRESS>wrote:

Hey, thank you for your response.
Concerning your comments:
Currently we can enter multiple pensions/other income/other expenditure lists. How would this be handled in your new layout?
Two options here: Either through tabs inside the container or adding a row
below the first eg. Pension.
Currently the system can handle multiple results (up to 10) and let the user go back and compare previous simulations. Do you have a method of saving these results in the new layout?
Good point. I haven't thought about the header yet, but the save & load
buttons could stay there, same for the links of course. For the results,
I'd go for tabs.
The current layout is handled by bootstrap. Are you planning on using this or a different tool or would you have something completely custom? Whatever your plan, I am keen to minimise load times/performance as much as possible (I often work on a slow connection and bloat is something that annoys me).
Never used bootstrap before, but it's an easy solution. Not sure if
Bootstrap is really what's impacting load times, might be some other JS
going on. Either way is possible. My suggestion is using bootstrap as a
start, see how it works with the option to scrap it later on in the process.
Concerning the results:
The data could simulate additional things like Coast-Fire etc, so we have
plenty of room for that on the right column.
Let me know what you think and if you have any further thoughts,
suggestions and feedback.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/alistair-marshall/cFIREsim-open/issues/46#issuecomment-626372491,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6ESVHC6UM2ATT7RD5LKI3RQ3Z6HANCNFSM4MSISMCQ
.


Fix to syntax highlighting of JS example in layout-chaining docs

I love Eleventy, thank you so much for the wonderful project. First time sending in a pull request, so please don't hesitate to let me know if I didn't follow the right procedures.
Fixes this following issue:

Perfect, thank you!


Log verbosity setting is ignored

When starting the broker, --logging:logHostOutput and --logging:logPackets switches correspond to IActionLog.LogVerbosity. However, when the session is created at VS startup, that property is set to LogVerbosity.None, and so no logging takes place. regardless of what is specified in R Tools | Options | Log events.

Ultimately, this setting is supposed to come from LoggingPermissions.CurrentVerbosity according to the code. But running it under the debugger, the setter for this property is never actually called during startup. @MikhailArkhipov, could this be related to the recent refactoring of settings handling?

This should be fixed in master. Tools | Options had property that didn't match property on the settings interface (LogLevel rather than LogVerbosity). Since settings persistence uses reflection this setting was never saved or loaded.


Compile the PR #65 in MDE repo in a separate library

Took the code from this PR: https://github.com/drewnoakes/metadata-extractor-dotnet/pull/65 and compiled that into a separate library as a plugin to MDE

Note: My knowledge of the jpeg format is very basic, so I can't say for certain if the file parts are right (think we'll have to leave that part up to the original author of the MDE code)

Note: My knowledge of the jpeg format is very basic, so I can't say for certain if the file parts are right (think we'll have to leave that part up to the original author of the MDE code)

I did test the output image from this code with other libraries. https://github.com/Exiv2/exiv2 and XMP-Toolkit-SDK. Both of these were able to read the jpeg segments and correctly get the xmp out of that. Also, checked if this lib identifies different segments correctly as per this spec: https://docs.fileformat.com/image/jpeg/. But not knowing a lot of jpeg myself, couldn't say if something might break in the future


Failed to install velocyto.py in Mac - clang: error: unsupported option '-fopenmp'

While installing velocyto with pip install, i keep getting error above
clang: error: unsupported option '-fopenmp'
error: command '/usr/bin/clang' failed with exit code 1
ERROR: Failed building wheel for velocyto

above is my mac info
does anyone have an idea about it?

@parkjooyoung99 Looks like similar to your other issue created, installing from conda might help.

brew install libomp
export LDFLAGS="-L/usr/local/opt/libomp/lib":$LDFLAGS
export CPPFLAGS="-I/usr/local/opt/libomp/include":$CPPFLAGS
than
git clone https://github.com/velocyto-team/velocyto.py.git
Open the setup.py in velocyto.py directory and add '-Xpreprocessor' before '-fopenmp'
(e.g. replace extra_compile_args=['-fopenmp', "-ffast-math"] toextra_compile_args=['-Xpreprocessor','-fopenmp', "-ffast-math"])
than do
pip install -e .
This will work.


Seed approach

make the same as mimesis
check it works

within distribution setting the global numpy seed, if it inherits the value from the Field this won't be an issue in typical use but unsatisfactory. Bump numpy version to use np.default_rng(seed) instead in future if version isn't an issue.

mimesis can set a seed just via random which is not suitable for numpy approaches.
Tests needed to determine whether it works.

Can't test seed setting easily.

Removed instances of random in favour of consistent numpy.random approaches to avoid missed seed setting.

Need to scope what the implications of a numpy bump would be. Branch refactor test?
rng can be accessed via schema object or field? Global approach works well in this respect decoupling any custom functions from the object calls

Needs to be sorted before integration tests will work across versions.
Regression test example failed due to different rng implimentations across versions.


Proposal: Everything not related to UI/plugin management should be a plugin

I believe that separating all behavior (eg. settings, authentication...) not related to the core of backstage (plugin management) should be separated in their own plugins.
These plugins would of course still ship by default, so the UX is identical. The development overhead is minimal as well.
Pro's:

No patching required when companies want to disable a feature: They can simply use the plugin management system (which I assume will come) to disable the features they don't like
Cleaner code: The core modules remain small and easy to understand.
Backstage becomes it's own customer: As the core developers will have to actively use the plugin system, they will quickly detect lacking features in it and hopefully add these. I'll provide an example below.

Cons:

More boilerplate: You'll have some boilerplate as each feature becomes it's own module
Dependency management: Eg. a lot of plugins may rely on the auth plugin. What if this is disabled? This is a nice example of "backstage becomes it's own customer". Dependency management should be a feature of the plugin management system.
"Now I have to write all these subsystems as if they were APIs/libraries": I can hardly call this a con tbh.

Looking forward to your thoughts on this.

Thank you for this discussion piece!
It is indeed our goal to have a sufficient and practical level of separation/modularity. We are currently drafting several of the API surfaces, including auth (as linked to), and you'll see these arrive in the coming weeks. While we may not go for an ultra-micro-package approach, we probably do not want a kitchen sink core either.
As this is being fleshed out, you may see some things land in overly central places, e.g. things unexpectedly being put into core or even app, and then transition out into a plugin later when the patterns emerge.
Do please call us out if you feel that something is out of place though, in case we haven't considered that particular thing yet or similar.

Thanks for the response, @freben. I can totally see how micro-packaging can cause friction in many cases. The most important aspect is that features which certain clients may not need can be disabled.

Would say this issue is related to #339, as it covers inter-plugin dependencies as well

With very few exceptions, this is what we are doing. Consider this ticket "done".


A connection was successfully established with the server, but then an error occurred during the login process.

Describe the bug
Unable to open trusted connection
A connection was successfully established with the server, but then an error occurred during the login process. (provider: SSL Provider, error: 0 - The certificate chain was issued by an authority that is not trusted.)'

To reproduce
await connection.OpenAsync();

Expected behavior
It should connect
Further technical details
Microsoft.Data.SqlClient version: 4.0
.NET target: .net 6
SQL Server version:

Operating system: Win 10
Workaround
Use System.Data.SqlClient, it works.... or use Microsoft.Data.SqlClient 3.0.1

”Encrypt” is now true by default

Add
Encrypt=false
to connection string will work too

To anyone finding this, in my case it was due to the self signed server certificate. see https://github.com/dotnet/SqlClient/pull/1210#issuecomment-901568015:

Systems using SQL Server's self-generated certificate will fail after this change and the user will have to buy a certificate or create a self-signed certificate, or change their connection string. If the change was made for scenarios where the user could not modify the connection string to enable encryption, then they are left having to get new certificates.

The fixes are:

disable encryption on the client connection string with Encrypt=false
blindly trust the server certificate with TrustServerCertificate=True
use an external certificate on the sql server that is signed by a certificate authority in the clients trusted certificate authorities.
3b) if the sql server already has an externally signed certificate, trust the signing certificate authority on the client.

I was experiencing the same issue, and it was resolved after adding Encrypt=false;.


This package need to be updated for Flutter 3.0

I am getting this warning in Flutter 3.0

Please upgrade this package.
Thanks for this awesome package. 👍

looks like this repo does not supported

This package needs simple upgrading.


Develop install

I like using python setup.py develop (or equivalent pip install -e .), so I can continue working on the source code without having to reinstall the package every time I do an edit (see setuptools). For some reason, his didn't work for me with interferopy, however...
I have traced this back to a long-standing issue with develop installs (see https://github.com/pypa/pip/issues/3160 and https://github.com/pypa/setuptools/issues/230). It boils down to the fact that the code sits in interferopy/src/ and not in a folder that has the same name as the package. As far as I can see, there are a few common workarounds:

move the source to interferopy/interferopy/ (easiest solution?)
move the source to interferopy/src/interferopy/ and change package_dir = { '' : 'src' } in setup.py

Another hack is to symlink interferopy/interferopy -> src, but that isn't a solution.
I'll look at the setuptools docs to see if there is a better solution. But in any case, any thoughts/preferences on this matter? I'm happy to do a PR with the preferred option.

I have to personal attachment to the name "src", so a simple rename sounds good to me, unless this renaming can introduce new problems.


[dev-1.1.2 pick](schema change) fix memory exceeded when schema change (#11748)

In row mode schema change, it will fail sometime because memory exceeded.
When the left memory is enough for sorting but not enough for next block,
it will not flush row_block_arr which data in memory and continue to alloc next block
so it can't alloc the memory and return directly.
And if it can't alloc the memory for block, it need to flush row_block_arr and
try it again unless row_block_arr is empty.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Ignore data changes from the vendor graph?

Just a thought: should we ignore incoming data changes originating from the destination read-only graph this service is putting data into (= vendor graph)? For example, in the automatic submission flow, tasks and jobs are updated on a triplestore level, not in the specific organisation graph, so an update is triggered once for the organisation graph and once for the vendor graph.

This is now irrelevant because all services in the automatic-submission stack use graph'ed queries for reading and updating. Closing this issue.


[Bug]: It don't more enroll

What happened?
It don't more enroll, only skip without message. From 2022-10-26.

Log files is empty too.

Regards
Enroller
GUI
OS
Windows
Relevant log output
No response
Terms

[X] I am using the latest version available.
[X] I agree to follow this project's Code of Conduct

++++++++

++++++++

OK it has been fixed, will release v1.8 after a few more fixes

OK it has been fixed, will release v1.8 after a few more fixes

Waiting For It

Waiting For ver 1.8

++++++++++++++

+++++++++++++++
A N Y - U P D A T E S ?
+++++++++++++++

+++++++++++++++
A N Y - U P D A T E S ?
+++++++++++++++


Issues with Lockette Plugin

Describe the bug
Plugin thows this error:  https://pastebin.com/AnVWf7mv
To Reproduce
Set Up a server, install LocketteX, try to place a sign on a chest or door to protect it
Plugins
Citizens, CoreProtect, dynmap, Essentials, EssentialsChat, EssentialsSpawn, InventoryRollbackPlus, ItemEditor, LocketteX, LuckPerms, nLogin, OpenInv, PlaceholderAPI, ProtocolLib, TAB, Towny, TownyChat, Vault, ViaVersion, WorldEdit, WorldGuard
Version
This server is running Dionysus version git-Dionysus-"42ce9ca" (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)
Unknown version, custom build?
Misc
Great work my friend, server works amazing with java 19!

this plugin doesn't support 1.12.2

this plugin doesn't support 1.12.2

Theres two of them heres one and heres the other one and neither of them work lmao

https://www.spigotmc.org/resources/20427
with what error does it crash?

https://www.spigotmc.org/resources/20427
with what error does it crash?

Server doesnt crash, plugins simply dont work

Server doesnt crash, plugins simply dont work

test on paper

Server doesnt crash, plugins simply dont work

test on paper

I found a previous version and it kinda works

I found a previous version and it kinda works

close issue?

What's the version difference? Knowing what changed would help narrow down if this is Dionysus's fault or theirs.

What's the version difference? Knowing what changed would help narrow down if this is Dionysus's fault or theirs.

Well, I used this plugin, the latest version is 1.7.8 but that didnt worked, so I tested different versions until 1.6.7 worked fine without any issues, there are a lot of changes to list here, feel free to look at the plugin update page


Trinket or Curios whats the advantage?

I will probably add support for both, but I would love to know what the advantages / disadvantage / differences are

Apparently Trinkets and Curios will merge, so there is no need to do Curios


Exclude tests when fuzzing

Currently we run a bunch of unit tests that check the state of data structures during hashing however we hobble these data structures when fuzzing so the tests fail and are meaningless.
Exclude unit tests that test state if fuzzing.
Fix: #1409
I'm not totally sure I'm not being brain dead here but I think this is the problem :)

We should fix the unit tests so that they pass with cfg(fuzzing) ... and other than fixed-vector tests we should fix the fuzzing harness rather than disabling the tests. But this isn't really related to #1409 which is about the actual fuzztests not passing.

ok cheers, so my suspicion that I was being brain dead was correct.


15930 + 16175 Pinia upgrade and package updates/cleanup

Issue #: bcgov/entity#15930 and bcgov/entity#16175
Description of changes:

merging pinia-upgrade branch into main branch
see PR 540 and PR 541 for more details

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Temporary Url for review: https://business-create-dev--pr-544-aifmetrd.web.app

Ketaki, Karim, Argus, Hongjing, Vysakh, Chris -- you don't need to review this, but I wanted you to see the process...

This is a feature branch to which 2 of us submitted PRs. This allowed us to commit code that would break the branch, but it wasn't main branch so it didn't get auto-deployed to Dev. We may need to commit some small fixes to the feature branch, and I think they will automatically show up in this PR.

When I ran /gcbrun above, a new GitHub action (check) was run to deploy this to a temporary URL. This allows us to test the code in a deployed environment (not locally). Since this is Create UI code, an example URL is:
https://business-create-dev--pr-544-aifmetrd.web.app/registration-define-business?id=TEFUWP93U7&accountid=2288

When Ketaki and I are satisfied with our testing on this temporary URL, I will merge this feature branch into main branch, where it will be auto-deployed to Dev and eventually make its way to Test and then Prod.

Let me know if you have any questions.

Temporary Url for review: https://business-create-dev--pr-544-aifmetrd.web.app

When I ran /(deleted) above, a new GitHub action...

And I just realized that having the command in my comment above kicked off the GH action again, haha. So now we know :)

/gcbrun

Temporary Url for review: https://business-create-dev--pr-544-aifmetrd.web.app


Filter out courseruns that can't be upgraded when displaying the upsell dialog

What are the relevant tickets?
Partial fix for mitodl/hq#3109
Description (What does it do?)
If there are two active course runs, both with products but one of which is ineligible for upgrade, the upsell dialog will allow you to upgrade that particular course run where you shouldn't be able to. This adds some filtering to keep that from happening.
How can this be tested?
Set up two course runs that overlap. Both should have products and allow for upgrading, but the one that starts the latest should have an upgrade deadline in the past. (So, if you have ones that has both start dates as 2023-11-01 and one that has both start dates as 2023-11-15, the 2023-11-15 one should be the one with the upgrade deadline set in the past.)

On main, you should be able to upgrade, and you should be able to select the second course run and upgrade it.
In this branch, you should be able to upgrade but you won't see the selector at all.

If you add a third course run that overlaps and is eligible for upgrade, you should see two course runs but not the ineligible one.

@jkachel flow is complaining.

fixed in https://github.com/mitodl/mitxonline/pull/2023/commits/492c7b0656c10b68096a059ef374376120330501

Thanks for reviewing this @annagav


Rename Repository

the internal adapter component, currently called a Repository, is not an example of the repository pattern, and could cause confusion  when discussing ROMs place in the overall storage arcitecture  of an application.
It would be better if this component had a different name.  I'm not terribly sure what that name is, right now ... reasonable options could include Datastore or Gateway  but I'm open to other ideas.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/13732393-rename-repository?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F155789&utm_medium=issues&utm_source=github).

I'm leaning towards Datastore because it would play nice with Dataset. OTOH only exposes access to datasets, so hmmm maybe Gateway? As in a gateway to access datasets?

I like Gateway!
Should we deprecate the usage of Repository somehow to make the transition easier?

Yes that's the plan
On Sat 9 May 2015 at 08:54 Peter Suschlik<EMAIL_ADDRESS>wrote:

I like Gateway!
Should we deprecate the usage of Repository somehow to make the
transition easier?
—
Reply to this email directly or view it on GitHub
https://github.com/rom-rb/rom/issues/219#issuecomment-100436987.

Gateway is okay from my perspective.

Yeah, like gateway to another realm, gateway to another dimension or just gateway to postgresql ;)
Anyhow, do you think it's reasonable to schedule this change for 0.7.0? It's a massive rename + deprecate work but shouldn't be hard, just tedious. Hmm.

Yeah -- Gateway is the name for a (family) of patterns that are basically thin access to an external system.  Provide a focused internal api around a RestClient library, that sort of thing.  It actually fits our usage really well here.
I suspect it's reasonable to chase for 0.7.0, unless we're looking to release on Monday.  ;)
Transitionally, we need to add Gateway to the various lookups, add deprication warnings (is there a standard way of doing that?) for Repository, and update the linters.

I was thinking about May 20ish as the release date. I have to admit that this change would be very low on my personal priority list so help would be appreciated.

Oh and regarding deprecations: no, we don't have anything in place yet. I think we should put something together as deprecations is not something we'll manage to avoid after all.

Alternatives to ROM::Gateway I just thought of: ROM::Store or ROM::Source.

Can we shoot for 0.8.0 with this mass-rename/deprecation? I added Deprecations module to rom/support which can be used for this easily.
Are we done deciding on the name? I'm good with Gateway :)

I like both the ROM::Gateway and ROM::Source

Source is a bit too vague, no?

Just a bit.  :)
0.8 sounds good; I'll work on this during the week

That would be awesome. I actually start thinking about wrapping up 0.8.0 before RubyNation (June 12th). Stuff that's schedule for this release should be very time consuming...guides on rom-rb.org come first though, that's my current focus.

PR for this: #243


Pull to refresh feature

This will be a cool feature to have.

Yes, sounds like a nice feature. Contributions are always welcome :)

Hi @Reagang,
I decided to develop this feature on my own and it is part of the TableView library version 2.3.0 which was just released.
Best regards,
Ingo


Disabling Team's Names and change width

Is there a way to prevent the user from editing the Team's name? I'm loading data from DB and I want to allow the user to change just the scores.

Hi,
There's no built-in way of disabling only the edit, but you might be able to do a hack by using decorators and calling the doneCb immediately from the edit callback. See for details: http://www.aropupu.fi/bracket/#customHandlers
No built-in way of changing the size.
P.S. Please create two issues rather than merging them into one, then it will be possible to solve each separately, thanks!

I'm loading data from DB and I want to allow the user to change just the scores.

So how should it actually work in your case, should all scores be editable?

Hi teijo! Sorry for the "double issue". I have created a new one for the box width and edited here.
As you said, all the scores should be editable. When the page loads, I retrieve the scores from DB if they exists. The user is able to input new scores or edit previous ones in case of error.

Implemented in 1a5d5ede2b550b894076c90b99f7297fff2ecda0. Comes to next release.
You can give disableTeamEdit: boolean. Setting it to true will require you to also set disableResize to true, otherwise you could remove teams, therefore "editing" them.


Feature request - archive locally

Having another archive provider that is a local "service" to somehow (wget maybe) save a web page archive locally would be a great addition, I think.
Not sure best format... MAFF is good, although I've had issues finding non-Firefox support for it.

Local archiving is definitely something interesting to look into.
wget wouldn't work, because these days, a lot of websites are loading data using AJAX, but an increasing number are pretty much entirely dynamic.
An approach using headless browsers (see HeadlessBrowsers), where we wait a set time for the page to execute its JavaScript, and save the resulting DOM tree could be useful.
Another approach toward this that I was looking into was this =>

The extension injects a content script into the page
When the bookmark button is clicked, a snapshot of the DOM is transmitted to the server
This then gets stored in the database as a local archive

I think the third approach would be the best approach, with the highest accuracy. (PS: Infinite scroll pages wouldn't work with the headless browser approach).
If anyone has more ideas for this, please do share! :). I've already done some work on this that hasn't made GitHub yet (In a Chrome extension repo).
This is on the roadmap to come pretty soon.

We may want to define what we want the archive to actually store... their is the web page itself (HTML, CSS, etc.), the text of the web page (for full-text searching the archive, etc.), or an image of the web page (to show how it looked, even maybe with ads or whatever sidebar kind of things you wouldn't normally store).
I've used things like elinks to grab the basic HTML (for text searching) and http://cutycapt.sourceforge.net/ to grab an image. Actually worked fairly well.
Your content injection sounds neat, but you've past my skill level with that one :-)
Another thought is where do you store it... storing the text in the database for searching makes sense, but (an option maybe?) to store the actual HTML/whatever in an external file/archive would make sense to me.
Just some thoughts :-)

Hey @bdillahu! Apologies for the delayed response.

What we want to store:
a) We might want to store the entire visible text of the page. This can help us power full text search, and it would be better than server-side crawling.
b) Storing HTML/CSS, I think a better alternative would be to take a DOM screenshot. See this.

var page_content = $("html").clone().find("script,noscript").remove().end().html();
var page_content = replace_all_rel_by_abs(page_content);
var page_content = minify(page_content, {
                removeComments: true,
                removeCommentsFromCDATA: true,
                removeCDATASectionsFromCDATA: true,
                collapseWhitespace: true,
                conservativeCollapse: true,
                collapseBooleanAttributes: true,
                removeAttributeQuotes: true,
                removeRedundantAttributes: true,
                minifyURLs: false,
                removeEmptyElements: true,
                removeOptionalTags: true
});

This code produces an almost perfect snapshot of the DOM. It is run as a content-script by the extension. Storing images might pose a problem. Either we compress them, or they will end up taking a huge amount of space. Plus without some sort of CV pipeline that makes the images searchable, there's not a lot of benefit to image archival. Also, an image of the page would let us offer a more visual representation of the bookmarks, I'm in full support of that :).

On your point about cutycapt. It does work, but for dynamic pages we need to go through the extension and get the DOM snapshot. Right now we use PhantomJS for this, which is a mid-way approach.

On the storing the files part. Would perhaps exporting from the database into HTML make sense for you?

Obiously I agree on the image of the page for a bookmark... that sounds good :-)
Not sure I concur on images not being useful even if they aren't searchable. Part of my desire is that I have bookmarked a page and I'm archiving it... often without the pictures, it isn't going to be a lot of use (obviously depends on the page). Disk is cheap :-)
Exporting to HTML/MAFF/whatever would work... doesn't necessarily have to be stored in that format, but I think some way of "getting it out" and using it elsewhere would be important.

The average size of a webpage is 2MB. About 60% of that is taken up by images. So we're saving 1.2MB per page. ref
The images don't add up to a lot though due to disk being cheap. And that would indeed be a more complete bookmark. But this needs to be a granular setting then.
I'd suggest opening a separate feature request for the exporting ability.


Tasks register() shows already exist but not found by named() and getByName()

I want to add a doLast{} action to a regular Android project task connectedDebugAndroidTest.
But tasks.register() shows Cannot add task 'connectedDebugAndroidTest' as a task with that name already exists.  .
Also tasks.getByName() and tasks.named() shows: Task with name 'connectedDebugAndroidTest' not found in project ':app'.
Expected Behavior

I expect getByName() can find out the exist task, and allow me to append doLast{} action.
Current Behavior

Currently it shows as above.
Context

This problem exists at any android projects and kotlin-multiplatform projects.
Steps to Reproduce

It's 100% reproducible at any regular android projects.
Your Environment

macOS 10.14.4
gradle 5.4.1-all
Android Studio 3.4 / com.android.tools.build:gradle:3.4.0
IntelliJ IDEA 2019.1.1
Kotlin /kotlin gradle plugin 1.3.30-1.3.31

Thanks for submitting this issue. It seems you are facing an ordering issue. You are calling getByName or named before the task is created and calling register after the task was already register/created. We need a minimal reproducible project to know what is happening here. If you can provide a reproducible sample please reopen the issue.

Hi @lacasseio ,
Thank you for your help.
Here is a minimal android sample project: https://github.com/9468305/GradleRegister .
In file app/build.gradle.kts, below two functions build error:
Here shows error:

Cannot add task 'connectedAndroidTest' as a task with that name already exists.

tasks.register("connectedAndroidTest") {
    doLast {
        println("connectedDebugAndroidTest doLast")
    }
}

Here shows error:

Task with name 'connectedAndroidTest' not found in project ':app'.

tasks.named("connectedAndroidTest") {
    doLast {
        println("connectedDebugAndroidTest doLast")
    }
}

I reopen this issue until we have more time to look at it.
In the meantime, is the connectedDebugAndroidTest a task rule that may be provided by the Android plugin or is a created task? One thing to try in order to debug this is to check the tasks list ./gradlew tasks --all to see if the task appears or a mention of a rule at the bottom of the report.

I think the connectedDebugAndroidTest task is provided by the Android plugin.
./gradlew tasks --all shows:
> Task :tasks

------------------------------------------------------------
Tasks runnable from root project
------------------------------------------------------------

Android tasks
-------------
app:androidDependencies - Displays the Android dependencies of the project.
app:signingReport - Displays the signing info for the base and test modules
app:sourceSets - Prints out all the source sets defined in this project.

Build tasks
-----------
app:assemble - Assemble main outputs for all the variants.
app:assembleAndroidTest - Assembles all the Test applications.
app:build - Assembles and tests this project.
app:buildDependents - Assembles and tests this project and all projects that depend on it.
app:buildNeeded - Assembles and tests this project and all projects it depends on.
app:bundle - Assemble bundles for all the variants.
app:clean - Deletes the build directory.
app:cleanBuildCache - Deletes the build cache directory.
app:compileDebugAndroidTestSources
app:compileDebugSources
app:compileDebugUnitTestSources
app:compileReleaseSources
app:compileReleaseUnitTestSources

Build Setup tasks
-----------------
init - Initializes a new Gradle build.
wrapper - Generates Gradle wrapper files.

Cleanup tasks
-------------
app:lintFix - Runs lint on all variants and applies any safe suggestions to the source code.

Help tasks
----------
buildEnvironment - Displays all buildscript dependencies declared in root project 'GradleRegister'.
app:buildEnvironment - Displays all buildscript dependencies declared in project ':app'.
components - Displays the components produced by root project 'GradleRegister'. [incubating]
app:components - Displays the components produced by project ':app'. [incubating]
dependencies - Displays all dependencies declared in root project 'GradleRegister'.
app:dependencies - Displays all dependencies declared in project ':app'.
dependencyInsight - Displays the insight into a specific dependency in root project 'GradleRegister'.
app:dependencyInsight - Displays the insight into a specific dependency in project ':app'.
dependentComponents - Displays the dependent components of components in root project 'GradleRegister'. [incubating]
app:dependentComponents - Displays the dependent components of components in project ':app'. [incubating]
help - Displays a help message.
app:help - Displays a help message.
app:kotlinDslAccessorsReport - Prints the Kotlin code for accessing the currently available project extensions and conventions.
model - Displays the configuration model of root project 'GradleRegister'. [incubating]
app:model - Displays the configuration model of project ':app'. [incubating]
projects - Displays the sub-projects of root project 'GradleRegister'.
app:projects - Displays the sub-projects of project ':app'.
properties - Displays the properties of root project 'GradleRegister'.
app:properties - Displays the properties of project ':app'.
tasks - Displays the tasks runnable from root project 'GradleRegister' (some of the displayed tasks may belong to subprojects).
app:tasks - Displays the tasks runnable from project ':app'.

Install tasks
-------------
app:installDebug - Installs the Debug build.
app:installDebugAndroidTest - Installs the android (on device) tests for the Debug build.
app:uninstallAll - Uninstall all applications.
app:uninstallDebug - Uninstalls the Debug build.
app:uninstallDebugAndroidTest - Uninstalls the android (on device) tests for the Debug build.
app:uninstallRelease - Uninstalls the Release build.

Verification tasks
------------------
app:check - Runs all checks.
app:connectedAndroidTest - Installs and runs instrumentation tests for all flavors on connected devices.
app:connectedCheck - Runs all device checks on currently connected devices.
app:connectedDebugAndroidTest - Installs and runs the tests for debug on connected devices.
app:deviceAndroidTest - Installs and runs instrumentation tests using all Device Providers.
app:deviceCheck - Runs all device checks using Device Providers and Test Servers.
app:lint - Runs lint on all variants.
app:lintDebug - Runs lint on the Debug build.
app:lintRelease - Runs lint on the Release build.
app:lintVitalRelease - Runs lint on just the fatal issues in the release build.
app:test - Run unit tests for all variants.
app:testDebugUnitTest - Run unit tests for the debug build.
app:testReleaseUnitTest - Run unit tests for the release build.

Other tasks
-----------
app:assembleDebug - Assembles main output for variant debug
app:assembleDebugAndroidTest - Assembles main output for variant debugAndroidTest
app:assembleDebugUnitTest - Assembles main output for variant debugUnitTest
app:assembleRelease - Assembles main output for variant release
app:assembleReleaseUnitTest - Assembles main output for variant releaseUnitTest
app:buildDebugPreBundle
app:buildReleasePreBundle
app:bundleDebug - Assembles bundle for variant debug
app:bundleDebugAndroidTestClasses
app:bundleDebugAndroidTestResources
app:bundleDebugClasses
app:bundleDebugResources
app:bundleDebugUnitTestClasses
app:bundleRelease - Assembles bundle for variant release
app:bundleReleaseClasses
app:bundleReleaseResources
app:bundleReleaseUnitTestClasses
app:checkDebugAndroidTestDuplicateClasses
app:checkDebugDuplicateClasses
app:checkDebugManifest
app:checkReleaseDuplicateClasses
app:checkReleaseManifest
clean
app:collectDebugDependencies
app:collectReleaseDependencies
app:compileDebugAidl
app:compileDebugAndroidTestAidl
app:compileDebugAndroidTestJavaWithJavac
app:compileDebugAndroidTestKotlin - Compiles the debugAndroidTest kotlin.
app:compileDebugAndroidTestRenderscript
app:compileDebugAndroidTestShaders
app:compileDebugJavaWithJavac
app:compileDebugKotlin - Compiles the debug kotlin.
app:compileDebugRenderscript
app:compileDebugShaders
app:compileDebugUnitTestJavaWithJavac
app:compileDebugUnitTestKotlin - Compiles the debugUnitTest kotlin.
app:compileLint
app:compileReleaseAidl
app:compileReleaseJavaWithJavac
app:compileReleaseKotlin - Compiles the release kotlin.
app:compileReleaseRenderscript
app:compileReleaseShaders
app:compileReleaseUnitTestJavaWithJavac
app:compileReleaseUnitTestKotlin - Compiles the releaseUnitTest kotlin.
app:configureDebugDependencies
app:configureReleaseDependencies
app:consumeConfigAttr
app:createDebugCompatibleScreenManifests
app:createMockableJar
app:createReleaseCompatibleScreenManifests
app:extractApksForDebug
app:extractApksForRelease
app:extractProguardFiles
app:generateDebugAndroidTestAssets
app:generateDebugAndroidTestBuildConfig
app:generateDebugAndroidTestResources
app:generateDebugAndroidTestResValues
app:generateDebugAndroidTestSources
app:generateDebugAssets
app:generateDebugBuildConfig
app:generateDebugFeatureMetadata
app:generateDebugFeatureTransitiveDeps
app:generateDebugResources
app:generateDebugResValues
app:generateDebugSources
app:generateDebugUnitTestAssets
app:generateDebugUnitTestResources
app:generateDebugUnitTestSources
app:generateReleaseAssets
app:generateReleaseBuildConfig
app:generateReleaseFeatureMetadata
app:generateReleaseFeatureTransitiveDeps
app:generateReleaseResources
app:generateReleaseResValues
app:generateReleaseSources
app:generateReleaseUnitTestAssets
app:generateReleaseUnitTestResources
app:generateReleaseUnitTestSources
app:javaPreCompileDebug
app:javaPreCompileDebugAndroidTest
app:javaPreCompileDebugUnitTest
app:javaPreCompileRelease
app:javaPreCompileReleaseUnitTest
app:mainApkListPersistenceDebug
app:mainApkListPersistenceDebugAndroidTest
app:mainApkListPersistenceRelease
app:makeApkFromBundleForDebug
app:makeApkFromBundleForRelease
app:mergeDebugAndroidTestAssets
app:mergeDebugAndroidTestJniLibFolders
app:mergeDebugAndroidTestResources
app:mergeDebugAndroidTestShaders
app:mergeDebugAssets
app:mergeDebugJniLibFolders
app:mergeDebugResources
app:mergeDebugShaders
app:mergeDexDebug
app:mergeDexDebugAndroidTest
app:mergeDexRelease
app:mergeExtDexDebug
app:mergeExtDexDebugAndroidTest
app:mergeExtDexRelease
app:mergeReleaseAssets
app:mergeReleaseJniLibFolders
app:mergeReleaseResources
app:mergeReleaseShaders
app:packageDebug
app:packageDebugAndroidTest
app:packageDebugBundle
app:packageDebugUniversalApk
app:packageRelease
app:packageReleaseBundle
app:packageReleaseUniversalApk
app:preBuild
app:preDebugAndroidTestBuild
app:preDebugBuild
app:preDebugUnitTestBuild
prepareKotlinBuildScriptModel
app:prepareKotlinBuildScriptModel
app:prepareLintJar
app:prepareLintJarForPublish
app:preReleaseBuild
app:preReleaseUnitTestBuild
app:processDebugAndroidTestJavaRes
app:processDebugAndroidTestManifest
app:processDebugAndroidTestResources
app:processDebugJavaRes
app:processDebugManifest
app:processDebugResources
app:processDebugUnitTestJavaRes
app:processReleaseJavaRes
app:processReleaseManifest
app:processReleaseResources
app:processReleaseUnitTestJavaRes
app:reportBuildArtifactsDebug
app:reportBuildArtifactsRelease
app:reportSourceSetTransformAndroidTest
app:reportSourceSetTransformAndroidTestDebug
app:reportSourceSetTransformDebug
app:reportSourceSetTransformMain
app:reportSourceSetTransformRelease
app:reportSourceSetTransformTest
app:reportSourceSetTransformTestDebug
app:reportSourceSetTransformTestRelease
app:resolveConfigAttr
app:signDebugBundle
app:signingConfigWriterDebug
app:signingConfigWriterDebugAndroidTest
app:signingConfigWriterRelease
app:signReleaseBundle
app:transformClassesWithDexBuilderForDebug
app:transformClassesWithDexBuilderForDebugAndroidTest
app:transformClassesWithDexBuilderForRelease
app:transformNativeLibsWithMergeJniLibsForDebug
app:transformNativeLibsWithMergeJniLibsForDebugAndroidTest
app:transformNativeLibsWithMergeJniLibsForRelease
app:transformNativeLibsWithStripDebugSymbolForDebug
app:transformNativeLibsWithStripDebugSymbolForRelease
app:transformResourcesWithMergeJavaResForDebug
app:transformResourcesWithMergeJavaResForDebugAndroidTest
app:transformResourcesWithMergeJavaResForDebugUnitTest
app:transformResourcesWithMergeJavaResForRelease
app:transformResourcesWithMergeJavaResForReleaseUnitTest
app:validateSigningDebug
app:validateSigningDebugAndroidTest
app:writeDebugApplicationId
app:writeDebugModuleMetadata
app:writeReleaseApplicationId
app:writeReleaseModuleMetadata

BUILD SUCCESSFUL in 0s
1 actionable task: 1 executed

I can confirm this, having a test task in a Kotlin multiplatform project shared:test - Run unit tests for all variants. that is added by the Android library plugin and listed during ./gradlew task --all.
I can neither findByName("test") or register("test").
Gradle 5.4.1
Kotlin 1.3.31 with Kotlin-DSL

Any progress on this?

I can still experience this issue. My environment is:
Android Studio 4.1.3
Build #AI-201.87<IP_ADDRESS>99119, built on March 11, 2021
Runtime version: 1.8.0_242-release-1644-b3-6915495 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.16
GC: ParNew, ConcurrentMarkSweep
Memory: 1979M
Cores: 12
Registry: ide.new.welcome.screen.force=true, external.system.auto.import.disabled=true, debugger.watches.in.variables=false
Android Gradle plugin 3.5.4
Gradle 6.5

Experiencing the same AGP 7.2.2

same issue. but using ksp.
i want to get the .destination defined in task "kspKotlin" but gradle is unable to find the task.
in all tasks it shows up though. and ksp is able to generate files. but i can't get it.
does anyone have any idea how to fix this?

I had maybe a similar issue.
With this:
tasks.named("check")...

It was failing because I have a module called modules that is just a wrapper of submodules.
Thus, it didn't find the task check because it actually didn't exist.
I have skipped it using this simple check.
def check = "check"
if (tasks.getNames().contains(check)) {
    tasks.named(check)...
}

Hope it helps!

Gradle 8.3 here and this issue still exists... why is this closed?

Yes, that's a problem. I'd like to execute custom script before running 'connectedAndroidTest' phase but got "Task with name 'connectedAndroidTest' not found".

why is this issue closed with no answer when so many people are having similar issues. There is not good documentation on how ordering works if that is the problem and the tasks LITERALLY show up in the gradle task list. What is going on here, explain it to us, fix the issue, or do something except just ignoring everyone and closing the issue.

I am having a similar issue ./gradlew tasks --all shows :app:generateReleaseResValues, but I am unable to do something like:
tasks.named("generateReleaseResValues") {
    dependsOn("myCustomTask")
}

I get error message Task with name ':app:generateReleaseResValues' not found in project ':app'.


Tables vrules : adds vertical rules to tables (latex/pdf output)

Works with all kind of Pandoc supported Markdown tables.

The Latex hack based on patching \LT@array doesn't work anymore for Multiline and Pipes tables with current versions of Pandoc.
A Lua filter should hopefully have less compatibility issues and be easier to maintain.

Thanks for this. We put merging of new filters on hold for the time being, see #207 for details.
If you want to publish the filter in its own repository, please consider using https://github.com/tarleb/lua-filter-template and let us know about any problems with that repo.


Unscoped doesn't apply to preload

How can I just query normally without all the act_as_paranoid magic? For example, Blog.unscoped.preload(:comments) will pull only non-deleted comments.

Won't Blog.with_deleted.preload(:comments) work ?

This seems related to #110.


update contributing.md to include the command to pull in the git submodules

yarn update-submodule
... or perhaps find a way to make it be automatically gotten when the project is prepared.

We got rid of the submodules so this task obviated


PSVariable ToString() should be the name of the variable

Summary of the new feature / enhancement
As a developer, I want to able to easily identify variables and efficiently get a number of variables.
Proposed technical implementation details (optional)
PSVariable should implement .ToString() and return the name of the variable (or the name of the variable prefixed by $).
This would make the code below work:
@(Get-Variable) -in ([string[]]$psBoundParameters.Keys)  # Get the actual variables of every psBoundParameter
@(Get-Variable) -match '^ps' # match returns the original item if it matches

Sounds useful, but note that while your -match example would then work, the -in one would not (ditto for -contains): the LHS of -in can only be a scalar; an array(-like) LHS is quietly - and unhelpfully - stringified; e.g., 1, 2 -in '1 2' is $true). Similarly, -like wouldn't work, because - unlike -match - it passes the stringified input objects through (see #15172).


allow Pan, Rotate and Zoom using touch

https://github.com/ros2/rviz/commit/718948c3dadf449814e098b966f5b023f24129b0 is the proof of concept, which works fine.
The scope of this PR needs to be defined first, as the proof of concept is a hacky solution with which sending goal pose and all also works, without affecting mouse controls. If a proper code structure is added for this, then the PR might get big.
ToDo:

[ ] create ViewportMouseEvent for Touch Events
[ ] add touch gestures for several view controllers
[ ] add a toggle to enable this in view controller tab

Suggestions are welcome and needed. Thank you

hello, any suggestions would be appreciated


Java runtime: batching

Close #4391

Marking as WIP for now, will introduce an HttpEngine interface, which will induce a refact of this one.


Scala Hadoop Shred: bump Scala Iglu Client to 0.1.1

I guess, this can be closed.

November 2014! Where does the time go... Closing.


Is there any way to get an error message when the exception is thrown by the message->invoke() method?

When the exception is thrown by the message->invoke() method then I'm unable to get the error code. The only thing I can get is $e->getMessage() that returns just an error message string.
It would be good if there was a method that returns the native Nexmo response
Correct me if I'm wrong.
// Edit:
This is how i solved the problem, but this is not an elegant solution at all.
$message = $e->getMessage();

$response = [
    'status' => null,
    'errorMessage' => $message
];

$errorMessageArray = explode(' - status ', $message);

if (count($errorMessageArray) === 2) {

    $response = [
        'errorMessage' => $errorMessageArray[0],
        'status' => $errorMessageArray[1]
    ];

}

It should be fairly easy to include the raw response as part of the exception, but the point of exceptions in cases like this is to abstract away the underlying specificity and instead include your own messages/codes.


Multiple renderings will result in weird results (part of ESP Easy new front end)

I'm using the library v1.0.0-rc.5 to dynamically add  simple screenshots of object which are hard to screenshot manually. This is mainly long lists of settings and/or information.
The problem I'm facing is that after rendering one object then another and then the first one will either add an offset or a Uncaught (in promise) Unable to find element in cloned iframe. You can see the different renders of the same object:

PS. this is part of https://github.com/letscontrolit/ESPEasy new GUI. I post memo's here for anyone interested: http://grovkillen.dribbble.com/
Thanks you all your efforts, I know how much work it's behind it. Great job guys and g'als!

I've been experimenting with this and the problem was that I left some empty div's (no height) that seemed to mess up the screenshot rendering. I make sure to flush these out and the problem is gone.


Discord

Hi there!
I am absolutely loving this fork and the whole idea of all the extra features you've added. I was wondering if I could perhaps add you to Discord and ask a few questions.
I would really appreciate it.
Thanks a lot and keep up the great work! 🔥

Hi! Thanks for your interest. I'm afraid I don't give out y Discord publicly, but I'd be glad to answer any questions you have here in Issues. That way, others with the same questions can see their answers too.

Hi! Thanks for your interest. I'm afraid I don't give out y Discord publicly, but I'd be glad to answer any questions you have here in Issues. That way, others with the same questions can see their answers too.

Ah I see! That makes sense actually. Basically I was wondering if it is possible to run a specific workflow without booting ComfyUI at all or if there are any other posibilities here.
I tried out your fork and I had a few issues here and there that I wasn't able to fix just yet, but I also noticed that it does boot up ComfyUI. First I thought this just exported to native Python code and wouldn't need ComfyUI at all or atleast on it's own, standalone.
Maybe this is not possible at all but fairly new here, so yeah not quite sure.

While it would theoretically be possible to run the code without booting up ComfyUI, it probably wouldn't be realistic. Support for custom nodes especially relies on the fact that we simulate the ComfyUI server and its execution environment. We can't predict what aspects of the ComfyUI server custom nodes will rely upon.
We could make a framework that would mimic a lot of the features of the ComfyUI server, but at that point, we're just reimplementing ComfyUI. That code was implemented by the original maintainer, but I don't believe the server should actually be listening for requests. It's just there for the API.


Warn Gen Issue on Mac

Warn gen says I need to have workstation host name. Can someone help me??

In CAVE > Preferences you should have a Text Workstation server option which should be set to "localhost".

I got it to work. I was able to use my localhost and then it worked. I do thank you for the advice. I hope you have a great rest of your day, wherever you are in the world.

The chat can be closed now, by the owners of the issue page. I really appreciate the help.


ESLint regression build failing

ESLint core has a nightly regression build that runs unittests and lints a few popular projects with the latest master. For the last two days it's been failing on eslint-plugin-react unit tests. Not sure if it's a real problem or not.
  1) no-unused-vars invalid /*eslint jsx-uses-react:1*/ var React;:

      AssertionError: '\'React\' is defined but never used.' == '\'React\' is defined but never used'
      + expected - actual

      -'React' is defined but never used.
      +'React' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  2) no-unused-vars invalid /*eslint jsx-uses-react:1*/ /** @jsx Foo */ var React;
;:

      AssertionError: '\'React\' is defined but never used.' == '\'React\' is defined but never used'
      + expected - actual

      -'React' is defined but never used.
      +'React' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  3) no-unused-vars invalid /*eslint jsx-uses-react:1*/ var React;
;:

      AssertionError: '\'React\' is defined but never used.' == '\'React\' is defined but never used'
      + expected - actual

      -'React' is defined but never used.
      +'React' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  4) no-unused-vars invalid /*eslint jsx-uses-vars:1*/ var App;:

      AssertionError: '\'App\' is defined but never used.' == '\'App\' is defined but never used'
      + expected - actual

      -'App' is defined but never used.
      +'App' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  5) no-unused-vars invalid         /*eslint jsx-uses-vars:1*/        var App;        var unused;        React.render(<App unused=""/>);:

      AssertionError: '\'unused\' is defined but never used.' == '\'unused\' is defined but never used'
      + expected - actual

      -'unused' is defined but never used.
      +'unused' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  6) no-unused-vars invalid         /*eslint jsx-uses-vars:1*/        class unused {}:

      AssertionError: '\'unused\' is defined but never used.' == '\'unused\' is defined but never used'
      + expected - actual

      -'unused' is defined but never used.
      +'unused' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  7) no-unused-vars invalid         /*eslint jsx-uses-vars:1*/        class HelloMessage {          render() {            var HelloMessage =
Hello
;            return HelloMessage;          }        }:

      AssertionError: '\'HelloMessage\' is defined but never used.' == '\'HelloMessage\' is defined but never used'
      + expected - actual

      -'HelloMessage' is defined but never used.
      +'HelloMessage' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

  8) no-unused-vars invalid         /*eslint jsx-uses-vars:1*/        class HelloMessage {          render() {            var HelloMessage =
Hello
;            return HelloMessage;          }        }:

      AssertionError: '\'HelloMessage\' is defined but never used.' == '\'HelloMessage\' is defined but never used'
      + expected - actual

      -'HelloMessage' is defined but never used.
      +'HelloMessage' is defined but never used

      at testInvalidTemplate (node_modules/eslint/lib/testers/rule-tester.js:407:36)
      at Context.<anonymous> (node_modules/eslint/lib/testers/rule-tester.js:463:25)

Let me know if you want/don't want me to post those issues in the future.

Did eslint change to add or remove a trailing period on error messages?

Add: https://github.com/eslint/eslint/pull/6739

@ilyavolodin Thanks - the regression build + issue post is awesome. Technically that change constitutes a breaking change, since our tests are now breaking.
However, eslint-plugin-react does not yet support eslint 3, and this is just tests. I'll try to update the test messages so they pass both with and without the periods - hopefully that will ensure there's no other failures.

Actually, it kind of seems like eslint's own RuleTester should maybe ignore trailing periods, since that's what we're using to validate this (or, accept a regex rather than a string)?

ESLint v3.2.0 was just published with this "breaking" change. I updated the dependencies and the tests to match with the new error message.

Linking to https://github.com/yannickcr/eslint-plugin-react/commit/19ece14135897da6bf887ac3a818b0918b74da61


serialization caching

to #366

some abaplint bug on macro object_check_timestamp. Maybe it doesn't like "object" in the name ?

yeah, files are sorted alphabetically, and the macro must appear in a file before its used
can you try moving the macro to https://github.com/larshp/abapGit/blob/master/src/zabapgit_definitions.prog.abap ? and rename so it starts with '_'

macro:
It is indeed complex for a macro.
But I'm not sure how to convert it to a method. Return is needed there and sy-subrc is checked. A method would have 3 params + return value + after method check if the execution should be stoped. It is almost the same number of lines repeated through many places which will spoil code clarity. Is it ok to just move it to definition + prefix with '_' ?
Variables:
Not that simple. my_local cannot be cleared - it is used to check new objects. mv_last_serialization is a timestamp to check objects were updated. So they are needed. And so there should be an option to initiate refresh. That's mv_do_local_refresh. Not sure that it can be redured although indeed looks overweighted a bit. Maybe name them more clearer ? But not sure how.
lt_cache  vs mt_local. This is possible. But not ideal from performance perspective. mt_local (rt_files in fact) is appended line by line later in code - not good for sorted table. Option is to convert mt_local to sorted but get_files_local will return standard. Or collecting to standard internally (that mean analog of lt_cache anyway) and then assigning to sorted mt_local and rt_files. Maybe the last option is the best, because status then can take advantage of sorted table.
mv_last_serialization IS NOT INITIAL: can do. in this case it is the same indeed. Still mv_last_serialization remains used.
pls comment before I do the changes. More questions than answers :)

macro: yes, just move and rename will be okay IMHO
variables: okay, just keep as is, we can always look into it later. It will be easier for me to understand once its merged and I have the ABAP code installed

done. Also added dedicated include for macros - probably all macros can be moved there.
lt_cache vs mt_local topic: maybe I'll adjust to the proposed option but a bit later. I have some idea to improve status performance (although it is not critical - more for fun) - I'll need sorted table there.

thanks :+1:

Just by the way. decided to measure serialization time of diff types. Not the best statistics - some of types occur just once in my Big Package. But still as a prioritization list.
TYPE      COUNT    AVG TIME PER 1
FUGR         21          0,066248
SHI3          1          0,044075
VIEW          4          0,014691
TABL         44          0,014305
PROG         72          0,009246
MSAG          1          0,008687
W3MI          1          0,008601
NROB          2          0,007391
TTYP         26          0,005796
XSLT         15          0,005324
CLAS         33          0,004824
SHLP         11          0,004363
ENQU          1          0,003753
TYPE          1          0,003052
INTF          1          0,002841
TOBJ         18          0,002286
TRAN         17          0,001884
DTEL        110          0,001224
DOMA         24          0,001191
PARA         10          0,000971
ENHS          1          0,000930

Looks like most heavy are actually done.


Support optional / on demand jobs

This PRs will allow repositories to have optional / on demand tests.
This will eventually be used when we onboard SO repo.

We have an immediate use case for this in eventing-hyperfoil repo, I've not tested this deeply but I think testing it with a repo that needs this will make it easier and we can iterate as we found issues.

/cc aliok

@pierDipi
https://github.com/openshift/release/compare/master...aliok:release:sync-serverless-ci-tmp3 is this what a good output look like in your opinion?

/close
Closing in favor of https://github.com/openshift-knative/hack/pull/42


No Bug - Fix import/exports. Organize the types and components exports. Code refactoring. Fix code styles.

Going to have to trust you on this one.


[Logging] Skip TestListEntries because it's flaky.

We don't get a lot of info, it's just timing out.

I've skipped it in #1067

I've skipped all of Login tests, they constantly time out on Linux and often time out on Windows. These need a good review/rewrite.


Open Coverage File Automatically on Test Command?

Is there any configuration setting that serves or pops open the coverage file in a browser window? I am looking for a solution to have it open up on command instead of digging for the file and opening static html. Thanks so much for any direction on this and thanks for writing this package! Huge help to our team.

Hey there @tracyalison11!
If you're using npm or yarn, would calling
test: [incantations of all the testing and covering] && open coverage/lcov-report/index.html

not work?
Or even have a script such as:
"openCoverage": "open coverage/lcov-report/index.html"

And calling npm run openCoverage or yarn openCoverage work?


[datasets] Added Bangla characters to VOCABS

This PR:

Add new vocab (bangla)
Add corresponding docs entry

Closed by #1687


Update testing information in README.md

Update testing information - test.bat starts KitchenSink automatically.

The above is not true, but still the testing information in README.md needs updating.
@KmaTTi89 please update https://github.com/StarcounterSamples/KitchenSink/blob/develop/README.md#run-the-test-from-command-line.
It seems that point 2 can be removed and points 3, 4, 5 should be changed to use the BAT files.

I will change that

Done in https://github.com/StarcounterSamples/KitchenSink/pull/96

Thanks, closing


test: posix/pthread_rwlock

tests/posix/pthread_rwlock/portability.posix calls pthread_attr_destroy() on the uninitialized, stack allocated, pthread_attr_t attr[N_THR]; leading to undefined behaviour:
starting test - test_rw_lock

main acquire WR lock and 3 threads acquire RD lock
==18028== Thread 5:
==18028== Conditional jump or move depends on uninitialised value(s)
==18028==    at 0x80507F5: zap_pthread_attr_destroy (pthread.c:533)
==18028==    by 0x8049D4E: test_rw_lock (posix_rwlock.c:83)
==18028==    by 0x80559FC: run_test_functions (ztest.c:56)
==18028==    by 0x8055BB7: test_cb (ztest.c:196)
==18028==  Uninitialised value was created by a stack allocation
==18028==    at 0x804982F: test_rw_lock (posix_rwlock.c:55)

I ran this on qemu_x86 and I don't see any issue. test passed. How do i reproduce this?

compile for native_posix, and then run the executable inside valgrind
valgrind --track-origins=yes zephyr/zephyr.exe

Offtopic:
You can also use a hack like this to have sanitycheck run all tests in valgrind, if you prefer to run several tests with sanitycheck
diff --git a/scripts/sanitycheck b/scripts/sanitycheck
index f837dc0..9c49c7e 100755
--- a/scripts/sanitycheck
+++ b/scripts/sanitycheck
@@ -423,7 +423,7 @@ class NativeHandler(Handler):
         """
         super().__init__(instance)

-        self.valgrind = False
+        self.valgrind = True

     def _output_reader(self, proc, harness):
         log_out_fp = open(self.handler_log, "wt")
@@ -450,7 +450,8 @@ class NativeHandler(Handler):
         command = [binary]
         if shutil.which("valgrind") and self.valgrind:
             command = ["valgrind", "--error-exitcode=2",
-                       "--leak-check=full"] + command
+                       "--leak-check=full", "--log-fd=1", "--track-origins=yes"  ] + command
+            self.timeout = self.timeout*10

         with subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE) as proc:
             t = threading.Thread(target=self._output_reader, args=(proc, harness, ))
@@ -463,8 +464,10 @@ class NativeHandler(Handler):

             proc.wait()
             self.returncode = proc.returncode
-            if proc.returncode != 0:
+            if self.returncode != 0:
                 out_state = "failed"
+            else:
+                out_state = "passed"

         returncode = subprocess.call(["GCOV_PREFIX=" + self.outdir, "gcov", self.sourcedir, "-b", "-s", self.outdir], shell=True)

@@ -475,6 +478,9 @@ class NativeHandler(Handler):
         else:
             self.set_state(out_state, {})

+        if out_state == "failed":
+            self.set_state(out_state, {})
+

 class UnitHandler(Handler):
     def __init__(self, instance):

@ramakrishnapallala Are you able to reproduce it?

@aescolar-ot I was looking into some other stuff, will look into it shortly.

@aescolar-ot I have looked at the code. From the pthread_attr_destroy() I don't see any issue as it returns 0 or EINVAL.
From the test case point, we can set the attr[n_THR] memory to 0x0 or make it static.
Do you see any other issue?

Why is the test calling pthread_attr_destroy() before calling pthread_attr_init()?

I think the author of the test wanted to make sure the resources are freed (if allocated earlier) before he uses the attr struct for creating a new pthread.

As it is now it is being called over uninitialized memory,
sometimes attr->initialized is 0, sometimes it is 1, causing random coverage differences.
I think that call should be removed.

Ok will fix it.


Error while using mui5 Button

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
No response
Expected behavior 🤔
No response
Steps to reproduce 🕹
Steps:

Context 🔦
Error while using mui5 Button with const enterKeyframe=0,_system.keyframes`\n  0% {\n    transform: scale(0);\n    opacity
pakage.json
"dependencies": {
"react": "18.2.0",
"react-dom": "18.2.0",
"resolve": "1.20.0"
},
"devDependencies": {
"@babel/cli": "^7.0.0",
"@babel/core": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"@babel/preset-react": "^7.0.0",
"liferay-npm-bundler": "2.28.3"
},
"scripts": {
"build": "babel --source-maps -d build/resources/main/META-INF/resources src/main/resources/META-INF/resources && liferay-npm-bundler"
}
.babelrc file
{
"presets": ["@babel/preset-env", "@babel/preset-react"]
}
index.js
import ReactDOM from "react-dom/client";
import React from "react";
import Button from "@mui/material/Button";
export default function(elementId) {
ReactDOM.createRoot(document.getElementById(elementId)).render(
    <Button variant="contained">Hello World</Button>
);

}
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

chrome browser

Please provide a reproduction via CodeSandbox and describe the error thoroughly.


How to get JSON output on save?

I'm using npm i novel and trying to customize Editor to export JSON data on save. Currently using
  <Editor          onUpdate={(editor) => {           if (editor) {             const content = editor.getJSON(); // Get the editor's content in JSON format             console.log(content); // Log the content to the console             setEditorData(content);           }         }}       />
  but getting an Argument of type 'JSONContent' is not assignable to parameter of type 'SetStateAction<EditorContent | null>'.

Property 'blocks' is missing in type 'JSONContent' but required in type 'EditorContent'.ts(2345)
page.tsx(17, 3): 'blocks' is declared here. Error
I tried adding `type Block = {
type: string;
data: {
text: string;
[key: string]: any; // Additional properties for different block types
};
};
type EditorContent = {
blocks: Block[];
};` but still not having JSON output.
Is there any default function for controlling exports?

They this looks like a type error SetStateAction<EditorContent | null> because the editor export type for json is JSONContent
New version exports a type for it:
import {type JSONContent} from "novel";
Also see usage here:
https://github.com/steven-tey/novel/blob/main/apps/web/components/tailwind/editor.tsx


monorepo release parallelism/concurrency support

Greetings!
In relation to this #54 I am running into a locked ref issue.
 " ! [remote rejected] @test-repo/pkg-b-v2.0.0 -> @test-repo/pkg-b-v2.0.0 (cannot lock ref<EMAIL_ADDRESS>reference already exists)\n" +
I am currently using Turborepo to run semantic-release-monorepo in all the packages and this error occurs unless I set the concurrency to 1.
As running the semantic-release commands sequentially does add a sizeable amount of time to our workflow, is there a chance that we can have increased support for concurrency ?

Im having the same issue


[py2py3] test str/bytes use in WMCore (wildcard issue)

Impact of the bug
It should involve src/python/WMCore/MicroService/DataStructs/MSRuleCleanerWflow.py only
Describe the bug
We have not observed any bug at the moment, but this is very likely to create some problems.
(add here all the checks about str/bytes that did not fell into another issue)

[ ]  MicroService/DataStructs/MSRuleCleanerWflow.py
In #10307 we made the following changes
-                elif (isinstance(data['type'], tuple) and (str in data['type'] or unicode in data['type'])) or \
-                     (data['type'] is str or data['type'] is unicode):
+               elif (isinstance(data['type'], tuple) and (bytes in data['type'] or str in data['type'])) or \
+                    (data['type'] is bytes or data['type'] is str):

[ ] #10321 src/python/WMCore/JobStateMachine/ChangeState.py

[ ] #10321 src/python/WMCore/WMSpec/WMTask.py

[ ] #10329 src/python/WMCore/WMRuntime/Scripts/SetupCMSSWPset.py

Expected behavior
These are supposed to behave the same in py2 and py3 as he previous lines, but there is a somewhat high probability that they will not. We should make sure that these lines behave properly when we have a py3 environment.

The 4 modules mentioned above have all been tested and are already in production as well. I think it's safe to close this issue, and if a problem is found in the near future, we can always either reopen it or create a new specific issue.
Closing it.


METRON-758: HdfsServiceImplTest should sort files for list test

Simple fix for the same issue that caused https://issues.apache.org/jira/browse/METRON-743.  I verified that metron-rest unit tests run successfully.   Is the full suite of tests and checks needed here?
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification guildlines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check
the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
[x] Have you included steps or a guide to how the change may be verified and tested manually?
[ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:

mvn -q clean integration-test install && build_utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html.

cd site-book
bin/generate-md.sh
mvn site:site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommened that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Done

+1, by inspection

+1 Pulled into the failing branch -> issue resolved in travis


non-canonical smiles using deepsmiles

smiles have non-canonical smiles and canonical ones.
Here are some examples of from three non-canonical smiles to the same canonical smiles

Chem.MolToSmiles(Chem.MolFromSmiles('C1=CC=CN=C1'))
'c1ccncc1'
Chem.MolToSmiles(Chem.MolFromSmiles('c1cccnc1'))
'c1ccncc1'
Chem.MolToSmiles(Chem.MolFromSmiles('n1ccccc1'))
'c1ccncc1'

For deepsmiles，

converter.encode('n1ccccc1')
'nccccc6'
converter.encode('C1=CC=CN=C1')
'C=CC=CN=C6'
converter.encode('c1cccnc1')
'ccccnc6'

It gives three different answers. Are they all reasonable valid deepsmiles? Is there a way to tell  'nccccc6' == 'C=CC=CN=C6' =='ccccnc6'? (a way to canonicalize them). Thank you in advance!

Hi, and sorry for the delay in replying. These are all "reasonable valid deepsmiles". To tell that they are the same, I would convert them back to SMILES, read them into a toolkit and generate canonical SMILES.


Add Firebase Auth MFA info to user record

Hi,
I noticed this SDK doesn't yet expose MFA info supported by Identity platform.
The issue ##645 also mentions this.
So I implemented it :) Let me know what you think

Thank you @edwardmp for your contribution! Changes to the public API interface requires an internal API review. Please stay tuned.
@prameshj @pragatimodi tagging as FYI. I think we will need an API review for this. Thanks!

Hi @prameshj & @pragatimodi, do you have any time to take a look? 🙏

@pragatimodi Would you be able to review this? Thanks!
Also FYI @renkelvin

Thanks for making the change and contributing to this repository!
Had a few notes here -

Looks like the MFA config has only been added as field with it's own get() function and not create/update/get functions that make calls to the backend. I don't think we can merge the PR without implementations for these.
Please add request and response validators for MFA data.
Please add test cases for data validation.

@pragatimodi thanks for the review!

You mean create/update/delete right? Makes sense, my own use case only covered get but I'll see if I can address that too.
Can you clarify what you mean here? Validating the Firebase server response and validating any CRUD request?
You mean test cases for the validation as mentioned by point 2?

By the way, happy to help, just wondering why Google/Firebase itself hasn't target parity with the Identity platform API yet as to MFA?

@edwardmp Apologies for the delay, please find my responses below -

Yes that's right. We want to be able to cater to all kinds of use cases and get() alone isn't enough for the master branch.
I meant validating the request sent to the backend where the MFA config being sent for create/update is valid. For example, you can find examples here for NodeJS Admin SDK and for (Go Admin SDK)[https://github.com/firebase/firebase-admin-go/blob/1d245771f556db75b76b32a793b931be6f39c630/auth/user_mgt.go#L652]
Yes and making sure that the flows work and JSON parsing is done correctly.

Hope this helps.
Thanks for contributing to the Firebase Identity platform API. We're actively working on adding MFA support to our SDKs. NodeJS and Golang SDKs already have this feature, and the rest of the SDKs are in progress. We anticipate it will be available sometime in the near future. Thanks for your interest!

@pragatimodi
Thanks for the response. Would be happy to expand my PR to include this, just confused by your final remark

We anticipate it will be available sometime in the near future

So is Google already working on this, i.e. is there no point for me to work on this right now or..?

I was clarifying a point on adding feature parity there. We welcome any contributions you may be able to make to the repository to help us accelerate the development process and glad to review any PRs!
Please note that changes to the public API must go through an internal review process, which sometimes can take a while to complete.

@pragatimodi hey, I finally have some time to improve this PR, but beforeI dive in, to avoid duplicate work, wanted to make sure Firebase/Google doesn't already have something in the works for this?
Thanks in advance

Hi @edwardmp
Thanks for your message. We're always eager to enhance our Firebase repository. Feel free to take the lead, and if you have any questions or need assistance along the way, don't hesitate to reach out. Our team hasn't had the opportunity to dive into this yet, so your contribution is much appreciated.


Bug: add a task of automatically linking the secret to sa during the pipeline run

In order to use a private registry, the registry secret must be linked to the service account that will deploy the application.
oc -n kabanero secrets link <service-account> my-registry --for=pull,mount
However, today the pipeline doesn't automatically do this so the resulting pod fails with ImagePullBackOff errors until Todd manually find the correct SA, applies the link, and deletes the pod.
To Reproduce
Steps to reproduce the behavior:

Follow these instructions for private registry:
https://www.ibm.com/support/knowledgecenter/SSCSJL_4.1.x/settingup.html
Then deploy some app using these newly created stacks using appsody.
Result:  the pod is in ImagePullBackOff state.
To fix this problem:

find the Service Account for the application by looking in the pod yaml,
run this cmd:
oc -n kabanero secrets link <service-account> my-registry --for=pull,mount
Delete the pod and it will get regenerated.

After this the application works. We need a better solution,  this seems just a workaroud. Perhaps we can automatically link the secret to serviceAccount during the pipeline run.

Hi @kvijai82 - Please help to find the appropriate owner and assign a release to the this issue.  Thank you.


Add Jummbox 2.6 features

Jummbox 2.6 features are being worked on and will be released soon
If you'd like, you can head over to the testing site to get early access


bug: app crashes on iOS when changing screen orientation

Plugin version:
4.1.1
Platform(s):
iOS
Current behavior:
When I enable the plugin on an iOS device and subsequently change the screen orientation, the app crashes. However, if I enable the plugin more than once, it functions correctly without any crash.
Expected behavior:
The app should not crash after enabling the plugin
Steps to reproduce:
Scenario 1: App Crash
Enable the plugin on an iOS device.
Change the screen orientation.
Observe that the app crashes.
Scenario 2: No Crash
Enable the plugin on an iOS device.
Disable the plugin.
Re-enable the plugin.
Change the screen orientation.
Notice that the app works fine without any crash.
https://github.com/capacitor-community/privacy-screen/assets/111672775/40f168a4-fd06-450b-85b8-060f903e229a

Thank you for your request.
Please provide a Minimal, Reproducible Example using this template in a public GitHub repository so I can debug the issue.

Thank you for your request. Please provide a Minimal, Reproducible Example using this template in a public GitHub repository so I can debug the issue.

Example

Thank you, I will test this next week and get back to you.

Okay, i just tested it and close this issue as a duplicate of #64.


[ZEPPELIN-3610] Cluster Raft module design

[ZEPPELIN-3610] Cluster Raft module design
What is this PR for?
By using the Raft protocol, multiple Zeppelin-Server groups are built into a Zeppelin cluster, the cluster State Machine is maintained through the Raft protocol, and the services in the cluster are agreed upon. The Zeppelin-Server and Zeppelin-Interperter services and processes are stored in the Cluster MetaData. Metadata information;
What type of PR is it?
[Feature]
Todos

[x] added support for checking lambda syntax styles in the pom.xml file
[x] add raft algorithm copycat jar
[x] add  Cluster State Machine
[x] add state machine query command
[x] add state machine delete command
[x] add state machine put command

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3610

How should this be tested?
CI pass
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@liuxunorg You didn't set up travis, please follow the instruction here. https://zeppelin.apache.org/contribution/contributions.html#continuous-integration


pre/code tags in feed are loosing the newlinines

Hi, I searched around, could not find any still open relevant issue for this, so here i go:
I have a page with a feed, the post contains multiline-code with newlines, the feed has still the code tag but all is in one paragraph now without newlines! I am not sure, what is wrong. My blog is not really far off from the jekyll default+minima?
the blog source is at https://github.com/fabsenet/blog_de
the blog runs at https://fabse.net
the feed is at https://fabse.net/feed.xml
A good example is the latest post, search for "isLedOn" (it is contained in this post: rendered / markdown)
I am not sure, maybe I configured something wrong? But all I know is, the end result is wrong.
Can you guys give me a hint?

We do minify the feed template, but that shouldn't affect the content that goes inside that template.
https://github.com/jekyll/jekyll-feed/blob/f879ed22076fce4cff98b22fec7d0ec85f9a3199/lib/jekyll-feed/generator.rb#L49
The template itself uses the strip filter, which should remove leading and trailing whitespace, but should not affect whitespace inside the content.
https://github.com/jekyll/jekyll-feed/blob/f879ed22076fce4cff98b22fec7d0ec85f9a3199/lib/jekyll-feed/feed.xml#L42
I'm not sure. I suppose the thing to do is to create a failing test and see if we can get to the bottom of what is stripping those spaces.

@fabsenet I don't think this is anything that you have done wrong. Seems like a problem with the plugin.

Hmm... we already do have a test for this.
https://github.com/jekyll/jekyll-feed/blob/10071c56678a5bb3ccff8806334fb750b6baf716/spec/jekyll-feed_spec.rb#L57-L59

The problem is the jekyll-minifier gem. It collapses all whitespace into a single space.
If you disable that plugin, the feed generates as expected.
You should open an issue there about keeping preformatted whitespace. :+1:

jekyll-minifier was actually my first bet on the issue, but I disabled it to test it (at least I thought so) but removingit from the _config.yaml is not enough. I learned that now. I had to remove it from the gemfile as well.
at least you are right, removing jekyll-minifier also removes the problem of missing newlines. thanks so far 👍


zcbor/include/zcbor_common.h:108:2: warning: ISO C99 doesn't support unnamed structs/unions [-Wpedantic]

-Wpedantic generates warnings:
zcbor/include/zcbor_common.h:108:2: warning: ISO C99 doesn't support unnamed structs/unions [-Wpedantic]
when build with Zephyr for nrf52840dk_nrf52840.

You might be interested in this comment from the maintainer:
https://github.com/NordicSemiconductor/zcbor/issues/299#issuecomment-1411688585

That's right. -Wpedantic is only supported on C11. I initially didn't catch this distinction. I added -Wpedantic tests (using Zephyr) for the native_posix board. I later discovered problems when running on other boards. It turns out that Zephyr defaults to C11 for native_posix, and to C99 for ARM-based boards. In my tests I now do the following towards the top of my CMakeLists.txt file:
set_property(GLOBAL PROPERTY CSTD c11) # To avoid issues with c99 and -Wpedantic

Which sets the cstd to C11 for all boards.


refactor: make option and config without generic for better type inference

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c561da2) 100.00% compared to head (60c3493) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          419       422    +3
=========================================
+ Hits           419       422    +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Need to use make NUM_THREADS=64 or some other large number.

.. otherwise the value is determined from the build machine instead and you'll fail to exploit high performance systems.

Agreed. This came up in another PR not long ago. FWICT NUM_THREADS is a misnomer as it has nothing really to do with the number of threads and everything to do with the maximum amount of memory available. So we should keep this in mind when choosing a value.

It mostly affects stack space requirements and does directly concern the maximum amount of threads this build of openblas is able to launch in parallel. Less good CPUs are still able to cap this to sensible limits to prevent excessive thread eviction.

My understanding was that OpenBLAS would still detect the number of cores, which influences how many threads it launches. Does this change if we set NUM_THREADS? IIUC it does not.

NUM_THREADS is a hard upper limit on the amount of threads that can be used. It's relatively inexpensive in terms of memory and more or less totally free in terms of performance.

Ok. Yeah I'm in favor of this change. Do you want to do a PR?

In defaults they use 128


⚠ ClamAV has degraded performance

In b2866df, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 78 ms

Resolved: ClamAV performance has improved in 2995476.


Authorship Chapter is Missing

The Authorship chapter does not appear in this repository. Would it be possible to add the markdown source please?

Hi! Sure let me get on it.

Done. You may notice the internal seems out of sync with external, but this is the copy that will be public shortly. We added Tasini to round out discussing collective works.

@sillsm Thanks!


JerseyServices.postResource was not passing through transaction (txid)

This is a back-port of #325

Nevermind, looks like 2.0 branch doesn't support transactions on any of the *Resource methods of JerseyServices


LinkedState array of objects

Not sure if this is the right channel.
I'm trying to do the following, is it possible?
linkState(this, `user.addresses[${index}].street`)

Thanks!

Hi @rafbgarcia.
The linkstate replository would 've probably been a better place for this question.
You can't use the syntax you tried above. Linkstate parses dots . as the seperators of identifiers.
So your example would look like this:
linkState(this, `user.addresses.${index}.street`)

An example of this working: https://codesandbox.io/s/kol0rzo2j7


feat: need to run Without Closing in testing package too

Hi ,
i am nestjs-backend-developer in south korea
I wish you understand that I am not good at English
nest-commander-testing Package's run-method has app.close();
but this closes the DB connection.   (in my E2E - test )  (CommandTestFactory.run ( ) )
In fact, the company used it as an example below.
export class CustomCommandTestFactory {
  static async runWithoutClosing(app: TestingModule, args: string[] = []) {
    if (args?.length !== 0 && args[0] !== 'node') {
      args = ['node', randomBytes(8).toString('hex') + '.js'].concat(args)
    }
    await app.init()
    const runner = app.get(CommandRunnerService)
    await runner.run(args)
  }
}

But, nestjs-commander has runWithoutClosing method.
plz) merge this.
then my company will love this library
thanku

Taken care of #731


Connecting to HTTPS Upstream service.

I have my secure service running on HTTPs using following options.
new HttpServerOptions().
		setSsl(true).
		setClientAuth(ClientAuth.required).
		setKeyStoreOptions(
			new JksOptions().
				setPath("Certificate.jks").
				setPassword("password")

		).
		setTrustStoreOptions(
			new JksOptions().
				setPath("ca_cs_combined_prod.jks").
				setPassword("password")
		)

When i connect to my service at https:\localhost:8080\getToken using chrome i get pop up to select certificate and after selecting certificate i am able to call this service fine.
I have registered my service in consul with proto=https option.
But i am unable to call this service using fabio.  My use case here is service registered in Consul is HTTPs and fabio is runing with HTTP and not as HTTPs. Is it possible to call this upstream HTTPs service such as http:\localhost:9999\getToken. How to use jks certificates with fabio?
With current set up of i try to query my HTTPS upstream service using fabio i am getting folowwing error:
cannot validate certificate for ipadress because it doesn't contain any ip sans

I have converted my jks keystore to pem now when i do cs=cert;type=file;cert=certificate.pem;clientca=ca_cs_combined.pem i get following error:
found a certificate rather than a key in the pem
Please advice. All i want is -  my HTTPS service needs client side auth. I am able to call HTTPs service which does not require client side AUTH through fabio. But i am struggling with calling HTTPS service which needs client authentication from Fabio. How to do it?

fabio doesn't support authenticating to backends (TLS or otherwise).

My use case here is service registered in Consul is HTTPs and fabio is runing with HTTP

All i want is - my HTTPS service needs client side auth.

Which is it? The former can't be done when the backend requires TLS auth. The latter can be done by using a TCP proxy instead of an HTTP(S) proxy (i.e. fabio's client authenticates directly with the backend), but you can't do routing decisions based on the HTTP request, of course.

Does this mean that we cant call HTTPS service which needs client AUTH from fabio?

FYI i am able to call my HTTPS service which needs client AUTH directly and it works fine. I am not sure how to do it using Fabio

Does this mean that we cant call HTTPS service which needs client AUTH from fabio?

Yes. As I was saying, fabio doesn't support authenticating to backends (TLS or otherwise).

Does this mean that we cant call HTTPS service which needs client AUTH from fabio?

Not with an HTTP(S) proxy. You can use a TCP proxy but then authentication has to be done downstream.


cmd/compile: large unnamed struct can result in 'name too long' error at link time

Because we use the raw type literal in symbol names, if the result exceeds 8 kB (!),
then ld's Brdline will not be able to read the name into the Biobuf buffer, which will
make ld print 'name too long'. For enormous literals like this we need an alternate
plan, like using the sha1 sum of the type text instead.

Yeah, just like @minux mentioned, @rtoma's program can now be compiled fine,
as on the playground at https://play.golang.org/p/RGuspjE9uw

Wow, blast from the past.
Verified with go version go1.7.3 darwin/amd64
Thanks for fixing.

@rsc or @griesemer can we close this s'il vous plait?


Closes Issue #42 - Remove "No Further Action"

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


DSU Fabric GTIN Check

PL user story:
Description:
Update the DSU Fabric to include a check to ensure the check Digit of the entered GTIN is correct. This Should be done when creating the product.

It is to be determined when this check is performed. If it is done when the user presses Save product then all the other data entered should remain in place i.e. picture of the product, leaflet/ SmPc etc. and the GTIN corrected.

The System will allow barcodes to be produced even though the check digit is incorrect. When the person scans the Datamatrix code then they get an message stating it is not readable.

Acceptance criteria's:
positive tests

Create a GTIN with an incorrect check Digit. The system will detect this and indicate the issue to the user.

negative tests / error path testing

N/A

Process scenario:

N/A

Additional information:
N/A.
@UnHynek your colleague Clement had this issue hence why the request is being raised.

The GTIN can be 8, 12, 13,14 digits long. Currently the mobile app is only able to scan the 14 digit GTIN
https://www.gtin.info/ -- The website gives the various GTIN format available in the market currently.
We have to allow the app to scan the other lengths also.
For details of the check digit calculation please refer to the below link :
https://www.gs1.org/services/how-calculate-check-digit-manually

@skutner , @salboaie,  @asaccool : need your comments about the implementation of this feature item.


Feature Request: Reduce the number of calls to the August API.

Problem
Every time the status of the lock is requested, two calls are made to the August API. I see homebridge-august making these calls to august-api when it refreshes the state of the lock:
lockStatus:
const lockStatus = await this.platform.august.status(this.device.lockId);
which calls through to the august-api status object, which then does this:
let { body } = await this.put(/remoteoperate/${lockId}/status)
and lockDetails:
const lockDetails = await this.platform.august.details(this.device.lockId);
which calls through to august-api details object, which then does this:
let { body } = await this.get(/locks/${lockId})
Solution
Almost all the data is available in the lockDetails call, except for if the lock is jammed (retryCount > 1). We should just use lockDetails and work out another way to handle a jammed lock.
Alternatives
No response
Additional context
Calls to the August API is rate limited, so reducing the number of calls to the API is a good thing in general. Also some people are running into issues when they have multiple locks, they hit the rate limit.

Thanks for the fix!

v1.2.0 has been released