Fix the highlighting of end-of-line

For #1792.
Summary
sample.vim
normal! iabcd
syntax on
call matchadd('ErrorMsg', '\n')
setlocal cursorline

current vim
cursorline: underline

cursorline: background-color (:hi CursorLine cterm=NONE ctermbg=DarkGray)

patched
cursorline: underline

cursorline: background-color (e.g. :hi CursorLine cterm=NONE ctermbg=DarkGray)

This is the similar highlighting as set list (of current vim).

Additional examples
set rightleft and background-color cursorline
the left-col is highlighted:

fixed:

diff-mode
without cursorline.
sample2.vim
normal! iabcd
call matchadd('ErrorMsg', '\n')
diffthis
vnew
diffthis

fixed:

Codecov Report

Merging #2111 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
+ Coverage   73.95%   73.97%   +0.02%
==========================================
  Files          90       90
  Lines      131856   131865       +9
  Branches    28962    28963       +1
==========================================
+ Hits        97515    97552      +37
+ Misses      34322    34309      -13
+ Partials       19        4      -15

Impacted Files
Coverage Δ

src/ex_cmds.c
77.71% <0%> (-0.23%)
:arrow_down:

src/if_py_both.h
76.09% <0%> (-0.15%)
:arrow_down:

src/window.c
81.02% <0%> (-0.1%)
:arrow_down:

src/eval.c
80.78% <0%> (-0.05%)
:arrow_down:

src/ex_cmds2.c
80.31% <0%> (+0.14%)
:arrow_up:

src/gui_gtk_x11.c
47.76% <0%> (+0.5%)
:arrow_up:

src/libvterm/src/screen.c
71.99% <0%> (+0.66%)
:arrow_up:

src/version.c
80.3% <0%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b2964...5e7de76. Read the comment docs.


Left and Right yAxes with the same data

In 2.0 is it possible to basically mirror/duplicate the left yAxes on the right side without having to duplicate the exact same dataset for each the left and the right axis?

@joeshub thr only other way would be to set the max and min to the same thing for both axes

@etimberg i see, I tried that but it ends up with uneven ticks which is not ideal. Also in that same scenario deselecting a bar from the legend no longer animates the lines for some reason.
If I do duplicate the data I end up with duplicate items in the legend and unselecting each one ends up basically with the corresponding axis being in a different state than the opposite side. I guess what I'm trying to achieve would be a "feature" that is not supported?
Thanks for you help

@joeshub is it possible to post a fiddle with what you have so far? There are some ways to keep the grid lines the same for each axis.

Closing since the only solution to this is to use hard coded min / max solution mentioned above.


Fixed relative URL computation in wIthoutBaseUrl

Current behaviour :

base URL = http://foo.bar/
url = http://foo.bar/my/api
gives => my/api

Fixed behaviour :

base URL = http://foo.bar/
url = http://foo.bar/my/api
gives => /my/api

Great work @devdufutur


Pausing picture in picture does not use automatic resume

Currently changing the code to not rely on if the tab is active.

Currently muted picture in picture is not working correctly on firefox.
Due to API not existing.

Fixed :D


Update repositories.txt

Hello @chrmlinux I am confirming your request to remove https://github.com/chrmlinux/ArreyExt.
Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and closes those issues and pull requests when it is done. You will get a notification from GitHub at that time.
After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager


Remove unused variables

Ruby emits a warning because these are unused.

If #57 is merged then this will not be needed.


add some very simple, fairly stupid, benchmarks

Just a very simple benchmark for the message parsers. It even yielded a bug, which I fixed and added a test for.
At this point, nothing actually consumes the produced report, but I wanted to get the benchmark itself in just to give us a starting point.
/cc @pakrym @mikeharder

Related to #316 , but by no means completes it ;)

If anyone is curious as to the results, here's my results. It's not terribly useful until we have a stable place to run them and aggregate results, but there are numbers!

BenchmarkDotNet=v<IP_ADDRESS>, OS=Microsoft Windows 10.0.15048
Processor=Intel(R) Xeon(R) CPU W3550 3.07GHz, ProcessorCount=8
Frequency=2994776 Hz, Resolution=333.9148 ns, Timer=TSC
dotnet cli version=1.0.0
  [Host]     : .NET Core 4.6.25009.03, 64bit RyuJIT
  DefaultJob : .NET Core 4.6.25009.03, 64bit RyuJIT

Method
ChunkSize
MessageLength
Format
Mean
StdDev
Gen 0
Allocated

SingleBinaryMessage
32
64
Binary
591.2310 ns
6.3492 ns
-
88 B

SingleBinaryMessage
32
64
Text
1,357.3538 ns
17.9380 ns
-
199 B

SingleBinaryMessage
32
128
Binary
872.9236 ns
15.9066 ns
-
152 B

SingleBinaryMessage
32
128
Text
2,168.1824 ns
41.5669 ns
-
351 B

SingleBinaryMessage
64
64
Binary
508.5033 ns
19.8728 ns
-
88 B

SingleBinaryMessage
64
64
Text
1,245.9036 ns
23.1488 ns
-
199 B

SingleBinaryMessage
64
128
Binary
675.3224 ns
8.7229 ns
0.0109
152 B

SingleBinaryMessage
64
128
Text
1,858.4763 ns
66.3500 ns
-
351 B


fix(init-db): add required permissions for postgres init script

This change fixes an issue where postgres was unable to run the init-db
scripts.
fixes plandex-ai/plandex#22

Thank you @ryansonshine!


Update reprounzip-vistrails for use as a dataflow

This updates reprounzip-vistrails to use a full-fledged VisTrails package instead of CLTools, and provides the dataflow capabilities we discussed. This was the reason for #101.
Needs #129 for it to work with reprounzip-docker

Cool! Looking forward to checking this out !
On Wed, Jul 22, 2015 at 12:07 AM, Remi Rampin<EMAIL_ADDRESS>wrote:

This updates reprounzip-vistrails to use a full-fledged VisTrails package
instead of CLTools, and provides the dataflow capabilities we discussed.
This was the reason for #101
https://github.com/ViDA-NYU/reprozip/pull/101.
Needs #129 https://github.com/ViDA-NYU/reprozip/pull/129 for it to work
with reprounzip-docker
You can view, comment on, or merge this pull request online at:
https://github.com/ViDA-NYU/reprozip/pull/130
Commit Summary

Rewrite reprounzip-vistrails plugin
Draft reprounzip VisTrails package
pep8 plugin
plugin: optional arg
pkg
Display meaningful error restoring unpacked input
pkg
Add comments on reprounzip-docker behavior
Docker: update current_image after each run
Add reprounzip docker reset command
Merge branch 'docker-keep-changes' into 'reprounzip-package'

File Changes

M reprounzip-docker/reprounzip/unpackers/docker.py
https://github.com/ViDA-NYU/reprozip/pull/130/files#diff-0 (116)
M reprounzip-vistrails/reprounzip/plugins/vistrails.py
https://github.com/ViDA-NYU/reprozip/pull/130/files#diff-1 (458)
A reprounzip-vistrails/vistrails_package/reprounzip_vt/init.py
https://github.com/ViDA-NYU/reprozip/pull/130/files#diff-2 (22)
A reprounzip-vistrails/vistrails_package/reprounzip_vt/init.py
https://github.com/ViDA-NYU/reprozip/pull/130/files#diff-3 (142)
M reprounzip/reprounzip/unpackers/common/misc.py
https://github.com/ViDA-NYU/reprozip/pull/130/files#diff-4 (11)

Patch Links:

https://github.com/ViDA-NYU/reprozip/pull/130.patch
https://github.com/ViDA-NYU/reprozip/pull/130.diff

—
Reply to this email directly or view it on GitHub
https://github.com/ViDA-NYU/reprozip/pull/130.

--
Fernando Chirigati
Research Assistant and Doctoral Candidate at NYU
http://bigdata.poly.edu/~fchirigati/ http://vgc.poly.edu/~fchirigati/

I'm not sure how to distribute the VisTrails package though. I guess it could be part of VisTrails, or it could be distributed separately (another thing to install!), deploying it automatically is awkward.


[SPARK-23160][SQL][TEST] Port window.sql

What changes were proposed in this pull request?
This PR ports window.sql from PostgreSQL regression tests. https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/sql/window.sql
The expected results can be found in the link: https://github.com/postgres/postgres/blob/REL_12_BETA2/src/test/regress/expected/window.out
How was this patch tested?
Pass the Jenkins.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Question: should I check the window.sql src/test/resources/sql-tests/inputs to remove overlapping tests here or it is ok to have duplicates?

ok to test

Test build #106545 has started for PR 24881 at commit 7ec6b76.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11786/
Test PASSed.

Test build #106545 has finished for PR 24881 at commit 7ec6b76.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106545/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11796/
Test PASSed.

Test build #106556 has started for PR 24881 at commit 4b87073.

Hey guys, I added new references to JIRAs. I removed the WIP tag so that the CI could run because I wanted to be sure that I wasn't breaking other things - and I was lmao. I forgot to drop the tables at the end of the file. However, I still need to pay attention to a few things to finish this. For instance, postgres have tons of tests with UDF+Window, but I don't know if we should also because I don't think that we can create UDFs in SQL.
Btw, a question:
I checked and the results order are different from postgresql. I.e: if I don't explicitly order by some column, the results between Postgresql and Spark are different. For me, this makes a lot of sense: Spark is a distributed processing engine, so the order may differ unless we explicitly say to not. Should this be documented or it is too obvious?

Test build #106556 has finished for PR 24881 at commit 4b87073.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106556/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11801/
Test PASSed.

Test build #106561 has started for PR 24881 at commit fe280f3.

Test build #106561 has finished for PR 24881 at commit fe280f3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106561/
Test FAILed.

Btw, another question: the CI isn't passing and I can't identify the query: https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106561/testReport/junit/org.apache.spark.sql/SQLQueryTestSuite/sql/
I think that it has some relation with the new tempview that I created (tenk2) but I'm not sure. Suggestions?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11802/
Test PASSed.

Test build #106563 has started for PR 24881 at commit b679e58.

Test build #106563 has finished for PR 24881 at commit b679e58.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106563/
Test FAILed.

@DylanGuedes Please re-generate golden file by:
SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite -- -z window.sql"

You can verify it by:
build/sbt "sql/test-only *SQLQueryTestSuite -- -z window.sql"

Hmm I was always generating them, I think that at the end I made a minor change and forgot to rerun then because I just changed a comment. Whatever, thank you!

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11832/
Test PASSed.

Test build #106596 has started for PR 24881 at commit 8273331.

I updated with a few changes. I just got noticed (after @wangyum help) that I was having problems in udf-inner-join.sql, but I didn't figured out why since I don't built any changes to it. Do you guys have any idea of the reason?

Test build #106596 has finished for PR 24881 at commit 8273331.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106596/
Test FAILed.

Retest this please.

Test build #106687 has started for PR 24881 at commit 8273331.

The failure is due to the wrong generated output. Please configure your Python environment and regenerate this.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11920/
Test PASSed.

Test build #106687 has finished for PR 24881 at commit 8273331.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106687/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/11954/
Test PASSed.

Test build #106722 has started for PR 24881 at commit dc8915c.

You are right, I had an environment variable that was setting ipython instead. Whatever, I regenerated the golden files, looks fine now.

Test build #106722 has finished for PR 24881 at commit dc8915c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106722/
Test PASSed.

By the way, the CI looks fine now.

Hi, @DylanGuedes .
The output file (21,485 line) looks ridiculously bigger than the original one (3823 line).

https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/expected/window.out

Could you compare the result with PostgreSQL. Is the output correct?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12432/
Test PASSed.

@dongjoon-hyun You are absolutely right - for some reason, results from two queries were not truncated. I commented them out and will probably create a JIRA for them, but for now I just commented they out.

Test build #107284 has started for PR 24881 at commit 48bd010.

Test build #107284 has finished for PR 24881 at commit 48bd010.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107284/
Test PASSed.

Thank you for update. We need to embed the JIRA ID of new issues in the file in this PR.

Gentle ping.

@dongjoon-hyun Sorry for taking too long on this one. I'll update the tests with the new JIRAs/comments and finish it until tomorrow.

Never mind~ Please take your time.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12906/
Test PASSed.

Test build #107787 has started for PR 24881 at commit ddcf90e.

Hi, @DylanGuedes . I made a PR to you, https://github.com/DylanGuedes/spark/pull/1 .

It replaces REL_12_BETA1 with REL_12_BETA2. Luckily, they are the same. We only need to change pointer.
I reverted show-tables.sql.out and SQLQueryTestSuite.scala. Instead, I added the following.

CREATE TEMPORARY VIEW tenk2 AS SELECT * FROM tenk1;

Could you review and merge it to your branch?

@dongjoon-hyun Thank you for the suggestion! I review'd it and I only missed a drop view at the end.

It's not missed. It's a temporary view. We don't need to drop it manually.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12910/
Test PASSed.

Test build #107792 has started for PR 24881 at commit 00ff975.

Nice! So, I'm almost finishing it, I get stucked in the following questions, because I'm not sure if the current behavior is intended or if I should create a JIRA for it:

Spark exclude looks different from PgSQL exclude (I commented out the error). Should I create a JIRA for it?
Spark does not accept operations between double and timestamp. Should I create a JIRA for it?
Spark does not have a explain (costs off). Should I create a JIRA for it?
ntile(0) does not accept an empty bucket. Should I create a JIRA for it?
I think I should create a JIRA for the problems with result not being truncated, but to be fair I didn't created because I don't know which title to create for it. Do you have any suggestion?

Thank you!

Test build #107787 has finished for PR 24881 at commit ddcf90e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107787/
Test PASSed.

Yes. Please search the JIRA and file all of them if they don't exist.
For explain (costs off), there might exist one.

@dongjoon-hyun Nice. So I'll document them for now.

Test build #107792 has finished for PR 24881 at commit 00ff975.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107792/
Test PASSed.

Test build #108051 has started for PR 24881 at commit ea00971.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13159/
Test PASSed.

Test build #108051 has finished for PR 24881 at commit ea00971.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108051/
Test FAILed.

@dongjoon-hyun I've been trying to make filtering works for a while but without success. For instance, in the following snippet
SELECT sum(salary), row_number() OVER (ORDER BY depname), sum(
sum(salary) FILTER (WHERE enroll_date > '2007-01-01') )
FROM empsalary GROUP BY depname;

I already tried moving the filter to different places and using different syntaxes (I even used lambda), but none of them work for this case. Since I don't know If it is just me not knowing the API well enough or if Spark has any limitation in this side, I didn't created a JIRA for cases like this. What do you think?

FILTER is not supported syntax, isn't it? The unsupported syntax is a good reason to create a JIRA issue.
In this PR, you can file a JIRA and comment that query. That's enough.
If you create a JIRA issue, then someone else can start from it.

I don't know, I didn't find anywhere a list of which features Spark has support to. And FILTER works at some point:
select filter(ys, y -> y > 30) as v from nested;

this query work, for instance. But ok, I'll create a JIRA about filter.

SQL Function and SQL Language syntax is different, @DylanGuedes .

The one you mention here is higher-order function, filter. And, you need to search Apache Spark SQL function API document.

https://spark.apache.org/docs/latest/api/sql/#filter

The one you asked is SQL syntax, FILTER (WHERE ...). And,  you need to search SQL Standard Documentation. (Not Apache Spark SQL document).

Ok, thank you for the explanation. I found that code snippet in a .sql file, that's why I thought that it was related to SQL Language itself.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13226/
Test PASSed.

Test build #108122 has started for PR 24881 at commit 4be05f6.

Test build #108122 has finished for PR 24881 at commit 4be05f6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108122/
Test FAILed.

BTW, thank you for your patience!

You're welcome.
I commented out the calls to explain. If you find more things that can be improved I can indeed work on them, so don't hesitate.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13275/
Test PASSed.

Test build #108174 has started for PR 24881 at commit 0666354.

Test build #108174 has finished for PR 24881 at commit 0666354.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108174/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13424/
Test PASSed.

Test build #108327 has started for PR 24881 at commit f98ddf7.

Test build #108327 has finished for PR 24881 at commit f98ddf7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108327/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13433/
Test PASSed.

Test build #108336 has started for PR 24881 at commit 0611f07.

Test build #108336 has finished for PR 24881 at commit 0611f07.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108336/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13438/
Test PASSed.

Test build #108341 has started for PR 24881 at commit 182da98.

Hi, @maropu . Could you give us some advice on the following?

https://github.com/apache/spark/pull/24881#discussion_r308373086

Test build #108341 has finished for PR 24881 at commit 182da98.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108341/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13481/
Test PASSed.

Test build #108385 has started for PR 24881 at commit 696bd44.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13482/
Test PASSed.

Test build #108386 has started for PR 24881 at commit 8ec9765.

Test build #108385 has finished for PR 24881 at commit 696bd44.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108385/
Test FAILed.

Test build #108386 has finished for PR 24881 at commit 8ec9765.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108386/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13513/
Test PASSed.

Test build #108417 has started for PR 24881 at commit 59a4951.

Test build #108417 has finished for PR 24881 at commit 59a4951.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108417/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13559/
Test PASSed.

Test build #108465 has started for PR 24881 at commit 7ac001c.

Test build #108465 has finished for PR 24881 at commit 7ac001c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108465/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13615/
Test PASSed.

Test build #108521 has started for PR 24881 at commit 350acd4.

Test build #108521 has finished for PR 24881 at commit 350acd4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108521/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13658/
Test PASSed.

Test build #108567 has started for PR 24881 at commit ab73b04.

Test build #108567 has finished for PR 24881 at commit ab73b04.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108567/
Test PASSed.

@dongjoon-hyun I applied the suggestions by @maropu , what do you think?

Could you please carefully check the output again?

@maropu Thank you for the revision, it was very clarifying. I also think that I didn't paid enough attention to which differences are important between pgSQL and Spark - I was way more focused on just translate the pgSQL queries into SparkSQL queries. Since you recommended to wait #25331, I'll use this extra time to understand and make better description of the current Spark behavior for the pgSQL/window queries.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13864/
Test PASSed.

Test build #108784 has started for PR 24881 at commit de9361c.

Test build #108784 has finished for PR 24881 at commit de9361c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108784/
Test PASSed.

https://github.com/apache/spark/pull/25357 has been merged. So, can you update the output file, too?

Test build #109122 has started for PR 24881 at commit 826708d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14190/
Test PASSed.

Test build #109122 has finished for PR 24881 at commit 826708d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109122/
Test PASSed.

cc @maropu @dongjoon-hyun @wangyum

Yea, I'll check now.

@DylanGuedes any update?

@gatorsmile @maropu Sorry guys, altough I`ve got noticed about some of your comments, I didn't get any notification about the new suggestions to the merge, so I thought that your guys were discussing about splitting the merge or not. I'll try to finish all the suggestions til next week. Also, if you guys preffer a splitted merge, I can work on it, for sure.

ping @dongjoon-hyun @wangyum

Test build #110280 has started for PR 24881 at commit 80f2915.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/15276/
Test PASSed.

Test build #110280 has finished for PR 24881 at commit 80f2915.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110280/
Test PASSed.

ok to test

Looks we're blocked. If the current status doesn't looks enough to merge, shall we split? @wangyum, @maropu WDYT? I am willing to help as well.

This seems the last ticket in PostgreSQL umbrella. Let's get this done.

+1 for the split....

Test build #110683 has started for PR 24881 at commit 80f2915.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15845/
Test PASSed.

@DylanGuedes Are you still here? Can you split this pr (~1400 lines) into 4 parts (each file has 300-400 lines) by referring pgSQL/aggregates_partX.sql?
https://github.com/apache/spark/tree/master/sql/core/src/test/resources/sql-tests/inputs/pgSQL

@maropu Yes, I'm following everything. Yes, I can split th PR.

Thanks!

Test build #110683 has finished for PR 24881 at commit 80f2915.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110683/
Test FAILed.

Close this pr cuz I saw your split prs.


Downstream build fails when using annotation processor and compile options -Xlint:all -Werror

Using the annotation processor in a build along with compiler options -Xlint:all -Werror fails the build with:
warning: No processor claimed any of these annotations:
/io.jstach.jstache.JStache,
... (other annotations which built just fine before jstachio)
/org.junit.jupiter.params.ParameterizedTest,
/org.junit.jupiter.api.io.TempDir

Note: Wrote services file: io.jstach.jstachio.spi.TemplateProvider
Note: Wrote services file: io.jstach.jstachio.spi.JStachioExtension

error: warnings found and -Werror specified
1 error
1 warning

Similar issue to the one solved in project lombok here.

I had originally claimed the annotations but errorprone says that is bad. I may need a flag. I’ll get this fixed for very soon.

https://errorprone.info/bugpattern/DoNotClaimAnnotations
I will check with the errorprone team as well.
I swore I have -Xlint:all -Werror in my other projects but maybe I'm mistaken.

I swore I have -Xlint:all -Werror in my other projects but maybe I'm mistaken.

Here's a proof of concept build as well as the workaround (Adding -Xlint:-processing)

https://errorprone.info/bugpattern/DoNotClaimAnnotations
💯

I didn't know this was problematic .. 🤷 I'm looking forward to errorprone's reply 👌

Apparently my other project had a flag to disable the warning but for a different reason.
Would adding an annotation processor flag be amenable for now?
Annotation processors look like -A and are covered in JStachio doc.
The issue is I can't add this till like at least a minor release and not a bug release.
The flag I can add as a bug release (well semver is sort of unclear on this because its not actual runtime but lets ignore that) which will not impact people relying on the annotation for whatever reasons.
Also how urgent is this for you?

Would adding an annotation processor flag be amenable for now?
Also how urgent is this for you?

Using -Xlint:-processing works fine for me for now - and if it turns out that errorprone is correct when they say that claiming annotations prevents other annotation processors from seeing the annotation, then it's probably something that should always be in effect.

Using -Xlint:-processing works fine for me for now

Yes that is the flag I have set in the other project. I will eventually add a flag as I can see an advantage to still have the warning applied to other processors.
Thanks for the bug report!


Restrict trait bound on F generic in query filters to ReadOnlyWorldQuery

This is an interesting bound; we don't require ReadOnlyWorldQuery on the F in Query<Q, F>. Perhaps we should though?
Originally posted by @alice-i-cecile in https://github.com/bevyengine/bevy/pull/6004#discussion_r973628162
Query filters cannot mutate data (by definition); as a result we can strengthen the trait bound on the appropriate generics from WorldQuery to ReadOnlyWorldQuery.
This better communicates how these generics are supposed to be used, and catches mistakes that are likely to be user error at compile time.

@BoxyUwU, I'd like your tak here.
For anyone considering tackling this, this should be super easy from an implementation perspective. Just make sure to hit QueryState too!

seems reasonable to me

Should be addressed as of #6008


[Snyk] Upgrade @apollo/client from 3.7.16 to 3.7.17

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @apollo/client from 3.7.16 to 3.7.17.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 2 months ago, on 2023-07-05.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Check out a preview of your pull request here: https://alphasite-appservice-dev-pr-preview-3.azurewebsites.net


prevent optimum from re-wrapping ORTModule

What does this PR do?
In the case of running optimum + accelerate's auto_batch_size, ORTModule is recursively wrapped which causes export errors the second time batch_size is halved as ORT will try to export an already exported model. This fix adds a quick instance check to prevent ORTModule being double wrapped when optimum + accelerate's auto_batch_size is used.

Hi @prathikr,
Thanks for the PR, the double wrapping problem is also handled in #561 by unwrapping self.model when all wrapping is finished. Can you take a look at this PR to see if it can solve the issue here?
Thank you!

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hi @prathikr, the rewrapping issue shall have been fixed with unwarp_model:
https://github.com/huggingface/optimum/blob/dbb90b4ce286b22615c767a4ac4339dfac78d7c7/optimum/onnxruntime/trainer.py#L450
If things go well from your side, can I close the pull request?


[DOC]: Add missing task type documentation

What are you missing in the docs
I see that the following types of tasks are documented in the Open API

SIMPLE
DYNAMIC
FORK_JOIN
FORK_JOIN_DYNAMIC
DECISION
SWITCH
JOIN
DO_WHILE
SUB_WORKFLOW
START_WORKFLOW
EVENT
WAIT
HUMAN
USER_DEFINED
HTTP
LAMBDA
INLINE
EXCLUSIVE_JOIN
TERMINATE
KAFKA_PUBLISH
JSON_JQ_TRANSFORM
SET_VARIABLE
NOOP

The following types are missing from the conductor oss documentation and orkes documentation:

DECISION
USER_DEFINED
LAMBDA
EXCLUSIVE_JOIN
NOOP

@RizaFarheen can you please take a look at this issue?


Add ability to prepend query comments

This is a rebased and updated version of #2815 that fixes #1982.
About parameter binding, I did tried to escape them, but I doesn't works for mysql. So I forbidden any ?.

Coverage increased (+0.0007%) to 92.271% when pulling fbf38a8e2de2153a5487764bdd7dcfe7688731a6 on francois2metz:feature/query_comment into 2dadde4214d9ee333adccfa517089647e94d23be on knex:master.

I fixed a bug with cockroachdb as ids are not numeric. It should be fine now. I'll squash commit later.

@francois2metz Can you please send documentation PR to https://github.com/knex/documentation?

@kibertoad Hi! I created the documentation PR: https://github.com/knex/documentation/pull/450

Very excited for this! Any ETA on when a new version will be released?


Code style settings are empty

This leads to issues with space vs tabs recognition, it always thinks that Lua code should use tabs.

Sorry, the code style is uncompleted, please wait for next version :smile:

I see you added Spaces around operators, before comma, after comma, and after field sep (separator), thanks for those.
I realize there's a lot to add, but the one addition that would make me most happy would be:
Tabs and Indents -> Keep indents on empty lines.

Formatting & code style settings are Experimental feature currently. It's in my plans, please wait...

Two issues prevent me from using formatter everywhere:

'Continuation indent' seems to be not working - it acts like always set to 'zero'
Our code is full with simple one-liners like this one:
if not ok then return false, err end
Formatter expands them to three lines; could you please make that configurable?

Everything else is cool!

@sharonovd Available in next version


V0.0.2 changely api update

This update handles the new APIs for changelly and updated our servers response to our more standard JSON.

Arrrr! This was to wrong branch. Closed.

😢


Feature: Login Page

I want to make login page and it will be like if we click on login before sign up then it will pop message that first sign up and then once user signed up successfully then they will be automatically directed to the login page and once we login then this information will be stored and saved now same will be implemented for login with Google and Facebook.

Pleass assign me this issue.


golang.org/x/crypto needs to be updated

CVE-2019-11840
An issue was discovered in supplementary Go cryptography libraries, aka golang-googlecode-go-crypto, before 2019-03-20. A flaw was found in the amd64 implementation of golang.org/x/crypto/salsa20 and golang.org/x/crypto/salsa20/salsa. If more than 256 GiB of keystream is generated, or if the counter otherwise grows greater than 32 bits, the amd64 implementation will first generate incorrect output, and then cycle back to previously generated keystream. Repeated keystream bytes can lead to loss of confidentiality in encryption applications, or to predictability in CSPRNG applications.
Can we update crypto here?
https://github.com/Azure/go-autorest/blob/3492b2aff5036c67228ab3c7dba3577c871db200/autorest/go.mod#L10

Hello,
I am updating this here since I felt its the same issue.
The crypto used in autorest/adal seems to be the old one still. I will open another bug for this one.
https://github.com/Azure/go-autorest/blob/21d4b01533b1005be0d020da67a6d3f8ebdf0141/autorest/adal/go.mod#L11


Update to work with Docker v1.13.0 parser API

Was broken by docker/docker@755be795

Coverage increased (+7.6%) to 85.311% when pulling a32ae108c93a04615ac99a8c5d0d6aea7cdef709 on michaelhood:mh/docker-parser-compat into 74f94bc3a48fdc8cb38e073b1761caa7fe6ab32a on moul:master.

LGTM

Thanks!


Release PCC.ODH

close #402

@MaryLJ I did not update the pcc index.

OK, I will do that.
Mary Jungers | Documentation Specialist
IHE International | IHE.net
From: John Moehrke @.>
Sent: Friday, March 8, 2024 10:54 AM
To: IHE/publications @.>
Cc: Mary Jungers @.>; Mention @.>
Subject: Re: [IHE/publications] Release PCC.ODH (PR #403)
@MaryLJ https://github.com/MaryLJ  I did not update the pcc index.
—
Reply to this email directly, view it on GitHub https://github.com/IHE/publications/pull/403#issuecomment-1986052444 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDULOKQPDV36YFZ2HIAUXTYXHULLAVCNFSM6AAAAABEND2C2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGA2TENBUGQ .
You are receiving this because you were mentioned.  https://github.com/notifications/beacon/AGDULONTW5U6HE3HMO5HJFDYXHULLA5CNFSM6AAAAABEND2C2OWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTWMDAVY.gif Message ID: @.*** @.***> >


Update event handler logic in search.js component

Not sure if we'd want to version bump? This shouldn't be a breaking change.


Update new versions of hardhat-deploy

The package "hardhat-deploy-ethers": "0.4.0-next.1" requires to be locked into this version as we are dependent on one of the functionalities it provides and is not available in "0.4.0.x stable release.  Opening up to higher/newer versions of this package leads to conflict.
Checksums matched!
Now using node v18.16.1 (npm v9.5.1)
@macbook-pro mina-state-proof % npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/ethers
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@nomicfoundation/hardhat-ethers
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/hardhat-deploy-ethers
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/.npm/_logs/2023-07-20T07_19_09_844Z-eresolve-report.txt

npm ERR!      /Users/.npm/_logs/2023-07-20T07_19_09_844Z-debug-0.log

This task it to track and ensure ethers/hardhat-deploy-ethers compatibility when they are in sync.

Closed by #95


Added many old ion lawsets for borgs and AI.

About the PR

Added a lot of ss13 lawsets as possible ion laws and AI circuit boards.
Why / Balance

Thought it would be funny to have more chaotic laws for cyborgs to be able to get.
Technical details

Added a lot of circuit boards, added new silicon laws, few of which can be rolled from ion storms.
Only .yml changes.
Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

add: Plenty of old silicon laws can now be rolled as ion laws.

Can you make a normal crewsimov one for the ai that occasionally gets replaced with one of the others? Is that within scope?

antimov is hilarious i hope these get added

Can you make a normal crewsimov one for the ai that occasionally gets replaced with one of the others? Is that within scope?

Thats something that someone else would need to add, I just simply added the laws to the code and made them possible to roll via ion laws

i feel like we brushed past the part about ai circuit boards, the laws can be stored on circuit boards?

i feel like we brushed past the part about ai circuit boards, the laws can be stored on circuit boards?

Currently there are circuit boards that cannot be obtained in a way other than the admin menu (unless they can and im not aware).
They can be inserted into the AI Upload Console to update the laws of the AI into whatever is on the board.
Currently in game theres NT, Corporate and Crewsimov, I just thought itd be fun to add those for the new lawsets I added in case someone makes them loot in maints or something, or for when they eventually become craftable

Currently in game theres NT, Corporate and Crewsimov
Wow, that's new

Wow, that's new

Was added at the same time AI, its just that these items cannot be found unless an admin spawns them in

Am I missing something or is rolling Antimov just an instant “I gotta go singuloose”?

Am I missing something or is rolling Antimov just an instant “I gotta go singuloose”?

It believe that would break the mass destruction rule, but im unsure how it works for borgs.
If anything can add a  law 1 saying that its just the crew that needs destruction and not the station

Silicon laws bypass roleplay roles if you’re referring to RP rule 9.

Silicon laws bypass roleplay roles if you’re referring to RP rule 9.

Oh yeah I just double checked, in that case I think it would be fine if you had a law 1 that says you have to avoid damaging the station

antimov says nothing about being elaborate. i suppose if it is within reason then antimov would mean singuloose now, but the borg would also go on a manual killing spree, and then just kill itself. this would also affect syndicate borgs to kill all syndicates. antimov is simply amazing, even if it means borg looses tesla., maybe antimov should replace one at a time though?

antimov says nothing about being elaborate. i suppose if it is within reason then antimov would mean singuloose now, but the borg would also go on a manual killing spree, and then just kill itself. this would also affect syndicate borgs to kill all syndicates. antimov is simply amazing, even if it means borg looses tesla., maybe antimov should replace one at a time though?

Replacing one at a time is not something i can do, but we also must remember that antimov is extremely low chance to roll as a lawset, especially since theres so many now

sounds just fine, i think borgs need more chances to turn evil anyways.

sounds just fine, i think borgs need more chances to turn evil anyways.

I think borgs already can turn "evil" plenty of time, especially if they know someone is a syndie they can just follow and help them as long as it doesnt break their laws
But I agree borgs need a lil more chaos

its against the rules to knowingly allow yourself to be subverted by a syndicate, "you cannot request or allow a law change". i also really think that robotics should to be reworked, which i should write some type of suggestion for.

its against the rules to knowingly allow yourself to be subverted by a syndicate, "you cannot request or allow a law change"

I didnt mean get emagged, i meant that if you, as a borg, are aware someone uses you for evil you can literally just help them out more as long as youre not asked to hurt anyone


Test of RNN in the case when some gradients are None

I added a test case which checks RNN behavior when some gradients are None.
This fix includes the test case that checks #3042
merge #4048 first
related to #4045, #3042

jenkins, test this please.

jenkins, test this please.

jenkins, test this please.

LGTM!


enhance histogram_quantile to get min/max value

This pr refers to the comments on https://github.com/prometheus/prometheus/pull/12188#issuecomment-1542311506
Which will fix #12172

@beorn7 could you help review this pr?

@fatsheep9146 I just learned that @carrieedwards was still working on the same thing (even though it might have looked from the outside as if the work had gone stale). Before you invest further work into this PR, let's sync with her to what point she actually got to avoid further parallel work.

Before

No problem! I'm ok if you want me to do any work.

OK, I've talked to @carrieedwards now. Her work is about at the same point as your work in this PR. Let's continue with your PR here, as everything that needs to still get done is already commented. We'll give @carrieedwards credit in the final commit for authoring the original work.
Looking forward to you addressing the final two comments. Thank you very much.

OK, I've talked to @carrieedwards now. Her work is about at the same point as your work in this PR. Let's continue with your PR here, as everything that needs to still get done is already commented. We'll give @carrieedwards credit in the final commit for authoring the original work.
Looking forward to you addressing the final two comments. Thank you very much.

All comments are resolved. @beorn7

=== RUN   TestRulesUnitTest/Bad_input_series
Unit Testing:  ./testdata/bad-input-series.yml
  FAILED:
1:48: parse error: unexpected character inside braces: '0'

=== RUN   TestRulesUnitTest/Bad_PromQL
Unit Testing:  ./testdata/bad-promql.yml
  FAILED:
    expr: "join_1 + on(a) join_2", time: 0s, err: found duplicate series for the match group {a="1"} on the right hand-side of the operation: [{__name__="join_2", a="1", b="4"}, {__name__="join_2", a="1", b="3"}];many-to-many matching not allowed: matching labels must be unique on one side

The failed tests seemed not related to this pr. Could you help rerun this check? @beorn7

I have reruned the failed check and it passed :+1:

@beorn7 two remarks are resolved


add section to readme with main difference to chzyer/readline

Things like:

Less refresh flicker on resize and editing
Modern/Better windows ANSI support
TODO: Undo support
Lots of bug fixes
Less and updated dependencies

#51


Add Go support for meta-examples

feature/golang branch has the initial support for a Go interface of shogun. it'd be great to have Go support added to our meta-example generator.

this could be a cool GSoC project


chore: delete "moduleResolution": "bundler" from tsconfig and jsconfig

Delete "moduleResolution": "bundler" from tsconfig and jsconfig as its already in the tsconfig located at "./.svelte-kit/tsconfig.json"

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[✅ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

[ ] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

I was also thinking of removing it but it’s probably better to not remove it because the generated config only exists after the user runs vite dev, etc.

Oh right it's part of the generated config by now. Mhm..

i actually wonder if we should encourage commiting the generated config instead of ignoring it.
Remembering to run sync when switching branches is a bit of a pain.

I actually wonder if we want to go the reverse direction and set NodeNext in the generated config and then have all apps set bundler. It can be very disruptive to the ecosystem when libraries don't set NodeNext. There's not a lot of harm if an app does that except for annoyance at extra work, but things don't break in the same way that they do if a library sets bundler then potentially affecting all of its dependencies.
E.g. check out the Threlte instructions at https://threlte.xyz/docs/learn/getting-started/installation which have a needless step in their setup instructions because they're missing the moduleResolution that we ship by default for libraries (https://github.com/threlte/threlte/issues/985):

I'm going to go ahead and close this since the templates have moved to https://github.com/sveltejs/cli


[BUG] MetalLB instructions fail on k8s 1.25+

What happened?
I followed the documentation on Deploying a TCP Load Balancer for User Workloads on my MicroShift cluster running on OpenShift 4.12.  The instructions to deploy resource manifests from the metallb project do not work because PodSecurityPolicy which was previously deprecated, has now been removed from OpenShift 4.12 / Kubernetes 1.25.
What did you expect to happen?
Applying the YAML manifests to deploy the project should work.
How to reproduce it (as minimally and precisely as possible)?

Deploy MicroShift on OpenShift 4.12.
Run the instructions to apply the resource manifests from metallb project:

oc apply -f https://raw.githubusercontent.com/metallb/metallb/v0.13.4/config/manifests/metallb-native.yaml

It should fail when attempting to create objects of type PodSecurityPolicy.
Anything else we need to know?
I've already found a solution, which is to use updated manifests from that project:
oc apply -f https://raw.githubusercontent.com/metallb/metallb/v0.13.7/config/manifests/metallb-native.yaml

Afterwards, I still needed to apply the privileged scc to the controller and speaker serviceaccounts as follows:
oc adm policy add-scc-to-user privileged -z controller -n metallb-system
oc adm policy add-scc-to-user privileged -z speaker -n metallb-system

Environment

MicroShift version (use microshift version):
$ microshift version
MicroShift Version: 4.12.0-0.microshift-2022-11-17-084702-untagged
Base OCP Version: 4.12.0-0.nightly-2022-11-07-181244

Hardware configuration:
Intel NUC with 2 cores and 16 GB RAM

OS (e.g: cat /etc/os-release):
$ cat /etc/os-release
NAME="Red Hat Enterprise Linux"
VERSION="8.7 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.7"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.7 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/red_hat_enterprise_linux/8/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.7
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.7"

Kernel (e.g. uname -a):
$ uname -a
Linux [hostname redacted] 4.18.0-425.10.1.el8_7.x86_64 #1 SMP Wed Dec 14 16:00:01 EST 2022 x86_64 x86_64 x86_64 GNU/Linux

Others:

Relevant logs

/assign @ggiguash


feat: Unify TextInput autoComplete and textContentType props

Summary
This unifies the Android only  autoComplete and the iOS only textContentType TextInput props with the web autoComplete values as requested on https://github.com/facebook/react-native/issues/34424. I left the textContentType prop and the current supported autoComplete values untouched in order to avoid having a breaking change. This also updates RNTester to include test cases using the new autoComplete values
Changelog

[General] [Changed] - Unify TextInput autoComplete and textContentType props
Test Plan

Open the RNTester app and navigate to the TextInput page
Test the TextInput component through the Text Auto Complete section

https://user-images.githubusercontent.com/11707729/187118267-3b509631-7b84-47b7-a580-567a7f5b483f.mov

@necolas do you mind checking what is causing internal builds and tests to fail?

Someone else will have to import this PR. I closed that internal diff as I'm away for the rest of September

Ping @cipolleschi or @jacdebug to import


Fix references for v2.2.3 on CHANGELOG

Some references were pointing to 2.2.3 instead of v2.2.3.

Thanks for the fix


Safari passing WPT tests for "Hacker News" scenario

[x] https://github.com/GoogleChromeLabs/chromium-bidi/milestone/2
[ ] https://github.com/GoogleChromeLabs/chromium-bidi/milestone/7

Out of scope for this repo.


Helm fixes

Signed-off-by: Ilya Lobkov<EMAIL_ADDRESS>
Description
Move jaeger and skydive to nsmd-monitoring chart, add parameter 'pullPolicy' to values.yaml
Motivation and Context
Issue https://github.com/networkservicemesh/networkservicemesh/issues/837
How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[X] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.

@lobkovilya can we mive the helm folder to deployments/helm as the defaul project layout suggests: https://github.com/golang-standards/project-layout/tree/master/deployments
I assume this is true for all k8s/conf files, but that is a separate issue anyway.


[$250] Web - Deleting a message/comment in report shows New messages floating indicator even if no new message in the report - Reported by @aneequeahmad

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch web app.
Click on any report having list of comments/messages in LHN
Hover on any comment/message and click on delete comment/message icon.
Click on delete in Delete comment modal.
Scroll to top.

Expected Result:
Shouldn't see New message floating indicator.
Actual Result:
New message floating indicator is shown
Workaround:
unknown
Platform:

Where is this issue occurring?

Web

Version Number: 1.2.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/201708226-2f4bfc97-f091-428e-ba8e-43b543dfb116.mov
Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668232657153179
View all open jobs on GitHub

I am able to reproduce. I am assigning out to an external contributor.

Definitely Looks like a regression!

I was able to reproduce. Job posted - https://www.upwork.com/jobs/~015eb0ac1a09b42c84

@marcaaron this might be related to the New Indicator PR can you confirm, thanks!

@Santhosh-Sellavel Sorry, I can't determine if it's related. But if you see a clear link I will try to assist however I can.

I want to say this is a known issue and has never really worked correctly. There are a lot of small edge cases related to deleting chat messages that proved to be difficult to solve when we moved to the new style API.

Not overdue, looking for proposals!

@marcaaron should I raise the pay to $500?

Not overdue, still looking for proposals!

I'm no longer able to reproduce this on dev or staging.  @mvtglobally or @davidcardoza are you able to reproduce this?
https://user-images.githubusercontent.com/22447860/203138212-0cc9036a-99ab-440c-8ffd-9e57ae973ddf.mp4

Ya, I can't seem to reproduce either after several attempts. Should I close this issue?

Lets close this out. If QA can reproduce, we can reopen it then


Conflicting environment variable settings

When I configure the px4-based simulation environment, after I perform the compilation "make px4_sitl gazebo", I will meet an error, look at the picture above, this means that there is an environment variable name that is not set correctly, the enviroment variable name is "GAZEBO_RESOURCE_PATH", I checked the value of this environment variable, and found that it should be set in this step, "add 'source /path/to/uav_simulator/gazeboSetup.bash'to ~/.bashrc",
if I delete this sentence from the file, this error will not be reported when compiling. because this step is set in the simulation that is not based on px4, will  add 'delete /path/to/uav_simulator/gazeboSetup.bash' from ~/.bashrc",this affect the simulation based on px4?

I use "rostopic list" , and can not find those topics started with "/camera", how can I solve this problem?


Cannot pass factorization_size param to fmqa.FMBQM.from_data(xs, ys, factorization_size = 8)

Bug?

Traceback (most recent call last):
  File "./bin/fmqa_model.py", line 106, in <module>
    trained_model = train_regr(x_list, y_list)
  File "./bin/fmqa_model.py", line 60, in train_regr
    model = fmqa.FMBQM.from_data(xs, ys, factorization_size = 8)
  File "/home/berenger/.local/lib/python3.8/site-packages/fmqa-0.0.1-py3.8.egg/fmqa/fm_binary_quadratic_model.py", line 72, in from_data
  File "/home/berenger/.local/lib/python3.8/site-packages/fmqa-0.0.1-py3.8.egg/fmqa/fm_binary_quadratic_model.py", line 35, in __init__
TypeError: __init__() got an unexpected keyword argument 'factorization_size'

it looks like an hyper parameter users should be allowed to optimize...


How do you query metrics?

In datadog's api they mention you can query metrics (http://docs.datadoghq.com/api/#metrics-query). Looking through your docs, I couldn't find anything to do that. I saw SearchMetrics, but that didn't query timeseries data.

Looks like nobody has implemented that method yet. Should be pretty trivial though, about 5 lines of code in series.go if you want to take a crack at it.

I've made a PR, tested it against my own stuff and found it works: https://github.com/zorkian/go-datadog-api/pull/18

Merged -- thank you! Closing this :)


Make a settings file

There should be a settings file that we read in so people can set variables / how they want to use it
Shortcuts, model, custom prompts, etc

Ok, implemented this with: https://github.com/jasonjmcghee/plock/pull/4 which fixes this issue


Stdout buffer flush in Write String function

Hey,
I noticed a behavior of the write to string function that is not what I expected. After some investigation I figured out that the Stdout by default is buffered, and depending on the configuration will only flush its outputs if there is an end of line, which is what I understand the rust part of g-cli is doing.
So, everytime I use the write string function, nothing happens, and only when a write line function is called, the terminal is populated.
My use case is related to writing pieces of string for a progress for example, so user can see the progress, without resorting to use the new line.
Python for example, has this sys.stdout.flush(), rust I think is std::io::stdout().flush()
Could we incorporate in G-CLI an option in the "Write String" function, where we could set a flag to force flushing the Stdout buffer?
Regards,

Sounds like a great change. I would probably be inclined to make it part of the LabVIEW side so it is similar to having the APIs native there but will look through some of the options

Thanks for the feedback.
I am in doubt actually if this can be done from LabVIEW side, as this is a behavior from the application writing to terminal.
I don't know how big the change would be (no rust expert), but I guess it would need to create a new message type, and handing that specific one to write immediately as the others should continue to be the same.
Right now I have a workaround with escape codes, it is clunky and not ideal but it works.

You are absolutely correct - I've confirmed that the flush needs to happen on the Rust side.
My inclination is to give the LabVIEW user control over this so I'll add a new message and API for this.

Sounds good. Let me know if you need any help on testing whenever you come to this.


How to set trust_remote_code=True in privateGPT to use nomic-ai/nomic-embed-text-v1.5 embed model from huggingface.co?

First of all, grateful thanks to the authors of privateGPT for developing such a great app.
However, when I tried to use nomic-ai/nomic-embed-text-v1.5 from huggingface.co as an embedding model coupled with llamacpp for local setups, an error occurred as follows:
ValueError: Loading nomic-ai/nomic-embed-text-v1.5 requires you to execute the configuration file in that repo on your local machine. Make sure you have read the code there to avoid malicious use, then set the option `trust_remote_code=True` to remove this error.

I am wondering how I can set the trust_remote_code=True option and properly pass it to privateGPT. I tried inserting trust_remote_code: true in the huggingface or llamacpp section in the yaml file, but it did not work.
The following is my configuration profile.
server:
  env_name: ${APP_ENV:demo-local}

llm:
  mode: llamacpp
  max_new_tokens: 512
  context_window: 3900
  tokenizer: mistralai/Mistral-7B-Instruct-v0.2
  temperature: 0.1

llamacpp:
  prompt_style: "mistral"
  llm_hf_repo_id: TheBloke/Mistral-7B-Instruct-v0.2-GGUF
  llm_hf_model_file: mistral-7b-instruct-v0.2.Q4_K_M.gguf
  tfs_z: 1.0
  top_k: 40
  top_p: 1.0
  repeat_penalty: 1.1

embedding:
  mode: huggingface
  embed_dim: 768
  ingest_mode: pipeline
  count_workers: 4

huggingface:
  embedding_hf_model_name: nomic-ai/nomic-embed-text-v1.5

rag:
  similarity_top_k: 5
  rerank:
    enabled: false
    model: cross-encoder/ms-marco-MiniLM-L-2-v2
    top_n: 3

data:
  local_data_folder: ../KBs/demo

vectorstore:
  database: qdrant

qdrant:
  path: ../KBs/demo/qdrant

nodestore:
  database: simple

Any suggestions? Thank you.

Hi, same situation here. did you find any solution for this?

To set the trust_remote_code option in privateGPT, you need to modify the following code sections:

add definition of trust_remote_code to private_gpt\settings\settings.py , the default value is set to False.

class HuggingFaceSettings(BaseModel):
    embedding_hf_model_name: str = Field(
        description="Name of the HuggingFace model to use for embeddings"
    )
    access_token: str = Field(
        None,
        description="Huggingface access token, required to download some models",
    )
    trust_remote_code: bool = Field(
        False,
        description="Trust remote code when downloading models",
    )

insert trust_remote_code=settings.huggingface.trust_remote_code, to  private_gpt\components\embedding\embedding_component.py :

self.embedding_model = HuggingFaceEmbedding(
                    model_name=settings.huggingface.embedding_hf_model_name,
                    cache_folder=str(models_cache_path),
                    trust_remote_code=settings.huggingface.trust_remote_code,
                )

finally, add trust_remote_code:true to settings-{profile}.yaml

huggingface:
  embedding_hf_model_name: nomic-ai/nomic-embed-text-v1.5
  access_token: ${HUGGINGFACE_TOKEN:********}
  trust_remote_code: true

Above modifications work for me.

@01PAfXWT Worked like a charm, thanks mate 👍


chore: added collaborators to root OWNERS file

Why
some people listed in CODEOWNERS file and people with write permissions to the repo are not able to approve PRs via the usual prow workflow (i.e. by adding the /approve comment), because they are not listed in OWNERS file
Issue ticket number and link
N/A
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/lgtm


fix(Typescript Support): Add missing definitions to typescript d.ts file

I added all the missing properties to the typescript type definition file. Additionally, I updated the package-lock file due to #555. I can make that change a separate PR or remove entirely if you wish.

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #556   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         945    945
=====================================
  Hits          945    945

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7198e...25ae2b0. Read the comment docs.

Lol you were faster than I was to answer your issue! ^^


BEP Describe personas and separate portal and framework docs

Hey, I just made a Pull Request!
BEP Describe Personas associated with a Backstage adoption journey and propose the clear separation of the Backstage Developer Portal and Backstage framework docs.

@waldirmontoya25 apologies - but we already merged a BEP-0006 😅  We're going to run out of numbers soon. Could you update this to be 0007 instead? :pray:

@waldirmontoya25 apologies - but we already merged a BEP-0006 😅 We're going to run out of numbers soon. Could you update this to be 0007 instead? 🙏
Side note, I wonder if there's a better process for this, maybe the number could be added in a seperate PR which is merged quicker than it being in a pending approval state.

hey @benjdlambert sure, I just removed the numbers 😅

bump


Rename clientId to clientInfo

Closes #7734

The code for a database migration never changes. So it's very unlikely we'll introduce a bug at a later point in time. Even if we find a way to do that, it's very unlikely that it'll affect a lot of users. Because by that time most users will have upgraded to or newly installed a version of the app that doesn't require the migration anymore.
If code never changes, having tests is mainly useful during development (and maybe code reviews) to show the code handles all the cases it was meant to handle. In this case the change is trivial and I manually verified the code does what it is supposed to do. In my opinion the cost (time to write + CPU cycles spent in all future test runs) of an automated test to check a setting is renamed properly outweighs its usefulness.

The code for a database migration never changes.

I understand your point that the code for the database migration is unlikely to change, and that the cost of writing and running a test for this specific scenario might be high. However, I would like to argue that the potential benefits of writing a test for this code outweigh the costs.
Firstly, even if the code is unlikely to change, it's not impossible. And if it does change, a test would help catch any bugs or errors that might be introduced. This is a key principle of defensive programming: anticipating and mitigating potential issues before they become problems. Just have a look at the recent changes done for the StorageMigrationHelper and DefaultStorageMigrationHelper, that touches exactly this "never changing` code.
Secondly, while the change may be trivial, it's still important to verify that the code works correctly. Manual verification is not a reliable method, as it can be prone to human error. Automated tests provide a way to ensure that the code works as expected, without relying on manual verification.
Thirdly, the test wouldn't need to be run frequently. It could be put in its own suite and run at a lower pace. This would ensure that the code is still tested periodically, without slowing down the main test suite.
Finally, writing tests for this code would also provide a layer of documentation and understanding of how the code works. It would make it easier for other developers to understand the code, and would provide a clear example of how to test this specific functionality.


(BKR-587) added nil as a result to apply_manifest_on docs

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1669/
Test FAILed.

failure unrelated to change

:+1:


Continued mismatch between PR and tracking issue

Users are still struggling matching up the PRs to the Issues, making linking the two very difficult.

@markweitzel the user indicated the API was Public and didn't add a PR at creation time for our tooling to verify.

When they added the PR, they did it directly in the GH issue which doesn't have any validation. If they would have done it in the scheduling tool (which is the recommended way), they would have seen the error.


Cast source_url to string in terraform provider

It seems that https://github.com/dependabot/dependabot-core/commit/b4d66fa5ec88d6456a63fd1c04504ea9b325e586 introduced a bug where URI object would be passed in to get_proxied_source method. This results in raising undefined method 'start_with?' for #<URI::HTTPS>.
Convert URI to String for it to work correctly

@jeffwidman Totally makes sense to add a spec for that and I was thinking about it but was a bit lazy on a Saturday morning to do so 😄
The spec You linked, only tests service_url_for method, so it doesn't get to the code in question where the problem happens.
The issue is basically branch coverage.
https://github.com/dependabot/dependabot-core/blob/46aecc93aaf79dfe9a2c55574fbf4644d27f70ed/terraform/spec/dependabot/terraform/registry_client_spec.rb#L150
this spec is executing the right code, but it does not return X-Terraform-Get as path to trigger condition source_url.start_with?("/", "./", "../").
To add a spec, I would need to find a way to record a proper vcr cassette. I ran in to this issue when using private Gitlab terraform registry, not sure what other cases might reproduce this.

Hei @andrcuns!
Even if not a real repo, what I would do is modify the recorded VCR responses that we have already in place to simulate this case, namely, copy the existing responses by with a X-Terraform-Get relative to the download endpoint.
Do you think that would work?

@deivid-rodriguez
Yeah, I was thinking about just copying the existing one, did not have time to do it yet.
One note though, after the latest release, it started working again and that line of code is not triggered anymore for some reason 😅

🤣 That's surprising! Research on why appreciated 😅.

gentle nudge @andrcuns any chance of figuring out why this suddenly started working?

@jeffwidman Sorry, I have been a bit busy lately and haven't had time to do any investigations. Given I will be "on the road" for several upcoming months, I'll probably wont have much time to investigate it anytime soon.
I could try and add a proper spec, regardless of why it actually started working (I suspect changes in tf version or tf registry itself), the actual described bug is still there as it's fairly clear from just looking at the code.

Our point is it would be useless to fix a bug that nobody is running into because the code is no longer hit. That would be the case if this was a change in the terraform registry, right? And even it it's some change in terraform itself, the bug would be gone once you upgrade.
That's why I believe it's more rewarding to spend time on investigating this and potentially deleting this now dead code, than on writing a spec.

Our point is it would be useless to fix a bug that nobody is running into because the code is no longer hit

I kind of don't agree with such approach when there is a clearly visible wrong code execution path 😄
Basically, I won't have time to do such investigation, so feel free to close this then.

I kind of don't agree with such approach when there is a clearly visible wrong code execution path 😄

But don't you agree it would be better to delete the code if it's no longer needed? I think it would be not good that you spend time writing a test for this if we will delete both the test and the code some time later once we verify this is no longer needed in the versions of terraform that we support.

Basically, I won't have time to do such investigation, so feel free to close this then.

It's alright, let's leave it open for a bit, hopefully we can look into it ourself!
Thanks for all the help in this and other PRs, by the way ❤

But don't you agree it would be better to delete the code if it's no longer needed?

100% agree on that, but I don't know terraform well enough and can't really determine if it's safe to delete this code even if usecase I encountered this problem personally, is not valid anymore.


Add property "priorityMixPolicy" of VM Scale Set to .NET SDK for Version 2022-08-01

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

Accidentally rebased onto the wrong branch thinking I was working off of a different branch than I actually was. Please disregard this PR


chore: add @douyinfe

Summary by CodeRabbit

Chores

Added a new collaborator @douyinfe to the project.

https://www.npmjs.com/search?q=%40douyinfe


installation using docker file

i am currently testing to build the image using docker in a virtual machine, if so does it require any gpu usage?

also it shows that the public key isn't available and could not proceed building the image


LiveAudio KeepAlive

I notice the JS SDK's has KeepAlive implemented but it's not added yet to .net SDK.
I am cutting audio to deepgram while my agent speaks and on longer sentences (I think around 10s) the websocket closes.
I couldn't see in the docs what logic the deepgram API is expecting.  If I fork the repo and add a background task to send a message with type="KeepAlive" every 5 seconds would that be a good approach?
Any extra info on your API behaviour would be greatly appreciated.

Hi @GuerrillaCoder
There is a KeepAlive function implemented in the current v3 release which will send the message out for you, but you will need to start a thread to send that message every 5 seconds:
https://github.com/deepgram/deepgram-dotnet-sdk/blob/release-v3/Deepgram/Clients/LiveTranscriptionClient.cs#L174
There are plans in the upcoming v4 to go one step further so that when thestart()`connect()` Client are called this will automatically start a thread for you provided a flag is set in the configuration.
In the meantime, you can either:

extended the LiveClient object then implement the thread function
create a thread function that will manage the Client itself

Oh, I was using wrong branch!  Many thanks for the quick response.

Oh, I was using wrong branch! Many thanks for the quick response.

No worries at all. Glad to help out!


Update Python syntax highlighting grammar

Latest commit is https://github.com/MagicStack/MagicPython/commit/7d0f2b22a5ad8fccbd7341bc7b7a715169283044 .
I'm happy to do the upgrade for https://github.com/microsoft/vscode/blob/main/extensions/python/syntaxes/MagicPython.tmLanguage.json , but it's in JSON while upstream is in TextMate XML. Do we have a tool we typically use to convert from TextMate XML to JSON?

Yep, we have a script (yarn run update-grammar from the built in extension directory) and then run the integration tests. I run this during debt week and then on demand when requested. Update incoming.


show multipart requests as running until they are finished or cancelled

I noticed this after looking at https://github.com/graphql/graphiql/pull/2885: We're currently not showing the stop button while a multipart request (e.g. a subscription) is running. The only state provided by the context is the boolean isFetching which is true only until the first (partial) response is returned.
This PR solves the issue by exposing another boolean isSubscribed which is true if there is an active subscription running (i.e. the fetcher function returned an unsubscribable).
Sidenote: We can't just change the semantics of the isFetching state. It also controls the loading spinner which should indeed only be shown while the first response is loading.

Also related to https://github.com/graphql/graphiql/issues/2774

Awesome, thanks for the review @TallTed 🙌


Security Audit

Perform a complete security audit.

I reviewed the can_update() method all models to ensure we are enforcing write permissions as described in the "Access Control" section of OpenCloud guide: http://open-cloud.github.io/0_overview/
There were some inconsistencies that needed to be fixed. I also refactored the permission checking business rules and moved them the user model. Every model still has a can_update(user) method, but instead of containing business rules object.can_update(user) just calls user.can_update_object(object).  Moving the business rules out of the various object.can_update() and moving them into the user model helped eliminate redundant and inconsistent code form our object models.
I'm in the process of writing regression tests to check object write permissions. Once this is done I plan to create a script that builds a docker container and runs the tests inside the container, allowing us to quickly and easily verify our object write permissions for future builds. I hope to get this integrated into the jenkins build job.


Open Opportunities should have its own hostname

proposal:  http://open.digitalgov.gov

migrating issues to:  https://github.com/18F/midas/issues/811


interaction_check issue

Summary

Reproduction steps
Use for example jsk sh a command

Expected results
Interaction bottons to work

Actual results
Interaction buttons doesn't work cause of breakingchanges
https://github.com/iDevision/enhanced-discord.py/commit/1fae5bface6cdd00cdd22b9247eb62a804cbe9d3
Ignoring exception in view <PaginatorInterface timeout=7200 children=6> for item <Button style=<ButtonStyle.secondary: 2> url=None disabled=False label='▶' emoji=None row=None>:
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/discord/ui/view.py", line 353, in _scheduled_task
    allow = await self.interaction_check(item, interaction)
TypeError: interaction_check() takes 2 positional arguments but 3 were given

Checklist

[x] I have updated discord.py and jishaku to the latest available versions and have confirmed that this issue is still present
[x] I have searched the open issues for duplicates
[x] I have shown the entire traceback, if possible
[x] I have removed my token from display, if visible

System information

Python v3.8.10-final
discord.py v2.0.0-alpha

discord.py pkg_resources: v2.0.0a3693+gabe4e4e6

aiohttp v3.7.4.post0
system info: Linux 5.4.0-99-generic #112-Ubuntu SMP Thu Feb 3 13:50:55 UTC 2022

Name: jishaku
Version: 2.3.2
Summary: A discord.py extension including useful tools for bot development and debugging.
Home-page: https://github.com/Gorialis/jishaku
Author: Devon (Gorialis) R
Author-email: None
License: MIT
Location: /usr/local/lib/python3.8/dist-packages
Requires: click, braceexpand, import-expression
Required-by:

This is a pretty awkward signature change. Thinking about what I should do about it


Use clap::builder::NonEmptyStringValueParser for UV_PYTHON env var

Summary
Closes #7841. If there are other env vars that would also benefit from this value parser, please let me know and I can add them to this PR.
Test Plan
When running the same example for the linked issue, we now get a different error:
UV_PYTHON= cargo run -- init x
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.52s
     Running `/Users/krishnan/Projects/uv/target/debug/uv init x`
error: a value is required for '--python <PYTHON>' but none was supplied

It looks like this will error. Do we want it to error, or is it supposed to "unset" the env var? Do you know what other tools do?

I think we should silently ignore the variable if it's empty, generally. I am curious what other tools do though.

Good question. I don't know what other tools do here but I think it feels reasonable to coerce empty strings to None rather than having them error out - I'm happy to make that change here.

We have this pattern for UV_INDEX_URL -- we wrap it in a Maybe type, where it's Maybe::None when empty. It has to be distinct from Option because Clap has special handling for Option.

I implemented your suggestion re: Maybe - I think I did this properly but let me know if I didn't.

Thanks, that's great!


[FX-4751] Make jest tests work

FX-4751
Description
Describe the changes and motivations for the pull request.
How to test

Temploy
Clone the branch locally and run yarn test:unit

Screenshots

Development checks

[NA] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[x] Annotate all props in component with documentation
[x] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[x] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[x] Covered with tests (visual tests included)

Breaking change

[NA] codemod is created and showcased in the changeset
[NA] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers

Also, package.json highlights nodeJS@18 as a minimum required engine: https://github.com/toptal/picasso/blob/master/package.json#L177
I think, we must also increase this version


[FEATURE] add sentence-transformers support for the to_argilla method

Is your feature request related to a problem? Please describe.
We ideally want to enrich data as much as possible when pushing it to Argilla to allow for out-of-the-box support for as many search features as possible
Describe the solution you'd like
We want to re-use the SentenceTransformersExtractor introduced as Argilla integration through this PR.
dataset = ...
dataset.to_argilla(vectors=True)

if vectors:
    try:
        from argilla import SentenceTransformersExtractor
    except:
         # handle warning and skip
    if isinstance(vectors, SentenceTransformersExtractor):
        st = vectors
    else:
        st = SentenceTransformersExtractor
    ds = st.update_dataset(ds)

Describe alternatives you've considered
N.A.
Additional context
N.A.

default=True

We decided to move this issue to 0.5.0 along with https://github.com/argilla-io/distilabel/issues/231 because we wanted to outline the fields a bit more which we would like to include by default because Argilla only allows 5 vector settings per record i.e. we can only select 5 fields.


Incorrect slot <-> time conversions

At the moment plutp uses default SlotConfig for bot-plutus-interface w/o adjusting zero-slot time and slot length. This results in incorrect slot <-> time conversions and validators with time range checks can't work reliable.
Instead of adjusting zero-slot time and slot length, though, there is more general fix in progress in bot-plutus-interface, which will allow to remove SlotConfig completely and rely on node queries during  slot <-> time conversions.
This ticket is created to track the progress.

[x] update bpi dependency once implementation is finished - related issue
[x] add contract which exercises correctness of time <-> slot conversion to tests

Closed by #71


Retract button on a attribution funding view redirects to list

The retract button on the attribution funding view (http://localhost:8000/en-gb/funding/28/view/) redirects to membership list. This seems like confusing behaviour, it isn't clear to me (without reading the title) what I should be seeing here.
A better name for the button (e.g. manage memberships) and a better view in the resulting list (e.g. a list filtered by project) might make more sense.

The retract button retracts permission from the user to use the FundingSource then directs to the membership list. This is because it's implemented via ToggleFundingSourceMembershipApproved, which on success redirects to list-funding_source_memberships. This toggle is also used in the funding source memberships view, where it makes sense to redirect back there. I don't know how to make Django direct back to the previous view again… (See also #127)

I think the thing you're suggesting (but don't know how to do) sounds like a sensible option to me. Let's do that!  :+1:
It's a lot simpler that you'd think, honest. :smile:

Moving to the back burner as this button is quite unlikely to be used, and is less exposed than it previously was.


Add support for Python 3

Drops support for python 2.4, 2.5, and 2.6.  Adds explicit support for python 2.7, 3.4, and 3.5 on Django 1.8 and Django 1.9.  Older versions of Django will probably work, but the test suite doesn't.
Also adds .travis.yml for CI.  Just enable travis for the repo.

Thanks so much for this work, Matt, and apologies for letting it languish for so long.

Released as 2.0.0


[feature required] pouch info should also show image proxy info

Ⅰ. Issue Description
We need to show image proxy info in pouch info
Ⅱ. Describe what happened
Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?
Ⅵ. Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

I have assigned this issue to @ZouRui89
Please help to handle this. Thanks a lot.


Problems in TriggerCollection Members page

Two problems with https://docs.microsoft.com/en-us/previous-versions/visualstudio/design-tools/expression-studio-4/ff724858(v=expression.40) page:

Link for the Add method is broken.

The page contains a generic banner about checking the Microsoft Product Lifecycle.  But (a) this banner is not present on other pages of this class( at least those I happened to visit) and (b) it's not clear which product needs to be looked up in Microsoft Product Lifecycle.

Thank you for the feedback! The content above is archived and is no longer updated.


Diagnostic Settings as Extension Resource Deployment

Changes the diagnostic policies to deploy as an Extension Resource instead of a provider resource.

Changes the diagnostic policies to deploy as an Extension Resource instead of a provider resource.