implement driver-cql-scylla-shaded

Implement driver for ScyllaDB, which similar to driver-cqld3-shaded, but have some syntax difference and using scylla java driver

@dkropachev I've added #421 as a way to explain and discuss what needs to be done for an effective PR. Here are the current options that I can think of:

merge this after review, with separate work to occur on the j17-preview branch.
Prepare a driver on the j17-preview branch.
Use the CQLd4 driver on the j17-preview branch.

In any case, we won't be using shading on the main branch once the j17-preview branch is ready for merge. Perhaps we need to talk about the specific differences you have in client behavior and why it has to be a different re-instanced copy of a whole driver tree.

@dkropachev I've added #421 as a way to explain and discuss what needs to be done for an effective PR. Here are the current options that I can think of:

merge this after review, with separate work to occur on the j17-preview branch.
Prepare a driver on the j17-preview branch.
Use the CQLd4 driver on the j17-preview branch.

In any case, we won't be using shading on the main branch once the j17-preview branch is ready for merge. Perhaps we need to talk about the specific differences you have in client behavior and why it has to be a different re-instanced copy of a whole driver tree.

Regarding differences, in major part Datastax and ScyllaDB drivers are similar, but there are crucial differences:

ScyllaDB supports shard awareness, meaning that driver holds separate connection to each shard and also have special logic that allows it to know to which exactly shard query should go, which allows it to send queries directly to the shard, skipping coordinator. This feature optimize network usage inside the cluster and make it more productive.
There are some features that exist in Datastax and do not exist in ScyllaDB, which is could be disabled via ANTLR syntax schema. One example is stored FUNCTIONS
There are some features that do not exist in Datastax and exist in ScyllaDB, such as a. Caching control (BYPASS CACHE, and disable cache per table) and b. ICS

Because of these differences I think that It would be better to keep both drivers separately.
Regarding new driver API, I do not want to put an extra work on you, so, If new driver API/j17-preview is far from been ready, that it would be great to have this PR merged and later prepare driver using new API on j17-preview.
At worst you will merge j17-preview to main without ScyllaDB driver.
Regarding testing, I will take a look at what you have there and do similar things on this driver, also If you have testing protocol beside code, let me know, I will follow it to make sure it is fully functional.
What is the status of j17-preview, is cqld4 functional there ? Can I start looking at it ?

@dkropachev Yes, the cqld4 driver is functional. The key APIs to look at are DriverAdapter and its implementations. You'll find a different set of supporting types that I would have called "missing tools." If you study the Cqld4DriverAdapter and the DynamoDBDriverAdapter, you'll see how they are used. Specifically, these types are all more targeted and prescriptive around how to construct ops: DriverAdapter, OpMapper, OpDispenser, and ParsedOp. Also, native driver state (the object graph) associated with an instance of a driver must now live in a DriverSpaceCache (which can be initialized as needed via a DriverAdapter delegate method).
If you study the two initial implementations above, it should start to make sense. Ideally these are all in a developer docs site soon with some supporting examples.
If you are ok with using the j17-preview branch, I think it will save us both effort, since the API changes are causing some structural divergence from main.

@dkropachev Yes, the cqld4 driver is functional. The key APIs to look at are DriverAdapter and its implementations. You'll find a different set of supporting types that I would have called "missing tools." If you study the Cqld4DriverAdapter and the DynamoDBDriverAdapter, you'll see how they are used. Specifically, these types are all more targeted and prescriptive around how to construct ops: DriverAdapter, OpMapper, OpDispenser, and ParsedOp. Also, native driver state (the object graph) associated with an instance of a driver must now live in a DriverSpaceCache (which can be initialized as needed via a DriverAdapter delegate method).
If you study the two initial implementations above, it should start to make sense. Ideally these are all in a developer docs site soon with some supporting examples.
If you are ok with using the j17-preview branch, I think it will save us both effort, since the API changes are causing some structural divergence from main.

Great, what do you think of the merging this PR into master and creating an issue and separate PR to implement scylla driver support on j17-preview ?

I'm ok with that, however the goal is to merge j17-preview into main very soon. So that shifts the focus to the j17-preview implementation, since you would lose access to the driver without it. However, getting this into a current release would allow it to be used even if you version locked to a specific release. So I suppose both are valid.

I'm ok with that, however the goal is to merge j17-preview into main very soon. So that shifts the focus to the j17-preview implementation, since you would lose access to the driver without it. However, getting this into a current release would allow it to be used even if you version locked to a specific release. So I suppose both are valid.

@jshook , could you please take a look at - https://github.com/nosqlbench/nosqlbench/pull/427

Closing this in lieu of the approach described in #427 . Shaded artifacts will not be included by default in the main NoSQLBench artifacts, although externally hosted drivers can be loaded at runtime using the steps described there.


LoadingObjectManager. How to add the custom balloon?

I need to add the React component with buttons from the UI-kit library as a balloon. Should I implement the balloonContentLayout option or smth else?
const inizilizeMap = () => {
	const objectManager = new ymaps.LoadingObjectManager(autoApiUrlForLoading, objectManagerProps);
	objectManager.clusters.options.set({...});
	objectManager.options.set('geoObjectOpenBalloonOnClick', false);
	objectManager.objects.options.set({...});

	objectManager.objects.events.add(['click'], (event: any) => {
		const objectId = event.get('objectId');
		const data = objectManager.objects.getById(objectId); // receive data for the balloon

		objectManager.objects.options.set({
			balloonContentLayout: makeLayout(ymaps.templateLayoutFactory), // ???
		});

		objectManager.objects.balloon.open(objectId);
	});
	...
}

....

return (
	<div className={styles.map} ref={containerRef}>
		<YMaps query={{ load: 'package.full' }}>
			<YandexMap
				{...MAP_SETTINGS}
				state={mapState}
				onLoad={(maps: YMapsApi): void => {
					if (maps && !ymaps) {
						setYmaps(maps);
					}
				}}
				instanceRef={ref => {
					mapRef.current = ref;
				}}
			/>
		</YMaps>
	</div>
);

@aveselovalova there are some issues that can help you: https://github.com/gribnoysup/react-yandex-maps/issues/150, https://github.com/gribnoysup/react-yandex-maps/issues/130, https://github.com/gribnoysup/react-yandex-maps/issues/27
Unfortunately ymaps.templateLayoutFactory does not support react components. Only html string template. So if you don't have any logic inside balloon it will be easier to use just html strings. Otherwise you will need to implement some difficult logic. Also I made some research on how it can be done, so you can checkout this, but it was quite old solution.

@mmarkelov Thanks for the answer. Are you going to implement React components support for ymaps.templateLayoutFactory in the future?
I implement the template as a html string and completely update the click event if some props have changed, like this...
useEffect(() => {
	objectManager.objects.events.remove(['click']);
	objectManager.objects.events.add(['click'], event => {
		const objectId = event.get('objectId');
		const data = objectManager.objects.getById(objectId);
		objectManager.objects.options.set({
			balloonContentLayout: makeLayout(ymaps.templateLayoutFactory, data),
		});
		objectManager.objects.balloon.open(objectId);
	});
}, [id, preventSelection]);

Are you going to implement React components support for ymaps.templateLayoutFactory in the future?

@aveselovalova IDK. I just tried some integration about 1.5 years ago. And I was not sure that I was able to handle with possible cases. To my mind this is something that we should to have, but it's maybe something challenging to do.


The DSL parser is not returning a valid object

Method DSLParser.prototype.parse = function()
Doesn't has a return value, also I noticed that the constructor is not calling
AbstractParser.call(this, root, databaseTypes);
When using this parser the entitycreator fails when trying to call
this.parsedData.getClass(classId)
due getClass is not part of the object

I may have broken this parser... I'll try to fix it as soon as I get back to my computer.

I committed a fix for this. I'm not making a release out of it yet, as I want to fix a few remaining bugs before releasing a new version.
Can you check if the problem's solved for you?

yea.. it worked.. no errors this time. good job.


remove extra-requirements from rtd config

🚀 Pull Request
Description

This PR mops up after #5262, and removes the now defunct PyPI docs optional dependencies reference within the .readthedocs.yml.

Consult Iris pull request check list

@tkknight Awesome, thanks :smile:


[Usage] Demo is not working, cannot upload image

Describe the issue
always like this

+1

Same question here.

+1

+1


Prefix - add prefix to action names as well

Prefix - add prefix to action names as well

Extension for #19

This is the naming convention:
action(prefixActionName)

Regex to find:
(.+action()"?([ a-zA-Z0-9._/&-]+)"?)
Replace:
$1action("CWF $2")


Improve output for streamed image progress

Replace lines in-place for each line about a particular SHA
Despite the name of this branch, defer converting the ANSI sequences into colored parts for now,
mainly due to the added complexity. Consider adding this after MVP ships

Signed-off-by: Eric Promislow<EMAIL_ADDRESS>

Rather than adding more text, when the process is done the output textarea gets an unmissable blue border.


image_picker add timestamp to an image

Feature request. Add timestamp text to an image captured via image_picker.

This would be image manipulation which is out of the scope of what image_picker is for

It's right,

A Flutter plugin for iOS and Android for picking images from the image library, and taking new pictures with the camera.
I think it's safe to close the issue. I believe there are other ways to add a timestamp.

It's right,

A Flutter plugin for iOS and Android for picking images from the image library, and taking new pictures with the camera.

I think it's safe to close the issue. I believe there are other ways to add a timestamp.

can you please specify some way to add a timestamp to an image clicked by a camera or drop some relevant links here,it would be really helpful.


feat(test): add download tests

What did not work before?
#27
What have you changed and why?
Added new tests in Download module to increase coverage.
This PR has:

[x] Been doubled checked by the author
[x] Tested for newly introduced bugs
[x] Included documentation

vlw @LucasZatta

Codecov Report

Merging #32 (762d5e6) into main (4e772ed) will increase coverage by 2.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   44.98%   47.64%   +2.65%
==========================================
  Files          14       14
  Lines        1656     1656
==========================================
+ Hits          745      789      +44
+ Misses        867      820      -47
- Partials       44       47       +3

Impacted Files
Coverage Δ

download/download.go
75.00% <0.00%> (+68.75%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e772ed...762d5e6. Read the comment docs.


Sun Energy is int instead of float .

Godot version
4.0.3
System information
windows 10 amdA6 integrated graphics
Issue description
The sun energy value displayed in the Preview Sun window is shown as an integer instead of a float value. This makes it difficult to adjust the sun energy efficiency precisely.
Currently, when i attempt to adjust the sun energy i are only able to do so in whole numbers. This is not ideal, as we often need to make more precise adjustments to get the desired lighting effect.

I would like to look into it if you also thinks its minor bug and can be a good first contribution.
Steps to reproduce
go to the panel in the image.
Minimal reproduction project
N/A

Go ahead! This seems like a good first issue, so if you want to investigate and open a PR, please do!

Fixed by https://github.com/godotengine/godot/pull/76722


Update nats bench

Refactored nats-bench 'bench' functionality into a small library. Changed nats-bench to use bench package
Added 'bench' package to github.com/nats-io/nats/bench
Added support for saving samples in CSV format with the intention of incorporating running of bench as part of the build and save historic performance information
Added tests to bench package

@kozlovic @ColinSullivan1

Coverage remained the same at 94.566% when pulling 205db8d057440a598939da5e07453f2f8e843cd7 on update-nats-bench into d498de06529cce1536449f220f54217a10c319e5 on master.

Coverage remained the same at 94.566% when pulling 139420b979225b2c97e0f4f05997d8d2ede73b7f on update-nats-bench into d498de06529cce1536449f220f54217a10c319e5 on master.


Use latest Exhibitor master

High-level description
This was intended to be the PR that fixed an Exhibitor problem, but it now synchronizes DC/OS master with the current Exhibitor master so that we're starting with latest versions of both.
Corresponding DC/OS tickets (required)
Related tickets (optional)

D2IQ-68109 COPS-6111: Regression: Exhibitor writing JNA files to /tmp again

@mesosphere-mergebot changelog-not-required the changes don't change Exhibitor's behavior, just it's build process.

@mesosphere-mergebot request-review @DominikDary @wavesoft @jkoelker


Add missing test cases for AD and OpenLDAP

@sangeethah @mrajashree Can you please review?

@mrajashree Added missing test cases for OpenLDAP as well, can you review?
@sangeethah ^

LGTM

@galal-hussein , can you also add test cases for "restricted" access mode?
In the current "required" access mode test case , can you add a user that is not in the allowed_identities list but has a member access to one of the environments and make sure he does not access to rancher-server ?
In the "restricted" access mode test case , this same user ( not in the allowed_identities list but has a member access to one of the environments) should be allowed to access rancher-server  and should have access to environment he is member of.

@sangeethah @mrajashree Sure i will add these test cases too

@sangeethah Actually for the point of

In the current "required" access mode test case , can you add a user that is not in the allowed_identities list but has a member access to one of the environments and make sure he does not access to rancher-server ?

There are already environments created for all the users, that's why i added these cases at the end.

@sangeethah I will add cases for the restricted access

LGTM


Simplify by removing unnecessary steps and with sensible defaults

Parity with https://github.com/MicrosoftDocs/azure-docs-pr/pull/215944 and associated sample https://github.com/Azure-Samples/open-liberty-on-aks
Removed, or made optional, unnecessary steps
Added sensible defaults where applicable
Tested
Signed off by @m-reza-rahman and reviewed by @majguo

Learn Build status updates of commit 485d35e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/java/ee/howto-deploy-java-liberty-app-manual.md
:warning:Warning

Details

articles/java/ee/howto-deploy-java-liberty-app-manual.md

Line 38, Column 180: [Warning: file-not-found - See documentation] Invalid file link: '../role-based-access-control/role-assignments-list-portal.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Similar to https://github.com/MicrosoftDocs/azure-docs-pr/pull/215944, this PR should also be moved to https://github.com/MicrosoftDocs/azure-dev-docs-pr because azure-dev-docs-pr is for internal user but azure-dev-docs is for external user.

Pls also fix all warnings detected by Learn Build.

Pls also fix warnings detected by Learn Build.

@majguo - Fixed the warning related to invalid link. Regarding moving the pr to azure-dev-docs-pr, I was looking for this under https://github.com/MicrosoftDocs/azure-docs-pr and couldn't find it, without realizing of the existence of azure-dev-docs-pr. Anyway, will follow the same approach as with azure-docs-pr. Thanks for pointing this out.

Learn Build status updates of commit 1c52537:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/java/ee/howto-deploy-java-liberty-app-manual.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

As @thegovind has already moved the same changes to the PR https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/3811, I'm going to close this one.

#please-close


Fix primary GIE deserialization errors on load model engine

@Sscsmatrix the Primary GIE issues I was having were related to config and model file issues.  Strangely enough, I'm unable to run the combination of

test/config/config_infer_primary_nano.txt
test/models/Prmary_Detector_Nano/resnet10.caffemodel
... results in deserialization errors when loading the engine on Play

However, the combination of

test/config/config_infer_primary.txt
test/models/Prmary_Detector/resnet10.caffemodel_b1_fp16.engine
...seems to work for me...  pretty sure I bought a Nano

I'll try and search the dev.talk when I get a chance, but glad to be finally moving past this issue.
I'm working on the OSD boxing next so we can visually verify.

@rjhowell44 Glad that you found this.  I was trying to get it working on Saturday but I was running into the same problem.  So I started looking at the DeepStream-test1-app to try and figure out what the difference was.  Any way now I can play with your solution!

It turns out that it was a path issue, and I have the Nano configs working now.  The problem is, that if the plugin can't find your model at the path specified, it looks for a default and loads an incompatible engine.  I just did a new pull request that has the basic on-screen-display working.  The simple sample scripts are doing more now... getting to be fun


Fixes resolution of FN003005_CFG_localizedResource_pathLib. Closes #1470

Fixes resolution of FN003005_CFG_localizedResource_pathLib. Closes #1470

Coverage remained the same at 100.0% when pulling b5ddbde71f1b1d81a351c3702b483216644fedb8 on waldekmastykarz:fix-1470 into 5d275be18c9e479582708aa5575c6953d7886fd2 on pnp:dev.

Merged manually


Kubernetes example

Not sure how to size the backups, but here's an example kubernetes setup.
---
apiVersion: v1
kind: Service
metadata:
  name: factorio
  labels:
    app: factorio
spec:
  ports:
  - port: 34197
    name: factorio
    protocol: UDP
  type: LoadBalancer
  selector:
    app: factorio
---
apiVersion: apps/v1beta1
kind: StatefulSet
metadata:
  name: factorio
spec:
  serviceName: "factorio"
  replicas: 1
  selector:
    matchLabels:
      app: factorio
  template:
    metadata:
      labels:
        app: factorio
    spec:
      containers:
      - name: nginx
        image: dtandersen/factorio:0.15.37
        env:
          - name: PORT
            value: "34197"
        ports:
        - containerPort: 34197
          name: web
          protocol: UDP
        volumeMounts:
        - name: saves
          mountPath: /factorio
  volumeClaimTemplates:
  - metadata:
      name: saves
    spec:
      accessModes: [ "ReadWriteOnce" ]
      resources:
        requests:
          storage: 5Gi

If you'd like to add a yaml file for this or update the readme i'll take a pull request for it


Update App Service / websites extension to the latest SDK (6.0.1)

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

route to service team

stale, closing


feat(cli): color graphical commit for "gas log"

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.921%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5292

Relevant Lines:
6382

💛  - Coveralls


Optimize log print.

(cherry picked from commit 11aaf6c)

Coverage increased (+0.1%) to 71.721% when pulling 995ddaffdfad25b12646c4851b03484d47dbd21a on little-cui:master into d585c3a0745a0efaf3634644d9b79b03c71cfd8d on ServiceComb:master.

Codecov Report

Merging #217 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   67.96%   67.99%   +0.02%
==========================================
  Files          17       17
  Lines        3584     3584
==========================================
+ Hits         2436     2437       +1
  Misses        974      974
+ Partials      174      173       -1

Impacted Files
Coverage Δ

server/service/util/dependency.go
50.13% <0%> (ø)
:arrow_up:

server/service/tag.go
74.41% <0%> (+0.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d585c3a...995ddaf. Read the comment docs.

Coverage increased (+0.04%) to 71.661% when pulling e236938f0b32942ddf0e44f18927cb5875fb0c51 on little-cui:master into d585c3a0745a0efaf3634644d9b79b03c71cfd8d on ServiceComb:master.


Status bar text color android

On out of box when creating cordova vue app there black text color on black statusbar.
And may be there is anywhere theme to post sugestions for updates. Such as for example "click" on back button on android navigate router back. Thanks

Use http://framework7.io/docs/statusbar.html#statusbar-app-parameters androidBackgroundColor and androidTextColor statusbar parameters with required values


Change expiration of ttl.sh images

Unavailability of build runners will sometimes cause the ttl.sh images to expire before the integration test has a chance to run them.

Closing as it's already merged as part of #480


An unhandled exception occurred: Maximum call stack size exceeded

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: 7.3.9
Description

I have typescript class with thousands of static property, when running ng build --prod it will throw an Error An unhandled exception occurred: Maximum call stack size exceeded.

update target in tsconfig.json to "target": "es5" -> build success
update buildOptimizer in angular.json to "buildOptimizer": false -> build success

How to make the build succeed when using "buildOptimizer": true and "target": "es2015"?
🔬 Minimal Reproduction

Clone https://github.com/rkusuma/angular-cli839-sample
run ng build --prod

🔥 Exception or Error
An unhandled exception occurred: Maximum call stack size exceeded
See "/private/var/folders/g6/yq3yptmn6w5fr_9k3f_db5fr0000gp/T/ng-ZIr3Yd/angular-errors.log" for further details.
inside angular-errors.log

[error] RangeError: Maximum call stack size exceeded
    at checkExpressionWorker (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53913:39)
    at checkExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53878:38)
    at checkBinaryLikeExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53241:28)
    at checkBinaryExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53229:20)
    at checkExpressionWorker (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53986:28)
    at checkExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53878:38)
    at checkBinaryLikeExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53241:28)
    at checkBinaryExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53229:20)
    at checkExpressionWorker (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53986:28)
    at checkExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53878:38)
    at checkBinaryLikeExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53241:28)
    at checkBinaryExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53229:20)
    at checkExpressionWorker (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53986:28)
    at checkExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53878:38)
    at checkBinaryLikeExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53241:28)
    at checkBinaryExpression (/Users/xxx/GitHub/angular-cli839-sample/node_modules/typescript/lib/typescript.js:53229:20)
🌍 Your Environment

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 8.3.19
Node: 10.16.3
OS: darwin x64
Angular: 8.2.14
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.19
@angular-devkit/build-angular     0.803.19
@angular-devkit/build-optimizer   0.803.19
@angular-devkit/build-webpack     0.803.19
@angular-devkit/core              8.3.19
@angular-devkit/schematics        8.3.19
@angular/cli                      8.3.19
@ngtools/webpack                  8.3.19
@schematics/angular               8.3.19
@schematics/update                0.803.19
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

Anything else relevant?

Yeah this is definitely related with processing https://github.com/rkusuma/angular-cli839-sample/blob/master/src/app/label.constant.ts. We can probably do it in a less stack-intensive way. Thanks for the great report btw!

This should be fixed with Angular CLI 9 and TypeScript 3.6.

This should be fixed with Angular CLI 9 and TypeScript 3.6.
The issue is caused because in version 8, in some cases we used TSC to downlevel the code instead of Babel. However this was fixed in version 9 as we moved completely to Babel.
As a workaround in version 8 you can opt to use the full differential loading feature using;
NG_BUILD_DIFFERENTIAL_FULL=true ng build --prod

Closing as there seems to be a fix merged already.

@filipesilva @alan-agius4 thanks for the reply!
So in v8 the current workaround is using NG_BUILD_DIFFERENTIAL_FULL=true?


[CQLReplicator on Glue] Enable Glue metrics

The metrics are not enabled by default in Glue.
It would be great if it can be enabled when the job is created (i.e. init).

well, I can add it, possible, but Glue/Spark is chatty and it might incur extra CloudWatch costs

probably add it as a flag during init process ?

--enhanced-monitoring-enabled


probe: add route-table probe

this will display the route table info
in the metadata.

run tests

nit: can you change the commit message as it's not really a new probe in the Skydive jargon

rerun selenium-tests

rerun scale-tests

Hi @masco-enovance can you rebase your patch please

@masco-enovance you have to bump to netlink library to have the your patch working properly


[TBDGen][Test] Add expected failure for symbol difference on iOS

It turns out that on iOS builds theres variance on whether OBJC_(META)CLASS symbols get emitted & exported. What's important for TBDGen is that it matches what gets exposed in binaries and that is still upheld on iOS.
resolves: rdar://123811306

When I compiled the object file for the same source that generated the TBD file, the actual symbol set differs. So TBDGen matches that behavior, which is good. But I don't understand why they differ on a platform level, for the sake of time, I haven't investigated whether that is expected.  The other Darwin platforms, according to what I checked on CI, look consistent.
$ nm -gmU client-ios.o | swift-demangle  | rg CLASS
0000000000000310 (__DATA,__data) external [alt entry] _OBJC_CLASS_$_client.extendedAPI.Square
00000000000002e0 (__DATA,__data) external [no dead strip] _OBJC_METACLASS_$_client.extendedAPI.Square

$ nm -gmU client-macos.o | swift-demangle | rg CLASS
00000000000002d0 (__DATA,__data) external [no dead strip] _OBJC_METACLASS_$_client.extendedAPI.Square

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test


declaration of 'MLKTextRecognizedLanguage' must be imported from module 'MLKitTextRecognitionCommon.MLKTextRecognizedLanguage' before it is required

I have this error when i updated my xcode anyone can help ?

Hi everyone. The following PR fixes this issue: https://github.com/brianmtully/flutter_google_ml_vision/pull/37.

I am still having this issue with the latest version 0.0.8 and latest flutter version.


403 issue on tableselection.css

403 on tableselection.css in the admin. Caused by a bug in CKEditor apparently (issue https://github.com/django-ckeditor/django-ckeditor/issues/422). No guidance on how to solve, but just needs the // removed...

Workaround for this was edit ckeditor.js in site-packages/ckeditor/static/ckeditor/ckeditor and do a search for tableselection and then remove the / at the start of the CSS path e.g.
CKEDITOR.document.appendStyleSheet(this.path+"/styles/tableselection.css")
...becomes...
CKEDITOR.document.appendStyleSheet(this.path+"styles/tableselection.css")


Support W3C - no relationship between parentid and spanid

Good afternoon,
In our project we have enabled W3C support for Sleuth. We have done some tests and we are surprised by the way the trace-id field of the traceparent is being generated.
Let's assume we have micro 1 and it receives the header:

traceparent: 00-609a534e112b3e7b920264c8e933aae5-2f644cc2fbb7d434-01

The TraceContext is initialized with the following values:

traceId: 609a534e112b3e7b920264c8e933aae5
spanId: 26e3ebadac5aeecc
parentId: 2f644cc2fbb7d434

Then micro1 invokes micro2 and receives:

traceparent: 00-609a534e112b3e7b920264c8e933aae5-2d179eaf853ae86c-01

The TraceContext associated with micro 2 will be:

traceId: 609a534e112b3e7b920264c8e933aae5
spanId: 9ffb18ac465f1ec1
parentId: 2d179eaf853ae86c

It is observed that during the execution of micro 1, Sleuth generates (for the outgoing request) a completely new parentId, disregarding the current spainId.
Why is the parentId not generated based on the spainId in a similar way as B3 behaves?... because with B3 it is easy to trace the relationship between micro1 and micro2 because the parentId of micro2 is the same as the spainId of micro1, but with the current W3C implementation how can I establish this relationship?
Thank you very much.

I adopted this class https://github.com/spring-cloud/spring-cloud-sleuth/blob/main/spring-cloud-sleuth-brave/src/main/java/org/springframework/cloud/sleuth/brave/bridge/W3CPropagation.java from https://github.com/open-telemetry/opentelemetry-java/blob/main/api/all/src/main/java/io/opentelemetry/api/trace/propagation/W3CTraceContextPropagator.java . I wonder if it has changed in the meantime, cause if it has then I have to adopt the changes too. Before we do a more thorough analysis of the issue. are you willing to do a short analysis of whether there are changes between the two?

Hi Marcin,
First of all, I think we should change the title of the issue to something like 'W3C Support - no relationship between parentid and spanid'.
I have been checking the last couple of months and the only changes they seem to have introduced are related to some validations on the format of traceparent and tracestate and null control so they don't seem to affect the overall behavior.
To try to clarify further, what I expected to receive on micro 2 was a traceparent header with the following value: 00-609a534e112b3e7b920264c8e933aae5-26e3ebadac5aeecc-01
Honestly, I don't know if this is an issue or not, in which case I have to understand that it has been implemented this way for some reason. The specification seems somewhat ambiguous on this point but there are references describing the expected behavior, e.g. -> https://sgryphon.wordpress.com/2020/11/16/a-guide-to-w3c-trace-context/
Thank you very much.

Hi Varania, do you have a small sample that replicates this issue? I don't want to guess what the problem might be (what comes to my mind is that a client span for e.g. a RestTemplate call was made so as a parent id you will not have the HTTP controller span but the RestTemplate one), I'd prefer to work on sth that has a confirmed issue.

Hi, I am getting the same error.
I am using spring-cloud-starter-sleuth : 3.0.3.
My scenario:
Microservice (MS)1 is a producer and sends the message to topic1.
MS2 picks up the message and sends to topic2.
MS3 picks up the message.
Here, MS2's parentID should be MS1's spanID and MS3's parentID should be MS2's spanID.
TraceID are same. spanID and parentID are all different therefore I cannot track the message in sequence.
To capture traceId, spanId and parentId, I am using Sleuth's @Autowired Tracer then tracer.currentSpan().context().traceId(), tracer.currentSpan().context().spanId() and tracer.currentSpan().context().parentId() respectively.
Is this issue fixed or are there any alternatives?

Hi Marcin, I will upload a simple sample this week.

I have uploaded a sample here, https://github.com/sr325/kafka-tracer.
Producer log
2021-10-04 21:02:48.686  INFO [producer,e2868d30510862fa,e2868d30510862fa] 27152 --- [nio-8080-exec-1] o.a.kafka.common.utils.AppInfoParser     : Kafka version: 2.7.1
2021-10-04 21:02:48.693  INFO [producer,e2868d30510862fa,e2868d30510862fa] 27152 --- [nio-8080-exec-1] o.a.kafka.common.utils.AppInfoParser     : Kafka commitId: 61dbce85d0d41457
2021-10-04 21:02:48.694  INFO [producer,e2868d30510862fa,e2868d30510862fa] 27152 --- [nio-8080-exec-1] o.a.kafka.common.utils.AppInfoParser     : Kafka startTimeMs:<PHONE_NUMBER>677
Consumer log
2021-10-04 21:02:50.611  INFO [consumer,e2868d30510862fa,4dd5d0ab97c76699] 5260 --- [ntainer#0-0-C-1] com.demo.consumer_one.KafkaConsumer      : Tracer id is e2868d30510862fa
2021-10-04 21:02:50.612  INFO [consumer,e2868d30510862fa,4dd5d0ab97c76699] 5260 --- [ntainer#0-0-C-1] com.demo.consumer_one.KafkaConsumer      : Span id is 4dd5d0ab97c76699
2021-10-04 21:02:50.612  INFO [consumer,e2868d30510862fa,4dd5d0ab97c76699] 5260 --- [ntainer#0-0-C-1] com.demo.consumer_one.KafkaConsumer      : Parent id is cdb59ff94a162b3c
2021-10-04 21:02:50.612  INFO [consumer,e2868d30510862fa,4dd5d0ab97c76699] 5260 --- [ntainer#0-0-C-1] com.demo.consumer_one.KafkaConsumer      : Consumed message hello world
Use case
In the above log, producer's traceId/SpanId is e2868d30510862fa therefore Consumer's parentId should be e2868d30510862fa  but it is cdb59ff94a162b3c.
I have simply used spring-cloud-sleuth to generate traces and @Autowired Sleuth's tracer to generate traceId, spanId and parentId. Thanks.

So parent 654... is from the poll span that you can see in my message. You're pointing to a span that in my example is the last one. Please check my message again where you have full explanation of all 4 spans.

@marcingrzejszczak : could you please elaborate 'poll' span . Also as you can see w.r.t @sr325  comment, 654c6c202519f923( consumer  parent id) != 3a105242f3aa175d(producer spanId).  Want to understand how 654c6c202519f923 is pointing to span id that in your example is last one.
Your last component has parent Id=98271bd42f0a4c2c which looks fine as it follows up with the listener container span id. But in case of @sr325, consumer parentId(654c6c202519f923) != producer spanId (3a105242f3aa175d).
If possible can you the github link for the change you made.

It's been some time now but I think I remember what the problem was @subhajitgoswami . B3 always having a shared span. That means that you have the same span on the client and on the server side. With W3C the shared span is not allowed. That means that always a new span will be created on the server side. Here we're talking about Kafka but have you observed a similar "problem" with HTTP?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

Hi guys. As @marcingrzejszczak said, W3C does not consider share de spanId. In my opinion, this is a really annoying loophole, because it makes it difficult or even impossible to correlate logs if an APM agent is tracking your service.
The reason is that you don't have access to the context in which the spanId was created, so if you want to generate a correlated log to send to another log analysis platform than your APM, you can't.
And I think this puts at risk one of the reasons why the W3C Trace Context was created: to open up traceability and avoid vendors locking.
What do you think? Is there any way to raise this thought to the owners of the W3C Trace Context specification?


repo: Fedora 41 repositories

Fedora 41 repositories

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit).

I've dismissed the reviews on this PR until the above can be resolved.

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.
The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide
I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

Right, podman-5.0 is included in F40, so the change should be made there as well.
We also had to drop passwd as its provided by shadow-utils in F40+

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.
The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide
I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

Right, podman-5.0 is included in F40, so the change should be made there as well.
We also had to drop passwd as its provided by shadow-utils in F40+

Right, do you or @nullr0ute want to write a PR to drop those packages from the package sets for Fedora >= 40 or shall I do it for you?

It seems there are missing packages in Fedora 41: podman-plugins which is required by a few image types (iot-container, iot-commit) and defined in the iot-commit package set.
The subpackage podman-plugins was removed in this commit for podman 5.0: https://src.fedoraproject.org/rpms/podman/c/2ab1bb3d2d6b3e9df18449494a081fcbe8044d4c?branch=rawhide
I'll tag @paulwhalen and @nullr0ute on this, we can disable podman-plugins conditionally for Fedora > 40 though it seems 5.0 is also in 40 itself?

Right, podman-5.0 is included in F40, so the change should be made there as well.
We also had to drop passwd as its provided by shadow-utils in F40+

Right, do you or @nullr0ute want to write a PR to drop those packages from the package sets for Fedora >= 40 or shall I do it for you?

I can do the PR, sorry the delayed response.

Thank you @paulwhalen.

Rebased now that #480 has landed in main which should turn this PR green.

@ondrejbudai @achilleas-k it seems the CI for the iot-bootable-container is an actual failure but I haven't been able to figure out why yet. Does either of you have an idea?

https://issues.redhat.com/browse/RHEL-29559 is happening in F41 now too.

If we want to bring F41 repos and builds and avoid the issue with rpm-ostree we could temporarily disable the ostree-based image types in F41 only.


relax the CRD certificates availability requirement

Is your feature request related to a problem? Please describe.
Currently, IC won't start if the certificates secrets referenced in the CRD do not exist.
That creates an issue for the authenticate endpoint if an HTTP-01 challenge is required by the cert-manager to acquire the certificate.
Describe the solution you'd like
Skips certs that do not exist, and just do warning in the CRD status / events.
The cert-manager would be able then to use Pomerium to solve HTTP-01 challenge for the authenticate certificate that Pomerium would pick up once available.
Describe alternatives you've considered
Explain any additional use-cases
If there are any use-cases that would help us understand the use/need/value please share them as they can help us decide on acceptance and prioritization.
Additional context
Add any other context or screenshots about the feature request here.

We can approach this with code or with docs.


IDs generated from markdown with numerical headings break

Description
When parsing markdown files which have h1-2 headings that start with numbers (eg. # 1.2 Introduction), the generated IDs throw an error when navigated to from the sidebar (this is forked from the gridsome.org repo).
vue.runtime.esm.js [Vue warn]: Error in nextTick: "SyntaxError: Failed to execute 'querySelector' on 'Document': '#12-introduction' is not a valid selector."

Steps to reproduce
Clicking on the sidebar sub nav items (eg. 4.1, 4.2) will generate the error.

Repo, with more history and description in this issue:
https://github.com/daticahealth/doc-stack/issues/1
Demo: https://datica-docs-stack.netlify.com/

Expected result
The page should jump to the sub-section, and no error generated. More under the hood, the remark plugin should be able to be configured to handle numerical IDs, or a perhaps a custom router in main.js would do the trick. The custom router looked promising as a workaround; I got this to work when I hacked the core router. #356 grapples with a similar problem, where the router needed custom configuration. I think this would work here but I've not gotten it to work yet.
Hacking the core router.js with this worked:
} else if (to.hash) {
  // return { selector: to.hash } // original line
  return { selector: `[id="${to.hash.substring(1)}"]` }
}

It's been said to me, that IDs must not have numbers; my understanding is that HTML 4 was opinionated about IDs not starting with numbers, but HTML5 has very few opinions about IDs (only that they have at least one character, even non-latin ones). I support evergreen browsers, so legacy support isn't an issue. I would think that the case could be made for Gridsome/Vue to support the current standard.
Actual result
The error above results.
Environment

Libs:
- gridsome version: 0.5.2
- @gridsome/cli version: latest

Browser:
- [ ] Chrome (desktop) version 73
- [ ] Firefox version 66.03

For Tooling issues:
- Node version: 11.x, 10.x
- Platform:  macOS High Sierra

Others:

There's a lot of threads I've been following trying to solve this issue. One was to see if Remark had a configuration option; there wasn't one I could see here.
Props also to @tomtev for following up with me on this issue.

Sample markdown and generated HTML:
# 1. Introduction
...
## 1.1 Platform as a Service (PaaS)

renders to

  #
  1.1 Platform as a Service (PaaS)

See the issue above if you're wondering about IDs that start with numbers.

@robaxelsen @tomtev Gents, if this issue is an edge case, and there's a solution with a custom router as I imagine above, would that be a better approach than bothering with the internals or plugins of Gridsome? Would love to know your thoughts. Thanks!

We have this problem at https://gridsome.org too. I think we can fix it either by prefixing the id attribute or the generated slug. GitHub, for instance, adds a user-content- prefix to the ids. The prefix isn't part of the generated slug so it has to be added before scrolling to the element by its id. It's possible to do the same by overriding the default scrollBehavior method in Gridsome. But one problem with this approach is that ids not generated by the Remark transformer won't work (because they don't have the prefix).
Prefixing the slugs which have leading numbers is safer, but results in uglier slugs.
Both alternatives require us to create a custom slugify plugin for the Remark transformer instead of using the remark-slug plugin.

Prefixing the slugs which have leading numbers is safer, but results in uglier slugs.

This seems perfectly reasonable to me. I tend to think about semantics & naming affects the user; if it's a slug that makes sense (because it appears in the URL) and can be set by the developer (say, section-, or chapter-), that would allow an easy fix when the content structure calls for it.

@allanwhite thanks for all the work looking into and reporting this!
How about we make a seperate issue with a feature request based on this suggestion?:

Prefixing the slugs which have leading numbers is safer, but results in uglier slugs.

[@robaxelsen] How about we make a seperate issue with a feature request based on this suggestion?

Whatever works for you, let me know how I can help.

Sure, and thanks!
Hm... Looking deeper into this, perhaps we should keep this issue as is.
@hjvedvik @allanwhite would a solution be to either change the remark-slug plugin to always prefix slugs with leading number, or make it optional via configuration option in the plugin?

@robaxelsen @hjvedvik I would think adding an optional slug prefix (and including it in the docs, so people can remove it if necessary) would be optimal from a user (developer using Gridsome) perspective. This way users could add the prefix for other reasons outside this issue (say, scoping CSS classes).


Feature: allow job-level write-permissions only when job steps are properly hash-pinned

Is your feature request related to a problem? Please describe
Context
The issue #2338 discussed the problem of getting a straight 0/10 on the Token-Permissions check if you have a single job with permissions contents: write or packages: write. It ended up with the implementation of the PR #2355, and now if a job explicitly defines a job-level write permission, it will get a Warning on the logs but won't have a decrease on Token-Permission score.
Problem
Although I agree with the motivations of the discussed problem, I think that having a job-level contents: write or packages: write still brings relevant risks, which should be reflected on the Token-Permission score. I understand that having a job-level write permissions probably means that the maintainer knows the action and explicitly decided to trust in it -- and I also agree this decision should be considered, so I'm not saying we should get to 0/10 --, but the risks still exists and should be considered for whoever wants to evaluate the security of the repository.
E.g., if you use dangerous permissions when calling a GitHub Action without hash-pinning, your repository would be vulnerable on the scenario of a malicious or buggy release -- which could be actually a new released or a change of an existing tag, so even actions pinned as @X.Y.Z aren't immune to attacks.
Describe the solution you'd like
I suggest to keep rewarding repositories that declare write permissions as job-level, but only grant the maximum score if the write permission is declared job-level and all job steps are properly hash-pinned. In this way, we would also ensure the dangerous permissions could not be abused on a malicious release.
Considering the case of write permissions on workflows, I purpose that the score for the Token-Permission check could be decreased according to the following table:

Dangerous permission pattern
Score decreased by occurrence
Motivation

Workflow without any permissions definition or with top-level write permissions
10
Permissions are imposed according to the repository's default permission. If the repository doesn't manually change it, the default set by GitHub will be write-all permissions.

Write permissions for contents, packages or actions given job-level, but without hash-pinning
3*
Permissions may be abused by malicious releases.

Write permissions for contents, packages or actions given job-level, with proper hash-pinning
0

* The value 3 hasn't been discussed and should be reviewed.

Dunno. Hashes just mitigate some issues but if those hashes point to forks thanks to imposter commits they can actually make things worse.

I view this as a GitHub implementation problem, not as a pinning problem. But yes, the result is it can negatively impact projects. When I'm reviewing PRs, I check that the SHA belongs to the intended repo, but it's a burden that not every maintainer will do.

I think that scorecard should decide what it flags.
If the idea is to show whether projects are aware of permissions in general and follow the best practices I think #2338 should suffice.

My view is the check highlights the default github token permissions, and tries to enforce least privilege. At some point the check added logic for "some permissions are more dangerous than others", but we don't have the resources to maintain an allowlist/audit.
I'm curious about @laurentsimon's opinion.

I view this as a GitHub implementation problem, not as a pinning problem

Agreed. Though actions should be pinned in the first place because there is no way to ship actions where consumers could refer to them using meaningful labels that would point to immutable things. Hashes just get around that GitHub shortcoming.

I'm reviewing PRs, I check that the SHA belongs to the intended repo, but it's a burden that not every maintainer will do

Agreed. That's why I think before asking maintainers to pin their actions that part should be automated too (and as far as I understand https://github.com/ossf/scorecard-webapp/pull/389 should kind of address it but Ideally imposter commits should be caught when PRs are opened. Malicious hashes if they are actually malicious should never end up in repositories especially if they use the scorecard action).


debugged process crashes sporadically: 'Error: Cannot switch to old mode now.'

When I run a nodejs process with node-inspector, it works fine for a few minutes with heavyish load but then crashes:
Error: Cannot switch to old mode now.
at emitDataEvents (_stream_readable.js:748:11)
at IncomingMessage.Readable.resume (_stream_readable.js:733:3)
at ClientRequest.handleHttpResponse (/home/vagrant/node_modules/node-inspector/lib/Injections/NetworkAgent.js:299:16)
at ClientRequest.g (events.js:180:16)
at ClientRequest.emit (events.js:117:20)
at HTTPParser.parserOnIncomingClient [as onIncoming] (http.js:1692:21)
at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:121:23)
at CleartextStream.socketOnData [as ondata] (http.js:1587:20)
at CleartextStream.read [as _read] (tls.js:513:12)
at CleartextStream.Readable.read (_stream_readable.js:340:10)
at EncryptedStream.write [as _write] (tls.js:368:25)
at doWrite (_stream_writable.js:225:10)
at writeOrBuffer (_stream_writable.js:215:5)
at EncryptedStream.Writable.write (_stream_writable.js:182:11)
at write (_stream_readable.js:601:24)
at flow (_stream_readable.js:610:7)
at Socket.pipeOnReadable (_stream_readable.js:642:5)
This happens even when there are no active breakpoints. I'm running node-inspector 0.12.3 . Both node-inspector and the debugged process are running nodejs v0.10.32 . It's in Ubuntu.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27057597-debugged-process-crashes-sporadically-error-cannot-switch-to-old-mode-now?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F195817&utm_medium=issues&utm_source=github).

I have the same issue, I wish someone has some clues to the cause.

Should be fixed in 0.12.5
Feel free to reopen this issue if it still exist.


Adapters incorrectly picking up version numbers

The 4 adapters are NOT, via the automated build system, picking up the correct version strings. This applies to both the .nupkg and .snupkg files.
For example, in this nightly build, you can see:
Microsoft.Bot.Builder.Adapters.Facebook.1.0.0.nupkg
Microsoft.Bot.Builder.Adapters.Slack.1.0.0.nupkg
Microsoft.Bot.Builder.Adapters.Twilio.1.0.0.nupkg
Microsoft.Bot.Builder.Adapters.Webex.1.0.0.nupkg

I don't see an obvious problem, but these are the only 4 packages that are having this problem. The issues is probably in the .csproj file, but something isn't flowing through correctly.
The correct build should look like this:
Microsoft.Bot.Builder.4.10.0-daily.20200707.144229.nupkg

I've looked at this for a little while now, and still don't see the issue. @garypretty let's sync tomorrow and see if we can figure this one out.

@tomlm was able to spot the problem. PR incoming.


Add Map.count

As requested by https://fslang.uservoice.com/forums/245727-f-language/suggestions/12880398-add-map-count

Hi @robertpi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

@robertpi  you have run in to the Surface area verification test, you added a new API to fsharp.core.dll and so you need to update the list of APIs for the Surface area tests : FSharp.Core.Unittests.SurfaceArea.SurfaceAreaTest.VerifyArea
Just add this line:0
Microsoft.FSharp.Collections.MapModule: Microsoft.FSharp.Collections.MapModule: Int32 Count[TKey,T](Microsoft.FSharp.Collections.FSharpMap`2[TKey,T])

between these two:
Microsoft.FSharp.Collections.MapModule: Boolean IsEmpty[TKey,T](Microsoft.FSharp.Collections.FSharpMap`2[TKey,T])
Microsoft.FSharp.Collections.MapModule: Int32 GetHashCode()

In:
   src\fsharp\FSharp.Core.Unittests\SurfaceArea.net40.fs
   src\fsharp\FSharp.Core.Unittests\SurfaceArea.portable7.fs
   src\fsharp\FSharp.Core.Unittests\SurfaceArea.portable47.fs
   src\fsharp\FSharp.Core.Unittests\SurfaceArea.portable78.fs
   src\fsharp\FSharp.Core.Unittests\SurfaceArea.portable259.fs

Thanks
Kevin

See RFC here: https://github.com/fsharp/FSharpLangDesign/blob/master/RFCs/FS-1010-add-map-count.md
Robert - please the take time to fill in the RFC and if necessary have a discussion on this.  For example, people may want to discuss whether other functions should be added at the same time in an overall update to the Map module.

@dsyme @robertpi  so ... this PR looks good to me, let me know if you want to do more work on it.

@robertpi @dsyme Please provide an RFC to allow us to examine the context for this PR ... the code looks good, it looks like something we would want to take.  But we want to examine how it fits.
Don has provided a template here:
https://github.com/fsharp/FSharpLangDesign/blob/master/RFCs/FS-1010-add-map-count.md

Just to add - I think we're petty much going to require RFCs for API and language additions from now on.  RFCs allow us to:

track what changes have happened, when, why and with exact links to the PRs and history
discuss the changes from a design point-of-view.  For example, is the design change complete? consistent?
gives a future reference point that people can find to understand the change.

Thanks and apologies, I thought I filled in the in RFC, but can find no
evidence of this.
Thanks,
Rob
On Mon, Apr 18, 2016, at 09:33 PM, Kevin Ransom (msft) wrote:

Merged #1007[1].
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub[2]

Links:

https://github.com/Microsoft/visualfsharp/pull/1007
https://github.com/Microsoft/visualfsharp/pull/1007#event-631842801


Github Actions enhancements

Pull Request Test Coverage Report for Build 298520915

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.4%) to 81.347%

Files with Coverage Reduction
New Missed Lines
%

goalc/compiler/IR.cpp
1
94.76%

Totals

Change from base Build 298512192:
1.4%

Covered Lines:
14557

Relevant Lines:
17895

💛  - Coveralls


testing: add mock_opae class

mock_opae_p class is a templated class that derives from TestWithParam
and is meant to be a mock class for mock platforms.
The template argument is used to specify how many tokens to use
(if any).
This class implements the SetUp/TearDown that google test uses in the fixture
but also defines test_setup/test_teardown functions that can be overridden by
a sub-class.
This is a first step in refactoring tests to avoid code cloning.

Coverage remained the same at 80.896% when pulling 24d29e37e64b14350e7aa3e937ca57e424ee5247 on rrojo/mock_gtest_class into ae2777931b6a2f574234f65403ded9bcc1653144 on master.


Metrics arguments to runs view subcommand do not change output

Adding any of the metrics command to the runs view command do not append any new metrics:
$ tw -o json runs view --id 5CTeD42c9cFCRo \
  | md5sum-lite
eb9a64c5557ee2894a363444c435c175 -

$ tw -o json runs view --id 5CTeD42c9cFCRo \
  --metrics-memory \
  --metrics-cpu \
  --metrics-time \
  --metrics-io \
  | md5sum-lite
eb9a64c5557ee2894a363444c435c175  -

The cli indicates that these metrics args are to be applied at the "tw runs view" level (as shown above), but perhaps they are supposed to be applied at the "metrics" subcommand. If so, we have the same problem:
$ tw -o json runs view --id 5CTeD42c9cFCRo metrics | jq '. | keys[]'
"metricsCpu"
"metricsIo"
"metricsMemory"
"metricsTime"

tw -o json runs view --id 5CTeD42c9cFCRo --metrics-cpu metrics | jq '. | keys[]'
"metricsCpu"
"metricsIo"
"metricsMemory"
"metricsTime"

I'm unsure why these --metrics-... were added; they're never used.
Maybe what you are looking for is the --type option in metrics subcommand:
-t, --type=<type>[,<type>...]            Process metric types separated by comma: cpu, mem, time, io [default: displays all].

Example:
$ tw runs view --id 2m2ZyQ076oUNL0 metrics --type mem
...


Anti affinity Groups not work  sometimes ,  Start VM in batches

ISSUE TYPE

Bug Report

COMPONENT NAME

affinity Groups

CLOUDSTACK VERSION

CloudStack <IP_ADDRESS>

CONFIGURATION

OS / ENVIRONMENT

CloudStack <IP_ADDRESS>
host  OS version: Ubuntu 20.04
SUMMARY

Start virtual machines in batches, anti affinity Groups not work sometimes
STEPS TO REPRODUCE

It doesn't happen every time
1.Two host in one cluster
2.add three VM to a anti-affinity group
3.VM in stopped state
4.start vm with WEB UI, Check three VM to start
5.Three VMs will start successful
logs ：
vm id : 158 159 160
host id:  3 9
job-5595:
2021-09-29 09:35:14,379 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-31:ctx-ff549a9e job-5595 ctx-e1872415) (logid:ec8a48c2) Processing affinity group gumd-test for VM Id: 158
2021-09-29 09:35:14,382 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-31:ctx-ff549a9e job-5595 ctx-e1872415) (logid:ec8a48c2) Added host 3 to avoid set, since VM 159 is present on the host, in Stopped state but has reserved capacity
2021-09-29 09:35:14,383 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-31:ctx-ff549a9e job-5595 ctx-e1872415) (logid:ec8a48c2) Added host 9 to avoid set, since VM 160 is present on the host, in Stopped state but has reserved capacity
job-5598
2021-09-29 09:35:14,594 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-32:ctx-acdc74f8 job-5598 ctx-3ce8dd3b) (logid:1d2445d0) Processing affinity group gumd-test for VM Id: 159
2021-09-29 09:35:14,597 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-32:ctx-acdc74f8 job-5598 ctx-3ce8dd3b) (logid:1d2445d0) Added host 9 to avoid set, since VM 158 is present on the host, in Stopped state but has reserved capacity
2021-09-29 09:35:14,600 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-32:ctx-acdc74f8 job-5598 ctx-3ce8dd3b) (logid:1d2445d0) Added host 9 to avoid set, since VM 160 is present on the host, in Stopped state but has reserved capacity
job-5592
2021-09-29 09:35:14,498 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-30:ctx-307add2b job-5592 ctx-0802d14f) (logid:c430fdd5) Processing affinity group gumd-test for VM Id: 160
2021-09-29 09:35:14,500 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-30:ctx-307add2b job-5592 ctx-0802d14f) (logid:c430fdd5) Added host 9 to avoid set, since VM 158 is present on the host, in Stopped state but has reserved capacity
2021-09-29 09:35:14,502 DEBUG [o.a.c.a.HostAntiAffinityProcessor] (API-Job-Executor-30:ctx-307add2b job-5592 ctx-0802d14f) (logid:c430fdd5) Added host 3 to avoid set, since VM 159 is present on the host, in Stopped state but has reserved capacity

EXPECTED RESULTS

Two VMs start success , one VM start failed

ACTUAL RESULTS

Three VMs start success

cc @nvazquez

Hi @havengit I have tried some scenarios on KVM with a cluster of 2 hosts:
Case 1: SUCCESS
Deploy VM1 - select host anti-affinity -> VM running on host 1
Deploy VM2 - select host anti-affinity -> VM running on host 2
Deploy VM3 - select host anti-affinity -> ERROR

Case 2: ERROR
Deploy 3 VMs without selecting any affinity group -> VMs distributed across the 2 hosts
Stop 3 VMs
Add VMs to anti affinity group
Start 3 VMs at the same time -> 3 VMs running (even starting them one by one)
Will work on it

@Pearl1594 @davidjumani @weizhouapache @rohityadavcloud @DaanHoogland @andrijapanicsb this will a proper definition, VM deployments are always failing considering the anti-affinity groups, however if the VMs are stopped/started belonging to the anti-affinity group it is possible to have VMs running on the same host as this issue describes (anti affinity for 3 VMs with 2 hosts). Should stop/start also fail if the anti-affinity rules are not met? Looking forward to hearing your input

I think anti affinity groups need to have more attributes. A strict anti-affinity might require cluster spreading or even pod spreading for a VM. In those cases a VM should not be started at all if any VM in the group is already running on each host/cluster/pod. If the anti-affinity is not strict one might argue for instance, "no third VM may be started if any resource (host/cluster/pod) doesn't host two VMs from the group yet".
of course there are monsters hiding in all details for this.

@Pearl1594 @davidjumani @weizhouapache @rohityadavcloud @DaanHoogland @andrijapanicsb this will a proper definition, VM deployments are always failing considering the anti-affinity groups, however if the VMs are stopped/started belonging to the anti-affinity group it is possible to have VMs running on the same host as this issue describes (anti affinity for 3 VMs with 2 hosts). Should stop/start also fail if the anti-affinity rules are not met? Looking forward to hearing your input

I think anti affinity groups need to have more attributes. A strict anti-affinity might require cluster spreading or even pod spreading for a VM. In those cases a VM should not be started at all if any VM in the group is already running on each host/cluster/pod. If the anti-affinity is not strict one might argue for instance, "no third VM may be started if any resource (host/cluster/pod) doesn't host two VMs from the group yet".

@DaanHoogland
this is how it works  in cloudstack for now.
VMs with same host anti-affinity can not be deployed to the same host. It leads to an issue that user cannot deploy VMs if there are not enough hosts.
we could rename the current "host anti-affinity" to "Strict host anti-affinity" , and create a type like "Loose anti-host affinity". The new type works like guest os preference. VMs are preferably allocated to different hosts, but if there are not enough hosts, VMs can be deployed to same host as other vm with same affinity group.
anyway, it is not the root cause of this issue I believe.

of course there are monsters hiding in all details for this.

@Pearl1594 @davidjumani @weizhouapache @rohityadavcloud @DaanHoogland @andrijapanicsb this will a proper definition, VM deployments are always failing considering the anti-affinity groups, however if the VMs are stopped/started belonging to the anti-affinity group it is possible to have VMs running on the same host as this issue describes (anti affinity for 3 VMs with 2 hosts). Should stop/start also fail if the anti-affinity rules are not met? Looking forward to hearing your input

Hi @havengit I have tried some scenarios on KVM with a cluster of 2 hosts:
Case 1: SUCCESS Deploy VM1 - select host anti-affinity -> VM running on host 1 Deploy VM2 - select host anti-affinity -> VM running on host 2 Deploy VM3 - select host anti-affinity -> ERROR
Case 2: ERROR Deploy 3 VMs without selecting any affinity group -> VMs distributed across the 2 hosts Stop 3 VMs Add VMs to anti affinity group Start 3 VMs at the same time -> 3 VMs running (even starting them one by one)
Will work on it

@nvazquez
I suspect, the root cause of this issue is, affinity group is not checked when start a vm with last host id.
I have fixed a similar issue with guest os preference in #4338,
unfortunately it seems to be broken by #3600 which reverted the change cc @GabrielBrascher .
I have created a PR to fix it #6000
we need more logs to confirm it.  if so, we need to add check for affinity group in checkVmProfileAndHost method.

Thanks @weizhouapache checking it

@weizhouapache I tested the fix but still getting all the 3 VMs running even though they belong to an anti-affinity group. Attaching the logs antiaffinity.log

@weizhouapache I tested the fix but still getting all the 3 VMs running even though they belong to an anti-affinity group. Attaching the logs antiaffinity.log

@nvazquez
I had a quick check on logs, it seems affinity group check has been processed in DeploymentPlanningManagerImpl, so my suspicion is not correct.
I think the issue is because 3 vms are started in parallel.
the original vm state:
(job_107) VM 1: Stopped, host_id: NULL, last host_id: 2
(job_108) VM 2: Stopped, host_id: NULL, last host_id: 2
(job_109) VM 3: Stopped, host_id: NULL, last host_id: 1
after first try:
(job_107) VM 1: Starting, host_id: NULL, last host_id: 2
(job_108) VM 2: Starting, host_id: NULL, last host_id: 2
(job_109) VM 3: Starting, host_id: 1, last host_id: 1
after second try:
(job_107) VM 1: Starting, host_id: 2, last host_id: 2
(job_108) VM 2: Starting, host_id: 2, last host_id: 2
(job_109) VM 3: Starting, host_id: 1, last host_id: 1
After first try,  VM 1 and VM2 are Starting state and do not have host_id. in second try, affinity group does not work well. see code below
https://github.com/apache/cloudstack/blob/478e24493e2c44d922d898cbeb11db4cabec826a/plugins/affinity-group-processors/host-anti-affinity/src/main/java/org/apache/cloudstack/affinity/HostAntiAffinityProcessor.java#L82-L98
(groupVM.getHostId() is NULL and groupVM.getState() is Stopped for both VM 1 and VM 2.)
If VM is started when other vms are Running or Stopped, it should work as expected.


Failed migration: how to handle existing user db

I have already built up an app around devise authentication, and nothing I've tried will get vanilla Devise to work with implementing AJAX logins the way I want them.
So I installed devise_token_auth and ran the generator. The db:migrate command won't run after that because there's already a users db from installing Devise the first time. And my app won't run because of pending migrations.
Can I just delete the migration that was created and use the existing Devise users db? Or will I need to roll back the db schema to a pre-Devise state and start over?

@MatthewMDavis, you can get this to work by "massaging" the migration that gets generated by the devise_token_auth install command.
Most of the fields in the migration were already created by your original devise install. As an example this is what my migration ended up being (which ran cleanly):
class DeviseTokenAuthCreateUsers < ActiveRecord::Migration
  def change
    change_table(:users) do |t|

      # NOTE: The provider `email` really just refers to
      # a standard devise user authentication. I use username
      # but devise_token_auth only looks for users with provider
      # `email` when signing in (even if Devise is set to use
      # something else like username)
      #
      ## Required
      t.string :provider, :null => false, :default => "email"
      t.string :uid, :null => false, :default => ""

      ## Tokens
      t.json :tokens
    end

    add_index :users, [:uid, :provider],     :unique => true
  end
end

The key thing was to change create_table to be change_table so the migration modifies the existing table. The only columns I then needed to add were :provider, :uid, and :tokens, (though your needs may be slightly different). A thoughtful comparison of your original devise users migration and the one created by devise_token_auth should make it clear to you which parts you need and which parts you don't. Good luck!

I'm getting this error when running my Devise Token Auth migration, which looks exactly like yours @campo
"UniqueViolation: ERROR:  could not create unique index "index_users_on_uid_and_provider"
DETAIL:  Key (uid, provider)=(, email) is duplicated."

@edwinramirez I just split up the migration into these three migrations:

Create the new columns
class DeviseTokenAuthCreateUsers < ActiveRecord::Migration[5.0] def change  add_column :users, :provider, :string, :null => false, :default => "email"  add_column :users, :uid, :string, :null => false, :default => ""  add_column :users, :tokens, :text end end

Copy the email field to the uid field
`class SetUidForUsers < ActiveRecord::Migration[5.0]
def self.up
User.update_all("uid=email")
end

def self.down
end
end
`

Add the index
class CreateAuthIndex < ActiveRecord::Migration[5.0] def change  add_index :users, [:uid, :provider],     unique: true end end

@edwinramirez The reason you get this error is because the index that gets added is based on the uid and the provider for each row and is unique: true. If you happen to have two rows that have the same uid and the same provider, the unique constraint on that index causes it to fail.
The "real" way to fix the problem would be to eliminate the situation where both the uid and provider would be the same for multiple rows. That could mean preventing it from happening in the first place, or by making a well-reasoned decision about how to change the values for the affected rows in your particular situation.

If you have a database with multiple existing users, the migration will always fail.
The two new columns have default values "email" and "". In that case there will always be duplicate values ("email, "") for the unique index.
The second migration above is an example of how you could fix that (by generating a unique uid (assuming that email is unique for existing users in your database).

Sounds like we have a proposed solution, so closing this for now.


(PDB-1941) Grab db credential variables directly from testutils

This commit changes the unit tests in PuppetDB to grab their database
credentials from the environment directly rather than through a memoized
function loaded from a Clojure file on the classpath under a config
directory (i.e. we're stopping ourselves from doing some silly things).
Relates to https://github.com/puppetlabs/pe-puppetdb-extensions/pull/94.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1864/

transients ^

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1869/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1871/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1873/

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1874/

@ajroetker some comments, a perhaps real problem, some name pickiness, and some confusion over legacy code. The usual, really.

:+1: from me after the memoize issue gets addressed

@mullr think I addressed your memoization issues if you wanna take another look

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1878/

@pljenkinsro retest this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1880/

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1879/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1881/

@ajroetker hypersql tests on travis are failing, out of memory, the PR tests are the git issues we've been having

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1884/

@pljenkinsro retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1885/

looks good to me


app-service should run with mqtt-export, functional or http-export for TAF ?

Hi @cloudxxx8 , @cherrycl ,
In order to test app-service, can we run the service with any of these 3 : functional-tests (56705), http-export (56704), mqtt-export (56703) ?
If yes, then what are the configurations we need to modify in order to use any of these ports ?
Please suggest if possible ? Thanks in advance.

I am not sure what tests you are talking about.  Where did you get the number?  I don't understand your question.

@cloudxxx8  In global_variables.py file, these port numbers are defined, so, in case I am running app-service through mqtt or http, do I need to do any changes in robot files for that ?

you can try

Close this issue due to no activity. If you have further question, please file questions on Github Discussions (https://github.com/orgs/edgexfoundry/discussions). Thank you.


What should I do if there are ups and drop refresh ui  in viewpager?

Some requirements are like this, viewpgaer has a head viewpgaer, and the recyclerview inside can be pulled up to load more drop up refresh

Good to know ;) What is the issue here?


Error occurred while RSpec/OverwritingSetup cop was inspecting

Hi 😄
I don't know if you are aware of this, I'm posting it just in case you don't.
If you have a let declaration in a spec containing an extra space like this:
let (:user) { create(:user) }

Your tests will pass, but rubocop will raise an exception like this:
Scanning /Users/microweb10/rubocop_test/spec/models/user_spec.rb
An error occurred while RSpec/OverwritingSetup cop was inspecting /Users/microweb10/rubocop_test/spec/models/user_spec.rb:3:0.
undefined method `value' for "s(:begin,\n  s(:sym, :author))":RuboCop::AST::Node
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-rspec-1.26.0/lib/rubocop/cop/rspec/overwriting_setup.rb:51:in `block in find_duplicates'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/node.rb:185:in `block in each_child_node'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/node.rb:183:in `each'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/node.rb:183:in `each_child_node'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-rspec-1.26.0/lib/rubocop/cop/rspec/overwriting_setup.rb:47:in `find_duplicates'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-rspec-1.26.0/lib/rubocop/cop/rspec/overwriting_setup.rb:34:in `on_block'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:44:in `block (2 levels) in on_block'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:109:in `with_cop_error_handling'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:43:in `block in on_block'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:42:in `each'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:42:in `on_block'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/traversal.rb:49:in `block in on_begin'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/traversal.rb:49:in `each'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/traversal.rb:49:in `on_begin'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:48:in `on_begin'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/ast/traversal.rb:12:in `walk'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/commissioner.rb:60:in `investigate'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/team.rb:114:in `investigate'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/team.rb:102:in `offenses'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cop/team.rb:44:in `inspect_file'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:259:in `inspect_file'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:206:in `block in do_inspection_loop'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:238:in `block in iterate_until_no_changes'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:231:in `loop'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:231:in `iterate_until_no_changes'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:202:in `do_inspection_loop'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:111:in `block in file_offenses'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:121:in `file_offense_cache'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:109:in `file_offenses'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:100:in `process_file'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:78:in `block in each_inspected_file'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `reduce'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:75:in `each_inspected_file'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:67:in `inspect_files'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/runner.rb:39:in `run'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:156:in `execute_runner'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:84:in `execute_runners'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:41:in `run'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/bin/rubocop:13:in `block in <top (required)>'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/2.3.0/benchmark.rb:308:in `realtime'
/Users/microweb10/.rbenv/versions/2.3.2/lib/ruby/gems/2.3.0/gems/rubocop-0.54.0/bin/rubocop:12:in `<top (required)>'
/Users/microweb10/.rbenv/versions/2.3.2/bin/rubocop:22:in `load'
/Users/microweb10/.rbenv/versions/2.3.2/bin/rubocop:22:in `<main>'
.

1 file inspected, no offenses detected

rubocop (0.54.0)
rubocop-rspec (1.26.0)
rspec-core (3.8.0)

Hi @microweb10. I'm was unable to reproduce this on the current version of rubocop-rspec. Could you try the latest version and see if you still get the error and/or provide a reproduction test file? Thanks!
I seem to recall a fix going out for this at some point, but I can't seem to find the issue/PR at the moment if it does, in fact, exist.

Hi @dgollahon!
Thanks for the update ☺
You are right! 🎉
My apologies for the inconvenience. 🙏
Closing issue. 😃

No worries, glad it works as expected for you.


How to disconnect user if internet connection is not available

Hi.
How can i disconnect user if the internet connection change to none?
socket.close();
socket = null;
works manually and CLI logs Client disconnected
but when those codes called in offline event it doesn't logs any in CLI
Thank you

I still cant trace the code called when the connection lost(sudden internet loss, changes of network connection)

If a person is disconnected due to a network issue, the abstract function Websockets::closed will be run by Websockets::disconnect.
You are required to implement the closed() method.  You are invited to override the disconnect() method if you need to know the particular reason why a given connection is closed.
And I am embarassed that I set it up this way originally.

It seems like the Websockets::disconnect does not called when a person is diconnected due to network issue, im running this using php 7 codeigniter framework and ubutu server, to recreate the network issue, i did disable my Ethernet adopter in network settings

what was the error that you got? in the server

There is no any logs in server CLI nor any error  at the time i disconnect/disabled  my network

Here's the screen shot of server cli logs
https://ibb.co/mzwHyU
the the screen shot of browser in mobile after i turned off my wifi
https://ibb.co/b6MjdU
it says disconnected - status 3 but the server does not recognized it
please help me thank you

https://ibb.co/c2oZDU
so basically i just tried the raw server(i changed it alot for my needs before and i didnt work on it since two years ago) and it notices it as i said before and you can change the function to do whatever you want when disconnected

i dont understand how you didnt notice the function its so direct they called it disconnect and you will see that the client get disconnected and deleted from users list in it as well(as i said before)

Yes disconnected works perfectly to me on close of browser/ browser's tab but while im connected then turn of my wifi disconnect function does not called i dont know why disconnect does not call when wifi is off, just like how disconnect call when browser/tab is closed

I can explain what happens.
1- When you use "quit", you close normaly the websocket connection.
2- When you close the browser, you close abruptly the websocket connection.
3- When you unplug ethernet cable ( or wifi connection ), the websocket stay open.
It's the force of TCP if you plug back ( or reconnect wifi ) quick enought and have the same IP. The data will flow back on the last thing you receive.
So after some unresponse from client ( no ACK ) or the timeout on TCP occur the connection will be terminated.

Thank you very much @Xaraknid , @ghedipunk , @youssefali424
for your help
Question:
It is safe to do that the client send ping to server every sec. to log the last time activity of user then in server checking all connected user last time activity if > 5sec user will be disconnected?

All depend what you need.
You should use server side to send PING, all official current browser send Automaticaly the PONG.
Keep in consideration lag spike, loss packet, bandwidth, stress time, ect. Data is send/receive sequentially that mean if you send a huge message that take time your PING will be received after that.
So 5 sec you have a fair chance to disconnect a valid connection.
I suggest you let the OS deal mostly with that. Sure a Ping/Pong exchange is just 4 bytes but it add up quickly for something that should happens rarely. With 100 clients you ping every 5 secs you'll end up with 288 Kbytes/hour that didn't count the CPU usage to fill and unfill the list.
You should check every X (higher than TIMEOUT) minutes that will not stress unecessary the server.  Also make sure to remove from the list the disconnected that happens between every check.

Any idea how to do this server side ping and how server manage the pong of client ?

the easy way send a specific message(num or word.....etc) then the client should replay if the ack didnt come then he is disconnected for sure you have to implement it in client and server side(make a timer to know idle users like if there is no traffic or data sent to server send the ack )

or you can depend on the browser for the bong like check the browser response as Xaraknid said but you need to know how the browser respond

Thank you very much guys


[FEATURE] Use custom security groups for Docker Host

Is your feature request related to a problem? Please describe.
Some orginizations require specific restrictions on their ingress and egress rules. Currently CLI extension does not allow that.
Describe the solution you'd like
Having an option in the configuration file to provide a list of security group ids
Describe alternatives you've considered
No other alternative available

Implemented


Build with rollup instead of tsdx

We currently build this repo in prep for both our CDN publish step (umd build) and our npm publish (cjs / esm build) with TSDX.
Chang flagged earlier that we might want to move off of TSDX, and I wanted to play with our builds to get a code split react export working anyways, so this seemed like a good time.
The code is commented and I tested it via import { X } from '@apollo/explorer' and const { X } = require('@apollo/explorer'), but I think we'd want to ship this along with https://github.com/apollographql/embeddable-explorer/pull/125/files in a new major version? I would like to publish an alpha and make sure everything looks gucci.
Historical Context
Hello! Welcome to the embeddable-explorer repo. Please take a look at the README.
Some context that would be helpful to know for reviewing in this repo:

We have 2 ways that we export the code that is build in this repo. We publish a umd file embeddable-explorer.umd.production.min.js to this bucket on merge. This file is used by folks who select the CDN option in the Embed Explorer modal like so:

We also have an npm package @apollo/explorer that is managed by Changesets. This npm package uses the build command, which creates an esm & cjs build. The CJS build have a production & development version which is decided via index.cjs which, in this PR, is created by writeCJSEntryFile.js.
I am pretty sure that the publish-changeset npm script is our publish script, but I want to publish an alpha to be sure.
Notes:

The source maps have no info in them. How much do we care about source maps b/c we aren't adding the .ts files to our build? I am confused how they would be useful without the og ts files in our dist folder

TODO: add babel

TODO: upgrade typescript to v4 and remove MessageEvent comment

@Jephuff I added a babel plugin to rollup, since tsdx had one before 🤷