[AIRFLOW-XXX] Don't spam test logs with "bad cron expression" messages

Make sure you have checked all steps below.
Jira

[x] https://issues.apache.org/jira/browse/AIRFLOW-XXX

Description
We needed these test dags to check the behaviour of invalid cron
expressions, but by default we were loading them every time we create a
DagBag (which many, many tests to).
Instead we ignore these known-bad dags by default, and the test checking
those (tests/models.py:DagBagTest.test_process_file_cron_validity_check)
is already explicitly processing those DAGs directly, so it remains
tested.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason: Just makes test output a tiny bit easier to read

Commits

[x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

You will need to update test_list_py_file_paths test as well
======================================================================
5) FAIL: test_list_py_file_paths (tests.SchedulerJobTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/jobs.py line 3297 in test_list_py_file_paths
      self.assertEqual(sorted(detected_files), sorted(expected_files))
   AssertionError: Lists differ: [u'/app/tests/dags/test_backfi... != [u'/app/tests/dags/test_backfi...

   First differing element 8:
   u'/app/tests/dags/test_issue_1225.py'
   u'/app/tests/dags/test_invalid_cron.py'

   Second list contains 2 additional elements.
   First extra element 17:
   u'/app/tests/dags/test_zip.zip'

   Diff is 1007 characters long. Set self.maxDiff to None to see it.

D'oh, thanks. I looked for _invalid_ but that string doesn't appear in the failing test

Codecov Report

Merging #3973 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3973      +/-   ##
==========================================
+ Coverage   75.05%   75.09%   +0.03%
==========================================
  Files         199      199
  Lines       15965    15965
==========================================
+ Hits        11983    11989       +6
+ Misses       3982     3976       -6

Impacted Files
Coverage Δ

airflow/jobs.py
82.39% <0%> (+0.26%)
:arrow_up:

airflow/utils/dag_processing.py
90.35% <0%> (+1.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9c9b5...82ad279. Read the comment docs.

As a bonus this now also tests .airflowignore a bit :D


Possible to use with a switch rather than button

I'm currently using this with a switch rather than a button. I have the switch connected between BCM 3 and ground; if the pi is in a low power state the switch shorting to ground will start the pi, when running (switch is on,) the gpio is pulled low, so when the switch is turned off the pin goes high due to internal pull-up. I have changed in listen-for-shutdown.py:
GPIO.wait_for_edge(3, GPIO.FALLING)
to
GPIO.wait_for_edge(3, GPIO.RISING)
which works great for turning pi on and off. The only issue I have is the pi will boot and stay on with the switch in the off position when power is applied. A quick boot and shutdown is acceptable with the switch in the off position. I was thinking to do a one time check on the pin after the internal pull-up is initialized and perform a shutdown if it is already hi, not 100% sure how to go about this in the cleanest way. Any suggestions.

Sorry for the major delay here, but this is a really neat idea. I'm going to close this issue, but I'll think about ways to make this optionally work for a switch.


When to release the diffusers version？

Hello, can you give a version to run with code？

@Jonseed         sigma_float = float(sigma.max().detach().cpu())
if end_sigma <= sigma_float <= start_sigma:
sigma = sigma * (1.0 + lss_dishonesty_factor)

@NicholasCao I don't know. I don't know much about diffusers. Do you know @blepping ?

I don't know Diffusers either but it looks like that code is just changing the schedule. To get the Detail Daemon effect you'd need to sample with one set of sigmas and pass the model an adjusted value. I don't know how you'd do that with Diffuses though.

Actually, I looked at the Diffusers code you linked. I think it would be the first one (the model's input parameters). If you did something like:
  timestep=(timestep / 1000) * (1.0 + lss_dishonesty_factor),

that might work. If that's actually timesteps they'd be 0 at the start of sampling and 1000 at the end. If you wanted, you could add logic to only do the adjustment when the timestep was in a certain range.
You'd have to figure out a way to plumb the extra parameters to where they're needed or just hardcode them I guess.

Actually, I looked at the Diffusers code you linked. I think it would be the first one (the model's input parameters). If you did something like:
  timestep=(timestep / 1000) * (1.0 + lss_dishonesty_factor),

that might work. If that's actually timesteps they'd be 0 at the start of sampling and 1000 at the end. If you wanted, you could add logic to only do the adjustment when the timestep was in a certain range.
You'd have to figure out a way to plumb the extra parameters to where they're needed or just hardcode them I guess.

thank you！here is a solution https://github.com/huggingface/diffusers/issues/10112


2d kde plots can be much wider than actual distribution / samples (over-smoothing?)

Describe the bug
The contours from plot_2d are very large / over-smoothed if the PDF is very peaked/asymmetric (see example below). Not sure if this is a bug, I guess it would rather be a scipy bug, but should we do something about it?
To Reproduce
I uploaded some example data where the problem occurs, the data files are currently available at http://www.ast.cam.ac.uk/~sh2061/xdata.npy etc.
x = np.load("xdata.npy")
y = np.load("ydata.npy")
samples = anesthetic.MCMCSamples(np.array([x,y]).T, columns=['x','y'])
samples.limits={}
fig, axes = samples.plot_2d(['x','y'], types={"lower": "kde"})
samples.plot_2d(axes, types={"lower": "scatter"}, ncompress=2000)

These samples are sampled from a flat prior in model parameter, but the points show some derived parameters.
For these derived parameters (usually samples['x']=function(samples) the limits are not set by default. In many "less rectangular" cases limits don't help though, like this one:
    x = np.load("xdata2.npy")
    y = np.load("ydata2.npy")
    samples = anesthetic.MCMCSamples(np.array([x,y]).T, columns=['x','y'])
    #samples.limits={}
    fig, axes = samples.plot_2d(['x','y'], types={"lower": "kde"})
    samples.plot_2d(axes, types={"lower": "scatter"}, ncompress=2000)

Expected behavior
A cutoff where the data is cut off, or close to it. Especially at the bottom 95 close to 68% contour lines. This can only be partially fixed with setting the limits dictionary.
I see that those samples have a rather difficult distribution. If this cannot be fixed, do you think it would be possible to have a warning in some way to make sure the user notices that the kde contours look very misleading? I guess always plotting the scatter plot (as anesthetic does by default) helps with noticing such problems.
Screenshots
This is what happens using the kde plot (first example)

2nd data set. Adding ncompress up to 10000 does not help.

FastKDE can help sometimes:

But not always:

This is an example plotting the same data (first set) with GetDist:

Additional context
I checked

Higher values of ncompress up to 10000 without visible change
fastkde sometimes works, but produces rather jagged contours (sometimes quite unreadable)
Setting the scalar bw_method scipy for kde to values between 1e-5 and 1e5 but that seems to have no effect

Edit: I noticed I didn't try high enough values of ncompress (I thought it was getting super slow but with FastKDE it actually is okay), and setting ncompress=3200000 (which is the size of my sample set) produces plots somewhat similar to GetDist

Hi @Stefan-Heimersheim,
sorry for taking so long to look at this. Thanks for the reproducable example. This addresses the issue of finding the optimal bandwith for the KDE, which is not easy to do in an automated fashion.

This can only be partially fixed with setting the limits dictionary.

Adding ncompress up to 10000 does not help.

Hmm, for me the combination of limits with higher ncompress looks quite good:
import numpy as np
import anesthetic

x = np.load("xdata.npy")
y = np.load("ydata.npy")
samples = anesthetic.MCMCSamples(np.array([x,y]).T, columns=['x','y'])
samples.limits={}
samples.limits['x'] = (None, samples.x.max())
samples.limits['y'] = (samples.y.min(), None)

fig, axes = samples.plot_2d(['x','y'], types={"lower": "kde"}, ncompress=10000)
samples.plot_2d(axes, types={"lower": "scatter"}, ncompress=2000)
axes.iloc[0, 0].set_xlim(8, 13)
axes.iloc[0, 0].set_ylim(-1, 4)

I find this arguably better than the GetDist output, which in my opinion reduces the bandwith too far (it still looks ok because our eyes iron out the raggedy contour edges, but in a 1D plot we would call that out for being overfitted, I think).
You can improve on the above plot by further cranking up to ncompress=30000:

Cranking up ncompress does indeed slow down the computation. I'm getting 7s for ncompress=10000 and 23s for ncompress=30000. I think that is acceptable for publishing-quality plots. When your just exploring, then you don't need that high ncompress to see what's going on, I think, right? Plus, for exploration you can always include the scatter plot...
@williamjameshandley Did you ever consider/look into attempts at parallelising this to speed up computation? Could that be something helpful to get a speed-up of a few?

As for your second plotting example, I get the following:
x = np.load("xdata2.npy")
y = np.load("ydata2.npy")
samples = anesthetic.MCMCSamples(np.array([x,y]).T, columns=['x','y'])
samples.limits={}
samples.limits['x'] = (samples.x.min(), samples.x.max())
samples.limits['y'] = (samples.y.min(), None)
fig, axes = samples.plot_2d(['x','y'], types={"lower": "kde"}, ncompress=50000)
samples.plot_2d(axes, types={"lower": "scatter"}, ncompress=2000)

I think the problem here is less one of bandwidth, but rather that this is a quite difficult case, because there seems to be a non-linear line excluding part of the parameter space, right?
@williamjameshandley Do you reckon there could might be a way of telling anesthetic about prior excluded regions and have it cut them off similar to how it's doing it at the moment using limits? A potentially simpler case would be a linear line, but a curved line might not be that much more difficult?

In all of the plots you show I find the contours still a bit problematic. Looking at the very left edge, or the part just above (8.5 , 0) in the 3rd plot you see a region without any samples but the 68% contour still goes way into that region. I think this is my main issue, there is a clear cutoff and we are not capturing it.

I acknowledge of course that this is not necessarily the job of the plotting tool and more of the researcher to make sure they use their tools correctly / check what they do; I just noticed it and was surprised.

In my toy data, the 2nd data set is just a transformed version of the 1st one, so in this case one could calculate the analytic cut-off, but the lower cutoff e.g. is not manually imposed but by the simulation (temperature of radiation, where the lower limit is T_cmb).

@williamjameshandley Do you reckon there could might be a way of telling anesthetic about prior excluded regions and have it cut them off similar to how it's doing it at the moment using limits? A potentially simpler case would be a linear line, but a curved line might not be that much more difficult?

I'm not Will but from my side I don't think that would be very helpful in too many cases. I think in most such cases you won't know the cut-off, and fitting a function to the use it for the cutoff also seems like not a good idea. Maybe automatically assuming limits=[min(data), max(data)] when plotting parameters with no limit information might help (as in my case, there were no limits as I used derived parameters but simple limits already helped a lot.

Looking at the very left edge, or the part just above (8.5 , 0) in the 3rd plot you see a region without any samples but the 68% contour still goes way into that region. I think this is my main issue, there is a clear cutoff and we are not capturing it.

Well, I did not include the low-x limit, once you do that there is a bit of a cutoff. I'd be careful not to over-interpret the output from the scatter plot, though, that can be misleading in its own right. Maybe a KDE with 2 contours is not the best choice for this type of complicated distribution. If a high level of accuracy is needed here, then maybe it might be best to show the full histogram?
fig, axes = samples.plot_2d(['x','y'], types={"lower": "hist"}, bins=50)

Looking at this I can see why the KDE picks up on a lower left "kink". You can also play around with cmin which leads me to believe that that kink is actually real...

I think in most such cases you won't know the cut-off

Agreed, using a function would only help in cases like your lower curved line in the second example, where you know about the cutoff line. A more frequent case would be the identity line when e.g. one parameter is strictly smaller than the other, such as for the black hole masses in binary mergers with GW data.

Maybe automatically assuming limits=[min(data), max(data)] when plotting parameters with no limit information might help

Anesthetic actually should already do that. If you remove the samples.limits={} line from your first example then anesthetic should automatically assign the limits.

Anesthetic actually should already do that. If you remove the samples.limits={} line from your first example then anesthetic should automatically assign the limits.

Sorry I meant when you create a derived variable with samples['c'] = samples['a']  + samples['b']  the limits do not get copied, so when you plot 'c' you get a plot without limits (that's what happened to me, my limits were on model parameters and the temperatures in my plot were derived)

Maybe automatically assuming limits=[min(data), max(data)] when plotting parameters with no limit information might help

Sorry I meant when you create a derived variable with samples['c'] = samples['a'] + samples['b']  the limits do not get copied, so when you plot 'c' you get a plot without limits

That's a good suggestion. Tackled in #166. Surprisingly easy, just a one-liner: calling self._set_automatic_limits() at the start of plot.

@Stefan-Heimersheim Should I flag this issue as fixed by #166, or is there anything else that we should be discussing here?
Trying to summarize a bit w.r.t. the initial post, I'd say that the combination of correct limits (fixed by #166) and sufficiently high ncompress should in principle give correct results, albeit at the potential cost of rather slow computation (recommendation there could be to test things out with low ncompress and then give it more time with high ncompress for a publication plot?).
As regards the question of warning the user about difficult distributions, I don't see how one could implement such a warning. My general suggestion there would be to always explore multiple visualisation methods ('kde', 'scatter', 'hist') before settling on one (or maybe a combination?) when dealing with complicated distributions.

Yes thanks a lot for the help & advice @lukashergt.

My general suggestion there would be to always explore multiple visualisation methods ('kde', 'scatter', 'hist') before settling on one (or maybe a combination?) when dealing with complicated distributions.

One just has to keep this in mind and always should double-check nontrivial distributions.
I expect #166 will fix this for quite a few common cases, and the general problem isn't really solvable here in a simple way, so lets consider this fixed :)

One just has to keep this in mind and always should double-check nontrivial distributions.

Agreed. Would probably be good for this recommendation to appear in Readme/documentation/demo somewhere, so I'll link #62 here.


Screen Hanging on "Waiting for Klipper"

In the klipper github commit 0105aa3, the name of parameter max_accel_to_decel changed to minimum_cruise_ratio. Loading the program with a newly updated firmware causes the screen to hang on "Waiting for Klipper" as it cannot find the max_accel_to_decel in it's dictionary. Simply changing every instance of the old name to the new name lets it pull the actual data it needs from klipper and fixes the issue.
For those using linux its as easy as:
sed -i 's/max_accel_to_decel/minimum_cruise_ratio/g' main.py lcd.py printer.py
within the KlipperLCD directory. Cheers.

just comment out line 439 in ~/KlipperLCD/printer.py like this:
self.X_MAX_POS = int(volume[0])
self.Y_MAX_POS = int(volume[1])
self.max_velocity           = toolhead['max_velocity']
self.max_accel              = toolhead['max_accel']
#self.max_accel_to_decel     = toolhead['max_accel_to_decel']
self.square_corner_velocity = toolhead['square_corner_velocity']
its not anymore used in klipper  v0.12.0-131.
btw i didnt updated to v0.12.0-132, but should work anyway since it has other fixes.

Could you maybe open a PR with the changed file?
Hopefully that'll make @joakimtoe look into this and maybe start working on it again - imho KlipperLCD is a great solution with a lot of potential, and it would be just great if it would become a somewhat 'generic' solution.. ;)

Worked for me too. @joakimtoe I like the idea of a PR :-)


0.56.0 crashes at startup (in YellowBoxList.js)

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
React Native Environment Info:
System:
OS: macOS High Sierra 10.13.4
CPU: x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Memory: 695.62 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.6.0 - /usr/local/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 6.1.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
IDEs:
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: ^16.4.1 => 16.4.1
react-native: ^0.56.0 => 0.56.0
npmGlobalPackages:
react-native: 0.56.0
Description
After upgrading from version 0.44 -> 0.56 I keep getting this at the first render loop.
This error is located at:
in FlatList (at YellowBoxList.js:87)
in RCTView (at View.js:43)
in YellowBoxList (at YellowBox.js:104)
in YellowBox (at AppContainer.js:93)
in RCTView (at View.js:43)
in AppContainer (at renderApplication.js:31)
_checkProps
FlatList.js:489:6
FlatList
FlatList.js:433:21

createClassProxy.js:98:23
instantiate
createClassProxy.js:96:6
constructClassInstance
ReactNativeRenderer-dev.js:7577:26
updateClassComponent
ReactNativeRenderer-dev.js:9868:8
performUnitOfWork

We need to have your code to reproduce this issue.

I'm having the same problem, but I do have some more info. I can run my app without a problem until I run packager with whackage (https://github.com/FormidableLabs/whackage). After that, I do get this error as well. Then it doesn't matter what I try to do, I can clear every cache, I keep getting this error, also when I just run react-native start.
@swapkids Do you, by any chance, use(d) whackage as well? If so, I think it might be related.

Okay, did some more digging around (started upgrading to 0.56 yesterday) and can reproduce 10/10 times when I run react-native start --reset-cache. Without the flag, everything works fine.

Same problem here.

Please reproduce with the latest version.


Libclang required for compilation.

Many people don't have it by default.

Thank you for the merge request. What OS required the libclang installation?
For linux, the default apt-get install build-essential patch already existing in README should do it.

I'm using Windows 10


init?(:) vs init(:)

BinaryInteger initializers of the form T/init(_:) are abbreviations of T.exactly(_:).unwrap(). Alternatively, I could return Optional<T>. Optional<T> force-unwrapping is only one additional character ("!") and explicit error-handling is awesome. In this hypothetical rework, init?(_:) would an abbreviation of T.exactly(_:).optional().

The more I think about it, the more I like this approach. It's easier to test since it doesn't automatically trap. In the case of the Guarantee types, it would also result in fewer overall methods since error-handling would hoisted to Optional<T>. If I add Optional/prune(_:) then the number of Guarantee initializers would go from 5 to 2. Depending on how well LLVM optimizes Optional/unchecked() it might even be possible to turn remove init(unsafe:).
// MARK: with

init(_:)         // error: nil
init(unsafe:)    // error: %%%%%%

// MARK: without

init(_:prune:)   // error: throws
init(exactly:)   // error: nil
init(_:)         // error: precondition
init(unchecked:) // error: assert
init(unsafe:)    // error: %%%%%%

Also, if the Guarantee protocol becomes that simple, then I can probably drop it.


RTD: fix savefig dir creation

I've had a hard time finding out what was going on with missing RTD plots since we updated the packages until I came across this: https://github.com/ipython/ipython/issues/8733
The proposed fix creates the @savefig directory if not there. It works locally but I'm not sure if it will work on RTD (they might use a custom build directory).
The other changes are minor tweaks to remove some build warnings and/or making use of the latest sphinx Makefile. I also removed a part of the conf.py which I think is not needed anymore.
@shoyer do you remember what the inspect.findsource monkeypatch was good for?

OK, so this fix worked locally but not on RTD because RTD uses another build directory:
/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/latest/doc/plotting.rst:None: WARNING: image file not readable: ../../../../../readthedocs/templates/sphinx/_static/plotting_example_existing_axes.png

This is really annoying. I'll try to dig into another possible fix mentioned here: https://github.com/ipython/ipython/issues/8733#issuecomment-234249437


Remove casper-mainnet feature flag

This PRs removes the casper-mainnet feature flag.

TODOs:

Failing test: block_with_deploys_round_trip_lmdb(), with Block has incorrect block hash.
Failing test with a particular seed:

CL_TEST_SEED=db116508126c89831CD6AA9da22d2925 cargo test components::storage::tests::can_put_and_get_blocks_v2

caused by era_id to be randomized as 0.

@rafal-ch This PR has over 5k LOC touched. Is it really just removing casper-mainnet feature flag?

@rafal-ch This PR has over 5k LOC touched. Is it really just removing casper-mainnet feature flag?

It removes the resources/test/rpc_schema_hashing_V2.json which contributes -4222 lines.


Flatlist Footer animation[possible BUG]

Possible BUG
I was creating a Flatlist component like following -
<FlatList data={data} renderItem={this._renderItem} keyExtractor={this._keyExtractor} refreshing={this.state.refresh} onRefresh={this.onRefresh}                 ListHeaderComponent={this._renderHeader} ListFooterComponent={this._footerComponent}/>
now the footer component looks like this -
_footerComponent = () => {       return(         <ButtonComponent buttonState={this.state.buttonState}           states={{             load:{               onPress: () => {                 this._endReached();               },               text:'Load More'             },             loading:{               onPress: () => {},               spinner: true,               text:'Loading More .....'             }           }}></ButtonComponent>       )
with library react-native-button-component
now the problem is that the button does not seem to animate!
in fact anything i put in the footer component it does not seem to animate or even change with a change of state
i even tried with this library - ant
in this manner -
<View style={{alignItems:'center', justifyContent:'center', height: 40, flex:1, flexDirection:'row'}}>                             <ActivityIndicator animating={this.state.loadingMore} text="Loading more ..."/>                             <Text>{this.state.ButtonText}</Text>                         </View>
but it does not animate, except that everything works fine
Have you read the Bugs section of the Contributing to React Native Guide?
YES
Environment

react-native -v: {react-native-cli: 2.0.1
react-native: 0.45.1}
node -v:  v7.4.0
npm -v: 4.0.5
yarn --version (if you use Yarn): 0.24.5

Then, specify:

Target Platform (e.g. iOS, Android): Android/iOS(Tested on: Android 7.1.1/ iOS: 10.3.2/11 beta)
Development Operating System (e.g. macOS Sierra, Windows 10): macOS 10.12.5
Build tools (Xcode or Android Studio version, iOS or Android SDK version, if relevant): not relevant

Steps to Reproduce

copy the above code,
configure state change accordingly to show animations
use any of the above library

Expected Behavior
it should animate or show a state change
Actual Behavior
not showing state change or animation/ but the onPress function runs fine
if i skip this step its fine no apparent change! but i do not think that it should behave like this!

Hi @michaelspeed did you find any solution for this issue. I am facing the same issue with FlatList.


ref(builder): push deis/slugrunner in the background

We shouldn't have to wait however long it takes for deis/slugrunner to
be pushed to the registry in order to start serving requests. This is
just an optimization so that the first git push with a heroku buildpack
will not have to push the entire cedar stack, though if someone is using
the Dockerfile workflow then this optimization is more of a bane than a
boon.
refs #3395

If this gives a useful error message when someone does a git push and slugrunner is still being pushed in the background, I think it's a better UX overall.

@bacongobbler maybe I'm not clear with the idea in 3395.
I want to download a tgz from s3 that contains the slugbuilder and slugrunner directly to the registry.
Not using the builder at all. Not even docker load/push or anything like that.
(something like the cedarish tar download but from the registry)

Unfortunately this failed when I set DEIS_TEST_APP=example-java-jetty (the default app doesn't use buildpacks):
-----> Building Docker image
	error at command wait
--- FAIL: TestApps (573.15s)
	itutils.go:288: exit status 1
FAIL
exit status 1
FAIL	github.com/deis/deis/tests	573.192s
godep: go exit status 1
make[1]: *** [test-full] Error 1
make[1]: Leaving directory `/home/jenkins/workspace/test-integration/src/github.com/deis/deis/tests'
make: *** [test-integration] Error 2

>>> Error detected, dumping logs <<<
...

Apr 13 15:08:47 deis-03 sh[3006]: dd795ea47d19: Pushing
Apr 13 15:08:54 deis-03 sh[3006]: dd795ea47d19: Buffering to disk
Apr 13 15:08:55 deis-03 sh[3006]: dd795ea47d19: Image successfully pushed
Apr 13 15:08:55 deis-03 sh[3006]: e1e370efd2a8: Pushing
Apr 13 15:08:59 deis-03 sh[3006]: e1e370efd2a8: Buffering to disk
Apr 13 15:09:00 deis-03 sh[3006]: e1e370efd2a8: Image successfully pushed
Apr 13 15:09:00 deis-03 sh[3006]: fc74463dd1f8: Pushing
Apr 13 15:09:05 deis-03 sh[3006]: fc74463dd1f8: Buffering to disk
Apr 13 15:09:06 deis-03 sh[3006]: fc74463dd1f8: Image successfully pushed
Apr 13 15:09:06 deis-03 sh[3006]: Pushing tag for rev [fc74463dd1f8] on {http://<IP_ADDRESS>:5000/v1/repositories/deis/slugrunner/tags/latest}
Apr 13 15:09:07 deis-03 sh[3006]: time="2015-04-13T15:09:07Z" level="info" msg="-job push(<IP_ADDRESS>:5000/deis/slugrunner) = OK (0)"
Apr 13 15:10:52 deis-03 sh[3006]: HTTP code 409 while uploading metadata: {"error": "Cannot set this image checksum"}
Apr 13 15:10:52 deis-03 sh[3006]: time="2015-04-13T15:10:52Z" level="info" msg="-job push(<IP_ADDRESS>:5000/appssample) = ERR (1)"
Apr 13 15:10:52 deis-03 sh[3006]: Received disconnect from <IP_ADDRESS>: 11: disconnected by user

Ok thanks @mboersma, I'll take a look into it :)

I hit a similar issue. I have a feeling that it was due to a timeout. I was just monitoring the process tree in the builder before it died:
><> git push deis master
The authenticity of host '[deis.<IP_ADDRESS>.xip.io]:2222 ([<IP_ADDRESS>]:2222)' can't be established.
ECDSA key fingerprint is d1:91:26:8a:79:b9:da:d5:cd:e5:68:a8:8e:64:2c:a7.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added '[deis.<IP_ADDRESS>.xip.io]:2222,[<IP_ADDRESS>]:2222' (ECDSA) to the list of known hosts.
Counting objects: 32, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (18/18), done.
Writing objects: 100% (32/32), 10.72 KiB | 0 bytes/s, done.
Total 32 (delta 9), reused 32 (delta 9)
-----> Go app detected
-----> Installing go1.2.2... done
-----> Running: godep go install -tags heroku ./...
-----> Discovering process types
       Procfile declares types -> web
-----> Compiled slug size is 1.7M

-----> Building Docker image
remote: Sending build context to Docker daemon 1.799 MB
remote: build context to Docker daemon
Step 0 : FROM deis/slugrunner
 ---> 8fc0ec00e29d
Step 1 : RUN mkdir -p /app
 ---> Running in f75e832fa5bb
 ---> f6bf7704e2d9
Removing intermediate container f75e832fa5bb
Step 2 : WORKDIR /app
 ---> Running in ac6f126d8793
 ---> 6344cc89d4e3
Removing intermediate container ac6f126d8793
Step 3 : ENTRYPOINT /runner/init
 ---> Running in a37adde0dda9
 ---> 87f34ee87137
Removing intermediate container a37adde0dda9
Step 4 : ADD slug.tgz /app
 ---> 0d255ae8a201
Removing intermediate container d1bdcc3422a0
Step 5 : ENV GIT_SHA 7259e519b91cb6ab9acfec1cae8332085241b9ec
 ---> Running in 5aecd5056ccb
 ---> d0b50b9454c4
Removing intermediate container 5aecd5056ccb
Successfully built d0b50b9454c4
-----> Pushing image to private registry
To ssh://git@deis.<IP_ADDRESS>.xip.io:2222/go.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://git@deis.<IP_ADDRESS>.xip.io:2222/go.git'

Process tree for the most part:
root@ac065f9c19df:/app# ps faux
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
root      2005  0.3  0.1  18144  3340 ?        S    22:52   0:00 bash
root      2042  0.0  0.1  15568  2172 ?        R+   22:53   0:00  \_ ps faux
root         1  0.0  0.1  18004  3024 ?        Ss   22:42   0:00 /bin/bash /app/bin/boot
root       170  0.1  0.0   9896  1784 ?        Sl   22:43   0:00 confd -node <IP_ADDRESS>:4001 --confdir /app --log-level error --interval 5
root       176 81.6  4.8<PHONE_NUMBER>8 ?        Sl   22:43   7:45 docker -d --bip=<IP_ADDRESS>/16 --storage-driver=overlay --insecure-registry <IP_ADDRESS>/8 --insecure-registry <IP_ADDRESS>/12 --insecure-registry
root       603  0.0  0.1  17968  2784 ?        S    22:45   0:00 /bin/bash /usr/local/bin/push-images
root       616  0.1  0.5<PHONE_NUMBER>6 ?        Sl   22:45   0:00  \_ docker push <IP_ADDRESS>:5000/deis/slugrunner:latest
root       604  0.0  0.2  61372  5192 ?        S    22:45   0:00 /usr/sbin/sshd -D -e
root       837  0.0  0.2  88892  5436 ?        Ss   22:47   0:00  \_ sshd: git [priv]
git        848  0.0  0.1  88892  3108 ?        S    22:47   0:00      \_ sshd: git@notty
git        849  0.0  0.0   4448   744 ?        Ss   22:47   0:00          \_ sh -c /usr/local/bin/gitreceive run bacongobbler c7:e8:c0:2f:37:8e:e2:87:d2:7a:0c:bc:bb:2d:27:85
git        850  0.0  0.1   9556  2684 ?        S    22:47   0:00              \_ /bin/bash /usr/local/bin/gitreceive run bacongobbler c7:e8:c0:2f:37:8e:e2:87:d2:7a:0c:bc:bb:2d:27:85
git        863  0.0  0.1  23184  2492 ?        Sl   22:47   0:00                  \_ git receive-pack go.git
git        868  0.0  0.1   9528  2344 ?        S    22:47   0:00                      \_ /bin/bash hooks/pre-receive
git        870  0.0  0.1   9556  2636 ?        S    22:47   0:00                          \_ /bin/bash /usr/local/bin/gitreceive pre-receive
git        875  0.0  0.1   9568  2648 ?        S    22:47   0:00                              \_ bash /home/git/builder bacongobbler go.git 7259e519b91cb6ab9acfec1cae8332085241b9ec
git       1198  0.1  0.5<PHONE_NUMBER>8 ?        Sl   22:47   0:00                              |   \_ docker push <IP_ADDRESS>:5000/go:git-7259e519
git        876  0.0  0.0   9556  1832 ?        S    22:47   0:00                              \_ /bin/bash /usr/local/bin/gitreceive pre-receive
git        877  0.0  0.0  10980  1408 ?        S    22:47   0:00                                  \_ sed -u s/^/.[1G/
root      2035  0.0  0.0   4348   664 ?        S    22:52   0:00 sleep 5

And before the job failed, PID 603 had finished. After the failure, I tried pushing the image and noticed that a few layers still needed to be pushed:
root@ac065f9c19df:/app# docker push <IP_ADDRESS>:5000/go:git-7259e519
The push refers to a repository [<IP_ADDRESS>:5000/go] (len: 1)
Sending image list
Pushing repository <IP_ADDRESS>:5000/go (1 tags)
Image 44cd487a09bd already pushed, skipping
Image 52dc3ac34171 already pushed, skipping
Image 70b0d11fad2d already pushed, skipping
Image 423dce5daa60 already pushed, skipping
Image 30c30c9934b1 already pushed, skipping
Image 1dacbe3f6e05 already pushed, skipping
Image 2470a58be133 already pushed, skipping
Image 8647e1c10631 already pushed, skipping
Image 98e3b0e2fed4 already pushed, skipping
Image 27e3802eb861 already pushed, skipping
Image 8fc0ec00e29d already pushed, skipping
Image 14a4112c9089 already pushed, skipping
Image 66ccf2758f57 already pushed, skipping
f6bf7704e2d9: Image successfully pushed
6344cc89d4e3: Image successfully pushed
87f34ee87137: Image successfully pushed
0d255ae8a201: Image successfully pushed
d0b50b9454c4: Image successfully pushed
Pushing tag for rev [d0b50b9454c4] on {http://<IP_ADDRESS>:5000/v1/repositories/go/tags/git-7259e519}

Looking closely at the actual logs in the builder, I indeed hit the same issue as you did:
Pushing tag for rev [8fc0ec00e29d] on {http://<IP_ADDRESS>:5000/v1/repositories/deis/slugrunner/tags/latest}
time="2015-04-22T22:53:19Z" level="info" msg="-job push(<IP_ADDRESS>:5000/deis/slugrunner) = OK (0)"
HTTP code 409 while uploading metadata: {"error": "Cannot set this image checksum"}
time="2015-04-22T22:54:10Z" level="info" msg="-job push(<IP_ADDRESS>:5000/go) = ERR (1)"
Received disconnect from <IP_ADDRESS>: 11: disconnected by user

Haven't looked too deep in the code, but this is the error: https://github.com/docker/docker-registry/blob/ca53d728fb57302606892362820dfaa8aed105c5/docker_registry/images.py#L245-L246

The root issue here is https://github.com/docker/docker-registry/issues/593, so this is something that's not supported with the v1 registry. :(

Maybe we could add some retry logic to the docker push? This is a pretty huge optimization to the builder, cutting down the startup time by half. I'd hate to see that there's no native workaround for this

The v2 docker registry seems to be able to handle concurrent pushes. We're currently blocked from updating to that because of deis pull, but that would help us solve this problem:
docker@boot2docker:~$ docker push localhost/bacon/foo:latest
6941bfcbbfca: Image successfully pushed
41459f052977: Image successfully pushed
fd44297e2ddb: Image already exists
0ae6eb24ab7f: Image successfully pushed

In another terminal, pushing concurrently:
docker@boot2docker:~$ docker push localhost/bacon/bar:latest
6941bfcbbfca: Image successfully pushed
41459f052977: Image successfully pushed
fd44297e2ddb: Image already exists
1f7956a0c895: Image successfully pushed

docker@boot2docker:~$ docker history localhost/bacon/foo
IMAGE               CREATED             CREATED BY                                      SIZE
0ae6eb24ab7f        2 minutes ago       touch foo                                       0 B
fd44297e2ddb        36 hours ago        /bin/sh -c #(nop) CMD ["/bin/bash"]             0 B
41459f052977        36 hours ago        /bin/sh -c #(nop) ADD file:be2a22bb15fbbbf24b   215.7 MB
6941bfcbbfca        36 hours ago        /bin/sh -c #(nop) MAINTAINER The CentOS Proje   0 B
docker@boot2docker:~$ docker history localhost/bacon/bar
IMAGE               CREATED             CREATED BY                                      SIZE
1f7956a0c895        2 minutes ago       touch bar                                       0 B
fd44297e2ddb        36 hours ago        /bin/sh -c #(nop) CMD ["/bin/bash"]             0 B
41459f052977        36 hours ago        /bin/sh -c #(nop) ADD file:be2a22bb15fbbbf24b   215.7 MB
6941bfcbbfca        36 hours ago        /bin/sh -c #(nop) MAINTAINER The CentOS Proje   0 B

closing. Will re-open as an issue to keep track of this


Resolve: Match folder structure to other hosts

Brief description
Make sure that code related to in-DCC logic is not imported in main host directory. This change gives ability to have resolve as module which is not possible at the moment.
Description
Changed all import to point directly to function locations or to openpype.hosts.resolve.api instead of openpype.hosts.resolve. Moved setup function from in-DCC functions to public code because is used in prelaunch hook.
Additional info
I don't have resolve so all changes are made blindly, please report any issues. Current structure would block development of some features thus this changes are needed to move on.
There is a lot of script files that seems to be duplicated or not used, we should consider remove those unused.
Testing notes:

Resolve should work at least the same as before this PR

Resolves https://github.com/pypeclub/OpenPype/issues/3406

I would love to check, but I am not able to make the Resolve work. Attempt to run Openpype_MEnu script stops at importing OTIO:
    from opentimelineio import opentime
  File "C:\Users\robur\OpenPype\.venv\Lib\site-packages\opentimelineio\__init__.py", line 35, in <module>
    from . import (
  File "C:\Users\robur\OpenPype\.venv\Lib\site-packages\opentimelineio\opentime.py", line 1, in <module>
    from . _opentime import ( # noqa
ModuleNotFoundError: No module named 'opentimelineio._opentime'

Resolve 17.4.6 build 4
Python 3.6

I would love to check, but I am not able to make the Resolve work. Attempt to run Openpype_Menu script stops at importing OTIO:
    from opentimelineio import opentime
  File "C:\Users\robur\OpenPype\.venv\Lib\site-packages\opentimelineio\__init__.py", line 35, in <module>
    from . import (
  File "C:\Users\robur\OpenPype\.venv\Lib\site-packages\opentimelineio\opentime.py", line 1, in <module>
    from . _opentime import ( # noqa
ModuleNotFoundError: No module named 'opentimelineio._opentime'

Resolve 17.4.6 build 4
Python 3.6
Windows 10

You have to install OpenTimelineIO separately into p3.6. The process should be explained in documentation I believe.

@iLLiCiTiT please also fix the pep8 before the merge ;)

please also fix the pep8 before the merge ;)

I can't. It's because the imports are after definition of bmdvr and bmdvf, but they must be defined before those imports because are replaced during that time. To fix it I would have to move those global variables elsewhere and change all related imports.


Add TO Go Servers Details endpoint

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1568/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1614/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1635/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1684/
Test PASSed.


Clarify DWORD usage on Error logging in HTTP APIs

Currently on the main page: Error logging in HTTP APIs for configuring EnableErrorLogging, saying to create a DWORD key and set the value to TRUE or FALSE which is wrong as for DWORD the value must be number. I already set the key EnableErrorLogging with the value 1 or 0 and is working as expected.
I changed the description to be more clear and helpful.
From:

To:

#sign-off

@sa-es-ir Thanks for your suggestions. And we noticed that the content in this article is a duplicate of this page in core docs: https://learn.microsoft.com/en-us/windows/win32/http/error-logging-in-the-http-server-api. We have redirected this article and feel free to let me know if you have further feedback.

@sevend2 That's cool, thanks.


Add search command

Note: Algolia search API key was pushed intentionally; this is already publicly distributed as part of the wiki bundle.
Usage
/search <query>
Demo
https://github.com/user-attachments/assets/b07c1b16-c745-48c5-b234-49f4a22302ba

This should be /wiki like it was originally, imo. Could do an alias !search for !wiki, /search should make /wiki show up since it's in the description anyway, but I'd need to test.
Everything else looks good, but I recommend 4 spaces for continuous indention so it looks better.

Changed to /wiki.


feat(Formatter): add space inside option

WIP
Summary
Add formatting option to include spacing inside parentheses, square brackets, curly braces, and angle brackets.
For example, this input:
function id<TypeArg>(x: TypeArg): TypeArg {
	return x;
}
const arr = [1, 2, 3];
if (id(true)) {
	// …
}

Would be formatted as follows with a "space inside" option enabled:
function id< TypeArg > ( x: TypeArg ): TypeArg {
	return x;
}
const arr = [ 1, 2, 3 ];
if ( id( true ) ) {
	// …
}

See https://github.com/biomejs/biome/discussions/2360#discussioncomment-10690814.
Test Plan

@sirreal would you mind creating a task first? Or an umbrella issue?
This isn't something that we might be able to ship in one PR, there's a lot of stuff to take into account:

CLI
option names
comments
formatting strategies

Sure, thanks. I've created https://github.com/biomejs/biome/issues/4607.
This PR really a placeholder and I have a number of questions of my own after spending just a bit of time on this 🙂


Logging failure due to no keybase directory on OSX

It appears that no directory is being tested for/created for keybase on install or selfupdate/autoupdate:
2017-07-17T18:56:02.555464-04:00 ▶ [ERRO keybase standard.go:230] 031 stat /keybase: no such file or directory
This is the relevant block:
https://github.com/keybase/client/blob/cb3bef8fc44eb3732d911c8647b9b2df5978eb89/go/logger/standard.go#L229-L231
There is no keybase directory in either /var/log or ~/Library/Logs/

@cjb clear something up
tyr:~/Library/Logs benc$ ls keybase.
keybase.kbfs.log
keybase.service.log
keybase.start.log
keybase.updater.log

does exist.

Logs are there, /keybase is there later, so there's no bug here.

Yeah was going to close it. It appears that keybase ctl restart still has the error.
You need to fully exit the GUI and restart it to so it does not error on stat /keybase
All errors are reported as [ERRO keybase standard.go:230] as that is the logging line in the GO code. Sorry for the issue.
Full PEBKAC


Document the changedFiles property in readme

Added in https://github.com/alloc/jumpgen/commit/aaac750b101d09a9b1a01c89e747ff0147463e38

This property was renamed to changes.
https://github.com/alloc/jumpgen/blob/07bf2455b2f7cfb06627457bbf1cb4a0cd6f3ac6/packages/jumpgen/src/context.ts#L325-L331
It now includes added and unlinked files as well.


Add ability to ignore changes for cluster_endpoint_public_access_cidrs

Is your request related to a new offering from AWS?

No.
Is your request related to a problem? Please describe.

I initially set the value for cluster_endpoint_public_access_cidrs in terraform, but I also have an external process that updates the CIDRs in AWS very often, so every time I run terraform it tries to change the state. It would be nice to have a flag to ignore changes for this parameter.
Describe the solution you'd like.

Add a lifecycle hook to ignore changes in the cluster_endpoint_public_access_cidrs and a new variable to enable it.
Describe alternatives you've considered.

I can't think of any alternative right now, but would be glad to know if I could solve this using another approach using Terraform.
Additional context

Lifecycle hooks cannot rely on a variable. We are trying to handle this module with best practices from AWS and EKS. Furthermore, we cannot cover each user use case.
We are trying to follow the complete IaaC paradigm in a module (or as much as possible). We can advise you to fork module and customize per your specific use case.


/hiring from google - Route exists but no method in controller

AppSingal shows this:
function CompaniesWeb.CompanyController.hiring/2 is undefined or private
which is possible if you come from google, where we have /hiring as a path (probably some seo left from the old website). This path exists in our router, but internally we have changed this functionality to work through browse?type=hiring.

Would a redirect here suffice?

Yes, I think a redirect would be a good option here. Thank you @zacck 😁

Watch this 👁

@zacck thank you for your interest :) . Are you going to submit a PR for this? If yes, this is great, but if no, please let us know so we can go ahead and fix it ASAP because apparently a lot of people find themselves landing on an error page instead of a regular one. Thanks again :)

@gemantzu I did a thing :)


ABB, UNO-DM-PLUS ETHERNET COM KIT

Hi, I have an Aurora 3.0 UNO with a Lantronics 485 to IP converter which communicates to the windows software called Aurora Communicator.
Will your integration work, If not will this card work?

If it's Modbus Sunspec TCP, it should work. Personally, I chose the VSN300 datalogger, If you give me the exactl model number of your inverter I can check if the VSN300 is compatible.


add RDTimeStamps and associations for OpDetWaveforms

The NOvA timestamps are 64-bit unsigned integers, but the SSP decoder converted them into doubles by truncating to the lowest 1E9, which, in NOvA ticks, is only about 7 seconds.  So the double timestamps in OpDetWaveforms are a random remainder between 0 and 7E6 (since they are in microseconds).  For downstream analysis, we would like to preserve the original NOvA timestamps without modification for use with the OpDetWaveforms.  This PR makes collections of RDTimeStamps and associations for each collection of OpDetWaveforms that the SSP raw decoder makes -- internal, external, and, if fcl configured, just all of them.  Associations are also provided between OpDetWaveforms and RDTimeStamps.
This PR is dependent on lardataobj PR 45
https://github.com/LArSoft/lardataobj/pull/45
so that the classes_def.xml file knows about the new associations.  Pictures below include the fast-rollover double timestamps as well as the NOvA timestamps now copied into RDTimeStamp.fTimeStamp.  The Entry$ number just increments within an artDAQ file from PDSP.

The code changes look reasonable and readable to me. Are we still working on validating this, or is it ready to merge?

This PR depends on another PR in lardataobj. Maybe it is easier to merge when a new larsoft release is avaiable.


made changes to the logout functionality

fixed the location actions and reducers
Description
functionality changes on the navigation links
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[x] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

fixed nav bar and edited main page looks good


EXEC_ROOT is not replaced

Bazel 2.0.0
compilation_database without exec_root produces compile_commands.json with directory:"__EXEC_ROOT__", which is supposed to be replaced by the actual bazel info execution_root.
Using generate.sh prints the error:
ERROR: While parsing option --override_repository=bazel_compdb=.: Repository override directory must be an absolute path

First issue is a duplicate of #40. It seems that you fixed the second issue in #42, right?

Hello,
I am sorry for my prolonged absence.
Your first issue is actually working as intended unfortunately. There is no way for me to detect the exec_root from within the action, so I need user input for that piece of information.
On the same subject, rather than making the attribute mandatory in the user's BUILD file, I think it is better if the users can replace the string with their actual exec_root path from outside the bazel. That way, teams can check in the BUILD file, and some other mechanism can run the bazel target and do the replacement. Similar to what generate.sh does.
 Can you please use any commit after 20591c7ebc597faca2c441d60c025a8a6767349f and let me know if it works for you now? I need to make a new release version with these fixes.

I will mark this issue as closed for now. But please feel free to reopen if something is not working right for you.


find and memoize address on call rather than init

Since race conditions on setup of the credentials processes are tough, we change to fetch address from the credentials server lazily.

Pushed to Hex: https://hex.pm/packages/signet/0.1.4


⚠ Secret Website 3 has degraded performance

In 2426612, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 4307 ms

Resolved: Secret Website 3 performance has improved in 318d896.


Code examples in exercise 10.7 still don't work

Looks like there's been a change to the Activity type to not separate step from event handling:
data Activity world = Activity
        world
    (Event -> world -> world)
    (world -> Picture)

But the code examples afterward are still written against the old type.  For example:
resetable :: Activity s -> Activity s
resetable (Activity state0 step handle draw)
  = Activity state0 step handle' draw
  where handle' (KeyPress key) _ | key == "Esc" = state0
        handle' e s = handle e s

I will try to find time to fix this in the next few days if no one gets to it first.

Ah, guess I only fixed the code that is actually run on CodeWorld, but not the inline code…


NN-2489: Start using create user id rather than audit user id

This has a safety check in that if the staff can't be found it shows '--', so the page won't break, it will temporarily not show the information. I had started on the road to doing what you suggest, but decided against as the impact is minimal.


[release-1.19] Make sure unknown vhosts fall through and get added eventually (if on port 80)

Manual cherrypick required.
#49403 failed to apply on top of branch "release-1.19":
Applying: Make sure unknown vhosts fall through and get added eventually (if on port 80)
Using index info to reconstruct a base tree...
M	pilot/pkg/networking/core/v1alpha3/route/route.go
M	pilot/pkg/networking/core/v1alpha3/route/route_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/core/v1alpha3/route/route_test.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/route/route_test.go
Auto-merging pilot/pkg/networking/core/v1alpha3/route/route.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/route/route.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Make sure unknown vhosts fall through and get added eventually (if on port 80)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Fixed bu https://github.com/istio/istio/pull/49527


Task fails with error "--local can only be used inside a git repository"

The tasks errors out in my pipeline with the error message :
##[error]fatal: --local can only be used inside a git repository

Maybe due to the pipeline checking out more than one repository:
- checkout: self
  persistCredentials: true
- checkout: Scripts

Probably fixed by making the following line configurable: https://github.com/mlarhrouch/azure-pipeline-gpt-pr-review/blob/1db7cfa7a1d56f0a58aa4580caace063610b158a/GPTPullRequestReview/src/git.ts#L7

@fabian-schwarz i don't see the reason for configuring the base directory for git, it should be always "System.DefaultWorkingDirectory"

@mlarhrouch you can checkout multiple repositories in Azure Pipelines, thus it is not always "System.DefaultWorkingDirectory"

@fabian-schwarz in this case maybe using "Build.Repository.LocalPath" instead of "System.DefaultWorkingDirectory" is the best solution ?
https://learn.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml

@mlarhrouch think this would only do half the job, it would only help if the repo we want to use is the "self" repo, another we can't reach with this variable. Still would love to have the option to define my custom working dir to target any checked out repo, which can default to either "System.DefaultWorkingDirectory" or "Build.Repository.LocalPath".

we need this fix, i always pull multiple git repos in my pipelines, for multiple reason. i don't want to do a job just for that... i need the fix of that he can use the multiple directory path

I am using Microsoft hosted agents and checkout put the code into System.DefaultWorkingDirectory /  so basePath configuration is needed.


unignore utp_connections::test::send_receive_data test

r? @canndrew
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Weird Access and Refresh Token liftetimes

Reported by @zigapovhe

Access token expires in 1min after successful login
Refresh token expires after 30min

Testing: Try to decode JWT token with any public available tools and check for exp field.

Should be fixed by a6e0b1

Yep


Game Crash - InvalidOperationException: Sequence contains no matching elements

Let me know if you need anything else, like log files, save file, or modlist.
I will try to respond soon.

Log please, and what you were doing

error-report-2022-09-21-22h13m22s.zip
Does this work for the log?
As for what I was doing, I was just letting the game run, building a few things.
I could try to pinpoint it. Could be a Golem getting build or maybe me building a biofuel tank on top of some platforms.

Just confirmed in another playthrough, it was building a Biofuel tank

Just discovered, also crashes in the same way when building the Biofuel Refinery

Just discovered, also crashes in the same way when building the Catalyst Tank

Note that this does not affect the Charging Station or Control Tower, just the Folktails golem needs buildings.


Add Counter1-4

Hi,
i use the Counter inputs as S0 Interface.
Would it be possible to have counters as IDs? Like the BME280.
22:55:55 MQT: tele/HG/OG/HVT/SENSOR = {"Time":"2019-12-20T22:55:55","COUNTER":{"C1":64},"BME280":{"Temperature":21.6,"Humidity":43.4,"Pressure":957.2},"PressureUnit":"hPa","TempUnit":"C"}

Hallo,
here is the debug log:
sonoff.0	2019-12-20 23:28:46.501	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.BME280_Pressure: {"val":957.6,"ack":true,"ts":1576880926500,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880916519}
sonoff.0	2019-12-20 23:28:46.500	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.BME280_Humidity: {"val":43.7,"ack":true,"ts":1576880926499,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880926499}
sonoff.0	2019-12-20 23:28:46.499	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.BME280_Temperature: {"val":21.6,"ack":true,"ts":1576880926498,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880856508}
sonoff.0	2019-12-20 23:28:46.498	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.Time: {"val":"2019-12-20T23:28:45","ack":true,"ts":1576880926497,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880926489}
sonoff.0	2019-12-20 23:28:46.496	debug	(1584970) [HG_OG_HVT_Z1] Received: tele/HG/OG/HVT/SENSOR = {"Time":"2019-12-20T23:28:45","COUNTER":{"C1":64},"BME280":{"Temperature":21.6,"Humidity":43.7,"Pressure":957.6},"PressureUnit":"hPa","TempUn
sonoff.0	2019-12-20 23:28:46.494	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.Wifi_RSSI: {"val":46,"ack":true,"ts":1576880926493,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880906512}
sonoff.0	2019-12-20 23:28:46.493	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.Wifi_Channel: {"val":6,"ack":true,"ts":1576880926491,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576879106450}
sonoff.0	2019-12-20 23:28:46.491	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.Uptime: {"val":"0T00:30:33","ack":true,"ts":1576880926490,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880926490}
sonoff.0	2019-12-20 23:28:46.490	debug	(1584970) stateChange sonoff.0.HG_OG_HVT_Z1.Time: {"val":"2019-12-20T23:28:45","ack":true,"ts":1576880926489,"q":0,"from":"system.adapter.sonoff.0","user":"system.user.admin","lc":1576880926489}
sonoff.0	2019-12-20 23:28:46.488	debug	(1584970) [HG_OG_HVT_Z1] Received: tele/HG/OG/HVT/STATE = {"Time":"2019-12-20T23:28:45","Uptime":"0T00:30:33","UptimeSec":1833,"Heap":27,"SleepMode":"Dynamic","Sleep":50,"LoadAvg":19,"MqttCount":2,"Wi

Hi,
i checked datapoints.js and found "Counter1-Counter4" already defined.
Looks like Tasmota is changing from Conter1 to C1
Ok, i tried it on my installation... It works perfektly
Could you make the changes? Maybe its saver to add C1-C4 to keep compatible to older Tasmota versions. Don't know when they changed that...


#3189: Scatter plot labels are shown for filtered out points

v1.22.2
Steps to reproduce:

Open SPGI
Add a scatter plot, e.g. 'Whole blood assay 2 Date' on X, 'Stereo category' on Y
Set up showing labels for selected items
Apply some filtering
Select some items that are filtered out

Expected results: labels should not be shown for the items that are not visible on the scatter plot.
Actual results: labels are shown for the filtered out items.
It can be reproduced for any kind of filter (filter panel, in viewer filter).

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-17176

Andrew Golovko commented in Jira:

There can be multiple points at the same coord location (two, or four or more). So if there’s not enough space, then only one or couple will be displayed, and if there’re enough space for many (for example, after zoom in), much more labels can be displayed
[file id="6eaf5541-3a57-4a6f-b037-528259e444f1"][file id="f2f81e25-d9ed-4f91-91b5-ec9e2eeffc4f"][file id="e7a7f970-34ba-48a9-86c3-b5a4434b498e"]
[file id="ea157f17-b001-4ac2-8585-74cff9a29871"]

fixed for 1.22.3

DG 1.22.3 and 1.23.0


PERMISSION_DENIED -> SERVICE_DISABLED to get all reviews of Google My Business Information

I'm trying to get all reviews of an account at GMB (Google My Business Information) and i'm getting an error of permission_denied and service_disabled... but, im my project in Google Console, the services at GMB are enabled...
my code:
$access_token = $token["access_token"];
$request_uri = "https://mybusiness.googleapis.com/v4/$name/locations:batchGetReviews?access_token=" . $access_token;
$curinit = curl_init($request_uri);
curl_setopt($curinit, CURLOPT_SSL_VERIFYPEER, false);
curl_setopt($curinit, CURLOPT_CUSTOMREQUEST, 'GET');
curl_setopt($curinit, CURLOPT_RETURNTRANSFER, true);
$json = curl_exec($curinit);
$phpObj = json_decode($json, true);
var_dump($json);
My Answer:
string(1045) "{ "error": { "code": 403, "message": "Google My Business API has not been used in project<PHONE_NUMBER>8 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/mybusiness.googleapis.com/overview?project=83172312488 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.", "status": "PERMISSION_DENIED", "details": [ { "@type": "type.googleapis.com/google.rpc.Help", "links": [ { "description": "Google developers console API activation", "url": "https://console.developers.google.com/apis/api/mybusiness.googleapis.com/overview?project=83172312488" } ] }, { "@type": "type.googleapis.com/google.rpc.ErrorInfo", "reason": "SERVICE_DISABLED", "domain": "googleapis.com", "metadata": { "service": "mybusiness.googleapis.com", "consumer": "projects/83172312488" } } ] } } "
OBS: THIS IS NOT MY PROJECT ID.... "projects/83172312488" is not my project... my correct project id is "gmail-123XXX"
i'm using PHP library of GMB..
OBS2: the library of GMB to PHP, there isn't resources to get reviews...
Can you help me, guys?

You need to enable the "Google My Business" API by going to the URL provided in the error message. Your project ID may be gmail-123XXX, but your project NUMBER is<PHONE_NUMBER>8. And if THAT isn't correct, then you've configured the wrong project ID somehow.

Hi I am also facing the same issue and checked my configuration but can you please help with more elaborate steps.
getting this error
"Google My Business API has not been used in project<PHONE_NUMBER>92 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/mybusiness.googleapis.com/overview?project=407408718192 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry."
when trying to get all the reviews for my business account
And this is not my project number checked in my google console

For everyone else getting this issue: Your are probably using the Google Developer OAuth Playground, which has the project id<PHONE_NUMBER>92. You cannot use the oauth token generated by the playground, but need to use an access token generated using your projects credentials instead.

You need to fill the https://docs.google.com/forms/d/e/1FAIpQLSdoCw8P5JJsJ-taCH2i8w8B69sGsZfoRhacQOe7FTWArWZ-SQ/viewform to get the access to the reviews


Transaction signatures not being stored properly

Currently Juno is not getting the correct signatures of each transaction. This is due to the fact that we have the wrong assignment:
https://github.com/RiccardoM/juno/blob/6a7b00190e073db5e7171de80924c8c451e74e08/db/postgresql/postgresql.go#L105
This should be
sigs[index] = tx.Signatures[index]

Closes with 3b09c4e72f19c1b8b7d132aec799d7ce5c1815b4


[chip-test, sival] AES sideload test

Test point name
chip_sw_aes_sideload
Host side component
None
OpenTitanTool infrastructure implemented
None
Silicon Validation (SiVal)
None
Emulation Targets

[ ] None
[X] CW310
[ ] Hyperdebug + CW310

Contact person
vogelpi
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)
[ ] For SiVal test cases, test is running relevant FPGA or silicon regression

estimate: 2

Based on PR: #19783


Does not run on Linux

BUTRLoader does not start up on Linux (Linux 5.13.0-30-generic #33~20.04.1-Ubuntu SMP Mon Feb 7 14:25:10 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux)
Vanilla Launcher loads instead

Sorry for the delayed answer! I guess that Proton was used? Was net472 installed? Was the .config file present?
If the config was there and net472 was not installed, could you try to install it? Because by default the game is using mono as the runtime, it might work with a proper net472 runtime

A similar Linux issue that has some info about installing dotnet472

This seems to be the fix here as well.


Use standard function names

The standard go way to deal with format function is to have a f suffix. This is used by tools like go vet to detect errors and typos.
A simple fix would be to add f functions calling the regular one.
Example of the problem:
var local, remote string
flog.Info("doing initial sync (%s -> %d)", local, remote)

$> go vet -printf.funcs go.coder.com/flog.Info ./...
# No result.

While having standard Infof would result in:
var local, remote string
flog.Infof("doing initial sync (%s -> %d)", local, remote)

$> go vet -printf.funcs go.coder.com/flog.Infof ./...
main.go:25:2: Errorf format %d has arg remote of wrong type string

cc @nhooyr

I agree, I blame @ammario

👍 and @nhooyr designed this API

👍 and @nhooyr designed this API

straight lies


Snapshot serializers added with expect.addSnapshotSerializer are not used

🐛 Bug Report
Custom snapshot serializers added with expect.addSnapshotSerializer are not used. Only custom snapshots serializers configured via snapshotSerializers actually work.
This behaviour appears to have broken in version 8.
To Reproduce

git clone https://github.com/askoufis/jest-puppeteer-repro
pnpm install
pnpm test

The test in foo.test.js is run. This has a custom serializer added that prepends some text to the snapshot. However the snapshot does not contain this test, which is a bug.

git switch jest-puppeteer-7
pnpm install
pnpm test

This branch has jest-puppeter@7 installed. The snapshot serializer works in this case.

git switch config-snapshot-serializers
pnpm install
pnpm test

This branch has the snapshot serializer configured in the jest config instead of the test file, and it's using jest-puppeteer@8. The snapshot now fails as the serializer has prepended some text to the snapshot, which is the expected behaviour.
Expected behavior
Custom snapshot serializers added with expect.addSnapshotSerializer should work.
Link to repl or repo (highly encouraged)
https://github.com/askoufis/jest-puppeteer-repro
System info
Paste the results here:
## System:
 - OS: macOS 13.2.1
 - CPU: (10) arm64 Apple M1 Pro
 - Memory: 4.52 GB / 32.00 GB
 - Shell: 3.6.1 - /opt/homebrew/bin/fish
## Binaries:
 - Node: 16.20.0 - ~/.local/share/.volta/tools/image/node/16.20.0/bin/node
 - Yarn: 1.22.19 - ~/.local/share/.volta/tools/image/yarn/1.22.19/bin/yarn
 - npm: 8.19.4 - ~/.local/share/.volta/tools/image/node/16.20.0/bin/npm
 - Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
## npmPackages:
 - jest-puppeteer: ^8.0.6 => 8.0.6

Hello @askoufis, thanks. I think it is a problem in the overriding of expect.

Did a bit of debugging. To me, the overriding of expect is correct. It's fairly similar to the code in expect-puppeteer v7. What's interesting is that when calling addSnapshotSerializer, which is just an alias for addSerializer, the PLUGINS array is updated correctly. However, when getSerializers is called later on (internally within jest somewhere), the PLUGINS array is back to its original state with only 7 elements (you'd expect there to be at least 8).

Thanks for the fix! :)


checkov: 3.2.50 -> 3.2.51

Diff: https://github.com/bridgecrewio/checkov/compare/refs/tags/3.2.50...3.2.51
Changelog: https://github.com/bridgecrewio/checkov/releases/tag/3.2.51
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 301163 run on x86_64-linux 1

2 packages built:

checkov
checkov.dist