Add a post about running Kythe on OS X. [phab:D293]

Created by zarko at 2015-05-28 22:38:19:
If anyone hasn't built on OS X yet,
please try out the instructions and let me
know if I've left anything out.

bzz wrote at 2015-05-29 11:26:41:
not sure if that suppose to happen:
XCode 6.1.1
$sw_vers                                                                                ProductName:	Mac OS  ProductVersion:	10.10.3 BuildVersion:	14#341
$ bazel build //...                                                                                INFO: Found 397 targets... INFO: From Compiling third_party/rapidjson/test/unittest/valuetest.cc: third_party/rapidjson/test/unittest/valuetest.cc:58:3: error: static_assert failed ""   static_assert(!std::is_copy_assignable<Value>::value, "");   ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ third_party/rapidjson/test/unittest/valuetest.cc:62:3: error: static_assert failed ""   static_assert(!std::is_nothrow_copy_assignable<Value>::value, "");   ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. ERROR: /Users/.../google-kythe-osx/third_party/rapidjson/BUILD:99:1: C++ compilation of rule '//third_party/rapidjson:rapidjson_value_test_lib' failed: clang failed: error executing command /Users/.../google-kythe-osx/tools/cpp/clang '-std=c++11' -fno-rtti -Wall -Werror -Wno-unused-variable -Wno-deprecated-declarations -D_XOPEN_SOURCE -static -Wno-non-virtual-dtor ... (remaining 25 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1. INFO: Elapsed time: 26.369s, Critical Path: 21.09s

schroederc commented inline (context lost during migration) at 2015-05-29 15:20:40:
Why not just
cd ~
git clone https://github.com/google/bazel/
cd bazel

schroederc commented inline (context lost during migration) at 2015-05-29 15:20:40:
Same as above

schroederc commented inline (context lost during migration) at 2015-05-29 15:20:40:
This can also be installed with brew install go.

schroederc commented inline (context lost during migration) at 2015-05-29 15:20:40:
Homebrew installation might be more useful before the Bazel install.  It simplified things for me greatly by installing xcode.

schroederc wrote at 2015-05-29 15:20:40:
I deployed this draft to https://79f82e731a5f3fe8dc17e7f3fded1898e4929f4e-dot-kythe-repo.appspot.com/2015/05/29/osx-support/

schroederc commented inline (context lost during migration) at 2015-05-29 15:25:10:
Go can also be installed with brew install go

schroederc commented inline (context lost during migration) at 2015-05-29 15:26:55:
Maybe point to http://kythe.io/phabricator/maniphest instead of just the Phabricator homepage?

schroederc commented inline (context lost during migration) at 2015-05-29 15:26:55:
kythe-dev instead of the community forum?

schroederc wrote at 2015-05-29 15:57:22:
bazel test //... works for me, but I'm getting a bunch of warnings.  Here's just a few.
INFO: From CcIndexer kythe/cxx/extractor/testdata/extract_verify_std_vector_test/compilation/kythe/cxx/extractor/testdata/extract_verify_std_vector_test.cc.entries:
Warning: when looking for /usr/include/pthread/sched.h[3efaeeac44fdd32a9c49dd5d779c71213013ed56571b03bc7587cd209d412505]:1022: missing source path

INFO: From Linking kythe/cxx/common/commandline_test:
ld: warning: option -noall_load is obsolete and being ignored

INFO: From Linking tools/cpp/libmalloc.a:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/tools/cpp/_objs/malloc/tools/cpp/empty.pic.o has no symbols
warning: /Library/Developer/CommandLineTools/usr/bin/libtool: warning for library: bazel-out/local_darwin-fastbuild/bin/tools/cpp/libmalloc.a the table of contents is empty (no object file members in the library define global symbols)

INFO: From Compiling third_party/grpc/src/core/tsi/ssl_transport_security.c:
third_party/grpc/src/core/tsi/ssl_transport_security.c:123:3: warning: 'SSL_library_init' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
  SSL_library_init();
  ^
/usr/include/openssl/ssl.h:1569:5: note: 'SSL_library_init' has been explicitly marked deprecated here
int SSL_library_init(void ) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
    ^
third_party/grpc/src/core/tsi/ssl_transport_security.c:124:3: warning: 'SSL_load_error_strings' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
  SSL_load_error_strings();
  ^
/usr/include/openssl/ssl.h:1432:6: note: 'SSL_load_error_strings' has been explicitly marked deprecated here
void    SSL_load_error_strings(void ) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
third_party/grpc/src/core/tsi/ssl_transport_security.c:125:3: warning: 'OPENSSL_add_all_algorithms_noconf' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
  OpenSSL_add_all_algorithms();
  ^
/usr/include/openssl/evp.h:829:3: note: expanded from macro 'OpenSSL_add_all_algorithms'
                OPENSSL_add_all_algorithms_noconf()
                ^

INFO: From Linking third_party/grpc/libgrpc_unsecure.a:
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/iocp_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/iomgr_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/pollset_multipoller_with_epoll.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/pollset_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/resolve_address_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/socket_utils_linux.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/socket_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/tcp_client_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/tcp_server_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/tcp_windows.pic.o has no symbols
/Library/Developer/CommandLineTools/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/grpc/_objs/grpc_unsecure/third_party/grpc/src/core/iomgr/wakeup_fd_eventfd.pic.o has no symbols

schroederc wrote at 2015-05-29 16:00:42:
There seems to be an error ignored while building the docs:
INFO: From Executing genrule //kythe/docs:kythe-storage:
/bin/sh: : command not found
asciidoc: WARNING: kythe-storage.txt: line 106: filter non-zero exit code: "" "/usr/local/Cellar/asciidoc/8.6.9/etc/asciidoc/filters/graphviz/graphviz2png.py"  -o "/private/var/tmp/_bazel_schroederc/74c4715b4953fb15a59589ef48454c24/kythe/bazel-out/local_darwin-fastbuild/bin/kythe/docs/kythe-storage__1.png" -L dot -F png -: returned 127
asciidoc: WARNING: kythe-storage.txt: line 106: no output from filter: "" "/usr/local/Cellar/asciidoc/8.6.9/etc/asciidoc/filters/graphviz/graphviz2png.py"  -o "/private/var/tmp/_bazel_schroederc/74c4715b4953fb15a59589ef48454c24/kythe/bazel-out/local_darwin-fastbuild/bin/kythe/docs/kythe-storage__1.png" -L dot -F png -

schroederc wrote at 2015-05-29 16:04:58:
Building //kythe/docs/schema is failing as well.  It emits messages like this for a few pages.
INFO: From Executing genrule //kythe/docs/schema:schema:
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
mkdir: /example: Permission denied
asciidoc: WARNING: schema.txt: line 75: filter non-zero exit code: "kythe/docs/schema/example.sh" xhtml11 kythe C++ "Typedefs are aliases.": returned 1
asciidoc: WARNING: schema.txt: line 75: no output from filter: "kythe/docs/schema/example.sh" xhtml11 kythe C++ "Typedefs are aliases."
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
/private/var/tmp/_bazel_schroederc/74c4715b4953fb15a59589ef48454c24/kythe/kythe/docs/schema/example-java.sh: line 35: /E.java: Permission denied
asciidoc: WARNING: schema.txt: line 96: filter non-zero exit code: "kythe/docs/schema/example.sh" xhtml11 kythe Java "Classes can be annotated.": returned 1
asciidoc: WARNING: schema.txt: line 96: no output from filter: "kythe/docs/schema/example.sh" xhtml11 kythe Java "Classes can be annotated."
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
mkdir: /example: Permission denied

zarko wrote at 2015-05-29 20:42:19:
Responding in order from top to bottom to the out-of-line comments:
bzz: That is weird. Do you know what version of libc++ you're using?
If you remove the tests from //third_party/rapidjson/BUILD (all the targets
beyond and including "rapidjson_unit_test_lib") can you get any further?
schroederc: I don't see anything curious in the linker and deprecation warnings.
I hadn't noticed the schema problem (I think we should remove the
manual tag from the BUILD file--it's supposed to be run as a test).
#518 should help.
The "missing source path" warning is interesting. I'd seen it before
but failed to create #515. It relates to claiming and can result in potentially
more redundant entries being emitted.
Re: no output from filter: ""
"/usr/local/Cellar/asciidoc/8.6.9/etc/asciidoc/filters/graphviz/graphviz2png.py",
it sounds like something's wrong with your asciidoc installation--it's trying to
execute the empty string applied to a Python script.

zarko wrote at 2015-05-29 20:57:05:
I'm seeing the same thing now re: //kythe/docs:kythe-storage (if only asciidoc failed if a filter failed).

zarko wrote at 2015-05-29 22:18:23:

Address comments and fix asciidoc invocation

bzz wrote at 2015-05-30 01:55:05:
zarko: indeed after commenting out rapidjson tests and pulling latest changes was able to move further

now build fails with

ERROR: /Users/.../google-kythe-osx/third_party/grpc/BUILD:121:1: C++ compilation of rule '//third_party/grpc:grpc' failed: clang failed: error executing command /Users/.../google-kythe-osx/tools/cpp/clang -Wno-implicit-function-declaration -iquote . -iquote bazel-out/local_darwin-fastbuild/genfiles -isystem third_party/grpc/include -isystem ... (remaining 16 argument(s) skipped): com.google.devtools.build.lib.shell.AbnormalTerminationException: Process terminated by signal 15.
ERROR: /Users/.../google-kythe-osx/kythe/go/platform/tools/BUILD:5:1: //kythe/go/platform/tools:entrystream: missing input file '//tools/go:go'.
ERROR: /Users/.../google-kythe-osx/kythe/go/platform/tools/BUILD:5:1 1 input file(s) do not exist.

have go installed using brew
lrwxr-xr-x  1 xxxx   25 May 30 01:02 go -> ../Cellar/go/1.4.1/bin/go```

2. there are plenty of warnings like

INFO: From Linking third_party/liblibcurl.a:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/third_party/_objs/libcurl/third_party/empty.pic.o has no symbols
warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning for library: bazel-out/local_darwin-fastbuild/bin/third_party/liblibcurl.a the table of contents is empty (no object file members in the library define global symbols)
INFO: From Linking tools/cpp/libmalloc.a:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: file: bazel-out/local_darwin-fastbuild/bin/tools/cpp/_objs/malloc/tools/cpp/empty.pic.o has no symbols
warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning for library: bazel-out/local_darwin-fastbuild/bin/tools/cpp/libmalloc.a the table of contents is empty (no object file members in the library define global symbols)

I'm not sure about version of libc++ being used, there are `/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1` and `/usr/local/Cellar/boost/1.58.0/include/boost/tr1/tr1/` and `/usr/include/c++/4.2.1/`.
Would appreciate direction on how to check that.

bzz wrote at 2015-05-30 12:46:35:
bazel build //... passes after manually symlinking tools/go/go -> /usr/local/bin/go and removing all test targets from //third_party/rapidjson/BUILD
with deprecation warnings
long    SSL_CTX_ctrl(SSL_CTX *ctx,int cmd, long larg, void *parg) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
108 warnings generated.```

and a lot of things like

```warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning for library: bazel-out/local_darwin-fastbuild/bin/third_party/liblibuuid.a the table of contents is empty (no object file members in the library define global symbols)```

Also, pulling the fix for asciidoc invocation resolves the issue with `//kythe/docs/schema`

`bazel test //...` works but has some tests failing

INFO: Found 303 targets and 72 test targets...
//kythe/cxx/common/testdata:net_client_test_runner                       FAILED
//kythe/cxx/tools/fyi/testdata:basic                                     FAILED
//kythe/cxx/tools/fyi/testdata:hopeless                                  FAILED
//kythe/cxx/tools/fyi/testdata:nothing                                   FAILED
//kythe/go/serving/tools/testdata:kwazthis_test                          FAILED
Executed 72 out of 72 tests: 67 tests pass and 5 fail locally.

zarko wrote at 2015-05-30 22:43:56:
bzz: Did you see any errors when you ran setup_bazel.sh? That should have created the go symlink. (Maybe we're seeing the same kind of thing that we saw in the asciidoc path and we need to look for tools on OS X using command -v.)
Could you run //kythe/cxx/common/testdata:net_client_test_runner alone (bazel test //kythe/cxx/common/testdata:net_client_test_runner) and post or e-mail me the test log directly? (It's just my Phabricator username google.com). The other tests that are failing for you depend on that one succeeding; net_client_test_runner tests the underlying infrastructure that those other tests use to spin up an xrefs service.
I'm assuming that your libc++ version is similar to mine (v1).

bzz wrote at 2015-05-31 05:18:01:
zarko there were no errors on setup_bazel.sh, but #514 might have already took care of it.
Logs of bazel test //kythe/cxx/common/testdata:net_client_test_runner are here https://gist.github.com/bzz/0081a7e78a5356f2fb55

zarko wrote at 2015-06-01 17:39:40:
If you change the line that reads
if [[ -e /proc/1/cgroup ]] && grep -qe ':/docker' /proc/1/cgroup ; then
to
if true ; then
in kythe/cxx/common/testdata/start_http_service.sh, do you get any farther?

schroederc commented inline (context lost during migration) at 2015-06-01 23:10:28:
This file will need to be renamed with a new date once this change is accepted.

schroederc required changes at 2015-06-01 23:10:28

bzz wrote at 2015-06-03 01:20:54:
Changing a line in kythe/cxx/common/testdata/start_http_service.sh as suggested got me further, but not much - still the same tests are failing, here are new logs
$less /private/var/tmp/_bazel_bzz/3d1bfd70d37a0aadb174e62056949bf3/google-kythe-osx/bazel-out/local_darwin-fastbuild/testlogs/kythe/cxx/common/testdata/net_client_test_runner/test.log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
kythe/cxx/common/testdata/start_http_service.sh: line 63: /proc/sys/net/ipv4/ip_local_port_range: No such file or directory

zarko wrote at 2015-06-04 21:36:10:

Update date and rebase.

schroederc commented inline (context lost during migration) at 2015-06-04 22:28:43:
Link Bazel to bazel.io

schroederc commented inline (context lost during migration) at 2015-06-04 22:28:43:
No need to assume where they clone the repository.

zarko wrote at 2015-06-04 22:44:27:

Link to Bazel and remove a cd.

schroederc accepted this revision at 2015-06-04 22:47:11

zarko closed via commit 9164bc3357bad31bba5eab89d23f56e9890c4dff at 2015-06-05 18:12:43


not working on 21h1 version 10.0.19041.1081

if you install servicing stack update from microsoft updtae it won't work anymore

Hi,
Have you tried this ini file ?
https://raw.githubusercontent.com/sebaxakerhtc/rdpwrap.ini/master/rdpwrap.ini

Worked for me. Thanks
On Sun, Jun 27, 2021 at 12:05 AM sk-lau @.***> wrote:

Hi,
Have you tried this ini file ?
https://raw.githubusercontent.com/sebaxakerhtc/rdpwrap.ini/master/rdpwrap.ini
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/stascorp/rdpwrap/issues/1454#issuecomment-869096883,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4KT5JPUKINJU3A6XA4FZLTU2PR5ANCNFSM47LUNWNA
.

Removed the previous autoupdater.bat and helper and redownloaded from the link below.
https://github.com/stascorp/rdpwrap/pull/1160
Fixed it for me on 21H1.

+1

Anybody can help me to post the offsets in rdpwrap.ini for this version? Because I can't access the link as posted above. I would appreciate it.

Hi All,
I installed as per instructions with the autoupdater.bat and helper. I had all green but when I ran the RDPCheck the screen I got did not show any users. I then changed the setting in Remote desktop services to local system account instead of this account and in order to do so I stopped the service. it did not stop it just said "stopping", I then restarted the computer and since then everything is green as per below except the Listener State is not listening. I have since restarted the computer and installed an update to the one in this thread.  Can anyone suggest any possible fixes or do I need to uninstall everything and go back and start from scratch. I can no longer select "this account" in the remote desktop services properties.

any help or direction appreciated.
Cheers.

uninstalled everything and started from scratch

there are a couple of errors in the uninstall. tried a different configuration file but still getting fully supported but not listening. I am thinking the problem could be in the termsrv.dll file. I have been following a process to install and do not have knowledge about how all the files work so troubleshooting is a stab in the dark.
Again any help appreciated.
Cheers.

Finally got it working the issue was in the remote desktop services properties. this account had to be selected. I entered Network Services and my login account pass. when I applied it automatically populated a password. I then stopped and started the termservices and all working. Hopefully this can help another battler out there.
Cheers.

Anyone else?
I tried @bunyrabitt but no success?

I'm running

this

https://github.com/asmtron/rdpwrap/blob/master/binary-download.md
This worked for me.

Hi,
Have you tried this ini file ?
https://raw.githubusercontent.com/sebaxakerhtc/rdpwrap.ini/master/rdpwrap.ini

Worked for me. Thank you.

if you install servicing stack update from microsoft updtae it won't work anymore

¿How can I remove the update?

I can use the RDP with 1 user, anybody knows how does work with multiple users?

I'm using 21H1 Enterprise and still not working.  I tried a fresh install and updating the latest RDPwrap.ini.  Is a fix being worked on for the Enterprise version?

I'm using 21H1 Enterprise and still not working. I tried a fresh install and updating the latest RDPwrap.ini. Is a fix being worked on for the Enterprise version?

Do you try to start the rdp or multiple users?

Yes, I tried RDPcheck and get error 0x4.  Rebooting the computer will cause a RPC error at login and will infinite loop the login.  You will need to stop the 'TermServices' service to be able to login.  Tried several options on RDPconfig.

Hi,
Have you tried this ini file ?
https://raw.githubusercontent.com/sebaxakerhtc/rdpwrap.ini/master/rdpwrap.ini

this worked great for 10.0.19041.1081 21h1 x64 home edition
i did RDPWInst.exe -r and net start termservice after replacing ini file
thanks alot


[BUG] Multiple game directories are found if executables have same filename

Expected behaviour
If multiple games have the same executable name but are not equal (different binary) they should not be found.
Actual behaviour
le dot
How to reproduce

Day-of-Defeat finds Counter-Strike: Source
The Specialists finds Counter Strike 1.6

Screenshots
No response
Lanty version
v0.1.0-beta
Operating system and version
Windows 11, Windows 10
Additional Information
No response

Could be due to how the games are started - same executable with different arguments --> maybe just use a .bat and make it unique therefore

Cna be fixed by configuration


How to Logout?

How do I add  or find logout button inside ubar sdk.

@nidhiAscra If you're asking about how to generally maintain a UX that leverages the user information (if there is any), it highly depends on your code base.
However, you can simple have a button that removes that token you obtained for that user with the removeAccessToken method.
If you also want to revoke the access by invalidating the current token, you should call the  /revoke endpoint as documented here. I created an enhancement request for this, so one could simply use a method provided by the SDK to accomplish that.
Let me know if you have further questions.


Proper HTML templating

Pure f sharp code makes working with designers etc. difficult  Something like Razor pages/ERB would be nice

Giraffe supports Razor and dotLiquid templates - https://github.com/giraffe-fsharp/Giraffe/blob/master/DOCUMENTATION.md#additional-features. And as Saturn is built on top of Giraffe, you can easily plug it in - just add NuGet package, and use (for example) dotLiquid function in your handlers/controllers.


new builder options: tagNameProcessors and attrNameProcessors

Added tag and attribute name processing to the builder (similar to what the parser does)
Added tests for tag and attribute name processing for the builder (similar to the tests for the parser)
Minor refactoring in parser.coffee: processItem was always used in the same way, removed some copied code
Added package-lock.json to .gitignore to make git handling simpler. (If you want, we can revert this.)
Added a TODO to the line for key, entry of child in the builder - should it be for own key...?
We didn't update README.md yet, because the section about these processors looks like it's a work in progress anyway. If you want, we could try to add a few words to the section.

Potential issues:

Backwards compatibility: Some users may have used the same options object for the parser and the builder in their code. Until now, this worked, because the builder simply ignored tagNameProcessors and attrNameProcessors. After this pull request, such users may run into problems because their builder modifies the names in unexpected ways.
Possible remedies:

Change the names of the builder options, e.g. builderTagNameProcessors and builderAttrNameProcessors.

Rather ugly, I think. In the long run, this will be confusing rather than helpful.

Add another option that activates tagNameProcessors and attrNameProcessors in the builder, e.g. builderProcessors: true or version: "0.4.20". Old code doesn't contain this option and thus works as usual.

Workable, but maybe users will expect all options to be "versioned" in this way...

Simply update the documentation and instruct users not to use the same options object for parser and builder. (With object spread syntax (available since Node.js 8.3.0), it's easy to have a 'common' base object and extend with different options for builder and parser.)

In my opinion, this is the best solution.

Coverage increased (+0.07%) to 97.708% when pulling a202f4750048de62dce0db2b648776c6350c2ff4 on iami-me:add_prop_name_processors into 049242dbefc2d69e8e8ceac566b9e862a58c9ff1 on Leonidas-from-XIV:master.


Missing Set-AzureRmNetworkSecurityGroup

When using the New-AzureRmNetworkSecurityGroup and creating a group you need to Set-AzureRmNetworkSecurityGroup as seen in the docs (https://docs.microsoft.com/en-us/powershell/module/azurerm.network/set-azurermnetworksecuritygroup?view=azurermps-6.11.0)
An example of how to use it can be found here: https://docs.microsoft.com/en-us/azure/hdinsight/hdinsight-extend-hadoop-virtual-network#azure-powershell

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b8d10aa-ed80-46eb-ade4-1489e64b7921
Version Independent ID: 4ee8e50e-3360-895c-92c9-d4621c9e0c89
Content: Filter network traffic - Azure PowerShell
Content Source: articles/virtual-network/tutorial-filter-network-traffic-powershell.md
Service: virtual-network
GitHub Login: @jimdial
Microsoft Alias: jdial

Hi Travis, I guess you are referring to my provided links, I agree that the new cmdlet should only create it. However, in the article I was referring to and raised the issue https://docs.microsoft.com/en-us/azure/virtual-network/tutorial-filter-network-traffic-powershell the Set-AzureRmNetworkSecurityGroup is missing because you are creating two rules. See:
https://docs.microsoft.com/en-us/azure/virtual-network/tutorial-filter-network-traffic-powershell#create-a-network-security-group-1
$webRule = New-AzureRmNetworkSecurityRuleConfig
$mgmtRule = New-AzureRmNetworkSecurityRuleConfig
$nsg = New-AzureRmNetworkSecurityGroup `
  -ResourceGroupName myResourceGroup `
  -Location eastus `
  -Name myNsg `
  -SecurityRules $webRule,$mgmtRule

@mark-mit-k I was able to follow the example and create a new Network Security Group with the 2 security rules using only the New-AzureRmNetworkSecurityGroup cmdlet. Please let me know if you are unable to do the same.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


feat(core): add if-match to OpWrite

Which issue does this PR close?
Closes #5359. similar to what has been done in #5305, please review the code🙏
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
Add op.write_with(path, content).if_match("<etag>")

Seems ceph rados s3 doesn't support write_with_if_match. Let's add a new config for s3 called disable_write_with_if_match and only enable it for ceph rados s3.

Thank you @Frank-III for working on this! I'm guessing most tests have passed now. Please try merge with main branch to addess the clippy warnings.

Thank you @Frank-III for working on this, really great!

Thank you again for your patient guidance! 😊


[AutoPR sql/resource-manager] Failover database and elastic pool swagger changes

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6365

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/5771


Several bugfixes in Docker build

Removed unnecessary variables
Fixed symbolic links creation
Fixed enter point
Less intermediate containers

Thanks @ogarcia !
Have you tested those changes?

Yes!
If you want you can test it, i have an autobuild in https://hub.docker.com/r/ogarcia/gogs/
docker pull ogarcia/gogs do the magic :wink:

Thanks, merging...


Addquotes: detect automatically common commands

There is a certain number of very common commands such as \ref and all of its variants where the user will never want to add quotes.
I believe it would be a nice quality of life improvement if these cases were not suggested by addquotes.
Steps to reproduce :
0) Write a PhD thesis

Write \ref{fig:grammar} with a grammar notion
Execute knowledge addquotes -t myfile.tex
For every single reference containing grammar, addquotes will offer you to add quotes.

Duplicate of #22.


Fancy chunk initialization method

Currently at many places in our code we have two nested for looks like this:
for q in 0..CHUNK_SIZE {
    for r in 0..CHUNK_SIZE { ... }
}

I want to replace this by
Chunk::with_pillars(|q, r| ... )

EDIT: I guess the closure should get one AxialPoint as parameter instead of q and r...

Me and Andy would take this issue

One closure example:
fn greet_multiple_people<F>(greeter: F) where F: FnMut(String) -> bool {
    let result1 = greeter("peter".to_string());
    let result2 = greeter("anna".to_string());
    if result1 && result2 {
        println!("everything worked well!");
    }
}

greet_multiple_people(|name| {
    println!("hi {}", name);
    true
});


raw_disk: move packages to manifest

Closes #616
Signed-off-by: Itxaka<EMAIL_ADDRESS>

Not sure about the format
This way its expandable in the future if we need more parameters per package, but on the other side its more complicated than a list of packages...


Update PortingGuide.rst

fix typo

Thank you for the correction! Ordinarily contributions require a signed CLA but for a simple typo we can overlook that.


fix: replace new lines in constant attributes with escaped new lines

Fixes #115

The attributes were being parsed properly, however when generating into _templ.go files the strings were being broken.


"children" table is missing

gmsv_workshop's steamworks.FileInfo:
> steamworks.FileInfo("2790156152", PrintTable)...
["banned"] = false
["created"] =<PHONE_NUMBER>
["description"] = maps and addons for Ebic Sad Bunch Trouble in Terrorist Town gaming NO traitor testers NO traitor traps NO traitor rooms NO rooftops
["fileid"] =<PHONE_NUMBER>
["id"] = -1504811144
["owner"] =<PHONE_NUMBER>1705338
["previewid"] =<PHONE_NUMBER>
["previewsize"] = 90788
["previewurl"] =
["size"] = 90788
["tags"] = Addon,map,Water,ServerContent
["title"] = ESB TTT with unvivianed maps
["updated"] =<PHONE_NUMBER>

gmod's steamworks.FileInfo:
] lua_run_cl steamworks.FileInfo("2790156152", PrintTable)
["banned"]	=	false
["children"]:
		[1]	=	144558171
		[2]	=	145316417
		[3]	=	164942659
		[4]	=	345337612
		[5]	=	376339464
		[6]	=	488752776
		[7]	=	749663718
		[8]	=<PHONE_NUMBER>
		[9]	=<PHONE_NUMBER>
		[10]	=<PHONE_NUMBER>
		[11]	=<PHONE_NUMBER>
		[12]	=<PHONE_NUMBER>
		[13]	=<PHONE_NUMBER>
		[14]	=<PHONE_NUMBER>
		[15]	=<PHONE_NUMBER>
		[16]	=<PHONE_NUMBER>
		[17]	=<PHONE_NUMBER>
		[18]	=<PHONE_NUMBER>
		[19]	=<PHONE_NUMBER>
		[20]	=<PHONE_NUMBER>
		[21]	=<PHONE_NUMBER>
		[22]	=<PHONE_NUMBER>
		[23]	=<PHONE_NUMBER>
		[24]	=<PHONE_NUMBER>
		[25]	=<PHONE_NUMBER>
		[26]	=<PHONE_NUMBER>
		[27]	=<PHONE_NUMBER>
		[28]	=<PHONE_NUMBER>
		[29]	=<PHONE_NUMBER>
		[30]	=<PHONE_NUMBER>
		[31]	=<PHONE_NUMBER>
		[32]	=<PHONE_NUMBER>
		[33]	=<PHONE_NUMBER>
		[34]	=<PHONE_NUMBER>
		[35]	=<PHONE_NUMBER>
		[36]	=<PHONE_NUMBER>
		[37]	=<PHONE_NUMBER>
		[38]	=<PHONE_NUMBER>
		[39]	=<PHONE_NUMBER>
		[40]	=<PHONE_NUMBER>
		[41]	=<PHONE_NUMBER>
		[42]	=<PHONE_NUMBER>
		[43]	=<PHONE_NUMBER>
		[44]	=	551416188
["created"]	=<PHONE_NUMBER>
["description"]	=	maps and addons for Ebic Sad Bunch Trouble in Terrorist Town gaming NO traitor testers NO traitor traps NO traitor rooms NO rooftops
["disabled"]	=	false
["down"]	=	0
["fileid"]	=<PHONE_NUMBER>783503880
["id"]	=<PHONE_NUMBER>
["installed"]	=	false
["owner"]	=<PHONE_NUMBER>1705338
["ownername"]	=	wget
["previewid"]	=<PHONE_NUMBER>783503880
["previewsize"]	=	90788
["previewurl"]	=	https://steamuserimages-a.akamaihd.net/ugc/1844795141783503880/812AA84F48735762E0596CBEEDE3C6207086D9C5/
["score"]	=	0.53271025419235
["size"]	=	90788
["tags"]	=	Addon,map,Water,ServerContent
["title"]	=	ESB TTT with unvivianed maps
["total"]	=	7
["up"]	=	7
["updated"]	=<PHONE_NUMBER>
["visibility"]	=	0

srcds and gmsv_workshop version:
version
Protocol version 24
Exe version 2023.06.28 (garrysmod)
Exe build: 19:02:32 Mar 21 2024 (9246) (4000)
GMod version 2024.03.21, branch: unknown
Linux 32bit Dedicated Server
lua_run print(steamworks.gmsv_workshop)
> print(steamworks.gmsv_workshop)...
2.2.7

Same problem, the children field is an important part of the FileInfo function, it is strange that it is not filled with get_children, considering that .include_children(true) is used in the query.
I also note that the id field sometimes has an overflowed value due to using push_integer instead of push_number.
@WilliamVenner


Nvidia Shield TV pro - unrecognized device

I installed plugin, installed ADB tools inside Homebridge server
Device config is bellow. IP is correct and is reachable
HB is authorized in Shield for adb over network
Shield is visible and added to Home app

--> Still getting error in HB which says Unrecognized device
--> In Home app Shield is shown as OFF but should be shown as ON
Device:
Nvidia Shield TV pro
adb tcp 5555 without error
homebridge@raspberrypi:/var/lib/homebridge $ adb connect <IP_ADDRESS>:5555
already connected to <IP_ADDRESS>:5555

homebridge@raspberrypi:/var/lib/homebridge $ adb --version
Android Debug Bridge version 1.0.39
Version 1:8.1.0+r23-5
Installed as /usr/lib/android-sdk/platform-tools/adb
[03/07/2022, 14:59:24] [HomebridgeADB]
WARNING:
Unrecognized accessory - "Nvidia Shield".
Please check if the accessory's IP address is correct.
If your accessory is turned OFF, please turn it ON.
[03/07/2022, 14:59:24] Nvidia Shield E02F is running on port 32971.
[03/07/2022, 14:59:24] Please add [Nvidia Shield E02F] manually in Home app. Setup Code: xxx-xx-xxx
[03/07/2022, 14:59:24] Nvidia Shield Playback Sensor 9DE5 is running on port 37683.
[03/07/2022, 14:59:24] Please add [Nvidia Shield Playback Sensor 9DE5] manually in Home app. Setup Code: xxx-xx-xxx
[03/07/2022, 15:05:32] [HomebridgeADB] Nvidia Shield - Awake
[03/07/2022, 15:05:33] [HomebridgeADB] Nvidia Shield - Playback - On
[03/07/2022, 15:05:43] [HomebridgeADB] Nvidia Shield - Playback - Off
HomeBridge config:
"accessories": [
{
"name": "Nvidia Shield",
"ip": "<IP_ADDRESS>",
"path": "/usr/bin/adb",
"mac": "48:b0:2d:65:2d:37",
"timeout": 1000,
"interval": 1000,
"category": "TV_STREAMING_STICK",
"hidenumber": true,
"hidehome": true,
"hideother": true,
"playbacksensor": true,
"skipSpeaker": true,
"upbutton": "KEYCODE_DPAD_UP",
"downbutton": "KEYCODE_DPAD_DOWN",
"leftbutton": "KEYCODE_DPAD_LEFT",
"rightbutton": "KEYCODE_DPAD_RIGHT",
"selectbutton": "KEYCODE_ENTER",
"backbutton": "KEYCODE_BACK",
"playpausebutton": "KEYCODE_MEDIA_PLAY_PAUSE",
"infobutton": "KEYCODE_HOME",
"poweron": "KEYCODE_POWER",
"poweroff": "KEYCODE_POWER",
"volumeup": "KEYCODE_VOLUME_UP",
"volumedown": "KEYCODE_VOLUME_DOWN"
}
],
"platform": "HomebridgeADB"
}
],

One last set of "gotchas"...

you must add ":5555: to the IP address - you'll have to do this in the Homebridge config file as the plugin's web UI won't let you, e.g.:

"ip": "<IP_ADDRESS>:5555",

You must set the category as "Streaming Stick" e.g.:

"category": "TV_STREAMING_STICK",

You must set the path to the correct version of adb, e.g.

"path": "/snap/bin/android-tools.adb",

Hello @RobotLimeLtd would you be so kind to explain to me like I'm five.
I'm pretty sure my setup is all over the place and probably why your instructions aren't working for me. if you think I would be better off starting my server from scratch idc, I just really want to get my Shield TV in Homekit again like before. Following your steps
1- do I run all of the command in homebridge commmand line? if yes, do I need to change something or run it right from this section? pi@homebridge:/var/lib/homebridge $
or do I log into my Pi directly and do it from there.
2- if the answer was pi I guess I have two users to login. (pi or homebridge) why I don't know.
now after following all your steps I did notice my shield asked for the permission. That is something I've not seen in a long time so that's progress. Thank you! :D
What would you suggest I do?

@RobotLimeLtd One more thing. What do you mean when you said this? and comment out the line /usr/lib/arm-linux-gnueabihf/libarmmem-${PLATFORM}.so
When I follow this, the command is already there. Do I need to delete it or type it again. That is one step I'm missing. Thank you!

I’m trying to install this inside a docker container on my raspberry pi since I ran into the same problems everyone else is. In the Homebridge terminal, after installing snapd, when I type snap install core it gives me the following error:
error: cannot communicate with server: Post "http://localhost/v2/snaps/core": dial unix /run/snapd.socket: connect: no such file or directory
Any ideas how to proceed?

@SawkeeReemo I'm having the same issues too, did anyone ever find a fix for running Homebridge-ADB in a docker container?

@SawkeeReemo I'm having the same issues too, did anyone ever find a fix for running Homebridge-ADB in a docker container?

Pardon the lag, I missed your message here. And unfortunately no, there doesn't seem to exist a way to make this work anymore. I've been trying to figure it out for months. I just gave up.


Added home in navbar redirecting to home

Description
Closes #201

This PR does the following:

Adds ...
Fixes ...
Updates ...

Related Issues
Link any related issues using the format Fixes #issue_number.
This helps to automatically close related issues when the PR is merged.

Placeholder: "Fixes #123"

Changes
List the detailed changes made in this PR.

Added a new feature to ...
Refactored the ...
Fixed a bug in ...

Testing Instructions
Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

Pull this branch.
Run npm install to install dependencies.
Run npm test to execute the test suite.
Verify that ...

Screenshots (if applicable)
Add any screenshots that help explain or visualize the changes.
Additional Context
Any additional context or information that reviewers should be aware of.

This PR is based on the following...

Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

@Trisha-tech Please merge this when u are free

@Trisha-tech Also merge this Please... Tomorrow is the final date for gssoc24... Please

@Trisha-tech Also merge this Please... Tomorrow is the final date for gssoc24... Please

Resolve these conflicts @arunimaChintu

@Trisha-tech Resolved... Please merge this now


Fix error in env syntax

I was getting
2018/09/23 17:00:20 Failed to parse workflow: error unmarshaling JSON: while decoding JSON: json: cannot unmarshal string into Go struct field ScriptTemplate.env of type v1.EnvVar

before this change

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Sharing is all or nothing?

https://github.com/kbase/nextgen/blame/master/docs/challenges/data.md#L28
Can you elaborate on this? I'm not quite sure what you're getting at here.

cf. larger discussion, the idea is there are no "types" of sharing. clearly, there is a spectrum of opinion as to whether that is a good thing.


Pylance can be slow in returning intellisense

I'm seeing this on a project with a single Notebook. @rchiodo mentioned opening an issue here and this one looks relevant.
Environment
OS: Windows 11 22000.466
VS Code: 1.64.0-Insiders
Jupyter: v2022.1.1001755318
Pylance: 0.18.1
Logs
https://gist.github.com/burkeholland/6f7deb0730456cc239db58c1eac8a59f
Video
https://user-images.githubusercontent.com/686963/151440515-cb083cb5-b08e-48ba-83b9-c4c1d523c206.mp4
Project to reproduce
https://github.com/claudiaregio/data-science
Originally posted by @burkeholland in https://github.com/microsoft/pylance-release/issues/1338#issuecomment-1023623014

We should handle this case and timeout the pylance results.

Going to timeout the pylance results.

Possibly related to:
https://github.com/microsoft/pylance-release/issues/1338
https://github.com/microsoft/pylance-release/issues/2313
https://github.com/microsoft/pylance-release/issues/2347

Verification steps:

Install Jupyter, Python, and Pylance extensions
Create jupyter notebook
Add code that loads a csv file or creates a pandas dataframe (like so:)

import pandas as pd
df = pd.DataFrame([[0, 1, 2], [1, 2, 3], [2, 3, 4]], columns=['A', 'B', 'C'])

Create new cell and try to bring up intellisense for df.C

It should take at most 2 seconds (max timeout)


Synced Cron stopped working

Synced Cron just stopped working entirely. Only these errors are in the logs:
Exception in setTimeout callback: MongoError: driver is incompatible with this server version
[<IP_ADDRESS>]     at Object.Future.wait (/bundle/bundle/programs/server/node_modules/fibers/future.js:420:15)
    at MongoConnection.<anonymous> (packages/meteor/helpers.js:119:1)
[<IP_ADDRESS>]     at MongoConnection.(anonymous function) (packages/mongo/mongo_driver.js:736:49)
    at MongoConnection.mongoConnectionProto.(anonymous function) [as insert] (packages/meteorhacks_kadira/lib/hijack/db.js:62:1)
[<IP_ADDRESS>]     at OptimizedApply (packages/meteorhacks_kadira/lib/utils.js:31:1)
    at Object.ret.(anonymous function) (packages/meteorhacks_kadira/lib/hijack/db.js:20:1)
[<IP_ADDRESS>]     at Object.CollectionHooks.defineAdvice.self (packages/matb33_collection-hooks/insert.js:48:1)
    at Object.collection.(anonymous function) [as insert] (packages/matb33_collection-hooks/collection-hooks.js:117:1)
[<IP_ADDRESS>]     at [object Object].insert (packages/mongo/collection.js:507:37)
    at packages/percolate_synced-cron/synced-cron-server.js:203:1
[<IP_ADDRESS>]     at scheduleTimeout (packages/percolate_synced-cron/synced-cron-server.js:266:1)
    at packages/percolate_synced-cron/synced-cron-server.js:314:1
[<IP_ADDRESS>]     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
    at packages/meteor/timers.js:6:1
[<IP_ADDRESS>]     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:110:1)
    - - - - -
[<IP_ADDRESS>]     at Object.toError (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/utils.js:114:11)
[<IP_ADDRESS>]     at Object.__executeInsertCommand [as executeInsertCommand] (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/db.js:1926:27)
    at [object Object].execute_writes (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/base.js:133:15)
[<IP_ADDRESS>]     at /bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/repl_set/ha.js:201:41
    at /bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/db.js:1905:9
[<IP_ADDRESS>]     at Server.Base._callHandler (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/base.js:453:41)
    at /bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/server.js:488:18
[<IP_ADDRESS>]     at [object Object].MongoReply.parseBody (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/responses/mongo_reply.js:68:5)
    at [object Object].<anonymous> (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/server.js:446:20)
[<IP_ADDRESS>]     at [object Object].emit (events.js:95:17)
    at [object Object].<anonymous> (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/connection_pool.js:207:13)
    at [object Object].emit (events.js:98:17)
[<IP_ADDRESS>]     at Socket.<anonymous> (/bundle/bundle/programs/server/npm/node_modules/meteor/npm-mongo/node_modules/mongodb/lib/mongodb/connection/connection.js:440:22)
    at Socket.emit (events.js:95:17)
[<IP_ADDRESS>]     at Socket.<anonymous> (_stream_readable.js:765:14)
    at Socket.emit (events.js:92:17)

are you sure it's this package problem? I see meteorhacks_kadira, matb33_collection-hooks between the  method call from this package and the error you get

This is the only error I saw in the log. I guess it might have to do with us using mongo 3.2 thus the incompatible driver. I schedule a job to clear completed jobs in cronHistory regularly, and the error hasn't appeared again. Is there anything wrong with this solution?

Exception in setTimeout callback: MongoError: driver is incompatible with this server version
Please use a compatible mongo to fix this issue


Add an option to remove blocks inside the schematic (blocks not visible from the outside) to make said schematic hollow

This is already how the voxelising process works. Triangles in the mesh directly converted into blocks and that'll result in the structure being hollow. Do you have more info about the problem you're having?

Closed as stale.


[Feature] skywalking-php defined instance name

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
I have release customize instance_name in skywalking-php, maybe it will be useful
I'm not Rust programmer, sorry for miss guidelance
https://github.com/Almot77/skywalking-php/commit/2f2d2d503d8be49bdf577d42a4bc703825776592
Add two options to skywalking_agent.ini:
; Defined agent instance name
skywalking_agent.instance_name = myservername
; Use hostname as agent instance name
skywalking_agent.use_hostname_as_instance_name = On
If two options both enabled - second has higher priority.
Use case
instance_name has rnd + ip address, i defined it in config or use hostname.
If you have one instance on host and multiple hosts - it would be comfortably.
Related issues
No response
Are you willing to submit a pull request to implement this on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

$HOSTNAME is a Bash variable that's set automatically.
But it's not a Bash environment variable (i. e. it's not passed in environment to child processes). One can check this by looking at env output
$ echo $BASH_VERSION
5.1.16(1)-release
$ echo $HOSTNAME
srvdocker03
$ env | grep HOSTNAME
$

The php-fpm.conf also should enable the pool configuration item, such as env[HOSTNAME] = $HOSTNAME.
Since users can set php.ini through environment variables, there is no need to consider what shell the user is using, what the environment is like, and so on.

Okay, you close.
But we havent't now skywalking_agent.instance_name option, right ? )
May be you add it in next release ?

You could continue the discussion if needed.

Leave only skywalking_agent.instance_name option:
https://github.com/Almot77/skywalking-php/tree/defined_instance_name

Welcome to PR.

Added by https://github.com/apache/skywalking-php/pull/111

Thank you! My first open source PR and contribute :)


Add memoryOnlyKeys setter option to Onyx

Details
Guides continue to experience really bad performance that we now know is in part related to the IndexedDB code and the synchronous setting of each key one at a time. This is a performance improvement with smaller data sets, but ends up creating a ton of blocking time when these datasets are large.
Related Issues
https://github.com/Expensify/App/issues/21766
Automated Tests
Since this is an opt-in behavior and bandaid solution for now I didn't write any tests.
Linked PRs
https://github.com/Expensify/App/pull/22729

Tested here: https://github.com/Expensify/App/pull/22729#issuecomment-1631800646


Separate main video events from ad events

Currently the VAST preroll triggers the play, end etc events, which makes it hard to use (thought of counting the events, but preroll/ads will not always play).
Solution, create a set of events for the main video, and another for the ads.
Thanks

@sp4r74cus - can you please confirm if the issue is still reproducible ?

Moving the ticket to closed since there is no input from the reporter .


[CERT-TEST-FAILURE] [TC-DGGEN-2.1] - Test Failed

Feature Area
Other
Test Case
TC-DGGEN-2.1
Reproduction steps
Execute the below mentioned command to put DUT into a commissionable state,
 ./chip-all-clusters-app --KVS ./mytest.txt
Once DUT reach the  commissionable state, sent below mentioned command on TH.
 ./chip-tool pairing onnetwork 1 20202021
After a successfully paired sent mentioned command from TH
Verifying the Step 3(reboot-count attribute)
1 .TH reads a RebootCount attribute value from DUT.
./chip-tool generaldiagnostics read reboot-count 1 0
On TH(chip-tool), Verify that RebootCount attribute data type must be UINT16

[1692697157.169409][4935:4937] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0033 Attribute 0x0000_0001 DataVersion: 629105351
[1692697157.169523][4935:4937] CHIP:TOO:   RebootCount: 1

after reading  RebootCount attribute reboot the DUT, by killing DUT more than 2 times and launch again, without commission follow the next steps

./chip-tool generaldiagnostics read reboot-count 1 0
The  reboot-count count should match with the number of rebooted times

[1692697170.581354][4938:4940] CHIP:DMG: }
[1692697170.581583][4938:4940] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0033 Attribute 0x0000_0001 DataVersion:<PHONE_NUMBER>
[1692697170.581692][4938:4940] CHIP:TOO:   RebootCount: 4

Factory reset on DUT using the mentioned command and launch again, without commission follow the next steps
sudo rm -rf /tmp/chip_*

`./chip-tool generaldiagnostics read reboot-count 1 0``
On TH(chip-tool), Verify that RebootCount attribute  value set to 0

[1692697194.341566][4942:4944] CHIP:TOO: Endpoint: 0 Cluster: 0x0000_0033 Attribute 0x0000_0001 DataVersion:<PHONE_NUMBER>
[1692697194.341654][4942:4944] CHIP:TOO:   RebootCount: 1

As per Spec and Test-plan Expectation after Factory Reset the DUT, Reboot Count attribute value -
Expected value  : 0
Actual value : 1
Bug prevalence
everytime
GitHub hash of the SDK that was being used
5ca8bec0a813c51f82a55da4b8bfffa32546248e
Platform
raspi
Anything else?
As per Spec :

The RebootCount attribute SHALL indicate a best-effort count of the number of times the Node has rebooted. The RebootCount attribute SHOULD be incremented each time the Node reboots. The RebootCount attribute SHALL NOT be incremented when a Node wakes from a low-power or sleep state. The RebootCount attribute SHALL only be reset to 0 upon a factory reset of the Node.

and Test-plan expecting  :

The data type must be UINT16 and the count should match with the number of rebooted times. A low power or sleep shall not count as a reboot. Upon the factory reset, the count shall be set to 0.

As per Spec and Test-plan Expectation after Factory Reset the DUT, Reboot Count attribute value should be set to 0 instead of 1
Execution Logs :
TC-DGGEN-2.1_DUT.txt
TC-DGGEN-2.1_TH.txt
Test-plan Reference :
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/general_diagnostics.adoc#tc-dggen-2-1-attributes-dut_server
Spec Reference :
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/service_device_management/DiagnosticsGeneral.adoc#rebootcount-attribute

After factory reset, it should be either 1 or 0, doesn't matter. As long as subsequent reboots increment, we are good. I think "reboot count" can be interpreted differently by different people since it's unclear in spec. So the reboot count is set to 0 after factory reset, but can it be set to 1 during first boot? That's the question...

Can you please check Linux platform implementation, in the configuration manager, what the impl is?

For me it seems to make sense that "I reboot, so I increase the counter" results in "first time reboot (after factory reset), the counter is 1 ... since i rebooted". I don't think trying to make sure it is 0 after factory reset is worth the extra effort. If spec demands that we should fix the spec.

"The RebootCount attribute SHALL only be reset to 0 upon a factory reset of the Node." I interpret this as factory reset sets it to 0. However if implementation reboots after factory reset (I imagine most do) then we reboot and the count then should be 1.
We should fix our tests.


Form data handling hangs with ASyncApp

Here is the reproduction:
from apistar import ASyncApp as App, Route, types, validators, http

class Product(types.Type):
    name = validators.String(max_length=100)
    rating = validators.Integer(minimum=1, maximum=5)
    in_stock = validators.Boolean(default=False)
    size = validators.String(enum=['small', 'medium', 'large'])

async def create_product(product: Product):
    print("CREATE A PRODUCT")

app = App(
    routes=[
        Route('/', method='POST', handler=create_product),
    ]
)

if __name__ == '__main__':
    app.serve('<IP_ADDRESS>', port=5000, debug=True)

Running this app and trying to make a POST request (tested with Wget and cURL), I get my request hanging forever:
$ wget --post-data='name=123' http://<IP_ADDRESS>:5000/
--2018-06-03 22:02:04--  http://<IP_ADDRESS>:5000/
Connecting to <IP_ADDRESS>:5000... connected.
HTTP request sent, awaiting response... ^C

$ curl -v --data name=123 'http://<IP_ADDRESS>:5000/'
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 5000 (#0)
> POST / HTTP/1.1
> Host: <IP_ADDRESS>:5000
> User-Agent: curl/7.60.0
> Accept: */*
> Content-Length: 8
> Content-Type: application/x-www-form-urlencoded
>
* upload completely sent off: 8 out of 8 bytes
^C

Once I change ASyncApp to App and drop all the async markers, thus, reverting to the sync style, everything works just fine.
from apistar import App as App, Route, types, validators, http

class Product(types.Type):
    name = validators.String(max_length=100)
    rating = validators.Integer(minimum=1, maximum=5)
    in_stock = validators.Boolean(default=False)
    size = validators.String(enum=['small', 'medium', 'large'])

def create_product(product: Product):
    print("CREATE A PRODUCT")

app = App(
    routes=[
        Route('/', method='POST', handler=create_product),
    ]
)

if __name__ == '__main__':
    app.serve('<IP_ADDRESS>', port=5000, debug=True)

My environment:

Arch Linux, x64, 4.16.12
Python 3.6.5
Apistar 0.5.26

Duplicate of #489, resolved by #501.


xcode 7.1 - include of non-modular header inside framework module 'SSKeychain.SSKeychain'

Anyone else getting this error in SSKeychain.h? It started after the 7.1 update.

How do you solve?

+1

If you are only using objective-c this should help
http://stackoverflow.com/questions/27776497/include-of-non-modular-header-inside-framework-module
Im having more issues since im using seift

This isn't fixed for swift.

@heshamsalman can you try master?


Replica behavior without an HPA

The documentation states that the autoscalerRef section is optional, and we have a few deployments that do not use HPA's.  However, I noticed that the canaries with these HPA less Deployments only ever scale to one pod during testing/rollout, etc... The original deployment object has replicas of 8, and the -primary deployment also has 8 after canary creation.  But when flagger takes over it drops the replicas to 1 on the original deployment during the whole rollout test.  So 50% traffic swing is impractical.  If I test with an HPA that has min/max set to the static deployment replicas, it works, though it still spins up 8, then goes down to 1, then back to 8 before rollout.
What is the expected behavior with no autoscaleRef setup?  Am I missing something?  The following code seems to be where the static replica of 1 is coming from and I don't see where flagger would scale up the replicas based on the deployment replicas?
if shouldAdvance {
c.recordEventInfof(cd, "New revision detected! Scaling up %s.%s", cd.Spec.TargetRef.Name, cd.Namespace)
c.sendNotification(cd, "New revision detected, starting canary analysis.",
true, false)
if err := c.deployer.Scale(cd, 1); err != nil {
c.recordEventErrorf(cd, "%v", err)
return false
}

Yes I should've mention that a HPA with an equal number of min/max replicas should be used when your app needs more than one replica. In the next canary version I'll make the HPA a requirement.

Sorry to bump a closed issue, but is making HPA a requirement an absolute necessity here? We just transitioned from using HPAs to VPAs for our deployments as an experiment, and VPAs and HPAs should not be used together (https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler#limitations-of-beta-version). If this change is made we basically have to revert this change to be able to continue using Flagger or stay on an old version of Flagger.

@tanordheim the PR that fixed this issue makes Flagger work without a HPA. If you have the replica field in your deployment spec then Flagger will use that instead of relying on HPA to scale up the canary. I haven’t used VPA but I think it will conflict with Flagger since it will change the deployment spec and each time it does that Flagger will restart the analysis. Please test it out and open an issue if that’s the case.


Fixed Ui::calc_text_size

It now passes correct null-ended string to ImGui.

It also would be nice to drop offset argument in calc_text_size. We can always limit the slice length in text.

We could also use something like this:
if offset == 0 {
    let end = start.as_ptr() + start.len_in_bytes() + 1;
    let t = ((*self.api).calc_text_size)(start.as_ptr(), end, 0, -1.0);
    (t.x, t.y)
} else {...}

to prevent copying strings at all. However, I don't know how to calculate end correctly.

Ah good find!
Yeah in this case we don't need to do that as ImGui accepts a end string and. Maybe end can be calculated as (un-tested)
let end = text[..text.len()];
let end_ptr = end.as_ptr();

This works
fn test(text: &str) {
        let ptr = text.as_bytes().as_ptr();
        let end = &text[text.len()..];
        let end_ptr = end.as_bytes().as_ptr();
        println!("ptrs {:?} - {:?}", ptr, end_ptr);
    }

    pub fn main() {
        test("test");
    }


Vulnerability Roundup 33 (master)

Scanned nixos/release-combined.nix @ 3d2948e. Filtered out previously reported CVEs.
See #34055 for open CVEs in release-17.09.
exiv2-0.26 (search, files)

[ ] CVE-2017-18005
[ ] CVE-2018-4868

Cc:  @NixOS/security-notifications, @joepie91, @phanimahesh, @the-kenny, @7c6f434c, @k0001, @peterhoeg, @nh2, @LnL7
Contact @ckauhaus for any questions.

FYI: fixes for both CVEs are now in the master branch of Exiv2. The pull requests that fix both issues are: https://github.com/Exiv2/exiv2/pull/207 and https://github.com/Exiv2/exiv2/pull/199 for CVE-2018-4868 and CVE-2017-18005 respectively.

nixos-17.09 is EOL


Add beam search

Invoke by adding "beam_width": 2 (for example) to /v1/completions POST.
This PR will be moved out of Draft mode after https://github.com/ggerganov/llama.cpp/pull/2267 is merged. Closes #145 Closes #340 Closes #185
In the meantime, there is a question:
How does one specify --logits_all False when invoked from the command line?
python3 -m llama_cpp.server --logits_all False

results in settings.logits_all=True on startup.

results in settings.logits_all=True on startup.

you can pass False with an empty string --logits_all '' but a better way would be to add either action='store_true' to or action=argparse.BooleanOptionalAction

@mattpulver  Guess now you can un-draft this PR.

you can pass False with an empty string --logits_all '' but a better way would be to add either action='store_true' or action=argparse.BooleanOptionalAction when adding argument

When I add --logits_all '' to python -m llama_cpp.server it errors w/
__main__.py: error: argument --logits_all: invalid parse_bool_arg value: ''

In the meantime I changed the default setting for logits_all from True to False: 3fce944
but I welcome any better suggestions. (I'm not sure where exactly to make the action='store_true' suggestion.)

Testing

Start the web server.
Go to http://localhost:8000/docs (adjust port as needed)
Open/click the POST /v1/completions panel.
Press the Try it out button.
Edit the Example Value json by adding "beam_width": 2,
Press Execute

If you would like to see how the beams evolve and their probabilities, uncomment:
    #print(f"\n\nCurrent beams (last_call={beams_state.last_call}):\n")
    #for i in range(beams_state.n_beams):
    #    print(f"beams[{i}]", beam_view_to_string(callback_data.ctx,beams_state.beam_views[i]))

in llama_cpp/llama.py.

@mattpulver great work here, I'll review this and should have it merged this week.
Cheers

@abetlen Thanks. Perhaps the most intrusive integration change is changing the default value of the logits_all command line parameter from True to False: 3fce944a9acb574407ee9ce6998530ea6f072915
This actually matches the default value of llama.cpp so in a broader sense this makes sense IMO but it may break some existing functionality.

@mattpulver just a quick update, I'm going to hold of merging this until after #771 because that's going to have some big impact on how we use the llama.cpp api internally in the Llama class. Once that's in I'll take a look at dealing with the merge conflicts here. One thing to note, I won't change the default behaviour of logits_all, this would constitute a breaking change for a number of users so we need to find a better solution (automatially reload the model with logits_all=False) or inform the user that it has to be set to false for beam search.

I don't understand what changed, but now I am consistently hitting GGML_ASSERT: llama-cpp-python/vendor/llama.cpp/llama.cpp:5967: n_tokens <= n_batch with this applied to the latest llama-cpp-python.
beam.tokens.size() ends up at 513 here, which is one more than the batch size: https://github.com/ggerganov/llama.cpp/blob/master/llama.cpp#L7849-L7852
// beam is not at end-of-sentence, so branch with next top_k tokens.
if (!beam.tokens.empty()) {
    llama_decode(ctx, llama_batch_get_one(beam.tokens.data(), beam.tokens.size(), n_past, 0));
}

This is from a local fork of llama.cpp so I'm not 100% sure that some other change I applied isn't interfering. Will test further.

Thanks @mattpulver for the PR (both here and in the llama.cpp repo)
Curious if abelten, cebtenzzre, or someone else knows if/when this will get merged? I've found beam search extremely helpful for code generation, and would love to know if it'll be supported with the main llama-cpp-python library in the near future, or if I should create a binary from Matt's PR instead.

Hey @rishsriv I'm still planning to merge this however I'm currently grinding through the batch processing support first as it requires a bunch of internal refactoring, after that I was planning on coming back in and merging this. Can't give an eta though, likely in the next few weeks if I had to guess.

Got it – thank you for the response! If there are things you think external contributors will be able to fix, please do open an issue and will be happy to help fix it.

If I wait a little longer, I consistently hit GGML_ASSERT: llama-cpp-python/vendor/llama.cpp/llama.cpp:5967: n_tokens <= n_batch with this applied to the latest llama-cpp-python.

Possibly related: ggerganov/llama.cpp#6664

Any update on this ?

Alright so I copied the changed into a local clone and it seems to be working, or running at least.
First it spend a crazy time on llama_cpp.llama_beam_search then the token output is quite low. which makes the sampling time insanely high.
beam_width=1
HEAD MASTER :
llama_print_timings:        load time =     154.96 ms
llama_print_timings:      sample time =    1534.47 ms /   548 runs   (    2.80 ms per token,   357.13 tokens per second)
llama_print_timings: prompt eval time =     371.38 ms /  1661 tokens (    0.22 ms per token,  4472.54 tokens per second)
llama_print_timings:        eval time =    4816.73 ms /   547 runs   (    8.81 ms per token,   113.56 tokens per second)

This fork :
llama_print_timings:        load time =     127.43 ms
llama_print_timings:      sample time =   59429.62 ms /     1 runs   (59429.62 ms per token,     0.02 tokens per second)
llama_print_timings: prompt eval time =     338.67 ms /  1661 tokens (    0.20 ms per token,  4904.55 tokens per second)
llama_print_timings:        eval time =   58430.05 ms /  6530 runs   (    8.95 ms per token,   111.76 tokens per second)

59429.62 ms per token


perf(PeriphDrivers): Remove Redundant if Statement in I2C Rev A

Description
Close #753
Checklist Before Requesting Review

[x] PR Title follows correct guidelines.
[x] Description of changes and all other relevant information.
[x] (Optional) Link any related GitHub issues using a keyword
[x] (Optional) Provide info on any relevant functional testing/validation.  For API changes or significant features, this is not optional.

Merge from main, should fix the Verify Register/SVD workflow.


Fix typo (proerty -> property)

Summary of the changes (Less than 80 chars)
Fix typo (proerty -> property)
Closes n/a

Thanks for your help!


Feat docker compose

This PR establishes a dockerized environment
It incorporates Dockerfiles for the following components:

Opetator
Aggretor
Anvil tesnet

Type of change

[x] New

To test it, run:
docker-compose build

then
docker-compose up

Stale


Suggestion: More obvious external links in the shownotes

After listening to an episode, i often check the shownotes to check out the stuff that was talked about in the episode.
Today, all links are a gray color, regardless of if it's a sponsor, a link to a specific timestamp in the episode, the usual links to Wes and Scott's Twitter/Instagram, or external links to stuff mentioned in the episode.
It would be great if the external links would be easier to spot.

Completed in 1886545


Adding support for MacOS

Install location are a little bit different on MacOS, also policies are managed through .plist instead of policies.json

@ffprivacy
Thanks for your contribution. LG2M


Alternative implementation of StaticStructural

This PR proposes an alternative implementation of StaticStructural from #9:

We add KeyPaths and BaseType to the structural representations.
StaticStructural is implemented as a regular structural of a zero value.
Additionally, as an example show how to allKeyPaths on top of it.

In contrast to #9 this approach does not require duplication of the API to provide new representation types for static counterparts.

/cc @dabrahams

This has been an interesting experiment, but we decided to postpone this for now. We might revisit it later.


Check for NULL locks

This will happen if a library calls SSL_CTX_free() in its destructor, which runs after OpenSSL's atexit() handler OPENSSL_cleanup() has already destroyed all the locks. This commit fixes a SEGV in that case.
Related to #23575

Checklist

Given the myriad of ways that the atexit behavior can go wrong, I don't think it makes sense to play whack-a-mole trying to patch individual functions for broken invariants. Doing so could even obscure more serious problems. For example, if an fd to /dev/urandom is closed but not reset to -1, another part of the program could open another fd in its place, and then your program may silently use bad entropy in a security-critical component.
The only real fix is for OpenSSL to not tear itself down while it may still be in use.

your program may silently use bad entropy in a security-critical component.

So you're saying it's better for a security-critical component to crash and become a denial of service, than to detect an error and return an error code.
Except you're being inconsistent, since the same kind of check already exists just a few lines further down in the  current code:
https://github.com/openssl/openssl/blob/1a571a59759465812b71f8f1ff3bcbd786839077/crypto/threads_pthread.c#L711

Btw, your fuzzcheck job failed because it's out of disk space.
https://github.com/hyc/openssl/actions/runs/7944169917/job/21689368952
2024-02-17T20:57:10.4107118Z /usr/bin/ld: final link failed: No space left on device
2024-02-17T20:57:10.4112347Z /usr/bin/ld: final link failed: No space left on device
2024-02-17T20:57:10.4319161Z clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
2024-02-17T20:57:10.4333353Z make[1]: *** [Makefile:19005: test/fatalerrtest] Error 1
2024-02-17T20:57:10.4338346Z make[1]: *** Waiting for unfinished jobs....
2024-02-17T20:57:10.4346369Z clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
2024-02-17T20:57:10.4364303Z make[1]: *** [Makefile:18960: test/exdatatest] Error 1
2024-02-17T20:57:10.6447205Z /usr/bin/ld/usr/bin/ld: final link failed: : final link failed: No space left on deviceNo space left on device
2024-02-17T20:57:10.6448514Z
2024-02-17T20:57:10.6624368Z clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
2024-02-17T20:57:10.6639259Z make[1]: *** [Makefile:19044: test/fips_version_test] Error 1
2024-02-17T20:57:10.6640359Z clang-15: error: linker command failed with exit code 1 (use -v to see invocation)
2024-02-17T20:57:10.6656258Z make[1]: *** [Makefile:19029: test/ffc_internal_test] Error 1
2024-02-17T20:57:10.6657504Z make[1]: Leaving directory '/src/openssl32'
2024-02-17T20:57:10.6691625Z make: *** [Makefile:2879: build_sw] Error 2
2024-02-17T20:57:14.2947813Z 2024-02-17 20:57:14,294 - root - ERROR - Building fuzzers failed.
2024-02-17T20:57:14.2949146Z 2024-02-17 20:57:14,294 - root - ERROR - Error building fuzzers for (commit: 1a571a59759465812b71f8f1ff3bcbd786839077, pr_ref: None).

The out of disk space is a known issue

@hyc It's not my CI job. While I contribute to OpenSSL and am quite familiar with the problem space, I'm not a decision maker for project. I work on BoringSSL, which solves this problem by not calling atexit in the first place. However, as OpenSSL does not seem to have decided what they wish to do here, all I can do is offer advice in comments.
This PR may address a symptom, but it ignores the underlying problem and misses that far, far worse symptoms can occur. Ignoring broken invariants piecemeal is a recipe security vulnerabilities. That you're only crashing on NULL dereference is a mercy. For a security-critical component, a clean crash is far better than use-after-free, overflow a buffer, race condition or signing ECDSA with bad entropy. Those will result in much worse! (Of course, it's best to do none of these. The way to do that is to fix OpenSSL to stop calling atexit.)
As for consistency, that's a free function. All free functions in OpenSSL behave like C free and C++ delete in accepting NULL. That's not a broken invariant but happens often as part of normal operation, so it's convenient for free functions to accept NULL. Whereas trying to lock a NULL lock should never happen in normal operation and can only be a broken invariant elsewhere in the system.

So you're saying it's better for a security-critical component to crash and become a denial of service, than to detect an error and return an error code.

If "detect an error and return an error code" would always happen, then no. But since errors in very low-level routines like locks aren't always caught, and can't always be propagated back up the stack (a void function calls something that calls something ... that needs a lock) then there WILL be times that the error is ignored, and there just has to be one unlucky place that this becomes a serious vulnerability.
And "crash and become a denial of service" is definitely better than "serious vulnerability".
With the NULL-pointer crash, it is possible to know what the underlying problem was (lock was destroyed) - if this had been silently ignored and propagated back up the stack to something that was several levels deep it would have been much harder to figure out what had happened.
While I am not a decision maker for the project, I too think this change is potentially unsafe.

I totally agree with @davidben and @tom-cosgrove-arm on this one. The decision maker on technical issues is OTC. If any OTC member disagrees with my triage (resolved: wont fix - i.e., this won't be merged), he can add OTC hold label and it will be discussed by OTC as a whole.

Any reason to keep this open?


libre: 0.5.6 -> 0.5.7

Semi-automatic update. These checks were performed:

built on NixOS
found 0.5.7 with grep in /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7
found 0.5.7 in filename of file in /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7

cc "@raskin"

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘libre-0.5.7’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/libre/default.nix:4 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Partial log (click to expand)
install -m 0644 libre.pc /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7/lib/pkgconfig
install -m 0644 mk/re.mk /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7/share/re
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7
shrinking /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7/lib/libre.so
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7/lib
patching script interpreter paths in /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7
checking for references to /build in /nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7...
/nix/store/3mjrmw1p7h7wcr6d6w6zzb33kk3bljv6-libre-0.5.7

Success on x86_64-linux (full log)
Partial log (click to expand)
install -m 0644 libre.pc /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7/lib/pkgconfig
install -m 0644 mk/re.mk /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7/share/re
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7
shrinking /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7/lib/libre.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7/lib
patching script interpreter paths in /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7
checking for references to /tmp/nix-build-libre-0.5.7.drv-0 in /nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7...
/nix/store/flnmjxr20pwpgi7d35361gh6xwai8d07-libre-0.5.7


Need clarification on strong mode semantics of field overrides

See https://github.com/dart-lang/sdk/issues/29426 for some background.
For a while strong mode disallowed fields in subclasses that overrode fields in superclasses. IIRC, this included getters and setters. Then I thought we had relaxed that. Now we're being asked to produce diagnostics of some form. I need a clearly written specification of what the semantics are in strong mode, including errors and warnings that should be produced.

errr, I think this bug was a misunderstanding! I'm going to close it out :)


Sanitize response message for unathorized headers

Summary
This pull request adds sanitation to the response body when unauthorized headers are added to the request payload. The reason for doing so is to prevent cross-side scripting vulnerabilities.
Resolves #162

Thanks, not the most exploitable vector it seems, but better safe than sorry :)


[MINOR] update dstream.py with more accurate exceptions

Reopened from https://github.com/apache/spark/pull/27525
What changes were proposed in this pull request?
The exception messages for dstream.py when using windows were improved to be specific about what sliding duration is important.
Why are the changes needed?
The batch interval of dstreams are improperly named as sliding windows. The term sliding window is also used to reference the new window of a dstream collected over a window of rdds in a parent dstream. We should probably fix the naming convention of sliding window used in the dstream class, but for now more this more explicit exception message may reduce confusion.
Does this PR introduce any user-facing change?
No
How was this patch tested?
It wasn't since this is only a change of the exception message

Can one of the admins verify this patch?

cc @srowen


[KOGITO-5740] Unnecessary reconciliations triggered for Service

See:  https://issues.redhat.com/browse/KOGITO-5740
Description
Kogito operator isn't able to properly compare Service resources because the deployed Service object has properties ipFamilies and ipFamilyPolicy, while the requested Service object is missing these properties.
The fix I completed is to skip the comparision for ipFamilies and ipFamilyPolicy when the requested Service object is missing these properties. If the requested Service object has these properties, then the comparator will function as usual.
I refactored our custom service comparator to compare only the service spec fields our operator initializes and disabled the default service comparator from operator utils. This ensures the comparator only catches differences in operator specified fields, instead of auto generated fields from the cluster.
Many thanks for submitting your Pull Request :heart:!
Please make sure your PR meets the following requirements:

[ ] You have read the contributors' guide
[ ] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[ ] Pull Request contains a link to the JIRA issue
[ ] Pull Request contains a description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[ ] You've ran make before-pr and everything is working accordingly
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster
[ ] You've added a RELEASE_NOTES.md entry regarding this change

Can one of the admins verify this patch?

@amygaoo, albeit this is a fine workaround, I think the approach we should take here is to compare only the necessary fields, i.e., the ones we set/manage. Take a look here:
https://github.com/kiegroup/kogito-operator/blob/761552207d271d70d6c4f785adb841ae97293103/core/infrastructure/service.go#L42
.
This is the service we create. We should only compare the fields we are interested in. This way, we avoid a similar bug in the future.

This is a good idea, I will look into a way to create a copy of the service with only the required fields for comparision. In this case, the comparator may have a different approach than the other ones.

@amygaoo, albeit this is a fine workaround, I think the approach we should take here is to compare only the necessary fields, i.e., the ones we set/manage.
This is the service we create. We should only compare the fields we are interested in. This way, we avoid a similar bug in the future.

This is a good idea, I will look into a way to create a copy of the service with only the required fields for comparision. In this case, the comparator may have a different approach than the other ones.

@ricardozanini After looking at how our comparators are called, I would like to check that I am on the right track here. Currently we are using the default comparator from Operator Utils to compare services:  https://github.com/RHsyseng/operator-utils/blob/0f7acfb7a492851cad0ca5eb327b85cee0aa7e10/pkg/resource/compare/defaults.go#L383
So with this function we don't have control over which fields are being compared.
I'm thinking that for services we can not set the default comparator, and instead call the default comparator from our custom comparator https://github.com/kiegroup/kogito-operator/blob/ce1f6eda31269bacfea005b4054211ede602a7ba/core/framework/comparator.go#L202
, where we can create a seperate copy of deployed and requested reasources with only the required fields.
Or another option is to create our custom comparator to reuse some of the code from the Operator Utils and then only compare the fields we require.  For this option I'm not sure what the policy is about using code from other repos, and if we are allowed to use it if they have an Apache License 2.0?
What is your take on this? Or is there another option that I am missing?

@amygaoo, I believe we already have some sort of "custom comparator" in our codebase. I remember creating our own. Also, the operator-utils allows injection of custom comparators, so should be pretty straightforward adding our own.

can you please rebase it?

@spolti rebased!

/jenkins test

@radtriste @sutaakar does this fix needs to be on 1.11.1 as well?

That would be great for Product I would say but I think it won't be included into 1.11.1 unless the cherry-pick is done in the next 5 hours ...

@amygaoo Could you cherry-pick this to 1.11.x ?


Proposal for Extracting Load Balancing from the Event Processor

This PR is for discussion of #9051 and demonstrates the key proposed functional refactoring. It keeps all existing tests in tact and doesn't address details such as missing comments.
Summary
There are two primary concerns owned by the current EventProcesorClient implementation

Managing the processing tasks for each partition owned
Managing ownership of partitions

A subset of which is Load balancing of ownership

This PR proposes that EventProcesorClient can offload all of concern 2 into the new PartitionLoadBalancer class.
Changes of Interest

All code dealing with the acquisition and relinquishing of partition ownership moves to PartitionLoadBalancer. This means the following properties and methods migrate over.

RandomNumberGenerator and s_randomSeed
InstanceOwnership (see details below)
ActiveOwnershipWithDistribution
FindAndClaimOwnershipAsync
ClaimOwnershipAsync
RenewOwnershipAsync
RelinquishOwnershipAsync

InstanceOwnership is now encapsulated inside PartitionLoadBalancer as it is mostly no longer a concern of EventProcesorClient. The one exception is the requirement of getting the list of currently owned partitionIds to prune running processor tasks. For this scenario we expose a new property on  PartitionLoadBalancer called OwnedPartitionIds
Error handling newly residing in PartitionLoadBalancer previously serviced by calls to OnProcessErrorAsync are now bubbled up as a EventHubsException with the operation string passed as the exception message. See 4aa3a8fce0c32e77197721c6a56a94888b0e58f1 for an alternate approach using an injected OnProcessErrorAsync. Ultimately I concluded that passing the error handler is more error prone and leaks implementation details across class boundaries.

note: This PR is a comparison to #8816 until it is merged to master

I think the high level makes sense.   There's some naming that we'll probably want to talk about.     The error handling is an interesting twist.   Call me out if I'm missing something but, If I'm reading correctly, each call to RunAsync (which we may want to consider renaming to something like PerformBalancing or ReconsiderOwnership or something) would be the place where the exception would bubble for the critical areas.   The utility methods would also bubble their own.
I think that covers us, as we'd have a deterministic spot for errors to surface that wouldn't result in log-n-forget or wait-until-stopped.    Assuming that's the case, I agree with you in that I like that trade-off better than injecting a handler or having another event-style callback.

I think the high level makes sense. There's some naming that we'll probably want to talk about. The error handling is an interesting twist. Call me out if I'm missing something but, If I'm reading correctly, each call to RunAsync (which we may want to consider renaming to something like PerformBalancing or ReconsiderOwnership or something) would be the place where the exception would bubble for the critical areas. The utility methods would also bubble their own.
I think that covers us, as we'd have a deterministic spot for errors to surface that wouldn't result in log-n-forget or wait-until-stopped. Assuming that's the case, I agree with you in that I like that trade-off better than injecting a handler or having another event-style callback.

That's correct. This approach lets the Processor control how those errors translate to event handlers and leaves the LoadBalancer agnostic. Effectively the handling logic still resides in RunAsync
I was on the fence regarding the naming. Either we could go more specific at the method level, as you suggested, or let the class provide the context as to what RunAsync means, Arguably if all the PartitionLoadBalancer does is run or stop, it's implied that they are starting and stopping load balancing. However, I don't feel strongly either way.

@jsquire Thanks for the comments. Once you confirm you are good with the general approach, I'll button up the details and refactor the tests.

I was on the fence regarding the naming. Either we could go more specific at the method level, as you suggested, or let the class provide the context as to what RunAsync means, Arguably if all the PartitionLoadBalancer does is run or stop, it's implied that they are starting and stopping load balancing. However, I don't feel strongly either way.

That's a fair point.    I worry that RunAsync may be confusing in the context of the processor where that has some history as the "thing to call for running the background stuff."   Not sure that we need to go all out, but "Start/Stop" would also seem to imply semantics about things actively running in the background.   Something that gives a sense of "We're going to run one phase/pass/whatever of load balancing in response to this call" is kind of what I was aiming for.
We probably need to think about the "Stop" call the same way.   We're kind of saying "Finalize load balancing for this" more than "Stop doing the thing in the background".

I was on the fence regarding the naming. Either we could go more specific at the method level, as you suggested, or let the class provide the context as to what RunAsync means, Arguably if all the PartitionLoadBalancer does is run or stop, it's implied that they are starting and stopping load balancing. However, I don't feel strongly either way.

That's a fair point. I worry that RunAsync may be confusing in the context of the processor where that has some history as the "thing to call for running the background stuff." Not sure that we need to go all out, but "Start/Stop" would also seem to imply semantics about things actively running in the background. Something that gives a sense of "We're going to run one phase/pass/whatever of load balancing in response to this call" is kind of what I was aiming for.
We probably need to think about the "Stop" call the same way. We're kind of saying "Finalize load balancing for this" more than "Stop doing the thing in the background".

I see your point, and I think you convinced me that we need some more specific terminology, I'll think a bit more about it and propose something in the next commit.

closing this PR in favor of #9198


Building Packages with Fable Compatible F# Dependencies

I started thinking about this when I was wondering what the best way to enable projects like Gjallarhorn to publish Fable compatible packages.
There seem to be a few possible approaches

Nuget packages that include the source files from the subset of the project that will be included with fable and fable manifest file. Similar to how Cargo works with Crates
NPM packages of standard compiled js
Fables plugins to adapt the library
Git dependencies with paket that use a Fable manifest in root to know what to build

The main features that are important to be preserve are the design time tooling and type checking that come from the dll references in the Fable project being built.
One advantage of using a method that use the F# source to build everything together is it could enable the fable compiler to do dead code elimination to reduce the size of the final Fable package.

My preferred solution would be some variance/evolution of the way shown for the fable helper sample, i.e.: distributing the F# dll and the compiled JS code (either through npm or nuget).
Plugins are a bit complicated, and I would recommend them only when the whole library cannot be compiled to JS or we are only interested in some part of it (e.g. FSharp.Core, NUnit).
I wouldn't recommend distributing the F# source to compile it to JS either (though this will always be a last resort as the consumer can just reference the github repo with Paket) as this will slow/complicate the whole compilation and some tweaks may be necessary to compile to JS which should be responsible of the lib author.

The main features that are important to be preserve are the design time tooling and type checking that come from the dll references in the Fable project being built.

This is possible if the consumer project just references the lib dll.

One advantage of using a method that use the F# source to build everything together is it could enable the fable compiler to do dead code elimination to reduce the size of the final Fable package.

Fable doesn't do dead code elimination by itself. However, when referencing a type from another file it always used ES6 member imports. This, combined with tools like Webpack 2 and uglify-js, allows for tree shaking. The condition to allow this feature would be that the lib author compiles to JS using the --module es2015 fable compiler option.
In conclusion, it's already possible to distribute F# packages and reference them with fable using the --refs option. I think what remains to be decided is:

Should we always distribute JS code using ES6 modules? This would allow tree shaking. The problems would be: a) cannot be used directly in node or the browser (like UMD), and b) only Webpack 2 (still in beta, I think) supports ES6 imports.
Should we add some "manifest" file next to dll so Fable can automatically recognise where's the compiled JS code? This will avoid the need for the consumer project to use the --refs argument in fableconfig.json.

The condition to allow this feature would be that the lib author compiles to JS using the --module es2015 fable compiler option.

This information and possibly some other metadata could also be stored in the manifest

Once  a format has been decided on a FAKE helper module could be created to simplify and streamline the process of creating nuget or npm fable packages

Just brainstorming... would it be possible for fable to add the compiled js as Metadata into the assembly?  could potentially allow single file f#+js libs...

@ReedCopsey, this could be an interesting idea. Actually we considered something similar but just to add the fable manifest data into the assembly. However this may make things a bit more complicated and for now probably it's better to stick to human readable files that are easily editable.
I gave it a quick thought and maybe the manifest could be name something like fablemanifest.json (I know, very imaginative) and contain the following fields (names are tentative):

assemblyName: The name of the F# dll in case there are more assemblies in the same file. Perhaps the manifest itself could include info for different dlls?
js / jsCode / jsLocation / jsDir: Indicates a dir relative to the current location where the JS code is to be found. It could be possible to point to an npm package instead (so the dll would be distributed through nuget and the js through npm).
module: The module system used to compile the code to JS.
fableCoreVersion: The version of fable-core used when compiling the code to JS.

It could be possible to point to an npm package instead (so the dll would be distributed through nuget and the js through npm
That's a really cool idea!

Fable 0.7 includes a new way to distribute packages using .dll and .fablemap, still through npm though. Enrico is also working to integrate npm packages with the new fsproj format. Let's wait a bit to see the response from the community and see if it makes sense to unify distribution of .NET and JS.


[RelayMiner] LeanClient

Summary
Adds an ability to run many suppliers on one relayminer
Issue

#528

Type of change
Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[x] Documentation
[ ] Other (specify)

Testing
Documentation changes (only if making doc changes)

[x] make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

[x] Unit Tests: make go_develop_and_test
[x] LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

[x] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
Optionally run make trigger_ci if you want to re-trigger tests without any code changes
If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

[x] I have tested my changes using the available tooling
[ ] I have commented my code
[ ] I have performed a self-review of my own code; both comments & source code
[ ] I create and reference any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable

@Olshansk @red-0ne E2E tests are green. I think this PR is ready for the first pass of reviews. Please let me know what you think and if I need to change anything.
I know the go tests are not fixed yet, and this is what I'm going to be focusing on next.
Thanks!

Seems like the only e2e test that fails is the same flaky TestFeatures/Session_Namespace/Supplier_completes_claim/proof_lifecycle_for_a_valid_session.

Merging with one flaky test still failing.


[Spotify Player] ...

Extension – Spotify Player
Author: @mattisssa

@anisim101, can you update this with the error you are encountering?


You should add the commands to use it on android

Ik it sounds ridiculous but I'm sure we all have a old phone around and should put it to use so mabye use this on android......
it's just
----!!THIS IS WITH UNROOTED TERMUX!!----
git clone https://github.com/logicguy1/Discord-Nitro-Gen-and-Checker
pkg instal python
pip install discord_webhooks
cd Discord-Nitro-Gen-and-Checker
python3 main.py
-------------------------------------

Good work btw

#Proof

Feel free to make a pr and update the readme

Ok will do later


Process stop buttons in Call Stack pane always stop first process in list

I have several processes running and they are all listed in the Call Stack pane of the Run and Debug view. If I click the Stop button for the third process in the list, I would expect the third process to be stopped; the first one always gets stopped instead, no matter which stop button I click.

@JordanLongstaff with "Stop button" you mean the stop button on the item in the Call Stack pane, not the "Stop button" in the debug bar, right?

@weinand Correct. And upon further experimentation, it's not simply the first process in the list that gets killed, it's the one selected in the debug bar.

/confirm
@weinand here's how I reproduced this with vscode-mock-debug

Run the 'Debug test.md' configuration.
'Step Over' once.
Use the '...' menu at the right-hand end of the 'RUN AND DEBUG' view header to 'Start Additional Session' and pick 'Debug test.md'. The CALL STACK pane should look like this:

Hover over the first session in CALL STACK. When the action buttons appear, use Step Over with the expectation that the first session will advance by one line.
:bug: the Step Over gets applied to the second session.

As @JordanLongstaff wrote, the action buttons on every session row of CALL STACK seem to act on the session currently selected in the Debug Tool Bar (which in my screenshot is docked rather than floating).

Dup of https://github.com/microsoft/vscode/issues/125327
fixed in insiders


Refactor OSSL_LIB_CTX to avoid using CRYPTO_EX_DATA

This refactors OSSL_LIB_CTX to avoid using CRYPTO_EX_DATA. The assorted objects to be managed by OSSL_LIB_CTX are hardcoded and are initialized eagerly rather than lazily, which avoids the need for locking on access in most cases.
This ended up surprisingly simple. Of course I'm expecting people to throw rocks at this; this can be considered a first draft.
Currently this has the different parts of the code still calling ossl_lib_ctx_get_data with vestigial method structures, implemented using a big switch statement. Probably after this we can replace these with separate methods per object to be retrieved and get rid of the indices and most of the method structures (except for the separate fips module). I figured I'd leave this to a separate PR to keep the size of this PR down and make it easier to review.
The 02-test_internal_context test has been removed since it seems to mostly test the dynamic functionality of OSSL_LIB_CTX which no longer exists.
This is built on top of the scrypt KDF dup bugfix #17873 because it's dependent on it.
Fixes #17116.

Failures are being investigated.

Investigating deadlocks.

Updated to add namespacing to symbols.

Nice.. Code that doesn't use crypto_ex_data seems easier to understand :)
I would be interested to see what performance difference this makes when doing fetching of an algorithm in a loop, after doing an initial prefetch wilth these changes vs before the changes.

I'll make an effort to review this properly tomorrow.  Too much to get though today while retaining what little remains of my sanity.

Had to rebase, not sure what happened. Anyway, updated.

If I understand correctly, OSSL_LIB_CTX_METHOD isn't necessary any more with this PR. So you should be able to drop all instances, i.e.:

It's actually still used for OSSL_LIB_CTX_FIPS_PROV_INDEX (although as per my comments above, I'm not convinced it needs to be). Other instances probably can be dropped.

Yeah. I left out the cleanup of the OSL_LIB_CTX_METHOD structures initially to keep the diff size down. Updated to clean all this up.
It looks like we can indeed avoid needing to lazily load the FIPS stuff.
Updated.

Any idea what's going on here? Not like the file has been changed. https://github.com/openssl/openssl/runs/5719759959?check_suite_focus=true

@paulidale - needs reconfirmation

Merged to master.