SDMolSupplier requires several attempts to load a SDF file in Python 3.6/3.7

Configuration:

RDKit Version: 2020.03.6
Operating system: Ubuntu 18.04 (on WSL2)
Python version (if relevant): 3.6, 3.7
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? Conda Forge
If you are not using conda: how did you install the RDKit?

Description:

This is a weird one :)
SDMolSupplier needs two iterations on the supplier instance to get the molecules loaded on Python 3.6 and 3.7. Python 3.8 does not exhibit this problem.

Python 3.6 🚫
import sys
import rdkit
from rdkit.Chem import SDMolSupplier
print("System:", sys.platform)
print("Python:", ".".join(map(str, sys.version_info)))
print("RDKit:", rdkit.__version__)
# System: linux
# Python: 3.6.11.final.0
# RDKit: 2020.03.6

supplier = SDMolSupplier("sample.sdf")
mols, attempts = [], 0
while not mols and attempts < 10:
    mols = list(supplier)
    attempts += 1
print(f"Loaded {len(mols)} molecules after {attempts} attempts.")
# Loaded 145 molecules after 2 attempts.

Python 3.7 🚫
import sys
import rdkit
from rdkit.Chem import SDMolSupplier
print("System:", sys.platform)
print("Python:", ".".join(map(str, sys.version_info)))
print("RDKit:", rdkit.__version__)
# System: linux
# Python: 3.7.8.final.0
# RDKit: 2020.03.6

supplier = SDMolSupplier("sample.sdf")
mols, attempts = [], 0
while not mols and attempts < 10:
    mols = list(supplier)
    attempts += 1
print(f"Loaded {len(mols)} molecules after {attempts} attempts.")
# Loaded 145 molecules after 2 attempts.

Python 3.8 ✅
import sys
import rdkit
from rdkit.Chem import SDMolSupplier
print("System:", sys.platform)
print("Python:", ".".join(map(str, sys.version_info)))
print("RDKit:", rdkit.__version__)
# System: linux
# Python: 3.8.6.final.0
# RDKit: 2020.03.6

supplier = SDMolSupplier("sample.sdf")
mols, attempts = [], 0
while not mols and attempts < 10:
    mols = list(supplier)
    attempts += 1
print(f"Loaded {len(mols)} molecules after {attempts} attempts.")
# Loaded 145 molecules after 1 attempts.

Python 3.9 ✅
import sys
import rdkit
from rdkit.Chem import SDMolSupplier
print("System:", sys.platform)
print("Python:", ".".join(map(str, sys.version_info)))
print("RDKit:", rdkit.__version__)
# System: linux
# Python: 3.9.0.final.0
# RDKit: 2020.03.6

supplier = SDMolSupplier("sample.sdf")
mols, attempts = [], 0
while not mols and attempts < 10:
    mols = list(supplier)
    attempts += 1
print(f"Loaded {len(mols)} molecules after {attempts} attempts.")
# Loaded 145 molecules after 1 attempts.

Zipped sample SDF:  sample.zip
Thanks!

@jaimergp I will investigate more in-depth over the weekend. For now I guess the reason is that the SDMolSupplier wrapper exposes a random access container to Python, while it does not 100% fulfil Python requirements for iterators.
For the time being, here are some workarounds:
import sys
import rdkit
from rdkit.Chem import SDMolSupplier, ForwardSDMolSupplier
print("System:", sys.platform)
print("Python:", ".".join(map(str, sys.version_info)))
print("RDKit:", rdkit.__version__)
System: linux
Python: 3.6.10.final.0
RDKit: 2021.03.1dev1

supplier = SDMolSupplier("/home/toscopa1/sdf/chembl100.sdf")
mols = list(supplier)
len(mols)
0

# Use ForwardSDMolSupplier
supplier = ForwardSDMolSupplier("/home/toscopa1/sdf/chembl100.sdf")
mols = list(supplier)
len(mols)
100

# Use ForwardSDMolSupplier
supplier = ForwardSDMolSupplier("/home/toscopa1/sdf/chembl100.sdf")
mols = tuple(supplier)
len(mols)
100

# Explicitly iterate with a list comprehension
supplier = SDMolSupplier("/home/toscopa1/sdf/chembl100.sdf")
mols = [m for m in supplier]
len(mols)
100

# Explicitly iterate with a map
supplier = SDMolSupplier("/home/toscopa1/sdf/chembl100.sdf")
mols = list(map(lambda m: m, supplier))
len(mols)
100

Oh, I see. ForwardSDMolSupplier seems to be the way to go. We were using a plain comprehension before and it worked, but it was refactored into that list(...) call for simplicity. Interesting 🤔 Thanks for looking into it!


Chat application hangs once we continuously send messages

Hello,
We were developing chat application using flyer chat with firebase. We are facing an  issue when sending  a new messages when there are many messages present in the chat thread. We are using stream-builder to display real time messages.
As soon as we send the message, stream builder loads the messages again and it leads to memory leak. Eventually it leads to screen freezing due to memory leak. This happens when we keep sending messages continuously.

Hello! Currently I don't have much time to work on open source, you can help me debug and open a PR, thanks

When we call this function FirebaseChatCore.instance.sendMessage  it slows down may be because all  messages are fetched again.


podman images --digest: always list a digest

When we're asked to display image digests, always provide them if we have values that we can provide.

LGTM

LGTM and happy green test buttons

/lgtm

/approve


Add sideEffects: false flag to lit-helpers package

I just noticed in my webpack bundle that we're pulling in the live directive from lit-helpers, even though we only use spreadProps. Looks like this package doesn't set sideEffects: false which would allow webpack to treeshake these other modules.
I'm open to sending a PR, just want to make sure everyone would be onboard with this.

that would be awesome 🤗
actually most of our packages are side effect free 👍 (only testing and testing-helpers have side effects by default as far as I can think)
care to "check" and add sideEffects: false everywhere if appropriate?

Sure I can check! Although if I’m not mistaken are most of the other packages build utilities? It really only matters for the ones that would potentially be bundled into a production app.

true makes sense - I think only scoped-elements might also end up in a production app 🤗


examples: use java in README example

cc/ @heyitsanthony. I use maven to generate the jar and then show the example with java and example jar.

did the -SNAPSHOT update break the build? I get:
jetcd-simple-ctl $ ./mvnw clean package
Downloading https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.3.9/apache-maven-3.3.9-bin.zip
..............................................................................................................................................................................................................................................................................................................................................................................................................................................
Unzipping /home/anthony/.m2/wrapper/dists/apache-maven-3.3.9-bin/2609u9g41na2l7ogackmif6fj2/apache-maven-3.3.9-bin.zip to /home/anthony/.m2/wrapper/dists/apache-maven-3.3.9-bin/2609u9g41na2l7ogackmif6fj2
Set executable permissions for: /home/anthony/.m2/wrapper/dists/apache-maven-3.3.9-bin/2609u9g41na2l7ogackmif6fj2/apache-maven-3.3.9/bin/mvn
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for com.coreos:jetcd-simple-ctl:[unknown-version]: Could not find artifact com.coreos:jetcd-examples:pom:0.1.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 23, column 11
 @
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR]   The project com.coreos:jetcd-simple-ctl:[unknown-version] (/home/anthony/go/src/github.com/coreos/jetcd/jetcd-examples/jetcd-simple-ctl/pom.xml) has 1 error
[ERROR]     Non-resolvable parent POM for com.coreos:jetcd-simple-ctl:[unknown-version]: Could not find artifact com.coreos:jetcd-examples:pom:0.1.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 23, column 11 -> [Help 2]

@heyitsanthony confirmed the issue is with -SNAPSHOT. Change the version to 0.0.1 then it will work.

I update PR, it should work this time. I think my mvn was cacheing the -SNAPSHOT artifact  which is why I didn't get the snapshot not found error. Once I cleaned mvn cache, then I was able to reproduce
[FATAL] Non-resolvable parent POM for com.coreos:jetcd-simple-ctl:[unknown-version]: Could not find artifact com.coreos:jetcd-examples:pom:0.1.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 23, column 11

All fixed. PTAL


Show All Units doesn't work

Clicking show all units in Units Table gives white screen:
https://sortingview.vercel.app/workspace/sorting/R-c5089c48b72f/S-816a8e175985?workspace=e5c306c436a9f75fd97a20d832cd54d8243d516da53cbfe86270f11e98ee8b26&channel=franklab

I pushed a fix to this. No need to restart backend.


Only one mimetype per requestbody supported

We have an endpoint that either allows application/json in the request body, or a multipart/form-data with a data string field containing the same json and some additional file parts.
Currently oas-tools is always checking against the first mimetype configuration, and is ignoring the others completely. Please change the logic to apply the validation matching the Content-Type request header
Example:
                 "requestBody": {
                    "content": {
                        "application/json": {
                            "schema": {
                                "$ref": "definitions.json#/definitions/SomeData"
                            }
                        },
                        "multipart/form-data": {
                            "schema": {
                                "properties": {
                                    "data": {
                                        "$ref": "definitions.json#/definitions/SomeData"
                                    },
                                    "someFiles": {
                                        "type": "array",
                                        "items": {
                                            "type": "string",
                                            "format": "binary"
                                        }
                                    }
                                },
                                "required": [
                                    "data"
                                ]
                            }
                        }
                    },
                    "required": true
                },

This behaviour has been fixed in v3.0.0.


#1308 Workspaces are not created under certain conditions in I.E Browser.

Description
IE에서 공유 워크스페이스가 생성할 때 오류를 수정하였습니다.
Related Issue :
#1308
How Has This Been Tested?
IE 11과 Chrome 71 에서 공유 워크스페이스를 생성해서 테스트 하였습니다.
(https://github.com/metatron-app/metatron-discovery/issues/1308#issuecomment-461694558 참조)
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Additional Context

run build
deploy to 4


 Did I muck something up on my database setup or is it on the calaccess side?
Loading data files
 Loading CvrSoCd
 Loading Cvr2SoCd
Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/__init__.py", line 385, in execute_from_command_line
    utility.execute()
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/__init__.py", line 377, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/downloadcalaccessrawdata.py", line 121, in handle
    self.load()
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/downloadcalaccessrawdata.py", line 251, in load
    call_command("loadcalaccessrawfile", model.__name__)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/__init__.py", line 115, in call_command
    return klass.execute(*args, **defaults)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 503, in handle
    label_output = self.handle_label(label, **options)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 22, in handle_label
    self.load(label)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 41, in load
    self.load_postgresql(model, csv_path)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 160, in load_postgresql
    self.cursor.execute(temp_insert)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 63, in execute
    return self.cursor.execute(sql)
django.db.utils.DataError: value too long for type character varying(19)
CONTEXT:  COPY temporary_table, line 37468, column TRAN_ID: "9A0E4A6D-5C20-49AE-B"

I reproduced by calling loadcalaccessrawfile directly:
10:11:21 $ python manage.py loadcalaccessrawfile Cvr2SoCd
 Loading Cvr2SoCd
Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    execute_from_command_line(sys.argv)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/__init__.py", line 385, in execute_from_command_line
    utility.execute()
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/__init__.py", line 377, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 503, in handle
    label_output = self.handle_label(label, **options)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 22, in handle_label
    self.load(label)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 41, in load
    self.load_postgresql(model, csv_path)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 160, in load_postgresql
    self.cursor.execute(temp_insert)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute
    return super(CursorDebugWrapper, self).execute(sql, params)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
    return self.cursor.execute(sql, params)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 63, in execute
    return self.cursor.execute(sql)
django.db.utils.DataError: value too long for type character varying(19)
CONTEXT:  COPY temporary_table, line 37468, column TRAN_ID: "9A0E4A6D-5C20-49AE-B"

Are you using the latest pypi release? If so what version?
On Sat, Dec 17, 2016, 10:22 AM Charley Bodkin<EMAIL_ADDRESS>wrote:

During a run of downloadcalaccessrawdata in the load step, I encountered
this database error. Did I muck something up on my database setup or is it
on the calaccess side?
Loading data files
Loading CvrSoCd
Loading Cvr2SoCd
Traceback (most recent call last):
File "manage.py", line 22, in
execute_from_command_line(sys.argv)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line
utility.execute()
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/init.py", line 377, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
self.execute(*args, **options.dict)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
output = self.handle(*args, **options)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/downloadcalaccessrawdata.py", line 121, in handle
self.load()
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/downloadcalaccessrawdata.py", line 251, in load
call_command("loadcalaccessrawfile", model.name)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/init.py", line 115, in call_command
return klass.execute(*args, **defaults)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
output = self.handle(*args, **options)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 503, in handle
label_output = self.handle_label(label, **options)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 22, in handle_label
self.load(label)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 41, in load
self.load_postgresql(model, csv_path)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 160, in load_postgresql
self.cursor.execute(temp_insert)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute
return super(CursorDebugWrapper, self).execute(sql, params)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
return self.cursor.execute(sql, params)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/utils.py", line 94, in exit
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 63, in execute
return self.cursor.execute(sql)
django.db.utils.DataError: value too long for type character varying(19)
CONTEXT:  COPY temporary_table, line 37468, column TRAN_ID: "9A0E4A6D-5C20-49AE-B"
I reproduced by calling loadcalaccessrawfile directly:
10:11:21 $ python manage.py loadcalaccessrawfile Cvr2SoCd
Loading Cvr2SoCd
Traceback (most recent call last):
File "manage.py", line 22, in
execute_from_command_line(sys.argv)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line
utility.execute()
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/init.py", line 377, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
self.execute(*args, **options.dict)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
output = self.handle(*args, **options)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/core/management/base.py", line 503, in handle
label_output = self.handle_label(label, **options)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 22, in handle_label
self.load(label)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 41, in load
self.load_postgresql(model, csv_path)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/calaccess_raw/management/commands/loadcalaccessrawfile.py", line 160, in load_postgresql
self.cursor.execute(temp_insert)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 81, in execute
return super(CursorDebugWrapper, self).execute(sql, params)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 65, in execute
return self.cursor.execute(sql, params)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/utils.py", line 94, in exit
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "/Users/cbodkin/.virtualenvs/hcbodkin.com/lib/python2.7/site-packages/django/db/backends/utils.py", line 63, in execute
return self.cursor.execute(sql)
django.db.utils.DataError: value too long for type character varying(19)
CONTEXT:  COPY temporary_table, line 37468, column TRAN_ID: "9A0E4A6D-5C20-49AE-B"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/california-civic-data-coalition/django-calaccess-raw-data/issues/1496,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAnCXm6hGjviXVm9-ZMHsulQ7fqN3buks5rJChjgaJpZM4LP8q_
.

I just ran the complete update process on the master branch of this repo and did not get an error. So there must be some difference between our two configurations. Are you using a PyPI release? If so, which version?

I was using pypi release, but then I had switched to master branch because of a separate problem. I'm going to close until I can reproduce reliably using pypi version.

As a second measure, I just created a blank virtualenv and installed the latest PyPI release according to our official instructions. Everything loaded fine on a first run through updatecalaccessrawdata. So something else must be different between us. I am using PostgreSQL 9.5 on Ubuntu Linux 16.04 with django-calaccess-raw-data 1.4.6.

Believe I just overcame this issue. Not sure exactly what was going on--probably on an out of sync tree or something screwy with my DB, but thank you @palewire for assisting.
On PostgreSQL 9.4.5 on Mac OS 10.11.6 (15G31)


feat(aws-codedeploy): add auto rollback configuration to server Deployment Group

Continuing on covering the entire CodeDeploy service area in the L2.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Updated with Elad's and Bangxi's feedback.


Update rules_docker to 0.4.0

also added a group file with the root group, some packages expect it to exist

Thanks!


feat(jenkins): add logic to parse CI_PULL_REQUEST env variable

add logic to parse CI_PULL_REQUEST env variable.
Currently this variable is not parsed for jenkins configuration.
https://coveralls.zendesk.com/hc/en-us/articles/201347419-Coveralls-currently-supports JENKINS PULL REQUEST SUPPORT section suggest to use it in conjunction with github pull request builder config

There were the following issues with your Pull Request

Commit: 585d3364942b54df681a7f18d0298c636968a2e1
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/coveralls-clients/coveralls-python

This message was auto-generated by https://gitcop.com

@TheKevJames, @goanpeca you guys still active?

Ah, sorry about that, somehow missed this notification. Looks good, thanks!


(PUP-8957) Revert changes that made SMF return :absent (again)

This commit reverts any changes that made the SMF provider return
:absent for nonexistent services, while preserving some of the
acceptance test improvements made during this work (e.g. like
consolidating all SMF tests to a single file). These involve the
following commits:

(PUP-6797) service should check for smf service first
** Hash: 3d7a3c4c1c6697047ae356c8765928f68618bc69
(PUP-6860) puppet on solaris 11 should support exists? for services
** Hash: dd30a54c9ff5fba9f980147b4a7af80442e009ed
(PUP-6797) Update SMF tests for nonexistent service
** Hash: 7085af0b7e508d86caa9e30bf44bed931d65f0df
(maint) (PUP-6767) remove redundant smf acceptance testing
** Hash: b539fe581f372514e28f4c7e095d81dc8b0f500c
(PUP-8167) SMF provider: do not try to stop :absent services
** Hash: 7183a352288867392c1c934270c494e7b1270ab0

jenkins please test this on solaris10-64a,solaris11-64a

CLA signed by all contributors.

Merging with just my own review, since this was previously reviewed by others in another PR


reapaintBoundary can't catch pictures in platformview

reapaintBoundary can't catch pictures in platformview
both pictures in webview_flutter and video_player can't be catched  by toImage of repaintBoundary;

Hi @wanjm
Can you please provide your flutter doctor -v, the actual vs expected results and a minimal complete reproducible code sample?
Thank you

#25306 is talking the same problem, though he thought it is a problem of webview_flutter, in fact it is a problem with PlatformView

Hi @wanjm
Thanks for pointing that out.
I'm going to close this one as a duplicate of https://github.com/flutter/flutter/issues/25306. I will update https://github.com/flutter/flutter/issues/25306 to cover platform views and not just webview. Please follow up on that issue.
Thank you


Is the new way of measuring the CLS already implemented?

Is the new way of measuring the CLS already implemented?
https://web.dev/evolving-cls/
https://web.dev/cls-web-tooling/

Yes, see v2 in the changelog

Thanks! @csabapalfi


Errors from VVL on Nvidia

Short info header:

GFX version: 0.9.0
OS: Linux
GPU: GeForce GTX 1050/PCIe/SSE2 with proprietary drivers (NVIDIA 460.67)

I want to thank you for a great job. But i have some warnings when use wgpu.
It looks like it is a gfx_backend_vulkan error. I did a little research on this bug and VVL reviews. But I tried to implement some logic with ash and I don't have these warnings in my production application.
So I think this is not a VVL and Nvidia problem. Can you fix this or disable these warnings that appear on every frame?
[2021-06-21T05:22:13Z ERROR gfx_backend_vulkan]
    VALIDATION [VUID-VkRenderPassBeginInfo-framebuffer-03212 (0xd883b436)] : Validation Error: [ VUID-VkRenderPassBeginInfo-framebuffer-03212 ] Object 0: handle = 0x180000000018, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0xd883b436 | vkCmdBeginRenderPass(): Image view #0 created from an image subresource with height set as 800, but image info #0 used to create the framebuffer had height set as 600 The Vulkan spec states: If framebuffer was created with a VkFramebufferCreateInfo::flags value that included VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each element of the pAttachments member of a VkRenderPassAttachmentBeginInfo structure included in the pNext chain must be a VkImageView with a height equal to the height member of the corresponding element of VkFramebufferAttachmentsCreateInfo::pAttachmentImageInfos used to create framebuffer (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkRenderPassBeginInfo-framebuffer-03212)
    object info: (type: RENDER_PASS, hndl: 0x180000000018)

Thank you for filing!
Could you record an API trace for us to reproduce this?

Isn't this just the imageless fb vvl issues we've been seeing forever now?

https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2503 was about the fact that the mipmap level dimensions weren't taken into account. So the mismatch would be within the power of two. But this one has 800 versus 600, so it's something else.

git clone https://github.com/gfx-rs/gfx.git
git checkout hal-0.9
cd examples
cargo r --bin quad --features=vulkan
 Finished dev [unoptimized + debuginfo] target(s) in 0.12s
     Running `/home/Substrate/wgpu/gfx/target/debug/quad`
AdapterInfo { name: "GeForce GTX 1050", vendor: 4318, device: 7297, device_type: DiscreteGpu }
Memory types: [MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: (empty), heap_index: 1 }, MemoryType { properties: DEVICE_LOCAL, heap_index: 0 }, MemoryType { properties: CPU_VISIBLE | COHERENT, heap_index: 1 }, MemoryType { properties: CPU_VISIBLE | COHERENT | CPU_CACHED, heap_index: 1 }, MemoryType { properties: DEVICE_LOCAL | CPU_VISIBLE | COHERENT, heap_index: 2 }]
Using sparse resource binding
formats: Some([Bgra8Unorm, Bgra8Srgb])
SwapchainConfig { present_mode: FIFO, composite_alpha_mode: OPAQUE, format: Bgra8Srgb, extent: Extent2D { width: 1024, height: 768 }, image_count: 3, image_layers: 1, image_usage: COLOR_ATTACHMENT }
[2021-06-21T16:03:02Z ERROR gfx_backend_vulkan]
    VALIDATION [VUID-VkRenderPassBeginInfo-framebuffer-03212 (0xd883b436)] : Validation Error: [ VUID-VkRenderPassBeginInfo-framebuffer-03212 ] Object 0: handle = 0x190000000019, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0xd883b436 | vkCmdBeginRenderPass(): Image view #0 created from an image subresource with height set as 1024, but image info #0 used to create the framebuffer had height set as 768 The Vulkan spec states: If framebuffer was created with a VkFramebufferCreateInfo::flags value that included VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each element of the pAttachments member of a VkRenderPassAttachmentBeginInfo structure included in the pNext chain must be a VkImageView with a height equal to the height member of the corresponding element of VkFramebufferAttachmentsCreateInfo::pAttachmentImageInfos used to create framebuffer (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkRenderPassBeginInfo-framebuffer-03212)
    object info: (type: RENDER_PASS, hndl: 0x190000000019)

resized to PhysicalSize { width: 1024, height: 768 }
SwapchainConfig { present_mode: FIFO, composite_alpha_mode: OPAQUE, format: Bgra8Srgb, extent: Extent2D { width: 1024, height: 768 }, image_count: 3, image_layers: 1, image_usage: COLOR_ATTACHMENT }
[2021-06-21T16:03:02Z ERROR gfx_backend_vulkan]
    VALIDATION [VUID-VkRenderPassBeginInfo-framebuffer-03212 (0xd883b436)] : Validation Error: [ VUID-VkRenderPassBeginInfo-framebuffer-03212 ] Object 0: handle = 0x190000000019, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0xd883b436 | vkCmdBeginRenderPass(): Image view #0 created from an image subresource with height set as 1024, but image info #0 used to create the framebuffer had height set as 768 The Vulkan spec states: If framebuffer was created with a VkFramebufferCreateInfo::flags value that included VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each element of the pAttachments member of a VkRenderPassAttachmentBeginInfo structure included in the pNext chain must be a VkImageView with a height equal to the height member of the corresponding element of VkFramebufferAttachmentsCreateInfo::pAttachmentImageInfos used to create framebuffer (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkRenderPassBeginInfo-framebuffer-03212)
    object info: (type: RENDER_PASS, hndl: 0x190000000019)

[2021-06-21T16:03:02Z ERROR gfx_backend_vulkan]
    VALIDATION [VUID-VkRenderPassBeginInfo-framebuffer-03212 (0xd883b436)] : Validation Error: [ VUID-VkRenderPassBeginInfo-framebuffer-03212 ] Object 0: handle = 0x190000000019, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0xd883b436 | vkCmdBeginRenderPass(): Image view #0 created from an image subresource with height set as 1024, but image info #0 used to create the framebuffer had height set as 768 The Vulkan spec states: If framebuffer was created with a VkFramebufferCreateInfo::flags value that included VK_FRAMEBUFFER_CREATE_IMAGELESS_BIT, each element of the pAttachments member of a VkRenderPassAttachmentBeginInfo structure included in the pNext chain must be a VkImageView with a height equal to the height member of the corresponding element of VkFramebufferAttachmentsCreateInfo::pAttachmentImageInfos used to create framebuffer (https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#VUID-VkRenderPassBeginInfo-framebuffer-03212)
    object info: (type: RENDER_PASS, hndl: 0x190000000019)

seems its happen inside gfx-rs

OK. I resized the "quad" exmaple window to 512x512. It seems to have been a power of two problem. And there are no more warnings. Any ideas how to fix this problem? Wait for updates from KhronosGroup or some other options?

What's the version of your validation layers?

Interesting. I just tested this on 1050 GTX / Linux, and not seeing any validation errors. Current version of "vulkan-validation-layers" package is <IP_ADDRESS>. Not sure how to investigate this without a repro :/

Maybe you have your own settings for the validation layer? I can definitely upgrade VVL to 1.2.179. I have done additional research.
git clone https://github.com/sotrh/learn-wgpu.git
cd learn-wgpu
cargo run --bin tutorial2-swapchain

User generated textures do not exist (as I know, mipmaps should not be generated). But I have the same problems.
As far as I know, there are several hacks for working with NPOT textures called upperPowerOfTwo. It might come in handy.

Running this doesn't trigger any validation errors for me either. Are you on Wayland, perhaps?

As far as I know, there are several hacks for working with NPOT textures called upperPowerOfTwo. It might come in handy.

this isn't about NPOT, that other issue was about mipmaps


1.8 backport: release CI: Update used actions to latest versions, add upload to PyPI

This is backport of #1561 to the 1.8 maintenance branch, brining maintenance to the release CI to the 1.8 branch.
It updates the used actions in the release CI to their latest version, and also adds the Upload Release Assets to PyPI part which was added in https://github.com/shapely/shapely/commit/a66a623cd63b674d7aa12c259ff56a58348e08d5.
The main improvement is on the cibuildwheel side, which include Python 3.11 support, better Apple Silicon support and many bugfixes. It also expands the API, see https://cibuildwheel.readthedocs.io/en/stable/changelog/ for details.
With this PR, the only thing that's needed to release Python 3.11 wheels to PyPI is tagging a new patch release on the 1.8 branch, on which this CI configuration is triggered and does the rest.

@sgillies just backported it already: https://github.com/shapely/shapely/commit/257691148b06ebe59c55711178473a7bef8ace56

That's a coincidence, thanks!


Clean up unused elements in the APIs like hmName, hmContact etc. but keep backward compatibility

Clean up unused elements in the API like hmName, hmContact etc. but keep backward compatibility so that APK doesn't fail with old API interface implementations

backend task for this has been done successfully . now unwanted fields are not present


fix: KubernetesDashboard.Enabled: false should not break controllers

The applyall function in the /opt/bin/install-kube-system fails when only one value is
contained in the braces. This corrects the problem by moving the kubernetes-dashboard
role & rolebindings to a dedicated entry.
Fixes #1460

Codecov Report

Merging #1461 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1461   +/-   ##
======================================
  Coverage    38.1%   38.1%
======================================
  Files          74      74
  Lines        4559    4559
======================================
  Hits         1737    1737
  Misses       2580    2580
  Partials      242     242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d6bea...fd7ecf4. Read the comment docs.


Fix inconsistent PR comment counts

This makes the comment count on PRs consistent with repostats cronjob behaviour again: ie. don't try to count review comments towards issue comment count (fixing a regression from #16075).
This is also a bugfix for API clients, that rely on that count to fetch issue comments (but that API does not include review comments, resulting in bad client state).
fixes #16901
In a later PR we can aim at counting PR-reviews & code comments towards the the PR comment count similar to github.

add a doctor task to fix wrong records?

@6543 cron.check_repo_stats will fix the comment counts anyway, per default config after 24h..


Feature Request: A Customised Scroll bar for Spendwise

Make a Customised Scroll bar for Spendwise

@niladrix719  May I work on this Issue

yes go ahead @SHIVAA17


58 handling of the restarfile

Addresses #58, it allows the storage if desired of the restartfile.
Takes care of being able to run the calculation either from a restartfile in the db or from a remote folder.

ping @chrisjsewell do you think you could review this? I would like to have this merged so that i can work in #63 and #56


SSL certificate issued, webpage error:  DNS_PROBE_FINISHED_NXDOMAIN

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d1pysc4lw8c3dr
Region
us-east-1
Step
Deploy
Status
Passes tests, fails to load
Issue or question
I've went through the build steps and had the SSL issued but when I attempt to reach the site, it fails with the DNS error below. I did previously have the domain in use on a S3 bucket but deleted the bucket two days ago to migrate the domain and content to AWS Amplify.
Error message
This site can’t be reached
Check if there is a typo in checkpointalarms.com.
DNS_PROBE_FINISHED_NXDOMAIN
Additional information
No response

Hi @Corey-Wademan @into-expert 👋 , thanks for reaching out to us and we apologize for the delayed response on the thread.
The Amplify app d1pysc4lw8c3dr seems to have been deleted and thus we cannot review the domain configuration associated to it.
If you are observing a DNS_PROBE_FINISHED_NXDOMAIN error while trying to resolve your custom domain, I would highly recommend reviewing this article which outlines some potential root causes of this error.
Related thread: https://github.com/aws-amplify/amplify-hosting/issues/2125


When reloading a Play! application, if the classloader has not changed, do not reload the application.

When changing a file that is only served as "assets" (and is not part of the classloader), Gradle still reloads the Play application. This is unnecessary.
SBT had a related problem: https://github.com/playframework/playframework/issues/2905
Expected Behavior
When changing an asset file or a file that does not affect the classloader of the Play application, the Play application does not reload.  The Gradle build may still need to run (e.g., to copy assets/generate other assets).
Current Behavior
Play application reloads on any change.
Steps to Reproduce (for bugs)

Using the "basic" Play application sample, run the Play application (gradle runPlay)
Change a file in public/.  Observe the Play application stops/starts.  This is unnecessary when the file is not a part of the classloader.

@big-guy, Just checking if there is any action planned for this issue?

Also interested in seeing this fixed

@ymwang1984 please let us know if this fixes the issue for you

@oehme
We are still verifying. Initial feedback is good as a few front-end devs said the re-deploy is much faster with asset change only. Please give us one more week to thoroughly test it. Thanks a lot!


Generate steps with v-for

Hi,
When I use v-for to generate the steps I end up with the steps mixed up. The generated ones are always the last.
        <tab-content  title="Hello" icon="fa fa-key"></tab-content>
          <tab-content
            v-for="(item, index) in pages"
            v-bind:item="item"
            v-bind:index="index"
            v-bind:key="item.id"
            :title="item.title" icon="fa fa-check">
         </tab-content>
        <tab-content title="Bye" icon="fa fa-upload"></tab-content>

The generated steps in order:

Hello
Bye
Step1
Step2

Did I miss something?

@cristijora Somehow this works:
        <template v-for="(item, index) in pages">
          <tab-content v-if="index === 0"  title="Hello" icon="fa fa-key"></tab-content>
          <tab-content v-else-if="index === pages.length - 1" title="Bye" icon="fa fa-upload"></tab-content>
          <tab-content :title="item.title" icon="fa fa-check"></tab-content>
        </template>

The generated steps in order:

Hello
Step 1
Step 2
Bye

Should I use it this way?

Yes. That's pretty much what I suggested. Keeping everything inside v-for. Just for simplicity, I would put everything inisde your pages array so you end up with this only
<tab-content
            v-for="(item, index) in pages"
            v-bind:item="item"
            v-bind:index="index"
            v-bind:key="item.id"
            :title="item.title"
            :icon="item.icon>
         </tab-content>

Found an example.
https://jsfiddle.net/bt5dhqtf/973/
You can easily use component :is="componentName" and define each step in separate components if you have a more complicated wizard. Then simply define a component for each step

Maybe I should update docs with this example since I would recommend the following approach from the last fiddle as it can cover many cases and it's pretty clean.


Add authentication to post metadata, logs

These routes should be restricted to the dispatch-service

:tada: This issue has been resolved in version 5.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add dependabot grouping for otel-collector-contrib repo

Should make it a bit easier to review and merge the OTel version bump PRs.

I don't have a strong opinion, but I agree that the otel core happens first, and the contrib is updated accordingly. This repo can be seen as an extension of the contrib one, thus we can keep the same strategy (different groups). If the repo becomes too overwhelmed, I don't think there would be an issue joining them into a single otel group.


Hacktoberfest optin

Unless you see any concerns with this, I figure might as well make this repo Hacktoberfest-eligible since they changed to an opt-in model this year: https://hacktoberfest.digitalocean.com/details#details
Requires adding a 'hacktoberfest' topic to the repo on GitHub (on repo homepage), that should be all that's necessary for this.
Thanks a lot! 👏

I think the author has abandoned the project. He doesn't respond. I've forked this library fixed few bugs, if it works fine, I'll publish it and maintain it.


Purchase request of subscription throws "offerToken is required" exception on Android

Description
Hello, everyone!
After the request of subscriptions finished successfully and the UI is rendered successfully as well with all dynamic values as titles, prices etc. the productId/sku is provided to the requestPurchase method and is throwing a native exception.
offerToken is required for constructing ProductDetailParams.
There is no way of providing the offer token to the method.
Am I doing something wrong with the SKU handling or with the lifecycling?
The app.tsx is wrapped in withIAPContext HOC.
I thank you for your help!
Expected Behavior
The process should complete successfully when providing all necessary parameters (skus array).
Screenshots

Environment:

react-native-iap: 12.3.0
react-native: 0.67.3
Platforms: Android device on Android 9

To Reproduce
Some sample snippet:
import React, {FC, useEffect, useState} from 'react';
import {SubscriptionAndroid} from 'react-native-iap/src/types';
import {useIAP} from 'react-native-iap';
import {Platform, StyleSheet, View} from 'react-native';

export const SomeComponent: FC<SomeComponentProps> = ({}) => {

  const {getSubscriptions, requestPurchase, subscriptions} = useIAP();

  /**
   * Getting subscriptions from PlayStore / AppStore on init
   */
  useEffect(() => {
    (async () => {
      await getSubscriptions({
        skus: SubscriptionSkus,
      });
    })();
  }, []);

  /**
   * Handle purchase request
   */
  const purchaseSubscription = async (sku: string) => {
    console.debug('Purchasing: ', sku);

    // Get object again by SKU to be sure that a matching subscription in list is available and the sku is valid
    const subscription = subscriptions.find(s => s.productId === sku);

    // Handle android purchase request
    if (Platform.OS === 'android' && subscription) {
      const androidSubscription = subscription as SubscriptionAndroid;
      const sku = androidSubscription.productId;
      const offerToken =
        androidSubscription.subscriptionOfferDetails[0]?.offerToken; // Offer token is available
      }
      await requestPurchase({skus: [sku]}); // There is no signature/way to provide the offerToken to rn-iap
    }
  };

  // Following some JSX that renders buttons based on subscription array and triggers purchaseSubscription with given productId (called sku as parameter name)

}

parameter is called subscriptionOffers

For everyone who is facing the same problem, here is a snippet of how to purchase a subscription with the framework, since the documentation does not tell anything about it. If you have any other problems, please send me a message, I'm happy to help:
/**
   * Handle purchase request
   */
  const purchaseSubscription = async (sku: string) => {
    console.debug('Purchasing: ', sku);

    // Get subscription by sku from subscription
    // list provided by react-native-iap after calling the getSubscriptions method
    const subscription = subscriptions.find(s => s.productId === sku);

    // Early return on invalid subscription
    if (!subscriptions) {
      throw new Error(
        'Invalid sku provided. No subscription with given sku could be found.',
      );
    }

    // Handle android purchase request
    if (Platform.OS === 'android') {
      const androidSubscription = subscription as SubscriptionAndroid;

      // Get offer token. If you have multiple offers, you need to choose the correct one here
      // We only got one offer per subscription
      const offerToken =
        androidSubscription.subscriptionOfferDetails[0]?.offerToken;

      if (!offerToken) {
        throw new Error('Subscription does not contain a valid offerToken');
      }

      const subscriptionRequest: RequestSubscriptionAndroid = {
        subscriptionOffers: [
          {
            sku,
            offerToken,
          },
        ],
      };

      await requestSubscription(subscriptionRequest);
    }
  };


marking event handler as 'passive

Hello,
Is this a solution for this warning please?
bridge3.410.0_en.html:91 [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
You can find the warning even in your example provided as demo. Sample Page
Thank you,

Hello @etomProductions ,
Can you provide steps for reproducing this error? Or which sample causes the error?
Thank you,
Jackson
IMA SDK DevRel

Hello @Kiro705,
First of all thank you so much for reply to my question and apologize for the delay as I did not got any notification from github and I will look to my email settings.
AS I mentioned above it (was) showing also in your example page as well if you open the console but for some reason not any more. Did you updated the page?
Please advise.
For me I have the error in my own host (private and dont have yet public access.) and I tried it in different hosts with the same result.
Thank you,
Kind Regards,
Tariq

Hello @etomProductions ,
Sorry for the slow reply. Without a way for me to reproduce the issue, it will be difficult to help with a solution.
Are there any specifics you can provide, as to types of devices/browsers where the error occurs. If it specific to certain ad types?
More obviously, if your code is adding any event listeners to the 'touchmove' event, I would look there to resolve the issue.


set_target with hostname fails during pongo run

We have a custom plugin that sends a user to a different endpoint if they meet specific conditions. This previously was done in another nginx instance via proxy_pass.
Originally we were using the set_upstream method which we believed was working but recently stopped (or perhaps never worked to begin with and our tests were faulty).
According to the Kong Service API documentation , I should be able to use a hostname or IP address for the host value in the set_target method.

The host argument expects the hostname or IP address of the upstream server, and the port expects a port number.

This seems to work just fine when Kong is running. However, when running in Pongo I get the following error:
2023/06/14 15:59:57 [error] 109#0: *155 [lua] init.lua:1166: balancer(): failed to set the current peer (address: api.xxxxx.com port: 443): no host allowed while connecting to upstream, client: <IP_ADDRESS>, server: kong, request: "GET /request HTTP/1.1", host: "api.xxxxx.com"

Expected Behavior
Kong reroutes the request to the specified endpoint.
Repro Steps

Write a plugin that returns kong.service.set_target("somehost", 443) :

local plugin = {
  PRIORITY = 999,
  VERSION = "0.1.0",
}

function plugin:access(config)
  return kong.service.set_target("somehost", 443)
end

return plugin

Write an integration test to test it:

local helpers = require "spec.helpers"

local PLUGIN_NAME = "my-plugin"
local strategy = "postgres"

describe("["..PLUGIN_NAME.."]", function()
  local client

  lazy_setup(function()

    local bp = helpers.get_db_utils(strategy, nil, { PLUGIN_NAME })

    bp.routes:insert({
      hosts = { "originalhost.com" },
    })

    bp.plugins:insert {
      name = PLUGIN_NAME
    }

    assert(helpers.start_kong({
      database = strategy,
      nginx_conf = "spec/fixtures/custom_nginx.template",
      plugins = "bundled," .. PLUGIN_NAME,
      declarative_config = strategy == "off" and helpers.make_yaml_file() or nil,
    }))
  end)

  lazy_teardown(function()
    helpers.stop_kong(nil, true)
  end)

  before_each(function()
    client = helpers.proxy_client()
  end)

  after_each(function()
    if client then
      client:close()
    end
  end)

  describe("a request to the original host", function()
    it("should pass the request to the other endpoint", function()
      local res = client:get("/request")

      assert.response(res).has.status(200)
    end)
  end)
end)

Type pongo run in the terminal.

Configuration
I'm currently deploying Kong Ingress Controller via Helm chart 2.23.0.

moved this issue to the Kong repo, since it is not Pongo specific.

@rwa-siteimprove I tried to locate the positions you mentioned and it seems the file has already changed. Could you specify what version of Kong you were using?
The error message indicates that we should not use a host, but an IP address. I guess Kong was using the API wrong and we should have resolved the host before that. The latest code seems to do it in the right way.

I'm still getting the error with the latest pongo code and kong 3.4.2. My tests pass if I use an IP address instead of a host name. What I believe may be happening is I'm not using the ring balancer at runtime as I'm just passing a DNS record to kong for my upstreams.
I'll look into this some more but we can probably close this issue for now until I have more information.

@rwa-siteimprove Got it. Please feel free to reopen it if we have further information.


[Question] - Support video components (expo-av, react-native-video, etc.)

Hi @pavelbabenko! Thank you for your hard work! I really adore this package. I have a couple of questions for you. Can I use this package for rendering video components? Will there be any performance issues if I use this component for this?

Hi @SelfDestroyer
I didn't try rendering videos, but I assume that it should work with custom renderItem

@SelfDestroyer hey, did you succeed in using this with videos?
Thanks in advance!


BUG: Links at the footer hovering effect can be improved

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
Links at the footer hovering effect can be improved. The hovering effect for quick links at the footer looks odd..
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Footer section is already assigned to someone


Add null check for Carbon config path retrieval

Resolves #1309

@gokul : PRs need to be imperative style and in the PR comment we need to have the "Resolves #". The same should be use for in the commit message as well

Closing PR since the file structure is different after refactoring. Will open a new one.


chore: bdd-spring-1575480722 to 0.0.1

chore: Promote bdd-spring-1575480722 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Click on "copy command"

Please verify that you have read and understood the guidelines.
yes
A clear and concise description of the issue.
when I click "copy command", it copies "test", not the command.
Browser Chrome on linux
Thank you! Great work!
What settings are you currently utilizing?
Default Settings
Which Linux distribution are you employing?
Ubuntu 20.04
If relevant, including screenshots or a code block can be helpful in clarifying the issue.

Please provide detailed steps to reproduce the issue.
No response

Fix was in a seperate branch, merging into main now.

Fix has been deployed, may take a bit for vercel to update the main URL with the changes


kubectl 1.8 validation errors for mesh-expansion.yaml

this will hit users soon (when 1.8 is the default) - I don't know how widespread it is (ie is it an issue with more than that yaml) - second hand report I didn't see it myself
error: error validating "https://raw.githubusercontent.com/istio/istio/master/install/kubernetes/mesh-expansion.yaml": error validating data: apiVersion not set; if you choose to ignore these errors, turn validation off with --validate=false
Client Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.2", GitCommit:"bdaeafa71f6c7c04636251031f93464384d54963", GitTreeState:"clean", BuildDate:"2017-10-24T19:48:57Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

PRs are most welcome, and even just Issues reports !

fixed in #1312


IA-668: React 17 upgrade

⚠ This branch is using https://github.com/BLSQ/bluesquare-components/pull/2 in package.json
Don't forget to remove your node_modules + npm install or clean your docker image before

I would have merge if there were no conflicts :-)

I'm converting it back to draft because before merging we need to merge the bluesquare-component pr and change the dependencies back to the main package

⚠ This branch is using BLSQ/bluesquare-components#2 in package.json
Don't forget to remove your node_modules + npm install or clean your docker image before

you can use npm ci, it will clean up the node_modules for you and install the deps versions from package-lock

There's deprecated prop in MaterialUI's textarea:

When searching for an orgUnit in the form submission screen, the selected orgUnit doesn't display in the 'levels' select boxes
https://user-images.githubusercontent.com/38907762/125085731-31000580-e0cb-11eb-9897-a9dcd70222dc.mov

⚠ This branch is using BLSQ/bluesquare-components#2 in package.json
Don't forget to remove your node_modules + npm install or clean your docker image before

The PR in bluesquare-components has been merged

Select issue is present on playground too , then not linked to this PR.


error in ZonamaDev1.5.8 missing a code line

when i try on vm and standalone i get this

either the bug is in Gerrit code or 1.5.8 has a coding error in build face here is from server standalone part


Framework to define tooltips

We should look into a way to add tooltips if the user hovers over the field or label.  For certain things, I think it could be used to give a basic rundown of how to get it ("From the console, run 'show version'" as an example for IOS kit).
@128keaton?

Closed.  Fantastic job, @128keaton .


Add ContainerSecurityContext

Some keys such as fsGroup are supported in podSecurityContext, and keys such as capabilites are supported in containerSecurityContext.
Operator should support both :)
Here is a sample yaml to test this out

apiVersion: integreatly.org/v1alpha1
kind: Grafana
metadata:
  name: example-grafana
spec:
  ingress:
    enabled: True
  deployment:
    containerSecurityContext:
      allowPrivilegeEscalation: false
      capabilities:
        add: ["NET_ADMIN", "SYS_TIME"]
    securityContext:
      runAsUser: 1000
      runAsGroup: 3000
      fsGroup: 2000
  config:
    log:
      mode: "console"
      level: "warn"
    security:
      admin_user: "root"
      admin_password: "secret"
    auth:
      disable_login_form: False
      disable_signout_menu: True
    auth.anonymous:
      enabled: True
  dashboardLabelSelector:
    - matchExpressions:
        - {key: app, operator: In, values: [grafana]}

thanks @AdheipSingh ! Will try to review asap.

Thanks @AdheipSingh !


still maintained?

Is this deposit still maintained?
The last commit more than 2 years ago, and the last valid pull-request is from October 2017.

Your finding probably answer itself.
I noticed the same thing and did not dare to adopt this project for my solution base.

This is a great project, it would be a shame if it was no longer supported. I've always used Ink, and had great respect for the project and team.
It looks like https://mjml.io/ is well supported if anyone is looking for an alternative, and I've heard good things from teams in my company.

There have been quite a few similar issues in the past weeks/months. To sum it up, what I understood:
The project is still used actively by the maintainers and fixed in case there is a serious issue. Regarding the open issues / PRs, people are welcome to review and help get things sorted out.
I just noticed there also is #938, which has been created by one of the maintainers. I think the main issue is that their time currently is very limited.
Just as a side note, I switched from mjml to this project because I encountered too many limitations using mjml (especially regarding templating support), so you might want to take those recommendations with a grain of salt...

Thanks for your replies.
So, if I've understand, I can use Foundation-emails for my project. But no update are planned for now and just the criticals bugs are corrected.

Should a critical bug arise, I doubt it would be corrected.

😢 this reply don't help me to know if I could adopt the framework

I did a quick search for a few references to the information from my previous post.
I think most information regarding current state of this repo can be found within  https://github.com/zurb/foundation-emails/issues/893
And there is an issue where I asked how we could move forward with the open PRs https://github.com/zurb/foundation-emails/issues/860
But to quote from the first issue the main problem seems to be this one:

there is just a lack of active contributors and maintainers (like in many opensource projects).

so, it very likely is not dead or unmaintained, but available resources are currently an issue
sorry @shnizmuffin , I don't think speculations are of any help here...
However, if we find something that does not work, are able to provide a PR and get that merged, we are all good. We just need to make that happen somehow 😬

@st-h, It's not speculation. It would be irresponsible to tell someone, "yeah, this project is still in active development," when it's very obviously not. Without an active member with the authority to approve and merge PRs, this project is a zombie.
@Vilsafur, if you're uncomfortable working through NPM errors, don't adopt this framework. If you are uncomfortable cobbling together a working framework from the myriad of PRs in this repo, don't adopt this framework. Once you get it working and you understand it's quirks, it's fine.
MJML seems like the next best option, but it has a completely different philosophy behind it. It is limited in scope and rigid in design - which is completely fine for some applications and a complete non-starter in others.
Unless you have the confidence and ability to maintain your own fork, you should not adopt this framework.

I have been using foundation for Emails 2.0 since 2015.  I use to be in regular contact with Rafi (one of the main guys who works on this code base and foundation for sites. As I understand it, there was alot of turnover at Zurb and people I was in regular contact with no longer work there.
I use to be very active on the Forums and helped lots of people with Foundation for Emails 2.0 but as a result of them doing nothing to fix the issues with spam bots;  users (like myself) quit contributing because legitimate users would be marked as spam. Kind of frustrating answering all those questions only to have your post marked as spam. Some answers that were very lengthy sometimes took hours to write.
With that said, I still use the Framework. And while there have been no additions or official releases for quite sometime it's still one of the better options for producing emails. I even took the class that they offered as I have a team of 4 individuals who use this product every day and crank out over 350 emails per year.
I've customized my solution a lot and taken advantage of items that were on git.  But not even seeing any of the moderators post on this tread is very disheartening. I'm not saying you should find an alternative solution, I'm saying you will get very little help from the people who wrote the code base and it's mainly up to die hards to keep it alive.

Hi,
sorry but most of us o not get any notifications about new issues or comments.

@st-h

Just as a side note, I switched from mjml to this project because I encountered too many limitations using mjml (especially regarding templating support)

👋Would be happy to discuss about those limitations ? (You can come on mjml slack if you want?)

@iRyusa Among other things I had to create a daily digest which is composed of various events. In the end the requirement was to create a handlebars based template (using Mjml or foundation) which then can be compiled by the backend server (using handlebars) and then sent out via email. If I remember correctly back then custom components were not working or not finished - at least there were a few major issues. At last it turned out to be a major pain to create such a complex template using Mjml. This was probably a year (maybe 2) ago. Sorry, just a little too long ago to provide a lot of details. And I can't say anything about recent development though.
@DanielRuf that sounds like a real major issue, if the maintainers are not even able to get notified about what is going on within the repo. Is there any way to fix that? As much as I personally like foundation-emails, and I am aware that we do not have a lot of alternative frameworks out there, but by now I am really getting worried as well.

@DanielRuf that sounds like a real major issue, if the maintainers are not even able to get notified about what is going on within the repo

I am not a maintainer in this repo but foundation-sites. This is not group wide.

@shnizmuffin, I'm not uncomfortable working through NPM errors, but I can't use an abandoned repo in production. And I don't think fork this repo for upgrade only for myself is a good think.
@DanielRuf So, who is the maintainer, can he come and take care of it?

It is not abandoned, life is just more important for most of us and we are volunteers who do this in our spare time.

@DanielRuf for this question - but you don't work at Zurb if I understand correctly.   As such, for people to use this confidently (or start to use this in production as I have been using it in production for over 3 years now) there would need to be more support for it.  The problem that I have is that no one from Zurb is saying yes it is still a Framework maintained by the people who built it or NO it is not something we maintain anymore and let users make pull and push request.
According to Zurb's website, they still accept money for their training courses (but there are all just videos) https://zurb.com/university/responsive-emails-foundation?utm_campaign=Footer+Upsell&utm_content=Footer&utm_medium=Docs&utm_source=Foundation+Docs which I find odd being that there has been no major activity on this repo for quite some time.
I don't think @Vilsafur is accusing you of anything, I think his understand (and correct me if I'm wrong) are that you are one of the programmers from ZURB.  That does not seem to be the case.  No one is blaming you for having a life especially if you're a volunteer, but if you were an employee of ZURB and telling us "it's not abandoned, life is just more important for most of us" is really a turn off when it comes to using a framework that many of us rely on to keep our own clients happy.

In general you are right but keep in mind: this is opensource, see the MIT license ;-)

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.

I'll ask the other Yetinauts / Foundation Sites contributors and maintainers how we can proceed here with Foundation Emails as most of us have no push permissions here.

Thanks @DanielRuf !

@DanielRuf I think the issue most people are having is that

PRs are not getting merged
there does not seem to be anyone around who is able (has the necessary permission) to maintain this repo
the last commit > 2 years, ~50 unresolved PRs, a couple of hundred issues is treated as an indication of progress no longer being made. This is not necessarily an issue for developers themselves, but at very least for the companies who are paying the devs

I am aware that there are some people around who expect OSS to be a magical bullet which solves all their problems without having to spend any money or invest time in implementing, maintaining or fixing stuff. However, there are a lot of people around who are willing to dedicate to a framework, if that work inevitably will not end up as an open PR that will never get merged. So, mostly this is a chicken and egg problem imho. I think there are quite a few options to solve these issues, however almost each of them requires at least write permissions to the repo etc.

Indeed, I am not accusing anyone, and I am also ready to contribute to the framework.
Only if my contributions can one day be taken into account.
I realize that @DanielRuf is not a member of Zurb.
As @st-h said, the problem is that the last commit was over 2 years ago, there are ~ 50 PRs pending and ~ 270 issues pending as well.
For having tested Foundation for mail and mjml, I much prefer to use foundation, but if it is not maintained any more, how do you want me to explain to my superiors that the adoption of foundation will be a perennial solution?

Duplicate #893

Foundation Emails is still actively maintained and developed.

@st-h

Just as a side note, I switched from mjml to this project because I encountered too many limitations using mjml (especially regarding templating support)

👋Would be happy to discuss about those limitations ? (You can come on mjml slack if you want?)

@iRyusa Just a short heads up: I finally gave mjml another try and the compiled mail templates are shorter and the rendering in the client is more consistent. Great work! so far everything improved nicely since I tried a few years ago.


Option to skip QC steps, e.g., when processing filtered datasets.

Make sure you test on the latest master version of bakana. (Though fix #131 first, otherwise custom selections will err out.)

@jkanche Receiver for quality_control_DATA needs to handle the case when the response is null; this should skip the plotting and evict any existing QC plots, e.g., in the case of a re-analysis.


[BugFix] Fix query partition compensate predicates for mv rewrite

Fixes #issue
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 86 / 95 (90.53%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
57
64
89.06%
[465, 490, 823, 830, 872, 873, 874]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/BaseMaterializedViewRewriteRule.java
19
21
90.48%
[100, 101]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewRewriter.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/MvRewriteContext.java
2
2
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 91 / 103 (88.35%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/common/Log4jConfig.java
12
18
66.67%
[198, 199, 200, 201, 207, 211]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
27
31
87.10%
[830, 872, 873, 874]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/BaseMaterializedViewRewriteRule.java
25
27
92.59%
[100, 101]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/RewriteContext.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
19
19
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/MvRewriteContext.java
4
4
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-3.1


Microsoft Rewards Extension Request

Is it possible to go to the chrome web store and install the extension from there through the script? Or load an crx file of the extension? I believe doing so unlocks the prediction game, and it is a extra 15 points I'm pretty sure

is this an extension? i think its a python script, idk about you tho

If you want a make a pull request for this feel free. I do not have the Chrome extension installed and it is on my account so I am not sure if that is what brings it up for people.

No plan on implementing this


Update sys-dm-exec-background-job-queue-stats-transact-sql.md

if we want to know how many failed attempts we got we must compare the set of "all the attempts".  but  the column "enqueued_count" is not the number of "all the attempts" but "Number of requests successfully posted to the queue", so to me it seems that if we want to calculate the set of "all the attempts" we must sum enqueued_count + enqueue_failed_full_count + enqueue_failed_duplicate_count (Number of requests successfully posted to the queue + Number of failed enqueue attempts because the queue is full + Number of duplicate enqueue attempts ) but actually i'm not sure about "Number of duplicate enqueue attempts" (these are to count or not in the set of all the attempts?). maybe a duplicated event raises only when the queue is full so we must exclude the  "Number of duplicate enqueue attempts"  from the set  "all the attempts".   thank you best regards

@baleng : Thanks for your contribution! The author, @stevestein, has been notified to review your proposed change.

@baleng - Good catch. Thanks for updating the example.

#sign-off


Upgrade: 0.41.1-1 -> 0.41.1-2 crashed completely and hyprland don't initialize

Regression?
Yes
System Info and Version
 System/Version info
<Paste the output of the command here>

Description
After upgrading from version 0.41.1-1 to 0.41.1-2 hyprland wouldn't startup, I had to use tty and manually downgrade:
sudo downgrade 'wlroots=0.17.3-1' 'libdisplay-info=0.1.1-3' 'hyprland=0.41.1-1'

How to reproduce
upgraded and had the issue.
Crash reports, logs, images, videos
couldn't find a crash report.

Can you bisect?

this is an arch packaging moment. Perform a proper update of your system, possibly recheck your mirrors for some lagging ones.

Hello, I'm properly updated: see https://archlinux.org/packages/extra/x86_64/hyprland/ (latest version is 0.41.1-1).
@fufexan - how would you suggest for me to bisect? those two are sequential update, no way to further bisect from package-manager point of view :thinking: .

Well you can diff the PKGBUILD file and see what changed. Also I don't think external wlroots affects Hyprland, and if it does, it shouldn't.

literally nothing changed but arch packaging, so it's not an issue on our side

I found this:

In here: https://archlinux.org/packages/extra/x86_64/hyprland/

this seems to be the commit difference:
https://gitlab.archlinux.org/archlinux/packaging/packages/hyprland/-/commit/006ffcfb34f45152724903f10ee429c2b52fe0ff

The only difference seems to be upgrade of libdisplay-info to version 0.2.0

I have engaged with the package maintainers but it seems that they can't help me understand what is going on 😢
I made a video showing what is happening (basically I cannot manage to pass the login screen): https://gitlab.archlinux.org/archlinux/packaging/packages/hyprland/-/issues/11#note_194829
Could you give me any advice about where I could find logs and info about potential issue?
I couldn't find any specific hyprland crash reports from tty

what if you build hyprland manually?

I could try that but my concern is that I would still lack the skill to debug an issue like that if something was to go wrong and it would become even harder for me to rollback. I completely understand your concern about the package manager but it's jsut the least worst solutio9n for mortals like me that are trying to minimize their time spent on upgrading while still getting some job done during the day :D
this issue could even be unrelated to hyprland itself and maybe only related to the tool I use as login/llock window but I've been strugling to find the time to go back and debug even my own tools.
Do you have any advice about files or crash reports that i could find from TTY if I attempt this upgrade once more just to try to drill-down where the problem might be?

I found a futher lead:

cat .local/share/sddm/wayland-session.log
Hyprland: error while loading shared libraries: libdisplay-info.so.1: cannot open shared object file: No such file or directory

it seems that after the upgrade above Hyprland cannot find the `libdisplay-info.so.1` lib...

Before the upgrade:
❯ ldconfig -p | grep display
        libdisplay-info.so.1 (libc6,x86-64) => /usr/lib/libdisplay-info.so.1
        libdisplay-info.so (libc6,x86-64) => /usr/lib/libdisplay-info.so

after the upgrade:
❯ ldconfig -p | grep display
        libdisplay-info.so.2 (libc6,x86-64) => /usr/lib/libdisplay-info.so.2
        libdisplay-info.so (libc6,x86-64) => /usr/lib/libdisplay-info.so

I found the issue - at the end the issue was that I had 2 hyperland versions installed - one was compiled from source by me and the other was the package manager one - after upgrading some system libs the one compiled from source broke cause it expected the libdisplay-info version 1. I've removed the version compiled from source and it works well again...


Don't automatically try to upgrade the cluster on config create

We shouldn't touch an existing cluster unexpectedly.
This was nearly an issue for me when I wanted to upgrade an existing cluster. I.e. I wanted to load the config without changing the cluster, which was not possible.
Now, just warn the user if there's an existing cluster.

/tmp/samples/kctf/bin/kctf-cluster: line 289: syntax error near unexpected token `;'
/tmp/samples/kctf/bin/kctf-cluster: line 289: `  if [[ "$***START_CLUSTER***" == "1" ]] || ; then'


Question: exec and stdout/stderr

I am trying to use the exec function within a release to compute a value via a script. It's a somewhat complex bash script I have, so I would like to add some diagnostic logging in case it goes sideways. What I thought would happen is that whatever is written to stdout would be used as the computed "value", so I figured I could write to stderr for my diagnostic information, but it seems that stderr is also being consumed and appended into the "value".
Is this expected? Is there somewhere else (other than a file) that I could write diagnostic logging information to?

Yes. That's expected. We explicitly use stderr to capture error message that should be shown when the command exited with a non-zero code.

Thanks for the response.
I certainly think it makes sense to capture stderr to show any error messages. I'm not sure it makes sense to capture stderr as part of the output used for the value (in the case the script still returns zero).

Any feedback on that? Is that some that could be changed so only stdout is used as the value and stderr could be used for logging? Is there some other possible solution?

Oh, well, Helmfile should use only stdout as a value. It's coded here:
https://github.com/roboll/helmfile/blob/master/pkg/helmexec/runner.go#L74
So what you might be seeing can be a bug?
Would you mind giving me an example for reproduction so that I can investigate further?

Here is a minimal example:
helmfile.yaml:
repositories:
- name: incubator
  url: https://kubernetes-charts-incubator.storage.googleapis.com

releases:
- name: test
  namespace: test
  createNamespace: true
  chart: incubator/raw
  values:
  - resources:
    - apiVersion: v1
      kind: ConfigMap
      metadata:
        name: test
      data:
        value: {{ exec "./test.sh" (list "test") }}

test.sh:
#!/bin/bash

echo "stderr $1" 1>&2

Output from helmfile diff:
Comparing release=test, chart=incubator/raw
********************

        Release was not present in Helm.  Diff will show entire contents as new.

********************
test, test, ConfigMap (v1) has been added:
-
+ # Source: raw/templates/resources.yaml
+ apiVersion: v1
+ data:
+   value: stderr test
+ kind: ConfigMap
+ metadata:
+   labels:
+     app: raw
+     chart: raw-0.2.3
+     heritage: Helm
+     release: test
+   name: test

Version:
❯ helmfile -v
helmfile version v0.116.0

❯ helm version
version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.14.2"}

❯ helm plugin list
NAME    VERSION DESCRIPTION
diff    3.1.1   Preview helm upgrade changes as a diff
secrets 2.0.2   This plugin provides secrets values encryption for Helm charts secure storing

@mumoshu - Were you able to reproduce this?

@cdunford Hey! Thanks a lot for the reminder. I've managed to reproduce it. The fix is on-going in #1298

@cdunford The fix is available in v0.118.6

👍

@mumoshu - so this is working, but would it be possible to get stderr logged in all cases (not just failure cases)? I don't believe there is currently a way to get any sort of debugging info from a successful exec script, correct?

@cdunford There's a PR that turns Helmfile to log every stdout/stderr line by line when and only when --debug flag is provided. https://github.com/roboll/helmfile/pull/1354
Would it work?

No I don't think so; in my use case I'm looking for something that doesn't require the --debug flag and would be more for info level logging from the exec script and would support secret masking similar to what's described in #1397.
What I think would meet my needs (maybe not others though) is to always output stderr from an exec script and mask and secret values in it (or perhaps there could be another parameter passed to exec to enable this, similar to showlogs for hooks, but I don't want to have to pass --debug to get this output as this gives me way more than I want).

@cdunford I think I got it. What if we had showstderr: true under hooks to enable forwarding stderr from the hook in near realtime?

@mumoshu just realized you responded when I looked back on this thread after the latest convo slack. My request is around exec, not hooks; I think it would great if stderr was always logged even if exec is successful.


Runtime error: PS:Is this module depreciated?

No module named 'magenta.protobuf'
I have no idea where to find this particular module/script.

it seems it moved to magenta.music.protobuf

#uses pip install magenta
to make sure used the upgrade option
#ALL white

THANK YOU VERY MUCH.


bug: [Do not log assignment when DoLog is absent or not explicitly true] (FF-3109)

Observation

Customer started an experiment with 1% percent exposure.
They saw 100x the assignment volume

After investigating the cause, found that the default allocation was responsible for the overage. We should not be logging these events.
🎫 https://linear.app/eppo/issue/FF-3109/kargo-experiment-generated-much-more-exposures-than-expected
Changes
Only log when DoLog on an allocation is explicitly true

@leoromanovsky just to confirm, this PR just adds the tests and does not change the client behavior?

@leoromanovsky just to confirm, this PR just adds the tests and does not change the client behavior?

Yes - originally I thought there might be a bug but after further investigation the implementation is desired, just added tests to cover all cases.


Is there a way to use cargo-clif clippy in VSCode too?

I'm using cranelift for a while now.
I'm using VSCode too and these settings:
"rust-analyzer.checkOnSave": true,
"rust-analyzer.runnables.extraEnv": {
    "RUST_BACKTRACE": "0"
},
"rust-analyzer.cargo.extraArgs": [
    "--target-dir",
    "target/rls/"
],
"rust-analyzer.check.command": "clippy",

I'm wondering if there is a way to speed-up the "cargo-clif clippy" too directly in VSCode.
What do you think?

Clippy is effectively doing a check build, skipping codegen entirely. As such the only case where you would benefit from using cg_clif with clippy is if you are changing build scripts, proc macros or their dependencies as those are the only things for which codegen actually happens in a check build.