CWA performing checks (nearly) every time I open the app

[x] Bug is not mentioned in the FAQ
[x] Bug is not already reported in another issue

Describe the bug
When I open cwa it downloads the new files and checks them. But: often this happens twice! When I leave the app then and reopen it after 10 minutes it's downloading the files again – you may see it in the log. This issue could be related to #916 or #1542 but in #1542 one of the files is empty; my logs always do contain "new" files (which are the same as ten minutes before obviously).
It's happening randomly. This morning I can't get cwa to update (intended behaviour as the last check was last night at 01:28 when I opened the app), yesterday it updated every time I opened it – only 01:28 contained the new DC6C131E[...] file.

Technical details

iOS Version: iOS 14.2
Device: iPhone 7

Dear @Mihahn,
Thank you for your contribution. Your post seems a duplicate of actually two issues.
Please, continue any further contribution regarding duplicate checks here #1505.
Also, have alook here https://github.com/corona-warn-app/cwa-app-ios/issues/1514#issuecomment-727602796, please.
Can you confirm you are using CWA version 1.6.1 ?
Best wishes,
DS
Corona-Warn-App Open Source Team

Thank you for your reply and I'm sorry I missed those issues.
I didn't know I had connection issues (which might be the root of the problem) – but this seems to be the cause. And yes, I am on 1.6.1. Thanks again!

Thanks again for reporting. I will close this issue now, you will find further updates regarding these issues in the aforementioned issues.
Best regards,
DS

Corona-Warn-App Open Source Team

Duplicate of https://github.com/corona-warn-app/cwa-app-ios/issues/1505


Add exception hierarchy

Implement all exception types defined in the guidelines

Implemented in v2-sdk branch (hosting new azure core modules), this branch will be master soon


how do I fill the masquerade_address field?

#Specify a masquerade address and the range of ports to use for
#passive connections.  Decomment in case you're behind a NAT.
#handler.masquerade_address = '<IP_ADDRESS>'
#handler.passive_ports = range(60000, 65535)
Currently I set handler.masquerade_address = '',it worked,but sometimes fail,the error message is "
[W 2019-04-19 20:34:43] <IP_ADDRESS>:45431-[user] Rejected data connection from foreign address <IP_ADDRESS>:47558." , how do I set the  value of 'handler.masquerade_address' to avoid the above issue? Thanks very much!

If you know the public IP of the server you deploy pyftpdlib based app onto them you can hard code it.
I assume you don’t know that tho. In this instance I have a function this_ip() which returns the ip. I need to ping out to a service to ask for the IP, maybe you can use AWS metadata service if your deployed on AWS.
If you add some more context around why you don’t know the address I can help with solutions I find to work.

thanks


Debug

some alignment issues?

Yes looks like there is a bug on arm v7 (maybe with some compilers only, not sure yet).


Support for margins/gutters

Love this simple plugin, thanks for sharing!
Would be great if there was an easy way to support margins around images.
For example:

Adding padding or a border currently throws off the layout.
Any chance of adding support for this or any suggestions on how to get there myself?
Thanks!

Hi Erin,
So much thanks for your suggestion! It is indeed a great idea to add this feature. So great, actually, that I’ve just added and released it! Check out the latest version of jQuery Mosaic with support for outer margin and inner gap between elements: http://jquery-mosaic.tin.cat http://jquery-mosaic.tin.cat/
Thanks!

On 23 Sep 2016, at 03:19, Erin Keeffe<EMAIL_ADDRESS>wrote:
Love this simple plugin, thanks for sharing!
Would be great if there was an easy way to support margins around images.
For example:
https://cloud.githubusercontent.com/assets/1291167/18771112/09e12978-80f1-11e6-925a-592a78704807.png
Adding padding or a border currently throws off the layout.
Any chance of adding support for this or any suggestions on how to get there myself?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/tin-cat/jquery-mosaic/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDFRJqVPO-Se6v_zy6o2kHsUHdshVqDks5qsyk5gaJpZM4KEhNx.

Wow thank you!


Discrete differences between adjacent grid squares (version 2)

New PR to finish @gavinevans work on gradients between adjacent cells.
Issue: #83
Comments and responses on previous PR #142
Testing:

[x] Ran tests and they passed OK
[x] Added new tests for the new feature(s)

Does the metadata fully describe the new data in the output cube. What does an output cube look like?
Does the name change? Do we have a convention for this?

The output is two cubes, one for each of x, y coords. The name of the input is preserved as are the input units and any cell methods/attributes on the input cube. Most coordinates are preserved, but the x,y coords will be staggered accordingly. In addition, the new cube has a new attribute: form_of_discrete_difference which is set to forward, and a new cell method: discrete_difference.
We don't really have firm conventions. Gavin and I looked for any kind of gradient etc in the cf conventions but couldn't find anything similar; the new attribute and cell_method seemed sensible to us. Maybe the name of the cube should change.

Yes, maybe the cube name should change. What about the units as well?
I understand that it is useful to add a cell method to cover this, but I think cell methods are rather tightly controlled by cf conventions. Have you had a look at this section of the cf conventions?

All tests run successfully  on the desktop.
All changes requested by Stephen completed.
Everything looks good.

Output cube looks like this:
difference_of_wind_speed / (m s-1)  (projection_y_coordinate: 970; projection_x_coordinate: 1041)
     Dimension coordinates:
          projection_y_coordinate                           x                             -
          projection_x_coordinate                           -                             x
     Scalar coordinates:
          forecast_period: 43200 seconds
          forecast_reference_time: 2017-02-20 03:00:00
          height: 10.0 m
          realization: 0
          time: 2017-02-20 15:00:00
     Attributes:
          Conventions: CF-1.5
          form_of_difference: forward_difference
          grid_id: enukx_standard_v1
          institution: Met Office
          source: Met Office Unified Model
          title: Operational MOGREPS-UK Model Forecast
          um_version: 10.4
     Cell methods:
          difference: projection_x_coordinate (1 grid length)

The code in this pull request was initially written by @gavinevans. It was reviewed and corrected by @Katie-Howard  and @meabhnicguidhir. @MoseleyS  reviewed the changes, but I have ensured that his comments have been addressed. I have done a final review and am therefore happy to merge.


Handling log text in code blocks

Context
Displaying log output inside of a code block.
The logs are generic text and would not benefit from syntax highlighting.
While still allowing other code blocks to highlight in appropriate languages.
Issue
Inline code blocks `example.md` and code blocks without a language flag
```
example.md
```

Both will automatically attempt to guess the language being used.
In the examples above, language css is guessed, which renders the filename as an element, and the extension as a css class.
Potential solution
Add a flag that disables automatic language guessing when language flag is missing from code block.

Hey @ChristianMurphy! If you can figure out the correct options to pass to the LowLight component (that this project just wraps) to make that work, I'm all for it. Even better if you make a PR!


IN Queries Failing w/ OTEL Configured

Not sure if this is a bug or I'm doing something wrong here...
When I add tracing like so:
driver, err := otelsql.Register("postgres", "postgres")
if err != nil {
   return nil, fmt.Errorf("registering Postgres driver for instrumentation: %v", err)
}
pgConnection, err := sqlx.Connect(driver, pgOpts)

I'm getting errors only with IN queries that I construct like so:
query, args, err := sqlx.In(getTeamsForEnvsQuery, envIds)
if err != nil {
    return nil, errors.Wrap(err, "error creating 'IN' query")
}
var results []TeamEnvResult
if err = t.SelectContext(ctx, &results, t.Rebind(query), args...); err != nil {
    return nil, errors.Wrap(err, "error querying team table for teamIds")
}

where getTeamsForEnvsQuery is:
SELECT e.id as "environmentId", p."teamId"
FROM product p
JOIN environment e ON e."productId" = p.id
WHERE e.id IN (?)

(using github.com/jmoiron/sqlx as my postgres client)
When I forget about otelsql and just register the driver like so i get no errors and everything runs smoothly:
pgConnection, err := sqlx.Connect("postgres" /*driver name*/, pgOpts)

Am I doing something wrong here? Or is this an issue?

Thanks for filing this issue. @mnotti
Would you like to paste errors so I will have more context about this issue? Also, do you have a small project that reproduces the errors? It would help me a lot if you could put up a ready reproducer.

Hi @XSAM sorry for the long delay, I ended up tabling the issue and forgetting about it until it bit me again (which is now) ...
Slightly different situation now, but I have an example of similar behavior w/ clickhouse instead of postgres. (when I drop the otel stuff it works)
Pushed an example here: https://github.com/mnotti/otel-failure-example which when executed w/ go test ./... will fail with the following error:
client_test.go:43:
        	Error Trace:	client_test.go:43
        	Error:      	Received unexpected error:
        	            	driver: skip fast-path; continue as if unimplemented
        	Test:       	TestTableCreateInsertSelect

However, if you comment out https://github.com/mnotti/otel-failure-example/blob/8e3d929c026d45ce66e609572d0e508d1ea96e3d/client.go#L33-L37 and uncomment L38 to remove the OTEL driver logic, everything passes just fine.
What's strange is it hiccups on
tx, err := ch.BeginTx(ctx, nil)
assert.NoError(t, err)

Hi, @mnotti thanks for providing the reproducer.
otelsql assumes every driver.Conn implements these driver.XXXContext/driver.XXXTx interfaces that use context.Context for span collection.
https://github.com/XSAM/otelsql/blob/b8a2dd4f7f2455ddf98eb8f08e5f2f87be809e08/conn.go#L24-L35
But if a driver.Conn did not implement these interfaces, like clickhouse.stdDriver did not implement driver.ConnBeginTx, it will throw driver.ErrSkip error.
https://github.com/ClickHouse/clickhouse-go/blob/ee79713daf7a10ba3b363797f74b0909be463b49/clickhouse_std.go#L92-L95
https://github.com/XSAM/otelsql/blob/b8a2dd4f7f2455ddf98eb8f08e5f2f87be809e08/conn.go#L184-L187

Here are my proposals:

otelsql can return a certain struct that does not implement certain interfaces depending on the underlying implementation.
c := &otConn{
	Conn: conn,
	cfg:  cfg,
}

if _, ok := conn.(driver.ConnBeginTx); ok {
	return c
}

// Only implements driver.Driver
return struct {
	driver.Conn
	driver.Pinger
	driver.ExecerContext
	driver.QueryerContext
	...
}{c, c, c, c}

But there are too many combinations to fully support these exceptions. I would not recommend this.

Let clickhouse.stdDriver support driver.ConnBeginTx.

@mnotti about

Let clickhouse.stdDriver support driver.ConnBeginTx.

I went around a similar problem by wrapping the original driver, you can check it here: https://github.com/sourcegraph/sourcegraph/pull/39300/files#diff-bc34aa163694ecf12848f338a0eccb4a222a5d61dc30061d597fc78f8238c906R86

I think this issue should be fixed, as the clickhouse recently implemented the driver.ConnBeginTx.
https://github.com/ClickHouse/clickhouse-go/blob/8b2d0a80754beb334f1ffc9e8b50df4d433cdd40/clickhouse_std.go#L202

Feel free to re-open this issue if you have any questions.


added clarification on what the permissions are for.

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66427471eb560026b8b25df2--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6642759223917d2506bf09fc--harness-developer.netlify.app


Starting client failed

OS: Ubuntu 18.0.4LTS
rustc: 1.45.2
vscode: 1.48.1
Rust extension: 0.7.8
rust-analyzer: 0.2.281
Error output:
[Error - 11:38:12 AM] Starting client failed
Launching server using command /home/john/.config/Code/User/globalStorage/matklad.rust-analyzer/rust-analyzer-linux failed.
It didn't provide any further failure reason.
I tried to manually run the "rust-analyzer-linux", it just block there without any output, and does not return to the command prompt. I have to hit Ctrl+c to kill it.
I also tried recent older version of rust-analyzer, all failed with the same error
Tied to clean up the extension and downloaded rls sever from disk. Nothing helped.

I've encountered this as well.
The actual rust-analyzer-linux binary seems to be ok though:
$ /home/tomas/.config/Code\ -\ OSS/User/globalStorage/matklad.rust-analyzer/rust-analyzer-linux --version
rust-analyzer 3ca97b0

Aaaargh, ok - for me the issue was that the VSCode workspace contained rust projects (with own Cargo.toml etc)  that got deleted. I guess rust-analyzer then tried to run it in those folders, but since they no longer exist, that of course fails.
Simply removing those deleted folders from the workspace fixes the issue.

@johncrane are you still having this problem?


Not able to install it on newer ionic version

I get this error when I try to add it here

Installing "com.phonegap.plugins.twilioclient" for android
Android Studio project detected
Subproject Path: CordovaLib
Subproject Path: app
Installing "com.phonegap.plugins.twilioclient" for ios
Failed to install 'com.phonegap.plugins.twilioclient': undefined
(node:1438) UnhandledPromiseRejectionWarning: CocoaPods was not found. Please install version 1.0.1 or greater from https://cocoapods.org/
(node:1438) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1438) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Hi,
Do you have Cocoapods installed on your computer?
pod --version
If not, you'll need to install it from that web site.
Thanks!

After installing it does not allow me to build
This is the error I'm getting while building an APK
RE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processDebugResources'.
> Failed to execute aapt

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 41s
    at ChildProcess.whenDone (/Applications/MAMP/htdocs/acs-now/platforms/android/cordova/node_modules/cordova-common/src/superspawn.js:169:23)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at maybeClose (internal/child_process.js:925:16)
    at Socket.stream.socket.on (internal/child_process.js:346:11)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at Pipe._handle.close [as _onclose] (net.js:567:12)
(node:888) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:888) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I fixed the issue by installing
cordova plugin add cordova-android-support-gradle-release --fetch
And then removing and adding android platform again
ionic cordova platform rm android && ionic cordova build android

Hey @jefflinwood Can you please tell how to import this twilio in my app as I don't think you have the typings available or any npm package that helps ?


It seems no API to bind local endpoint for ssl_stream as a client

I need bind to some local endpoint to send https request.
...
beast::ssl_streambeast::tcp_stream stream(ex, ctx);
//put this before connect would throw bad file descriptor.
beast::get_lowest_layer(stream).socket().bind(tcp::endpoint(boost::asio::ip::make_address_v4("<IP_ADDRESS>"), 10000));
I checked the source code and could not find an API to bind to local endpoint as a client.
Any help would be appreciated. Thanks

You must open() a socket before you can bind() it.

You must open() a socket before you can bind() it.
Thanks for your help.

net::io_context ioc;
auto ex = net::make_strand(ioc);
beast::ssl_stream<beast::tcp_stream> stream(ex, ctx);

beast::get_lowest_layer(stream).socket().open(boost::asio::ip::tcp::v4());
beast::get_lowest_layer(stream).socket().bind(tcp::endpoint(boost::asio::ip::make_address_v4("<IP_ADDRESS>"), 20001));

auto ep = tcp::endpoint(boost::asio::ip::make_address_v4("<IP_ADDRESS>"), 443);
beast::get_lowest_layer(stream).connect(ep);
sleep(500);

Then with netstat, I can see a connection <IP_ADDRESS>:20001<---><IP_ADDRESS>:433 was established as expected.
But if I used a resolver, there was no error/exception when run the program, but the local port was still randomly chosen.
net::io_context ioc;
auto ex = net::make_strand(ioc);
beast::ssl_stream<beast::tcp_stream> stream(ex, ctx);

tcp::resolver resolver(ioc);
// Look up the domain name
auto const results = resolver.resolve("www.baidu.com", "443");

beast::get_lowest_layer(stream).socket().open(boost::asio::ip::tcp::v4());
beast::get_lowest_layer(stream).socket().bind(tcp::endpoint(boost::asio::ip::make_address_v4("<IP_ADDRESS>"), 20001));

beast::get_lowest_layer(stream).connect(results);
sleep(500);

Yes, connect() will automatically open and bind the socket to an ephemeral port. Manually binding the socket is a lower level operation.

I guess I figured it out.
auto ep = tcp::endpoint(boost::asio::ip::make_address_v4("<IP_ADDRESS>"), 443);

//this would call below function in basic_stream.hpp
//void
//connect(endpoint_type const& ep)
// {
//    socket().connect(ep);
// }
// It just connected directly, did not close the socket  first.
beast::get_lowest_layer(stream).connect(ep);

but
auto const results = resolver.resolve("www.baidu.com", "443");

//this would call
//template <typename Protocol, typename Executor,
//    typename Iterator, typename ConnectCondition>
//Iterator connect(basic_socket<Protocol, Executor>& s, Iterator begin,
//    Iterator end, ConnectCondition connect_condition,
//    boost::system::error_code& ec)
// in connect.hpp, which would close the socket first for each result in the iterator.
beast::get_lowest_layer(stream).connect(results);


github anchor

Hi,
We have several pages in a github wiki which use anchors to navigate within a page. In github markdown it looks like this:
[Some text](#header-1)
# Header 1
This works fine. If I look at the HTML this leads to on github:
Some text

If I run the same markdown content through showdown, the html it generates is
Some text

Header 1

So it seems to have removed the space from the header text to generate its id. As they are no longer matching, the navigation is no longer working. Is there some setting I'm missing?
Thanks!

The behavior of showdowns generated Ids follows the original markdown.pl, the parser made by markdown's aithor, John Gruber.
This behavior, however, is a bit different from github, which uses a different set of rules, mostly for internal linking and compatibility issues.
Currently you cannot match git hubs behavior.
However it should not be very difficult to implement an option to emulate this.
Do you mind post the list of rules github uses to generate IDS?
I can use that list as a base for said option!

Thanks for the quick response.
So far I haven't been able to find the list of rules.
The page that contains the gfm information, https://help.github.com/articles/github-flavored-markdown/, doesn't say anything about the identifiers unfortunately.
Perhaps an easy fix would be to allow a user to provide a parameter with which to replace the non-word characters in the Headers? I think replacing the non-word characters with "-" would already lead to a working solution.


The size of buttons isn't calculated. calculateWidths() isn't called after navigation to viewController on AppBecomeActive event

Environment: XLPagerTabStrip - (9.0.0), Xcode - 10.3 (10G8) and iOS 11.0 - 12.4;
The app is opened with push notification - so the view controller is pushed right after appDidBecomeActive. In this case the methods are called in this way: viewWillAppear() -> viewDidAppear() ->  viewDidLayoutSubviews(). So property "isViewAppearing" is set to false before viewDidLayoutSubviews() is called and the following code isn't called: cachedCellWidths = calculateWidths(). As the result - the size of buttons is wrong.

Hey, did you manage to fix that?

Hey, did you manage to fix that?

Hi there. Yes, but my solution isn't perfect.
All I did was forcing my vc to layout
let someViewController = ... ()
someViewController.view.setNeedsLayout()
someViewController.view.layoutIfNeeded()

and then push or present this view controller.
If you are using storyboards and segues, then maybe call that two lines in prepareForSegue.
Also keep in mind that this workaround may be broken in the next iOS versions, cuz as we can see, apple changes the way segues works sometimes.


Fire a webhook when identity changes are made

Read a webhook URL in environment configuration or similar and call it with the GT username and the new list of groups for the user any time a user's groups are changed. We would also have to authenticate the message in some way to prevent unauthorized privilege escalations.
We would build a separate application to handle that event and call other applications' group management APIs (out of scope for this issue).
This would enable faster and more seamless authorization changes across all our managed applications.

Authentication idea: don't provide new groups, just username, then have the handler access the user's information using the usual API endpoint

Vault, SUMS need this, other apps are nice to have

The webhook should include the following information in some format (JSON suggested):

Affected GT username
Active flag in Apiary
List of teams the user is a member of (with name and apiary numeric ID for each)
Preferred first name
Last name
Personal email address

The webhook should fire when the following events occur:

Any change is made to the user model itself
Any user joins or leaves any team
A dues package transitions from active to inactive or v.v.
An administrator selects a Nova action to fire the webhook

Each webhook should have information for one user. If multiple users are modified at once (for instance, when a dues package transitions), a webhook should fire for each affected user.
Webhooks should be queued as needed and fire in a background job via Horizon so that requests do not hang.

Added in #574


Successful run - Just a blank admin page??

I am not clear on what a successful run looks like.
Write a short description of the issue here ↓
I was able to pull down the latest repo, set my .env and run the Debug> dev script in the package.json file. When clicking on the app link in the dev store, I just get a blank page. Is that it? If not, what could be wrong?
What do you think should happen?
I was expecting to see at least HomePage and ProductsCard from the src/components directory.
What actually happens?
Here are screenshots of what I see, source, and console.

The best way to get your bug fixed is to provide a reduced test case.
Specifications

Browser: Chrome
Device: Intel i7
Operating System: Windows 10 Pro

Hi @jfk86d — could you try running your app with shopify app serve?
This template assumes you have it installed and the debug script is meant to connect to the running server to allow you to try out breakpoints in the node dev tools. @paulomarg we should clarify this.

Hi @JaKXz , thank you for your reply and suggestion. I ran shopify app serve. Got the error below. The error noted "ngrok tunnel not running". I confirmed it is and all URLs are updated in .env as well as in the app setup. Further, I could see requests on the ngrok inspect page (http://<IP_ADDRESS>:4040/inspect/http). Any ideas? Thanks, John

@jfk86d Are you by chance using a paid ngrok account? If so you may have to terminate the tunnel using shopify app tunnel stop then shopify app serve I don't believe the cli currently accounts for non-expiring tunnels so you have to manually switch it by stopping the ngrok process.

@jfk86d Are you by chance using a paid ngrok account? If so you may have to terminate the tunnel using shopify app tunnel stop then shopify app serve I don't believe the cli currently accounts for non-expiring tunnels so you have to manually switch it by stopping the ngrok process.

Hi Michael-Gibbons, thank you for the fast reply. I am using a free ngrok account. Process I went through was to start ngrok, copy new address, edit .env and the URLs on the App Setup page. Then run the shopify app serve command.

@jfk86d  - did you ever find a solution to this?

Not sure if this will be helpful to anyone, but I had this issue when creating an app with post-purchase page extension, and managed to fix the issue by doing the following

Create new app using the shopify CLI . yarn create @shopify/app (don't run the app yet)
Create extension yarn generate extension
Start app from within extension directory. cd extensions/my-extension/; yarn dev

I think this process works because using an extension forces you to run the dev server using a tunnel (e.g ngrok). So if anyone else has this blank page issue, try simply running it with a tunnel to see if the issue gets resolved.


Add list-src/doc/example command

The list-src, list-doc, and list-example commands will print all the modules and archives available for use with the install/src/doc/example commands.
The impetus for this PR comes from #453.

I tried to split my fix for #453 into two discrete parts; looks like the split failed. I will submit a more complete PR instead; if you feel like it should be split in half, I will fix this PR and reopen it.


setStyle should pass paletteTextures in WebGLTile Layer and Renderer

Addreses #15100
need to test a bit further as there's a strange artifact that happens in top-left tile when paletteTexture is updated.
EDIT: in further testing, the above i think is an unrelated issue in my application. I do not see it in included examples

Shoule be ready for review!
Modified cog-style example to have style examples with palettes.
compare behavior on this branch
https://deploy-preview-15101--ol-site.netlify.app/en/latest/examples/cog-style.html
vs current
https://codesandbox.io/s/cog-style-forked-r2k4fm?file=/main.js

Hey @malaretv - good to hear from you, and thanks for the fix.  Hope all is well!

Thanks to you @tschaub, and likewise!


Project failed to run

I got the following error after trying to use super tabs in my ionic project.

One more question. Do you support horizontal scrolling if I have many icons in the tab? I might have up to 9 icons in the tab and currently the out of the box ionic tab does not support it. Does your tab support it?

What version of ionic2-super-tabs are you using?
Please refer to the Compatibility table to make sure you're using the right versions.

@eddyng8 yes you can scroll between tabs, you will need to add the scrollTabs attribute to your super-tabs component. See here for example code.

I ran "npm i --save ionic2-super-tabs" and I got version 4.0. I will upgrade my ionic version to 3.5.2 now. Thanks.


Downgrading 3.0.15 to 2.3.7 fails, experimental-v3demo cannot be disabled

I have a 3 node 2.3.7 etcd cluster. Its healthy.
I upgraded 1st and 2nd nodes to 3.0.15. 3rd node is leader and complains about versions:
etcd[13529]: the local etcd version 2.3.7 is not up-to-date
etcd[13529]: member 632c48c9b3985929 has a higher version 3.0.15

But the cluster is still healthy.
Downgrading 1st node back to 2.3.7. This node will not start up, because of
etcd[3645]: experimental-v3demo cannot be disabled once it is enabled

Neither 2.3.7 or 3.0.15 config included ETCD_EXPERIMENTAL_V3DEMO=true.
Upgrading 1st node again and its happy. Great of course, but I need a working rollback plan.
What can you suggest?
Thanks!

Will a backup before upgrading work for you?

Yes, its downgrading-the-hard-way, but it will do.
Any idea why the normal downgrade path is not possible?

I've upgraded our clusters without issues. Closing this ticket.

@rtoma You must be remove work-dir, then restart

@JinsYin Which "work-dir" would that be? This is the structure of the etcd2 data dir:
# find /var/lib/etcd2
/var/lib/etcd2
/var/lib/etcd2/member
/var/lib/etcd2/member/wal
/var/lib/etcd2/member/wal/0000000000000002-00000000000319b5.wal
/var/lib/etcd2/member/wal/0000000000000000-0000000000000000.wal
/var/lib/etcd2/member/wal/0000000000000001-0000000000018e6c.wal
/var/lib/etcd2/member/snap
/var/lib/etcd2/member/snap/0000000000000002-0000000000033465.snap
/var/lib/etcd2/member/snap/0000000000000002-0000000000035b76.snap
/var/lib/etcd2/member/snap/0000000000000002-0000000000038287.snap
/var/lib/etcd2/member/snap/db
/var/lib/etcd2/member/snap/0000000000000002-000000000003a998.snap
/var/lib/etcd2/member/snap/0000000000000002-0000000000030d54.snap


Popped out NPC/character blocking out screen upon taking damage

Versions:
Next Up v0.0.62
D&D5e 1.2.4
Both Tidy5e Sheet and the Default 5e NPC Character Sheet
Current settings (that I believe affect this functionality):
Sheets to Open --> Only Unlinked
Sheets to Close --> Unlinked Only (not sure if unrelated, but this does not close popped-out sheets once the token's turn is over)
Sheets to Close --> Unlinked Only
Combatant Sheets to Close --> Previous Combatant
Popout Actor Sheets --> Enabled (this seems to be the setting that causes things to fail)

NPC takes turn in encounter, opens sheet as intended.
Next token's turn. If the NPC token takes damage while its character sheet is popped out, it causes a gray "character sheet-like" window to pop up alongside the already-popped out sheet.
Closing the "gray" window OR the popped out window will "pop in" the NPC character sheet, except the sheet will take up the entirety of the screen and be unclosable, unmodifiable, and requires a refresh of the GM's browser window in order to do anything.

Before taking damage (next token's turn after NPC and NPC's sheet is popped out):

After taking damage:

After closing the NPC's sheet that's popped out:

At this point, the GM must refresh the browser as that sheet takes up the whole screen and is unmodifiable.

This should be fixed with popout v2


Disable ES6 experimental features through compile flag

JsRuntimeAttributeEnableExperimentalFeatures attribute to JsCreateRuntime
enables all experimental ES6 features together. Selective features can be
disabled using compile time options. When a feature is disabled config
takes precedence and it can be enabled.
The scenario is to disable certain feature when chakracore is compiled
with node but still being able to use test/chk build of
Microsoft/ChakraCore to work with node-chakracore for testing.

@curtisman @kunalspathak please take a look. This is to resolve issue https://github.com/Microsoft/ChakraCore/issues/1064

LGTM.


Consolidate Background, Race, and Class/Subclass into a single Row

To stop the features tab in the character sheet from just being a vertical mess of features that don't efficiently use the space, what about changing the layout slightly for the time being with the upcoming Race Items in 2.3 and make the features tab a little more presentable.
Image Photoshopped by MaxPat

It would save a fair bit of room on the character sheet by allowing the basics of the character, ie the Class, Race, and Background to be all next to each other in a single row, alleviating the need to have a "tall" character sheet.
From MaxPat on Discord:
"one thing is that Class and Subclass are grouped, so they take up 2 lines, while background and race are 1 line, maybe a 50% split for Class & Subclass, and Race & Background?"
I do agree with Max on this but dont exactly know how to format the split to make it look nice, especially if some subclasses have longer names, for instance Path of the Ancestral Guardian.

Yea I think the 1/3 split does make the sections too compact, and with multiclassing, that Classes section would bloat the others, so I think having the Race and Backgrounds split a section up top (as a character is unlikely to have more than one of these item types - although I know there was talk in the Race Item issue to allow for multiple race items), then the Classes have their own section where the Class and Subclass items are side-by-side would be a better layout

Alternatively, introducing subtabs in the Features tab could leverage the feature subtypes introduced in 2.1.0. One tab for class features, one tab for the rest.

I think the tabs thing might sound the best- especially if you put any background features into there as well, or atleast, like the 1 background feature you get but races do sometimes give a few features as well when they dont give out spells or spell-like abilities.


Passing InputProps and InputLabelProps to SimpleFileUpload Component are not working.

               <Field
                  component={SimpleFileUpload}
                  InputLabelProps={{
                    classes: {
                      root: classes.cssLabel,
                      focused: classes.cssFocused
                    }
                  }}
                  InputProps={{
                    classes: {
                      underline: classes.cssUnderline
                    }
                  }}
                  name="logoContent"
                  label="Upload College Logo*"
                  className={classes.logo}
                  required
                />

@cliedeman I'll take a look at this and see about a fix.

PR: #78
I'm not as familiar with Typescript as I would like. If I didn't follow conventions that you would like to keep to, let me know and I can update the PR.

Released in v0.0.19


Bugs/mvn3.3.3

What changes were proposed in this pull request?
Changing the URI for Maven 3.3.3, version is no longer available on previous endpoint
How was this patch tested?
Successfully built spark using make_distribution after the patch was applied

Can one of the admins verify this patch?

cc @srowen for build update

Was considering withdrawing the PR. Here are my thoughts
Tag v1.6.2 specifies mvn 3.3.3 (unless user intentionally overrides). Users who previously built wanting to replicate their previous build have two choices:
#1, Apply this patch allowing v1.6.2 to be build as previous
#2, Apply PR #14066 bumping maven to 3.3.9 (btw this PR misses updating the pom.xml
The purist in me thinks #1 is the correct approach, but I'll defer to general wisdom
@srowen thoughts ?

This is already in branch-1.6: https://github.com/apache/spark/blob/branch-1.6/build/mvn
We can't change releases/tags of course. Yeah, this is because non-current versions eventually get moved off active mirrors. It's not great but only a problem if you don't actually have Maven installed. I'd expect most people have 3.3.x available locally anyway.
I think we don't want to download every time from dist, or that's discouraged.


Rename alignment arguments to align_to and make them default to UNIX_EPOCH

This is to make it consistent with the resampler.
Fixes #343.

(based on #335, only the last 2 commits are relevant)


Fail to scan a TV series Library

If i remove this library works good, with several libraries, but if i add the "Series TV" library give me this error, is the last library
Failed to load content!
Please check your Plex settings and try again.
The library has 3673 TV Series and 47717 Episodes
my docker compose file is
cleanarr:
image: selexin/cleanarr
container_name: cleanarr
hostname: cleanarr
ports:
- "5000:80"
environment:
- BYPASS_SSL_VERIFY=1
- PLEX_TOKEN=_Z7ioEDxcV8kkcTccmhs
- PLEX_BASE_URL=http://<IP_ADDRESS>:32400
- LIBRARY_NAMES=Conciertos;Animación TV;Anime TV;Cortos Animación;Documentales TV;Películas;Películas 4K;Películas Anime;Películas Documentales;Series 4K;Series ES;Series TV
volumes:
- /root/cleanarr:/config
restart: unless-stopped
sonarr:
image: lscr.io/linuxserver/sonarr
container_name: sonarr
environment:
- PUID=1000
- PGID=1000
- TZ=Europe/Madrid
volumes:
- /root/sonarr:/config
- /srv/mergerfs/FractalMerger/MergeLimpio:/Media #optional
Thanks for the help

Hi @lylmiksistemas
This may be due to your libraries having unicode characters in the name such as ó. Can you please try renaming the libraries to use non-unicode characters such o instead?

Hello the name is "Series TV" there is not unicode character in library, I have another library "Animación TV" with ó, and works good.

I have test with only this library and fail again.


[shared_data] deleting file in staros seems never takes effect when vacuum occurred periodically

Steps to reproduce the behavior (Required)
In be.INFO log, the same data file is vacuumed periodically. It seems that the dat file has never been deleted at all.
Expected behavior (Required)
Real behavior (Required)
I0719 20:58:58.422240 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:01:58.303380 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:04:58.597882 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:07:58.360976 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:10:58.329208 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:13:58.544032 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:16:58.317865 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:19:58.299844 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:22:58.510511 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:25:58.308576 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:28:58.350298 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:31:58.482692 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:34:58.311506 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:37:58.628608 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:40:58.632773 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:43:58.357741 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:46:58.435446 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:49:58.452464 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:52:58.721911 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:55:58.578860 101833 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 21:58:58.485316 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 22:01:58.804502 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 22:04:58.655936 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat
I0719 22:07:58.582829 101832 vacuum.cpp:55] Deleted staros://10644/data/0000000000000003_ff9a7bb6-2d81-41de-a658-77ae509b6cb2.dat

StarRocks version (Required)
runtime version build from main branch on 2023/07/19

You can get the StarRocks version by executing SQL select current_version()

Hi @wxl24life, could you please follow these steps to help troubleshoot the issue:

Run show tablet 10644 to identify which table and partition the tablet 10644 belongs to.
Run show partitions from <table>, and check the output to find the corresponding partition. Look at the visibleVersion and compactVersion values for that partition.

BTW，what object storage are you using?

BTW，what object storage are you using?

Aliyun OSS

Hi @wxl24life, could you please follow these steps to help troubleshoot the issue:

Run show tablet 10644 to identify which table and partition the tablet 10644 belongs to.
Run show partitions from <table>, and check the output to find the corresponding partition. Look at the visibleVersion and compactVersion values for that partition.

I have checked log, and found that the vacuum log has stopped at 6 am. The log started at around 18:00 yesterday. It continues for 12 hours. Not sure if there is any relation with OSS object storage policy?

Hi @wxl24life, could you please follow these steps to help troubleshoot the issue:

Run show tablet 10644 to identify which table and partition the tablet 10644 belongs to.
Run show partitions from <table>, and check the output to find the corresponding partition. Look at the visibleVersion and compactVersion values for that partition.

I have checked log, and found that the vacuum log has stopped at 6 am. The log started at around 18:00 yesterday. It continues for 12 hours. Not sure if there is any relation with OSS object storage policy?

acuum will stop for a partition if there have been no new imports or compactions within 12 hours (lake_autovacuum_stale_partition_threshold).

Hi @wxl24life, could you please follow these steps to help troubleshoot the issue:

Run show tablet 10644 to identify which table and partition the tablet 10644 belongs to.
Run show partitions from <table>, and check the output to find the corresponding partition. Look at the visibleVersion and compactVersion values for that partition.

visibleVersion and compactVersion have same value.
MySQL [(none)]> show tablet 10644
    -> ;
+-----------+---------------------------+---------------------------+---------------------------+-------+---------+-------------+---------+--------+------------------------------------------------------------+
| DbName    | TableName                 | PartitionName             | IndexName                 | DbId  | TableId | PartitionId | IndexId | IsSync | DetailCmd                                                  |
+-----------+---------------------------+---------------------------+---------------------------+-------+---------+-------------+---------+--------+------------------------------------------------------------+
| load_test | lineitem_csv_dk_replica_3 | lineitem_csv_dk_replica_3 | lineitem_csv_dk_replica_3 | 10171 | 10641   | 10640       | 10642   | true   | SHOW PROC '/dbs/10171/10641/partitions/10640/10642/10644'; |
+-----------+---------------------------+---------------------------+---------------------------+-------+---------+-------------+---------+--------+------------------------------------------------------------+
1 row in set (0.002 sec)
MySQL [(none)]> use load_test;
Database changed

MySQL [load_test]> show partitions from lineitem_csv_dk_replica_3;
+-------------+---------------------------+----------------+----------------+-------------+--------+--------------+-------+-----------------+---------+----------+-----------+-----------------+------------+-------+-------+-------+
| PartitionId | PartitionName             | CompactVersion | VisibleVersion | NextVersion | State  | PartitionKey | Range | DistributionKey | Buckets | DataSize | RowCount  | EnableDataCache | AsyncWrite | AvgCS | P50CS | MaxCS |
+-------------+---------------------------+----------------+----------------+-------------+--------+--------------+-------+-----------------+---------+----------+-----------+-----------------+------------+-------+-------+-------+
| 10640       | lineitem_csv_dk_replica_3 | 3              | 3              | 4           | NORMAL |              |       | l_orderkey      | 96      | 22.8GB   | 600037902 | true            | false      | 0.00  | 0.00  | 0.00  |
+-------------+---------------------------+----------------+----------------+-------------+--------+--------------+-------+-----------------+---------+----------+-----------+-----------------+------------+-------+-------+-------+
1 row in set (0.005 sec)

In simple terms, if the last version of a partition was produced by a compaction job, vacuum will repeatedly try to delete files that have already been removed. The aliyun OSS will return OK when deleting a non-existent file, so it appears as though the same files are being deleted repeatedly, when in fact those files no longer exist.

In simple terms, if the last version of a partition was produced by a compaction job, vacuum will repeatedly try to delete files that have already been removed. The aliyun OSS will return OK when deleting a non-existent file, so it appears as though the same files are being deleted repeatedly, when in fact those files no longer exist.

You can ignore these logs for now. Future versions will optimize this so that vacuum tasks that have already succeeded will not be repeatedly triggered.


How to set the bubble clear background but with border in Swift 3.0?

https://raw.githubusercontent.com/jessesquires/JSQMessagesViewController/develop/Screenshots/screenshot3.png
Here's my Code, But it didn't work like the sample picture
How to set the bubble clear background but with border in Swift 3.0,  like the sample picture?
let cell = super.collectionView(collectionView, cellForItemAt: indexPath) as! JSQMessagesCollectionViewCell
let msg = messages[indexPath.row]
let maskPath: UIBezierPath = UIBezierPath(roundedRect: cell.textView.bounds, byRoundingCorners: ([.bottomLeft, .bottomRight]), cornerRadii:CGSize(width: 10.0, height: 10.0))
var maskLayer = CAShapeLayer()
maskLayer.frame = cell.textView.bounds
maskLayer.path = maskPath.cgPath
cell.textView.layer.mask = maskLayer
cell.textView.layer.masksToBounds = true
if msg.senderId! == senderId {
cell.textView.layer.mask =  maskLayer
cell.textView.layer.borderColor = ButtonNoneColor.cgColor
}else{
cell.textView.layer.borderColor = ButtonClickColor.cgColor
}
cell.textView.linkTextAttributes = [NSForegroundColorAttributeName: cell.textView.textColor ?? UIColor.white]
cell.textView.layer.borderWidth = 2
cell.textView.textColor = UIColor.black
cell.textView.clipsToBounds = true
return cell

You can just simply do
let incomingBubble = JSQMessagesBubbleImageFactory(bubble: UIImage.jsq_bubbleRegularStroked(), capInsets: .zero).incomingMessagesBubbleImage(with: UIColor.blue)
....
....

    override func collectionView(_ collectionView: JSQMessagesCollectionView?, messageBubbleImageDataForItemAt indexPath: IndexPath!) -> JSQMessageBubbleImageDataSource? {
        return messages[indexPath.item].senderId == AvatarIdWoz ? outgoingBubble : incomingBubble
    }

you can also use your own image for it. check the image used in above sample from below link:
https://github.com/jessesquires/JSQMessagesViewController/blob/develop/JSQMessagesViewController/Assets/JSQMessagesAssets.bundle/Images/bubble_stroked%403x.png

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Web Admin Settings is not changed port

Hi. I found bug...
If i removed from "Web Admin Settings" in Luci two lines with port :80 and add <IP_ADDRESS>:81 (and next for ipv6) then not changes port to 81.
This bug is now, and after reboot stayed.
/etc/init.d/uhttpd restart is not efect
Web is accesilable on port 80 stayed.
How i can fix this?

This problem is caused by install offical LuCI by opkg. For details information, plase move to https://github.com/SuLingGG/OpenWrt-Rpi/issues/42

No. It is on Original build (2020-11-13, 2020-11-11 tested too)... RPi 4B where Luci is ok.
Clean image (no upgrades, no updates).

I tested on Raspberrypi 3b, the port is changed correctly.

now I'm testing for a Lean build and here the port change works correctly.
In previous cases, the only thing I did with the original image was to change the root password of the user via the "passwd root" command and set the interface for ethernet address assignment from DHCP

If you are caring about these problems, I think maybe you can try official OpenWrt...
https://downloads.openwrt.org/snapshots/targets/bcm27xx/bcm2711/
RaspberryPi 4 only have snapshots version that isn't include Luci, you should download & flash then install Luci & other modules at SSH.
My firmware is more suitable for Chinese, It includes many Cross-The-GFW packages, these package may be useless for non-Chinese users, If you use official snapshots OpenWrt, you can install packages by your needing. If you find problems, you can make issues to official OpenWrt team, maybe they have ability to solve them.
I am only a compiler that have less ability, most of bugs I can't solve them...

Ok. Thanks.
Your poackage is better 👍


PEGTL out of date

The repository link is out of date:

https://github.com/taocpp/PEGTL

Please add cpp-peglib.

Please add cpp-peglib.

Hi! @data-man Thanks for your advice. I have created a new issue for tackling this. A PR is welcome.


Fix Errors in setfit-onnx-optimum Notebook

Hey
I found a workaround to the errors when exporting using optimum-cli:
I run ONNX exporting + optimization programmatically instead of using the CLI, and there are no issues.
I also replaced the SetFit model with a faster one, which uses a SetFitHead.
cc @tomaarsen @MosheWasserb @orenpereg

@tomaarsen
I added the final plot

Apologies for the delay.


UITableView scrolls up when tap on "Read More".

I want scroll position to stay where label is tapped.
Currently tableView scrolls up, when any of the cell label is tapped from bottom.

Have a look at the demo project changes made in f75b294.


Make like colour consistent across the app

There are some instances where colors.red3 is used instead of colors.like, which results in a much-complained-about difference between the heart icon and the text next to it when a post is liked.
This PR uses s.likeColor everywhere, increasing consistency.
Fixes #2223

That's weird. I know github says the code changed but both lines look exactly the same to me


chore: release v1.1.1

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0-alpha.21 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


chore: re-generate API client

_ :robot: This pull request was generated_
Generate a new API client

This job should be re-run when https://github.com/bf2fc6cc711aee1a0c2a/srs-fleet-manager/pull/23 is merged.


electron-forge not packaging anymore

[x ] I have read the contribution documentation for this project.
[x ] I agree to follow the code of conduct that this project follows, as appropriate.
[x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
I've been using electron-forge for a few weeks now, and all of a sudden (well not I guess, but I can't recall what I changed), it seems to be unable to package anything. It can start my app without a problem, but can't package it.
It seemed to popup a the time I was playing around with squirrel and it's implementation in my system.
Any idea what I should check to get this working again ?

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.
$ env DEBUG="electron-forge:*" electron-forge package :
WARNING: DEBUG environment variable detected.    Progress indicators will be sent over electron-forge:lifecycle
Thu, 23 Mar 2017 09:21:50 GMT electron-forge:lifecycle Process Started: Preparing to Package Application for arch: x64
Thu, 23 Mar 2017 09:21:50 GMT electron-forge:project-resolver searching for project in: E:\SPARTECity
Thu, 23 Mar 2017 09:21:50 GMT electron-forge:project-resolver electron-forge compatible package.json found in E:\SPARTECity\package.json
Thu, 23 Mar 2017 09:21:50 GMT electron-forge:packager packaging with options { asar: true,
  overwrite: true,
  platform: 'win32',
  icon: 'src/assets/icons/win.ico',
  win32metadata: { CompanyName: 'SPARTE', ProductName: 'SPARTECity' },
  afterCopy: [ [Function], [Function], [Function], [Function] ],
  afterExtract: [],
  dir: 'E:\\SPARTECity',
  arch: 'x64',
  out: 'E:\\SPARTECity\\out',
  electronVersion: '1.6.2',
  quiet: true }

What does your config.forge data in package.json look like?
"forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ]
      },
      "github_repository": {
        "owner": "Dorkside",
        "name": "SPARTECity",
        "draft": true
      },
      "electronPackagerConfig": {
        "asar": true,
        "platform": "win32",
        "icon": "src/assets/icons/win.ico",
        "win32metadata": {
          "CompanyName": "SPARTE",
          "ProductName": "SPARTECity"
        }
      },
      "electronWinstallerConfig": {
        "name": "spartecity",
        "loadingGif": "src/assets/loader.gif",
        "iconUrl": "**********************",
        "setupIcon": "src/assets/icons/win.ico",
        "setupExe": "setup.exe",
        "remoteReleases": "https://*************************/update/win32/0.1.1",
        "remoteToken": "**********************"
      }
    }
  }

I have tried copying my project to a different PC and it worked without a hitch... Just wondering what I can verify on my own machine so as not to be dependent on this other station.
James

Could you please run electron-forge package again, but now the DEBUG variable should be electron-forge:*,electron-packager?

Here's the output, it just seems to hangs there forever.
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Checking your system +0ms
  electron-forge:lifecycle Process Succeeded: Checking your system +51ms
  electron-forge:runtime-config setting key: verbose to value: false +13ms
WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
  electron-forge:lifecycle Process Started: Preparing to Package Application for arch: x64 +0ms
  electron-forge:project-resolver searching for project in: E:\SPARTECity +3ms
  electron-forge:project-resolver electron-forge compatible package.json found in E:\SPARTECity\package.json +6ms
  electron-forge:packager packaging with options { asar: false,
  overwrite: true,
  platform: 'win32',
  icon: 'src/assets/icons/win.ico',
  win32metadata: { CompanyName: 'SPARTE', ProductName: 'SPARTECity' },
  afterCopy: [ [Function], [Function], [Function], [Function] ],
  afterExtract: [],
  dir: 'E:\\SPARTECity',
  arch: 'x64',
  out: 'E:\\SPARTECity\\out',
  electronVersion: '1.6.2',
  quiet: true } +10ms
  electron-packager Electron Packager 8.6.0 +16ms
  electron-packager Node v6.3.1 +1ms
  electron-packager Host Operating system: win32 (x64) +0ms
  electron-packager Packager Options: {"asar":false,"overwrite":true,"platform":"win32","icon":"src/assets/icons/win.ico","win3
2metadata":{"CompanyName":"SPARTE","ProductName":"SPARTECity"},"afterCopy":[null,null,null,null],"afterExtract":[],"dir":"E:\\S
PARTECity","arch":"x64","out":"E:\\SPARTECity\\out","electronVersion":"1.6.2","quiet":true} +1ms
  electron-packager Target Platforms: win32 +0ms
  electron-packager Target Architectures: x64 +0ms
  electron-packager Inferring application name from productName in E:\SPARTECity\package.json +6ms
  electron-packager Inferring appVersion from version in E:\SPARTECity\package.json +1ms
  electron-packager Application name: SPARTECity +0ms
  electron-packager Target Electron version: 1.6.2 +0ms
  electron-packager Ignored path regular expressions: [ '/node_modules/electron($|/)',
  '/node_modules/electron-prebuilt(-compile)?($|/)',
  '/node_modules/electron-packager($|/)',
  '/\\.git($|/)',
  '/node_modules/\\.bin($|/)',
  '\\.o(bj)?$' ] +1ms
  electron-packager Downloading Electron with options {"platform":"win32","arch":"x64","version":"1.6.2"} +829ms
  electron-packager Creating C:\Users\Dork\AppData\Local\Temp\electron-packager\win32-x64-template +299ms
  electron-packager Extracting C:\Users\Dork\.electron\electron-v1.6.2-win32-x64.zip to C:\Users\Dork\AppData\Local\Temp\electr
on-packager\win32-x64-template +2ms
  electron-packager Initializing app in C:\Users\Dork\AppData\Local\Temp\electron-packager\win32-x64\SPARTECity-win32-x64 from
C:\Users\Dork\AppData\Local\Temp\electron-packager\win32-x64-template template +2s
  electron-packager Ignored paths based on the out param: [ 'E:\\SPARTECity\\out' ] +3ms

Doesn't bring much answers I'm guessing.

This sounds like https://github.com/electron-userland/electron-packager/issues/544. Try upgrading to Node 7.

@malept I had this yesterday and remembered that electron-packager hangs on certain recursive symlinks.  Yarn creates .bin directories at all levels of the node_modules tree and therefore can create this nasty loop of symlinks.  Wiping node_modules and running npm install instead of yarn worked flawlessly.
@Dorkside If you still have this problem it might be worth trying the above 👍
@malept I'll probably add all .bin directories to a default set of packager ignores in forge itself 👍

Are the values dir, arch and platform even taken into account under electronPackagerConfig?
I am tying to package my app with this configuration:
"config": {     "forge": {       "make_targets": {         "linux": [           "deb"         ],         "win32": [           "squirrel"         ]       },       "electronPackagerConfig": {         "asar": false,         "dir": "./src",         "platform": [           "linux",           "win32"         ],         "arch": [           "ia32",           "x64"         ],         "ignore": [           ".idea"         ]       }     }   }
While asar and ignore are working fine, arch and platform only seem to take one string value and dir is completely ignored when I write it like this. After digging into package.js it is my impression that dir seems to always be the cwd.
Am I missing something here? Any hints or a link to any example would be highly appreciated.
I also created a question on StackOverflow (https://stackoverflow.com/questions/44147470/electron-forge-packaging-configuration-not-working) for this, if someone wants to answer there.

Those values are overridden by Forge, because they're all specified on the command line. Check out the output of electron-forge package --help.

Since the original issue reporter has not responded to the request for additional information in a while, I'm going to assume that they either found the answer in another manner or decided not to pursue this issue. If I'm incorrect, they can respond with answers to the questions posed, and I'll reopen.

Did a clean install of my PC for other reasons, so I don't really know if the issue got solved. Working now though.


Discussion: SASS 2.0 & Breaking changes (removing settings)

So SASS 2.0 will be coming (2024 @ the earliest) and, with that, there will be a lot of breaking changes.
My main concern is that the current JS API has now been marked as deprecated in favour of a newer one - so will be removed in 2.0. By upgrading to the new defacto it will remove the following settings: (which I have avoided for now)

liveSassCompile.settings.formats[].linefeed
liveSassCompile.settings.formats[].indentType
liveSassCompile.settings.formats[].indentWidth

These are not in the new API and, apparently, will never be added (see sass/dart-sass#1585)
I'd like to move to the new API sooner rather than later as it has some benefits (mainly speed related). However, I don't just want to remove it without at least opening it up to the community.
Another option - according to sass/dart-sass#1585 -  is to create a postcss plugin to do this instead. I don't really have the time to work on this and can't really spend all those hours/days working on a feature that might not have a big userbase

I obviously can't speak for everyone, but I never use those settings, as I don't do any further work in the compiled CSS file. And I think if people are using a VS Code extension to compile their Sass files, they could use Prettier to handle formatting.

Thanks for the input! It seems that the community are agreeing with you so I will mark these settings as deprecated in the next release.
This will give users plenty of time to review alternative solutions (ready for whenever SASS 2.0 is released).
I will continue to keep this open until until it's relase (probably move it over to an actual discussion though)


PSIRT vulnerability for glob-parent CVE-2021-35065 - v0.x

What package(s) are you using?

[x] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.

PSIRT vulnerability issue CVE-2021-35065 for<EMAIL_ADDRESS>found in @carbon/ibm-cloud-cognitive @0.x

What did you expect to happen? What happened instead? What would you like to
see changed?

Updating the dependency @carbon/telemetry to @^0.1.0

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?

0.65.0, we tried updating to 0.99.1
Additional information

https://exchange.xforce.ibmcloud.com/vulnerabilities/208298

Hey @joshualiu, this appears to be already fixed in newer versions (specifically @carbon/telemetry was upgraded to 0.1.0 in @carbon/ibm-products@1.12.0).
Let us know if there is more we can do to help!


[10.x] Get tables and views info

This PR adds Schema::getTables() and Schema::getViews() to fetch options and info of tables and views on the connection. We currently use doctrine/dbal on the framework to retrieve this info and also we have Schema::getAllTables() and Schema::getAllViews that this PR deprecates.
Usage
Just like Schema::getColumns() added on #48357, the new Schema::getTables() and Schema::getViews() methods are necessary to inspect the database (db:show, db:table, and model:show artisan commands). These functions provide even more info than doctrine/dbal (e.g. table size):
Schema::getTables()

name: Name of the table
schema: Schema name (MySQL, PostgreSQL, and SQL Server)
size: Total disk space used for the table in bytes, including indexes (On SQLite, would be null if dbstat table is not available)
comment: Table comment (MySQL and PostgreSQL only)
collation: Table collation, e.g utf8mb4_unicode_ci (MySQL only)
engine: Table engine, e.g. InnoDB (MySQL only)

Schema::getViews()

name: Name of the view
schema: Schema name (MySQL, PostgreSQL, and SQL Server)
definition: View definition query

Changes

Feature
Before
After

Schema::getTables()
N/A
Added. Uses Processor::processTables() and Grammar::compileTables()

Schema::getViews()
N/A
Added. Uses Processor::processViews() and Grammar::compileViews()

Schema::getAllTables()
Uses Grammar::compileGetAllTables()
Deprecated. You may use Schema::getTables() instead

Schema::getAllViews()
Uses Grammar::compileGetAllViews()
Deprecated. You may use Schema::getViews() instead

Schema::hasTable()
Uses Grammar::compileTableExists()
Uses newly added Schema::getTables() except on PostgreSQL that left unchanged1

Schema::dropAllTables()
Uses Grammar::getAllTables() on MySQL and PostgreSQL grammars
Uses newly added Schema::getTables() on MySQL and PostgreSQL grammars

Schema::dropAllViews()
Uses Grammar::getAllViews() on MySQL and PostgreSQL grammars
Uses newly added Schema::getViews() on MySQL and PostgreSQL grammars

Schema::hasTable() left unchanged on PostgreSQL to avoid a breaking change on a case that user is calling this function with a 3-parts search path Schema::hasTable('database.schema.table'), although this usage is non-standard IMO and should be Schema::connection('database')->hasTable('schema.table'). I'll cover this on another PR to master branch.

Deprecations

\Illuminate\Database\Schema\Builder::getAllTables()
\Illuminate\Database\Schema\MySqlBuilder::getAllTables()
\Illuminate\Database\Schema\MySqlBuilder::getAllViews()
\Illuminate\Database\Schema\PostgresBuilder::getAllTables()
\Illuminate\Database\Schema\PostgresBuilder::getAllViews()
\Illuminate\Database\Schema\SQLiteBuilder::getAllTables()
\Illuminate\Database\Schema\SQLiteBuilder::getAllViews()
\Illuminate\Database\Schema\SqlServerBuilder::getAllTables()
\Illuminate\Database\Schema\SqlServerBuilder::getAllViews()
\Illuminate\Database\Schema\Grammars\MySqlGrammar::compileTableExists()
\Illuminate\Database\Schema\Grammars\MySqlGrammar::compileGetAllTables()
\Illuminate\Database\Schema\Grammars\MySqlGrammar::compileGetAllViews()
\Illuminate\Database\Schema\Grammars\PostgresGrammar::compileTableExists()
\Illuminate\Database\Schema\Grammars\PostgresGrammar::compileGetAllTables()
\Illuminate\Database\Schema\Grammars\PostgresGrammar::compileGetAllViews()
\Illuminate\Database\Schema\Grammars\SQLiteGrammar::compileTableExists()
\Illuminate\Database\Schema\Grammars\SQLiteGrammar::compileGetAllTables()
\Illuminate\Database\Schema\Grammars\SQLiteGrammar::compileGetAllViews()
\Illuminate\Database\Schema\Grammars\SqlServerGrammar::compileTableExists()
\Illuminate\Database\Schema\Grammars\SqlServerGrammar::compileGetAllTables()
\Illuminate\Database\Schema\Grammars\SqlServerGrammar::compileGetAllViews()

I think this feature should have some integration tests, to engage real databases in the test.
@hafezdivandari

@imanghafoori1 done, thank you for your feedback. Added few tests for new methods, we already had many integration tests that engage changed functions, i.e. Schema::hasTable(), Schema::dropAllTables(), and Schema::dropAllViews().

@hafezdivandari so do any of the Artisan commands that currently prompt for doctrine/dbal need to be updated?

@taylorotwell no this PR doesn't change anything on these commands, we are just adding what we need as series of PRs to 10.x to be able to remove doctrine/dbal on 11.x (PR #48864)

@hafezdivandari Looks like this cause a breaking change in #49227

@crynobone Thanks for mentioning, I'll send a PR.

This caused a breaking change; when doing this in SQLServer:
$hasTable = $schemaBuilder->hasTable('"schema"."table_name"');

This used to return TRUE if that table name in that schema existed. Now it returns FALSE.
It seems like the new code checks just table_name against the passed "schema"."table_name" string, not taking the schema into account at all.


python sample code cannot pass

I have installed both base and python packages successfully. However, when I try to run the sample code in python/README.md, it throws error as below:
Traceback (most recent call last):
  File "ngt_sample.py", line 11, in <module>
    index = ngt.Index.create("tmp", dim)
  File "/root/workspace/NGT-1.3.1/python/ngt/base.py", line 250, in create
    index = Index.__ngt.ngt_create_graph_and_tree(path, prop, err)
ctypes.ArgumentError: argument 1: <class 'TypeError'>: wrong type

Since this sample code does not work, I cannot find out how to use NGT to create an index...

Solved. Path argument should be b"tmp" instead of "tmp".

How did you resolve this issue ?
I am getting this same error. Please help urgently

How did you resolve this issue ?
I am getting this same error. Please help urgently

index = ngt.Index.create("tmp", dim)

This should be
index = ngt.Index.create(b"tmp", dim)

According to my memory, this fixed the error in my case.


Fix alert bugs

Related Issues: https://github.com/rancher/rancher/issues/12572, https://github.com/rancher/rancher/issues/12571
Dependent types PR: https://github.com/rancher/types/pull/355

LGTM

LGTM


Can't infer correct NuxtApp property type after registering @nuxtjs/color-mode

Originally posted in https://github.com/nuxt/nuxt.js/issues/13787

Environment

Operating System: Windows_NT
Node Version:     v16.14.2
Nuxt Version:     3.0.0-rc.1
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-yq4qz8
Describe the bug
When using a property provided by a custom plugin, it can't infer correct NuxtApp property type that always shows any after registering @nuxtjs/color-mode.
But it works when the property used in template alone.
Please try the demo in VS Code.
Additional context
No response
Logs
No response

https://github.com/P4sca1/nuxt-plugin-provide-types

@danielroe I found out that removing the following lines resolves the issue.
https://github.com/nuxt-modules/color-mode/blob/f5253feb5a547a61ee38edca243947cf1b20c58c/src/runtime/types.ts#L28-L30
Changing them to the following also works (and might be needed for Bridge typings?):
declare module '#app' {
    interface NuxtApp extends PluginInjection {
        $colorMode: ColorModeInstance;
    }
}

Maybe adding $colorMode to the PluginInjection interface was just forgotten?
Could you elaborate which interfaces are used by Nuxt Bridge / Nuxt 3 for TypeScript typings?
According to the docs, the following declaration would be sufficient for Nuxt 3:
export interface ColorModeInstance {
    preference: string;
    value: string;
    unknown: boolean;
    forced: boolean;
}

declare module '#app' {
  interface NuxtApp {
    $colorMode: ColorModeInstance
  }
}

declare module '@vue/runtime-core' {
  interface ComponentCustomProperties {
    $colorMode: ColorModeInstance
  }
}

export { }

I don't really know what all the other definitions are for in the types.d.ts file.

@danielroe @pi0 Could you have a look at this? This issue really kills the DX in Nuxt 3.

This seems to be working fine for me using your reproduction + latest color mode + rc113.

  "devDependencies": {
    "@nuxtjs/color-mode": "latest",
    "nuxt": "3.0.0-rc.13"
  }

Are you still experiencing this?

@danielroe I upgraded the dependencies in https://github.com/P4sca1/nuxt-plugin-provide-types and still experience the issue.
However I noticed the following: When you just loaded VSCode, or restarted the Vue server (Volar: Restart Vue Server), the correct typing for $test will be there for a few seconds. After a few seconds, when you reopen the file app.vue, the typings will be gone and $test will be typed any.

https://user-images.githubusercontent.com/10992664/201470194-823b4a80-20ee-44eb-8728-f4ed7b17da9e.mov

This is no longer reproducible.


Python 3.5 deprication notice

# manuale/crypto.py:80: CryptographyDeprecationWarning: signer and verifier have been deprecated.
# Please use sign and verify instead.
  signer = key.signer(padding.PKCS1v15(), hashes.SHA256())

@veeti Is it simply changing the name of functions?

@veeti What is I send a PR with function name change only? Could you release it?

Sure, but as ACMEv1 is being deprecated you are better off moving to a maintained client.

Thank you.

So this client is depreciated also?

Started to work on automatoes as this client is not supported anymore.


[SPARK-28624][SQL][TESTS][3.0] Run date.sql via Thrift Server

What changes were proposed in this pull request?
Enable date.sql and run it via Thrift Server in ThriftServerQueryTestSuite.
Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the enabled tests via:
$ build/sbt -Phive-thriftserver "hive-thriftserver/test-only *ThriftServerQueryTestSuite -- -z date.sql"

@HyukjinKwon Please, review this PR.

Test build #123519 has started for PR 28723 at commit 81f63e0.

Looks good if the tests pass. WDYT can you point out which change fixed this if you already know?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28142/
Test PASSed.

@HyukjinKwon I guess this PR fixes the issue mainly:
https://github.com/apache/spark/pull/28582

Test build #123519 has finished for PR 28723 at commit 81f63e0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123519/
Test PASSed.

Let's cut out RC3 first and then merge.

I discussed with @MaxGekk @cloud-fan. The tests will have to be disabled back at SPARK-30808. Basically, resulting to 0045-03-15 itself is actually controversial.
We strictly can just merge and enable it for Spark 3.0 specifically because SPARK-30808 won't land to branch-3.0 but let me just don't merge this for simplicity.


In-game server selection?

Hello! Looking forward to the unified server guide.
I was wondering if there will eventually be an in-game way to input ApiUrl? For quest users, especially those using one-click solutions like ModsBeforeFriday, we don't get a chance to modify the mod before it is installed.
Thanks for the hard work on BeatTogether!

Hello,
We do not plan on providing a in game based editor to add servers at this time.
If you'd like to add servers as default, I'd suggest recompiling the PC or Quest mod with your custom server.


Location to restore notes from backup

Bug Report
Please fill out this information:
Browser version: 94.0.2
Extension version: 1.2.7
Operating system: Windows 10

Firefox updated to latest version and a year of notes disappeared. Could you please be so kind as to let me know where/how you store notes so I can restore them from a backup and, hopefully, open them with a text editor? I tried downgrading Firefox but v93 creates a new blank profile and refuses to let me access the v94 profile. Sorry, I understand I can't expect support from free software.

What are the steps to reproduce the bug?

Open the browser console (Hamburger menu > Web Developer > Browser Console) and include anything that is logged when the bug occurs.
This step is not always necessary.

Any screenshots or videos of the bug would be helpful.

Fixed. Seems "I don't care about cookies" extension blocks Note Taker from working.


ACS URL undefined when using IdP other than the Onelogin example

Every IdP I test always return a "No return endpoint available for relying party express-saml2" error. Though I made sure the the AssertionConsumerService tag has an attribute of "Location" pointing to "http://localhost:3000/sso/acs".

@fredpedro Do you need to load any SP metadata into your IdP ? Also make sure it supports localhost access and not https. In fact, it would be good to provide more information and even make a sample repo, so I can help more.

Hi @tngan , here is the sample repository based from the application that I am working on. https://github.com/fredpedro/potential-robot. This is an Angular 2 application, but I removed the Angular 2 codes from the "client" folder. Yes, I need to load the SP metadata to our Gluu Server. I also tested the package against testshib.org's IdP but it raised the same error. If our Gluu Server is https enabled, does that mean I have to enable https on our Node.js app as well?

I solved it by placing two AssertionConsumerService attributes, the HTTP-POST and HTTP-Redirect.

Thanks @fredpedro , let me close this issue then.


What changes are required for 4.3?

Hello! I have updated to Godot 4.3, and the plugin stopped logging-in on app launch.
I am getting "Plugin found" printed from godot_play_game_services.gd so that's not the issue.
I tried pasting this code from the demo project
func _ready() -> void:
	SignInClient.user_authenticated.connect(func(is_authenticated: bool):
		if not is_authenticated:
			SignInClient.sign_in()
	)

to try to force it to sign in, and I did get the sign-in prompt, but even when I pressed "continue" it would keep prompting me again and again. and also never signing me in successfully (when I closed and opened the app again things I save weren't saved, this used to work when I was in Godot 4.2)
help updating to Godot 4.3 would be much appreciated!

Hi @TheSkyOne thanks a lot for letting me know! I haven't tried the plugin yet in godot 4.3, my bad! I'm out for the weekend but as soon as I get back to my computer I'll check the issue! Thanks for your patience!

Hi @TheSkyOne I've updated the plugin for Godot 4.3 and launched a new release. Can you try it out now and see if this fixes your issue? It definitely worked for me, but you know, it's better to check!

Thank you for updating so quickly!
I was just about to make an update, for some odd reason when I released a new update to my app and downloaded it on my device, and the signing-in and saving worked. but when launching with remote debug to my device from the godot editor it doesnt work, but it used to. I am not sure if I should update or not.
does it sign in to your account for you when you launch with remote debug from the editor?

Yes, I tested it launching from the godot editor with WiFi debugging and it worked fine. You can give a try and update the plugin to see if it works

OK, I will update you

I don't think your changes overlap mine, so you can move your changes to a separate place temporarily, download the new version of the plugin and then copy and overwrite your changes on top, that should be safe and you won't lost your changes

I still cant get it to show the sign-in at the top on remote debugging

also note about something small, I noticed the version in the config file hasnt changed

also note about something small, I noticed the version in the config file hasnt changed

You mean the plugin version from 1.7.0 to 1.8.0? I forgot about that, thanks for pointing out! But that doesn't affect anything.
I have an idea, but I'm not sure that would help, can you try deleting the android/build folder of your Godot project and reinstalling the android template from the godot editor?

yeah ik the version doesnt affect it, just wanted to keep it up to date 😄
I will try reinstalling the build template

no change

I'm sorry to hear that but I'm afraid I can't help much more without looking at the code. I imagine you've followed the implementation guide, right? https://github.com/Iakobs/godot-play-game-services/blob/main/plugin/demo/README.adoc

I will try to do a full restart and follow all the steps again, will update tomorrow if it worked

Hi @TheSkyOne did you manage to solve your issue?

Hey! my computer has been having some issues the past few days so I havent been able to test yet. Hopefully I will be able to soon, and I will update here whether or not I have managed to solve it.
thank you for following up! :)

Hi @TheSkyOne how is it going? Let me know if you need something else 😊

Hi @Iakobs unfortunately it is going to be a little while before i can test. i really appreciate you taking the time you follow up, and i will write here once i get on it, it might just be a while before i can.
thanks again 🙂

Sure no problem! :)

@Iakobs so i finally was able to get back to this, i deleted everything related to the plugin and started from scratch.
i am now at the same place i was when i open this issue, that is, im getting the sign-in popup as seen here

but regardless of pressing "continue" or "cancel" the popup closes and immediately reopens, creating a loop where i cant do anything.
this is the sign-in code (straight from the demo)
SignInClient.user_authenticated.connect(
	func(is_authenticated: bool):
	if not is_authenticated:
		SignInClient.sign_in()
	)

this is running on my first scene that gets loaded on game start (splash screen).
interestingly, i noticed that if i put this same code in my main menu scene, which comes a little bit after, i dont get this sign-in popup at all. which i am guessing means is_authenticated is coming as true. meaning something else is attempting and successfully authenticates. does the plugin try to automatically authenticate when its loaded? if so, could that be causing some issue where the code above (which as i said gets run in the first scene in the game) is racing against the plugin and that somehow causes the weird cycle? im really just taking shots in the dark here tbh...

Hi! Yes, as mentioned here, the plugin attempts to login when loaded. The Google workflow for logging in is a bit strange, so it makes sense that the code you posted from my example might enter in a loop. In the demo project there's a retry mechanism with a finite number of retries if you want to implement something similar.
I understand that the plugin is working, it's just a matter of implementing the workflow, right? Let me know if I can help you with something else.

i guess the issue is, why is there even a retry when i press "continue" or "cancel" on the prompt. like i would expect it to just either load the user or not load it depending on my choice, not prompt me again if that makes sense. is there a way to prevent it from doing that?
also could you please direct me to where exactly in the demo it checks for a maximum number of attempts?

I see, yes, that behaviour is very weird. That sign in window is provided by Google and it's not configurable. I don't see any option in their documentation to modify its behaviour.
The part in the demo where I do the retry mechanism is in this gdscript file.

so this feels like a bandaid fix, but it does work to stop it from repeating trying to sign in
var sign_in_attempts = 1 and
func _sign_in() -> void:
	SignInClient.user_authenticated.connect(
		func(is_authenticated: bool):
		if sign_in_attempts > 0 and not is_authenticated:
			SignInClient.sign_in()
			sign_in_attempts -= 1
	)

which i call in ready.
currently, i am struggling with getting things to save. i am trying to run your demo project but when i remote debug it it fails to export with this error
* What went wrong:
  Execution failed for task ':processDebugResources'.
  > A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
     > Android resource linking failed
       ERROR: C:\Users\Omer\Downloads\Iakobs godot-play-game-services main plugin-demo\android\build\src\debug\AndroidManifest.xml:23:1-113: AAPT: error: resource string/game_services_project_id (aka com.example.googleplaygameservicesgodotplugin:string/game_services_project_id) not found.

which makes sense because i dont have the game services project id for this, but then im not sure how im supposed to test things. unless the demo project is just meant as a code example and not meant to be ran.
in any case, i dont think there is an actual issue with the plug-in, its just me probably misunderstanding and using it wrong (even tho i had it working at some point earlier). so i guess this issue can be closed?

so this feels like a bandaid fix, but it does work to stop it from repeating trying to sign in
var sign_in_attempts = 1 and
func _sign_in() -> void:
	SignInClient.user_authenticated.connect(
		func(is_authenticated: bool):
		if sign_in_attempts > 0 and not is_authenticated:
			SignInClient.sign_in()
			sign_in_attempts -= 1
	)

which i call in ready.
currently, i am struggling with getting things to save. i am trying to run your demo project but when i remote debug it it fails to export with this error
* What went wrong:
  Execution failed for task ':processDebugResources'.
  > A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
     > Android resource linking failed
       ERROR: C:\Users\USER\Downloads\Iakobs godot-play-game-services main plugin-demo\android\build\src\debug\AndroidManifest.xml:23:1-113: AAPT: error: resource string/game_services_project_id (aka com.example.googleplaygameservicesgodotplugin:string/game_services_project_id) not found.

which makes sense because i dont have the game services project id for this, but then im not sure how im supposed to test things. unless the demo project is just meant as a code example and not meant to be ran.
in any case, i dont think there is an actual issue with the plug-in, its just me probably misunderstanding and using it wrong (even tho i had it working at some point earlier). so i guess this issue can be closed?

Hi, sorry for the delay!
The demo project does work, but you have to provide a project Id to it via the new tab in the dock. I haven't tested with other ids beside mine, but in theory it should work with any id.
You can close the issue if you want. I can try to help you with the saving games part too, what's the issue you're facing?

after more debugging, i seem to be having issues signing-in at all, rather than saving issues.
currently i have this code in my main menu scene
SignInClient.user_authenticated.connect(
	func(is_authenticated: bool):
		print("user authenticated: " + str(is_authenticated))
	       )
SignInClient.sign_in()
await SignInClient.user_authenticated
SignInClient.is_authenticated()

which results in this output
user authenticated: false
user authenticated: false

when i press the "continue" button on the prompt i shared a few messages above (by the way, i keep getting that prompt, instead of just seeing the game automatically connect with a popup from the top like it usually does in games, and im not sure why that is)
also, i tried putting my game's play games ID in your demo and it does work, but it behaves the same as my own game, it keeps prompting me to sign in, until i eventually get attempts expired.
another thing i dont understand, is how your code in the main menu initiates the sign-in process.
SignInClient.user_authenticated.connect(func(is_authenticated: bool):
	if _sign_in_retries > 0 and not is_authenticated:
		title_label.text = "Trying to sign in!"
		SignInClient.sign_in()
		_sign_in_retries -= 1

this only connects the user_authenticated signal to the lambda function, according to your docs this signal is emitted by is_authenticated() and sign_in(). for the former i couldnt find any call within the project, and the latter is only called within the same lambda function...
i am asking this because i have pretty much the same code, which you can see in my comment above, but mine doesnt get initiated unless i call the functions from the SignInClient manually...
your help is much appreciated! 🙏

Oh I see. That's maybe not clear in the docs and I'll try to explain it better. I never call the is_authenticated method in the demo app, because it's called internally when the plugin is loaded, that's why I only connect to the signal and, in case the user is not authenticated, I attempt the other method.
Maybe you can try without sign in code at all, and see if the automatic attempt works by its own?
About the prompt, that's weird. I never had it while testing, I either couldn't sign in or I was automatically signed in. Maybe also important to note that I'm logged in the Google Play Games app before opening the demo app.

Wow, that's indeed very confusing of an issue. What do the logs say? Maybe it's a problem with the credentials in the Google cloud? It sounds like maybe there's a cache for it and that's why your build works some time after running the one in the console.

what logs are you referring to particularly?

that was a good shout by you!
it seems like my game's SHA-1 certificate changed somehow? in the logs in is showing a sequence i recognize, but going to the google console, both "App signing key certificate" and "Upload key certificate" are different than that key... im not sure what would cause the key to change tho, and would like to avoid this happening again...

Nice! This happened to me too,  that's why I put this section in the README.

yeah, i went through it just after discovering the issue in the logs. so do i need to delete the existing credentials and recreate them with the new sha-1 certificate?

I don't think you have to delete them, iirc you can just edit them. But if you feel safer deleting them, that's OK too!

Yes, that needs to be changed in the Oauth client in the Google Cloud. The basic steps are described here, and the changes are made here:

Just click in any of the credentials that are already created and there you can edit the package name and the SHA1. Basically you need an oauth client for every keystore you are using. Say if your team has 3 memeber who develop in their machines, that will be AT LEAST 3 different oauth clients with the SHA1 that every dev must provide running this command over their keystore: keytool -keystore path-to-debug-or-production-keystore -list -v. I usually have 2 different keystores in my own machine, one for debug mode of the game and the other for release mode of the game.
Then you need another oauth with the SHA1 of the play store for the game to run when downloaded from the store. That SHA1 is controlled by Google, but available in the Play Console.
Hope it makes sense!

updating, after updating the wrong sha-1 cert (still no idea what made it change) to the correct one i can now sign in as usual!
hopefully saving will be easy to do now as i have already done it before. thanks a lot for all your help and the maintenance of this plugin 🙇

no worries at all! I'll close the issue for now, but feel free to open a new one if you need help with snapshots!


[DOCS] correct ArgillaTrainer section older dataset

Which page or section is this issue related to?
https://docs.argilla.io/en/latest/practical_guides/fine_tune.html#id18 this does not show the ArgillaTrainer for older datasets. But it should look like https://docs.argilla.io/en/v1.13.0/guides/train_a_model.html

Regarding this, I can work on that, as I already have an issue and branch created to modify this file

PR completed #4053


Fix jshint dependency

jshint shouldn't be a peer dependency.

Hi Thom, thanks for the pr. Could you target the develop branch instead?

Am going to change it in dev, thanks for the hint Thom, closing this pr because of inactivity.

Thanks. Sorry I completely forgot about this :)


Missing class com.google.android.play.core.tasks.OnFailureListener (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
Flutter version 3.7.12
Android gradle plugin 8.1
PlayStoreDeferredComponentManager uses com.google.android.play.core.tasks.OnFailureListener which does not exist anymore (Error thrown by R8 in release mode)
On building the application in release mode following error is thrown after upgrading to gradle 8.1:
Missing class com.google.android.play.core.tasks.OnFailureListener (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))
Missing class com.google.android.play.core.tasks.OnSuccessListener (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String))
Missing class com.google.android.play.core.tasks.Task (referenced from: void io.flutter.embedding.engine.deferredcomponents.PlayStoreDeferredComponentManager.installDeferredComponent(int, java.lang.String) and 1 other context)

Expected results
The Tasks class is no more under play.core and is moved to gms, flutter engine should be using it correctly and the error should not have occured.
Actual results
The task class, onFailureListener and onSuccessListener are being shown as used from play.core library which does not exist.
Code sample
Here is my proguard-rules.pro file:
#Flutter Wrapper
-keep class io.flutter.app.** { *; }
-keep class io.flutter.plugin.**  { *; }
-keep class io.flutter.util.**  { *; }
-keep class io.flutter.view.**  { *; }
-keep class io.flutter.**  { *; }
-keep class io.flutter.plugins.**  { *; }

-keep class org.xmlpull.v1.** { *;}
 -dontwarn org.xmlpull.v1.**

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.7.12, on macOS 13.1 22C65 darwin-arm64, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.84.0)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

I've already checked that post @darshankawar.
I am just not sure if commenting out keep rules for Flutter wrapper is a good idea.
That's why i deep dived into the error and I was able to solve few of them by adding the below 2 dependecies:
implementation 'com.google.android.play:feature-delivery:2.1.0'
implementation 'com.facebook.infer.annotation:infer-annotation:0.18.0'

The ones which I've mentioned are the only ones which are left, and i think those errors shouldn't have existed in the first place since Tasks class is now removed from play core and added to gms.

Maybe the fact that you are on older version of stable + using latest gradle version could be causing the conflict and the error you are reporting. Is there a way for you to upgrade your config to latest and run your scenario again to check if you still get the same behavior or not ?

Which flutter version would you recommend? The latest stable one?

Have reverted this change for now and gone back to Gradle 7.0.2, the upgrade to 8.1 is not required for me anymore.
Didn't try updating flutter because it was not needed anymore, but could be a possible fix.
Will seek further help later, if required.
Closing this from my end for now.


Error building MacVim on Mojave with Xcode 9.3

I am attempting to build MacVim from git clone on macOS 10.14 Mojave with Xcode 9.3. I am configuring MacVim as follows:
./configure --with-features=huge --enable-rubyinterp --enable-pythoninterp --enable-python3interp --enable-perlinterp --enable-cscope  --enable-terminal

and get an error:
if_perl.xs:57:10: fatal error: 'EXTERN.h' file not found
#include <EXTERN.h>
         ^~~~~~~~~~
1 error generated.
make: *** [objects/if_perl.o] Error 1
make: *** Waiting for unfinished jobs....

However, open -h EXTERN.h does find EXTERN.h in /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/simd
Building with Xcode 10 works, but the binary produced has known issues with Core Text renderer.

I thought Mojave requires at least Xcode 10.

I thought Mojave requires at least Xcode 10.

Apparently, at least Xcode 9.4.1 or higher. So my Xcode 9.3 is not supported.


Possible issue with compareLists method in FilterUtils.java?

I found this issue while writing unit tests for the AndFilter and OrFilter classes.
I  created an AndFilter object named "andFilter" with a couple of other filter objects as statements.
When comparing andFilter with itself ( andFilter.compareTo(andFilter) ), I was asserting a zero value but got a 1 instead.
On debugging I realized it is because of the compareLists method where we are not completely iterating over the list of filter statements.  I guess We need to use a while loop instead of the if loop in line 49. of FilterUtils.java
If this is a valid issue, I can submit a PR with some simple test cases.
Also, If the left is greater than the right in a compare method, shouldn't we return a positive value? I think FilterUtils has it implemented the other way round.

Guessing you mean this line?.
Looks like a bug. Good find!

Yes! I would like to fix that.
I also had this question about the return value
"Also, If the left is greater than the right in a compare method, shouldn't we return a positive value? I think FilterUtils has it implemented the other way round. " - Am I correct in this assumption ?
If so, I will make that change as well.