Hard-coded excluded_dirs

function.py hard-codes 8 directories that will always be excluded.  But this breaks deployment of any projects that happen to use those packages.  I discovered this when the "jmespath" dependency in my project mysteriously refused to be included in the deployed package.  Some code-spelunking revealed the hard-coded list in function.py.
Any chance of just removing that list entirely?  As far as I can tell kappa is not caching any of those dependencies in my src folder anyway, so I don't think it should need to exclude them.

there builtins on the py lambda execution environment which has the boto3 sdk installed.

+1
Would prefer them to be configurable. We might want to use a specific version of boto or other libraries such that code do not break when AWS change their execution environment.

I will push a PR for them to be configurable.


Update kyaml and related deps

Alternative to #2181 with no replace directive. Everything builds fine and make build tidy does not modify anything, however the test do not go through and I won't have time to look at that in a while.

Thank you for the PR! Will add a couple of things from here to mine.


CryptoCrew Validators uni-2 gentx

let the phoenix rise

oh, past gentx submission time 😅 ok gonna join after the launch then


ruleSet is null

Junit test code is:
File inputFile = new File("c:/data1.txt");
double minSupport = 0.1;
double minConfidence = 0.2;
Apriori<NamedItem> apriori = new Apriori.Builder<NamedItem>(minSupport)
    .generateRules(minConfidence).create();
Iterator<Transaction<NamedItem>> iterator = new DataIterator(inputFile);
Output<NamedItem> output = apriori.execute(iterator);
RuleSet<NamedItem> ruleSet = output.getRuleSet();

if (ruleSet != null) {
    Iterator<AssociationRule<NamedItem>> iteratorItemSet = ruleSet.iterator();

    while (iteratorItemSet.hasNext()) {
        AssociationRule<NamedItem> itemSet = iteratorItemSet.next();
        System.out.println("result ............." + itemSet.toString());
    }
} else {
    System.out.println("ruleSet is null");
}

data1.txt content is:
bread   butter  sugar
coffee  milk    sugar
bread   coffee  milk    sugar
coffee  milk

run result is :
ruleSet is null

the support  of "coffee  milk "  is 3/4=0.75, the confidence is 3/3=1，accord with  minSupport = 0.1 and minConfidence = 0.2,ruleSet should has "coffee -> milk" at least.

Fixed in version 1.1.1.


FormAtomValues hints wrong type to the developer

Describe the bug
The return type of FormAtomValues should contain only primitive language types, while it still mentions FieldAtom generics.
The type itself is correct, but the developer experience could be better.
Case 1: array of field atoms FieldAtom<T>[]
const imageFields = {
  images: [
    fieldAtom({
      value: { id: "1", url: "https://" },
    }),
    fieldAtom({
      value: { id: "2", url: "https://" },
    }),
  ],
};

// when hovered/inspected
type ImageValuesACTUAL = FormAtomValues<typeof imageFields>;

// ISSUE1: the [x: number] is ugly way to say there is array of items
// ISSUE2: FieldAtom is obfuscating the actual type
// ISSUE3: there is recursive call to FormAtomValues
type ImageValuesACTUAL = {
  images: FormAtomValues<{
    [x: number]: FieldAtom<{
      id: string;
      url: string;
    }>;
  }>;
};

// FIX1: the array has intuitive syntax []
// FIX2: we have plain values, not boxes of FieldAtom
// FIX3: no recursive call
type ImageValuesEXPECTED = {
  images: {
    id: string;
    url: string;
  }[];
};

// Fix of https://github.com/jaredLunde/form-atoms/blob/main/src/index.tsx#L1208
type _FormAtomValues<Fields extends FormAtomFields> = {
  [Key in keyof Fields]: Fields[Key] extends FieldAtom<infer Value>
    ? Value
    : Fields[Key] extends FormAtomFields
    ? _FormAtomValues<Fields[Key]>
    : Fields[Key] extends FieldAtom<infer Value>[] // FIX2: here go deeper into array of FieldAtom; no need to recurr
    ? Value[]
    : Fields[Key] extends FormAtomFields[] // FIX1: fixes the [x: number] for Case 2 below
    ? _FormAtomValues<FormAtomFields>
    : never;
};

Case 2: array of 'fields'  {[string]: FieldAtom<any>}[]
const addressesFields = {
  addresses: [
    {
      city: fieldAtom({ value: "Stockholm" }),
      street: fieldAtom({ value: "Carl Gustav Street" }),
    },
    {
      city: fieldAtom({ value: "Bratislava" }),
      street: fieldAtom({ value: "Kosicka" }),
    },
  ],
};

type AddressValuesACTUAL = FormAtomValues<typeof addressesFields>;

// when hovered
type AddressValuesACTUAL = {
    addresses: FormAtomValues<{
        [x: number]: {
            city: FieldAtom<string>;
            street: FieldAtom<string>;
        };
    }>;
}

type AddressValuesEXPECTED = {
    addresses: {
        city: string;
        street: string;
    }[];
}

// Now the fix is a bit trickier - the arrays does not contain leaf nodes, they have objects, so we must recurr,
// but recurr would keep the `FormAtomValues` call indication in the result, and obfuscate it
// SO WE CAN recurr by duplicating the code.
// This does not cover all cases, e.g. deeply nested form definitions would be still 'bad', but certain level, e.g. depth 2
// could be supported to cover most user needs:
type _FormAtomValues<Fields extends FormAtomFields> = {
  [Key in keyof Fields]: Fields[Key] extends FieldAtom<infer Value>
    ? Value
    : Fields[Key] extends FormAtomFields
    ? _FormAtomValues<Fields[Key]>
    : Fields[Key] extends FieldAtom<infer Value>[]
    ? Value[]
    : Fields[Key] extends (infer NestedFields)[]
    ? NestedFields extends FormAtomFields
      ? {
          [K2 in keyof NestedFields]: NestedFields[K2] extends FieldAtom<
            infer Value
          >
            ? Value
            : NestedFields[K2] extends FormAtomFields
            ? _FormAtomValues<NestedFields[K2]>
            : NestedFields[K2] extends any[]
            ? _FormAtomValues<NestedFields[K2][number]>
            : never;
        }[]
      : never
    : never;
};

Additional context

the same should be done for FormAtomErrors and FormAtomTouchedFields
when the recursive call will start only from level 1 or 2, we should manually unwrap also the 1 level nesting on line https://github.com/jaredLunde/form-atoms/blob/main/src/index.tsx#L1207

I prefer the current type as it is more readable and thus easier to maintain.

Am I missing something? Wouldn't this work just as well?
export type FormFieldValues<Fields extends FormFields> = {
  [Key in keyof Fields]: Fields[Key] extends FieldAtom<infer Value>
    ? Value
    : Fields[Key] extends FormFields
    ? FormFieldValues<Fields[Key]>
    : Fields[Key] extends Array<infer Item>
    ? Item extends FieldAtom<infer Value>
      ? Value[]
      : Item extends FormFields
      ? FormFieldValues<Item>[]
      : never
    : never;
};

@jaredLunde Yes, the version from case 1 will be ok, as its an improvement.
I don't like the readability of the _FormAtomValues from case 2 neither, it was only illustration that its possible to achieve :)
Maybe typescript will improve this automatically in the future, by eagerly resolving the 'generit type calls' instead of displaying them. Who knows.


[Bug]: With only execute permission on Environments, Able to access environments page.

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When I login with a user having only execute permissions on Environments, I am still able to view and access the environments page
Steps To Reproduce

Give a user a role with only execute permissions on Environments
Login with that user
Note that user is able to view environments option in the kebab menu and the page is accessible, and user can try to edit and delete the page.

https://github.com/appsmithorg/appsmith/assets/101863839/6d655fbf-00c0-49f7-aee0-9a1b026c6b34
Public Sample App
No response
Environment
Deploy Preview
Issue video log
No response
Version
Cloud

Tested. Now the user cannot see environments option in the menu with just execute permissions on environments.


how to use Style2Paints in ComfyUI

how to use Style2Paints in ComfyUI

您好(*?0?7▽｀)ノノ青弦已经收到您的邮件啦！请耐心等待，10个工作日内会给您回复w

how to use Style2Paints in ComfyUI

you cant


BIG-24226 update hello world example

Just updated the hello world app to highlight the scopes associated to the received token and update the code to reflect the the expected behavior when receiving new token for existing installs.

:+1:

:+1: Please follow up on why the omniauth gem is not delivering the scope as expected.


Bad GeoIP2-City.mmdb lookup: MMDB_entry_data_s contains illogical data_size and type

Environment is CenOS 6.0
libmaxmind 1.4.2
Flow:
MMDB_SUCCESS == MMDB_open ()
MMDB_lookup_string(): 0 != gai_error and MMDB_SUCCESS != mmdb_error
And than:
MMDB_entry_data_s countryData = { 0 };
int status = MMDB_get_value(&(result.entry), &countryData, "country", "iso_code", NULL);
if ((status == 0)
	&& (countryData.has_data)
	&& (countryData.type == MMDB_DATA_TYPE_UTF8_STRING))
{
	Country = PooledString(countryData.utf8_string, countryData.utf8_string + countryData.data_size);
}
else
{
	LOGGER_WARN("Cant fetch Country. status: " << status << ",  countryData.has_data: "
		<< countryData.has_data << ", countryData.data_size: " << countryData.data_size
		<< ", countryData.type: " << countryData.type);
}

Produces this log:
WARN 12 Mar 2020 09:26:35.802 IPV6: [21122:139928515954624]: GeoIP2Helper.cpp:102[getRegionByAddress]: Cant fetch Country. status: 0,  countryData.has_data: true, countryData.data_size: 178, countryData.type: 181
Problem: Expecting data_size and type to be 2 (two chars, utf8 type).
More information:

Failed on Linux, works OK on Windows 32 compilation
Tested with 3 different file – same results.
Dumping the results, as MMDB_entry_data_list_s as a big json-like buffer succeeded on all platforms. I see the entries are there.
May be memory/types/compilation issue.

Thanks,
Adi Ariel
Viber Media Backend Team

Did you also check that result.found_entry is true?

Yes - it is true.

That's intended to be an internal field I believe, so you shouldn't need to look at it.

Your snippet looks correct to me. I'm not sure what's wrong. Maybe you could show the MMDB_lookup_string() part of your code as well?

What else can be done? Maybe compilation flags? (We statically link with the lib, not so)
Maybe DB file version mismatch?
PooledString strIp = sourceIP.getDottedIP();
int gai_error = 0, mmdb_error = 0;
MMDB_lookup_result_s result = MMDB_lookup_string(&_mmdb, strIp.c_str(), &gai_error, &mmdb_error);

// check for general errors while lookup
if ((0 != gai_error) || (MMDB_SUCCESS != mmdb_error))
{
	LOGGER_WARN("Failure for IP: " << strIp << "GAI-Error: " << ((0 != gai_error) ? gai_strerror(gai_error) : "No Info") << ", MMDB-Error: " << ((MMDB_SUCCESS != mmdb_error) ? MMDB_strerror(mmdb_error) : "No Info"));
	return ST_NOT_FOUND;
}

// Check for results
if (!result.found_entry)
{

#ifdef _DEBUG
LOGGER_DEBUG("GeoIP2 not found for IP : " << strIp);
#endif
return ST_NOT_FOUND;
}

That looks fine too! I don't think the database version should matter in terms of producing this behaviour, unless it is corrupt somehow.
Does it happen with all IPs? Does valgrind complain about anything? One idea is to try a standalone test program with just the MMDB lookup code to see if it still occurs, to rule out something with your application.


Sugar Cane Growth Ceremony?

Hello!
I know Sugar Cane will not grow with Bone Meal, but is it possible to allow the Growth Speed ceremony to affect it?
https://github.com/Darkosto/SevTech-Ages/issues/1077
If not, no worries! Just wanted to ask if you would consider it :)
Thanks!
Darkosto

Yes, I think I will add that.


Update index.md

Added a space after a dot.

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @mejraf. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Trying to install

Had the plugin in dalamund before the patch tried multiple times to re add the plugin but keeps saying Donwload Failed???

Uninstall the plugin.
Remove the link from repos, readd the link and reinstall plugin.
I can't replicate your problem myself.

Yeah, if removing/reinstalling a plugin or removing/readding a repo works, it's probably something on dalamud side.


refreshAccessToken must not crash when connection is down

[error] Error: getaddrinfo ENOTFOUND idp2-apigw.cloud.grohe.com
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:107:26)
at GetAddrInfoReqWrap.callbackTrampoline (node:internal/async_hooks:128:17)

Also got this two times in the last few weeks. Last yesterday because my DNS was down.
Only way to get the node back up running is to edit and enter the password again in the location node.


Not able to import pytorch_lightning in colab

Whenever I am running the below code in Colab:
import pytorch_lightning as pl
Its is showing below error:
ImportError: cannot import name 'Batch' from 'torchtext.data' (/usr/local/lib/python3.7/dist-packages/torchtext/data/init.py)

Hmmm.... that's weird ... @alankritmishra Did you restart your runtime after installing pytorch-lightning ?

Yes a couple of times, still didn't work. I am doing this experiment with
my custom dataset.
In the requirements you mentioned the version should not be more than
1.0.0. So, i didn't upgrade.
On Mon, Aug 9, 2021, 9:01 AM Ayushman Buragohain @.***>
wrote:

Hmmm.... that's weird ... @alankritmishra
https://github.com/alankritmishra Did you restart your runtime after
installing pytorch-lightning ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/benihime91/pytorch_retinanet/issues/6#issuecomment-895202176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACT6WIN47CVVSTMTYREHNWLT37GQ7ANCNFSM5BZGYWNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

You could probably try looking here for some solutions https://stackoverflow.com/questions/66538407/unable-to-import-pytorch-lightning-on-google-colab. It's seems its due to a version mismatch between pytorch and pytorch-lightning

Colab has probably upgraded the default torch and torchvision version.
torch>=1.6.0 torchvision>=0.7.0

You could try reinstalling the versions mentioned above. Or another way would be to uninstall torchtext.

Okay let me try

@alankritmishra I have updated the demo notebook. Should work on colab now. Do check it out.

Thank you @benihime91 pytorch_lightning  imported successfully after uninstalling torchtext . However, it shows there on module called 'model'
when I am trying from model import RetinaNetModel

Thank you @benihime91 pytorch_lightning imported successfully after uninstalling torchtext . However, it shows there on module called 'model'
when I am trying from model import RetinaNetModel

Should we have to track it as another issue?

Did you try the new demo.ipynb notebook @alankritmishra ?

Yes, and it worked, but I already have csv files for annonation and was trying your original documentation in github.
Here  is my Colab notebook for your reference. Thanks again for such quick response.

Hmmm.... You need to do
import sys
sys.path.append("/content/pytorch_retinanet/")

After cloning the repo and before importing modules from the RetinaNet repo itself

I came through that, Now I just have to mention the right path of my data in hparams.yaml.
It shows below error:
FileNotFoundError: [Errno 2] No such file or directory: '/train/_annotations.csv'
Although, I already provide root path in root_dir placeholder

Is there a way for the model to retrieve the data and annotation directly from my drive, or do I have to upload it on the runtime environment?

You need provide the absolute path to the annotations. And root_dir is needed only for COCO datasets

Hi @benihime91 the original issue is resolved so closing this tracker. Can I dm you for this to work?

Hi @benihime91 the original issue is resolved so closing this tracker. Can I dm you for this to work?

I have emailed you.


Revisit environment agnostic operation

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

CDK has two modes of operation:

environment agnostic (no account/region)
user explicitly sets account/region

We need to revisit what is best for Pulumi CDK:

how to map this and explain for users that are used to CDK, how does it "translate to Pulumi"?
should we consider getting ambient AWS credentials and automatically injecting account/region into CDK stack or not (what the defaults should be)

Affected area/feature

This came up in discussion of Fn::If - the conditionals are mostly in practice used for the environment agnostic operation. THanks @corymhall


How to solve this problem：conv2d() received an invalid combination of arguments

TypeError: conv2d() received an invalid combination of arguments - got (Tensor, weight=Tensor, bias=NoneType, stride=float, padding=int, dilation=int, groups=int), but expected one of:

(Tensor input, Tensor weight, Tensor bias, tuple of ints stride, tuple of ints padding, tuple of ints dilation, int groups)
didn't match because some of the arguments have invalid types: (Tensor, weight=Tensor, !bias=NoneType!, !stride=float!, !padding=int!, !dilation=int!, groups=int)
(Tensor input, Tensor weight, Tensor bias, tuple of ints stride, str padding, tuple of ints dilation, int groups)
didn't match because some of the arguments have invalid types: (Tensor, weight=Tensor, !bias=NoneType!, !stride=float!, !padding=int!, !dilation=int!, groups=int)

Targeting to  ：output = F.conv2d(x, weight=self.weight.squeeze(dim=0), bias=None, stride=self.stride, padding=self.padding,
dilation=self.dilation, groups=self.groups)

It seems that the input argument of stride is a float value. You can use int() function to convert the float value to an integer.


Warning on kup shell k

Not sure what package / dependency this refers to, but I get a (seemingly harmless) warning when running a kup shell:
$ kup shell k
trace: WARNING: 9.2.7 is out of date, consider using 9.2.8.

this is a haskell.nix warning about the version of ghc from either the haskell or booster backend.... should disappear soon as we have migrated both repos to ghc 9.2.8

as this is emitted by nix which we have no control over, i will close


[network] eliminate enable_noise and enable_remote_authentication flags

Motivation
Remove the enable_remote_authentication and enable_noise flags as they are both used only with values of true.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
don't break existing integration tests
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@davidiw @zekun000 @phlip9
This PR covers the removal of the flags identified in #4140..
Note for @davidiw that this does not make it straightforward to assume that a ConnectivityManager has been attached to the network because of the gap between when the NetworkBuilder is created and when add_manager() is invoked.
main_node likely requires a conscious and holistic cleanup/restructuring rather than a series of ad hoc local fixes.

:umbrella: The latest upstream changes (presumably 2108b78338b5d6c0ef83af9b1e403a592de50957) made this pull request unmergeable. Please resolve the merge conflicts.


Talk to the RC API

We need to get this bot talking to the RC API so that we can automate on and off-boarding at the beginning/end of batch. There's been a little bit of work done on it in this commit, but I heard there might be more coming down the pike??? Pinging @anushriadhia!

More work happening on this here -- thanks @anushriadhia!

I've thought about this a lot over the last eight months (:sweat_smile:). I do still think it's important for pairing bot to be able to talk to the RC API, but I now imagine the behavior being different is described in the first comment. I'll make a new ticket scoped only to address getting pairing bot talking to the API, and I won't specifically ticket the design of the new on/off-boarding system (since it's part of a bigger set of general changes that'll come along with the python re-write).

see #8


[Request]: Load network config from file

Feature description
Load network config file dynamically instead of compile it statically into the package.
Motivation
Currently the network config is statically compiled into the package what makes building docker images more complicated because we need a docker image with the correct config inside the docker for each network.
It would be great if the network config could be loaded dynamically at start.
This way we can use a common built docker image (by Github CI) and just mount the correct network config file into the container
Here is a PR that already did this (and it worked, before it was removed during migration of the evm-toolkit from the wasp to the evm-toolkit repository).
https://github.com/iotaledger/wasp/pull/1914
Requirements

Someone re-integrating the PR

Open questions
No response
Are you planning to do it yourself in a pull request?
No

It seems, the current version is a looot different than the evm-toolkit for which the PR was.
The PR dynamically loaded the json when opening the app.
I wonder if the json file couldn't be just loaded when starting the docker (and therefore the app) once instead of requesting the file each time when someone opens the app in the browser.
But idk how Svelte works - but it also would be fine, if a file just could be loaded at docker container start.

new PR: https://github.com/iotaledger/evm-toolkit/pull/18

Closed by https://github.com/iotaledger/evm-toolkit/pull/18


Sort album list and see what albums images are a member of

Currently there is no way to order Albums in the display pane. I think it would be a good feature to be able to sort them. Even if just alphabetically in ascending/descending order. It would make adding images to albums that aren't in the top 10 easier when listed alphabetically.
Also, it would be handy to know which albums images are a member of. Perhaps in the show info window when viewing an image.

Thanks, I'll see what I can do for sorting.  I'm currently trying a drag and drop implementation.  I'll also probably add album filtering by a search box.

I want to piggyback on this issue and ask if there is a way to export a list of files from an album?  I'd like to be able to sort my images, and find them in the Windows explorer as members of an Album.   Filtered either by metadata or by physically moving them to a named folder.  Is this possible, or any workaround currently?

I'm planning to add a feature to do a bunch of stuff to albums, such as export parameters to a single text file to input into A1111 again, or move to a different folder.
There is existing querying for album names.  You need to add quotes if the name contains a space e.g:
album: "Book Covers"

With the latest release, you can now sort the album list (menu Albums > Sort), and see what albums images are members of in the info.
Still thinking of ways to show at a glance if an image in the thumbnail pane is in an album or not, as that would help when moving images into albums.

The list of albums an image is a member of is now displayed in metadata.


Feat:Dark Mode Not Working in Canteen End

Describe the feature
In Canteen End Dark Mode is not working i want to Fix That
Add ScreenShots
https://github.com/VanshKing30/FoodiesWeb/assets/101548649/1adbc822-55a1-4007-8d48-8bce773d7ad0
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Fix it


updated little-snitch (3.6.2)

Thank you for the contribution. It was merged directly as aef08d685288beeba820c6d47fa67b4c709bfbfa to keep commit history cleaner. Your contribution is still credited to you.


Electron 8: Linux smoke test errors

#96316

VSCode Smoke Tests (Electron)
Localization
starts with 'DE' locale and verifies title and viewlets text is in German:
Error: Timeout: get text content 'div[id="workbench.view.explorer"] .split-view-view:nth-child(1) .title' after 20 seconds.
at /home/parallels/vscode/test/automation/out/code.js:174:23
at Generator.next ()
at fulfilled (/home/parallels/vscode/test/automation/out/code.js:9:58)

Seems to work manually.

seems flaky, this ran fine on windows

@JacksonKearl which platform are you on?

.deb, Ubuntu 18

Thanks!

I am closing this issue. The smoke tests passed in the weeks where Electron 8 was in insiders.


add new semantic release test

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix bug with keyboard input in click tooltips

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change
In https://github.com/atom/atom/pull/17651/files, @cacheflow (hi! I think we follow each other on twitter, fancy seeing you here 😄  ) fixed a bug where tooltips were obscuring some of the areas in a user workspace, by making the tooltips disappear on keydown.
Unfortunately, this fix led to some unfortunate side effects.  Some tooltips (such as Teletype, and the github atom branch creation menu) need keyboard functionality.  These tooltips were closing on keypress, so users couldn't actually enter the input.  Also, window.addEventListener was being called every time a new tooltip was registered/added to the TooltipManager, which led to the creation of many additional keyboard listeners.  Atom generally follows the event delegation pattern, to avoid unnecessary listeners as it's bad for performance.
This fix scopes @cacheflow's original changes to only tooltips that are triggered on hover.  The assumption being, hover tooltips are most likely to get in the way.  The thinking is, click-triggered tooltips are more likely to be intentionally triggered (and all the input tooltips are click-triggered.) It also attaches/removes the event listeners when a hover tooltip is shown, rather than when the tooltip is registered with the event manager.  That's going to cut down on the number of listeners.
Alternate Designs
I'm a little afraid of the event handling code in atom/atom and tbh didn't really consider any alternatives.
Why Should This Be In Core?
It's a bugfix of existing core functionality.
Benefits
Teletype and the github atom branch selector work again.
Possible Drawbacks
The handling for events in Atom is complicated.  It's possible that this fix could trigger undesirable behavior. For example, if there are tooltips that are triggered by a click, that are blocking somewhere where a user wants to type, the user will have to dismiss these tooltips with a click.
Verification Process

Manual testing:

tested that typing dismisses a hover-triggered tooltip
tested that typing does not dismiss a click-triggered tooltip
tested that when a hover-triggered tooltip and a click-triggered tooltip are both showing, typing dismisses the hover-triggered tooltip but not the click-triggered tooltip

Unit tests

show a click-triggered tooltip.  Fire a keyboard event.  Assert the click-triggered tooltip is still there.
show a hover-triggered tooltip.  Fire a keyboard event.  Assert the tooltip has gone to the great dev/null in the sky.  (Mostly I moved @cacheflow's existing test, to live with the other tests of hover-triggered tooltips, just to keep the test suite organized.)

negated assertions to verify that things fail as expected

Applicable Issues
https://github.com/atom/atom/issues/18041

@cacheflow yes, it would probably be better to fix the resizing events as well.  In case there are side effects, it would probably be good to clean that up separately.  I added a comment though, just so people don't add more listeners in tooltipManager in the meantime.

I'll tackle that in another commit. @annthurium.


No information in the plugin's panel

The Gerrit plugin is not working with the Intellij version referred below.  It's possible to connect to the server, but there is no information in the plugin's panel.
Gerrit version: 2.14.16-105-g1fbfa3d565

IntelliJ IDEA 2018.3.3 (Ultimate Edition)
Build #IU-183.5153.38, built on January 9, 2019
Licensed to Alexandre Verri
Subscription is active until July 2, 2019
JRE: 1.8.0_152-release-1343-b26 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

It's possible to connect with success to the Gerrit server:

There is no information in the plugin panel:

Hi,
I have a seemingly similar issue: I have set up the Gerrit plugin and could successfully authenticate, I even received a popup notification that I have incoming reviews waiting for me, yet the plugin's page is empty no matter how I set up the filters. I checked that the git remote matches our Gerrit domain (barring the fact that the git remote is stored in username@domain format, while the Gerrit URL is simply the domain). There are no errors in the CLion event log. Do you have any ideas on what should I check?
Thanks

@averri & @yosuah: You can enable request logging in your IDE: Help -> Debug Log Settings... -> add "gerrit" (without quotes) on a new line.
Then you can find all requests in system/log/idea.log.
That probably gives us some insights what's going on wrong with the requests here.

@uwolfer I've enabled logging but can not see anything interesting in my logs. I've closed & opened CLion, went to project settings, hit refresh multiple times, changed what to show in the panel, etc. I don't see errors, but I also don't see a connection being made after hitting refresh, only one at startup. I've opened this link and verified that it contains the correct response in JSON, which is also processed by the Gerrit pluging, because right after startup I get one notification of my reviews in the console window/balloon, but no further connections are made. Do you have any other ideas?
Btw our company uses Gerrit 2.16.5, I don't know if that is a useful piece of information.
~/.CLion2018.3/system/log$ grep --text gerrit idea.log
2019-03-26 12:13:40,594 [94462980]   INFO - lij.diagnostic.DebugLogManager - Set DEBUG for the following categories: gerrit
2019-03-26 12:16:16,912 [   3065]   INFO - lij.diagnostic.DebugLogManager - Set DEBUG for the following categories: gerrit
2019-03-26 12:16:27,696 [  13849]  DEBUG -                         gerrit - GET /login/ HTTP/1.1 []
2019-03-26 12:16:27,837 [  13990]  DEBUG -                         gerrit - POST /login/ HTTP/1.1 []
2019-03-26 12:16:28,014 [  14167]  DEBUG -                         gerrit - GET / HTTP/1.1 []
2019-03-26 12:16:28,027 [  14180]  DEBUG -                         gerrit - GET /changes/?q=is:open+reviewer:self&o=DETAILED_ACCOUNTS HTTP/1.1 [X-Gerrit-Auth: [hidden], Accept: application/json]
2019-03-26 12:18:13,845 [   3058]   INFO - lij.diagnostic.DebugLogManager - Set DEBUG for the following categories: gerrit
2019-03-26 12:18:25,596 [  14809]  DEBUG -                         gerrit - GET /login/ HTTP/1.1 []
2019-03-26 12:18:25,808 [  15021]  DEBUG -                         gerrit - POST /login/ HTTP/1.1 []
2019-03-26 12:18:25,965 [  15178]  DEBUG -                         gerrit - GET / HTTP/1.1 []
2019-03-26 12:18:25,977 [  15190]  DEBUG -                         gerrit - GET /changes/?q=is:open+reviewer:self&o=DETAILED_ACCOUNTS HTTP/1.1 [X-Gerrit-Auth: [hidden], Accept: application/json]
2019-03-26 12:20:08,893 [ 118106]  DEBUG -                         gerrit - GET /login/ HTTP/1.1 []
2019-03-26 12:20:08,920 [ 118133]  DEBUG -                         gerrit - GET /changes/?n=1 HTTP/1.1 [Accept: application/json]

It looks like the relevant requests are not issued at all in your case @yosuah. I have not idea at all what happens here.
It would help if somebody who can reproduce this issue could debug into it; see: https://github.com/uwolfer/gerrit-intellij-plugin#build-and-develop-the-plugin


fix: passing ddb params from root to nested model stacks

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8766 (14bb0b6) into releaseGQLE2E (aa1096c) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           releaseGQLE2E    #8766   +/-   ##
==============================================
  Coverage          57.20%   57.20%
==============================================
  Files                757      757
  Lines              42243    42243
  Branches            8659     8659
==============================================
  Hits               24166    24166
  Misses             17263    17263
  Partials             814      814

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1096c...14bb0b6. Read the comment docs.


Thread deadlock on Bukkit

Description
Luckperms blocks the main thread causing the server to freeze and crash.
Issues seems to be related to https://github.com/LuckPerms/LuckPerms/issues/3483, although it is locking from a different call this time.
Attached a complete stacktrace dump to this issue.
Reproduction Steps
Not quite sure as it is very rare, but does happen every now and then.
Expected Behaviour
To not freeze the main thread.
Server Details
Paperspigot-1.8.9-git-2894af0
LuckPerms Version
5.4.49
Logs and Configs
stackdump.txt
Extra Details
No response

[21:05:17] [Paper Watchdog Thread/ERROR]: 	eu.smashmc.smash.game.listener.PlayerToggleSneakListener.toggleSneak(PlayerToggleSneakListener.java:23) whatever this plugin is, it appears to be checking permissions of lots of players whenever they sneak. report this to that plugin instead.

[21:05:17] [Paper Watchdog Thread/ERROR]: eu.smashmc.smash.game.listener.PlayerToggleSneakListener.toggleSneak(PlayerToggleSneakListener.java:23) whatever this plugin is, it appears to be checking permissions of lots of players whenever they sneak. report this to that plugin instead.

This is our plugin, checking a permission once when a player happens sneaks under certain conditions.

Why are you not using Player::hasPermission("perm")? Luckperms already modifies the outcome of that.
If you are looking to avoid the bukkit api for whatever reason, why are you not using User::getCachedData().getPermissionData().checkPermission("perm")? There is no need to perform a lookup to a databse every time. Just use the already cached data.

It looks like you are making queries to a database for this to happen? If so:
In general Player::hasPermission("perm") is safe? Luckperms already modifies the outcome of that. If you are looking to avoid the bukkit api for whatever reason, you can use User::getCachedData().getPermissionData().checkPermission("perm")? It shouldn't need to perform a DB query every time.

I am using Player#hasPermission for this. The player is actually comming from a Bukkit.getOnlinePlayers() loop - so the player must be online and should already be cached by luckperms.

I think it would be useful if you would provide the entire log file following up to that crash, and you can choose to censor IPs if you wish to do so. I think also providing the 20-ish lines of code around your permissions check can help make sure there are no issues there.

Yeah I am not seeing anything obviously wrong here..
I was mostly interested in the logs though as that may have even small warnings at startup or after that would indicate issues with loading permissions for a player. If you are able to reproduce this behavior that would be great.

i highly suspect that "checking permsisions of many players when anyone crouches or uncrouches" has something to do with this problem. sure you have a cooldown, but you iterate over the blocks and check the permission on many players each iteration. there is no context here for how many iterations its doing on blocks. if you have a complex permissions setup with lots of parent groups, it will take longer to calculate permissions. being unable to see more code or details about how your permissions are setup, its hard to tell what the issue actually is.
i assume you are also setting and unsetting this smash.advantage permission in your plugin code. why not just store this advantage data yourself with a map or even on the player directly with bukkit's metadata?

LuckPerms doesn't actually appear the second time the server thread is dumped:
[21:05:17] [Paper Watchdog Thread/ERROR]: Current Thread: Server thread
[21:05:17] [Paper Watchdog Thread/ERROR]: 	PID: 39 | Suspended: false | Native: false | State: RUNNABLE
[21:05:17] [Paper Watchdog Thread/ERROR]: 	Thread is waiting on monitor(s):
[21:05:17] [Paper Watchdog Thread/ERROR]: 		Locked on:app//org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:475)
[21:05:17] [Paper Watchdog Thread/ERROR]: 	Stack:
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.util.HashMap.hash(HashMap.java:338)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.util.HashMap.getNode(HashMap.java:568)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.util.HashMap.getOrDefault(HashMap.java:1139)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.character.CharacterManager.getCharacter(CharacterManager.java:90)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.mechanic.VelocityHandler.getEffectiveVelocityMultiplier(VelocityHandler.java:121)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.mechanic.VelocityHandler.applyRawVelocity(VelocityHandler.java:99)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.character.characters.Toph.pushbackPlayers(Toph.java:163)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.character.characters.Toph.spawnWall(Toph.java:110)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.character.characters.Toph.onToggleSneak(Toph.java:49)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		eu.smashmc.smash.game.listener.PlayerToggleSneakListener.toggleSneak(PlayerToggleSneakListener.java:23)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		jdk.internal.reflect.GeneratedMethodAccessor77.invoke(Unknown Source)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.lang.reflect.Method.invoke(Method.java:568)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:300)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:74)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:490)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:475)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:1344)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.PacketPlayInEntityAction.a(SourceFile:43)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.PacketPlayInEntityAction.a(SourceFile:9)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:6)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.PlayerConnectionUtils$$Lambda$1485/0x00000008017c7208.run(Unknown Source)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:781)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:376)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:720)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		app//net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:613)
[21:05:17] [Paper Watchdog Thread/ERROR]: 		java.base@17.0.3/java.lang.Thread.run(Thread.java:833)

Seems like a coincidence, but please feel free to open another issue if it occurs again.


Do not run CodeQL in merge queue commits

CodeQL does not reliably run in merge queue commits since it's not a required check (so commits may be automatically removed after merge but before CodeQL has reported).

I can't see any non-linty changes -- is that correct?


Removing the alpha label?

With the recent posit::conf(2023) talk (amazing to see that live), it'd be great to have that alpha label removed from the readme. I'm going to point some of my colleagues to the package and don't want them to be nervous!

This is something one would think I would have done before the talk. #189


Property 'li' does not exist on type 'JSX.IntrinsicElements'

I am new to react and every time I open or write regular html tags I get errors about them using coc-tsserver
## versions

vim version: VIM - Vi IMproved 9.0 9001424
node version: v20.3.1
coc.nvim version: 0.0.82-f52ab48c 2022-12-15 01:56:36 +0800
coc.nvim directory: /Users/seion/.vim/plugged/coc.nvim
term: Apple_Terminal
platform: darwin

## Log of coc.nvim

2023-06-27T16:25:31.106 INFO (pid:39257) [plugin] - coc.nvim initialized with node: v20.3.1 after 107
2023-06-27T16:25:38.416 INFO (pid:39257) [attach] - receive notification: showInfo []

Plugs:
call plug#begin()

" Polyglot is Syntax highlighting
Plug 'sheerun/vim-polyglot'

" Code Completion
Plug 'neoclide/coc.nvim', {'branch': 'release'}

" Side Bar
Plug 'preservim/nerdtree'

" ColorScheme
Plug 'NLKNguyen/papercolor-theme'

" Bottom Bar
Plug 'vim-airline/vim-airline'

Plug 'pangloss/vim-javascript'
Plug 'leafgarland/typescript-vim'
Plug 'peitalin/vim-jsx-typescript'
Plug 'styled-components/vim-styled-components', { 'branch': 'main' }

Plug 'OmniSharp/omnisharp-vim'
Plug 'dense-analysis/ale'
Plug 'nickspoons/vim-sharpenup'
Plug 'junegunn/fzf'
Plug 'junegunn/fzf.vim'

call plug#end()

Also want to note that its able to detect all typescript and react elements just fine. Its only complaining about the regular HTML tags like div, li, ul, ect...

I think this is something to do with my tsconfig or node modules installed, because its not happening in another project that has tsx files in it

I was having this same problem (along with some others) and realized that coc-tsserver is using typescript 4.9.3, see:
https://github.com/neoclide/coc-tsserver/blob/d8a2f44d64fcefaf6a2087cd5d0b7783393b73d7/package.json#L1180 and https://github.com/neoclide/coc-tsserver/blob/d8a2f44d64fcefaf6a2087cd5d0b7783393b73d7/yarn.lock#L184
and the project I was starting up was using typescript 5.0.2 and there were some incompatibilities.
I solved this by setting "tsserver.useLocalTsdk": true on the coc-settings.json. All the errors I was seeing went away.
I got the solution from https://github.com/neoclide/coc-tsserver/issues/434#issuecomment-1588758486, thanks @yaegassy for the explanation.

Fixed on<EMAIL_ADDRESS>


[SPARK-12979][Mesos] Don’t resolve paths on the local file system in Mesos scheduler

The driver filesystem is likely different from where the executors will run, so resolving paths (and symlinks, etc.) will lead to invalid paths on executors.

Test build #50106 has started for PR 10923 at commit 79bd5c6.

Test build #50106 has finished for PR 10923 at commit 79bd5c6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50106/
Test PASSed.

Merged into master


Snippets for custom css-counters

Your idea:
From DOMT

Also, in a similar vein, references. In overleaf there are a set of commands to reference an item in the document (like a paragraph, equation, picture, or even a section). So it would be incredibly useful to have that as well. Making it easier to navigate through the contents.
To avoid confusion, what I was referring to [here] was the \label{}, \cite{} and \ref{} functions overleaf has. HB has [{{_Text}}](#p), which returns an hyperlink Text that doesn't add the number of reference (like "fig. 10" which is the overleaf format).

It is possible to use custom css to insert an incrementing reference number (e.g. ##### Table {tableCounter }: Misc. Stuff).
It would be helpful to have some snippets that show what the format should be. Snippets for "Incrementing Table number", or "Incrementing Figure reference" .. with the necessary css already defined in theme-style.css. (Some theme sources even have style conventions of prefixing all tables with "Table NN: ").
If we define this custom css in THB, we can also detect it when rendering and insert window.getComputedStyle(elem).counter(counter-name) for a limited but known set of counter-names (e.g. tableCounter, figureCounter). Those IDs could then be used to generate a TOC-like list of tables or figures.
Caveat: the links of such a TOC-like list of tables or figures would fail if partial-rendering is active for the document (only the page stubs are rendered, not the page contents, for pages which are not the currently viewed or adjacent thereof). Would still be helpful for /print resources. (partially rendering fragment targets could be a separate issue).

At this stage, would this not be better handled by the impending variables system?

At this stage, would this not be better handled by the impending variables system?

Definitely, especially since the values of css-counter can not be accessed by javascript. They can only be displayed according to css (and reset and incremented). This would make using css-counter impossible for the use case of "See figure [%css-counter-foo%]".
Using variables we would instead increment the variable and then assign the value of that counting variable to a nominative variable (e.g. increment $[figure_counter], assign $[figure_counter] to $[figure_dog], and use $[figue_dog] eveytime we want to display the value figure_counter had at the time we incremented the counter for the dog figure).

removing phb style label, since this has a use-case for every theme

Can we reword this problem assuming a brew variables based solution?


i cant install this.

Dear developer, im very appreciate you made this tool, i really want to use my LG TV remote to controll my pc, but i cant install it as well,  the system show those things i cant understand, im a noob at this, pls help th

x

Unfortunately, as I cannot read Chinese, I cannot read these error messages.
Try downloading this zip file and installing "WindowsAppSDK-Installer-x86/WindowsAppRuntimeInstall.exe".

This last screenshot indicates that the installation of WindowsAppRuntime was successful.
Now try installing Magic4PC again by running install_x64.bat in the latest release.
I have not tested this app with Windows LTSC. The app may be incompatible.

lame ;c
information shows i need install vclibs, version least tha 14.0.30035, but its hard to find out download link, so sad (sigh)

This page seems to have redistributable packages for vclibs. Perhaps this one is what you need?

@Wouterdek
Hey Wouterdek, sorry i'm busy for past day. I tried to reinstall win 10 and download the tool again, here you can see the picture

, idk its successfully installed or not, and tv root tool you provied seems gone(https://github.com/Wouterdek/magic4pc/blob/master/rootmy.tv), really hope i can use it soon ! much love !
Tom.

its installed :D


add .debug class

{{output.some.values.for.debugging}}

Add a debug class ala sassquatch1 that allows us to dump values into a page when debugging (pink BG, mono font, red color, etc).
Extra bonus (requires a chapstick dependency): set this class to display none unless in "debug" mode via the dev bar, which could toggle a body class or something

in PR https://github.com/meetup/sassquatch2/pull/132

merged to release/1.0.0


Single OData controller not visible in Swagger

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I tried to follow example for .net 6 but still do not see OData endpoint in swagger
Expected Behavior
both Odata and Odata metadata visible in Swagger
Steps To Reproduce
ODataConfiguration.cs
public class RightmoveEntityModelConfiguration : IModelConfiguration
{
    /// <inheritdoc />
    public void Apply(ODataModelBuilder builder, ApiVersion apiVersion, string routePrefix)
    {
        builder.EntitySet<RightmoveEntity>("RightmoveEntities").EntityType.HasKey(p => p.Id);
    }
}

RightmoveController.vs
[ApiVersion( 1.0 )]
public class RightmoveController : ODataController
{
    private readonly HomesContext _context;
    public RightmoveController(HomesContext context)
    {
        _context = context;
    }

    [HttpGet]
    [Produces( "application/json" )]
    [EnableQuery]
    public IQueryable<RightmoveEntity> GetRightmoveEntity()
    {
        return _context.RightmoveEntities;
    }
}

Program.cs
var builder = WebApplication.CreateBuilder(args);

// Add services to the container.

var config = new ConfigurationBuilder()
    .SetBasePath(Directory.GetCurrentDirectory())
    .AddJsonFile("appSettings.json")
    .AddEnvironmentVariables()
    .Build();

builder.Services.AddDbContext<HomesContext>(b => b.UseSqlServer(config.GetValue<string>("SqlConnectionString")));

builder.Services.AddControllers().AddOData(options =>
{
    options.Expand().Select().Filter().OrderBy().Count();
    options.RouteOptions.EnableKeyInParenthesis = false;
    options.RouteOptions.EnableNonParenthesisForEmptyParameterFunction = true;
    options.RouteOptions.EnablePropertyNameCaseInsensitive = true;
    options.RouteOptions.EnableQualifiedOperationCall = false;
    options.RouteOptions.EnableUnqualifiedOperationCall = true;
});
builder.Services.AddApiVersioning(options => {
        options.DefaultApiVersion = new ApiVersion(1, 0);
        options.ReportApiVersions = true;
        options.AssumeDefaultVersionWhenUnspecified = true;
    })
    .AddOData( options => options.AddRouteComponents( "api" ) )
    .AddODataApiExplorer(
        options =>
        {
            // add the versioned api explorer, which also adds IApiVersionDescriptionProvider service
            // note: the specified format code will format the version as "'v'major[.minor][-status]"
            options.GroupNameFormat = "'v'VVV";

            // note: this option is only necessary when versioning by url segment. the SubstitutionFormat
            // can also be used to control the format of the API version in route templates
            options.SubstituteApiVersionInUrl = true;

        } );;

    // Learn more about configuring Swagger/OpenAPI at https://aka.ms/aspnetcore/swashbuckle
builder.Services.AddTransient<IConfigureOptions<SwaggerGenOptions>, ConfigureSwaggerOptions>();
builder.Services.AddSwaggerGen(
    options =>
    {
        // add a custom operation filter which sets default values
        options.OperationFilter<SwaggerDefaultValues>();

        var fileName = typeof( Program ).Assembly.GetName().Name + ".xml";
        var filePath = Path.Combine( AppContext.BaseDirectory, fileName );

        // integrate xml comments
        options.IncludeXmlComments( filePath );
    } );

var app = builder.Build();

// Configure the HTTP request pipeline.
if (app.Environment.IsDevelopment())
{
    // navigate to ~/$odata to determine whether any endpoints did not match an odata route template
    app.UseODataRouteDebug();
}
app.UseSwagger();
app.UseSwaggerUI(
    options =>
    {
        var descriptions = app.DescribeApiVersions();

        // build a swagger endpoint for each discovered API version
        foreach ( var description in descriptions )
        {
            var url = $"/swagger/{description.GroupName}/swagger.json";
            var name = description.GroupName.ToUpperInvariant();
            options.SwaggerEndpoint( url, name );
        }
    } );

app.UseHttpsRedirection();
app.UseAuthorization();
app.MapControllers();

app.Run();

Exceptions (if any)
No response
.NET Version
6.0.203
Anything else?
   <PackageReference Include="Asp.Versioning.OData" Version="6.4.0" />
        <PackageReference Include="Asp.Versioning.OData.ApiExplorer" Version="6.4.0" />
        <PackageReference Include="Microsoft.AspNetCore.OData" Version="8.0.12" />
        <PackageReference Include="Microsoft.EntityFrameworkCore" Version="7.0.1" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="7.0.1" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="7.0.1">
          <PrivateAssets>all</PrivateAssets>
          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
        </PackageReference>
        <PackageReference Include="Swashbuckle.AspNetCore" Version="6.4.0" />

I admit, you had me stumped for a second. I thought I had introduced a regression. How did I figure it out? By looking at ~/$odata. I've been bit by this so many times that I just threw it into all of the examples with app.UseODataRouteDebug();.
So what's the problem? Succinctly - OData 🤣. If you don't know or follow the OData routing conventions to the letter, things can go sideways. So what went wrong?

You registered the entity set with builder.EntitySet<RightmoveEntity>("RightmoveEntities")
a. The matching controller type must be named RightmoveEntitiesController
b. Your controller is named RightmoveController
The action is question is an entity set query; therefore the method must be named Get or GetRightMoveEntities
a. Your action is named GetRightmoveEntity

The OData routing conventions can be difficult to remember; especially for action mapping. Whenever possible, I recommend sticking the simple HTTP method names (which is the real API method anyway). It's much more succinct and easier to remember.
If you refactor to this, it will work:
[ApiVersion( 1.0 )]
public class RightmoveEntitiesController : ODataController
{
    private readonly HomesContext _context;
    public RightmoveController(HomesContext context) => _context = context;

    [HttpGet]
    [Produces( "application/json" )]
    [EnableQuery]
    public IQueryable<RightmoveEntity> GetRightmoveEntities() => _context.RightmoveEntities;
}

Oddly, the controller was not listed at all under ~/$odata, which is strange. This might be a bug in its logic, but it was definitely a clue that something didn't match up to what OData expected.

You are absolutely correct, it was my mistake that I forget to follow convention.
Happy New Year!

No problem. I can't tell you how many times I've been bitten by this. 🤦🏽♂ Hapy New Year to you as well! 🥳


Fix code blocks

Lead-in PR for the work on https://github.com/dotnet/docs/issues/2192. This fixes some goofy code blocks.
cc/ @cartermp There are a couple of fsharp ones in here to :eyes: review.

Thanks @cartermp!
@rpetrusha Look ok?


docs: various updates

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

analytics: linkify links to Google documentation, clarify current usage, policy, and first-run behavior
brief mention about using custom Requirements
update current practice w.r.t. cross-compilers and alternative toolchains
FAQ: move terminology question to the top (since we get complaints about it all the time), remove deprecated behavior (manual brew cleanup, brew pull, etc.), include new features in brew info and brew extract for disabled/deleted formulae
livecheck is no longer an external command
remove outdated mentions of npm@5 and python 2.7
include relevant mentions of the Homebrew discussion forums where needed
brews -> formulae
clarify that we don't permit tap migrations out of homebrew/core
move kickstarter supporters to its own bullet point group

Thanks for the reviews all!


[VM] On-chain whitelist config

Motivation
This is a pretty lengthy PR that illustrate the first usage of having a on chain config module. With this PR, the publishing option for LibraVM will now live on chain so that we don't need to worry about updating all configs across the validators.
This PR covers three major changes:

I added the is_genesis functionality to compensate the fact that we are running multiple reconfiguration operations within the genesis despite the regular restriction that only one reconfiguration can be triggered within one block. cc @tzakian
I moved the VMPublishingOption from config crate  to libra-type crate as it is no longer a config item we need to store locally. Because of that lots of e2e testing code were modified :(
And finally I included the boiler plate code to generate and load configs in Rust.

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Added a test to change the PublishingOption at runtime in functional test. Will add the same test to smoke test in the future.
Further Cleanup Planned.

This PR didn't fully remove the VMConfig in config crate.
This PR didn't have an end to end testing in smoke test testsuite. Will add it in a separate PR.

Related PRs
#2835

Question for all of you: where should the rust representation of on chain config values live? Currently I just store the VM specific on chain config in libra_vm but we might want to have a centralized location for storing such values. Any suggestions? @davidiw

Question for all of you: where should the rust representation of on chain config values live? Currently I just store the VM specific on chain config in libra_vm but we might want to have a centralized location for storing such values. Any suggestions? @davidiw

I  would think in libra/types? Surely clients will want to read the values of some key configs without going through the VM. This seems superficially similar to the problem of representing key move types in Rust (e.g., Account).

:umbrella: The latest upstream changes (presumably 8530581d485aa99f7fa67ca85fde926fe97d2d8a) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra  r=sblackshear

:pushpin: Commit 0510ef8 has been approved by sblackshear

:hourglass: Testing commit 0510ef82a7b65949c6d986f858d27fd1ca4926d4 with merge 21425265ee6e325018f2fb6e8a7089f1b5d78afa...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: sblackshear
Pushing 21425265ee6e325018f2fb6e8a7089f1b5d78afa to master...


Question: Does this work across browsers and devices?

Hi,
I'm looking for a tool that would work across browsers and devices. Would this work for that or would it only work on Chrome?
Thanks!

Hi @danieltisdale
It only works with chrome. Why do you need to make it work cross devices/browsers? This is just for visual regression
Nima

@NimaSoroush Hi Nima,
Our platform runs across devices, browsers, OS versions, so I wanted to find a tool that would allow me to see visual regressions when we deploy a new version of the code. Essentially, we'd like to be able to see if there are any changes across Edge, Firefox, Chrome, Safari, etc from version to version of our code. Does that make sense?

Hi Daniel,
Yeah, that makes sense, but there is a tradeoff between what you get as a local (possibly dockerized) browser vs using a cloud provider which has a variety of browser/OS combinations and you can do what you described.
Differencify only focuses on visual regression testing on chrome headless which can easily be integrated with CI tools and doesn't need 3rd parties to run the visual test
VS
Something like applitools which is a cloud visual regression provider


facebook_referrals or messaging_referrals ?

My controller didn't pick up the ref parameter that is added to the URL, e.g. m.me/botname/?ref=params
Is there any example to show how this is used in botkit?

Can you share an example of the controller listener thats not getting the ref param?
You should be able to do something like this:
controller.on('facebook_referral', function(bot, message) {
 console.log(message.referral)
})


agent fail to start with "Failed to open Intel SGX device"

when start container with runc in bundle dir see following error:
root@iZ2ze49w79e4zvkn2mcbscZ:/opt/confidential-containers/share/enclave-cc-agent-instance# runc run 1234567
[get_driver_type /home/sgx/jenkins/ubuntuServer2004-release-build-trunk-218/build_target/PROD/label/Builder-UbuntuSrv20/label_exp/ubuntu64/linux-trunk-opensource/psw/urts/linux/edmm_utility.cpp:111] Failed to open Intel SGX device.
[ERROR] occlum-pal: Failed to create enclave with error code 0x2006: Invalid SGX device. Please make sure SGX module is enabled in the BIOS, and install SGX driver afterwards. (line 152, file src/pal_enclave.c)
and the device section in config.json of agent bundle is as below:
"devices": [
{
"path": "/dev/sgx_enclave",
"type": "c",
"major": 10,
"minor": 125,
"fileMode": 438
}
]

check what is the minor for that device on your node from /proc/misc

since we install the SGX SDK libs from their APT repository, we automatically get the latest version 2.18 which is broken due to https://github.com/intel/linux-sgx/issues/920. Creating a symlink from the non-standard /dev/sgx/enclave -> /dev/sgx_enclave fixes the problem

currently our e2e does not check with HW mode so this issue is not reflected in time in all the PR e2e test, this situation should be improved.

The SDK fix is expected to be released maybe this week still.

app container also has this issue:
root@iZ2ze49w79e4zvkn2mcbscZ:~# cat  /var/log/pods/default_enclave-cc-pod_28c552b5-cc3f-4cf4-ab49-c958edd2416b/hello-world/0.log
2023-01-12T00:37:34.512107365+08:00 stderr F [get_driver_type /home/sgx/jenkins/ubuntuServer2004-release-build-trunk-218/build_target/PROD/label/Builder-UbuntuSrv20/label_exp/ubuntu64/linux-trunk-opensource/psw/urts/linux/edmm_utility.cpp:111] Failed to open Intel SGX device.
2023-01-12T00:37:34.512127777+08:00 stderr F [ERROR] occlum-pal: Failed to create enclave with error code 0x2006: Invalid SGX device. Please make sure SGX module is enabled in the BIOS, and install SGX driver afterwards. (line 152, file src/pal_enclave.c)
@mythi @haosanzi

that means to workaround this bug, we need change both agent's config.json  and app's yaml  to add sgx devices:
for this workload POD definition hello_world-enc.yaml
apiVersion: v1
kind: Pod
metadata:
name: enclave-cc-pod
spec:
containers:

image: docker.io/eqmcc/helloworld_enc
name: hello-world
workingDir: "/run/rune/boot_instance/"
**volumeMounts:

mountPath: /dev/sgx/enclave
name: sgx-enclave
mountPath: /dev/sgx/provision
name: sgx-provision
securityContext:
privileged: true**
resources:
limits:
sgx.intel.com/epc: 600Mi
env:
name: OCCLUM_RELEASE_ENCLAVE
value: "1"
command:
/run/rune/boot_instance/build/bin/occlum-run
/bin/hello_world
runtimeClassName: enclave-cc
**volumes:

name: sgx-enclave
hostPath:
path: /dev/sgx_enclave
name: sgx-provision
hostPath:
path: /dev/sgx_provision**

@hairongchen if you create these /dev/sgx/enclave -> /dev/sgx_enclave symlinks on the host and use v0.24 device plugin it will just work

@mythi hi,mikko.
I want to provide more information about this issue.
Our CI/CD SGX machine the sgx device has the symlinks, and met the agent fail to start with "Failed to open Intel SGX device"
lrwxrwxrwx 1 root root 14 Jan  9 11:05 /dev/sgx/enclave -> ../sgx_enclave
root@iZ2ze49w79e4zvkn2mcbscZ:~# ls -l /dev/sgx/provision
lrwxrwxrwx 1 root root 16 Jan  9 11:05 /dev/sgx/provision -> ../sgx_provision

The fix solution is to mount host /dev/sgx_enclave to /dev/sgx/enclave in the container environment.
The Root cause is:  after analysis the SDK code, we found that SGX SDK does not provide the support /dev/sgx_enclave.
Therefore, if we have /dev/sgx_enclave in the container environment, we will meet the Failed to open Intel SGX device. problem. We need to have /dev/sgx/enclave in container environment,.
// @psw/urts/linux/edmm_utility.cpp
int hdev = open("/dev/sgx/enclave", O_RDWR);    //attempt to open the in-kernel driver
if (-1 == hdev)
{
    hdev = open("/dev/isgx", O_RDWR);    //attempt to open the out-of-tree driver
    if (-1 == hdev)
    {
        hdev = open("/dev/sgx", O_RDWR);  //attempt to open the DCAP driver
        if (-1 == hdev)
        {
            SE_PROD_LOG("Failed to open Intel SGX device.\n");
            return false;
        }
        sgx_driver_type = SGX_DRIVER_DCAP;
    }
    else
    {
        sgx_driver_type = SGX_DRIVER_OUT_OF_TREE;
    }
}
else
{
    sgx_driver_type = SGX_DRIVER_IN_KERNEL;
}

Based on the above analysis, I think use v0.24 device plugin it will just work may not work because it seems mount to /dev/sgx_enclavein container environment.  Please correct me if I am wrong. Thank you.

@hairongchen if you create these /dev/sgx/enclave -> /dev/sgx_enclave symlinks on the host and use v0.24 device plugin it will just work

that's sth we can keep investigating after the release, now the CI machine as the link already andrunning v0.25 plugin, but not work.
But I don't suggest do the changes for plugin version for now since we already spent time to find workaround for now, this will keep CI base env stable.

PR for temp fix: https://github.com/confidential-containers/enclave-cc/pull/90

@hairongchen if you create these /dev/sgx/enclave -> /dev/sgx_enclave symlinks on the host and use v0.24 device plugin it will just work

Make sense. Since 0.24.0 intel sgx plugin mount /dev/sgx dir to /dev/sgx dir in container environment. Thank you very much.

this would work for workload container, but agent still need these devices to be mounted in as it does not as k8s to add sgx resource via plugin.

agent still need these devices to be mounted

/dev/sgx dir volume mount alone is enough.


[Event Change] Report 7306 - "Get Inbound Source Documents" - OnBeforeWhsePutAwayRequestOnAfterGetRecord

Hi AL-Team,
can you please add set the IncludeSender parameter to Publisher OnBeforeWhsePutAwayRequestOnAfterGetRecord?
// NEW >>>>
// [IntegrationEvent(false, false)]
[IntegrationEvent(true, false)]
// NEW <<<<
local procedure OnBeforeWhsePutAwayRequestOnAfterGetRecord(var PostedWhseReceiptLine: Record "Posted Whse. Receipt Line");
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


disabled prop not works on  Component

react-native, react and native-base version
"native-base": "^2.3.1",
"react": "16.0.0-alpha.12",
"react-native": "0.47.1"
Expected behaviour
When a <ListItem /> Component has a disabled prop with true value, all interactions with this component should be disabled, according with react-native official docs.
Actual behaviour
Even with disabled prop with a true value, the onPress event keep triggering.
Steps to reproduce (code snippet or screenshot)
<ListItem disabled={true} onPress={() => console.log('I'm working')}>
        ...
</ListItem>

Screenshot of emulator/device
N/A
Is the bug present in both ios and android or in any one of them?
Tested only Android
Any other additional info which would help us debug the issue quicker.
N/A

@netojose ListItem internally uses TouchableHighlight for iOS and TouchableNativeFeedback for android, not TouchableWithoutFeedback. You can create your own ListItem for TouchableWithoutFeedback with the same styling though following the customization guidelines http://docs.nativebase.io/Customize.html#custom-component-headref


[polymetis] Logging

Description
Please include a summary of the change and link to an issue this PR fixes. Please also include relevant context. List any downstream components that might be affected by this change.
Fixes # (issue)
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[ ] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[ ] I want a thorough review of the implementation.
[ ] I want a high level review.
[ ] I want a deep design review.

Before and After
If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.
If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.
Testing
Please describe the tests that you ran to verify your changes and how we can reproduce.
Checklist:

[ ] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I have verified that all scripts in tests/scripts runs on hardware.

Codecov Report

Merging #928 (c04c9d2) into main (caaa3e5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   32.19%   32.18%   -0.01%
==========================================
  Files         345      345
  Lines       33901    33901
==========================================
- Hits        10914    10911       -3
- Misses      22987    22990       +3

Impacted Files
Coverage Δ

agents/craftassist/tests/fake_agent.py
72.97% <0.00%> (-0.70%)
:arrow_down:


GSM8KTemplate does not yield a standard template format for 0-shot chain-of-thought prompting.

❗BEFORE YOU BEGIN❗
Are you on discord? 🤗 We'd love to have you asking questions on discord instead: https://discord.com/invite/a3K9c8GRGt
Describe the bug
GSM8KTemplate does not yield a standard template format for 0-shot chain-of-thought prompting of GSM8K, as used across most published benchmarks.
Typically you'd expect something like

Q: Janet’s ducks lay 16 eggs per day. She eats three for breakfast every morning and bakes muffins for her friends every day with four. She sells the remainder at the farmers' market daily for $2 per fresh duck egg. How much in dollars does she make every day at the farmers' market?
A: Let's think step-by-step.

To Reproduce
from deepeval.benchmarks.gsm8k.template import GSM8KTemplate
from deepeval.benchmarks import GSM8K
gsm8k = GSM8K(n_shots=0, enable_cot=True)
test_goldens = gsm8k.load_benchmark_dataset()

GSM8KTemplate.generate_output(train_set=gsm8k.shots_dataset, input=test_goldens[0].input, n_shots=0, enable_cot=True)

Expected behavior
A prompt following the conventional format for chain-of-thought prompting.
Actual behavior
"**Problem**: Janet’s ducks lay 16 eggs per day. She eats three for breakfast every morning and bakes muffins for her friends every day with four. She sells the remainder at the farmers' market daily for $2 per fresh duck egg. How much in dollars does she make every day at the farmers' market?\n**Answer**: \n\nOutput only the numerical answer. No explanation needed."

Desktop (please complete the following information):

OS: macOS
Version 0.21.55 - still present in the latest release

Additional context
Add any other context about the problem here.

Resolved by merging #866, so I'm closing!


Decimal type mismatch error only output in meta node log

Describe the bug
In psql client, it reports channel closed.
Error message/log
Can find this error log in meta node log

Json parse error: rw Decimal's precision is large than doris max decimal len is 12, doris max is 11

To Reproduce
No response
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
dev=> select version();
                                     version
----------------------------------------------------------------------------------
 PostgreSQL 9.5-RisingWave-1.3.0-alpha (5ab1f7a2fb8bf1e0b984598d95b69b50c6410c33)
(1 row)

Additional context
No response

@xxhZs Please take a look

Hello, can you provide the table creation statements for Doris and RW?

Hello, can you provide the decimal data associated with the error?

It happens when the length of decimal in mv is larger then the correspond field in Doris, easy to reproduce.

It happens when the length of decimal in mv is larger then the correspond field in Doris, easy to reproduce.
Thanks！This is because Doris has a decimal precision limit, exceeding which will result in the data insertion failure. Here, we will adopt a more explicit approach to throw this error.


pull request for e2e test at 11/13/2016 08:45:10

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Simply Doesn't Want to Work

Description:
The Mod doesn't seem to want to activate borderless, I tried all settings and it seems that even with the "best" and "borderless" settings, tabbing in and out stutters my screen regardless.

VSync Disabled

Steps to reproduce:
N/A
Versions:

Minecraft Version: 1.16.5
Forge Version: 36.1.24
Mod Version: Latest

Crash report
N/A
Please list other mods that seem to cause the issue.
Using ATM 6 Mod Pack Version 1.6.7
Using OptiFine_1.16.5_HD_U_G7_
Thank you for your reporting!

The problem could be caused by OptiFine. OptiFine HD U G7 is marked compatible with Forge 36.0.42, version 36.1.24 might not be fully compatible.
If OptiFine is not causing this problem, could you upload your game logs? I assume you are using Windows?

The problem could be caused by OptiFine. OptiFine HD U G7 is marked compatible with Forge 36.0.42, version 36.1.24 might not be fully compatible.
If OptiFine is not causing this problem, could you upload your game logs? I assume you are using Windows?

I downloaded and tested OptiFine_1.16.5_HD_U_G8, there seems to be no difference.
Yes, I am using windows. Game logs attached below.
Logs.txt

Sorry for not answering for quite a while now, but I investigated the issue in the meantime. I was basically waiting for Forge to release version 1.17 to recode the entire mod and see in which direction the Forge team is heading.
I also recoded the base version for 1.16. It should run more stable now, the different display modes are now correctly applied. If you want, you can give the latest version another try.

Trying with OptiFine HD U G7 and 1.16.5 I'm also not able to get this to work at all. I've tried every combination of settings I can think of.


Add slot support for function apps

@panchagnula, would love a review from you.
Fixes #6581, #9126

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

@panchagnula, I have updated the PR to add an error message when use webapp's create command. Please have another look if you don't mind :)

Hi @ankitkumarr thanks for implementing this.  I was able to check out the repo and test this out and was able to create a slot.  I was wondering about the ability to deploy using az functionapp to slots.  I believe az webapp has a deployment option (az webapp deployment source config-zip) that has a --slot option.   Are you planning on adding the same for the az functionapp deployment commands?
https://docs.microsoft.com/en-us/cli/azure/webapp/deployment/source?view=azure-cli-latest#az-webapp-deployment-source-config-zip

@bigdatamoore, this PR should have addressed that as well. webapp and functionapp use a lot of the same functionality underneath. I turned slots on for all the functionapp commands that should have it. Let me know if you are unable to use it. Thanks!

@ankitkumarr  I was able to deploy a c# function using the az functionapp deployment source config-zip --slot command.  I tried it with a python function and got the following error:
(venv) PS > az functionapp deployment source config-zip --resource-group myresourcegroup --name myfunction1 --src test-function.zip --slot staging
Getting scm site credentials for zip deployment
Starting zip deployment. This operation can take a while to complete ...
The command failed with an unexpected error. Here is the traceback:

Expecting value: line 1 column 1 (char 0)
Traceback (most recent call last):
  File "C:\Users\240721\source\repos\azure-cli\venv\lib\site-packages\knack\cli.py", line 206, in invoke
    cmd_result = self.invocation.execute(args)
  File "c:\users\240721\source\repos\azure-cli\src\azure-cli-core\azure\cli\core\commands\__init__.py", line 561, in execute
    raise ex
  File "c:\users\240721\source\repos\azure-cli\src\azure-cli-core\azure\cli\core\commands\__init__.py", line 619, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
  File "c:\users\240721\source\repos\azure-cli\src\azure-cli-core\azure\cli\core\commands\__init__.py", line 612, in _run_job
    six.reraise(*sys.exc_info())
  File "C:\Users\240721\source\repos\azure-cli\venv\lib\site-packages\six.py", line 693, in reraise
    raise value
  File "c:\users\240721\source\repos\azure-cli\src\azure-cli-core\azure\cli\core\commands\__init__.py", line 589, in _run_job
    result = cmd_copy(params)
  File "c:\users\240721\source\repos\azure-cli\src\azure-cli-core\azure\cli\core\commands\__init__.py", line 298, in __call__
    return self.handler(*args, **kwargs)
  File "c:\users\240721\source\repos\azure-cli\src\azure-cli-core\azure\cli\core\__init__.py", line 467, in default_command_handler
    return op(**command_args)
  File "c:\users\240721\source\repos\azure-cli\src\command_modules\azure-cli-appservice\azure\cli\command_modules\appservice\custom.py", line 296, in enable_zip_deploy
    authorization, timeout)
  File "c:\users\240721\source\repos\azure-cli\src\command_modules\azure-cli-appservice\azure\cli\command_modules\appservice\custom.py", line 2233, in _check_zip_deployment_status
    res_dict = response.json()
  File "C:\Users\240721\source\repos\azure-cli\venv\lib\site-packages\requests\models.py", line 897, in json
    return complexjson.loads(self.text, **kwargs)
  File "C:\Python36\lib\json\__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "C:\Python36\lib\json\decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "C:\Python36\lib\json\decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

@bigdatamoore, oh are you on a Linux Consumption plan? Slots aren't yet supported for Linux Consumption, neither is the az functionapp deployment source config-zip command yet. I believe we are tracking support of these scenarios.

Ok thanks.  That is what I figured.  Thanks for the update.  I will wait until those are supported. Any idea as to when that could be?

@ankitkumarr I am seeing something weird with the c# function (http trigger).  I tried deploying a new version using config-zip --slot command to a staging slot.  However it appears to be deploying to both the production slot and the staging slot, as both urls are returning the same thing.  I could be doing something wrong.
Steps I followed:

Create a http trigger c# function
deploy the function to a new functionapp
Create a slot using az functionapp deployment slot create
publish the function app, and create a zip file
deploy the function to the functionapp production slot by using az functionapp deployment source config-zip
make a change to the app, publish  a new version and create a new zip file
deploy the modified function to the functionapp app staging slot by using az functionapp deployment source config-zip with the --slot staging option.
You will see that both the production slot and the staging slot have the same code

Hi @ankitkumarr, I took a look at the source code and although I have pretty limited understanding of how this works, I did find a few things that I thought might be causing what I am seeing.  Please correct me if I am off track.
This appears to be where the zip deployment is happening.  I see there is a slot argument which if passed in, will be used to deploy to a slot.
https://github.com/Azure/azure-cli/blob/cbb0c773d681f5f0a779d145793fbfa8d45e7eca/src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/custom.py#L276
However when I searched for where this function is called from, I only found this reference:
https://github.com/Azure/azure-cli/blob/cbb0c773d681f5f0a779d145793fbfa8d45e7eca/src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/custom.py#L2479
I don't see it passing in the slot argument.

@ankitkumarr
Ok nevermind.  I was able to get it working.   Sorry for the false alarm.   The problem I had was that in my staging slot I had the WEBSITE_CONTENTSHARE set to the same value as my production slot.  So when I updated one, it was automatically updating the other as well.
I have confirmed that the CLI is working with slots for C# functions.  I was able to create a slot, deploy to the slot, and then use the CLI to swap the slots.

@bigdatamoore, thanks for reporting this. I will take a look at your issue later today.
As for the actual code, you did find the correct function enable_zip_deploy. But, it is linked directly to the command here - https://github.com/Azure/azure-cli/blob/cbb0c773d681f5f0a779d145793fbfa8d45e7eca/src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/commands.py#L253. That's why you don't see any code references to it.
The reference you linked is actually for a different command az webapp up that uses the function to deploy.
Anyway, I will try and get a repro to see what's going on.

@bigdatamoore, whoops, I missed you comment. Thanks for verifying. Glad you were able to resolve.

@ankitkumarr, can you test out the create slot command and see if it updates the WEBSITE_CONTENTSHARE setting value?  When doing this via the portal, the WEBSITE_CONTENTSHARE is automatically appended with a random string.  However when doing this via the CLI it is copying the same value that is in the production slot.  So that was actually causing the behavior that I was seeing.    Probably you will want to add some random string to the end of the existing value so that you don't have these collisions when using the CLI to create slots.  This may be by design but I am not sure.  Thanks.


[row consumer] Add fetch_first_row

Use to init instead of situation where we have no min_cursor. Means we always need to always have an initial_min_cursor. This will allow us to start from wherever in a table.

#282  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @acco and the rest of your teammates on  Graphite


chore: don't emit disruption events for non-karpenter nodes

Fixes #N/A
Description
Removes eventing for state nodes that don't have NodeClaims (non-Karpenter managed nodes)
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

9 of 9 (100.0%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.009%) to 80.607%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/nodeclaim.go
2
89.13%

Totals

Change from base Build<PHONE_NUMBER>3:
0.009%

Covered Lines:
8388

Relevant Lines:
10406

💛  - Coveralls

Hi @njtran
Do you know if this PR has been packaged into a release yet?
I'm facing the following event in my nodes that Karpenter doesn't manage:
"Cannot disrupt Node: state node doesn't contain both a node and a nodeclaim"
I think it's related to what this PR changes.

Hi have the same issue with nodes not being managed by Karpenter. Would like to know which release this lands in.

Looks like 1.1.0 has it.


Proof of concept: Custom functions

I got the software equivalent of an earworm and decided to turn it into a proof of concept.
👀 I'm seeking feedback of any kind, which could include "this isn't something Hugo is interested in"; I'll be happy to turn this sorry state of affairs into quality, tested code, or to close this line of thinking down.
What is it?
Code similar to this would allow Hugo users to write and use custom Typescript (or Javascript) functions for use inside their templates.
{{ $today := (now.Format "Mon January 2" ) }}

{{ printf $today }} → Mon June 12            # Standard Hugo
{{ fn "enc.Rot13" $today ) }} → Zba Whar 12  # New!

See the external.md at the top of the PR for more detail.
Can I test it out?
Yes!

Build this branch
Clone my demo site
Edit layouts/index.html and functions/*.ts
Run ../path/to/built/hugo in the site root
Check out public/index.html to see the output

Why is this useful?
A lot of Hugo's Github Issues seem to be about changing or adding new functions to Hugo. Though contributing to Hugo's codebase is an admirable, it's a long-term solution to these requests and likely isn't available option to many.
Writing and sharing function files, storing them in the site files (eg. in functions/*.ts), is a cross-platform, simple, accessible way to be able to write and share helper functions.
Some important benefits:

The JS runtime used is totally sandboxed (no access to the filesystem, web or similar), so malicious custom code can't do harm.

I'd like to be able to use a limited fetch, but there are lots of new challenges there.

Unlike using something like Go plugin files, this TS/JS is platform agnostic (so it can be committed to source code along side the site files)
Other JS modules should be import-able*, so custom code writers can build on the shoulders of the JS community. (*Caveat: I haven't tried this, it'd likely be a little complex right now)
JS execution happens entirely in Go (no v8 here!) and is time-limited. It'll be slower than Go, but not "slow".

Why this PR isn't at all ready
I've thrown this together to understand if it's interesting to the community. There are lots of sharp edges. Some of the ones I've found/considered but not addressed:

The error reporting if you've written bad TS/JS is plain bad or absent.

Good dev tooling here will be crucial, or making these function files will be very hard

Go types are auto-cast to Javascript ones, which mostly works (with strings, numbers, structs, even times—though timezone data is lost) but there are undoubtedly arguments people could pass to a JS function that'd be super confusing to interact with.
The function call is a little clunky ({{ fn "filename.FunctionName" "args" }} instead of {{ filename.FunctionName "args" }}), as Hugo seems to require namespaced functions to be methods in Go and, because these are dynamically generated from JS, I can't do that (without substantial codechange)

This also means that the code I wrote to extract exported constants of the name <FunctionName>Examples, expecting it to be in the [][2]string format used for other function examples, is useless right now.

While Goja (the Javascript-VM-in-Go library used here) seems stable as an open source project, go-typescript seems less well maintained.
I'm re-compiling the JS every time it's called. I can definitely optimise this.

Thanks for reading this far! Let me know what you think.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

You may want to have a look at https://github.com/bep/gojap
Creating a new runtime for each function is bound to be very slow, memory hungry.
I like the idea of this (given the above, I have been thinking about it ...), but there are lots of caveats, and I suspect a proof of concept would have a better chance of success if it tested out the hard parts first, mainly:

In templates, It's very rare that I have simple problems (addition, date formatting ...) that I think "oh, I wish I could do this in JavaScript".
So for this to be useful, I suspect many people would expect to be able to pass the Hugo Page, Site etc. down to the JS runtime. That brings up several issues, but the main part is to get it working.

Thank you for the rapid reply @bep! For me this was indeed hard thing #1 ("is it at all possible"), but you're absolutely right, passing .Site or similar large objects over is definitely a hard thing worth testing! I can now build some of the trivial things I'd like to have (for example: custom calendar date formatting), but nothing more complex.
The two things I'll work on next:

Making use of gojap (it looks great!) to reduce the number of runtimes (perhaps one per file, or one total — I'll try to measure resource usage)
Getting a demo of what'd be needed for passing something more substantial over. Do you have an example use-case in mind? (I was considering doing something like implementing a MakeRSS function — would this cover the challenges you see?)

That challenge I faced of all function calls needing to be Go methods; do you think this is worth addressing in a proof of concept? I'm not particularly familiar with the Hugo codebase, so I'd be very willing to leave it to a later round of thought (if we get there).

That challenge I faced of all function calls needing to be Go methods; do you think this is worth addressing in a proof of concept?

You don't want to tackle all problems -- but what I would have wanted to see is something like (pseudo code, I just made up these, so they're not particulary clever):
function getLastMod(pages) {
   // return the newest .Date from the page list given
}

function filter(pages, predicate) {
  // return the pages matching predicate.
}


MacOS v2.0.1 Seg Fault

Getting this a few minutes into phase 2 on a Mac mini M1 with 16GB.

Can you please provide a full log?
Crashing a little bit into phase 2 is typical of running out of required temp 1 disk space


Fix issue 7102: std.numeric.gcd overload that works with non-builtin types

This PR does the following:

Add sig constraints to the current version of std.numeric.gcd so that it won't pick up types that it actually can't support. The current implementation is dependent on builtin types and fails in ugly ways with non-builtin types (including BigInt).
Add a generic overload of gcd that implements both Euclid's algorithm and Stein's algorithm in a minimalistic way of doing the most while requiring the least.  While I realize that this involves a lot of copy-pasta, I couldn't find a nice way to do it without potentially breaking existing code or turning the code into an unmaintainable mess of static ifs, due to the original overload being a rat's nest of dependencies on properties of builtin integer types and other implementation details.  Also, another reason I did a separate overload is because the current algorithms are suboptimal with BigInt, and an optimal BigInt GCD algorithm is beyond my ability to implement. But for the sake of not letting the perfect be the enemy of the good, this overload is intended to be a temporary stop-gap measure to at least allow a working implementation of BigInt GCD until a better-optimized version is implemented -- it is better than the current ludicrous situation where Phobos doesn't come with a GCD algorithm for BigInt.
Improve the gcd documentation with standard ddoc sections.

I don't see any obvious code problems, but I'm not familiar with these algorithms so I'll refrain from pulling.