Protocol ERROR

Describe the bug
reported in https://github.com/Shopify/themekit/issues/631
REPORT
I'm having this issue all of a sudden. I've been working for a week with my theme. All of a sudden tonight while using theme watch I refreshed and suddenly theme when nuts. Now my theme is borked, and totally using wrong theme settings. I can't upload.

I've tried creating a new theme entirely with theme deploy. No dice.
I've tried deleting all the theme files on the server, but no go.

I'm not going to lie I'm kind of freaking out. I even rolled back to a few version of my theme in git and no dice. Any ideas?
I adjusted the timeout to 10min. Still the same errors. I just tried it on different ISPs. I don't have any proxy installed. Additionally the files it complains about if I upload them with theme deploy on just the individual file it's fine. But I can't upload or fix my theme. Something about assets.json seems bad on shopify's servers.

Here you can take a look. My theme is totally borked. It's using the wrong style, colors, and has a whole bunch of modules I normally don't have.
https://0gu1633t8wuopedl-14175736.shopifypreview.com/
When I go into the shopify admin it claims some file I've never edited is broken. (I checked git history)

Thanks for any help!
FOLLOW UP
I've restarted.
Tried an entirely different computer with a new checked out version of my theme @tanema
The issues started around 12:30am at Shopify. They aren't fixed still. It's def on Shopify's servers as the same thing is happening on a new computer with a brand new checked out copy.
I consider myself a decent developer, and have no idea hoaw to proceed. I even tried looking for the assets.json file to delete.
Any of those protocol error files above if I manually deploy them it works fine deploy assets/cervical-leadin-page-6.jpg works. So it's not the file
cc @ckizer

I have tracked this in shopify logs and see successful requests for these assets. I have had a look around and have seen this in relation to working within docker. @ckizer can you pleast tell me what version of themekit you are running, what OS you are running and what editor you are using?

I don't have docker installed right now.

Visual Studio Code

ThemeKit 1.0.1 darwin/amd64

No Docker installed

MacOS Catalina Beta (it's been working with the themekit for several weeks without any issues). The issue started at about 11:33am last night when I went to refresh a preview page link. Not even when I was uploading files. I restarted thinking maybe the theme command line tool was broken.

If it's useful, I invited you to the github repository of the theme. You can look back at around 11:30PM PST and see the commits I did before the error started happening.
https://github.com/ckizer/lofty-sleep-theme

@tanema After a restart entirely new errors:
[development] 96|234 [===============================>----------------------------------------------]  41 %
[development] (assets/application.sass) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (templates/page.contact.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (templates/customers/addresses.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (sections/home-featured-video.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (snippets/article-list-item.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (sections/pxs-map.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (assets/icon-facebook.svg) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (assets/icon-quote.svg) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (templates/product.cervical.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (assets/Sailec-Bold.woff2) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (sections/home-image-with-text.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (assets/application.scss) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (assets/bg-sleep-happy.jpg) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (snippets/navlist.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (sections/page-collections-list.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (snippets/meganav.liquid) Exceeded 2 calls per second for api client. Reduce request rates to resume uninterrupted service.
[development] (assets/hero-homepage.jpg) Exceeded 2 calls

Is this because I was using theme watch for a good 30 hours while coding?

Thanks, no that is my fault, I was uploading a test theme using your private app so that I could test your scenario however I am not having problems. I am still investigating. You should be able to upload smoothly again in a few moments

It always seems to get about 30% done, then hang. I set the timeout to 2000s thinking that might fix it. I've have pretty fast upstream so I don't think it's actually timing out. Files are max about 3.2MB
[development] 79|234 [=========================>----------------------------------------------------]  34 %
[development] (assets/thin-leadin-page-8.jpg) Put https://cradle-me.myshopify.com/admin/themes/74945298535/assets.json: stream error: stream ID 129; PROTOCOL_ERROR

Also as a note this should not have anything to do with the changes you have made to your theme but it does seem like something is happening with your connection.
Can you follow the debugging guide here: https://github.com/Shopify/themekit/blob/master/.github/CONTRIBUTING.md#debugging-requests and send me the dump file afterward<EMAIL_ADDRESS>Hopefully I can gain some more insight into what is happening with your connection.

Okay @ckizer I have a suspicion and have deployed an update with a patch in it. Please try it out by running theme update --version=v1.0.2-issue659

@tanema
@tanema I'm running a deploy with the new version right now. 🤞🏻. Writing up an email with the themekit_dump file right now. 22MB
Uploading themekit_dump.zip…
It got about 40% done then these errors
➜  lofty-sleep-theme git:(master) ✗ theme deploy
[development] 97|234 [===============================>----------------------------------------------]  41 %
[development] (assets/thin-leadin-page-5.jpg) Put https://cradle-me.myshopify.com/admin/themes/74945298535/assets.json: stream error: stream ID 187; PROTOCOL_ERROR
[development] (assets/slider-boomerang-1.jpg) received a malformed response from shopify, this usually indicates a problem with your connection
[development] (assets/thin-leadin-page-2.jpg) Put https://cradle-me.myshopify.com/admin/themes/74945298535/assets.json: stream error: stream ID 193; PROTOCOL_ERROR
[development] (assets/thin-leadin-page-6.jpg) received a malformed response from shopify, this usually indicates a problem with your connection
[development] (assets/about-quality.jpg) Put https://cradle-me.myshopify.com/admin/themes/74945298535/assets.json: stream error: stream ID 191; PROTOCOL_ERROR

Here's the dump file prior to upgrading to v1.0.2
https://www.dropbox.com/s/eq7a9w4f01dlsrn/themekit_dump.zip?dl=0

After updating to v1.0.2 It still reports as ThemeKit 1.0.1 darwin/amd64
I assume it updated fine though. No issues were reported with the update.

Interesting enough if I go to index.liquid and add some html test change and run theme watch it doesn't seem to notice that I made the change anymore.

Yeah, that version is expected. I am not sure why it would not pick up changes since that part has not changed since 1.0.1

New error when running deploy
New schema is incompatible with the current setting value. Invalid type value for block 'footer-1'. Type must be defined in schema.New schema is incompatible with the current setting value. Invalid type value for block 'footer-3'. Type must be defined in schema.New sch

Those are validation errors coming from shopify and they are good things to see. That means that your themekit is working again but your configuration may have been corrupted or is out of date.

Tim:
That's good. I can just delete these?:
settings_data.json
settings_schema.json
On Wed, Aug 7, 2019 at 2:11 PM Tim Anema<EMAIL_ADDRESS>wrote:

Those are validation errors coming from shopify and they are good things
to see. That means that your themekit is working again but your
configuration may have been corrupted or is out of date.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/themekit/issues/659?email_source=notifications&email_token=AABOZ6X4QA4S7VAR7YO6ZZTQDM27RA5CNFSM4IKDVOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZXCCI#issuecomment-519270665,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOZ6UVNIMGPBTTCOKHG43QDM27RANCNFSM4IKDVOYQ
.

After deleting those it seems to get stuck again on random files:
[development] 96|389
[==================>-----------------------------------------------------------]
25 %
[development] (assets/pillow-8542 2.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 153; PROTOCOL_ERROR
[development] (assets/cervical-leadin-page-7.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 155; PROTOCOL_ERROR
[development] (assets/about-lofty.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 165; PROTOCOL_ERROR
[development] 76|389
[==============>---------------------------------------------------------------]
20 %
[development] (assets/pillow-8542 2.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 153; PROTOCOL_ERROR
[development] (assets/cervical-leadin-page-7.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 155; PROTOCOL_ERROR
[development] (assets/about-lofty.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 165; PROTOCOL_ERROR
On Wed, Aug 7, 2019 at 2:12 PM Court Kizer<EMAIL_ADDRESS>wrote:

Tim:
That's good. I can just delete these?:
settings_data.json
settings_schema.json
On Wed, Aug 7, 2019 at 2:11 PM Tim Anema<EMAIL_ADDRESS>wrote:

Those are validation errors coming from shopify and they are good things
to see. That means that your themekit is working again but your
configuration may have been corrupted or is out of date.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/themekit/issues/659?email_source=notifications&email_token=AABOZ6X4QA4S7VAR7YO6ZZTQDM27RA5CNFSM4IKDVOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZXCCI#issuecomment-519270665,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOZ6UVNIMGPBTTCOKHG43QDM27RANCNFSM4IKDVOYQ
.

Interesting enough now it's this:
https://y0mt79xea725i4qt-14175736.shopifypreview.com
Which is an entirely different theme (My active theme in production)
On Wed, Aug 7, 2019 at 2:15 PM Court Kizer<EMAIL_ADDRESS>wrote:

After deleting those it seems to get stuck again on random files:
[development] 96|389
[==================>-----------------------------------------------------------]
25 %
[development] (assets/pillow-8542 2.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 153; PROTOCOL_ERROR
[development] (assets/cervical-leadin-page-7.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 155; PROTOCOL_ERROR
[development] (assets/about-lofty.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 165; PROTOCOL_ERROR
[development] 76|389
[==============>---------------------------------------------------------------]
20 %
[development] (assets/pillow-8542 2.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 153; PROTOCOL_ERROR
[development] (assets/cervical-leadin-page-7.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 155; PROTOCOL_ERROR
[development] (assets/about-lofty.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74440605799/assets.json:
stream error: stream ID 165; PROTOCOL_ERROR
On Wed, Aug 7, 2019 at 2:12 PM Court Kizer<EMAIL_ADDRESS>wrote:

Tim:
That's good. I can just delete these?:
settings_data.json
settings_schema.json
On Wed, Aug 7, 2019 at 2:11 PM Tim Anema<EMAIL_ADDRESS>wrote:

Those are validation errors coming from shopify and they are good things
to see. That means that your themekit is working again but your
configuration may have been corrupted or is out of date.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/themekit/issues/659?email_source=notifications&email_token=AABOZ6X4QA4S7VAR7YO6ZZTQDM27RA5CNFSM4IKDVOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZXCCI#issuecomment-519270665,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOZ6UVNIMGPBTTCOKHG43QDM27RANCNFSM4IKDVOYQ
.

Can you also try a new theme. settings_data.json and settings_schema.json are important files but you should rarely have to touch them. If you deploy and they are not there, themekit will try to delete them from your store which wont work. If you dont want those files around you should add them to your ignores list in your config.

I tried deploying each part of the theme manually to see if I could
determine what it hangs on. When I try to upload folders it seems to work.
When I try to upload an individual file like config.yml it just stays at
zero %
➜  ~ cd /Users/ckizer/Desktop/Pixel\ Union\ Pacific
Theme/lofty-sleep-theme
➜  lofty-sleep-theme git:(stash) theme deploy /templates
[development] 28|28 [===================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /snippets
[development] 42|42 [===================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /sections
[development] 26|26 [===================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy README.md
[development] 0|1565212991
[------------------------------------------------------------------------------]
0 %
^C
➜  lofty-sleep-theme git:(stash) theme deploy README.md
[development] 0|1565213049
[------------------------------------------------------------------------------]
0 %
^C
➜  lofty-sleep-theme git:(stash) theme deploy /locales
[development] 1|1
[==============================================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /layout
[development] 1|1
[==============================================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /config
[development] 2|2
[==============================================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy config.yml
[development] 0|1565213140
[------------------------------------------------------------------------------]
0 %
On Wed, Aug 7, 2019 at 2:23 PM Tim Anema<EMAIL_ADDRESS>wrote:

Can you also try a new theme. settings_data.json and settings_schema.json
are important files but you should rarely have to touch them. If you deploy
and they are not there, themekit will try to delete them from your store
which wont work. If you dont want those files around you should add them to
your ignores list in your config.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/themekit/issues/659?email_source=notifications&email_token=AABOZ6WRVDQCG7IKJKCSGGLQDM4MTA5CNFSM4IKDVOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZX56A#issuecomment-519274232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOZ6RBSS23FED6VKTVW33QDM4MTANCNFSM4IKDVOYQ
.

If I try theme deploy /assets
it almost finishes but not quite
[development] 128|129
[============================================================================>-]
99 %
[development] (assets/cervical-leadin-page-9.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74945298535/assets.json:
stream error: stream ID 75; PROTOCOL_ERROR
[development] 128|129
[============================================================================>-]
99 %
[development] (assets/cervical-leadin-page-9.jpg) Put
https://cradle-me.myshopify.com/admin/themes/74945298535/assets.json:
stream error: stream ID 75; PROTOCOL_ERROR
On Wed, Aug 7, 2019 at 2:27 PM Court Kizer<EMAIL_ADDRESS>wrote:

I tried deploying each part of the theme manually to see if I could
determine what it hangs on. When I try to upload folders it seems to work.
When I try to upload an individual file like config.yml it just stays at
zero %
➜  ~ cd /Users/ckizer/Desktop/Pixel\ Union\ Pacific
Theme/lofty-sleep-theme
➜  lofty-sleep-theme git:(stash) theme deploy /templates
[development] 28|28 [===================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /snippets
[development] 42|42 [===================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /sections
[development] 26|26 [===================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy README.md
[development] 0|1565212991
[------------------------------------------------------------------------------]
0 %
^C
➜  lofty-sleep-theme git:(stash) theme deploy README.md
[development] 0|1565213049
[------------------------------------------------------------------------------]
0 %
^C
➜  lofty-sleep-theme git:(stash) theme deploy /locales
[development] 1|1
[==============================================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /layout
[development] 1|1
[==============================================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy /config
[development] 2|2
[==============================================================================]
100 %
➜  lofty-sleep-theme git:(stash) theme deploy config.yml
[development] 0|1565213140
[------------------------------------------------------------------------------]
0 %
On Wed, Aug 7, 2019 at 2:23 PM Tim Anema<EMAIL_ADDRESS>wrote:

Can you also try a new theme. settings_data.json and settings_schema.json
are important files but you should rarely have to touch them. If you deploy
and they are not there, themekit will try to delete them from your store
which wont work. If you dont want those files around you should add them to
your ignores list in your config.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Shopify/themekit/issues/659?email_source=notifications&email_token=AABOZ6WRVDQCG7IKJKCSGGLQDM4MTA5CNFSM4IKDVOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZX56A#issuecomment-519274232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABOZ6RBSS23FED6VKTVW33QDM4MTANCNFSM4IKDVOYQ
.

In an entirely new folder, with a new theme from Pacific Union I did the following:
theme new -p=*** -s=cradle-me.myshopify.com --name="Test Theme"
It completed successfully.

If I do my deploy one folder at a time like this
theme deploy /snippets
theme deploy /templates
theme deploy /sections
theme deploy /locales
theme deploy /layout
theme deploy /assets

No issues. (it does take an exceptionally long time on /assets)
If I do theme deploy it seems to start having errors when it gets to the /assets folder.
After a manual deploy of each folder separately it seems like theme watch is able to keep up as long as I don't swap out the entire /assets folder at once.

@tanema I think I know what's causing it. Animated gifs. Even if they are only 24k, it seems to die whenever there is an animated gif added to the asset folder. Even with timeout of 3min.
Something about the gif file format?
➜  new-theme git:(master) ✗ theme deploy /assets/mosaic-animated-pillow.gif
[development] 0|1 [------------------------------------------------------------------------------]  0 %
^C

A small bit of information is that it seems like it only happens on large items that are 2mb or larger.

Resurecting this issue, because I believe this might have been an issue on past Go versions on how they handle http2. Does this problem still arise?


0.3.7

Please Update Gem Version to 0.3.7 · Issue #98 · mcasimir/devise-i18n-views

Thank you very much.


[Remix] Ewasm Plugin

Ewasm Plugin
(subject to change)

See https://github.com/ethberlin-hackathon/ETHBerlin-Teambuilding/blob/master/RemixHackathon.md for more info about the Remix hackathon. Please be sure to read it before starting.
Some infos about Remix: https://remix.readthedocs.io/en/latest/
Online version: http://remix.ethereum.org

We've been releasing an API (available in http://remix-alpha.ethereum.org) which allows developing plugin for Remix.
(See https://github.com/ethereum/remix/blob/master/docs/remix_plugin.md and https://github.com/ethereum/remix/blob/master/docs/remix_plugin_api.md)
Checkout https://remix-alpha.ethereum.org / settings tab / Oraclize for a live example.
This issue is specifically about developing a Ewasm Plugin.
Proposal for implementation
(You don't need to strictly follow this proposal, we would like to have your feedback)

compile https://webassembly.studio/ from * to wat (easy way to inject the wat in Remix?)
from Remix deploy to ewasm test net using the Run tab or directly from the plugin
call the fallback function with raw data from Run tab

Team
We are the team behind Remix IDE and related libraries, using this hackathon as a kickstart for the Remix API.
We've setup an extended team for helping you during this event

Remix team - @ninabreznik @serapath @ryestew @yann300 @iurimatias
Go team - @ligi @holiman
Solidity team - @leonardoalt @chriseth
C++, ewasm - @chfast @axic

Beside normal funding, we will at the end of the event select 4 teams that will receive sponsorship from the Ethereum Foundation.
Be sure to contact us at any time online or grab us directly at the event.
Skills wanted
JavaScript / Ethereum
Communication
We will be around giving advice and helping if needed.
And in any case just drop your thoughts there ;)
https://gitter.im/ethereum/remix-dev-plugin
How to get started:

Clone https://github.com/yann300/remix-plugin , go to src folder
Serve the folder through local web server
Go to remix-alpha.ethereum.org
Settings tab / Plugin section
Input Description:

{
“title”: “<name of plugin>”,
“url”: “http://<IP_ADDRESS>:<port>”
}

Load  and Start using it.

This issue has been moved there: https://github.com/ethberlin-hackathon/ETHBerlin-Teambuilding/issues/17


Exclude java/rmi/Naming tests for macx64

Exclude java/rmi/Naming/legalRegistryNames/LegalRegistryNames and java/rmi/Naming/DefaultRegistryPort tests for versions 8/11/17/21.

related: https://github.ibm.com/runtimes/backlog/issues/867

Grinder tests:
39061 - jdk8
39062 - jdk11
39063 - jdk17

Do we have this test in 22 and 23? If so, we need to exclude it

Do we have this test in 22 and 23? If so, we need to exclude it

yes we do have these tests for 22 and will exclude these

Please cherry pick this into https://github.com/adoptium/aqa-tests/tree/v1.0.1-release. Thanks


refactor CI testing of dart-services

refactor CI testing of dart-services

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

With this PR, both beta and main are failing, but they're both failing the same way (due to https://github.com/dart-lang/dart-pad/issues/2718).
We now run build-storage-artifacts nightly in order to find regressions sooner.
We're working around an issue with the flutter sdk's version file not being created for sdks on the main branch.
In addition, it doesn't look like subosito/flutter-action is happy with specifying the main branch (we use master instead).

beta is fixed now, and main is past the issue with the moved flutter framework dill file.
master is now failing on a calls to ui.webOnlyInitializePlatform() - it looks like that's been removed (and perhaps is now a call to ui_web.bootstrapEngine()?). In any case, I think what's here is now worth review - it includes several fixes. We can work on additional fixes to the main channel in future PRs.

Note that there is a test failure for main related to firebase. This is worth landing irrespective.


Revert EnvyControl changes

I'd like to remove envycontrol due to the little bug when connecting HDMI while using wayland (GNOME).
I've uninstalled it while in hybrid mode, but it seems that wayland still crashes when HDMI is connected.
How can I solve this issue?

It's caused by Nvidia drivers, it also happens to me.
See relevant GNOME bug report:
https://gitlab.gnome.org/GNOME/mutter/-/issues/1891
El mié, 23 de feb. de 2022 07:52, FPuoti255 @.***>
escribió:

I'd like to remove envycontrol due to the little bug when connecting HDMI
while using wayland (GNOME).
I've uninstalled it while in hybrid mode, but it seems that wayland still
crashes when HDMI is connected.
How can I solve this issue?
—
Reply to this email directly, view it on GitHub
https://github.com/geminis3/envycontrol/issues/24, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALY7IYMGL7U7C3URXJ7VUDLU4TKB7ANCNFSM5PEINDOQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It is not true, because now I'm using the nvidia driver 510, not the 470, and this problem has been solved.
I'm using endeavourOS and after a fresh install wayland does not crash when plugging the HDMI in


Adopt toolbarSep as a valid (legacy) alias. Fixes #1323

Hoist P/R Checklist
Review and check off the below. Items that do not apply should be checked to indicate they have been considered. If unclear if a step is relevant, please leave unchecked and note in comments.

[x] Up to date with develop branch as of last change.
[x] Ready for review (or add wip label).
[x] Added CHANGELOG entry (or N/A)
[x] Checked for breaking changes (add breaking-change label + CHANGELOG if so, or N/A)
[x] Updated doc comments / prop-types (or N/A)
[x] Reviewed and tested on Mobile (or N/A)
[x] Created Toolbox branch / PR (link provided here, or N/A)

Pull request reviewers: when merging this P/R, please consider using a squash commit to collapse multiple intermediate commits into a single commit representing the overall feature change. This helps keep the commit log clean and easy to scan across releases.

We have more important things to do. :-)

Agreed 💯


Explicit limit and offset for execution calls

Due to changes in api validation, we're now required to clearly state limit and offset.

Actually, I don't know when we made this change and there's surely better ways to get around it, but at that point, I just want it gone.


Can I assign IPAMBlocks for special nodes manually?

I want to assign IPAMBlocks for some nodes manually in my cluster which is a KubeEdge cluster. A KubeEdge cluster normally have a lot of edge nodes on which calico cannot work.
After reading calico's source code, it seems this method EnsureBlock can do the job.
I just have some questions:

Can I assign IPAMBlocks manually? I don't want to make calico disfunction.
What is the proper way to reclaim a block( I used kubectl delete, but it seems this is not right way)?
To call EnsureBlock, an  ipam.HostReservedAttr argument is needed.

	rsvdAttrWindows := &ipam.HostReservedAttr{
		StartOfBlock: 0,
		EndOfBlock:   31,
		Handle:       "edge",
		Note:         "edge host rsvd",
	}

I want to know what are the valid values for Handle, StartOfBlock and EndOfBlock? Should handle be unique for each assign?
4. Since calico cannot work on those nodes, I have to assign IP myself. Do I have to manage Unallocated and Allocations fields of IPAMBlocks of those nodes?
Thanks in advance.

The IPAMBlock API isn't really intended to be used directly, but obviously with some care you should be able to do it.
Have you looked at simply assigning IP pools to those nodes? The IPPool API includes a node selector that would allow you to allocate certain ranges of IPs to certain nodes - this is the intended way to satisfy your use-case.

Do I have to manage Unallocated and Allocations fields of IPAMBlocks of those nodes?

How do you plan to allocate IPs from these blocks? Would these nodes be using the Calico CNI plugin?

Would these nodes be using the Calico CNI plugin?

@caseydavenport No, calico-node won't run on edge nodes, cni plugins will do the assign IP to pods.  I just need calico to assign IPAMBlock for edge nodes.

Have you looked at simply assigning IP pools to those nodes?
As I know to assign IPs to pods, an calico-node must be involved, but in my scenario, edge nodes won't have calico-nodes running.

I'm curious why you need IPAM blocks on those nodes if Calico won't be running on them at all?

I'm curious why you need IPAM blocks on those nodes if Calico won't be running on them at all?

In fact I implemented a semi-CNI plugin which runs on those edge nodes, previously I choosed to assign PodCIDR for each node , but it requires another CIDR to keep calico safe. It worked, but I just wonder if can use calico client to ask calico to assign IPAMBlock for those nodes.
But as you replied in another issue, the IPAMBlock is internal resource, maybe I should leave it alone.
Thanks for your help.


Caching a works stats results exceeds GA daily quota

When running the rake task to cache user statics, we exceed our quote for Google Analytics.
RAILS_ENV=production bundle exec rake scholarsphere:stats:user_stats
Results in:
2017-05-18 10:54:23 -0400 (27483) Sufia::UserStatImporter: Last exception {"errors"=>[{"domain"=>"global", "reason"=>"dailyLimitExceeded", "message"
=>"Quota Error: profileId ga:74306755 has exceeded the daily request limit."}], "code"=>403, "message"=>"Quota Error: profileId ga:74306755 has exce
eded the daily request limit."}:
{"error":{"errors":[{"domain":"global","reason":"dailyLimitExceeded","message":"Quota Error: profileId ga:74306755 has exceeded the daily request li
mit."}],"code":403,"message":"Quota Error: profileId ga:74306755 has exceeded the daily request limit."}}
rake aborted!

Need migrate the cached analytics from the old system.  We need to migrate and move the items to the Work.
Get the old data into the table and see if this fixes the issue.
GenercFile Analytic becomes and GenericWork analytic for page view and download.


router: Retain trailing slashes in paths

This addresses client-side part of #2154 leaving path matching trailing slash insensitive (to be compatible with current behavior). For example /*path/ would still match both foo and foo/. But when clicking on a link foo/, trailing slash would be retained.
I think it's sensible to keep matching compatible until server-side for this is figured out.
Since path resolution implementation in router is copied from solidjs router and that one retains trailing slashes, I just fixed regexp recreations in rust code to fully match ones from solidjs router:
https://github.com/solidjs/solid-router/blob/main/src/utils.ts#L5:
const trimPathRegex = /^\/+|(\/)\/+$/g;
//
export function normalizePath(path: string, omitSlash: boolean = false) {
  const s = path.replace(trimPathRegex, "$1");
  //
}

(note that trailing slash is retained (match group $1) but excessive trailing slashes are trimmed)
https://github.com/solidjs/solid-router/blob/main/src/utils.ts#L37:
export function joinPaths(from: string, to: string): string {
  return normalizePath(from).replace(/\/*(\*.*)?$/g, "") + normalizePath(to);
}

(matches wildcard pattern optionally from right and removes it along with all trailing slashes in from path)

Testing this locally, with:
    let paths = generate_route_list(leptos_app::App);
    dbg!(&paths);
    cfg.leptos_routes(options.clone(), paths, leptos_app::App);
    cfg.app_data(Data::new(options));

I still see routes with their trailing slashes trimmed.  I bet this is leptos-actix.  I'm forking this branch and adding on some changes to leptos-actix as well to confirm.  🤞

@NfNitLoop I think that's expected, try removing this line: https://github.com/leptos-rs/leptos/pull/2163/files#diff-31f96b333e0c4d9391387d676c81a652b1a975d984ee51b3e2cbd1d4ecf8de8cR641

try removing this line

That did the trick! I think we should not trim there, because that path gets returned by leptos_router::generate_route_list_inner() to the integrations.  Without the trailing / you can't know the user's intent.
The good news is that after removing that line, the leptos-actix integration does the "right thing" (IMO) and also keeps the trailing slash.  I wrote some unit tests to show this behavior at the two layers it passes through:
https://github.com/skirsdeda/leptos/compare/trailing_slashes...NfNitLoop:leptos:trailing_slashes?expand=1

leaving path matching trailing slash insensitive

This has an unfortunate side-effect.  Now with <Route path="/foo/">,

/foo on the server gives a 404.
/foo/ on the server works.
After hydration, /foo on the client does not give a 404. 🤔

IMO you really want your client and server behavior to match exactly or you'll end up with a lot of headaches.
I'm going to continue learning the codebase and see how I can make them align.  May also play around w/ some ideas in #2154 on top of this branch. 😊

Closing this in favor of #2172.

Thanks for this work, though!  It was a good start for building the full feature, and a primer for me for diving into the Leptos codebase!


tridentctl not loading the kube context

Describe the bug
A clear and concise description of what the bug is.
Environment
Provide accurate information about the environment to help us reproduce the issue.

Trident version: 20.01.1
Trident installation flags used: -d -n trident
Container runtime: gitlab-runner on openshift
Kubernetes version: v1.16.2
Kubernetes orchestrator: [e.g. OpenShift v4.3.5
Kubernetes enabled feature gates: none
OS: RHEL 8.1
NetApp backend types: ONTAP
Other:

To Reproduce
Run tridentctl in a gitlab-runner
Expected behavior
Installation to use the context from oc or kubectl
Additional context
Output from gitlab-runner
 $ oc project trident
 Now using project "trident" on server "https://api.openshift.company.com:6443".
 $ kubectl config get-contexts
 CURRENT   NAME                                         CLUSTER                   AUTHINFO                             NAMESPACE
           default/api-openshift-company-com:6443/kube:admin   api-openshift-company-com:6443   kube:admin/api-openshift-company-com:6443   default
 *         trident/api-openshift-company-com:6443/kube:admin   api-openshift-company-com:6443   kube:admin/api-openshift-company-com:6443   trident
 $ oc config get-contexts
 CURRENT   NAME                                         CLUSTER                   AUTHINFO                             NAMESPACE
           default/api-openshift-company-com:6443/kube:admin   api-openshift-company-com:6443   kube:admin/api-openshift-company-com:6443   default
 *         trident/api-openshift-company-com:6443/kube:admin   api-openshift-company-com:6443   kube:admin/api-openshift-company-com:6443   trident

 $ tridentctl install -d -n trident
 level=debug msg="Initialized logging." logLevel=debug
 level=debug msg="Trident image: netapp/trident:20.01.1"
 level=fatal msg="Install pre-checks failed; could not initialize Kubernetes client; unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined"

It seems that this has happened before: https://github.com/NetApp/trident/issues/202
--use-cluster=false isn't working either.

Prior to invoking the Trident installer the KUBECONFIG env variable needs to be set. If you can do this it should resolve your issue.
FYI, we are moving to using an Operator to handle Trident installs and upgrades in future Trident releases.

Closing this issue as a response wasn't received after providing a solution to the OP.


How to get video feature

Thanks for your nice work!
I'd like to train FACT on other dataset. Please tell me how to get the video feature for training!

Hi,
Thanks for your interest. We use I3D-Resnet model to compute features for EgoProceL, which has similar performance as I3D and avoids computing optical flows. You can use the extract_from_frame.py or extract_from_video.py from this repo. It is a fork of the original paper code. It computes framewise features via sliding window.

@ZijiaLewisLu Thanks for your reply!


Capping API usage in case of Speech to Text service (com.google.cloud.speech.v1)

Hi,
I am trying to put an easy mechanism (if it exists on client side, better than a second server) to limit API calls on each client daily.
Other Google Cloud services seem to offer this option**. I searched a little in API, I am trying to implement services no top of the nice demo app here
I tried including Firebase Firestores to make a counter on API calls for users, but unfortunately apparently Firestore does not go well with Speech-to-Text in Android, both depending on protobuf java and protofuf javalite which present duplicate dependencies, so I give up Firestore option at all.
I admit, I am taking it step by step as I am not keen Android developer.
Thanks !
**According to documentation:

To identify a user, use the quotaUser=userID parameter. This value is for short term quota enforcement only, so you don't need to use a real user ID. You can choose any arbitrary string under forty characters long that uniquely identifies a user.
The quotaUser parameter is only used for capping requests per user per second. If you don't send the quotaUser parameter, then all calls are attributed to your server machines, in which case calls can't be capped by user.

I managed to use firebase-realtime-database, it's great and easy. Woohoo, not sure it's the best since current needs is just authentication and this API calls counter.
So firebase-realtime-database works well along with speech-to-text dependency, not like Firestore.


Validate AppData file failed on Flathub

<caption> cannot end in '.' in app's metainfo
flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml
 in dir /srv/buildbot/worker/build-x86_64-5/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --env=G_DEBUG=fatal-criticals --command=appstream-util org.flatpak.Builder validate builddir/*/share/appdata/org.endlessos.Key.appdata.xml'
 using PTY: False
builddir/files/share/appdata/org.endlessos.Key.appdata.xml: FAILED:
• style-invalid         : <caption> cannot end in '.' [Completely free; access without an account, safeguarded data, and no ads.]
• style-invalid         : <caption> cannot end in '.' [Engaging and interactive; discover an abundance of ready-made resources, games, simulations, etc.]
Validation of files failed

CI: https://buildbot.flathub.org/#/builders/25/builds/8069

This is for Publish the Endless Key app on Flathub's PR Add org.endlessos.Key.

New test org.endlessos.Key flatpak v0.3 is built as the testing version on Flathub. https://github.com/flathub/flathub/pull/4481#issuecomment-1718706603


Unexpected exception is thrown in PropertyAccessor.cs, line 138.

Steps to reproduce
In CentOS7, Setup and run PSRP remote scenario by following instructions at https://github.com/powershell/psl-omi-provider.
Expected behavior
No exception is thrown. If needed, return a proper error.
Actual behavior
Hit exception as below when trying to login remotely from a windows client,
PS C:\windows\system32> Enter-PSSession -ComputerName li-cent7 -Credential $cred -Authentication neg
otiate -SessionOption $o
Enter-PSSession : The type initializer for 'System.Management.Automation.ConfigPropertyAccessor'
threw an exception.
At line:1 char:1

Enter-PSSession -ComputerName li-cent7 -Credential $cred -Authenticat ...

- CategoryInfo          : NotSpecified: (:) [Enter-PSSession], TypeInitializationException
- FullyQualifiedErrorId : RemoteRunspaceStateInfoReason

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.9
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

After debugging, the exception is thrown in PropertyAccessor.cs, line 138.  When PSRP tries to CreatDirectory /root/.config/powershell under root at GetCurrentUserConfigDirectory(). It is inconsistent that the logic catches the exception at JsonConfigFileAccessor(), but not GetCurrentUserConfigDirectory().
    internal JsonConfigFileAccessor()
    {
        //
        // Sets the system-wide configuration directory
        //
        Assembly assembly = typeof(PSObject).GetTypeInfo().Assembly;
        psHomeConfigDirectory = Path.GetDirectoryName(assembly.Location);

        //
        // Sets the per-user configuration directory
        //
        appDataConfigDirectory = Utils.GetUserConfigurationDirectory();
        if (!Directory.Exists(appDataConfigDirectory))
        {
            try
            {
                Directory.CreateDirectory(appDataConfigDirectory);
            }
            catch (UnauthorizedAccessException)
            {
                // Do nothing now. This failure shouldn't block initialization
                appDataConfigDirectory = null;
            }
        }
    }

    /// <summary>
    /// Enables delayed creation of the user settings directory so it does
    /// not interfere with PowerShell initialization
    /// </summary>
    /// <returns>Returns the directory if present or creatable. Throws otherwise.</returns>
    private string GetCurrentUserConfigDirectory()
    {
        if (null == appDataConfigDirectory)
        {
            string tempAppDataConfigDir = Utils.GetUserConfigurationDirectory();
            if (!Directory.Exists(tempAppDataConfigDir))
            {
                Directory.CreateDirectory(tempAppDataConfigDir);
                // Only assign it if creation succeeds. It will throw if it fails.
                appDataConfigDirectory = tempAppDataConfigDir;
            }
            // Do not catch exceptions here. Let them flow up.
        }
        return appDataConfigDirectory;
    }

tempAppDataConfigDir is /root/.config/powershell at the failure case.

While this can be reproduced during remoting due to the higher likelihood of HOME not being set (or being set to a non-writable folder), this is not itself a remoting bug.
The ConfigPropertyAccessor logic that is meant to read PowerShell configuration values from JSON files must not require that user config directory can be created. If it cannot be written, PowerShell should not fail like this.
The XDG Base Directory Specification (which this UserConfigDirectory is for) states:

If, when attempting to write a file, the destination directory is non-existant an attempt should be made to create it with permission 0700. If the destination directory exists already the permissions should not be changed. The application should be prepared to handle the case where the file could not be written, either because the directory was non-existant and could not be created, or for any other reason. In such case it may chose to present an error message to the user.

An error message is acceptable; crashing is not.

I'm assigning to @mirichmo for follow-up.

It would be nice if it check HOME was set, before trying to use it and if not set, display an error message saying please set environment variable home.  I was lucky to notice this was a difference between myself running it as a user and a service running it.

Ah but PowerShell should be able to run even without HOME being set, as there are applicable scenarios where this is the correct environment (say, running as a daemon, or started by cron under a user with a non-existent home directory). So instead of erroring, I think it should just run without a problem (and error gracefully when it needs to write something but can't).

closed via #2387

@andschwa @mirichmo I'm continuing to encounter this error with the latest alpha release on Ubuntu 14.04 when HOME is unset. I expected running it with -NoProfile would prevent Powershell from attempting to load settings, but I could be mistaken on what that flag controls. Is this error still expected on Ubuntu 14.04 even though #2387 is merged in?
$ unset HOME
$ powershell
PowerShell
Copyright (C) 2016 Microsoft Corporation. All rights reserved.

The shell cannot be started. A failure occurred during initialization:
The type initializer for 'System.Management.Automation.ConfigPropertyAccessor' threw an exception.

Environment info:
PS /home/kloudless> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.14
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

@vinodc Can you please attach the stack trace from the exception?
Based on code inspection, I suspect that this is the offending line. My guess is that it is an ArgumentNullException stating that the argument to Path.Combine is null since "HOME" is not defined.

I believe that's #1794.

@mirichmo That's all the output that was provided. Was there a way to obtain the stack-trace from the alpha release? I'm not sure if it was compiled with debugging symbols. Would I need to compile it from source to generate a Debug build instead?

Hmmmm... if PowerShell had started, you could use $Error[0] | fl * -Force. Debugging it in VS Code and stopping at the exception throw point would provide the answer.
With that said, I'm pretty certain that this is a simpler reproduction of #1794 and no additional information is needed.


ASAN: heap-buffer-overflow in InactivityCop

==26076==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6250008cc918 at pc 0x000000e096e6 bp 0x2b88973a8600 sp 0x2b88973a85f0
READ of size 8 at 0x6250008cc918 thread T2 ([ET_NET 0])
    #0 0xe096e5 in Ptr<ProxyMutex>::operator bool() const ../../include/tscore/Ptr.h:112
    #1 0xe096e5 in Continuation::handleEvent(int, void*) /usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:189
    #2 0xe096e5 in read_signal_and_update /usr/local/src/trafficserver/iocore/net/UnixNetVConnection.cc:83
    #3 0xe0e7fa in UnixNetVConnection::mainEvent(int, Event*) /usr/local/src/trafficserver/iocore/net/UnixNetVConnection.cc:1148
    #4 0xde3cef in Continuation::handleEvent(int, void*) /usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:190
    #5 0xde3cef in InactivityCop::check_inactivity(int, Event*) /usr/local/src/trafficserver/iocore/net/UnixNet.cc:85
    #6 0xf290ac in Continuation::handleEvent(int, void*) /usr/local/src/trafficserver/iocore/eventsystem/I_Continuation.h:190
    #7 0xf290ac in EThread::process_event(Event*, int) /usr/local/src/trafficserver/iocore/eventsystem/UnixEThread.cc:136
    #8 0xf2b9ad in EThread::execute_regular() /usr/local/src/trafficserver/iocore/eventsystem/UnixEThread.cc:249
    #9 0xf2cd71 in EThread::execute() /usr/local/src/trafficserver/iocore/eventsystem/UnixEThread.cc:338
    #10 0xf2717a in spawn_thread_internal /usr/local/src/trafficserver/iocore/eventsystem/Thread.cc:92
    #11 0x2b8891a17e64 in start_thread (/lib64/libpthread.so.0+0x7e64)
    #12 0x2b889274d88c in clone (/lib64/libc.so.6+0xfe88c)

Address 0x6250008cc918 is a wild pointer.
  With that commit, the read_vio ndone is no longer being updated.  For the post bodies, we are entirely relying on the client correctly setting the stream end flag.  The asserts were catching cases where the origin tunnel consumer received the WRITE_COMPLETE but the user agent tunnel producer never received the READ_COMPLETE.  Instead it hung out until it received the INACTIVE TIMEOUT.  In this sequence the server_session was not being cleaned up correctly, leaving a read_vio pointing back to the deleted state machine.
I have a branch which updates the ndone and sends the READ_COMPLETE once read_vio.ntodo() is 0 or the end stream flag is set.  I'm leaving this run.  And I need to back out some of my asserts before putting up a PR tomorrow.

Spent the day working with PR's #6404, #6413, and #6407.
Mostly ran with #6404 + #6413 on a prod box.  It did not crash, and it did not show increased client aborts, but it did not get as many connections as its peer.  Even after the peer was restarted.
Tweaked with that build some more adding and subtracting things, then went to PR #6407.  That too is not crashing, but it is showing the same reduced RPS.
I did not build the image on the peer machine, so it is possible there is a problem in my build environment.  Monday, I will build both our standard image (with the post optimization commit reverted) and the fixed versions to figure out the performance difference.

After several days of pounding my head, I switched my test and control boxes.  The changes in performance stayed with the machines.  So I was chasing a chimera.  The performance changes were due to the load balancing configuration in this colo.
Based on my testing, I agree with @masaori335 and think that the combination of PR #6413 and PR #6404 are the best option.

This is fixed by #6413 & #6404.


Train with my own data

Hi, @SaoYear .Thank you for your great work.I am a beginner in the field of SED.Now i want to finetune with own data.The problem is that I only have audio files and annotations.I want to ask that how could i change the data folder path in the yaml or how could i modify the code?
Thank you so much

Hello, brother:
I am also a beginner in SED, but I think the question you raised would be more appropriate to ask ChatGPT. This is not only a sign of respect for the open-source contributors but also a sign of respect for yourself.

Hi guys, sorry for being late to response this issue.
@Zhu1004 For your question, I would recommend you to refer to the DESED baseline repo. Instead of transforming your annotation in .yaml, you should re-organized them in to .csv files.
The .yaml files are only used for the model training configuration, which follows the rule of pytorch-lightning.
The implementations of ATST-SED are indeed somehow complicated for the new-comers. That's because it follows the DESED baseline implementation details, which makes it more friendly to the DCASE challenge participants.
@chumingqian It's okay for me to give suggestions for the new-comers. But thank you for your enthusiasm anyway!
There are new-comers to the field of SED each year. I am planning to organize a WeChat group for the new-comers so that I do not need to answer the problems repeatly.

In case that the QR code could be expired, if any other developer has problems on the SED implementation, please leave a message in this issue.


On locked environment

Hello,
Maybe I have missed something, but I have an issue.
In the scenario, I have an isolated system, that doesn't have an outside world connection and therefore cannot fetch using git and using the Grafana store.
So I downloaded the plugin from GIT and added it to the Grafana plugin folder. I see the plugin in the dashboard but once I click on it loads like forever. I guess that it is trying to fetch some resources from outside the network. Therefore I would like to ask you if could you please advise how to get it working with an isolated network. Or maybe you could tell me in what file or files it is requesting so that I can put that on the internal network?
Thanks.

Resolved on my own.
Thanks.


Rewrite info-hackspeed

Filter by key code to only count letters and numbers, and not interpunction and e.g. the Ctrl and Shift keys. (The way this works isn't foolproof but it should be good enough.)
Be more efficient: use less commands to achieve the same goal.
Add options, and make them configurable with environment variables. This would enable system-wide installations with per-user configurations. If you think the code gets too unorderly with the environment variable system, feel free to only merge the first and third commit and ignore the second.

Let me check it out.

Which icon font is that on your screenshot? It looks good!

You use subtitles from the AV section. :wink:


Support "uncipher(file)" with privatekey specified

It would be great, if rsactftool could easily support the decryption of a ciphertext also when you already have the private key generated (and not only the public key).
While this here works:
./RsaCtfTool.py --publickey "pub?.pem" --uncipher 88389551.....
this doesn't:
./RsaCtfTool.py --key priv1.pem --uncipher 883895515...... Traceback (most recent call last):   File "./RsaCtfTool.py", line 806, in <module>     attackobj = RSAAttack(args)   File "./RsaCtfTool.py", line 135, in __init__     if '*' in args.publickey or '?' in args.publickey: TypeError: argument of type 'NoneType' is not iterable
It seems the cmdline parsing logic just assumes a key needs to be attacked but fails to recognize everything's given to actually do something useful.


Cookies/localStorage is not shared across WKWebView:s (RN 0.57.1)

Hi, we have an app with several webviews within it. If you log in from one of the webviews you should be logged in, in all of them (This should be expected, right?). The cookie/localStarage sharing works in both UIWebview, and the third party WKWebview component. Here is the PR that fixed it for that component, if it helps:
https://github.com/CRAlpha/react-native-wkwebview/pull/123
React Native Environment Info:
Binaries:
Node: 8.12.0 - /usr/local/bin/node
Yarn: 1.9.2 - ~/.yarn/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.1.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
npmPackages:
react: 16.5.2 => 16.5.2
react-native: 0.57.1 => 0.57.1
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

Hey there - WebView is in the process of being extracted to its own repo, please open a dedicated issue there


Create PrivateKey trait

Background
Our DefaultPrivateKey struct exposes several useful methods. We should expose at least the following methods via a trait, and add that trait to Spec.
pub trait PrivateKey: TryFrom<&[u8]> {
       type PublicKey: PublicKey;
       type Signature: Signature<PublicKey = Self::PublicKey>;
       fn generate() -> Self;
       fn pub_key(&self) -> Self::PublicKey;
       fn sign(&self, msg_hash: [u8; 32]) -> Self::Signature;

        pub fn to_address::<A: AddressTrait>(&self) ->  {
            self.pub_key().to_address::<A>()
        }
    }

closed by #608


Memory Mapped File access : the file is being used by another process

I am trying to use MemoryMappedFile to write some bulk data from the database. Whenever I am running application in a single instance,it works perfectly well-as the writing is taking place sequentially. But whenever I am trying to run the same application in multi-instance mode,it is failing to write to the file. If one instance is writing data to the file,the other instance which got instantiated in parallel is unable to access this file.
I looked at the file.cs class in the framework but I could not find a property or method which can give me information if the file is free to be written i.e.,it is not being used by any other process.
Could someone help me -how do I check if the file is not being used by any other process?
public static void WriteToMMF(string fileName, byte[] records, long? beginOffset, long? endOffset)
{
//create MMF
try
{
using (var writeMMF = MemoryMappedFile.CreateFromFile(fileName, FileMode.OpenOrCreate, "OutboundMMF", endOffset.Value))
{
using (MemoryMappedViewAccessor accessor = writeMMF.CreateViewAccessor())
{
accessor.WriteArray(beginOffset.Value, records, 0, records.Length);
                }
            }
        }
        catch (Exception ex)
        {

            throw ex;

        }
    }

See below link.
http://stackoverflow.com/questions/876473/is-there-a-way-to-check-if-a-file-is-in-use
V/RChris Barratta
Date: Mon, 24 Aug 2015 16:13:13 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Subject: [dotnet] System.IO (#226)
I am trying to use MemoryMappedFile to write some bulk data from the database. Whenever I am running application in a single instance,it works perfectly well-as the writing is taking place sequentially. But whenever I am trying to run the same application in multi-instance mode,it is failing to write to the file. If one instance is writing data to the file,the other instance which got instantiated in parallel is unable to access this file.
I looked at the file.cs class in the framework but I could not find a property or method which can give me information if the file is free to be written i.e.,it is not being used by any other process.
Could someone help me -how do I check if the file is not being used by any other process?
public static void WriteToMMF(string fileName, byte[] records, long? beginOffset, long? endOffset)
    {

        //create MMF

        try

        {

            using (var writeMMF = MemoryMappedFile.CreateFromFile(fileName, FileMode.OpenOrCreate, "OutboundMMF", endOffset.Value))

            {

                using (MemoryMappedViewAccessor accessor = writeMMF.CreateViewAccessor())

                {

                    accessor.WriteArray(beginOffset.Value, records, 0, records.Length);

            }
        }
    }
    catch (Exception ex)
    {

        throw ex;

    }
}

—
Reply to this email directly or view it on GitHub.

Please re-activate if this is still an issue.


Call datamodule.setup() before linking arguments

Description & Motivation
Some properties of the dataset (for example, the number of features of a multivariate time series dataset) need to be passed to the model as arguments. To reuse DataModule classes, I calculate those properties in the setup() method of the DataModule. However, this doesn't seem to be supported in Lightning CLI. The arguments are linked before setup() method of DataModule is called, thus an AttributeError is raised, claiming that there are no such properties in the DataModule.
Pitch
Call datamodule.setup() before linking arguments so that the calculated properties can be accessed and linked to the model by Lightning CLI.
Alternatives
No response
Additional context
No response
cc @borda @carmocca @mauvilsa

I think that LightningCLI suddenly calling setup() is not a good idea. This behavior change most likely could conflict with existing code. And making it an option is not very important because there are already multiple ways of doing this. Two that I can mention are:

Implement the attribute(s) as a @property that when its value is accessed, then it would automatically call setup(), if not done already.
Subclass LightningCLI and in add_arguments_to_parser add a custom instantiator for the data class, see add_instantiator. The instantiator function would first instantiate the class, then call setup() and then return the class instance.


GLES2 Chaning scenes sometimes results in a messed up editor UI, colors becoming transparent

Godot version:
3.1 5707034
OS/device including version:
Windows 10 Intel HD 4600
Issue description:
When I changing scene(from  3D tutorial), sometimes I see that theme crash. After theme crash I can see a big slowdown, even several times
Videos with this strange behaviours:
https://streamable.com/ira9l
https://streamable.com/9l0cm
Log from cmd from this: GLES2.txt
Bugsquad edit: Error spam consists of:
ERROR: _gl_debug_print: GL ERROR: Source: OpenGL        Type: Error     ID: 1280        Severity: High  Message: Error has been generated. GL error GL_INVALID_ENUM in (null): (ID:<PHONE_NUMBER>) <target> 0 is not valid.
   At: drivers/gles2/rasterizer_gles2.cpp:111
...
ERROR: _gl_debug_print: GL ERROR: Source: OpenGL        Type: Error     ID: 1281        Severity: High  Message: Error has been generated. GL error GL_INVALID_VALUE in (null): (ID: 173538523) Generic error
   At: drivers/gles2/rasterizer_gles2.cpp:111

probably a rare edge case of maxxing out a intel hd 4600 by scene switching as fast as possible :P

i7 4770S
This error occurs at different times. First time I had to change scene several times, but different time I change scene only once and it happened.

Can't reproduce bug with master


installerOptions.stateStore.verifyStateParam not called when state parameter is empty

Description
Error message:  "Redirect url is missing the state query parameter. If this is intentional, see options for disabling default state verification."
To reproduce this error, you need to set stateVerification to true and try installing the app from the app page. (url  wil be like
that ..&state=&....
installerOptions.stateStore.verifyStateParam not called when state parameter is empty
I think the check described below is not needed, because I can validate it myself in installerOptions.stateStore.verifyStateParam.
@slack/oauth/dist/index.js, line 379
if (this.stateVerification && !state) {
    throw new errors_1.MissingStateError('Redirect url is missing the state query parameter. If this is intentional, see options for disabling default state verification.')
}

What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version:
"@slack/bolt": "^3.9.0",
"@slack/oauth": "^2.4.0",
"@slack/web-api": "^6.6.0",
node version:
OS version(s):
Steps to reproduce:

set stateVerification to true
Try installing the app from the app page. (url  wil be like
that ..&state=&....
after redirect your app will send error "Redirect url is missing the state query parameter. If this is intentional, see options for disabling default state verification."

Expected result:
Function verifyStateParam call
What you expected to happen
Function verifyStateParam call
Actual result:
error "Redirect url is missing the state query parameter. If this is intentional, see options for disabling default state verification."
What actually happened
@slack/oauth/dist/index.js, line 379
if (this.stateVerification && !state) {
    throw new errors_1.MissingStateError('Redirect url is missing the state query parameter. If this is intentional, see options for disabling default state verification.')
}

Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

Hey @dzhk,
Thanks for submitting the issue! I agree that your expected result makes sense. I've labelled this as needs info so that we can discuss whether to change the functionality and whether this would introduce breaking changes for existing developers who assuming that an error will be thrown.

Hey @mwbrooks!
Perhaps you should create a default state setting in your application's manifest.  This will solve my problem

As a temporary solution, you can do this:
const tmp  = require('@slack/oauth') ;
tmp.InstallProvider.originalExtractSearchParams = tmp.InstallProvider.extractSearchParams;
tmp.InstallProvider.extractSearchParams = function(){
    const resultOriginal = this.originalExtractSearchParams.apply(this, arguments);
    if ( resultOriginal.get('state') === '' ) {
        resultOriginal.set('state', 'your_default_state');
    }
    return resultOriginal;
}

Hey @dzhk, thanks a lot for the temporary solution code sample. 🙇🏻  That may help others who want to apply the same workaround.
Another alternative is to use the installerOptions.callbackOptions.failure callback to handle an empty state gracefully. This would be safer in-case the private method InstallProvider. extractSearchParams is changed during a minor or patch release.

I had an internal discussion with some of the maintainers of Bolt JS. There's agreement that this is a legit change, but it would require a major version update to not break functionality of existing developers. So, I'm going to assign it to the 4.x Milestone. Thanks for helping us find this improvement!


wg-ui-and-a11y Status Update 2019-12-6

What was accomplished

Video Docking: Scroll back up to the original video
Visual tests for docking
Fixed an issue with fonts
Inline autocomplete experimentally launched! 👏👏
Changes for inline-gallery in base-carousel
[UI] Validator badges design

Lessons learned

Video docking is stable now (manual tests)!
Learned about a11y and pointer-events: none
Should use touch-action / pointer-events instead of gestures.js
Visual diff API is easy to use!
It is possible to reducing the bundle size by adding code!

What's next

Document lack of support for docking in the viewer
Docking interaction for multiple videos
Display locking
More inline autocomplete
Merging inline gallery + documentation
Look into blurry placeholders
Unify fonts inside AMP

WRT "What's next": We have requested https://github.com/ampproject/amphtml/issues/23675 which is important for our catalog of tool-tips delivered via amp-list. If this problem is not solved, we have to generate the tool-tip as part of static-page-generation, which is less flexible and does not allow content creators to easily update an amp-list rather than rebuild the page.


Event topics support

I'm going to merge this branch and add specific hardfork heights in separate PR

Is it okay? Could you wait for Ashiqul Islam's review?


Improving hasModel method, adding test

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.47 :tada:

Comparison is base (83d9166) 65.05% compared to head (c6a513f) 65.53%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff              @@
##                1.x      #18      +/-   ##
============================================
+ Coverage     65.05%   65.53%   +0.47%
  Complexity      478      478
============================================
  Files            93       93
  Lines          1348     1349       +1
============================================
+ Hits            877      884       +7
+ Misses          471      465       -6

Impacted Files
Coverage Δ

src/Component/DataAccessor.php
100.00% <100.00%> (+25.00%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


azd should support Aspire mongodb.server.v0 resource type.

Currently when attempting to deploy a Mongo DB resource in Aspire via azd using the AddMongoDB(...) method we get the following error:
ERROR: generating bicep from manifest: unsupported resource type: mongodb.server.v0

When we support managed services we should deploy this resource type:
https://learn.microsoft.com/en-us/azure/cosmos-db/mongodb/introduction

We will not add hand-crafted, template-based Bicep deployment support in azd. Instead, we will be moving towards using bicep resource type and CDK effort.

https://github.com/dotnet/aspire/issues/1941
https://github.com/Azure/azure-dev/issues/3279


update qrcode.clear() method

update qrcode.clear() method and it can be used when useSVG=false
add the useSVG in options and update the README.md

Let me know if it needs adjusting

@steplegionnare i encounter the same isssue, trid clear the src attribute on img tag, worked on android, however failed on iphone.
the workout for me is clear all inner html of the qrcode container. for example:
generate:
qrcode = new QRCode($('#qrcode')[0])
clear:
$('#qrcode').html('');

I think clearing inner HTML manually is not proper thing to do)
.clear() method needs to be modified to work everywhere)


My reference topic

Merge my reference topic after review.

I'm not sure about the nature of this topic. It seems to be a collection of several topics in one file. Can you provide some more context about this and where it would fit in the documentation, please?
Thanks!

Hi there,
I was thinking of a dedicated topic to reference the required elements for each request. Let me know if this would fit...
Thanks,
Radhika

I see what you're trying to do and added some suggestions to help support that goal. Feel free to add more clarification, if necessary.
Also add a link to this topic from someplace that makes sense in the existing topics.
Thanks!

Can I create this topic reference in the API reference docs section on this > https://uwc2-apidoc.github.io/to-do-service-public/
page?

Review requested for pr-71

Can I create this topic reference in the API reference docs section on this https://uwc2-apidoc.github.io/to-do-service-public/
page?

How about in the https://uwc2-apidoc.github.io/to-do-service-public/#api-reference-docs section.

Open pull request for #71..


Add instuction how to inject clientscript via nginx reverse proxy config

An alternative solution to inject the clientscript into the webclient.
This is using the Nginx ngx_http_sub_module module, works when using Nginx as reverse proxy in front of Jellyfin (regardless of install method) and does not require any file/owner/permissions changes as Nginx simply injects the code dynamically on request

@tam1m I also had to disable caching in nginx for the /web/ location:
	location = /web/ {
# Proxy main Jellyfin traffic
		proxy_pass http://$jellyfin:8096/web/index.html;
		proxy_set_header Host $host;
		proxy_set_header X-Real-IP $remote_addr;
		proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
		proxy_set_header X-Forwarded-Proto $scheme;
		proxy_set_header X-Forwarded-Protocol $scheme;
		proxy_set_header X-Forwarded-Host $http_host;
# disable caching
		add_header Last-Modified $date_gmt;
		add_header Cache-Control 'private no-store, no-cache, must-revalidate, proxy-revalidate, max-age=0';
    		if_modified_since off;
    		expires off;
    		etag off;
# inject Jellyscrub script into the webclient
		proxy_set_header Accept-Encoding "";
		sub_filter
			'</body>'
			'<script plugin="Jellyscrub" version="<IP_ADDRESS>" src="/Trickplay/ClientScript"></script>
			</body>';
		sub_filter_once on;
	}

Otherwise the inject sometimes didn't happen. Did you also faced this issue? Or maybe have a better solution?


add tom hennen to pgi viewers

@tomhennen FYI

@trevrosen @SantiagoTorres @priyawadhwa @lukehinds can I get an LGTM from one of you please?


fix(template-preact-ts): add preact compat paths to tsconfig

Description
This patch adds React compatibility types to template-preact-ts so that new projects using create-vite with Preact and TypeScript include these by default.
Additional context
I ran into some typing issues trying to use react-redux with this Preact template.
Type 'Element' is not assignable to type 'ReactNode'. Property 'children' is missing in
type 'VNode<any>' but required in type 'ReactPortal'.

Preact's docs specify that you can add some type paths to add compatibility for Preact with libraries meant for React.

Your project could need support for the wider React ecosystem. To make your application compile, you might need to disable type checking on your node_modules and add paths to the types like this. This way, your alias will work properly when libraries import React.

Many people use Preact as a faster, lightweight, and compatible alternative to React, so most developers are likely going to use libraries meant for React with Preact. This change removes friction, with what seems to be little added cost, so that developers can quickly get started on a new project.
I'm also happy to turn this PR into a discussion thread if this change is unwanted. (Also, thanks for making Vite; I've never been able to spin up a new project with little overhead this easily before!)

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[X] Other

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines.
[X] Read the Pull Request Guidelines and follow the PR Title Convention.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[X] Ideally, include relevant tests that fail without this PR but pass with it.

For other reviewers: @preact/preset-vite aliases react to preact
https://github.com/preactjs/preset-vite/blob/3ed6fb180ed3845f26281675e45f06c1acbce906/src/index.ts#L174-L180

I'm a bit worried that this would bring questions of Vite being impartial to package managers that don't use node_modules, like yarn pnp or Deno default mode. Does the error happen even with skipLibCheck: true? Usually that means ignoring errors in libraries, so I'm confused why the paths is still needed when the error is ignored.

Thanks for the feedback; I can see that this could be an issue for other package managers. While messing around with my project, trying new libraries, I found that the issue was gone once I uninstalled react-redux. Seems that it is pulling in @types/react, which was the source of the issues.
At this point, I think it makes the most sense for react-redux to stop forcing a peer dependency on @types/react. If that isn't feasible, it probably is best for Vite users to add this on a need-by-need basis.
Feel free to close this PR if you think the discussion is resolved.

Maybe we should just add a link to these issues because it doesn't seem to have a good solution yet.

Yeah I think it would be nice to add some comments to the tsconfig to explain about skipLibCheck, and what to do if it's disabled. Closing this for now as that could be done together in https://github.com/vitejs/vite/issues/7867.


Make filename retrieval function more generic

In some occasions mentioned in #6, the src within @font-face declarations can’t be used for mapping to a filename.
I’d propose adding a more generic resolveFilename callback as a replacement for srcUrlToFilename, accepting parameters such as src and fontFamily:
const postcssFontpie = require("postcss-fontpie");

module.exports = {
  plugins: [
    postcssFontpie({
      fontTypes: {
        "Atkinson Hyperlegible": "sans-serif",
        "JetBrains Mono": "mono",
      },
      resolveFilename: ({ src: _unused, fontFamily }) => {
        const fontFamilyNormalized = fontFamily.replace(" ", "-").toLowerCase();
        return require.resolve(
<EMAIL_ADDRESS>        );
      },
    }),
  ],
};

Please note that this would make implementing #6 unnecessary.

Thanks for the feedback! I think I like this option better than #6. I'll look into implementing something like this and will probably create a minor release with the srcUrlToFilename option deprecated

@kripod, mind taking a look at #8 and confirming it would solve your issue?

Yeah, that looks awesome, thank you!
I really appreciate your quick response and implementation 🚀

No problem! Just published in 1.1.0 😄


Stream transformation

Hello,
I am wondering if it is possible to be able to modify the local stream before sending it and the remote stream after receiving.
the modification may be private compression, encryption, or any algorithm.
This is for practical security reasons.
Thanks.

at the current time, our SDK doesn't support this feature, and we don't plan to add this functionality at the nearest time


Publish the Gradle plugin to MavenCentral

The Gradle plugin is currently only published to the Gradle plugin portal.
Publishing it on MavenCentral is easy to setup.
Main reason to consume the plugin from MavenCentral is the JCenter shutdown and the redirection handling of the Gradle plugin portal regarding proxying MavenCentral, https://blog.gradle.org/portal-jcenter-impact.
That's why we do not depend on the Gradle plugin portal at all but only use MavenCentral.

I believe gradle plugin portal does not use JCenter (as of July 15, 2024) but I could be wrong. It doesn't feel unreasonable to use the gradle plugin portal -- but I guess people can see this differently. There's no reason we can't publish this to maven central, we just don't yet.


Adding "make install" command

Having install is a bit useful for us to install jvmkill as a part of build process of Docker images.

We now publish a Docker image: ghcr.io/airlift/jvmkill:latest


Creating a floating block now takes durability

Closes #156
(I know it's already closed, but it's not actually solved. The code that solves it was forgotten to be committed.)

Nevermind


Activate the GitHub App Stale on the GitHub repository

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:

Task list:

[ ] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #155 into dev will not change coverage.
The diff coverage is n/a.

@@        Coverage Diff         @@
##           dev   #155   +/-   ##
==================================
  Coverage   94%    94%
==================================
  Files        6      6
  Lines      784    784
==================================
  Hits       741    741
  Misses      43     43

Reviewed 1 of 1 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


fix: [IDP]: Updated the info for catalog metadata related checks

Description

Please describe your changes: Updated the info for catalog metadata related checks

PRs must meet these requirements to be merged:

[ ] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[x] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://661409be41ad8a045a41bc71--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66140d50fb52d306d72b4cb8--harness-developer.netlify.app


mc_objectinstancepair_destroy will be invoked from mc_objectinstancepair_list_destroy

So no need to invoke mc_objectinstancepair_destroy at the end of mc_parameter_listdefinition_consumer_response.

This was an issue in mc_parameter_listdefinition_consumer and mc_parameter_getvalue_consumer.


Working with command palette

Description
It has been some time since GitHub announced Command palette. While it is as standalone as it can get, maybe some features should work with it:

sort-conversations-by-update-time doesn't apply to links within the command palette. I wonder if it's worth doing so though.
file-finder-buffer is not going anywhere (since it's branch-aware), but repo-wide-file-finder may seem redundant now (though I still tend to press t these days).
Just for record: https://github.com/refined-github/refined-github/issues/3802#issuecomment-966471452

More thoughts welcome.
Screenshot
No response
Example URL
N/A

sort-conversations-by-update-time doesn't apply to links within the command palette. I wonder if it's worth doing so though.

Maybe, but probably via delegate since it's keyboard-based (so no need to support "Right click -> Open in new tab")

file-finder-buffer is not going anywhere (since it's branch-aware), but repo-wide-file-finder may seem redundant now (though I still tend to press t these days).

Let's keep it at least until it breaks. It's a micro feature that shouldn't give us trouble either way (I also use it more than the palette at this point)

Just for record: Toggle for Github Theme #3802 (comment)

?

Just for record: Toggle for Github Theme #3802 (comment)

?

It's possible to run "commands" with the > prefix, like changing the current theme.

[ ] Links in command palette is not PJAX enabled. We can enable that if you are e.g. in the same repository, just like regular GitHub navigation.

For operations on such links, let's use delegate and listen to keydown/mousedown to change links on the fly, not MutationObserver

Now that this was discussed, I'm closing it.
If there are still any bugs related to the palette, please open separate issues.
I opened this for a feature request followup:

https://github.com/refined-github/refined-github/issues/6142


New feature request: OCSP must-staple

Since you already support checking for HPKP, how about OCSP must-staple?
https://blog.mozilla.org/security/2015/11/23/improving-revocation-ocsp-must-staple-and-short-lived-certificates/

+1.

+1

+1

+1


Add documentation for syndication endpoint

Using url and token query string values
How to set up as a webhook (using Netlify as an example?)

I'll add that many of the plugins could use a further explanation of "why" to show how it is useful.

I'll add that many of the plugins could use a further explanation of "why" to show how it is useful.

First pass at making plugin descriptions a bit more useful in https://github.com/getindiekit/indiekit/commit/e68eb1306b0b634a193b5536a0305b46ad63be55


[add-skip-ci-mq-check] Add skip ci check

What does this PR do?
Adds a skip ci check to the merge queue

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Improve whitelist comments + issue with PreparedSQL sniff

This PR contains a bugfix and an enhancement. Pulled in one go as they would otherwise conflict.
While working on some improvements for the PreparedSQLPlaceholders sniff, which includes a whitelist comment, I came across the following issue:
// This works fine.
$sql = $wpdb->prepare( "SELECT * FROM $wpdb->users WHERE id = %d AND user_login = %s", $replacements ); // WPCS: PreparedSQLPlaceholders replacement count OK.

/*
 * This would trigger a "Use placeholders and $wpdb->prepare();
 * found // WPCS: PreparedSQLPlaceholders replacement count OK." error.
 */
$sql = $wpdb->prepare( // WPCS: PreparedSQLPlaceholders replacement count OK.
	"SELECT *
		FROM $wpdb->users
		WHERE id = %d
			AND user_login = %s",
	$replacements
);

Bugfix: That the WP.PreparedSQL sniff triggers an error for comments is clearly wrong, so that is fixed in the first commit.
Next I had a look at the has_whitelist_comment() method as - based on the number of questions I've seen about the whitelist comment placement and the number of times I've struggled with it myself in the past -, it doesn't always seem intuitive where to place the whitelist comment.
Whitelist comments only worked if they were:

the last token in an embedded PHP snippet
òr at the end of the line for the token which triggers the whitelist check.

However, for a "normal" user, it is often unclear what token triggers the whitelist check, so people find it hard to correctly place the whitelist comments.
Enhancement: The second commit changes the behaviour of the whitelist comment method and now allows for both the above as well as a whitelist comment directly after the semi-colon ending the statement.
I do wonder why this wasn't implemented when the method was originally and if there were pertinent reasons not to do so. Maybe @JDGrimes or @westonruter knows ?
So taking the above example, this will now work:
$sql = $wpdb->prepare(
	"SELECT *
		FROM $wpdb->users
		WHERE id = %d
			AND user_login = %s",
	$replacements
); // WPCS: PreparedSQLPlaceholders replacement count OK.

Unit tests for both are, of course, included.
TODO when merged

[x] Update wiki whitelist comment page

I do wonder why this wasn't implemented when the method was originally and if there were pertinent reasons not to do so. Maybe @JDGrimes or @westonruter knows ?

I think that when I added this method I was trying to make it as efficient as possible, because it gets called by quite a few sniffs on every single token. So we just checked at the end of the line. (There was inconsistency in how different sniffs handled this up to that point, so I just decided to standardize one way or the other.) I think it was only later that the bug with interspersed HTML was fixed. So now that we get the end of the statement anyway, there is no reason not to check both places that I can see.

@JDGrimes Thanks for your response.


Update README

Summary
Adds:

Version shield (icons at top)
Discord shield
"Play Now!" link
Logo
Screenshot

Changes:

Subtle change to game description
Contributing info related to issues

Testing
You can view the full updated README here

I love the new banners, and the bottom section for contributing. I think we should be more explict about other games that influenced this one, so we aren't limiting ourselves to just those who are a fan of Zelda-inspired games, but top down puzzle action games in general, which is what this really is.

I agree, you're welcome to continue making changes of my branch. My focus here was screenshot and the contributing section


ResourceExhaustedError in CNN/MNIST example (with GPU)

Hi titu1994,
I got an issue when I run the code (05_resnet.py)
tensorflow.python.framework.errors_impl.ResourceExhaustedError: OOM when allocating tensor with shape[60000,16,28,28] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc [Op:FusedBatchNorm]
Do you know how to solve this problem.
Also, I have set the batch_size of 2, but same error issue occur.

It's a bug in TF eager, as far as I've found. I've mentioned a fix in the earlier examples, but basically use the private function model._set_inputs.
If that doesn't work, then simply call the model on a single data point first to build all the tensors. Aka is model (dummy_x).

Hi titu1994;
Thanks, it work for me.


ViewController does not dealloc when push to another view

I have dealloc problem when using WVJB enable UIWebView. I think problem maybe the memory management. Right?
Without WVJB
A -> push -> B (UIWevView) -> pop back -> A (A trigger dealloc) -> B (UIWebView)
With WVJB
A -> push -> B (UIWevView) -> pop back -> A (A not trigger dealloc) -> B (UIWevView but nothing happen here)
Without WVJB
_webView = [viewController webView];
[_webView setDelegate:self];

With WVJB
 _webView = [viewController webView];
[WebViewJavascriptBridge enableLogging];
_bridge = [WebViewJavascriptBridge bridgeForWebView:_webView webViewDelegate:self handler:^(id data, WVJBResponseCallback responseCallback) {
    NSLog(@"ObjC received message from JS: %@", data);
    responseCallback(@"Response for message from ObjC");
}];

hi ,i meet the same question,if viewDidDisappear do this ,it will be reload (background ---> fo);how can i do?

#135

I have meet the same problem, I find a way to release the ViewController by setting bridge to nil when call popViewController and use weakSelf in the bridge blocks at the same time.


chore(main): release 3.1.0

:robot: I have created a release beep boop
3.1.0 (2024-01-07)
Features

Add end-to-end tests 🧪 (83b9b5a)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/paraspell/xcm-sdk/releases/tag/v3.1.0 :sunflower:


UNSUPPORTED_CLUSTER during ./chip-tool testing (CON-1114)

Hi, so ive been testing my Matter device with temperature measurement cluster. But keep getting unsupported cluster error during ./chip-tool testing.
Here's the command
./chip-tool temperaturemeasurement read cluster-revision 1 1

Here's the output of chip-tool
:523367] CHIP:DMG: ReportDataMessage =
[1712219652.186473][523365:523367] CHIP:DMG: {
[1712219652.186475][523365:523367] CHIP:DMG:    AttributeReportIBs =
[1712219652.186480][523365:523367] CHIP:DMG:    [
[1712219652.186483][523365:523367] CHIP:DMG:            AttributeReportIB =
[1712219652.186488][523365:523367] CHIP:DMG:            {
[1712219652.186491][523365:523367] CHIP:DMG:                    AttributeStatusIB =
[1712219652.186494][523365:523367] CHIP:DMG:                    {
[1712219652.186497][523365:523367] CHIP:DMG:                            AttributePathIB =
[1712219652.186501][523365:523367] CHIP:DMG:                            {
[1712219652.186504][523365:523367] CHIP:DMG:                                    Endpoint = 0x1,
[1712219652.186508][523365:523367] CHIP:DMG:                                    Cluster = 0x402,
[1712219652.186511][523365:523367] CHIP:DMG:                                    Attribute = 0x0000_FFFD,
[1712219652.186514][523365:523367] CHIP:DMG:                            }
[1712219652.186518][523365:523367] CHIP:DMG:
[1712219652.186521][523365:523367] CHIP:DMG:                            StatusIB =
[1712219652.186525][523365:523367] CHIP:DMG:                            {
[1712219652.186528][523365:523367] CHIP:DMG:                                    status = 0xc3 (UNSUPPORTED_CLUSTER),
[1712219652.186531][523365:523367] CHIP:DMG:                            },
[1712219652.186534][523365:523367] CHIP:DMG:
[1712219652.186536][523365:523367] CHIP:DMG:                    },
[1712219652.186540][523365:523367] CHIP:DMG:
[1712219652.186542][523365:523367] CHIP:DMG:            },
[1712219652.186547][523365:523367] CHIP:DMG:
[1712219652.186549][523365:523367] CHIP:DMG:    ],
[1712219652.186553][523365:523367] CHIP:DMG:
[1712219652.186555][523365:523367] CHIP:DMG:    SuppressResponse = true,
[1712219652.186558][523365:523367] CHIP:DMG:    InteractionModelRevision = 11
[1712219652.186560][523365:523367] CHIP:DMG: }

@anuarrozman Are you sure that the temperaturemeasurement cluster is indeed present on endpoint 1? Can you read the server-list attribute on the descriptor cluster on endpoint 1? Also, which device type is present on your device type?

Hi @dhrishi . Thank you. Ive check again using this command
Command:
./chip-tool temperaturemeasurement read cluster-revision 1 3

Output:
[1712221217.663774][552238:552240] CHIP:DMG: ReportDataMessage =
[1712221217.663776][552238:552240] CHIP:DMG: {
[1712221217.663777][552238:552240] CHIP:DMG:    AttributeReportIBs =
[1712221217.663780][552238:552240] CHIP:DMG:    [
[1712221217.663782][552238:552240] CHIP:DMG:            AttributeReportIB =
[1712221217.663784][552238:552240] CHIP:DMG:            {
[1712221217.663786][552238:552240] CHIP:DMG:                    AttributeDataIB =
[1712221217.663788][552238:552240] CHIP:DMG:                    {
[1712221217.663790][552238:552240] CHIP:DMG:                            DataVersion = 0xf2d2d49e,
[1712221217.663792][552238:552240] CHIP:DMG:                            AttributePathIB =
[1712221217.663794][552238:552240] CHIP:DMG:                            {
[1712221217.663796][552238:552240] CHIP:DMG:                                    Endpoint = 0x3,
[1712221217.663798][552238:552240] CHIP:DMG:                                    Cluster = 0x402,
[1712221217.663800][552238:552240] CHIP:DMG:                                    Attribute = 0x0000_FFFD,
[1712221217.663801][552238:552240] CHIP:DMG:                            }
[1712221217.663803][552238:552240] CHIP:DMG:
[1712221217.663806][552238:552240] CHIP:DMG:                            Data = 4,
[1712221217.663807][552238:552240] CHIP:DMG:                    },
[1712221217.663810][552238:552240] CHIP:DMG:
[1712221217.663812][552238:552240] CHIP:DMG:            },
[1712221217.663814][552238:552240] CHIP:DMG:
[1712221217.663815][552238:552240] CHIP:DMG:    ],
[1712221217.663818][552238:552240] CHIP:DMG:
[1712221217.663820][552238:552240] CHIP:DMG:    SuppressResponse = true,
[1712221217.663821][552238:552240] CHIP:DMG:    InteractionModelRevision = 11
[1712221217.663822][552238:552240] CHIP:DMG: }

now it didnt show any error, but during TH Matter test, I get this error.
Executing Test Step: Step 2: TH reads ClusterRevision attribute from the DUT
Test Failure: The test expects no error but the "UNSUPPORTED_CLUSTER" error occured.
Test Failure: The test expects a value but it does not exists in the response."
Test Step Completed [FAILED]: Step 2: TH reads ClusterRevision attribute from the DUT

now it didnt show any error, but during TH Matter test, I get this error.

Which endpoint is the TH reading on? Looks like it is reading the one that does not have the cluster

I'm sorry , it's my mistake. I didnt specify the endpoint before starting the TH. Thank you for your time. I'll close this issue.


[gettext] Fix osx

Fixes https://github.com/microsoft/vcpkg/issues/35778: With the necessary libiconv check before the gettext check, we also need the include_next check before the libiconv check. Instead of pulling the libiconv check in before the gettext check, push the gettext check behind everything up to the libiconv check: I didn't spot any references to GETTEXT or LIBINTL dependencies in the now-early checks.
Fixes failing cross builds for osx targets: There is probably an upstream bug around relocatable installations, but it is only visible when building for ...-darwin auto tools triplets without trailing release number. Vcpkg uses such triplets for cross builds (and it generally doesn't set the osx deployment target for arm64-osx). The patch aligns cross-builds with native builds on osx >= 10.4.

Feature tools is tested successfully in the following triplet:
x64-osx

Are there ci.baseline.txt or supports changes that need to happen in response to this being fixed?

No. CI doesn't test gettext[runtime-tools], and it doesn't test osx cross-builds. That's why the issues went unnoticed. And even local testing on linux, windows, osx with cross targets missed these combinations.

Thanks!