[ BUG ] IoaRuleGroup.repr() raises AttributeError

Bug Report Template
Describe the bug
Custom IOA Rule models raise an AttributeError when repr() is called on them when instantiated using __init__().
To Reproduce
from caracara.modules.custom_ioa import IoaRuleGroup

irg = IoaRuleGroup("name", "description", "platform")

repr(irg)

Traceback (most recent call last):
  File "/home/zaci/PycharmProjects/Caracara-Reproduce/.venv/lib/python3.10/site-packages/caracara/modules/custom_ioa/rules.py", line 66, in __repr__
    f"<{self.__class__.__name__}(id_={repr(self.id_)}, version={repr(self.version)}, "
AttributeError: 'IoaRuleGroup' object has no attribute 'version'

Expected behavior
There should be no state of IoaRuleGroup where a repr() cannot be displayed.
Environment
Operating System Version
Linux arch 6.11.2-arch1-1 #\1 SMP PREEMPT_DYNAMIC Fri, 04 Oct 2024 21:51:11 +0000 x86_64 GNU/Linux
Python Version

Python 3.10.14
Python 3.12.6

Poetry Version
Poetry (version 1.8.3)
Python Package Versions
caracara==0.8.0
caracara-filters==0.2.0
crowdstrike-falconpy==1.4.5

Additional context
If you are wanting to distinguish between unset and null variables then one approach could be to use a sentinel object.
# sentinel.py
class Unset:
    def __str__(self):
        return ""

    def __repr__(self):
        return "<empty>"

    def __bool__(self):
        return False

# my_model.py
UNSET = Unset()  # sentinel object

class MyModel:
    a: str = UNSET
    b: str = UNSET

    def __init__(self, a: str):
        self.a = a

    def __repr__(self):
        return f"<MyModel(a={self.a!r}, b={self.b!r})>"

m = MyModel("example")
assert repr(m) == "<MyModel(a='example', b=<empty>)>"

*edit: Added Sentinel class for tidier __repr__

After some further playing around I noticed that in a similar note accessing the cloud fields on the models also raises an attribute error. This is documented in the inline comments but I think this would also be improved with sentinel values.
from caracara.modules.custom_ioa import CustomIoaRule

rule = CustomIoaRule("name", "description", <rule_type>)
rule.deleted  # raises AttributeError

Thank you also for raising this issue, Zac! Assigning myself to this one, too. Going to think about how to architect this one a little better.


Use official Bower package for Sinon.

I've been running into a similar error to https://github.com/csantero/ember-sinon/issues/28 when installing this package, and anyway, there seems to be little reason to specify a full Git URL for Sinon, so I've changed it.

Did this wrong. Closing and will reopen when I fix it.


Add support for ResourceShare resource

Issue #492
Description of changes:

Generated ResourceShare
Added e2e tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/retest


onLocationChange not getting triggered after goToLocation fired

Summary
I am saving the latest location in the local storage and if the user closes the book and reopens it later, it goes to the saved location using goToLocation after onReady is fired. The odd thing is, that after that onLocationChange is no longer triggered when swiping to the next page and it also no longer updates the current location.
What platform(s) does this occur on?
Android
What workflow(s) does this occur on?
Expo Workflow
Environment (or package.json)
{
"dependencies": {
"@epubjs-react-native/core": "1.4.5",
"@epubjs-react-native/expo-file-system": "latest",
"@expo/metro-runtime": "~3.2.1",
"@expo/vector-icons": "^14.0.0",
"@gorhom/bottom-sheet": "^4",
"@react-native-async-storage/async-storage": "1.23.1",
"@react-native-community/slider": "^4.5.2",
"@react-navigation/native": "^6.1.15",
"@react-navigation/native-stack": "^6.9.24",
"expo": "^51.0.8",
"expo-document-picker": "~12.0.1",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.74.1",
"react-native-fs": "^2.20.0",
"react-native-gesture-handler": "~2.16.1",
"react-native-paper": "^5.12.3",
"react-native-reanimated": "~3.10.1",
"react-native-safe-area-context": "4.10.1",
"react-native-screens": "3.31.1",
"react-native-vector-icons": "^10.0.3",
"react-native-web": "~0.19.6",
"react-native-webview": "13.8.6",
"usehooks-ts": "^3.1.0",
"expo-router": "~3.5.15",
"expo-linking": "~6.3.1",
"expo-constants": "~16.0.2",
"expo-status-bar": "~1.12.1"
},
"devDependencies": {
"@babel/core": "^7.19.3",
"@types/react": "~18.2.14",
"typescript": "~5.3.3"
},
"scripts": {
"start": "expo start",
"android": "expo run:android",
"ios": "expo run:ios",
"web": "expo start --web"
},
"version": "1.0.0",
"private": true,
"name": "example-expo",
"main": "expo-router/entry"
}
Your .epub file
https://www.clozetesting.com/readdaily/roblox/book.epub
Minimal reproducible example
export function Book({ route }) {
  const { goToLocation, goNext } = useReader();
  let currentLocation;
  let src = `https://www.clozetesting.com/readdaily/${route}/book.epub`;
  if(route === 'test') {
    src = 'https://s3.amazonaws.com/moby-dick/OPS/package.opf';
  }

  const goToSavedLocation = async (currentLocation) => {
    try {
      let savedLocationString = await AsyncStorage.getItem('savedLocationObject_' + route);
      let savedLocationObject = JSON.parse(savedLocationString);
      let savedLocationPos = savedLocationObject.end.location;
      this.currentLocation = savedLocationObject;
      if(savedLocationPos !== null && savedLocationPos != '0' && savedLocationPos != currentLocation) {
        goToLocation(savedLocationObject.end.cfi);
      }

    } catch (e) {
      console.log('error getting saved location');
    }
  };
  const saveLocation = async (currentLocation) => {
    try {
      let savedLocationString = await AsyncStorage.getItem('savedLocationObject_' + route);
      let savedLocationObject = JSON.parse(savedLocationString);

      if(savedLocationObject.end.location != 0 && (currentLocation.end.location == 0 || currentLocation.end.location == savedLocationObject.end.location)) {
        console.log('no change!');
        return;
      }
    } catch(e) {
      //just continue to saving location
    }

    try {
      let currentLocationString = JSON.stringify(currentLocation);
      console.log('saving: ' + currentLocation.end.location);
      await AsyncStorage.setItem('savedLocationObject_' + route, currentLocationString);
    } catch (e) {
        console.log('error saving location');
    }
  };

  return (
    <SafeAreaView style={{ flex: 1 }}>
      <Reader
        src={src}
        fileSystem={useFileSystem}
        height={Dimensions.get('screen').height * 0.8}
        waitForLocationsReady
        onReady={(location) => {
          console.log('onReady');
          goToSavedLocation(location);
        }}
        onSwipeLeft={() => {
          console.log('on swipe left');
          goNext();
        }}
        onLocationChange={(total, current, progress, currentSection) => {
          currentLocation = current;
          console.log('on location change');
          saveLocation(current);
        }}
        onWebViewMessage={(message) => {
          console.log(message);
          if (message.type === 'onCfiFromLocation') {
            goToLocation(message.cfi);
          }
        }}
      />
      <Footer />
    </SafeAreaView>
  );
}

I confirm that i have

[X] I looked for a solution to my problem in other open and resolved issues
[X] I checked the examples provided solve my problem
[X] I have verified that my problem is not caused by a third-party library
[X] I cloned the project environment examples and still the problem persists
[X] I'm using the latest available version of the library and its complements

i try to reproduce this scenario, but when called goToLocation the onLocationChange was fired
import * as React from 'react';
import { SafeAreaView } from 'react-native';
import { Reader, ReaderProvider, useReader } from '@epubjs-react-native/core';
import { useFileSystem } from '@epubjs-react-native/expo-file-system';

function Component() {
  const { goToLocation } = useReader();
  return (
    <Reader
      // src="https://s3.amazonaws.com/moby-dick/OPS/package.opf"
      src="https://www.clozetesting.com/readdaily/roblox/book.epub"
      fileSystem={useFileSystem}
      onReady={() => {
        console.log('onReady');
        goToLocation('text/ch001.xhtml#chapter-5-a-new-challenge');
      }}
      onLocationChange={() => console.log('onLocationChange')}
    />
  );
}

export function Basic() {
  return (
    <SafeAreaView style={{ flex: 1 }}>
      <ReaderProvider>
        <Component />
      </ReaderProvider>
    </SafeAreaView>
  );
}

This has just started happening to me. I'll try and find out as much info as I can.

Okay. What I've found so far.
If I load my app and add a book and start reading it. It will always work. If I leave the book and go back to my library and load it again or another that has been previously loaded, it may or may not stop working (in terms of tracking location changes). Once it stops working it's hard for it to start again. Sometimes changing books works, sometimes scrolling through a bunch of pages starts it again, but not always.
There seems to be no significant difference (other than cfi) of the book object when comparing between when the onLocationChange works and when it doesn't.
These are epub3 files.
Epub2 files don't work at all in this regard, but I'm not too concerned about this at the moment.
If you would like me to set up a minimal repo @victorsoares96 let me know.

I fixed this by putting the goToLocation inside onLocationsLoaded. It takes a little while for it to go to the right page, but it works

Thank you dcallus! I stopped using initialLocation and used goToLocation inside onLocationsReady (which is what I think you meant). That fixed it.

I just met the same situation.And your solution worked,thanks a lot!


Background should have shades of grey like color does

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/3995556-background-should-have-shades-of-grey-like-color-does?utm_campaign=plugin&utm_content=tracker%2F4691114&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F4691114&utm_medium=issues&utm_source=github).

Fixed in 368de61c274206f83444d91293d4d6a95968cba3


Implementing DNS lookups

Perform DNS lookups, with the option of finding the ISP of that IP and rDNS.

The GeoIP plugin does all of this except for rDNS lookups. It does need some improvements, though.


Add more API endpoints

Add the following endpoints:
https://hitbloq.com/api/leaderboard/<leaderboard_id>/friends [POST] {"friends": [<friend_id_1>, <friend_id_2>, etc.]}
https://hitbloq.com/api/ladder/<pool_id>/players/<page>
https://hitbloq.com/api/ladder/<pool_id>/nearby_players/<user_id>
https://hitbloq.com/api/ladder/<pool_id>/friends [POST] {"friends": [<friend_id_1>, <friend_id_2>, etc.]}

Add action ID lookups and return an action ID when requesting user updates.

Action ID lookups have been added.

all endpoints have been added as described


Small error in animation chapter: animate class not mentioned.

In the animation chapter, the style.css excerpt shows the class as
.post{
    position:relative;
    transition:all 300ms 0ms ease-in;
}

When the source code actually has the transition in a post.animate class:
.post.animate{
    -webkit-transition: all 300ms 0ms;
    -moz-transition: all 300ms 0ms ease-in;
    -o-transition: all 300ms 0ms ease-in;
    transition: all 300ms 0ms ease-in; }

I think this is worth noting in the chapter because the animation logic that follows adds and removes this animation class, and the class isn't mentioned until then. This is something that might be obvious to most (especially those that have used the animate.css library), but I think it's best to include to clear up any possible confusion.
GREAT job on the book and new chapter.

Thanks @MichaelOber - I think you are right that we should call it out and it sounds like there's a mistake there.

This is really a problem with the book so I'll move this issue there.


Add --quiet to story

Also sends the spinner to stderr so the stdout is not poluted by the spinner. It should be the spinner library default behavior IMHO.

@j-martin what do you think of also adding the --quiet option to club find?
What do you think of removing the loading/spinner entirely? Originally, the Clubhouse API was a bit slow, but seems to be speeding up over time.

Sounds great!

Released in v1.8.0


feat: add Tilt support. Close #58

This PR adds support for developing against a Kubernetes cluster using Tilt. See https://tilt.dev/ for more info.

Update port forwards to be done this way:
k8s_resource(workload='django', port_forwards=8000)
k8s_resource(workload='mailhog', port_forwards=8025)


add link on non-english documentation

What version of Go are you using (go version)?
go version go1.7.4
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/konstantin/Documents/GoProjects"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build033396211=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
What did you do?
Translate doc. "Effective Go" into Russian language
https://github.com/Konstantin8105/Effective_Go_RU
What did you expect to see?
Please add link on page https://github.com/golang/go/wiki/NonEnglish

Done. (btw anyone with a github account can edit that page).


ArgumentNullException & FormatException

I get
Ausnahme ausgelöst: "System.ArgumentNullException" in mscorlib.dll
Ausnahme ausgelöst: "System.FormatException" in mscorlib.dll

all the time while Client.GetMessages is running.
Seems to do the job anyways, but there is something wrong in the code.

It was a decission by @smiley22 to use Exceptions as "normal flow" which is of course bad see https://github.com/smiley22/S22.Imap/issues/27#issuecomment-15562403
I did some changes to handle this, but can't find it on github so might have ended up in internal only since  responses from smiley just stopped (you should probably consider this repo abandoned by now)

Which alternative do you suggest - please also see my feature request.


Migration without exact nullability makes a non-nullable list literal and assigns null

From package:async.
This is with exact nullability. Notice the two lines commented with // here
  /// Captures each future in [elements],
  ///
  /// Returns a (future of) a list of results for each element in [elements],
  /// in iteration order.
  /// Each future in [elements] is [capture]d and each non-future is
  /// wrapped as a [Result.value].
  /// The returned future will never have an error.
  static Future<List<Result<T>?>> captureAll<T>(Iterable<FutureOr<T>> elements) {
    var results = <Result<T>?>[]; // here
    var pending = 0;
    Completer<List<Result<T>?>>? completer;
    for (var element in elements) {
      if (element is Future<T>) {
        var i = results.length;
        results.add(null); // and here
        pending++;
        Result.capture<T>(element).then((result) {
          results[i] = result;
          if (--pending == 0) {
            completer!.complete(results);
          }
        });
      } else {
        results.add(Result<T>.value(element as T));
      }
    }
    if (pending == 0) {
      return Future<List<Result<T>?>>.value(results);
    }
    completer = Completer<List<Result<T>>>();
    return completer!.future;
  }

Without exact nullability, this produces the same migration except
     List<Result<T>?> results = <Result<T>>[];

This is guaranteed to err at runtime. And even if it didn't, it would err when the null is added to results if the underlying store is indeed List<Result<T>>.
Notably, however, the null is only added temporarily. It looks like it's added essentially because the order of returned values is not guaranteed; if the second future returns a value, it must be inserted as the second value in the list. The null assignment is there to ensure that the list has two slots at that point, and fundamentally, the first slot may be empty.
The exact-nullable migration is therefore mostly correct, except that completer.complete should pass in results.cast<T> or List<T>.from(results).
The migration could be refactored to avoid this, but ultimately, any refactoring will likely be a rewrite of the same pattern -- make a List<T?>, fill in Ts into the list, and then return a copy of the list or a view of it that has different static behavior. Whether that pattern is implemented as a linked list, sequence of awaits, new implementation of lists in dart:core, etc., the pattern will essentially be the same.

In package:collection, we have three literals where they disagree at creation vs assignment:
-    Set<E?> set = SplayTreeSet<E>(comparison);
+    Set<E?> set = SplayTreeSet<E?>(comparison);
     for (var i = 0; i < _length; i++) {
       set.add(_queue[i]);
     }
diff --git a/lib/src/union_set_controller.dart b/lib/src/union_set_controller.dart
index 4f7d6e1..c31d0c8 100644
--- a/lib/src/union_set_controller.dart
+++ b/lib/src/union_set_controller.dart
@@ -27,7 +27,7 @@ class UnionSetController<E> {
   UnionSet<E>? _set;

   /// The sets whose union is exposed through [set].
-  final Set<Set<E>?> _sets = <Set<E>>{};
+  final _sets = <Set<E>?>{};

   /// Creates a set of sets that provides a view of the union of those sets.
   ///
diff --git a/lib/src/wrappers.dart b/lib/src/wrappers.dart
index a95eefc..87b7f13 100644
--- a/lib/src/wrappers.dart
+++ b/lib/src/wrappers.dart
@@ -801,7 +801,7 @@ class MapValueSet<K, V> extends _DelegatingIterableBase<V> implements Set<V> {

   @override
   void retainAll(Iterable<Object?> elements) {
-    Set<V?> valuesToRetain = Set<V>.identity();
+    var valuesToRetain = Set<V?>.identity();

In each case, it looks like it will actually be ok. These are all cases of where the algorithm did the wrong thing and so it is an improvement to not propagate that.
However, the algorithm is defensible in each case:
  List baseList = List<E?>(10); // nullable because of initial capacity
  ...
  Set<E?> set = SplayTreeSet<E>();
  ...
   // baseList won't contain null here, but migrator thinks it may
   set.add(baseList[x]);

  Set<Set<int>?> _sets;
  ...
  foo(Set<int>? other) {
    _sets.add(other);
  }

...

// in tests
group("foo", () {
  // nullable because not initialized
  Set<int>? set;
  init(() {
    set = {};
  });

  ...

  test("bar", () {
    // won't be null here
    UnionSet().foo(set);
  });
  ...

```dart
  Map _baseMap;
  ...
    if (!baseMap.containsKey(k)) continue;

    // At runtime, baseMap[k] will not return a nullable value. The tool things it may.
    valuesToRetain.add(baseMap[k]);

There are two narratives one can draw here:

It's good we didn't further propagate the non-nullability, because the non-nullability was wrong
We propagated the nullability because we didn't want to change behavior. By not propagating the nullability to the list literals, we have added nullabilities that don't do anything, and we risk changing behavior anyway.

Personally I'm in camp 2 here

List<Result<T>?> results = <Result<T>>[];

This is guaranteed to err at runtime.

This assignment won't err at runtime. The type List<T?> is a supertype of List<T>, so the assignment still succeed due to covariant generics.
It will still fail when you try to add null to the list.

As of 1c7fe7196dd7a542f7f91cd6ea2ac81e1a13146c, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.
If you still need help, or you believe this issue has been closed in error, please feel free to reopen.


Using the engine’s npm run develop command doesn’t watch for changes

Here’s the command as it is now:
https://github.com/cloudflare/cloudflare-docs-engine/blob/765bc30127b0e80b570aade7044036925928c3ea/bin/commands.sh#L63-L74
What it does is it copies the host project’s content into the engine’s .docs/src/content directory and then runs npm run develop in there. The problem with this is that changes to content inside src/content aren’t watched by the npm run develop watcher inside .docs.
A quick-ish hack would be to have the engine run its own watcher when you run npm run develop, and have it re-run copysrc on changes to src/content, copying files into .docs/src/content which would kick off the watcher in there. This seems like a really bad approach which is why we have not implemented it yet.
While no solution we’ve found yet is ideal, one current workaround is to run npm run develop and then once it’s running, make your changes to .docs/src/content. These will be watched by the internal npm run develop’s watcher, and everything will function normally as developers are used to. The big caveat is that once you’re done with all of your local changes, then you need to _manually copy .docs/src/content back into src/content. Worse, if you accidentally run npm run develop again (in the root) you’ll end up overwriting what you had been working on inside .docs/src/content when copysrc is called. So yea, pretty gross.
The more straight-forward alternative is to simply cancel and re-run npm run develop every time you want to see your changes. The problem with this of course is it’s slow, requiring Gatsby to start up again each time, and labor intensive as it requires you to manually run a command to see changes rather than see them change immediately.
All of this is to say, the current local development setup needs work.

As a temporary workaround, we’ve added the npm run savechanges command (see https://github.com/cloudflare/cloudflare-docs/commit/0dd348cfae223d4be8faa4af63ccd84a79922d03) to make it easier to copy changes from .docs/src/content into src/content.
https://github.com/cloudflare/cloudflare-docs-engine/blob/db743a0183f161fd58cced63d6c90c72fac3b422/bin/commands.sh#L104-L108

Here's how I get around this issue:

I work entirely outside of the .docs folder
In parallel I run npm run develop and watch rsync -av src/content/ .docs/src/content

The second command  syncs everything from the main location into .docs and if I remove or add folders it takes care of the sync. So I can move things around and delete while working no problem.

$


[Snyk] Upgrade date-fns from 2.29.1 to 2.29.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade date-fns from 2.29.1 to 2.29.2.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 22 days ago, on 2022-08-18.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
Base: 82.03% // Head: 82.03% // No change to project coverage :thumbsup:

Coverage data is based on head (994748f) compared to base (a824690).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   82.03%   82.03%
=======================================
  Files          31       31
  Lines         412      412
  Branches       59       59
=======================================
  Hits          338      338
  Misses         68       68
  Partials        6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Allow "parametrised" imports

Web bundlers such as vite or webpack, allow adding "query strings" to import paths to trigger special behaviour.
For example, vite has a built-in feature to load any file as string by appending ?raw to the module path.
I fixed that on a branch and will be happy to submit a PR once #4 is merged

Ah, good call. I haven't used that feature in Webpack in a few years, so I didn't consider it, but I think that's a good addition.


add vpc and subnet options

In mainForm.pyline 130:
                global SELECTED_BUTTON
                if act_on_this == 'INSTANCES' or act_on_this == 'SECURITY':
                    SELECTED_BUTTON = 8
                else:
                    SELECTED_BUTTON = self.cursor_line
                self.form.reload()

This has not been updated... The idea beeing that you click on something with specific buttons then the grid is loaded and the first specific button selected.
i.e. Click instances then the selected button should be create new ... You might add it to other  fields....


IPv6 support

NetBIOS names and IPv4 are supported at the moment, but no IPv6.

I do not know if/how NetBIOS works with IPv6, but I proposed an alternative PR to allow fs.smbfs to support IPv6 by improving pysmb: https://github.com/miketeo/pysmb/pull/183

Great, thanks! I'll push a patch release that adds support for the v1.2.7 of PySMB, which contains your changes.


Propagate authentication method claims in openid token

It is sometimes required by applications to be able to know whether a user authenticated using multi factor authentication, or regular password flow. Following related discussion during the cfsummit uaa office hours, I'm submitting this issue to pursue discussion around this topic.
The ODIC specifies into http://openid.net/specs/openid-connect-core-1_0.html#IDToken the optional
amr
    OPTIONAL. Authentication Methods References. JSON array of strings that are identifiers for authentication methods
   used in the authentication. For instance, values might indicate that both password and OTP authentication methods were used.
   The definition of particular values to be used in the amr Claim is beyond the scope of this specification.
   Parties using this claim will need to agree upon the meanings of the values used, which may be context-specific.
   The amr value is an array of case sensitive strings.

Additionally, http://self-issued.info/docs/draft-jones-oauth-amr-values-04.html proposes some further normalized value.
In case the IDP provided normalized authentication method (e.g. a SAML IDP in SAML assertions, or an OIDC IDP in a idtoken), could this be mapped (if a translation is needed) and propagated into the openid id token ?
As a side question, in case the user identity (and its authentication method) needs to be propagated through a chain of webservices backends, using http://docs.cloudfoundry.org/api/uaa/#api-flow to exchange tokens (swapping clientid and possibly reducing scopes), should the amr be added to the access token (as a custom non standard extension) ?

@gberche-orange Thank you creating the issue.
I will get this prioritized.

@sreetummidi thanks for implementation of the related story, and filling the amr field in the id token
One question though, how would the AMR be propagated to a chain of backend when exchanging tokens through the api flow http://docs.cloudfoundry.org/api/uaa/#api-flow which expects a token bearer as authentication (and no an id token if I'm understanding this correctly) ?

@gberche-orange
If authentication was done through UAA Internal Auth then we set the AMR to pwd
If the authentication was done thru an external SAML provider we ACR instead of AMR as SAML passed Authentication Context Reference value
If the authentication was done thru an external OIDC provider we set the AMR to be the same as set by the external OIDC provider

This story has been picked up and will be available as part of UAA 3.8.0


add support for parsing rOBJ and rCAM chunks

This module currently supports parsing all chunks/data defined in https://github.com/ephtracy/voxel-model/blob/master/MagicaVoxel-file-format-vox-extension.txt except for rOBJ (render settings such as sun position, fog etc) and rCAM (camera settings).
This PR adds support for those missing chunks. Rather than exposing all the props as nice structs, I've followed the basic dict style that the scene graph PR used. I think this makes sense for consistency, and it's easy enough for the developer using this library to consume these dicts however they like.
With this change, the api includes .render_objects and .render_cameras accessors.
Please let me know if any changes are needed and I'm happy to keep working on this! Thanks :)

Notes
In encountered a few weird issues when trying to write tests for these modern features of MagicaVox. It looks like none of the test files include these chunks, so I added a new placeholder-with-render-objects.vox created with v0.99.6. However it exports the voxels in a different order to previous versions. Rather than updating all the old placeholder tests to new order, I just opted to only test the parsing of the new chunks in the new tests.
This PR also changes some debug code that was causing my compiler to complain:
if let Some(w) = w && (w < 0.0 || w > 1.0) {
  debug!("_weight observed outside of range of [0..1]: {}", w);
}

error[E0658]: `let` expressions in this position are unstable

I assume this is due to my use of an older version of rust, but it seems unnecessary to break compatibility with older versions just for a simple syntax cleanup for a debug feature, so I replaced the code with one compatible with older rust versions.

I have considered when using this API that it might be better if render_objects was grouped by type as a HashMap instead of Vec. Also it possibly should be called render_settings, however the way it is in the PR right now is the closest to the spec doc.

Hmm, I see that this repo seems to be in the middle of a big refactor so I get if this isn't high priority for now.
I see that a lot of the scene graph stuff seems to be getting replaced with actual struct types. This makes sense, but kind of means that my implementation in this PR is now out of date.
Looks like i'll need to depend on my own fork for now. Awesome to see the changes that dust-engine is bringing to this module, but yeah, obviously not actually ready yet! Let me know if I can help at all, I am also heavily relying on this module for a project that fully imports MagicaVoxel scenes into a 3D engine.

@mmckegg Thank you for your contribution! You're correct that the library was undergoing a bit of work.
Regarding your comment on _type, I think this is one of those cases where "the spec is the implementation". I think it would make sense for this to be a dictionary as well.
You can insert some assertions here, and if in the future we have reports of MagicaVoxel producing multiple items for the same _type we can always change it later on.
Regarding whether an item should be a struct or a dictionary: For now, if the spec specifically enumerated the possible attributes, let's turn it into a struct. Otherwise, keep it as a dictionary. That means "rCAM" should be a struct, but "rOBJ" shouldn't.
Thanks again! I'm planning to cut a release soon - let's see if we can include this in the next release.

Okay thanks @Neo-Zhixing, I'll take another look at this in the next few days. Not sure if it'll make the release in time, so let me know if you just want to take it over and clean it up yourself. Absolutely happy to do it though, just a bit short on time right at this minute.


delete grammar from table is not user-friendly

CREATE TABLE `test` (
    `k1` tinyint(4) COMMENT "",
    `k2` smallint(6) COMMENT "",
    `k3` int(11) COMMENT "",
    `k4` bigint(20) COMMENT "",
    `k5` decimal(9, 3) COMMENT "",
    `k6` char(5) COMMENT "",
    `k10` date COMMENT "",
    `k11` datetime COMMENT "",
    `k7` varchar(20) COMMENT "",
    `k8` double MAX COMMENT "",
    `k9` float SUM COMMENT ""
) ENGINE=OLAP
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
    "storage_type" = "COLUMN",
    "replication_num" = "1"
);

I have a table test without partition. If I want to delete data where k1 = 1, the SQL is like this:
delete from test partition test where k1 = 1;

where partition test is necessary.

@morningman


npm scripts doesn't terminate when you run them as task

VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T21:22:49.932Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

gitlens
eam
6.0.0

tslint
eg2
1.0.21

Angular2Tests
Mar
0.7.3

mssql
ms-
1.2.1

debugger-for-chrome
msj
3.5.0

wallaby-vscode
Wal
1.0.65

Steps to Reproduce:

Create an empty package.json with this content

{
  "name": "test-bug",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "build": "echo 'done'"
  },
  "author": "",
  "license": "ISC"
}

Press CTRL+SHIFT+B and select npm:build task
Task starts but it doesn't terminate. You have to manually terminate task clicking bin button and when you click on bin button this error appears

Reproduces without extensions: Yes

Dups #37934


Better radio input

Hi! Radio inputs looks different than older Bootstrap versions. Small upgrade with fix.

According to this codepen made by @mdo, we could also keep the current background image svg (with radius 3) and change the $form-check-input-checked-bg-size to calc($form-check-input-width - .5em). The look seems a little bit better with big font-size values.


Deprecation timeline README changes

Fixes #16720
Initial documentation update. Trying to reflect here what we've agreed on by a simple majority.
Wording changes, or any other change suggestions are very welcome!
The goal here is to get out an official update ASAP, so that we can not only close related pull requests but do it with some info about why, and what to do instead (create a new Helm repo, and open a PR on Helm Hub. See https://github.com/helm/charts/issues/7800 for this one. People still need help knowing how to do that. This issue is just to document the deprecation timeline).

lgtm

/lgtm

/hold

/lgtm

/lgtm

/unhold


pkg/node: fix nil pointer dereference in non-IPv6 node

If a node doesn't have any IPv6 address cilium can panic while trying to
delete the IPv6 routes of that node.
Signed-off-by: André Martins<EMAIL_ADDRESS>Reported-by: Markus Padourek<EMAIL_ADDRESS>pkg/node: fix nil pointer dereference when deleting IPv6 route for non-IPv6 node

test-me-please


Pluggable modules

:tada: This PR is included in version 3.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Point $HOME to /tekton/home

/builder/home is still mounted, backed by the same volume, to allow
users some time to move over before we move /builder/home in v0.10 and
beta.
More progress toward #1030
This is step 1 of a breaking change, since some users might unfortunately rely on the specific path that we document. We'll warn people in v0.9 release notes that the path is changing, and remove the old path in v0.10.
Users who rely on $HOME will not be affected (that points to /tekton/home after this change)

Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[y] Includes tests (if functionality changed/added)
[y] Includes docs (if user facing)
[y] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
:rotating_light: Change $HOME to /tekton/home

/builder/home is still provided, backed by the same volume, but will be removed in a future release

/lgtm

/hold cancel


Is there a way to convert AVI to MP4 on the save function ?

Feature Request
I've found this:
https://stackoverflow.com/a/32391332/11700502
I tryed to implement but i don´t have skills on Obj-c.
Could someone helps me ?
thanks

Why it is needed
Because AVI is not suported on IOS

Hi @brunodias28, closing this issue as video format conversion outside of the scope of this project. You might have better luck asking this question on stackoverflow or in the reactiflux react-native channel.


amplify configure: "aws_access_key_id" and "aws_secret_access_key" have replaced to true and name of my profile wrapped with doublequote

Describe the bug
I have several profiles in .aws/credentials.
after I use cli amplify configure and create a new IAM user,
some of my existed profile's aws_access_key_id and aws_secret_access_key have replaced to true
and also wrapped with doublequote except IAM user which is newly created
I attached this situation in Screenshots section
Amplify CLI Version
4.6.0
To Reproduce

$ amplify configure
add new IAM user

Expected behavior

input several profiles in .aws/credentials.
use amplify configure cli and create a new IAM user called aws-gs
check  aws_access_key_id and aws_secret_access_key have replaced to true and also name of my profile wrapped with doublequote

Screenshots
"[404hunter-root]"=true
aws_access_key_id=****
aws_secret_access_key=****
"[404hunter-geoseong]"=true
"[ideasam-geoseong]"=true
"[changsoft-geoseong]"=true

[default]
aws_access_key_id=****
aws_secret_access_key=****

[aws-gs]
aws_access_key_id=****
aws_secret_access_key=****

Desktop (please complete the following information):

OS: Mac
Node Version: v10.15.3

@geoseong I could not reproduce this. Could you share the name of the profiles you had before running amplify configure

@yuth
name of the profiles is in Screenshots section posted above here.
I haven't backed up my credentials file so I recovered and tried to reproduce this issue, that problem haven't occured...
it is weird... can you provide code path which handle aws profile in amplify-cli?

The code that updates the credentials should be somewhere in this file
https://github.com/aws-amplify/amplify-cli/blob/dcee2aab12b40562d1c6f0d260b830ca4ab0bedd/packages/amplify-provider-awscloudformation/lib/system-config-manager.js#L14-L59

@geoseong We weren't able to reproduce this issue. If you're able to reproduce this issue with any other profile name, please let us know. Closing this issue for now.


willSelectRowForItem and willDeselectRowForItem

Methods willSelectRowForItem and willDeselectRowForItem must return nullable value (you wrote in comments that they can return nil), to have optional value in Swift (Any?)

I am using Ra Tree View Controller. It's working far fine in iOS 10 versions, but having alot of scrolling and tapping gestures issues in iOS 11 (Xcode 9.0). Wishing to fix these issues. Moreover, is there any possible to expand only one row at a time? On tapping other row, it will automatically collapse other rows.
I am using these delegates but they are not working good, as I wish to collapse and close all other rows and just expand one row per time.
[_treeView collapseRowForItem:lastSelectedPoint withRowAnimation:RATreeViewRowAnimationNone];
[self treeView:_treeView willCollapseRowForItem:lastSelectedPoint];
By over-riding these delegates, I am trying. They are working very close but in few cases they are not working.
Also, fix bugs for iOS 11.
Thank you.


Issue #142, Material Design

#142 NOTE:

Please fill out the template below

Did you read the instructions in the README?

Y

Have you read the instructions in CONTRIBUTING?

Y

Have you written this article by yourself? Have you taken inspiration from anywhere and then written it in your words?

I've written this article by myself after going through material design specs & various other online resources.

@RN0311 please review this

@pbiswas101 : Beautifully fabricated!
@the-ethan-hunt : Reviewed.


[release-1.23] etcd snapshot issues with compression and timeout

Backport to release-1.23:

#5839

Validated on release-1.23 branch commitid ea29d624ad95a27b8293be23941a73612469c32f
Environment Details

Infrastructure

[x] Cloud (AWS)
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

Ubuntu 22.04 LTS
Cluster Configuration:

1 server
Config.yaml:

write-kubeconfig-mode: 644
token: test
cluster-init: true
etcd-snapshot-compress: true
etcd-s3: true
etcd-s3-bucket: maxrtest
etcd-s3-folder: maxk3s
etcd-s3-region: us-east-2
etcd-s3-access-key: "<redacted>"
etcd-s3-secret-key: "<redacted>"
etcd-snapshot-retention: 4
etcd-snapshot-schedule-cron: "*/2 * * * *"

Additional files

N/A
Testing Steps

Copy config.yaml

$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s

Install k3s
Monitor both the the k3s logs and the designated s3 bucket

Replication Results:

k3s version used for replication:

v1.23.8+k3s2

Snapshots are not saved as zips when defined in the config yaml

Jul 14 21:12:00 ip-172-31-46-97 k3s[43019]: time="2022-07-14T21:12:00Z" level=info msg="Uploading snapshot /var/lib/rancher/k3s/server/db/snapshots/etcd-snapshot-ip-172-31-46-97-1657833120 to S3"
Jul 14 21:12:00 ip-172-31-46-97 k3s[43019]: time="2022-07-14T21:12:00Z" level=info msg="S3 upload complete for etcd-snapshot-ip-172-31-46-97-1657833120"

Validation Results:

k3s version used for validation:

commit `ea29d624ad95a27b8293be23941a73612469c32f`

Snapshots are saved with zips when defined in the config yaml
On demand snapshots continue to work and save as zips when defined
Logs show snapshots being saved as zips

Jul 14 20:56:00 ip-172-31-46-97 k3s[40088]: time="2022-07-14T20:56:00Z" level=info msg="Uploading snapshot /var/lib/rancher/k3s/server/db/snapshots/etcd-snapshot-ip-172-31-46-97-1657832160.zip to S3"
Jul 14 20:56:00 ip-172-31-46-97 k3s[40088]: time="2022-07-14T20:56:00Z" level=info msg="S3 upload complete for etcd-snapshot-ip-172-31-46-97-1657832160"

When compression flag is not defined in the config, snapshots are not saved compressed as expected


⚠ Bofrost.at has degraded performance

In 32addcc, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2154 ms

Resolved: Bofrost.at performance has improved in 4ad6fa8.


position: initial; -

position: initial; - https://developer.mozilla.org/en-US/docs/Web/CSS/initial

This issue was imported from Google Moderator
Moderator votes: +4
Issue added by csscallum on 2014-02-14
To vote this issue up or down, simply include +1 or -1 in your comment.

Duplicate of #1016.


Not Detecting Visual Studio 2008 (Version 9)

I ran vswhere and it is not returning any information for VS2008.
I a couple of combinations "vswhere -legacy", "vswhere -all" and even "vswhere -legacy -all".
I get results for VS 10 *installationVersion: 10.0) but not 9.
Am I missing something?

Feedback for vswhere should go to https://github.com/microsoft/vswhere; however, it only detects back to VS2010. VS2008 is out of support.


set_deferred method is invalid

Godot version
4.2 Dev 2
System information
Win10
Issue description
An area node, and setting area.set_deferred ('monitoring', true) in gdscript,and then 4.2 Dev 1 and below are no problem.
Updating to Dev2 failed, and tests found that setting other properties was also ineffective, such as Sprite2D.set_deferred('position', Vector2(100,100))
Steps to reproduce
add area node in scene
write the code in _read callback
func _ready() -> void:
	area_2d.set_deferred('monitoring',true)

run,observe the node properties in the property inspector
Minimal reproduction project
test_bug.zip

Caused by #78987, cc @RandomShaper.
CallQueue::push_set creates a Callable with the property name passed as the method. :upside_down_face:
https://github.com/godotengine/godot/blob/031aa99d313ceec7cdb8263957d22cae10de0b95/core/object/message_queue.cpp#L165
Hence for such message the added check fails as object doesn't have such method:
https://github.com/godotengine/godot/blob/031aa99d313ceec7cdb8263957d22cae10de0b95/core/object/message_queue.cpp#L324
https://github.com/godotengine/godot/blob/031aa99d313ceec7cdb8263957d22cae10de0b95/core/variant/callable.cpp#L128


Replaced assertRaisee with assertRaisesMessage in tests.admin_autodiscover.tests.

@hramezani Can you explain what this change fix?

@hramezani Can you explain what this change fix?

Sorry, it was wrong. I changed the title.
There are more tests like this. We can keep open the PR, K will fix them as well.

@felixxm I replaced assertRaisee with assertRaisesMessage in more tests.
There are still more that can be replaced but need more changes, So I haven't changed them.

@hramezani Thanks :+1: I think it's worth to merge this. I pushed a few more.


LinkPlugin links wrong behaviour

Hello, found a bug that adding a link to inline text would result updating entity, but href on link would be same as text.
For example decorating text "github.com" with "google.com" link would result link to github.com, which seems like a wrong behaviour.

All fixed now in version 1.2.2 of the link plugin
Check out https://github.com/vacenz/last-draft-example-v3 for an example of use.
Sorry I didn't get to use your pr, I had a lot of work to do updating to the latest version of draft-js-plugins and draft/react so this was too out of date for me to rebase. Thanks a lot for picking it up and your work, made it east for me 👍


Implement extensions directly on Instance/Device instead?

Currently, Ash has separate structures for each extension, which means each one has to be loaded and kept around by the user. This is a bit awkward if there's many extensions involved, so what if the extension functions were implemented directly on Instance and Device instead? The user would only have to keep these two structures around for all their use cases.
These two objects would initialise the function pointers of all extensions internally when they are created. This is allowed by the spec; the spec dictates that asking for the pointer to an extension function that has not been requested at create time should return a null pointer. Ash itself already does this for the Vulkan core functions, which are all loaded regardless of whether the user created their Instance for that version.
If this is done, I also suggest getting rid of the DeviceV1_0 trait and others like it, and implementing functions (both core and extension) as inherent methods on Instance and Device. These traits add extra flexibility but I'm not sure if that's actually needed for most people. And if each extension is going to be represented as a trait on Instance or Device, those two types end up with a very long list of trait implementations. You could keep the functions for returning the raw function pointer structs as they are now, or expose each function struct member of Instance and Device to the user directly; the latter has my preference.

Yes this is something I have been considering for a while and will most likely change with #344

Would it be ok if I made this change manually in a PR for now? Assuming the generator rewrite will take a while.

Would it be ok if I made this change manually in a PR for now? Assuming the generator rewrite will take a while.

That would be nice

You could keep the functions for returning the raw function pointer structs as they are now

This would be my preference, keep it as it is now and just move the trait impls to a normal impl block.

I remain a fan of how Option<Extension> makes it easy to correctly handle extensions that you support but do not require, which comes up constantly with the debug extension.

But I do believe that is something for the crate user to specify in their own code. I don't want to expect/unwrap Option anywhere (or store a duplicate without Option outside of ash::Device) if there are certain extensions that my application requires and does not / should not start without. That's not ergonomic IMO.

I'm skeptical that these are a realistic threat.

I'm not sure whether drivers prefer to perform extra loading/work during instance/device creation when the extensions are passed, or when a function is loaded. Neither seem to be slow on any driver that I've tried but given past/open issues Ash is used in quite a few embedded scenarios for which we should provide an as bare-bones setup as possible, IMO.

But I do believe that is something for the crate user to specify in their own code

Yes, strongly agree.


When errors occur in a batch, only last one is visible, masking the original cause of the failure

When batch execution fails, we usually want to see the first failed statement. The subsequent failures can be caused by the first one, but in the exception thrown the (irrelevant) information of only the last failure is available.
Note the following line:
https://github.com/microsoft/mssql-jdbc/blob/05ef7c07d184e9f8b659c351f68599b1a94132e3/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerStatement.java#L1879
Our scenario:

We are using SET IDENTITY_INSERT .. ON in one batch with INSERTs to fill a table with IDENTITY fields.
Insertions fails somewhere in the middle of the batch because of constraint violation.
But what we see in exception is "Cannot insert explicit value for identity column", which has nothing to do with the real cause of the error.

Can we change the logic of error handling so that the first failure in the batch is saved and is used when building BatchUpdateException?

Hi @inponomarev,
We'll look into this. You make a good argument around how returning the last known error can mask the actual problem, but we'll have to take a look into the impact this has on other workflows. Thanks for the PR as well, we'll take a look into that too.

Apologies, this is a common issue that I failed to recognize. Use getResultSet and getMoreResults to process the response and see all the errors returned. For more information, please see: https://learn.microsoft.com/en-us/sql/connect/jdbc/using-multiple-result-sets?view=sql-server-ver16

Hi @Jeffery-Wasty thanks a lot for your quick replies!
As I figured out, indeed, the individual errors are visible. In our particular case we're using jOOQ and we're able to intercept all the errors in the batch via ExecuteListener.exeption(...).
However it would be nice if you considered the change of the driver's behaviour. Now the exception that causes program termination may contain the irrelevant information, which is bad. The choice of the last error for the exception message seems to be just arbitrary.
Can we consider either reporting the first error in the batch or at least giving a hint that more than one error occurred in the batch?

Hi @inponomarev,
Glad to hear that you're able to see all errors. The driver is used by many people and organizations, and a fundamental change to its behavior would need to be well warranted. Additionally, there are other workflows that depend on the last error message, which was a reason behind the initial decision. As long as the first error can be seen, we see no problem, and no changes are needed for the driver.
If you have any additional questions, please let us know, otherwise we'll move forward with closing the issue.

@Jeffery-Wasty I fully understand the danger of breaking things. However let us spend a bit more time considering this issue, maybe we still can improve something here.
If there are reasons to show exactly the last error (I hope that there are reasons indeed, and  it's not just your guess that there are such reasons) -- ok let's keep the last error then.
But can we tweak the error's message itself so that it will contain an information like "%d errors occured, the last one: %s"? All the other exception properties may remain the same.
Since error message text is used by humans, not by scripts, I believe this can significantly improve the speed of debugging.
The initial problem that I faced was the completely misleading error message in the log.


styles passed into styled(Component) don't overwrite base styles

Environment
npx envinfo --system --binaries --npmPackages styled-components,babel-plugin-styled-components --markdown --clipboard - zsh: command not found: npx
Reproduction
https://codesandbox.io/s/k51yyo4v35
Heading.js
import * as React from "react";
import styled, { css } from "styled-components";

const Wrapper = styled.h1`
  margin-top: 0;
  margin-bottom: 0;
`;

export const Heading = props => {
  const WrapperWithAnotherTag = props.tag && props.tag !== "h1"
      ? Wrapper.withComponent(props.tag) : Wrapper;

  return (
    <WrapperWithAnotherTag className={props.className}>
      {props.children}
    </WrapperWithAnotherTag>
  );
};

Index.js
import React from "react";
import ReactDOM from "react-dom";
import styled, { css } from "styled-components";

import { Heading } from "./heading";

const Name = styled(Heading)`
  margin-bottom: 10px;
`;

function App() {
  return (

      <Name>Here is a title with margin</Name>
      <Name tag={"h2"}>Here is a title without margin -_-</Name>

  );
}

const rootElement = document.getElementById("root");
ReactDOM.render(<App />, rootElement);

Expected Behavior
<Name tag={"h2"}>Here is a title without margin -_-</Name>

should have margin-bottom
Actual Behavior
<Name tag={"h2"}>Here is a title without margin -_-</Name>

Doesn't have margin-bottom because it doesn't overwrite base styles
P.S. it is simplified example!

Alright so the issue here is related to the order of composed classNames. If you inspect the H2, the CSS for margin-bottom: 10px is there but is being overridden by the base component styles due to how s-c is composing the passed class name vs the class name it injects itself.
@kitten @mxstbr do you guys remember why we put the SC classnames last instead of first?

I just ran into this and while I understand the cause and the solution, the solution feels like a workaround for unexpected behavior. I would expect that styles for an extended component always follow the styles of the base component -- that's the whole point of extending.

I agree with @stonebk . This should be default behaviour and this issue should be reopened.

The "&&" trick is no help.
If I use regular CSS, or style tags, I can set the style, but if I use styled-components the styles get overridden for some reason even if I use "!important". This is with hardly anything else on the page.

Agree, this seems like odd behaviour.

This seems to work as expected in v3. After I updated to v4 styles doesn't applies in right order. This should be reopen.

What is the current state of this?

I still have this issue, specifically with a third party styled components framework. (react-bulma-components)

Still happening here

Still happening and does not fixed in 4.2.1
Why issue is closed?

@RellaxxDev this issue is resolved. We still maintain specificity as we have always in all versions which is now going to be improved in v5.
Anyway, in the example withComponent is called dynamically during the runtime. This creates a new StyledComponent on every render. Since we order by creation order that does mean that after creating a new component the order will be the opposite of what the CodeSandbox here expects.
We introduced the "as" prop to solve this.

Is this "resolved" means to be in v5? Problem still occurs on 4.3.2. Thanks!

Not working, even with &&

The solution that worked for me was to pass the className prop into the styled component you wish to override. Thanks StackOverflow!

The solution that worked for me was to pass the className prop into the styled component you wish to override. Thanks StackOverflow!

That's a different issue. The above issue is understanding that you can pass a class name into the component, the issue arises when we have multiple levels of class names of the same specificity.
Example follows:
const ComponentA = styled.div`
  width: 100%;
  height: 100%;
`

function ExtendedComponent({ className }) {
  return <ComponentA className={className} />
}

const StyledExtendedComponent = styled(ExtendedComponent)`
  width: 50%;
`

width: 50% will not be applied in this case.
width: 100% will be applied.
To fix the issue we currently have to use:
const StyledExtendedComponent = styled(ExtendedComponent)`
  && {
    width: 50%;
  }
`

This really seems like a bug rather than a feature

In my case,
const Title = styled.h2`
  font-size: 20px;
  color: ${({ theme }) => theme.colors.darkGrey};
  height: 38px;
  font-size: 28px;
  font-weight: 300;
  line-height: 38px;
  margin-bottom: 20px;
  margin-left: 20px;
  width: calc(100% - 20px);
  padding: 0;
`;

const PageTitle = styled(Title)`
        text-align: center;
`;

Doesn't work; nor does using && change anything. Text-align: center doesn't show up in any style sheets as rendered in my FireFox browser. For me, it's as if the PageTitle stylesheet is never built. Furthermore there is no prior text-align competing with it.

In my case, though the style is generated:
.jrJmTH{text-align:center;color:red;}

The actual element is not assigned that class:

Add New User

Same issue in the latest code

Going to lock this as the OP issue has been resolved. Please make a new issue with reproduction if necessary.


added tests to the ts-app for json body, query, and path params

added the test case as requested to the typescript app.. simple, but at least it'll fail if somehow those signatures change in the future.

Please squash commits.

Looks like this PR has been abandoned.


Gatebreaker

Resolves #9.
Adds a new option to allow aborting the pipeline when quality gate is not met.
If gatebreaker option is enabled, the step will wait until the analysis report was processed by the server and check the state of the quality gate.
The state of the Quality Gate is fetched via the Web API. I'm using a forked and slightly adjusted version of https://github.com/magicsong/sonargo which is needed to work with the current Sonar version.
Container with binary available at https://hub.docker.com/repository/docker/saitho/drone-sonar-plugin

Thanks for your pr.
Please fix the conflict before I could merge it.

Hey there,
sorry for the late reply. I rebased the branch, but I wasn't able to test it yet...
I'm now using the official repository of sonargo, as my pull request there was merged.
Building the binary locally works fine, but using the Dockerfile it says that it couldn't find the package. :(

Could you merge this ? @roganw

Hello,
@roganw Is there any chance of this being merged anytime soon


Remove Campus Facilitator from Project List

Remove Campus Facilitator from Project List:

Validated that the Campus Facilitator field is no longer on the Project Details List
https://docs.google.com/spreadsheets/d/1kDlD1jvFjbBhtBgEXI1najTKH6EVz-OvjXULBhIfI7w/edit#gid=547627265


Retry on "Could not read schema from HTTP, response status is 503 Service Temporarily Unavailable"

Recently, I randomly started to encounter the 503 error when validating against local schemas (ByteLoader) that appears to reference remote schemas (over http)... I did not realize I was for some time that this error was likely due to being on an unreliable Wifi network...
Would there be a way to add a "retry" (default 3x or configurable) to any external HTTP loads of ref. schemas?
OR even better, allow for me to tell the loader to NOT find the schemas at their remote (http) locations, but instead find them locally (i.e., I would likely include them as a Go embedded resource along with the base schemas that reference them)?

The second option... i.e., to effectively tell the loader to resolve http to local is highly desirable in "closer" build systems where external network access is intentionally shut off.

+1 to the resolve http to local or embedded. I'd be happy to create a PR for this would be accepted upstream?


Remove ReporterInput.packageConfigurationProvider

This PR first of all ensures that the evaluator and reporter and list-copyrights commands add all package configurations to the OrtResult before passing it around, and applies resulting simplifications.
This prepares for changing OrtResult.getIssues() to filter the issues by path excludes in a following PR.
As a I nice side effect, package configurations are now only resolved once per CLI command run instead of multiple times.
Part of #7921.

FYI, the SPM test update is part of my https://github.com/oss-review-toolkit/ort/pull/8119.


Old data is not deleted

Description
When working with test data you can clear all data from dashboard, but the plugin does not clear all the models from db when sync.
It happens with

customers
invoces

Steps to reproduce

Sync your data from stripe
Clear your test data
Sync again and old (non existing) invoces are not deleted from db

Additional info

Craft version: 5.4.9
PHP version: 8.2
Database driver & version: Mysql
Plugins & versions: 1.1.0

Hi, thanks for reporting! I just raised a PR that adds a CLI command to clear all the plugin's data, which can be used e.g. after deleting the test data in Stripe dashboard.

Do you think this could happen in a production enviroment? Having duplicated subs it's very confusing

Stripe 1.3.0 is out with the new stripe/data/reset command.


Add Storage interface wiki article

Description of change
Add Storage interface wiki article. This embeds the Rust and TS MemStore examples, which were documented, so they are more helpful for readers looking for an example implementation.
This also gets rid of the index in the Rust MemStore, where the vaults can be used as an implicit index, just like in the TS MemStore already.
Links to any relevant issues
fixes #816
Type of change
Add an x to the boxes that are relevant to your changes.

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] Enhancement (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Fix

How the change has been tested
n/a
Change checklist
Add an x to the boxes that are relevant to your changes.

[x] I have followed the contribution guidelines for this project
[ ] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Change the target branch to support/v0.5.

@JelleMillenaar Addressed all your comments and added a brief overview at the beginning, I think that's a good idea.


Error: There is no user record corresponding to this identifier. The user may have been deleted.

Please fill in the following fields:
Unity editor version: 2018.3.4f1
Firebase Unity SDK version: 6.7.0
Firebase plugins in use (Auth, Database, etc.): Auth, RealtimeDatabase
Additional SDKs you are using (Facebook, AdMob, etc.): none
Platform you are using the Unity editor on (Mac, Windows, or Linux): Windows
Platform you are targeting (iOS, Android, and/or desktop): Android/iOS
Scripting Runtime (Mono, and/or IL2CPP): I really dont know...
Please describe the issue here:
When I try to log in using firebase, I recieve this error:
I have tried to create delete and create users, and also create a whole new Firebase project...
Failed to access task with System.AggregateException: One or more errors occurred. ---> System.AggregateException: One or more errors occurred. ---> Firebase.FirebaseException: There is no user record corresponding to this identifier. The user may have been deleted.
   --- End of inner exception stack trace ---
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.AggregateException: One or more errors occurred. ---> Firebase.FirebaseException: There is no user record corresponding to this identifier. The user may have been deleted.
   --- End of inner exception stack trace ---
---> (Inner Exception #0) Firebase.FirebaseException: There is no user record corresponding to this identifier. The user may have been deleted.<---
<---

UnityEngine.Debug:LogWarning(Object)
<DoAccessUser>d__10:MoveNext() (at Assets/FirebaseManager.cs:118)
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)

Few days ago I was able to log in without problem, and I haven't moved anything from my LogIn system.
Please answer the following, if applicable:
This is my code:
IEnumerator DoAccessUser(string email, string password)
{
    var auth = FirebaseAuth.DefaultInstance;
    var logTask = auth.SignInWithEmailAndPasswordAsync(email, password);
    yield return new WaitUntil(() => logTask.IsCompleted);

    if (logTask.Exception != null)
    {
        Debug.LogWarning($"Failed to access task with {logTask.Exception}");
    }
    else
    {
        Debug.Log($"Successfully access user {logTask.Result.Email}");
    }
}

What's the issue repro rate? (eg 100%, 1/5 etc)

Are you able to register new users? You said you tried to delete and create users, is is possible you've accidentally deleted the user you were using?


VueUiQuickChart    Version 2.3.24, legend display abnormal ，   2.3.17  not have this problem

2.3.17

2.3.24

Hi @salarxiao321
I cannot reproduce the issue using 2.3.24.
Please provide the config object you are using, and confirm you imported the css.

2.3.25   have fixed


lib/pq seems to have data corrupted between calls to scan https://github.com/lib/pq/issues/831

What version of Go are you using (go version)?

$ go version

go version go1.11.4 linux/amd64

Does this issue reproduce with the latest release? unknown
What operating system and processor architecture are you using (go env)?
go env
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/nlacey/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/nlacey/gocode"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build255173950=/tmp/go-build -gno-record-gcc-switches"

What did you do?
test.go.txt
table.sql.txt
I can use results of an empty interface and sql.RawBytes (as long as I don't call scan again)
Once I call scan again, it seems to some how corrupt the data from the previous call?
Even though I create bran new data for everything.
(Notice the simple string isn't corrupted, but the json data and uuid is)
test.go.txt
table.sql.txt
//create simple test table
CREATE TABLE IF NOT EXISTS test (
id uuid DEFAULT public.uuid_generate_v1() NOT NULL,
name text NOT NULL,
groups text[] NOT NULL,
jsonData jsonb NOT NULL,
PRIMARY KEY (id)
);
insert into test (name,groups,jsonData) values ('hi', array['hello'], '{"test":"s", "b":"c"}');
insert into test (name,groups,jsonData) values ('by', array['gone'], '{"test":"a", "b":"d"}');
package main
import (
"database/sql"
"fmt"
_ "github.com/lib/pq"
)
func main() {
db, err := sql.Open("postgres", "user=postgres")
if err != nil {
fmt.Printf("Invalid postgres connection string")
return
}
if err = db.Ping(); err != nil {
fmt.Printf("Unable to establish connection to postgresql %+v", err)
return
}
rows, err := db.Query("select id, name,groups,jsonData from test;")
if err != nil {
fmt.Printf("Unable to perform query %+v", err)
return
}
output := make([][]interface{}, 0)
for rows.Next() {
fmt.Println("Reading record")
tmpRow := make([]interface{}, 4)
for index := range tmpRow {
tmpRow[index] = new(sql.RawBytes)
}
err := rows.Scan(tmpRow...)
if err != nil {
	return
}

//Print object inside for loop
for _, item := range tmpRow {
	fmt.Printf("\tinside loop item = %s  \n", item)
}

//Add current record to batch array
output = append(output, tmpRow)

}
err = rows.Close()
if err != nil {
fmt.Printf("error closing row %+v", err)
}
err = db.Close()
if err != nil {
fmt.Printf("error db close %+v", err)
}
//Print object outside for loop
fmt.Println("outside loop items")
for _, dbRow := range output {
fmt.Printf("\nrecords*\n")
for _, item := range dbRow {
fmt.Printf("\t %s", item)
}
}
fmt.Printf("\n Notice uuid, []text, and jsonb data are all corrumpted\n")
}
Output
Reading record
inside loop item = &b5d5cd04-36d1-11e9-a412-08002707b10f
inside loop item = &hi
inside loop item = &{hello}
inside loop item = &{"b": "c", "test": "s"}
Reading record
inside loop item = &c4cd3a0e-36d1-11e9-a412-08002707b10f
inside loop item = &by
inside loop item = &{gone}
inside loop item = &{"b": "d", "test": "a"}
outside loop items
records*
& 2d3a0e-36d1-11e9-a412-08002707b10f &hi &{gone} &"b": "d", "test": "a"}}
records*
& 2d3a0e-36d1-11e9-a412-08002707b10f &by &{gone} &{"b": "d", "test": "a"}
Notice uuid, []text, and jsonb data are all corrumpted
What did you expect to see?
I've used identical code for simple object types, but for []string or jsonb types it gets corrupted.
What did you see instead?
I expected the object I stored in an array to be the same after the second call to scan.

This may well be a bug in lib/pq?  I've created a ticket there too, but I want to cover my bases just in case this turns into some kind of language bug (garbage collection?).
Thanks!

The documentation says:

RawBytes is a byte slice that holds a reference to memory owned by the database itself. After a Scan into a RawBytes, the slice is only valid until the next call to Next, Scan, or Close.

You can copy the values if you need to keep the data.

This may well be a bug in lib/pq? I've created a ticket there too, but I want to cover my bases just in case this turns into some kind of language bug (garbage collection?).

It's hard to investigate whether this is a bug in language without a smaller, reproducible test case.
Let's wait on the outcome of lib/pq#831. If it turns out to be a bug in the Go compiler or runtime, we can re-open this issue with more relevant information.

Thanks for the help! How do I copy the value?
I tried the following
func cloneArrayInterface(input []interface{}) []interface{} {
output := make([]interface{}, len(input))
for index, val := range input {
b, ok := val.([]byte)
if ok {
c := make([]byte, len(b))
copy(c, b)
output[index] = c
} else {
fmt.Println("failed to cast")
}
}
return output
}
But I just get a mess of failed to cast?
Thanks

This appear to work for cloning the rawbytes data
func cloneArrayInterface(input []interface{}) []interface{} {
fmt.Println("cloneArrayInterface, ", len(input))
output := make([]interface{}, len(input))
for index, val := range input {
b, ok := val.(*sql.RawBytes)
if ok {
c := make([]byte, len(*b))
copy(c, *b)
output[index] = c
}
}
return output
}


ARROW-2852: [Rust] Make Array sync and send

Mark array as Sync and Send would be useful for multithread processing. It's also safe since they have no interior mutability.

@andygrove @xhochy Could you please help to review this?

@liurenjie1024 I'm not really comfortable in Rust. Maybe someone of the other people that previously reviewed Rust PR might give this a review. Then I would be happy to merge.

Do You have tests for it?

@kszucs I add some test for it now.

Hi @liurenjie1024 I have started reviewing this. I'd love to hear about your use case that is prompting this change so I can understand the motivation better.

@andygrove It looks like @liurenjie1024 is working on a time series analytic database in Rust: https://github.com/liurenjie1024/zeus

@wesm @andygrove  LOL. Yes I'm working on it and plan to use arrow as in memory data structures.

Thanks! Merging. The CI failure is unrelated. We should rekindle the Cargo / Rust release discussion


Location Based: content follows the camera when moving phone on y axis

see: https://github.com/jeromeetienne/AR.js/issues/710

fixed with aframe 1.0.4

fixed with aframe 1.0.4

Where is link to bug fix? I am having same issue of camera markers following camera

I have used these versons of aframe：0.9.2、1.0.4、1.1.0,but nothing changed,the 3d model follow my mobile all the time.

I have used these versons of aframe：0.9.2、1.0.4、1.1.0,but nothing changed,the 3d model follow my mobile all the time.


Modulus and phase application

This PR contains a new module which contain an application to compute simultaneously the modulus and the phase of complex image. These complex image can be:

a monoband image of complex pixel typ
two bands image of real type
two monoband images of real type

Technically we require RFC for this. I rebased your branch on develop, pushed it to our main git repo: https://git.orfeo-toolbox.org/otb.git/shortlog/refs/heads/app_modulus_phase, and added it to dashboard (it should be there tomorrow).
I also did a quick proof reading of the app documentation (I hope that's ok).
I wrote a draft RFC here: https://wiki.orfeo-toolbox.org/index.php/Request_for_Changes-83:_New_Modulus_and_Phase_application

I also did a quick test with an S1 image and it looks fine.
Ideas for possible future improvements:

Don't use BandMath for performance in the 2 input mode
Auto detect number of inputs (use an input parameter list)
Add option to output modulus in dB (amplitude vs intensity)

Currently failing on dashboard: https://dash.orfeo-toolbox.org/viewTest.php?onlyfailed&buildid=259828


TableClient.CreateIfNotExists should not return null

Library name
Azure.Data.Tables
Please describe the feature.
Currently CreateIfNotExists returns null when the table already exists. This causes a NullReferenceException when an implict cast is attempted by Response.
related to #25434

How can I know if a table has been created or not?
And all documentation still reports that "If the table does not already exist, a Response. If the table already exists, null." !
https://learn.microsoft.com/en-us/dotnet/api/azure.data.tables.tableclient.createifnotexistsasync?view=azure-dotnet


jaxb-api/2.3.0

Type: Missing
Summary:
jaxb-api/2.3.0
Details:
No info in package files. Meta data indicated MIT in POM file. However, when reviewing the URL to source repo, the author took liberties with the MIT license language. So, curated as OTHER.
Resolution:
https://repo1.maven.org/maven2/org/dspace/orcid-jaxb-api/3.0.0/orcid-jaxb-api-3.0.0.pom
https://repo1.maven.org/maven2/org/dspace/orcid-jaxb-api/3.0.0/orcid-jaxb-api-3.0.0.pom
Affected definitions:

jaxb-api 2.3.0

@TRQ3 You have mismatched info. The info provided is for org.dspace:orcid-jaxb-api:3.0.0 but submitted the changes to update javax.xml.bind:jaxb-api:2.3.0. If you meant org.dspace:orcid-jaxb-api:3.0.0, please close this PR and resubmit.


Account management page UI/UX improvement

Description
Basic QOL improvements

Team Profile Management now changed to Account Settings.
Uploaded image looking squished is now fixed.
Basic "choose file" is now replaced with a button. (Bootstrap style to keep consistent with update and delete)
Container size is now reduced and the form is centered.
Removed "back" button to dashboard, since navigation will be done through sidebar.

Type of change

[X] Bug fix
[ ] New feature
[X] Refactoring
[ ] Documentation

Problem/Solution Description

Team Profile Management naming can be improved on as per discussion.
Image was squished, object-fit: cover in css does the trick.
User can click on "file name" beside "choose file", this is now hidden and replaced with a button.
Complaints, that account page was too plain. Reduced size to minimize screen usage.
Back button is redundant, since users navigate from sidebar.

Tests
All unit tests pass?
Y
Builds successfully?
Y
Attach screenshot of the expected result (e.g. UI of the website/ postman api call result/ database changes)

Provide steps in detail for reviewers to reproduce the expected result of the code changes.
Relevant document/ link (if any)
Any related documents could help reviewers to review this PR
N/A
Risk
Identity the risk level (low, medium, high) and indicate which component(s) will be affected if bugs exist.
Low-Medium, affects profile page.

LGTM other than the CSS issue as Jis mentioned

Overall looks good to me!
Not sure if it was just me, the layout is not showing as expected when using a smaller screen size.

My wild guess is because of the fixed width of the profile container.
Btw, the window size I'm trying is 1020*720 px.

Should be fixed now, I changed the resize css

Overall looks good to me!
Not sure if it was just me, the layout is not showing as expected when using a smaller screen size.

My wild guess is because of the fixed width of the profile container.
Btw, the window size I'm trying is 1020*720 px.

Should be fixed now, its % fill not fixed px now

Still having the problem when the screen size is smaller or zooming in

A possible way to fix it might be using width auto or setting a minimum width for it.
If that's not an easy fix I think we can fix it later, Ig it should be fine for normal use. Happy to hit approve first since we're having user testing soon.

Left out >175% zoom because I assumed users will be using Researchify in desktop. But yeah we can fix it up if we require mobile view.


Add a hash value for profiles

Right now its very easy to:

setup some profiles and do the import/preparation of the graph data
shut down the server
change the profiles in config.yml again
restart the server but 'forget' deleting the graph-cache folder
get bad routing results because the profiles no longer 'match' the preparations

One easy way to detect this error would be calculating and storing some kind of hash code for each profile.
See this discussion: https://github.com/graphhopper/graphhopper/issues/1999#issuecomment-618910167

This could be a valuable improvement to be included in 1.0?

Yes, sure. I'll have a look into it!

Do we need to store and ensure hash values only for every profile listed in profile_lm/ch?
And can we skip the check for all LM profiles that reuse another preparation?

Do we need to store and ensure hash values only for every profile listed in profile_lm/ch?

Yes I think so. All we want to do is recognize if a profile that we keep some preparation for was changed (without updating the preparation).

And can we skip the check for all LM profiles that reuse another preparation?

Hm it could happen that such a profile changes and no longer works for the chosen preparation_profile. Then again we do not do any kind of check whether or not a preparation_profile works for a given profile either.

Hm it could happen that such a profile changes and no longer works for the chosen preparation_profile. Then again we do not do any kind of check whether or not a preparation_profile works for a given profile either.

Sorry this was probably not very clear. I mean this: We have profile A and calculate landmarks for it  and profile B that uses the landmarks we have for profile A as well. If we later change profile A we should get an error (because the hash changed without calculating new landmarks). If we later change profile B it could happen that this is no longer compatible to the landmarks we got for profile A. But then again we never checked that is was compatible before this either.

Do we need to store and ensure hash values only for every profile listed in profile_lm/ch?

Yes I think so. All we want to do is recognize if a profile that we keep some preparation for was changed (without updating the > preparation). And without ch/lm we do not store any kind of prepared data so nothing can go wrong?

I think we have to be a more strict now, because of the subnetwork encoded values. We only run the subnetwork search when we do the initial import. So if we change or add more profiles later we would have to update re-run the subnetwork search. The easiest thing we can do is just not allowing changes of the profiles at all.


App variable & other fixes

Show all variables in table, not just specific environment_json
Fixed config options for several tables (used ':' instead of '=') including app var (filter should now show)
Fixed action menu delete (regression)
Other fixes

Refactor: Match app variable config and service names
Remove  from deploy app branch/commit details
Updated entityLettabledRows name to match transformedEntities change

Discussed with Nathan, with previous fix ok to merge


Rest Api support for subscription

API Spec link
Microsoft.Maintenance/configurationAssignments/DynamicAssignment_SubC?api-version=2023-04-01"
API Spec version
2023-04-01
Please describe the feature.
Hi,
Is it possible to upgrade REST API for dynamic scope ? At this moment API doesn't support filter by subscription. Nice would be if API can filter resources by subscriptions

@KalpeshChavan12 Please help have a look, thank you.

Hi, any update on that ?


cmd/cgo: unable to pass "--static" to pkgconfig

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.10
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
Irrevelent
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
I'm trying to build a package that static links C dependencies using pkg-config to set the flags.
Before the cgo security update for go get (1.9.3), doing #cgo pkg-config: --static SDL2 would tell pkg-config to use the flags for static linking. As --static is a arg passed to pkg-config not the C compiler or linker, there is now no easy way to pass --static to pkg-config.
What did you expect to see?
Build succeed
What did you see instead?
Invalid pkg-config package name: --static

This is with the final released version of 1.10?  A fix for that went in quite late in the process.

Yup I just downloaded it from golang.org a few minutes before the report

I can't recreate the problem.  Can you show a complete test case?  Thanks.

After some checking I found out what's wrong. I'm setting --static in multiple files.
While exec is only allowing the first arg in the list to contain --
https://github.com/golang/go/blob/f7c2a71632854050d9fe6de115c6c346fcd9774c/src/cmd/go/internal/work/exec.go#L939

That's a loop, though.
Assuming this is still a problem for you, I'd still like to see a test case.  Thanks.

Test case is just any 2+ files with --static in the pkgconfig args.
main.go
package main

/*
	#cgo pkg-config: --static SDL2
*/
import "C"

func main() {

}

foo.go
package main

/*
	#cgo pkg-config: --static SDL2
*/
import "C"

func foo() {

}

Hmm...I'm having a similar problem (same error), but maybe it is different enough to be worth describing.

If it's different enough to be worth describing, it's worth being in its open bug (or at least on a bug that's not closed and thus not tracked).

@bradfitz - Will do. I only added it hear since it wasn't clear to me if my issue was obviously addressed by the patch that closed this issue already.

Reopening for 1.10.1.

CL 94896 OK for Go 1.10.1


Callback to router.param listener function should be last argument

See my listener function to router.param. The next callback is third (not last).
router.param('foo', function (req, res, next, paramValue, paramKeyName) {
});

99% of the time, functions that receive callbacks will receive the callback last. Could we change this for consistency? It would be a breaking change, of course.
router.param('foo', function (req, res, paramValue, paramKeyName, next) {
});

For the record, I am trying to intercept functions that receive callbacks so that I can author promises instead, which is why I need the callback to be last: https://gist.github.com/OliverJAsh/0c755bd05219fb8011cf.
Having the callback last is not standardised anywhere AFAIK, but it's a reasonable expectation as that's how the pattern normally goes. I'm surely not the only person programmatically accessing the callback via `arguments.

I have updated the labels on this issue (namely removing the 5.x label), but there hasn't been any significant discussion for quite a while here, nor elsewhere I am aware of. I'm going to close this one generally as stale, but we can always reopen. For reference as well, this particular method had been extracted out of this module and into https://github.com/pillarjs/router a while back.


Fix is operation fail on get_script()

Fix: #39244
func _ready():
    var unresolved_type_var = $Control.get_script()
    print($Control is unresolved_type_var) ## this works fine

the above code is working fine on all including previous versions, since the type of unresolved_type_var is unresolved at compile time but a script at runtime. and also current master also working fine because get_script() return type is Variant. and this fix works the same. get_script return type will remain variant.

Did you see #39260?

@vnen could you have a look at this as this also work on other nodes including self ?

Thanks!


MIOpen(HIP): Warning [SQLiteBase] Unable to read system database - Performance may degrade

Hello,
when running some PyTorch code, I am seeing a warning about MIOpen not being able to open a system database:
MIOpen(HIP): Warning [SQLiteBase] Unable to read system database file:/opt/rocm/miopen/share/miopen/db/gfx900_64.kdb Performance may degrade

I checked that the database file is in place and readable as a user:
$ ls -lh /opt/rocm/miopen/share/miopen/db/gfx900_64.kdb
-rw-r--r-- 1 root root 555M Okt 19 12:02 /opt/rocm/miopen/share/miopen/db/gfx900_64.kdb

This seems somewhat similar #306, where the database file cannot be deleted.
Just after this warning, I get errors about the device identifier being messed up, but these are already covered in https://github.com/RadeonOpenCompute/ROCm/issues/1572. Anyhow, here is the full output of my application:
FAILED [100%][INFO] Found GPU. Using device: cuda
Processing 1/1
[INFO] Found GPU. Using device: cuda
[INFO] Found GPU. Using device: cuda
MIOpen(HIP): Warning [SQLiteBase] Unable to read system database file:/opt/rocm/miopen/share/miopen/db/gfx900_64.kdb Performance may degrade
MIOpen(HIP): Error [SetIsaName] 'amd_comgr_action_info_set_isa_name(handle, isa.c_str())' amdgcn-amd-amdhsa--gfx900:sramecc-:xnack-: INVALID_ARGUMENT (2)
MIOpen(HIP): Error [BuildOcl] comgr status = INVALID_ARGUMENT (2)
MIOpen(HIP): Warning [BuildOcl] amdgcn-amd-amdhsa--gfx900:sramecc-:xnack-
MIOpen Error: /MIOpen/src/hipoc/hipoc_program.cpp:286: Code object build failed.  Most likely, the 1st problem (warning) can be safely ignored. Just in case, let's check the GPU (please paste output of /opt/rocm/opencl/bin/clinfo | grep -E "gfx|units" here).
For the 2nd problem we have workaround, see #1231

Hi @atamazov,
here is the requested output about my GPU (it's a Vega 64):
$ /opt/rocm/opencl/bin/clinfo | grep -E "gfx|units"
  Max compute units:				 64
  Name:						 gfx900:xnack-

@Bengt Yes, the 1st problem can be ignored.

Alright then. Since this issue is primarily about the first warning about not being able to read the database, I consider ignoring it a workaround. Hence, I will close this issue.

I hope this issue still helps somebody wondering about that warning message in the future.

@Bengt The 1st issue (warning) and the 2nd (build error) are unrelated. The workaround is required to resolve the 2nd issue. The root reason of it is ROCm problem with gfx900 identification.

Yes, thanks for clarifying.


datetime  lost precision

Microsoft SQL Server 2019 (RTM-CU12) (KB5004524) - 15.0.4153.1 (X64)
Jul 19 2021 15:37:34
Copyright (C) 2019 Microsoft Corporation
Developer Edition (64-bit) on Linux (Ubuntu 20.04.2 LTS)

@minesunny -- thank you for your feedback and example.  This looks like a product issue rather than a documentation issue; please add it here:

SQL Server feedback


SetStateAsync returns System.Exception: The requested resource is in use. (Exception from HRESULT: 0x800700AA)

Hi team,
Upon using SetStateAsync call for setting On/Off state on Bluetooth radio, I get the following exception:-
The requested resource is in use. (Exception from HRESULT: 0x800700AA)
I am using it as follows ->
await TaskHelper.DoTask(radio.SetStateAsync, state);
I am using GetRadioAsync method to get the available radios.
public static Task<T> DoTask<T, TIn>(Func<TIn, IAsyncOperation<T>> func, TIn input)
       {
              return Task.Run(() =>
              {
                 IAsyncOperation<T> asyncOperation = func(input);
                  return WaitAndGetResults(asyncOperation);
              });
       }

(I have no GUI BT related window opened on my Windows machine)
Any help/input would be really appreciated.

Hi, we appreciate you submitting through our feedback channel. However, this feels not so much like feedback specifically about the documentation, but rather like a support request. Here are all of the developer support resources, for completeness.
Microsoft Q&A offers relevant and timely answers to your technical problems from a community of experts and Microsoft engineers.

For community assistance with development questions, there are our forums, and StackOverflow.
The Windows developer support site explains other support options.
The Visual Studio developer community is available, and responsive. The former User Voice feature is now there on the Suggest a feature tab, if you want to lobby for a change, a feature, or to make a suggestion.
For developer issues, or suspected product bugs, there's Microsoft Support; a support engineer will look at the repro and see whether the issue is a Microsoft product bug, or something else. If it's a bug with a Microsoft product then the ticket will be free of charge.

If you receive assistance via any support resource, and you believe that information would help us improve the docs, we'd appreciate if you came back and let us know.


Vector2Angle returns degrees instead of radians, but all other raymath

functions use radians, making this awkward to use.
Per discussion on discord, raymath should always use radians. I found this one was left out by searching for 180 and 360.

@schveiguy Good catch! I missed that one. Actually, there is an open issue that could be related: https://github.com/raysan5/raylib/issues/2172

@raysan5 I believe atan2f(v2.y, v2.x) - atan2f(v1.y, v1.x) is the correct way to retrieve an angle between two vectors, based on the defintion of the arc tangent. Here's an article about it from Stack Overflow: https://stackoverflow.com/questions/21483999/using-atan2-to-find-angle-between-two-vectors/21486462


Need for OpenJ9 Java 9 (0.9) Release at Adopt

Previously, OpenJ9 Java 9 releases were available at AdoptOpenJDK.
To access OpenJ9 Java 9 releases, the following AdoptOpenJDK API is available: https://api.adoptopenjdk.net/openjdk9-openj9/releases/x64_linux/latest/binary (https://github.com/AdoptOpenJDK/openjdk-api).
In OpenJ9, DockerFile(s) to build Java 10 are dependent on Java 9 as the boot JDK. The above AdoptOpenJDK API was used to get OpenJ9 Java 9 from AdoptOpenJDK.
Suddenly, AdoptOpenJDK removed all Java 9 releases. The above API can't be used. In OpenJ9, DockerFile(s) to build Java 10 don't work anymore (https://github.com/eclipse/openj9/issues/2152).
Even though, AdoptOpenJDK stopped supporting Java 9. Instead of removing all Java 9 releases, they should have a final/last release of Java 9 available. This way others who are dependent on AdoptOpenJDK API won't be impacted.
Nightly builds for Java 9 are still running. I would like to request a final release of Java 9 builds of OpenJ9, following which OpenJ9 will not make any efforts to keep Java 9 working.

fyi - @pshipton

@sxa555 fyi

I expect OpenJ9 will drop all support and builds for Java 9 after the 0.9.0 release. The release at Adopt can be the final build, with no further nightly builds of Java 9 required afterwards.

We are working on getting all the release builds back in place (although at the moment 9 is at the bottom of that list) - stay tuned :-)
Ref: https://github.com/AdoptOpenJDK/openjdk-build/issues/317

The java_util one is interesting - difference in fr_FR vs fr:
ResourceBundleT200: Failed. FAIL-> Expected: greetings from Msgs_fr_FR.properties, Actual: greetings from Msgs_fr.properties

No issues with any of the other resource bundle tests, only the French one - will verify whether it happens on HotSpot builds as well as J9

Now that OpenJ9 0.9 has been release I'll get this done over the next few days (We don't currently have a release pipeline for AO9/J9 so I'll need to put one together but that won't take long)

Released and on the main download site - all platforms available from the archive page at https://adoptopenjdk.net/archive.html?variant=openjdk9&jvmVariant=openj9


Add a navigation Widget

Fixes #13

closing because I want to do a mouse over effect instead of a tooltip


No syntax highlighting after update

I recently updated my plugins (I use Vundle). This caused syntax highlighting to fail when I use the nova colorscheme. I did a thorough revamp of my vimrc and the plugins I use. I have determined that whenever I execute colorscheme nova all of my syntax highlighting goes away. It seems the nova colorscheme plugin isn't working.
I looked at the latest documentation which says the plugin is now dependent on sheerun/vim-polyglot. So I installed that as well, but I still get the same problem—no syntax highlighting at all.
Help!

Hi @jlconlin! Thanks for using Nova! I haven't had any other reports of this and everything is working for me and those I know using Nova with Vim - so I'm thinking there might be something up with your setup. Here are a two things to try:

Ensure running vim --version shows your Vim version is at least 8.0.

See if you can reproduce with only this in your .vimrc:

set nocompatible
filetype off

set rtp+=~/.vim/bundle/Vundle.vim
call vundle#begin()

Plugin 'sheerun/vim-polyglot'
Plugin 'trevordmiller/nova-vim'

call vundle#end()
filetype plugin indent on

colorscheme nova

Then restart Vim and run: :PluginClean and :PluginInstall to clean your plugins to only use this minimal config ^
^ This is a vundle specific version of the example .vimrc from https://trevordmiller.com/projects/nova
If syntax highlighting works after doing these two things, it means that your issue is related to your other plugins or settings in your .vimrc unrelated to Nova. But if you can still reproduce after doing these two things, let me know :)

I tried your suggestion and it worked using MacVim, but it did not work in my terminal. I generally run with iTerm2 using the terminal vim provided with MacVim. Strange that it works in one place, but not the other.

@jlconlin Yeah that is strange. I’m not sure why it wouldn’t be working for you. But I’m happy to try to help debug with you. If you could upload a video or gif of you starting iTerm and then starting Vim and moving around some files that could be helpful in debugging.

@jlconlin Also one other idea: do you have anything in ~/.vim/colors? That directory should be empty.

After further attempts, it looks like it was some combination with my tmux settings. When I did it outside of tmux then the terminal and gui version worked just fine, but inside of tmux, the terminal version didn't work.
I am getting syntax highlighting now, but I'm not sure everything is exactly the way it should be—it's kind of hard to see. I'm trying to figure out which of my settings is the culprit.

@jlconlin Ok, sounds like you have some personal settings interfering so I'm going to close this issue. The Nova website does have info on how to use tmux: https://trevordmiller.com/projects/nova. You can also check out my own dotfiles as I use iTerm2 + tmux + vim: https://github.com/trevordmiller/dotfiles. If you find anything Nova specific feel free to post a new issue. Thanks!


all distrho plugins segfault Ardour and jalv

Issue description
I get the following output as soon as I insert a distrho-ports plugin in ardour:
Skip explicit buffer seconds, preset in use
UI::flush_pending timed out after 10s.
The program 'ardour-5.6.08353095' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadShmSeg (invalid shared segment parameter)'.
  (Details: serial 48 error_code 128 request_code 130 minor_code 2)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
[1]    28770 segmentation fault  ardour5 --sync /tmp/ArdourTest/ArdourTest.ardour

jalv.gtk --sync urn:juced:DrumSynth gives me:
The program 'jalv.gtk' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadShmSeg (invalid shared segment parameter)'.
  (Details: serial 53 error_code 128 request_code 130 minor_code 2)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

I also tried with the latest git of distrho; same issue.
I don't know if this is a NixOS issue, or an upstream issue, see:
https://github.com/DISTRHO/DISTRHO-Ports/issues/17
Technical details
Below is my current info, but this was also an issue with earlier versions of NixOS.

System: 17.03.git.62a2890 (Gorilla)
Nix version: nix-env (Nix) 1.11.8
Nixpkgs version: "17.03.1264.9ed5dbafe3"
Sandboxing enabled: build-use-sandbox = true

This seems to be fixed now.