Dividend Growth Rate

Feature Request
Wanted Feature
I would like to know the 5 year average dividend growth rate for a stock. I'm not sure if this already exists?
Use Cases

To calculate the chowder number you need the current dividend yield + 5 year average dividend growth rate
https://www.suredividend.com/the-chowder-rule-explained/#:~:text=The Chowder Number is derived,applied differently to different stocks.

Potential Example Usage
This feature could be used in the following way:
  const dividendYield = data?.summaryDetail?.dividendYield * 100;
  const dividendRate = data?.summaryDetail?.dividendGrowthRate;
  const chowderNumber = dividendYield + dividendRate;

Ah I found a workaround using this historical API:
https://github.com/gadicc/node-yahoo-finance2/blob/devel/docs/modules/historical.md


Does it work with any frontmatter keyword?

I am trying this plugin with docusaurus 2.0 rc.1 but I am seeing something not right.
I swizzled the TOC component, added a random frontmatter entry to a page and used the plugin.
I do not see the testKey.  If I use id or title which are default frontmater accepted key, they work. Am I wrong with anything?
import React from 'react';
import clsx from 'clsx';
import styles from './styles.module.css';
import TOCItems from '@theme/TOCItems'

import useFrontMatter from '@theme/useFrontMatter';

// Using a custom className
// This prevents TOCInline/TOCCollapsible getting highlighted by mistake
const LINK_CLASS_NAME = 'table-of-contents__link toc-highlight';
const LINK_ACTIVE_CLASS_NAME = 'table-of-contents__link--active';
export default function TOC({className, ...props}) {

  const { testKey } = useFrontMatter();

  return (
    <div className={clsx(styles.tableOfContents, 'thin-scrollbar', className)}>
      {testKey}
      <TOCItems
        {...props}
        linkClassName={LINK_CLASS_NAME}
        linkActiveClassName={LINK_ACTIVE_CLASS_NAME}
      />
    </div>
  );
}

My bad. It works. Unknown reason.

I haven't tested this yet on RC1. I'll try and get that done in the next week.

So far so good. I suspect given the number of docs I have in my site I touched the wrong set. It seems working with rc1 now.
On 30 Jul 2022, 15:01 +0100, trent @.***>, wrote:

I haven't tested this yet on RC1. I'll try and get that done in the next week.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID: @.***>


HSEARCH-3413 Search 6 groundwork - Restore support for implicit index name

https://hibernate.atlassian.net//browse/HSEARCH-3413

Pull Request Test Coverage Report for Build 1

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 86.627%

Totals

Change from base Build 63:
0.003%

Covered Lines:
11433

Relevant Lines:
13198

💛  - Coveralls

Merged, thanks!


Review of changes to ANCM Configuration Reference

@Rick-Anderson @spboyer @Tratcher @pranavkm @shirhatti @moozzyk @danroth27
A significant update was just made to the ASP.NET Core Module Configuration Reference to accommodate the new ANCM overview doc, but I see just a handful of very minor grammatical issues.
Instead of submitting a PR outright, I'll post on this issue the handful of suggestions that I have for approval if that works for you.

@GuardRex  OK

If you like any of these, I'll get a PR together this weekend. I numbered them for reference.

1

ASP.NET Core Module is an IIS module that lets Kestrel use IIS or IIS Express as a reverse proxy server.

I recommend "allows Kestrel to use" (more formal) over "lets Kestrel use" (somewhat informal).

2

The Web.config file

Throughout .NET Core docs and samples, Web.config (the uppercase IIS clan file naming convention) is ignored in favor of the lowercase filename, web.config. Throughout this doc and in all of the samples the lowercase filename predominates. For consistency, I think it should be lowercase here. Conversely, it could be uppercase everywhere else.
Also, this section doesn't strike me as really addressing web.config, per se. It's about using web.config to configure the module. What do you think of Configuration via web.config?

3

Here's an example from a Visual Studio project, with placeholders for settings that Visual Studio plugs in when you run or debug the project.

[EXAMPLE]

When the project is published, Visual Studio automatically plugs in the values required for the destination environment, as shown in this example of a project that has been deployed to an Azure web app.

[EXAMPLE]

I'm surprised this was added at this time, as it seems to apply to VS2017, MSBuild/csproj, and utility provided by Microsoft.NET.Sdk.Web. There is also a comma splice btw ("project, with").
Would you like this refactored to address the use of publish-iis tooling? ... or dropped? ... or left alone (except for the comma splice)?
Side note: This section has been introduced here for the first time. Since we've seen a number of devs  include the <handlers> section in subapps, I recommend to say something about removing the <handlers> section in subapp web.config files. It's a common problem, and a few words here will probably save a number of dev headaches.

4

Duration in seconds for which the module will wait for the executable to start a process listening on the port.

... change "for which" to "that" ...

Duration in seconds that the module will wait for the executable to start a process listening on the port.

5

Here's an example that sets two environment variables.

There are three env vars set now, so we'd probably remove the ENV_VAR_2 setting.
I don't have a hard suggestion ... just a question on this: It seems a little strange to me to show the ASPNETCORE_ENVIRONMENT env var as an example. web.config transforms aren't supported at this time (https://github.com/aspnet/Tooling/issues/252), and this implies that devs will be creating alternate web.config files and having them :sparkles: auto-magically :sparkles: get picked up. It might imply that this is the correct/best way to configure the environment, which I think many would find objectionable. Are you sure you wouldn't want to go with something more generic here? ... maybe ...
<environmentVariable name="DOTNET_CLI_TELEMETRY_OPTOUT" value="1" />

lol ... jk ... jk ... just kidding. :smile: Seriously tho ... would it make more sense right now to use ASPNETCORE_PORT or something like ASPNETCORE_DETAILEDERRORS here? Would it be better to just remove the ASPNETCORE_ENVIRONMENT entry from the example and leave it with the two generic env vars I listed? ... or how about something more generally relevant, such as a suggestion by @wpostma for CONFIG_DIR, which is how he picks up his config file directory in Startup?

6

Look at the HTTP Errors attribute to override this page with a custom error page.

to

For more information on configuring custom error messages, see HTTP Errors <httpErrors>.

7
Add backticks to "aspNetCore" in ...

Here's a sample aspNetCore element that configures stdout logging

... and explicitly specify that this example is for Azure Apps.

ASP.NET Core Module is an IIS module that lets Kestrel use IIS or IIS Express as a reverse proxy server.

I recommend "allows Kestrel to use" (more formal) over "lets Kestrel use" (somewhat informal).

Um.  Can I just say I find that confusing, it seems like passive voice.  Kestrel is designed to be fast, not designed to be secure, or load balanced, or to have policies or management or lots of logging. So IIS is a production web hosting platform, and kestrel is an ultra lightweight http request server.
So I would say "ASP.NET Core Module is the module that lets you run portable .net core applications behind IIS, using IIS for what it's good at (security, manageability, and lots more) and using Kestrel for what it's good at (being really really fast), and getting the benefits from both technologies at once".

Technically tho, the description is correct. This is merely the reference doc. I think the intention is that general info, descriptions, how-to is all in the new ANCM overview doc at https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/aspnet-core-module.

@wpostma  can't we use your approach but also mention that you get security from the RPS. We can't leave out that detail.
@GuardRex  looks good, go ahead.

Oh sure,  I'm just giving an End User perspective here. What I first found confusing about ANCM is that it exists at all.   Then I realized, this is a more modern architecture than ISAPI or DCOM, so of course it's a reverse proxy.

@Rick-Anderson :+1: ... but on specifics ...
RE: 3 ... VS modding the web.config: Would you like this refactored to address the use of publish-iis tooling?  ... or left alone (except for the comma splice)? I assume you don't want it dropped, since the ANCM overview specifically says to come here for a web.config example.
RE: 5 ... the env var example: Leave it alone? ... change it to ASPNETCORE_PORT or ASPNETCORE_DETAILEDERRORS (or both)? ... or remove ASPNETCORE_ENVIRONMENT and leave the generic ones (or better generic ones) in place?
☝ or do you want me to make the call? In which case, I'll go with publish-iis language and change the env var example to ASPNETCORE_PORT.
@wpostma I recommend you float that over to @tdykstra for https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/aspnet-core-module? @Rick-Anderson, what we could do here is just drop the first sentence entirely. This whole doc can just start with the second sentence.
Although, I would combine it with the next line. Like Captain Kirk, "I don't believe in the one-line paragraph." :smile: [well ... I try to avoid them most of the time]
I would also make a few other minor course corrections, but this doc would open well with something like ...

This document provides details on how to configure the ASP.NET Core Module for hosting ASP.NET Core applications. For an introduction to the ASP.NET Core Module and installation instructions, see the ASP.NET Core Module overivew.

That's a good page. Why not link to that page from here? Links are awesome.  People will google and land all over your docs.

@GuardRex  you make the call.

ASPNETCORE_ENVIRONMENT was my suggestion. It's a real value that people ask how to set. They're likely to set this after publishing as a way to help them debug their app.

@Tratcher Ok ... I'll leave that.

Why not link to that page from here?

It is ... it will be in the opening paragraph.

For the fundamentals doc, @wpostma intro sentence suggestion sounds good -- I'd just make minor changes:

ASP.NET Core Module is an IIS module that lets you run ASP.NET Core applications behind IIS, using IIS for what it's good at (security, manageability, and lots more) and using Kestrel for what it's good at (being really fast), and getting the benefits from both technologies at once.

For this doc I like @GuardRex suggestion

This document provides details on how to configure the ASP.NET Core Module for hosting ASP.NET Core applications. For an introduction to the ASP.NET Core Module and installation instructions, see the ASP.NET Core Module overview.

Regarding "allow" vs. "lets", the choice of the latter results from an effort on Microsoft's part to make its docs sound less formal. I was accustomed to using "allow" in cases like this but have been advised that the "lets" language is preferred for that reason.
Suggestions 2, 4, 6, 7 all sound fine

@Rick-Anderson I see your merge requests are going against "master;" but when I did it, it went against "aspnet:master." That seemed to have hung both PR's. Where did I go wrong there?
Also, curious how I can view the build progress as before. There's no link in the vicinity of ...

@GuardRex  sometimes the OPS build doesn't show up. It usually shows up. If you see that again, let me know. I usually close/reopen  and that fixes it.


Cloud Firstore Plugin Should Support Logical Or Query

Currently, we can do logical And operations using the where clause  something like this
Logical AND
Firestore.instance.collection("messages")
    .where("field1", isEqualTo: "value1")
    .where("field2", isEqualTo: 'value2')

I would propose a similar functionality for logical OR
Proposal
Firestore.instance.collection("messages")
    .where("field1", isEqualTo: "value1")
    .orWhere("field1", isEqualTo: 'value2')

The current approach which works for me is using the CombineLatestStream from the rxdart package
Current Approach
final stream1 = Firestore.instance.collection("messages")
    .where("field1", isEqualTo: "value1");
final stream2 = Firestore.instance.collection("messages")
    .where("field1", isEqualTo: "value2");

StreamBuilder(
    stream: CombineLatestStream.list([
    stream0,
    stream1,
  ]),
builder: (context, snapshot) {
  final data0 = snapshot.data[0];
  final data1 = snapshot.data[1];
})

I am not sure how efficient the current approach is, or what are the technical challenges involved with adding support for Logical Or query to firestore plugin I would love to hear more about it. Feel free to close this issue if this is a duplicate or is not related.

Hi @maheshmnj
From what I can see, the issue is related to a FlutterFire plugin rather than to Flutter itself. Please open the issue in the dedicated repository.
Closing, as this isn't an issue with Flutter itself.
If you disagree, please write in the comments,
providing your flutter doctor -v, your flutter run -v,  your pubspec.yaml
a minimal reproducible code sample that does not use 3rd party plugins,
and I will reopen it.
Thank you


caplock remap not work

[ids]

*

[main]
capslock.h = left

i want to press capslock+h and see cursor move left, not work
Linux local-dev 5.18.16-arch1-1 #1 SMP PREEMPT_DYNAMIC Wed, 03 Aug 2022 11:25:04 +0000 x86_64 GNU/Linux

Thank you for your solution


Proper mobile navigation

The current implementation of the navigation bar feels a bit clunky on mobile. It would be nice to have a proper bottom navigation bar, as is the case with native apps.

can you please assign this issue to me?

We could also leave the navigation in the header and make something looking like this. I kinda like this look.

Closing now because I implemented this in the complete rewrite


[S3] wrong weapon info

Tri-Slosher sub weapon is Toxic Mist not Splat Bomb

Good catch!

It seems these data have been swapped...

They are fixed. Thank you for the report.


Trouble parsing comments?

Seems that this module won't parse comments? If it's the first line, it causes an exception. If you add a comment further down, it seems to stop at the commented line, and not parse any further.
You could try this example to see.
https://learnxinyminutes.com/docs/yaml/

Believe this was user error!


Editor spawns hundreds of processes on startup to call xdg-user-dir

Godot version
v4.0.alpha.custom_build [f6714581c]
System information
Linux
Issue description
Not a bug but a quality-of-life issue and I really don't know if this is worth looking into. I won't be the least bit mad if you reject this issue.
When I start the editor on my Linux machine it spawns 807 processes (in sequence, not in parallel) to run xdg-user-dir DESKTOP. If I start the editor with a --path it "only" does it 606 times.
I changed OS_LinuxBSD::get_system_dir() to instead return early with a hardcoded path and that took startup time from 8.8 to 7.5 seconds (as measured with the new --startup-benchmark) on a small scene.
Steps to reproduce
To see how many times this happens during startup, here are a couple of different, ugly ways I can think of:
Add a print_line() to OS_LinuxBSD::get_system_dir()
or
Create a shell script called xdg-user-dir which does echo $@ >> ~/xdg.log and put it somewhere in your PATH before where the proper xdg-user-dir lives. Then wc -l ~/xdg.log.
Minimal reproduction project
No response

If you follow by poor advice to create a shadow xdg-user-dir script, please remember to remove it once you're done testing, or other apps will behave weirdly. Don't ask me how I know.

I agree the value should be cached, as it's not going to change at run-time.


saveArticle returns plain message which causes php error

Changed return to throw new \Exception because if this message returns as result of this method "$result->getId()" fails in line 2383 and the import hung up.

Dear Contributor,
Thank you for your contribution to Shopware. We value your engagement.
Unfortunately we have to close all existing Pull Requests.
This is due to the new Shopware 5 Major Release and a restructuring of the branch names.
If your contribution is still relevant for Shopware 5, a new pull request is highly appreciated.
We are very sorry for this inconvenience.
Greetings from the Shopware Team.


Improve clickable area in repo action view page

Before:

After:

In current design, the clickable area is too small, and it is hard to find the correct clickable area as the area with background color (div with class name job-brief-item selected) is bigger than it.

Agreed, try if you can address @yp05327. Thanks 🙏

Renamed class name.

Ah, if I re-request review, the block status will be removed. 😕


Delete does not check if entity exists

See #HBL-44.

Codecov Report

Merging #3 (789d756) into HBL-22 (557ada3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            HBL-22        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           44        44
  Lines          978       980    +2
  Branches        81        82    +1
=========================================
+ Hits           978       980    +2

Flag
Coverage Δ

api
100.00% <100.00%> (ø)

client
100.00% <100.00%> (ø)

client-e2e
100.00% <100.00%> (ø)

core
100.00% <100.00%> (ø)

core-e2e
100.00% <100.00%> (ø)

landing
100.00% <100.00%> (ø)

landing-e2e
100.00% <100.00%> (ø)

shared-models
100.00% <100.00%> (ø)

shared-types
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../src/app/controllers/GymZone/GymZone.controller.ts
100.00% <ø> (ø)

...pp/controllers/VirtualGym/VirtualGym.controller.ts
100.00% <ø> (ø)

apps/api/src/app/controllers/helpers/delete.ts
100.00% <100.00%> (ø)


drt: Consolidate spacing calculation code

Signed-off-by: Anton Blanchard<EMAIL_ADDRESS>

There are quite a few more places to consolidate, but this was a simple subset to start with.
There are one or two places that error (or warn) when the layer doesn't have min spacing constraints, or if the constraint wasn't one of the types we expect. It seems like we could check this once during initialisation if it is required (these cases will now just use a space of 0).


[KYUUBI #1229] Fix met error when debug KyuubiServer in local IDE

Why are the changes needed?

When debug KyuubiServer in IDEA, IDEA: Intellij IDEA 2021.2(Ultimate Edition)
throw exception
/KyuubiHiveDriverSuite.scala:45:36
Class org.apache.hive.jdbc.HiveConnection not found - continuing with a stub.
    assert(connection.isInstanceOf[KyuubiConnection])

/KyuubiHiveDriverSuite.scala:47:34
Class org.apache.hive.jdbc.HiveDatabaseMetaData not found - continuing with a stub.
    assert(metaData.isInstanceOf[KyuubiDatabaseMetaData])

For more detail, please go to https://github.com/apache/incubator-kyuubi/issues/1229
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

cc @pan3793, had tried run KyuubiServer after build kyuubi project.

please add this to the umbrella @pan3793

Codecov Report

Merging #1231 (873b331) into master (16aaeaf) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1231   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         156     156
  Lines        5985    5985
  Branches      636     636
======================================
  Misses       5985    5985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16aaeaf...873b331. Read the comment docs.

Execute Build => Build Project(⌘+F9) or Rebuild Project before running the test.

@cfmcgrady Does this work for you?

Thanks, merging to master.


Updated 06-package-niceties.js - grammar fix

Just a tiny grammar correction

hi @pathogen- sorry for the super long delay in responding to you! i'd love to merge this PR. could you rebase on master? (lemme know if you need help doing that). thanks so much! :space_invader: :dolphin:

Aha! I worked it out :tada: No problem with the delay! Hope that's all good.

:sparkling_heart: :money_with_wings:


⚠ ClamAV has degraded performance

In c263b49, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 70 ms

Resolved: ClamAV performance has improved in d1c15c5 after 10 minutes.


Pass the --disable-dds flag through to dwds

This passes the value from the --disable-dds flag through to DWDS to prevent it spawning its own version of DDS when disabled.
@jonahwilliams @bkonyi what's the best way to test this? It doesn't directly do much itself (except pass a flag through to DWDS), and I was unable to find tests doing something similar I could use as a template. Thanks!

cirrus is stuck, I'll land and revert if there are problems.


Replaced the corrupted .sppkg by a functional one

Q
A

Bug fix?
yes

New feature?
no

New sample?
no

Related issues?
no

What's in this Pull Request?
The .sppkg file was referring the wrong .js files, and thus displaying an error while adding the WebPart to a page. Replaced it with an updated and functional .sppkg file.

Hi Simon, have to ask what's the thinking around this? - Typically you would not share compiled code or solution files in the GitHub - since those would be recompiled by the persons who would test the solution. If someone would now use this file, there would be the dependency for assets being hosted from your tenant, which would be a potential issue for anyone... if you suddenly would pull the JS files... and Office 365 CDN is not really intended for cross tenant usage. Thanks for the additional details advance.

Hi Vesa, actually I find it usefull for people who want to quickly see what the component can do without having to compile it on their own etc...
I think most people realize it’s not ideal for production since they have a dependency on my tenant, but that could be said even If I was hosting it on a « proper » azure blob storage CDN, I could of stop my azure subscription and users would find their WebPart broken on the next morning. Not sure how the O365 CDN should be less of an option, other than the fact that it is limited to a « *.sharepoint.com » referrer?
That being said, although I am very carefull with the sources on my tenant and I make sure to create a new folder everytime the sources changes so I don’t impact people who were using an old version of the .sppkg, it really is for demonstration purposes more than anything.

Makes sense. Thx for opening up this slightly more.


Creating new relationship

I think this topic was discussed several times, but I cannot find an answer to my question. I'm quite new to JSON API, so excuse me for my ignorance.
Assume there's an article resource, article has many comments.
/articles/1 - article resource.
/articles/1/comments - article's comments, related resource.
How do I create a comment? Am I right that I have to do two calls?
First,
POST /articles/1/comments
{
  data: {
    "type": "comments",
    "attributes": {
      "message": "Hello there"
    }
  }
}

Assume comment resource just created gets id 2.
.. and then link it to an article:
POST /articles/1/relationships/comments
{
  data: [
    { "type": "comments", id: 2 }
  ]
}

This is not quite making sense to me. Why do I have to create a relationship if related resource sits "under" /articles/1 namespace? It makes sense to me to do it in case with many-to-many relationship, but why it is proposed for many-to-one?
Should I include a relationship block during comment creation, that points to a parent article? But again, why would I do it if I'm working within article's namespace /articles/1/comments?
Please point me to the right place in spec.

The spec says

A resource can be created by sending a POST request to a URL that represents a collection of resources.

Your /articles/1/comments represents a collection of resources (namely that of comments for the article with id 1). All good so far.
Now the part you may be missing is that the spec never says "the created resource MUST have exactly the same attributes and linkage data as the creation payload". Some attributes/relationships may be decided by the server (such as here, where the article id is decided, from the route, by the server).

How do I create a comment? Am I right that I have to do two calls?

The spec is pretty light on the behavior of the /resourceOne/:resourceOneId/resourceTwo endpoints. I only see it referenced for GET requests, so if I were to implement JSON API, I'm not sure if I'd add support for write endpoints.
The way that I perform this operation in one call is to just use the regular /comments endpoint. It's really nothing fancy.
POST /comments

{
  data: {
    type: 'comments'
    attributes: { ... },
    relationships: {
      article: {
        data: {
          type: 'articles'
          id: 1
        }
      }
    }
  }
}

So far I've only used endpoints of the form articles/1/comments for reading data.

Actually, when you POST to /articles/1/comments server should create relation automatically, without need to POST /articles/1/relationships/comments.
But if you POST to /comments, you should add relationships to article with it's id.

I see a couple things that stick out to me as odd here.

The convention of /resource/{id}/{rel-name} is not mentioned anywhere as part of the spec that I can find, therefor it is a poor idea to assume the existence of a resource at that particular URL.  It is fortunate it was not included in the spec, as this would have further crippled the hypermedia capabilities of json-api.

I would agree with @jmeas that as defined in the spec, the back reference method of defining the relationship is best, however it is unintuitive and would require some form of mental gymnastics by the user to reason out.

A possible extension and potentially currently supported option which is less counter intuitive come to mind.

One solution would be to extend the specification by allowing POST or PATCH requests to the relationships link to contain a 'resource object' as well as a 'resource identifier object', following the same error handling rules as previously defined.

A less ideal, but I think currently supported by the spec would be the POST a compound document with a resource identifier object using a user defined ID to the relationships link with an included resource object.

I realize this issue has been inactive for quite some time, but as I read the specification, nothing normative seems to be said regarding the structure of URLs.
For example, although URLs such as /articles/1/relationships/comments are included in a number of examples, the /relationships bit is not mentioned even once in the actual normative text of the specification.
If the URLs shown in the examples are meant to be normative, that needs to be explicitly stated; without such a statement, my personal opinion is that they must be considered non-normative. If the specification is intended to cover the structure of resource URLs, quite a significant amount of work will be necessary to make a robust specification for that structure -- personally, I believe that it should be considered beyond the scope of JSON:API.
Proceeding with the assumption that I am not wrong in my reading, most likely, any of the approaches discussed above would be acceptable under v1.0 of the specification (as well as the v1.1 draft as it exists as of this writing).
Of course, it is entirely possible that I'm wrong, and have missed something in my many readings of the spec. In that case, could someone please point me to where resource URL requirements are described?

They are recommendations, @rintaun .

@jamesplease Thank you :) I suppose that's what happens what you hyperfocus on one thing... I had completely skipped over the recommendations page.

@jamesplease what would be the response from the server to the request you gave as an example?
In particular, would that solution mean that there are two relationships endpoints a server must expose:

the expected one, from article to comments /articles/1/relationships/comments, containing the new relation created by the request
another one on the other side, from comment to article /comments/2/relationships/article

If this is the case, it would also mean that we can delete a relationship between two resources either from one or the other endpoint, right?

@jamesplease what would be the response from the server to the request you gave as an example?

One part of using JSON:API that I like is that it is flexible, to a degree. In situations like this, you get to decide what sort of response makes sense to you. My rule of thumb is: come up with a solution that makes sense to me that doesn't go against the spec. And anything that might be surprising or unusual should be documented somewhere.
In the example I posted above, I can think of two possibilities (based on my memory of the spec. It's been awhile since I really dug into it tbqh):

Return the created comment as data and the created article in included (both at the top-level)
Return only the created comment as data, and allow a user to pass the includes query param to return the newly-created article (docs)

In particular, would that solution mean that there are two relationships endpoints a server must expose:

What you're describing are back-links or two-way relationships, which I think is an independent topic from the one in this issue.
I don't recall the spec enforcing back-links, but APIs that support it are much more useful. If you're using a relational database under-the-hood, you'll likely need to store the relationships both ways (this guide from Fortune.js describes one approach).

If this is the case, it would also mean that we can delete a relationship between two resources either from one or the other endpoint, right?

Ideally, yup.


python3-libselinux is the OS package. It's best to install from the ISO

[WIP]python3-libselinux is the OS package. It's best to install from the ISO
build python3-libselinux package is easy to has the dependency issue.

Centos7 / RedHat 7

It can be found at the CentOS-7-x86_64-DVD-2207-02.iso
./Packages/libselinux-python-2.5-15.el7.x86_64.rpm

Centos8 / RedHat 8

It can be found at the CentOS-8.5.2111-x86_64-dvd1.iso
/BaseOS/Packages/python3-libselinux-2.9-5.el8.x86_64.rpm
So I think it can be removed:
https://github.com/kubean-io/kubean/blob/639ef2c7e81ae91882a6b0c8b64cdcbdab9fa219/build/os-packages/packages.yml#L15
https://github.com/kubean-io/kubean/blob/639ef2c7e81ae91882a6b0c8b64cdcbdab9fa219/build/os-packages/packages.yml#L24

/kind feature


temporary PR to test #16495

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Thanks for contributing!

Closing in favor of https://github.com/cilium/cilium/pull/16553.


[labs/ssr] handle shadowRootOptions during SSR

Should this be an RFC?

[X] This is not a substantial change

Which package is this a feature request for?
SSR (@lit-labs/ssr)
Description
When shadowRootOptions are declared on a component like in the snippet below, they are not used to render SSR components. It sounds like this could be achieved by declaring some additional attributes on the template for the declarative shadow dom.
static shadowRootOptions = {...LitElement.shadowRootOptions, delegatesFocus: true};

Recreation
On both of the examples below, focus the "button" by tabbing to it and then tab again. The non-SSR example focuses only the inner button and not the host element because of the delegatesFocus shadowRootOption. The SSR example focuses the host element first, but then also the inner button.
Expected behavior without SSR: lit playground reproduction
Behavior with SSR: https://stackblitz.com/edit/lit-ssr-global-3cktrx?file=src/components/ex-button.js
Alternatives and Workarounds
None I am aware of.

@hrmcdonald this is now released in<EMAIL_ADDRESS>


Added NTSC mode

Unlocks the NTSC exclusive difficulty adjustments for RE4 UHD.
Quoting my post in https://github.com/nipkownix/re4_tweaks/issues/183 as a summary of what this is supposed to do:

Normal mode and Separate Ways start at 5500 difficulty instead of 3500.
Assignment Ada is fixed to 6500 difficulty instead of 4500.
Easy difficulty is removed as an option from the title menu.
Shooting range requirements are 3000 per bottle cap instead of 1000.
The village stage in Mercenaries has a unique dynamic difficulty mode. In PAL the difficulty is fixed at 5500, but in NTSC it's unlocked, and you also gain 30 difficulty points every second. ***This requires a 60fps fix, because it's just calling GameAddPoint(LVADD_TIMECOUNT) every frame in R400Main(). At 60fps, you gain difficulty twice as fast!

TODO:

[ ] the note in the shooting range still says that bottle cap requirements are 1000 for non-English languages

Not sure how to fix the shooting range note. I checked inside ss_file_01.MDT and found the 1,000 and 3,000 score requirement strings are already there, so the question becomes how to change the message ID of this particular object.

Looks like file_msg_tbl defines the start MDT entry number for each file, file_pages also says how many pages/MDT entries are in each file (per language), seems it starts with the MDT entry number inside file_msg_tbl entry, and reads through that entry number up to the count inside file_pages.
file_msg_tbl[0xE] seems to be one for the target practice note, that sets start MDT entry as 0x3F/63, editing that to use the MDT entry num for the 3000 point msg (0x9D/157) seems to work, 0xC1BFF4 (byte) -> 0x9D in 1.1.0.
Probably wouldn't be too hard to pattern match that table, maybe should let it fail silently if it can't find the pattern though, in case some kind of EXE mod is installed.

Nice job with this!
A question, though, since I haven't been following discussions related to this: I see you're manipulating checks that check if pSys->language_8 is SYS_LANG_ENG_NTSC, right? Have you tried just changing language_8 to ENG_NTSC instead? Just curious to know if the game works just fine with that changed, since I imagine you're doing it differently to allow these changes to work on different langs as well.

Yeah, the game seemed to run fine with language_8 = 1. Only issue I noticed is that the English subtitles patch doesn't work.

Managed to hunt down the texID of the START texture and swap it for NEW GAME 🥳

With the clarified bottle cap requirements, I think we're safe to merge this?

Should be good to go 👍

BTW just found a doc that goes through the changes between different regions/releases of the game pretty extensively, a lot of it seems like it's probably just dynamic difficulty related, but maybe there's some surprises there too: https://docs.google.com/document/d/1aXN-Kxt0jbt9HQk_YrUNEn4WalTyiw18u2XBeuhqMts/edit

Most of that tracks with what I've discovered. Main thing I'm trying to figure out right now is how they buffed the knife.

Does changing UHD to 30FPS make any difference? IIRC most people assumed the increased damage was because of the framerate increase, hadn't really tried looking into it that much yet though. (I do know playing in 60FPS increases rate/accuracy of collision checks though, if that's related at all, which broke some speedrun strats iirc)
Those em** funcs are probably separated into the em** rel files in GC (which are stored inside the em**.drs files for some reason), got some IDBs for most of them, but could be some missing here:
re4_gcdebug_drs-rel-idbs.zip

Nah, same thing at 30FPS. I know people report weird things with the knife doing multihits at 60fps, so I made sure that wasn't the issue. I also tested the GC PAL version in the same scenario, and that has the buff knife too, so it looks like an intentional balance change they made.
Thanks for the rel IDBBs! I'll take a look.

Aha, so it was in GetWepDmVal. First there is the switch ( pEm->id_100 ), which is where the game retrieves the damage modifiers for each weapon per em**. The Ganado modifiers are stored in Dmg_tbl_em10. The knife is wep_no 16, and the 16th entry in  Dmg_tbl_em10 is 200. On NTSC Gamecube it's 100, so the knife was buffed to do double damage, and this carries over to almost every em type.
These table are interesting, because there's a lot of these changes. eg. the TMP also got a 40% damage buff vs Ganados. damage values for almost every weapon type were buffed by 33% vs em36 (Regenerator), 15% damage buff vs em39 (Krauser), etc...
Then I found this stuck in at the end of GetWepDmVal:
  else if ( v3 == 16 )
  {
    Wep_7D8 = pPL->Wep_7D8;
    if ( Wep_7D8 )
    {
      if ( Wep_7D8->field_42 <= 0 )
        return (int)((double)wep_nob * 1.3);
    }
  }

So it looks like the Wii port added a further 30% damage buff to the knife vs everything, that isn't active when using auto-knife, presumably to make manual knifing feel more impactful vs just using waggle vs everything.
The net result of this is the knife in UHD actually does 160% more damage to Ganados than it did on NTSC Gamecube.
Something else I noticed, and I remember someone mentioning this, the knife has a shorter range on NTSC Gamecube. Will need to find where those values are defined.

Last major thing I have to do is parse the differences in RandomItemCk. People have said that ammo drops more often in the NTSC GC version, and it's true. First thing I've noticed is that the dynamic assist for low ammo kicks in more often in GC-NTSC, because the game is weighting shotgun and TMP ammo less when it calculates your inventory's total ammo value in GetBulletPoints.
It's interesting that GetBulletPoints is still checking for Chicago Typewriter ammo in the Gamecube version, clearly Capcom just gave up on this weapon at some point and turned it into a 'fun' weapon. It would be fun to try and mod in a balanced version at some point.

@pas-de-2 Just noticed this seems to be crashing with the 1.0.6 debug .exe. Seems it is unable to find the pattern for file_msg_tbl_35.

Huh, that's interesting. It looks likefile_msg_tbl[14] is already set to 9F in the debug exe, so there's no 3F 00 01 00 entry for it to find. If you comment out that code and go to pick up the note, it says that scoring requirements are 3000, and if you set the language to something other than English, the game crashes when you try to pick it up.

I mean, I'm not opposed to outright disabling this feature on 1.0.6 debug if supporting it turns out to be too much work..

It's no problem to keep supporting NTSC mode with this, but I might have problems with the Separate Ways difficulty menu feature in my other PR. Do we have a 1.06 debug IDB uploaded somewhere?

I don't think we have much about 1.06 debug, actually. Unless @emoose has something locally?

Oh that wasn't too bad at all. I pushed fixes for everything to the Separate Ways PR.

@pas-de-2 do you know if the NTSC/dynamic difficulty stuff affects QTEs at all? Someone on steam forums mentioned they might have been different in the original release:

I was also just thinking that it would be interesting to have the option to disallow both dodge command inputs like in the original GCN -- do you happen to know if this option exists? (in other versions of the game, you can spam all four dodge input commands and it will succeed, but in the original GCN it would fail if you put in the wrong one first, so effectively you couldn't spam)

I don't think we have much about 1.06 debug, actually. Unless @emoose has something locally?

Nah haven't really done much work on that other than naming stuff like SystemSave/Global, maybe should look into it more some time though, might still be some debug things there that we haven't reimplemented yet.

Hm, is that true? Playing the debug NA version in Dolphin, I can press all the wrong buttons, so long as I eventually press the right buttons before time is up. At least for the boulder after the farm, and the axe Ganado cutscene at the start of 1-3.
I remember having a similar thought before, that they must have nerfed the QTEs somewhere along the way, but maybe they were always like this?


Break of min and max functions on Arduino Sam Due

Hi, I'm trying  to use you library but after adding it to my project I get an error on min and max functions that was previous inside my code.
Before adding your library everything works well.
I've patched platform.txt for SAM Due, as you said. I'm using also EthernetENC.
Is It my fault? I forgot to patch something?
To make my code working again I've to put this definitions after including your library:
#ifndef max
#define max(a,b) (((a) > (b)) ? (a) : (b))
#endif
#ifndef min
#define min(a,b) (((a) < (b)) ? (a) : (b))
#endif
Thanks,
Paolo

Thanks for using the library and it's good that you've found out a way to fix the problem. I also think that it's not your fault at all. There are too many libraries now, and each one will try to dictate the environment and conflicts will finally arise.
Without the Minimum Reproducible Code, it's difficult for anybody to guess what is going on with your code and which library introduces the issue.
It's helpful for other users to use your solution if getting the same issue. That's the way you, with your feedback,can contribute back to the Open Source Community.
Regards,


Change "Subject" to "Subject Keywords"

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[x] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Create a resource
Edit the resource
Under the text area of Abstract, verify the label is "Subject Keywords"

Add Liza. Do we need to update documentation for this user-facing change?

Build finished.


new Controller

Coverage decreased (-2.3%) to 62.309% when pulling 2fa253e657b1f530c42b80923e3d5210d258231d on ljbergmann:master into 2cee1db2994d852c25233fc0035ab5603ace5875 on Alpha-Trader:master.


v1.0.0

First production-ready version

Codecov Report

Merging #12 (c7b262f) into master (2baf466) will increase coverage by 0.42%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   85.28%   85.71%   +0.42%
==========================================
  Files          22       26       +4
  Lines         367      406      +39
==========================================
+ Hits          313      348      +35
- Misses         54       58       +4

Impacted Files
Coverage Δ

lib/src/model/language.dart
60.00% <60.00%> (ø)

lib/src/model/usage.dart
75.00% <75.00%> (ø)

lib/src/model/language.g.dart
100.00% <100.00%> (ø)

lib/src/model/usage.g.dart
100.00% <100.00%> (ø)

lib/src/translator.dart
89.56% <100.00%> (+0.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2baf466...c7b262f. Read the comment docs.


Security 3.11: Update to 100-level security point definitions

The current security point definitions are as follows.

Security Point
Description

100
View assays

110
Upload assays

120
Edit only assays created by self

130
Edit all assays

140
Delete only assays created by self

150
Delete all assays

160
Well edit only assays created by self

170
Well edit all assays

Changes proposed

Change description of 100 to "Can access View Assay activity"
New security point 115: "Can access Edit Assay activity"
Note: 110 controls both access to activity and ability to submit data from it.

Tasks:

Modify security points and user role definitions in master document
Update C_Security_Points to reflect the new values and names of security points
Update UserRoleDefinitions to reflect definitions of user roles in terms of new security points
Modify security point selector options in manage_user.html

Test Plan

A user with appropriate security can modify security points
Old and new security points work
Security points can be added and removed
Database updates are appropriate and all form controls are visually correct

Test Plan - SUCCESS!


Only play songs that haven't been played before

Brian's intuition is that we don't need this, so let's test without it.


We should use font-awesome's icons.yml rather than our generated charmap.json

Currently, qtawesome uses a character map that is stored as a .json file for the association
(icon-name -> unicode character). I generated these files based using yml source available in FontAwesome and Elusive icons.
Font-awesome:   https://github.com/FortAwesome/Font-Awesome/blob/master/src/icons.yml
Elusive icons:  https://github.com/reduxframework/elusive-icons/blob/master/src/icons.yml
Fortunately, they use the same schema in both projects.
To adapt more easily to future versions of FontAwesome and Elusive icons, we should probably directly use those yaml files. However, this would require qtawesome to have a dependency to yml. Unlike json, yml is not part of the Python standard library.
Similarly, I would have to produce a similar file for the spyder font.

@ccordoba12 any take on that?

Let's talk about this in our next week meeting

Relevant to the FA's update to v5: where the new icon names are

Is this still open ??

Hi, yes! Although seems like it has been open for a while now 🤔 Should we keep this open @ccordoba12 ?

We don't have a strong interest to use yml files here. So, perhaps we should close it.


[CONFIG][REQUEST] keep best ONLY if cp and iv conditions met aswell.

requested Behavior
you can make it so it only catches above  x and y but the way the transfer code is done as long as the keep best flag is there it will always keep 1 even if below the cp and iv req. I have been trying (badly) to add in a config option myself so that you can choose which is checked first.
at the moment it checks for keep best first then cp and iv limit and I am praying for the ability to check cp and iv first and IF it matches then keep only 1 above those limits.
Actual Behavior
if keep best is in the release config it doesnt matter what the release below is set to it will still keep 1.
if you remove the keep best then it will keep ALL above the cp and iv limit.
also the AND logic does not fix this
Steps to Reproduce
normal use.

How'd you get keep best to work? Mine never recycles/transferrs anything.

"release": {
"any": {"keep_best_cp": 1},
"// Example of always releasing Rattata:": {},
"// Rattata": {"always_release": true},
"// Example of keeping 3 stronger (based on CP) Pidgey:": {},
"// Pidgey": {"keep_best_cp": 3},
"// Example of keeping 2 stronger (based on IV) Zubat:": {},
"// Zubat": {"keep_best_iv": 2},
"// Also, it is working with any": {},
"// any": {"keep_best_iv": 3},
"// Example of keeping the 2 strongest (based on CP) and 3 best (based on IV) Zubat:": {},
"// Zubat": {"keep_best_cp": 2, "keep_best_iv": 3}
} just works to keep 1 best of everything.

Please add your config (removing user, pass, and gmapkey)


(PUP-6660) Remove --no-use_cached_catalog flag from --test flag

This reverts commit b330957e6ae2c6af0701c696cba628a574e7683f.
This reverts the change that added the --no-use_cached_catalog flag to
--test, because this made it impossible to ever use the cached catalog
during a test run. The user can once again decide whether a test
run should attempt to use cached catalogs or not.
It also reverts 3c8e953fcc02bfc98db40d87514c5e4b182cca44, which added an
associated test.

CLA signed by all contributors.

nit, typo in the commit message cahced catalog

Fixed.

Verified --test no longer implies use_cached_catalog:
$ bx puppet agent -t --server chara
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for chara.corp.puppetlabs.net
Info: Applying configuration version '1494612278'
Notice: Applied catalog in 0.04 seconds

But it can be requested:
$ bx puppet agent -t --server chara --use_cached_catalog
Info: Using cached catalog from environment 'production'
Info: Loading facts
Info: Applying configuration version '1494612278'
Notice: Applied catalog in 0.04 seconds

It can also be set to false to prevent the agent from falling back to the cached catalog:
$ bx puppet agent -t --server chara --no-use_cached_catalog
Warning: Unable to fetch my node definition, but the agent run will continue:
Warning: Failed to open TCP connection to chara:8140 (Connection refused - connect(2) for "chara" port 8140)
...
Error: Could not retrieve catalog from remote server: Failed to open TCP connection to chara:8140 (Connection refused - connect(2) for "chara" port 8140)
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run
...


Memory leak on rpz zone reloads when unbound is listening on an external interface

Hi all,
we are using unbound 1.11.0 on debian buster. we are testing the rpz support of unbound on two machines with 32GB RAM each. we get the rpz zones (~100MB) from our nsd servers by AXFR.
in our current configuration unbound uses around 5G after starting up and loading the rpz zones.
however, after a few hours unbound uses up the entire memory (32G) and the oom killer starts killing unbound processes.
please note: these are test machines and do not handle any requests from clients. the only thing unbound is doing is transferring and reloading the rpz zones (when it gets a notification from the nsd servers).
unbound is listening on two interfaces/IP numbers on the same network. one is the hosts IP address, the other is a floating IP.
to our total surprise (and it took quite a while to track that down because we would never have believed it) the memory leak described above does NOT happen, when unbound listens only on one interface/IP number.
this graph shows ram usage when unbound is listening on two interface:

This graph shows the same time period but with unbound only listening on one interface

the increases in RAM usage (first graph) happen when rpz zones are being transferred and reloaded. however, the increase is different, even if the same rpz zone is reloaded.
note that the first few zone reloads are also visible in the second graph, but only much smaller. here, the increase of RAM usage on zone reloads is not noticeable after some time.
it appears that memory is leaked when reloading rpz zones, but only when unbound listens on more than one interface.
this is our unbound.conf:
server:
  verbosity: 3
  num-threads: 4
  port: 53
  interface: aaa.bbb.ccc.6 # <- if this line is removed, the memory leak does not happen!
  interface: aaa.bbb.ccc.3
  interface-automatic: no
  outgoing-range: 206
  outgoing-port-permit: "32768-65535"
  outgoing-port-avoid: "0-32767"
  msg-cache-size: "32m"
  msg-cache-slabs: 4
  so-rcvbuf: "1m"
  so-sndbuf: "1m"
  ip-transparent: no
  ip-freebind: yes
  rrset-cache-slabs: 4
  rrset-cache-size: "64m"
  infra-cache-slabs: 4
  access-control:  aaa.bbb.ccc.0/24 allow
  access-control:  aaa.bbb.ddd.0/24 allow
  access-control:  aaa.bbb.eee.0/24 allow
  access-control:  aaa.bbb.fff.0/24 allow
  access-control:  aaa.bbb.ggg.0/24 allow
  username: "unbound"
  directory: "/etc/unbound"
  use-syslog: yes
  log-time-ascii: no
  log-queries: no
  log-replies: no
  hide-identity: yes
  pidfile: "/run/unbound.pid"
  root-hints: "/etc/unbound/root.hints"
  module-config: "respip validator iterator"
  auto-trust-anchor-file: "/var/lib/unbound/root.key"
  trusted-keys-file: "/etc/unbound/keys.d/*.key"
  key-cache-slabs: 4
  include-toplevel: "/etc/unbound/unbound.conf.d/*.conf" # this include our rpz zones, nothing else

Best,
Hp

I investigated a bit further. unbound works well with:
interface-automatic: no
ip-transparent: no
ip-freebind: yes

(no interfaces: configured, besides the default localhost)
unbound then listens on <IP_ADDRESS>:53, ::1:53

if I configure one interface explicitly, e.g. interface: aaa.bbb.ccc.ddd, unbound's memory allocation increases substantially with each rpz zone reload. the same thing happens if I set freebind: no (but keep the interface line in the config)
unbound is listening on the configured IP address, i.e. aaa.bbb.ccc.ddd:53 (but not on the localhost anymore)

if use interface-automatic, i.e.
interface-automatic: yes
ip-transparent: no
ip-freebind: no

(without any interfaces configured) unbound is listening on <IP_ADDRESS>:53. same thing happens: unbound's memory allocation increases substantially with each rpz zone reload.

Thus, it seems to me, that as soon as unbound listens on an interface other than the loopback interface, there is a memory leak when reloading rpz zones. I might be that this is related the one of my rpz zone is huge (more than a million entries) which are all CNAMEs. See also:
https://lists.nlnetlabs.nl/pipermail/unbound-users/2020-October/006993.html
note that this contradicts my first post, where I said that the memory leak occurs when several interfaces are defined. I realized only later that one of the IP numbers I configured, was not present on the system, therefore in fact, it happens also using only a single interface.
I did not try ip-transparent: yes, since I do not like running unbound as root.
I also have no auth-zones (other than rpz zones) configured. Thus I cannot say if this is specific to rpz, or if it would also occur with auth-zones,

I updated to unbound 1.12.0
The behavior is still the same.


I am using SpeechRecognizer class in JavaScript and the intermediate recognition result obtained using the recognize method does not have punctuation, what should I do if I want to have punctuation?

I am using SpeechRecognizer class in JavaScript and the intermediate recognition result obtained using the recognize method does not have punctuation, what should I do if I want to have punctuation?

@pengchengZhi001 Thank you for using JS Speech SDK, and writing this issue up. Because each sentence is usually a longer collection of words, and the intermediate recognition result merely parses shorter collections of words, punctuation can't really be assigned correctly without a large context.
For example, if you got the intermediate response "my friend drove a car", what punctuation should be assigned to that?
The final sentence could be, depending on the rest of the turn, "My friend drove a car to New York." or "My friend drove a car, but decided to start taking the bus instead" or "My friend drove. A car was over there." or just "My friend drove a car."
Does that make sense?

Closed as answered; punctuation and capitalization is only added in the final result. Please open a new issue if more support is needed.

@glharper What if I need him to return the recognizer. recognized event faster? How do I configure SpeedConfig?

@glharper What if I need him to return the recognizer. recognized event faster? How do I configure SpeedConfig?

There's nothing in the JS SDK to configure the speed or size of the recognized callback. You could possibly throttle the input  speed of the audio using a pushstream, which might have the desired effect.

@glharper Just wanted to point out that Google ASR API offers punctuation on Temporary results. There are possible use cases why a user wants prediction of punctuation while the incoming speech is still unfolding. Predictions are unstable towards the end of the transcription, but tend to be stable towards the beginning. You might want to reconsider adding this in future.

@fantinuoli Thanks for letting us know, I'll pass this info on to the service team.


jrl-cmakemodules: 0-unstable-2024-05-22 -> 0-unstable-2024-08-05

Description of changes
The main change is a new workspace setup, which allow multiple projects depending on jrl-cmakemodules to be used in the same CMake (meta) project: https://github.com/jrl-umi3218/jrl-cmakemodules/pull/701
Other simpler updates are:

sdfformat: update with latest versions
python: look for Numpy to fill Python_NumPy_INCLUDE_DIR hint
find-external: remove suffix from library names (to allow use with macos .dylib)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 332451 run on x86_64-linux 1

21 packages built:

crocoddyl
jrl-cmakemodules
pinocchio
python311Packages.crocoddyl
python311Packages.eigenpy
python311Packages.eigenpy.dev
python311Packages.eigenpy.doc
python311Packages.example-robot-data
python311Packages.hpp-fcl
python311Packages.hpp-fcl.dev
python311Packages.hpp-fcl.doc
python311Packages.pinocchio
python312Packages.crocoddyl
python312Packages.eigenpy
python312Packages.eigenpy.dev
python312Packages.eigenpy.doc
python312Packages.example-robot-data
python312Packages.hpp-fcl
python312Packages.hpp-fcl.dev
python312Packages.hpp-fcl.doc
python312Packages.pinocchio

Result of nixpkgs-review pr 332451 run on aarch64-darwin 1

20 packages built:

crocoddyl
pinocchio
python311Packages.crocoddyl
python311Packages.eigenpy
python311Packages.eigenpy.dev
python311Packages.eigenpy.doc
python311Packages.example-robot-data
python311Packages.hpp-fcl
python311Packages.hpp-fcl.dev
python311Packages.hpp-fcl.doc
python311Packages.pinocchio
python312Packages.crocoddyl
python312Packages.eigenpy
python312Packages.eigenpy.dev
python312Packages.eigenpy.doc
python312Packages.example-robot-data
python312Packages.hpp-fcl
python312Packages.hpp-fcl.dev
python312Packages.hpp-fcl.doc
python312Packages.pinocchio


Dont perform which twice when check is true

Right now, if check is true we get the result of _which(tool, false) and then don't use that result if the tool is found. We should just short circuit there if the tool is found, rather than basically performing the _which an extra time

Can we add a test for this?

Can we add a test for this?

Functionally this shouldn't change behavior, so existing tests should provide the coverage we need. Beyond that, I'm not really sure what we'd be testing.


[CT-738] [Enhancement] dbt debug command not outputting logs correctly

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When running the command dbt debug the logs are not output correctly. When the command is run with json log formatting turned on the log entries are still printed to the console in the same textual way. It also appears they are not output to the logs/dbt.log file either. When --debug is turned on alongside the json formatter then only the debug level logs are output using the json format.
Expected Behavior
It would be good to have the loglines of the debug command output using the json formatter for all levels of logs. We use dbt debug as an pre run test to check for any connections issues. We would like to be able to parse the logs for any lines with 'level': 'error' across our entire process, but this connection test doesn't get captured because of the lack of json logging.
Steps To Reproduce
Simply run dbt --log-format=json debug in any situation. With --debug included the difference becomes even more apparent.
Relevant log output
I've removed some pieces/lines which contain sensitive information.

{"code": "A001", "data": {"v": "=1.1.0"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "info", "log_version": 2, "msg": "Running with dbt=1.1.0", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.708619Z", "type": "log_line"}
{"code": "A003", "data": {"user_state": "tracking"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Tracking: tracking", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.711659Z", "type": "log_line"}
{"code": "Z040", "data": {"kwargs": "{'category': 'dbt', 'action': 'invocation', 'label': 'start', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d827e50>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d827e80>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d8f1fa0>]}"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'start', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d827e50>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d827e80>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d8f1fa0>]}", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.713623Z", "type": "log_line"}
dbt version: 1.1.0
python version: 3.8.13
python path: /usr/local/bin/python
os info: Linux-5.10.104-linuxkit-x86_64-with-glibc2.2.5
Using profiles.yml file at /root/.dbt/profiles.yml
Using dbt_project.yml file at /usr/app/dbt_dir/dbt_project.yml

Configuration:
  profiles.yml file [OK found and valid]
  dbt_project.yml file [OK found and valid]

Required dependencies:
{"code": "Z006", "data": {"cmd": ["git", "--help"]}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Executing \"git --help\"", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.827315Z", "type": "log_line"}
{"code": "Z008", "data": {"bmsg": ""}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "STDERR: \"b''\"", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.836976Z", "type": "log_line"}
 - git [OK found]

Connection:
  host:
  port: 443
  cluster:
  endpoint: None
  schema:
  organization: 0
{"code": "E005", "data": {"conn_name": "debug", "conn_type": "spark"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Acquiring new spark connection \"debug\"", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.845000Z", "type": "log_line"}
{"code": "E015", "data": {"conn_name": "debug", "conn_type": "spark"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Using spark connection \"debug\"", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.846550Z", "type": "log_line"}
{"code": "E016", "data": {"conn_name": "debug", "sql": "select 1 as id"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "On debug: select 1 as id", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.847964Z", "type": "log_line"}
{"code": "E037", "data": {"connection_state": "init"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Opening a new connection, currently in state init", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T13:58:50.849569Z", "type": "log_line"}
{"code": "E001", "data": {"args": [], "base_msg": "Error while running:\nselect 1 as id", "name": "Spark"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Spark adapter: Error while running:\nselect 1 as id", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T14:00:54.908987Z", "type": "log_line"}
  Connection test: [ERROR]

1 check failed:
dbt was unable to connect to the specified database.
The database returned the following error:

  >Object of type FailedToConnectException is not JSON serializable

Check your database credentials and try again. For more information, visit:
https://docs.getdbt.com/docs/configure-your-profile

{"code": "Z040", "data": {"kwargs": "{'category': 'dbt', 'action': 'invocation', 'label': 'end', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d6462b0>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d62da60>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d62dd90>]}"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Sending event: {'category': 'dbt', 'action': 'invocation', 'label': 'end', 'context': [<snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d6462b0>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d62da60>, <snowplow_tracker.self_describing_json.SelfDescribingJson object at 0x7fb85d62dd90>]}", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T14:00:54.913884Z", "type": "log_line"}
{"code": "Z042", "data": {}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Flushing usage events", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T14:00:54.914749Z", "type": "log_line"}
{"code": "E008", "data": {"conn_name": "debug"}, "invocation_id": "27f7d084-0279-4455-8a5e-b937004b5930", "level": "debug", "log_version": 2, "msg": "Connection 'debug' was properly closed.", "pid": 13, "thread_name": "MainThread", "ts": "2022-06-09T14:00:55.472184Z", "type": "log_line"}

Environment
- OS:Linux-5.10.104-linuxkit-x86_64-with-glibc2.2.5
- Python: 3.8.13
- dbt:1.1.0

What database are you using dbt with?
other (mention it in "Additional Context")
Additional Context
databricks

@UselessAlias Thanks for opening, you're right!
The debug task does a lot of printing today, rather than real logging. That's why it shows up the same regardless of --log-format, since these aren't actually events / logs.
https://github.com/dbt-labs/dbt-core/blob/72b6a80b07b3acc9aa64ae65c5d82191dbb1aa11/core/dbt/task/debug.py#L106-L111
(there's more, that's just a taste)
I agree these should be real events (and thereby real logs). I see at least four, though maybe it should be more to better differentiate between success and error:

DebugEnvironmentDetails
DebugDependenciesResult
DebugConfigurationResult
DebugConnectionResult

I'm going to relabel this as an enhancement rather than a bug. I agree that it's really a prerequisite for making the debug task usable by machines, in addition to human beings trying to debug their local CLI.

AC: Go through and check for all print statements and change them structured log

Can also remove the method in this test and use run_dbt_and_capture instead.

A PR for this is up :>
As I snuck in Emily's suggestion as best I could (required a tiny bit of editing on the "back end") of our test framework.

@jtcohen6 Seeing your comment, I went through the code of list and did some refactoring for filtering out messages which nets us the following behavior. First command was dbt list and the second dbt --log-format json list | jq '.msg'.

The structured json logs are info type; just lists the name, no extra messages ahead of time.
There's still a print in the file, but if a user wants an ls in structured logs, they can have em.
=======
per Leah's comment, there remains only:

the list for basic printing of file names
the error message when there are no available adapters


Media Upload Queue

Context
Videos that need to be transcoded during upload cannot be previewed in the editor/library until they have been processed by FFmpeg. In that scenario, we currently don't display anything until transcoding is finished, which means the user has to wait a long time for feedback.
For improved UX around video optimization during upload, we want to display a placeholder image first and replace it with an actual preview as soon as it gets available—all while the upload is still progressing behind the scenes.
Unfortunately, the current media upload queue is not very stateful in that regard and does not allow for such updates in the middle of the process, nor does the consumer even know what state an individual file is currently in.
Summary
This PR introduces a new hook to act as a queue for media uploads where we know the state (e.g. pending/transcoding/uploading/finished/cancelled) of each file being uploaded at all times.
Not only does this allow us to update media resources mid-progress, but we can now also do things like displaying tooltips for items still being processed (#6089).
Regular image and video uploads should not be affected by this change
The most significant change is when uploading video files that need to be transcoded, for example a MOV file from iPhone.
For such files, the process looks a bit like follows:

Drop video into editor
A placeholder gray square is displayed on the editor (because we don't know its dimensions yet)
Video is being transcoded
Two things now happen in parallel:

Try to replace placeholder with an actual preview of the image and update its dimensions once they become known
Upload video and replace any placeholder or preview with the uploaded file

Relevant Technical Choices

Media Provider: new prependMedia action to add items to the beginning of the media library. This avoids having to replace the whole list of items with setMedia, which is error prone if using outdated items
Media Provider: update updateMediaElement to allow overriding the resource's ID. This is necessary because local resources (i.e. still being uploaded) now have an ID already, but after upload they will have a WordPress attachment ID.
Resource Type: a resource now has a new isPlaceholder property to identify whether it's a blank
Story Provider: adds a new deleteElementsByResourceId action to delete elements by resource ID across all pages (deleteElementsById only works on the current page) in case upload failed. This is needed because the user could have duplicated/copied elements/pages while upload was in progress.
useTranscodeVideo:  moves the time & error tracking closer to the source
Canvas: do not display video playback button for placeholders
useUploader: separate file validation and actual uploads into two separate  validateFileForUpload and uploadFile functions
useUploader: move the useTranscodeVideo usage to useUploadMedia because it's actually only used and needed by that. useUploader should not be concerned with transcoding.
useUploadMedia: validate files for upload before doing anything, so the user has more instant feedback
useUploadMedia: try to generate preview once at the beginning (as it works for most files) and again once transcoding has finished

To-do

More tests for the media upload queue
Improve/clarify position and behavior for placeholder resources on canvas / in media library
Testing & bug fixes as we go

User-facing changes
Uploading a regular image
(no visible change)
https://user-images.githubusercontent.com/841956/109307413-e6c76780-7840-11eb-8b66-53f2c0498bfb.mov
Uploading a regular video
(no visible change)
https://user-images.githubusercontent.com/841956/109325776-9e1aa900-7856-11eb-8f25-ad37c8af2a95.mov
Uploading a video requiring additional transcoding
(see placeholder element before preview later on)
https://user-images.githubusercontent.com/841956/109307458-f941a100-7840-11eb-914d-c2585fa721cb.mov
Uploading a video requiring additional transcoding but with poster
(see poster image before preview later on)
https://user-images.githubusercontent.com/841956/109325859-b7235a00-7856-11eb-9237-7fa45ed28790.mov
Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

Prerequisites

Download some test files here:
test files.zip

Turn on video optimization experiment and enable video optimization in settings

ZIP file, dropped on media library

Drop ZIP file onto media library
See snackbar message saying that the file type is not supported

ZIP file, dropped on editor

Drop ZIP file onto editor
See snackbar message saying that the file type is not supported

PNG image, dropped on editor

Drop PNG image onto editor
See an instant preview of the image on the canvas and in the media library
See a progress bar for the image in the media library while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

PNG image, dropped on media library

Drop PNG image onto editor
See an instant preview of the image in the media library
See a progress bar for the image in the media library  while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

MP4 video, dropped on editor

Drop MP4 video onto editor
See an instant preview of the video on the canvas and in the media library
Verify that you can play the video on the canvas while it's being uploaded
See a progress bar for the video in the media library while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

MP4 video, dropped on media library

Drop MP4 video onto editor
See an instant preview of the video in the media library
See a progress bar for the video in the media library  while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

MOV video (H.264), dropped on editor

Drop MOV video onto editor
See an instant preview of the video on the canvas and in the media library
Verify that you can play the video on the canvas while it's being uploaded
See a progress bar for the video in the media library while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

MOV video (H.264), dropped on media library

Drop MOV video onto editor
See an instant preview of the video in the media library
See a progress bar for the video in the media library  while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

MOV video (HEVC), dropped on editor

Drop MOV video onto editor
See a gray, rectangular placeholder element on the canvas and in the media library
Verify that you cannot play the video on the canvas (no play button)
See a progress bar for the video in the media library while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress
See how the placeholder gets replaced with an actual preview after some time, and that its dimensions and position on the canvas change.

MOV video (HEVC), dropped on media library

Drop MOV video onto editor
See a gray placeholder element in the media library
See a progress bar for the video in the media library while it's being uploaded
Verify that you get a warning trying to close the window while upload is in progress

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

No
Does this PR change what data or activity we track or use?

No
Does this PR have a legal-related impact?

No
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6088
Also partially addresses #6400 by using URL.revokeObjectURL() as needed
Also fixes #6427

I am seeing this bug more while testing this - https://github.com/google/web-stories-wp/issues/6427

I think we need to change these lines
https://github.com/google/web-stories-wp/blob/b851f3ca8c24d50ec327b4c5121d338d64ef7cbc/assets/src/edit-story/components/library/panes/media/common/innerElement.js#L107-L112
With this PR, we are adding a state where we know that poster is going to be null. This just makes the averageColor issue worse.

I am seeing this bug more while testing this - #6427

I think we need to change these lines
https://github.com/google/web-stories-wp/blob/b851f3ca8c24d50ec327b4c5121d338d64ef7cbc/assets/src/edit-story/components/library/panes/media/common/innerElement.js#L107-L112
With this PR, we are adding a state where we know that poster is going to be null. This just makes the averageColor issue worse.

While I am not seeing the bug at the moment, I've made useAverageColor more robust now in 75f2d752738ec8890f8da4d0d907810ac98f8669, fixing this once and for all.

I was unable to upload a 164MB MP4. This should be have been transcoded.


[feature] [BE] Implement last.fm api call function

Describe the feature
Get play count using lastfm_id, track title
Data

Technical Details

[ ] Implement in Genie/genie/server/backend/utils/lastfm.py

Minimum Requirements
Acceptance Criteria

[ ] nothing

You can find details here. (https://www.last.fm/api)
We will get discord user's track play count using last.fm

Yes, you're right


UI rediraction fixed, Memory collection optimized.

Issue 1
In terms of resource metrics data 'jobContext' was used. It leads the UI redirect to "Job initialization" steps each time.
BUG: https://github.com/microsoft/azure-pipelines-agent/issues/4469
SLN: Switch context to step execution each time
Issue 2
Memory collection was wrong due to missing siblings processes.
Sln: Collect all memory usages from siblings processes

/azp run

Any update about this bug please ?

Also looking for an update on when this will be released? As it is quite painful trying to monitor running pipeline logs right now.


replace github.com/juju/arrar by /errors

What problem does this solve? What does this package do better than the other one? (Why do we need either one?)

https://bugsnag.com/blog/go-errors explains it. Basically, when you return an error, you don't get any information on where it was originally encountered. In Go, these errors tend to bubble up until a function decides to handle them (print out, terminate program, etc), but this doesn't give any context where this error occured originally. And for some errors, the message attached to the error is something very generic, like "Permission Denied", without the information what has been accessed.
I think it's a good idea to annotate things to errors so that the is a bit more context. We could do that by using fmt.Errorf() so that instead of return err we use return errors.Errorf("unable to open file %s: %v", path, err), but this wraps the original error in a way that you cannot get it out again in a higher function, and e.g. compare it with io.EOF.
The juju/errors package solves this problem, allowing to wrap an error, annotate it with context, and still allow accessing the original error.


Support 'puppetlabs-powershell', '5.0.0'

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 2021.4.0
Ruby:
Distribution:
Module version: 4.1.0

How to reproduce (e.g Puppet code you use)
How to request this module to upgrade to 'puppetlabs-powershell', '5.0.0'
What are you seeing
What behaviour did you expect instead
Output log
Any additional information you'd like to impart

Hi,
based on a discussion in https://groups.io/g/voxpupuli/message/449 we decided to archive this repository. I'm going to close all issues and PRs. If you're interested in maintaining the module, please respond to our mailinglist.


Apply missing secret filter for discoverySelector

This was the one missing spot for the filter

@howardjohn need to backport?


When to use Intent for data to activity and when load from repository?

This is a general question.
In these blueprints the Intent is used to pass the TaskId from TasksActivity to eg TaskDetailActivity/Fragment.
Then the data of this task is loaded and shown.
My question is: If I have all data in the list (here TasksActivity/TasksFragment) - should I put this data in an Intent or should the DetailFragment load the data from repository?
For my understanding, if all data is already loaded and "fresh" I should use Intent.
If I don't have all data or data is outdated then load all from repository.
UPDATE:
The TaskId is passed to Fragment.newInstance AND even to the presenter. Why?

I think it's just for general.
make following linke reference.
http://stackoverflow.com/questions/25194102/is-it-more-efficient-to-pass-large-parcelable-or-pass-id-and-query-db
parcelable data is limited to 1MB, so if you intent bitmap over 1MB, it's better to use task id and obtain task from repository.

@fisache thanks for the answer. This helps a lot.


API is down

API is not responding to requests.
Used command curl "https://api.quotable.io/quotes?sortBy=author&order=desc" and it just waits and I never get a response. Same issue with a JavaScript fetch() request.

Local fix that will help:
https://github.com/lukePeavey/quotable/issues/218#issuecomment-2256303807


Refactor to use rspec filtering

Just a draft PR for now to replace some inline logic with rspec filters and tags.
I'm also tweaking the Jruby handling a bit to be more generic since there's now also Truffleruby.

@sferik What do you think of this approach?

I like this approach. I'll be happy to merge it when the build failures are fixed.

Does this supersede https://github.com/intridea/multi_json/pull/213? If so, can you close that PR?

@sferik Thanks. I'm still working out some JRuby/Truffleruby things, probably shoulda left it as a draft. I'll ping you when I think it's ready.

Looks like tests are passing. Is this ready for review now?

@sferik I could tinker with it some more, but I guess it's ready.
The main issue was that the tags weren't as useful as I hoped since the require statements are evaluated first, and blow up with or without tags. I think they'd have to be removed from the file list first, but that can be done in a future refactor.
Why was this closed?

Oops. I must have accidentally hit “Comment and Close” instead of “Comment”. Pressing “Reopen and comment” now. ☺


DRY event maps

collection: {
  'add': '_resetStatus',
  'remove': '_resetStatus',
  'change': '_resetStatus'
}

it would be nice to have a way to say:
"add, remove, change": "_resetStatus"
or something else to do with an array of keys or what have you.

Added support for a ',' separator in event names.


⚠ File access (beta) has degraded performance

In 8e1aa80, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 11232 ms

Resolved: File access (beta) performance has improved in ed8e265.


How to add custom "RequestedAttributes" into SP metadata

Hi,
I would like to be able to customize the way through which the SP's EntityDescriptor metadata is generated to have something similiar to this one (maybe this feature is already implemented in the library, but I haven't been able to find it :D):
<md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata"
    entityID="https://spid.serviceprovider.it"
    ID="_0j40cj0848d8e3jncjdjss...">
    <ds:Signature xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
        [...]
    </ds:Signature>
    <md:SPSSODescriptor
        protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol"
        AuthnRequestsSigned="true"
        WantAssertionsSigned="true">
        <md:KeyDescriptor use="signing">
            [...]
        </md:KeyDescriptor>
        <SingleLogoutService
            Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"
            Location="https://spid.serviceprovider.it/slo-location"
            ResponseLocation="https://spid.serviceprovider.it/slo-location"/>
        <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:transient</NameIDFormat>
        <md:AssertionConsumerService
            index="0" isDefault="true"
            Location="https://spid.serviceprovider.it/sso-location"
            Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"/>
        <md:AssertionConsumerService
            index="1"
            Location="https://spidSP.serviceProvider.it/sso-location"
            Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST"/>
        <md:AttributeConsumingService index="0">
            <md:ServiceName xml:lang="it">Set 0</md:ServiceName>
            <md:RequestedAttribute Name="name"/>
            <md:RequestedAttribute Name="familyName"/>
            <md:RequestedAttribute Name="fiscalNumber"/>
            <md:RequestedAttribute Name="email"/>
        </md:AttributeConsumingService>
            <md:AttributeConsumingService index="1">
            <md:ServiceName xml:lang="it">Set 1</md:ServiceName>
            <md:RequestedAttribute Name="spidCode"/>
            <md:RequestedAttribute Name="fiscalNumber"/>
        </md:AttributeConsumingService>
    </md:SPSSODescriptor>
    <md:Organization>
        <OrganizationName xml:lang="it">Service provider</OrganizationName>
        <OrganizationDisplayName xml:lang="it">Nome service provider</OrganizationDisplayName>
        <OrganizationURL xml:lang="it">http://spid.serviceprovider.it</OrganizationURL>
    </md:Organization>
</md:EntityDescriptor>

Thanks in advance.

You will need to extend the Metadata class and a accept a List of Strings per ACS you want to support. and then change the generateSubstitutor and getMetadataTemplate methods to include the AttributeConsumingService part

Hi @pitbulk,
I  need to implement SPID authentication in my company. SPID (https://www.spid.gov.it/) is the Italian government official federated authentication system for citizens and companies and is based on SAML 2.0.
After studying the argument, I selected java-saml as the library to use, because it goes straight to the point, has an excellent "quick start" guide here on GitHub and provides almost all the features I need.
However, to properly support SPID I would still need to enhance it a bit. I would like to know whether you're open to pull requests for such enhancements.
The first one (and it's the reason I'm writing here) is the ability to support multiple attribute consuming services. My plan is the following:

allow to configure (zero or more) attribute consuming services in settings, just like the assertion consumer service: I don't see good reasons for not having attribute consuming services configured there just like the other aspects of SP configuration
add the ability to specify the index for each attribute consuming service and its isDefault attribute
deprecate com.onelogin.saml2.settings.Metadata.Metadata(Saml2Settings, Calendar, Integer, AttributeConsumingService) but maintain it for backward compatibility; when using this constructor, the specified AttributeConsumingService will override any other attribute consuming service specified in the Saml2Settings instance; this should guarantee the exact same behaviour if existing client code is left untouched
add a com.onelogin.saml2.Auth.login() overloading that allows to specify the AttributeConsumingService index to send to the IdP, with a selector mechanism; all the other existing login() overloading will default to a "default selector" (i.e.: no AttributeConsumingServiceIndex specified, rely on the default one); this should guarantee backward compatibility

As an alternative to the last point, since the number of overloadings is quite huge already, I think it should be better to provide a login() overloading that takes the following signature:
public String login(String returnTo, AuthnRequest authRequest, Boolean stay, Map<String, String> parameters)

In this way, by enhancing AuthnRequest, we can specify further information required to create the actual AuthnRequest message without producing so many login() overloadings. For instance, another (lower priority) enhancement that I have in mind is the ability to specify multiple assertion consumer services, which would require another (optional, of course) selector parameter to be specified when creating the AuthnRequest.
My plan is to implement this over the current version of java-saml, so only for Java 8+. What do you think?


Regions names for parameterized tests

Description
Some tests generated for ArraysQuickSort.sort in Parameterized mode are presented as regular tests.
They are put in to region ///region Tests for method sort(int[], int, int, int[], int, int) that cannot be presented as parameterized
Now there are 2 types of such tests:

#1252
#1161

To Reproduce

Install latest build from main into IDEA 2022.2.3
Check File -> Settings are default: 95% Symbolic execution
Open UTBotJava project
Generate tests for ArrayQuickSort with JUnit5 and Parameterized on.

Expected behavior
Regions in the generated tests are supposed to be similar to the ones generated with parameterization off.
Actual behavior
Regions in generated tests, that cannot be presented as parameterized, do not contain information about which suite they belong to.
Fuzzing / Symbolic, Successful / Explicitly thrown exceptions / ...
Visual proofs (screenshots, logs, images)
Regions for parameterized tests:

Regions for regular tests:

Environment
IntelliJ IDEA

@korifey @amandelpie @EgorkaKulikov
Could you please check the expected and actual result? What would be the correct way to name these suites?

@alisevych could we say now that we are satisfied for today with the existing master

@alisevych could we say now that we are satisfied for today with the existing master?

As for regions for parameterized tests - they are readable.


polkadot/frontier0.9.24-1 upgrade; frontier test script change

Codecov Report

Merging #324 (12acc02) into master (001af27) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   66.88%   66.92%   +0.04%
==========================================
  Files          55       55
  Lines       16605    16594      -11
==========================================
  Hits        11106    11106
+ Misses       5499     5488      -11

Impacted Files
Coverage Δ

cli/src/cli.rs
0.00% <ø> (ø)

cli/src/command.rs
0.00% <0.00%> (ø)

cli/src/service.rs
0.00% <0.00%> (ø)

rpc/src/lib.rs
0.49% <0.00%> (-0.01%)
:arrow_down:

runtime/src/lib.rs
10.96% <0.00%> (+0.05%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


WIP: symfony v4 + 7.1 bump

awesome to see this :+1:
if you get stuck, ping me and i will try to help find whats wrong.

First i'm gonna just do chores like return types / php 7 compat etc.
Other goal would be to split the "real" logic into a dedicated pure package (lunetics/locale) which does the locale detection etc and keep this as sole integration bundle of this lib


chore: Add helper tooltips on page properties

Fixes #8487
Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Manual
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: chore/page-properties-tooltip

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
54.92 (0.02)
36.58 (0)
33.84 (-0.02)
55.47 (0.02)

:red_circle:
app/client/src/constants/messages.ts
74.41 (-0.1)
100 (0)
24.31 (-0.31)
79.94 (0.19)

:green_circle:
app/client/src/pages/Editor/PagesEditor/ContextMenu.tsx
68.42 (3.71)
60 (0)
0 (0)
72.22 (3.47)

:green_circle:
app/client/src/pages/Editor/PagesEditor/EditName.tsx
43.9 (6.06)
20 (0)
0 (0)
48.65 (6.23)

:green_circle:
app/client/src/pages/Editor/PagesEditor/PageListItem.tsx
66.67 (3.81)
57.14 (0)
0 (0)
66.67 (3.81)

@ramsaptami Please test this on DP!

/ok-to-test sha=8ed5c29

/ok-to-test sha=5ae739d


Allow users to use a dev release of the library

But I'm not sure how.

According to the current size of the project, this feature doesn't seem very useful at the moment. However, we provide some information here for possible future implementation:
Using of dev release seems to be possible with changeset using prerelease mode. However, this mode seems to be broken with monorepo because it increases the dependency version of the updated package on all other dependent packages
We close this issue as not-planned 🚀