Issues with async discord connection

INFO:discordrp_mpris.__main__:Connection to Discord client lost. Reconnecting...
WARNING:asyncio:socket.send() raised exception.
WARNING:asyncio:socket.send() raised exception.
INFO:discordrp_mpris.__main__:Connection to Discord client lost. Reconnecting...
WARNING:asyncio:socket.send() raised exception.
WARNING:asyncio:socket.send() raised exception.
INFO:discordrp_mpris.__main__:Connection to Discord client lost. Reconnecting...
WARNING:asyncio:socket.send() raised exception.
WARNING:asyncio:socket.send() raised exception.
INFO:discordrp_mpris.__main__:Connection to Discord client lost. Reconnecting...
WARNING:asyncio:socket.send() raised exception.
WARNING:asyncio:socket.send() raised exception.

Discord is running fine in the meantime. I am using Ubuntu 18.04.3 LTS

Has this worked for you before? Has discord been installed as a snap?

It only works for some time (~10 minutes) after it is launched. Discord is installed via deb file.

I'm thinking of rewriting parts of the tool, in addition to implementing the other enhancements in open issues, which may or may not make it more stable, but no ETA as of now.

 pm@VIX  /home/pm   systemctl --user status discordrp-mpris.service                                                                                 14:58:21
● discordrp-mpris.service - Discord Rich Presence based on mpris2 media players
     Loaded: loaded (/usr/lib/systemd/user/discordrp-mpris.service; enabled; vendor preset: enabled)
     Active: failed (Result: exit-code) since Thu 2020-07-09 14:58:13 CEST; 25s ago
    Process: 301790 ExecStart=/usr/bin/discordrp-mpris (code=exited, status=1/FAILURE)
   Main PID: 301790 (code=exited, status=1/FAILURE)

juil. 09 14:58:13 VIX discordrp-mpris[301790]:     op, length = await self._recv_header()
juil. 09 14:58:13 VIX discordrp-mpris[301790]:   File "/usr/lib/python3.8/site-packages/discord_rpc/async_.py", line 108, in _recv_header
juil. 09 14:58:13 VIX discordrp-mpris[301790]:     header = await self._recv_exactly(8)
juil. 09 14:58:13 VIX discordrp-mpris[301790]:   File "/usr/lib/python3.8/site-packages/discord_rpc/async_.py", line 247, in _recv_exactly
juil. 09 14:58:13 VIX discordrp-mpris[301790]:     return await self.reader.readexactly(size)
juil. 09 14:58:13 VIX discordrp-mpris[301790]:   File "/usr/lib/python3.8/asyncio/streams.py", line 721, in readexactly
juil. 09 14:58:13 VIX discordrp-mpris[301790]:     raise exceptions.IncompleteReadError(incomplete, n)
juil. 09 14:58:13 VIX discordrp-mpris[301790]: asyncio.exceptions.IncompleteReadError: 0 bytes read on a total of 8 expected bytes
juil. 09 14:58:13 VIX systemd[3478]: discordrp-mpris.service: Main process exited, code=exited, status=1/FAILURE
juil. 09 14:58:13 VIX systemd[3478]: discordrp-mpris.service: Failed with result 'exit-code'.

 pm@VIX  /home/pm   systemctl --user start discordrp-mpris.service                                                                                 14:58:39

 pm@VIX  /home/pm   systemctl --user status discordrp-mpris.service                                                                                 14:58:47
● discordrp-mpris.service - Discord Rich Presence based on mpris2 media players
     Loaded: loaded (/usr/lib/systemd/user/discordrp-mpris.service; enabled; vendor preset: enabled)
     Active: active (running) since Thu 2020-07-09 14:58:47 CEST; 2s ago
   Main PID: 360463 (discordrp-mpris)
     CGroup<EMAIL_ADDRESS>             └─360463 /usr/bin/python /usr/bin/discordrp-mpris

juil. 09 14:58:47 VIX systemd[3478]: Started Discord Rich Presence based on mpris2 media players.

Not sure if we are talking about the same issue there, but discordrp-mpris does fail when discord is not yet started.
As said, One workaround is manually restarting it after one instance of Discord has been started.

Basically discordrp-mpris works OK if it is started after Discord is launched, but not otherwise.
When systemd unit is started on boot, discordrp-mpris tries to connect when Discord isn't started, it will log continuously every second:
ERROR:discord_rpc.async_:failed to open '/run/user/1000/discord-ipc-0': [Errno 111] Connection refused
If Discord is launched at this point, then discordrp-mpris crashes with these logs:
Apr 02 15:17:57 fractal discordrp-mpris[139309]: ERROR:discord_rpc.async_:failed to open '/run/user/1000/discord-ipc-0': [Errno 111] Connection refused
Apr 02 15:17:58 fractal discordrp-mpris[139309]: ERROR:discord_rpc.async_:failed to open '/run/user/1000/discord-ipc-0': [Errno 111] Connection refused
Apr 02 15:17:59 fractal discordrp-mpris[139309]: ERROR:discord_rpc.async_:failed to open '/run/user/1000/discord-ipc-0': [Errno 111] Connection refused
Apr 02 15:18:00 fractal discordrp-mpris[139309]: ERROR:discord_rpc.async_:failed to open '/run/user/1000/discord-ipc-0': [Errno 111] Connection refused
Apr 02 15:18:01 fractal discordrp-mpris[139309]: WARNING:discord_rpc.async_:closing connection
Apr 02 15:18:01 fractal discordrp-mpris[139309]: Traceback (most recent call last):
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/bin/discordrp-mpris", line 33, in <module>
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     sys.exit(load_entry_point('discordrp-mpris==0.3.0', 'console_scripts', 'discordrp-mpris')())
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discordrp_mpris/__main__.py", line 292, in main
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     loop.run_until_complete(wait_task)
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     return future.result()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/asyncio/tasks.py", line 478, in wait_for
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     return fut.result()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discordrp_mpris/__main__.py", line 287, in main
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     return loop.run_until_complete(main_task)
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/asyncio/base_events.py", line 642, in run_until_complete
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     return future.result()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discordrp_mpris/__main__.py", line 280, in main_async
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     return await instance.run()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discordrp_mpris/__main__.py", line 67, in run
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     await self.connect_discord()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discordrp_mpris/__main__.py", line 56, in connect_discord
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     await self.discord.connect()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discord_rpc/async_.py", line 64, in connect
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     await self._do_handshake()
Apr 02 15:18:01 fractal discordrp-mpris[139309]:   File "/usr/lib/python3.9/site-packages/discord_rpc/async_.py", line 94, in _do_handshake
Apr 02 15:18:01 fractal discordrp-mpris[139309]:     raise RuntimeError(ret_data)
Apr 02 15:18:01 fractal discordrp-mpris[139309]: RuntimeError: {'code': 1000, 'message': 'User logged out'}

The workaround is to launch discordrp-mpris after launching Discord for now.


Branch ppp (XJ)

Codecov Report

Merging #231 (61b8317) into master (c951ae3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #231   +/-   ##
=========================================
  Coverage     76.61%   76.61%
  Complexity      806      806
=========================================
  Files           115      115
  Lines          2266     2266
  Branches        262      262
=========================================
  Hits           1736     1736
  Misses          455      455
  Partials         75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c951ae3...61b8317. Read the comment docs.


Remove support to parse other than *.robot files by default

Parsing other than *.robot files was deprecated in RF 3.1 for reasons explained in #2820 in RF 3.2 only *.robot files will be parsed by default. The support for HTML files will be removed for good by #3081 but files containing plain text data (incl. compatible TSV files and reStructuredText files with embedded data) can be used if --extension is used to enable them.
Things to consider:

Should we try to look do reST files contain Robot Framework data and parse them automatically if they do? Would make using reST data easier but would complicate logic. Another possibility is somehow making global configuration easier.
What to do with resource files using other extensions? They weren't deprecated by #2820. Should that be done now?

My two cents worth to:

What to do with resource files using other extensions? They weren't deprecated by #2820. Should that be done now?

I like the possibility of having different extension for the resource files. This way it's easy to identify the test suites (*.robot) from the rest. I see this quite a lot in scenarios where non-developers are involved in Test Case definition/review i.e. they work mostly with test cases (i.e. *.robot files) and the rest (resource files and libraries) is just black magic that makes things happen.
On the other hand .txt extension is also a bit misleading for the resource files. Maybe something new would be better, e.g. .resource
In short: if we deprecate resource files using other extensions then add a new extension that is dedicated to resource files.

I agree *.resource extension is a good idea. That's why it was introduced in RF 3.1 by #2891. =)

I though I remembered seeing it somewhere =)

This has now been implemented like this:

When executing a single file, it is parsed regardless the extension. Allows running robot tests.rst as earlier and even supports robot tests.whatever.

When executing a directory, only *.robot files are parsed by default. The --extension option needs to be used to parse other kind of files, including reST files.

At the moment resource file extension isn't validated at all but that still needs to change. Options include:

Use same extensions as used for parsing and in addition that support also the explicit *.resource extension introduced by #2891. This would be the best solution but it may not be that easy to pass  --extension information to the resource file parsing code.

Support only *.resource , *.robot and *.r(e)st files.

Support *.resource , *.robot, *.r(e)st, *.tsv and *.txt files.

Once resource files are handled somehow, this issue can be considered done. Documenting changes in the User Guide is covered by #3293.

I think it's best to just support *.resource , *.robot, *.r(e)st, *.tsv and *.txt extensions with resource files. This is easy to implement and, because these are the extensions we supported earlier, it shouldn't cause backwards compatibility problems.


Add Ethereum address to FUNDING.yml

I'd like to see an Ethereum address added to the custom property of the FUNDING.yml file for GitHub Sponsors. This would allow a canonical address to send funds to. For example, I'm building a project that allows developers to setup one recurring donation that is split between all of their dependencies with an Ethereum address: https://sustainus.io

As this is a project for a company, it’s unlikely it’d ever get a funding.yml, but i suspect ethereum isn’t the mechanism we’d want to use.


Template 10 <IP_ADDRESS> + Newtonsoft.Json 11+  causes error

After upgrading my packages, I received an error.  I was able to isolate the issue to moving from version 10+ of Newtonsoft.Json 10+ to Newtonsoft.Json 11+.  The error generated was.
Exception thrown: 'System.MissingMethodException' in Template10Library.dll
An exception of type 'System.MissingMethodException' occurred in Template10Library.dll but was not handled in user code
Method not found: 'Void Newtonsoft.Json.JsonSerializerSettings.set_TypeNameAssemblyFormat(System.Runtime.Serialization.Formatters.FormatterAssemblyStyle)'.

 It has to do with the definition of the dependency in nuget's NUPKG syntax, I think. You are not the first to have this experience. The easiest solution is to downgrade your version of NewtonSoft for now. I will leave this as a backlog item to fix in future iterations.

In your template 10.1 V1.1.13b it seems you were solving this issue, I was able to get rid of that error by using your source code and upgrading the libraries.
Now I'm using T10.1 V1.1.13b Custom to my need my only problem is that designer get broken it shows an exception casting from DelegateCommand.

Interestingly I only had this problem when I updated the Target min version of the project to Windows 10 Fall Creators Update (or newer).
I fixed the issue by updating the Newtonsoft.Json Nuget dependency to 10.0 3 instead of 11.x.x.
After doing that I had no problem.
Thanks for pointing out it was the combination of template 10 and Newtonsoft.Json 11 that caused the issue. I could have lost ages searching on this one!


Track function run session to stop it from the plugin

We should track function run sessions as they will spawn an infinite process and we should be able to stop them. It happens that if you close the terminal, func cli doesn't stop them

After talking with the serverless team they said they are going to see how to handle it. Maybe by closing the container when the pipe i/o gets closed. Keeping it blocked for now.

Relates to https://github.com/redhat-developer/intellij-knative/issues/93


Remove pack input from PostFetchJob

We could use the --reachable option in git commit-graph write instead of --stdin-packs. This would remove the need to communicate a list of pack-indexes when queueing the PostFetchStep.
This will make the commit-graph smaller, but will increase the lag from when users update their refs and when the commit-graph has parsed their commits. Background prefetch can do a lot to keep them up-to-date.

Creating for tracking. We may not actually want to do this.


Interest in moving to rust-lang or rust-lang-nursery?

About a year ago the question came up about providing "blessed" building blocks for concurrency as a part of rust-lang-nursery, for which Niko had some thoughts: https://internals.rust-lang.org/t/scoped-threads-in-the-nursery-maybe-with-rayon/4942 . Given that Rayon has just reached 1.0, I figure now's a good time to restart that discussion. In particular I'm curious whether any of the comments there regarding Rayon's configurability/generality/interoperability are still relevant in the post-1.0 design. Any thoughts?

I think it's OK for de facto standard crates to live outside of rust-lang -- like serde, for instance.  It might even be better to break the notion that crates should be "blessed" in this way.

The trend seems to have shifted the other way, e.g. rand moved to @rust-random, so I think we're fine here in @rayon-rs.


sasjs run command - to sasjsresults folder

Currently when running sasjs run we stick the log in the current directory by default.  This can create a lot of unwanted files within a local project repository.
Instead, if running with a local target, we should write the log to a sasjsresults/log folder (alongside the sasjsbuild folder).  the sasjsresults folder should be configurable, like sasjsbuild.  If running for a global target, the current behaviour (write to current directory) is ok.

[ ] sasjsresults folder is configurable
[ ] logs for sasjs run, when running for a local target, are written to the sasjsresults/logs folder

if outside project, sasjsresults will be relative to home directory, as we do for sasjsbuild from global Config.


Docs: Enhance backend plugins topic in "Introduction"

Enhance backend plugins topic:

Add data communication system section
Add caching section
Tighten heading levels
Consolidate two intro paragraphs

Fixes https://github.com/grafana/grafana/issues/75706

All feedback incorporated, merging.


Jet, Karaoke, Charitable Trust, and Stethoscope behave inconsistently when shared

Stethoscope is supposed to make you draw an 8 iff you melded a blue card, but it doesn't behave properly when shared.  This can be seen on move 107/108 of https://studio.boardgamearena.com/table?table=414483 (both players draw an 8, even though only MadisonSilver0 should) and throughout https://studio.boardgamearena.com/gamereview?table=412783.

This is the same as #619.  This same issue will affect Karaoke as well.  Basically, sharing the effect corrupts the variable that stores the card (or color) of the card that was melded in the echo effect (or drawn by Charitable Trust).

I realized that if Jet were shared with someone (in a 3 person game for example), then the melded color would get corrupted by a similar mechanism.

I'll add a player-based auxiliary value. Right now the auxiliary value is shared between players, which causes the corruption.


Change message from warning to success.

After awarding a badge to the user, it shows your badge is under review, change the message to your badge has been awarded or something similar.
To fix this issue:
Go to users/views.py: https://github.com/18praneeth/sushiksha-website/blob/48df7b2d9f3ae342a3e190b94b6a307faff613d5/users/views.py#L199
Change the message type to success

https://github.com/18praneeth/sushiksha-website/blob/48df7b2d9f3ae342a3e190b94b6a307faff613d5/users/views.py#L230
It has to be changed in 2 position

Ok I'll do it

Sure you can take up the issue

message.success(request, 'message here')

Don't forget to change the message type from info to success

#247


SFT微调保存报错，缺失文件trainer_state.json

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
脚本命令：
deepspeed --include localhost:4,5,6,7 --master_port 29500 src/train_bash.py
--deepspeed src/conf/mydeepspeed.json
--stage sft
--model_name_or_path /home/house365ai/xxm/model/Qwen-14B-Chat
--do_train
--dataset estate_qa12_v13
--template qwen
--finetuning_type lora
--lora_target c_attn
--output_dir /home/house365ai/xxm/LLaMA-Efficient-Tuning/output/estate_qa12_v13
--overwrite_cache
--per_device_train_batch_size 2
--gradient_accumulation_steps 4
--lr_scheduler_type cosine
--logging_steps 10
--save_steps 20
--learning_rate 5e-4
--num_train_epochs 50.0
--plot_loss
--neftune_noise_alpha 5
--shift_attn
--bf16
报错信息：
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 1537, in train
File "/home/house365ai/xxm/new/v3/LLaMA-Factory4/src/llmtuner/train/tuner.py", line 26, in run_exp
run_sft(model_args, data_args, training_args, finetuning_args, generating_args, callbacks)
File "/home/house365ai/xxm/new/v3/LLaMA-Factory4/src/llmtuner/train/sft/workflow.py", line 68, in run_sft
train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 1537, in train
return inner_training_loop(
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 1914, in _inner_training_loop
return inner_training_loop(
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 1914, in _inner_training_loop
return inner_training_loop(
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 1914, in _inner_training_loop
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 2274, in _maybe_log_save_evaluate
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 2274, in _maybe_log_save_evaluate
self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 2274, in _maybe_log_save_evaluate
self._save_checkpoint(model, trial, metrics=metrics)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 2383, in _save_checkpoint
self._save_checkpoint(model, trial, metrics=metrics)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 2383, in _save_checkpoint
self._save_checkpoint(model, trial, metrics=metrics)
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer.py", line 2376, in _save_checkpoint
os.rename(staging_output_dir, output_dir)
FileNotFoundError: [Errno 2] No such file or directory: '/home/house365ai/xxm/LLaMA-Efficient-Tuning/output/estate_qa12_v13/tmp-checkpoint-20' -> '/home/house365ai/xxm/LLaMA-Efficient-Tuning/output/estate_qa12_v13/checkpoint-20'
os.rename(staging_output_dir, output_dir)
FileNotFoundError : self.state.save_to_json(os.path.join(staging_output_dir, TRAINER_STATE_NAME))[Errno 2] No such file or directory: '/home/house365ai/xxm/LLaMA-Efficient-Tuning/output/estate_qa12_v13/tmp-checkpoint-20' -> '/home/house365ai/xxm/LLaMA-Efficient-Tuning/output/estate_qa12_v13/checkpoint-20'
File "/home/house365ai/.conda/envs/xxm_new9/lib/python3.10/site-packages/transformers/trainer_callback.py", line 114, in save_to_json
with open(json_path, "w", encoding="utf-8") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/house365ai/xxm/LLaMA-Efficient-Tuning/output/estate_qa12_v13/tmp-checkpoint-20/trainer_state.json'
Expected behavior
No response
System Info
No response
Others
No response

https://github.com/hiyouga/LLaMA-Factory/issues/1809

thx


regions I've visited disappears

Subject: regions I've visited
Description:
enter
Results:
I can not enter the regions, it doesn't do it right and after some regions all disapears...
Backend version: develop-b8a97954
Frontend version: develop-b8a97954
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.82 Safari/537.36
Page: https://app.couchers.org/profile/edit
User: amytje (4650)

c42b90154d9ee2576832f76be0cffd9e0e215340

Actually this is different, but I can't reproduce

Working fine now, can't reproduce


WIP: Add field customer data access

What type of PR is this?
feature
Add new required field 'customerDataAccess' to Script and ScriptMetadata
This flag is added to determine if a managed script has access to
customer data or not and will be used by backplane api to determine if
additional access protection checks need to be performed.
What this PR does / Why we need it?\
Enable managedscripts on clusters with AccessProtection feature
Which Jira/Github issue(s) does this PR fix?
https://issues.redhat.com/browse/OSD-22636
Special notes for your reviewer
Pre-checks (if applicable)

[X] Generated new-client-pkg

/hold cancel

/lgtm
/approve


Single database multi-tennant setup - cache prefix and self-invalidation

This is maybe more of a question as I expect it may have been considered already. If not, a feature request!
I have a single database, multi-tennant application consisting of a single master admin account (that can view all data, make changes etc.) and then multiple tenants. The tenant is defined by an account_id column on each applicable table
The master admin account will be making changes to the tenants, as will the tenants.
I originally setup as suggested in readme:
if(\Auth::user()->isAdmin()){
    config(['laravel-model-caching.cache-prefix' => 'admin']);
} else {
    config(['laravel-model-caching.cache-prefix' => \Auth::user()->account_id]);
}

However, with this when the master account made a change on the model, the cache was not invalidated fo the tenants.
As in a multi-tenant application, each model is generally owned by a tenant. I would love to be able to key the cache to the model owner (in my case each multi-tenant model has the field account_id).
class Order extends Model
{
    public function __construct(array $attributes = [])
    {
        config(['laravel-model-caching.cache-prefix' => $this->account_id]);
        parent::__construct($attributes);
    }
}

However, in the model constructor the attributes of the model are not available. Can anyone see any work around to this?

@booni3 There should be nothing you need to do, not even set up the prefix. If your query includes a where clause to restrict to the respective tenant, it will cache different results for different tenants.
Have you confirmed that using Model Caching for Laravel returns unexpected results without using the manual prefix setting?

Closing this for now. Please reopen if issue persists.

@mikebronner sorry for the delay getting back on this. My app was running OK without caching so I thought I would just leave this out, but now I do want to try and revisit. This package is great and I would love to be able to use it across our apps (many have a similar architecture to below).
I believe my problem may be caused due to a mix of multi-tennant users but also additional interaction from admin which is not restricted to the tennant_id's.
For example:
Tenant Query
SELECT * FROM ORDERS WHERE ORDER ID = '1234' AND tenant_id = '1234'

Admin Query
SELECT * FROM ORDERS WHERE ORDER ID = '1234'

The tenant_id WHERE in my case is turned on/off via middleware, depending on who is logged in. It is present in every/all types of query.
The problem I was having before, was an admin would modify an order and it would invalidate their cache, but if you then logged in as the user and viewed the same database entry, the cache had not been invalidated and it was sill showing the old version.
I am not sure if there is any way around this?


AST: fix dependencies

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.

A smoke test on Linux does the following:

Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

clang SVN r278541 added a dependency on LTO for clangCodeGen.  Reflect that here
to satisfy link dependencies.

@swift-ci please smoke test and merge

CC: @gottesmm

CC @CodaFi ... since I don't seem to able to merge this right now, mind doing it on my behalf?  The failure is unrelated.

Ah, yeah.  @bitjammer is taking at look at that.  In the meantime LGTM.

I'll give the smoke test one more try before hand-merging.
@swift-ci please smoke test and merge.


send bus initialization bits before MMC_GO_IDLE_STATE command to init…

…ialize card after poweron.
I didn't test this all that thouroughly, and on some cards it's not necessary, but it is the correct behaviour afaik.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @jsarrett ,
Thanks for sending this change. Do you mind signing our CLA before we can merge the contribution? You can find it a little bit above this comment on the PR page.
Angus

cla accepted

eMMC now fully initializes, including switchign to HIgh speed and 4-bit mode (if requested).  I did have to modify the SD card command set very slightly, but I think it is safe.  please test.

I cleaned this up a bit and made sure it now merges to master.  If there is any reason no to merge it please let me know and I'll fix it.  It's working reliably for me on my custom board and an ESP32-WROVER, though the WROVER can't do 4-bit transfers through the uSD slot

Hi, thanks for your PR. I'm currently finishing work on SDIO support, which also modifies initialization heavily, so we may have some conflicts merging both changes.
Since SDIO and MMC support are less commonly used, i would like to make them optional, so that extra code doesn't get compiled/linked unless required. The other problem is that card initialization/probing function is becoming too large to be readable, so i am looking for a way to refactor initialization flow, making it easier to read and maintain.
Because these things need to be addressed, i can't merge this code right now, but i would like to keep the PR open in case someone else needs eMMC support in the meantime.
I plan to revisit this again once SDIO is integrated.

I agree that it's unwieldly, but I thought it was better to keep it close to the OpenBSD implementation.  If you want help merging the two let me know.

@jsarrett I know it's been an awfully long time since you sent this PR, but are you able to address the comments that @igrr has made?

@projectgus, @igrr sorry guys.  Just over a week ago the project I was doing this for was cancelled.  The company I was contracting for is not going forward with production, so I'm not really working on it anymore.  If I can scrape up some spare time I can maybe work on it a little more, but I can't commit to anything more than answering questions and discussions.  I don't even have a board to test on anymore.  I can get access to one of our development systems but I have ot make a special trip for it.  sorry team.
-James

Any plans to move this forward ? It looks like @jsarrett has abandoned this project, I volunteer to implement the changes requested by @igrr

@starlino The code in master branch has changed a bit when SDIO support was added, but if you are interested in making the requested changes and rebasing them on top of master, that would be appreciated. In a few weeks we will have some boards with ESP32 and eMMC, which will allow us to test these changes.

@igrr I rebased the chages and submitted a new PR #1941, I addressed your concerns . I tested with SD cards and 3 different eMMC chips  (micron, kingston and sandisk) . I did not (re)tested the SDIO functionality since I don't have any SDIO card, but hopefully I did not break it.
Hopefully this can be integrated promptly into the Arduino core as well,  since I am using it for an ongoing and kind of urgent project. Thank you !

Looks like we can close this in favor of #1941, thanks @jsarrett  and @starlino!
Regarding "promptly integrating into Arduino core" — i don't think this can happen soon, since on the IDF side we are coming close to a feature freeze for release 3.1. Please be advised that you can use Arduino as an ESP-IDF component, which essentially allows you to build Arduino sketches with customized version of IDF.


php artisan admin:install

`$ php artisan admin:install
In Connection.php line 664:
SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name '' (SQL: create table `` (id int unsigned not null auto_increment primary key, username varchar(190)
not null, password varchar(60) not null, name varchar(191) not null, avatar varchar(191) null, remember_token varchar(100) null, created_at timestamp null, updated_at tim
estamp null) default character set utf8mb4 collate utf8mb4_unicode_ci)
In Connection.php line 452:
SQLSTATE[42000]: Syntax error or access violation: 1103 Incorrect table name ''
`

Do you run php artisan vendor:publish --provider="Encore\Admin\AdminServiceProvider" before admin:install??

Yup

Repeated the process again works now ... must have been something I missed

I have tried all the things but not working in my case. Still showing same error again and again, Do i need to do changes on config/admin.php or it will work without it


AttributeError when use_bqstorage_api=True on empty df

The following error is thrown when using pandas_gbq.read_gbq with use_bqstorage_api=True when the query returns no data.
(use_bqstorage_api=True)
File '/env/local/lib/python3.7/site-packages/pandas_gbq/gbq.py', line 1034, in read_gbq
progress_bar_type=progress_bar_type,
File '/env/local/lib/python3.7/site-packages/pandas_gbq/gbq.py', line 532, in run_query
progress_bar_type=progress_bar_type,
File '/env/local/lib/python3.7/site-packages/pandas_gbq/gbq.py', line 576, in _download_results
df = _localize_df(schema_fields, df)
File '/env/local/lib/python3.7/site-packages/pandas_gbq/gbq.py', line 808, in _localize_df
if field['type'].upper() == 'TIMESTAMP' and df[column].dt.tz is None:
File '/env/local/lib/python3.7/site-packages/pandas/core/generic.py', line 5175, in getattr
return object.getattribute(self, name)
File '/env/local/lib/python3.7/site-packages/pandas/core/accessor.py', line 175, in get
accessor_obj = self._accessor(obj)
File '/env/local/lib/python3.7/site-packages/pandas/core/indexes/accessors.py', line 343, in new
raise AttributeError('Can only use .dt accessor with datetimelike ' 'values')
AttributeError: Can only use .dt accessor with datetimelike values

I'm not able to reproduce with a plain empty result set. This test passes:
def test_empty_results(method_under_test):
    """Test with an empty dataframe.

    See: https://github.com/pydata/pandas-gbq/issues/299
    """
    df = method_under_test(
        "SELECT * FROM (SELECT 1) AS tbl WHERE TRUE = FALSE;",
        use_bqstorage_api=True,
    )
    assert len(df.index) == 0

Based on the stacktrace, I'll try a query where a timestamp column is in the results.

Based on the stacktrace, I'll try a query where a timestamp column is in the results.

Confirmed. The test fails with the query "SELECT * FROM (SELECT TIMESTAMP('2020-02-11 16:33:32-06:00')) WHERE TRUE = FALSE;".


WinUI 3 ItemsRepeater scrolling is slow

When scrolling an ItemsRepeater with 10 buttons (in horizontal StackPanel) as an ItemTemplate the frame per seconds are below 10. Profiling shows that most of the time is spent in Layout (e.g. measure & arrange).
Is there a way to reach at least 30 fps or even better 60 fps?
Check the attached project for reference. You will also notice that when dragging the scrollbar thumb there is a time where a white screen is shown and also thumb position is not always under the mouse cursor.
RepeaterSlowScroll.zip

@jeffStall We've had some reported scrolling issues that I think ended up on IXP, could this be a dupe? From the description it sounds like it is Dmanip (from scrollviewer) though.  @ranjeshj has seen issues with EffectiveViewport which may also be contributing here.

@hshristov Couple of things might be contributing to slower scrolling performance. 10 buttons in the item template expand into several elements in each item. Depending on how big your window is you get a page full of items + 4 more pages realized in order to ensure that you don't see empty space when you scroll. That could amount to a lot of elements that are going through layout when you start scrolling. Some thoughts to improve the perf

Try reducing the number of elements in the item template (look at live visual tree to see the counts). Each element element you save gets multiplied due to the repeating nature of this scenario.
Play with the VerticalCacheLength property to reduce the 4 pages of buffer that I mentioned earlier.

I have not analyzed perf on your app, so there could possibly be other things at play.
The height of each item is not uniform, and stack layout is a virtualizing layout. It does not measure everything to accurately know what the real extent is. It is estimating the extent as it sees more items. That is the reason for the change in scroll bar size and it not sticking to the mouse.


NUKE nukes also CHARS

nuke command also nukes chars
nuke should remove only items
for chars
nukechar is the command, and it works well

mu nuke note removing chars, only items

build?
i'm using 3033

Sounds like maybe it is just removing the spawn item that the char is linked to. When that happens it removes the spawned NPCs as well.

yes, my chars not removing...only if you nuke spawner item

ok. i "didn't" but did nuke spawn item.
i was with gm so when nukeing i did no see no spawn even if there was there


Makes zipkin v1 runtime optional

This adds detection such that Zipkin v1 types are not invoked at
runtime. However, there are some limitations to this.
For example, reflective configuration (like spring XML beans) needs no
Zipkin v1 dependency at all. However, compiled configuration (like Guice
or Spring AutoConfig) needs a compile (optional) dependency on zipkin
reporter v1 (io.zipkin.reporter:zipkin-reporter:1.1.1). This is because
we have some method overloading and to compile an overloaded method, you
need to access all the types.
For example, if you don't have zipkin-reporter v1 in your classpath,
when you compile a call to Tracing.Builder.reporter, you will get an
error like this from the compiler:
TracingConfiguration.java:[48,9] cannot access zipkin.reporter.Reporter
  class file for zipkin.reporter.Reporter not found

However, once compiled, if you are using zipkin2.reporter.Reporter,
you don't actually need the v1 types at runtime.
In Brave 5, we should remove the zipkin v1 types from the api,
eliminating this problem.

Ps I took the optional dep route. Another way is we keep compile deps (which mean users dont need to specify a v1 optional dep at compile time). This might be better as people can always exclude if they want to recover the couple hundred KiB of v1 jars.
cc @jorgheymans @llinder @devinsba  preferences?

ok found a sweet spot. this removes the hard dependency on zipkin reporter v1, but can't avoid the one on zipkin v1 due to method overloading. I think this is the best we can do for now (luckily zipkin artifacts even with old types share the same version)


Json output

Type of change

[ ] Refactor
[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Documentation Update

Description
Some of the changes are from metadata change PR please ignore them. We output the change point detection in a tabular form which was inherently provided by hunter. Now we provide it as a json output with the use of the flag --output or -o, this flag defaults to text and can be set to json. Below is a concise version of the json output.
[{
        "uuid": "5b06c830-be55-4c84-b4da-92720b55c304",
        "timestamp":<PHONE_NUMBER>,
        "metrics": {
            "etcdDisk_duration_avg": {
                "value": 0.0134358362,
                "percentage_change": 0
            },
            "P99": {
                "value": 13000,
                "percentage_change": 0
            },
            "etcdCPU_cpu_avg": {
                "value": 8.6963812859,
                "percentage_change": 0
            },
            "ovnCPU_cpu_avg": {
                "value": 2.8599566281,
                "percentage_change": 0
            },
            "apiserverCPU_cpu_avg": {
                "value": 11.0500421666,
                "percentage_change": 0
            }
        },
        "is_changepoint": false
    },
    {
        "uuid": "c5f95336-27d4-4615-94c1-d618e975a36b",
        "timestamp":<PHONE_NUMBER>,
        "metrics": {
            "etcdDisk_duration_avg": {
                "value": 0.0137848279,
                "percentage_change": 42.39053258714572
            },
            "P99": {
                "value": 13000,
                "percentage_change": 0
            },
            "etcdCPU_cpu_avg": {
                "value": 8.2014834841,
                "percentage_change": 0
            },
            "ovnCPU_cpu_avg": {
                "value": 2.7795422015,
                "percentage_change": 0
            },
            "apiserverCPU_cpu_avg": {
                "value": 10.9252901816,
                "percentage_change": 0
            }
        },
        "is_changepoint": true
    },]

Related Tickets & Documents

Related Issue #19
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please describe the System Under Test.
Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

Can we add some additional data to the JSON like the build, platform, cni, etc?

Thank you for the suggestion @jtaleric, will be adding and pushing the changes.


now on rpi pico instead of esp8266

now on rpi pico instead of esp8266...
Traceback (most recent call last):
File "", line 7, in
File "mhz19.py", line 56, in get_data
File "mhz19.py", line 77, in crc8
IndexError: bytearray index out of range

Did you ever get it working on the pico?

Not with this library, to make the sensor work on the Pico I had to write my own code, based on this library and the documentation of the sensor.


Accessibility › Signal Options: Volume Reset Error

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.92.1 (Universal)

Commit: eaa41d57266683296de7d118f574d0c2652e1fc4

Date: 2024-08-07T20:16:39.455Z

Electron: 30.1.2

ElectronBuildId: 9870757

Chromium: 124.0.6367.243

Node.js: 20.14.0

V8: <IP_ADDRESS>-electron.0

OS: Darwin arm64 23.6.0

OS Version:  MacOS 14.6.1(23G93)

Steps to Reproduce:

search for Volume in the settings as I don't want to hear the error sound when coding

change the sound from 70 to 0 in Accessibility ‘ Signal Options: Volume

exit and restart vscode and the volume is back to 70 again

if you check $HOME/Library/Application Support/Code/User/settings.json, you can see the problem.
When it is 70, there is no json change, but when I set it to 0, it generates the code ‘accessibility.signalOptions.volume’: 0 code is generated.

when I exit vscode and run it again, the ‘accessibility.signalOptions.volume’: 0 code in settings.json is deleted: 0 code in settings.json is deleted and the signal Options: Volume in vscode changes to 70.

please fix the bug where the volume is changed to 70 when restarting vscode. It is too hard to change the volume every time I restart vscode.

Is there something I'm missing? Thanks for your answers 🙇🏻

Volume 0 Setting

VScode Restart (Volume 70)

I believe this is already fixed, can you see if you can reproduce in the Insiders build?
/label info-needed

I believe this is already fixed, can you see if you can reproduce in the Insiders build? /label info-needed

Oh I downloaded insiders and ran it, and it's fixed at 0 in insiders!
This is the first time I realised that insiders existed.
I did a Google and GitHub search and didn't think I had the same question, but someone else must have asked it. 🫠
When will this be fixed in vscode? 😢
Thank you so much for your answer :)

It'll be fixed in stable in a few weeks


Add section about canonical encoding

For example, make it clear that CCF-based protocols and data formats must use a deterministic sequence when encoding more than one Cadence composite type.

Closed by PR #57 which specifies requirements for Validity and Deterministic Encodings.


chore(main): release 1.0.10

:robot: I have created a release beep boop
1.0.10 (2023-09-03)
Miscellaneous

setup code coverage reporting and export to codecov (3bf5840)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/yetti/shelfie/releases/tag/1.0.10 :sunflower:


chore(deps): Remove "Translation" addon

https://linear.app/pleo/issue/HMS-1288/clean-ups-after-npm-package-for-translations-alive
This is clean up after moving to the solution using NPM packages for storing translations instead of having CDN for that.
Here I removed translation addon and everything that is associated with it.
I do have a question about testing it in the dev/staging env before pushing to prod.
On what env I may do that?

We should ideally test this on the product-dev environment.
I've recently done a test using a pre-release in bff-tools without having to merge the PR first. Are you familiar with how to test this without merging the PR? But merging the PR and testing the newly published version is ok with me too.

We should ideally test this on the product-dev environment. I've recently done a test using a pre-release in bff-tools without having to merge the PR first. Are you familiar with how to test this without merging the PR? But merging the PR and testing the newly published version is ok with me too.

@macko911 Do you mean that when I merge this PR, the updates won't be in production automatically?
But anyway I'm for any possible testing (before or after merging) and I'm not familiar with bff-tools if you may share knowledge how to do that testing, it would be great!

Do you mean that when I merge this PR, the updates won't be in production automatically?

Yes, you will then need to update terraform repo with the new version here. That change can then be deployed only to product-dev environment before merging.
But actually since this PR is marked as chore it probably won't trigger a new release based on the docs. This can be fixed by changing the prefix to chore!, leading to a new major version.


Team 1: week 3/18 updates to review

This PR:
Faq outline bug fix

Pull Request Test Coverage Report for Build #73

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.32%

Totals

Change from base Build #69:
0.0%

Covered Lines:
1872

Relevant Lines:
2006

💛  - Coveralls


Fixes the basic compile tests.

This will fix the basic compile tests when ran against travis, since
travis wasn't test against PE.

@rji beat met it...


cross-strategy function addition: randomizing initial insert_id

An easy way to have invalid specs is to have model object's primary key IDs be the same, hiding mishandling of those ids when dealing with caching, etc.
Most (all?) of the backends which have autoincrement ids have the ability to set the starting point of that ID.  Instead of resetting ids after truncate/delete, have the ability to randomize those ids.
I've currently got the very hacky test in my before(:suite) rspec block:
    DatabaseCleaner.connections.each do |c|
      s = c.create_strategy(:truncation)
      cxn = s.connection_class.connection
      if (cxn.send(:uses_sequence) rescue false)
        tables = s.send(:tables_to_truncate, cxn)
        tables.each do |table_name|
          cxn.execute("replace into sqlite_sequence (name,seq) values ('#{table_name}', #{rand(100000)});")
        end
      end
    end

It seems to do the job, obviously knows a lot about the internals of databasecleaner though, so its just a proof-of-concept.  It's already pointed out a failing spec!
I'm happy to put together a PR, but wondering if I'm barking up the wrong tree here.

@onyxraven I think randomizing the starting point shouldn't matter as long as all records get properly deleted/truncated. Could you provide a concrete scenario for this issue?

@schmierkov In some cases, our app passes around IDs instead of full objects (queued items, etc), and assigns them.  When every table potentially starts at id=1, accessing the wrong table/object can hide a broken spec when the IDs match up, but the tables do not.  Randomizing the IDs has shown quite a few of those errors in the past, and seems like an easy way to raise those errors.
so for example, say a method mistakenly sends the wrong id:
class FirstTable < ActiveRecord::Base; end
class SecondTable < ActiveRecord::Base
  def do_work
    'work work'
  end
end

def use_second(second_id)
  second = SecondTable.find
  second.do_work
end

obj1 = FirstTable.new.save
obj2 = SecondTable.new.save

#mistake
output = use_second(obj1.id)

expect(output).to eq('work work')

This spec should throw a ActiveRecord::RecordNotFound, but won't because both obj1.id and obj2.id will == 1.
This example is somewhat contrived, but can mimic getting an object ID from another source (say a cache, api call, etc) without a specific class information.


Got no response from my bot

wget command didn't work for me, so I used git clone to pull the source code, and I got all dependencies installed, sure, replaced the api key and bot token and got it running on my Azure WM, but I still got no response from my bot.

Sorry about the wget command. This is a known issue which we will fix in next version.
As for the bot won't working. Would you mind try this first? https://github.com/flynnoct/chatgpt-telegram-bot/issues/13

Sorry about the wget command. This is a known issue which we will fix in next version.
As for the bot won't working. Would you mind try this first? https://github.com/flynnoct/chatgpt-telegram-bot/issues/13

Thanks for your reply, I have removed the comments and commas you mentioned, but it didn't help, I executed the openai_parser.py file and got response from openai.

You can just run python3 telegram_message_parser.py and see if there is any traceback info?

Traceback (most recent call last):
File "telegram_message_parser.py", line 15, in
from telegram import Update
ImportError: cannot import name 'Update' from 'telegram' (/home/ubuntu/.local/lib/python3.8/site-packages/telegram/init.py)
Thanks, I got traceback info as above.

Check this https://github.com/flynnoct/chatgpt-telegram-bot/issues/27.
Uninstall telegram module first and install python-telegram-bot

Check this #27.
Uninstall telegram module first and install python-telegram-bot

Traceback (most recent call last):
File "telegram_message_parser.py", line 22, in
with open("config.json") as f:
FileNotFoundError: [Errno 2] No such file or directory: 'config.json'
I got v1.2.0 on my VM, but still no response from my bot, I got trackback info as above when I run python3 telegram_message_parser.py

done in release 1.2.0

I moved config.json to folder src/, and the bot is working now, thanks.

Sorry for mis-operation.
This is a brief explanation:

If you run python3 telegram_message_parser.py in src/ folder, it will try to read config.json from src/ because this is your current working directory.
If you run this bot as we planned (execute bash bin/start_bot.sh in project's root directory), then it will try to load config.json from project's root directory which is we planned.
Hence, if you want to run the bot manually, I suggest you to execute python3 src/telegram_message_parser.py because it will load config file from project's root directory. And no copy operation is needed.

I hope this may help you.

Thanks for the explanatiom.

I will close this issue if everything is correct. Please comment if you have any further questions.


chore: promote origins-cms to version 0.0.9

chore: promote origins-cms to version 0.0.9
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign dnmahendra
You can assign the PR to them by writing /assign @dnmahendra in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Return correct exit code on error

Coverage remained the same at 100.0% when pulling 0bd54e0d291492165d2a3be0e88975458e386e63 on juanjoDiaz:add_correct_error_codes into e9622cbd555bd134de3d6a90d3bca33007f580b5 on zemirco:master.


Hitsound got parsed incorrectly

I've noticed that in some rare cases the sampleset is off on some hitobjects after parsing the .osu file.
I've applied the standard ruleset to the beatmap, if that makes any difference.
Beatmap to reproduce:
https://osu.ppy.sh/beatmapsets/2109375#osu/4427449
00:37:399 (5) - Sampleset in hitObject.nodeSamples should be Soft but it's Normal for some reason

Actually, I'm aware of that problem. It's happening because beatmap decoder lacks so me sample control point logic right after beatmap parsing. I was working on that stuff before, so I just need to finish an update for osu-classes


Block36 -> MovingPiston

Block36 bad and worst in game
I look forward to the :bike::house:ing that this PR may or may not cause.

(On a serious note, I don't really mind Block36 all that much, I just prefer more descriptive names)

no block36 is a terrible name

block36 best name

nou

Block36 needs to stay or the universe will explode k thx

the universe will explode

merge or slap

You slap me I close

👏 I'll fuckin do it again

I will poll this for 24 hours

nvm I can combine this with supercoder's pr


Incorrect implementation of PbList.hashcode

PbList.hashcode intends to implement the Jenkins hash function. However, in lines like this it is adding before applying the bit shift. Instead of (hash + hash << 10) it should be something like (hash + (hash << 10)).
It was also suggested offline that we should change  (...) & 0x3fffffff to 0x3fffffff & (...) , though I don't fully understand why.

I recommend:

use for-in instead of forEach
copy the exact bit-twiddling from the private class in dart:math
write arithmetic with the constant first, since this has more precise type inference which leads to better code.


changeAlive: false => false

Using digitalocean

Tried 3x to setup everything
always same error in the end
Dpoplets get created and are live in digitalocean

Output:
2020-11-08T19:38:16.155Z - debug: [Instance/215963992] changeAlive: false => false
2020-11-08T19:38:20.854Z - debug: [Manager] checkInstances
2020-11-08T19:38:21.279Z - debug: [Manager] adjustInstances: required:1 / actual:1
2020-11-08T19:38:30.855Z - debug: [Manager] checkInstances
2020-11-08T19:38:31.114Z - debug: [Manager] adjustInstances: required:1 / actual:1
2020-11-08T19:38:31.153Z - debug: [Instance/215963992] checkAlive: false / -
2020-11-08T19:38:31.153Z - debug: [Pinger] ping: hostname=<IP_ADDRESS> / port=3128
And keeps repeating.
In a previous post it was because of this step: https://scrapoxy.readthedocs.io/en/master/standard/providers/digitalocean/create_image/index.html
Extra info: config file
{
"commander": {
"password": "xxxx"
},
"instance": {
"port": 3128,
"scaling": {
"min": 1,
"max": 2
}
},
"providers": [
{
"type": "digitalocean",
"token": "xxxxx",
"region": "lon1",
"size": "s-1vcpu-1gb",
"sshKeyName": "mykey",
"imageName": "forward-proxy",
"tags":"proxy, instance"
    }
]

}
Any idea what it might be?
thnx a lots

Extra info:
Console:

Digitalocean

This is a duplicate of https://github.com/fabienvauchelles/scrapoxy/issues/196

Hi @DennisPeeters,
I got same error. Did u fix the checkAlive problem?
Thanks

will be corrected in the 4.0.0 version

Hey there! 🌟 Exciting news! Scrapoxy 4 is ready to rock 🚀. Check it out at Scrapoxy.io (explore the "get started" guide, deployment documentation, and more 📚).
I can't wait to hear your feedback on this new version! Send me your coolest screenshots with as many proxies as possible! 📸💻
Join the Discord community if you have any questions or just want to chat. You can also open a GitHub issue for any bug or feature request 🐞✨.
See you soon!  😎
Fabien


util/device-os-version: Make compatible w/ newer typings

TypeScript will emit the same code, but imo this was
was a nice way to avoid the Array<string | number>
cast (that's what the new typings say for the
prerelease prop).
Change-type: patch
See: https://www.typescriptlang.org/play/#src=[...build%2C ...versionInfo.prerelease]
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch

Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci retest


Ignore Kamereon account without vehicle.

OK during the config flow, I have to serial number at the last step. The first one didn't work and the second correspond to my Zoé.
Originally posted by @oncleben31 in https://github.com/epenet/hassRenaultZE/issues/30#issuecomment-711086472

I have look at the communication.
The two account have different ID and different types (MYRENAULT and SFDC). My vehicle is in the MYRENAULT. Could we ignore by default SFDC account ? Or is there some case where vehicule could be hosted in this account ?


[improve][ws] Support subscribing multi/pattern topic for Websocket

PIP-307
Motivation
Support subscribing multi/pattern topic for WS.
The new sub-path could be :
/ws/v3/consumer/subscription?topicsPattern="a.*" /ws/v3/consumer/subscription?topics="a,b,c"

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Please help fix the checkstyle issue.

Codecov Report

Merging #21379 (6caf1ec) into master (bd86e4e) will increase coverage by 38.71%.
The diff coverage is 58.82%.

@@              Coverage Diff              @@
##             master   #21379       +/-   ##
=============================================
+ Coverage     34.54%   73.25%   +38.71%
- Complexity    12084    32609    +20525
=============================================
  Files          1713     1892      +179
  Lines        130782   140444     +9662
  Branches      14250    15436     +1186
=============================================
+ Hits          45173   102878    +57705
+ Misses        79577    29475    -50102
- Partials       6032     8091     +2059

Flag
Coverage Δ

inttests
24.14% <23.52%> (?)

systests
24.72% <13.23%> (-0.02%)
:arrow_down:

unittests
72.54% <55.88%> (+40.67%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...n/java/org/apache/pulsar/broker/PulsarService.java
83.07% <100.00%> (+15.67%)
:arrow_up:

...pache/pulsar/proxy/server/ProxyServiceStarter.java
66.44% <100.00%> (+34.44%)
:arrow_up:

...che/pulsar/websocket/AbstractWebSocketHandler.java
57.55% <100.00%> (+57.55%)
:arrow_up:

...a/org/apache/pulsar/websocket/ConsumerHandler.java
63.09% <100.00%> (+63.09%)
:arrow_up:

...sar/websocket/service/WebSocketServiceStarter.java
74.46% <100.00%> (+74.46%)
:arrow_up:

.../websocket/WebSocketMultiTopicConsumerServlet.java
88.88% <88.88%> (ø)

...he/pulsar/websocket/MultiTopicConsumerHandler.java
38.63% <38.63%> (ø)

... and 1468 files with indirect coverage changes


Modal is not displayed properly

Bug Report
When upgrading to the latest version of Semantic UI React, all the Modals I have in my app are now kind of broken.
The "fullscreen" modal in scrolling mode is now located at the bottom of the screen and flickers (when looking in the console, I saw that the class was switching between scrolling and not scrolling).
The other modals are not centered anymore and they go on the bottom right of my screen (because of a style in semantic css which does top: 50%; left: 50%
In order to make it work properly again, I had to check in the previous version what was different and I saw that in the latest version, position: static !important was missing in the new style.
So I added this property in my css and everything went back as expected, my Modals were not broken anymore.
I just want to know if I missed a part, or if there was a better practice to fix it ?
I read all the existing issues, and except from this one https://github.com/Semantic-Org/Semantic-UI-React/issues/2221#issuecomment-374822317 which helped me on the flicker issue, all the other issues were closed and marked as duplicated without providing a proper solution to the Modal issue.
Version
"semantic-ui-css": "2.4.1"
"semantic-ui-react": "0.83.0"

There is an issue with incorrect padding for the fullscreen size in Semantic UI 2.4.0, it is also reproducing in docs. It was fixed in 2.4.1, RELEASE-NOTES.md. However, our docs are running on 2.4.0, yet.
The other weird thing that<EMAIL_ADDRESS>still points to 2.4.0.

Preview of issue

top: 50%; left: 50% is applied only for .legacy modals as I see, https://github.com/Semantic-Org/UI-Modal/blob/master/modal.css#L326. We don't use this feature, yet.
However, as I see this issue is still duplicate of #2221, I'm correct? Because it caused by conditionally apply of scrolling CSS class. We don't have any valid solution or a fix for this, feel free to open PR that will make our calculations there correct and predictable.

Closing as duplicate, PRs are welcome 👍


fix MetadataStorage binding so that it is always Noop except for coordinator iff derby is configured

a regression from #3700
currently derby works fine as long as other metadata storage modules (mysql, postgres etc) are not loaded which always bind the MetadataStorage to Noop implementation even when derby is configured in the properties. this patch fixes that.
After this patch, DerbyStorage module binds MetadataStorage to Noop which is only overridden by CliCoordinator to bind to configured metadata storage.

👍

@gianm updated

👍  after travis


Addresses added using add_known_address are never cleaned up

They should be removed if we have failed to reach them.

Issue still relevant and important.

So if I'm reading the code correctly, we do remove those addresses here.
https://github.com/paritytech/substrate/blob/8d17a16a5653974ec17ed617306606e9dbb6e4b4/client/network/src/discovery.rs#L546
removes addr from kademlia

@tomaka could you please clarify what's the issue about ^?


Security issue with xls_builder retaining data even if template render fails to an exception on a computed field

There seems to be a possibly high impact issue with the way the xls_builder handles rendering the column contents. Steps to reproduce:

Have the following xls template for an ActiveAdmin resource

  xls do
    whitelist
    column :name do |key|
      custom_helper_that_raises_exception(key)
    end
  end

Have the ActiveAdmin resource filtered in to view A and view B so that

Items from viewA raise no exception with the custom helper
Some item(s) from viewB raises an exception.

First export viewB as xls and have the server throw an error. Now export viewA as xls.

Observed: viewA.xls contains data from viewB
Expected: Every export should be from a clean slate, so viewA.xls should only contain data from viewA.
Haven't had the chance to see if the issue is with my versions, this gem, or the underlying spreadsheet gem. This does pose a security issue with using custom helpers that might throw an uncaught error, thus leaking data between exports.
Versions used:
Ruby 2.3.7p456, Rails <IP_ADDRESS>, ActiveAdmin 1.2.1, ActiveAdmin-xls 2.0.0, Spreadsheet 1.1.7

I understand the issue.  I believe the problem is in the Builder class.
Thanks!


Can DSP Be Trained On JSON

Thank you for open sourcing your DSP research. Qq - can the DSP framework be used on JSON data to input for example OpenAPI 3.0.0 to another format? or it only works with text?
Again appreciate your guys effort and thank you for show casing your work.

Sorry I just saw this issue. Do you mean giving JSON to the LLM? Or where exactly?


Override Header and Footer info

Is your feature request related to a problem? Please describe.
I'd need to override the header and footer info that are shown when I use the 'chromiumPdfOptions' with 'displayHeaderFooter' flag set to true.
Describe the solution you'd like
HEADER
I understood that this box takes the label from the "title" tag, but I'd need to change the date format (using the european instead of the US)

FOOTER
here I'd need to get rid of the text at the bottom left and add something before the page number

``
Describe alternatives you've considered
No response
Additional context
setup the body with the following:
const body = {
      "templatePath": "*.zip",
      "returnPdfInResponse": false,
      "public":false,
      "chromiumPdfOptions": {
        "width": 1500,
        "format": "a4",
        "printBackground": true,
        "scale":zoom,
        "displayHeaderFooter": true,
      },
      "adjustHeightToFit": false,
      "data":data,
    }

I got it using this solution:
https://github.com/puppeteer/puppeteer/issues/1853#issuecomment-383626554


fix recursion error when handling unsupported types

Should fix https://github.com/deepset-ai/hayhooks/issues/43.
Seems like some nested generic types are causing handle_unsupported_types to return RecursionError: maximum recursion depth exceeded.

I've iterated on this:

rewrite of handle_unsupported_types (simpler + add tests)
add a logger
add IT tests of deploying sample pipelines using API, check status and /docs route

This should solve both #43 and #47.


google() needs to point to 'https://dl.google.com/dl/android/maven2'

We have confirmation from our China team that https://maven.google.com is blocked in China. As such, can we please change the google() shortcut to point to 'https://dl.google.com/dl/android/maven2'? That URL is not blocked.

@jmslau Our concern is maven.google.com is redirecting to dl.google.com/dl/android/maven2 and we don't know when that redirection may change. We want to avoid dependencies with Google infrastructure. Thanks for your input.

URL has been changed.

Awesome, thanks!

    maven { url "https://dl.google.com/dl/android/maven2/" }

I can't visit  this url "https://dl.google.com/dl/android/maven2/"

@yangyudaddy The direct repository URL is not browsable. You can have a look at the content here: https://dl.google.com/dl/android/maven2/index.html.

@bmuschko Thank you.

but I can not access yet.


Add support for IAM roles

Update the AP and RTA templates to support two different authorization modes: User or Role
In User mode, the templates create IAM users. In Role mode, the templates create IAM roles
Also, update the e2e tests to use the AP and RTA template to cover both AP and RTA functionality in the e2e tests.

/do-e2e-tests


Allow to control compiling GRPC and HTTP in

Set grpc build tag to include GRPC driver
Set http build tag to include HTTP driver

Codecov Report
Patch coverage: 57.74% and project coverage change: -2.43 :warning:

Comparison is base (addb650) 81.73% compared to head (5479e1f) 79.30%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   81.73%   79.30%   -2.43%
==========================================
  Files          39       38       -1
  Lines        4106     3479     -627
==========================================
- Hits         3356     2759     -597
+ Misses        548      519      -29
+ Partials      202      201       -1

Impacted Files
Coverage Δ

driver/observability.go
0.00% <0.00%> (ø)

driver/search_http.go
82.59% <ø> (ø)

driver/types.go
0.00% <ø> (ø)

driver/management.go
43.75% <37.50%> (-45.14%)
:arrow_down:

driver/search.go
50.00% <50.00%> (ø)

driver/driver.go
71.42% <64.28%> (-14.94%)
:arrow_down:

driver/http.go
75.06% <93.75%> (+0.40%)
:arrow_up:

... and 3 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Onboard Sarah to cloud.gov team

New Team Member Onboarding Checklist
Meta note, mostly to myself, we should add the required cloud.gov elements into the Pages template so we can accomplish this in one ticket.
Instructions

Try to go through the checklists in order.
If @drewbo can’t complete any of the items on their checklist personally, they are responsible for ensuring that someone with the correct access completes that item.

Onboarding Checklist
Required items for all team members
These items help us fulfill security and compliance requirements (including for FedRAMP). If you get stuck, or if these requirements are confusing, ask for help from your buddy or in a cloud.gov channel.

[x] Take judicious notes on what about this onboarding process or cloud.gov is confusing or frustrating. If you notice a problem (especially with things like documentation), you are more than welcome to fix it! At the very least, please share this information with your onboarding buddy (or someone) at some point so we can make the team/platform better. (You can also file issues and pull requests on the template Onboarding checklist.
[x] Be sure to introduce yourself and follow up with your onboarding buddy (they should have reached out to you at this point; if they haven't, please let the team know) and make sure this issue is assigned to them in our Github Project Planning Board. We use this board to organize, prioritize, and track our work.

Pre-requisites

[x] Complete GSA OLU GSA Mandatory Cyber Security and Privacy Training, including accepting the GSA IT Rules of Behavior, which is required before we can give you access to any cloud.gov systems. If you joined GSA more than two months ago, you've already completed this task and can just check the box.

Fulfill security and compliance requirements (including for FedRAMP) - Completed by onboarding buddy

[x] Make sure they're in the list of people working on the project.
[x] Add their name, whether they're Cloud Ops (Platform), and the date they joined the team to the training tracker. Copy the formulas for the due dates from an existing row (grab the "corner" of the cells and pull down).
[x] As they complete training, fill out their completion dates in the training tracker.
[x] Add them to the @cloud-gov-team in Slack’s Team Directory.
[x] Review the recurring cloud.gov meetings that are relevant for them in the team calendar (they will get access to this when added to the cloud.gov Team Google Group).
[x] Add them to the cloud-gov organization in GitHub, and the cloud-gov-team team.

Learn our policies and procedures
For the three trainings list at the top, your onboarding buddy will create a separate ticket to track the trainings once scheduling has been finished.  This will help consolidate trainings for multiple new members to the team and prevent them from blocking progress on this onboarding ticket.  Once the trainings are scheduled, they can be marked as complete here.

[ ] Coordinate with your onboarding buddy to go through Contingency Planning training within 60 days (and annually after that). This will cover the following document, which you should also review before or after training:

[x] Read the Contingency Plan.

[x] Coordinate with your onboarding buddy to go through Incident Response Training within 60 days of joining the team (and annually after that). This will cover the following document, which you should also review before or after training:

[x] Read the Incident Response Guide.

[x] Coordinate with your onboarding buddy to go through nonpublic information training within 60 days of joining the team (and annually after that). This will cover the following documents, which you should also review before or after training:

[x] Review the cloud.gov open source policy guidance about protecting sensitive information.
[x] Read our sharing secret keys policy.
[x] Review the TTS requirements for password management.

[x] Read the Continuous Monitoring Strategy, particularly the cloud.gov team responsibilities.
[x] Read the Configuration Management Plan.
[x] Read the cloud.gov Security Policies and Procedures. These documents explain the high-level policies and procedures we must comply with while running cloud.gov, sorted into security control "families" They explain that we follow GSA IT security policy, and they provide a summary of the procedures in our System Security Plan.
[x] Review the System Security Plan (the latest version lives on Google Drive; look for "cloud.gov System Security Plan (SSP)" as a .docx file). Of particular note for onboarding: Section 9 (System Description) and Section 10 (System Environment)

Getting to know cloud.gov
These items will help you come up to speed on cloud.gov and what it is, how it works, why it exists, etc.  While you
should take the time to go through them, please do not try and tackle it all in one shot!  It can become overwhelming
very quickly, so your onboarding buddy will walk through this list with you at a high level with you to help manage the work.

[x] Read the team onboarding document for more context about cloud.gov.
[x] Bookmark the pertinent links listed here.
[x] Read through the Overview section of our site for a broader understanding of cloud.gov, especially how we present it to potential customers and users.
[x] Sign up for a cloud.gov sandbox using your GSA email address and start experimenting to get familiar with the basics of the PaaS from a user's perspective.

This is also required in order to make you a platform admin once you've completed the Cybersecurity and Privacy training.

[x] Read the Delivery Process document to learn about how we work.
[x] Read our service disruption guide to learn how we handle customer-facing service disruptions.
[x] Add the cloud.gov Google Drive folder to your Google Drive -- that's where we put cloud.gov docs. If you create or move a doc there, it'll get the right access permissions for team members to be able to view and edit it.
[x] Subscribe to the cloud.gov team calendar (click the + in the bottom right) so you know when assorted team meetings are happening in the various squads. Tip: When you plan Out of Office time, make a calendar event for that on the cloud.gov calendar so that your teammates know you'll be away

Slack channels
Your onboarding buddy will add you to these Slack channels:

[x] #cg-billing - private business development channel (if applicable)
[x] #cg-business - business development (if applicable)
[x] #cg-compliance - compliance-related information and discussion
[x] #cg-offtopic - off-topic team sharing
[x] #cg-general - program-level information and discusion
[x] #cg-priv-all - private channel for in-team discussion
[x] #cg-priv-gov (Federal employees only) - may contain discussion of contracting-related or other private, federal-employee-only comms

Authorization to onboard: https://groups.google.com/a/gsa.gov/g/cloud-gov-compliance/c/aF2vLibOUxE

Review the cloud.gov open source policy guidance about protecting sensitive information.

The first link redirects to a page where the next link is to a deleted Google doc. This link should probably go directly to https://handbook.tts.gsa.gov/general-information-and-resources/sensitive-information/ unless there's a more specific cloud.gov resource

@sknep amazing. New speed record for onboarding


Email Alert: 'User' object has no attribute 'user'

All the users have an email setup. I also setup an user profile for each.
Not sure if this matters.
ERROR 2015-02-24 08:18:18,412 urls 12135<PHONE_NUMBER>89312 No url file available for plugin cabot_alert_email

This seems to be the main issue.
Traceback (most recent call last):
  File "/home/ubuntu/2015-02-23-3c6f4f6/cabot/cabotapp/alert.py", line 50, in send_alert
    alert.send_alert(service, users, duty_officers)
  File "/home/ubuntu/venv/local/lib/python2.7/site-packages/cabot_alert_email/models.py", line 29, in send_alert
    emails = [u.user.email for u in users]
AttributeError: 'User' object has no attribute 'user'

Changing to u.email for u in users fixed this. Where is this code in the project?

This is actually an issue with https://github.com/bonniejools/cabot-alert-email - can you fix @bonniejools

+1


Add read frames after logging statement

Fixes #102

Could you rebase the commit to make the Add read frames after logging statement on top of the latest trailblazer branch?


Follow up fixes to #1753

These are followup fixes for #1753 and fixes #1932.

Check the output file's mtime against the most recent input time before checking the build log
For outputs created by generator rules, record the restat'd output's mtime in the build log
Always include depfile mtime in build log mtime if special deps binding isn't specified
Fix performance regression (change Stat() to StatIfNecessary() in StartEdge())

cc: @bradking @jhasse

I've confirmed this fixes #1932, but some of CMake's test suite still fails.  I'll track down the next case.

See additional case posted in https://github.com/ninja-build/ninja/issues/1932#issuecomment-804275428.

@jdrouhard as of commit 9fb5867362 all but one of CMake's tests pass.  I'm still tracking down the remaining failure.

See additional case posted in https://github.com/ninja-build/ninja/issues/1932#issuecomment-804399236.

As of commit f2205713 all of CMake's tests pass.  However, commit 53f96fed breaks one again.

As of commit f2205713 all of CMake's tests pass.  However, commit 53f96fed breaks one again.

What test? We really should port more of CMake's ninja tests to native ninja tests.

commit 53f96fed breaks one again.
What test?

It's the Qt5Autogen.RerunMocBasic test.  I won't have time until later to try to narrow it down to a ninja-only example.

Hi! Thanks for your work. I haven't followed everything yet.
I think a good idea would be to actually revert the merge commit of #1753, then add the test cases (except those for #1753) and then draft a new version of #1753 with the fixups. What do you think?
We could also merge this PR, but then the actual change (and the fixes for it) would be scattered.

I can do that. I'll open another PR with the revert + new tests, and a second one that re-lands the change along with the fixes.


Multiple Votes

Currently, there is no limit to the amount of votes that can be cast when a person logs into the website and selects a nation for each match. Make sure to limit a user's ability to vote to one nation per fixture and to one vote per user each fixture.

I can

I can contribute to this @NSmonish

Sure we will assign the issue once the "Predict the winner" issue is solved as it is required to complete the fan poll section and to start working on this issue "Multiple votes".


[Memos] Newline in between each tag appended to Memo

Extension
https://www.raycast.com/JakeYu/memos
Description
Could you append a newline in between each tag appended to Memo?
ex:
current:
content #tag1 #tag2
desired:
content
#tag1
#tag2
Who will benefit from this feature?
Anyone creating memos often. Especially with codeblocks as the primary content.
Anything else?
lmk if any questions

@erauner12 You can use Send Memo Form command to input text. Use shift+enter to add new line.

@erauner12 This is too personalized. Some people like to add a line, while others do not. We are just following the format of usememo.


Try from int error

Codecov Report

Merging #167 (9275a48) into develop (3fdd1e3) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 9275a48 differs from pull request most recent head 686cd52. Consider uploading reports for the commit 686cd52 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff            @@
##           develop     #167   +/-   ##
========================================
  Coverage    41.70%   41.70%
========================================
  Files           87       87
  Lines        12385    12385
========================================
  Hits          5165     5165
  Misses        7220     7220

Impacted Files
Coverage Δ

src/error.rs
100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Gradle build stuck during test execution

I have a build that gets stuck everytime we execute our tests. The build is a multi-project build. We're running gradle 7.3.3 with jdk 11.
With a thread dump, I see 3 TaskProcessors all trying to stop the tests but all of them seem to be waiting on a condition that i cant seem to figure out. It seems that i can't reproduce this issue on a physical machine, but this is occurring consistently within a docker container. The docker container base image is centos 7. Also, interestingly, when the build is executed a second time on the same folder, it doesnt get stuck.
Following is the thread dump.
https://gist.github.com/abbas-gadhia/b3cf0eed9552795e67dbd02b5d44e71b
Please help if possible.

Sorry that you're having trouble with Gradle!
We suspect that it's the tests that are stuck, not Gradle. (The stop() method is not an indicator that Gradle is trying to actively stop the tests.) A reproducer project could really help us track down and fix your problem quicker.
Also, it would be useful to get a thread dump of your test JVM, as opposed to the dump from the Gradle Daemon's JVM.

You were right! After looking at the Gradle Worker Main thread dump, we identified that it was our code blocking on a future. I didnt know that the daemon delegates to another jvm to run the tests. Closing this issue. Thanks for your advice!

You were right! After looking at the Gradle Worker Main thread dump, we identified that it was our code blocking on a future. I didnt know that the daemon delegates to another jvm to run the tests. Closing this issue. Thanks for your advice!

@abbas-gadhia I'm facing the same issue. Can you assist me in identifying the correct process to troubleshoot? I've tried using the jps -lv command to list all the running JVM processes, but there are multiple processes related to Gradle running.


multi era potential command

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/fixes-of-cli@56cb892). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             feature/fixes-of-cli    #1157   +/-   ##
=======================================================
  Coverage                        ?   74.62%
=======================================================
  Files                           ?       74
  Lines                           ?    10686
  Branches                        ?        0
=======================================================
  Hits                            ?     7974
  Misses                          ?     2712
  Partials                        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


consul service: Restart on failure.

Backport of #29860 to 17.09.

Please use cherry-pick -x for adding a reference to the picked commit on master. I backported the commit for you. Thanks!

Please use cherry-pick -x for adding a reference to the picked commit on master.

Ah dammit I forgot that again. We should add that to the pull request template if that is possible.

I backported the commit for you. Thanks!

Much appreciated!


Add support for Cargo (Rust)

:wave: I'm pretty excited to get it merged, but could you add some tests?
You could copy the simple project from here https://github.com/sbt/sbt-jni/tree/main/plugin/src/sbt-test/sbt-jni and call it ~ simple-cargo or smth and adjust to use Cargo instead of CMake.

We're green :tada:

Btw, instead of maintaining a Changelog manually, we could use Release Drafter. Have a look here for inspiration:
https://github.com/zio/zio-prelude/blob/master/.github/release-drafter.yml
https://github.com/zio/zio-prelude/blob/master/.github/workflows/release-drafter.yml

@sideeffffect a very nice idea :+1:. I'd still like to keep the CHANGELOG.md file though (I find it very useful to search through all changes placed in a single file); but mb we can use drafter + some other github actions to preserve the file as well.

So shall we make a release? :)

@sideeffffect you mean drafter? or just the release?
I think ETA for release is today evening / tomorrow - I'd like to add more words about Cargo into the README (you can help it btw! haha);
We also changed the groupid so I'm thinking about packages renaming (https://github.com/sbt/sbt-jni/issues/49), it can be pretty confusing for users to see the groupid com.github.sbt but ch.jodersky.jni.nativeLoader in the code. That's a grea opportunity for us to make this transitioning.
But I'd like to hear your opinon on that as well.

packages renaming

good idea :+1:


Review form leaking in service layer

During type safety pass, we noticed there's no type in review parameter in postProductReview() method in projects/core/src/product/occ/product.service.ts class.
We tried to use Review as a type, but then TS is complaining on these lines:
    const body = new URLSearchParams();
    body.append('headline', review.title.value);
    body.append('comment', review.comment.value);
    body.append('rating', review.rating.value);
    body.append('alias', review.reviewerName.value);

Title, comment, rating, reviewerName are not part of the Review type.
Tracing the calls, we found out that in product-reviews.component.ts' submitReview() we are passing angular's reactive form to the service layer like this:
this.reviewService.add(this.product.code, this.reviewForm.controls);.
Instead, we should pass a Review object.

NOTE for the reviewer of this ticket - I noticed that the review is posted to the server (in dev tools network tab we get 201) but the posted review is not visible even after refreshing.


fix(@embark/solidity): fix binding in method call

This commit fixes a bug where it throws while trying to compile solidity
files as it dereferences its this.
Unfortunately passing methods as lambda callbacks doesn't correctly
resolve its this scope even within fat arrow functions, resulting in
unexpected behaviour where this inside lambda is undefined.

To give a bit more context: At the moment compiling contracts that point to external contracts (e.g. http and git) will fail.


Add specs for multiple macros

@jandudulski 👋 are you planning to fix it?

@solnic I'm trying but tbh there are a lot of moving parts here and some of them are mysterious to me. Like this:
# evaluator
macros.each do |args|
  macro = macro(*args.flatten(1))
  instance_exec(macro.extract_block_options(_options.merge(macro: macro)), &macro.block)
end

or this
# rule
@macros = macros.map { |spec| Array(spec) }.map(&:flatten)

so it might take some time before I will be able to solve this. Any tips here are more than welcome :D

@jandudulski you found the right places where things are broken. We need to make sure that @macros in Rule is set in the following way:

validate(:foo) => [:foo]
validate(:foo, :bar) => [:foo, :bar]
validate(foo: 1) => [[:foo, [1]]]
validate(foo: [1,2]) => [[:foo, [1,2]]]
validate(foo: [1], bar: [2]) => [[:foo, [1,2]], [:bar, [2]]]

and then that these cases are handled properly in Evaluator#initialize where we pass those to Contract#macro

@solnic that's something I can work with.

@solnic please take a look

Fixes #538 and #541


update for 1.5?

are you gonna make an update for 1.5?

Use either mine or legendros' fork. They both suport 1.5.1

kalebodonnel is there a possibilty of you uploading the exe and files? I do no know what to install for qtopen source and I dont have 600ish gb of storage for it.


syntax error on line 35, col 77: `$'

I'd posted this on stackoverflow too..  and narrowed this down to "es_facts.rb"
https://stackoverflow.com/questions/28656462/puppet-syntax-error-on-line-41-col-55-t
--snip--
Notice: Installing -- do not interrupt ...
/etc/puppet/environments/production/modules
└─┬ elasticsearch-elasticsearch (v0.9.1)
  └── puppetlabs-stdlib (v4.5.1) [/etc/puppet/modules]

%) sudo puppet agent --test --waitforcert 60 --environment production;
info: Retrieving plugin
notice: /File[/var/lib/puppet/lib/puppet/parser/functions/array_suffix.rb]/ensure: defined content as '{md5}f4d8cfd448698eb9594f49bb2ed3c263'
notice: /File[/var/lib/puppet/lib/facter/es_facts.rb]/ensure: defined content as '{md5}b4b33e1047d659e45cb2590402f4b376'
info: Loading downloaded plugin /var/lib/puppet/lib/facter/es_facts.rb
err: Could not load downloaded file /var/lib/puppet/lib/facter/es_facts.rb: syntax error on line 35, col 77: `'
info: Loading downloaded plugin /var/lib/puppet/lib/puppet/parser/functions/array_suffix.rb
err: Could not run Puppet configuration client: Could not retrieve local facts: syntax error on line 35, col 77: `$'

Thank you for the report. I'll have a look at this soon and see if I can find the issue

Hi, i've been doing several tests but have not been able to reproduce this.
Also ruby -c says the syntax is good.
I'll try to do some more debugging on this.
Can you check if the file copied over is fully correct?

Closing due to lack of feedback.


Error Serializing data

I'm trying to deserialize and then reserialize some player data (specifically this file)
    let mut file = std::fs::File::open("./simple_player.dat").unwrap();
    let mut bytes = Vec::new();
    file.read_to_end(&mut bytes).unwrap();
    let uncompressed = inflate(&bytes);

    let data = from_bytes::<PlayerData>(&uncompressed).unwrap();
    println!("{:?}", data);
    to_bytes(&data).unwrap();

The deserialization works fine but then I get a "no root compound" error when trying to serialize.
Full source of my test: main.rs

Hi Madeline, thanks for the report, especially for including the data and code. I'll have a look at this as soon as I can. Sorry you found a bug!
Cheers

Simple issue on fastnbt's part. I wasn't going to support serializing a bool since NBT does not really have them. But the deserializer happily deserializes 'byte' as a bool, so now it will also serialize it. The no root compound was a red herring error.
This is fixed in fastnbt 2.3.2 and master.
P.S. You might find serde's rename_all useful if you're not already aware of it, you can shorten your main struct to:
    #[derive(Debug, Serialize, Deserialize, PartialEq)]
    #[serde(rename_all = "PascalCase")]
    pub struct PlayerData {
        persistant_id: Option<i32>,
        #[serde(rename = "playerGameType")]
        game_type: i32,
        #[serde(rename = "abilities")]
        abilities: PlayerAbilityData,
        score: Option<i32>,

        dimension: i32,
        on_ground: bool,
        fall_distance: f32,
        motion: Vec<f64>, // [f64; 3]
        #[serde(rename = "Pos")]
        position: Vec<f64>, // [f64; 3]
        rotation: Vec<f32>, // [f32; 2]

        spawn_x: i32,
        spawn_y: i32,
        spawn_z: i32,
        spawn_forced: Option<bool>,

        portal_cooldown: Option<i32>,
        invulnerable: Option<bool>,

        attack_time: Option<i16>,
        hurt_time: i16,
        #[serde(rename = "HurtByTimestamp")]
        hurt_by: Option<i32>,
        death_time: i16,
        sleeping: bool,
        sleep_timer: i16,

        health: i16,
        #[serde(rename = "HealF")]
        heal: Option<f32>,
        #[serde(rename = "foodLevel")]
        food_level: i32,
        #[serde(rename = "foodTickTimer")]
        food_tick_timer: i32,
        #[serde(rename = "foodSaturationLevel")]
        food_saturation_level: f32,
        #[serde(rename = "foodExhaustionLevel")]
        food_exhaustion_level: f32,

        fire: i16,
        air: i16,

        xp_p: f32,
        xp_level: i32,
        xp_total: i32,
        xp_seed: Option<i32>,

        inventory: Vec<InventoryEntry>,
        ender_items: Vec<i8>,

        selected_item_slot: Option<i32>,
        selected_item: Option<InventoryEntry>,
        #[serde(rename = "UUIDLeast")]
        uuid_least: Option<i64>,
        #[serde(rename = "UUIDMost")]
        uuid_most: Option<i64>,
        absorbtion_amount: Option<f32>,
        attributes: Option<Vec<AttributeEntry>>,
        active_effects: Option<Vec<ActiveEffect>>,
    }

But I see you might be well aware of this but just rename each field since Minecraft's way of storing data is so inconsistent...


feat: add print/fatal/error convenience methods

Codecov Report

Merging #48 (92de95f) into main (8982236) will decrease coverage by 0.83%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   56.46%   55.63%   -0.84%
==========================================
  Files          21       21
  Lines        1098     1118      +20
==========================================
+ Hits          620      622       +2
- Misses        423      441      +18
  Partials       55       55

Impacted Files
Coverage Δ

wish.go
38.63% <33.33%> (-23.87%)
:arrow_down:

git/git.go
59.57% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8982236...92de95f. Read the comment docs.


Question re: #226 Using Micro services as proxies

[https://github.com/DinisCruz/Book_Software_Quality/pull/226/files]
I just want to check that my understanding is correct in this paragraph:
L 13: "The power of this workflow is that because you now have the unit test that locks the micro web service, you could move that new functionality to the micro service, and leave the main one online. This means that you allow the main web service to be conservative in making changes and sustainability. This supports robustness, consolidation, and re-factoring. Knowing that the clients are the micro web services, there is a very tight relationship between them which can secure, queue, and perform all sorts of tests before it reaches the client."

yeah looks good (I will make a couple further changes when I merge it into the main text)


Update methods-for-removing-user-access.md

@ArvindHarinder1 : Thanks for your contribution! The author, @barbkess, has been notified to review your proposed change.

#sign-off


unresolved extenal symbol in ConnectedThresholdImageFilter

Description

vs2019 report unresolved external symbol in ConnectedThresholdImageFilter's printself function
Steps to Reproduce

using vcpkg to install itk via vcpkg install itk[vtk]:x64-windows
using the example code in https://itk.org/ITKExamples/src/Segmentation/RegionGrowing/ConnectedComponentsInImage/Documentation.html?highlight=connectedthresholdimagefilter

Expected behavior

it should run properly
Actual behavior
vs2019 reported unresolved external symbol in ConnectedThresholdImageFilter's printself function
the detail report as below:
Severity	Code	Description	Project	File	Line	Suppression State Error	LNK2019	unresolved external symbol "__declspec(dllimport) class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl itk::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum itk::ConnectedThresholdImageFilterEnums::Connectivity)" (__imp_??6itk@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV12@W4Connectivity@ConnectedThresholdImageFilterEnums@0@@Z) referenced in function "public: virtual void __cdecl itk::ConnectedThresholdImageFilter<class itk::Image<unsigned char,3>,class itk::Image<unsigned char,3> >::PrintSelf(class std::basic_ostream<char,struct std::char_traits<char> > &,class itk::Indent)const " (?PrintSelf@?$ConnectedThresholdImageFilter@V?$Image@E$02@itk@@V12@@itk@@UEBAXAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@VIndent@2@@Z)

Reproducibility

Versions
itk5.1.0

Environment
vs2019
vtk9.0.1
qt5.15.2

Additional Information
I delete the printself function in ConnectedThresholdImageFilter.h and hxx.
Then the project build success.

@jjjkkyz thanks for the report. Does the same issue occur with ITK Git master?

@jjjkkyz thanks for the report. Does the same issue occur with ITK Git master?

Well, I haven't  test it on git master. If it's neccessary, I'll try.


Fix errors in develop

After merging over 10 Pull Requests in last hacknight we ended up with some errors in develop which I am addressing here. Please review toughly and add any needed fixes to this, thanks.

Amazing work - thank you


redesign the "data"-collection and adapt wis2box-stack, to support new version of bufr2geojson

Investigation into https://github.com/wmo-im/wis2box/issues/783 leads me to conclude that we need to move to a new version of bufr2geojson as Dave as made various fixes.
We need to adapt to this new version of the wis2box-stack :

update the oaproc to extract relevant fields for publishing using new bufr2geojson
update code in backend/elastic.py to create an "observation"-collection
adapts clients of oaproc to use the new structure where required, wis2box-webapp and wis2box-ui

Observation-collection to hold a subset of data returned by bufr2geojson, for example:
"properties": {
        "host": "0-20000-0-60355",
        "observedProperty": "air_temperature (minimum value)",
        "phenomenonTime": "2024-11-01T07:00:01Z/2024-11-02T07:00:01Z",
        "result": {
            "value": 0.6,
            "units": "Celsius",
            "standardUncertainty": null
        }
 }