DevStudio fails to install with detected java

Codecov Report

Merging #1316 into master will decrease coverage by 0.59%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #1316     +/-   ##
========================================
- Coverage   93.69%   93.1%   -0.6%
========================================
  Files          45      45
  Lines        4679    4757     +78
  Branches      512     806    +294
========================================
+ Hits         4384    4429     +45
- Misses        295     299      +4
- Partials        0      29     +29

Impacted Files
Coverage Δ

browser/model/devstudio.js
99.09% <100%> (+0.01%)
:arrow_up:

browser/model/devstudio-autoinstall.js
97.29% <0%> (-2.71%)
:arrow_down:

browser/services/request.js
97.61% <0%> (-2.39%)
:arrow_down:

browser/pages/install/controller.js
91.86% <0%> (-1.75%)
:arrow_down:

browser/model/helpers/downloader.js
95.53% <0%> (-1.68%)
:arrow_down:

browser/model/che.js
95% <0%> (-1.62%)
:arrow_down:

browser/model/jdk-install.js
93.04% <0%> (-1.49%)
:arrow_down:

browser/services/platform.js
97.05% <0%> (-1.41%)
:arrow_down:

browser/pages/account/controller.js
98.61% <0%> (-1.39%)
:arrow_down:

browser/model/cdk.js
98.74% <0%> (-1.26%)
:arrow_down:

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddc7bb...1600a5a. Read the comment docs.

test this

I'm hijacking this PR to fix some other components as well :)

meh, it doesn't work with a freshly installed jdk now :(

Hopefully it is fixed now


Onagre failing to detect theme

Describe the bug
When I try to start Onagre it fails to detect the theme and gives this error:
"Failed to parse theme:
Failed to open config file
Failing back to default theme".
After that it launches without any theme or icons.
Config
I use the not-adwaita config from the example directory but I replaced the Papyrus icon theme with Adwaita.
To Reproduce
Install onagre-git from aur. Launch with a theme specified with -t or one in /etc/xdg/onagre/theme.cscs or ~/.config/onagre/theme.cscs.
Expected behavior
Onagre should launch with a theme applied.
Window manager (please complete the following information):
Hyprland (Arch)
Additional context
I already tried manually specifying the path to the theme and used other themes from the examples. I also tried to manually set the $XDG_DATA_DIRS to /usr/share/icons.

Hey @Jozhin-s-Bazhin.
You have a typo in your theme filename, it should be theme.scss not theme.cscs
If that does not solve your issue you can try to install the latest onagre version with cargo:
cargo install onagre --git https://github.com/oknozor/onagre --locked

Then make sure to move onagre to the bin dir:
sudo mv ~/.cargo/bin/onagre /usr/bin/onagre

Let me know if that works for you.
PS: I am sorry, currently the installation process is a bit manual, we are waiting for pop-os devs to release some library to make an official onagre v1 release.

I followed your instructions and it worked, but only after I put the config file in ~/.config/onagre/theme.scss. With strace I got these logs when trying to manually specify the config file:
"log.103431:readlink("/etc/xdg/onagre/theme.scss", 0x7ffcd1115cf0, 1023) = -1 EINVAL (Invalid argument)
log.103431:openat(AT_FDCWD, "/home/roman/.config/onagre/theme.scss", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
log.103431:statx(AT_FDCWD, "/usr/share/icons/locolor/index.theme", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffcd110c5f0) = -1 ENOENT (No such file or directory)
log.103431:statx(AT_FDCWD, "/usr/share/icons/spotube/index.theme", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffcd110c5f0) = -1 ENOENT (No such file or directory)"

I reinstalled onagre from the aur and when the file is in ~/.config/onagre it works fine. I guess the issue has to do with me naming the file wrong and the -t flag not working.


Update popper homepage with deprecation notice.

Floating-UI is great!
It could have saved me some time if there was a note of where to obtain the latest version of the library rather than pointing users to the now stale popperjs installation instructions. Thanks!

We are planning to add a notice, but keep in mind Popper v2 is in a very mature and stable phase and it's perfectly suitable for production projects.

Popper v2 is still supported and will be getting bugfixes. It won't be receiving features though due to size/architecture constraints. So it depends on what you view as "deprecated". A lot of big projects are using it and will for a while!

Okay, it would be good to have a hint towards floating-ui because it is the better solution for many problems (like in my case)


Planning on adding the upgraded features farshadz1997 added?

discord, shuffle etc

You're welcome to make a PR if you want, might be done if I find the time to do it

I can go ahead and do the discord one

Do you know if anyone still has the farshadz1997 code?

Do you know if anyone still has the farshadz1997 code?

Yeah its still here

It's now done !


Redirect fix; mumbai not supported by gnosis

:tada: This PR is included in version 1.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


SS4: TreeDropdownField_Readonly / LookupField returns escaped html

SS4-beta4: The TreeDropdownField_Readonly / LookupField returns escaped(? .. html-encoded) html code in the read-only fields. Below a sample of a non-editable RedirectorPage:

I think this is related to the last-year fixed XSS for the read-only transformation?
Does it happen in SS3.latest as well?

Fix at #7512, although we probably need either a merge up or another issue in the CMS to fix the icon alignment:

Another fix at https://github.com/silverstripe/silverstripe-framework/pull/7517


Creating a new project targeting iOS, target project format is XCode 3.2

Steps to Reproduce

From VSCode use the Flutter: New Project command.
Enter myapp for the project name, let Flutter build the project files
Use XCode to open the project
Select the top level Runner node in the project tree view
Look to the right in the File Inspector, under Project Format

Please update to at least XCode 9. As of April 2018 all new apps submitted to the App Store are required to target iOS 11, (requiring XCode 9), come March 2019 all new apps submitted to the App Store are are required to target iOS 12.1, (requiring XCode 10)

Is this causing an actual issue other than it just being inconsistent with Flutter tools requiring Xcode 9.0?  The Xcode project compatibility version isn't related to the minimum SDK version you mentioned for App Store submission AFAIK.


Use in Web Application

Can this be used in a Javascript Web App instead of a chrome extension. Like in a NuxtJS or NextJS web app ?

Can this be used in a Javascript Web App instead of a chrome extension. Like in a NuxtJS or NextJS web app ?

What you mean with your question? Linguist is an standalone full featured application. If your question is "is it possible to embed a Linguist into my application" then answer probably no, by the same reasons you can't embed twitter or Cyberpunk 2077.
But you we have NPM package https://github.com/translate-tools/domtranslator used by Linguist, that let you handle DOM elements for translation. And also we have a NPM package https://github.com/translate-tools/core used by Linguist, that provide translators implementations. So, you may use this packages to implement your own code for translation on client side.
If you looking for an embedded solution for translate DOM, you may create it yourself as described above, or you may contact me with email if you need help with implementation or deep consulting. If you are ready to implement it yourself, feel free to create issues in mentioned repositories about any bugs or documentation related questions.

@vitonsky thanks. I just thought it would be good to have a Linguist standalone version to install via npm. So a person have a choice to install the chrome extension or have it provided by a Web app, where it's integrated in the app by the developer. I will play around with your suggestions. Thanks.


ac - init at 0.1.1

Motivation for this change
Add ac as a package.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Feel free to open a new pull request if you're still interested in getting this into Nixpkgs.


Handled JSON Error

#65

@studentgrad0419 do you want to add that as a next story ? we can close this issue for the time being then


Timer consistency

The current tick-based timer relies on accurate tick timing to achieve accurate event timing. This can lead to significantly longer competitions if the server isn't running at maximum ticks. Perhaps consider using server time to determine time remaining rather than how many ticks have passed.

Thank you very much, I'll try implementing this some time tomorrow possibly, or at least before the next update.

The timer now syncs with the real time at regular intervals to prevent this from ocurring. Thanks for reporting :)


Swap JSON parser

This PR swaps out the JSON parser found in Language.JSON in contrib for @stefan-hoeck's parser-json (idris2-parser).
This also remove the dependency on contrib.

The Makefile ought to run locally for you to save the round trip of GitHub CI running, though I don’t mind hitting the button to get it to run again.

The Makefile ought to run locally for you to save the round trip of GitHub CI running, though I don’t mind hitting the button to get it to run again.

I apologize, was fairly certain this Makefile would build.
I did make locally first and it built.  Not sure what is going on here, but will get this fixed up.

Without digging into the changes in much depth yet, my high level critique would be that I assume there's no reason we can't retain totality for those functions you've made partial so I'd like to do that since totality is such a nice guarantee. Even when I don't get totality I almost never opt for partial over covering (again because coverage checking is such a nice benefit offered by the compiler).

Without digging into the changes in much depth yet, my high level critique would be that I assume there's no reason we can't retain totality for those functions you've made partial so I'd like to do that since totality is such a nice guarantee. Even when I don't get totality I almost never opt for partial over covering (again because coverage checking is such a nice benefit offered by the compiler).

I agree with that, I'll re-work the partial functions so that they are at least covering.

@mattpolzin
I was able to rewrite the typeSpec function using substr in Prelude.Types instead of using the partial strTail function in Data.String, removing all of the partial annotations.
See 47e01888693e879da76afba3076001165fcbad97.

@mattpolzin
Not sure if you have time, but if this most recent commit doesn't build, would you mind taking a look at the Makefile?  I'm sure I'm missing something silly (not a Makefile expert by any means).

Sure. These days with pack around having a Makefile is kind of extra credit but I do want to maintain that because I’ve gone through the effort of making the project build without pack as a dependency. Happy to fix any remaining finicky details.

Sure. These days with pack around having a Makefile is kind of extra credit but I do want to maintain that because I’ve gone through the effort of making the project build without pack as a dependency. Happy to fix any remaining finicky details.

Awesome, thank you for helping with this!

Thanks for taking the time to swap out contrib with Stefan's faster JSON library!
I'm still working through the combination of build & test failures as you can probably see but while I work on that there are some stylistic/preferential requests I have for you.

You're welcome, I'm glad that I am able to contribute!
Sounds good, see my commits below addressing your comments (you had great ideas/requests btw).

I think we're there! Thanks again.

Awesome, you're welcome!


Nightly bump version workflow

This GitHub actions workflow runs daily at 3:00 AM and does the following if there has been new commit(s) on the develop branch of tudatpy in the last 24 hours:

Bump dev version: dev field of the version number in the files version and .bumpversion.cfg will be bumped by 1. This will result in a new commit.
Create a tag with the above version, and push the tag and the commit to the tudatpy develop branch
Bump dev version in tudat-feedstock: dev field of the version number in recipe/meta.yml and .bumpversion.cfg will be bumped by 1. This will result in a new commit.
Create a tag with the above version, and push the tag and the commit to the tudatpy-feedstock develop branch

This workflow must be present in the master branch because scheduled workflows run only on the default branch, so the PR is opened towards master. This version does not make any changes to the master branch of tudatpy and tudatpy-feedstock though. This is controlled by specifying the checkout of develop branch in the workflow. This ensures that the bump version action will be performed on the develop branches.
This pull request should be merged after the changes in branch https://github.com/tudat-team/tudatpy-feedstock/tree/19-add-bumpversion-cfg are merged to the develop branch of tudatpy-feedstock, so the bumpversion operation can be performed successfully in tudatpy-feedstock.
To do

[ ] Create Personal access token as described here and fill in the secret name in the placeholder in the workflow.

Warnings for this workflow
From the GitHub documentation, workflows that run on a trigger of type schedule (e.g. every night at 3 am) have the following constraints:

In a public repository, scheduled workflows are automatically disabled when no repository activity has occurred in 60 days. For information on re-enabling a disabled workflow, see "Disabling and enabling a workflow."

This warrants no action from our side, but it's good to keep it in mind. Tudat and tudatpy are both very active repos so I don't expect a problem.

When the last user to commit to the cron schedule of a workflow is removed from the organization, the scheduled workflow will be disabled. If a user with write permissions to the repository makes a commit that changes the cron schedule, the scheduled workflow will be reactivated. Note that, in this situation, the workflow is not reactivated by any change to the workflow file; you must alter the cron value and commit this change.

Since @niketagrawal and myself will leave the project at some point, it would be best for @DominicDirkx to make a change to the cron trigger in the workflow file to prevent the workflow from being disabled.


Memory usage explosion with very narrow images (e.g. book spine)

With this document (PPN894261851.zip) we experienced an OOM error. Further investigation revealed this memory usage (measured using procpath):

The culprit seems to be this "page" from the document - an image of a book spine:

Relevant parts from the log output:
18:25:30.757 INFO eynollah - INPUT FILE PHYS_0017 (17/18)
18:25:30.780 INFO eynollah - resize and enhance image
18:25:30.780 INFO eynollah - Detected 25 DPI
18:25:40.756 INFO eynollah - Found 5 columns ([[4.1955504e-01 1.7818451e-13 2.7631987e-21 7.5972243e-22 5.8044493e-01
  0.0000000e+00]])
18:31:39.449 INFO eynollah - Image is enhanced
18:31:40.369 INFO eynollah - Enhancing took<PHONE_NUMBER>660736s
18:31:47.043 INFO eynollah - Image dimensions: 448x672
18:43:35.935 INFO eynollah - Image dimensions: 224x448
18:52:07.638 INFO eynollah - Image dimensions: 448x672
19:01:28.031 INFO eynollah - Textregion detection took 1787.6620445251465s
19:01:36.604 INFO eynollah - Graphics detection took 8.571088552474976s
19:01:36.604 INFO eynollah - cont_page [array([[  519,   445],
       [ 4404,   445],
       [ 4404, 27685],
       [  519, 27685]])]
19:01:41.160 INFO eynollah - Image dimensions: 448x672
19:08:15.645 INFO eynollah - textline detection took<PHONE_NUMBER>6735535s
19:26:32.295 INFO eynollah - slope_deskew: -90.0
19:26:32.451 INFO eynollah - deskewing took 1096.8060252666473s
19:26:33.040 INFO eynollah - detection of marginals took 0.5885534286499023s
19:26:55.466 INFO eynollah - Image dimensions: 896x896
19:27:51.663 INFO eynollah - Image dimensions: 896x896
19:34:22.576 INFO eynollah - areas_cnt_text [1.60449940e-05 3.67248936e-05 4.69396395e-05 1.78734430e-05
 6.68446924e-05 1.59316018e-05 2.67794541e-05 3.35782605e-05
 2.04153178e-05 1.02601028e-04 1.49299709e-05 2.50974700e-05
 1.09640792e-04 4.56729543e-04 1.69521315e-05 7.82122588e-05
 9.06334276e-05 2.25603199e-04 1.58796304e-05 4.07455914e-05
 1.44858515e-05 1.97103964e-04 3.92242463e-05 2.14925435e-05
 2.01601854e-05 1.57520642e-05 1.14313495e-04 2.90331237e-05
 1.44291554e-04 2.15615238e-04 3.12064739e-05 4.46585667e-04
 2.03675986e-04 4.18700639e-05 2.75817038e-04 2.86669615e-04
 4.78515016e-05 1.76816212e-04 2.13172581e-04 2.02211337e-04
 3.27372684e-05 1.72403366e-05 1.62434303e-05 3.26522243e-05
 2.49226571e-05 1.41551243e-05 2.55297777e-04 2.39352001e-05
 1.48591008e-05 1.77080794e-05 1.41844173e-04 7.28828262e-05
 1.27079565e-04 1.09125803e-04 5.03886517e-05 1.61253135e-05
 2.59356273e-04 3.43578317e-05 1.49417826e-04 1.00711158e-04
 1.49819423e-05 5.42553252e-04 2.48706857e-05 2.26875554e-03
 4.71257916e-04 8.13966893e-05 7.39080805e-05 4.21195267e-04
 3.22033802e-05 2.35572262e-04 2.46580753e-05 2.20656465e-04
 2.95670119e-05 1.99759231e-05 4.83650737e-04 2.61520173e-04
 1.14686745e-04 5.78111151e-05 1.14729267e-04 1.89081467e-05
 1.68529133e-04 1.66998339e-04 1.72875834e-05 2.23552691e-04
 1.04831546e-03 6.28268293e-04 5.47693697e-04 1.98365452e-04
 2.78094331e-05 6.26397322e-05 5.01098959e-05 1.08133621e-04
 9.64258784e-05 5.27179162e-05 6.81203545e-05 1.25246392e-04
 7.48104933e-04 8.99908719e-05 6.32440181e-04 1.75379911e-05
 9.17437261e-05 3.56807405e-05 3.17781595e-05 2.56077349e-05
 1.14162306e-04 3.40275770e-04 1.91113077e-05 2.73133423e-05
 2.53143326e-04 4.32118714e-05 1.93848663e-04 3.59594963e-05
 1.95918070e-04 1.34687236e-03 1.60180634e-04 2.35761249e-05
 6.63717525e-04 4.14731913e-05 1.89790168e-05 1.82136195e-05
 1.86530142e-05 2.08773909e-04 2.22569958e-04 3.77780235e-04
 4.02589500e-05 5.98474497e-05 1.02081314e-04 3.75233635e-05
 4.72098908e-04 5.47306274e-05 1.23058868e-04 1.49281755e-03
 8.34802707e-05 1.13349662e-04 2.02093220e-04 2.57681376e-03
 2.15686108e-04 5.79150579e-05 4.43079958e-05 2.98197820e-04
 2.61132750e-05 8.44677276e-05 5.68189335e-05 3.62051794e-05
 7.14342410e-04 1.95589233e-03 1.87621542e-04 2.56549816e-05
 1.75568898e-05 1.43630100e-05 9.49763483e-04 5.73769175e-04
 3.36840932e-04 1.75474405e-05 1.04953916e-04 6.89329984e-05
 6.42224981e-05 2.66504705e-04 6.18412623e-05 5.68283828e-05
 2.05906032e-04 1.20568964e-04 2.07554943e-05 2.06421021e-05
 6.66509807e-05 3.16127959e-05 1.37913244e-05 7.39458779e-05
 3.90399840e-05 2.61038257e-05 2.60187815e-05 2.02953110e-04
 4.78609509e-05 1.26876404e-04 8.87908046e-05 4.99917791e-05
 2.68890665e-04 4.74404549e-05 1.45269562e-04 1.67092832e-04]
19:43:02.340 INFO eynollah - Job done in 4651.560835599899s

This log output is not from the OOM, but another run I did on a different machine to investigate the problem. If I interpret the cont_page part correctly, the image is blown up to [ 4404, 27685], which would certainly explain the OOM error on the other machine.
Reproduce with ocrd-eynollah-segment -I MAX -O TEST-SEGMENT -P models /path/to/models.

Same problem with a different document, but also a book spine:

Yes, it should be possible to skip pages marked as certain types in the logical structmap – not just in any one processor, but as a general mechanism for workflows in OCR-D.
For the concrete set of supported page types, we should stick to DFG Strukturdatenset, which is strangely missing colour_checker.
This set is also partially supported by ocrd-anybaseocr-layout-analysis:
{'annotation': 0, 'binding': 1, 'chapter': 2, 'colour_checker': 3, 'contained_work': 4, 'contents': 5, 'cover': 6, 'edge': 7, 'endsheet': 8, 'epicedia': 9, 'illustration': 10, 'index': 11, 'musical_notation': 12, 'page': 13, 'paste_down': 14, 'preface': 15, 'provenance': 16, 'section': 17, 'sermon': 18, 'table': 19, 'title_page': 20}

For the general mechanism, I suggest something along the lines of our --page-id CLI option's existing numerical range syntax, but more elaborate. For example, one could define filter operators that can look into the structmap, perhaps XPath expressions with predefined functions?

Yes, it should be possible to skip pages marked as certain types in the logical structmap – not just in any one processor, but as a general mechanism for workflows in OCR-D.
For the concrete set of supported page types, we should stick to DFG Strukturdatenset, which is strangely missing colour_checker.

100% agree! Should we take this to an OCR-D core or spec issue? I have some additional thoughts to discuss (like: What happens with skipped pages in the output?)

Should we take this to an OCR-D core or spec issue?

Yes, we should elevate this to OCR-D/spec.

I have some additional thoughts to discuss (like: What happens with skipped pages in the output?)

There is already some discussion on skip strategies for API changes in spec...

With the current version including https://github.com/qurator-spk/eynollah/issues/67 I was able to

process FILE_0017_MAX.tif successfully without memory explosion
process the whole document PPN894261851 using the -di flag without running into memory issues

Is there anything relevant from here that is still needed for https://github.com/OCR-D/spec/issues/172#issuecomment-693593327 or can we close this?

With the current version including #67 I was able to
* process `FILE_0017_MAX.tif` successfully without memory explosion7

* process the whole document PPN894261851 using the `-di` flag without running into memory issues

Is there anything relevant from here that is still needed for OCR-D/spec#172 (comment) or can we close this?

I wouldn't know, the current version is not working for OCR-D and so I can't reproduce until it's fixed. (Yes, there is a elaborate workaround but I am not willing to invest the time to reproduce with a lengthy changeset (#86) missing.)


Could not load aws-sdk using node.js

Hi,
I installed node.js in my PC, and installed aws-sdk successfuly with the below command.
npm install aws-sdk -g package.json
I have a html file, in which i am trying to ling aws-sdk. But it is failing.
Code looks like this,
var s3;
function inits3()
{
alert("alert1");
//var AWS = require('C:/Program Files/nodejs/node_modules/aws-sdk');
var AWS = require('aws-sdk');
alert("alert2");
s3 = new AWS.S3({ params: { Bucket: 'test' }});
}
Note : I am getting the alert box message alert1 but not alert2.
Please suggest!!
Regards.

I think you intended the aws-sdk-js repositiory?
https://github.com/aws/aws-sdk-js/issues


Add a search bar to the theme

Hell. can you add a search bar feature to the widgets in this theme it doesn't have to be an internal search engine just a #search bar that take you to google something like this one in this theme Mainroad theme
demo site to check it : https://mainroad-demo.netlify.app/

thank you very much 👍  google search is enough for me  :)


Add button component

Description
Add button component
Please provide a short summary explaining what this PR is about.
Fixes #127
How to test?
Please provide a short summary how your changes can be tested?
Checklist

[ x] I have performed a self-review of my own code
[ x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x ] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[ x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[ x] This PR is ready to be merged and not breaking any other functionality

I am just going to merge it :)


Expeses: add description field to the expenses model

#51

Hey @adiabramovitch
there are 2 commits in this PR
The first one was actually add of the description to the expenses model
The second one is to ignore long lines that generated by the Django framework
If necessary I can split it into two PRs, merge the flake8 fix, and after that one merge actually added the description
I don't really see a reason to split these two

@ronyyosef  please follow https://cbea.ms/git-commit/ the commit-msg is supposed to start with uppercase and then I can merge it

Fixed!

@ronyyosef resolve conflicts and I can merge

This PR is ready to merge


Actions of the template not working if deploying in another region

All actions of the create_cloudformation template that deploy a Lambda function are relying on the bucket "com.gilt.public.backoffice". Unfortunately, CloudFormation does not achieve to create these lambda functions.
It fails with the usual code "Permanently redirect ..." indicated that you try to access a s3 bucket not located in the same region as yours.
I downloaded the "cloudformation-helpers.zip" file, hosted it in a bucket in the right region, modified the template to point to my bucket and ... it works !
However, I don't know how to fix this easily. Maybe just some documentation on the README ...
But in the end : thank you very much for sharing all this code !

Nota : I am deploying in eu-west-1, in which region is the bucket "com.gilt.public.backoffice" ?

Ok, thanks for the note. I've only ever tried deploying this in us-east-1. Either I need to created the same bucket in all regions, or I need to tweak the permissions on that bucket. I'll take a look.

I figured out the solution for this: I need one bucket for each region and can add a chain of cross-region replications to duplicate the file so it's available in all regions. This will also require a small change to the CloudFormation template; I'll comment back here when this is done.

Nice ! Looking forward for the proper way to do this in the CloudFormation template.


Geodesic Polyline support in iOS

Description
Polylines in iOS are not curved based on the earth's curvature even if we set geodesic true in flutter dart code. This is because this property passed to the plugin native code isn't used. I have set this property after GMSPolyline Objc instance created
Related Issues
flutter/flutter#49189
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Error output from Xcode build:
↳
    ** BUILD FAILED **

Xcode's output:
↳
    /var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/ios/Classes/GoogleMapPolylineController.m:128:71: error: use of undeclared identifier 'geodisc'; did you mean 'geodesic'?
                                                                 geodesic:geodisc.boolValue
                                                                          ^~~~~~~
                                                                          geodesic
    /var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/packages/google_maps_flutter/google_maps_flutter/ios/Classes/GoogleMapPolylineController.m:124:15: note: 'geodesic' declared here
        NSNumber* geodesic = [FLTPolylinesController isGeodesic:polyline];
                  ^
    1 error generated.

@ditman Yes. corrected

This has been tagged and published to google_maps_flutter: ^0.5.31


Improve multi-image support for STM32 UART and timer drivers

Hi!
These changes add UART and timer reset using RCC. This is needed in multi-image environment to make sure that the devices are initialized correctly and won't cause system crash or hang.
Best regards,
Patryk

Friendly ping.

Added reset driver for STM32 and STM32MP1. Used reset API in UART and timer drivers.

I replaced defines in DTS with STM32_RESET(). To do that, I used magic power of C preprocessor and sed.

Added missing newline at the end of include/zephyr/dt-bindings/reset/stm32u5_reset.h file.

Split changes in DTS from changes in driver. Fixed typo.

Restored call to LL_UART_Disable


Rename variables called "timezone"

Since we build with -Wshadow, we can't use the name of the global
variable "timezone".
Signed-off-by: Thiago Macieira<EMAIL_ADDRESS>

+1


[Feature Request] [NOWEB] Ignore contacts not to be synced

Hello!
It's possible to ignore certain contacts, maybe on session creation, not to be synced?
The idea is to given list of contacts, exclude them from the Full Sync process and don't storage any info from these contacts.

Hi! Could you explain your pain points?
like storage is nothing for saving contacts (even if you have 100K, that's fine), so not sure what we'll solve with that approach :thinking:
For /contacts/ we're adding limit&offset parameters, so you filter this properly as well https://github.com/devlikeapro/waha/issues/371

don't storage any info from these contacts

Do you mean like ignore incoming messages and etc?

don't storage any info from these contacts

Do you mean like ignore incoming messages and etc?

Yes! I don't want to store anything from contacts on this "ignore" list.

Hi! Could you explain your pain points? like storage is nothing for saving contacts (even if you have 100K, that's fine), so not sure what we'll solve with that approach 🤔 For /contacts/ we're adding limit&offset parameters, so you filter this properly as well #371

I'll probably have many users with huge amount of messages and contacts, .ie:

But not every "chat|contact" needs to be synced. So I was thinking in minimize the cost of storage (currently in MongoDB Atlas).

oh, do you want to be in free tier there?
Unlikely we'll implement the request at all, but may be we'll add cleanup API in the future, hit +1 there if you need it!
https://github.com/devlikeapro/waha/issues/592

oh, do you want to be in free tier there? Unlikely we'll implement the request at all, but may be we'll add cleanup API in the future, hit +1 there if you need it! #592

I've never mentioned free tier.
But ok, I'll follow updates from #592 then.


Fix image kebabs

Added kebabs to all rows in image table and set to disabled when no actions are available. Ticket THEEDGE-999

Codecov Report

Merging #146 (decc770) into master (a4b593a) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   26.38%   26.30%   -0.08%
==========================================
  Files          77       77
  Lines        1319     1323       +4
  Branches      337      339       +2
==========================================
  Hits          348      348
- Misses        896      898       +2
- Partials       75       77       +2

Impacted Files
Coverage Δ

src/Routes/ImageManager/ImageTable.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b593a...decc770. Read the comment docs.


Local is exposing too many implementation details

We should make the Context class in Local private or at least its implementation.
Is there any reason for the user to have access to the methods of Context or to Bound / Unbound?
The problem is that I'm sure this isn't the final Local implementation and it would be a pity to break binary compatibility for simple fixes.

Is there any reason for the user to have access to the methods of Context or to Bound / Unbound?

Actually I see that the macros are calling those methods now 🙂 I'm a little worried that we are exposing methods with Any in their signature.
Also are the Bound / Unbound classes required to be public?

Pretty sure Bound / Unbound being public is an oversight.
We could remove macros for other cases, if they aren't really buying us much performance. I preserved them as they were already here.
Also we can make things private[monix] (should be bincompatible, IIRC that translates to JVM public anyway). I had some ideas for a Local that can work for any F if its ContextShift is backed by a TracingScheduler, which is why I left things quite lax.
At least parts that are used in TaskLocal should remain public for anybody daring to do such thing. One thing in particular is that isolate needs to be reimplemented in terms of effect type's bracket with getContext/setContext.

Fixed in #946, I assume we don't do anything else related to it


Support new Philips Hue 1600 lumen bulbs

Hi, you probably don't need all the stuff below, but I've added it anyway.
I think we just need an extra line in ../adapters/philips/__init.py like this: -
'929002335001': DimmableBulbAdapter,    # Philips Hue white A21 bulb B22 with Bluetooth (1600 Lumen)
I know this works because I have some of these bulbs and have tested the change.
Note that there is also an Edison version of the same bulb which is also already supported in zigbee-herdsman-converters, so it might be a good idea to add it at the same time: -
'9290023349': DimmableBulbAdapter,    # Philips Hue white A67 bulb E26 with Bluetooth (1600 Lumen)
Note that I don't have one of the Edison ones so I can't test that change.
Hugh
Device description
Philips Hue white A21 bulb B22 with Bluetooth (1600 Lumen)
Zigbee2mqtt page
Not yet added to that page but has been added to zigbee-herdsman-converters/devices.js
MQTT message with device information
PUT here the device data you receive when publish message with topic
zigbee2mqtt/bridge/config/devices, as example
{"ieeeAddr":"0x0017880108d981b0","type":"Router","networkAddress":2110,"model":"929002335001","vendor":"Philips","description":"Hue white A21 bulb B22 with Bluetooth (1600 Lumen)","friendly_name":"LOUNGE.DINING.CEILING","manufacturerID":4107,"manufacturerName":"Philips","powerSource":"Mains (single phase)","modelID":"LWA010","hardwareVersion":1,"softwareBuildID":"1.55.7_r28193","dateCode":"20190322","lastSeen":1599138898877}

**MQTT messages from device**
Put here examples of MQTT messages with different states you've received from device, as example
info  2020-09-03 13:40:05: MQTT publish: topic 'zigbee2mqtt/LOUNGE.DINING.CEILING', payload '{"brightness":254,"linkquality":117,"state":"OFF","update_available":false,"device":{"friendlyName":"LOUNGE.DINING.CEILING","model":"929002335001","ieeeAddr":"0x0017880108d981b0","networkAddress":2110,"type":"Router","manufacturerID":4107,"manufacturerName":"Philips","powerSource":"Mains (single phase)","applicationVersion":2,"stackVersion":1,"zclVersion":2,"hardwareVersion":1,"dateCode":"20190322","softwareBuildID":"1.55.7_r28193"}}'

MQTT state change commands
info  2020-09-03 14:20:19: MQTT publish: topic 'zigbee2mqtt/LOUNGE.DINING.CEILING', payload '{"brightness":117,"linkquality":117,"state":"ON","update_available":false,"device":{"friendlyName":"LOUNGE.DINING.CEILING","model":"929002335001","ieeeAddr":"0x0017880108d981b0","networkAddress":2110,"type":"Router","manufacturerID":4107,"manufacturerName":"Philips","powerSource":"Mains (single phase)","applicationVersion":2,"stackVersion":1,"zclVersion":2,"hardwareVersion":1,"dateCode":"20190322","softwareBuildID":"1.55.7_r28193"}}'

Thanks! Updated the plugin


Add error handling code about get timeseries data (#45)

Category

[ ] New feature
[ ] Bug fix
[x] Improvement
[ ] Refactor
[ ] etc

Description
This PR related with #46.
So if you want to follow this issue please see #46.

add error handling code about get timeseries data

insert try-except code

Known issue

#45

@jihyungSong
As you mentioned in our direct conversation, I added defensive code.


codehelper

Issue Type: Bug
Hi,
I'm using the macOS High Sierra and I would like to report the issue of 100% using CPU by service "CodeHelper". So I have to everytime kill the VSC and run again
I do not know cause of this issue, but its not comfortable to write the code with that. Please, is it possible to do something with it?
I love VSC, but this issue is slowing my work.
 In my case, it only intermittently goes to 100%, but when it does I experience a lot of slowdown, etc.

I too am experiencing this. With the Vim extension enabled, this causes the editor to be stuck in command mode and essentially locks up the application. Even basic commands appear to start this codehelper spike.
OS: MacOS Sierra.
VS Code version: Code 1.25.1

Can you run code --status and paste in the process info? Also in the future these details will be included automatically if you report a performance issue through the issue reporter.
You can also use the process explorer in the Help menu to identify the problem process.

Hi,
I'm not sure if is it ok, but now again in code helper is lot of uknown binaries with 100%
Vzorek procesu Code Helper.txt

Hi,
I'm not sure if is it ok, but now again in code helper is lot of uknown binaries with 100%
Vzorek procesu Code Helper.txt

I've updated some information about that. Let me know if you have any idea.

Hi,
I've just tell to everyone, that bug has been fixed by disable extension the
AutoFileName
now everything is ok. Thanks for your help.

Created https://github.com/Jerry-Hong/vscode-autofilename/issues/19


Child location's slug is autogenerated using parent's UUID rather than slug

Environment

Nautobot version (Docker tag too if applicable): v1.4.2
Python version: 3.8
Database platform, version: PostgreSQL v13

Steps to Reproduce

Create root location type
Create child location type of the root location type
Create root location
Create child location of the root location

Expected Behavior
Child Location's slug auto generated using the parent location's slug

Observed Behavior
Child Location's slug auto generated using the parent location's UUID

Appears to have been introduced by #2322. Any fix needs to be careful to not re-introduce #2311.


Company Page - get Custom Field empty tag , and show on Custom Field Menu

when user is on Company Profile,
show icon to bring attention on Custom Field required
Initiated by @vinpahilwani
Verified by @mitulpanch

https://www.berrycast.com/conversations/a35b7614-ff8d-5233-bc4c-dd92aca96f98


Package source asks for login

Trying to follow the steps on this page but the package source asks for login info. Can public access this source?
I'm basically trying to create a client to use in a Xamarin project. We cannot use web chat as we have a lot of customization and functionalities on top of the chat view. Am I on the right track?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c463a003-c709-b516-ce1b-6c45537de3b2
Version Independent ID: 8ca42668-23ac-6dca-054d-d183b0fb5b0b
Content: Create .NET client to connect to direct line app service extension - Bot Service
Content Source: articles/bot-service-channel-directline-extension-net-client.md
Service: bot-service
GitHub Login: @Kaiqb
Microsoft Alias: kamrani

@Cage-e The feed is now public. There were a few packages that got merged into the main SDK and the whole experimental feed was mistakenly closed instead of just a few packages.


First Commit

December 2024 Student Submission
Module Completed

[x] Module 1: Instruction Tuning
[ ] Module 2: Preference Alignment
[ ] Module 3: Parameter-efficient Fine-tuning
[ ] Module 4: Evaluation
[ ] Module 5: Vision-language Models
[ ] Module 6: Synthetic Datasets
[ ] Module 7: Inference
[ ] Module 8: Deployment

Changes Made
Describe what you've done in this PR:

What concepts did you learn?
What changes or additions did you make?
Any challenges you faced?

Notebooks Added/Modified
List any notebooks you've added or modified:

[x] Added new example in module_name/student_examples/my_example.ipynb
[ ] Modified existing notebook with additional examples
[x] Added documentation or comments

Checklist

[x] I have read the module materials
[x] My code runs without errors
[x] I have pushed models and datasets to the huggingface hub
[x] My PR is based on the december-2024 branch

Questions or Discussion Points
Add any questions you have or points you'd like to discuss:
1.
2.
Additional Notes
Any other information that might be helpful for reviewers:

Hi @Bipul70701
Now, I have reviewed your notebook. Well done!
The model is also uploaded to Huggingface.
@burtenshaw Could you please merge?

Nice work on reviewing @alishakiba
And great submission @Bipul70701
Feel free to join us on Discord if you want to discuss
We have a discord channel: https://discord.com/channels/879548962464493619/1313889336907010110
HF invite link: https://discord.gg/hugging-face-879548962464493619


Update voluputous

Bump voluptuous to 0.11.1
[0.11.0]
Changes:

#293: Support Python 3.6.
#294: Drop support for Python 2.6, 3.1 and 3.2.
#318: Allow to use nested schema and allow any validator to be compiled.
#324:
Default values MUST now pass validation just as any regular value. This is a backward incompatible change if a schema uses default values that don't pass validation against the specified schema.
#328:
Modify __lt__ in Marker class to allow comparison with non Marker objects, such as str and int.

New:

#307: Add description field to Marker instances.
#311: Add Schema.infer method for basic schema inference.
#314: Add SomeOf validator.

Fixes:

#279:
Treat Python 2 old-style classes like types when validating.
#280: Make
IsDir(), IsFile() and PathExists() consistent between different Python versions.
#290: Use absolute imports to avoid import conflicts.
#291: Fix Coerce validator to catch decimal.InvalidOperation.
#298: Make Schema([]) usage consistent with Schema({}).
#303: Allow partial validation when using validate decorator.
#316: Make Schema.__eq__ deterministic.
#319: Replace implementation of Maybe(s) with Any(None, s) to allow it to be compiled.

We must be careful with Default values MUST now pass validation just as any regular value. This could break any platform, and if not a built-in platform then any custom component.

I know. Was waiting for Travis to tell me what needs work. We should rip this bandaid off 👍

I like this new feature but it have also break some stuff on hass.io :)

I did a first pass looking for all the vol.Optional('', default=None) and found a bunch.
Next up I'm going to modify voluptuous locally to validate default while constructing schemas, load every file and find final defaults that are wrong.

To patch voluptuous, add this to the end of the Schema constructor:
        if not isinstance(schema, dict):
            return

        for key, value in schema.items():
            if not hasattr(key, 'default'):
                continue

            value(key.default)

Making tons of progress. Just the tests left.
Found a voluptuous 0.11 incompatible schema in one of our dependencies using voluptuous: https://github.com/armills/aioautomatic/pull/4

Done 🎉


[INTEL oneDNN] Refactoring: rename and enhance IsMKLEnabled Method

Rename IsMKLEnabled() (C++ API) to IsOneDNNEnabled() as "MKL DNN" has been replaced by "OneDNN".

Enhancement IsOneDNNEnabled() implementation: Remove the use of environment variable TF_DISABLE_MKL as it has been replaced by TF_ENABLE_ONEDNN_OPTS.

@qqfish Hi, merge conflicts should have been addressed. Please help review. Thanks!

@penpornk I noticed quite a few check failures and did not see any specific error caused by this PR change. Please help re-run the tests, or point out the specific errors which I need to take care of. Thanks!

@gzmkl Sorry for the delay! Could you please help resolve the conflicts?

@penpornk , any comments on this PR?

@penpornk , can you re-run the test?

Just resolved another merge conflict...

Hi @gzmkl Can you please review this PR ? Thank you!

Addressed merge conflict related to Penporn's recent PR

Hi @penpornk Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

Hi @ezhulenev Can you please review this PR ? Thank you!

@penpornk @ezhulenev  Please hold on reviewing this PR. Due to a lot of merge conflicts, I am working on a new PR which is based on the latest master (with oneDNN 3.x fully integrated, all conflicts will be gone).
Thanks

Hi @gzmkl Any update on this CL? Please. Thank you!

Hi @gzmkl Any update on this PR? Please. Thank you!

Hi @gzmkl Any update on this PR? Please. Thank you!

Hi @gzmkl Any update on this PR? Please. Thank you!

Hi @gzmkl I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen. Thank you for your contribution!


Fix scrolling not working on iframe in preview mode

Fixes #22799
Fix bug : Scrolling an iFrame not working in preview mode.
Test Plan:

DnD an iFrame onto Canvas.
Make sure iFrame is scrollable.
Switch to preview mode.
Ensure iFrame is scrollable.
Deploy the app.
Ensure the iFrame is scrollable in deployed mode as well.

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/build-deploy-preview env=release

/ok-to-test sha=7d1720b

Tested this PR and LGTM


Release Google.Ads.AdManager.V1 version 1.0.0-beta01

Changes in this release:
Initial release.
PiperOrigin-RevId: 681864022

Created release for Google.Ads.AdManager.V1-1.0.0-beta01


Create presentation slides for D1

I started a Google Slides presentation called comp3004-d1_crema_presentation in the Google Drive folder.

[ ] Write about the app's use cases. (we'll talk about these in the presentation)
[ ] Write about the app's functional requirements. (we'll talk about these in the presentation)
[ ] Write about the app's non-functional requirements. (we'll talk about these in the presentation)
[x] Insert the app mockups.
[x] Make the slides look nice.

Google Drive link: https://docs.google.com/presentation/d/1-r30M6oX1mftwHXZEouyjq3S1yaEBWIU1kwqUaWNFrM/edit#slide=id.g173feb9b67_0_34


add cranelift-module interface for accessing trap information

Feature
lucetc needs some way of accessing the trap sites for every function it compiles:
https://github.com/bytecodealliance/lucet/blob/23305e5d8e08bed442c244d282b1a0389ed3d822/lucetc/src/output.rs#L69-L89
In the above snippet, the trap site access happens after Module::finish has been called, so we're working with faerie interfaces.
We are trying to port lucetc to use object instead of faerie underneath, mostly so lucetc can start generating PE/COFF objects with ease.  It would reduce risk somewhat to be able to use cranelift-module as a high-level interface, swap between cranelift-object and cranelift-faerie with as few lines of code as possible, and deal with object and faerie themselves as little as possible (probably just to write out the .o file).  Therefore, it would be convenient if this information about traps associated with each function were accessible through cranelift-module interfaces, rather than through lower-level interfaces.
Benefit
Trap information would be more easily accessible prior to module finalization.  Though I don't know of anybody else who needs this kind of information about besides lucetc at this point.
Implementation
This is the tricky bit, because the three in-tree implementations differ substantially in their approach to trap collection:

cranelift-faerie collects essentially (string-name, Vec<TrapSite>) pairs.
cranelift-object collects a mapping of FuncId to Vec<TrapSite>.
cranelift-simplejit ignores traps entirely.

I don't think there is a single method that all three interfaces could easily implement to iterate over (string-name, &Vec<TrapSite>) pairs.  To implement such an interface, cranelift-object would need to have a way to map from FuncId to string-name, and that's awkward to do, given that object itself doesn't deal with symbol names as strings, but as Vec<u8>.
The alternative, iterating over (FuncId, &Vec<TrapSite>) pairs, would require some kind of modification to cranelift-faerie.  We could change cranelift-faerie to map from string-name to FuncId: cranelift-faerie could grow a separate table for storing that mapping, but cranelift-module is already storing that mapping, and requiring cranelift-faerie to store it seems like wasted effort.  Alternatively, the way cranelift-faerie stores its traps could be modified to look more like cranelift-object.
But then maybe the right thing to do is just moving trap collection into cranelift-module itself?  Module::new would then grow a flag for indicating whether trap collection should be done.  Module itself would probably contain a FuncId to Vec<TrapSite> mapping similar to cranelift-object, and then Backend::define_function would receive Option<&mut Vec<TrapSite>> for potentially accumulating traps.
Since cranelift-simplejit doesn't collect traps, it doesn't matter too much what interface gets decided on.
I think I prefer moving trap collection into cranelift-module itself, but modifying cranelift-faerie to make it more like cranelift-object and the implementing some sort of common iterator interface works, too.
Alternatives
The alternative is to keep the status quo, and lucetc would need to write two sets of code for defining certain pieces of information: one that defines those pieces with faerie and another that defines them with object.

Since #1389 define_function gets a TrapSink argument.


Dockerfile: use JDK 8u102 as an image base

Starting from 8u101 we aren't need to explicitly import the certificate anymore.
Close #37.

Approved!


error on delete from admin

Hello,
I am using 0.4.4 version and I got the error
Exception Value: 'RowResult' object has no attribute 'object_id'
Exception Location:     /usr/local/lib/python2.7/site-packages/import_export/admin.py in process_import, line 178

while I am trying to delete some record using your import function.
I think it is because your code try to log a delete action of an object just deleted. At the row 178 there is
object_id=row.object

I have resolved it adding at the row 174
and row.import_type != row.IMPORT_TYPE_DELETE:

I know it do not log the delete action in the admin panel, but never mind.
Thank you for your work and best regards
Simone

Thanks  for reporting. This should be fixed - please reopen if you still experience difficulties

That's all right!
Thank you
Simone

Hello,
I'm using the 1.2 version and found the same problem. To correct this we added back:
row_result.object_id = instance.pk
row_result.object_repr = force_text(instance)

in the line 512, 513

I made a PR (#1101) with a fix for this problem, that can log the deleted instance correctly, for version 2.0.2

I can confirm that @msart fix works, had the exact same problem in 2.6.1.

I can reproduce as follows

start example app
import books1.csv
import books2.csv (this marks the book for delete)

books1.csv
books2.csv

A fix for this issue is now in main branch and will go into release 2.7.0


Bump version, fix compability issues

Here's what I've done:

Bumped the version number
Updated dependencies
Fixed compability issues

// Spamix

Just tested live on a rp2040 board, works perfectly!

Hello!
Any idea when this will get merged? If it's in a couple of days then I'll just wait with development but if it's longer than that I'll probably have to reference my git repo in my Cargo.toml.
By the way thanks for this crate, it's amazing :-)

I merged it but i'm unable to publish a new version yet (my computer is still in a box).

I merged it but i'm unable to publish a new version yet (my computer is still in a box).

Haha okay! Thanks for merging, very appreciated!
Have a great evening/whatever time it is for you :-)
I'll get back to watching Eurovision now so if you need to reach me please ping me directly!


Constant definition error

Note: for support questions, please use stackoverflow or irc. This
repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, see note
at the top of this template.

What is the current behavior?
importing nimgl throws this during compilation:

C:\...\.nimble\pkgs\nimgl-0.3.6\nimgl\opengl.nim(69, 39) Error: -1 can't be converted to uint64

If the current behavior is a bug, please provide the steps to reproduce and
if possible a minimal demo of the problem
Just importing nimgl creates the error

Please tell us about your environment:

Version: [ nimgl 0.3.6 | Nim 1.0.99 [Windows: amd64] ]
OS: [ Windows ]
Bindings: [ GLFW ]
Backend: [ C ]

requires "nimgl >= 1.0.0"

Backstory here.

But I did promise to give support to 0.3 so I will be fixing this issue shortly.


Simplify handling of no sending

We had two paths that handled not sending a transmit at all.  This meant the 2nd path was never triggered.  This instead removes the early-returns making it easier to reason about the paths taken.  Now only an error is logged if there was nothing sent.

spellcheck error is in upstream branch. ignoring it here


You shoudl probably remove afterpage as well.

yep, thanks!


pants: 1.3.0 -> 1.4.0

Motivation for this change
Upgrading to what was the latest release of pants. Note in meantime see that 1.5.0 was just released a couple days ago, but want to go one release at a time here.
Things done
Tested via running "nix-build -A pkgs.pants" on macOS (10.13.3)

@GrahamCOfBorg build pants


Question: How to pass a vector to a MoveCallRequest ?

I have a contract object with a function that takes these parameters:
"parameters": [
{
"MutableReference": {
"Struct": {
"address": "0xe1efa6f2268145b2ce7865cedaeec0b2906d228093994e9bdc6ff49cc69c9e26",
"module": "broker",
"name": "Broker",
"typeArguments": []
}
}
},
{
"Struct": {
"address": "0x1",
"module": "string",
"name": "String",
"typeArguments": []
}
},
{
"Vector": "U64"
},
{
"Vector": "U64"
},
"U64"
],
but I don't know how to pass my vector of u64 integers to the MoveCallRequest  "Arguments" .
I expected to need to call some kind of 'pure()' function but couldn't find any.
The error I currently get is :
{"code":-32000,"message":"Bcs field in object [0xf369656fcdb3ba357eebab4331fc021f969f63f23a0abde7f393762a9fcc1cfd] is missing or not a package."}

Figured it out.


Simpler way to generate static files (webpack feels a bit over the top)

Moved this into django-filingcabinet.


Upgrading from 0.3.0 to 0.4.0 service source failure

After upgrading from 0.3.0  to 0.4.0 the service source is no longer working.
- --provider=aws
- --policy=upsert-only
- --registry=txt
- --txt-owner-id=sstarcher
- --fqdn-template={{  .Name }}-sstarcher.dns.com
- --log-format=text
- --source=service

I also tried dropping the txt owners
        - --provider=aws
        - --policy=upsert-only
        - --fqdn-template={{  .Name }}-sstarcher.dns.com
        - --log-format=text
        - --source=service
        - --debug

time="2017-07-27T19:11:49Z" level=info msg="config: &{Master: KubeConfig: Sources:[service] Namespace: FQDNTemplate:{{  .Name }}-sstarcher.dns.com Compatibility: Provider:aws GoogleProject: DomainFilter:[] AzureConfigFile:/etc/kubernetes/azure.json AzureResourceGroup: Policy:upsert-only Registry:txt TXTOwnerID:default TXTPrefix: Interval:1m0s Once:false DryRun:false LogFormat:text MetricsAddress::7979 Debug:true}"
time="2017-07-27T19:11:49Z" level=info msg="Connected to cluster at https://<IP_ADDRESS>:443"
time="2017-07-27T19:11:51Z" level=info msg="All records are already up to date"
time="2017-07-27T19:12:53Z" level=info msg="All records are already up to date"

If I edit the deployment and change it back to 0.3.0
time="2017-07-27T19:14:46Z" level=info msg="config: &{Master: KubeConfig: Sources:[service] Namespace: FqdnTemplate:{{  .Name }}-sstarcher.dns.com Compatibility: Provider:aws GoogleProject: DomainFilter: Policy:upsert-only Registry:txt TXTOwnerID:default TXTPrefix: Interval:1m0s Once:false DryRun:false LogFormat:text MetricsAddress::7979 Debug:true}"
time="2017-07-27T19:14:46Z" level=info msg="Connected to cluster at https://<IP_ADDRESS>:443"
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service default/kubernetes"
time="2017-07-27T19:14:49Z" level=debug msg="Endpoints generated from service: XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="Endpoints generated from service: XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="Endpoints generated from service: XXXX
time="2017-07-27T19:14:49Z" level=debug msg="Endpoints generated from service: XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="Endpoints generated from service: XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=debug msg="No endpoints could be generated from service XXXX
time="2017-07-27T19:14:49Z" level=info msg="Changing records: CREATE {
  Action: "CREATE",
  ResourceRecordSet: {
    AliasTarget: {

@sstarcher Confirmed. We're looking into it.

@sstarcher We found the issue. Patch will be available soon.

Let me know when a release is out and I'll test it out.

It's released. Please try it out: docker pull registry.opensource.zalan.do/teapot/external-dns:v0.4.1

verified

Thanks for letting us @sstarcher.
We messed up the order of the parameters to the contructors. Here's the fix: https://github.com/kubernetes-incubator/external-dns/pull/298/files


SAMZA-2465: Task inputs information lost when enabled RegExTopicGenerator  or specified 'task.inputs' explicitly in non-legacy application

Symptom
If the user’s non-legacy application enabled RegExTopicGenerator or specified task.inputs explicitly and specified the input streams in its application descriptor, the expectation from the user side should be that the application can consume messages from specified input streams and Kafka topics that matched specified regex patterns.
However, in current logic seems the input information from the application descriptor will be overrided by the information from RegExTopicGenerator or task.inputs in the config file, which means the user’s application can only consume from matched Kafka topics or the inputs specified in task.inputs.
Cause
The generated task inputs from the application descriptor are overrided by JobNodeConfigurationGenerator.mergeConfig function.
Changes
Merge generated inputs and original inputs before doing JobNodeConfigurationGenerator.mergeConfig function call.
Tests

[x] All unit tests and integration tests are passed

API Changes
None
Upgrade Instructions
None
Usage Instructions
Noe

@bkonold can you take a look at this PR?

It is my understanding that we override generated configs to allow for job deployment to be reconfigured without building a new binary of the job. This is useful, for example, when managing issues in production and a job needs to be quickly reconfigured; the job's configuration can be modified and the job redeployed with the same binary vs needing to touch the job's app descriptor and building a new version of the binary.
For that reason it seems contradictory to merge values for the same key between original and generated config...
A bit more generally begs the question of how we treat precedence between original config, rewritten config, and generated configs (from app descriptor). @kw2542 Since you are working on the deployment flow, can you comment on what the touch points are in the system currently for rewriting configs? Do we have a clear picture of what this precedence is now?

".... input information from the application descriptor will be overrided by the information from RegExTopicGenerator or task.inputs...."
Isnt this desired behavior ?
If a user provides conflicting values for inputs in the two places, we resolve the conflict in favor of the one in the config.

".... input information from the application descriptor will be overrided by the information from RegExTopicGenerator or task.inputs...."
Isnt this desired behavior ?
If a user provides conflicting values for inputs in the two places, we resolve the conflict in favor of the one in the config.
I'm not sure why this is problematic.

+1; This PR negates - https://github.com/apache/samza/pull/1065

Clarify the issue here:
If the user’s non-legacy application enabled RegExTopicGenerator and specified the input streams in its application descriptor, the expectation from the user side should be the application that can consume messages from specified input streams and Kafka topics that matched specified regex pattern. However, in current logic seems the input information from the application descriptor will be overdried by the information from RegExTopicGenerator, which means the user’s application can only consume from matched Kafka topics.


Option to edit inline element (such as a header)?

Hello there!
First, let me say that this is an amazing project. It is the nicest solution to the WYSIWYG-problem I've seen thus far. Although, of course, some things are still missing or behave oddly.
From the docs:

A common misunderstanding when marking up editable HTML is to mark up a single element as editable, for example:

Content

This wont work as a region has to contain editable block level elements. A simple way around this is to wrap the h1 tag like so:

Content

In my project, I want to give users the ability to edit some elements without allowing them to create new block elements above/below it, and without changing the overall style of this element. An example would be the header (h1) of their page:

I want them to be able to use bold/italics/underlines in there, as well as colours.
I do not want them to be able to change the h1 to a h2, h3 or p tag.
I do not want them to be able to use the return key to start new block elements below the h1.
I do not want them to be able to insert lists/tables/images in there.

Is it possible to change the options to support this behaviour right now?

Hi @Qqwy, thank you for your kind comments. Support for making greater control over editable regions/elements (such as a H1) and for limiting the tools that can be used when editing these has been raised in a number of existing issues:

https://github.com/GetmeUK/ContentTools/issues/79
https://github.com/GetmeUK/ContentTools/issues/118
https://github.com/GetmeUK/ContentTools/issues/130

It's something that our clients (getme) would like to have in place to so support is planned, but as per your question no there is no support currently and work creative arounds must be implemented.


fix: environ setting for azure openai

Thanks for the great open source work! I was building a tool similar to this on my own, and recently I found out this repo. 🙂
I'm an azure openai user, so when I tried using it, I had to use AZURE_OPENAI_API_KEY, but the docs didn't seem to have been updated yet, so I updated the readme.
related code :
https://github.com/TonicAI/tonic_validate/blob/main/tonic_validate/services/openai_service.py#L41

This LGTM! Thanks for catching this bug for us! Not sure, why the tests aren't running correctly, but it's not related to your PR obviously!


Lab1/Part2_debiasing_solution.ipynb fails with TypeError

When executing  "encoder_output = encoder(inputs)" (search for exact phrase), it fails with a type error:
TypeError: Failed to convert object of type <type 'tuple'> to Tensor. Contents: (Dimension(None), Dimension(100)). Consider casting elements to a supported type.
I'm using colab and following the recommended solution.
I propose
"epsilon = tf.random_normal(shape=(batch, dim))" be replaced with
"epsilon = tf.random_normal(shape=tf.shape(z_mean))"
I followed the remainder of the lab and got something that made sense.

I had the same problem, and replacing (batch, dim) with tf.shape(z_mean) solved it, thanks for sharing.
You should create a new pull request.


#box() between lines breaks justification

Description
Either the space before the box appears at end of line or space (or newline) after box appears at the next line. As it is, I have to remove all space before and after the box. But it doesn't create any output, so it shouldn't break the justification.
#set par(justify: true)

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do
eiusmod tempor incididunt ut labore et dolore magnam aliquam quaerat
voluptatem. Ut enim aeque doleamus animo, cum corpore dolemus, #box()fieri
tamen permagna accessio potest, si aliquod aeternum et infinitum
impendere malum nobis opinemur. Quod idem licet transferre in
voluptatem, ut.

Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

This is working as intended. If you have a box, then the space before it does not collapse. Special-casing empty boxes feels rather ad-hoc to me. Might I ask why you create an empty box in the first place?

In reality I create a box with an annotation that must not effect the real text flow. How else can I do this?

What kind of annotation? What's inside the box?

Just some superscripted text. But it doesn't matter, an empty box is enough to break the justification.

It matters because I'm trying to understand your use case and why there is an empty box in the first place.
I'm not convinced that special casing empty boxes would be consistent. What if the box is empty, but stroked? Does the space still collapse?

What is stroked?
#box(width:0pt, stroke:1pt, super("annotation"))?
Just the same. Space does not collapse, but it should.
Btw: Why does the space collapse when I add a ")"?: dolemus, #box())fieri
The ")" is in the next line, and the justification is not broken Why?

What is stroked?

I mean something like this #box(width: 0pt, height: 6pt, stroke: 1pt). It is clearly visible, so it would be weird if the space collapsed.

Btw: Why does the space collapse when I add a ")"?: dolemus, #box())fieri
The ")" is in the next line, and the justification is not broken Why?

The box is moved to the next line because there is no line break opportunity between it and the parenthesis.

I mean something like this #box(width: 0pt, height: 6pt, stroke: 1pt). It is clearly visible, so it would be weird if the space collapsed.

No it's not visible, and if the line is broken, the space should disappear from the end of the line anyway.

Have you actually tested this? It is visible if you provide a height. But anyway, there seems to be no point in further discussion as your position seems settled.

Have you actually tested this?

Yes. Have you?

A zero-width box and all space before it is kept at the end of line, despite being invisible. This breaks justification. Is that what is intended?

Yes. Have you?

Yes. Turns out that the rendering differs between PNG export (= web app) and PDF export... but this is already tracked in https://github.com/typst/typst/issues/2155.

A zero-width box and all space before it is kept at the end of line, despite being invisible. This breaks justification. Is that what is intended?

The fact that it is invisible is, in my opinion, secondary. Spaces around boxes just don't collapse and carving out a special case for invisible or zero-width boxes will open up a can of worms. For instance, the next question is whether A #box(width: 0pt) B has one or two spaces etc. I think I get your use case (inserting content without it having any width), but I think adding special cases to how boxes work is not the solution.

The only special case would be the 0pt box to be handled as white space.
Can I inhibit the line break after a #box() manually? -- Something like TeX's \penalty?
Is there a better way to insert an annotation? Or anything else (side note etc.)? All of these will have the same problem when using #box.

You can inhibit the linebreak with a non-breaking space (~) or zero width joiner (#sym.zwj).
As for better ways to insert an annotation: Depends on what exactly you're trying to achieve. You could trying removing the space before the box automatically with h(0pt, weak: true), similar to how footnotes eat the space before them.

I don't want to remove the space, I just want it to have no effect at all ...
Yes, appending #sym.zwj; to the box seems to work (for now)


Sections and pages

Revised how documentation is organized into sections. Folders are created for sections (pages that have subpages). Pages are added as markdown files under sections. Updated the contributing guide to clearly describe this.

Related issue :

Although files are in the correct structure for Hugo and everything renders correctly, all links function correctly, the linter does not understand how Hugo works with relative links from subpages. Restoring old folder structure.

Closing this as it cannot achieve its goal. The imposed linter does not understand how Hugo interprets links in markdown pages.


Investigate "https://github.com/ant-research/ace-compiler/"

ANT-ACE is a Fully Homomorphic Encryption (FHE) Compiler Framework designed for automating Neural Network (NN) Inference. ANT-ACE accepts a pre-trained ONNX model as input and directly generates C/C++ programs to perform NN inference on encrypted data.

Interesting! It looks like they partially re-invented the Multi-Level-IR wheel for this:

(This is written from scratch in C++ as far as I can see, no LLVM/MLIR in sight)


Eager validation not working as expected

Environment

Operating System: Darwin
Node Version:     v20.11.1
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>
Version
v2.15.1
Reproduction
https://ui.nuxt.com/components/form-group#eager-validation
Description
Hi there, loving the form component with Zod validation so far. However, I believe the eager-validation prop isn't working as expected (see docs). Am I wrong for assuming that the field should be validated immediately (before blur)? This is not the case in the docs or in my project, unfortunately. Would greatly appreciate this fix, thank you!
Additional context
No response
Logs
No response

Yes, using eager-validation will validate the input directly and won't wait for an initial blur. That's the behaviour I'm seeing in the documentation too:
https://github.com/nuxt/ui/assets/25613751/5239ce1e-b835-47df-a0e2-c1dae37d68c7
Would you mind sharing a reproduction of your project's form using stackblitz so I can have a look?

My apologies, I assumed eager validation meant the form would validate onMount, not just onChange. Given that this is my desired UX, I guess I can validate the form onMount using Zod and push the errors to the form to show immediate warnings?

You should also be able to attach a ref to your UForm, and use one of the methods exposed on it. See API reference

You can use the validate method to achieve this on mount.


⚠ ClamAV has degraded performance

In b9bffee, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 79 ms

Resolved: ClamAV performance has improved in 3095ba2.


Trigger automated checks to keep python-podman aligned with libpod defined interfaces

Summarize
In the sake of compatibilty in libpod and python-podman I propose to design and implement automated checks to verify if python-podman implementation is fully compatible with libpod varlink defined interface.
The goal of this ticket is to discuss about this feature design and watch how we could implement this and the needs behind this (impact on project workflow, how to proceed etc...).
Draft design
Project lifecycle
I think we need to create a git branch dedicated for each libpod version that we want to maintain to avoid to introduce future features into wrong branches and python-podman releases, in other word we need to isolate development versions.
The master branch will only reflect the libpod master and will help us to synchronize changes between future latest versions only.
I think we need as many version of python-podman than existing libpod versions to keep the python-api compatible with libpod defined interface.
Triggering automated checks
The automated check can be trigger from:

the libpod side when changes are pushed on https://github.com/containers/libpod/blob/master/cmd/podman/varlink/io.podman.varlink
the python-podman side daily by triggering cronjob on each opened branches

The automated check need to reflect the relation between version on the both projects, we only need to compare the varlink defined interface in the right libpod tag version and on the right development branch version on python-podman.
If we choose to trigger automated checks on python-podman then we need to pull from the right libpod tag/branch the raw varlink defined interface file (by using http request) and then compare it the python-podman implementation.
How to compare interface with implementation
For the moment I see some solutions to compare if these projects are synchronized, lets describe them.
Maybe you will see other/better solutions to manage this.
Don't forget that the main goal of this issue is to discuss with you if we can do this and how to do this before starting to spend time on it. Also I want to raise pro and con that I may miss.
First solution
The main idea in this solution is to compare function signatures.
Steps needed in order:

download the raw interface description form libpod repo
parse the previous download file to extract defined signature
parse the function implementation available in python-podman
compare the both and observe if delta exists
raise error if delta exist
automatically open a new github python-podman issue with attached job output to inform us and then fix the issue

The main difficulty here is how to ignore perifical function which are part of the python-podman mechanisms and not related to interface implementation... Since python-podman is only compatible with python3 we could by example use the powerful python inspect module coupled with a standardized mechanism which will allow us to analyze keywords in functions's docstrings to detect if the function is part of the interface definition, determine which interface the implementation is linked and if signature need to be compared with interface definition.
All these things can be done in pure python without extra module and dependencies (or just to some mainstream requirements).
We don't need to compile and install libpod here, we just need to refer to the related interface.
I think this one is the more preferable solution and the more safer and the less painful.
Second solution
On travis's instance compile and install the right libpod version and then start its varlink server, and then run unit tests against but I think it's more likely that libpod's varlink defined interface will be ahead of the python-podman implementation. In this case it can be difficult to witness raised exceptions from the python-podman side because the python-podman would not pass undefined params (except if some params are removed from libpod and not yet removed from python-podman).
Maybe I'm wrong by thinking this way, I'm not sure if all params are mandatory and if exceptions can be raised by doing this. If exception are raised then it's can be a way to identify non synchonized interface implemention in python-podman.
My main concern about this solution is how to properly manage travis instance, libpod rights (sudo etc...), rootless needs, etc... on a travis's instance image which could have some limitations. I think it can be painful to follow this way and our goal is not to test libpod but just to observe if implementation is rightly synchronized, I don't want to fight with windmills here.
Third solution
By adding new capabilities to the varlink's mocking feature it will allow us to generate a fake service by lookup form the downloaded raw interface to generate some fake python classes (rather than generating fake interface definition from fake python class as is currently the case).
Then we can mix solution 1 and solution 2 approachs (if enough unit test exists for solution 2), and by example compare generated function's signatures and real implementation signatures.
Like has explained in the second solution I'm not sure if 100 percent of the args are mandatories and if some are missing I'm not sure we will catch exception and error. Anyway with this approach libpod stay ahead of the python-podman implementation so this is the main risk.
This is a cross project solution which ask to us to adding new feature on the varlink side and in a second time to implement the check on python-podman.
The main advantage here is to provide feature which can be reused outside of the scope podman (the feature added to varlink).
Conclusion
I think we need this kind of feature to avoid to spend time fix issue unsynchronized implementation.
Also I think these changes can help us to better handle the support of libpod's versions on python-podman and to more often and more merely release new versions of this API.
Do not hesitate to react to my proposal by sending comments here.
Possibly related to

#69
#64
#14
#15

A quick-and-dirty option would just be to pull out all the method names from the varlink schema and run an identifier search over the python source (especially libs).
If the identifier doesn't appear, you have pretty high confidence the feature isn't implemented. (Since afaik you're not doing dynamic things.)
If it does appear, you can be mildly certain it is implemented.
You could probably hack an initial version with a regex and a pile of greps. Unless you have a varlink schema library lying around.

I think we should have a discussion on these features.  I love seeing python-podman further develop.
We need to coordinate with the APIv2 work that is going on in Podman.
https://github.com/containers/libpod/tree/apiv2
The bottom line we are moving away from varlink to a similar Protocol to the Docker.API.

A quick-and-dirty option would just be to pull out all the method names from the varlink schema and run an identifier search over the python source (especially libs).
If the identifier doesn't appear, you have pretty high confidence the feature isn't implemented. (Since afaik you're not doing dynamic things.)
If it does appear, you can be mildly certain it is implemented.
You could probably hack an initial version with a regex and a pile of greps. Unless you have a varlink schema library lying around.

Yep I agree it can be a first version quickly released, however, we still don't check if defined and implemented signatures and we risk to face this kind of issue #64, so we need to move further in a second time to cover this part too.

I think we should have a discussion on these features. I love seeing python-podman further develop.
We need to coordinate with the APIv2 work that is going on in Podman.
https://github.com/containers/libpod/tree/apiv2
The bottom line we are moving away from varlink to a similar Protocol to the Docker.API.

Thanks Daniel for the heads up, I will take a look to the APIv2 to avoid to spend time on something who will be deprecated in the next releases.

See my proposed changes #71


Support to navigate from an issue query to its definition in the settings.

Provide an action in the Issues view that opens the corresponding query definition in the settings.

To verify:
Install the nightly build of the extension
Open the Issues view
Click on the tools icon next to a query title and verify that it opens your settings at that query.


Change the response structure

In this PR I changed the response structure for the getCompanyPayments function so if the result is success I only get the payments array instead all the object ({ success: true, payments: [...]}),

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Console error: Uncaught (in promise) You may not create directories in this location

Players get the following error in the console. (players in my world dont have permission to upload)
game:1 Uncaught (in promise) You may not create directories in this location
Promise.then (async)
(anonymous) @ chat-images.js:14
_call @ foundry.js:294
callAll @ foundry.js:253
initialize @ foundry.js:5403
🎁call_wrapped @ libWrapper-wrapper.js:510
🎁libWrapperInit @ libWrapper-api.js:778
await in 🎁libWrapperInit (async)
🎁Game.prototype.initialize#0 @ libWrapper-wrapper.js:186
window.addEventListener.once @ foundry.js:62282

Fixed with release 2.5.6


Add node.js binding for activations

I have verified that related webnn-polyfill tests can pass through node.js binding. PTAL, thanks! @fujunwei

Much thanks for @fujunwei 's help, we have fixed the clamp related issue. I updated the commit id in DEPS for webnn-samples and webnn-polyfill to the latest. PTAL, thanks! @huningxin @fujunwei


Fix issue with MIND large and small

Description

Fixing https://github.com/recommenders-team/recommenders/issues/2147#issuecomment-2308615469
Related Issues

References

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] I have signed the commits, e.g. git commit -s -m "your commit message".
[ ] This PR is being made to staging branch AND NOT TO main branch.

Also checking the nightly builds: https://github.com/recommenders-team/recommenders/actions/runs/10556674705

All green @SimonYansenZhao @anargyri @daviddavo


Presentation: Remove dataProvider prop from usePresentationTreeNodeLoader

dataProvider was included in usePresentationTreeNodeLoader props for testing purposes, but this increases the hook's complexity and adds a possibility for the prop to be misused. Since there is a good alternative that still allows testing this hook fully without requiring @internal props, there should be no reason to keep and maintain that extra complexity.
This change uses sinon.stub to define PresentationTreeDataProvider behavior during tests, and removes internal dataProvider props from a number of components.
When switching to using sinon stubs, I encountered the following error: TypeError: Cannot stub non-existent property getFilteredNodePaths. The error occurred due to getFilteredNodePaths being assigned during object's construction rather being defined in the class prototype. Defining this member as a regular function has fixed this error.
The error I encountered above should be enough reason to avoid using this pattern of initializing class methods as variables, because this prevents them from being stubbed in tests.

A bunch of line ending changes have made their way into the commits. I'll remake them and do a force-push.

This was a breaking change that should have been documented imo.
I know it's internal so we probably shouldn't have been using it.
See https://github.com/imodeljs/viewer-components-react/blob/master/packages/tree-widget/src/components/trees/TreeWithRuleset.tsx

This was a breaking change that should have been documented imo.
I know it's internal so we probably shouldn't have been using it.
See https://github.com/imodeljs/viewer-components-react/blob/master/packages/tree-widget/src/components/trees/TreeWithRuleset.tsx

I do not agree - @internal clearly states that you shouldn't be using it and I'd like to think that we can break internal APIs anytime. In addition, internal APIs aren't documented to ensure they're not visible to the outside consumers (sadly they're not stripped from declarations), so I believe there's no need to document breaking changes of something that shouldn't be used by anyone in the first place.
Looking at the linked source file, I don't see why it needs a data provider - can you point us to a place where this TreeWithRuleset component is used? Thanks.

Looking at the linked source file, I don't see why it needs a data provider - can you point us to a place where this TreeWithRuleset component is used? Thanks.

I believe this is used in the classification tree used by DR in the building-ui-components package. We'll refactor this pkg for 3.0 and will let you know if we run into any issues.


Make DidIonResolver tests work if network is unavailable

DidIonResolver depends on calling an external API endpoint. When the network is not available, these tests fail.
There was some code around stubbing fetch but this failed for Browser tests with the following error:
Can only call Window.fetch on instances of Window.

No longer applicable.


fix: removed core-js from dependencies

Hi, I've made this PR in relation to the issue regarding the deep import warning when compiling. I've removed the core-js package completely and used the Object.assign function instead because it was the only usage that i have found in the code. I don't know if there can be other use cases in wich the package is required. Let me know if this can be a valid fix.


I.waitForNavigation method in the container does not work. Puppeteer.

The test run stops when the script reaches a call to the waitForNavigation method in the PageObject class. But the call to this method proceeds normally when called in a test. I tried different values in the waitForNavigation key config (load, domcontentloaded, networkidle2).
For example:
    Emitted | step.passed (I fill field "#login", "Admin")
    Emitted | step.finish (I fill field "#login", "Admin")
    Emitted | step.start (I fill field "#password", "123456")
    I fill field "#password", "123456"
    Emitted | step.passed (I fill field "#password", "123456")
    Emitted | step.finish (I fill field "#password", "123456")
    Emitted | step.start (I click "Войти")
    I click "Войти"
    Emitted | step.passed (I click "Войти")
    Emitted | step.finish (I click "Войти")
    Emitted | step.start (I wait for navigation )
    mainNavFragment: validate
      I wait for navigation
      › [Browser:Error] Failed to load resource: the server responded with a status of 422 (Unprocessable entity)
      › [Browser:Error] JSHandle@objectJSHandle@object

These are screenshots. Here the method call occurs first in the test, then in the pageobject and stops:

Details

CodeceptJS version: 2.1.0 (https://hub.docker.com/r/codeception/codeceptjs)
Configuration file:

exports.config = {
    tests: './tests/frontend/*.js',
    output: './tests/_output/puppeteer',
    helpers: {
        Puppeteer: {
            url: 'http://somesite.local',
            waitForNavigation: ['networkidle2', 'domcontentloaded'],
            chrome: {
                args: [
                    '--headless',
                    '--disable-setui-sandbox',
                    '--ignore-certificate-errors',
                    '--ignore-certificate-errors-spki-list',
                    '--allow-insecure-localhost',
                    '--no-sandbox'
                ],
                ignoreHTTPSErrors: true,
            }
        }
    },
    waitForAction: 10000,
    include: {
        I: './tests/_support/PuppeteerTester.js',
        loginPage: './tests/_support/Page/Login.js',
        mainNavFragment: './tests/_support/Page/Fragments/MainNav.js',
    },
    plugins: {
        screenshotOnFail: {
            enabled: true
        }
    },
    bootstrap: null,
    mocha: {},
    timeout: 10000,
    name: 'Testing',
}

Tests look like this:

I apologize, this case works when in the config "waitForNavigation: 'load'".
If in the config "waitForNavigation: 'networkidle2'" then the tests fail even when the waitForNavigation is in the test.


DRY up uncommitted file steps

Closes #455 #463

Nice work @ricmatsui! Looks very good to me! :+1:

Thanks, all comments addressed.

Nice work! :ship: it!


[mathematica] 10.0.2 -> 11.0.1

Motivation for this change
Mathematica 11 was released a while ago. I left a nix expression for version 10.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Could you add a mathematica_10 to top-level?

Updated as requested. I can squash the commits if you'd prefer.

yes please

Commits are now squashed.


Null actions appearing on "click to enable actions"

@davidtsong may have more details
Click enable action
Got a 404 https://github.com/null/actions

nvm i think i will close this. this is probably from trying to use a repo that isnt setup for github actions
On Aug 3, 2020, 6:21 PM -0700, Steven Raden<EMAIL_ADDRESS>wrote:

@davidtsong may have more details
Click enable action
Got a 404 https://github.com/null/actions
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Still something we should handle maybe better? idk if you can get an image of what happened?

can't reproduce dang


Alex1

Environment data
dotnet --info output:
VS Code version:
C# Extension version:
Steps to reproduce
Expected  behavior
Actual behavior

Closing this issue. Please open a new issue and provider all the requested details if you are having problems. Thanks!


Test Only: QA Schema and DTO

The below tickets need to be tested:

[x] QA API DTO Validation Updates #5601

[x] Front End: QA Schema Updates #5587

Initial testing complete. Bugs will be fixed and further testing done


Token from instant-tokens.com

Hi,
Could anyone add instructions on how to include the token from https://www.instant-tokens.com/?
How would the code samples look then?
The heroku app is not working :(

Hi,
They have a wiki page with a codepen example to help you out located here:
https://github.com/codingbadger/instant-tokens.com/wiki/3.-Instafeed.js-Demo
Have fun!

They have a wiki page and codepen example on their website.

Hey @sjabby! You should be able to use the new asynchronous access token feature in V2, to fetch your token dynamically from instant tokens:
var feed = new Instafeed({
  accessToken: function(done) {
    $.ajax({
      url: instantTokenApiUrl,
      dataType: 'json'
    }).done(function(response) {
      if (response.Token) {
        done(null, response.Token);
      } else {
        done(new Error('error: ' + response));
      }
    });
  }
});

@ringerce thanks for chiming in too!


postfiles aren't matched against converters?

eg:
- _posts
  - 2019-06-19-welcome-to-jekyll/
    - 2019-06-19-welcome-to-jekyll.md
    - assets/
      - main.scss

output files:
- _posts
  - 2019-06-19-welcome-to-jekyll/
    - index.html
    - assets/
      - main.scss

the sass file isn't converted to css before being included in the build directory.

see also: jekyll/renderer.rb

The original scope of the plugin was simply to gather images and markdown files in a single page bundle. I don't see the point of adding assets here though.

I suppose your right. just felt like this would be a nice way to group styles you only intend to use on a single page.

Other methods like CSS modules group files and styles, but Jekylll users use Sass, and it's more usual to gather files through @import (or now @use).

I suppose your right. I'll close this issue for now.


Add MessageSpies cop

Add MessageSpies cop for enforcing consistent style of either expect(...).to have_received or expect(...).to receive. This new cop is intended as a replacement for the MessageExpectation cop.
This relates to various issues:

https://github.com/backus/rubocop-rspec/issues/23
https://github.com/backus/rubocop-rspec/pull/169
https://github.com/backus/rubocop-rspec/issues/218
https://github.com/backus/rubocop-rspec/issues/229

See also discussion in https://gitter.im/rubocop-rspec/Lobby
This PR is a work in progress, and we need to discuss:

[x] Add specs (and code?) for different cases of chaining.
[x] Is it OK to change an existing cop, or should this be a new cop?
[x] Changelog
[x] Why is there so little documentation for def_node_matcher and def_node_search :trollface:

cc/ @backus @andyw8

Is it OK to change an existing cop, or should this be a new cop?

I think this should be a new cop and the old cop should be disabled by default

@bquorning I think you need to adapt the node matchers a bit to handle for different chaining cases. For example, we should probably enforce this cop for all of the following
expect(foo).to have_received(bar)
expect(foo).to have_received(bar).with(baz)
expect(foo).to ordered
expect(foo).to have_received(bar).at_most(3).times
# etc

this is approximately what the node pattern and corresponding node search were doing before with
def_node_matcher :message_expectation, <<-PATTERN
  (send $(send nil {:expect :allow} ...) :to #receive_message?)
PATTERN

def_node_search :receive_message?, '(send nil :receive ...)'

Otherwise these changes look good!

I think this should be a new cop

Done.

and the old cop should be disabled by default

That should probably be a separate PR.

I think you need to adapt the node matchers a bit to handle for different chaining cases.

Working on it.

Better now @backus? Will squash commits before merge.

This looks great @bquorning. Thanks for working on this. Feel free to squash and merge

I added a commit using different error messages for the two styles. Please let me know if I should change the text or remove the commit again.

@backus I ended up using all three of your suggestions. I think this is ready for the final review.

Feel free to merge

Before:
before { expect(account).to receive(:errors).and_return(amount_cents: [error]) }

After:
before { expect(account).to have_received(:errors).and_return(amount_cents: [error]) }

Error:
NoMethodError: undefined method `and_return' for #<RSpec::Mocks::Matchers::HaveReceived:0x007fe9ccb409e8>

@backus will do, thanks.