[Rstmgr Change Proposal] Shadow Reset Implementation

To further enhance OpenTitan's shadow register scheme, it was suggested early on during the design (and by security consultation) to augment shadow registers with shadow resets.
The basic idea of shadow resets is that each the normal and shadow copies of a register receive different resets. So if an attack managed to glitch one of the reset lines, the two copies become different and trigger an error condition.
This error condition should then propagate through the module and trigger the alert handler (there is a longer discussion of what happens if the alert sender / handler are also in reset, but that is separately handled through our ping / escalation ping mechanisms and not part of the scope of this issue).
The prototype PR for this mechanism is #7442. In this PR, both aes and alert_handler are augmented with a secondary shadow reset.
PROS

Enhance the shadow reset scheme
Provide better glitch resistance for shadow registers

CONS

Increases DV burden both for common component verification / module specific verification.
It will become necessary to negative test the shadow resets to ensure that a glitch on either reset (normal or shadow) can still allow an alert to propagate through the module.

@cdgori
@moidx
@dsandrs
@domrizz0
@imphil
@rswarbrick
@tomroberts-lowrisc
@GregAC

Hey @tjaychen ,
thanks for creating the issue and the prototype PR. This makes sense.
I think the main open question is how to handle cases where the two resets are not released together as this might trigger a fatal alert:

On the alert handler side things should be okay: software first needs to activate it. However, if things can be reset while the alert handler is running. This might be a problem.
On the module side things are different. According to the alert handler guidance fatal alerts should always trigger local security countermeasures. In most cases, the module will just lock up and wait for reset. So we also need to come up with a way to handle this on the module side.

I think you have this on your list as well but wanted to get the CDC regfile proposal through first. But if you could outline possible ideas for handling this that would be interesting.

So at the moment I am not too worried about the reset assertions.
Our resets are async so under normal circumstances they will pull related logic to the same value immediately.  There is technically STILL a possibility of false positives if the reset occurs RIGHT on the clock sampling edges and look like two different values.  For the software reset case, this is okay since software-caused resets are actually synchronous.  For asynchronous reset sources we'd have to look a bit more closely.  However these async resources are usually wide ranging and impact the entire design.
For the release, my thinking is that even if they are not at the same time, it does not necessarily matter because the two flops are already the same value.  The real issue is if during that one cycle gap someone tries to access the register.  So my idea is that for shadow registers, they would rely on the reg_busy indication (similar to the CDC regfile) to back-pressure any writes directed at them until we are out of the ambiguous reset region.  This should keep the two sides in sync.

@tjaychen Afaik this has been implemented so I think we can close this.

yes sounds good.


[CALCITE-2159] Support dynamic row type in UNNEST (additional changes)

@amansinha100  Can you please review this PR.
This PR includes
a) SqlUnnestOperator row type is made to return $unnest. This change is made because unnest operator returns only one column (either a scalar column/ a map column). Also, $unnest name has no significance it just acts as a place holder. Drill has changes to not allow unnest usage in the query without providing alias column name.
b) Uncollect returns the same name as the input column. This is made just to avoid $unnest static column string name usage in pop config and also record batch code.
c) Tests and the corresponding plans have been changed.
d) Couple of tests were ignored, because one test was failing even without my changes. Other test (i.e testProjectCorrelateTransposeDynamic) is failing because the query plan will now get same plan as before, since the row type is no more dynamic_star. I also want to fix the code projectcorrelate transpose rule independently as this change was causing some other issues in Drill execution code.

Couple of minor comments but mainly I wanted to understand a bit more about the nature of the 2 tests that have been marked ignored.

@amansinha100  Thank you for the review. I have changed the comments to reflect the new changes.
As per the two ignore test changes. One test is related to the changes which chunhui-shi has done to take care of fixing star. The other is related to ProjectCorrelateTranspose rule which I think has not gone to apache calcite.
I think these changes should be re-evaluated with respect to new changes. Hence these were commented.
Here is the result on the latest commit.
[INFO] Reactor Summary:
[INFO]
[INFO] Calcite ............................................ SUCCESS [  6.279 s]
[INFO] Calcite Linq4j ..................................... SUCCESS [ 20.072 s]
[INFO] Calcite Core ....................................... SUCCESS [08:15 min]
[INFO] Calcite Cassandra .................................. SUCCESS [  3.252 s]
[INFO] Calcite Druid ...................................... SUCCESS [  8.120 s]
[INFO] Calcite Elasticsearch .............................. SUCCESS [  9.620 s]
[INFO] Calcite Elasticsearch5 ............................. SUCCESS [  5.125 s]
[INFO] Calcite Examples ................................... SUCCESS [  0.515 s]
[INFO] Calcite Example CSV ................................ SUCCESS [ 15.859 s]
[INFO] Calcite Example Function ........................... SUCCESS [  5.065 s]
[INFO] Calcite File ....................................... SUCCESS [ 10.357 s]
[INFO] Calcite Geode ...................................... SUCCESS [  4.305 s]
[INFO] Calcite MongoDB .................................... SUCCESS [  4.270 s]
[INFO] Calcite Pig ........................................ SUCCESS [ 17.204 s]
[INFO] Calcite Piglet ..................................... SUCCESS [  5.346 s]
[INFO] Calcite Plus ....................................... SUCCESS [ 12.280 s]
[INFO] Calcite Server ..................................... SUCCESS [ 12.258 s]
[INFO] Calcite Spark ...................................... SUCCESS [ 16.520 s]
[INFO] Calcite Splunk ..................................... SUCCESS [  2.831 s]
[INFO] Calcite Ubenchmark ................................. SUCCESS [  4.645 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:00 min
[INFO] Finished at: 2018-05-17T15:20:04-07:00
[INFO] Final Memory: 196M/1504M
[INFO] ------------------------------------------------------------------------

+1


Auto-increment versions in build

One thing I'm going to want to do in the build before we do a public publish is to auto-update the version number in the build process.  The GitVersion build task produces an environment variable $(GitVersion.MajorMinorPatch) that I think we can use to text replace  version="0.0.0" in setup.py.  I'm not sure of the best way to do that with Python commands; however, the worst case is we just do a straight text replacement in the setup.py file in the build process.  I'd like the build system to manage the version numbers and not rely on manually updating setup.py.
Ref: https://gitversion.net/docs/reference/variables
Observed in #28

@DaveSkender Works well!

When I get a moment, I’ll setup the test PyPI and regular PyPI account endpoints.


Documentation about toml script to create commands

We need documentation about how to use these toml script to create commands:

[x] : Explain what can be achieve with it. (command, startup, ...)
[x] : Document the current toml that exists
[ ] : Small internal documentation how it works

https://github.com/g8os/core0/tree/0.12.0/docs/config

@zaibon i don't get what kind of internal documentation you need. can u check the provided link and tell me if u think we can add more.


Inline chat diff incorrect when whole file is selected

Description
Notice how the diff shows the whole file outside the diff but also the whole file in the diff:

(I've filed an issue for this before but can't find it anymore -- I think it was closed as fixed by changing the diff mode to live when the whole file is selected, but I still somehow get this bug)
Screencast:
https://github.com/microsoft/vscode/assets/16353531/113ec882-2b05-488c-b07d-8d6cef6f3b2f
Repro

Select whole file
Trigger inline chat & ask something that will show a diff - 🐞

Version
Version: 1.80.0-insider
Commit: 5b7440441bbd2548a862f7321cafdfa1597132e5
Date: 2023-06-30T21:17:11.593Z
Electron: 22.3.14
ElectronBuildId: 21893604
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

Select whole file

That's the reason for this. The diff ranges are extended by the selection/whole range in order to preserve context. And yeah, not being able to hide everything is tracked in another issues (which is still open)


Add ODS support

ODS support is based on ezodf [1] library.
It looks, that ezodf has a bug [2], where number of sheet rows and cells are
calculated incorrectly. Probably this is the reason, why I get extra rows and
cols in tests.
[1] https://github.com/T0ha/ezodf
[2] https://github.com/T0ha/ezodf/issues/12
It fixes https://github.com/frictionlessdata/tabulator-py/issues/28

@sirex
Thanks!

@sirex
could you please rebase on master after NDJSON merge

@roll, rebased.

@sirex
Thanks!


Implement class structure for SOMA arrays and groups

Overview
As of the initial 'ingest-only' version we have at present, we have a single SOMA class with lots of methods. Those methods should be moved to individual classes:

For parity with tiledbsc-r
To facilitate comparisons tiledbsc-py <-> tiledbsc-r
To make it easier to complete readback/outgest logic
To faciliate development of the nascent SOMA-query API

Context: #72
Notes

This is a big, cross-cutting PR -- which is a card which I try to rarely play in my career. Reviewer, I owe you a beer. If you thought you owed me one, then I now owe you two. ;)
Names are largely drawn from tiledbsc-r.
Rest assured all unit tests that were ever passing, are still passing.

Review guide

Base object TileDBObject

Propagates basic things like config options, ctx, verbosity, indent level for printing to the terminal, etc
For groups & arrays both

Group object TileDBGroup

Simple wrapper around tiledb group. When we add a soma.uns['neighbors']['params']['method'] via overloading the index operator, that'll go right here.

Array object TileDBArray
Various array/group classes like in tiledbsc-py

See init.py for a quick view
See also this README.md section for my "rosetta stone" to help keep all this straight in my head

soma.py is now quite a bit slimmed down

What isn't done on this PR

The ingestor still does shutil.rmtree. In-place updates are pending my finding the right overwrite-mode syntax for tiledb.from_numpy in UnsArray; other array-creation sites in the code appear to be working OK with in-place updates.
TileDB-Cloud URIs aren't fully supported yet -- this will be done separately.
Overloading the index operator so we can say things like soma.uns['neighbors']['params']['method'] will be powerful and liberating, but, will be done on a separate PR.
Likewise, currently-in-plan SOMA-API updates are not here. Yet rest assured that the current class-strucuting work will make that easier, quicker, and less error-prone.
Readback via to_anndata is largely in place, as a pure-Python prototype. It still has a bug on readback of obsp and varp (same bug that was present before this PR); needs dealing with separately.

Reviewer, I owe you a beer. If you thought you owed me one, then I now owe you two.
Noted 🍻


Make factory method for creating reader

This is only readerV1 for now. Will do v2 in a separate commit.
I have also begun moving the "public" api to the init folder

Codecov Report

Merging #204 into master will decrease coverage by 0.13%.
The diff coverage is 76.54%.

@@            Coverage Diff            @@
##           master    #204      +/-   ##
=========================================
- Coverage   85.84%   85.7%   -0.14%
=========================================
  Files          68      67       -1
  Lines        3532    3512      -20
  Branches      477     471       -6
=========================================
- Hits         3032    3010      -22
- Misses        399     401       +2
  Partials      101     101

Impacted Files
Coverage Δ

petastorm/test_util/shuffling_analysis.py
0% <0%> (ø)
:arrow_up:

setup.py
0% <0%> (ø)
:arrow_up:

examples/hello_world/python_hello_world.py
0% <0%> (ø)
:arrow_up:

examples/mnist/tests/test_pytorch_mnist.py
100% <100%> (ø)
:arrow_up:

examples/hello_world/tensorflow_hello_world.py
100% <100%> (ø)
:arrow_up:

examples/mnist/tf_example.py
79.59% <100%> (ø)
:arrow_up:

...o_world/tests/test_generate_hello_world_dataset.py
96.42% <100%> (ø)
:arrow_up:

petastorm/reader_worker.py
92.85% <100%> (-0.09%)
:arrow_down:

petastorm/benchmark/throughput.py
84.84% <100%> (ø)
:arrow_up:

examples/mnist/pytorch_example.py
67.05% <33.33%> (ø)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ef567a...eec0d2b. Read the comment docs.


Indent Guide dosn't work everywhere

Hi, I just started to use this plugin in eclipse and it's realy nice, thank you.
But I have installed it on another computer and it's doesn't show. It appears in "preferences", we can change the color or width, but it's dosnt appear on the text editor ...
We have the same version of eclipse ...
I just installed on other eclipse and it's works ...
Realy weird

Hey there,
Did you enable the plugin for the various file types? It needs to be
done explicitly in the preferences (at the same place where you can
configure everything else).
Simon

Thanks for fast response, Yes it's enable for all files.
Mathieu

After re-installed and change some parameters (like the pixel width) it's works, I don't know why ... Thank you for your help


How to resolve a topic

Hi,
I have trying to resolve some topics from our bots but I can't seem to find anything in this client lib or in the official API doc.

Sorry I just found it there:

You can resolve topics by editing the topic to ✔ {original_topic}.


[DPE-3824] Upgrade mysqld-exporter to v0.15

Issue
We would like to test a new build of the charmed-mysql-snap which contains an upgraded version of mysqld-exporter
Solution
Update snap revision to reflect the new build
TODO
Update charm revision to 8.0/edge revision after https://github.com/canonical/charmed-mysql-snap/pull/45 is merged in

Closing as PR is irrelevant right now - mysqld-exporter has the following issues https://github.com/prometheus/mysqld_exporter/issues/754 that we are running into

mysqld-exporter 0.15 does not correctly parse unix sockets as --mysqld.address (it expects host:port)
mysqld-exporter 0.15 expects my.cnf style file with args even though it should be optional if the args are passed in through the command line


jsoning was loaded as "database" not "db" in example.

Basically, in the example, it used "db" to use jsoning, however, "db" wasn't defined. So I changed "let database" to "let db"

Finally I can merge this and sleep peacefully.


Add core-foundation to homu

@bors-servo r+

:pushpin: Commit e727194 has been approved by metajack

:hourglass: Testing commit e727194 with merge f354b7f...

:sunny: Test successful - travis


Delay before paymentStatus event

After entering the card details and pressing "Purchase", there is at least a 2-3 second delay, where the Braintree component disappears, but (paymentStatus) has not fired yet.
For improved UX, would be good if there was an event that would be fired right after user has pressed "Purchase" or if the Braintree component would not disappear and would display a loader until the paymentStatus event fires.

@MarkusPint thank you for this. A loader will be displayed as soon as the user clicks purchase. This feature will be available in this week's release.


tiny fixes & improvements

@camfairchild @S0AndS0 @Rubberbandits @shibshib

need rebase with development branch, will use #299 to continue


Expand test modules

I am trying to expand some macros inside #[cfg(test)] mod tests { .... } modules and failing.
I have tried: cargo expand --tests, cargo expand --test path/to/file.rs, cargo expand --test file, cargo expand test` (like cargo test but with expand), without any luck.
I've also tried by copying the relevant code into tests/file.rs and trying to cargo expand --test tests/file.rs instead.

Expanding test code in the library requires passing --test to rustc (not to cargo). This should work: cargo expand -- --test.

Thanks, I managed to get it to work. I was doing cargo expand -h which was suggesting to use  --test. It was very confusing.


Cannot build project

Hi,
This maybe something obvious, but tried to build the latest version and im getting the same message for all three .net versions.
The only argument that gives me the correct output is the  help '-?'
Using VS2019. Build comes back clean. Tried both Debug and Release.
Win10 21H1 OSBuild 19043.1320

Any suggestions appreciated.
Object reference not set to an instance of an object.

I'm guessing IPv6 is disabled on that system? If so, you can manually feed it a MAC address (-mac ) to get around that bug. I have a version with some bug fixes that I will be posting soon.

IPv6 is enabled, but you were right that setting the MAC resolved the issue.
Incase its useful, im using a laptop wireless that doesnt have an cabled connection.

Interesting, it doesn't looks like it's detecting any of the IPs. Did the old version of Inveigh work on that same system?

It did and does yes.


Remove @runbench targets

We don't want to run these benchmarks as part of dune build, so can't have run aliases for them as we do for the tests.

/cc @voodoo would be nice if dune build would not run the benchmark targets.


de-accession bibdata-alma-worker3 and reduce worker count to 2

With the extra CPUs on the solr boxes, a worker maxes out its own CPU with 2 workers. The solr infra can handle 4 workers indexing at once at 60% CPU usage.

closed by https://github.com/pulibrary/princeton_ansible/pull/2429 and https://github.com/pulibrary/bibdata/pull/1597


Documentation?

I've looked around on the Copernicus site and here, but I can't find any documentation on using this Python package. Would appreciate a point in the right direction?

Hi @cademirch 👋
Many thanks for your question!
Actually, this package was a PoC (as written in the setup.py file: Development Status :: 2 - Pre-Alpha). It's going to be archived in favor to an upgraded version with a brand new package (that replaces this one), with a broader perimeter and covering more use cases.
The new package (available in both CLI and Python API) can be downloaded via [pip|mamba|conda]. Currently it's in Closed Beta.
👉🏻 Head to the Help Center dedicated section to know more!
Note:

in the current phase, only signed in users can browse the content so don't forget to sign-in before or to refresh your web page if done afterwards!
as a general note, while being signed-in you can also chat in real time with our User Support Engineers (using the widget chat on the bottom right of any of our web pages!)

Does it answer your answer your question?

@copernicusmarine Thank you for the info! I am trying to visit the pages you have linked, but unfortunately even after signing in, I am redirected to the Copernicus home page every time, so I cannot get to the page you have linked.

Hi @cademirch , thanks for your message. We invite you to chat with our user support, while being sign in, using the widget located on the bottom right of the page:

https://help.marine.copernicus.eu/en/collections/4060068-copernicus-marine-client
They will sort out the situation in no time :)

Meanwhile, for sake of clarity, I'm closing this thread, since this repo is going to be archived in favor of the new client.


Takes too long on resume session on a new repo.

Testing #161875
Repro steps:

Create new extension repo using yo code with "initialize git repository?" to true.
Open the created repository in code-insiders

For some reason takes over 2 mins the first time. Following reloads get to "Aborting resuming edit session as no edit session content is available to be applied from ref undefined." almost instantly.

Hm, it only takes 16 seconds for me. This could be due to our service itself being unhealthy or extension host process contention on startup. Out of curiosity how many extensions do you have installed? If you are able to repro this, would you mind sharing the Log (Edit Sessions) output channel contents or open the network tab in devtools to share how long the individual network requests to our service are taking?

I will try it again a few more times and let you know.


Could not find es6 branch to clone

In description there is written the following command to try the new version of the logger:
git clone https://github.com/bluejamesbond/Scribe.js --branch  es6 --single-branch && cd Scribe.js && npm install && npm run babel-node ./examples/simple-server.js
But i get an error saying that there is no branch named es6, so i suppose that is the dev branch instead.

Do you mean this branch? https://github.com/bluejamesbond/Scribe.js/tree/dev

Yup, my points is that the command should be:
git clone https://github.com/bluejamesbond/Scribe.js --branch **dev **--single-branch && cd Scribe.js && npm install && npm run babel-node ./examples/simple-server.js

I updated it as such. Thank you. I'm closing this issue. Please reopen as necessary


Loop iterator type

I ran into a situation where I wanted to pass a loop iterator to a function, like this:
def test(a: bit<32>) {
	let test2 = a;
}

for (let i = 0..5) {
	test(i);
}

But the typechecker is seeing i as type idx<0..1, 0..5>, and gives this error:
[Type error] [6.7] Expected subtype of int32 in parameter, received: idx((0,1), (0,5)).
Should this fail like this?

This is related to #73, FWIW!

Gah, subtyping and join need to be updated

Another spot where this problem came up: for fft, I wanted to OR together an iterator and a bit<32> variable, and I got a similar error.

Paste the program here please.

The original, from here:
    ...

    outer:for(span=FFT_SIZE>>1; span; span>>=1, log++){
        inner:for(odd=span; odd<FFT_SIZE; odd++){
            odd |= span;
            even = odd ^ span;

            temp = real[even] + real[odd];
            real[odd] = real[even] - real[odd];
            real[even] = temp;

            temp = img[even] + img[odd];
            img[odd] = img[even] - img[odd];
            img[even] = temp;

            rootindex = (even<<log) & (FFT_SIZE - 1);
            if(rootindex){
                temp = real_twid[rootindex] * real[odd] -
                    img_twid[rootindex]  * img[odd];
                img[odd] = real_twid[rootindex]*img[odd] +
                    img_twid[rootindex]*real[odd];
                real[odd] = temp;
            }
        }
    }
}

The type of odd and even will be dynamic since performing an operation on an index type upcasts it to a dynamic type. It's unclear if you should actually be allowed to do this. Instead, think about the view this implies.
Open a new issue if you think this particular operations should be applied.


Strong name assembly

Hi, is there any changes to sign assembly with strong name? :)

No, I'm not sure about signing.

Why not? :)
On Tue, May 10, 2022 at 1:39 PM vain0x @.***> wrote:

No, I'm not sure about signing.
—
Reply to this email directly, view it on GitHub
https://github.com/vain0x/DotNetKit.Wpf.AutoCompleteComboBox/issues/24#issuecomment-1122219698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALEFV2DV3XHYS4LSSV2VKXDVJI4FHANCNFSM5VQ3VTLQ
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Signing seems to need some amount of work; but I'm uncertain how it's helpful or necessary. Pull request is welcome.

Ok, will see if I can do this ;)
On Tue, May 10, 2022 at 7:26 PM vain0x @.***> wrote:

Signing seems to need some amount of work; but I'm uncertain how it's
helpful or necessary. Pull request is welcome.
—
Reply to this email directly, view it on GitHub
https://github.com/vain0x/DotNetKit.Wpf.AutoCompleteComboBox/issues/24#issuecomment-1122616830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALEFV2EOQJYWEEOEB54QCTTVJKE47ANCNFSM5VQ3VTLQ
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Closing since it's been a while and I have no plan to support strong name signing for now. Feel free to reopen if someone want to discuss about this.


Breaking changes in patch updates?

Hello, due to a recent update this broke one of my CI pipelines. It appears in version 1.1.4 and 1.1.1 you included a breaking change. Please follow semantic versioning to prevent this in the future.

@BaileyJM02  Thanks for the suggestion. I'll recommend switching from the v1.1.x version to v* or v*.* semantics the legacy 1.1.x was introduced earlier and wouldn't be supported longer term.
v1.1.x -> v12
See

https://github.com/tj-actions/changed-files/issues/79

NOTE: Patch/Minor version v*.* aren't currently used by the corresponding major version which might change in the future.


villagers torches

The villagers only inserted torches on grass blocks, soil, and stones

Wall torches are much more complicated and I can't add them at this time.  I have worked with some of the funky direction code a few weeks ago so I might be able to do it later but can't for now..


Parameter setup bugfixes

Description

This addresses two issues encountered when loading themes via URL.

Themes with lightness set to 0 do not load: #179
Themes do not load when the first defined color scale uses OKLAB/OKLCH plus smoothing. #179

The first issue was due to lightness interpreted as undefined. The second was solved by ignoring the smoothing setting for the first color scale, then setting it downstream if the color space was OKLAB or OKLCH.
Motivation

Want users to be able to use the site with these parameters setup.
Screenshots

To-do list

[x] I have read the CONTRIBUTING document.

[x] This pull request is ready to merge.

@DmitryBaranovskiy or @GarthDB sorry for the 🏓 ping but I do not have merge & release rights. The first fix is straightforward. The second fix is a bit of a workaround, but still succeeds in loading the example URLs filed in the linked issue.


Feature: Can we add Available books features?

Describe the feature
The "Available Books" feature provides users with access to a diverse collection of literary works, curated and made accessible through our platform. Users can explore a wide range of books spanning various genres, from classics to contemporary literature. Each book listing includes details such as cover image, and a convenient download link, allowing users to easily access and enjoy their favorite reads. With our "Available Books" feature, users can embark on literary adventures, discover new authors, and indulge in the joy of reading.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 let me work on the feature...

Assigned! @shruti-mishraa
Make sure to attach before & after screenshots in your PR. Also, star the repo before working on it. While creating your PR, ensure you pull all existing changes beforehand to avoid conflicts.
Happy open-source contributing!


Date picker in a dialog not working

I am using a date picker in a dialog, the picker opens up but only the action bar is visible at the top of the dialog, the rest of the control doesn't show. I am suspecting its a z-index issue and positioning the control with respect to the parent container. Anyone run into this?

I didn't not include moment library. Including it solved the issue.


Encounter path resolve problem on Windows platform

After migrated @nuxtjs-alt/proxy 2.1.0 to @nuxt-alt/proxy 2.2.0
While startup nuxt dev server, following error reported :
√ Nitro built in 16193 ms

 ERROR  [worker reload] [worker init] Only URLs with a scheme in: file, data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

  at new NodeError (node:internal/errors:387:5)
  at throwIfUnsupportedURLScheme (node:internal/modules/esm/resolve:1017:11)
  at defaultResolve (node:internal/modules/esm/resolve:1097:3)
  at nextResolve (node:internal/modules/esm/loader:163:28)
  at ESMLoader.resolve (node:internal/modules/esm/loader:837:30)
  at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
  at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:76:40)
  at link (node:internal/modules/esm/module_job:75:36)

The situation looks similar to https://github.com/unjs/nitro/issues/718

The same problem


Detect when a SECTION with the same name is used twice

The following code doesn't work as the user intended
void test(bool foo)
{
    SECTION("bar")
    {
           CHECK(something);
    }
}

TEST_CASE("Test something", "[test-something]")
{
    test(true);
    test(false); // This doesn't get executed
}

This can be solved by wrapping the calls to test in SECTION. Not sure if it's a DOCTEST issue or a user error, but the fact that the second call just gets ignored is problematic. If it's a user error, DOCTEST should report an error.

Sorry for the late reply and thanks for reporting! My initial hunch was that it's not possible to diagnose this, but actually it should be possible to issue a warning (or at least crash) when subcases are misused like this. Will keep this open until it's fixed.

This needs a minimal reproducible example.
BTW, I've seen the usage of SECTION a la BDD style, but it does not seem to be defined anywhere?


Background service not working with Android O

Android O has changed the way things work in the background, and this service will not work on an Android O device in the background.
To reproduce, run the example project on a virtual Android O device, while subscribed to location updates, turn off the screen of the device.  Updates stop (actually slow down to about once every 30 minutes) until the screen is turned back on.

Background execution with location updates that wake up the application is not supported yet.

I see the same thing. On Android N locations keep coming through when the app is backgrounded, but this does not happen on Android O.
Ideally, I would like this change on Android N:

Option to keep tracking locations and send locations to REST server when OS kills backgrounded app or when user swipes away the app. (A 'stop tracking' option is available in the app itself when needed)

And for Android O the same, but right now it doesn't even send locations when the app is in background.
Does the background tracking work well on iOS 11? I haven't been able to test this yet.
Do you know when this functionality could become available in this plugin? I'm working on an app that needs to track boats in open water and am now looking at Flutter instead of Ionic, partly because the geolocation plugins for Ionic are not working very well in background on iOS.
In any case, thanks for your work on this plugin. Hopefully we can go the Flutter way.

@synio-wesley Could you explain how you get the backgorund updates to work in Android N or lower? During my tests the updates get buffered when the app goes in the background but .listen() is not called, therefore the coords are not being sent to firestore, as per my requirement. Tried it on several devices with background and unrestricted data access enabled for my app.
StreamSubscription < LocationResult > subscription = Geolocation.locationUpdates(     accuracy: LocationAccuracy.best,     displacementFilter: 10.0,     inBackground: true,   )   .listen((result) {     if (result.isSuccessful) {       saveResult(result);     } else {}   });

Hello,
Does anyone know if the new version has the same behaviour ?
Or is the .listen() called every time when the app is in background ?

I just have tried it on Android version 9 and the location updates stop when the app is not active in the foreground. I have switched from the plugin I am using to this plugin just for this feature.

@lukaspili - does the plugin support background execution already?

I have tried it on Android version 9 and the location updates stop when the app is not active in the foreground. I have switched from the plugin I am using to this plugin just for this feature. Unfortunately, it is not working.

which plugin you are using now for foreground let me know if you found some stable plugin, i am really sick of these basic issues.. even flutter editor's favorite widget also have issues.. and the extremely bad thing is plugins owners damn care about bugs/issues.. i can i noticed 70% of issues are still not replied by anyone.


Add more Java installations detection options

Hi!
@raboof and me are wondering about a standard mechanism to discover JDKs on a system, particularly in the context of the Nix package manager. We're aware of the org.gradle.java.installations.{fromEnv,paths} mechanisms that Gradle exposes, and that there are a number of heuristics implemented by Gradle.
I didn't manage to pass Java installations to Gradle via {GRADLE,JAVA}_OPTS:
JAVA_11JETBRAINS_HOME=/nix/store/r670i06rdg59g8zpzyzzdvv3w85k3kq7-jetbrains-jdk-11.0.7-b64
JAVA_11_HOME=/nix/store/zfwnw6bi1ljyfnwfs4n12ryxbxxa4wlg-openjdk-11.0.10+9
ORG_GRADLE_JAVA_INSTALLATIONS_PATHS=${JAVA_11JETBRAINS_HOME},${JAVA_11_HOME}
GRADLE_OPTS="-Dorg.gradle.java.installations.paths=${ORG_GRADLE_JAVA_INSTALLATIONS_PATHS}" gradle -q javaToolchains
JAVA_OPTS="-Dorg.gradle.java.installations.paths=${ORG_GRADLE_JAVA_INSTALLATIONS_PATHS}" gradle -q javaToolchains

Should that work?
I was wondering whether Gradle would be willing to make things a little easier here. Some options, in order of personal preference:

Allow setting one of org.gradle.java.installations.{fromEnv,paths} via the environment, e.g. ORG_GRADLE_JAVA_INSTALLATIONS_{FROMENV,PATHS}.
As a new convention, consider all JAVA_*_HOME variables to be candidates.
Accept a new implementation of InstallationSupplier that scans /nix/store for Java installations.

Also, are there any JEPs, or similar efforts to unify ways of discovering JDKs?
/cc @bmuskalla

Edit: As of 2022-11 there are two new installation suppliers:

IntellijInstallationSupplier contributed by @rweisleder in #19890
MavenToolchainsInstallationSupplier contributed by @Okeanos in #19048

Edit: As of 2024-05-18 there is work ongoing for one more installation supplier:

NixInstallationSupplier by @lorenzleutgeb in #29214

IntelliJ's built in support for downloading JDKs may benefit from this as well.
We could point to a directory (or have the autodetection check for the default IntelliJ download path, I think it's ~/.jdks) that we know contains multiple JDKs downloaded by IntelliJ, and use them in toolchains.

Yes, it looks like IntelliJ IDEA will default to downloading to ~/.jdks. This could be added as an InstallationSupplier to Gradle.
Also, there's been work the other way round, to register JDKs downloaded by Gradle in IntelliJ IDEA: https://github.com/JetBrains/intellij-community/pull/1464
All of that works by supplying directories, with the JDKs being sub-directories. This would work for Nix as well, although the directory would have many more entries:
$ find /nix/store -maxdepth 1 -type d | wc -l
21646

$ find /nix/store -maxdepth 1 -type d -name '*jdk-*'
/nix/store/qsd848cffk29syl67r7yq19hgf1nmras-openjdk-8u272-b10-jre
/nix/store/0yjcz9q4p1nbwg7qr5x6mmrsap7m016q-openjdk-11.0.9+11
/nix/store/m5v6l2lmjslncl9hvyp493k3h2f947kx-jetbrains-jdk-11.0.7-b64
/nix/store/6ndz2aw3w61j999ydbykdpgczj6la2i0-openjdk-8u272-b10-jre
/nix/store/jq8bjsyk3qjidwi6npy844inz802fzky-openjdk-8u272-b10
/nix/store/x7zm8sdj4k42agpm2i5z7h0ygs4ng20w-openjdk-8u242-b08-jre
/nix/store/q0ap8aa5br4vr2y75n7hmacwlihmpdgq-openjdk-11.0.7-ga
/nix/store/g6l8fi6l0aq4713ba9cwsry85sqvzbaq-openjdk-8u242-b08
/nix/store/48ddc74sdlinbg5q5655i4z8kp6xasb0-openjdk-11.0.9+11
/nix/store/r670i06rdg59g8zpzyzzdvv3w85k3kq7-jetbrains-jdk-11.0.7-b64
/nix/store/526lsclbryma9qk5kadfqn2r6r7ndmsj-openjdk-8u272-b10-jre
/nix/store/cw580zrdvdqv8f0dk7cddf5p97pf84rw-openjdk-8u272-b10
/nix/store/7vj5k82kym6v0sljgw12qfkczhlwkp2w-openjdk-8u272-b10-jre
/nix/store/npnlqndq25wimi3nyp334c8hznhxwwik-openjdk-8u272-b10
/nix/store/m9qyc7zdrm42m809dhpgcvbgwifab2xi-openjdk-8u272-b10-jre
/nix/store/fmzyx4vadw5sy7y8zjw7ysv0952p4fpc-openjdk-8u272-b10
/nix/store/avwbx0mfdbqgh9dr0lhfpls7ys54bj07-jetbrains-jdk-11.0.7-b64
/nix/store/qpc15fcpmr93fpsv4s0rhwz5b6dbjsvl-openjdk-11.0.9+11
/nix/store/6njnlhvz2q5bd516pwdd09vrv4h0b7f0-openjdk-8u272-b10-jre
/nix/store/dff8y658p4xlppwspm2sbwwb77mx3s6k-openjdk-8u272-b10
/nix/store/8dsfl02y2i3xivpwynyxgnphf7nfd082-jetbrains-jdk-11.0.7-b64
/nix/store/zfwnw6bi1ljyfnwfs4n12ryxbxxa4wlg-openjdk-11.0.10+9
/nix/store/n1i0dnrky3wdmxlvkpg19bfw8l9ik732-openjdk-15.0.1-ga
/nix/store/6b2k015akivwvlmps54h7r1nqy6cjck6-openjdk-11.0.10+9

The problem being that this is not really reproducible. I'd prefer to explicitly specify a list of JDKs when wrapping Gradle, but I failed to do so via only environment variables (as mentioned in the initial description of the issue).

This would work for Nix as well (...) The problem being that this is not really reproducible

Aside from reproducibility there are some more reasons this is not a great approach for Nix: most importantly, by looking at /nix/store 'manually' you might refer to things that are not in your 'current environment', which means Nix might garbage-collect them from under your feet unexpectedly (Nix of course takes care not to garbage-collect things that are part of active environments, but you lose that protection by scanning the store directly). Also, the internal directory structure of different JDK packages is not consistent: for example the JAVA_HOME for openjdk15 is /nix/store/b40bz6ylignrgpnidz4951j42k6a8l4y-openjdk-15.0.1-ga/lib/openjdk, while for adoptopenjdk-hotspot-bin-15 it's /nix/store/k4snz9ny9b4qxaj98imxmhm28p8bjjzs-adoptopenjdk-hotspot-bin-15.0.2 - without the /lib/openjdk. The latter could perhaps be fixed, but it doesn't feel like the right direction.
I like the idea of scanning any environment variables of the form JAVA_*_HOME for JDK's. While not a widespread convention at this point, there is some precedent for it (https://www.google.com/search?hl=en&q="JAVA_8_HOME"), and it seems to serve a need that isn't otherwise met yet.

This would work for Nix as well (...) The problem being that this is not really reproducible

Aside from reproducibility there are some more reasons this is not a great approach for Nix: most importantly, by looking at /nix/store 'manually' you might refer to things that are not in your 'current environment', which means Nix might garbage-collect them from under your feet unexpectedly (Nix of course takes care not to garbage-collect things that are part of active environments, but you lose that protection by scanning the store directly). Also, the internal directory structure of different JDK packages is not consistent: for example the JAVA_HOME for openjdk15 is /nix/store/b40bz6ylignrgpnidz4951j42k6a8l4y-openjdk-15.0.1-ga/lib/openjdk, while for adoptopenjdk-hotspot-bin-15 it's /nix/store/k4snz9ny9b4qxaj98imxmhm28p8bjjzs-adoptopenjdk-hotspot-bin-15.0.2 - without the /lib/openjdk. The latter could perhaps be fixed, but it doesn't feel like the right direction.
I like the idea of scanning any environment variables of the form JAVA_*_HOME for JDK's. While not a widespread convention at this point, there is some precedent for it (https://www.google.com/search?hl=en&q="JAVA_8_HOME"), and it seems to serve a need that isn't otherwise met yet.

Yeah, maybe I was using the word "reproducibility" incorrectly, but the first problem (profiles, GC) is what I meant. I just didn't expand any further, because I thought that the people working on Gradle might not be interested in those details :) But anyway, it's good to mention!
I am actually a bit surprised to hear that the $JAVA_HOME varies by package. By saying "it doesn't feel like the right direction", you refer to scanning /nix/store again, right? Because I would think that harmonizing $JAVA_HOME across JDK packages would be a good thing.

I thought that the people working on Gradle might not be interested in those details :)

Yeah, fair enough, sorry for rambling ;)

I would think that harmonizing $JAVA_HOME across JDK packages would be a good thing.

I agree it would be an improvement from an "it is nice when things are consistent" perspective, but actually relying on it (thus making it a somewhat-obscure 'rule') feels questionable.

Just had a quick look at the documentation and afterwards stumbled upon this issue. I am surprised no one mentioned Maven Toolchains, specifically the ~/.m2/toolchains.xml file as a source of JDK locations that could be 'autodetected' by Gradle.
This would be particularly useful when migrating from Maven to Gradle to ease the transition or when having different projects that use either but require particular JDKs.

@ljacomet kindly asking for feedback from Gradle.

Toolchains installation locations are passed as Gradle properties not system properties. What you tried should work by changing the -D to -P and passing that as a paramtere of the gradle command.
Regarding the different questions:

It feels weird to allow environment variables to be defaults for Gradle properties, especially when one of them is used to know which environment variables to read.
We do something similar in our test infrastructure. It makes me wonder about having an SPI for detection of JDKs instead of adding this kind of support natively.
Given the conversation, that seems like a tricky thing to support. So maybe it fits better as an external option if Gradle had an SPI for that.

@Okeanos That is a very good point and something which would make sense inside Gradle. If you are up for it, feel free to file an issue and propose a PR 😉

@ljacomet I am willing to take a look at it at the very least, however, would very much appreciate a few basic pointers, e.g. where to look inside the Gradle project for the current toolchain detection implementation for instance. I have used Gradle but never worked on the project itself before.

@Okeanos If I were you I'd start from https://github.com/gradle/gradle/blob/4d54b872e15f36eb892f53f37a65717f2d16758d/subprojects/jvm-services/src/main/java/org/gradle/jvm/toolchain/internal/LinuxInstallationSupplier.java

FWIW in Nixpkgs, I took the org.gradle.java.installations.fromEnv route, see https://github.com/NixOS/nixpkgs/pull/119444

Sorry, we don't want to add more built-in options.
I opened a new issue that describes roughly our approach: https://github.com/gradle/gradle/issues/29508
We want a mechanism so 3rd parties can add support for different package manager options and not require changes to Gradle to support them. Eventually, we would remove the existing options.


Unordered list relationship lines can extend too far in edit mode when there are indentation issues

Example doc:

...which renders normally in view mode:

Adding an extra space to the obvious line causes edit mode to look as expected:

since this isn't a critical issue & since relationship lines are gonna need a do-over with the upcoming version 0.13 anyway (due to the transition to CodeMirror 6), I'll postpone this issue for now and look into it when the CM6 changes are stable, just so you know

So I tried to look into it in the new editor and I think you can't make relationship lines work with wrong indention.
Unless you find some theme or plugin that has relationship lines despite indention issues, I don't think I am able to do anything about this, sorry.


Support for Cloud Terminal API ?

I would like to use the Go-libarary with Cloud-Terminals from Adyen
The Readme in the develop branch says:
The Library supports all APIs under the following services:
[...]
Cloud-based Terminal API: Our point-of-sale integration.

But I cannot find anything regarding cloud-terminals in the code, beside a configuration for the TerminalApiCloudEndpoint
Is there any plans for supporting Cloud-Terminals in the near future ?

Found the issue #32 now, and it seems like it is closed. Does that mean the feature is implemented @KadoBOT  ?

Hi @kurtinge , I'm not working for Adyen anymore. If no one answers in the next couple of days, I can try finding who can help you.

Hey @kurtinge , our libraries don't have a 1/1 relation with the APIs. Let me check what the status is for the Cloud-Terminals. I'll come back to you about this

Hi, I have the same question as @kurtinge and I can't find an answer, do you have any updates?

Hello all, unfortunately we don't support Terminal API's in Go yet due to the lack of OpenAPI specifications. We are working together with the respective teams and have some prototypes, but we can't provide an estimate yet since priorities can change quickly.
Meanwhile, In-Person Payments merchants have been using https://github.com/Adyen/adyen-java-api-library or https://github.com/Adyen/adyen-dotnet-api-library, which provide a partially automated implementation.


SEPA: credit

Incl. example with and without BIC.

Coverage remained the same at 100.0% when pulling 6cef763838cec95726e2ef1753715e8f2939164b on reka:sepa-credit into 7c4068b9226363cc66327a410b11c241e2841e4b on wirecard:59-sepa.

Coverage remained the same at 100.0% when pulling 1499d4d7d4f18ea6f17942ca1d7237a6a3500881 on reka:sepa-credit into 7c4068b9226363cc66327a410b11c241e2841e4b on wirecard:59-sepa.


fast path for fixed-size vecbuilder

@sppalkia can you test performance

C Runtime: 0.031014
Weld Runtime: 0.034031

beautiful job good sir


GodotSharp Error

Godot version:

GODOT 3.0.3 RC 2
OS/device including version:

Windows 10 64bit
Issue description:

Fresh project, press play and everything works but as soon as i make a new *.cs and attach to a node godot shows me an error : "Failed to build GodotSharp Solution". It was the same with 3.0.3 rc1. Current 3.0.2 stable works. Using Mono 5.4.1

Steps to reproduce:
Minimal reproduction project:

Fresh Prpject

What version of mono do you have installed? For 3.0.3 you must have mono 5.10

What version of mono do you have installed? For 3.0.3 you must have mono 5.10

OP says: Using Mono 5.4.1
Wasn't the idea behind bundling DLLs that we wouldn't have a strong requirement on the Mono version though? Or does that mean that people can use 5.10 or newer, but not older?

5.10 did the trick
did a few tests with different mono versions for clarification:

mono-<IP_ADDRESS>-x64-0 not working
mono-<IP_ADDRESS>-x64-0 working
mono-<IP_ADDRESS>-x64-0 not working
mono-<IP_ADDRESS>-x64-0 not working

Wasn't the idea behind bundling DLLs that we wouldn't have a strong requirement on the Mono version though? Or does that mean that people can use 5.10 or newer, but not older?

Bundling mscorlib only prevents editor from crashing on start, but it will work only with assemblies from exactly same runtime version (at least System.dll and System.Core.dll are usually incompatible).

Wasn't  the idea behind bundling DLLs that we wouldn't have a strong  requirement on the Mono version though? Or does that mean that people  can use 5.10 or newer, but not older?

I was under the impression that was for running games, not necessarily developing them.

@akien-mga We have to bundle a few more assemblies, not only mscorlib. I mention this in #18364. It's more even noticeable with 5.10 which replaced some assemblies with the CoreFX implementation. I ask for patience until I'm done with my obligations in a month, although I hope I can make some good progress with these issues by then in my free time.

@rama0x9 Please re-test with Godot 3.2.3 and/or the master branch. Also, check if you have the latest Mono and .NET Core.
If this issue does still exist for you, then you will need to include a minimal reproduction project.

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


systemwide install of offlinedatasci fails on recent debian versions

Using a Debian 11 (Bullseye) or 12 (Bookworm) VM to build the image fails when upgrading pip and installing offlinedatasci. It insists on being installed in venv. Need to confirm if this happens on a Raspberry Pi too.
+ pip3 install<EMAIL_ADDRESS>error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.

    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.

    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.

    See /usr/share/doc/python3.11/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

Yes that is expected in newer installations due to PEP 668. I use pipx to install Python applications, it is available in Debian.

Thanks @abhidg, I didn't know about pipx. Can you create a pull request with your changes?

Never mind, just saw your PR


Fix/unregistered mask testnet

See the commit messages for details. Adding the asserts make the unit tests fail, fixing up the child detection makes them pass again.
Checklist:

[x] Tests were added for the new behavior
[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[x] Does this close issues? List them:

Closes #2969

oops, some of the staged ledger tests don't handle masks properly.


Possible Issue with Dependencies and Linux

Hi,
after we've updated from 6.6.1 to 7.4.0 we ran into an issue with the dependencies included.
The core-module has jakarta.activation:2.0.1 and jakarta.mail:2.0.1 as direct dependencies.
The smime-module has jakarta.activation-api:2.1.0 and jakarta.mail-api:2.1.0 as dependencies (via utils-mail-smime:2.0.1 --> bcjmail-jdk15to18:1.70).
On the website for Jakarta Mail it says that

The Jakarta Mail API definitions only, suitable for compiling against; use only with a Maven “provided” dependency scope

The Maven Page for Bouncy Castle Jakarta S/MIME API lists them as compile dependencies, so in theory they should not be needed at runtime and therefore shouldn't be included when building the project with Maven (same with bcprov, bcutil and bcpkix but that's not an issue so far).
The issue this causes seems to be the following:
On a Windows machine the Java classloader adds the jakarta.activation-2.0.1.jar first and after that the jakarta.activation-api-2.1.0.jar. Your batch file for the standalone version also adds the jakarta.activation-2.0.1.jar first (line 75 in the sjm.bat in the cli-module-7.4.0-standalone-cli.zip).
If you do the same thing on a linux machine (Ubuntu 20.04 in this case) the classloader adds the jakarta.activation-api-2.1.0.jar first which leads to this error:
java.lang.ExceptionInInitializerError
java.lang.ExceptionInInitializerError: null
	at org.simplejavamail.converter.EmailConverter.mimeMessageToEmailBuilder(EmailConverter.java:135) ~[simple-java-mail-7.4.0.jar:?]
	at org.simplejavamail.converter.EmailConverter.mimeMessageToEmailBuilder(EmailConverter.java:122) ~[simple-java-mail-7.4.0.jar:?]
	at org.simplejavamail.converter.EmailConverter.emlToEmailBuilder(EmailConverter.java:390) ~[simple-java-mail-7.4.0.jar:?]
	at org.simplejavamail.converter.EmailConverter.emlToEmailBuilder(EmailConverter.java:369) ~[simple-java-mail-7.4.0.jar:?]
	at org.simplejavamail.converter.EmailConverter.emlToEmail(EmailConverter.java:303) ~[simple-java-mail-7.4.0.jar:?]
	at org.simplejavamail.converter.EmailConverter.emlToEmail(EmailConverter.java:295) ~[simple-java-mail-7.4.0.jar:?]
...

Caused by: java.lang.RuntimeException: Provider for jakarta.activation.spi.MailcapRegistryProvider cannot be found
	at jakarta.activation.FactoryFinder.find(FactoryFinder.java:90) ~[jakarta.activation-api-2.1.0.jar:?]
	at jakarta.activation.MailcapCommandMap.getImplementation(MailcapCommandMap.java:696) ~[jakarta.activation-api-2.1.0.jar:?]
	at jakarta.activation.MailcapCommandMap.loadFile(MailcapCommandMap.java:284) ~[jakarta.activation-api-2.1.0.jar:?]
	at jakarta.activation.MailcapCommandMap.<init>(MailcapCommandMap.java:154) ~[jakarta.activation-api-2.1.0.jar:?]
	at jakarta.activation.CommandMap.getDefaultCommandMap(CommandMap.java:60) ~[jakarta.activation-api-2.1.0.jar:?]
	at org.simplejavamail.converter.internal.mimemessage.MimeMessageParser.<clinit>(MimeMessageParser.java:127) ~[simple-java-mail-7.4.0.jar:?]
	... 59 more

Renaming the jakarta.activation-2.0.1.jar to for example jakarta.activation-zzz-2.0.1.jar leads to the same issue on a windows machine.
We solved this on our end by completely removing both the jakarta.activation-api-2.1.0.jar and the jakarta.mail-api-2.1.0.jar from our project, but given that at the moment they are included when building the project we're not entirely sure if this has any consequences during runtime (allthough we haven't found any so far).

The non-api jars have exactly the same classes in it so in runtime this should be fine. I'm wondering why smime-module relies on the -api version, though. Can't remember that being intentional, but I'll have a look.

Ok so bouncy castle brings it it. I've tested ands verified the following doesn't pose any problems:
<exclusions>
                <exclusion>
                    <groupId>jakarta.mail</groupId>
                    <artifactId>jakarta.mail-api</artifactId>
                </exclusion>
                <exclusion>
                    <groupId>jakarta.activation</groupId>
                    <artifactId>jakarta.activation-api</artifactId>
                </exclusion>
</exclusions>

Would this solve your issue?

https://github.com/bcgit/bc-java/issues/1199

Ok so bouncy castle pulls it in, as you said. I've tested ands verified the following doesn't pose any problems:
<exclusions>
   <exclusion>
      <groupId>jakarta.mail</groupId>
      <artifactId>jakarta.mail-api</artifactId>
   </exclusion>
   <exclusion>
      <groupId>jakarta.activation</groupId>
      <artifactId>jakarta.activation-api</artifactId>
   </exclusion>
</exclusions>

Would this solve your issue?

Since the primary issue is with Bouncy Castle and not your project this workaround should solve our issue until they have fixed in on their end.

Closing as nothing more I can do here.


[ISSUE #855] Add the Test Util And ORC Writer for Spark

Add the Test Util And ORC file writer.
Lack of the metrics information and file length check.

HI @rdsr , would you mind to take another look or give some advices on next steps？ thanks

Thanks @shawnding . I'll try to review this today!

This looks good to me, except for two things:

Map keys are always required if the map is projected, so I'm not sure the map change is correct.
I think it would make more sense to add nested tests later. The majority of these changes are test changes to add a map. I don't think the amount of change here is worth such a narrow set of cases -- one string map with the same key/values each time.

One more thing that I thought of: if this is adding the ability to write ORC files, then we should make sure all of the parameterized Spark tests that currently test Parquet and Avro are also applied to ORC.

Thanks for your suggestion @rdblue . I will append same complicated nested type to this test。And now if  all of the parameter test applied to ORC file should after https://github.com/apache/incubator-iceberg/pull/199 have merged

I will append same complicated nested type to this test

Sorry for the miscommunication: I'm asking you to remove the more complicated nested type from this PR. Let's get the existing tests running on ORC for this PR and then we can add more test cases in a separate one.

Thanks @rdblue , I was  removed the  nested type.would you mind to take another look or give some advices on next steps？

Looks good to me. Thanks for adding this, @shawnding!


To Use With Javascript Server/Client on JSON TCP Protocol

Hi,
AnyRpc work fine server/client on c++. But when I use it with another Server/Client on Javascript+Node on JsonHttp is still working fine. But I used with JsonTcp no data received on server.
My Javascript code (Server and Client) work fine together on jsontcp mode also, like the AnyRpc examples. But to mix or cross it that only work on JsonHttp.
The Javascript client for example is very simple like:
var client = jayson.client.tcp({port: 9000 })
client.request('add', [3.0, 5.0], function(err,response)){... throw ....}
Any idea ?
Thanks

I glanced through the jayson source code and I didn't see that it was using netstrings for the tcp implementation, but I don't really write Javascript code.  My guess is that it is just sending the requests and responses without any encapsulation.  Jsonrpc over tcp doesn't really have a standard with some using netstrings and others not.
If the problem is the encapsulation, AnyRpc could be modified to send unencapsulated data by modifying TcpClient and TcpConnection.  The problem with not encapsulating the data is determining the ending of the JSON objects.  The structure of this code assumes that the JSON string is available before parsing, in contrast to a structure that parses a character at a time until complete.

Thank you for your response
you know i used your client with jsontcp and i send request to server tcp with hercules (siftware seriak. Tcp and udp communication).
And get th request and i will send it from hercules cluent to anyrcp server. I see request with wireshark but not in your server.
Just another information to more understand the issues
Thkx
Sent from my Samsung Galaxy smartphone.
-------- Original message --------
From: Steve Gieseking<EMAIL_ADDRESS>Date: 2017-01-24 4:09 PM (GMT-05:00)
To: sgieseking/anyrpc<EMAIL_ADDRESS>Cc: Mehdi<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [sgieseking/anyrpc] To Use With Javascript Server/Client on JSON TCP Protocol (#29)
I glanced through the jayson source code and I didn't see that it was using netstrings for the tcp implementation, but I don't really write Javascript code. My guess is that it is just sending the requests and responses without any encapsulation. Jsonrpc over tcp doesn't really have a standard with some using netstrings and others not.
If the problem is the encapsulation, AnyRpc could be modified to send unencapsulated data by modifying TcpClient and TcpConnection. The problem with not encapsulating the data is determining the ending of the JSON objects. The structure of this code assumes that the JSON string is available before parsing, in contrast to a structure that parses a character at a time until complete.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sgieseking/anyrpc/issues/29#issuecomment-274939325, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQlVH1zgYZpicYecesEyjPxvWN8-tH7ks5rVmh8gaJpZM4Lsu37.

I modifie your cluent exactly the header...() to remove  betstring and my Javascript  server eesponse correctly  to yiur client. I have to remove this encapsulation netstrin steps (receive/send).
But what is the main raison to use this netstring and not just send and receive json native ??
Thkx

The following link summaries the encapsulation issue:
https://www.simple-is-better.org/json-rpc/transport_sockets.html
Essentially, you can only send one request/response per connection, perform some encapsulation such as netstrings, or detect the end of the JSON by some type of parsing/streaming approach.
Xmlrpc is only officially specified over http.  With jsonrpc, the spec doesn't really specify the transport layer, but with http, it is mostly consistent between implementations.  With jsonrpc tcp, some implementations encapsulate with netstrings and some don't.
AnyRpc currently performs the encapsulation using netstrings but I can include a fully tested non-encapsulated method as an additional transport method.

Hi,
Thank you again . It is very intersting to add the precompile option to decide with netstring or not. So if you can do it it will be very good . I start to modifie on clinet is more easy but not the server. The only issue is about the default request length or size. I think to use your default size of your buffer (2048 byte ). But It is more intersting for me if you do it by your self because you know it more than any other people.
Otherwise I compile your librairy on cross compile arm and the Lib linked correctly right now. I have to integrated with you cmake system. Because I just did with simple makefile under Eclipse. When I finish to work on this cross-compile and when i make it clean on your cmake I will send to you (commited).
So tell me if you will modified it to to support netstring or not ?
Thank you very much again and hope to work with you.
See you

From: Steve Gieseking<EMAIL_ADDRESS>Sent: January 26, 2017 8:36 AM
To: sgieseking/anyrpc
Cc: Mehdi; Author
Subject: Re: [sgieseking/anyrpc] To Use With Javascript Server/Client on JSON TCP Protocol (#29)
The following link summaries the encapsulation issue:
https://www.simple-is-better.org/json-rpc/transport_sockets.html
simple is better - JSON-RPC 2.0 Transport: Socketshttps://www.simple-is-better.org/json-rpc/transport_sockets.html
www.simple-is-better.org
Using sockets (TCP, UDP or Unix Domain Sockets) with JSON-RPC is simple: Simply send and receive the JSON-RPC strings. The only problem is to detect when a Request ...
Essentially, you can only send one request/response per connection, perform some encapsulation such as netstrings, or detect the end of the JSON by some type of parsing/streaming approach.
Xmlrpc is only officially specified over http. With jsonrpc, the spec doesn't really specify the transport layer, but with http, it is mostly consistent between implementations. With jsonrpc tcp, some implementations encapsulate with netstrings and some don't.
AnyRpc currently performs the encapsulation using netstrings but I can include a fully tested non-encapsulated method as an additional transport method.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/sgieseking/anyrpc/issues/29#issuecomment-275373378, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFQlVPFwf0FxKUaxwI4malfnhpPepwEFks5rWIxKgaJpZM4Lsu37.

In the current context of processing encapsulated transfers, the default buffer of 2048 only has a requirement to hold the header (http header or netstring length).  If the entire message will fit into the buffer, that is more efficient, but it will allocate a separate buffer of up to MaxContentLength = 1000000.  If your application works better with a different default, these can be adjusted.  Another option is to modify the code to make the buffer length as a parameter when creating the class.  It's not clear whether you are suggesting that your application would benefit from a larger or smaller buffer.
Regarding modifying the code to support direct JSON as an additional communication method, I can't give you a time frame for my making the modification.


refactor: better naming for config flag

SUMMARY

Coming out of some discussion from https://github.com/apache/incubator-superset/pull/10179 the flag LIST_VIEWS_NEW_UI is quite confusing as to what it's refering to.
This PR updates the flag to be more semantically correct, LIST_VIEWS_SIP34_FILTER_UI and adds a comment on ENABLE_REACT_CRUD_VIEWS flag pointing to SIP-34.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

welcome, dashboards, charts, tables pages work with ENABLED_REACT_CRUD_VIEWS enabled
welcome, dashboards, charts, tables pages work with LIST_VIEWS_SIP34_FILTER_UI feature flag enabled

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #10180 into master will decrease coverage by 0.40%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10180      +/-   ##
==========================================
- Coverage   70.57%   70.16%   -0.41%
==========================================
  Files         594      190     -404
  Lines       31474    18360   -13114
  Branches     3228        0    -3228
==========================================
- Hits        22212    12882    -9330
+ Misses       9146     5478    -3668
+ Partials      116        0     -116

Flag
Coverage Δ

#cypress
?

#javascript
?

#python
70.16% <ø> (-0.23%)
:arrow_down:

Impacted Files
Coverage Δ

superset/config.py
90.00% <ø> (ø)

superset/views/database/mixins.py
59.64% <0.00%> (-21.06%)
:arrow_down:

superset/utils/cache.py
48.00% <0.00%> (-20.00%)
:arrow_down:

superset/db_engine_specs/mysql.py
78.72% <0.00%> (-12.77%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

superset/views/database/api.py
84.09% <0.00%> (-3.41%)
:arrow_down:

superset/db_engine_specs/postgres.py
97.36% <0.00%> (-2.64%)
:arrow_down:

superset/views/database/views.py
87.17% <0.00%> (-2.57%)
:arrow_down:

superset/models/core.py
84.46% <0.00%> (-2.26%)
:arrow_down:

superset/jinja_context.py
80.00% <0.00%> (-0.96%)
:arrow_down:

... and 406 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdc6b1...1bb87c5. Read the comment docs.


Do not regenerate api object that does not change

The Dynamic team is using siwe-parser in our codebase in production, and noticed that ParsedMessage(text) was causing unnecessary latency in our application. When we took a closer look its implementation, we noticed that the bulk of the latency was from creating a new apgApi:
const api = new apgApi(GRAMMAR);

Doing this in the constructor of ParsedMessage is unnecessary because new apgApi(GRAMMAR) would never actually change and that GRAMMAR is a static const declared earlier in the file. This means every time we instantiate the ParsedMessage class, we generate a new and unnecessary apgApi.
This PR removes the expensive API generation from ParsedMessage's constructor and make sure we only generate the API once.
siwe-parser's tests have a bunch of test cases they evaluate against to check that the parser works. Locally, I added basic time duration that looks like:
const start = new Date().getTime();
const parsedMessage = new ParsedMessage(test.message); // this line was already in parser.test.ts
const duration = new Date().getTime() - start;
console.log(`test duration[${test_name}]: ${new Date().getTime() - start}`)

Here are the results collected from running the test BEFORE I made the change (this was running on a M1 Max):
test duration[couple of optional fields]: 53
test duration[no optional field]: 35
test duration[timestamp without microseconds]: 29
test duration[domain is RFC 3986 authority with IP]: 26
test duration[domain is RFC 3986 authority with userinfo]: 25
test duration[domain is RFC 3986 authority with port]: 21
test duration[domain is localhost authority with port]: 21
test duration[domain is RFC 3986 authority with userinfo and port]: 22
test duration[no statement]: 21
test duration[domain ipv6]: 22
test duration[uri ipv6]: 22
test duration[uri ipv4]: 21
test duration[uri with port]: 21
test duration[uri ipv4 query params and fragment]: 21
test duration[chainId not 1]: 21
test duration[recovery byte starting at 0]: 21

And here are the results collected after the change was made:
test duration[couple of optional fields]: 11
test duration[no optional field]: 2
test duration[timestamp without microseconds]: 2
test duration[domain is RFC 3986 authority with IP]: 1
test duration[domain is RFC 3986 authority with userinfo]: 1
test duration[domain is RFC 3986 authority with port]: 1
test duration[domain is localhost authority with port]: 2
test duration[domain is RFC 3986 authority with userinfo and port]: 2
test duration[no statement]: 0
test duration[domain ipv6]: 1
test duration[uri ipv6]: 2
test duration[uri ipv4]: 0
test duration[uri with port]: 0
test duration[uri ipv4 query params and fragment]: 0
test duration[chainId not 1]: 0
test duration[recovery byte starting at 0]: 0

As you can see, the duration for instantiating the ParsedMessage class goes down significantly after the change - and this would translate to much lower latency in our application and the endpoint that uses this.

Hi there! I just wanted to follow-up on this PR. Anything we can do to help with the review? Thank you!

hi @sbihel - updated the branch . let me know if you need anything else

hi @sbihel - thanks for taking a look! i have rebased the commit off of upstream/main, and should be correct now. let me know if you need anything else.

@skgbafa @sbihel Thanks for reviewing and merging! When can we expect the new version to be published to NPM?

I can't give you an exact date right now, but we have a new release planned already and this changes will be included.


AetherSX2

AetherSX2 now loads into AetherSX2 home screen instead of directly into the rom. Could this be due to the recent AetherSX2 update that has now introduced ads ?


AAD & New Schema of User and Group

Coverage decreased (-2.6%) to 51.235% when pulling 348473856fbbd3bf180598ba297374fe0754b899 on authndev into ccda8e3760fede42134bb05853c3a7d4b5ef37bc on pai-0.14.y.


fix(APPLAUSE-6697021): auth2 back button double tap crash

This PR fixes a bug where double-tapping the back button on the password step of the auth flow crashes the app.
This happens because tapping back "pops" the last screen from a list of previous screens and sets it as the current screen, but we do not guard that operation against an empty list of previous screens. This PR solves that by not allowing the user to double-tap past the first screen in the auth flow.

BEFORE
AFTER

https://github.com/user-attachments/assets/8c08b24b-3d74-4767-92ca-43ac2f9f9d87
https://github.com/user-attachments/assets/93f22d74-58d0-40ec-aa0d-85c5a5674550

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Fixed a bug that could cause the authentication flow to crash

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (Fixed a bug that could cause the authentication flow to crash - iskounen)

  Generated by :no_entry_sign: dangerJS against 318da2a2744e0d4ef1ebeb0aa5ac0ba173647bd0

Cool - sure @araujobarret. It's not a blocker for sure. It's something we already in navigate and it's only perceived if you tap multiple times in a row.

I can perceive 100ms honestly 😂


⚠ ClamAV has degraded performance

In 17ef4d2, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 458 ms

Resolved: ClamAV performance has improved in e55f8ec.


i, j  and k / single letter abbrevs

I noticed that in the latest version i, j  and k are missing. I think "i" is used a lot and "j" also helpful. "k" should be in the list because "v" is (as in key and value)
Possibyl it could be an idea to move all single letter abbrevs into their own section

I would not be too strict on the convention versus abbreviations matter and my vote remains to keep them in. Because as you also state, they are "short and handy" and feel a little like an abbreviation... arguably "i" could be interpreted as "item".

Got it. We can create a separate section for them or add 'i' as 'item' as you said.

It's really hard to decide. If there aren't too many convention-like abbreviations (I can't tell more) I also suggest adding i and j.
I don't think single letter abbreviations are a special topic so I vote for adding them normally.

It's just by accident, right?

It's just by accident, right?

Yep, it should be - 🟢 v • value {only with k}

It's really hard to decide. If there aren't too many convention-like abbreviations (I can't tell more) I also suggest adding i and j.

I don't think single letter abbreviations are a special topic so I vote for adding them normally.

I still think thay are a little different than abbreviations but ok.

If we allow conventions I have to change back this point.

... whilst you are at it, I would also suggest to change "Abbreviations in codes
The list of the abbreviations you can find and use in software environment." to "Abbreviations in code
The list of the abbreviations you can find and use in software environments."

The name of the project here on GitHub is "Abbreviations..." so to change also that?

yea, readme title = repo title. I like it's clarity

Yep, it should be - green_circle v • value {only with k}

fixed in 7ff206746a297fa92e7c4dadacef268ea4c4a018

yea, readme title = repo title. I like it's clarity

fixed in bd7d9a3e5c91b48ff4c19dbb7a8c727db868ae9f

BTW, there are also type parameter names like T, U. Obviously, as with i, j, if you need more than one letter, by convention, you just take the next in the alphabet. So, follow-up letters have less of a right for an own entry.

IMO 2 follow up letters can be added to show the pattern.

i agree with @h-h-h-h that "follow-up letters have less of a right for an own entry".

So, we just add "i"?

Okay, let's add i only and open a new section like "Others" for j, k and similar cases.

Okay, let's add i only and open a new section like "Others" for j, k and similar cases.

If there is no objection, I can add the "Others" section for i, j, and k.

Nop go on after #50


Support connecting to password protected faktory

Adds support for connecting to a password protected instance of a faktory server.
Fixes #4

Yeah we could start up another faktory instance during tests with the password set. Do you feel the unit test doesn't fully cover the functionality?

The unit tests look good and cover the detail of the protocol but there is currently no way to verify that it connects to real faktory with a password outside of running it.

Now updated with an integration test for both correct and incorrect password usage.

Thanks looks good, just working on the circle stuff

@SeatedInc/dev tests passing now, although its not possible to remap ports on docker containers in circle they can be mapped to different hostnames https://support.circleci.com/hc/en-us/articles/360007186173-Port-conflicts-with-service-containers-on-Docker-executor
Config is switched in test mode depending on if in CI mode.


Allow analysis over abstract tags

Currently the analysis is done purely over word surface forms. It would be nice if we could do analysis in a more abstract context, such as using abstract tags like POS tags. One reference for this is the analysis done by @davidweichiang in this paper: http://www.mt-archive.info/HLT-EMNLP-2005-Chiang.pdf

Finished by https://github.com/neulab/compare-mt/commit/24dd523851006f077ec83cf3a5071952cb938f0c


The function wrap() does not work as expected

The doc says that If wrap is specified, sets this tile layout’s wrapping option to the specified boolean value and returns this tile layout, however it does not work as expected. Do we have some tests or examples for the wrap() function?

Could you please post an example that reproduces the behavior you see?

@curran Sorry, my d3-tile is an old version 0.0.3. The latest version works as expected.


Define Goals/Non-Goals

Possible Goals: Introduce Squid to Github.
For this, Squid should be a superset of Github's current Markdown.


small updates for sysupgrade/wireless-configuration

Exposing an accesspoint with a camera is a potential security risk, limiting the time to 3 minutes should be sufficient for the initial setup.
Summarize get_flash_type, puts the nand bootcmd and ipcinfo flashtype check in the same function.

With changes in the logic of sysupgrade, it is very desirable to make [bump version] (https://github.com/OpenIPC/firmware/blob/master/general/overlay/usr/sbin/sysupgrade#L6) so that the script is self updated before starting the firmware update.


Forming the CGR, during the Share Exchange, the Local Client get correct shares, remote client gets error

When Forming the CGR, during the Share Exchange, Player A collects the President Share of CGR, then Player B collects more shares, the swap of certificates are done out of order:
Action: Player A gets 2 Certificates of CGR from Bank
Action: Player A exchanges 2 Certificates of CGR for 1 President Certificate of CGR from Bank
Next is Player B's Actions on Client B
Action: Player B exchanges 2 Certificates (to Player A) for 1 President (from Player A)
**** FAILS to send 2 Certificates that have NOT been given to Player B yet ****
Action: Player B gets 3 (or more) Certificates of CGR from Bank

Corrected the order of the Actions for remote clients.


CL2 config validation

What type of PR is this?

/kind feature
What this PR does / why we need it:
Refinement of https://github.com/kubernetes/perf-tests/pull/142. Validates more aspects of the CL2 config.
Steps validation will automatically apply to modules once compilation is moved before test execution in https://github.com/kubernetes/perf-tests/pull/1680.
Which issue(s) this PR fixes:

Part of https://github.com/kubernetes/perf-tests/issues/1636
Special notes for your reviewer:
Copy pasted the logic from https://github.com/kubernetes/perf-tests/pull/142 but placed it in the existing api/validation.go file. Had to do a conversion back to CL2 error types.
TODO

[x] add subtest names
[ ] check for empty steps
[ ] check that referenced tuning set has been declared
[ ] implement verifyMeasurement

Does this PR introduce a user-facing change?:

Added CL2 config validation for namespaces, tuning sets and steps.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/ok-to-test

Resolved the file path issues. The remaining test failures will be fixed after rebasing on #1680

The failures are related to this PR:
0s
--
:0 [steps[1].measurements: Invalid value: []*api.Measurement(nil): can't be empty with empty phases steps[23].measurements: Invalid value: []*api.Measurement(nil): can't be empty with empty phases]

@lyzs90 - please fix

The failures are related to this PR:
0s
--
:0 [steps[1].measurements: Invalid value: []*api.Measurement(nil): can't be empty with empty phases steps[23].measurements: Invalid value: []*api.Measurement(nil): can't be empty with empty phases]

@lyzs90 - please fix

Will confirm. I think it should be coming from a module step whereby there's no measurements nor phases. Compilation of modules has not occured yet when the validation is run. That will happen after ~https://github.com/kubernetes/perf-tests/pull/1680~ https://github.com/kubernetes/perf-tests/pull/1712

The failures are related to this PR:
0s
--
:0 [steps[1].measurements: Invalid value: []*api.Measurement(nil): can't be empty with empty phases steps[23].measurements: Invalid value: []*api.Measurement(nil): can't be empty with empty phases]

Shem Leong - please fix

As Shem wrote, it should get fixed with https://github.com/kubernetes/perf-tests/pull/1680, where he moves module compilation before the validation

@lyzs90 - can you please rebase this one?
I would really like to have that in finally :)

@lyzs90 - can you please rebase this one?
I would really like to have that in finally :)

Done! I'll create a separate issue for improving the validation:

check for empty steps
check that referenced tuning set has been declared
implement verifyMeasurement

/lgtm
/approve
Thanks!

hmm - something froze here
/retest


Google Tag Manager not working

Under >public>index.html
Both the Tags for google Tag Manager and Google Analytics are included.
Google Tag Manager is not working

https://firebase.google.com/docs/analytics/get-started?platform=web
This file should be the exact official tutorial about this defect.
BTW, can you please write some wiki about how the analytics is designed and what's the google credential and account in use to offer analytic service?

It has started working. I will invite you to the admin.


gets a version of eigen3 which actually works

and be explicit about all these specific protobuf and hdf5 packages being available in the default package manager only on ubuntu 15.04

All hdf5 packages are not needed anymore.
I successfully installed clstm on Ubuntu 14.04 with Eigen 3.3 beta.
http://packages.ubuntu.com/xenial/all/libeigen3-dev/download


Work preview

Implement latest preview designs in Zeplin
single item

max width 1010px (10 col)

Multiple items <= 5

max-height 400px
max-width 800px
images centered
images get cut of to the right
wobbly background

In terms of the CTA, could we a/b test?
Work specific (# images or # pages) vs Generic (View item)

Apart from the A/B testing idea above (which I'll put in another issue), is this one ready to be closed @wellcometrust/experience-devs ?

@jennpb yes it is


would sheet-router work well with yoyo?

@yoshuawuyts  Would this router work well with bel/yoyo/morphdom?

Hell yeah - https://github.com/yoshuawuyts/playground-yoyo/blob/master/index.js
I'd stay away from the bridge.js file though, it's even confusing me (and I wrote it). Apart from that all should work well. Let me know if you run into any issues :sparkles:


Vagrant up fails if mysql is selected for install, but no database set to be created

TASK: [mysql | databases | import stored mysql databases] *********************
fatal: [localhost] => error while evaluating conditional: protobox_env == 'vagrant' and item.1.stat.exists and item.2.rc == 1

FATAL: all hosts have already failed -- aborting

PLAY RECAP ********************************************************************
           to retry, use: --limit @/root/playbook.retry

localhost                  : ok=27   changed=16   unreachable=1    failed=0

I had the same problem with this congif:
mysql:
  install: 1
  root_password: 123
  databases: [ ]

And the I ffixed the problem removing databases: [ ] line.


feat: Add static methods to composer

Can work inside a namespace Composer.static which allows a generic implementation via proxies.

This isn't what was requested. @Loskir please open a new issue describing what you actually meant, if this is still relevant.


Disclaimer for supermarket users

After some research I figured out the problem with the supermarket and the backup and backup_lwrp cookbook. In earlier issues it was said that the cookbook could be renamend, which would be quite a good idea an shouldn't be a big thing. But that's not mine to decide.
But since this isn't resolved ( at least for me) you should update the README for the supermarket. It looks to me that you maintain two versions of this cookbook, one for the supermarket and the one here on GIT. So why not just put in disclaimer or reminder that user who use the supermarket need to watch out that they should use backup_lwrp instead of backup to use its providers? This would've saved me some hours.

This is a valid point.  How do you think this would be best achieved without duplicating our README a ton?


Use particular version of external dependencies

Codecov Report

Merging #27 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #27      +/-   ##
=========================================
+ Coverage   64.72%   64.8%   +0.07%
=========================================
  Files          16      16
  Lines        4885    4878       -7
  Branches      441     441
=========================================
- Hits         3162    3161       -1
+ Misses       1525    1519       -6
  Partials      198     198

Impacted Files
Coverage Δ

source/broadband/webpa_notification.c
23.85% <0%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2027716...99bde74. Read the comment docs.


Fix Ethernet privileges

Post method:

/redfish/v1/Managers/bmc/EthernetInterfaces//VLANs/
ConfigureComponents -> ConfigureManager

Patch method:

/redfish/v1/Managers/bmc/EthernetInterfaces//VLANs//
ConfigureComponents -> ConfigureManager

/redfish/v1/Managers/bmc/EthernetInterfaces//
ConfigureComponents -> ConfigureManager (SubordinateOverrides)

Delete method:

/redfish/v1/Managers/bmc/EthernetInterfaces//VLANs//
ConfigureComponents -> ConfigureManager

This change allows only Admin user to post, patch, and delete on VLAN
Network Interface Collection and restrict Operator user.
Same for the EthernetInterfaces patch method.
Tested: Ran curl test with admin and operator privileged user for
all methods (post, patch, and delete). one test failing.
Error: curl -k -H "X-Auth-Token: $bmc_token"  -X PATCH -d
'{"VLANId" :30 , "VLANEnable" : true}'
https://${BMC_IP}/redfish/v1/Managers/bmc/EthernetInterfaces/
eth0/VLANs/eth0_50
   This command is unable to update the VLANId value. instead, it
   deletes VLAN

Email sent to openbmc list:
https://lists.ozlabs.org/pipermail/openbmc/2021-August/027232.html
Signed-off-by: Abhishek Patel<EMAIL_ADDRESS>Change-Id: I4101c429db6fa788909982b66445b191ccacaec7

upstream commit is  https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/45469


Add redis index deploy features.

I have nginx installed with the HTTP_REDIS module so it would be advantageous to have nginx serve the index.html file.  However the nginx redis module is very limited.  It is not easy to lookup the key and then use the key to fetch the content.
I am thinking a improved approach would be to copy the index content to the value of the current key thus eliminated the need for a lookup.
The second thing I ran into was wanting to store the html cache.manifest file in redis as well.   I know cache.manifest is a bastard, but it does help with mobile.
Just wanted to run this by the team. I will most likely fork the ember-deploy-redis repo and implement this functionality.
:beers: to paving the cow paths.
Here is the nginx config; quite simple.
map $arg_version $app_version {
    default "current";
    ~^\w+ $arg_version;
}
upstream redisbackend{
    server <IP_ADDRESS>:6379;
}
server {
    location / {
        set $redis_key my-app:$app_version;
        redis_pass redisbackend;
        default_type text/html;
    }
}

Any one have any thoughts about the cache.manifest?

Hi @arenoir... I think having the right hooks to support for a cache manifest is a good idea.
Regarding writing the HTML content directly to the "current" key in redis, I would like for it to be easy for you to do this in your own addon. It would definitely not become the default behavior for a redis addon because it eliminates many of the benefits of the addon, such as preview and rollback support.
Stay tuned to #88 and chime in if you think the hooks we are planning will not be sufficient to achieve what you need.

@lukemelia thanks for the reply.  I just pushed a pull request to ember-deploy-redis that allows writing directly to the content current key.  Preview and rollback still work, I just moved where the version number was stored.


[Bug]: VLC not currently returning latest version (3.0.21)

What happened?
@aaronparker This is more of an FYI, for other Evergreen users, than a requirement for you to fix anything:
The latest version of VLC that Evergreen returns (via Get-EvergreenApp -Name VideoLanVLCPlayer) is currently returning the previous 3.0.20 version.
This appears to be because VLC have not updated the content served by the x64 URL https://update.videolan.org/vlc/status-win-x64 or x86 URL https://update.videolan.org/vlc/status-win-x86, defined on lines 8 & 9 of the VideoLanVLCPlayer.json file
So, I have raised a request on the VLC forum asking when they plan to update the content served from these URLs, in the hope that Evergreen stays current.
"Detection of upgrade available to v3.0.21 not currently working": https://forum.videolan.org/viewtopic.php?f=14&t=164779
Version
2405.1076
What PowerShell edition/s are you running Evergreen on?
PowerShell Core, Windows PowerShell
Which operating system/s are you running Evergreen on?
Windows 10+
Have you reviewed the documentation?

[X] Troubleshooting at: https://stealthpuppy.com/evergreen/troubleshoot/
[X] Known issues at: https://stealthpuppy.com/evergreen/issues/

Verbose output
Get-EvergreenApp -Name VideoLanVLCPlayer -Verbose | ft

VERBOSE: Function path: C:\Program Files\WindowsPowerShell\Modules\Evergreen\2405.1076\Apps\Get-VideoLanVLCPlayer.ps1
VERBOSE: Function exists: C:\Program Files\WindowsPowerShell\Modules\Evergreen\2405.1076\Apps\Get-VideoLanVLCPlayer.ps1.
VERBOSE: Dot sourcing: C:\Program Files\WindowsPowerShell\Modules\Evergreen\2405.1076\Apps\Get-VideoLanVLCPlayer.ps1.
VERBOSE: Get-FunctionResource: read application resource strings from [C:\Program Files\WindowsPowerShell\Modules\Evergreen\2405.1076\Manifests\VideoLanVLCPlayer.json]
VERBOSE: Calling: Get-VideoLanVLCPlayer.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: DisableKeepAlive: True.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/124.0.2478.67.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: MaximumRedirection: 2.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: ContentType: application/octet-stream.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: Uri: https://update.videolan.org/vlc/status-win-x64.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: Method: Default.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: UseBasicParsing: True.
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 528-byte response of content type application/octet-stream
VERBOSE: Content encoding: utf-8
VERBOSE: Resolve-InvokeWebRequest: Adding UserAgent.
VERBOSE: Resolve-InvokeWebRequest: Resolving URI: [http://get.videolan.org/vlc/3.0.20/win64/vlc-3.0.20-win64.exe].
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: UserAgent: VLC/3.0.16 LibVLC/3.0.16.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: ErrorAction: SilentlyContinue.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: Uri: http://get.videolan.org/vlc/3.0.20/win64/vlc-3.0.20-win64.exe.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: UseBasicParsing: True.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: MaximumRedirection: 0.
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 response of content type text/html of unknown size
VERBOSE: Resolve-InvokeWebRequest: Response: [Found - Moved Temporarily].
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: DisableKeepAlive: True.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/124.0.2478.67.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: MaximumRedirection: 2.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: ContentType: application/octet-stream.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: Uri: https://update.videolan.org/vlc/status-win-x86.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: Method: Default.
VERBOSE: Invoke-EvergreenRestMethod: Invoke-RestMethod parameter: UseBasicParsing: True.
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 528-byte response of content type application/octet-stream
VERBOSE: Content encoding: utf-8
VERBOSE: Resolve-InvokeWebRequest: Adding UserAgent.
VERBOSE: Resolve-InvokeWebRequest: Resolving URI: [http://get.videolan.org/vlc/3.0.20/win32/vlc-3.0.20-win32.exe].
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: UserAgent: VLC/3.0.16 LibVLC/3.0.16.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: ErrorAction: SilentlyContinue.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: Uri: http://get.videolan.org/vlc/3.0.20/win32/vlc-3.0.20-win32.exe.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: UseBasicParsing: True.
VERBOSE: Resolve-InvokeWebRequest: Invoke-WebRequest parameter: MaximumRedirection: 0.
VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
VERBOSE: Received HTTP/1.1 response of content type text/html of unknown size
VERBOSE: Resolve-InvokeWebRequest: Response: [Found - Moved Temporarily].

Version Platform Architecture Type URI
------- -------- ------------ ---- ---
3.0.20  Windows  x64          EXE  https://www.mirrorservice.org/sites/videolan.org/vlc/3.0.20/win64/vlc-3.0.20-win64.exe
3.0.20  Windows  x64          MSI  https://www.mirrorservice.org/sites/videolan.org/vlc/3.0.20/win64/vlc-3.0.20-win64.msi
3.0.20  Windows  x64          ZIP  https://www.mirrorservice.org/sites/videolan.org/vlc/3.0.20/win64/vlc-3.0.20-win64.zip
3.0.20  Windows  x86          EXE  http://mirror.lchost.net/videolan/vlc/3.0.20/win32/vlc-3.0.20-win32.exe
3.0.20  Windows  x86          MSI  http://mirror.lchost.net/videolan/vlc/3.0.20/win32/vlc-3.0.20-win32.msi
3.0.20  Windows  x86          ZIP  http://mirror.lchost.net/videolan/vlc/3.0.20/win32/vlc-3.0.20-win32.zip

Documented in the known issues here: https://stealthpuppy.com/evergreen/issues/#videolanvlcplayer

Yep maybe that's the reason - Apologies I jumped in on the issue without checking the 'known issues' 1st - that'll teach me 🤣
N.B. It also looks like the latest .msi installs may not be forthcoming (https://forum.videolan.org/viewtopic.php?f=14&t=164735) 🤷♂


NaiveBayesClassifier taking too long

Hi, I've a small dataset of 1000 tweets which I've classify in pos/neg for training. When I tried to use it at the NaiveBayesClassifier() it tooks like 10-15min to return a result...
Is there a way to save the result of the classifier like a dump and reuse that for further classifications ?
Thanks

I'm experiencing this, but I cannot get rid of the training set because is in French, which means every string is UTF-8 encoded.
I actually created a training set encoded as ASCII, ignoring the characters outside that encoding (which means losing a lot of data), and the training phase was still taking too much time.
What can I do?

Hi, I also noticed the TextBlob classifier to take very long in comparison to sklearn and the NLTK-classifier. But I don't understand why there is a difference, especially for NLTK. Isn't TextBlob using the NLTK version?

Can I know how to get the accuracy and most informative features of the naive bayes classifier which is already trained using movie corpus.
Thanks

Experiencing similar performance issues. Using custom NaiveBayes classifier to train on 1500 article titles (pos, neg, NA). Takes about 10 minutes to train on core i7 and not much faster to classify the same number of titles with a pickled classifier (loading is fast, but classification is slow). Any ideas how to speed this up? I can understand that training is slow, but why is classification slow too?

I ran into the same trouble.  It seems that basic_extractor re-tokenizes the training set with every update AND for each item in the original training set (so training is O(n^2)).
I'm working on a fix that should also fix #77 and #123.

any update on this issue?

#136 is now merged and released to PyPI.


Proper nouns require proper capitalisation

Given that this function has been named after and developed to deter a specific individual, it would be best to highlight the function's importance by utilising proper capitalization of the offender's name to prevent later removal.

Consistent code styling takes precedent over normal English grammar rules; if Caesar doesn't get capitalised, then you surely don't.


Feature request: Pin issues

There are a few issues at a time that I absolutely cannot lose track of, and sometimes I'll go back to read them and forget to mark them as unread later on.
Any chance of getting a thumbtack icon next to "mark as unread" or something that keeps them in the notifications view until I manually un-pin them?
The notification color would probably red, and would be the least prioritized (e.g. blue if there are any new notifications, green if there are any manually unread notifications, and finally red if there are any pinned issues).
This is similar to #1481 in nature but a different use-case. Also, "just use browser bookmarks" is a complete non-starter as far as solutions go.

This is a complete duplicate of the #1481 you mentioned.

#1571: something that keeps them in the notifications view until I manually un-pin them?

#1481: will not be cleared from notifications list until you manually 'resolve' them

Duplicate of #1481

Sorry @Qix-, but the current "mark as unread" functionality is quite complex and we would prefer to not add even more bloat to it. This functionality is also not something we or I guess most people would need.


Hotfix for #35 Log error and continue when deleting oldest message fails.

Hi @jhillyerd
I've made a hotfix for issue #35.
Regards,
Tomasz

Looks good, thank you!