[SDK] Charting Colors that enabled color blind mode

Now that we have the dyslexic and motion sensitivity layers working, I would love to get at least one part of the color blind functionality working.
We can start by modifying the charting colors and the state colors based on the type of color blindness.
I have created the proper color blind charting colors for the 8 types of color blindness and those will be fixed values.  So now we need to create the standard charting colors.
1.) For users who provide a primary color, secondary and tertiary colors the values are as follows:
For Light Mode:
If the users selects white or the half/quarter colors for the background the charting variables are as follows:

--chart-1: is the primary-400
--chart-2: is the primary-500
--chart-3: is the primary-700
--chart-4: is the primary-900
--chart-5: is secondary-500
--chart-6: is secondary-700
--chart-7: is secondary-900
--chart-8: is tertiary-500
--chart-9: is tertiary-700
--chart-10: is tertiary-900
--on-chart-1: is the on-primary-400
--on-chart-2: is the on-primary-500
--on-chart-3: is the on-primary-700
--on-chart-4: is the on-primary-900
--on-chart-5: is on-secondary-500
--on-chart-6: is on-secondary-700
--on-chart-7: is on-secondary-900
--on-chart-8: is on tertiary-500
--on-chart-9: is on-tertiary-700
--on-chart-10: is on-tertiary-900

If the user selects black or the dark shade of the primary color the chart variables are as follows:
--chart-1: is the primary-050
--chart-2: is the primary-100
--chart-3: is the primary-300
--chart-4: is the primary-500
--chart-5: is secondary-050
--chart-6: is secondary-200
--chart-7: is secondary-400
--chart-8: is tertiary-050
--chart-9: is tertiary-200
--chart-10: is tertiary-400
--on-chart-1: is the on-primary-050
--on-chart-2: is the on-primary-100
--on-chart-3: is the on-primary-300
--on-chart-4: is the on-primary-500
--on-chart-5: is on-secondary-050
--on-chart-6: is on-secondary-200
--on-chart-7: is on-secondary-400
--on-chart-8: is on-tertiary-050
--on-chart-9: is on-tertiary-200
--on-chart-10: is on-tertiary-400

For Dark Mode:

--dm-chart-1: is the dm-primary-050
--dm-chart-2: is the dm-primary-100
--dm-chart-3: is the dm-primary-300
--dm-chart-4: is the dm-primary-500
--dm-chart-5: is dm-secondary-050
--dm-chart-6: is dm-secondary-200
--dm-chart-7: is dm-secondary-400
--dm-chart-8: is dm-tertiary-050
--dm-chart-9: is dm-tertiary-200
--dm-chart-10: is dm-tertiary-400
--dm-on-chart-1: is the dm-primary-050
--dm-on-chart-2: is the dm-primary-100
--dm-on-chart-3: is the dm-primary-300
--dm-on-chart-4: is the dm-primary-500
--dm-on-chart-5: is dm-secondary-050
--dm-on-chart-6: is dm-secondary-200
--dm-on-chart-7: is dm-secondary-400
--dm-on-chart-8: is dm-tertiary-050
--dm-on-chart-9: is dm-tertiary-200
--dm-on-chart-10: is dm-tertiary-400

2.) For users who provide a primary color and secondary colors only:
For Light Mode:
If the users selects white or the half/quarter colors for the background the charting variables are as follows:

--chart-1: is the primary-400
--chart-2: is the primary-500
--chart-3: is the primary-700
--chart-4: is the primary-900
--chart-5: is secondary-400
--chart-6: is secondary-500
--chart-7: is secondary-700
--chart-7: is secondary-900
--chart-9: is gray-500
--chart-10: is black
--on-chart-1: is the on-primary-400
--on-chart-2: is the on-primary-500
--on-chart-3: is the on-primary-700
--on-chart-4: is the on-primary-900
--on-chart-5: is on-secondary-400
--on-chart-6: is on-secondary-500
--on-chart-7: is on-secondary-700
--on-chart-7: is on-secondary-900
--on-chart-9: is on-gray-500
--on-chart-10: is on-black

If the user selects black or the dark shade of the primary color the chart variables are as follows:
--chart-1: is the primary-050
--chart-2: is the primary-100
--chart-3: is the primary-300
--chart-4: is the primary-500
--chart-5: is secondary-050
--chart-6: is secondary-100
--chart-7: is secondary-300
--chart-8: is secondary-500
--chart-9: is grey-300
--chart-10: is white
--on-chart-1: is the on-primary-050
--on-chart-2: is the on-primary-100
--on-chart-3: is the on-primary-300
--on-chart-4: is the on-primary-500
--on-chart-5: is on-secondary-050
--on-chart-6: is on-secondary-100
--on-chart-7: is on-secondary-300
--on-chart-8: is on-secondary-500
--on-chart-9: is on-grey-300
--on-chart-10: is on-white

For Dark Mode:

--dm-chart-1: is the dm-primary-050
--dm-chart-2: is the dm-primary-100
--dm-chart-3: is the dm-primary-300
--dm-chart-4: is the dm-primary-500
--dm-chart-5: is dm-secondary-050
--dm-chart-6: is dm-secondary-100
--dm-chart-7: is dm-secondary-300
--dm-chart-8: is dm-secondary-500
--dm-chart-9: is dm-grey-300
--dm-chart-10: is dm-white
--dm-on-chart-1: is the dm-on-primary-050
--dm-on-chart-2: is the dm-on-primary-100
--dm-on-chart-3: is the dm-on-primary-300
--dm-on-chart-4: is the dm-on-primary-500
--dm-on-chart-5: is dm-on-secondary-050
--dm-on-chart-6: is dm-on-secondary-100
--dm-on-chart-7: is dm-on-secondary-300
--dm-on-chart-8: is dm-on-secondary-500
--dm-on-chart-9: is dm-on-grey-300
--dm-on-chart-10: is dm-on-white

3.) For users who provide ONLY a primary color:
For Light Mode:
If the users selects white or the half/quarter colors for the background the charting variables are as follows:

--chart-1: is the primary-400
--chart-2: is the primary-500
--chart-3: is the primary-700
--chart-4: is the primary-900
--on-chart-1: is the on-primary-400
--on-chart-2: is the on-primary-500
--on-chart-3: is the on-primary-700
--on-chart-4: is the on-primary-900

Next, we need to create additional shades for colors that complement the primary color:

Here is the following function that I use:

function splitComplement(testColor) {
      var rgbArray = hextoRGBArray(testColor);
      var h = chroma.rgb(rgbArray).get('hsv.h');
      var s = chroma.rgb(rgbArray).get('hsv.s');
      var v = chroma.rgb(rgbArray).get('hsv.v');
      h += 180;
      var h0 = h + 30;
      var h1 = h - 30;
      var color1 = 'rgb(' + chroma.hsv(h0,s,v).rgb() + ')';
      var color2 = 'rgb(' + chroma.hsv(h1,s,v).rgb() + ')';
    }

From there I create the 10 shared of light mode and dark mode for color1 and color2.

    --chart-5: is color1-500
    --chart-6: is color1-700
    --chart-7: is color1-900
    --chart-8: is color2-500
    --chart-9: is color2-700
    --chart-10: color2-900
    --on-chart-5: is on-color1-500
    --on-chart-6: is on-color1-700
    --on-chart-7: is on-color1-900
    --on-chart-8: is on-color2-500
    --on-chart-9: is on-color2-700
    --on-chart-10: on-color2-900

    If the user selects black or the dark shade of the primary color the chart variables are as follows:
    --chart-1: is the primary-050
    --chart-2: is the primary-100
    --chart-3: is the primary-300
    --chart-4: is the primary-500
    --chart-5: is color1-050
    --chart-6: is color1-100
    --chart-7: is color1-300
    --chart-8: is color2-050
    --chart-9: is color2-100
    --chart-10: is color2-300
    --on-chart-1: is the on-primary-050
    --on-chart-2: is the on-primary-100
    --on-chart-3: is the on-primary-300
    --on-chart-4: is the on-primary-500
    --on-chart-5: is on-color1-050
    --on-chart-6: is on-color1-100
    --on-chart-7: is on-color1-300
    --on-chart-8: is on-color2-050
    --on-chart-9: is on-color2-100
    --on-chart-10: is on-color2-300

    For Dark Mode:
    --dm-chart-1: is the dm-primary-050
    --dm-chart-2: is the dm-primary-100
    --dm-chart-3: is the dm-primary-300
    --dm-chart-4: is the dm-primary-500
    --dm-chart-5: is dm-color1-050
    --dm-chart-6: is dm-color1-100
    --dm-chart-7: is dm-color1-300
    --dm-chart-8: is dm-color2-050
    --dm-chart-9: is dm-color2-100
    --dm-chart-10: is dm-color2-300
    --dm-on-chart-1: is the dm-on-primary-050
    --dm-on-chart-2: is the dm-on-primary-100
    --dm-on-chart-3: is the dm-on-primary-300
    --dm-on-chart-4: is the dm-on-primary-500
    --dm-on-chart-5: is dm-on-color1-050
    --dm-on-chart-6: is dm-on-color1-100
    --dm-on-chart-7: is dm-on-color1-300
    --dm-on-chart-8: is dm-on-color2-050
    --dm-on-chart-9: is dm-on-color2-100
    --dm-on-chart-10: is dm-on-color2-300

link to problem content

Proposed Solution

@lwnoble to look to implement color blind modes with assistance from other maintainers as required

@lwnoble Lise, this has been checked into the dev branch.  I imagine there are going to be some issues with the generation of color1 and color2 when only the primary is set.  If so, I'll need some help in getting those right.  Please verify.

Talked with @lwnoble today, SDK portion done.  We need UI to show the changes to the end user.  @lwnoble and @aaronreed708 to meet.

Talked with @lwnoble, she and @smithbk need to meet to discuss tweaking the values going into color blindness/charting colors.  They will meet on Friday to discuss.
The UI piece should be done under a different issue.  @aaronreed708 to open.  Involves:

Lise needs to create overlays for 8 types of color blindness
SDK will create 10 color combinations for charting by default
we need to create charting components that will utilize the 10 color combinations that the SDK will produce to demonstrate their functionality
we also need to allow these charting components to be influenced by the color blindness overlay dropdown value from the UI and use the appropriate colors for each possible color blindness level.

I created #758 and #759 for the UI pieces mentioned above.

Update from today: When Keith is says it is ok, Lise says she can merge their code together.

10 color combinations complete, Keith and Lise to meet on next steps (SDK components)

@lwnoble mentioned in today's call that the colors are done, waiting on the molecule implementation on the SDK side.

Lise thinks this might be done - @smithbk could you let us know if so?

@lwnoble said to close.  Closing.


jailbreak detection bypass

all banking apps and games are disabled because of detecting jailbreak
i used all jailbreak detection bypass but it falls and reboot help ?

also tried all flex3 scripts not working and still crash

Try safemode when needed

This is neither an issue or a bug with unc0ver. I’m guessing you’re using a system-wide tweak (like bloard).
Feel free to post this in https://www.reddit.com/r/jailbreak/ as a [Request] post with the specific app name(s).
Please close this issue, @mohammadabumoosa.

use libertylite works great

Use libertylite bro.


export TF saved-models

This PR add code for exporting TF saved-model to TF-Hub. Added one notebook also to show how extra head can be appended over the pre-trained model and how the resulting model can be trained. I will add some detailed- text in the notebook if basic structure looks fine to you.
I can merge it if everything looks alright to you @sayakpaul @MorganR

@sayakpaul thanks for the review!
I will work on your suggestion by today.


[Doc Improvement][Add a link in see also for protected APIs]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/graph-api/proactive-bots-and-messages/graph-proactive-bots-and-messages.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 324134c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/graph-api/proactive-bots-and-messages/graph-proactive-bots-and-messages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


changed picker to let you choose number of picks

Added a user prompt for the number of people you want to pick.

Thanks @bahadasx, and what a great idea! Can you re-implement line 39 using range(len(people)) in case we onboard more staff and have to update our people dict?
Also, I noticed a bug in line 41, where we should be incrementing the number variable by one to account for the fact that it starts at 0 but our people dict starts at 1.


Shows custom error for latitude out of bounds

How to test this feature
See original issue #11050 for a description on how to test this fix.
Closes #11050

🚀

I have not been able to pass acceptance on this, I can investigate further the causes for it

What happened?


[Service Bus] CreateQueueOptions and restricted QueueResponse

Issue #10081
PROPOSAL
export interface QueueDescription {
    authorizationRules?: AuthorizationRule[];
    autoDeleteOnIdle?: string;
    deadLetteringOnMessageExpiration?: boolean;
    defaultMessageTtl?: string;
    duplicateDetectionHistoryTimeWindow?: string;
    enableBatchedOperations?: boolean;
    enablePartitioning?: boolean;
    forwardDeadLetteredMessagesTo?: string;
    forwardTo?: string;
    lockDuration?: string;
    maxDeliveryCount?: number;
    maxSizeInMegabytes?: number;
    name: string;
    requiresDuplicateDetection?: boolean;
    requiresSession?: boolean;
    status?: EntityStatus;
    userMetadata?: string;
}

export interface CreateQueueOptions extends Omit<QueueDescription, "status"> {}

export interface QueueResponse
  extends Pick<
      Required<QueueDescription>,
      | "defaultMessageTtl"
      | "lockDuration"
      | "deadLetteringOnMessageExpiration"
      | "duplicateDetectionHistoryTimeWindow"
      | "maxDeliveryCount"
    >,
    Readonly<
      Omit<
        Required<QueueDescription>,
        | "defaultMessageTtl"
        | "lockDuration"
        | "deadLetteringOnMessageExpiration"
        | "duplicateDetectionHistoryTimeWindow"
        | "maxDeliveryCount"
      >
    >,
    Response {}

With the current set of changes, QueueDescription is still the input for the update operation and continues to have all properties other than name as optional.
I would recommend a bottom up approach

Define CreateQueueOptions first
QueueDescription is defined based on CreateQueueOptions using the Pick/Omit/Required/Readonly logic you used in this PR and has the status as the extra property
QueueResponse extends QueueDescription

/azp run js - servicebus - tests

/azp run js - servicebus - tests

azp run js - servicebus - tests

/azp run js - servicebus - tests

/azp run js - servicebus - tests


SignalException not excluded despite being in excluded_exceptions

Hello,
A few of our rails apps are still seeing SignalExceptions on our dashboard. We'd like to exclude these exceptions from our dashboard since they're caused by Heroku restarts.
We have the following in the raven initializer:
Raven.configure do |config|
  ...
  # exclude exceptions
  config.excluded_exceptions = [
    'SignalException' # Heroku dyno restarts
  ]
end

However, the exceptions are still showing up:
SignalException: SIGTERM
Error | polyglot.rb in require at line 65 | rake

Thoughts? Thanks!

I did some digging and wrote a test to verify SignalExceptions are captured. The specs (as written) actually passed - https://github.com/getsentry/raven-ruby/commit/8a38a39b95deaab3dbbb29fa8774625011c7121e . However, we still see these exceptions coming in during Heroku server restarts.
As I listed above, our initializer is config/initializers/sentry_raven.rb:
Raven.configure do |config|
  ...
  config.excluded_exceptions = [
    'SignalException' # Heroku dyno restarts
  ]
  ...
end

However, looking into it, it looks like these exceptions are only coming through in rake tasks. Could it be possible that exceptions aren't being properly excluded in rake tasks? I am pretty sure that the environment (and initializers) are loaded when these rake tasks are run.
Cheers!

@drn it looks like the SignalException is being raised while files are being required, which leads me to believe your configuration has not yet been loaded. I would suggest the following:
# Gemfile
gem 'raven-ruby', require: false

# config/initializers/sentry_raven.rb
require 'raven-ruby'

Raven.configure do |config|
  ...
  config.excluded_exceptions = [
    'SignalException' # Heroku dyno restarts
  ]
  ...
end

There's still a chance that you'll catch a SignalException if it occurs between requiring Raven and executing the config block.
In addition, you will no longer catch any other exceptions raised before the initializer is executed.

Perfect. I'll test this out next week and will let you know if the SignalExceptions are suppressed. Thanks!

Your solution worked perfectly for our purposes. Thanks for the help

Cheers mate :)


Update copy and add empty state messages

Looks great. Ship it!

@piamancini What about "See how to contribute"

@znarf go for it


Add registerIfAbsent(Tracer tracer) to GlobalTracer

Related to #186 and https://github.com/opentracing/opentracing-java/pull/269#issuecomment-399699201

@pavolloffay @jpkrohling I want to work on this issue. May I proceed?

My bad, I labeled it as suitable for Outreachy but didn't realize there was a PR already.

Can this be closed since #289 is already merged?

Closing this one (#289 as mentioned ;) )


webpubsub, update changelog about nimbus-jose-jwt

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check for com.azure:azure-messaging-webpubsub
API changes are not detected in this pull request for com.azure:azure-messaging-webpubsub


[NuGet Symbol Server] Symbol package API push implementation

This includes the gallery side standalone changes for symbol push with API. In subsequent PRs I will add support for validations on snupkgs, telemetry and auditing.
Please review the code, this is work in progress and I will add tests to the same PR in subsequent commits.
@diverdan92 - Please review the strings in this PR.
I will be deploying this change to DEV to validate everything looks good before merging it in.

I have verified these changes in DEV env. I can now upload multiple snupkg files against existing nupkg and everything seems to be working as expected. Waiting on @joelverhagen to sign off and then merge this change into dev branch, followed by adding validations support for symbols.


Should/can generate Vulnerability's CWE as metadata?

Trustification exposes CWE in a column that exposes the list of vulnerabilities within a CSAF file. See image below:

Let's define if we should also include CWE on Trustify
CWE is also a column defined in the original mockups designed by UX

The CWE indicates what the cause of the vulnerability is (https://cwe.mitre.org/). As it doesn't take up much space, I think there's value in showing this.


Remove support for plate mounted stabilizers

I basically don't use plate mounted stabilizers, and although I tried to have a "one size fits all" plate cutout, it doesn't work well for Durock v2 stabilizers, which are regarded as some of the best screw in stabilizers. (Edit - after reading more on reddit, they are apparently not some of the best, but certainly pretty nice)
So to get the best possible fit and performance, the top plate cutout should be changed to accommodate durock stabilizers and other PCB-mount, screw-in stabilizers.

Done in https://github.com/bschwind/key-ripper/commit/a955e04e3e7224cf159dbc17892ad0df489ad800


Interest in new search filters for nested tags, folders, maybe other nestable things

Hello,
In getting familiar with aem, asc and java (coming most recently from c#) I've built a couple search filters for nested "sling:Folder" and "cq:Tag".  Both override a couple methods from a base AbsrtactNestedPredicate containing most of the code. It should be easy to override the base as needed for other nested resource types.
The ui is also mostly shared using sling:resourceSuperType with just 60 lines vanilla js/css. Parent/child checkbox state is propagated automatically, though I'm considering making that optional in _cq_dialog for some edge cases.
The screenshots are probably enough to gauge any interest and whether I should pursue a pull request.
Let me know if there are any questions,
Thanks

@mfyobst these looks very cool! Would def be open to a PR if its not too much trouble -- or if you had the code in an accessible repo to look at it there for compat.
One thing to caution about the folder predicate (which i was bitten by myself) is that the Search Results component (which Java-side is ~represented by the PagePredicateImpl) also has path restrictions in it - and that config is expected to be the "lowest level" path restriction for the search -- so any of the Folder criteria would need to 1) validate its under any of those paths and 2) ensure they are not OR'd together .. else any of the "sub-path" restrictions will be supeseded by the lower-level rooth paths.
niether here nor there - but what does "Children merged" mean/do? That ones not obvious to me.

Hello David,
Great, I just need to figure out business-wise if I can publish open-source and will let you know. The company I work for is in a "strategic partnership" with Adobe so it should be ok.
Thanks for the details on path restrictions, and I think explains some inconsistent search results that confused me, for example:
(/content/dam/asset-share-commons/en/site OR /content/dam/asset-share-commons/en/public/pictures) returns all child assets
(/content/dam/asset-share-commons/en/site OR /content/dam/asset-share-commons/en/public) returns empty
So if I'm getting it, OR'd path restrictions bubble up: ("a" OR "a/b/c") "a/b/c supersedes "a"; is "a/z" unaffected?
I'm of half-a-mind to just ignore as expected (but arbitrary) behavior by the framework. I try to avoid fighting frameworks, especially around security, especially when a noob.
Maybe just adding a "Allow restricted folders" checkbox: (default unchecked) invalidate a root path if it contains any restricted descendants of resourceType.
Regarding "Children Merged" checkbox, the info tip is "Merge top-level children of all root paths" which probably helps only a little. In other words, the immediate-children of all root paths are combined and listed top-level in the ui. So, "/content/dam/asset-share-commons/en/public" would display "Documents", "Media", "Pictures" top-level, instead of just "Public" which would be omitted.
Thanks for the feedback and I hope to push somewhere soon.
Max

For path restrictions i meant more:
If the the Search Results component [1] sets the base path restrictions (ex. /content/dam/asset-share-commons/en/public) that can be allowed to surface in search. So if in your component you somehow were able to set a folder selection to /content/dam/foo (which is not under /content/dam/asset-share-commons/en/public) the restriction of /content/dam/foo should get discarded. This should be taken care of if youre using the OOTB path predicate though. As part of the QuerySearchProviderImpl, .. there is some special case handling [2] that looks for path predicates coming in from query params, and makes sure anything thats passed in falls under one of the Search Results [1] paths.
If the query parameter path is allowed (its same or beneath an authored Search Resutls path; we dont want random ppl to be able to specify any path in AEM Assets and start querying it :)) - then it marks the Search Results path to be excluded from being added to the query (since we know the users picks an allowed sub-path(s) to search on -- and the PagePredicatImpl [3] skips adding the SearchResults component's path to the overall query.
Anyhow - its a bit convoluted/tricky ... not sure i have the most elegant solution for it - but i think youre good as long as you

Communicate to authors configuring the Paths component that only sub-paths of a Search Results path will work
Use the OOTB querybuilder path predicate

[1]

[2] https://github.com/adobe/asset-share-commons/blob/develop/core/src/main/java/com/adobe/aem/commons/assetshare/search/providers/impl/QuerySearchProviderImpl.java#L172-L220
[3] https://github.com/adobe/asset-share-commons/blob/develop/core/src/main/java/com/adobe/aem/commons/assetshare/components/predicates/impl/PagePredicateImpl.java#L195-L199

Gotcha on the Merge children - that makes sense ... you can create an artificial set of "root" folders, pulling from various levels of the DAM. I can definitely see this being useful.

Hello David, I finally got code pushed to: https://github.com/mfyobst/slop
Let me know when you get a chance to have a look, it definitely needs some code review for java/aem newb mistakes. There is no testing yet, but I'm looking through core\src\test\java\com\adobe\aem\commons\assetshare atm trying to figure out what's expected.

Forgot to mention, built from release 3.5.0. I'm using windows/vscode and anything newer fails with a long list of bnd-baseline version problems that has me stumped for now.

Let me take a look at it tomorrow or Friday. The bnd baseline can be nitpicky

@mfyobst It looks like your github has cherrypicked code - rather than the whole project; so what you ahve isnt a valid Maven project and/or would be merge-able (wrt to Git) into this project.
Typically, youd want to:

Fork this repo
Create a new working branch from this repo's develop branch
Put your changes in that working branch
Commit your changes
Push the working branch to your fork
PR that working branch on your fork to the this repo's develop branch

Ok, that was just a git diff > diff.patch/git apply diff.patch to an empty repo but I just forked and pushed to https://github.com/mfyobst/asset-share-commons
Note I'm still working on baseline issues:
[ERROR] Failed to execute goal biz.aQute.bnd:bnd-baseline-maven-plugin:6.3.1:baseline (baseline) on project assetshare.core: An error occurred while calculating the baseline: Baseline problems detected. See the report in C:\work\mf-asc\core\target\baseline\assetshare.core-3.8.1-SNAPSHOT.txt.
[ERROR] ===============================================================
[ERROR]   Name                                               Type       Delta      New        Old        Suggest
[ERROR] * com.adobe.aem.commons.assetshare.core              BUNDLE     MAJOR      <IP_ADDRESS>40104162143091 3.8.0      3.9.0
[ERROR]   MAJOR                BUNDLE     assetshare.core-3.8.1-SNAPSHOT
[ERROR]     MINOR              API
[ERROR]       MINOR            PACKAGE    com.adobe.aem.commons.assetshare.components.predicates
[ERROR]         ADDED          CLASS      com.adobe.aem.commons.assetshare.components.predicates.AbstractNestedPredicate
[ERROR]           ADDED        ACCESS     abstract
[ERROR]           ADDED        EXTENDS    com.adobe.aem.commons.assetshare.components.predicates.AbstractPredicate
[ERROR]           ADDED        IMPLEMENTS com.adobe.aem.commons.assetshare.components.Component
[ERROR]           ADDED        IMPLEMENTS com.adobe.aem.commons.assetshare.components.predicates.NestedPredicate
...
I've tried deleting .m2 cache folder and skipping the test with -Darguments="-Dbnd.baseline.skip=true" but no luck so far.

ahh sorry -  this is saying your change requires a bundle version bump to 3.9.0 -- and since we pin all projects to the same version for ASC, youll need to bump them all:
so run this from the root of your project:
$ mvn versions:set -DnewVersion=3.9.0-SNAPSHOT

This will touch and update all pom.xml files in the project to 3.9.0-SNAPSHOT and bnd-baseline should be happy ...
You may need to also update a package-info.java in com.adobe.aem.commons.assetshare.components.predicates but bnd-baseline will output what the correct version there is.

Thanks, that worked. Also, got skip working by updating core/pom.xml:
<plugin>
    <groupId>biz.aQute.bnd</groupId>
    <artifactId>bnd-baseline-maven-plugin</artifactId>
    <configuration>
        <failOnMissing>false</failOnMissing>
        <skip>true</skip>
    </configuration>
</plugin>

Just to be clear we don't want to skip bnd baseline recommendations - they're important ensure osgi import/exports are correct.

Got it, won't skip baseline testing. Should modified pom.xmls/pakage-infos be pushed or are they just for local dev?
Fyi, for windows/vscode/powershell I needed quotes: mvn versions:set -DnewVersion="3.9.0-SNAPSHOT"

both the POMs and package-info should be committed to Git -- these are used to build and version the artifacts and bundle exports when installed into AEM, so these version notations are part of the code base.
Ah - good to know about windows, im on macOS ... as long as the POMs are all getting updated to 3.9.0-SNAPSHOT version it's all good!


He created 10 wallet addresses, and these 10 wallet addresses were airdropped!!

Querying an address through the Ethereum browser has created 10 multi-signature addresses, and all of them have transactions. The query link is:https://etherscan.io/txs?a=0x1ee199c1832d4cfd075ad2708feb75fc8c80b8c6&p=1
eth address:
0x1ee199c1832d4cfd075ad2708feb75fc8c80b8c6
Relevant safe address:0x9aDB2404Af11Ed004B9bCcF8bb6cEBA11833E6c0
0xEaCae0A7004C3466ee1C86aFFB08b738e6B11a2f
0xA123ee02e6673C2Ef0A7bfBde35956804EE6fc12
0x8c22A00a94F1FbB870ab65E4a30530Eb253Bc1fa
0x2fd8fff98f6fEa01d1d4E33262a6a9C70e4697Bd
0xa159AFEc31851B754AECA1be5c914eaA2eEf31a8
0x7524fbBB8a654eDe614dDec64Bf809240016Af27
0xA549cA95fBd5785d56029029d6D93Ad8D716e1dD
0x1413fbdee7f7547d8e35cAFAFde97Cf8aeEB59C8
0x2e016964119fCfb4F77Bee3A057152dBA9F89E9a
My Safe Address：eth:0xab31c9A6504b82ec0B1021a8b294eBE04D3bFB4e

Please elaborate on why these are safes created for airdrop farming. Just the fact that 1 addresses created all of them doesn't qualify.
If e.g. a wallet uses a relayer to create Safes, the relayer would be the account that created all user Safes which is not airdrop farming per se.
Also this report is of very low quality and hard to read. Please use the provided issue template.

Please check here
https://github.com/safe-global/safe-user-allocation-reports/issues/66

We haven't received any further information on this ticket and therefore deemed this submission invalid.
Unfortunately just the pure fact that Safes...

were created by the same address
have the same owner
conducted the same transactions
received assets from the same address

... is not enough reasoning for a valid submission, as there are legit user behaviour leading to such as well (relayer, scripts, power users, exchanges)
This submission didn't provide sufficient indicators to convince the team that there is some targeted airdrop farming behind the provided addresses. As per the rules, when in doubt we will default in favor of the airdrop recipients in order to not risk any false positives when sorting out airdrop hunters.


HIP-134 unique connections

HIP-134
proto PR

Summary
If a wifi hotspot has >25 unique connections of a 7 day rolling period, it automatically gets a 1x Oracle Boosting multiplier.
It is are exempt from Service Provider Banning.
Update Coverage Point Calculator

Added OracleBoostingStatus::Qualified variant.

This variant is constructed when a wifi radios has >25 unique connections over a 7 day rolling period as submitted by the CDR processing service to the ingestor.
New Ingestor

Added UniqueConnectionsIngestor.

Verifies  a unique_connections_ingest_report_v1 carrier_key, writes out verified_unique_connections_ingest_report_v1 and saves unique counts to mobile-verifiers db for next rewards epoch.
New db table

Added unique_connections table

Stores unique connection reports received from the CDR processing service. Counts represent unique connections for a wifi hotspots over a 7 day rolling period.
The rewarder clears this table after rewarding keeping a days extra worth of data for reprocessing.

Got a clippy issue


extend metrics for github and provider executions

This PR add couple of new metrics to count interactions with the github API and external provider binaries.
i've followed the recommendation of the prometheus-folks when it came to metrics for this kind of problem: https://promlabs.com/blog/2023/09/19/errors-successes-totals-which-metrics-should-i-expose-to-prometheus/#recommended-for-binary-outcomes-exposing-errors-and-totals
provider binary example metrics:
# HELP garm_runner_operations_total Total number of instance operation attempts
# TYPE garm_runner_operations_total counter
garm_runner_operation_total{operation="CreateInstance",provider="kubernetes_external"} 2
garm_runner_operation_total{operation="DeleteInstance",provider="kubernetes_external"} 2

github api call example metrics:
# HELP garm_github_errors_total Total number of failed github operation attempts
# TYPE garm_github_errors_total counter
garm_github_errors_total{operation="GenerateOrgJITConfig",scope="Organization"} 2
# HELP garm_github_operations_total Total number of github operation attempts
# TYPE garm_github_operations_total counter
garm_github_operations_total{operation="GenerateOrgJITConfig",scope="Organization"} 2
garm_github_operations_total{operation="ListOrganizationRunnerApplicationDownloads",scope="Organization"} 2
garm_github_operations_total{operation="ListOrganizationRunners",scope="Organization"} 1
garm_github_operations_total{operation="RemoveRunner",scope="Organization"} 4

towards #181
TODO:

[x] document new metrics
[ ] discuss golangci.yml with metrics linter
[ ] do a second round and search for all github api calls

This looks good to me. All this makes me think we might benefit from some telemetry as well. Maybe in a future release we could leverage OpenTelemetry.
I could merge this if you're satisfied with it. Let me know. If you're still working on it, feel free to convert it to draft so I don't accidentally merge it prematurely 😁

OpenTelemetry is definitely (IMHO) the next thing when it came to observability. TBH i didn't spend that much time into it to understand how/what we need on our side to use it within our company internal managed prometheus service.
But as you said, something totally different and unrelated to this PR.
Will convert the PR to draft to finalize it tomorrow morning (especially the second round of looking for external api-calls).

OpenTelemetry is definitely (IMHO) the next thing when it came to observability. TBH i didn't spend that much time into it to understand how/what we need on our side to use it within our company internal managed prometheus service.
But as you said, something totally different and unrelated to this PR.

definitely something for future releases, not even for the next one. otel allows us to trace calls throughout the codebase and allows us to add context to those traces, like what we're calling functions with, what error they return. With that info, we can then generate detailed graphs of how a call traveled throughout the code base. Further more, this can be correlated even with external providers.
But again, this is for much further into the future. For now, and especially in this PR, metrics are the focus.


implemented inspect element context menu as per #9

I created a separate file debug-context-menu.js that handles all operations that occurs  in renderer process, to be able to require it in renderer via executeJavaScript.
I hope you're ok with this, otherwise we have to put all the code inside a string template (I think this is ugly)...
I also wrote a test.js file that open two BW on google and github, just to test the stuff:
I didn't include this in PR to avoid polluting the package. Do you prefere to include it?
test.js:
'use strict';
require('.')();

var app = require('app');
var BrowserWindow = require('browser-window');

app.on('ready', function () {
	var win = new BrowserWindow({width: 800, height: 600});
	win.loadUrl('https://github.com');
	win.show();

	var win2 = new BrowserWindow({width: 800, height: 600});
	win2.loadUrl('https://google.com');
	win2.show();
});

Looks good. Thanks :)

You're welcome, it was a pleasure...


Minrelayfee func

Added MinRelayFee func to walletkit_client.go.
Pull Request Checklist

[x] PR is opened against correct version branch.
[ ] Version compatibility matrix in the README and minimal required version
in lnd_services.go are updated.
[x] Update macaroon_recipes.go if your PR adds a new method that is called
differently than the RPC method it invokes.

Can you squash the commits? Then I think we can merge this. Or is anything else missing here? Just waiting to confirm everything works in tapd?

Just waiting to confirm everything works in tapd?
Exactly. All seems to work. So we have a cascade of PRs depending on this one.


[HOTFIX] Fix missing verbosity argument from methods.

The verbose argument was removed from multiple functions with the
commit b6de530d09d5325c31192e27331da8fd3f2c6b60. Seems like the call
for this method wasn't removed from the install.py module. The hotfix
Allows hyperledger composer to be installed.

Removing pull request to create another with the signed off commit.


Adding MAX_MSP Namespace for Max's Global Constructors, and Dependency Updates

Some of Max's constructors (Like Buffer) are being overwritten by variables that get bundled in from third-party dependencies.  This change defines all of the Max Constructors at the top of the file, namespaced inside the object MAX_MSP so that they can still be used:
const myBuffer = new MAX_MSP.Buffer('myBuffer');
I was also getting a few warnings after using the build command, so I updated the dependencies to use the latest versions.  I had to make a new branch of rollup based on the latest version and then cherry-picked your commit to support the c74max format:
"rollup": "github:devanecondition/rollup#fde/max_target-latest",

Awesome thanks much for the PR. Generally makes sense to me. Will take a closer look / review this week.

I merged this into fde/dep_update for now. There is some more stuff to work on and I'd like to identify a general path moving forward on how to handle / separate bundling vs transpiling. Will ticket


WIP: add Alpine Dockerfile

Hello hello,
I took the freedom to create an Alpine based Dockerfile. It is WIP. The only file which should be reviewed is ./Alpine/16/Dockerfile.
This should fix #78
The Dockerfile is not yet 100% optimized in terms of Docker best practices. And image size, hence, I used a trick to copy everything into a SCRATCH base image in the end, but that could be improved, if the image works as intended.
I tested:

Bootstrapping: InitDB, recovery, pg_basebackup
Replica mode set to true and promotion
Scheduled backups
Barman cloud backup for WAL

I uploaded the image also in Dockerhub, so you do not need to build it yourself :)
docker pull  docker.io/sando38/cnpg-postgres:16.2-1-alpine

ToDos:

Integrate into the CI process/ repository structure
Test other Postgres versions <16
Test other scenarios I haven't tested yet
Test performance of the image variant

Let me know what you think!

Hi @sando38 Thank for awesome work, If you check the alpine packages registry, there is "barman" package available,
what your opinion about use that packages from registry or compile from source is best option.

Thanks for the feedback.
I compiled barman from source to avoid the installation of unrequired dependencies as the postgres base image contains them already. And I wanted to avoid, that a potential incompatible version of pg-client is being installed by the barman package, plus the package is only in the edge repository.

Thanks for the feedback.
I compiled barman from source to avoid the installation of unrequired dependencies as the postgres base image contains them already. And I wanted to avoid, that a potential incompatible version of pg-client is being installed by the barman package, plus the package is only in the edge repository.

Thank you @sando38
If I want to use this image that you have published for testing purpose, i have to refer this image and then install other packages, like this one
FROM docker.io/sando38/cnpg-postgres:16.2-1-alpine
USER root
RUN apk add timescaledb OR Compile from source (use multi stage build)
USER 26

right?

Yes, that is correct.

Are there any updates on this PR? This is good work!


Cherrypick #24606 to 2.44.0 release branch (disallow sliding windows in Python fanout combiner per key)

Mitigates #20528 for this release

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Python_Internal PreCommit

Python_Internal appears to be disabled now, so a re-run is not possible by phrase. I assume it is not a relevant result.

retest this please

Python_Internal appears to be disabled now, so a re-run is not possible by phrase. I assume it is not a relevant result.

That's correct, that is a job I was working on enabling but haven't gotten green


getReadableVersion is returning the versionCode/buildNumber

Bug
Environment info

React native info output:
System:
    OS: macOS 10.14.6
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
    Memory: 274.65 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 12.4.0 - ~/.nvm/versions/node/v12.4.0/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/.nvm/versions/node/v12.4.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
    Android SDK:
      API Levels: 22, 23, 24, 25, 26, 27, 28
      Build Tools: 23.0.1, 23.0.2, 23.0.3, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.2, 28.0.3, 29.0.0
      System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Google APIs Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-25 | Google Play Intel x86 Atom, android-26 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
    Xcode: 10.3/10G8 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.0 => 0.60.0

Library version: 2.3.2
Steps To Reproduce

just call DeviceInfo.getReadableVersion()
...

Describe what you expected to happen:

My app versionName on Android and Version on iOS is 1.0.1
My versionCode on Android and buildVersion on iOS is 1
getReadableVersion is returning <IP_ADDRESS>
I'm expecting 1.0.1 only.

might be a doc bug or an implementation issue depending on point of view.
would be a breaking change to alter it at any rate
how do getBuildId() and getVersion() suit you?

@mikehardy thanks for your reply.
getVersion does return 1.0 as in the example, but I'd not be sure where to change that value.
getBuildId is not an option for me.
BTW, on a previous app, I used version 0.24.3 and I got the expected result. I know it's an old version but the example output is the same: 1.0.1.

I dunno, looks like it's just concatenating them https://github.com/react-native-community/react-native-device-info/blame/master/deviceinfo.js#L432
I'm 99% tempted to call this "not a bug" except the docs are definitely not clear on the point, which is certainly not great. Care to make a docs PR that clarifies in the README how this works, in a way that you'd expect what you get?

It is a bug. It doesn't match with android's view of versioning https://developer.android.com/studio/publish/versioning

no response

@mikehardy thanks for your patience. getVersion doesn't work for me, because I want to display the version like 1.0.0.
IDK if I should open a PR to change the docs since it may be a bug.

Your response makes me feel as if you weren't listening, or I wasn't explaining myself well.
getReadableVersion is implemented as getVersion() + '.' + getBuildNumber() effectively https://github.com/react-native-community/react-native-device-info/blob/master/deviceinfo.js#L432
So I don't believe you have a bug. You want getVersion(). You might just want to PR an update to the docs.

@mikehardy the last time I tried getVersion it returned 1.0 and my app's version used to be 1.0.0. I just tried it and now it returned 1.0.0 so, I think getVersion does work for me. Thank you so much.

whew :-), glad it works


Problem with upgrade under OSX arm64

doing a docker compose up -d I get the following warning and error message. Deleting all containers / volumes make the error disappear (obviously)
WARN[0466] volume "ovos_vosk" already exists but was created for project "ovos" (expected "compose"). Use `external: true` to use an existing volume
WARN[0466] volume "ovos_nltk" already exists but was created for project "ovos" (expected "compose"). Use `external: true` to use an existing volume
WARN[0466] volume "ovos_listener_records" already exists but was created for project "ovos" (expected "compose"). Use `external: true` to use an existing volume
WARN[0466] volume "ovos_models" already exists but was created for project "ovos" (expected "compose"). Use `external: true` to use an existing volume
[+] Running 0/0
 ⠋ Container ovos_messagebus  Creating                                                                                0.0s
 ⠋ Container ovos_cli         Creating                                                                                0.0s
Error response from daemon: Conflict. The container name "/ovos_cli" is already in use by container "57513d619d519c3a8b1bacb8479a69fbad920864dd5ff49a1c43f3b6a7de06ec". You have to remove (or rename) that container to be able to reuse that name.

docker info:
$ docker info
Client:
 Version:    24.0.2
 Context:    desktop-linux
 Debug Mode: false

docker-compose.macos.yml file should be used when running on Mac OS.
https://github.com/OpenVoiceOS/ovos-docker#mac-os


How does this routes setting work?

Saw following settings from the doc, seemed like it could capture all requests to /api and redirect those to a file named my-api.js, I gave that a try but ran into errors with now complaining about my-api.js did export a react component, did I put my-api.js in the wrong place?
{
  "routes": [
    { "src": "/api", "dest": "/my-api.js" },
  ]
}

This is currently recommended way to setup routing. Although I couldn't make it work with Now v17+.

I tried 'redirects' but still  no dice...

I tried 'redirects' but still no dice...

If you happen to use Now CLI V17+ then maybe you can try to go back to V16.x and see if routes work for you then.

Ended up what I wanted to do can be achieved by dyanamic API routes, thanks for helping out though! 🙌


feat: allow extra attribute for fields

Description
This allows you to add "extra:" as an attribute to any fields. Example:

Why this is useful
Copied from discord: https://discord.com/channels/967097582721572934/1092895968623591444
The goal is to be able to read extra information information through a plugin.
E.g. something like:
{
            name: 'textArea',
            type: 'textarea',
            extraInfo: {
              someKey: "val"
            }
},

So I can do stuff like:
Find all fields of a CollectionConfig which have value XX for key XY

[X] I have read and understand the CONTRIBUTING.md document in this repository

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have added tests that prove my fix is effective or that my feature works
[X] Existing test suite passes locally with my changes
[ ] I have made corresponding changes to the documentation

This is a duplicate. See GH-2436

This is a duplicate. See GH-2436

Wow, what a coincidence – completely missed that one! Thank you!


Enforce taint key and value restrictions (fixes #751).

this PR needs rebasing to pass CI (needs to pick up e2e notifications)


Allow deploying subdomains for the same reserved name in name gateways

Is your feature request related to a problem? Please describe

Prevent reserving names every time we need to get a subdomain
Allow having subdomain for the reserved names

Describe the solution you'd like
Related issue: https://github.com/threefoldtech/zos/issues/2354

Reverted bacause ssl cerificates aren't allowed for subdomains


Segfault in eigenvalue computation

julia> using ToeplitzMatrices

julia> using ArbNumerics

julia> using LinearAlgebra

julia> using GenericLinearAlgebra

julia> n = 200
200

julia> x = rand(-1:2:1, n+1);

julia> T = Toeplitz{Int}([x[[2,1]]; zeros(Int, n-2)], x[2:(n+1)]);

julia> A = Matrix{ArbFloat}(T);

julia> Base.nextfloat(x::ArbFloat) = x + eps(x)

julia> @time eigvals(A)
error: ulp error not defined for special value!

signal (6): Abort trap: 6
in expression starting at no file:0
__pthread_kill at /usr/lib/system/libsystem_kernel.dylib (unknown line)
Allocations: 202080912 (Pool: 202077977; Big: 2935); GC: 424
[1]    8377 abort      julia --check-bounds=yes

I added ulps last night, I have not released a new version because github is wonky.
let me try what you did with latest  ...

Ok, I found the problem (or the first problem?) The Arb C library considers NaN, Inf and 0 "special values" .. in this case it is looking for ulp(0).   Do you know how ulp(0) / eps(0) is used in the matrix code?

It's my definition of nextfloat via complex square root. E.g.
julia> using ArbNumerics

julia> Base.nextfloat(x::ArbFloat) = x + eps(x)

julia> sqrt(complex(ArbFloat(1.0)))
error: ulp error not defined for special value!

signal (6): Abort trap: 6
in expression starting at no file:0
__pthread_kill at /usr/lib/system/libsystem_kernel.dylib (unknown line)
Allocations: 3545619 (Pool: 3544803; Big: 816); GC: 6
[1]    10397 abort      julia

In  GenericLinearAlgebra/src/eigenGeneral.jl:266
this happens
julia> eigvals(A)
ERROR: TypeError: in setindex!, in typeassert, expected Complex{ArbFloat{128}}, got ArbComplex{128}
Stacktrace:
 [1] setindex!(::Array{Complex{ArbFloat{128}},1}, ::ArbComplex{128}, ::Int64) at ./array.jl:769
 [2] #_eigvals!#29(::ArbFloat{128}, ::Function, ::GenericLinearAlgebra.Schur{ArbFloat{128},Array{ArbFloat{128},2}}) at /home/jas/.julia/packages/GenericLinearAlgebra/src/eigenGeneral.jl:266
 [3] _eigvals! at /home/jas/.julia/packages/GenericLinearAlgebra/src/eigenGeneral.jl:251 [inlined]
 [4] #_eigvals!#23(::Base.Iterators.Pairs{Symbol,Bool,Tuple{Symbol,Symbol},NamedTuple{(:permute, :scale),Tuple{Bool,Bool}}}, ::Function, ::Array{ArbFloat{128},2}) at /home/jas/.julia/packages/GenericLinearAlgebra/src/eigenGeneral.jl:241

I don't know what to make of
setindex!, in typeassert, expected Complex{ArbFloat{128}}, got ArbComplex{128}
In the Arb C Library, the Complex type is not JuliaBase.Complex{ArbFloat{N}}, it is ArbComplex which is a pair of ArbFloat{N}s but not quite organized as Complex{ArbFloat{N}} would be.
Any ideas?

Are you using master of GenericLinearAlgebra? In any case, I think the example in the post right above in https://github.com/JeffreySarnoff/ArbNumerics.jl/issues/11#issuecomment-431939745 is the culprit.

I found the conflict.  In GenericLinearAlgebra/src/eigenGeneral.jl around line 250
function _eigvals!(S::Schur{T}; tol = eps(real(T))) where T
    HH = S.data
    n = size(HH, 1)
    vals = Vector{complex(T)}(undef, n)

vals is created as a vector of elements of type complex(T) where T, with ArbFloats is ArbFloat{N}.
so typeof(vals[i]) == Complex{ArbFloat{N}}
then around line 265
            vals[i] = x + y

where typeof(x), typeof(y), typeof(x+y) are all ArbComplex{N}

adding this to ArbNumerics is the fix
 Base.complex(::Type{ArbFloat{P}}) where {P} =ArbComplex{P}

I set n=5 and made that change locally
eigvals(A)
  1.350727532566863262096914237033 + 2.022949336645996775550965569813im
  1.350727532566863262096914237033 - 2.022949336645996775550965569813im
                                0.2473871490728637677284417719064 + 0im
 1.025578892896704854038864877013 + 0.5608503498404175266457114825999im
 1.025578892896704854038864877013 - 0.5608503498404175266457114825999im

v0.2.4 is now out in the weeds --
I deleted it on github unintentionally, but I have the whole version repo locally.
the current just tagged version is v0.2.5
let me know if I should do something with the local copy of v0.2.4 (170Mb tar.gz)

Great. I've just tested it and it works. Thanks for the prompt fix. I tried to time this and compare to BigFloat and they take about the same time. Is that expected?

v0.2.4 is now out in the weeds

It would be great if you could add the tag again at https://github.com/JuliaLang/METADATA.jl/blob/metadata-v2/ArbNumerics/versions/0.2.4/sha1 such that things won't break.

I am happy to do that -- don't know how.  Tell me what steps to follow.
My timings for arithmetic and elementary functions relative to BigFloat were 3x (better for *).  That was months ago.  I just got a speed issue though -- https://github.com/JuliaMath/DoubleFloats.jl/issues/31 -- somehow, while my mulitiplication is faster than DoubleDouble's, the addition is 15% slower .. I will see what happens when I do what DoubleDouble does (there are two choices of approach, one involves branching on magnitude comparison the other does not branch but requires an addition (+ this - that) correction.  Apparently the a>b ? _ : _ way runs quicker.  So I will change that and test the timing.   I really don't know why the matrix manipulations are taking as much time as they are .. it should really outstrip BigFloat.  It does seem that there is something that is done with matrix multiply that takes time that pairwise multiply does not -- do share any more specific insight into where the unexpected cost is incurred while matrix multiplying.

Is it easier to get 0.2.4 back if give you read/write permission?

It is pretty easy to do with the GitHub UI but I'd be happy to do it if you give me write access.
If can get more insight to where the time is spent, I'll share it with you.

https://github.com/JeffreySarnoff/ArbNumerics.jl/invitations
On Tue, Oct 23, 2018 at 5:29 AM Andreas Noack<EMAIL_ADDRESS>wrote:

Is it easier to get 0.2.4 back if give you read/write permission?
It is pretty easy to do with the GitHub UI but I'd be happy to do it if
you give me write access.
If can get more insight to where the time is spent, I'll share it with you.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/JeffreySarnoff/ArbNumerics.jl/issues/11#issuecomment-432171127,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABmqxpQ64P7rk8pgnGmm2uOpKi4Eh8M_ks5unuF6gaJpZM4Xz3ld
.

I've reapplied the tag.

I have tracked an unexpected increase in constructor allocations relative to ArbFloats (1.5x).
An early decision to adopt Nemo's way of constructing Arb values in leu of my own needs undoing.
After that change, if the allocations decrease, then I can approach throughput.


Possible bug in example code

In this snippet
https://github.com/microsoft/react-native-windows-samples/blob/fd8310144083733eec02d1dde18032aea02f6faa/docs/windowsbrush-and-theme.md?plain=1#L53-L59
is it correct to call addChangeListener in response to componentDidMount and componentWillUnmount?

Yep, that's wrong. Should be a removeChangeListener. Whoops!

I'm just learning so apologies, but in the 'not-Windows' React Native there is no removeChangeListener
https://reactnative.dev/docs/appearance
and in the Windows codebase there is addListener and removeListeners with an 's'.
https://github.com/microsoft/react-native-windows/blob/b051774f5429ed49df69e0b85ae16cfae8c18922/vnext/codegen/NativeAppearanceSpec.g.h#L17
Is that relevant?


Model not found in cache or in root at ./diabetes-model

Hello,
Following the different steps of the Azure Pipeline, I got this issue :
"message": "Service deployment polling reached non-successful terminal state, current service state: Unhealthy\nOperation ID: e9252f0d-81f8-44e5-bd6d-983076eca1f5\nMore information can be found using '.get_logs()'\nError:\n{\n  "code": "DeploymentTimedOut",\n  "statusCode": 504,\n  "message": "The deployment operation polling has TimedOut. The service creation is taking longer than our normal time. We are still trying to achieve the desired state for the web service. Please check the webservice state for the current webservice health. You can run print(service.state) from the python SDK to retrieve the current state of the webservice."\n}
Looking for the logs with get_logs(), I extract this part of the message :
Model not found in cache or in root at ./diabetes-model
The az CLI command is the following :  az ml model deploy -n diabetes-qa-aci -f model.json --ic config/inference-config.yml --dc config/deployment-config-aci.yml --overwrite -v
And model.json is created by the previous step and contains :
{
"cpu": "",
"createdTime": "2020-06-09T04:57:54.550301+00:00",
"description": "",
"experimentName": "diabetes-exp",
"framework": "Custom",
"frameworkVersion": null,
"gpu": "",
"id": "diabetes_reg_model:2",
"memoryInGB": "",
"name": "diabetes_reg_model",
"properties": "",
"runId": "diabetes-exp_1591678184_b25da442",
"sampleInputDatasetId": "",
"sampleOutputDatasetId": "",
"tags": "",
"version": 2
}
Any idea ?

The model name is hard coded in the score.py function :
model_path = Model.get_model_path('diabetes-model')
Is there a way to variabilize it ?

in a nutshell, I would say it's not really possible to do so. There has to be a model name (which corresponds to what you would have registered to Azure Machine Learning in the devops pipeline. That exact name has to be reused there to rehydrate the model when the init function runs.


Device provisioning process

The 8-step diagram shown in this document seams different from the flow diagram in the following document: https://docs.microsoft.com/en-us/azure/iot-dps/media/concepts-auto-provisioning/sequence-auto-provision-device-vs.png
It will be helpful if these two diagrams can be consolidated into a single, uniformed process flow for easy understand.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f21f48a7-a140-b21f-e699-df8e9fb000a9
Version Independent ID: 32965fad-9f8b-81b2-ac3d-d532b517182b
Content: Overview of Azure IoT Hub Device Provisioning Service
Content Source: articles/iot-dps/about-iot-dps.md
Service: iot-dps
Product: unspecified
GitHub Login: @nberdy
Microsoft Alias: nberdy

@vxjen We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Short solution needed: "Set key in Redis" (redis)

Please help us write most modern and shortest code solution for this issue:
Set key in Redis (technology: redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Set key value in Redis


always point to the latest stable links

I cannot test it, but would be nice to have it tested. Not sure if we can use defined strings, though. Otherwise I will replace them with the latest links.

makes sense :+1:

Tested, works.

Thanks.


bollards completely block connected way segments

Suppose a way defined by
a - b - |c| - d - e
where node c is a bollard. Routing from a to a point within b-c is not possible at the moment. The segment b - c is completely blocked. The same applies to  c - d.
Routing from a point within b - c in direction to point a is possible. So the problem is direction sensitive.

need to split the way at barriers?

Should be easy to fix. Thanks.

Fixed. Change will be pushed to master repo shortly.


Fix Cypress Form Submission

Replaced cy.get('form').submit() with cy.get('button[type="submit"]').click()
This fixed the issue with form submission, but now tests are failing for other reasons. (ie. changes to the exit survey and not seeing game loading screen.)
If you can take a look @kepstein23 and see if this solves what you were initially struggling with?

I should've told you yesterday, but we did manage to solve that problem by using cy.get('button[type="submit"]').click(). The most up to date cypress tests are on the simplify-tests branch but they're getting stuck on No experiments available so we're passing that issue onto Nicolas. Thanks for taking a look!


Cleanup the output from the gitea internal hooks

Some gitea hook output "Processing 2 references" is a little noisy, so let's cleanup them.
Want to fix #23364

Codecov Report

Merging #23389 (6e1c5bc) into main (8cadd51) will decrease coverage by 0.01%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main   #23389      +/-   ##
==========================================
- Coverage   47.61%   47.61%   -0.01%
==========================================
  Files        1147     1147
  Lines      151225   151185      -40
==========================================
- Hits        72002    71982      -20
+ Misses      70709    70694      -15
+ Partials     8514     8509       -5

Impacted Files
Coverage Δ

cmd/hook.go
7.64% <ø> (+0.55%)
:arrow_up:

modules/git/error.go
28.57% <0.00%> (-24.29%)
:arrow_down:

modules/util/io.go
73.68% <0.00%> (-5.27%)
:arrow_down:

models/activities/repo_activity.go
61.50% <0.00%> (-4.61%)
:arrow_down:

modules/charset/charset.go
71.73% <0.00%> (-3.63%)
:arrow_down:

modules/git/repo.go
64.44% <0.00%> (-3.56%)
:arrow_down:

modules/queue/queue_channel.go
84.26% <0.00%> (-1.13%)
:arrow_down:

services/pull/pull.go
42.22% <0.00%> (-0.32%)
:arrow_down:

models/issues/review.go
52.73% <0.00%> (+0.56%)
:arrow_up:

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ovrUtilities.is_oculus_quest_1_device does not exist

I had to comment out the two lines at startup in vr_autoload that do the following logging:
	log_info(str("      is_oculus_quest_1_device: ", is_oculus_quest_1_device()));
	log_info(str("      is_oculus_quest_2_device: ", is_oculus_quest_2_device()));

This looks like it could be an updated function in a more recent version of the godot_ovrmobile addon asset than comes in the AssetLib (v 3.0.1)?  Have I got that right?
I prefer not to commit that binary libraries into my source code repo.  Is there a way to read the version of the library that's loaded and give an warning that it is less than what your toolkit expects?

yes; there is a gap between the official oculus mobile plugin and what is supported in the toolkit; the toolkit is based on a branch (you can find it here: https://github.com/NeoSpark314/godot_oculus_mobile). One of the reasons for the branch is that the Mixed Reality Capture support is not yet ported into the official oculus mobile plugin. So there are some differences on the API and which functions are exported.

There's a really huge difference between these versions.  I copied the addons/ovr_mobile file across as you can see...

Now that I deleted the backup Dgodot_ovrmobile directory it worked (I'm after the hand-tracking).
What is the right thing to do?  I originally had the OQ_Toolkit not in my repo, but then my project wouldn't open when it's not AssetLib imported in, so I copied across just that directory of source code files.  I've not been able to see the best way to handle these dependencies.
Given how easy it is to get into this pickle, at the very least we need some detection and warning about what needs to be fixed.  Maybe an error message if the expected functions are not in the library telling us where to get it from for the time being.

currently the best thing to do is to use the ovrmobile version that is part of the OQ_Toolkit here on this repository https://github.com/NeoSpark314/godot_oculus_quest_toolkit/tree/master/addons/godot_ovrmobile; this is what I test with when developing
For the assetlib I'm not sure but I hope it also just includes the correct version of the ovrmobile from this repo here but I need to check this...


where are the requirement yml files?

As the title states, our team is wondering where the mentioned requirement yaml files are?

Requirements
TF-C has been tested using Python >=3.5.
For the baselines, we have not managed to unify the environments due to the large divergence in original baseline implementations. So you need to build three different environments to cover all six DL baselines. For ts2vec, use ts2vec_requirements.yml. For SimCLR, because Tang et al. used TensorFlow framework, please use simclr_requirements.yml. For the other four baselines, use baseline_requirements.yml. To use these files to install dependencies for this project via Conda

I am also confused about this...

I can't find it either

Hi, the requirement file has been uploaded. Thanks.


Updating team.mdx page

The previous version is fairly old and out dated.
Me and Daniel are now full time of our respective teams.
Jacob changed teams and is now a research at the EF and not full time on Portal/Trin
Konrad changed jobs I remember Kim telling me at Boulder
Perama Contributed a lot to Glados and Trin so I think he should be on 3rd party

Asking for review @carver @njgheorghita @jmcook1186

can you move the PR to dev instead of master?
The we'll check the dev preview and batch merge this week's updates to master in one PR.

@jmcook1186 ok I switched to dev


Remove NumericalIntegration.jl

Purpose

Removes dependency on NumericalIntegrations.jl, which has deprecated dependencies. Instead we simply re-implement the necessary functionality for Simpson rule integration.
To-do

Content

[ ] I have read and checked the items on the review checklist.

Thank you for doing this. I'm not sure it is finished yet but it looks already good. There are two minor comments about Julia dependency and the placement of the new function.


Missing PyTorch in the requirements.txt?

Hi there. Congratulations on the release. The platform looks great.
After following the installation guide for MonoBeast
$ conda create -n torchbeast python=3.7
$ conda activate torchbeast
$ pip install -r requirements.txt

and running
python -m torchbeast.monobeast --env PongNoFrameskip-v4

I'm getting the following error ModuleNotFoundError: No module named 'torch'.
Looks like you're missing the torch prerequisite in the requirements.txt for the new torchbeast conda environment.

Hey Mikayel, thanks for the kind words!
You're absolutely right. We avoided adding PyTorch to requirements.txt in order to let users choose their preferred version, and because the installation for PolyBeast on Linux requires a special version of PyTorch due to binary incompatibilities. In https://github.com/facebookresearch/torchbeast/commit/7b5dd9a477fd7258ec7d582e08f3d8c04d2ac156 we added a PyTorch installation command to the installation guide.
Thanks for telling us and have fun using TorchBeast!


build(deps-dev): Upgrade dev dependencies

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Replace the native-base with the react-native View component.

Description
Description of the feature or fix with link to the issue if existing
On what platform have you tested the change?

[ ] Android - Emulator
[ ] Android - Physical device
[x] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Please attach screenshots showing the change if relevant
Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevant
[ ] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

Just curious... what was the reason for using View from native-base in the first place? And why change now?


AL:GO! Creates Folder but returns error - Can not resolve workspace folder

AL:Go! asks for the folder, creates the folder and HelloWorld project files (except the launch.json), then in the EXPLORER shows a slash over the folder icon with an error saying : "Can not resolve workspace folder", it also returns multiple errors in the PROLEMS tab below, it asks for the server then completes
I've tried this running VSC as administrator and not.
To Reproduce
Steps and to reproduce the behavior:

Press SHIFT-CTRL-P
Enter or Select:  AL: GO!
Enter a folder name
Enter a server

Expected behavior
As soon as you enter the requested folder name the PROBLEMS tab starts filling in with:
[Error - 3:21:34 PM] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'workspace/didChangeConfiguration' failed with error: 'Invalid URI: The format of the URI could not be determined.'
Details:
System.UriFormatException: Invalid URI: The format of the URI could not be determined.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.PathUtilities.CreateUriFilePath(String filePath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\PathUtilities.cs:line 394
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.CreateProjectInfo(String projectPath, String assemblyName, CompilationOptions options, ParseOptions parseOptions, String packageCachePath, String[] probingFolders, String ruleSetPath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 648
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.SetCurrentProjectFromPath(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, List`1& projectLoadingDiagnostics) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 137
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.TrySetCurrentProject(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, IList`1& diagnostics, Boolean& missingManifest, Boolean& missingSymbols) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 74
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ProjectRequestHandler`1.TrySetCurrentProject(SettingsRequest request, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ProjectRequestHandler.cs:line 36
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.DidChangeConfigurationRequestHandler.HandleAsync(SettingsRequest request, Int32 requestId, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\DidChangeConfigurationRequestHandler.cs:line 69
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.<HandleAsync>d__9.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 43
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.<Process>d__6.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 64

[Error - 3:21:34 PM] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/setActiveWorkspace' failed with error: 'Invalid URI: The format of the URI could not be determined.'
Details:
System.UriFormatException: Invalid URI: The format of the URI could not be determined.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.PathUtilities.CreateUriFilePath(String filePath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\PathUtilities.cs:line 394
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.CreateProjectInfo(String projectPath, String assemblyName, CompilationOptions options, ParseOptions parseOptions, String packageCachePath, String[] probingFolders, String ruleSetPath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 648
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.SetCurrentProjectFromPath(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, List`1& projectLoadingDiagnostics) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 137
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.TrySetCurrentProject(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, IList`1& diagnostics, Boolean& missingManifest, Boolean& missingSymbols) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 74
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ProjectRequestHandler`1.TrySetCurrentProject(SettingsRequest request, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ProjectRequestHandler.cs:line 36
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.SetActiveWorkspaceRequestHandler.HandleAsync(SettingsRequest request, Int32 requestId, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\SetActiveWorkspaceRequestHandler.cs:line 24
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.<HandleAsync>d__9.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 43
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.<Process>d__6.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 64

[Error - 3:21:40 PM] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/setActiveWorkspace' failed with error: 'Invalid URI: The format of the URI could not be determined.'
Details:
System.UriFormatException: Invalid URI: The format of the URI could not be determined.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.PathUtilities.CreateUriFilePath(String filePath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\PathUtilities.cs:line 394
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.CreateProjectInfo(String projectPath, String assemblyName, CompilationOptions options, ParseOptions parseOptions, String packageCachePath, String[] probingFolders, String ruleSetPath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 648
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.SetCurrentProjectFromPath(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, List`1& projectLoadingDiagnostics) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 137
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.TrySetCurrentProject(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, IList`1& diagnostics, Boolean& missingManifest, Boolean& missingSymbols) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 74
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ProjectRequestHandler`1.TrySetCurrentProject(SettingsRequest request, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ProjectRequestHandler.cs:line 36
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.SetActiveWorkspaceRequestHandler.HandleAsync(SettingsRequest request, Int32 requestId, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\SetActiveWorkspaceRequestHandler.cs:line 24
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.<HandleAsync>d__9.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 43
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.<Process>d__6.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 64

[Error - 3:21:41 PM] Please report this issue to https://github.com/microsoft/al/issues including information on how to reproduce it, if possible.
Processing of message 'al/setActiveWorkspace' failed with error: 'Invalid URI: The format of the URI could not be determined.'
Details:
System.UriFormatException: Invalid URI: The format of the URI could not be determined.
   at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind)
   at Microsoft.Dynamics.Nav.CodeAnalysis.Utilities.PathUtilities.CreateUriFilePath(String filePath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.CodeAnalysis\Utilities\PathUtilities.cs:line 394
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.CreateProjectInfo(String projectPath, String assemblyName, CompilationOptions options, ParseOptions parseOptions, String packageCachePath, String[] probingFolders, String ruleSetPath) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 648
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.SetCurrentProjectFromPath(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, List`1& projectLoadingDiagnostics) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 137
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.VsCodeWorkspace.TrySetCurrentProject(String projectPath, String packageCachePath, String[] assemblyProbingPaths, String ruleSetPath, IList`1& diagnostics, Boolean& missingManifest, Boolean& missingSymbols) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\VsCodeWorkspace.cs:line 74
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.ProjectRequestHandler`1.TrySetCurrentProject(SettingsRequest request, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\ProjectRequestHandler.cs:line 36
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.LanguageServer.Extensions.SetActiveWorkspaceRequestHandler.HandleAsync(SettingsRequest request, Int32 requestId, CancellationToken cancellationToken) in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\LanguageServer\Extensions\SetActiveWorkspaceRequestHandler.cs:line 24
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.MessageProtocol.RequestHandlerBase`1.<HandleAsync>d__9.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\MessageProtocol\RequestHandlerBase.cs:line 43
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Dynamics.Nav.EditorServices.Protocol.RequestRegistry.<Process>d__6.MoveNext() in F:\a\435\s\source\Prod\Microsoft.Dynamics.Nav.EditorServices.Protocol\Endpoints\RequestRegistry.cs:line 64

Screenshots

Versions:

Visual Studio Code:
Version: 1.35.0 (user setup)
Commit: 553cfb2c2205db5f15f3ee8395bbd5cf066d357d
Date: 2019-06-04T01:17:12.481Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17763

AL Language: 3.0.126610

Business Central: 14.0.29537.0

Hi @DigiTecKid,
We have seen this issue before but weren't able to successfully reproduce it.
Is this still an issue for you?

Same error, New Version:
Version: 1.39.1 (user setup)
Commit: 88f15d17dca836346e787762685a40bb5cce75a8
Date: 2019-10-10T23:31:28.683Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

Just an FYI.  The error happens even before I specify the server...

When you use AL:Go does the the path starts with \Users... and if so could you try prefix with the system drive letter so it becomes something like C:\Users....

I used C:\temp\algo (making sure to give "Everyone" full permissions to the folder) and it's the same error:

Can you please tell us what is teh version of the AL extension you are using?

I had an old version of the Microsoft AL Language installed along with the newest:
AL Language 0.12.28462
was installed along with
AL Language 4.0.191880
Once I removed the VSC extension AL Language 0.12.28462 The AL:Go! function created the folders correctly and tried to connect to BC to get symbols.

Thank you for verifying! I will close this issue as it appears it has been fixed.


Add label support for include and filter configuration

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

6 of 6 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
4710

Relevant Lines:
4710

💛  - Coveralls

Thanks again for your effort!
Are you sure the label filter works? As far as I understand it, the logic in all filters is "whitelisting", meaning that you specify more granularly what should be included in the group.
The new example with the label filter is "blacklisting", meaning that you specify labels which should be excluded.
I don't see that reflected in the code and if I've overlooked it, it's very confusing to change the logic based on filter types.

The "filters" implemented in powercalc can act both for whitelisting and blacklisting.
https://docs.powercalc.nl/sensor-types/group/include-entities/
You can use include to specify what to include in the group.
A bit down is explained how to apply filters. You can apply one or more filters to narrow down the included entities.
powercalc:
  sensors:
    - create_group: All lights
      include:
        domain: light
        filter:
          label: excludePowercalc

I will see how to make this doc topic more prominent, as it's not easily accessible in the docs currently.

Then I got this wrong. Thanks for the clarification.
I'll give it a try as soon as possible. Looking forward to throw away all the manual stuff. I've got about 50 Shellys and 60 Hue lights in my setup and it's super annoying to add everything manually to the areas.


Settings

@kllevin please review.
Revamped all of Settings, now everything is in the 1 partial broken into these sections:

Colours (Global)
Typography (Global)
Spacing (Global)
Breakpoints (Global)
Z-Index system (Global)
HiDPI units (Global)
HTML textual inputs (Global)
Base (Local)
Container (Local)
Grid (Local)
Helpers (Local)

See the CHANGELOG.md for more details.
💎

@kllevin please review, all your feedback is now addressed.


Flocculator Assignment Questions I - PatrickStars

Is G-Bod the same thing as Gcs in the spacing equation?

yes. Apologies for not having consistent nomenclature.
G_bod is the velocity gradient that we are using a the Basis of Design.


Use cc1352-flasher for flashing instead of a script that does not exist

Search the system PATH for cc1352-flasher instead of assuming a location

Please update the board's (or boards', if there are others using the same tool?) with instructions on how to install the cc1352-flasher tool instead.
Even if these are "extra" requirements, it is not appropriate for adding board-specific stuff: it will slow down initial setup for all users, and unecessarily adds a dependency that may fail and need troubleshooting.

It is used by 2 boards currently, beagleplay and beagleconnect freedom.
Adding them as a dep was a suggestion by someone on discord since some other boards apparently do something similar.

From the functionality/changes the PR looks good, I can confirm the upstream Python module flasher works fine, I agree with the concern @kartben raised, mainly the long-term maintenance for this and even if the module is not maintained well upstream, it should not hinder other platform user experience.
Along with updating documentation, can you check the output of find_program() and display a error pointing to the flasher installation?
https://github.com/zephyrproject-rtos/zephyr/blob/418416eefacfe894f8d7df3c5374c0e147e2fc7c/boards/arm/beagle_play_cc1352/board.cmake#L9

... some other boards apparently do something similar

For the record this is true but I believe it's also concerning only two boards, and not ideal either IMO

Shouldn't this delete boards/arm/beagle_bcf/cc2538-bsl.py?

Shouldn't this delete boards/arm/beagle_bcf/cc2538-bsl.py?

@fabiobaltieri , it looks like the board directory was not packaging the flashing script so far:
https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arm/beagle_bcf/board.cmake#L6

@fabiobaltieri , it looks like the board directory was not packaging the flashing script so far: https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/arm/beagle_bcf/board.cmake#L6

Oh, I see. There was a bit of a conversation about this today on Discord (https://discord.com/channels/720317445772017664/1196766845332619305 <- does this work?), inconclusive for now, people are split on whether these should be introduced or not and how, but considering that the script is not even there I think that bare minumum the boards/arm/beagle_bcf/board.cmake is good.
Then if it's decided to not include the tool in the default requirements maybe CMake could identify that the tool is not there and print an error message that references the correct pip command to install it?

Oh, I see. There was a bit of a conversation about this today on Discord (https://discord.com/channels/720317445772017664/1196766845332619305 <- does this work?), inconclusive for now, people are split on whether these should be introduced or not and how, but considering that the script is not even there I think that bare minumum the boards/arm/beagle_bcf/board.cmake is good.

Yup, the board.cmake changes are needed since the script is absent anyway.

Then if it's decided to not include the tool in the default requirements maybe CMake could identify that the tool is not there and print an error message that references the correct pip command to install it?

I tried that https://github.com/zephyrproject-rtos/zephyr/pull/64718 . Basically, making board.cmake abort seems to break some twister test: https://github.com/zephyrproject-rtos/zephyr/actions/runs/7492335335

I tried that #64718 . Basically, making board.cmake abort seems to break some twister test: https://github.com/zephyrproject-rtos/zephyr/actions/runs/7492335335 . I guess I can make it just a warning instead of an error?

Yeah I guess that the board cmake file runs regardless of the target and you get the warning even if you are building, so such a check and error needs to hook into the "flash" target somehow. @tejlmand do you know if there's a way of doing this?

@kartben Can we merge this PR now? I have removed the python module. While I would prefer adding it as a module or at the very least be able to throw a good error message and abort in it's absence, I do not want to continue having a path to a script that does not exist in the cmake file.

@Ayush1325 did you not want to also update the READMEs of the boards that are relying on this tool for flashing? Similar to how e.g. the ESP32 boards have a small note to remind folks to run west blobs fetch espressif

@Ayush1325 did you not want to also update the READMEs of the boards that are relying on this tool for flashing? Similar to how e.g. the ESP32 boards have a small note to remind folks to run west blobs fetch espressif

Done


Fix bigint and seperator

retrigger

i could not use real bigint type or we could not compile to es5


[Bug]: GlitchTip service cannot send email

Is there an existing issue for this?

[X] I have searched the existing issues

Description
GlitchTip logs ValueError: EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True. if sending email tried.
$ docker exec -ti 56e530843797 /bin/bash
$ export | grep EMAIL
declare -x EMAIL_USE_SSL="false"
declare -x EMAIL_USE_TLS="true"

It should be True or False in python.
$ python
>>> a="true"
>>> b="false"
>>> print('y') if a and b else print('n');
y
>>> b=False
>>> print('y') if a and b else print('n');
n
>>> b=True
>>> print('y') if a and b else print('n');
y

startGlitchTipService should convert true or false string into True or False primitive.
https://github.com/coollabsio/coolify/blob/d3a1bbc3d0a7e93f821f4cbe801310e341fae5dc/apps/api/src/lib/services/handlers.ts#L1982-L1983
Steps To Reproduce

Create GlitchTip service
login
Add notification email address
Send confirmation email fails
See log in coolify
ValueError: EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True.

Version
3.9.3

Nice catch! Fixing in the next version!

$ docker ps | grep glit | grep start | awk '{print $1}' | xargs -I"{}" -o docker exec -ti {} /bin/bash -c 'printenv | grep EMAIL_USE'
EMAIL_USE_TLS=True
EMAIL_USE_SSL=False

does not work
$ docker ps | grep glit | grep start | awk '{print $1}' | xargs -I"{}" -o docker exec -ti {} /bin/bash -c 'printenv | grep EMAIL_USE'
EMAIL_USE_TLS=1
EMAIL_USE_SSL=0

(set by Secrets) not work too
https://glitchtip.com/documentation/install docker-compose.sample.yml file set EMAIL_URL.
So EMAIL_URL also tried but still failed.
I suspect that EMAIL_USE_TLS and EMAIL_USE_SSL remains after overwrite by EMAIL_URL.
(https://gitlab.com/glitchtip/glitchtip-backend/-/blob/master/glitchtip/settings.py#L541)

I don't know if I'm reading this right, but I think you could either use None instead of False, or unset the variable that is false: https://sourcegraph.com/github.com/django/django/-/blob/django/core/mail/backends/smtp.py?L36-49#tab=references
I think this issue should be re-opened, from what I can tell you can't configure GlitchTip to use e-mail at this point.

@andrasbacsai may I ask you to re-open the issue? I can also create a new one. I can reproduce this quite easily:

Create a new GlichTip instance.
Configure e-mail (any combination of flags will fail, whether on or off).
Login using the generated user/password.
Change the user's e-mail address (this triggers a confirmation e-mail that fails).

I think GlichTip is especially good if it sends alerts about things that go wrong, without it, it is
a lot less useful.
My guess is that it's not a problem of the variable format (1, True, None), but that the variable exists in the first place. It should likely be unset if it is meant to be off.

The latest template based GlitchTip works now.

I assume this has not been released yet? I tried a new instance in 3.11.9, and I still get the following error:
2022-11-16T07:03:16.148142494Z ValueError: EMAIL_USE_TLS/EMAIL_USE_SSL are mutually exclusive, so only set one of those settings to True.

Maybe someone else can confirm, to ensure I'm not doing something wrong.

Unfortunately, You probably need to recreate GlitchTip service, because a lot of things changed with that. The differences between the hardcoded and template based are huge.

Is this supposed to be solved? I still get the same error on 3.12.31. EMAIL_USE_TLS is "enabled" and EMAIL_USE_SSL is "disabled" in the config.

we also get the same problem on latest coolify

@andrasbacsai please reopen the issue.

Without looking much into it, https://github.com/coollabsio/coolify/blob/v3/apps/api/src/lib/services/serviceFields.ts#L627 is a duplication of the SSL setting when it should probably say TLS.

Without looking much into it, https://github.com/coollabsio/coolify/blob/v3/apps/api/src/lib/services/serviceFields.ts#L627 is a duplication of the SSL setting when it should probably say TLS.

ive created a PR updating the specified line: https://github.com/coollabsio/coolify/pull/1147

Can confirm this issue is still reproducible in v3.12.37


Added trim on wikipedia pages to disclude info box on right of some pages

See problem on: https://en.wikipedia.org/wiki/Particle_physics
Close #68

LGTM!


Bouncing Traefik TCP connections?

I have a few services that are exposed in Traefik via TCP entrypoints.  I'd like to bounce TCP connections that CrowdSec identifies as threats.  Does this bouncer only handle HTTP-based connections?

Last time I've checked, Traefik expose the Auth Middleware only for HTTP request. So this bouncer only work with HTTP connection.


修复拷贝漫画搜索

https://www.mangacopy.com/api/kb/web/searchba/comics?format=json&limit=12&offset=1&platform=2&q=成&q_type=
Giving
{"code":210,"message":"搜索崩潰啦","results":{"detail":"搜索崩潰啦"}}

No need to use "format=json&", the returned result itself is a JSON, which should be usable within the software.

https://www.mangacopy.com/api/kb/web/searchba/comics?format=json&limit=12&offset=1&platform=2&q=成&q_type=
Giving
{"code":210,"message":"搜索崩潰啦","results":{"detail":"搜索崩潰啦"}}

No need to use "format=json&", the returned result itself is a JSON, which should be usable within the software.


Allow closure spies

Currently I write something like this when I want to test that a closure gets executed:
class SomethingTest extends TestCase
{
  public function testSomething()
  {
    $spy = [
      'callCount' => 0,
      'args' => []
    ];

    aFunction(function () use (&$spy) {
      $spy['callCount']++;
      $spy['args'][] = func_get_args();
    });

    self::assertSame(1, $spy['callCount']);
    self::assertSame(['what', 'ever'], $spy['args'][0]);
  }
}

dependent from what I want to test of course. I'm wondering that there is no spy. In jasmine for example your write:
describe('something', function() {
  it('calls the callback', function() {
    var spy = jasmine.createSpy('callback');

    aFunction(spy);

    expect(spy).toHaveBeenCalledWith('what', 'ever');
  });
});

Sounds some bit more easy, readable and understandable.
Ok, thats not your problem - phpunit is differnt. But you could provide a spy. I just saw that there is a method Mockery::spy() but when I see it correct is again to create a Spy for an Interface. I want to spy a closure. Ok spy is taken and I guess you don't want to change the current behavior for spy.
My suggestion:
class SomethingTest extends TestCase
{
  public function testSomething()
  {
    $spy = \Mockery::createSpy('callback');

    aFunction($spy);

    $spy->shouldHaveBeenCalled()->with('what', 'ever')->once();
  }
}

I'd be open to providing something like this. We could code up something specific, or we could utilise the existing code and effectively do something like:
class CallableSpy {
    public function __invoke() {}
    public function shouldHaveBeenCalled() {
        return $this->shouldHaveReceived("__invoke");
    }
}

$mock = Mockery::spy(CallableSpy::class)->makePartial();
$mock(123);
$mock->shouldHaveBeenCalled()->with(123);

My preferred syntax would be something like
Mockery::spy(function() {});

I think it's fairly clear that it's a spy for a callable, and we could also further it to make it partial spy etc.
Mockery::spy(function($number) { return $number+1; });

yes, thats good for me too.

@tflori see #712, let me know your thoughts on there.

Closing as #712 got merged.