Bug: Error "fetch failed" when fetching v3.1.1

We are getting error "fetch failed" when targeting the brand new patch v3.1.1:

Targeting v3.1.0 works fine.

@lindeberg thanks for the report, we recently updated our HTTP libraries and I was expecting something like this to show up! Can you share the YAML file you're using for the Action (please obscure any private info) so we can reproduce?

name: Dependency Review
on: [pull_request]
permissions:
  contents: read
jobs:
  dependency-review:
    name: Dependency review
    runs-on: [self-hosted, linux]
    steps:
      - name: Checkout Repository
        uses: actions/checkout@v4

      - name: Dependency Review
        uses: actions/dependency-review-action@v3
        with:
          fail-on-severity: low
          license-check: false

Why release something where there is an expected issue?

@lindeberg Thanks for providing additional details for the reproduction. I apologize for using such loose language in my previous comment. Rephrased: I am not surprised to see this error given the number of packages updated. I will provide an update once I can debug this issue.

@lindeberg I have not been able to reproduce this issue on github.com. I used the https://github.com/future-funk/glowing-computing-machine/ repo with two pull requests:

PR with vulnerability: https://github.com/future-funk/glowing-computing-machine/actions/runs/6773235611?pr=2
PR fixing vulnerability: https://github.com/future-funk/glowing-computing-machine/actions/runs/6773258235?pr=2

Are you able to reproduce? The only difference is the self-hosted runners part. A few questions:

What platform are you using? (GitHub Enterprise Cloud, GitHub Enterprise Server (on-prem)..., etc)
Are your self hosted runners running at the repo, org or enterprise level?

Not sure if related, but since the new version we have been having the following problem on self-hosted runners:

Runner version: v2.311-ubuntu-20.04
Pinning to the previous version solves the problem: actions/dependency-review-action@6c5ccdad469c9f8a2996bfecaec55a631a347034
@febuiles happy to log this on a different issue

Hello, i am also receiving this error! Tried with 3.1.1 with no difference!

It is executed on GitHub Enterprise with Advanced security enabled.
Code of the action is :
name: 'Dependency Review'
on: [pull_request]
permissions:
contents: read
pull-requests: write
jobs:
dependency-review:
runs-on: ubuntu-latest
steps:
- name: 'Checkout Repository'
uses: actions/checkout@v4
- name: 'Dependency Review'
uses: internal-marketplace/dependency-review-action@v3
with:
fail-on-severity: high
comment-summary-in-pr: on-failure
Added bold lines hoping to get some additional info.

We are using self hosted runners on organization level in Enterprise Cloud.

I have not been able to reproduce this in GitHub Enterprise Cloud with a self-hosted runner, log here: https://github.com/future-funk/glowing-computing-machine/actions/runs/6784453748/job/18440780341. Relevant lines:
Current runner version: '2.311.0'
Runner name: 'nekrasov'
Runner group name: 'Default'
Machine name: 'nekrasov'
...
Run actions/dependency-review-action@v3
  with:
    fail-on-severity: low
    license-check: false
    repo-token: ***
    retry-on-snapshot-warnings: false
    retry-on-snapshot-warnings-timeout: 120
Dependency review did not detect any denied packages
Vulnerabilities
  package.json »<EMAIL_ADDRESS>– Prototype pollution in webpack loader-utils (critical severity)
    ↪ https://github.com/advisories/GHSA-76p3-8jx3-jpfq

A reproduction repro, or a scrubbed log of a run would be appreciated to get an idea of where we're failing. I'll commission a GitHub Enterprise Server to test self-hosted runners there.

Not sure what logs you mean. Logs with debug on:
##[debug]Evaluating condition for step: 'Dependency Review'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Dependency Review
##[debug]Loading inputs
##[debug]Evaluating: github.token
##[debug]Evaluating Index:
##[debug]..Evaluating github:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'token'
##[debug]=> '***'
##[debug]Result: '***'
##[debug]Loading env
Run<EMAIL_ADDRESS>  with:
    fail-on-severity: low
    license-check: false
    repo-token: ***
    retry-on-snapshot-warnings: false
    retry-on-snapshot-warnings-timeout: 1[2](https://github.com/company/repo/actions/runs/6779542227/job/18431071297#step:4:2)0
Error: fetch failed
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Dependency Review

Could you elaborate on how we can help?
Note that we are running behind proxy server. That sounds like a potential culprit as you mentioned http libraries.

I was not able to reproduce this in GHES 3.10 either, so I guess proxies are the ones getting disrupted by this, thanks for bringing that up @lindeberg.
To get the full logs for a run you can click the cogwheel item in the failed run and then "View raw logs":

It'd be useful to get the full output (with private data scrubbed) to see at which step of the run things are failing.

I've pushed a temporary tag to see if we can fix this issue by downgrading a couple of libraries.
Can you test with this custom version and see if the error still appears?
 uses: actions/dependency-review-action@downgrade-actions-github

@febuiles I just tried the tag you posted and I am getting the same error I posted before while getting credentials.
Some additional info:

GHES: 3.8.5
ARC: actions-runner-controller-0.23.3 (chart), 0.27.4 (app version)
We do patch custom certs in our runner images

Same error with version "downgrade-actions-github".
Full log:
2023-11-08T03:19:33.8099068Z Requested labels: self-hosted, linux
2023-11-08T03:19:33.8099316Z Job defined at: company/repo/.github/workflows/dependency-review.yml@refs/pull/255/merge
2023-11-08T03:19:33.8099404Z Waiting for a runner to pick up this job...
2023-11-08T03:19:34.3619552Z Job is about to start running on the runner: company-runner-s59vw-7t59s (organization)
2023-11-08T03:19:39.4870942Z Current runner version: '2.311.0'
2023-11-08T03:19:39.4878687Z Runner name: 'company-runner-s59vw-7t59s'
2023-11-08T03:19:39.4879653Z Runner group name: 'company runners'
2023-11-08T03:19:39.4880619Z Machine name: 'company-runner-s59vw-7t59s'
2023-11-08T03:19:39.4883695Z ##[group]GITHUB_TOKEN Permissions
2023-11-08T03:19:39.4886191Z Contents: read
2023-11-08T03:19:39.4886546Z Metadata: read
2023-11-08T03:19:39.4886843Z ##[endgroup]
2023-11-08T03:19:39.4890074Z Secret source: Dependabot
2023-11-08T03:19:39.4891346Z Runner is running behind proxy server 'http://proxy.company.net:8080' for all HTTP requests.
2023-11-08T03:19:39.4892809Z Runner is running behind proxy server 'http://proxy.company.net:8080' for all HTTPS requests.
2023-11-08T03:19:39.4893677Z Prepare workflow directory
2023-11-08T03:19:39.5554514Z Prepare all required actions
2023-11-08T03:19:39.5729375Z Getting action download info
2023-11-08T03:19:39.8544704Z Download action repository 'actions/checkout@v4' (SHA:b4ffde65f46336ab88eb53be808477a3936bae11)
2023-11-08T03:19:40.7002773Z Download action repository 'actions/dependency-review-action@v3' (SHA:9f45b2463b475767b61721ccfef113fef513e6aa)
2023-11-08T03:19:41.6662394Z Complete job name: Dependency review
2023-11-08T03:19:41.7139255Z A job started hook has been configured by the self-hosted runner administrator
2023-11-08T03:19:41.7309545Z ##[group]Run '/etc/arc/hooks/job-started.sh'
2023-11-08T03:19:41.7334999Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2023-11-08T03:19:41.7335817Z ##[endgroup]
2023-11-08T03:19:41.7733049Z 2023-11-08 03:19:41.769  DEBUG --- Running ARC Job Started Hooks
2023-11-08T03:19:41.7747411Z 2023-11-08 03:19:41.773  DEBUG --- Running hook: /etc/arc/hooks/job-started.d/update-status
2023-11-08T03:19:41.8266349Z ##[group]Run actions/checkout@v4
2023-11-08T03:19:41.8266864Z with:
2023-11-08T03:19:41.8267117Z   repository: company/repo
2023-11-08T03:19:41.8267801Z   token: ***
2023-11-08T03:19:41.8268061Z   ssh-strict: true
2023-11-08T03:19:41.8268461Z   persist-credentials: true
2023-11-08T03:19:41.8268864Z   clean: true
2023-11-08T03:19:41.8269145Z   sparse-checkout-cone-mode: true
2023-11-08T03:19:41.8269465Z   fetch-depth: 1
2023-11-08T03:19:41.8269725Z   fetch-tags: false
2023-11-08T03:19:41.8269988Z   show-progress: true
2023-11-08T03:19:41.8270238Z   lfs: false
2023-11-08T03:19:41.8270473Z   submodules: false
2023-11-08T03:19:41.8270749Z   set-safe-directory: true
2023-11-08T03:19:41.8271033Z ##[endgroup]
2023-11-08T03:19:41.9726356Z Syncing repository: company/repo
2023-11-08T03:19:41.9728129Z ##[group]Getting Git version info
2023-11-08T03:19:41.9728749Z Working directory is '/runner/_work/repo/repo'
2023-11-08T03:19:41.9729529Z [command]/usr/bin/git version
2023-11-08T03:19:41.9729861Z git version 2.42.0
2023-11-08T03:19:41.9730945Z ##[endgroup]
2023-11-08T03:19:41.9741963Z Temporarily overriding HOME='/runner/_work/_temp/3f211264-d443-4bb6-a161-bec21cefd0f1' before making global git config changes
2023-11-08T03:19:41.9743057Z Adding repository directory to the temporary git global config as a safe directory
2023-11-08T03:19:41.9743982Z [command]/usr/bin/git config --global --add safe.directory /runner/_work/repo/repo
2023-11-08T03:19:41.9745232Z Deleting the contents of '/runner/_work/repo/repo'
2023-11-08T03:19:41.9745976Z ##[group]Initializing the repository
2023-11-08T03:19:41.9746507Z [command]/usr/bin/git init /runner/_work/repo/repo
2023-11-08T03:19:41.9779092Z hint: Using 'master' as the name for the initial branch. This default branch name
2023-11-08T03:19:41.9779849Z hint: is subject to change. To configure the initial branch name to use in all
2023-11-08T03:19:41.9780531Z hint: of your new repositories, which will suppress this warning, call:
2023-11-08T03:19:41.9781015Z hint:
2023-11-08T03:19:41.9781667Z hint: 	git config --global init.defaultBranch <name>
2023-11-08T03:19:41.9782071Z hint:
2023-11-08T03:19:41.9782538Z hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
2023-11-08T03:19:41.9783593Z hint: 'development'.  You can look around, make experimental
2023-11-08T03:19:42.9999146Z changes and commit them, and you can discard any commits you make in this
2023-11-08T03:19:43.0000453Z state without impacting any branches by switching back to a branch.
2023-11-08T03:19:43.0001194Z
2023-11-08T03:19:43.0001630Z If you want to create a new branch to retain commits you create, you may
2023-11-08T03:19:43.0002416Z do so (now or later) by using -c with the switch command. Example:
2023-11-08T03:19:43.0002836Z
2023-11-08T03:19:43.0003002Z   git switch -c <new-branch-name>
2023-11-08T03:19:43.0003231Z
2023-11-08T03:19:43.0003357Z Or undo this operation with:
2023-11-08T03:19:43.0003565Z
2023-11-08T03:19:43.0003660Z   git switch -
2023-11-08T03:19:43.0008573Z
2023-11-08T03:19:43.0011007Z Turn off this advice by setting config variable advice.detachedHead to false
2023-11-08T03:19:43.0014096Z
2023-11-08T03:19:43.0016966Z HEAD is now at 649d2c4 Merge 768ab17184b4800aa9498763213100fd97619918 into 72750e124c054d202e489eb2f491224810a05a62
2023-11-08T03:19:43.0021871Z ##[endgroup]
2023-11-08T03:19:43.0056614Z [command]/usr/bin/git log -1 --format='%H'
2023-11-08T03:19:43.0087975Z '649d2c42dd93c5a27d08cb9b602133615e502188'
2023-11-08T03:19:43.0393155Z ##[group]Run actions/dependency-review-action@v3
2023-11-08T03:19:43.0393583Z with:
2023-11-08T03:19:43.0393803Z   fail-on-severity: low
2023-11-08T03:19:43.0394092Z   license-check: false
2023-11-08T03:19:43.0394595Z   repo-token: ***
2023-11-08T03:19:43.0394873Z   retry-on-snapshot-warnings: false
2023-11-08T03:19:43.0395457Z   retry-on-snapshot-warnings-timeout: 120
2023-11-08T03:19:43.0395822Z ##[endgroup]
2023-11-08T03:20:37.4560030Z ##[error]fetch failed
2023-11-08T03:20:37.4827090Z Post job cleanup.
2023-11-08T03:20:37.5855729Z [command]/usr/bin/git version
2023-11-08T03:20:37.5892623Z git version 2.42.0
2023-11-08T03:20:37.5943136Z Temporarily overriding HOME='/runner/_work/_temp/5f21b3ab-600a-4fdd-b619-c6ee28cc7e57' before making global git config changes
2023-11-08T03:20:37.5945517Z Adding repository directory to the temporary git global config as a safe directory
2023-11-08T03:20:37.5949403Z [command]/usr/bin/git config --global --add safe.directory /runner/_work/repo/repo
2023-11-08T03:20:37.5994176Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2023-11-08T03:20:37.6036526Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
2023-11-08T03:20:37.6579275Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2023-11-08T03:20:37.6631824Z http.https://github.com/.extraheader
2023-11-08T03:20:37.6665174Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2023-11-08T03:20:37.6742297Z [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
2023-11-08T03:20:37.7261229Z A job completed hook has been configured by the self-hosted runner administrator
2023-11-08T03:20:37.7360183Z ##[group]Run '/etc/arc/hooks/job-completed.sh'
2023-11-08T03:20:37.7371474Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2023-11-08T03:20:37.7372125Z ##[endgroup]
2023-11-08T03:20:37.7484790Z 2023-11-08 03:20:37.746  DEBUG --- Running ARC Job Completed Hooks
2023-11-08T03:20:37.7537414Z 2023-11-08 03:20:37.752  DEBUG --- Running hook: /etc/arc/hooks/job-completed.d/update-status
2023-11-08T03:20:37.7920228Z Cleaning up orphan processes

@lindeberg thanks for sharing the output of your run. We posted almost at the same time, but I hope the new branch mentioned in the last comment fixes the. Your patience is much appreciated, I will make sure that HTTPS-proxy testing is done for future releases.

@febuiles version "fix-https-proxy" works! 👍

Thanks for the confirmation that it's working 🙇
I cut a new releases, 3.1.2, to address the bug. I added a bit more context to the original PR. With this I'm closing this issue.
If you are still running into problems with 3.1.2 please re-open this issue or create a new one.

Hello, I also can confirm it is working now - sorry for the timeout!

Hi @febuiles! We are having this issue again (some(most)time). On self hosted runners with least privelege external network access. So we figured these domains should be allowed by the proxy:

api.deps.dev
api.securityscorecards.dev

Anything else that needs to be allowed?

@lindeberg I'm not up to date with the latest changes, but it makes sense that now that the action reaches out to external providers some additional configuration is needed.
I think @jonjanego can provide further guidance with this, good luck!


Tags

Closes #101
Tags are strings meant to be used as additional filtering method. A transaction can have as many tags as the user wants. Tags are only stored in transactions, list of tags in an account is generated on loading transactions; as result, there's no need to remove tags - unused ones automatically disappear on the account closing. Tags can contain any characters except , because it's used as separator.
Gtk.ScrolledWindow with fixed size is used because propagate-natural-height doesn't work in a popover, and I didn't find a better way to create tags managing interface without sacrificing usability. It has card style class because we need to visually separate it from Add tag entry/button, separator doesn't work here because elements a child of a popover always have margins. Tags are just Gtk.ToggleButtons without any additional styling (I tried to make them more rounded first, but I think they looked worse).
Implemented: adding, selecting, loading and saving tags in transactions, as well as exporting/importing tags.
TODO:

[x] Filtering using tags
[ ] Show/hide tags
[ ] Update po(t)
[ ] Update docs

Unrelated, but I wish to implement in the same PR since I already start polishing some things:

[x] Saving graphs state (visible/hidden)

With latest commits, TransactionDialog is broken...working to fix it

Ok fixed

@fsobolev Implemented showing and hidding tags list and updated po(t)....all that's left is if you can update docs :)


feat: Extract generic type for KafkaListeners in batch mode

The KafkaPayloadTypeExtractor contains the logic to extract the payload type, which previously was part of ClassLevelKafkaListenerScanner and MethodLevelKafkaListenerScanner.
If the parameter is of type List<?>, reflection is used to extract the underlying type.
This solution assumes by using the List type, Kafka batch mode is used.
A future improvement can be to only extract the generic when the KafkaListener annotation is used together with the batch property. A library update for spring-kafka is possible: https://docs.spring.io/spring-kafka/api/org/springframework/kafka/annotation/KafkaListener.html#batch()
To demo it, one listener in ExampleConsumer is updated to use batch mode.
Relates to https://github.com/springwolf/springwolf-core/issues/87

I updated the PR with a larger refactoring and moving duplicated code to Abstract classes in core. The amqp and kafka listeners are slimmer now, although there is still some complexity through the abstract methods.
For reviewing, I suggest to check out the code locally.
Since the release is around the corner, I think this is a feature for the following release.
Regarding the batch mode, yes, this by default assumes that all List Payloads are batch methods. In the future this could be made configurable (batch-mode: yes/no), but at this point I would assume that people define their own payload types and not use List in non-batch mode (defining <MyType extends List<?> should work around the list detection anyway).

I really like these refactoring, it will make it much much easier to implement more plugins based on listener annotations. Great job!


[CLOSED] Alphabetisation of the Wiring and Observers

 Issue by tommyp
Wednesday 23 July 2014 at 16:43 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/182

This commit alphabetises some of the dependencies, attrs and moves the factories around in the wiring to group them in a more sensible way.

tommyp included the following code: https://github.com/alphagov/specialist-publisher/pull/182/commits

 Comment by tommyp
Thursday 24 July 2014 at 12:56 GMT

With the addition of the IDF Finder, both places where this PR touches grow. We're going to end up with 7 Finders at least and deciphering these files with stuff not being in alphabetical order might get a bit hairy.

 Comment by bestie
Thursday 24 July 2014 at 09:28 GMT

I'm generally not in favour of alphabetising lines of code as it's usually more helpful to see them in either some sort of logical grouping.
Also a lot of the churn introduced here is in code we want to get rid of.
If this is helpful to others and not just an OCD exercise then I'm fine with these changes.


vpi_visitor & vpi_listener logic update

vpi_visitor & vpi_listener logic update

vpi_listener
** vpiExtends cannot be safely ignored since there could be only a
single reference to it. Ignoring would mean there is never a
entry/leave call for it.
** Avoid entry/leave for vpiProgram, vpiPackage, and vpiUdp when
referred as a member reference from other objects.

vpi_visitor
** Show vpiParent in the output for bit_select & part_select
** Never use shallow for ref_obj - without the vpiActual the reference
itself is pointless
** Similar update for vpiInstance, vpiModule, vpiInterface, vpiUse,
vpiProgram, vpiClassDefn, vpiPackage, and vpiUdp.
** Attempt to show all the information at the outer level but shallow
in inner level of the hierarchy (basically, flattenning the tree a
bit so it's easier to visually parse).

@hs-apotell, Can we finish #677 before we merge this one?

#677 and this are independent changes. Either way, #677 is updated with requested changes.


Controls doesn't appear on map

Hello,
I tried to use the AGM controlers but i didn't work... it didn't appear on the map.
component.html
<agm-map [usePanning]="usePanning"
        [latitude]="latAGM"
        [longitude]="lonAGM"
        [zoom]="zoomAGM"
        (mapReady)="mapReady($event)">
</agm-map>

component.ts
mapReady(map: any): void {
      map.setOptions({
            mapTypeControl: true,
            mapTypeControlOptions: {
                style: MapTypeControlStyle.DROPDOWN_MENU,
                mapTypeIds: ['roadmap', 'terrain']
            },
            fullscreenControl: true,
            streetViewControl: true
        });
}

Only zoomControl and fullscreenControl appear on the map...
At the beginning i tried with in AGM Input() parameters but it was the same result...
Any help ?
Thanks in advance.

so first of all, almost always work with Input parameters. Secondly, I was not able to reproduce. Can you do a stackblitz?

I've tried both (inputs and by config) and i've arrived to the same result...
here's the stackblitz
Tried with Firefox and Chrome...

This is from your stackblitz. The only change I made, was setting a valid apiKey.

I am closing this as this doesn't look like a bug. For further usage questions, ask us in Discord  or in StackOverflow

Ho... that's embarassing...
Anyway, thanks for the answer ! ;)


ORC-1213: [C++] Use https in ThirdpartyToolchain.cmake

Update some download links from using http & ftp to https

Welcome to Apache ORC community and thank you for your first contribution, @dbaxa .
Do you have Apache JIRA id? I need to assign ORC-1213 to you.

Hi @dongjoon-hyun , it should be dblack.

Thank you. ORC-1213 is assigned to dblack now. :)

.


Tokens remain showing in token wallet once sent.

Operation System
Windows 10
Expected Behavior
The app should remove the token/NFT from showing in your token wallet once you send it and no longer hold any of those tokens (or once the app recognises you no longer have any of those tokens/NFT in your address).
Current Behavior
The dapp does not update your wallet once you send a token/NFT and have a 0 balance left for that specific token/NFT. I had to log out and back in for it to disappear completely from my token wallet.
Steps to Reproduce
Send an NFT and watch it stay in your token wallet.
Note the dapp shows 4 tokens within the token wallet, but says '2 tokens' under the coin wallet amount, and also shows no balance for the currently selected token (because I sent all of the ones I had in my address)
https://i.gyazo.com/11f3224c0d614e009136272b53c02247.png

Issue no longer in current releases.


'StylesProvider' cannot be used as a JSX component.

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
Upon our latest build of our app using Material-UI v4, our builds are failing with the following error:
'StylesProvider' cannot be used as a JSX component.
  Its element type 'ReactElement<any, any> | Component<StylesProviderProps, any, any> | null' is not a valid JSX element.
    Type 'Component<StylesProviderProps, any, any>' is not assignable to type 'Element | ElementClass | null'.
      Type 'Component<StylesProviderProps, any, any>' is not assignable to type 'ElementClass'.
        The types returned by 'render()' are incompatible between these types.
          Type 'React.ReactNode' is not assignable to type 'import("{ REDACTED }/node_modules/@types/react-router/node_modules/@types/react/index").ReactNode'.
            Type '{}' is not assignable to type 'ReactNode'.
              Type '{}' is missing the following properties from type 'ReactPortal': key, children, type, props

This is an older application that we are working on phasing out, but we need to make periodic patch fixes. Migrating from v4 to v5 is not an option.
This issue occurred yesterday, May 5th. We had a successful build on May 5th at 5:59pm UTC. The following build failed on May 5th at 8:10pm UTC. The two have pulled different versions of @material-ui/styles.
The successful build is using<EMAIL_ADDRESS>while the failing build is using<EMAIL_ADDRESS>I do not see version 4.11.5 in the release list of this repository.
We are using yarn for package installation. The 4.11.5 package is in the yarn registry at:
<EMAIL_ADDRESS>We are using<EMAIL_ADDRESS>which lists<EMAIL_ADDRESS>as a dependency. All attempts to override the dependency resolution to lock-in<EMAIL_ADDRESS>have failed. Our resolved version of @types/react-router has not changed between the successful and failed build (5.1.18).
This issue is currently blocking a critical patch release for our production application. Any assistance to help us step around the issue would be greatly appreciated. Thank you.
Expected behavior 🤔
The use of <StylesProvider injectFirst> within a ThemeProvider element should work without error. <StylesProvider injectFirst> should return a valid JSX element.
Steps to reproduce 🕹
Steps:

Configure a React application with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Render the React application in strict mode <React.StrictMode>...
Setup the application to use <ThemeProvider theme={ THEME } ><StylesProvider injectFirst>...
Build

I attempted to make an example within the Typescript sandbox, but there is something I am not understanding about creating a working React application within the sandbox.
Context 🔦
Subsequent build of the same branch are failing without changes in our code.
These issues have started within the last 24 hours.
Your environment 🌎

`npx @mui/envinfo`
System:
    OS: macOS 11.5.2
  Binaries:
    Node: 14.17.6 - /usr/local/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 6.14.15 - /usr/local/bin/npm
  Browsers:
    Chrome: 101.0.4951.54
    Edge: 101.0.1210.39
    Firefox: 98.0.1
    Safari: 14.1.2
  npmPackages:
    @types/react: ^17.0.0 => 17.0.44
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    typescript: ^4.0.3 => 4.6.4

These issues are occurring during building (react-scripts build)

Hey, worth asking. Are you sure it isn't related to this question?

this question

That appears to have fixed it! I hadn't seen that SO post, nor had I noticed that my @types/react@* had changed from 17.0.38 to 18.0.4.
Adding these resolutions solved my problem:
  "resolutions": {
    "@types/react": "17.0.14",
    "@types/react-dom": "17.0.14"
  },

Thanks!

Seems like this is about the types from React so I marked this as an external dependency. Note that Material UI v4 does not support React 18 (correct me if I am wrong).


Adding support for loading multiple kernel modules(softdep)

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.18% :tada:

Comparison is base (f0cb9a0) 79.63% compared to head (be065ff) 79.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   79.63%   79.82%   +0.18%
==========================================
  Files          43       43
  Lines        4316     4356      +40
==========================================
+ Hits         3437     3477      +40
  Misses        721      721
  Partials      158      158

Files Changed
Coverage Δ

internal/controllers/nmc_reconciler.go
75.37% <100.00%> (+1.76%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm


brackets: drop

Motivation for this change
Hasn't been updated since 2017 and suffers from CVE-2019-8255.
closes https://github.com/NixOS/nixpkgs/issues/90740
closes https://github.com/NixOS/nixpkgs/issues/59196
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

The last release is from 6. April 2020. https://github.com/adobe/brackets/releases

The last release is from 6. April 2020. https://github.com/adobe/brackets/releases

Yep, lets remove this.

Yep, lets remove this.

@dotlambda Thanks :sparkles:

@dotlambda Thanks :sparkles:


CORS is not enabled for BinderHub API

I'd like to use BinderHub's API to start kernels from another webpage.
When trying to start a notebook server using the BinderHub API, the browser will error because the Access-Control-Allow-Origin HTTP header is missing.

I believe this should be a simple implementation of set_default_headers in the base.py:BaseHandler class but I'm still trying to get binderhub set up locally so I can't test it myself.
In addition, the current release of notebook (5.1.0) is missing a header that allows starting kernels from another domain. I fixed it in https://github.com/jupyter/notebook/pull/2876 but is there something we can do to get the fix in for the current deployment of Binder?
Happy to talk more about this (in person works too).
Related to #13.

Now that tokens are enabled, we no longer need to relax CORS restrictions. When you access a notebook server via Binder, a token will be given to you, and that should be used to authenticate requests. Token-authenticated requests are not affected by CORS restrictions.
Here is a Python example extending the binder-api example in this repo that requests a kernel and runs code using the token without any relaxation of CORS restrictions.
I'd love to have a javascript example that does the same thing using the JupyterLab js.

Having done some browser testing, I think I've misunderstood some of how browsers implement CORS.  Using tokens bypasses the server-side CORS check, which allows scripted access to the resources. However, it doesn't bypass the origin checking that happens in the browser.
I've opened https://github.com/jupyter/notebook/pull/2920 to make default notebook server behavior what I thought it already was.
#180 should restore CORS access in general on Binder, but only for authenticated requests, as it should be.

It looks like #180 restores CORS access to the notebook server, but from what I understand there are two steps in starting kernels using the BinderHub API:

Make an EventSource request to https://beta.mybinder.org/build/<provider>/<spec>
Once a ready event is emitted by the EventSource, we have a running notebook server and a token to access it. Now we can use the Kernel api in @jupyterlab/services to start a kernel on the notebook server.

Correct me if I'm wrong, but it looks like #180 allows CORS for 2. while we still need to allow CORS for 1.

@SamLau95 you are 100% correct

#182 enables CORS on BinderHub itself, with some questions about how exactly we should be doing it.

@SamLau95 CORS should be deployed to beta.mybinder.org now.

Thanks @minrk!
On Mon, Oct 16, 2017 at 5:13 AM Min RK<EMAIL_ADDRESS>wrote:

@SamLau95 https://github.com/samlau95 CORS should be deployed to
beta.mybinder.org now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/issues/177#issuecomment-336868194,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWsKAGw06h6Ybwf4lGjNvqvg6eMxJSPks5ss0hagaJpZM4PyFzd
.


cilium, docker: runtime dependency updates

See commit messages. tl;dr

Shrinks cilium-runtime from ~150M down to ~97M (!) according to quay.io

Final built Cilium container image ~200M smaller (see below)

Removes generic compiler, linker, binutils and others from image which are not needed anymore

Probing fully done by bpftool

Update to recent clang/llvm for better codegen and remove all backends but BPF

Main motivation to reduce verifier complexity due to less stack spilling
Implements BPF CPU probing, allowing also v2 for arm64

Remove shipping headers (/usr/include/ now empty !) and instead fully rely on Cilium ones

Add missing needed headers to bpf/ include infra to be fully independent

Describe where remaining dependencies are still needed in the Dockerfile

Comparing locally pulled image sizes, tag 2020-02-27 vs 2020-03-20:
root@tank:~# docker images
REPOSITORY                      TAG                                        IMAGE ID            CREATED             SIZE
quay.io/cilium/cilium-runtime   2020-03-20                                 3e9d2e373a7f        4 hours ago         229MB
quay.io/cilium/cilium-runtime   2020-02-27                                 33b9abb9ab72        3 weeks ago         433MB

cilium-new/cilium                 latest                                     697dd743abb9        5 minutes ago       429MB
cilium-old/cilium                 latest                                     ca339d7b069c        About an hour ago   633MB

This change is

contrib/packaging/deb/Dockerfile also installs libc6-dev.i386. Question is whether this Dockerfile is still in use? It looks quite outdated, e.g. using Go 1.9.

Looks outdated, @aanm ? If so, perhaps contrib/packaging/{deb,rpm}/ should be removed altogether if noone is actively maintaining it. Seems last actual work on that was roughly mid 2018.

Coverage increased (+0.005%) to 45.641% when pulling 865ae6810ea5a194e8ad3de15a64ab9d15285bfc on pr/cilium-runtime-updates into 6d29bba62d7cef9d340848d360da2effc09f2485 on master.

(Depends on<EMAIL_ADDRESS>resp final merged version upstream to unblock #10019 and therefore this PR.)

test-me-please

test-me-please

test-me-please

04:32:08  manifest for quay.io/cilium/cilium-runtime:2020-03-19 not found: manifest unknown: manifest unknown
04:32:08  Makefile:222: recipe for target 'docker-image-no-clean' failed

I think you've been pushing the 2020-03-11 image instead?
https://quay.io/repository/cilium/cilium-runtime?tag=latest&tab=tags

I think you've been pushing the 2020-03-11 image instead?
https://quay.io/repository/cilium/cilium-runtime?tag=latest&tab=tags

I was testing the bpf patch in the series since it triggered a build issue in the CI earlier, so that is fixed now. I'm doing a new tag in the next step since I've been shrinking runtime dependencies further.

test-me-please

test-me-please

Looks like CI issue:
23:07:15  Step 3/15 : ADD . /go/src/github.com/cilium/cilium
23:07:36  Error processing tar file(exit status 1): write /go/src/github.com/cilium/cilium/.git/objects/pack/pack-d24563f5587a36769ac0fc2e4ca3b89729513ede.pack: no space left on device
23:07:36  Makefile:250: recipe for target 'docker-operator-image' failed
23:07:36  make: *** [docker-operator-image] Error 1

test-me-please

test-me-please

test-me-please

test-me-please

test-docs-please

test-docs-please

test-me-please

test-me-please

net-next vm provisioning, retrying

test-me-please

13:17:27  Step 10/20 : FROM quay.io/cilium/cilium-runtime:2020-03-23
13:17:27  manifest for quay.io/cilium/cilium-runtime:2020-03-23 not found: manifest unknown: manifest unknown
13:17:27  Makefile:222: recipe for target 'docker-image-no-clean' failed

https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18139/execution/node/55/log/
13:17:27  Step 10/20 : FROM quay.io/cilium/cilium-runtime:2020-03-23
13:17:27  manifest for quay.io/cilium/cilium-runtime:2020-03-23 not found: manifest unknown: manifest unknown
13:17:27  Makefile:222: recipe for target 'docker-image-no-clean' failed

It has been tagged already, so should be resolved. The error I saw in my run:
  [2020-03-23T21:54:09.900Z] Interpreting /root/.vagrant.d/boxes/cilium-VAGRANTSLASH-ubuntu/169/virtualbox/box.ovf...
  [2020-03-23T21:54:09.900Z] OK.
  [2020-03-23T21:54:09.900Z] 0%...
  [2020-03-23T21:54:09.900Z] Progress state: NS_ERROR_INVALID_ARG
  [2020-03-23T21:54:09.900Z] VBoxManage: error: Appliance import failed
  [2020-03-23T21:54:09.900Z] VBoxManage: error: Code NS_ERROR_INVALID_ARG (0x80070057) - Invalid argument value (extended info not available)
  [2020-03-23T21:54:09.900Z] VBoxManage: error: Context: "RTEXITCODE handleImportAppliance(HandlerArg*)" at line 957 of file VBoxManageAppliance.cpp

According to https://www.virtualbox.org/ticket/18343 the issue aside from buggy vbox is After hours of investigations, the problem is basic. There was not enough space on the disk to create the VM files.

Several indicators of unhappy CI node running out of space on the latest run:
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18141/
I'll re-run.

test-me-please

test-me-please

test-me-please

test-me-please

provision error, retrying:
09:41:32      k8s1-1.11: 55769680e827: Download complete
09:41:32      k8s1-1.11: 3b6795100674: Verifying Checksum
09:41:32      k8s1-1.11: 3b6795100674: Download complete
09:41:32      k8s1-1.11: 15357f5e50c4: Verifying Checksum
09:41:32      k8s1-1.11: 15357f5e50c4: Download complete
09:41:33      k8s1-1.11: 5dcdacb923a0: Verifying Checksum
09:41:33      k8s1-1.11: 5dcdacb923a0: Download complete
09:41:37      k8s1-1.11: 50e431f79093: Pull complete
09:41:38      k8s1-1.11: dd8c6d374ea5:
09:41:38      k8s1-1.11: Pull complete
10:09:29  Cancelling nested steps due to timeout
10:09:29  Sending interrupt signal to process
10:09:30  Cancelling nested steps due to timeout
10:09:40  Sending interrupt signal to process
10:09:41  script returned exit code 255

test-me-please

CI infra issues again :-/ No space left on device
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18155/
11:10:27  	from /opt/vagrant/embedded/lib/ruby/2.4.0/tmpdir.rb:86:in `mktmpdir'
11:10:27  	from /opt/vagrant/embedded/gems/2.2.4/gems/vagrant-2.2.4/lib/vagrant/util/platform.rb:229:in `fs_case_sensitive?'
11:10:27  	from /opt/vagrant/embedded/gems/2.2.4/gems/vagrant-2.2.4/lib/vagrant/util/platform.rb:247:in `fs_real_path'
11:10:27  	from /opt/vagrant/embedded/gems/2.2.4/gems/vagrant-2.2.4/lib/vagrant/environment.rb:124:in `initialize'
11:10:27  	from /opt/vagrant/embedded/gems/2.2.4/gems/vagrant-2.2.4/bin/vagrant:145:in `new'
11:10:27  	from /opt/vagrant/embedded/gems/2.2.4/gems/vagrant-2.2.4/bin/vagrant:145:in `<main>'
11:10:27  sh: echo: I/O error
11:17:42  wrapper script does not seem to be touching the log file in /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.18-gopath/src/github.com/cilium/cilium/test@tmp/durable-c05f1046
11:17:42  (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)
11:17:43  Cannot contact jenkins-fixed-4: java.io.IOException: No space left on device
11:22:47  wrapper script does not seem to be touching the log file in /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.18-gopath/src/github.com/cilium/cilium/test@tmp/durable-c05f1046

test-me-please

(On CI there were many old boxes, they were cleaned up to make some free space, lets see whether it helps.)

12:17:52      k8s2-1.11: [discovery] Failed to request cluster info, will try again: [Get https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-public/configmaps/cluster-info: dial tcp <IP_ADDRESS>:6443: connect: no route to host]
12:17:55      k8s2-1.11: [discovery] Failed to request cluster info, will try again: [Get https://<IP_ADDRESS>:6443/api/v1/namespaces/kube-public/configmaps/cluster-info: dial tcp <IP_ADDRESS>:6443: connect: no route to host]
12:18:01  Cancelling nested steps due to timeout
12:18:01  Sending interrupt signal to process
12:18:01  script returned exit code 255

test-me-please

Same issue, out of disk space again:
13:12:23  Cannot contact jenkins-node-0: java.io.IOException: No space left on device
13:17:27  wrapper script does not seem to be touching the log file in /home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated@tmp/durable-d0a5e8ca
13:17:27  (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)
13:22:04  Cancelling nested steps due to timeout

(Temporarily removing vbox image upgrade patch.)

test-me-please

test-me-please

Same stuff :-(
17:37:39  Progress state: NS_ERROR_INVALID_ARG
17:37:39  VBoxManage: error: Appliance import failed
17:37:39  VBoxManage: error: Code NS_ERROR_INVALID_ARG (0x80070057) - Invalid argument value (extended info not available)
17:37:39  VBoxManage: error: Context: "RTEXITCODE handleImportAppliance(HandlerArg*)" at line 957 of file VBoxManageAppliance.cpp

test-me-please

test-focus K8sDataPathConfig.*

test-focus K8sDatapathConfig.*

test-focus K8sDatapathConfig.*

test-focus K8sDatapathConfig.*

From prior run (https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18170/) the only two failed tests in k8s-1.{11,18} are now fixed and have passed in (https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/18201/). Therefore the test suite should now pass (aside from CI infra issues getting in the way). Therefore, rerunning the whole suite once more.

test-me-please

test-me-please


Improve user logging file structure

Modified the user logging directory to prevent errors from occurring when the user running a command is different from the alluxio installation user.
@ZacBlanco or @aaudiber PTAL

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3034/
Test PASSed.

@aaudiber fixes done. Please help to merge.

@ns1123 just waiting for build to pass, then I'll merge

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3035/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3036/
Test PASSed.

alluxio-bot, merge this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3037/
Test PASSed.

alluxio-bot, cherry-pick to branch-1.8 please


Fix for some grammar and spelling

[x] documentation is added or updated

The CLA: trivial needs to be placed in the commit message body (i.e. after an empty line after the commit message subject) and not in the subject.

I suppose this would be acceptable with CLA: trivial although the patch is not small.

The CLA: trivial needs to be placed in the commit message body (i.e. after an empty line after the commit message subject) and not in the subject.

How to fix the commit messaege? I forgot the empty line

Making another pull request.

How to fix the commit messaege? I forgot the empty line.

git commit --amend
and then
git push --force


cannot install lxd on Debian 10: snap "lxd" assumes unsupported features: snapd2.39

Required information

Distribution: Debian
Distribution version: 10

Issue description
It is no longer possible to install LXD via snap on Debian 10 because the LXD snap version require a snapd version that is not available.
Steps to reproduce
root@srv-324:~ # snap install --channel 4.0/stable lxd
error: cannot perform the following tasks:
- Mount snap "lxd" (14954) (snap "lxd" assumes unsupported features: snapd2.39 (try to update snapd and refresh the core snap))
root@srv-324:~ # apt-cache policy snapd
snapd:
  Installed: 2.37.4-1+b1
  Candidate: 2.37.4-1+b1
  Version table:
 *** 2.37.4-1+b1 500
        500 http://ftp.fr.debian.org/debian buster/main amd64 Packages
        100 /var/lib/dpkg/status
root@srv-324:~ # uname -a
Linux srv-324 4.19.0-9-amd64 #1 SMP Debian 4.19.118-2 (2020-04-29) x86_64 GNU/Linux
root@srv-324:~ # snap refresh
All snaps up to date.
root@srv-324:~ # snap list
Name    Version   Rev   Tracking  Publisher   Notes
core18  20200427  1754  stable    canonical✓  base

Found this: https://forum.snapcraft.io/t/snap-lxd-assumes-unsupported-features-snapd2-39/17542
So the error message is wrong. Can a snap depends on an other one? If that's the case, core should be installed first.
For anyone searching for the solution:
root@srv-324:~ # snap list
Name    Version   Rev   Tracking  Publisher   Notes
core18  20200427  1754  stable    canonical✓  base
root@srv-324:~ # snap install core
2020-05-18T15:26:03+02:00 INFO Waiting for restart...
core 16-2.44.3 from Canonical✓ installed
Channel latest/stable for core is closed; temporarily forwarding to stable.
root@srv-324:~ # snap list
Name    Version    Rev   Tracking       Publisher   Notes
core    16-2.44.3  9066  latest/stable  canonical✓  core
core18  20200427   1754  latest/stable  canonical✓  base
root@srv-324:~ # snap install --channel 4.0/stable lxd
Warning: /snap/bin was not found in your $PATH. If you've not restarted your session since you
         installed snapd, try doing that. Please see https://forum.snapcraft.io/t/9469 for more
         details.

lxd (4.0/stable) 4.0.1 from Canonical✓ installed
root@srv-324:~ # snap list
Name    Version    Rev    Tracking       Publisher   Notes
core    16-2.44.3  9066   latest/stable  canonical✓  core
core18  20200427   1754   latest/stable  canonical✓  base
lxd     4.0.1      14954  4.0/stable     canonical✓  -

This is a snapd issue, not something we can influence sadly.

Snaps cannot depend on each other. The closer snapd let's us do is require a particular snapd version which is exactly what we did and what's causing this message.
Newer snapd is I believe more clever about this but since the issue is about regressing it, there's a chicken and egg problem there...

I see, unfortunate. I added the installation of the "core" snap package to our installation process of LXD.


Use HTTPHeaderDict in request

Supersedes #633

This might not be perfect, but it at least passes the test_collections tests. And it's late here =P

Tests are failing because there isn't that tests the get method directly of the HTTPHeaderDict.

Broadly LGTM.

Mmmm yea this is a smaller change than I thought we'd need. If you can make the remaining test(s) pass, I'm all for it. :)

Btw, :custard:.

So the tests should pass now. The thing that I'm uncertain about is this test. I can definitely see that dict(HTTPHeaderDict(baz='quuz')) == {'baz': 'quuz'} but something else is turning that into {'Baz': 'quuz'}. I haven't investigated it yet.

Hm wonder if it's our dummyserver and/or httplib mangling headers on some versions.

Hm wonder if it's our dummyserver and/or httplib mangling headers on some versions.

It's more bizarre because this test was passing before we fixed the round-trip behaviour. =/

If I debug into the request methods, I get to
(Pdb) p kw['headers']
{'Accept': '*/*', 'baz': 'quux', 'Host': 'localhost:52261'}

On L276 in urllib3/poolmanager.py

If I go further, it's still the right case in connectionpool.py. I don't have much time to go further though. Sorry. =(

For anyone else looking to follow the same rabbit hole.

Add import pdb; pdb.set_trace() (or ipdb if that's your thing) to test/with_dummyserver/test_proxy_poolmanager.py at L238.
tox -e py27 -- -s test.with_dummyserver.test_proxy_poolmanager (or py34 or whatever)
Start stepping into functions that make the request.

So this isn't in httplib: the header is emitted in the case it was provided to httplib. Current money is on the dummyserver doing that.

Definitely the dummy server. From tcpdump:
GET http://localhost:62953/headers HTTP/1.1
Accept-Encoding: identity
Accept: */*
Host: localhost:62953
baz: quux
foo: bar

HTTP/1.1 200 OK
Etag: "feb15a7ce2766d24cf20cf1633197fc5d8a59281"
Date: Sun, 19 Jul 2015 10:22:50 GMT
Content-Length: 146
Server: TornadoServer/4.1
Content-Type: text/html; charset=UTF-8,text/plain

{"Accept": "*/*", "Content-Length": "0", "Foo": "bar", "Connection": "close", "Host": "localhost:62953", "Accept-Encoding": "gzip", "Baz": "quux"}

We definitely emitted headers in lowercase, they were definitely reflected to us in upper-case.

Note also that the dummyserver inserts some headers we didn't send (Connection: close) and mangles one we did send (Accept-Encoding: gzip).

Ok, so had a quick chat with @shazow and I think that test should just be rethought. We can't effectively test that case is preserved when we round-trip via the dummy server, so let's just not.
I can see a case for wanting a test that ensures that case is preserved that includes httplib, but if we're going to do that we should do it as a socket-level test where we can confirm that the bytes-on-the-wire are really what we think they are.

So b49490d has a socketlevel test for this.

Yay :Custard:!
Are we good to go? Shall I merge and ship v1.11?

That's Cory's call.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Let's rock-and-roll. :shipit:

This causes OpenStack devstack-gate tests to fail on Fedora 21 (but not on Ubuntu). There are interactions between many python packages during the test, so I am not yet certain if it is urlib's fault, but if I use the commit previous to the merge of this pull request, tempest tests pass.

@mmedvede Can we get more information, e.g. a link to a Launchpad bug?

@Lukasa it appears they're tracking it in https://bugs.launchpad.net/glance/+bug/1476770. The original bug was because the gate is not operating as it is supposed to (and I suspect the same is happening on Fedora). The gate should always be installing requests from pip instead of using system packages but they're not so when they install urllib3 1.11.0, it installs over the system urllib3 that was installed. I maintain that this is fundamentally a problem with the gate. Note that instead of fixing the gate, they released a new version of oslo.vmware (the only library to use urllib3 in openstack directly) with a cap to exclude 1.11.0. This is not a problem or a bug in urllib3.

@sigmavirus24 I was not aware of the bug, thanks. It is exactly what was happening to our third-party Fedora 21 gate (IBM PowerKVM CI) before I disabled the urllib3 1.11 install. I assume that Ubuntu installs newer system python-requests, so when urllib3 1.11 is installed on top, the gate doesn't break. The weird thing is that both Ubuntu and Fedora gates show requests 2.7.0 installed. I have confirmed that doing 'pip install --upgrade --force-reinstall requests' fixes Fedora 21 in my scenario, even though requests would still show as being 2.7.0.
@Lukasa Thanks for quick response. Not urllib3 problem.

@mmedvede check where requests 2.7.0 is installed from. You'll see that it's installed from the system packages and that is not what the gate is supposed to do. Anyway, further discussion should happen on LaunchPad, not here.

This change requires all requests-cache caches be deleted.


cut audio when video ends

https://superuser.com/questions/1130638/ffmpeg-cut-audio-to-video-length-if-its-longer-in-video-file
to use on dash cam videos

Created custom application for processing videos.


My feeds marked "Read" automatically after 1 month

I was shocked when I knew it, commafeed automatically marked my feeds as "read" after 1 month, this wasn't the case some time ago, without a notification, commafeed let me down.

Well, it's been like this since https://github.com/Athou/commafeed/commit/150920e0c894eb286492ba487be688043cf6d588 (19 months ago)

Is there any way (option?) to keep them?

Not on commafeed.com. You can host commafeed on your own server.

Thanks

I thought this is because of database size, but now I thought, if they are still listed as read, they should have no effect on the disarray side

I thought this was because of the database size, but now I thought, if they are still listed as read, they should have no effect on the database size, can you please add an option for how much time does it take before marking as read automatically?

It is because of database size.
Read statuses are deleted after a month, but the entries are kept longer. Entries that are older than a month are automatically shown as read.

I thought a boolean flag will not affect the database size that much (compared to a link), however, thank you for commafeed :)

A boolean flag for each feed entry for each user. It's not really the size that matters but really the number of rows that are needed to store the information.

I'm somehow new to databases, so thank you for the info, and for giving me the motivation to try PostgreSQL instead of MySQL


Allow request timeout to be configured in NettyTransport

Coverage increased (+0.02%) to 47.973% when pulling 7099279e1c5ec57936d816f067daa0e60499e8fb on netty-request-timeout into 4ca87c5f28a1a9d2607447856c1d9924f1e81212 on master.


Dashboard Skeleton

User stories
As a user I want to get informed about the most important information relevant to me when opening the web-application in order to know if I missed something.
Dependencies
Depends on:

#3
#4
#5

Needs me implemented:

#38
#39
#40
#41

UI Mockup

Acceptance criteria

[x] Welcome message at the top also displaying the users name
[x] Placeholder for unread messages #38 (located at the very top underneath the users name)
[x] Placeholder for lent articles #39
[x] Placeholder for offered articles #40
[x] Placeholder for wishlist #41
[x] Design should include: correct font & font size, correct colours, appropriate object positions
[x] Space for navigation bar #3

Po Review is done!

Merge into main/dev branch is missing


Nifi on ubuntu 16.04

Hi,
Could i setup the version of nifi with ansible on a ubuntu 16.04 ?
thanks.
best regards.

Hi, I'm not sure that's possible at the moment.
I haven't tested/adapted these blueprints yet on Ubuntu 16 but I plan to do it soon.
Last time I checked it was a long time ago, and Ansible was not supporting Python 3 (since Ubuntu 16 doesn't have Python 2 by default).
NiFi/HDF works on Ubuntu 16, so it's only a matter of testing these playbooks.

Hi Alexandru,
i did it, i changed all the files "debian-ubuntu-14.yml" to "debian-ubuntu-16.yml" and every things is ok.
but i have a problem to start nifi.
do you have an idea ?
my error is
2018-07-03 17:17:31,446 ERROR [main] org.apache.nifi.NiFi Failure to launch NiFi due to java.net.ConnectException: Connexion refusée (Connection refused)
java.net.ConnectException: Connexion refusée (Connection refused)
regards

Hi, sorry for the late reply, but I really couldn't understand much from your issue (the error message if very generic - could be an environmental issue).
I have now made some changes to support Ubuntu 16 and in all my tests NiFi was deployed and running fine on Ubuntu 16.
Please pull the latest code, try again, and let me know if you still have issues, but with more information (including the AMI id).


Proposal: Remove all extensions accepting "string message, params object[] args"

Several times over the last few months, my team has attempted to use our own extensions to ILogger, but were unaware until looking at the logs that the default LogDebug/etc implementation was used because of the "string message, params object[] args" signature accepting what should calls to a different override.
The overrides I'm asking to be removed can be replaced with the $"{variable}" syntax in newer version so f C#; for older versions consumers can always call String.Format themselves.
This would result in a breaking change, but would add the benefit of the compiler ensuring that the correct override is called (or can't be found).

To answer a few questions above, the reason for this requested change was the issue with other extension methods like the following:
public static void LogDebug(this ILogger logger, string message, ILoggable loggable)
{
    ...
}

Such an extension method works as long as Microsoft.Extensions.Logging AND our custom namespace are pulled in with using statements.  If a developer (including me) forgets to reference our custom namespace, the code still compiles, but uses the Microsoft.Extensions.Logging version of the LogDebug method, and we only find out after a deployment and the logs are examined.
I think it's really easy to find ourselves in this situation, and if there is an alternative way to prevent this (without renaming the LogDebug method), I'd love to hear suggestions.

I would suggest to put loggable before message (if you can).

I would make a roslyn analyzer that detects if they're calling the "wrong" overload and you can create a code fix to import your namespace. Should be pretty simple and doesn't involve changing the aspnet/logging system to suit your use case.


Dogecoin bridge requesting a much higher miner fee than required.

If you didn't know, there was a recently an update to the dogecoin network to decrease the amount of fees needed to transfer DOGE.
Before it was 4-5 DOGE, now transactions with 0.001 DOGE (1000 sat/b) attached to them confirm in 1 minute.
I notice that the REN bridge (https://bridge.renproject.io) still asks for a 5 DOGE miner fee to bridge DOGE to renDOGE.
Are there any plans to support the new DOGE fees? It would significantly make bridging much more frictionless.
Current fees:
500 DOGE -> 493.13 renDOGE (-1.37%)
New fees:
500 DOGE -> 498.12 renDOGE (-0.37%)

+1
A feature to be able to set custom transaction fees.  This is with bitcoin though, not doge but still related


Check specific streaming service

Allow user to select streaming service in checkbox (Amazon, Netflix, Disney) to be applied for skip

Add AppleTV+ skip ad


Fix case with empty notifier - sink should not get terminated

If we want to comply to Rx semantics this has been a bug: https://github.com/ReactiveX/rxjs/blob/2979ec168855a18cece695652a83f8f5af1a9437/spec/operators/takeUntil-spec.ts#L33
When "fixing" this I've realized lately that at least part of the former behavior was intentional on your part since: https://github.com/franciscotln/callbag-take-until/commit/67b17b3b77f0f0720fed2e6475037be274b793eb , but I don't believe that chosen behavior was good. For instance, it was not possible to unsubscribe from the source in certain situations and this should always be possible.

@franciscotln friendly 🏓


CMake build requires users have MS Visual C++ Redistributable installed

The CMake build script produces a Windows version of the toolkit DLL that requires that users have a copy of the MS Visual C++ Redistributable library (I think it has to be the 2017 version but I'm not sure) installed on their machine. The Makefile.bat script in the project's win_build directory builds a DLL that has the necessary library functions linked into it. (Hence the CMake-produced DLL is only 198 KB in size while the Makefile.bat DLL is 334 KB). The CMake script can be modified to produce a DLL that doesn't rely on the C++ Redistributable library by adding a definition "-MT" to it. Do people think this is an issue that's worth addressing?

Sure, I think we want a stand alone DLL.


SSL Error with .exe File Not Occurring in IDE

Hello,
I am experiencing an issue with my Python script when it is converted to an .exe file. The script runs perfectly when executed in Visual Studio Code, but it generates an SSL error when run as an .exe file. Here's the error message I receive:
requests.exceptions.SSLError: HTTPSConnectionPool(host='keepersecurity.eu', port=443): Max retries exceeded with url: /api/rest/sm/v1/get_secret (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)')))
Do i need to import specific file on my .exe ?
Regards

Hello, Indeed i'm behind a company proxy :/ I tried on my own computer and it worked

Company proxy issue


Javadoc generation fails with tag-like doc field

Prerequisites

[x] Are you running the latest version of the plugin? (Check releases)
[x] Are you running a supported version of Gradle? (Check the README)
[x] Are you running a supported version of Apache Avro? (Check the README)
[x] Are you running a supported version of Java? (Check the README)
[x] Did you check to see if an issue has already been submitted?
[x] Are you reporting to the correct repository?
[x] Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.
Describe the bug
If doc field includes a tag-like value such as "<first name>", Javadoc generation fails.
To Reproduce
Steps to reproduce the behavior:

Sample project: https://github.com/izeye/samples-java-branches/tree/avro
Sample schema file:

{
  "namespace": "learningtest.avro",
  "type": "record",
  "name": "User",
  "doc": "User.",
  "fields": [
    {
      "name": "name",
      "type": "string",
      "doc": "Name. <first name> <last name>"
    },
    {
      "name": "favorite_number",
      "type": [
        "int",
        "null"
      ],
      "doc": "Favorite number."
    },
    {
      "name": "favorite_color",
      "type": [
        "string",
        "null"
      ],
      "doc": "Favorite color."
    }
  ]
}

Run the following command:

./gradlew clean javadoc

Errors:

> Task :javadoc FAILED
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:75: error: unknown tag: first
  /** Name. <first name> <last name> */
            ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:75: error: unknown tag: last
  /** Name. <first name> <last name> */
                         ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:91: error: unknown tag: first
   * @param name Name. <first name> <last name>
                       ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:91: error: unknown tag: last
   * @param name Name. <first name> <last name>
                                    ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:126: error: unknown tag: first
   * @return Name. <first name> <last name>
                   ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:126: error: unknown tag: last
   * @return Name. <first name> <last name>
                                ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:135: error: unknown tag: first
   * Name. <first name> <last name>
           ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:135: error: unknown tag: last
   * Name. <first name> <last name>
                        ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:273: error: unknown tag: first
      * Name. <first name> <last name>
              ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:273: error: unknown tag: last
      * Name. <first name> <last name>
                           ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:283: error: unknown tag: first
      * Name. <first name> <last name>
              ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:283: error: unknown tag: last
      * Name. <first name> <last name>
                           ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:296: error: unknown tag: first
      * Name. <first name> <last name>
              ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:296: error: unknown tag: last
      * Name. <first name> <last name>
                           ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:306: error: unknown tag: first
      * Name. <first name> <last name>
              ^
/Users/user/IdeaProjects/samples-java-branches/build/generated-main-avro-java/learningtest/avro/User.java:306: error: unknown tag: last
      * Name. <first name> <last name>
                           ^
16 errors

Expected behavior
Escape doc fields to be rendered properly for Javadoc.
Environment (please complete the following information):

Gradle Version: 6.5
Apache Avro Version: 1.9.2
Gradle-Avro Plugin Version: 0.20.0
Java Version: 11.0.6
OS: macOS High Sierra

Additional context
N/A

I'm sorry you're having problems, but this isn't a problem with this project (gradle-avro-plugin).  If you want this behavior changed, please submit a ticket with the Apache Avro project.
As demonstrated below, this behavior is manifested when using the command-line Avro compiler:

Store the provided schema as User.avsc
Download avro-1.9.2.jar and avro-tools-1.9.2.jar from https://avro.apache.org/releases.html#Download
Run java -jar avro-tools-1.9.2.jar compile schema User.avsc out
Check the output in out/learningtest/avro/User.java
Run javadoc -classpath avro-1.9.2.jar out/learningtest/avro/User.java and see that it produces errors.

In your case, you can fix the errors by escaping the unintended HTML tags in the docstring.  The updated line in your schema file would look like this:
"doc": "Name. <first name> <last name>"
If you want such escaping to happen automatically, it should be done by the compiler produced by the Apache Avro project.

@davidmc24 Thanks for the quick feedback!
I created https://issues.apache.org/jira/browse/AVRO-2869.


Supports arduino-cli

I added supports for arduino-cli.
How to compile with arduino-cli

Install arduino-cli
Install esp32 arduino core with command

arduino-cli core update-index
arduino-cli core install esp32:esp32

Compile code with command

arduino-cli compile .

Upload firmware

arduino-cli upload -p /dev/cu.usbmodem01

See Makefile for more details

Thanks !
Looks like the PR unintentionnally brought the ESPTinyUSB library,

I've integrated your changes in a separate commit.
arduino-cli has a very limited dependency resolver and will only pick the main branch of the git-url, so I made some modifications to the Makefile to make sure the right library version is pulled on first run.
thanks again !


Gist index not supported on prisma schema

Bug description
Hello
I'm introspecting my database and this is the schema that is being generated when I use the prisma cli and run npx prisma db pull.
model appointment {
  account_id String                   @default(dbgenerated("(current_setting('app.account'::text))::uuid")) @db.Uuid
  id         String                   @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  date       Unsupported("tstzrange")
  patient_id String                   @db.Uuid
  is_paid    Boolean                  @default(false)
  is_active  Boolean                  @default(true)
  created_at DateTime                 @default(now()) @db.Timestamptz(6)
  patient    patient                  @relation(fields: [account_id, patient_id], references: [account_id, id], onDelete: NoAction, onUpdate: NoAction, map: "FK_Appointment_patient_id__Patient_id")
  account    account                  @relation(fields: [account_id], references: [id], onDelete: NoAction, onUpdate: NoAction)

  @@id([account_id, id], map: "PK_Appointment_account_id_id")
  @@index([account_id, date], map: "appointment_account_id_date_excl", type: Gist)
}

I get the following error once I try to generate the client by running npx prisma generate.
This is the error.
Error: Schema validation error - Error (query-engine-node-api library)
Error code: P1012
error: Error parsing attribute "@@index": The Gist index field type `Uuid` has no default operator class.
  -->  schema.prisma:54
   |
53 |   @@id([account_id, id], map: "PK_Appointment_account_id_id")
54 |   @@index([account_id, date], map: "appointment_account_id_date_excl", type: Gist)
   |

Validation Error Count: 1
[Context: getDmmf]

I thought Gist indexes where supported as stated on https://www.prisma.io/docs/concepts/components/prisma-schema/indexes#index-configuration
How to reproduce
Try to generate the prisma client based from this schema, use the cli npx prisma generate.
model appointment {
  account_id String                   @default(dbgenerated("(current_setting('app.account'::text))::uuid")) @db.Uuid
  id         String                   @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  date       Unsupported("tstzrange")
  patient_id String                   @db.Uuid
  is_paid    Boolean                  @default(false)
  is_active  Boolean                  @default(true)
  created_at DateTime                 @default(now()) @db.Timestamptz(6)
  patient    patient                  @relation(fields: [account_id, patient_id], references: [account_id, id], onDelete: NoAction, onUpdate: NoAction, map: "FK_Appointment_patient_id__Patient_id")
  account    account                  @relation(fields: [account_id], references: [id], onDelete: NoAction, onUpdate: NoAction)

  @@id([account_id, id], map: "PK_Appointment_account_id_id")
  @@index([account_id, date], map: "appointment_account_id_date_excl", type: Gist)
}

Expected behavior
The prisma client is generated with no errors.
Prisma information
model appointment {
  account_id String                   @default(dbgenerated("(current_setting('app.account'::text))::uuid")) @db.Uuid
  id         String                   @default(dbgenerated("gen_random_uuid()")) @db.Uuid
  date       Unsupported("tstzrange")
  patient_id String                   @db.Uuid
  is_paid    Boolean                  @default(false)
  is_active  Boolean                  @default(true)
  created_at DateTime                 @default(now()) @db.Timestamptz(6)
  patient    patient                  @relation(fields: [account_id, patient_id], references: [account_id, id], onDelete: NoAction, onUpdate: NoAction, map: "FK_Appointment_patient_id__Patient_id")
  account    account                  @relation(fields: [account_id], references: [id], onDelete: NoAction, onUpdate: NoAction)

  @@id([account_id, id], map: "PK_Appointment_account_id_id")
  @@index([account_id, date], map: "appointment_account_id_date_excl", type: Gist)
}

Environment & setup

macOS
Postgres 14
Prisma CLI Version : 4.3.1
Node 16.15.1

Prisma Version
4.3.1

Hi @gmwill934, could you please share the rest of your schema? We see that the appointment model references the patient and account models as well.
These are the operator classes of GiST we currently support for Postgres. We currently provide an escape hatch to use a custom operator class in GiST and Gin indexes, via ops:
@@index([account_id(ops: raw("")), date(ops: raw(""))], map: "appointment_account_id_date_excl", type: Gist)

Besides, I see the date field mentioned in the @@index is using the tstzrange extension, which is not supported by Prisma (I would have linked you to https://github.com/prisma/prisma/issues/3287, but I see you have already found that issue on your own ☺).

Before version 4,  the type property on @@index([account_id, date], map: "appointment_account_id_date_excl", type: Gist) was not added and worked perfectly, I'm doing introspection, so it breaks my CI CD because it errors out.
 Can you share the SQL of the appointment table (and maybe the ones it has relations with, although we can certainly clean that out if not)? Thanks.

Absolutely  @janpio
Account
create table account (
	id uuid not null default(gen_random_uuid()) primary key,
	email varchar(64) not null unique,
	password varchar(128) not null,
	first_name varchar(32) not null,
	last_name varchar(32) not null,
	city varchar(32) null,
	state varchar(32) null,
	is_verified boolean default(false) not null,
	created_at timestamp with time zone not null default(now())
);

Patient
create table patient (
	account_id uuid not null default(current_setting('app.account')::uuid) references account(id),
	id uuid not null default(gen_random_uuid()),
	email varchar(64) not null,
	first_name varchar(32) not null,
	last_name varchar(32) not null,
	street varchar(64) null,
	interior varchar(16) null,
	exterior varchar(16) null,
	zip varchar(16) null,
	neighborhood varchar(64) null,
	municipality varchar(64) null,
	city varchar(64) null,
	state varchar(64) null,
	tax_system varchar(16) null,
	country varchar (16) null default('MEX'),
	dob date null,
	rfc varchar(13) null,
	legal_name varchar(128) null,
	facturapi_customer_id varchar(32) null,
	is_active boolean not null default(true),
	created_at timestamp with time zone not null default(now()),
	constraint "PK_Patient_account_id_id" primary key (account_id, id),
	constraint "UQ_Patient_account_id_email" unique (account_id, email)
);

Appointment
create table appointment (
	account_id uuid not null default(current_setting('app.account')::uuid) references account(id),
	id uuid not null default(gen_random_uuid()),
	date tstzrange not null,
	patient_id uuid not null,
	is_paid boolean not null default(false),
	is_active boolean not null default(true),
	created_at timestamp with time zone not null default(now()),
	constraint "PK_Appointment_account_id_id" primary key (account_id, id),
	constraint "FK_Appointment_patient_id__Patient_id" foreign key (account_id, patient_id) references patient (account_id, id),
	exclude using gist (account_id WITH =, date WITH &&),
	constraint "CHECK_Appointment_date_lower_not_null" check (lower(date) is not null),
	constraint "CHECK_Appointment_date_lower_not_infinity" check (lower(date) > '-infinity'),
	constraint "CHECK_Appointment_date_upper_not_null" check (upper(date) is not null),
	constraint "CHECK_Appointment_date_upper_not_infinity" check (upper(date) < 'infinity')
);

Internal: Next step is to try to reproduce locally what @gmwill934 is seeing, and then figure out what is going on with that ops class.

Thanks

Is there a way I can help with this?

No change, next step is still for someone from Prisma to reproduce to confirm and understand the problem.

Actually, I fear I am missing some information here. The minimized SLQ for that exclude constraint from your table:
create table appointment (
	account_id uuid not null,
	constraint "foo" primary key (account_id),
	exclude using gist (account_id WITH &&)
);

leads to this error message:
ERROR: data type uuid has no default operator class for access method "gist"
  Hint: You must specify an operator class for the index or define a default operator class for the data type.

Do you have any extensions enabled on your database that add such an operator class for the column type uuid and index type gist?

Two follow up issues:

Support Exclusion constraints properly: https://github.com/prisma/prisma/issues/17514
In the meantime at least do not introspect wrongly as indexes: https://github.com/prisma/prisma/issues/17515

Yes, @janpio I do have the btree_gist extension activated

More info here

https://www.postgresql.org/docs/current/rangetypes.html

You can use the [btree_gist](https://www.postgresql.org/docs/current/btree-gist.html) extension to define exclusion constraints on plain scalar data types, which can then be combined with range exclusions for maximum flexibility. For example, after btree_gist is installed, the following constraint will reject overlapping ranges only if the meeting room numbers are equal...
The whole point of this is to delegate all of these validations when creating appointments to postgres, hence me using the tstzrange  type.

Any update on this?

Has there been any development on this?


Android Studio "ktfmt Settings" missing from Preferences

I'm trying to enable ktfmt for my project but I noticed that the setting is missing from my Preference pane. I'm using Android Studio 4.1.1 (on macOS) and installed the plugin directly from the Marketplace. I've restarted my IDE and I can't seem to find the "ktfmt Settings" option as described by the installation instructions. The instructions say it should be under the "Editor" group.
I've tried this on two separate computers and neither installations of Android Studio show this option after installing the plugin from Marketplace. Am I missing some configuration or setting?

I think it might have to do with ktfmt's requirement of JDK 11 and up, while AS uses JDK 8 (if I remember correctly).
IIRC, there's a way to run AS with a different runtime.
Can you paste your About screen? It should show the JDK version.
@tyvsmith and I discussed a way to make ktfmt work with JDK 8.

Gotcha, yeah here's my About screen. If that's the case, I'll have to see if I can change the runtime.

Installing the "Choose Runtime" plugin from Marketplace and changing my runtime to JDK 11 did make the option appear, guess that was it!

I should note that there are some stability issues with running JDK 11 with Android Studio. Specifically I'm getting an instant crash when opening XML layout files in Android Studio. I haven't found a JDK 11 runtime package that doesn't cause this issue so it's a little annoying right now. If anyone has a workaround or knows a stable runtime package to download from the "Choose Runtime" plugin, please feel free to share that.
A cursory search of "Android Studio java 11" on Google doesn't seem to pull up very many results. I assume it's not robust yet.

Progress on JDK 8 support: https://github.com/facebookincubator/ktfmt/issues/201


chore: fix macos build

What's changed and what's your intention?
As titled.

Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have passed make check and make test in my local envirorment.

Related issues or PRs (optional)

This PR may break hakari check on linux.

Fixed by #130


Update metadata property to support dynamic keys

Previously, the key property was restricted to a static field. This change enables the use of dynamic keys for hostname metadata, allowing greater flexibility in defining custom parameters.

[x] I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested
According to the documentation here the custom_metadata property should be
Record<string, string>

instead of
 export interface CustomMetadata {
    /**
     * Unique metadata for this hostname.
     */
    [key: string]: string;
  }

Additional context & links

thanks but this is generated from the openapi schemas and they are still not correct in the source of truth. once the service team corrects these, they will flow through to the SDKs. otherwise, this will be overridden on the next generation run.


dotnet command build and run.

When i trying to migrate aspnet dnx project to netcoreapp1.0 some packages not supported in dotnet core makes input "Object is not set to an instanse of object". But no "Wrong package in project.json file [blabla.bla:"1.1.0"]" or something like this is not shown so i do not know where exect problem is.

@daviatorstorm is this still reproing with the latest tools/bits?

Closing this due to the lack of activity.

The problem with dependencies in project.json. When all dependencies are resolved, problem disapeared.


Siemens EQ.9 Connect sensors 'state_class'

Hi, I already had an older Ticket open, where I complained about missing options (like statistics) from the HomeConnect app...
To be fair, it seems that I have installed the wrong (default) HomeConnect app - which does not provide these information...
Today, I have changed to the home-connect alt integration - and in fact, I do get several statistics from the device (not all, but much better than in the old setup ;) )
BUT:
I noticed, that some of the counters could be improved...
It would be great, if they could get a state_class attribute (total_increasing)... this would allow to generate further statistics (like amount cups of coffee per day / week... etc.)
for example:
sensor.siemens_ti*******_*********45de_consumerproducts_coffeemaker_status_beveragecountercoffee
state: 306
device_class: home_connect_alt__status
icon: mdi:gauge-full
friendly_name: Siemens Kaffeevollautomat - Anzahl Kaffeegetränke

furthermore - the device class given here - is at least no official device class from HomeAssistant... ;)

The integration is completely generic, every appliance exposes different controls and metrics and the integration automatically exposes in Home Assistant everything that is made available by the API. The integration is using metadata exposed by the API to know the type of value but that information doesn't go as deep as what you are looking for so there is no way to do it other than manually mapping all the data fields, which is not something I plan to do.

hm... okey, thank you.
but still, one question might be allowed here :)
Checking the statistics information provided by the application - it seems:
sensor.siemens_ti9578x1de_68a40e8445de_consumerproducts_coffeemaker_status_beveragecounterhotwater
Counter Hot-Water seems to be a "numeric" value - statistic can be generated.

it does have a unit_of_measurement, which is "ml"...
unit_of_measurement: ml
device_class: home_connect_alt__status
icon: mdi:gauge-full
friendly_name: Siemens Kaffeevollautomat - Menge Heißwasser

for the other sensors - like
sensor.siemens_ti9578x1de_68a40e8445de_consumerproducts_coffeemaker_status_beveragecountercoffee
we do not have a unit_of_measurement (OK, HomeAssistant does not provide "cups" as a measurement, I guess ;)"
And this is why we can't see any type of statistic here, right?
device_class: home_connect_alt__status
icon: mdi:gauge-full
friendly_name: Siemens Kaffeevollautomat - Anzahl Kaffeegetränke

When the units are provided by the API the integration uses it to set the HA entity units. If you don't see it then the API doesn't have it.

What would you expect to see?

unit_of_measurement: none
Should give us a graph line

I've released 0.6.0-b1 that tries to handle this scenario while also allowing to explicitly set the units for entities in the configuration.
Try it (you have to allow beta versions in HACS in order to see it) and let me know if it works for you.

The Beta doesn't work for me, I can try it again with log later.

Doesn't work how?

Same issue, see https://github.com/ekutner/home-connect-hass/issues/159

If you have the same issue then you didn't add the configuration for setting the units. Anyway, that is fixed now.

Okay thank you very much,
I don't know how to add the config... (not yet)

In the README

Hi,
I've noticed that change in the new beta (?) [don't know if it is still beta]...
And came across the following:
I do have a binary_sensor in my application - that does not have a specific Device_class...
binary_sensor.siemens_ti9578x1de_68a40e8445de_connected

I would consider, that this specific entitiy should be device_class = connectivity
Example:

This would also allow the usage of the new state color options provided by HomeAssistant, where you can define specific colors on device_class level.
Could this be added (at least) as optional configuration as shown in the readme for unit / icon?

You can actually already do it in the configuration. Just add
entity_settings:
  Connected:
    class: connectivity

thanks, great :)

Yes if you set it to none it looks like this:

When you set it to none you are actually setting it to the string "none". If you want to set it to nothing then you should use null

Hi,
one question about the "unit of measurement"...
is it possible to handle "cup / cups"  somehow?

Meaning: 1 Cup or 2 Cups (0 Cups) ...

Also, do we have an option to change the Icon based on the state of an entity?
For example:
The Switch "Cup-warmer" - I would like to use the "coffee-off-outline" icon when the sensor / switch is off and the coffee-outline icon when it is on.
Right now, it is using the "slider" icon by default - and with the entity settings, I could change the default color - but don't know, if I can change the icon based on the state... :)

I'm not aware of a way to change the units from singular to plural and custom state dependent icons are also not supported.


"Fix" @todos In Test Specs

There are a fair number of @todo notes in the tests based on when other functionality will be implemented. So, at some point in the future when work is towards a stopping point, the tests should be looked over to add more tests that cover the todo basis.

well...since they are marked @todo in the code...that's probably a good enough reminder, lol.


CASMNET-2179 - Document kea arm64 and node-specific boot file functionality

Description
Document how to override the DHCP boot file name on a per-node basis.

Checklist

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.5


Add Offset Links Tab to the Topical Events Featurings Index Page in the GOV.UK Design System

Description
While adding the features page for World locations news i hadn't realised that there is also a features page for topical events.
Unfortunately there's fairly subtle differences in data modelling so i'm going to have to clean up and reuse a bunch of the partials used for World news locations and Orgs feature pages.
Unlike World location news and orgs, Topical events use TopicalEventFeaturings to feature documents. To keep the PRs reviewable i'm going to open 1 PR for each of the tabs.
This PR tackles the easiest of the tabs, the Non-gov links tab (offsite links).
The currently featured and document tab will be added in the next two prs.
Screenshots

Trello card
https://trello.com/c/EgRz8GpE/151-featured-page
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

Regarding your comment about whitespace, i agree it's bad! There's various gems that strip whitespace from a users input, or we could add our own method that does it down the line. We should def sort this though. We can adda card to the ideas/tech debt column

ah cool i hadn't realised the cancel link wasn't working there. I'll sort that now 👍


feat(sort-filter): search project by name

Description
I am activating the new feature to search projects by name using the search bar. Behind the scenes what I am doing is I am taking the registryAddress and the search bar input and sending it to the server to perform a search. The server fetches all the metadata objects and add them to the projects. Later on it filters them comparing the search value and the metadata.name value.
Considerations
This current implementation performs the search on the server because it avoids problems with React <InfiniteLoading> and useinfiniteQuery in the client side. These two use pagination for better data efficiency and I did not want to break that feature.
Drawback
The main drawback is that every time the user types in the search bar, a new network request gets send to the server. In scenarios where we have thousands of projects and limited internet connection, this could be a big problem.
@ctrlc03 @kittybest @crisgarner @0xmad what do you think? 😊

You can use useInfiniteQuery for pagination support and throttling or debouncing support with useDeferredValue to not send requests every time you type something in a search bar. Current solution is not optimized if we have a big number of projects and it sends the requests on every search input change.

I added the useDeferredValue in the Projects.tsx component. Is that okay? 😊

You can use useInfiniteQuery for pagination support and throttling or debouncing support with useDeferredValue to not send requests every time you type something in a search bar. Current solution is not optimized if we have a big number of projects and it sends the requests on every search input change.

I added the useDeferredValue in the Projects.tsx component. Is that okay? 😊

You still need to use useInfiniteQuery for pagination support. Also, there are some configuration for requests optimization.
Imagine if you have a big number of projects and they all starts with your search input value. You fetch them all but you only need one page of results.

@kittybest @0xmad hi guys! 😊
I added the fixes for your current comments and also pushed my housekeeping fixes to prevent console errors. Could you review the file changes? I added a comment to each file to explain a bit more what I was doing.
After your final approval I will squash the commits to merge this PR
Thank you for your help :)


Disable icons for Conversation settings, Clear conversation messages and context menu while response is generating

Description
Actual result: while response generating
Conversation settings - disabled
Clear conversation messages -  hidden
context menu -enabled
Expected result: disable icons for Conversation settings, Clear conversation messages and context menu
Note: also context menu should be disabled while Replay was started and executing
Use case/motivation
No response
Related issues
No response
Confidential information

[X] I confirm that do not share any confidential information

verified on staging successfully


add more information in summary page

Coverage decreased (-0.09%) to 43.615% when pulling 74d34a0ed34e51d6763d201be409ea1aec04aacb on 40huo:master into 51327a98c120080f8b5ecae3e0f4b112d6424b34 on wufeifei:master.


update storage client for plato

The meta client and storage client are designed for Plato only. It's should not be used by ordinary users

Write a case to test ssl connection for storage/meta client.

Write a case to test ssl connection for storage/meta client.

ok


[CA-1497] Add Billing Account Summary Panel to Billing Project

RR: https://broadworkbench.atlassian.net/browse/CA-1497
Add workspace billing account summary panel to billing project page. This panel summarises the status of the billing account changes applied to each workspace in the billing project. When there are errors, a link appears to contact support.
Mock-up here: https://www.sketch.com/s/59da26e3-a1a4-48f4-9a35-f39e2de22da9/a/bgaxn85

(yes - I'm aware it's meant to be fizzbuzz :D )

Just to be clear, you were right to merge this without waiting for my responses to your questions. Even if we find something we like better, the main value is in improving future code.


Bug: sort-enums breaks members referencing earlier members: "reference members declared after it,"

Describe the bug
I'm seeing cases where perfectionist/sort-enums is asking to reorder an enum to be in alphabetical/natural order, even though an enum member has to go last to reference earlier members.
Code example
enum ArgumentType {
  First = 1 << 0,
  RegExp = 1 << 1,
  Both = First | RegExp,
  //  ~~~~~~~~~~~~~~~~~
  // Expected "Both" to come before "RegExp". (eslint)
}

After fixing:
enum ArgumentType {
  Both = First | RegExp,
  First = 1 << 0,
  RegExp = 1 << 1,
}

$ npm run tsc

><EMAIL_ADDRESS>tsc
> tsc index.ts

index.ts:2:10 - error TS2651: A member initializer in a enum declaration cannot reference members declared after it, including members defined in other enums.

2   Both = First | RegExp,
           ~~~~~

index.ts:2:18 - error TS2651: A member initializer in a enum declaration cannot reference members declared after it, including members defined in other enums.

2   Both = First | RegExp,
                   ~~~~~~

Found 2 errors in the same file, starting at: index.ts:2

ESLint version
9.0.0
ESLint Plugin Perfectionist version
3.2.0
Additional comments
Isolated repro: https://github.com/JoshuaKGoldberg/repros/tree/perfectionist-order-enums-self-referencing
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Fixed in eeb0534. Released in v3.3.0.


Visual Studio debug profiles

Show how to setup and use debug profiles. E.g. switch between running on IIS Express and as a console app.

@danroth27 	is this a priority or can I close it?


Trace: comm_summary and comm_over_time

comm_summary computes total message count/volume sent and received per process

comm_over_time computes total message count/volume sent over time

We need to think about why we have an additional "MPISend" event within the "MPI_Send" event and if we can remove it.


Kate - 18448, song 749

Kate's notes:

SONG_ID | lat | lon |
-- | -- | -- | --
749 | 31.95 | 77.1 | Is assigned to culture "Khattak", but has the same recording location and lat lon as other songs recorded for the "Kullu" society

Should be Kullu. There is a typo in liner notes saying "Side I, Band 2 is a Khatak dance," but it should have said Side II Band 2. Side I Band 2 is indeed Kullu. Corrected. --Stella


SEO issues

Could having this site open to crawlers pose potential issues in clashes with the main site (nodejs.org)?
Would it be worth creating a robots.txt file that denies all crawlers, as well as adding no-index meta tags to both pages to ensure that neither page gets indexed?

#4 Adds the robots meta with noindex, nofollow but we should also consider a robots.txt file as not all crawlers listen to the meta tag.


Restructured to streaming API

Preliminary restructure to separate input streaming from output

I think this should probably be merged, even though some of the "old" features aren't present anymore. Otherwise someone new visiting the repo will be sort of confused.

Thanks for the comments. I've cleaned up the commits a little and will merge now.


Bump Dependencies #7189917880

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/7189917880

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-is-staging seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Adds tagged logging support and Logger::Formatter support

Builds on @mitnal's PR, which adds tagged logging support, and also adds support for logger formatters.
# Example formatter.
# Unlike most formatters, message is a hash.
# Must return a hash as well.
class MyGelfFormatter < Logger::Formatter
  def call(severity, datetime, facility, message)
    message.merge({
      pid: Process.pid
    })
  end
end

config.log_tags = [:uuid, :remote_ip]
config.logger = GELF::Logger.new("localhost", 12201, 'LAN', {
  tags: [:uuid, :remote_ip] # same order as config.log_tags !
})

config.logger = MyGelfFormatter.new

@meltingice Would you mind cleaning up those commits a little bit and rebase to current master? There are some unintended changes in this PR, like the unresolved conflicts in .travis.yml.

Seems like this is partly a duplicate of #35 now. Also, besides history cleanup, would you mind creating separate PRs for formatter support and tagged logging?

@milgner I would like to close this PR - CLA is still beding and this is kind of outdated and might need some love.
How would you decide?

As if the missing CLA i'll close this PR now


Pisces P100 LAN Port 1Gbps Issue

@shawaj We recently upgraded to a gigabit switch and all Pisces miners on Nebra OpenFleet firmware lost network connection.
This is a known issue which has been resolved by @inigoflores, please see the link below. Can this be incorporated into Nefra Open Fleet firmware please?
https://github.com/inigoflores/pisces-p100-tools/tree/main/1Gbps_LAN_Port_Fix
Thank you.

@vstrong-info not are how easily we can implement this but we will take a look

Ok looks like we can configure this over dbus with a network manager configuration.
https://developer-old.gnome.org/NetworkManager/stable/settings-802-3-ethernet.html
https://networkmanager.dev/docs/api/latest/nm-settings-dbus.html
Or possibly using ethtool
@vstrong-info would you mind being a guinea pig for this?

Possibly a better reference guide...
https://manpages.ubuntu.com/manpages/jammy/en/man5/nm-settings.5.html

Annoyingly, it doesn't look like ethtool advertise is exposed via NetworkManager but you can set the link speed so probably best option is to default to having it at 100 for pisces with an option to change it to 10 if necessary.

I would be happy to help. I will add you to my Balena organisation and give you developer permissions as well.

I would be happy to help. I will add you to my Balena organisation and give you developer permissions as well.

@shawaj , you already have permission for this device. https://dashboard.balena-cloud.com/devices/b3877407ccbc3c5453dc2d54fdef87b3
It is currently connected to 100/AUTO hardcoded switch port but you should be able to play with port config on the miner. Let me know if you need me to do anything. Thank you.


initial implementation of SpeakerEncoder forward function

Hey team, this is my initial implementation of the forward function for SpeakerEncoder.
I'm not too certain what the author is referring to in this part of the paper: Input 40-channel log-mel spectrograms are passed to a network consisting of a stack of 3 LSTM layers of 768 cells, each followed by a projection to 256 dimensions..
My interpretation is that, out of the 3 lstm layers, the initial lstm expects an input size of 40 (40 channels = input size of 40? unsure about the input shape as it's not implemented yet) and output dim of 256, and the rest of layers are set to 256 for both input and output dims.
However, looking at @CorentinJ's implementation, he used same sizes for all 3 of the layers by simply putting num_layers to 3.
What do you guys think?

Shouldn't the additional 256 dimensions get reintroduced through the hidden states that get propagated forward. I think it's ok to go with a single 3 layer LSTM block.

Shouldn't the additional 256 dimensions get reintroduced through the hidden or cell states that get propagated forward? I think it's ok to go with a single 3 layer LSTM block.

At any rate, the pytorch LSTM doc for num_layers seems to indicate that it should handle the case.


Maxpool data mismatch

This error was caught while running ResNet unique op tests.
Repro is available on branch dgolubovic/add-resnet-unique-op-tests-that-fail, and will hopefully be in main soon.
Run: 'pytest -svv forge/test/mlir/test_model_unique_ops.py::test_maxpool2d_resnet'
Error:
Tensor mismatch. PCC = -4.919688780169255e-05, but required = 0.99

This one is fixed on branch milant/maxPoolFixWithPermute. @mtopalovicTT feel free to close when these changes hit the main branch...