Upgrade three.js and aframe

⚠ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠
What kind of change does this PR introduce?

THis PR will upgrade Three.js and Aframe dependencies.
Can it be referenced to an Issue? If so what is the issue # ?
See issue #611 #504 #563 #535
How can we test it?

Test all the examples
Summary

Newer Three.js lib need to imported as a module so probably we need to create .module.js version for each build libs. Doing this probably we solve also issue #504
Does this PR introduce a breaking change?
I hope no but this is a draft PR.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Other information

i should have upgraded most of the three and aframe location-based examples, The only issue that i found is related to Aframe i got this warning:
renderer.js:39 THREE.WebGLRenderer: The property .useLegacyLights has been deprecated. Migrate your lighting according to the following guide: https://discourse.threejs.org/t/updates-to-lighting-in-three-js-r155/53733.
but i think there is not so much that we can do.

@nickw1 now all the examples should use aframe 1.6.0 and three 164, i applied all the changes you suggested in issue #611, i would merge it before 7 or 8 december, of course if you have nothing against. I haven't found any particular issue but let's do some more testing with the examples...

@kalwalt great! Will test the location-based examples and let you know if there's any problem but other than that, all should be good!

@kalwalt great! Will test the location-based examples and let you know if there's any problem but other than that, all should be good!

Thank you @nickw1! I have the same idea, probably there shouldn't be any issue. Just a quick question; do you have an idea because exists this file: https://github.com/AR-js-org/AR.js/blob/master/aframe/dist/main.js ?
I have made some fixes for the multiMarkers option in artoolkit5-js, not all the required methods are implemented yet but maybe after this PR i may concentrate to improve it.

@kalwalt I don't think that main.js is needed, because the bundles are placed in build. At a guess it was something which was committed accidentally.

@kalwalt have just tested the location-based examples.
Some comments:

some of the old location-based examples (in location-based) do not work, but the older versions of the location-based API are not really being maintained anymore and they don't work on master either. Can we just remove this directory? It will ease maintenance effort for one thing, only the new-location-based components have seen any updates for several years.

the new-location-based examples mostly work with this PR the same as they do on master. avoid-shaking doesn't seem to work on either. However the osm-ways example is non-functional with this PR, while it works fine on master. Let me see if I can investigate this.

Update on the above: I can get osm-ways to work if the a-camera is placed after the custom component, i.e.
<a-entity osm></a-entity> <!-- this does not work if placed AFTER the a-camera. -->
<a-camera gps-new-camera='gpsMinDitance:<a-entity osm></a-entity>
            <a-camera gps-new-camera='gpsMinDitance: 5; simulateLatitude: 51.049; simulateLongitude: -0.723' position='0 20 0' wasd-controls='acceleration: 1300'></a-camera>
 5; simulateLatitude: 51.049; simulateLongitude: -0.723' position='0 20 0' wasd-controls='acceleration: 1300'></a-camera>

Not sure if this is related to an internal change in A-Frame?

For the A-frame examples I haven't developed a module version as I did for the three.jsexamples. simply because for the vanilla J's examples wasn't required, but maybe it potentially could solve some issues loading as a module in React for example?

Some of the location examples do work, but they aren't using the new-location-based components so I'm thinking they maybe misleading. So are you still good for me to remove them?
I will do so in this branch if it's OK, as then we don't get master diverging.

The problem in osm-ways is odd because my Hikar webapp (using AR.js) works fine with aframe 1.6.0 and latest AR.js, the only issue is a PlaneBufferGeometry vs PlaneGeometry error in one of its dependencies (my own aframe-osm-3d lib which I can quickly fix). And in the Hikar webapp the camera is before the entity.
For now I think I'll rewrite the osm-ways example using the same template as some of the (working) examples, there is probably some difference I haven't spotted just yet.
With the reduce-shaking examples I think they need a real mobile device, come to think of it. Let me try on one.

@kalwalt a few updates:

reduce-shaking works fine on a real mobile device.
osm-ways also works fine on a real mobile device.

Related to the osm-ways issue, I have discovered an issue in which simulateLatitude and simulateLongitude do not generate the gps-camera-update-position event correctly if hard-coded in the HTML, though they do work when they are updated dynamically. This seems to be the case in master too, so maybe something which slipped in during a recent update.
However I am unlikely to have much time to look into this soon, so maybe it's best raised as a separate issue. I'm more likely to be focusing on locar.js in any case.
For the "old" location-based examples these seem to work fine:
avoid-shaking
click-places
max-min-distance
peakfinder-2d
The others appear to be using old coding standards.
What I propose in that case is to change the new-location-based example directory to location-based, move the four examples above to a classic-components subdirectory, and delete the rest. Does this sound good? Let me know if I can go ahead and do this.
It looks like there is nothing in this PR which stops the examples working, though.

@kalwalt a few updates:

reduce-shaking works fine on a real mobile device.
osm-ways also works fine on a real mobile device.

Related to the osm-ways issue, I have discovered an issue in which simulateLatitude and simulateLongitude do not generate the gps-camera-update-position event correctly if hard-coded in the HTML, though they do work when they are updated dynamically. This seems to be the case in master too, so maybe something which slipped in during a recent update.
However I am unlikely to have much time to look into this soon, so maybe it's best raised as a separate issue. I'm more likely to be focusing on locar.js in any case.
For the "old" location-based examples these seem to work fine:
avoid-shaking click-places max-min-distance peakfinder-2d
The others appear to be using old coding standards.
What I propose in that case is to change the new-location-based example directory to location-based, move the four examples above to a classic-components subdirectory, and delete the rest. Does this sound good? Let me know if I can go ahead and do this.
It looks like there is nothing in this PR which stops the examples working, though.

Those examples are not necessary, so much the better. Proceed as you suggested. As you finish I will implement the module feature for aframe as discussed.
In regards the issue you catch it for the gps-camera-update-position event, better to open a specific issue for kepp track of it.

I will do so in this branch if it's OK, as then we don't get master diverging.
Hadn't the time to answer you, yes of course, works on this branch!

OK - done.

OK - done.

thank you @nickw1 if i have time i will work on this sunday evening, we are close to finish this task.

Im testing an example in this gist but it's not loading properly, i will investigate it.

I'm not sure that the module aframe versions dist libs will be helpful. Let me explain, the AFRAME arjs system is heavily based on THREE dependencies (i'm not referring to the internal aframe super-three.js code) from AR.js internal API, this cause the multiple three.js instances error for example and a bigger file size, it' shouldn't be necessary but this was designed from the begginning (more or less), so what we can do now? we should redesign the whole code base, not for sure in this PR...

Maybe we should just stick with the "multiple three.js instances" warning now and try and re-design the code base as you say.

Maybe we should just stick with the "multiple three.js instances" warning now and try and re-design the code base as you say.

@nickw1 yeah maybe, i am a bit sad because i would release an updated AR.js, the redesign process will be a bit awkard, but maybe i'am wrong. I am convinced that for aframe-ar and all similar libraries, three.js is not necessary at all. For all calculations with matrices and maths, you can use a library like glm.js or gl-matrix.js. I think it would be a good idea to create a package AR.js-base or AR.js-core to include all the basic classes that may serve as root for AR.js and AR.js-threejs. Briefly i can start to convert this basilar classes:

Source
Profile
Context
ArBaseControls
MarkerControls

I think i can start with these, probably it's needed to add some more, but it's enough to start with.
I will redesign with the ES6 statndard in mind and maybe something more advanced standard. That is the Source  class instead use this signature:
Source = function (parameters) {
// the constructor
}

// the init prototype method
Source.prototype.init = function (onReady, onError) {
// init code...
}

a more modern approach:
class Source {
  constructor() {
  }

  init() {
  }

  //private method setParameters
  #setParameters()
}

I will start soon to create a new repository, and to work with the basis. We will think how to proceed with this PR.

@kalwalt your design sounds good. I think it makes sense to release AR.js with updated versions of A-Frame and three as soon as possible, then work on the redesign.
So presumably aframe-ar (NFT/marker based) just uses three.js for mathematical operations? I agree that it should not be necessary for this, as three.js is intended to be a rendering library rather than a general mathematical library.

@kalwalt your design sounds good. I think it makes sense to release AR.js with updated versions of A-Frame and three as soon as possible, then work on the redesign.

yes, the re-design process will take some time for sure. I think i will merge this PR in the next days.

So presumably aframe-ar (NFT/marker based) just uses three.js for mathematical operations?

The answer is not easy and fast but briefly i summarize what happens under the hood:
For the pattern/barcode and NFT markers we have the artoolkit5-js code that when detect one of them it dispatch an event with the matrixGL_RH (Right Hand OpenGL matrix). From artoolkit5-js we get also the camera Projection matrix. Inside AR.js we need them to pass the matrixGL_RH to the object3D (the root of the scene)  and camera projection Matrix to the three.js PerspectiveCamera. But inside Ar.js we smooth the matricies with three.js, this operation can be done with other matrix libs as well or in Aframe starting from the this.el.object3D.
I just started to develop a Ar.js-core testing library, as soon as i provide a reliable code i will push on it.
I'm thinking to drastically cut and simplify the aframe-ar.js code, it will help me in the code development to focus on the strictly necessary.
I would also improve and add more dcoumentations and infos on this topic when i will push the code in the repository.

@kalwalt thanks for the detail. I agree that it's a good idea to simplify the library: that was basically why I created locar.js, to focus on a small and tightly-focused location-based library which would be easier to work on and debug.

@nickw1  I will merge this PR tomorrow in the late afternoon, after making some final tests. i will wait few days for the release so if we find some bugs maybe we can fix them.

@kalwalt no worries!


error on opening compile vim with python support

Getting error when executing vim command on bash.
vim: error while loading shared libraries: libtinfow.so.6: cannot open shared object file: No such file or directory
What i did -
sudo apt-get install libncurses5-dev libgnome2-dev libgnomeui-dev \     libgtk2.0-dev libatk1.0-dev libbonoboui2-dev \     libcairo2-dev libx11-dev libxpm-dev libxt-dev python-dev ruby-dev mercurial
Removed existing vim
sudo apt-get remove vim vim-runtime gvim vim-tiny vim-common vim-gui-common
hg clone https://code.google.com/p/vim/ cd vim ./configure --with-features=huge \             --disable-darwin \             --disable-selinux \             --enable-luainterp \             --enable-perlinterp \             --enable-pythoninterp \             --enable-python3interp \             --enable-tclinterp \             --enable-rubyinterp \             --enable-cscope \             --enable-multibyte \             --enable-xim \             --enable-fontset \             --enable-gui=gnome2 make sudo apt-get install checkinstall sudo checkinstall
Using terminator and compiled using git repo of vim default branch.
I am using Bunsenlabs helium with backed by Debian Stretch.

did you really use  https://code.google.com/p/vim/?
Also, can you please show the output of ldd vim, looks like you are missing the libtinfo library.

I am using Bunsenlabs helium with backed by Debian Stretch.

Is that an operating system? You might try something like apt-get build-dep vim-gtk3 (or similar) and see if this fixes things for you

did you really use https://code.google.com/p/vim/?

No.
ldd vim -
 krishna@krishna:$ ldd vim
ldd: ./vim: No such file or directory
krishna@krishna:$ vim
vim: error while loading shared libraries: libtinfow.so.6: cannot open shared object file: No such file or directory krishna@krishna:$

Is that an operating system?

Yes it is. Bunsenlab helium is debian stretch os.

You might try something like apt-get build-dep vim-gtk3 (or similar) and see if this fixes things for you

Reading package lists... Done
E: You must put some 'source' URIs in your sources.list

sudo apt-get remove vim vim-runtime gvim vim-tiny vim-common vim-gui-common

Removing system vim is not recommended. It might remove important libraries. libtinfow.so.6 might be removed by it.
If you want to install your own vim, you should install it to /usr/local/bin (which is the default). System vim is installed in /usr/bin, so they won't conflict.
Try installing system vim again:
sudo apt-get install vim

sudo apt-get remove vim vim-runtime gvim vim-tiny vim-common vim-gui-common

Removing system vim is not recommended. It might remove important libraries. libtinfow.so.6 might be removed by it.
If you want to install your own vim, you should install it to /usr/local/bin (which is the default). System vim is installed in /usr/bin, so they won't conflict.

Indeed. Not only they won't conflict, but since /usr/local/bin comes earlier in the $PATH than /usr/bin, invoking vim or gvim with no path will load your own Vim (once you have one). You can of course still load the OS's Vim by invoking it with a full path, i.e. as /usr/bin/vim or /usr/bin/gvim.

Try installing system vim again:
sudo apt-get install vim

Best regards,
Tony.

This looks like a system configuration issue and not a real Vim bug.
Please ask user questions on the vim_use mailinglist or use vi.stackexchange.com. This here is a bug tracker for problems with Vim. We cannot provide individual help here. Closing.


Be able to deploy the custom branch to the staging by the label

As a developer, I want to be able to test my branch on staging by adding the label to the PR in GitHub.
Given:

Branch in neon repository
Opened PR from this branch

When:

I add the label to the PR

Then:

The branch is deploying to the staging

I think at the very beginning it should be OK to deploy only when the label was set and update it manually by resetting this label on PR.

I'm just wondering how practical it is to deploy to shared environment. It allows for single developer testing at a time and our deployments do take rather long. Definitely at least it has to be separate from staging, because otherwise it would indeed either block the pipeline or destroy ongoing testing.

I'm just wondering how practical it is to deploy to shared environment. It allows for single developer testing at a time and our deployments do take rather long. Definitely at least it has to be separate from staging, because otherwise it would indeed either block the pipeline or destroy ongoing testing.

As Lassi highlighted this would probably mean we setup a namespaced deployment using instance storage on k8s, as I don't see how the current setup can support multiple simultaneous test branches

is this Epic scale? :)

I'm just wondering how practical it is to deploy to shared environment. It allows for single developer testing at a time and our deployments do take rather long. Definitely at least it has to be separate from staging, because otherwise it would indeed either block the pipeline or destroy ongoing testing.

I don't see how the current setup can support multiple simultaneous test branches

That kind of perf testing of in-progress patches is not often needed, I'm pretty sure we can get pretty far with just asking to deploy own branch in that region


Strange performance hit with 480p videos

The Nvidia 1050 Ti video card
I got 60 fps while playing 720 and 1080 videos, only with 480 videos
the fps drop to around 42 at all time
Change MPV player scale algorithm to nearest to see if this is the MPV issue but not helped.

Which version of the shader are you using? If it is the v2.1aL version, it is normal. 1050Ti might not be strong enough to run the x4 upscaler.
But anime are usually 30 or 24fps, it shouldn't be a problem?

@bloc97 The fact is 24fps converted to 60fps(60 Hz monitor) and then result in 42/60fps,
this cause some frames are dropped
24/60=0.4
42*0.4=16.8
24-16.8=7.2

I'm use the v2.1aL, what do I supposed to do?
Grab a h.264 tool to convert 480p videos to 720?
If apply 720p algorithm to 480p information videos, is this bad?
Or just use v2.1a but not L?

I have a GTX 1060, so is not so many stronger than a 1050Ti,  and I also use the v2.1aL.
480p anime works like a charm, gpu usage is only 1.2%.
But are you talking about 60 fps anime with motion interpolation like SVP ? That is an overkill for the gpu.

I've tested 420p video with two passes of v2.1aL with temporal interpolation, debanding and anti-ringing on 1050 (mobile) and it works just fine on 1080p@60Hz OpenGL output. The reported utilization was less than 40% even with lower clocks("optimal power" in Nvidia control panel). The video output looked really ugly, but I haven't noticed any performance hit (except when I was plugged out from power and I believe that GPU was memory bandwidth constrained due to even lower clocks).

@chrnodroid @lux-perpetua  @bloc97
I'm not using any kind of SVP-like smooth plugin, but that reminds me!
I then just checked my mpv.conf, and noticed something like:
# Interpolation
video-sync=display-resample
tscale=oversample

Well I didn't realize that would be a heavy performance option...
I was thought it is "non-integer frame interval conversion",
when I use other media player this feature is almost zero-performance hit.
After comment the two lines out, everything is fine and I got 0 frames drop!
Thank you!

@mhtvsSFrpHdE
Ah, the interpolation option! It's very heavy yes, maybe
tscale=mitchell
is less heavy than oversample.
I always prefer to not using the interpolation because on my 60hz screen don't work well.
Anyway, try to use the latest Anime4K shader v3.0 with the "UL" variant. I get 2 fps with my GTX 1060 hahaha, I think it require a 2080.  The default option suggested by the author works like a charm instead. 3.0 it's better than v2.1aL.

I get 2 fps with my GTX 1060
Is it for 1080p or 480p videos? The UL version is overkill for 1080p videos since they almost contain no small detail.
Also, it must be due to cache issues or something like that, since the UL version should be only (in theory) 5x slower than the L version. (5x more multiply-add operations)

I will do some tests on lower end GPUs and get back to you. I think that a 1060 should be powerful enough to run one pass of the UL upscaler variant without problems.

Is it for 1080p or 480p videos? The UL version is overkill for 1080p videos since they almost contain no small detail.

Is it for 480p videos,  2fps on my 1060.
While the L variant is 23fps, it's good. This is strange.
I'm using only these two lines:
This for 480p videos  (2 fps), here there is something wrong.
CTRL+1 change-list glsl-shaders set "~~/shaders/Anime4K_3.0_Upscale_CNN_UL_x2_Denoise.glsl;~~/shaders/Anime4K_3.0_Auto_Downscale_Pre_x4.glsl;~~/shaders/Anime4K_3.0_Deblur_DoG.glsl;~~/shaders/Anime4K_3.0_DarkLines_HQ.glsl;~~/shaders/Anime4K_3.0_ThinLines_HQ.glsl;~~/shaders/Anime4K_3.0_Upscale_CNN_UL_x2_Deblur.glsl"
And this for 1080p videos (23fps)
CTRL+2 change-list glsl-shaders set "~~/shaders/Anime4K_3.0_Denoise_Bilateral_Mode.glsl;~~/shaders/Anime4K_3.0_Deblur_DoG.glsl;~~/shaders/Anime4K_3.0_DarkLines_HQ.glsl;~~/shaders/Anime4K_3.0_ThinLines_HQ.glsl;~~/shaders/Anime4K_3.0_Upscale_CNN_UL_x2_Deblur.glsl"

@chrnodroid @lux-perpetua @bloc97
I'm not using any kind of SVP-like smooth plugin, but that reminds me!
I then just checked my mpv.conf, and noticed something like:
# Interpolation
video-sync=display-resample
tscale=oversample

Well I didn't realize that would be a heavy performance option...
I was thought it is "non-integer frame interval conversion",
when I use other media player this feature is almost zero-performance hit.
After comment the two lines out, everything is fine and I got 0 frames drop!
Thank you!

The correct tool that I actually need is not interpolation, is "video-sync".
Just remove all interpolation related entry and set video-sync=display-resample.
This is the equipment to zero-cost frame interval conversion in MPV.

@chrnodroid Thanks! But I need is just simple video-sync=display-resample,
that's enough for me. I'm not looking for smooth video, just frame interval conversion.


Refactor with dduitem constructor

I have merged another PR.
Please rebase it.

It is still WIP?

Yes, I plan to send several separate pull requests after this.

Merged.


Add initial support for OpenBSD 6.0

I was able to compile mdata-client for OpenBSD with these modifications. I still have some warnings due to the use of 'unsecure' versions of sprintf etc.
By the way, I saw the PR for NetBSD and I agree it is a better idea to do a plat/bsd.c with ifdef OS as the only thing which is changing is the serial port device.
I did test that cua01 is the COM2 for OpenBSD (mdata-* is working on a fresh KVM OpenBSD 6.0 install on Triton)

@mguegan thanks for putting this together. We're about to land the plat/bsd.c change at which point I'd like to go ahead and add the ifdef for OpenBSD. If we get that put together today, would you be able to test and confirm that that worked on OpenBSD?

@mguegan I've gone ahead and cleaned this up and put together a CR at https://cr.joyent.us/#/c/1136/. We've recently transitioned the review system at Joyent, hence the alternate site. Feel free to comment there or leave all your feedback here. I can also provide a git patch for this. If you could test it, please let me know. I was going to keep you as the author on this unless you said otherwise. Thanks again.
@chorrell and @travispaul if you two don't mind sanity-checking this on FreeBSD/NetBSD, I'd appreciate it. I'll take care of the SmartOS client side.

I did a test build (gmake) on FreeBSD 10.3 and tested mdata-delete, mdata-get, mdata-list and mdata-put. Looks good to me as far as FreeBSD goes.

more specifically, a test build of the recent change in https://cr.joyent.us/#/c/1136/ (https://github.com/joyent/mdata-client/commit/4edaed6d6b46e3d55a51d8cd0291c4276d8a9634)

@rmustacc : thanks ! I will test your patch on Monday and will keep you in touch then.

Built and tested https://cr.joyent.us/#/c/1136/ on NetBSD and all mdata-* commands worked as expected.

@rmustacc : same for me with OpenBSD 6.0 on Triton : everything is working as expected. 👍
Please note that I've created an Issue on https://github.com/joyent/freebsd-kvm-image-builder/issues/1 for OpenBSD Image creation.

Thanks all, we've landed this in  dbb3fde.


New version: Tauri.create-tauri-app version 4.4.0

Created by 🥟 Dumplings in workflow run #8138.

Log
Updated: 4.3.1 → 4.4.0
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\Tauri.create-tauri-app__DefaultSource\create-tauri-app.exe returned exit code: 1
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\create-tauri-app.exe returned exit code: 1
Installation failed with exit code -1978335187
2024-09-17 01:17:35.929 [FAIL] Installer failed security check. Url: https://github.com/tauri-apps/create-tauri-app/releases/download/create-tauri-app-v4.4.0/create-tauri-app-i686-pc-windows-msvc.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 895.)

@wingetbot run


Update enum capitalization in guide

Pull request checklist

[ ] All tests pass.
[ ] Demo project builds and runs.
[x] I have resolved merge conflicts.
[x] I have followed the coding style and contributing guidelines.

What's in this pull request?
Was reading getting started and the enum capitalization bother me 😆 probably not worth the time it took to make a PR, but here it is

Codecov Report

Merging #28 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #28   +/-   ##
========================================
  Coverage    61.83%   61.83%
========================================
  Files            3        3
  Lines          131      131
========================================
  Hits            81       81
  Misses          50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c1996...3362b99. Read the comment docs.

Thanks @kylebshr !


Support color(rgb(36, 72, 99), a(90%))

If I'm using https://github.com/postcss/postcss-simple-vars, and my code looks like:
$myColor: rgb(36, 72, 99);

.foo {
  color: color($myColor, a(90%));
}

And I run my postcss-simple-vars processor before this one, shouldn't it transform into:
.foo {
  color: color(rgb(36, 72, 99), a(90%));
}

Any reason why it wouldn't work from here?

OK I figured it out. I'm not supposed to use a comma between the color and a(90%)


Scrum 35 object detection

Updated application and API. Mapping coordinates of objects from camera to board 2D

And also added code for Siamese Networks. TODO: put this to endpoint in appropriate way


Optimize fee level

[ ] Use the new recommended fee and time confirmed estimate from Mempool

[ ] Update bitcoin balance.

Version test : http://<IP_ADDRESS>:8900/s/zi7EQE6d7sBNBPi
Validation passed

Optimize amount for fee rate level. Use the new recommended fee and time-confirmed estimate from Mempool:
Mainnet

Testnet


build: split build & test into parallel runs across supported platforms

Closes #20855
Closes #20638
Still WIP
This rewrites the initial build & test steps of our CI pipeline to use Circle's built-in support for ARM64, Mac, and Windows executors. This enables us to:

Parallelize builds across all of our target platforms (instead of running them sequentially as cross-builds)
Run unit tests on each platform

In addition to checking that we can actually build on each platform, parallelizing has some benefits:

Cuts the total build time to roughly a 3rd of the current build time on master (~30m down to ~10m)
More fine-grained retry behavior (i.e. if Windows build fails for a spurious reason, we can retry it without rebuilding Linux)

The main downside is that goreleaser is pretty locked into the local-cross-build model, so we have to stop using it and reinvent some wheels.
Still TODO:

[ ] Restore grace-test job
[ ] Restore litmus-test job
[ ] Restore e2e-test job
[ ] Restore fluxtest job (as a matrix?)
[ ] Add job for building & pushing quay.io images
[ ] Add job for uploading artifacts to dl.influxdata.com on releases
[ ] Decide what subset of the build/test matrix we want to run on: push, nightly, release
[ ] Add nightly & release workflow definitions
[ ] Update branch protection rules to match new job names expected on PRs

I'd prefer that we continue to do the release builds (and ideally the test builds) with the docker cross build container. This shouldn't take too long if we also take advantage of build caching.
We could save the go test binaries in the workspace and run them on each executor type. See e.g. https://github.com/golang/go/issues/15513#issuecomment-773994959 . That way we have a fairly minimal dependency on special mac/arm/windows enviroments

I don't have much love for goreleaser, 1.x is not using it and the build/test is pretty clean.

Superseded by #22539


Implement tilt by arbitrary angles

sharp has had no functionality to tilt an image by any arbitrary angle yet.
This PR utilizes libvips's similarity to do an affine transformation on the image and result in an image rotated by some angle.

[x] Code is linted
[x] Code confirms to style guide
[x] Contribution guide is followed
[x] Code is accompanied by supporting documentation
[x] Added tests
[x] Single squashed commit

@lovell I had a minor typo in the commits. Should I redo the PR?

There does seem to an issue with the tests as well. I might need to redo this. @lovell Help needed!

Thanks Sukant, this looks like a very useful addition, I'll make time to review it properly in the next couple of days.
Couple of initial thoughts: Do the tests pass locally for you? Could this functionality be exposed via the existing rotate operation?

Yes, the tests do pass locally for me.It is possible to expose it via rotate itself. I did not want to change the existing API, because the libvips functions for rotate and tilt are different. rotate uses rot and rot45, while tilt uses similarity.It is easy to accomplish both of these with sharp().rotate() itself.  I was unable to decide if we should overload rotate. Should we?
On Tuesday, 8 August 2017 2:56 PM, Lovell Fuller<EMAIL_ADDRESS>wrote:

Thanks Sukant, this looks like a very useful addition, I'll make time to review it properly in the next couple of days.Couple of initial thoughts: Do the tests pass locally for you? Could this functionality be exposed via the existing rotate operation?—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Clarification: sharp().rotate() uses rot.
On a second thought, I think it would be better if we don't expose just a single effect that vips similarity can accomplish. It is possible to apply different sorts of affine transforms using similarity, like skew, shear, scale, and rotate. We should be able to expose all of them at once. Something like sharp().affine({tilt: 15, skew: 2, scale: 0.3}) can be a candidate API for this.
@lovell Let me know what you think of that.

@gargsms Sorry for the delay replying.
Yes, I prefer the affine API you propose (as vips_similarity is a thin wrapper around the rotation feature of vips_affine anyway).

@lovell Perfect. Thanks for the update. I will try to renew this PR soon.
On Wednesday, 16 August 2017 4:52 PM, Lovell Fuller<EMAIL_ADDRESS>wrote:

@gargsms Sorry for the delay replying.Yes, I prefer the affine API you propose (as vips_similarity is a thin wrapper around the rotation feature of vips_affine anyway).—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@lovell Anything about the failed tests? They happened to all pass on my local machine. The generated PNGs had 4 channels locally, but they have 6 on the test server.
I will close this and implement affine.

@gargsms Sorry, I haven't had a chance to check your work-in-progress branch out to see what might have been causing this.
One thing I did notice was that when a transparency channel is added, make sure the value matches the bit depth.
if (!HasAlpha(image)) {
  double const multiplier = sharp::Is16Bit(image.interpretation()) ? 256.0 : 1.0;
  image = image.bandjoin(255 * multiplier);
}

@lovell it looks like this never went anywhere. Are you open to introducing this either using the current tilt api or overloading rotate? I'd love to clean up this PR & get arbitrary rotation in, but I'm not confident I could implement the full affine API.

@bentona Please see #998


'yield' keyword appears twice in completion lists

https://github.com/microsoft/pyright/blob/2918da1d0281ef0d8a1336512ccc81c4232960d6/packages/pyright-internal/src/languageService/completionProvider.ts#L116
https://github.com/microsoft/pyright/blob/2918da1d0281ef0d8a1336512ccc81c4232960d6/packages/pyright-internal/src/languageService/completionProvider.ts#L142

Thanks for the report, I'll get a fix in for this.

This issue has been fixed in version 2021.4.1, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202141-14-april-2021


Fix ArrowUp to properly skip over unselectable items

Arrow up is broken in 1.8 and won't iterate past unselectable items (category headers in the custom states example).  This fixes it.

Released in 1.8.1.


feat(tslint): add validation for selector prefix

Multiple prefixes can be added by:
  "component-selector-prefix": [true, "app", "custom-prefix", "etc"]

Restarted the Appveyor, but LGTM.


Fixed val interval

Fixes #348
To use:
Trainer(val_check_interval=100)

(checks val every 100 train batches interval)

@ibeltagy to late, it is already merged... 8-/


Upgrade Elasticsearch to 7.8.0

This PR upgrades the Elasticsearch libraries to the latest available Maven version: 7.8.0

I found two direct dependencies in the ES server POM that we do not reference, please check if they are needed for anything (they seem to be related to spatial indexing):

org.locationtech.spatial4j:spatial4j:0.7
org.locationtech.jts:jts-core:1.15.0

Thanks, I'll check.

@apeteri they are optional dependencies in the elasticsearch pom.xml and we are currently not using any of the available geospatial features available in ES.
I think we can leave them out safely.


Inconsistency for image edit and not logged-in users

What

We should (probably) have the same behavior for photo editing, regarding the "is the user logged in?" pre-check.
That's not the case.

Steps to reproduce the behavior
Imagine you're not logged in ("It's easy if you try" 🎹 )

Go to a product page
Click on a top image
You land on the image page
Click on an image: you can edit it

But

Go to a product page
Click on the "edit" button
You land on the "edit product" page
There's a "edit photo" item, but if you click it you get a "for that feature you must be connected" message

Expected behavior
We should have the same behavior in both cases.

I can work on this @monsieurtanuki !

Thank you @Akashsri3bi!
Before any coding, you need to find the answers to both questions:

is it OK to have a different behavior?
if it's not OK, which is the correct behavior?

Spoiler alert: I don't know.

@monsieurtanuki I think it's okay to request for sign in both cases because we don't know who can edit or crop out , but someone from the community will do it for a more genuine reason .
2) If you are keeping edit photos option open then you have the view of taking in more community feedback but doesn't it make the whole point of user account irrelevant . I mean those who want to contribute to community or make the app better it would be best they have an account or sign up or in . That is why I think it would be hence better to go with feature request dialog.

@teolemon Your views on the topic?

It's ok to protect, I guess.
In the past, we let anonymous users upload an image if none exists

Thank you @teolemon for your answer!
@Akashsri3bi If I had to sum up and refine the issue, I would say that we should check "is user logged in?"

only when the user tries to edit an image (unselect, take new picture, from existing pictures, crop)
but as a front picture is nice when none is available, we should bypass this check for the front picture when none of the 4 main pictures is populated

Please write a method that checks those cases (logged in / first picture), and use it accordingly.
This way we'll have only that method to change if we decide to change the logic.
Today, the check is just before the "edit photos page", which is slightly incorrect: the user should have the opportunity to see the details of the 4 photos photos. As long as no editing is involved (which happens in a next page).

"but as a front picture is nice when none is available, we should bypass this check for the front picture when none of the 4 main pictures is populated" - didn't get this @monsieurtanuki

@Akashsri3bi As @teolemon said:

In the past, we let anonymous users upload an image if none exists

So if there are no image at all for a product, we can be more lenient: it's more interesting to have at least a photo for one product than to prevent an anonymous user from adding the first photo.
That's not the most important part of the issue. You can PR first on the following:

check "is user logged in?" when the user tries to edit an image (unselect, take new picture, from existing pictures, crop)

Okay Thank you @monsieurtanuki !

Fixed by #3689.


Set omnicomplete more intelligently

Hi,
I've been playing with this plugin and I've had some issues with the omnicompletion.
Problem
Conjure seems to set omnifunc to ConjureOmnifunc regardless of it is already set or even if the client doesn't support completion (it happened with lua)
Solution
I can make a PR myself but I need some time to understand a bit better how the various fennel parts work.

Ah good catch, I've pushed a change to main that should only set the omnifunc if the current client supports that part of the client API.

Works better now, thanks!


Add /locraw support

The most reliable way to tell whether we're in Skyblock or not is via /locraw. We have been advised to use it by Hypixel admins, and no one has any qualms as long as it is implemented properly.
This issue details an implementation of /locraw handling, sending, parsing, and storing.
Tasks

[ ] Implement listener for /locraw responses (and hide from user chat if we sent /locraw in the last few seconds and haven't received a response).
[ ] Parse & set variables from locraw responses (whether we're in skyblock and possibly island type).
[ ] Create trigger that runs /locraw when switching lobbies (worlds).
[ ] Add channel listener that blocks sending /locraw if another mod (or this mod) sent it recently (open for consideration on how long this window should be, I'm thinking 500ms).

Considerations for discussion

Maximum threshold (ms) for hiding a locraw response from user chat? (balance possible lag vs accidentally showing locraw)
Maximum threshold (ms) for re-sending /locraw if another mod sent it?

Maximum threshold (ms) for hiding a locraw response from user chat? (balance possible lag vs accidentally showing locraw)

Why bother with a threshold for hiding this at all? Just hide it every time the message pops up. If other mods send /locraw, they can still read their message even if we hide it from the player.

Maximum threshold (ms) for re-sending /locraw if another mod sent it?

Why would we want to resend locraw? We send + detect it on world change, why bother if another mod is doing it as well? It can't corrupt data, only up the data faster on accident.

Why bother with a threshold for hiding this at all? Just hide it every time the message pops up. If other mods send /locraw, they can still read their message even if we hide it from the player.

Not sure if this behaviour is wise - if nothing else it could be irritating to developers trying to test with locraw who aren't aware that the core mod is hiding it from them. In 1.8.9 I don't know of any mods that always block locraw, we should probably try to keep the behaviour similar.

Why would we want to resend locraw? We send + detect it on world change, why bother if another mod is doing it as well? It can't corrupt data, only update the data faster on accident.
As in, don't resend if another mod sent it recently, not that we should resend - that is exactly the point (if you read the 4th task you'll see that was what I said).

The optimal solution here is to keep with proposed #12 Skyblock detection with a few extras.
#12 Relies on Scoreboard name detection (So, receiving "SBScoreboard") to know whether or not we are in Skyblock or not.
This already gives us fast & up to date info for almost every single scenario (exceptions are for limbo/network lag)
IMO the solution is an implementation of /locraw on top of the existing infrastructure.
So, to break it down:

On world load, we first start up our 500ms (or however long) timer for waiting for other mods to send their /locraw commands, and receive any versions they get back. If we don't get any, we will send our own.

Scoreboard packet comes in, updating us that we are either in Skyblock, or a lobby, giving us an update window without relying on that 500ms (or however long) window for /locraw to come in.

If we don't ever get a scoreboard packet, then finally, our own/a mods /locraw packet activates, giving us info that we are in limbo or just extremely laggy, removing us from being "in Skyblock". After the lag is done, and we get the scoreboard packet, we then "join skyblock" again once we've confirmed its just lag, as its a built in "done with lag" detector, or if we never recieve it, we know we are in limbo with a ton of lag possibly if we never recieve back a /locraw response, or if we do, just know we are in limbo.

These 3 simple steps can easily allow us to cover all bases, without possibly breaking other mods, without sending extra unnecessary commands to Hypixel, and giving the user the best possible experience of mods with the fastest in Skyblock detection.

Why all this "waiting x millis" stuff? Why not just apply following logic:

On world join / change send the command and set some variable that indicates the mod's awaiting a locraw response.
On locraw response, consume it if that variable is true, if not, don't consume it.
This would make it so that:
If another mod also sends the command, worst case it just gets a later response than the core mod. It wouldn't prevent the other mod from getting the response as the command would've been sent twice. Unless you exceed the limit, in which case that would require some extra step.
If the player itself sends the command it would also not consume it.


Allow layer types that accept multiple arguments to accept a single argument.

The paths, stubs, and symlink layer types accept multiple arguments. However, sometimes you want to just specify one. I want to be able to say something like:
added_layers = [
    { paths = "foo/" },
    { symlinks = { link = "foo", target = "bar" } },
    { stubs = "/{dev,proc}/" },
]

We might want to also allow the aliases path, symlink, and stub. The first two seem like no-brainers. We could even have paths require a list, but path would require a single string. It gets a little less clear with stubs, because a single string can specify multiple stubs. It would feel weird to have to say stub = "/{dev,proc}/".
I imagine this would be done in the deserializer for these types, so it would work for all rust clients.

Or, just have all of the layer types just take one thing.


Webex adapter: Allow dialogs in threads

Currently, there is a bug that prevents dialogs to function properly in threads (webex adapter). This PR adds the missing parentId to the conversationID, so bottkit can recover the conversation and continue with the dialog
Example (this dialog can only happen after applying this PR, otherwise it stops at the first question):

Code for the example:
    const MY_DIALOG_ID = 'my-dialog-name-constant';
    const convo = new BotkitConversation(MY_DIALOG_ID, controller);
    convo.say('Howdy!');
    convo.ask('What is your name?', async(response, convo, bot) => {
        console.log(`user name is ${ response }`);
    }, 'name');
    convo.addAction('favorite_color');
    convo.addMessage('Awesome {{vars.name}}!', 'favorite_color');
    convo.addQuestion('Now, what is your favorite color?', async(response, convo, bot) => {
        console.log(`user favorite color is ${ response }`);
    },'color', 'favorite_color');
    convo.addAction('confirmation' ,'favorite_color');
    convo.addQuestion('Your name is {{vars.name}} and your favorite color is {{vars.color}}. Is that right?', [
        {
            pattern: 'no',
            handler: async(response, convo, bot) => {
                await convo.gotoThread('favorite_color');
            }
        },
        {
            default: true,
            handler: async(response, convo, bot) => {
            }
        }
    ], 'confirm', 'confirmation');
    controller.addDialog(convo);

    controller.hears("start a thread", 'message', async(bot, message) => {
        await bot.startConversationInThread(message.channel, message.user, message.parentId || message.id);
        await bot.beginDialog(MY_DIALOG_ID);
    });

I wish they'd review and approve this already.

hi @jmcombs and @monzonj! Sorry for the delay. I'll work on getting this rolled into a release.

This has been published!


Distribute via krew (kubectl plugin manager)

krew is a plugin manager for kubectl. Plenty of kubectl plugins have an installation method with krew (see the list). Inspektor Gadget could join that list.
$ kubectl krew install gadget

/cc @ahmetb @invidian

This is my initial writeup of the yaml necessary for Krew. As I'm currently running on OSX, I'm waiting for the first release containing OSX to evaluate this as well.
The choice for network-policy as the example is a bit arbitrary, but as it's my primary reason to look at Inspektor gadget it made sense to me. Feel free to correct me if I'm wrong.
apiVersion: krew.googlecontainertools.github.com/v1alpha2
kind: Plugin
metadata:
  name: gadget
spec:
  version: "v0.1.0-alpha.5"
  platforms:
  - uri: https://github.com/kinvolk/inspektor-gadget/releases/download/v0.1.0-alpha.5/inspektor-gadget.tar.gz
    sha256: 327abda851fcbd8cd7a4a69c0c50c5f2d93b1abed00c901eb78a083fd0d2cbfb
    bin: kubectl-doctor
    files:
    - from: "inspektor-gadget"
      to: "."
    selector:
      matchLabels:
        os: linux
        arch: amd64
  shortDescription: Collection of gadgets for Kubernetes developers
  homepage: https://github.com/kinvolk/inspektor-gadget
  description: |
    Inspektor Gadget is a collection of tools (or gadgets) for developers
    of Kubernetes applications. While it is primarily designed for
    Lokomotive, Kinvolk's open-source Kubernetes distribution, it can be
    used on other Kubernetes distributions.Inspektor Gadget is deployed
    to each node as a privileged DaemonSet.It uses in-kernel BPF helper
    programs to monitor events mainly related to syscalls from userspace
    programs in a pod. The BPF programs are run by the kernel and gather
    the log data. Inspektor Gadget's userspace utilities fetch the log
    data from ring buffers and display it.

    What BPF programs are and how Inspektor Gadget uses them is briefly
    explained here:
    https://github.com/kinvolk/inspektor-gadget/blob/master/Documentation/architecture.md

  caveats: |
    Usage:
        Inspektor Gadget is a collection of tools (or gadgets) for developers
        Install Inspektor Gadget on Kubernetes:
        $ kubectl gadget deploy | kubectl apply -f -

        One of the gadgets is the network-policy gadget
        The network-policy gadget monitors the network activity and record
        the list of new TCP connections in a file. This file can then be used
        to generate Kubernetes network policies.

          In one terminal, start the network-policy gadget recording:
          $ kubectl gadget network-policy monitor --namespaces demo \
            --output ./networktrace.log

          At some point, let's stop the recording with Ctrl-C, and generate
          the Kubernetes network policies:
          $ kubectl gadget network-policy report \
            --input ./networktrace.log > network-policy.yaml

Hi @aristosvo, thanks so much for working on it.
Unfortunately I failed to assign this issue to me some days ago and we ending up doing duplicated work. I had started to draft a manifest here and to update the release process to make it more krew friendly here.
We are planning to do a new release soon (after https://github.com/kinvolk/inspektor-gadget/pull/58 is merged), after that we'll open a PR against krew-index. Once it's done, would you mind taking a look and testing it (specially in OSX as I don't have access to this system)?
Thanks a lot.

@mauriciovasquezbernal No problem, I'm more interested in the functionality than anything else, thanks for pushing it!
I'll take a look ASAP, do you have a draft PR somewhere?

hi @aristosvo, we opened a PR for it https://github.com/kubernetes-sigs/krew-index/pull/628, we did a small check and it works on OSX too. It'll be great if you can confirm.

Solved by https://github.com/kinvolk/inspektor-gadget/pull/95.


chore(deps): update renovatebot/github-action digest to beaea3f - abandoned

This PR contains the following updates:

Package
Update
Change

renovatebot/github-action
digest
259200b -> beaea3f

[!WARNING]
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Autoclosing Skipped
This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.


Get started 1st step

hi, after the installation, I was stuck at the first step of Getting started
_Run a simulator with the BenchBot software stack by selecting an available robot, environment, and task definition:
_benchbot_run --robot carter_omni --env miniroom:1 --task semantic_slam:active:ground_truth
And I got:

Waiting until a robot controller is found @ 'http://benchbot_robot:10000' ...
	Found
Sending environment data & robot config to controller ...
	Ready
Starting the robot controller ...
	Ready

and no simulation environment afterwards. Could you please help me with that?

This can happen sometimes on your first running of benchbot. Cancel your previous command then run a clean up with benchbot_run -k and then try running again.

Pinging this issue again. If the problem has been solved let me know, if not this issue will be closed in 3 days

Closed due to inactivity.


Training the regressor guidance

It appears that the regressor is trained on the real graphs, where as in the original guided diffusion paper, the classifier is trained on the noisy images. Is this intentional? Many thanks.

We do train the regressor on the noisy data, as stated in the paper:
"Our method uses a regressor gη which is trained to predict target properties y of a clean graph G from a noisy version of G: gη(Gt) ≈ y(G)."
We are very happy of your interest in our work, but please double check the paper before opening Github issues :)

Thanks, I did. If I understand correctly, you'd have to process the training data with DiscreteDenoisingDiffusion.apply_noise() before training the regressor, which is absent in train_qm9_regressor.py. I'm just trying to understand if there is a discrepancy between the code and the paper, or am I missing where this processing is done.


Token Contract/Symbol

[ ] Rename "Token Name" => "Symbol"
[ ] Display Token Contract first
[ ] Compact Token Contract + Symbol selection box
[ ] Symbol limit to 7 characters
[ ] Symbol only allow uppercase alphabetic characters (ex: EOS)
[ ] Symbol selection box smaller
[ ] Once both fields are filled, validate using get_currency_stats

https://developers.eos.io/manuals/eos/latest/nodeos/plugins/chain_api_plugin/api-reference/index#operation/get_currency_stats

Before

After

Implemented


Doing pull and push

I did a previous initial push using rakyll's drive. I do a push on the same dir using your drive and it seems to want to do the same initial push (I can't tell because there are a lot of files and I can't scroll back ijn history).

As well, if I do a pull on a remote dir (previously using rakyll) to check that all files are synced and your drive tells me that it should be pulled using the 'M' flag where this file hasn't been changed in months locally and/or remotely. I understand the 'Last Modified' date on google drive will be when the rakyll push was pushed, but this should not be the case for an initial push as per comments on https://github.com/rakyll/drive/issues/50. This should be the same as cp -p when copying files.

I have a remote dir which exists but doing pull commands keep asking for the same files over and over. I'm not sure why as the files havent changed and I'm not accessing them in any way.

@ikwyl6 could you try this with the latest?

@ikwyl6 So here is the reason why this issue existed:
If you have a Google Doc or Sheet, they don't provide a url to download the raw data but can only be exported. However, to maintain consistency we must touch an empty file locally for a Google Doc + Sheet due to the explanation above and this file gets skipped when pushing upstream.
The implication then is that when doing a pull however, the sizes of the files do not match up and that's why there was always a change here. If you are interested in seeing the implementation it is here: https://github.com/odeke-em/drive/commit/3c2c974940202853a7199ebe91b4b3449acac5fa

How about making the Google Doc a link file? So when clicked in a linux file browser it will open up using 'xdg-open' ? Atleast it lets the user know the file still exists and they can edit it on the spot if clicked..
I will get the latest and report back.

So currently drive supports for exporting of files see: https://github.com/odeke-em/wiki_content/blob/master/drive/export_usage.png

For my 01 item above, this is still happening but instead of the whole folder about 15-20% is still being requested to be added '+' . Is there a debug flag I can show to give you more info? These are all jpgs and some avis.
When I still proceed with this 15-20% of the files that are not uploaded, I try to do a drive pull to verify all if good on the remote side but it says to remove it locally ('-' minus symbol). Going on google drive (chrome), there are no files present even though they should have been uploaded. Since I do want these files pushed to GD, I have done the push but it throws an error: http://paste2.org/UIVvHNY2
Should this comment be a separate issue? Let me know.

@odeke-em ?? Dis you need more info from me? Did you make a change that is reflective of this issue that you want me to try out? I see milestone changes only above.

@ikwyl6 the error that you got was a separate issue that you already filed. Basically it was a resource exhaustion due to too many threads being spawned. Did you pull from master and retry it?
See the issue you filled for #11 is way separate from the resource exhaustion issue and is more related to correctness and the issues carried over from rakyll's repo.


[SPARK-26129][SQL] Instrumentation for per-query planning time

What changes were proposed in this pull request?
We currently don't have good visibility into query planning time (analysis vs optimization vs physical planning). This patch adds a simple utility to track the runtime of various rules and various planning phases.
How was this patch tested?
Added unit tests and end-to-end integration tests.

Test build #99065 has started for PR 23096 at commit b6a3d02.

Test build #99067 has started for PR 23096 at commit b2a2a01.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5188/
Test PASSed.

Test build #99069 has started for PR 23096 at commit dd61273.

Test build #99069 has finished for PR 23096 at commit dd61273.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99069/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5189/
Test PASSed.

Test build #99070 has started for PR 23096 at commit dd61273.

Test build #99067 has finished for PR 23096 at commit b2a2a01.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class QueryExecution(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99067/
Test FAILed.

Test build #99070 has finished for PR 23096 at commit dd61273.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99070/
Test FAILed.

Test build #99065 has finished for PR 23096 at commit b6a3d02.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  class RuleSummary(
class QueryPlanningTracker

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99065/
Test PASSed.

Test build #99080 has started for PR 23096 at commit f36a231.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5195/
Test PASSed.

Test build #99081 has started for PR 23096 at commit 2cd069c.

Test build #99080 has finished for PR 23096 at commit f36a231.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99080/
Test FAILed.

Test build #99081 has finished for PR 23096 at commit 2cd069c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99081/
Test FAILed.

Test build #4437 has started for PR 23096 at commit 2cd069c.

Test build #4437 has finished for PR 23096 at commit 2cd069c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5224/
Test PASSed.

Test build #99118 has started for PR 23096 at commit 34f8bfe.

Test build #99118 has finished for PR 23096 at commit 34f8bfe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99118/
Test PASSed.

Merging this. Feel free to leave more comments. I'm hoping we can wire this into the UI eventually.


Running main function of a .mvir file from terminal

How can one execute the main function of a .mvir file from the terminal? For example running create_account_script.mvir with address and amount as arguments? I could not find any details  on this in the documentation.

Good question. This is a bit more complicated than it sounds because the main procedure must be executed in the context of a particular global blockchain state. We are working on a testing environment that will let you do this using a dummy global state with a few test accounts. The discourse post here has some more details.


Connect Page documentation for Metro apps to update or remove

Just found the following page on MDN:
https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Firefox_for_Metro#Set_up_Firefox_for_desktop
It documents a flow relying on the Connect page. The Connect page will be disabled in Firefox 69 and removed in Firefox 70. We could migrate the content to a flow using the new Remote Debugging, but I don't know if it's still relevant (Metro applications?).

cc @irenesmith

This definitely doesn't need to exist. I've decided to archive it.

I have archived the English page and removed the translations.


Home page and SCSS structure

using material grid layout (needs npm install) for simpler layout
split components styling into individual files
first draft of the home page

Looks good to me :-)


Add filter-awareness to vocab-by-root entity endpoint

@dmgaldi can we close this?

I pushed to QA/Feat today. If it looks good to you we can close. Otherwise, I'll do a little more testing and try to close tomorrow.


menus.index route doesn't exist

It's referenced in master.blade.php but it's not in routes.php and not listed in php artisan route:list.

Check your data_types schema. There should be a menus option in there, if you didn't remove it.

You're saying a seed file creates the menus.index?  Can you point me to which seed file does that?  I'm not seeing it.

It's a little more convoluted than that, but yes, that's the gist.
The Menu option is generated as a part of the BREAD Builder data types seed:
https://github.com/the-control-group/voyager/blob/master/publishable/database/seeds/DataTypesTableSeeder.php#L72
The routes.php file then iterates through this table and generates a resource for each one:
https://github.com/the-control-group/voyager/blob/master/src/routes.php#L17
If the record doesn't exist, then that particular route will fail, as no resource was generated during the above loop.
I'm currently in the process of starting a new branch the aims to separate the Menu Builder from Voyager itself so that it can act as its own component. Personally, I think that configuration should be kept out of the database, as we can run into issues exactly like this.

Let me know if I can help.  We are very interested in using this project and have multiple installs of Laravel.  Some in sub directories, some at root levels.
I ran the seeders, but am still having issues.  All routes that are db powered end up NotFoundHttpException in RouteCollection.php line 161:

I'm only a contributor, not the author. @tnylea has been pretty good about doing a lot of the PRs, if you want to put in your own Pull Request.

@ChrisThompsonTLDR the menus.index will map to the following route:
foreach(TCG\Voyager\Models\DataType::all() as $dataTypes):
	Route::resource($dataTypes->slug, 'VoyagerBreadController');
endforeach;

'Menu', 'Page', 'Post' are all considered a DataType. When a new data type is created from a table it then gets looped in the above functionality and will create the routes for that data type.
So, 'menu' must be in the database to be able to access that route. And that is actually how the admin menu is built by displaying the Menu from the Menu Data Type.

Let me know if that helps clear things up.
So, have you tried running the following:
php artisan db:seed --class=VoyagerDatabaseSeeder?
Do you see the menus row inside of the data_types table? Let me know 👍

Ya, I ran the seeder (which doesn't appear to abide by the voyager.routes.prefix) and modified the slug to match the url path I need.  I just get 404's, route not found.

@ChrisThompsonTLDR, do you still have an issue here?

Closing as inactive.  @ChrisThompsonTLDR, please let us know if this is still an issue and we can reopen it.


updated cleanapp (5.0.2)

Thank you for the contribution. It was merged directly as 911ea5d4d38dfc4aca4debdc301a0d7f70382681 to keep commit history cleaner. Your contribution is still credited to you.


Fix Content-Type Header

multipart/form-data and boundary must be separated by a semicolon.

Thanks @pama !


how to reset progress wheel?

By reset do you mean set the progress to 100%?  If so, you just call setProgress() on the wheel and pass in 100 as the value.  For example, to set the seconds progress wheel back to 100% you would do this:
mSecondsWheel.setProgress(100);

but i want to set initial starting point. every wheel should be set 0. i tried to set 0 but its start second process on same progress wheel...

The wheel progresses are set inside the countdown timer, calculated from
the time of "now" to the target date.  You need to modify that calculation
(or remove it) if you want the timer to stay at 0.  I guess I'm not
entirely clear on what your end goal here is.
On Fri, Jun 26, 2015 at 12:27 AM, MikhilPastagia<EMAIL_ADDRESS>wrote:

but i want to set initial starting point. every wheel should be set 0. i
tried to set 0 but its start second process on same progress wheel...
—
Reply to this email directly or view it on GitHub
https://github.com/CardinalNow/Android-CountdownTimer/issues/1#issuecomment-115497745
.


Add ipv6 support to ActiveGate deployment

Description
We filled out the DT_DNS_ENTRY_POINT envvar based on the IP of the created Service to the ActiveGate StatefulSet using the envvars that are automatically added by kubernetes. (see in docs https://kubernetes.io/docs/concepts/services-networking/service/)
However, this is problematic when we consider that:

the IPs of the Service can be IPv4 or IPv6, and the DNS entry points are actual URLs (example: https://<IP_ADDRESS>:443/communication).
the contents "auto-added" Service envs are not formatted according to RFC2732 in the case of IPv6 (makes sense).

Due to this "limitation", we can't rely on the "auto-added" envs, instead, we look at the Service we create and get the IPs from it, then add each to the DT_DNS_ENTRY_POINT directly, formatted correctly.

This way we can support even dual-stack setups.

Sidenote: Ignore the first commit, that was my easy/quick POC without magic.
How can this be tested?
This is semi-difficult, because you need a dual-stack cluster (can be created on GKE) + do changes to the code, that enforces the usage of DualStack IPFamily, because otherwise it will always use IPv4. (if you can configure your cluster to not have to do this, then you deserve all the 🌮 )
I did this, so you don't necessarily have to:

The service

The resulting entry points

Otherwise, the unittests are straight forward.
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

@0sewa0 could you please run make doc/api-ref?

@0sewa0 could you please run make doc/api-ref?

did it, no changes (the first commit would need it, but that is no longer relevant)

Codecov Report
Attention: Patch coverage is 82.05128% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 67.36%.  Consider uploading reports for the commit a370e9c to get more accurate results

Files
Patch %
Lines

...akube/activegate/internal/capability/reconciler.go
64.28%
3 Missing and 2 partials :warning:

...llers/dynakube/activegate/capability/capability.go
91.66%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
+ Coverage   67.23%   67.36%   +0.13%
==========================================
  Files         262      262
  Lines       14234    14251      +17
==========================================
+ Hits         9570     9600      +30
+ Misses       3845     3828      -17
- Partials      819      823       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Will it support video input?

Amazing work, will it support video input?

Our model has the capability to handle multi-image inputs. However, multi-image data wasn’t utilized during the training process in our current checkpoint. You might want to consider fine-tuning the model with multi-image data.

Yep, also interesting to know how it works.

@zRzRzRzRzRzRzR


Rename repository "add" to "save" and remove "remove" calls before updating

"save" is also used for updates.
Set all repository properties to read-only in command handlers.

Thank you @wazum :slightly_smiling_face:

Related to #23


Memory barrier documentation

In https://embarkstudios.github.io/rust-gpu/api/spirv_std/arch/fn.control_barrier.html , there's no explanation of the MEMORY template parameter, or even what values are valid in it. (Turns out it is a scope, just like the EXECUTION parameter).
I guess what would be most immediately helpful is basically just examples matching the common ones like HLSL's GroupMemoryBarrierWithGroupSync.

Here's what I've got so far as an implementation of GroupMemoryBarrierWithGroupSync();
    unsafe {
        control_barrier::<
            { Scope::Workgroup as u32 },
            { Scope::Workgroup as u32 },
            { Semantics::WORKGROUP_MEMORY.bits() | Semantics::ACQUIRE_RELEASE.bits() },
        >();
    }

Maybe we should have a library of wrappers for common combinations.


exceptions: allow xdg-data access to net.codelogistics.webapps

Web Apps installs websites as desktop applications, using xdg-desktop-portal's dynamic launcher portal for the same until now. However, I received multiple bug reports and complaints that the app was not working on various desktop environments and distros due to incomplete or outdated implementations of the portal and so the app now creates and removes desktop files in ~/.local/share/applications directly.

incomplete or outdated implementations of the portal

Was any bug opened to the portal folks? This really should be reported properly.
Also curious to see what kind of bug reports from users you got.

Hi, thank you for the prompt response!
This is the bug report I got for KDE, which I reported to KDE here.
This is the bug report for Ubuntu 24.04, and this is the bug report I filed against this. The last time I checked, the fix for this was making its way through their packaging system.
This seems to be related to the portal as well as I cannot reproduce it on my machine.
As you can tell it is not so much issues with the portal itself but with its various backends.
I was also told by a user I know IRL that they were unable to install a web app in Cinnamon but could do so in GNOME, but I was unable to investigate further.

The KDE issue was fixed recently, https://github.com/flatpak/xdg-desktop-portal/pull/1376#issuecomment-2182121010
I'm granting the exception, but you should try to revert to the portal when possible.

Hi, thank you so much! I'll switch back to the portal after the changes reach the major distros.


fix: updated deps

:tada: This PR is included in version 2.1.18 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Tests not passing in Windows

I've got a fresh clone of builder.  I've run an npm install.  npm run test fails since I assume that syntax is invalid on my windows machine.  So I manually created the output directory and just ran mocha from the command line.  6 tests are failing, and it's not immediately clear why.

@guybedford I've got a PR almost ready for you on those arithmetic parens (I think I can get them recursive, too...)
I just need to get these tests passing before I'd feel comfortable sending them over.

Did I hear you right on Twitter, or do we still need to tackle these compatibility bugs to get the tests to run in Windows?

No it's still an issue - I commented these tests out - it appears I need to take some special steps to get these Traceur / Babel / Typescript tests working?  Or should they work out of the box?

Ok right, well feel free to send the PR anyway, as the Travis tests won't be affected by having test support in Windows. I've renamed this issue accordingly.

Ok cool - I should have it wrapped up tomorrow.  Thanks.

I'm not sure if this is a Windows bug actually. The current build failures seem to be consistent only in Node 5, due to some random phantomJS bug. I've disabled the phantomjs tests in Node 5 for now to get the builds to pass.

fyi - I'm on Node 4.1.1.

Ah ok that kills that hypothesis then :)

Did you test it on Node 4.1.1?
Also, you ok with a .gitignore change for Jetbrains users?

I haven't got around to the windows testing yet so will come back to that when I can. Sure feel free to put what you like in gitignore!

Ok sent - thanks for being so responsive :)

Let me know if there's anything I can do to try to debug those tests for us Windows types

Fixed in https://github.com/systemjs/builder/commit/15cd868980ff8ced54c269ebb75d5656360577f1.

Hm, sorry, but those 6 tests are still failing for me.  The tests DO run with npm run test but there appears to be something wrong with Babel, TypeScript and Traceur.
As I said, I'm happy to help debug.

@arackaf odd it's definitely passing for me here. Which version of Node are you running?

Node 4.1.1.  I'll try to find some time to properly debug these tests and find the place where things are failing.

I was testing on the exact same version, and it was a fresh clone, so do let me know what you find.

Further info: npm 3.5.  Windows 10.
I'll debug this when able and let you know where precisely the error is.


Use correct service name for "ecr" in BackendDict

I am pretty sure this should be "ecr" (the AWS name for the ECR service), not "ec2".
I presume the bug arises from a copy-paste error.
The service name appears to only be used to lookup supported regions, which is probably why this bug hasn't had any impact on users.

Codecov Report

Merging #5006 (4902417) into master (43b9874) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5006      +/-   ##
==========================================
- Coverage   95.77%   95.76%   -0.02%
==========================================
  Files         661      661
  Lines       66044    66033      -11
==========================================
- Hits        63253    63234      -19
- Misses       2791     2799       +8

Flag
Coverage Δ

servertests
36.18% <100.00%> (-0.01%)
:arrow_down:

unittests
95.69% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/ecr/models.py
96.96% <100.00%> (ø)

moto/resourcegroupstaggingapi/models.py
82.30% <0.00%> (-1.48%)
:arrow_down:

moto/awslambda/models.py
93.91% <0.00%> (-0.44%)
:arrow_down:

moto/route53/responses.py
96.69% <0.00%> (-0.42%)
:arrow_down:

moto/sns/models.py
96.83% <0.00%> (-0.40%)
:arrow_down:

moto/ssm/models.py
94.42% <0.00%> (-0.11%)
:arrow_down:

moto/core/models.py
96.92% <0.00%> (-0.02%)
:arrow_down:

moto/sqs/models.py
96.92% <0.00%> (-0.01%)
:arrow_down:

moto/config/models.py
99.34% <0.00%> (-0.01%)
:arrow_down:

moto/ses/feedback.py
100.00% <0.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b9874...4902417. Read the comment docs.


CPU cycle count

Kindly clarify the below mentioned issues:

For RV32G variant, I want to find how many CPU cycles are required for execution of each instruction

I have searched a lot to find out that how many clock is needed for operation of each instruction in ISA RV32G variant, but I couldn’t find any thing.

The base timing information is required for RV32G variant for determining the CPU cycle time. Can anyone Kindly suggest the information in this regard

Thanks in advance

I don't think there is RV32G implementation... The only one is RV64G OOO.


php-7.0 runtime try to use composer 1.6.4, but only works with php-7.1

Error when I try use nanobox run
PHP 7.0
Boxfile
    runtime: php-7.0

nanobox run ERROR :cry:
    - composer install :

      Fatal error: Uncaught TypeError: Return value of PackageVersions\Installer::activate() must be an instance of PackageVersions\void, none returned in /app/vendor/ocramius/package-versions/src/PackageVersions/Installer.php:62
      Stack trace:
      #0 phar:///data/bin/composer/src/Composer/Plugin/PluginManager.php(236): PackageVersions\Installer->activate(Object(Composer\Composer), Object(Composer\IO\ConsoleIO))
      #1 phar:///data/bin/composer/src/Composer/Plugin/PluginManager.php(205): Composer\Plugin\PluginManager->addPlugin(Object(PackageVersions\Installer))
      #2 phar:///data/bin/composer/src/Composer/Plugin/PluginManager.php(261): Composer\Plugin\PluginManager->registerPackage(Object(Composer\Package\CompletePackage))
      #3 phar:///data/bin/composer/src/Composer/Plugin/PluginManager.php(76): Composer\Plugin\PluginManager->loadRepository(Object(Composer\Repository\InstalledFilesystemRepository))
      #4 phar:///data/bin/composer/src/Composer/Factory.php(384): Composer\Plugin\PluginManager->loadInstalledPlugins()
      #5 phar:///data/bin/composer/sr in /app/vendor/ocramius/package-versions/src/PackageVersions/Installer.php on line 62

PHP 7.1
Boxfile
    runtime: php-7.1

nanobox run OK :smile:
More information

Also, I try with composer require and require-dev empty
Maybe its related with https://github.com/Ocramius/PackageVersions/issues/18, but php-7.1 runtime requieres an update on nanobox images server, I think.

Temporary solved with
run.config:
  engine: nanobox-io/nanobox-engine-php
  engine.config:
    runtime: php-7.0

It's a bug related cache_dir. This is how can I reproduce the error.
pablorsk $ cat boxfile.yml | grep runtime
    runtime: php-7.1
pablorsk $ nanobox run
/app $ composer install # all its ok
/app $ exit
pablorsk $ git checkout some_branch_with_php70
pablorsk $ cat boxfile.yml | grep runtime
    runtime: php-7.1
pablorsk $ nanobox run
# CRASH !!!

Only solution is nanobox destroy (or, more complex,  do inside machine rm -rf vendor/*)
This problem can be solved, maybe, with #84. And prevent another issues like #100.


what version of discord.js is this?

Also, you dont mention anywhere in the readme that you need to npm install ytdl and yt-search and all the other things

V12 Discord.js and also it's common sense to download the npms unless you just wanna fork without any knowledge or experience of a Discord bot.

@Ravenwulf running npm install installs every packages needed for the bot since package.json contains all the needed information. It'll also install the correct version of said package. Simply rum npm install as stated in the README file.


I installed python mode, but I can't get any code run, I don't get any error, and i don't get any result either. the java mode works.

Can you provide some more information?
What operating system are you using, do you have Python installed already? Which versions?
Any screenshots you could provide may also help.

@emanouda --
Are you using some networked account? This is know to cause issues: https://discourse.processing.org/t/processing-3-5-4-not-working-with-python-mode/25650


Use same TLS defaults for docker API as for docker CLI

When you just set :tls, true than docker invocations via CLI will use the default certificates from ~/.docker, but invocation via API using Excon will fail because no defaults are provided.

Good catch, thanks! Appreciate the clear PRs with good tests. Hi Five!


add feature support VITS2 training like dataset format

We are coming from Bert-VITS2, its a very good project, and we already have many dataset which using vits like format:
aaa.wav|Jake|ZH|我来了

is there a way to suppor this format as well?

@Stardust-minus Maybe we can introduce a data converter to convert Bert-VITS2 format into protos?

We are coming from Bert-VITS2, its a very good project, and we already have many dataset which using vits like format:
aaa.wav|Jake|ZH|我来了

is there a way to suppor this format as well?

#18

@Stardust-minus @leng-yue  thank u so much.
As a rookie, wanna consult 2 questions:

Does the vits data can be directly used to train the vqgan? does there any other operation need to do;
I finetune on my custom data, the llama part shouldn't change right? It at least can support Chinese and English out of box?

For 1, yes.
For 2, I am not sure that you mean. You can finetune llama for better quality, and if you use g2p mode (enabled by default), yes, it supports Chinese and English out of box.

VITS format docs updated.

@leng-yue training llama and vqgan, the data is same right?

audio + text

I think for llama, the gt should be codebook + text?

Yes, basically semantic tokens + text.

how's the pretrained model trained? Is it using Genius Dataset? 元神

The data used for current model are shown here.

@leng-yue  Is there any convenient way to finetune on my existed Bertvits2 data?
Just like train_ms.py and then webui to verify the result


Leadership Section(2h)

Notes:

Hello @luigicr18 @mjbarnes88
Please take a look at these notes

Thanks

Hello
This is now looking good
Thanks

font family used in bio doesn't exist "robotoLight"
instead use
.styleGuideP {
font-family: roboto;
font-weight: 300;
}

Spacing will be fixed per #66 but font is now correct.


ATProto => AP: hashtags

Here, #atproto is not a link:

Thanks! True. Original: https://bsky.app/profile/mackuba.eu/post/3krr7pybrf22w
I got them working AP => Bluesky in testing, https://github.com/snarfed/bridgy-fed/issues/980 , but evidently not Bluesky => AP.

Fixed! Example: https://bsky.app/profile/snarfed.bsky.social => https://indieweb.social/<EMAIL_ADDRESS>(requires login)


Improve property Transform section

On a property the Tranform section is pretty plain and uninteresting.

Make it more appealing and inspirint to users by making these changes.

Heading changed to "Transform a Property"
Add a card with these new elements

image, content, arrow icon, heading, and description

Clicking on this card takes users to the Transform page

@thansidwell can I be assigned this ticket if no one else is working on it?

closed by #543


Windows Aarch64 builds fail due to missing libcpmt.lib

Description
In the OpenJDK project our Windows Aarch64 builds have been failing due to:
LINK : fatal error LNK1104: cannot open file 'libcpmt.lib'
A google search suggests this is may be due to a misconfigured Visual Studio environment.
Area for Triage:
Java ?
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016 R2
[x] Windows Server 2019

Image version
Version: 20210531.1
Expected behavior
No LINK error
Actual behavior
LINK : fatal error LNK1104: cannot open file 'libcpmt.lib'
Repro steps
https://github.com/dholmes-ora/jdk/runs/2769789699?check_suite_focus=true

Hi @dholmes-ora!
Is it possible to create any minimal repro as the current workflow looks pretty complicated and it can take significant time for us to analyze all the steps in the search of the root cause?

@dhadka can you please double check libcpmt.lib picked up by linker is the same (64/32bit architecture) as the build target?

@dholmes-ora ☝ (I believe that mention was meant for you 😄)

Sorry my github notifications are disabled to avoid getting duplicated notices from our workflows.
I can't help with any minimal repro I'm afraid, I am simply an end-user.

This is a cross-compilation situation:
checking for cl... $FIXPATH /cygdrive/c/progra~2/micros~1/2019/enterp~1/vc/tools/msvc/1428~1.293/bin/hostx64/arm64/cl.exe
checking resolved symbolic links for CXX... no symlink
configure: Using microsoft C++ compiler version 19.28.29337 [Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29337 for ARM64]
So possibly it is finding the wrong architecture library.

Correction. The tool being built (adlc.exe) runs on the build host, so in this case it should be an x86_64 binary. So perhaps the problem is that the wrong link.exe is being used ...

@dholmes-ora
I double checked the instructions for building OpenJDK on the windows and it says they supports only cygwin build.
According to that i removed the VC related lines from the workflow https://github.com/dsame/jdk/commit/f13d168e147fe6e8b847dd497be18a1981e7658d
and i got the success build https://github.com/dsame/jdk/runs/2844995406?check_suite_focus=true
Can you please follow my steps and make sure the artefact can be used your environment?
Also i want to note you do not have any of the actions tasks and there's no specific github related problems during the build. The more productive way to cross build aarch64 binary on windows host is to contact OpenJDK support team.

@dsame Appreciate the assistance here. I'm now treating this as a bug at our end. We have removed the problematic windows-aarch64 build from our project workflow until the folks in charge of that port determine exactly what the problem is. It was working in the past and no longer does, so something changed, but it is up to others to determine exactly what. Thanks again for the help - much appreciated. I will add your findings to our bug report. I guess I can just close this issue now.

@dsame I don't have  a specific link - not sure how to find one. The support for building Windows-Aarch64 was added to our repo back on Dec 9, 2020 and AFAIK was working until a some weeks ago (unsure when exactly it started).

Just for the record; cl.exe and cygwin work fine together. The special care needed to make this work is handled by the JDK build system. Building on Windows/aarch64 used to work fine in the past.
@dsame The relevant change you did was dropping --with-msvc-toolset-version from the configure line. Without that, configure tries to use the default installed version of Visual Studio, which was 14.29. And this works fine.
I'm pretty certain 14.28 used to work for us, and I have a hard time imagining any changes done in our code base that could have caused this breakage, so I assume something has changed in the environment of the VMs. Perhaps an additional msvc package that we indirectly need was installed by default before, but not anymore..? If so, the fault is arguably ours, since we try to make sure that all parts that we need are installed explicitly, instead of relying on defaults.


Swift 3?

Is there a way to use it with swift 3?

What problem do you have? I am using it on swift 3 without any problems
Just let XCode to convert it for you

+1
and i don't let xcode convert frameworks...

This guy ported it: https://github.com/davidseek/ESTMusicIndicator
You can update your Podfile to use his fork.

Lol ,I agree

pod 'ESTMusicIndicator', :git => 'https://github.com/davidseek/ESTMusicIndicator.git'
well. he might just have too much stuff to do... he has 10k stars in other projects...
hope my fork helps you guys

I have way more and keep my stuff up to date. Publishing implies commitment.

@Glaubenio @yarodevuci @mxcl @yarodevuci Sorry guys, too much trivia recently, @davidseek providing a solution for this, I will update this project after a few days later.

@Aufree Fell free to use my solution. Works with Swift 3

@davidseek Thank you.

This repo has been upgrade to Swfit 3.0, Enjoy~ 🎉  🎉  🎉


Allow dependencies to be compiled libraries.

Coverage decreased (-0.02%) to 83.832% when pulling 07615a12bb69f55be0baecd8f7657c0b1fdaf708 on jnphilipp:upstream into 099715a85343d4877271da3f2a642f39175c77d8 on IDSIA:master.

Hi thanks! That is a good idea. Minor improvements: endswith() takes a tuple of suffixes, so you could keep it a single if clause. Also compiled libraries seem to end with '.pyd' on windows, so maybe you could add that suffix to the list too? Thanks.

Cool, thanks!


testing pydantic v1.10.0a2

TO NOT MERGE
This is pull request is just to test pydantic v1.10, see https://github.com/pydantic/pydantic/discussions/4359

Hi, please can you kick off tests so I can check if v1.10 will break anything.

I've marked this as "ready for review" in the hope that someone kicks off tests.

Looks like tests passed on the first commit, I'll let CI finish but I think we're good here.

It would appear DeepSpeed is compatible with pydantic V1.10 👍. Thanks for your help.

No problem, thank you @samuelcolvin for your great work on pydantic!


Target documentation misrepresents support for job types on different targets

Our current documentation on targets does a very poor job of explaining the two types or jobs and targets that we support. We've had several folks come away with the impression that Q# jobs may be run on optimization targets.
This doc needs to be restructured for clarity and to give sufficient weight to Optimization vs. QC.

That's something I ran into a bit with instructions on the Azure Quantum service samples as well; would be good to align with how we discuss the two kinds of targets in those README.md files as well, perhaps?

Agreed we should absolutely align on the right definitions. I also think the existing article has a structural issue because the first sections is about quantum devices, and says " your Q# code can run seamlessly on all of the Azure Quantum targets.". I'd propose a structure like:

Targets in Azure Quantum

Optimization Solvers
Quantum Computing targets

Then we could have a link to the relevant target type in README files. would that help with what you'd like to address?

Then we could have a link to the relevant target type in README files. would that help with what you'd like to address?

I think that could be really helpful, yeah. At the moment, there's no link I can provide from the READMEs that helps explain why some of the targets listed by az quantum target list cannot be used to run Q# applications; your suggestion would really help with that, I think.

Yes, we need to restructure the article. I'll do it.

@cgranade I'd also like to see us outputting the target type in az quantum target list. Will see if we have a product backlog item for that.

I created a PR to address this issue: #59
Please, review and add your suggestions.


introduce rspec and convert over draw_spec.rb

This is a quick first pass. The marshal test wasn't running because it wasn't
properly named before. I tried for a bit to get it to pass, but that might be a
project in its own right.

There were the following issues with your Pull Request

Commit: d45922d5265d081a20bba58c5a454b19ac0c02ce
Your commit message body contains a line that is longer than 72 characters

Guidelines are available at http://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message

This message was auto-generated by https://gitcop.com

One unpleasant side effect with this is that the :test task won't run if :spec fails, so that could be a little annoying until everything is converted over.

I think this is an awesome direction to move in. +1.

Hmm, anybody have any idea why this build is failing? It looks as if older versions of ImageMagick are no longer available...

Looks like they changed their patch level. This will depend on https://github.com/gemhome/rmagick/pull/177

I actually asked the ImageMagick team to NOT do this, i.e. remove existing binaries. If the file isn't in http://www.imagemagick.org/download/releases then they have messed up again.

Yeah it looks like they removed it. Makes for things to be a little inconsistent on our end... Would it make sense for us to mirror them somewhere?

I don't think so.. but they shouldn't be doing it !@#$!@#. I explicitly asked them that when they make an official release that that file sticks around permanently.

Are they using an automated build script that just deletes them? Maybe we can patch that, too...

This has been rebased, so hopefully it will pass...

Ugh, it looks like the marshal spec passes under some versions of ImageMagick, which fails the build because a pending spec is passing... I think I'm just going to put a hard fail in there.

Alright, this is passing. Alright if I merge?

gah! ImageMagick switched up their versions again!

@vassilevsky @linduxed any idea why this is failing? It seems to be unrelated to my changes here.
https://travis-ci.org/gemhome/rmagick/jobs/57288500

It looks like the test uncovered a real mismatch.

I posted the issue #186 to address the problem. What's confusing is that I got that to pop up during my work on #185.
What's weird about this is that I can't get that error to go red anymore. Apparently, I ran bundle exec rake enough times that it doesn't want to fail anymore. The Ruby versions on Travis that go red don't go red for me; I have no idea why this is the case.
I did get the error for a while though and I'll try to look a bit more on the code to figure out what could be causing this.

Renamed spec group to ._dummy_img_.

I updated the spec to use skip instead of pending. I think that just skips it entirely.

Any idea why we're getting "Stack consistency error"?
https://travis-ci.org/gemhome/rmagick/jobs/58983037

Sometimes it's consistency error, sometimes it's something else, but this test fails very often. I think it has something to do with the way the trace proc is implemented in the C extension. Maybe it uses some old MRI C API and newer versions of MRI support it badly. Something along these lines.

@vassilevsky any idea what needs to happen in order to make it consistent? Also, can we just merge this then?

FWIW, trace_proc has a volatile variable in the C extension. (at rmimage.c:L15224)
Possibly, it might cause that confusion.

“volatile” implementations may be buggy/inconsistent in some
compilers and architectures. RB_GC_GUARD is customizable for broken
systems/compilers without those without negatively affecting other
systems.

Appendix E. RB_GC_GUARD to protect from premature GC

I rebased this onto the awesome fixes by @u338steven and now it's passing! 🎉
The failing tests are the usuals.

Thanks @mockdeep! 👊You are the trailblazer of better testing! 🚢


Is bgfx not support PT_TRILIST draw mode anymore?

I want to draw model on PT_TRILIST mode, but I can't find ant config function or macro.
 #define BGFX_STATE_PT_TRISTRIP             UINT64_C(0x0001000000000000) //!< Tristrip.
#define BGFX_STATE_PT_LINES                UINT64_C(0x0002000000000000) //!< Lines.
#define BGFX_STATE_PT_LINESTRIP            UINT64_C(0x0003000000000000) //!< Line strip.
#define BGFX_STATE_PT_POINTS               UINT64_C(0x0004000000000000) //!< Points.
#define BGFX_STATE_PT_SHIFT                48                           //!< Primitive type bit shift.
#define BGFX_STATE_PT_MASK                 UINT64_C(0x0007000000000000) //!< Primitive type bit mask.
But I found the old closed issue that discused about PT_TRILIST mode.

It's default mode, if you don't specify any BGFX_STATE_PT_* it's tri-list.

Should there be a constant to set just the state back to default?

bgfx is stateless, you set whole state every time, not bits of state.


[IDEA] Allow custom blockNumber + report blockNumber in downloading holders CSV

Problem to solve
Currently the downloadable CSV with project holders information uses the latest blockNumber by default, and does not report which block number was used.
Proposal
Allow the user to set a custom block number for downloading a CSV, and include the block number in the filename.

fixed