Fixes a bug that causes the nodes in the graphs to not always be initalized

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   88.04%   88.04%
=======================================
  Files          41       41
  Lines        4183     4183
=======================================
  Hits         3683     3683
  Misses        500      500

Impacted Files
Coverage Δ

pymars/drgep.py
91.47% <100%> (ø)
:arrow_up:

pymars/drg.py
93.86% <100%> (ø)
:arrow_up:

pymars/pfa.py
94.61% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b571ed2...b8dde7c. Read the comment docs.


Adds ASM Policy Endpoint with first set of sub collections

Fixes #844, #828
Problem:
ASM Policies Endpoint was not in SDK.
Analysis:
Adds first an ASM policy endpoint along with first set of subcollections, subsequent subcollections will be added in next PRs. One of the ASM policy subcollections was returning different json 'kind' property starting from 12.x version, the workaround was implemented to keep this behavior consistent.
Tests:
Functional
Unit
Flake8

@caphrim007 @zancas @pjbreaux

lgtm


Alvin implementation

All of these changes are included #146, I close this PR as I won't update it again to main branch.


Fix newRemoteAddr is never assigned

Using the wrong variable for not null validation before HttpServletRequestXForwardedFilter.newRemoteAddr assignment.

That way, the header X-Forwarded-For, passed from AbstractHTTPServlet.checkXForwardedHeaders() was never considered.

should be random failure

Good catch. Could you please squash your commits? I'll merge it also to 3.2.x and 3.1.x branch.


load optimization: Optimize updating right sidebar when tab is idle in large organizations

In very large organizations with a lot of presence data, Zulip sometimes gets complaints about either (1) consuming more CPU than would be ideal or (2) weird browser-related behaviors (like the Zulip tab being killed by Chrome when it tries to reload when coming back from suspend) that seem likely to have a root cause in Zulip spending CPU while the user isn't interacting with the tab (and thus getting tagged as a "problematic tab" by Chrome).
If you do profiling of an idle tab on chat.zulip.org, it becomes clear that this problem is almost entirely caused by the right sidebar presence data (it consumes about 100ms on each rerender on chat.zulip.org, and does those a few times a minute if the server is active and thus new users are coming online frequently).
I think we can substantially reduce this category of in a few ways:
(1) Simply optimizing the performance of rerendering the right sidebar presence list (even in very large organizations); I think our list_render API still doesn't support doing efficient incremental rerenders.
(2) Rebuilding the right sidebar to use a buddy list type structure in these large organizations?  I'm not sure I actually like this option for a few reasons, because there is a legitimate use cases where the current right sidebar is considerably better than a buddy list would be (so we'll probably keep it as an option).
(3) Tweaking our right sidebar presence code to defer rerenders when it has been N minutes or more since the user last focused the tab (we sorta already track that data for presence purposes), and then trigger a rerender if this has happened in the on_focus handler for the tab.  This would carry a small downside (in that users would see inaccurate data if they were looking at the right sidebar from behind another window for a long time, and would see an immediate rerender when they visited the tab later).  But it might be a reasonable tradeoff in cases where the time since last focus is very high (e.g. N > 30) and thus the downsides are unlikely to be important.

Will it be possible to make disable the right sidebar with an option to enable/disable defaults at the organization  settings level?
(As in the case of Rocket.Chat, members-list and member status tab appears only on demand.)

It's certainly possible.  @veerjainATgmail do you have a particularly large organization that's using Zulip?  This only really affects organizations that have thousands of user accounts.

@timabbott , IMO it will be useful even with less user accounts for low bandwidth areas/less powerful clients and an option to enable/disable will reduce distractions for the users in my deployment case.

The list_render option is still non-trivial, for basically the reasons you mention--it's not great at incremental updates, including both adding/deleting entire rows and dealing with unread count updates.
I'm in favor of options to basically suppress redraws when users don't care--so, some combo of knowing the user hasn't had focus for a long time, allowing user to turn off sidebar, and knowing when sidebar is not visible due to window width.
For optimizing your option #3, I could see eagerly updating green circles during non-focused time and then only redraw orange/empty circles when the user re-focuses.  But that might be too complex for the amount of perceived benefit.

A fourth option for the every-N-second updates is go to a more data-diffed approach.  This would require some of the same internals as progressive list rendering--i.e. we want the list widget to have a better notion of what data it's representing, rather than just putting it into a template and doing all subsequent things at the jQuery level.  I imagine most updates really aren't changing the data much, so if you could compute which ids are deleted/added/modified from the current list, you could simulate a few tiny updates (basically a virtual DOM kind of approach).

Thanks to #9954, we've mostly completed approach 1 above.  I'm going to leave this open for now, since we might want to do some of these other ideas; it sorta depends on practice on whether we hear more reports from users of Zulip consuming "too much CPU" when idle.

Removing the priority tag, since we've stopped seeing complaints about this.

Closing, since we've not gotten further complaints and a fix was implemented as noted above.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/145 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-source-version-target.git

Docs Build status updates of commit d0dfaa9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Enhancements in Frontend

Deliverable:

[ ] Reduce the card height for Recent Broadcast and previous broadcast section same as the card height of All broadcasts page
[ ] Add a dash line below the heading on All Broadcast page similar to Recent Broadcast page
[ ] Reduce the Card height for Get Involved Page

I would like to work on this

I would like to work on this

sure @LeeRenJie Please go ahead
Happy Learning :)

I tried reducing the height of the card but the words were still there. How do I tackle this issue? I tried to tap into the height of the card-item.

I tried reducing the height of the card but the words were still there. How do I tackle this issue? I tried to tap into the height of the card-item.

I found a way to solve this but maybe it is better if there is a way to limit the words in the card shown


There is a bug in the "multipleOr" and "multipleAnd" search for practitioners in the PractitionerRole.

This issue is related to tests where a search by patient does not exist. In the current implementation, the test attempts to retrieve data using patient_id from storage, which does not exist in this case.
Solution: I can enhance the function to retrieve data without patient_id by using the current resourceType when patient_id does not exist.

I faced this new issue on the build step.
https://github.com/hl7au/au-fhir-core-inferno/actions/runs/12370531586/job/34524690160#step:3:1071
This issue is new and looks like many people are faced with this too.
https://github.com/rubygems/rubygems/issues/8336
Will try to fix this.


[macOS] Recreate nuget.config with a proper feed

Description
It turned out that any PowerShell module installation causes nuget.config file creation without any feeds in the $HOME/.config/Nuget directory.

Our assumption is that the file was previously overwritten by one of the NuGet commands from the mono package but it is not valid anymore since mono <IP_ADDRESS>, which causes the issue for customers who don't have nuget.config file in their project.
This PR is a temporary workaround that basically does the same trick as before — deleting a broken file and recreating a new one with the correct feed.
Related issue:
https://github.com/actions/virtual-environments/issues/5768
Check list

[x] Related issue / work item is attached
[x] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos1015, macos11, macos12


Upgrade to version 2

Let's upgrade to version 2 👍
See https://github.com/FormidableLabs/webpack-dashboard/releases

Done in v1.0.0! :)


Add more error messages to stablize integration tests

Problem

I saw the Cannot commit transaction in miner error message in our stress tests occasionally. This requires us to re-run the tests and waste our time.

How to solve

Add Cannot commit transaction in miner error to resubmit the transaction

Does this happen because the mempool is full?

No. This only happens on Fantom L2. Fantom L1 is auto mine. It has this nonce issue and the error is Cannot commit transaction in miner.

l2geth_1                     | TRACE[07-08|18:38:23.414] Skipping transaction with low nonce      sender=0xC13f5b798A65CAeDA5f3d88a94392173e191B53a nonce=6

l2geth_1                     | ERROR[07-08|18:38:23.414] Problem committing transaction           msg="Cannot commit transaction in miner"

l2geth_1                     | ERROR[07-08|18:38:23.414] Got error waiting for transaction to be added to chain msg="Cannot commit transaction in miner"

l2geth_1                     | WARN [07-08|18:38:23.414] Served eth_sendRawTransaction            conn=<IP_ADDRESS>:44380 reqid=7532 t=6.446652ms   err="Cannot commit transaction in miner"

Thank you


fix(docs): correct a typo inside docs/guide/build.md

Description

In this pull request, I am just correcting a little typo in the following paragraph with the difference bolded:
From:

You can configure how chunks are split using build.rollupOptions.output.manualChunks (see Rollup docs). If you use a framework, refer to their documentation for configuring how chunks are splitted.

To:

You can configure how chunks are splitted using build.rollupOptions.output.manualChunks (see Rollup docs). If you use a framework, refer to their documentation for configuring how chunks are splitted.

@patak-dev, do you have time to merge it for me?

@bluwy, I need to remember that in the future 😅.


popup/sidenav: map center in upper left corner

When the container is initially hidden the maps center is in the upper left corner when the map is drawn for the first time, even when explicitly calling setCenter() and sending 'resize' event.
http://codepen.io/exchsac/pen/PbreYZ
(drag to see the marker in the upper left corner)

same issue marker in the upper left corner

map.setCenter after resize event fixed my problem

I have added FAQ section for this.


Right column set in % ignoring left column set fixed width on some breakpoint

Describe the bug
Right column set in % ignoring left column set fixed width on some breakpoint, not sure is that bug or correct behaviour, but how to fix it to let left column be static and only right column change own width in responsive mode?
https://mjml.io/try-it-live/3MGgKaxc_Mh
Expected behavior
Left column set static with word wrap only right column
MJML environment (please complete the following information):

OS: Windows 10
MJML Version: VS code extention version
MJML tool used: VS code extention

There's multiple errors in your MJML

Don't use mj-raw like this it would produce invalid HTML at the end, use mj-text if you need to use some standard HTML
Section can't have more than 100% of content inside it or it will misrender on Outlook

https://mjml.io/try-it-live/MWJInbRkBct You should use mj-image instead of raw html img tag as it won't handle overflow properly.


Allows to set off screen page limit

There are a few cases where overriding the default limit for offset screens in ViewPager can be very useful. I personally think that AppIntro should let the developer decide whether or not override this value as ViewPager does.
Thanks for this fantastic library btw.

Looks good, thank you @juankysoriano! :+1:


How can i auto click alert pop up?

i can't use auto click with alert pop up because i can't get xPath from it

browser default Alert box cant be clicked.


Incorrect interpretation of RFC 6265 in SetCookie::validate

SetCookie::validate checks if the cookie is valid according to RFC 6265
It includes the following checks:

Names must not be empty, but can be 0
Value must not be empty, but can be 0

RFC 6265
   3.  The (possibly empty) name string consists of the characters up
       to, but not including, the first %x3D ("=") character, and the
       (possibly empty) value string consists of the characters after
       the first %x3D ("=") character.

   4.  Remove any leading or trailing WSP characters from the name
       string and the value string.

   5.  If the name string is empty, ignore the set-cookie-string
       entirely.

It only says to ignore the cookie, not to do something drastic like throwing exception, when name string is empty and says nothing about empty value.

Sounds good to me. Can you send a PR?

I solved my issue by disabling strict mode.
I don't know what is the intention of strict mode in CookieJar.
Changing comment would count as a fix, right?
- * Check if the cookie is valid according to RFC 6265
+ * Check if the cookie is valid

I don't think that is the best way to fix it. The validate check should not be called when there is no name.

A related issue is caused by this condition:
        // Check if any of the invalid characters are present in the cookie name
        if (preg_match('/[\x00-\x20\x22\x28-\x29\x2c\x2f\x3a-\x40\x5b-\x5d\x7b\x7d\x7f]/', $name)) {
            return 'Cookie name must not contain invalid characters: ASCII Control characters (0-31;127), space, tab and the following characters: ()<>@,;:\"/[]?={}';
        }

I have no objections against rejecting most of these characters, but 2 of them are very important - square brackets are used to define arrays, even PHP manual gives example how to do that http://php.net/setcookie#example-4936

Addressed by #1245

Run into non standard cookie-name with ':' char, and need to override SetCookie::class but there's a bit tight coupling in CookieJarInterface


Fix for symlink attack needs to support extracting symlinks pointing outside the root

Thanks for fixing the symlink attack.  However, the fix in 85b6399b212f66eb955431f214e0e9eb408988c8, while addressing the vulnerability, also prevents extracting valid archives that contain a symlink pointing outside the root, even if nothing attempts to write "through" those symlinks.  As an example of such a valid tarball, consider extracting the filesystem tarball from a Debian package into a temporary directory.  Such a tarball could legitimately contain, for instance, a symlink like /usr/bin/vi -> /etc/alternatives/vi; that shouldn't cause extracting the archive to a temporary directory to fail.  It's even OK to have a symlink to a directory outside the root, as long as nothing gets extracted through that symlink.
The fix for busybox (in https://bugs.busybox.net/show_bug.cgi?id=8411) used the approach of writing a "placeholder" for such symlinks, and replacing all of the placeholders with symlinks at the end of the extraction; then, if anything attempts to extract "through" that placeholder, it'll fail.

Yeah that seems like a more reasonable fix to me. This'd unfortunately be a bit more difficult to implement, but not impossible! I'd be down for a PR


Adds Assertj-core

Hmm this one is not ready.
We have an assumption that JUnit is always used to test libraries and is never a 'main' dependency.  Will need to figure out how to change j2objc-gradle to support libraries like this one that extend junit.

So there's a build failure with net.sf.cglib.proxy does not exist. Put this in to the "allowed failures" for now then?

Wow its been 4.5 years :D


Custom app _app getInitialProps not running

What version of this package are you using?
2.5.0
What operating system, Node.js, and npm version?
macOS Monterrey, node v16.15.1, npm 8.11.0
What happened?
I'm using Nextjs and next-translate in an nx monorepo. I have a custom app on _app with a getInitialProps that I use for initializing different tools. With Nextjs 12.3.1 and next-translate 1.6.0, everything was working fine.
I upgraded Nextjs from 12.3.1 -> 13.4.10. At this point, I got an error because the i18n config file couldn't be found despite having the NEXT_TRANSLATE_PATH env var defined. There was a thread suggestion to change that env var value to '../../' for dev and './' for production. This worked after I upgraded next-translate to 2.5.0.
The problem I have at the moment is that the function getInitialProps in _app doesn't run.
What did you expect to happen?
I want the MyApp.getInitialProps to run.
Are you willing to submit a pull request to fix this bug?
Yes

After checking the code I realized this problem comes from next-translate-plugin and there's already an issue created there https://github.com/aralroca/next-translate-plugin/issues/8. I'll follow up there.
Thanks!

I guess is related that we replaced all regex to the typescript parser to detect the loaders.

@all-contributors please add @danielpid for code

Fixing also pageExtensions like _app.pages.js in https://github.com/aralroca/next-translate-plugin/issues/35. @all-contributors please add @TheMatrixan for code


FileReader: cache files locally

Cache downloaded files for faster acces next time

As mentioned. This needs to be cleanup up, and it needs to be really solid since it's used by all offline tools. Also needs tests.

Despite all checks working I maybe still perhaps want to run the branch on a device, just to make sure the master is not broken in some hard to find way?

These tools aren't meant to run on devices. Can you revert the changes to the submodules?

Yup as soon as I figure out how :)


Brackets for Linux

Is it possible to update so that brackets can work with linux due to libcurl3 and libcurl4. I know that i can recompile by replacing libcurl4 but i would like a minor fixed

yeah, when I installing brackets it need to remove virtualbox because different on libcurl.

When I recompile it to work with libcurl4, the program works, but the text gets fuzzy and basically becomes unusable,

When I recompile it to work with libcurl4, the program works, but the text gets fuzzy and basically becomes unusable,

I have this issue too. The fuzzy text makes even compiling it pointless because fuzzy text renders it useless. I wish Brackets developers would fix this issue with libcurl. Last Brackets update was in June, 2018.

There was an extension for linux to handle just that, no?

@benlumia007 @krizalidzero @aniketbarik Can you guys help with some more specific info of exactly what is not working?
Is the problem with the installation of the Brackets package on Linux or is the problem with building from source?
Also please specify the flavour/OS you guys are on.
Thanks for reporting this.

@shubhsnov
since most of people here are using linux of some kind of distro. The current version of Brackets is still using libcurl3 which is one of the dependency needed
In this case, some of us have virtualbox installed, and i think it started at the last vrsion 5.2.28 or early 6.0 have moved to libcurl4 as the dependency.
if brackets can replace libcurl3 with libcurl4, we as linux users should be able to install Brackets.
I hope that make sense.

@benlumia007 @krizalidzero @aniketbarik Can you guys help with some more specific info of exactly what is not working?
Is the problem with the installation of the Brackets package on Linux or is the problem with building from source?
Also please specify the flavour/OS you guys are on.
Thanks for reporting this.

Hello. Thank you for asking.
I was using Ubuntu Mate 18.10 at the time of the report.
Brackets can't be installed via the deb package unless you modify it to require libcurl4 (it normally requires version 3). And when you modify it, it runs fine, except the text looks extremely fuzzy.
I was using it at work, and I don't have access to that computer anymore to make a screenshot or similar.

is the .deb package for Brackets can't be install if virtualbox is install becuse virtualbox and some new applications uses libcurl4, brackets currently have libcurl3, if i continue to install brackets, it will then automatically uninstall VirtualBox.
the point is, Brackets needs libcurl4 as a dependency package for .deb packages.

@benlumia007 @krizalidzero @aniketbarik I've been investigating this issue, and it seems that the shell actually doesn't even need the libcurl dependency. The dependency was added here by replicating the dependencies for Google Chrome 28.
But chromium itself has moved on from that dependency as can be seen here.
I built the debian package after removing the libcurl3 dependency and was able to use Brackets and VirtualBox side by side without any issue. I didn't notice any fuzzy text as well.
We're working on bringing this change into the actual build. Meanwhile, you guys can also help us by creating a package without the libcurl dependency and see if you run into any other functional issues on installation and usage.
Thanks again for all the valuable info.

Alright, I'm trying again in Ubuntu 19.04, it does work without libcurl4 (as in it installs fine and runs fine), but the fuzzy text is still there. Might be a platform issue.

The screenshot is in Spanish, but I have used the OS in Spanish, Japanese and English with the same results.

But I'm pretty sure the problem is Ubuntu, since this also happened to me with NetBeans 10 and other editors.

@krizalidzero Thanks for verifying. Great to know that it works for you now. I think the fuzzy text is not related to the libcurl3 issue. You should create a separate issue for that.
Did you ever try installing with libcurl3, and did it solve the fuzzy text problem?

@krizalidzero The font issue seems to be totally independent and might be related to this. You can take a look at @gautam0217's solution and see if it works for you.

Hello and thanks a lot for the help.
I actually installed KDE Plasma and the problem of fuzzy text isn't happening in a KDE environment, so it's all good.
Thanks again!

This topic wasn't meant for blurry/fuzzy fonts, this topic was meant to be due to  the libcurl4 for newer version. why was this not solved before Brackets 1.14 was released.
I don't think Adobe is taking this seriously enough to fix this problem.

We did try, but there were time constraints. We really wanted to put out a release as soon as possible as well as provide some value. Upon some investigation, it turned out that Brackets which uses CEF as a shell doesn't exactly need libcurl3 let alone libcurl4. The libcurl3 dependency was removed in CEF 2840 (Chromium based) while we use 2704 so we just didn't take the risk even though it very clearly is a redundant dependency.
https://codereview.chromium.org/2271063004/diff/1/chrome/installer/linux/debian/build.sh
Be assured that we have prioritized this issue and are working to update the CEF for the LINUX at this very moment. Please bear with us.
https://github.com/adobe/brackets-shell/pull/666

@benlumia007 @krizalidzero @aniketbarik Can you guys help with some more specific info of exactly what is not working?
Is the problem with the installation of the Brackets package on Linux or is the problem with building from source?
Also please specify the flavour/OS you guys are on.
Thanks for reporting this.

Sorry, for the late reply. I'm on Ubuntu 18.04.2 with GNOME DE.
If I try installing Brackets v1.14 without compiling and changing the dependency to libcurl4, it says that it needs to remove Clamav, Clamtk, curl, libcurl4, and a couple more packages. Changing the dependency to libcurl4 fixes this.

Be assured that we have prioritized this issue and are working to update CEF for the Linux at this very moment. Post which we'll update Brackets dependencies and remove the redundant dependencies altogether. Please bear with us.

Thanks. That's good to know. Cheers.

There is a duplicate issue #14667

Here is a link (maybe temporary) to the repackaged deb that works on linux (It is possible to verify that I only touched the control file via unzipping and md5ing). 2020.10.02 version.
http://c.raph.io/index.php/s/9s86JB9RqPwgqfN

I believed that the package only removes and adds libcurl4, but make sure if u do this way, u don't do updates on it, if brackets have a new version, you're probably be stuck using the repackaging one. or else for every new release, it will need to be repackaged without that libcurl3.

Apparently libcurl is not needed anyway per shubhsnov, he wrote above, so removing the libcurl3 works for me without the need to add libcurl4 as dependency.

the problem you can remove it by yourself, but i rather have adobe brackets remove the libcurl altogether. being able o update to latest version is needed.

In case someone has libcrul4 as dependency if they uninstall brackets, will that uninstall the libcurl4 also? I tried to understand the other problems you mentioned before, I'm not a developer really, just starting out :)
Yes that's true you have to do it manually, but I found debtool (a script) that kind of makes is easy to repackage, takes like few seconds :)


fix: Use correct regex for tag name validation

This PR contains these changes:

Fix tag name validation by using the correct regex
Fix tests to reflect validation changes

@medikoo Added a bug-fix that sc-356 made apparent

@alexdelorenzo after we've merged that integration tests started to fail

@alexdelorenzo after we've merged that integration tests started to fail

I looked at the Actions logs and it looks like that could be related to: https://github.com/serverless/console/pull/405


Enums are not generating companion objects in Kotlin

Hi everyone,
When you create any type in the schema and it translates to the Kotlin code automatically it creates a companion object inside that class, that is very useful when you want for example to add some behaviour to that classes with exension functions: https://kotlinlang.org/docs/extensions.html#companion-object-extensions
The problem I am having is that enums are not generating any companion object and for example I am using the extension function to add a mapper to that class that translates the Domain object into the GraphQL object.
Here is an example code
enum RestaurantCurrency {     ARS, BRL, MXN, COP, PEN, UYU }
That will generate the following:
public enum class Currency {   USD,   BRL,   MXN,   COP,   PEN,   UYU, }
Instead of that we should have something like this:
`
public enum class Currency {
USD,
BRL,
MXN,
COP,
PEN,
UYU;
public companion object
}
`
Thank you very much.

This is fixed using the last version, thank you very much.

@zanonena @srinivasankavitha Can you please link an example on how to create a companion object, Let's say checking for nulls for enums and if null replacing the value with e.g. value OTHER in the enum? I am unable to generate a specific companion object using DGS code gen.


Should we offer unattended upgrades

Wonder if we should offer the setup of unattended upgrades for security packages.
Being this is something that will have at least one port open to the internet, we could offer to configure unattended upgraded for security packages only so that on some regular basis the pi is upgraded with new security patches.
I'd take it to a thumb up/down vote here.

thumb up here. Thanks

thumbs up as well but only security packages


shallow clone failures are inscrutable and undocumented

[x] Confirmed this is a problem with Homebrew/brew and not one or more formulae? If it's a formulae-specific problem please file this issue at https://github.com/Homebrew/homebrew-core/issues/new
[x] Ran brew update and retried your prior step?
[x] Ran brew doctor, fixed as many issues as possible and retried your prior step?
[x] Ran brew config and brew doctor and included their output with your issue?

Given my rsync problems (http://discourse.brew.sh/t/why-does-homebrew-hardcode-disable-debug-and-whats-the-right-way-to-debug/706/3) I decided to try to build from their git repo.
 This is at least a documentation bug. If Homebrew is going to do something nonstandard (shallow cloning), it ought to explain that it is doing something different and that there might be reason to question or adjust it:  http://www.rubydoc.info/github/Homebrew/brew/master/GitDownloadStrategy
But there's no mention of this there or in the inherited classes. Although there's a brief allusion to the concept of shallow cloning since SHALLOW_CLONE_WHITELIST is defined (but not explained).

2. I would argue that the code should be different as well -- that it should give the user some guidance as to what might be wrong in the error message. Is this controversial?
3. Another doc bug: The easy fix is to change the formula to:
  head do
      url "git://git.samba.org/rsync.git", :shallow => false
  end

But the :shallow option is not documented.
4. Why is git:// whitelisted? Maybe the idea of the whitelist is to avoid shallow cloning failures with GitDownloadStrategy in places where it's not known to work. Fine. But clearly git:// URLs can generate these failures. Why is it in the whitelist?

So I see 2 doc bugs and maybe 1 code bug-or-room-for-improvement. And 1 I'm-not-sure.
Do others see it differently?
Thanks.

p.s.: Before I got to these, I encountered this direction to brew unlink before brew install --HEAD. Does this make sense? The HEAD install is going to be versioned differently already, right? So why is this guidance correct?:
pb3:src jhawk$ brew install --HEAD -s --keep-source -v rsync
Unsetting PERL5LIB to protect you from yourself
Error: rsync-3.1.2_2 already installed
To install this version, first `brew unlink rsync`
pb3:src jhawk$ brew unlink rsync
Unsetting PERL5LIB to protect you from yourself
Unlinking /usr/local/Cellar/rsync/3.1.2_2... 3 symlinks removed

b3:Formula jhawk$ brew doctor
Unsetting PERL5LIB to protect you from yourself
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!

Warning: You have unlinked kegs in your Cellar
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  ghostscript
  lesstif
  numpy
  poppler
  python
  rsync

Warning: Some installed formula are missing dependencies.
You should `brew install` the missing dependencies:
  brew install adns libassuan libksba npth pinentry

Run `brew missing` for more details.
pb3:Formula jhawk$

pb3:Formula jhawk$ brew config
Unsetting PERL5LIB to protect you from yourself
HOMEBREW_VERSION: 1.1.12-27-gb0d25d83fe
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: b0d25d83fef80cb655823746450e04820bb0fb31
Last commit: 2 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: e4496c710b5300d08bd9232abf0b56e150742a3d
Core tap last commit: 6 days ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: quad-core 64-bit broadwell
Homebrew Ruby: 2.0.0-p481
Clang: 7.0 build 700
Git: 2.12.2 => /usr/local/bin/git
Perl: /usr/local/bin/perl => /usr/local/Cellar/perl/5.24.0_1/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby
Java: 1.8.0_74, 1.6.0_65-b14-468
macOS: 10.10.5-x86_64
Xcode: 7.2.1
CLT: <IP_ADDRESS>.1.1447826929
X11: 2.7.11 => /opt/X11

I would argue that the code should be different

Why not do a pull-request? :slightly_smiling_face:

Why not making a pull-request? :slightly_smiling_face:

Because I don't want to waste my effort if the maintainers disagree, and the likihood of disagreement seemed to be significant in my assessment. Also because I'm trying to deal with Time Machine breakage which has resulted in rsync breakage which has resulted in lldb lossage and Homebrew breakage and implementing fixes for the myriad of problems along the way is definitely low on my todo list. I can just manage to document them, but developer resources to repair them will have to wait.
Is it unreasonable to file issues instead of submitting pull requests? One takes a lot more effort than the other, and the effort to produce a pull request is not always available.
Incidentally, "502 Bad Gateway" on accessing this page at 12:35:40  US/Eastern (https://github.com/Homebrew/brew/issues/2487#issuecomment-293320408), cleared up seconds later.

@johnhawkinson as a stylistic aside,
head "git://git.samba.org/rsync.git", :shallow => false

is preferred.

But clearly git:// URLs can generate these failures.

I think this is actually a bug with rsync upstream's git backend, and not something we should code around or print customized messages about as if it's a common occurrence.
bash-3.2$ git clone --depth 1 git://git.samba.org/rsync.git
Cloning into 'rsync'...
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed
bash-3.2$

That's just broken.
Regarding documentation of :shallow => false, it's usually used to accommodate build systems that expect to be executing in a full clone so that they can retrieve revision/tag/branch/version/etc. information that wouldn't be available in a shallow clone. I agree that the DSL should be documented somewhere, but its description probably wouldn't cover the case you're thinking of anyway.

I think this is actually a bug with rsync upstream's git backend, and not something we should code around or print customized messages about as if it's a common occurrence.

Interesting. I was wrongly presuming that the :shallow => false in 31 formulas was because of similar issues, but I see that it's not.
But that still leaves 4.; why are all git:// urls whitelisted but only a few http/https sites:
class GitDownloadStrategy < VCSDownloadStrategy
  SHALLOW_CLONE_WHITELIST = [
    %r{git://},
    %r{https://github\.com},
    %r{http://git\.sv\.gnu\.org},
    %r{http://llvm\.org},
].freeze

it seems like something doesn't quite add up if this is only turned on because of build system expectations?

I think you're confusing the DSL with the download strategy. The fact that not all http/https servers can handle shallow clones, doesn't let rsync's git protocol server off the hook.

I don't really know anything about shallow clones and what is and is not a reasonable expectation.
The whitelist code clearly assumes that most http://,https:// servers can't handle shallow clones, and that all git:// servers can. Clearly rsync is a git:// server that can't. I'm not sure why the whitelist is appropriate for one schema and not the other. Is there a protocol issue here? Is it the case that whatever software implements one protocol is more likely to support this than the other?
I don't know, but it also doesn't seem to me that behavior should change like this.
To put it a different way, it's not rare for software to offer both a git:// and an http:// url to the same repo. It seems strange for Homebrew to clone one more shallowly than the other without any guidance about that. http://docs.brew.sh/Formula-Cookbook.html doesn't seem to suggest a reason to prefer one schema over the other (although it gives https:// as the primary example), which makes it stranger still. If git:// is preferred because a protocol issue makes shallow cloning possible, and if shallow cloning is good [I'm not so sure of this!], then that should probably be made explicit?
Or have I misunderstood this again? Thanks.

The whitelist code clearly assumes that most http://,https:// servers can't handle shallow clones, and that all git:// servers can.

I think the assumption is that all git:// servers should support shallow clones, and that some http/https servers may not. I think most http/https servers do actually support shallow clones these days, though there are still some that do not. For example, the head url in ballerburg is https://git.tuxfamily.org/baller/baller.git, which dies, as follows:
$ git clone --depth 1 https://git.tuxfamily.org/baller/baller.git
Cloning into 'baller'...
fatal: dumb http transport does not support --depth

As an enhancement to the status quo, it might be better to always attempt a shallow clone with http/https, and then fall back to a full clone on that specific error.

If git:// is preferred because a protocol issue makes shallow cloning possible, and if shallow cloning is good [I'm not so sure of this!], then that should probably be made explicit?

We prefer https:// to git://, and are probably indifferent between http:// and git://, though perhaps have a slight preference for the former since the current audit code will check if http:// can be promoted to https://, and I do not think it currently checks if git:// can be.

though perhaps have a slight preference for the former since the current audit code will check if http:// can be promoted to https://, and I do not think it currently checks if git:// can be.

Also if you run a very tight firewall git:// can be a PITA.

But that still leaves 4.; why are all git:// urls whitelisted but only a few http/https sites:
I think most http/https servers do actually support shallow clones these days, though there are still some that do not.

HTTPS Git repositories had a protocol bump in which they moved from "dumb" to "smart" (if I remember correctly). The latter supports more functionality such as shallow clones and (again, if I remember correctly) is more performant than SSH or git://.

Given this: what are the actionable changes requested here?

Given this: what are the actionable changes requested here?

Assuming none but will reopen if that changes.


Cannot import "i2c" from remote dependency, possible if local build

I got a code with this import line:
use esp_hal::i2c::{self, Error, I2C}
In the Cargo.toml file:
esp32-hal = { path = "./esp32-hal/" } (github clone in local dir) -> works fine
esp32-hal = "0.2.0" -> "could not find i2c in esp32_hal"
You can grab my full code here: https://github.com/litchipi/esp32rs/blob/oled_simple/src/oled_simple.rs
It's basically a copy-paste of the example given in the hal for now.
(PS: I tried to create my own example, but the libs used in the example of the hal are outdated and the new versions doesn't work anymore. Should I open another issue for this as well ?)

The 0.3.0 now includes the I2C module :)


Playwright results tab in Azure DevOps pipeline run

Is your feature request related to a problem? Please describe.
I'm always frustrated when my Playwright tests finish running in Azure DevOps, and I'm left with virtually no results to review. What's the point of running tests without having access to their outcomes?
Describe the solution you'd like
Now that the Playwright Testing Service is operational, I'm looking for seamless integration with Azure DevOps (ADO). Whenever a pipeline runs and includes Playwright tests, a 'Playwright Tests' tab should be accessible in the run summary alongside other tabs. Each test case should have its associated video and trace available for immediate review within ADO. Additionally, a summary indicating pass versus fail statuses may also be beneficial.
Describe alternatives you've considered
Currently, I use BrowserStack for my Azure DevOps Playwright test runs because it offers video playback for each test case, facilitating easier diagnosis of issues. Without such functionality, the process feels ineffective.
Additional context

AB#1952583

Hey man, not with Microsoft but i recently did the following to achieve the outcome you are wanting..
Adding a task to your pipeline will already allow you to do this

It might be a reasonable feature request to the azure devops guys to create a new task called publish playwright tests which would include more data like the videos and stuff your talking about. But you can already get to the second screenshot state using the publish test results task. See the below screenshot, taken from devops..

HI @chris-strudel There are few things which i want to decouple for clarity of issues.
Support for Test Results/Report in ADO
As @willbertSmillbert  mentioned, this is possible today via ADO inbuilt Publish test Results Task via JUNIT file, you can enable JUNIT reporter in config and then add ADO Task in your pipeline to publish it.
Playwright Service Reporting and Playwright Test Tab
We have feature backlog to add reporting into MPT service and we are actively working on it and hopefully you will soon hear from us. Please add your suggestion around adding ADO integration via Playwright Test tab in your reporting feature ask https://github.com/microsoft/playwright-testing-service/issues/47
Known ADO Publish test Results Task bug around video and traces
ADO currently has known issue which doesnt allow video and traces to show up in thier report

Hey man, not with Microsoft but i recently did the following to achieve the outcome you are wanting..
Adding a task to your pipeline will already allow you to do this

It might be a reasonable feature request to the azure devops guys to create a new task called publish playwright tests which would include more data like the videos and stuff your talking about. But you can already get to the second screenshot state using the publish test results task. See the below screenshot, taken from devops..

@willbertSmillbert - Yep! I currently do this, and it's a marginal reporting tool at best. I used to use the Allure reporter, but support for that stopped, and now all we have is the most minimal JUnit reporter. For Quality Engineering, those error messages often aren't enough. I think with the $20B that Microsoft is spending, it would be a good idea to up their game. If they really want the Playwright Testing Service to be a real player, then the reporting side needs a massive upgrade.

@chris-strudel good point.

porting side needs a massive upgrade

HI @chris-strudel Your feedback is super valuable for us and it will help us develop reporting solution for playwright. I will keep this issue open.

porting side needs a massive upgrade

HI @chris-strudel Your feedback is super valuable for us and it will help us develop reporting solution for playwright. I will keep this issue open.

I see so much potential in Playwright. It could finally be the testing tool that leaves everything else in the dust! However, it desperately needs the reporting piece. I just finished a POC for the Playwright Testing Service. It's great for spinning up 50 threads and running tests in a massive parallel run, but without reporting, trying to figure out where the issues are is just too painful. We'll be staying with our BrowserStack solution (and we're one of their biggest clients) until the Testing Service and ADO can tackle the reporting piece. We depend on those ADO pipeline runs.  Our QEs and Devs need to be able to quickly find the problems so that our agile teams can move fast.


ERRINFO_DECRYPT_FAILED appears randomly.

There was an error in RabbitRemoteControl . It appears randomly. What causes this.
I've found that when I use the clipboard, the chances of showing up are a bit greater.
One thread processes one connection in the RabbitRemoteControl. The clipboard operation is also in this thread. When the clipboard is operating, there is a brief blockage.
09:10:44.078 5807|6007 D FreeRDP.Log - received Heartbeat PDU -> period=1, count1=8, count2=8
09:10:44.238 5807|6007 D FreeRDP.Log - updating RDP key
09:10:45.111 5807|6007 D FreeRDP.Log - received Heartbeat PDU -> period=1, count1=8, count2=8
09:10:45.549 5807|6007 D FreeRDP.Log - recv Set Error Info Data PDU (0x2F), length: 22
09:10:45.549 5807|6007 I FreeRDP.Log - ERRINFO_DECRYPT_FAILED (0x00001192):(a) Decryption using Standard RDP Security mechanisms (section 5.3.6) failed.
(b) Session key creation using Standard RDP Security mechanisms (section 5.3.5) failed.
09:10:45.549 5807|6007 E FreeRDP.Log - rdp_set_error_info:freerdp_set_last_error_ex ERRINFO_DECRYPT_FAILED [0x00011192]
09:10:45.549 5807|6007 E FreeRDP.Log - BIO_read returned a system error 104: 连接被对方重置
09:10:45.549 5807|6007 D FreeRDP.Log - transport_check_fds: transport_read_pdu() - -1
09:10:45.549 5807|6007 D FreeRDP.Log - transport_check_fds() - -1
09:10:45.549 5807|6007 D FreeRDP.Log - rdp_check_fds() - -1

2024-03-05_0001.log

@KangLin which version of FreeRDP do you use?
as for the error, that is RDP security related (the weakest of all modes)
it has some custom key rollover after a certain amount of data was transferred and some older versions did have issues with that.
whatever the reason, I´d recommend to just switch the server to NLA or TLS modes (depending on what you need) and ditch the RDP security mode.

freerdp 2.60-2.10.0 is the issue.
Which version solved？

2.9.0 got some fixes.

Tested 2.11.5 and it still appears.

@KangLin the RDP security mode is quite complex (you have custom key rollover and (per session global) sequence counters)
can´t tell exactly.
will check your code, give me a bit of time...

@KangLin ok, there are a few issues with your project (missing files, broken so versioning and wrong installation locations)
will take a little bit longer to get that up and running :/

@KangLin ok, there are a few issues with your project (missing files, broken so versioning and wrong installation locations) will take a little bit longer to get that up and running :/

@akallabeth Is there any more details？

@KangLin the installed .so files do not follow the versioning scheme in use by unix systems (should be handled correct by CMake by default? check freerdp installed files, there should be libfoo.so in dev package, libfoo.so.1 link to libfoo.so.1.1 link to actual lib libfoo.so.1.1.1
there are wrong install locations (most likely due to windows path conventions being used?) .so installed to bin directory
I see you have a debian build recipie there working around these things, but if CMake is run plain it defaults to these wrong paths.
also, I think the whole license.md and others should be in share/doc or similar, not root?
anyhow, makes it hard to just install and run. (I do prefer building my libs step by step to find out what is going on)

Please use the master of RemoteCommon and RabbitRemoteControl.
the code of master is correct build.
the install folder is /opt/RabbitRemoteControl.
run RabbitRemoteControl.sh , it handle load .so
when debug, set CMAKE_INSTALL_prefix to 'pwd'/install

@KangLin using master of both.
there is also a missing share/RabbitCommonTests.sh file referenced in RabbitCommon

ok, had a look.
looks like you do not set up the session properly and it uses antiquated paths that are buggy.
the other stuff (library naming, ...) are minor issues, but you lack complete support of everything newer than windows XP ;)

Because the keyboard and mouse sending thread is different from the freerdp running thread and is not in sync, there is a random error.
After syncing, the issue is resolved.

@KangLin so you are in the antiquated code paths?  RDP security is something that should not be used anymore.
we´re happy about pull requests though ;)

@akallabeth This is a usage error, not a FreeRDP issue.
However, it can be clearly written in the document :)

@KangLin yes, that is only true for RDP security as there the messages must be in some order due to the way the encryption is done.
with NLA/TLS you should not have that restriction.


added SVG logos

Fixes #125
Describe the changes you have made in this pr -
I have created SVG logos and added it in app/assets/images/SVGs.

Out of curiosity, where are these icons referenced?

Out of curiosity, where are these icons referenced?

Not particular but surfed many sites and referred many logos to finally build these ones.

Approved from my side.
@satu0king, @tachyons, @Parikshit-Hooda If you guys give a go ahead then we can go forward with merging it and using it.

Green light from my end.

Out of curiosity, where are these icons referenced?

Not particular but surfed many sites and referred many logos to finally build these ones.

I'm asking where are we going to use them. :-)

@fpintos  the icons would be used as favicon.

Out of curiosity, where are these icons referenced?

Not particular but surfed many sites and referred many logos to finally build these ones.

I'm asking where are we going to use them. :-)

Ohh! I am sorry, these are the Favicons.

@fpintos Thankyou for merging the pull request :-)
@armudgal @Parikshit-Hooda @tachyons @satu0king  : It was really a very good experience working on this issues. Got to learn many new things.  :-)


ROU-10851: fix AnimatedLabel on init value

This PR is for fixing the issue that prevents the AnimatedLabel to correctly appear as active on the screen load, when there's already a default value.
This was happening as the build method was async, while the render method responsible for the active state was running first than the build.
Checklist

[x] tested locally
[ ] documented the code
[ ] clean all warnings and errors of eslint
[ ] requires changes in OutSystems (if so, provide a module with changes)
[ ] requires new sample page in OutSystems (if so, provide a module with changes)

Pipeline failure fixed will be fixed by: https://github.com/OutSystems/outsystems-ui-tests/pull/454


For commenting on 01-03-Construction-of-an-artificial-but-realistic-image.ipynb (part of review-ee0cbc6)

Will address the issues noted here later this summer...


We will build a NavamAI capability to chain multiple LLM runs combining response from prior run to prompt for next run.

https://www.navamai.com/researching-and-validating-blog-content-using-ai/

Feature complete.

Reopening as the use case have been solved for validation. However it does not chain beyond that use case for now.


Allow connections to Microsoft Dataverse using the TDS endpoint

Hi,
I'm trying to connect to Microsoft Dataverse but this always returns the following error:
Login failed: The HTTP request is unauthorized with client authentication scheme 'Anonymous'. The authentication header received from the server was 'Bearer authorization_uri=https://login.microsoftonline.com/c13f6e78-545e-4878-a61a-4887d80c3f28/oauth2/authorize, resource_id=https://XXXX.crm4.dynamics.com/'.
RequestId: TDS;d8f1f194-a7ca-404f-871c-468ddde01d89;1
Time: 2021-01-08T12:33:30.1133716Z
The issue might be that when you request a token to connect to Dataverse, you should not use https://database.windows.net/ as the resource id, but https://XXXX.crm4.dynamics.com. If you use the wrong resource ID in a custom .NET app, you get exactly the above error when you try to connect.
Note that opening these kind of connections in the SSMS just works fine.
Jurgen

Is this still an open bug? I am getting the same error when trying to use ADS to connect to a Dataverse using SQL.
Login failed: The HTTP request is unauthorized with client authentication scheme 'Anonymous'. The authentication header received from the server was 'Bearer authorization_uri=https://login.microsoftonline.com/043207df-e689-4bf6-9020-01038f11f0b1/oauth2/authorize, resource_id=https://xxx.crm.dynamics.com/'.
ADS v 1.25.3

moving out to May for investigation and consideration.

I have the same problem. When can we expect a fix?

Hello, I'm having the same issue... has anybody found a solution?
Thank you

Hi, I am facing the same issue while trying to open a connection to TDS endpoint of CDS. Does anybody know about a fix yet?

Hi, I’m the original submitter of this issue. The issue has not been resolved yet. If original description is correct, It would take any descent developer 5 minutes of work to fix it…

I'm unable to connect to Dynamics via Azure Data Factory - or SSMS v19 Release 2.
(I have no trouble with SSMS v18.)

Does not work for me in Azure Data Studio 1.38.0 as well. I am able to use SqlConnection with C# and connect to the TDS endpoint using Service Principal and secret, but ADS does not work at all.

Any update on this issue?
It’s beginning to seem like maybe they don’t want to solve so as to force use of Azure Synapse Link for Dataverse…

hello, I'm having the same problem. with Azure Data Studio.

I'm running into the same authentication issue.
Can successfully connect from the legacy SSMS but not from Azure Data Studio.
Any update on a resolution or work around?

Same issue here. Data Studio connection to Dynamics365 data source (xxxxx.crm.dynamics.com) fails with the error described by others. Using the latest insiders build made no difference as of today. SSMS 15 works fine with the connection. Opening Azure Data Studio directly from the active connection in the object explorer changes nothing. Using Active Directory with MFA. Would love to be a guinea pig if it helped solve this issue or determine a work around.

Still an issue as of today, devs.. can you please fix this?  Same error as OP and Im connecting to XXXX.crm.dynamics.com. SQL Server Management Studio (SSMS) works fine but Azure Data Studio errors.

You can now connect to Dataverse/Dynamics 365 instances using the SQL 4 CDS extension. Get it from the extensions panel, then create a new connection. Change the Connection Type option to SQL 4 CDS and fill in the rest of the details to connect. You can then run queries using the TDS Endpoint or they can be translated to FetchXML. You can also run UPDATE, INSERT and DELETE statements which will be translated to the corresponding API requests.

@MarkMpn Appreciate you letting us know there are ISV options as well.  The intent of the request here is for using an SPN w/ ADF (natively within ADF) using the TDS endpoint as opposed to translating it to fetch.
@kenvanhyning & @cheenamalhotra do you have an update as we approach March 2023? I noticed it was sized as a Large update - given SSMS can easily and natively connect to the TDS endpoint (for queryonly/readonly operations) I would hope this isn't a huge level of effort to enable within ADF - I think the request here is to enable an SPN/Identity to connect to a SQL/TDS endpoint for the purpose of running a sql query and read that data. For reference: https://learn.microsoft.com/en-us/power-apps/developer/data-platform/dataverse-sql-query
Thanks!

Hi @seanmcne
It's one of our top priorities, and our plan stays intact for March release. I'm aware of the changes (being ex-SqlClient) that we need to use SqlAuthenticationProvider implementation to integrate with SqlClient's FedAuth flow.
As of now, Azure Authentication flow in both tools (ADS and VSCode's MSSQL extension) is governed with SqlConnection's 'AccessToken' property , and the entire token lifecycle had been driven by NodeJS layer (including refreshing token) using ADAL/MSAL NodeJs packages. ADS isn't designed similar to SSMS when it comes to Azure authentication, and that's why we have this huge design gap. To be clear, this is not just a Dataverse specific issue, but is a design issue in both tools (as they share the same backend service SqlToolsService).
The changes we are making will apply to all Azure SQL connections and are planned to be released together in both tools. And as we enable SqlClient integration with MSAL.NET, there's a greater chance things will be fragile (with regards to access tokens and persistence caching) with the way features and extensions are built and depend on access tokens and auth flows from NodeJS layer. We're trying our best here, but there's significant amount of testing needed across the product to ensure tool features and extensions' stability with the authentication layer shift, as it will affect every Azure SQL connection and related features.
Due to this reason, we will introduce this support in preview in March, so customers can enable the feature on-demand, and we can get feedback on experience and make incremental improvements along the way.
Hope that clarifies :)

Since I read ADF in a few comments above, want to clarify we're home to Azure Data Studio and not Azure Data Factory.
Thanks!

Hi @seanmcne
It's one of our top priorities, and our plan stays intact for March release. I'm aware of the changes (being ex-SqlClient) that we need to use SqlAuthenticationProvider implementation to integrate with SqlClient's FedAuth flow.
As of now, Azure Authentication flow in both tools (ADS and VSCode's MSSQL extension) is governed with SqlConnection's 'AccessToken' property , and the entire token lifecycle had been driven by NodeJS layer (including refreshing token) using ADAL/MSAL NodeJs packages. ADS isn't designed similar to SSMS when it comes to Azure authentication, and that's why we have this huge design gap. To be clear, this is not just a Dataverse specific issue, but is a design issue in both tools (as they share the same backend service SqlToolsService).
The changes we are making will apply to all Azure SQL connections and are planned to be released together in both tools. And as we enable SqlClient integration with MSAL.NET, there's a greater chance things will be fragile (with regards to access tokens and persistence caching) with the way features and extensions are built and depend on access tokens and auth flows from NodeJS layer. We're trying our best here, but there's significant amount of testing needed across the product to ensure tool features and extensions' stability with the authentication layer shift, as it will affect every Azure SQL connection and related features.
Due to this reason, we will introduce this support in preview in March, so customers can enable the feature on-demand, and we can get feedback on experience and make incremental improvements along the way.
Hope that clarifies :)

Will this work for Mac Azure Data Studio installations as well? Thanks for your attention to this!

Will this work for Mac Azure Data Studio installations as well? Thanks for your attention to this!

Yes, we have no platform specific reservations for adding this support.

For my understanding... A service principal can use the tds endpoint of PowerApps for crud actions form March/April?

Authentication mode will still be MFA, so an Azure AD user account is needed. But we'll be able to connect with the dynamics endpoint instead of the default 'https://database.windows.net' when requesting access token.
I'll provide update here when this will be available in insiders, so we can have feedback from community before we release :)

Hi everyone,
This feature support is now available in ADS insiders (download link) and can be enabled with below setting:
    "mssql.enableSqlAuthenticationProvider": true

It will be available in the ADS March 2023 release and is currently NOT enabled by default.
I will proceed to close this issue as resolved, please open a new GitHub issue if you face any issues.
Thanks!

This is still non-functional. I have the 'Enable Sql Authentication Provider' option checked. - I've added my MSFT account as a linked account - but when I try to connect to Dataverse using this account, It appears to be looking for my email address instead of my domain name in the MSAL cache. - I get the following error and it fails. "User account (my email address) not found in MSAL cache, please add linked account or refresh account credentials."

Update: Syncing offline to investigate proper way of fixing username being used.

I assume I will be the first person to put a comment here saying it worked :). I managed to execute the first SELECT statement after getting successfully connected to the CRM Dynamics 365 DB using Azure Data Studio after couple of failed attempts to authenticate.
Client Machine ........ Macbook Apple Silicon based - M1 Max
MacOS .................... MS Ventura 13.2.1
Azure Data Studio ... https://azuredatastudio-update.azurewebsites.net/latest/darwin-arm64/insider
Here is a screenshot of the output

Now the two main issues I experience are:

I can't expand tables under the Database > same way I can on Microsoft SQL Management Studio
Columns names/tables names doesn't appear when I start writing their names

Hi @MohammadShalaby
Thanks for testing out, if the issues with expanding look related to https://github.com/microsoft/azuredatastudio/issues/22272, I'd suggest adding details there or upvoting it. Or if it's a different issue, please open a new issue to get the right attention.

@cheenamalhotra .. It is exactly #22272 .. Thx a million.
I will upload my comment there :)

Here's how to use MSAL to make a Service Principal connection to the TDS Endpoint. If you don't use your dataverseUrl as the scope you get an "unauthorized with client authentication scheme 'Anonymous'" error when accessing SQL.
Bare bones here, fill in your constants as required, if you want, this post shows how to cache the token and refresh as necessary.
`
string dataverseUrl = "https://mycompany.crm3.dynamics.com";
string resourceId = dataverseUrl + "/";
string scopes = [$"{resourceId}/.default"]; //Yes it’s, double //
var authority = $"https://login.microsoftonline.com/{aadTenantId}";

var app = ConfidentialClientApplicationBuilder.Create(clientId)
.WithClientSecret(clientSecret)
.WithAuthority(new Uri(authority))
.Build();
var result = await app.AcquireTokenForClient(scopes).ExecuteAsync();

sqlConnectionString = $"Server={dataverseUrl.Replace("https://", "")};Database={database};Encrypt=True;TrustServerCertificate=False;Persist Security Info=False";

sqlConnection.ConnectionString = sqlConnectionString;
sqlConnection.AccessToken = result.AccessToken;`


feat: add Vuepress hello World

Closes #12
By making a PR you are agreeing to that contributing a hello world project allows the repo/project owner to use the hello world app in examples for their own use.

[x] only the most simple basic hello world app
[x] remove all tests and commands for tests and dependencies for tests
[x] must say "Hello World" on the main component
[x] only include the minimal components (1 ideally)
[x] no routing, not extras whatsoever
[x] no styling
[x] nothing else !
[x] must work by running npm install and npm start (or equivalent)
[x] must be in the folder named <tech-name>
[x] add yourself using the all-contributors bot @allcontributors please add @<your-github-account> for code
[x] add build steps and which folder to serve in the README.md, Serve the public folder

all-contributors already in https://github.com/johnpapa/hello-worlds/pull/63


Added viewport resizer

Features added:

Manual resizer
user defined viewport size
predefined viewport size

I would like to have a different arrangement for the menu bar. I will play with this.
Shall we add another button to reset the viewport and take the full space. Just like the default way?
I am not sure I can access to my devbox in the weekend. I will definitely work on this on monday if not.
Everything looks great.

Yea sure. we can add the reset button. I'm also planning on adding a 'random' and 'hay' setting, just like the ones in bradfrost's ish.
So you want me to refactor toggles into another component? Where would you like to put it?

Very cool.
For the UI, I like to keep them in this palce. That's fine.
For a new component, just create a new file close to the layout.
May be name it as top_menu.js or something.

Very good stuff!

Very cool! I actually just forked this repo because I wanted to try and add this! :smile: Maybe draw some inspiration from Safari's responsive view?

Or even Chrome's.

Hey @jeef3. That look is super cool.
I am super happy if we can bring this to here.

Just for comparison, here's how Chrome does it:

However, since Storybook is used to develop components, it might make less sense to have device presets. We probably care more about how our components look at a certain width in pixels, than on a certain device — that would be more for full websites of the whole application layout.

@arunoda, I think we should transfer storybook to mantra structure ASAP so that other devs can work on adding features.

@sammkj you mean for the source of this repo. Hmm. That's something I didn't thought.
Mantra is build for apps, but that's a good idea. I will have a look at, how it can be done.

Was just thinking, I wonder if there could be a tidy way to pre-define the size, per component. Maybe if there was a pathway for passing options in per story?
storiesOf('My Component')
  .add('feature', { /* options */ }, () => { /* component */ });

Then you could use:
storiesOf('My Component')
  .add('feature', { initialWidth: 200 }, () => { /* component */ });

I just find that some of my components are designed to fill their container, but are meant for use within a certain size.
Of course, something like this has much bigger implications, possibly beyond the scope of this PR.

You can always wrap your stories with a Container Query rather than changing the viewport. Something like: http://d6u.github.io/react-container-query/

Personally, I'd prefer to just use my browser's built-in responsive tools, and have Storybook's "chrome" adjust for a mobile layout.
Storybook could fit the viewport to the window, hide menus and overlay simplified next story / prev story buttons.
Of course, this could be implemented as a custom layout, but why not just include a responsive layout by default?

Of course, this could be implemented as a custom layout, but why not just include a responsive layout by default?

Actually, with the implementation of #115, this resizer could just be a decorator...

@jeef3 That's a pretty clever idea.
I think we can simply use Facebook Design's devices.
@namuol using browser tools is also a pretty nice idea. We need to find a way to just render the iframe when doing tests. May be we can do it via with a set of keyboard shortcuts.

I agree with @namuol on this

For me, this feature is more about testing components that fill their container, but are designed to be used at, for example, '~100px x 80px'.
I could just wrap the story in a div styled to the right size, but it would be nice to be able to adjust it to make sure it responds appropriately to container size changes — not necessarily media queries.

I totally agree with @namuol as well. Had the same thoughts actually.
We need a quick button or key shortcut to hide all storybook UI and put the selected story into a "Full Screen" mode. The some additional minimal buttons or key shortcuts to jump to next or previous stories.
Even now if you hide the left nav and action logger there is still a small chrome around the whole viewport... so even that should go away in "Full Screen" mode.
This will be a good thing to have on it's own, plus it will help defer a mobile solution to external tools like Chrome Dev Tools.

@timkindberg Full screen mode is implemented in the mantra branch. We'll do a release within this week.

I've released version 1.20.0. As I mentioned, in that release we've the support for full screen support. You can switch to the full screen mode with CMD + SHIFT + F or CTRL + SHIFT + F.
Then we can use native browser tools for responsive testing. I think that's a better approach.
@sammkj What do you think?

@arunoda , sounds good! And the mantra branch is awesome!

@arunoda if we don't use the "native browser tools" but implement it in storybook itself, we can easier switch between different stories. I'm in favor of a "responsive toolbar" that we can show and hide in storybook. We can already resize the sidebar and the action-logger. If we can also change the location of the right edge, then we are already there.

@smeijer I think it's best if we make a storybook decorator for this.

@mnmtanish - was a decorator for toggling between full-screen navigation ever implemented?
I'd love to test my stories on a native mobile device, but it's completely unfriendly to that environment - the toolbar takes up half of the screen and accidentally clicking on the 'keyboard shortcut' helper takes over the entire screen without any means to disable it.
Would love to see the decorator, thanks!

@mnmtanish - was a decorator for toggling between full-screen navigation ever implemented?

I think this is built in now.

⌘ ⇧ F /  ⌃ ⇧ FToggle Fullscreen Mode

But that only helps you on desktops, not sure how to enable this on mobile devices...

Thanks @jeef3. It looks like full-screen mode can be entered by adding ?full=1 to the URL. Would be great to have an icon on the toolbar to enable that with a click/tap. A meantime workaround would be creating a story that handles it separately and hosted it in the story list - but this seems overkill to wire up something that, IMO, should be native.

We really do need to work on the UI to make it more mobile friendly but it might take some time. For now, I think we can fix it by making the "shortcuts helper" mobile friendly and then make shortcut info clickable as mentioned here.
Related issues:
https://github.com/kadirahq/storybook-ui/issues/10

Awesome for Full Screen Mode + Device Preview, but most time I develop mobile site, I want keep the sidebar and preview in a device container, to switch pages quickly. Currently I must open two window.
@sammkj this PR is great for me, can we just extract the code to an independent library? we can use it with a decorator.


Slow buffering on mpv

The default config uses --no-ytdl and *VIDEO* for the args of mpv but this causes extremely slow buffering on slow internet connections and also prevents mpv from showing video chapters.
Would like to know if there is a reason these are used rather than using *URL*.

Will not merge this, for multiple reasons (resolution cannot be selected from pipe-viewer, videos will take longer to start, depends on youtube-dl/yt-dlp)
People that want this, can easily edit the config file or add a new player entry in the video_players section, as:
 mpv_native => {
   arg => "--really-quiet --force-media-title=*TITLE* *URL*",
   cmd => "mpv",
   fs => "--fullscreen",
   novideo => "--no-video",
   srt => "--sub-file=*SUB*",
 },

...and setting video_player_selected to "mpv_native".


Question: Is there a plan to provide mentioned unsupported-features ?

As per https://github.com/apideck-libraries/postman-to-k6#unsupported-features, some features are not supported (although this pm.response.to.have.status(200); worked for us!) which creates some blockers in converting our already written postman scripts to k6 scripts.
Is there a plan to provide for those features? Until these are provided, any other workarounds for these missing features?
Thanks for maintaining this friendly fork!

@svmundada
The documented "unsupported" features were taken over from the original repo.
I'll review the list of features, since pm.response.to.have.status is working.
With regards to brining support for these features, it depends on the needs of the community and the feasibility within K6.
For example: postman.setNextRequest is a highly demanded request BUT it wouldn't fit the K6 functionality.
We could covert postman.setNextRequest to a series of K6 requests, that are generated as a sequence of seperate requests (the "navigaiton use-case of postman.setNextRequest) but how would know how to handle logic (IF ELSE) that can be trigger in Postman?
Or we could trigger a loop in K6, with the IF ELSE, but this would only cover the looping use-case of postman.setNextRequest.
Feel free to share missing features and use-cases, so we can discuss if they could fit postman-to-k6 conversion.

The documented "unsupported" features were taken over from the original repo.
I'll review the list of features, since pm.response.to.have.status is working.

sure thanks.
At the moment, having pm.sendRequest and pm.response.headers.* would be of great help to us. Are these possible?

I'm currently in the process of slowly creating a proof of concept for using postman-to-k6 for our QA team.
Ideally we would need the pm.sendRequest would be awesome to have. As currently we have to call AWS cognito to get user credentials before I can make any other calls, and having a the pre-script to get the tokens would be awesome. Currently I'm looking into creating a bespoke implementation that could fix this, but it does seem to break the workflow using postman-to-k6.

@Kpizzle The pre-request scripts are supported, but the "pm.sendRequest" would be more difficult, since this concept does not really exist in the K6 concepts.
As a work-around I do it like so:

Create a seperate NodeJs script or bash script
In the NodeJS script, it generates a Postman Environment file as result, with the necessary tokens
Convert Postman to K6 with the generated Postman environment file
Run generated K6 script

A simplified example of a packages.json contains the steps mentioned:
{
  "name": "api-k6",
  "version": "1.0.0",
  "description": "API - K6 testing suite",
  "scripts": {
    "generate:k6:api:oauth:token": "node api.pipeline.env.js",
    "generate:k6:api:pipeline": "postman-to-k6 api.postman.json --output  k6-script.js --environment api.pipeline.env.json ",
    "test:k6:api": "k6 run k6-script.js",
    "generate:k6:report": "node utils/generateReport.js"
  },
  "dependencies": {
    "@apideck/postman-to-k6": "^1.8.3",
    "axios": "^0.24.0",
    "dotenv": "^9.0.2",
    "k6-html-reporter": "^1.0.5",
    "k6-to-junit": "^1.0.3"
  }
}

Example of the api.pipeline.env.js script that generates the Postmen environment (using an Oauth flow), which uses ENVIRONMENT variables to pass along authentication parameters.:
const fs = require('fs');
const path = require('path');
const request = require('axios');
const dotenv = require('dotenv');
dotenv.config({path: __dirname + '/.env'});

if (!process.env.OAUTH_ACCESS_TOKEN_URL) {
    console.log('No ENV variables or .env file found.')
    process.exit(1)
}

const currentTime = new Date().getTime();

const requestOptions = {
    url: process.env.OAUTH_ACCESS_TOKEN_URL,
    method: 'POST',
    headers: {"Content-Type": "application/json"},
    data: JSON.stringify({
        "client_id": process.env.OAUTH_CLIENT_ID,
        "client_secret": process.env.OAUTH_CLIENT_SECRET,
        "audience": process.env.OAUTH_AUDIENCE,
        'account_id': process.env.OAUTH_ACCOUNT_ID,
        "grant_type": "client_credentials"
    })
};

request(requestOptions)
    .then(function (res) {
        const resBody = res.data
        let postmanEnv = {
            "id": "7796f73b-b0d8-4b1a-98c8-9951304740b8",
            "name": "api-PIPELINE",
            "values": [
                {
                    "key": "baseUrl",
                    "value": process.env.BASEURL,
                    "enabled": true
                },
                {
                    "key": "oauth_access_token",
                    "value": resBody.access_token,
                    "enabled": true
                },
                {
                    "key": "oauth_access_token_expires",
                    "value": resBody.expires_in,
                    "enabled": true
                },
                {
                    "key": "oauth_access_token_url",
                    "value": process.env.OAUTH_ACCESS_TOKEN_URL,
                    "enabled": true
                },
                {
                    "key": "oauth_grant_type",
                    "value": "client_credentials",
                    "enabled": true
                },
                {
                    "key": "oauth_client_id",
                    "value": process.env.OAUTH_CLIENT_ID,
                    "enabled": true
                },
                {
                    "key": "oauth_client_secret",
                    "value": process.env.OAUTH_CLIENT_SECRET,
                    "enabled": true
                },
                {
                    "key": "oauth_audience",
                    "value": "https://audience.example",
                    "enabled": true
                },
                {
                    "key": "oauth_account_id",
                    "value": process.env.OAUTH_ACCOUNT_ID,
                    "enabled": true
                },
                {
                    "key": "oauth_base_url",
                    "value": process.env.OAUTH_BASE_URL,
                    "enabled": true
                }
            ]
        };

        let postmanEnvOutput = JSON.stringify(postmanEnv, null, 2);
        let currentFile = path.basename(__filename);
        let postmanEnvFile = currentFile.substring(0, currentFile.length - 3);
        fs.writeFileSync(__dirname + '/' + postmanEnvFile + '.json', postmanEnvOutput, 'utf8');

        console.log('Auth0 access token updated');
    })
    .catch(function (err) {
        // handle error
        console.log(`POST ${process.env.OAUTH_ACCESS_TOKEN_URL} failure`, err.message)
        process.exit(1)
    })

so locally or in my CI/CD I use the following sequence:
npm run generate:k6:api:oauth:token && npm run generate:k6:api:pipeline
npm run test:k6:api

FYI: I have collected your question in the "discussions" section for future reference.

Awesome @thim81 thanks very much! I'll have a deep-dive into this and continue the conversation in the discussion section.

Is there any news or plans to support pm.response.headers.*? I noticed @svmundada asked but there was no answer for this specific feature.
We rely a lot on validating response headers so this feature would be super useful for me and my team.

hi @kgrozdanovski
I can investigate to see what is needed to bring the support.
Could you share an example of what you would do with the pm.response.headers.*?

hi @kgrozdanovski
Thanks to a contribution from @aegrey, postman-to-k6 supports 2 header methods: pm.response.headers.all() & pm.response.headers.get(). These are part of the v1.9.0 release.


Route order not respected for "*" host

Describe the bug
Route order is not respected for routes with "*" wildcard in the hosts - see "To Reproduce" section.
To Reproduce
Setup proxy with following configuration:
public class EsProxyConfig : IProxyConfig
{
    private readonly CancellationTokenSource _cts = new CancellationTokenSource();

    public EsProxyConfig()
    {
        ChangeToken = new CancellationChangeToken(_cts.Token);
    }

    public IReadOnlyList<RouteConfig> Routes => new List<RouteConfig>()
    {
        new RouteConfig()
        {
             ClusterId = "httpbin",
             RouteId = "httpbin",
             Match = new RouteMatch() {
                 Path = "{**catch-all}",
                 Hosts = new[] { "*" }
             },
             Order= 1
        },
        new RouteConfig()
        {
             ClusterId = "github",
             RouteId = "github",
             Match = new RouteMatch() {
                 Path = "{**catch-all}",
                 Hosts = new[] { "foo-localhost" }
             },
             Order= 10
        }
    };

    public IReadOnlyList<ClusterConfig> Clusters => new List<ClusterConfig>() {
        new ClusterConfig()
        {
               ClusterId = "httpbin",
               Destinations = new Dictionary<string, DestinationConfig>(StringComparer.OrdinalIgnoreCase)
                {
                    { "destination", new DestinationConfig() { Address = "https://httpbin.org" } },
               }
        },
        new ClusterConfig()
        {
               ClusterId = "github",
               Destinations = new Dictionary<string, DestinationConfig>(StringComparer.OrdinalIgnoreCase)
                {
                    { "destination", new DestinationConfig() { Address = "https://github.com" } },
               },
        }

    };

    public IChangeToken ChangeToken { get; }
}

The httpbin route has "*" wildcard provided in the hosts and has lower order - therefore all requests to the proxy should be routed to httpbin. Given the proxy running on localhost, see the requests toghether with expected/and the actual route (wrong routing highlighted as bold):

Request
Expected route
The actual route

curl http://localhost
httpbin
httpbin

curl -H "Host:foo-localhost" http://localhost
httpbin
github

To get the routing work as expected, hosts configuration from httpbin route can be ommited as shown below.
new RouteConfig()
{
     ClusterId = "httpbin",
     RouteId = "httpbin",
     Match = new RouteMatch() {
         Path = "{**catch-all}",
// REMOVE HOSTS CONFIGURATION
//         Hosts = new[] { "*" }
     },
     Order= 1
},

Further technical details

.NET 6
YARP.ReverseProxy v1.0.0
Platform: Windows

We'll have to do some research to better understand the behavior.
While this does deserve an explanation, I don't expect there's anything YARP could/would do to change it since Host routing is a built-in ASP.NET Core component.

This issue was moved to dotnet/aspnetcore#39920


More fixes for POC rename symbol

Few more fixes on this:

Other language servers I've used were just returning nil for the version, which seems to have fixed the [coc.nvim] Error on applyEdits: Error: file:///.... changed before apply edit issue I was having before
Find references when on a variable definition also finds the definition itself, so we were getting duplicate entries in the list of edits because of that. Just done a Enum.uniq on the list of changes to fix that
For files other than the one you are on it now returns the URI in the correct format (it wasn't working before)

Stuff I think still needs doing:

[x] There's a small bug with ElixirSense where it doesn't find references for a variable if the definition is on the line after the variable name, something like:

cow =
  "moo"

I've now raised a PR for this on the elixir sense repo - https://github.com/elixir-lsp/elixir_sense/pull/172 - it has been merged now

[x] - Tests for rename prepare functions
[x] - Preparing to rename currently fails for a function defined in another file, so that needs fixing

Things for follow-up PRs:

[ ] - Rename module functionality
[ ] - Find references (and hence rename) doesn't work when a usage of a variable is in a list comprehension (this is more of an issue with existing Elixir Sense functionality rather than the rename functionality, but it would be nice to fix)

Btw do you have any guidance on testing with VS code? I mostly use Vim, but would like to test things out on VS code too. UPDATE: This seems helpful - https://dragoshmocrii.com/fix-vscode-elixirls-intellisense-for-code-imported-with-use/

@Tuxified I think this is pretty much ready, though recent changes to the elixir sense dependency seem to have broken things :( I need to take a deeper look into that but let me know if you have any suggestions. Adding the trace argument seems to fix most things, but the test for renaming a function defined in another file is now broken :(

Added some test setup bits and it's all working again now 👍
Let me know if you're happy to merge this to get your PR updated, or if it would be easier for me to raise a new PR with the main repo and then I can follow up any comments too. I'm happy either way :)


Consider refactor: WidgetsManager + KernelManager + OutputRenderer

There is poor documentation about the Jupyter-widgets and jupyterlab-manager. The current implementation is an adaptation of the thebelab plugin.
I think that we can omit WidgetsManager somehow.
If it is not possible, another idea is to use the WidgetsManager as the interface to manage kernels and the OutputRenderer.

This repository is no longer maintained. It has been superseded by IBM Quantum Learning.


Update 3Sum.py

Added Edge Case Handling,Improved Loop Efficiency,Early Exit: If nums[i] > 0, we break out of the loop, as all subsequent numbers will be positive, and no sum can reach zero.

any updates ?


chore: enrich panic context when BooleanBuffer fails to create

TRIVIAL AS IS
Today I encounter this panic while I have no idea whether my data set is too large or there is other logical errors.

Besides, I encountered this issue when iterating StreamReader. I wonder if we should return an error on data too large rather than panic here.


Bugfix gradients

Context:
The more_strategies PR introduced several custom gradients, but we never noticed they were broken under some conditions.
Description of the Change:

Gradients are now cast to the backend array type
This PR also adds the numpy option to the bargmann methods

Benefits:
Gradients work
Possible Drawbacks:
None
Related GitHub Issues:
None

Why no changelog for this change?

Why no changelog for this change?

Because it's not fixing a bug in a previous version, so it wouldn't make sense to claim a bug was fixed in the upcoming release


add the little Rectangle interface that I need for a geoHash implemen…

…tation. :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
56 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 65.744%

Files with Coverage Reduction
New Missed Lines
%

Pharo/PharoJs-Base-JS-CoreLibraries/PjObject.class.st
56
15.47%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
12941

Relevant Lines:
19684

💛  - Coveralls


Make a perfect logo for Taaveez

Is your feature request related to a problem? Please describe.
The creation of a new logo for our project. We believe a fresh and visually appealing logo would greatly enhance the overall presentation and identity of our project.
Requirements:

The new logo should reflect the core values and essence of our project.
It should be visually striking, memorable, and versatile.
We prefer a modern and clean design that conveys professionalism and innovation.
The logo should be suitable for both digital and print applications.
It should incorporate relevant elements or symbols that represent the nature of our project.

Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
Please note that the selected logo design will be used across various platforms, including our website, social media profiles, and marketing materials. We are open to creative suggestions and encourage designers to showcase their unique vision while ensuring that the logo aligns with our project's objectives.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I hope that to create a attractive logo for your project kindly assign me this issue under GSSOC'23 @Suryansh1720001

@NANDHINI45
I'm assigning you this task for GSSoC'23. You can reach out to me on LinkedIn through this link or follow me on GitHub. Feel free to connect with me regarding this app and its theme.

@NANDHINI45 I'm assigning you this task for GSSoC'23. You can reach out to me on LinkedIn through this link or follow me on GitHub. Feel free to connect with me regarding this app and its theme.

Sure sir


Remove browser compatibility table and use the one on GDS DS

GDS updated their browser support list twice a year. We should remove our table and link to theirs instead
https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices
Comment:
Will speak with @leonrose about getting browserstack plan upgraded to mobile automate so we can test with our new support list.

Resolved: https://ons-design-system.netlify.app/guidance/browser-testing/


Bind directional hjkl for the Problems panel

I'm trying to bind a vim-style hjkl mapping in the Problems panel as a substitute for directional arrow keys, but it doesn't seem to be possible right now.
Exposing the directional commands for the Problems panel just like list.focus{Up,Down}, list.{expand,collapse}, etc. would be a really great feature.

See your SO question for a possible answer: https://stackoverflow.com/a/78381623/836330

Copying my comment from SO:

when I tried, I used the default when clause- listFocus && !inputFocus && !treestickyScrollFocused, which had the issue of the filter getting focus for typing when key had no modifiers.

Thanks for the fix, I'll try it out on the next update.
For now, I'm using the following workaround from the stackoverflow post:
{
  "key": "k",
  "command": "list.focusUp",
  "when": "focusedView == 'workbench.panel.markers.view'"
},
{
  "key": "j",
  "command": "list.focusDown",
  "when": "focusedView == 'workbench.panel.markers.view'"
},
{
  "key": "h",
  "command": "runCommands",
  "args": {
    "commands": [
      "list.collapse",
      "widgetNavigation.focusNext"
    ]
  },
  "when": "focusedView == 'workbench.panel.markers.view'"
},
{
  "key": "l",
  "command": "runCommands",
  "args": {
    "commands": [
      "list.expand",
      "widgetNavigation.focusNext"
    ]
  },
  "when": "focusedView == 'workbench.panel.markers.view'"
}

The widgetNavigation.focusNext seems to be necessary because list.expand somehow focuses the filter box, but only with my custom binding ({Left,Right}Arrow doesn't cause a focus change).

This bug has been fixed in the latest release of VS Code Insiders!
@musjj, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version<PHONE_NUMBER>a2d269e7f4556369d44ed5b71dfabf of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

Works perfectly in code insiders, thanks for the fix!
/verified


pubsub: add keepalive

If streaming pull connection is idle for a long time,
a firewall/proxy might terminate the connection.
The keepalive should prevent this from happening,
or at least let us notice that the connection is terminated so we don't
wait forever.
Fixes #2506

We seem to be getting some deadlock in CI. Analysis and experience suggest these flakes are caused by the test themselves; the libraries aren't doing anything fundamentally wrong.
I'm planning to simply pubsub implementation and tests in upcoming weeks which, I hope, will make these flakes go away. I think we can merge this for now.


Upgrade to Cosmopolitan 3.0

Regarding this section from your readme https://github.com/dinosaure/esperanto#pthread-and-platforms on cosmo's pthread support. We cover the POSIX threads API pretty comprehensively now. Let me know which specific things are missing, if that's still the case. I'd be surprised if it's still not ready.


mpris-scrobbler: add ListenBrainz to the desc.

The project’s online manpage (https://www.mankier.com/1/mpris-scrobbler) mentions ListenBrainz before the other services.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

The README also mentions it before the Audioscrobbler-compatible options. I think making this change can help with discovery (I was looking for a ListenBrainz-compatible option because I think it’s a better project to contribute data to).


[CT-2606] [Bug] Contract enforcement checks do not sent SQL header

Is this a new bug in dbt-core?

[X] I believe this is a new bug in dbt-core
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
Turning on the contract enforcement sends a where false limit 0 query that does not include the SQL header. This can cause failures, e.g. when the sql header is used to declare a variable or temporary function which is referenced in the model query.
Expected Behavior
The sql header should be sent.
Steps To Reproduce
With dbt 1.5 and dbt-bigquery 1.5.1
A simple model with contract enforcement enabled
version: 2
models:
  - name: demo
    contract:
      enforced: true
    columns:
      - name: demo_text

{% call set_sql_header(config) %}
DECLARE DEMO STRING DEFAULT 'hello world';
{% endcall %}

SELECT DEMO AS demo_text

results in a query being sent like this, which fails because the variable declared in the header does not exist

    select * from (

SELECT DEMO AS demo_text
    ) as __dbt_sbq
    where false
    limit 0

The model runs successfully without contract enforcement enabled.
Incidentally, the location of the failed SQL is not reported as with regular model / test failures, but the BQ adapter does drop in a link to the failed job in BQ's UI.
Relevant log output
No response
Environment
- OS: max
- Python: 3.9
- dbt: 1.5
- dbt-bigquery: 1.5.1

Which database adapter are you using with dbt?
bigquery
Additional Context
No response

Thank you for opening and providing a reproduction case @elyobo! I've added it to https://github.com/dbt-labs/dbt-core/issues/7372 for tracking.

Thanks @MichelleArk!


[ConstraintSystem] Use an explicit generic argument constraint for UnresolvedSpecializeExpr.

The eager generic argument matching code in CSGen for unresolved specializations was incorrect because it didn't account for parameter packs. Fortunately, a constraint to delay explicit generic argument matching already exists for macros. Use it here.

@swift-ci please smoke test

@swift-ci please smoke test


Find and Replace feature, Write_Log feature

2 new features, 1 still isnt done. Write_Log function just takes in a string and writes it down on a file in /logs/log.txt
Find and Replace seems to be able to find the text but it doesnt replace it properly. it replaces some other random text in the editor. i also found a bug, try doing SHIFT + TAB, it will type "a" instead of indenting backwards. I cant seems to figure out the issue with the random changing of text from the Find and Replace. i explained how to use it in the comments.

Good stuff, thanks! I will look into why it doesn't work properly, it can be kind of hard to work with the buffer if you aren't familiar with how it's set up. The logging feature is also super handy, and I was just planning on implementing one, so thanks for that. One note though, I prefer pull requests to focus on one thing, so instead of submitting both at the same time, you do one for the logging, and one for the search and replace. It's not a big deal, but it just makes it a bit  easier to review, because I know what is for what.
Thanks a ton!


Bulk import

Would you accept a pull request to allow pasting in bulk csv-like text?
A quick and dirty console script I was using to import a list:
const words = `
question1;answer2
question2;answer2
`;

words.split('\n').map(word => word.split(';')).forEach(pair => {
  $('#h-action-create').click()
  $('#card-question-input').value = pair[0]
  $('#card-answer-input').value = pair[1]
  $('button[type="submit"]').click()
})

But ideally there would be a field somewhere in the deck settings to do this properly.

Hi, I personally don’t use this extension myself, and I don’t like the design either: D
Therefore, thanks, but there is no point in wasting time on this repository :)


[T4A6][F12-A3]Joel Lim Jing

Ready for Review

@funnieguy
Some comments added. Please ack & close the PR after reading comments.

Ack thanks


autoclicker poorly randomized or not randomized at all

the autoclicker doesn't take 10s to flag on karhu for: Autoclicker (I) - no randomization
I also tested on coldpvp and got banned in 2 fights using it.

Autoclicker is kind of poorly randomized, but it is randomized. It's safe to use unless you go to kinda high CPS (15+). Originally, I tested thoroughly 14 CPS on anticheat-test, on multiple anticheats, with no flags for extended periods of time (except on anticheats that would also flag ~10 CPS human clicking).
On Karhu, I tested:

CPS
Time
Notes

13 CPS
A minute and a half
no flagging

14 CPS
About 50 seconds
Autoclicker (C) - Low Outliers

15 CPS
About 40 seconds
Autoclicker (C) - Low Outliers

17 CPS
About 8 seconds
Autoclicker (I) - No Randomization

19 CPS
About 5 seconds
Autoclicker (I) - No Randomization

Unless you're using really high CPS, I don't see a reason to worry about Autoclicker (I), just use lower CPS.
In regards to Autoclicker (C), I will test and modify the autoclicker to hopefully completely eradicate them.
If you're still experiencing Autoclicker (I) while using low CPS, please comment on this issue with the CPS count you're getting flagged on.


Consistently use same default model

Description
Use the same default model for the llm factory and the llm_task factories, so that these are entirely equivalent:
llm = nlp.add_pipe("llm", config={"task": {"@llm_tasks": "spacy.NER.v3"}})

and
llm = nlp.add_pipe("llm_ner")

Corresponding documentation PR

NA
Types of change
fix
Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[x] I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes

all external tests (i. e. pytest ran with --external)
all tests requiring a GPU (i. e. pytest ran with --gpu)

[x] My changes don't require a change to the documentation, or if they do, I've added all required information.

Should succeed after merging in develop.