Notification light not working properly

Expected behavior
Notification light should be activated when a new message arrives, independent from any other settings
Actual behavior
Notification light is only working when at least "vibrate when mail arrives" is activated
Steps to reproduce

Set ringtone to "none"
Disable "Vibrate when mail arrives"
Get new mail => no notification light

Environment
K-9 Mail version:
5.4.2
Android version:
8.0.0
Account type (IMAP, POP3, WebDAV/Exchange):
IMAP

I believe this is expected Android behavior.

If this is expected Android behaviour, then the options menu shouldn’t let you configure something that the OS won’t allow.

I believe this is expected Android behavior.

No, it's most certainly not. I'm using LED notifications for other apps without any sound or vibration notification. I'd like to be notified about emails discretely, thus only by LED, not by vibration or ringtone.
Please re-open this issue. A fix / adjustment for newer Android versions would be highly appreciated.

We're not doing anything special. Just configuring what we'd like a notification to look/sound/feel like. What the OS does with that information is highly dependent on the particular Android flavor on a device.
The next K-9 Mail version won't allow you to configure vibration and notification light on newer Android versions because it's now handled by Android itself. Maybe this will fix your issue. If not, you'll have to take it up with the vendor of your Android device anyway.

Please don't remove these configuration options. Newer Android versions offer a new notification API that you need to implement for allowing notification configuration for certain events. I see many different notification options for some apps (messengers, calender, todo-app, etc.) but only enable/disable notifications for K-9, because apparently it doesn't use that API. If you want to remove the options from the app, you would at least need to implement that notification API, otherwise there won't be any way to configure notifications at all. But as I see it, this API doesn't allow configuration of the LED light, only sound and vibration, so it wouldn't be a good alternative anyway.
Please leave the options in K-9 as they are and try to find a way to start the LED notification without having to use sound or vibration additionally. Would it be possible to enable vibration but set the vibration number to 0 or alternatively the rythm to a very short, unnoticeable vibration duration? That way the vibration trigger will trigger the LED vithout actually vibrating. That might also be a workaround you could implement if only LED notifiction is enabled on newer Android devices, so it would just work for everyone.


Release procedure

See issue #371 for discussion of these changes.
Release checklist

[NA ] Authors updated in cf-conventions.adoc?
[NA] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
[NA] history.adoc up to date?
[NA] Conformance document up-to-date?

For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

Hopefully I've captured all of the versioning and actions stuff in https://github.com/cf-convention/cf-conventions/pull/372/commits/4c9e120d06fc4466e9f7f80945aff5af5b7f19fb

Ethan and I thought that we should now try and use this procedure on the release of CF-1.10 (in a couple of weeks, or so), fixing any problems with the checklist as we go. Then the "proven" release procedure can be merged, ready for CF-1.11 ...


Update free-programming-cheatsheets.md

What does this PR do?
Add resource(s)
For resources
Description
PHP cheat sheet
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Thanks, and welcome to free-programming-books!


Query erlang.log creation

I am using lager. This is my config.
There is an erlang.log file being created in the log folder which is essentially duplicating stuff that is in debug.log. Could you tell the reason for its creation?
I am passing this in vm.args file to erlang
-sasl sasl_error_logger false

{lager, [
        {log_root, "log" },
        {crash_log, "crash.log"},
        {handlers, [
            {lager_console_backend, [
                {level, debug},
                {formatter, lager_default_formatter},
                {formatter_config, [time," [",severity,"] ", message, "\n"]}
            ]},
            {lager_file_backend, [
                {file, "debug.log"},
                {level, debug},
                {formatter, lager_default_formatter},
                {formatter_config, [date, " ", time," [",severity,"] ",pid, " ", message, "\n"]},
                {size, 2097152}, {date, "$D0"}, {count, 5}
            ]}
        ]}
    ]}

@pankajsoni19
meet the same issue recently, wonder how you fix it
tks

Couldn't fix it. These are 5 files, and not much of a big deal so ignored it. I just wanted to know the reason, why this was happening.

Thanks for quick reply.
In my case, it is a  real matter, because I find that there are quite many logs writen into this file
Also I find that my erlang application is not running normally, from the log output, I see some latency (somethings > 1s) happened now and then.
I can't find how to disable erlang.log

That's not a lager file. Your release may be logging stdout to the file, in which case you may want to try disabling the console log handler.

@Vagabond
Thanks for your tips, I will have a try.

by https://erlang.org/doc/man/run_erl.html , find that erlang.log is created by run_erl.


timescaledb-tune invocation fails

After doing go get, I tried calling timescaledb-tune which returned EXIT: unknown major PG version: PostgreSQL 12.0

TimescaleDB does not currently support PG12.  We will be releasing support for PG12 in our next release, v1.7.

Actually, I might have closed this too early...but could this be related to installing via helm?
https://github.com/timescale/timescaledb-tune/issues/61

No, I was trying to install timescaledb with postgres 12. So when you said it's not supported then I tried it with postgres 11 and it worked fine.


Edits to Flux and to all tutorials

Should be ready to merge if it builds.

I am fixing the headers back and switching to new options style

I think that is the first time that the smoke tests caught a real error for me! :)

They have definitely caught real errors by me on other projects...


Chinese word

Describe the bug
Chinese word show Square
Screenshots

Info (please complete the following information):

Browser [e.g. chrome, safari]:

if [ -f ./oclint_result.html ]; then echo '-----分析完毕-----'
else echo "-----分析失败-----"; fi

Hello! Does this occur in both Chrome and Safari? Or only Safari...

@ChendayUP this is a duplicate of #439. I have updated that issue to make sure Chinese characters get fixed as well for Safari


Added support for ACLs on port groups.

Added support for ACLs on port groups.

To do this, I used the ovn-nbctl acl-add as a model, and added an entityType
parameter to the API which could be either PORT_GROUP or LOICAL_SWITCH.
In order to preserve the existing APIs, I added a new set of APIs called
ACLAddEntity/ACLDelEntity/ACLListEntity.
It would look a lot cleaner to keep the old API names, but that would require
all users to be okay with the signature change. ovn-kubernetes isn't using the
old APIs yet, so the change wouldn't affect that project.

I also made an optimization suggested by vtolstov on my last pr.
Signed-off-by: Andre Fredette<EMAIL_ADDRESS>

Thanks @anfredette . LGTM!
A minor comment is that it would be better to split the fixes such as for the problem when external_ids == nil in separate commits. Let me know if you'd like to do that.

Thanks @anfredette . LGTM!
A minor comment is that it would be better to split the fixes such as for the problem when external_ids == nil in separate commits. Let me know if you'd like to do that.

I agree. I’ll split it out.
Thanks,
Andre
On Sun, Jan 3, 2021 at 5:21 PM Han Zhou<EMAIL_ADDRESS>wrote:

Thanks @anfredette https://github.com/anfredette . LGTM!
A minor comment is that it would be better to split the fixes such as for
the problem when external_ids == nil in separate commits. Let me know if
you'd like to do that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/eBay/go-ovn/pull/122#issuecomment-753691164, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHY7X3QKMLWM2U3JRHXDDTSYD3Y3ANCNFSM4VGJWSRA
.

I agree. I’ll split it out.
Thanks,
Andre
On Sun, Jan 3, 2021 at 5:21 PM Han Zhou<EMAIL_ADDRESS>wrote:

Thanks @anfredette https://github.com/anfredette . LGTM!
A minor comment is that it would be better to split the fixes such as for
the problem when external_ids == nil in separate commits. Let me know if
you'd like to do that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/eBay/go-ovn/pull/122#issuecomment-753691164, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHY7X3QKMLWM2U3JRHXDDTSYD3Y3ANCNFSM4VGJWSRA
.

I've updated this PR as follows:

Created Issue #124 and split out fix as PR  #125.
Rebased this PR on PR #124.
Optimized getACLUUIDByRow()

when we have the row UUID, we don't have to loop through the table to find it.

I've updated this PR as follows:

Created Issue #124 and split out fix as PR  #125.
Rebased this PR on PR #124.
Optimized getACLUUIDByRow()

when we have the row UUID, we don't have to loop through the table to find it.

Per Han's request above, and discussion on Slack, I've changed the port group ACL APIs to use the PG name instead of the PG UUID.
NOTE: I've kept this change as a separate commit to facilitate reviews.  After I get the thumbs up, I will squash the last two commits.

Per Han's request above, and discussion on Slack, I've changed the port group ACL APIs to use the PG name instead of the PG UUID.
NOTE: I've kept this change as a separate commit to facilitate reviews.  After I get the thumbs up, I will squash the last two commits.

This PR has been reworked on top of PR-125.

This PR has been reworked on top of PR-125.


Should not attempt to log variables if null

This could lead to an exception, preventing the result to be sent to the client.

Coverage decreased (-0.01%) to 72.702% when pulling e0756c0c7f19ea167d5a786587069f85b989b8e6 on fix-variables-log into 3aed166c366f8ad76fddffc3360186b6342c260d on master.


Init TTL and hop_limit in Echo response

Fixes https://github.com/Igalia/snabb/issues/1069

Looks good.  In some future we should make this default TTL configurable, but it is good as is.  Would you mind adding an end-to-end test?

Where did the tests go?  I could have sworn you added some end-to-end tests.

I think I overwrote the PR by mistake, removing the tests. Luckily I still had the changes on a local branch.


KAFKA-2453: Enable new consumer in EndToEndLatency

closing and reopening pull request to re-trigger build (failed due to intermittent test)

reopening to trigger build

Failure due to what should be an unrelated test. Build passes locally (QuotasTest this time).

Confirmed this passes system tests (as contract of EndToEndLatency was changed in performance.py). Build: http://jenkins.confluent.io/job/kafka_system_tests_branch_builder/62/

This can be cleaned up post KAFKA-2486. I'll make the changes now.

System tests passed http://jenkins.confluent.io/job/kafka_system_tests_branch_builder/64/

Looks good overall. Do we want to add a JIRA to move this to the java client tools at some point?

Closing and reopening to trigger build (ProducerTest failure which runs locally)

testMetricsLeak failed this time

Triggering build after 5th random failure (SocketServerTest this time). Still passing locally. todo: look at build stability.

Ran System Tests also and still passing http://jenkins.confluent.io/job/kafka_system_tests_branch_builder/69/console
@gwenshap I did some detailed testing today using this patch on ec2. I seems ok. Could we commit?

can you address the questions I posted earlier today?

Removed changes relating to seekToEnd

LGTM. Just do a follow up on whether message size can be a parameter in performance.py rather than "20".


Failing to break lease for PREMIUM_LRS storage or detach os disk

I have several virtual machines which uses a bunch of blobs. these blobs are divided into two storages (PREMIUM_LRS and STANDARD_LRS). If i try to restore a blob, i shutdown the virutel machines which is using the blob and then break the lease (instead of deleting the VM). this works fine for STANDARD_LRS stored blobs. For PREMIUM_LRS Blobs i allways get the Message: "This blob is being used by the system." - but i did stop and deallocated the using virtuel machine?!
DEBUG LOG:
File logging enabled - Writing logs to '/root/.azure/logs'.
Command arguments ['storage', 'blob', 'lease', 'break', '-b', 'test02-db01-02.vhd', '-c', 'vhds', '--connection-string', 'DefaultEndpointsProtocol=https;EndpointSuffix=core.cloudapi.de;AccountName=[REPLACED];AccountKey=[REPLACED]']
Current cloud config:
{'endpoints': {'active_directory': 'https://login.microsoftonline.de',
               'active_directory_data_lake_resource_id': None,
               'active_directory_graph_resource_id': 'https://graph.cloudapi.de/',
               'active_directory_resource_id': 'https://management.core.cloudapi.de/',
               'batch_resource_id': 'https://batch.cloudapi.de/',
               'gallery': 'https://gallery.cloudapi.de/',
               'management': 'https://management.core.cloudapi.de/',
               'resource_manager': 'https://management.microsoftazure.de',
               'sql_management': 'https://management.core.cloudapi.de:8443/',
               'vm_image_alias_doc': 'https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json'},
 'is_active': True,
 'name': 'AzureGermanCloud',
 'profile': 'latest',
 'suffixes': {'azure_datalake_analytics_catalog_and_job_endpoint': None,
              'azure_datalake_store_file_system_endpoint': None,
              'keyvault_dns': '.vault.microsoftazure.de',
              'sql_server_hostname': '.database.cloudapi.de',
              'storage_endpoint': 'core.cloudapi.de'}}
Registered application event handler 'CommandTableParams.Loaded' at <function add_id_parameters at 0x7f41b36039d8>
Registered application event handler 'CommandTable.Loaded' at <function add_id_parameters at 0x7f41b36039d8>
Successfully loaded command table from module 'storage'.
 Once a lease is broken, it cannot be renewed. Any authorized request can break the lease; the request is not required to specify a matching lease ID. When a lease is  [...]
Getting data service client service_type=BlockBlobService
azure.multiapi.storage.v2017_04_17.common._auth : String_to_sign=PUT

x-ms-client-request-id:fd4b8d8e-da4f-11e7-a7b7-a434d9460bfd
x-ms-date:Wed, 06 Dec 2017 06:37:55 GMT
x-ms-lease-action:break
x-ms-version:2017-04-17
/test02fast/vhds/test02-db01-02.vhd
comp:lease
azure.multiapi.storage.v2017_04_17.common.storageclient : Client-Request-ID=fdb89488-da4f-11e7-a7b7-a434d9460bfd Outgoing request: Method=PUT, Path=/vhds/test02-db01-02.vhd, Query={'comp': 'lease', 'timeout': None}, Headers={'x-ms-lease-id': None, 'x-ms-lease-action': 'break', 'x-ms-lease-duration': None, 'x-ms-lease-break-period': None, 'x-ms-proposed-lease-id': None, 'If-Modified-Since': None, 'If-Unmodified-Since': None, 'If-Match': None, 'If-None-Match': None, 'x-ms-version': '2017-04-17', 'User-Agent': 'Azure-Storage/0.37.0-0.36.0 (Python CPython 3.6.1; Linux 4.4.0-43-Microsoft) AZURECLI/2.0.20', 'x-ms-client-request-id': 'fd4b8d8e-da4f-11e7-a7b7-a434d9460bfd', 'x-ms-date': 'Wed, 06 Dec 2017 06:37:55 GMT', 'Authorization': 'SharedKey [REPLACED]'}.
urllib3.connectionpool : Starting new HTTPS connection (1): test02fast.blob.core.cloudapi.de
urllib3.connectionpool : https://test02fast.blob.core.cloudapi.de:443 "PUT /vhds/test02-db01-02.vhd?comp=lease HTTP/1.1" 409 219
azure.multiapi.storage.v2017_04_17.common.storageclient : Client-Request-ID=fdb89488-da4f-11e7-a7b7-a434d9460bfd Receiving Response: Server-Timestamp=Wed, 06 Dec 2017 06:37:55 GMT, Server-Request-ID=1f00da01-001c-0014-045c-6eb6ae000000, HTTP Status Code=409, Message=This blob is being used by the system., Headers={'x-ms-lease-id': None, 'x-ms-lease-action': 'break', 'x-ms-lease-duration': None, 'x-ms-lease-break-period': None, 'x-ms-proposed-lease-id': None, 'If-Modified-Since': None, 'If-Unmodified-Since': None, 'If-Match': None, 'If-None-Match': None, 'x-ms-version': '2017-04-17', 'User-Agent': 'Azure-Storage/0.37.0-0.36.0 (Python CPython 3.6.1; Linux 4.4.0-43-Microsoft) AZURECLI/2.0.20', 'x-ms-client-request-id': 'fd4b8d8e-da4f-11e7-a7b7-a434d9460bfd', 'x-ms-date': 'Wed, 06 Dec 2017 06:37:55 GMT', 'Authorization': 'SharedKey test02fast:[REPLACED]'}.
azure.multiapi.storage.v2017_04_17.common.storageclient : Client-Request-ID=fdb89488-da4f-11e7-a7b7-a434d9460bfd Operation failed: checking if the operation should be retried.

This blob is being used by the system.
Environment summary
Install Method (e.g. pip, interactive script, apt-get, Docker, MSI, edge build) / CLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)

Did this issue get resolved? I've encountered the same issue.

@seguler

@mirobers - is there a difference in behavior for premium vs standard ?

This is expected from the storage side. Premium disk leases can't be broken as long as the disk is in use. Detaching the disk should remove the lease.

Looks like breaking a lease on a premium VM page blob is not supported as long as the blob is attached to a VM,even if the VM is stopped and de-allocated. This is quite problematic since it means you have to completely delete and recreate the VM if you need to access its OS disk. Definitely not an optimal solution.
Any chance this restriction will be lifted in the future?
Reference:
https://docs.microsoft.com/en-us/rest/api/storageservices/lease-blob

I believe the VM keeps the lease on the disk even when deallocated, but will release it once detached. Could you try detaching?

Why is this issue closed? As said by @erosen03 this is an lack of usage! Please explain.

@dtissen, the correct workflow for removing the lease is to detach the disk. The issue as stated is by design because breaking the lease is the wrong way to go about this. If there is a problem in the detach workflow, we should reopen (and rename) this issue and involve the right folks from the compute side to check further. Could you state the issue you are hitting when attempting to detach that requires the VM to be deleted?

@mirobers , The reason detaching the disk doesn't work is because the only way to 'detach' an OS disk is to delete and recreate the VM. That's a really heavy-handed approach and caries a significant risk of configuration data loss.

reopening since there seems to be further discussion

@williexu Please also update the title to "OS disk can't be detached without deleting the VM" and remove the storage tag. Thanks!

@erosen03 have you tried this?: https://docs.microsoft.com/en-us/azure/virtual-machines/windows/detach-disk#detach-a-data-disk-using-the-portal
Seems like you should be able to detach the disk after stopping your vm

Thanks @williexu and @mirobers. I don't want to get off topic, but two other common scenarios that also currently require recreating a VM are:

Moving a VM to a different subnet or vnet
Adding a VM to or removing a VM from an availability or scale set

As were're looking at the 'recreate VM' requirement regarding an OS disk, it would be really nice if we come up with a solution that would also help the other two scenarios listed above.
Thanks.

@williexu, yes I have used that before, and it works fine or data disks. You can also attach / detach data disks using the Azure portal. However, that does not work for OS disks, and you can not attach / detach OS disks using the Azure portal either.

@williexu I'm applying Azure Storage Service Encryption (https://docs.microsoft.com/en-us/azure/storage/common/storage-service-encryption) for existing data. This requires that you copy the disk block out and back, which requires that the lease is broken.

Q: I would like to encrypt the current data in an existing Resource Manager storage account?
A: With SSE enabled by default for all storage accounts - Classic and Resource Manager storage accounts. However, data that were already present will not be encrypted. To encrypt existing data, you can copy them to another name or another container and then remove the unencrypted versions.

@erosen03 for your problem: Use az group export (with default values). this gives you the vm also settings. Delete the VM. Do whatever you want with the blobs and deploy the configuration back using the exported Template.
Using the Template you can "detach" the OS disk and use it again as OS disk. Thats my current approach to snapshot and restore a VM with blobs.
@erosen03 : Encryption: As said in your Q/A: you can copy the blob with another name, therefor you dont need to break lease. Copy somerwhere should always be possible. Of course, if you want to use the same names you have to get rid of the lease before.....
@williexu not to be able to detaching an OS Disk: Is this ab bug or feature? I thought it is a feature, also i dont know why to forbid....

@dtissen unfortunately it looks like exporting resource group templates is limited to resource groups with fewer than 200 resources, so that won't work for most of my environments.

-.- sorry for that, but good to know. Another approach could be: create the template on your own... not very complex. Export an existing one, modify it so it fits your requirement. Since a template can also use a parameter file you can make a template and just change the parameters....

@dtissen that's pretty much what we're doing now - using PowerShell to capture the VM configuration, delete the VM, perform whatever operations we need to do on the OS disk, and then recreate the VM using the captured configuration.
The issue with this approach is that you risk losing some VM configuration information if the config data is not captured completely, so it's really not a great solution, just the best one available at the moment.
The ideal solution is to not need to delete the VM in the first place, hence the need to break the lease.

@erosen03 Thats exactly the same i do! ;-) ans also the same reason.... yes deleting the vm is very ugly approach

@erosen03 after stopping a vm, you should be able to make a copy of your os disk blob. You can then perform operations on that blob, and then do a az vm update --set storageProfile.osDisk.vhd.uri=<copy url> to set the vm to the disk copy. Hope this helps.

@williexu, unfortunately my experience is that you can't perform file level operations on a blob like copying it or overwriting it while the blob is leased. Also, you can not set the OS disk on an existing VM. You can only do that on a new VM configuration.

@erosen03 Do the following steps (assuming your container name is vhds):

stop your vm
run az storage blob copy start --source-blob <source blob name> --source-container vhds -b <your desired copy name> -c vhds --account-name <storage account name>
get your copied blob url using az storage blob url -c vhds --account-name <> -n <blob copy name> or portal
run az vm update --set storageProfile.osDisk.vhd.uri=<copy url> -g <group name> -n <vm name>
az vm show should show you an updated os disk

I was able to run these steps with no problems.

Closing this as this is not a problem with the cli.
@erosen03 hopefully the steps I outlined above help with your scenario

@williexu I tried the steps using PowerShell and Azure storage explorer, and they worked. Thanks.
Only thing I'm wondering is how that procedure will affect things when you're using blob snapshots. I.e., since we're getting a completely new blob, none of the snapshots from the previous blob will be available, unless you keep the old blob around and track somewhere that it contains the older snapshots for the OS disk.  Regardless, that's manageable and a lot better  than deleting and recreating the VM.
But it would really make things a lot easier if breaking blob leases worked in premium storage the way it works in standard storage  :)
Thanks again.


Review or create SEO text for main landing pages in docs

Is your feature request related to a problem? Please describe.
It would help users to find the information they need via search engine if we better metadata-described some of our pages.
Describe the solution you'd like
Review and edit as appropriate the SEO tags for our main landing/topic pages in docs/:

[ ] index.mdx
[ ] api-standards.md
[ ] api-docs.md
[ ] file-management.md
[ ] rules.md
[ ] decorators.md

Describe alternatives you've considered
Do nothing. But I think the updates would be worth doing.

We agreed not to prioritise SEO for docs yet.


Adding flavour to Leader profile block

Content guidelines:

Make sure Author crops images to square to prevent the image getting pinched in the flyout
Text should not be longer than one line - should be restricted in content guidelines
Download button will truncate with ellipsis if longer than allotted space

AC:

Create a Block option for the existing block ( Leader Profiles) so it displays 2 columns and uses the full width of the main grid
Text under the image should be in black size 26px
Block should have the option to have the under image text convert to a button
Able to add an ordered list
Add the option to add a button in the flyout (Block 5 - 8 Images mosaic with title tag*)
The whole block (image and text) is clickable and opens the flyout

Specs:
Block 1- Leader Profiles new Block option
https://projects.netcentric.biz/wiki/pages/viewpage.action?pageId=430092249
Example:

@sonaldhekale if I get this ticket correctly the 2 column layout should be just an option and not all instances of this block should have that layout, please align with @DaphneKoren if https://326-flavour-to-leader-profile--cn-website--netcentric.hlx.page/who-we-are is really what is needed.

@sonaldhekale Yes, @nc-andreashaller is correct this should be a as a flavour to allow both the old design and this design according to the author's decision

Did you specify how the author selects the design?

I updated the ticket and specs with the correct terminology

Thanks! @sonaldhekale the "flavour" should be done by a so called "Block Option" which refers to the additional CSS class after the block name in parenthesis.

All things are clear now i did the the changes. PR is created it required review to move to testing.Thanks


Support Python 3.11

🚀 Pull Request
Description

Python 3.11 has been out for nearly 6 months now so I think we should officially support for the upcoming release.
I note @trexfeathers' comment at https://github.com/SciTools/iris/pull/5211#issuecomment-1484725649, so appreciate you won't want to merge this immediately. :eyes:

Consult Iris pull request check list

Wow I managed to break all the tests.  Seems I need some help!
I can report that the main tests, gallery tests all passed locally under 3.11.

It's amazing the variety of errors you can generate by just not making sure your branch is up-to-date with upstream 🤦♀
The doctest and linkcheck fails are probably due to #5232, though I can't see the specific errors in the logs.  I am somewhat suspicious that readthedocs passed.

I am somewhat suspicious that readthedocs passed.

It passed, but the rendered docs are not showing the calling sequence for e.g. cube instantiation.  So I guess the failure is there but RTD is not registering the non-zero exit code?

Behold my full set of green ticks ✅😎

@rcomer I'd say that a whatsnew entry is defo also needed :100:


Multiple configurable save locations depending on file's mime type

Is your feature request related to a problem? Please describe.
I like my files nice and organized. Video files go to ~/Videos, documents go to ~/Documents, etc. However, LocalSend only ever saves in a specific directory, which forces me to re-organize all the received files by their type.
Describe the solution you'd like
Check file's mime type, and depending on what type of file it is, put it in the appropriate folder specific to user's OS. If the file is of unknown type, fallback to Downloads.
There should then also be appropriate folder picker buttons in the UI in case the user wants to save, say, video files somewhere else on his system.
It's also best to guard this feature behind an option named something like Smart Saving, so the user can choose if they need that feature at all.
Describe alternatives you've considered
Having a separate program watch the filesystem and act appropriately, but it's complicated and not very portable (think iOS or Android).
Additional context
No response

As I use LocalSend to easily transfer files from phones/tablets/computers to my Kodi media players, this would be an absolute game changer.
Maybe have the sending app query the receiving app as to what folders have been made available for quicksave, that way we are able to choose the destination folder when sending.
Example: Videos/TV Shows/Movies are all videos, so I don't want all videos ending up in Videos folder, I would send movies to the Movies folder, shows to TV Shows, etc.


Cfncluster will submit to nodes that are being scaled down.

Leading to jobs that are orphaned in the middle of running.
Relevant qstat -f output
<EMAIL_ADDRESS>BIP   0/2/1          -NA-     lx-amd64      auo
    704 0.50617 cromwell_8 ec2-user     r     07/25/2017 17:54:44     1
    705 0.50617 cromwell_8 ec2-user     r     07/25/2017 17:54:44     1

Can you verify nodes are removed from sge host-lists when nodes scaled down ?

This should be fixed by https://github.com/awslabs/cfncluster-node/pull/6

https://github.com/awslabs/cfncluster-node/pull/6 was released in 1.3.2 (Jun 23) not sure the PR fixes this issue? @awacs are you seeing this issue in 1.3.2 ?
We can't proceed without your input. I am marking this issue closing soon if no response. Happy to help if @awacs comes back.


Custom filter

This is the third function-related issue/feature request I've made now :P
According to this comment by the author of Tabulator, a predicate function can be used to filter data like so:
//define custom filter
function customFilter(data){
    //data - the data for the row being filtered
    // returns a boolean
}
// (...)
$("#example-table").tabulator("setFilter", customFilter);

However, I cannot get this to work (and I suspect the same tricks you used for #1 and #2 will be needed here)
My current code (using a factory to make a filter; I tried using multiple filters but date filtering didn't seem to work properly):
        self.tabulator.set_filter(self.make_filter())

    def make_filter(self):
        def filter(data):
            name_filter = self.search_name.text or ''
            date_filter = self.search_expires.date
            return name_filter in data['name'] and ((not date_filter) or data['expires'] < date_filter)
        return filter

Current behaviour:
Filter Error - No such filter type found, ignoring: null

E.findFilter @ tabulator.min.js:8
(anonymous) @ tabulator.min.js:8
E.addFilter @ tabulator.min.js:8
E.setFilter @ tabulator.min.js:8
u.setFilter @ tabulator.min.js:5
set_filter @ (index):1281
(anonymous) @ PyDefUtils.js:1570
f @ rsvp.es.js:320
w @ rsvp.es.js:492
(anonymous) @ rsvp.es.js:556
ce @ rsvp.es.js:2432
characterData (async)
(anonymous) @ rsvp.es.js:2409
le @ rsvp.es.js:2366
x @ rsvp.es.js:555
e.finally @ rsvp.es.js:1106
(anonymous) @ DatePicker.js:159
dispatch @ jquery.min.js?buildTime=1598345055:2
v.handle @ jquery.min.js?buildTime=1598345055:2
trigger @ jquery.min.js?buildTime=1598345055:2
(anonymous) @ jquery.min.js?buildTime=1598345055:2
each @ jquery.min.js?buildTime=1598345055:2
each @ jquery.min.js?buildTime=1598345055:2
trigger @ jquery.min.js?buildTime=1598345055:2
clickApply @ daterangepicker.js?buildTime=1598345055:1407
clickDate @ daterangepicker.js?buildTime=1598345055:1363
i @ jquery.min.js?buildTime=1598345055:2
dispatch @ jquery.min.js?buildTime=1598345055:2
v.handle @ jquery.min.js?buildTime=1598345055:2

Yeah. Anytime you send a python function to JavaScript there’s not natural
way to convert it so you have to check it’s type and then use some skulpt
architecture to covert it.
Won’t be able to do this till next week.
On Wed, 2 Sep 2020 at 02:04, Starwort<EMAIL_ADDRESS>wrote:

This is the third function-related issue/feature request I've made now :P
According to this comment by the author of Tabulator
https://github.com/olifolkerd/tabulator/issues/185#issuecomment-281516289,
a predicate function can be used to filter data like so:
//define custom filter
function customFilter(data){
//data - the data for the row being filtered

// returns a boolean

}
// (...)
$("#example-table").tabulator("setFilter", customFilter);
However, I cannot get this to work (and I suspect the same tricks you used
for #1 https://github.com/s-cork/Tabulator/issues/1 and #2
https://github.com/s-cork/Tabulator/issues/2 will be needed here)
My current code (using a factory to make a filter; I tried using multiple
filters but date filtering didn't seem to work properly):
    self.tabulator.set_filter(self.make_filter())

def make_filter(self):

    def filter(data):

        name_filter = self.search_name.text or ''

        date_filter = self.search_expires.date

        return name_filter in data['name'] and ((not date_filter) or data['expires'] < date_filter)

    return filter

Current behaviour:
Filter Error - No such filter type found, ignoring: null
E.findFilter @ tabulator.min.js:8
(anonymous) @ tabulator.min.js:8
E.addFilter @ tabulator.min.js:8
E.setFilter @ tabulator.min.js:8
u.setFilter @ tabulator.min.js:5
set_filter @ (index):1281
(anonymous) @ PyDefUtils.js:1570
f @ rsvp.es.js:320
w @ rsvp.es.js:492
(anonymous) @ rsvp.es.js:556
ce @ rsvp.es.js:2432
characterData (async)
(anonymous) @ rsvp.es.js:2409
le @ rsvp.es.js:2366
x @ rsvp.es.js:555
e.finally @ rsvp.es.js:1106
(anonymous) @ DatePicker.js:159
dispatch @ jquery.min.js?buildTime=1598345055:2
v.handle @ jquery.min.js?buildTime=1598345055:2
trigger @ jquery.min.js?buildTime=1598345055:2
(anonymous) @ jquery.min.js?buildTime=1598345055:2
each @ jquery.min.js?buildTime=1598345055:2
each @ jquery.min.js?buildTime=1598345055:2
trigger @ jquery.min.js?buildTime=1598345055:2
clickApply @ daterangepicker.js?buildTime=1598345055:1407
clickDate @ daterangepicker.js?buildTime=1598345055:1363
i @ jquery.min.js?buildTime=1598345055:2
dispatch @ jquery.min.js?buildTime=1598345055:2
v.handle @ jquery.min.js?buildTime=1598345055:2
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/s-cork/Tabulator/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIY3YQXMN554PMJGMWC2RDDSDUZSVANCNFSM4QSALB2Q
.

Yeah. Anytime you send a python function to JavaScript there’s not natural way to convert it so you have to check it's type and then use some skulpt architecture to covert it.

Oof, that sounds painful; at least it should be easier with repetition, right :P
In all seriousness, thanks for putting up with this and hopefully it makes the experience better for everyone else too :)

Won’t be able to do this till next week.

Totally fair, it's not super urgent anyway - Have a nice week!

done with commit 3e872ab4b3e


Seeing 'tcp.Mux: handler not registered' messages in 0.9.2rc1

Running influx-0.9.2rc1 in a 3-node cluster, and seeing these messages on one of the nodes:
...
2015/07/22 18:53:26 tcp.Mux: handler not registered: 71
2015/07/22 18:53:26 tcp.Mux: handler not registered: 71
2015/07/22 18:53:26 tcp.Mux: handler not registered: 71
2015/07/22 18:53:26 tcp.Mux: handler not registered: 71
2015/07/22 18:53:26 tcp.Mux: handler not registered: 71
...

I've restarted influx, but the messages persist. Can someone explain what might be going on?

Are you connecting to the correct ports for writing/querying?  That message can be logged if you try to query or write to the cluster port (default 8088) and not the API port (default 8086).

I just re-built the cluster; will monitor to see if this recurs.

Please re-open if you see it again.


Use "TI Group" and "TI Member" instead of "TI"

The phrase "trusted intermediary" is ambiguous -- it could refer to a CBO or to an individual staffer at a CBO. Instead, we can use "TI Group" to represent a CBO (an organization with many members who help clients), and then "TI Member" to represent a staff member or employee of a TI Group (these people work with clients directly).

According to both Seattle and AR, TI is an unfamiliar term. Seattle suggested "community based organizations" instead. Suggest we do some lightweight UXR to confirm the best language


Disabling remote upload local results when generating an arbitrary deployable jar

Hey,
I would like to suggest about adding the --remote_upload_local_results=false as a permanent flag to GenerateDeployableJarTaskProvider.java.
Uploading local arbitrary main jar content is time consuming, pollutes the remote cache and usually redundant.
It'll be great to get some inputs about the topic, think it's a useful feature that might save time for everyone involved.
It's already implemented internally here at Wix and we can see a lot of value from it which we would like to share with the rest of the Scala community.
Thanks

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.


Support ARGB

You could support hexadecimal alpha also (often used for Android so for cross-compatible palettes support would be useful). I wrote this a while back which shows a way to use just one NSScanner to get all four values in one go:
https://gist.github.com/blixt/821a0748257dc8d3581f

Sounds great. Want to submit a PR?
I'm using React Native right now and have no need to maintain this library. :smile:


I add jokes to jokes.json

Adding three more jokes to jokes.json update jokes.json!!
Short description of what this resolves:
I want to add jokes to jokes.json!
Jokes are
"What kind of witch lives on the beach?\n A sandwich"
"What do you call a fish without an eye?\n fsh"
"Why doctors are angry?\n Because they have no patience" ...
Changes proposed in this pull request:

Fixes: #

Thank you for taking the time to contribute! This is sincerely appreciated. 😇
(Powered by GitMate.io)

Can you close my pull-request and merge it in the jokes.json file?


office web site doc description is error

link：https://github.com/apache/dubbo/issues/5095

I'll fix it.


Fixed XSS vulnerability for front-end

I'll merge it and we can separate them to their own function in the future if we'll need to.


jcider slider is support for apps for swipe.

Is jcider slider supports for apps for swipe.

jCider can only be used as a jQuery plugin.
closes #1


Simple Attachments on Skype Channel

My bot attaches some messages to its activities before replying to a user. Right now, I have them all as the simple Media Attachment example with the ContentType, ContentUrl, and Name fields populated.
I have the bot exposed on Direct Line and some information about those attachments comes through on that channel. However, I have added my bot to the Skype channel and I don't see the attachments come through on that channel.
I am using the v3 version of the Bot Framework with the .NET Bot Builder. I am testing this on Skype Web with the developer options enabled.

ContentUrl should be either https for skype or a valid base64 encoded data url

Awesome, thanks!

@msft-shahins I might need to open a different issue, but it looks like there is a bug with the Skype channel if the base64 encoded data URL is above a certain length.

if I send the same image to Slack it works fine
if I send a smaller image to Skype it works

I am getting errors like this:
Error: Request to 'https://skype.botframework.com/v3/conversations/xyz/activities' failed: [500] Internal Server Error

@thingista feel free to open a separate issue about this.

What is the size limit for attachments using base64 encoded data url, because I am sending a 254kb file as attachment (base64 encoded) it always gives error : 400 bad request, but the same works fine in case of 25-30 KB files.


azure file on k8s doc issue

Creating an issue
There are two issues about the below doc:
https://docs.microsoft.com/en-us/azure/aks/azure-files-dynamic-pv

create storage account in the beginning is little hard to use for customers, we could let k8s create storage account directly by not specifying storageAccount field, e.g.

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
 name: azurefile
provisioner: kubernetes.io/azure-file
parameters:
 skuName: Standard_LRS

By above config, k8s will create or search a storage account in the same resource group as k8s cluster for users.

add comments for skuName type
available values: Standard_LRS, Standard_GRS, Standard_RAGRS, (and Premium_LRS are supported from k8s v1.13.0)

@neilpeterson
cc @sriramkomma

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a57e48b4-dc33-0b9d-b773-42ce7d2bffd0
Version Independent ID: e912ac2d-cf6a-0b54-4697-1940b1270874
Content: Dynamically create a Files volume for multiple pods in Azure Kubernetes Service (AKS)
Content Source: articles/aks/azure-files-dynamic-pv.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

@andyzhangx Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.


grid capacity: create algorithm to compute percentage of uptime over a month

Issue migrated from https://api.github.com/repos/Jumpscale/lib9/issues/298, opened by @zaibon
The capacity database should be able to give the percentage of uptime of a node over a month.
Proposal:

tX: time of update of the uptime
actual_uptime: uptime received from the 0-OS node

then we can compute the percentage of uptime like:
expected_uptime = tX - tX-1 #amount of second between 2 uptime update
if actual_uptime < expected_uptime:
   uptime += expected_uptime - actual_uptime
elif actual_uptime > expected_uptime
    uptime += expected_uptime # this is a strange case, not sure this could happens, except if the node tries to fake is uptime
else:
   uptime += actual_uptime

# then at the end of the month
percentage = uptime / (number_of_second_in_this_month)

commented by @zaibon
This actually won't work, cause this will only check if the node is up, not if it is actually reachable over the network. So we need an external monitoring tool that check that the node is up and reachable

commented by @muhamadazmy
@zaibon I think what we need is more of a heartbeat. Not sure though how this should be done for millions of machines without a centralized monitor.

*commented by @muhamadazmy
Suggestion 1

All node connects to well known and defined (may be even public) monitoring zerotier network. No node access is possible over this network
Nodes send heartbeats up stream.
Heartbeats are aggregated by a (yet to be defined) node in the same logical location of a set of nodes
This monitor node (may be it's elected somehow to take the honor of aggregating the heartbeats) should calculate the uptime of nearby nodes and move it up the tree. until it reaches infra structure nodes (threefold backbone if I may call it)
The uptime won't be real time

This suggestion defined new terms that are not really part of the system at the moment as u can see, which we can discuss further. This includes the (threefold backbone, or infra structure nodes) and the local monitoring node(s) for a region.
*

*commented by @zaibon
I like this idea. I don't think we need to do the aggregation per location just yet. The grid is small enough for all the node to send their own heartbeat to the "monitor node'
@muhamadazmy can you elaborate on how you would design the heartbeat and the monitoring node please*

*commented by @muhamadazmy
If we won't need aggregation per location just yet, we can actually use the same capacity registration endpoint we have now https://capacity.threefoldtoken.com
My idea is as follows:

capacity registration should happen more frequently (may be 5min updates) not 2 hours
on capacity registration, an influx series should be updated which should include farmer id and node id (or similar identification for the node (mac, ip, zt id, etc)
Once the data is in influxdb, we can actually aggregate (and plot the following metrics)

Total farmer capacity (now) and graph capacity change over time
Total registered grid capacity (now) and graph grid capacity changes

Me and @zaibon  did not agree if we should a push or pull mechanism to collect the capacity heartbeat though.
A more serious problem with either approaches is the trusting the reported capacity. Since the protocol is open anyone can start registering a fake capacity. We can of course ignore this issue for later but may be it's a good idea if we at least figure out a plan so is considered before designing the capacity reporting/heartbeats.
*

*commented by @zaibon
let's stick with the push approach, we have already all the infrastructure in place to do this
ok so if we do that path, here are the task that I can already see we'll have to do:

[x] make the registration of the capacity happens more often (https://github.com/zero-os/0-templates/commit/141cdb4489762fcf492b25ac76ebe1207e6e24ae#diff-f480ff2159beef48225b4e750fcb9e00R23)
[x] update capacity website so it write data into influxdb when capacity is registered/updated
[ ] write code that compute/plot of the farmer capacity, node uptime etc...
[ ] update the capacity webstire UI to show the farm capacity graphs*

*commented by @andhartl
Just look at my farm Maisaval 2: It has the correct geo ip on the node view but no location on the farmer view. There should be the same location on the farmer view. And if it is the wrong one you can correct it on the farmer view manually.

On 21. Jul 2018, at 06:12, Christophe de Carvalho<EMAIL_ADDRESS>wrote:
Well if it's not show in the farmer page, that means that the farm has no location set.
The node are automatically located using geo-ip. But the farmer can overwrite that location if needed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/Jumpscale/lib9/issues/298#issuecomment-406769120, or mute the thread https://github.com/notifications/unsubscribe-auth/ARutKLFN1HQfLGNVk7OhT0qwDodV4BlGks5uIqpHgaJpZM4UTQsa.

think we are making this too complex, for now measuring local is ok !
just uptime measured when the node is up, independent of connection to internet, we can fix that one later


Add support to pull from GitHub Sponsors metadata

:heart:

What would implementing this look like for Back Your Stack?

Considerations when developing this feature:
FUNDING.yml can be located in a .github/ directory within a repository, or in the root of a repository named .github owned by an individual or an organization, and sometimes you can find both.
Currently, as far as I know, there's no information in the API to indicate if a repo or individual is sponsored or not, so you end up having to test every repo. I've found it easiest to just ask the API for the file, but it's inefficient (my hit rate is ~ 4%).
It might be worth having a conversation with GitHub about surfacing Sponsorship information in the API, returning has_funding and funding_url along with the rest of the repo information.
https://api.github.com/repos/chalk/chalk


Make CMake work on version 3.22

I tested this on Ubuntu-22.04.
This change makes it build with CMake 3.22 which is the latest version on ubuntu-22.04.
benney@DESKTOP-DQNT22A:~/s/fastplong$ cmake --version
cmake version 3.22.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).
benney@DESKTOP-DQNT22A:~/s/fastplong$ cmak^C
benney@DESKTOP-DQNT22A:~/s/fastplong$ make
cmake --build --preset ninja-vcpkg-release
ninja: no work to do.

seems it requires cmake v3.30.1 to install vcpkg
shifu@ShifudeMacBook-Pro fastplong % make
/opt/homebrew/bin/cmake --preset "ninja-multi-vcpkg"
Preset CMake variables:

  CMAKE_TOOLCHAIN_FILE:FILEPATH="/Users/shifu/fastplong/vcpkg/scripts/buildsystems/vcpkg.cmake"

-- Running vcpkg install
A suitable version of cmake was not found (required v3.30.1).
Downloading cmake-3.30.1-macos-universal.tar.gz

I am getting crazy about the cmake + vcpkg + ninja, since I have bad network access to GitHub. And this will also impact the autobump in anaconda.
So I am considering to drop cmake + vcpkg + ninja, and revert the code to use a pure Makefile, or a simpler cmake with much lower requirement.
I totally agree with you to use simd for performance boost, but we can just simply introduce highway, or probably xsimd, which is also available in conda.

seems it requires cmake v3.30.1 to install vcpkg
shifu@ShifudeMacBook-Pro fastplong % make
/opt/homebrew/bin/cmake --preset "ninja-multi-vcpkg"
Preset CMake variables:

  CMAKE_TOOLCHAIN_FILE:FILEPATH="/Users/shifu/fastplong/vcpkg/scripts/buildsystems/vcpkg.cmake"

-- Running vcpkg install
A suitable version of cmake was not found (required v3.30.1).
Downloading cmake-3.30.1-macos-universal.tar.gz

I am getting crazy about the cmake + vcpkg + ninja, since I have bad network access to GitHub. And this will also impact the autobump in anaconda.
So I am considering to drop cmake + vcpkg + ninja, and revert the code to use a pure Makefile, or a simpler cmake with much lower requirement.
I totally agree with you to use simd for performance boost, but we can just simply introduce highway, or probably xsimd, which is also available in conda.

I understand your internet may be unreliable from China using a VPN.
It seems like the main problem is vcpkg downloads some extra stuff.

vcpkg downloads cmake v3.30.1 since it doesn't know which dependency you are downloading so it gets the latest. This should only be about ~20 MB compressed.
ninja is less than 1 MB so I don't think that should be causing too many issues.

vcpkg should only be downloading these dependencies once and will download them to ~/.cache/vcpkg/archives.
I had a look at the packages provided by conda it might be worth investigating. I noticed some of the packages are a little behind the latest version on github though.
I'm not sure how switching to conda will solve your issue though.
Is it because Github requires VPN in China but conda-forge doesn't?

Yes, we should use vpn to access GitHub, but we can freely access to conda.

I have tested libhwy in conda is working, and I've decided to rollback to c4f2d60665f12ca0737873228a93fd2541d7935f

I have tested libhwy in conda is working, and I've decided to rollback to c4f2d60
We can then focus on the SIMD acceleration, not the compilation

Okay if that's the case, then we can remove vcpkg as a dependency and install cmake, and highway from conda.

I've reverted the code, and recommended Anaconda.
And libhwy is working with current setup.
Let's keep it simple, and use libhwy to speed it up.


you can safely mangle now, see TinyColor/pull/79

You can safely mangle variable names now without breaking IE8, for an even smaller minified build.
See https://github.com/bgrins/TinyColor/pull/79
which links to
https://github.com/hammerjs/jquery.hammer.js/issues/20
If I may also suggest pulling TinyColor out of the source and making it a versioned-requirement instead.

Sure, I went ahead and bumped TinyColor to 1.1.2 with the change and pulled that into spectrum.js: https://github.com/bgrins/spectrum/commit/4efcb861a3fe5d2a954e3f4afad46a66d0295d07.
So, could you remove the change to spectrum from this PR and include just the gruntfile change?

done

Thanks


PointCloud2 Display: Cannot manually set min/max intensity

After upgrading from ROS melodic to noetic I cannot set the min/max intensity values anymore in a PointCloud2 display, when I untick "Autocompute Intensity Bounds".  (see highlighted field in rviz screenshot).

Even manually editing the min/max values in the .rviz file does not work, when I change the bounds there they will be loaded as [0, 4096].
when I tick and untick "Autocompute Intensity Bounds" (min/max values will update to some values) and then save the rviz config, the bounds in the rviz file don't change their value.

How to reproduce:

subscribe to any pointcloud2 topic
set "Color Transformer" to "intensity"
Untick "Autocompute Intensity bounds"
try to set min or max intensity value  --> does not work
save your rviz config and see if the min/max values corresponds to what it currently says in RVIZ
change the values in the .rviz file and reload the config --> see min/max values change to [0,4096]

Describe your issue here and explain how to reproduce it.
Your environment

OS Version: Ubuntu 20.04
ROS Distro: Noetic
RViz, Qt, OGRE, OpenGl version as printed by rviz:

[ INFO] [1619766592.458320745][${node}][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/visualizer_app.cpp:114]: rviz version 1.14.5
[ INFO] [1619766592.458375693][${node}][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/visualizer_app.cpp:115]: compiled against Qt version 5.12.8
[ INFO] [1619766592.458391012][${node}][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/visualizer_app.cpp:116]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1619766603.100651819][/rviz_1619766592458490660][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/ogre_helpers/render_system.cpp:84]: Forcing OpenGl version 0.
[ INFO] [1619766606.351965812][/rviz_1619766592458490660][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/ogre_helpers/render_system.cpp:466]: Stereo is NOT SUPPORTED
[ INFO] [1619766606.352046530][/rviz_1619766592458490660][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/ogre_helpers/render_system.cpp:181]: OpenGL device: GeForce GTX 1070/PCIe/SSE2
[ INFO] [1619766606.352102245][/rviz_1619766592458490660][/tmp/binarydeb/ros-noetic-rviz-1.14.5/src/rviz/ogre_helpers/render_system.cpp:227]: OpenGl version: 4,6 (GLSL 4,6).

Should be fixed in release 1.14.7 which is not yet synced. Try the ros-testing repos?

Should be fixed in release 1.14.7 which is not yet synced. Try the ros-testing repos?

oh nice, I will try it out, thank you!

that fixed it! thanks a lot @rhaschke .


Added a name to AudioKit Engine's built-in Mixer node

Added a name to AudioKit Engine's built-in Mixer node. This makes it look much better in the connection tree, and it's nice to have a name for it anyway. Updated the unit tests to match.

Cool.


Error: fetch failed

I am running the action in a github self hosted runner which inside a firewall. It has a proxy ip to access outside sites. I get the error "Error: fetch failed" when running the action. I suspect it occurs here: https://github.com/mgrybyk-org/allure-report-branch-js-action/blob/f36b8d8d5acd0a4e67b4eb7368da173d26f81e5e/src/allure.ts#L55
I added the proxy at the step level as well as the global level and both didn't work. Is it possible to make the downloadUrl configurable to use a local maven repo? Or am I overlooking something? Please help.

name: Allure Report Action
env:
HTTPS_PROXY:
uses<EMAIL_ADDRESS>if: always()
continue-on-error: true
id: allure # used in comment to PR
with:
report_id: 'allure-report'
gh_pages: 'gh-pages-dir'
report_dir: 'target/allure-results'

I checked my proxy in the runner again today and it works fine. I am able to connect to https://repo.maven.apache.org/maven2/io/qameta/allure/ from the runner.
So now I am not sure what the error is for because there is no further information apart from
Error: fetch failed

It might be the case that proxy is not applied correctly.
We can definitely add an option to override download url.


Back button does not appear when navigating to nested view

When navigating to a page with tabs, the header does not display the back button.
Mentioned this on the forum at:
http://forum.ionicframework.com/t/ui-router-question-related-to-tabs/555/3
Also on StackOverflow at:
http://stackoverflow.com/questions/21218419/trouble-understanding-ui-router-and-nested-views
I've set up this Plunkr to demonstrate the behavior:
http://plnkr.co/edit/jKII2S3uEnEOVDy9WBA2

+1

+1

+1

This is basically the same problem as https://github.com/driftyco/ionic/issues/2997

+1

+1

+1

+1

@ajoslin if you transition from "STATE1"to "STATE_WITH_TABS" ,it should have 'navigation' and in his tabs the back button should go back to "STATE1".

It seems a bad idea to use tabs in ionic framework.

+1

+1, no back button when entering tabs.

:+1:

+1

+10000000000

+1 !!

why there is no perfect solution for this? even i add the back button by myself, but how can I add the back transition to the button? it is just normal history go back.
i am sure a lot of people have so much confuse on here. They all like me cost few days to found a perfect solution.
plz help us!

I resolved this by adding an additional state to the route where I was coming from. I had dashboard > friend detail page (no back button), but then I added friend detail state to my tab.dash, and voila, a back button appeared. My resolution to this mentally, is that a nested route must be duplicated and nested into the new base route you with to come from. In my case, I wanted the dashboard to be able to route to a user friend profile page (bypassing the friends list), so I duplicated the friend detail state to my tab.dash, made the route /dash/friend/:friendId, and everything works.
So my message to everyone is, fiddle with your route definition code, and help the app understand how you want routing to go back and forth. You can utilize the same templates, but you'll need to create new routes to resolve some of you back button issues. Hope this helps. See my code (edited) below:

app.config(function($stateProvider, $urlRouterProvider, $ionicConfigProvider) {

  $stateProvider

  .state('tab', {
    url:          "/tab",
    abstract:     true,
    templateUrl:  "templates/tabs.html"
  })

  .state('tab.dash', {
    url: '/dash',
    cache: false,
    views: {
      'tab-dash': {
        templateUrl: 'templates/pulse/index.html',
        controller: 'DashCtrl'
      }
    }
  })
    .state('tab.dash-friend-detail', {
      url: '/dash/friend/:friendId',
      cache: false,
      views: {
        'tab-dash': {
          templateUrl: 'templates/friends/detail.html',
          controller: 'FriendDetailCtrl'
        }
      }
    })

  .state('tab.friends', {
      url: '/friends',
      views: {
        'tab-friends': {
          templateUrl: 'templates/friends/index.html',
          controller: 'FriendsCtrl'
        }
      }
    })
    .state('tab.friend-detail', {
      url: '/friend/:friendId',
      cache: false,
      views: {
        'tab-friends': {
          templateUrl: 'templates/friends/detail.html',
          controller: 'FriendDetailCtrl'
        }
      }
    });

});

@argyleink I think your case doesn't cover the problem that is actually discussed here. You're states are already well defined children of a parent tab view, so that means ionic will nicely handle this within an own navigation history stack.
The problem occurs if you switch between tabbed and non-tabbed view states that relate to each other and explicitly should track an own history without switching history contexts ("stacks"). Background: ionic assumes that different tabs mean different navigation contexts what is often undoubtedly the preferred behavior if you present some kind of "main menu entry points" as a button tab bar - that way, you can switch between tabs and restore the last inner state/view that the user opened.
But in reality tabs may be used in different ways, e.g. for structuring some sub-view to have easy pre-filtered access to the presented content.
In my eyes this problem still remains unsolved. And it's kinda serious: How to solve this differently? Building an own tab logic with just using buttons?
I guess there should be a way to easily hook into the view transition before entering the affected tab view  and do some kind of $ionicHistory.suppressNewHistoryStack() or even better: Have some attribute that can be set alongside ui-sref like ionic-history-keepstack="true" or whatsoever.

I'm having the same problem. I have a tabbed view and when I use the side menu to go to a non-tabbed view it does not show the back button.

@atufkas  I think that I have the same issue, lets say I have two tabs:

profile tab
item list tab

and three views,

profile view (on profile tab)
item list view (on list tab)
item detail view (on list tab)

From the item list if I click on an item I am taken to the item details view this all works fine as it is all contained in the same item tab and the back button works.
Now if I favourite an item that item then shows up in my profile tab and I would like to be able to click on the item from the profile tab and be taken to the item details view but currently if you click on an item that is on the profile tab you are taken to the item details view but you are moved to the item tab and hence you are unable to get back to the profile tab as no back button is displayed.
Is this the issue that we are describing here?
If so I would also love to be able to override the back button behaviour from the profile tab.
Thanks.

I have the exact same problem I love ionic but that is a real weakness that you have no backbutton when you come from a non-tabbed view to a tabbed-view. Im an android user and so i also will never understand the back navigation when calling different tabs. switching between tabs should never build a back stack at least in my opinion.
Please give us a back button for tabs view!

+1
Just hit this issue. Seems like a serious limitation. Request Ionic to prioritize this.

+1. Please fix this. It is a very real life use case.

+1. I am wondering why the Ionic team is simply ignoring this.  Its a very serious problem that requires hacks to get around which further destabilizes and app down the road.  Is there any way to contact them directly? Should be  a simple fix for such a serious bug.

We're not ignoring this, we are well aware of the current limitations.
It is not a simple fix, because now we're dealing with abstract states and nested navigations.
If you're on view1 and you got to tab1-view1, should a back button be displayed?
Currently it won't since we're assuming tabs will have their own navigations stacks.
tab1-view1 is technically the start of that nested views navigation stack, so there shouldn't be back button.
This is why we're working hard on V2 of ionic. Thins like this will be addressed.

@mhartington
That's maybe true but than i would have one question: Why do you want tabs to have their own navigation stack? For me (android developer) that simply makes no sense to have a back functionality withint tabs. If you still want that feature to exists you will need another tabs view. One with own navigation stack and one without.

@Montrazul that's how tabs work in iOS, isn't it?

I dont know if it works like that on iOS. I only know about android. But it would still be unlogical because why should you implement a immitation of behaviour for iOS but not for Android since there are a huge amount of Android Devices more than iOS devices.

This is how tabs work in iOS, but it's less about an iOS/Android imitation. It's a good UI to have to allow for nested navigations stacks. Again, this is not the place for this, please use the forum.

I would if i would be allowed to post on the forum. I registered but i cant find any functionallity to post a thread ;)

Whats your user name on the forum?

Same like here.

can you email me, mike at ionic dot io, your user name isn't coming up on the forum.

IMHO the back button not being shown is the least of the problems here. The real problem is not having a transition between those views.

I'm in a tabbed view.
Click on a item in a list inside that tab
Goes to the detail view which has no tabs (to achieve this I gotta put this view on the tabs parent state and then I lose the transition between a parent-detail view relationship)

This is a very simple use case. Just look at Android's WhatsApp, Telegram, etc...
The back button you can solve using your own button and ui-sref forcing the back state. Not the ideal solution I know, but it solves the problem. But what about the transition?
I love Ionic, but no solution for this for over a year... we're building hybrids apps that definitely doesn't look native (transition is the key for this gap IMHO) =/

Again, we know about this issue. As we've stated before, it's a very tricky issue. This is something we are very serious about fixing and making more flexible in 2.0.

Hey guys, please refrain from commenting on this issue as Im sure the Ionic team is tired of responding to it.  They mentioned previously there is an ionic forum to discuss this.
I did have one question Mike.  Is there a time frame for Ionic 2.0 release or a beta version we can test out or possibly a website link where we can find out more info? Not really in regards to this issue just a general question.

I would be interested in this (solution / time frame) too!
We have the problem that we open a detail object with tabs where no back button is available so I created an own close / back button by overwriting the inoicHistory.backView with the object's previous view on each object's tab and then going back (ionigHistory.goBack() to that view) when closing the object's detail.
Unfortunately, sometimes the back button is just not visible anymore at some places of the navigation stack despite navigation stack/history is still available.


Work around uninitiialized value in current protobuf library.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3a99c81) 92.91% compared to head (393e283) 92.91%.

:exclamation: Current head 393e283 differs from pull request most recent head 6f70527. Consider uploading reports for the commit 6f70527 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   92.91%   92.91%
=======================================
  Files         358      358
  Lines       26571    26571
=======================================
  Hits        24688    24688
  Misses       1883     1883

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[2.1] Cloned cpp boilerplate for the skeleton of our software. Update…

…d thereadme with contributor names and system overview diagram

Let's add the sprint plan and role assignment details in the readme

Let's add the sprint plan and role assignment details in the readme in the second commit.


Construct step function pipeline

Background
Link to issue
https://biomage.atlassian.net/browse/BIOMAGE-506
Link to staging deployment URL
N.A.
Links to any Pull Requests related to this
https://github.com/biomage-ltd/iac/pull/41
Anything else the reviewers should know about the changes here

Modified skeleton to fit the current data processing configuration

Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[ ] Tested locally with Inframock
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

What did you do to test that this works?

What did you do to test that this works?

Tested locally. Added test to check for the result of merging the config from DynamoDB.

Btw, with the current implementation, even though users have just finished 1 step, all the steps will be run. Is this expected?

Btw, with the current implementation, even though users have just finished 1 step, all the steps will be run. Is this expected?

Depends on whether the implementation for support of custom pipeline creation should be done as part of this ticket or not. Judging from this ticket: https://biomage.atlassian.net/browse/BIOMAGE-506 in the goals it says that it should. But since this PR is ready to go, it might be a better idea to merge it as it is and make the pipeline be custom as part of a separate ticket

Creation of custom pipeline will be moved to a separate ticket


Use $::puppet_vardir instead of $::settings::vardir

$::settings::vardir resolves to the puppetmaster's vardir.
$::puppet_vardir is a fact that rsolves to the clients's vardir.  In
this case, since we're putting the config on the client, we want to use
the client's vardir.

This pull request addresses #12.

I'm closing out old PRs that I'm not likely to return to.


Permission - Add requesting for specific notification types

Goal
This closes #344 with adding the notification types.

Lovely and thanks for upgrade. I shortly check it and merge


⚠ Bofrost.de has degraded performance

In c92b008, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2553 ms

Resolved: Bofrost.de performance has improved in 43e9cb7 after 7 minutes.


fatal error: 'GoogleUtilities/GULURLSessionDataResponse.h'  when building with Xcode 12.0.1

I get following error message when building project:
codelab-friendlychat-ios/ios-starter/swift-starter/Pods/GoogleDataTransport/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploadOperation.m:36:9: fatal error: 'GoogleUtilities/GULURLSessionDataResponse.h' file not found
#import <GoogleUtilities/GULURLSessionDataResponse.h>

Project is opened in Xcode 12.0.1.
Off course I ran pod install --repo-update before clicking Run button.

Same here, Xcode 13.1

Same here, Xcode 12.5

Same here Xcode 13.2.1. I have slavishly followed the instructions and tried all the suggested solutions that I have found.
The error message implies that part of GoogleUtilities is missing. However, according to the pod install output, two different versions of GoogleUtilities are installed :
Installing GoogleUtilities (1.3.2)
Installing GoogleUtilities (7.7.0)
Not sure if this is relevant:
[!] Unable to read the license file LICENSE for the spec Firebase (8.10.0)
[!] Unable to read the license file LICENSE for the spec GoogleUtilities (7.7.0)
[!] Unable to read the license file LICENSE for the spec Firebase (8.10.0)
[!] Unable to read the license file LICENSE for the spec GoogleUtilities (7.7.0)
[!] [Xcodeproj] Generated duplicate UUIDs:

I have advised as below.
--
The project is outdated so the recent version of Xcode won't accept the code. First, the Podfile contains the line as below:
platform :ios, '9.0'
Since the current version of Firebase (8.12.1) requires iOS 10.0 or above, the statement above would force the obsolete Firebase (which is not compatible to the recent Xcode) to be download.
Also, pod 'Firebase/AdMob' would cause another problem, we must use Google-Mobile-Ads-SDK insted.
Thought I update Podfile, the GoogleSignIn would cause error because the implementation is outdated.
As a result, the project must be updated to be compilable on the current Xcode.


(docs) chore: improve readme

Small improvements fixes to the docs.
Added:

topDrawer property
bottomDrawer property
open event
close event

Fixed:

import in Vue code

awesome thank you @tralves . didn't think much people were using it ;)


Configuration priorities in AtmosCoveragePerfConfig are surprising

AtmosCoveragePerfConfig advertises itself as creating a model configuration for many performance tests. The docstring says that the priorities for the configuration s are:
Creates a config from the following in order of top priority to last:
1. Configuration from the given config file/dict
2. Default perf configuration
3. Target job configuration
4. Default configuration

This is very unexpected.
The flag target_job says: An (optional) job to target for analyzing performance. So, one would expect that something like
config = CA.AtmosCoveragePerfConfig(config_dict = Dict("target_job" => "sphere_baroclinic_wave_rhoe_equilmoist"))

would run the sphere_baroclinic_wave_rhoe example. Instead, the default perf configuration has higher priority, so, the following configurations are changed (from default_perf.yml):
moist: "equil"
apply_limiter: true
z_elem: 25
dt: "1secs"
surface_setup: "DefaultExchangeCoefficients"
t_end: "10secs"
vert_diff: "true"
h_elem: 12
forcing: "held_suarez"
precip_model: "0M"
dt_save_to_sol: "Inf"
rad: "allskywithclear"

At this point, not much is left of sphere_baroclinic_wave_rhoe and a completely different configuration is being profiled.
Should default_perf.yml be ignored when a target_job is passed? Maybe default_perf should be thought not as a default, but as a all_perf, ie, something that actives several parts of the code so that the benchmark is closer to a realistic complete run.

In addition to the above, ClimaAtmos.AtmosCoveragePerfConfig() fails because YAML.load_file(parsed_args["config_file"])) is called with Nothing` as argument.
This is not the same behavior as AtmosConfig, which uses the default configuration when called with no options.

Yeah, we should fix the doc string, and or move AtmosCoveragePerfConfig outside of src and into a common file for the perf scripts. The main point of using target_job is so that that is the only flag needed to target a particular flag. The main point of AtmosCoveragePerfConfig is to add a lot of physics to our default (dry baro wave driver) so that we can analyze the performance of a many physics kernels. I think the docs were re-written during some refactoring.

I'm not sure what you mean by "ClimaAtmos.AtmosCoveragePerfConfig() fails",  this is run regularly in our CI.

Ah, I see now. This did not used to be the case. @nefrathenrici, can you please fix this? It looks like the config changes broke this functionality

I think we can recover the default behavior with ClimaAtmos.AtmosCoveragePerfConfig(;config_dict=Dict()), which isn't too bad. Ultimately, I'd like for these perf scripts to work out of the box. The default being the ClimaAtmos default (the dry baro wave).

The main point of using target_job is so that that is the only flag needed to target a particular flag.

What do you mean with this? Did you mean "particular job"?


Fix rate exchange bug

Issue/Task Number: #980
Overview
When creating rate, the amount is not passed correctly because it divided a string x,xxx / y,yyy.
Changes

Fix rate dividing.
Fix height and unused css for top navigation.

Impact
Deploy as usual

also edit modal updatePair button broken.. i think because of the commas in the input...

@nicholasmueller fixed both problem


Build fail: No such file or directory

@marcelstoer , I pulled latest nodemcu-firmware from dev and pulled latest nodemcu-build using docker pull marcelstoer/nodemcu-build.
Doing a Docket build using  docker run --rm -it -v c:/nodemcu:/opt/nodemcu-firmware marcelstoer/nodemcu-build build in Windows 10, I get the following failure:
... inflating: ESP8266_NONOS_SDK-e4434aa730e78c63040ace360493aef420ec267c/third_party/include/ssl/ssl_tls1.h
 extracting: ESP8266_NONOS_SDK-e4434aa730e78c63040ace360493aef420ec267c/third_party/include/ssl/ssl_version.h
 extracting: ESP8266_NONOS_SDK-e4434aa730e78c63040ace360493aef420ec267c/third_party/include/user_config.h
mv: cannot move '/opt/nodemcu-firmware/sdk//ESP8266_NONOS_SDK-e4434aa730e78c63040ace360493aef420ec267c' to '/opt/nodemcu-firmware/sd
k//esp_iot_sdk_v3.0-e4434aa': No such file or directory
Makefile:320: recipe for target '/opt/nodemcu-firmware/sdk/.extracted-3.0-e4434aa' failed
make: *** [/opt/nodemcu-firmware/sdk/.extracted-3.0-e4434aa] Error 1
make: Leaving directory '/opt/nodemcu-firmware'

This error started occurring after the latest nodemcu-build was pulled.

Fixed, the failure related to Windows 10 Docker Desktop. Updating to the latest version solved the problem.


v4 Migration Guide

Preview

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Doesn't work, it loops in login page.

Great work, but even if I have authenticated user, the application loops in login page. Page not found if i try to go /Config/Index Action.
How to fix?
Thanks in advance.

Did you click the link to confirm email?

Yes, I followed all the registration steps but the return url is still login.

Hi, the return URL would be empty because you're not coming from any prior directory/URL within the application, and empty return URL would lead to the index page
I have tried to reproduce the issue from registration step to logging in and it all seems fine;
Here is what i think the problem is

your email confirmation was not successful for this account; try with another account

Assuming you entered the right credentials though

Hi! Indeed, after logging in Google Chrome returns the value "/", Opera returns "/ Config / Index" and then everything works.

As a workaround you can register and modify EmailConfirmed property of a user directly in DB


map attribution is incorrect

Hey, first: great for using an open source map as map background or your big project
Can you please try to add the correct attribution for the used map styles?
Due to OSM and Stamen you can find the correct attribution here:
http://maps.stamen.com/ look for "Attribution"
map tiles (style) is by Stamen, Data is by OSM
Leafletjs is just the origin JS-library to embed the data
You can also write:
Leaflet | Map tiles by Stamen Design | Data by OpenStreetMap
Leaflet=https://leafletjs.com/
Stamen=http://maps.stamen.com/
OpenStreetmap = https://www.openstreetmap.org/copyright/en
Thanks from OSM Community

@Seandebasti Thank you so much for reporting this issue :pray:. Correct attribution is indeed important.
@decabeza I'm afraid I don't have access to the website :thinking:. Could you a look, or maybe we can talk about how to access it?

Hi @Seandebasti,
Thanks for the note! And sorry we didn't add this before. 🙏
Now I think that's right:


Fix: Set indent size to 2 for YAML files

This PR

[x] sets indent_size to 2 in .editorconfig

Follows #227.
:information_desk_person: Throughout the project, YAML files are indented with 2 spaces. Since we're using .editorconfig, it makes sense to adjust it, as not to fight an IDE supporting it.

Thanks @localheinz!


Allow partial rustfmt.toml

With this change one can use a config file
that only specifies a subset of config keys
to overwrite. E.g. a config file that looks like this
struct_trailing_comma = "Never"
struct_lit_trailing_comma = "Never"

Fixes #255

Thanks for the PR, it looks good and I'd like to have this functionality. There are a few formatting nits to fix and it could do with a comment. r+ with that.

Thanks for the feedback. I updated the PR.

Awesome. thanks!

Super cool! That was actually the first time that I ever wrote macro code :)


Redux Form normalize weird issue.

The normalize works when I declare my normalize function here.

However, if I declare my normalize function at different place (File). It is not working.
Anyone know what is the issue with my normalize function here?

It's my fault. Mistake during import.


Question about testing

Hi, i have general question. I have checked test code.
In Data layer test, test class only tests if some method is called, and does not care about result of method. Example, RepositoryTest only tests if method for getting User object is called, but it does not check if it really gets User object from that method. Same for DataStore classes.
In Domain layer, again same thing for UseCases. It only tests if UseCase calls some repository method. Does not care about if it really gets result from that method.
In Presentation layer, again PresenterTest only tests if Presenter calls some method of UseCase.
Question:

What is point of "testing only if method is invoked" :grey_question:
Why none of the Test classes care about the result of method they've called :grey_question: Example, Presenter only checks if it calls useCase method, but why it does not check if view.showContent() is called after useCase returns data? There is no test for if UserCache is able to return right data?

Sorry if i am missing sth

https://static.javadoc.io/org.mockito/mockito-core/1.10.19/org/mockito/ArgumentCaptor.html

This is simple — you need to test the behaviour, not the implementation. If you test agains interface, you test behaviour, so you only need to know if the method is actually called.
How this method behaves and what data returns you should test when writing concrete implementation.

@jungornti

How this method behaves and what data returns you should test when writing concrete implementation.
What do you mean? There is Presenter implementation class which calls UseCase methods, still it doesn't check data returned

If you testing presentation layery (Presenter) then you dont care about data, that comes from UseCase, because you should care about use case being called at all.
You should care about data in following situations (for example):

if you testing repository or datasource implementation
if you testing your aggregate root or domain service to test if all invariants are correct.

@jungornti ok, then where is the test that tests data returned from UseCase? For example, i want to test after executing UseCase, is presenter really calling view.showError() etc, like this line: https://github.com/android10/Android-CleanArchitecture/blob/master/presentation/src/main/java/com/fernandocejas/android10/sample/presentation/presenter/UserDetailsPresenter.java#L113
How to test that exact line?

I think that this test is missing. You can check [https://codelabs.developers.google.com/codelabs/android-testing/#0](this google codelab), maybe it will help.
Now, about testing this exact line. First of all, i will test that presenter calls showErrorMessage with any string (i dont care about text for now).
Then i will test that usecase throws correct exception if there are any specific case for that.
Then i will test method showErrorMessage itself, by passing hand−crafted test ErrorBundle.

What about if there was this line this.viewDetailsView.showError(errorMessage); in line 113, inside onError(),  presenter calls view method directly ? How would you test it?

@jemshit you can mock the view interface (viewDetailsView) in your presenter test class and can use mockito to verify if that method gets called or not .
presenter.someServerCall();
and that call returns the callback on OnError() you can verfiy if the showError method is called or not.
Mockito.verify(viewDetailsView).showError(anyString())

thanks guys


i18nMiddleware TS error

In new projects, middleware.ts shows an typescript error:

Argument of type 'MiddlewareResponseHandler' is not assignable to parameter of type 'MiddlewareEndpointHandler'.

I think it's because Astro updated types in the new release of i18n feature. Speaking of that, what's your opinion on the new i18n feature?

Thanks @MarvinXu!  I’ve been planning to use the new integration middleware feature so that you don’t have to configure the middleware at all—just haven’t gotten around to it quite yet.  I decided to try it first by making cors and helmet middleware for Astro, and bringing back what I’ve learned to astro-i18n-aut.  Certainly makes me miss express haha
As for the new i18n feature, I’m disappointed that it doesn’t support what this library can—rendering all locales, including an unprefixed default locale, using a single page.astro file.  I don’t want to generate or keep an Astro page file up to date for every locale I have.  I was actually hoping to retire this library, but it seems like I’ll need it for quite a while longer.
I’ll keep this issue open until I make a PR for the built-in integration middleware.

I don’t want to generate or keep an Astro page file up to date for every locale I have.

ha, exactly the  reason I chose this integration :)

I’ve been planning to use the new integration middleware feature so that you don’t have to configure the middleware at all

This looks great! Looking forward to it~

Fixed in 0.5.0 🎉
Just remove the old astro-i18n-aut middleware (the integration handles it now)…
…and everything will work the same!

I don’t want to generate or keep an Astro page file up to date for every locale I have.

ha, exactly the reason I chose this integration :)

I encourage you to leave a comment and feedback in the i18n routing RFC 😄 I’d love to see Astro support it in core, or at least fix https://github.com/withastro/astro/issues/8241


100% CPU usage

I am not sure whether this is caused by crow, when I use crow.h sometimes my program takes 100% CPU and couldn't respond to requests, but this doesn't happen when I use crow_all.h, previously you were fixing the bug in http_parser_merged and but this bug is not fixed in crow_all.h, I am wondering whether some bug was introduced during that fix.

I fixed a multithread related bug at 5b72a099736faca57ff2e2906bb1912ed29498d0.
Can you test again with the new version?


Introduce author list order for author references

Add support for adding the order in which the author appears in the publication of the dataset, tomogram and annotations.

Duplicate of #100


Incorrect handling of export config parameters

Hi,
I noticed an issue when converting a Transducer model from espnet to espnet_onnx where the max_seq_len in the DefaultEncoder class was not properly set when specifying m.set_export_config(max_seq_len=5000) in top-level export script.
To me it looks like the issue is caused by incorrectly passing the export_config to the replace_modules method in get_encoder method here:
$ git diff espnet_onnx/export/asr/models/__init__.py
diff --git a/espnet_onnx/export/asr/models/__init__.py b/espnet_onnx/export/asr/models/__init__.py
index d40de3f..7db3bbb 100644
--- a/espnet_onnx/export/asr/models/__init__.py
+++ b/espnet_onnx/export/asr/models/__init__.py
@@ -56,7 +56,7 @@ def get_encoder(model, frontend, preencoder, export_config, convert_map):
             ),
             model,
             preencoder=preencoder,
-            export_config=export_config,
+            **export_config,
         )
         return DefaultEncoder(_model, frontend, **export_config)

For instance, with current code OnnxRelPositionalEncoding was always initialized with default value of 512 instead of what was specified in export_config dict.
@Masao-Someki: Could you please take a look and let me know if that change looks correct?
Thanks!

@espnetUser
Sorry for the late reply!
And thank you for reporting the bug!!
It looks like your change does fix the issue! It seems the code passes the export_config to the class as a dictionary rather than as individual arguments...
Would you create a PR for this?

@Masao-Someki: Thanks for getting back to me!

Would you create a PR for this?

Sure. https://github.com/espnet/espnet_onnx/pull/116


SelectMultipleField: Check that valuelist is not None in process_formdata before modifying field.data

The bugg: When you create a Form using formdata and key-word arguments, the SelectMultipleField would be assign and empty array, instead of the value in formdata (or the value in the key-word argument as a backup).
The fix: Check that the valuelist argument in SelectMultipleField.process_formdata() is not None before changing the field's data attribute. This check is already been made for SelectField.process_formdata(). That is why the problem only arises with SelectMultipleField.
There are a couple of new assert statements in 'test_selectmultiple.py' to check that the problem has been fixed.
PD: There was an error in 'test_selectmultiple.py:40'. The value of 'b' should be equal to the default value define in line 18. But 'b' had a value of '[]' because of the bug in cuestion. That is why the test used to pass, but was now giving an error.

This is incorrect, keyword arguments are the same as defaults, they're only used if no form data was passed.


Add accessibility label to header back button

Add support for accessibility for header back button. As we support accessibility in our app.

@matthamil Hihi. Sure thing :) What file should I update in the docs? Don't know where to put the documentation for the accessibility.

Hey there, could you please demonstrate how this was tested? Does it work on both platforms? Why is the accessibility label needed on the title?
Will the app developer ever want to customize the accessibility labels? Maybe they should be configurable as navigation options?
Also, can you adjust the strings to have Title Capitalization?

@ericvicenti @matthamil Thank you very much for reviewing :D I will change the accessibility labels so the user can customize them him self. I was wondering where in the docs should I document this? And the test plan how does that work?

 The name could be navigationOptions.header.backAccessibilityLabel

Hi ... can you rebase and merge it ??

I am going to close this pull request as it has changes requested for more than a month. If anyone (including original author) is willing to continue working on it, feel free to create a new PR that addresses concerns mentioned during the review process.
We are most likely to accept this PR.


Remove read IDCODE instruction from VeeR JTAG TAP

This PR removes support for read IDCODE instruction from the TAP. This addresses https://github.com/chipsalliance/caliptra-rtl/issues/289 where Caliptra is to be connected to a system JTAG as a submodule.

@bharatpillilli should we target a different branch ?

@mcockrell-google - SInce we did a tagged release already, is it OK to push this to the main branch and then we do another tagged RTL release?

@mcockrell-google - SInce we did a tagged release already, is it OK to push this to the main branch and then we do another tagged RTL release?

Yes - that's probably the best way.

I currently have a sync in progress to address #284 - if we push this to dev-public, I'll grab it in dev-integrate and get it into main.

@calebofearth I see that #299 depends on this PR. To get green CI we need #302 to go in first. Could you take a look?

@calebofearth I see that #299 depends on this PR. To get green CI we need #302 to go in first. Could you take a look?

I see that PR's been merged since making this request, but it looks like a simple and good change.

I see that PR's been merged since making this request, but it looks like a simple and good change.

@calebofearth Okay, great. Rebased this PR on the latest dev-public.

Is this PR ready to go? @tmichalak or @mkurc-ant , are one of you planning to merge it?

@calebofearth we're waiting for some review and ACK (or comments if there is sth to address). If you're OK with the code changes here we can merge it

@calebofearth we're waiting for some review and ACK (or comments if there is sth to address). If you're OK with the code changes here we can merge it

Ok, thanks. Looks good to me.


Fix Guest Agent version compatibility check

What this PR does / why we need it:
We recently added a VMI status condition for AgentVersionNotSupported. This was intended to warn the user that the version of the QEMU guest agent they're using isn't compatible with KubeVirt. The method we currently use to check for compatibility is error prone. This PR introduces a new method of checking -- Instead of checking the package version number, we now inspect which calls the QEMU guest agent actually supports. As part of this we no longer need to track compatible versions (since package version numbers are now ignored entirely).
The fundamental issue that's causing this check to fail so often is that the guest agent API isn't versioned--the "version" call returns the guest agent version, not an API version. So any regexp we craft to check versions will eventually fail, even though odds are overwhelmingly that nothing's wrong.
Which issue(s) this PR fixes
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1908419
Release note:
Updated Guest Agent Version compatibility check. The new approach is much more accurate.

/cc @davidvossel @ashleyschuett

/hold
Will look into @davidvossel's suggestion

/hold cancel
Adjusted this PR according to @davidvossel's suggestion

/hold cancel
Adjusted this PR according to @davidvossel's suggestion

/retest

/retest

/cc @ashleyschuett @davidvossel
This PR is ready for review.

/cc @ashleyschuett @davidvossel
This PR is ready for review.

/lgtm

/lgtm

/hold
The commit history on this PR has gotten messy. I'd like to clean that up a bit. @davidvossel ignoring the spaghetti-commits the code itself is ready for critical review.

/hold cancel
commit history has been cleaned up

/retest

/cc @davidvossel
Dusting this one off. Finally had a chance to incorporate your feedback ICO upgrading from older version.

/assign @enp0s3

/cherry-pick release-0.36


[Bug]: The resolver label doesn't work on branches started from a fork

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Describe the bug and reproduction steps
At least I think that's what happens, for example here:
https://github.com/All-Hands-AI/OpenHands/actions/runs/12041355151/job/33573059053?pr=5178#step:6:1
Started from: https://github.com/All-Hands-AI/OpenHands/pull/5178#issuecomment-2502333342
I think it failed on that issue because it's a branch started from a fork... It just doesn't recognize the first repo secret (LLM_MODEL). @mamoodi what do you think, I seem to recall you've seen something like this recently?
OpenHands Installation
Other
OpenHands Version
No response
Operating System
None
Logs, Errors, Screenshots, and Additional Context
No response

Hey @enyst! This is an issue that we hope to resolve by addressing #5050 😀

Ah okay, thank you!

Yeah forks don't have access to secrets for the organization. Same problem with running eval on PRs.

Seems like this is a duplicate of https://github.com/All-Hands-AI/OpenHands/issues/5044


dev: Increase Travis output wait

Documentation for travis_wait:
https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received

I tested a couple of values before submitting this PR. The default without this PR is 10 minutes; 30 minutes is too short as you can see in this failed build of my fork:
https://travis-ci.org/mihaic/brainiak/builds/604666246
Travis has an overall timer of 50 minutes as well and we must allow time for testing. See also the fixed issue where we discussed test durations:
https://github.com/brainiak/brainiak/issues/107
I believe a recent change in conda-build increased the build time, so I opened an issue to investigate that:
https://github.com/brainiak/brainiak/issues/442