Rclone ESXI

What is your rclone version (eg output from rclone -V)

rclone-v1.37-049-g28a18303β

Which OS you are using and how many bits (eg Windows 7, 64 bit)

VMware ESXI (fork of Linux)

Which cloud storage system are you using? (eg Google Drive)

Google Drive

The command you were trying to run (eg rclone copy /tmp remote:tmp)

./rclone -V | ./rclone config ...

A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)

message from ESXI "Segmentation fault"
See also the forum thread

In the forum thread we tried an rclone compiled with go-tip without any luck.
Can you try a simple go binary?  This is a simple hello world compiled for linux/amd64
hello.zip
If that doesn't work then we should report this as a go issue.
Either way does ESXI have gdb? If so can you try it on the failing binaries like this (I made a crashing binary called crash - you would use rclone or hello).
$ gdb ./crash
GNU gdb (Ubuntu <IP_ADDRESS>70314-0ubuntu1) <IP_ADDRESS>70314-git
[snip]
Reading symbols from ./crash...done.
(gdb) run
Starting program: /home/ncw/Go/crash
[New LWP 29811]
[New LWP 29812]
[New LWP 29813]
[New LWP 29814]
[New LWP 29815]

Thread 1 "crash" received signal SIGSEGV, Segmentation fault.
main.main () at /home/ncw/Go/crash.go:7
7		*p = 1
(gdb) bt
#0  main.main () at /home/ncw/Go/crash.go:7
(gdb)

hello,
Exactly the same issue "segmentation fault".
I cannot check crash, because no gbd...
Thanks

I made a in issue on the go project about this: https://github.com/golang/go/issues/21347


a feature request：Could you provide Chinese web pages and help files?

a feature request
Could you provide Chinese web pages and help files?

Unfortunately not. Even if this would be contributed by the community, this would make it really hard for me to keep the documentation up-to-date as I don't speak and write Chinese.


Inputs for SelfAttention mechanism

Apologies if this is inappropriate for an issue or relates too closely to  #77.
I've had a look at the documentation for SelfAttention in modules.py and its unit test, but I'm still unsure of the following: if (for example), I've got a graph with nodes A, B, and C, feature vectors Av, Bv and Cv for all 3 nodes, and sender and receiver information for those nodes, what are my "keys", "values", and "queries"? Are queries the relationships a given node has with other nodes, and keys the indices of the nodes?

You would need a tensor of keys, a tensor of queries (same feature_size as keys) and a tensor of values for each node in the batch.
Each of these tensors will have shape:
[total_num_nodes, feature_size]
There are many ways you can get these three tensors, for example:

Take the nodes that are output by a graph network, and split the feature size in 3 (keys, queries, values = tf.split(output_graph.nodes, [key_size, key_size, value_size], axis=-1))
Take the nodes that are output by a graph network, and use 3 different MLPs/LinearLayer with consistent output sizes to create the three tensors.  (keys = snt.Linear(output_size=query_size)(output_graph.nodes) and so on for queries and values).

Hope this helps!

Thanks very much for the prompt response!
So just to clarify, the flow would be:
Input graph --> Graph Network --> Output graph 1 --> Generate keys, queries etc. via splitting / layers --> feed into SelfAttention module --> Output graph 2
where the 2nd output graph has the aggregated attended value for each of the nodes?

Not necessarily, that was just an example of how to get some tensors nodes. In that flow you will have communication both via self attention and via message passing in the first GraphNetwork.
If you want to have pure communication via self-attention, instead of using a modules.GraphNetwork you could use a modules.GraphIndependent (providing a node_model_fn to encode the nodes independently), or a blocks.NodeBlock (with both use_*_edges options disabled) if you want the nodes to also be conditioned by some global vector in the graph.

Ok great - thanks so much! I'll try and get a flow with pure communication going ASAP.


When HttpResponse.Body is replaced, the replacement is used for future requests

Copied from https://github.com/aspnet/KestrelHttpServer/issues/940 to consider this for 1.0.1.
This is a contrived example to illustrate the point:
app.Use(next => context =>
{
    if (context.Response.Body is MemoryStream)
    {
        throw new Exception("Wrong stream type in context.Response.Body");
    }

    context.Response.Body = new MemoryStream();

    return context.Response.WriteAsync("Hello, world!");
});

Run the application and browse to it. The first request returns nothing (content was written to the MemoryStream). Subsequent requests will hit the Exception.
The real-world case is when the Body stream is decorated for a given request. The decorator stream will be re-used for a subsequent request, which could result in re-decorating the stream, and ultimately produce a long chain of decorators.
It appears that Kestrel is trying to be efficient by re-using its underlying Stream instances. But the reusable instances are being replaced, with unintended consequences for future requests.

@muratg Should I close this? Or are we waiting for something before closing 1.0.1 issues?

@cesarbs Sure, make sure to update the label to done.


Ambiguous class resolution because of duplicated traits

Warning: Ambiguous class resolution, "Spatie\Snapshots\Concerns\SnapshotDirectoryAware" was found 2x: in "vendor/spatie/pest-plugin-snapshots/src/Concerns/SnapshotDirectoryAware.php" and "vendor/spatie/phpunit-snapshot-assertions/src/Concerns/SnapshotDirectoryAware.php", the first will be used.

Warning: Ambiguous class resolution, "Spatie\Snapshots\Concerns\SnapshotIdAware" was found 2x: in "vendor/spatie/pest-plugin-snapshots/src/Concerns/SnapshotIdAware.php" and "vendor/spatie/phpunit-snapshot-assertions/src/Concerns/SnapshotIdAware.php", the first will be used.

Are these trait duplicates needed for anything? If so I think that this package should use exclude-files-from-classmaps to exclude the original files and load the overrides.

Thanks for creating this issue. Can you create a pull request with your idea?


Support 3D models

Note that the "file viewer" on the Hub already renders the 3D models (.glb) using https://modelviewer.dev/:
https://huggingface.co/datasets/allenai/objaverse/blob/main/glbs/000-000/000074a334c541878360457c672b6c2e.glb
https://user-images.githubusercontent.com/1676121/229077088-ef9bfde2-2e9a-4b12-8ac9-2d0ed3283df7.mov
related to #979

maybe related: https://github.com/huggingface/datasets/issues/6388

blocked by https://github.com/huggingface/datasets/issues/7195

we can brainstorm about the UX maybe (i don't expect we should load all models on the page at once – IMO there should be a manual action from user to load + maybe load first couple of row by default) cc @gary149 @cfahlgren1

we can brainstorm about the UX maybe (i don't expect we should load all models on the page at once – IMO there should be a manual action from user to load + maybe load first couple of row by default) cc @gary149 @cfahlgren1

I wonder if you could somehow show a preview (img) of the model in the dataset and when you click the img you can load the model in the modal similar to how we show expanded pictures. See lazy loaded model viewer here too.

I wonder if you could somehow show a preview (img) of the model in the dataset and when you click the img you can load the model in the modal similar to how we show expanded pictures. See lazy loaded model viewer here too.

Sure, that would work. How would you obtain an image for each 3D model and each dataset, though? It's seems quite complex. Maybe a a simple placeholder each time would be simpler.

yeah that part is tricky, given there are only a few datasets on the hub probably not worth the effort.
I like the icon approach. Logo is 🔥

what about my idea of loading a few (can be 1) first items


06 September 2022 - Diversity Equity & Inclusion Special Interest Group Meeting

Date
06 September 2022 - time
Untracked attendees

Fullname, Affiliation, (optional) GitHub username
...

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[x] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve past meeting minutes
[ ] Meeting time clashes with FINOS Regulation Innovation SIG. Can we find a time that does not clash with another FINOS meeting. Community Calendar
[ ] Resources for 1st time speakers: Resource Center & Blog Post
[ ] Tech Gateway update and SIG help needed for promotion - https://tg.zngly.com/
[ ] FINOS Community Awards and the DEI SIG - James has a clash on this meeting, but the conversation needs to start about getting the SIG involved.
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

Meeting Info
Join Zoom Meeting
https://zoom.us/j/98492160513
Meeting ID: 984 9216 0513
Passcode: 691166

Jevon Beckles - present

Hi.

Present

Cara Delia present.

hi


Gadri exercises (Lessons 21 & 24)

I added typed exercises because I find that it is easier to understand a concept if there is a wider range of opportunities to try.

Thank you!
My concern with some of the translations is that, whenever "le" is accepted", "lo" is accepted as well. But if someone writes "lo", their translation will be considered incorrect. So I need to think more about what to do there.


feat(phone_ext): Allow users to add a phone extension to listings

JIRA-713
To test:
After pulling the branch, go to Create/Edit (Submit a Listing) page.
Scroll to the bottom of the page and click Add New under the Contacts section.
The Unsecure Phone section will have an updated message telling the user how to add an extension.
Use case examples for the phone validation:
###-####
###-###-####
(###) ###-####
###-###-#### x##
###-###-#### x###
###-###-#### x####
###-###-#### ext###
etc, etc
'extension' will also work.
(A new field in the create/edit form was deemed unncessary for this feature.  The backend for a phone number already supports upto 50 characters as a string.  The only step needed to allow the user to add an extension was to update the JS REGEX validation to allow x/ext/extension + a number.)

@blynch11p  - Would adding an additional input field for user to add extension be more user-friendly?

pulled branch
reviewed code
tested

:+1:

:+1:
Regex matches correctly. Tried inserting characters in random places and wouldn't match.


Apk crashes when create a note or try to access existing notes -- V1.3.5_alpha.3

Apk crashes when create a note or try to access existing notes .
Here am adding screen recording for the reference.
https://user-images.githubusercontent.com/102143707/178963240-16cce526-ce7d-46d0-8b45-2050274c2018.mp4

New apk alpha 4 sent for testing with fix - https://bridgeconn.sharepoint.com/:u:/s/DevTeam-VachanUI-VachanGo/EfqbemBx1aJEhMj96WlIckAB0-Mlnt46hNcKxhFu9_dB4w

Testing completed and the issue with the notes which crashes the apk has fixed. As discussed moving this issue to done.


Using IP restriction for Azure Table

When using IP restriction of Azure table storage with firewall of Table Storage, cloud partner portal cannot create leads to Azure Table storage with Error 'StrorageException.'
After turned off firewall, cloud partner portal can create leads. So, if we can know IP address for cloud partner portal, we can resolve this issue. Could you tell me IP address?
I think, Cloud Partner portal IP is included Azure Data Center IP address range. So, if Azure Storage Firewall function of 'Trusted Microsoft services' has cloud partner portal , we can resolve completely.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2632af75-7664-b79b-ac5b-c7c17e6a609a
Version Independent ID: 6ecf71b6-77c4-3ab6-8ec9-353ea407d70f
Content: Configure Azure Storage firewalls and virtual networks
Content Source: articles/storage/common/storage-network-security.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@MakurodaHotmail
Thanks for your feedback! We will investigate and update as appropriate.

@MarileeTurscak-MSFT
Thank for checking my issue. I'm waiting for your update. If you need more information, please let me know.

@MakurodaHotmail Firstly, apologies for the delay in responding here and any inconvenience this issue may have caused. what is cloud partner portal ?
You are not able to create leads to table storage when firewall is on, you need IP to whitelist
recommend posting your question in https://azure.microsoft.com/en-in/support/community/  since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@SumanthMarigowda-MSFT
Hi, thank you for checking. Explanation of Cloud Partner Portal is here.
https://docs.microsoft.com/en-us/azure/marketplace/cloud-partner-portal-orig/cloud-partner-portal-getting-started-with-the-cloud-partner-portal
Cloud Partner Portal URL is this: https://cloudpartner.azure.com/
This portal is to use for management Offer and Lead in Azure Marketplace.
I want to use Table Storage for manageming Leads with IP restriction, so I need Azure Firewall function with Trusted Microsoft Services.
And I posted this question to StackOverflow, could you assist to me?


Consider short-circuiting writes having TTL-expired timestamps

In certain scenarios, such as when backfilling CVs, catching up from a paused stream, upstream failure, etc. we can easily end up performing writes to rows that are already TTL-expired. Obviously they'll be cleaned up as soon as possible by the reaper, but it's probably worth adding an optimization to the combiner that performs a TTL check before actually flushing the write to disk.

This is a trivial optimization, with one significant complication: since TTLs can be added/changed, it involves detecting when a TTL has changed, and reloading the CQ state accordingly. Currently CV/CTs are immutable, so we never have to refresh their state within the execution process which keeps things very fast and efficient.
If we want to support this, we'll have to add support to the combiner for detecting changed TTLs and reloading CQ for them to take effect.

This could probably be a good lead in to #1814, in the sense that both of these issues require efficient detection of configuration changes.


Fix failing tests in GraphApiClientTest for ArangoDB 3.7

Tests are failing in the graph API when ran against ArangoDB 3.7. We are asserting the value of cluster-only properties, whereas the created graph is for a single server. Removing those Assert will fix the test.
More details here: https://github.com/Actify-Inc/arangodb-net-standard/pull/298#issuecomment-725327203

At some point we can look at running tests against an ArangoDB Enterprise edition, possibly with a cluster setup. They are quite a few features that we are not covering in tests.


How to monitor thanos S3 backups

Hi there, is there any way to look at logs, etc. for thanos backups to s3. I'm pretty sure I've got everything sorted - he sidecars and the querier are up and running and works.
But nothing is appearing in my bucket, and I want to work out what's going on here!

Do the Thanos people have some suggestions on how to debug that? If they do, then we should make sure that that's possible with the Prometheus Operator, or maybe we can even make it easier :slightly_smiling_face:

Maybe an "THANOS_ARGS" variable that can be used to pass arbitrary args to the sidecare so the log level can be increased, etc?

log level is already passed through as the log levels of prometheus and thanos are equivalent :slightly_smiling_face:

ahh excellent, let me try increasing that and see where that gets me

did increasing the log level help?

Wait, I'm wrong on that "thanos store" front. It could just be the env vars - I'll work it out and open a PR

Thanos store (today) is not involved in uploading, but that has been discussed. Please do open a PR if there should be any mistakes in the env var configurations (they have also changed on master since the last release, if that's the case we should probably stick to whatever the latest release supports).

You know what, I think this was a completely separate issue on my end... If I do find anything I will open a PR though :)


Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter

https://github.com/xdid-net/webhookemail/blob/8c584958e53a08d0b99451288bd20df9b3f75905/template.tpl#L71
When reviewing your template, we've noticed that it is using user-defined parameters to build a URL. It's best practice to use encodeUri() if part of the URL path or encodeUriComponent() if used as a URL parameter.

Fixed with new version

Fixed with new version


Compiler options page 'noisy'

This page either needs some form of tabulation - this is just text 'noise' and is hard to scan through the options - designer should know better than this
https://www.typescriptlang.org/docs/handbook/compiler-options.html

Hi, designer and developer on the site here - it should be better with the most recent deploy.
It's a straight copy of the old version which had the same constraints I'm afraid, the TSConfig Reference replaces this table

I honestly think microsoft lost the ability to design usable and readable guides and User Interfaces since Windows 8 Metro HELL - to me as a user/developer both pages are a jumble of information that are hard to follow and mentally process - the newer version makes it worse by having 3 columns to process - compared to the ease of use of MDN documentation this is farcical. No wonder Microsoft consider MDN to be their source of JS docs.
Microsoft seem obsessed with making every flat and indistinguishable.
I guess this is as good as it gets from Microsoft.

Wow, shot to the heart there @virtuallightstudios - I'm proud of this design work (it's also the first thing I did since I joined Microsoft) sorry it doesn't work for you.

The comment wasn't meant as a personal attack - however it may to wise to put the design out internally and get some feedback prior to unleashing on the public.
Part of my issue is that I hate change especially as it happened suddenly within the 24 hours that I am evaluating Typescript.


Correct a typo by replacing uv_request_t by uv_req_t

Tend to believe that uv_request_t should be uv_req_t.
Please ignore if I have mistaken.

Landed in eddff0a, thanks!


Depreciated items are no longer crossed out / broken graphics in the documentation

The new menu does look and feel better but there seems to be some big problems.
Using neovim 0.5.1 appimage and latest nvim-cmp with the new menus and the deno language server:
deno.buffer is depreciated and used to have a cross through it, also 'ected' has appeared from nowhere:

documentation window has gone very wrong:

Some kind of terrible bug is plaguing this:

There are very similar problems on the latest 0.6 master branch too:

I found the answer, I have the following lines added to stop the virtual text and instead show the diagnostics on putting the cursor on the error... I think it is much better:
-- Turn off virtual text
vim.lsp.handlers['textDocument/publishDiagnostics'] = vim.lsp.with(vim.lsp.diagnostic.on_publish_diagnostics, {
  virtual_text = false,
})

-- Show diagnostics on cursor over and stop window being focusable
vim.cmd [[autocmd CursorHold,CursorHoldI * lua vim.lsp.diagnostic.show_line_diagnostics({focusable=false})]]

Now it shows the error right on top of and in the documentation window, you can see the error in red on the last image I attached above. It seems the message is white in version 0.5.1.

OK. I get the reason too.
I think you don't need the CursorHoldI (Because in insert-mode, some other plugins will show the another floating window so It easy to conflict with show_line_diagnostics.

Thanks, that fixes it :)


[RFR] Allow null as a valid value for translation

There is no good reason to prevent a translation to be null. When deliberately wanting to define a translation to be incomplete (empty), null is a perfectly reasonable value.
This PR intends to fix that.
When (if?) you merge, could you please bump a new version on npm? Thanks.

sorry seems I didn’t get a notification for this. I’m not convinced this is a change for the better, but maybe I’m missing something.
My open question are: Why don’t you use an empty string to signal empty values and what is the purpose of a translation to nothing? I’d vote against allowing mixed types.


feat: advanced search UI

:tada: This PR is included in version 1.195.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Song sync across levels

You should only have to upload a song once and then you can access it on every level instead of having to upload it every time you want to use it on a different level.

hey there, songs are being stored based on the song ID, nothing much I can do about that


UI cuts the last part of the latest item in the credentials list

Description
On ubuntu the UI cuts the last part of the latest item in the credentials list
Additional Context

wrong project :)


"fs" is not founded in akord module

I'm trying to use this module in Next.js project to use arweave service. And when I start development next.js project, I got following error.
error - ./node_modules/@akord/akord-js/lib/core/file.js:177:76
Module not found: Can't resolve 'fs'

I really appreciate any advices.

I'm trying to use this module in Next.js project to use arweave service. And when I start development next.js project, I got following error.
error - ./node_modules/@akord/akord-js/lib/core/file.js:177:76
Module not found: Can't resolve 'fs'

I really appreciate any advices.

Hi @cancan007, thank you for opening the issue!
Here's an example of using akord-js with Next.js: https://github.com/Akord-com/recipes/tree/main/nextjs-starter
To fix Module not found: Can't resolve "fs", you can update your Next.js config file by setting the "fs" fallback to "false" as shown here:
https://github.com/Akord-com/recipes/blob/8c95a84bf609eecf244dea2607f836ba4eed3011/nextjs-starter/next.config.js#L7
I'm sorry for the inconvenience, the package is for both nodeJS and the browser and this sometimes causes problems, we will try to improve this part so that it works without additional configuration in the future.
Let me know if this helps for now :)

hi, wkolod
Thank you for reply, and it solved!
I really appreciate ur help and u are implementing this module.


[Documentation] Swap findWhere and where in documentation

I re-ordered findWhere and where in the documentation to make it less confusing
Fixes #1811

Coverage remained the same at 96.863% when pulling 5084b51dcd263e0576a078b65b95197b748214c5 on jdelbello:master into 6fa3796bf50fad2120beae86c3c9b33551f40f5e on jashkenas:master.

Can you also move find to be beside findWhere?

@pootzko from #1811 suggested that the order should be as I presented it in this pull request, and I agree. The reasoning is that we want to keep find and filter together because both search for matches based on context. We also want to keep where and findWhere together because both search for matches based on properties. I moved findWhere before where because I wanted to preserve the pattern in the first pair of "find first occurrence" and "find all occurrences".

find (context, first)
filter (context, array)
findWhere (properties, first)
where (properties, array)

Does that make sense?

wasn't aware of the previous discussion on this. I'm fine with this rationale


docs: fix quoting issue, clarify naming in auth.md

The steps for creating serving certificates were missing a pair of
quotes, which could have lead to some confusion.
This also clarifies the naming of the serving certs a bit: many places
refer to the cert and key as .crt and .key, but cfssl outputs them
as .pem and -key.pem.

cc @jpeeler

while you're in here. line 70 stesp to steps.


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #75.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #75

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge/core maybe someone has an idea what's wrong with osx:
ld: -stack_size option can only be used when linking a main executable
clang-11: error: linker command failed with exit code 1 (use -v to see invocation)

Perhaps something like https://github.com/kovidgoyal/kitty/issues/289#issuecomment-416040645


Group-by aggregation based optimization for UNBOUNDED collect_set window function

Fixes https://github.com/NVIDIA/spark-rapids/issues/10114.
This change introduces an optimization for the collect_set() window function, when run as an fully UNBOUNDED window function, as follows:
SELECT COLLECT_SET(foo) OVER (PARTITION BY grp
                              ORDER BY ord
                              ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) ...

It might be possible to solve most UNBOUNDED window aggregations via group-wise aggregations. This change addresses collect_set first.
This change currently builds on the changes @revans2 made over at #10158, and includes those changes here.
A new window-exec is introduced specifically to address fully UNBOUNDED window functions.  Each input batch is processed via group-wise aggregations.  For groups that are known to be complete, the output is returned.  The results for incomplete groups are cached, and finalized only when the end of the group is encountered.

The operation seems to be functional, from my testing.  A few tasks remain:

Handling retries in the second stage.
Rooting out memory leaks.

I'm working on these now.

I'm now trying to sort out the bugs revealed in the test I added.  I'll update when I have more.

A quick update: The code is close to complete.  There seems to be a memory leak that's proving hard to find.

I've resolved the memory leaks at last. @revans2, could you take another peek at this?

Sorry, I thought I'd upmerged.
Yes, I should resolve these before we merge.

Still getting errors on compile. Looks like some style issues with the imports.

I did some quick scale tests and it looks really good. I'll try to look through all of the code on Monday.

Build

Build

Build

CI still seems to be failing because of https://github.com/NVIDIA/spark-rapids/issues/10382. I'll retry the build after #10382 is resolved.

Build

Build

@revans2: I've rebased this change since #10158 was merged.  The tests are passing, thankfully.


Roadmap for Symfony 6 & Stimulus 3 support

Hi!
Stimulus 3 has been released (if you're unaware, it's a few nice feature, but mostly, the library was renamed from stimulus to @hotwired/stimulus) and Symfony 6 is around the corner. Here is what I think we should do:
A) Make one last 1.x release of symfony/ux with Symfony 6 support #160 (we decided to skip this - if you're using Symfony 6, you'll use 2.0 of the symfony/ux libraries)
B) Create 1.x and 2.x branches on symfony/ux (skipped this also - keep main branch only for now)
C) Make a 2.0 release of symfony/ux, stimulus-bridge, stimulus-testing
- Merge Stimulus 3 PR (#141, https://github.com/symfony/stimulus-testing/pull/4, https://github.com/symfony/stimulus-bridge/pull/48)
- new build system / typescript (#156)
- Chartjs upgrade (#126)
- bump PHP min version to 8.0
Blockers for the 2.0 release:

[x] #141
[x] #156
[ ] #126 (not a block but would be great to have)
[ ] PR to update the recipe for WebpackEncoreBundle to install @hotwired/stimulus v3

This can be closed I think


feat(npm-package): exclude docs from npm

make sure to exclude the dist/docs folder from published npm package
closes #202

Coverage remained the same at 94.851% when pulling cc0c788a2892620b829d5aa0a3678ac9d422662b on #202-remove-docs-from-published-npm-package into 9eb6569b267db20d59c0e265f2540a2c8fc7f985 on master.

please change to fix instead of feat

@simonmumenthaler opened a new PR #204


pre-commit hook for the repository that can do a static code analysis

pre-commit hook for the repository that can do
1-format code
2-a static code analysis

@aselarbd @orionpax00  please, assign to me that to start to work contribute to this project


Documentation

We may need to add some notes on how this backs up the files, and possibly update that functionality


Minimum/Maximum Row/Column sizes per item

As requested as part of #89 there should be the option to configure a minimum and maximum column and row size for each item.

Great Ben, thank you very much! We will test it and give you some feedback.

We tested this. Minimum rows/columns works perfectly! Thank you.


[nginx] Add support prefix/suffix server names

In would be great to add support for prefix and suffix server names (i.e. ".top.domain" and "sub.domain.").
It makes it possible to reuse the same ingress definition in several environments.
k8s does not allow to specify wildcard server names, but it may be added as annotation "ingress.kubernetes.io/prefix-wildcard".
Please let me know if there is a better way to support it.
I can make PR for this feature.

@electroma you can use the same FQDN in mutiple ingress rules. The only restriction is that you cannot use the path multiple times. If there is path conflicts the first created ingress rule wins.

@electroma please reopen if you still have issues

@aledbf thank you for your reply.
Let me give some examples.
Example 1:
I've got several environments running same set of components.
Each environment has a public domain.
I have ingress object for each public resource.
Using FQDN approach I need to copy/template ingress object on every environment (component.[env.parent.domain]).
Example 2:
My k8s ingress controller is exposed on several domains, for example public and internal.
In this case I need to create separate ingress object for each domain.
Now I'm using helm charts to create several ingress objects, but it's just a duplication.
In this setup each chart should know parent domain(s).
My proposal is to add support for basic prefix names instead of FQDN and let ingress controller to form FQDN of it.
It can help to reduce number of duplicate ingress objects in scenario described above.

@aledbf I can't reopen this issue. Let me know if I need to create another one.

My proposal is to add support for basic prefix names instead of FQDN and let ingress controller to form FQDN of it.

Right but this also increases the complexity of the generation of the template to render.

My proposal is to add support for basic prefix names instead of FQDN and let ingress controller to form FQDN of it.

Please post some examples

This is an example of prefix Ingress syntax:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: auth-service
  annotations:
    ingress.kubernetes.io/prefix-wildcard-subdomain: true
spec:
  rules:
  - host: auth
    http:
      paths:
      - backend:
          serviceName: auth-svc
          servicePort: 80
        path: /

During conversion it will be converted to the construct server_name  auth.* in NFINX configuration.
Having prefix service name will make this service available on any subdomain mapped to NGINX controller.

I would like this for similar effect, but slightly different reasons: we're managing a couple of clusters for the dev teams here and it would be nice if they didn't need to know the ingress domain for the cluster they are targetting but just say "I want this name/subdomain" and let the IC take care of it.
My though on how to achieve it was an entry in the ConfigMap for the IC that says "my default domain is X, suffix it to anything not ending in a valid tld" but that's probably quite complex in hindsight.

Closing. This is out of the scope and soon we will have a LoadBalancerClaim concept https://docs.google.com/document/d/1Kj9OcTQdERZgNkZhdDxnQeT-TI4DLqqg62lShnboT6s/edit


Feature Requests: Add command/button to git branch delete (local and remote)

Pleeease, that's honestly the only reason I'm switching to the cmd line when in vs code and dealing with git

Actually, tell me where the git create branch action is and I file a PR for the remove action.

Closing this since local branch management commands are in. Remote ones, I'll mark it as out of scope.


Request: Save passwords encrypted using Android KeyStore

Currently all IMAP/POP3/SMTP/WebDAV credentials are stored in the preferences as plain text. I would like to propose to encrypt the password(s) using the Android KeyStore API for devices with Android 4.3 (API level 18) and above.
One "drawback" is of course that it will not be possible to include the passwords when importing/exporting the settings.
http://developer.android.com/training/articles/keystore.html

Another drawback (this time without quotes since I see this as a real drawback):
The device needs to be unlocked to be able decrypt the password. So if a user starts his/her phone without unlocking it no emails will be received. Only when it is unlocked K-9 will be able to decrypt the password. I have not digged through the code fully, but from this point K-9 hopefully can hold the password in memory.

I don't think that behaviour is necessarily something that should prevent us using the keystore. Personally I see it as a good thing that a non-unlocked device won't start using the user's credentials to perform mail retrieval. If it were related to back-up the argument is more complex (theft vs. interception of backups).

I think it's a feature to omit passwords in settings.   A settings file without a password isn't that sensitive, and the password is easy to reenter.   I also agree that not using the credentials on boot until unlock is makes sense.   If k-9 could only fetch mail when the phone was unlocked later, that would be a bug.

We need direct access to passwords to be able to support all authentication schemes. Using KeyStore in a meaningful way is not an option for K-9 Mail.

not entirely true: it's possible to generate a symmetric key in the android keystore since Android M, which if hardware-backed can't be extracted so it would minimize (albeit not eliminate) the time the actual credentials are stored in ram.
check out the fourth example here: https://developer.android.com/reference/android/security/keystore/KeyGenParameterSpec.html

Sure. But that is just a poor man's way to avoid device encryption. I don't think we should invest time to support users willing to set up a "secure" device lock but not device encryption.
Also, KeyStore was unreliable in the past. So this has the potential to cause serious support issues when used on older devices.

agreed (link related)


no returns in this function

Thanks for the PR, however addImbalance also returns void.
Hence, it is fine to return it.


Line lenght of input text fields is hard coded - looks weird on iPad

nothing to do, was already fixed in a previous PR:


ACR - Determine if Polaris is a Suitable Platform

Review and determine if Polaris is a better platform than PoSH Server for this project.

I looked at Polaris, and maybe it's the better option but it still looks confusing enough to me that I'll hold off until later.  PoSH Server is working okay for now.


Add FunctionExecutionContext model extension and factory method

Add a class under Extensions/Models/ that is in the PlayFab.CloudScriptModels namespace.
This class serves two purposes:

Provide context for Azure Functions that are using the SDK to make further API calls back to Main Server
Simplify the creation of PlayFabApiSettings and provide a single instance for the developer to use throughout all further function calls using authentication information provided by Main Server, such as title ID, secret key, and entity token.

Closing to redo branching scheme and not have PR to master.


Fix data races in flows_test.go

Motivation
Data races in test code can cause tests to be flaky.
Changes
Added synchronisation to test code to ensure race free access to test results. Details of the data races can be found in the commit messages.
Test Plan
I used the following command to run the offending tests multiple times and witnessed no data races.
ulimit -n 9999; CGO_LDFLAGS="-L/Users/piersy/projects/go-spacemesh/build/ -Wl,-rpath,/Users/piersy/projects/go-spacemesh/build/" TEST_LOG_LEVEL= go test -timeout 0 -v -count 10 -p 1 -race ./hare/... -run Test_multiple

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors merge


Update CNI to 1.2.0

[ upstream commit a1046bcc10b75c7130f0579d40d0529c85e1fe56 ]
Run images/scripts/update-cni-version.sh 1.2.0 to update the CNI version.
Ref: https://github.com/containernetworking/plugins/releases/tag/v1.2.0
Signed-off-by: Michi Mutsuzaki<EMAIL_ADDRESS>

/test-backport-1.13

/mlh new-flake Cilium-PR-K8s-1.19-kernel-4.9

/test-1.19-4.9

/test-1.24-5.4

@michi-covalent it looks that 1.19 failed for the first time with this test. I would suggest to run it five times before merging to detect the potential flake caused by this PR.

yeah the same test failed again. very suspicious: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/2570/

/test-1.19-4.9

/test-1.19-4.9

/test-backport-1.13

✅ test-1.19-4.9: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/2605/

/test-1.19-4.9

/test-1.19-4.9

/test-1.19-4.9

/test-1.19-4.9

/test-backport-1.13

/test-backport-1.13

test-1.22-4.9: https://github.com/cilium/cilium/issues/23317

/test-1.22-4.9

/ci-gke-1.13

/ci-aks-1.13

/test-1.22-4.9

/test-backport-1.13

/mlh new-flake Cilium-PR-K8s-1.18-kernel-4.9

/test-1.18-4.9


Improve support for Chrome Android browser

Currently on Android browser the recording doesn't work. I tried the demo for video and the recorder doesn't start after clicking it.
Any plan on supporting them?
Thank you

@fajarmf what (version) of the android browser? Can you add a screenshot?

My mistake, it was a chrome browser. and the screenshot is attached.

@fajarmf is there any way you can get a console log for this? I'm hoping we can use that to figure out what's going on here.

I've used the DevTools to debug this issue and I managed to record a audio/video clip but the playback of this clip failed with this error:
video.min.js:22 VIDEOJS: ERROR: (CODE:4 MEDIA_ERR_SRC_NOT_SUPPORTED) The media could not be loaded, either because the server or network failed or because the format is not supported.

From https://developers.google.com/web/updates/2016/01/mediarecorder: Audio recording works in Firefox and in Chrome 49 and above; Chrome 47 and 48 only support video recording.
I tested audio+video in the previous comment so that explains the error. @fajarmf which one did you try?

Here's a bug tracking the MEDIA_ERR_SRC_NOT_SUPPORTED error: https://bugs.chromium.org/p/chromium/issues/detail?id=253465
There seems to be a workaround, can you give that a try @fajarmf?

Hmm for me it also doesn't work on mobile chrome - simply nothing happens. https://webrtc.github.io/samples/src/content/getusermedia/record/ asks for permissions but videojs-record does not. Will try to find out what's wrong later.

OK I tried to debug but there are no errors and actually I found out that it kinda works, but reaaaallllyyy slow. Like press button then wait 3 min for video to show up (with pressing that button repeatedly) then press record then wait again and with multiple tries it's possible to record something. So it seems that it does work it just so incredibly slow it's unusable with android chrome. Video is also very slow and choppy while recording.  https://webrtc.github.io/samples/src/content/getusermedia/record/  is really fast compared and original RecordRTC is slower but usable. I have used HTC M8 and android chrome 51.

@ignl thanks for the report. I suspect the code that updates the current time for the video.js player is slow as it happens continuously. What if you comment out the statements on https://github.com/collab-project/videojs-record/blob/master/src/js/videojs.record.js#L1231 and https://github.com/collab-project/videojs-record/blob/master/src/js/videojs.record.js#L1257?

Ok I have checked on firefox and video performance seems similar. Maybe chrome is more sensitive to this. I will test it tomorrow as it requires https so i will need to deploy my app or work around that security requirement. However there is also something wrong with the click event as it hardly works on first easy touch on android. For the firefox I also had to try several times until it asked me permission for cam and mic same with chrome just takes much longer. Maybe will need to try and play with different events.

I have added touchstart event everywhere where there was a click event. Something like this:
DeviceButton = videojs.extend(VjsButton,
    {
        /** @constructor */
        constructor: function(player, options)
        {
            VjsButton.call(this, player, options);

            this.on('touchstart', this.onClick);
            this.on('click', this.onClick);
        }
    });
    DeviceButton.prototype.onClick = function(e)
    {
        e.preventDefault();
        // stop this event before it bubbles up
        e.stopImmediatePropagation();

        // open device dialog
        this.player().recorder.getDevice();
    };

Not sure if it is a good approach, I didn't find any problems like ghost click event triggering but maybe its only on my device. Maybe need a better solution like the ones discussed here.
Camera view is laggy and choppy on mobile chrome, and it is so even before starting recording so proposed fix didn't help.  I tried on recordrtc example again and this time recording was also really choppy so I think the problem could be with record rtc.
Also tried on htc browser and it didn't work at all, but the problem is probably that it is based on an old version of chrome so no surprises.

Did adding touch events help?

Yes mobile browsers now works fine on my htc just maybe need more testing with more devices. But yeah touch events should be added to the project.

@ignl cool, could you add a PR?

Ok I will test my application a bit more, and when finish will try to do it

It looks like the only event video.js subscribes to is the tap event as seen here. This doesn't seem to be a native browser event but a custom video.js event indicating there is support for touch events as seen here. So it seems we need to listen for tap events as well as the current click events.

@ignl if you have time, please test the latest. I'll put out a new release in a few days.

I will test "tap" a bit later today.

OK "tap" event works for me.

Did I try it myself? Uh, of course?? And if you followed the link in my previous comment explaining tap, you'd see it's a custom video.js event that combines touchstart and touchstop events.
Thanks for testing!

Yeah saw "tap" vent before when looking for mobile event, but I thought it will require additional dependency so it's my bad research :)

Going to close this, if there are any other mobile issues, open a new ticket.


Poor error message with setters.

I created a class:
class Test {
  int range = 1000;

  set setRng(int val) => range = val;

  get getRng => range;
}

If I type test.setRng the setter is underlined RED and it throws the error The getter 'setRng' isn't defined for the class 'Test'. This is a very poor error message since all it's missing is the value it needs to be set at, the setter is certainly defined for the class. Adding = 100 on the end makes the error disappear completely.

This sound like a problem with dart in general and not specific to flutter. Dart issues should be raised at https://github.com/dart-lang/sdk/issues/new/choose.


⚠ ClamAV has degraded performance

In 261744f, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 197 ms

Resolved: ClamAV performance has improved in 3c89463.


Idea for deserialization flexibility

I have a little conundrum right now, I need to deserialize a field named draft-code, and I really don't want to name a field r#draft-code (I'm not even sure what the stringify result of that would be) — between that and deny_unknown_fields that cannot be turned off, also fields that cannot be made optional... I was thinking about how deserialization could be made more flexible.
And I kinda like the idea of the Deserialize trait's main function taking some sort of "Context" or "Opts" structure that could do things like:

Turn on deny_unknown_fields
Given a key, decide if a field is required, or if we should use its default value (that one's kind of annoying because ideally we'd want more flexibility, ie. to return a T rather than say "use the default" — we cannot return a T but we might be able to fill in an &mut Option<T> but.. how do we guarantee type safety in this case? some kind of downcasting would be needed)
Map a key name to another key name — when deserializing structs, if we encounter draft-code, that function could map it to draft_code. This can be done as a CowStr<'s> -> CowStr<'s> — and then it would work the same for structs and HashMaps.

This approach would avoid combinatory explosions of macro_rules — which are already pretty bad right now — and could push the boundaries in terms of flexibility, without having to resort to codegen (yet!). I also think they wouldn't necessarily be a big problem performance-wise.

Done in #89


Support signal in addEventListener

https://github.com/whatwg/dom/issues/911

Supported on 6.0.0.

Supported on 6.0.0.


Frontend support for language extension with #lang-X

For Pulse and other DSLs, we want tighter syntax integration. This PR provides support for writing
module A
#lang-somelang
let f x = 0
fn g () { ... }
let h x = 1

I.e., after #lang-something, the rest of the file is parsed by a custom parser registered for language "somelang". Such a parser can be an extension of the F* parser and what follows could be a mixture of F* and some custom syntax. The block can optionally end with an #end-lang, without it, the entire rest of the file is considered to be in extension syntax.
This is used in Pulse---where you can find a fully worked out example of how all this works.
Some of the main pieces:

FStar.Parser.AST.Util provides:

type extension_lang_parser = {
  parse_decls:
   (contents:string ->
    p:FStar.Compiler.Range.range ->
    either error_message (list decl))
}

val register_extension_lang_parser (extension_name:string) (parser:extension_lang_parser) : unit

This is the main parser hook for #lang extensions. The registered parser takes a string and a source range for the suffix of the buffer after the #lang pragma, and should produce a list of F* declarations (or an error)

FStar.Parser.ParseIt.mli provides a function that an extension can use to build an incremental parser that works well with VSCode. I.e. given a lexer and parser for one or more declarations, this function will incrementally parse until reaching the first error.

val parse_incremental_decls :
    (*filename*)string ->
    (*contents*)string ->
    FStar_Sedlexing.lexbuf ->
    (unit -> 'token * Lexing.position * Lexing.position) ->
    ('semantic_value -> FStar_Compiler_Range.range) ->
    ((Lexing.lexbuf -> 'token) -> Lexing.lexbuf ->
         ('semantic_value list * FStar_Sedlexing.snap option) option) ->
'semantic_value list * parse_error option

FStar.Parser.AST has two new constructs:

Unparseable : decl' which is a token to indicate a terminal parsing failure in a file, associated with a range. By including this token as a decl, we can produce a list of decls including up to the first error, suppressing the error. This is useful when launching  the IDE on a file that may have syntax errors in it.

DeclToBeDesugared: A decl node which allows an extension to stash arbitrary data (e.g., its own parse tree) within the AST, for downstream processing. The node also includes callbacks to let an extension check blobs for equality (using for caching in the IDE), and to scan blobs for dependency analysis.

FStar.ToSyntax.ToSyntax: provides the following, to allow an extension to desugar  DeclToBeDesugared node with the desugaring environment appropriate for that point in a file---using this ensures that an extension doesn't see out-of-order names in scope.

type extension_tosyntax_decl_t = env -> FStar.Compiler.Dyn.dyn -> lids:list lident -> Range.range -> list sigelt'
val register_extension_tosyntax (lang_name:string) (cb:extension_tosyntax_decl_t) : unit

FStar.Options provides an ide_filename which is set programmatically by the IDE mode, allowing other modules (notably extension parsers) to query the name of the file on which the IDE was launched. This is not a command line option.

FStar.Interactive.Ide: This is all mostly transparent to FStar.Interactive.IDE when using the full-buffer mode, i.e., for VSCode. However, for backwards compat with fstar-mode.el, which only sends fragments of buffers, I rigged the repl-state to keep track of which language parser is currently active and use that to parse the next chunk sent by emacs.

I also got an Everest green with this; it is still compatible with pulse ... style extensions.


content gets overridden on elfeed-search-fetch

I've added a function to elfeed-new-entry-hook that adds some metadata and overrides the default content.  If I run elfeed-search-fetch (press G) some time later it resets the content of all already existing entries to it's original state (though as expected the things I've set in meta stay the same).
I'm not sure if this is intended behavior.
If so what would be the best way to get around this?

As a general rule, information provided by the feed is kept in sync with
the feed. This includes title, date, and content. That's why if you want
a custom title displayed in elfeed-search, you set the metadata :title
slot. This is local — i.e. not supplied by the feed itself — so it
doesn't get synced / overridden during updates. It's useful because
elfeed-search knows to use it instead of the original title when it's
non-nil.
The same could be extended to content via a :content metadata slot. For
this to completely work, it would require support from elfeed-search (to
choose it instead of the original content) and the database garbage
collector (treat :content, if not all metadata slots, as a GC roots).
There's nothing stopping you from using a :content metadata slot now
except for those two reasons.

Thanks for the quick answer, especially pointing me towards the garbage collector has likely saved me a lot of time/headache.
Would it be sensible to make the GC process check the whole entry for refs by default? (I suppose "indirect" references like images would still be collected/removed that way)
Not sure how much of a performance impact that would be on bigger feeds. (though I suppose it shouldn't make much of a difference)
Other than that I consider this issue solved.

I ran into this issue as well, and after considering a few solutions, I think I found one that could work.
The idea is that elfeed would expose a list of functions (technically a hook) that are each passed an entry and must return an elfeed-ref or a list of elfeed-refs, which are counted as being in use by elfeed-db-gc.
Heres an example of what I mean:
(defvar elfeed-db-gc-trace-functions nil
  "A list of functions called to determine which elfeed-refs are reachable.
Each function is called with an elfeed-entry and should return a
single elfeed-ref or a list of them, which will be considered in
use by `elfeed-db-gc'.")

(defun elfeed-db-gc (&optional stats-p)
  "Clean up unused content from the content database.
If STATS is true, return the space cleared in bytes."
  (elfeed-db-gc-empty-feeds)
  (let* ((data (expand-file-name "data" elfeed-db-directory))
         (dirs (directory-files data t "^[0-9a-z]\\{2\\}$"))
         (ids (cl-mapcan (lambda (d) (directory-files d nil nil t)) dirs))
         (table (make-hash-table :test 'equal)))
    (dolist (id ids)
      (setf (gethash id table) nil))
    (with-elfeed-db-visit (entry _)
      (let ((content (elfeed-entry-content entry))) ;this is left hardcoded in
        (when (elfeed-ref-p content)
          (setf (gethash (elfeed-ref-id content) table) t)))
      ;; NEW STUFF
      (dolist (trace-function elfeed-db-gc-trace-functions)
	(let ((refs (funcall trace-function entry)))
	  (unless (listp refs)
	    (setf refs (list refs)))
	  (dolist (ref refs)
	    (when (elfeed-ref-p ref)
	      (setf (gethash (elfeed-ref-id ref) table) t))))))
     ;;END OF NEW STUFF
    (cl-loop for id hash-keys of table using (hash-value used)
             for used-p = (or used (member id '("." "..")))
             when (and (not used-p) stats-p)
             sum (let* ((ref (elfeed-ref--create :id id))
                        (file (elfeed-ref--file ref)))
                   (* 1.0 (nth 7 (file-attributes file))))
             unless used-p
             do (elfeed-ref-delete (elfeed-ref--create :id id))
             finally (cl-loop for dir in dirs
                              when (elfeed-directory-empty-p dir)
                              do (delete-directory dir)))))

I think its worth leaving elfeed-entry-content hardcoded in as a GC root (as opposed to having it being the default value of elfeed-gc-functions) so if elfeed-gc-functions gets set to nil by accident the user won't lose all their old entry contents (like I did while testing this out), and if they really want to delete all the old contents, they can just run this:
(with-elfeed-db-visit (entry _)
  (setf (elfeed-entry-content entry) nil))

(elfeed-db-gc)  ;; garbage collect everything

which i found in this neat blog post.
As for the other block, elfeed-show-refresh-function already exists, which has been more than customizable enough for my needs.


[$500] Room - Selection list RHP does not show sliding animation while being dismissed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.55-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to staging.new.expensify.com.
Go to FAB > Start room.
Go to Room.
Click Workspace (or Who can post or Visibility).
Click outside the RHP.

Expected Result:
The RHP will show sliding animation while being dismissed.
Actual Result:
The RHP does not show sliding animation while being dismissed.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/7362f8aa-0619-421a-814b-a27645f8515b

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a45c6aecba3aa427
Upwork Job ID:<PHONE_NUMBER>290019328
Last Price Increase: 2024-03-20

@rlinoz I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this issue might be related to the #vip-vsb.

He did, but the videos in the Authors checklist there is an animation, and in the reviewers checklist there is not, so something happened along the way.
@Krishna2323 @hoangzinh

Not a deploy blocker though, so removing the label

I don't see this issue happening in my case on the latest main

@godofoutcasts94 you have to click outside the RHP.

Yes i did

@Krishna2323 This was added by you around 2 weeks back ( https://github.com/Expensify/App/commit/904316b9036ad3c7b87ae371d59354094af4a39a )
Was there a reason you used Navigation.dismissModal ) ?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Room - Selection list RHP does not show sliding animation while being dismissed
What is the root cause of that problem?
The ValueSelectorModal opens separately in a RHP screen . And when we call Navigation.dismissModal in on backdrop press we the prev screen is closing with animation which will not affect to ValueSelectorModal
What changes do you think we should make in order to solve the problem?
when the user clicks on the background Call hidePickerModal too. To do that we can update this line like below
onBackdropPress={()=>{
    Navigation.dismissModal()
    hidePickerModal()
}}

What alternative solutions did you explore? (Optional)
Use below styles instead margingLeft here
position: 'absolute',
right: 0,
height: '100%',

Pinged on the original PR here

This should probably be fixed by the original PR creator, since it's in the regression period. @Krishna2323

Confirmed with @danieldoglas and I agree that because this is within the regression period, we're assigning both @Krishna2323 (contributor) and @hoangzinh (C+) to this issue as well to get this corrected 👍

This should probably be fixed by the original PR creator, since it's in the regression period. @Krishna2323

I am sorry but i want to ask where is it written that the regression should be fixed by the original PR creator ?

This should probably be fixed by the original PR creator, since it's in the regression period. @Krishna2323

@hoangzinh @CortneyOfstad @Pranav2612000 @danieldoglas  I am sorry but I want to ask where is it written that the regression should be fixed by the original PR creator ? I encountered case when there was chosen the proposal of other contributor

@Krishna2323 indicated on the PR here they will review the feedback 👍

PR still in review 👍

Reopening for proposals since we got to a dead end here.

Thanks @rlinoz!

waiting for proposals

waiting for proposals

@rlinoz What about my proposal ?

@shahinyan11 which one specifically?

@rlinoz this one

The proposal only works if we delay the dismiss: https://github.com/Expensify/App/pull/38711#issuecomment-2075349697
And making it a separate screen was considered poor ROI before: https://github.com/Expensify/App/pull/38711#issuecomment-2078535974

I am inclined to close this for now, since we don't want to create the new screens yet.

Sounds good to me @rlinoz! Closing!


GrandUriPersmission in AndroidManifest.xml

The plugin sets the provider "org.apache.cordova.camera.FileProvider" with the grandUriPermission="true" in the AndroidManifest.xml.
According to google developer documentation https://developer.android.com/guide/topics/manifest/provider-element#gprmsn the given permission must be revoked via the function Context.revokeUriPermission().
Is it possible to remove the entry and use grantUriPermission before using the FileProvider and after revokeUriPermission in the class "CameraLauncher"?

@maltorpro can you clarify a little bit more on your expectation. The android permissions seems to work just fine.
Why should the given permission be revoked?

I am closing this issue, because there is not enough information / answers to start working on this.


Stop usage data config file from being committed by users in v13

Description of the issue

After running npx govuk-prototype-kit create, npm run dev, and responding to the dialog asking about analytics, users will have a usage-data-config.json file in the project. Currently in the v13 branch git will offer to commit this file for them, which is not the desired behaviour and not the behaviour that is present in v12.
Steps to reproduce the issue

Checkout v13 branch of this repo
Run node bin/cli create --version local /path/to/new/project
Change directory to new project
Run npm run dev
Enter y or n to accept or decline analytics
Stop prototype
Run git status

Actual vs expected behaviour

Expected behaviour is git does not show usage-data-config.json.
Actual behaviour is git does show usage-data-config.json as new untracked file.
Environment (where applicable)

GOV.UK Prototype Kit version: v13

There are two possible ways of fixing this, either adding the file to the prototype starter gitignore (see #1681) or moving the file into the .tmp file (see #1690).
We need to pick which fix we want, @joelanman and @nataliecarey to discuss.

We're going with starter gitignore as in #1681


remove mergeRichtexts(), not needed anymore

method not required anymore.

Before<EMAIL_ADDRESS>After: https://experience.adobe.com/#/@amc/aem/editor/canvas/author-p122525-e1200861.adobeaemcloud.com/content/exlm/global/en/uat/mirko-test.html?ref=remove-richtext-merge

somethings broken


Tutorial Page sds-part7-testing.md Issue. PROD

Tutorial issue found: https://github.com/SAPDocuments/Tutorials/blob/master/tutorials/sds-part7-testing/sds-part7-testing.md contains invalid primary tag.
Your tutorial was not updated. Please double-check primary tag property.
Each tutorial md-file shall have primary tag provided above. Example:
---
title: Text Bundles within Node.js SAP HANA applications
description: Working with text bundles in Node.js
primary_tag: products>sap-hana
tags: [ tutorial>intermediate, products>sap-hana, products>sap-hana--express-edition ]
---
Affected server: PROD

Tag updated: https://github.com/SAPDocuments/Tutorials/commit/a6650f8c273f14714acae7fedeeee1ae083a9b05


feat(payments): INT-2816 Added 3DS to googlepay adyenv2

What? INT-2816
Added adyen to stop asking to redirect
Why?
In order to have 3DS working for google pay on AdyenV2
Siblings
BigCommerce PR
BigPay PR
Checkout-SDK
Testing / Proof

@bigcommerce/checkout

This PR is no longger needed, changes were merged in other PR


Run CI on PRs

Similar to #593, it'd be nice if the "Build and Test" workflow ran on PRs, so that contributors can tell whether a PR passes the tests before merging.

I have no idea why I didn't set this up this way in the first place.


1006 upload camera lecture slides as vod

Motivation and Context
Currently its not possible to add lecture slides and camera videos as dedicated video files.
Description
Add input fields to allow the upload of camera and slides video too. Because the upload formular becomes a little
user unfriendly, it is refactored. Also, a jump to new added lectures and is introduced together with a little marker
that marks the new added lectures in the list.
Steps for Testing
Prerequisites:

1 Admin
1 Course

Log in
Navigate to a Course Admin Page
Upload a new VoD with dedicated camera and slides video
Check if all videos are working
Upload a new VoD with combined stream only
Check if the VoD with combined stream is working

Screenshots
https://github.com/joschahenningsen/TUM-Live/assets/17506411/7052c833-3b1d-4a25-acbe-c602929107d2

@joschahenningsen I did some major changes due to your feedback, I hope it makes it simpler. Summary:
I renamed uploadVOD to createVOD and removed the video upload logic. All videos are not uploaded over the dedicated endpoint uploadVODMedia. Now the upload logic only has to be in one of the two endpoints. Also the worker does not have to return the streamID but it can be directly returned from createVOD.
Downside, you could theoretically create a vod without any media if you sent the request manually to the API. But thats probably not to bad.


Move JavaPrinter out of internal package

It is now designed for extension by framework users.

resolved here: https://github.com/openrewrite/rewrite/commit/ce02173db6200c26bf6538a33d5b93789284e7b9


How to pair programmatically BLE device(nRF 52840) with iOS iPhone using Swift

When I try to connect my device(iOS Application) to my peripheral(BLE Device), I want to send this passkey programmatically during the connection. I'm using BleManager but I can't find a way to send it programmatically. Please provide your valuable inputs and suggestion

BLE library is so far for Android only,
This screen shot is from Android,
You are asking in iOS nRF Toolbox project,
You're asking about Swift API, as far as I understand.

Please ask your question on DevZone or Stack Overflow, or provide info how your case is related to this project.
BTW, on iOS, the only way to initiate bonding is to read/write secure characteristic, or trigger bonding from the remote side (don't ask me how).


Bump Dependencies #8724215676

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/8724215676

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


babl: 1.2.8 -> 1.3.4

Motivation for this change
Motivation for change: GIMP 2.9.6 requires at least BABL v1.3.0 so upgrading to latest release.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/) - this is a library
[X] Fits CONTRIBUTING.md.

Thanks!


test: update how Selenium is configured

Summary
This updates how Selenium is configured so that the dummy specs can be run locally in more environments such as Ubuntu on WSLv2.
Pull Request checklist
Remove this line after checking all the items here. If the item does not apply to the PR, both check it out and wrap it by ~.

[x] Add/update test to cover these changes
[x] ~Update documentation~
[x] ~Update CHANGELOG file~

Other Information
I think this is just the result of the dummy project being generated a long time ago and so this is effectively just updating the config based on changes that have happened over the years - specifically this was based on the config we generate in our rails-template.
Before this is landed someone should try this locally to ensure this doesn't just "work on my machine" - until then I'll mark this as a draft.

This issue of version mismatch is really annoying.


Random letter at initialization

In the current version, only the first letter is visible at a hint. Modify it further to include random letters. But be careful of the capital letter.

No need


Large dark surfaces with directional light has banding at certain angles

Project: https://playcanvas.com/project/875481/overview/light-banding
To reproduce:

Fork the project
Change the 3D view from Perspective to Camera
Notice the circular banding of light on the surface from the material

That's the 8bit monitor which cannot display smooth gradients here. I tried Unity and get the same results.
The darker the image, the more banding you see.
To fix it, you need monitor that can display 10 bit colors, and also render to HDR (10-10-10-2) framebuffer.


How is it possible to get the indexes of the current expanded headers/parents?

Hi,
I want to know which parents/headers are expanded currently. Is this possible at the moment?
What I tried:

Save the parent view holders
When I need the indexes, call into adapter `getExpandedHeaders()'
retrieve expanded status via ParentViewHolder.isExpanded()

Problem:
The ViewHolder list is not "final" since it will change during runtime when the list grows or shrinks.
Thanks

Oh well, I think I got a solution.
    @Override
    public void onBindParentViewHolder(@NonNull HeaderViewHolder parentViewHolder, int parentPosition, @NonNull someobject parent) {
        parentViewHolder.bind(parent);
        if (parentViewHolder.isExpanded())
            expandedHeaders.add(parentPosition);
        else
            if (expandedHeaders.contains(parentPosition)) expandedHeaders.remove(parentPosition);
}

Saving the expanded headers this way seems to be accurate.


updated finality documentation

updated finality example in integrating.md
updated json result for view_state query example in rpc.md

you got it!

Did not include aforementioned example, as a block finalizes in within 2seconds after transaction is complete. This makes querying the non-final state difficult and was decided to leave it out of this particular doc.


FPS Issues with Borderless

Description:
My FPS is about 30% lower with Borderless installed, as opposed to without. I'm just opening this issue to let you know, I'm not expecting a fix :)
The issue was discovered in this issue: https://github.com/NillerMedDild/Enigmatica5/issues/280
Steps to reproduce:

Start Minecraft with Borderless
Make sure all terrain around you is generated, and that your FPS is set to Unlimited
Note FPS
Close Minecraft, remove Borderless, repeat 2) and 3)

Versions:

Minecraft Version: 1.15.2
Forge Version: 1.15.2-31.1.73
Mod Version: 1.15.2-1.0.1

Thanks for reporting. I noticed that as well when using the borderless window, but I think FPS drop also applies to other games, as a borderless window often has slightly worse performance. But it should definitely not be that significant. On my side, I only have an FPS loss of 5-10 frames. I think there is nothing I can do to fix this problem.
The only thing that might work is to leave the window in native fullscreen, but prevent the window from minimizing when the focus is lost. The downside of this is that other windows can not be placed on top of Minecraft.
I think I will implement this behavior and let the user choose the desired fullscreen mode with a config file.

I might look at making a change to GLFW that makes fullscreen windows on Windows respect the GLFW_FLOATING hint, so that disabling GLFW_AUTO_ICONIFY is actually useful there.
The current method both our mods use on Windows (I maintain the Fabric equivalent Borderless Mining) seems to disable the swap interval and call DwmFlush despite the fullscreen borderless heuristics making this not necessary, which causes vsync and performance issues. See https://github.com/glfw/glfw/blob/master/src/wgl_context.c#L322 and https://github.com/glfw/glfw/blob/master/src/wgl_context.c#L349
Replacing the native GLFW library from a mod will be annoying, but I don't think it'd be too hard to do, and of course it can be PR'd to GLFW directly so whenever Mojang updates they can use this functionality too.


BCUninstaller.dll: System.EntryPointNotFoundException error

Last two (or maybe three) releases of the app always have this error message after every deinstallation process.
It's running on Windows 7 x64.

Run Windows Update and install all system updates.

Run Windows Update and install all system updates.

All of them were installed long ago. More likely it's related to something like this (2), I guess (?)

Yes, it's similar, but this API is added to Windows 7 by Windows Update.


remove logger.error noise

observed a few errors in the log since latest hotfix rollout.  the situation no longer deserves error alert status, as the withdrawn users will legitimately raise this error.  dialed back to a logger.warning just in case it helps with future debugging.
not critical to push live, unless the alerts are overwhelming.
example of error it was generating:
celeryworkerslow_1  | {"written_at": "2024-03-27T14:30:02.073Z", "written_ts":<PHONE_NUMBER>073935000, "msg": "patient 5357 w/o cur_qbd??", "type": "log", "logger": "flask.app", "thread": "MainThread", "level": "ERROR", "module": "qb_status", "line_no": 99, "correlation_id": "7f2f63ac-ec46-11ee-b0e1-0242ac190006"}
celeryworkerslow_1  | 2024-03-27 14:30:02,073: patient 5357 w/o cur_qbd??

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file portal/models/qb_status.py:

Line 99:80: E501 line too long (83 > 79 characters)


Upgrade Web app to React 17 (#11558)

Summary
Cherry pick of https://github.com/mattermost/mattermost-webapp/pull/11558
cc. @amyblais
Release Note
Cherry picking the react 17 upgrade to v7.6

@nevyangelova There are some failing tests.


Add SmoothedConstantInterpolation

Fixes https://github.com/SciML/DataInterpolations.jl/issues/364.
Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[x] Any new documentation only uses public API

Additional context
using DataInterpolations
using Plots
using Random

N = 10
Random.seed!(8)
u = rand(N)
t = cumsum(rand(N))
A1 = ConstantInterpolation(u, t)

p = plot()
plot!(A1)

for d_max in 00.05:0.05:0.2
    A2 = SmoothedConstantInterpolation(u, t, cache_parameters = true; d_max)
    plot!(A2)
end

p

Fun feature; if SmoothedConstantInterpolation is used with extrapolation = ExtrapolationType.Periodic, then the transitions are also smooth:
using DataInterpolations
using Plots
using Random

N = 4
Random.seed!(8)
u = rand(N)
t = cumsum(rand(N))
Δt = t[end] - t[1]
t_eval = range(first(t) - Δt, last(t) + Δt, length = 500)

A = SmoothedConstantInterpolation(u, t; extrapolation = ExtrapolationType.Periodic, d_max = 0.2)

plot(t_eval, A.(t_eval))
scatter!(t[1:end-1], u[1:end-1]; label = "data")
scatter!(t[1:end-1] .+ Δt, u[1:end-1]; label = "data one period forward")
scatter!(t[1:end-1] .- Δt, u[1:end-1]; label = "data one period back")


TextField should support typing accented words with external keyboard

Steps to Reproduce

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: TextField(
          autofocus: true
        ),
      )
    );
  }
}

run above sample in iOS
change keyboard input language to Spanish (Spain)
type [
type a

Expected results: à
Actual results: `à
we tested it on iOS/Android with external keyboard. both native behaviors showing the accented a without additional prefix `. in Flutter, it shows two words ` and à.

 flutter doctor -v
$ flutter doctor -v
[✓] Flutter (Channel stable, v1.17.0-4.0.pre.7, on Mac OS X 10.15.5 19F96,
    locale en)
    • Flutter version 1.17.0-4.0.pre.7 at
      /Users/jerrychen/Documents/project/flutter
    • Framework revision b041144f83 (12 days ago), 2020-06-04 09:26:11 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/jerrychen/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1
[✓] Connected device (1 available)
    • iPhone 11 Pro • B39B2840-47A2-4280-A589-D86B4AC8A69F • ios •
      com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)

Reproducible on the latest master 1.21.0-2.0.pre.83.

flutter doctor -v
[√] Flutter (Channel master, 1.21.0-2.0.pre.83, on Microsoft Windows [Version 10.0.18362.900], locale et-EE)
   • Flutter version 1.21.0-2.0.pre.83 at C:\Development\flutter_master
   • Framework revision 9e658bc3d5 (8 hours ago), 2020-07-21 03:56:07 +0200
   • Engine revision dcc9a4048d
   • Dart version 2.9.0 (build 2.9.0-21.0.dev 9dca49e71e)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
   • Android SDK at C:\Users\Isa\AppData\Local\Android\sdk
   • Platform android-30, build-tools 30.0.0
   • Java binary at: C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
   • All Android licenses accepted.

[√] Chrome - develop for the web
   • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.4)
   • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
   • Visual Studio Community 2019 version 16.6.30309.148
   • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
   • Android Studio at C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
   • Flutter plugin version 47.1.2
   • Dart plugin version 193.7361
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.47.2)
   • VS Code at C:\Users\Isa\AppData\Local\Programs\Microsoft VS Code
   • Flutter extension version 3.12.2

[√] Connected device (5 available)
   • SM G950F (mobile)       • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
   • sdk gphone x86 (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
   • Windows (desktop)       • windows            • windows-x64    • Microsoft Windows [Version 10.0.18362.900]
   • Web Server (web)        • web-server         • web-javascript • Flutter Tools
   • Chrome (web)            • chrome             • web-javascript • Google Chrome 84.0.4147.89

• No issues found!

It seems that we also have the same issue with the Physical keyboard having an input language as Portuguese (Brazil).

type ˜
type a
It should become ã but it is not.

Any updates on this problem?

I have the same problem with Flutter (Channel stable, 3.7.6, on Microsoft Windows [version 10.0.19044.2604], locale pt-BR).
I develop on Windows, but I compile for IOS and test on an IOS with an external keyboard.

This issue is reproducible on the latest stable and master channels.
Verified with Vietnamese by two methods:
Using scrcpy

Input: a + s
Expected result: á
Actual result: a´a

Connect with physical keyboard via Bluetooth (switching to Vietnamese language)

Input: a + s
Expected result: á
Actual result: as

Demo

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.7, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.7.7 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (10 hours ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.9.0-12.0.pre.17, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.9.0-12.0.pre.17 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6b7c60d69a (2 hours ago), 2023-03-20 18:08:51 -0700
    • Engine revision ea6ed14b4e
    • Dart version 3.0.0 (build 3.0.0-345.0.dev)
    • DevTools version 2.22.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 111.0.5563.64

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Since my duplicate issue has been closed, and this one has been open for several years, I've been looking for a workaround that allows me to use this feature while waiting for the problem to be solved at platform level.
I have published a package at https://pub.dev/packages/dead_keys with an ad-hoc text editing controller that should handle these cases. It's a library still at alpha level, I'd just like to know what you think and if it's a viable way.

The package by @aleripe is very good however is not perfect (eg doesnt handle correctly TextFormField with obscureText: true as used for password fields). I am voting for implementing support for these accented keys into Flutter.

The package by @aleripe is very good however is not perfect (eg doesnt handle correctly TextFormField with obscureText: true as used for password fields). I am voting for implementing support for these accented keys into Flutter.

I vote for it too. My package is just to support my use case until it is fully implemented in the framework, but it's far from being perfect. By the way, if you need some precise functionality in the meantime please open an issue and I'll be happy to check if I can support it.

I have the same problem. When I type on google keep or any android app it works fine, the issue is specific to flutter textinput.
There have been many threads about this, I don't know if this matter is already been put on a schedule or a list of known bugs to be fixed.
See these threads:

[Flutter Desktop] Textfield does not accept accents #75510
Windows: Dead keys are not producing accented characters #86179
TextField should support typing accented words with external keyboard #59541
Accents in TextField widget do not work (Flutter 2.0.1 Desktop Windows - Beta Channel) #77534

This issue is still there. It is a blocker issue because many of our clients are using external keyboard and cannot type essential accents now, making our app totally unusable. The package by @aleripe is solving this for some cases, unfortunately it is buggy and can not be used reliably, we found after profound testing. Sometimes it works, sometimes not. This needs to be fixed by Flutter development team urgently in the core packages themselves. Info - our clients are using physical keyboard with layout cz_CS.

Also the bug is still present in Flutter release version 3.10.3

Priority of this issue should be hightened.

This issue is still there. It is a blocker issue because many of our clients are using external keyboard and cannot type essential accents now, making our app totally unusable. The package by @aleripe is solving this for some cases, unfortunately it is buggy and can not be used reliably, we found after profound testing. Sometimes it works, sometimes not. This needs to be fixed by Flutter development team urgently in the core packages themselves. Info - our clients are using physical keyboard with layout cz_CS.

As I told before my package is just a test of an alternative way to solve the problem. If this needs to become definitive we can work on it to make it more reliable, but I agree... it would be better to have it implemented inside the framework as I believe it's a core functionality (IME).

@aleripe yes I know, I am not complaining, just I am not sure if reliable functionality is even achievable with custom package.

I have the same doubt... but I see there's not much interest around this topic.

@aleripe Left you an e-mail (just noting it case it gets into spam folder or something). Also making this thread more active and visible will not harm I guess. :)

I'm also experiencing the same problem in the pt_BR layout. Customers are unable to use physical keyboard on IOS devices.

Not sure of how to bring this issue to attention generally, so tagging two of the possibly active core devs.
@jonahwilliams @stuartmorgan could you add tags "found in release 3.10" and possibly UP the priority of this issue?
It might not be obvious on first sight, but this is crucial issue. In many localizations (including my national) essential letters of the language can be typed only by this method (typing accent + letter afterwards) and no other way. Many of Flutter apps users use eg. iPad with the external keyboard to input the texts comfortably. While having this issue this make  typing text into Flutter app not possible in many countries (aka localizations) including mine. From my understanding there is "some" implementation of typing accented letters in Flutter. It is just buggy and doesnt work. So fixing this issue should possibly not be reinventing the wheel. I am coming from the notion that when I press accent key, it appears inside input field with underscore as if it was expecting the following letter for accenting. However after pressing the following letter the underscore gets away and the letter is just put next to the accent. In best case it might be just issue of some missing localized keymaps of accented letters in the Flutter core. Please, lets not get this issue unnoticed. We are making text data intensive Flutter app for several thousands of enterprise clients and currently they just cant type in text in our national language using external keyboard. Thanks for any reaction.

@ioma8 Please do not ping random developers. I would also suggest reading https://github.com/flutter/flutter/wiki/Issue-hygiene#escalating-an-issue-that-has-the-wrong-priority

I have the same issue. It's really annoying since flutter is used across so many apps. If this was fixed, it would make using quite  a few  apps on my device much more pleasant.

This here is the commit that fixed the same issue for Windows:
https://github.com/flutter/engine/pull/27921/commits/32de55aab1313b0f8756013b2b5e22279be7b88a

This is also happening on Flutter Web on macOS, is there any update? I've noticed the same thing with pt_BR input and also the Kana japanese input. Maybe #105244 is related? Could #1053243 fix it?

@kevmoo we've had reports from our users that this is happening. The majority of our users are from Quebec, and therefore speaking french.
We're using flutter 3.13.6 right now. We've reproduced it on latest iOS with a bluetooth keyboard.

@Pacane – how about w/ the latest stable (as of yesterday)?

@kevmoo along with @Pacane, in our Braver app, we've confirmed that it still happens as of 3.16.3

... and also in 3.16.4

Just to confirm, this in a Flutter WEB app on a mobile device with an external keyboard?

No, this is a native app on iOS, with an external keyboard.

Its shame this issue doesnt get adressed. We are still having to use workaround otherwise our app would be unusable for lot of our clienta who use it with external keyboard. And no its not web app. Its native ios app.

Its shame this issue doesnt get adressed. We are still having to use workaround otherwise our app would be unusable for lot of our clienta who use it with external keyboard. And no its not web app. Its native ios app.

@ioma8  What workaround are you doing? We're a little out of solutions and with all the time that passed, it's costing us in terms of credibility.

No, this is a native app on iOS, with an external keyboard.

The same issue also exists on native Android apps, but afaik web apps are fine.

Its shame this issue doesnt get adressed. We are still having to use workaround otherwise our app would be unusable for lot of our clienta who use it with external keyboard. And no its not web app. Its native ios app.

@ioma8 What workaround are you doing? We're a little out of solutions and with all the time that passed, it's costing us in terms of credibility.

@matehat we are using the solution suggested in one of the previous comments: https://pub.dev/packages/dead_keys

Its shame this issue doesnt get adressed. We are still having to use workaround otherwise our app would be unusable for lot of our clienta who use it with external keyboard. And no its not web app. Its native ios app.

@ioma8 What workaround are you doing? We're a little out of solutions and with all the time that passed, it's costing us in terms of credibility.

@matehat we are using the solution suggested in one of the previous comments: https://pub.dev/packages/dead_keys

Ironically, I wrote that package but it doesn't work for my use case. I'm still waiting for a definitive platform fix.

Any news on this bug? it really affects users from places like Spain

@localboss-git czech people also really strugle due to this. Flutter team is highly understaffed, so even new community fork of Flutter out of that desperation. I will probably switch there later: https://flutterfoundation.dev/blog/posts/we-are-forking-flutter-this-is-why/

@localboss-git czech people also really strugle due to this. Flutter team is highly understaffed, so even new community fork of Flutter was created out of that desperation. I will probably switch there later: https://flutterfoundation.dev/blog/posts/we-are-forking-flutter-this-is-why/

Wow, this is a tough decision, but I fear it won't succeed as it's nearly impossible to keep the two codebases synced as they could take different paths in key areas. But I agree, issues like this have been opened since a very long time and it's likely they'll be never fixed. Fingers crossed.

Is there any way to push this issue or increase its visibility for the Flutter team? It's hard to explain to the customer that after 4 years he should keep waiting a few more years for Google to fix the problem :(

I fear, unless you implement it yourself and know someone at Google who'll then merge the PR for you, there is little chance of this basic feature to ever make it into flutter.
We gave up flutter because of this.


[Xcode] enables Swift 2.3 support; fixes Xcode 8 compilation

Adjusts the build settings for "Use Legacy Swift Language Version":
 + SWIFT_VERSION = 2.3;

Resolves #99

> Note: for Xcode 7 users, this setting is ignore and listed under "User Defined".

Thank you!


[JOSS Review] Typo in references

Please fix the typo in the last reference listed in the JOSS paper (DOI link).
Also, please provide the reference for HAWC2 mentioned in line 42 of the paper.

cf: JOSS-6838

Hi @paroomk, thank you for the comments. I updated the references and recompiled the article on our submission. Please confirm the changes so I can close the issue.

Hi @alizma, references look good now. Thanks!


Fibers + Cancellation

What was here is no longer relevant.

We currently only see async and await as at the edge, where cancelation is less important. However, this is something we've extensively discussed that is currently missing.

For future reference: We're looking into cancellation support with #20.


Release notes for v2.1.0-beta.20180904

For https://github.com/cockroachdb/cockroach/issues/29164.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cf49c51cd7dee48301fa526bbc5d77d14a3f7b35/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e3109580f908d54eddbd6512418164cd8d0dbdf5/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9cd6f24de9448150e1629061c7427b811fd75ce5/

releases/v2.1.0-beta.20180904.md, line 46 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
The PR to hide all the parts we don't want to expose to users didn't make it into this beta, so we may want to save this note for next week

Done.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c5c02ca3109d6ccb55e4c447fc5085939938491f/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/60d6103d4fa646d010d1dc30f195050086b08bae/


NovaWallet bugs

Seems that recently there were several bugs reported with NovaWallet/mobile experience, let's track them here and get mobile back on track

https://github.com/kodadot/nft-gallery/issues/3623
https://github.com/kodadot/nft-gallery/issues/3624
https://github.com/kodadot/nft-gallery/issues/3626

continue #7970


[Deps] update tsconfig-paths

Security fix.
See https://github.com/dividab/tsconfig-paths/pull/197
Weaknesses CWE-1321
CVE ID CVE-2021-44906

Minimist <=1.2.5 is vulnerable to Prototype Pollution via file index.js, function setKey() (lines 69-95).

(This currently triggers cascade alerts in many packages using eslint-plugin-import)

This is fine, but also 100% unnecessary, because it's using a semver range. Reinstall eslint-plugin-import and you'll get an updated copy of all its transitive deps.

This is fine, but also 100% unnecessary, because it's using a semver range. Reinstall eslint-plugin-import and you'll get an updated copy of all its transitive deps.

I removed eslint-plugin-import, yarn installed (minimist 1.2.0 went away), installed eslint-plugin-import and the bad version of minimist was back as a dep of<EMAIL_ADDRESS>Reinstalling doesn't seem to work.

I can't speak to yarn, but npm would properly update it since json5 uses ^ (https://unpkg.com/browse/json5@1.0.1/package.json).

This was updated in 0e80ee37c, so, closing this PR.


Adds performance improvement for RedisRateLimiter

Fixes #108

Coverage increased (+0.5%) to 97.838% when pulling c80a00e535fdfce7c6ed7b4c0ba6d09f4d69b568 on ghs-108 into ed1dfd7ba83f4f10ff84e2e4da333caac5f90cc6 on master.


python.version in restmap.conf.spec does not render choices due to curly braces { }

The python.version setting in restmap.conf.spec has curly braces around the choices.  The extension does not render the choices due to the braces.
python.version = {default|python|python2|python3}

Addressed in v0.2.8