SEGFAULT in grpc_core::RefcountedMdBase::hash

What version of gRPC and what language are you using?
1.39
What operating system (Linux, Windows,...) and version?
BSD12
What runtime / compiler are you using (e.g. python version or version of gcc)
clang version 10.0.1
What did you do?
initalmetadata array passed to grpc_call_start_batch.
shutdown of cq usinggrpc_completion_queue_shutdown.
draining cq using grpc_completion_queue_next.
Deletion of grpc call usinggrpc_call_unref
Deltion of Initial metadata array using grpc_metadata_array_destroy.
What did you expect to see?
No Core
What did you see instead?
Segfault and valgrind pointing Invalid read
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
BT
#0  grpc_core::RefcountedMdBase::hash (this=0x5a5a5a58) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/transport/metadata.h:239
#1  grpc_mdelem_unref (gmd=...) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/transport/metadata.h:390
#2  grpc_metadata_batch_destroy (batch=0x2461b44) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/transport/metadata_batch.cc:93
#3  0x0188ac43 in post_batch_completion (bctl=0x2462060) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/surface/call.cc:1189
#4  finish_batch_step (bctl=0x2462060) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/surface/call.cc:1254
#5  0x0188a4ac in receiving_initial_metadata_ready (bctlp=0x2462060, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/surface/call.cc:1526
#6  0x018322bd in grpc_core::Closure::Run (location=..., closure=0x2461ef8, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/closure.h:245
#7  grpc_core::ClientChannel::CallData::RecvInitialMetadataReadyForConfigSelectorCommitCallback (arg=0x2461f90, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/ext/filters/client_channel/client_channel.cc:2287
#8  0x018d8a90 in grpc_core::Closure::Run (location=..., closure=0x2462024, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/closure.h:245
#9  recv_initial_metadata_ready (user_data=0x3c9e098, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/ext/filters/http/client/http_client_filter.cc:205
#10 0x018d93a3 in grpc_core::Closure::Run (location=..., closure=0x3c9e1b0, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/closure.h:245
#11 grpc_core::(anonymous namespace)::CallData::OnRecvInitialMetadataReady (arg=0x3c9e2d0, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/ext/filters/http/message_compress/message_decompress_filter.cc:165
#12 0x019b65f2 in exec_ctx_run (closure=0x2, error=0x0) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/exec_ctx.cc:43
#13 grpc_core::ExecCtx::Flush (this=0x25a5f00) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/exec_ctx.cc:165
#14 0x01999c10 in grpc_core::Executor::RunClosures (executor_name=0x16d0961 "default-executor", list=...) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/executor.cc:130
#15 0x01999f17 in grpc_core::Executor::ThreadMain (arg=0x21ba060) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/iomgr/executor.cc:248
#16 0x019b608a in grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void ()(void), void*, bool*, grpc_core::Thread::Options const&)::{lambda(void*)#1}::operator()(void*) const (this=, v=) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/gprpp/thd_posix.cc:140
#17 grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void ()(void), void*, bool*, grpc_core::Thread::Options const&)::{lambda(void*)#1}::__invoke(void*) (v=0x21e0200) at ../../../../../../../../src/external/apache2/grpc/dist/src/core/lib/gprpp/thd_posix.cc:110
#18 0x01f372f2 in thread_start (curthread=0x2169300) at /src/lib/libthr/thread/thr_create.c:292
Valgrind
==23804== Invalid read of size 4
==23804==    at 0x8A2FD67: grpc_metadata_batch_destroy(grpc_metadata_batch*) (metadata_batch.cc:93)
==23804==    by 0x894BC42: post_batch_completion (call.cc:1189)
==23804==    by 0x894BC42: finish_batch_step(batch_control*) (call.cc:1254)
==23804==    by 0x894B4AB: receiving_initial_metadata_ready(void*, grpc_error*) (call.cc:1526)
==23804==    by 0x88F32BC: Run (closure.h:245)
==23804==    by 0x88F32BC: grpc_core::ClientChannel::CallData::RecvInitialMetadataReadyForConfigSelectorCommitCallback(void*, grpc_error*) (client_channel.cc:2287)
==23804==    by 0x8999A8F: Run (closure.h:245)
==23804==    by 0x8999A8F: recv_initial_metadata_ready(void*, grpc_error*) (http_client_filter.cc:205)
==23804==    by 0x899A3A2: Run (closure.h:245)
==23804==    by 0x899A3A2: grpc_core::(anonymous namespace)::CallData::OnRecvInitialMetadataReady(void*, grpc_error*) (message_decompress_filter.cc:165)
==23804==    by 0x8A775F1: exec_ctx_run (exec_ctx.cc:43)
==23804==    by 0x8A775F1: grpc_core::ExecCtx::Flush() (exec_ctx.cc:165)
==23804==    by 0x8A5AC0F: grpc_core::Executor::RunClosures(char const*, grpc_closure_list) (executor.cc:130)
==23804==    by 0x8A5AF16: grpc_core::Executor::ThreadMain(void*) (executor.cc:248)
==23804==    by 0x8A77089: operator() (thd_posix.cc:140)
==23804==    by 0x8A77089: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void ()(void), void*, bool*, grpc_core::Thread::Options con
st&)::{lambda(void*)#1}::__invoke(void*) (thd_posix.cc:110)
==23804==    by 0x91212F1: ??? (in /packages/mnt/os-libs-compat32-12/usr/lib32/libthr.so.3)
==23804==  Address 0xba6c914 is 36 bytes inside a block of size 156 free'd
==23804==    at 0x73EBCC8: free (src/paul-floyd-317-fbsd12/valgrind-freebsd/coregrind/m_replacemalloc/vg_replace_malloc.c:602)
==23804==    by 0x8A8AEB7: gpr_free (alloc.cc:52)
==23804==    by 0x89C4617: grpc_metadata_array_destroy (metadata_array.cc:35)
==23804==    by 0x7F15EF1: GrpcCall::~GrpcCall() (GrpcCall.cc:1344)
==23804==    by 0x91212F1: ??? (in /packages/mnt/os-libs-compat32-12/usr/lib32/libthr.so.3)
==23804==  Block was alloc'd at
==23804==    at 0x73EAB42: malloc (src/paul-floyd-317-fbsd12/valgrind-freebsd/coregrind/m_replacemalloc/vg_replace_malloc.c:311)
==23804==    by 0x8A8AE5C: gpr_malloc (alloc.cc:32)
==23804==    by 0x7F13A66: GrpcCall::GrpcSendInitialMetadata(grpc_client_info_s*, std::__1::map<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator<char

, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits, std::__1::all
ocator > >, std::__1::allocator<std::__1::pair<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const, std::__1::basic_string<char, std
::__1::char_traits, std::__1::allocator > > > >*) (GrpcCall.cc:303)

Anything else we should know about your project / environment?

Clarification of the statement is not enough. You should explain more and after that we think more on the problem.

The version that you are using is pretty old. The code has seen a lot of changes and I don't think that branch is going to see any fixes. Can you please using the latest version and see if the issue still persists?
(I'll also note that you're using BSD. I'm not sure if that might be a factor here but just something to keep in mind.)

Ok I will try to reproduce on 1.52 with asan enabled image.


fix some tag errors in horizon

Operations and Payments tags weren't present, or were improperly defined.

Preview is available here:http://developers-pr802.previews.kube001.services.stellar-ops.com


Windows error LNK2019: unresolved external symbol

I was getting this error when build in Windows:
error LNK2019: unresolved external symbol "public: class b2Joint * __cdecl b2World::CreateJoint(class b2JointDef const *)"
As you can see in this job: https://github.com/supernovaengine/supernova/actions/runs/5994348679/job/16255853451
I discovered the problem was in b2JointDef. After changed include order in box2d.h, putting joints before body, it worked. I don't know why.
#include "b2_distance_joint.h"
#include "b2_friction_joint.h"
#include "b2_gear_joint.h"
#include "b2_motor_joint.h"
#include "b2_mouse_joint.h"
#include "b2_prismatic_joint.h"
#include "b2_pulley_joint.h"
#include "b2_revolute_joint.h"
#include "b2_weld_joint.h"
#include "b2_wheel_joint.h"

#include "b2_body.h"
#include "b2_contact.h"
#include "b2_fixture.h"
#include "b2_time_step.h"
#include "b2_world.h"
#include "b2_world_callbacks.h"

Linux and Mac are ok in any order.

Closing out v2 issues since it is no longer supported.


v0.8.0-rc3 build error: Checksum mismatch for btcd

Background
I'm trying to build v0.8.0-rc3 with this command:
make && make install tags="signrpc walletrpc chainrpc invoicesrpc routerrpc watchtowerrpc"
however i get this error message:
go: downloading github.com/btcsuite/btcd v0.20.0-beta
verifying<EMAIL_ADDRESS>checksum mismatch
	downloaded: h1:PamBMopnHxO2nEIsU89ibVVnqnXR2yFTgGNc+PdG68o=
	go.sum:     h1:DnZGUjFbRkpytojHWwy6nfUSA7vFrzWXDLpFNzt74ZA=
 Building debug lnd and lncli.
GO111MODULE=on go build -v -tags="dev" -o lnd-debug -ldflags "-X github.com/lightningnetwork/lnd/build.Commit=v0.8.0-beta-rc3" github.com/lightningnetwork/lnd/cmd/lnd
go: downloading github.com/btcsuite/btcd v0.20.0-beta
verifying<EMAIL_ADDRESS>checksum mismatch
	downloaded: h1:PamBMopnHxO2nEIsU89ibVVnqnXR2yFTgGNc+PdG68o=
	go.sum:     h1:DnZGUjFbRkpytojHWwy6nfUSA7vFrzWXDLpFNzt74ZA=
make: *** [Makefile:92: build] Error 1

I am able to build the v0.8.0-rc2 version successfully. Are any one else experiencing this?
Your environment

version of lnd: v0.8.0-rc3
which operating system: Linux raspibolt 4.18.0-17-generic #18-Ubuntu SMP Wed Mar 13 14:34:40 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
version of btcd, bitcoind, or other backend: btcd v0.20.0-beta

go version go1.12.4 linux/amd64
Maybe this is related to the new modules in 1.13?

can you try with either 1.12.9 or go1.13.1?

I can try this on Friday. Currently i got it working with rc2 and do not have time to mess up my node now before a demonstration tomorrow :p I'll get back to this on friday.

I get this issue build 0.18.1 as well
verifying<EMAIL_ADDRESS>checksum mismatch
	downloaded: h1:PamBMopnHxO2nEIsU89ibVVnqnXR2yFTgGNc+PdG68o=
	go.sum:     h1:DnZGUjFbRkpytojHWwy6nfUSA7vFrzWXDLpFNzt74ZA=
```g

I have go version go1.12.9 linux/amd64 and having the same issue

Also tried building the tag commit 73ceb9a06eb19e727a9e6cf140bda8924df977eb (HEAD, tag: v0.8.0-beta), same error.
How did you guys release if it can't build?  🤔

I'm having the same error: checksum mismatch for btcd. Also, can confirm I didn't have it with rc2 (I have double checked).
I'm building a Docker container for testing with golang:1.12-alpine as builder

@gustavonalle  Try go clean -modcache. Also, make sure all older Go versions have been purged from your system.
@sergioabril  You need go1.13.1.  Make sure to delete all older go versions in your system or the problem won't be solved.  There're important changes in RC3 which is the final version, so forget RC2. and you should get the final version which has been released and named v0.8.0-beta

@molxyz yep, can confirm that building Docker image with golang:1.13.1-alpine did the trick.
Running v.0.8.0-beta

You need go 1.13.1 as mentioned in the release notes.

Same issue on go 1.13.3

@anilCSE Try using lnd v0.8.1-beta


Allow guest checkout URLs and form actions

Description
Currently, the Checkout::getCheckoutUrl() method and the CheckoutController::actionCheckout() endpoint both require that there be an actual Craft user to generate the session.
This PR updates the functionality to allow guest checkouts via the service method and controller action.
Due to the nature of how the method arguments are set it is a bit odd having to pass false, this is because currently, we are treating null as somewhat of a fallback which will try and seek out the user.

Closing in favour of https://github.com/craftcms/stripe/pull/9


Handle multiple levesl of substitutions and indexed accesses in getActualTypeVariable

Fixes #49556
#48837 added a special case to getConditionalFlowTypeOfType that adds an extra constraint of number | `${number}` to K in a homomorphic mapped type like { [K in keyof T]: XXX } when T is a tuple. This resulted in a substitution within the indexed access to account for the constraint.
getActualTypeVariable was already equipped to handle a substitution within an indexed access, so most things worked fine. All good so far.
However, in inference, we end up with the opposite; there's an indexed access within a substitution, but getActualTypeVariable didn't handle that case.
So, let getActualTypeVariable recurse on substitutions too, which allows the code in #49556 to continue working as it did before TS 4.7.

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this


Planner datatable

@sanbornsen fabric8/fabric8-ui:SNAPSHOT-PR-2357-10 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2357-fabric8-planner.badger.fabric8.io

@sanbornsen fabric8/fabric8-ui:SNAPSHOT-PR-2357-13 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2357-fabric8-planner.badger.fabric8.io

@sanbornsen fabric8/fabric8-ui:SNAPSHOT-PR-2357-14 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2357-fabric8-planner.badger.fabric8.io

@sanbornsen fabric8/fabric8-ui:SNAPSHOT-PR-2357-16 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2357-fabric8-planner.badger.fabric8.io

@sanbornsen Sort by asc and desc is not working for attribute Label and Type. Is this intended behaviour or bug

In the setting dropdown, if we select any of the displayed attribute and click on say, Move to bottom. Then the column disappears from the table view(moved to available attribute)

Cancel in the setting dropdown  is not working.

@Raunak1203 I have addressed your comments in latest changes. Sort by asc and desc should be working only for title columns (not others).

@sanbornsen @sahil143 I believe not all comments could be addressed as part of this PR. Kindly let me know as such and I'll then track them via separate defects.


Repositories Example

I was looking at the Repositories Example, and i dont see how TenantScope is being called so Repository is able to call $this->applyTenant().

It doesn't ever get called in any Repository. When you add the Trait on a Model, Laravel's global scoping picks up the boot method and registers the $extensions in TenantScope. This makes methods like applyTenant and the other extensions available throughout your app anytime you resolve a Model's (with the Trait) Repository out of the container.
Note, that you would never need to call applyTenant unless you wanted to override the current Tenant id set, since applyTenant is called automatically on boot. If you are trying to "scope" an non-scoped Model, you would just use the whereTenant method, which has nothing to due with the package, but is just a normal where clause constraint on the query.


Support older versions of Bash

Slurm submission scripts written by Parsl 0.7 use the Bash builtin command 'wait' with the -n option. I believe this option was introduced in a relatively recent version of Bash, perhaps 5.0 Many of the systems at my organization run Redhat Enterprise Linux 7, which uses Bash-4.2. This version of bash does not recognize the -n option to wait, and the script errors out.
Please consider implementing the slurm submission script without using wait -n to improve compatibility with older versions of bash, which I imagine are still in common use.

Hi @jadamstephens, could you try switching to the latest parsl version (v1.0.0)? In the latest version I do not see wait being used with the SlurmProvider+SrunLauncher combination. If you still have issues, please share a tarball of your runinfo directory.

A quick skim doesn't show me wait -n in 0.7.0 either, though, so I'm unclear where the -n is coming from for you. Can you attach a full submission script that has this in it?

Hi,
I wrongly assumed that I was using 0.7 based on some instructions that are probably now outdated. It looks like I did install 1.0.
Anyway, this line in launchers/launcher.py seems to be the source of the wait command in the slurm submission script.
I'm encountering this issue when running example.py using the command:
python3 example.py --fileconfig=blake --count=10 --example=tasks

(I modified cori.py to use on a machine here named blake.)

OK. That line isn't in 1.0.0, but was introduced into master in PR #1724. So I guess you've actually installed the latest master, not 1.0.0 (although it likely claims to be 1.0.0).

tagging @hategan because that's some code he's been working on recently

You're right. I did clone master. I checked out and installed the 1.0.0 tag and now it's working. Even so, since the change is on master, my feature request stands :)

Didn't realize that "-n" was v5 and up. I very much agree that currently-in-use versions of bash should be supported.


Allow access to media dir for consumption

I would like to use a network folder that is mapped into HA under /media/ as consumption dir. I think the only thing missing for that is adding "media:rw" to the map section in the config.json.
I have implemented & tested this in my version of the addon (see https://github.com/torfbolt/paperless-home-assistant-addon/commit/95bfd627c8bf3caca8b4ada9a43386886d44bdfe), but I would like to switch to your version so I can use the ingress feature.
I also looked at the solution proposed in https://github.com/BenoitAnastay/paperless-home-assistant-addon/issues/120 for storing the paperless-media folder in a different location, but the existing HA internal solution for mounting to /media/ looks much easier and more robust to me.

The actual workaround is to use Samba share addon and mount the share with paperless name.
I prefer to avoid giving add-ons too much access to the host

Ok, looks like HA has improved since the last time I tried this and you can now natively mount a network folder into /share/, not only into /media/

Indeed


Shortening release notes in module manifest (For release <IP_ADDRESS>)

Release notes in the module manifest are limited to 10,000 characters when publishing to the PowerShell Gallery.

This change is

Codecov Report

Merging #572 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #572   +/-   ##
=====================================
  Coverage      74%    74%
=====================================
  Files          27     27
  Lines        4030   4030
  Branches        4      4
=====================================
  Hits         3009   3009
  Misses       1017   1017
  Partials        4      4


[Bug] Current version is not showing in beta releases

I think we discussed this before, but now as I am testing v5.0.2 vs. v5.0.3 it is crucial to be able to differentiate between the version. Right now, both show this:

-- which makes it difficult to figure out what is the current version ...
Let me know what you think.
Thanks!

This is not a bug.
As I mentioned before, the About popup shows for only the production release, not for the beta version. Because I don't plan to take the beta version to the store (chocolatey or winget), so I thought the showing for the beta version is redundant.
However, the differentiability between the production release and beta is needed, so I'll add a fourth version and treat it as an implicit TAG version. But, the top three will continue to handle as MAJOR.MINOR.PATCH as before.

Conventional version format

MAJOR.MINOR.PATCH

New version format

MAJOR.MINOR.PATCH.TAG

Thanks.

I released the beta4 including this change, please try it.
https://github.com/pit-ray/win-vind/releases/tag/v5.0.0-beta4


Chore add renovate

close https://github.com/rust-lang/bors/issues/122
This very simple configuration does 99% of what we need I think :)
Tested here 👍
If you see the PRs of the repository you can see what renovate does. It's free to use (there's no paid plan) 👍
I'm using the hosted version of renovate as https://github.com/rust-lang/crates.io does.
I'm not sure which account we should use to add the GitHub app and authenticate into https://developer.mend.io/
We can ask the crates.io team how they do this if we have doubts.
Ideally everyone in the infra-bors team should be able to access the renovate dashboard. But I guess we can fix this issue later? Also, you can control renovate by checking the boxes in the Dashboard issue 👍
The dashboard looks like this:

After merging this PR we need to install the renovate app in this repo via the team repo I guess.

We already have support for renovatebot in team (https://github.com/rust-lang/team/blob/7922f9bd1b0126b4fa403d313694f91e450f200d/repos/rust-lang/cargo.toml#L5), where we can install the renovatebot app to selected repositories. Is both the config file and the GitHub app installation needed?

sync-team only installs the GitHub app.
From my understanding, if the configuration is missing, we will get a PR from renovate that adds it. Explained here.
I created https://github.com/rust-lang/team/pull/1539
We can:

Merge https://github.com/rust-lang/team/pull/1539
Wait for renovate to open the configuration pr
Check how the default configuration looks like
Merge this PR if we aren't satisfied with it 👍

What do you think?

Here's the generated pr
https://github.com/rust-lang/bors/pull/128


reverse works destructively

function reverse modifies original array since it calls Javascript's destructive reverse.
I don't know if it's Intentional behavior or not, I think it's not Lisp-ish.
reproducible code;
(def array [0 1 2])
(reverse array)
(prn array) ;; [2 1 0]

Thank you for the issue. I also fixed sort function as well :)
細かい所レビューしてくださって本当に勉強になります…。マジで嬉しいです...!


Package status is not updated for days/weeks

Hi,
I know that there are many packages to test, and limited hardware available, but would it be possible to increase the frequency with which packages are tested? E.g. by triggering tests based on METADATA updates?
It would give the Julia community a more realistic view of which packages are broken and which are not.
Best regards,
Jesper

It'll be updated later today


Done


fix: Fix rendering error when clickhouse files are specified

If trying to render clickhouse with the following
helm template charts/clickhouse -f broken-values.yaml

and the values.yaml
files:
  config.d/log_rotation.xml: |
    <clickhouse>
      <logger>
        <level>xxx</level>
        <console>true</console>
        <errorlog>/var/log/clickhouse-server/clickhouse-server.err.log</errorlog>
        <log>/var/log/clickhouse-server/clickhouse-server.log</log>
        <size>100M</size>
        <count>10</count>
      </logger>
    </clickhouse>

helm unindentds and break the output yaml
coalesce.go:175: warning: skipped value for zookeeper.initContainers: Not a table.
Error: YAML parse error on clickhouse/templates/clickhouse-instance/clickhouse-instance.yaml: error converting YAML to JSON: yaml: line 77: could not find expected ':'

@jaysonsantos Thanks for the fix PR.

I imagined the linting workflow runs checks to find these issues. Isn't there a way to catch them early?

@srikanthccv that is a bit hard because you would need to run helm template at least with a matrix of values to try things on/off

I do not have expertise with this tooling, but I would imagine that to be part of the test strategy it runs checks for formatting errors. I saw a similar one last week where someone had a problem with the pull secrets section because of indentation and the chart not working. I hope it's not naive of me to think there is a better way to deal with issues of this kind.

I imagined the linting workflow runs checks to find these issues. Isn't there a way to catch them early?

@srikanthccv yes, lint workflow catches a lot of similar ones. But there are bunch of those which are only applied upon specific conditions like the value itself being set, enabled boolean flag, or other specific condition.
Right way to go ahead would be to with chart tests which is something we would work on when we have more bandwidth.
Thorough review from the you or anyone else from team would also be helpful.


Adding a base class to use as strong typed reconciler events.

This will allow us to propagate events from the reconcilers easier.
Create wrapper functions like:
func WarnSomeReason(msgf string, args ...interface{}) error {
	reconciler.NewReconcilerEvent(corev1.EventTypeWarning, "SomeReason", msgf, args...)
}

Use from a reconciler like:
if somethingBad {
  return WarnSomeReason("this was bad")
}

And then use the returned error inside the bigR reconciler like:
var event *ReconcilerEvent
if errors.As(err, &event) {
	recorder.Event(resource, event.EventType, event.Reason, event.Format, event.Args...)
}

/assign @mattmoor

/hold
still validating

What confuses me is that the corev1 events types are warnings & info - so returning them as errors is interesting.

Yeah it is a little bit of an abuse, but it works really well I think for this usecase.

Secondly, should the ReconcilerEvent support wrapping errors?

Wrapping is supported by using %w in the format and passing an error. Ah but I see... Let me fix...

Wrapped errors now supported and test added.

/hold cancel

/hold
Gonna work this to be returning an interface ReconcilerResult rather than an error

ok reworked, Please take another look.
/hold cancel

How about implementing the change in pkg/controller already so we can see the bigger picture?

LG in general, but I think you want to tweak the title a bit. It makes no sense to me now :)

LG in general, but I think you want to tweak the title a bit. It makes no sense to me now :)

done.

/approve

ok @vagababov fixed it for us.


POST response does not return correct path when creating public link

Describe the bug
Creation of a public link: the POST request does not return the path to the item.
Steps to reproduce
Steps to reproduce the behavior:

Create a public link to item that is not placed in root folder, for example item /A/land2.jpg. Following curl request will help:

curl -k -u user1:xx
-H 'User-Agent:Mozilla/5.0 (Android) ownCloud-android/3.0-beta.2'
-H 'Content-Type:application/x-www-form-urlencoded'
-X POST 'https://xx.xx.xx.xx:9200/ocs/v2.php/apps/files_sharing/api/v1/shares?format=json'
--data-binary 'path=/A/land2.jpg&shareType=3&permissions=1&name=link1'

Expected behavior
path field in POST response containing the path to the item:  "path":"/A/land2.jpg",
Actual behavior
path field in POST response does not contain the path:
{
   "ocs":{
      "meta":{
         "status":"ok",
         "statuscode":200,
         "message":"OK"
      },
      "data":{
         "id":"fNrugBtjyVzaGnf",
         "share_type":3,
         "uid_owner":"user1",
         "displayname_owner":"Perez",
<EMAIL_ADDRESS>         "permissions":1,
         "stime":1669628641,
         "parent":"",
         "expiration":"",
         "token":"wKqmsitvMoSnEJB",
         "uid_file_owner":"user1",
         "displayname_file_owner":"Perez",
<EMAIL_ADDRESS>         "state":0,
         "path":"/land2.jpg",  <============= MISSING PATH
         "item_type":"file",
         "mimetype":"image/jpeg",
         "storage_id":"shared::/land2.jpg",
         "storage":0,
         "item_source":"652fc57c-8044-43e8-9a7a-3b0a8a40689c$affb1013-b397-42f3-afe8-31295c4a2235!19d43b6f-19e1-499c-b243-dd91f1eefc90",
         "file_source":"652fc57c-8044-43e8-9a7a-3b0a8a40689c$affb1013-b397-42f3-afe8-31295c4a2235!19d43b6f-19e1-499c-b243-dd91f1eefc90",
         "file_parent":"652fc57c-8044-43e8-9a7a-3b0a8a40689c$affb1013-b397-42f3-afe8-31295c4a2235!98a20954-c44c-40a0-a178-12b02c67a448",
         "file_target":"/land2.jpg",
         "share_with_user_type":0,
         "share_with_additional_info":"",
         "mail_send":0,
         "name":"link1",
         "url":"https://xx.xx.xx.xx:9200/s/wKqmsitvMoSnEJB"
      }
   }
}

this is causing a problem in mobile clients: When public link is created, it is not reflected till parent folder is refreshed.
Setup
Container created with the following docker-compose file:
version: "3.7"

services:
  ocis:
    image: owncloud/ocis:2.0.0-rc.2
    ports:
      - 9200:9200
      - 9215:9215
    environment:
      OCIS_INSECURE: "true"
      OCIS_URL: "https://xx.xx.xx.xx:9200"
      IDM_CREATE_DEMO_USERS: "true"
      IDM_ADMIN_PASSWORD: "admin"
      PROXY_ENABLE_BASIC_AUTH: "true"
    restart: "no"
    entrypoint:
      - /bin/sh
    # run ocis init to initialize a configuration file with random secrets
    # it will fail on subsequent runs, because the config file already exists
    # therefore we ignore the error and then start the ocis server
    command: ["-c", "ocis init || true; ocis server"]

Additional context
Problem does not happen in oC10, where the path field contains the correct path.

some remarks: clients should be sending a space property together with a path relative to the space. This was introduced with https://github.com/cs3org/reva/pull/2913

We decided to deprecate the parameter "space_ref". We decided to use
"space" parameter instead. The difference is that "space" must not contain
a "path". The "path" parameter can be used in combination with "space" to
create a relative path request

for the space id we accept
// The accepted formats are:
// <providerid>$<spaceid>!<nodeid> 	-> <providerid>$<spaceid>, <nodeid>
// <providerid>$<spaceid>		-> <providerid>$<spaceid>, <spaceid>
// <spaceid>				-> <spaceid>, <spaceid>

Now for the path in the response we see that when listing public links the path does contain the parent folders ... we need to check why the create response does not contain them.

@butonic Currently, the iOS client uses the File ID as space_ref. Can it also just pass that to space - or should it pass only the space id?
If it should pass only the space id, that will be a challenge due to #5355 still unsolved.

@felix-schwarz See the examples above. you can provide anything from a complete resourceID to a single spaceID.

any ETA for this fix?

Since getting the path is an expensive operation and might leak data I only added it for the POST public link case. Let me know if other endpoints are also affected.
fix is here https://github.com/cs3org/reva/pull/4004 needs a reva bump after merge


[-] Error 403 : Request Blocked by haveibeenpwned API

@hedin-hiervard you must have got the response body, if you are on the latest version, Send it to the email address i have given above the response body

Sorry, I don't see any emails.

@hedin-hiervard looks like you are on an older version, try this
cd pwnedOrNot
git pull
now execute it, i hope it works for you otherwise now you will get the full response body and email address

Same issue. How to fix it? Does haveibeenpwned blocked against in Russia? Does VPN help in this case?


Enable softdog in case the user provided watchdog doesn't exist

softdog provides better reliability comparing to software reboot
This PR tries to enable softdog in case the user provided watchdog doesn't exist

/retest


CiviForm has unknown unit test coverage

We estimate our level of unit test coverage to be poor, but do not have a metric yet since we do not have a unit test code coverage tool. We should investigate a good open source option and add it.

I'll look into setting up https://about.codecov.io/product/features/


Issue I found when using GUI r

The issue is with the Keyboard.press("r");
the r should be in single quotations like Keyboard.press('r');.
Using the double quotations caused every icon on my desktop
to continuously open untill I unplugged the Arduino.
Input code:
DELAY 3000
GUI r
DELAY 500
STRING notepad
DELAY 500
ENTER
DELAY 750
STRING Hello World!!!
ENTER

Output code:
/**
 * Made with Duckuino, an open-source project.
 * Check the license at 'https://github.com/Nurrl/Duckuino/blob/master/LICENSE'
 */

#include "Keyboard.h"

void typeKey(uint8_t key)
{
  Keyboard.press(key);
  delay(50);
  Keyboard.release(key);
}

/* Init function */
void setup()
{
  // Begining the Keyboard stream
  Keyboard.begin();

  // Wait 500ms
  delay(500);

  delay(3000);
  Keyboard.press(KEY_LEFT_GUI);
  Keyboard.press("r");
  Keyboard.releaseAll();

  delay(500);
  Keyboard.print(F("notepad"));

  delay(500);
  typeKey(KEY_RETURN);

  delay(750);
  Keyboard.print(F("Hello World!!!"));

  typeKey(KEY_RETURN);

  // Ending stream
  Keyboard.end();
}

/* Unused endless loop */
void loop() {}

Hi @ITHzWANip, are you sure that when you change "r" to 'r', the bug doesn't happen ?
What you're explaining make me think more about an Arduino power issue, like rebooting continuously and spamming <enter>...

yea i would screen cap it but for whatever reason when i have my recording software up it wont replicate. But I've tested it multiple times and 'r' works over "r" every time. My theory was that any press needs to be in single quotes but that was not reliable in my testing. It might just be the board im using. Its the pro micro.

I noticed the double quotes are passed in the keyArray parameter of the module's computeKeys callback. For the Digispark module I already needed to strip these double quotes, as characters need to be converted to constants ( 'a' becomes KEY_A, etc.) Would it be an idea to omit the double quotes and have the board module decide how to format the character?

@nixublx Yep I'll do that ^^

For the v2.1, and I'll make per module locale selection by merging LocaleKeyboard.js in Duckuino ^^
@Plazmaz Do you agree with these changes ?

@Nurrl Yep, sounds good

@Plazmaz Great ^^


Fix 23h for energinet and flat polyfill.

Resolves https://github.com/tmrowco/tmrow/issues/3483

I think you can use [].concat(...array):
https://medium.com/@mwalterspieler_31762/es6-flatten-an-multi-dimensional-array-bfc6abb930c

Is the "flatten" part supposed to be committed? Doesn't seem like it's used anywhere, right?

Found a work around (remembered about the beautiful existence of lodash!) I am currently testing it
The flatten part is a polyfill, .flat is still experimental in JS so sometimes it works, sometimes it does not

@madsnedergaard this will need to be merged before running the integration on production for bloom


enable previously disabled VM tests

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
d536e0e7336aaaf61ada71e13046802743fcae9e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
d536e0e7336aaaf61ada71e13046802743fcae9e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-mc-k8s-tests_istio
d536e0e7336aaaf61ada71e13046802743fcae9e
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
d536e0e7336aaaf61ada71e13046802743fcae9e
link
/test integ-telemetry-mc-k8s-tests_istio

integ-pilot-multicluster-tests_istio
87ff88fda972529054adf438f614375a528b8210
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Bump Go versions and use '.x' to always get latest patch versions

@iawia002 Thanks for a quick merge! 😃


Export published app's package from API fails. ERROR using an unsupported compression method

Export published app's package from API gives me a file that fails when the container tries to read it. It says
fail: Luis[0]
      Failed while prefetching App: AppId: {APP_ID} - Slot: {APP_ENVIRONMENT} The archive entry was compressed using an unsupported compression method.

If I Export published app package from LUIS portal it works perfectly, so it seems that the API does something internally that corrupt the file.
I have tried with mac and linux, and I'm using this command
curl -X GET \
https://{LOCATION}.api.cognitive.microsoft.com/luis/api/v2.0/package/{APP_ID}/slot/{ENV}/gzip  \
 -H "Ocp-Apim-Subscription-Key: {MY_KEY}" \
 -o {APP_ID}_{ENV}.gz

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc19d2e0-5960-c165-083c-a9dcf9976c91
Version Independent ID: 58d32965-6909-2461-5158-aa66d904bf3c
Content: Docker containers - Language Understanding - Azure Cognitive Services
Content Source: articles/cognitive-services/LUIS/luis-container-howto.md
Service: cognitive-services
Sub-service: language-understanding
GitHub Login: @IEvangelist
Microsoft Alias: dapine

@ignacioPastor Thanks for the feedback. We are investigating the issue and will update you shortly.

Hey, @AmirGeorge -- this looks like a dup of #29557. This should either be closed as a duplicate or investigated further. #reassign:AmirGeorge

AmirGeorge
is not a valid GitHub ID, or is not a collaborator on this repo.

Hi @ram-msft ,
Can you please share the LUIS application ID?

@ignacioPastor Can you please share the LUIS application ID.

@ram-msft  here is my LUIS app id e082bb09-8093-4fb4-8978-b21a5830cf61
Please note that I'm dealing with the same issue on the other LUIS app that I've been working with, so from my experience it always fails. I haven't configured anything on the second LUIS app, so maybe thre is something wrong on the command I'm using or in the API
Thanks for your help

@ignacioPastor I took a look at your app and there seems to be nothing corrupt with its state. Can you share your gzip package in this thread? If you have concerns about sharing it here, we can discuss sharing it privately.

Hi @AmirGeorge
This is an app downloaded with the API (Fails with docker container)
e082bb09-8093-4fb4-8978-b21a5830cf61_STAGING.gz
This is an app downloaded manually with the Luis Portal (works nicely)
e082bb09-8093-4fb4-8978-b21a5830cf61_STAGING.gz
Let me know if you need anything else
Thanks for your support

@ignacioPastor great, now I know what the problem is. If you open the first file with a text editor, you will see this error response:
{"error":{"code":"401","message": "Access denied due to invalid subscription key. Make sure to provide a valid key for an active subscription."}}
We will be updating the documentation to avoid this error-prune step.

@ignacioPastor We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Thank you @AmirGeorge, you were right. I'm going to explain here the which was my error in case someone else faces the same problem.
The issue was that my LUIS authorization key was for one location, while my cognitive services subscription was using other location. It happens that an authorization key is bound to a region, and it fails if you try to use other location endpoints.
The -o flag on my curl command was hiding the error (creating a file compressed with the error message instead of showing the error on the console), and the docker error was saying unsupported compression method for the downloaded package, which doesn't help to figure out the real problem.
After being pointed the error on the key, I found this blog quite useful to understand my mistake: https://blogs.msdn.microsoft.com/kwill/2017/05/17/http-401-access-denied-when-calling-azure-cognitive-services-apis/


Verify that all bug fixes for STDP are propagated to GPU code

What kind of issue is this?

[X] Bug report
[ ] Feature request
[ ] Question not answered in documentation
[ ] Cleanup needed

Besides making notes so that all fixes propagate to the master branch (from the single-threaded simulator), they need to also propagate to the GPU code in the single-threaded simulator.
What is affected by this?

How do we replicate the issue/how would it work?

Expected behavior (i.e. solution or outline of what it would look like)

Other Comments

At the master branch, all CUDA_CALLABLE functions are common for both CPU and GPU.

Good point. This issue only applies to the single-threaded branch. FYI, @eeemily17 is documenting her changes in the single-threaded branch so that those mods can be brought to the multi-cluster branch.

Good point. This issue only applies to the single-threaded branch. FYI, @eeemily17 is documenting her changes in the single-threaded branch so that those mods can be brought to the multi-cluster branch.


parser: implement Restore for VariableExpr

Implement Restore and unit test for VariableExpr.
By the way, the literal string of operator EQ should be = instead of ==, which is fixed.
Issue: https://github.com/pingcap/tidb/issues/8532

@kennytm Hi, I want to discuss two problems with you. After changing to WriteName, some tests will fail.

The generated ASTs of select @`a`  and select @a are different.

The AST of select @`a` :
*ast.SelectStmt	&{{{{select @`a`}}} {[]} 0xc00000f590 false <nil> <nil> 0xc00000f5c0 <nil> <nil> [] <nil> <nil> none [] false false}
  *ast.FieldList	&{{} [0xc000056660]}
    *ast.SelectField	&{{`a`} 8 <nil> 0xc0000e6960  false}
      *ast.VariableExpr	&{{{} {0 0 0 0   []} 64} a false false false <nil>}

The AST of select @a:
*ast.SelectStmt	&{{{{select @a}}} {[]} 0xc00000f590 false <nil> <nil> 0xc00000f5c0 <nil> <nil> [] <nil> <nil> none [] false false}
  *ast.FieldList	&{{} [0xc000056660]}
    *ast.SelectField	&{{@a} 7 <nil> 0xc00009caa0  false}
      *ast.VariableExpr	&{{{} {0 0 0 0   []} 64} a false false false <nil>}

So they are not deeply equal to each other. In the unit test function, I have to use @`a`  but not @a as the source SQL text. But the restored SQL text will work.

TiDB doesn't support queries like this while MySQL supports:

tidb> select @@global.`sql_mode`;
ERROR 1193 (HY000): Unknown system variable ''

The AST of select @@global.sql_mode:
*ast.SelectStmt	&{{{{select @@global.sql_mode}}} {[]} 0xc000083500 false <nil> <nil> 0xc000083530 <nil> <nil> [] <nil> <nil> none [] false false}
  *ast.FieldList	&{{} [0xc00007e600]}
    *ast.SelectField	&{{@@global.sql_mode} 7 <nil> 0xc000092aa0  false}
      *ast.VariableExpr	&{{{} {0 0 0 0   []} 64} sql_mode true true true <nil>}

The AST of select @@global.`sql_mode` :
ast.SelectStmt	&{{{{select @@global.`sql_mode`}}} {[]} 0xc000083500 false <nil> <nil> 0xc000083530 <nil> <nil> [] <nil> <nil> none [] false false}
  *ast.FieldList	&{{} [0xc00007e600]}
    *ast.SelectField	&{{} 7 <nil> 0xc000092a00 sql_mode false}
      *ast.VariableExpr	&{{{} {0 0 0 0   []} 64}  true true true <nil>}

As you can see the parse currently doesn't handle such case, so Variable.Name=''. Maybe this syntax should be added, and the test can pass only when it is supported.

@exialin Thanks for the throughout tests. I think both are bugs in the parser. I've filed #94 and #95.
So we have two paths forward:

Use WriteKeyWord instead of WriteName and ignores variables with quoted names, or
Wait until those two issues are fixed

I think we should do (1) (use WriteKeyWord) to avoid blocking this PR on these edge cases. WDYT @tiancaiamao @leoppro

#112 id merged, please resolve conflicts and run test again @exialin

@leoppro PTAL.
Here's one more problem. The name of system variables are converted to lower cases:
https://github.com/pingcap/parser/blob/f4f461469cfddff6693f9a2c65379ff9fc29ea7a/parser.y#L5649-L5651
But user variables are not. So in the test cases, the names have to be case sensitive for user variables, while insensitive for system variables. Should they be consistent?

@leoppro PTAL.
Here's one more problem. The name of system variables are converted to lower cases:
parser/parser.y
Lines 5649 to 5651 in f4f4614
doubleAtIdentifier
{
v := strings.ToLower($1)
But user variables are not. So in the test cases, the names have to be case sensitive for user variables, while insensitive for system variables. Should they be consistent?

it doesn't matter, ignore it will be fine

LGTM,  PTAL @kennytm

@kennytm  PTAL


flutter doctor --android-licenses: ProcessException: The system cannot find the file specified C:\Users\admin\AppData\Local\Android\sdk\tools\bin\sdkmanager.BAT --version

flutter_01.log

Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter doctor --android-licenses
exception
ProcessException: ProcessException: The system cannot find the file specified.
Command: C:\Users\admin\AppData\Local\Android\sdk\tools\bin\sdkmanager.BAT --version
#0      _ProcessImpl._runAndWait (dart:io-patch/process_patch.dart:498:7)
#1      _runNonInteractiveProcessSync (dart:io-patch/process_patch.dart:643:18)
#2      Process.runSync (dart:io-patch/process_patch.dart:68:12)
#3      LocalProcessManager.runSync (package:process/src/interface/local_process_manager.dart:93:20)
#4      _DefaultProcessUtils.runSync (package:flutter_tools/src/base/process.dart:368:50)
#5      AndroidSdk.sdkManagerVersion (package:flutter_tools/src/android/android_sdk.dart:595:43)
#6      AndroidLicenseValidator.runLicenseManager (package:flutter_tools/src/android/android_workflow.dart:314:64)
#7      Doctor.diagnose (package:flutter_tools/src/doctor.dart:243:38)
#8      DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:59:39)
#9      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:615:18)
#10     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
#11     _rootRunUnary (dart:async/zone.dart:1134:38)
#12     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#13     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
#14     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
#15     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#16     Future._completeWithValue (dart:async/future_impl.dart:524:5)
#17     Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7)
#18     _rootRun (dart:async/zone.dart:1126:13)
#19     _CustomZone.run (dart:async/zone.dart:1023:19)
#20     _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#21     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#22     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#23     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#24     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#25     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)

flutter doctor
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version
    6.3.9600], locale en-US)
    • Flutter version 1.12.13+hotfix.5 at C:\flutter
    • Framework revision 27321ebbad (4 days ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at C:\Users\admin\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b03)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit
      https://flutter.dev/setup/#android-setup for detailed instructions.

[✓] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build
      1.8.0_202-release-1483-b03)

[✓] VS Code (version 1.40.2)
    • VS Code at C:\Users\admin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.7.1

[☠] Connected device (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete.  Doctor found issues in 2 categories.

@vikrantmalla That's your log file. I'm having almost the same issue share your solution if you find any

possibly related to https://github.com/flutter/flutter/issues/46938

@christopherfujino Where does flutter doctor thinks it is. I also do native android development and i know i have Android SDK installed

Hi @vikrantmalla
does the proposed solution in this issue
solve the problem?
Thank you

@JerryMatera flutter doctor will tell you where it thinks it is, with a line like:
    • Android SDK at C:\Users\admin\AppData\Local\Android\sdk

hey bro @vikrantmalla  is the issue solved?

can anybody solve this issue please..
I am having the same exact problem.

@sandy9808 see my comment https://github.com/flutter/flutter/issues/47071#issuecomment-594927182 - we'll need more information in order to determine the cause of the issue.

Well Hurry up! I have to do a lot of fluttering in this quarintine.

command:
flutter doctor --android-licenses
output:
C:\Users\user>flutter doctor --android-licenses
'git rev-parse HEAD' is not recognized as an internal or external command,
operable program or batch file.
Building flutter tool...
Running pub upgrade...
'dir /a:l "C:\realflutter\flutter\bin\cache\dart-sdk" 2>nul   | find ">     bin [" 2>nul' is not recognized as an internal or external command,
operable program or batch file.
CreateProcessW failed 2
Sending crash report to Google.
Crash report sent (report ID: 557252744ea32c2d)
Oops; flutter has exited unexpectedly.
\CreateProcessW failed 2
Crash report written to C:\Users\user\flutter_20.log;
please let us know at https://github.com/flutter/flutter/issues.
the text in the log file is:
Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter doctor --android-licenses
exception
ProcessException: ProcessException: The system cannot find the file specified.
Command: C:\Users\user\AppData\Local\Android\sdk\tools\bin\sdkmanager.BAT --version
#0      _ProcessImpl._runAndWait (dart:io-patch/process_patch.dart:498:7)
#1      _runNonInteractiveProcessSync (dart:io-patch/process_patch.dart:643:18)
#2      Process.runSync (dart:io-patch/process_patch.dart:68:12)
#3      LocalProcessManager.runSync (package:process/src/interface/local_process_manager.dart:93:20)
#4      _DefaultProcessUtils.runSync (package:flutter_tools/src/base/process.dart:368:50)
#5      AndroidSdk.sdkManagerVersion (package:flutter_tools/src/android/android_sdk.dart:595:43)
#6      AndroidLicenseValidator.runLicenseManager (package:flutter_tools/src/android/android_workflow.dart:314:64)
#7      Doctor.diagnose (package:flutter_tools/src/doctor.dart:243:38)
#8      DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:59:39)
#9      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:615:18)
#10     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
#11     _rootRunUnary (dart:async/zone.dart:1134:38)
#12     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#13     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
#14     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
#15     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#16     Future._completeWithValue (dart:async/future_impl.dart:524:5)
#17     Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7)
#18     _rootRun (dart:async/zone.dart:1126:13)
#19     _CustomZone.run (dart:async/zone.dart:1023:19)
#20     _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#21     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
#22     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#23     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#24     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#25     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)

flutter doctor
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.18363.657], locale en-US)
    • Flutter version 1.12.13+hotfix.8 at C:\realflutter\flutter
    • Framework revision 0b8abb4724 (6 weeks ago), 2020-02-11 11:44:36 -0800
    • Engine revision e1e6ced81d
    • Dart version 2.7.0

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at C:\Users\user\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-R, build-tools 29.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed
      instructions.

[✓] Android Studio (version 3.6)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)

[✓] VS Code (version 1.43.2)
    • VS Code at C:\Users\user\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.8.1

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

And P.S don't try to give me any link to other issues.
I have tried nearly all of them.

@sandrasandeep do you have git installed and on your user path? I see 'git rev-parse HEAD' is not recognized as an internal or external command,

Yes Sir, I do have git installed in my computer(windows 10)

'git rev-parse HEAD' is not recognized as an internal or external command, I HAVE CLEARED THIS ERROR.

'git rev-parse HEAD' is not recognized as an internal or external command, I HAVE CLEARED THIS ERROR.

I'm sorry, but can you clarify? What do you mean by "cleared this error"?

$ flutter doctor --android-licenses --verbose
CreateProcessW failed 2
Android sdkmanager tool was found, but failed to run (C:\Users\user\AppData\Local\Android\Sdk\tools\bin\sdkmanager): "ProcessException: The system cannot find the file specified.
Command: C:\Users\user\AppData\Local\Android\Sdk\tools\bin\sdkmanager.BAT --licenses".
Try re-installing or updating your Android SDK,
visit https://flutter.dev/setup/#android-setup for detailed instructions.
#0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1      AndroidLicenseValidator.runLicenseManager (package:flutter_tools/src/android/android_workflow.dart:394:7)

#2      Doctor.diagnose (package:flutter_tools/src/doctor.dart:262:38)
#3      DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:58:39)
#4      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:711:18)
#5      _rootRunUnary (dart:async/zone.dart:1134:38)
#6      _CustomZone.runUnary (dart:async/zone.dart:1031:19)
#7      _FutureListener.handleValue (dart:async/future_impl.dart:140:18)
#8      Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:682:45)
#9      Future._propagateToListeners (dart:async/future_impl.dart:711:32)
#10     Future._completeWithValue (dart:async/future_impl.dart:526:5)
#11     Future._asyncComplete. (dart:async/future_impl.dart:556:7)
#12     _rootRun (dart:async/zone.dart:1126:13)
#13     _CustomZone.run (dart:async/zone.dart:1023:19)
#14     _CustomZone.runGuarded (dart:async/zone.dart:925:7)
#15     _CustomZone.bindCallbackGuarded. (dart:async/zone.dart:965:23)
#16     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#17     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#18     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#19     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)
I mean that no more "git rev-parse HEAD' is not recognized as an internal or external command"
is written anymore in the output of command.

My version of flutter is:
flutter --version
Flutter 1.15.17 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2294d75bfa (3 weeks ago) • 2020-03-07 00:28:38 +0900
Engine • revision 5aff311948
Tools • Dart 2.8.0 (build 2.8.0-dev.12.0 9983424a3c)

I am closing this issue as a duplicate of https://github.com/flutter/flutter/issues/51712. The current status is contained in this comment https://github.com/flutter/flutter/issues/51712#issuecomment-601863075.

so it is a work in progress i guess.

@sandrasandeep per https://github.com/flutter/flutter/pull/51980#issuecomment-606152832, the fix is in v1.15.12, which is on the beta channel, so you can either switch to the beta channel, or do the workaround specified on the linked issue.

@christopherfujino but i am using ths version
flutter --version
Flutter 1.15.17 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2294d75 (3 weeks ago) • 2020-03-07 00:28:38 +0900
Engine • revision 5aff311948
Tools • Dart 2.8.0 (build 2.8.0-dev.12.0 9983424a3c)
So,it should work right.

@christopherfujino but i am using ths version
flutter --version
Flutter 1.15.17 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 2294d75 (3 weeks ago) • 2020-03-07 00:28:38 +0900
Engine • revision 5aff311948
Tools • Dart 2.8.0 (build 2.8.0-dev.12.0 9983424a3c)
So,it should work right.

Hmm, good point...

@christopherfujino  do you need more information?

Hi @vikrantmalla, I checked out your logs. As per the exception thrown by the flutter doctor, it says sdkmanager.bat not found.  The sdkmanager is a command-line tool that allows you to view, install, update, and uninstall packages for the Android SDK. As per the exception, sdkmanager file is missing. I suggest try to reinstall the SDK and before that, you should also check the sdkmanager if already exist in the path android_sdk/tools/bin/
let me know if you need any help
Happy Coding!!

sdkmanager.bat is present in tools/bin folder.
And reinstalling the sdk means what?

HI @sandy9808 reinstalling the SDK means to again install whole Android SDK either by reinstalling the Android Studio or by the CLI by downloading sdkmanager from https://developer.android.com/studio under sub-section named "Command line tools only"

g=me tumse pyaar krta hun


Add bulk merge feature

Allow to bulk merge :

Create new temporary table
Copy data in this temporary table
Upsert data from temporary table to target table
Drop temporary table

To use bulk merge, you must define primary key in mapping (AbstractMergeMapping)

I see your need for the feature and I see, that you have put a lot of energy into it. I also understand it's a feature, that makes your life a lot easier. As a maintainer it's hard to decline PRs from people collaborating on the project. But this library has a focus on the COPY Protocol, and supporting upserts is a different area, which could come with its own set of problems, that are going to be hard to debug and would take time, I don't have.
So sorry, I am closing it and hope you do understand my reasons.

I understand, thantks for review :)
The upsert feature will be available in this lib : https://github.com/klee-contrib/spring-batch-bulk

What I would do these days is something like this:

https://www.bytefish.de/blog/bulk_updates_postgres.html

I wouldn’t define a custom type anymore, but just pass the data as JSON and unnest it in the procedure. This way you don’t need to define staging tables, and you are flexible when it comes to updates.
I didn’t evaluate properly how near this gets to the performance of a Binary COPY, but I think it is quite an efficient approach.

I understand the disadvantages of creating temporary table. But in my case, I generate mapping description with a great model generator TopModel. Incoming dataflow feature...
About performance, I've inserted 40,000,000 (small) lines in 5 minutes locally, so it's ok for my needs.


enables CRUD operations for global isolation-groups

What changed?

Adds CRUD operations to isolation-group library
Moves isolation-group-library to use the dynamic config client in line with other config-store providers
Unexports some configuration no longer making sense to export for the IsolationGroup library

Why?

How did you test it?
cqlsh:cadence> select * from cluster_config;

 row_type | version | encoding | timestamp                       | values
----------+---------+----------+---------------------------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
        1 |       4 | thriftrw | 2023-04-05 21:59:54.863000+0000 | 0x590a000a00000000000000000f00140c000000010b000a000000000f00140c000000020c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d31222c225374617465223a317d00000c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d32222c225374617465223a317d00000000
        1 |       3 | thriftrw | 2023-04-05 21:59:43.871000+0000 | 0x590a000a00000000000000000f00140c000000010b000a000000000f00140c000000020c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d31222c225374617465223a317d00000c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d32222c225374617465223a317d00000000
        1 |       2 | thriftrw | 2023-04-05 21:57:28.829000+0000 | 0x590a000a00000000000000000f00140c000000010b000a000000000f00140c000000020c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d31222c225374617465223a327d00000c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d32222c225374617465223a327d00000000
        1 |       1 | thriftrw | 2023-04-05 21:55:25.266000+0000 | 0x590a000a00000000000000000f00140c000000010b000a000000000f00140c000000020c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d31222c225374617465223a327d00000c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d32222c225374617465223a317d00000000

(4 rows)

cadence admin db decode_thrift -i '590a000a00000000000000000f00140c000000010b000a000000000f00140c000000020c000a08000a000000010b00140000001b
7b224e616d65223a227a6f6e652d31222c225374617465223a327d00000c000a08000a000000010b00140000001b7b224e616d65223a227a6f6e652d32222c225374617465223a327d00000000'
======= Decode into type config.DynamicConfigBlob ========
(*config.DynamicConfigBlob)(0x140007a4e80)(DynamicConfigBlob{SchemaVersion: 0, Entries: [DynamicConfigEntry{Name: , Values: [DynamicConfigValue{Value: DataBlob{EncodingType: JSON, Data: [123 3
4 78 97 109 101 34 58 34 122 111 110 101 45 49 34 44 34 83 116 97 116 101 34 58 50 125]}} DynamicConfigValue{Value: DataBlob{EncodingType: JSON, Data: [123 34 78 97 109 101 34 58 34 122 111 11
0 101 45 50 34 44 34 83 116 97 116 101 34 58 50 125]}}]}]})
======= As JSON ========
{"schemaVersion":0,"entries":[{"name":"","values":[{"value":{"EncodingType":"JSON","Data":"eyJOYW1lIjoiem9uZS0xIiwiU3RhdGUiOjJ9"}},{"value":{"EncodingType":"JSON","Data":"eyJOYW1lIjoiem9uZS0yI
iwiU3RhdGUiOjJ9"}}]}]}

echo eyJOYW1lIjoiem9uZS0xIiwiU3RhdGUiOjJ9 | base64 -D
{"Name":"zone-1","State":2}%

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 01875390-6bba-417e-a4a2-aba89218aa3e

95 of 128 (74.22%)  changed or added relevant lines in 2 files are covered.
150 unchanged lines in 31 files lost coverage.
Overall coverage decreased (-0.002%) to 57.102%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

common/isolationgroup/default-isolation-group-state.go
83
116
71.55%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/transfer_queue_processor_base.go
1
77.62%

common/isolationgroup/default-isolation-group-state.go
2
51.21%

common/persistence/domainManager.go
2
67.55%

common/persistence/nosql/nosqlplugin/cassandra/gocql/public/client.go
2
60.47%

common/persistence/nosql/nosqlplugin/cassandra/tasks.go
2
75.57%

common/persistence/sql/sqlDomainStore.go
2
55.05%

common/resource/resourceImpl.go
2
84.12%

common/task/parallelTaskProcessor.go
2
92.75%

common/task/weightedRoundRobinTaskScheduler.go
2
89.64%

service/history/handler.go
2
47.28%

Totals

Change from base Build 0187537e-cefb-40ff-80d2-81d3157519af:
-0.002%

Covered Lines:
85704

Relevant Lines:
150089

💛  - Coveralls

As per discussion:
For comparison with the Update / Get operations on dynamic config
# creating a map-key
# ./cadence admin config update  --name "testGetMapPropertyKey"  --value '{"Value": {"isolation-groups": { "zone-123": {"State": 1}, "zone-321": {"State": 2}}} ,"Filters":[]}'
#
# Note that a list key doesn't appear to be implemented correctly, so not used here.
{
  "schemaVersion": 0,
  "entries": [
    {
      "name": "testGetMapPropertyKey",
      "values": [
        {
          "value": {
            "EncodingType": "JSON",
            "Data": "eyJpc29sYXRpb24tZ3JvdXBzIjp7InpvbmUtMTIzIjp7IlN0YXRlIjoxfSwiem9uZS0zMjEiOnsiU3RhdGUiOjJ9fX0="
          }
        }
      ]
    }
  ]
}

# ./cadence admin config get --name "testGetMapPropertyKey"

[
  {
    "Name": "testGetMapPropertyKey",
    "Values": [
      {
        "Value": {
          "isolation-groups": {
            "zone-123": {
              "State": 1
            },
            "zone-321": {
              "State": 2
            }
          }
        },
        "Filters": []
      }
    ]
  }
]


[tab]  Dynamic content tab was not worked after I update from 1.7.3 to 1.8

Nothing was loaded.

Can you provide a test-case that shows the bug?

Why is this issue closed?


Using a different cache directory elm-install --cache-directory=cache (the default is ~/.elm-install) shows me this output:
Resolving packages...
  ▶ Package: https://github.com/Digisensei/elm-phoenix-socket not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/core not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/html not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/virtual-dom not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/websocket not found in cache, cloning...
  ▶ Package: https://github.com/NoRedInk/elm-decode-pipeline not found in cache, cloning...
  ▶ Package: https://github.com/evancz/elm-effects not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/dom not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/http not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/keyboard not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/mouse not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/page-visibility not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/window not found in cache, cloning...
  ▶ Package: https://github.com/evancz/url-parser not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/navigation not found in cache, cloning...
  ▶ Package: https://github.com/jystic/elm-font-awesome not found in cache, cloning...
  ▶ Package: https://github.com/evancz/elm-html not found in cache, cloning...
  ▶ Package: https://github.com/evancz/virtual-dom not found in cache, cloning...
  ▶ Package: https://github.com/evancz/elm-svg not found in cache, cloning...
  ▶ Package: https://github.com/elm-lang/svg not found in cache, cloning...
  ▶ Package: https://github.com/truqu/elm-base64 not found in cache, cloning...
  ▶ Package: https://github.com/maxsnew/IO not found in cache, cloning...
  ▶ Package: https://github.com/deadfoxygrandpa/Elm-Test not found in cache, cloning...
  ▶ Package: https://github.com/laszlopandy/elm-console not found in cache, cloning...
  ▶ Package: https://github.com/NoRedInk/elm-check not found in cache, cloning...
  ▶ Package: https://github.com/NoRedInk/elm-random-extra not found in cache, cloning...
  ▶ Package: https://github.com/NoRedInk/elm-task-extra not found in cache, cloning...
  ▶ Package: https://github.com/NoRedInk/elm-shrink not found in cache, cloning...
  ▶ Package: https://github.com/NoRedInk/elm-lazy-list not found in cache, cloning...
  ▶ Package: https://github.com/maxsnew/lazy not found in cache, cloning...
  ▶ Package: https://github.com/TheSeamau5/elm-lazy-list not found in cache, cloning...
  ▶ Package: https://github.com/TheSeamau5/elm-random-extra not found in cache, cloning...
  ▶ Package: https://github.com/TheSeamau5/elm-task-extra not found in cache, cloning...
  ▶ Package: https://github.com/deadfoxygrandpa/elm-test not found in cache, cloning...
Solving dependencies...
Saving package cache...
  ● Digisensei/elm-phoenix-socket - 2.0.2 (2.0.2)
  ● NoRedInk/elm-decode-pipeline - 3.0.0 (3.0.0)
  ● elm-lang/core - 5.1.1 (5.1.1)
  ● elm-lang/dom - 1.1.1 (1.1.1)
  ● elm-lang/html - 2.0.0 (2.0.0)
  ● elm-lang/http - 1.0.0 (1.0.0)
  ● elm-lang/keyboard - 1.0.1 (1.0.1)
  ● elm-lang/mouse - 1.0.1 (1.0.1)
  ● elm-lang/page-visibility - 1.0.1 (1.0.1)
  ● elm-lang/window - 1.0.1 (1.0.1)
  ● evancz/url-parser - 2.0.1 (2.0.1)
  ● jystic/elm-font-awesome - 2.0.1 (2.0.1)
  ● truqu/elm-base64 - 1.0.5 (1.0.5)
  ● elm-lang/virtual-dom - 2.0.4 (2.0.4)
  ● elm-lang/navigation - 2.1.0 (2.1.0)
  ● elm-lang/websocket - 1.0.2 (1.0.2)
  ● elm-lang/svg - 2.0.0 (2.0.0)
Packages configured successfully!

the question is i make a project find for packages like "deadfoxygrandpa/elm-test" but i not use! why elm-install is search for that

You can read about how elm-github-install works in this document: https://github.com/gdotdesign/elm-github-install/blob/master/docs/How it works.md but basically it creates a cache of the packages that you use or used.
This cache is just the clones of the repositories in ~/.elm-install directory. It allows among other thigns for offline installation of packages.
In this case deadfoxygrandpa/elm-test is cloned because some version of some package uses it as a dependency.

OK. Thanks. I'll see what the problem is.

If I remove the line for this base64 package, elm-install does not show these packages I speak, and the base64 package does not have this dependencies  https://github.com/truqu/elm-base64/blob/master/elm-package.json.

Yes you are right the latest version does not depend on it, but elm-github-install goes through all versions of it and since the 1.0.0 (https://github.com/truqu/elm-base64/blob/1.0.0/elm-package.json) has that dependency it clones it.

ok, i resolve this issue put   "truqu/elm-base64": "1.0.5 <= v < 2.0.0" to get only last version... thanks


Tracking: Test generator MVP

Test generator MVP to use after configlet generate for practice exercises:

[ ] Integrate POC test generator into separate directory, so it is not installed in CI
[ ] Add a parameter to choose the exercise by slug
[ ] Use local configlet cached problem specification repository as information source
[ ] Write to already created /exercises/practice/${slug}/{PascalCaseSlug}.php
[ ] Have test class skeleton
[ ] Have test class DocBlock with "PHP track rules"
[ ] Do not do more, if exercise has no canonical-data (there are some)
[ ] Have testdox with description
[ ] Have UUID in DocBlock
[ ] Have all tests marked incomplete
[ ] Do not do more, if exercise canonical-data is not "input", "expected", "property" scheme (they may be nested, too)
[ ] Have $input, $expected
[ ] Have $subject = new ${PascalSlug};, $actual = $subject->${property}($input); and assertSame($expected, $actual);
[ ] Bonus: Add golden tests for test generation of some exercises

@tomasnorre Did you add some functionality to your local copy of the test generator that you would want to have here, too? I think I'll find time on the weekend to take some of the steps outlined here and would be happy to integrate the "latest" version.


[Syntax] Add node definition for enums and enum cases

This patch adds a libSyntax definition for enum cases. Parsing support will be added in a separate patch.

@swift-ci please smoke test

@swift-ci please smoke test


Minify CSS and combine JS as part of collectstatic and build

From #88.

https://django-compressor.readthedocs.io/en/latest/

I'd also look into doing offline compression since we serve a static version of the site: https://django-compressor.readthedocs.io/en/latest/usage/#offline-compression

So the way it's done here is to turn on COMPRESS_OFFLINE in production and then hook up the compression management command into a fabric task. We currently don't have two separate settings files, so I don't think this solution will work for us. Ideas?

We can probably add it as a .env variable or maybe an if statement in the
setting keyed off our PRODUCTION variable.
On Sun, Aug 28, 2016, 1:22 AM Sahil Chinoy<EMAIL_ADDRESS>wrote:

So the way it's done here
https://github.com/cirlabs/django-project-template/blob/master/project_name/settings/production.py#L13
is to turn on COMPRESS_OFFLINE in production and then hook up the
compression management command into a fabric task. We currently don't have
two separate settings files, so I don't think this solution will work for
us. Ideas?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/california-civic-data-coalition/django-calaccess-downloads-website/issues/100#issuecomment-242958801,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAnCTt_KygqZcesJgB-vUgDKOsy4OeJks5qkSlBgaJpZM4JpMYQ
.

The simplest solution ended up being forcing django-compressor's compress command to run as part of our deploy routine. So COMPRESS_OFFLINE is always technically FALSE, but when we build the site, the static CSS and JS should still get be created before we deploy. There could easily be something wrong with this, so let's monitor.

How can we test it? Roll out the site with the new code?

Yeah so this doesn't work. I realized that it's not that we want to turn on COMPRESS_OFFLINE only for prod, but rather we want it on when we're running the build/deploy routine (dev & prod) as opposed to the local runserver. Struggling with how to accomplish that.

Here. Let me.

it me irl rn


The data scale in trainer isn't consistent

Hi,
I found that in BasicTrainer.py, the scale of the model's outputs and labels isn't consistent when setting args.real_value=True. You may need to inverse transform the model's outputs to make it right.

Yeap, I also found this, you will find AGCRN model's label's scaler is really high while the output's is smaller. He forgets to inverse transform.

Hi,
I found that in BasicTrainer.py, the scale of the model's outputs and labels isn't consistent when setting args.real_value=True. You may need to inverse transform the model's outputs to make it right.

Hi,
I found that in BasicTrainer.py, the scale of the model's outputs and labels isn't consistent when setting args.real_value=True. You may need to inverse transform the model's outputs to make it right.

Yeap, I also found this, you will find AGCRN model's label's scaler is really high while the output's is smaller. He forgets to inverse transform.

I still wonder why so many papers in Spatio-Temp's mae and rmse are all the same scaler !!!  They use the real data to compare with the normalize data and got this answer, wtf??

Hi,
I found that in BasicTrainer.py, the scale of the model's outputs and labels isn't consistent when setting args.real_value=True. You may need to inverse transform the model's outputs to make it right.

Thanks for the comment. When setting args.real_value=True, the output is the real value, not the normalized value. The corresponding codes are Line 47, 74, and 182 in BasicTrainer.py.


Release 0.2 cherry pick cluster wide initializer

What this PR does / why we need it:
Cherry-picks the following PR to make initializer cluster-wide in release-0.2 branch.
https://github.com/istio/pilot/pull/1437 - Added new parameter to exclude inject namespaces
https://github.com/istio/pilot/pull/1476 - bugfix: remove initializer when specific namespaces are set
https://github.com/istio/pilot/pull/1525 - Make initializer cluster wide
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

* Initializer now watches all namespaces and unconditionally removes itself from the list of pending initializers.
* Added new parameter to exclude inject namespaces.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
9b9cc8a0fc18eb98c5e49f03f332e23a3088bfca
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Metric unit mappings

Hey, I am trying to map metric units configured in the GCP service yaml files to the metric unit format in Dynatrace so that i can create custom alerts in the UI or via the API. Would you be able to help with the mappings containing "????" or point me in the right direction?
{
"%"            : "Percentage",
"10^2.%"       : "Percentage", // multiplies the value by 100 before ingestion
"1"            : "Count",
"ms"           : "MilliSecond",
"s"            : "Second",
"By"           : "Bytes",
"GiBy"         : "GigaByte",
""             : "UNSPECIFIED",
"{CPU}"        : "????",
"{packets}"    : "????",
"d"            : "????",
"s"            : "Second",
"us"           : "MicroSecond",
"1/s"          : "PerSecond",
"{connection}" : "????",
"{request}"    : "????",
"s{CPU}"       : "????",
"By/s"         : "BytePerSecond",
"GBy.s"        : "???? GigaBytes per second?",
"GiBy.s"       : "???? GigaBytes per second?",
"{inode}"      : "????",
"{dBm}"        : "????",
"ns"           : "NanoSecond",
"s{idle}"      : "????",
"s{uptime}"    : "????",
"{port}"       : "????",
"{packet}"     : "????",
"{connection}" : "????"
}
Many thanks
Jack

Hello Jack,
First of all I'm very sorry for late response.
You can find units mapping here: https://github.com/dynatrace-oss/dynatrace-gcp-function/blob/master/generate_metadata.py#L24
units not present in this map are set to Unspecified
Best,
Marek


API: FileSystemWatcher not firing when complete filename used without wildcards

Does this issue occur when all extensions are disabled?: Yes

Attempting setup a FileSystemWatcher for a specific single file fails to trigger on create/change/delete events when complete filename provided:
const watcher = vscode.workspace.createFileSystemWatcher(new vscode.RelativePattern("C:\\", "test.json"));
watcher.onDidChange(uri => console.log("change", uri));
watcher.onDidCreate(uri => console.log("create", uri));
watcher.onDidDelete(uri => console.log("delete", uri));

if test.json replaced with *.json the events triggered properly.
Version: 1.72.2
Commit: d045a5eda657f4d7b676dedbfa7aab8207f8a075
Date: 2022-10-12T22:15:18.074Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No

Did you duplicate yourself? See https://github.com/microsoft/vscode/issues/162498

Ops


remove index tests

These are no longer needed since we got API Reports in place

😆 Yeah, the new API reports should be sufficient.


Incorrect conversion of animated images to non-animated formats

If animated images (e.g. GIF) are saved in non-animated formats (e.g. Jpeg), all frames appear in a strip below each other.
The result is Jpeg but the expected behaviour would be that only the first frame is transferred to the new format.
Code Example
use Intervention\Image\Drivers\Vips\Driver as VipsDriver;

$image = ImageManager::withDriver(VipsDriver::class)
    ->read('animation.gif')
    ->toJpeg();

Input Image (GIF)

Output Image (Jpeg)

@olivervogel I think we could update the vips core so frames are broken down into pages (Collection)
https://github.com/libvips/php-vips/issues/116#issuecomment-793940189
Similar to how the gd core handles frames
otherwise, we can easily update the encoders to check if the image is animated and only use the first frame, probably an easier fix for now

@deluxetom I think it's better if the core object only contains a single vips image and only splits it when necessary (or desired).
Your second idea sounds good, although I can imagine that there is an easier way with vips, but I'm not sure.


tf2: Updated setup.py dependencies.

Setup will now install latest tf2 and latest compatible gym.

About the changes: I was unable to install the baselines tf2 pip package (windows10, python 3.7.4). I got an error telling me that the tensorflow package didn't exits in PyPI even after manually installing the latest one. Gym version is also limited by a line in run.py.

LGTM, @tanzhenyu, any objections?

LGTM, @tanzhenyu, any objections?

No objection. probably install tensorflow == 2.0.0-rc0 as latest version?

I have checked master's branch setup.py and updated acordingly. CPU/GPU and nightly versions were already correctly handled there.


rename param to that which the frontend sends

Purpose
In an earlier refactor the query params for privacy request search got updated on the backend and not the frontend — this PR resets the backend to its previous value.
Changes

Update request_id param to be id

Checklist

[ ] Update CHANGELOG.md file

[ ] Merge in main so the most recent CHANGELOG.md file is being appended to
[ ] Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
[ ] Add a link to this PR at the end of the description with the PR number as the text. example: #1

[ ] Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
If docs updated (select one):

[ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
[ ] documentation issue created (tag docs-team to complete issue separately)

[ ] Good unit test/integration test coverage
[ ] This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
[ ] The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket
Fixes #598

I think we'll need to update the frontend to match this. I updated the frontend to use request_id in the details PR that was merged yesterday.
https://github.com/ethyca/fidesops/blob/main/clients/admin-ui/src/features/privacy-requests/privacy-requests.slice.ts#L39

Just a note on the reason for they pylint error. id is a Python built in function so naming something id could cause bugs https://docs.python.org/3/library/functions.html#id.

Just a note on the reason for they pylint error. id is a Python built in function so naming something id could cause bugs https://docs.python.org/3/library/functions.html#id.

@sanders41 is correct, and this is the reason we refactored this in the first instance. This solution was my fix for the demo I made yesterday that I thought I'd sooner commit while we waited to implement the correct solution of updating the frontend...

I think we'll need to update the frontend to match this. I updated the frontend to use request_id in the details PR that was merged yesterday.

...which appears to have just been done! We can close this PR.


how to save/restore vector store to/from file

I'm using llama-index elastic search module, and I'm confused about why such basic functionality seems missing in python3.12/site-packages/elasticsearch/_sync/client


Playback pause after 7 seconds

same thing happens to me on youtube and with store.steampowered.com.
but i can still seek in the video and resume the playback, which will pause again after 7 seconds.
using Fedora 20/x64 with the latest commit - cbe7057

Direct PulseAudio support was implemented, so the root of the issue — interacting with ALSA compatibility plugin — was eliminated. Thus I believe issue is solved now.
If you still experience unexpected playback pauses, feel free open a new issue, or reopen this one.


APP NOT RUN

After the update, when you open the application it closes at the moment without being able to select anything, any solution?

Please provide logs and crash logs so I can see what is happening.
It would be best if you set LogLevel = 3 in Component.json config so logging shows more

can I communicate by some direct channel with you to show you a video, why do I not understand? discord?

you can send me a video via twitter. its linked in this git.
Otherwise, im guessing I know what happened and this should not be an issue anymore.


Update README.md to use --toolchain nightly rather than --target

With --target nightly it complains:

error: toolchain 'stable-x86_64-unknown-linux-gnu' does not contain component 'rustc-dev' for target 'nightly'

I believe --toolchain is the correct argument here.

Thank you for your contribution @upsuper!


useResource "submit" method is mis-typed

The submit method seems to be mis-typed as being synchronous. However, it's an async function!
Code:
https://github.com/badgateway/react-ketting/blob/main/src/hooks/use-resource.ts#L86
const submit = async () => {
    if (!resourceState || !resource) {
      throw new Error('Too early to call submit()');
    }
    await resource.put(resourceState);
  };

Type:
https://github.com/badgateway/react-ketting/blob/main/src/hooks/use-resource.ts#L21
// Send the state to the server via a PUT or POST request.
  submit: (state?: ResourceState<T>) => void;

Originally by design because I wasn't sure what we were going to do with this method, but at this point I think it's fine to change to Promise<void>


Does not contain packages matching github.com/equinix/pulumi-equinix/sdk/go/...

Hi,
Just trying to do a go get for this package and I run into the below issue.
go get -u github.com/equinix/pulumi-equinix/sdk/go/...
go: module github.com/equinix/pulumi-equinix@upgrade found (v0.5.1), but does not contain packages matching github.com/equinix/pulumi-equinix/sdk/go/...

I'm not sure how to get around this issue and any help you could provide would be great thanks.

Hi @DevGuyOps can you please try again? in case still not working please clean cache first
go clean -cache
go clean -modcache

I just tried and managed to get it to import.
Thanks for the help!


Problems with Notebook debugger (using Jupyter Protocol)

Note: These issues have been fixed for IW debugger, we need to fix them for Notebook

Problem 1:

Cell 1< empty line>
< empty line>
< empty line>
< empty line>
print(1)
print(2)

When debugging the above code, the debugger will stop at line print(1), however when you hit step over in RBL or continue in the cell debugger it will break there once again.

Problem 2:

Cell 1< empty line>
< empty line>
< empty line>
def foo():
    print('inside foo')

Cell 2

foo()

When debugging the above code, the debugger will stop at line foo(), however when you step into the code, it will stop way above the def foo, in a white space (basically on line 2 of the file, in the white space).

Problem 3:
The above issues were uncovered while running some of the IW debugger tests.
I think we need a few more tests for the notebook debugger to cover the same scenarios covered in IW debugger.

These issues have been fixed in the new IW when using debugger protocol.
Basically injecting breakpiont() along with a few other changes.

After further analysis, i think we have to do the following:

Use breakpoint() to stop where we want (instead of adding breakpoints)
Strip the leading white space from the cells and send that to the kernel (debugger)

We'll need to take this into account when translating source maps & tracebacks

We might want to make this change for Notebook debugger as well.

I can't repro issue 1 in a notebook. I see issue 2 though, didn't know that Jupyter does this

@roblourens the empty lines were stripped during rendering... lol, Jupyter does the same,
Try with the leading empty lines.

Build of Visual Studio Code - Insiders: 1.68.0-insider(user setup)
Build of python-Pre-Release: v2022.7.11541009
Build of jupyter-Pre-Release: v2022.6.1001562429
Build of pylance: v2022.6.0
Build of jupyter Notebook Renderers: v1.0.8
Build of jupyter Keymap: v1.0.0
Pressing F10 will stop at the line def bar():, then pressing F10 again will stop at the line ``def bar():```.

@ttSpace
please could you file a separate issue for that.

Upstream issue https://github.com/microsoft/vscode-jupyter/issues/10586

Issues with empty lines will not be resolved for now (as it was reported by me and a papercut),
Creating a new issue to track breakpoint issue caused by upstream python debgger https://github.com/microsoft/vscode-jupyter/issues/10600

Was problem 2 supposed to be fixed by the debugpy update?


panic when following the instructions in the README

Following the instructions as is, here is the error I'm getting in Chrome 71.0.3578.98 (Official Build) (64-bit) with Go version 1.11.4 darwin/amd64
running
wasm_exec.js:45 panic: invalid character 'd' after top-level value
wasm_exec.js:45
wasm_exec.js:45 goroutine 1 [running]:
wasm_exec.js:45 main.main()
wasm_exec.js:45 	/Users/mattetti/Code/golang/src/github.com/dennwc/dom/cmd/app/main.go:97 +0x4b
wasm_exec.js:67 exit code: 2

It looks like maybe the data in the storage is bad, but I can't easily debug it, nor do I seem to get a lot of clues from the code:
if err := storage.GetItemJSON(stor, key, &s); err != nil {
				panic(err)
			}

Based on the error, it looks like bad JSON but I have no clue how to properly debug :(

Can't reproduce it on the latest version. Make sure that the key you are trying to get does not contain any old data that might be in plain text instead of JSON.


FetchPodOrProxyMixin should not use proxy to query the app resources

If we went a notification, the object will be created on the app server.
Instead of going through the user's proxy, we should fetch the resource on the app server directly.

We do it correctly on the PodActivitiesWatcherService (call ldp.resource.get instead of pod-resources.get if this is a local resource)


Upgrade git inputs to clone at a SHA

Right now we clone + checkout, which means we need the full depth of the repo, which can be slow.
It sounds like there is a way to do this, in which case we should:
@sean might make sense to join our community slack and talk to the devs (you can sign up via https://sourced.tech).

What I got so far was:

It's a bit complex to explain, but basically it's building a basic request with the want and haves very defined:
https://github.com/src-d/go-git/blob/v4/remote.go#L270
and create a request with the commit wanted and depth == 1```

It's been a bit since I dug into this. There needs to be an API change to support this: https://github.com/src-d/go-git/issues/691
It's a bit unclear how hard that is.
An alternative is to use tarballs (most hosted git solns provide these -- bitbucket, gituhb, gitlab), but we were hoping the git client would just support it as is, as the alternative requires supporting each git hosting provider's API.


Added to The task in reverted-merge/README.md

Added detail to The task, which was very high level. Added more specific commands so the student should know if they are going down the expected track.
Added to Useful commands.

You make the rest of us look bad!
Thank you!


Html input to Webview

WebView appears to work when the input was a URL, but not html text:
            bool TESTTMP = true;
            if (TESTTMP)
            { //works
                WebView webview = new WebView { Source = "http://www.xamarin.com" };
                objStackLayout.Children.Add(webview);
            }
            else
            { // fails
                var htmlSrc = new HtmlWebViewSource();
                htmlSource.Html = "
Xamarin.Forms

Welcome to WebView.
  ";
                WebView webview = new WebView { Source = htmlSrc };
                objStackLayout.Children.Add(webview);
            }

A further problem surfaced from careful experiment: even when input is a URL as in samples etc. we have case where adding the webview to the stacklayout for some reason renders button click handlers inoperative.
So webview isn't workable either by setting source directly to URL, or to html text, or by using htmlwebviewsource.  The former appears to work but has a problem side effects on buttons.
Everything is close in this amazing package.  We are very near to having a large application ported.
Thanks.

Continuing our investigation...
When WebView is present on the page, the message pump is not active so buttons etc. cannot work.  We will soon have more to report and a possible solutions.  Working from a full build in debug mode we're trying to learn our way into enough understanding so we can identify the specific problem.