All http://datainterface.eastmoney.com/EM_DataCenter/JS.aspx URL does not work. Need replace with new URL

Python: 3.8
OS: Linux
akshare:1.8.10
Error of the current URL:

This bad URL often result error like this:

To fix such issues all the bad URL should be replace with new URL in code base
Please check one of the file macro_china.py

Do you have the newest URL? I have encouter this issue too.
Appears many eastmoney api cannot run correctly.

I do not know, but @jindaxiang has fixed a similar issue with a new URL of  "https://datacenter-web.eastmoney.com/api/data/v1/get". You may check if this url can be used to fix this issue.

Python: 3.8 OS: Linux akshare:1.8.10
Error of the current URL:
This bad URL often result error like this:
To fix such issues all the bad URL should be replace with new URL in code base Please check one of the file macro_china.py

感谢反馈问题；已修复该问题，升级到 AKShare 1.8.17 版本使用


rename tools to workflows [SATURN-868]

This replaces references to tools in the code with workflows, along with redirectors for affected paths. There are still a few places in copy where we refer to tools, and I didn't touch those, I want to check in with product first.

@panentheos I think I got them all


comb: working (eager) version of combinations_with_replacements

First version of an entirely eager version of combinations with replacement

Working on a lazy version. Hoping to finish before the end of tomorrow, or earlier

Working on a lazy version. Hoping to finish before the end of tomorrow, or earlier

Finished it earlier than expected

Finished it earlier than expected


feat(event_handler): add cookies as 1st class citizen

Issue number: #1192
Summary
This PR adds first class support for Cookies.
bigger description comming soon
Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[ ] Meet tenets criteria
[ ] I have performed a self-review of this change
[ ] Changes have been tested
[ ] Changes are documented
[ ] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa @leandrodamascena would appreciate early feedback on this one before I continue to apply changes


fix: copernicus electronic issn captured correctly

modified:   adsingestp/parsers/copernicus.py
modified:   tests/stubdata/output/copernicus_ESSD_essd-15-3075-2023.json
modified:   tests/stubdata/output/copernicus_GeChr_gchron-5-323-2023.json
modified:   tests/stubdata/output/copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
modified:   tests/stubdata/output/copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
modified:   tests/stubdata/output/copernicus_wes-8-1625-2023.json
modified:   tests/test_copernicus.py
modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0938a1c) 89.78% compared to head (3f2c339) 89.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   89.78%   89.79%
=======================================
  Files          25       25
  Lines        2615     2616    +1
=======================================
+ Hits         2348     2349    +1
  Misses        267      267

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Everything looks good! just one minor suggestion.


Arming Failed: Can't connect to 3DR Solo

Hello,
I am trying to get a working sample of the DronecodeSDK library working in my iOS app.  That being said, I am having trouble getting the SDK to actually connect to my 3DR Solo drone.  By following the basic guide in the README, I get the following error while attempting to arm the drone:
Arming failed: The operation couldn't be completed. (SwiftGRPC.RPCError error 0)
I have made sure that my iOS simulator is connected to the drone wifi.  I have also tried to run the sample project but to no avail (same error).
Any help would be appreciated.
Environment:
XCode -> 9.4.1
3DR Solo Drone
iOS Simulator (iPhone 8+)

Hmm I've never tried the Solo. Does it get recognized? You would see some logs similar to:
[11:53:28|Info ] New device on: <IP_ADDRESS>:14540 (udp_connection.cpp:200)
[11:53:28|Debug] Component Autopilot (1) added. (system_impl.cpp:369)
[11:53:28|Debug] Discovered 1 component(s) (UUID:<PHONE_NUMBER>) (system_impl.cpp:515)

Would you mind trying with SITL first? If you have docker, you can try to run this container. I personally connect it directly to my phone (but it should work with the iOS simulator), like so:
docker run --rm -it jonasvautherin/px4-gazebo-headless:v1.8.0 <ip of my iPhone>

@hjames2 what port does Solo send UDP MAVlink traffic on? I suspect the default QGC port 14550. By default the SDK connects on 14540. If you want to use 14550 instead you should be able to add that port like this:
add_udp_connection(14550);


Added missing html tag in wtforms docs

The tags/quotes aren't missing. Omitting them is valid HTML5.


Switching from Jenkins plugin to Gradle plugin

As far as I can tell the gradle plugin is faster for us than the jenkins plugin. So we'd like to move over to the Gradle plugin but we don't know how to fail the build based on number of types of vulns discovered
When setting up the jenkins plugin we used
dependencyCheckPublisher(
                        canComputeNew: false,
                        defaultEncoding: '',
                        failedTotalAll: '', // fail if greater than M vulns
                        failedTotalHigh: '0', // 0 means fail if any high vulns
                        healthy: '',
                        pattern: '',
                        unHealthy: '10' //build is unhealthy while there are more than N vulns
                )

So that we could block the build for new high vulns.
In our gradle file we have:
dependencyCheck {

    skipTestGroups = false
//    suppressionFile = 'dependency-check-suppressions.xml'
    data {
        directory= System.properties['user.home'] + '/dependency-check-data'
    }
    analyzers {
        experimentalEnabled = true
        assemblyEnabled = false
        rubygemsEnabled = false
        nuspecEnabled = false
//        nugetconfEnabled = false
        composerEnabled = false
        cocoapodsEnabled = false
        swiftEnabled = false
        bundleAuditEnabled = false
    }
}

what's the equivalent way to block the build in Gradle?

Hmm, I've just realised I can still use the publisher block in the pipeline, DOH!
Is that the correct solution or...?

Yes - and in reality you will get better results using the gradle plugin vs. having the Jenkins plugin scan and publish the results.

Brill, will stick with that
Thanks so much! Infosec folk (and others) at work are so happy we can have this in the build pipeline!


Duplicate notifications for new messages

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.000
Where did you get the app from?
Google Play
Android version
11
Device model
Moto g10
Steps to reproduce
Part of the trigger seems to be only closing the notifications about a few of the received mails and the  receiving more mails. More I didn't find out in the last months.
Expected behavior
If n mails arrive I normally get notifications with all their title lines
Actual behavior
Rarely I get n notifications with the title lone of one of my mails instead
Logs
No response

I actually got 8 mails, bit only one was about wxMaxima

Same problem. Driving me crazy!

Unfortunately that doesn't seem to be this specific Android11 bug:

Unfortunately this time it seems not to be a bug in this specific Android11 feature:

Issue is still present in version 6.20

I have the impression that a trigger might be that a reply arrives to an unread message that is dropped out of the mails kept in K9 by the arrival of the new message.

When this happens again, please try the following:

Force stop the app. This should also remove all notifications.
Do something that will start the app again. That will recreate the notifications from K-9 Mail's database. However, don't just open the app if this will open a message list view that contains the messages in the notifications (because that will lead to the notifications being removed). You could add a new "K-9 Unread" widget to the home screen. That process will launch the app, triggering the notifications to be recreated. But it won't display a message list that will lead to the notifications being removed.
Check if there are still duplicate notifications and report back.

We are lucky: Normally this triggers about once per week. Today I found two more puzzle pieces: I got 6 repeated notifications and one notification about a different mail.
And killing K9 and restarting it using the widget caused only the repeated notifications to reappear.

That result is raising more questions than it is able to provide answers.
So you started out with 7 notifications, 6 of them for the same message? And you ended up with 3 notifications, all of them for the same message, the one that was repeated 6 times before the app restart?
What happened to the other message? Was it deleted, moved, or marked as read using another client?

Before I made the screenshot the 6 repeated Mails were still displayed in the notification drawer. I believed that the other mail that was no more shown might have been marked as read by tapping on the K9 widget. My kmail wasn't in a working order when I made this screenshot...

Ok. So it sounds like all duplicate notifications are being restored. The database table that stores information about notifications doesn't allow more than one entry per internal message ID. That suggests that for K-9 Mail all of these entries are distinct messages.
When this happens again, please do the following:

Tap an individual notification to open the message. That should open the message view and remove the notification for that message.
Don't go back to the message list screen (because that would remove all notifications for messages in that folder). Leave the app using the home button.

Does that remove all duplicate notifications or just the one you tapped?
Repeat the process with the other notifications. Does tapping one of them remove more than one notification?

It removes only the duplicate I tried to remove. As if I get 10 duplicates that means I got 10 messages I guess that already made sense.
...but going back to the message list screen doesn't remove the duplicate notifications for me. As it often doesn't do so for non-duplicate messages that might possibly not mean anything, though...

Maybe the title is misleading now: I actually get one notification per message. But sometimes (very rarely) many of the notifications get the notification text from the same message.

I was finally able to reproduce this issue.
Steps to reproduce:

Receive 9 messages for which notifications are created
Open the folder containing the messages by regularly opening the app (not through a notification)

When opening the folder, the app tries to remove all notifications belonging to messages in that folder. However, the code to remove notifications contains a bug. Combined with some other behavior this leads to 8 notifications showing the same message.


row-grouping 23.2.1

Type: Missing
Summary:
row-grouping 23.2.1
Details:
ClearlyDefined license states Commercial: AG-Grid-Enterprise-License
NPM license field states see license folder
GitHub license is MIT AND OTHER: https://github.com/ag-grid/ag-grid/blob/v23.2.1/LICENSE.txt
Resolution:
MIT AND OTHER
Affected definitions:

row-grouping 23.2.1

@LandOfBliss I would Declare as OTHER for the commercial license. Only certain components are under MIT and this one is not listed, see here - https://github.com/ag-grid/ag-grid/blob/latest/LICENSE.txt. @ariel11 do you agree?

@AE49 I agree with just OTHER.


chore(deps): bump openresty from <IP_ADDRESS> to <IP_ADDRESS>

Summary
See: https://openresty.org/en/ann-1021004002.html
KAG-2140

Need to fix dyn_upstream_keepalive.patch.

Need to fix dyn_upstream_keepalive.patch.

Yes, if it is because of it. Currently I cannot reproduce with my setup, and patch applies cleanly. But I can take another look at it. Perhaps things works differently on Linuxes.

I rebased the patch by using patch tool and generate the patch again. The patch implementation for Bazel is patch and somtimes it fails to apply for patches that are applied with fuzz
patching file ngx_lua-0.10.25/src/ngx_http_lua_balancer.c
Hunk #3 succeeded at 238 with fuzz 2.
Hunk #4 succeeded at 303 (offset 10 lines).
Hunk #5 succeeded at 354 (offset 10 lines).
Hunk #6 succeeded at 376 (offset 10 lines).
Hunk #7 succeeded at 415 (offset 10 lines).
Hunk #8 succeeded at 452 (offset 10 lines).
Hunk #9 succeeded at 490 (offset 10 lines).
Hunk #10 succeeded at 938 (offset 10 lines).
Hunk #11 succeeded at 952 (offset 10 lines).
Hunk #12 succeeded at 965 (offset 10 lines).
Hunk #13 succeeded at 997 (offset 10 lines).
Hunk #14 succeeded at 1020 (offset 10 lines).
Hunk #15 succeeded at 1032 (offset 10 lines).
Hunk #16 succeeded at 1107 (offset 10 lines).
Hunk #17 succeeded at 1138 (offset 10 lines).
Hunk #18 succeeded at 1195 (offset 10 lines).
Hunk #19 succeeded at 1224 (offset 10 lines).
Hunk #20 succeeded at 1250 (offset 10 lines).
Hunk #21 succeeded at 1278 (offset 10 lines).
patching file ngx_lua-0.10.25/src/ngx_http_lua_common.h
Hunk #1 succeeded at 247 with fuzz 2 (offset 7 lines).
Hunk #2 succeeded at 341 with fuzz 1 (offset 20 lines).
patching file ngx_lua-0.10.25/src/ngx_http_lua_module.c
Hunk #1 succeeded at 1158 with fuzz 1 (offset 41 lines).

I rebased the patch by using patch tool and generate the patch again. The patch implementation for Bazel is not patch and somtimes it fails to apply for patches that are applied with fuzz

Yes, it turned out that Mac patch tool was not complaining, so I installed brew install gpatch and could reproduce. Thanks for figuring it out, I fixed rest of the fuzz. Should be no ok, but lets see.

@bungle The above error is because lua-resty-healthcheck uses sock:tlshandshake that is from our patch but is removed in this PR. Is this intentional and should we update lua-resty-healthcheck to use the new API or add the cosocket-mtls patch back?

@bungle The above error is because lua-resty-healthcheck uses sock:tlshandshake that is from our patch but is removed in this PR. Is this intentional and should we update lua-resty-healthcheck to use the new API or add the cosocket-mtls patch back?

@fffonion good catch! I tried to search for tlshandshake but didn't find anything, so I think it would be best to update lua-resty-healthcheck to use sslhandshake.


Doesn´t work with 3 items

I created a list with 3 todo-items: e, q, w
When I click on the first item, nothing happens.
I click again and get q, q, w
I click on the last one and get an exception

Well spotted, had old debug code left hanging.


Add More Credit Card Types

There are more card types that what is supported in current implementation. Can we add more card types

@jrock2004 I realize this is an old issue, but do you know what card types were missing that you needed?

I do not unfortunately

Closing this as wontfix for now.


UX Enhancement - Send MWC Page

Maybe it is possible to place highly visible notice to the "Send MWC" page:
"IMPORTANT - ONLINE SEND: Make sure the destination wallet is online before sending."

Will update confirmation message with that.

@bayk It would also be good to inform the user that the online wallet needs to be listening for the specific address being sent to. Perhaps this text:
"IMPORTANT - ONLINE SEND: Before sending make sure the destination wallet is online and listening for the destination address."

@airdropmario , @pocketLNio , @cgilliard
If transaction failed, it is not a big deal, it can be cancelled. Warning should say:

transaction will not be  finalized if the destination wallet is offline and and not listening for the destination address.
Until it is finalized your fund at that output will be blocked.
You can cancel your non finalized transaction  and unblock your funds at "Transactions" page.

Number 2 and 3 applicable to file transactions as well.
How can we say that nicely?

I think it is enough to Update the main send page with that. I am not updating the message boxes. It is better not overload them with too much info.
Also  Send Confirm dialogs will be enriched soon with a password, so there are not much to put there.
@condensed-io ,  here is how send page looks now.


Merge race condition fix into master

This PR was merged into testnet before I could change the target branch.

Codecov Report

Merging #71 into master will increase coverage by 0.18%.
The diff coverage is 83.87%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   54.94%   55.12%   +0.18%
==========================================
  Files         118      118
  Lines        6197     6298     +101
==========================================
+ Hits         3405     3472      +67
- Misses       2197     2229      +32
- Partials      595      597       +2

Impacted Files
Coverage Δ

pkg/core/consensus/agreement/collector.go
85.71% <71.42%> (-14.29%)
:arrow_down:

pkg/core/consensus/agreement/broker.go
78.78% <94.11%> (+5.93%)
:arrow_up:

pkg/core/chain/chain.go
33.33% <0%> (+1.98%)
:arrow_up:

pkg/core/consensus/reduction/reducer.go
76.71% <0%> (+11.64%)
:arrow_up:

pkg/core/consensus/selection/filter.go
93.54% <0%> (+16.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168a59b...9abf0f4. Read the comment docs.


Removing a series from an event does not work

Describe the bug
Given that an event is part of a series. Removing the series does not work.
To Reproduce
Steps to reproduce the behavior:

Create a series in Opencast
Upload an event and choose the previously created series, wait for processing
Go to the metadata tab and edit the series, choose in the drop down menu: -- No option selected --
Wait for the green checkmark
Close the event details
The event should now be without a series, however, the previous series is still assigned to the event

Environment Information

OS: Arch Linux
Browser: Firefox 78
Opencast 8 (stable.opencast.org at 29.07.2020)

Transferred data looks fine.
The problem is somewhere in the backend:
set:
[{
"flavor":"dublincore/episode",
"title":"EVENTS.EVENTS.DETAILS.CATALOG.EPISODE",
"fields":[
   {"translatable":false,"readOnly":false,
    "id":"isPartOf",
    "label":"EVENTS.EVENTS.DETAILS.METADATA.SERIES",
    "collection":{"Blender Foundation Productions":"63517a94-473a-4e7d-a66f-ff62a5c097cf","Testing":"de2fe0e3-fd48-49c5-a6ea-3c84db3dd58f"},
    "type":"text",
    "value":"de2fe0e3-fd48-49c5-a6ea-3c84db3dd58f",
    "required":false,
    "tabindex":8}]}]

delete:
[{
"flavor":"dublincore/episode",
"title":"EVENTS.EVENTS.DETAILS.CATALOG.EPISODE",
"fields":[
   {"translatable":false,
    "readOnly":false,
    "id":"isPartOf",
    "label":"EVENTS.EVENTS.DETAILS.METADATA.SERIES",
    "collection":{"Blender Foundation Productions":"63517a94-473a-4e7d-a66f-ff62a5c097cf","Testing":"de2fe0e3-fd48-49c5-a6ea-3c84db3dd58f"},
    "type":"text",
    "value":null,
    "required":false,
    "tabindex":8,
    "saved":true}]}]

Unrelated: Why are we sending the collection to the backend. That doesn't make no sense

Can confirm this bug; happening on our instance as well

@ebbertd Seems to be fixed, should I close it?

This has been fixed.


[Event Request] Codeunit 80 - Sales-Post - OnCheckAndUpdateOnBeforeCopyAndCheckItemCharge

Dear ALAppExtensions team,
Through this issue we would like to request event publisher OnCheckAndUpdateOnBeforeCopyAndCheckItemCharge to be added to Codeunit 80 Sales-Post with the following signature:
    [IntegrationEvent(false, false)]
    local procedure OnCheckAndUpdateOnBeforeCopyAndCheckItemCharge(var SalesHeader: Record "Sales Header"; WhseReceive: Boolean; WhseShip: Boolean; var RefreshNeeded: Boolean)
    begin
    end;

with var parameters: SalesHeader, RefreshNeeded.
which would be called as follows from CheckAndUpdate:
    local procedure CheckAndUpdate(var SalesHeader: Record "Sales Header")
    var
        GenJnlCheckLine: Codeunit "Gen. Jnl.-Check Line";
        CheckDimensions: Codeunit "Check Dimensions";
        ErrorContextElement: Codeunit "Error Context Element";
        ForwardLinkMgt: Codeunit "Forward Link Mgt.";
        ReportDistributionManagement: Codeunit "Report Distribution Management";
        SetupRecID: RecordID;
        ModifyHeader: Boolean;
        RefreshTempLinesNeeded: Boolean;
    begin
       ...
            CheckPostRestrictions(SalesHeader);

            if Invoice then
                Invoice := CalcInvoice(SalesHeader);
            // NEW EVENT >>
            RefreshTempLinesNeeded := false;
            OnCheckAndUpdateOnBeforeCopyAndCheckItemCharge(SalesHeader, WhseReceive, WhseShip, RefreshTempLinesNeeded);
            if RefreshTempLinesNeeded then
                RefreshTempLines(SalesHeader, TempSalesLineGlobal);
            // NEW EVENT <<
            if Invoice then
                CopyAndCheckItemCharge(SalesHeader);

            if Invoice and not IsCreditDocType then
                TestField("Due Date");

Similar to how event OnCheckAndUpdateOnBeforeCalcInvDiscount was added following the exact same pattern.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


@conda-forge-admin,please add bot automerge

Issue:

Environment (conda list):

$ conda list

Details about  conda and system ( conda info ):

$ conda info

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/credstash-feedstock#7.


Update reset-a-conference-id-for-a-user.md

Per the SFB product group, changes to static are no longer supported. Engaging Support will trigger the same response.

Thank you! Appreciate it. Tony


Feature Request: Support offering client certificate as array (chain) in ssl option :client_cert

Basic Info

Faraday Version: 1.4
Ruby Version: 3.0.2

Issue description
I am trying to send the array of chain certificates in the SSL hash but I cannot have an error when sending the request, to be honest, I am not sure if Faraday or the current version of faraday supports this SSL request
Steps to reproduce
Create the Certificate array chain [OpenSSL::X509::Certificate, .... n]
Add in the SSL hash in the request
post = {...}
ssl = {
   verify: true,
   client_cert: [cert_1, cert_2, cert_3],
   client_key: OpenSSL::PKey::RSA.new("Key_String")
 }
 headers = {
   'Content-Type': 'application/json'
 }
url = "https://demo.com/test"

response = JSON.parse(Faraday.new(url, ssl: ssl).send(:put, url, post.to_json, headers).body)

Is this issue still actual?
Suggested solution №2 sounds reasonable and easy to solve. I would be happy to figure out on solution if it is still actual

I didn't bump into this issue myself, but I also haven't seen any PR addressing this.
So I suspect this is still not possible if someone wants to do it and thus ready to be picked up if you'd like to give it a stab @aka-nez 🙌

In order to clarify the state of things, I renamed this Issue to something that can be fixed by improving this adapter.


Provide the possibility of activating SELinux for RHEL, CentOS (and Flatcar maybe)

The goal of this task is to provide the possibility of enabling SELinux for machines using RHEL, CentOS and maybe Flatcar.
https://github.com/kubermatic/machine-controller/blob/master/pkg/userdata/rhel/provider.go#L159
https://github.com/kubermatic/machine-controller/blob/master/pkg/userdata/centos/provider.go#L152

/remove-lifecycle rotten


Error while updating property 'showLocalVideo' of a view managed by: RCTAgoraVideoView

Hi,
I only encounter this problem in the project I created. While everything is going well, it gives this error after the program is closed and opened. It works smoothly for the first time but closes on the second.
I guess I can't close the agora properly with modal. My close method;
  endCall = () => {
        RtcEngine.leaveChannel().then(r => {
            this.setState({
                peerIds    : [],
                joinSucceed: false,
            });
            this.props.CallStore.closeModal();
        });

    }

the second time I try to open the program I get this error.

this is where I get the error

can this parameter have a special use? or am I using it in the wrong place?
Best regards.

Maybe you can try the beta version

you can reopen this issue if the problem still exists.


Added records-per-iteration for --server mode

Now will return specified number of records per iteration, instead of
single record by default.
Updated cli docs to include records per iteration info
Some code clean up per pylint and pycharm inspections
Bumped to 0.2.2 for this small change/fix

Codecov Report

Merging #43 (a286f45) into develop (0df60c2) will decrease coverage by 0.05%.
The diff coverage is 93.10%.

@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
- Coverage    97.37%   97.32%   -0.06%
===========================================
  Files           35       35
  Lines         2938     2952      +14
===========================================
+ Hits          2861     2873      +12
- Misses          77       79       +2

Impacted Files
Coverage Δ

datacraft/builder.py
98.65% <ø> (ø)

datacraft/supplier/calculate.py
100.00% <ø> (ø)

datacraft/_registered_types.py
97.48% <66.66%> (-0.20%)
:arrow_down:

datacraft/server.py
96.87% <90.90%> (-3.13%)
:arrow_down:

datacraft/__init__.py
100.00% <100.00%> (ø)

datacraft/__main__.py
100.00% <100.00%> (ø)

datacraft/cli.py
96.57% <100.00%> (+0.05%)
:arrow_up:

datacraft/preprocessor.py
97.45% <100.00%> (ø)

datacraft/supplier/combine.py
100.00% <100.00%> (ø)

datacraft/supplier/model.py
94.91% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df60c2...a286f45. Read the comment docs.


Plugin not compiling in Unity 2018.3.14f1

After creating a fresh project in Unity 2018.3.14f1, enable OpenVR desktop from package manager, having installed steam and steam VR and installing steamvr unity plugin version Version 2.7.3 I get 3 errors in console and the plugin does not work at all:
Assembly has reference to non-existent assembly 'Unity.XR.OpenVR' (Assets/SteamVR/Input/Editor/SteamVR_Input_Editor.asmdef)
Assembly has reference to non-existent assembly 'Unity.XR.OpenVR' (Assets/SteamVR/Editor/SteamVR_Editor.asmdef)
Assembly has reference to non-existent assembly 'Unity.XR.OpenVR' (Assets/SteamVR/SteamVR.asmdef)

After two days no response, is this plugin dead?
For those interested as a workaround I found that version SteamVR_v220 is working without errors. Strange because for the latest patch/release on February it is stated that the backwards compatibility is fixed with Unity 2019 and 2018.

I would not recommend using version 2.2 as it is quite old and unsupported at this point. That is an odd error you're getting though. Is it possible to upgrade your version of unity to 2018.4?

I would not recommend using version 2.2 as it is quite old and unsupported at this point. That is an odd error you're getting though. Is it possible to upgrade your version of unity to 2018.4?

Thank you very much for your response and advice! I have to assess the implications for upgrading unity to 2018.4 and I will definitely do the upgrade at some point. For the moment this version of plugin is ok because I could map the actions to controllers, teleport/hands are working fine, and I don't have any other integrations with steam VR.


Documentation for Fetch API

Added some code samples for Fetch API usage
https://appsmith-docs-git-fetchapi-get-appsmith.vercel.app/core-concepts/writing-code/javascript-promises#fetch-api

@arunvjn could you please review my code examples?

@bharath31 Is this a new framework function. If yes, could you create an issue on docs to link to the engineering issue so that we have more context and also when this is due to be released?

@danciaclara this is already live. Support for fetch API was released as a part of Custom JS Libs


Add logging to exception thrown in cart

Whenever a product cannot be added to cart, an exception is thrown.
This PR offers logging with context, when that exception occurs, making it possible to retrieve and repair the faulty product.
Provoking an exception is not that easy at that point. In order to test my changes, you could

create a new downloadable product
in Product/Type/Downloadable.php, copy line 165 and paste it two lines above, i.e. to the very beginning of function prepareForCart()
try to add the Downloadable to cart
wait for the message: "Downloadable links are missing for this product."
browse storage/logs/laravel.log, at the end of the file there should be the same message again, along with the product and cart data

[2020-06-09 11:40:36] local.ERROR: Downloadable links are missing for this product.
 {"product":{"Webkul\\Product\\Models\\Product":{"id":1,"sku":"1","type":"downloadable",
"created_at":"2020-06-09 11:36:01","updated_at":"2020-06-09 11:36:01",
"parent_id":null,"attribute_family_id":1,"short_description":"
Download 1
","description":"

Download 1
","name":"Download 1","url_key":"download-1",
"tax_category_id":0,"new":0,"featured":1,"visible_individually":1,"status":1,"color":1,"size":6,
"brand":null,"guest_checkout":0,"meta_title":"","meta_keywords":"","meta_description":"",
"price":"10.0000","cost":null,"special_price":null,"special_price_from":null,
"special_price_to":null,"width":null,"height":null,"depth":null,"weight":null,
"attribute_family":{"id":1,"code":"default","name":"Default","status":0,"is_user_defined":1}}},
"cartData":{"is_buy_now":"0","_token":"scvjMwMDiOdkRebCeILKjslPHMVOX4tbXuNYwykL",
"product_id":"1","quantity":"1","links":["1"]}}

I noticed that there are two log entries now, because laravel logs the exception on itself.
Thinking about it again...

Alright, I removed the logging from Cart now and added it to the different CartController calling the Cart's function addProduct(). This way, the exception is catched everywhere and logged only once.
Unfortunately, I cannot provide a test.  At the moment, I have no idea how to provoke an exception during an automatical test. But it still can be human tested as described above.


View statistics of algorithm's pending requests in a graph view

As a HKube manager I want to be able to view statistics of algorithm's pending requests in a graph view, so that I can analyze the resources allocation mechanism and sizing of system resources over time.
User Story implementation details:

Statistics of algorithm's pending requests means: 50 & 90 percentile of algorithm's pending (state = pending) requests per minute
Each of the statistics information will be calculated separately per algorithm type.
Graph view is detailed in #110

TID-205


Use GitHub's URL shortener

git.io is GitHub's own URL shortener, which is guaranteed to only point to GitHub domains. This is safer and (IMO) more professional. Additionally, goo.gl will be deprecated very soon.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


command (and page?) search lazy loads bad results

Something seems to be off about the async updates for searching commands and pages. The inital typing seems to be a fast list reduction but eventually new results will load in, which don't seem to be using the input.

This is really strange, and I cannot replicate this myself. After typing "update" here you only wait, you're not pressing any additional keys?

Correct, But I just realized it is only an issue when the Debug: Show Logs is active. I'm guessing there is a timed task that updates the log windows and somehow loses the typed in state of the input

Ah yes indeed, I've noticed that too in the past. It's specific to the reload behavior of show logs indeed.

Fixed this for now by making refresh a manual operation, not a great solution but it works.


Fixed the issue that some commands stopped the spinner too early

See commit message.

Coverage increased (+0.3%) to 37.191% when pulling e2098c115e48df9ad6686dd7cf1b12d79aff062e on andy/fixed-spinner into 20aabab166ee72c920d794cd34faa90d184459fb on master.


FAQ page

Q: "I just started using a new component, but it looks weird"
A: Have you updated your theme? We can't make a hard dependency between components and themes; different themes get released independently so their version numbers are out of sync. In the release notes for the theme we mention when we add support for a new component. Just make sure the component you are using and that looks weird is supported in the version of the theme you are using


Add documentation to add a new model to the repo

Hello, I would like to ask myself how to add a new model

You basically have to factor your model code like one of the existing models https://github.com/openvinotoolkit/anomalib/tree/development/anomalib/models
then you have to add tests and documentation and create a pull request :)

Addressed with #576.


chore!: Replace computing hashes in circuits wasm, with computing them in ts via bb.js pedersen call.

This was originally going to use our TS pedersen lib to do all pedersen computations, but wasm is 10x faster, so we still want to use wasm.
Introduce elliptic version of pedersen as it can be much faster than @noble/curves (WARNING: Jest totally messes with benchmarks and can't be trusted for timings with this stuff). Leaving noble version in for now in case want to revisit, but not exported via index. The elliptic version is also just there as reference (maybe useful in future).
The pedersen api required being passed a wasm, and that wasm was obtained via async call. This creates a tonne of async function overhead and is generally a bit of a faff.
This adds foundation/crypto/pedersen/pedersen.wasm.ts (and defaults to using it via index.ts) that mimics our pure TS pedersen api, but uses the bb.js wasm.
Adds a hand rolled synchronous pedersen bind caller to bb.js (I should probably bring back making bindgen produce the sync api, but also figured might adopt Adams msgpack approach so not worth effort).
foundation/crypto/pedersen leverages top-level await to load the wasm as a global, so we can remove a tonne of async await calls.
We cleanup some of the c_binds in barretenberg.
We still use circuits.wasm for a couple of more complex calls ive not tackled yet, e.g. hashVK.
We now have dependency on bb.js, pulled in via portal yarn thingy. What does this mean for releases? (edit: This would probably have broken canary. This PR disabled canary. https://github.com/AztecProtocol/aztec-packages/pull/3244)
Pulls the bbmalloc WASM_EXPORTS into own header so it doesn't mess with the bindgen util.
Broke some circular import dependencies as I was hitting weird errors.
All pedersen calls now made on foundation/crypto/pedersen, got rid of circuits/barretenberg/crypto/pedersen wrapper.
Enable colorizing debug output in e2e tests via DEBUG_COLOR=1.
Change some test() to it() (was faffing with other test runner when profiling pedersen).
Timer uses performance.now rather than Date.getTime()
Introduces madge as a tool to detect circular deps.

TODO in subsequent PR's.

Move all the hashing functions in abis.ts to exist as hash functions on the various types.
Implement hash functions for e.g. vkHash and a couple others that were to complicated for doing right now.
Move the types out of circuits.js into types project.
Ultimately remove need for circuits.js / circuits.wasm?

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 4161be99 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,984
868,232
3,449,504

l1_rollup_execution_gas
842,071
3,595,340
22,204,873

l2_block_processing_time_in_ms
2,005
7,613
30,039

note_successful_decrypting_time_in_ms
292 (-2%)
866 (-2%)
3,175 (-2%)

note_trial_decrypting_time_in_ms
94.1 (-4%)
74.9 (-20%)
133 (-1%)

l2_block_building_time_in_ms
13,158 (-3%)
51,986 (-2%)
208,863 (-1%)

l2_block_rollup_simulation_time_in_ms
11,811 (-3%)
46,689 (-2%)
187,764 (-1%)

l2_block_public_tx_process_time_in_ms
1,306 (-1%)
5,161 (-2%)
20,611 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
21,741
42,431 (-1%)

note_history_successful_decrypting_time_in_ms
2,022
3,967 (-1%)

note_history_trial_decrypting_time_in_ms
121
145 (+1%)

node_database_size_in_bytes
1,629,874
1,097,059

pxe_database_size_in_bytes
29,748
59,307

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
773 (-1%)
61,697
18,905

private-kernel-ordering
123 (-1%)
24,297
8,153

base-rollup
1,764 (-1%)
656,311
814

root-rollup
75.3 (-15%)
4,072
1,097

private-kernel-inner
789 (-1%)
81,568
18,905

public-kernel-private-input
41.0 (-2%)
41,519
18,841

public-kernel-non-first-iteration
25.8 (-3%)
41,497
18,841

merge-rollup
0.956 (+1%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
8,787
27,548

I'll keep this review light on the principle of engineers reviewing their own work first and foremost, so kept the review to 'am I comfortable with what I read here'. The above comments are the main stuff, otherwise I saw a lot of propagation of async/await removal and read the comments above, LGTM.
One thing missing: The motivation, just for posterity, is to move away off of circuits dependency gradually, right?

One thing missing: The motivation, just for posterity, is to move away off of circuits dependency gradually, right?

Yeah. The ultimate reason is to have much more of a pure TypeScript reference client rather than this extremely strong coupling with the C++ code/wasm. So bb.js can hopefully act as a lib for building proofs with a simple api, noir has their TS packages we can use, and then hopefully all of our yarn-project can just be pure TS.
A side reason for this is just having the wasm plumbed into a hash function we use all over the place seems a bit off. It's nicer when the api is how it is in this PR, as we can easily switch how the hash is computed. Wether its a wasm, TS, or something else, is now encapsulated within the foundation/crypto/pedersen module.


Implement RFC 0044: Provide Global Mechanism to Disable SBOM Generation

Summary
Implement RFC 0044 by checking for BP_DISABLE_SBOM as one of the first things in build.go and, if set, return early.
Alternatives considered

Change detect.go to bail out, if BP_DISABLE_SBOM is set. I guess that would be the more "idiomatic" way of doing it, but:

It breaks other buildpacks requiring syft as no one will provide syft anymore. This could be fixed, by making sure other buildpacks only require syft, if BP_DISABLE_SBOM is not set, but I don't think that's worth it.
There is no chance to set the io.paketo.sbom.disabled label (AFAIK) as suggested by the RFC (this could also be moved to other buildpacks, but again I don't think that's worth it ).

Open Questions
Should the buildpack log that sbom generation is skipped? After all that is its only purpose, so might be worth logging.
Use Cases
See RFC 0044
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

I'm not sold on allowing users to disable SBOM generation

@dmikusa You are actually the one who approved RFC 0044 :laughing:
I don't really care, if this ever gets merged. I just thought it's an approved RFC so shouldn't be controversial and I had some time to spare for contributions.
Maybe @ryanmoran as the author of the RFC can address your concerns. Otherwise feel free to close this (and maybe you should revisit the RFC process)

Yes, I was part of that. If I recall, RFC was more about having an agreed-upon way to implement this if language families want to implement it. I know it's important for some languages, like Javascript/Node.js where the SBOM generation is much slower (minutes). I had similar feelings back then as I still do now, but the way we implemented the RFC it provides a framework for this to be implemented where the trade-off is worth it.
While I don't see the benefit, I don't want to speak for everyone either. So what I will do is open an issue on libpak as a placeholder. If people provide some use cases where this is important for Java users, then we can circle back and look at implementing this.

Oh, for some reason I thought that syft was used by other language families as well. That does not seem to be the case.


AP gap between local evaluation and online server?

Hi, I evaluate vehicle bin file on validation set locally by using python API (sets overlap with nlzs zero), get 52.21%; while the online server gets 60.24%; Why such a big gap? Any suggestion?

Maybe read https://github.com/waymo-research/waymo-open-dataset/issues/121?
A couple of causes:

You did not prepare the ground truth correctly (i.e. did not filter boxes without points).
You did not compute the difficulty level correctly

@peisun1115 Yes, I just forget to filter zeros points box, after filter zeros point boxes, I get 63%. It seems higher than the online server.

@jiangzhengkai It is likely because of inaccurate difficulty computation. Follow this.


Ability to import Argo Workflows and then modify as per need

As an end user, I would like to be able to use an existing Argo Workflow yaml template, import it in Chaos Center and then modify it further. Here is a trivial example workflow that I am trying to import in Litmus Chaos and create a workflow but getting an error.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
 namespace: argo
 generateName: dag-diamond-coinflip-
 annotations:
  workflows.argoproj.io/description: |
   http looad generation defined as a DAG.
spec:
 serviceAccountName: argo
 entrypoint: diamond
 templates:
 - name: diamond
  dag:
   tasks:
   - name: A
    template: start
   - name: B
    depends: "A"
    template: generate-traffic
   - name: C
    depends: "A"
    template: generate-traffic
   - name: D
    depends: "A"
    template: generate-traffic
 - name: start
  script:
   #image: python:alpine3.6
   image: nyurik/alpine-python3-requests
   command: [python]
   source: |
    print("Start")
 - name: generate-traffic
  script:
   #image: python:alpine3.6
   image: nyurik/alpine-python3-requests
   command: [python]
   source: |
    import threading
    import requests
    def worker(num):
     """thread worker function"""
     url = 'http://<IP_ADDRESS>:32212/'
     r = requests.post(url)
     print(r.text)
    threads = []
    #for i in range(1):
    i = 1
    while True:
     t = threading.Thread(target=worker, args=(i,))
     threads.append(t)
     t.start()
     i += 1

Hi @faisalchishtii, you need to upload a valid LitmusChaos workflow. Not all Argo workflows can be run using LitmusChaos.


Contents of CIT directory seem not to be added to the texture atlas

Right off the bat this is not an issue where CIT textures aren't working but speculars and normals, textures used for storing things like reflectiveness in shaders which are not working. To justify why I think this is a Resewn issue and not on Iris/shader packs is that in Optifine speculars and normals for CIT textures work as expected. That is to say that like with a vanilla texture you simply place it in the same directory. I highly suspect this is an issue relating to the texture atlas or how the CIT textures are registered so it might require a significant rework to the code to fix.
Attached is a basic resource pack to better demonstrate this issue. As well as my configuration file for Complementary Reimaged v2.2 which is a shader with labPBR specular support (not relevant to issue just the format of my speculars) and the one I personally use. I also tested Complementary v4 and BSL which have the same behavior.
CIT specular debug pack.zip
ComplementaryReimagined_r2.2.zip.txt
Each variant uses identical specular textures to the ones used when no CIT is applied IE the vanilla texture is being used. The CITs are for 3 items including the elytra. They are the Bucket, the Totem of Undying and the Elytra because this issue also effects the "armor" texture when worn.
These three items have 3 "variants" accessed via renaming. They are "resewn" for simply placing the specular texture in the same location the base texture is in this pack that's with the properties file, "vanilla" placing both the base and specular texture under a vanilla texture path which is added to the atlas for this pack that's "textures/item/cit" and "manual" placing both the base and specular texture under a newly created directory "textures/cit" which is manually added to the atlas in blocks.json.
These three variants are easily distinguishable in game through color coding, resewn has blue textures, vanilla are magenta and manual are green. There is no particular reason for these colors it just makes it easy to verify the correct texture is being used.
Of these variants resewn are the only ones which exhibit no specular effects, when using Optifine however it has specular effects for all 3.
The following screenshots are rather self explanatory but I'll give a quick explanation of what is expected. Firstly each screenshot has the held items name to easily tell them apart aside from the solid color differences. The totem on the left (offhand) is the vanilla texture, it is somewhat reflective and has glowing eyes. The resewn totem should reflect the vanilla totem as well as have glowing eyes (better seen in the other two working variants).

This is the CIT totem with it's assets under a vanilla path IE the "textures/item/cit" one. Like the previous it should have glowing eyes and be somewhat reflective. You can clearly see what would be glowing eyes if it weren't for the solid colors as well as a slight reflection of the vanilla totem in the offhand.

This is the CIT totem with it's assets under the manually created "textures/cit" path which is added to the atlas manually via blocks.json. This like the previous totem should be reflective and have glowing eyes. In this totem you can clearly see the reflection of the vanilla totem in the offhand due to it's lighter color.

Here is a screenshot of the resewn variant working under Optifine with no other changes.

Fixing this issue might be as simple as adding the cit directory to the atlas which doesn't seem possible through a resource pack. At the very least I was unable to do so by using the relative "../optifine/cit" path.

So this is less of an issue with the atlases and more of an issue with how CIT Resewn presents texture identifiers to the game.
Most likely a duplicate of #149 and just that special handling was added in continuity for emissives but there isnt one in Iris for speculars and normals(which is totally understandable).
Right now CIT Resewn just tells the game a unique absolute path which it handles internally but this is not expected behavior that these mods take into account.
The model rewrite already has a plan to solve this issue by internally moving old "legacy" textures to modern identifiers so they'd get support from other mods' special texture features.
For now I am marking this as a duplicate of #149 as it should be resolved once a proper "correct" fix is added by CIT Resewn which would fix both issues.

Strange that there's a difference when referencing textures in the atlas then? From the sounds of it it should have the same behavior as the (implicit) absolute path when pointing to a local CIT texture. I guess since the absolute path is also a modern identifier it just works? Appreciate the clarification.
Glad this will be getting fixed eventually as otherwise I'd be looking at least an hour of tedious work moving textures and editing CIT properties. Thanks for your work!

If you want the details on what really happens I suggest reading #149. Essentially absolute identifiers are not "modern", and I have to have specual handling for them(currently differentiated by suffixing them with their file extensions .png). The mods that rely on the file extension not being there will attempt to use ".png_e.png" which ofc fails. I suppose the same is happening with other suffix based asset checks

So basically my question is why does an absolute path sometimes work and sometimes not? Even though I'm pointing to an texture that should have a modern identifier (my manual or "automatic" atlas stuff) it should still be using an absolute identifier for the actual CIT right? Or in other words we point to a texture and include the extention but someplace else (the identifier vanilla creates) does it "correctly" (no extension). IE how does the presence of a modern identifier make the absolute identifier correctly exhibit the specular effects even though it seems like it shouldn't?
My comment of "I guess since the absolute path is also a modern identifier so it just works?" is cause I can only guess things somehow just work™ cause a non extension identifier exists and somehow it's recognized that the two separate identifiers are for the same asset so Iris manages to load the specular map. Far as I understand none of my examples should have worked at all yet two of them did, they both through being added to the texture atlas had modern identifiers created for them automatically I'd assume. Even though we don't use these identifiers the specular effects show up which I guess could be a really lazy and crude way to fix the issue?

My guess would be that it just depends on how I set up the requirement for absolute paths but honestly, I just dont know. Afaik it just shouldnt work, and I am specifically not interested in looking into why it works because it's going to be rewritten regardless..
I'm also still having a little trouble understanding what you mean when you say "modern" identifiers. Identifiers in the texture space are only supposed to specify the texture's name(without the .png) and in newer minecraft it locates where they are in the assets by the texture atlas specifications in the resourcepack.
CITR just injects somewhere inside the game and checks if the identifier already has a .png extension and then it treats it as an absolute path in the assets, which is not a thing that other mods expect to happen. That's all really..
I dont really know why it would work beyond that but if you want to look into it, you're free to do so, this is exactly the reason I love open source, anyone can look at the code if they want to learn something.

I thought you had used the term to describe identifiers without the extension but it seems I misread

The model rewrite already has a plan to solve this issue by internally moving old "legacy" textures to modern identifiers so they'd get support from other mods' special texture features.

As for looking into it I'd like to, honestly I started out by trying to find some sort of bug in the code cause I was convinced the textures were being registered under a incorrect path or something of the sort. I mostly have a bearing on what's going on thanks to modding in 1.12 Forge but well stuff is different enough where I don't have a firm grasp on it well as the mod being Fabric, not Forge. I am rather interested in being a complete unga bunga cave man and crudely making identifiers for stuff without touching however the mod currently works just to see what happens but honestly I don't wanna deal with whatever setup is involved for a dev instance. I hear it's a lot less of a hassle with Fabric but bleeh.
Got a lot to do just with the resource pack I've been messing with don't really want to spend a day or so figuring out fabric enough to maybe come up with a fix to a problem that at the end of the day I only really notice cause I'm a perfectionist. Speaking of I did try renaming a few CIT speculars in the style of .png_s.png which did not seem to work. If it had I'd happily deal with that stupidity till resewn eventually released a fix lol.
If I do end up messing with it I guess I'll say what the results were here? The whole learning Fabric + 1.19 MC is just not that appealing though...


Gutter highlights make breakpoints unclickable

Describe the bug
When there are highlights for code coverage in the "gutter" it makes the area unclickable which prevents breakpoints being set. This seems like a rather big deal.
To Reproduce
Steps to reproduce the behaviour:

Go to a file with coverage
Click on an area covered by a highlight where you would like a breakpoint
Nothing happens

Expected behaviour
For step 3 it is expected that a breakpoint would be set/unset.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: windows]
Extension Version: 2.4.3
VSCode Version: 1.42

@Troto Thanks for submitting an issue! This is a known limitation with the current gutter icon api that microsoft gives to extension developers. You can see a workaround here in the readme to allow for both coverage and breakpoints to work properly https://github.com/ryanluker/vscode-coverage-gutters#tips-and-tricks. This may also help you @alex-broad if you are having similar issues.

@Troto going to close this issue but hopefully in the future there is improvements to the extension api that allow gutter icons and breakpoints to live together :grin:


updated sabnzbd (1.0.0)

Should have an appcast, as releases are now on github - https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/appcast.md

done

Thank you for the contribution. It was merged directly as fa41946cfd7f08117b0db6a4d14f874872400928 to keep commit history cleaner. Your contribution is still credited to you.


Results do not match other implementations

The following queries provide results that do not match those of other implementations of JSONPath
(compare https://cburgmer.github.io/json-path-comparison/):

[ ] $[-1]
Input:
["first", "second", "third"]

Expected output:
["third"]

Actual output:
[]

[ ] $[1:10]
Input:
["first", "second", "third"]

Expected output:
["second", "third"]

Error:
Offset and length were out of bounds for the array or count is greater than the number of elements from index to the end of the source collection.

[ ] $..*
Input:
{"key": "value", "another key": {"complex": "string", "primitives": [0, 1]}}

Expected output:
["string", "value", 0, 1, [0, 1], {"complex": "string", "primitives": [0, 1]}]

Actual output:
["string", "value", 0, 1, [0, 1], {"complex": "string", "primitives": [0, 1]}, {"another key": {"complex": "string", "primitives": [0, 1]}, "key": "value"}]

[ ] $..*
Input:
[40, null, 42]

Expected output:
[40, null, 42]

Actual output:
[[40, null, 42], 40, null, 42]

For reference, the output was generated by the program in https://github.com/cburgmer/json-path-comparison/tree/master/implementations/dotNET_Manatee.Json.

Thanks for reporting this. I'll have a look.  I have tests that cover the examples given in the JSON path blog post, but I'm afraid there's not any other docs or spec for it.

Okay... let's take these one at a time.  I used https://jsonpath.com/ (powered by https://github.com/s3u/JSONPath) for my comparisons.
$[-1]
This is saying that I want the -1st (-1th?) index.  It doesn't state that it should take the last element.  To do that you want $[-1:] (note the colon).  The different is that the colon indicates that we want to interpret the index value as a slice rather than an numerical index.  An array doesn't have a -1 index.
Your syntax works for some languages (including C# with v8), but it's not valid for JSON Path.  My implementation is correct.
$[1:10]
Technically, the error's not wrong, though the library should be tolerant of such cases, as it is with the -1 case.  I'll fix this.
$..*
Looks like I'm returning the root object as well as the members.  Goessner's post is not too specific about this.  He simply states, "All members of JSON structure."  I can fix this too.

Please see v12.0.2 for the fixes.


Should increase sterling script deploy timeout to 120 minutes

Timeout is currently 90 minutes. Given that the script will wait for 90 minutes for the last step, the overall timeout should be greater.

Closed with #62


chore: remove docs/generate_members.py

This is a really old file and not used nor relevant any more
contributing guide: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md

I'd like to work on this.

Oh, just saw that this is already being solved by #1012 .


WebSocket connection to 'wss://www.walletlink.org/rpc' failed: RxWebSocket.js:41

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
1.0.8
wagmi Version
1.3.10
Current Behavior
After leaving web page idle for some time, error in the post title will occur.
Expected Behavior
No error.
Steps To Reproduce
Create a new NextJS project by running below command:
npx create-next-app@latest
Install RainbowKit by running below command:
npm install @rainbow-me/rainbowkit wagmi viem
Install ethers by running below command:
npm install ethers
Update next.config.js file to avoid certain bugs:
webpack: (config) => {
config.resolve.fallback = { fs: false, net: false, tls: false };
config.externals.push('pino-pretty', 'lokijs', 'encoding')
return config
},
Add providers.js and edit layout.js to establish RainbowKit connection;
Place connection button by edit page.js file;
Run below command to get web page running:
npm run dev
After web page become idle for some time, below error will appear:

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

@linghuccc Are you still seeing this issue? Can you try testing behind a VPN or different VPN? This is the websocket that the Coinbase Wallet connector uses to bootstrap their WalletConnect-equivalent pairing. It is unfortunately out of control, and subject to firewall blocking, throttling, or outages. Is this isolated to this project, or do you see this on other projects or RainbowKit.com as well? It is also possible that a dependency conflict with Wagmi's internals or bundling issue could break these websockets.

Dear Daniel,
I report this bug because I have web socket stalled issue while developing NextJS + RainbowKit project. Below is an example:
[cid:b16ffa2f-d89e-4421-bc4e-0a65bbe2cc8f]
I was trying to reproduce above error while had reported error instead.
The error is still here. Actually it persists for months already. I am using CloudFlare VPN and I am not sure if it is related.
Richard

发件人: Daniel Sinclair @.>
发送时间: 2023年9月16日 0:32
收件人: rainbow-me/rainbowkit @.>
抄送: LingHu Chong @.>; Mention @.>
主题: Re: [rainbow-me/rainbowkit] WebSocket connection to 'wss://www.walletlink.org/rpc' failed: RxWebSocket.js:41 (Issue #1512)
@linghuccchttps://github.com/linghuccc Are you still seeing this issue? Can you try testing behind a VPN or different VPN? This is the websocket that the Coinbase Wallet connector uses to bootstrap their WalletConnect-equivalent pairing. It is unfortunately out of control, and subject to firewall blocking, throttling, or outages. Is this isolated to this project, or do you see this on other projects or RainbowKit.com as well? It is also possible that a dependency conflict with Wagmi's internals or bundling issue could break these websockets.
―
Reply to this email directly, view it on GitHubhttps://github.com/rainbow-me/rainbowkit/issues/1512#issuecomment-1721553379, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AODVLYKCDX7LRBI7HXRIVPTX2R7LPANCNFSM6AAAAAA4WPA5KM.
You are receiving this because you were mentioned.Message ID: @.***>

Closing for inactivity. More troubleshooting is available on this Coinbase Wallet SDK issue: https://github.com/coinbase/coinbase-wallet-sdk/issues/318


Added test cases & docs

Resolves #1
Added Test cases to cover more edge cases for inputs of all functions
Added Docs

Hello there.
I hope that at least some of the Test Cases make sense.
I am not sure what to add to the Docs of fn calculate_liquidity_in & calculate_luquidity_out though.
I do have a few more thoughts on this (e.g.: rounding of the result of fn calculate_spot_price), I will can put those to words once I get some sleep.
Any Feedback is appreciated.

Rounding

It seems that the functions round their results as follows:
{calculate_spot_price, calculate_liquidity_in, calculate_liquidity_out} - truncate
{calculate_sell_price, calculate_buy_price} - round up
I guess this is as designed, however let me state one corner case for fn calculate_spot_price:
Formula: BUY_RESERVE * AMOUNT / SELL_RESERVE
Input:
BUY_RESERVE = u128::MAX - 1
SELL_RESERVE = u128::MAX
AMOUNT = 1
u128::MAX-1 * 1 / u128::MAX = 0,9999
Output:
0
Maybe this is of no concern. If it is however, I can think of some more corner cases.

Exception Handling

It is quite easy for a Client to use the functions in a "erronous" manner.
Using fn calculate_spot_price with the following input (which should be semantically correct) might return an unexpected result:
Input:
BUY_RESERVE = sqrt(u128::MAX) + 1
SELL_RESERVE = sqrt(u128::MAX) + 1
AMOUNT = 1
Output:
None
Also, a Client will get the same result for the following input (which is semantically incorrect/formula div by zero):
Input:
BUY_RESERVE = any
SELL_RESERVE = 0
AMOUNT = any
Output:
None
Maybe it would be worth the effort to try to distinguish between these cases, as I think that a Client should not have to know implementation details of a function in order to be able to use it properly.
However I am new to Rust/Web3 and maybe all of this makes sense in given the Context.
Feedback would be appreciated. :)
Thanks in advance

Thanks.
Yes, absolutely correct. However it is not in progress as this math was extracted as is from the main repo where such bad cases would never happen ( like sell_reserve = 0 ).
But there cannot be such assumptions here of course.
Would you be willing to look at property testing - something like this proptest and use it here if possible ?
Another issue is to use Result for proper error handling ( #3  ).

Thanks for the reply, I will surely look into property testing.
Had a conversation regarding issue today with jakub, need to process all the data :)

Docs for fn calculate_buy_price state:
/// Calculating buying price given reserve of selling asset and reserve of buying asset. /// Formula : SELL_RESERVE * AMOUNT / (BUY_RESERVE - AMOUNT )

yes. correct. definitely needs better description. Docs/words are hard.

Thanks for the reply, I will surely look into property testing.
Had a conversation regarding issue today with jakub, need to process all the data :)
I do have one question though:
Docs for fn calculate_buy_price state:
/// Calculating buying price given reserve of selling asset and reserve of buying asset. /// Formula : SELL_RESERVE * AMOUNT / (BUY_RESERVE - AMOUNT )
To me it was a bit confusing that it says "given reserve of selling asset and reserve of buying asset".
One could argue that the three parameters are the given part:
{sell_reserve, buy_reserve, amount}
Do you see any potential issue here that is worth thinking about?
PS:
Sorry for the awful formatting, my formatting skills here are weak :)

Yes the docs could use better wording. We also have a movement to get rid of the sell and buy references as it is clear to some people but completely confusing to other. We are going to use in and out like everybody else does instead of sell and buy (change from the point of actor to point of the pool itself) The only place where sell and buy will be left probably is user facing functions. This could clear some stuff. So here it would change to.
reserve_in * amount / (reserve_out - amount) and the corresponding docs should be updated. I'll probably create new issue linking these.

Thanks. I will go through all these changes shortly.
But can i revert the "create renamed" and make as separate change in new PR ?  Probably same with the renaming of sell/buy with in/out. So we have multiple issue in one PR.

Of course, please do so.
I was wondering how you would like these issues to be split up into PRs, but i didnt want to ask more questions as i already asked a zillion :D

Done.
I'll create seperate PRs for these changes.

Done.
I'll create seperate PRs for these changes.

yes, thanks. I really meant "can you revert" in the original posts. so great.


Add change pin of current key command to solo tool

Add change pin of current key into solo tool.
it will help user change PIN directly from command line.

LGTM!
I added a set-pin command, as I could not test otherwise :)


Feature: Config diff for custom charts.

🔖 Feature description
Want a config diff view for custom charts also during deployment.
🎤 Pitch / Usecases
Someone might want to use his own chart instead of what is already present.
🔄 Alternative
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

fixed in this :- https://github.com/devtron-labs/devtron/pull/5837


invalid orc download link

Describe the bug
The link address specified in thirdparty/vars.sh for orc archive is invalid.
 ORC_DOWNLOAD="http://mirror.bit.edu.cn/apache/orc/orc-1.5.8/orc-1.5.8.tar.gz"

--2020-04-29 15:48:07--  http://mirror.bit.edu.cn/apache/orc/orc-1.5.8/orc-1.5.8.tar.gz
Resolving mirror.bit.edu.cn (mirror.bit.edu.cn)... <IP_ADDRESS>
Connecting to mirror.bit.edu.cn (mirror.bit.edu.cn)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found

To Reproduce
rm -rf thirdparty/src/* && bash .thirdparty/build-thirdparty.sh

I will fix download link, you can download it by "https://github.com/apache/orc/archive/rel/release-1.5.8.tar.gz"

@sduzh
Can you fix this for us?


d4mac, d4win 17.07.0 edge release

What's changed

added edge release notes for d4mac 17.07.0

added edge release notes for d4win 17.07.0

also added release notes for 17.06.1 mac and win (upgrades only)

Reviewers
@jeanlaurent @friism
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

You shouldn't base this on master should you?

@mstanleyjones I'll wait to merge until the release is out

@mstanleyjones this is the way these are shown on stable and edge changelogs, which speaks to the problems we were talking about earlier, so leaving for now and I'll show you the changelogs in the private repo.


Roll out eager Prebid for desktop

What does this change?
This PR removes the AB test and rolls out the new behaviour for eager Prebid, first implemented in this this PR.
Note we're just rolling out the behaviour for Desktop breakpoints and above, and retaining the original non-eager behaviour for mobile/tablet. When we do run Prebid eagerly, we adjust the display margin to 10%, matching variant-2 in the original AB test.
Hence the new behaviour is:

mobile and tablet: A single intersection observer that fires when an ad slot is 20% of the viewport away.
desktop and wide: An intersection observer that fires when an ad slot is 10% of the viewport away, and initiates a Prebid auction when ad slot is 50% of the viewport away.

This is captured by a basic unit test, but we should also run an end-to-end test for this some time in the future.
Why?
This test concluded with favourable results for desktop screen sizes, so we're rolling it out.

Good point about adding an e2e test @deedeeh, will followup!


Custom Arrows disappear on slickAdd

Hello Folks,
i got a little Problem with Slick using its slickAdd Function. If i use this my customs arrows disappear. To be exact they are completly remove from DOM. The Second issue is that the arrows are removed in resposive view as well (everything under 900px) but one step after another.
		target = jQuery('#' + id + " .slide-wrapper");

		var slider = jQuery(target).slick({
			slidesToShow: 4,
			slidesToScroll: 2,
			prevArrow: '#' + id + " .slider-button-left",
			nextArrow: '#' + id + " .slider-button-right",
			infinite: false,
			speed: 1000,
			onAfterChange: function () {
				bLazy.revalidate();
			},
			responsive: [
				{
					breakpoint: 900,
					prevArrow: '#' + id + " .slider-button-left",
					nextArrow: '#' + id + " .slider-button-right",
					settings: {
						slidesToShow: 2,
						slidesToScroll: 1
					}
				},
				{
					breakpoint: 500,
					prevArrow: '#' + id + " .slider-button-left",
					nextArrow: '#' + id + " .slider-button-right",
					settings: {
						slidesToShow: 1,
						slidesToScroll: 1
					}
				}
			]
		});

		jQuery(target).slickAdd("
test
");
		jQuery(target).slickAdd("
test
");
		jQuery(target).slickAdd("
test
");
		jQuery(target).slickAdd("
test
");

Here is a working site with that problem.
http://novacreator.net/testarea/da/index.php
Someone an idea what the heck is wrong there?

I've got the same problem with my custom arrows disappearing.

One possibility: If you have fewer images loaded than you you have in the slidesToShow setting, the arrows will not show.

@tripgrass There are already 8 Elements in the slider and 2 added so i think it is not this issue
@ssauceda Thanks for advice ... but i am not using unslick ... do did not even know this function

Can someone provide a reduced test case with jsFiddle? Closing pending a test clearly showing the issue.

Please see the behaviour reproduced in this fiddle: https://jsfiddle.net/9pxucLhj/4/
Thanks for looking into this!

Hello,
I've faced the same issue after a responsive breakpoint is reached. So I've commented these lines in the destroy method :
if (_.$prevArrow && (typeof _.options.prevArrow !== 'object')) {
.$prevArrow.remove();
}
if (.$nextArrow && (typeof _.options.nextArrow !== 'object')) {
_.$nextArrow.remove();
}
My custom arrows aren't removed from the DOM anymore :smile:

Should be fixed by this commit: https://github.com/simeydotme/slick/commit/adfbfd1f446e33915c6c53a22f7a2cda94f7ceee in this PR: https://github.com/kenwheeler/slick/pull/1331


bru electron: bump to version that supports node_extra_ca_certs

Description
Closes #2257. As it turns out, Electron finally added support for this under version v30.0.0 🚀
Electron feature req: https://github.com/electron/electron/issues/41590
Original PR: https://github.com/electron/electron/pull/41689
Backport for v30: https://github.com/electron/electron/pull/41822
Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

@logandavies181 Have you tested if everything works with the latest version of electron ?

Superseeded by https://github.com/usebruno/bruno/pull/2668.


Updating README with AWS signing info

This updates the README with info about installing the aws extras along with elastic-doc-manager for signing requests to AWS Elasticsearch service.
Relates to #5 and #4

Thanks for the pull request but I think it's enough to include this information in the Usage with Elasticsearch wiki page. We already link to it in the README.


Update dependency

Move Git, Bash and SwiftScriptRunner to independen repo.

Codecov Report

Merging #13 into master will decrease coverage by 4.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master      #13     +/-   ##
=========================================
- Coverage   48.04%   43.94%   -4.1%
=========================================
  Files          16       13      -3
  Lines         358      314     -44
=========================================
- Hits          172      138     -34
+ Misses        186      176     -10

Impacted Files
Coverage Δ

...RedmineBotCore/Command/PostCommitHookCommand.swift
61.29% <ø> (ø)
:arrow_up:

...urces/RedmineBotCore/Utility/Path+RedmineBot.swift
13.33% <ø> (ø)
:arrow_up:

Sources/RedmineBotCore/API/CommentRequest.swift
4.08% <ø> (ø)
:arrow_up:

...edmineBotCore/Command/PostRewriteHookCommand.swift
55.93% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b2cd5...940635a. Read the comment docs.


[mgmt] containerservice release

https://github.com/Azure/sdk-release-request/issues/4534

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-arm-containerservice


[Grid] Component rename of argument parameters justify to justifyContent: support justify again.

Hello,
Thanks a lot for your work on material-ui.
I would like to ask for a modification of the Grid component: continue to support the old argument justify argument.
The rationale for my request is users are buiding products on material-ui and a breaking change for no apparent reason is made as  a new keyword argument justifyContent could be equally supported without breaking old code.
Moreover, I would suggest to flag this change as breaking change in your changelog, as you are typically requesting more information from your users (as justifyContent was not necessary before).
Best regards,
David

9

Thanks for the feedback, I have updated the changelog to clarify the motivation


Will mcwss allow me to connect Code Connect (with Minecraft for Windows 10) to a private Bedrock Server?

I have a personal, dedicated, Ubuntu Linux server set up to run a Bedrock Server (using a $5/month 1GB RAM server from Vultr).
I'm using Minecraft for Windows 10 and I'm able to connect Code Connect, when I create a world, following the instructions here:

https://minecraft.makecode.com/setup/minecraft-windows10

...including setting Activate Cheats to the ON position.
When I try connecting to my dedicated Bedrock Server (which has allow-cheats=true set in the server.properties file), I get an error that says:

"Unknown command: wsserver. Please check that the command exists and that you have permission to use it."

Will mcwss help me connect Code Connect (with Minecraft for Windows 10) to my private Bedrock Server?
If yes, where do I install it? On my Linux server (Bedrock Server)? Or in my Windows 10 box running Minecraft for Windows 10?
Many thanks in advance for any help!

/wsserver and /connect is recognized as a command but it's not implemented into BDS software, You can track the bug here https://bugs.mojang.com/browse/BDS-1013


Security concern about Google Map API

<application>
    <meta-data
      android:name="com.google.android.geo.API_KEY"
      android:value="Your Google maps API Key Here"/>
</application>

When we put our key to manifest file, is it possible someone can see and steal it?

Only if you publish your manifest file to the public. You can overcome this by using manifest/gradle variables - see https://developer.android.com/studio/build/manifest-build-variables.html

Another option is to set it as a env variable that is injected during the build process of your CI.
In the end, there are ways to decompile your apk and retrieve the contents of the manifest so there is not real way to contain this information, just make it harder for people to get access.


Add GeoJSON SVG renderer

In addition to large interactive maps, there are parts of the Atlas where we'll need small, non-interactive maps. Example screens in Figma:

1000x400 map on detail page
64x64 map in scrolled header map
290x290 map on comparison page

For a variety of reason, we can't use Mapbox GL JS or Mapbox's Static Images API:

Mapbox GL JS isn't an option for these cases for appearance and cost reasons. Per Mapbox's pricing page, each map on a page counts against the quota as a separate "Map Load for Web". So, 4 large, square maps plus 4 tiny header maps on a comparison page would count as 8 loads. Also, the Mapbox branding info must be visible in all maps, so the bottom third of 64px x 64px maps would be hidden by the Mapbox logo.

Mapbox also offers a cheaper Static Images API, but it is incapable of rendering maps with multiple styled layers and has the same branding issue as Mapbox GL JS.

The alternative is to render images ourselves from PostGIS. Rendering raster images on the backend is possible, but there's more flexibility if we render to SVGs.
d3.js supports rendering GeoJSON to SVGs, so we could use that to render all desired sizes from the one GeoJSON source.
There's an initial /datasets/{dataset}/geometry endpoint to support this, and the needed link for each detail page is included in the data response from /datasets/{dataset}/detail/{id} under _atlas_header_image, e.g. http://localhost:8000/datasets/small-business-support/detail/401011001/ has a link to http://localhost:8000/datasets/small-business-support/geometry/?ids=401011001&include_neighbors=true&format=json.
That endpoint needs work on its output (it sometimes returns the wrong sized bounding box), but it should be suitable for starting work on a renderer.
Styling should be:

fill
fill-opacity
stroke
stroke-width

Background
#0a1216

Requested map feature
#ff8e3c
0.6
#ff8e3c
2

Other map features
#1c2636

#565A61
2

Examples for Adelaide (401011001):

Resolved by #253.


Update fs2-core, fs2-io, ... to 3.10.1

About this PR
📦 Updates

co.fs2:fs2-core
co.fs2:fs2-io
co.fs2:fs2-reactive-streams

from 3.2.14 to 3.10.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "co.fs2" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, commit-count:1

Superseded by #712.


Updates link ubuntu.com/wsl for store listing

In the ProductDescription.xml sources.
CI will generate the derivatives from those.

@EduardGomezEscandell please have a look in the interaction between the first commit and the CI complementing it in this PR. That understanding will be useful in the future.


Revert "properly quote commands"

this PR broke this but it will be easier to patch than revert. closing.


Roadmap

Edit this issue to...

[ ] Replace this with something that should be done
[ ] Replace me too
[ ] Replace... you got the idea

I think I'd rather put a Roadmap in a .md file in the repo. Just so we can keep a better history. But you're right, we need a road map.

As you wish, I just tried to get things moving.

:) Appreciated, @staltz ... leaving this open until their is a valid roadmap.

Closing in favor of #100


boards: arm: rpi_pico: add pyocd runner configuration

Adding configuration for support pyocd.

Raspberry Pi Pico already has configuration by open source solution with OpenOCD for debugging, but the zephyr-sdk currently contains OpenOCD v0.11, which does not support Raspberry Pi Pico.
I added support for PyOCD that can be used alternatively.
The Raspberry Pi Pico manual describes a way of t using OpenOCD, so I do not change the current default of using OpenOCD.

@yonsch
Could you please take a look when you have time?


Align versions in GitHub and NPM

Hello,
I noticed that the version 0.0.2 I pull via npm is a different version than the one I see here on GitHub in the main branch. Can you transfer the Github version to NPM?
kind regards

Hi @DaTebe ,
Thank you for bringing it up, we uploaded version 0.0.3 with all the last changes.


Something is wrong and I have no idea what!

This is an enhancement to docs. Having installed the latest NuGet packages for Nancy and StructureMapNancyBootstrapper, I've had a horrific day trying to get something basic working inside an existing project I could simply have used WebAPI for (specifically, being fairly new to Nancy and it's bootstrapper, I just want a tutorial showing a non-self-hosted setup using the StructureMap Bootstrapper, using an appropriate VS2013 template, for RESTful API endpoints - But I suspect such noobie issues are for SO not here, since nobody has blogged an end-to end with that specific scenario :)
What I'd really like is an end-to-end walk through for non-happy path stuff, since small scale, super-duper-happy-path stuff trades-off against the pain of working with existing legacy code (which is often far from a happy experience and there is naturally so much more of it, so I could argue that's the real 'happy path'). Indeed, copying and pasting the sample from the README.md into VS and I get the attached image indicating that no ApplicationStartup etc. methods exist to override. Has the boot-strapper not got these methods any more? Or perhaps I'm using the wrong IContainer?
So, after that rant, would it be too much to ask to include the using statements as part of the sample?
Thanks

Well, something is clearly wrong.

I've had a horrific day trying to get something basic working inside an existing project I could simply have used WebAPI for

Sorry Nancy made your day horrific. If you could do the same with WebAPI so easily, I suggest you do so instead.

I just want a tutorial showing a non-self-hosted setup using the StructureMap Bootstrapper

If you want docs on hosting a non-self-hosted setup, I suggest you look at the wiki. There's lots of guidance on hosting with ASP.NET, WCF, Azure, OWIN (Katana), Umbraco, Nginx on Ubuntu and with FastCGI. The bootstrapper little to do with the hosting you choose. You just install the bootstrapper of choice, derive from it and override the methods you need. There's loads of examples on custom bootstrappers under in the demo projects (Nancy.Demo.*). We would expect people using Nancy to know how to override methods properly.

What I'd really like is an end-to-end walk through for non-happy path stuff

What specifically do you want here? It's impossible to provide a full guide on building complex applications with Nancy. People are doing large scale, production stuff with it. Not sure we can build your applications for you by providing much documentation on this.

would it be too much to ask to include the using statements as part of the sample?

No. I've already added them. We also take PRs, you know?
Also, this works perfectly fine here:

I suspect such noobie issues are for SO not here

Exactly. If you have other problems trying to figure out the correct using statements etc. I suggest you take it to SO. That's not really Nancy specific.
Thanks!


add NTPsec to projects_to_examine

This makes sense to me.  NTP (the protocol) is clearly important.

Please merge this PR, thank you


Chrome 69?

Tab Modifier version
Browser: Chrome 69.0.3497.100
Extension version: 0.22.0
Steps to reproduce the behavior
Please describe the steps to help me to reproduce the actual behavior
Rules do not work. I have two simple rules "Contains: calendar.google.com" and none of the functionality works.  Can someone verify that the extension works with the latest Chrome 69 release?

Can't confirm.  ALl my rules stopped working recently and I was wondering if the chrome update was involved. I see my custom icons for maybe ~1 second after the page loads, then they disappear.

Works for me.
May be an issue with specific websites.

Seems universal on my end. What OS are you on?

@mmuelly

Windows 10 Chrome 69 : OK
macOS Mojave Chrome 69 : OK

Rule: URL fragment "google.com" type "Contains" and title "hello"
Best

yeah, no luck on high sierra.

Problem was a security policy which prevents the extension from working correctly.

a security policy setting in the browser? If you could comment on the solution that would be helpful, because I'm still broken over here.


RHostSession not terminate RHostBroker

I`m having problem to close broker process. After StopHostAsync, only R host process is terminated but RHostBroker is still there.
_session = RHostSession.Create("Test");
_session.StartHostAsync(new RHostSessionCallback()).Wait();
_session.ExecuteAsync("q()").Wait();
_session.StopHostAsync().Wait();
_session.Dispose();

This is expected - the broker is a process that manages host processes, and it is running as you start and stop sessions. It will exit when it detects that the parent process that owns it has exited.

Correct. In case you'll want to start another session. It is pretty tiny process. If you really need it to go away, I think it can be killed by id - @int19h can comment.

I'm not sure if we expose IBrokerClient in that API. If we do, then calling Dispose on the instance of that will kill the process, if it is a local broker.

Is it also expected when the main process create a new session but the old broker will not be reused?

In my opinion, providing a method to close broker is quite necessary.  Some application will be long running and the R session may crash,  in current behavior,  the number of brokers will keep increasing.

Broker is normally reused, at least that what happens in the main product. I'll see what we can do in the API about this.

Hi,  I`m trying to log the output from R host by override Output from RHostSessionCallback and assigned to IRHostSession. but it did not work.  Sorry in advance if it is a dumb question.
_session.StartHostAsync(new HandleRSessionCallBack(), Environment.CurrentDirectory).Wait();
var re = _session.ExecuteAndOutputAsync("cat(getwd())");
//I have to call explicitly to log
//     this.Log().Info(re.Result.Output);
class HandleRSessionCallBack : RHostSessionCallback
{
public override Task ShowErrorMessageAsync(string message, CancellationToken cancellationToken = default(CancellationToken))
{
return base.ShowErrorMessageAsync(message, cancellationToken);
}
public override void Output(string message, bool error)
{
base.Output(message, error);
if (error)
{
this.Log().Error(message);
}
else
{
//No log
this.Log().Info(message);
}
}
}

It comes as result
var result = await _session.ExecuteAndOutputAsync("code here");
// use result.Output

My broker will not be reused. Stop and Create a new R session, will get 2 brokers

Added API. Will update nuget soon

https://www.nuget.org/packages/Microsoft.R.Host.Client.API/1.1.1

Hi @MikhailArkhipov
I am trying to use the package. I am only using C# to call a user defined R function for a project but i am not that familiar with C# much so please excuse me if its a very basic question.
The following line IRHostSession session = RHostSession.Create('Test'); returns an error         System.ArgumentNullException has been thrown
Value cannot be null.
Parameter name: path1
Can you please help me out?


check 'disease' class from OGMS

OGMS_0000031 disease has been imported from RO and Mondo classes are being classified under this

@matentzn create a kill list as part of the RO import


fix: Explicitly configure AssignPublicIp in EC2 Launch Templates

Fixes #3815
Description
See issue.
How was this change tested?

I added two tests covering three possible values of AssignPublicIP, true, false and undefined.

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

awesome. Thanks. Just what we need.
we have scp to deny associatepublicip and without this, karpenter cannot provision new nodes.


SwiftUI's native dismiss environment value does not work from fullscreen modal with navigation

There is a bug where attempting to use SwiftUI's native dismiss environment value does not work from a fullscreen modal presented with navigation: foo.presentCover(Screen.modalView, withNavigation: true). This bug is present in both the 0.8.1 and 0.8.2 versions (I haven't checked any other versions). Workaround is to use FlowPathNavigator or a reference to the FlowPath associated with the FlowStack because FlowStacks dismiss APIs still work as expected. See code example below:
import Foundation
import FlowStacks
import SwiftUI

public enum Screen {
    case modalView
}
extension Screen: Identifiable, Hashable {
    public var id: String {
        return String(reflecting: self)
    }

    public func hash(into hasher: inout Hasher) {
        hasher.combine(id)
    }

    public static func == (lhs: Screen, rhs: Screen) -> Bool {
        lhs.id == rhs.id
    }
}

struct ScreenViewBuilder {
    static func view(for screen: Screen) -> some View {
        switch screen {
        case .modalView:
            return ModalView()
        }
    }
}

struct ContentView: View {

    @State var path = FlowPath()
    var body: some View {
        FlowStack($path, withNavigation: true) {
            makeRootView()
                .flowDestination(for: Screen.self) { screen in
                    ScreenViewBuilder.view(for: screen)
                }
        }
    }

    @ViewBuilder private func makeRootView() -> some View {
        Button("Present ModalView with navigation") {
            path.presentCover(Screen.modalView, withNavigation: true)
        }
    }
}

struct ModalView: View {
    @Environment(\.dismiss) private var dismiss
    @EnvironmentObject var navigator: FlowPathNavigator

    var body: some View {
        Text("Modal View")
            .toolbar {
                ToolbarItem(placement: .topBarLeading) {
                    Button("Native Dismiss") {
                        dismiss() // does not work
                    }
                }

                ToolbarItem(placement: .topBarTrailing) {
                    Button("FlowStacks Dismiss") {
                        navigator.dismiss() // works
                        // navigator.goBack() // works
                    }
                }
            }
    }
}

Thanks for raising this issue @CorbinMontague ! To update you, I can reproduce the bug, but I'm not yet sure why it's happening.

@johnpatrickmorgan It looks like the issue is tied to the content being wrapped in a NavigationView vs a NavigationStack, because if I change UseNavigationStackPolicyKey's defaultValue to be UseNavigationStackPolicy.whenAvailable instead of UseNavigationStackPolicy.never, I notice that EmbedModifier wraps the content inside a NavigationStack instead of a NavigationView, and this issue does not reproduce. So for some reason Apple's native DismissAction seems to work with NavigationStack, but not NavigationView in this case.
In View+UseNavigationStack.swift I see a comment about how func useNavigationStack() is not ready to be exposed publicly yet due to issues. Could you elaborate on what those issues are since I'm wanting to use UseNavigationStackPolicy.whenAvailable to fix this DismissAction issue?

hmm I'm seeing some kind of hang when using UseNavigationStackPolicy.whenAvailable and attempting to push additional views from within my modal so I assume I'm starting to hit some of those "issues" referred to in the comment I mentioned given I did not have that issue with UseNavigationStackPolicy.never.

hmm I'm seeing some kind of hang when using UseNavigationStackPolicy.whenAvailable and attempting to push additional views from within my modal so I assume I'm starting to hit some of those "issues" referred to in the comment I mentioned given I did not have that issue with UseNavigationStackPolicy.never.

Hi @CorbinMontague , yes that is indeed the issue that was holding me back from making that API public. Navigation seems to trigger an infinite loop currently.


[ConstraintSystem] Remove an attempted optimization that we've not

seen benefit from.
This was added at one point after the observation that it may in
theory allow us to solve constraint systems more quickly, but there
wasn't really a motivating test case and we do not know of any real
code that it helps with.
We currently have a problem in the solver in that we are both
short-circuiting evaluation of constraints systems, and do not have
a stable order that we visit disjunctions. These in combination can
result in inconsistent and unpredictable results, so I am moving to
enforce a stable order for visiting disjunctions, and that requires
this code to be removed.

@swift-ci Please smoke test

@swift-ci Please test source compatibility


Create a view of projects and fellows by geographic location (the map of where our support is going idea)

Relates to #1173


[question] i wander what's the normal speed of sglang at a 8 * a800 machine.

Checklist

[ ] 1. I have searched related issues but cannot get the expected help.
[ ] 2. The bug has not been fixed in the latest version.
[ ] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[ ] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[ ] 5. Please use English, otherwise it will be closed.

Describe the bug
yes, i only have a 8*a800 machine. i set the 8 request threads, tp 8, with a 70b model like llama3.1
the final throughput is about 500 tokens/second
i wander is this speed normal.
by the way, can anyone show me the way to slack channel of sglang?  i hear that this channel is active
(i want to use a100. cry)
Reproduction
0
Environment
0

i can provider more info needed if anyone can help me. thanks a lot.

Can you paste reproducible commands?
You can join the channel at  https://join.slack.com/t/sgl-fru7574/shared_invite/zt-2um0ad92q-LkU19KQTxCGzlCgRiOiQEw
I will close this one since this is not a bug report or feature request.


Cannot load a backup file on production app

I found the backup file from icould is not working and "select_invalid_backup_file" error showed up on the OWND Wallet.
IPhone15
iOS: 17.4.1
OWND Wallet ver: v0.1.5

FYI, here is the content of my backup file ( unzipped ).
{"idTokenSharingHistories":[],"credentialSharingHistories":[],"seed":"<12 secret phrase>"}

@kitakaze-kan Thank you for reporting the backup-related issue.
The direct cause of this problem was insufficient permissions when manipulating files.
Code=257 "ファイル“owned_wallet_2024-06-05.zip”を表示するためのアクセス権がないため、開けませんでした。"

I have created a pull request to address the above issue and several other backup-related issues.


Minimize interpreter bootstrapping in tests.

Master is currently timing out trying to fetch and build 7 interpreters.
Since We have no need for seven, constrain the interpreter count. Along
the way fix a flaky test that exposed production code not setting up all
interpreters.

I'm not very familiar with the PEX directory structure. Is this all test code, or is any source code?
Will review next few minutes!

The only production code change is in pex/bin/pex.py here: https://github.com/pantsbuild/pex/pull/571/files#diff-178808e5641b15e64b2d09f744976f03

This has brought the cold cache CI times on OSX down from 50+ minutes to 30- minutes - so looks like it'll do.