2 suggestions

1- If player has a specif permission, the chest will be protected from other player take items
2- Option to add a custom head textures or another block to change the death chest

What should happen if another player causes an explosion so that the chest is destroyed?

What should happen if another player causes an explosion so that the chest is destroyed?

the chest is not destroyed, it only protects against item theft

#19 adds a chest protection

#19 adds a chest protection

The second suggestion it's not planned?

Not yet but I will implement it soon


Exercise Approval Filter - UT Feedback

On SLs approving exercises - it would be helpful to have a filter on the page with exercises listed where you can filter out exercises that require clearance or if the exercises requiring clearance are identified on the list differently somehow. At the moment, all the exercises that are listed, approved or not, all look the same.
Explore option of adding a filter onto main page of exercises to filter by approval state

Add a new column to the live exercises table to display the approval status (requested, rejected, approved).
This column should not be sortable.
The data for this column will come from exercise._approval status (doesnt need to sort)
Add a dropdown (or 3 checkboxes) to the table filters. This new filter will allow the user to select an approval status to filter by.


Unit test jest

#3148 - this PR adds Jest configuration and a handful of sample tests. Still to do:

enforce testing somewhere in PR workflow
convert ava tests in @/test to jest

I'm converting this to a draft until I can incorporate changes to UnitInput in pr #4542

For the records, in order to merge this branch to master, I have been forced to keep the yarn.lock and only use the yarn commands to add/remove packages. Any other attempt to find the proper pinned version, configuration and combination of libraries resulted in a total failure, with several types of errors of any kind.
Major errors encountered were related to:

@babel/preset-env
Nuxt resolve issues not working with the babel configuration

I also have encountered several errors due to the update of the tests libraries, which may be worth to finally update them as it is causing certain tech-debt at the beginning of the tests implementation.

As extra notes not mentioned in the issue:

Added Jest debugging process for VSCode
Removed file exclusion from VSCode configuration, preventing listing files in the editor
Changed global unit test:

Added yarn test with watching capabilities
Added yarn test:ci for CI scopes, with coverage files generation

Typescript scoped

Converted involved utilities into types
Switched ESLint rules to TSLint, e.g. to allow overloading function declaration types
Disabled new ESLint after rebase to master
Added Lodash types

Notes:
I am omitting cases without real any type of benefit like this one:
  let g = getter('foo');

  t.deepEqual( typeof g, 'function', 'Returns a function');

Due to the complexity of the code, amount of time required and been out of scope, I opted for avoiding to type involved utilities.
We should review these utilities together and make some decisions.
@richard-cox while converting utility/string.js I encountered a runtime error with the i18n.js plugin import which may require further investigation for implementing TS in this project.

Important! Please remember to install packages with yarn command.
Required for manual QA:

Read new documentation in Testing > Unit testing and try commands
Check Pipeline logs to include mentioned tests and passing
Run debugging tools with Jest

I fixed the eslint issue which was a problem with my development environment. But when I run the tests I get a lot of errors that say it's getting a 401 where it expects a 202.

The console says
Error occurred while trying to proxy request /v3-public/authProviders from <IP_ADDRESS>:8005 to https://<IP_ADDRESS> (ECONNRESET) (https://nodejs.org/api/errors.html#errors_common_system_errors)

In this case I'm running Rancher locally using a remote backend. And I'm trying to point Cypress at the locally running UI:
API=<backend-IP> yarn dev --spa

TEST_USERNAME=admin TEST_PASSWORD=gjdlagjlkasdjgklajgkldajgadlkgjsdlkgjalkgj DEV_UI=https://<IP_ADDRESS>:8005/ yarn cypress open

Am I setting the environment variables wrong?

The setup I used for running Cypress were just running the project, without spa flag and then yarn cy:open.
I see the same errors also on the main branch. It does not seems something to be fixed within this ticket, however we should tackle it down and also integrate it in the CI.
As a first step I would actually correct the script e2e:dev as it does run the tests, just open Cypress.

Furthermore, it looks like the tests are not passing anymore after a rebase to master. We should integrate a procedure so we do not have to fix other ticket issues.

@catherineluse  Cypress E2E tests to be fixed within https://github.com/rancher/dashboard/issues/4181

@catherineluse the it is nested within another describe.
The full texts are:

fx: get should return value of an object of a given path
fx: get should return value of an object of a given nested path
fx: get should return value of an object of a given complex path

Since we are repeating the same assertion, it has been wrapped in a describe.

no, the describe should have a noun to say what you are describing and the it should have a verb to say what the thing does. so it could be like:

describe - "the function to get a value from an object"
it - "returns a value at a given path"
it - "returns a value at a nested path"
it - "returns a value at a complex path"

For the records, since I was not sure to have been testing it, a build run has been done without encounter any issue.


[DOC] Remove license info from module docstrings

Describe the issue linked to the documentation

There has been cases popping up where module docstrings are including our licensing information.
Licensing should not be in docstrings (See numpydoc module docstrings. It should be in a comment line.
Suggest a potential alternative/fix

Solution is manually going through and finding the cases where we have included licensing information in the module docstrings and moving it to a comment line above the docstring.
The result should look something like this:
#!/usr/bin/env python3 -u
# -*- coding: utf-8 -*-
# copyright: sktime developers, BSD-3-Clause License (see LICENSE file)
"""Some docstring (single or multiple line) here."""

I'd like to take on this issue.


Fix building with GCC-6

Since C++11, there has existed std::error_category::equivalent.  OpenNI defines a macro equivalent.  During header inclusion, a GCC header calls the function equivalent but that symbol is hidden by the name clash with the macro equivalent leading to:
In file included from ../../../../../Samples/NiViewer/glh/glh_obs.h:62:0,
                 from ../../../../../Samples/NiViewer/NiViewer.cpp:62:
/usr/lib/gcc/x86_64-pc-linux-gnu/6.2.0/include/g++-v6/system_error:107:5: error: expected unqualified-id before ‘int’
     equivalent(int __i, const error_condition& __cond) const noexcept;
     ^

This is easily remedied by changing all instances of macro equivalent to is_equivalent.

This correction suits well for this error too :
../../../../../Samples/NiViewer/glh/glh_linear.h:80:63: error: no match for ‘operator>’ (operand types are ‘const std::error_code’ and ‘float’)  #define     equivalent(a,b)     (((a < b + GLH_EPSILON) && (a > b - GLH_EPSILON)) ? true : false)
and it's the same as the PR #101


Positioning and Resizing does not work as intended in production mode

Describe the bug
I would have given a code snippet, but I don't know what part is causing this specific issue. It works how it's supposed to or intended in the development build, but after I've built it for production, everything falls apart as shown in the given gif. I tried looking at the examples provided in this repository, and I found a similar problem happening with my code in https://react-grid-layout.github.io/react-grid-layout/examples/8-localstorage-responsive.html . The width, height, or the positions don't get saved in local storage either.
Your Example Website or App
https://react-grid-layout.github.io/react-grid-layout/examples/8-localstorage-responsive.html
Steps to Reproduce the Bug or Issue

Go to https://react-grid-layout.github.io/react-grid-layout/examples/8-localstorage-responsive.html
Try resizing, dragging the containers
Know it cannot be done

Expected behavior
As a user, I expect the container to be resized, when I resize it. I also expect it to be placed where I've dragged it
react-grid-layout library version
1.4.4
Operating System Version
Ubuntu
Browser
Chrome
Additional context
The package works as intended in the development build but not in the production build.
Screenshots or Videos

I am also facing this issue and seems like the responsive layouts is not working.

Any update?


Update all dependencies from requirements.txt

What current issue(s) does this address?, or what feature is it adding?
Outdated dependencies
How did you solve this problem?
Update them
How did you make sure your solution works?
Run the tests
Did you add any tests?
no
Are there any special changes in the code that we should be aware of?
no

Coverage remained the same at 68.234% when pulling 5a18e9f0e41a9267f4d34f4f0b2e8ae4732a5eb9 on metachris:deps-update-new into 54a937a893cb405542073d82e56ce057bf0e7132 on CityOfZion:development.

🆙 📅


Stuck in a "App not responding" loop

Using Gnome 42, every few seconds there is a message about app "Unknown" is not responding wait or force quit? I installed latest version from AUR. Any other info I should provide?

Apparently layer shell is not supported on Gnome. Does the window show, or are you getting oly the message?


fix: use existing app group properly

Hi!
When app's original config has ios.entitlement["com.apple.security.application-groups"],
generated shareExtension's entitlement file has wrong type value like this:
    <key>com.apple.security.application-groups</key>
    <array>
      <array>
        <string>group.com.xxxxx.xxxxxx</string>
      </array>
    <array>

It should be:
    <key>com.apple.security.application-groups</key>
    <array>
       <string>group.com.xxxxx.xxxxxx</string>
    <array>

I noticed it comes from expo config plugin.
So I added a little change to it.

released as part of v1.10.6 🚀


Unify Update Scheme and Revaulting Options

Task Description
Currently, under Vault Settings for Miniscript-based Vaults, we have separate options for the update scheme and revaulting (where revaulting is a subset of the update scheme). We need to create a single unified flow for these options to streamline the user experience.

Have made the UI for it. Please check if it meets the requirement @Parsh . Have changed the wording of option and then a pop up opens up allowing us to select which method do we want so that accidently we don't change the signers and also don't change the config as well.
Section:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=7417-4233&t=h1nmgKyEMXQrrUdZ-1
S.S

@AreejKhalid21 This looks good!

Not sure about this, feels like it makes it less straightforward to know where to revault. I think the change scheme option now already offers the user to set the new timeline of the IK, so not sure why this issue is really needed

Closing as we decided against it


Document environment variable overrides and their usage

For example all of the ones defined here:
https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/app.py#L34-L42
And also here:
https://github.com/NebraLtd/hm-diag/blob/00f492a173e048bfbe9923c7497fa3e18d15632e/hw_diag/utilities/hardware.py#L216
There may be more elsewhere

Related to #442

we should move all of them to a configuration module. There are too many and too spread out. Only downside is such a refactor will involve changing lot of test cases. But shouldn't be very hard to do. it will be easy to document and reference.


improvement: add configuration to avoid System.gc even if -XX:+DisableExplicitGC is not present

Hi @mjiderhamn ,
I'd like to leverage your excellent library though I'm not confortable with the System.gc that will be triggered if the -XX:+DisableExplicitGC jvm switch as not been turned on.
This is done in these 2 classes:

https://github.com/mjiderhamn/classloader-leak-prevention/blob/master/classloader-leak-prevention/classloader-leak-prevention-core/src/main/java/se/jiderhamn/classloader/leak/prevention/ClassLoaderLeakPreventor.java
https://github.com/mjiderhamn/classloader-leak-prevention/blob/master/classloader-leak-prevention/classloader-leak-prevention-core/src/main/java/se/jiderhamn/classloader/leak/prevention/cleanup/StopThreadsCleanUp.java

Here's the use case:

My company run performance testing with multiple sites deployed on a single application server.
Deploy and undeploy operation can happen at any time.
Forcing a GC on each undeploy operation could potentially have performances impact on the other sites deployed.

I think, solely relying on the -XX:+DisableExplicitGC is a bit problematic. Sure I could most likely extends your library to change the behavior though, I feel it would be a great addition if we could instead leverage a configuration to explicitly enable or not the System.gc.
Maybe a bit like the other "ClassLoaderLeakPreventor. ..." configuration you already provide (through the context param).
I also think, it could be worthwile to enable/disable any individual leaks prevention feature one by one. So when hunting down for leaks and fixing them, it could be possible to still leverage your library to solve one issue at the time.
WDYT?
Again a big thank you for your excellent library.

Hi Mathieu and thank you!
Despite your explanation, I don't quite see why you need this configuration. What is the problem with -XX:+DisableExplicitGC? Do you need to do explicit GC in other circumstances, but avoid it only in the leak preventor?
Also, did you notice under what circumstances the leak preventor does explicit GC? Currently there are only two cases when this will be used. The first (in StopThreadsCleanUp) is if your app includes Open Office Java Uno RunTime (JURT). The second (in ThreadGroupCleanUp) will happen if any custom ThreadGroups were created in your app. This does not seem to be very common. The only third party library I've seen that uses ThreadGroups is JGroups (which is a dependency of Infinispan).
Given that information, do you still think explicit GC will be a problem in your scenario...?
Furthermore, I'm not completely convinced that explicit GC will have a bigger impact on the performance results, than the fact that multiple other applications are running in parallell (and implicit GC). Although that also depends on what Garbage Collector is used (Parallell would likely have much more impact than CMS or G1). What GC are you using?

Sorry for the delay, I was in vacation without Internet connectivity.
We are indeed using JGroups through Infinispan / Wildfly Application Server.
We are currently using CMS + ParNewGC though will try to migrate to G1GC soon especially to gain the benefits of the -XX:+UseStringDeduplication.
Correct me if I'm wrong, though, when we enable the -XX:+DisableExplicitGC, we also loose the ability to trigger a GC directly from the JVisualVM and/or JConsole? When running performance testing, we would like to keep this ability. This is also why having a dedicated configuration other than relying on -XX:+DisableExplicitGC would be handy.
You're probably right that this is a 'corner case' though I still feel this is fair feature request. I'm willing to implements the configuration through a pull request if you are willing to merge it after it satisfy your/the library quality requirements.
Thanks!

I've been thinking on this for a bit. For ThreadGroupCleanUp I think we could add configuration to avoid explicit GC, but the documentation should include a warning that then we can't predict when stale java.beans.ThreadGroupContext entries will be expunged. (One potential improvement is to trigger stale expunging also on startup, in case implicit GC happens between undeploy and redeploy.)
For the JURT case, I cannot yet see a way to shut it down properly without first forcing GC. Do you?


Fix incorrect rule name

The empty args rule was named incorrectly within the rule definition. It was labelled no-empty-args whereas in the docs and config file it was labelled empty-args.
Not a breaking changes as it's just the reported name, the default config etc was having effect as anticipated but was leading to confusion on the rule name to update.
Fixes #652
DCO 1.1 Signed-off-by: Dan Purdy<EMAIL_ADDRESS>

Coverage remained the same at 96.993% when pulling e0862051d78f1d8d190a5b4d802380f5747501d6 on DanPurdy:feature/fix-empty-args-rule-name into bbef921bdb9756fd79a84dbc3f26ef3e8f89645a on sasstools:develop.

:+1:


Regular update

Update Angular 2 Beta 16
Re-enable mangling
Fixed unit tests breaking changes
Update stable dependencies

Coverage remained the same at 100.0% when pulling 94d6a3c97ca30ed7518955a6b2223ad13a6aefef on regular-update into 46f7f41f0e9635aff27f06e7a9246857201436e1 on master.


configure matchers and receivers conditionally

We have the problem of failing deployments on Control Planes for which there is no webhook configured. This PR tries to resolve certain scheduling limitations by just not configuring any matchers nor receivers at all in case there is no webhook configured. Below is an error within the App CR status found on ginger.
$ k get -n giantswarm -o yaml apps.application.giantswarm.io event-exporter-app-unique
...
status:
  release:
    reason: 'helm error: (template: event-exporter-app/templates/configmap.yaml:28:31:
      executing "event-exporter-app/templates/configmap.yaml" at <.Values.Installation.V1.Secret.EventExporterApp.Slack.Webhook>:
      nil pointer evaluating interface {}.Slack)'
    status: not-installed

With this PR the pod gets deployed again and this is how the configmap looks like.
$ k -n giantswarm get -o yaml configmap event-exporter-app
...
data:
  config.yaml: |
    logLevel: debug

Another option would be to sent events to an stdout sink which would print events on the pod itself I think.
For now let's merge it like this to close alerts

The reason why I would like to not configure an optional feature for all installations is because it is a burden you then always have to consider. SREs should not be bothered with it when setting up a Control Plane. By just not setting up anything if there is no webhook the configmap gets also simpler. I would expect anything else to increase complexity.


Non dependent versions of pi_transport

Lean's HoTT library does not have a non dependent version of the theorem pi_transport. I want to implement these in a pull request, but I don't know where to put them.

Do you mean arrow_transport in types.arrow?

Yes, I was mislead by the documentation here: https://github.com/leanprover/lean/blob/master/hott/book.md, which says that the code corresponding to Section 2.9, which includes the theorem arrow_transport is to be found in types.pi and init.funext, types.arrow is not mentioned.

Good point. I will add it there. Thanks for the feedback.


Fix function pointer size calculation

The class member function pointer size is
different in some cases on windows CL compiler,
8 bytes for single class inheritance,
16 bytes for multiple class inheritance.
So max the function pointer class to multiple class inheritance.

ping for review


cid/doc: added recommended way of deployment and time for all options

Issue #, if available:
Description of changes:
cid/doc: added recommended way of deployment and time for all options
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yprikhodko please can u approve this?


[LANDGRIF-1252]: Client/hotfix/landgrif 1252 backup

General description
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Provide minimal instructions on how to test this PR.

Apart from the added feature / bug fix, check overall performance, styling...

Checklist before merging

[x] Branch name / PR includes the related Jira ticket Id.
[x] Tests to check core implementation / bug fix added.
[x] All checks in Continuous Integration workflow pass.
[ ] Feature functionally tested by reviewer(s).
[ ] Code reviewed by reviewer(s).
[x] Documentation updated (README, CHANGELOG...) (if required)

Clean version of https://github.com/Vizzuality/landgriffon/pull/885


Fix pylint errors caused by a new stricter version

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

9 of 9 (100.0%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.4%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
2252

Relevant Lines:
2801

💛  - Coveralls


What to do about embiggened datasets?

Background
We have a 4 million cell dataset which hosted cellxgene explorer can't handle. It triggers page-unresponsive warnings in cellxgene and generally does not perform adequately. We don't want to launch with this dataset because it produces a bad experience.

The dataset is published.
The authors are excited about being able to provide access to the full dataset in our standard schema
The authors are excited about users being able to view a subset of the data and explore it using cellxgene.

We believe that datasets will continue to increase in size due to integration (this is not the final occurrence)
Being able to download standardized datasets and being able to explore them have distinct value.
Proposal
Portal

Disable exploration of datasets in the portal larger than 2 million cells (gray out icon)
Hover over grayed out icon states "Exploration is currently unavailable for datasets with more than 2 million cells"
Dataset exploration is disabled privately and publicly if they contain > 2m cells.
Intent for tooltip should be .warning

Explorer

Filter datasets larger than 2 million cells from the seamless menu in explorer

Curation

Indicate in submission documentation that datasets larger than 2m cells will not be explorable. Stanford to communicate to users about limitations of exploration

Metrics

Amanda to add this metric to the metrics reporting she is creating.

Future
Investigate solutions for increasing our performance ceiling. Could include:

subsampling datasets
improving explorer performance so that it can display more points
displaying manifolds instead of individual cells

Capturing Mim's recommendation from eng:

It  might be better to filter on the BE if it’s required longer term. Another option could be to filter on the FE but have the limit specified by the BE. I can add the filter on the FE for now and we can revisit post-launch if needed.

See wrangling.
@signechambers1 @ambrosejcarr - I would be curious about your perspective about whether we should mirror the curation UX policy - Do not include datasets larger than 2 million cells in the dataset menu - and block access to the explorer_url (filter it out) in the curation API (and all other portal APIs that return the reference to the CXG URL.
My personal position is to take no action since it's currently an edge case and scaling is to be addressed soon.
Note that we do make independent policy decisions for the API and the UX. For example, we do not allow publication or collection deletion from the API - only the UX.

scaling is to be addressed soon

We are addressing UI issues that degrade performance on datasets up to 2 million cells. I don't believe the 4m cell dataset will be addressed anytime soon.
While we're not aware of any dataset > 2m cells, I do imagine submitters will continue to submit data as single objects - so if we receive large datasets in the future, they will create additional instances of this issue.

Thanks for raising Brian! Echoing Ambrose, our performance related goals
for this quarter are for up to 2M cell datasets so we won't be enabling
explorer for 4M cell datasets anytime soon.
My thoughts probably depend on the use cases for the curation API. What is
the main use case for the explorer url in the curation API? I could imagine
it is for curators to see what users would see? If so, blocking that option
for datasets >2M cells would make sense to me so as not to mislead anyone
that users will see an explorer UI but agree that is low priority since it
is an edge case.
On Mon, Aug 8, 2022 at 8:09 AM Ambrose J Carr @.***>
wrote:

scaling is to be addressed soon
We are addressing UI issues that degrade performance on datasets up to 2
million cells
https://app.zenhub.com/workspaces/single-cell-5e2a191dad828d52cc78b028/issues/chanzuckerberg/single-cell-explorer/327.
I don't believe the 4m cell dataset will be addressed anytime soon.
While we're not aware of any dataset > 2m cells, I do imagine submitters
will continue to submit data as single objects - so if we receive large
datasets in the future, they will create additional instances of this issue.
—
Reply to this email directly, view it on GitHub
https://github.com/chanzuckerberg/single-cell/issues/245#issuecomment-1208254182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQXM6GV5PEEYU2Z6GH6CXHTVYEPJ7ANCNFSM5F3ZMWNA
.
You are receiving this because you were mentioned.Message ID:
@.***>


refactor: centralize git checkouts and db paths

What does this PR try to resolve?
This moves the logic of getting $CARGO_HOME/git/checkouts and $CARGO_HOME/.cargo/git/db to a central place.
How should we test and review this PR?
There is no functional change.
Additional information

Thanks!
@bors r+

:pushpin: Commit 0a4ce466dda6024cd6bad74d8fc2f6c71d38f7b7 has been approved by ehuss
It is now in the queue for this repository.

:hourglass: Testing commit 0a4ce466dda6024cd6bad74d8fc2f6c71d38f7b7 with merge 60053f7dd3450e66722e7ed008c13762a40925d2...

:broken_heart: Test failed - checks-actions

Rust version was updated to 1.77 hours ago https://github.com/rust-lang/rust/pull/119181. I'll bump the version of Cargo today.

Blocked on #13192

@bors retry

:hourglass: Testing commit 0a4ce466dda6024cd6bad74d8fc2f6c71d38f7b7 with merge 363a2d11320faf531f6aacd1ea067c6bc08343b9...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 363a2d11320faf531f6aacd1ea067c6bc08343b9 to master...


[Fix]: Inconsistency in merchant requirement during and after invoice creation

Details

Give error when we try to send invoice without merchant name
Fixed Issues

$ https://github.com/Expensify/App/issues/41285
PROPOSAL: https://github.com/Expensify/App/issues/41285#issuecomment-2084520616
Tests

Same as QA steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA steps
QA Steps

Precondition: You should already have a collect workspace.

Go to FAB > Send invoice.

Enter amount and select a participant.

Click on send invoice button
(Verify that you get error when trying to save without entering merchant)

Click on merchant

try saving merchant without entering any value
(Verify that you get error when trying to save empty merchant name)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/110545952/7f465e55-0d30-4340-b4f4-ecd6fb5eaa03

MacOS: Desktop
https://github.com/Expensify/App/assets/110545952/f9805f93-ff1d-4b67-b894-6a873f225eff

Android: Native
https://github.com/Expensify/App/assets/110545952/3105c1bc-c5be-4961-8cee-2a88b02caf87

Android: mWeb Chrome
https://github.com/Expensify/App/assets/110545952/a188a913-5306-4876-9a23-d6d0a8f9e3c3

iOS: Native
https://github.com/Expensify/App/assets/110545952/9edae978-022f-4954-beb8-1cbe116f93b8

iOS: mWeb Safari
https://github.com/Expensify/App/assets/110545952/a9de41aa-e29f-472d-b7d1-57beaf9de660

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Army Models not Loading with Submit code Table.

Describe the bug
Loading army list from Battlescribe2TTS code seems to work fine. However, there are no objects present on the table to assign to data.
Expected behavior
Models described by data sheets load alongside the data options.
10K Necrons Force v1.0 - Copy.zip

Discovered how to assign data to models. A description of this process would be helpful if added to website or workshop site.

Discovered how to assign data to models. A description of this process would be helpful if added to website or workshop site.


can you upgrade this repo ?

this were a good implemntation to janus audio bridge and many other example but it seems outdated. also okhttp now is Supporting websocket client many enhancement can be done

upgraded already.


New-AvdSessionHost Freeze

Hi,
When I trigger the New-AvdSessionHost with all the necessary parameters, it does nothing and freezes for hours - in the previous version in 2.5.1 also it's returning an error to the -Domain parameter and says:
Line |
311 |  …             Invoke-RestMethod -Method PUT -Uri $domainJoinUrl -Header …
|                                                   ~~~~~~~~~~~~~~
| Cannot validate argument on parameter 'Uri'. The argument is null or empty. Provide an argument that is not null
| or empty, and then try the command again.
Any support on that?

Hi @h-sadeghpour let me have a check on that. Thank you for your comment

With version 3.0.0 Beta this is where it freezes - thought might be helpful - But with version 2.5.1 the "Uri" error is keep coming as mentioned in the main post.

Hi @h-sadeghpour  are you able to test release https://github.com/srozemuller/AzAvd/releases/tag/3.0.0-beta.8

Hi,
I have tested it, it's the same issue.
Kind regards,
Hamid Sadeghpour Saleh
http://hamidsadeghpour.net/
Microsoft Solutions Consultant
MVP: Microsoft Azure | Cloud and Datacenter Management
https://hamidsadeghpour.nethttp://hamidsadeghpour.net/ | @.***
[cid:037632c5-49a8-4ab4-aa9f-edcba5b8decf][cid:0a570dda-e149-4822-8acf-5374ee59b289]

From: srozemuller @.>
Sent: Friday, June 2, 2023 11:19 AM
To: srozemuller/AzAvd @.>
Cc: Hamid Sadeghpour Saleh @.>; Mention @.>
Subject: Re: [srozemuller/AzAvd] New-AvdSessionHost Freeze (Issue #92)
Hi @h-sadeghpourhttps://github.com/h-sadeghpour are you able to test release https://github.com/srozemuller/AzAvd/releases/tag/3.0.0-beta.8
—
Reply to this email directly, view it on GitHubhttps://github.com/srozemuller/AzAvd/issues/92#issuecomment-1573422795, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALXIVXACA6CYLIEMCDV5JWTXJGV3NANCNFSM6AAAAAAYEC6YYQ.
You are receiving this because you were mentioned.Message ID: @.***>

Hi @h-sadeghpour a lot has been changed on the session host deployment. I've tested many time with no issues anymore. Are you able to test 3.0.0 from the PSGallery


velocityXYZ names are violating conventions

as discussed in this pr and on discord, velocityXYZ reads much less naturally than xyzVelocity, which means that velocityXYZ names are in violation of the conventions, specifically this section of "general":

To make code as easy to read as possible, keep names in the natural language order. For example, a class representing a chest block entity should be named ChestBlockEntity rather than BlockEntityChest. Though prefix naming may be helpful for grouping classes together in an IDE's tree view, reading and writing code is done much more often than browsing files.

additionally, seeing how common this mistake is, we should add this as an example in the conventions.

Re-posting what I said on discord:

iiuc its
"velocity's x component" for velocityX
vs
"x component of velocity" for xVelocity
imo both are pretty natural, so no reason to change it

Additionally, this would contradict the Coordinates convention, which goes so far as to specify "velocityX, not xVelocity"

Coordinates can be named x, y, and z when it's clear what they represent. If clarification is needed, add a word in front of the coordinate (velocityX, not xVelocity).

When this was brought up on discord it seemed like there was a distinct lack of agreement that the current "velocityX" order is less natural.
There was also disagreement on the current "velocityX" being less natural in #458 where, to my knowledge, this discussion started. Start of discussion.

I agree with @supersaiyansubtlety that velocityXYZ is a better word order.  However, does it make more sense for it to be velocityXyz?  I think probably not, it just depends on whether you want to treat it like an acronym (which it isn't) or not:

Treat acronyms as single words rather than capitalizing every letter. This improves readability (compare JsonObject and JSONObject) and it's consistent with Mojang naming (a known name is NbtIo).

The issue is actually about velocityX, velocityY, and velocityZ.
velocityXYZ is just shorthand to talk about all 3.

I'm not sure I support this change anymore, but if anyone has another argument for it I'd love to hear it. otherwise, I'm closing the issue.


Support for Tailwind CSS 2.x

Hi there,
Thanks for building this.
Do you have any plans to upgrade this package to support Tailwindcss 2.x?
Attempted to npm update and got the follow error:
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/tailwindcss-multi-theme
npm ERR<EMAIL_ADDRESS>from the root project

I believe this package is abandoned and should be marked as such. No updates for two years, tailwind dependencies are very outdated. Projects that are using this package cannot update anymore. It would be great if the person that developed this package offered an alternative.


kotlin standard library ships as transitive dependency of all modules

We apply the kotlin gradle plugin for our unit tests. We do not use, or plan to use, kotlin or its standard library in the main source sets so this dependency is not necessary.
I believe that in the past the kotlin plugin didn't automatically add its standard library to the classpath, but that behavior changed and now it does. We should exclude this "dependency" that we don't actually use.

@sambsnyd , you probably want adding kotlin.stdlib.default.dependency=false Gradle property rather than dealing with exclude(..)
See https://kotlinlang.org/docs/gradle-configure-project.html#dependency-on-the-standard-library


Use Microsoft.Windows.CsWin32 to generate P/Invoke methods

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR @virzak ! 👍🏻
Could you create an issue in this repo with the elevator pitch for moving to CsWin32 on this library? I'm definitely not against it, but I'd like to understand the value we get given all the P/Invoke definitions have already been written and have been battle tested for many years.
Also, if we were to go this route, would we be able to use a stable version of the Microsoft.Windows.CsWin32 package directly from the nuget.org feed?

Logged #85.
Yes, the nuget.org version works as well. Something wasn't working during development and I just tried the latest build of the library. Turned out it wasn't at fault. If you'd like I can revert.

Now using the latest version from nuget instead of a private feed.

@augustoproiete, any chance of merging this soon? I'd like to submit another PR which conflicts with this, so if you have a chance to look at this soon, it would avoid future conflict.

@virzak Merged. Sorry for the long delay


Update README.md

Add a readme file for the assignment 3._version2.

Readme file for assignment 3.


jets build fails for new project

Checklist

[x] Upgrade Jets: Are you using the latest version of Jets? This allows Jets to fix issues fast. There's a jets upgrade command that makes this a simple task. There's also an Upgrading Guide: http://rubyonjets.com/docs/upgrading/
[x] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.rubyonjets.com
[x] Code sample: Have you put together a code sample to reproduce the issue and make it available?  Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software
Version

Operating System
OSX 10.13.4

Jets
1.8.8

Ruby
2.5.3

Expected Behaviour
A newly created Jets project should build successfully.
Current Behavior
A newly created Jets project fails to build due to webpack errors.
Here is the output of jets build
err.txt
Step-by-step reproduction instructions
gem install jets
nvm install 8.10.0
nvm alias default node
npm install -g yarn
jets new --no-database demo
cd demo
jets build

@undefinedvalue Thanks for the report. This was an important one. Release fix in v1.8.9
Had to dig into this one a bit. Some notes for posterity:

Webpacker upgraded to a newer version of babel.
Looks like babel renamed a few of its libraries to be under the @babel namespace. IE: syntax-dynamic-import -> @babel/plugin-syntax-dynamic-import. So needed to update the generated .babelrc file to the new libraries.
The postcss-cssnext plugin was also moved to a separate library. So that needed to be added as part of the jets new process.
Webpacker also change the default behavior so that css files do not get compiled. You must now turn it on with extract_css: true in your webpacker.yml

Pushed out a release to fix this quickly.  Would like to revisit the webpacker fork when got time. Unsure when. Will consider PRs.


Cloud formation: the WeaveScope output shouldn't be loadbalanced

The WeaveScope output goes through an ELB:

This is wrong since it leads to a split brain in the apps, affecting things like terminal spawning:
See: https://github.com/weaveworks/scope/issues/2016#issuecomment-261226026

Perhaps we could just run one app behind the ELB?

Why use an ELB if there's going to be a single app? I would suggest simply enabling public DNS for the instances and picking one of them for the WeaveScope output.

Why use an ELB if there's going to be a single app?

Good question! The reason for this is that there is no other easy way to display a URL in outputs section of CloudFormation stack status page.

Then fine as long as it works and it's commented (assuming you can comment in CF templates)

assuming you can comment in CF templates

No, it's JSON.

Can we just tell people to use Weave Cloud for their Scope UI?

Luke, yes, I've asked the same question earlier. Fons believes that the
extra step needed right now doesn't do well for UX, but we can do that once
we have new getting started page, we can just link to CloudFormation with a
toke in the URL.
On Mon, 21 Nov 2016 at 15:54 lukemarsden<EMAIL_ADDRESS>wrote:

Can we just tell people to use Weave Cloud for their Scope UI?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/integrations/issues/115#issuecomment-261977838,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS-r9dwMp0M-q2EmB7Dh3RY56ct9Wks5rAb7EgaJpZM4K1NYi
.

I would prefer to fix this with sticky sessions. Fons, you have mentioned
that you foresee some problems with that - could you please outline those?
On Mon, 21 Nov 2016, 16:05 Ilya Dmitrichenko<EMAIL_ADDRESS>wrote:

Luke, yes, I've asked the same question earlier. Fons believes that the
extra step needed right now doesn't do well for UX, but we can do that once
we have new getting started page, we can just link to CloudFormation with a
toke in the URL.
On Mon, 21 Nov 2016 at 15:54 lukemarsden<EMAIL_ADDRESS>wrote:
Can we just tell people to use Weave Cloud for their Scope UI?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/integrations/issues/115#issuecomment-261977838,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS-r9dwMp0M-q2EmB7Dh3RY56ct9Wks5rAb7EgaJpZM4K1NYi
.

you foresee some problems with that - could you please outline those?

The stateful nature of sticky sessions brings problems in my experience. But, give it a spin and let's see what happens.

Turns out classic ELB only supports stick session for HTTP listeners, and Scope listener has to be a TCP one, due to the use of WebSockets. I haven't looked into ELBv2 yet, and I'd rather encourage the use Weave Cloud, which is also more secure as standalone mode doesn't even do TLS.


Bar timeseries chart binning is not working as expected

Version
5.2.2
Reproduction link
https://codesandbox.io/s/echarts-zoomin-timeseries-sktvb?file=/src/App.js
Steps to reproduce
You can run the codesadnbox link provided and try to zoom in on each bar chart too reproduce the problem.
What is expected?
Suppose we have three date-value pairs on (1988, 8, 3), (1988, 9, 18) and (1988, 10, 18).
It's expected that when you zoom in on each bar (for example 18/10/1988) and the user can see the actual date on the ticks, the bar should wrap around the actual date tick and it shouldn't extend to other ticks.
Zoomed-out state:

Expected zoomed-in state (Zoomed in on 18/09/1988):

What is actually happening?
The bar wraps around other dates and the actual zoomed-in state on 18/10/1988 looks like this:

(Which is wrong, the bar is also covering 8th and 10th month but it is counting only the data on 9th month)

I also provided a gif on what's happening:

This is not a bug but currently the time series lack the ability to control bar width in the unit of value (time).

Bar width could be controlled by barMaxWidth - Demo v.5.2.2.
Unfortunately v.5.2.2 is the last version showing bars at the right time (X-axis location). And only with (redundant!) stack present.
Newer versions treat time axis similarly to category axis and try to "make space" for adjacent series which makes horizontal position inaccurate.


Log4j

Some packages import log4j, which might get exploited (but I don’t know)

I don’t know if this would affect anything but I might as well point it out

I don't see anything wrong with this:
https://twitter.com/gegy1000/status/1469714451716882434


Application reliant on existence of "C:\AkashaScanner\AkashaScanner\wwwroot."

This fork is reliant on the existence of the directory "C:\AkashaScanner\AkashaScanner\wwwroot." and crashes at runtime if this is not the install directory

Scratch that, but still can't figure out exactly what the file structure is here. It looks like it's heavily reliant upon the directory tree that existed when it was first compiled.

Taking a look at this today. ty for reporting

Was about the way i published. Just republished and it tested on my side and looks fine. Let me know if you still have issues


Add tools/runtest.py for running individual testcases

Add tools/runtest.py which allows running individual testcases manually and from scripts:

Parse testcase metadata from input file.
Parse testcase expect string from input file.
Add a testcase framework prefix (with e.g. print/console.log harmonization) and process includes to create a stand-alone prepared testcase (which can be executed as is).
Execute the test, with optional valgrind wrapping.
Analyze test results.
Print a test summary with a diff snippet.
Output test results into a JSON file for other tools to process (e.g. when running a test suite the suite summary can be created using this output).

The tool can also just prepare the test without running it, so that it's then easy to run it manually using e.g. Node.js and edit the test.
Tasks:

[ ] Add a minimally functioning version
[ ] Resolve FIXMEs
[ ] Use "diff" by default, and if missing on Windows default to FC
[ ] Check overlap with util/prep_test.py, e.g. to complete minifier code
[x] Create knownissue files for existing known issues
[ ] Test on Windows

The runtest.py tool supports YAML for metadata test case to allow more compact syntax:
/*---
custom: true
---*/

and allows an inline expect string syntax:
print('aiee');  //>aiee

Known issues are now described by individual files in tests/knownissues/. The file contains a YAML document which provides a summary and other metadata for the known issue, optionally followed by --- and the expected output for that known issue (i.e. the exact buggy output):
summary: prints 'aiee' incorrectly
description: >
    Prints 'aiee' incorrectly because foo is not bar.
----
foo
bar
aiee

The expected (broken) output can also be specified using an MD5 key which is useful for huge outputs:
summary: prints 'aiee' incorrectly
description: >
    Prints 'aiee' incorrectly because foo is not bar.
md5: bf8759a584cfe6d800c45de80fc59582

This allows known issue to be tracked more precisely; previously doc/testcase-known-issues.yaml just listed failing tests with a description but the output itself was not checked. So it was possible for a test to fail differently than before without being noticed.
This pull doesn't change runtests or any existing test infrastructure yet. Later pulls will change runtests to use this tool for executing tests and eventually the Javascript-based runtests.js will be replaced with something a bit better.

@fatcerberus This is very far from complete (lots of FIXMEs, some output formatting bugs, etc) but it'd be interesting to hear how this works for you out of the box:
$ python tools/runtest.py tests/ecmascript/test-dev-mandel2-func.js
SUCCESS test-dev-mandel2-func.js [0.0 sec]
duktape@keppihevonen:~/duktape$ python tools/runtest.py tests/ecmascript/test-regexp-invalid-charclass.js

$ python tools/runtest.py tests/ecmascript/test-regexp-invalid-charclass.js
FAILURE test-regexp-invalid-charclass.js [6 diff lines] [errors: expect-mismatch] [0.0 sec]
- Diff to expected result:
    @@ -1,2 +1,2 @@
    -SyntaxError
    +no error
     SyntaxError

$ python tools/runtest.py tests/ecmascript/test-bi-number-proto-toexponential.js
KNOWN   test-bi-number-proto-toexponential.js [74 diff lines] [known: corner case rounding errors in toExponential()] [errors: expect-mismatch,known-issue] [0.0 sec]
- Diff to expected result:
    @@ -77,13 +77,13 @@
     2,19 string -1.0000000000000000000e+21
     2,20 string -1.00000000000000000000e+21
     RangeError
    -3,undefined string -9.8765e+20
    -3,notgiven string -9.8765e+20
    +3,undefined string -9.876500000000001e+20
    +3,notgiven string -9.876500000000001e+20
     RangeError
     3,0 string -1e+21
    [... 62 more lines]

To get the prepped test case without executing the test:
$ python tools/runtest.py --prepare-only --output-prepared /tmp/prepared.js tests/ecmascript/test-bi-number-proto-toexponential.js
Wrote prepared testcase to: '/tmp/prepared.js'
$ nodejs /tmp/prepared.js
[...]

Forgot to mention: the tool searches for includes and known issues automatically related to the testcase location. These will get explicit options before merge.
Similarly, the tool expects "duk" to be in ./duk. If that's not the case, you can say:
$ python tools/runtest.py --duk ./duk.O2.master tests/ecmascript/test-dev-mandel2-func.js
SUCCESS test-dev-mandel2-func.js [0.0 sec]

I'll look at this later.

Yeah, I'm trying to implement a few features which makes it nice to use manually when developing, at least:

Default paths for utilities so that you don't need to provide them explicitly (like now).
Show a short diff snippet so it's easy to figure out what went wrong. Maybe color the diff for easier readability.
Show the line in the original source file which contains the first mismatching expect line - this allows pinpointing the failing test more easily than a plain diff (which can sometimes be confusing for large tests).
Provide comparison to Node.js automatically.

It would be nice if one could say:
$ tools/runtest.py test-bi-math-hypot`

And it would pick up the correct file from tests/ecmascript.

Ok, I'll add that. These defaultings can assume the repo layout so that it would scan for ../tests/ecmascript when a plain name is not found.
So ideally the utility will have some heuristics built-in for manual use, but accept explicit paths and dir names for scripted use with minimal heuristics.

Current output when running:
for i in tests/ecmascript/test-*; do python tools/runtest.py $i; done

is something like:

There are still some of these indent bugs etc, but it's close to being usable as a test suite executor. Apart from summaries etc of course, which should require much less code than what exists in runtests.js now.

Hm, this doesn't seem to work on Windows right now:
D:\src\duktape>python tools\runtest.py test-bi-math-hypot.js
Execution failed
Failed to diff!
FAILURE test-bi-math-hypot.js [1 diff lines] [errors: expect-mismatch,returncode-nonzero,stderr-nonempty] [0.0 sec]
- Test wrote to stderr:
    FIXME
    - Diff to expected result:

Ah yes, it expects a diff command. What would be appropriate on Windows to compare text outputs and provide a diff-like summary?

The other thing you may need to specify now is path to "duk"; it checks for <cwd>/duk but not <cwd>/duk.exe which I probably need to add. So for now:
python tools\runtest.py --duk duk.exe test-bi-math-hypot.js

One alternative seems to be FC but the output looks quite poor. But maybe I'm just used to unified diffs :-)

Windows has FC and COMP.  Oddly, they seem to be different tools and not aliases for one another:
D:\src\minisphere>fc
FC: Insufficient number of file specifications

D:\src\minisphere>comp
Name of first file to compare:

The main problem with FC is that it only shows the lines that are different.  It doesn't include the surrounding lines like diff does.

Would either provide a useful diff output for testcases?

I was initially thinking about implementing a minimal fallback into the runtest.py utility itself. Diffing is trivial until you get to missing or extra lines - at which point you need to actually do work to represent the difference in a useful way.
I don't want to replicate "diff" but maybe the tool could show a few of the changed lines with their line numbers; quite often it's enough to indicate the first (and often only) offender.

COMP looks like it does a character-by-character/binary comparison, so that's useless.  I'd be okay with using FC for diffs.

Ah, COMP only works if the files are the exact same size.  I think that one is a relic from early MS-DOS, so that makes sense.

Ok, so I'll use "diff" if that's in the path (you can install one for Windows, even outside Cygwin) and fall back to FC on Windows if diff is not present.

The tooling works on Cygwin but only if testcase paths in the temporary file are converted to Windows path when executed. Sigh... :)

Yeah, I was never able to get the test tooling to run on Cygwin even before this pull.  I finally just set up a Ubuntu VM for that purpose and haven't had a problem since :)

Now seems to work on Windows command prompt and Cygwin. For command prompt fc is used and ANSI colors are disabled (they seem to be supported out of the box only in Windows 10). For Cygwin paths given to the "duk" command need to be converted to Windows paths but ANSI colors are fine. CR LF normalization is needed for both.

There seem to be a few Math built-in tests that fail on Cygwin right now (atan2 test for example) - I'll open issues/pulls for them once I've confirmed it's the tests and not the tooling.

ANSI colors are disabled (they seem to be supported out of the box only in Windows 10)

Yeah, and there's also a regression in Windows 10 Anniversary Edition (build 14393) that prevents them from working again, so it's better that you disabled them.

Hm, this still doesn't seem to work:
D:\src\duktape>python tools\runtest.py test-bi-math-hypot.js
Execution failed
FAILURE test-bi-math-hypot.js [36 diff lines] [errors: expect-mismatch,returncode-nonzero,stderr-nonempty] [0.0 sec]
- Test wrote to stderr:
    FIXME
    - Diff to expected result:
    Comparing files C:\USERS\FATCE\APPDATA\LOCAL\TEMP\TMP-DUK-RUNTEST-L8MENM\expect  [... 68 more chars]
    ***** C:\USERS\FATCE\APPDATA\LOCAL\TEMP\TMP-DUK-RUNTEST-L8MENM\expect
    0
    NaN
    NaN
    NaN
    Infinity
    Infinity
    NaN
    Infinity
    [... 26 more lines]

I notice a FIXME in the output - Is this not intended to be functional yet?

Did you give --duk option to provide the executable path?

The failure reporting is still broken, that's the FIXME.

Did you give --duk option to provide the executable path?

No, that would make sense what went wrong then.  Guess I'm just too used to Linux builds - "make qecmatest" builds duk automatically :)

Yep, this is just the raw tool so it can't really do that :) But I'll make it print out more useful error messages though.

Error messages should now be a bit better, and the tool now tries both duk and duk.exe. So maybe a plain:
python tools\runtest.py test-dev-mandel2-func.js

should now work.

Moved the utility to util/runtest.py because it won't be part of the dist.

Hm, there doesn't seem to be a way to get it to print the entire output of a test, so I can compare manually?  The diffs often don't have enough context for me to gauge where things went wrong.

--output-stdout <somefile.txt> should do that.

While this utility is still pretty rough, I'm now using it for most test runs because it shows a useful diff directly and the colored output is easy to follow at a glance. It's also easy to run test subsets using a for i in <something>; do python util/runtest.py ... ; done loop.
So maybe in a while this could replace most (or all) of runtests.js and make the testing tools more accessible than they are now.

Ah, thanks.  I thought that option was just for redirecting the normal output (i.e. the diffs)
Regarding coloring: I don't seem to get that on my Ubuntu VM.  Is there a command-line option to enable it?

@fatcerberus The options are quite likely to change when the tool is improved towards replacing runtests.js, but in the meanwhile:
python util/runtest.py --help

shows available options with hopefully reasonable descriptions.

The coloring should be automatically enabled if running on Linux and output is a tty. This is the exact condition:
windows = platform.system() == 'Windows'
cygwin = 'CYGWIN' in platform.system()
istty = sys.stdout.isatty()
use_colors = istty and not windows

It's not really that good so maybe istty is incorrect for you, for some reason.
Note that redirecting causes the output to become not a tty and lose coloring, e.g.:
$ python util/runtest.py tests/ecmascript/test-dev-mandel2-func.js | less
SUCCESS test-dev-mandel2-func.js [0.0 sec]

would not be colored.

I could add a command line option to force ANSI coloring even if the detection doesn't work for some reason.

Hm, on further inspection it seems the coloring is working for the test tool itself (FAILURE with red bg), but Ubuntu's diff isn't colored for some reason.

The diff clip isn't colored: it's just plain output from a diff -u.
If you wanted to view a colored diff, a roundabout way of doing that would be to:

Use --output-diff <somewhere> for runtest.py
Then colordiff < <somewhere>.

Ah, that makes sense.  I got too spoiled by git diff always being colored I guess. :)


Unable to query ldap as stated in README

Inside the container I'm trying to do this;
root@d1ada0b74b70:/# ldapsearch -x -H ldap://localhost -b dc=example,dc=com -D "cn=admin,dc=example,dc=com" -w admin
ldap_bind: Invalid credentials (49)

docker-compose.yml:
version: '3'
services:

    openldap:
       image: osixia/openldap:1.1.10
       environment:
           LDAP_ORGANISATION: "Example"
           LDAP_DOMAIN: "example.com"
           LDAP_ADMIN_PASSWORD: "demo"

you set demo as admin password, use :
ldapsearch -x -H ldap://localhost -b dc=example,dc=com -D "cn=admin,dc=example,dc=com" -w dem

Grateful, I've changed to -W to prompt the password and it did worked.


Support PHP 8.1

PHP version 8.1.* is available as of 25 Nov 2021, and we should consider supporting it eventually, especially since we wil be ending support for verion 7.3 in #335.
Currently, this version's availability in the dep-server is blocked on https://github.com/paketo-buildpacks/dep-server/issues/133, which is a blocker to this issue. Once that is resolved, we can consider introducing the dependency constraint for 8.1  to the buildpack.toml, modify the buildpack/tests as needed, and start receiving version bumps via our automation.

The PHP 8.1 dependency is now available in the dep-server, and https://github.com/paketo-buildpacks/dep-server/issues/133 is resolved.

What's the next step here? Adding 8.1 to buildpack.toml? Or is anything else preventing that?

Adding Php 8.1 is unblocked, and we will be getting to it shortly. We are currently in the middle of a significant refactor to the Php language family of buildpacks.
Logistically, we will add a new section to buildpack.toml that looks like:
  [[metadata.dependency-constraints]]
    constraint = "8.1.*"
    id = "php"
    patches = 2

And the automation will pick up the metadata for 8.1.* from: https://api.deps.paketo.io/v1/dependency?name=php

@enumag release in PHP Dist buildpack v0.7.0

Thanks!


Automated cherry pick of #1563: add deploy failed action log

Cherry pick of #1563 on release/2.11.0.
#1563: add deploy failed action log

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@4c9ea9d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.11.0   #1564   +/-   ##
================================================
  Coverage                  ?   7.69%
================================================
  Files                     ?     411
  Lines                     ?   62934
  Branches                  ?       0
================================================
  Hits                      ?    4844
  Misses                    ?   57683
  Partials                  ?     407

Flag
Coverage Δ

#aFlag
7.69% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9ea9d...2d6c542. Read the comment docs.

/lgtm
/approve


community(sparkllm): Add function call support in Sparkllm chat model.

Description: Add function call support in Sparkllm chat model. Related documents https://www.xfyun.cn/doc/spark/Web.html#_2-function-call说明
@baskaryan

assigning to @ccurme, we should have standard tests for chat models for tool calling right?


prepare release

:white_check_mark: Build TheIdServer 1.0.0-ci.1+17.build.545 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/c1b811c0cf by @aguacongas)


Program lockup when stop audio stream

I was using a python library 'sounddevice' to play audio through bluezalsa device. Most of time, it will works as expect. However, the program will hang occasionally when trying to stop ongoing stream.
I was using bluez-alsa on a Raspberry Pi 3B+ running Ubuntu-mate. The Bluez version is 5.48 from the depot originally. I have tried to upgrade  Bluez to 5.52, but can not fix the problem.
When the issue happens, bluetooth will go off and stop responding completely. And I can not turn on bluetooth anymore, below is the output of bluetoothctl:
[bluetooth]# power on
Failed to set power on: org.bluez.Error.Failed
Restarting bluetooth service or bluealsa will also not help, the only way to recover is a reboot.

This seems a issue of Raspberry firmware https://github.com/raspberrypi/firmware/issues/887

I have tried to build and install the latest rpi-4.19.y branch of https://github.com/raspberrypi/linux on My 3B+ running Ubuntu-Mate 18.04. And confirm that it fixed the Bluetooth problem. I leave it play audio overnight and cannot see an disconnection.
So, close the issue here.


[feature request]: selector-nest-combinators option least

First case which should emit error:
.a {
  &.b {
    color: red;
  }
}

Second case which should be allowed:
.a {
  &.b {
    color: red;
  }

  .c {
    font-size: 16px;
  }
}

@kristerkari What do you think?

Hi @JounQin and sorry for the late reply.
I'm not totally sure what's the use case for having such option, could you provide another example that would maybe be related to some issue that you are having with the rule?
Also, why is the option called least? Is that a good name to describe it?
I'm totally ok with adding the option, but I just need to understand it properly first.

@kristerkari We don't want to add redundant nested block in our team, so current option always | never is both too strict and unreasonable for us.
// input
.a {
  &.b {
    color: red;
  }
}

// expected output
.a.b {
  color: red;
}

Also, why is the option called least? Is that a good name to describe it?

Maybe as-needed be better or not?

@kristerkari Sorry to interrupt, any further discussion?

Any movement on this issue?
Motivation:
Consider the following css code:
.group .item thead th { ... }
.group .item tbody td { ... }
.group .item tfoot td { ... }

I want to avoid duplicating ".group .item" part, but I don't want to add unnecessary nesting. I.e. this is what I want:
.group .item {
  thead th { ... }
  tbody td { ... }
  tfoot td { ... }
}

Obviously neither "never" nor "always" option for selector-nest-combinators let me do this.
So, I agee that "as-needed" option would be helpful that would:

Require nesting for duplicate prefix (e.g. ".group .item" in my example above).
Forbid nesting in all other cases.

@ilyub I'm totally fine with adding such option. Are you able to contribute a Pull Request, or do you know someone who would be able to do it?

I never dealt with stylelint rule programming. So, I can only hope that somebody else gets interested who is more familiar with this ecosystem.


Unable to complete flash, memory write failure

I have the CC1310 Launchpad, trying to flash to one of my contact sensors but am not able to write the file to sensor.  It times out. and I get the errors below.  My launchpad has the TCK pin going to the C pad, the TMS pin going to the M pad.  The 3.3v from the launchpad is going to the + battery terminal and the ground is going to the vbat-.  Is there a trick to allow these chips to take a program load or am I missing something else?

Ok, so I was able to get it to write the flash, I think the problem was the pins weren't making good enough contact with the C and M pads.  It helped to take it out of the case and use some pins that were bent at a 90 degree angle to put more even pressure down on the pads.

Great! Sorry I didn't respond earlier.


Async handler approach

PR against #2, to show what is needed to introduce full async functionality.
Includes some unrelated things as well like cleanup and a channel stream

Really great work @Krulknul 👍 Thank you.
I left some minor comments mostly about style and naming. We can also have a quick call to discuss them if you prefer that.

Thanks for the review!


Feat/fixed many2 many and added update model

The next PR implements a feature that allow the developer to update instead of create a record if the props.id that we are passing to the create are already as a record on our store. It also, fixes a many2many error.

Hey @carlesnunez,
Thanks for submitting a PR! I noticed your other PR https://github.com/tommikaikkonen/redux-orm/pull/112, but I'll leave comments here

Looks like your second commit changes a lot of indentation from 4 to 2 spaces, and there's also some reordering of functions in Model. It's making it hard to see what's changed in logic. Can you revert that commit and only apply the logic changes you're proposing? The project has an eslint config, which you can use with command make lint to check that code adheres to the project style.
Can you provide a failing test case for the fix in https://github.com/tommikaikkonen/redux-orm/pull/124/commits/1be587abf0128f21b3d320ef800481c1649dd2d1?
Updating an instance if one already exists, and creating one if it doesn't, is a common pattern, but I think it could be problematic if it's implicit in the .create method. If I don't read the docs, I wouldn't expect create to update the instance if it already exists. And if it does, I might want to know if the instance actually existed already or not. E.g. in Django you can use Model.objects.update_or_create that takes 1) lookup props and 2) default props. I'm sure other ORM's have a similar method too. I think it could make more sense to put this functionality in it's own method, such as Model.updateOrCreate().

I would name it upsert (update or insert) like at mySQL, Postgres and etc

https://github.com/tommikaikkonen/redux-orm/pull/130/commits/7fdec8423bc3782cc7233751213f04534e335fd6

IMHO this shouldn't be merged as u did. There was an open PR with a person that invests they time to make it work. If we start to take another one 'ideas' or proposals putting them on master just because you can and that person not would demotivate the people to make PR's proposing changes because they wouldn't appear never as a contributors cause their ideas won't be implemented by themselves....
Is not about my work, is about the idea to have one people thinking ways to improve the library and another person taking this ideas and putting on master directly cause he can
Is just my opinion 😞  @tommikaikkonen @plandem

will duplicate my answer here:
1) PR that you mentioned has multi issues

2) there was a request to revert formatting to review changes( that I'm totally agree) for a quite long time without any response/feedback.

3) my commit mainly patches "system" files and add the "upsert" feature that had some positive feedback about naming at original issue and has very simple implementation that already mentioned few times at others issues/comments. So I don't see any problem here.

P.s. It's all about contributing to library and improving it, but not about personal ego and copyrighting every line of code. As for me, I would be fine with such merging.

maybe it's a good idea to create authors.md or contributors.md file with list of people that have some activity at project (issues/PR).

I am agree with that @plandem I close this PR then!


Improvement to rest.py

Summary
A small change to rest.py may make Garak easier to use for Rest. or build it as a plugin for LMstudio.
Brief explanation of the feature.
Makes Rest Generator more flexible.
Basic example
Using Garak against a locally hosted model
If the proposal involves a new or changed API, include a basic code example. Omit this section if it's not applicable.
Changing line 62 of rest.py (https://github.com/leondz/garak/blob/main/garak/generators/rest.py) to
def init(self, uri=None, config_root=_config):
# Attempt to get URI from config if not provided
self.uri = uri or getattr(config_root.plugins, "rest_endpoint", None)
self.name = self.uri
self.seed = _config.run.seed
self.supports_multiple_generations = False  # not implemented yet
self.escape_function = self._json_escape
self.retry_5xx = True
self.key_env_var = self.ENV_VAR if hasattr(self, "ENV_VAR") else None
# Load other configurations
self._load_config(config_root)
Motivation
Why are we doing this? What use cases does it support? What is the expected outcome? this makes it more flexible for organizations to make calls to hosted AI environments. increasing ease of use for orgs that may need to or desire to make API calls against their fully stood up AI application implementation.

Current:
        self.uri = uri
Suggested:
        self.uri = uri or getattr(config_root.plugins, "rest_endpoint", None)
It looks like the change suggested is to add another way of configuring RestGenerator.uri. Currently the module expects this from the constructor. It is probably helpful to have another way of doing this via config. I'm not sure that adding a rest_endpoint var is the optimal way but maybe RestGenerator.uri could be taken from config_root.uri rather than as a constructor param. This would also help unify generator constructor signatures. @jmartin-tech what do you think?

The capability to inject configuration values via the config file was added a few months ago and documentation was recently expanded and published here.
uri is already possible to set via configuration options, if uri is not passed as a keyword parameter it is gathered from config_root.
As noted the docs:
https://github.com/leondz/garak/blob/5eb8ea1df9a04b7ffa605c2c5b74326261e82012/docs/source/garak.generators.rest.rst#L8
An example of a json based config setting uri also in the docs:
https://github.com/leondz/garak/blob/5eb8ea1df9a04b7ffa605c2c5b74326261e82012/docs/source/garak.generators.rest.rst?plain=1#L32-L50
You can also already provide the config in yaml with something like:
plugins:
  generators:
    rest:
      RestGenerator:
        uri: https://localhost:8080/v1

I don't see value in having a fourth location outside the plugins.generators configuration structure that is only used by one generator.

Thanks. Missed that supported_params was also used by Configurable. We're not going to add yet another node for this. @db0109 I hope this config example above plus the ones in the RestGenerator docs are helpful enough, you can reopen if it's not working.


[DNM]: test for ci trigger on release-8.4

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

tikv image not ready, try again later

/retest

/retest

/retest


Aio

copilot:all

🤖 Generated by lychee action
Summary

Status
Count

🔍 Total
885

✅ Successful
348

⏳ Timeouts
0

🔀 Redirected
0

👻 Excluded
536

❓ Unknown
0

🚫 Errors
0

Full action output
Full Github Actions output


No password: Forgot username screen

@keybase/react-hackers CC @zapu @keybase/design

adds a "Forgot your username?" link in the same style as the existing "Forgot passphrase?"

changes the existing "Username or email" prompt to just "Username"

asks you for an email address

if the email exists, button label becomes "Username reminder emailed!" and email is sent

if it doesn't, input field gets error text "We couldn't find an account with that email address. Try again?"

once you get the email you can click Back and provide it in the username screen

@chrisnojima Thanks! All fixed, and tested with nav2.

cool! I will look again after the calls


Update README.md

changed "open in cloud shell" from cloning from installation branch to main branch

changed "open in cloud shell" from cloning from installation branch to main branch


Does pt support qemu user mode? -- Cannot get qemu-system pid

$ qemu-aarch64 -g 1234 -L /usr/aarch64-linux-gnu ./chall

$ gdb-multiarch -ex 'target remote <IP_ADDRESS>:1234' ./chall

> pt -save -filter
Cannot get qemu-system pid

@lonnywong
I think qemu-user is for emulating userspace processes, and not a full aarch64 system. There is no benefit of using gdb-pt-dump for this usecase because there are no page tables exposed by qemu.
I will close this later this week unless you have some more queries.

@martinradev Can you parse it from /proc/<pid>/maps ?

No, this project is not trying to solve this problem, and maps doesn't actually show the mapped pages, it shows the VMAs.

It includes the VMAs and the mapped pages. May need some translation.


add InitialWorld.md

Project Abstract

Please provide a brief description of your project here summarising key points (1-2 paragraphs).
If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

For which grant level are you applying?

[x] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $50,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied, renamed ( project_name.md) and updated.
[x] A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
[x] I have read and acknowledged the terms and conditions.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted.

@LeonardoTZ closing again due to inactivity. If you're still interested, please address David's feedback and do not force-push. Then you can reopen this PR instead of creating a new one.


bugfix assign correct use virtual address value

Proposed changes
Issue Number: close #xxx
Formerly the s3_conf.use_virtual_addressing is mistakenly assigned one opposite value. This pr fixes it and examine using one minio environment.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.43 seconds
stream load tsv:          513 seconds loaded<PHONE_NUMBER>9 Bytes, about 139 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>0 Bytes


check demo site and Tonomy id for all links refereeing to the blockchain

Acceptance Criteria:

[x] all links  referring to the block explorer working on staging tonomy id
[ ] all links  referring to the block explorer working on staging demo app
[ ] all links  referring to the block explorer working on development demo app

the issue is not about the links, but that we don't have history API anymore with leap v3

see for more details:
https://github.com/Tonomy-Foundation/Tonomy-ID/issues/636#issuecomment-1508917764


Resizable Nodes and Services table columns

Testing
(recommended in a private browsing tab)

Navigate to the {Nodes|Services} page
Resize some columns
Refresh the page

Columns should be resizable, and when you refresh the page, the resized columns should be the same width you resized them to
Trade-offs

Dependencies

Screenshots

Also, unit and snapshot tests are failing.

Currently looking into the non-snapshot failure.

Merging master to see if it will fix the issue.

The same test is failing again.

Taking a look at the failing tests.

I've somewhat narrowed down the problem. It comes from the new ui-kit version. It makes the table have height 0 in integration tests.
I tested this by first running master and seeing tests work and then running master with new ui-kit version 2.1.1 and seeing tests break because of invisible tables.

This ui-kit PR should fix the issue: https://github.com/dcos-labs/ui-kit/pull/324
Alternatively, we could have added styles to ensure the div that is a direct child of .table-wrapper fills it's parent's height. The ui-kit fix feels much cleaner though

If there are still failing tests, I will investigate them.

Can't reproduce failing tests locally, retriggered.

Still can't reproduce them locally. Reasons for test failures looking at the artifact video:

It looks like a flake to me.

@GeorgiSTodorov - I wasn't able to reproduce locally either. I wonder why these tests aren't flaking on other PRs though 🤔

@mperrotti , are we sure they aren't?

Merging latest master to see if they are still flakes.

Now it fails locally.

flicts :)

:tada: This PR is included in version 2.108.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update add-form.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerapps-docs/add-form.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerapps-docs/add-form.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerapps-docs/add-form.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Replace random nonce with offset

This is pretty ugly, since I hacked in the offset all over the place instead of rethinking things a bit.

Interestingly, while chacha20 seek fails at values > 1<<38, x chacha20 works for the entire range of u64.
use chacha20::cipher::{NewCipher, StreamCipher, StreamCipherSeek};

fn chacha20_seek() {
    let key: chacha20::Key = [0u8; 32].into();
    let nonce: chacha20::Nonce = [0u8; 12].into();
    let mut cipher = chacha20::ChaCha20::new(&key, &nonce);
    cipher.seek(1u64<<37); // 38 fails
    let mut data = [1u8; 1024];
    cipher.apply_keystream(&mut data);
}

fn xchacha20_seek() {
    let key: chacha20::Key = [0u8; 32].into();
    let nonce: chacha20::XNonce = [0u8; 24].into();
    let mut cipher = chacha20::XChaCha20::new(&key, &nonce);
    cipher.seek(1u64<<62); // 38 fails
    let mut data = [1u8; 1024];
    cipher.apply_keystream(&mut data);
}


NODE_EXPORTER image here was not used in the compute nodes ansible

/unhold
Actually, this is correct and the operator should not be able to define the compute image: that's dataplane-operator job


Reconciliation fails when no user data is provided

When ProxmoxMachineTemplate does not contain spec.template.spec.cloudInit.user, the merging (and thus reconciliation) fails, even though omitting of that field is allowed according to the spec.
As a workaround adding empty map solves this issue:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: ProxmoxMachineTemplate
metadata:
  [...]
spec:
  template:
    spec:
      [...]
      cloudInit:
        user: {}

The underlying issue can be reproduced with code:
mergeUserDatas(bootstrapConfig, baseUserData(vmName), &infrav1.UserData{}) works, but  mergeUserDatas(bootstrapConfig, baseUserData(vmName), nil) doesn't
Either that cases should be handeled or the spec adjusted to not allow omitting that field
Environment:

Cluster-api-provider-proxmox version: 0.3.0

Thank you for pointing out. I don't want to update api(crd) so let's fix by modifying the mergeUserDatas() func to accept nil.
do you mind to send PR out for this ?


Make calvin run on fresh install

Calvin throws an error on default configuration.
Check that configurable is a dict instead of a list
Step pyasn required version to satisfy everyone ..

Hi,
these issues have been addressed in the develop branch. Could you please verify that checking out and running that branch does indeed fix the problems?
Also, could you supply the output from csruntime -l DEBUG when running the (unpatched) master branch on your system?
Thanks,
Per

Yep! It's working :+1:

For the pyasn issue:
(calvin) efryper@elarm-work:~/calvin$ csruntime --host <IP_ADDRESS> --port 5002 --controlport 5003 --name runtime-1 -l DEBUG
Traceback (most recent call last):
  File "/home/efryper/.virtualenvs/calvin/bin/csruntime", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/home/efryper/.virtualenvs/calvin/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3137, in <module>
    @_call_aside
  File "/home/efryper/.virtualenvs/calvin/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3121, in _call_aside
    f(*args, **kwargs)
  File "/home/efryper/.virtualenvs/calvin/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3150, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/home/efryper/.virtualenvs/calvin/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 666, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/home/efryper/.virtualenvs/calvin/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 679, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/home/efryper/.virtualenvs/calvin/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 871, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (pyasn1 0.1.9 (/home/efryper/.virtualenvs/calvin/lib/python2.7/site-packages), Requirement.parse('pyasn1<0.4.0,>=0.3.4'), set(['pyasn1-modules']))

I could not reproduce the configuration problem, a simple raise around the affected code was not thrown.. Maybe the configuration are not always read?


Dev/ivarandj/instance pool operations api

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@ivanarandjelovic please fix https://github.com/Azure/azure-rest-api-specs/pull/29932/checks?check_run_id=27748070049
in dsmain and swagger

@ivanarandjelovic please fix https://github.com/Azure/azure-rest-api-specs/pull/29932/checks?check_run_id=27748070049 in dsmain and swagger

Fixed. DsMainDev PR: https://msdata.visualstudio.com/Database Systems/_git/DsMainDev/pullrequest/1411050

/azp run


fix response is not of given type

Fix error when a percent character is in the passphrase

Typescript/Javascript is not my strongest language so I'm not sure if this is the best way to fix #30, but it works.

LGTM. :D

I added another PR here #35


About logits for ImageNet

Hi,
Thank you for the solid work and code releases!
It seems that for ImageNet training, an additional logits were calculated as 'pooled logits'. May I ask about the actual benefits of this operation? (Sorry if I missed that description in your paper)
Thanks!

Thanks very much for your attention to our work.  'pooled logits' denotes the original Euclidean distance between the average of visual features and prompted text features.  By fusing this global distance and local matching distance with optimal transport, PLOT can achieve a better balance between  features in different granularities. Please let me know if you have any questions.

I see, thanks for your reply!