test(server): vite server restart flow

Description
Since vite server restart flow had been changed, add several test cases for it.

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

I noticed this pr had hung up for a while. It seems harmless, could you review it again @bluwy  @patak-dev Thanks


cakelisp: update upstream url

Description of changes
The old upstream points to the new url:
https://github.com/makuto/cakelisp#cakelisp-has-moved
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

homepage should also be updated.


Find a satisfying solution for problems related to Gradle compatibility matrix

Is your feature request related to a problem? Please describe.
I've been trying to mix and match different versions of JDKs and Gradle, trying to satisfy the Compatibility Matrix. However, I still haven't found a way to satisfy everything.
Describe the solution you'd like
I'd like to have a tool that would identify the mismatch between the tools and solve it by installing necessary stuff and changing the environment variables.
Describe alternatives you've considered
I don't see other alternatives.
Would you want to assign yourself to implement this feature?

[ ] Yes
[x] No

Additional context
Add any other context or screenshots about the feature request here.

Most recent problem:
C:\Users\USER\Documents\github\betting_app\app>cargo android run
 (LM-Q630) with target "aarch64-linux-android"

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':buildSrc:compileKotlin'.
> Error while evaluating property 'compilerOptions.jvmTarget' of task ':buildSrc:compileKotlin'.
   > Failed to calculate the value of property 'jvmTarget'.
      > Unknown Kotlin JVM target: 20

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6s
error: Failed to assemble APK
    command ["C:\\Users\\USER\\Documents\\github\\betting_app\\app\\gen\\android\\gradlew.bat", "--project-dir",
    "C:\\Users\\USER\\Documents\\github\\betting_app\\app\\gen\\android"] exited with code 1

Output of gradle --version:
------------------------------------------------------------
Gradle 8.3
------------------------------------------------------------
Build time:   2023-08-17 07:06:47 UTC
Revision:     8afbf24b469158b714b36e84c6f4d4976c86fcd5

Kotlin:       1.9.0
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          <IP_ADDRESS> (Amazon.com Inc. <IP_ADDRESS>+10-FR)
OS:           Windows 10 10.0 amd64

I don't think we have the capacity to spend on implementing a tool to check for compatibility between gradle and gdk, if google itself didn't provide such a tool, we probably won't either. The compatibility  matrix is good enough. Also the template generated by tauri-mobile tool should be working without any compatibility issues, if you do change the template afterwards, it is your own responsibility to make them compatible.

@amrbashir I started moving in this direction. I've implemented https://crates.io/crates/corretto


Swagger UI

I'm able to generate the JSON file in the ./swagger folder. How do I integrate swagger UI along with it in a sails app on some path say /swagger-api/

you can simply change the directory you want to place the generated swagger json may be assets, then clone https://github.com/swagger-api/swagger-ui following the instructions here
Update the path to the json to the within your assets folder

Thanks :)

you can simply change the directory you want to place the generated swagger json may be assets, then clone https://github.com/swagger-api/swagger-ui following the instructions here
Just simply extract the dist folder (which is needed for just the swagger ui) and update this line https://github.com/swagger-api/swagger-ui/blob/1a95b9e9c972b95227a2976553fea988e58d7ff2/dist/index.html#L44 to be the path to the generated swagger json within your assets folder

Where to extract the dist folder?


GIMP + ComfyUI

Hi !
Where is downloadable the GIMP + ComfyUI plugin you speak about in this README ?
Have you started it yet ?
Is it meant to be libre and accessible ?
Thx btw :)

You can look at https://github.com/Charlweed/gimp_comfyui. It also requires GIMP 2.99. The details are in the README.


Move Phantomjs to a single import and single instance

I'm pretty sure most of the reason that PhantomJS is slow is because we import and instantiate it every single time. A better solution would keep it around after it was started each time. An even better solution would keep it around, but only instantiate it when it was first needed (so calling just one scraper that doesn't use Phantomjs isn't negatively impacted).
There's an answer on StackOverflow that has some tips about this. This also might help with the Webdriver connection errors we seem to have on longer-running processes.

Further investigation here has revealed a few things:

If you quit phantomjs and then try to quickly instantiate a new one, you're looking for pain. There's a 30s timer in the code that in theory makes this possible, since the old phantomjs doesn't go away immediately. But if 30s elapse and your old one is still around, the new one can't be created and then crashes your program. Why it's like this, I know not, but it's certainly annoying. It crashes with:
 Traceback (most recent call last):
   File "/var/www/court-listener/alert/scrapers/management/commands/cl_scrape_opinions.py", line 430, in handle
     self.parse_and_scrape_site(mod, full_crawl)
   File "/var/www/court-listener/alert/scrapers/management/commands/cl_back_scrape_opinions.py", line 11, in parse_and_scrape_site
     for site in site_yielder(mod.Site().back_scrape_iterable, mod):
   File "/usr/lib/python2.7/dist-packages/juriscraper/lib/importer.py", line 51, in site_yielder
     site._download_backwards(i)
   File "/usr/lib/python2.7/dist-packages/juriscraper/opinions/united_states/state/tex.py", line 237, in _download_backwards
     self.html = self._download()
   File "/usr/lib/python2.7/dist-packages/juriscraper/opinions/united_states/state/tex.py", line 56, in _download
     service_log_path=os.path.devnull,  # Disable ghostdriver.log
   File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/phantomjs/webdriver.py", line 50, in __init__
     self.service.start()
   File "/usr/local/lib/python2.7/dist-packages/selenium/webdriver/phantomjs/service.py", line 69, in start
     raise WebDriverException("Can not connect to GhostDriver")
 WebDriverException: Message: 'Can not connect to GhostDriver'

The way we currently import modules means that there's no long-living object that persists between scrapes of one site and the next (or multiple scrapes of the same site, in the case of a backscraper). This means that we need to either load PhantomJS in the caller and pass it to the scraper (which sucks), or change Juriscraper's caller API. Current code works like this:
 module_strings = build_module_list(court_id)
 package, module = module_strings[i].rsplit('.', 1)
 mod = __import__("%s.%s" % (package, module),
                  globals(),
                  locals(),
                  [module])
 site = mod.Site()
 site.parse()

A better approach would probably be to instantiate a new Juriscraper object that holds onto long-running stuff and does the wack-a-doo string conversion for you. Something like:
 j = Juriscraper()
 j.start()
 s = j.parse('tex')  # or j.parse('united_states.opinions'), or whatever.

It's a much nicer API that moves the craziness out of the callers. What's more, it gives us a place where we can keep PhantomJS.

Well, we moved past phantom to just using selenium, and now we might be removing that, so....closing!


Update OWNERS

This change is

/lgtm
/approval

/lgtm
/approve

/lgtm
/approve

Merging explicitly to get around the broken OWNERS..


Add support for Auto Splitting to the c api.

This works in its current state but some stuff needs to be adjusted.

Todo:

[ ] Find a way to expose logging as right now logging just does not work.

[x] Find a way to make auto splitting support optional.

[ ] Improve bindings generator to conditionally include definitions for the auto splitting feature.

The only thing blocking this right now is the fact that we yet to improve the bindings generator. (All of the needed feature attributes have been set up.)
 If anyone has any guidance on this I'd really appreciate it.

I'm going to opt to just stub out the implementation here instead of extending the bindings generator, using this as an example.
We can improve the bindings generator at a later date.

I'm going to opt to just stub out the implementation here instead of extending the bindings generator, using this as an example.
We can improve the bindings generator at a later date.


Adding sample data to penguins

This fixes the issue with the sample data, all of the combinations should pass now without exceptions.
We should think if we want to just host our own xls so this doesn't take 10-20 seconds extra for the user to compose the dataset on start (vs having it ready and just download it from github).
Closes https://github.com/ploomber/cloud-backend/issues/259
@edublancas I wasn't sure how I can get rid of the success outputs, I tried minimizing the feedback: SqlMagic.feedback=0 but it didn't work. Any ideas?

ok, I merged this because it's already an improvement over the original one. feel free to open another PR to make the loading time faster.

you mean the csv? yeah that's fine.
I'm thinking of asking Laura to spend more time on it to make it prettier and more interactive, so up to you if you feel like we need to host the csv right now.


Add serverless-compose

#15
This PR:

introduces serverless-compose (meant to simplify orchestrating multiple services)
removes the UserPoolId and UserPoolClientId SSM parameter resources and instead uses CloudFormation outputs. The cross service output referencing is easily done through serverless-compose.

I proceeded as following, in order to see whether these changes can be a solution to issue #15

recreating the userpool (honestly there was no easy way to recreate it), so I had to:

manually delete the userpool from the AWS console
in auth/serverless.yaml comment out all the UserPool related resources and outputs (note: there is also an environment variable called CLIENT_ID that also needs to be commented out)
in the auth folder run npx serverless deploy
in auth/serverless.yaml bring back the UserPool related resources and outputs by removing the comments you made in the previous steps
again in the auth folder run npx serverless deploy

at the root of the project run npx serverless refresh-outputs
at the root of the project run npx serverless deploy

The API Gateway Authorizer should now reflect the updated values (Issuer which is a string containing your UserPoolId, and Audience, which is the UserPoolClientId)

Thanks for the great idea for simplifying deployment, @volenpopov and sorry it took so long to get back to you.
I tried out deployment and noticed a couple of things we need to check first.

Each serverless.yml loads the stage from config.cjs. When I deploy with serverless compose, this seems to be ignored and the deployment always goes to dev. Is there a way to get serverless-compose.yml to load the stage from config.cjs too?
The change to use CF outputs for User Pool identifiers is more CloudFormation means that sls info does not work in the parent directory or in, say, the backend subfolder. I'm not always keen to use CloudFormation outputs because of the "hard" nature of these dependencies. SSM Parameters also allows the flexibility to delete stacks in any order. Would it be okay to separate out the CloudFormation output idea and just use serverless compose?


In non-sticky sessions mode with only a single memcached the backup is done in the primary node

From martin.grotzke on January 27, 2011 00:33:05
For non-sticky sessions the session is also stored in another, secondary memcached node. If only a single memcached node is configured this one is chosen for backup. For a single memcached storing backups should be omitted.
Original issue: http://code.google.com/p/memcached-session-manager/issues/detail?id=79

From martin.grotzke on February 03, 2011 14:12:34
(No comment was entered for this change.)
Labels: Milestone-1.4.1

From martin.grotzke on February 03, 2011 15:36:49
Fixed.
Status: Fixed

From martin.grotzke on February 07, 2011 02:51:01
(No comment was entered for this change.)
Labels: -Milestone-1.4.1 Milestone-1.4.0-RC2


Support Dynamic Provisioning for PVC

From: https://kubernetes.io/blog/2017/03/dynamic-provisioning-and-storage-classes-kubernetes/

If storageClassName is not specified in the PVC, the default storage class will be used for provisioning.
Existing, “Available”, PVs that do not have the default storage class label will not be considered for binding to the PVC
If storageClassName is set to an empty string (‘’) in the PVC, no storage class will be used (i.e.; dynamic provisioning is disabled for this PVC)
Existing, “Available”, PVs (that do not have a specified storageClassName) will be considered for binding to the PVC

We currently set the storageClassName for our PVC to the empty string, which works well for testing in CRC since it doesn't use Dynamic Provisioning out of the box. For real world clusters though, it might make sense to not specify storageClassName, deferring to the default StorageClass.
If this is not sufficient, we may want to add a storageClassName to the ContainerJFR CRD spec, to allow the user to specify which class they want used for our PVC.
For our CRC testing setups there are some options for Dynamic Provisioning here:
https://github.com/code-ready/crc/wiki/Dynamic-volume-provisioning

I think the best approach is adding the storageClassName property to the CRD. This way users can choose which storage class they want to use, and also keeps static provisioning as an option.

Going beyond this, we could add a whole PVC spec to the CRD. This would allow the user to override defaults for things like storage size as well.


Test issue title

Test issue body
Minimum Approvals: 1
Approval Words: approve, approved
Rejection Words: deny, denied, reject, rejected

approve

Approved by MdShimulMahmud.


docs(custom-api): add examples for embedding and classification providers

Added 'Example - Embedding' to custom-api.md, closes #1294

Thank you for improving our docs @Luca-Hackl!


Lnurl auth problem with latest Spring Boot

Is your feature request related to a problem? Please describe.
I use the latest Spring boot release and I try to implement lnurl auth.
Using your example, I get this error:
'apply(C)' is deprecated since version 6.2 and marked for removal
With latest spring boot release, <C extends SecurityConfigurerAdapter<O, B>> C apply(C configurer) is deprecated.
Now, the method <C extends SecurityConfigurer<O, B>> C apply(C configurer) should be used.
Describe the solution you'd like
Upgrade to latest spring boot release or tell me how I can make it work :)

Hey @straumat!
Thank you so much for the report. :muscle:
In my local spring verison the deprecation text says For removal in 7.0. Use {@link #with(SecurityConfigurerAdapter, Customizer)} instead..  Thank you for making me aware of it. See #106.
Please correct me if I am wrong but this means it is in your own application, right?
Is it sufficient to just apply the changes from the branch?
- apply(new LnurlAuthConfigurer()
+ with(new LnurlAuthConfigurer(), it -> it

Please let me know if I understood it correctly :pray:
On side note, but unrelated:
The latest devel branch should be compatible with Spring Boot v3.2.1 and Spring v6.1.2.
Since OSSRH is down (last check 2024-01-18) I cannot deploy a snapshot release at the moment. As soon as it is up again, I update 0.12.0-SNAPSHOT and soon after 0.12.0.

Thank you so much for the amazing, fast, and accurate support!
Indeed, with your solution + with(new LnurlAuthConfigurer(), it -> it, the code compile. I did not finish yet to implement lnurl-auth in my application. I still have hard time understing why we have to keep k1 and not generate one each time the user log! I hope to write an article about how to implement it with your library. Thanks a lot for this work.
The work is in progress on my Royllo project, it's an explorer for Taproot Assets. In fact, i'm not too at ease with this new way to code in Java, that's why I did not get the error.
Thanks again!

Hey @straumat! Nice. If there is anything you need help with, or if you have any question, please do not hesitate to reach out to me. :pray:


Add installation and packaging targets [guanpu]

GitLab account: guanpu
Installation
Build the image:
docker build -t IMAGENAME .
Run in interactive mode by mounting the current folder (Ensure you are inside the git repo's root directory):
docker run --rm -it --mount type=bind,source="$(pwd)",target=/mnt/cpack-exercise IMAGENAME
I have implemented docker automate building process.
You can find the debain package in dir:
/mnt/cpack-exercise/output
But to test the build process manuely, follow these steps:
cd /mnt/cpack-exercise/
mkdir -p build
cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
make
make package
apt install ./cpackexample-0.1.0-Linux.deb
/usr/bin/cpackexample

Solved bonus exercise tasks

File size comparison
The comparison of the tar.gz package with and without file stripping results in:

du -h cpackexample-0.1.0-Linux-unstripped.deb
4.4M	cpackexample-0.1.0-Linux-unstripped.deb
du -h cpackexample-0.1.0-Linux.deb
2.5M	cpackexample-0.1.0-Linux.deb
Unstripped cpackexample package needs1.9M more space.
2.. Fixed lintian warnings
First output:
E: cpackexample: extended-description-is-empty
E: cpackexample: malformed-contact Maintainer Guanpu
E: cpackexample: missing-dependency-on-libc needed by usr/bin/cpackexample
E: cpackexample: no-changelog usr/share/doc/cpackexample/changelog.gz (native package)
E: cpackexample: no-copyright-file
W: cpackexample: no-manual-page [usr/bin/cpackexample]

Final output:
W: cpackexample: no-manual-page [usr/bin/cpackexample]

Error: extended-description-is-empty
Fixed bu adding set(CPACK_PACKAGE_DESCRIPTION "This is SSE cpack exercise")
Error: malformed-contact Maintainer Guanpu
Fixed by adding
set(CPACK_DEBIAN_PACKAGE_MAINTAINER "Guanpu<EMAIL_ADDRESS>Error: missing-dependency-on-libc needed by usr/bin/cpackexample
Fixed by adding libc6 dependency
Error: no-ropyright-file Copyright file missing
Fixed by adding
install(FILES "${CMAKE_CURRENT_SOURCE_DIR}/cmake/debian/copyright" DESTINATION "${CMAKE_INSTALL_DOCDIR}")
Error: no-changelog-file Changelog file missing
Fixed by adding
add_custom_command(
    OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/changelog.gz"
    COMMAND gzip -9 --no-name -c "${CMAKE_CURRENT_SOURCE_DIR}/cmake/debian/changelog" > "${CMAKE_CURRENT_BINARY_DIR}/changelog.gz"
    DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/cmake/debian/changelog"
    COMMENT "Compressing changelog file"
)

add_custom_target(compress_changelog ALL DEPENDS "${CMAKE_CURRENT_BINARY_DIR}/changelog.gz")

install(FILES "${CMAKE_CURRENT_BINARY_DIR}/changelog.gz" DESTINATION "${CMAKE_INSTALL_DOCDIR}")

Warning: changelog-not-compressed-with-max-compression
Fixed by using the option -9 for the highest compression with gzip when compressing changelog
Warning: package-contains-timestamped-gzip 2024-12-10T19:13:16 [usr/share/doc/cpackexample/changelog.gz]
Fixed by using the option -no-name
Warning: no-manual-page [usr/bin/cpackexample]
didn't fix

Debian package did not have the standard name. Rest looks good 👍
The automated package creation did not work for me. How should I run the container exactly?

I just build the image with ' docker build -t ex5 .' and use docker run it ex5, the result should be in output folder.

What message did you get when auto package doesn't work?

The output needs to be on the host system, not in the container. The container should not run in interactive mode.

The output needs to be on the host system, not in the container. The container should not run in interactive mode.

Ah sorry, I missunderstand the task. Do I still have chance to change?

I am happy to review any updates. Of course, grading also needs to take the deadline into account.


Upstream nixpkgs?

Is your feature request related to a problem? Please describe.
Can I use upstream nixpkgs? Branch release-20.03 now have flake.nix. I tried to switch to it but stuck on error: "flake-registry.json' has unsupported version 2".

Yeah I was having the same issue, basically it has to do with the recent merge and some commit updates that change the registry version. If you were using this before the merge it will give you the error. Simplest fix is to simply change the nixpkgs input manually inputs.nixpkgs.url = "github:NixOS/nixpkgs"; for a single update.
Then after the update finishes, you could just drop the input all together and just use nixpkgs from registry, since it is now pointing to upstream. I'm gonna be updating it myself in a bit, my machine is in the middle of updating right now. Once it is done, I'll push the commit.

Changing inputs.nixpkgs.url don't solve problem in my case. I had to remove inputs.home.url to build.
If I unintended correctly your fork of home-manager is depending on your fork of nixpkgs.

Thanks to this commit: https://github.com/NixOS/nixpkgs/commit/e421d740cba3dbd78d5f3d592a4413237c0b0363 I was able to update the system to 20.03 but without home-manager.
How to update:

Change inputs.nixpkgs.url to "github:NixOS/nixpkgs/release-20.03";
Remove home-manager from config (I wasn't able to fix it :( )
Mount /nix/store in rw mode mount -o remount,rw /nix/store
Replace local cache of flake-registry.json (in my case nix/store/a4db1w50nsqy79xv072ijf5pi4x0g4cl-flake-registry.json) with version 1 (last working version 1 https://raw.githubusercontent.com/NixOS/flake-registry/5bfb0451bf1d527916b28112937da9382f4ecf26/flake-registry.json)
4.Update

Only left problem is broken home-manager.

Commit dd7f6b0c6b461dbc69c1b11ebcf1c8ea5b6160ec from nixpkgs contains the update nixFlake version that supported the registry v2 format.


app will freeze when video hasn't been loaded, if video link is broken, then the app will freeze

app will freeze when video hasn't been loaded, if video link is broken, then the app will freeze, I suggest, the video should be loaded after entering the activity!

@MacauNext  Thanks.I'm rewriting this project.

glad to to your quick improvement, there still some problems, in the landscape full view, the Back arrow is not working.
And you should put the Play button in the video player for user to click to play more convenient, also you can set a thumbnail or background for the video. :)

Thanks for your report.I'll add these features in the future.

2.0.0 has been released.


lifecycle does not get defaultProps from pure component

This is my example: https://gist.github.com/pr1ntr/15531b21736fbf66eb67aa5f01c7d238
id from defaultProps does not show up in this.props

can you elaborate, also is lifecycle being deprecated?

Why are you thinking that defining static property in one place it must propagate there you want?
What to elaborate here ;-)
Just use defaultProps enhancer and all will be fine
compose(
defaultProps({ blabla }),
...
)

yep I think it will be deprecated

thanks


Adds a note about notion in the standup doc

Fixes https://github.com/artsy/potential/issues/173

This should have a link to the notion doc https://www.notion.so/artsy/Standup-Notes-28a5dfe4864645788de1ef936f39687c

And I’m not sure how I can link to the notes externally


Cannot update azure-cli to release 2.0.76 on osx

Trying to install the latest version of Azure-cli on osx using homebrew, but no matter what I'm doing:

Upgrade
reinstall
remove then install
I'm still getting the version 2.0.75 of Azure-cli

we are waiting for Homebrew team to merge PR: https://github.com/Homebrew/homebrew-core/pull/46244

2.0.76 is now available on Homebrew.


feature/training

close (#35)
Save & handle the train data in firebase/firestore database instead of .csv
Handle its embedding within pinecone, instead of .json
Implement CRUD logic to managing train-data and partially update-logic in pinecone for its vector data.

@jupiter0913 There are 2 problems:
1. sendNotification is not working with saucelab test.
{
"message": "Please search an image that shows Brown Teddy Bear",
"token": "eSyP3i7ITZuq8hWn2qutTl:APA91bH1FtWkaTSJwuX4WKWAl3Q-ZFyrOw4UtMP4IfwuvNrHOThH7EvEGIhtguilLRyQNlLiXatEN0xntHAc8bbKobSGjge3wxIHlspbIWY_855CzONqaVdl3y3zOmgKZNnuhYi4gwbh",
"uuid": "c40a09075d11940f"
}
It should return "image_name" with "image" as its program but it returns null
2. please optimize the code block to fetch the document from document model without calling iterator.
https://github.com/ttt246/Brain/blob/feature/training/Brain/src/rising_plugin/guardrails-config/actions/actions.py#L82
We should call any method to get only one document by id without getting all documents.
It will cause some performance issue with a number of documents to iterator them.


Twisted Site should start factories wrapped as resources

WebSocketResource wrapping a factory does not call startFactory on the wrapped Autobahn WAMP or WebSocket factory. And it probably should not. But instead, the Twisted Site should call startFactory when during startup.

This doesn't apply to AutobahnPython anymore / anyways => moved to Crossbar.io


NGAP Onboarding

💡 Description

we want people in the team to be able to use SDAP:

[x] vivian
[x] jimmie
[x] thomas
[x] ramesh
[x] jordan

all NGAPers have been onboarded


request to add Vignesh Murugan to the triage team

Hi @VigneshMurugan , welcome! You may want to follow the process outlined in our guide here: https://github.com/expressjs/express/blob/master/Contributing.md#becoming-a-triager

Welcome @VigneshMurugan

Welcome @VigneshMurugan ! You should have an invite to the triage team in the expressjs org.


Cannot replicate LSTUR results for MIND large test

Hello, I cannot replicate the results of LSTUR model with MIND test set. I used the scripts provided to generate embedding.npy, word_dict.pkl and uid2index.pkl for test set because they are not provided with MINDlarge_utils.zip.
I use the last lines of code in lstur_MIND.pynb to make predictions in test set, but the results of metrics in validations and test are very differents.
For example, I obtained
group_auc: 0.65, mean_mrr: 0.31, ndcg@5: 0.34, ndcg@10: 0.40 in validation and auc: 0.5075, mrr: 0.2259, ndcg@5: 0.2309, nDCG@10: 0.2868 in test set, with the model trained for 10 epochs.

Do you have a solution yet ??

Hello, I cannot replicate the results of LSTUR model with MIND test set. I used the scripts provided to generate embedding.npy, word_dict.pkl and uid2index.pkl for test set because they are not provided with MINDlarge_utils.zip.
I use the last lines of code in lstur_MIND.pynb to make predictions in test set, but the results of metrics in validations and test are very differents.
For example, I obtained
group_auc: 0.65, mean_mrr: 0.31, ndcg@5: 0.34, ndcg@10: 0.40 in validation and auc: 0.5075, mrr: 0.2259, ndcg@5: 0.2309, nDCG@10: 0.2868 in test set, with the model trained for 10 epochs.
Do you have a solution yet ??

Do you have a solution yet ??

I originally calculated the embeddings for the test set only and used them for prediction. I solved it, recalculating all the embeddings for train, validation and test set.


added usage of subtest for etl

One of #2098

CI error: --- FAIL: TestSeedWithTime (0.00s)  animal_magic_test.go:22: SeedWithTime always sets the same seed
The example uses time.Now().UnixNano()) so it should be fine, therefore I added a constant offset and the test should not fail again


Include guava:failureaccess in jar

Issue #, if available: Related to https://issues.apache.org/jira/browse/FLINK-23009
Description of changes:
This is a runtime dependency without which we get exceptions
in flink kinesis sql connector.

LGTM, thanks

Just out of curiosity, is this problem observed in 2.1.0? Thanks!

Hey @acruise this was merged before commit fb27d907ae6af7f0d31180d8371dc3a5e694f3c2 (version 2.1.0) and I believe Danny ran an end-to-end test suite against 2.1.0. So I don't believe it's observed in 2.1.0.


Test realtime performance view

Testing https://github.com/microsoft/vscode-js-debug/issues/755

[x] anyOS @jrieken
[ ] anyOS @sbatten

Complexity: 3
Create Issue

This iteration the flamechart visualizer now includes a "realtime performance" view which appears in the Debug view while running a JavaScript debugee (node.js, browser, or ext host).

The graph shows performance information for the active (currently selected) debug session
The top left is the graph vertical scale
The bottom times are the horizontal scale.
The bottom indicates the color of each series, along with the current value. Hovering on the chart will show you the value at that point in time.
Clicking on the series expands the "configurator" which lets you toggle series on and off (Node.js only support CPU and heap; browsers support more). When expanded, you can click on the graph to collapse the configurator.
The gear in title opens a quickpick giving similar functionality as the configurator (this is also accessible via command)
The split action toggles between showing all the series on one plot, versus having separate plots
You can configuring easing, the poll interval, and the width of the graph (in milliseconds) data to retain

Verify that things work and the UI makes sense to you

I don't get this to work/show.

The bumped commit was reverted from the last Insiders, so you may need to use js-debug nightly or tomorrow's insiders.

Filed a few polish items but I really like this 👏

Thanks! :)


analyze native memory allocation

First of all, thanks for this awesome software!
I am using async-profiler to analyze memory allocation. I have some question about the result.
I find method Unsafe_AllocateMemory in jvm only use os::malloc to allocate memory.  why I can see mprotect and mmap in stack.
this is my test code:
public class MemoryTest {

    public static void main(String[] args) throws Exception {
        new Thread(() -> {
            while (true) {
                ByteBuffer buffer = ByteBuffer.allocateDirect(1024 * 1024 * 10);
                try {
                    TimeUnit.MILLISECONDS.sleep(100);
                } catch (InterruptedException e) {
                    e.printStackTrace();
                }
            }
        }, "leak_thread").start();

        System.in.read();
    }
}

$./profiler.sh -d 10 -e malloc 30035
Started [malloc] profiling
--- Execution profile ---
Total samples       : 121

Frame buffer usage  : 0.0132%

---<PHONE_NUMBER> events (99.99%), 96 samples
  [ 0] malloc
  [ 1] os::malloc(unsigned long, MemoryType)
  [ 2] Unsafe_AllocateMemory
  [ 3] sun.misc.Unsafe.allocateMemory
  [ 4] java.nio.DirectByteBuffer.<init>
  [ 5] java.nio.ByteBuffer.allocateDirect
  [ 6] NativeLeakTest.lambda$main$0
  [ 7] NativeLeakTest$$Lambda$1.834600351.run
  [ 8] java.lang.Thread.run

   .....

./profiler.sh -d 10 -e mprotect 30035
Started [mprotect] profiling
--- Execution profile ---
Total samples       : 57

Frame buffer usage  : 0.0026%

--- 53 events (92.98%), 53 samples
  [ 0] __GI___mprotect
  [ 1] sun.misc.Unsafe.allocateMemory
  [ 2] java.nio.DirectByteBuffer.<init>
  [ 3] java.nio.ByteBuffer.allocateDirect
  [ 4] NativeLeakTest.lambda$main$0
  [ 5] NativeLeakTest$$Lambda$1.834600351.run
  [ 6] java.lang.Thread.run

./profiler.sh -d 10 -e mmap 30035
Started [mmap] profiling
--- Execution profile ---
Total samples       : 12

Frame buffer usage  : 0.0008%

---<PHONE_NUMBER> events (100.00%), 10 samples
  [ 0] mmap64
  [ 1] sun.misc.Unsafe.allocateMemory
  [ 2] java.nio.DirectByteBuffer.<init>
  [ 3] java.nio.ByteBuffer.allocateDirect
  [ 4] NativeLeakTest.lambda$main$0
  [ 5] NativeLeakTest$$Lambda$1.834600351.run
  [ 6] java.lang.Thread.run

Unsafe_AllocateMemory in jvm
UNSAFE_ENTRY(jlong, Unsafe_AllocateMemory(JNIEnv *env, jobject unsafe, jlong size))
  UnsafeWrapper("Unsafe_AllocateMemory");
  size_t sz = (size_t)size;
  if (sz != (julong)size || size < 0) {
    THROW_0(vmSymbols::java_lang_IllegalArgumentException());
  }
  if (sz == 0) {
    return 0;
  }
  sz = round_to(sz, HeapWordSize);
  void* x = os::malloc(sz, mtInternal);
  if (x == NULL) {
    THROW_0(vmSymbols::java_lang_OutOfMemoryError());
  }
  //Copy::fill_to_words((HeapWord*)x, sz / HeapWordSize);
  return addr_to_java(x);
UNSAFE_END

Please there is another issue re this where @apangin has already answered why and how :)

https://github.com/jvm-profiling-tools/async-profiler/issues/336

One hint from me, if you want to find places in your system that really easts your RAM you can profile page-faults.

As I explained in this video, malloc implementation calls mmap and mprotect under the hood to extend native memory pool.
libc (which malloc is a part of) is usually compiled without frame pointers (-fomit-frame-pointer optimization), that's why async-profiler can't show that mprotect/mmap is actually called by malloc.

As I explained in this video, malloc implementation calls mmap and mprotect under the hood to extend native memory pool.
libc (which malloc is a part of) is usually compiled without frame pointers (-fomit-frame-pointer optimization), that's why async-profiler can't show that mprotect/mmap is actually called by malloc.

Thank you very much for your reply. The video is very good.

One hint from me, if you want to find places in your system that really consumes your RAM you can profile page-faults.

@apangin @krzysztofslusarski could you please tell me what to look for in page-faults flame graph to say what is actually consuming RAM?

Flame graph just presents you what were the execution stacks that consumed some resource. The resource can be CPU, Heap, time, native memory ....  The semantics of the flame graph is the same for all the resources. In case of page faults it simply shows you the stacks where page fault occurred. The top frame is responsible for the page fault, everything beneath is simply a stack trace.
Page fault is not a 1-1 relation to RSS expansion, but from my experience this usually brings needed information. You also need to watch out for heap expansions, to avoid that you can use Xmx == Xms and +XX:AlwaysPreTouch.


Azure Cloud Service Deployment missing "Affinity group" setting

When i add the task "Azure Cloud Service Deployment" i can configure "Service Location".
But i cannot define a Affinity group.
When i specify the affinity group in service location it fails.
The command executed by the deployment script is :
New-AzureService -ServiceName ServiceName -Location AffinityGroupName
This needs to be :
New-AzureService -ServiceName ServiceName -AffinityGroup AffinityGroupName

Addressed in PR


Dwell Time

I'm using git master of svgtogcode and j-tech with a laser driven by grbl.
I've activated Dwell Time.
This adds G4 P statements into my gcode
These statements are however added AFTER the laser did it's cut.
When cutting things like cardboard, it be very useful if the dwell time is here:

laser powered off (m5)
laser is moved to next position (g1)
laser is turned on (m3)
dwell time (G4 P)
laser is moving for a cut (g1)

right now step 4 is done before step 1.
I'm not sure, if my use-case is different, or if this is a bug.

To be honest I'm not sure how the dwell time helps. I added it based on someone's request because it easy to implement. Could you help me understand the purpose of dwelling before a cut?
I'd propose having a two integer argument like dwell_before_cut and dwell_after_cut. What do you think?

I experienced this issue on my blue diode laser, when cutting white paper / cardboard / stickers too quickly.
Basically, the paper will absorb better, once it got black. When cutting too quickly, this may not happen at the point where the cut is supposed to start, but along the line where a small disturbance increases the absorption.
This is where that dwell_before_cut would really help.
I understand that the actual reason to introduce dwell_time comes from milling machines, where the actual milling process requires some time to settle in.
Making this configurable as you say sounds like a perfect solution!

Hi There,
I came back to the very same issue. The fix seems simple. Please see the PR #29


[CI] Move DeepSpeed into CUDA image, remove DeepSpeed install from azure

What does this PR do?
Moves DeepSpeed to be installed within the CUDA image, and the azure pipeline to not install it everytime.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

have you populated the docker hub with this new image, otherwise, it will fail because this new image is not used and Azure already dropped install...

I learnt from my master @Borda and have already :)

have you populated the docker hub with this new image, otherwise, it will fail because this new image is not used and Azure already dropped install...

I learnt from my master @Borda and have already :)

just noticed push/pull :D


Feature: (optional) UM can ignore identity changes emitted from stream

also adds javadoc to UndoManagerFactory and UndoManager
also uses default methods to reduce code duplication in the factory

Address #14

Since there's no Travis CI on here:
~/Git Projects/UndoFX $ git branch
* addIdentity
  master
  placeholderForRound2Work
  undo-redo
~/Git Projects/UndoFX $ gradle test
:undofx:compileJava
:undofx:processResources UP-TO-DATE
:undofx:classes
:undofx:compileTestJava
:undofx:processTestResources UP-TO-DATE
:undofx:testClasses
:undofx:test
:undofx:jar
:undofx-demos:compileJava
:undofx-demos:processResources UP-TO-DATE
:undofx-demos:classes
:undofx-demos:compileTestJava UP-TO-DATE
:undofx-demos:processTestResources UP-TO-DATE
:undofx-demos:testClasses UP-TO-DATE
:undofx-demos:test UP-TO-DATE

BUILD SUCCESSFUL

Total time: 1.455 secs

Actually, let me update the build file to resolve links to ReactFX properly, too.

Ok. Good to go.

You forgot the main thing: test for identity after merging. This can be done in the private C[] merge(C c1, C c2) method, returning an empty array when the result of merge is identity.
Also, to reduce the number of constructors, a constructor should take isIdentity only if it also takes merge. When there is no merge, instead of  passing in isIdentity, the user can just filter changeStream with !isIdentity.

You forgot the main thing: test for identity after merging. This can be done in the private C[] merge(C c1, C c2) method, returning an empty array when the result of merge is identity.

Sorry. Somewhere in the process, I thought the isIdentity only applied to the changes that are emitted by the eventstream, not the merge process. Re-reading through #14, I realize that's not the case. I'll fix it possibly tomorrow but definitely by next week.

Fixed.
On another thought, should there be a 3rd constructor with a merge parameter but no isIdentity parameter because it assumes that every emitted event and merged event is non-identity?

Yes. That also preserves compatibility with the previous version.

Fixed

I've updated it to use the empty array approach now.

I've addressed your comments.
Additionally, I removed the javadoc for merge when isIdentity = c -> false because there's no point in mentioning the change annihilation part since that will never happen in those cases.

Since I haven't heard anything back from you about the documentation issue, I'd like to clarify some things to insure no offense was made and to insure this gets done. I initially removed the javadoc concerning the changeStream, apply, and invert parameters because I thought your comment implied it was pointless to document them. Then you later implied that documenting these parameters  was worth it, and listed what could be documented. You also indicated another place where documentation could be improved merge. Since this PR was taking longer than expected (I take blame for misunderstanding and misreading), taking time away from papers I still need to write before my semester ends, and since you implied that additional documentation was needed but did not specify what exactly, so that I could write it quickly and easily, I thought that you should document it because it would meet your standards and be immediately merged whereas it might be delayed by miscommunication between us via comments of "this could be better documented" or "you forgot to do this." So, while I'm guessing you haven't responded due to being busy with other matters and haven't been offended, I want to insure I did not somehow offend you by my comment.
With that being said, I'd also guess that it would be inconvenient for you to literally document this yourself: you would need to add my repo, check out a local copy, document everything, submit the changes to my repo, where I would then have to merge it, and then you would merge this PR here. Thus, it would be better if I could fix the documentation and update this PR. Since I am unsure what I should write, I think it would be faster if you wrote the documentation via comments and I updated my PR to include those comments in the documentation. Your thoughts?

Don't worry, no offense taken, just being busy ;)

I initially removed the javadoc concerning the changeStream, apply, and invert parameters because I thought your comment implied it was pointless to document them.

I only meant to imply that those specific comments were pointless (duplicating the code).

you implied that additional documentation was needed

You said you were going for completeness. I pointed out there was something worthwhile to document [if you really wanted to].

but did not specify what exactly, so that I could write it quickly and easily

I just wanted to give you the chance to figure it out yourself (if you wanted). If not, I can as well just merge (since I'm already happy with the code) and update comments myself afterwards.

Good luck with your papers 😉

Ah, thanks for the clarification. That makes sense now.

I just wanted to give you the chance to figure it out yourself (if you wanted). If not, I can as well just merge (since I'm already happy with the code) and update comments myself afterwards.

Thanks for not taking away my opportunity to learn. While I think completeness is best, I probably won't be able to get to this until after my semester finishes (mid-may ish). So, the goal is to fix RTFX ASAP so that a new release without any regressions is made, then it makes sense to merge this now. If you're willing to wait, then I could do it after my semester finishes, but the context of our conversation will not be as fresh in my mind.

Good luck with your papers

Thank you sir!

Just fetched your new updates. Why did you add the nextToUndo/Redo? (And wouldn't nextUndo/Redo be easier to read than what you have?)

Yeah, I guess maybe those would have been better names...
The motivation is to be able to peek at the next/previous change, so that one can display
"Undo: Insert text", "Redo: Move object" as menu item labels or button tooltips.

The motivation is to be able to peek at the next/previous change, so that one can display
"Undo: Insert text", "Redo: Move object" as menu item labels or button tooltips.

Mm.. Good idea.

Yeah, I guess maybe those would have been better names...

Maybe in UndoFX 1.3.2?

Yeah, but I'm not going to make another release just for that.

Makes sense.


Corrupted data after hot code push

Hi,
when storing objects with methods in a pure client side collection, very often the data becomes corrupted (key and values are swapped randomly) after a hot code push.
Steps to reproduce:
//create a base project with meteor create

//create a pure client side ground collection
testColl = new Ground.Collection('testColl', { connection: null });

//go in the console and create an object with methods:
var obj =  {a:1, b:function(){return "foo";},c:function(){return "bar";}};

//insert it in the collection
testColl.insert(obj);

//Modify a line in your code to force a hot code push.
//Then in the reloaded console, do a
testColl.find().fetch()

//The object will be corrupted.

Strange thing is that if you try it again with the same object it work, but then adding an object with more methods and keys will get you again a corrupted object after hot code push.

Updated report, you need an object with two methods.

So if you dont have functions in the object you insert its working? - It should actually throw an error, functions are not jsonable/ejson - so the behaviour is expected, but it should throw an error.
I'm not 100% sure why it doesn't fail - it could be that the MiniMax.minify tries to reason about this - it should just skip functions.

Edit: minify should actually dont skip - it should just insert the function - have to investigate if its iterating over function properties.

"So if you dont have functions in the object you insert its working? - It should actually throw an error, functions are not jsonable/ejson - so the behaviour is expected, but it should throw an error."
IMHO it should not throw, but just drop the keys corresponding to functions, like regular meteor collection.
I have tried to do a EJSON.parse(EJSON.stringify(obj)) before insert, but i'm still not 100% sure that this is correcting my problem. I need a tad more experimenting.

Actually in my app, when i insert a pure data object without functions (through EJSON parse/stringify "filtering"), it doesn't persist through hot code push, althought it could be due to a bug on my part.
I dont know if ground db is designed to persist the data between HCP. I'm trying to replace the meteor Session with a client only ground db collection, as a mean to do session persistance of my objects.

My findings show that once you have a corrupted document in the grounddb, it goes berserk, and is never considered loaded.
So it's not only corrupting the document but also the whole grounded db.

Only solution after the corruption has occured is to clear the whole localstorage. Perhaps there should be some validation (?) to ensure one faulty document can't doom the whole grounddb ?

Please take a look at my PR:
https://github.com/GroundMeteor/minimax/pull/3
It can have a performance penalty but i think it's worth it.

Thanks but I hope its fixed now?

No, it doesn't work.
Please take a look at my test added in my pull request.

<EMAIL_ADDRESS>


Log files created are named "rotatorXXX.log" even when other device

When using the code as described in the documentation to create a different device, for example ObservingConditions, the log file that is generated is "rotatorXXX.log" instead of say "observingconditionsXXX.log".  In the log.py file, line 74 appears to have the name of the log file hard coded to "rotator.log".  Might want to add this to your changes in the documentation to modify this line in log.py or add it as a config.toml setting.

This is a good one. Thank you!!! Since the server can host multiple device types and the logging is part of the server I'll change the file to alpyca. Change committed for 0.4


Crash when OpenFile dialog is closed clicking cancel button

I, firts sorry mi english.
When i use the OpenFile dialog if i close it or press Cancel the program is crass. This us the error messages:

/home/sonlink/proyectos/vid4web/index.js:31
const filename = libui.UiDialogs.openFile(window);
^
Error: basic_string::_M_construct null not valid
at add_btn.onClicked (/home/sonlink/proyectos/vid4web/index.js:31:36)

If i select a file and press Accept works correctly.
I use the last release installed with npm

What OS and version are you using?
What Node.js version?
Are you able to reproduce the problem using one of the example? (node-pad has an open menu that open a file dialog)

OS: Arch Linux
NodeJS: 10.2.1
And, yes, crash in examples/node-pad.js in Open, Save and Save AS

Ok I'll try to reproduce it.

related to https://github.com/mimecorg/vuido/issues/21

Yes, it's a libui-node bug.

TL;DR: uiOpenFile returns NULL when aborting and we're then freeing the NULL.

Code from libui/test/page5:
static void openFile(uiButton *b, void *data)
{
	char *fn;

	fn = uiOpenFile(parent);
	if (fn == NULL)
		uiLabelSetText(uiLabel(data), "(cancelled)");
	else {
		uiLabelSetText(uiLabel(data), fn);
		uiFreeText(fn);
	}
}

libui-node:
https://github.com/parro-it/libui-node/blob/154e660c7392620d14aba0ade4b346640737b373/src/UiWindow.cc#L166-L171

Fixed in version 0.2.1


Is there is a way to run whatsappWebToGo on old devices, like android 4.4.4?

Android Web view is bundled into 4.4 and not updated trough the store, it's to old to run whatsapp web. -> not supported.
To bring this app to 4.4, a webview need to be bundled in the apk and updated separately which would result in a way bigger apk which has to be maintained separately. Marked share for devices below Anrdoid 7.0 is <3% -> won't do.

Thanks for the Information 92lleo


HDDS-2250. Generated configs missing from ozone-filesystem-lib jars

What changes were proposed in this pull request?
Concatenate ozone-default-generated.xml files using Maven Shade Plugin's built-in XML transformer.
https://issues.apache.org/jira/browse/HDDS-2250
How was this patch tested?
Ran Hadoop 3.1 and 3.2 acceptance tests:
$ cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozone-mr/hadoop32
$ ./test.sh
...
hadoop32-hadoopo3fs :: Test ozone fs with hadoopfs                    | PASS |
...
hadoop32-mapreduce :: Execute MR jobs                                 | PASS |
...

$ cd ../hadoop31
$ ./test.sh
...
hadoop31-hadoopo3fs :: Test ozone fs with hadoopfs                    | PASS |
...
hadoop31-mapreduce :: Execute MR jobs                                 | PASS |
...

Checked the concatenated XML:
$ unzip hadoop-ozone/ozonefs-lib-current/target/hadoop-ozone-filesystem-lib-current-0.5.0-SNAPSHOT.jar ozone-default-generated.xml
$ grep '<name>' ozone-default-generated.xml| sort -u
    <name>hadoop.hdds.db.rocksdb.logging.enabled</name>
    <name>hadoop.hdds.db.rocksdb.logging.level</name>
    <name>hdds.containerscrub.enabled</name>
    <name>hdds.containerscrub.metadata.scan.interval</name>
    <name>hdds.containerscrub.volume.bytes.per.second</name>
    <name>hdds.ratis.server.num.snapshots.retained</name>
    <name>ozone.om.group.rights</name>
    <name>ozone.om.user.rights</name>
    <name>scm.container.client.idle.threshold</name>
    <name>scm.container.client.max.outstanding.requests</name>
    <name>scm.container.client.max.size</name>

CSI and SCM configs are missing, but I think that's because Ozone FS does not depend on CSI and depends on SCM only with test scope.

/label ozone

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
82
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1
mvninstall
30
hadoop-hdds in trunk failed.

-1
mvninstall
32
hadoop-ozone in trunk failed.

-1
compile
18
hadoop-hdds in trunk failed.

-1
compile
13
hadoop-ozone in trunk failed.

+1
mvnsite
0
trunk passed

+1
shadedclient
969
branch has no errors when building and testing our client artifacts.

-1
javadoc
20
hadoop-hdds in trunk failed.

-1
javadoc
18
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

-1
mvninstall
35
hadoop-hdds in the patch failed.

-1
mvninstall
40
hadoop-ozone in the patch failed.

-1
compile
22
hadoop-hdds in the patch failed.

-1
compile
16
hadoop-ozone in the patch failed.

-1
javac
22
hadoop-hdds in the patch failed.

-1
javac
16
hadoop-ozone in the patch failed.

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
811
patch has no errors when building and testing our client artifacts.

-1
javadoc
18
hadoop-hdds in the patch failed.

-1
javadoc
16
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
25
hadoop-hdds in the patch failed.

-1
unit
21
hadoop-ozone in the patch failed.

+1
asflicense
29
The patch does not generate ASF License warnings.

2272

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1597

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml

uname
Linux 03569846e5a9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6171a41

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/branch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/branch-javadoc-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-javadoc-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/testReport/

Max. process+thread count
306 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozonefs-lib-current U: hadoop-ozone/ozonefs-lib-current

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1
mvninstall
38
hadoop-hdds in trunk failed.

-1
mvninstall
36
hadoop-ozone in trunk failed.

-1
compile
18
hadoop-hdds in trunk failed.

-1
compile
13
hadoop-ozone in trunk failed.

+1
mvnsite
0
trunk passed

+1
shadedclient
974
branch has no errors when building and testing our client artifacts.

-1
javadoc
19
hadoop-hdds in trunk failed.

-1
javadoc
16
hadoop-ozone in trunk failed.

_ Patch Compile Tests _

-1
mvninstall
31
hadoop-hdds in the patch failed.

-1
mvninstall
34
hadoop-ozone in the patch failed.

-1
compile
22
hadoop-hdds in the patch failed.

-1
compile
14
hadoop-ozone in the patch failed.

-1
javac
22
hadoop-hdds in the patch failed.

-1
javac
14
hadoop-ozone in the patch failed.

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
xml
1
The patch has no ill-formed XML file.

+1
shadedclient
810
patch has no errors when building and testing our client artifacts.

-1
javadoc
19
hadoop-hdds in the patch failed.

-1
javadoc
17
hadoop-ozone in the patch failed.

_ Other Tests _

-1
unit
29
hadoop-hdds in the patch failed.

-1
unit
26
hadoop-ozone in the patch failed.

+1
asflicense
32
The patch does not generate ASF License warnings.

2227

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1597

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml

uname
Linux d86e32ee678d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / f826420

Default Java
1.8.0_222

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/branch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/branch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/branch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/branch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/branch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/branch-javadoc-hadoop-ozone.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-mvninstall-hadoop-hdds.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-mvninstall-hadoop-ozone.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-compile-hadoop-hdds.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-compile-hadoop-ozone.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-compile-hadoop-hdds.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-compile-hadoop-ozone.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-javadoc-hadoop-hdds.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-javadoc-hadoop-ozone.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-unit-hadoop-hdds.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/testReport/

Max. process+thread count
305 (vs. ulimit of 5500)

modules
C: hadoop-ozone/ozonefs-lib-current U: hadoop-ozone/ozonefs-lib-current

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1597/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

+1 thank you very much the fix. And the continuous work to resolve all the acceptance test failures.

Thanks @elek for help in finding the root cause.


Setup 'smartypants' (SmartOS/Illumos) node

This one is going to be tricky.

This is currently blocked on figuring out IPv6 support on Illumos.

Done! This is now known as 'uzone'


Lab 2 & 3.1

Nice work for Lab03!
You may call your lowercase functions to test out the results.
Well done!


Forseti Release 2.24.3

Fixes for model creation.

Release has been created, pending website and Terraform PRs:

https://github.com/forseti-security/forseti-security/pull/3788
https://github.com/forseti-security/terraform-google-forseti/pull/599


[lc_ctrl] Add CSR for switching to an external clock source

This makes the switch to an external clock source configurable through the CSRs and LC TAP. It is similar to the additional vendor-specific OTP test CSR that can be used to switch to external VPP in certain life cycle states.
Note that the external clock option is only available in RAW, TEST* and RMA, but not in the production states PROD* and DEV.

CC @arnonsha @zi-v


Define a Saga builder to query AggregateRef contents to another microservices

[TODO]
async def event_handler(saga_manager: SagaManager, event: Event):

    async def _fn(context: SagaContext):
        products = context["products"]
        ticket = context["ticket"]

        diff = context["diff"]
        diff.products= products
        diff.ticket = ticket

        await OrderQueryService().order_created(diff)

    saga = (
        Saga("OrderCreated")
        .step()
        .invoke_participant("GetProducts", lambda c: c)
        .on_reply("products")
        .step()
        .invoke_participant("GetTicket", lambda c: c)
        .on_reply("ticket")
        .commit(_fn)
    )

    await saga_manager.run(saga, SagaContext(event))

As this issue is closely related to #4, I decided to close this one and resolve all of them in a single issue


esp_http_client_set_url() parse failure (IDFGH-12440)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
http://croonerradio_classicgold.ice.infomaniak.ch/croonerradio-classicgold-midfi.mp3 URL fails on esp_http_client_set_url()
with ESP_ERR_INVALID_ARG. However, it is a valid URL.

Similar issue with https://amorfm_192.streampartner.nl/stream

Hello @espradio
http_parser does not support "_" i.e underscore character in host name part of the URL by default. This is the reason you are getting the error while calling esp_http_client_set_url() API for setting the URL. You can enable by adding the following in project's top level CMakeList.txt:
idf_component_get_property(http_parser http_parser COMPONENT_LIB)
target_compile_definitions(${http_parser} PRIVATE "-DHTTP_PARSER_STRICT=0")

Hope it helps.

Closing this issue. Please feel free to reopen if the issue persists.

@hmalpani Thanks it works.


Info badge

Info tokens are not defined for the badge component but are an existing variant in the figma component.
### Tasks
- [ ] add info tokens
- [x] make info badge available in storybook

While you're working on the tokens for the badge maybe also look at the primary tag in dark mode for SL? Because that doesn't really work very well:

For Magister and My Vanin the padding/radius tokens appear to be missing:


briar-desktop: use tor binary shipped by upstream

Description of changes
The current version of this package replaced the tor binary shipped with briar-desktop with the system tor binary because the upstream binary does not work. ldd reports a broken dependency on libzstd. Instead of using this kind of workaround, I'm suggesting to just add zstd as a dependency to this package.
Things done
I'm a beginner with NixOS so I haven't been able to verify my changes actually work. Would appreciate if this could be tested by a more experienced person.
List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions
-->

For reference, the system tor package also does depend on zstd and ldd reports that it can be resolved for that successfully: https://github.com/NixOS/nixpkgs/blob/adcbabfac262e3adbfe868ec7be20ab816c56c59/pkgs/tools/security/tor/default.nix

Is there a difference between using the upstream Tor binary and the one provided by NixOS? Just for understanding what are the pros/cons

and another pro would be that as far as I can tell the workaround with replacing the tor binary is not working (we changed the way to is packaged recently and hence the code related to unpacking the binaries from archives inside the jar is no longer valid. the binaries are now directly packaged within subdirectories of the jar file)

Our next release will most likely include a tor binary that no longer depends on zstd by the way. Adding some kind of workaround for this version however still seems to make sense to me.

Just got around to trying my changes on a NixOS live CD. I cloned this repository and then ran nix-build -A briar-desktop. Afterwards I can run ./result/bin/briar-desktop -v, however briar-desktop cannot run the Tor executable that we ship with the app. I didn't know about this, but apparently it's not trivial at all to run arbitrary binaries on NixOS! No idea how to move forward with this. @onny if you've got any idea that would be very useful. (Btw. I also tried a new Tor binary we just compiled that does no longer require zstd. However the whole problem of not being able to run the executable seems not to have anything to do with the dependency on zstd).

I could check on how to patch the binary properly, should be possible to solve with tools in nixpkgs

I could check on how to patch the binary properly, should be possible to solve with tools in nixpkgs

Cool, thanks a lot!


Smite Evil Deflection Bonus Not Applying

The Paladin Smite Evil ability does not appear to be applying the deflection bonus to AC to the Paladin against the creature to which the Smite Evil was applied. The bonus does seem to apply when the mod is disabled.
To Reproduce
Steps to reproduce the behavior:

Apply Smite Evil to an evil creature
Allow creature to hit character that applied the Smite Evil
Note the combat log does not include the "Smite Evil" deflection bonus to AC
Check the Buffs for the evil creature and note a single "Smite Evil" buff
Check the 'See All' while searching for "smite" for the evil creature and note that only "SmiteEvilBuff" is applied

Steps to show which buffs are applied when Toy Box is disabled:

Launch the game and load a save with Toy Box disabled
Enter combat and apply Smite Evil against an evil enemy
Allow the enemy to the hit the Paladin that applied the Smite Evil
Note the combat log includes the "Smite Evil" deflection bonus to AC
Check the Buffs for the evil creature and note that two "Smite Evil" buffs are applied to it
Check the Show All when selecting the evil enemy and searching for "smite" and note the "SmiteEvilBuff" and "SmiteEvilBuff_NoScabbard" are applied

Expected behavior
The Deflection bonus from Smite Evil is applied to the Paladin when attacked by the evil creature to which the Smite Evil was applied.
Screenshots

Settings
Settings.zip
Version Info:

ToyBox Version: 1.4.25
OS: Windows 10
Version: 22H2

Fixed in 1.4.26 which may be reversioned to 1.5.0

https://github.com/cabarius/ToyBox/commit/d00c5bdb2fb8b556969312b676adf55aff8e1ca9


QBFT Bonsai 24.3.3 private network halted

Description
Hi guys, we have a production private QBFT PoA network running Besu 24.3.3 that halted this week. The network architecture is:

4 RPC Bonsai Full nodes
1 Archive Forest Full node
4 Validator Bonsai Full nodes
Other 4 RPC Bonsai Full nodes, that act as “standby validators”.

The nodes are distributed in different AZs and regions. We have each validator in one AZ, two of them in one region and the other two in another. It’s the same for “standby validators” and RPC node.
This week, the network just halted. The validators, which were in INFO log level, stopped producing blocks with no error message, and even stopped logging anything.
To quick recover from this, we manually restarted the 4 validators, bringing the network online again. Validator logs are attached.
The network was running for +- 4 months without any issues.
Something curious is that some RPC nodes came back, some not. We restarted 2 of the main RPC nodes, which applications connect, and they started to sync blocks, but the other 2 recovered themselves, without intervention.
But there’s still “standby validators” that we didn’t restart and are halted. We changed the log level of them to debug and trace but didn’t have much luck with the information. Both logs are attached as well.
One last important information is that near the time the network froze, we’re deploying an application contract to the network. Smart contract is solidity 0.8.24 version, with hardhat.
This contract was deployed before in one of our development/QA networks without any issues, and after the crash of the network and the restart, we’re able to deploy it to the network, but it’s the major event that happened near the crash time besides the “business as usual” load in other contracts. The applications were running as usual among this deploy.
Our guess here is maybe the deploy triggered a bug, or it could be a bug alone in the 24.3.3. We already planning to upgrade to 24.9.1, but we would like to share this case with the community because this could be a bug, and we’re afraid it could be something related to Bonsai and QBFT.
Thank you
Steps to Reproduce
We’re unable to reproduce the issue in our test/QA environments. We have a QA network running for about the same time with no issues.
Versions

Software Version: Besu 24.3.3
Docker image: official hyperledger/besu:24.3.3, arm image
AWS EKS: 1.29
EC2: m6g.xlarge

Smart contract information

Solidity version: 0.8.24
ethers v6
hardhat 2.22.3

Additional information

Besu setup info:
Requests: CPU: 500m, memory: 3Gi
Limits: CPU: 4 core, memory 8Gi
besu-validator-7-0_besu-validator-7.log

Do you have the debug RPC enabled? If so can use the debug_getBadBlocks to retrieve any bad blocks?

Hi @jframe, we have DEBUG enabled, I ran against a still failed node (validator 7, which is still frozen, generating no logs but with rpc port open) and one active validator, validator-1. Validator 7 didn't return anything, but validator 1 returned lots of info. Both follows attached.
validator-7-debug-getbadblocks.txt
validator-1-debug-getbadblocks.txt

@matthew1001 we think this is a P3, what do you think?


migration:fix logic error in continous_migration

When last bunch of records added to mirror table have errors, migrate_from_mirror won't run

Supersede by #357

I cannot reproduce the issue, hence I'll not include it in my PR


Enhancement [sticky tabs]: Top nav and tabs stacking behavior

Mike provided below assets describing Tab's stacking behavior. Digital's site is consistent with this, and we should aim to build it in, if not this release, potentially shortly afterwards.

See full res videos of above:
https://ibm.box.com/s/np46yjxa0xa5je1ifqkbh2bigxfhevjo
Sketchfile: https://ibm.box.com/s/yshar9cm6tnbr8zdzjrwvstihf0anhjq

How will this work with more than two tabs? I think this page is the worst on mobile currently https://www.carbondesignsystem.com/getting-started/developers/vanilla

@jeanservaas makes sense, thanks!
They don't do that on the site currently because they aren't using the tab component, they aren't technically tabs, they are links to new pages. 😉

Sorry @alisonjoseph -- i realized that I massively needed to provide you a visual on that one. It's an outlier because the banner tabs don't really function like the experimental tab component in that it spans full screen... so it got a little weird at the tablet breakpoint and @shixiedesign and I had to look at it.
sketch file: https://ibm.box.com/s/tmtrrtphiio2g7duvb4uwchbvjd6h8z6

@jeanservaas and @shixiedesign are we going to stick with smaller ones (like current next.carbon) and go upt to three tabs before going to the dropdown. I think it looks good being smaller versus the 50/50. What do you all think?

@lovemecomputer
After mike saw the stacking spec, he wanted a slight pivot in the design... he did not want us to go to 50% of the screen with two tabs at mobile anymore.

[ ] Two banner tabs will not go 50/50 on the screen at mobile anymore but will stay as they are now on the carbon site

[ ] Our tab component (the in-page component seen on the motion page) the uses a minimum width to make tabs all equal width if they are under a certain character count; it would be nice to do something like this with our banner tabs as well (or add some light JS)

[ ] blue highlight is 3px tall (not 2px)

[ ] at 3 or more banner tabs, they will revert to full screen dropdown in mobile

Here are the updated responsive design specs for the banner tabs:
Two tabs

2 tabs at Desktop

2 tabs at Tablet

2 tabs at Mobile

Three or more tabs
3 tabs at Desktop

3 tabs at Tablet

3+ tabs at Mobile

Color specs for dark theme dropdown (gulp)

(can also get you exact tokens if you need)

currently finishing implementation of this in:

https://github.com/carbon-design-system/carbon-website/issues/578#issuecomment-486315185
https://github.com/carbon-design-system/carbon-website/issues/1518

wonder if stalebot shouldn't make issues stale if PRs and issues are referencing them?

not stale

yes, not stale and has different design specs that I thought @jeanservaas already updated but it looks like this has not. Jeannie did you do this or do we need to do this now. I can have Sadek do this if you’re tapped.

@alisonjoseph @vpicone @jeanservaas @shixiedesign
This should not be stale or it should be moved to Gatsby theme. The sticky behavior for desktop and mobile seems to be right but the width of tabs in mobile are too wide. They need to follow the DL mobile specs and have added pattern of horizontal scrolling in mobile. This should be added into Gatsby them to get this done and I believe @jeanservaas spec’d this out?

did this issue move to Gatsby issues? The tabs should scroll horizontally if more than 3. I think Jeannie spec’d this somewhere? @jeanservaas


security_groups Unable to change！！！

kubevirt version：0.58.0
I created two new security groups and created a new vm，but I found that changing the security group of one vm to another did not take effect. The policy is based on the original security group and takes effect only after the vm is restarted。
Is there a good solution to this problem？？

@wenjunGU I think security group are a AWS concept, am I right. If so, do you know how this translate into k8s features? If this is related to the pod, then probably the part is immutable or there isn't an update mechanism and update takes place when the virt-launcher pod is recreated.
More then a bug, I think this is a feature request.

@alicefr It seems that I have solved this problem, the solution is that VM, VMI, and POD must be changed together to ensure transactional consistency. This isn't really a BUG, it should be a feature


Feature: Apply Undo/Redo operation to the operator stream

Current ImageLab works with an operator pipeline to do the image processing tasks. If a user mistakenly adds an unwanted operator, he/she has to reset the whole pipeline. But, the feature Undo/Redo operation enables users to recover that action and go to the previous state. In order to do that task, DashboardControlller should be improved accordingly.

Hii @SahanDisa I would like to work on this issue. Can you assign this to me?

Hello, @kaveeshadinamidu please go ahead.

@SahanDisa I have implemented the feature successfully. Do I need to write test cases for the undo/redo operations?


Devel

use lookup table, more benchmarks for overlaps

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 95.346%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
840

Relevant Lines:
881

💛  - Coveralls


really fix date

the lines
https://github.com/aaronpeikert/reproducible-research/blob/1b582b96290bc1cafbee6de2a94f6d788ea9fc71/Dockerfile#L3-L8
close #49
the specific date:
https://github.com/aaronpeikert/reproducible-research/blob/1b582b96290bc1cafbee6de2a94f6d788ea9fc71/Dockerfile#L2
closes #48

See this as a suggestions, not sure this is the best way.


Missing note

Hi Team,
I think we are missing a note.
It could sound like:
All routing methods are routing calls to the agent regardless if the Agent(s) is currently in a call or not.
Even with presence-based routing a second call will be offered if the agent is setting the status manually to available.
Kind Regards
Alfred Masing
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b755d9ae-13ac-019f-f5f4-a95b1eee2989
Version Independent ID: f7afd8ad-e6e0-6c79-aed1-4ee87d48ba12
Content: Create a call queue in Microsoft Teams - Microsoft Teams
Content Source: Teams/create-a-phone-system-call-queue.md
Service: msteams
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.


Add support for identity-based endpoint configuration

Add identity-based endpoint parsing in Serverless SDK
Add identity-based endpoint parsing in Server SDK

Azure SDK team does not recommend to parse TokenCredential from Configuration. A ServiceEndpoint constructor accepts TokenCredential is enough.


pythonPackages.fastparquet: 0.6.3 -> 0.7.0

https://github.com/dask/fastparquet/compare/0.6.3...0.7.0
Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@grahamcofborg build python3.pkgs.datashader

(also no new failures macos 10.15)


AMBARI-24667 JS errors during adding hosts

How was this patch tested?
21818 passing (34s)
48 pending

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4027/
Test PASSed.


[android] No devices found when scanning due to Location Services being turned off.

If location services are turned off, the example app will act as if no devices are nearby, and show an empty list when scanning.
Location services must be enabled like so:

The plugin should report back a Platform error stating that Location services must be enabled.

Thanks for the info, it's working for me.
Is there any other solution than activating the gps?

Then there is a solution only in demonstrating to the user a message about the need to turn on the gps ?
@FavazCL Did you find any other options?


Distant NPCs don't spawn when getting closer with ViaVersion

Describe the bug
NPCs spawned outside of the players' rendering distance will not appear once the player gets closer to the NPC's location if the server is using ViaVersion.
NPCLib usage option
Shaded Maven dependency for npclib-plugin
Server version
This server is running Paper version git-Paper-1618 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)
To Reproduce
With a 1.12.2 server running ViaVersion and a 1.16.5 client:

Spawn an NPC far away from the player, far enough that it doesn't / wouldn't render anyway.
In-game, get closer to the NPC
The NPC never spawns (and the NPCShowEvent is never triggered).

Calling npc.show(player) manually after the player is close enough makes the NPC appear (although it's interact event doesn't trigger either ??).
Expected behavior
The NPC should spawn normally once in render distance, and it's interact event should work as intended.
It does work as intended when the client is running 1.12.2 too.

This seems to be connected to #124. Something is fundamentally wrong with the spawning mechanism. I want to use the chuck request packets supported from 1.9 and forward, but then I have to drop 1.8 support, which would be a bummer...
I'll keep this in mind. Thanks for opening this issue ticket.

It might be related, although in my case the Hologram doesn't spawn either, and isShown(p) returns false (which makes sense so long the NPC is out of render distance)..
Anyway, thanks for taking a look at this!


Revisions in README.md

Coherence & Sentence structures
Grammar and spelling

@Parva9eh thanks!

@vincentngo Thanks.


Java servlet store broken with Rails 5.1 and Tomcat 7

I am trying to set up my rails app to use :java_servlet_store in place of :cookie_store for my session store.
Rails throws undefined method 'get_header' for Rack::Handler::Servlet::DefaultEnv being thrown when adding the following configuration:
if defined?($servlet_context)
  require 'action_controller/session/java_servlet_store'
  # tell rails to use the java container's session store
  Rails.application.config.session_store :java_servlet_store
else
  Rails.application.config.session_store :cookie_store, key: '_servicesdirectory_session'
end

Full backtrace:
Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: I, [2017-08-11T19:47:14.637448 #1]  INFO -- : [150177b8-e353-437b-b893-a951d7029046] Started GET "/jruby-rails-tomcat-sample/" for <IP_ADDRESS> at 2017-08-11 19:47:14 +0000

Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: I, [2017-08-11T19:47:14.736209 #1]  INFO -- : [150177b8-e353-437b-b893-a951d7029046] Processing by MessagesController#index as HTML

Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: I, [2017-08-11T19:47:14.826652 #1]  INFO -- : [150177b8-e353-437b-b893-a951d7029046] Completed 500 Internal Server Error in 80ms

Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: F, [2017-08-11T19:47:14.844744 #1] FATAL -- : [150177b8-e353-437b-b893-a951d7029046]

Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: F, [2017-08-11T19:47:14.846148 #1] FATAL -- : [150177b8-e353-437b-b893-a951d7029046] NoMethodError (undefined method `get_header' for #<Rack::Handler::Servlet::DefaultEnv:0x39f27856>):

Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: F, [2017-08-11T19:47:14.846964 #1] FATAL -- : [150177b8-e353-437b-b893-a951d7029046]

Aug 11, 2017 7:47:14 PM org.apache.catalina.core.ApplicationContext log
INFO: F, [2017-08-11T19:47:14.847805 #1] FATAL -- : [150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:295:in `current_session_id'
[150177b8-e353-437b-b893-a951d7029046] uri:classloader:/jruby/rack/session_store.rb:162:in `session_exists?'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:124:in `exists?'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:149:in `load_for_read!'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:56:in `[]'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/turbolinks-5.0.1/lib/turbolinks/redirection.rb:43:in `set_turbolinks_location_header_from_session'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:413:in `block in make_lambda'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:197:in `block in halting'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/abstract_controller/callbacks.rb:12:in `block in Callbacks'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:198:in `block in halting'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:507:in `block in invoke_before'
[150177b8-e353-437b-b893-a951d7029046] org/jruby/RubyArray.java:1734:in `each'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:507:in `invoke_before'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:130:in `run_callbacks'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/abstract_controller/callbacks.rb:19:in `process_action'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_controller/metal/rescue.rb:20:in `process_action'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/notifications.rb:166:in `block in instrument'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/notifications.rb:166:in `instrument'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_controller/metal/params_wrapper.rb:252:in `process_action'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activerecord-5.1.3/lib/active_record/railties/controller_runtime.rb:22:in `process_action'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/abstract_controller/base.rb:124:in `process'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionview-5.1.3/lib/action_view/rendering.rb:30:in `process'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_controller/metal.rb:189:in `dispatch'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_controller/metal.rb:253:in `dispatch'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/routing/route_set.rb:31:in `serve'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/journey/router.rb:46:in `block in serve'
[150177b8-e353-437b-b893-a951d7029046] org/jruby/RubyArray.java:1734:in `each'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/journey/router.rb:33:in `serve'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/routing/route_set.rb:834:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/etag.rb:25:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/conditional_get.rb:25:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/head.rb:12:in `call'
[150177b8-e353-437b-b893-a951d7029046] uri:classloader:/jruby/rack/session_store.rb:79:in `context'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/session/abstract/id.rb:226:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/cookies.rb:613:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/callbacks.rb:26:in `block in call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/callbacks.rb:97:in `run_callbacks'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/callbacks.rb:24:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/debug_exceptions.rb:59:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/railties-5.1.3/lib/rails/rack/logger.rb:36:in `call_app'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/railties-5.1.3/lib/rails/rack/logger.rb:24:in `block in call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/tagged_logging.rb:69:in `block in tagged'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/tagged_logging.rb:26:in `tagged'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/tagged_logging.rb:69:in `tagged'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/railties-5.1.3/lib/rails/rack/logger.rb:24:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/remote_ip.rb:79:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/request_id.rb:25:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/method_override.rb:22:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/runtime.rb:22:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/activesupport-5.1.3/lib/active_support/cache/strategy/local_cache_middleware.rb:27:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/actionpack-5.1.3/lib/action_dispatch/middleware/executor.rb:12:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/rack-2.0.3/lib/rack/sendfile.rb:111:in `call'
[150177b8-e353-437b-b893-a951d7029046] gems/gems/railties-5.1.3/lib/rails/engine.rb:522:in `call'
[150177b8-e353-437b-b893-a951d7029046] uri:classloader:/rack/handler/servlet.rb:22:in `call'

Adding the configuration above to my sample app shows this happens with a new rails app.
I also posted in SO.
https://stackoverflow.com/questions/45594295/undefined-method-get-header-for-rackhandlerservletdefaultenv
Thanks in advance for your help!

yes, unfortunately jruby-rack is behind. we pbly only officially supported Rails <= 4.2 its mostly luck that nothing broke with 5.0. Rack's 2.0 changes also should get reviewed for this. unfortunately were low on maintainers...

Ah OK, I see. If you can point me in the right direction in tackling this I
would be happy to help out.
On Aug 12, 2017 4:05 AM, "Karol Bucek"<EMAIL_ADDRESS>wrote:
yes, unfortunately jruby-rack is behind. we pbly only officially supported
Rails <= 4.2 its mostly luck that nothing broke with 5.0. Rack's 2.0
changes also should get reviewed for this. unfortunately were low on
maintainers...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jruby/jruby-rack/issues/211#issuecomment-321965273,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGJa90AHk5QenDWYk3mO810LZ02hvoC_ks5sXVzXgaJpZM4O1E8R
.

honestly did you try :) ? its not that hard to find, start here and find yourself around ...
... also backwards-compatibility is important if you want it in 1.1.x (1.1-stable branch)

No, I haven't had a chance to look into it yet. I may have some time this
week to take a look.
Thanks!
Kevin McCormack
Full Stack Web Developer
HarlemSquirrel.github.io
On Aug 12, 2017 10:44 AM, "Karol Bucek"<EMAIL_ADDRESS>wrote:

honestly did you try :) ? its not that hard to find, start here
https://github.com/jruby/jruby-rack/blob/1.1-stable/src/main/ruby/action_dispatch/session/java_servlet_store.rb#L12
and find yourself around ...
... also backwards-compatibility is important if you want it in 1.1.x
(1.1-stable branch)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jruby/jruby-rack/issues/211#issuecomment-321985645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGJa907222fcg3MVS4DSkGeCWn2K84fvks5sXbpKgaJpZM4O1E8R
.


Unknown Message ID when connecting to server.

Describe the bug
Throws:
Unknown message ID 55829 connId:0
Unknown message ID 30259 connId:0
After connecting to the server.
Desktop:

OS: Windows, MacOS
Build target: Standalone
Unity version: 2019.2,0f1
Mirror branch: Latest package from Release

Not enough information provided.  Please join our Discord for assistance.

I corrected this error by using NetworkManager.singleton.StartServer and NetworkManager.singleton.StartClient instead of NetworkServer.Listen and NetworkClient.Connect


Improve BaseReducer

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (c6771b4) to head (b92ae03).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #505   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           58        58
  Lines         1593      1615   +22
  Branches       188       191    +3
=========================================
+ Hits          1593      1615   +22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


maxHeight incorrectly includes margins in the calculation

When a node has both a max height and a vertical margin, it appears that Yoga incorrectly considers the margins to take up part of the max height.
Repro Steps
Here's some HTML representing a case that repros the bug:

Here's the equivalent C code:
  const YGNodeRef root = YGNodeNew();
  YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
  YGNodeStyleSetWidth(root, 250);
  YGNodeStyleSetHeight(root, 250);

  const YGNodeRef root_child0 = YGNodeNew();
  YGNodeStyleSetWidth(root_child0, 100);
  YGNodeStyleSetHeight(root_child0, 100);
  YGNodeStyleSetMaxHeight(root_child0, 100);
  YGNodeStyleSetMargin(root_child0, YGEdgeTop, 20);
  YGNodeInsertChild(root, root_child0, 0);

  YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
  YGNodePrint(root, YGPrintOptionsLayout | YGPrintOptionsChildren);

Expected Output
Child's height is 100:
{layout: {width: 250, height: 250, top: 0, left: 0}, children: [
  {layout: {width: 100, height: 100, top: 20, left: 0}, },
]},

This JSFiddle illustrates the expected behavior: https://jsfiddle.net/4mr6tbqq/
Actual Output
Child's height is 80:
{layout: {width: 250, height: 250, top: 0, left: 0}, children: [
  {layout: {width: 100, height: 80, top: 20, left: 0}, },
]},

I got this, fix is coming in a few minutes.

@woehrl01 Thanks for the quick turnaround!


Add transforms.tools

Pull Request Template
Please ensure all items below are checked before creating a pull request:

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] I have searched the repository for any relevant issues or pull requests
[x] All changes have been squashed into a single commit

Approved and merged. Thanks!


save_to_file fails if directory does not exist on Windows

Not really a significant issue, but can add a check if a file_path directory exists and mkdir otherwise...
def save_to_file(self,
                 file_path,
                 labels=None,
                 predict_proba=True,
                 show_predicted_value=True,
                 **kwargs):
    """Saves html explanation to file. .

    Params:
        file_path: file to save explanations to

    See as_html() for additional parameters.

    """

    if not os.path.exists(os.path.dirname(file_path)):
        try:
            os.makedirs(os.path.dirname(file_path))
        except OSError as exc:
            if exc.errno != errno.EEXIST:
                raise

    file_ = open(file_path, 'w', encoding='utf8')
    file_.write(self.as_html(labels=labels,
                             predict_proba=predict_proba,
                             show_predicted_value=show_predicted_value,
                             **kwargs))
    file_.close()

I am not sure I want to create a directory for the user if the one provided doesn't exist. I guess I could go either way.
In the interest of simplicity, I think I'll leave it as is : )
Thanks,