Page Attachment as linked content

Summary
Adds the Page Attachment features as linked content.

Relevant Technical Choices

To-do

[x] Needs UX for the general behavior in case a link ends up in an invalid position.

[x] UX adjustments for the editor

[x] Add "default" suffix to Learn more

[x] Behavior when there is a linked element

[x] Refactor code a bit

[ ] Disable links for output that are in the Page Attachment area.

[ ] Tests (Need update post-UX change)

User-facing changes
There is a new Page Attachment panel which the user can add while Page/background is selected.
The moment when the user adds a URL, the Page Attachment gets added.

Testing Instructions
I

Open a Page
Add a URL to the Page Attachment
Verify that if you add incorrect URL format (e.g. with a space inside), a warning is displayed

II

Open a Page
Add a URL to the Page Attachment
Verify that "Learn more" appears in the bottom of the page
Change the "Learn more" to something else.
Verify that it also changed on the Page.
Verify that removing the CTA Text will restore the default "Learn more"
Verify that the Page Attachment is also displayed in the Front-end and with the correct CTA Text.

III

Open a Page
Add a URL to the Page Attachment
Add a Shape, add a link to the Shape
Try dragging/resizing and rotating the link so that part of the element is near the bottom -- where the "Learn more" is displayed.
Verify that after finishing with the transformation, a dashed line appears with a tooltip on the left saying that links can't be below the dashed line with Page Attachment.

IV

Open a Page
Add a URL to the Page Attachment
Add 3 elements, add link to one of these elements
Select all 3 elements
Drag/resize/rotate the elements so that the linked element is positioned near the "Learn more" text.
Verify again the same dashed line with the tooltip.

V

Add a shape with link
Move the shape to the bottom area of the page
Now click on the Page and click on the Page Attachment input without typing anything.
Verify that the dashed line is displayed again and a warning message appears explaining that links of the elements below the dashed line won't be clickable in case of adding Page Attachment.
Add a Page Attachment URL, save the story and verify that the link is not clickable indeed.

VI

Add a Page Attachment
Create a shape and move it to the Page Attachment area.
Focus on the link field of the Shape element.
Verify that a warning appears when focusing on the link input and the dashed line is displayed.
Verify that it's not possible to fill in the link field.

Fixes #254

@wassgha Thank you for the feedback, all the points should be addressed now, PTAL.

Thanks! I've reached out to Sam to clarify about the invalid link case, the rest of the comments have been addressed.

Invalid link behavior for page attachment should be similar to the invalid case for regular links.

Figma

@barklund
The Page Attachment PR should be addressing everything else except for tests (need updating now after the change in UX) and most importantly -- disabling the links inside the Page Attachment area when creating the output.
I was looking into this a bit today to figure out what could be a good approach. Since the incorrectly positioned links will be in the Publishing Checklist anyway in the future then it seems that perhaps the best option would be related, for example:

Create a ChecklistProvider (currently including links only) which would keep track of the incorrectly positioned links (e.g. useElementsWithLinks could have an action registerInvalidLinks) and then while creating output, each element would be just checked against that and the links disabled if issue found. Then this checklist would be saved into story_data as well.

Some alternatives could be:

Adding a disabled param to the link object and then while creating output, the link would not be added if it's disabled, however, this would bring back the issue of disabling links in a bunch of different places, e.g. when moving to the area, when pasting a link, when moving using keyboards etc. so it doesn't seem to make sense.

Making the check while creating the output, however, this means that we should render all the pages somehow and check if there are matching areas (just calculating based on the position and width/height might get complicated due to rotation).

Since we'll need the checklist anyway then the first option seems to be the most reasonable.
(I started testing out the ChecklistProvider option but not enough to create a commit.)

@googlebot I consent.

@barklund @swissspidy If you have time, could you PTAL at this: 06031fd
Since the real update to the CTA text happened previously only onBlur then this didn't allow saving before onBlur had happened. This now uses a combination of locally kept _ctaText and debouncedCallback for allowing typing without lag + update the global ctaText in the background. Will send back to QA if it gets a 👍 from either of you.


Upgraded Ruby to 2.5.0

Upgraded Ruby to 2.5.0 from 2.4.3. (6 files)

Travis is Green

Replace TBD with CoC email before merging.


xonsh shell support

Hi! Thank you for the awesome tool!
Is there a way to use it with the shell i.e. with the python-powered xonsh shell?
Thanks!
For community
⬇  Please click the 👍 reaction instead of leaving a +1 or 👍  comment

xonsh might not be possible with the textual framework, but this would be very doable with textual-terminal.
Just curious, what would be your recommended UX? I was thinking something like the T keyboard binding that pops up a terminal window on the lower 50% of the screen


[FEATURE REQUEST] Ability to have inter-page linking

There is currently no ability to navigate to other pages of a report within a custom visual, which seems like a MAJOR missing feature. Why is there no ability to link to other elements of reports? Is it planned? If so when can we expect it?

We could use basic Anchor tags if we had the ability to specify report page URLs.

No, visuals executes inside iframe by security reasons

You don’t want to allow inter-page intra-report linking for “security reasons”? Visuals execute inside iframes for security reasons, sure, so why do you allow cross highlighting? Can you tell me what security threat linking to other pages within a report poses over cross highlighting?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Ilfat Galiev<EMAIL_ADDRESS>Sent: Tuesday, June 11, 2019 12:35:56 PM
To: microsoft/PowerBI-visuals-tools
Cc: Chris Schofield; Author
Subject: Re: [microsoft/PowerBI-visuals-tools] [FEATURE REQUEST] Ability to have inter-page linking (#270)
No, visuals executes inside iframe by security reasons
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerBI-visuals-tools/issues/270?email_source=notifications&email_token=AJSVR2RK64T5L32QWKKJQBLPZ55YZA5CNFSM4HW4ZLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXMWBZY#issuecomment-500785383, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSVR2UBHILKSIGI4XX6SLLPZ55YZANCNFSM4HW4ZLAA.

It's possible for custom visuals to communicate to each other through the APIs you provide. I am asking if you will include one that allows us to navigate a report properly.

For instance maybe a reportNavigationUtils that allows us to use a method to navigate to a report page based on index.

I mean, you can't manipulate with report elements from the visual, because visuals are inside iframe.
For cross highlighting visuals communicate with Visual API.
If you want to create a button in report to switch the report page, you can use buttons:

I will forward you question to Power BI Visual API developers (give similar API for visuals)
Or you can consider some hack workaround:
https://community.powerbi.com/t5/Desktop/How-to-Page-Navigation-in-Power-BI-Desktop/td-p/42737/page/2

Okay, so you are saying the Visuals API is capable of helping the other visuals communicate with each other. I am asking why there cannot be something similar to control the state of the report. What is it that you fear could happen as a consequence of being able to change report page? Ideally we are looking for an actual feature, not a hacky workaround. We cannot be the only people with these issues.
You could have it as a custom data type, part of capabilities.json, that allows the user to configure a page as a capability, allowing the visual no further information than the reference provided by the user. What would be the issue with that?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Ilfat Galiev<EMAIL_ADDRESS>Sent: Tuesday, June 11, 2019 1:32:37 PM
To: microsoft/PowerBI-visuals-tools
Cc: Chris Schofield; Author
Subject: Re: [microsoft/PowerBI-visuals-tools] [FEATURE REQUEST] Ability to have inter-page linking (#270)
I mean, you can't manipulate with report elements from the visual, because visuals are inside iframe.
For cross highlighting visuals communicate with Visual API.
If you want to create a button in report to switch the report page, you can use buttons:
[image]https://user-images.githubusercontent.com/10897951/59268247-f4941e00-8c54-11e9-865a-cb1712dad261.png
I will forward you question to Power BI Visual API developers (give similar API for visuals)
Or you can consider some hack workaround:
https://community.powerbi.com/t5/Desktop/How-to-Page-Navigation-in-Power-BI-Desktop/td-p/42737/page/2
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerBI-visuals-tools/issues/270?email_source=notifications&email_token=AJSVR2SJRIX4RE3PBVDJFYLPZ6ENLA5CNFSM4HW4ZLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXM2CPI#issuecomment-500801853, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSVR2VFSCHG2XPP4KBUENDPZ6ENLANCNFSM4HW4ZLAA.

Currently, API doesn't support the functionality. I will forward you question to Power BI Visual API developers. Thanks!

Thank you very much. Have a great day!
Get Outlook for iOShttps://aka.ms/o0ukef

From: Ilfat Galiev<EMAIL_ADDRESS>Sent: Tuesday, June 11, 2019 1:56:46 PM
To: microsoft/PowerBI-visuals-tools
Cc: Chris Schofield; Author
Subject: Re: [microsoft/PowerBI-visuals-tools] [FEATURE REQUEST] Ability to have inter-page linking (#270)
Currently, API doesn't support the functionality. I will forward you question to Power BI Visual API developers. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerBI-visuals-tools/issues/270?email_source=notifications&email_token=AJSVR2W5ZVDXYUQH3M5GSNTPZ6HH5A5CNFSM4HW4ZLAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXM3Z2Y#issuecomment-500808939, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJSVR2SE6TSU3D6LZ54UHQLPZ6HH5ANCNFSM4HW4ZLAA.


can I ask a question using the Brazilian Portuguese language?

Johannes, please, can I ask a question using the Brazilian Portuguese language?
Thanks

Sure, what would you like to know?

(trying in English ...)
Thanks for the chance.
I use AppLayoutRouterLayout and I need to put in a simple login form.
I created a method before init () and put it inside a modal Dialog with a login form.
I ask:
1 - how can I navigate to a welcome view, after authentication?
2 - is it possible to load an empty view as a default?
Thank you for your help and attention.
Hugs

Obrigado pela chance.
Uso AppLayoutRouterLayout e preciso colocar um formulario simples de login.
Criei um method antes do init() e coloquei dentro de um Dialog modal com um form login.
Pergunto:
1 - como posso navegar para uma view de boas vindas, depois da autenticação?
2 - é possível carregar uma view vazia como default?
Obrigado pela ajuda e pela atenção.
Abraços

@csilva2001 Access control is not being managed by this addon. This addon is only about the View Side of things. The following blog gives a good overview about this..
Also read some documentation about Vaadin Routes in general:

Router Layouts and Nested Router Targets

Navigating Between Routes

ok, I got it.
I'll see that link.
Thanks, hugs


On-Premise Connection

Hi Scott,
I am unable to connect to my Onpremise environment, it always give the Input invalid message. Can you please provide the steps to connect to on-premise environment.

Hello Scott,
I have the same problem.
Can you please help us.
There is a note saying "Note: Use /l switch for on-premises or legacy login"
What do you mean about that ?
Regards

Can you edit batch file to something like:
"%spkl_path%" /l earlybound "%cd%.." "AuthType=AD;Url=https://D365URL/XRMServices/2011/Organization.svc;Domain=DOMAIN;UserName=DOMAIN\USER;Password=***”
and give it a try?
I found that for spkl earlybound I need to specify the connection string, where for spkl plugins it runs fine if I run it (with /l) and select the connection.


README: How to use old subtitles db?

The program downloaded many subtitles. It took some time. But then i closed the terminal session. And now it does not appear to recognise the .db file in the current working path. Is there a way to specify the db file to use?

Possibility 1: you changed directories
The tool currently makes a database in the current working directory you run the tool. So if you download subtitles then open a new terminal in another directory it won't know where this previous database was. to fix this simply go back into the original directory and run yt-fts list and it should show your original db.
if you don't know where you originally ran the command you can try:
find ~ -type f -iname "subtitles.db"

important: when ever you run any command like list in a new directory it will create an empty database if no subtitles database is found
A fix to prevent this confusion has been proposed: "Save database and config files to user .config folder #26"
Possibility 2: session closed before db processing
If you closed the session before it showed this "adding to database" loading screen then they were unfortunately deleted before they cold be saved to the database.

Possibility 3: version conflicts
What version are you running? check with yt-fts --version if you had a database saved before 0.1.16 the updated, the older databases might not be compatible.

I think it is possibility 2:

How would one check possibility 3?

I've settled on what I believe to be a "stable" schema for this project so hopefully, we'll avoid breaking existing
databases every update.
CREATE TABLE [Channels] (
   [channel_id] TEXT PRIMARY KEY,
   [channel_name] TEXT NOT NULL,
   [channel_url] TEXT NOT NULL
);
CREATE TABLE [Videos] (
   [video_id] TEXT PRIMARY KEY,
   [video_title] TEXT NOT NULL,
   [video_url] TEXT NOT NULL,
   [channel_id] TEXT REFERENCES [Channels]([channel_id])
);
CREATE TABLE [Subtitles] (
   [subtitle_id] INTEGER PRIMARY KEY,
   [video_id] TEXT REFERENCES [Videos]([video_id]),
   [start_time] TEXT NOT NULL,
   [stop_time] TEXT,
   [text] TEXT NOT NULL
);
CREATE VIRTUAL TABLE [Subtitles_fts] USING FTS5 (
    [text],
    content=[Subtitles]
)
CREATE TABLE [SemanticSearchEnabled] (
   [channel_id] TEXT REFERENCES [Channels]([channel_id])
);


Revert "Revert "[WIP] Adaptor config in a new table""

Reverts ecmwf-projects/cads-broker#69

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


The favicon is a skull

Consider replacing the default favicon from the Skeleton UI toolkit.

Consider it done.
static/favicon


Output sender in JSON port

In a situation where multiple connections are made to a single JSON port there is no way to identify which connector sent the data.
Please allow the output of the sender in the JSON port.

Added a new feature for JSONPort to print event Sender. e561fbb632848378087578029d4e93c30d5f7e24
Cheers,
Neil


throwing the error while running the model

Hi i have been implementing the bert cpp but i am facing the following error
OSError: dlopen(examples/../build/libbert.so, 0x0006): tried: 'examples/../build/libbert.so' (no such file), '/System/Volumes/Preboot/Cryptexes/OSexamples/../build/libbert.so' (no such file), '/usr/lib/examples/../build/libbert.so' (no such file, not in dyld cache), 'examples/../build/libbert.so' (no such file), '/Users/compl-558jasheen/Downloads/bert.cpp-master/build/libbert.so' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/compl-558jasheen/Downloads/bert.cpp-master/build/libbert.so' (no such file), '/Users/compl-558jasheen/Downloads/bert.cpp-master/build/libbert.so' (no such file)
Exception ignored in: <function BertModel.del at 0x7f95006a8b80>
Traceback (most recent call last):
File "examples/sample_dylib.py", line 40, in del
self.lib.bert_free(self.ctx)
AttributeError: 'BertModel' object has no attribute 'lib'
From the error i can understand that the file is missing i have done same procedure for installing the bert.cpp as mention can you please help me .
Thanks
Jasheen shaik

same issue


Move resource may result downtime or not?

Move resource may result in downtime statement contradicts with information on Azure resource move page (given link), that in its turn says that there is no downtime but only lock for 4 hours. Which page is correct?
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6aef944e-c3da-70b4-47c4-9c45447d0a3c
Version Independent ID: 4fb9a899-cf9f-43dd-334a-f202e3b75067
Content: Transfer Azure subscriptions between subscribers and CSPs
Content Source: articles/cost-management-billing/manage/transfer-subscriptions-subscribers-csp.md
Service: cost-management-billing
GitHub Login: @bandersmsft
Microsoft Alias: banders

@dfatkulbayanova Thanks for the feedback! We are currently investigating and will update you shortly.

Hello @dfatkulbayanova ,
Both statements/pages are correct. Let me clarify...
In this doc, the statement reads:

this simply means there are a subset of Azure Resources  that require downtime or have special move requirements + limitations.

The 4 hour lock only applies to the source and destination resource groups involved in the move  - and not the underlying resources. By design, the lock is applied for a maximum of 4 hours to maintain integrity of the resource groups and ensure there are no updates to the resource group during the move. Here's an example:

There's also some useful content in the FAQ section

Hope this helps but happy to discuss further if needed
Cheers.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.
#please-close

Hi Femsulu,
Thanks for the clarification,
I understand that statement "may result in service downtime" means that
because of specific prerequisite move will require some post-move actions
to make service operational again.
But move itself is not causing downtime,only lock. It is a post or
pre-deployment action that will cause the downtime. Just highlighting it
because my customers panic when see the statement "move can result in
downtime" on one page and "move only locks" on another one. Do you think it
will be better to say that "move itself doesnt cause the downtime but some
services require post or pre configuration tasks before service become
operational again?". Like this there is no doubt in move process itself?
Regards,
Dina Fatkulbayanova
On Fri, 26 Jun 2020, 00:56 femsulu-MSFT<EMAIL_ADDRESS>wrote:

Hello @dfatkulbayanova https://github.com/dfatkulbayanova ,
Both statements/pages are correct. Let me clarify...
In this doc http://url, the statement reads:
[image: image]
https://user-images.githubusercontent.com/34327711/85800874-979bc680-b6f6-11ea-9eeb-97637e74a9ee.png
this simply means there are a subset of Azure Resources
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-resource-group-and-subscription#checklist-before-moving-resources
that require downtime or have special move requirements + limitations.
[image: image]
https://user-images.githubusercontent.com/34327711/85801267-6243a880-b6f7-11ea-9d1a-babf354e32ac.png
The 4 hour lock only applies to the source and destination resource
groups involved in the move - and not the underlying resources. By design,
the lock is applied for a maximum of 4 hours to maintain integrity of the
resource groups and ensure there are no updates to the resource group
during the move. Here's an example
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-resource-group-and-subscription#frequently-asked-questions
:
[image: image]
https://user-images.githubusercontent.com/34327711/85803052-31657280-b6fb-11ea-9250-fbfbd5c2d817.png
There's also some useful content in the FAQ section
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/move-resource-group-and-subscription#frequently-asked-questions
[image: image]
https://user-images.githubusercontent.com/34327711/85802017-e3e80600-b6f8-11ea-8bd5-89c4dfa8f37f.png
Hope this helps but happy to discuss further if needed
Cheers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/57466#issuecomment-649857864,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHO5QL2VGYET7YIYXUTBP43RYPI2TANCNFSM4OC5TACA
.

thanks for clarifying, Dina. If I understand correctly, you are proposing revising the statements in both pages to further explain the root cause of downtime (if any) during a move operation. Let me take this offline between you and the content owner to see how we can clarify these complimentary statements.
Stay tuned.


Markdown not parsing in descriptions and scripts

I just tested a couple markdown examples in the description and script and it doesn't look like they're parsing correctly to styled text.
Can you take a look @mccarron? Let me know if you need me to add test markdown to an older issue, I removed it from this issue after I tested.
Both of the screens below have text that has __test markdown__ which should be bold

Yeah we didn't add Markdown support yet just a pod that adds the ability to parse Markdown. You said the API didn't have Markdown yet so there wasn't anything to do. ;)
Can we get some Markdown onto a Staging/Test API to build this out?

I don't have a staging API for the main issues list (it's getting moved to a different server soon that already has a staging API) but I added some test markdown to an issue on the more issues list: "Protect the Right to Fight Workplace Sexual Harassment"
Let me know if that works OK.

Sure that'll work, I'll take a look at hooking this up either tomorrow or Sunday then.

🏓

Done!


Chrome exhibits dreadful performance when the id maps get populated

I've observed that when the id_to_refcount_map and id_to_ref_map get above 5000 items, performance of these maps in Chrome (even nightly) degrades massively, taking acquire_rust_reference from ~0.5ms per call to up to 20ms.
What this means is that if you have a lot of references that you aren't doing anything with, the rest of your program will become inexplicably slower at passing things to JS and back.
For example:
$ git clone https://github.com/aidanhs/slow-ref-stdweb-example.git
$ cd slow-ref-stdweb-example
$ cargo web start --target wasm32-unknown-unknown --release

This is a simple yew project with two buttons. The first, Test serialization, times how long it takes to send a largeish (2.4MB as JSON) struct from Rust to javascript by a) using a JSSerialize derive and b) converting to JSON, sending the string, and parsing it on the other end. If you click this button a few times, you'll see the numbers are within the same order of magnitude (output in the console).
Clicking the other button, Add elts, will get yew to add 14000 divs to the body of the document - as Yew keeps references to these, they'll be stored in the two maps mentioned above. If you do this in Chrome, and then use Test serialization again, you'll see that the JSSerialize approach is now ~20x slower than before!
This doesn't happen in Firefox so it's clearly something Chrome should fix (a better hashing function on their maps?), but I think it's worth tracking and being aware of as other people could be bitten. CC @DenisKolodin for awareness.

Do we consider it 'UB' to use a reference that has expired? Currently an ID that was used once will never be used again, so you'll just get undefined.
However if we were to allow ID reuse (sacrificing the consistent behaviour of returning undefined), we could use an array and reuse slots in it - my testing indicates that this is a significant amount faster, even for the normal case where there's nothing in the map.

On reflection, we could actually still use arrays to consistently return undefined by partitioning references into a 32bit index and 20bit 'generation' (max precise integer in JS is 2^53-1). When indexing into the array we then check the generation (which is stored alongside each entry) and return undefined if it's not equal.

Interesting; have you checked if anything changes if we'd replace the WeakMap for reference -> id mappings with a normal Map?

To be clear, the two problematic maps are the id_to_ ones - https://github.com/koute/stdweb/blob/39a9955/src/webcore/runtime.js#L288-L289, which use objects (changing to an actual Map didn't seem to help). The weakmap barely makes a difference.
Here are the results trying different changes in Chromium on Ubuntu 16.04. In each case I:

loaded the page
pressed Test serialization to give the JS engine a chance to warm up
pressed Test serialization three times to record the "before elts" columns
pressed Add elts
pressed Test serialization three times to record the "after elts" columns

Diff
JSON before elts
stdweb before elts
JSON after elts
stdweb after elts

(none)
96/175/114
147/156/159
191/124/118
4259/6409/3482

ref_to_id_map WeakMap->Map
95/127/114
140/127/129
126/120/110
2882/4912/5233

id_to_{ref,refcount}_map {}->Map
176/111/115
142/127/136
110/176/159
2799/4879/5562

id_to_{ref,refcount}_map {}->[]
140/113/175
153/133/134
141/97/98
161/184/129

(for my own reference I use this in the console to monitor the size of the maps: function abc() { var id_to_refcount_map = Module.STDWEB_PRIVATE.id_to_refcount_map; var id_to_ref_map = Module.STDWEB_PRIVATE.id_to_ref_map; var ref_to_id_map = Module.STDWEB_PRIVATE.ref_to_id_map; var ref_to_id_map_fallback = Module.STDWEB_PRIVATE.ref_to_id_map_fallback; console.log([id_to_refcount_map, id_to_ref_map].map(x => Object.keys(x).length), [ref_to_id_map, ref_to_id_map_fallback.size]) }; abc())

So, wouldn't a better solution be to fix #78?

@Pauan ah nice, I hadn't seen that. Yes, I think that's a better approach for the id_to_refcount_map, but it's only half the story. I added a couple more rows to my table to show the effect of only converting one of the maps to an array, and you can see that it's clearly an improvement but there's still an unpredictable performance cliff lurking in the other one.

Ah, nevermind, I spoke too soon, you're right that id_to_ref_map complicates things.
I wonder if we could just replace ref_to_id_map with a Map and then remove id_to_ref_map completely.


Update Getting-Started.md

In line 43 of this article, users are reminded to modify the 'MauiProgram.cs' content with two key lines missing. This will cause a subsequent error: material:ColorResource not found in xmlns http://schemas.enisn-projects.io/dotnet/maui/uraniumui/material

Thanks for you contribution, also configuring handlers isn't necessary when UseUraniumMaterial() is called


GROOVY-8586: Support Java 9 ARM blocks

72 hours have gone. I will merge it soon if no one has objections.


tests: fix fs tests run w/o full getdents support

fs_access, fs_async_dir and fs_symlink_dir could fail when the
filesystem where the tests are run does not fully support getting the
file type via getdents.  Having getdents support does not imply that the
underlying filesystem fully supports what is necessary for these tests
to have passed prior to this commit.  So the failing tests were updated
to check for UV_FILE as it did previously but it will also check for
UV_UNKNOWN as well to handle the filesystems that do not fully support
getting the file type via getdents.  For OS X and Windows, which are
known to fully support getting the file type, the tests work as they did
before and will not check for UV_UNKNOWN.  We could/should update the
preprocessor directive that chooses "vigorous" or "lax" checks
accordingly when we learn of new environments that should always do the
original "vigorous" checks.
Fixes: #501

Don't create a CI for this yet.  Investigating something.

This PR should be good for CI.  Tested on OS X and CentOS.

CI: https://ci.nodejs.org/view/libuv/job/libuv+any-pr+multi/143/

RHEL 7 seems good: https://ci.nodejs.org/view/libuv/job/libuv+any-pr+multi/143/nodes=centos7-64/console  I looked at FreeBSD, OS X, Ubuntu and Windows and their test failures were unrelated.  I look forward to the review process.

One femto-nit, but LGTM. Great work @whitlockjc :+1:

Should be fixed.  Let me know if there is more to do.

Landed in 30fc362, thanks a lot! :heart_eyes:

Any time.


Basic Http Auth

I'd like to use IssueService with Http Basic Auth but access to the request object is needed in order to set the credentials
Am I missing any obvious way to configure the client or the service to achieve this?
BTW, thanks for your work, I am using this package in couple of personal projects with no issues appart of this

@rodrigodiez You can pass a http.Client to NewClient, so you can set the Transport field for that HTTP client to perform Basic auth:
type BasicAuthRoundTripper struct {
    Username string
    Password string
    Next     http.RoundTripper
}

func (rt *BasicAuthRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
    req.SetBasicAuth(rt.Username, rt.Password)
    return rt.Next(req)
}

func main() {
    // ...

    var httpClient http.Client
    httpClient.Transport = &BasicAuthRoundTripper{
        Username: "username",
        Password: "password",
        Next:     httpClient.Transport,
    }
    client := jira.NewClient(baseURL, &httpClient)

    // ...
}

BTW thanks, happy this package is useful for someone else as well :-)

Wow, thanks for the code samples! I did not know that the standard http Client could be configured in such way
I'll take this approach, thanks again for your hard work!

@rodrigodiez No problem. Actually these should be return rt.Next.RoundTrip(req) in the example. Fixed.


Image support?

Any plans to add support for the image type?  just using file right now but a lot less nice to see in the castledb editor that way.

Can you send me a link to a quick sample CastleDB file using that type and I can take a look. In my current project all images are coming from tile maps, so I don't think I put that type in yet.

Sprite is an image file.
That said, shortly after I posted that, I realized the file type had an “open” button on it.  My main concern was being able to quickly see what the image was still in the castled editor, but that kinda fixed it.  So don’t worry about this for my sake unless its super simple.
From: Justin Walsh<EMAIL_ADDRESS>Sent: Monday, May 11, 2020 11:19 AM
To: thejustinwalsh/castledb-godot
Cc: Rankith; Author
Subject: Re: [thejustinwalsh/castledb-godot] Image support? (#1)
Can you send me a link to a quick sample CastleDB file using that type and I can take a look. In my current project all images are coming from tile maps, so I don't think I put that type in yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/thejustinwalsh/castledb-godot/issues/1#issuecomment-626870886 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNINPMTQQ2PGVG64IVIEGDRRA6TDANCNFSM4M5PYNXA .

So looking into it a bit more I see that images or stored into a new json file with Base64 decoding.
I can see how one may want to visualize Images in the DB and then use them to load something up dynamically. However, at this time I have no plans to add support for Images. I feel like there are plenty of image loading paths methods and routines available in Godot.
Please feel free to submit a PR for this feature and I will gladly merge it.

So I've been using CastleDB more and it seems List would be very useful
type to have support for.  List on the back end for CastleDB is just an
array of json entries:
"otherval1": 1,
"listtest": [
{"x": 1,"y": 1},
{"x": 2,"y": 1},
],
"otherval2": 2
Unfortunately I don't 100% understand the godot import process (I tried to
get it to run with debugging so I could step through what you've done, but
apparently thats not a thing). When poking around I saw the comment about
implementing lists as a todo.  If you are not going to get around to it,
did you have an idea for implementation?  Would just adding the class
without the @ and then instantiating an array of that class in the index
buildout be about right?
On Wed, May 13, 2020 at 5:52 AM Justin Walsh<EMAIL_ADDRESS>wrote:

So looking into it a bit more I see that images or stored into a new json
file with Base64 decoding.
I can see how one may want to visualize Images in the DB and then use them
to load something up dynamically. However, at this time I have no plans to
add support for Images. I feel like there are plenty of image loading paths
methods and routines available in Godot.
Please feel free to submit a PR for this feature and I will gladly merge
it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/thejustinwalsh/castledb-godot/issues/1#issuecomment-627962045,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNINPNNXWZFHH4EZ64VL4LRRKJXDANCNFSM4M5PYNXA
.

Lists would require generating a row class from the list, then just making an array of rows. I think this is where my head was at, with this type. Would want to see how it is done in haxe and port it over in a similar way.

The List conversation should be redirected to https://github.com/thejustinwalsh/castledb-godot/issues/5.
Leaving this issue open for image support.


⚠ Community has degraded performance

In 5f5765a, Community (https://community.wrk.com/health) experienced degraded performance:

HTTP code: 200
Response time: 294 ms

Resolved: Community performance has improved in 689951c.


[Wallet] Restore Account Key screen redesign

Description
Redesigning Account Key screen in onboarding https://www.figma.com/file/zt7aTQ5wuXycIwxq5oAmF9/Wallet--Refresh?node-id=5404%3A440. I've straggled to make multiline input to work as expected on both platform, when placeholder is multiline, but no luck. So I've decided to use short placeholder for now and later come back to this problem. This means, that instead of full 24 words as a placeholder you would see only a first couple of them followed by ... (see Screenshots)
Tested
Android and iPhone
Related issues

Related to https://github.com/celo-org/celo-monorepo/issues/3645

Backwards compatibility
Yes
Screenshots

@coreycelo please take a look on the tepmorary proposed design changes if that's ok, thanks!

@coreycelo please take a look on the temporary proposed design changes if that's ok, thanks!

@i1skn Cool. This is something that will confuse some users so it'd be good to get it in eventually, but makes sense. In the second screenshot after the video, the word "medal" is underlined. Is that an Android text field feature or part of the app?

@coreycelo please take a look on the temporary proposed design changes if that's ok, thanks!

@i1skn Cool. This is something that will confuse some users so it'd be good to get it in eventually, but makes sense. In the second screenshot after the video, the word "medal" is underlined. Is that an Android text field feature or part of the app?

It's Android feature.


I built a site with Eleventy!

Please supply the following information:

https://andrewrico.com/
Andrew Rico
A Homepage
Twitter avatar of either the site or the author
https://github.com/Andrewrico/andrewrico.com-2020

Sometimes it can take a little bit to get all of these on the live site. If you want a faster turnaround (or want to be nice to our lovely maintainers ❤), please open a pull request instead!
Built with Eleventy sites each have a separate file in _data/sites/*.json with this format: (the source_url field is optional)
{
	"url": "https://www.zachleat.com/",
	"name": "Zach Leatherman",
	"description": "A 10+ years-running blog about web development.",
	"twitter": "zachleat",
	"source_url": "https://github.com/zachleat/zachleat.com"
}

Nice portfolio page! I like the list of Skills


WorkflowRun.doTerm and doKill need to redirect back to the build

Otherwise clicking the sidepanel entries for term / kill sends you to a blank page.

https://github.com/jenkins-infra/helpdesk/issues/3189

https://github.com/jenkinsci/bom/pull/1500#issuecomment-1291935787

Yeah I did not get around to updating them yet. Guess I can file PRs for that.

either needs corresponding fixes in
pipeline-graph-analysis, workflow-api, workflow-cps, workflow-durable-task-step and workflow-support or should be reverted and redone without breaking API compatability (possily using Stapler.getCurrentResponse().forwardToPreviousPage(StaplerRequest.getCurrentRequest()) with null protection.


Fix keyboard navigation on library tabs

Summary
A simple oversight: instead of passing a key handler, it passes a closure resolving to a handler.
Relevant Technical Choices

To-do
n/a
User-facing changes
User can navigate library tabs using arrows left and right.
Testing Instructions
See #2272

Fixes #2272

@barklund changes made. ptal.


Beiboot client: "cluster list" function

Currently the client does not have a function to list all existing beiboot clusters. Adding this functionality would be a nice enhancement.

This needs to be discussed. Can you elaborate why you would like to see this functionality?

E.g. in order to decide if a cluster is already created or not. Currently I detect if a cluster exists by running get_connection, which works, too. Other providers such as k3d and kind provide a "cluster list" option. Not sure if there are some cluster permission concerns for beiboot, which would speak against such a feature.

Now possible using the client


cargo chef cook ignores disabled default features in dependencies

Hi,
I hit an issue where cargo chef cook --release ignores the disabling of default features for dependencies, making it impossible to build Rusoto with Rustls.
In a workspace with layout:
.
├── backend
│   ├── Cargo.toml
│   └── src
├── Cargo.lock
├── Cargo.toml
├── Dockerfile
├── frontend_yew
│   ├── Cargo.toml
│   ├── index.html
│   ├── main.js
│   ├── pkg
│   ├── README.md
│   └── src
├── LICENSE-APACHE
├── LICENSE-MIT
├── README.md

and the backend Cargo.toml:
[dependencies]
actix-web = "3.2.0"
tracing-actix-web = "0.2.1"
tracing = "0.1.21"
serde_derive = "1.0.117"
serde = "1.0.117"
base-62 = "0.1.1"
uuid = { version = "0.8.1", features = ["v4"] }
tracing-futures = "0.2.4"
anyhow = "1.0.34"
rusoto_core = { version = "0.45.0", default_features=false, features=["rustls"] }
rusoto_s3 = { version = "0.45.0", default_features=false, features=["rustls"] }
tokio = "0.2"
lazy_static = "1.4.0"
tracing-log = "0.1.1"
tracing-subscriber = "0.2.15"
tracing-bunyan-formatter = "0.1.6"
actix-cors = "0.5.1"

Running cargo chef prepare  --recipe-path recipetest.json generates:

{
  "skeleton": {
    "manifests": [
      {
        "relative_path": "Cargo.toml",
        "contents": "[workspace]\nmembers = [\"backend\"]\n"
      },
      {
        "relative_path": "frontend_yew/Cargo.toml",
        "contents": "bench = []\nbin = []\nexample = []\ntest = []\n\n[dependencies]\nwasm-bindgen = \"0.2.68\"\n\n[dependencies.web-sys]\nfeatures = [\"FormData\"]\noptional = false\nversion = \"0.3.45\"\n\n[dependencies.yew]\nfeatures = [\"services\"]\noptional = false\nversion = \"0.17.4\"\n\n[lib]\nbench = true\ncrate-type = [\"cdylib\", \"rlib\"]\ndoc = true\ndoctest = true\nharness = true\nplugin = false\nproc-macro = false\nrequired-features = []\ntest = true\n\n[package]\nauthors = [\"James McMurray<EMAIL_ADDRESS>= true\nautobins = true\nautoexamples = true\nautotests = true\ncategories = []\nedition = \"2018\"\nkeywords = []\nname = \"frontend\"\npublish = true\nversion = \"0.1.0\"\n"
      },
      {
        "relative_path": "backend/Cargo.toml",
        "contents": "bench = []\nexample = []\ntest = []\n\n[[bin]]\nbench = true\ndoc = true\ndoctest = true\nedition = \"2018\"\nharness = true\nname = \"elposhigu\"\npath = \"src/main.rs\"\nplugin = false\nproc-macro = false\nrequired-features = []\ntest = true\n\n[dependencies]\nactix-cors = \"0.5.1\"\nactix-web = \"3.2.0\"\nanyhow = \"1.0.34\"\nbase-62 = \"0.1.1\"\nlazy_static = \"1.4.0\"\nserde = \"1.0.117\"\nserde_derive = \"1.0.117\"\ntokio = \"0.2\"\ntracing = \"0.1.21\"\ntracing-actix-web = \"0.2.1\"\ntracing-bunyan-formatter = \"0.1.6\"\ntracing-futures = \"0.2.4\"\ntracing-log = \"0.1.1\"\ntracing-subscriber = \"0.2.15\"\n\n[dependencies.rusoto_core]\nfeatures = [\"rustls\"]\noptional = false\nversion = \"0.45.0\"\n\n[dependencies.rusoto_s3]\nfeatures = [\"rustls\"]\noptional = false\nversion = \"0.45.0\"\n\n[dependencies.uuid]\nfeatures = [\"v4\"]\noptional = false\nversion = \"0.8.1\"\n\n[lib]\nbench = true\ncrate-type = [\"rlib\"]\ndoc = true\ndoctest = true\nedition = \"2018\"\nharness = true\nname = \"elposhigu\"\npath = \"src/lib.rs\"\nplugin = false\nproc-macro = false\nrequired-features = []\ntest = true\n\n[package]\nauthors = [\"James McMurray<EMAIL_ADDRESS>= true\nautobins = true\nautoexamples = true\nautotests = true\ncategories = []\ndescription = \"Minimal pastebin service written in Rust + Actix Web\"\nedition = \"2018\"\nhomepage = \"https://github.com/jamesmcm/elposhigu\"\nkeywords = []\nlicense = \"MIT/Apache-2.0\"\nname = \"elposhigu\"\npublish = true\nreadme = \"README.md\"\nrepository = \"https://github.com/jamesmcm/elposhigu\"\nversion = \"0.1.0\"\n"
      }
    ],
    "lock_file": "#..."
}

However, cargo chef cook generates a backend/Cargo.toml with no default_features entries:
[dependencies.rusoto_core]
features = ["rustls"]
optional = false
version = "0.45.0"

[dependencies.rusoto_s3]
features = ["rustls"]
optional = false
version = "0.45.0"

In this case, this causes the build to fail due to having both rustls (and native-tls still included):
error[E0252]: the name `tls` is defined multiple times
  --> /home/archie/.cargo/registry/src/github.com-1ecc6299db9ec823/rusoto_core-0.45.0/src/lib.rs:25:5
   |
23 | use hyper_rustls as tls;
   |     ------------------- previous import of the module `tls` here
24 | #[cfg(feature = "native-tls")]
25 | use hyper_tls as tls;
   |     ^^^^^^^^^^^^^^^^ `tls` reimported here
   |
   = note: `tls` must be defined only once in the type namespace of this module
help: you can use `as` to change the binding name of the import
   |
25 | use hyper_tls as other_tls;
   |     ^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0252`.
error: could not compile `rusoto_core`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed
thread 'main' panicked at 'Exited with status code: 101', /home/archie/.cargo/registry/src/github.com-1ecc6299db9ec823/cargo-chef-0.1.8/src/recipe.rs:88:27
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Even using --no-default-features for the backend package directly doesn't seem to help.
Is it possible to use crate-level default features?

This seems to point at a bug in cargo-manifest - I'll look into it!

Thanks, I found the issue:
https://github.com/LukeMathWalker/cargo-manifest/blob/8cffbcc94ae76795354e0f4753d1cbdb41c3a8c5/src/lib.rs#L432
It serde renames all to kebab case, but snake_case is still permissible too, so ideally we'd accept both.
At the moment it doesn't recognise the snake case so it ignores it and default features are left enabled.

It should be fixed in 0.1.9!


Bug fix/agency assert consistency of acked time and index

This PR fixes an issue where, during a failover in the Agents (re-election, or Agent death) the new leader was not able to report the config for a while, due to 2 internal maps being out-of-sync.
These two maps are now unified into a single one, the the out-of-sync situation is impossible.
Also made synchronization with the AgencyConfiguration more explicit, and removed code that worked due to implicit side-effects only, should be a bit safer now, not claiming the the old code was wrong in any way, besides the error seen above.
Jenkins:
http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/10831/

Attached Jenkins is fully blue.
However I would like to have some Chaos Testing on this branch, handed this over to @kvahed thank you for this :+1:


adding Facility_Location.ipynb

adding new notebook as per #48

Pull Request Test Coverage Report for Build 620

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.3%) to 86.171%

Files with Coverage Reduction
New Missed Lines
%

spaghetti/network.py
2
90.0%

Totals

Change from base Build 613:
0.3%

Covered Lines:
997

Relevant Lines:
1157

💛  - Coveralls


DAT can't find Dell XPS 13 9380

Last time I had this issue with a different model the solution below fixed it but it's happening again with a new model and this did not fix it this time.

close Driver Automation Tool (DAT)
under where you have DAT installed, look for a Temp folder
delete the two DriverPackCatalog files in that Temp folder
launch DAT and select Dell
click Find Models

Any other suggestions?

Searched for 9380 and it showed up as Dell XPS Notebook 9380.


Add check for the license header.

Fix the issue https://github.com/google/instrumentation-java/issues/274
Found one file without the license using this check.

Codecov Report

Merging #309 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #309   +/-   ##
=========================================
  Coverage     94.67%   94.67%
  Complexity      491      491
=========================================
  Files            79       79
  Lines          1860     1860
  Branches        121      121
=========================================
  Hits           1761     1761
  Misses           67       67
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a34c32...8a46550. Read the comment docs.


fix(explore): Missing markarea component broke annotations in echarts

SUMMARY
Recent Echarts bundle size optimization PR didn't register MarkLineComponent and MarkAreaComponent from echarts/components package, which broke annotations.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS

Create an annotation layer

date 2000-01-20 15:50 -> 2000-03-01 15:50

Save
Go to the Country Growth Rate chart
Add the annotation

Show labe = checked
annotation layer type = interval
annotation source = Superset annotation
annotation layer = your annotation layer
hit ok

click update chart
Verify that the annotation is visible
Do the same for annotation layer type = Event

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up


On mobile the "welcome to Gann+" message is far on the left side and half is covered [Bug]

This also occurs when the window width is considered by the website to be "mobile".

Thank you for reporting! This has been fixed in 4ec52c8 and will be published in the next release.


Mostly switch to @Inject in MixinPlayerChunkSender for compatibility

Which mod incompatibility issue do you want to fix with this PR?


Gazebo simulation scene: The robot in Unity moves in opposite directions with the robot in Gazebo

Hi all
My settings are ROS# Version 1.2c, Unity 2017.4 and ROS indigo and I followed this video to run Turtlebot2 successfully. when I tried to do the same thing to Tutlebot3, everything goes well. Expect the robot in Unity moves in opposite directions with the robot in Gazebo. Like when the robot in Unity goes forward, the one in Gazebo moves backward. When the Unity robot turns left the gazebo one turns right. Any of you know how I can recalibrate it? Thanks a million.
Shall I simply just need to modify the directions in the following piece of code in the PoseReveiver.cs
private void ProcessMessage()
{
transform.position = position;
transform.rotation = rotation;
}

Hi @stevensu1838
I experienced the same issue when working with the TurtleBot2 in Unity. When I applied positive velocities, the robot moved in the opposite direction of Gazebo and a real TurtleBot2.
I suppose that this issue somehow is related to the left-handed coordinate system in Unity. Even though the axis are changed accordingly when importing the URDF, the angular positive direction around the y-axis in the left-handed cs is opposite of the angular positive direction around the z-axis in the right-handed cs (does this make any sense?).
My workaround for also publishing the "right" values with the JointStateReader was:

Change the axis for the Hinge Joint in both actuated wheels to 0 -1 0 (instead of 0 1 0)
Add a minus in RosBridgeClient/MessageHandling/JointStateReader.cs to get the "negative" velocity. (velocity = -urdfJoint.GetVelocity();)

For my case this worked. Hope it helps.

Hi,
I first figured out it was a problem on odom instead of joint state. (I learnt this by not using join state message). Then I added negative in PoseReceive.cs in front of message.pose.pose.position.x and message.pose.pose.orientation.w as shown below. Thus, the problem solved. Hope it helps others. B ut who do you know why I experience this error? Thx a lot. Thank you for your help@anko0009
        private Vector3 GetPosition(NavigationOdometry message)
        {
            return new Vector3(
                -message.pose.pose.position.x,
                message.pose.pose.position.y,
                message.pose.pose.position.z);
        }

        private Quaternion GetRotation(NavigationOdometry message)
        {
            return new Quaternion(
                message.pose.pose.orientation.x,
                message.pose.pose.orientation.y,
                message.pose.pose.orientation.z,
                -message.pose.pose.orientation.w);
        }
    }
}

Same problem here.
The above solution seems a bit "hacky" without knowing why in the first place those rotations are inverted from those shown in the video, given the same setup.

Maybe I should open another issue to gather some attention (I don't know if anyone other than @stevensu1838 is getting notifications on this).
A simple way to reproduce this bug is to clone the repository, open the Gazebo simulation scene, and edit the two wheel joints in unity.

Tick use motor
Tick free spin
Enter a positive value for target velocity

Enter play mode : the turtle bot is moving backward (negative on the Unity z axis).
I've checked the conversion methods for Points / Vectors / Quaternions between ROS and Unity, which are all good. As mentioned in the first post, it might be related to the URDF import and how the joint axes are positioned. I'll try to dig further when I have some time.

Dear @PymZoR, @anko0009  and @stevensu1838 ,
we delved into the problems you described above.
The root cause of the errors you are describing is that the ROS coordinate system is right-handed whereas the Unity coordinate system is left-handed.
This entails that the positive rotation direction in Unity is opposite to the positive rotation direction in ROS. In all problems you wrote about above, you are communicating angular rotation messages between ROS and Unity: angular positions, angular velocities, angular accelerations, torques, ...
You have to multiply -1 whenever you transfer those values between Unity and ROS.
We thought about pointing angular rotation axes into opposite directions, but this would be a hack. In case you change the joint into a prismatic joint, you would have to change the axis direction again. And in which axis direction should a cylindrical joint point to?
For Vector3 and Quaternion we already have Ros2Unity and Unity2Ros methods in TransformExtensions.cs.
We did not add  corresponding transformation methods for angular float value, since since we found individually multiplying -1 is better than extening the floatclass with two methods Ros2UnityAngular and Unity2RosAngular which both effectively multiply the float value by -1.
I hope this clarifies your problems. I'm closing this issue. Please let me know if you know a better solution than this. Please reopen or answer here if anything is left unclear.


merge from arlac77/npm-package-template-esm-only

package.json

fix(engines): add >=12.14.1 remove >=12.14.0 (engines.node)

.travis.yml

chore(travis): (jobs.include)
chore(travis): (jobs.include.node_js)
chore(travis): (script)

README.md

docs(README): update from template

:tada: This PR is included in version 5.0.13 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


set "must support" flags (Annatina Foppa, eHealth Suisse)

ch.fhir.ig.ch-emed#0.2.0 /
to define which elements have to be "understood" by implementing systems
Annatina Foppa, eHealth Suisse

for further explanation see the example of IPS, https://build.fhir.org/ig/HL7/fhir-ips/design.html#must-support

according to IPAG data elements
swiss emedication architecture table with supported data elements in pdf 7.2 CDA-CH-EMED and CH-EMED Key Element

-> mustSupport should be a mix of th two?

Current status:

Mapping table eMedication

add mapping of the data elements from section 7.2 CDA-CH-EMED and CH-EMED Key Elements (p. 136) from the PDF Implementation Guide for eMedication architecture in the context of the EPR - Detailed specification, Version 0.13

IG CH EMED (branch must-support):

Set MustSupport for the "green" IPAG elements for

Medication Card document


Add thermal model dataset and change name to live script

As per title.
xlsx files contain the thermal camera measurements, while .mat files contain the matlab logs taken by three_boards_receiver.slx.

Also, is the live script capable of reading the data files from data?

Yep, changed the target directory.

Missing README.

Added it!


Can't pass null to non-nullable arguments

This is in regards to: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
I'm getting this deprecation warning throughout all of winter with php 8.1 and it's happening in both winter and storm

@Teranode are you still getting those warnings? If so, where and how? I'm running 8 projects on latest wip/1.2 and have not seen those.

I went back to php8.0 cause the errors were getting pretty annoying, so Idk if it's still happening, I'll check tomorrow to see if it's still occurring

@Teranode if you could check to see if this is still a problem without your changes and then resubmit the PR if it is that would be great; thanks!

@LukeTowers yes it is still happening with php 8.1

There's also this one, I've not seen any indication of str_starts_with being use, but a lot of starts_with being used so it's complicated for me as I can't root it down.


Run servers error when it is disabled

I changed my settings like this:
tasks: {
	runServers: {
		enabled: false,
		sourcePath: 'build/server',
		paths: ['app.js']
	}
}

Now on save app.coffee I get the following error.
/id-builder/build/lib/servers.js:33
  monitor.kill(true);
TypeError: Cannot call method 'kill' of undefined

Probably due to the monitor not containing the child_process or something similar that should normally run app.js

This problem occurs because watchServers was still enabled, so on change it tries to restart something that issn't there to begin with. watchServers: { enabled: false } Solves it. But if runServers is false watch should be made false too by id-builder. The same maybe holds for other tasks too?

I might get time for id-builder this weekend again, but I'm thinking this: Maybe the watch tasks should all be condensed into one watch task, that turns on the watch functionality of a compile task when that one is enabled. That would mean that I would have to bundle the functionality of compiling and watching into one thing and then then whole architecture starts to sound more like a plugin architecture. That's what I wanted to avoid with this project. I don't want to rebuild gulp or grunt but DRY instead (yet still configurable).

On a second thought, I think the right way to look at id-builder is to provide a "live" coding environment.
Why have compile targets at all? Make everything watchable and include the initial compile into the watch functionality.

Ahh great I was hoping for a new release with all the cool fixes :) Yes exactly, why would you even want to compile once? I too think that would be a good flow! Looking forward to the next version :)

I've created a separate ticket (https://github.com/Industrial/id-builder/issues/27) to handle this issue. Thanks!


alternate base91 spec?

Hi,
The library uses follow alphabet order:
!~}|{zyxwvutsrqponmlkjihgfedcba`_^]#[ZYXWVUTSRQPONMLKJIHGFEDCBA@?>=<;:9876543210/.-,+*)($&%

However, original base91 spec has follow alphabet order:
ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!#$%&()*+,./:;<=>?@[]^_`{|}~\"

basE91 encoding

Is spec bug or extension?

Hi,
The library was designed to use encoded text in JSON without any escape sequence. Unfortunately, original alphabet has " - double quotes :(
/ may be escaped too, but it is not mandatory and works well.
Second - the library alphabet order was created with simpliest than original rule to create the sequence - XOR function with 3 exclusion.
So, it is an extension :)

Thank you for your response. OK, I understand.


Proposal Action Buttons: start and stop

Reported by atze on 6 Jul 2014 11:38 UTC
For Recording tickets in states scheduled resp. recording there could be action buttons in the ticket list with following semantics:
''' start button'''
-for tickets in "scheduled" or "recording"
-ask for something like "started [minutes ago", maybe with an additional "now"-button
-set Fahrplan.Starttime to current time minus value entered above
-set Record.StartPadding to a low value, like 60
''' stop button'''
-for tickets in state "recording"
-ask for something like "ended ..... minutes ago", maybe with an additional "now"-button
-set Fahrplan.Duration to current time minus value entered above - Fahrplan.Starttime
-set Record.EndPadding to a low value, like 60
-do NOT change ticket state
this could save time and confusion in the cutting process at some events, or it may even be possible that cutting is unnecessary at all.

Comment by texec on 12 Jul 2014 09:05 UTC
When we don't change the ticket state, isn't it counterintuitive that you can stop a recording ticket multiple times?
I suspect that starting moves a ticket to recording when in scheduled?

Comment by atze on 12 Jul 2014 10:42 UTC
A ticket state change could be done for the "start" button.
Not changing ticket state on pressing "stop" is NOT counter-intuitive IMO, because:

it could interfere with worker scripts
of course you should be able to stop a recording multiple times, since it is just a time marker. Using the "last wins" pragma, you can change the time marker easily.

Maybe the names shouldn't be "start" and "stop"... but stg. like "mark in" and "mark out" is not the vocabulary of our intended audience ;)


feat: add git hash of build everywhere

Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[ ] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[ ] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[ ] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[x] Testing: Have you written and run sufficient tests for validating the changes?
[x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Label: To cleary categorize this pull request, assign a relevant label to the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description
Add the git hash of the build into the output of backend and the frontend in the about page to help disambiguate builds when multiple releases of the same tag are produced.

Screenshots or Videos

LGTM, Thanks!


RHEL7(w/ systemd) needs only timedatectl to change timezone

Found this RHEL7 recipe creates /etc/sysconfig/clock that has no meaning in RHEL7.
Just removed the unnecessary resources.

This looks good. Food for thought, what do you think about how the systemd cookbook does it here:
https://github.com/nathwill/chef-systemd/blob/master/recipes/timezone.rb

Seems cool, but I found it does not always work fine.
For example when specified Asia/Tokyo as node['timezone_iii']['timezone'], node['time']['timezone'] is JST, which invokes timezonectl every run.
system::timezone uses the similar guard logic with timezone_iii::rhel7, and I think this is better.
https://github.com/xhost-cookbooks/system/blob/master/providers/timezone.rb#L83-L84


Btree map serialization results in error.

Are map type supported?
  {
        "type": "record",
        "name": "test",
        "fields": [
            {"name": "a", "type": "long", "default": 42},
            {"name": "b", "type": "string"},
            {"name": "additional", "type": {"type": "map", "values": "string"}}
        ]
    }

Herein the struct test has a third parameter called additional which is a map.
use avro_rs::{Codec, Reader, Schema, Writer, from_value, types::Record};
use failure::Error;
use serde::{Serialize, Deserialize};
use std::fs::File;
use std::io::prelude::*;
use std::collections::{HashMap, BTreeMap};

  #[derive(Debug, Deserialize, Serialize)]
   struct Test {
  a: i64,
  b: String,
   additional: BTreeMap<String, String>,
}

   fn main() -> Result<(), Error> {
let raw_schema = r#"
    {
        "type": "record",
        "name": "test",
        "fields": [
            {"name": "a", "type": "long", "default": 42},
            {"name": "b", "type": "string"},
            {"name": "additional", "type": {"type": "map", "values": "string"}}
        ]
    }
"#;

let schema = Schema::parse_str(raw_schema)?;

// println!("{:?}", schema);

let mut writer = Writer::with_codec(&schema, Vec::new(), Codec::Deflate);

let mut record = Record::new(writer.schema()).unwrap();
record.put("a", 27i64);
record.put("b", "foo");

let mut m: BTreeMap<String, String> = BTreeMap::new();
record.put("additional", m);

writer.append(record)?;

let test = Test {
    a: 27,
    b: "foo".to_owned(),
    additional: BTreeMap::new(),
};

writer.append_ser(test)?;

writer.flush()?;

let input = writer.into_inner();
let reader = Reader::with_schema(&schema, &input[..])?;

for record in reader {
    println!("{:?}", from_value::<Test>(&record?));
}
Ok(())

}
This results in Error
    the trait `avro_rs::types::ToAvro` is not implemented for `std::collections::BTreeMap<std::string::String, std::string::String

However the de-serialization works fine.

I don't see any theoretical impediment to serializing BTreeMap, but your code clearly shows that this doesn't work atm.
We do have a bunch of tests on schema validations of maps and one for the encoding of Value::Map, but I cannot find any covering native rust types serialization and deserialization. There might be a bug with all kind of maps or perhaps some serde method we did not implement for BTreeMap.
If you'd like to contribute, a good first step would be to add a couple of serialization and deserialization tests for HashMap to check whether that works at all and use that information to figure out where the problem is.

@poros , I did some tests, HashMap does actually work. I would be happy to help if provided some pointers(especially what you or someone familiar with code-base would have done).

It would be great if you could add your tests for HashMap (and then for BTreeMap once it works) to a place like writer.rs.
As for discovering where the problem is, I would start from ToAvro in types.rs as the error says and, in case it is not there, maybe move to ser.rs or de.rs.

@poros , Thanks for pointers.  I have a question though, the Value enum in types.rs maps the Avro map type to Rust HashMap and implements ToAvro trait for HashMap. I believe I need to implement the ToAvro trait for BtreeMap. What I am confused about is how do we allow the Avro Map type to correspond to  both BtreeMap  and HashMap  ? Any ideas there?

@poros any pointer on the previous comment would be great. Thanks

If I understand your original request correctly, I don't think you are interested in changing the internal implementation of the Value type, but only allow a conversion from and to BtreeMap. As I mention before, I think you could at least allow conversion from BtreeMap by implementing the ToAvro trait for such a type.

@poros , noted. Will do so and add tests for it as well.


IndexError in format_bar()

One of my CI builds failed with:
File ".../site-packages/click/_termui_impl.py", line 176, in format_bar
    chars[
IndexError: list assignment index out of range

I've never seen this before. It seems to be a bug that's only triggered in very rare circumstances and hard to reproduce.
Environment:

Python version: 3.9.5
Click version: 8.0.1

Do you have click code from your project/ci build that is causing the issue that you could post?

Sure. But I'm not doing anything interesting :)
with open(file) as f:
  with click.progressbar(f, width = 0, label = "...") as bar:
    for line in bar:
      ...

This has worked fine 100% of the time. Except for that single CI build.

Closing as there's nothing to reproduce with.

Closing as there's nothing to reproduce with.

I agree that lacking the ability to reproduce this is a problem. And currently I can't rule out that this was the result of a random bit flip.
But if the problem is that the math used to calculate the index has a weird edge case, we could still either fix the math or coerce the value to the appropriate range.

But if the problem is that the math used to calculate the index has a weird edge case

I'm not convinced that's the case, but I'm certainly not convinced it isn't either :)


Style tweaks for widescreens and button page

Added some styles to fit the screen better on larger monitors and improve the style on the addresses above the tables on the /button pages

Ah for sure. I only have my laptop screen to go off of, and in the dev window it seemed too stretched out at simulated wider sizes.  But if its fine IRL thats good for me, reverted those changes


dart:ffi - expose dart_api.h to FFI modules

Would it be possible to
#include "third_party/dart/runtime/include/dart_api.h"

from a c-file that is called by ffi?

cc @sjindel-google

This should be possible, provided the Dart_* symbols are publicly exported from libflutter.so.
/cc @dcharkes

I tried the code from https://github.com/dart-lang/sdk/blob/c52acadd15f95e1367f03200206c549a52f81b94/tests/ffi/vmspecific_send_port_id_test.dart on iOS.
It failed. So, I guess the symbols are stripped.

@jonahwilliams this is a Flutter embedder thing, not a Dart thing if the symbols are not exposed.

Not sure, cc @cbracken

Flutter FFI on IOS with statically linked prebuilt library does not work either, is it related? Please see https://github.com/flutter/flutter/issues/33227#issuecomment-566239011

We will solve this on the Dart side https://github.com/dart-lang/sdk/issues/40607.


Same total request time when using a Transport

This is similar to #2 and results in the same<PHONE_NUMBER>854).
I'm trying to test the request time of a bunch of proxies by calling https://ipinfo.io/json with a proxy in the transport of the client.
When I'm running that code the request always has the exact same total time even though its proxies in other continents. Anything I'm missing? Code is basically the same as this one: https://github.com/tcnksm/go-httpstat/blob/master/_example/main.go except that I'm using a transport. I also added the output of the code from GoDoc which looks as expected
https://play.golang.org/p/RxhH0r236p

Thank you for submitting issue. Let me run your code and investigate.

Basically, there are 2 problems.
One is it shows non-zero time.Duration(9223372036854). The other is Proxy time problem.
Let's solve one by one. The first problem is because you old Dial. httptrace is enabled when you use DialContext. Could you update your code to use newer function?
And now I fix not to show non-zero time.Duration(9223372036854) on https://github.com/tcnksm/go-httpstat/pull/5

I updated the http.Transport to use the new DialContext and updated go-httpstat to the latest version but the result still doesn't look right. Can you replicate this problem?
	t := &http.Transport{
		DialContext: (&net.Dialer{
			Timeout: 5 * time.Second,
		}).DialContext,
		TLSHandshakeTimeout: 5 * time.Second,
		Proxy:               http.ProxyURL(u),
	}
	c := &http.Client{
		Timeout:   time.Second * 10,
		Transport: t,
	}

Result:
2016/10/21 11:08:51 DNS lookup: 0 ms
2016/10/21 11:08:51 TCP connection: 582 ms
2016/10/21 11:08:51 TLS handshake: 0 ms
2016/10/21 11:08:51 Server processing: 98 ms
2016/10/21 11:08:51 Content transfer: 0 ms
2016/10/21 11:08:51 Name Lookup: 0 ms
2016/10/21 11:08:51 Connect:<PHONE_NUMBER>854 ms
2016/10/21 11:08:51 Pre Transfer:<PHONE_NUMBER>854 ms
2016/10/21 11:08:51 Start Transfer:<PHONE_NUMBER>854 ms
2016/10/21 11:08:51 Total:<PHONE_NUMBER>854 ms

I reproduced it and found it's because of DNSLookup part.
Fix is on feature/when-connecting-ip-proxy branch. Can you try it ?

I will merge. Report again if still broken.

Sorry for the late reply, this fixed the issue. Thanks!

Great! Thank you for reporting !

Hi, i'm getting same error on aws lambda, it works fine on my local env, but having issue on lambda. Do you have any idea about that?
Thanks.


Add 3 new endpoints: Flight Most Booked Destinations, Flight Busiest …

…Period and Airline Code Lookup
Add endpoint implementations for the new following APIs:

Airline Code LookUp
Flight Busiest Traveling Period
Flight Most Booked Destinations

@anthonyroux ready for review!


scripts: Use local server for Strava auth

Several changes combined into one:
• Redirect back to the local server to complete the auth flow, rather
than pointlessly redirecting via an AWS server
• Convert the temporary token into a long-term token so that people
don’t have to reauthenticate every time they want to upload an
activity
• Don’t use a fixed local port — allow the OS to allocate us one
• Store the access and refresh tokens in the correct directory
according to the XDG Base Directory specification
(https://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html)
I’ve registered a new application with Strava for doing the
authentication, since the client secret is needed.
Signed-off-by: Philip Withnall<EMAIL_ADDRESS>

Coverage remained the same at 6.272% when pulling 35e0954eeb6f8d2976f95c84164297958d70a14b on pwithnall:auth into a8ae0ce3d77004bbc1d2c1e7ed34b14c344cddba on Tigge:master.

Would you mind removing python 3.3 from the Travis config (it's not supported anymore)? It's not something you introduced, but fixing it would give this green checkboxes for the checks.

Would you mind removing python 3.3 from the Travis config (it's not supported anymore)? It's not something you introduced, but fixing it would give this green checkboxes for the checks.

Done.

@Tigge would you mind merging this? It's a much better fix that what I did on #182

Sorry, this got left here without action from me. Merged now. Thank you!


NPE when using shared property merge tasks

Using a task definition that shares properties, but does not use command line merge options results in a NPE:
A bug occurred.
Please report an issue on the 'test-openapi-plugin-merge' code repository and paste the following lines:

OS: darwin
node.js: v10.11.0
test-openapi: 40.2.0

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)
    at mergeObject (/Users/jpettit/dev/github/test-openapi/node_modules/deepmerge/dist/umd.js:55:9)
    at deepmerge (/Users/jpettit/dev/github/test-openapi/node_modules/deepmerge/dist/umd.js:79:10)
    at /Users/jpettit/dev/github/test-openapi/node_modules/deepmerge/dist/umd.js:89:10
    at Array.reduce (<anonymous>)
    at Function.deepmergeAll [as all] (/Users/jpettit/dev/github/test-openapi/node_modules/deepmerge/dist/umd.js:88:15)
    at customMerge (/Users/jpettit/dev/github/test-openapi/src/utils/merge.js:27:20)
    at merge (/Users/jpettit/dev/github/test-openapi/src/template/merge.js:12:10)
    at mergeTask (/Users/jpettit/dev/github/test-openapi/src/core/merge/load.js:51:58)
    at nonMergeTasks.map.task (/Users/jpettit/dev/github/test-openapi/src/core/merge/load.js:25:5)

Executing test-openapi with any merge option at the CLI fixes the issue: ./test-openapi.js --merge.call.headers.foo bar
The issue is that ultimately utils/merge.js gets an ...objects array with a null element here:
const customMerge = function(isMergeableObject, ...objects) {
  return deepMerge.all(objects, { arrayMerge, isMergeableObject })
}

Fixed. (see #12)


Rename Sandbox to Playground:

Description

The repo has been renamed.
Why is this needed

Fixes: #
How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

@mergifyio queue

@Mergifyio queue


Update to release 8.1

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

/test ?

/test ?

/retest

/retest

/retest

/retest

/retest

/retest


fix: Aeson 1.5 readiness

Enables build with newer Aeson versions (otherwise fails with overlapping instances error).

Thanks! LGTM


Add uk modulus checking assert

This assert checks if the given accountNumber and sortCode represent a valid Faster Payment Account.

@franciscocardoso is this PR ready to be reviewed?

The test file has a typo.


hugo: 0.46 -> 0.47

Motivation for this change
https://gohugo.io/news/0.47-relnotes/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

cc @schneefux

@GrahamcOfBorg build hugo

Failure on aarch64-linux (full log)
Attempted: hugo
Partial log (click to expand)
github.com/gohugoio/hugo/tpl/time
github.com/gohugoio/hugo/tpl/transform
github.com/gohugoio/hugo/tpl/strings
github.com/bep/go-tocss/scss/libsass
github.com/gohugoio/hugo/resource/tocss/scss
github.com/gohugoio/hugo/tpl/resources
github.com/gohugoio/hugo/tpl/tplimpl
github.com/gohugoio/hugo/hugolib
builder for '/nix/store/yhzjvms5972vxi73k48fqma2hkryhwb9-hugo-0.47.drv' failed with exit code 39
error: build of '/nix/store/yhzjvms5972vxi73k48fqma2hkryhwb9-hugo-0.47.drv' failed

aarch64 looks like an resource problem on the build machine.

Success on x86_64-linux (full log)
Attempted: hugo
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lxj1xjvzy2d2zaqrdm9alm3gxa5bxxl0-hugo-0.47-bin
shrinking /nix/store/lxj1xjvzy2d2zaqrdm9alm3gxa5bxxl0-hugo-0.47-bin/bin/hugo
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lxj1xjvzy2d2zaqrdm9alm3gxa5bxxl0-hugo-0.47-bin/bin
patching script interpreter paths in /nix/store/lxj1xjvzy2d2zaqrdm9alm3gxa5bxxl0-hugo-0.47-bin
checking for references to /build in /nix/store/lxj1xjvzy2d2zaqrdm9alm3gxa5bxxl0-hugo-0.47-bin...
strip is /nix/store/553rihc190vsyy8b22iqcq25a6489h8y-binutils-2.30/bin/strip
/nix/store/lxj1xjvzy2d2zaqrdm9alm3gxa5bxxl0-hugo-0.47-bin

Success on x86_64-darwin (full log)
Attempted: hugo
Partial log (click to expand)
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
find: '/nix/store/1a0l8kn5mpfnmzsn5y396993bgcaznwn-hugo-0.47': No such file or directory
/nix/store/k5fwshanh1npyfrmamyrgj4khccmiksr-hugo-0.47-bin


IAM Users cannot be renamed

While AWS supports changing a User's name, this causes some problems for pulumi as dependent resources reference the user by name.
Pulumi version: 3.10.3
AWS plugin version: 4.17.0
Steps to reproduce

Create a Pulumi script that creates an IAM user along with a UserPolicy, a UserPolicyAttachment and an AccessKey
Deploy via pulumi up
Change the user's name in the Pulumi script
Deploy via pulumi up

Expected: The user is renamed and dependent resources remain unchanged.
Actual: The user is renamed, but pulumi then tries to replace dependent resources to reflect the name change - which fails because they are looked up using the original user name:
    error: deleting urn:pulumi:dev::rename::aws:iam/accessKey:AccessKey::testuserAccessKey: 1 error occurred:
    	* Error deleting access key AKIAXXXXXXXXXXXXXXXXX: NoSuchEntity: The user with name testuser1 cannot be found.
    	status code: 404, request id: ...

After that, the IAM User has the new name but both the old and new versions of the UserPolicy and AccessKey since deleting the previous instance failed.
Doing a pulumi refresh then will detect that the user (using its original name) has been deleted. A subsequent pulumi up will still fail, because the user actually exists with the new name.
Pulumi script to reproduce (just change the username):
import * as aws from "@pulumi/aws";
import * as fs from "fs"

const basename = "testuser"
const username = "testuser2"

const testUserPolicy: aws.iam.PolicyDocument = {
    Version: "2012-10-17",
    Statement: [
        {
            Action: [
                "iam:GetUser"
            ],
            Effect: "Allow",
            Resource: "*",
        }
    ],
}

const testUserPolicies: Record<string, aws.iam.PolicyArgs> = {
    "test-s3-policy": {
      description: "Manage S3 resources",
      policy: {
        Version: "2012-10-17",
        Statement: [
          {
            Action: ["s3:ListBucket"],
            Effect: "Allow",
            Resource: "*"
          }
        ]
      }
    }
}

const user = new aws.iam.User(basename, {name: username})

new aws.iam.UserPolicy(`${basename}Policy`, {
    user: user.name,
    policy: testUserPolicy
})

for (const key in testUserPolicies) {
    const policy = new aws.iam.Policy(key, testUserPolicies[key])
    new aws.iam.UserPolicyAttachment(`${key}-attachment`, {
        user: user.id,
        policyArn: policy.arn
    })
}

const accessKey = new aws.iam.AccessKey(`${basename}AccessKey`, {
    user: user.name,
    pgpKey: fs.readFileSync("gpg.pub").toString()
})

I think this is an unfortunate consequence of how the upstream provider has modeled the attachment by using name which is tied in to the identifier (which we'd expect to be stable). One way to work around this is to use { replaceOnChanges: ["name"] } as a resource option for the iam.User which will cause cascading replaces for the related resources and you should be able to successfully create/delete the resources.
I don't think restructuring the upstream provider's model of IAM is feasible, so I'll close this issue out as unfortunately "by design" (given the way it's modeled).


Not providing output when running with different input PNG.

Hi, I am trying to run Mozart with one of my own PNG files and am not receiving any output. Does this PNG disagree with Mozart's specifications?

I met the same problem. My input figure is below.
Please kindly help if anyone can give suggestions, thanks!

Hi @ChelyFernandezUSC @lixucuhk,
Please, try to use the section break-in each of the sheets you referenced before to split the sheet into multiple sections/images and run it again.

I have the same question. How do you create the sample PNG file? I scanned my music sheet as pdf file, then convert to PNG format, but I got empty result. I tried to debug Mozart, which fails to segment my file.

Really appreciate any insights. Thanks

Hi @ChelyFernandezUSC @lixucuhk,
Please, try to use the section break-in each of the sheets you referenced before to split the sheet into multiple sections/images and run it again.

Hi,
we actually had the same problem. What exactly do you mean by breaking it into sections? What should be part in one section?
Could you provide an example?
Thanks a lot!
Martin

The same to me.
I created two folders for input and output.
Put the music sheet image in the input folder, even split it into sections.
Run python3 .\src\main.py .\input .\music
Nothing happened in my music folder(output folder).

@sknightq you can try python .\src\main.py .\input .\music


Globed won't let me login

I just downloaded globed, and it says to fix my system clock (which is 100% on time) and refresh my login. I tried the ladder, and nothing happened, and I'm not sacrificing the clock on my computer for globed.
a few fyi's: it says the clock is off by 10914 seconds which CANNOT be right, and also, this is my first time attempting to use globed, I have never touched it before.

sync your system time. there is no other solution. you are not sacrificing anything.

ok, but what do i even correct it to? it already is correct.

it's not correct, you don't correct it to anything. you just press the sync button and it will sync it automatically.


Exception in lumberjack plugin when shutting down

SIGTERM received. Shutting down the pipeline. {:level=>:warn, :file=>"logstash/agent.rb", :line=>"122", :method=>"execute"}
Sending shutdown signal to input thread {:thread=>#<Thread:0x3887db5c sleep>, :level=>:info, :file=>"logstash/pipeline.rb", :line=>"258", :method=>"shutdown"}
Plugin is finished {:plugin=><LogStash::Inputs::Lumberjack ssl_certificate=>"/etc/logstash/lumberjack.crt", ssl_key=>"/etc/logstash/lumberjack.key", host=>"<IP_ADDRESS>">, :level=>:info, :file=>"logstash/plugin.rb", :line=>"61", :method=>"finished"}
Exception in lumberjack input {:exception=>#<LogStash::ShutdownSignal: LogStash::ShutdownSignal>, :level=>:error, :file=>"logstash/inputs/lumberjack.rb", :line=>"74", :method=>"run"}
Received shutdown signal {:plugin=><LogStash::Inputs::Lumberjack ssl_certificate=>"/etc/logstash/lumberjack.crt", ssl_key=>"/etc/logstash/lumberjack.key", host=>"<IP_ADDRESS>">, :level=>:info, :file=>"logstash/plugin.rb", :line=>"39", :method=>"shutdown"}
Sending shutdown event to agent queue {:plugin=><LogStash::Inputs::Lumberjack ssl_certificate=>"/etc/logstash/lumberjack.crt", ssl_key=>"/etc/logstash/lumberjack.key", host=>"<IP_ADDRESS>">, :level=>:info, :file=>"logstash/plugin.rb", :line=>"56", :method=>"finished"}
Sending shutdown event to agent queue {:plugin=><LogStash::Inputs::Lumberjack ssl_certificate=>"/etc/logstash/lumberjack.crt", ssl_key=>"/etc/logstash/lumberjack.key", host=>"<IP_ADDRESS>">, :level=>:info, :file=>"logstash/plugin.rb", :line=>"56", :method=>"finished"}

The shutdown behavior was changed in #53 So this exception should not happen anymore.


Add Templates for issues, Pull Request and Code of Conduct

Templates will help to formalize the pull request and issue. This will help ongoing contributors to project and new community members.

@swissarmykirpan @isen-ng can you please take a look at this PR and assign reviewers.


Custom Checkpoint file extension

🚀 Feature
Atm, we have hardcoded .ckpt as a file extension for any checkpoint.
https://github.com/PyTorchLightning/pytorch-lightning/blob/db69d169e868451c16a4ee418f2de835ccce146c/pytorch_lightning/callbacks/model_checkpoint.py#L429
Proposed solution 1:
class ModelCheckpoint(Callback):
    FILE_EXTENSION = ".ckpt"

Proposed solution 2:
ModelCheckpoint(ext=''pt')

Should it be part of the filename?
Adding a new argument would require some justification I think.

Some previous discussion about this: https://github.com/PyTorchLightning/pytorch-lightning/pull/3163#discussion_r476644340

I agree with @awaelchli, but just need to handle some edge cases (don;t think we should support "." in filenames anway, no?)

I agree with @awaelchli, but just need to handle some edge cases (don;t think we should support "." in filenames anway, no?)

If we define it as propose in the description, all behaviors stay the same for now... And if use overwrite it is, it is his decision and responsibility

Should it be part of the filename?
Adding a new argument would require some justification I think.

I thought so too, but what if user wants the default filename created by PL but with a different extension? In that case it should be  filename=None.

well in such case you need to pass the instance of checkpoint call back anyway, so I would fo keeping untouched API inherit it...
class ModelCheckpoint(Callback):
    FILE_EXTENSION = ".ckpt"
    ...

class MyModelCheckpoint(ModelCheckpoint):
    FILE_EXTENSION = ".abc"
    ...

so you can later pass [ModelCheckpoint(), MyModelCheckpoint()]

I agree with @awaelchli, but just need to handle some edge cases (don;t think we should support "." in filenames anway, no?)

as you agree with it I have reverted the description to the original one :]

Proposed solution 1:
class ModelCheckpoint(Callback):
FILE_EXTENSION = ".ckpt"

I'd suggest this one

Ill happily work on this :)


NFLDB-Update not updating rosters

>>> C:\Python27\Scripts>python nfldb-update
-------------------------------------------------------------------------------
STARTING NFLDB UPDATE AT 2014-08-16 09:25:50.151000
Connecting to nfldb... done.
Setting timezone to UTC... done.
Updating player JSON database... (last update was 2014-08-13 00:07:18.078000+00:
00)
Loading games for PRE 2014 week 2
Downloading team rosters...
1/32 complete. (3.12%)Traceback (most recent call last):
  File "C:\Python27\lib\runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "C:\Python27\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "C:\Python27\lib\site-packages\nflgame\update_players.py", line 479, in <
module>
    run()
  File "C:\Python27\lib\site-packages\nflgame\update_players.py", line 403, in r
un
    roster.append(meta_from_soup_row(team, row))
  File "C:\Python27\lib\site-packages\nflgame\update_players.py", line 161, in m
eta_from_soup_row
    profile_url = 'http://www.nfl.com%s' % tds[1].a['href']
IndexError: list index out of range
`C:\Python27\python.exe -m nflgame.update_players --no-block` failed (exit statu
s 1)
done.
Locking player table...
Updating 5946 players... done.
Locking write access to tables... done.
Updating season phase, year and week... done.
Bulk inserting data for 5 games...
        Sending batch of data to database.

For some reason, the rosters aren't updating (it says 1/32 complete) and   there are some other errors. I'm not sure what is causing this.

"If it still doesn't work, could you please upgrade nflgame with pip install --upgrade nflgame and try it again? If it fails, please post the output message. There should be more details now."

Having an issue when updating nfldb for the 2016 season week 1. I was able to correctly run nfldb-update, but it didn't actually change the database to include 2016 week 1 data. I upgraded nflgame as you suggested and after retrying nfldb-update I got a much more robust looking update!:

C:\Users...\AppData\Local\Continuum\Anaconda2\Scripts>python nfldb-update
STARTING NFLDB UPDATE AT 2016-09-14 11:27:41.507000
Connecting to nfldb... done.
Setting timezone to UTC... done.
Locking write access to tables... done.
Updating season phase, year and week... done.
Adding schedule data for 321 games... done.
Bulk inserting data for 81 games...
Sending batch of data to database.
Sending batch of data to database.

that being said... still no update when running a query. The below returns empty. Any additional suggestions? Is it a problem I run python through spyder/anaconda stack?
import nfldb
import pandas as pd
db = nfldb.connect()
q = nfldb.Query(db)
q.game(season_year= 2016, season_type='Regular')
for g in q.as_games():
    print(g)

[empty]

Try updating your nfldb install and see if that helps anything.
pip install --upgrade nfldb

thanks for the speedy reply! this solved my issue:
pip install --upgrade nfldb


[rxjs] Add type for distinct

https://github.com/ReactiveX/rxjs/blob/master/src/operator/distinct.ts

Could you add the flushes?: Observable<any> parameter as well?
And add a test for the method please.

Closing in favor of #472 (sorry for the delay!)


Stats Async

Move stats calc to async and store json in memcaded
http://docs.celeryproject.org/en/v2.3.3/userguide/periodic-tasks.html#crontab-schedules
Necesaary, b/c build takes too long and times out dashboard

Getting cryptic segfault error that keeps on repeating.
Comming stats to memory...
[New Thread 0x7fffeedd3700 (LWP 16128)]
1

Program received signal SIGSEGV, Segmentation fault.
__memcpy_sse2_unaligned () at ../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S:37
37	../sysdeps/x86_64/multiarch/memcpy-sse2-unaligned.S: No such file or directory.
(gdb) quit


map.getCenter() does not work with polarstereograhic maps

Especially if one of the poles is within the bounds results are outside of the map. Currently I use this code to circumvent:
getCenter: function(map){

  var prj = map.options.crs.projection,
      sw  = map.getBounds()._southWest,
      ne  = map.getBounds()._northEast,
      psw = prj.project(sw),
      pne = prj.project(ne),
      x   = psw.x + (pne.x - psw.x)/2,
      y   = psw.y + (pne.y - psw.y)/2;

  return prj.unproject({x:x, y:y});

},

Works at least with EPSG:3413. L.ImageOverlay._reset() and ._animateZoom() have  same problem.

I think it might have been fixed in 1.0.0-beta.1, can you verify?

Like @mourner says, this looks like it has been fixed in current master, although I can't verify since I don't have a polarstereograhic map to test with.
Closing for now, but feel free to add more info if this is still a problem.


fix: tests for geth

Finally noticing that the travis tests dont pass because it can't find /bin/test.sh, not this PRs fault. But wouldn't hurt to fix.

Dope!
Notes from our convo on Slack:

some docs around how to setup etherbase for geth
tests fail when run with ganache (think due to the previous timeout issue)

for some reason the last (12th) iteration of should query normal case medHash==0x0 step 12 is failing; I don't think the submitter is responding correctly. Investingating

LGTM. Tests pass on ganache. :)


Fix: lsp crash caused by vfs loader

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y fix #760

2. What is the scope of this PR (e.g. component or file name):
tools/LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
lsp crash when close file.
The reason is that the receiver of vfs is dropped when creating a new LanguageServerState. When the file is closed, there is no object to accept the Message, causing panic.

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.82%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2300

Relevant Lines:
2619

💛  - Coveralls


Open sourcing the design assets

Instructions
Flow has really nice design language, especially the design of flow-playground and dev-wallet is top of its class in my opinion. It would benefit community to open source this design language ( to people are developing for flip-fest etc )
It will allow those changes to be consistent with the overall design language, and can speed up development for developers that lacking design capabilities.

yeah, i love the flow blockchain explorer! it'd be really nice to open source it + extend it all over the place!


deploy compendia docker to gh package registry

currently, binder seems to store images in its own container registry, though the open source version also accepts other registries.
Might be worthwhile to add github pkg registry as a registry to cut down on auth shenanigans, and enable this for closed repos.
Binder (and anything based on just Dockerfiles) is actually less reproducible than one might think, because it (presumably) still depends on the irreproducible state of package managers from which docker build builds the image.
A better way would be to actually save the build image for a release so that we can be sure that the precise compute environment can be reproduced.
An added advantage would be that users can quickly download the images on their own machines and run it from there, without the compute limitations of binder.
(might be possible now already).

overlap / duplicate of #55


Unified custom route data

Description
SFC custom block and JSX/TSX YAML format comments are not perfect method to custom route data, especially when I want to use imported data in route data:
import { mdiHomeOutline } from '@mdi/js';
const route = {
  meta: {
    btnProps: {
      tip: 'home',
      icon: mdiHomeOutline,
      order: 2,
      hideOn: 'mobile',
    },
  },
}

Suggested solution
custom route data in runtime code is maybe better method, it has natural framework-independence advantage, and support type check:
// src/pages/index.tsx
import type { RouteMeta } from 'vue-router';
import { mdiHomeOutline } from '@mdi/js';
export const route = {
  meta: {
    btnProps: {
      tip: 'home',
      icon: mdiHomeOutline,
      order: 2,
      hideOn: 'mobile',
    } satisfies RouteMeta,
  },
}
export default ...

Alternative
No response
Additional context
No response
Validations

[X] Follow the Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

If I add too much support to this is kind of thing which is framework specific, this plugin will become hard to maintained.
I personal will recommend using some existing solution like Remix to resolve that kind of requirement.

@hannoeru I don't think it is framework specific. Actually, merging custom data from page file with generated route from plugin in virtual module is feasible methods, which is what I do currently.
I used import.meta.glob to achieve it, just like:
// as a part of virtual module
const customs= import.meta.glob(
  ['~/pages/**/*.tsx', '!~/pages/**/components/*'],
  { import: 'route', eager: true },
);

of course, it will throw error when the page file don't export named route data, so we can add export route = {}  to solve it on transform hook.


Improved OmniSR detection

Changes:

Use the same set_scale_and_output_channels as for Compact. This means that we now support grayscale to RGB models.
Removed the ffn_bias parameter from the OmniSR class. This parameter was completely unused.
Detect all model parameters.
Added parameter detection tests.

I also removed dump.yml which I accidentally committed in #30.