A "marketplace" of language servers

As all the clients are supposed to be able to work with any language server, it would be interesting if they could all share a same "marketplace" where to search and fetch implementations of language server protocol. Example: I'm in Eclipse IDE, opening a .cs file, the language server "marketplace" would say "Do you want to use OmniSharp?", I press "Yes, thanks" and then OmniSharp is downloaded and installed and configured in my client so the .cs file editor gets features coming from this language server.

I think JSON, CSS server, etc should be installed as npm module. After that you could do just:
mpm install json-language
TypeScript 2.0 provides this features to install TypeScript definition @types. See https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/

What about servers that aren't npm modules, such as https://github.com/felixfbecker/php-language-server ?

IMHO, It should provide install with npm.

@angelozerr I don't think this is a good idea. There will be a great deal of grief if you try to contort every language's build and packaging ecosystems into the node module format. The fact that a language server implementation does not need to be implemented in node (or forced into its packaging format) is one of the strengths of a common language server protocol.
I think the direction Che has gone with this is a good approach. Containers can be used as the packaging format for language servers, and e.g. the Docker hub could be a "marketplace" of language server implementations. You can treat any language server as a black box exposed over a socket. Since all major development platforms (Win 10/OSX/Linux) support Docker already, cross-platform compatibility should not be a major issue.
Another alternative is to distribute language server implementations alongside scripts that can stand up a JSON-RPC service over each platform's equivalent of named pipes. This would eliminate some of the overhead of containers, but forces a lot of work onto the developers of language server implementations.

@mickaelistria This is a good idea, but I would take it a step further: instead of a having a "marketplace" where an LSP client would fetch different servers itself, why not have instead a "meta" LS that would be able to transparently serve requests for multiple languages. This has the obvious effect that it makes client implementation easier: so instead of each client having to learn how to deal with the marketplace, only the meta LS has to.
Furthermore, if we want language servers to be able to handle cross-language functionality, the correct way to this would be to abstract all the language interactions under a single LSP server.

@angelozerr That doesn't make much sense. The package manager / registry to be used is dependent on the language. The package manager's main job is to manage dependencies. A language server in TypeScript / JavaScript has a lot of dependencies through NPM, so it makes sense to install it through NPM. But a language server written in PHP has a lot of dependencies through Composer/Packagist, so it only makes sense to publish it as a Composer package, which I did. The VS Code extension is written in TypeScript, but installs the language server through Composer, which works totally fine.
I could publish this as an NPM package, but then I would have to publish it with dependencies included - and that would prevent soft versioning, which is a dealbreaker. It would be a nightmare to maintain because I would have to republish for every small dependency update.
The same goes for a LS in Java, it will have dependencies through Maven, or a C# LS that will have dependencies through NuGet.
So I'm clearly -1 on a uniform way to install.
But of course it would be nice to have a searchable, dedicated list of LS implementations instead of a wiki page, that link to the package on the respective registry.

@bruno-medeiros So you use a JavaScript package manager to install a package that then installs other packages through another package manager that you need to have installed on your PC in a postinstall hook? Because then why not install it with that other package manager directly? Alternatively: You use a JavaScript dependency manager to install a package, that has no JavaScript dependencies but tons of PHP dependencies, distributed in the package (and therefor version-locked). Both don't seem right to me.
LS will have runtime dependencies anyway. A Java LS will require that you have Java installed, so why not require Maven installed (which a Java developer likely both has installed anyway). A PHP LS will require PHP installed, so why not require Composer installed as well (which a PHP developer will likely have both installed anyway).

Inside of Che - with our repository, the workspaces where a language server will need to run varies by the user. We cannot predict or mandate the underlying operating system, or any dependencies.  So we have implemented a language server packaging approach where the only dependency is bash.  It's crude, but it's the lowest common denominator.  Then within the language server, the packager of the language server must provide the ability for the language server to install everything else that it needs.
Since our workspaces are defined by Docker, if a user provides the underlying dependnecies within their Docker image that is loaded, then our packager will not repeat download.  And this is why our codenvy base images are so big - we provide all dependencies for each type of platform.
But overall, for language servers to truly be portable across platforms, we should not require any dependencies.  Even the bash dependency is too much and we are thinking about POSIX shell.

@TylerJewell You shouldn't expect a language server to provide an install script that is catered to Che's use case. That install script would only be used by Che... VS Code for example has no use for a bash install script or a Dockerfile. You should rather use wrapper extensions like VS Code does, and that could then contain a Dockerfile and a launch script.

The language server does not provide the install script.  The language server "packager" does.  In the Che world, agents are dynamically added to / from an existing workspace, which is already running.  so the packager is the wrapper in bash around the  language server, and when the agent is deployed into an already running workspace, then it is activated to do its magic.
It is complicated as the bash script has to handle differerent OS issues.  One thing that we'd like to look at in the future is to have our agents running in their own containers side by side with a workspace, but so far performance for this configuration hasn't been the best vs. having the agent runnin natively within the worksapce container itself.

Because then why not install it with that other package manager directly?

Because the other package manager (Composer in that case) is language specific, and in this case "you" would need specific knowlege of how to work with Composer.
Note that we are not talking about a situation were a PHP developer wants to install a PHP LS and nothing else. In this scenario, yes, it makes more sense for the developer to install the PHP LS using Composer directly, no need for an extra layer or abstraction. But this is not the case we are talking about.
We are talking about a having an LSP client be able to install arbitrary LS's. For that to work, the client must not have specific knowlege about each LS - otherwise it would not be extensible. How would the client handle an LS, say for a new language that doesn't exist yet, but is developed in the future, has it own package manager, etc?
There would have to be some sort of language-indepedent abstraction for installing and updating LS's. This coudl could be NPM packages. It coud be bash script like @TylerJewell mentioned, for Ché - although this does not meet the requisites of being cross-platform. (it's POSIX only, as mentioned). Works for Ché world, but wouldn't necessarily work beyond that.

Yes correct - even for Che with being POSIX shell, this poses problems if th workspace continer is a windows container, which is now possible with windows 2016 server.  However, every byte of memory is something that we are very concerned about, and we had looked at npm and other package mangaers as a way to deliver language servers, and their footprints were all quite taxing.
Imagine a situation where we are running a single physical node and we are trying to load up 20 workspaces on a single azure server.  And each of those workspaces have varying agents for language servers and other stuff that we provide such as debuggers, ssh, and web terminal.  The overhead requirements add up quickly - so shell was a quick way for us to have a low impact to start.

@bruno-medeiros

We are talking about a having an LSP client be able to install arbitrary LS's. For that to work, the client must not have specific knowlege about each LS - otherwise it would not be extensible.

Or you have intermediate installers for each LS, that have knowledge about how to install the LS, and also knowledge about how to integrate into the desired environment. The LS itself should not tailor to a client. The VS Code extension will simply spawn the LS with PHP and ask the user to install PHP himself, a Che LS package might have a Dockerfile that sets up an environment. But the LS should not include a specific launch script or Dockerfile, it should only document how install and run it.

 It may
have  library deps, OS configuration requirements, need binaries on PATH,
expect configuration files, etc. The only sane way to distribute all of
this to a user is in an isolated container or VM, as Che does.
The ability to set up a container (or evem container system) does not
require bash, and can be implemented e.g. in powershell or a x-plat binary.
E.g. on Windows you'd need docker run -p lang-server-php and on Ubuntu
much the same.
On Oct 17, 2016 9:27 AM, "Bruno Medeiros"<EMAIL_ADDRESS>wrote:

Because then why not install it with that other package manager directly?
Because the other package manager (Composer in that case) is language
specific, and in this case "you" would need specific knowlege of how to
work with Composer.
Note that we are not talking about a situation were a PHP developer wants
to install a PHP LS and nothing else. In this scenario, yes, it makes more
sense for the developer to install the PHP LS using Composer directly, no
need for an extra layer or abstraction. But this is not the case we are
talking about.
We are talking about a having an LSP client be able to install arbitrary
LS's. For that to work, the client must not have specific knowlege about
each LS - otherwise it would not be extensible. How would the client handle
an LS, say for a new language that doesn't exist yet, but is developed in
the future, has it own package manager, etc?
There would have to be some sort of language-indepedent abstraction for
installing and updating LS's. This coudl could be NPM packages. It coud be
bash script like @TylerJewell https://github.com/TylerJewell mentioned,
for Ché - although this does not meet the requisites of being
cross-platform. (it's POSIX only, as mentioned). Works for Ché world, but
wouldn't necessarily work beyond that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/language-server-protocol/issues/76#issuecomment-254206929,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADgPyOJXYzxSDfY5qVIwVT3IabZrB0NWks5q03fMgaJpZM4KJo5S
.

@masaeedu That totally depends on the type of client. For Che, a Dockerfile makes sense. For VS Code, it makes much more sense to simply tell the user "hey, if you want to use the PHP LS, you need PHP installed". Setup is the responsibility of the client (or wrapper extensions), it's out of scope for the LS. The LS should only document the requirements.

Multiple people have referenced that a language server provider should just provide a Dockerfile and then be done.  While we have investigated this packaging approach, it poses limitations in a distributed environment.
Please assume that the project code that a language server will operate against needs to be accessible by the language server.  In a Che distributed world, each workspace is its own set of containers.  If the language server that the code depends upon is a separate container, then this poses some constraints on the underlying orchestration system to have the containers co-located on the same physical nodes (or at least for the orchestrator to ensure that the LS container and the ws container have the same shared mount point over a NAS) AND for certain project files to be accessible through shared volume mounts, which in some cases creates I/O performance problems.
So, let's please consider that packaging / installation of langugae servers may need to be done both in-process - inside an existing container and as a separate container.

That's exactly the complicated problems an LS should not be concerned with, but the client / wrapper extension.

@felixfbecker I don't understand why a Dockerfile is Che specific. Like I said before, a language server is a black box that speaks a particular language protocol. The goal is to start from nothing and have a language server running on an accessible port/named pipe/socket. Docker provides a x-platform approach to doing so. You deploy a file-for-file identical server that speaks the language protocol for a particular language. You don't need to worry about whether the PHP binary is installed within the container or it has the right extensions or whatever.

The LS itself should not tailor to a client. The VS Code extension will simply spawn the LS with PHP and ask the user to install PHP himself, a Che LS package might also have a Dockerfile that sets up an environment. But the LS should not include a specific launch script or Dockerfile, it should only document how install and run it.

I'm not saying otherwise. It's best that the LS should only concern itself with the LSP protocol, and yes, installation is beyond the scope of the LSP protocol. However, the sugestion is that there could be an additional protocol, an additional abstraction layer (the "marketplace" abstraction) that would handle installation/update/startup of arbitrary LSs. But this would be separate from the main LSP protocol, rather, it would just be something additional than could be developed on top of each existing LS.

@masaeedu Because no editor like VS Code, Visual Studio, Atom etc. will not spin up a container just for the LS, that would take way to many resources. In that way the Dockerfile is Che-specific, because it is only used by Che.

@TylerJewell The solution to this problem is volumes, which again work x-plat. While it is true this poses latency problems if you're running your containers in AWS europe, a reasonable fix for this is to simply run the containers on the user's machine.

@bruno-medeiros That's what I am saying - setup/installation/startup needs to be in a seperate registry with separate packages, and that registry must be per-client, because setup will be different for different client as I explained in my previous comment. For VS Code this registry already exists, it's the VS marketplace. Che just needs something similar.

Because no editor like VS Code, Visual Studio, Atom etc. will not spin up a container just for the LS

@felixfbecker Why not? We are discussing possible ways to package language servers, not discussing what is currently implemented. When you say "would take up way too many resources", this needs to be backed up with tests. Running 20-30 containers on my laptop does not result in a noticeable slowdown, and starting up a busybox container once I have the image downloaded takes a few milliseconds.

@masaeedu - It's diverging from the intention of the thread, but with the experience we have of running 500,000 workspaces on a distributed basis - we can confidently say that shared volumes is not the way to solve Docker container distribution problems :).
@felixfbecker - Che has its own registry.  We call it hte language server registry.  We mandate our own parameters for installation + configuration, but we expect total reuse of the language server.  It would be really nice, though, if we could consolidate on packaging / installation philosophies over time so that we can have language server providers provide a single (or two) packaging philosophies.  It'll speed adoption.

For VS Code this registry already exists, it's the VS marketplace. Che just needs something similar.

Yeah but those are all client-specific registries. Eclipse would needs it's own registry too, vim/emacs and every other editor/IDE out there. And each registry would need an extension for each LS...  The interesting project is to have a "marketplace" registry that is client-agnostic, much like LSP itself is client-agnostic.

@TylerJewell Here's the thing though, the typical user is not running 500,000 workspaces on their local machine, or using a number of language-servers at that scale simultaneously. It is possible that Che would need some Che-specific configuration in addition to the Dockerfile to make this scale well, but for typical editors (sublime, vim, VS Code, Atom, etc. etc.), a Docker container with the source volume mounted is performant enough for day-to-day use.

However, every byte of memory is something that we are very concerned about, and we had looked at npm and other package mangaers as a way to deliver language servers, and their footprints were all quite taxing

@TylerJewell Interesting, I didn't consider the performance aspect. Have you looked at Cargo, Rust's package manager? It's cross-platform, compiled natively (thus generally faster), and also not GC-based (so also smaller memory footprint). True, its intended purpose is to manage Rust source code and its depedencies, but maybe it could be used just for distribution purposes?

@masaeedu - the use cases for the language servers that I have seen are:

LS / workspace in a distributed system running many workspaces - the Che model.
Shared LS - in a distributed system where there are many clients sharing a single LS for different underlying code projects.  This is the orion model, which has its own problems, but they envision having many shared volumes.
LS / workspace in a local system running a single ws.

I think it's good to state the uses of language servers in the wild.  Any proposed or anti-proposed solution should be aware that this is happening.
@bruno-medeiros - I have not studied Cargo in any depth, other than doing a hello world with it about a year ago.  I think for something to replace shell / bash for us, our pre-req would be that it works on every distro of linux, mac, and windows.  If cargo compiles natively to these platforms, then that is certainly an option.  I don't think we thought of native compiled options yet, but worth a good dialog on it.

Additionally to the definition of how to provision the langauge server, a marketplace would also require to define how to connect to the provisioned server. As there are already sdio, pipes, sockets being used and big chances to have some HTTP or other network-based transports, it's also something not trivial.
@TylerJewell Do you know how does Che define the connection? I guess Che has some conventions on this regard, or does it already have some relatively reusable format to describe that?

@mickaelistria - good question.  I am not sure the answer.  I do know that within Codenvy, our on prem distributed system, we hvae implemented an HTTP server for hosting language server installations.  When a workspace is deployed via Docker, the workspace checks for a volume mount to get the language server and if that fails, then it connects to the hosted codenvy server to connect and download the server.
Once the language server is installed and started.  Then there is some way that our editor detects its usage.  I suspect that we have deployed a server-side API that allows the editor to query the workspace to see the status of language servers and then once the server is active, hands over to the editor.  If you want specifics, I can ask Eugene Vidolob and Anatoliy Bazko.

@TylerJewell Have you considered using an orchestration tool like Ansible/Chef/Puppet to specify the language server configuration instead of bash scripts? That way the configuration can be applied outside of Docker containers, and depending on what surface of the configuration API you use, can even run it directly on Windows boxes.

We have thought about puppet - we have a lot of experience with running distributed puppet systems and aware of what it is capable of doing.  But we do all of our work for configuration now inside of docker containers, so to apply that sort of configuration, we'd do it in a container outside of the workspace container and then inject it in.  We have explored doing that, or potentially having the codenvy / che server host specialized configurations that are downloaded based upon the OS distribution where the language server is intended to run.  But there is some configuration like this that is possible.  We will keep experimenting, but we will look for something that gives us the most cross-platform, highly distributed flexibility, and allows language server packagers to package any language server as simply as possible.

I've given another round of thought about it, and in any case, I'm quite skeptical about the possibility and value to create a marketplace of language servers that goes beyond the wiki page.
Integrating language server will always require some integration/packaging effort, that will always require some integration effort from someone working on the target tool, according to the tool specificity (Che will prefer docker images, whereas Eclipse IDE will prefer locally installed tools with STDIO, whereas some language servers offering analysis on the Cloud as SaaS will definitely require a remote network stream...). I find the idea of an interoperable marketplace of LS very expensive to set up, hard to be fully universal, and really not something that would help end-users (who don't care about language servers as it's an implementation detail of a language support).
The wiki page is IMHO a very good and sufficient approach.
As I'm the initial reporter of this issue, I'm tempted to close it; but I'm leaving it open to keep potential disucssions going on. But I wouldn't mind if project owners close it for me ;)

@mickaelistria I agree with our statement. I will close the issue. If someone feels strongly about this please comment here and I am willing to reopen.


Generated test assets import older version of a module

Note the import to the v1 armcompute module.
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/resourcemanager/compute/armcompute/go.mod#L8
This is due to live test importing it.
https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/resourcemanager/compute/armcompute/virtualmachinescalesets_client_live_test.go#L16
It should be importing the latest major version (v3 at this time).
I didn't check other tests so this might not be the only occurrence.

Same is true for go get installation instructions in the README.  https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/resourcemanager/compute/armcompute/README.md


Features/batch

TableBatchOperation Support
Continuing work started by @davidroberts63 in PR #69
Summary of changes
New Class
Added an AzTableBatchOperation class that wraps the [Microsoft.Azure.Cosmos.Table.TableBatchOperation] class.  It keeps a separate instance for each partition of the table, since operating on multiple partitions is not supported in one batch operation.
Functions
New functions

New-AzTableBatch
Creates and returns (and optionally populates) a new AzTableBatchOperation class to use with subsequent commands.
Invoke-AzTableBatch
Iterates over each partition in the AzTableBatchOperation object and invokes the related batch operation

Updated functions

Add-AzTableRow
Update-AzTableRow
Remove-AzTableRow

These functions now support passing an AzTableBatchOperation object instead of a table object
Tests
New tests for New-AzTableBatch and Invoke-AzTableBatch.
Updated tests for the existing functions to test batch functionality
Docs
Updated docs for existing functions and added new docs for New-AzTableBatch and Invoke-AzTableBatch
Hopefully this is helpful.  Please let me know if there's anything you'd like changed.

Thanks @bszimmer, I'll review it.

@paulomarquesc - did you have a chance to review this yet?

@paulomarquesc - did you have a chance to review this yet?

Not yet.


feat(meta): Client failover

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
https://github.com/risingwavelabs/risingwave/issues/6787
PR based on https://github.com/risingwavelabs/risingwave/pull/7049. Only merge after that one is merged.
Checklist

[x] Client can connect against leader on original connection
[x] Client can handle leader failover
[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] Det Sim tests should also run with 3etcd-3meta-1cn-1fe
[ ] Det Sim tests should also kill meta node if using 3etcd-3meta-1cn-1fe

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)

Codecov is complaining that coverage decreases. I assume that this is ok, since we also relied on relied on sim testing in  feat: introduce ElectionClient trait for meta. Please correct me if I am wrong @shanicky @yezizp2012

Good job! No worries about the code coverage. @shanicky also submitted a PR #7389 to support service discovery(including client failover). After a quick look at both of your pr's, I believe you have implemented some common functionality, except for inconsistencies in where you update the meta leader address information.

in the k8s deployment environment, the clients in this PR will fetch and refresh the meta leader address from the load balance service.
In other deployment environments, #7389 will have a bypass logic to refresh leader address from configured and cached meta members. This could cover some scenarios of migration in non-k8s environments.

I think both implementations are necessary as we discussed earlier, and need a configuration parameter to determine which path to take, such as --meta-service-mode=lb/group. the first path is taken when mode is lb, the second when group.
Besides, I think starting risingwave via risedev belongs to non-k8s deployment, so I prefer not to introduce nginx in risedev, config --meta-service-mode=group and leave it to the implementation of the second way.

Thank you very much for the feedback. I will have a look at this on Wednesday after my vacation :)

Closing this PR as duplicate work 😞


Is the name of the project correct?

Is the name of the project correct?

Actually, yes. It's inspired on Metis from Greek mythology.

Actually, yes! It's a pun about serving Java.


Removed forms-MAX_NUM_FORMS POST data in docs.

The field is ignored server-side and only exists as a client-side
convenience. Removing it slightly simplifies the documentation and
avoids some distractions.

Super, thanks for the quick reply @jdufresne. I'll squash this down and pull it in.


fix(CheckBox): Avoid resource name clash for Path Data resources with xamlmerge

closes https://github.com/unoplatform/nventive-private/issues/357
PR Type
What kind of change does this PR introduce?

Bugfix

Description
Two resources existed in Uno.Material with the key CheckGlyphPathStyle, one in CheckBox.xaml and one in Flyout.xaml. As a result of the XamlMerge, there can be only one true CheckGlyphPathStyle so the Flyout Path Data was being used for the CheckBox's Check Glyph data

@mergifyio backport release/stable/1.3


feat(axelar-gateway): increase gateway coverage and add coverage report

AXE-5747

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.56%. Comparing base (41256ea) to head (119bc0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   95.84%   97.56%   +1.71%
==========================================
  Files          26       26
  Lines        1493     1518      +25
==========================================
+ Hits         1431     1481      +50
+ Misses         62       37      -25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

add scope to PR title feat(axelar-gateway): ...


🐛 [Codex] Codex v1.6.9 is should not be used.

Description
Hi, it's AJ the author of Codex.
Your configuration relies on Codex v1.6.9 but it was behaving badly on the network and i've removed it from dockerhub and pypi. I'd appreciate it if you would update your config to use a more recent version.
Reproduction steps
Looking at the config here:

https://github.com/alexbelgium/hassio-addons/blob/master/codex/config.json#L109

Addon Logs
No logs. I've never run HA.

Architecture
aarch64
OS
HAos

Thanks! Updated

Thanks!


Inconsistent documentation across dockerhub and github

In Docker registry it says that this server has V+ support
https://registry.hub.docker.com/r/lloesche/valheim-server/
but in github repo it seems to be missing and when passing VALHEIM_PLUS=true it does not create a valheimplus directory under /config folder as it is stated in docker docs.
I would really like to modify the server data rate value but it seems that i cant at the moment.

The V+ support is still in review here #91
If you want to have the V+ support with this docker image, you hall to docker pull lloesche/valheim-server:dev
For the latest corresponding documentation, check the 'dev' branch on github.
Keep in mind that Valheim updated this morning with :

Updated socket-backend
That will probably have an impact on the data rate workaround we could use until now.

@ShintoTuna Dockerhub is set up for automated builds for this repo. Dockerhub will display the README.md of whatever branch it last built. It just so happens you opened Dockerhub after it had built the dev branch. Not much to be done about.


Enable noUncheckedSideEffectImports

This catches errors such as:
import 'vs/editor/noSuchFile';

Previously these were unreported

Blocked by https://github.com/microsoft/vscode-languagedetection/issues/26

Will hold off on this until the esm changes


Feature/deployment helper events processor deletion

Description

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[*] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (existing code being refactored)
[ ] This change requires a documentation update

Submission Checklist

[*] Build Verified
[*] Bundle Verified
[*] Lint passing
[*] Unit tests passing
[*] Integration tests passing
[*] Change logs generated

Additional Notes:

After talking with @bahavar we realize this PR is needed by the customer when a cloudformation stack is to be deleted.

@komushi just realized I had not published my review therefore my above comments related to this PR were not viewable.

Closing due to lack of activity.

@komushi  Can you please provide more information on request above by November 15th.


Incorrect count of closed  tags

Re: Waypoint: Wrap an Anchor Element within a Paragraph
http://www.freecodecamp.com/challenges/waypoint-wrap-an-anchor-element-within-a-paragraph
It seems the expectation is that one would create a new paragraph tag with an element within.  However, if I were to insert the anchor tag within an existing
 tag, it doesn't satisfy the "Be sure that each of your p elements has a closing tag" requirement.
In other words, the following code evaluates to incorrect:

    Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.
    Click here for cat photos.

It seems that you're just counting the number of
 tags as I'm able to make that condition pass by simply adding closing
 tags (without ever opening them) and pass the challenge.
    Click here for cat photos

This evaluates as correct even though it obviously isn't.  It might be better to check that the number of closing tags match the number of opening tags instead of checking the absolute count of closing
 tags.

Good point. I figured out a way to do this with our one-line Chai.js tests, and I'm going through and retrofitting our curriculum right now. Thanks!


Header parameter "kid"

We are implementing a key rotation strategy for our auth server, and need to be able to specify the kid (key id) JWT header parameter. As of 1.0.4 this cannot be set with the spring-security-jwt JwtHelper. https://tools.ietf.org/html/rfc7515#section-4.1.4
I notice between 1.0.3 and 1.0.4 the typ header parameter was added. Might kid also be added in the near future?
Thank you.

I'll add that this is part of the key rotation epic in UAA

Thank you @william-tran, it is. Link to the backlog story for interested parties: https://www.pivotaltracker.com/story/show/107773584

I guess you can always put it in the body of the token until the header is available.

@dsyer From the perspective of clients that are decoding and verifying JWT tokens themselves, it would be a breaking change for the key ID to first be in the body and then be moved to the header.

Not if they knew about the change. If they could tolerate change, eg. if they were built using this library, they could adapt, surely?

@dsyer Our API is provided as a set of JSON endpoints, and we make no assertion that clients should use a particular library.

Adding a new field that the user controls to the header is kind of a bigger deal than the "typ" was ("typ" is read only and optional). I think I managed it without breaking the public API. There's a new method JwtHelper.encode() taking a Map<String,String> which are added verbatim into the headers. To decode and verify a token you would need to call the decode() method, extract the headers and parse them to get the key id and then call decodeAndVerify() with the signature verifier.
There is a new 1.0.5.RELEASE with the new features. I put it in repo.spring.io but not in Maven Central yet, so you have a chance to try it out before I push it to the rest of the world if you want.

@dsyer Any idea when you'll push the 1.0.5.RELEASE to Maven Central?

Done. Thanks for the reminder.

<EMAIL_ADDRESS>


Fix test components build

Exclude test-components/components/target from workspace members
Add test components to vscode rust-analyzer.linkedProjects
Write adapted test components to new path instead of overwriting modules

oops, that last commit doesn't actually...work...


Use external ical.js

The built-in version of ical.js has several bugs.
Fix https://github.com/heskja/MMM-CalendarWeek/issues/63

Wait, I have sent my PR too quickly.

I got this by just git pulling
`[25.11.2023 19:08.01.480] [ERROR] (node:23812) UnhandledPromiseRejectionWarning: Error: Cannot find module './vendor/ical.js'
Require stack:

/home/pi/MagicMirror_modules/MMM-CalendarWeek/calendarfetcher.js
/home/pi/MagicMirror_modules/MMM-CalendarWeek/node_helper.js
/home/pi/MagicMirror/js/app.js
/home/pi/MagicMirror/js/electron.js
/home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
at node:internal/modules/cjs/loader:1084:15
at Function. (node:electron/js2c/browser_init:2:117419)
at Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
at node:internal/modules/cjs/loader:929:27
at Function._load (node:electron/js2c/asar_bundle:2:13327)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at require (node:internal/modules/cjs/helpers:110:18)
at Object. (/home/pi/MagicMirror_modules/MMM-CalendarWeek/calendarfetcher.js:8:12)
at Module._compile (node:internal/modules/cjs/loader:1271:14)
at Object..js (node:internal/modules/cjs/loader:1326:10)
at Module.load (node:internal/modules/cjs/loader:1126:32)
at node:internal/modules/cjs/loader:967:12
at Function._load (node:electron/js2c/asar_bundle:2:13327)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at require (node:internal/modules/cjs/helpers:110:18)
at Object. (/home/pi/MagicMirror_modules/MMM-CalendarWeek/node_helper.js:10:23)
(Use electron --trace-warnings ... to show where the warning was created)
[25.11.2023 19:08.01.482] [ERROR] (node:23812) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)`

Could have been due to some other instructions to remove ./vendor/ical.js
With that restored, new error occurred
`[25.11.2023 19:53.09.351] [ERROR] (node:24269) UnhandledPromiseRejectionWarning: Error: Cannot find module 'rrule'
Require stack:

/home/pi/MagicMirror_modules/MMM-CalendarWeek/vendor/ical.js/node-ical.js
/home/pi/MagicMirror_modules/MMM-CalendarWeek/vendor/ical.js/index.js
/home/pi/MagicMirror_modules/MMM-CalendarWeek/calendarfetcher.js
/home/pi/MagicMirror_modules/MMM-CalendarWeek/node_helper.js
/home/pi/MagicMirror/js/app.js
/home/pi/MagicMirror/js/electron.js
/home/pi/MagicMirror/node_modules/electron/dist/resources/default_app.asar/main.js
at node:internal/modules/cjs/loader:1084:15
at Function. (node:electron/js2c/browser_init:2:117419)
at Module._resolveFilename (/home/pi/MagicMirror/node_modules/module-alias/index.js:49:29)
at node:internal/modules/cjs/loader:929:27
at Function._load (node:electron/js2c/asar_bundle:2:13327)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at require (node:internal/modules/cjs/helpers:110:18)
at Object. (/home/pi/MagicMirror_modules/MMM-CalendarWeek/vendor/ical.js/node-ical.js:27:13)
at Module._compile (node:internal/modules/cjs/loader:1271:14)
at Object..js (node:internal/modules/cjs/loader:1326:10)
at Module.load (node:internal/modules/cjs/loader:1126:32)
at node:internal/modules/cjs/loader:967:12
at Function._load (node:electron/js2c/asar_bundle:2:13327)
at Module.require (node:internal/modules/cjs/loader:1150:19)
at require (node:internal/modules/cjs/helpers:110:18)
at Object. (/home/pi/MagicMirror_modules/MMM-CalendarWeek/vendor/ical.js/index.js:3:12)
(Use electron --trace-warnings ... to show where the warning was created)
[25.11.2023 19:53.09.352] [ERROR] (node:24269) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)`

Adding

   "rrule":"^2.7.1",

to package.json solved it. New PR on the way.

What I noticed is that my calendar events are 1 hour off.
I live in UTC+1 and calendar seems to show UTC.
Seen something similar?


route not found (404 error)

i've SPA in /public folder and in routes.js
Route.any('*', async ({ response }) => {
return response.download(Helpers.tmpPath('public/index.html'))
})
go to http://localhost:3333 everything works fine,
but got 404 when go to http://localhost:3333/home
it is correct to use '*' as wildcard route?

Do you have this file inside tmp/public/index.html?

got it, update the path as below every thing works now.
return response.download(Helpers.tmpPath('../public/index.html'))
thanks.


GitHub Follow button does not render in footer

Steps to reproduce:

Navigate to jupyter.org
Go to About or Resources page
Go back to Home page by using the browser's back button
Scroll down to footer

Getting the following in my console:

Unable to reproduce this in any of the browsers so I am going to close for now.


Update k8s test matrix to include 1.{19,20,21}

According to https://github.com/weaveworks/kured/#kubernetes--os-compatibility main should be compatible to 1.19.x, 1.20.x, 1.21.x, but that's not what we're currently testing in CI.

Good catch!!!

Kind node for 1.21 is not yet published on dockerhub 1. Either we wait for it, we help update upstream, or we move towards building our own. As kind contributors have been historically good at maintaining those containers, I suggest we wait to update to kind 1.21. It shouldn't prevent us from readying our branch for 1.21 though.

Perfect - that makes sense!

kind-cluster-1.21.yaml will have to be created in https://github.com/weaveworks/kured/tree/main/.github  when the kindest node v1.21.0 is out.
we need to then add the 1.21 to the matrix in the github workflows.

See also https://github.com/kubernetes-sigs/kind/issues/2188

→ https://github.com/weaveworks/kured/pull/349


feat: generate open graph image in netlify edge function

Prerequisites checklist

[x] I have read the contributing guidelines.

What is the purpose of this pull request?

Generates an open graph image. Improve the experience of previewing documents in social media.
What changes did you make? (Give an overview)
It consists of six parameters.
https://github.com/eslint/eslint.org/blob/9a7793b41a1ba953b9bba4799853246e29975c14/functions/og.tsx#L30-L36
/og?title=Core%20Concepts&summary=A%20pluggable%20and%20configurable%20linter%20tool%20for%20identifying%20and%20reporting%20on%20patterns%20in%20JavaScript.%20Maintain%20your%20code%20quality%20with%20ease.%20&is_rule=false&recommended=&fixable=&suggestions=

/og?title=no-div-regex&summary=A%20pluggable%20and%20configurable%20linter%20tool%20for%20identifying%20and%20reporting%20on%20patterns%20in%20JavaScript.%20Maintain%20your%20code%20quality%20with%20ease.%20&is_rule=true&recommended=false&fixable=code&suggestions=

Related Issues
Close https://github.com/eslint/eslint.org/issues/362
Is there anything you'd like reviewers to focus on?
It can be abused, although that doesn't mean much.

A small suggestion would be to configure ellipsis at the end so that it doesn't overflow when there is large number of text? Other things LGTM. Great work 🎉


test issue please ignore

lorem ipsum
EDIT: no more dependency

Working perfectly on issues. cc @z0al @naveen521kk


Add EVSE Test Plan

We need a test plan for the EVSE cluster.
There is a PR here on chip-test-plans repo:
https://github.com/CHIP-Specifications/chip-test-plans/pull/3709

This can be closed now - EVSE test plan made it into 1.3


iOS native view is not rendered when haze is applied

Information

Haze version: 0.7.2
Platform: iOS (iPhone 15 Pro simulator running on iOS 17.2)

I want to blur all the contents on the screen below a snackbar, on Android it works, but on iOS,
when there are composables that contain implemented iOS native views, they are not rendered.
The blur effect itself is correct.
Expected Behavior
on Android, it works.
Screen_recording_20240620_193618.webm
Actual Behavior
on iOS, the Toggle is broken only during haze is used.
https://github.com/chrisbanes/haze/assets/167203772/113ecdb1-3333-4010-abbd-c601b09c200a
Steps to Reproduce the Problem

implement a native iOS view:

// ThemedSwitch.ios.kt
@Composable
actual fun ThemedSwitch(
    checked: Boolean,
    onCheckedChange: (Boolean) -> Unit,
) {
    val appContext = koinInject<AppContext>()
    val viewModel = remember { SwitchViewModel(onCheckedChange) }
    LaunchedEffect(checked) {
        viewModel.isChecked = checked
    }
    UIKitViewController(
        modifier = Modifier.size(55.dp, 33.dp),
        factory = { appContext.uiViewControllerContext.componentFactories.switchFactory(viewModel) },
        update = {},
    )
}

struct SwitchView: View {
    @ObservedObject var viewModel: SwitchViewModelWrapper

    var body: some View {
        Toggle("", isOn: $viewModel.isChecked)
            .tint(Color(uiColor: ColorHelper().toUIColor(color: Colors().brandNormal)))
            .labelsHidden()
            .padding()
    }
}

View model implementations are omitted because it's not related, I think. If you need it please tell me.

Use haze for the snackbar

// App composable
AppTheme {
    GuardSignIn { isLoggedIn ->
        val initialScreen = remember(isLoggedIn) {
            if (isLoggedIn) MainScreen.createHome() else SignInScreen
        }
        Box(
            modifier = Modifier.fillMaxSize()
                .background(brush = Colors.gradientBackground)
                .haze(koinInject()) // the app-wide HazeState
        ) {
           // screen contents that need to be blurred
        }
    }

    koinInject<SnackbarController>().Compose()
}

// SnackbarController.Compose()
Box(
    modifier = Modifier
        .padding(16.dp)
        .fillMaxWidth()
        .height(56.dp)
        .hazeChild(koinInject<HazeState>(), shape = shape, style = HazeStyle(blurRadius = 10.dp))
        .shadow(elevation = 8.dp, shape = shape),
) {
  // contents
}

@chrisbanes , is that something 0.9 is fixing or is there no possibility for this topic?

I haven't tried, but it might help

@chrisbanes I tried it and it seems 0.9.0-alpha07 works somewhat-ish, just materials wasn't something I could use as it was showing some weird effects (almost fully translucent). Here is a SwiftUI map in the background within a Scaffold with Floating Action Buttons with custom HazeStyle.
style = HazeStyle(
     backgroundColor = FloatingActionButtonDefaults.containerColor,
    tint = FloatingActionButtonDefaults.containerColor.copy(alpha = 0.3f),
    blurRadius = 148.dp,
),

The thing is that this looks different on iOS and Android and also I would assume that with such a high blurRadius I wouldn't see any text through at all, but it's readable on both? (look at the bottom FAB, I was playing around with that one)

Should I create a new issue or do you want to use this here?

My guess is that the map content isn't actually being drawn in the blur iOS, and what you're seeing is the white background being blurred.
I need a sample to see what's really happening though. If someone wants to send a PR for a quick MapView sample that would help immensely. Otherwise I'll see if I can find some time.

Yeah that would work, or a PR adding it to the samples in this repo. Either works.

https://github.com/rschattauer/compose_multiplatform/
Branch: broken-haze-on-map
Feel free to copy stuff as you wish into haze as a sample.
In the README it's stated on how to add your private MapBox keys.
There is val useUIKitInsteadOfSwiftUI = false that you can make true to also see the same (not working) effect on UIKitView instead of UIKitViewController if that even makes a difference.
On the home and map screen you will find a top bar that has the haze effect activated.
Android:

iOS:

If there is anything else I can help you with, please let me know.


Decouple @odk/xpath API from XML/browser DOM

I'd like to explore the possibility of decoupling the @odk/xpath API from the XML/browser DOM API. Specifically for the purposes of this issue, the decoupling would involve accepting a different type for contextNode with the following considerations:

Provide a significantly more limited interface, restricted to only those semantics of a node which satisfy the implemented XPath semantics. This interface would likely still be "a DOM", in the sense of representing a traversable tree of nodes consistent with the XPath node types, but it wouldn't necessarily be "the DOM".
A simpler interface would allow us to more easily reason about potentially substituting node implementations. And being able to more easily reason about this, we could better evaluate if and how to reap other potential benefits (discussed below).
It's an open question whether this simpler interface should attempt to maximize compatibility with "the DOM" (i.e. so that an unmodified XML/browser DOM reference is assignable), but my gut instinct is that it should not be a requirement though it may be nice to have. If we pursue this, and choose not to maximize compatibility, we'd still have the option of providing a compatibility layer e.g. wrapping the underlying XML/browser DOM APIs.

Minimize incidental complexities of different interfaces for different node types. This is a source of significant incidental complexity in the evaluation implementation as well, and it's highly error prone. A trivial example of this kind of incidental complexity is the lack of consistent, direct access to certain properties, such as ownerDocument. Another good example is the combinatory explosion if slightly different ways to access node data (textContent, innerText, children, childElements, data, value, ...).

Require (whether enforced or not) certain guarantees which aren't assumed in the XML/browser DOM compatible API we currently provide. Top of mind here:

Require that the entire context is read-only for the entire scope of a given evaluation. This would unlock a wide variety of potential performance improvements without baking in a lot of domain-specific assumptions.

Require that evaluation is always performed against a context node which is fully intact/connected to its root. This would overlap both with API simplification and performance.

Provide specific affordances for additional optimizations, e.g. the ability to designate certain aspects of a context tree permanently immutable.

Make callable aspects of the API explicit, either by choosing to express them as methods rather than as property accessors, or by designating them as getters with a clear indication that they are anticipated to have an associated runtime behavior. In the most minimal version of this, it would help us reason about where certain accesses are more expensive than others.
In a broader vision, this would allow us to provide a reactive implementation of nodes, e.g. allowing a reactive graph of dependencies to be established automatically as they're accessed while evaluating an expression referencing them. This in turn could potentially allow for other valuable use cases, such as producing an evaluation history log which can be referenced directly back to e.g. instance nodes—both valuable for direct debugging, as well as potentially enriching bug reports from users.

Done in #245


refactor(worker): use existing isBuild flag

Description

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

I think that if we do this refactoring, it would be better to invert the two branches so it is more clear
if( isBuild ) {
  ...
}
else {
  ...
}

@patak-js  Yes, I did consider this writing style but it will make a litter noise to git blame. I've tried and seems the noise is small. Done 👍🏻


[Bug] Replace the speaker, video and microphone icons to 24px

Purpose

Update the speaker, video and microphone icons
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

1. Navigate to the Lobby screen
2. Check video, microphone and speaker icons
3. Mute/unmute mic, enable/disable camera, select a speaker
4. Join or start a call
5. Repeat step 2

What to Check
Verify that the following are valid

Icons on the Lobby screen
Icons on the Call screen for different orientations

Tested LGTM


Unable to delete Windows shared (SMB) folder

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

Open a shared folder.
Delete a file or folder in the tree view.
An error occurs when you press "Move to Trash (I cannot do it)".

Expected behavior:
The object can be deleted.
Actual behavior:
The object cannot be deleted.
Reproduces how often:
anytime
Versions

atom

PS > atom --version

 Atom    : 1.41.0
Electron: 4.2.7
Chrome  : 69.0.3497.128
Node    : 10.11.0

apm

PS > apm --version
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.41.0
python 3.8.0
git 2.24.0.windows.2
visual studio

OS

Edition: Windows 10 Pro
Version: 1809
Installed: 2019/11/12
OS Build: 17763.864

Additional Information
What is clear from the confirmation message and the error contents is designed based on the local object, not the remote object.

Atom doesn't allow deletion of files period, regardless of where they are located. If it can find a "recycle bin" and send the file there it will allow you to "Delete" a file, but only then. If it can't move the file to your operating system's location for recoverable files it will refuse to remove the file.
This is a compromise that unfortunately leads to some confusion like this about it, but not one that we will be changing.
Thanks for taking the time to file an issue!


Add more settings utilities

KeyboardKit should have a way to manage various keyboard settings between the app and extension, and persists using @AppStorage a .standard or app group-based defaults.
I'm thinking about adding observable settings classes that can be directly bound to a SwiftUI view and make it possible to setup the keyboard context from these settings.
For instance:

KeyboardAudioSettings
KeyboardFeedbackSettings
KeyboardLayoutSettings
KeyboardLocaleSettings

By then having a way to register your own settings to the controller, this would be a very easy way to configure your keyboard without having to manually change providers.

I will add the types that I create as I develop the new KeyboardKit app.

This will be available in a later 7.x version

KeyboardKit 8.7 will get a brand new settings concept, with observable settings classes that automatically persists changes and lets KeyboardKit sync their values with the corresponding contexts whenever a setting is changed.
KeyboardKit Pro will add convenient settings screens and forms that use these types.
This is available in the v8.7 branch.


Feature request: SSR

Great package, unfortunately this does not work out of the box with SSR because you use new Image()

This is stopping me from being able to use this package with gatsby because of the Image issue


Argument of type '{ devtools: { enabled: boolean; }; runtimeConfig: { abc: string; }; }' is not assignable to parameter of type 'InputConfig<NuxtConfig, ConfigLayerMeta>'

Environment

Operating System: Linux
Node Version:     v20.6.1
Nuxt Version:     3.7.4
CLI Version:      3.9.0
Nitro Version:    2.6.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, runtimeConfig
Runtime Modules:  -
Build Modules:    -

Reproduction
add in the Nuxt config
export default defineNuxtConfig({
    devtools: {enabled: true},
    runtimeConfig: {
        abc: ''
    }
})

in pure vue project created by
npx nuxi init my-project

Describe the bug

In Webstorm I see problems with a typescript like this:

TS2345: Argument of type '{ devtools: { enabled: boolean; }; runtimeConfig: { twilioAccountSid: string; }; }' is not assignable to parameter of type 'InputConfig<NuxtConfig, ConfigLayerMeta>'.   Object literal may only specify known properties, and 'runtimeConfig' does not exist in type 'InputConfig<NuxtConfig, ConfigLayerMeta>'.Webstorm

Additional context
this code works, but my issue is about typescript warnings in the IDE
docs with presented syntax https://nuxt.com/docs/guide/going-further/runtime-config
Logs
No response

Would you check you are using the most recent version of Webstorm?

I was using Nuxt Plugin 2.0.2, now updated to 2.0.6 - this does not help
Webstorm 2023.1, now updated to 2023.2.2 and this helped.
Now after updating to the latest webstorm, it works. Thanks.


Scroll back not working

Scrolling calendar back to previous month is only possible after scrolling forward.
Tried with ion2-calendar/demo (Android).

Yes, I have the same problem

Does anyone have a fix for this issue?

I believe I've had the same issue. Here is what I did to allow for scroll back without scrolling forward first, I hope it helps with this issue.
   const options: CalendarModalOptions = {
      pickMode: 'range',
      title: '',
      from: moment().subtract(1, 'months'),
      canBackwardsSelected: true,
      defaultDateRange: {from: moment().format('YYYY-MM-DD'), to: moment().format('YYYY-MM-DD')},
      defaultScrollTo: moment(),
    };

    this.myCalendar = this.modalCtrl.create(CalendarModal, {
      options: options
    });

Basically I set the from option to 1 month less then my default selection then set defaultScrollTo to the default selection date (not sure if this helps but I just did it to make sure)

, I have the same problem  :(

@IT-MikeS Your hacky solution works but this way I can't disable future dates anymore using to option.

I have that same problem too :( Can somebody help us please???


Player actors "action bar" is not working

For some reason only NPC action bar is automated. When a player uses action, bonus, reaction the bar does not update automatically.
dnd5e-helpers.js:2034 Uncaught (in promise) TypeError: Cannot read property 'actor' of undefined
at Function.ReactionApply (dnd5e-helpers.js:2034)
at Function.ReactionDetect_preCreateChatMessage (dnd5e-helpers.js:2106)
at dnd5e-helpers.js:733
at Function._call (eval at  (libWrapper-error_listeners.js:56), :4:14)
at Function.call (foundry.js:179)
at ClientDatabaseBackend._preCreateDocumentArray (foundry.js:8577)
at async ClientDatabaseBackend._createDocuments (foundry.js:8493)
at async Function.createDocuments (document.mjs:331)
at async Function.create (document.mjs:430)
at async Item5e.doItemRoll (itemhandling.js:372)

My experience is probably related although slightly different. Running in a world with no other modules. I start a combat, then make an actor roll an attack (as if using a reaction) and the following message is given in console:

No reaction status appears, and the action bar does not show despite being switched on (and not suppressed). All actors in my scene were PCs.

Thanks for the report. I didn't run into this and thought I banged on it pretty well...
Will do yet another pass on it and produce a release on the 19th.

I both of these should be addressed in 2.0.6


Mac release for v0.11.2 not working

When attempting to launch the extracted .app from both the 32 bit and 64 bit mac releases of v0.11.2, I get the message

The application “Livestreamer Twitch GUI 0.11.2.app” can’t be opened.

The 64 bit release of v0.11.1 works perfectly fine on the same system. The permissions on Livestreamer\ Twitch\ GUI\ 0.11.2.app/Contents/MacOS/nwjs seem to be incorrect because I believe it should be executable as it is in v0.11.1.
[~]$ ls -l Downloads/Livestreamer\ Twitch\ GUI\ 0.11.1.app/Contents/MacOS/nwjs
-rwx------@ 1 t  staff  8552 Dec  5 05:45 Downloads/Livestreamer Twitch GUI 0.11.1.app/Contents/MacOS/nwjs
[~]$ ls -l Downloads/Livestreamer\ Twitch\ GUI\ 0.11.2.app/Contents/MacOS/nwjs
-rw-r--r--@ 1 t  staff  8552 Jan 23 10:53 Downloads/Livestreamer Twitch GUI 0.11.2.app/Contents/MacOS/nwjs

However this permission is not the only problem because adding the executable flag does not fix the issue.

Oh boy... :sob:
The build system didn't change, so I'm not sure why the file permissions are not working... Let me see...
Thanks for reporting, though

Ok, I have found the issue...
I just recently copied my repo with all the cached NWjs files to a new partition on my system and somehow the file permissions were not set correctly. I did not expect this... :disappointed:
Easy fix: I don't need to change anything, since redownloading NWjs will fix this issue. I will recompile the files from the v0.11.2 tag and then reupload the files. Give me a couple of mins, so I can check that evrything is working again....

Fixed... Thanks again...
https://github.com/bastimeyer/livestreamer-twitch-gui/releases/tag/v0.11.2


Update Wiki

As a developer, I'd like to have an updated wiki, in order to only find relevant information about the project quickly.

:thought_balloon:   Hints & Thoughts
Check popular open-source projects and steal some quick win ideas we can implement
:question:   Additional Questions to Answer / Consider

:white_check_mark:   Conditions of satisfaction

[ ] Should delete files or parts of files that are not needed anymore (have a look at hints and thoughts) -> make sure you extract all the information from these files that is still useful (rule of thumb: everything you can just google is not relevant)
[ ] Add diagrams from the technical presentation to the wiki
[ ] Should enrich the architecture text with pointers to the code files or folders that implement specific elements of the architecture.
[ ] Refactor the structure and naming of the pages in the wiki if needed
[ ] Check all final wiki files for typos.

Updating the ssot wiki is also very important here


[Android] auto-generating js-stub based on annotations

Feature implementation and test case.
JIRA issue: https://crosswalk-project.org/jira/browse/XWALK-3969

Updated, @halton Please help to review. Thanks!

@DonnaWuDongxia good rework. I reviewed very carefully this time, I'm happy to give my lgtm after you fix them all.

@halton Please help to review. Thanks!

LGTM, thanks for your patience of reworking. Will merge.


[DNM] Refactor validation, support dataset appending, and extend testing

Description

[x] Refactor validation so that all file I/O happens in cli.py
[x] Squash a bunch of little bugs/improve user experience
[x] Expand testing to catch more cases
[x] Add -add option to append molecules to an existing dataset

Tests are passing. Merging.

Tests are passing. Merging.


Allowing an override to let non increasing oids be returned.

Need to test more but this could be a fix for #554 .

This has two new options to try and make the AWS elemental mib work.

no_check_increasing_oids: true. Set this in the device config per device.
walk_full_table: true. Set this per mib table in a snmp profile.

Its hard to test without an actual device but my best guess is that 2 is all that is needed. I'll set up a seperate PR with this.

Connected with https://github.com/kentik/snmp-profiles/pull/664


The Extension Cannot be Installed on Windows?

Installing the extension:

Error notification:

Full error message:

Tried using Docker Desktop v4.29.0 (previously used 4.28.0), but getting the same error:

Exist other MindsDB extension in Docker Desktop for Windows 10 Home?

Hey @Leunam1392,
Are you having trouble installing it as well?

Problem solved, really thanks guys for the help.

You're welcome @Leunam1392

@MinuraPunchihewa
Please close this issue. Thanks.

Completed by https://github.com/mindsdb/mindsdb/pull/9146


MudSwitch doesn't allow a default value when using ValueChanged

Bug type
Component
Component name
MudSwitch
What happened?
Using MudSwitch I need to handle the ValueChanged event so I can do an action when the switch is clicked. Unfortunately there is no viable way to set the mudswitch state to checked in it's default state.  I can in my application set the value onafterrender in code and it works. In the snippet submitted it doesn't work there. It generates a warning for me doing it in code that I can neither suppress or fix.
Expected behavior
A property for DefaultValue (or DefaultValues if tri-switch is ever introduced). I use this in a radiobutton where I need to handle the event rather than binding to the value, it's SelectedValues there.
Reproduction link
https://try.mudblazor.com/snippet/GkGokpFVpOQrPJPt
Reproduction steps

It's just available by default. Generosity at it's finest.

...
Relevant log output
No response
Version (bug)
6.19.1
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Simply set the Value property to true - https://try.mudblazor.com/snippet/mamIETbBJdVjwnGH

Seems like the simple solution, but on my machine if I set Value="true" I cannot uncheck the switch. It stays true all the time and doesn't matter what I do. Everything else in the page works. In the Try MudBlazor thing it works as expected. Here is my exact code.
<MudSwitch @ref="groupBySwitch" Value="true" ValueChanged="@((bool val) => GroupByChanged(val))" Label="@(!groupValue ? "Grouped by Agency" : "Grouped by Entity")" LabelPosition="LabelPosition.Start" />

	// Toggle Group By
	private async Task GroupByChanged(bool isChecked)
	{
		if (isChecked)
		{
			groupValue = true;
		}
		else
		{
			groupValue = false;
		}
		dataGrid.GroupItems();
	}

I see the issue now. I was obviously thrown off by trying to use @bind-Value that I normally would use. Which of course it won't let me use. I never again attempted to "bind" my value to the switch as I assumed it would give me the same error. Value="@groupValue" works as intended and allows me to start it with a true value.

Great. Feel free to close this issue if you're satisfied.

Another alternative in .NET 7+:
<InputText @bind-Value:get="_isSelected" @bind-Value:set="SetAsync" />
private bool _isSelected = true;
private Task SetAsync(bool newValue)
{
    _isSelected = newValue;
    return Task.CompletedTask;
}

Unfortunately, this syntax is not supported by TryMudBlazor, so I can't show a playground.
But yeah, you never want to do this:
valueSwitcher.Value = true;

This is really bad in Blazor. Forget about the imperative way (component.Parameter1 = v1); only use the declarative syntax (<Component Parameter1="@v1" />).


@fill3d/search is unavailable

The newer updated which previews via the search predictor fails as the '@fill3d/search' isn't public. See here: https://www.fxn.ai/@fill3d/search
This means the prompt objects are only showing:
[
  {
    anchor: { x: 0.25234103937549035, y: 0.6721133977451418 },
    x: 0.07097091732435663,
    y: 0.5155331336550648,
    width: 0.433711161426624,
    height: 0.34861266344583164
 }
]

vs the example of this:
 }
  prompt: "pink bed",
  choiceIdx: 1,
  choices: [
    {
      id: "1755a6fa-6e64-441a-bc4e-8cbe38343879",
      preview: "https://public.blenderkit.com/thumbnails/assets/1755a6fa6e64441abc4e8cbe38343879/files/thumbnail_70e3e49b-5326-4728-8514-a68620853b52.jpg.1024x1024_q85_crop-%2C.jpg"
    },
    {
      id: "21eadbf0-db80-4b5c-9ec9-2dae46109776",
      preview: "https://public.blenderkit.com/thumbnails/assets/21eadbf0db804b5c9ec92dae46109776/files/thumbnail_1b48d752-a482-4a2a-9f76-0ffd9fdaa196.jpg.1024x1024_q85_crop-%2C.jpg"
    },
    {
      id: "f5d42e12-db07-40ce-92bc-02e1072fb650",
      preview: "https://public.blenderkit.com/thumbnails/assets/f5d42e12db0740ce92bc02e1072fb650/files/thumbnail_671a367f-0888-4c55-98ab-365955944dd4.jpg.1024x1024_q85_crop-%2C.jpg"
    },
    {
      id: "328c4c2b-c395-49ec-b6e4-1960b5730374",
      preview: "https://public.blenderkit.com/thumbnails/assets/328c4c2bc39549ecb6e41960b5730374/files/thumbnail_4ac68b94-e393-4b44-9348-80575998b638.png.1024x1024_q85_crop-%2C.png"
    }
  ]
}

Hey @l3wi , just made the predictor protected: @fill3d/search. When filling, each prompt has the shape:
{
  x: number;
  y: number;
  width: number;
  height: number;
  anchor?: { x: number, y: number },
  // Either specify a text prompt, which will search and use the `id` of the first returned object
  prompt?: string;
  // Object ID to place, gotten from a search result
  id?: string;
}

The search predictor outputs a SearchResult[]:
interface SearchResult {
  // Object ID
  id: string;
  // Preview URL
  preview: string
}


GEODE-8158: enhance LocalHostUtil to support anyLocalAddress

Changed redis to have its default bind address to be anyLocalAddress instead of a single local address.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

The UpgradeTestOpenJDK11 failure is not related to this PR.

the acceptance test failures all had to do with docker not being available


Tasks 024-046 Variations, Phase II

This PR is resolved to the submission of the Dataset Creation Project (Dataset 3) Phase II.
There are a total of 115 variations (5 per instruction task) for the assigned 23 instruction tasks. There were various methods used to construct these variations ranging from fully-automated, semi-automated, and manual. Additionally, every task has at least two modifications to ensure it is a variant of the original. This includes a combination of definition perturbations/paraphrases, new examples with explanations, and re-sampling of instances.
The re-sampling of instances occurred only if possible and if the sampling method of the original task was feasible. The breakdown of each of these is described in the formal report submitted via Canvas.
Note: These tasks do not intersect with Phase I tasks (#136). This indicates that I have submitted a total of 184 total variations between the two phases.

@jwande18 Few comments - 1) Please resolve the conflict. 2) Can you add the original tasks in this PR as well. 3) Can you rename the task variants as taskxxx.1_yyyy, taskxxx.2_yyyy, taskxxx.3_yyyy and so on. For e.g. task547.1_spl_translation_entk_en.json, task547.2_spl_translation_entk_en.json, task547.3_spl_translation_entk_en.json and so on. Do this for all the tasks in this PR

@jwande18 Few comments - 1) Please resolve the conflict. 2) Can you add the original tasks in this PR as well. 3) Can you rename the task variants as taskxxx.1_yyyy, taskxxx.2_yyyy, taskxxx.3_yyyy and so on. For e.g. task547.1_spl_translation_entk_en.json, task547.2_spl_translation_entk_en.json, task547.3_spl_translation_entk_en.json and so on. Do this for all the tasks in this PR

@Ravsehajsinghpuri I have completed all the requested tasks as stated above. Please let me know if there is anything else you would like me to do. Thank you!


DOC: Add Table of Contents

What's wrong with the existing documentation
The existing documentation lacks a Table of Contents, making it difficult for users to navigate through the sections efficiently.
Add ScreenShots
Before:

After:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'24 contributor
[X] I want to work on this issue

@nikhil25803 can you assign this to me?

@nikhil25803 why is this marked as complete, please explain I thought that I was the first to open the issues does it already exist?
Thank you.


fix(dependencies): falcon needs at least six 1.4.0

six.PY2 is used several times in falcon, but that wasn't added to six until 1.4.0

Verified that PY2 landed in 1.4. Thanks!


LpSpec::__Pac attribute to be set on IsReadOnly:=False

UML to be corrected
+yang.3 already fixed

Solved with IpInterface_1.0.0-tsp.220330.1845.


Basic Layout for Test Certificate Detail Screen (DEV)

Basic Layout for GreenCertificate Detail Screen
To test, pls go to Test Menu -> Green Certificate -> Details Screen
Everything else will be done in a follow-up PR

@axelherbstreith @harambasicluka can it be that there's one data input field missing? I didn't find the "Date and Time of Sample Collection | Datum und Uhrzeit der Probenahme" field.

@axelherbstreith @harambasicluka can it be that there's one data input field missing? I didn't find the "Date and Time of Sample Collection | Datum und Uhrzeit der Probenahme" field.

Nice Catch! This is somehow missing in the Android Figma file. Will clarify with the designers 👍


Heads up : openrouter.ai is really not well referenced for some reason

Hi,
I'm sorry I can't find other ways to reach out so I created an issue on a random repo.
Basically if you look for openrouter ai on duckduckgo it's impossible to see your website. proof
I know that when I found out about your service I was blown away and then struggled to find again your website!
I use duckduckgo all the time and it's been reliable to me so I don't know where the issue comes from but if it's on your side I think you want to know about it so yeah just a heads up :)

The same here. Found in someone's open research randomly. Search engines are no longer reliable because of how the WebDev  works now.

I've never had an issue with finding it on duckduckgo


Revert "Add chase_provider_decision_at column to application_chices"

Reverts DFE-Digital/apply-for-postgraduate-teacher-training#1293

Sorry I didn't press submit on my comment before, but we can't only revert a migration. We need another migration to remove the column from QA's database.


Windows Defender reporting trojan virus in current wasm-pack-init.exe (v0.9.1) download

🐛 Bug description

During download of wasm-pack-init.exe (v0.9.1) for Windows 64-bit, Windows Defender is removing the download due to a reported trojan virus (Trojan:Win32/Spursint.F!cl).
I can manually "Allow" the executable, but reporting first to verify if this executable is safe first (and report for other users in case this is a true virus).
If this is safe, I can submit this to Microsoft as a false positive.

🤔 Expected Behavior
Download should succeed without a virus warning.
👟 Steps to reproduce

Navigate to https://rustwasm.github.io/wasm-pack/installer/ from a Windows 10 machine running current Windows Defender antivirus
Click to download the wasm-pack-init.exe
File downloads and is them immediately deleted with a status of "Failed - Virus Detected"

🌍 Your environment
OS: Windows 10 Version 2004 (OS Build 19041.172)
wasm-pack version: v0.9.1
rustc version: 1.42.0
Details from Windows Defender
Detected: Trojan:Win32/Spursint.F!cl
Status: Removed
A threat or app was removed from this device.
Date: 4/5/2020 8:43 AM (CDT)
Details: This program is dangerous and executes commands from an attacker.
Affected items:
file: C:\Users\XXXXX\Downloads\wasm-pack-init.exe
webfile: C:\Users\XXXXX\Downloads\wasm-pack-init.exe|https://github-production-release-asset-2e65be.s3.amazonaws.com/121253762/b19e6c00-49d6-11ea-90df-484cfb8fb95d?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20200405%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20200405T134257Z&X-Amz-Expires=300&X-Amz-Signature=05ee5765471ec18b4f51f5e22d36b55b44ae58bff883d00d42aff139f736822e&X-Amz-SignedHeaders=host&actor_id=1571176&response-content-disposition=attachment%3B%20filename%3Dwasm-pack-init.exe&response-content-type=application%2Foctet-stream|pid:11916,ProcessStart:132303105291942845
Learn more <- Details of virus from Microsoft

I'm facing the same issue.

@smithia30 I'm not able to reproduce this. I was able to successfully download the .exe file, and when I ran Windows Defender on the file it found no threats.
What browser are you using to download the file?

@Pauan I am using Chrome.  However, I just tried the download gain, and the error is no longer happening (and I can successfully install without errors).  I can only assume that there was a security update from Microsoft that tripped Windows Defender.
I see in my update history that I received two security updates and a cumulative update about a week after I submitted this ticket. So, maybe this fixed my issue.

@smithia30 I think it was just a false positive. Of course wasm-pack has never contained any viruses (and this is easy to verify, since everything is open source).
If anybody runs into this again we can reopen it, but for now I'll assume it was a bug on Microsoft's side.

same issue

I also just got the warning from Windows Defender.


update lifecycle doc

fix an error

Thanks!

Shouldn't that just be invoices/ consistently?

shrug It can go either way. But this at least keeps it consistent throughout the doc.


chore: release 20241216

Bug Fixes:

#384
#399

:tada: This PR is included in version 7.1.4 :tada:
The release is available on:

GitHub release
v7.1.4

Your semantic-release bot :package::rocket:


lang: Error if account init payer account is not marked mutable

This coincidentally works if the account is not marked mutable since the client will use the provider to pay for the transaction (and thus it is mutable). However, we should require the developer to explicitly mark these paying accounts mutable.

I'm up for giving this a spin. First time I dive into this part of Anchor though, so do you have a specific place where adding this logic would be best, maybe?
I see there seems to be constraint checks done here, but they seem limited to per-account checks (e.g. payer attribute unique per account), and I have not found an instance of cross-account check yet.
Would it make sense to add these checks here?

@losman0s are you still interesting in doing this?
If so, you can add the checks in this new function https://github.com/project-serum/anchor/blob/01ff03b09b30b974f2854dd0b0b9a958dd509622/lang/syn/src/parser/accounts/mod.rs#L40

@paul-schaaf yes, been a bit tied up the last few days but I'll get to it soon. Thanks for the update.

Hi guys im experiencing this error, can any one help
thread 'main' panicked at 'Code not parseable: Error("the payer specified for an init constraint must be mutable.")', lang/syn/src/idl/file.rs:360:58
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Hi guys im experiencing this error, can any one help
thread 'main' panicked at 'Code not parseable: Error("the payer specified for an init constraint must be mutable.")', lang/syn/src/idl/file.rs:360:58 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

It should pretty much be what the error describes. You are likely init-ing an account through the init macro, but forgot to mark the payer account you specified as mut.
If this does not fix your issue, please post your question on Discord instead.

Oh thanks, that solved the issue. but im finally trying to deploy to dev net but i get this error again
error: Custom: Invalid blockhash
There was a problem deploying: Output { status: ExitStatus(unix_wait_status(256)), stdout: "", stderr: "" }.

Even if this does not fix your issue, please post your question on Discord instead.

Whats the link to the discord channel seems the one i'm on wont allow me post anything
Thanks


Security vulnerabilities in SixLabors.ImageSharp

NPOI Version
2.7.1
Issue Description
Our Trivy security scanner pipeline is preventing this project from being used due to a security vulnerability in the SixLabors.ImageSharp package.
Installed library version: 2.1.8
Fixed versions: 2.1.9, 3.1.5
CVE-2024-41132 (https://avd.aquasec.com/nvd/2024/cve-2024-41132/)
CVE-2024-41131 (https://avd.aquasec.com/nvd/2024/cve-2024-41131/)
I have not created a PR for this as I did not want this to conflict with https://github.com/nissl-lab/npoi/pull/1390

can we fix thin soon on <IP_ADDRESS>

Can we fix then soon on <IP_ADDRESS>?

select your project where you consume npoi in Visual Studio, open NuGet UI, go to "Installed packages", here you see "Top Level Packages" and "Transivite Packages". Now find SixLabors.ImageSharp under Transitive Packages and install it in Version 2.1.9 to fix it yourself. Only issue is now that NuGet shows an update of SixLabors.ImageSharp to 3.1.5 because Microsoft still has no version range blocking like in old packages.config times (allowedVersions entry) or detecting of incompatible frameworks.

There is no plan of urgent fix for this. The security bug is about gif codec. NPOI doesn't use this feature in ImageSharp at all.

Created #1402

I get it that NPOI doesn't use git codec where the vulnerability is. But, for some of us who use it in production code reports still point that the package is vulnerable, and the process we have setup doesn't let us keep it that way.

NPOI 2.7.2 has been released. This issue is fixed then.


Chronicle milestones 1 and 3

Milestone Delivery Checklist

[x] The milestone-delivery-template.md has been copied and updated.
[x] The invoice form has been filled out for this milestone.
[x] This pull request is being made by the same account as the accepted application.
[x] In case of acceptance, the payment will be transferred to the EOS account name provided in the application.
[x] The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: https://github.com/eosnetworkfoundation/grant-framework/pull/26

This is only for Milestone 3.  Milestone #2 will likely be skipped and not completed.  This is for support.

no, both milestones 1 and 3 are new and weren't reviewed.

I will re-submit, one PR per milestone


Error in CLion 2017.2

I updated to CLion 2017.2 and I'm seeing this error

com.google.idea.blaze.plugin.CMakeWorkspaceOverride@77e8e6df: tried to access field com.jetbrains.cidr.cpp.cmake.workspace.CMakeWorkspace.myProject from class com.google.idea.blaze.plugin.CMakeWorkspaceOverride

And sync works, but the IDE is stuck at "indexing", and auto-completion is not working.

We haven't yet released a plugin version compatible with 2017.2.
I'll update this thread when we do (likely around late August).


node-port-acceleration for kernel bonded device

Proposal / RFE
Is your feature request related to a problem?
We have cilium setup on bare metal kubernetes cluster. The physical 10g Intel NIC's are bonded (static rr) for failover,
I am unable to set node port acceleration for bond0 as it is not yet supported.
Describe the solution you'd like

I am unable to set node port acceleration for bond0 as it is not yet supported.

@srinathhs Could you share 1) your devices (ip l), 2) what cilium configuration did you use, 3) what exactly failed (probably cilium pod logs)?

(needs kernel support for bonded devices for XDP)

Fyi, native XDP support for bonding driver has been merged into net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=9e2ee5c7e7c35d195e2aa0692a7241d47a433d1e


Allow a custom logger for both Phobos and RubyKafka.

I have a custom Rails logger I'm using which uses ActiveSupport tagged logging and not the Logging framework. This PR allows me to set the custom logger to Phobos instead of being required to use Logging.

The comments are general comments, not comment about the line if ruby_kafka 🙄

@klippx I've added a couple of extra commits. Can you take a look?

@klippx one more commit added!

Thank you for the contribution!

Released in 1.8.0

Awesome!


Sic codes

https://podio.com/bitzesty/app-qae/apps/stories/items/142
Implementation of sic codes storing and retrieving.

Looks good for me :+1:


Update netty-handler to 4.1.90.Final

Updates io.netty:netty-handler from 4.1.81.Final to 4.1.90.Final.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.netty", artifactId = "netty-handler" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "io.netty", artifactId = "netty-handler" }
}]

labels: library-update, commit-count:1

Superseded by #1467.


Letting flags be changed from outside

Proposed Changes

Letting flags be changed from outside
Changing those flags is needed to perform tests on RH operators.
Adding Intellij, and vandors excluded files to gitignore

Implementation
This PR let change test flags from outside. It can be done either by:

declaring environmental variables: TEST_NAMESPACE, and TEST_RESOURCE,
using -ldflags "-X knative.dev/serving-operator/test.ServingOperatorNamespace=knative-serving"

Release Note
NONE

This PR mirrors https://github.com/knative/eventing-operator/pull/21

/ok-to-test

/approve
/lgtm


[Datagrid] Window is not defined when SSR

What package(s) are you using?

[x] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.

Get window is not defined when server side rendering (Next.js)

Is this issue related to a specific component?

Datagrid

What did you expect to happen? What happened instead? What would you like to
see changed?

It works fine in @carbon/ibm-products 1.34.0, then the error show up when upgrade to latest version 1.47.0.
Not sure the root cause is the dependencies upgrade in version 1.46.2 or not.

What browser are you working in?

Google Chrome

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?

@carbon/ibm-products 1.47.0
Additional information

const datagridState = useDatagrid(
    {
      columns,
      data,
      isFetching,
      manualPagination: true,
      pageCount: total,
      autoResetPage: false,
      DatagridPagination,
      DatagridActions,
      ExpandedRowContentComponent,
    },
    useExpandedRow,
    useStickyColumn,
    useActionsColumn
 );

Should be addressed with #3059 #3058


Fixed #30678 -- Added support for GDAL 3.

I pushed edits, but I wasn't able to test them properly with GDAL 3.1+ and PROJ.4 6.3+. I will try tomorrow morning.

Everything works with GDAL 3.0.4 :heavy_check_mark: I have some issues with GDAL 3.1 so I think we can leave it for now and include only GDAL 3.0 in Django 3.1. I don't have more time to investigate these failures before the feature freeze, e.g.
  File "repo/django/django/contrib/gis/gdal/srs.py", line 104, in __init__
    capi.set_axis_strategy(self.ptr, self.axis_order)
  File "repo/django/django/contrib/gis/gdal/prototypes/errcheck.py", line 117, in check_errcode
    check_err(result, cpl=cpl)
  File "repo/django/django/contrib/gis/gdal/error.py", line 61, in check_err
    raise GDALException('Unknown error code: "%s"' % code)
django.contrib.gis.gdal.error.GDALException: Unknown error code: "50690944"

I can confirm the tests pass with GEOS 3.8.1 and GDAL 3.0.4 (on PostGIS).

@claudep Thanks. I also confirmed that GEOS 3.8.1 works as expected.

buildbot, test on oracle.

Sorry if I'm asking this in the wrong place, but does this fix apply for Django 2.2 too? I currently updated my Django version to 2.2.15 but it seems that these changes are not there yet.

@m-nouredini This is a new feature so it doesn't qualify for a backport.


Stream life cycle

Exercise the entire life cycle of a stream, including appropriate use/handling of RST_STREAM. Streams are bidirectional, regardless of ongoing issue discussion

This is mostly done. I don't do flow control but that's covered separately.


Change 'cm' -> 'lineage'

Hi @AdrianDC
Check this out and merge if you think it is good :)
Nitin

Picked and improved.


Add --confirm to conan upload

For issue #84

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks so much. I'm releasing new version in some minutes.

0.4.31 released.


github action to run tests and code quality

What is this
We need to add a test action and a code quality action to dp-python-tools that work in the same way as they do in dp-data-pipelines (minus the features action).
What do do
Add actions to py-python-tools
Acceptance Criteria

[ ] actions added, any flagged linting issues are resolved

Test action and code quality action added, and flagged linting issues resolved


microk8s is not running.

Summary

microk8s is not running. Use microk8s inspect for a deeper inspection.
What Should Happen Instead?

Reproduction Steps

sudo snap install microk8s --classic --channel=1.26
sudo microk8s status

Introspection Report

inspection-report.zip
Can you suggest a fix?

i cannot
Are you interested in contributing with a fix?

no, I'm a beginner and not yet able to fix

Hi @gocpplua
In the logs of the report you sent, I see the following line being repeated a few times:
12月 15 09:01:28 cn0314000510l microk8s.daemon-containerd[14551]: time="2022-12-15T09:01:28.400762292+08:00" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:calico-node-ncbr4,Uid:0064ebc3-3681-4178-b304-1640c137d231,Namespace:kube-system,Attempt:0,} failed, error" error="rpc error: code = DeadlineExceeded desc = failed to get sandbox image \"registry.k8s.io/pause:3.7\": failed to pull image \"registry.k8s.io/pause:3.7\": failed to pull and unpack image \"registry.k8s.io/pause:3.7\": failed to resolve reference \"registry.k8s.io/pause:3.7\": failed to do request: Head \"https://asia-east1-docker.pkg.dev/v2/k8s-artifacts-prod/images/pause/manifests/3.7\": dial tcp <IP_ADDRESS>:443: i/o timeout"

We have seen this issue come up a few times due to the great firewall blocking access to upstream image registries. Practically, MicroK8s is failing to pull the images that are required to function.
Can you follow the instructions described in https://microk8s.io/docs/registry-private#configure-registry-mirrors-7 for registry.k8s.io? The commands that you have to run are:
sudo mkdir -p /var/snap/microk8s/current/args/certs.d/registry.k8s.io

echo '
server = "https://k8s.gcr.io"

[host."https://registry.aliyuncs.com/v2/google_containers"]
  capabilities = ["pull", "resolve"]
  override_path = true
' | sudo tee -a /var/snap/microk8s/current/args/certs.d/registry.k8s.io/hosts.toml

Afterwards, restart MicroK8s with:
sudo snap restart microk8s

Let me know if that helps!

suggested solution also fails with:
Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = failed to get sandbox image "registry.k8s.io/pause:3.7": failed to pull image "registry.k8s.io/pause:3.7": failed to pull and unpack image "registry.k8s.io/pause:3.7": failed to resolve reference "registry.k8s.io/pause:3.7": failed to do request: Head "https://registry.aliyuncs.com/v2/google_containers/pause/manifests/3.7?ns=registry.k8s.io": dial tcp <IP_ADDRESS>:443: i/o timeout

Hi @nealabh
Can you reach https://registry.aliyuncs.com/ from your host using something like curl, or does it timeout?

suggested solution also fails with:
Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = failed to get sandbox image "registry.k8s.io/pause:3.7": failed to pull image "registry.k8s.io/pause:3.7": failed to pull and unpack image "registry.k8s.io/pause:3.7": failed to resolve reference "registry.k8s.io/pause:3.7": failed to do request: Head "https://registry.aliyuncs.com/v2/google_containers/pause/manifests/3.7?ns=registry.k8s.io": dial tcp <IP_ADDRESS>:443: i/o timeout

This did help me.
I was trying to run microk8s on a fresh install ubuntu 22.04 on a Hetzner server.

neoaggelos This did help me. I was trying to run microk8s on a fresh install ubuntu 22.04 on Hetzner server. Thank you.

neoaggelos' method works. As https://registry.aliyuncs.com/ does not work now, I replace it with https://hub.docker.com/docker.

Hi @gocpplua
In the logs of the report you sent, I see the following line being repeated a few times:
12月 15 09:01:28 cn0314000510l microk8s.daemon-containerd[14551]: time="2022-12-15T09:01:28.400762292+08:00" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:calico-node-ncbr4,Uid:0064ebc3-3681-4178-b304-1640c137d231,Namespace:kube-system,Attempt:0,} failed, error" error="rpc error: code = DeadlineExceeded desc = failed to get sandbox image \"registry.k8s.io/pause:3.7\": failed to pull image \"registry.k8s.io/pause:3.7\": failed to pull and unpack image \"registry.k8s.io/pause:3.7\": failed to resolve reference \"registry.k8s.io/pause:3.7\": failed to do request: Head \"https://asia-east1-docker.pkg.dev/v2/k8s-artifacts-prod/images/pause/manifests/3.7\": dial tcp <IP_ADDRESS>:443: i/o timeout"

We have seen this issue come up a few times due to the great firewall blocking access to upstream image registries. Practically, MicroK8s is failing to pull the images that are required to function.
Can you follow the instructions described in https://microk8s.io/docs/registry-private#configure-registry-mirrors-7 for registry.k8s.io? The commands that you have to run are:
sudo mkdir -p /var/snap/microk8s/current/args/certs.d/registry.k8s.io

echo '
server = "https://k8s.gcr.io"

[host."https://registry.aliyuncs.com/v2/google_containers"]
  capabilities = ["pull", "resolve"]
  override_path = true
' | sudo tee -a /var/snap/microk8s/current/args/certs.d/registry.k8s.io/hosts.toml

Afterwards, restart MicroK8s with:
sudo snap restart microk8s

Let me know if that helps!

Hi @neoaggelos
Thanks for the solution!
How about images from gcr.io?
Thanks!

Ok, I will check.
Tian Siyuan @.***> 于2024年5月31日周五 10:23写道：

Hi @gocpplua https://github.com/gocpplua
In the logs of the report you sent, I see the following line being
repeated a few times:
12月 15 09:01:28 cn0314000510l microk8s.daemon-containerd[14551]: time="2022-12-15T09:01:28.400762292+08:00" level=error msg="RunPodSandbox for &PodSandboxMetadata{Name:calico-node-ncbr4,Uid:0064ebc3-3681-4178-b304-1640c137d231,Namespace:kube-system,Attempt:0,} failed, error" error="rpc error: code = DeadlineExceeded desc = failed to get sandbox image "registry.k8s.io/pause:3.7\ http://registry.k8s.io/pause:3.7\": failed to pull image "registry.k8s.io/pause:3.7\ http://registry.k8s.io/pause:3.7\": failed to pull and unpack image "registry.k8s.io/pause:3.7\ http://registry.k8s.io/pause:3.7\": failed to resolve reference "registry.k8s.io/pause:3.7\ http://registry.k8s.io/pause:3.7\": failed to do request: Head "https://asia-east1-docker.pkg.dev/v2/k8s-artifacts-prod/images/pause/manifests/3.7\": dial tcp <IP_ADDRESS>:443: i/o timeout"
We have seen this issue come up a few times due to the great firewall
blocking access to upstream image registries. Practically, MicroK8s is
failing to pull the images that are required to function.
Can you follow the instructions described in
https://microk8s.io/docs/registry-private#configure-registry-mirrors-7
for registry.k8s.io? The commands that you have to run are:
sudo mkdir -p /var/snap/microk8s/current/args/certs.d/registry.k8s.io
echo 'server = "https://k8s.gcr.io"[host."https://registry.aliyuncs.com/v2/google_containers"]  capabilities = ["pull", "resolve"]  override_path = true' | sudo tee -a /var/snap/microk8s/current/args/certs.d/registry.k8s.io/hosts.toml
Afterwards, restart MicroK8s with:
sudo snap restart microk8s
Let me know if that helps!
Hi @neoaggelos https://github.com/neoaggelos
Thanks for the solution!
How about images from gcr.io?
Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/canonical/microk8s/issues/3627#issuecomment-2141125170,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALFC7ASIXCQIO3WCRNXHUODZE7NJFAVCNFSM6AAAAAAS7FGE2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBRGEZDKMJXGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Software Development Engineer  陈琦  TEL:18767122273

Hi guys, I have similar issues with a customer installation.
We whitelisted registry.k8s.io but why is the image pull requesting sources from *.pkg.dev ?


fix: dismiss payload

fix issue #142
pass payload when dismiss

Tried this locally on my iOS app and can confirm it works as expected 💯  🎉  🙏