Cluster upgrades may cause downtime for workloads with multiple AZs

Hey friends.
This is not the typical enhancement request, but still it's a strange behaviour we observed while using cluster managed by Gardener, so I think it's worth sharing.
Description of the problematic behaviour observed
We have a relatively small cluster running on GCP with worker nodes distributed over 3 AZs.
Here is the worker setup:
      workers:
        - name: worker-c92jz
          machineType: n1-standard-4
          machineImage:
            name: coreos
            version: 2135.6.0
          autoScalerMin: 3
          autoScalerMax: 6
          maxSurge: 1
          maxUnavailable: 0
          volumeType: pd-standard
          volumeSize: 50Gi
      zones:
        - us-west2-a
        - us-west2-b
        - us-west2-c

Currently we have 3 worker nodes, 1 node per AZ and our workloads have PodDisruptionBudget, PodAffinity and HorizontalPodAutoscaler configured.
When we roll out a new k8s version to the cluster we observe a downtime of the workloads running on top. The behaviour we see is that all 3 worker nodes seem to start updating all at the same time and in parallel.
What would you like to be added:
Is it possible to alter this behaviour and not trigger a parallel deploy for all zones, but do it one by one or at some configurable value/%. Pretty much the same as when we have in a single zone cluster.
If it's not possible at least have it explicitly stated and document what are the preferred adjustments that needs to be done in order to prevent similar misinterpretations from users in future.
The mitigation mechanism we thought may help is that if we increase the nodes to be at least 2 per zone and also scale out our pods to distribute a bit more evenly between the nodes. Any recommendations from your side are welcome.

@hardikdr @prashanth26 - we have three MachineClasses and three MachineDeployments, one per zone. When updating the version then we create three new MachineClasses and update the references in all MachineDeployments in parallel. Wasn't your statement that PDBs will ensure that MCM does not start draining all of the nodes at the same time?

It should block, according to my understanding, but maybe that's a parallelisation issue/race condition since draining will start together, because these are three different machine deployments, but the code that does the PDB planning is not within the API server, but the client, I believe.

@ggaurav10 tried this the following -
i tried to reproduce this in my cluster. Details:
setup: 2 nodes, deployment with 5 replicas, pdb with minAvailable: 4
Exp1 - To check client side parallelism:
*   All pods are created on same node of of the 2
*  use cmd k drain --pod-selector=run=resource-consumer ip-10-250-30-120.eu-west-1.compute.internal to drain it
* Expectation and observation: PDB was respected
Exp2 - To check server side parallelism:
• All pods are created on same node out of the 2
• use the same cmd but run it in parallel 5 times
• Expectation and observation: PDB was respected

But we are yet to test it with the multi-zone setup as mentioned above. Maybe something isn't working there.  Ideally, this shouldn't be happening. I shall check this case out. We might need a couple of days' time. I will keep you posted on this thread.

I believe PDBs should be respected with the above setup.

MCM respects the maxSurge, maxUnavailable but that's per MachineDeployment. With the setup mentioned above by @rfranzke , it is expected that the replacement of all the machines will initiate simultaneously.
Before actually deleting/replacing the machine, MCM always drains it. And drain basically evicts the pods on the node using EvictionAPI.

The EvictionAPI ensures to not delete the given pod if any PDBs are violated due to its deletion. Hence, even though the drain has been simultaneously initiated for all machines above, the actual deletion of the PDB-backed-pods should be blocked by EvictionAPI.

Though the catch here is, we have certain timeouts. If a drain isn't successful in a given timeout-period, we simply force-delete the machines and hence also the pods running on them. I believe such a timeout is large enough atm[~2hrs] [cc @prashanth26 ]. This is just a theoretical explanation and it would be nice to reproduce the case if possible, we shall do a few experiments.
Although I am curious, what is the size of the docker image? How much time does your pod generally take in getting started on the fresh machine? Was your observation only about the machines being rolled together or was there actually a downtime observed for the workload-pods as well?

There is code to block already but I when I tried with multi-az cluster, PDB was indeed violated as described above.
There could be a general PDB violation issue for pods with affinity/antiaffinity even in single-az clusters.

The PDB violation in single-az clusters was transient and was not reproducible. But it is consistently reproducible in multi-az clusters.

OK, so even though we use a central coordinator (Kubernetes eviction API), PDBs are not respected. Do we already know whether that's an upstream bug or works as intended?

Not sure. Couldn't make out from the available MCM logs. Could be an internal issues as well. We should to check with more logging (especially, the eviction API response).

Hey @hardikdr .
Some of the docker images are around 30-40 MB and others  80-100 MB. In general no more  than 100MB. Implementation is Go based if it matters.
I don't have a concrete metrics about the starting time, but in general it doesn't take more than a couple of seconds, so nothing noticeable or too big.
There was an actual downtime for the workloads running on top.
We tried the upgrades with both maxUnavailable set to 0 and 1, but the observed behaviour was pretty much the same.

Any thoughts on this one?
Does the option to just scale the clusters to have more than one VM/node per region sounds like a viable thing to do in order to mitigate the downtime problem in the short term?
Is the PDB going to be taken in consideration if we have this setup and scale out both our machines and pods ?

Sorry for not updating this thread. We are looking into it further. We have a possible improvement at hand in MCM, where we plan to increase the number of eviction retries before force-fully deleting the pods. This should better the roll-outs, at least initial experiments have been suggesting so.

Does the option to just scale the clusters to have more than one VM/node per region sounds like a viable thing to do in order to mitigate the downtime problem in the short term?

Any possible mitigations from your side are always good to have in my opinion. Having more machines leaves space for pods to be quickly scheduled on other machines.

Is the PDB going to be taken in consideration if we have this setup and scale out both our machines and pods ?

We have identified a fixed number of eviction-retries in drain function, which were exhausted and hence pods were getting deleted forcefully - violating PDBs. With fix on the way, the PDBs should be respected in the setup you described above.

@rfranzke another problem is that both fields maxSurge and maxUnavailable are applied to ALL MachineDeployments which is really contra-intuitive:
workers:
- name: worker-c92jz
  autoScalerMin: 3
  autoScalerMax: 6
  maxSurge: 1
  maxUnavailable: 0
zones:
- us-west2-a
- us-west2-b
- us-west2-c

When I have the above specification I would expect that only ONE node should be updated at all times.
End-user might also be tricked into putting maxUnavailable and maxSurge to 3, expecting that there should always be at least 6 nodes UP, which would result in ALL Nodes of the cluster to be rolled in the same time:
workers:
- name: worker-c92jz
  autoScalerMin: 9
  autoScalerMax: 9
  maxSurge: 3
  maxUnavailable: 3
zones:
- us-west2-a
- us-west2-b
- us-west2-c

A more sane representation would be to have
workers:
- name: worker-a
  autoScalerMin: 3
  autoScalerMax: 3
  maxSurge: 1
  maxUnavailable: 1
  zone: us-west2-a
- name: worker-b
  autoScalerMin: 3
  autoScalerMax: 3
  maxSurge: 1
  maxUnavailable: 1
  zone: us-west2-b
- name: worker-c
  autoScalerMin: 3
  autoScalerMax: 3
  maxSurge: 1
  maxUnavailable: 1
  zone: us-west2-c

or something on the line of:
workers:
- name: worker-a
  taints:
  - foo: bar
  kubernetes:
    kubelet: ....
  zones:
  - name: us-west2-a
    maxSurge: 1
    maxUnavailable: 1
    autoScalerMin: 3
    autoScalerMax: 3
  - name: us-west2-b
    maxSurge: 1
    maxUnavailable: 1
    autoScalerMin: 3
    autoScalerMax: 3
  - name: us-west2-c
    maxSurge: 1
    maxUnavailable: 1
    autoScalerMin: 3
    autoScalerMax: 3

I agree. Ideally, MCM should be responsible for distributing the nodes across availability zones. Worker pool extension should just create one MachineDeployment per worker pool.

This issue was resolved with #370 recently, PDBs should be respected with the given setup. We'll release new MCM soon with the changes in.
Though I am looking towards keeping this issue open, agreeing with comments from @mvladev above. We might want to rethink how we present the worker-pools via shoot-spec.


The ReadWrite flag isn't needed for code segments

Follow-up to #278

Cherry-picked fce85e6 to entering_longmode set_up_rust printing_to_screen allocating_frames page_tables remap_the_kernel kernel_heap catching_exceptions better_exception_messages returning_from_exceptions double_faults


Change BGP port on ATE to port2

The nexthop of the BGP route is port2, so the route should come from there as well instead of port1.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.559%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4108

Relevant Lines:
6172

💛  - Coveralls

Is this passing locally for you? Looks the bgp triggered gue is failing on presubmit? Can we get it passing or remove from presubmit

@DanG100 This is passing for me locally. It looks like in the VM, or higher CPU environment there is more packet loss. For now I've tweaked the loss tolerance higher and marked a TODO for later debugging since otherwise the test is working fine.


minor: STUD-196 Implement "Released" email notification

Ready to merge

@saif-software-developer Looks good to me, but I'll let @wlara give final approval on this one.

Tested:


[pulsar-client-cpp] Should throw std::exception (or a subtype), not const char*

Is your enhancement request related to a problem? Please describe.
The Pulsar C++ client library throws const char* in several locations instead of std::exception or a derived type.
Describe the solution you'd like
Throw std::exception or some derived type instead.
  The not supported exceptions should perhaps be runtime_error or maybe just bare exceptions.

I agree with you. Throwing a std::invalid_argument is a better choice. The pulsar C++ client doesn't use exceptions except for fail-fast, but throwing a const char* won't print any message, while throwing an exception would print the message of what() method.
Would you like to submit a PR?

@BewareMyPower I will


Change Html.Partial to partial tag helper for StatusMessage

Summary of the changes:

Changed
@Html.Partial("_StatusMessage", Model.StatusMessage)
to
<partial name="_StatusMessage", for="StatusMessage" />
in relevant identity scaffolds which will stop warning messages and therefore will prevent potential deadlock scenarios.

Fixes #756
Fixes #737

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: tura08 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Is this ready to merge?

Closing as this seems to have been handled on master.


MarkerWithLabel ignore click events

Hi guys I am using GoogleMap with MarkerWithLabel and it seems that all click events inside the Label are being ignored
I've created the following example to show this issue:
https://codesandbox.io/s/reactgooglemaps-example-89h10?fontsize=14
Is this supported or am I supposed to be handle it differently?

Hello @apellizzn , this library is not maintained more than a year. We have built new version @react-google-maps/api https://www.npmjs.com/package/@react-google-maps/api
We have active community at spectrum, examples and working docs.


[INLONG-10841][SDK] Transform SQL supports toBase64 function

Fixes #10841
Motivation

Add a string function class：ToBase64Function.
Add the corresponding unit test codes
Modifications

Verifying this change
(Please pick either of the following options)

[ ] This change is a trivial rework/code cleanup without any test coverage.

[x] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

please resolve the conflict.

please resolve the conflict.

done


Fit the exponential decay curve to accuracy distribution

We hypothesize that the Scatter SDE summary plot of the accuracy distribution is an exponential decay with a bump at acc = 1 corresponding to the sum of the tail probabilities (since the memorization score can't go above 1).  Specifically, let p(x) = [the number of sequences in the training data that have accuracy x]. We want to do the following:

Fit an exponential decay curve to p(x) looking only at x in [0, k] for k in [0.25, 0.5, 0.75, 0.9, 0.99]
Check how well the curves agree on [k, infinity)
Check whether the sum from i = 1 to infinity of p(i) according to the fit model equals the observed p(1) value.

We were recently discussing this theory in Discord, and it occurred to @norabelrose and I that an exponential decay pattern does not actually agree with the tail probability theory, as the tails an exponential decay are too fat to produce noticable bumps. However, power laws do have fat tails and a "rich get richer" dynamic makes sense in the context of memorization as the more detail one specifies about the generated sequence the more locked-in the model should be to the correct distribution.
Last night Nora decided to run some basic analysis, and lo and behold:

Does this issue still need help?

@CalmDownKarm Thanks for reaching out! We took care of this, and are currently preparing a paper for release detailing the results.


MAP: Decide on what markers to use for cases and orgs in the map

We can use any of the icons in material icons (https://material.io/icons/) or font-awesome (http://fontawesome.io/, not sure what version).  I'd prefer it if we didn't have to use new icons, at least for now (because mapbox doesn't make it trivial).
Can pick whatever color, size.
(for implementation, see MapVisualization.js and https://github.com/mapbox/mapbox-gl-js/issues/3605#issuecomment-296486123 for the magic incantations.
Currently:

@jesicarson @davidascher - If we're limited in terms of icons, then let's go for the standard "place" icon from google material. I'm not certain about colour - I think we should check with amber for approval - My assumption is that black (#333) is preferred (can we add a white outline? + drop/text shadow?) - if not, then we should stick with the interactive colour (red #ec1414). - we should also add a hover state colour - lightened by 15%.

don't we want to distinguish cases & orgs?

Well, Stefan had a legend to show different colours and how they correlate
with the markers on the map, I'm cool with that.. though I think it's best
we bring this back to Amber. Based on her feedback, I'd like to hear what
she thinks about introducing more colours into the palette.
With that being said, it wouldn't be a deal breaker if they were all the
same colour, since filtering for cases / organizations - should also filter
the map, right?
On Mon, Apr 24, 2017 at 11:45 PM, David Ascher<EMAIL_ADDRESS>wrote:

don't we want to distinguish cases & orgs?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/participedia/frontend/issues/260#issuecomment-296930762,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYaZ3zQb-9xYfcM3CiOaOYgnI5D9Ntb1ks5rzZaOgaJpZM4NFh61
.

It should but it doesn't yet. Good point to notice.

Two colours might also be fine without a legend, since the word case/org will appear on click in the white box and people will very quickly figure that out. Also it indicates that something multi-layered is going on on the map at first glance. But I agree we should check with Amber. For now I'd say try red and black as Sam suggested. Although for hover, I'm not sure I like the idea of lightening the red, is there another way to indicate hover for red pins, or do we have to? Can it just be click to activate the info box, no hover state change?

Decision is:

[ ] we'll use black (or dark grey) markers for cases and methods
[ ] we'll use the highlight color (or a derivative) to show pins that correspond to the search results.

Black please

took out the remaining bits in #288, closing this.


Add jest test for dragon

This pull request adds a jest test for the dragon component

everything is correct, time to merge it.


Adjust presets on Sketch-colorpicker

It seems that I can not feed any custom swatches to the sketch colorpicker. that would be super useful :)

The swaches can be customize now! Please upgrade to the latest version. And the usage is down blow:
/* presetColors accepts an array of colors */
<sketch v-model="colors" :presetColors="presetColors"></sketch>


DEXTER is not able to pull data at tier level

Describe the bug
Current DEXTER setup is working fine at the Application level, Tried to pull data at tier level, not working and pulling expected data. By this issue missing data visualization when trying at the node level.
Expected behavior
If there is any way or JSON file that can help me in pulling data as expected at a tier that would we helpful.

Can you please describe the issue in better detail. What do you want to pull at Tier level? What visualizations are you wanting to produce?

Can you clarify please?

Same issue here. Dexter picks up data on an Application level only and cannot minimize the scope to a Tier level. Can anyone help here pls?

@danielodievich danielodievich
We would like to pull  "TransactionNode", "TransactionBackend", "TransactionBT", "TransactionSEP", "TransactionError", "TransactionIP", "AgentStats", "OSHardware", "CLRStats", "IISStats", "IISReqCounts", "IISReqPerf", "JVMStats", "BusinessTransactionPercentiles"

Hi, if you want to grab the Tier level only, you need to look at https://github.com/Appdynamics/AppDynamics.DEXTER/wiki/Metric-Sets. The entity type the metric set applies to is in EntityType column. If you want to pull only Tier metrics, you can remove all rows with EntityType that is NOT Tier and you'll accomplish what you want.
Alternatively, you can modify the MetricSet column value for just the Tier metrics you want and specify that.
Let me know if this makes sense.

Closing for lack of clarify


fix mdx not rendering

What is it?

Bug

Description
For some reason,  the Qwik UI docs didn't render with version 1.10.0 because they are based on mdx.
Apparently #6845 broke it.
But this seems to fix it.
Couldn't setup a breaking test for this one (it happens only in dev mode, and the CLI e2e passed with my attempt to break it).
It also seems like this is solved in V2, so this will be a quick (qwik) fix until V2 is released and then we'll dig into it more.
Checklist

[x] My code follows the developer guidelines of this project
[x] I performed a self-review of my own code
[x] I added a changeset with pnpm change

@shairez I'm not sure this is necessary. The Qwik UI docs use an mdx recma plugin hack that I implemented back then. So your fix here would be fixing a hack inside of Qwik UI in a way 😅.  I got the Qwik UI docs to work by simply removing the plugin. This seems to work now since Woot changed the underlying implementation. I was going to make a PR, but no time for it when I was in China 🙈

thanks @maiieul
well that explains the tests passing 😅
closing

Re-opening after discussion with Maieul


Safari Extension?

Are there any plans to develop a safari extension? I hear with the new safari update it will be easier to migrate extensions available on chrome to work with safari as well.

See #3286.

https://apps.apple.com/au/app/wappalyzer/id1520333300

Nice! I've been checking every week for this. Thank you.

@AliasIO Hey is it possible to update the style so it matches other extensions in the toolbar?  I'm a designer so I don't mind volunteering if you're busy.

Yeah, would love to. It looks like Safari doesn't support browserAction.setIcon properly so we can't set it dynamically based on the user agent. I'll see what I can do.


Employee is not redirected to github after the Corporate workflow in Contributor Console

Background

Launch github repository url https://github.com/selenium-af/Issue719
Login as github user
Update any file and Pull Request
Checks fail
Click on the link to Sign CLA
Click on Corporate
Select Company CompSignAfterEmployeeRequest
Popup to request authorization is displayed
Select employee Email ID
Click SEND button and click DISMISS
Observed the UI with popup to select Company is displayed and user is not redirected to github
NOTE: User is not redirected to github after any of the workflow related to Corporate

@hnexokonkwo please work with @nirupamav to test/evaluate/resolve this issue.

The old console is deprecated and removed.


Capacity tariff Flanders (Belgium) - Extra data-objects, telegram change

Would it be possible to add the following data objects that are published on the DSMR P1 port with KW as measurement to the HomeWizard integration? These measurements are very important for Flemish users for the new capacity tariff which the distribution system operator will highly likely introduce on the 1st of January 2023.
The changes that have been made to eMUCs for the introduction of the capacity tariff in Flanders are highlighted in yellow in this pdf delivered by the the distribution system operator (Fluvius):
https://maakjemeterslim.be/rails/active_storage/disk/eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaDdDRG9JYTJWNVNTSWhlblJ4YW14cU5XdHRhalZsWkRWbmJIaDNNak4zYmpReGFUazRkd1k2QmtWVU9oQmthWE53YjNOcGRHbHZia2tpVjJsdWJHbHVaVHNnWm1sc1pXNWhiV1U5SW1VdFRWVkRVMTlRTVY5RlpGOHhYemRmTVM1d1pHWWlPeUJtYVd4bGJtRnRaU285VlZSR0xUZ25KMlV0VFZWRFUxOVFNVjlGWkY4eFh6ZGZNUzV3WkdZR093WlVPaEZqYjI1MFpXNTBYM1I1Y0dWSkloUmhjSEJzYVdOaGRHbHZiaTl3WkdZR093WlUiLCJleHAiOiIyMDIyLTEyLTEyVDExOjQ1OjMwLjg0NVoiLCJwdXIiOiJibG9iX2tleSJ9fQ==--1c68e8d843e99a6f94dc825253327341be27fe84/e-MUCS_P1_Ed_1_7_1.pdf?content_type=application%2Fpdf&disposition=inline%3B+filename%3D%22e-MUCS_P1_Ed_1_7_1.pdf%22%3B+filename%2A%3DUTF-8%27%27e-MUCS_P1_Ed_1_7_1.pdf
Telegram example
/FLU5\253769484_A

0-0:96.1.4(50217)
0-0:96.1.1(3153414733313030313731323436)
0-0:1.0.0(221212123022W)
1-0:1.8.1(003180.623*kWh)
1-0:1.8.2(004438.105*kWh)
1-0:2.8.1(004994.116*kWh)
1-0:2.8.2(001924.378*kWh)
0-0:96.14.0(0001)
1-0:1.4.0(00.008*kW)
1-0:1.6.0(221205163000W)(03.686*kW)
0-0:98.1.0(0)(1-0:1.6.0)(1-0:1.6.0)()
1-0:1.7.0(00.655*kW)
1-0:2.7.0(00.000*kW)
1-0:21.7.0(00.000*kW)
1-0:41.7.0(00.000*kW)
1-0:61.7.0(00.714*kW)
1-0:22.7.0(00.059*kW)
1-0:42.7.0(00.000*kW)
1-0:62.7.0(00.000*kW)
1-0:32.7.0(230.8*V)
1-0:52.7.0(000.0*V)
1-0:72.7.0(231.3*V)
1-0:31.7.0(005.70*A)
1-0:51.7.0(004.51*A)
1-0:71.7.0(007.48*A)
0-0:96.3.10(1)
0-0:17.0.0(999.9*kW)
1-0:31.4.0(999*A)
0-0:96.13.0()
!FB50

These are the most important:
Current average demand -
Active energy import
1-0:1.4.0*255
Maximum demand – Active
energy import of the running
month
1-0:1.6.0*255
Maximum demand – Active
energy import of the last 13
months
0-0:98.1.0255
(1-0:1.6.0255 ,2)
(1-0:1.6.0*255, 5)
Last 13 months of the maximum demand register (Time of
appearance & Value)
I would be very thankful if you could manage to incorporate these changes, because this would mean these measurements would become easily accessible in Home Assistant.
e-MUCS_P1_Ed_1_7_1.pdf

Hey, thank you for your feature request.
I would love it to add this, but these values are not exposed by the API. I do not prefer adding telegram parsing to this library because this can give some legacy issues later on. HomeWizard currently works on adding more datapoints but I can't give an exact timeline.
I think a nice in-between is something like this to configuration.yaml (from https://community.home-assistant.io/t/homewizard-energy-wi-fi-p1-meter-kwh-meter-energy-socket-and-water-meter/227441/431):
rest:
  - authentication: basic
    scan_interval: 10 # Lower has more resolution, but voltage is a bit 'noisy' so it fills your database fast. Be careful.
    resource: http://<ip_address>/api/v1/telegram
    sensor:
      - name: "Current maximum demand"
        device_class: power
        unique_id: <something_random_or_serial_id>_active_maximum_demand # It does not matter what is added here, but it has to be unique.
        state_class: measurement
        unit_of_measurement: W
        value_template: "{{ (value|regex_findall_index('1\\-0\\:1\\.4\\.0\\([0-9.]*')).split('(',1)[-1].strip() | float }}"
      - name: "Maximum demand this month"
        device_class: power
        unique_id: <something_random_or_serial_id>_current_maximum_demand # It does not matter what is added here, but it has to be unique.
        state_class: measurement
        unit_of_measurement: W
        value_template: "{{ (value|regex_findall_index('1\\-0\\:1\\.6\\.0\\([0-9.]*')).split('(',1)[-1].strip() | float }}"

I do not have a smart meter with these values, can you see if this works?

The first one active_maximum_demand seems to work great.
The second one current_maximum_demand however is not giving the correct numbers:
Current value from<PHONE_NUMBER>00W)(03.686kW) it is giving me 221,205,163,000,000.0 W instead of 03.686kW
Maybe this has something to do with it?

Value
OBIS reference
Attribute
Class ID
Value Format
Value Unit

Maximum demand– Active energy import of the running month
1-0:1.6.0*255
5 (Capture time)
4 (Extended register)
TST
/

2 (Value)
4 (Extended register)
F5(3,3), tag 6
kW

I'm going to be honest with you: this is beyond my capabilities to resolve this.

I think it's fine now.

You have really made my day today.  Thanks for this very appreciated assistance.

Nice! Would you mind reporting back later on how Home Assistant handles when the monthly peak is updated? Do you see a latest update timestamp for example?

I will certainly do ;-)
Just in case, I'll even schedule a reminder. 😊

Hey, Happy new year!
Can you take a minute to check how Home Assistant reports a month-reset? :)

Also: https://github.com/DCSBL/python-homewizard-energy/pull/154

will this be implemented?

Yes. https://github.com/home-assistant/core/pull/85198

Please do not ask HomeWizard support to update your device. They can't do it, the device wil update automatically.

Hey, Happy new year!
Can you take a minute to check how Home Assistant reports a monthy-reset? :)

As promised. I can confirm Home Assistant reports a monthly reset.

Awesome! I was expecting this was the behaviour but it is nice that you was able to verified this!
https://github.com/home-assistant/core/pull/85198

Awesome! I was expecting this was the behaviour but it is nice that you was able to verified this!
home-assistant/core#85198

All credit deserves to go to you, I'm just merely reporting back. ;-)

Hi, I'm new to HA but I've set it up on my Synology NAS and it's running fine!
And because I live in Belgium I would like to add this too.
But I'm afraid I have to admit that I don't have a clue as where to put this.
I copy/paste the text from the post of DCSBL of dec 12th in the configuration. yaml.
But I can't find it via entities. So I have must have been doing something wrong.
Could someone please point me in the right direction?
Thanks!

Just wait for the next Home Assistant release, where this is build in. It will be released on the 1th of Februari 2023.

Ah, even better!! Thanks for the fast reply!!

Is it build in now in Home Assistant version 2023.2.5
I can not find it.


WebUI sluggish when accessed via HTTPS on a 250+ vlan host

Hi,
Thanks for your hard work on the opnsense project !
For the cloud lab i'm trying to setup, i would like to configure a opnsense-on-a-stick router with a trunk link (with more that 500 vlans) between my compute node and the opnsense (physical) server/router so that a vlan could be dedicated ot each of my users.
OPNSense is running bare metal on a host with an Intel® Xeon® Processor E5420 cpu , 8G RAM and 6 NIC
The configuration, which is was partially generated via a mini-script and is attached to  this report (NB:password attribute has been deleted), seems to be correctly imported and the CLI shows that all of the vlan subinterfaces have been created
But, the WebUI is so slow when accessed via https  that it is barely useable :-/ It took me 15 min for example to show the configuration of a single interface. In the meantime, ssh access works just fine.
After trying several options, It appears that disabling the https (and the redirect to https) access  solves the issue !?
Any hint on what could be the bottleneck please :-) ?
config-OPNsense.gw_opennebula.orig.xml.250.txt
Thanks
PS:I tried to copy/paste some Dtrace one-liner to help me find the issue but it seems that Dtrace doesn't work at all even if the modules are loaded :-/ Is that a known issue please ?

@isrc hi there, is this still an issue? we suspect it's the old config system coupled with static php pages (end in ".php" in the address bar). pages will slowly change to MVC, but this takes us all the way into 2018 due to the sheer amount of work necessary.


permessage-deflate compression support

Is permessage-deflate compression supported on flask-sock?  I know this is implemented with flask-socketio if you use eventlet but I can't seem to make compression work with flask-sock.
This is a great project and thank you for your work!

@wilson0028 if you install the main branch of simple-websocket you should be able to use compression, with all web servers.


test: render tests for button component

Description
Add tests for <Button /> component, with no production code changes.
Changelog

[x] should render button correctly
[x] should render different text
[x] should ignore events when disabled
[x] should ignore events when loading

Additional

lgtm 🔥

Should i create snapshot tests for components that are developed? Also having a __tests__ directory for each component would be a much better solution to isolate actual components from their tests. Let me know what you think.

I guess that's so we can have filenames inside the directory that don't need to have 'test' in them, for testMatch rules
https://stackoverflow.com/a/55551668

Yes, but you can use .test.js as an extension for the files inside __tests__ directory. This is how libraries recommend writing test. Ant Design follows the same pattern.

:tada: This PR is included in version 0.28.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Better zoom

No need to have such a fine grained zoom. Zoom twice as much on each button click

👍


Log in bottom sheet with two close buttons

Describe the bug
The bottom sheet "Please log in" has two "X" Close buttons.
To Reproduce
Steps to reproduce the behavior:

When logged out of an iNat account, with no saved observations
Create a new observation
Press on "Upload 1 observation"
See wrong UI in bottom sheet

Expected behavior
The one X close button that is situated above the title "Please log in" and X close button should not be there.
Screenshots

Context (please complete the following information):

Device: [iPhone7]

I like to work on this, can you assign me please?

Closed via #638


Publish does not create a release on github

Preflight Checklist

[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Forge Version:

6.0.0-beta.54

Electron Version:

11.1.1

Operating System:

Windows 10

Last Known Working Electron Forge version::

none

Expected Behavior
Electron Forge creates a new release on my github repo with app installers for chosen platforms after I run "yarn run publish".
Actual Behavior
It behaves exactly like "make", no release was created on my github repo.
Additional Information
My config forge:
"config": {
    "forge": {
      "packagerConfig": {
        "executableName": "Folder Tagger",
        "name": "Folder Tagger"
      },
      "makers": [
        {
          "name": "@electron-forge/maker-squirrel",
          "config": {
            "name": "FolderTagger",
            "exe": "Folder Tagger.exe",
            "setupExe": "Folder Tagger.Setup.exe"
          }
        },
        {
          "name": "@electron-forge/maker-zip",
          "platforms": [
            "darwin"
          ]
        },
        {
          "name": "@electron-forge/maker-deb",
          "config": {}
        },
        {
          "name": "@electron-forge/maker-rpm",
          "config": {}
        }
      ],
      "publisher": {
        "name": "@electron-forge/publisher-github",
        "platforms": [
          "win32"
        ],
        "config": {
          "repository": {
            "owner": "xuanhieu1479",
            "name": "folder-tagger-electron"
          }
        }
      },
      "plugins": [
        [
          "@electron-forge/plugin-webpack",
          {
            "mainConfig": "./webpack.main.config.js",
            "renderer": {
              "config": "./webpack.renderer.config.js",
              "entryPoints": [
                {
                  "html": "./src/index.html",
                  "js": "./src/renderer.ts",
                  "name": "main_window"
                }
              ]
            }
          }
        ]
      ]
    }
  },

Please advice.

You probably have to pass it an authToken, docs: https://js.electronforge.io/publisher/github/interfaces/publishergithubconfig#authtoken

You probably have to pass it an authToken, docs: https://js.electronforge.io/publisher/github/interfaces/publishergithubconfig#authtoken

Unfortunately it does not work. I've tried adding authToken inside package.json and pass it through cli --auth-token= but no luck. Electron forge just runs make then not doing anything, no errors shown either.

The problem is solved.  Also its value is an array not an object. Please close this.


[

[
- - [ ]         // IG05:_[_**[16700 ]()**_]()_

]()
Publicación original de @nelsondani en https://github.com/dotnet/runtime/pull/50115#discussion_r601984694

Closing out because this is off topic. Please open another issue if you'd like to offer feedback on policies governing our site.


Question: Allowed memory size

I am using sabre\dav and sabre\client to send large files to another host, but the response I have got the following error

Allowed memory size of 134217728 bytes exhausted (tried to allocate 31860068 bytes)

I have investigated and have found that the error comes from Sabre\HTTP\Client:499
$headerBlob = substr($response, 0, $curlInfo['header_size']);
$responseBody = substr($response, $curlInfo['header_size']) ?: null;

this issue should be opened at https://github.com/fruux/sabre-http

Yes. But the issue is associated with file transferings

so whats your exact use case. do you post large files? how exactly do you send the payload?

My project based on Laravel ,so I am using putContent() function to put the content of file via url

could you create  a small example which reproduces your issue?

For put, read or update streams I am using FileSytyem. Here is the code which need to send files to another host
$files = $old_storage->files()->withTrashed()->get();

        try {
            foreach( $files as $file ) {
                try {
                    $stream = $file->readStream();
                    $file->setStorage( $storage->id );
                    $file->storage()->getDriver()->putStream( $file->getRealDestination(), $stream );
                    $file->putStream( $file->getRealDestination(), $stream );
                } catch( \Exception $e ) {
                    $file->setStorage( $storage->id );
                }
                $file->save();
            }

            $old_storage->is_active = 0;
            $old_storage->status    = DiskStorage::STATUS_OK;
            $old_storage->save();
            $storage->is_active = 1;
            $storage->status    = DiskStorage::STATUS_OK;
            $storage->save();

I dont know laravel enough to help you with laravel specific code. you should reduce your failing example to something more concrete and related to sabre-dav/http.
at best you could hand us some runnable code which shows/reproduces the problem

which exact version of sabre-dav and sabre-http do you use?

Here is a functions which calling
public function read($path)
   {
       $location = "/abc/13/Storage/Files/6/61bad8ee7dcd736a966d09fbb7839847.mp4"

       try {
           $response = $this->client->request('GET', $location);

           if ($response['statusCode'] !== 200) {
               return false;
           }

           return array_merge([
               'contents' => $response['body'],
               'timestamp' => strtotime(is_array($response['headers']['last-modified'])
                   ? current($response['headers']['last-modified'])
                   : $response['headers']['last-modified']),
               'path' => $path,
           ], Util::map($response['headers'], static::$resultMap));
       } catch (Exception $e) {
           return false;
       }
   }
// Sabre\DAV\Client
function request($method, $url = '', $body = null, array $headers = []) {

       $url = $this->getAbsoluteUrl($url);

       $response = $this->send(new HTTP\Request($method, $url, $headers, $body));
       return [
           'body'       => $response->getBodyAsString(),
           'statusCode' => (int)$response->getStatus(),
           'headers'    => array_change_key_case($response->getHeaders()),
       ];

   }

After sending get method I am getting the error

Allowed memory size of 134217728 bytes exhausted (tried to allocate 31860068 bytes)  Client.php line 498:

nice, I guess we can work with it.
I will close this issue here as it needs to be handled in the http-client.
we will continue the analysis at https://github.com/fruux/sabre-http/issues/82


Autocomplete - Controls - The behavior of Read-only functionality is not as expected

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Autocomplete - Controls - The behavior of Read-only functionality is not as expected
When the auto search field is set to Read-only, we expect the text field to be disabled where the user should not be able to enter any text in the text box and the field should only be focused when the user selects the text field.
Currently, the textbox is active and also user is able to type in search box. After entering the data user will have to give a space and "No results found" text is displayed as shown in the below screenshot:

Steps to reproduce:

Access the storybook
Select Autocomplete web component Default/With Option/With Custom Option
On the canvas section, under Controls set 'Read-only' status to 'True'
Place the cursor on the Search textbox
Enter the required data and give a space

Expected Behavior: When the auto search field is set Read only we expect the text field to be disabled where the user should not be able to enter any text in the text box and the field should only be focused when the user selects the text field.
Current Behavior: The textbox is active and also user is able to type in search box. After entering the data user will have to give a space and "No results found" text is displayed.
Reduced test cases
No response
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Chrome, Firefox, Microsoft Edge
Which npm package?
No response
What version of npm package are you using?
No response
Priority
Low
What product/project are you using Modus Components for?
QA
What is your team/division name?
QA

With disabled attribute set to true, the user is still able to type in the textbox by using keyboard navigation.  This needs to be fixed.

Looks like the expected behavior and current behavior outlined above are accurate.
With read-only enabled you can still select new options from the list, and their value is set in the box (for both single select and multi-select).
The main change needed seems to be not allowing new selections or editing current selections in read-only mode.

@prashanthr6383  Could you confirm if the item needs to remain highlighted while clicking, similar to its behavior when tabbing?


Add more targets to Makefile and make it configurable

I think the Makefile also needs to have the targets:

test
coverage

Also, in the case of using docker, the Makefile could use an environment variable USE_DOCKER to decide how the commands will be executed.

I myself can handle this issue.

This was closed by #261


Enable logging in godot as well

Godot version
4.2
Plugin version
1.0.5
System information
macbook air m1
Issue description
I am trying to connect to another client, one is host one is client:

A - host
B - client

I also have a signaling server running locally, on localhost.
On the browser, everything works. Locally, multiplayer doesn't work. The two players aren't connected, and the callbacks aren't called for disconnected or anything.
While this might be an ok issue or not, the thing would be it would be nice to view this kind of logs in godot also, and maybe with a dropdown for what kind of logs to view.
Steps to reproduce
Exporting and running it with terminal I can see the logs for webrtc and I can see what's happening. For some reason, the ice transport doesn't seem to work while sending something:
2024-03-21 12:38:23.258 INFO  [953767] [rtc::impl::PeerConnection::changeState@1212] Changed state to connecting
2024-03-21 12:38:23.260 INFO  [955025] [rtc::impl::IceTransport::LogCallback@363] juice: Using STUN server stun.l.google.com:19302
2024-03-21 12:38:23.266 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: STUN server binding successful
2024-03-21 12:38:23.266 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Got STUN mapped address <IP_ADDRESS>:51794 from server
2024-03-21 12:38:23.267 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Candidate gathering done
2024-03-21 12:38:23.267 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Connectivity timer started
2024-03-21 12:38:23.267 INFO  [955024] [rtc::impl::PeerConnection::changeGatheringState@1248] Changed gathering state to complete
2024-03-21 12:38:23.361 WARN  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Send failed, errno=1
2024-03-21 12:38:23.361 WARN  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: STUN message send failed
2024-03-21 12:38:38.273 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: STUN server binding successful
2024-03-21 12:38:38.274 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Got STUN mapped address <ip>:51794 from server
2024-03-21 12:38:53.280 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: STUN server binding successful
2024-03-21 12:38:53.280 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Got STUN mapped address <ip>:51794 from server
2024-03-21 12:39:02.917 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Connectivity timer expired
2024-03-21 12:39:02.917 INFO  [955024] [rtc::impl::IceTransport::LogCallback@363] juice: Changing state to failed
2024-03-21 12:39:02.917 INFO  [955024] [rtc::impl::PeerConnection::changeIceState@1230] Changed ICE state to failed
2024-03-21 12:39:02.917 INFO  [955024] [rtc::impl::PeerConnection::changeState@1212] Changed state to failed
2024-03-21 12:39:02.918 INFO  [955006] [rtc::impl::PeerConnection::changeIceState@1230] Changed ICE state to closed
2024-03-21 12:39:02.918 INFO  [955006] [rtc::impl::PeerConnection::changeState@1212] Changed state to closed
2024-03-21 12:39:02.918 DEBUG [955006] [rtc::impl::IceTransport::~IceTransport@160] Destroying ICE transport

Minimal reproduction project
No response

Fixed  via #141


Add stdout check to isTTY

WHY are these changes introduced?
https://github.com/Shopify/shopify-functions/issues/363
When piping the output of a commands such as shopify app dev or shopify app logs, we can sometimes encounter a react infinite render error. This happens when a prompt is supposed to be displayed to the user, but since we've piped the output, it's no longer interactable.
The react error doesn't really explain what's going on, and doesn't leverage the existing error we have in our throwInNonTTY.

WHAT is this pull request doing?
Modifies the existing throwInNonTTY and isTTY functions to also verify that stdout is also TTY.
How to test your changes?

Cause the ensureDevContext check to trigger by editing
/Users/<user>/Library/Preferences/shopify-cli-app-nodejs/config.json
and remove the entry for your app path
Run shopify app logs | more

You should see an error explaining that things need to be run in interactive mode
╭─ error ──────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  Failed to prompt:                                                           │
│                                                                              │
│  Which organization is this work for?                                        │
│                                                                              │
│  This usually happens when running a command non-interactively, for example  │
│   in a CI environment, or when piping to or from another process.            │
│                                                                              │
│  To resolve this, specify the option in the command, or run the command in   │
│  an interactive environment such as your local terminal.                     │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes

Closed in favour of https://github.com/Shopify/cli/pull/4348


Remove duplicate repository key in package.json

Hi maintainers, any chance of rolling a 1.9.3 release with this fix?  It's giving us grief.  Thanks.

Thanks, but the issue has already been fixed in the current release. There will never be another 1.x release. I suggest upgraded, as you would be long overdue.

Hi Doug, yes I do appreciate that, but we've got transitive dependencies on your 1.x which I would love to get rid of but cannot at this time.  Would you mind doing a release just to fix the currently-broken 1.x?  Regards.

No. The 1.x branch is from 2012 -- that is over 5 years ago now. Get those transitive dependencies to upgrade. The 1.x brach has critical security flaws, even...

I agree those projects should upgrade their dependencies.  Unfortunately I don't have control over them.
The "critical security flaws" are not a concern for us as the package(s) in question are only used to run unit tests in a secure environment.
I'll ask a final time:  Would you kindly release the attached fix to your broken package.json so it doesn't break folks (like us) who have no choice in the matter.

The 1.x series is designed for the Node.js & npm of the era when it was released. If you need to use the old release, downgrade to a version of npm that works with the release or upgrade connect.

npm rejects publishing a new version of that branch with your PR merged:
$ npm publish
npm ERR! Tag name must not be a valid SemVer range: 1.8

npm ERR! A complete log of this run can be found in:
npm ERR!     /.npm/_logs/2017-08-08T03_28_26_558Z-debug.log

Seems like the registry has changed at some point in the last 5 years. If npm removes whatever new publish restriction is in place I can publish the version.


coredump on exit

only happens if dGPU has been unloaded with
sudo udevadm trigger --verbose --action=remove --subsystem-match=drm --property-match="MINOR=1"

when sway exits. This suggests that I'm not doing proper cleanup
Also, I have experienced a few kernel panics when exiting sway. Unsure if that is related to my patch or not. If so, that is a massive problem, and difficult to debug. I guess it could be related to this crash because gbm etc... is in the kernel?
           PID: 978161 (sway)
           UID: 1000 (chris)
           GID: 1000 (chris)
        Signal: 11 (SEGV)
  Command Line: /home/chris/code/sway/build/sway/sway
    Executable: /home/chris/code/sway/build/sway/sway
 Control Group: /user.slice/user-1000.slice/session-4.scope
          Unit: session-4.scope
         Slice: user-1000.slice
       Session: 4
       Storage: /var/lib/systemd/coredump/core.sway.1000.250eb2cce95a44c3b5d5460e4ed0b9a2.978161.1602721581000000.zst
       Message: Process 978161 (sway) of user 1000 dumped core.

                Stack trace of thread 978161:
                #0  0x00007fca894c2df6 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x27df6)
                #1  0x00007fca894c69fb n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x2b9fb)
                #2  0x00007fca894c6d79 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x2bd79)
                #3  0x00007fca894c83c4 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x2d3c4)
                #4  0x00007fca894d0e9e n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x35e9e)
                #5  0x00007fca88b91f63 gbm_bo_destroy (libgbm.so.1 + 0x9f63)
                #6  0x00007fca7d105565 n/a (libEGL_mesa.so.0 + 0x1d565)
                #7  0x00007fca7d102bea n/a (libEGL_mesa.so.0 + 0x1abea)
                #8  0x00007fca7d0f4a84 n/a (libEGL_mesa.so.0 + 0xca84)
                #9  0x00007fca894c2bdd n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x27bdd)
                #10 0x00007fca894d0a36 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x35a36)
                #11 0x00007fca894c9f5e n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x2ef5e)
                #12 0x00007fca894c86d2 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x2d6d2)
                #13 0x00007fca894d8749 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x3d749)
                #14 0x00007fca894d88c9 n/a (/home/chris/code/sway/build/subprojects/wlroots/libwlroots.so.6 + 0x3d8c9)
                #15 0x00007fca88e53e0f n/a (libwayland-server.so.0 + 0x8e0f)
                #16 0x00007fca88e545a7 wl_display_destroy (libwayland-server.so.0 + 0x95a7)
                #17 0x000055c946b587ee n/a (/home/chris/code/sway/build/sway/sway + 0x207ee)
                #18 0x000055c946b57f78 n/a (/home/chris/code/sway/build/sway/sway + 0x1ff78)
                #19 0x00007fca88c2b152 __libc_start_main (libc.so.6 + 0x28152)
                #20 0x000055c946b4951e n/a (/home/chris/code/sway/build/sway/sway + 0x1151e)

More specific instructions to reproduce:

Start sway with nouveau loaded
Plug in external monitor
Run sudo udevadm trigger --verbose --action=remove --subsystem-match=drm --property-match="MINOR=1" to unload wlroots backend while keeping external monitor connected.
Exit Sway
Sway should crash with similar coredump as above

To be more exciting:

Run sudo rmmod nouveau before exiting sway.
Should get a kernel panic

When responding to udev events (instead of listening for monitor unplug) I get these errors - seems like cleanup isn't being done properly.
00:00:05.296 [ERROR] [backend/drm/legacy.c:45] HDMI-A-1: failed to set DPMS property: Permission denied
00:00:05.339 [ERROR] [backend/session/logind.c:122] Failed to release device '9': Device not taken

Closing because this was based upon the outdated feature/unload-drm branch. Will reopen if can reproduce with drm-hotplug branch

Closing because this was based upon the outdated feature/unload-drm branch. Will reopen if can reproduce with drm-hotplug branch


Improve Forecast / Current Conditions

Not sure if this is possible based on the available data – and maybe it is already available and I am just missing it. :)
But having an actual weather status beyond metrics would be most useful. For ex. "Sunny, Mostly Cloudy, Light Rain", etc... Temp, wind and pressure are interesting but don't really explain the consequences of weather for humans very well. (i.e. I need an umbrella, or I don't)

The icons are really too small to be usable, so just having access to the underlying text or string that triggers them would solve my issue. :)

@kerns
I had the same issue regarding the icon size and solved it with the following workaround:

Please create a configuration file for ansiweather in the correct scope (just your user account or the whole system).  There is a template to do so in this repository, https://github.com/fcambus/ansiweather/blob/master/ansiweatherrc.example.  For your account on a Linux system, save the example as .ansiweatherrc in your home directory.
The icons (ll. 36) are strings which are displayed for the respective weather situation.  You can enter any text there which is going to be displayed, then.  The default string is the Unicode icon the template ships with.  For example, I altered the string for rain in my configuration from rain:\033[37;1m\xe2\x98\x94 to rain:\033[37;1m\xe2\x98\x94 (rainy) such that now, after the icon the additional information "(rainy)" is shown.  Some terminals show rather large icons, so an additional information was my preferred solution.  The simplest way is to repeat the name of the weather situation, such as rain:rain, snow:snow and so on.

Does this suggestion solve the problem for you?

@kevinmatthes It could! Maybe I would just go with rain: Rain etc, as the icons are too small to be interpreted in my shell in any case. Thanks for the suggestion. 🙏


failed to connect to database

I create a user and database in my PostgreSQL. But I can't start chaind in docker, it's eror log: 'failed to start chain database service: failed to connect to database: failed to connect to host=localhost user=chain database=: dial error (dial tcp [::1]:5432: connect: cannot assign requested address)'

You could try changing you host to <IP_ADDRESS>.  Alternatively, your postgresql server may not be configured to listen on port 5432.  You can check that by running psql -h localhost -U chain on a command line: if it fails to connect you will need to look at your postgresql configuration to enable it to listen on that port.


Content of microprofile-config.properties contains entries for non selected specifications

In the case Config and/or Rest Client is not selected, the file microprofile-config.properties still contains values of the examples for those spec examples.

Fixed By #243


SSA Refactor: Remove tech debt when moving to the SSA refactor

Problem

PR #1728 implements syntax for slices into Noir. However, as we are moving to the new SSA pass, the PR only implements slices in the new pass while breaking changes were made to the frontend in order to get slices fully working. This means that the experimental_ssa flag is now needed not only to determine which SSA to generate but also during compilation.

There are features aside slices that touch the frontend but are only implemented using the new SSA. For example after the refactor in PR #1917 we have two different implementations of println. One that uses the old refactor and one that uses Brillig foreign calls. The experimental_ssa flag is used again here to determine whether we should use one println or the other.

We have unneeded transformations like the array of structs to struct of arrays conversion during monomorphization that can be removed once the old ssa code is removed. Removing this would lead to a more intuitive serialization order when going back and forth between Noir and TypeScript.

Happy Case
The enable_slices flag inside of the NodeInterner should be fully removed and all of its conditional checks within the frontend. The array of structs to struct of arrays conversion should also be removed.
Alternatives Considered
N/A
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

We should re-evaluate https://github.com/noir-lang/noir/issues/562 when closing this too

@kevaundray, #562 should be unrelated since that is a type system bug

@kevaundray, #562 should be unrelated since that is a type system bug

When we make this the default, we would also be merging in the breaking change which would force users to use [T;N] instead of [T], so I think that would issue may be fixed

This issue should also be reviewed once this is closed, since this can only be closed after dynamic indices: https://github.com/noir-lang/noir/issues/793

Once the experimental ssa is merged we can also close https://github.com/noir-lang/noir/issues/1982 and https://github.com/noir-lang/noir/issues/1986, which are issues with the old ssa.

Also adding: https://github.com/noir-lang/noir/issues/1830

Adding https://github.com/noir-lang/noir/issues/1925

This was mentioned here: https://github.com/noir-lang/noir/issues/1842

I've closed the linked issues which are fixed by just using the new SSA.

All relevant bugs and changes listed here have been completed.


Put hydra advances query result in a public s3 bucket somewhere on a cron job

@mweinelt :)
Is your feature request related to a problem? Please describe.
We have no good way of bisecting hydra anymore since the grahamc service died a year ago. But we have the data, it is just locked behind the hydra API being busted, and can relatively easily simply be obtained from the database. Although there is definitely merit in doing the https://pad.lassul.us/opendata-projects and making an open hydra read replica, this requires effort.
I have written a tool https://github.com/lf-/necktangler, and a ~5s sql query to run against hydra, where the result could simply be put in a s3 bucket on a nightly cron job and we could call it a day.
Describe the solution you'd like
Put this query in a cron job somewhere with hydra DB access, and run it with:
psql $SOME_CONNECTION_DETAILS -v job=tested -v project=nixos -v jobset=trunk-combined --csv -f hydra-query.sql > data-nixos-unstable.csv
psql $SOME_CONNECTION_DETAILS -v job=tested -v project=nixos -v jobset=unstable-small --csv -f hydra-query.sql > data-nixos-unstable-small.csv
psql $SOME_CONNECTION_DETAILS -v job=unstable -v project=nixpkgs -v jobset=trunk --csv -f hydra-query.sql > data-nixpkgs-unstable.csv
psql $SOME_CONNECTION_DETAILS -v job=darwin-tested -v project=nixpkgs -v jobset=nixpkgs-23.11-darwin --csv -f hydra-query.sql > data-nixpkgs-23.11-darwin.csv
psql $SOME_CONNECTION_DETAILS -v job=tested -v project=nixos -v jobset=release-23.11 --csv -f hydra-query.sql > data-nixos-23.11.csv
psql $SOME_CONNECTION_DETAILS -v job=tested -v project=nixos -v jobset=release-23.11-small --csv -f hydra-query.sql > data-nixos-23.11-small.csv
# s3 upload to some bucket somewhere

select
    jsei.revision as sha, b.timestamp as advance_ts, concat(j.project, ':', j.name, ':', b.job) as hydra_job, b.id as hydra_build_id
    from jobsets j
        inner join builds b on j.id = b.jobset_id
        inner join jobsetevalmembers jsem on jsem.build = b.id
        inner join jobsetevals jse on jsem.eval = jse.id
        inner join jobsetevalinputs jsei on jsei.eval = jse.id
    where
    b.job = :'job' and
    j.project = :'project' and
    j.name = :'jobset' and
    jsei.name = 'nixpkgs' and
    b.finished = 1 and
    -- arbitraily chosen start in time; there are some bogus commit IDs from
    -- 2014 or so, which we would rather not deal with
    b.timestamp > extract(epoch from '2018-01-01T00:00:00Z'::timestamptz)
    order by b.timestamp asc

(nixpkgs-unstable is 8571 rows, nixos-unstable is 3000 rows, from several years. imo we have no reason to shard this any time soon)
Describe alternatives you've considered
Going and building a public read replica of hydra (sounds like effort).
Being unable to bisect hydra.
Additional context

An alternative could be to add this particular API endpoint in the Hydra code and deploy it fast.


Change the way of getting slotted elements / Fix demo

These changes fix problems when using Firefox and Edge.

Tries to solve #4, but it isn't working in IE11.


Start entombing "VCAP Framework"

Create new vcap_sarcophagus directory to confine code relating to the
the "vcap framework"
The objective is to separate code responsible for cloud controller
business logic from framework code that can be replaced with Rails
This will let us delete the code in the sarcophagus once we are able
to remove the v2 API (and move fully to Rails)
The distinction between "business logic" code and "framework" code is
fuzzy at best, so this will likely take multiple iterations to get
right. Hopefully this will help us better track calls that cross the
boundary between the sarcophagus and the rest of the codebase.

See sarcophagus README for more details

@Gerg can you take a look at the conflicts?  github tells me they're too complex to resolve in the web editor 😂

@selzoc rebased


fix(postslistitem.vue): color of category and tags not change by hover

Sorry for delay.
It looks a little strange for the different behaviors of category and tags:

here

Yes, that's the initial reason why I didn't change the hovered color 😅

没明白，明明可以点击，hover时颜色却不变，这样有什么好呢？


Make makeRandom public

Super useful method for me when generating random numbers for RGB colour values. As I haven't found a better way, I would suggest to make this public?
makeRandom(min: 0, max: 256)
potentially it could be called something like randomNumber or randomInt?

Why note use the Swift 4.2 Random APIs? Is that version not available to you yet?

oh ... will have to take look :) I wasn't aware of that change :) @calebkleveter

@tanner0101 should I close it and wait for 4.2 then?


Eureka client not brining back the list of Servers when dockerised — current list of Servers=[],

Describe the bug
https://stackoverflow.com/questions/64634228/eureka-client-not-brining-back-the-list-of-servers-when-dockerised-current-li
Kindly help

Closing in favor of stack overflow. Please don't cross post.


Fix fetch-configlet bash script for windows

Sync with upstream https://github.com/exercism/configlet/pull/156

This correctly sets the OS and EXTension when on windows, even when in bash
(or a different bourne-shell).

Additionally this uses unzip if the extension is zip, as tar will correctly say the
zip is not a tar. unzip does not allow for piping, so a temporary file is created.

@tejasbubane given that you're not on Windows and this was approved and merged upstream, I've just went ahead and merged ✔


Cannot deploy Service from VS to Kubernetes anymore

Describe the bug
Today I started to receive this error when trying to debug from VS:
An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = KubernetesExec (ReflectionActivator), Services = [Microsoft.Azure.DevSpaces.ExecService.ContainerOrchestratorExecs.KubernetesExec, Microsoft.Azure.DevSpaces.ExecService.ContainerOrchestratorExecs.ContainerOrchestratorExecBase], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An exception was thrown while invoking the constructor 'Void .ctor(Microsoft.Azure.DevSpaces.Common.Services.Kubernetes.IDevSpacesHelm2Client, System.Func2[Microsoft.Azure.DevSpaces.Common.Services.Helm3.Model.Helm3ClientConfiguration,Microsoft.Azure.DevSpaces.Common.Services.Kubernetes.IDevSpacesHelm3Client], System.Func3[Microsoft.Azure.DevSpaces.Common.Logging.LoggingConstants+TargetCluster,k8s.KubeConfigModels.K8SConfiguration,Microsoft.Azure.DevSpaces.Common.Kubernetes.IKubernetesClient], System.Func2[k8s.KubeConfigModels.K8SConfiguration,Microsoft.Azure.DevSpaces.Common.Services.Spaces.ISpaceManager], System.Lazy1[Microsoft.AspNetCore.SignalR.IHubContext`2[Microsoft.Azure.DevSpaces.ExecService.SignalR.ExecSignalRHub,Microsoft.Azure.DevSpaces.ExecService.Client.Streaming.IExecStreamingClient]], Microsoft.Azure.DevSpaces.Common.Logging.ILog, Microsoft.Azure.DevSpaces.ExecService.Services.IConfigDocumentStore, Microsoft.Azure.DevSpaces.Common.Cache.ICacheService, Microsoft.Azure.DevSpaces.Common.IO.IFileSystem, Microsoft.Azure.DevSpaces.ExecService.IExecEnvironmentVariables, Microsoft.Azure.DevSpaces.ExecService.KubeConfigProvider)' on type 'KubernetesExec'. ---> Object reference not set to an instance of an object. (See inner exception for details.) (See inner exception for details.)
I'm getting the same error on all services I'm trying to debug.
This has been working fine before.
No changes has been made to my local computer or to our cluster.

I am getting the exact same error.
Trying to work out what has changed, and the only thing I can see, is a possible update to the azds images used when initialising the related pods.
https://hub.docker.com/r/azds/azds-image-prepull/tags
The DaemonSet in my azds namespace is showing image:  azds/azds-image-prepull:20200430.4
Which was last updated 6 days ago.
I don't know how/when new images are pulled in... but all my pods were reinitialised overnight and now I cannot build!
I am still getting to grips with Devspaces + Kubernetes - so hopefully some of this will make sense to someone and we can get a quick fix.

@Eneuman Are you able to confirm that images in the azds namespace are running at the same version as mine? Would be good to know if I am on to something - or clutching at straws.
You can get image info usign the following command (assuming you are using kubectl)
kubectl get pods --namespace azds -o jsonpath="{..image}"

Thanks for reporting this! I've identified the issue on our side, and we'll work on getting a fix rolled out ASAP.

@Eneuman or @d4devblog we have a fix available and would like to verify it on your controllers before deploying everywhere. Please email me<EMAIL_ADDRESS>your subscription ids and controller names where you're seeing this issue, and I'll try to patch them.

Hi @ynambiar Thanks for the quick response on this.
Email sent!

Apologies to everyone who ran into this issue. A fix has been rolled out and all controllers have been updated. Please give it a try and let us know if you see any problems.


Update Tekton tasks for pde2e images to be aglined with the lately added parameters

Especially the changes here: https://github.com/containers/podman-desktop-e2e/issues/130 and here: https://github.com/containers/podman-desktop-e2e/issues/129

Fixed by: https://github.com/odockal/pde2e-runner/commit/bfe2491fd71409bc346c7e7aa91f629b2ec23081


Subtitles incorrectly forced?

An SRF user reported the following issue:

Habe mich schon mal via Twitter gemeldet - bei mir läuft seit dem letzten iOS Update das Streaming via AirPlay überhaupt nicht mehr.

So kann es dann eine Weile weitergehen, oder es stoppt komplett. Abschiessen der App hilft nicht, danach lässt sich der Playback für diese Sendung gar nicht mehr starten - passiert einfach nichts,
Eine neue Sendung läuft dann wieder, aber wie oben.
Mein Setup: iPhone XS Max, aktuelles iOS -> AppleTV 4K, ebenfalls aktuell. AppleTV hängt an Ethernet.
Beispiel Sendungen wo das bei mir passiert:
Mini Schwiiz, dini Schwiiz, Stadt Bern - Tag 1
Mini Schwiiz, dini Schwiiz, Solothrun - Tag 4
Übrigens, bei mir wird auch immer der Untertitel angezeigt, obwohl ausgeschaltet. Wenn ich nochmals auf “Aus” clicke, verschwindet er aber.

I could not reproduce the AirPlay quality issues (for which we have no real control). For subtitles, @ahmedgoumri provided us with the following reproducible scenario:

Make sure in setting that subtitles are turned off
Start Play SRF App and play a video with subtitles (here: Kassensturz from editorial tipps)
show subtitle settings (Subtitles turned offI
Activate AirPlay. at first try, no subtitles shown on AirPlay 4K device.
Stop and Play same video again. Subtitles are displayed on AirPlay device. Settings still the same (Subtitles turned off)
Any further video on Airplay is displayed with subtitles .

At first I could not reproduce this issue with these instructions either. This might depend on device settings, though, and needs further investigation.
Here are a video capture of the issue, as well as the device language and accessibility settings:

Issue type
Incorrect behavior
Description of the problem
Environment information

Library version: 3.0.0
iOS version: Any
Device: Physical

Reproducibility
To be determined.

I could find out what forces subtitles when using AirPlay. It is the Apple TV itself which saves the last choice made on it in the top pane displayed during playback (swipe down with Apple Remote), and restores it.
At least this is what I could verify with my Apple TV running tvOS 13. I cannot remember which was the behavior on tvOS 12, maybe this is something that changed with tvOS 13.
Here is how to reproduce and understand this behavior (for simplicity I only use Off and German subtitles settings; the Automatic setting depends on device settings and device / content languages):

Open Play SRF on a mobile device and pick a content with subtitles (e.g. 10vor10). Set subtitles to Off.
Play the content and enable AirPlay from the player.
On the TV receiver, open the subtitles settings pane at the top, and choose Off.
Close and reopen the content on the mobile device. Subtitles are still off.
On the TV receiver, now choose German subtitles.
Close and reopen the content on the mobile device. German subtitles are automatically displayed (a choice reflected on the mobile, where the subtitles icon is highlighted).
On the TV receiver, select Off again.
Close and reopen the content on the mobile device. Subtitles are now off.

This behavior is consistent with the behavior observed when doing the same withAVPlayerViewController, the standard Apple player. So it is consistent with what the platform enforces.
It remains to be determined whether this is an iOS 13 change, by reproducing the above steps with a tvOS 12 receiver. If this is a change, we can either recognize it as such (after all, it can make sense to have the same accessibility settings we have on iOS saved on tvOS as well). Otherwise we can file a bug report for a regression.
In the meantime, the workaround is of course to use the Apple remote to disable subtitles on the receiver.

We could / should probably document subtitle expected behavior better with proper use cases. This would make it far easier to test this feature for regressions in the future.
In the meantime, I might have spotted two minor issues on our side:

When using AirPlay, Automatic is disabled on the mobile device but can be tapped anyway.
With the subtitles window open on mobile, the subtitle choice is not correctly updated when changing subtitles on the TV.

Here is my proposal to solve this issue:

Study AVPlayerViewController behavior carefully.
Document use cases.
If possible and meaningful, try to explain the current behavior in the tracks selection popover

This is a bug on our side. Though the Apple TV receiver saves the last used language as well, it influences the default language on a casting device.
I opened a dedicated issue for SRG Media Player.

Fixed, will be available in version 3.0.0.


Add data migration mechanism to update elastic search data and structure regarding ver. no.

Migrations should be stored in separate Json files in vuestorefront-api and executed using alias like: npm run migration

Duplicate of https://github.com/DivanteLtd/vue-storefront-api/issues/2


validate "required"

I see the past issues around validate onSubmit and I would like to give a +1 for that feature. react-select v2 does not support the required prop so ideally we could get around that with a validator like validate: value => !!value
bring on the breaking changes!

I've faced a similar difficulty and wrote about my workaround
See https://github.com/wsmd/react-use-form-state/issues/56#issuecomment-537768840

Hi @keeganstothert!

bring on the breaking changes!

😄

does not support the required prop so ideally we could get around that with a validator like validate: value => !!value

I think is might be a great use case for the validate method. I'm not quit sure if there's a need to introduce  an additional method to validate the requirement of an input.
Have you considered separating your validators and re-composing? For example, you can have a isRequired function solely for this purpose.
compose = (...fns) => /* compose implementation */;

const isRequired = value => !!value;
const isEmail = value => EMAIL_REGEX.test(value)

<input
  {...text({
    name: 'email',
    validate: compose(isRequired, isEmail),
  })}
/>

That said, I'll keep this in mind for future releases.


[question] Transfer hyperparameters from optuna

For learning purposes I am tuning a number of algorithms for environment 'MountanCar-v0'. At the moment I am interested in PPO. I intend to share tuned hyperparameters working putting them on your repo. I try to understand the working with some depth of a variety of algorithms hands-on. SB3 and zoo are great tools to get hands-on.
So I was using optuna from zoo to find the right parameters for PPO, and by the results produced by it I would say that the hyperparameters should work:
I execute as indicated:
train.py --algo ppo --env MountainCar-v0 -n 50000 -optimize --n-trials 1000 --n-jobs 2 --sampler tpe --pruner median
Output:
========== MountainCar-v0 ==========
Seed:<PHONE_NUMBER>
Default hyperparameters for environment (ones being tuned will be overridden):
OrderedDict([('ent_coef', 0.0),
('gae_lambda', 0.98),
('gamma', 0.99),
('n_envs', 16),
('n_epochs', 4),
('n_steps', 16),
('n_timesteps', 1000000.0),
('normalize', True),
('policy', 'MlpPolicy')])
Using 16 environments
Overwriting n_timesteps with n=50000
Normalization activated: {'gamma': 0.99}
Optimizing hyperparameters
Sampler: tpe - Pruner: median
Then one nice result is:
Trial 151 finished with value: -95.4 and parameters: {'batch_size': 256, 'n_steps': 32, 'gamma': 0.999, 'learning_rate': 0.00043216809397908225, 'ent_coef': 5.844122887301502e-07, 'clip_range': 0.2, 'n_epochs': 10, 'gae_lambda': 0.92, 'max_grad_norm': 2, 'vf_coef': 0.035882158772375855, 'net_arch': 'medium', 'activation_fn': 'relu'}. Best is trial 151 with value: -95.4.
Normalization activated: {'gamma': 0.99}
Normalization activated: {'gamma': 0.99, 'norm_reward': False}
When passing these hyperparameters to the algorithm it does not work. I do not exactly understand why.
envm = make_vec_env("MountainCar-v0", n_envs=16)
policy_kwargs = dict(activation_fn=th.nn.ReLU, net_arch=[dict(pi=[254,254], vf=[254,254])])
model = PPO("MlpPolicy", envm, verbose=1, batch_size=256, n_steps=2048, gamma=0.9999, learning_rate=0.00043216809397908225, ent_coef= 5.844122887301502e-07, clip_range=0.2, n_epochs=10, gae_lambda=0.92, max_grad_norm=2 ,vf_coef= 0.035882158772375855, policy_kwargs=policy_kwargs )
model.learn(total_timesteps=1000000)
model.save("ppo_mountaincar")
As I read it in the docs, I would say it is supposed to work like that, am I wrong? Should I take something else into account?

Hello,
you are apparently posting in the wrong repo ... (SB2 one, not SB3)
Please use markdown codeblock to format the code too ;)
There are actually related issues in the other repo (and some PR are going to be made to automate that process): https://github.com/DLR-RM/rl-baselines3-zoo/issues/121

I am sorry for that. I shall format in code blocks as you ask and put the question where it belongs. :)
I will check the questions/issues raised in the right repo


Is posible to dismiss when background is tapped?

Hey!
First of all, thanks for this amazing piece of work. I have just one question, it is posible to dismiss a card when the background is tapped? I have tried using the method "actionForTappedOnBackground" but it is not being called when tapping the background.
I would appreciate your help.
Thanks!

It worked when using this code:
- (id)initWithFrame:(CGRect)frame
{
    self = [super initWithFrame:frame];
    if (self) {
        // Initialization code
        UITapGestureRecognizer *tap = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(backgroundTapped:)];
        [self addGestureRecognizer:tap];
    }
    return self;
}
- (void)backgroundTapped:(UITapGestureRecognizer *)tgr{
    CGPoint touchedPoint = [tgr locationInView:self];
    if (!CGRectContainsPoint(self.containerView.frame, touchedPoint)) {
        NSLog(@"Hey! Background Tapped");
    }
}

Hi,
Sorry, I must forgot to implement that.


[Overlay] Add FullScreenInteractiveExceptElementId

[Overlay] Add FullScreenInteractiveExceptElementId
Introduction
In some use cases (see #2567#issuecomment-2307956048, it's useful to allow the user to interact with components placed under the FluentOverlay (with the possible exception of certain zones). To manage this, we've added the pointer-events: none style, which disables event handling on the FluentOverlay and allows interaction with other elements on the web page. It is then necessary to add a global event document.addEventListener via the FluentOverlay.razor.js script (register it and remove it at the end of use).
Stay interactive
By using the FullScreenInteractiveExceptElementId property, only the targeted element will not close the FluentOverlay panel. The user can click anywhere else to close the FluentOverlay.
When this property is set, the FullScreen is automatically set to True.
In this example, when the Stay interactive switch is checked, the FluentOverlay will only close when the user clicks outside the white zone and the user can increment the counter before to close the Overlay.
When the switch is unchecked, the FluentOverlay will close when the user clicks anywhere on the screen.
Simplified example
<FluentOverlay @bind-Visible=@visible
               FullScreen="true"
               FullScreenInteractiveExceptElementId="my-zone">

Non-interactive zone

    <FluentProgressRing />

</FluentOverlay>

The FullScreenInteractiveExceptElementId property implies two things:

The overlay is full screen interactive
Except for an element id

Is there a reasonable case that someone wants a full screen interactive overlay and no exceptions? If yes, then they can't achieve it with this property and probably we need a separate FullScreenInteractive property which is of type bool and current FullScreenInteractiveExceptElementId is for the exception element id only, null or empty means no exceptions.
Actually, there's a FullScreen property, so perhaps just have two more properties: Interactive of type bool and InteractiveExceptElementId of type string?, three properties, each one has simple and dedicated purpose.

If the dev want no exception, he can set an unknown ID. This ElementId will never found to have the expected result.
We don't check if the ID exists in the HTML DOM, we try to find it.

I would say it's not straightforward and more like a workaround, but it does the trick.

I think the functionality this offers is good but the name of the parameter is a bit verbose and unclear. Maybe change to something like DissmisExemptId?

I would say it's not straightforward and more like a workaround, but it does the trick.

I agree. I could add a paragraph in the documentation to explain that. And to add a global constant NoException = Identifier.NewId() to be more explicit for the dev.

I think the functionality this offers is good but the name of the parameter is a bit verbose and unclear. Maybe change to something like DissmisExemptId?

I was waiting for you on the name 😀. I couldn't think of a simple name. Your proposal is easier but remove the info of Fullscreen and Interactivity (maybe not interesting).
Other proposals ? InteractiveExceptId, ...

I was waiting for you on the name 😀. I couldn't think of a simple name.

😂 I think the fact the name says you exempt an ID from dismissing (I misspelled earlier) the overlay kind of implies interactivity.
The full screen aspect can be clarified in xnl and developer docs

I still think it may be helpful to separate three concepts:

Full Screen
Interactive
Interactive Exception Element Id

Separating 1 and 2 can make the interactive available for non-full-screen as well if it could be a potential scenario.
Separating 2 and 3 can be intuitive for people who wants the interactive overlay only, simply set Interactive to true other than an NoException to InteractiveExceptionElementId because the Interactive emphasize interactive, can be true/false, the InteractiveExceptId emphasize an element id, set it a special NoException is not very intuitive for interactive only even if it's elaborated in document, unless the name is InteractiveButExceptId, a longer name but emphasize both interactive and except id.

@RickyLin we can't separate the interactivity from the full screen part because it relies on a addEventListener on the document on the JS side.
Denis will spilt out the Interactive and the InteractivityExcludedElement concepts.

Yep, Probably using Interactive = true and InteractiveExceptId = "my-id" will be easier for the dev (without this ID, the entire page will be interactive).
Of course, these properties will be dependent: InteractiveExceptId will be ignored if Interactive = false; and using Interactive will automatically set FullScreen = true .
Make sense?

Yes, makes sense to me!

It's almost perfect to me. One last thought, can it support non-full-screen scenario? In that case, shall we look for the container element that the FluentOverlay covers then add event listener to that container element instead of the document element? I know it may be a rare case, but it would make the feature perfect if it won't take much effort.

It's nearly perfect for me. One last thought, for non-full-screen scenario, if we add event listener to the container element of the FluentOverlay based on its absolute position (nearest non-static positioned ancestor element?) instead of the document element, then it makes the same semantic for the full screen FluentOverlay and can decouple the FullScreen property.

One last thought, for non-full-screen scenario, if we add event listener to the container element

Mmm. Let me try if it's possible (but using the FluentOverlay element, not using the absolute position).

PR fixed (and description updated)


Added clickable logo

Description
Made devFind paragraph logo clickable
Related Issues
Fixed Issue #207
Changes Proposed
Included hyperlink tag to make the devFind paragraph logo clickable. I have also made this specific link not underlined on hover.
Hyperlink tag added here in .jsx file:

dev
Find

css added to the specific hyperlink tag added here:
a.titlelink:hover {
text-decoration: none;
cursor: pointer;
}
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers
Please let me know if there are any issues, concerns or anything that needs modification.
Thanks

@MuhammadNoorani Yes, it re-directs to: https://dev-find.vercel.app/
please see attached for relevant screenshot where it shows the link on bottom left where it re-directs.

Thank you @MuhammadNoorani for the feedback, it is very much appreciated!
I am glad to have contributed to this project, I am looking forward to seeing it grow.

@CameronSquires Look good to me. Thanks for the contribution.


Create python-app.yml

This workflow will install Python dependencies, run tests, and lint with multiple versions of Python # For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
name: Python application
on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]
permissions:
contents: read
jobs:
build:
runs-on: ubuntu-latest
strategy:
  matrix:
    python-version: [3.7, 3.8, 3.9, 3.10]

steps:
- name: Checkout repository uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }}

- name: Cache dependencies uses: actions/cache@v3 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} restore-keys: | ${{ runner.os }}-pip-

- name: Install dependencies run: | python -m pip install --upgrade pip pip install flake8 pytest if [ -f requirements.txt ]; then pip install -r requirements.txt; fi

- name: Lint with flake8 run: | # stop the build if there are Python syntax errors or undefined names flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

- name: Test with pytest run: | pytest

- name: Upload Test Results if: always() uses: actions/upload-artifact@v3 with: name: test-results-${{ matrix.python-version }} path: ./test-results

Summary
Changes to recipe:  lib/[version]
Motivation

Details

[x] Read the contributing guidelines
[x] Checked that this PR is not a duplicate: list of PRs by recipe
[x] Tested locally with at least one configuration using a recent version of Conan

Hope it's helpfull!


limit 999 contacts

Hi, tell me please, is it a temporary limitation or not?

Get the 'Size must be smaller then 999' error message on Android.
(Picked up 1700 contacts successfully on iPhone.)
Is there a workaround for this?

Also hitting this, can't even batch around it. Please let us know if there is an intent to fix?

// this works
for (start; start < count; start=start+batch) {
range = start+batch > count ? count - start : batch;
newArray.push(...await pagedContacts.getContactsWithRange(start, range, [
PagedContacts.displayName,
PagedContacts.phoneNumbers
]));
};

thanks @UkRedi
I tried the multiple promise version of that resolving into a Promise.all(). Was still having issues, but I'll loop back to test waiting on each batch. I'll update when I get the chance.

@UkRedi What you posted isn't working for me.
I definitely feel like this should be marked as a bug. If I try to batch using batched promises, I continue to get SQLite exceptions (either "expression tree is too large max depth 1000 , or similar, where android is evidently trying to evaluate SQL queries that are much too large). Still not finding a reliable way to fetch contacts off of an android device w/ more than 1000 contacts.
For testing, Lorem Contacts works well to quickly generate thousands of contacts. As @UkRedi posted, I'm only trying to get names and PNs.


ubuntu permission in /run/ceph for ceph user

Permission denied when admin socket try to create the socket files in /run/ceph when the socket files does not exists.
Typical error when /run/ceph is empty and sudo is not installed :
-1 asok ... AdminSocket::bind_and_listen: failed to bind the UNIX domain socket to '/var/run/ceph/ceph-mon.5okl0xw8mc.asok': (13) Permission denied

With a little add in this file, it works :
https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-common/tasks/create_ceph_initial_dirs.yml#L10
    - /run/ceph

like this :
---
- name: create ceph initial directories
  file:
    path: "{{ item }}"
    state: directory
    owner: ceph
    group: ceph
    mode: 0755
  with_items:
    - /run/ceph
    - /etc/ceph
    - /var/lib/ceph/
    - /var/lib/ceph/mon
    - /var/lib/ceph/osd
    - /var/lib/ceph/mds
    - /var/lib/ceph/tmp
    - /var/lib/ceph/radosgw
    - /var/lib/ceph/bootstrap-rgw
    - /var/lib/ceph/bootstrap-mds
    - /var/lib/ceph/bootstrap-osd

Can you provide more context? How did you run the playbook without sudo on your machines?

@nabbar

@nabbar not sure why /run/ceph would work better than /var/run/ceph, you're saying /run/ceph but the error appears on /var/run/ceph. This is really confusing.

you're saying /run/ceph but the error appears on /var/run/ceph. This is really confusing.

I don't have more context here, but for this I think /var/run/ is a link of /run.

@nabbar are you still experiencing this issue?

Closed due to inactivity, feel free to re-open if needed. Thanks!


Connection Forcibly Closed

When I attempt to connect as a client, I am able to but then get this message:

[Errno 10054] An existing connection was forcibly closed by the remote host
and I get disconnected. I am using python as my client and seems to only break if I attempt to send something. Also used to work before but now doesn't

@edfungus, set the log level to info and check log/emqttd_error.log

It said:

[error] MQTT detected framing error invalid_mqtt_frame_len for connection

So I went to the emqttd.config, increased the max_packet_size and now all is well.
Thanks!


Fixes 'spo folder roleinheritance reset' and 'spo file roleinheritance reset' commands. Closes #3750

Fixes spo folder roleinheritance reset and spo file roleinheritance reset commands. Closes #3750

Thanks @nanddeepn for your awesome work. We'll review it ASAP 👍

Thanks @nanddeepn for the quick turn around. I'll review it ASAP.
You rock 🤩

merged manully


How to translate custom attributes like text input placeholder?

Eg:
<input type="email" name="email" data-i18n-key="emailPlaceholder"<EMAIL_ADDRESS>/>
Currently it is actually inserting the value of the translation as a value.
(I am using vanilla js fyi)

You could use a naming convention like data-i18n-attr="placeholder" data-i18n-attr-placeholder-key="emailPlaceholder" and then use element.setAttribute('placeholder', translation).


Remove cap on NearestNeighbors.jl version

Currently version is capped: NearestNeighbors = "<0.4.14" but 0.4.16 is the latest. Is there a reason for this?

Yes there was a reason, but I can now update to <0.4.14,>0.4.15.
https://github.com/KristofferC/NearestNeighbors.jl/issues/173

Landed in v0.1.5 https://github.com/OutlierDetectionJL/OutlierDetectionNeighbors.jl/commit/256ebe6a9a64c189b11c30a3ef6bceb3c2e29b61

Thanks!


feat: syncindex can handle large queryset, allow for nonstandard pk models

Added ability to have non standard ids and large queryset handling for syncindex

allow for large querysets at syncindex
legacy models with non standard pks supported

need to add tests

It all looks great, the last thing are the tests and I think we will be good to merge! Thanks for the feature, I really appreciate it and I think it'll add a lot to the library!

Will probably be in the next few days! :)

got some time added tests... also a makefile to make it easier for people to list.. just set it up and go test

⚠ GitGuardian has uncovered 1 secret following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🔎 Detected hardcoded secret in your pull request
🛠 Guidelines to remediate hardcoded secrets
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

lol yep.. good thing its just a random hex ;)

Added tests read for you to review


Backport changes to v1.24

This backports the following commits to v1.24 branch:

https://github.com/kiali/kiali-operator/commit/8e5d04d8485284376e9e66fcd51d0be46b4dc06e
https://github.com/kiali/kiali-operator/commit/ef176e2ac209d6aba0403d06bce5c7641d6826ff
https://github.com/kiali/kiali-operator/commit/1d0c4c67c278c035adf38a8f294d738fc278f735
https://github.com/kiali/kiali-operator/commit/6ad8ada2026c477f4a714314a399e09e4ede6897

We most likely want this, too - so do not merge this backport PR until this PR is merged and we backport it also: https://github.com/kiali/kiali-operator/pull/284

@jshaughn This should be ready for review and merge


Fix invalid annotation property in ECO:0006154 declaration

Hi !
Latest version of ECO has an issue in the ECO:0006154, where the obo:creation_date property was used instead of the obo:created_by. This PR fixes that.

Hi @althonos
I made the change and completed a release just now. Did not realize that you sent a pull request on my phone. I did not pull your request, sorry. But you should be good now.
Thanks,
Suvvi

No problem as long as it is fixed :wink:

Thanks Martin. Closing now.


Replace ImageList impl with NamedTuple

For better support with torch.jit.script.
See https://github.com/pytorch/pytorch/issues/42258 for background, https://github.com/pytorch/audio/pull/861 for a similar change.
This allows executing the script without Python (no custom Python class, until https://github.com/pytorch/pytorch/issues/46944 is fixed).

@fmassa mind to take a look? Thanks!

Hi @byronyi
This PR in principle looks good to ma and seems backwards-compatible, so I don't have any concerns merging this.
But could you clarify a bit on the case where this doesn't work with torchscript on our case? The Faster R-CNN model inputs are List[Tensor], and we only convert internally to an ImageList, so I would have expected this to work.
Additionally, we were able to export Faster R-CNN into a mobile application and run it successfully there (without relying on any Python code), so I wonder if this is a problem on our case? Would you have a snippet that would trigger this issue on torchvision?

It doesn't script the following method (and no class definition either):
%image_list.1 : __torch__.torchvision.models.detection.image_list.ImageList = prim::CreateObject()
%156 : None = prim::CallMethod[name="__init__"](%image_list.1, %images.17, %image_sizes_list.1)

$ cat fasterrcnn.py
import torch
import torchvision

model = torchvision.models.detection.fasterrcnn_resnet50_fpn(pretrained=True)
model.eval()

script_model = torch.jit.script(model)
script_model._c.dump(code=True, attrs=False, params=False)

$ python3 fasterrcnn.py | grep -B 1 __init__
            %image_list.1 : __torch__.torchvision.models.detection.image_list.ImageList = prim::CreateObject()
            %156 : None = prim::CallMethod[name="__init__"](%image_list.1, %images.17, %image_sizes_list.1) # /opt/homebrew/lib/python3.9/site-packages/torchvision/models/detection/transform.py:116:21

Sure, I understand that ImageList might have troubles here. What I don't understand is why BoxCoder isn't a problem https://github.com/pytorch/vision/blob/3bfdb4275c13ec8207ae78222b7895c01a01371b/torchvision/models/detection/_utils.py#L128 and why the current implementation is able to run in C++ (and in mobile) without any issues. Do you have any insights on this?

The bug only affects deployment when the classes are used as outputs of the model. So like @fmassa  said, ImageList is only used internally and will not stop running the model in C++ or Python.

Or let's put it in that way, if I would like to write a custom TorchScript interpreter for my in-house silicon, what is your suggestion to execute missing ImageList class definition and its __init__ method?

You'd want to look at model.inline_graph instead, where the method call will be replaced by the actual IR of it.

Given the comments from @ppwwyyxx that this is only an issue for inputs / outputs of the model, do you think we need to merge this PR?