Expand connected temporary traffic signals in SwzDevice

Issue name: “Expand connected temporary traffic signals in SwzDevice”
Summary
Currently the SwzDevice feed allows for temporary traffic signals under the field device type of location marker.  The location marker device type is currently designed to only describe the location marker type/location but doesn't allow any additional attributes associated with the device.  In Iowa, there is a desire for an additional attribute on the mode of the connected temporary traffic signals that we would like to incorporate into the SwzDevice feed.  Providing the mode allows for a better understanding of the impacts the signal has on traffic as well as ensuring the device is operating as desired.
Proposed changes
Iowa was working on creating a protocol for connected temporary traffic signal and originally put together the following enumerations for the mode:

No communication available to the temporary signal set
Powered on, but not displaying
Using a timed cycle
Using a manual trigger
Using some other external trigger
Disabled due to an error

I feel there are multiple options for adding a mode for the temporary traffic signals but looking for feedback from others on the best implementation that aligns with the SwzDevice feed.  Below is a list of some potential options

Option 1: Simply add a mode in the MarkedLocations Object that is optional and only used when the MarkedLocationType is temporary-traffic-signal.  The problem with this approach is that the mode is not relevant to most of the marked locations.
Option 2: Create a new device type object for TrafficSignal similar to the Arrowboard Object and FlashingBeacon Object.  The TrafficSignal object would contain the core_details and mode. I would propose making this a required field as well.  This approach would allow additional attributes to be added specific to traffic signals if needed in the future.

As a manufacturer of TrafficSignal I agree with the proposal and I would suggest Option #2 above due to the various elements related to such piece of equipment.
I'm proposing some change to the Mode above:

Power On, but not displaying.    The Standard NEMA TS5 that applies for such equipment define Startup Flash as that operational state.  That could be the name
TS5 defines the Mode of Operation. which are: Pre-Timed, Semi-actuated (mix of timing and actuation), fully actuated and Manual.  That could replace the timed and trigger mode above.
TS5 also add the standby mode which could be red, red flash or yellow flash.
The last element is defined as the Fault Mode in TS5 and this one could be either a solid Red, flashing red or flashing yellow. I would think that could be valuable information as the car behavior is going to be affected depending on the mode and type.

On the same wave.    They are reporting location of flagging operation.  They cannot be actuated but could report the others elements (off, standby or startup, error). So this object  may be used for such devices as well.. or creating one for such equiment

@sknick-iastate I agree with Option 2, creating a new type of field device: a TrafficSignal (or TemporaryTrafficSignal, to be discussed) and remove the temporary-traffic-signal value from the MarkedLocationType enumerated type.
TrafficSignal Object
The TrafficSignal object describes a temporary traffic signal deployed on a roadway.

Name
Type
Description
Conformance
Notes

mode
TrafficSignalMode (see below)
The current operating mode of the traffic signal.
Optional

Optional allows representing a traffic signal when the mode is not known, which is consistent with what the current implementation (traffic signal as a MarkedLocation) allows.
TrafficSignalMode Enumerated Type
To be discussed

Do we want to put AFADs and portable signals in the same group?

Hello.  I'm the author of the related Iowa standard protocols for portable traffic signals and arrow boards, I've been asked to provide input on this.
I believe that Skylar's option 2 is the best choice.  It keeps the traffic signal devices in their own definition/domain without blurring the MarkedLocations Object by adding optional elements that only relate to one type of device.
@sergebeaudry has some good points about keeping an eye on maintaining compatibility with TS5 standards.
I will note that the "power on, but not displaying" is a status, not a description of a startup event.  So it should not be modified to blend with the TS5 "startup flash" status.

Regarding @rdsheckler question on AFAD.
We already have the value flagger in MarkedLocationType   with the description A human who is directing traffic_
An AFAD is an extension of a flagger. A human is still directing the traffic.  An AFAD can't be automated as per MUTCD.
The current way could work for a human with a traditional Flip stick, a GPs enabled stick or an AFAD.
Do we have others elements pertinent of having a separate objects?.    Aside reporting error I do not see.. An even error, if this occurs the Flagger will have to put a B-plan in place.. Traffic will not stop.

After discussing further with a smaller group, the consensus was that Option 2 for a new device object would be preferred.  The only attribute beyond the core_details recommended at this point was the mode.  Below is a list of the recommended modes (descriptions may need further details).

Blank - Not displaying
Timed/Pre-timed - Using a timed cycle
Manual Trigger - Using a manual trigger
Semi-actuated - using an external trigger only for the minor movements
Fully-actuated - using an external trigger for all movements
Flashing-red - The signal is in a flashing red state that could be part of startup or fault
Flashing-yellow - The signal is in a flashing yellow state that could be part of startup or fault
Unknown - The mode is not known

Right now the plan would be to make this a required field but would appreciate further discussion.
There were also additional discussions about Fault and whether that information should be in the mode but it was deemed this info should be located in the status_messages in the core_details

The list for TrafficSignalMode looks good to me; I've drafted enumerated type documentation based on it below (I used pre-timed and manual as this was the wording in the NEMA TS 5 standard document).
As for required or optional, it has been a consideration for past specification design choices that instead of adding "unknown" as an option that the property is optional. That is, in this case, if the mode is not known, then the property is not provided. If "Unknown" is an option or that is more explicit, I agree with the property being required. I would just advocate for being consistent across the spec with using optional properties vs an enumerated type value to represent unknown. Edit: FieldDeviceStatus includes unknown, so I think we are fine to have TrafficSignalMode include it as well.
TrafficSignalMode Enumerated Type
The TrafficSignalMode enumerated type describes the current operating mode of a TrafficSignal (see definition above).
Values

Value
Description

blank
The signal is not displaying anything.

pre-timed
The signal is using a timed cycle.

manual
The signal is using a manual trigger.

semi-actuated
The signal is using an external trigger only for the minor movements.

fully-actuated
The signal is using an external trigger for all movements.

flashing-red
The signal is in a flashing red state that could be part of startup or fault.

flashing-yellow
The signal is in a flashing yellow state that could be part of startup or fault.

unknown
The current operating mode is not known.

Used By

Property
Object

mode
TrafficSignal (see above)

Another decision to make: the name of the traffic signal object:

TrafficSignal; or
TemporaryTrafficSignal

I don't think I'm have the ideal knowledge set to make this choice. For what it's worth, the current enumerated type value in WZDx v4.0 for representing a traffic signal using the LocationMarker MarkedLocationType is named temporary-traffic-signal.

The simpler name TrafficSignal was chosen during SWZ Subgroup meeting discussion on 2022-04-25. The description will clarify it is for a temporary traffic signal deployed on a roadway.

Implemented in #313.


Upgrade aenum to remove warnings

Details can be seen here https://github.com/kayak/pypika/commit/aee4b0cbd05c29795b07360079527637efe48b55#commitcomment-31539024
This will involve upgrading aenum and ensuring the tests pass.

@tolmanam PR for the upgrade of aenum. Once merged I'll deploy a new version.


⚠ Cioos Atlantic CKAN has degraded performance

In ce92d29, Cioos Atlantic CKAN (https://catalogue.cioosatlantic.ca/) experienced degraded performance:

HTTP code: 503
Response time: 18228 ms

Resolved: Cioos Atlantic CKAN performance has improved in ff19156 after 5 minutes.


Add backup/restore functionality

Can be used for migrating OSBS instances.
Please test?

Oh mai, this is very impressive.

Fixed the typo, let me know when I should squash the commits.

Tested on a system with imagestreams, builds, and buildconfigs with triggers on the imagestreams.
Worked fine, everything restored with no superfluous builds.

Would it be nicer if it sent/received a tarfile over standard output? That way you could do things like:
osbs --instance=old backup-builder | osbs --instance=new restore-builder

It also avoids the cumbersome directory name (I tried using rsync on it and it got confused by the ':'s in the timestamp).

Thanks for testing. Addressed the inline comments, will look into the tar output later.

Rebased on top of master due to conflicts. PTAL
Changes: backup now creates a tarball so now you can do:
osbs -i old backup-builder -f - | osbs -i new restore-builder -

Default file name also no longer uses colons.

Works well!
Do we need to think about backing up resourcequota? I'm thinking not, because osbs doesn't create those itself except for the pause/resume one.
LGTM

Thanks! I wouldn't backup resourcequotas, I would only backup data created by OSBS (possibly indirectly). I'd consider the resourcequota created by ansible-osbs to be configuration and therefore out of scope.
Let me just at least some tests before merging.

Yes, agreed.

Added tests, fixed the string formatting.

LGTM


fix convert_calendar on static variables

[ ] Closes #7398
[ ] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

@aulemahal what do you think of the fix?

This makes complete sense to me, thanks!
I'm quite surprised I didn't get this issue before in my scripts, sorry about that!

Looks good. #7027 may be somewhat related.


Update elasticsearch chart to work with Kube 1.5

Add environment variable KUBERNETES_MASTER, resolves issue documented
here:
https://github.com/fabric8io/fabric8/issues/6229#issuecomment-247373967
Rename PetSet to StatefulSet, rename template file
Add initialDelay and increase timesouts to all liveness and readiness
checks. This was the only way I could get it to deploy reliably in my
environment.
Update to a newer image version

@mkrakowitzer looks great. Now that this chart no longer uses Kubernetes Alpha APIs, can you move it to stable/?

@seanknox done. Thanks.

One more thing needed for the stable repo is to have a NOTES.txt file that tells people how they can connect to the cluster. For an example, look at the Jenkins chart:
https://github.com/kubernetes/charts/blob/master/stable/jenkins/templates/NOTES.txt

@k8s-bot ok to test

Should the DataStorageClassVersion default in values.yaml be changed beta as well? Since this chart is being moved to stable?

@mkrakowitzer today I tested your branch and seems to be thatelasticsearch-client-deployment.yaml and elasticsearch-master-deployment.yaml readiness and liveness probes are broken.
You try to probe for 9200 but the master has only 9300 for example.
Other than that it seems to work for me on GCP with:
DataStorageClass: "standard"
DataStorageClassVersion: "beta"

@viglesiasce as @lostintangent recommended I think we should also change storage-class to default like at MySQL and PostgreSQL to improve portability: https://github.com/kubernetes/charts/blob/master/stable/postgresql/templates/pvc.yaml#L15
@maciaszczykm I'm happy to do these changes if you don't have time, just say a word.

@hekike Did you mean to @ me? I seem to be a little out of topic :-)

Sry, I missed it. cc @mkrakowitzer

I'd suggest to rather not move the chart to stable yet. As I mentioned at https://github.com/kubernetes/charts/pull/1062#discussion_r116161560, I'd rather align it to best practices first and then move it in a separate PR.

@unguiculus I agree that #1062 should be pushed through first. @mkrakowitzer want to close this out in the meantime? Perhaps you can migrate some of the other changes into #1062 or another PR.

I see that #1062 is based on this one so already includes those changes. What do we want to do here? Close this in favour of #1062 and work on 1.5 changes in incubator there, and then follow up in a future PR to move it to stable?

I can rebase #1062 back on master and reapply my changes to the incubator files.

@icereval that would be great, @mkrakowitzer I'll close this out in favour of #1062

Just an update for all watching, I was moving last week so did not get around to making the updates I promised. I plan on having time this week to make the changes, and unblock any further work.


Experiment.variant() method does not return payload on Android

I ran into some problem while integrating this library. When an experiment / flag is using a payload and I called Experiment.variant() method, it only returns the value and not the payload. This only happens on Android, on IOS, it's working correctly.
Any ideas why this is happening?
Example Log on Android:

Example Log on IOS:

Sorry for the delay: fixed in #8

@FerdyTarawan Thanks for reporting this.
The new version, 0.5.2, contains the fix.


15 04 2021 - Commodities Payout Terms Meeting Minutes

Date
Thursday, 15 04 2021 - 11am ET / 4pm GMT
Untracked attendees

Fullname, Affiliation, GitHub username

Meeting notices

FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact<EMAIL_ADDRESS>with any questions.

FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

[ ] Convene & roll call (5mins)
[ ] Display FINOS Antitrust Policy summary slide
[ ] Review Meeting Notices (see above)
[ ] Approve past meeting minutes
[ ] Pricing Dates/Rounding Discussion Continued.
[ ] AOB, Q&A & Adjourn (5mins)

Decisions Made

[ ] Decision 1
[ ] Decision 2
[ ] ...

Action Items

[ ] Action 1
[ ] Action 2
[ ] ...

WebEx info

Meeting link: https://finos.webex.com/finos/j.php?MTID=m67d73e1fc1592e699f3cf95d4627de8d
Meeting number:<PHONE_NUMBER>
Password: JMrsuEmY376
Call-in:

Join by video system: Dial<EMAIL_ADDRESS>You can also dial <IP_ADDRESS> and enter your meeting number.
Join by phone: +1-415-655-0003 US Toll | +44-20319-88141 UK Toll | Access code:<PHONE_NUMBER>

Rob Underwood, TTM Advisors, @brooklynrob

Hi

here

present

here

Untracked attendees

Nigel Cobb / Regnosys

minutes approved


KOP upgrade Problem

my current pulsar version is 2.9.2  kafka-protocal pulsar-protocol-handler-kafka-<IP_ADDRESS>.nar
So I plan to upgrade the pulsar cluster from bookeeper to broker  from version 2.9.2 to 2.9.3
When i upgrade broker  with  kafka-protocal   pulsar-protocol-handler-kafka-<IP_ADDRESS>.nar But It went wrong
Got error from broker:
2022-10-13T11:45:43,891+0800 [pulsar-io-4-93] ERROR io.streamnative.pulsar.handlers.kop.KafkaRequestHandler - Caught error in handler, closing channel
io.netty.handler.codec.TooLongFrameException: Adjusted frame length exceeds 104857600:<PHONE_NUMBER> - discarded
Got error from kafkaclient 2.0.0:
F1013 11:04:08.548171  153179 kafka_exporter.go:865] Error Init Kafka Client: kafka: client has run out of available brokers to talk to (Is your cluster reachable?)
so i change nar from  pulsar-protocol-handler-kafka-<IP_ADDRESS>.nar to  pulsar-protocol-handler-kafka-<IP_ADDRESS>.nar
it works well
So what's happend between <IP_ADDRESS>.nar  to <IP_ADDRESS>.nar

@hzluyang Do we have a full broker log here? Through the TooLongFrameException  cannot see the root cause.

Some Error logbelow
seems like  kafka_exporter cannot LIST_OFFSETS
2022-10-14T20:19:20,121+0800 [kop-event-thread] ERROR io.streamnative.pulsar.handlers.kop.KopEventManager - Error processing event null
2022-10-14T20:22:45,874+0800 [ForkJoinPool.commonPool-worker-36] ERROR org.apache.pulsar.broker.service.persistent.PersistentTopic - [persistent://public/default/__change_events] Failed to create subscription: reader-b5966d0bb4
2022-10-14T20:23:39,287+0800 [send-response-OrderedScheduler-1-0] ERROR io.streamnative.pulsar.handlers.kop.KafkaCommandDecoder - [[id: 0x59d22776, L:/<IP_ADDRESS>:9092 - R:/<IP_ADDRESS>:14336]] request RequestHeader(apiKey=LIST_OFFSETS, apiVersion=1, clientId=kafka_exporter, correlationId=23) is not completed for<PHONE_NUMBER>9 ns (> 30000 ms)
I find out if I upgrade protocals from  <IP_ADDRESS>.nar to  <IP_ADDRESS>.nar  kafka_exporter cannot get metrics
https://github.com/danielqsj/kafka_exporter

@hzluyang Do you have a full broker log here? Through the TooLongFrameException  cannot see the root cause.

However, some non-official Kafka clients might not work for kafka format. For example, old Golang Sarama client didn't assign relative offsets in compressed message sets before https://github.com/Shopify/sarama/pull/1002. In this case, the broker has to assign relative offsets and then do recompression. Since this behavior leads to some performance loss, KoP adds the mixed_kafka format to perform the conversion. The mixed_kafka format should be chosen when you have such an old Kafka client. Like kafka format, in this case, Pulsar consumers still cannot consume messages from Kafka producers.
maybe it can fix by set mixed_kafka  I will try

@hzluyang Do you have a full broker log here? Through the TooLongFrameException  cannot see the root cause.
@Demogorgon314
it turns out like <IP_ADDRESS> may cause kafka client  Metaupdate failed
Timed out wait for a node assignment call: fetchMetadata

@hzluyang Do you have a full broker log here? Through the TooLongFrameException  cannot see the root cause.

However, some non-official Kafka clients might not work for kafka format. For example, old Golang Sarama client didn't assign relative offsets in compressed message sets before Shopify/sarama#1002. In this case, the broker has to assign relative offsets and then do recompression. Since this behavior leads to some performance loss, KoP adds the mixed_kafka format to perform the conversion. The mixed_kafka format should be chosen when you have such an old Kafka client. Like kafka format, in this case, Pulsar consumers still cannot consume messages from Kafka producers.
maybe it can fix by set mixed_kafka I will try

hi @hzluyang , what's the result if you set mixed_kafka? Could you share your test result?
thanks.


fix sync_readme workflow

@electrum small typo sneak in which prevent running one of the workflows.
Pls merge :)

Will merging this create a new release automatically?


Fix reference to self.faces

Fix variable faces to be referenced as self.faces

Thanks!

Thanks to you!
The package is really nice and handy :D


Add undocumented measurement types, support for segmented values

Proposed Changes
Add models for Position (for segmented measurements) and add on to Measurement some of the undocumented types that are causing errors in Home Assistant component
Ignore the changes I had to make to get some of the tests through, I'm not a python dev.
Note
I am not typically a github user and I don't really code in Python but I do use this package and I have a Body Scan and I just wanted to add in measurement types that are showing up as errors in the Home Assistant component.  I don't care if you use the PR, but if you want to cherry pick out the values I added to the Measurement and add Position that are missing I just want the component to work without errors again.  I attached a sample API get_measurement response which includes the fields so you can see what they look like.
withings.json
I was going to also PR the home assistant component to add some new sensors around this and add support for position, which I did do, but I had enough trouble getting through the python linters and testing on this project with no experience, forget the ones on the HA project, it took me way too long just to add a few enum values so I will leave that as an exercise to an actual Python dev.
Related Issues

#157
#145
#138

Oh lol, I saw your fork but I didn't see this PR. This is quite nice since I am missing this info and was trying to get to know it via users.
I think I will cherry pick the info from the PR to implement (since you said you don't mind) since there are also some things that I might implement differently.
I am wondering, when you check your measurements, do you see all positions in every measurement? Or do you sometimes have a measurement with only the left side of the body (as example)?

Yes I am sure you would implement them differently as I don't really know what I'm doing in Python, lol, I just did not know how to submit the information without a PR to show it.  So go right ahead with that.
If I get segmented measurements, I always get all of them, but there are really only 10 I see in the app there are 5 segmented fat % (R/L arm, Torso, R/L leg) 5 segmented muscle mass (same group) -- I am not sure why you get fat in %, but it cannot be toggled like other fat ratio display.  I see some additional breakdown of segments and/or left/right in the API results, but they're not in the app, electro derma readings from the feet for instance seem to be measured per foot but I had no idea and honestly I don't even know what the measurement is to begin with.
I also notice a lot of non-segmented measurements in the API return a position = 7 which I have attributed to "Whole Body" or "Non Segmented" as I do not believe it was officially called out anywhere.  The 7 is likely the default value, although it was frustrating trying to figure out how to implement the model with the position property potentially optional, because there are measurements which lack it entirely.

I'll be looking into it this week, if we're lucky we might even finish it before Wednesday so we can do some changes in HA for 2024.2, otherwise it will be 2024.3

Not meant to be merged for information only

Haven't found the time yet as I am also busy trying to graduate :)

It's all good man, i work at DraftKings it's Superbowl weekend so i have
been living the vida loca myself
On Sat, Feb 10, 2024, 05:50 Joost Lekkerkerker @.***>
wrote:

Haven't found the time yet as I am also busy trying to graduate :)
—
Reply to this email directly, view it on GitHub
https://github.com/joostlek/python-withings/pull/165#issuecomment-1936970768,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5FPXGTWFBQ7WHRP4VVAUTYS5GF5AVCNFSM6AAAAABCOJXATGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWHE3TANZWHA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Document protected

Icon Request

Icon name: Document protected
Tags of this icon: file-protected, document-protected, document-secured
Use case:
Screenshots of similar icons:

We've updated our icons. Looking for document protected icons with the name of file-shield on our website  Document category.


[Request for External] report 493 "Carry Out Action Msg. - Req." - Protected variables

Hello, we need the following currently global variable/-s to be set as protected. Can you please check this? Thank you!
protected var
   PurchOrderHeader: Record "Purchase Header";
   ReqWkshTmpl: Record "Req. Wksh. Template";
   PrintOrders: Boolean;
   EndOrderDate: Date;

@JesperSchulz Can you please check this? Thank you!

It appears that this issue wasn't created in our internal system due to an issue with the automation, syncing GitHub issues and our internal systems. We will get that addressed as soon as possible and will then pick up this work. I apologize for the inconvenience!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 47754.


Added dismiss method to DismissibleState

This PR adds dismiss method to DismissibleState. I'm not sure if this is the ideal way to solve the issue but I'm up for suggestions.
@HansMuller @Hixie @Piinks
Fixes: #88705
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

Making the State public is something we'd like to avoid in general.
What's the use case here? The issue doesn't list a use case, it just says people might sometimes want to do it.

Making the State public is something we'd like to avoid in general.
What's the use case here? The issue doesn't list a use case, it just says people might sometimes want to do it.

Well, the idea behind this issue was derived from #88515. Let's say this feature of drag extent is added and the user wants to implement a UI similar to google meet where the dismissible consists of the participant item. Now let's say it has this partial drag extent implemented so that after partially dragging, the dismissible shows a "cross" button in the background to remove this particular item. This cannot be achieved currently as the only way to dismiss a dismissible is by user swipe.

Ah, I see. I would probably recommend implementing that as a new widget in a package, rather than overloading Dismissable with more features.

Ah, I see. I would probably recommend implementing that as a new widget in a package, rather than overloading Dismissable with more features.

Well if that's the case I would love to work on an implementation if you could guide me about what features this new widget is expected of and also about the overall skeletal of the widget. Maybe discussing this on discord would be more apt so that other's could also weigh in?

Totally happy to chat on Discord.


Getting warning: The 'file' type in input field is deprecated

Thanks a bunch for this package :)
I'm getting this warning:
The 'file' type in input field is deprecated. Use 'file' field instead.

when using this kind of field:
{
    type: "input",
    inputType: "file"
}

I can't find anything in the documentation about what to do instead of this, even though it says I shouldn't use type: "input" for type file. I've tried just type: "file" but then I get an error about an unregistered custom file type.
What is the recommended alternative?

You need to use the 'upload' field,
{
  type: 'upload',
  onChange: (model, schema, event, instance) { }
  ...
}

The upload field doesn't appear to be documented...

Thank you! Correct, this field is not documented.

Related to #400 - additional usage and sample code can be found here.
https://github.com/vue-generators/vue-form-generator/issues/400


Monthly installs section

Description
Closes #731
Depends on #729
Refactors the UI for the area chart to match the designs for the monthly installs section. This also partially fixes https://github.com/chanzuckerberg/napari-hub/issues/723 because this PR adds data normalization and filtering such that we only show data points after the published line.
Demos
https://napari-hub-monthly-installs.vercel.app/plugins/napari-svg?enable-feature=activityDashboard
>= 12 months

< 12 months

1 month

Next Steps

Implement https://github.com/chanzuckerberg/napari-hub/issues/732

Thanks for sharing this, it's looking so good to see it coming together!
There are just a few things to update that I saw from design perspective:

[ ] The aspect ratio fo the chart is a little too tall. This would make there be too tall of a gap between the bottom of the other metrics (like number of installs) and any future metrics we'd add to the dashboard, below this top row of installs-based metrics + chart. Is it possible to maintain the same width of the chart, but make itshorter? Here is the aspect ratio of the design in Figma, if we can have it this same height that'd be ideal!

Current implementation of chart:

[ ] When teh screen width is narrowed, the activity dashboard metrics + chart don't scale to fit the space as expected. I don't think I was very explicit about this in the designs, so I will mock up like I did for the Collections breakpoints. But basically the metrics + chart should switch between 1-, 2-, 3-columns of content in the exact same way and at the same breakpoints as the Collections design. Right now they are not widening to fill the space the same way. I will start mocking up these more thoroughly now and will let you know when ready (should be today).

[ ] Yeah good point about the y-axis when the data only has zeroes! I think in that case we could just have the y-axis scale from 0 to 1, and could still have ~4-5 tick mark labels for consistency (like 0.2, 0.4, 0.6, 0.8, 1.0) if that is possible?

UPDATE: @codemonkey800 Here are the breakpoint mockups for the Activity dashboard; I did the same breakpoints as for Collections, and mocked up what the screen should look like AT each breakpoint, and also right before (1px narrower) the breakpoint hits:
https://www.figma.com/file/d3t84J9Uzmj0GZnYROzdQX/Activity-Dashboard?node-id=1729%3A2340
(Scroll to the right or zoom out to see them all!)


Recommend lossless/lossy audio formats to ensure compatibility and a good experience

First-off I wanted to say this is amazing. I believe in open-source and the sfz format. I am planning to support it for my project: https://studiorack.github.io/studiorack-site/ However there are a few things we could improve.
Problem
When creating an .sfz file there are many possible audio file/formats to chose from, with varying licenses and cross-platform support. I can publish .sfz files along with wav, flac, ogg or even mp3 files. Users can download these but their platform/player has to be able to support them. If not the file does not load, or the playback is buggy/untested. This creates inconsistency and ultimately a poor user-experience.
For example, sfizz appears to support playback of wav, flac, mp3, ogg, aiff, but I had to dig into the source-code to find it out:
https://github.com/sfztools/sfizz/blob/acd866fd3d247d2fc659593cac96e88e801c29e2/external/st_audiofile/src/st_audiofile_libs.h
sforzando appears to support wav, ogg and flac. But as there is no list of formats, I have no way of knowing that my .sfz file will be supported without testing with every player...

As a SFZ author, I would like to be recommended which lossless/lossy audio formats will ensure a good player-experience and compatibility
As a SFZ user, I would like to download .sfz files from different authors, and not have to worry about whether my player is compatible, or playback is buggy.

Investigation
There seems to be two main use-cases:

Lossy version - Quick download to test them out, or for experimenting fun music
Lossless version - Producing professional music, exporting final versions of tracks.

It seems that every .sfz should be released in those two versions at a minimum, and the two formats used, should be supported by a majority of .sfz players
In the original Cakewalk documentation it states:
"Two kinds of sample files were selected to be included in the sfz format: a basic PCM uncompressed format (standard Windows wave files) and a basic, adjustable-quality, royalty free compressed format (ogg-vorbis encoded files). The inclusion of a compressed format allows sample developers and soundware creators to easily create preview or demonstration files in a small package so they can be transferred with minimum bandwidth, while retaining complete performance functionality."
https://sfzformat.com/legacy/
They intended two versions, using .wav and .ogg formats. Therefore all players should support these formats to comply with the original specification.
This was likely before the introduction of .flac as an improved lossless (but compressed) audio format
It appears this context has been lost in the new documentation, but would be very useful for .sfz authors.
Solution
Create a page called Samples containing context on the recommend file/format types (lossless vs lossy), and link to the homepage list here:
To make use of the SFZ format requires three things:
* Samples
* SFZ player
* SFZ file
https://sfzformat.com/
Add the audio formats each player supports to this page:
https://sfzformat.com/software/players/#players

Create a page called Samples containing context on the recommend file/format types (lossless vs lossy), and link to the homepage list here

Good idea.

Add the audio formats each player supports to this page

I don't know if that's possible and I guess also a maintenance problem.

I think we can add currently supported file formats for at least ARIA and sfizz, I don't expect it to require much maintenance. If we know what formats they currently support, I don't expect that to change often.


[BUG]

Describe the bug
Error running project in container
(base) kye@api:~/swarms-cloud$ docker run --gpus all -p 8000:8000 newcogvlm
/usr/local/lib/python3.10/dist-packages/pydantic/_internal/_fields.py:151: UserWarning: Field "model_id" has conflict with protected namespace "model_".

You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
  warnings.warn(
A new version of the following files was downloaded from https://huggingface.co/THUDM/cogvlm-chat-hf:
- configuration_cogvlm.py
. Make sure to double-check they do not contain any added malicious code. To avoid downloading new versions of the code file, you can pin a revision.
A new version of the following files was downloaded from https://huggingface.co/THUDM/cogvlm-chat-hf:
- visual.py
. Make sure to double-check they do not contain any added malicious code. To avoid downloading new versions of the code file, you can pin a revision.
A new version of the following files was downloaded from https://huggingface.co/THUDM/cogvlm-chat-hf:
- modeling_cogvlm.py
- visual.py
. Make sure to double-check they do not contain any added malicious code. To avoid downloading new versions of the code file, you can pin a revision.
========Use torch type as:torch.bfloat16 with device:cuda========

Downloading shards: 100%|██████████| 8/8 [05:07<00:00, 38.50s/it]
Loading checkpoint shards: 100%|██████████| 8/8 [00:05<00:00,  1.42it/s]
INFO:     Started server process [1]
INFO:     Waiting for application startup.
ERROR:    Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 734, in lifespan
    async with self.lifespan_context(app) as maybe_state:
  File "/usr/lib/python3.10/contextlib.py", line 199, in __aenter__
    return await anext(self.gen)
TypeError: 'coroutine' object is not an async iterator

/usr/local/lib/python3.10/dist-packages/uvicorn/lifespan/on.py:91: RuntimeWarning: coroutine 'lifespan' was never awaited
  return
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
ERROR:    Application startup failed. Exiting.

the whole message i even set all gpus```

Closing, this was a long time ago.


PyMongo sort syntax bug; if no direction is specified, key_or_list must be an instance of list

  File "/home/jasperb/Projects/niprov/niprov/views.py", line 12, in latest
    return {'images':repository.latest()}
  File "/home/jasperb/Projects/niprov/niprov/mongo.py", line 122, in latest
    records = self.db.provenance.find().sort({'added': -1}).limit(20)
  File "/home/jasperb/Projects/niprov/env/local/lib/python2.7/site-packages/pymongo/cursor.py", line 623, in sort
    keys = helpers._index_list(key_or_list, direction)
  File "/home/jasperb/Projects/niprov/env/local/lib/python2.7/site-packages/pymongo/helpers.py", line 55, in _index_list
    raise TypeError("if no direction is specified, "
TypeError: if no direction is specified, key_or_list must be an instance of list

pymongo==3.0.3

Fixed for this version. May need to set specific pymongo version in requirements?


[EMB-279] [Analysis] Demo version of daterangepicker

Purpose
Determine a viable solution for a daterange picker for the analytics page. I went with https://github.com/josemarluedke/ember-cli-daterangepicker .  If it were worthwhile, I would have made it into a component (osf-daterangepicker or similar), but I think you'll see from the diff that it's pretty functional out of the box, so I figured an example would work fine until we put the page together.

Summary of Changes

Add the addon
Adjust the styling a bit
Make some test variables to ensure we had easy control and access to the data

Side Effects / Testing Notes
There are the usual A11y problems with nested complex components. We might be able to do a PR to the ember addon to enable updating the template which might allow us to fix many/most of the problems, but form elements aren't labeled and we currently have no direct access to those, just like on the tags widget etc.
I've created a div with a custom id to enable us to locally namespace the daterangepicker dropdown-menu component. That will be problematic if we ever want to do multiple daterangepickers on one page, but I think there are other ways to deal with that if we needed to.
Ticket
https://openscience.atlassian.net/browse/EMB-279
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md Not a real PR

Coverage increased (+0.04%) to 56.585% when pulling 5b0d43313acd16f390579df60a0c6a7146bea405 on brianjgeiger:feature/daterange-picker into 5707a34bb0ec30878bdacdf6282a6142ba173c6a on CenterForOpenScience:develop.

LGTM, but closing since this is just a demo of out-of-the-box functionality.


HapiJs process.binding is not supported

Hi,
I use HapiJs on the server-side and I have this function:
 this.server.route({
            method: "POST",
            path: Routes.Login,
            handler: (request, reply) => {
               ...
            }
        })

If I add a validation to this function:
 this.server.route({
            method: "POST",
            path: Routes.Login,
                config: {
                   validate: {
                       payload: {
                           email: Joi.string().email().required(),
                           password: Joi.string().min(5).max(100).required(),
                       }
                   },
               },
            handler: (request, reply) => {
               ...
            }
        })

i get always this error-message:

process.binding is not supported
at Object.process.binding (browser.js?2c72b87:173)
at Object.eval (eval at evalScript (eval-script.js?c3c3587:22), :6779:25)
at Object.893 (eval at evalScript (eval-script.js?c3c3587:22), :6857:30)
at webpack_require (bootstrap 2796216…?8ce1719:693)
at fn (bootstrap 2796216…?8ce1719:110)
at Object.eval (eval at evalScript (eval-script.js?c3c3587:22), :3158:22)
at Object.601 (eval at evalScript (eval-script.js?c3c3587:22), :4753:30)
at webpack_require (bootstrap 2796216…?8ce1719:693)
at fn (bootstrap 2796216…?8ce1719:110)
at Object. (string.js?d42dd4f:5)

Is this a bug, or what am I doing wrong?
Thank you :smiley:

Little Update:
it works when I write the validation like this:
...
 config: {
                validate: {
                    payload: {
                        email: require('joi').string().email().required(),
                        password: require('joi').string().min(5).max(100).required()
                    }
                },
            },
...

when I import like this:
import * as joi from 'joi'
or
import joi from 'joi'
or
const joi = require('joi');
it doesn't works
very strange

Can't reproduce this.
Did you add joi as a dependency?
It works for me when I use const Joi = require('joi')
Validation:
config: {
      validate: {
        payload: {
          email: Joi.string().email().required()
        }
      }
    }

Using joi "^10.4.1"

Sorry for the late reply.
The solution


Fix so all motions call nohlsearch

This removes the highlighted characters that remain on screen after performing certain motions.

Would love to see this pulled in.


Buttons for change disk size are not displayed when create or resize disk - MS Edge, IE

Url: http://cs-ui-ci.z1.netpoint-dc.com:8080/bwsw/master/storage/create
User: develop
Browser: Edge (ver. 41.16299.15.0), IE (ver. 11.192.16299.0)
Steps:

Log in and go to Storage / VM sidebar.
Create new storage or edit old.
Select editable disk offering.

Actual result: Buttons of change disk size is not displayed;
Expected result: Buttons of change disk size is displayed; (Including ROOT disks)
Connected Feature ID: vm_disk_resize, storage_disk_resize, storage_disk_create
Screenshots:

@rennervo @chewlite @Nadya913 please note the following check-points in this issue:

The problem in the description is fixed
System checks max and min possible values and changes value entered if it is out of this range
If value is deleted - input becomes red which means that this field is required

It is needed to check all forms that contain this kind of inputs

http://cs-ui-ci.z1.netpoint-dc.com:8080/bwsw/pm-Egor-Genning/940-input-type-number

Update to @ershovaelena comment.

The original problem is not solved. IE does not know about numeric fields, so it does not show arrows. PO decided that this behavior is normal.
Here another problem was found, which is that these fields were not validated in the IE (see p.3).
After discussion with PO, it was decided to prevent user to the entry of the text values into the numeric input field and to limit the possibility of entering numbers beyond the boundaries, if this boundaries for this input field can be identified and set.
For numeric input field with boundaries:

input can't be empty, min value should be placed instead, exception - new untouched form (this means no error about the required field)
input doesn't allow you enter lesser value than a minimum or greater than a maximum

Point 3 from @ershovaelena comment not relevant anymore

/cc @rennervo @chewlite @Nadya913

Test on:
tamazlykar/940-input-number-validation

Tested on:
tamazlykar/940-input-number-validation


Prevent unhandled promise rejection when animations are cancelled

Fixes #101

This seems reasonable to me. thanks for the suggestion.


HARP-5432 Removing return statement

The return statement isn't used, hence removing to reduce confusion.
Signed-off-by: Jonathan Stichbury<EMAIL_ADDRESS>

@heremaps-bot retest please

@heremaps-bot test this please

@heremaps-bot retest this please

@heremaps-bot retest this please


Version2 development fix fx multi institute

should fix https://github.com/ESMValGroup/ESMValTool/issues/579

sounds good to me @schlunma :grin:

@schlunma hang on for a few, this is not 100% working -- I am fixing it as we speak

ok guys @schlunma @bouweandela finally fixed it, pain in the arse, but should work fully now

Hi V., sorry for bothering you again, but I ran three tests and none was successful:

Both institutes have fx files
Only one institute has fx files
No institute has fx file

The tool gets the correct template but fails with the error:
2018-08-22 14:52:10,865 UTC [34375] INFO    Using fx files for var tas of dataset HadGEM2-ES:
{'sftlf': ['~/models/INPE/HadGEM2-ES/historical/fx/atmos/fx/r0i0p0/v20120215/sftlf/sftlf_fx_HadGEM2-ES_historical_r0i0p0.nc']}
2018-08-22 14:52:11,727 UTC [34375] ERROR   Program terminated abnormally, see stack trace below for more information
Traceback (most recent call last):
  File "~/ESMValTool/esmvaltool/_main.py", line 215, in run
    conf = main(args)
  File "~/ESMValTool/esmvaltool/_main.py", line 143, in main
    process_recipe(recipe_file=recipe, config_user=cfg)
  File "~/ESMValTool/esmvaltool/_main.py", line 189, in process_recipe
    recipe = read_recipe_file(recipe_file, config_user)
  File "~/ESMValTool/esmvaltool/_recipe.py", line 55, in read_recipe_file
    raw_recipe, config_user, initialize_tasks, recipe_file=filename)
  File "~/ESMValTool/esmvaltool/_recipe.py", line 771, in __init__
    raw_recipe['diagnostics'], raw_recipe.get('datasets', []))
  File "~/ESMValTool/esmvaltool/_recipe.py", line 802, in _initialize_diagnostics
    raw_diagnostic.get('additional_datasets', []))
  File "~/ESMValTool/esmvaltool/_recipe.py", line 880, in _initialize_preprocessor_output
    self._initialize_variables(raw_variable, raw_datasets)
  File "~/ESMValTool/esmvaltool/_recipe.py", line 858, in _initialize_variables
    drs=self._cfg['drs'])
  File "~/ESMValTool/esmvaltool/_data_finder.py", line 444, in get_input_fx_filelist
    ][0]
IndexError: list index out of range

hey @schlunma sorry, I have updated the branch and now I am merging https://github.com/ESMValGroup/ESMValTool/pull/581 in and then you can test -- sorry, another 5min and it will be done :)

Ok, no problem :smile:  I will probably do the testing tomorrow!

good for testing now @schlunma (or tomorrow, whenever it's good for you) :)

@schlunma this should work no problemo now - I ran a thorough test with two vars:
      ta:
        preprocessor: pp_rad
        field: T2Ms
        fx_files: [sftlf, sftof]
2018-08-22 15:16:25,736 UTC [20293] INFO    Using fx files for var ta of dataset MPI-ESM-LR:
{'sftlf': '/badc/cmip5/data/cmip5/output1/MPI-M/MPI-ESM-LR/historical/fx/atmos/fx/r0i0p0/latest/sftlf/sftlf_fx_MPI-ESM-LR_historical_r0i0p0.nc', 'sftof': '/badc/cmip5/data/cmip5/output1/MPI-M/MPI-ESM-LR/historical/fx/ocean/fx/r0i0p0/latest/sftof/sftof_fx_MPI-ESM-LR_historical_r0i0p0.nc'}
2018-08-22 15:16:27,261 UTC [20293] INFO    Using fx files for var ta of dataset NorESM1-M:
{'sftlf': '/badc/cmip5/data/cmip5/output1/NCC/NorESM1-M/historical/fx/atmos/fx/r0i0p0/latest/sftlf/sftlf_fx_NorESM1-M_historical_r0i0p0.nc', 'sftof': '/badc/cmip5/data/cmip5/output1/NCC/NorESM1-M/historical/fx/ocean/fx/r0i0p0/latest/sftof/sftof_fx_NorESM1-M_historical_r0i0p0.nc'}
2018-08-22 15:16:27,684 UTC [20293] INFO    Using fx files for var ta of dataset HadGEM2-ES:
{'sftlf': '/badc/cmip5/data/cmip5/output1/MOHC/HadGEM2-ES/historical/fx/atmos/fx/r0i0p0/latest/sftlf/sftlf_fx_HadGEM2-ES_historical_r0i0p0.nc', 'sftof': '/badc/cmip5/data/cmip5/output1/MOHC/HadGEM2-ES/historical/fx/ocean/fx/r0i0p0/latest/sftof/sftof_fx_HadGEM2-ES_historical_r0i0p0.nc'}

      mrros:
        preprocessor: pp_rad
        field: T2Ms
        fx_files: [sftlf, sftof]
2018-08-22 15:35:04,858 UTC [1110] INFO    Using fx files for var mrros of dataset MPI-ESM-LR:
{'sftlf': '/badc/cmip5/data/cmip5/output1/MPI-M/MPI-ESM-LR/historical/fx/atmos/fx/r0i0p0/latest/sftlf/sftlf_fx_MPI-ESM-LR_historical_r0i0p0.nc', 'sftof': '/badc/cmip5/data/cmip5/output1/MPI-M/MPI-ESM-LR/historical/fx/ocean/fx/r0i0p0/latest/sftof/sftof_fx_MPI-ESM-LR_historical_r0i0p0.nc'}
2018-08-22 15:35:05,163 UTC [1110] INFO    Using fx files for var mrros of dataset NorESM1-M:
{'sftlf': '/badc/cmip5/data/cmip5/output1/NCC/NorESM1-M/historical/fx/atmos/fx/r0i0p0/latest/sftlf/sftlf_fx_NorESM1-M_historical_r0i0p0.nc', 'sftof': '/badc/cmip5/data/cmip5/output1/NCC/NorESM1-M/historical/fx/ocean/fx/r0i0p0/latest/sftof/sftof_fx_NorESM1-M_historical_r0i0p0.nc'}
2018-08-22 15:35:05,458 UTC [1110] INFO    Using fx files for var mrros of dataset HadGEM2-ES:
{'sftlf': '/badc/cmip5/data/cmip5/output1/MOHC/HadGEM2-ES/historical/fx/atmos/fx/r0i0p0/latest/sftlf/sftlf_fx_HadGEM2-ES_historical_r0i0p0.nc', 'sftof': '/badc/cmip5/data/cmip5/output1/MOHC/HadGEM2-ES/historical/fx/ocean/fx/r0i0p0/latest/sftof/sftof_fx_HadGEM2-ES_historical_r0i0p0.nc'}

phew, this was a bit more of a complication that I initially thought :grin: godspeed for your testing :ship:

Hey guys I am on my way to work atm and will fix all these once I get
there; Manuel, cheers for testing, man! Bouwe, I'll plug in the comments
but will also fonstruct a dict to map fx to mip as Manuel suggested
yesterday, where do you think would be best to place it? I reckon in
config-developer
On Thu, 23 Aug 2018, 09:27 Bouwe Andela<EMAIL_ADDRESS>wrote:

@bouweandela commented on this pull request.
In esmvaltool/_data_finder.py
https://github.com/ESMValGroup/ESMValTool/pull/580#discussion_r212222753
:

     else:

         dirname = dirname_template

   # Set the filename glob

   filename_glob = _get_fx_filename(variable, drs, j)

   # Find files

   fx_file_list = find_files(dirname, filename_glob)

   if fx_file_list:

       # Grab the first file only; fx vars should have a single file

       fx_files[variable['fx_files'][j]] = fx_file_list[0]

   dirnames.append(dirname)

for fx_idx in range(len(variable['fx_files'])):

This is unreadable, loop over the fx files directly:
for fx_file in variable['fx_files']:
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/580#pullrequestreview-148805482,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo4EhqLMxSC2d6zHnq_lE3MMkApD0ks5uTmdogaJpZM4WEIxY
.

yes, that would be a good place.

hey fellas @schlunma @bouweandela I have re-hauled the code and tested with a whole bunch of options and OBS files as well, it works fine for me - unfortunately there still is a warning about 6/5 nested statements but kill me if I can actually do anything about that, those checks really need to be there...

Closes #582 and #575.

Closes #582

Closes #575

Thanks @valeriupredoi, I will test this when I'm finished with some stuff on my other branch.

thank you, sir @schlunma :)

Thanks, it's looking better already. Can you get rid of the i and j indices everywhere, also in the replace_tags function?

@bouweandela ughh that's a tough call because I really don't want to change replace_tags (that function an old nightmare of mine :grin: )

It should be simple enough to change: just replace i with fx_file name and j with institute name. Much more readable.

@bouweandela - done :grin: question for you: are get_input_filename() and get_input_fx_filename() used anywhere? Can't seem to find their use...

The function get_input_filename() is used for creating dummy input files for testing diagnostics if you have no data, so it can probably be moved to the test file. The fx file equivalent is not used yet.

aha, since they are pretty old-looking compared to their counterparts that should match with

Just delete the fx_files one then.

get_input_filename is used by tests/system/data_simulator.py, so can also be moved there. I'm not sure if those tests still work, because they are too time consuming to run on circleci, they may have to be fixed.

Sorry V., I will test your stuff first thing tomorrow, I'm still not done on my branch :disappointed:

Dont worry, man, take your time, good luck with your stuff :)
On Thu, 23 Aug 2018, 17:50 Manuel Schlund<EMAIL_ADDRESS>wrote:

Sorry V., I will test your stuff first thing tomorrow, I'm still not done
on my branch 😞
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/580#issuecomment-415488458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCo_r6Jk8jSMUa0Ehshv6TtZUo8lm9ks5uTt1YgaJpZM4WEIxY
.

I ran quite a lot tests including the recipes which already use fx_files, all of them were fine :tada:.

Sweet, cheers for testing, man! :beer:
On Fri, 24 Aug 2018, 09:52 Manuel Schlund<EMAIL_ADDRESS>wrote:

I ran quite a lot tests including the recipes which already use fx_files,
all of them were fine 🎉.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ESMValGroup/ESMValTool/pull/580#issuecomment-415696506,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbpCoxVs3usj0_wJseo45Fv6YROlRyg9ks5uT76_gaJpZM4WEIxY
.

gents, sterling efforts all round - shall we merge this PR then? :beers:

Fine for me, since this PR doesn't include new features it should be fine for @mattiarighi as well :smile: I'm running the last tests now.

@schlunma go ahead and mergy-merge when you all caught up, man, I will drink a beer for you guys (and @mattiarighi altho am sure he's baking his arse on some beach at the moment, beer in hand) at pub o'clock later on today :grin:

Tests were successful, your opinion @bouweandela?

_data_finder.py is still not very readable, but at least this PR doesn't make it worse, so fine with me to merge.

Running one last test to see if #586 is closed with this one.

wohoo, what a chain of closures, cheers, guys, good weekend!

Cheers, have a nice weekend, too! 😄


Add test cases for AuthPathMapper and fix bugs for auth-path-sqlmap.xml.

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #548 (37b0506) into master (5c035c1) will increase coverage by 4.35%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c035c1...37b0506. Read the comment docs.


CMake Error at build/_deps/inferenceengines-src/CMakeLists.txt:22 (list):   list sub-command FIND requires three arguments.

CMake Error at build/_deps/inferenceengines-src/CMakeLists.txt:22 (list):
list sub-command FIND requires three arguments.

Fix CmakeLists.txt line22
list(FIND SUPPORTED_BACKENDS ${DEFAULT_BACKEND} SUPPORTED_BACKEND_INDEX )
to
list(FIND SUPPORTED_BACKENDS ${DEFAULT_BACKEND} SUPPORTED_BACKEND_INDEX -1) in fetch dependcy
when you compile project found this problem.

Hi,
Thanks for the report. It seems there's a bug in the propagation of the DEFAULT_BACKEND argument from the root project to the subproject. I will try to fix it as soon as I can.
In the meantime, as a workaround, you can hardcode the backend you need in the following file:
build/_deps/inferenceengines-src/CMakeLists.txt
At line 16, replace the line:
set(DEFAULT_BACKEND ${DEFAULT_BACKEND})

with:
set(DEFAULT_BACKEND "<YOUR_BACKEND>")

Replace <YOUR_BACKEND> with one of the supported backends, such as:

"ONNX_RUNTIME"
"LIBTORCH"
"LIBTENSORFLOW"
"OPENCV_DNN"
"TENSORRT"
"OPENVINO"

Let me know if you need further assistance!


Create add2Numbers.R

This pull request do not contains files in specific folders. Please fix it and reopen


Handouts for examples' cmake

Required Info

Camera Model
SR300

Firmware Version

Operating System & Version
Ubuntu 16.04

Kernel Version (Linux Only)
4.10.0-37-generic

Hi
I am a new user of Ubuntu and just start a new project with SR300. Previously I have some experience on Matlab so I can read and understand the code.
Would you pls give a detail description of how to use cmake to compile the examples code?
For instance, I am trying to work with the example of capture
I have tried
mkdir build && cd build
cmake ../
make
Then, I don't know how to continue, How can I get the executable?
Best Regards
Joe

Hi @wwangzhao , Please try to follow the Linux Installation guide

You are in the right direction, please try:
mkdir build && cd build
cmake .. -DBUILD_EXAMPLES=true
make
sudo make install
rs-capture

Let us know if this helps

Hi, @zivsha  and @dorodnic
Thx for your reply. It seems that I haven't make it clear.
For the linux installation guide, I have finished the installation and the examples works well, e.g. the rs-capture, rs-align, etc.
However, I wish to start my own project. Hence I try to compile the code in the example, e.g.  in the example of align, I tried
mkdir build && cd build
cmake ../ -DBUILD_GRAPHICAL_EXAMPLES=true
make
Then it shows
Scanning dependencies of target rs-align
[ 20%] Building CXX object CMakeFiles/rs-align.dir/rs-align.cpp.o
[ 40%] Building CXX object CMakeFiles/rs-align.dir/home/james/librealsense/third-party/imgui/imgui.cpp.o
[ 60%] Building CXX object CMakeFiles/rs-align.dir/home/james/librealsense/third-party/imgui/imgui_draw.cpp.o
[ 80%] Building CXX object CMakeFiles/rs-align.dir/home/james/librealsense/third-party/imgui/imgui_impl_glfw.cpp.o
[100%] Linking CXX executable rs-align
CMakeFiles/rs-align.dir/rs-align.cpp.o: In function rs2::error::error(rs2_error*)': rs-align.cpp:(.text._ZN3rs25errorC2EP9rs2_error[_ZN3rs25errorC5EP9rs2_error]+0x2a): undefined reference to rs2_get_error_message'
There are a lot of messages about undefined reference to `rs2_get_error_message', it seems that the rs.h is not included? I find that the forlder librealsense2 is under /usr/local/include
What should I do then ?
Best Regards

Hi @wwangzhao,
I've created a simple "getting started" example on my fork which you can take and build as a stand alone project: zivsha/getting-started.
It is not the best way to create a cmake project but it is something to help you get started.
Note that you must install the library prior to building this project. Also this will probably not work on windows unless you add the path to the realsense.dll to your environment variable.
We will consider adding such a template project to the SDK itself, with a more robust cmake, and detailed readme in the near future.

Hi @zivsha
Thanks a lot for your reply. I have tried the rs-getting-started. The CMake and Make goes well but it reports error for ./rs-getting-started:
RealSense error calling rs2_get_frame_width(frame_ref:nullptr):
null pointer passed for argument "frame_ref"
I noticed that the light (both green and red) turns on once, and I also tried the executable example of rs-capture, which shows that the camera works well.
Anyway, when I use ldd rs-getting-started, it shows the library links well:
$ ldd rs-getting-started
linux-vdso.so.1 =>  (0x00007fffe3b99000)
librealsense2.so.2 => /usr/local/lib/librealsense2.so.2 (0x00007ff6cc36d000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007ff6cbfa0000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007ff6cbd88000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ff6cb9be000)
libusb-1.0.so.0 => /lib/x86_64-linux-gnu/libusb-1.0.so.0 (0x00007ff6cb7a6000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007ff6cb49c000)
libgomp.so.1 => /usr/lib/x86_64-linux-gnu/libgomp.so.1 (0x00007ff6cb26c000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ff6cb04f000)
/lib64/ld-linux-x86-64.so.2 (0x000055db84ca8000)
libudev.so.1 => /lib/x86_64-linux-gnu/libudev.so.1 (0x00007ff6cb02e000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007ff6cae2a000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007ff6cac22000)

Hi @wwangzhao ,
This is caused because the frames.get_depth_frame(); returned an empty frame.
This should not happen currently (in development) but it is not yet merged to master.


Objects cluster membership reassignment broken via Sunstone

Description
It's not possible to properly change the cluster assignment of some objects. The object XML is just partially updated, the main reference leaves untouched. Object leaves assigned to the original cluster(s). Applies at least for datastores and vnets.
Steps To Reproduce
Have a vnet:
$ onevnet show 2 --xml
  <CLUSTERS>
    <ID>0</ID>
  </CLUSTERS>
...
  <TEMPLATE>
    <CLUSTER><![CDATA[0]]></CLUSTER>

Now I select different cluster:

But in the Sunstone object list, the original cluster is still shown:

and, the object XML is only half-updated:
$ onevnet show 2 --xml
  <CLUSTERS>
    <ID>0</ID>
  </CLUSTERS>
...
  <TEMPLATE>
    <CLUSTER><![CDATA[100]]></CLUSTER>

Details

Affected Component: Sunstone
Version: 5.8.0

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

Problem was not in reloading tables, but incomplete XML object update.
But, I can't reproduce it anymore as well. Now I don't see any TEMPLATE/CLUSTER in the objects. So, maybe it was a bug in oned which was fixed in the meanwhile.
Probably we can close this issue.


updated fileserver directory name

Please check below, if the PR fulfills these requirements:

[X] Commit(s) and code follow the repositories guidelines.
[X] Test(s) have been added or updated to support these change(s).
[X] Doc(s) have been added or updated to support these change(s).

Associated Links:

N/A

Types of Changes:

Feature

Proposed Changes:

Updated the directory for the fileserver to be fileserver to match the registry directory of registry

Verification/Testing of Changes:

Add artifacts to your store, then run hauler store serve fileserver and you will see the new directory name.

Additional Context:

N/A

Would rather see this sidelined in favor of a unified hauler store serve

Is the implementation of hauler store serve near term? I would think it may take a bit to implement.
I don't think any workflows would rely on the directory name of the fileserver, so this wouldn't be a breaking change and would be provide more simplified naming conventions/structure to hauler.

@dweomer very understandable. I wasn't sure how long it would take for the unified hauler store serve to be implemented, so this would be for the interim so the registry and fileserver would have the same look and feel and workflow.
I don't think any user functionality depends on the directory name, so thought it would be safe to update


Allow logging in existing user in promotion flow

User may select an existing identity in promotion flow. Currently, it would fail with an identity exists error. Use case instead requires user to perform authentication and log in using the existing identity. The anonymous user is discarded in this case.

[ ] Configuration flag (TBC): on_identity_conflict.promotion

error
login

[ ] Hook events (TBC): before_user_promote, after_user_promote

anonymous_user
user
usually anonymous_user and user have same ID
when on_identity_conflict.promotion is login, anonymous_user and user may have different ID.

ref #1469

I have question regarding the SDK. After the promotion, the user is authenticated as a normal user. When the user logs out and authenticateAnonymously again, is the anonymous user a brand new one?

Yes, after finishing the promotion flow, the key ID is deleted and a new key is generated.

ah, it makes a lot of sense.
Will we have a default login with on_identity_conflict.promotion parameters?
I think in our doc or config comment, we need to remind users that we won't MERGE the anonymous user for them, the application need to handles the merging behavior if they want to after login.

If the default is login, we assume the application has specific logic to merge the two users. I think error is a better default value because it does not introduce potential data integrity problem to the application. When the developer encounters the error, the developer consults the documentation and realize their application needs to handle such case. login being the default may be surprising to developers who are not aware of this situation.
Also we should turn off anonymous user by default as not every application needs it.

@louischan-oursky the dilemma here is, is there any users who would prefer to have an error instead of able to login directly, if he "upgrade" the anonymous users to an existing logged in users? .....

Login directly as existing user would 'lose' the anonymous user, along with its associated data. If developer forgot to configure it and deployed to production, it can cause destructive data damage. Therefore, error is a safer default.

@kiootic I understand what @louischan-oursky said, actually I've already spell out we should add a warning in the documentation about "merging users" before all these already.
I'm just pointing out no normal people would expect, say after clicking "Continue as guest", if you choose "Login", it said "Users existed" when he tried to login an existing user account. This would definitely looks like a bug to most people.

One idea...
If I'm right that no normal users would expect the error flag, what about we make it easy to customize the error message?
And in the default error message, we can make it clear that it is not configured -- the developer should read the configuration options of on_identity_conflict.promotion
Other idea are welcomed.

Re-open issue to consider if there is better way to solve the problem

From the end user's perspective, just like what Ben said, the user normally does not expect the error case. Auth Gear ideally should behave in the following ways

If the identity the End-User provides does not exist, then just promote the anonymous user.
Otherwise, Auth Gear explicitly shows a page to tell the End-user that the identity exists and ask if the End-User wants to just login or merge the two users.

From the developer's perspective, they are very likely unaware of the merge case. So the default configuration should not cause destructive data damage. The main problem becomes how to make the developer aware of it. If the default is error and the developer does test their application before going live on production, the end user should have good UX.
Actually I want to merge the signup, login and promotion page into one. The End-User has fewer things to choose. Instead the UI tells the End-User what is happening and guide them to finish the flow. So I prefer Idea 1.

Discussed with @louischan-oursky @kiootic off line, agreed Idea 1 is better, maybe we can use an explicit error message like "You can't continue as guest by loggin in an existing user account".


string interpolation does not preserve class name ordering in template

When using string interpolation in a template for class, the evaluated expression does not preserve the order of classes in some cases.
//gives wrong ordering of classes

//also tried this with no luck

//gives correct ordering of classes

if !data.length, the result is:
//order of class names are not preserved

Some style rules may depend on this order.
gist created:
https://gist.run/?id=fc23d1922cd6ea27e91ad804f2ade548

https://github.com/aurelia/framework/issues/211

Closing as fixed dupe.

I'm still having this problem and I don't think it is the same problem as aurelia/framework#211. When using the code from @tantommy I get the correct order the first time (twelve wide column) but when I change data.length and Aurelia rebinds the classes it keeps "wide column", removes "twelve" and adds "sixteen" resulting in the order (wide column sixteen).
Did you solve the problem @tantommy?

@mikeesouth please setup a reproduction and we'll take a look: https://gist.run/?id=7542e061bc940cde506b

@jdanyow the gist from @tantommy still works: https://gist.run/?id=fc23d1922cd6ea27e91ad804f2ade548
When you click the "click me" texts the items.length changes and thus triggers some databindings. When looking at div A, this databinding is used:
"${items.length ? 'twelve wide column' : 'sixteen wide column'}"
The expected result is sixteen wide column but the result is wide column sixteen.

ah- because it's you're really only adding one class.  The logic isn't that smart. Either do this:

or this:

that latter is the most performant

@jdanyow ah, the first one doesn't work. It yields the same result as the first. However, the second approach (class-name) does indeed work. Thanks! Where can I find more documentation on this "-name" syntax?

The DOM is case insensitive, when it parses your markup, everything ends up being lowercase.  This makes it hard to bind to element properties like className.  Aurelia's solution is to use a convention where hyphenated names in your template are converted to camelCase.
So class-name="${...}" or class-name.bind="..." is going to assign the DOM element's className property.
By assigning the property directly, you're skipping all the logic we have around making sure we don't stomp on existing classes, etc. Binding className in this way will wipe out whatever is in the element's class list and replace it with the result of your binding which is the expected result in 99% of the use cases.

Great explanation. Thanks!


Improvement: DO-2012 improve custom action impl handling

Motivation and Context

This PR brings small improvements to advanced use cases of the action API:

Added an execute_action method. This can be passed an arbitrary ActionImpl instance. The two main use cases are:

composing external APIs - if an external function provides an ActionImpl, users can use this API to invoke it within their custom action

def external_api(*args) -> ActionImpl:
  # something
  return NavigateTo('/some-url')

# user action
@action
async def my_action(ctx: actionCtx):
  # some custom logic
  await ctx.execute_action(external_api(*args))

invoking custom impls

Improved useAction hook to invoke an optional onUnhandledAction callback for each impl encountered without a registered implementation. This combined with the API above allows users to pass arbitrary instructions down to custom components and handle them.

Implementation Description

In the initial implementation onUnhandledAction was invoked once when an unknown action impl was encountered; this meant that potentially a stream of more instructions would stop and no longer be handled.
This has been moved deeper so each individual impl now falls back to using the onUnhandledAction callback if there is no registered implementation.
Any new dependencies Introduced

How Has This Been Tested?

Added Python and JS test cases
PR Checklist:

[x] I have implemented all requirements? (see JIRA, project documentation).
[x] I am not affecting someone else's work, If I am, they are included as a reviewer.
[x] I have added relevant tests (unit, integration or regression).
[x] I have added comments to all the bits that are hard to follow.
[x] I have added/updated Documentation.
[x] I have updated the appropriate changelog with a line for my changes.

Screenshots (if appropriate):

Could we add a small section in the actions page letting users know this exists as well? :)


Added parser for .NET Core build files and date-agnostic parsing

New Functionality

Added a new parser specifically designed to handle .NET Core build files
Implemented date-agnostic parsing logic to handle logs that do not contain explicit timestamps. This allows the parser to function correctly with build logs from various sources, including those that lack standard date formatting.

Fixes

Resolved an issue where the parser would fail when encountering build logs without dates, making it more robust and versatile for different use cases

Related Issues

None at this time.

Sorry for the delay. This looks great!


Can't get the PyLoxone config screen.

I can't get this screen:

should i just add the Configuration over yaml (deprecated) code?

Then the installation failed. Try to reinstall it.  How did you install it?

Then the installation failed. Try to reinstall it. How did you install it?

I installed it with HACS and have tried to reinstall it multiple times, also tried a fresh HA install still didn't work.

Fixed it!


chore: publish docker image on release

Not tested yet, waiting on a docker hub user.

having trouble figuring out which python version is used

having trouble figuring out which python version is used

Hmm you're right, it's kind of arbitrary https://github.com/deepgenomics/GenomeKit/pull/112/files#diff-4aee7e10b78db377004a7ac425c4ed6e265bbdfbb6fdf64141ade09102fa75c6R61
I'll fix it so it's explicitly py3.10


Support auto-prefixing of CSS in inline styles in HTML templates

Currently, HTML templates that contain  do not run styles through the CSS parser/generator. We should make it so. A temporary fix for existing code is checked in at 25decb0a26c8d533b81e80c2ed386f15025fedad.

I believe the CSS parser has since fixed this. @mdittmer to close if that's true.

Not true. What's meant by "styles" is inline <foo style="bar:baz">. The CSS parser is not wired up to DOM elements to manage prefixing in this case.


Luna Data

Hi,julian
can i just change step3 to predict luna date,and make a submission for luna16

I think not..
First of all the model is trained on full luna dataset.
I believe LUNA expects 10 fold CV.
Also I think there are big differences in the submission format etc.

Hi Julian,
I've done 10 fold CV and did the multiplication (by patient_img shape) to get back the original co-ordinates. But, I see even now the co-ordinates are not matching even slightly. What can be the reason ? Can you please help ?


Add args support for OPEN_MENU action

Hello, it's my first pull request for a project and I currently learning Java. I am open to any comments to help me!
This pull request is related to my issue: #30
Théo

I hadn't done any testing, I just fixed the build errors as well as tested ingame.


Laravel 5.3: Call to a member function supportsSchemaTransactions() on null

Hi there,
I've just upgraded to Laravel 5.3 and also upgraded laravel-mongodb to 3.1.1.
Now when I'm trying to migrate the following error occurred:
PHP Fatal error:  Call to a member function supportsSchemaTransactions() on null in /private/var/www/laravel/vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php on line 378

I've set protected $connection = 'mongodb'; in my migration class.
BTW: up() method never fired, the error occurred before it I think.

I've just open commented on Laravel issue [https://github.com/laravel/framework/issues/15892#issuecomment-255517921]
They said the similar problem was fixed before but work in my case!
laravel version: 5.3.19
jenssegers/laravel-mongodb version: 3.1.1

+1. Rolled back to Laravel v5.3.18, which works.

@ellej16 make a comment on that Laravel issue:

As far as I checked jensessegers/laravel-mongodb's source code, it's missing a few key methods/attributes introduced by this particular PR: #15780 . If I remember correctly, one of those are: getSchemaGrammar() and useDefaultSchemaGrammar() on Connection.php (With this being the culprit behind your troubles).

Is there any chance to fix it here?

@ahmadazimi Below is the fix to your issue:
Go to Connection.php which can be found in the Mongodb folder of this package and add these changes:

Add use Jenssegers\Mongodb\Schema\Grammar; right below the use MongoDB\Client;.

Inside the public function __construct(array $config) function, add $this->schemaGrammar = new Grammar();. It can come before any other code in the function.

Now head over to the Schema folder and create a new file called Grammar.php. The file should contain this:
<?php
namespace Jenssegers\Mongodb\Schema;

use Illuminate\Database\Schema\Grammars\Grammar as BaseGrammar;
/**
 * Class Grammar
 *
 * @package Moloquent\Schema
 */
class Grammar extends BaseGrammar
{
}

I found this fix in the moloquent fork of this package (https://github.com/moloquent/moloquent). Hope this helps you.

Thank you @kofispaceman
I think I should switch to https://github.com/moloquent/moloquent ;-)

Was this fixed in the last Laravel release, or still an issue?

@jenssegers using Laravel v5.3.21 and jenssegers/mongodb v3.1.1
and still this is an issue!

Can you try the master branch?

@jessengers Looks like it has been fixed in the master branch. Thanks!

@jenssegers Looks like it has been fixed in the master branch.
Thanks.

@jenssegers when we can have it in stable channel?

Will do this now


Program Days Menu - Not Collapsing Properly on Small Screens

Hi all,
In the program section, the list of days for programs lasting more than 4 days works well on medium and large screens. However, on small screens, the list does not collapse into two or more rows. Instead, it collapses into a single row that extends beyond the screen size.
print screens attached to this issue report.

You can see a live example here (please note that it may change in the coming days):
https://cibit-uc.github.io/summerschool/programa/
thank you.
best regards,
Ricardo Martins

Hi Ricardo. I was aware of this problem and planned to fix it later this year as part of a broader restyling of the theme. But to solve it right now, I quickly pushed an update that introduces a new layout for the program page. In this new layout, the issue will not occur.
Please load the latest version of the gem, v2.2.0. Then rebuild the side, check the program page and see if all works well.

thank you :)


Interface aliases should be possible

Maybe through custom struct in StaticInterfaces? But could make interfaces slower as is

@wouterwln
y[i] ~ MvNormal(mean = m, covariance = C)
y[i] ~ MvNormal(μ = m, Σ = C)

both correspond to MvNormalMeanCovariance, but the first one fails when looking for a missing interface.


need help

Can somone help me with the 2 Factor Auth ?! I try to create it, but it always failed on me.
Would be nice if someone help me with TeamViewer. !

Create an App password! https://support.google.com/accounts/answer/185833


User-Dashboard: Messages

Develop the pages of the User-Dashboard message UI appropriately
The user dashboard message contains 2 pages ( you should send a pull request for each of the pages)
Ensure they are responsive and follow the responsive design on the Figma
Implement images properly
Follow the colour guide and the appropriate colours

Hi, i will like to take on this task please

Hi, i will like to take on this task please

hi please assign me to this issue. I will like to work on it

@ingressive4good
I'd like to take this

@Sandee004 What's in the progress status on this?

I actually requested for this first

@dabsclement can i still get assigned?

@d-a-ve

@omotayomialake wait till the end of the day, if @Sandee004 doesn't comment then you can assign the task to yourself

@ingressive4good it seem i haven’t been added to this repository, i can’t seem to assign myself to it, that was why i commented instead

Invite sent

I didn't get an invite too that's why I didn't assign myself

@omotayomialake sorry, my bad. I thought you were the person that removed the first assignment I didn't take a good look at the username.
Like @dabsclement said, if @Sandee004 hasn't replied by day's end you can assign yourself.
I will do my best to remove his assignment if he hasn't replied.

@Sandee004 just tag @ingressive4good to send you an invite.

@ingressive4good I didn't get an invite 🤲

I think this issue has a PR already, why is it not closed.

this is done


Refactors Reconciler() Method for Kubernetes Provider

Refactors Kubernetes controller:

Improves readability.
Improves log messages.
Updates the reconciler to continue processing a request even if dependent resources cannot be found.

Fixes #788
Signed-off-by: danehans<EMAIL_ADDRESS>

cc: @chauhanshubham

Codecov Report

Merging #803 (84e720d) into main (fbc55a3) will increase coverage by 0.71%.
The diff coverage is 69.67%.

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   61.06%   61.77%   +0.71%
==========================================
  Files          46       46
  Lines        5674     6023     +349
==========================================
+ Hits         3465     3721     +256
- Misses       1980     2068      +88
- Partials      229      234       +5

Impacted Files
Coverage Δ

internal/cmd/server.go
7.82% <0.00%> (-0.07%)
:arrow_down:

internal/gatewayapi/runner/runner.go
31.32% <0.00%> (-1.59%)
:arrow_down:

internal/gatewayapi/zz_generated.deepcopy.go
0.00% <0.00%> (ø)

internal/ir/infra.go
67.41% <ø> (ø)

internal/ir/xds.go
76.82% <ø> (ø)

internal/message/types.go
0.00% <ø> (ø)

internal/provider/kubernetes/routes.go
57.74% <0.00%> (ø)

internal/provider/kubernetes/controller.go
50.09% <20.23%> (-0.01%)
:arrow_down:

internal/gatewayapi/helpers_v1alpha2.go
27.77% <33.33%> (+7.14%)
:arrow_up:

internal/gatewayapi/contexts.go
75.94% <72.15%> (-1.22%)
:arrow_down:

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This PR is required to enable the HTTPRouteReferenceGrant conformance test.

Superseded by https://github.com/envoyproxy/gateway/pull/793


fix(packages): change to valid patternplate version

@marionebl could you change the commit message? Not everyone knows what 'pp' means and there are still enough characters left to write the whole name ;)

@Jumace I assume you'll squash the commits in here when merging anyway, so please reword the commit message then. :)

@marionebl currently it is just your commit but i can change this later :)


SEQ Keys

There are seq keys in the source code and on the commit history. Is this secure?

@agaldino The Git history should be rewriten to remove these keys as they can still be seen on github. They should also be invalidated on the server.

I don't think you need to rewrite the commit history as long as you invalidate the key on the server.

@mccraveiro @greenboxal At the time I close this issue, I've also invalidated the key on the server.

Nice! 👏


[WIP] Change status logic on "Your Submissions" page

When you log a new Submission and immediately visit the Your Submissions page, the status of the new ticket is "Not Started". This is confusing. The logic being this status needs to be revisited.
This ticket is a placeholder and will be updated with the new logic when agreed on

Duplicate of #568


[Accordion Menu] Animation loop

How can we reproduce this bug?

Just take an accordion menu
Double click on a link
And the open/close animation loop

What did you expect to happen?
Just a open/close animation
What happened instead?
The menu keeps opening / closing.
Test case
http://codepen.io/anon/pen/gPOjYz
or just the one in the docs (http://foundation.zurb.com/sites/docs/accordion-menu.html#)

the commit seem to fix the problem problem partially. Specific toggle tempo can still be achieved to keep animation loop going and it also delays the animation start a bit.
Setting the time-out time to 300 seems to prevent it completely but the delay seem to long.

seems like just checking for animation state on toggle trigger eliminates the repeating loop :D


Issue #152: Only add regularization constant to diagonal

The regularization constant was already used properly in the initialization I wrote earlier.

Thanks!
Though there is still a bug here, the compute_cov output is added within a nested loop. We should only add the regularization at the end of that nested loop.

Whoops. Long night...


Change onVariablePanelShowDataViewerRequest to directly call debugger for pandas version

Per convo with the python team.
Instead of trying in infer from the configuration we should just run our pandas version checking snipped directly on the activeDebugSession and check the results there. Should be safer.

this likely won't be applicable with https://github.com/microsoft/vscode/issues/165445


[5.5][Concurrency] Add an exported symbol on Darwin that contains the frame pointer flag bit for async frames.

Cherry-pick https://github.com/apple/swift/pull/38290 to 5.5.
The symbol is swift_async_extendedFramePointerFlags.
This bit is mixed in to the frame pointer address stored on the stack to signal that a frame is an async frame. The compiler can emit code that ORs in the address of this symbol to apply the appropriate flag when it doesn't know the flag statically.
rdar://80277146

@swift-ci please test


Add "using with a virtual environment" notes to readme

Anyone checking out the pfpAPI should get precisely the dependencies and versions necessary so a virtual environment will keep things from getting mixed up. It also helps ensure that no systems-installed packages are being relied on when developing.
The combination of pyenv and poetry will work. See https://python-poetry.org/docs/managing-environments/ for more info.

I added the instructions into read-me document. Please check


copy python files from extra_settings

The new approach to copy files from /app/docker/extra_settings will fail in kubernetes when overwriting the folder through a volume mount. README.md will no longer be there and as such the number of files will be 1, instead of 2 as expected by the if conditions. I propose this be moved to enumerate and copy all *.py files found in the folder.
Additionally, this PR also deals with celery beat and worker, for which the local_settings.py file is being copied only after executing python3 manage.py dbshell, causing late-defined variables to not be counted on. In my use case this causes the DB password to not be passed

@tiagoposse I like the idea of just copying to python files over instead of the entire directory
I am not crazy about putting DB creds in a local settings file though. We generally recommend using environment variables to set credentials

@Maffooch I'd love if you could expand on your opinion. env vars vs config files to store sensitive data is a very hot topic. I myself have been leaning to an approach using injection into config files (hashicorp Vault approach), but I'm always happy to have my mind enlightened

i've approved as regardless of storage of db credentials it's good to first try to copy over any extra settings before doing any work that might use them. not sure if there's anything k8s to think about @alles-klar as that was mentioned as where it's not working at the moment with 2.6.0


Add tests for limited variables

The implementation requires additional checks for limited variables, and safety of the rules. This PR reproduces some common unsafe rules.

(This will be included in #6)


:art: Dark theme

:grey_question: About
As Bloom gets better and better on datavi, I tend to use it to produce showable contents. Still, being able to put a drak/custom background would be better so produce easier to read graphs/artworks, and beter accessibility.
:dart: Feature request

Implement a color picket so we can choose the background scene color

We appreciate that you consider Bloom useful! Great suggestion, we'll put it as a suggestion for future releases.
Thanks for bring it up!

Thanks a lot for your kind feedbacks 🙏


Return creating node with (+) button & fix a regression

Pull Request Description
This PR returns previously reverted #3278 PR and also fixes a regression introduced by that PR.
The PR is quite big, so per-commit review is preferred.
The regression consists of two separate issues:
Issue 1
Node searcher thinks that adding a new node by internal API is the same as adding nodes by the user. After the project is loaded, the searcher thinks that one of the project nodes was just created due to an invalid state of the adding_new_node FRP output. After the user cancels node editing the searcher removes the "latest added" node.
To fix this bug I added an additional filter for the should_edit variable in ProjectView: now adding_new_node is only triggered when the node is added by the user, not by an internal API.
Issue 2
The second issue is much harder to debug. Let's look at how the searcher opens on the develop branch:

node_being_edited endpoint is triggered. ProjectView handles this output and the Searcher Presenter is initialized.
node_editing_started endpoint is triggered. GraphEditor calls node.model.input.frp.set_edit_mode(true), the implementation of node::input::Area calls model.label.set_content (see Cursor Setup section of the node/input/area.rs).
In turn, this leads to the graph.node_expression_set output trigger, which is handled by Searcher Presenter by calling Searcher::input_changed.
 Captured network communication between IDE and Engine shows that the searcher asks the action list twice: once after the searcher presenter is initialized and a second time when this set_content update happens. Only the second answer returns a non-empty action list for some nodes (like the .sort node from the default project). I think this additional communication requires special attention, but I don't know whether this is normal behavior.

Now, let's see what happened in the (+) button branch:

node_being_edited endpoint is triggered. However, this does not initialize Searcher Presenter - it is now initialized later.
node_editing_started endpoint is triggered. The flow is almost identical, with one important difference: we don't have Searcher Presenter ready yet. Therefore we don't get the second update from the Engine after node.input.set_content -> graph.node_expression_set call. For some nodes, this leads to an empty list of actions, and the searcher is virtually invisible.
ProjectView initializes the Searcher Presenter, but it is too late.

To sum it up: the Engine returns an empty action list for some scene nodes (I reproduced it for .sort node of the default project). Accidentally or not, the IDE asks the Engine twice - and it returns a correct action list for the second request. This second request is made by Searcher Presenter after we update the edited node expression (by removing non-connected port names I believe). Therefore the Searcher Presenter must be initialized at a time of node_editing_started handling in the Graph Editor.
To fix this bug I changed the used FRP endpoint from node_editing_started to node_being_edited – and the Searcher Presenter is initialized earlier now.
Important Notes

[ ] Add missing docs for newly added functions.

Checklist
Please include the following checklist in your PR:

[ ] The documentation has been updated if necessary.
[ ] All code conforms to the Scala, Java, and Rust style guides.
All code has been tested:

[ ] Unit tests have been written where possible.
[ ] If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

Ok, so there are few questions that need to be answered here:

Why the current implementation asks engine about this information twice? Was that on purpose? Is that documented somewhere?
Why engine sometimes returns empty list of entires? If the entries are not filled out yet, it should return information about lack of info, rather than empty list.
Regarding if the action was done by the user or was done by the system – I want to chat about it with you and Adam. This is more complex topic that we've been already covering in the past.

@vitvakatu Please check out the points 1 and 2 - talk with people that you need to talk and let's talk about the whole PR after you know the answers.


Rewrite/adjust more tests using decorators

Related to #290
This fixes the two tests @starksm64 asked me to take a look it. Feel free to put your work on top of this PR or just merge it and create a new one.
About InjectionPointTest - this test actually asserts things like AnnotatedParameter and others which we won't use in Lite. However, we want to use InjectionPoint API as such so I think we want to keep them in for now.

I didn't realize there is https://github.com/eclipse-ee4j/cdi-tck/pull/291 already up. I guess we can just merge both of these separately :)


SteamDir::app crashes due to unwrap when app doesn't exist

app unwraps to get the result:
steam_apps.apps.get(app_id).unwrap().as_ref()

It should probably be:
steam_apps.apps.get(app_id).and_then(|v| v.as_ref())

Thanks for the issue!
You seem to be right. I'll fix things and add regression tests tomorrow


Adding new VEP plugin NMD

Description
We are adding new plugin for VEP. This PR add the documentation for that.
This is for Ensembl release e!109
Use case
Plugin functionality available through REST.
Benefits
The endpoint needs documentation to be displayed.
Possible Drawbacks
None, the default behavior is the same.
Should only be merged if https://github.com/Ensembl/ensembl-rest_private/pull/124 is merged (have related configuration changes)
Should be merged after  https://github.com/Ensembl/ensembl-rest/pull/546 and https://github.com/Ensembl/ensembl-rest/pull/551 (change the same file - so incorporated those changes to avoid a merge conflict)
Testing
Tested on sanbox.
Changelog
[/vep/:species/hgvs/] new plugin option added: NMD
[/vep/:species/id/] new plugin option added: NMD
[/vep/:species/region/] new plugin option added: NMD

Coverage increased (+0.02%) to 44.405% when pulling c15ed708fbf2b0811e77358a277eb5a395a1accb on nakib103:add_nmd into 8e97787dc79eadd5ed64a42c79f6e95cc4057506 on Ensembl:main.

Hi @sgiorgetti , we would love to have it on 109, I have updated the - https://github.com/Ensembl/ensembl-rest_private/pull/124 according to review. Hope it could be merged pretty soon.


Help me my pc got locked

I just leave my laptop to my brother and suddenly my laptop got locked
He thought me he using some kind command to optimize my laptop and now my pc got locked and I dont know the username or password please help me

There are quite a few ways to resolve this, but this isn't the forum for those kinds of answers.


fix(detail/service): fix js error if no port is configured

Summary
Fixes #10822

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[ ] The PR template has been filled out
[x] The PR has been self reviewed
[ ] The PR has a reviewer assigned
[ ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Needs an automated test


[RadioMelodieBridge] Fix to use the new website layout

The website layout has been slightly updated, so the bridge needed to be adapted.

I tested your change and now it works perfectly. Thank you @sysadminstory

As strptime() is deprecated, I replaced it with a new function using date_parse_from_format() instead !


Register server5432.is-cool.dev

Added server5432.is-cool.dev using the CLI.

CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request


Add physical memory allocator

Ready for merge with master.

Am i supposed to review the code, and accept merge pull request?

You're supposed to review my changes. I'll merge PR myself.


Redesign: border width panel

Context

Summary
Redesigns the border panel.

To-do

User-facing changes

Before
After

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:
Figma

Add a rectangle shape
Verify the border panel looks like in Figma
Unlock the border width to see all the inputs
Add some values to see the color input
Verify that all looks as expected.

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6475

@googlebot I consent.

Verified in QA


fix: Don't call get_fields_for_table for skipped tables

Description
Though tkutcher/quickbase-client#40 cuts down on the number of files generated, it did not cut down on the number of times fields for tables were requested. This commit moves the "skip" logic to before theget_fields_for_table call.
It also adds pytest-mock as a dev dependency in order to test the change.
Checklist:

[x] Submitting to dev branch
[x] pytest tests passing
[x] Includes tests to cover the changes
[x] flake8 passing
[x] Relevant documentation added

Good point - thanks for this! I will merge and release as a patch on 0.3.


Logo Glower

Logo Glower..

Logo Glower..

Don't Create Pull Request For Small Updated

Logo Glower..

Don't Create Pull Request For Small Updated

Go It