fix typo

Thanks for this. However, we can't merge commits that have not been signed. Would it be possible for you to set up GitHub to sign your commits and then open a new PR? Once you get it set up, your future commits will all be signed automatically. Here's some more info:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits


Upload esp-dl to IDF Component Registry (AIV-647)

Hello @Auroragan
I can see that this is a IDF component with already implemented idf_component.yml. Do you plan to upload it to IDF Component Registry?
Let me know if you need any help, I can push a GH workflow that will do this automatically for you.
Cheers, Tomas

Hi Tomas,
Yeah we're interested in doing that, but I don't have any experience with the upload process. If you could help with the workflow, that would be great.


Lazy loading images should be implemented

Nice plugin, but sadly it can't handle bigger amount of images... And usually use case for galleries is to contain a lot of photos.
Cheers

@SlimDogs true, I will think about it

came here looking for this. glad to see its being considered :)

@SlimDogs @tomscript please check version 4.0.0


Installation error - Windows 11

Compiling rustpython-doc v0.1.0 (https://github.com/RustPython/__doc__?branch=main#d927debd)
error: failed to run custom build command for `openssl-sys v0.9.90`

Caused by:
  process didn't exit successfully: `C:\Users\username\AppData\Local\Temp\1\cargo-installOJh5LY\release\build\openssl-sys-4c9a6d64ff91284b\build-script-main` (exit code: 101)
  --- stdout
  cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR
  X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
  OPENSSL_LIB_DIR unset
  cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_INCLUDE_DIR
  X86_64_PC_WINDOWS_MSVC_OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
  OPENSSL_INCLUDE_DIR unset
  cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_DIR
  X86_64_PC_WINDOWS_MSVC_OPENSSL_DIR unset
  cargo:rerun-if-env-changed=OPENSSL_DIR
  OPENSSL_DIR unset
  note: vcpkg did not find openssl: Could not find Vcpkg tree: No vcpkg installation found. Set the VCPKG_ROOT environment variable or run 'vcpkg integrate install'

  --- stderr
  thread 'main' panicked at '

  Could not find directory of OpenSSL installation, and this `-sys` crate cannot
  proceed without this knowledge. If OpenSSL is installed and this crate had
  trouble finding it,  you can set the `OPENSSL_DIR` environment variable for the
  compilation process.

  Make sure you also have the development packages of openssl installed.
  For example, `libssl-dev` on Ubuntu or `openssl-devel` on Fedora.

  If you're in a situation where you think the directory *should* be found
  automatically, please open a bug at https://github.com/sfackler/rust-openssl
  and include information about your system as well as this message.

  $HOST = x86_64-pc-windows-msvc
  $TARGET = x86_64-pc-windows-msvc
  openssl-sys = 0.9.90

  It looks like you're compiling for MSVC but we couldn't detect an OpenSSL
  installation. If there isn't one installed then you can try the rust-openssl
  README for more information about how to download precompiled binaries of
  OpenSSL:

  https://github.com/sfackler/rust-openssl#windows

  ', C:\Users\username\.cargo\registry\src\index.crates.io-6f17d22bba15001f\openssl-sys-0.9.90\build\find_normal.rs:190:5
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: failed to compile `rustpython v0.2.0 (https://github.com/RustPython/RustPython#d66f4d53)`, intermediate artifacts can be found at `C:\Users\username\AppData\Local\Temp\1\cargo-installOJh5LY`

Did you tried the printed openssl-sys related trouble shooting?
You also can disable ssl feature not to install openssl.

Now, It's working. I donno the magic.


submit-nominee and internal-submit-nominee 'Links' field should be multiline

This is the 'Links about your candidate' field.

This was already a "textarea" and supported multiline if you press enter (it grows), but I've made it two rows by default now, to make it clear it's more than one line and get them in the habit of pressing enter.


add version flag

Thanks, I've wanted this for the browser version!

@vjeux Won't you need it from the API instead of the CLI for the browser?

Yeah, from the API indeed!

@vjeux @jlongster Not sure if this is what you meant by adding it to the api.

Nice, yep that's perfect! I would like this as well because on my blog post I show the version and right now it's hardcoded.


CrossBatch details in appendix A.2

As mentioned in Appendix A.2:

...across elements of the batch by dividing batch entries into four segments of equal size...The last segment consists of elements exposed to three additional contexts coming from the same document. We abbreviate this setup as 1/4(0,0), 1/4(1,1), 1/4(2,1), 1/4(3,0).

I am a little bit confused the implementation about the upper description. For the segment 1/4(2,1), suppose now we are in the i-th batch, do we need to maintain memory of all (i-2, i-1) batch so that we can obtain two different positive ones? or we just maintain batch i-1 but repeat the positive one twice? and how about the one negative one?
Beyond that, there are no any ablation experiments about this trick, is it necessary for llong llama training? Thx.

As mentioned in Appendix A.2:

...across elements of the batch by dividing batch entries into four segments of equal size...The last segment consists of elements exposed to three additional contexts coming from the same document. We abbreviate this setup as 1/4(0,0), 1/4(1,1), 1/4(2,1), 1/4(3,0).

I am a little bit confused the implementation about the upper description. For the segment 1/4(2,1), suppose now we are in the i-th batch, do we need to maintain memory of all (i-2, i-1) batch so that we can obtain two different positive ones? or we just maintain batch i-1 but repeat the positive one twice? and how about the one negative one?
Beyond that, there are no any ablation experiments about this trick, is it necessary for llong llama training? Thx.

And also another implementation consideration during training, in i-th batch, for j-th doc, if doc_i_j is the start of a new doc, which means doc_(i-1)_j is not the positive example of doc_i_j, should we handle this situation or ignore it? and how?


Backwards incompatible changes: client module - release 1.5.29

The OauthHelper class exposes the getToken() method.
It returned a TokenResponse and it returns a different response at this time: Result, where Result is: com.networknt.monad.Result;
Code at my client fails with this change and it makes the release backwards incompatible.
The fix should include:

documentation for the change to getToken()
sample code light-example

Change linked to closed issue #41

 Backwards incompatible changes: client module - release 1.5.29

Issue closed:
fixed by https://github.com/networknt/light-4j/pull/399


Getting a list of pages (for sitemaps, etc.)

Here's my take on getting a list of High Voltage pages for building sitemaps, based on this issue: https://github.com/thoughtbot/high_voltage/issues/123
If you're using the sitemap_generator gem, you could do something like this in your config:
HighVoltage.page_ids.each do |page|
  add page, changefreq: 'monthly'
end

I fixed the empty line, new line and "line too long" issues from Hound.
Should I make the double-quoted string changes? Seemed like most of the repo is using single quotes.

Thanks for the pr @bentoncreation.

Should I make the double-quoted string changes? Seemed like most of the repo is using single quotes

We're slowly in the process of moving towards double quotes. Instead of doing this via one big sweep we're just making changes as we go through. As such, any places that are touched we recommend moving to double quote usage.
Some other thoughts:
What do you think about extracting another class to represent a page (or view)? That way instead of having a few private methods in the PageCollector class that need the same argument passed around, it could be contained within this new object.
Something along the lines of:
if page.valid?
  page_paths.push page.path
end

Sure thing @dgalarza ! Thanks for the review.
Okay, I'll follow Hound on double quotes, etc. (Although, I think it's wrong about 'detect' over 'find'. It seems to be thinking it's Enumerable, not the Find module.)
A Page class makes sense. How would that relate to the PageFinder class? Are they overlapping at all? I want to make sure I get the right abstraction.

I don't think that the new class would overlap with the PageFinder class since PageFinder is specifically responsible for finding a given static page based off an ID.

Ok, cool. Also, I noticed in your sample code, you changed page_ids to page_paths. The original issue suggested page_ids as the interface...would you rather go with page_paths?

Ah good question. I named it page_paths in my examples since it looked like you were collecting the path to a page with url_path. It feels like a better name imo however I don't feel to strongly about it if you feel otherwise.

Does the following make sense to you?
It seems like we're trying to make a distinction between file paths and URL paths. They could be different, since you can override the PageFinder with the Rot13PageFinder. To keep that distinction, we're calling the URL path a page_id.
PageFinder says: give me a page_id and I'll find the file path.
PageCollector is saying: give me a base file path and I'll return the page_ids for all the files I find there.

Makes sense to me, :+1:

Great, thanks!

Hey @dgalarza, I've broken out the Page class we talked about and I think I have things ready for you to review. Let me know how this looks when you get the chance. Thanks!

@bentoncreation this is looking really good. Just a few more stylistic tweaks and I think this will be ready to merge soon. Thanks for keeping up with it @bentoncreation.

@dgalarza Hey, thanks for the guidance/patience! :) I'm going to try to make your recommended fixes this morning.

Awesome stuff @bentoncreation. Looks good to me. Would you mind squashing to prep this for a merge? Otherwise I can go ahead and do so.
Also, it might be useful to add something in the README about this and it's applicable usage.

:+1: nice work @bentoncreation. I'm not familiar with this codebase but I CRed and LGTM. Nice!

Thanks, @dgalarza! I'll work on a README update shortly.
Thanks, @aguynamedben!

Hey @dgalarza, can you let me know if the README update looks ok?

Looks good to me @bentoncreation

@dgalarza Okay, I think I squashed it right. That was my first time doing an interactive rebase. :) Let me know if anything else is needed.

Thanks again for the hard work on this @bentoncreation. I'll put out a release with this in it later in the week. :+1:

Sounds good, thanks!


Replacing boost::format with std::stringstream

As part of eliminating dependency from boost we replace boost::format with an alternative solution which relies on standard library only.
I've made two variants of the replacement:

the one which uses std::stringstream;
and another one with an own printf-like function;

I'm posting both variants as separate PRs and let you choose which one you like more.
In this PR we use std::stringstream.
The replacement looks like this:
was:
    LOMSE_LOG_TRACE(Logger::k_layout, str(boost::format(
        "Trying to create the EngroutersCreator for Imo id %d %s")
        % pImo->get_id() % pImo->get_name() ));

became:
    stringstream ss;
    ss << "Trying to create the EngroutersCreator for Imo id " <<
        pImo->get_id() << " " << pImo->get_name();
    LOMSE_LOG_TRACE(Logger::k_layout, ss.str());

It's a little bit more verbose but manageable. However there is one issue. LOMSE_LOG_DEBUG and LOMSE_LOG_TRACE are macros which in debug builds expand to calls logger.log_debug() and logger.log_trace(). In release builds these macros expand to empty code.
Therefore in release mode:

variant with boost::format produces no code.
variant with stringstream instantiates a stringstream object and writes into it, the result isn't used. I doubt compilers can eliminate instantiation and writing into stream here.

To avoid this unnecessary runtime overhead in release builds we should write:
#if (LOMSE_ENABLE_DEBUG_LOGS == 1)
    stringstream ss;
    ss << "Trying to create the EngroutersCreator for Imo id " <<
        pImo->get_id() << " " << pImo->get_name();
    LOMSE_LOG_TRACE(Logger::k_layout, ss.str());
#endif

This is considerably more verbose than the original boost-version.
These additional #if (LOMSE_ENABLE_DEBUG_LOGS == 1) are not included in this PR but they probably should be added if you choose that alternative.
The second approach (own printf-like function, for which I'll post another PR) works similar to boost::format version and doesn't produce code in release builds.

Finally, implemented version in PR #144, as discussed in #143. Thank you.


Updated constants.py

Using EARTH_SEMI_MAJOR_AXIS = 6378137 instead of EARTH_SEMI_MAJOR_AXIS = 6378137.0 may result in overflow error if float 64 is not enable in jax

I think there is a bigger conversation about how to make the detector part of Jim to be compatible with float32. Approving and opening a new issue related to that


How to search in Custom HTML templates?

Issue Type (delete the irrelevant ones)

[x] Question

Specs
What version are you using?
VGT: 2.21.10
VueJS 2
What browser?
Firefox 89.0 (64-bit)
Expected Behavior
What did you expect to happen?
Actual Behavior
What actually happened?
I cannot search items that are using HTML templates or we can say "slots".
1st photo:
As you can see here, There is an String that has a Letter "J"

2nd photo:
I tried to put a string/Character "J" on the search bar but it does not return any value

Code:

I ady Fixed it by creating a hidden Row which serves data for search and created a template for Rendering the Data.


Bump golangci-lint to 1.58.0

Bump golangci-lint to 1.58.0.
This will require a change in CI to bump golangci-lint.
Adds ./hack/module lint-in-docker which runs golangci-lint with a repeatable version number.

Marking as draft while I consider adding some new linters.

This is blocked on CI work to upgrade the linter to 1.58.1


Deletion age correction

Correct AGE record processing for deletion.
Some age records had breakpoints far from the expected locations in the reference. Also in some cases the breakpoints were far from each other in the contig sequence. I fixed these and added n input parameter that controls the min length of the sub-alignment.

@msahraeian , could you please add some short description about what the problem was in the pull request?

just did
On Tue, Oct 13, 2015 at 12:33 PM, Marghoob Mohiyuddin <
<EMAIL_ADDRESS>wrote:

@msahraeian https://github.com/msahraeian , could you please add some
short description about what the problem was in the pull request?
—
Reply to this email directly or view it on GitHub
https://github.com/bioinform/metasv/pull/69#issuecomment-147825289.


LED Strip

https://community.home-assistant.io/t/best-way-for-a-single-led-strip-for-ha/329913/2?u=nicholaswilde

https://dig2go.info/


app..json not found

D:\Workspace\toucan\src\server>dotnet run -p server.csproj -c Development
Unhandled Exception: System.IO.FileNotFoundException: The configuration file 'app..json' was not found and is not optional. The p
hysical path is 'D:\Workspace\toucan\src\server\app..json'.
at Microsoft.Extensions.Configuration.FileConfigurationProvider.Load(Boolean reload)
at Microsoft.Extensions.Configuration.FileConfigurationProvider.Load()
at Microsoft.Extensions.Configuration.ConfigurationRoot..ctor(IList`1 providers)
at Microsoft.Extensions.Configuration.ConfigurationBuilder.Build()
at Toucan.Server.WebApp.Main(String[] args) in D:\Workspace\toucan\src\server\Program.cs:line 15

I will check the readme docs - they must be out of date. Since I migrated the template to Asp.Net Core 2.0 it uses the framework environment variables. You should be okay if you run the following before starting the project up
set ASPNETCORE_ENVIRONMENT=Development
set ASPNETCORE_URLS=http://localhost:5000
dotnet run -p server.csproj
Just as an FYI - I am almost ready to deploy an update that is a fairly big one! It provides for proper I18n support, and also a lightweight 'pre-launch' app loading page (for mobile users on slow connections)

hi @samdubey i have updated docs, and release the new version last night (2.1.0)
if you run into any issues during install or setup of the latest version, just let me know and I will try to figure them out.
the yeoman generator worked okay for me from a fresh install


False or outdated information

At
Ensure correct package format
I tried to follow these steps but on VS for Mac 17.6.1 (build 452) I do not have any options at least close to what is described or shown on the screenshots. Also the screenshots do not match the written advice.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 52ddc473-7f14-f391-2589-1484ce1aa3be
Version Independent ID: 52ddc473-7f14-f391-2589-1484ce1aa3be
Content: Publish a .NET MAUI Android app for Google Play distribution - .NET MAUI
Content Source: docs/android/deployment/publish-google-play.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @hinnerkweiler
The doc is accurate for Android publishing from Visual Studio, not Visual Studio for Mac. Afraid that there are no plans to add instructions for doing the same from VSMac.


python312Packages.debugpy: 1.8.8 -> 1.8.9

https://github.com/microsoft/debugpy/releases/tag/v1.8.9
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 358498

x86_64-linux

:white_check_mark: 6 packages built:

home-assistant-component-tests.debugpy
python311Packages.debugpy
python311Packages.debugpy.dist
python312Packages.debugpy
python312Packages.debugpy.dist
vscode-extensions.ms-python.python


Ldap host failover

Continuation of #3742
TODO

[x] Connection is no longer cached per-request. Either need to tweak test expectations or add caching layer in.
[ ] Manual Testing
[ ] Added automated failover/error coverage

Closing this off since I can't get it to a point I'm happy with after spending another few hours today.
Is technically working but now has multiple layers of additional complexity and worse testing capabilities and code just to expose details for testing.
Would need a fresh approach that keeps the low-level function abstraction, but not in the way done here.
The value/demand is minimal for this feature, and I don't want to waste any more time for something of little benefit, especially as this would still need additional real-world testing which requires even more time. Closing off for now.


fix: wrap output in single quotes to allow for multi-line secrets

Closes: https://github.com/sst/sst/issues/3789

Thanks!


Tabular Editor 2 freezing after any changes

Discussed in https://github.com/TabularEditor/TabularEditor3/discussions/1154

Originally posted by @VasilinaBalashevich October 24, 2023
When I do any changes in a tabular cube, like adding a new table or even renaming the existing ones, the TE starts freezing for ages (  about 1 hour). I've reinstalled it several times, the service desk team updated the system, so it must work properly, as my mates have the same laptops and the same version of TE, and they don't face this issue. Please,  give me a hand as it hinders efficient work.
@otykier:
Just to clarify, does this freeze happen when you attempt to save the change, or does it happen immediately when you make the change? Which version of TE2 are you using?
@VasilinaBalashevich:
It happens immediately when I make the change, e g I have just created a new relationship, once I clicked 'new relationship' it started freezing. the version is TE 2.20.2
@otykier:
I'm sorry, but it's not something I've seen or heard about before, so it's not easy to figure out what's causing this. Are your colleagues using the same version? Do you have access to another machine where you could try to install Tabular Editor to see if the same issue occurs there?

Yes, my colleagues use the same version. Unfortunately, I don't have another machine, probably it makes sense to install it on VM?

Yes, I would recommend installing on a VM to see if that solves the problem.
Which version of Windows are you using on your machine? You can see this by opening a command prompt:

I have the same as you - Microsoft Windows [Version 10.0.19045.3570]

I wonder if you have any custom macros or best practice rules installed, that would cause TE to become slow?
Could you try to rename your %LocalAppData%\TabularEditor folder into something else, just to keep it as a backup, and then try again? If this doesn't help, could you let me know if your colleagues are working on the same model as you, or a different one?

The renaming the %LocalAppData%\TabularEditor folder helps! Fantastic! thank you soooo much for your help!

Glad to be of help.
Out of curiosity, did you have any custom best practice rules? I suspect that one of these rules may have slowed down your Tabular Editor installation. If you could share your BPARules.json file from that folder either here or with<EMAIL_ADDRESS>I would be happy to take a closer look.

Thank you. It looks like these are the official best practice rules from Microsoft? - last question: How many measures (approximately) does the model you're working on contain?

9057 measures

Suspicion confirmed, thanks! (Some of the rules compare every measure in the model against every other measure - so that’s like 9057*9057 comparisons, which happens every time something is changed in the model - so that explains why it becomes so slow it basically freezes).

Thank you for explanation, and for your help! have a great life:))


Documentation update: followup to #1736, fix typo on inline.rst

Add note about ordering when sorting by custom-fields on query.rst (as per https://github.com/sampsyo/beets/pull/1736#discussion_r45827719)
Fix typo on inline.rst.

Again, I'm issuing it as a pull request, in the hopes of having it double checked while my beets-documentation-style skills are not fully developed!

Perfect. Thank you for being so quick! And for fixing those embarrassing formatting typos. :flushed:


collection.some is not a function

angular.js:13424 TypeError: collection.some is not a function
at findIndex (angularjs-dropdown-multiselect.min.js:1)
at Scope.$scope.isChecked (angularjs-dropdown-multiselect.min.js:1)
at angularjs-dropdown-multiselect.min.js:1
at Object.forEach (angular.js:321)
at Scope.$scope.getButtonText (angularjs-dropdown-multiselect.min.js:1)
at fn (eval at compile (angular.js:14268), :4:230)
at expressionInputWatch (angular.js:15321)
at Scope.$digest (angular.js:16860)
at Scope.$apply (angular.js:17133)
at done (angular.js:11454)
Here's the plunker to show the error
https://plnkr.co/edit/SqZGFwf4iD09MqLiisPK?p=preview
So the issue really seems to be with setting value to model where if I set it to an object I see this error. I wanted to have to as single select hence the object instead of an array.

If someone can help me with this error sooner, it would be really helpful. thanks in advance.


WIP Enable configuration of TOP_DIR

used by default_filter_filename.
The test suite of my tool runs forked processes in a temporary directory (via tempfile.mkdtemp) which does not share the same root directory as the test suite.
This implies all calls are filtered out by default_filter_filename.
Adding the set_top_dir was enough to avoid filtering out.
This is a simple enough way to work around the little naive assumption made by:
TOP_DIR = os.path.join(os.getcwd(), '')     # current dir with trailing slash

Would you see a better solution ?

I have moved the definition of the variables closer to where they are used.
See #112 to avoid global vars while still enabling top_dir customization.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: confusing nil in direct interface with typed nil

fix #376

Codecov Report

Merging #377 (c8d6da8) into master (27bd0f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   79.92%   79.92%
=======================================
  Files          52       52
  Lines       17561    17563    +2
=======================================
+ Hits        14036    14038    +2
  Misses       2957     2957
  Partials      568      568

ping @goccy


document: how to calculate script integrity hash for Plutus v3

regarding plutus v1/2, a text file with the key names for cost model was provided as part of cddl. which is missing for Plutus v3. Please document the spec for calculating script integrity hash for plutus v3.
This is required for non-haskell tools to support building transactions with plutus scripts.

Could you please elaborate? I am not aware of any text files with key names.
The process of script integrity hash calculation did not change for PlutusV3. Also names for parameter keys for CostModels never participated in hash integrity calculation, CostModels were always represented as a list of integers. Moreover this list will no longer be static for all Plutus versions. Starting with Conway it will be possible to add new primitives, thus number of elements in that list will change.

@lehins
found this, https://github.com/IntersectMBO/cardano-ledger/commit/8e0419193b92e161cea833664bf1919df8fb9775#diff-4683b5e894b0b003ec15f7ff32c5cd5725debf47894e3f6aa70c5dda85bc7fd2


Improve example – simplify code and add streaming functionality

My initial goal was to add streaming example to a starter template. But while adding it I found several confusing problems:

We suggest using instance manager but not showing how to do this
We are using separate struct as management instance (instanceSettings) - it's a bit confusing how to get datasource setting inside SampleDatasource QueryData method (need to call instance manager with type assertions), also instanceSettings contains unused http client - also not really obvious why it's there
I think that with current layout it's pretty non-obvious to do a proper resource cleanup when Dispose called (for example cleanup sth belonging to SampleDatasource instance) - thus we don't provide a straight way for correct cleanups.

I changed example a bit using a companion pr to SDK  - example now uses automatic instance management hidden inside new datasource.Manage method. I believe this simplifies plugin code drastically.
The problem with this approach I see is that real plugin capabilities are not known (since we don't have access to datasource instance till first request from Grafana, automatic instance manager implements all capabilities). If this is a real problem then maybe we can add an option where developer explicitly tells which capabilities datasource instance provides. The current approach solves this but in a way which is pretty confusing.

The only comment I have is about adding the streaming support. Otherwise this looks good!

It seems not great to want a new streaming example... rather than one well maintained example that shows the APIs (people can easily remove them if they do not want it)

I don't see how this is a good argument. It could be used to justify adding just about any feature to the starter. Every feature we add will make it harder for new plugin authors to wrap their heads around it. They way I see it, the starter should be relevant for at least 80% of the people who use it. If instead 80% have to remove said feature, we risk losing newcomers who struggle to figure out things they don't even need.
If you deem streaming to be relevant for most of the people using the starter, then I'm ok with adding it as long as we make it clear that it's only available for 8.0.

I do appreciate the abstraction of the instancemanager. that was one of the more confusing aspects that I remember when I first started.
I'm not sure which is better, <- time.After(...) or using a time.Ticker. I think I prefer a time.Ticker but that's just me, maybe introducing a new type might not be the best idea.
Looks good to me!

developers thinks they need to implement everything such as health check, query data, resource and streaming rather than start with queryData for example. If streaming is going to be part of this I would suggest that CallResource example is included as well.

For now let me add some comments into code which explains that a bit, and yep - adding CallResource sounds like a good thing since we are adding streaming.

If you're adding CallResource, I think a welcome addition for users experienced in Go would be to use the httpadapter.


Connections dropped when Hikari used with RDSProxy

We are using a set of microservices built in Java that run on ECS Fargate. They connect to an AWS RDS PostgresDB. Each service uses a Hikari connection pool with the following settings: maxPoolSize 10, maxLifetimeMs 25 mins, minIdle 0, and idleTimeoutMs 10 seconds.
This setup worked well, but we had to introduce RDSProxy to run one of the microservices in Lambda. Now our microservices reach RDS through Hikari and RDSProxy: Hikari → RDSProxy → RDS. Note that RDSProxy is configured with IdleClientTimeout set to 30 mins.
With the new setup, we have started receiving the following error:
HikariPool-1 - Failed to validate connection org. PostgreSQL.jdbc.PgConnection@16913c10 (This connection has been closed.). Possibly consider using a shorter maxLifetime value.

While this error is rare at about once a month, it suggests that connections are getting closed. Since some microservices in our setup are on the critical path, we can’t afford to drop connections.
We expect active connections not to get dropped, and based on our configured settings, we expect no idle connections in Hikari - at least after 10 seconds. Therefore, we can't identify why these connections are being dropped.
Can you advise on configuring Hikari with RDSProxy so that connections don't get dropped?

To elaborate on the issue: RDS proxy is an AWS-managed database proxy and the error message above indicates that the connection is being closed by RDSProxy. Its setting IdleClientTimeout is used to specify how long a client connection, in our case, a Hikari connection, can be idle before the proxy closes it.
It appears that because the Hikari connection is idle for longer than the value of the IdleClientTimeout setting, i.e. 30 mins, the Hikari connection is being closed.
The settings minIdle 0 and idleTimeoutMs 10 seconds ensure that idle Hikari connections don’t exist and those that do close after 10 seconds. We also set maxLifetimeMs to less than 30 mins and equal to 25 mins. However, RDSProxy is still closing the connections. Can you suggest what we can look for to investigate this further?

Update: We think this is only a warning message, and we can ignore it.


First attempt at rust for v1 official CIFF format.

Here's my first take on using the new "official v1" ciff format.
Pretty much my first ever piece of rust code, so please take a careful look. The code runs and gives expected results for Robust04.

Thanks @elshize -- added those changes now, ready for another look.


bugfix writer status is read and write concurrently and will core by use after free

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Fix Python interop unit-tests on Windows

Depends on #6797, which depends on #6791.
Fixes #5163.

Python Windows is green on basic tests.

Zomg this got git-insensitive-rebase-conflict-sniped.

LGTM after rebase

Still kicking the tests...

Portability test results are consistently insane; this change did not touch C++ code in any way that ought to be running for C++-specific builds, and yet... failures when building the protobuf library (not grpcio-tools) abount.

Something got screwed up with the submodules. https://grpc-testing.appspot.com/job/gRPC_pull_requests/10711/config=opt,language=sanity,platform=linux/testReport/junit/(root)/tests/tools_run_tests_sanity_check_submodules_sh/
But the .gitmodules file was never touched. Hm.

Hah, turns out I was wrong. Somewhere in there the wrong version of protobuf got checked out and committed... y'know, I still haven't the darnedest idea how that happened.

test this please

Relevant tests passed, marking ready to merge.


forEach doesn't work if array item is null

I use helper in this way
{{# forEach allergens }}     {{ tag }}{{# unless isLast }},{{/ unless }} {{/ forEach }}
but if allergens = [{tag:32}, null] I got an error Cannot set property 'index' of null line

Please see my open issue with BigCommerce Stencil-CLI, as this is causing server 500 errors and is any easy fix.
Thanks!

My local fix was to add an empty array as a default parameter, but you may choose to do a fast-fail...
helpers.forEach = function(array=[], options) {

Good catch... Since null won't cause the default to be used. Want to do a PR?

Hi @jonschlinkert
Is this still open? I would be glad to do a PR to fix this.


a reminder ......

📢 Suggestion proposed by Profxy<PHONE_NUMBER>30229761)
What is the title of your suggestion?
a reminder ......
Explain your suggestion more accurately (It's best to give as much information as possible, so that we can implement the suggestion better)
it would be nice if we can add a reminder / timer, so you won't forget something.
for example ?timer 2h <notificationtext> or ?remind 2h <notificationtext>
maybe add the possibility to remind someone else: ?timer 2h $usermention$ (instead of mention the ID or tag should be possible too)
after the time, Lenox should answer @User#0000 you were remembered: <notificationtext>
Why should we add this feature?
so you do not forget things 😄
Comments:
✅ Dadi: maybe ?remind instead of ?timer
❗✅ Monkeyyy11: I am working on this feature currently so I need this suggestion to be approved

#76


node with maxlength on create or rename

is there any way to limit the amount of characters the user can enter when inserting or renomar one node

No, sorry that is not possible with a setting. You can build your own code of course:
$("#tree").on("keydown", ".jstree-rename-input", function (e) { ... });

Best regards,
Ivan

thank you, it was what I needed


How do we monitor our acquisition database?

In addition to previous issue ticket, how do we ensure that all of our SLC acq metadata ES database is up-to-date?
Here are some rough examples - maybe the facets are wrong, but it seems like we can have significantly less acquisition documents in our database for certain time periods.
(Aria)
https://mamba-grq.aria.hysds.io/search/?base64=eyJxdWVyeSI6eyJib29sIjp7Im11c3QiOlt7InRlcm0iOnsiZGF0YXNldC5yYXciOiJhY3F1aXNpdGlvbi1TMS1JV19TTEMifX0seyJxdWVyeV9zdHJpbmciOnsicXVlcnkiOiJtZXRhZGF0YS5zZW5zaW5nU3RhcnQ6ezIwMjAtMDEtMDFUMDA6MDA6MDBaIFRPIDIwMjAtMDEtMDNUMDA6MDA6MDB9IiwiZGVmYXVsdF9vcGVyYXRvciI6Ik9SIn19XX19LCJzb3J0IjpbeyJfdGltZXN0YW1wIjp7Im9yZGVyIjoiZGVzYyJ9fV0sImZpZWxkcyI6WyJfdGltZXN0YW1wIiwiX3NvdXJjZSJdfQ== ( about 1900)
(ASF)
https://search.asf.alaska.edu/#/?start=2020-01-01T00:00:00Z&end=2020-01-02T23:59:59Z&resultsLoaded=true&granule=S1B_IW_SLC__1SDV_20200102T235532_20200102T235602_019645_025205_8E4D-SLC&productTypes=SLC,METADATA_SLC (about 2k)
The change here seems more dramatic:
(aria)
https://mamba-grq.aria.hysds.io/search/?base64=eyJxdWVyeSI6eyJib29sIjp7Im11c3QiOlt7InRlcm0iOnsiZGF0YXNldC5yYXciOiJhY3F1aXNpdGlvbi1TMS1JV19TTEMifX0seyJxdWVyeV9zdHJpbmciOnsicXVlcnkiOiJtZXRhZGF0YS5zZW5zaW5nU3RhcnQ6ezIwMjAtMDUtMjlUMDA6MDA6MDBaIFRPIDIwMjAtMDYtMDFUMDA6MDA6MDB9IiwiZGVmYXVsdF9vcGVyYXRvciI6Ik9SIn19XX19LCJzb3J0IjpbeyJfdGltZXN0YW1wIjp7Im9yZGVyIjoiZGVzYyJ9fV0sImZpZWxkcyI6WyJfdGltZXN0YW1wIiwiX3NvdXJjZSJdfQ== (<250)
(asf)
https://search.asf.alaska.edu/#/?end=2020-05-30T23:59:59Z&resultsLoaded=true&granule=S1A_WV_SLC__1SSV_20200530T234444_20200531T000010_032801_03CCA7_D8B3-METADATA_SLC&productTypes=METADATA_SLC&start=2020-05-29T00:00:00Z (about 2k)

Ok, this is definitely a start. What are your thoughts creating an AOI that spans the globe and then loop through tracks? Is this feasible in time?
There is no documentation for this repo. How was this meant to be run?

Why create a global AOI? You could just set this up as a cron to run however often you'd like and have it iterate through all aoi-track datasets.
I'm not familiar with the code, but reading it, you'll find this snippet that tells you what inputs it takes:
https://github.com/aria-jpl/ops_scripts2/blob/f6a067ee6308641a4fb0ae1269399dd77cccee30/check_acquisitions/check_acquisition_completeness.py#L262

So for the standard product, this could be run for each AOI and track and things could, in theory, be tracked accordingly after learning about said script/PGE.
For coseismic,  when we have to let the pipeline producing AOITracks in along tracks (that could be previously unmonitored), how would we monitor the SLC metadata in this setting to ensure the enumerator works as expected which relies on this? @riverma

It's only recommended that we run the scrapers over the the AOI's because we do not have a reliable, independent way of confirming our collection of SLC metadata is up-to-date. Ideally, we should be up-to-date with SLC metadata world-wide, so I think it would be best to not think in terms of AOI's or AOI tracks and instead focus on developing an independent checker that works in conjunction with the cron scrapers.

@marjo-luc - please go ahead and create a new dev ticket to track the proposed solution you're recommending.


Z scaling

@bbastings please take a look at the tool/AccuSnap changes.

@bbastings please take a look at the tool/AccuSnap changes.

Looks ok, I may revisit the MeasureDistanceTool changes after this merges...


Set up a git ignore so that I don't keep countless old huge png files around.

I think I've fixed this. I want to double check it, though.

I think we're good.