generate.py does not generate a proper script for nona + [fix]

Distro: ArchLinux
Hugin: extra/hugin 2014.0.0-2
Version: pannellum-2.0.1_full and trunk (rev: 3d1f9344fb254c03d3f2f1d6e23dc79af38e6ca8)
When I call nona command it generates: 0, 1, 4, 5 faces files only (we are missing: 2 and 3). The current nona version accepts a different scripting syntax: '+p90' instead of 'p90' or '-p90' instead of 'p-90'.
diff --git a/generate.py b/generate.py
index faf086a..babee1d 100755
--- a/generate.py
+++ b/generate.py
@@ -72,8 +72,8 @@ text.append('p E0 R0 f0 h' + str(cubeSize) + ' n"TIFF_m" u0 v90 w' + str(cubeSiz
 text.append('m g1 i0 m2 p0.00784314')
 text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" p0 r0 v360 w' + origWidth + ' y0')
 text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" p0 r0 v360 w' + origWidth + ' y180')
-text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" p-90 r0 v360 w' + origWidth + ' y0')
-text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" p90 r0 v360 w' + origWidth + ' y0')
+text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" -p90 r0 v360 w' + origWidth + ' y0')
+text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" +p90 r0 v360 w' + origWidth + ' y0')
 text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" p0 r0 v360 w' + origWidth + ' y90')
 text.append('i a0 b0 c0 d0 e0 f4 h' + origHeight + ' n"' + origFilename + '" p0 r0 v360 w' + origWidth + ' y-90')
 text.append('v')

Thanks for your help. I'm satisfied that we solved this problem.
Regarding my panorama I workaround the issue by adding a black background and resizing the image. Then after I run your script it produced the proper set of images. I've also override some variables like minPitch/maxPitch to 0 and the result is much better.
Google's panoramas are very wide but not so high and that's a problem when you want to initially present a static image and then switch to dynamic presentation - the size of frame should be different for both cases. Though I did a trick in pannellum.htm and after a clicking button I resize the hight of frame.. Is there any other way I can do that without touching your code?

No, not at the moment.

hi matt.. i had a problem with multires image when its in fullscreen mode. The panorama doesnt run smooth. i use image with 3000x1500 dimensions

The multires renderer could use some performance improvements. However, with an image that small, using multires is probably not needed. The image isn't that big, so it doesn't take that long to download, and 99% of devices support that resolution.

yes, i use it for safari and iphone due their lack webgl support. But with that small image, it doesnt running so well on desktop fullscreen.

Closing as this seems to be resolved.


Moving from Bulleye to bookworm broke pip install

Hello team,
I just want to report an issue woth new docker image running with Bookworm. Installing image via PIP not working anymore with this container
Versions used
Docker version : 19.03.13
Gitlab runner version : 13.4.0
Image used : python:3
Workaround
use python:3-bullseye to fix the issue
Log
Step 10/26 : RUN pip3 install --no-cache-dir -r pkg/requirements.txt
 ---> Running in f834de7c2606
Collecting mkdocs==1.4.3 (from -r pkg/requirements.txt (line 1))
  Downloading mkdocs-1.4.3-py3-none-any.whl (3.7 MB)
ERROR: Exception:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/cli/base_command.py", line 169, in exc_logging_wrapper
    status = run_func(*args)
             ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/cli/req_command.py", line 248, in wrapper
    return func(self, options, args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/commands/install.py", line 377, in run
    requirement_set = resolver.resolve(
                      ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 92, in resolve
    result = self._result = resolver.resolve(
                            ^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 546, in resolve
    state = resolution.resolve(requirements, max_rounds=max_rounds)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 397, in resolve
    self._add_to_criteria(self.state.criteria, r, parent=None)
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/resolvelib/resolvers.py", line 173, in _add_to_criteria
    if not criterion.candidates:
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/resolvelib/structs.py", line 156, in __bool__
    return bool(self._sequence)
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/found_candidates.py", line 155, in __bool__
    return any(self)
           ^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/found_candidates.py", line 143, in <genexpr>
    return (c for c in iterator if id(c) not in self._incompatible_ids)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/found_candidates.py", line 47, in _iter_built
    candidate = func()
                ^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/factory.py", line 206, in _make_candidate_from_link
    self._link_candidate_cache[link] = LinkCandidate(
                                       ^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 293, in __init__
    super().__init__(
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 156, in __init__
    self.dist = self._prepare()
                ^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 225, in _prepare
    dist = self._prepare_distribution()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/resolution/resolvelib/candidates.py", line 304, in _prepare_distribution
    return preparer.prepare_linked_requirement(self._ireq, parallel_builds=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/operations/prepare.py", line 516, in prepare_linked_requirement
    return self._prepare_linked_requirement(req, parallel_builds)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/operations/prepare.py", line 587, in _prepare_linked_requirement
    local_file = unpack_url(
                 ^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/operations/prepare.py", line 166, in unpack_url
    file = get_http_url(
           ^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/operations/prepare.py", line 107, in get_http_url
    from_path, content_type = download(link, temp_dir.path)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/network/download.py", line 147, in __call__
    for chunk in chunks:
  File "/usr/local/lib/python3.11/site-packages/pip/_internal/cli/progress_bars.py", line 52, in _rich_progress_bar
    with progress:
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/rich/progress.py", line 1169, in __enter__
    self.start()
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/rich/progress.py", line 1160, in start
    self.live.start(refresh=True)
  File "/usr/local/lib/python3.11/site-packages/pip/_vendor/rich/live.py", line 132, in start
    self._refresh_thread.start()
  File "/usr/local/lib/python3.11/threading.py", line 957, in start
    _start_new_thread(self._bootstrap, ())
RuntimeError: can't start new thread
The command '/bin/sh -c pip3 install --no-cache-dir -r pkg/requirements.txt' returned a non-zero code: 2

Duplicate of https://github.com/docker-library/python/issues/843 and https://github.com/docker-library/python/issues/835 .


Contact section is added

Related Issue
contact section is added and its backend code also
Closes: #116
Describe the changes you've made
https://user-images.githubusercontent.com/55352601/115186206-ee97df80-a0fe-11eb-8e55-bf91c26cf71e.mp4
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Mention any unusual behaviour of your code (Write NA if not)
Any unusual behaviour of your code
Checklist:

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly whereever it was hard to understand.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[x] I am a GSSOC Participant.

thanks @vigneshshettyin i will raise a issue for table as you said in some time


fix books link & update code block

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
❌

Fixed issues
https://github.com/yiisoft/yii2/issues/18730

I added the correct links where they were.
all lang checked

Great! Thanks.


contact participants to register

Hi @SebaDele, I can take this up. I would need the email addresses of the participants. Their names are mentioned in this sheet. https://docs.google.com/spreadsheets/d/1H9D26zIsoUDP6xFV62ONGNRsfAw-SII5zPi76EmVFXw/edit#gid=1889372594
thanks,

contacted the participants that did not register yet (or indicated that they need sponsoring)


No auto-reload

Problem

I use trunk serve --open  like in the tutorial and it doesn't reload
Steps To Reproduce
Follow the tutorial
Expected behavior
auto-reload
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

Yew version: 0.20.0
Rust version: 1.68.2
Build tool, if relevant: trunk
OS, if relevant: Windows

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

I am not smart enough to fix

This is a bug not of Yew, but of Trunk, file the issue in that repo.

I'm closing this as this is a Trunk issue

I think this is a known issue with trunk. Adding a "cooldown" at the end of the build eats of change events. There's a fix which seems to work for some people, but as trunk's development seems to have stalled again, it is not released in trunk itself, but in trunk-ng.
With trunk-ng, you can disable the cooldown (using --ignore-cooldown). If enough people report that that's the fix for them, I would swap around the default and make it "opt-in", instead of "opt-out".


Is there a providers list?

The only provider that I could find was the aws provider. Isn't there a public provider list that I can add by default to my setup

if you want regex i can provide you some patterns

A provider is any script that outputs a list of patterns. You can create your own, or copy them from other sources. I will follow up in #194.


Allow key/value pairs as sensor/node metadata

This is a feature request for the Backend.
Explain what you want to do
When setting up larger usecase, you might end up with different sensors used (which send into the same application), where you want to store e.g. some information about how they are deployed. (e.g. in which height, indoor/outdoor, sensor model, software version of the node)
This information should available to everybody, who listens to the event stream (console, mqtt...), and different people might - based on these metadata - do different calculations with the data.
This key/value dictionary should be read & writeable via API. Additionally each data record, which is outputted via console, mqtt etc. should have the key/value dictionary as additonal information.

Device attributes as a key/value dictionary can indeed be useful.
A challenge here is to distinguish between generic attributes and custom attributes. The generic attributes are in fact the ones you mention; location, placement, manufacturer, model, version.
There are three possible implementations; 1) adding these as builtin device attributes, 2) introduce key/value attributes with reserved keys and custom keys, or 3) introduce key/value attributes with only custom keys (e.g. don't add UI/UX support for the fields you mentioned in TTN).
I would suggest option 2.

Option 1 seem more fitting to me.
Though it will be useful, this data should be kept to the minimum.
Adding information such as location, software version, sensor model fit TTN purpose and are indeed useful to monitor the health of a device, but data such as indoor/outdoor seems to be irrelevant here. They are applications oriented data and as such should be stored somewhere else or sent by the device himself.
When setting up large use case TTN allow simple communication with devices and monitoring. Data processing, storage, business intelligence will be handled by an integration or by your own solution. There the rest of metadata will be readily available or pulled from a service or database.

I'd vote for option 2) , because option 1) requires you to know all potential keys/values, which later can be applied.
This limits the usecases, which other people might want to do with TTN.
In my understanding the solution should allow to stick all sensor-specific metadata to the node object in TTN.

We will move on with option 2.
Here is the plan:

Add only reserved field, they will be generic data that can be filled by TTN or the user. Most likely to be under the form 'ttn_..."
Customs keys will be added later but limited. Having a few keys can indeed prove very useful but providing more is not TTN job. That's why we have integration with more complex platform such as Azure, AWS and other IoT broker.

I will open issues for each development phase and reference them here.

@dakoller What type of data you want (location, sensor model, firmware version...) ?
There will be very few of keys available (white listed) in the first version. So if you can tell us the one you want, we can add them now.

I would suggest:

Brand
Model
Version
Antenna
LoRaWAN module

We already have the location

Closed by #605. Will be included in next release


Metrics Upgrades

Running issue for metrics upgrades:
Increasing unittest coverage:

Tests for synops LSTMCell, RNNCell, GRUCell should include batch size > 1

Features / Modularization:

Connection sparsity pull out long if/elif statement to separate functions
Hooks are only added specifically for the metrics that need them

@SreyesVenkatesh, @jasonlyik I found this codecov.io tool to give a better overview of the code covered by the unit tests. Once implemented it will be beneficial to extend our unit tests.

https://app.codecov.io/gh/NeuroBench/neurobench
Here you can find the report


Can RestTestGen detect wrong status codes?

I have some test API with endpoint GET /testStatusCode. In the OAS is defined, that this endpoint will return 200 or 400 status code. Instead, I implemented my API to always return 403. Other fuzzers can detect this difference between real status code and specified status code as bug. What about RestTestGen? Is this possible? Or is it already implemented and I just don't get the information out of the results?
Thanks for your great work so far :)

Hello!
Often, specifications are incomplete, and, in most cases, they do not provide any output schema information or just the schema for the 200/201 responses. For this reason, we decided not to implement such a check because it would raise a lot of false positives.
Nevertheless, I believe that such a check can be implemented in a subclass of Oracle in less than 5 minutes! Do you want me to implement it? Do you want to try to implement it yourself? Let me know!
Thanks!
Davide

Thank you for your quick reply.
Okay, your explanation makes sense.
I see in StatusCodeOracle.java that you test what type of status code comes back and set the test result. I have tried to implement this here, but I don't know how to access the expected status codes from the specification, which I need to compare with the status code we actually get back.
Maybe you can help me out here?
To avoid a lot of false positives, I may be able to implement an option in my version to disable or enable this type of detection.

Let me implement it for you. I'll be back in 5.

Here is it! Please note:

I did not test this code.
You should explicitly call this Oracle in the testing strategy you are running. You should probably call it in the same place the standard StatusCodeOracle is called!

Let me know if it works!
package io.resttestgen.implementation.oracle;

import io.resttestgen.core.testing.Oracle;
import io.resttestgen.core.testing.TestResult;
import io.resttestgen.core.testing.TestSequence;

import java.util.Set;

public class SpecificationStatusCodeOracle extends Oracle {

    @Override
    public TestResult assertTestSequence(TestSequence testSequence) {

        TestResult testResult = new TestResult();

        if (!testSequence.isExecuted()) {
            return testResult.setError("One or more interaction in the sequence have not been executed.");
        }

        // The received status code as string
        String receivedStatusCode = testSequence.get(0).getResponseStatusCode().toString();

        // The set of status codes defined in the specification for the operation of this interaction
        Set<String> specificationStatusCodes = testSequence.get(0).getFuzzedOperation().getOutputParameters().keySet();

        if (specificationStatusCodes.contains(receivedStatusCode)) {
            testResult.setPass("The observed status code is defined in the specification.");
        } else {
            testResult.setFail("The observed status code is not defined in the specification.");
        }

        testSequence.addTestResult(this, testResult);
        return testResult;
    }
}

Thanks for your implementation.
It works, yes 👍🏻
But somehow, on other endpoints where an 404 is defined according to my specification, it still says:
"SpecificationStatusCodeOracle": {
      "result": "FAIL",
      "message": "The observed status code is not defined in the specification."
    }

Here you can see my Swagger, where 200, 400 and 404 is defined.

I think, the Set does not contain the correct status codes. I added some line to check what's inside the set:
// The set of status codes defined in the specification for the operation of this interaction
Set<String> specificationStatusCodes = testSequence.get(0).getFuzzedOperation().getOutputParameters().keySet();
System.out.println("SET: " + specificationStatusCodes);

As you can see in the following picture, the set often contains no status codes or sometimes just one.

Mmm, that's strange!
Could you share the OpenAPI specification you are using so I can check what's going on with a debugger?
Thanks.

Sure, here
api.json

Hello!
I've checked with the debugger and I can see that RTG ignores responses without a schema. In particular, in your specification you only define a status code and a description for responses, without defining a schema.
To quickly fix this, I would suggest to add some kind of schemas (empty or fake) to your specification, while I fix the OpenAPI parser to take into account also responses without a defined schema.
Hope this helps!
Best,
Davide

Ah okay, that sounds understandable.
That helps me a lot, I will change my OAS. Thank you very much for your efforts!
Best regards
Henning

Thank you!
In the next release, I plan to fix the parser to include responses with empty schemas, and I will include the so-called SpecificationStatusCodeOracle.
Davude


Conflict with tap-i18n-db collection

Hi, trying to use helper with tap-i18n-db collection and got this error:
Uncaught Error: [Can't apply helpers to 'meals' a transform function already exists!]

Any ways to make them compatible?

Hey @Kostanos which package is applying the transform function?

I opened the pull request with fix to this issue. #47
The package is: https://github.com/TAPevents/tap-i18n-db
I'm sure there are many other like this.


[Backend Configuration VIa] Removal of H5DataIO for ecephys

@h-mayorquin How do you think we should handle testing for this? Aside from removal of the current tests related to compression through those tools

Yes, I think just removing them. We already have tests for this on the test of the configurations, right?

@h-mayorquin The integration level tests via the interfaces and converters are the way those specific behaviors get tested

It seems that I need to take a look at the current tests again then. Let me take a look.

And by 'tested' I mean 'succeeds without error'
The unit tests for a dataset configuration stuff is what ensures the actual specification of a configuration ends up configuring the dataset on disk correctly

This is now ready I think

@h-mayorquin This one is independent of the docs PR and should be a quick and easy one to take a look at

Good catch, modified the base interfaces
Technically everything still would have worked, just would have thrown the warning
IDK about the test, all the interfaces are already tested in that way now due to the autoconfigured default backend

IDK about the test, all the interfaces are already tested in that way now due to the autoconfigured default backend

In the light of the discussion here:
https://github.com/catalystneuro/neuroconv/pull/802#discussion_r1589694694
I wouldl ike to add a test to see if buffer_shape is correctly propagated.

That's a separate (and more general) test of any backend configuration though
And this PR is only about removing compression method and options

That's a separate (and more general) test of any backend configuration though
And this PR is only about removing compression method and options

Are we testing this somwere else now? That the buffer shape is propagated to an object that is wrapped already?

Albeit indirectly in https://github.com/catalystneuro/neuroconv/blob/main/tests/test_minimal/test_tools/test_backend_and_dataset_configuration/test_helpers/test_configure_backend_overrides.py#L45-L46, yes - because the alteration to the chunk shape would otherwise throw off the previous buffer shape
We can enhance and further specify this aspect in the follow-up that adds automatic wrapping I think


A more formal Flutter tree health/gardener process

As we merge flutter/engine and flutter/flutter, we'll likely need to rethink our various "build health" rotations (i.e. Flutter Engine Sheriff, Flutter Tree Gardener), not immediately perhaps, but soon (TM), as there will be a single source of build and build health issues instead of split across two trees/repositories.
Here are some ideas in the back of my head, I'd be happy to be involved or help organize:

Formal hand-off doc that is updated at least once a week (as rotations change) with what happened
One merged rotation with a primary and a secondary (instead of two rotations with only a primary)
More clear guidance on how time is expected to be spent during the rotation (i.e. little/no core work)
More clear guidance on working hours/core hours (if someone helps fix the tree at 2am PST but is unavailable at 10am PST it sort of defeats the purpose of the rotation)

If this is staffed by only Googlers and we really wanted to be serious about it, we could also look at oncall tiers.


Can’t fetch data

Description
I use App Router and client Side components instead of getting json from file I tried to make api request to my server but it didn’t work it says x not found
Mandatory reproduction URL (CodeSandbox or GitHub repository)
Don’t have
Reproduction description
Steps to reproduce:

Open reproduction
Click on …
See error: …

Expected behaviour
Fetch data success and display

Closing since the issue template was ignored and this is a usage question, not a bug report.


Bluetooth, host: API to expose local controller version & manufacturer info to application

Now one can print local controller and HCI info using BT_INFO, originating from https://github.com/zephyrproject-rtos/zephyr/blob/45a693a2a92412c8677cae9c3111bb4369272f42/subsys/bluetooth/host/hci_core.c#L3081
This is good, but it is desirable to have this information available to the application trough an API.
Something similar to bt_dev_get_info() which returns bt_dev as a pointer, or it could be more specific, returning one of the
hci_version;
lmp_version;
hci_revision;
lmp_subversion;
manufacturer;

Parameters.

FYI @Emil-Gydesen-Bose

Alternative: The app can run BT_HCI_OP_READ_LOCAL_VERSION_INFO.


Suspiciously large OR job cut located in MN

company
postal_code
jobs
hash_id
location
date

NORTHWEST AIRLINES
OR
27500
50e28021cc053807ecdeaac24862150a3bb0bddc24b25c43d2832a96
ST. PAUL, MN
1998-08-11T00:00:00.000Z

Yeah, I think this is a nationwide figure. Same as United in NJ (reported as Chicago). Wonder if other parts of show up in other states.


[BUG] Cypress intercept always failing on "No request ever ocurred" for Security Analytics CI run

What is the bug?
When the cypress tests are run for Security Analytics the tests always fail to intercept the API calls in the before all hook and end up failing fast for all the specs.
As seen in the test runs for the PRs #1104 and #1160 (e.g. https://github.com/opensearch-project/opensearch-dashboards-functional-test/actions/runs/8367009816/job/22908488244?pr=1160)
However, the tests always pass on the Security Analytics repo's CI runs as well as during release candidate testing.
What is the expected behavior?
Need to investigate why the API calls are not being made so that the tests can run.

#1311 as well.


[Feature]: Un-randomize select test cases

🚀 Feature Proposal
describe.series (name TBD) - An option to enable running test cases in the order they appear, despite the --randomize flag being set. In this specific implementation of the proposal, it'd be in the form of a describe block which would wrap any number of test cases effectively disabling the randomize flag for the contents.
It could also be in the form of test.series or a jest.setRandomize(false).

For completeness, it'd probably make sense for this feature to be accompanied with a describe.randomize to enable a granular opt-in for those who want tests to be synchronous by default except in certain cases.
Motivation
The new --randomize flag is a great default, but some test cases cannot or should not be randomized. A good example is when there's global state which is persisted between tests and the order of the test cases is intentional. Having the ability to define a series of tests to run in the order they appear, despite the randomize flag being set, would enable this customization.
Example
// These tests are run in the order they appear, regardless if the `--randomize` flag is set
describe.series(() => {
    let lastTest = 0;
    test("1", () => {
        expect(lastTest).toBe(0);
        lastTest = 1;
    });
    test("2", () => {
        expect(lastTest).toBe(1);
        lastTest = 2;
    });
    test("3", () => {
        expect(lastTest).toBe(2);
        lastTest = 3;
    });
});

Pitch
Currently --randomize is all or nothing. It's set at the config level so we cannot customize it more granularly. It's difficult to use it when 1% of our tests depend on execution order which requires us to either rearchitect the tests (adds a lot of code) or not use randomize at all. This makes the new feature much more usable for a wide range of people.

Not stale

Not stale

Not stale

Not stale

I agree it is all or nothing and that blocks many existing projects.
I definitely should have run it past more people at work with older codebases as they're asking for something similar.
I'm not sure if describe.series and describe.randomize is the best option. I'll take a look anyway and see how people feel.

Current inelegant solution is to create two jest configurations. One for the order dependent tests and another for the randomized tests.

Perhaps, you can add @serial to the names of tests you want to filter out and use -t flag somehow? Docs: https://jestjs.io/docs/cli#--testnamepatternregex

Hey @CreativeTechGuy to give an update I'm trying out mrazauzskas' suggestion before trying to change things in Jest.
To help identify the order dependent tests I wrote a patch for the --randomize feature. This works with patch-package.
> cat patches/jest-circus+29.7.0.patch

diff --git a/node_modules/jest-circus/build/shuffleArray.js b/node_modules/jest-circus/build/shuffleArray.js
index cc9d442..c7f799f 100644
--- a/node_modules/jest-circus/build/shuffleArray.js
+++ b/node_modules/jest-circus/build/shuffleArray.js
@@ -24,6 +24,7 @@ const rngBuilder = seed => {
 };

 // Fisher-Yates shuffle
+// Reverse order of array (No longer shuffles)
 // This is performed in-place
 exports.rngBuilder = rngBuilder;
 function shuffleArray(array, random) {
@@ -31,8 +32,8 @@ function shuffleArray(array, random) {
   if (length === 0) {
     return [];
   }
-  for (let i = 0; i < length; i++) {
-    const n = random.next(i, length - 1);
+  for (let i = 0; i < length/2; i++) {
+    const n = length - 1 - i;
     const value = array[i];
     array[i] = array[n];
     array[n] = value;

The above reverses the order of the tests completely instead of randomizing them.
We have 14,000 test suites in our monorepo and at least 500 are failing. It will be a grind to add exceptions for these 500, I'm thinking how to do this more easily.

Not stale

Not stale

Merry Christmas and Happy Holidays. Still not stale...

Still not stale (Happy new year)

Hey @CreativeTechGuy apologies it's been so long. I was unable to get enough support on the two configurations system at work. (Before you ask, the describe.serial was a no-go either)
Have you tried the two configuration system yourself? What were the pain points?

@Joshua-Hwang I guess this issue can be closed then if it's been rejected.

Have you tried the two configuration system yourself? What were the pain points?

Having multiple configs for different files is difficult to do when configs are shared via an organization via centrally managed libraries. It's nice to have everything "just work" and then give fine-grained tuning capabilities within a specific team's files.
And just to clarify, are you a Jest maintainer/owner?

I'm neither but I did work on the randomize feature.
I'm not sure how easy it would be in your case.
We have global configurations for eslint and tsconfig but each team extends this base config for their use cases. Could the same be done with the jest config?
Create two configurations, one for the tests that can be randomized and a special configuration that runs specific *.serial.test.ts files?

Got it. Thank you for the reply. I guess I'll close this issue.


feat(cc): implement Thermostat Fan State CC

This is a draft implementation of the Thermostat Fan State CC and a basic set of tests.  Not yet tested on real hardware.

Thank you! We should see if this works soon :)


Genrate Dependency Graph from CMake

Retrieve information about tools to generate a dependency graph from the CMake Configuration Files.

Info: CMake GraphViz Option

# IMPORTANT: otherwise project root directory flooded with temp files
mdkir depGraph && cd depGraph

# generate dot files
cmake -S .. -graphviz=enV5.dot

# convert to png file
dot -T png -o enV5.<target>.png enV5.dot.<target>

Add graph generation as target to CMake!!

With the given graphviz options it was not possible to generate a dependency graph without the enormous dependencies inside the external libraries. However, a workaround with multiple regex replacements is functioning.


Cannot search and view symbols in outline that are inside export default object

VSCode Version: 1.43.2 (0ba0ca52957102ca3527cf479571617f0de6ed50, 2020-03-24T07:52:11.516Z)
OS Version: Linux x64 5.3.0-45-generic (Ubuntu 19.10)

Steps to Reproduce:

Create JS file with content:

export default {
  foo: 1,
};
export const hello = {
  world: 2,
};

The code outline and symbol search (Ctrl+Alt+O) will show: default, hello, world (nested), while it should (as in previous VSCode versions): default, foo (nested), hello, world (nested) - foo is missing, as well as other symbols if they were put inside default symbol.

Does this issue occur when all extensions are disabled?: Yes

Opened https://github.com/microsoft/TypeScript/issues/37877 to track upstream


corerad: 0.3.2 -> 0.3.3

Signed-off-by: Matt Layher<EMAIL_ADDRESS>
Motivation for this change
New minor release.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Builds and runs, tests pass:
$ ./result/bin/corerad -h
CoreRAD v0.3.3 (2021-07-20)
flags:
  -c string
        path to configuration file (default "corerad.toml")
  -init
        write out a minimal configuration file to "corerad.toml" and exit

/cc @hugolgst @prusnak @SuperSandro2000 (thanks for reviews on my previous PRs!)

@GrahamcOfBorg test corerad

/marvin opt-in

/status needs_reviewer

Result of nixpkgs-review pr 130850 run on x86_64-linux 1

1 package built:

corerad


Feature/image rotation

Description

Image rotation feature implemented in image widget.
Fixes # (#2751)

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ]  I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ]  I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/image-rotation

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
53.33 (-0.02)
35.37 (0)
31.96 (-0.02)
53.86 (-0.02)

:red_circle:
app/client/src/components/designSystems/appsmith/ImageComponent.tsx
22.06 (-5.02)
18.87 (3.49)
10 (-3.33)
22.58 (-4.69)

/ok-to-test sha=6b8102b

/ok-to-test sha=25931cd

Rr-running all jobs. Unrelated tests are always failing!

Observed that if zoom is set and rotation is enabled in property pane then I am not able to zoom the image in both edit and deployed mode.
cc: @somangshu @momcilo-appsmith

Observed that if zoom is set and rotation is enabled in the property pane then I am not able to zoom the image in both edit and deployed mode.

@techbhavin for this we need to enable zoom functionality on the overlay in case the rotation property is enabled.

@areyabhishek need some help here, The problem is that when the rotate feature is enabled, we cannot access the zoom functionality. We wanted to enable the zoom feature in click on the the overlay, the problem is

bad UX
difficult Implementation

Can you give us a solution from the design point of view

@techbhavin here are the new design. Kindly let me know if you have any queries about the implementation/design.

/ok-to-test sha=a6a351d

/ok-to-test sha=5e1de7a

the document is also updated in appsmith-doc-pr-163.
@marks0351

Fixed #5337

@techbhavin Few issue with dragging the image after zoom is enabled.

Able to drag the image out of the image widget
Edit mode - > https://www.loom.com/share/6fc5fd73f01243f68ffe1849df72221f
Deployed mode - > https://www.loom.com/share/b716fd573a1a4488bdefa500d477cb0f

@vivekverma2312 the issue you are pointing out is with the zoom functionality and not related to this. Suggest we create new issues for that.
@techbhavin please resolve the conflict
@SatishGandham Kindly review changes.

@techbhavin Rotation is working fine in deploy preview.

fixed #5155

Rerunning failed tests


Move community files from withastro/astro

This PR copies over community health files from withastro/astro so that they apply to all repos across the GitHub org.
I’ve left CONTRIBUTING.md and STYLE_GUIDE.md in place as those are repo-specific, but:

Language Tools and the Prettier plugin do also link to the style guide, so we coud also move that if people prefer?
In the future, we could consider an org-wide CONTRIBUTING.md at some point if we think there are common things we want to ensure show up in all repos.

@ran-dall were you able to get any insight on how consolidating these files in this repo impacts our OpenSSF scorecard?

@natemoo-re Theoretically, it should, for Best Practices. I'm not sure about Scorecard, however, let me investigate and I'll update you guys shortly.

@natemoo-re I just tested it and confirmed. Yes, these can be moved over, without any effect on Scorecard (or Best Practices).


Get current command

Is there a good way to get the current command?
For example, on executing dep deploy:info -p I'd like to get the value "deploy:info".
On executing dep dump -p I get "Command "dump" is not defined.", which is fine.
"Do you want to run "config:dump" instead?  (yes/no) [no]:" yes, I type "yes". Here of course I'd like to get the corrected value "config:dump" instead of "dump". (all after "dep init" with defaults)
Is there a way?

Yes, via arguments.

Ah, thanks. Sure, I can do input()->getArgument('command') in a task. But there are two issues with that:
First, I'd like to get the command in the main script (not within a task) to configure some things which need to be done before the tasks run. But there is yet not Context object, so input() does not work (I know I could use multiple Deployer files and dep -f deploy-1.php, but still…).
Second, in parallel mode, when I retrieve the command as shown above in a task, the command is "worker" instead of the real command.

I am cleaning up on issues. Fill free to reopen if needed.
Also, we have a new section available: discussions.


Don't allow duplicate fields on datasets

Coverage increased (+0.01%) to 91.036% when pulling ab0d9cb6b2e6ffb8ae48ea02b3884f091f2518df on gl3nn:no-duplicate-fields into 2a3bbec8419c04a0eacb6b03d8271abaccc0c58c on kayak:master.


Firebase and FirebaseAdmin use different interfaces

The code I'm testing is like this:
const app = admin.initializeApp();
const mockAdminApp = exposeMockFirebaseAdminApp(app);
const mockFirestore = mockAdminApp.firestore();
mockFirestore.runTransaction(async (transaction) => {
    const query = collection.where("uploaded_at", ">", 0);
    return await transaction.get(query)
});

The problem here is transaction.get().
In Firebase Node.Js SDK, Transaction.get could only accept DocumentReference which means you could only fetch one doc at a time:
https://firebase.google.com/docs/reference/node/firebase.firestore.Transaction#get
However, in FirebaseAdmin Transaction is a type alias to @google-cloud/firestore:
https://firebase.google.com/docs/reference/admin/node/admin.firestore
Where Transaction.get accepts DocumentReference or Query:
https://googleapis.dev/nodejs/firestore/latest/Transaction.html#get
This means I could query multiple documents in one shot.
But in ts-mock-firebase, it seems like firebase and firebase-admin are treated no differently.
And my code doesn't return documents that match the condition.
Is it a known issue? Any plan for a fix? If not, any advise for a workaround?
Thanks!

Thanks @ranmocy for telling me about this! And I am sorry for the delay with my answering. I've been in a vacation. :)
Currently these are working in a same manner. I will put this on my list to fix this.


Tweak Oauth App org restriction docs

This PR tweaks the trigger for warn_oauth_restricted error handler
to reflect upstream changes (ideally they'd give us an HTTP header, but
alas). It also adds a note to the onboarding docs to make the workaround
explicit.
Critical Changes
Changes
Issues Closed

github actions seems stuck. I'm going to bypass branch protection to merge this, since the builds already passed and it's not touching code.


IML bugreport Error when trying to create a filesystem from the GUI using a custom profile

Describe the bug
I'm unable to create a new file system from the UI using a custom server profile. The profile is very similar to the default "base_managed_rh7" profile, but with corosync and pacemaker disabled (the intention is to disable HA).
Here's the profile:
{
  "ui_name": "Managed Storage Server, no HA",
  "managed": true,
  "worker": false,
  "name": "base_managed_rh7_no_ha",
  "initial_state": "managed",
  "ntp": true,
  "corosync": false,
  "corosync2": false,
  "pacemaker": false,
  "ui_description": "A storage server suitable for creating filesystem targets",
  "packages": [
    "python2-iml-agent-management",
    "kernel-devel-lustre",
    "lustre-ldiskfs-zfs"
  ],
  "repolist": [
    "base",
    "lustre-server"
  ],
  "validation": [
    {
      "description": "The profile is designed for version 7 of EL",
      "test": "distro_version < 8 and distro_version >= 7"
    }
  ]
}

To Reproduce
Steps to reproduce the behavior:

Go to the servers page.
Click on "Add More Servers",
Add and configure three servers, using a custom profile (the profile is shown above)
Go to the file systems page, and click on create file system.
Click on "create file system".
Configure the file system according to the screenshot below.
Click on the "Create file system" button
See error shown on the screenshot below

I'm listing some logs on the logs section below.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Here's my filesystem config:

Here's the error I get in the browser:

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 83.0.4103.116

Version
What version of IML?
5.1.0
What Operating System?
RHEL
What Operating System version?
7.6
Logs
(click to expand)
job_scheduler.log

[2020-07-01 11:17:25,418: INFO/job_scheduler] Job 237 completing (errored=False, cancelled=False)
[2020-07-01 11:17:25,554: INFO/job_scheduler] run_next: 1 runnable jobs of (1 pending, 0 tasked)
[2020-07-01 11:17:25,640: INFO/job_scheduler] Job 238: RunJobThread.run
[2020-07-01 11:17:25,641: INFO/job] invoke_agent on agent mgs-1 initialise_block_device_drivers {}
[2020-07-01 11:17:25,711: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger._complete: starting wait for rpc e15d23d4-9ff5-4cc6-a3ca-006cf2a20931
[2020-07-01 11:17:25,711: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger._complete: starting wait for rpc e15d23d4-9ff5-4cc6-a3ca-006cf2a20931
[2020-07-01 11:17:25,814: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger.on_rx: mgs-1/7437f3c9-1300-4135-ade3-d0ff83e036b1
[2020-07-01 11:17:25,814: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger.on_rx: mgs-1/7437f3c9-1300-4135-ade3-d0ff83e036b1
[2020-07-01 11:17:25,815: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger.on_rx: good session mgs-1/7437f3c9-1300-4135-ade3-d0ff83e036b1
[2020-07-01 11:17:25,815: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger.on_rx: good session mgs-1/7437f3c9-1300-4135-ade3-d0ff83e036b1
[2020-07-01 11:17:25,815: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger.on_rx: completing rpc e15d23d4-9ff5-4cc6-a3ca-006cf2a20931
[2020-07-01 11:17:25,815: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger.on_rx: completing rpc e15d23d4-9ff5-4cc6-a3ca-006cf2a20931
[2020-07-01 11:17:25,839: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger._complete: completed wait for rpc e15d23d4-9ff5-4cc6-a3ca-006cf2a20931
[2020-07-01 11:17:25,839: INFO/chroma_core.services.job_scheduler.agent_rpc] AgentRpcMessenger._complete: completed wait for rpc e15d23d4-9ff5-4cc6-a3ca-006cf2a20931
[2020-07-01 11:17:25,840: INFO/job_scheduler] Job 238 finished 1 steps successfully
[2020-07-01 11:17:25,881: INFO/job] StatefulObject.set_state mgs-1 unconfigured->managed (intentional=True)<PHONE_NUMBER>89904
[2020-07-01 11:17:25,885: INFO/job] Job 238: StateChangeJob complete, setting state managed on mgs-1
[2020-07-01 11:17:25,885: INFO/job] Job 238: not_deleted=True
[2020-07-01 11:17:25,885: INFO/job_scheduler] Job 238: complete_job: Updating cache
[2020-07-01 11:17:25,885: INFO/job] Job 238: StateChangeJob complete, setting state managed on mgs-1
[2020-07-01 11:17:25,885: INFO/job] Job 238: not_deleted=True
[2020-07-01 11:17:25,885: INFO/job_scheduler] Job 238: complete_job: Updating cache
[2020-07-01 11:17:25,885: INFO/job_scheduler] Job 238: locked_item<PHONE_NUMBER>89904 <class 'chroma_core.models.host.ManagedHost'> True True
[2020-07-01 11:17:25,888: INFO/job_scheduler] Job 238 completing (errored=False, cancelled=False)
[2020-07-01 11:17:26,185: INFO/job_scheduler] Replaying 2 buffered notifications for ManagedHost-12
[2020-07-01 11:17:26,216: INFO/job_scheduler] _notify: Updating .immutable_state of item 12 (mgs-1) from True to False
[2020-07-01 11:17:26,216: INFO/job_scheduler] _notify: Set immutable_state=False on mgs-1 (ManagedHost-12) and saved
[2020-07-01 11:17:26,230: INFO/job_scheduler] run_next: 0 runnable jobs of (0 pending, 0 tasked)
[2020-07-01 11:37:52,228: ERROR/rpc] RunOneRpc: exception calling create_filesystem: Traceback (most recent call last):

  File "/usr/share/chroma-manager/chroma_core/services/rpc.py", line 107, in run
    "result": self.rpc._local_call(self.body["method"], *self.body["args"], **self.body["kwargs"]),

  File "/usr/share/chroma-manager/chroma_core/services/rpc.py", line 622, in _local_call
    return fn(*args, **kwargs)

  File "/usr/share/chroma-manager/chroma_core/services/job_scheduler/job_scheduler.py", line 1213, in create_filesystem
    mgt_data["volume_id"], reformat=mgt_data.get("reformat", False), **_target_kwargs(mgt_data)

  File "/usr/share/chroma-manager/chroma_core/models/target.py", line 340, in create_for_volume
    stonith_not_enabled = (

AttributeError: 'NoneType' object has no attribute 'id'

http.log
[2020-07-01 11:08:53,094: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux_network/bd20558f-1a9e-4cc0-8634-2a716af8f617 to create new one
[2020-07-01 11:08:53,094: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux/b27bf275-eb09-4b25-b3db-cee56ef63292 to create new one
[2020-07-01 11:08:53,094: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux/b27bf275-eb09-4b25-b3db-cee56ef63292 to create new one
[2020-07-01 11:08:53,094: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/action_runner/58c3a20b-5d6e-4ef7-89f2-a028742ddf33 to create new one
[2020-07-01 11:08:53,094: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/action_runner/58c3a20b-5d6e-4ef7-89f2-a028742ddf33 to create new one
[2020-07-01 11:08:53,095: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/systemd_journal/daddb397-f4a5-4f30-8adb-8a40441c8b6c to create new one
[2020-07-01 11:08:53,095: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/systemd_journal/daddb397-f4a5-4f30-8adb-8a40441c8b6c to create new one
[2020-07-01 11:12:01,831: WARNING/http_agent_host_state] Agent restart on server mgs-1 at 2020-07-01 11:12:01.393699+00:00
[2020-07-01 11:12:01,864: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/lustre/d5cb96e4-cddd-4f0f-8edc-4b2661152722 to create new one
[2020-07-01 11:12:01,864: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/lustre/d5cb96e4-cddd-4f0f-8edc-4b2661152722 to create new one
[2020-07-01 11:12:01,864: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/systemd_journal/364ab6df-5ca7-4b5d-8d6a-73b1e4a25f2d to create new one
[2020-07-01 11:12:01,864: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/systemd_journal/364ab6df-5ca7-4b5d-8d6a-73b1e4a25f2d to create new one
[2020-07-01 11:12:01,865: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/corosync/043b03d1-c9de-46be-8f57-f9d446131a5e to create new one
[2020-07-01 11:12:01,865: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/corosync/043b03d1-c9de-46be-8f57-f9d446131a5e to create new one
[2020-07-01 11:12:01,865: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux_network/e60dd04a-0487-477c-83c5-6f9de57a6a42 to create new one
[2020-07-01 11:12:01,865: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux_network/e60dd04a-0487-477c-83c5-6f9de57a6a42 to create new one
[2020-07-01 11:12:01,865: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/action_runner/ea99b7f0-ac39-47ac-ab1d-307d544570b8 to create new one
[2020-07-01 11:12:01,865: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/action_runner/ea99b7f0-ac39-47ac-ab1d-307d544570b8 to create new one
[2020-07-01 11:12:01,866: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux/71546456-4715-48d3-8cc1-776693260b06 to create new one
[2020-07-01 11:12:01,866: WARNING/chroma_core.services.http_agent.sessions] Destroying session mgs-1/linux/71546456-4715-48d3-8cc1-776693260b06 to create new one
[2020-07-01 11:12:01,877: WARNING/agent_views] Cancelling GET due to barrier 2020-07-01T11:12:01.393699+00:00Z 2020-07-01T11:08:52.911680+00:00Z
...skipping...
do          domainname  done
[2020-06-30 10:41:26,218: ERROR/rpc] ServiceRpcInterface._call: exception 'NoneType' object has no attribute 'id': AttributeError       traceback: Traceback (most recent call last):

  File "/usr/share/chroma-manager/chroma_core/services/rpc.py", line 107, in run
    "result": self.rpc._local_call(self.body["method"], *self.body["args"], **self.body["kwargs"]),

  File "/usr/share/chroma-manager/chroma_core/services/rpc.py", line 622, in _local_call
    return fn(*args, **kwargs)

  File "/usr/share/chroma-manager/chroma_core/services/job_scheduler/job_scheduler.py", line 1213, in create_filesystem
    mgt_data["volume_id"], reformat=mgt_data.get("reformat", False), **_target_kwargs(mgt_data)

  File "/usr/share/chroma-manager/chroma_core/models/target.py", line 339, in create_for_volume
    len(StonithNotEnabledAlert.filter_by_item_id(corosync_configuration.__class__, corosync_configuration.id))

AttributeError: 'NoneType' object has no attribute 'id'

sosreport
Attach any sosreports for nodes relevant to this issue.

This currently won't work. I'd suggest using a monitored profile if you'd like to work with a filesystem without HA.

@jgrund thank you for the quick response.


Odd ordering of beforeSave Hook

It seems odd to me that you would run your beforeSave hook before the validations, for instance I was working on a User model where I encrypted the password so I wanted to validate the plain text password before I did the encryption in the before save hook.
This is my only example really, and I am willing to accept an argument for it, but it is my opinion that the beforeSave hook should be done after the validations.

Your point is valid and makes perfect sense, I'll switch it.


Redirect /docs/ to /en/docs/

Fixes #3602
Not sure this is the way to go, and I can't really test it since it's at the S3 level, but maybe @samwgoldman can tell whether it's correct.

lgtm! Thanks!

doesn't seem to work. neither does the /about/ above it... :/
docs/index.html -> en/docs/ will probably work.

Unfortunately this is hard to test. If you guys have a quicker way of testing it, please go ahead :)


[ENH] Deprecate the alignment module

The alignment module wraps a package called dtw-python which contains an implementation of dtw that is slower than our ours.  The functionality of alignment is available in distances using our own distance functions. The only place it is used is in KNN, which I would like to remove
https://github.com/scikit-time/scikit-time/issues/47
https://github.com/scikit-time/scikit-time/issues/39
and dists_kernels, which I would also like to deprecate. @chrisholder

Use #79


database should use utf8 charset instead of latin1

The PXC database has been configured to use the default latin1 charset.
I'm not sure if this has practical implication, but I think it could affect e.g. using non-latin1 user names in UAA. I have not verified this.
I've found this issue by comparing mysqldump output for the UAA database between an SCF and a kubecf instance, to investigate potential migration issues, e.g.
CREATE TABLE `SPRING_SESSION` (
-  `PRIMARY_ID` char(36) COLLATE utf8_unicode_ci NOT NULL,
+  `PRIMARY_ID` char(36) NOT NULL,
[...]
-) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci ROW_FORMAT=DYNAMIC;
+) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=DYNAMIC;

There are a whole bunch of pxc config settings beyond the character set that pxc-release sets explicitly, but we currently leave at default values:
https://github.com/cloudfoundry-incubator/pxc-release/blob/master/jobs/pxc-mysql/templates/my.cnf.erb
I've created a diff between the pxc-release values (exported from SCF) and the current kubecf settings and uploaded it to https://gist.github.com/jandubois/6f3faf17ed95adefb321c108f08da33a
We need to determine which of those settings we want to update as well, and which we consider inconsequential.

Assigned to @fargozhu to consider adding it to the icebox/backlog. (I thought this assignment was  already done by a bot, or maybe this issue is too old?).


Create issue template - nitric repo, cli and node sdk projects

This is a design exercise, not implementation.
There is already contained in these templates which need review and minor adjustments.

Add a note about requesting the user to run the debug command, and paste the content into the issue.

New copy for the bug report and feature request templates here.
Relies on the new diagnostic command in #155.

Requires a user with access to the 'settings' tab in git to update the issues template.

Test for consistency across all projects.


Add reources management for nodes

This is a duplicated one of #502, PR generated from official repo branch to run all the CI jobs
This PR would set the resource manage for octez nodes and sidecar in the same pod. For bakers, there are no resources management for it however
Users can manage the node resources for octez node placement. Additionally, users can use k8s autoscalers to scale out node pods based on certain criteria
https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale
This scaling mechanism is for pod, so both octez node and sidecar resources should be specified for the pod resource usage to be calculated. For now, pods with bakers running inside is not supported.

@harryttd @orcutt989 all issues resolved, please review again

@nicolasochem @harryttd There are still requested changes on this PR. Please dismiss them if they have been addressed.

I'm reviewing right now


it did not work for me

Make sure the bug can be reproduced in either demo page or a forked codepen page.
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
1.
Expected behavior
A clear and concise description of what you expected to happen.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
it did not work, i click the img, it nothing happen.
i do not how to solve it

finally, it work now

but why the way of the document  is did not work for me

Are you sure you're using .img-zoomable instead of img-zoomable css selector for the document example?


Vote with ATOM

Fixes #142. Fixes #141.
This also enables paying gas in ATOM or STB.
This merge should trigger Dependabot on Stakebot and Stakewatcher.

I can't believe it's this easy... 😂

This assumes the user already has ATOM and STB in their wallet.


Print a redacted form of the DSN to STDERR when we fail to connect to the db

When you can't connect to the db, it's helpful to know exactly which params we were using to attempt the connection.  This info was already being logged at the debug level, but I thought it might be nice to provide the info right away on error (except for the password, for security reasons).
Definitely open to other approaches -- like maybe telling the user how to change the log level in the error or something?  I personally don't know how to change it 😅 .

Jane, your patch looks great.  However, it brought to light a limitation with the current code.  In particular, the DSN string should be created when needed instead of set and forget, in case underlying parameters have changed.
I merged your code into a new working branch to address the dynamic DSN values.  Some changes to your implementation were required.
https://github.com/kcls/evergreen-universe-rs/tree/working/add-dsn-to-db-connection-error

Oh, good point @berick !  The working branch implementation looks good to me.  I also like that it assembles the redacted DSN string in the same manner as the real DSN, rather than the assemble-disassemble-reassemble twisted path in my branch.

Thanks for the eyes and code.  Patches merged.


[BUG] caught IllegalArgumentException if batch size > 4096

Describe the bug
caught IllegalArgumentException if batch size > 4096
To Reproduce
Steps to reproduce the behavior:

create a new topic --- t2
producer message with batch size 5000
./rdkafka_performance -P -t t2 -b <IP_ADDRESS>:9092 -s 128 -a 1 -X batch.num.messages=5000 -c 1000000
consume
./rdkafka_performance -C -t t2 -b <IP_ADDRESS>:9092 -G g2
See error

Expected behavior
consume correctly
Screenshots

it's related to https://github.com/streamnative/kop/issues/175

Since continuous offset is already supported, this issue will no longer happen.

Since continuous offset is already supported, this issue will no longer happen.


custom pattern

hi, how can i use my custom regex and a custom rendering item?

Custom rendering can be accomplished using the renderLink prop which controls how to output each detected link, and of course the style prop to control the overall Text style. Custom regex isn't supported yet (#25), but you can see how the LatLng matcher is implemented here and do something similar. PR's are welcome as I've been really busy and haven't had a chance to work on the custom phone number support as planned.


Error: Cannot find module '@vanilla-extract/css/adapter

Describe the bug
env:nextjs 15
react:18
yarn monorepo workspace
I'm getting this error while i ran the nextjs client server
Reproduction
Error
System Info
Chrome / Mac )S

Used Package Manager
yarn
Logs
No response
Validations

[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

@KwangminNam Please provide a minimal reproduction of your issue. It's very hard to diagnose an issue without any code to run/look at.


Change Tourism contract pack to Tourism Plus

Jenkins is stuck in the past with 1.0.0 so I merge this after manual inspection.


Whitespace after processors= global option causes option to be ignored

Your Windows build number: Microsoft Windows [Version 10.0.18945.1001]
What you're doing and what's happening: Testing the global options feature recently announced.
For the processors option, you cannot have whitespace after the value.
For example, this option will not work:
processors=2            # How many processors to assign to the WSL2 VM.
The memory option, though, has no issue when adding it like this:
memory=3GB              # How much memory to assign to the WSL2 VM.
Removing the whitespace after the processors value, works fine:
processors=2
What's wrong / what should be happening instead:
Amount of processors shown using top should reflect the global option value. Instead it shows that the VM is using all of the available processors on the host.

Thanks, I'll sort this out.

Is this bug still open?

Is this bug still open?


Dropdown on Large and Small Images

Make large image and small image a dropdown instead of a text field having to know the name of the keys much like in DiscordRPCMaker.

great suggestion! I'm gonna try to implement this.

@E-boi Thanks, but I can't seem to deselect it once I have selected one. How do I set the key to none?


Client ID

Hello,
I am using two nodes on Pi Zeros, but one of the nodes gets constant disconnections (socket errors) in Mosquitto / Home Assistant. Is there a way to change Client ID in the node, so I can keep using both nodes?

Hey @CMDR-Sloma,
why would changing client ID improve the issue you are describing? Sounds like a network or system issue to me...
Anyhow, to answer your question, please check:

https://github.com/ThomDietrich/miflora-mqtt-daemon/blob/75519a227c2d325f2bcc6726edbe4c8eeca5e86a/miflora-mqtt-daemon.py#L137
https://www.eclipse.org/paho/index.php?page=clients/python/docs/index.php#client

Well, then I am at a loss. I have few clients and every single one works fine with Mosquitto. However one of the RPi Zeros which run MiFlora gets constant socket errors. Both RPis have identical MiFlora config. Only one of them works the other one gets dropped after 5-6 seconds each time it logs in. Originally, I asked on HA forums because to me Mosquitto is quite 'cryptic' when it comes to finding why I get socket errors in the first place. Because I use the same user & password for both MiFlora nodes suggestion was one client gets dropped because Mosquitto doesn't like having two clients with the same ID. Whether that's the case I am not sure.
Anyway... Thank you, I will give it a try and see if this solves the issue.

OK, that's definitely not it... However, now I know it is something with MiFlora config and not the connection issue:

This node has exactly the same config as other Pi and yet this one throws out the above error and runs an endless restart loop.
Here is a sensor config section from both Pis side by side:


[Bug]: Git commands pass null in Obsidian, works fine via command line

Describe the bug
When using the commands in the Obsidian UI, nothing works. It's passing null to the command. The remote origin URL and the default branch of master are both set.
Git Pull using Obsidian Git:

Git Pull via terminal:
MINGW64 ~/Desktop/Vaults/Programming (master)
$ git pull origin master
From https://github.com/username/vault-repo
 * branch            master     -> FETCH_HEAD
Already up to date.

Relevant errors (if available)
git obsidian error: null
fatal: ambiguous argument 'null': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

plugin:obsidian-git:10679 Uncaught (in promise) Error: null
fatal: ambiguous argument 'null': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

    at Object.action (plugin:obsidian-git:10679:25)
    at PluginStore.exec (plugin:obsidian-git:10704:25)
    at eval (plugin:obsidian-git:8499:43)
    at new Promise (<anonymous>)
    at GitExecutorChain.handleTaskData (plugin:obsidian-git:8497:16)
    at GitExecutorChain.eval (plugin:obsidian-git:8481:44)
    at Generator.next (<anonymous>)
    at fulfilled (plugin:obsidian-git:7333:24)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Steps to reproduce

Create a repository on GitHub
Create new vault
Install Obsidian Git and enable
Set remote origin to GitHub repo URL
Try any command in Obsidian Git (like pulling the repo)
Try any command in terminal shell

Expected Behavior
Obsidian Git should behave the same as running commands in terminal.
Addition context
Output of git branch info in terminal
$ git branch -a
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master

Operating system
Windows
Plugin version
1.26.1

Does the same happen for stage/commit? Or only for pull?

Tried other commands, Issue was happening because there wasn't an upstream set. git branch --set-upstream-to origin/master fixed it.
Wouldn't have known if if the Obsidian Git Push command error didn't tell me no upstream was set, since git pull just gave the null error.


BitBar 1.10.1 does no longer execute shell scripts

After updating from 1.9.2 to 1.10.1, my shell scripts are no longer executed.
Here's the content of HTTPS_Port_Status.1m.sh that I put in /usr/local/etc/BitBar/ directory:
#!/bin/bash

if [[ "8118" = $(networksetup -getsecurewebproxy "Thunderbolt Ethernet" | grep -Eo "[0-9]{4}") ]]
  then
  echo "🔒 TLS | color=red"; echo "---"; echo "Filter encrypted requests… | color=green bash=/Users/$USER/bin/PORTS2PROX.sh"
else
  echo -e "\b"
fi

Content of PORTS2PROX.sh file:
#!/bin/bash
sudo networksetup -setwebproxy       "Thunderbolt Ethernet" <IP_ADDRESS> 8118
sudo networksetup -setsecurewebproxy "Thunderbolt Ethernet" <IP_ADDRESS> 8079
exit 0

BitBar 1.9.2 was able to execute my scripts. I thus reverted back to 1.9.2.

Possible duplicate of https://github.com/matryer/bitbar/issues/596.

Possible duplicate of https://github.com/matryer/bitbar/issues/596.

Closing, as it's a duplicate.

Closing, as it's a duplicate.


Wrong seconds under mainloop

https://github.com/Barbosik/MultiOgar/blob/master/src/GameServer.js#L687
It states the loop is to run per 30 seconds in the comment under it, but based on my math 250 ticks is actually 10 seconds. I ran it and tested my theory and I was write, the script runs every 10 seconds. Either the comment is wrong or the formula is wrong. 👍
Also one more thing, why did you guys do 10000 / 40? Why didn't you just put it as 250. It didn't affect anything when I tested it out. You're pretty much just adding an extra equation that doesn't matter much in that anyways :)

rip this issue lol

It's okay, bud.


Add tableOptions for DataLakeSuiteMixin

Add create table options for DataLakeSuiteMixin
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @pan3793 @yanghua

Have a second thought on it, I change my mind now, because it seems that tableOptions is not a common field for DDL, as we create several tables in different methods using different options.
But as we disscue before, it's valuable to set hoodie.bootstrap.index.class=org.apache.hudi.common.bootstrap.index.NoOpBootstrapIndex for hudi tables.
@simon824 Sorry for making you back and forth.

Codecov Report

Merging #1040 (8b3b4b8) into master (c328c88) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 8b3b4b8 differs from pull request most recent head f6d3742. Consider uploading reports for the commit f6d3742 to get more accurate results

@@             Coverage Diff              @@
##             master    #1040      +/-   ##
============================================
+ Coverage     78.42%   78.43%   +0.01%
  Complexity       61       61
============================================
  Files           167      167
  Lines          6196     6196
  Branches        723      723
============================================
+ Hits           4859     4860       +1
+ Misses          915      914       -1
  Partials        422      422

Impacted Files
Coverage Δ

.../scala/org/apache/kyuubi/server/KyuubiServer.scala
58.69% <0.00%> (+2.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347c932...f6d3742. Read the comment docs.

Have a second thought on it, I change my mind now, because it seems that tableOptions is not a common field for DDL, as we create several tables in different methods using different options.
But as we disscue before, it's valuable to set hoodie.bootstrap.index.class=org.apache.hudi.common.bootstrap.index.NoOpBootstrapIndex for hudi tables.
@simon824 Sorry for making you back and forth.

what about separate common config like hoodie.bootstrap.index.class  and custom config like primaryKey?
https://github.com/apache/incubator-kyuubi/pull/1040/files#diff-98f5ef031c8c38b4be598220eaa8c0f8c23522b32fa8c63fdcf71e46f44a9dacR42-R52

Thanks, merging to master


Bug: Pass/Failure Condition is not working as expected in pre build step.

📜 Description

During the Set failure condition for combination of multiple variables , here we are doing AND operation across all conditions but it should be OR
During the Set pass conditions for combination of multiple variables here we are doing OR operation across all conditions but it should be AND

Exporting the value of x and y variables .

Set failure condition.

Here build should fail but here it tigger the build stage.

👟 Reproduction steps

Create a Devtron app .
Go into pre build stage and add below script .#!/bin/sh  set -eo pipefail  #set -v  ## uncomment this to debug the script  export x=2 export y=0 echo "The value of x and y are $x, $y"
Set output variables for x and y as number.
Set failure condition for x and y as shown in screenshot and trigger the build.

👍 Expected behavior
It should block the build stage.
👎 Actual Behavior
Right now it tigger the build stage.
☸ Kubernetes version
1.23
Cloud provider

AWS

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#3948

This is fixed with #3938


No longer working in newer versions of Studio?

Source: https://forum.thegamecreators.com/thread/228925
"I use Adambiser's Steam Plugin and it's always worked perfectly. However, on AGK's latest couple of updates it seems to have broken and attempting to run my app brings up an error message. After puzzling it over, I realised I could restore it back to working by rolling back to Studio version 2022.09.26. That's what I've done for now, but I'm wondering if anyone has managed to get it to work with the newer versions of AppGameKit?"

Seems to be an installation issue that sometimes removed plugins from the AppGameKit Studio\Plugins folder


Fix CD

Because of a missing schema definition (sftp), aim is currently using a hard fork of rust-url.
This means cargo publish will fail in the CD pipeline, because we cannot publish a crate that relies on git deps.
This PR tried to contribute changes upstream but got closed.
url-parse, once reaching maturity, will be able to unblock the blocked pipeline.

CD pipeline green, badge displayed as red incorrectly.
Issue reported.


Component denylist

This PR adds the ability to create a denylist that forbids loading certain types of components. This is passed as an environmental variable (for the daprd container) called DENY_COMPONENTS.
The denylist is a comma-spearated list of component identifiers. For example:
DENY_COMPONENTS="bindings.smtp,bindings.kubernetes"

Disables the "bindings.smtp" and "bindings.kubernetes" components. It's possible to specify a version too, to disable that version only (if the version is not specified, all versions are disabled):
DENY_COMPONENTS="bindings.kubernetes/v1"

The goal is being able to disable certain components from being instantiated. This issue fixes https://github.com/dapr/dapr/issues/4692 although it is done in a much softer way, including a denylist only and using env vars instead of annotations. Additionally, it prevents components from being loaded, but does not prevent them from being registered.

Please change the PR to use Configuration CRD instead of an env var. It's more explicit and will allow extensibility.

Also, let's wait with merging until https://github.com/dapr/dapr/pull/4808 is in as there will likely be a merge conflict.

Closing this in favor of #4946 which uses the configuration CRD.


Useraudit and Custom User model

I stumbled upon useraudit and I've been enjoying using it. However, for this project, I had to implement a custom user model - extending AbstractBaseUser.
Rather than having a "username", this project requires a "phone_number" as the username, and this leads to useraudit not displaying anything in the username field (in admin), and not having any value stored for username in the db.
Is there a work around for this situation? I'm running Django 1.10.4
Regards,

Hi,
Currently, that isn't supported.
Would setting up an alias property be acceptable for you?
class YourCustomUser(AbstractBaseUser):
    ...
    @property
    def username(self):
        return self.phone_number
    ...

I think that should work, please let us know if there are any problems with it.
Cheers,
Tamas

Closing this as it is pretty old now.


Add missing derives for Algorithm

I require this for the following scenario, porting some C logic into Rust. It attempts to find the greatest possible checksum for an array of possible checksums, starting with SHA512 and gradually downgrading to SHA1.
const ALGORITHMS: &[Algorithm] = &[Algorithm::SHA512, Algorithm::SHA256, Algorithm::SHA1];

/// Based on libfwupd/fwupd-common.c
pub fn checksum_guess_kind(checksum: &str) -> Algorithm {
    match checksum.len() {
        32 => Algorithm::MD5,
        40 => Algorithm::SHA1,
        64 => Algorithm::SHA256,
        128 => Algorithm::SHA512,
        _ => Algorithm::SHA1,
    }
}

/// Find the best checksum available for an array of checksums.
pub fn find_best_checksum<S: AsRef<str>>(checksums: &[S]) -> Option<(&str, Algorithm)> {
    for &algorithm in ALGORITHMS {
        for checksum in checksums {
            if algorithm == checksum_guess_kind(checksum.as_ref()) {
                return Some((checksum.as_ref(), algorithm));
            }
        }
    }

    None
}

Coverage decreased (-2.9%) to 71.429% when pulling 3330fa478099151297bde92c122350e989f0cc93 on mmstick:algo-derives into dc9be9f866b2b98cc67d7195d4b017d1e5dfaf66 on malept:master.

Seems reasonable. I don't know why the coverage decreased, I'll need to find some time to look into that.
Adding derives is a non-breaking change, right?

Indeed, adding derives only adds features, and does not modify any existing behavior. If you were not using these traits before, you won't be using them after.

Any chance I could get this merged so I can publish https://github.com/pop-os/fwupd-dbus?

I'll try to make some time this weekend to look into the coverage discrepancy.

Thanks for your patience!

Released in 0.3.4.


Tag all releases

The README.md suggests:
- uses: rui314/setup-mold@v1

However the latest and only "v1" tag has not been updated for the recent commits, e.g. https://github.com/rui314/setup-mold/compare/v1..main
It would be best if each "release" gets its own tag. e.g. "v1.0.2" and a major version tag such as "v1" gets updated continously, see https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-release-management-for-actions
This would also help for pinning full-length sha with a version comment for https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
If you'd rather not do tags, I suggest you update your doc to:
- uses: rui314/setup-mold@main

See https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-branches-for-release-management
This way users of the action constantly get (possibly breaking) updates.

If you don't intend to change anything in the action other than the default mold version https://github.com/rui314/setup-mold/blob/354d1662b2a6f02e5eccc9712f22657621bf645b/action.yml#L6C5-L6C21, then yes - users could just use v1 of the action and explicitly set the mold version instead.
But in that case, why do you even create commits such as "Bump mold version to x.y.z"? The users won't use that new default if they still use the old "v1" tag as your readme suggests them to do.
Furthermore "By default, the most recent version will be installed." is wrong since "v1" of the action will only ever install 2.0.0 currently, while at the time of writing 2.2.0 is the latest mold version.

I usually don't increment the default v1 version immediately after I make a new release. Instead, I advance only the staging tag to refer to the latest version and see if everything is okay. The thing that v1 pointed to 2.0.0 was just my mistake -- it now refers to version 2.2.0.


Add tests

Added a minimal testing hookup to wetzel.
These tests do not follow typical unit testing guidelines. The final end user never actually runs wetzel itself, they simply read a document that was produced by wetzel. As such, we don't bother to probe the innards of wetzel to check if each little API entry point works. Instead, we have sample schema inputs, and "golden" outputs that wetzel is expected to produce from those inputs.
If you hack up the inside of wetzel completely, but the resulting output document has no diffs at all from what was there before, the tests all pass. If you make an intentional change to wetzel output, the golden outputs will likewise need to be updated, revealing the intended change as git diffs. And most importantly, if some changes to wetzel have unintended concequences for its output formatting, those will be flagged as test failures. Keep your diffs clean!
This is basically the strategy that was manually used to test wetzel PRs prior to any test framework being connected.

This also fixes an issue where the -p command-line argument couldn't accept an absolute URI.


Remote restore not working - "DB metadata not changed. database may already exist"

Influxdb 1.5 (apine docker version)
backup
influxd backup -portable -database "metrics-cadvisor" -host $DATABASE_HOST:$DATABASE_PORT "$BACKUP_PATH"

influxd backup -portable -database "metrics-health" -host $DATABASE_HOST:$DATABASE_PORT "$BACKUP_PATH"

restore
influxd restore -portable -database "metrics-cadvisor"  -host $DATABASE_HOST:$DATABASE_PORT $BACKUP_PATH ;

influxd restore -portable -database "metrics-health" -host $DATABASE_HOST:$DATABASE_PORT $BACKUP_PATH

error
2018/03/16 17:18:44 error updating meta: DB metadata not changed. database may already exist
restore: DB metadata not changed. database may already exist
Restore failed

I tried deleting the 2 databases before restoring, and it didn't work.

@pragmaticivan what version of InfluxDB are you running?

Just updated Influxdb 1.5 (apine docker version)

When restoring, the flag for database selection is '-db'  not '-database', as in   influxd restore -portable -db "metrics-health" -host $DATABASE_HOST:$DATABASE_PORT $BACKUP_PATH.  We'll propose improving on the flags and track them in issue #9608

I'm still getting this error regardless of the -db flag. Have tried -newdb as well and no db flag. Currently running 1.5.1
Error
2018/04/11 09:56:20 error updating meta: DB metadata not changed. database may already exist restore: DB metadata not changed. database may already exist
Backup Command
influxd backup -portable -database "brood" -host localhost:8088 ~/Desktop/influx-backup-test-2
Restore Command
influxd restore -portable -db "brood" -host localhost:8088 ~/Desktop/influx-backup-test-2
Restore -newdb
influxd restore -portable -newdb "brood1" -host localhost:8088 ~/Desktop/influx-backup-test-2

The legacy backup and restore appear to work fine.

hi @entone ,   try:
influxd restore -portable -db "brood" -newdb "brood1"   -host localhost:8088 ~/Desktop/influx-backup-test-2
to clarify:
-db  identifies the database from the backup file that you want to restore.
-newdb indicates the name you want to give to the imported database.   If not given, it will default to the same name as the original.  However, you must restore to a unique db name.  If the original db already exists in the system, then the restore will fail, which is why you need both -db and -newdb   in this case.

Your commands above are not incremental, but always take a full backup.  You can use either -since  or -start and -end  to extract the more recent data.  (see https://docs.influxdata.com/influxdb/v1.5/administration/backup_and_restore/)  Then for each incremental backup, you do as above and restore the incremental part to brood1.  Then, after you've restored the incremental data to brood1, you can side-load it to the original DB and drop brood1:
>  use brood1
> SELECT * INTO brood..:MEASUREMENT FROM /.*/ GROUP BY *
> drop brood1

You can then repeat this process for each increment.

@mcappadonna yes, that's correct.

I don't want to complain about open source software and I appreciate the work that you are doing a lot, but is incremental restore planned? Incremental backup without the means of restoring them incrementally without intensive manual work seems rather cumbersome and a huge oversight.

We wrote this small script for restoring incremental backups so we won't be SOL when the worst happens
https://github.com/motleyagency/influxdb-incremental-restore
It's written in Node, so it might not be optimal for every case but has worked just fine for us.

Also to add onto @petetnt's great work, before you do the SELECT * INTO operation suggested by @aanthony1243, you'll want to:

disable query-timeout
set some sort of CPU limit on influxdb so it doesn't render the machine completely unusable during the restore

I just tried an incremental restore of about 1.6M data points on a 2 core machine, and it took about 2 minutes. This operation is slower than the initial /usr/bin/influxd restore command by one or two orders of magnitude, which makes sense.

Currently struggling with restore/backup, I'm also surprised that I can't restore a backup over an existing database. I expected new data to be added and existing data to be overwritten.
I thought this was what is meant in the docs by

If duplicate data points are included in the backup files, the points will be written again, overwriting any existing data.

Perhaps the docs refers to duplicate data points in the backup itself (although I wonder how that could happen in the first place).
Please consider this a feature request then. The lack of an ability to restore a partial DB file into an existing database is an important shortcoming.
Use case: I recently backed up / restored databases to migrate an InfluxDB instance and something went wrong, I guess, because new databases lack chunks of data. After a few days, I made new backups and would like to complete the new databases. I can't afford to replace from scratch because new databases have been recording new data since the migration.

I've been trying the workaround proposed by @aanthony1243 in https://github.com/influxdata/influxdb/issues/9593#issuecomment-380994623:

use brood1
SELECT * INTO brood..:MEASUREMENT FROM /.*/ GROUP BY *
drop brood1

Unfortunately, it seems only measurements of numerical type are copied (#18132) so it does not provide a full backup/restore solution.
At this point, I have data in two different databases and I can't find a way to merge data from one into another.

@lafrech the InfluxDB team has moved on to version 2.0, so you won't see a feature like this added to 1.x.
Consider using the hack I mentioned a few comments ago to merge data from one database to another.


⚠ Bofrost.be has degraded performance

In ae9f82d, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 14783 ms

Resolved: Bofrost.be performance has improved in c31628d.


Does not change to directory

When I select any of the files from my bookmark, my cwd is not actually changed to the directory of the file.
It works if I disable change_to_vcs_root.
I would expect it to first try to change to the vcs root, and if it does not exist, then change to the file dir.
let g:startify_change_to_vcs_root = 1
let g:startify_change_to_dir = 1

let g:startify_bookmarks = [
      \ {'v': '~/.config/nvim/init.vim'},
      \ {'n': '~/.config/nixpkgs/home.nix'}
      \ ]

You are too quick :laughing:

:) Thank you for finding these bugs! ✨


Command bar: add extrude command, nonlinear editing, etc

Part 2 of big overhaul of the command bar to begin supporting modeling commands. Does the following:

Refactors types for command bar configuration to help make it easier to add new types in the future
Refactors the command bar state to be managed by its own XState machine
Allows commands to support multiple highly-configurable arguments that may

be strings, point-and-click selections, option inputs, or numbers
be required or optional
be skipped in the command bar (if a payload is supplied)
be hidden on one or more platforms
have default values or not

Allows commands to be made reviewable with a confirmation dialog step
Allows for nonlinear editing of command arguments
Adds hotkeys for switching arguments, advancing in the command bar flow, etc
Add test for using extrude via the command bar workflow
CSS tune-ups to support

Demo video
https://github.com/KittyCAD/modeling-app/assets/23481541/098448d6-eca6-4f37-ac42-af6691575dc8
New command bar state machine

Resolves #846 and resolves #203, and ticks off one item from #817

This is so sick.

lol yeah I was giddy in the first video in Slack, just a little tired during the second


UnixPB: Fix insecure downloads discovered from TrailOfBits Audit

Fix issues identified in ToB #4
Fixes #3324
Checklist

[X] commit message has one of the standard prefixes
[ ] playbook changes run through VPC or QPC (if you have access)

VPC in progress: https://ci.adoptium.net/job/VagrantPlaybookCheck/1827/
All changes have been tested locally and have worked ok.

I'll run some tests on a SLES docker image, I did manage a test on a SLES 12.3 x64 vagrant box, with a custom written playbook, that simply downloads the file with those options, but I'll try running the playbook on some additional docker SLES12 & SLES15 s390x containers or similar.

Tests on SLES12 & SLES15 docker containers ok for the changed element of the Java download, for SLES12, there are many other issues related to the lack of official repositories, but these are known issues, with SLES12 being end of life.


Remove 'extra_css_files'

extra_css_files was add in https://github.com/rtfd/readthedocs.org/commit/e759c50697c5c9b210f5b7ea2978e24b25aef901 but serves no purpose (not sure why it was added intially) users should use Sphinx.add_stylesheet instead.

Actually looking at this there are several projects that use this. Is there a way to mark this as deprecated?

Yeah, this is still in use by forks, so I wouldn't want to deprecate it either.

Well, this is used for add style sheets, which might be required to fine-tune the appearance where rst is coming to its limits.

This should still be removed to conform sphinx's new method for adding css files.
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_css_files
This can be removed when we require sphinx2, there does not seem the be a way to deprecate this first.

I think we can target this for 3.0 and start raising a warning on 2.x.

I just wanted to note that we had some issues when releasing 2.0 because of this chunk of code. I'm fine removing this since it adds no value over the built-in Sphinx feature.

Updated the branch and waiting on approval for 2.0

Thanks for the update @Blendify. I don't think we will include this in 2.0 since we are on rc4 already and this will break projects already using this config. However, I'm 👍🏼 to remove this on 3.0 together with other breaking changes we are planning to do as well.

We definitely need to do a deprecation warning before removing an option like this.
Though this is a configuration we shouldn't have added, I also personally don't see much value in a deprecation like this given it's such a sideways change -- the code here isn't really presenting a problem for our maintenance and the user is not really better off being forced to change either.
If we do a deprecation in 3.0, we should emit a deprecation warning starting in 2.0


test: re-enable HPE merge test

re-enable HPE merge test, oops
Fixes: #87

Coverage increased (+2.05%) to 91.992% when pulling de8505a802c94a56d5a6498a4604038c9181e53a on reenable-hpe into a669a06dddbbaffb7c1919f56a02e50df0560c5a on master.


Need to update BLAST database

Tied to JIRA 2141
User is unable to blast the following sequence against these genome IDs (2065118.12, 2065118.14, 1639.5069, 1639.5025)
MANLKVIENEATILASIPKHNVDYNARVMQSVSVDYERDMIYWTQQYSGKKMTDAGAGES
YNITRTDLKGNYIDQMWCLNGGHGTNIALDYNLESKKMHIWSAYKINNKWEVVCYPYESN
KILKGTESSIFISKVESGSYNRISGDLKNDMLVFHSGGDPKTFNIRIVRASSVREGKLEV
LYKVKATEANDAYVYQGCALDFPYLYTASGTGGVEEPKQLTCVDIVTGKRVYQTTFKFNT
KAMQTTESNFAEPENVCVYYKNNQKHIVVGYALGGAGNRMNRAFDLVENNSENIETEIES
LRNLIISRKRTEVIFDQSTKGDMTTNFKLRETLNNFDIIQVVLESGGGYTTASRLVSPKL
FEASKSFIFASSNIGDTSGNNVDMYEYAANFNDDLTSFKNDRAVKIEVSNNGTVRGNITN MGIKKIYGIVL

All BLAST databases have been updated after the January Release.

I have updated all blast databases. I tried the specific query above and it is working now.


Touch select event missunderstanding

I have spent a lot of time with issue in the webview on Galaxy Tab S2. I was not able to use either ol.interaction.Select singleclick or click event, it doesn't matter if hitTolerance has been used or not. It took several touches on a tablet screen to finally select a feature, it was quite tricky. We tried to debug it in the native android app and it worked only in cases when ACTION DOWN, ACTION MOVE and ACTION UP within the tablet had exactly same coordinates. Simply there is always slight dragging, when a user tries to do only click/touch.
After tests with map.on("click" click we have realized, that it has the same corrupted behavior as the previous one and more catching pointermove was impossible because of an entire map slowness..
            //Don't work
            map.on("click", function (evt) {
                app.showMessage(evt.coordinate[0]);
            });

Finally we tried below code and it works as a charm... We can build the selection upon this code:
            map.getViewport().addEventListener('click', function (evt) {
                map.getEventCoordinate(evt);
                //Pick a feature from particular layer etc.
            });

The question is why it is happening as so, that there is the difference between map.on and map.getViewPort().addEvent Has somebody the same issue ?
Openlayers 4.1.1 has been used.

see #6776


loader: Fix egress attachment for bandwidth manager

The loader only attaches BPF programs to the egress of native devices if the host firewall or BPF NodePort are enabled. It is however also necessary to attach on egress if only the bandwidth manager is enabled.
Updates: https://github.com/cilium/cilium/issues/16790.
Fix BPF attachment when bandwidth manager is enabled without host firewall or kube-proxy-replacement.

/test

/

/test-runtime


FIFO Banking Analysis Seems Broken Suddenly

For example:
CompactingFIFO.scala:46: Could not bank the following reads and writes for memory x140
[error]         out(i :: i + tileSize par 2) store fifo

Very likely that I did something that started causing this

Traced this down to an issue where Alphas was actually empty as generated by the exhaustive banking methods. This was because we were taking the size of an iterator, which actually iterates through the collection, causing it to later appear empty. The logic using the size wasn't actually being used, so I just removed that part. App compiles now on broadcast branch.


Is there any way how to donwload file with remote webdriver ?

Hello i need to do this:
i have multiple nodes on selenium grid and i need download file on remote node (with remote webdriver) , but i don't know how.
I don't care if downloaded file ends on node local disk.
Is there any way how to do it using selenide $.download ?

Hi!
Unfortunately, FOLDER mode doesn't work with Selenium Grid.
The reason is that Grid is a different machine, and test machine cannot always access files on that Grid machine.
Please try FileDownloadMode.HTTPGET or FileDownloadMode.PROXY.

@dironel FYI I registered a feature request https://github.com/selenide/selenide/issues/1687
Probably some day somebody can implement it. :)