Fixed OpenVPN related sensors (#264)

Fixed the ID check in get_openvpn function. Did some debugging and it seems that the id-values retrieved from /api/openvpn/service/searchSessions are integers when the VPN-connection is not active. However, when the connection is live, the id-value is in format "ID_IP-ADDRESS:PORT". Modified the id check to work for both scenarios. Also enabled/fixed the connected client count by counting sessions that have a value in connected_since field.

Thanks, LGTM. But @Snuffy2 has the final word.

Thanks @jesmak! Are you using the "new" OpenVPN setup or the legacy one? I'll need to look later, but I believe the new one uses much longer vpnids which are strings and not integers. We may need to account for those as well.

Thanks @jesmak! Are you using the "new" OpenVPN setup or the legacy one?

It's the legacy one. It's been a few years since I set it up and it was somewhat complicated, so I don't want to mess with it until I absolutely have to.

Nope, nothing you need to change on your setup. I'll stand-up a simple OpenVPN server on my router using the new setup and confirm what is bring returned and then we can determine how we can best handle both the legacy and new setups.

This is from the new OpenVPN /api/openvpn/service/searchSessions:
No connection:
{
    "total": 2,
    "rowCount": 2,
    "current": 1,
    "rows": [
        {
            "status": "wait",
            "timestamp":<PHONE_NUMBER>,
            "virtual_address": "",
            "real_address": "",
            "bytes_received": "0",
            "bytes_sent": "70",
            "type": "client",
            "id": "fc64283f-dbfe-4195-961f-df6bc682918d",
            "description": "Snuffy2's iPhone 16",
            "connected_since": "2024-10-15 20:37:03"
        },
        {
            "status": "ok",
            "type": "server",
            "id": "a90bf93b-0c67-4afa-9beb-5a96c6a956ee",
            "description": "Snuffy2 OpenVPN",
            "timestamp": null,
            "virtual_address": null,
            "real_address": null,
            "bytes_received": null,
            "bytes_sent": null,
            "connected_since": null
        }
    ]
}

With an active connection:
{
    "total": 2,
    "rowCount": 2,
    "current": 1,
    "rows": [
        {
            "status": "wait",
            "timestamp":<PHONE_NUMBER>,
            "virtual_address": "",
            "real_address": "",
            "bytes_received": "0",
            "bytes_sent": "42",
            "type": "client",
            "id": "fc64283f-dbfe-4195-961f-df6bc682918d",
            "description": "Snuffy2's iPhone 16",
            "connected_since": "2024-10-15 20:31:51",
            "common_name": null,
            "virtual_ipv6_address": null,
            "connected_since__time_t_": null,
            "username": null,
            "client_id": null,
            "peer_id": null,
            "data_channel_cipher": null,
            "is_client": null
        },
        {
            "status": "ok",
            "type": "server",
            "id": "a90bf93b-0c67-4afa-9beb-5a96c6a956ee_555.555.555.555:64529",
            "description": "Snuffy2 OpenVPN",
            "common_name": "snuffy2-ca",
            "real_address": "555.555.555.555:64529",
            "virtual_address": "<IP_ADDRESS>",
            "virtual_ipv6_address": "",
            "bytes_received": "5280",
            "bytes_sent": "5144",
            "connected_since": "2024-10-15 20:31:30",
            "connected_since__time_t_": "1729038690",
            "username": "UNDEF",
            "client_id": "6",
            "peer_id": "1",
            "data_channel_cipher": "AES-256-GCM",
            "is_client": true,
            "timestamp": null
        }
    ]
}

Ok so it's the same, but number id has been replaced with a guid. I can make a small adjustment to my PR to also cover this case.

I updated the id comparison, but now I'm wondering if the connected client count also needs some changes. In the session data you pasted, connected_since has a value even when there's no active connection. Maybe we should also check if connection status is "ok" in addition to the connected_since field?

Maybe we should also check if connection status is "ok" in addition to the connected_since field?

it's a good idea, but I also noticed that in the "active connection" json, for "type" client, the connection status is always "wait". So how do we distinguish if it's active or not?
@Snuffy2 are you sure those json outputs are correct? Am I missing something?

Maybe we should also check if connection status is "ok" in addition to the connected_since field?

it's a good idea, but I also noticed that in the "active connection" json, for "type" client, the connection status is always "wait". So how do we distinguish if it's active or not?
@Snuffy2 are you sure those json outputs are correct? Am I missing something?

I might be wrong, but I was under the impression that in the second json only one connection is active. The one that had its' id change to contain an IP-address.

I might be wrong, but I was under the impression that in the second json only one connection is active. The one that had its' id change to contain an IP-address.

I was looking at "type": "client". But I might be interpreting things incorrectly.
If you notice the client (the iphone), from active json and inactive json, the status is always ok. Probably the logic is different, but it's not very intuitive to me.

I was looking at "type": "client". But I might be interpreting things incorrectly.
If you notice the client (the iphone), from active json and inactive json, the status is always ok. Probably the logic is different, but it's not very intuitive to me.

Yeah, it certainly is not intuitive. Here's the session info from my legacy OpenVPN setup. First copy-paste has an active site-to-site VPN connection (id 1) and an inactive road warrior configuration (id 2). Second copy-paste has an active site-to-site VPN connection (id 1) and an active road warrior VPN connection from my Android phone (id 2).
{
	"total": 2,
	"rowCount": 2,
	"current": 1,
	"rows": [
		{
			"status": "ok",
			"type": "server",
			"id": "1_IP_ADDRESS:57696",
			"description": "OBFUSCATED",
			"common_name": "OBFUSCATED",
			"real_address": "IP_ADDRESS:57696",
			"virtual_address": "IP_ADDRESS",
			"virtual_ipv6_address": "",
			"bytes_received": "118407325586",
			"bytes_sent": "4310554814",
			"connected_since": "2024-10-13 11:55:25",
			"connected_since__time_t_": "1728809725",
			"username": "OBFUSCATED",
			"client_id": "3",
			"peer_id": "0",
			"data_channel_cipher": "AES-256-GCM",
			"is_client": true
		},
		{
			"status": "ok",
			"type": "server",
			"id": 2,
			"description": "Road warrior",
			"common_name": null,
			"real_address": null,
			"virtual_address": null,
			"virtual_ipv6_address": null,
			"bytes_received": null,
			"bytes_sent": null,
			"connected_since": null,
			"connected_since__time_t_": null,
			"username": null,
			"client_id": null,
			"peer_id": null,
			"data_channel_cipher": null,
			"is_client": null
		}
	]
}

{
	"total": 2,
	"rowCount": 2,
	"current": 1,
	"rows": [
		{
			"status": "ok",
			"type": "server",
			"id": "1_IP_ADDRESS:57696",
			"description": "OBFUSCATED",
			"common_name": "OBFUSCATED",
			"real_address": "IP_ADDRESS:57696",
			"virtual_address": "IP_ADDRESS",
			"virtual_ipv6_address": "",
			"bytes_received": "118451730703",
			"bytes_sent": "4312047198",
			"connected_since": "2024-10-13 11:55:25",
			"connected_since__time_t_": "1728809725",
			"username": "OBFUSCATED",
			"client_id": "3",
			"peer_id": "0",
			"data_channel_cipher": "AES-256-GCM",
			"is_client": true
		},
		{
			"status": "ok",
			"type": "server",
			"id": "2_IP_ADDRESS:51503",
			"description": "Road warrior",
			"common_name": "OBFUSCATED",
			"real_address": "IP_ADDRESS:51503",
			"virtual_address": "OBFUSCATED",
			"virtual_ipv6_address": "",
			"bytes_received": "6364",
			"bytes_sent": "5953",
			"connected_since": "2024-10-16 12:43:38",
			"connected_since__time_t_": "1729071818",
			"username": "OBFUSCATED",
			"client_id": "1",
			"peer_id": "0",
			"data_channel_cipher": "AES-256-GCM",
			"is_client": true
		}
	]
}

As you can see, all of these have the type set as "server". I'm really not sure what this is supposed to mean, as the road warrior connection is definitely initiated by a client app in a mobile device. In addition, there's the "is_client" property which in my examples is always true for active connections. This seems to be how it is in Snuffy2's copy-paste too, assuming "Snuffy2 OpenVPN" in the second json is the only active connection of the four.
So, perhaps the way to calculate active client connections should be: status is "ok", is_client is "true" and connected_since has some value in it.

I think I've been looking at this a bit wrong. All the time I assumed that Snuffy2 had two different VPN configurations which are shown in the json, but I guess it just shows both the client and server sides separately for a single configuration? The legacy setup I'm using only shows one entry for one configuration. I have to check what is shown in the sessions list when I open two simultaneous road warrior connections from different devices. If a third entry appears, I think it's a safe bet to calculate the connected clients the way I proposed in my previous message.

Tested with two simultaneous road warrior connections from two different devices and unfortunately, a third entry does not appear. Session list shows the same two entries, with nothing to indicate that there are actually multiple active connections for the other VPN configuration. This makes it quite impossible to count the client connections with the legacy setup. @Snuffy2, do you have another device you could use to test two simultaneous connections with the new OpenVPN setup? If it has the same problem, might make sense to remove the whole sensor from this integration as there's no way to get the correct count for it.

So for the new OpenVPN, Servers and Clients are both an Instance. The server and client I setup are both listed there. Paradoxically, the one with "is_client": true, is the Server and "is_client": null is the Client, although the type field is accurate.
For the client, connected_since always shows a time, even when I'm not connected, so also not accurate.
Let me explore some more.

Beware that there are complex configurations with openvpn that can allow the same client (cert, or username, etc depending on config) to be connected multiple times simultaneously.

I'm not able to test 2 concurrent OpenVPN connections right now. @jesmak what does:
/api/openvpn/service/searchRoutes
show for you? Does it change with 0-2 connections?

I'm not able to test 2 concurrent OpenVPN connections right now. @jesmak what does: /api/openvpn/service/searchRoutes show for you? Does it change with 0-2 connections?

It does change. Here's the output:
{"total":21,"rowCount":21,"current":1,"rows":[{"virtual_address":"X.X.X.80C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:12","last_ref__time_t_":"1729146192","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.81C","common_name":"obfuscated1","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:13","last_ref__time_t_":"1729146193","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.86C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:12","last_ref__time_t_":"1729146192","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.87C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:13","last_ref__time_t_":"1729146193","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.84C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:12","last_ref__time_t_":"1729146192","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.72C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:05","last_ref__time_t_":"1729146185","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.70C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:22:55","last_ref__time_t_":"1729146175","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.62C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:22:20","last_ref__time_t_":"1729146140","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.10C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:03","last_ref__time_t_":"1729146183","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.85C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:14","last_ref__time_t_":"1729146194","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"Y.Y.Y.0","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:07","last_ref__time_t_":"1729146187","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.82C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:10","last_ref__time_t_":"1729146190","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.52C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:15","last_ref__time_t_":"1729146195","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.83C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:14","last_ref__time_t_":"1729146194","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.60C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:22:59","last_ref__time_t_":"1729146179","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.51C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:15","last_ref__time_t_":"1729146195","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.63C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:22:59","last_ref__time_t_":"1729146179","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.0\/24","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-13 11:55:28","last_ref__time_t_":"1728809728","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.50C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:15","last_ref__time_t_":"1729146195","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"X.X.X.61C","common_name":"obfuscated","real_address":"XXX.XXX.XXX.XXX:57696","last_ref":"2024-10-17 09:23:06","last_ref__time_t_":"1729146186","type":"server","id":1,"description":"obfuscated"},{"virtual_address":"Z.Z.Z.6","common_name":"obfuscated","real_address":"YYY.YYY.YYY.YYY:26742","last_ref":"2024-10-17 09:23:06","last_ref__time_t_":"1729146186","type":"server","id":2,"description":"Road warrior"}]}```

It seems to show all the devices that connect to my home network via the site-to-site VPN, along with their actual IP-addresses in that remote subnet. These are the rows with id 1.

Also when connecting a device using the road warrior configuration, a new row appears (id 2). However, when connecting another device using the same road warrior configuration, a new row does not appear. The devices themselves show the same private IP on the OpenVPN app, so I guess it makes some sort of sense considering the previous message by @travisghansen. I'm by no means a networking expert but it feels really weird to me that these two separate physical devices connecting from two separate physical networks would be considered the same client, but that is indeed how it seems.

Yes, the Road Warrior scenario is very weird.
You're saying that two separate devices one with a public IP of <IP_ADDRESS> and another with public IP of <IP_ADDRESS> when connected to the Road Warrior OpenVPN both get the same OpenVPN IP of 333.333.333.333 (IPs obviously made up)??
Also, which IP shows in the real_address field? That is supposed to the public IP of the client connected to the OpenVPN Server, right?

This is exactly how it seems to be, at least in my environment. real_address for the site-to-site VPN seems to have the public IP-address of the remote location connected to my home network. For the road_warrior connections, it's sometimes the public IP of my Android phone's mobile connection (WiFi is disabled), and sometimes it's the (private) IP-address of my laptop which is connected to my WiFi. So it's not static when both devices are connected. Which IP is shown in /services/searchRoutes, it seems to change randomly. And yes, the private IP of the VPN-connection displayed in both clients is the same.

Bizarre. I guess, as you proposed, we should just remove the Connected Client sensor for now. I'll be updating some of that code likely this weekend so I can do that part. I'll be adding in similar data for Wireguard VPNs. Since Wireguard VPNs are stateless, there also won't be a Connected Client count sensor for it either.
If you want to refine your PR to just fix the id issue for now, that would be great.

Hey! Sorry I was a bit busy so didn't get back to this until now, but I see you already took care of it. Thank you!


Breaks associated_type_bounds

Input code:
#![feature(associated_type_bounds)]

fn f<I: Iterator<Item: Clone>>() {}

As of current rustfmt master (e0e2f0db537904b0efa78a106384e62852b806f0), rustfmt applies the following diff which makes the original code no longer compile:
- fn f<I: Iterator<Item: Clone>>() {}
+ fn f<I: Iterator<Item = Clone>>() {}

warning: trait objects without an explicit `dyn` are deprecated
 --> src/main.rs:3:25
  |
3 | fn f<I: Iterator<Item = Clone>>() {}
  |                         ^^^^^ help: use `dyn`: `dyn Clone`
  |
  = note: #[warn(bare_trait_objects)] on by default

error[E0277]: the size for values of type `(dyn std::clone::Clone + 'static)` cannot be known at compilation time
 --> src/main.rs:3:1
  |
3 | fn f<I: Iterator<Item = Clone>>() {}
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
  |
  = help: the trait `std::marker::Sized` is not implemented for `(dyn std::clone::Clone + 'static)`
  = note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
  = note: required by `std::iter::Iterator`

error[E0038]: the trait `std::clone::Clone` cannot be made into an object
 --> src/main.rs:3:1
  |
3 | fn f<I: Iterator<Item = Clone>>() {}
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::clone::Clone` cannot be made into an object
  |
  = note: the trait cannot require that `Self : Sized`

https://github.com/rust-lang/rustfmt/blob/e0e2f0db537904b0efa78a106384e62852b806f0/src/types.rs#L172-L177
We need to use a correct separator based on the AssocTyConstraintKind.

@topecongiro - I'd like to work on this one. The implementation looks relatively straightforward, but I might have a few questions if that's okay 😄
What exactly is the expected behavior if the AssocTyConstraint is Bound? Technically both of the below items will compile, but I don't think it's what we'd want/expect:
fn f<I: Iterator<Item : Clone>>() {} // type_punctuation_density = wide

fn f<I: Iterator<Item:Clone>>() {} // type_punctuation_density = compressed

Should we just skip the rewrite on Bound kind?

@calebcartwright Great, thank! Questions are always welcome :grin:
We should always add a space after : but not before it. In other words we do not need to take type_punctuation_density into account when AssocTyConstraint is Bound:
-fn f<I: Iterator<Item : Clone>>() {}
+fn f<I: Iterator<Item: Clone>>() {}

That makes a lot of sense thanks! I believe I've got this fixed, will open a PR later today. With what I've got currently:
This:
fn f<I: Iterator<Item: Clone>>() {}
fn f<I: Iterator<Item : Clone>>() {}
fn f<I: Iterator<Item:Clone>>() {}

Would be formatted to:
fn f<I: Iterator<Item: Clone>>() {}
fn f<I: Iterator<Item: Clone>>() {}
fn f<I: Iterator<Item: Clone>>() {}

Assuming that's the correct/expected behavior, where should I add tests for that? Should they go under  an issue-3657 directory under ./tests/source/ and ./tests/target/?

@calebcartwright tests would go in tests/source/ which is where you put the original code, then in tests/target/ where you put the expected formatting.

sorry I didn't your question got answered in the PR !


Feature request: only generate teardrops

Hi!
Watched your video on Youtube and just tried the plugin.
I don't like the look of round tracks for all my PCBs, but widening a thin trace around a via is always good.
Would it be possible to not round any corners, but only apply teardrops?
Perhaps it could also be a setting to only apply to vias or to vias and pads.

FYI teardrops are generated with this plugin.

Yep the teardrops are completely separate from the track rounding already.


Feature flags to limit dependencies

Can make some features optional to reduce dependencies:

[ ] Make AWS optional to eliminate AWS SDK crates
[ ] Make FTS optional to not require tantivy

Originally discussed here: https://github.com/lancedb/lance/discussions/2627


Modified error message and added some colour #6

Added some colour to a couple of error messages, added colour to sucess on download. Faded and added a return before the message showing where files are located. Couldn't modify the 'directory not found' message as it seems to use something hardcoded in python?
Also modified the error message to state that the magazine might not be out for free yet.

Sorry for the (long) wait. And thanks for the contribution :+1: .


Warning message as of React 0.14

The react package has been updated to 0.14, and as a result, React.render is no longer valid. For React 0.14 and up, it should be ReactDOM.render.

+1

I created a PR #33

Ah, beat me to it!

+1

another error:
Warning: React.renderToStaticMarkup is deprecated. Please use ReactDOMServer.renderToStaticMarkup from require('react-dom/server') instead.

Good catch. Someone else wanna PR that one?

I checked for the new React via Package['react-runtime'].ReactDOM. I'm not sure if that's the best way or not, but it works.

@ffxsam we can simply give the latest version of the react package. So, we don't need to check for backward compatibility.

So you mean react-layout will now require react 0.14 and above?

Yes. I'll work on the PR.

Check v1.5.0. it's has the latest React version.
We had to do few stuff to support SSR specially.
See: https://github.com/kadirahq/meteor-react-layout/commit/b2b67a508d96caec13980d3236fa3a20df397287

upgraded to the v1.5.0
these upgrades happen too
osmos:browserify    upgraded from 0.5.1 to 0.8.1
kadira:react-layout  upgraded from 1.4.1 to 1.5.0
react                upgraded from 0.1.13 to 0.14.1
react-meteor-data    upgraded from 0.1.9 to 0.2.2
react-runtime        upgraded from 0.13.3_7 to 0.14.1
react-runtime-dev    upgraded from 0.13.3_7 to 0.14.1
react-runtime-prod   upgraded from 0.13.3_6 to 0.14.1

cosmos:browserify new upgrade slows the rebuild process.. Please look in to this too

I can also confirm the huge slow down in the rebuild process after browserify updated.

I initally received the React.render not a function, removed the react package, then readded it, and now I am getting this console error:
VM1567:2 Uncaught SyntaxError: Unexpected token < in JSON at position 1xo.onfinish @ sockjs-0.3.4.js:2018EventEmitter.emit @ sockjs-0.3.4.js:151that.xhr.onreadystatechange @ sockjs-0.3.4.js:848
and this command line error:
while computing assigned variables: /packages/kadira_react-layout/packages/karia_react_layout.js: unexpected token: (69:12)
I think kadira:react-layout is broken.  Any way to fix this?


issue with linux assembly

its not a bug, its mainly stupidity
i dont know if you have a version to download,for linux. or only git stuff, which i have basically no clue about. i did some stuff got a master,installed cmake, it says something is missing.. mint doesnt offer a clue what exactly.
i would be happy about a sh or any sort of linux startable version , where i would not need to learn more then 4 hours how to just get a useful file together.
i mean, 4 hours,and a couple folder later,i still have nothing to show,or run for.
thanks,and sorry i have to use that way,no other basic contactmethod.

Hi @jay-76 , you are using Linux Mint?
You can try this. https://github.com/OmniNegro123/med/commit/9100db7ad44e0b1e36e06d942d84325d2bd95aed
Hopefully it helps.

yes mint mate, thanks that one helped,even if "2.5 cd build" was missing, basically i missed the first line with all those apps to install.
thanks again
it works flawless and yes its much better then the basic gc.
thanks for your time, making it.aswell as pointing that install list out.
regards Jay


workflows: enable running ci against ceph pacific

Enable the CI to run on ceph pacific release.
Previous issues with ceph pacific pre-release are resolved. Fixes applied to tests. Build tags are updated.
Checklist

[x] Added tests for features and functional changes
[x] Public functions and types are documented
[x] Standard formatting is applied to Go code

In addition to these changes, there are also Build Constraints that should get updated. Features introduced with Octopus should also get included in Pacific builds, as non-deprecated Nautilus features.

@mergifyio rebase

@mergifyio rebase

Only thing missing is the addition to README.md.

Only thing missing is the addition to README.md.

What addition to readme? Do you mean adding it to the supported versions table? If so, I don't do that until at or immediately after the release.

On Wed, Apr 28, 2021 at 04:18:32AM -0700, John Mulligan wrote:

Only thing missing is the addition to README.md.

What addition to readme? Do you mean adding it to the supported versions table?

Yes, that.

If so, I don't do that until at or immediately after the release.

I thought so, hence my +1. I don't think it hurts to add it already, but
waiting for the release is fine too.


Add command LeaderfCommand

I tried to implement command which is one of #451.
When executing a command, if a command requires an argument (E471), it can now be automatically entered on the command line.
Also, the line can be edited with e (normal mode) or C-o (input mode) like cmdHistory/searchHistory.
Please let us know if any changes are missing.
Thank you.

Thank you!

E492: Not an editor command: LeaderfCommand

E492: Not an editor command: LeaderfCommand

Thanks for letting me know.


Update from MazaCoin to Maza, fix OSX build, fix dns seed node entry, and update icon files.

Closing for new updated request.


Added table/options.ReadFromSnapshot() option for session.Stream…ReadTable() + Changed default value of UseSnapshot field to Ydb.FeatureFlag_DISABLED (previous not defined - equal to Ydb.FeatureFlag_STATUS_UNSPECIFIED)

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
Patch coverage: 42.85% and project coverage change: +0.04% :tada:

Comparison is base (3d2afa2) 66.29% compared to head (eb9f867) 66.34%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   66.29%   66.34%   +0.04%
==========================================
  Files         234      234
  Lines       23124    23129       +5
==========================================
+ Hits        15331    15344      +13
+ Misses       6985     6980       -5
+ Partials      808      805       -3

Flag
Coverage Δ

53.70% <42.85%> (+0.03%)
:arrow_up:

go-1.17.x
65.85% <42.85%> (-0.11%)
:arrow_down:

go-1.19.x
66.01% <42.85%> (-0.05%)
:arrow_down:

go-1.20.x
65.93% <42.85%> (+0.11%)
:arrow_up:

integration
53.70% <42.85%> (+0.03%)
:arrow_up:

macOS
39.76% <0.00%> (-0.04%)
:arrow_down:

ubuntu
39.80% <0.00%> (+0.04%)
:arrow_up:

unit
39.83% <0.00%> (-0.03%)
:arrow_down:

windows
39.75% <0.00%> (+0.15%)
:arrow_up:

ydb-22.5
53.70% <42.85%> (+0.60%)
:arrow_up:

ydb-23.1
?

ydb-23.2
?

ydb-23.2-slim
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

table/options/options.go
56.20% <0.00%> (-0.43%)
:arrow_down:

internal/table/session.go
78.95% <100.00%> (-0.77%)
:arrow_down:

... and 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cleanup and optimize

Cleanup duplicate code.
Optimize config access.

@levkk oh sir, I completely forgot about that.


Mouse selection is not working

Issue Type: Bug
Mouse selection is not working
VS Code version: Code 1.66.2 (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:46:01.075Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-6006U CPU @ 2.00GHz (4 x 1992)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.88GB (2.36GB free)

Process Argv
--crash-reporter-id 6abcceab-0082-4b4c-8dc8-1d7ee64b5eb8

Screen Reader
no

VM
0%

Extensions (38)

Extension
Author (truncated)
Version

npm-intellisense
chr
1.4.1

path-intellisense
chr
2.8.0

dart-code
Dar
3.38.2

flutter
Dar
3.38.1

vscode-eslint
dba
2.2.2

python-preview
don
0.0.4

vscode-npm-script
eg2
0.3.24

prettier-vscode
esb
9.5.0

code-runner
for
0.11.7

search-node-modules
jas
1.3.0

vscode-codemetrics
kis
1.24.0

kite
kit
0.147.0

node-module-intellisense
lei
1.5.0

mongodb-vscode
mon
0.9.2

vscode-azurefunctions
ms-
1.6.2

vscode-azureresourcegroups
ms-
0.4.0

python
ms-
2022.4.1

vscode-pylance
ms-
2022.4.2

jupyter
ms-
2022.3.1000901801

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.6

azure-account
ms-
0.10.1

cpptools
ms-
1.9.8

debugger-for-chrome
msj
4.13.0

awesome-flutter-snippets
Nas
3.0.3

vscode-for-node-js-development-pack
nod
2.0.1

java
red
1.5.0

LiveServer
rit
5.7.5

code-settings-sync
Sha
3.4.3

vscodeintellicode
Vis
1.2.20

vscode-java-debug
vsc
0.40.1

vscode-java-dependency
vsc
0.19.1

vscode-java-pack
vsc
0.22.4

vscode-java-test
vsc
0.34.2

vscode-maven
vsc
0.35.1

nodejs-extension-pack
wad
0.1.9

vscode-import-cost
wix
3.3.0

JavaScriptSnippets
xab
1.8.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebugcf:30475217
vscaac:30438847

Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.

Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.

more information needed

run F1 > Help: Start Extension Bisect
(this will restart VS Code with half of your extensions disabled)
try to do the steps which reproduce the problem
if the problem reproduces, click "This is bad" (this narrows down the problematic extension to the half which was enabled)
if the problem does not reproduce, click "Good now" (this narrows down the problematic extension to the half which was disabled)
these steps will repeat until the problematic extension is found

initial
step
final


"Variable X is assigned but never used." shown in error.

First of all - great extension. Thanks for creating it.
In PowerShell, it is common to get warnings about variables not being used when they are, as in this example:

Is there a workaround for this? Thanks.

You can use "errorLens.exclude":
"errorLens.exclude": [
	"is assigned but never used.",
],

Thanks, that's good to know. I like to be warned if I'm really not using a variable, though, so it would be better if the warning didn't fail as in this kind of example. Do you think a fix is possible?

Nope. The fix would be for PowerShell extension to produce diagnostics correctly.

Ah ok, thanks.


Subdomain takeover via Helprace

Service name
Helprace
Fingerprint
Alias not configured!
Admin of this Helprace account needs to set up domain alias
(see Step 2 here: Using your own domain with Helprace).

Proof

Documentation
CNAME = *.helprace.com

The fingerprint appears to have changed. Unclaimed subdomains now respond with a 301 redirect to https://helprace.com.


Update permissions list for Code Dx plugin

Description
GitHub: https://github.com/jenkinsci/codedx-plugin
Just looking to prune the uploader list of folks who no longer work on this project.
Submitter checklist for changing permissions
Always

[x] Add link to plugin/component Git repository in description above

@baffles can you please clarify why you would remove these people?
From the Jenkins Project PoV, we need approval from these people to remove them FWIW. Please have them approve here.
Thanks

Well, this has happened in the past, and we've done it by giving future former co-maintainers an opportunity to dispute the change. So, CC @ademartini and @leRadwan, who, by the way, still have commit access.
If you want to clean up GitHub permissions as well (currently 6 users), I recommend this be done as well, ideally through an INFRA issue in Jira.

Just cleaning up permissions; the folks listed no longer maintain the plugin. I do have an open INFRA issue (INFRA-1818) for GitHub permission cleanup/changes to go along with this as well.

I suppose we'll wait at least 15 days overall, somehow like the usual wait time for plugin adoption for the plugin process.

As the requester here already is a maintainer, 11 days seems plenty. (In fact, I basically forgot about this one. 😅) And it's not like this is irreversible if needed.

Thanks!


Modern Object Pascal - Read Section 1

Section 1 of Modern Object Pascal is read & understood.
Acceptance Criteria:
GIVEN the development environment has been setup
WHEN I want to develop using Pascal
THEN I can
As a developer, I want to read Modern Object Pascal so that I can write code using the Pascal language.
https://castle-engine.io/modern_pascal_introduction.html

Read this on 10/19


[REQUEST] ESM Support

ESM support is available?
Project like SST requires ESM to use all framework feature (like resource binding)

Works out of the box, at least as an AWS Lambda, with a layer.
import puppeteer from "puppeteer-core";
import chromium from "@sparticuz/chromium";

export async function shot (event){
	const browser = await puppeteer.launch({
		args: chromium.args,
		defaultViewport: chromium.defaultViewport,
		executablePath: await chromium.executablePath(),
		headless: chromium.headless,
		ignoreHTTPSErrors: true,
	});

	const page = await browser.newPage();
	await page.goto("https://example.com");
	const pageTitle = await page.title();
	await browser.close();

	console.log(pageTitle, "Example Domain");
};

I don't have any problems either, but the package is only set up for cjs and not esm. I'll probably eventually set it to esm only. I've heard there are problems with dual packaging

Yes I am also using it with imports. I have written an article and also made the code open source. Feel free to check it out.
https://adapttive.com/blog/serverless-scraping#how-to-debug
https://github.com/openwishlist/preview

I've just hit difficulties using this with Astro on AWS Lambda (included as a standard dependency, rather than as a layer), as I kept getting ReferenceError: __dirname is not defined. This appears to be coming from chromium.executablePath, but I've been able to get around it by providing the path to the chromium binary:
const browser = await puppeteer.launch({
  ...
    executablePath: await chromium.executablePath(`${path.dirname(fileURLToPath(import.meta.url))}/node_modules/@sparticuz/chromium/bin`),
  ...
});

That variable is dropped in more recent Node versions, nothing to do with the library
†øღ
Sent from a super computer that fits in my pocket and is connected to the sum total of all human knowledge
On 6 April 2023 21:55:36 BST, Ben Jones @.***> wrote:

I've just hit difficulties using this with Astro on AWS Lambda (included as a standard dependency, rather than as a layer), as I kept getting ReferenceError: __dirname is not defined. This appears to be coming from chromium.executablePath, but I've been able to get around it by providing the path to the chromium binary:
const browser = await puppeteer.launch({
 ...
   executablePath: await ***@***.***/chromium/bin`),
 ...
});

--
Reply to this email directly or view it on GitHub:
https://github.com/Sparticuz/chromium/issues/31#issuecomment-1499616742
You are receiving this because you commented.
Message ID: @.***>

Would you have any thoughts on how to fix the issue with _dirname? My code is exactly like the one above. However, I am using esbuild, and for some bizarre reason, the output is only 1.2 MB, and I wonder if it is even bundling successfully. So any advice would be appriciated.

Quick update, the moment I switched it to produce commonjs output, it worked without any issues, so the problem is related to the ESM bundle.

I'm using this with typescript and esm output with a lambda layer without any issues. Generally if you are using some type of bundler is where I've seen issues.

esbuild is AWS recommended one. CDK uses it as well, but the moment I switch the TS config compilerOptions module to CommonJS, it works without any issues, but the moment I set it to esnext, it fails with the error above.

fwiw we are running into the same error. Thought we had it working at one point w/ ESM output, not sure if something changed or if it was actually broken the whole time.

Okay I got it working again. Not sure what the issue was but I

Nuked node_modules, dist directories, and cdk.out directoreis
tweaked our package.json (puppeteer-core went from ^19.8.1 to ^19.8.0 and @sparticuz/chromium went from ^112.0.2)

note that @sparticuz/chromium is just a dev dependency, we use a lambda layer in prod.

Updated the our chromium binary to v112.0.2

For some reason node_modules/@puppeteer/browsers/node_modules/yargs was removed from our package-lock.json. Our stack trace for the __dirname error listed yargs as the originating package for the error so it makes sense that the error is gone now, although I don't know why the package-lock.json changed.

In case someone would like to use esbuild, the only way it worked for me in AWS was as follows.
import * as esbuild from "esbuild";

esbuild.build({
  entryPoints: ["out-rollup/index.js"],
  minify: true,
  bundle: true,
  platform: "node",
  format: "esm",
  target: "node18",
  external: [
    "puppeteer-core",
    "puppeteer-extra",
    "puppeteer-extra-plugin-stealth",
    "puppeteer-extra-plugin-adblocker",
    "@sparticuz/chromium",
  ],
  outdir: "dist",
  banner: {
    js: "import { createRequire } from 'module';import path from 'path';import { fileURLToPath } from 'url';const __filename = fileURLToPath(import.meta.url);const __dirname = path.dirname(__filename);const require = createRequire(import.meta.url);",
  },
  outExtension: {
    ".js": ".mjs",
  },
});

With the code in banner the error of __dirname, __filename and require in ESM are gone.
The downside I found is that by adding @sparticuz/chromium into external my package went from 16MB to 72MB being compressed, uncompressed was 75MB to 131MB.

That's great info. Thanks for posting! If you are on a platform that allows you to use layers, you can use the layer, then use @sparticuz/chromium-min. It's the same package, just without the binaries.

@sparticuz/chromium-min

You are right, I hadn't realized that!
Now the size remains at 20 MB while compressed. It is only necessary to specify the entire path using the layer.
chromium.executablePath("/opt/nodejs/node_modules/@sparticuz/chromium/bin")


feat: startsWith

Hi.
This is for #12.
Brandon

Great job @brandon-m-skinner , merging this one :)


Enable eslint "jsx-quotes" by default

Hi there!
I would be very glad to enable "jsx-quotes" in CRA's eslint by default.
With option "prefer-double" (the default) surely.
I'm ready to create a PR ;)
What do you think?

Hi @kerimdzhanov!
We do not enforce any stylistic rules by default; if you'd like to automate this sort of thing, I suggest you checkout Prettier.
Thanks for the proposal, however!


Multiple rooms and vertical expansion

Hello,
Is there a way to make the module add/show multiple rooms in a horizontal layout instead of vertical?
Thanks

No, but maybe you can do this with custom css.


Cannot read property create range of undefined

I've been using this repo in production for a while. I noticed this error yesterday and after doing some dissecting myself I can't seem to find the issue.
Below is the code I'm using:
$('.comment').suggest('#', {                   data: postIDReverse,                   map: function(id) {                     return {                       value: id, //id.value                       text: '<strong>'+id+'</strong>' //id.value                     }                   }    })
'postIDReverse' corresponds to an array ["post35", "post34", "post33", "post31", "post30", "post28", "post26", "post25", "post24", "post23", "post22", "post21", "post20", "post19", "post18", "post17", "post16", "post15", "post14", "post13", "post12", "post11", "post10", "post9", "post8", "post7", "post6", "post5", "post4", "post3", "post2", "post1"]
The error I'm getting is from bootstrap-suggest.js. I provided a screenshot of the error.
Please let me know if you need any more information. I've been looking into this for a few hours, so I hope I'm not missing something simple.
Any guidance helps!

quick google and it looks like the document.selection is already deprecated.
https://stackoverflow.com/a/19756936/3685987

Thanks for your quick response. So I stumbled upon that StackOverflow post yesterday and looked into it a bit, but went down a rabbit hole. After looking more into it I tweaked
range = document.selection.createRange(); to range = document.createRange(); and I'm getting an output in the console.
Now it's throwing an error with parentElement(). I attached it below:

I'll be looking into this, but if you find a fix let me know.

@NicolasPerl what browser are you using? I can't replicate it cause that code block is suppose to be a workaround if el.selectionStart isn't available (not supported).

would also help if you can provide a jsfiddle so I can see the code you're using.

The error is due to using the rich text editor - quill. It looks like the best way for me to have this mention functionality is to use another package.
If anybody stumbles upon this error and needs a fix I'll be using this.
Thanks for your help @lodev09.
https://www.npmjs.com/package/quill-mention

ahh well that make sense. this package does not support contenteditable. You can use At.js instead :)


ProcessSizeMax type

in Almalinux 9.5 it is specified in Gb like ProcessSizeMax=1G and I think this job should take this into account
https://github.com/ansible-lockdown/RHEL9-CIS/blob/81a929961a0c6049b9d48f180a702a02e73eb2f6/tasks/section_1/cis_1.5.x.yml#L21

hi @Olzhas011
Thank you for the PR, i am not sure which branch you are using. I will raise this fix and hopefully i have found it. This is part of the reason why we asked for the all the information around versions and branches to help us to fix these issues faster.
many thanks
uk-bolly

@uk-bolly
This is in all branches


Adaptive gradient update bug?

Hi,
I'm a CS M.Sc. student from the Technion, Israel, researching applications of word vectors to programming language. Thanks for your code, it's great.
In glove.c, lines 136-144, are the values of temp1 and temp2 a mistake, or should it be like this?
            // learning rate times gradient for word vectors
            temp1 = fdiff * W[b + l2];
            temp2 = fdiff * W[b + l1];
            // adaptive updates
            W_updates1[b] = temp1 / sqrt(gradsq[b + l1]);
            W_updates2[b] = temp2 / sqrt(gradsq[b + l2]);
            W_updates1_sum += W_updates1[b];
            W_updates2_sum += W_updates2[b];
            gradsq[b + l1] += temp1 * temp1;
            gradsq[b + l2] += temp2 * temp2;
temp1 gets the value of W in line l2:
temp1 = fdiff * W[b + l2];
but then gradsq in line l1 is increased with temp1*temp1:
gradsq[b + l1] += temp1 * temp1;
So - I think the values of temp1 and temp2 are swapped. What do you think?
Thanks!

My mistake, deriving the GloVe objective function showed that the code is correct.


Update domains.json

added sub-domain mapping to ens name for snapshot space
Hi! What is your PR about?

[x] Add a custom domain for your space

adding custom domain for our space


Don't commit Paket - we can restore it.

==> Much smaller package

oups. you changed something => merge conflict. Let me rebase

done


Update JSON file

Hey Ihor (@ihorpopyk @ihor-popyk),
Could you please show example on Java code of how to update JSON file using crowdin-java-sdk library.
My JSON file looks like below:
{
  "country.and":"Andorra",
  "country.gbr":"United Kingdom",
  "country.usa":"United States",
  "country.bel":"Belgium"
}

and I need add one line there: "country.ee": "Estonia"
CrowdinApiClient client = new Crwdn();
final Credentials credentials = new Credentials(
        BASE_URL, PROJECT_IDENTIFIER, PROJECT_KEY, ACCOUNT_KEY
);
CrowdinApiParametersBuilder parametersBuilder = new CrowdinApiParametersBuilder();
parametersBuilder.file("angular.json");
// where should I put new row ??
parametersBuilder.language("ru");
ClientResponse response = client.updateFile(credentials, parametersBuilder);

Thanks

Hello @antondozortsev
You just need to add new line to your file (e.g. angular.json) and update all file.
CrowdinApiClient client = new Crwdn(); final Credentials credentials = new Credentials( BASE_URL, PROJECT_IDENTIFIER, PROJECT_KEY, ACCOUNT_KEY); CrowdinApiParametersBuilder parametersBuilder = new CrowdinApiParametersBuilder(); parametersBuilder.files("PATH_TO_FILE"); parametersBuilder.titles("PATH_TO_FILE", "PATH_IN_CROWDIN"); ClientResponse response = client.updateFile(credentials, parametersBuilder);

@ihor-popyk Got it, thanks for answer.
I thought that I can modify JSON file by add new line trough Crowdin REST API to project which is registered in Crowdin.

@antondozortsev ,
you are welcome :)


SW-4770 Scope the subquery for seedbank project stats to the facility so that totalSeedsStoredForProject is scoped to that seedbank

Current dependencies on/for this PR:

main

PR #1669   👈

This stack of pull requests is managed by Graphite.


ci: add back auto-retry for main and docker pipeline

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #11304 , the auto-retry(exit code 255) of pull-request workflow was added back.
Here I add back the retry of main, main-cron and docker workflows, and also retry when the exit code is -1.
Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR contains user-facing changes.

Let's try to use only signal_reason: agent_stop first, if we can't catch 255 errors, then add 255 back.

It seemed to work.
-1 got retried https://buildkite.com/risingwavelabs/pull-request/builds/28595#0189b0ab-6968-4ff1-a61b-f5406670d259

255 got retried https://buildkite.com/risingwavelabs/main/builds/5127#0189b0e2-3adc-4e92-8d3d-f3ce115a2825


As a content editor, I want to list people who contributed to the project so that I can give credit to everyone who was involved in it.

testing notes
designs
desktop / tablet / mobile
you'll need to create a new page in wagtail that has the special type "contributors page". when that's done, you can add new the "person" block to the "contributors" and "board" sections of the page to populate it with people.

Works well on backend! Was able to add people and their titles/descriptions to snippets, and then add the people to the contributor page. We made the body optional for contributor page (since MM revised the content it will be all tiles).
Frontend looks good after we made the following changes:
We decided to wrap long titles for desktop because they were running together on 13" Macbook.
We also pushed an update for hyperlinked tiles to open in a new tab.


Lane markers

Hello, I tried:
Image inference
python hybridnets_test.py -w weights/hybridnets.pth --source demo/image --output demo_result --imshow False --imwrite True
And it worked for drivable regions, but it does not show road lanes
How to get those road lanes?
Thanks!

Solved, it actually showed lanes but in a bad contrast color.


Black Screen during 'downToUp' transitions in Flutter 1.17.1

Hi,
I'm having a problem after upgrading to flutter 1.17.1.
On previously working 'downToUp' transitions, I'm now seeing a black box in the upper part of the screen. Its almost like downToUp is partically rightToLeft before moving upwards. By the way I'm using a Stack with a Scaffold.
Sorry, not able to paste code.

Same. Happens with me most of the time when using a combination of different transitions. Say A to B is right to left and B to C is down to up. In these cases, there is a black screen in between B to C and it looks ugly. I don't know possibly I must be doing something wrong. Using the original MaterialPageRoute avoids this problem.

Still happen on version +5. The first navigation is OK, but the next navigation from the first one will have the black animation. Please fix that. Really appreciate. Thanks.


add improvement in simpletoken example #1458

Fixes #1458

This PR add an improvement to the SimpleToken example class.
The improvement is adding the class ERC20Detailed as a super class of SimpleToken, so we can reuse name, symbol and decimals values from that superclass.

Looks good !


Store playlists (lists of recordings)

UPF.
Scholars.

What is the status of this @alastair

This is possible using the MusicPlaylist type.


[ERROR - null] Analysis task was cancelled

Getting ERROR - null
from Log:
2018-11-11 21:01:47,271 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?debug)
2018-11-11 21:01:47,271 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?minimatch)
2018-11-11 21:01:47,271 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?tough-cookie)
2018-11-11 21:01:47,271 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?request)
2018-11-11 21:01:47,270 org.owasp.dependencycheck.Engine:1092
ERROR - null
Analysis task was cancelled.
2018-11-11 21:01:47,271 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?http-proxy-agent)
2018-11-11 21:01:47,271 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?tough-cookie)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?https-proxy-agent)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?concat-stream)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?lodash)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?cryptiles)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.Engine:1093
DEBUG -
java.util.concurrent.CancellationException: null
at java.util.concurrent.FutureTask.report(FutureTask.java:121)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at org.owasp.dependencycheck.Engine.executeAnalysisTasks(Engine.java:767)
at org.owasp.dependencycheck.Engine.analyzeDependencies(Engine.java:671)
at org.owasp.dependencycheck.App.runScan(App.java:250)
at org.owasp.dependencycheck.App.run(App.java:184)
at org.owasp.dependencycheck.App.main(App.java:69)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?debug)
2018-11-11 21:01:47,272 org.owasp.dependencycheck.analyzer.DependencyBundlingAnalyzer:286
DEBUG - IdentifiersMatch=false (package-lock.json, package-lock.json?minimatch)
...

What version of dependency-check are you using?
Is the project you are scanning open source? (i.e. is it possible to download and attempt to recreate the issue on our side?)

we are always using the latest version of the docker image (docker pull owasp/dependency-check)
No open souirce, download not possible

Through a process of elimination this problem is happening in my above example due to the RetireJS analyser.

@jeremylong Do you need any more information for this issue?

Sorry for the delay. As you are mirroring the NVD your build system likely can't reach out to the github to pull down the retireJS repository (located here: https://raw.githubusercontent.com/Retirejs/retire.js/master/repository/jsrepository.json).  We just added (within the last few days) the ability to easily configure this URL.
When 5.0.0 (or possible 5.0.0-m3) is released you should be able to configure the retireJS analyzer's URL and resolve the above problem.


[1429] snc serializer part 7

Context
search and compare serializer part 7
Provider enrichment/fallback for contact info related fields
Changes proposed in this pull request
Added provider related contact info related serialization
Guidance to review
Branched from part 4 to share full address generation
Checklist

[ ] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[ ] Rebased master
[x] Cleaned commit history
[ ] Tested by running locally

 [L] Serialize course to sync with search-and-compare


Improve G123 and H12 performance

Here we speed up G123 and H12 computations by using a faster approach to hashing.

N.b. G123 is still relatively slow as most of the time is in retrieval of genotype data, but this does still make a difference.


Change use of client_handshake in oinq due to oinq version update

Removes the agent_id provided by the argument. This value is provided by the certificate.
Update review version to 0.22.0.

Codecov Report
Patch coverage has no change and project coverage change: +0.01 :tada:

Comparison is base (5448701) 5.24% compared to head (6f4e0db) 5.26%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #55      +/-   ##
========================================
+ Coverage   5.24%   5.26%   +0.01%
========================================
  Files          7       7
  Lines        686     684       -2
========================================
  Hits          36      36
+ Misses       650     648       -2

Impacted Files
Coverage Δ

src/main.rs
0.00% <ø> (ø)

src/request.rs
0.00% <0.00%> (ø)

src/settings.rs
0.00% <ø> (ø)

src/subscribe/tests.rs
31.03% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

선행 이슈: https://github.com/aicers/giganto/issues/403


Add docs and github integration

I talked with @rsignell-usgs  this morning and he mentioned needing a better place for the examples than as functions inside the codebase.
I set up a quick Sphinx documentation site, where I did an autodoc generation of the two classes (SingleHdfToZarr and MultiZarrToZarr) which will update when docstrings are updated, as well as an examples page where the code from the two examples are now visible.
I'm open to feedback or discussion on what you all think should be added/removed/tweaked before this is pulled in. I have a test doc site added here:
https://lsterzinger.github.io/fsspec-reference-maker/
Let me know what you think!

Ok to merge this and iterate?

Merging this now, and we can figure out whatever extra changes may be required afterwards.

@martindurant I believe whoever owns the repo needs to enable Github Pages and Github Actions. The action that I included should push to a branch called 'gh-pages'. I believe I had to create an empty branch with that name in my fork in order to get Github Actions to push the docs correctly.

Can you check the log of my push https://github.com/intake/fsspec-reference-maker/runs/2999637344 to see if it did the right thing already?

Looks like the workflow was tracking master instead of main, I opened #42

It seems like we're getting the same error here as I was getting in my tests. https://github.com/intake/fsspec-reference-maker/runs/2999729567
The job is failing because there's no gh-pages branch to push the docs to. I don't think this can be accomplished via PR, but I think pushing an empty branch to gh-pages should be all that's needed. I believe I did:
git checkout --orphan gh-pages
git rm -rf .
git commit --allow-empty -m "initial commit"
git push origin gh-pages

OK, I did that. Let's see what happens when I (or you) next push something.

You should be able to click 're-run jobs' at the top of
https://github.com/intake/fsspec-reference-maker/runs/2999729567
On Tue, Jul 6, 2021 at 7:27 AM Martin Durant @.***>
wrote:

OK, I did that. Let's see what happens when I (or you) next push something.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/intake/fsspec-reference-maker/pull/36#issuecomment-874809257,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTH32WBZXNWARZIWF3ELSDTWMHERANCNFSM47KP455A
.

Done. Did it work?
https://github.com/intake/fsspec-reference-maker/runs/2999940010

(if yes, we should update the README to point to the doc page)

Looks good! https://intake.github.io/fsspec-reference-maker/
I created #44 to add a badge to the readme


Cannot import react-kronos

Just upgraded to 1.1.0 and we now get an error Error: Cannot find module 'react-kronos'.
It looks as though what is being published to npm needs to be a bit different, perhaps remove all of the dev stuff and define an entry point in your package.json

same here :+1:

I'll take a look! Sorry for not seeing this early, I somehow didn't get a notification

Should be fixed in 1.1.1 :)


Add upsert to HTTP API

As described in this issue (https://github.com/arangodb/arangojs/issues/325#issuecomment-307441818), I'm wondering if there are any plans to add upsert to the HTTP API (outside AQL)?
This would allow wrappers that are built on top of the HTTP API to add an upsert method.

Note that depending on your usecase you might suceed with a "pseudo upsert" with:
collection.import_bulk(...., on_duplicate="replace")
see: https://docs.arangodb.com/3.1/HTTP/BulkImports/ using the "import" HTTP API.

@coldcoff Thanks, that could work. Having an upsert method could still help to simplify this functionality in wrappers, though.

Yes ;-)
... and please see also https://github.com/arangodb/arangodb/issues/2523#issuecomment-308025153 for one more reason to prefer such collection inserts/upserts over AQL.

+1 on this - would greatly increase Arango utility if this was supported out of the box (add UPSERT to HTTP API). I've got a use case, but dropping down to AQL and figuring out all that stuff at POC stage is too much of a cognitive overhead.

+1 - for ref.. https://stackoverflow.com/questions/18470588/in-rest-is-post-or-put-best-suited-for-upsert-operation

+1 for this. Any chance we see this?

Thanks for reraising!
One challenge here is how to access the old document, for which there is a defined syntax in AQL
INSERT { page: "index.html", counter: 1 }
UPDATE { counter: OLD.counter + 1 }
IN pageViews```
but not in the http API.
Having that said, did you have a chance to look at the insert overwrite mode?
https://www.arangodb.com/docs/devel/aql/operations-insert.html#setting-query-options
(Please note that some of these options are new to the upcoming 3.7 version).
I actually have an interactive jupyter notebook for exploring the different behaviors :-).
https://colab.research.google.com/github/joerg84/ArangoDBUniversity/blob/master/Upsert.ipynb

We will keep this issue open as it is still not added to the http api, but maybe this helps for background and maybe even a workaround using `insert` with overwrite...

Having that said, did you have a chance to look at the insert overwrite mode?
https://www.arangodb.com/docs/devel/aql/operations-insert.html#setting-query-options

I think (and it's two years since I raised this initially) the original goal was to import data from github and then with each import add extra data to relations - for example :
REPO -*-> PR -*> COMMENTS <- USER -*-> REPO

So we could just fire and forget and add extra comments to a PR, etc, just adding on every run of the importer rather than have to pull the graph - figure out the structure and then manually update branches - complicated yes, but the thinking was to avoid the network round trip.

Thanks, as far as I understand that should be possible with "overwriteMode : update", given that you have the primary key of doc. Feel free to ping me in a DM to discuss how that would look like for your queries!


Adding dataset ARletta

Hello !
Here is our dataset YAML file:
schema: https://htr-united.github.io/schema/2023-06-27/schema.json
title: ARletta
url: zenodo.org/records/11191457
authors:
 - name: Lith
   surname: Lefranc
 - name: Ilja
   surname: Van Damme
 - name: Thibault
   surname: Clérice
 - name: Mike
   surname: Kestemont
institutions:
 - name: University of Antwerp
 - name: National Institute for Research in Digital Science and Technology, Paris
description: Open-source handwritten text recognition models for historic Dutch
project-name: Bias in History
project-website: https://www.bias-in-history.eu/
language:
 - nld
 - fra
production-software: eScriptorium + Kraken
automatically-aligned: false
script:
 - iso: Latn
script-type: only-manuscript
time:
 notBefore: '1600'
 notAfter: '1940'
hands:
 count: more-than-10
 precision: estimated
license:
 name: CC-BY-SA 4.0
 url: https://creativecommons.org/licenses/by-sa/4.0/
format: Page-XML
volume:
 - metric: lines
   count: 431359
 - metric: regions
   count: 44536
 - metric: pages
   count: 10267
 - metric: characters
   count: 14253206
transcription-guidelines: diplomatic transcription: all of the text was transcribed verbatim, preserving all of its original features:
 - orthography: preserve original spelling
 - abbreviations: do not expand abbreviations
 - capitalization: retain original use of uppercase and lowercase letters
 - punctuation: transcribe punctuation marks exactly as they appear, even of they are unconventional by modern standards
 - special characters: include any special characters or symbols as they appear
 - formatting: maintain original formatting such as underlining or strikethrough
 - errors and corrections: include all errors and corrections found in the text
 - non-interpretative: avoid interpreting or modernizing the text
 - use the '@' symbol for characters you can not read an tag them as 'unclear' on baseline level
 - tag marginal text as 'marginalia' and main body text as 'paragraph' on region level

Hello Lith,
Thank you very much for this contribution and sorry for the late response! I have created a PR corresponding to the addition of the dataset card in the catalog.
Regarding the description of the transcription guidelines, I think the description could be improved. Could you provide more details or refer to a transcription rulebook published somewhere else?
I have a remark that is not linked to the addition to HTR-United: on the Zenodo repo, you mention twice "/datasets/antw-expert: the image files and preprocessed transcription files for the Antwerp data (annotated by the expert);". Is the repository missing something or is it a typo?

Hello Alix,
Thanks for your remark on the Zenodo repository. That is a typo indeed. I have corrected it.
Considering the transcription guidelines: do the adjustments suffice?
Thank you!
Best wishes,
Lith

Hello,
Perfect, I just updated the yml file and merged the entry to the catalog :)
Thank you again for your contribution!


SQLDatabaseChain sharing data that's not in database

Issue you'd like to raise.
Okay I have tried both SQL database chain and create SQL agent from agents and what i have seen is that after run and it returns zero records from the database and LLM gives the output from its own. So basically I have only one fruit in my database and if I ask what fruit contains vitamin c which is not in the database and it fetch me the result from its own knowledge base.  I tried adding the instructions in the prompt like if query return zero records or observation is empty or the result of the SQL. Query is empty, Do not share anything on your own And just convey the message to the user that for your certain filter criteria that is no records Try different query or elaborate your request but it doesn't seem to be working. is there anyting we can do to fix it?
Suggestion:
No response

@dosu-bot what return_direct will do?

@dosu-bot, how can I change the run function in agents for create_sql_agent?

@dosu-bot, I'm trying to use the Router using Lcel and can I use sql chain and llm chains?
from langchain.chat_models import ChatOpenAI
from langchain.schema.output_parser import StrOutputParser
from langchain.schema.runnable import RunnableBranch
general_prompt = PromptTemplate.from_template(
"You are a helpful assistant. Answer the question as accurately as you can.\n\n{input}"
)
prompt_branch = RunnableBranch(
(lambda x: x["topic"] == "math", math_prompt),
(lambda x: x["topic"] == "physics", physics_prompt),
general_prompt,
)
from typing import Literal
from langchain.output_parsers.openai_functions import PydanticAttrOutputFunctionsParser
from langchain.pydantic_v1 import BaseModel
from langchain.utils.openai_functions import convert_pydantic_to_openai_function
class TopicClassifier(BaseModel):
"Classify the topic of the user question"
topic: Literal["math", "physics", "general"]
"The topic of the user question. One of 'math', 'physics' or 'general'."

classifier_function = convert_pydantic_to_openai_function(TopicClassifier)
llm = ChatOpenAI().bind(
functions=[classifier_function], function_call={"name": "TopicClassifier"}
)
parser = PydanticAttrOutputFunctionsParser(
pydantic_schema=TopicClassifier, attr_name="topic"
)
classifier_chain = llm | parser
from operator import itemgetter
from langchain.schema.output_parser import StrOutputParser
from langchain.schema.runnable import RunnablePassthrough
final_chain = (
RunnablePassthrough.assign(topic=itemgetter("input") | classifier_chain)
| prompt_branch
| ChatOpenAI()
| StrOutputParser()
)

@dosu-bot, how can use tracers elapsed time with sqldatabsechain?


Using snakemake -q all hides SLURM error messages

Snakemake version
$ snakemake --version
8.24.0

Describe the bug
I am using snakemake (actually via Python) on Linux but find if run in quite mode (--quiet all) this does not report SLURM error messages.
Minimal example
This example fails with a clear error message (there is no profile setup with SLURM settings):
$ rm -rf *.md5; \
  snakemake --executor slurm -s demo.smk -p $(for f in *.fna; do echo $f.md5; done); \
  echo Finished with return code 0
Error: maximum number of parallel jobs/used nodes has to be specified for remote execution (use --jobs N with N being a number >= 1)
Finished with return code 0

This is a clear actionable failure message.
(There is a separate problem here in that snakemake ought to have given a non-zero return code)
However, if I add --quiet all or -q all this hides the error message about needing to supply --jobs N:
$ rm -rf *.md5; \
  snakemake --executor slurm -q all -s demo.smk -p $(for f in *.fna; do echo $f.md5; done); \
  echo Finished with return code 0
Finished with return code 0

For reference, adding --jobs 10 then seems to start but waits indefinitely, without quiet mode at least there is a clue: No SLURM account given, trying to guess.
Additional context
The example demo.smk is a per my recent report issue #3152 about quiet mode not being quiet enough.

hm, I cannot reproduce your zero error code:
$ snakemake .... # all settings in the profile, no special flags
...
Error: maximum number of parallel jobs/used nodes has to be specified for remote execution (use --jobs N with N being a number >= 1)
$ echo $?
1

If run with -q, it gives the same error and exit code. With -q all the error message is suppressed and the exit code remains. With -q "" (the empty string example), I get the same error and exit code as you.
The executor will attempt to submit without an account. A cluster with only default accounts is considered one with an unorthodox setup, hence the message. If your jobs are correctly submitted and kept in the queue / partition, the reason for it might be outside of Snakemake's influence. This is something we might have to discuss or investigate.
This leaves the command line interface help message. To me, [...] means: “May be omitted” / anything within the square brackets is optional. Like in [--configfile FILE [FILE ...]], where one file is mandatory, the other(s) not. When you indicate an empty string, you do give an argument, albeit not a valid one, hence the error message. Does this make sense?
You write, that

Specifically the choices does no make it clear that it can alternatively have no argument

Yet, the quoted help message states

If used without arguments, do not output any progress or rule information.

So, no argument is fine. Then the run will be quite, except for warnings and errors.

Some tools will accept an empty string, but that or no argument both seem confusing to me. Getting back to:
% snakemake --quiet "" ; echo "Return code $?"
...
snakemake: error: argument --quiet/-q: invalid choice: '' (choose from 'all', 'host', 'progress', 'rules')
Return code 2

Can you tweak the error message for a bad option to say something like:
snakemake: error: argument --quiet/-q: invalid choice: '' (choose from 'all', 'host', 'progress', 'rules', or no argument at all)

Or (and I think this would be clearest), give the no-argument "do not output any progress or rule information" an alias like "silent"? Then you can list "silent" in the command line help explicitly (and retain the no argument behaviour for backward compatibility).

Apologies. Embarrassingly it looks like at some point in my testing copy-and-pasting commands, $? got evaluated and replaced with 0, so the echo command was literally echo Finished with return code 0 😞
I'm writing this from a different machine, but that more than likely explains things. Opps. Here the tests are working, in that they return a non-zero value:
% rm -rf *.md5; \
  snakemake --executor slurm -s demo.smk -p $(for f in *.fna; do echo $f.md5; done); \
  echo "Return code $?"
Error: maximum number of parallel jobs/used nodes has to be specified for remote execution (use --jobs N with N being a number >= 1)
Return code 1

% rm -rf *.md5; \
  snakemake --executor slurm -q all -s demo.smk -p $(for f in *.fna; do echo $f.md5; done); \
  echo "Return code $?"
zsh: no matches found: *.md5
Return code 1

(zsh is more verbose about non-matching wildcard expansions than bash)

Some tools will accept an empty string, but that or no argument both seem confusing to me.

I'm afraid, but this is due to the default behaviour from the argparse module in Python. If a tool accepts an empty string, that tool still receives an argument from the command line. But, yes, we could adapt the handling. I will take it on me to code a proposal. But understand, that it's not high on my list of priorities at the moment. If you want to go ahead, please let me know of your PR.
As to your last posts: That is actually matching my observation — regardless of verbosity, we get the same error code. And, of course. Is your concern, that the error message itself is suppressed, too?

Yes, I don't think the error message should get hidden - in this example:
Error: maximum number of parallel jobs/used nodes has to be specified for remote execution (use --jobs N with N being a number >= 1)


Update README to reflect python3 commands

Update commands to python3 because python2 is deprecated since Jan 2020

This is a necessary change, without which the sample program won't run if a developer only has the README.md to go by

Your pull requests assumes a user has a version of python 3.X installed, and that the installation is likely an addition to a previously added python version. The python vs python3 commands are environment specific, and do not reflect the limitations of the sample code provided.  For example, one could create a new symbolic link to the python command when two or more versions are installed on the development machine without changing the sample code to make the code run as-is simply by linking the python command to the python3 command.
sudo ln -sf /usr/bin/python3.14 /usr/bin/python


⚠ Bofrost.es has degraded performance

In d40bb0a, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1547 ms

Resolved: Bofrost.es performance has improved in 1a65e0e after 8 minutes.


feature request: localpart option for matrix nicks

matterbridge version: 1.6.0-dev d30ae19
Right now when I bridge matrix with any other service (IRC/XMPP for example), and I use {NICK} as the RemoteNickFormat on the side that isn't matrix NICK comes out as username:matrix.org. I would like to propose a new option for RemoteNickFormat that is LOCALPART which will only send the local part of a matrix username (trim the :matrix.org part).

Did you try this option? #160
#Whether to send the homeserver suffix. eg ":matrix.org" in @username:matrix.org
#to other bridges, or only send "username".(true only sends username)
#OPTIONAL (default false)
NoHomeServerSuffix=false

@42wim ah perfect. I didn't see that in the wiki, let me add that now. Thanks :)


Bookmark animations play twice (sometimes)

Description
Bookmark animations sometimes play twice.
To Reproduce
Enable animations and choose any bookmark animation sometimes before going to the website the bookmark animation plays twice.
System Info
Fedora 40 workstation
Firefox 129.0
mtab V1.3.8
Video of the issue
Screencast from 2024-08-15 02-35-53 (trimmed).webm

It should be fixed in release 1.3.9

This should be fixed now.


Fix coverage reports from Linux boxes

Currently, Linux boxes on Travis fail to calculate test coverage for our code. OS X works fine, so the issue is not pressing, but it should be fixed sometime anyway.

This has been fixed in f5d3fcb (or maybe even earlier).


Add searching algorithms in c

Add binary search and linear search in c.

Hi @bhaviya18 ,
I want to work on this issue please assign it to me . Thankyou!

Hi @bhaviya18 ,
Could you please assign me this issue?

Please assign this issue to me under Hacktoberfest2024


chore(release): bump version to 0.8.0

Also removes Gopkg references in base.Dockerfile
I'm cutting before we add the registry pods and to fix the current openshift 4 release (which is  missing the operatorgroup CRD)
As a reminder, the release process is:

bump OLM_VERSION
tag in github and gitlab
wait for images to build
new PR with correct image references to cut the release.

We definitely need to revise this process, but for now let's just cut.

/lgtm


dotnet publish-iis: Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>

Hey,
Using the "Microsoft.AspNetCore.Server.IISIntegration.Tools" the following error occurs:
D:\DEV>dotnet publish-iis  -p "D:\Lixo\oo" Configuring the following project for use with IIS: 'D:\Lixo\oo' No web.config found. Creating 'D:\Lixo\oo\web.config' Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The system cannot find the file specified.
The project itself is referencing Newtonsoft.Json 8.0.3
Any ideias why this packages is referencing this specific version?

This tool is not in a functioning state at the moment. I am working on fixing it but it may take a few days.

I want to deploy this to Azure [AppService]... I am totally dying here!!!
Unsuccessfully tried aspnet/Hosting#672 which miserably fails with HTTPS....
Also believe aspnet/KestrelHttpServer#698 adds to the mix...
Any lights or assistance?

cc @davidfowl

@LeandroPT can you share your project.json? This may be related to a nuget bug in "imports". cref https://github.com/aspnet/EntityFramework/issues/5022#issuecomment-209704617

We have a repro project here: https://github.com/aspnet/dotnet-watch/issues/72

@LeandroPT you can manually generate the web.config file, without publish-iis. Here's a sample file https://github.com/victorhurdugaci/projectk-build-stats/blob/master/src/BuildDashboard.Server/wwwroot/web.config

@victorhurdugaci nit: The log extension (with timestamp) will be added automatically.
stdoutLogFile="..\logs\stdout.log" to stdoutLogFile="..\logs\stdout"
... but it won't break the way you have it.

A little context:
I already have this running on RC1, what i did was to create a brand new project and use the CIDev bits with RC2.
project.json is attached....project.json.txt
Startup
          var builder = new ConfigurationBuilder()
              .SetBasePath(Directory.GetCurrentDirectory())
              .AddJsonFile("config.json", true)
              .AddEnvironmentVariables()
              .AddCommandLine(args)
              ;
           Configuration = builder.Build();

           IWebHostBuilder hostBuilder = new WebHostBuilder()
                       .CaptureStartupErrors(true)
                       .UseConfiguration(CoreStartup.Configuration)
                       .UseContentRoot(Directory.GetCurrentDirectory())
                       .UseKestrel()
                       .UseIISIntegration()
                       .UseStartup<CoreStartup>()
                       .Build();
           host.Run();

Won't work with HPH on Azure. You need the AspNetCoreModule on Azure Apps ... they're working on it according to @Tratcher with no ETA.

HPH?

HttpPlatformHandler ...sry ... acronyms everywhere :smile:

It's like i said: Unsuccessfully tried aspnet/Hosting#672 which miserably fails with HTTPS....
The thing is that i see alot of focus on Linux and other things... but on RC2 the latest bits allows me to use it, some required things got fixed from RC1, however i cannot run it either on Azure....

It is interesting, the priority was not Azure/IIS.. They are having fun with docker/*nix/Mac and whatever... I can see why... but it kills my project... again...
So the bottom line is, either i am a crappy reader, or bits are missing and i rest and nag around about dates :) aspnet/Mvc#4275

You can run on an Azure VM/IIS with ACM (AspNetCoreModule). At least when the module rolls out on Azure Apps, it would be a simple matter to just deploy it with no or minimal changes.

Yeah Rex, i could even build a container...

Found out the problem... Had old Tools and multiple versions installed.
It seems that cli does a First()..
Cleared tools folder, restored and no errors.

@LeandroPT - this?

@moozzyk Nope. Apparently on "my machine" it uses the 1st version of the tool.

Did you have -* in the version? Did you restore packages in this app (i.e. are you sure the project.lock.json was not stale - if you restore the new version of the tool in a different project then you would end up a new package version in the cache but project with older project.lock.json files would continue to use the old version since lock file contains specific versions).

@moozzyk
Yep :smile: .. It is proved... Very lazy

@LeandroPT Looks like this one is resolved. Please file another issue if you still have problems.


Create anaconda-deploy

@bodom0015  Thank you so much for your input on the conda workflow! I learned a lot in the process, and I was able to create a  testing workflow myself. I modified the workflow you created slightly so that the packages are now built in a matrix run on 3 major OS. Seems like the uploads are going through!


Invoke discovery of undiscovered server device in OME

Requirement Breakdown
Details

Objective

Authentication/Authorization

List of the tasks in the workflow (in   order)

Module type: Library and/or executable

Input and format

Expected output and format   Export required

Concurrency requirement.

Execution model: synchronous or   asynchronous

Applicable timeouts and retries

Expected error handing

Expected domain specific validation

https://github.com/dell/omivv/pull/27


Add synthetic GC double map test to Mac OSX

Depends on: https://github.com/eclipse/omr/pull/5580
Depends on: https://github.com/eclipse/openj9/pull/10714
Signed-off-by: Igor Braga<EMAIL_ADDRESS>

Dependent PRs have been merged. This PR is ready

jdk11 j9 xlinux: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4703
jdk11 j9 mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4704 - fails (does our nightly build of j9 still not have the upstream code change?)
jdk8 j9 mac: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4705

@bragaigor - is the expectation that this test is enabled in jdk11 as well?  See above that the Grinder on mac passed in jdk8 but failed for jdk11 with:
SyntheticGCWorkload_DoubleMap_J9_0 Start Time: Fri Nov 13 16:25:25 2020 Epoch Time (ms):<PHONE_NUMBER>808
variation: -Xmx2g -Xdump:none -Xgcpolicy:balanced -Xgc:enableArrayletDoubleMapping -verbose:gc
JVM_OPTIONS:  -Xmx2g -Xdump:none -Xgcpolicy:balanced -Xgc:enableArrayletDoubleMapping -verbose:gc
JVMJ9GC040E Unknown option: enableArrayletDoubleMapping
JVMJ9VM015W Initialization error for library j9gc29(2): Failed to initialize; unable to parse command line
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

@ShelleyLambert - I'm not sure why https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4704  failed. Doesn't both JDK8 and JDK11 fetch the same OpenJ9 branch?
And yes, the test is expected to run in JDK11. And I've been using JDK11 in my tests as well, so I'm not sure why it failed

Thanks for confirming @bragaigor
Checking what is being served up from Adopt API:
j9 jdk11 nightly
11:24:52  =JAVA VERSION OUTPUT BEGIN=
11:24:52  openjdk version "11.0.9" 2020-10-20
11:24:52  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11-202011022339)
11:24:52  Eclipse OpenJ9 VM AdoptOpenJDK (build master-40f5a9615, JRE 11 Mac OS X amd64-64-Bit Compressed References 20201102_801 (JIT enabled, AOT enabled)
11:24:52  OpenJ9   - 40f5a9615
11:24:52  OMR      - 4ede03ca6
11:24:52  JCL      - 39a80556b5 based on jdk-11.0.9+11)
11:24:52  =JAVA VERSION OUTPUT END=
j9 jdk8 nightly:
11:34:15  =JAVA VERSION OUTPUT BEGIN=
11:34:15  openjdk version "1.8.0_275-internal"
11:34:15  OpenJDK Runtime Environment (build 1.8.0_275-internal-202011121744-b01)
11:34:15  Eclipse OpenJ9 VM (build master-06760669e, JRE 1.8.0 Mac OS X amd64-64-Bit Compressed References 20201112_761 (JIT enabled, AOT enabled)
11:34:15  OpenJ9   - 06760669e
11:34:15  OMR      - cb2c463ee
11:34:15  JCL      - 04fa7040 based on jdk8u275-b01)
11:34:15  =JAVA VERSION OUTPUT END=

Respin jdk11 with latest release build (instead of nightly, which seems stale):
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/4706

Ah I see, the OpenJ9 change that enables double mapping was merged 10 days ago here: https://github.com/eclipse/openj9/commit/71c942fe2e9f673f2ab85534a065e0734c88f94b
And the j9 jdk11 nightly build fetched OpenJ9 - 40f5a9615 branch which is 14 days old. While j9 jdk8 nightly: fetched a fairly recent branch which is up to date as of yesterday. Which explains why JDK8 test passed and JDK11 failed.

Argh, latest release from API also looks stale:
12:39:12  =JAVA VERSION OUTPUT BEGIN=
12:39:12  openjdk version "11.0.9" 2020-10-20
12:39:12  OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
12:39:12  Eclipse OpenJ9 VM AdoptOpenJDK (build openj9-0.23.0, JRE 11 Mac OS X amd64-64-Bit Compressed References 20201023_788 (JIT enabled, AOT enabled)
12:39:12  OpenJ9   - 0394ef754
12:39:12  OMR      - 582366ae5
12:39:12  JCL      - 3b09cfd7e9 based on jdk-11.0.9+11)
12:39:12  =JAVA VERSION OUTPUT END=
I had assumed the builds published today would have been served up already.
Respin from today's build:


Update ScheduleView.tsx

Build new "dayPreview" schedule entry, make schedule for preview event.
Admittedly I am not set up with a dev environment at the moment so can't test that this doesn't break anything big...

...I can't figure out what the 'proper' brace style is, and can't get my dev environment set up, so someone's gonna have to fix that lint issue for me, sorry.


Fenics 1.4 miss dependencies (boost ==1.55.0)

Following
conda create -n f14 python=2.7
source activate f14
conda install "fenics=1.4.0" mkl --channel https://conda.binstar.org/juanlu001/channel/fenics:1.4.0:centos

fails with unmet dependencies.
Error:  Dependencies missing in current linux-64 channels:
  - fenics 1.4|1.4.0* -> dolfin ==1.4.0 -> eigen3
  - fenics 1.4|1.4.0* -> dolfin ==1.4.0 -> boost <=1.55.0
  - fenics 1.4|1.4.0* -> boost ==1.55.0

(Tried on centos 6 and mint 17.3)

Hm, the instructions for CentOS are particularly outdated. I'll have to take a closer look on this.

Any news on this? I'm having this same issue.


Development: Improve files assertions in server tests

Checklist
General

[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.

Motivation and Context

AssertJ offers different assertions related to files, that not all tests utilize. Some assertions are too long and not as clear as they could be.
Description

In this PR I replace assertions related to files with better suited AssertJ assertions such as exists(), doesNotExist(), hasContent(..) and others.
Review Progress

Look through the code and see if the new assertions make sense. Also look if I might have missed some assertions
Code Review

[x] Code Review 1
[x] Code Review 2

Test Coverage

unchanged

Codecov Report

Merging #6635 (ec7d2ae) into develop (9bd981e) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6635      +/-   ##
=============================================
- Coverage      80.41%   80.41%   -0.01%
- Complexity     13588    13589       +1
=============================================
  Files           2399     2399
  Lines          91680    91680
  Branches       12873    12873
=============================================
- Hits           73729    73722       -7
- Misses          9859     9866       +7
  Partials        8092     8092

see 4 files with indirect coverage changes

Flag
Coverage Δ

client
76.13% <ø> (-0.01%)
:arrow_down:

server
85.08% <ø> (-0.02%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd981e...ec7d2ae. Read the comment docs.


Add authentication mechanism

Need to add something like this https://github.com/wrstudios/reso_web_api#authentication, for now, it is good to have a simple Basic strategy.
See: https://swagger.io/docs/specification/authentication/basic-authentication/

@rtershak pls check

LGTM


Problems of checking optional object fields

It seems that when checking objects with optional fields, unexpected behavior occurs. The objects fit the type, but expectType thinks they don't.
import { expectType } from 'tsd';

type FirstExample = {
    example: string | undefined
};

type SecondExample = {
    example?: string
};

expectType<FirstExample>({ example: 'first' });
expectType<SecondExample>({ example: 'second' });

The result of the work:
 ✖  Parameter type FirstExample is declared too wide for argument type { example: string; }.
 ✖  Parameter type SecondExample is declared too wide for argument type { example: string; }.

In typescript playground you can see that this is a valid type:
https://www.typescriptlang.org/play?#code/C4TwDgpgBAYglgJwM7AKIA8CGBbMAbaAXigG8BYAKCmqgi1wIC4oUE4A7AcygB8oBXdgBMIAMw4QhlAL4BuSpVCQoAZQgBjAPbCMOfEVKUatevoD8zVh04z5FSlvYoo45MGbw3uhgZIm9TFAA5K4oQVByDtrOSBraQoxqjkLe+lDEfnQBEMxBscnhckA
I created a separate repository to replicate the problem:
https://github.com/MaksimLavrenyuk/problems-of-checking-optional-object-fields

expectType - Strict type assertions, expectAssignable - t loose type assertion. I get it.


Smart group my droplets

Planning to make droplets list more clear, currently (if #77 gets merged) , supposing 2 projects, multiple servers you'll end up with something like:
ON   foo-db1              <IP_ADDRESS>    @ New York 2      #123456
ON   foo-web1             <IP_ADDRESS>    @ New York 2      #123456
ON   bar-db1              <IP_ADDRESS>    @ New York 2      #123456
ON   bar-web1             <IP_ADDRESS>    @ New York 2      #123456
....

I propose a split and group with '-' hifens:
bar
    ON   db1.foo.com               <IP_ADDRESS>    @ New York 2      #123456
    ON   web1.foo.com              <IP_ADDRESS>    @  New York 2      #123456
foo
    ON   db1.foo.com               <IP_ADDRESS>    @ New York 2      #123456
    ON   web1.foo.com              <IP_ADDRESS>    @  New York 2      #123456
    ....

Kinda like linode groups. We could also do actions on groups, like god (monit).
You may not provide any hifen, so the listing will be the same. Also, maybe a option to don't group.
Any ideas?

Tagging droplets is now possible through the DigitalOcean API, so integrating into Tugboat should be straightforward: https://developers.digitalocean.com/documentation/v2/#tags

That's pretty cool, should be fairly easy to implement as you say. I might be able to get a basic implementation done on Sunday :)


deduper: Try to make debug_id aware.

Since the deduper creates a separate context the debug_id of the log is not passed on. We should make sure that we can still correlate the outside context within the deduper.
Proposal:

the first request uses the same debug_id as its outside context.
all deduped requests log a message Waiting on deduped reply debug_id=...., dedupe_debug_id=...

deduper is no longer used


uses AR Collection klass method

Type of PR (feature, enhancement, bug fix, etc.)
Minor enhancement
Description
Uses the #klass method on a collection to get the class being wrapped.
Why should this be added
#klass returns the collection's class even when it's empty.
User.none.first.class.name
=> "NilClass"
User.none.klass.name
=> "User"

Checklist

[x] My code follows the style guidelines of this project
[x] Checks (StandardRB & Prettier-Standard) are passing

Awesome! Thanks!

@all-contributors add @sas1ni69 for code