Indentation increases with each item

Describe the bug
I'm having a hard time determining if this is intended or not...but it's really annoying and I'm not sure how to disable it, or if I'm just doing something wrong. The problem is that when I'm writing a list, instead of being on the same indentation level, it adds one on the new line. This is super confusing, and it also happens when org_indent_mode is set to noindent.
Steps to reproduce
When I start a list like so (| = cursor):
- List Item|

Then I press enter, I would expect this:
- List Item
|

But instead I get this:
 - List Item
   |

This means that repeatedly adding items gets each one indented an additional level, which is not what I want. If I want another level, I'll add one myself...
Expected behavior
Explained above.
Emacs functionality
Not really sure...I'm not an emacs user, and I'm not in a position to install it and check at the moment, but what demo videos I can find online do not seem to function the way this plugin does...though I think they're doing something more clever that I'm not sure is possible with neovim at all at the moment (with virtual indents and whatnot).
Minimal init.lua
The template works: https://github.com/nvim-orgmode/orgmode/blob/master/scripts/minimal_init.lua
vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])

local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'

local function load_plugins()
  require('packer').startup({
    {
      'wbthomason/packer.nvim',
      { 'nvim-treesitter/nvim-treesitter' },
      { 'kristijanhusak/orgmode.nvim', branch = 'master' },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
    },
  })
end

_G.load_config = function()
  require('orgmode').setup_ts_grammar()
  require('nvim-treesitter.configs').setup({
    highlight = {
      enable = true,
      additional_vim_regex_highlighting = { 'org' },
    },
  })

  vim.cmd([[packadd nvim-treesitter]])
  vim.cmd([[runtime plugin/nvim-treesitter.lua]])
  vim.cmd([[TSUpdateSync org]])

  -- Close packer after install
  if vim.bo.filetype == 'packer' then
    vim.api.nvim_win_close(0, true)
  end

  require('orgmode').setup()

  -- Reload current file if it's org file to reload tree-sitter
  if vim.bo.filetype == 'org' then
    vim.cmd([[edit!]])
  end
end

if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system({ 'git', 'clone', 'https://github.com/wbthomason/packer.nvim', install_path })
  load_plugins()
  require('packer').sync()
  vim.cmd([[autocmd User PackerCompileDone ++once lua load_config()]])
else
  load_plugins()
  load_config()
end

Screenshots and recordings
No response
OS / Distro
Debian 11
Neovim version/commit
0.8.1
Additional context
No response

I guess I'll be more specific about what I'd expect to happen:
After headlines, one indentation level should be added, but if I then type *, it should automatically de-dent. This would essentially fix #72 too.
After a list item, the indentation should stay the same. Increased or decreased nesting of subsequent items should be done by the user.
E.G.:
* Heading
   | <-- Cursor here

After typing *:
* Heading
*| <-- Cursor here

* Heading
   - List item| <-- Cursor here

After typing
* Heading
   - List item
   | <-- Cursor here

If this is the intended behavior and I'm missing something, I'd love to hear what the right way to be doing this is :).

I understand that the behavior you expect makes sense from your point of view, but I think it needs a bit more nuance. E.g.
* heading
  *something bold*

  - list
    --> important!

These would be very awkward to write with what you are proposing. Granted, you're more likely to add a new heading/list-item than doing what I did above. We surely can discuss whether your suggestion would be more beneficial.
Concerning your original issue: the reason (or at least that's how I interpret it) why indentation is added after pressing enter at the end of a list-item, is that you might want to write something that still belongs to the list-item in a new line:
* foo
  - Lorem ipsum dolor sit amet, consectetur adipiscing elit,
    sed eiusmod tempor incididunt ut labore et dolore magna aliqua.
  - Ut enim ad minim veniam, quis nostrud exercitation ullamco
    laboris nisi ut aliquip ex ea commodo consequat.

If you want to add a new list-item, you can use <leader>ENTER (aka Meta-Return) in normal mode, with the cursor on the list-item. This also works on headings, although it will add a new heading right below the heading on which your cursor lies, not respecting the contents of the heading. If you want to add a new heading below the current one with respect to the headings content, press <leader>oih.

I just checked and I can reproduce this with org_indent_mode = "noindent" as well. I don't think that this is intended

Ok, in emacs the list-items still preserve the indentation on <ENTER>, even with org-indent-mode turned off. The behavior we have for list-items appears to be correct. However, we still preserve indentation on headlines, even when org-indent-mode is turned off. That should not be the case

Thanks for responding, @jgollenz!
That's certainly interesting...it kinda feels like it's treating adding a new list item immediately like the edge case rather than the normal thing...but that's just me I guess. If that's the way the original org mode does it, then I guess it's correct 🤷.
Just to add in my perspective a little more I guess, most of the time in other word processors and stuff like that, pressing enter adds a new list item at the same level. If you want to adjust the level, you can normally do this with tab/shift-tab, backspace, or enter, or sometimes all three (i.e. tab increases level, shift-tab, backspace, and enter decrease level). Then shift-enter is often what is used to add a newline without adding a new list item.
 - List item|

Shift-CR:

 - List item
   |

CR:

 - List item
 - |

CR again:

 - List item
|

Tab:

 - List item
   - |

Shift-tab:

 - List item
 - |

Again, just throwing it out there. Compatibility with org mode, at least by default, makes sense. It's just that exiting normal mode and pressing <LEADER><CR> for every new list item feels a little strange to me.

I get your points. Even Github followsHowever, neovim is not a word processor. If you indent text in neovim and then add a new line with <CR> it will also be indented

f

@pianocomposer321 in any case, the title for this GH issue doesn't really describe a bug. Can you please remove the bug label and add the enhancement label? I'll add a separate issue for the bug concerning org_indent_mode

Fair enough, that makes sense. Having  do this would be sufficient.
I'm not actually sure how to change the labels on GH issues lol. I'm not seeing an x or anything to remove the bug label. 🤷

I'm not seeing an x or anything to remove the bug label

I guess @kristijanhusak has to do that then

I ran into the same issue. I think, we should provide org_meta_return also for insert mode. It feels very clunky to have to always exit insert mode when I need a new item (which is - as @pianocomposer321 already stated out) the more expected usecase.
It would allow a user, wo doesn't care about the current behavior to map  to org_meta_return. And if you care about this, you could literally map it to , so you just have to hold Alt with your left thumb while hitting return to get a new item instead of .

Has anyone found a way to create new list items without exiting to normal mode since the last comment?

Support for this was added on the latest nightly branch. You can find docs about it here: https://github.com/nvim-orgmode/orgmode/blob/nightly/DOCS.md#use-enter-in-insert-mode-to-add-list-itemscheckboxestodos

Thanks @kristijanhusak I can confirm that with the minimal configuration using nightly the <S-CR> works. It doesn't work with my current setup though probably due to this issue


Infinite Loading Image on 1.18.1

Yamipa v1.2.2
Paper- Purpur

Protocol lib 4.80

When trying to place any image .png / .gif or anything else it just goes into infinite loading image and no image appears.

Hi, @Miner28!
I cannot reproduce the issue on a new server with:

Purpur 1.18.1 (rev 1562)
ProtocolLib v4.8.0-SNAPSHOT-b540
Yamipa v1.2.2

Could you enable verbose mode and post here the server logs when placing an image?

Hey did so this is logs when placing the image. Do you want the .log file

Please paste the relevant logs as text instead of upload images, seems some log entries are missing the timestamp because the screenshot is cropped.

Update: Downloaded the plugin from GitHub releases and everything suddenly works fine. All images I tried placing before are now in world. Scattered around everywhere, I clicked right click.

Grad to hear! I'm closing the issue.


compile tf-lite error

I want to cross compile some components of tf-lite.So I do these:
bazel build tensorflow/contrib/lite/arm_build:test_only \
      --crosstool_top=@local_config_arm_compiler//:toolchain \
      --cpu=armeabi\
      --host_crosstool_top=@bazel_tools//tools/cpp:toolchain \
      --verbose_failures

in my arm_build folder the BUILD file is:
package(default_visibility = ["//visibility:public"])
load("//tensorflow/contrib/lite:build_def.bzl", "tflite_copts")
licenses(["notice"])  # Apache 2.0
cc_binary(
    name = "test_only",
    srcs = [
        "test.cc",
    ],
    copts = [ "-O3",],
    linkopts = [
    ],
    deps = [
        "//tensorflow/contrib/lite:context",
        "//tensorflow/contrib/lite:framework",
        "//tensorflow/contrib/lite:schema_fbs_version",
    ],
    linkstatic=1,
)

the test.cc is:
#include <stdio.h>
int main(){
  printf("---");
  return 0;
}

Actually I just want to compile the "context,framework and schema_fbs_version" components.
I got like this "error: '_Float128' does not name a type"

If compiled with native gcc ,it is okay.
gcc version 7.3.1 20180312 (GCC)
cross-toolchain 4.9.3 raspberry pi which was downloaded by the Bazel(version 0.11.1)automatically.
OS:  4.15.15-1-ARCH
Can anyone help?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

I managed to bypass this issue by replaced a higher toolchain version than 4.9.3 . Thanks.


Update bazel-toolchains pin.

https://github.com/bazelbuild/bazel-toolchains/issues/216

@ittaiz

I don't have merge access. Please merge whenever you can. Thanks!


Fixes for variables, object type, new tests

Fixed some mistakes I made with variables.
Changed Object annotation to error for null (Flow does this).
Added some failing tests.

@phpnode Do you want to merge this? I'm not going to fix the errors now. Here is the error list https://travis-ci.org/codemix/babel-plugin-typecheck/jobs/85705961

I removed the try/catch in the traverse call so it shows error locations inside functions (like when augmenting variables). Is that ok? Maybe there's a better way to distinguish which errors should appear at the function node.

@fixplz added a few notes, I think we should revert a couple of things in the last PR. As a rule I want this plugin to be complementary to flow, so if flow supports something that we don't, then we should do the best job we can under the circumstances, but not prevent the programmer from using those constructs. Flow covers things that we cannot, and we cover things that flow doesn't support yet, so they can work well together provided that they don't step on each other's toes.

@phpnode just rebased

@fixplz ah I just merged #33 which incorporates your original commits

Consider reversing it, this PR will be cleaner.

@fixplz I'm not a huge fan of rebase for reasons like this, I'd rather leave the history intact even if it's messy.

@phpnode Ok.
I will follow up about the issue of throwing errors for things like type parameters.


Update Hugo to 0.118.2

The latest version has been released, follow the upstream update version information.
Hugo Releases v0.118.2 .

@ydFu, thanks for raising this PR
Is there a particular reason why you think we should upgrade to that version? We normally do upgrades to new versions of the underlying software on the cadence that is needed and doable by the maintainers, so if there is no compelling reason to upgrade, we will not introduce this chance

@ydFu, thanks for raising this PR
Is there a particular reason why you think we should upgrade to that version? We normally do upgrades to new versions of the underlying software on the cadence that is needed and doable by the maintainers, so if there is no compelling reason to upgrade, we will not introduce this chance

@svrnm ,Thank you for the reminder. I noticed that Hugo has the following changes:
v0.118.0

Hugo 0.118.0 now builds with Go 1.21. This version also includes:
Proper CJK support in Markdown.
A revamped implementation of hugo new site and hugo new theme. See details.

v0.118.1

This release only fixes a GLIBC_xxx not found issue with the Linux AMD64 binary when running on older Linux versions, which is the situation when building on Netlify/Vercel, etc.

v0.118.2

Release: Revert to building with Go 1.20.

That's why I raised the version change request. However, I respect that
community normally upgrade to new versions of the underlying software on the cadence that is needed and doable by the maintainers. Therefore, I'm closing this change request.


Added Period attribute to CloudWatch::Alarm MetricDataQuery

Add period to CloudWatch::Alarm MetricDataQuery
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudwatch-alarm-metricdataquery.html

Thanks!


fix: do not call entity detection callback after non-terminal action

:tada: This PR is included in version 0.297.5 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update pod versions.

Fix for this #193
cc @astralbodies, please review.

Looks good thanks @SergioEstevao :shipit:


Convert the OAV to ophyd-async

We should try and get all our devices into ophyd-async. The OAV is one of the last ones left
Note
This is a reasonably large device, it may make sense to split it into multiple issues
Acceptance Criteria

The OAV is converted into ophyd-async
Tests all still pass

https://github.com/DiamondLightSource/dodal/issues/801 should be done first

As part of this we should probably look at how we do the OAVConfigParams. Particularly how they get updated from the device. It may make more sense for them to be derived signals https://github.com/bluesky/ophyd-async/issues/525

As this is a fairly large device and we probably can't have an ophyd-async device with ophyd components (or viceversa), the first step will be to make a new very basic ophyd-async device meeting the minimum needs for i24 serial and then we can add the rest of the functionality as we go along.


How did you determine the size of the TinyLlama model?

Were there any trade-offs or considerations you made when deciding on the model's size? Or What criteria did you use to select the specific number of layers, attention heads and Embedding Size etc. in your model?

I start with Pythia-1.4B/GPT-3 XL's model
config.

I reduce the head dim from 128 to 64. (I believe this is a safe step because: 1. Falcon does that. https://huggingface.co/tiiuae/falcon-7b  . 2. If you look at the GPT-3 family's shape, the GPT3-2.7B used an even smaller head dim compared with GPT-3 XL.

We use GQA and set the number of query groups to 4.
In order to fit the model with 16K per-GPU-batch size, we reduced the number of layers from 24 to 22. Larger batch size leads to higher MFU /throughput.

Thanks for your clarification. Is there any comparison between different number of query groups for 1b models like inference speed and accuracy?


Example 2 (alternate locale) doesn't work in Exchange Online

The above Example 2 doesn't work in Exchange Online. It generates the following error:
WARNING: An unexpected error has occurred and a Watson dump is being generated: Argument objectId is null
Parameter name: objectId
Argument objectId is null
Parameter name: objectId
+ CategoryInfo          : NotSpecified: (:) [New-MessageClassification], ArgumentNullException
+ FullyQualifiedErrorId : System.ArgumentNullException,Microsoft.Exchange.Management.SecureMail.NewMessageClassification
+ PSComputerName        : outlook.office365.com

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a8edfe1-3c01-2130-eb99-483e29c61f0b
Version Independent ID: 800241fb-2ab8-f0a3-7637-0addec012040
Content: New-MessageClassification (exchange)
Content Source: exchange/exchange-ps/exchange/policy-and-compliance/New-MessageClassification.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@Cutriss, confirmed. I changed the text of the example to say it was for on-premises Exchange, and I changed the parameter description for Locale to say that it only works in on-premises Exchange.
Thanks for the feedback.

@chrisda Locale is still a visible parameter in the Exchange Online PowerShell. What is the plan here? I'd love to see locale support for this feature.


Bump tree-sitter version to 0.20

Checklist:

[ ] All tests pass in CI.
[ ] There are sufficient tests for the new fix/feature.
[ ] Grammar rules have not been renamed unless absolutely necessary.
[ ] The conflicts section hasn't grown too much.
[ ] The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

Now that this has merged can we publish a new version on crates.io? tree-sitter and tree-sitter-java have been incompatible for many months now.


The "does not conform to protocol" -Wprotocol refactoring warning should take method availability into account

This also ensures that the "Add missing requirements"
refactoring action doesn't add stubs for methods that
are unavailable or not yet introduced.
rdar://32549953

Thanks, committed to https://github.com/apple/swift-clang
c790745221..4d7cc27fda  upstream-with-swift -> upstream-with-swift


Score with disk resources.

This PR rolls disk usage into Singularity's offer scoring calcs.
It also changes the default relative offer weights to 0.25 cpu; 0.65 mem; 0.10 disk based on the fact that typical apps which Singularity is intended to host are stateless, primarily I/O bound, then CPU bound, with minimal, bounded disk usage.
Still need to update tests to exercise disk resources in tests of SingularityMesosOfferScheduler#score().
/cc @ssalinas

FYI that cluster coordinator change should already be in master. Maybe merge master into this before getting this in staging to avoid additional merge conflicts later on?
Looks good though 👍

typical apps which Singularity is intended to host are stateless, primarily I/O bound, then CPU bound, with minimal, bounded disk usage.

This is likely outside the scope of the PR, but it could be interesting if users were able to set the weights on a per-Request basis.

Aye, that's a cool thought.


Generating higher order mesh.

Do you have an example or a sample code to generate a higher-order mesh, for example, the quadratic triangular mesh given in square-disc-p2.vtk

Hi @Krishna-Dutt,
The square-disc-p2.vtk mesh in particular was generated from the square-disc.mesh using the Mesh Explorer miniapp (miniapps/meshing/mesh-explorer) by giving it curvature (key c) and applying a random perturbation (key j). This miniapp can be used to define other simple high-order meshes e.g. by applying a transformation to a simple domain.
If you are looking for a more general high-order mesh generator, we currently support high-order meshes produced by Gmsh and Cubit.
Hope this helps,
Tzanio

Hi @Krishna-Dutt,
The square-disc-p2.vtk mesh in particular was generated from the square-disc.mesh using the Mesh Explorer miniapp (miniapps/meshing/mesh-explorer) by giving it curvature (key c) and applying a random perturbation (key j). This miniapp can be used to define other simple high-order meshes e.g. by applying a transformation to a simple domain.
If you are looking for a more general high-order mesh generator, we currently support high-order meshes produced by Gmsh and Cubit.
Hope this helps,
Tzanio

Hi,
Yes, that answers my question. Thanks!

Hi,
Yes, that answers my question. Thanks!


Feature request: Pause acceleration

Similar to quitting on a 'q' keyboard input, would it be possible to put the tool into a 'paused' mode on some other key press? Meaning the script would continue to run and display the status, but the acceleration would be fixed to 1. And then on another key input the acceleration logic would enable again.
I usually only accelerate certain parts of a flight, and sometimes also just want to slow down to normal acceleration because of nice scenery etc. So this would be a convenient way to temporarily disable all acceleration, without having to fully quit the tool and restart afterwards. Just a thought...

This is a good idea I've thought about as well but haven't implemented. Shouldn't be very difficult.

Also, the ability to slow down is supposed to be given by switching to heading hold mode, but some aircraft don't report nav mode correctly...you know the ones.

Yeah, I saw the comment in the code... And yep I know the ones 😉

New release is up. Closing this issue.


add genders from csv

I have used Namsor to identify the approx. 4000 persons without a gender. The result is here and could be used to update the PMB:
https://docs.google.com/spreadsheets/d/1DkJoIK-7pZ56K_6rEt0PoFmr-hMdoPsc673KH2uDMFA/edit#gid=1373209059

i've removed the column name and added "id" and "gender"

Thank you!!!


Make apache install not reliant on specific version

Currently apache.sh calls out a specific version of Apache to install. When a new version comes out this breaks the install. See #93.
apache.sh should be modified to pull files from a consistent source. Alternatively, we could use v2.2.x instead of v2.4.x, and we could install via yum. Best solution would be to figure out how to create our own packages (see #29).

This is a duplicate of #80. I'm dumb.


⚠ Bofrost.de has degraded performance

In 0f2290f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 2361 ms

Resolved: Bofrost.de performance has improved in bbe4d5d after 6 minutes.


adding origin property update

Added Referer request header as prop for the google-places-autocomplete component. This update allows for a restricted Google API key as seen in this issue:
https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/140

How to use it? some usage example please?
Also where can I see all the props and methods that are provided by this library? Thanks for the good work

<GooglePlacesAutocomplete query={{ origin: 'http://mywebsite.com' }} />

tried the origin props but still got error message that the API doesn't support referrer restriction.
looked at the source code, it inject the origin to the http header, but it is still rejected though.
maybe google check it with reverse dns?
is there any way to use restricted API key?

@johnsonchandra Sorry, there's no solution for restricted api keys for now

@guilhermepontes change log says restricted api supported is added. Any new progress on this ?
1.3.0 : Added support for React 16 (isMounted() and propTypes bugfix), support for restricted API key and moving from ListView to Flatlist.

@guilhermepontes is this still an issue, if so I'll suggest mentioning it in the docs.  I thought it was a google api's issue for a long time!

I think I found why it isn't working. We should remove origin from query and to put it somewhere else.
I'd suggest that
<GooglePlacesAutocomplete referer='http://mywebsite.com' />
https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/489#issuecomment-611067781


[RCTPerformanceLogger.m:29] Unbalanced calls start/end for tag 5

When more than one RCTRootView exist and share a RCTBridge, it prints "[RCTPerformanceLogger.m:29] Unbalanced calls start/end for tag 5".

cc @tadeuzagallo @javache

cc @tadeuzagallo @javache once more

This is in productpains (unresolved)

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/rctperformanceloggerm29-unbalanced-calls-startend-for-tag-5
Product Pains has been very useful in highlighting the top bugs and feature requests:
https://productpains.com/product/react-native?tab=top
Also, if this issue is a bug, please consider sending a pull request with a fix.


Force redirect when pushState encounters an error

Version 9.1 of Safari allows a maximum of 100 calls to pushState. Subsequent calls to pushState throw a SecurityError: DOM Exception 18: An attempt was made to break through the security policy of the user agent.
This jsfiddle shows the error in action when using Safari v9.1:
https://jsfiddle.net/j1sxxLwy/
In Safari Technology Preview v9.1.1, the implementation is improved to only cap pushState to 100 calls in a 30 second period. This jsfiddle shows that the error is not encountered when there is a delay between pushState calls in Safari Technology Preview v9.1.1, however it is still present in Safari v9.1:
https://jsfiddle.net/885yfab6/
So it seems that in future versions of Safari the pushState check will be improved to only prevent malicious or buggy code from executing. I've provided a fix in the meantime since I'm unsure of the timeline for that enhancement. However, I'd be the first to admit that it's not necessarily the right way to fix this or if a fix even belongs in mithril. Really more interested in starting a discussion on the best way to handle this error, since it seems like other developers using mithril may run into this issue in their applications.

100 calls within 30 seconds equates to about 3.3 calls per second, which is mildly excessive for route changes (that frequency of changes should be in app state, not the URL). As an example that might need to be aware of that limit, Google Maps generally debounces URL updates to roughly once per second AFAICT. Not saying this is an absolute no go, but just thought I'd mention that.
(I do feel the limit should be 200, not 100, but that's not a decision I can make for WebKit.)


Typos

atlas generate model --help

Note: Model name should be singular and lowercase.

What's the typo?

I'm putting the correct text as a quote. Which I now understand is confusing.

f15a26fc0c09b9dc8c8039f141461bd9ad567f53


Implement User & Developer 'tours'

ala http://geonode.org/user_features.html and http://geonode.org/dev_features.html but with screenshots mixed in.

The link in the report are dead and should be replaced by http://geonode.org/user_features/ and http://geonode.org/dev_features/
Not sure how or what is expected though

closing as stale,  If this is still relevant, please reopen
Cheers


output results to json files

Getting things output to file in preparation to finding differences across multiple runs.

From today's chat:
TODO:

write tests which include query param _ember-perf-timeline=true conditionally. need docs about if the user has ember-perf-timeline installed they can leverage this flag directly
i needs to be similar to tracerbench fidelity enum
include a flag to pass a control and experiment rather than need to run the trace command twice
reportlooks for heuristics folder with the --report flag
event --event is the last event to look for to exit
legacy this flag will get the analyze command back to what it was end of last quarter with the stdout. ATM it is also spinning off the .json files (which needs to be removed). some stdout can be massive as such maybe write a --json flag.

analyze is including the the chrome-tracing-events
analyze is also fetching module names rather than mangled method names


Missing Descriptions for Formula Components in haydavies

The formula components for the haydavies function seems to not be properly defined. The current formula is:
$I_{d} = DHI \left( A R_b + (1 - A) \left(\frac{1 + \cos \beta}{2}\right) \right)$
However, the documentation does not provide definitions or explanations for the components $A$ and $R_b$. While $DHI$ and $\beta$ are relatively straightforward, I feel it would be beneficial to include their descriptions for completeness.
Additionally, isotropic, klutcher and reindl   also lack description of formula components.
Request

Update the documentation for the haydavies function to include descriptions for the following components:

$A$
$R_b$
$DHI$
$\beta$

Update the documentation for the isotropic, klutcher and reindl (shall different issues be created for each function?)

I think that providing these definitions will improve clarity.
Thank you!

I do agree that it seems poorly documented and that the other variables should be defined. While we're at it, equations such as these belong in the Notes section of the documentation.
@BernatNicolau are you up for making a PR to improve the haydavies function?

I will try to work on it but I don't think I will be able to prioritize it. I will post a comment when I start to work on the PR, so if anyone feels like doing it, go ahead :)

I'd be happy to work on the documentation for at least one of these functions. I don't want to hijack your work here though @BernatNicolau , let me know if you were planning to make a start soon and/or whether my contribution would be helpful here.
It was nice to meet you at PVPMC btw, happy to see you are already very active now with pvlib!

shall different issues be created for each function?

I think this single issue is sufficient but separate PRs for each function might help with overall organisation of these developments.

@BernatNicolau happy to hear the tutorial was helpful!
I have created a few PRs on this subject. Feel free to leave a review (another great type of contribution) if you have time! Your thoughts on the comments I have left or any of the code edits would be more than welcome. If you'd like some help with using any of the review features on github too then let us know.


Handle exception when dot is not present gracefully

When dot is not present on the system, currently the tool will crash with an exception. This exception should be caught and a meaningful message displayed to the user.

Hi:
I just use the tool to test some other  protocols ,  I  modified the SUL  and used  TLSTestService.java to fit new protocol , and the test passed. But when I used learner.java to learn its statemachine , it runed  some time and  then  the program got stuck after "INFO: Starting round 2", while the  process did not stoped. as a result ,I can't learned the final hypothesis. what's wrong with it ?Thak you!

@IMhappyZzz it's hard to say from this what exactly is going wrong. Could you open a separate issue for this and provide more detailed information?


[SUGGESTION] add a github bot auto deal with outdated issues

Like the description in the picture, for issue that have not been dealt with for a long time, regularly prompts to close.
@danny0405 @yihua @codope

looks great, how can we enable this @yihua ?

We can add a Github action to close stale issues, but I think we should still keep the legit issue open even if it stays there for some time.


Error after upgrading to NativeScript 2.5

nativescript-fresco worked great for me with NativeScript 2.4. But after I upgraded to NativeScript 2.5 I get this error when I try to build my application:
node_modules/nativescript-fresco/references.d.ts(1,1): error TS6053: File '/my-project-folder/node_modules/nativescript-fresco/node_modules/tns-core-modules/tns-core-modules.d.ts' not found.
Changing the first line in nativescript-fresco's references.d.ts from:
/// <reference path="./node_modules/tns-core-modules/tns-core-modules.d.ts" />

to
/// <reference path="../tns-core-modules/tns-core-modules.d.ts" />

seems to fix the issue.

Hi @ludwiktrammer ,
I updated the demo application located here to NativeScript 2.5.0 and was not able to reproduce the mentioned issue. Can you try to reproduce it in the demo app and let me know.

Closing this issue due to no activity.

For what it's worth, after upgrading to NS 3.0 the issue disappeared.


Switch to speedy new Travis boxes

@homu r+

:pushpin: Commit fafaf67 has been approved by indirect

:hourglass: Testing commit fafaf67 with merge 040bf36...

@homu r+

:pushpin: Commit fafaf67 has been approved by segiddins

Starting to think that Travis isn't running on the auto branch, and so homu will never succeed...

Any reason this is into 2-0-dev instead of master?

@homu r+

:pushpin: Commit c4f3012 has been approved by segiddins

:hourglass: Testing commit c4f3012 with merge 7e31101...

The beta infra doesn't have Ruby 1.8 on it. :/

Hmm seems like the tests must still not be running?

:sunny: Test successful - status


Bluetooth not discoverable in raspberry pi 3 model B+

Works like a charm in raspberry pi 3 model B, but in model B+ the bluetooth is not discoverable in phone or pc.

I just played a little bit with the lock overdrive button dont know what it does but now my mobilephone is conected
(pi3 B+ same issue)

@mvenilton interesting! I just deployed to a new 3B+ and see the same thing.
If you use the dashboard terminal and run bluetoothctl and then show you can see the discoverable status. You can also force it on by running discoverable on. I will take a look to see if I can figure out why this is happening.

You should find this now works ok with v0.0.10 - can you give it a try and reopen this issue if not?

You should find this now works ok with v0.0.10 - can you give it a try and reopen this issue if not?

Thanks @chrisys This is working!

how do I update to the new version do I just push it ore do I have to delete the old one?

@Nytrouz-official you can download the new version from GitHub and push it again to your device, you don't have to flash the SD card or delete anything. The build system will recognise that it's only a small change.

ok thanks


Only count skipped not duplicates mutations towards the total count

Duplicated mutations should not change the mutation score, and should therefore not counts towards the total count of mutations.

Coverage increased (+0.05%) to 77.158% when pulling 7ccb9f338c866c1eb4920f512f5d8ae05af39382 on only-count-skipped-not-duplicates-towards-total into adf20bc564b300dfab117edd95f56d12a8a0c81b on master.


GnuTLS error

Do you want to request a feature or report a bug?

Bug

What did you do?
Use wget on webpage. However, using curl works just fine. And all served webpages work fine in the browser as well. This issue affects all client side applications that depend on GnuTLS.

What did you expect to see?
wget saving index.html.
What did you see instead?
--2021-04-06 10:50:43--  https://jellyfin.viggy96.me/
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving jellyfin.viggy96.me (jellyfin.viggy96.me)... <IP_ADDRESS>
Connecting to jellyfin.viggy96.me (jellyfin.viggy96.me)|<IP_ADDRESS>|:443... connected.
GnuTLS: A TLS fatal alert has been received.
GnuTLS: received alert [47]: Illegal parameter
Unable to establish SSL connection.

Output of traefik version: 2.4.8
What is your environment & configuration (arguments, toml, provider, platform, ...)?
traefik.yaml
api:
   dashboard: true
   debug: true

 log:
   level: INFO

 accessLog: {}

 entryPoints:
   web:
     address: ":80"
     http:
       redirections:
         entryPoint:
           to: websecure
           scheme: https
   websecure:
     address: ":443"

 providers:
   docker:
     endpoint: "unix:///var/run/docker.sock"
     exposedByDefault: false
   file:
     filename: "/etc/traefik/config.yaml"
     watch: true

 certificatesResolvers:
   letsencrypt:
     acme:
       email<EMAIL_ADDRESS>       storage: "/etc/traefik/acme.json"
       tlsChallenge: {}

config.yaml
http:
  middlewares:
    default-headers:
      headers:
        frameDeny: true
        sslRedirect: true
        browserXssFilter: true
        contentTypeNosniff: true
        customFrameOptionsValue: "SAMEORIGIN"
        stsSeconds: 15552000
        forceSTSHeader: true
        stsIncludeSubdomains: true
        stsPreload: true

    local-only:
      ipWhiteList:
        sourceRange:
        - "<IP_ADDRESS>/16"
        - "<IP_ADDRESS>/12"
        - "<IP_ADDRESS>/8"

    private:
      chain:
        middlewares:
          - default-headers
          - local-only

    secure:
      chain:
        middlewares:
          - default-headers

tls:
  options:
    default:
      preferServerCipherSuites: true
      minVersion: VersionTLS12
      sniStrict: true
      curvePreferences:
        - "CurveP521"
        - "CurveP384"
      cipherSuites:
        - "TLS_AES_256_GCM_SHA384"
        - "TLS_CHACHA20_POLY1305_SHA256"
          #- "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256"
          #- "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256"
        - "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384"
        - "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384"

I have this issue with several applications, not just Jellyfin, which is mentioned above. Nextcloud for example exhibits the same issue.

Jellyfin has the following config in its docker-compose.yaml file:
jellyfin:
     image: jellyfin/jellyfin:latest
     restart: always
     environment:
       - UID=33
       - GID=33
       - TZ=America/New_York
     devices:
       - /dev/dri
     volumes:
       - /tmp/jellyfin:/transcodes
       - /tank/container_data/jellyfin_config:/config
       - /tank/container_data/jellyfin_cache:/cache
       - /tank/cloud/videos/:/media/video
       - /tank/cloud/music:/media/music
     expose:
       - 8096
     ports:
       - 1900:1900/udp
     labels:
       - "traefik.enable=true"
       - "traefik.http.services.jellyfin.loadbalancer.server.port=8096"
       - "traefik.http.routers.jellyfin.rule=Host(`jellyfin.viggy96.me`)"
       - "traefik.http.routers.jellyfin.middlewares=secure@file"
       - "traefik.http.routers.jellyfin.tls=true"
       - "traefik.http.routers.jellyfin.tls.certresolver=letsencrypt"

Hello @viggy96
Thanks for using Traefik Proxy and reporting the issue.
I've just tried to reproduce the issue and in order to the, I've built wget with the latest stable GnuTLS 3.6.15 and all other dependencies to have the wget binary linked with the expected libraries.
root@c1:/tmp/wget-1.21# /tmp/usr/bin/wget --version
GNU Wget 1.21 built on linux-gnu.

-cares +digest -gpgme +https +ipv6 +iri +large-file -metalink +nls
+ntlm +opie -psl +ssl/gnutls

Wgetrc:
    /tmp/usr/etc/wgetrc (system)
Locale:
    /tmp/usr/share/locale
Compile:
    gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC="/tmp/usr/etc/wgetrc"
    -DLOCALEDIR="/tmp/usr/share/locale" -I. -I../lib -I../lib
    -I/tmp/usr/include -DNDEBUG -DNO_SSLv2 -D_FILE_OFFSET_BITS=64 -g
    -Wall
Link:
    gcc -DNDEBUG -DNO_SSLv2 -D_FILE_OFFSET_BITS=64 -g -Wall -lnettle
    /tmp/usr/lib/libgnutls.so -L/tmp/usr/lib -lp11-kit -lidn2
    /tmp/usr/lib/libnettle.so -lhogweed /tmp/usr/lib/libgmp.so
    -Wl,-rpath -Wl,/tmp/usr/lib ftp-opie.o gnutls.o http-ntlm.o
    ../lib/libgnu.a /tmp/usr/lib/libunistring.so -Wl,-rpath
    -Wl,/tmp/usr/lib

Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://www.gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Originally written by Hrvoje Niksic<EMAIL_ADDRESS>Please send bug reports and questions to<EMAIL_ADDRESS>
I used my custom wget to get your website, here is the result:
root@c1:/tmp/wget-1.21# /tmp/usr/bin/wget --server-response --spider https://jellyfin.viggy96.me/
Spider mode enabled. Check if remote file exists.
--2021-04-07 14:01:04--  https://jellyfin.viggy96.me/
Resolving jellyfin.viggy96.me (jellyfin.viggy96.me)... <IP_ADDRESS>
Connecting to jellyfin.viggy96.me (jellyfin.viggy96.me)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 302 Found
  Date: Wed, 07 Apr 2021 12:01:03 GMT
  Location: /web/index.html
  Server: Kestrel
  Strict-Transport-Security: max-age=15552000; includeSubDomains; preload
  X-Content-Type-Options: nosniff
  X-Frame-Options: SAMEORIGIN
  X-Xss-Protection: 1; mode=block
Location: /web/index.html [following]
Spider mode enabled. Check if remote file exists.
--2021-04-07 14:01:04--  https://jellyfin.viggy96.me/web/index.html
Connecting to jellyfin.viggy96.me (jellyfin.viggy96.me)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response...
  HTTP/1.1 200 OK
  Accept-Ranges: bytes
  Content-Length: 6868
  Content-Type: text/html
  Date: Wed, 07 Apr 2021 12:01:04 GMT
  Etag: "1d71eaa95f720d4"
  Last-Modified: Sun, 21 Mar 2021 23:33:24 GMT
  Server: Kestrel
  Strict-Transport-Security: max-age=15552000; includeSubDomains; preload
  X-Content-Type-Options: nosniff
  X-Frame-Options: SAMEORIGIN
  X-Response-Time-Ms: 0
  X-Xss-Protection: 1; mode=block
Length: 6868 (6.7K) [text/html]
Remote file exists and could contain further links,
but recursion is disabled -- not retrieving.

What exact wget version do you use?

wget version 1.21.1
GnuTLS version 3.7.1
I'm using Manjaro

--2021-04-06 10:50:43--  https://jellyfin.viggy96.me/
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving jellyfin.viggy96.me (jellyfin.viggy96.me)... <IP_ADDRESS>
Connecting to jellyfin.viggy96.me (jellyfin.viggy96.me)|<IP_ADDRESS>|:443... connected.

Can you please make sure that the request hits the Traefik instances? I noticed from the log above the IP address <IP_ADDRESS> - seems that it is a local network.  As I mentioned in the previous answer I was able to reach your website correctly using WGET.

Hi, I am running the same GnuTLS and wget version as viggy96 on manjaro and I am running into the same problem with my public traefik instance (this requesst hit the traefik instance for sure):
Loaded CA certificate '/etc/ssl/certs/ca-certificates.crt'
Resolving www.paulgo.io (www.paulgo.io)... <IP_ADDRESS>
Connecting to www.paulgo.io (www.paulgo.io)|<IP_ADDRESS>|:443... connected.
GnuTLS: A TLS fatal alert has been received.
GnuTLS: received alert [47]: Illegal parameter
Unable to establish SSL connection.
[local@paul-laptop ~]$ wget --versi```

@jakubhajek The request is hitting the traefik instance, I just have a entry in my /etc/hosts file to force my desktop to use the 10GbE port that is directly connected to my server.

Hello @viggy96 @MrPaulBlack, I was able to replicate the issue using the same version of  Wget and GnuTLS on Manjaro. Let me investigate that issue deeper.

Hello @viggy96 and @MrPaulBlack
We did a deep investigation of that issue together with our teammates and we would love to say that the issue is related to the TLS Handshake in TLS 1.3 and its implementation on a *client-side. *
The first connection initiated by a client sends the Clienthello as the first message.
The message is also sent if the server responded with HelloRetryRequest and in that case, the client must send the same ClientHello with the same "session_id". In that fact the "session id" has to send the same, otherwise, the connection will be terminated.
During our tests, we have noticed exactly that behavior that "session-id" was changed and due to that the connection was terminated. As a client, we used Wget built with GnuTLS 3.7.1.
Thank you,


feat(frontend): Set up Bitcoin transactions page

Motivation
The transactions page for Bitcoin was not showing balance, nor logo, nor nice background.
The error was that it didn't find any token in the pageToken derived store and that the btc didn't have any assigned background.
Changes

Add the bitcoin tokens as the tokens to search the pageToken.
Set up a BtcTransactions component.
Add a background in the Hero for the Bitcoin network. (To be determined with design which one, but for now, same as ICP).
Render BtcTransactions if network is BTC.
New derived store networkBitcoin.

Tests
Tested manually that Hero appears as expected.

Before:

This PR:

Can you provide this in two separate PRs please? e.g. stores part followed by UI usage

Sure, I love small PRs. First one: https://github.com/dfinity/oisy-wallet/pull/2214
What is the rule to know when a PR is the right size? A PR can only touch one layer like api, services, components, etc? Or is it common sense?

What is the rule to know when a PR is the right size? A PR can only touch one layer like api, services, components, etc? Or is it common sense?

I'm not sure what the informal rule is. It’s a bit like grouping small PRs and related changes together. In this particular PR, the concern is with the stores, as we've recently had issues with an endless loop involving derived stores.
Perhaps @AntonioVentilii-DFINITY has a better definition?

I usually base them more on single revertable (or modifiable) changes.  For example, in this case, the Hero background would go in a different PR, even if small. Just because we could revert or change it after merging, and it would have a simpler history.
I'm not really sure if I explained correctly.
P.S. for me, it is even easier to follow: I submit 5 small PRs at the same time, and if there is a review in one of them, the others are not blocked. Plus, I can change them independently and really verify that one does not affect the other, unrelated (that always means good)

Closing in favor of #2223 and #2214


Issue 15167 add message read counts.

Work Towards #15167
Currently, this PR only shows the graph for reads per time not for read interaction.
@timabbott I think this ready for an initial review.

Oops, I accidentally pushed master here, which due to GitHub being silly, automatically closed this PR.

@timabbott No issue. So should I again force push it and make a new PR?

Yeah, sorry for the trouble!
I merged the test commit as fb2aae1c02512368743e16d87c255ca7ae02ae2a after a few tweaks.  I think ultimately we should be using bulk_create_streams from zerver/lib/bulk_create.py in the analytics tests, rather than having hand-written code creating Stream objects.
I sorta feel the same way about create_huddle_with_recipient; the create_message helper is the only one that makes sense to me (because the whole point is backdating message history).
For the query count changes in the data collection commit, I think we want effectively an if count > 0; -- there's no point in doing a query if we made no changes.  (And while we could and should put that check in do_increment_logging_stat, I suppose we'll need a increment=min(1, count)) in the messages_read_interactions calls to avoid adding an increment of 1 when in fact no messages were marked as read.

One more comment on the commit structure; can you split the backend for the new graph (including tests) as a separate commit from the frontend?  I think we'll likely be happy to merge the backend pretty early, but might delay a bit doing the frontend both because it's most of the code and because it's the point where users might see this seemingly-broken graph (it'll look broken due to too-little data for a while).


Twitter Social Icon wrong Href redirect

Describe the Bug
The twitter social icon is pointing to kleros_io twitter,
To Reproduce
Expected Behavior
should be redirect to poh twitter
Screenshots

Device and Browser Information
Chrome

Solved on 204cfcce37adf2f13998ddb8dd54ea10bac42e4f


Write co-registration settings to JSON param file

What is the purpose of this PR?
Closes #54. Currently, after running update_coregistration_params.ipynb, the new conversion factors are appended directly to settings.py. This causes a lot of clutter and causes settings.py to diverge from main. We should write the params to untracked temp .json file instead.
How did you implement your changes
The following changes have been added:

write_coreg_params has been nuked: instead we save to a file called stage_optical_coreg_params.json in toffy directly in update_coregistration_params.ipynb.
convert_stage_to_optical now includes a a default argument stage_optical_coreg_path set to stage_optical_coreg_params.json. If this path exists, then we read the coregistration conversion factors directly from the created .json file. Otherwise, we use the default factors in settings.py.

@ngreenwald I think it's easier to write successive coreg updates to the same file. We'll store each different co-registration parameter set in list format such as:
{
    'coreg_params': [
        {
            'STAGE_TO_OPTICAL_X_MULTIPLIER': ...,
            'STAGE_TO_OPTICAL_X_OFFSET': ...,
            ...
            'date': '220322'
        },
        {
            ...
            'date': '220323'
        }
    ]
}

In this way, we have one JSON file (as opposed to multiple that would create more clutter in toffy and be harder to keep track of) and simply take the most recent set of params created (the last element in 'coreg_params').
This will allow us to remove the STAGE_TO_OPTICAL_... params from settings.py. However, we'll still need to keep the MICRON_TO_STAGE_... constants around somewhere. I think it's easiest to leave these in settings.py...alternatively, we could put these in a separate .json file as well. I'm open to other ideas here.

Per our meeting, the following have been updated:

settings.py no longer contains STAGE_TO_OPTICAL_ constants, however we'll leave the MICRON_TO_STAGE_ constants there
The STAGE_TO_OPTICAL_ constants generated by update_coregistration_params.ipynb will now be saved to toffy/coreg_params.json. It will contain a key called coreg_params which defines a list of every set of conversion factors generated by the user. Each set of co-registraion params will also contain a key called 'date' which will indicate the timestamp they were generated. Only the most recent (the last one appended to the coreg_params list) is used.
If the user has not run update_coregistration_params.ipynb before autolabel_tma_cores.ipynb, an error message will direct them to run the co-registration script first.


[BUG] Data loader performance drops

Describe the bug
I'm measuring throughput using KerasSequenceLoader and I'm experiencing nondeterministic performance drops from time to time. For example measuring throughput (number of samples per second) as batch_size / (interval between end of 2 consecutive training steps), I'm getting following log:

Throughput:<PHONE_NUMBER>146777
Throughput:<PHONE_NUMBER>203963
Throughput:<PHONE_NUMBER>906468
Throughput:<PHONE_NUMBER>757882
Throughput:<PHONE_NUMBER>421744
Throughput:<PHONE_NUMBER>262529
Throughput:<PHONE_NUMBER>410793
Throughput:<PHONE_NUMBER>554414

Additionally I've calculated the median - 686733 and the mean throughput - 666872 +/- 79903 (without first and last batch of each epoch). Those drops are clearly below the std inverval, also there are no such picks over the interval.
Steps/Code to reproduce bug

Use NVTabular/examples/advanced-ops-outbrain/ jupyter notebooks as an example

In last notebook (03-Training) add following cell (before last one):

import time

class ThroughputMeasurement(tf.keras.callbacks.Callback):
    def __init__(self):
        self.t0 = None
        self.batch_start = None
        self.bs = 131072

    def on_train_begin(self, logs=None):
        self.batch_start = time.time()

    def on_train_batch_end(self, batch, logs=None):
        throughput = self.bs / (time.time() - self.batch_start)
        print(f"Throughput: {throughput}")
        self.batch_start = time.time()

throughput_callback = ThroughputMeasurement()

Call the last cell with:

history = wide_and_deep_model.fit(train_dataset_tf, verbose=0, callbacks=[validation_callback, throughput_callback], epochs=2)

Expected behavior
Constant (with respect to variance) throughput measurement without drops during training.
Environment details (please complete the following information):

Environment location: Docker
Method of NVTabular install:

docker pull nvcr.io/nvidia/merlin/merlin-tensorflow-training:0.5.3
nvidia-docker run --rm -it --net=host --ipc=host ${IMAGE} bash
cd /nvtabular && git checkout main && git pull (corresponds to 95edc4c9cb437913fffab1b44fe1b4e13701088f)

Additional context

The problem is even more visible in case of multi-gpu training, but the single-gpu example is enough to reproduce
1xGV100 32GB card was used for the tests

The behavior you are seeing is happening because you have a small number of partitions and those partitions are not all the same size. Some of the partitions will be smaller than others, this  happens because the data loader does not support reading from more than one file to create a "target_size" partition, so you end up with partitions with "< target_size" records. That behavior can be added in future releases.


Setting up the all contributors bot?

Do we want to use it?
If so? Is that something we should do "now" or wait do it during the "rejuvenation" process that should happen "soon" on this repo?

I think it would be great to automatically recognize contributions, especially since we are keeping the code repository @franklin-feingold do you have any ideas?

sounds good to set up the contributor bot here! Recognizing contributors can be done while the enhancement process is further fleshed, that process may be a bit longer to ramp up and implement

OK I will "slowly" go through our backlog of issues and PR and start adding people as contributors.

Contributions type sort out:

[ ] maintenance
[ ] doc

Done with the pull request backlog.
Will go through the issues later.

also check list of commits in the wiki

[x] checked the issues

List of contributors on the wiki:
git clone https://github.com/bids-standard/bids-starter-kit.wiki.git
git shortlog -sne --all

dorahermes
Park-Patrick
Kirstie Whitaker
Chris Holdgraf
Robert Oostenveld
Remi Gau
Stefan Appelhoff
Anthony Galassi
Chris Benjamin
Isla
AlexandreHutton
Ankit Gupta
Anushka Bhandari
Chris Filo Gorgolewski
Chris Markiewicz
Elizabeth DuPre
Franklin Feingold
James Kent
alexvonlautz

@all-contributors please add @cfxb for doc

@all-contributors please add @Islast for doc

@all-contributors please add @effigies for doc

@all-contributors please add @ankiitgupta7 for doc

@all-contributors please add @alexvonlautz for doc

@all-contributors please add @AlexandreHutton for doc

Done!!


Migrations generates '1.0.0-rtm-21431' for ProductVersion

It should be 1.0.0. We're using [AssemblyInformationalVersion], but because of the way the RTM packages are built, this attribute is not set to 1.0.0 to match the package version.

Decided to leave as-is, more info is always good


Mobile support?

Cool idea and it's working well on desktop. Installed via Brat on mobile and the little popovers aren't showing up after enabling it. Saw the commit for mobile so figure it is supported. Let me know if I can do anything to help and thanks for making this.

Would you please check the installed version number on your mobile device.  I am sure my changes are pushed out (though going to rebuild just in case).

0.0.26 now 0.0.27 and the update seemed to go fine via BRAT, it still wasn't showing popovers on restart though.
0.0.26 was showing in installed community plugins - Obsidian 42 strange new worlds, the latest update wasn't.
So I uninstalled from the community plugin list and used BRAT to install again with:
TfTHacker/obsidian42-strange-new-worlds
On install, got the error message "BRAT This plugin is already in the list for Beta testing"
Seems there's some code in there, not sure if it's just not getting fully uninstalled or what's happening.
Opened BRAT, Enable a plugin - toggle it on. Strange New Worlds isn't in the list to toggle on.
0.0.27 now also now not in the list of installed community plugins.

Things I've tried:
Restarting device
Changing themes to see if css (Minimal) was obscuring the popovers, but with the default theme they aren't showing up for me either.
I'm probably going to be leaving it on when on desktop, but mobile will leave it off so no worries on this. Happy to help any way if there's anything else you'd like me to check.

Thank you for your detailed feedback, I really appreciate it.
Can you do this for me?

uninstall the plugin in the normal way (community plugins, uninstall)
Delete the plug-in in the list of plugins from within settings BRAT settings.
And then try to reinstall it and see what happens.

I am thinking BRAT isn't updating right and is confused, so basically, remove the settings.
At the same time, I think mobile might have an issue.  will be testing this today.

I made a quick video here. please see if this helps.
https://cln.sh/BxS444

I think mobile support is now working properly, so I will close this out.
Tnx for the report!


Plans to develop Web DigiDoc

Are you planning to develop tools like https://github.com/PeculiarVentures/xadesjs to replace DigiDoc with a web version?
Latvia has eParaksts, but an open source alternative would be very attractive, especially if it supported other EU eID cards.

At the moment there are no needs or plans to develop that kind of a solution to the web version.

Okay. I'm working on one. https://github.com/eidins/web-signer/blob/basic-app/src/App.js
It would be cool from a unification perspective. Standard easy way to sign documents internationally.

@eidins keep up the good work and keep us posted with comments in this ticket when it is ready!

please no. For security reasons, I specifically try to keep as much out of the web browser as possible.


[Non-Issue] Question about layout

This is more of a question than a bug report.
Could someone achieve the following layout with FSCalendar, without having to alter its source code?

Scrolling affects the header view as well.

@WenchaoD
I tried achieving this by embedding instances of FSCalendar in UICollectionReusableView with the appropriate minimum and maximum dates.  Although when updating the reusable view with the model it crashes randomly.


[iOS] Fixme not displaying correctly

On last version (2.0), the fixme message does not display the entire text properly, per image below.

It won't display the entire text (there's the fixme field below for that), but I'll cut the text properly, thanks.

Done in 2.1.


⚠ CIOOS Pacific ERDDAP dataset ECCC_MSC_BUOYS has degraded performance

In 3bf9fc5, CIOOS Pacific ERDDAP dataset ECCC_MSC_BUOYS (https://data.cioospacific.ca/erddap/tabledap/ECCC_MSC_BUOYS.htmlTable?wmo_synop_id&time>now-3hours&distinct()) experienced degraded performance:

HTTP code: 503
Response time: 12084 ms

Resolved: CIOOS Pacific ERDDAP dataset ECCC_MSC_BUOYS performance has improved in 28a5ea1 after 5 minutes.


Alter TagSetManager score function to look at preference only

The score function counts all tags even if no PREFER tag is present and there is no reason to rank one destination higher than another.
I'd like to replace the score function with one that distinguishes only between pairs entities that prefer one another's tags and pairs that have no expressed preference for each other's tags.
@nuwang, I could keep this PR as is or add is_preferred(self, other) as a separate function returning a boolean.
I need to add a test to this.

The current score function takes the int value of the tag_type: https://github.com/galaxyproject/total-perspective-vortex/blob/3ee613617bff76dc8c894853be3864c1c498a539/tpv/core/entities.py#L13
So it does take preference into account, strongly favouring requires and prefers tags, ignoring accept tags and heavily penalizing reject tags.

If one tool matches to two destinations and both qualify as candidate destinations, but the tool has tag that destination 1 requires but destination 2 accepts, destination 1 will always outrank destination 2 under the score function. The tool can run at both destinations and the prefer tag has never been used. My opinion is that without a prefer tag there is no reason for tags to come into ranking after candidate_destinations have been determined. We stopped using it on Galaxy Australia because of this side effect.

For example, there was a tool and two destinations where it could run. There was no reason for one destination to be chosen over the other, but while we were using the score function destination 1 was always chosen.
Tool tags:
scheduling:
require:
- pulsar-blast
accept:
- pulsar
Destination 1 tags:
scheduling:
accept:
- pulsar-qld-blast
require:
- pulsar
- pulsar-blast
Destination 2 tags:
scheduling:
accept:
- pulsar-mel3
- pulsar-blast
require:
- pulsar

I think you make a good point about no longer counting required or reject tags after candidate destinations are matched. If we just set their respective scores to zero, wouldn't it have the same effect? In fact, it would also privilege the case if there are two matching prefers tags, as opposed to the ranking always being 1 or 0.

Thanks @nuwang, that would solve my issue. I'll swap this change for what you have suggested. Having a higher weight for tool prefers dest and dest prefers tool makes sense.


Ripple effect doesn't work in buttons inside md-menu

Steps to reproduce
Put a md-button inside md-menu-content.
Which browser?

Vue: 2.1.10
Vue Material: 0.7.1
OS: Fedora 25
Chrome Version: 55.0.2883.87 (64-bit)
PS: No problem in Firefox 50.1.0
What is expected?
Button should have ripple effect when clicked
What is actually happening?

No ripple effect

Can you add a reproduce link to jsfiddle or codepen?

@cawa-93 done

Closing this issue as our focus is on the new 1.0.0 version.


Comments from running PolarRoute on visual_ice SIC layers

I have now run PolarRoute on 5 - 6 different SIC layers derived from visual_ice. I supply below some considerations for future PolarRoute modifications when working with higher resolution data:

Apply a buffer to cells with high SIC. For example it would not be ideal to skirt around icebergs (Figure 1).
Smooth the route- it is undesirable and impractical for the ship to change direction every 250 m, so a penalty for changing direction is required (Figure 2).
I do not think the penalty for travelling through a grid cell with high SIC is great enough. In Figure 3 I would expect the route to go through one of the two areas in orange, compared to the route derived by PolarRoute in red.

I have generated routes using the scripts Sam shared on 6th July- happy to share again here is necessary. Note for this exercise I used a vessel config with MaxIceConc = 95%. This was to allow routes to go through areas where a low number of grid cells had a high SIC.
All comments are non-urgent, and great to see the software working on higher res imagery :)
Figure 1: Buffer required to prevent route from skirting around icebergs and other areas of high SIC.

Figure 2: Risk of too many directional changes.

Figure 3: Route derived by PolarRoute (red) compared to the ones I would expect drawn freehand in orange.

It's nice to start seeing PolarRoute used at a higher resolution ! :)
Currently the time and fuel usage of the ship in different sea-ice concentrations is based on vessel performance characteristics provided by the carbon accounting team. As the relationship is non-linear, in some cases it's more temporal/fuel efficient to actually do icebreaking than navigate longer distances. I think that is what could be the case for your second figure. Using the calculate_route function should allow you to inspect your manually chosen routes to see the difference from the optimised. In addition, you can plot the ship fuel and speed maps to really dive into the how the SIC is effecting the efficiency.
Currently you're still looking at grid-based routes, the inclusion of physics based path-smoothing will also help improve the routes. After lots of bug fixing these corrections should be included into 0.2.x release in the next couple of days :)
As an aside, in the long-run we are hoping that PolarRoute acts as the long-distance route planning toolkit, whilst the higher resolution in-ice navigation would be using a risk-based routing system. Ayat is currently working on a Gaussian-process risk aware routing that takes an environmental temporal risk map (in the long run this will be the probability of temporal sea-ice change multiple by severity) so we can leverage your images as a time series in this problem as well :) Looking forward to working with you more on this going forward :)

Hi @MartinSJRogers, just to let you know we've now released the new v0.2 of PolarRoute. So if you merge main into your branch you should be able to try out some of the new features we mentioned above 🙂

The dataloader for visual_ice is now available for use with the latest code as part of MeshiPhi: https://github.com/antarctica/MeshiPhi/tree/visual_ice. I'll close this issue for now as there has been no discussion for ~6 months.


Col lineage missing columns

Query
"create table shopify.dim_address_clean as select address_id, shop_id, first_name, last_name, address_1 as address, company, city, region, zip, country, phone from shopify.dim_address"

misses lineage from address_1 to address

{'entity': {'id': '0558de53-c700-4ffc-934c-bfc13bc163c1',
  'type': 'table',
  'name': 'dim_address_clean',
  'fullyQualifiedName': 'sample_data.ecommerce_db.shopify.dim_address_clean',
  'description': 'Created from dim_address after a small cleanup.',
  'deleted': False,
  'href': 'http://localhost:8585/api/v1/tables/0558de53-c700-4ffc-934c-bfc13bc163c1'},
 'nodes': [{'id': 'e899d4a2-38ee-4980-b239-301b5eff75a3',
   'type': 'table',
   'name': 'dim_address',
   'fullyQualifiedName': 'sample_data.ecommerce_db.shopify.dim_address',
   'description': 'This dimension table contains the billing and shipping addresses of customers. You can join this table with the sales table to generate lists of the billing and shipping addresses. Customers can enter their addresses more than once, so the same address can appear in more than one row in this table. This table contains one row per customer address.',
   'deleted': False,
   'href': 'http://localhost:8585/api/v1/tables/e899d4a2-38ee-4980-b239-301b5eff75a3'}],
 'upstreamEdges': [{'fromEntity': 'e899d4a2-38ee-4980-b239-301b5eff75a3',
   'toEntity': '0558de53-c700-4ffc-934c-bfc13bc163c1',
   'lineageDetails': {'sqlQuery': 'create table shopify.dim_address_clean as select address_id, shop_id, first_name, last_name, address_1 as address, company, city, region, zip, country, phone from shopify.dim_address',
    'columnsLineage': [{'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.address_id'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.address_id'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.city'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.city'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.company'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.company'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.country'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.country'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.first_name'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.first_name'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.last_name'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.last_name'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.phone'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.phone'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.region'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.region'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.shop_id'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.shop_id'},
     {'fromColumns': ['sample_data.ecommerce_db.shopify.dim_address.zip'],
      'toColumn': 'sample_data.ecommerce_db.shopify.dim_address_clean.zip'}]}}],
 'downstreamEdges': []}

my bad, works great


Grant Ships FAQs - Reasoning

review

These all need to be reviewed, but is low priority as there is a good draft. This should be reviewed after other pieces are finalized.


Adding custom content before tabs

Is there a way to add custom content before tabs?
What have you tried
I thought of replacing the current TabBar with a new custom component where I can add the customize content before adding TabBar. But now I stuck because I don't if there is a way to change the tabBar from a screen.
Screenshots (if applicable)

Your Environment

software
version

ios or android

react-native
0.61.2

react-native-tab-view
2.13.0

react-native-gesture-handler

react-navigation
4.3.6

node

npm or yarn

hi @kabaljit could you solve this?

you can use this prop
renderTabBar={(tabBarProps) => (
<View
style={{
height: vertical_48,
flexDirection: "row",
width,
}}
>
<View
style={{
height: vertical_48,
aspectRatio: 1,
backgroundColor: "red",
}}
>
<TabBar
layout={{ height: vertical_48, width: width - vertical_48 }}
renderIcon={({}) => {}}
scrollEnabled
{...tabBarProps}
        style={{
          height: vertical_48,
          width: width - vertical_48,
          backgroundColor: "#000",
          justifyContent: "center",
        }}

      />
    </View>
  )}

it worked for me perfectly

You can place the TabBar inside a View with a flex of 1. Then you can place any content you like wherever you like, e.g. above the TabBar.


Cannot use private libs anymore

Since #473, compiling with my private libs leads to this error:
Error: Error: Cannot process [xxx]: missing field license

Followed by this if I set "license": "":
Error: Error: Cannot process [xxx]: Invalid value  for License

I am now supposed to add one of these for a private lib in order to compile my project:
"GPL", "LGPL", "BSD", "Public", "MIT", "Apache"

I think we should keep the full haxelib.json check, but add an "Other" value for license, and a check on upload to lib.haxe.org that it's not "Other".

That annoyed me too, I had to add a user name and a license for private libraries which didn't required it before.


Make it easier to run the integration tests locally

The unit tests with go test ./... are pretty straightforward.
The integration tests (cmd/image-builder-tests) require composer up and running, and also a container of image-builder to test the container variant; so they are harder to run.
Either have a script somewhere or a make target before running go test -tags=integration. And document it.

Maybe we could reuse/extend the docker compose stuff @achilleas-k made for osbuild-composer?

Maybe we could reuse/extend the docker compose stuff @achilleas-k made for osbuild-composer?

Thanks @Gundersanne !
The unit tests I've run the 4 cases successfully. And there's a new package "tutils" has no unit test yet.
ok  	github.com/osbuild/image-builder/cmd/image-builder	0.011s
ok  	github.com/osbuild/image-builder/internal/cloudapi	0.010s
ok  	github.com/osbuild/image-builder/internal/logger	0.176s
ok  	github.com/osbuild/image-builder/internal/server	3.557s
?   	github.com/osbuild/image-builder/internal/tutils	[no test files]

About the integration test, I found a jenkinsfile "schutzbot/Jenkinsfile" and followed it to build the image-builder packages, install it in my fedora33, start a container and run image-builder-test, and get PASS result:
# /usr/libexec/tests/image-builder/image-builder-tests -test.v | tee /root/image-builder-test.log
=== RUN   TestImageBuilder

Out:  time="2021-01-25T06:13:16Z" level=info msg="🚀 Starting image-builder server on localhost:8086 ...\n" func="github.com/osbuild/image-builder/internal/server.(*Server).Run" file="/builddir/build/BUILD/image-builder-87143554f2f6f8042f36c0401ba08e0313409fe7/_build/src/github.com/osbuild/image-builder/internal/server/server.go:67"

   ____    __
  / __/___/ /  ___
 / _// __/ _ \/ _ \
/___/\__/_//_/\___/ v4.1.17
High performance, minimalist Go web framework
https://echo.labstack.com
____________________________________O/_______
                                    O\
⇨ http server started on <IP_ADDRESS>:8086

--- PASS: TestImageBuilder (11.48s)
=== RUN   TestImageBuilderContainer
--- PASS: TestImageBuilderContainer (9.28s)
PASS

I also get the same result when I go to /root/repos/image-builder/cmd/image-builder-tests/ and run "go test -tags=integration"

BTW, since there is a jenkinsfile, is there a CI job somewhere? Thanks!

Thanks @Gundersanne !
The unit tests I've run the 4 cases successfully. And there's a new package "tutils" has no unit test yet.
ok  	github.com/osbuild/image-builder/cmd/image-builder	0.011s
ok  	github.com/osbuild/image-builder/internal/cloudapi	0.010s
ok  	github.com/osbuild/image-builder/internal/logger	0.176s
ok  	github.com/osbuild/image-builder/internal/server	3.557s
?   	github.com/osbuild/image-builder/internal/tutils	[no test files]

About the integration test, I found a jenkinsfile "schutzbot/Jenkinsfile" and followed it to build the image-builder packages, install it in my fedora33, start a container and run image-builder-test, and get PASS result:
# /usr/libexec/tests/image-builder/image-builder-tests -test.v | tee /root/image-builder-test.log
=== RUN   TestImageBuilder

Out:  time="2021-01-25T06:13:16Z" level=info msg="🚀 Starting image-builder server on localhost:8086 ...\n" func="github.com/osbuild/image-builder/internal/server.(*Server).Run" file="/builddir/build/BUILD/image-builder-87143554f2f6f8042f36c0401ba08e0313409fe7/_build/src/github.com/osbuild/image-builder/internal/server/server.go:67"

   ____    __
  / __/___/ /  ___
 / _// __/ _ \/ _ \
/___/\__/_//_/\___/ v4.1.17
High performance, minimalist Go web framework
https://echo.labstack.com
____________________________________O/_______
                                    O\
⇨ http server started on <IP_ADDRESS>:8086

--- PASS: TestImageBuilder (11.48s)
=== RUN   TestImageBuilderContainer
--- PASS: TestImageBuilderContainer (9.28s)
PASS

I also get the same result when I go to /root/repos/image-builder/cmd/image-builder-tests/ and run "go test -tags=integration"

BTW, since there is a jenkinsfile, is there a CI job somewhere? Thanks!

Hi @teg ,
Is the "osbuild-composer" the job that runs this jenkinsfile?

Hi @teg ,
Is the "osbuild-composer" the job that runs this jenkinsfile?

So tutils is test utils, it's only stuff that's used during unit tests themselves.
And the CI should run on each PR hosted on psi. The integration tests are kinda weird in that there's 2 tests, one which starts image-builder itself, and the other one which expects there to be an image-builder container running. The latter is started right before running the actual tests.

Maybe we could reuse/extend the docker compose stuff @achilleas-k made for osbuild-composer?

Maybe! where is it ?

So tutils is test utils, it's only stuff that's used during unit tests themselves.
And the CI should run on each PR hosted on psi. The integration tests are kinda weird in that there's 2 tests, one which starts image-builder itself, and the other one which expects there to be an image-builder container running. The latter is started right before running the actual tests.

Maybe we could reuse/extend the docker compose stuff @achilleas-k made for osbuild-composer?

Maybe! where is it ?

PR is still open for it here https://github.com/osbuild/osbuild-composer/pull/1146

PR is still open for it here https://github.com/osbuild/osbuild-composer/pull/1146


add mental health crisis intervention number

https://multco.us/mhas/mental-health-crisis-intervention
maybe. This is probably accessible by 211 but having its own number could highlight a current social issue in portland.

Done, with yet another merge commit... sorry. Let the bike messenger touch the repo...


[Feature]: Backup tool should get the version of Milvus and check whether this version is supported

Is your feature request related to a problem? Please describe.
No response
Describe the solution you'd like.
No response
Describe an alternate solution.
No response
Anything else? (Additional Context)
No response

fix in #66


rename solutions to correct in dataset generation

this goes alongside the unlabelled array in the captchas.json and is required for clarity

will require changing elsewhere too, wherever solutions is used

decided not to do this, just document that solution is only the correct images


Hook up ontology terms

Merging this PR manually from my feature branch. Thanks kindly, @david4096 !


Add header and footer partials

All pages should have the same header and footer

[x] Add footer
[ ] Add header

The footer was added in PR #74


[xgboost4j-spark] Clarification on spark binding

Do I get to choose to write my SPARK code in both Scala and Python using the xgboost4j-spark plugin?  Or scala is my only choice?  And if so, would it be possible to create an equivalent Python binding?  Thanks!

We only provide Scala API
and Python binding is not in the recent plan


Update SBOMs for proton-bridge

As of cyclonedx-gomod v0.6.0, generated SBOMs include license information. I also added SBOMs for another version of proton-bridge to address #5.

Looks like the SBOMs are invalid. A license can be either a resolved SPDX license ID or an unresolved license name, but not both.
Refer to
https://cyclonedx.org/docs/1.2/#type_licenseType
https://cyclonedx.org/use-cases/#license-compliance

Thanks for pointing that out @stevespringett. I created a fix and will update this PR once GitHub Actions is working again.

SBOMs have been regenerated with v0.6.1 of cyclonedx-gomod, which includes a fix for the issue.

Thanks @nscuro. Validated all four. Looks good and thanks for the PR.


RFC: ResultExt trait

This follows discussion in https://github.com/neon-bindings/examples/pull/67
I'm quite new to Rust so hopefully my proposal is clear and I haven't missed any obvious alternatives!
View Rendered RFC

@davidbailey00 The main blocker for this RFC is that in order to support this in a very general fashion, requires Generic Associated Types or GATs, which do not exist in Rust.
We would need to choose between supporting generic Into responses on structs or boxed trait object representations (runtime cost).
This is an interesting idea, but I think it needs a proof of concept that can demonstrate we can provide this in a zero-cost, ergonomic format. I then think we would want to do a holistic update of Neon APIs to expect Into<Throw> or Into<Value> like traits.

The main blocker for this RFC is that in order to support this in a very general fashion, requires Generic Associated Types or GATs, which do not exist in Rust.

On that basis, should this be revisited when https://github.com/rust-lang/rust/issues/44265 lands?

@davidbailey00 I would ❤  to implement this sooner, if possible. I tried a few different hacks to work around the problem, but was unsuccessful. It would be awesome of some contributor could figure out how to solve it.
Maybe there's something we could do with proc macros to make it ergonomic without GATs? Here's my ideal API for JsFunction::new:
trait TryIntoJs {
    type Error: IntoThrow;

    fn try_into_js<'a, C: Context<'a>>(self, cx: &mut C) -> Result<Handle<'a, Value>, Self::Error>;
}

trait IntoThrow {
    fn try_into_js<'a, C: Context<'a>>(self, cx: &mut C) -> JsResult<Self>;
}

impl JsFunction {
    pub fn new<'a, C, F, T, E>(f: F) -> JsResult<'a, JsFunction>
    where
        C: Context<'a>,
        F: Fn(FunctionContext) -> Result<T, E>,
        T: TryIntoJs,
        E: IntoThrow,
    {
        todo!()
    }
}

Thanks for the contribution! This idea has been incorporated into https://github.com/neon-bindings/rfcs/pull/44.


[Fix #10921] Fix an error when processing configuration file

Fixes #10921.
This PR fixes an error when ERB pre-processing of the configuration file.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!

Thank you, @koic!


Stop recreating the hashmap all the time.

What does this PR do?
This is a different approach from #362 but should fix the same issue in the same way.
This doesn't change any external python API, and makes every existing code faster (by just using the structurs smarter).
This is better IMO as it fixes every potential use for the safe_open method, whereas #362 introduces a new layer that has to be used in order to benefit (so only users of safetensors.torch.load_file would actually see the difference).
The crux of the problem was Metadata::tensors which is a method that creates a full HashMap<String, String> to access the tensors. The structure used to be exactly that and just give directly the structure to callers, therefore relatively free. But since, the structure was refactored into a HashMap<String, usize> and Vec<TensorInfo>.
The main reason for it, is that the Vec is intrinsically ordered, and we maintain the data_offsets ordered in order to get efficient comparison when checking for malformed files (with overlapping data_offsets).
It also helps in during the serialization where we already have those information sorted so we write them sorted into the JSON header.
Fixes #361
Potentially superseeds #362

Fixes # (issue) or description of the problem this PR solves.

do you have account on twitter? i would like to follow you
good job

https://twitter.com/narsilou
I'm not very active though :)

https://twitter.com/narsilou I'm not very active though :)

Followed thanks


Use different "book" directory

Can you change the value "book" in the newBookFromToc() call? I run into errors when changing it to anything else. If it is designed to be changed, then some sort of error is occurring here.

You probably need also to change it in nimib.toml (which was introduced later) but I agree this is not ideal

now newBookFromToc is deprecated and you should use initBookFromToc. Changing the directories in nimib.toml allows to change src and out directories for nimibook. fixed in #50


CLI Updates

I've made some updates so that this works with the revised ibmcloud command line interface. Most of the commands work, but the ibmcloud login method with all of the flags doesn't quite work the way I'm expecting it to. Nonetheless, the individual action creation methods work now, and they're good enough for a client workshop.

@stevemar let me know when you have time to take a peek at this - I feel like this might be an easy PR to merge in 😄

Thanks @dokun1 !


Static files routed through xentriq should be served with cache headers

In some cases static files such as CSS, JS or images will need to be routed through Xentriq.
It should be possible to add cache headers for these files.

Planning to introduce ETag, If-Modified-Since/Last-Modified header and 304 Not Modified status for v1.
In addition to this we can introduce the Cache-Control: max-age=x header but we might need to put more though in to that because it allows distinction between public and private as well.
Any other mechanisms we need to consider?

I think that looks ok for now and should cover most use cases. If we need other things we can implement out of need :)

Implemented in 6d75512


docs: Introduces documentation for secret detection within repos

Pull Request Template
What are you trying to address

Provides good practices for enabling a robust secret detection workflow as part of your teams software development lifecycle.
Resolves #778

Description of new changes

Adds docs around incorporating secret detection workflow into repos
References existing repos for enabling secret detection using a combination of:

Pre-commit hooks
Github workflows / AzDO pipelines

For all pull requests

[x] Link to the issue you are solving (so it gets closed)
[x] Label the pull request with the appropriate area(s)
[x] Assign potential reviewers (you may also want to contact them on Teams to ensure timely reviews)
[x] Assign the project - Engineering Playbook Backlog
[x] Assign the pull request to yourself

@wbreza do you want me to move the content in dev-sec-ops to this section once this is merged?  A lot of this content already exists there and then some.


[linux] Get DaylightTimeHelper.cpp to compile

Last remaining file in lib/Common/Common. This one is harder since it has dependencies on Win32 time APIs that are not implemented in the PAL (TzSpecificLocalTimeToSystemTime and friends)

This was implemented for both POSIX and macOS while ago.


Revert https://github.com/openfoodfacts/smooth-app/pull/3666

What

Revert https://github.com/openfoodfacts/smooth-app/pull/3666 so that we can release #3663 with a working scanner
Another option is  a hotfix for #3663

To give some context: the revamp of the scan is very important topic (probably the most important topic of the app), so we should not rush it just because the Flutter upgrade broke the scanner.
Reverting the upgrade to Flutter so that we have a working app (without the bug #3670), on which we can add and deploy fixes and improvements (such as #3663), will give us time to explore solutions (such as #3674 proposed by @monsieurtanuki), to make the right choices and to create a great scanning experience.

I've just PR'ed #3702.
The priority now should probably be to fix the MLKit part so that it works on flutter 3.7.

Thank you very much @monsieurtanuki 🙏


HMR Support

Description
Supports HMR(Hot Module Replacement, aka. Hot Reload) on development environment.
Tasks

[x] using custom file watcher instead esbuild.context.watch()

[x] on some files change, trigger rebuild() and get the metadata(path, etc..) of the changed files.
[x] implement custom file system watcher using chokidar

[x] transformer

[x] skip if file is not changed (transform changed file only)
[x] wrap modules with hmr context boundary

[x] implement swc plugin (https://github.com/leegeunhyeok/swc-plugin-react-refresh)

[x] send hmr update message to client
[x] evaluate updated code

[x] get updated module code from bundle

[ ] #41

References

react-refresh

Notes
// when receive update code from bundler
if (global.globalEvalWithSourceUrl) {
    global.globalEvalWithSourceUrl(code, sourceURL);
  } else {
    eval(code);
  }
};

Notes
branch: feat/38-hot-module-replacement_poc2

Implement swc plugin for react-refresh

Register React components
Create signature when component is using hooks

Finding updates

Enhance file system watcher
Enhance bundled module code (add boundary for search it)

And.. many things

https://github.com/leegeunhyeok/react-native-esbuild/assets/26512984/8249589c-ceba-43d9-a8e3-aa9e49d830d2

Notes
Reverse dependencies

Transform changed module only
Send reverse dependencies information to client

accept changed module updates + accept on parent modules too

Mistake > https://github.com/leegeunhyeok/react-native-esbuild/commit/de55ffb175d66437e18c8075122d94524eefdcb0

Notes

sideEffects: false issue > (https://github.com/evanw/esbuild/issues/2795)

please bring HMR to this project, it would be crazy

I have been waiting


Refactor connection protocol

Removes forgotten disclose protocol handling on Aries SM level
Weakens assumptions about connection confirmation message on Connection protocol Aries SM level. We have required that inviter must receive Ping or Ack message to progress to final state on Inviter side, however as rfc states, "any message will do":

After the Response is received, the connection is technically complete. This remains unconfirmed to the inviter however. The invitee SHOULD send a message to the inviter. As any message will confirm the connection, any message will do.

So instead of having handle_ping and handle_ack in inviter SM, these are replaced by handle_confirmation_message. If the final message happens to be Ping, it's up to upper layers to perhaps respond to ping, but shouldn't be part of Connection SM responsibility to respond Ping message (and no longer is, with the changes made).

Adds optional thread attribute to BasicMessage
Adds thread_id matching for all message types.

Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #542 (f6eb765) into main (8d3045e) will decrease coverage by 12.93%.
The diff coverage is 45.07%.

:exclamation: Current head f6eb765 differs from pull request most recent head fe32e94. Consider uploading reports for the commit fe32e94 to get more accurate results

@@             Coverage Diff             @@
##             main     #542       +/-   ##
===========================================
- Coverage   60.47%   47.53%   -12.94%
===========================================
  Files         173      173
  Lines       17840    14010     -3830
  Branches     4009     3179      -830
===========================================
- Hits        10788     6660     -4128
- Misses       2819     4301     +1482
+ Partials     4233     3049     -1184

Flag
Coverage Δ

integration-aries-vcx
49.38% <45.95%> (+0.14%)
:arrow_up:

unittests-agency-client
25.97% <32.79%> (ø)

unittests-aries-vcx
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

agency_client/src/api/downloaded_message.rs
0.00% <0.00%> (ø)

agency_client/src/api/messaging.rs
0.00% <0.00%> (ø)

agency_client/src/api/onboarding.rs
0.00% <0.00%> (ø)

agency_client/src/httpclient.rs
7.69% <0.00%> (ø)

agency_client/src/internal/mod.rs
0.00% <ø> (ø)

agency_client/src/messages/connect.rs
0.00% <ø> (ø)

agency_client/src/messages/create_agent.rs
0.00% <ø> (ø)

agency_client/src/messages/sign_up.rs
0.00% <ø> (ø)

agency_client/src/messages/update_connection.rs
0.00% <0.00%> (ø)

agency_client/src/messages/update_message.rs
0.00% <ø> (ø)

... and 275 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


need to add tests

all testing has been done manually as of now. there should be some automated testing covering the main use cases.

https://github.com/ChannyClaus/alembic-rebase/tree/main/tests done


Swift 3 Support

Does this project support Swift 3 ?

Created a PR for this: https://github.com/Ramotion/animated-tab-bar/pull/127


[Mentorship Diary] Matteo and Chetan

[Mentorship Diary] Matteo and Chetan
(Mentorship Round 2) @mcollina  will be mentoring @ckarande about streams in Node.js

Kick off Meeting Notes: July 15 2019
Introductions
Matteo introduced himself and scope of his work related to Node streams, http, and readable-stream package. He shared his goal of mentorship to have more contributors on these.
Chetan gave introduction to his experience with Node, work related to Node.js security, and his goals to contribute to Node core and share the learning to have more contributors.
Getting started with Node Core:
As next steps Matteo recommended Chetan to:

check out https://www.nodetodo.org/ to, setup local fork, running tests, get familiarized with the node core etc.
Look into some of the open issues at https://github.com/nodejs/node/issues?q=is%3Aopen+is%3Aissue+label%3A"good+first+issue"+sort%3Acreated-asc and send PR with fixes
Get prepared for further discussion on https://github.com/nodejs/node/issues/445 to clean up _writableState and _readableState

Next meeting:
We decided to meet in two weeks (July 29th)

@Bamieh  Can these meeting be recorded? This may help to people who want to followup in the same scope?

Notes: July 29, 2019
Discussion on updates since last meeting
Matteo and Chetan briefly went over the PR Chetan made for issue #28758  and command to run linter locally - make  -j4 test
Discussion on Issue 445
As per the option b and a reference fix, Chetan to find out instances where _writableState and _readableState  are being used, and start replacing them one at a time. Exclude those references for which the PR already exists.
Next meeting:
Meeting in around two weeks (August 9th)

@ankibalyan sorry for the late reply. its up to the mentor/mentee whichever they feel comfortable with doing. I'd certainly would love to see the meetings recorded!


Incorrect title

The title of each notes is not correct,  can i do anything to get the right titles?
Titles are like "B28E2F39481A4904AA75014D00AB8A9E","B6822D15AC69468CA7787E6DBB38DDED" and so on.
At last, THX for your contribution :D

It's in the json file. I use this statement to extract the title:
title = jsonObj['fileEntry']['name'].replace('.note', '')

Thanks for ur reply :D
I wrote another shell to rename my titles which include some chinese,like:
-- coding: utf-8 --
import requests
import sys
import time
import hashlib
import os
from requests.cookies import create_cookie
import json
import re
reload(sys)
sys.setdefaultencoding('utf8')
def get_files(path, rule):
all = []
for fpathe,dirs,fs in os.walk(path):   # os.walk获取所有的目录
for f in fs:
filename = os.path.join(fpathe,f)
if filename.endswith(rule):  # 判断是否是".json"结尾
all.append(filename)
return all
def list_file(root,postfix=''):
file_reserved=[]
files=os.listdir(root)
for item in files:
if os.path.isfile(os.path.join(root,item)):
if item.endswith(postfix):
file_reserved.append(os.path.join(root,item))
else:
if os.path.isdir(os.path.join(root,item)):
file_reserved.append(list_file(os.path.join(root,item),postfix))
return file_reserved
path = 'your_path/YoudaoNoteExport/notes'
file_reserved=[]
all_jsons = get_files(path,'.json')
for one_json in all_jsons:
json_data = open(one_json).read()
json_text = json.loads(json_data)
name = json_text['fileEntry']['name']
# print(json_text['fileEntry']['name'])
old_path = os.path.split(one_json)
same_docx =  old_path[0]+os.sep+os.path.splitext(old_path[1])[0]+'.docx'
newname = old_path[0]+os.sep+name+'.docx'
# print(same_docx,newname)
if(os.path.exists(same_docx)):
    os.rename(same_docx,newname)
#.decode('gbk').encode('utf-8')

Hope it can be helpful for others :D

Yeah. I'm sure it's helpful. But there is still something to handle. For example what if the name has special characters in it...

yeah...I replaced all illegal characters for windows file name to completely drag out my note since 2015.


BIP32 Paths do not conform to standards

Summary
The BIP32 paths used in this project do not conform to globally-accepted standards.
Impact
Users will not find their coins when moving mnemonics to/from xchainjs.

Users who create their mnemonic on xchainjs and move it to another wallet will not see their transaction history
Users who take an existing mnemonic with transaction history and move it into xchainjs will not see their transaction history

Solution
Fix all paths to conform to BIP44/84 standards so that mnemonics created/imported by xchainjs are compatible with other wallets.
Examples:
https://github.com/xchainjs/xchainjs-lib/blob/570a2186fc10d633886f2a0ddb7e0b20d295bcad/packages/xchain-polkadot/src/client.ts#L53

The 44 ordinal should be hardened: 44'
The coin_type ordinal should be hardened with a ' too
The account 0 should be hardened with 0'
The last key index is hardened when it should not be

if i recall correctly, polkadot does use // to denote hardened for their custom uri parser
and as far as the last key, i think that's a requirement of the uri parser. fails otherwise

i'm going to propose we address this by making xhchainjs have a pluggable derivation path, something along the lines of:
pseudo code
import { DerivationPath, BTCClient } from  ' xchain-client'

// create a btc client tha uses default HD paths
const btcClient = new BTCClient({
phrase: ' blah blah blah'
network: 'testnet',
DerivationPath: DerivationPath.XCHAIN_DEFAULT
})

// create a btc client tha uses  HD paths that are identical to Ledger v1
const btcClient = new BTCClient({
phrase: ' blah blah blah'
network: 'testnet',
DerivationPath: DerivationPath.LEDGER_V1
})

// create a btc client tha uses  HD paths that are identical to keepkey v1
const btcClient = new BTCClient({
phrase: ' blah blah blah'
network: 'testnet',
DerivationPath: DerivationPath.KEEPKEY
})

// create a btc client tha uses  HD paths that are identical to xchain v1.0
const btcClient = new BTCClient({
phrase: ' blah blah blah'
network: 'testnet',
DerivationPath: DerivationPath.XCHAIN_V1
})

// create a btc client tha uses  HD paths that are identical to what jaxx uses
const btcClient = new BTCClient({
phrase: ' blah blah blah'
network: 'testnet',
DerivationPath: DerivationPath.JAXX
})

i think this gives us the needed flexibility to support being compatible with other wallet providers so users of the lib can easily pick from a bunch of precanned HD paths or optionally create a custom one
also propose this goes into the @next version
thoughts?

closing as polkdot is no longer supported, we can revisit again if it is