Unclear precedence between scheduler and get with dask.config.set()

This came up in the xarray test suite when I was in the midst of refactoring to it to use scheduler= instead of get=:
import dask

count = [0]

def counting_get(*args, **kwargs):
    count[0] += 1
    return dask.get(*args, **kwargs)

dask.config.set(scheduler='sync')

dask.delayed(1).compute(get=counting_get)
assert count[0] == 1  # passes

with dask.config.set(get=counting_get):
    dask.delayed(1).compute()
assert count[0] == 2  # fails, because get was silently ignored

More generally, the problem is that it's possible to set both get and scheduler in dask.config.set (e.g., dask.config.set(get=counting_get, scheduler='sync')), but it isn't clear which setting takes precedence.
My suggestions:

If setting get is explicitly in an inner context, it should take precedence over scheduler.
It should be an error to try to set both get and scheduler at the same time.

I agree that this is an issue.

If setting get is explicitly in an inner context, it should take precedence over scheduler.

It's not easy for us to determine the scope of configuration changes.
We could however generally prefer get= over scheduler= , which might make sense.

It should be an error to try to set both get and scheduler at the same time.

This also makes sense
Any preferences?

If can't easily determine the scope, then erroring would certainly be better than silent failure.

The alternative would be to prefer get= over scheduler=.  The argument
would be that get= is lower level, and so arguably more explicit.
On Fri, May 18, 2018 at 2:37 PM, Stephan Hoyer<EMAIL_ADDRESS>wrote:

If can't easily determine the scope, then erroring would certainly be
better than silent failure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3512#issuecomment-390295890, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszHBTD_Uw45kIcY8EKUfYGUq_LjvGks5tzxUGgaJpZM4UEMYy
.

Okay then. No strong preference from me :)
On Fri, May 18, 2018 at 8:39 AM Matthew Rocklin<EMAIL_ADDRESS>wrote:

The alternative would be to prefer get= over scheduler=. The argument
would be that get= is lower level, and so arguably more explicit.
On Fri, May 18, 2018 at 2:37 PM, Stephan Hoyer<EMAIL_ADDRESS>wrote:

If can't easily determine the scope, then erroring would certainly be
better than silent failure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3512#issuecomment-390295890, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AASszHBTD_Uw45kIcY8EKUfYGUq_LjvGks5tzxUGgaJpZM4UEMYy
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3512#issuecomment-390296304, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABKS1mnS-A0MTIQVhUJj1pP0bgJOxq7_ks5tzxVdgaJpZM4UEMYy
.

Sorry if this is a little off-topic, but was there an old way to set the default scheduler everywhere before dask.config was introduced? I'm on the latest stable release and trying to work out the easiest way to run everything on the single-threaded scheduler for debugging.

+1 for preferring get over scheduler when set.
Long term we should figure out how we want to have the same level of control for whatever new interface evolves. ( https://github.com/dask/dask/issues/3708 )

We've removed the get= option.


move placement e2e out of staging

this replace the previous placement e2e in registration-operator by e2e in placement, since the latter has covered the former

/lgtm


Update exchanges.js

Bitstamp EUR/BTC EUR/USD

This PR wouldn't be enough, see #317.

the commit 006c90010c3 has everything needed for Bitstamp's Euro markets.


Tidy up layout.html

This PR refactors the html files in the qiskit_sphinx_theme subdir with the goal of creating a cleaner theme codebase that will be pulled in by the qiskit repos and reducing old unnecessary code.
Included in this PR:

Removed a lot of old code that seemed to not actually do anything
Uncovered user feedback buttons ('was this page helpful?') - later PR will connect this to segment analytics, for now just frontend uncovered
theme can now pull the repo name as a variable from the repo itself, as long as the repo_name var is set in their conf.py - later README should be updated to enforce this (#69)
searchbox reformatted to pull in the repo name

The ToDo list has some pending, so moving this into draft. Feel free to put it back when ready for review.

I have split out the work from the original PR into separate ones that can be PRed against the layout_refactor branch instead of main. The scope of this PR has now been reduced to just removing old code and tidying up the layout.html to make it more readable. This is now ready for review

example layout:

@1ucian0 I put back the original links in the header bar for now, so will just get removed once #64 is completed. Lmk if there are any further changes needed on this :)

@1ucian0 I put back the original links in the header bar for now, so will just get removed once #64 is completed. Lmk if there are any further changes needed on this :)

I think it would be good to keep using the theme variables for now but can you also update the links in theme_varialbes.jinja to have the same links as the new top menu for the time being?
https://github.com/Qiskit/qiskit_sphinx_theme/blob/1035b33351150d640484e538e0123ca3c7d0da47/qiskit_sphinx_theme/theme_variables.jinja#L14-L15
'textbook': 'https://qiskit.org/learn/',
'slack': 'https://ibm.co/joinqiskitslack',

Remove Pytorch links:
https://github.com/Qiskit/qiskit_sphinx_theme/blob/1035b33351150d640484e538e0123ca3c7d0da47/qiskit_sphinx_theme/theme_variables.jinja#L17-L19

While you are at it, can you also update this line to reflect that the theme is qiskit sphinx theme.
https://github.com/Qiskit/qiskit_sphinx_theme/blob/1035b33351150d640484e538e0123ca3c7d0da47/qiskit_sphinx_theme/footer.html#L63
Built with Sphinx using Qiskit Sphinx Theme .


[Feature]

Summary
A clear and concise description of what the problem is, and what you solution you want.
Changes
What changes this feature would introduce. Any risks these changes involve. Any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

09108002079 ارز RAY  برداشت زدم ولی کم شد از ولت منتهی موفق نبود تراکنشم

توضیحاتی رو که میدید رو من نمیفهمم

میتونم یه شماره برای تماس داشته باشم

Hello @Vzp1988
Hello @EK2EvilKongs
Thanks for posting this issue, this will be reviewed and pending review, contact the dedicated 24/7 Solana support page to report this as well, remember to follow all instructions provided to resolve this quicker.


Swagger UI is giving following error

Is this still an issue? On what request do you see this error?

Have you changed anytging ? if no then it still might be an issue.

Again, at what request do you see this error? /api/docs? This works for me, I just tested. And what version do you use?

I pulled the latest code on the day I  logged this issue.


Filters not working on OS Hub site

Sector filter -
Several lists have been uploaded with “Electronics” or “Consumer Products” as the sector. When you select either of those sectors in the drop down, no facilities are returned.
https://5e7e9bbe1de56315bc37e39f.openapparel.org/?q=Appl&sectors=Consumer Products&sectors=Electronics
Product type filter -
This was working yesterday (July 6), where I could search for "networking" which is a product type in the Dell list. Today, searching for networking or other product types in the Dell list doesnt' return anything.
https://5e7e9bbe1de56315bc37e39f.openapparel.org/?q=Appl&product_type=networking

This was an issue with other filter values and it trying to search by AND logic across multiple filters.


Rebasing to version 1.2.1

New version

@miosukakura This is an old version by several months, please look at a rebase to version 1.2.9 here https://github.com/morrillup/chaingreen-blockchain


New Add-on for RHOAR Launch

It will be nice to have new add-on that helps in deploying RHOAR Launch, right now the steps are here https://appdev.openshift.io/docs/minishift-installation.html

I think this issue can be closed as https://github.com/minishift/minishift-addons/tree/master/add-ons/fabric8-launcher is available now


Please update version on supermarket

The version 0.9.2 is more than a year old...

Hi @brauliobo
I've just shipped 0.9.4 which will be the last in the 0.9.x series. 1.0 will contain a few breaking changes as it's a full re-write of master, which is still currently broken (I'm updating the README shortly to reflect this fact).

@martinisoft thanks!


Export examples/explorer as a requirable widget

blessed-contrib/examples/explorer.js

Can you please elaborate a bit further? I am willing to take some of this on, but would like to understand your use case so I can figure out a few things like...
What sort of configuration options would you like to see available?
What events do you want to be able to hook into? (just file selections, directories, up/down, etc)
Does it need to be refreshable?
Do things need to be marked as 'selected'?

Theoretically I would be using this in slap to replace the lightly customized but mostly default blessed.FileManager.
Amenable to discussion:

Should hook into a select event where a row is clicked or Enter is pressed while one is focused
file and directory events cool too
Ability to get current focused row
Selecting a directory by clicking on it or pressing Enter should unfold the directory

Maybe make this cancelable?

Should be able to refresh an arbitrary level, only one level deep would be good enough
Each row's display value from beginning to end should be editable, regardless of internal state
Multiple selections would be great but not necessary
Root should be selectable via API

cc @theredcat

Don't look complicated. The select event is already here and can be hooked to handle higher-levels events.
I may have a simple way to integrate this just by overloading the constructor of Tree

BTW, sould I name the file file.js or filetree.js ? Since the File object already exists in blessed, it would be confusing to name it file too

@dbkaplun would you like to have the file stats object as a event callback parameter? Or the path will be enough?

For the sake of performance, simply a path will be enough, but if you already get a Stats object then it's nice to have.


NiFi-1481 Enhancement[ nifi.sh env]

Initial working version of nifi-1481 , with plenty of room for enhancement.
It may help to close https://issues.apache.org/jira/browse/NIFI-1481

@apiri Can you please review it.

@trkurc Please review once you get a chance.

@trkurc Any chance to review out of your busy schedule yet?

I looked it over and gave it a try, I don't have any substantive comments yet, this was queued behind getting 0.5.1 out. I think this is a good candidate for 0.6.0.

@trkurc Thanks. I shall keep it as is & look forward to see it as part of 0.6.0.

reviewing

@PuspenduBanerjee going to need to investigate a couple of things further.  With JAVA_HOME set, operation worked as anticipated for both OS X and Linux.  Windows had issues with the path declaration.  Quoted those items, but had issues with establishing NIFI_ROOT.  Cygwin also seemed to have

@apiri For now I have no way to check Windows or Cygwin as I do not have any MS windows installation, total linux guy and on vacation to my homeland, so can't even borrow a windows PC from a colleague. . Please help to find out someone with Windows.

@apiri @PuspenduBanerjee I can take a whack at those windows fixes.

Sounds good, @trkurc.  Just personally ran out of steam digging into it last evening.

@trkurc Appreciate the Spirit.

I have a suggested fix/hack for dealing with spaces in the Java path in env-nifi.bat).  The fix converts the TOOLS_JAR path into a short 8.3 path without spaces, so the eventual call to NiFi has only one quoted parameter.  The expanded TOOLS_JAR path was not working due to spaces, and two quoted paths make the whole thing blow up for reasons I do not comprehend.
However, this was not enough to get the env feature running on Windows 10.  Running it outputs
17:58:32.959 [main] DEBUG o.a.n.b.NotificationServiceManager - Found 0 service elements
17:58:32.963 [main] INFO  o.a.n.b.NotificationServiceManager - Successfully loaded the following 0 services: []
17:58:32.965 [main] INFO  org.apache.nifi.bootstrap.RunNiFi - Registered no Notification Services for Notification Type NIFI_STARTED
17:58:32.987 [main] INFO  org.apache.nifi.bootstrap.RunNiFi - Registered no Notification Services for Notification Type NIFI_STOPPED
17:58:32.989 [main] INFO  org.apache.nifi.bootstrap.RunNiFi - Registered no Notification Services for Notification Type NIFI_DIED
17:58:33.012 [main] DEBUG org.apache.nifi.bootstrap.Command - Status File: bin\nifi.pid
17:58:33.013 [main] DEBUG org.apache.nifi.bootstrap.Command - Status File: bin\nifi.pid
17:58:33.040 [main] DEBUG org.apache.nifi.bootstrap.Command - Properties: {port=40930}
17:58:33.041 [main] DEBUG org.apache.nifi.bootstrap.Command - Pinging 40930
17:58:33.078 [main] DEBUG org.apache.nifi.bootstrap.Command - Sent PING command
17:58:33.080 [main] DEBUG org.apache.nifi.bootstrap.Command - PING response: PING
17:58:33.081 [main] INFO  org.apache.nifi.bootstrap.Command - Apache NiFi is not running

Where the last line "Apache NiFi is not running" matches RunNiFi.java line 559, where the env() method quits after not finding a PID.  Yes, NiFi was running when I tested this.  In comparison, the status-nifi.bat outputs
17:49:49.660 [main] DEBUG o.a.n.b.NotificationServiceManager - Found 0 service elements
17:49:49.664 [main] INFO  o.a.n.b.NotificationServiceManager - Successfully loaded the following 0 services: []
17:49:49.666 [main] INFO  org.apache.nifi.bootstrap.RunNiFi - Registered no Notification Services for Notification Type NIFI_STARTED
17:49:49.690 [main] INFO  org.apache.nifi.bootstrap.RunNiFi - Registered no Notification Services for Notification Type NIFI_STOPPED
17:49:49.691 [main] INFO  org.apache.nifi.bootstrap.RunNiFi - Registered no Notification Services for Notification Type NIFI_DIED
17:49:49.719 [main] DEBUG org.apache.nifi.bootstrap.Command - Status File: bin\nifi.pid
17:49:49.723 [main] DEBUG org.apache.nifi.bootstrap.Command - Status File: bin\nifi.pid
17:49:49.749 [main] DEBUG org.apache.nifi.bootstrap.Command - Properties: {port=40930}
17:49:49.752 [main] DEBUG org.apache.nifi.bootstrap.Command - Pinging 40930
17:49:49.798 [main] DEBUG org.apache.nifi.bootstrap.Command - Sent PING command
17:49:49.801 [main] DEBUG org.apache.nifi.bootstrap.Command - PING response: PING
17:49:49.804 [main] INFO  org.apache.nifi.bootstrap.Command - Apache NiFi is currently running, listening to Bootstrap on port 40930, PID=unknkown

Which recognizes that NiFi is running based on isRespondingToPing() (line 532), and describes the PID as "unknkown".  Since it looks like you use the PID in the env method, I'm not immediately sure what to suggest next.  It might be possible to work out an "if Windows, do this to get the PID" flow.

I discovered the same issue with the pid on windows 10. My fix was to use quotes a bit differently on the cmd.exe line (cmd.exe /C ""%JAVA_EXE%" %JAVA_PARAMS% %BOOTSTRAP_ACTION%" ) and (set JAVA_PARAMS=-cp "%TOOLS_JAR%";%CONF_DIR%;%LIB_DIR%* -Xms12m -Xmx24m %JAVA_ARGS% org.apache.nifi.bootstrap.RunNiFi)

The pid is not being recorded in the nifi.pid file after I run RunNiFi with start or run, haven't been able to diagnose why yet. @markap14 may have an idea.

push my changes up to a fork, in case anyone was interested (https://github.com/trkurc/nifi/commit/5ebf228a9ba5c5ce9f12189988920f94923e6210 from https://github.com/trkurc/nifi/commits/NIFI-1481)

@trkurc  isn't cmd.exe /C ""%JAVA_EXE%" %JAVA_PARAMS% %BOOTSTRAP_ACTION%"  equivalent to cmd.exe /C %JAVA_EXE%" %JAVA_PARAMS% %BOOTSTRAP_ACTION%"

@PuspenduBanerjee sadly, no, no it is not. https://technet.microsoft.com/en-us/library/bb490880.aspx

(See the section labeled "Processing quotation marks ". ). So bizarre.

@trkurc  Oh Man! Thanks for your guidance. Any chance of using power-shell in future?

Also, @jvwing I fixed that misspelling of unknown when I was hacking on RunNiFi

After an out of band discussion with @markap14, seems that windows pids might be challenging to get, so maybe we should leave the Windows env batch script out for 0.6.0. Any objections?

@apiri - cygwin is proving to be a challenge, and not necessarily due to the changes in this patch.
On my setup, the ':' separator on this line seems to break things (I suspect because my java is expecting ';' separators for things on the classpath)
See:
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh#L192

@trkurc I think it might be a fair concession to have both this and Windows punted. Maybe we just roll in the check piggybacking off of the already existing $cygwin and figure out how we can improve later?

@apiri: how would you think it best to review the changes I made based on your reviews? Another PR? A patch on the ticket?

Patch to apply on top of the PR is probably simplest, but am good with whatever is easiest for you.

@apiri - I attached a patch to the ticket, which should be the last two commits off my branch https://github.com/trkurc/nifi/commits/NIFI-1481

@trkurc Okay, will apply over the top and review.  Thanks!

@trkurc Patch unfortunately is not applying even on a fresh checkout of the 218 PR.  Will checkout your branch and work from there.
Patch issue was:

$ git am --signoff ~/Downloads/NIFI-1481.001.patch
Applying: NIFI-1481: Code review fixes
error: patch failed: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/env-nifi.bat:50
error: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/env-nifi.bat: patch does not apply
Patch failed at 0001 NIFI-1481: Code review fixes

@trkurc What is the final verdict on handling of Windows and Cygwin?  Are we punting those for now? If so, would like to provide handling for env with cygwin in nifi.sh and removal of the .bat for now. Happy to do these myself, but wanted to avoid another level of indirection.  Let me know what works.
Otherwise, your branch as presented looks good and works as anticipated.

@apiri - I tried last night to get the pid to get Windows to work. I could not. I say we shelve the env batch script (remove it for now from the patch set).
On cygwin does "nifi.sh run" or "nifi.sh status" work at all for you without these patches? It did not for me. What were you proposing to fix cygwin? Get run and start working, then try to get env working as well?

So, after discussion with @apiri, we removed the env batch script because it did not work due to limitations of bootstrap, and reworked nifi.sh to build the classpath for Bootstrap to work with cygwin and !cygwin and only include TOOLS_JAR if set.


Exit button or hotkey must be added.

I'm always frustrated when using the linutil utility because pressing CTRL+C does not exit the utility as expected. This makes it difficult to exit the program quickly and interrupts the workflow, especially when I want to abort the current operation.
Hence, I would like the utility to include a clear exit option, either through a visible "Exit" button in the UI or by mapping a hotkey (e.g., CTRL+C or ESC) that immediately exits the utility. This would provide a straightforward way to terminate the program without confusion.
As an alternative, the utility could display a prompt asking for confirmation before exiting when CTRL+C is pressed, or it could introduce an additional hotkey that functions solely to exit the utility.
Adding this feature would improve the user experience by allowing users to exit the utility in a more intuitive and expected manner, aligning with common behavior in terminal-based applications.

( Q ) Is this current keybind to exit Linutil.


VS2019 doesn't load sample projects

Hi.
When I open the wpf samples solution with VS2019 Community I get the following loading projects error.

: The project file cannot be opened by the project system, because it is missing some critical imports or the referenced SDK cannot be found.
Detailed Information:
Unable to locate the .NET Core SDK. Check that it is installed and that the version specified in global.json (if any) matches the installed version.

I've installed the .NET Core SDK

However, I can create and run WPF .NET Core 3.0 apps with Visual Studio.

Opps, sorry I was need to install the 3.0.101 version.

Hi,
Do you have solved the problem after install the .NET Core 3.0.101? I meet the same problem with you, but I do not find the  .NET Core 3.0

Hi,
Do you have solved the problem after install .NET Core 3.0.101? I meet the same problem with you ,but I do not find the .NET Core 3.0.101 Installation package

You can get .NET Core 3.0.101 SDK from https://dotnet.microsoft.com/download/dotnet-core/3.0

Yes, It's fixed installing the correct version :)

Thank you！

I just downloaded and attempted to open in Visual Studio 16.4.3 without success.  I manually downloaded the latest version of the .Net Core SDK.  Same problem. The project does not open out of the box.


Move mlir_graphblas.tests.jit_engine_test_utils.sparsify_array into mlir_graphblas.tools.utils

The sparsify_array function in mlir_graphblas.tests.jit_engine_test_utils is quite useful outside of testing.
We should move it into a non-testing Python module. I think mlir_graphblas.tools.utils would be a good place to put it.

https://github.com/metagraph-dev/mlir-graphblas/commit/d5d41a5fcae1e1cc9eb85e9eb0708ffddddb36f9 completes this task.


Build Binary/Docker image for every PR

Is your feature request related to a problem? Please describe.
Ensure that every PR is able to build both docker image and binary on ubuntu
Describe the solution you'd like

Ensure that code compiles on  every PR
We are able to build docker images on every PR

I believe we can close this with the test I added in https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/49


Upgrade Docker image/Ruby/RoboCop

When this Dockerfile was originally defined there was not a pre-built compose image. Having that available dramatically simplifies the Dockerfile here. The need for upgrade comes from the fact that the previous version of Alpine was bringing along a very old version or Ruby (2.3) which is not longer supported and some gems were failing to install.

          1 Message

:book:
We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

  Generated by :no_entry_sign: Danger


fix: use ws-port flag with runtime, default value 9000

Problem
In PR https://github.com/kinode-dao/kinode/pull/282 of the runtime, the flag for passing a ws-networking port is changed to --ws-port. The old name of --network-router-port was not suitable because nodes have multiple networking protocols available to them. We need to specify that this is the port for the WebSockets protocol.
Solution
This PR changes kit to use the new flag. It also sets the default port to 9000, to match the behavior of the runtime.
Notes
Do not merge until the PR linked above is added to a new runtime release (will be 0.6.2)

@dr-frmr closing now; reopen if I misunderstood discussion in discord


PHP page after installtion

Hello,
As a  linux's neophyte user i tried to follow some tutorials to installl CachetHQ:
Your documentation -> not enough complete for a neophyte like  me
https://www.rosehosting.com/blog/install-cachethq-on-debian-7-vps/ -> doesn't work
http://trevormanternach.com/2015/03/24/installing-cachet/ -> This is the one i currently use
With the one i use after following all the steps i always come to a weird php page after the installation:

Hope you'll be able to help me :)
Kind regards,
Vialaxy

Looks like you don't have PHP installed with the Apache modules. If that's the case, you'll also need to enable the rewrite module with a2enmod rewrite as it'll likely be disabled.

PHP already installled and rewrite already enalbled too :/
I've exactly follow this tutorial : http://trevormanternach.com/2015/03/24/installing-cachet/
Just added the .env config before the php artison migrate  as you state it in your documentation

Do you get any errors when running migrate?
Have you setup the DocumentIndex to include PHP?

This is an environment issue rather than Cachet, so I'm closing the issue, but will continue to help.


system power states

Currently Zephyr classifies power states into two categories, sleep state and deep sleep state, based on whether the CPU loses execution context during the power state transition, and every state has more sophisticated sub-states(SLEEP_1, SLEEP_2, SLEEP_3, DEEP_SLEEP_1, DEEP_SLEEP_2, DEEP_SLEEP_3) which are classified only by the residency duration. But it's not enough to define power states based on only whether CPU loses execution context, also there is no technical rules to classify sub-states. It's intended to give more flexible for vendors and users to do power management, but it really makes huge noise for long time because of the uncleared and confused definitions.
ACPI specification defines cleared power states which has already been adopted by other OSes(AFAIK linux and windows), so I suggest Zephyr also do power state definition based on ACPI spec. The sleep states that can be supported by Zephyr are listed below.
Working state Runtime active state
During runtime active state, the system is awake and running. In simple terms, the system is in a full running state.
Runtime idle state
Runtime idle is a system sleep state in which all of the cores enter deepest possible idle state and wait for interrupts, but all the devices are awake and in normal state, no requirements for the devices, leaving them at the states where they are.
Suspend to idle state
The system goes through a normal platform suspend where it puts all of the cores in deepest possible idle state and puts peripherals into low-power states(possibly lower-power than available in the working state runtime active state). No operating state is lost (the cpu core retains power, does not lose execution context), so the system can go back to where it left off easily enough.
Standby state
In addition to putting peripherals into low-power states, which is done for suspend to idle too, all non-boot CPUs are powered off. It should allow more energy to be saved relative to suspend to idle, but the resume latency will generally be greater than for that state. But it should be the same state with suspend to idle state on uniprocesser system.
Suspend to ram state
This state offers significant energy savings by power off as much of the system as possibleas everything in the system is power gated,  where memory should be placed into the self-refresh mode to retain its contents. The state of devices and CPUs is saved and held in memory, and it may require some boot-strapping code in ROM to resume the system from it.
Suspend to disk state
It gets the greatest power savings through powering off as much of the system as possible, including the memory. The contents of memory are written to disk/flash, and on resume it's read back into memory with the help of boot-strapping code, restores the system to the same point of execution where it went to suspend to disk.
Soft off state
This state consumes a minimal amount of power and requires a large latency in order to return to runtime active state the Working state. The contents of system(CPU and memory) will not be preserved, so the system will be restarted if woken by any wakeup-source.
And the implementation of this RFC will be the start of PM overhaul.

@pabigot

Where are these ACPI states documented?
Looking at the 6.3eB specification section 2.2 I see G0 is Working, G1 is Sleeping.  Figure 16-74 in section 16.1 shows four (S1-S4) substates within G1, though S5 is also mentioned. It seems to break down to:

G0 Working
G1/S1 low wake-latency sleeping...
G1/S2 S1+system memory can be lost
G1/S3 S2+more power domains shut down
G1/S4 S3+all devices powered off
G2/S5 Soft Off

These don't match to what you describe.  Which is fine, I just want to see a design that's clearly informed by an existing specification/architecture that we can go to to resolve questions.

I've interpreted the sleep states for sam0 as "idle" versus "standby" modes documented in the samd21 datasheet.  "Idle" might translate to "Runtime idle" and "standby" might translate to "Suspend to idle"

Where are these ACPI states documented?

reference ACPI spec you mentioned and also linux doc

OK, I see some of it in the Linux documentation.  Specifically I see that on ACPI systems these Linux system-wide states might map to ACPI states:

Standby => G1/S1
Suspend-to-RAM => G1/S3
Hibernation (aka Suspend-to-Disk) => G1/S4 or G2/S5

But you're mixing terms from two domains.  In Linux Working state is a power management scheme for non-sleep states: the states should be:

"Runtime Active" when all system components are active; and
"Runtime Idle" when "all [system components] are inactive".

The other power management scheme System-wide provides the suspend-to-idle, standby, suspend-to-RAM, and hibernation states.
So the Linux architecture splits the working and sleep states into two different schemes.  This seems like a good idea; but how does it map to Zephyr?
I don't see the terms you provided used in the ACPI reference, and they are not one-to-one with Linux terms.  We can say that the terms in this RFC are related to terms used by Linux, but not ACPI.  And because they're only related and from different Linux management schemes they are not part of a clearly defined existing power management architecture.
Which (again) doesn't mean we can't use them, but it does mean this is nowhere near enough description of a power management architecture to be used as a basis for implementation.
Why aren't we starting with the existing architecture, terminology, and PI from Linux, and describing what Zephyr will do in terms of how it's different?

For the device dependency, per #22941, @tbursztyka has already started to work on that, but no clear APIs exposed to other sub-systems so far, assume the dependency info will also be used to device initialization process, during which device_pm_add API of pm side will be called to construct the device list used by PM sub-system, the sequence of device suspend and resume will be based on that list instead of complicated data structure(tree or graph) to save sizes and reduce runtime latency; but if DTS code for device dependency can give such list somehow, pm side wouldn't maintain it again.

And for device runtime pm, the children info also be recorded in struct device based on the API of device dependency, parent can only be suspend if all of it's children suspended. This part will consider more, some problems haven't details yet, for example implementation will be based on current device runtime infrastructure or onoff service which I'm reviewing, and in which context parent suspend will be invoked if its last child suspended, etc.

Statement for runtime idle state has been updated, it has no requirements for the devices and just leaving them at where they are because device runtime pm may already put them off.

When system wide power management works with device runtime PM at the same time, the sync between them should be considered carefully, for example when system wide PM is functional, device PM should be paused and follow system wide PM logic, and as #22391(suggested by @vanti) indicated, the resume should consider the usage count of device, etc.

The PM sub-system will consist of pm policy, pm core, pm platform, device pm and device runtime pm. The pm policy is to make the decision about the next system state based on the constraints and system idle time, etc. Pm platform layer will expose the supported power states and do the actual power things for every platform, e.g. wfi/wfe, save cpu states and power gate cpu core, ram retention/shutdown, etc. Device pm layer will do devices' clock/power gate. Pm core will expose APIs to pm manger where pm logic will run and do the switch and lock, etc. The infrastructure of pm policy, pm core, pm platform and device pm is very straight forward, we should think about each layer's structures and APIs carefully and I'm still considering them. As mentioned above, The infrastructure of device runtime PM is still under considering.

Please change "Working state" in the list of states to "Runtime active state" to be consistent with "Runtime idle state" and the way the terms are used in Linux.
This also helps makes clear that there are two general states: runtime, and sleep.  The remaining five states are sleep states.
It would be nice if all the power-related state names matched their Linux inspiration.

PM state
typedef enum pm_state {
	PM_STATE_RUNTIME_ACTIVE = 0,
	PM_STATE_RUNTIME_IDLE,
	PM_STATE_SUSPEND_TO_IDLE,
	PM_STATE_STANDBY,
	PM_STATE_SUSPEND_TO_RAM,
	PM_STATE_SUSPEND_TO_DISK,
	PM_STATE_SOFT_OFF,
	PM_STATE_MAX
} pm_state_t;

PM policy structure and API
struct pm_policy_api {
	void (*init)(void);
	pm_state_t (*next_state)(struct pm_policy *policy);
	int (*set_constraint)(struct pm_policy *policy, pm_state_t state);
	int (*release_constraint)(struct pm_policy *policy, pm_state_t state);
};

struct pm_policy {
	int supported_states[PM_STATE_MAX];
	struct pm_policy_api *policy_api;
};

#define PM_POLICY_DEFINE(_name, _rt_active, _rt_idle, _suspend_to_idle, _standby, _suspend_to_ram, _suspend_to_disk, _soft_off, _api) \
	static const Z_STRUCT_SECTION_ITERABLE(pm_policy, _name) = \
	{ \
		.name = STRINGIFY(_name), \
		.supported_states = {_rt_active, _rt_idle, _suspend_to_idle, _standby, _suspend_to_ram, _suspend_to_disk, _soft_off}, \
		.policy_api = &_api \
	}

static inline void pm_policy_init(struct pm_policy *policy)
{
	if (policy && policy->api) {
		policy->api->init();
	}
}

static inline pm_state_t pm_policy_next_state(struct pm_policy *policy)
{
	if (policy && policy->api) {
		policy->api->next_state(policy);
	}
}

static inline int pm_policy_set_constraint(struct pm_policy *policy, pm_state_t state)
{
	if (policy && policy->api) {
		policy->api->set_constraint(policy, state);
	}
}

static inline int pm_policy_release_constraint(struct pm_policy *policy, pm_state_t state)
{
	if (policy && policy->api) {
		policy->api->release_constraint(policy, state);
	}
}

static inline struct pm_policy *pm_policy_get(char *name)
{
	Z_STRUCT_SECTION_FOREACH(pm_policy, policy) {
		if (strcmp(policy->name, name) == 0) {
			return policy;
		}
	}
	return NULL;
}

@wentongwu Could you put that into a draft PR that has the API in a header (with documentation) so we can review it?  I have comments, but can't provide them here.

@wentongwu Could you put that into a draft PR that has the API in a header (with documentation) so we can review it? I have comments, but can't provide them here.

sure, will do.

PM core
The PM core will get the pm state where system is going to with pm policy APIs, and it should be called with interrupt locked. And according to the decided next system pm state, it will suspend devices(if needed) and platform in sequence with the defined interfaces.
For the device suspend in some power states, it will take two steps. First is the device prepare stage, it will be executed with scheduler locked(k_sched_lock) to allow do some sync if needed with the connected slave/master, the well prepared devices will be linked into dev_prepared_list which will be the foundation of next step, however device can't reject the power state switching in this state because pm policy layer already provides constraint API. However during this, it's possible that there are wake-up interrupts, in that situation a global wake-up count will be defined to record wake-up happened or not, and it will be checked at the beginning of next step(if wake-up happened, the ongoing suspend will be stopped). And for the second step, it will clock/power gate the devices based on dev_prepared_list with irq locked.
After that platform suspend will happen with the defined APIs struct platform_suspend_ops.
Hold on, during typing this comment, I have another idea, run-time device pm will be always on(maybe no Kconfig option) to take care devices' pm, and it will provide API to indicate device states that can be used to pm policy layer to help decide system next state. And that will give more flexible to control device's pm state by device self. @pabigot what's your thoughts about this?

We cannot assume that devices can transition power levels synchronously from within an interrupt.  Rather, the allowed system power state must be affected by the states the devices are in.
This does suggest that device power management must always be on and devices should automatically transition to the lowest power state consistent with application needs.
I think the idea that system power management should control device power management is workable only with a well-defined model of application needs that can constrain system power management.  It is not in general acceptable for the system to say "I'm going to sleep, everybody shut down" if the application is waiting for a response from an external device that will be lost if the system sleeps.  We don't have such a model.
So I still feel we're going too deep without agreeing on and documenting the general design principles and goals.  That includes an architectural vision, core concepts, and (abstract) data structures including dependencies and constraints: what they are, how they're represented, and how they affect transitions between system power states.  So far the only thing described in any detail is the static power states.
For example the concept of an interrupt occurring during a power level transition and so blocking completion of that transition must have been addressed before.  How is it handled in the TI and other power management architectures?

I think the idea that system power management should control device power management is workable only with a well-defined model of application needs that can constrain system power management. It is not in general acceptable for the system to say "I'm going to sleep, everybody shut down" if the application is waiting for a response from an external device that will be lost if the system sleeps. We don't have such a model.

see the pm policy API, it defined constraint API to constrain system power management, the state pm core will follow come from pm policy layer. Ok, I will give more documentation about that.
struct pm_policy_api {
	void (*init)(void);
	pm_state_t (*next_state)(struct pm_policy *policy);
	int (*set_constraint)(struct pm_policy *policy, pm_state_t state);
	int (*release_constraint)(struct pm_policy *policy, pm_state_t state);
};

We cannot assume that devices can transition power levels synchronously from within an interrupt.

sure, power transition will not happen in interrupt, I mean the sync between device driver and device firmware will be the first step, device driver will start the sync message which runs in idle thread context, and the response(ack) will the interrupt and if receive the interrupt the device will be put to the dev_prepared_list. The second step will do the actual power transition in idle thread context based on the dev_prepared_list. There may be limitations for the sync if the response need a read, so suggest another idle as above.

Rather, the allowed system power state must be affected by the states the devices are in.

But we should well consider that device rejects the suggested power state, if happened, we only will go into run-time idle. It has the same effect if devices states can affect the ongoing system pm state.

@pabigot @nashif @vanti I attach the API here https://github.com/wentongwu/zephyr/commit/598eab9f6d8204a29c821db95fb9cbabf4d23e75 we have so far, please share some comments to avoid going differently with anyone's idea in head. platform pm API and device pm API is still in progress, after that will settle down the implementation of the pm core(or pm manager).

@wentongwu Can we relax the definition of "Suspend to ram state" state a bit to include states such as the standby mode on TI CC1352, where almost everything is power-gated, with the exception for some minimal CPU logic that is required for waking up from the same point without restarting? I think the word 'everything' is a bit strong here.

Just capturing some information about existing states.  The ones at the top are Zephyr; I think the names are good, and the other references can show what we mean by those states.
The draft API pointed to above should incorporate documentation that explain more clearly what's meant by those states (the Linux System State link has the most detail).

Linux Power Management
Linux System Sleep States
Linux Working State
ACPI States
S0ix in Linux

System power management states:

Zephyr
ACPI
Linux

Runtime Active
S0
Runtime active

Runtime Idle
S0ix
Runtime idle

Suspend to idle
S1
Suspend-to-idle (S2, S2Idle)

Standby
S2?
Standby

Suspend to RAM
S2 or S4
Suspend-to-RAM (STR, S2RAM)

Suspend to Disk
S4
Hibernation

Soft Off
S5

Device States

Zephyr
ACPI
Linux

TBD
D0 (Fully On)
??

TBD
D1, D2
??

TBD
D3 (Hot, Cold)
??

@wentongwu Can we relax the definition of "Suspend to ram state" state a bit to include states such as the standby mode on TI CC1352, where almost everything is power-gated, with the exception for some minimal CPU logic that is required for waking up from the same point without restarting? I think the word 'everything' is a bit strong here.

@vanti updated. Thanks

Zephyr
ACPI
Linux

normal(PM_ACTIVE_STATE)
D0 (Fully On)
??

clock gate(PM_SUSPEND_STATE)
D1, D2
??

power gate(PM_OFF_STATE)
D3 (Hot, Cold)
??

@pabigot @vanti how about we use the current definition for device pm state?

another problem, if all of the code get ready, which one is the best platform we do the test?

Zephyr	ACPI	Linux
normal(PM_ACTIVE_STATE)	D0 (Fully On)	??
clock gate(PM_SUSPEND_STATE)	D1, D2	??
power gate(PM_OFF_STATE)	D3 (Hot, Cold)	??
@pabigot @vanti how about we use the current definition for device pm state?

maybe not clock gate, the working clock of some device can be controlled, maybe the defined API for device pm should consider it.

Zephyr	ACPI	Linux
normal(PM_ACTIVE_STATE)	D0 (Fully On)	??
clock gate(PM_SUSPEND_STATE)	D1, D2	??
power gate(PM_OFF_STATE)	D3 (Hot, Cold)	??
@pabigot @vanti how about we use the current definition for device pm state?

I think active/suspend/off sound fine.

another problem, if all of the code get ready, which one is the best platform we do the test?

The infrastructure should be tested on multiple platforms in my opinion, to make sure it is flexible enough.

I don't like "power gate" and "clock gate" since those are (AIUI) technologies that produce a savings in power, not low-power states.  I've also not seen any non-MCU/CPU devices (e.g. I2C or SPI ICs) that document their low power modes in those terms.
Remember there are four states to capture.  Would it be active/suspend1/suspend2/off?  That's getting vague.
So I'm leaning towards D0, D1, D2, D3.  Then, for consistency, I've gotta change my position on system and go for S0, S0ix, S1, S2, S3, S4, S5.  My motivation for the existing Linux-based names was it's more clear what those states mean, but that could be addressed by clear documentation (might even be better, as we can go into detail without getting wrapped up in what's implied by "suspend to RAM".  (Though S0ix might become S0i) to indicate "idling in S0" rather than something to do with Intel-specific stuff).
Given where we are, I believe a one-to-one correspondence to an existing architecture like ACPI has the best chance for meeting cross-platform needs.  I would prefer a different functional-based architecture for the device power states but I don't think that's going anywhere.

this is now done.


E0277: Handler<_, _> is not implemented for `fn(Formsubscriptions::FormData, actix_web::web::Data<Pool>)

I'm seeing this error every now and then. Sometimes when adding dependencies manually or just now after trying your latest release of tracing-actix-web 0.4.0-beta.1. I believe I first saw it after mistakenly adding actix-web-4.0.0-beta.6 instead of beta.3 as specified in the book.
error[E0277]: the trait bound `fn(Form<subscriptions::FormData>, actix_web::web::Data<Pool<Postgres>>) -> impl std::future::Future {subscriptions::subscribe}: Handler<_, _>` is not satisfied
  --> src/startup.rs:15:53
   |
15 |             .route("/subscriptions", web::post().to(subscribe))
   |                                                     ^^^^^^^^^ the trait `Handler<_, _>` is not implemented for `fn(Form<subscriptions::FormData>, actix_web::web::Data<Pool<Postgres>>) -> impl std::future::Future {subscriptions::subscribe}`

Should be reproducible by setting actix-web = "=4.0.0-beta.6"  in Cargo.toml. Perhaps even without the = qualifier.
Setting actix-web = "=4.0.0-beta.3" makes all hell break lose, so I'm guessing it's all caused by other crates' dependencies.
I usually fix it by doing cargo clean and replacing my Cargo.lock with the one from your repository and branch for the chapter I am on. Currently root-chapter-07
However, I was hoping you would know if there's a way to fix it for good, and avoiding problems like these? Or even just point me in the right direction and I might be able to figure it out on my own.
PS: I'm only a few weeks old in the Rust world, and I am really enjoying the book. Outstanding work!

Interesting - can you share your Cargo.lock file?

I have the same issue; this is my Cargo.lock (.txt added by me because Github doesn't seem to allow .lock file uploads)
Cargo.lock.txt

I reproduced it on the main branch like this:

update tracing-actix-web to 0.4.0-beta.1
cargo check => errors.
cargo clean
undo the version change from point 1
cargo check => errors.

Cargo.lock is updated and keeps causing issues.
Cargo.lock.txt

Have you tried running cargo update after step 2? Do you get the same errors afterwards?

Tried it and it did a bunch of changes. Same errors, though.
Here's the lock file afterwards:
Cargo.lock.txt

Seems like they rushed beta.6 and broke the error types (see: https://github.com/actix/actix-web/issues/2173).
Pinning actix-http, actix-service and actix-web :
actix-http = "=3.0.0-beta.5"
actix-service = "=2.0.0-beta.5"
actix-web = "=4.0.0-beta.5"

As suggested in (https://github.com/actix/actix-web/issues/2185)
And running cargo clean && cargo update && cargo check fixed it for me :)

Woops. 😬
Great detective work. Worked very well, thank you.

Thank you for reporting :+1:. This was a really strange error message, glad I found help here. Spent an hour on this one before I found this issue.

Had the same issue and fixed it in the following way:
pub async fn subscriptions(form: web::Form<FormData>, db_pool: web::Data<PgPool>) -> HttpResponse {
    let query = sqlx::query!(...)

    match query {
        Ok(_) => HttpResponse::Ok().finish(),
        Err(e) => {
            eprintln!("Faield to execute query: {}", e);
            HttpResponse::InternalServerError().finish()
        }
    }
}

For me it makes a little bit more sense than the way described in the book since HttpResponse type seems already to be sort of Result (it can contain successes and failures). Wrapping it one more time feels weird. Hope this feedback helps :)

Solved in the next release, going out tomorrow 😁
Required a significant rework of many chapters 😅


Feature: add ability to filter by both date & time in one filter

Now only filter by date is possible. I would like to filter by time too.

Me too. But a whole new js picker would be needed. Maybe in future.


The result varies largely when changing random seeds

Hi,
Thank you for your code! My confusion is when I try to use different seeds to run the code, I found the result for MSVD (MSRVTT is just okay), especially the cider, varies largely (+-5%), which I think is not ignorable. Have you ever experienced that? In my view, it is because MSVD samples 17 captions out of nearly 40 captions, which causes big randomness using different seeds, but when I use the fixed 17 captions for each video, things are nearly the same (7% in Cider). What are the possible reasons for that?
Thank you!

I think maybe the dataset is too small. I didn't try different seeds.


Failed to construct URL : invalid URL

Your description here
Expected outcome
What should happen?
Actual outcome
What happened?
Versions
App: 10.0.8
Platform: 5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
Steps to reproduce

new request

update chrome    please  close


zookeepercollector: remove obsolete fragment of memcached

Just removing an unnecessary fragment left from the memcached copy. Acceptable?

This repo has moved to https://github.com/python-diamond/Diamond
Please open a new pull request there if this issue is not resolved with the current code there.
Thanks!


IA-3484: Eslint

We have now more than 2500 error on eslint
Related JIRA tickets : IA-3484
Self proofreading checklist

[x] Did I use eslint and black formatters
[ ] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[ ] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes

change rules
fix small errors

How to test
Everything should work like before

Cypress ✅  => https://github.com/BLSQ/iaso/actions/runs/11163723233


white lines through image when cropping images on mobile

Phone: Motorola Nexus 6 (6 inch screen), Android (latest build)
Browser: Chrome (latest build)
Issue: when cropping an image the result will more often than not have white lines across it. Sometimes they are vertical sometimes horizontal, sometimes both. This occurs on my own application but also when i upload something to your test page.
Thank you very much for your help in fixing this.

Thanks for taking the time to submit this.  We'll try to get to it, but it seems like a tough one to track down if it only happens sometimes..  Does this happen with every sized image?  Large ones?  Small ones?  I'm guessing you're getting the canvas result, and not the html one?
Would you expect the part of the image outside of the line to be part of the result or not part of the result, i.e. is the part that's underneath that line inside your viewport when cropping?

Thanks to you. yes using canvas.
i tested with a lot of images and it seems to happen with photos taken from my camera (13mega pixels).
the part outside the lines are also part of the result. its exactly how i selected it.
it seems now it created a portal to another dimension:

tested with large pictures of the internet. doesnt happen.
tested with small pictures of the internet. doesnt happen.
seems to only happen with pictures taken with my phone camera.

I observed this issue also, the lines can be horizontal and/or vertical.
I believe it has something to do with decimals in pixels.
This only happens on Chrome for me and I've tested it on IE11, Edge, Firefox, Chrome, Safari.
I fixed it by changing the fix function to parse float to value without decimals (an integer).
This function is used throughout the project but by changing the transform values on img css (when cropping produces lines in image) by removing decimal places had an immediate effect on the cropped image (no lines).
The only place the fix function is used and needs decimals places is on zoom values.
function getCanvasImage(img, data) {
    ...

    left = fix(left);
    top = fix(top);
    width = fix(width);
    height = fix(height);
    outWidth = fix(outWidth);
    outHeight = fix(outHeight);

    ctx.drawImage(img, left, top, width, height, 0, 0, outWidth, outHeight);

    return canvas.toDataURL();
}

function fix(v, fractionalDigits) {
    return parseFloat(v).toFixed(fractionalDigits|| 0);
}

@Ulkuurz Thank you for your post. after some testing I think it solved the issue.

edited the fix() function according to your post.
edited the function calls where it is used to get a zoomer value (in 3 places) from fix(v) to fix(v, 2) .

@thedustinsmith what's your take on this? will it be included in the official version?

Looks good to me - I'll try to get a few changes in and release 1.0.4 today.

Thanks for the help.  This is in 1.0.5  - the extra version just has the minified script.


Master to become slave when recovering from outage?

Hello,
Hoped to find some IRC channel to ask few questions but did not find any, too  bad :-)
When master election occurs because current one goes down, is the previous master supposed to become slave when coming back alive? Otherwise how will it catch-up with modifications?
Setup:
srvmysql1.domain.com:3306   [0s,ok,5.7.18-log,rw,ROW,>>]
+ srvmysql2.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]
+ srvmysql3.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]
+ srvmysql4.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]

This with GTID, as mentioned and log_slave_updates.
I shut down mysql service on srvmysql1 and then I trigger a manual (cli) election of a new master:
srvmysql1.domain.com:3306     [unknown,invalid,5.7.18-log,rw,ROW,>>,downtimed]
- srvmysql2.domain.com:3306   [null,nonreplicating,5.7.18-log,ro,ROW,>>,GTID]
  + srvmysql3.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]
  + srvmysql4.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]

srvmysql2 takes the role of "master" for 3 and 4.
1. Why don't srvmysql2 become a master (instead of a mix of master and slave)?
Now let me turn on srvmysql1:
srvmysql1.domain.com:3306     [0s,ok,5.7.18-log,rw,ROW,>>]
- srvmysql2.domain.com:3306   [null,nonreplicating,5.7.18-log,ro,ROW,>>,GTID]
  + srvmysql3.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]
  + srvmysql4.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]

2. Why don't srvmysql1 become a slave of srvmysql2 when it's coming back alive?
Otherwise, how do I transfer delta from srvmysql2 to srvmysql1?
Thank you

Hoped to find some IRC channel to ask few questions but did not find any, too bad :-)

There's this desolate group: https://groups.google.com/forum/#!forum/orchestrator-mysql
Pro tip:
use three backticks for multiline snippets, such as:
srvmysql1.domain.com:3306   [0s,ok,5.7.18-log,rw,ROW,>>]
+ srvmysql2.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]
+ srvmysql3.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]
+ srvmysql4.domain.com:3306 [0s,ok,5.7.18-log,ro,ROW,>>,GTID]

See how I edited your original comment.

When master election occurs because current one goes down, is the previous master supposed to become slave when coming back alive? Otherwise how will it catch-up with modifications?

You can't expect it to be come a replica because it potentially (likely, in many environments) have applied more transactions that its replicas. That is, it is more up to date than the promoted replica. As such, it will likely break on replication.

Why don't srvmysql2 become a master (instead of a mix of master and slave)?

Please set:
"ApplyMySQLPromotionAfterMasterFailover": true,

in your config. This will issue a RESET SLAVE ALL; set read_only=0; on the promoted server.
This is an endless debate: should orchestrator do that by default or not? Reason for not doing that is that RESET SLAVE ALL loses data if relay logs are not all applied. And otherwise some environments like to have this operation done from external scripts.

Why don't srvmysql1 become a slave of srvmysql2 when it's coming back alive?

Because it will have conflicting data (See above)

Otherwise, how do I transfer delta from srvmysql2 to srvmysql1?

backup + restore would be the safest, especially with GTID.

Hello,
Sorry for coming back to you so late on the question. Thanks for the pro tip. I'm not very familiar with (Github) markup but this one I knew :-) I just thought it looked OK as copy/pasted.
All of what you say obviously makes sense and I was able to get the behavior I was expecting from ApplyMySQLPromotionAfterMasterFailover - thanks for that!
Now how would I go about having the previous master join the dance again? Backup + restore and modify its configuration on disk to become a slave instead of a master, right?
Thank you!

I'm not very familiar with (Github) markup

It's called markdown 😛  https://guides.github.com/features/mastering-markdown/

Now how would I go about having the previous master join the dance again? Backup + restore and modify its configuration on disk to become a slave instead of a master, right?

Yes indeed.

Ah ah ! Early in the morning :-)
Thank you for your time and answers.

Hey Ristreto and Arpeggio are my favorites!

I prefer Dharkan et Kazaar :-)


Rework Central DB helm

Description
Lots of different changes at play here:

Make the configuration of Postgres a part of a config map that gets mounted in the Central DB container
Move Central DB configuration out from underneath the Central section and into it's own section
Add support for preexisting databases to be used by allowing the specification of a connection string (db password will still be required)

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Will test with an external database, but CI should test with Postgres and without Postgres

/retest

/retest

@misberner @SimonBaeumer This should be ready for review again. Thanks in advance!

/retest


Any plans for a GUI?

When chaining Cilium as netpol engine on top of the AWS VPC CNI plugin, the Hubble UI is invaluable. Does AWS plan to implement any sort of GUI to accompany this project?

@yurrriq - there is no plans right now for adding a UI but please open a request here - https://github.com/aws/containers-roadmap and we will provide updates.

Closing in favor of https://github.com/aws/containers-roadmap/issues/2144


Implement graph-based compilation

Currently, function compilation takes a list of functions. It is hence assumed that the user provides said functions such that inputs and outputs which are to be combined have been renamed appropriately.
While this succeeded at keeping the implementation of function compilation simple, it meant that this input-output association was forced onto the supplied functions themselves. This means that after compilation, such manipulation must be undone (which has been a previous source of bugs).
This issue would be resolved if we moved to a graph-based compilation engine, whereby the function graph is built and then passed to the compiler, which can handle the input-output association using the edge connection data explicitly.
CC: @sammorley-short @dexter2206

Closing as instead of graph-based compilation we have refactored compilation engine in a different way.


[Fallout 76] Strange Colors

Colors in Fallout 76 seem to render very strangely.
Software information

Fallout 76.exe launched standalone
It was downloaded from the Bethesda Launcher on a Windows installation.

Screenshots

System information

GPU: GTX 1080
Driver: Nvidia 396.54.09
Wine version: 3.20
DXVK version: 0.92

Apitrace file(s)

https://drive.google.com/open?id=1bbXqQBrWNJ6nDBsW0ni6l_plIAPmnWgq

Log files

d3d11.log: https://pastebin.com/hN20d7Bj
dxgi.log: https://pastebin.com/9gnQuq7J

I have not noticed this on an AMD RX480 using Mesa. If it helps narrow down the issue, I could make an API trace too.
The only issue I see is that some grass appears to have a "film-grain" effect over it - but I am not sure it's DXVK related at all as some Windows friends also report weirdness with grass.
btw @atm0915 Bethesda Launcher works in Wine (I only tried -staging), just needs corefonts to boot, and every time you want to download/update a game you have to rename a file manually (see WineHQ's entry for the launcher, it's explained there).

Thanks for providing the apitrace. Same thing happens when replaying the trace on my RX 480 - I hope it's not baked into the trace, because that would be insanely hard to debug. Will investigate next week.

I am open to do anything to help you debug if you need me to.

https://i.imgur.com/h5R38S2.jpg
Can reproduce with D3D11 :(

/u/Nugaryal reported the same issue in this reddit post, he gave me his specs to add here if they are useful.
RTX 2080 TI
Nvidia driver: 415.18
Wine: 3.20
DXVK: 0.92

Same issue. Using the same wine / Nvidia driver as atm. My card is NVIDIA 1060. The game works fine but everything is very red.

Thanks for providing the apitrace. Same thing happens when replaying the trace on my RX 480 - I hope it's not baked into the trace, because that would be next to impossible to debug. Will investigate next week.

Any luck? I know it's probably too soon but let me know if you need someone to test / debug anything and I can help.

Hi there, I like to help too but I dont get past the login screen. There is no sound and I can log in but it says: servers are down for maintenance; what was not true and I double checked in Windows. I have the same setup like you, except for the graphics card:
GPU: GTX 1060
Driver: Nvidia 396.54.09
Wine version: 3.20
DXVK version: 0.92

I have a clean wine-staging install, what else did you add? Corefonts and xact maybe?
Any tipps appreciated, thank you in advance :)

Alright I got 2 apitraces from Fallout 76 on windows here is the first one, because the 2nd stopped uploading and I am still reuploading. The game crashed while recording this one, but the trace replayed fine on the windows machine. The trace only crashed apitrace at the same point the game crashed. I will post the 2nd trace when its done uploading in approximately 1h.
Windows trace:
https://drive.google.com/open?id=12152NFduUTqVmBajBPi1KNbP6yU1AU0T

Here is the 2nd trace:
https://drive.google.com/open?id=1szYvyJc7GrZrHgdXtvdCeps_MDWtTnyW

I have solved my issue, I always got the error 'NoRegionPing' upon connecting in Fallout. I installed Visual C++ Redistributable for Visual Studio 2015 as an exe in the wineprefix and then it worked.
So now I have the same color glitches, I tried to make apitraces dont know if it worked tho.

dxgi.log - https://pastebin.com/VTirFTcs
Traces:
https://drive.google.com/file/d/1szYvyJc7GrZrHgdXtvdCeps_MDWtTnyW/view?usp=sharing

So, two things I discovered:

The apitraces that @Riesi posted render correctly
The apitraces recorded with DXVK don't, but apitrace actually doesn't update some constant buffers correctly. Not sure if that is in any way related to the rendering issues we're seeing.

@enthalpie @atm0915 can you test<PHONE_NUMBER>c2ee07ee112d8fe75a817c0f82b85c please? Here's a build in case you need it:
dxvk-master.tar.gz

Thanks for your effort, I have tried your prebuilt fix but it is still all very red. The GPU tho gets taxed lesser, before the game maxed out my VRAM of 6 GB, now it stays within reasonable ranges.

I may be on to something: in the wineprefix under /users/Username/My Documents/My Games/Fallout76 I deleted both ini files and the saves flder. Then started he game and now the raphics ar perfect. I changed the Fallout.ini as well, but I think deleting those files already does the trick. The graphics are set to ultra and run like in Windows and with 60 fps, just perfect. :)
Only downside is, the game and music hangs every minute or so for 5 seconds and then goes on. That stuttering is really hard. Will try a few things like switching of esync

I may be on to something: in the wineprefix under /users/Username/My Documents/My Games/Fallout76 I deleted both ini files and the saves flder. Then started he game and now the raphics ar perfect. I changed the Fallout.ini as well, but I think deleting those files already does the trick. The graphics are set to ultra and run like in Windows and with 60 fps, just perfect. :)
Only downside is, the game and music hangs every minute or so for 5 seconds and then goes on. That stuttering is really hard. Will try a few things like switching of esync.
Edit: that's it, no esync did the trick and it runs perfect now on ultra settings with 60 fps. Thank you very much doitsujin, great work the Dxvk layer :). Danke Alter!
My setup now:
Lutris
Wine: tkg-protonified-3.21-x86_64
DXVK: 0.93
Esync disabled
Driver Nvidia 396.54. 09

Interesting. Tried deleting those files but no luck. Same issue still. I wonder what's different?
I'm using the same wine and dxvk version.

I may be on to something: in the wineprefix under /users/Username/My Documents/My Games/Fallout76 I deleted both ini files and the saves flder. Then started he game and now the raphics ar perfect. I changed the Fallout.ini as well, but I think deleting those files already does the trick. The graphics are set to ultra and run like in Windows and with 60 fps, just perfect. :)
Only downside is, the game and music hangs every minute or so for 5 seconds and then goes on. That stuttering is really hard. Will try a few things like switching of esync.
Edit: that's it, no esync did the trick and it runs perfect now on ultra settings with 60 fps. Thank you very much doitsujin, great work the Dxvk layer :). Danke Alter!
My setup now:
Lutris
Wine: tkg-protonified-3.21-x86_64
DXVK: 0.93
Esync disabled
Driver Nvidia 396.54. 09

Enthal, I'm pretty sure this has to do with Fallout76Prefs.ini
I've been messing with it and definitely getting changes. A few edits and everything was green instead of red, for me. Can you post your prefs file here if it's working well for you?

Sorry for another post, but I do believe I got it working on my end!
First create a file in your My Games/Fallout76 directory called Fallout76Custom.ini
Then put this in it:
[ScreenSplatter]
bBloodSplatterEnabled = 0
[Grass]
iMinGrassSize = 80
bAllowCreateGrass = 0
[ImageSpace]
bDoRadialBlur = 0
[Weather]
bPrecipitation = 0
bFogEnabled = 0
bRainOcclusion = 0
bWetnessOcclusion = 0
[Enlighten]
bEnableEnlighten = 0
Graphics are perfect after that, and works with Esync (for me).
Found these tips on another site for someone who was having graphic issues on windows..

I have changed 3 or 4 values myself in the ini's that could be it. If I compare mine to your values, I have FogDisabled and enableEnlighten set to zero, the rest I have set to one. So maybe it is one of those two causing the problem.
After deleting the Fallout76prefs.ini I figured, the one newly created was much shorter. Here are my ini's. The Fallout76.ini script is created from the main game folder, so it should be changed there and after the changes be deleted in the users/username/My Documents/My Games/Fallout76 folder
Fallout76.zip

The solution is:
bFogEnabled=0
bEnableEnlighten=0
In Fallout76.ini in the main game folder. One of the two or both.
Problem solved :), just the framedrops still make it unplayable for me

Have the same issue here with a GTX 1060 on 396.54.09, here's my logs:
https://gist.githubusercontent.com/Makaronelle/ea783c4e08d4cc7369ad08ee124ff84f/raw/b9b9077437f9c0bf2ace7af78689241a75e86da2/terminal.log
https://gist.githubusercontent.com/Makaronelle/0828834ad0e9b0f9eb08b1fd0cd0d889/raw/a75943a09cafd28525652de504181d6a2b458796/Fallout76_d3d11.log
Hope it may help !

Have the same issue here with a GTX 1060 on 396.54.09, here's my logs:
https://gist.githubusercontent.com/Makaronelle/ea783c4e08d4cc7369ad08ee124ff84f/raw/b9b9077437f9c0bf2ace7af78689241a75e86da2/terminal.log
https://gist.githubusercontent.com/Makaronelle/0828834ad0e9b0f9eb08b1fd0cd0d889/raw/a75943a09cafd28525652de504181d6a2b458796/Fallout76_d3d11.log
Hope it may help !

Navigate to the directory, where your Fallout76.exe is located and log for the Fallout76.ini. Open it with a Texteditor and look for " bEnableEnlighten = 1". change the 1 to a zero and save the file. After a Fallout Update, you may have to do it again. That should fix the red tint for the time being.
I have an error now that is really bugging me, but it seems to be windows-related. DXVK is working so good that I can already suffer Fallout errors, normally only Windows users have. :D Every now and then, I get framedrops to zero and the game hangs for five seconds. That is pretty bad in fights and almost always results in death.
The windows people didnt seem to have fixed it so far from what I have read and its persisting since Fallout 4. Disabling VSync which locks the framerate in Fallout76 is an idea and another one is a memory leak regarding a two small pagefile. I dont know tho if thats with me and 16 GB RAM a real issue. I have reverted the NvAPI workaround and disabled napi manually but that only had an effect on micro freezes within Battlefield 5 (that runs Platinum now). In Fallout the error persits.
I will play a bit with settings on the weekend.

Have the same issue here with a GTX 1060 on 396.54.09, here's my logs:
https://gist.githubusercontent.com/Makaronelle/ea783c4e08d4cc7369ad08ee124ff84f/raw/b9b9077437f9c0bf2ace7af78689241a75e86da2/terminal.log
https://gist.githubusercontent.com/Makaronelle/0828834ad0e9b0f9eb08b1fd0cd0d889/raw/a75943a09cafd28525652de504181d6a2b458796/Fallout76_d3d11.log
Hope it may help !

Navigate to the directory, where your Fallout76.exe is located and look for the Fallout76.ini. Open it with a Texteditor and look for " bEnableEnlighten = 1". change the 1 to a zero and save the file. After a Fallout Update, you may have to do it again. That should fix the red tint for the time being.
I have an error now that is really bugging me, but it seems to be windows-related. DXVK is working so good that I can already suffer Fallout errors, normally only Windows users have. :D Every now and then, I get framedrops to zero and the game hangs for five seconds. That is pretty bad in fights and almost always results in death.
The windows people didnt seem to have fixed it so far from what I have read and its persisting since Fallout 4. Disabling VSync which locks the framerate in Fallout76 is an idea and another one is a memory leak regarding a two small pagefile. I dont know tho if thats with me and 16 GB RAM a real issue. I have reverted the NvAPI workaround and disabled nvapi manually but that only had an effect on micro freezes within Battlefield 5 (that runs Platinum now). In Fallout the error persits.
I will play a bit with settings on the weekend.

Oh, don't worry, I already made my little investigation on that issue a couple of days ago so I could make a workable Lutris script for both AMD and Nvidia. Just posting logs to help solving this.
It may be easier if you simply put your custom settings in a Fallout76Custom.ini in your game "save" folder to prevent it from behind reseted every now and then with an update, directly editing the root folder's inis may give mixed result, plus it's cleaner that way !

I was able to get rid of the frame drops or better micro freezes. The value "iPresentInterval" in users/username/my Documents/My Games/Fallout76Prefs.ini needs to be set to zero so VSync is disabled. The game runs perfect now for me at 80 fps, 1080p with maximum settings.

Is the red tinting still a thing?
Just bought the game yesterday, installed it in Windows, and started it with a fresh prefix (corefonts, xact, vcrun2015). Didn't change the .INI files, but the game runs nevertheless without red tinting.
Maybe someone who previously had red tinting with an older game version could test this, with bEnableEnlighten = 1 ?

@Taraluktus What GPU do you have? For me, on AMD the red tinting also doesn't happen.

LLVM 8, Mesa 19-dev, with RADV (RX 480)
Ah, I've misread your comment from Nov 23. Really seems to be NVIDIA only.

Perhaps in a dxvk conf for the game, spoof an amd card and see about it. Just out of curiosity.

AMD is spoofed by default since commit 5d49644cdc071866c5556997a35bd946d7724457

Oof. There goes that idea then.

Ran faster using proton beta with esync, however it stalled just at the point of rendering the world, and some pixels appear in the black darkness but CPU tanks to 0%, so I must be missing something critical, shrug. Maybe having no xact or faudio is causing this,

@jarrard Have a look at https://appdb.winehq.org/objectManager.php?sClass=version&iId=37459
Issues concerning WINE should probably go there, since game (not launcher!) runs pretty well&stable with DXVK.

SIGH,
I had a custom dxgi.dll file in my fo76 folder this whole time, facepalm......
Still yet to get sound working but its a start.

Water does show as white for me so far. Seems odd.

Just thought I mention this here and see if anyone else has this issue.
There is instances where light sources flicker in this game, I don't remember those happening under windows, basically cabin lights etc will flicker depending on angle you look at them. Might be a issue?

Just thought I mention this here and see if anyone else has this issue.
There is instances where light sources flicker in this game, I don't remember those happening under windows, basically cabin lights etc will flicker depending on angle you look at them. Might be a issue?

Nah, that actually happens outside of dxvk using the native renderer even on windows


[BUG] RPM commands missing in documentation

Describe the bug
Missing documentation around RPM build.
To Reproduce
Steps to reproduce the behavior:

run command" yarn build --rpm
Failed to build the RPM.

Expected behavior
The RPM should be built and can be found in the target folder.
OpenSearch Version
1.0.0
Dashboards Version
Please list the version of OpenSearch Dashboards being used.
1.0.0
Plugins
N/A
Please list all plugins currently enabled.
None
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Transfer to documentation repo per request of @ahopp

thanks @peterzhuamazon, basically if we some docs to reference this section: https://github.com/opensearch-project/documentation-website/issues/168#issuecomment-878575092 then it should solve this bug.

Hey all, the build commands for a particular project are usually best-left in the repository README or developer guide. I'd expect these commands to go in either the Dashboards repo or the build repo. Our general division of content at this time:
Repos:

What is this thing?
How do get started with development and build it from source?
How do I contribute changes or bug fixes?

Documentation:

What is this thing?
How do I install it?
How do I get started with it?
Reference stuff: supported operations, configuration, tuning, best practices, REST API, etc.

We are still working on deb/rpm related builds and they are not going to available for 1.1.0.
Will contact the doc team once we have everything ready.
Thanks.

Going to close this since the RPM installation instructions were added in 1.3.
https://opensearch.org/docs/latest/opensearch/install/rpm/


Setting up the main scene

Add game_state.gd to main scene

https://github.com/user-attachments/assets/8ac1357f-4365-4a0f-b091-c856c7bbcf75


Fix flp config backport

Backport of https://github.com/netobserv/network-observability-cli/pull/97

/lgtm

/ok-to-test

/label qe-approved

/approve


implement options --country and --language for export (must be used together)

export.options.country=If not using user''s default locale, the country abbreviation for locale (find in IANA Language Subtag Registry). Must use with --language
export.options.language=If not using user''s default locale, the language abbreviation for locale (find in IANA Language Subtag Registry). Must use with --country

If there is text in an export, the default language presented should be the default language of the user logged into Server.  Sending language parameters in the HTTP request overrides the Server user default language, which we do not not want, so do not include any language parameters in the language parameter unless explicitly set with these options.

in progress in #106


chore: add leaderboard api doc example snippets and remove duplicate integration test target

Addresses #468.
Added example leaderboard API snippets (including one showing pagination using FetchByRank) to add to the docs.
Also removed the separate integration test target for leaderboard tests because #963 added leaderboard tests to the main integration-test target.

My understanding was that this part specifies what integration test paths to remove,
--testPathIgnorePatterns \"auth-client.test.ts|vector-control-plane.test.ts|vector-data-plane.test.ts\"

hence why the auth and vector clients have separate test commands
"integration-test-auth": "jest auth-client.test.ts --reporters=jest-silent-reporter",
"integration-test-vector": "jest vector-control-plane.test.ts vector-data-plane.test.ts --reporters=jest-silent-reporter",

Is that correct? Isn't that how the other cache and topics integration tests run?

My understanding was that this part specifies what integration test paths to ignore,

🤦 I knew I was missing something. If its already merged as is then I think we are good on the 2 bullet points I made


feat(aws): document customizing the web app

See NordicSemiconductor/asset-tracker-cloud-docs#65

[x] Incorporate video

@umapraseeda I've added the Customizing video


Add set for is_keyframe and is_corrupt

Fixes #1179

Moved to maintained fork:
https://github.com/WyattBlue/pyav/pull/10


When using JerseyClient dropwizard metric is not reflecting connection pool details

When using JerseyClient, apart from max-connections, all the other metric remains 0, like available-connections, leased-connections etc.
Is there an example of how to initiate the client? As of now, it's done in a standard manner -
final Client client = new JerseyClientBuilder(environment).using(config.getJerseyClientConfiguration())
.build(getName());
This may be similar to the issue(https://github.com/dropwizard/dropwizard/issues/789) but was not finding a concrete example with the metric publishing working fine. If the functionality is working, please provide some detail/example of how to achieve the same.

For facilitation, what version of dropwizard are you using?

As of now, dropwizard version 1.1.0

Sorry for such the delay, but I can confirm your findings: it appears that since Dropwizard 1.1.0 (I have Dropwizard 1.0.x app that reports it fine) those metrics are zero. It may be the difference between sync and async http clients, as I haven't controlled for that yet.

I just recently checked again and I must have been mistaken the first time (as I can see metrics dating back several years) where I can see non-zero metrics for both async and sync clients. So there is no bug here. Oftentimes the metric may report zero for short and fast requests.


Context menus do not overflow

Custom context menus will clip at window edges instead of overflowing.

VS Code version: Code - Insiders 1.25.0-insider (e585e4bf008a50e5b1f4fde71cf6d255e25381bf, 2018-06-20T08:08:46.972Z)
OS version: Windows_NT x64 10.0.16299

Every update comes with a problem, But that's a good thing！That means VSCode is making progress！

@SunOfHomeBoy that seems like a different issue. This is related to the "custom" title bar option introduced in recent Insider's versions. You don't seem to have that enabled.

@JacksonKearl Excuse me! How to activate?

a temporal solution can be:
https://github.com/Microsoft/vscode/issues/31278
open vscode with this flag --force-device-scale-factor=0.8
this will change the UI size and make it smaller, so menus will not be hidden at less.
I hope they will add the scroll to the menus soon , it s a basic thing.


HBASE-23981 PBType which is marked as IA.Public references protobuf M…

…essage

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 36s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 39s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
7m 50s
master passed

+1 :green_heart:
compile
1m  1s
master passed

-1 :x:
shadedjars
0m  9s
branch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 18s
hbase-common in master failed.

-0 :warning:
javadoc
0m 19s
hbase-examples in master failed.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 38s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

-1 :x:
shadedjars
0m 10s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
hbase-common in the patch failed.

-0 :warning:
javadoc
0m 22s
hbase-examples in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 39s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 45s
hbase-examples in the patch passed.

26m 23s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1323

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2d118552b7df 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / eface74407

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-examples.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-examples.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/testReport/

Max. process+thread count
2761 (vs. ulimit of 10000)

modules
C: hbase-common hbase-examples U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
6m 10s
master passed

+1 :green_heart:
compile
0m 49s
master passed

+1 :green_heart:
shadedjars
5m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 51s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
shadedjars
5m 26s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 23s
hbase-examples in the patch passed.

31m 59s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1323

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8cd24b5924e4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / eface74407

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/testReport/

Max. process+thread count
2538 (vs. ulimit of 10000)

modules
C: hbase-common hbase-examples U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 37s
master passed

+1 :green_heart:
checkstyle
0m 39s
master passed

+1 :green_heart:
spotbugs
1m 24s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
checkstyle
0m 37s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m  5s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
1m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

35m 22s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1323

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux c1bfd7153d53 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / eface74407

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-common hbase-examples U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1323/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

technically this needs a deprecation cycle. I'm okay with skipping it for this one though, since it's an unintentional part of our API, a class that (I imagine is) not heavily trafficked.
everything in hbase-examples should be IA.Public, right?
mind also update the javadoc to link off to PBKeyValue since it's now all in the same package?

Good find @Apache9 .

In general, the rule is to mark it as deprecated first, and keep it through a whole major release, and then delete it.
So by the rule we should not move this class in 3.0.0. But it is a bit different is that, this is a broken behavior, where we expose protobuf in our public API, so I prefer we just remove it 3.0.0 release, and will open a sub task to mark it as deprecated on branch-2 and branch-2.3.

everything in hbase-examples should be IA.Public, right?

In my opinion, No. For me, example means you can copy the code, but not depend on the code...

FWIW I agree with Duo about the examples. We should call this out in the javadocs of them though.

For me, example means you can copy the code, but not depend on the code

That I agree with. Maybe we should discontinue publishing the hbase-examples jar to maven...

I'm +1 with dropping this immediately from master. and Deprecating on all existing branch-2 release lines. This is not a class designed or intended for production use, only supporting the example. Let's include a release note about it.


tests: ++coverage

without any extra:

@miragrudzinska thanks, please update the figure => https://github.com/thorvg/thorvg/wiki/Unit-Tests, (+ no need to add "static=true" option)


feat(access): add access control

We need to re-introduce the original access control package but with emphasis on client as first class citizen and server as rule and access consumer for persistent storage.

[ ] Revive @valkyr/access from a previous commit.
[ ] Make any adjustments required to make it functional.

Should be client focused.
Should be able to be run on any typescript based service with persistent access rules spawned through event projections.

Not needed as we will be using https://casl.js.org/ for access control


Ensure unsupported units don't break translations

This ensures unsupported units don't break translations. If the given units are not known, we'll just omit it instead of showing something like units.tag-mo.
This also places the % character inside the parenthesis above the progress bar.
fixes https://github.com/project-koku/koku-ui/issues/909

Codecov Report

Merging #911 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   72.74%   72.76%   +0.02%
==========================================
  Files         200      200
  Lines        3746     3749       +3
  Branches      692      693       +1
==========================================
+ Hits         2725     2728       +3
  Misses        931      931
  Partials       90       90

Impacted Files
Coverage Δ

src/utils/formatValue.ts
78.12% <100%> (+2.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afab283...ba25b01. Read the comment docs.


Add aarch64-apple-darwin test to CI

Try to reproduce #2200

I think https://github.com/PyO3/pyo3/pull/1428 is broken in 0.16.

Yes, I think also hitting this on setuptools-rust - https://github.com/PyO3/setuptools-rust/pull/209
Think we should get this out as a patch release 0.16.1. Just need someone to figure out what's broken. I might be able to look at this tomorrow, not sure.


Use standard setup and teardown keywords for TCs in extended dir

Use standardized names for setup and teardown keywords in Robot modules residing in the extended directory.

Suite Setup Execution
Suite Teardown Execution
Test Setup Execution
Test Teardown Execution

https://gerrit.openbmc-project.xyz/8326


jhudsl-robot git config error message when rendering website

I've been using the OTTR template to render an online textbook for a couple of months now and it's been working great so far. Yesterday I tried updating the website and started getting this error in the Render bookdown -> Login as jhudsl-robot step:
Run git config --local user.email<EMAIL_ADDRESS>
  git config --local user.email<EMAIL_ADDRESS>  git config --local user.name "jhudsl-robot"
  shell: sh -e {0}
fatal: --local can only be used inside a git repository
Error: Process completed with exit code 1

You can view the action log here, and are welcome to try re-running the jobs if you'd like (I can upgrade jhudsl-robot's permissions if you need me to!).
I haven't gotten this error before and am not sure how to go about fixing it, since it doesn't seem to be related to the webpage content itself:

when I tried to re-render the website with an older version of the content (which worked just a few weeks ago), it failed with the same error as above
I've also made sure that jhudsl-robotis a collaborator on the repo with the correct permissions

Any advice would be appreciated! Thanks for all the work you've put into this valuable resource.

Thanks so much for your comment and using OTTR!!
This is a bug from that comes downstream from some updates we had to make due to other github actions we use under the hood that are being deprecated, we sent out an OTTR template update that addressed this problem.
Did you follow the steps to Enroll you repository for OTTR updates? As described here on Step 9? https://www.ottrproject.org/getting_started.html#9 Enroll your repository for OTTR updates
If not, no worries, I'm happy to help you with it.

I haven't but I will do that now and see if it fixes it! Thank you!

Once we get your repository enrolled in the updates, I'll need to manual set out an update to your repo. I'll do that tonight or tomorrow.
Thanks again! Let me know if you have any troubles!

I just went through the steps to enroll for updates. Some of the Github interface looks different from when the instructions were made (I couldn't figure out how to request you as a reviewer, but I might have just missed something), so hopefully I did it right!

Yup! That was it. I merged it and will send over the updates. You'll see a pull request.

This was resolved with https://github.com/mccoy-lab/hgv_modules/actions/runs/4364753281/jobs/7632468928


InsertOrIgnore, InsertOrIgnoreAll, InsertOrIgnoreAsync, InsertOrIgnoreAllAsync, GetMappingAsync methods and unit tests added

Added the following methods:
InsertOrIgnore
InsertOrIgnoreAll
InsertOrIgnoreAsync
InserOrIgnoreAllAsync
GetMappingAsync
Added Unit Tests in the SQLite.Net.Tests.Generic assembly for all the above methods. All unit tests passed.

Looks good, thanks:)


UI for Requesting PPM Payment

Description
These changes allow a service member to request payment for a PPM they have finished.
Reviewer Notes
Pretty standard in the end. I reused the actions for CREATE_OR_UPDATE_PPM because I could, but had an additional action type to cover it's specific status.
Code Review Verification Steps

[ ] End to end tests pass (make e2e_test).
[ ] There are no aXe warnings for UI.
[ ] This works in IE.
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change
Pivotal story for this change

Screenshots

Can you see if you can get the alert to have left/right margins like this:


onlykey: fix missing wrapGAppsHook causing GLib-GIO-ERROR #181500

Description of changes

Fixes issue #181500 with OnlyKey crashing when no GSettings Schemas are installed by using stdenv.mkDerivation instead of runCommand and adding wrapGAppsHook as a build input.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Rebased, I did something 7 months ago too, but I waited for the CI to run before merging and forgot

Thanks, I recommend @'ing people or requesting reviews when your PR goes unmerged for a ~two weeks.


Add custom view into toolbar options

I created a custom view but currently having trouble adding the view to the toolbar.
I also created a custom toolbar since I need it in english.
changeView(changeViewType: string) {     switch (changeViewType){         case 'month':             this.selectedViewType = GanttViewType.month;             break;         case 'year':             this.selectedViewType = GanttViewType.year;             break;     }   }
How do I add an option in the toolbar that allows me to switch to custom view?

you can set custom toolbar template
<ng-template #toolbar>
    <button>CustomView</button>
</ng-template>


Investigate a restructuring of this extension that changes the code from stream-based to effect-based

As of 0.1.0, this extension relies on replacing user-provided audio streams with SteamAudioStreams that hijack the raw audio as it is is being mixed and apply SteamAudio effects over it. This works well for basic use cases, but it can cause jank and issues (#39, #29, #25, #24).
I'm opening this ticket as a reminder to investigate the possiblity of using audio effects to replace SteamAudioStream. If I can access raw audio as it's being mixed this way, I might be able to heavily reduce bugs (I might be trading advanced stream use-case bugs for advanced audio effect bugs, but I think I prefer it that way). This may also fix #18 (that would honestly be the best part).

Is there any progress? Maybe, some help is needed?

I'm not sure how feasible this way of doing things is. From what I've seen in the Godot source code, it would be a lot more complicated to extend audio effects than the current way this extension works.


Notification item styles

Text styles are not aligned with design

How it should look

Originally posted by @herrhaase in https://github.com/WalletConnect/web3inbox-widget/issues/9#issuecomment-1679329783

Notification card should

be a row element like displayed in design https://www.figma.com/file/P70QpTDpsgwdPJ2jJmVXxg/Web3Inbox?type=design&node-id=2042%3A87736&mode=design&t=qKbllZIOgujBOQnG-1
should not move on hover

Originally posted by @herrhaase in https://github.com/WalletConnect/web3inbox-widget/issues/9#issuecomment-1679332637

We no longer ship components with the SDK.


Target NLog 4.5

NLog 5 has been discontinued, we need to target NLog 4.5
https://twitter.com/NLogOfficial

Since this change, I can no longer find the  Nlog.RabbitMQ.Target.RabbitMQTarget. I could however find the class when using 2.4.0 (With NLog 5)


Allocators owns should take const void[]

owns should take a const void[] argument as it should also work with const and immutable memory chunks.
Added more unittests in order to ensure that allocators inherit from their parents.
This can now be safely merged as the vibe-d patch was merged. For more references see #5837 .

FYI: you don't need to create a new pull request to change the branch ...
Just click on "edit" :

@edi33416 anyhow it seems we now are safe to return to the master branch...