Memory error (leak?) at i2c_master.h (IDFGH-11783)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[x] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2-beta1-263-ge49823f10c
Espressif SoC revision.
ESP32-D0WD-V3 (revision v3.0)
Operating System used.
Windows
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
Development Kit.
DOIT ESP32 - ESP32-WROOM-32D
Power Supply used.
USB
What is the expected behavior?
Work whitout memory errors
What is the actual behavior?
After about 18174 i2c transactions got: Guru Meditation Error: Core 0 panic'ed (StoreProhibited). Exception was unhandled. i2c_master_transmit_receive
Steps to reproduce.

Setup a project and configure i2c master bus with callback and also nonzero trans_queue.
Configure i2c callback to increment a counter after each new transaction is completed.
Issue new i2c transactions periodically. I using a AS5600 magnetic sensor and calling i2c_master_transmit_receive(as5600_dev_handle, write_buf, 1, read_buf, 2, -1); write_buf and read_buf are alocated only once and remain the same the entire program life.
Log transaction counter and read_buf, everything works until about 18174 i2c transactions.

Debug Logs.
Timed = 532210 microsseconds :: i2c_transactions = 18015 ===> as5600 read = 61.699219
... i2c_dev->master_bus->anyc_write_buffer[i2c_dev->master_bus->index] = 3fffffcc
Timed = 532242 microsseconds :: i2c_transactions = 18016 ===> as5600 read = 61.699219
... i2c_dev->master_bus->anyc_write_buffer[i2c_dev->master_bus->index] = 3fffffdc
Timed = 532269 microsseconds :: i2c_transactions = 18017 ===> as5600 read = 61.699219
... i2c_dev->master_bus->anyc_write_buffer[i2c_dev->master_bus->index] = 3fffffec
Timed = 532302 microsseconds :: i2c_transactions = 18018 ===> as5600 read = 61.699219
... i2c_dev->master_bus->anyc_write_buffer[i2c_dev->master_bus->index] = 0
Guru Meditation Error: Core  0 panic'ed (StoreProhibited). Exception was unhandled.

Core  0 register dump:
PC      : 0x4000c333  PS      : 0x00060330  A0      : 0x800d9659  A1      : 0x3ffb4dc0
0x4000c333: memcpy in ROM

A2      : 0x00000000  A3      : 0x3ffb0274  A4      : 0x00000001  A5      : 0x00000000
A6      : 0x0000000c  A7      : 0x00000000  A8      : 0x00000000  A9      : 0x3ffb4a60
A10     : 0x0000004b  A11     : 0x00000000  A12     : 0x00000000  A13     : 0x3f4050f8
A14     : 0x00000001  A15     : 0x00000001  SAR     : 0x00000004  EXCCAUSE: 0x0000001d
EXCVADDR: 0x00000000  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0xffffffff
0x4000c2e0: memcpy in ROM

0x4000c2f6: memcpy in ROM

Backtrace: 0x4000c330:0x3ffb4dc0 0x400d9656:0x3ffb4dd0 0x400d64fc:0x3ffb4e70 0x400eaf38:0x3ffb4ed0 0x400866fd:0x3ffb4f00
0x4000c330: memcpy in ROM

0x400d9656: i2c_master_transmit_receive at C:/Users/carlo/esp/esp-idf/components/driver/i2c/i2c_master.c:990

0x400d64fc: app_main at D:/Documents/Projetos/PCB_CNC/StepperFOC/main/main.cxx:144

0x400eaf38: main_task at C:/Users/carlo/esp/esp-idf/components/freertos/app_startup.c:208

0x400866fd: vPortTaskWrapper at C:/Users/carlo/esp/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:134

ELF file SHA256: 69d430d0a

Rebooting...
ets Jul 29 2019 12:21:46

rst:0xc (SW_CPU_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:7172
load:0x40078000,len:15532
load:0x40080400,len:4
0x40080400: _init at ??:?

load:0x40080404,len:3904
entry 0x40080640

More Information.
I did some research on the error and found out that "i2c_dev->master_bus->anyc_write_buffer[i2c_dev->master_bus->index]" points to a new memory position each time, even after previous transaction was completed. So I suspected that the memory allocated was not being released after sucessfully queueing the i2c transaction. In fact, when the error happens it points to nullptr.
I was not able to track down any futher for when the memory block was suposed to be released, so in a desperated attempt I inserted a line "heap_caps_free(i2c_dev->master_bus->anyc_write_buffer[i2c_dev->master_bus->index]); // <<< free memory BUG?" just after "ESP_RETURN_ON_ERROR(s_i2c_asynchronous_transaction(i2c_dev, i2c_ops, DIM(i2c_ops), xfer_timeout_ms), TAG, "I2C transaction failed");". It seens to solve the problem, but maybe is the wrong solution.

It's worth noting that I am not issuing an I2C transaction every 20 us. The timer is inaccurately reporting time in microseconds, with a substantial discrepancy (roughly 500 times larger). This results in an approximately 10 ms delay for each I2C reading.

Hi, @CarlosEduardoNovaes Is it possible not to use callback currently? I've already noticed the issue and fixing it.

@mythbuster5 Can you post the fix here for verifying?

@AxelLin It's still in progress now.

Hi, @CarlosEduardoNovaes Is it possible not to use callback currently? I think in blocking method it should work well. I've already noticed the issue and fixing it. But it still need some time,

Hi, @mythbuster5, thanks for your response. It works with the blocking API. I made the switch to a newer esp-idf version to take advantage of the non-blocking API, aiming for readings every millisecond or even faster. However, I understand that this isn't a stable release.
So far, it has been operational for about 20 hours without any issues, thanks to the workaround mentioned in the opening post. This should serve me well for testing and proving the concept in my application. I'm considering switching to an AS5048 with an SPI interface in the next prototype level.

Loosing 300bytes of stack everytime the i2c handler fails to contact the i2c slave.
I did this on purpose by removing the i2c slave and monitoring the Free Stack. it gets degreased by 300 bytes for every call below;
    log_i("RTC_DS3231::begin");
    Wire.begin(sdaPin, sclPin, frequency);

    log_i("RTC_DS3231::begin beginTransmission");
    Wire.beginTransmission(DS3231_ADDRESS);

    log_i("RTC_DS3231::begin endTransmission");
    if (Wire.endTransmission() == 0)
    {
        log_i("RTC_DS3231::begin return true");
        return true;
    }

    log_i("RTC_DS3231::begin return false: Warning MemoryLeak!");

    return false;

esp32-gateway (platform<EMAIL_ADDRESS>board: esp32-gateway; framework: arduino)


Want to add some hover effect on header navbar and footer navbar

Is your feature request related to a problem? Please describe.
There is no hover effect on the navigation links which does not look good and little confusing if they are clickable or not.
Describe the solution you'd like
I would like to add some hover effect on the links may be an underline or a change in the text color.
Describe alternatives you've considered
Don't have an alternative consideration for this issue.
Additional context
NO

Assigning it to you


Segmentation fault in meson test

When executing meson test in the docker, all tests fail with a segmentation error. This situation does not occur outside the docker.
Meson setup is run as follows
meson setup build -Dtests=enabled -Db_coverage=true --optimization=0
I'm running my docker according to this instruction

Against which repo?
Usually that is in the Valgrind or ASAN/UBSAN phases indicating a failure of some sort. Do you have the full log you can upload to gist?

Can you provide a bit more information about your environment and what repo your trying to run the tests for? Maybe some output from meson setup would be helpful also?

I used the interactive docker mode and after adding support for valgrind in boost, you have to add the appropriate flag in meson setup. The problem was solved


fix(blame): add line threshold for large files

Fixes #891

Note this threshold won't help if a specific file with lines less than the threshold has a previous version with lines greater than the threshold.
Despite this, this PR is still a useful approximation.


confusion

is there a way to load png files or something? i dont see anything on the repo that shows anything like that

Raylib.loadTexture or Raylib.loadImage


HAWQ-412. Allocate query resource for multiple EXECUTIONs in explicit and implicit prepared statement

The resolution is to:

during planning phase, store the parameters that were used to allocate the query resource along with query resource itself in planned statement
in multiple EXECUTIONs, use the stored parameters to allocate query resource in the runtime

The query resource parameter includes:

Query resource life (i.e., QRL_ONCE, QRL_INHERIT)
Slice number
Query cost (i.e., iobytes)
Maximum target segment number
Minimum target segment number
Hostname volume information
Hostname volume information size

+1

+1 if memory context issue is fixed.

Good idea. For a quick fix, we can use CacheMemoryContext which is 8M at maximum.
We are investigating on plan context for different queries including:

SPI query
Named prepared statement
Unnamed prepared statement
After that, we can use more appropriate memory context for prepared plan accordingly. This will be a separate improvement.


Strip ANSI color codes in branch names

There is an error diring initial launch hack command

After all the .git/config file contains wrong branch names
[git-town]
    main-branch-name = master
[git-town-branch "test"]
    parent = master

Same issue after the ship command.
My git town version is 7.1.0

Very odd. I'm not able to reproduce on my machine (MacOS Sierra - 10.12.6, fish shell). What operating system / shell are you using?
We are making use of https://github.com/AlecAivazis/survey for prompts and passing in strings (which in our tests have never had colors). We get the prompt options from running branch git branch.
It appears that by configuration colors, can be made to always be on instead of omitted if not output to a terminal. See the Colors in Git section here: https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration. Can you please list your output of git config -l? (with any sensitive data scrubbed)

I use zsh shell with iTerm and High Siera. Problem remains when I switch terminal to bash or fish.
My config output is
credential.helper=osxkeychain
user.name=Alexey Korolev
<EMAIL_ADDRESS>core.editor=nvim
core.pager=diff-so-fancy | less --tabs=4 -RFX
core.excludesfile=/Users/alphatroya/.gitignore
merge.tool=vimdiff
mergetool.vimdiff.cmd=nvim $MERGED
commit.gpgsign=true
diff.tool=vimdiff
push.default=simple
gpg.program=/usr/local/bin/gpg
mergetool.keepbackup=false
color.ui=always
color.diff.meta=yellow bold
color.diff.commit=green bold
color.diff.frag=magenta bold
color.diff.old=red bold
color.diff.new=green bold
color.diff.whitespace=red reverse
color.diff-highlight.oldnormal=red bold
color.diff-highlight.oldhighlight=red bold 52
color.diff-highlight.newnormal=green bold
color.diff-highlight.newhighlight=green bold 22
credential.helper=osxkeychain
credential.https://github.com.username=alphatroya

Thanks @alphatroya. Does it work if you change color.ui=always to color.ui=true? If you force Git to always output colors, then Git Town reads the branch name with colors when it calls Git to list all branches and gets confused. I have created #1132 to fix this on our end, but in the meantime this config change should hopefully resolve your issue.

Thanks!
Ok confirmed the issue can be caused by color.ui=always. For my understanding, what caused you to set that property?
We can use https://github.com/acarl005/stripansi to remove ansi colors for users with that property set. I'll try to write a failing feature test for this which should be easy enough.


Add vs 2019 preview support

This great plugin doesn't support vs 2019 preview.
Is there a workaround to use it with vs 2019?

i'm trying out the rc now, so I'll see about updating this now.

Thanks, will be appreciated!

Visual Studio 2019 is GA.
Hopes zbrad can spend some time to make it work.
Thanks very much.

I was able to get this built and working on the Visual Studio 2019 release.
Repair the VS2013 installation via Add/Remove programs (this restores the EnvDTE assembly that was removed by VS2017 or VS2019 installation)
Open the solution in VS2019
Change the targeted framework to 4.7.2
Add a reference to Microsoft.VisualStudio.Shell.Framework;
Add "using Microsoft.VisualStudio.Shell.Framework;" to CommandRouterProvider.cs (not sure if this is necessary)
Add a prerequisites section to source.extension.vsixmanifest
 <Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.NuGet" Version="[16.0.28625.61,17.0)" DisplayName="NuGet package manager" />
</Prerequisites>
Change the install target to 16.0 in source.extension.vsixmanifest
Build the .vsix
Close visual studio
Run the .vsix
Open visual studio and select emacs from the keyboard options
This may need more work but should get you going for now.

I was able to get this built and working on the Visual Studio 2019 release.
Repair the VS2013 installation via Add/Remove programs (this restores the EnvDTE assembly that was removed by VS2017 or VS2019 installation)
Open the solution in VS2019
Change the targeted framework to 4.7.2
Add a reference to Microsoft.VisualStudio.Shell.Framework;
Add "using Microsoft.VisualStudio.Shell.Framework;" to CommandRouterProvider.cs (not sure if this is necessary)
Add a prerequisites section to source.extension.vsixmanifest
 <Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.NuGet" Version="[16.0.28625.61,17.0)" DisplayName="NuGet package manager" />
</Prerequisites>
Change the install target to 16.0 in source.extension.vsixmanifest
Build the .vsix
Close visual studio
Run the .vsix
Open visual studio and select emacs from the keyboard options
This may need more work but should get you going for now.

Could you please share your .vsix file?
I don't have VS2013 installation.
Thanks very much.

Sure, It's not signed. You will need to extract the vsix from the attached zip.
Microsoft.VisualStudio.Editor.EmacsEmulation.zip

Sure, It's not signed. You will need to extract the vsix from the attached zip.
Microsoft.VisualStudio.Editor.EmacsEmulation.zip

Thank you so much! Been dying to try VS 2019, but really needed these bindings. Thanks again!

Sure, It's not signed. You will need to extract the vsix from the attached zip.
Microsoft.VisualStudio.Editor.EmacsEmulation.zip

Thank you sooooooo much! Finally I can use VS 2019. :)


Draft: Change the representation of unit types

This was previously fixed though its merge highlighted several issues that have yet to be resolved. See discussion at the following locations.
#43
#82
#96
This is the new PR to fix this which helpfully already includes the necessary 'revert revert' commit.

Per #96, it seems like the relevant types should be name?: null instead of name: null; was that reverted deliberately?


Operator Greater not implemented.

I successfully convert the pytorch model to the onnx. The converted model cannot be loaded in tvm (0.6_dev0), because the greater operator is not implemented. The greater operator is supported in the tvm relay. Any suggestion?

It is probably a single missing line in the ONNX conversion code. cc @zhreshold

If you are interested in contributing you just need to provide a converter here: https://github.com/dmlc/tvm/blob/master/python/tvm/relay/frontend/onnx.py#L781.

listDiff operator in https://github.com/dmlc/tvm/tree/master/python/tvm/relay/frontend/tensorflow.py not implemented too.

https://github.com/dmlc/tvm/pull/3186

Thank you!


MapBox dependency error for React Native.

As of October 02 2024, Im using latest React Native Version.
after my complete installation of mapbox in react native, i got this error:
Could not determine the dependencies of task ':app:compileDebugJavaWithJavac'. > Could not resolve all task dependencies for configuration ':app:debugCompileClasspath'. > Could not find com.mapbox.maps:android:10.1.31. Required by: project :app * Try: > Run with --stacktrace option to get the stack trace. > Run with --info or --debug option to get more log output

Getting something similar when trying to build for ios
The following build commands failed: ▸ 	CompileSwift normal arm64 (in target 'MapboxMaps' from project 'Pods') ▸ 	SwiftCompile normal arm64 Compiling\

Getting something similar when trying to build for ios
The following build commands failed:
▸ 	CompileSwift normal arm64 (in target 'MapboxMaps' from project 'Pods')
▸ 	SwiftCompile normal arm64 Compiling\

i think we should declare the library name in babel.config file as well. Just like we did it for re-animated


Documentation for Filtering / Rules? (how to filter with wildcard? or filter by existence of custom journal field?)

I've just discovered cysystemd - great package, thanks for all your work on it.
However, I'm having trouble with the Rules syntax and application of these for efficient filtering of journald entries. Is there any documentation for this please? Or more examples - e.g. projects you know that use cysystemd?
Specifically, my two questions are:

Using journalctl it's possible to use wildcards when searrching for journal fields. How can I do this with cysystemd please? For example, the example in the README is:

from cysystemd.reader import JournalReader, JournalOpenMode, Rule

rules = (
  Rule("SYSLOG_IDENTIFIER", "CRON") &
  Rule("_SYSTEMD_UNIT", "crond.service") |
  Rule("_SYSTEMD_UNIT", "cron.service")
)

cron_reader = JournalReader()
cron_reader.open(JournalOpenMode.SYSTEM)
cron_reader.seek_head()
cron_reader.add_filter(rules)

But if I try to use a wildcard, e.g. Rule("SYSLOG_IDENTIFIER", "CR*")  I get no matches.

Is it possible to add a filter that matches events which simply contain some custom journal field, irrelevant of its contents. For example, say I write journal entries like this:

from cysystemd import journal
journal.send(
    message="Hello",
    priority=journal.Priority.INFO,
    some_field='some value',
)

How do I use the JournalReader() to filter events which contain the some_field key, irrelevant of the value assigned to that field?
Thank you.

Thank you for your kind words and for using cysystemd! I'm glad to hear that you're finding the package useful.
Wildcard matching isn't natively supported by cysystemd's Rule syntax, but there are workarounds to achieve similar functionality. As for filtering based on the presence of a custom field, you need to adapt the filtering to iterate through entries manually.
cysystemd doesn't directly support wildcards in the Rule API as journalctl does in its query syntax. This is because cysystemd uses the underlying sd_journal_add_match C-library call, which doesn't interpret wildcards like shell globbing.
To achieve similar functionality, you need to fetch the entries and then filter them programmatically in Python. For example:
import fnmatch
from cysystemd.reader import JournalReader, JournalOpenMode, Rule

cron_reader = JournalReader()
cron_reader.open(JournalOpenMode.SYSTEM)
cron_reader.seek_head()

while cron_reader.get_next():
    entry = cron_reader.get_entry()
    if fnmatch.fnmatch(entry.get("SYSLOG_IDENTIFIER", ""), "CR*"):
        print(entry)

In this case, fnmatch.fnmatch() will allow you to apply a wildcard-like filter after retrieving each journal entry.

Thanks for the quick reply. That makes sense and should work.
I just wondered if there was a Rule-based approach that may be more efficient than iterating over all entries.
Thanks!


Changed version origin for --version command #52

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

envcloak/cli.py
95.23% <100.00%> (+0.23%)
:arrow_up:

envcloak/encryptor.py
95.95% <ø> (ø)


Updating RxSwift

Use bind(to:) in rxswift 3.4
This change was spurred on by cocoapods' Trunk complaints:

Validating podspec
 -> Intrepid (0.7.8)
    - WARN  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:27:57: warning: 'bindTo' is deprecated: renamed to 'bind(to:)'
    - NOTE  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:27:57: note: use 'bind(to:)' instead
    - WARN  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:31:57: warning: 'bindTo' is deprecated: renamed to 'bind(to:)'
    - NOTE  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:31:57: note: use 'bind(to:)' instead
    - WARN  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:43:23: warning: 'bindTo' is deprecated: renamed to 'bind(to:)'
    - NOTE  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:43:23: note: use 'bind(to:)' instead
    - WARN  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:67:10: warning: 'bindTo' is deprecated: renamed to 'bind(to:)'
    - NOTE  | [Intrepid/Rx] xcodebuild:  Intrepid/SwiftWisdom/Rx/Rx+Extensions.swift:67:10: note: use 'bind(to:)' instead

retest this please

retest this please

Thanks! Just in time!


Custom Partitioners

@edenhill ready for review
cc: @ChadJessup - this is how it ended up, FYI - thanks for the initial version.
There is a requirement to be able to set a default custom partitioner (i.e. what to use if a topic partitioner isn't set). This could be implemented by intercepting each produce request, and adding a new partitioner if the topic is unknown, but this is inefficient, on the hot path, and the capability would be good in librdkafka. Leaving this as a separate scope of work.


Usage scenarios for Directive

Recently I've been doing some visualization work and I've been passing const useChart => (opts) => el => {} to <div ref={} />, Directive can do something similar but it looks more complicated, I'd like to know in what scenarios Directive should be used?

I see a directive as like a special kind of hook that receives a ref not from the user but from the framework directly.
And in some way I see them as an extension mechanism for the JSX, like class or style in some sense are built-in directives, you can define your own directives, but they need to be prefixed with use: when used in the JSX.
I use directives a lot, possibly too much, one of my favorite directive is a "use:shortcuts" directive that kinda attaches shortcuts to an element, shortcuts that are active while the focus is within the element.
I think there's no scenario where you must use a directive, it's kinda up to you, if you like it you can use them, otherwise it's fine as well.
I think their main feature is convenience really. Like if there was no "class" prop I'd definitely define a custom directive for it, because juggling refs and hooks would be way less convenient. If the improvement on convenience isn't big enough with a directive I just go with a hook myself.


[BUG] TypeError: Cannot read properties of undefined (reading '__knexUid')

I suspect that some bug is causing bulk connection drops.
In a long list of LOG: unexpeced EOF on client ... I see this error twice:
nostr-ts-relay  | /app/src/app/worker.js:29
nostr-ts-relay  |         throw error;
nostr-ts-relay  |         ^
nostr-ts-relay  |
nostr-ts-relay  | TypeError: Cannot read properties of undefined (reading '__knexUid')
nostr-ts-relay  |     at Client_PG.releaseConnection (/app/node_modules/knex/lib/client.js:324:58)
nostr-ts-relay  |     at Transform.<anonymous> (/app/node_modules/knex/lib/execution/runner.js:72:19)
nostr-ts-relay  |     at Transform.emit (node:events:525:35)
nostr-ts-relay  |     at emitCloseNT (node:internal/streams/destroy:132:10)
nostr-ts-relay  |     at emitErrorCloseNT (node:internal/streams/destroy:117:3)
nostr-ts-relay  |     at processTicksAndRejections (node:internal/process/task_queues:82:21)
nostr-ts-relay  |     at runNextTicks (node:internal/process/task_queues:64:3)
nostr-ts-relay  |     at listOnTimeout (node:internal/timers:533:9)
nostr-ts-relay  |     at process.processTimers (node:internal/timers:507:7)
nostr-ts-relay  |
nostr-ts-relay  | Node.js v18.12.1

I think 50 of 400 clients dropped that moment.
I'm running rev 273dcc65303b9fef9b974715cd65932cb6fd8c6f.
(sorry for not going through the template.)

I'm getting this slightly different stacktrace now at startup.
nostr-ts-relay        |
nostr-ts-relay        |  ███▄    █  ▒█████    ██████ ▄▄▄█████▓ ██▀███  ▓█████ ▄▄▄       ███▄ ▄███▓
nostr-ts-relay        |  ██ ▀█   █ ▒██▒  ██▒▒██    ▒ ▓  ██▒ ▓▒▓██ ▒ ██▒▓█   ▀▒████▄    ▓██▒▀█▀ ██▒
nostr-ts-relay        | ▓██  ▀█ ██▒▒██░  ██▒░ ▓██▄   ▒ ▓██░ ▒░▓██ ░▄█ ▒▒███  ▒██  ▀█▄  ▓██    ▓██░
nostr-ts-relay        | ▓██▒  ▐▌██▒▒██   ██░  ▒   ██▒░ ▓██▓ ░ ▒██▀▀█▄  ▒▓█  ▄░██▄▄▄▄██ ▒██    ▒██
nostr-ts-relay        | ▒██░   ▓██░░ ████▓▒░▒██████▒▒  ▒██▒ ░ ░██▓ ▒██▒░▒████▒▓█   ▓██▒▒██▒   ░██▒
nostr-ts-relay        | ░ ▒░   ▒ ▒ ░ ▒░▒░▒░ ▒ ▒▓▒ ▒ ░  ▒ ░░   ░ ▒▓ ░▒▓░░░ ▒░ ░▒▒   ▓▒█░░ ▒░   ░  ░
nostr-ts-relay        | ░ ░░   ░ ▒░  ░ ▒ ▒░ ░ ░▒  ░ ░    ░      ░▒ ░ ▒░ ░ ░  ░ ▒   ▒▒ ░░  ░      ░
nostr-ts-relay        |    ░   ░ ░ ░ ░ ░ ▒  ░  ░  ░    ░        ░░   ░    ░    ░   ▒   ░      ░
nostr-ts-relay        |          ░     ░ ░        ░              ░        ░  ░     ░  ░       ░
nostr-ts-relay        |                               v1.17.0 by Cameri
nostr-ts-relay        |             NIPs implemented: 1,2,4,9,11,12,15,16,20,22,26,28,33
nostr-ts-relay        |                               8 workers started
nostream-tor_proxy-1  | Jan 16 17:02:15.000 [notice] New control connection opened from <IP_ADDRESS>.
nostr-ts-relay        | saving private key to /home/node/v3_onion_private_key
nostr-ts-relay        | tor hidden service address: o3kbnz7kax2evrlbro3ixuo7ddlgi6ijg3uifwdpuha5gsgenannikad.onion:80
nostr-ts-relay        | /app/src/app/worker.js:29
nostr-ts-relay        |         throw error;
nostr-ts-relay        |         ^
nostr-ts-relay        |
nostr-ts-relay        | TypeError: Cannot read properties of undefined (reading '__knexUid')
nostr-ts-relay        |     at Client_PG.releaseConnection (/app/node_modules/knex/lib/client.js:324:58)
nostr-ts-relay        |     at Transform.<anonymous> (/app/node_modules/knex/lib/execution/runner.js:72:19)
nostr-ts-relay        |     at Transform.emit (node:events:525:35)
nostr-ts-relay        |     at emitCloseNT (node:internal/streams/destroy:132:10)
nostr-ts-relay        |     at emitErrorCloseNT (node:internal/streams/destroy:117:3)
nostr-ts-relay        |     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
nostr-ts-relay        |
nostr-ts-relay        | Node.js v18.12.1

After restarting 2h ago, it apparently did not come up well but with no other errors I could see.
I changed postgres, nginx and nostream configs to allow for more client connections as discussed on TG. The server's disk IO dropped dramatically, while ss -s reporting record connections. Restarting the relay 2h ago then appears to have killed it. Now, after a new restart, where I saw above error again it appear to be accepting connections.
I noticed that it responded slowly on the first try but now it looks good. By "slowly" I mean that querying 500 events yielded 1 event quickly and only after several seconds did it pick up speed, delivering the other 499.

I noticed that it responded slowly on the first try but now it looks good. By "slowly" I mean that querying 500 events yielded 1 event quickly and only after several seconds did it pick up speed, delivering the other 499.
If you didn't limit your query to historical events it's possible that first event that came in was just recently broadcasted. Nostream doesn't wait for the stored events to be sent first before sending you recently broadcasted ones.

If you didn't limit your query to historical events it's possible that first event that came in was just recently broadcasted. Nostream doesn't wait for the stored events to be sent first before sending you recently broadcasted ones.

That is a super interesting bit of information I guess most client devs are not aware of. My relay implementation probably has the same property there. That probably also is prone to deliver events twice and out of order.

If you didn't limit your query to historical events it's possible that first event that came in was just recently broadcasted. Nostream doesn't wait for the stored events to be sent first before sending you recently broadcasted ones.

That is a super interesting bit of information I guess most client devs are not aware of. My relay implementation probably has the same property there. That probably also is prone to deliver events twice and out of order.

Do you think the relay should buffer those and wait for EOSE?

I think it's a curiosity I had not thought about before but it's not very consequential.
I thought there was some prescription of the sorting of results but I can't find it now. Wasn't there something about events sorted newest to oldest if limit provided but oldest to newest else? Might have been removed because of what we are talking about here. Anyway, the nips don't mandate it one way or the other and clients shouldn't be surprised if they get some few duplicate events.


FractMilio

Please add the FractMilio Collection

I fixed the errors in meta.json file, but you still have the above issues. Please fix it. @FractMilio

Ok

Done

Done


[Bug]  Invalid aws session token

Cosmos in AthenaAccessKeyProfileMapping always tries to use a session token, even when it is not provided by the Airflow connection
Context

astronomer-cosmos= "1.3.2"
dbt-core = "1.7.14"
dbt-athena-community = "1.7.2"

When setting up a new aws connection using only aws_access_key_id and aws_secret_access_key, it
generates a profile like this:
profile_name:
    outputs:
        athena:
            aws_access_key_id: KEY_ID
            aws_secret_access_key: '{{ env_var(''COSMOS_CONN_AWS_AWS_SECRET_ACCESS_KEY'')}}'
            aws_session_token: '{{ env_var(''COSMOS_CONN_AWS_AWS_SESSION_TOKEN'')}}'
            database: db_name
            ...
    target: athena

But  AthenaAccessKeyProfileMapping sets the aws_session_token as an empty string, and dbt takes this value,
resulting in.
'botocore.exceptions.ClientError: An error occurred (UnrecognizedClientException)
 when calling the GetDatabases operation:
The security token included in the request is invalid', ''

Propose solutions
In profile function
Add a condition that check if there is a token.
profile = {
    **self.mapped_params,
    **self.profile_args,
    "aws_access_key_id": self.temporary_credentials.access_key,
    "aws_secret_access_key": self.get_env_var_format("aws_secret_access_key"),
    "aws_session_token": self.get_env_var_format("aws_session_token") if self.temporary_credentials.token else None,
}

HI @ssulca , thanks for reporting the issue and proposing a solution!
Would you like to contribute a PR with this fix? It would be highly appreciated.


Shell server terminated (code: 137, signal: null)

Issue Type: Bug
Error: Shell server terminated (code: 137, signal: null)
When:  Rebuild and Reopen Container or just Reopen in Container command
On: Ubuntu 20.04 running in WSL2 on Windows 11. Project was cloned inside WSL at folder ~/Projects
devcontainer.json content:
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
// https://github.com/microsoft/vscode-dev-containers/tree/v0.209.6/containers/docker-existing-docker-compose
// If you want to run as a non-root user in the container, see .devcontainer/docker-compose.yml.
{
	"name": "Existing Docker Compose (Extend)",
	// Update the 'dockerComposeFile' list if you have more compose files or use different names.
	// The .devcontainer/docker-compose.yml file contains any overrides you need/want to make.
	"dockerComposeFile": [
		"../docker-compose.yml",
		"docker-compose.yml"
	],
	// The 'service' property is the name of the service for the container that VS Code should
	// use. Update this value and .devcontainer/docker-compose.yml to the real service name.
	"service": "dev_container",
	// The optional 'workspaceFolder' property is the path VS Code should open by default when
	// connected. This is typically a file mount in .devcontainer/docker-compose.yml
	"workspaceFolder": "/workspace",
	// Set *default* container specific settings.json values on container create.
	"settings": {
		"terminal.integrated.shell.linux": null
	},
	// Add the IDs of extensions you want installed when the container is created.
	"extensions": [
		"ms-python.vscode-pylance",
		"ms-vsliveshare.vsliveshare",
		"be5invis.toml",
		"technosophos.vscode-make",
		"ms-python.python"
	],
	// Use 'forwardPorts' to make a list of ports inside the container available locally.
	// "forwardPorts": [],
	// Uncomment the next line if you want startp specific services in your Docker Compose config.
	// "runServices": [],
	// Uncomment the next line if you want to keep your containers running after VS Code shuts down.
	// "shutdownAction": "none",
	// Uncomment the next line to run commands after the container is created - for example installing curl.
	// "postCreateCommand": "pip install -U poetry localstack awscli-local"
	// Uncomment to connect as a non-root user if you've added one. See https://aka.ms/vscode-remote/containers/non-root.
	"remoteUser": "vscode"
}

docker-compose.yml (override):
version: '3.7'
services:
  # Update this to the name of the service you want to work with in your docker-compose.yml file
  dev_container:
    # If you want add a non-root user to your Dockerfile, you can use the "remoteUser"
    # property in devcontainer.json to cause VS Code its sub-processes (terminals, tasks,
    # debugging) to execute as the user. Uncomment the next line if you want the entire
    # container to run as this user instead. Note that, on Linux, you may need to
    # ensure the UID and GID of the container user you create matches your local user.
    # See https://aka.ms/vscode-remote/containers/non-root for details.
    #
    user: vscode

    # Uncomment if you want to override the service's Dockerfile to one in the .devcontainer
    # folder. Note that the path of the Dockerfile and context is relative to the *primary*
    # docker-compose.yml file (the first in the devcontainer.json "dockerComposeFile"
    # array). The sample below assumes your primary file is in the root of your project.
    #
    # build:
    #   context: .
    #   dockerfile: .devcontainer/Dockerfile

    volumes:
      # Update this to wherever you want VS Code to mount the folder of your project
      - .:/workspace:cached
      # Uncomment the next line to use Docker from inside the container. See https://aka.ms/vscode-remote/samples/docker-from-docker-compose for details.
      # - /var/run/docker.sock:/var/run/docker.sock

      # Uncomment the next four lines if you will use a ptrace-based debugger like C++, Go, and Rust.
      # cap_add:
      #   - SYS_PTRACE
      # security_opt:
      #   - seccomp:unconfined

      # Overrides default command so things don't shut down after the process ends.
    command: /bin/sh -c "while sleep 1000; do :; done"

Dockerfile:
FROM fintech-insurance-aquisition-api:local

# For VSCode Docker Extension to work with non-root user
# Please check https://aka.ms/vscode-remote/containers/non-root
USER root
ARG USERNAME=vscode
ARG USER_UID=1000
ARG USER_GID=$USER_UID
RUN groupadd --gid $USER_GID $USERNAME | true \
    && useradd --uid $USER_UID --gid $USER_GID -m $USERNAME | true \
    && apt-get update \
    && apt-get install -y sudo \
    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
    && chmod 0440 /etc/sudoers.d/$USERNAME

# Let image ready for development
RUN apt-get -y upgrade
RUN apt-get install -y tar git build-essential libssl-dev zlib1g-dev libbz2-dev zip \
    libreadline-dev libsqlite3-dev wget curl llvm libncurses5-dev libncursesw5-dev \
    xz-utils tk-dev libffi-dev liblzma-dev python3-openssl libpq-dev libcurl4-openssl-dev

WORKDIR /app/src

# Add AWS client v1
RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip" -o "awscliv2.zip"
RUN unzip -o awscliv2.zip
RUN ./aws/install --update

# Update libs
RUN pip install -U pip poetry localstack awscli-local

USER $USERNAME

CMD [ "tail", "-f", "/dev/null" ]

remoteContainers.log last lines:
[2022-01-20T03:30:44.388Z]
[2022-01-20T03:30:44.388Z] Stop (3 ms): Run in container: (cat /etc/os-release || cat /usr/lib/os-release) 2>/dev/null
[2022-01-20T03:30:44.389Z] Start: Run in container: cat /etc/passwd
[2022-01-20T03:30:44.391Z] Stop (2 ms): Run in container: cat /etc/passwd
[2022-01-20T03:30:44.392Z] Start: Setup shutdown monitor
[2022-01-20T03:30:44.393Z] Forking shutdown monitor: c:\Users\chris\.vscode\extensions\ms-vscode-remote.remote-containers-0.209.6\dist\shutdown\shutdownMonitorProcess \\.\pipe\vscode-remote-containers-411276d2811ee645dadd4b0bf9145ac53c2ad7fe-sock dockerCompose Debug c:\Users\chris\AppData\Roaming\Code\logs\20220119T232603\exthost1\ms-vscode-remote.remote-containers<PHONE_NUMBER>711
[2022-01-20T03:30:44.409Z] Stop (17 ms): Setup shutdown monitor
[2022-01-20T03:30:44.410Z] Start: Run in container: test -d /home/vscode/.vscode-server
[2022-01-20T03:30:44.433Z]
[2022-01-20T03:30:44.433Z]
[2022-01-20T03:30:44.433Z] Exit code 1
[2022-01-20T03:30:44.433Z] Stop (23 ms): Run in container: test -d /home/vscode/.vscode-server
[2022-01-20T03:30:44.434Z] Start: Run in container: test -d /home/vscode/.vscode-remote
[2022-01-20T03:30:44.494Z] Stop (533 ms): Run in Host: docker exec -i -u vscode -e VSCODE_REMOTE_CONTAINERS_SESSION=7421d22e-7f3b-43ef-ad12-74d6cd78ebaf1642649435695 14034ae3b8dd9b246e991e02bca17444677b042600927cc5b1fd49b7ed6e5c02 /bin/sh
[2022-01-20T03:30:44.494Z] Start: Run in container: test -f /var/vscode-server/.patchEtcEnvironmentMarker
[2022-01-20T03:30:44.494Z] Start: Run in Host: docker exec -i -u root 14034ae3b8dd9b246e991e02bca17444677b042600927cc5b1fd49b7ed6e5c02 /bin/sh
[2022-01-20T03:30:44.503Z] Start: Run in container: test ! -f '/var/vscode-server/.patchEtcEnvironmentMarker' && set -o noclobber && mkdir -p '/var/vscode-server' && { > '/var/vscode-server/.patchEtcEnvironmentMarker' ; } 2> /dev/null
[2022-01-20T03:30:44.786Z] Stop (292 ms): Run in Host: docker exec -i -u root 14034ae3b8dd9b246e991e02bca17444677b042600927cc5b1fd49b7ed6e5c02 /bin/sh
[2022-01-20T03:30:44.786Z] Start: Run in container: test -f /var/vscode-server/.patchEtcProfileMarker
[2022-01-20T03:30:44.787Z] Start: Run in container: test ! -f '/var/vscode-server/.patchEtcProfileMarker' && set -o noclobber && mkdir -p '/var/vscode-server' && { > '/var/vscode-server/.patchEtcProfileMarker' ; } 2> /dev/null
[2022-01-20T03:30:44.787Z] Start: Run in container: test ! -f '/home/vscode/.vscode-server/data/Machine/.writeMachineSettingsMarker' && set -o noclobber && mkdir -p '/home/vscode/.vscode-server/data/Machine' && { > '/home/vscode/.vscode-server/data/Machine/.writeMachineSettingsMarker' ; } 2> /dev/null
[2022-01-20T03:30:44.787Z] Start: Run in container: cat /home/vscode/.vscode-server/data/Machine/settings.json
[2022-01-20T03:30:44.787Z] Start: Run in container: test -d /home/vscode/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3
[2022-01-20T03:30:44.788Z] Installing VS Code Server for commit 899d46d82c4c95423fb7e10e68eba52050e30ba3
[2022-01-20T03:30:44.788Z] Start: Installing VS Code Server
[2022-01-20T03:30:44.788Z] Start: Run in container: mkdir -p /home/vscode/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3_1642649444788
[2022-01-20T03:30:44.788Z] Stop (0 ms): Installing VS Code Server
[2022-01-20T03:30:44.793Z] Shell server terminated (code: 137, signal: null)

[2022-01-20T03:30:53.642Z] Start: Run: wsl -d Ubuntu -e wslpath -u \\wsl.localhost\Ubuntu\home\chrismaille\Projects\Facily\fintech-insurance-acquisition
[2022-01-20T03:30:53.754Z] Stop (112 ms): Run: wsl -d Ubuntu -e wslpath -u \\wsl.localhost\Ubuntu\home\chrismaille\Projects\Facily\fintech-insurance-acquisition

VS Code version: Code 1.63.2 (899d46d82c4c95423fb7e10e68eba52050e30ba3, 2021-12-15T09:40:02.816Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No
Remote OS version: Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

System Info

Item
Value

CPUs
AMD Ryzen 7 2700X Eight-Core Processor          (16 x 3693)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.93GB (38.07GB free)

Process Argv
--crash-reporter-id 4279eadd-84af-4331-b713-249a89759721

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 2700X Eight-Core Processor (2 x 3693)

Memory (System)
7.77GB (0.13GB free)

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

vsc-material-theme
Equ
33.2.2

vsc-material-theme-icons
equ
2.2.1

vscode-firefox-debug
fir
2.9.6

dotenv
mik
1.0.1

vscode-language-pack-pt-BR
MS-
1.63.3

jupyter-keymap
ms-
1.0.0

remote-containers
ms-
0.209.6

remote-ssh
ms-
0.70.0

remote-ssh-edit
ms-
0.70.0

remote-wsl
ms-
0.63.13

vscode-remote-extensionpack
ms-
0.21.0

material-icon-theme
PKi
4.11.0

vscode-docker
ms-
1.19.0

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30425749
pythontb:30283811
pythonvspyt551:30345470
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dsc:30424895
pythonvs932:30410667
vscop804:30404766
vs360:30404995
vsrem710cf:30416617
vsbas813:30425875

I'm having the same issue when rebuilding a working container.
OS: Windows 10
WSL2 OS: Ubuntu 20.04.3 LTS
VS Code version: 1.63.2

Extensions

Extension
Author (truncated)
Version

dotenv
mik
1.0.1

remote-containers
ms-
0.209.6

remote-wsl
ms-
0.63.13

debugger-for-edge
msj
1.0.15

slim
sia
0.1.2

vscode-ruby
win
0.28.0

rails
bun
0.17.8

vscode-gemfile
bun
0.4.2

path-intellisense
chr
2.6.1

gitlens
eam
11.7.0

intellij-idea-keybindings
k--
1.5.0

vscode-docker
ms-
1.19.0

ruby
reb
0.28.1

vscode-yaml
red
1.3.0

slim
sia
0.1.2

vscode-ruby
win
0.28.0

System info

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2904)

GPU Status
2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled

Load (avg)

Memory (System)
15.88GB (7.16GB free)

Process Argv
--folder-uri=vscode-remote://wsl+Ubuntu-20.04/home/dhallek/dev/certipro --remote=wsl+Ubuntu-20.04 --crash-reporter-id 817e0c48-88bc-47e0-9a73-5a7587844790

Screen Reader
no

VM
0%

OS
Linux x64 5.4.72-microsoft-standard-WSL2

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2903)

Memory (System)
12.39GB (11.57GB free)

VM
0%


Fan is added, HomeKit interface works nothing happens

The fan has been successfully added to HomeKit and I can interact with it there(ie adjust the speed, turn it off / on etc) however nothing actually happens.
Could this be related to the fact it’s also connected to the ecobee. Is it one or the other?
Didn’t see anything unusual other than the senseme server was shut down.

It shouldn't matter if it's also connected to ecobee. Can you set your homebridge DEBUG settings to include haiku-senseme:* and post your homebridge log file?


Explanation of example

Explanation of the first example on line 18 and 19

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Congrats @drawingvishal on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Integrate the task polling in data requests

As a follow-up of #1387 : to make the visualization components agnostic of the underlying requests to the backend, we might factor out some of the logic involved in getting task ids and polling to the visualization.service.

NB when it comes to #1340, I wonder how to deal with the fact that some visualizations start tasks, and other don't?

Short answer is that it's one of the things we'll have to figure out if we implement that.
I guess we'll either make that a configuration of the plugin (and part of the metadata sent to the frontend) or say that plugin visualisations are always run as tasks because the main application's doesn't know how long they'll take.


[ SECURITY ] Deployment site shows not secured and redirects

Yeah, You are right. Not enforced https.  Site not provided a layer of encryption.

I think thats an issue with the k8s-cluster. Not sure if this can be solved with a PR.

This can't be solved with a pr.. I think we need a ssl certificate for this

Where are we with this? I got a warning from Google Chrome today asking if I wanted to run or proceed with visiting the site.

Where are we with this? I got a warning from Google Chrome today asking if I wanted to run or proceed with visiting the site.

Well, that mostly happens unless it detects some virus or something on the website.. weird.

I will reach out to some people who could help with this. I also found an potential example
https://www.digitalocean.com/community/questions/is-there-a-managed-load-balancer-with-https-support-for-digitalocean-kubernetes

Try doing this, the issue is that you made the site so long back that it only has http and not https://
https://www.brafton.com/blog/distribution/how-to-convert-http-to-https-a-quick-guide/

What's weird though is that https://www.eddiehub.org/ is secure and linkfree isn't?

I will reach out to some people who could help with this. I also found an potential example
https://www.digitalocean.com/community/questions/is-there-a-managed-load-balancer-with-https-support-for-digitalocean-kubernetes

Try doing this, the issue is that you made the site so long back that it only has http and not https://
https://www.brafton.com/blog/distribution/how-to-convert-http-to-https-a-quick-guide/

Or use a free SSL as suggested by @praveenscience

Thank you for raising and the collaboration 👍
We now have SSL for our EddieHub projects on our Kubernetes cluster


Adding full support for MPL plots

Hello @kmader! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file easy_dash/easydash.py:

Line 32:80: E501 line too long (85 > 79 characters)
Line 41:58: E203 whitespace before ':'
Line 64:63: E203 whitespace before ':'
Line 69:80: E501 line too long (87 > 79 characters)


add customize theme link

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Make sure you are merging your commits to dev branch.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

改成英文了


adding dynamic contributors

Issue that this pull request solves
Closes: #251
Proposed changes
Adding Dynamic contributor list ( Now no need to manually add contributor in another file. You can delete that file as well)
Brief description of what is fixed or changed
Types of changes
Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

As @Kajol-Kumari mentioned in #251 (comment), make sure that the images are linked with the contributors GitHub profile and please ensure that there are no merge conflicts as well.

Yep It's done now !! you can check @kingavatar

Looks good to me.
Couple of doubts: When a new contributor is added from the all-contributors bot.. Will the shape be circle only?

Looks good to me.
Couple of doubts: When a new contributor is added from the all-contributors bot.. Will the shape be circular only?

@goliakshay357 we won't require the bot anymore as it will be taken care by this

@goliakshay357 we won't require the bot anymore as it will be taken care by this

Yep It is done using contribution graph. Which you can see in contributor block of insights section of this repo. So there is no need to of .allcontributor_src file( Can I delete that file ).
@Kajol-Kumari So can I remove that existing block of contributor ?? I have commented those because i don't want to delete anything from this project without your permission. So should I delete that file and remove that block from README. Because this looks great in styling and it is more efficient as well.

Hey @Vishal-raj-1 , please remove all-contributors src file as well as we won't need that after this PR.

Hey @Vishal-raj-1 , please remove all-contributors src file as well as we won't need that after this PR.

Thanks for your quick reply !!

Thanks for incorporating suggested changes @Vishal-raj-1
LGTM 👍

Thanks for merging my PR !! Please update my points to +7 in NWOC.

Thanks for incorporating suggested changes @Vishal-raj-1
LGTM 👍

Thanks for merging my PR !! Please update my points to +7 in NWOC. @Kajol-Kumari

Done :)
Please keep commenting like this in the PRs so that we don't miss your score.

Please keep commenting like this in the PRs so that we don't miss your score.

Sure !! Thanks mam


[Ledger Migration] - Stuck at finding balance with legacy app

Issue description
Stuck at finding balance when using new Firefly 1.2.0 to migrate funds on a Ledger Nano S
Wallet version
0.7.3 - New IOTA App
0.5.8 - Legacy Ledger App
2.0.0 - Ledger Firmware version
1.2.0 - Firefly desktop
System specification
Windows 10
I just tried this on my Windows 10 Laptop instead and it worked there and I've now migrated successfully, so this seems isolated to my desktop machine, but may be an issue for others.
Is it a repeatable issue?
Yes
Steps To reproduce the issue
Explain how the maintainer can reproduce the issue.
Follow the new Trinity -> Firefly migration guide for Ledger devices.
When you get to checking balance, after swapping to the legacy app it just sits like this (I've currently waited 20 minutes).
Also the app on the ledger has done nothing, it doesn't say generating address. I've tried restarting the ledger and re-installing the legacy app.

Expected behaviour
Successfully find my balance
Actual behaviour
It hangs and never finds my balance. The Ledger app doesn't seem to do anything (I.e. no address generation).
Errors
No errors in the log unfortunately.

This is the state my ledger is in at this point, in the legacy app but it doesn't seem to actually "do" anything.

You can try to reinstall both apps (Legacy and new IOTA app). You can also try to run Firefly as admin if your OS is windows. To have further support you can go to the IOTA Discord server and visit the help channel.

@chrisella Have you successfully migrated your tokens?

Yes I managed to by using my other computer in the end, I had no luck
whatsoever on my main desktop machine.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iotaledger/firefly/issues/1375#issuecomment-902863789,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIFCDFE6W7ZCJFGTRAP4HLT52KCHANCNFSM5BVKA34A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Okay so I guess this issue can be closed


Remove DiagnosticAdapter and use DiagnosticListener directly

Try out using DiagnosticListener without DiagnosticAdapter and see it it improves performance

I think @Dmitry-Matveev has proof that it indeed saves some performance and it should be merged.
Current functional tests are sufficient.
I believe the main reason for perf hit from DiagnosticsAdapter was in IRouteData interface - we created this to avoid taking the dependency on the  Microsoft.AspNetCore.Routing.Abstractions and DiagnosticAdapter was dynamically typing IRouteData from that package to ours.


user's voice channel's are not being updated in latest indev

on commit https://github.com/hydrabolt/discord.js/commit/4b8f85d44ac7f9b8a2bf9bcec75e74e1285cc35b the user's VoiceChannel is not being updated from the time the bot is started.
steps to reproduce.
Join a voice channel with a standard client.
Start up your bot
change to a different voice channel, preferably on the same server.
have it Join the voice channel of the author of a command you use to have it join a voice channel.
it will join the voice channel you were in when you started the client, not the one  you are currently in.
note that the same bot was tested on https://github.com/hydrabolt/discord.js/commit/358c40c3557cc0cbd05aa33fad0c50ee7222bd5a and worked perfectly.

The API isn't designed to work when the account you are logged in with is being used somewhere else too. You shouldn't be running the Client alongside your bot.

Oh whoops I misread this...
I believe the design for Discord only allows for one voice connection per account per server.

@abalabalaha is that relevant to this bug?

Ohh, when I say the client I mean discord that I have my own personal account logged into

Clarity pls...

@macdja38 the API still isn't designed to work when there is interference by another bot or a client...

I have the same issue, i think he means that when you implement a summon command (bot.joinVoiceChannel --> message.author.voiceChannel) it joins the channel you were in when the bot started.

Yup

I'll repeat myself, when I say client, I mean discord with my own personal account, not the bots account.

I tested it the same way with two different commits, it works on the old one, it's broken I. The new one.

wanted to add to this (I'm not using Indev tho)

Not in a channel on main account
Start bot
Join a channel
voiceJoin event is NOT detected -- the event is detected in voiceStateUpdate
Leave channel
voiceChannel in the voiceLeave callback returns a SERVER object, not a voice channel object

@jennyl please test using InDev, as that would be what is patched, if there is an issue.

Just tested using indev, still the same

Can confirm that message.author.voiceChannel in a message event is not updated after the bot has been initialized. From master or indev.


On safari, getStats method returns switchHistory as an empty array.

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v2.5.9-debug
Please ask your question
On using fairplay for DRM protected content on safari, the player returns empty array in switchHistory when calling player.getStats(). Is this expected? How can I get switchHistory in safari for DRM protected content?

DRM content in Safari is played using Apple's native HLS implementation.  We don't control switching resolutions in JavaScript in that scenario, nor do we get any visibility into the switching that Apple does for us.  So unfortunately, there is nothing we can do about that.
Sorry for the inconvenience!

Yes, that makes sense. Thanks.


P43 $applyAsync initialization missing from constructor

Hey @teropa. I am back to business.
On the Scope constructor there, there is not $$ApplyAsyncQueue nor $$ApplyAsyncId from the previous new section.

Fixed, thank you!


settings: Move check_settings_values to user_settings.py.

This PR moves check_settings_values to user_settings.py
from validator.py such that we can import the functions at
the top without any issue of cyclic imports.
Follow up of #18884.

@timabbott ready for review.

Merged, thanks @sahil839!


[Feature] Categorical feature transform allows some input values are None

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

it looks good to me. but do we really need to support None in the input data?

does it represent missing categorical values?

does it represent missing categorical values?

Yes. If for some rows, there is no categorical value, i.e., empty, we treat it as all zeros in one-hot encoding.


Documentation for ion-input incorrect for autocomplete and autocorrect attributes

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The documentation for the two attributes: and are incorrectly labelled: @input {string} Instructional text that shows before the input has a value.
Expected behavior:
For these to be labelled correctly. I have created a pull request and raising this to link the two.
N/A

I pushed some commits incorrectly for the first pull. Ignore this - the second Open link is correct.

Thanks for the PR @kelvindart ! Since Manu merged it I am going to close this issue for now. Thanks!


[5.0.3] The file list is not hidden/dismissed

The file list popup is not hidden/dismissed  when file selected or clicked outside, I have to click on the button again.

Can be closed, it works with new release

:+1:


refactor(private-repo): move pkgs to overlays

#49  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zakuciael and the rest of your teammates on  Graphite


Enhancement: Create our own AxiosRequestConfig interface

To complete https://github.com/pnp/cli-microsoft365/issues/4232, we have to be able to read the response headers of a request.
Therefore we can extend the default AxiosRequestConfig options with our own options.
interface CliRequestOptions extends AxiosRequestOptions {
  fullResponse?: boolean;
}

Todo:

Create new request options interface
All our functions within the Request class should accept this new interface instead of the AxiosRequestConfig
Return the whole result when fullResponse is true (like we do for streams).
https://github.com/pnp/cli-microsoft365/blob/539ef23a2c569a5fd6d09cf1ebe101c73539254c/src/request.ts#L180-L185

Nice! Few suggestions:

let's name the class CliRequestOptions rather than PnP. We're using the PnP abbr less and less these days
since our interface inherits from the base Axios interface, we don't need to update existing code unless we really need access to new props. Otherwise, for the sake of simplicity we could leave the existing references as-is

So you wouldn't update the options type for let's say request.get? Just leave it and check in the execute method which type the options are?
Something like
If (typeof options === 'CliRequestOptions && options.fullResponse) {
Return whole response
}

Seems like a solid plan!

If we update the signature in get and execute it will allow us to benefit from design-time typesafety which we should aim for... but it will also lead to broken code wherever we use AxiosRequestConfig right now, which I wanted to avoid to limit the scope of changes, but which I don't think we can avoid. So let's update the signature in our request class and take the refactoring hit where necessary.

Would like to work on this one

Awesome! All yours!


Track adding control flow passes for optimization level 1

What should we add?
This issue is to track the target set of passes to enable control flow handling for transpiler optimization_level=1.

[X] SetLayout (no change)
[ ] UnitarySynthesis (#8565 )
[ ] Unroll3qOrMore (#8445 )
[X] TrivialLayout (no change)
[ ] Layout2qDistance
[ ] VF2Layout
[ ] DenseLayout
[ ] FullAncillaAllocation
[ ] EnlargeWithAncilla
[ ] ApplyLayout
[ ] CheckMap
[ ] BarrierBeforeFinalMeasurements
[ ] StochasticSwap (#8418)
[ ] UnrollCustomDefinitions
[X] BasisTranslator(#7808)
[ ] RemoveResetInZeroState
[ ] Depth
[ ] FixedPoint
[ ] Size
[ ] Optimize1qGatesDecomposition
[ ] CXCancellation
[ ] ContainsInstruction

Should we add SabreLayout and SabreSwap to this list because of: #8552 ?

We can put it in the list.  I don't think there's any chance of us supporting Sabre for 0.22 when there's control flow.  Part of this is working out what (if any) chances to the preset pass-manager logic we need for the initial support, when there's control-flow in the circuit.  The general idea being that we can have tweaked preset pass-manager logic if there's control flow or not, while we're building up to full support everywhere, but we want the literal call transpile(qc, optimization_level=1) to work for 0.22.

For the timeline of 0.22 it might be better to prioritize a set of non-redundant passes. Since BasicSwap and StochasticSwap have already been started it may be faster to get some other items on the list complete before coming back to implement alternative (even if soon to be default) routing passes.

@ewinston Can you call out in the list above which passes are easily implementable as recursion over the blocks of each ControlFlowOp, and those which need some custom handling?

@kdk Just saw this comment. Here's which passes might require special handling of blocks,
*** SetLayout
no
*** UnitarySynthesis
no
*** Unroll3qOrMore
no
*** TrivialLayout
no
*** Layout2qDistance
weight 2q distance for loop?
*** VF2Layout
possibly
*** DenseLayout
yes, for _build_error_matrix at least
*** FullAncillaAllocation
perhaps since controlflow ops may appear full width
*** EnlargeWithAncilla
no
*** ApplyLayout
no recursion
*** CheckMap
yes
*** BarrierBeforeFinalMeasurements
yes, simple
*** StochasticSwap
yes
*** UnrollCustomDefinitions
no
*** BasisTranslator
no
*** RemoveResetInZeroState
yes (reset occurs at beginning of block)
*** Depth
no change in pass but in DAGCircuit where this is calculated
*** FixedPoint
no
*** Size
no change in pass but in DAGCircuit where this is calculated
*** Optimize1qGatesDecomposition
not required
*** CXCancellation
not required
*** ContainsInstruction
no

I'll handle all the trivial passes in a PR that I'll post tomorrow.
Just a note: BarrierBeforeFinalMeasure doesn't need to recurse in, because any measurements in a control-flow block can't be final measurements by the original definition.

I found some more transpiler passes while trying to update the preset pass managers, so I've added them to the list.


spurious(?) traceback on import of folder as new project

Description
What steps will reproduce the problem?

Try to import a folder with many sub-folders, many non-python-files, as project, total size 1.3G including mercurial repository data

What is the expected output? What do you see instead?
Folder imported as project (hey, it was the first thing I tried in this respect) - or a message what failed. However... things still seem to work.
Please provide any additional information below
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/plugins/projects.py", line 148, in
lambda v: self.editor.setup_open_files())
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/plugins/editor.py", line 2662, in setup_open_files
self.close_all_files()
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/plugins/editor.py", line 1974, in close_all_files
self.editorstacks[0].close_all_files()
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/widgets/editor.py", line 1408, in close_all_files
while self.close_file():
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/widgets/editor.py", line 1370, in close_file
self.remove_from_data(index)
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/widgets/editor.py", line 1163, in remove_from_data
self.update_fileswitcher_dlg()
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/widgets/editor.py", line 822, in update_fileswitcher_dlg
self.fileswitcher_dlg.setup()
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/widgets/fileswitcher.py", line 757, in setup
current_path = self.current_path
File "/home/ingo/anaconda3/lib/python3.6/site-packages/spyder/widgets/fileswitcher.py", line 346, in current_path
return self.paths_by_widget[self.get_widget()]
KeyError: None
Version and main components

Spyder Version: 3.2.3
Python Version: 3.6.2
Qt Versions: 5.6.2, PyQt5 5.6 on Linux

Dependencies
pyflakes >=0.6.0 :  1.5.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.12.1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.5 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
psutil >=0.3     :  5.2.2 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.26.1 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  1.7.2 (OK)

I think this is fixed in our latest release (3.2.6). Please update and try again.

Looks like a direct duplicate of #5317 , which was fixed in 3.2.4. You can update with conda update spyder. Therefore, this will be closed. If updating doesn't fix it, then please comment and re-open this, describing in detail the circumstances in which the error occurred, and post the information listed in relevant subsection of the Calling for Help section as a comment to this issue, and we'll try to help if we can.


fix getPhotos params on RNTester XHR example.

Summary

Fixes redscreen on RNTester's XHR page. CameraRoll getPhotos was missing params.
ss: https://i.imgur.com/JLThyrF.png
Changelog

[iOS] [Fixed] - RNTester XHR Example crash
Test Plan

Run RN tester

this also fixes the iOS snapshots (yet again)

@hramos, I noticed you are trying to update the screenshots- I have also done so on this PR & is passing.

Great, I’ll merge this once I’m back at my computer. Thank you!
Sent with GitHawk

Sent with GitHawk


feat(parent-gate): move parent gate check to profile

About the changes

Move parent gate up a level and check before profile page is opened instead of checking for individual buttons in profile.

4.5.0


Adding I2C LCD Interface

Squash commits into 1.

Also, update branch.

1 commit please!

Closing stale PR


Fixes Cmake error "file called with network path DESTINATION"

This PR fixes install step failure:
...
-- Installing: /Install/armv7a/swift-corelibs-foundation/lib/swift/CoreFoundation/ForSwiftFoundationOnly.h
-- Installing: /Install/armv7a/swift-corelibs-foundation/lib/swift/CoreFoundation/module.map
-- Installing: /Install/armv7a/swift-corelibs-foundation/lib/swift/CFURLSessionInterface
-- Installing: /Install/armv7a/swift-corelibs-foundation/lib/swift/CFURLSessionInterface/CFURLSessionInterface.h
-- Installing: /Install/armv7a/swift-corelibs-foundation/lib/swift/CFURLSessionInterface/module.map
-- Installing: /Install/armv7a/swift-corelibs-foundation/usr/lib/libCoreFoundation.a
-- Installing: /Install/armv7a/swift-corelibs-foundation/usr/lib/libCFURLSessionInterface.a
CMake Error at CoreFoundation/cmake_install.cmake:73 (file):
  file called with network path DESTINATION.  This does not make sense when
  using DESTDIR.  Specify local absolute path or remove DESTDIR environment
  variable.

  DESTINATION=

  //System/Library/Frameworks
Call Stack (most recent call first):
  cmake_install.cmake:74 (include)

FAILED: CMakeFiles/install.util
cd /Build/armv7a/swift-corelibs-foundation && /Volumes/Data/Developer/Brew/Cellar/cmake/3.14.5/bin/cmake -P cmake_install.cmake
ninja: build stopped: subcommand failed.

Here is a contents of file /Build/CoreFoundation/cmake_install.cmake
...
if("x${CMAKE_INSTALL_COMPONENT}x" STREQUAL "xUnspecifiedx" OR NOT CMAKE_INSTALL_COMPONENT)
  list(APPEND CMAKE_ABSOLUTE_DESTINATION_FILES
   "//System/Library/Frameworks/CFURLSessionInterface.framework")
  if(CMAKE_WARN_ON_ABSOLUTE_INSTALL_DESTINATION)
    message(WARNING "ABSOLUTE path INSTALL DESTINATION : ${CMAKE_ABSOLUTE_DESTINATION_FILES}")
  endif()
  if(CMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION)
    message(FATAL_ERROR "ABSOLUTE path INSTALL DESTINATION forbidden (by caller): ${CMAKE_ABSOLUTE_DESTINATION_FILES}")
  endif()
file(INSTALL DESTINATION "//System/Library/Frameworks" TYPE DIRECTORY FILES "/ToolChain/Build/armv7a/swift-corelibs-foundation/CFURLSessionInterface.framework" USE_SOURCE_PERMISSIONS REGEX "/privateheaders$" EXCLUDE)
endif()

As you can see there is a double slash // in install destination. This cause CMake error. So, we need to avoid such case by performing RegEx replace when CMAKE_INSTALL_PREFIX set to /. Usually CMAKE_INSTALL_PREFIX set to / when whole installation relocated with DESTDIR option.

@swift-ci please test

@swift-ci test linux

I believe we do something similar in libdispatch and XCTest

Seems like we already can merge this PR. Should we?

Please wait for the android build to get fixed first.  See #2379


Change the json-subschema dependency to track master.

The maintainer of json-subschema plans on keeping master working.
Once there is a released version of json-subschema we will switch over to using it

Great!


Heat not dissipating when no fuel is present

Is this really a bug? I always thought this was an intended feature. I use (or exploit, I guess) it all the time because its difficult to keep the high level (HEC-247) reactors always filled with fuel because of the low quantities of isotopes obtained from breeding.

Ah, you know what, you're right - I must have just got confused with the 1.11.2 version, where heat doesn't affect the power output anymore :P


Fix Windows MSI installer (does not contain Qt DLLs)

Due to windeployqt breaking, i recently temporarily disabled it. We must enable it back in order to regain functional a functional MSI installer on Windows.
I think the problem is at least related to https://github.com/microsoft/vcpkg/issues/17840 (hopefully only that).

Fixed in PR #386


Update easv6-eadsv6-series.md

Fix the first Header to include "(Preview)"

@iamwilliew

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


feat: login with Nextjs and NextUI

Issue #32
Implement a Login frontend UI using React, Nextjs, and NextUI. :octocat:

Star this repo : https://github.com/DeepanshuGoel1122/CodeEasy
and follow him: https://github.com/DeepanshuGoel1122
let's build connection stronger


How can I load data from a data file just like http://projector.tensorflow.org/ does when using Tensorboard embedding projector

At http://projector.tensorflow.org/  we can choose a data file from our own computer by the Load data button(see the red rectangle below) and visualize the high-dimensional data

But when I tried to using Tensorboard embedding on my own computer (follow the instruction at https://www.tensorflow.org/get_started/embedding_viz and start a server on localhost:6006 by command tensorboard --logdir=LOG_DIR )
I just find the Load data button doesn't exist (see below)

So I want to ask when I run Tensorboard on localhost, how can I enable the load data button like http://projector.tensorflow.org/ does, thus I can visualize the high-dimensional data by uploading my file rather than writing code ?
thanks a lot :)

@dandelionmane @jart can one of you comment?

I'm going to mark this as a feature request and contributions welcome, and pingign @dsmilkov in case he wants to comment.

ok, thx anyway :)

Today I found this:
https://github.com/tensorflow/tensorflow/commit/8c8ac705ec4cbae71b56fa37990e26890b576a77?diff=split
from
tensorflow/tensorboard/components/vz_projector/vz-projector-data-panel.html
#demo-data-buttons-container {
display: none;
}

and
tensorflow/tensorboard/components/vz_projector/vz-projector-data-panel.ts
 if (this.projector.servingMode === 'demo') {
       (this.$$('#demo-data-buttons-container') as HTMLElement).style.display = 'block';
       // Fill out the projector config.
      ...

we can know only when the projector.servingMode is 'demo', the upload button can be displayed
but I don't know how to set the projector.servingMode into 'demo' mode
so I just modified
#demo-data-buttons-container {
display: none;
}

into
#demo-data-buttons-container {
display: block;
}

and it works!

However, can anyone tell me how to set the projector.servingMode into 'demo' mode?

This issue has been migrated to https://github.com/tensorflow/tensorboard/issues/94.


Use MuxUpload id instead if the input URL when looking up or writing …

…state in the SDK
Keep MuxUpload id immutable
Avoid duplicating the id across MuxUpload and UploadInfo
Use XCTUnwrap to read persistence entries in tests
Add a no throw check when writing persistence entries in tests
Use XCTUnwrap when reading all
Expose init method internally to rest of SDK module for testing
Attempt to add an upload dedupe test
Use XCTUnwrap for constructing test URLs
Expose UploadManager init to rest of module for testing
Use the public init

Dupe of PR https://github.com/muxinc/swift-upload-sdk/pull/31

LGTM?


Asynchronous load event

As a developer, I want a data layer event that is fired when all the data has been added to the data layer, including the asynchronously loaded one, so that I can take action when all the data finished loading.
The challenge is to know when all data has finished loading and has been added to the data layer. This means that the data layer must know when all the asynchronous scripts completed their task. Therefore, a pattern is needed for async data loaders to indicate that they are still loading, and to notify when they completed, which is usually done with a Promise pattern. The data layer can then wait for the JavaScript load event, at which point all promises must be registered, and then wait for all the registered promises to resolve (or to time out), so that it can then trigger its own load adobeDataLayer:load event. And if no promises have been registered, then the data layer adobeDataLayer:load event can happen right after the javascript load event.
Some ideas of how this could work:

There could be a dedicated registerLoader method to register the functions that load asynchronous data, and like promises, when they are done, they should call the resolve method. The benefit of this syntax is that it doesn't reply on the Promise object and would therefore also work in IE:

adobeDataLayer.push(function (dl) {
    dl.registerLoader(function (resolve) {
        jQuery.getJSON("test.json", function (data) {
            dl.push(data);
            resolve();
        });
    });
});

Returning a promise in the function that is being pushed to the data layer queue:

adobeDataLayer.push(function (dl) {
    return new Promise(resolve => {
        jQuery.getJSON("test.json", data => {
            dl.push(data);
            resolve();
        });
    });
});

Directly pushing a promise to the data layer queue:

adobeDataLayer.push(new Promise(resolve => {
    jQuery.getJSON("test.json", data => {
        adobeDataLayer.push(data);
        resolve();
    });
});

Another question is whether we could wait less long than for the javascript load event, and still be sure that all javascript loaders could have a chance to register their promises. The issue with the load event is that it will wait for all resourced to be fully loaded, including images, which isn't necessary in our case: we only need to wait for the scripts.
Instead, the data layer could only wait for the DOMContentLoaded event, because <script> and <script src="..."> block the DOMContentLoaded event. But then we need a way for async and defer scripts that don't block the DOMContentLoaded event to indicate that the data layer adobeDataLayer:load  event should wait on them as well.
This could be done with a custom data attribute that can be added to the scripts that are loaded asynchronously. When the DOMContentLoaded event happens, the data layer could then search if there are such script elements, and wait for them to have loaded, and then only wait for all promises to have completed:
<script src="..." defer data-layer-loader></script>

IMHO the application should be responsible to fire such an event. E.g. in AEM the cmp:loaded event is fired when the page and the Core components are stored in the data layer.
In case there is some asynchronous processing (e.g. retrieving data on a server), the application knows best when all Promises have completed and can fire such an event.
We may want to have a convention and call this event e.g. adobeDataLayer:loaded.

Closing for now. Please reopen if needed.


Fix scroll issue

Remove maxWidth, maxHeight parameter
Introduce new overflow-x and overflow-y modes

Fix https://github.com/uwdata/voyager2/issues/112

vl-plot-group width is still changing on my screen

vl-plot width changes too, and vl-plot gets a scroll class when the scroll bar appears


use local repo instead of pacman -U

Redesign the internal design to use a local repo instead of using pacman -Ucalls.
Advantage might include:

faster solving
some dependency situation would be better handled
simplification of the code, especially when handling split packages.

Cons:

A lightly more complicate initial setup (might be an advantage to keep off the complete newbies that do not want to read anything).

See also #364 where this has been briefly discussed. This can be a nice workaround for handling mismatching data error.

I am interested in contributing on this feature. I think using a local repo is a very good idea. What can I do to help?

Hi,
This is a rather big change. I don't plan to work on it in the near feature as I want to stabilize current code instead.
I believe most of the split package code, and the cache code that I implemented over the year would become unnecessary, or at least greatly reduced. I guess I'd throw away the whole MakePkgs() function and rebuild from the ground up. Should obviously done in a new branch, cannot be done step by step in master.

If you or someone else wants to implement this, I highly recommend to use pacutils (in particular pacconf) to work with the pacman configuration. Without it, you'd have to rely on fragile adhoc filters and make explicit assumptions where repos are configured (i.e., no Include support), amongst other issues. It's been in the community repository for a while.
Re split packages, you can indeed throw out any custom code that handles that, since pacman takes care of it. That said, there's other drawbacks:

Decide how to upgrade the local repo. With pacconf a "partial" -Syu, i.e. a full upgrade on the local repo only, can be done easily by dynamically generating the required pacman configuration.
Checksum mismatches on rebuilding packages. Most of them can be avoided by having a second CacheDir that points to the local repo, but a "garbage" collection for -Sc (which searches for packages with the same name in cache folders that are -not- the local repository) may be useful. Again, pacutils makes latter task trivial.
Stupid users who misuse the replaces field in their PKGBUILDs. The best I've come up with is manually parse the database, mangle the results with grep and paste, and specify it to pacman's --ignore option. Yeah.
The requirement for the exact package name as required by repo-add, i.e., makepkg --packagelist isn't sufficient. You might think it is, but packages may have the same name but a different archive extension. Simple approach is to use some intermediary directory to point PKGDEST to (as makepkg has all required information), get the package names, and move them back into place. As a side-effect, if a package is rebuilt the old build can be kept via mv --backup.
Instead of the above, you can use some automatic repo generation tool like repose. These tools are inherently more complex and prone to breakage.
Repos must be generated with LANG=C, or they will break if pkgname contains unicode characters.

All in all, even if you get some other benefits like pkgfile support, the amount of bugs and quirks makes it a pain to implement. Feel free to look at https://github.com/AladW/aurutils/blob/master/bin/aurbuild if still interested (ignoring the gpg and chroot stuff, which I doubt is interesting to support).

Thanks a lot for your detailed input, much appreciated.

These tools are inherently more complex and prone to breakage.

Just to be sure, do you refer to "automatic repo generation tools" here (fe. repose)? I'd have thought these tools would actually provide a more robust implementation.
From what I read above, this feature requires a near complete redesign of the core code - at which point I wonder if it really worth the effort. I actually don't have the time to do this, but this might be implemented on the longer term.

Just to be sure, do you refer to "automatic repo generation tools" here (fe. repose)? I'd have thought these tools would actually provide a more robust implementation.

Yeah, they do cover more ground. But when something goes wrong, it's more involved to debug them, e.g. you're expected to not only submit backtraces but also a full copy of the local repository. Though some of them like repoctl wrap repo-add rather than use a custom implementation.

This isn't worth the effort, especially since using a local repo pretty much doesn't solve any issue in the single machine scenario that pacaur is designed for, but brings a whole set of drawbacks requiring workarounds. Closing.


Native-239: store pois offline

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword NATIVE.

:tada:

Looking good! But only really testable with UI in a separate PR, right?
Yes, i will open a new PR after merging this one.


package com.doublesymmetry.trackplayer does not exist, cannot find symbol new TrackPlayer()

Describe the Bug
I'm trying to install the sound library, and when I try to run the command "yarn android," a console error occurs. I'm trying to review old issues, but I haven't had any luck finding information that helps me solve the problem.
Steps To Reproduce
I only install the library and when try to run yarn android, The console return:
error: package com.doublesymmetry.trackplayer does not exist import com.doublesymmetry.trackplayer.TrackPlayer;
error: cannot find symbol new TrackPlayer(),

Environment Info:
System:
OS: macOS 13.3.1
CPU: (10) arm64 Apple M1 Pro
Memory: 54.41 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 16.0.0 - ~/.nvm/versions/node/v16.0.0/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 7.10.0 - ~/.nvm/versions/node/v16.0.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.11.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.2 AI-222.4459.24.2221.9971841
Xcode: 14.3/14E222b - /usr/bin/xcodebuild
Languages:
Java: <IP_ADDRESS> - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: ^0.64.2 => 0.64.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
react-native-track-player: 3.2.0
Android studio simulator

This looks like an issue with your project, not this library. If you can create a repro in the example project via forking I'll reopen.


Additional Azure App Registration is required but not listed

On this page, we have some prerequisites listed including a requirement to have a specific Azure App ID be enabled in the tenant.
(This is under the section 'Configure your Azure AD tenant')
In the scenario where a customer wishes to install the Add-In, but does not bring their own data lake, the Add-In will deploy a 'managed' data lake instead. In this scenario, a customer would not have completed the steps described here:
https://docs.microsoft.com/en-us/dynamics365/fin-ops-core/dev-itpro/data-entities/configure-export-data-lake#createServicePrincipal
This causes add-in installation to fail because the service principle is still required but has not been configured. (A support ticket was required to determine the missing app registration as the cause.)
This page should be updated to add the App ID as a pre-requisite:
Application | App ID
Microsoft Dynamics ERP Microservices | 0cdb527f-a8d1-4bf8-9436-b352c68682b2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d45d1c62-6273-1eed-432e-0c2db98c4d95
Version Independent ID: 1c0777b6-6c96-f02f-a2c3-73332ad456bc
Content: Configuration for Finance insights - Finance | Dynamics 365
Content Source: articles/finance/finance-insights/configure-for-fin-insites.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @ShivamPandey-msft
Microsoft Alias: shpandey

Bug 746872 has been logged to address this issue.

During the installation of the Finance Insights Add-In, the Managed Data Lake is automatically deployed along with any other required applications/microservices. There is no requirement to independently install any other application to run Finance Insights. The anomaly experienced in this situation was not because a step was missed in the setup process.


Site down, again

Service not available
curl wttr.in/Nuremberg?format=3
curl: (52) Empty reply from server
Could you please check. Thanks in advance.

I would recommend you visit the URL in a web browser to see what the reason is before opening an issue. The reason I say that is because going to the URL will show you the exact reason they are offline. Usually when you are getting this message its because they are out of capacity and just need to wait for the next day for the limit to reset.
Right now on the page I am seeing
Sorry, we processed more than 1M requests today and we ran out of our datasource capacity.
We hope to solve the problem as soon as possible, so you can enjoy
your favourite weather service 24x365 even if it rains or snows.

Could you add a donation link? This project seems to be extremely popular, I don't see why you couldn't get enough for a higher tier backend

Yeah, the website's still totally down, with no kind of error whatsoever right now.

I would recommend you visit the URL in a web browser to see what the reason is before opening an issue. The reason I say that is because going to the URL will show you the exact reason they are offline. Usually when you are getting this message its because they are out of capacity and just need to wait for the next day for the limit to reset.
Right now on the page I am seeing
Sorry, we processed more than 1M requests today and we ran out of our datasource capacity.
We hope to solve the problem as soon as possible, so you can enjoy
your favourite weather service 24x365 even if it rains or snows.

as specified by OP, the response he got is that curl rejected the connection. This is happening now as well if you enter a destination that has not been visited before. It seems that the application caches popular places to prevent slowdowns, but new places seem to take way longer than expected and thus the application crashes.
And, yes, a donation link like @EternityForest mentioned would be actually a nice way to help this project.

Did anyone try self hosting this?
Or deploying your own instance on fly.io?

I wonder if it wouldn't make sense long term to move to a local client.
If the user's machine directly queried the NOAA API that doesn't need a key, only using the wttr.in servers as a fallback, you could probably remove the load from a lot of frequent users.
It's still really cool to have things accessible via curl, but people who use it often might like to switch to a proper client app that can use multiple backends.


Add profiling documentation

Description

Add documentation of how to perform profiling using Python profilers.

I just applied almost all suggestions. But all files in this directory are named uppercase. there is a plan to the lowercase the name of all?

They are not uppercase in master. =) Perhaps you can rebase to make things clearer? =)

done


Automate tests in pre-commit hook script.

Currently we dont have any scripts to check for linting/ formatting error in local. I propose we should add a script to extract certain steps/command directly from .github/workflow  and execute them before committing. This will eliminate extra commit fixing the lint and format. This will also ensure each commit is independent and does not give any error. We can further expand it to run the tests before any push to ensure each commit is complete without any errors.
what we need:
A script to extract steps/commads ( probably python script  )
A script to execute the commands ( bash script ) .precommit script which can be symlink with git/hook/precommit
ln -s ../../.pre-commit .git/hooks/pre-commit . This will automatically trigger on commit.

hey @SarthakJain26 @shivam-Purohit can i help out in this one?

sure what you will need is

a script to extract the steps from the workflow ( python maybe)
we will need specific steps, to do that, we can use variable like hook : precommit
after that you can execute those steps in a different bash script
we can use symlink to link this script to github hook precommit which will run on each commit

you can ask if you have any more doubts

Sure @shivam-Purohit I'll be linking up a commit ref to this soon.


getWindowsSDK.ps1 requires modifications to execution policy to run, breaks previous behavior

The script will not run out-of-the-box. E.g. trying to install the new version of the opengl port produces the following output:
D:\Code\vcpkg>vcpkg.exe install opengl:x64-windows
-- CURRENT_INSTALLED_DIR=D:/Code/vcpkg/installed/x64-windows
-- DOWNLOADS=D:/Code/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=D:/Code/vcpkg/packages/opengl_x64-windows
-- CURRENT_BUILDTREES_DIR=D:/Code/vcpkg/buildtrees/opengl
-- CURRENT_PORT_DIR=D:/Code/vcpkg/ports/opengl/.
D:/Code/vcpkg/scripts/getWindowsSDK.ps1 : File D:\Code\vcpkg\scripts\getWindowsSDK.ps1 cannot be loaded because running
scripts is disabled on this system. For more information, see about_Execution_Policies at http://go.microsoft.com/fwli
nk/?LinkID=135170.
At line:1 char:1

D:/Code/vcpkg/scripts/getWindowsSDK.ps1

  + CategoryInfo          : SecurityError: (:) [], PSSecurityException
  + FullyQualifiedErrorId : UnauthorizedAccess

CMake Error at scripts/cmake/vcpkg_get_windows_sdk.cmake:8 (message):
Could not find Windows SDK
Call Stack (most recent call first):
ports/opengl/portfile.cmake:4 (vcpkg_get_windows_sdk)
scripts/ports.cmake:73 (include)
Error: Building package opengl:x64-windows failed with: BUILD_FAILED
Please ensure sure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: opengl:x64-windows
Vcpkg version: 0.0.74-b831a7d9ee5f97df506b14058d5fc970260d692a
Additionally, attach any relevant sections from the log files above.
Output from powershell also shows this:
PS D:\Code\vcpkg\scripts> .\getWindowsSDK.ps1
.\getWindowsSDK.ps1 : File D:\Code\vcpkg\scripts\getWindowsSDK.ps1 cannot be loaded because running scripts is disabled
on this system. For more information, see about_Execution_Policies at http://go.microsoft.com/fwlink/?LinkID=135170.
At line:1 char:1

.\getWindowsSDK.ps1

  + CategoryInfo          : SecurityError: (:) [], PSSecurityException
  + FullyQualifiedErrorId : UnauthorizedAccess

Sorry about that! Could you try out fa3f9dd? I've added -ExecutionPolicy Bypass which should fix your issue.

Works fine now, thank you!
D:\WorkingFolder\git\vcpkg>vcpkg version
Vcpkg package management program version 0.0.74-fa3f9dd9628ebafd3ba65fb3abde6c1d6f0448fc
See LICENSE.txt for license information.
D:\WorkingFolder\git\vcpkg>vcpkg install opengl:x64-windows
-- CURRENT_INSTALLED_DIR=D:/WorkingFolder/git/vcpkg/installed/x64-windows
-- DOWNLOADS=D:/WorkingFolder/git/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=D:/WorkingFolder/git/vcpkg/packages/opengl_x64-windows
-- CURRENT_BUILDTREES_DIR=D:/WorkingFolder/git/vcpkg/buildtrees/opengl
-- CURRENT_PORT_DIR=D:/WorkingFolder/git/vcpkg/ports/opengl/.
-- Performing post-build validation
-- Performing post-build validation done
Package opengl:x64-windows is installed


[BUG] Audio not working on streamed actor

Description:
The streamed actor's view, is missing all the sounds coming from Foundry, since update to version 10.290 (it was working fine with the previous V10 build).
The only way to have the sounds work again, is to activate the option "Show Full Sidebar [WARNING]"; when this is disabled (as it should be), no sounds work, playlist, ambient and interface, nothing at all.
Stream View 1.3.0
Foundry 10.290
DND 5E 2.0.3
Server Foundry Client/server on Windows 10
Client for streaming: OBS

Can't reproduce here. Browsers do have a restriction that the page must be interacted with before it's allowed to play audio - just clicking the page once is enough, can you try that? When using the OBS browser source I don't even need to do that, I am on Linux though so the browser source might behave differently on Windows.
Not sure how having the sidebar displayed would work around that though, shouldn't be able to circumvent that requirement.

I have just updated Foundry to 291.
Indeed like you said, now it starts with no sound, but if after the canvas is completely loaded, I use "interact" and I click on it, the sound starts streaming correctly.
I can't check if the same behavior was happening on 290 now, but I'm quite sure I've interacted with the canvas multiple times, and the sound never started.
So, hopefully now it's kinda fixed on its own?
I wish there was a way to avoid the need to interact though, it's dangerous, if I refresh for any reason the page, I might not notice that the sound is cut off.

Browsers have required this interaction for quite some time now, they do it to prevent horrible auto-play ads that became common a while ago. They're meant to like, learn sites you visit, but it's some opaque algorithm, and I don't think there's a toggle anywhere to explicitly allow a certain site.
You can try starting Chrome/OBS with the --autoplay-policy=no-user-gesture-required flag just for the Foundry session, which may or may not still exist or work.
In any case, this is not a Stream View issue, not even really a Foundry issue, so going to close this out here.


create a KORE version of the pattern matcher -- to be used in macro expansion

tiny is exactly this and can already be used.


IDC viewer starts up and fails with a file not found

We are seeing cases where the IDC viewer is launched from the portal, the Viewer starts up and immediately reports it cannot access the file. An example: https://(test-viewer-redacted)/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.163047965868107465659169009295180558950.
When looking at the proxy report, we see a request:
https://(test-proxy-redacted)/dicomWeb/studies/<IP_ADDRESS>.4.1.145<IP_ADDRESS>.163047965868107465659169009295180558950/series/undefined/metadata
Note the "undefined" series ID, which returns a 404. This glitch clears when the viewer is reloaded. It is also the case that this happens randomly, implying a race condition on startup where a request is issued before the series is identified, and subsequent requests do not have this problem.

Hi @wlongabaugh I tired to reproduce in all tier (produuction, testing and dev), but I could not. Probably some running conditions. I will keep you posted if I manage to reproduce it.

Yes, it appears to be an intermittent race condition, so probably depends on when things show up on startup. One possibility would be to perhaps check if a request is being issued containing "/series/undefined/" and raise an error.  Thanks.

One possibility would be to perhaps check if a request is being issued containing "/series/undefined/" and raise an error.

This makes a lot of sense. More generally, could have a regex to discard strings that are not conforming with the UID (DICOM UI VR) character repertoire.

that is a good idea, but it would be better i I manage to find the racing condition and make the viewer wait for the series metadata. I will try again to reproduce iit. As fiinal approach I will raise an error in case of "/series/undefined/"

@wlongabaugh I tried again to reproduce the issue by throttling both/either network and CPU, but I had no success.
In the code I see that there is a wait/async call, therefore it is supposed to wait for the study metadata before firing any frame request. I am wondering if it is the google server failing to provide the full metadata and some gets corrupted.
Anyway, in https://github.com/OHIF/Viewers/pull/2908 I have added a check on StudyInstanceUID, SeriesInstanceUID and SOPInstanceUID and an error will be raised if they are not conforming with the UID (DICOM UI VR) character repertoire as suggested by @fedorov.

It seems unlikely that the problem is on the Google side, since this problem is random, and typically (always?) works on a reload. Checks and logging statements to console around this issue are good to have. Thx.


Remove reference to Microsoft.AspNetCore.Mvc.Razor.Extensions

Between preview1 and preview2, the bitness of .NET Framework targeting projects changed from x86 to AnyCPU [1]. Consequently the app is compiled with AnyCPU, but the Scaffolding binary is x86. In both preview1 and preview2, Mvc attempts to load Scaffolding binaries because it appears to be a candidate containing controllers[2]. However, the change in bitness of the app results in an exception when attempting to Assembly.Load scaffolding's binary. Possible suggested fixes:

Make Scaffolding not appear to be a candidate for Mvc
Put the correct bitness exe in the output directory.

[1] - Between Preview1 and Preview2, Asp.Net Core no longer depends on Libuv, a native dependency. This causes the PlatformTarget to change. Here's the culprit: https://github.com/dotnet/sdk/blob/34454e6b651d4e1f0f1149c13d8c1ec115e111a1/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.RuntimeIdentifierInference.targets#L158-L167
[2] - This is because Scaffolding references Microsoft.AspNetCore.Mvc.Razor.Extensions, an Mvc specific library.

@Eilon this changes a package dependency for Scaffolding which is added as a regular (not a  developer dependency) to user's projects. However, it's not the common path through which users acquire this dependency.

Travis OSX keeps failing with no error message. AppV + Travis Ubuntu passed which means this is good vis-a-vis CI.