Change path structure

As discussed, this PR changes the path structure to:

entity/ID/associations for the heat map associations view
entity/ID/associations/bubbles for the bubbles view
entity/ID/associations/graph for the graph view
entity/ID for the profile pages

And in terms of search behaviour:

When a user searches for a disease or target and they click on a result, we take them to the disease or target heat map associations page
When a user searches for a drug and they click on a result, we take them to the drug profile page

@javfg can you please review this?


Improved Testing of the Rust SDK

There were some issues reported a while ago by @slundqui. We'll need to review these calculations to see if we can find the source of the issue. We should also take the time to improve the test coverage. The current testing methodology is pretty good, but we don't test with different configurations, which really limits the robustness of the testing.
We should differentially test every rust function against Solidity.

@ryangoree

Alternatively the FixedPoint library could be refactored to handle these cases internally.

I think this is the move. We should refactor fixedpoint to return results instead of panic https://github.com/delvtech/hyperdrive-rs/issues/99
This would clean up a lot of testing code.

https://github.com/delvtech/hyperdrive-rs/issues/127

Updating test chain to support fuzzing over multiple states: https://github.com/delvtech/hyperdrive-rs/issues/128

panic / result issue resolved as much as we want by https://github.com/delvtech/hyperdrive-rs/pull/113

closing in favor of new smaller issues


disable arm64 travis test

the comment being committed provides a description of what this is.

I guess this is fine although what, now we have to remember to turn this on "occasionally"?

I suppose so. I don't have access to an ARM machine to periodically run it locally.
But realize that this test is NOT testing anything at runtime (i.e. it is not like we are running molecule or other integration tests here). This only tests that the Operator SDK has an ARM build that can be used to BUILD the operator on an ARM machine. So, it is a nice test, but is no where near anything like a comprehensive test since it doesn't even run the operator to see that it works on ARM.


Multilingual support

This implements multilingual support in I think a better way, without some hacks that I made in the previous pull request.
I made some changes in the way you hardcoded some links, specially links to "/blog" and the link back to previous section, so they were easy to add the language prefix.
Also note that there's a bug in Hugo regarding RSSLinks:
I changed the RSSLink from {{ .Site.RSSLink }} to {{ .Site.RSSLink | relLangURL }} but Hugo doesn't take the language into consideration, it always gets the feed for the default language.
I hope I didn't miss anything and didn't introduce any bugs.

@pmviva @vickylai Is there anything I can do to help push this feature?

@pmviva Would you mind if I use your code to finish this feature?

@Hanzei I don't mind you use my code to finish the functionality. I haven't had much time lately to spend on this...


Week 6 Indi Review Ticket || Punnu

CROSSOVER GRADE: /5 by LINDA LIU for PUNARVASU SANGAM
GH Pages - Corrections
Practice Test 1 (47/50)
Practice Test 2 (45/50)
Study Plan
Do tests, do corrections, study over weekend for Week 6 practice tests
Study Reflection
I did pretty good on the tests (45/50 & 47/50). I studied a little, but not much, so I think these are good scores.
Checks:

[ ] Start review ticket with study plan and study reflection for week, due EOD Monday 4/18
[ ] Finals-Quiz1 score/50 and corrections
[ ] Finals-Quiz2 score/50 and corrections
[ ] Create Task code/runtime and 1 min video are reviewed by another person, you may request Teacher review as time permits
[ ] Review ticket with Crossover Score on Monday 4/25 in class

grading


Doesn't ensure that ufw stays enabled

Cookbook version
2.7.0
Chef-client version
14.10.9
Platform Details
Ubuntu 18.04
Scenario:
Chef should enable UFW if it is disabled.
Steps to Reproduce:
Recipe:
firewall 'default'

Steps:

# chef-client
# ufw disable
# chef-client

Expected Result:
# ufw status
Status: active

Actual Result:
# ufw status
Status: inactive

Hi there -- indeed, the default action for the firewall resource is :install, which doesn't ensure ufw is running. As I understand it, Ubuntu doesn't (or didn't when we wrote this) ship a service that we can reference using Chef's builtin service resource. I'd be glad to review/merge/release code that supported the functionality you're looking for, but it isn't there today.
If you'd like, we do ensure the service is started and running when using iptables on Ubuntu.

Thanks for the context!
Would something like what's in the :restart action not work?
ufw_enable! unless ufw_active?

I think it'd need to be in the install action, as well. I'd take a look at one of the other providers and see where it ensures :enabled, :running on the services they cover. And then do the same for ufw. Thanks!

Yeah, I was asking if you saw anything wrong with copying the logic from :restart into :install or if that seems like roughly the right direction.


if echo-server stopped

Once the echo-server stop, the rest of my js would not work
error in console
:6001/socket.io/socket.io.js net::ERR_CONNECTION_REFUSED
Uncaught ReferenceError: io is not defined
Anything advise to avoid this situation if echo-server not working, the rest of functionality should work.

Hey @xralphack in the laravel echo options you can set how many times to attempt reconnection. These will be based to the socket.io client Manager
new Echo({
    reconnectionAttempts: 1
});

Let me know if this solves the problem. Thanks

See https://github.com/laravel/docs/issues/3173

@tlaverdure the way you suggested can not work, because if the problem I met is if the echo-server stop my client side can not get socket.io.js. So everything after that will crash.
@barryvdh According to the reference
window.io = require('socket.io-client');
works fine, thanks ~


if a user has created an account at some point they should be able to log into that account later on.

closed with commit: 139b02e


win_secedit fix for correct match failures

Added an if statement that passes through the match variable if its already in SID format on the yaml

I just removed it completely from the _account_audit function.  This function tries to convert non SID account names to SID. If the yaml already has SIDs in place of names, we don't need to call this function at all.  I did the check before going into the function instead.


Unable to start influxdb on CentOS 6.5 system running 32bit

I followed web site instructions for installing influxdb.  Target system is running CentOS 6.4 32bit.
wget https://s3.amazonaws.com/influxdb/influxdb-latest-1.i686.rpm
sudo rpm -ivh influxdb-latest-1.i686.rpm
After this, I ran sudo /etc/init.d/influxdb start
This indicates OK.
After this, I ran sudo /etc/init.d/influxdb status
This indicates FAILED
Log file is empty.

Once this is merged:
https://github.com/influxdb/influxdb/pull/2114
can you re-test? I am pretty sure this will address the start-up issue on Centos. Please re-open if it does not.

I wasn't sure how to get the merged build.  The latest on your site for download is only for 64bit and I'm on a 32bit system. I tried modifying my init.sh script with the single line change but it still fails to start.  I removed the last part of the line for directing output to STDOUT and the error I see is:
nohup: failed to run command '/usr/bin/influxdb' : no such file or directory.
If I do a directory listing at /usr/bin/, I see this...
lrwxrwxrwx 1 root root 30 Mar 29 16:24 influxdb -> /opt/influxdb/current/influxdb

How do I reopen this?

Latest does not point to the 0.9 release, it only points to the 0.8 release. Check http://influxdb.com/download/ to get the latest 64-bit 0.9 release. As of this time, we are not building 32-bit releases, so you must build 32-bit yourself.

looks good.  fix verified.  thanks!


DDS: optimize loading of compressed images (3-5x)

Description
Comparing the time it takes to load DXT/BCn compressed DDS images via OIIO, I noticed that it's several times slower than in another codebase (Blender). So I started profiling, and fixing some low hanging fruit.

After decoding a BCn block (always 4x4 pixels), it was written into destination image using quite many branches in the innermost loop. Now it still takes care of not writing outside of a destination image that might not be multiple-of-4 in size, just with way fewer branches.
BCn decompression is multi-threaded via parallel_for_chunked, using at least 8 block rows per job (i.e. 32 pixel rows). This is similar to internal multi-threading done by EXR or TIF readers.
Avoid one case of std::vector resize (which clears memory) followed by immediate overwriting of that buffer with bytes read from the file. Switched to using unique_ptr for that array, similar to how other input plugins do it.

Performance data: I'm timing how long it takes to do iinfo --hash on 24 DDS files, each 4096x4096 in size. Quite a lot of time there is taken by just the SHA hash calculation which is not related to loading, so also have timing info for just DDSInput::read_native_scanline where all the actual DDS loading/decoding happens.
Timings on PC (Windows 10, VS2022 Release build), AMD Ryzen 5950X.

BC1: total 3.68s -> 2.76s, read_native_scanline 1.54s -> 0.59s
BC3: total 3.74s -> 2.84s, read_native_scanline 1.83s -> 0.66s
BC4: total 1.26s -> 0.82s, read_native_scanline 0.74s -> 0.24s
BC5: total 2.29s -> 1.57s, read_native_scanline 1.31s -> 0.46s
BC6: total 7.50s -> 4.30s, read_native_scanline 4.67s -> 1.60s
BC7: total 6.18s -> 3.09s, read_native_scanline 4.34s -> 0.84s

Possible future optimization: implement DDSInput::read_native_scanlines, that could avoid one extra temporary memory buffer copy. This extra buffer clear & eventual copy from it into final user destination pixels is non-trivial cost from profiling. But it's also quite involved to handle all the possible edge cases (e.g. user requests scanlines not on 4-pixel row boundaries); the code would have to do similar juggling as EXR reader does to handle "not on chunk boundaries" reads. It could potentially also interplay with DDS cubemap/volume texture reading ("tiled") code paths, for which there is no test coverage at all right now. Maybe for some other day.
Tests
Locally for me passes the extended DDS test suite from #3581. The code changes are purely an optimization, no behavior changes.
Checklist:

[x] I have read the contribution guidelines.
[ ] If this is more extensive than a small change to existing code, I
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
[ ] I have updated the documentation, if applicable.
[x] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[x] My code follows the prevailing code style of this project.

Huh, the two CI failures are the most curious. I don't yet quite see how they would be related to the single .cpp source file change here.
The Ubuntu bleeding edge gcc12 C++20 py3.10 OCIO/libtiff/exr-master boost1.74 avx2 one fails linking lib/libOpenImageIO.so.2.5.0 with an error coming from libtiff (?):
/usr/bin/ld: /home/runner/work/oiio/oiio/ext/dist/lib/libtiff.a(tif_unix.c.o): warning: relocation against `stderr@@GLIBC_2.2.5' in read-only section `.text'
/usr/bin/ld: /home/runner/work/oiio/oiio/ext/dist/lib/libtiff.a(tif_unix.c.o): relocation R_X86_64_PC32 against symbol `stderr@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC

The failure on windows-2019 VS2019 is where unit_timer tests fail:
141/157 Test #144: unit_timer ..............................***Failed    2.90 sec
Timer begin/end cost is 2.13647e+07 /sec
Out of 10000000 queries, 7785692 had no time
Longest was 0.0007168 s.

 It is not important.
Not sure what happened in the "bleeding edge" test so I'm triggering it to re-run. Sometimes there are spurious failures because of failure for the runners to configure properly or they have a bad package installed or fail to install a dependency. The environments on GHA aren't super locked down and the fact that some deps are installed on the fly means all sorts of rare failures can happen. I just rerun and hope for the best.

Ah looks like the timer test has passed on a rerun. But the bleeding edge linker failure has not; however I see it's also happening on CI runs on other branches here in OIIO.

The bleeding edge test error appears related to libtiff -- which we build from source at the tip of its master for this test, as we do for several other dependencies. That's why it's bleeding edge. Stuff breaks there any time somebody checks a bug into one of those packages. Sometimes we're even the ones to alert them to their mistake! But anyway, it seems unrelated to your change.

Aside for @aras-p to know next time this comes up: a good way to time how long it takes to do a full read with minimal conversions and no SHA-1 overhead is
time oiiotool --native -i:now=1 file.exr

The now=1 modifier causes the input to be read in full rather than going through the ImageCache, and all at once. And the --native keeps it in the data type of the file itself if at all possible (versus the oiiotool default of tending to convert everything to float upon input so that image processing operations are done at full speed and precision).


92 option to download an generate image

In Edit mode :-

In SugarCubes mode :-

@LovedeepSingh19 this looks good. Please add it on the logs page as well.

Logs download button added


Feature/code refactoring

Thank you, refactoring has been long time on the list (and I think there's still plenty of it left).


fixes #637: add remove_storage helper

Fixes: #637
Added remove_storage helper along with following tasks:

[x] Test unit for remove_storage
[x] Function Docstring for easy usage

Now, method of deleting the storage records:
 client.remove_storage({'keys': ["entry 1", "entry 3"]})

Successful deletion returns

{ "result":"success"}

@amanagr review requested


Changing customStyleMap doesn’t trigger re-render until contentState is changed

Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
After customStyleMap is changed, nothing happens until contentState is changed.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem..
Check it out here: https://jsfiddle.net/m6z0xn4r/125/
What is the expected behavior?
#52 suggests that this exact problem has been cleared up. Regression?? Or am I not understanding how to do the thing?
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
Latest, macOS, seems like all browsers. Dunno about previous versions.

I don't mean to be annoying, but this is blocking me at work. I have tried to find a workaround but have come up short. Any thoughts about alternative solutions would be appreciated, as would some indication of the timeline for this bugfix.

i am also struggling with this.  thanks :-)

I ended up just having to trick draftjs into thrashing the editor dom. I put this in my componentWillReceiveProps method and implemented _shouldJiggle to check the props that would change the style.
    if (this._shouldJiggle(nextProps)) {
      const contentState = editorState.getCurrentContent()
      const blockMap = contentState.getBlockMap()

      const indented = blockMap.map(blk =>
        blk.set('depth', blk.getDepth() + 1))
      const outdented = indented.map(blk =>
        blk.set('depth', blk.getDepth() - 1))
      const outdentedContentState = contentState.set('blockMap', outdented)
      editorState = EditorState.set(editorState, {
        currentContent: outdentedContentState,
      })
    }

wait, what?  why does that help?  shouldn't it hold that outdentedContentState === contentState?
anyway, glad to hear you've found something, i'll look into it.  thanks!

The two objects have the same contents after this transformation but because draft-js is built on immutable objects they are actually not ===. Therefore, I would be careful to allow this to fire only when needed since it makes a lot of copies and that's never good for performance.

oh i see, thanks again.
(i am touching draft through a haskell binding in which the comparison works on the values not pointers, or at least that's what i hope.  javascript confuses me..  :-)

Ok, I've found a couple of different ways of making the EditorState in the component props different so that the component should re-render.  And it does.  But the changes to the style map that I pass do not have any effect.  I can see it rerender and show the mutated text, but the styles do not change with the text.
@cbothner do you happen to have another jsfiddle that works as we want it to?

Fixed it!  The branch is git+https://github.com/liqula/draft-js.git#999-fix-leaf-shouldupdate.
PR coming up soon.

I patched the branch a little more, and now it actually does fix the problem.  The PR may take a few days, though, please up-vote this if you want to make me go faster!

Ok, i was too optimistic up there, and then moved on to other business.  Sorry!
@slavikhard would you be willing to make it a PR yourself?  I forgot the context and what's missing.  If you need me to get it done I'll see what I can do.

Using Draft 0.10.5 it won't trigger a re-render even if contentState is changed. It seems now a block needs to be changed in order for styleMap to take effect for that single block. https://jsfiddle.net/mrxL6kq3/21/

as i said, it's all paged out of my brain currently, but this sounds like draft-js is just broken for the sake of performance?  i hope i'm wrong, though.  facebook usually does a really good job with react stuff.
anybody from draft-js dev?

In the earlier issue where this was mentioned, #52 Isaac had commented:

You can define a new customStyleMap to pass in as the prop, though that won't currently trigger a re-render of the entire editor if the ContentState hasn't changed along with it.
What we could do is make customStyleMap an immutable Map (which we probably should have done anyway), then allow a full re-render if it changes so that the newly defined styles can be picked up. That way, when you want to load your fonts, once they are available you could create a new customStyleMap and pass it through.

It looks like the actual issue was about a different problem which was resolved, but nobody made the change to trigger a re-render on changes to the customStyleMap that I know of. So someone could still submit a PR for that, sounds reasonable to me.
Changing the customStyleMap is not a common use case for us at Facebook, so we have not run into this problem, hence the current behavior. Would be great to get it fixed though! :)

thanks @flarnie, this is very helpful!  :-)
unfortunately, this issue is deep down my list at the moment.
@slavikhard as you seem to be interested in this, is there anything that's missing from https://github.com/facebook/draft-js/compare/master...liqula:999-fix-leaf-shouldupdate that you would need from me in order to be able to make a PR?
Here's the relevant commits.  You probably want to drop 8c16719ca5a7e2559bad548eece2e1e00e7032f2 to make it easier to read / rebase.
git log -r 7b1752581876a5061f738bce29e87bede516c498..HEAD

I'll keep reading this, but I won't be able to do much more than comment.  Good luck!  (-:


[PECO-728] Add OAuth support

PECO-728 Add OAuth support
Related to databricks/databricks-sql-python#15

[ ] Implement OAuth authentication method
[ ] Add tests
[ ] Configure a dedicated client app for Nodejs (instead of using PySQL's one)

Codecov Report
Patch and project coverage have no change.

Comparison is base (39ba279) 96.16% compared to head (26f2ffe) 96.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   96.16%   96.16%
=======================================
  Files          51       51
  Lines         809      809
  Branches      131      131
=======================================
  Hits          778      778
  Misses          9        9
  Partials       22       22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.04 :warning:

Comparison is base (39ba279) 96.16% compared to head (f96e636) 96.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   96.16%   96.13%   -0.04%
==========================================
  Files          51       50       -1
  Lines         809      802       -7
  Branches      131      131
==========================================
- Hits          778      771       -7
  Misses          9        9
  Partials       22       22

Impacted Files
Coverage Δ

lib/index.ts
100.00% <ø> (ø)

lib/DBSQLClient.ts
96.87% <100.00%> (-0.10%)
:arrow_down:

lib/connection/auth/PlainHttpAuthentication.ts
85.71% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Patch and project coverage have no change.

Comparison is base (0a2bdb4) 96.28% compared to head (da3e2e5) 96.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   96.28%   96.28%
=======================================
  Files          50       50
  Lines         808      808
  Branches      134      134
=======================================
  Hits          778      778
  Misses          9        9
  Partials       21       21

Impacted Files
Coverage Δ

lib/DBSQLClient.ts
96.87% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Patch coverage: 88.88% and project coverage change: -1.14 :warning:

Comparison is base (0a2bdb4) 96.28% compared to head (bf1639c) 95.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   96.28%   95.15%   -1.14%
==========================================
  Files          50       54       +4
  Lines         808      949     +141
  Branches      134      159      +25
==========================================
+ Hits          778      903     +125
- Misses          9       21      +12
- Partials       21       25       +4

Impacted Files
Coverage Δ

lib/DBSQLClient.ts
90.14% <50.00%> (-6.74%)
:arrow_down:

...ib/connection/auth/DatabricksOAuth/OAuthManager.ts
74.35% <74.35%> (ø)

...nnection/auth/DatabricksOAuth/AuthorizationCode.ts
98.48% <98.48%> (ø)

lib/connection/auth/DatabricksOAuth/OAuthToken.ts
100.00% <100.00%> (ø)

lib/connection/auth/DatabricksOAuth/index.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Patch coverage: 92.36% and project coverage change: -0.61 :warning:

Comparison is base (0a2bdb4) 96.28% compared to head (b894a0b) 95.67%.

:exclamation: Current head b894a0b differs from pull request most recent head 3fe269c. Consider uploading reports for the commit 3fe269c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   96.28%   95.67%   -0.61%
==========================================
  Files          50       54       +4
  Lines         808      949     +141
  Branches      134      159      +25
==========================================
+ Hits          778      908     +130
- Misses          9       18       +9
- Partials       21       23       +2

Impacted Files
Coverage Δ

...ib/connection/auth/DatabricksOAuth/OAuthManager.ts
74.35% <74.35%> (ø)

...nnection/auth/DatabricksOAuth/AuthorizationCode.ts
98.48% <98.48%> (ø)

lib/DBSQLClient.ts
97.18% <100.00%> (+0.30%)
:arrow_up:

lib/connection/auth/DatabricksOAuth/OAuthToken.ts
100.00% <100.00%> (ø)

lib/connection/auth/DatabricksOAuth/index.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Patch coverage: 95.91% and project coverage change: -0.07 :warning:

Comparison is base (0a2bdb4) 96.28% compared to head (2edbb66) 96.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   96.28%   96.21%   -0.07%
==========================================
  Files          50       54       +4
  Lines         808      952     +144
  Branches      134      160      +26
==========================================
+ Hits          778      916     +138
- Misses          9       10       +1
- Partials       21       26       +5

Impacted Files
Coverage Δ

...ib/connection/auth/DatabricksOAuth/OAuthManager.ts
89.74% <89.74%> (ø)

...nnection/auth/DatabricksOAuth/AuthorizationCode.ts
97.10% <97.10%> (ø)

lib/DBSQLClient.ts
97.18% <100.00%> (+0.30%)
:arrow_up:

lib/connection/auth/DatabricksOAuth/OAuthToken.ts
100.00% <100.00%> (ø)

lib/connection/auth/DatabricksOAuth/index.ts
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


CDAP-13274 Emit FLL from Spanner source and sinks

Emit FLL from Spanner source and sink

Source:

Sink (Operations screenshot)

@albertshau The operation name in the second screenshot for source and sink are not consistent. The source and sink have the same full descriptive name in the plugin json. Although the source plugin which gets created when pipeline is created from Wrangler does not have full name and just have 'Spanner' as a name. Do you know where it might be coming from?

The first part is the stage name in the pipeline I believe


Personal information warning feedback copy change

https://www.agileplannerapp.com/boards/105200/cards/5814
Addresses line 26 of the spreadsheet of copy changes for that ticket.
Part of a group of 4 pull requests for the same content:

https://github.com/alphagov/spotlight/pull/880
https://github.com/alphagov/feedback/pull/144
https://github.com/alphagov/performanceplatform-selfserve/pull/1
https://github.com/alphagov/static/pull/517

Thanks for this @camilleldn


Context flavour does not respect adjusted return types of ctx.reply

Feature request
If I adjust the return type of ctx.reply using a different plugin, such as the hydrate plugin, I would like the type of ctx.replyWithEmoji to adjust accordingly. This makes it necessary to use a transformative context flavour, rather than an additive one.

This might not be possible because TS does not allow to further transform function signatures which have been created by transformative context flavours, i.e. via intersection.

It's technically doable. The recently released parse-mode is capable of working with hydrate with the sole exception of replyWithFmt.  On the other hand, if I wanted replyWithFmt to have some success at the expense of the other functions, I could swap the order of intersection elements in HydrateFlavor. Further details are at https://github.com/grammyjs/emoji/pull/9#issuecomment-1083364176.
It's.. not a great solution. Perhaps there is a way to modify the function signatures for hydrate without intersections?

Could you support #9 be on par with parse-mode?


Scale testing for Kubearmor Relay

Request
Short Description
We need to perform scale testing for Kubearmor Relay to ensure that it can handle a high volume of traffic without degrading performance or crashing. The goal of this testing is to determine the maximum capacity of the system and identify any bottlenecks that need to be addressed.
Tasks

overload relay server

There are two points in our current scaling relay system that could potentially create problems:

Non-blocking code for pushing logs into the LogStructs channel can result in dropped logs.
This occurs when the code sends logs to the client without first checking if the channel is blocked. As a result, some logs may be dropped, and the client will not receive them.

Sending alerts/logs to the first connection that is free may deprive other clients of the same alerts/logs.
This occurs when the code sends alerts/logs to the first free connection that it finds. As a result, other clients may not receive the same alerts/logs, even if they are relevant to them.

Current Design
Currently, for every Kubearmor instance, we create 10 concurrent connections, and each connection runs 3 goroutines for WatchLogs, WatchAlert, and WatchMsg. This means that for a 100-node cluster, we have 3000 goroutines running.
Proposed Design
To optimize the connections and goroutines, we can decrease the number of goroutines running and connect to the Kubearmor relay server first. When we send a request to the server, we can get the clientUuid, and with every new connection, we can send the clientUuid to one connection from each clientuid. This would reduce the number of redundant connections and improve performance

proposed design
https://gist.github.com/Shreyas220/60baea6c3f140fa6ffc1f55f647855e6


Add filter chain name match support to envoyfilter

Signed-off-by: zhongfox<EMAIL_ADDRESS>fix https://github.com/istio/istio/issues/31166
support filter chain name match

@zhongfox: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
6480001a0ee43141dc3f8cfe9510f50b018615f6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/ok-to-test

Can you add a release notes?

@zhongfox: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
6480001a0ee43141dc3f8cfe9510f50b018615f6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Can you please add a release note since this is a bug fix? We will not to backport this.

/retest

/retest

One warning, we don't name most filter chains

I put a hold to address release note, feel rfee to remove once its fixed

In response to a cherrypick label: #31168 failed to apply on top of branch "release-1.8":
Applying: Add filter chain name match support to envoyfilter (#31168)
Using index info to reconstruct a base tree...
M	pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch.go
M	pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch_test.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch_test.go
Auto-merging pilot/pkg/networking/core/v1alpha3/envoyfilter/listener_patch.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add filter chain name match support to envoyfilter (#31168)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #31230


sorasvl-server cannot be started

Hi!When I am running SVL Simulator without wise.svlsimulator.com, sorasvl-server does not start properly. I performed the following troubleshooting.
First query the currently running container via docker ps, sorasvl-server is not running.
After that, I created a new container with the image of sorasvl-server and entered the container and typed npm run start and got the following error:

How should I fix this error.
Thanks!

Hi. Sorry for the late response!
The error says the database hasn't started, maybe there is something wrong with the sorasvl-mongo.
I made a mistake earlier last week for the .env file of the server directory
It should be
MONGO_URL="mongodb://sorasvl-mongo:27017"
MONGO_DB_NAME="WISE"

instead pf localhost:37017 (for the MONGO_URL)

Hi, hope my answer above has solved your issue! I added some details to the readme to make the setup process clearer.
I already see others raising issues after being able to set up the project, therefore I am going to assume this issue no longer exists.
Please open a new issue for other problems! Again thank you for raising problems like this!


python312Packages.tololib: 1.1.0 -> 1.2.0

Diff: https://gitlab.com/MatthiasLohr/tololib/-/compare/refs/tags/v1.1.0...v1.2.0
Changelog: https://gitlab.com/MatthiasLohr/tololib/-/blob/v1.2.0/CHANGELOG.md

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 357802

x86_64-linux

:white_check_mark: 5 packages built:

home-assistant-component-tests.tolo
python311Packages.tololib
python311Packages.tololib.dist
python312Packages.tololib
python312Packages.tololib.dist


Need Help

Is anyone here who can help me in deployment of the whole module. If can please let me know I am eagerly waiting for the help.
Thank you

install python 3

See the docs and be more specific about your issue.


I get problem on ocppj validator when implement CSMS and Central System in one project/package even though with different port and handler

Hello,
I want run the Central System (ocpp1.6) and CSMS (copp2.0.1) in one project/package with different port and handler.
But I get problem on ocppj validator when implement CSMS and Central System in one project/package even though with different port and handler using this library:
https://github.com/lorenzodonini/ocpp-go/blob/7652fcf0b6dda9a83d847c506db467b8814cfa4f/ocppj/ocppj.go#L19
Called in ocpp2.0.1 :
https://github.com/lorenzodonini/ocpp-go/blob/7652fcf0b6dda9a83d847c506db467b8814cfa4f/ocpp2.0.1/types/types.go#L700
Called in ocpp1.6 :
https://github.com/lorenzodonini/ocpp-go/blob/7652fcf0b6dda9a83d847c506db467b8814cfa4f/ocpp1.6/types/types.go#L317
I found validator on the RegisterValidation will override with the last called(init) of ocpp1.6 or 2.0.1 (which one is called last will override)
For example on validator triggerMessageStatus  :
https://github.com/lorenzodonini/ocpp-go/blob/7652fcf0b6dda9a83d847c506db467b8814cfa4f/ocpp1.6/remotetrigger/trigger_message.go#L113
https://github.com/lorenzodonini/ocpp-go/blob/7652fcf0b6dda9a83d847c506db467b8814cfa4f/ocpp2.0.1/remotecontrol/trigger_message.go#L111
It will override with the last one.
Is it designed like that or can someone give me a hint/guide for this case, please.
cc: @lorenzodonini
Thx

Would close the issue for now. In case more instances of conflicting validation tags between v1.6 and v2.0.1 are found, I'm happy to re-open the issue or simply accept more MRs.


Logger Interface

Closes #174

@codegangsta totally disagree with you, log levels don't always goto separate files, and it provides no common interface across the entire application to do correct logging. I've not seen any logging package in any other language not have levels


Feature Request: Option to disable repl for a code block

mdbook has a feature to disable code run a block of rust code see here it would be great have a similar feature with mdbook-repl

What you mean is able to disable repl for a specific codeblock?
Actually you can do this in mdbook-repl, mdbook repl options.
I'm sorry that the docs are not clear enough.

Thanks @MR-Addict for the prompt reply. I missed that option.


chore(switch): remove unused mdcw-ripple dep

This dependency isn't being used and, with the next release, this package would break when doing SSR because this version of @material/ripple contains direct reference to HTMLElement.

Codecov Report

Merging #756 into rc0.11.0 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           rc0.11.0    #756   +/-   ##
========================================
  Coverage      94.6%   94.6%
========================================
  Files            73      73
  Lines          2928    2928
  Branches        448     448
========================================
  Hits           2770    2770
  Misses           56      56
  Partials        102     102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba47022...7575f6b. Read the comment docs.

Thanks @lucasecdb!!


Update Ring field  data type

OS

Ubuntu 20.04

Ros2 version

Galactic

Branch

Galactic

Information
As of now, the Ring field is defined in the point.h file as a uint8_t. While this doesn't cause any issues in the node so to speak, but it can cause issues down stream like decreasing the portability of the Ros2 Ouster driver along with the reusability of the users code for those who use ignition gazebo for simulation or also have other 3D Lidars like the Velodyne because they define their ring datatype as a uint16_t.
This can be solved by changing the ring data type from a std::uint8_t to a std::uint16_t. I implemented this fix on my local computer as well as tested it on an Ouster OS1 16 sensor to confirm it fixes the issue and it indeed does.
I can make a PR with this change so please let me know!

That sounds reasonable, but I think you should also file the ticket / PR with the ROS 1 drivers where this was taken from. We try to keep all of the "client" code the same between them so as Ouster makes updates we can ingest them easily here. If you can make them there, I'd be happy to pull them in here as well

ok cool. I'll fill out an issue/PR with the ros1 Ouster driver as well. I've only skimmed the ros1 code so I'll have to find where they define it at

There should be the exact same file elsewhere in the project

that is correct. I made the fix on the ros1 driver and created an issue for it!

Hi @SteveMacenski,
I wanted to give you an update on this issue. The maintainers of the Ros1 Repository just got back to me and it is considered a breaking change with the ros bags, So they said they will merge my PR in with the next Breaking change Update sometime this year.


make sure the benchmark scripts continue to work

When we change API I keep on forgetting about the benchmark scripts, include them in CI to make sure they continue to work

My only concern here is that the benchmarks are pretty slow -- should we have some option to run them with a very low iteration count for benchmarking (maybe pass an arg for number of rounds for the benchmark?)

they did finish in 1m 30s, while the regular tests with coverage enabled finished in between 2m 30s to 3m (see current master); they won't be the bottleneck :smiley:

OK dokey, we can merge this for now then and then in the future dampen the number of calls if we wish


Screenshots

System Information:

OS: Windows 7 ultimate X32 system
Discord Version: app-1.0.9010

Additional context
Add any other context about the problem here.
I closed discord and reopened it about 3 times now. Still not fixed

Redo the installer until it stops at "Killing Discord" then without closing the installer, restart your pc, then check if bd got installed

i had the same bug it seems Windows 7 related i just killed discord manualy using task manager and then close BD installer then it worked for me

This is a problem with one of our dependencies on Windows 7, we are looking into workarounds.

Duplicate of #287


Add "minimum viable message" base class for use in plugins

As discussed in #1096, when writing plugins, having the flexibility to implement messages differently than the pattern followed within ACA-Py can be really significant. This PR defines a minimized base message class that is unopinionated and trivial to extend.
This PR also addresses concerns around message serialization in anticipation of changes coming with DIDComm v2 by defining serialize and deserialize methods that specify the output/input format. At present, the AgentMessage class only implements DIDComm v1 message structure.

Codecov Report

Merging #1133 (a29eea9) into main (7541002) will increase coverage by 0.12%.
The diff coverage is 90.00%.

:exclamation: Current head a29eea9 differs from pull request most recent head 2139baa. Consider uploading reports for the commit 2139baa to get more accurate results

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
+ Coverage   98.70%   98.82%   +0.12%
==========================================
  Files         430      429       -1
  Lines       24195    24173      -22
==========================================
+ Hits        23881    23890       +9
+ Misses        314      283      -31

Small conflict created by another PR

Side note @ianco, integration tests failed the first time around. I should have noted the scenario (not sure if those logs are stored somewhere) but I believe it had "Issuer sends credential offer but then revokes." Not sure if that's something we should look into.


Guide update & release 0.4.0

Closes: #1030
Description
PRs that demand guide update, according to our tagging with label:"needs guide update":

[X] #1012 (307dd19, @adizere)
[x] #995 (@adizere)
[x] #971 (@romac)
[x] #985 (@romac)
[x] #1033 (@romac)
[ ] #924 (@ancazamfir)
[x] double-check this list against all PRs since last release (maybe we did not add the correct tag and we missed some) (@romac)

the guide build started to fail in CI since master merge 10af4ec8da73319262e4a76bc6a8d93f04b82541


CloudFront & S3 for static site hosting

cheaper (maybe?)
no use of lambda calls
no cold starts, website responds faster!
no 6mb size limit

dup of #62. I'd like to put CF infront of Lambda though so you can just utilize http caching for assets (with dynamic apps as well). Currently AWS isn't capable of a great fully static site since you need to manually invalidate files etc

Actuallllly I'll re-open since the S3 implementation would be different

awesome! thank you 👍

Would love to see that feature--ran into the size limit too a few days ago.

I'd love to see the following that I've done semi-manually in the past which also solves the issue with invalidations and a bunch of others:
up will deploy static files (e.g. from /public) to S3 with CloudFront in front and it will also deploy the dynamic application to lambda. Now here's the twist: I've always deployed my apps with a STATIC_FILES_VERSION env variable. So when I made a deployment I incremented the number and pushed the static files into S3 prefixed with the version. E.g. /14/css/style.css. After the static files have been deployed I deployed the application and updated the STATIC_FILES_VERSION env variable.
Clean semantic URL (query strings aren't CDN friendly anyway)
You get rollback capabilities for your static assets for free 😱

Instead of incrementing a number up could use the same identifier it already uses to identify different lambda deployments. It could fully transparently handle static files and rollbacks that way. In my pug templates I always have a helper for static files that basically concat STATIC_FILES_ENDPOINT and STATIC_FILES_VERSION. up could provide similar info to the application using env variable.s

an easier way would be to just hash the file contents and have that as a manifest

an easier way would be to just hash the file contents and have that as a manifest

@thewillhuang could you elaborate? What would the manifest contain exactly? How does this compare to what I suggested?
If you're using up pro you can likely implement what I've described above using predeploy which combines up env get, up env set and aws s3 cp --recursive public s3://your-bucket...

instead of hosting all of a static site in S3 ({"type":"static"}), how about just directory ({"type": "server", "static":{"dir":"public", "s3-properties":...} })?

@tj any news on this feature?

@edlefebvre to be honest I'm not making nearly enough to justify adding new features to Up unfortunately, it was worth a try but didn't really work out financially

Oh OK, sorry to hear that. Does it mean you will stop maintaining this repo entirely?

Nope! I'll still maintain it, maybe add the small feature here and there, but nothing huge.

OK, thank you for your answer :)

I've been successfully orchestrating static sites with https://github.com/aws-samples/aws-cdk-examples/tree/master/typescript/static-site/

Thank you @kaihendry, I will have a look.


Storybook fullscreen icon

Changes:
The "fullscreen" icon was removed from the toolbar in storybook. This simple config change adds it back. The icon will appear at the right side of the toolbar.

Sure why not


Crawler stops after redirect

I'm using simplecrawler for a project.
One of the websites to crawl have a redirect from the entry domain. Similar like when you type http://www.microsoft.com and you will get to http://www.microsoft.com/en-us/default.aspx.
In my opinion the redirected url should be added for crawling to the queue but the crawler stops, if the the entry domain is a redirect.
Here you can see my crawler code.
var theCrawler = simplecrawler.crawl('http://www.microsoft.com')
.on("fetchcomplete", function(queueItem, responseBuffer, response) {
  console.log('fetchcomplete: ' + queueItem.url);
})
.on("fetchredirect", function(queueItem, parsedURL, response) {
  console.log('fetchredirect: ' + queueItem.url);
})
.on("fetch404", function(queueItem, response) {
  console.log('fetch404: ' + queueItem.url);
})
.on("fetcherror", function(queueItem, response) {
  console.log('fetcherror: ' + queueItem.url);
})
.on("queueadd", function(queueItem, responseBuffer, response) {
  console.log('queueadd: ' + queueItem.url);
})
.on("discoverycomplete", function(queueItem, resources) {
  console.log('discoverycomplete: ' + queueItem.url);
})
.on("complete", function() {
  console.log("complete");
});

Is this a known problem, or am i doing something wrong?

If the entry domain redirects to a different domain, the crawler won't add that URL unless you've added the new domain to crawler.domainWhitelist or have permitted the crawler to continue on any domain (by default simplecrawler will only crawl the initial domain, with the exception of any www subdomain). Redirects between pages on the same domain should be added correctly. Your code seems to work as expected (but I suspect you were trying to crawl a different domain than microsoft.com).
If you want to allow initial redirects to a different domain, you could add some custom logic that is triggered on fetchredirect events. This example checks if this was the initial request, and in that case adds the hostname of the new URL to the crawler's domain whitelist.
crawler.on("fetchredirect", function (queueItem, parsedUrl, response) {
	var url = require("url");

	if (crawler.queue.length === 1) {
		crawler.domainWhitelist.push(url.parse(parsedUrl).hostname);
	}
})


Offline Support

Hi !
I discovered your app while I wanted to change from Pocket.
It is really nice, well down !!
However, the "offline mode" in pocket was a real good feature (even if it was not perfectly implemented).
What do you think about adding this feature in the mobile app?
I think it is useful when you are travelling and want to read your website you didn't have time during the day
I can help you to add this feature if needed (3 years old React Native developers at www.bam.tech)
Tell me!

I can help you to add this feature if needed (3 years old React Native developers at www.bam.tech)

Maybe try making a pull request anyway? I bet it'll be included if it works.


Are these links for China Mainland the same parts as in the list?

STS3215 Servo：https://item.taobao.com/item.htm?id=769061524145
Motor Control Board：https://item.taobao.com/item.htm?id=738955630278
I found these two part in chinese shop, but uncertainty about feasibility

They look correct - are you able to use the links on Ali provided in the readme?

They look correct - are you able to use the links on Ali provided in the readme?

I haven't tried it yet, because it says overseas buyers only. Maybe I can buy after I sign up a overseas buyer, but still too hassle.

That seems odd to me, I am checking with the company. You can also get in touch directly with Jenny Deng who is the sales rep that runs the Ali page<EMAIL_ADDRESS>I'd be interested to hear how you get on.

Feetech confirm that you can buy through the Taobao store for delivery to China.

Feetech confirm that you can buy through the Taobao store for delivery to China.

We have fully tested the devices in the link and confirmed that they are available, so you can now add them to the Sourcing Parts list!


SILMem2Reg: fix a crash which was uncovered by the change in SROA

It's basically fixing two over-conservative asserts.
rdar://problem/44143761

@swift-ci test

@swift-ci benchmark

Build comment file:
No performance and code size changes

How to read the data
The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false alarms. Unexpected regressions which are marked with '(?)' are probably noise. If you see regressions which you cannot explain you can try to run the benchmarks again. If regressions still show up, please consult with the performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB


Error while unzip .zip archive

Hi, i'm triyng to unzip a .zip archive.
I've installed Zip by cocoapods and used like this :
        do {
            try Zip.unzipFile(NSURL(fileURLWithPath: docPath), destination: NSURL(fileURLWithPath: unzipedDocPath), overwrite: true, password: nil, progress: { (progress) -> () in
                print(progress)
            }) // Unzip

        } catch let error as NSError {
            print("Error: \(error)")
        }

But I get this error ...
Thank by the advence

Thanks @JimmyYezeguelian. There's nothing obviously wrong that should produce the error. Any chance you can upload the zip file and paste the docPath and unzipedDocPath?

This is my filePath to unzip:

/var/mobile/Containers/Data/Application/AE2C328C-7DEC-4697-B3FB-6A03A662D57A/Downloads/politiquedecom.zip
And my folder to unzip:
/var/mobile/Containers/Data/Application/AE2C328C-7DEC-4697-B3FB-6A03A662D57A/Documents/politiquedecom

Then, i just don't know if the NSURL needed is like NSURL(string: ) or NSURL(fileURLWithPath: )

Finale Works !
That's was just my folder not exists ... Sorry about that !
Thanks

Hehe. No worries. 😄


Missing /var/log/clusterhc directory

Great job. However, there is one minor issue that can be easily fixed in code or by updating the "Installation" documentation:
[root@8569ff github.com]# /opt/go/bin/clusterhc
open /var/log/clusterhc/clusterhc.log: no such file or directory
[root@8569ff ~]# mkdir -v /var/log/clusterhc
mkdir: created directory ‘/var/log/clusterhc’
[root@8569ff ~]# /opt/go/bin/clusterhc
OK

Hello @DevSidious!
Thanks, fixed with https://github.com/leoleovich/clusterhc/commit/2a4dab794afa89f1c6f16f4dca01f1dfb1276734


Test failure for secret creation when backend fails.

This is to improve the test coverage for the controllers/secrets/externalsecret_controller.go as part of #103
This is as much as I can do for now. The only other parts in the code that is not covered by unit test is inside the Reconcile loop.

@allanmoso this PR qualifies for our Hacktoberfest campaign! See https://blog.container-solutions.com/container-solutions-does-hacktoberfest for more details.
If you'd like a t-shirt, could you e-mail at<EMAIL_ADDRESS>with you size and address?


Added build system example code.

Work in progress. Do not merge :smile:

Ok, this is ready to be merged.


prevent caching of pages (bsc#1044237)

after logout you can still access the application pages via
the browser's back button
disabling caching completely prevents this, as all pages contain
sensitive information
Signed-off-by: Maximilian Meister<EMAIL_ADDRESS>

 Bug 1044237 - Dashboard-session data accessible after logout

Isn't this going to affect page caching on the whole velum site? What are the side effects of that?

Isn't this going to affect page caching on the whole velum site? What are the side effects of that?

there should be no negative side-effects as we're constantly rendering the more dynamic content via javascript, and the rest of the pages render pretty quickly on the server side. i tried other cache storages as well (cache_store) but that doesn't fix the issue described in the bugreport.
we could cache some sites and others not, but i believe right now, all sites contain somewhat sensitive information

Agreed with @ereslibre. This is really not the way to go. Plus, these headers might be further modified if the customer sets NGinx and similar in front of it all 😁

while the browser what is doing is basically serving the same client-side code it had (since we invalidated the session on our side nothing can be really done -- interaction would just redirect you to the login page).

of course, but you can still see the input fields of the form and all other internal details of the cluster, do you know another way how we could prevent that?

of course, but you can still see the input fields of the form and all other internal details of the cluster, do you know another way how we could prevent that?

You can't, and my point being is: we shouldn't even care about it IMO. We are invalidating the session on our side, and that's all we can do. Whatever the browser does is up to it. It can even completely ignore Cache-Control or Pragma (it shouldn't, but nothing can prevent it from ignoring those headers).
For the input fields to be visible in this case, I'd have to login, fill them, logout, don't close the browser, don't close the tab, and in that same tab, click back. And of course, I would only be allowed to read the fields (no interaction allowed, cause server side will just reject any request).

@ereslibre thanks for the input, let's see what the outcome in the bug is, I am just a bit worried as it got flagged as P1

Page caching is normal. I don't see this as a security bug, as there is no viable attack vector here.

can we close this?

Closing since the bug report was resolved as invalid.


Create nav bar

Description
This implements a nav bar at the top of every page to allow easier navigation between pages and provide utility functionalities such as search bar.
Redirecting features has not been implemented yet due to a relevant react router code not implemented yet.

Related Issue

Solves #17

Type of change

[x] New feature (enhancement)

How Has This Been Tested?

[x] Automated testing
[x] Manual testing

Checklist:

[x] Does a similar (open or closed) pull request not already exist?
[x] Is the pull request head repository a fork repository?
[x] Is the pull request compare branch a development branch?
[ ] Is the code documented, particularly in hard-to-understand areas?
[x] Does the code build without new warnings?
[x] Has testing been performed that proves changes are effective and work?
[ ] Has a self- and/or peer-review of the code been performed?
[x] Have dependent changes been merged and published in downstream modules?
[x] Does all new and existing automated testing pass?
[x] Is the person responsible for the repository assigned to the pull request?
[x] Is the pull request linked to a project?
[x] Is the pull request linked to a milestone?

For more information, refer to the Contributing Guidelines document.

Its looking great! Please move the the styles into their own file so the concerns are separate :) Thanks!

The component style was refactored into a separate file (NavBar-styles.js) and those files were relocated to its own folder called NavBar/.


worldCopyJump makes the map "blink" on 1.0.0-beta2

I have noticed that when using the  ̀worldCopyJump` option with the 1.0.0-beta2 version, if the user drag the map and the overlays are copied to the new "map", all the tiles disappear and re-appear again which causes a kind of blinking effect.
Working demo (0.7.5): http://plnkr.co/edit/mWKc4M?p=preview
Demo with bug: http://plnkr.co/edit/mWKc4M?p=preview

I'm going to guess it's a side effect from #4039. We should see if this issue is reproducible after fixing the tile pruning logic.

It's now fine with the 1.0 version;)

Actually, I found out that the problem still exists with 1.0.3. It just doesn't happen when we are at zoom level 0. If you zoom and pan, then the map still blinks.
Sorry for closing...

I'd like to contribute on this issue if possible. Any hint from experienced contributors?

@nhducseuit You could try to see if a value of keepBuffer high enough could alleviate the symptoms of this.
I guess we could change the tile pruning algorithm (again) so that tiles are pruned only on map moveend and not on every move event.


ceph-docker: fix bootstrap directories permissions

Make bootstrap directories permissions work for both RedHat and Debian
os families by using a variable set with the ansible_os_family fact.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>Fix: #1338

still WIP, after discussing with @leseb this PR needs to be fixed


Allow Bazel users to include Abseil headers with angle brackets.

Because we use Abseil with both CMake and Bazel, and we sometimes use Abseil from /usr/include (or /usr/local/include or some other $PREFIX) we need to always include Abseil headers with either quotes (#include "absl/...") or angle brackets (#include <absl/...>).
We would prefer to include Abseil with angle brackets. In some platforms that allows us to treat warnings as errors (-Werror -Wall -W... or /WX /W3) even if the Abseil code is not "clean" for some warning. In general Abseil is very very clean, thanks! But there are a few exceptions, e.g. #582 .

@EricWF are you still interested in working on this?

We are also running into this problem. Other Google repositories such as gRPC and Protobuf supported bracketed includes, but abseil does not.


[,Here’s how To WatcH,] UFC 310: Pantoja vs Asakura Live Streams [PPV] and TV Channel

It’s time for the final UFC pay-per-view event of the year —UFC 310— headlined by a flyweight title fight between champion Alexandre Pantoja and challenger Kai Asakura. Happening in the UFC’s home, the Las Vegas T-Mobile Arena, tonight’s event also sees a stacked undercard with fights including Shavkat Rakhmonov vs. Ian Garry and Ciryl Gane vs. Alexander Volkov.
The Japanese star is coming over from RIZIN, and has a rare opportunity to win the world title on his debut, unlike any UFC fighter before him. While there have been other occasions when a fighter has fought for the belt on their debut, they have lost those efforts.
He will have to dethrone the impressive Alexandre Pantoja to do it, however, which is no easy task. The Brazilian has literally wiped out the flyweight division, to the point that they needed to look elsewhere for a challenger.
The UFC's final numbered event of the year comes from Las Vegas, and its headliner has come a long way since he first appeared on UFC fans' screens on the organization's The Ultimate Fighter reality show.
The main event of UFC 310 will see Alexandre Pantoja defend the UFC flyweight title against Kai Asakura. Shavkat Rakhmonov and Ian Machado Garry face off in the co-main event to determine the next contender for the UFC welterweight title.
Brazilian Alexandre Pantoja completed his UFC ascent when he defeated Brandon Moreno to capture the flyweight crown and the Cannibal has chewed up two opponents by unanimous decision since. He's hot favorite to devour a third straight defence today.
Kai Asakura also knows what it feels like to wear the gold. He's a two-time bantamweight champ of the Rizin Fighting Federation in his native Japan, vacating the strap to head to Dana White's camp. He has a huge following back home and would be an instant international star if he makes history this weekend with an unlikely victory.
It's another jam-packed card at the T-Mobile Arena, with Shavkat Rakhmonov against Ian Machado Garry set as the penultimate battle on the bill in a welterweight title eliminator.
However, it appears that much of the fanfare surrounding this weekend’s proceedings is to do with the co-main event. Ian Machado Garry has stepped up to challenge Shavkat Rakhmonov in a welterweight title eliminator that will see one man’s undefeated run come to an end after a collective 33 wins.
The prelims are headlined by two former UFC light heavyweight title contenders, Dominick Reyes and Anthony Smith. Reyes (13-4) controversially lost against Jon Jones in 2020 for gold. Including that fight, he has gone 1-4 in five contests, winning his first fight since 2019 in June.
Smith (38-20) lost against Jones in 2019 and has gone 6-6 since. "Lionheart" is 2-2 in his last four fights and looks to end 2024 on a 2-1 run.
Movsar Evloev and Aljamain Sterling compete in a potential featherweight contender fight. Evloev (18-0) has won all his octagon fights via decision. A former UFC bantamweight champion, Sterling (24-4) beat Calvin Kattar in his UFC featherweight debut.
Also on the card are favorites Vicente Luque (20-10-1) and Bryan Battle (11-2, 1 NC). After taking out Kevin Jouseet to extend his unbeaten streak to four fights, the latter cut a pro-wrestling-like promo.
Tensions seemed to boil over at weigh-ins as the former teammates almost came to blows and had to be dragged apart.


can only concatenate str (not "int") to str

Dear Alexandrovlab,
Good day! I have been trying to use the Sigprofiler extractor tool to generate plots for my De Novo data.
I was trying the tool out on the sample dataset (example.txt) and successfully got the outputs. When I was trying to use the extractor tool to generate plots, I encountered a problem where python gave the(can only concatenate str (not "int") to str) command. I was using the X_seqinfo.txt file since it was the only output file that contained any columns.
This is my code:
sig.sigProfilerExtractor(“matrix”,”results”,”/Users/shaoyizhang/Desktop/X_seqinfo.txt”,reference_genome=”GRCh37”,minimum_signatures=1,maximum_signatures=10,nmf_replicates=100,cpu=-1)
The real question here is: which file from the SigProfiler Matrix Generator should I use for the Extractor tool(I was trying to look for a file that has the same format as the 21BRCA.txt but haven't found one)? There is a lot of files and I am fairly new to python.
Thanks a lot for the support and help!
Shaoyi

Hi Shaoyi,
You need to a file as input from the output folder of SigProfilerMatrixGenerator. Such as output/SBS/21BRCA_vcf.SBS96.all
Thanks,
Mishu

Dear Mishu,
That totally solved my problem! Thanks a lot. I have another issue I want to address - When I run the extractor for my DBS.all outputs from MatrixGenerater, the extractor still gave me SBS outputs in the results file. Can you give some insights into what might have caused this issue?
Shaoyi

Hi @shaoyiZ ,
Sorry that I did not notice your last question and found it when you closed the ticket. I just tested the tool and found it is working correctly at my end. Here is the code I used:
Uploading public_test.zip…

Hi! Could you please

Hi, no problem at all!
It doesn't seem like I can open the code you shared with me. When I click on it, it just redirects me to this Github page again.
Sincerely,
Shaoyi

public_test.zip
@shaoyiZ I attached the zip file again.

Thanks a lot! I was replied in another thread that the current extractor version does not support DBS - it is labeled as SBS but the results are correct. Thanks for the code and the help provided!
Sincerely,
Shaoyi


Gradle threw an error while downloading artifacts from the network. Retrying to download...

Hi, I am new to flutter, learning and trying to get my first app to work. I'am trying to research some solution but isn't work.
plz help me. tks
Exception in thread "main" java.io.IOException: Unable to tunnel through proxy. Proxy returns "HTTP/1.1 403 Request blocked by Privoxy"
at sun.net.www.protocol.http.HttpURLConnection.doTunneling(HttpURLConnection.java:2152)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:183)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect0(HttpURLConnection.java:2739)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect(HttpURLConnection.java:2651)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1830)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
at org.gradle.wrapper.Download.downloadInternal(Download.java:58)
at org.gradle.wrapper.Download.download(Download.java:44)
at org.gradle.wrapper.Install$1.call(Install.java:61)
at org.gradle.wrapper.Install$1.call(Install.java:48)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Running Gradle task 'assembleDebug'...
[!] Gradle threw an error while downloading artifacts from the network. Retrying to download...
Exception in thread "main" java.io.IOException: Unable to tunnel through proxy. Proxy returns "HTTP/1.1 403 Request blocked by Privoxy"
at sun.net.www.protocol.http.HttpURLConnection.doTunneling(HttpURLConnection.java:2152)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:183)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect0(HttpURLConnection.java:2739)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect(HttpURLConnection.java:2651)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1830)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
at org.gradle.wrapper.Download.downloadInternal(Download.java:58)
at org.gradle.wrapper.Download.download(Download.java:44)
at org.gradle.wrapper.Install$1.call(Install.java:61)
at org.gradle.wrapper.Install$1.call(Install.java:48)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
[!] Gradle threw an error while downloading artifacts from the network. Retrying to download...
Exception: Gradle task assembleDebug failed with exit code 1

Hi @dat036,
Can you try this solution and see if it works for you ?
Thanks.

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

Hi, I am also new to flutter, I have same error on my first flutter projec. Please help me solve the error!
Exception in thread "main" java.io.IOException: Unable to tunnel through proxy. Proxy returns "HTTP/1.1 403 Request blocked by Privoxy"
at sun.net.www.protocol.http.HttpURLConnection.doTunneling(HttpURLConnection.java:2152)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:183)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect0(HttpURLConnection.java:2739)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect(HttpURLConnection.java:2651)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1830)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
at org.gradle.wrapper.Download.downloadInternal(Download.java:58)
at org.gradle.wrapper.Download.download(Download.java:44)
at org.gradle.wrapper.Install$1.call(Install.java:61)
at org.gradle.wrapper.Install$1.call(Install.java:48)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Running Gradle task 'assembleDebug'...
[!] Gradle threw an error while downloading artifacts from the network. Retrying to download...
Exception in thread "main" java.io.IOException: Unable to tunnel through proxy. Proxy returns "HTTP/1.1 403 Request blocked by Privoxy"
at sun.net.www.protocol.http.HttpURLConnection.doTunneling(HttpURLConnection.java:2152)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:183)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect0(HttpURLConnection.java:2739)
at sun.net.www.protocol.http.HttpURLConnection.followRedirect(HttpURLConnection.java:2651)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1830)
at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
at org.gradle.wrapper.Download.downloadInternal(Download.java:58)
at org.gradle.wrapper.Download.download(Download.java:44)
at org.gradle.wrapper.Install$1.call(Install.java:61)
at org.gradle.wrapper.Install$1.call(Install.java:48)
at org.gradle.wrapper.ExclusiveFileAccessManager.access(ExclusiveFileAccessManager.java:65)
at org.gradle.wrapper.Install.createDist(Install.java:48)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:128)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
[!] Gradle threw an error while downloading artifacts from the network. Retrying to download...
Exception: Gradle task assembleDebug failed with exit code 1

Same error here

Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Thank you

Hi @dat036,
Can you try this solution and see if it works for you ?
Thanks.
it's work for me. tks a lot guy

Hi @dat036,
Can you try this solution and see if it works for you ?
Thanks.

it's work for me. tks a lot

This worked for me, hope it helps.


Update README.md

Coverage remained the same at 97.196% when pulling a38930a65e835684022d8c4b67ecbe1b12e1a1e9 on andela-jkanyua-patch-1 into 74bdb82408db146d3dce3c3895b7533eef870962 on develop.


Added mock command module

Missing the currentAltitude field, and I believe the eulerAnglesOfCamera should be a dictionary rather than an array, and the same with eulerAnglesOfPlane and gpsCoordinates.


[Merged by Bors] - ci: Try older version of node 18

This is done in order to unblock CI. We need to research why on node>=18.14 we get segmention errors

bors r+

see: https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.14.0,

works on Node v18.6 on local machine

works on Node v18.6 on local machine

in my local machine it fails on 18.14


Is there any way to set distance limit for capturing point cloud ? (c++)

Hi,
Sorry to say that this is not an issue. I need some clarification since i am new to c++ and pointcloud.
I am trying to capture ply file from intelrealsense. But for my application i need to capture from 0 to 3 meters distance. I tried to set depth values above 3000 to  0 , but it is not working.
is there any possibility that we could only capture point cloud between certain range ?
Any other post processing methods ?
Thank you for your suggestions.
According to my research i found passthrough filter , would it work ?

PCL(Point Cloud Library) has a API named 'PassThrough Filter' can satisfy your need.

Thank you so much

An in-SDK way to do it would be to set the Depth Clamp max/min in advanced mode>depth table. The only example I can find for advanced mode is in Python (https://github.com/IntelRealSense/librealsense/blob/master/wrappers/python/examples/python-rs400-advanced-mode-example.py) but that should be fairly easy to translate to different languages.

Thank you so much but it works beautifully with PassThrough FIlter. I tested it


When store new file, if we have thumbnail, we change filename to thum…

…bnail for client side use
if we have thumbnail, we change filename to thumbnail for client side to display. This is the same behavior as index action in this controller
Please consider whether or not merge this.
I use vuejs as the front end data-driven app dev. When uploaded file, if this $file with thumb returned, client side will update view automatically with this returned data. Otherwise, no thumb image can be retrieved

Thanks for bringing this up, cnweibo.  I think this is a specific use case and not necessarily something needed for generic functionality.  My suggestion for your scenario would be to either:
1.Override the controller's store() function, i.e:
$file = parent::store();

if( $file->has_thumbnail ) {
  $publicResourceUrlSegments = explode('/', $file->public_resource_url);
  $publicResourceUrlSegments[count($publicResourceUrlSegments) - 1] = '_thumb_' .    $publicResourceUrlSegments[count($publicResourceUrlSegments) - 1];
  $file->filename = implode('/', $publicResourceUrlSegments);
} else {
  $file->filename = config('laradrop.default_thumbnail_url');
}
return $file;

2.Implement an event handler for FileWasUploaded() and modify $file there.
Let me know what you think.

@jasekz , thanks a lot for your great job, it saves me much time.
Both of your proposal is OK for me. Currently, i use laradrop as backend, and rewrite the frontend myself to fit my requirement.

Excellent.  Thanks for taking the time to bring these issues up, I appreciate it, @cnweibo


add weekly endpoint

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 96.875%

Files with Coverage Reduction
New Missed Lines
%

src/stock-time-series/StockTimeSeries.ts
1
97.44%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
169

Relevant Lines:
174

💛  - Coveralls


Problems with protected properties dependency injection

I updated from 5.8.11 to 5.9.3 and protected properties dependency injection stop working.
Any suggestions?

Same problem here. @ENikS Could you please explain why it is by design? I have no reasonable explanations on forcing people to use only public properties.

While building pipeline Unity creates this expression:
var existing = new SomeType
{
  Field1 = "xx",
  Property1 = "yy"
}

If fields or properties are protected it will not compile and will not create pipeline.
Up until last version Unity used reflection to set member values but now it uses expressions which make it faster but initialization of protected members impossible.

Hi, the reasoning behind the decision (to be faster) whilst sacrificing consumers class design choices doesn't really sit clearly with me. Great, you made it faster, at what cost though?
In our code shop we have design constraints on our classes to ensure these properties are not increasing our surface area. Now we cannot inject these dependencies and are forced to remain with an older (slower) but functional version.
Perhaps you could inspect the access modifier of the property and keep the performance benefits for public modifiers, whilst still retaining support for a reflection approach over protected modifiers?

Gregg,
The constraint is not based on my arbitrary decision. It was implemented because of technical requirement.
Unity 4 used reflection to get setter methods and called them directly to set property values. It worked with all properties. Although in all Unity documentation is said it works only with public properties, the constraint was not strictly enforced.
Unity 5 creates and compiles an expression tree like this:

var Instance = new SomeType(c.Resolve(x), c.Resolve(y) )

{

    Prop1 = c.Resolve(z)

}

Non accessible properties and fields would not compile. So, this is why the limitation has been enforced.

Having stumbled across this I have to agree with Gregg. It is unfortunate that you didn't read his post more carefully. It's great you found a new faster way to implement injection, but in many applications the field receiving the injected value actually needs to be private. So I would say you found a nifty new hammer, but not every problem is your kind of nail.

The beautiful thing about Unity is that you have a choice. Use whatever works for you and override whatever doesn’t.
The source is available for both implementations. You could even contribute an extension if you think it is that valuable

Can you please share how one would produce such an extension. Should this be the correct/only way forwards then I will take a closer look.

Yes, this is the only way.
I am working on a manual for creating extensions and etc. I will post a link when it is available.


chore: finish remaining simple null check typing fixes

ref https://github.com/amundsen-io/amundsen/issues/47
Summary of Changes
strictNullChecks 68 errors -> 34 errors (35 fixes, 1 regression).
This should be all the relatively trivial fixes. The remaining PRs will be a bit tricker, and will be grouped per-topic, rather than big mixes.
Tests
no tests modified
Documentation
n/a
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

@Golodhros can you please merge?  thanks for review!


move to ghcr registry

What this PR does / why we need it:
This PR will start using ghcr.io as the container registry. This will create the explorer and explorer-db container image.
Which issue(s) this PR fixes:

Fixes #348
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation, usage docs, etc.:

@vineeth2328 please look into this PR.

@vineeth2328 please look into this PR.

@ArchanaArige please add me to the reviewers list

Tested the PR with the new changes in the forked repo.
Steps:

Copied the release.yaml in the forked repo.
Created a new tag
Then the images(explorer + explorer-db) got created with the release tag and latest tag
Made some code changes and pushed to the main of same repo
The workflow didnt get trigger and tried running it manually
The observed result was "The job got skipped"
For the manual triggering, the images are not getting created with latest tag. Please check and confirm.

This is the expected behavior. The images will be created for release tags only. There is a check that looks for the tag and skips the workflow, if the tag is not present.

This is the expected behavior. The images will be created for release tags only. There is a check that looks for the tag and skips the workflow, if the tag is not present.

ok. Thanks a lot @adityajoshi12.


Column series

Adds a column series
I did try to make a bar series with an 'orient' property, but the resulting API and code was a mess!
Note, before this is merged we need to swap bar <=> column, although I think it would be easier to review this change before renaming.

Is there a use-case for rebinding the fc.svg.bar align properties?

Along one of the axes there might be a use-case, I've rebound and aliased simply as align, so for a bar series you can align the bars left, right or center. Might be of use to someone!

Could the g.each be removed?

Good call - I found that quite a few things could be simplified, including the removal of the transition.

I'm really confused about the orientation in this line, are the variables named appropriately?

That's a tricky one! It all depends on whether you consider the width and height of columns and bars to be transposed. Personally I'd still use the word 'width' to describe the 'thickness' of columns - i.e their size along the cross-axis.

I've taken another look and it looks good to me.
For the naming, a quick hunt around suggests people normally leave it at width so happy with that.
Were you going to add a comment or do you want to just merge?

I'll add a comment before merging, although there was one last thing to do ...
We have bar and column the wrong way round. So a rename is required (and a breaking change).

I was about to launch into a rename, but am having second thoughts. From looking around, it would appear that a great many people consider bar charts to be vertical.
A few options:

Go ahead with the bar <=> column rename, which will be a breaking change
Come up with a different name for the new series type, horizontalBar perhaps?
Merge the two into fc.series.bar adding an orient property. I like this as a concept, but it does require a bit of juggling with the x & y properties.

@chrisprice any thoughts?

I like 3 the most but do share your concerns about the complexity. Would it be possible to do both 2 & 3, where 3 is just an adapter?

I like 3 the most but do share your concerns about the complexity. Would it be possible to do both 2 & 3, where 3 is just an adapter?

Well (3) actually has a couple of sub-options:
3.1. When the orient property is flipped, x becomes y and vice-versa.
3.2. The series has properties of x, y, x0, y0, y1, x1 - and which are 'active' depends upon the orientation.
I think 3.2 could be the most elegant solution (and is no a breaking change :-) ). When switching from column to bar you will have to change your scales regardless, so it doesn't add much extra effort to flip the relevant accessors.
They should throw errors if an accessor is set that isn't relevant for a given orientation. Although this would only be possible at the point where the series is rendered.

What about x/y aliased as x1/y1 (in the existing fashion) and x0/y0? orient would then set these to appropriate defaults (e.g. 'horizontal' sets x0 = xScale.domain()[0], x1 = (d) -> d.date, y0 = y1 = (d) -> d.close) which you could then override.

@chrisprice - I've combined bar and column into a bar series with horizontal / vertical orientation. I think this works quite nicely (once I managed to wrap my head around which properties to transpose).

Looks good to me, just need to add some drop shadows and linear gradients... :wink:

just need to add some drop shadows and linear gradients...

I'll raise an issue for adding d3fc themes ...


Units of report definition

Is there a way to determine the units of a report definition?
root.solution.report_definitions.compute only returns the value.

TODO: US

The settings API will evolve such that all physical quantities will include dimensions metadata, as planned in Fluent. The PyFluent codebase already has the code to handle that metadata and reflect the correct units.

@seanpearsonuk  Can you give an update on this issue? It would be really helpful to have access to the units of report definitions for automated post processing in plot labels etc.

@benjamintraut targeted for Fluent 24Rx

[1177014]


Verification for changed e-mail addresses

Verifying a new e-mail address for an existing profile is a very different thing from verifying the initial e-mail when registering that account.

The first e-mail leaves the account inactive until verification, but new addresses require the account remain active
The first e-mail can be stored in the profile, but new addresses need to be stored separately and only assigned to the profile when the verification is complete

In addition, there are some general concerns:

These verifications need a way to cancel them, both from the profile edit page and from the email received by the account
Changes in e-mail need to handle the case where a previous e-mail change was already pending verification, cancelling the previous request if the e-mail is changed yet again.

Because of these stark differences with the existing verification link, this feature has to be considered out of scope and really quite different. It is a separate feature to be worked. It also adds enough requirements that I would suggest considering temporary removal of the e-mail field from the profile form, and only allowing the e-mail be change when the verification to do so safely can be implemented.

I agree with the idea of a temporary removal (or greying out or locking) of the e-mail field to protect integrity.
Following are email rules that we established (from UsernameEmailRUles1.8 document in Alfresco) that pertain here.  I believe that 3.7 to 3.9 address some of the concerns about cancelling, although the point of being able cancel/revoke email change requests from the profile page as well as the email received is new and valid.
3.1.	Each user account should have a separate and unique email address that they specify at the time of account creation.
3.2.	In the case that a user requests to create an account and an account already exists that uses that email address the user is informed that an account with that email address exists.  This message should provide links to retrieve forgotten username and password.
3.3.	Email addresses should be validated by an email being sent to the user and the user being required to click on a link in the email.  An account should not be created until the email address has been validated (Technically this may mean that there is an account that exists but is activated by the clicking).  A time limit should be set for a user to click on the link and validate the email.  This time limit should be adjustable by a HydroShare system administrator via a system administrator interface.  The initial value of this time limit should be 24 hours and conveyed to the user in the email and in the request account landing page.
3.4.	If the user does not validate the account within the time limit any temporary information retained in the system about creating their account should be deleted.
3.5.	If a user attempts to create an account with an email address for which a validation is pending the user should receive a message that indicates that creation of this account is pending validation of the email address.  This message should suggest the user look in their junk mail in case the validation email is there.  This message should provide a button for the validation email to be resent.
3.6.	A user may change their email address using their profile page.  If when changing an email address the user requests an email address that exists in the system generate a message that an account with that email address already exists.  This message should provide links to retrieve forgotten username and password.
3.7.	The request to change an email should generate validation emails sent to both the new and the old email address.
3.8.	The email change validation email sent to the new email address should include a link for the user to click on to validate the new email address.  Changes in the email address should only be enacted when this is clicked.  This validation should be active for the same time limit as validation of account creation email.
3.9.	The email change validation sent to the old email address should indicate that a user (probably you) have requested to change the email address for your HydroShare account to .  If this is correct no action is needed.  If this is incorrect (which may mean someone is tampering with the account without your permission) provide a link to click on and revoke the email change.  This link to revoke the email change is intended to reduce the chance that someone can hijack a HydroShare account and should never expire.  So while an email change in the profile is made as soon as the new email account is verified, information needs to be retained so that this may be rolled back if the link to revoke the change is ever clicked.

HydroShare Profile Issues in GitHub: #44, #46, #47, #48, #49, #68

Refer to #695 which supercedes this.  Closing.


Cannot install with pip because depends on package not hosted on PyPi

> pip install tensorwatch
Collecting tensorwatch
  Using cached tensorwatch-0.9.0.tar.gz (187 kB)
ERROR: Packages installed from PyPI cannot depend on packages which are not also hosted on PyPI.
tensorwatch depends on pydot<EMAIL_ADDRESS>
However, I can install tensorwatch version 0.8.10 without issue.  I believe the problem was introduced by https://github.com/microsoft/tensorwatch/commit/353567f2071b4c7a5fae5afebeea787523c59762
I'm running ubuntu 16 with pip 20.0.2.

I have the same issue.

Also with the same issue, I've installed pydot with the following

pip install<EMAIL_ADDRESS>

> pip install tensorwatch
Collecting tensorwatch
  Using cached tensorwatch-0.9.0.tar.gz (187 kB)
ERROR: Packages installed from PyPI cannot depend on packages which are not also hosted on PyPI.
tensorwatch depends on pydot<EMAIL_ADDRESS>
However, I can install tensorwatch version 0.8.10 without issue. I believe the problem was introduced by 353567f
I'm running ubuntu 16 with pip 20.0.2.

I installed it with source code

python setup.py build
python setup.py install

I experience the same issue.

Seems like @sytelus fixed it with https://github.com/microsoft/tensorwatch/commit/30f770cc97ae399ec4de222c64fb77958704241e.