Always get Layer 'XX' already exists, please choice other 'name' or reuse this layer

i have already set reuse,but it still happens when i run the code.why?plz help me! thanks a lot!!!!! i always get
:\nHint : Use different name for different 'Layer' (The name is used to control parameter sharing)" % name)
Exception: Layer 'model/input' already exists, please choice other 'name' or reuse this layer
Hint : Use different name for different 'Layer' (The name is used to control parameter sharing) i use tensorflow1.1.
so whats the paoblem?
import tensorflow as tf
import tensorlayer as tl
from tensorlayer.layers import set_keep
import numpy as np
import time

X_train,y_train,X_test,y_test = tl.files.load_cifar10_dataset()
X_val = X_train[45000:50000,]
y_val = y_train[45000:50000,]
X_train = X_train[:45000,]
y_train = y_train[:45000,]

def model(x,y_,is_train,reuse):
    tl.layers.set_name_reuse(reuse)
    W_init = tf.contrib.layers.xavier_initializer()
    W_init2 = tf.truncated_normal_initializer(stddev=0.04)
    b_init2 = tf.constant_initializer(value=0.1)
    with tf.variable_scope("model1", reuse=reuse):
        network = tl.layers.InputLayer(x,name='input')
        network = tl.layers.Conv2dLayer(network,
                        act = tf.nn.relu,
                        shape = [5, 5, 3, 192],  # 64 features for each 5x5x3 patch
                        strides=[1, 1, 1, 1],
                        padding='SAME',
                        W_init=W_init, b_init=None,
                        name ='cnn_layer1')     # output: (?, 32, 32, 64)
        network = tl.layers.BatchNormLayer(network,is_train,name='batch_1')
        network = tl.layers.PoolLayer(network,
                        ksize=[1, 3, 3, 1],
                        strides=[1, 2, 2, 1],
                        padding='SAME',
                        pool = tf.nn.max_pool,
                        name ='pool_layer1')   # output: (?, 16, 16, 64)

        network = tl.layers.DropoutLayer(network, keep=0.6, name='drop1')
        network = tl.layers.Conv2dLayer(network,
                        act = tf.nn.relu,
                        shape = [3, 3, 192, 192], # 64 features for each 5x5 patch
                        strides=[1, 1, 1, 1],
                        padding='SAME',
                        W_init=W_init, b_init=None,
                        name ='cnn_layer2')     # output: (?, 16, 16, 64)
        network = tl.layers.BatchNormLayer(network,is_train,name='batch_2')

        network = tl.layers.PoolLayer(network,
                        ksize=[1, 3, 3, 1],
                        strides=[1, 2, 2, 1],
                        padding='SAME',
                        pool = tf.nn.max_pool,
                        name ='pool_layer2')   # output: (?, 8, 8, 64)

        network = tl.layers.Conv2dLayer(network,
                        act = tf.nn.relu,
                        shape = [3, 3, 192, 96],  # 64 features for each 5x5x3 patch
                        strides=[1, 1, 1, 1],
                        padding='SAME',
                        W_init=W_init, b_init=None,
                        name ='cnn_layer3')

        network = tl.layers.BatchNormLayer(network,is_train,name='batch_3')

        network = tl.layers.PoolLayer(network,
                        ksize=[1, 3, 3, 1],
                        strides=[1, 2, 2, 1],
                        padding='SAME',
                        pool = tf.nn.max_pool,
                        name ='pool_layer3')

        network = tl.layers.Conv2dLayer(network,
                        act = tf.nn.relu,
                        shape = [3, 3, 96, 96],  # 64 features for each 5x5x3 patch
                        strides=[1, 1, 1, 1],
                        padding='SAME',
                        W_init=W_init, b_init=None,
                        name ='cnn_layer4')

        network = tl.layers.BatchNormLayer(network,is_train,name='batch_4')

        network = tl.layers.PoolLayer(network,
                        ksize=[1, 3, 3, 1],
                        strides=[1, 2, 2, 1],
                        padding='SAME',
                        pool = tf.nn.max_pool,
                        name ='pool_layer4')

        network = tl.layers.FlattenLayer(network, name='flatten_layer')
                                                                # output: (?, 4096)
        network = tl.layers.DenseLayer(network, n_units=1024,act = tf.nn.relu,
                                   W_init=W_init2, b_init=b_init2, name='relu1') # output: (?, 384)
        network = tl.layers.DenseLayer(network, n_units=382,
                            act = tf.nn.relu, W_init=W_init2, b_init=b_init2, name='relu2') # output: (?, 192)
        network = tl.layers.DenseLayer(network, n_units=10,
                            act = tf.identity,W_init=tf.truncated_normal_initializer(stddev=1/192.0),
                            name='output_layer')            # output: (?, 10)
        y = network.outputs

        cost = tl.cost.cross_entropy(y,y_,name='softmaxloss')
        L2 = tf.contrib.layers.l2_regularizer(0.004)(network.all_params[8]) + \
                    tf.contrib.layers.l2_regularizer(0.004)(network.all_params[10])
        loss = cost + L2
        correct_pred = tf.equal(tf.argmax(y,1),y_)
        acc = tf.reduce_mean(tf.cast(correct_pred,tf.float32))

        return network,loss,acc

tf.reset_default_graph()
sess = tf.InteractiveSession()
tl.layers.set_name_reuse(True)

x = tf.placeholder(tf.float32, shape=[None, 32, 32, 3], name='x')
y_ = tf.placeholder(tf.int64, shape=[None, ], name='y_')

network, cost, _ = model(x, y_,is_train=True,reuse=True)
_, cost_test, acc = model(x, y_, is_train=False,reuse=True)

n_epoch = 50
learning_rate = 0.0001
print_freq = 1
batch_size = 128

train_params = network.all_params
train_op = tf.train.AdamOptimizer(learning_rate, beta1=0.9, beta2=0.999,
    epsilon=1e-08, use_locking=False).minimize(cost, var_list=train_params)

tl.layers.initialize_global_variables(sess)

network.print_layers()
for epoch in range(n_epoch):
    start_time = time.time()
    for X_train_a, y_train_a in tl.iterate.minibatches(
                                X_train, y_train, batch_size, shuffle=True):
         sess.run(train_op, feed_dict={x: X_train_a, y_: y_train_a})
    if epoch + 1 == 1 or (epoch + 1) % print_freq == 0:
        print("Epoch %d of %d took %fs" % (epoch + 1, n_epoch, time.time() - start_time))
        train_loss, train_acc, n_batch = 0, 0, 0
        for X_train_a, y_train_a in tl.iterate.minibatches(
                                 X_train, y_train, batch_size, shuffle=True):
            err, ac = sess.run([cost_test, acc], feed_dict={x: X_train_a, y_: y_train_a})
            train_loss += err; train_acc += ac; n_batch += 1
        print("   train loss: %f" % (train_loss/ n_batch))
        print("   train acc: %f" % (train_acc/ n_batch))
        test_loss, test_acc, n_batch = 0, 0, 0
        for X_test_a, y_test_a in tl.iterate.minibatches(
                                    X_test, y_test, batch_size, shuffle=True):
            err, ac = sess.run([cost_test, acc], feed_dict={x: X_test_a, y_: y_test_a})
            test_loss += err; test_acc += ac; n_batch += 1
        print("   test loss: %f" % (test_loss/ n_batch))
        print("   test acc: %f" % (test_acc/ n_batch))
sess.close()

you need to change your code from:
network, cost, _ = model(x, y_,is_train=True,reuse=True)
_, cost_test, acc = model(x, y_, is_train=False,reuse=True)

to:
network, cost, _ = model(x, y_,is_train=True,reuse=False)
_, cost_test, acc = model(x, y_, is_train=False,reuse=True)

and from:
    with tf.variable_scope("model1", reuse=reuse):
        network = tl.layers.InputLayer(x,name='input')

to:
    with tf.variable_scope("model1", reuse=reuse):
        tl.layers.set_name_reuse(reuse)
        network = tl.layers.InputLayer(x,name='input')

please check: https://github.com/wagamamaz/tensorlayer-tricks

thanks for your concern.it seems that i can only run this for a single time ,in the next time i run the code,it get the same error.if i close my spyder and reopen it ,the code can be run. is it a bug?@zsdonghao

there is not a bug, you need to reuse your parameters if you want to use a model twice. please check the link i send you.

i m really sorry to disturb you,i just copy the file 'tutorial_cifar10.py' in your examples,the first time i run the code everything is ok,while the second gives an error just like i said.In the second time i just change the learning rate ,so if there is nothing wrong,does it means i have to reopen my spdyer another time if i  just want to change the params.It is so troublesome.
Then i find it worked  through changing the with tf.variable_scope("mode2", reuse=reuse),from model1 to model2 .
Just wonder anyother methods to solve this questions.thank you for responsing when i asked so stupid questions.I love tensorlayer. @zsdonghao

don't worry.
if you got error in second run, this mean you have not clear everything (variables, layer names etc) before your second one.
to remove layer names please use tl.layers.clear_layers_name() before the second run, if you got some expections about variable exists , you also need to clear the tensorflow variables.
however, if people want to run a script twice, people usually close the python process and run again.

Thanks for helping.Really appreciate


file compression removes last digit

Godot version:
Godot 3.0.3
OS/device including version:
ubuntu 18.04
Issue description:
using open_compressed cuts off the last character of files.
Steps to reproduce:
func _ready():
var f = File.new()
f.open_compressed('user://asdf.txt', f.WRITE, f.COMPRESSION_GZIP)
f.store_string('asdf')
f.close()
f.open_compressed('user://asdf.txt', f.READ, f.COMPRESSION_GZIP)
var text = f.get_as_text()
print(text) # prints 'asd' instead of 'asdf'

Minimal reproduction project:
See the code above

Interesting. That might explain why a 2.1 project I have tends to crash weirdly when exported as exe + zip instead of exe + pck (even though open_compressed isn't available to GDScript in 2.1, but I suspect the underlying functions to be the same when used internally). "Weirdly" meaning "as if some of the files were incomplete" in this case.


client_oid not received on the order feedback message

Hello, I success sending a new order with a client_oid in the message, but in the feedback message received just after, the client_oid is not present. The documentation says that we need to request the public feed in order to retrieve the order with the client_oid of our previous order message. It is the only way to make match our order sent with the one on GDAX ? Is there a way we can receive the client_oid on the feedback message of our order ? thank you to answer.

It is — the message you get in response to your request will contain the actual order id, which is not user-supplied.


fix(sort): add aria-sort to host when sorted

Apply the aria-sort label to the sort header rather than include an additional visually hidden div to describe the sort.
Screenreaders will read this and append the phrase "Sorted ascending" or "Sorted descending" after reading the header content. Similar to what we had previously.
Up for debate: this property should only be applied to elements with role columnheader or rowheader. Should we only apply this property in those cases? If so, do we add in the sortDescriptionLabel to be displayed in the cases where the roles are not defined?
https://www.w3.org/TR/wai-aria/states_and_properties#aria-sort

Looks like some lint errors

Fixed lint issues

Marking as a major release due to the removal of some HTML elements

@andrewseguin please rebase

Thanks, rebased


Add a service to get the set of members for a PDSE

This would probably use DESERV GET_ALL: https://www.ibm.com/docs/en/zos/3.1.0?topic=bpam-deservfunctionget-all

done. see mlsx and underlying code


Add hervormd lyceum zuid

This PR adds hlz.nl, which is used for both the website and e-mailaccounts (see page footer). https://hlz.nl

@emielderckx Pull request merged. Thank you!


How to extract all exons of Ortholog Genes (OGs) from chromosome-level assemblies?

I've got Single_Copy_Orthologue_Sequences from 3 annotated genomes(YYL, LBL, HTL, protein sequences) by using OrthoFinder2. I try to extract OGs from these three and another three genomes by AliBaSeq, but most of the extracted genes are patchy from exon to exon in all 6 genomes. So I chose 1 OG (comprised of 14 exons, 5085aa, 15255nt, attatched below) to modifiy the parameters by got no improvement. I've tried not adding "--is", using "PAM30" matrix, changing "--hit-ovlp 40" or "ctg-ovlp 40".
In the tblastn results, all six genome got hit in all 13 exons excepted the shortest one--exon2 (36aa).
How to get all exons of baits genes from 1 hit contig/scaffold?
`ls assemblies/*.fasta | rev | cut -f1 -d/ | rev > list_of_files_to_seach_against.txt
../blast_wrapper_matrix-PAM30.sh ./bait4039/ ./assemblies/ 1e-10 tblastn 30 n ./list_of_files_to_seach_against.txt
mkdir blast_results
mv *.blast blast_results
python ../alibaseqPy3.py -x a -f M -b ./blast_results/ -t ./assemblies/ -e 1e-10 --amalgamate-hits --ac aa-tdna -o alibaseq_out-no-stitcher --log-header -s no-stitcher-log`
6genomes_extracted.pdf
9094.4039.split.fas.zip

LBL_ref_genome.fasta.blast_default.log
YYL_ref_genome.fasta.blast_default.log

Try dropping the evalue for tblastn down to 1e-5 to get the short exon. Not sure about the difference in performance in for the different genomes. What do you think @AlexKnyshov?

Try upping the evalue for tblastn to 1e-5 to get the short exon. Not sure about the difference in performance for the different genomes. What do you think @AlexKnyshov?

The tblastn results are the same after increasing evalue from  "1e-10" to "1e-5".  Oops.

I see. Perhaps try hmmr? AliBaSeq won't be able to find anything that isn't already found in the input files. You could also try a more closely related query sequence.
Is the patchiness of the results mostly based on these very short exons?

I see. Perhaps try hmmr? AliBaSeq won't be able to find anything that isn't already found in the input files. You could also try a more closely related query sequence.
Is the patchiness of the results mostly based on these very short exons?

Not always short exons, see 6genomes_extracted.pdf attached above.
The first 3 genomes (YYL, LBL, HTL) are the reference genomes of the baits.

I'm sorry I got back to you so late.

So, as to why in general they are patchy despite blast hits are there - judging by log of LBL, the 11 HSPs found were split into 2 pseudo contigs, instead of being kept as 1, and then only one out of two (the longest) was selected for output. The reason for split is probably the overlap. See rows 3 and 4 of your LBL table, row 3 ends at 2207AA, but row 4 starts at 2179AA, same part of query matched to two different places. Looking at your image, several extracted sequences end or start btw exons 4 and 5, intron there is super short. This consistent spurious match is a problem of TBLASTN. Two ways around this problem - enlarge --hit-ovlp parameter to the amount greater than the overlap (in this case seems like 100 would work), but at the expense you will get this extra ~100bp likely intronic or duplicated sequence, and will have to trim it out later, possibly using exonerate, alignment trimmer or other tool. Or otherwise, use a different aligner, perhaps one that has more sophisticated intron models, or in general with less false positive matches.

the other problem (not all exons detected) - if HSP is absent from alibaseq's table, it can't do anything about it. I blasted your LBL seq, here's the pic

I bet this softmasking of query that you can see as low letters is what causing the issue. When continuous proteins are aligned it's no biggie, but when alignment of a given exon is performed and low complexity region occupies half of it, the HSP is probably not reported. You can probably turn it off in the blast parameters, but again at the expense of some potential spurious matches, see here for example https://www.biostars.org/p/210569/

if you have highly contiguous assemblies, all your gene exons should be on one contig, so enabling or disabling --is or tweaking --ctg-ovlp will have no impact. In such cases common suspects for no reporting are indeed low scores or sequence overlaps.

Let me know if you have any other issues or need more feedback

Thanks for your detailed explanations. I've tried to set "--hit-ovlp 100"， the results were much better except one genome which had a 420aa query-overlap in tblastn result). "--hit-ovlp 10000" gave the same result, with 2 HSPs caused by 420aa overlap.
I also tried to use CDS baits, all exons were extracted!
Lastly, I'm no sure the using of "alignment coordinate" parameter (--ac). If using tblastn, then "--ac aa-tdna"; if using blastn, then "--ac dna-dna"?

You can try hacking this in alibaseq by using --ac dna-dna and see if it helps for that one case you mentioned
No, the results are the same as "--ac aa-tdna".

Actually, this kind of blast overlap seems quite enormous. Perhaps there's some repetitive region in the query for that locus?

Yes, the annotation of this species (GENOME_PRJCA005355) has only the first 8 exons of all 14 exons. But the alibaseq output the exon9-exon14.

Yeah! "-m b-e-i --hit-ovlp 100" seems the best option for protein baits when BLAST to chromosome-level assemblies. Thanks you so much! @AlexKnyshov


bikeshed: rename client.call() into something else?

because of Function.prototype.call it's kinda confusing. maybe run or exec?
client.run('myMethod', 'world');
client.exec('myMethod', 'world');

I completely "call" with this! :smile:

I should also mention that in an earlier version we tried using Proxy to allow method calls the look like:
client.myMethod('world');

IMO this is a little misleading as myMethod doesn't actually exist and also adds additional complexity for 'sugar' sake.

Another option:
client.method('myMethod', 'world');

As this maps well to the 'contract' format ({ methods: {...}, events: {...} })

method sounds good to me, better than other options. :+1:


Evaluation mode throw error

I try to run using Evaluation mode, however it show error. brain ID and snapshot ID already added.
 Error code: 2. If the error persists, please contact Falken for further assistance..
UnityEngine.Debug:LogError(Object)
Falken.Logger:LogMessage(LogLevel, String, IntPtr) (at Assets/Falken/Scripts/Log.cs:164)
FalkenInternal.falken_modulePINVOKE:falken_BrainBase_StartSession(HandleRef, Int32, UInt32)
FalkenInternal.falken.BrainBase:StartSession(Type, UInt32) (at Assets/Falken/Scripts/Gen/falken/BrainBase.cs:94)
Falken.BrainBase:StartSession(Type, UInt32) (at Assets/Falken/Scripts/Brain.cs:202)
BasePlayer:CreateOrLoadBrain() (at Assets/Scripts/Entity/Player/BasePlayer-Falken.cs:281)
BasePlayer:OnEnable() (at Assets/Scripts/Entity/Player/BasePlayer-Falken.cs:178)
UnityEngine.GameObject:SetActive(Boolean)
PoolableEx:AwakeFromInstantiate(GameObject) (at Assets/Scripts/Util/Memory/Poolable.cs:412)
Client:CreateOrUpdateEntity(Entity, Int64, Boolean) (at Assets/Scripts/Client/Client.EntityNetworking.cs:1229)
Client:OnEntities(Message) (at Assets/Scripts/Client/Client.EntityNetworking.cs:1072)
Client:OnNetworkMessage(Message) (at Assets/Scripts/Client/Client.Connection.cs:327)
Facepunch.Network.DTLS.Client:HandleMessage() (at Assets/Plugins/D11.DTLS/DTLS.Client.cs:146)
Facepunch.Network.DTLS.Client:OnMessageReceived(Byte[], Int32, String, Int32) (at Assets/Plugins/D11.DTLS/DTLS.Client.cs:305)
D11.DTLSConnection:ProcessRecvBuffer() (at Assets/Plugins/D11.DTLS/Connection.cs:114)
D11.DTLS:ProcessConnections() (at Assets/Plugins/D11.DTLS/DTLS.cs:840)
D11.DTLS:Update() (at Assets/Plugins/D11.DTLS/DTLS.cs:610)

 System.InvalidOperationException: Session in brain 'Hello Falken Brain' with id '23d14e02-ba6b-4c01-aabe-76d69016bd4b' could not be created. Possible reasons are:
1. Service got cleaned up before this brain.
2. Given session type ('Evaluation') is 'Invalid'
3. An error ocurred in the service.
  at Falken.BrainBase.StartSession (Falken.Session+Type type, System.UInt32 maxStepsPerEpisode) [0x0001d] in C:\Repos\rust_console_win64\Assets\Falken\Scripts\Brain.cs:206
  at BasePlayer.CreateOrLoadBrain () [0x0006a] in C:\Repos\rust_console_win64\Assets\Scripts\Entity\Player\BasePlayer-Falken.cs:281
UnityEngine.Debug:LogError(Object)
BasePlayer:CreateOrLoadBrain() (at Assets/Scripts/Entity/Player/BasePlayer-Falken.cs:286)
BasePlayer:OnEnable() (at Assets/Scripts/Entity/Player/BasePlayer-Falken.cs:178)
UnityEngine.GameObject:SetActive(Boolean)
PoolableEx:AwakeFromInstantiate(GameObject) (at Assets/Scripts/Util/Memory/Poolable.cs:412)
Client:CreateOrUpdateEntity(Entity, Int64, Boolean) (at Assets/Scripts/Client/Client.EntityNetworking.cs:1229)
Client:OnEntities(Message) (at Assets/Scripts/Client/Client.EntityNetworking.cs:1072)
Client:OnNetworkMessage(Message) (at Assets/Scripts/Client/Client.Connection.cs:327)
Facepunch.Network.DTLS.Client:HandleMessage() (at Assets/Plugins/D11.DTLS/DTLS.Client.cs:146)
Facepunch.Network.DTLS.Client:OnMessageReceived(Byte[], Int32, String, Int32) (at Assets/Plugins/D11.DTLS/DTLS.Client.cs:305)
D11.DTLSConnection:ProcessRecvBuffer() (at Assets/Plugins/D11.DTLS/Connection.cs:114)
D11.DTLS:ProcessConnections() (at Assets/Plugins/D11.DTLS/DTLS.cs:840)
D11.DTLS:Update() (at Assets/Plugins/D11.DTLS/DTLS.cs:610)

ok, managed to load the brain, but got these error instead:
No brain action generated in evaluation session 3fcb2f28-bd52-4a84-839d-fc936484dafd, episode 74c78581-da24-4be9-9015-86d91a41f2ff at step 294. If the error persists, please contact Falken team to report this as a bug
UnityEngine.Debug:LogError(Object)
Falken.Logger:LogMessage(LogLevel, String, IntPtr) (at Assets/Falken/Scripts/Log.cs:164)
FalkenInternal.falken_modulePINVOKE:falken_Episode_Step__SWIG_0(HandleRef)
FalkenInternal.falken.Episode:Step() (at Assets/Falken/Scripts/Gen/falken/Episode.cs:52)
Falken.Episode:Step(Nullable`1) (at Assets/Falken/Scripts/Episode.cs:133)
BasePlayer:CalculateObservations() (at Assets/Scripts/Entity/Player/BasePlayer-Falken.cs:351)
BasePlayer:Update() (at Assets/Scripts/Entity/Player/BasePlayer-Client.cs:550)


Improve semver detection in Python release plugin

Currently, we are using a dumb regexp for finding current Python semver. To make it more efficient, either move to a module that can read a Python AST or improve the regexp (see the semver library that npm uses).

We already have an issue in https://github.com/twolfson/foundry-release-pypi/issues/1. Closing this as it's no longer relevant to this repo.


dtls1_process_record  logic seems conflict with RFC6347

As Per RFC6347, invalid records  should be silently discarded, and generate fatal level alerts in case of generate an alert.  But dtls1_process_record have these two behavior.  This seems conflict with the RFC6347.
dtls1_process_record implement:
generate fatal level alerts:
        if (!ossl_assert(mac_size <= EVP_MAX_MD_SIZE)) {
            SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_F_DTLS1_PROCESS_RECORD,
                     ERR_R_INTERNAL_ERROR);
            return 0;
        }

generate an alert:
    if (enc_err < 0) {
        /* decryption failed, silently discard message */
        rr->length = 0;
        RECORD_LAYER_reset_packet_length(&s->rlayer);
        return 0;
    }

<IP_ADDRESS>.  Handling Invalid Records
Unlike TLS, DTLS is resilient in the face of invalid records (e.g., invalid formatting, length, MAC, etc.).  In general, invalid records
SHOULD be silently discarded, thus preserving the association; however, an error MAY be logged for diagnostic purposes.   Implementations which choose to generate an alert instead, MUST  generate fatal level alerts to avoid attacks where the attacker    repeatedly probes the implementation to see how it responds to  various types of error.  Note that if DTLS is run over UDP, then any   implementation which does this will be extremely susceptible to denial-of-service (DoS) attacks because UDP forgery is so easy.  Thus, this practice is NOT RECOMMENDED for such transports.
If DTLS is being carried over a transport that is resistant to  forgery (e.g., SCTP with SCTP-AUTH), then it is safer to send alerts because an attacker will have difficulty forging a datagram that will  not be rejected by the transport layer.

        if (!ossl_assert(mac_size <= EVP_MAX_MD_SIZE)) {
            SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_F_DTLS1_PROCESS_RECORD,
                     ERR_R_INTERNAL_ERROR);
            return 0;
        }

In this case this is a "should not happen" internal error. It is not the result of receiving an invalid record so the text about how to handle invalid records in <IP_ADDRESS> does not apply. Sending a fatal alert in this case is reasonable.
    if (enc_err < 0) {
        /* decryption failed, silently discard message */
        rr->length = 0;
        RECORD_LAYER_reset_packet_length(&s->rlayer);
        return 0;
    }

I'm not sure what your point is with this code. It seems to me to be doing exactly what the RFC says, i.e. we have encountered an invalid record and therefore we are silently discarding it. No alert should be generated in this case (otherwise it wouldn't be silent).

        if (!ossl_assert(mac_size <= EVP_MAX_MD_SIZE)) {
            SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_F_DTLS1_PROCESS_RECORD,
                     ERR_R_INTERNAL_ERROR);
            return 0;
        }

In this case this is a "should not happen" internal error. It is not the result of receiving an invalid record so the text about how to handle invalid records in <IP_ADDRESS> does not apply. Sending a fatal alert in this case is reasonable.
    if (enc_err < 0) {
        /* decryption failed, silently discard message */
        rr->length = 0;
        RECORD_LAYER_reset_packet_length(&s->rlayer);
        return 0;
    }

I'm not sure what your point is with this code. It seems to me to be doing exactly what the RFC says, i.e. we have encountered an invalid record and therefore we are silently discarding it. No alert should be generated in this case (otherwise it wouldn't be silent).

Some other case will also send faltal level alert, and some seems result from invalid record. So  faltal level alert will send only in case  of internal error and only ingnore in case of invalid record as per the current design currently ,right?
   /* r->length is now just compressed */     if (s->expand != NULL) {         if (rr->length > SSL3_RT_MAX_COMPRESSED_LENGTH) {             SSLfatal(s, SSL_AD_RECORD_OVERFLOW, SSL_F_DTLS1_PROCESS_RECORD,                      SSL_R_COMPRESSED_LENGTH_TOO_LONG);             return 0;         }         if (!ssl3_do_uncompress(s, rr)) {             SSLfatal(s, SSL_AD_DECOMPRESSION_FAILURE,                      SSL_F_DTLS1_PROCESS_RECORD, SSL_R_BAD_DECOMPRESSION);             return 0;         }     }

Thanks, As per the RFC6347, Maybe it is better to ingnore in case of invalid record and send faltal level alert in case of internal error.

Thanks, As per the RFC6347, Maybe it is better to ingnore in case of invalid record and send faltal level alert in case of internal error.

Yes - that is the intent - but it seems there are a couple of cases as I mentioned above that need to be fixed.

Thanks, I will check further and raise PR to fix

marking as inactive, will be closed at the end of the 3.4 dev cycle barring further input


Add documentation for numeric_column api.

Added documentation for number_column api that will work self sufficiently.
Pull request for the work item - https://github.com/tensorflow/tensorflow/issues/47286

Thank you @MarkDaoust for taking time out for the review. I have implemented all the review comments. Feedback is welcome.

@MarkDaoust , one check is failing, but I am unable to see the reason why. Could you kindly direct me? Thank you once again.

@MarkDaoust , one check is failing, but I am unable to see the reason why. Could you kindly direct me? Thank you once again.

I'm fixing this internally, it should be merged soon.


Create GameState Blueprint

Acceptance Criteria

[ ] GameState object exists
[ ] Can store values for the global current score, and other considered values

Implementation

[ ] Create custom GameState object based on GameStateBase
[ ] Link the GameState to the GameInstance or GameMode

Might not be needed
A gamestate monitors the state of the gameplay non-specific to the Player. This would be values that would be managed if there are multiple players or multiple enemies. However it should not store player specific values.


Nested Generic Models under PEP604 Convention Break Pydantic

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
First of all, thanks for the outstanding job with Pydantic!
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
            pydantic version: 1.9.0
            pydantic compiled: True
                 install path: /usr/local/opt/pyenv/versions/3.10.3/envs/spark-prices-3.10/lib/python3.10/site-packages/pydantic
               python version: 3.10.3 (main, May  4 2022, 17:20:41) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]
                     platform: macOS-12.1-arm64-arm-64bit
     optional deps. installed: ['dotenv', 'email-validator', 'typing-extensions']

According to the documentation, we can create nested Generic Models:
T = TypeVar("T")

class InnerT(GenericModel, Generic[T]):
    inner: Optional[T]

class OuterT(GenericModel, Generic[T]):
    outer: T
    nested: Optional[InnerT[T]]

nested = InnerT[int](inner=1)
print(OuterT[int](outer=1, nested=nested))

That's working very well!
But, now, in Python 3.10, thanks to the PEP 604, Optional[] can be replaced by the | None operator. And that breaks Pydantic:
T = TypeVar("T")

class Pep604InnerT(GenericModel, Generic[T]):
    inner: T | None

class Pep604OuterT(GenericModel, Generic[T]):
    outer: T
    nested: Pep604InnerT[T] | None

nested = Pep604InnerT[int](inner=1)
print(Pep604OuterT[int](outer=1, nested=nested))

Traceback:
Traceback (most recent call last):
  File "pydantic_bug.py", line 55, in <module>
    print(Pep604OuterT[int](outer=1, nested=nested))
  File ".../python3.10/site-packages/pydantic/generics.py", line 136, in __class_getitem__
    _prepare_model_fields(created_model, fields, instance_type_hints, typevars_map)
  File ".../python3.10/site-packages/pydantic/generics.py", line 359, in _prepare_model_fields
    concrete_type = replace_types(field_type_hint, typevars_map)
  File ".../python3.10/site-packages/pydantic/generics.py", line 263, in replace_types
    return origin_type[resolved_type_args]
TypeError: 'type' object is not subscriptable

Does the Outer model need to be generic to cause this? Shouldn't be too hard to fix.

Yes. This piece of code is working well:
from typing import Generic
from typing import TypeVar

from pydantic.generics import GenericModel, BaseModel

T = TypeVar("T")

class Inner(GenericModel, Generic[T]):
    inner: T | None

class Outer(BaseModel):
    outer: int
    nested: Inner | None

nested = Inner[int](inner=1)

print(Outer(outer=1, nested=nested))

This seems to work now on latest (2.5.0)


Allow disabling half.h

Use new OPENVDB_THROW_IF_HALF_NOT_SUPPORTED() macro which, when OPENVDB_USE_HALF is OFF.

Closing this PR, I have incorporated these changes into PR #819. Thanks!


Signature Pen Color

Signature pen color is not set after calling a method
mSignaturePad.setPenColorRes(color);//where color is get by Color Picker Dialog.

Hello,
You shouldn't use setPenColorRes(color) as color must be a resource, not a color.
For your usage, you should use setPenColor(color), passing the int representing the picked color.


Sercurity issue: clickhouse server ip & port is showing on the dashboard UI

Bug description
Hi,
The issue is the Clickhouse connector return sensitive detail: IP & Port  in the Superset UI dashboard
Example:
Error: HTTPDriver for http://<IP_ADDRESS>:8123 returned response code 404)
 Code: 60. DB::Exception: Table test.users_1 does not exist. Maybe you meant test.users? (UNKNOWN_TABLE) (version <IP_ADDRESS> (official build))

the UI will show the IP & Port and event the table and database name then the hacker may use this to attack.
Furthermore, The dashboard viewer/creator I don't think the technical error message will help them.
So I think we need to wrap the exception and give a better description for each error to the UI.
Beside that we will log the details of the original exception in the Superset backend side => So the admin they can debug and check the log later.
By doing this, the UI will display  clean and clear.
Summary

Checklist
Delete items not relevant to your PR:

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided to include in CHANGELOG
[ ] For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

How to reproduce the bug

Create a virtual dataset with Clickhouse Connection
Build a simple dashboard with at least 1 chart using the above dataset.
Change the database with a wrong name in SQL query. And save it
Go to the dashboard and see the debug message log

Screenshots/recordings

Superset version
4.0.1
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist

[ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
[ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

Solved by set show_clickhouse_errors = False


Fix invalidate size in geojson outputs

Without a setTimeout (of any timeout value), I’m observing that geojson outputs don’t invalidate size and as a result render only a portion of their tiles. Documents don’t have this issue. I don’t really understand why so this is a temporary fix until we understand what’s going on.
As a side note: The scroll wheel zoom logic is only necessary for outputs (vs. documents), but I don’t know how to detect whether the widget is being used within an output or document context.

We should talk about whether renderers should know they are in a document at the meeting today.


Microsoft.PowerShell.Commands DLL not found

Hi guys,
I am trying to use the System.Management.Automation nuget package version 7.0.0-preview.4 in my application. But I keep getting the error message below when I try to run it.
Error Message:
Cannot load PowerShell snap-in Microsoft.PowerShell.Diagnostics because of the following error: Could not load file or assembly 'C:\Users\MyUser\Source\Repos\ConsoleApp2\ConsoleApp2\bin\Debug\netcoreapp3.0\Microsoft.PowerShell.Commands'. The system cannot find the file specified

Screenshot:

The PowerShell version installed on my computer is: 5.1.14393.2879

Steps to reproduce

Install the System.Management.Automation nuget package version 7.0.0-preview.4 in a new .Net Core console application.

Update your Main method in the Program class.

       static void Main(string[] args)
       {

           PowerShell
               .Create()
               .AddScript("get-process")
               .Invoke();

       }

Expected behavior
Return a list of processes

Actual behavior
Throws an error message.

The fix to this error message is to install the Microsoft.PowerShell.SDK package instead of the System.Management.Automation.


How to use "|" in a Better Table when pulling from other rolltables in a compendium?

Hi I have a rolltable that is not in a compendium that has as results other rolltables that are in a compendium.
Some of the results in the compendium rolltables look like this @creature[Giant Boar] and some look like this @creature[Shadow Mastiff|VGM]. If I get a result that has the "|" in it, those results have messed up formatting. The ones without a "|" do not have issues.
Also, I noticed that if I use the same rolltables for results but do not have them in a compendium it works fine. So this would be stock Foundry. Default table with other default tables as results. But when they are in a compendium, I have to make the main table a better table for it to roll from a compendium. And that is when there is a problem.
Is there a way to escape the "|" character so that I can still use it in the tables? I have a lot of them so I'd rather have them in a compendium if possible.
Thanks

To reproduce this, if I understand this correct.

Create a table in World
Reference/roll on Compendium rolltables
Have results in these tables that have |

Just so I learn something new, does the | is meant to to something?
is this a flag or an operator?

Yes that is correct.
This is what the tables and results look like. Figured this could help you visualize.

As you can see the 2 results that have the "|" get a lot of code displayed in the result.
I'm not sure about naming the mod that works with this here but let's just say "a mod" allows importing of actors (and other entities) by using a specific tag format. For creatures in the MM, one does not need the "|" character. So above the Naga tag looks like @creature[guardian naga]. But for creatures in other source books, an identifier is required and that is when the "|" comes in. For example the Orthon would be @creature[Orthon|MTF]. When the result is in the correct format (such as the Naga above) I can actually drag that result onto the canvas and it both adds the token to the scene and imports the actor.
Hopefully that makes more sense but if you have any questions feel free to ask. Thanks!

Hi @DanielBoettner,
I'm not expecting a fix yet or rushing you or anything, just wondering if my explanation made sense and see if you had any questions or wanted any additional info.
Thanks!

Did not yet have the time going into that exactly issue.
I will update you as soon as I can do so.
Thanks for your patience.

Fast reply! No worries, take your time and just let me know if you need anything else. :-)


Navigation Menu button hover color style is missing or not honored in freelancer.css

Currently hover color of Menu button for narrow screens does not meet the style of other buttons on page (like contact me form Send button). I also couldn't find a way of changing it through freelancer.css.

I was able to fix it by changing following files (making as little as possible changes)

index.html - remove bg_primary class, add btn btn-primary classes to Menu button

from
  <button class="navbar-toggler navbar-toggler-right text-uppercase bg-primary text-white rounded"

to
  <button class="navbar-toggler navbar-toggler-right text-uppercase btn btn-primary text-white rounded"

freelancer.css - remove btn class, add missing important! to btn-primary selectors

from
.btn {
  border-width: 2px;
}

...

.btn-primary:hover, .btn-primary:focus, .btn-primary:active {
  background-color: #128f76;
  border-color: #128f76;
}

to
.btn-primary:hover, .btn-primary:focus, .btn-primary:active {
  background-color: #128f76 !important;
  border-color: #128f76 !important;
}

Rewrote some of this stuff in the most recent update so this should no longer be an issue.


API calls very high during startup

Similar to issue number 1, I am seeing a huge spike in API calls to unsplash only during startup, or refresh or restart MM.
I have 7 Wallberry modules configured, since I am using Pages.  Each Page has a different collection or module associated with it.  I have set the update interval to be 1hour, and I have persistance enabled in my PAGE-SELECTOR module.
Unsplash limits us to 50 requests/hour, and what I am observing is during startup, Typically 6-8 requests are made per Walberry module.  For 7 modules, I exceed the 50 and must wait for the next hour to have the API interface reset.  When you start up, is the module doing a lot of queries before downloading?
Everything still works, but I wanted to see if you can optimize (minimize) the start-up API calls.

This sounds like it's probably an issue with the way your Pages module manages the different WallberryTheme module instances, as WallberryTheme makes only one API request on start up or on resume. Without knowing how the Pages module works, I'm not sure what would cause the multiple requests - it sounds like something the Pages module is doing is causing each WallberryTheme instance to be started or refreshed multiple times.
This probably isn't something I can fix cleanly on my end. WallberryTheme does currently support wake and resume notifications so other modules can order WallberryTheme to suspend API requests while in the background, but it's up to them to do so.
You can post a link to the Pages module you're using and it's possible there will be something we can do to help integrate WallberryTheme with it, but without knowing how the other module works I can't be sure.


Modal should capture all key presses while being open

Steps
I have a login form with username and password fields and a submit button. When the form is submitted, an API call is made and if the response is not successful a Modal is displayed notifying the user.
The problem is - while the modal is being displayed, the cursor is still in the username/password field and if I press Enter hoping to close the modal it resubmits the form even though the modal is covering the whole page. I've not found an easy way to automatically focus on the button in the modal.
Expected Result
Modal/dimmer to capture key presses and act as a layer covering the whole page. At least give us an option which modal action to activate (default to) on open.
Actual Result
Dimmed modal is acting as if it's "transparent" even though it's covering the whole page and not capturing focus.
Version
0.68.5
Testcase
https://codepen.io/anon/pen/wewbjX
Open console, focus on the username field and press Enter multiple times. Watch form submission messages being logged on every Enter press.
Note
The same isssue is happening with the Form element if loading is set to true. One can keep submitting the form even though it's covered by the loading overlay.
Probably related to #1341.

@levithomason commented on this before there and there. I agree with him, Modal shouldn't capture focus by default.
You can simply remove focus from Form in the handleFormSubmit, it will solve your issue. I will keep this issue opened before we'll get a response from @levithomason.

https://codepen.io/anon/pen/JJdbjm
Add a button id
<Button id='my-button' color='green' inverted onClick={this.closeModal.bind(this)}>
  <Icon name='checkmark' /> Yes
</Button>

After the state change to open, focus the button
this.setState({
  open: true,
}, () => {
  // after modal opens, focus the modal button
  const $button = document.querySelector('#my-button')
  if ($button) $button.focus()
  console.log($buttont)
})

@levithomason Isn't that a rather dirty solution having to use document.querySelector? I suppose I could use refs but it would be nice if there was a built-in functionality to specify which button/action to default to when the modal opens.
Also, for some reason the onOpen event isn't triggering in my case. I have the <Modal> element defined in my App component so that I can display global popups/alerts using Redux.  It shows and hides if I change the open property but the onOpen never gets called. Any ideas what it could be?


[FLINK-16694][ci] Limit number of dumped log lines

With this PR we only print 500 from each log file if an error/exception etc was found.
This is to prevent issues with ungodly long log files caused by some tests. This is usually only an error on Travis (so it only really applies to 1.10/1.9), but I think there could be value in restricting this at all times.

If we are going to merge this to master as well, I would recommend putting the Flink logs into the ARTIFACTS_DIR, so that we can recover the full logs for debugging purposes.

that should already be done afaik: https://github.com/apache/flink/blob/master/flink-end-to-end-tests/test-scripts/test-runner-common.sh#L99

Ah yeah, I forgot.

This breaks the scripts on macOS, --lines doesn't work, but -n does. I pushed fixes to master and release-1.11.


update readme for how to build

Pull Request Test Coverage Report for Build 7671

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.109%

Totals

Change from base Build 7670:
0.0%

Covered Lines:
8700

Relevant Lines:
15787

💛  - Coveralls


update pyright version

can you update this in typespec/packages/http-client-python instead? we've moved the bulk of our code there. you can check the downstream effects using these steps. thanks @kristapratico

Oh thank you will do


feat:  new variant to action in table with text in button #700

#700
Add new variant to action in table with text in button

Pls, align the column actions to left.


Onboard with OSD multiple data source feature

When OSD MD feature is enabled. All visualizations in native OSD will support its use case. User experience side, there shouldn't be a difference for them. Since gantchart is also a visualization. Could you evaluate the changes of user experience?
For integrating with MD feature. We have provided API to be able to get a data  source client instead of the default legacy client in gantchart. Logically, all places that interacts with OS will need to switch to use datasource client on demand. Since I am not familiar with the code base, I only found 1 places that does the actual search. Am I missing anything?
https://github.com/opensearch-project/dashboards-visualizations/blob/main/gantt-chart/server/routes/index.ts#L42

Gantt chart uses IAggConfigs to get fields and context.core.opensearch.legacy.client.callAsCurrentUser() to send search requests
If user selects an index pattern from a different data source, I'm assuming IAggConfigs would have its metadata? It's used here https://github.com/opensearch-project/dashboards-visualizations/blob/029f1743392fa68a40da627bcd4f31fe76bfe2d8/gantt-chart/public/components/gantt_chart_editor.tsx#L19


When switching type, the type will change anyway regardless of the prompt result and delete the datas

Expected Behavior
The type should change only after selecting "Ok" or stay the same when clicking on Cancel

Actual Behavior
After Entering settings, when switching to any kind of type ( body type or authentication ) a prompt to avoid losing your settings appears as such

but right after clicking, the authentication / body type will instantly change, making the prompt useless and losing your settings and data anyway
Reproduction Steps
Example for the body:
After creating a request

Click on multipart
add a setting with any text
switch to JSON
the prompt appears and the data is lost

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
Version: Insomnium 0.2.3-a
Build date: 29/10/2023
OS: Windows_NT x64 10.0.19045
Electron: 25.8.1
Node: 18.15.0
Node ABI: 116
V8: <IP_ADDRESS>-electron.0
Architecture: x64
Insomnium Version
0.2.3-a
What operating system are you using?
Windows
Operating System Version
Windows 10
Installation method
Downloaded windows package from the github release tab of insomnium
Last Known Working Insomnium version
No response

Hey, can you assign this issue to me?

@Burrish aww this is a good catch.. really bad bug
@G0HAN3 my bad I had been radio-silence recently (catching some work & some stuff happened and now I'm back on github).. It will be real cool if you can sort it out!


PT-155764178 Sophia AENS

Closes

PT-155764139
PT-155764178

Missing

update transaction: not clear how to handle the pointers
names owned by external accounts: fix with PT-158023244

Protocol PR: https://github.com/aeternity/protocol/pull/130


FPS Initialize

Description
Vendor AddressRegistry contract
Add foundry tests
Add circleci task to run foundry tests
Create constants file
Start FPS documentation
Tests
Tests have been added for the AddressRegistry contract, with all functions being called and only 2 branches in the constructor that have not been tested.
Metadata
Part 1 of this issue: https://github.com/ethereum-optimism/superchain-ops/issues/397

/ci authorize 65282912dab58b481a7f592510c261688d2205f2

/ci authorize 65282912dab58b481a7f592510c261688d2205f2

/ci authorize 65282912dab58b481a7f592510c261688d2205f2

/ci authorize a501b54257ddba09b389282df73be054ca289097

/ci authorize a501b54257ddba09b389282df73be054ca289097

/ci authorize a501b54257ddba09b389282df73be054ca289097

/ci authorize https://github.com/ethereum-optimism/superchain-ops/pull/406/commits/a501b54257ddba09b389282df73be054ca289097


make boilerplate-update for Golang 1.20 compatibility

This PR is the result of running make boilerplate-update. Similarly to #166, this should allow openshift/release#51661 to pass, which will allow us to bump the Golang version for this repo as a whole to v1.20.
/kind dependency-change

/lgtm

/approve


docs(cn): translate content/docs/hooks-effect.md into Chinese

content/docs/hooks-effect.md done.

@Crazydogs


How to define a List of Nested Object Schema

I'm working on designing a nested object's schema on a Games collection.
Documents will be stored like this:
{
    gameId:'123456',
    datetime: 'xxxx',
    stats:[{
             playerId:"456789"
             score:20
             fouls:3
           },{
             playerId:"789123"
             score:16
             fouls:4
           },
           ]
}

I thought the Schema of Games.stats should be:
Schemas.statsForGames = new SimpleSchema
  playerId:"456789"
    type:String
    optional:true
    label:"ID"
  score:
    type:Number
    optional:true
    label:"Score"
  fouls:
    type:Number
    optional:true
    label:"Personal Fouls"

and In the Games Schema:
    stats:
        type:[Schemas.gameStatsOfTeam]
        label:"球队数据统计"
        optional:true

But after I defined these and tried to update my collections with:

Games.update("123456",{$push:{stats:{playerId:'456789',score:20,fouls:1}}})

I got errors like:

SimpleSchema.clean: filtered out value that would have affected key "teamStats.$.playerId", which is not allowed by the schema

I checked the docs and there is only an [Object] option in Arrays topic. Is there any chance I can define schemas above, that may be helps on code reuse.


Various potential new commands from github repo

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[x] feature
[ ] bug:

Details
https://github.com/MichelleUfford/sql-scripts

Oh, her script on SQL Agent status is awesome...been using that one for years. It would be awesome to see the Get-DbaAgentJob expanded to include similar output.

I can look at incorporating some of the schedule/last execution info into Get-DbaAgentJob, that would for sure be useful.

Well, last execution would be more fitting in Get-DbaJobHistory which was just added.

The lastexecution and the like are properties of the AgentJob object, and the Get-DbaAgentJob function already returns them!
The jobschedules are totally different things and don't belong in the Get-DbaAgentJob function.
In JobHistory, the user can | sort and | where and ... to get the latest execution in general, of a specific agent job, the last succeeded, and so on.
Also, JobHistory may be purged and miss lastexecution of certain jobs.

Can you then expand Get-DbaJobHistory to include the same items that are in Michelle's script?
This is an example of the output I build from her script in my assessment script:

Only the ..count columns come from jobhistory, and this is a history table subject to settings concerning purging.
The others are job properties and schedule properties.
we already have all of them, but maybe not combined.
Get-DbaAgentJob | select *
Get-DbaAgentSchedule | select *
the AgentJob.JobSchedules collection needs to be joined to the AgentSchedule.Name and the counts are aggregates from jobhistory, grouped by result and joined to the job on jobid.
This table will be incorrect if a job has multiple schedules, because those aggregate rows will become a one to many, and the counts will appear multiple times.
As for [Enabled], there is Job.enabled and schedule.enabled.
@sanderstad and @DevOpsFu may have a solution ready.
If not, I think we can build a new script to get those results, because we need to have a lean and fast Get- for those 3 objects separately.

I would agree in keeping the Get commands separate, but we need to offer a method that either (1) lets a user join the output together to build a full report or (2) build out a wrapper function to do it for them.
Maybe a Get-DbaSqlAgent that includes a switch for Jobs. Certain cases we need to be able to pull the Agent properties, but others I just want all the jobs configured along with the schedules an such associated with each one. That may be to big to handle on our side in one command, but we should provide an easy method (or set of commands) that does.

Those "wrapper" scripts are my favourites 😄
like a second layer that bundles the power of multiple functions, that's what gives so much added value.
Only, there are so much possibilities: drill down reports, excel tabs, write-host with colors, write to a database with normalized design (I do that daily), ....
I've done some things like that in scripts, in blog posts like computerinfo , but I think not everything should be a function.
We've raised the idea of a script repository a few times before.
Wouldn't this be more suitable for someting like that?

Well I need to grab this type of info for up to hundreds of servers when doing client reviews. So  if it is not added to dbatools I'll just add it to my repo.

This was not approved to incorporate into the job commands we already have so will it be created as a new maybe Invoke command, or just close this request?


Trouble Enabling batarang in Version 46.0.2490.71

Hi All
I am new to angular and trying to enable chrome extension for debugging angular app
my chrome version is Version 46.0.2490.71 and i have downloaded Batarang latest version available in  Github.and added in chrome://Extensions and enabled it.
I can see AngularJs tab while i open developer tool ,but the sub tabs inside the angular tab is missing and i am unable to enable it ,Please see the screen shot and let me know if i am missing anything ? any settings?

I haven't seen that before. Can you inspect the Batarang Extension background page (from chrome://extensions/) and see if there are any errors there ?

I have the same issue.
I checked the Extension log, but there is nothing. I'm using version 10.7.
Do you have any idea?

If you update Chrome (you're 5 major versions behind, seems like a good idea) does it work?  I don't think supporting past versions is in scope for this project.

@Ajishapj, @gkalpak, @jycouet, @SomeKittens are you still using Chrome at versions prior to 52?
Maybe this issue can be closed, due the time lapse.

For me you can close it :)


BUILD FAILED

I was run the scripts step by step, But, An error occurred
when I running 'sh build.sh build'
See: clang: error: no such file or directory: '/Users/KingCQ/Desktop/realm-cocoa/Realm/ObjectStore/src/impl/apple/external_commit_helper.cpp'
clang: error: no input files
** BUILD FAILED **

Which version of Realm are you building? How did you obtain the source? Which instructions are you following?

The nature of the error suggests that the submodule at Realm/ObjectStore is not initialized. If you've cloned the Git repository, you'll want to run git submodule update --init --recursive to ensure that all submodules are initialized.

Thinks, it's work for me!


skip server side apply because of gke neg webhook issue

more details found at https://github.com/kubernetes/kubernetes/issues/96351, which requires GKE fix. Keep it in master as it works normally and we can still work and test it out with GKE folkd

@richardwxn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test release-notes_istio_release-1.8

unit-tests_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test unit-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test release-notes_istio_release-1.8

unit-tests_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test unit-tests_istio_release-1.8

integ-security-multicluster-tests_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test integ-security-multicluster-tests_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test unit-tests_istio_release-1.8

integ-security-multicluster-tests_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test integ-security-multicluster-tests_istio_release-1.8

release-notes_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan it was merged for master, but auto cherry-pick failed, so do it here

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.8
38a7d27be93f96c48b439ba89e88b6ee5fbe4143
link
/test unit-tests_istio_release-1.8

release-notes_istio_release-1.8
2fdc5abc94f2ed87f970f9ba7441422000981ac1
link
/test release-notes_istio_release-1.8

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio_release-1.8


PTR (Reverse DNS) is not Resolving Locally.

Hello,
I have Followed Blog For Configuring Power DNS + Power DNS Admin.
https://www.howtoforge.com/how-to-install-powerdns-admin-on-ubuntu-20-04/
After setting up all the things I have created RDNS From Admin Panel, But it is not resolving, Please Refer Below Attachments.
Please Let me know if You Require anything Else.

Hello,
you must only enter the last part of the IP to the RTP Record.
In your Example you must set the RTP Records with the Names 4 and 10, because the rest is already set over the Zone.

Hello,
you must only enter the last part of the IP to the RTP Record.
In your Example you must set the RTP Records with the Names 4 and 10, because the rest is already set over the Zone.

Hello,
Thats Great it Worked It is Resolving Locally, But i am not Sure Why i am not able to ping google.com From My Server.

Hello,
Thats Great it Worked It is Resolving Locally, But i am not Sure Why i am not able to ping google.com From My Server.

Hello,
PowerDNS consists of several components once the PowerDNS Authoritative Server that you have set up, which is only there to resolve its own zones (test.com).
The PowerDNS Recursor is a resolver that searches for the authority DNS server of the searched zone (google.com) based on the Root DNS and TLD DNS servers and then asks the Authority Server (ns1.google.com) for the record.
The different types are also described quite well here. https://www.cloudflare.com/learning/dns/dns-server-types/
So, in order to resolve external zones (google.com), you would also need the Recursor, which then forwards the requests to the local zone (test.com) to your Authoritative Server.

Hello,
PowerDNS consists of several components once the PowerDNS Authoritative Server that you have set up, which is only there to resolve its own zones (test.com).
The PowerDNS Recursor is a resolver that searches for the authority DNS server of the searched zone (google.com) based on the Root DNS and TLD DNS servers and then asks the Authority Server (ns1.google.com) for the record.
The different types are also described quite well here. https://www.cloudflare.com/learning/dns/dns-server-types/
So, in order to resolve external zones (google.com), you would also need the Recursor, which then forwards the requests to the local zone (test.com) to your Authoritative Server.

Hello,
I Didn't Got that DNS Stuff but it seems like My Domain name or hostname should be resolved globally but not local only.
but so why i am able to ping <IP_ADDRESS> and not google.com i have public ip for my server & when i add <IP_ADDRESS> in /etc/resolv.conf google.com start pinging but nslookup stoped working for my local addr domain.
Please guide.

Hello,
I Didn't Got that DNS Stuff but it seems like My Domain name or hostname should be resolved globally but not local only.
but so why i am able to ping <IP_ADDRESS> and not google.com i have public ip for my server & when i add <IP_ADDRESS> in /etc/resolv.conf google.com start pinging but nslookup stoped working for my local addr domain.
Please guide.

Hello,
I don't exactly undertand your question but I'll complete @larslehmann-net  answer to be clear. There are two kinds of DNS Servers:

Authoritative : These servers literally hosts zones content. What you installed is PowerDNS Authoritative Server. PowerDNS Admin is the frontend to manage PowerDNS Authoritative Server content.
Recursive: These servers take all the clients requests and try to resolve it recursively to answer the requests. This is done by PowerDNS Recursor, which is another software.

When you configure a client, it should be configured to reach a Recursive Server :

the recursive server will resolve any request for your client (google.com, github.com ...)
it will instead not be able to resolve your local domains if they are not registered in a registrar and behaving correctly with a public IP (the recursion chain must be set correctly) UNLESS you locally add a FORWARD directive to your Recursive server to point at the local IP of your Authoritative server for all the zones you are hosting. As private IP ranges reverse domain are not served over public DNS, the FORWARD is a requirement for private ip subnet reverse domains.

Pointing your client to your Authoritative server will fail for any domain not served by your server. You have to install a recursor and configure your client to send requests to the recursor instead. Then, if your domain is not available outside your organization, you have to configure a zone forward inside your recursor to point the required domains to your internal Authoritative server.
I hope it's a bit more clear for you.


Close span tag

Some template compiler configuration will complain about missing closed tag

Thank you for this, as this is a duplicate of the PR i just merged, I will close this request. Thanks for taking the time though!


Add Vision detect_properties() system tests.

Towards #2753
Adds the system tests for detect_properties().
test_detect_properties_content (vision.TestVisionClientImageProperties) ... ok
test_detect_properties_filename (vision.TestVisionClientImageProperties) ... ok
test_detect_properties_gcs (vision.TestVisionClientImageProperties) ... ok
...

----------------------------------------------------------------------
Ran 18 tests in 25.420s

OK
________________________________________________________ summary ________________________________________________________
  system-tests: commands succeeded
  congratulations :)

The last method!

🎉


Cleanup unused messages

I did a lot of cleanup in #699, there are some messages that need further consideration. These are unused right now, do we want to keep them?
BUTTON.LEAVE
BUTTON.MORE_OPTIONS
BUTTON.SUBMIT
PICKUPMANAGE.TITLE
PICKUPMANAGE.SHOW_SERIES_DETAILS
PICKUPMANAGE.HIDE_SERIES_DETAILS
PICKUPMANAGE.DATE_TEXT
PICKUPMANAGE.NUMBER_COLLECTORS
PICKUPDELETE.DELETE_SERIES_TITLE
PICKUPDELETE.DELETE_SERIES_TEXT
CREATEPICKUP.TITLE
CREATEPICKUP.TITLE_EDIT
CREATEPICKUP.SERIES
CREATEPICKUP.SINGLE
CREATEPICKUP.WEEKDAYS
CREATEPICKUP.HINT_MULTIPLE
CREATEPICKUP.TIME_ERROR
PICKUP_FEEDBACK.TITLE
PICKUP_FEEDBACK.AMOUNT
PICKUP_FEEDBACK.COMMENT
PICKUP_FEEDBACK.COMMENT_PLACEHOLDER

I'd like to remove unused messages to reduce the load for new translations.

Only BUTTON.LEAVE is left unused with #720


Outset should ignore .DS_Store files

If Outset is configured to verify checksums and a .DS_Store file happens to exist in out of the Outset directories, an error is printed to the log.
This doesn't seem to cause any problems with processing other scripts, but it would be nice if Outset would simply ignore that file.
For my build process, I wrote a script to copy all of my scripts from a local repo into the Outset folder and then use outset-pkg to make the installer. When I copy those files, sometimes a .DS_Store can be included. Obviously I've improved my own build script to exclude .DS_Store files, but I think it would be nice if Outset ignored them by default.
Thanks for reading!

I've thought about this for a bit and I've decided to close this as wontfix.
The reason being that outset is not impacted by the presence of .DS_Store files but will result in an error to the log. This behaviour is preferred to ensure your deployments are clean. As you have indicated, the presence of the error message forced you to improve your process. If no error were thrown in the presence of files that were not supposed to be there then you would not have noticed.
That is to say, we want outset to notify us when our file structure is not how it should be, but also errant files should not impact regular operation.


Preview window stays in the foreground

Describe the bug
When a markdown file is open, the preview window stays in the foreground when a side panel window is opened (properties or test explorer docked on the side with auto hide enabled).
To Reproduce
Steps to reproduce the behavior:

Open a markdown file with preview
Open one of the docked and auto hidden side panel windows
The preview stays on top of the side panel window

Expected behavior
I would expect the preview window gets pushed back (as the markdown file window does)

Probably same as / related to #49

Yes, this is a dupe of #49. Closing this one


Update asset_transfer_ledger_chaincode.js

Using the right function name

@RobertBetschinger  could you please fix the DCO issue so we can merge your change? Otherwise we'll have no choice but to abandon it.
Thanks.

@RobertBetschinger as @lehors said, can you fix the DCO issue please and I can merge this.

Hello :)
Sadly i Dont know the Right Push command.
Beat Regards
Robert
Von meinem iPhone gesendet
Am 03.09.2021 um 09:12 schrieb Matthew B White @.***>:

@RobertBetschingerhttps://github.com/RobertBetschinger as @lehorshttps://github.com/lehors said, can you fix the DCO issue please and I can merge this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/hyperledger/fabric-samples/pull/437#issuecomment-912312607, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMFHRMQ6SH54D3GB76R2ES3UABYOZANCNFSM42UPRTHQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hello :) Sadly i Dont know the Right Push command. Beat Regards Robert
The following should do it, from your machine on the same branch:

git commit -s --amend
git push -f

First, you amend your commit adding (-s) your sign-off.
Then you push it.


Add support for GCP KMS as a signer, using the sigstore/sigstore libr…

…ary.
This will allow using other providers in the future.

/lgtm

/lgtm


Last N Matches Lookup over 10 results to current season being left out (Italian Serie A)

It's discussed on other opened issues but seems that there is an issue if you put over last 3 matches, all the games don't get imported.


tests/subsys/fs/nffs_fs_api:-Evalution failed

As on  zephyr commit ID:-07e1a64e77e15180721c56993a19bce473ff4365
Steps to be Reproduce:
cd $ZEPHYR_BASE/tests/subsys/fs/nffs_fs_api
mkdir build && cd build
cmake -DBOARD=qemu_x86 -DTEST=cache ..
make run
Then console output is obtained as pasted below:
Running test suite nffs_fs_cache_test
starting test - test_cache_large_file
Assertion failed at /tests/subsys/fs/nffs_fs_api/src/nffs_test_utils.c:216: nffs_test_util_assert_cache_range: cache_start not equal to expected_cache_start

FAIL - test_cache_large_file.
===================================================================
PROJECT EXECUTION FAILED

I'm guessing this is related to needing to configure CONFIG_FS_NFFS_NUM_CACHE_BLOCKS & CONFIG_FS_NFFS_NUM_CACHE_INODES.  If you look at tests/subsys/fs/nffs_fs_api/testcase.yaml you'll see those set as part of the cache test.

you need to set additional configs per the testcase.yaml for the cache test


dilated convolution support

Hi,
Is there any plan to support dilated convolution layer on arm-neon. It would be really useful to run the waveNet kind of networks.
Thanks

Hello @Subarukun,
Yes we have this in our backlog don't though when it will be scheduled.

Closing issue. Dilated convolution was added in 18.05.


Refactor to separate container IDs from container names

This PR introduces IDs for containers separating them from container names similar to what we have for pods. I will add support for short IDs in a follow on PR.
@runcom PTAL

LGTM


Deploy to SaaS sandboxes fails in preview

When publishing apps to SaaS sandboxes, the deploy process shows the installed apps and then, when trying to install the new apps (or updates to existing apps), it fails with the following error message:
"The response content cannot be parsed because the Internet Explorer engine is not available, or Internet Explorer's first-launch configuration is not complete. Specify the UseBasicParsing parameter and try again."
I am assuming something changed recently in how the Invoke-WebRequest functionality is implemented in PS, but not sure, if that is actually the case.

That is likely a bug in ContainerHelper - will issue a fix asap

should work in approx 1 hour

Thank you, @freddydk!
I can confirm that it's working. And I apologize, I probably should have dug in more to see that it was part of BcContainerHelper and not AL-Go per se. But that's the great part of having control over both projects ;)
Merry Christmas and a Happy New Year!

No problem
Merry Christmas and Happy New Year to you and yours as well...

BTW - this bug was introduced after changing Publish-PerTenantExtensionApps to use v2.0 of the management API supporting force sync.
Will add support for setting Force Sync in AL-Go as well.


trim command line before parse it

This can avoid some errors caused by an additional space at the end of
the command line.
For example: 'use db ' will be trimed to 'use db' and parsed correctly.
Signed-off-by: Kai Zhang<EMAIL_ADDRESS>

The unit tests failed:
Pretty print disabled

--- PASS: TestParseCommand_TogglePretty (0.00s)

=== RUN TestParseCommand_Exit

--- FAIL: TestParseCommand_Exit (0.00s)

panic: runtime error: invalid memory address or nil pointer dereference [recovered]

panic: runtime error: invalid memory address or nil pointer dereference

[signal 0xb code=0x1 addr=0x0 pc=0x503cd0]

goroutine 9 [running]:

testing.func·006()

/usr/local/go/src/testing/testing.go:441 +0x181

github.com/influxdb/influxdb/client.(*Client).Query(0x0, 0x747ad0, 0x5, 0x0, 0x0, 0x0, 0x0, 0x0)

@otoolep updated

+1 from me. Please merge @corylanou if it looks good to you.

+1


Ability for end users to load data on to prod and treat the data as a source of truth for others to consume

[ ] End user should be able to upload the data via portal
[ ]  data is validated against the underlying structure.
[ ] Ability for the the end user to add or modify the structure of the table
[ ] Only authorised users are allowed to make changes.
[ ] Users should be able to upload data only to the tables were they were assigned access to load
[ ] Audit log of all the changes to be captured.
[ ] Users should be able to upload the data  only after validating the data against the schema of the table
[ ] Should be able to support standard csv  format files.
[ ]  Any schema validation error should be thrown in the UI with reference to the line number and column in the data which lead to the error in the first place limiting to a max of 10 errors.
[ ] Once the data is submitted the workflow should go to the data owner for review and approval. Only approved data upload gets published.
[ ] any data upload that is rejected should send out appropriate email alert to the requester. The approver while rejection should have to provide justification for the reject and that becomes part of the email.
[ ]  when a requester request to upload the data an email is sent to approver with the link to take appropriate action.
[ ]  The entire solution/portal should be over SSL.

Rationale:-
For user data to be treated as production data we need to have:-

an automated process which the production support team can support.
audit traceability of who and when some one had loaded the data.
prevent unauthorised users making changes to the data
data is validated for correctness ( Through code rather than manual verification ).
appropriate security restrictions in place.
the user should not be able to upload to other data assets which are loaded from source systems.

@anandsiva can you raise this issue here https://github.com/CommBank/maestro-team. This is a larger issues that won't be directly provided by the Maestro library but is instead work that needs to be done by the team. We will probably stand up a separate service and repo for this.

Yes. Created a new ticket. https://github.com/CommBank/maestro-team/issues/11


provide better error messages when importing publications/datasets

fixes #1138 #1135 #1136 #1137
So

provides error for "bad connection"
provides error for "not found" (if it can be determined)
provides error for "invalid content"

TODO: I have put the text in translations.go, but .. that contains also html data. So feels a bit off.

@nicolasfranck which parts do you mean? Do we need to rewrite information?

@mietcls not sure if that is possible.
What I mean: for each situation (bad connection, resource not found ..), a localized message (stored in the translation map) needs to be put in the "body" of the toaster.
In the past that body of the toaster was merely a sentence, with here and there simple tags like  or . But now the body needs to have a whole html structure. That fills the translation map with data like "
I do not want you to see this
 are we good?", data you would expect in a template...

@mietcls yes it works, but putting a lot of html in a translation map makes it unreadable.

@nicolasfranck yes that's true. There are plans to move this to a different format, where it becomes more manageable.

to delete or split up? @netsensei @nics

@nicolasfranck @nics @mietcls I'm closing this. This an attempt to create error messages which were not useful enough for end users. See #1091  => needs to be turned into a discussion to hash out how we want to move this one forward.


Add build script and Dockerfile.

@pires this should deal with that issue. Unfortunately the Dockerfile won't look very friendly until Quay doesn't support multi-stage builds for Docker.

This is super complex. Can you just compile statically, e.g. go build -ldflags '-w -extldflags=-static'?

@pires OK, the complexity is gone with the help of Travis and multi-stage builds. Here's what you will need to do in order to get this working:

Enable Travis CI for this project.
Create a robot account at Quay and grab its credentials.
On the Travis CI settings for the project, set the DOCKER_USERNAME and DOCKER_PASSWORD environment variables to the credentials of the robot account.
Profit!

This will auto-push to Quay images built from the master branch and from every tag/release. PRs will be built but nothing is pushed to Quay. The final image size is about 58MB (which is 4MB for Alpine + 54MB for the nats-operator binary).


Simple: typo in VirtualAssitant.py check does not apply custom wakewords

In VirtualAssistant.py roughly 104 (I am working on a few things so about that area)
the if check has an extra o:
        if 'awake_with_keyowords' in kwargs:
            self.Keywords = kwargs['awake_with_keywords']
        else:
            self.Keywords = awake_with_keywords```

I fixed this in mine, but it is still in the main repo

Thanks for working on this, I was actually starting something similar before I found yours. I am currently working on a possible integration with elevenlabs. So that custom voices could be easily used if someone wanted to, without installing tts

I didn't know Evenlabs. Their voices are actually nice to hear. They might be a solid alternative to IBM's. The  point of tts is to clone jarvis voice in real time, tts results are not that refined but other better alternatives like TorToise takes too much time to generate. In the long run I need to explore other alternatives


Not getting object value in debug watch window for imported type "StatusBarItem"

VSCode Version:1.1.0-alpha
OS Version: Windows10

Steps to Reproduce:

Launch app and open VSCode extension project.
Follow instruction to create and debug extension.
https://code.visualstudio.com/docs/extensions/example-word-count
Add breakpoint in extensions.ts in updateWordCount() and start debugging.
Add _statusBarItem in watch window and verify object values.

Actual: Unable to get object value and showing up "Not available" message.
Expected: User should be able to get object value.

You should be able to inspect that value by adding this._statusBarItem to the watch


legacy support: handle if trainOpts doesn't exist

From: https://github.com/karpathy/convnetjs/issues/54#issuecomment-370259874

I think this will be solved with the next npm release


UI - Workflow credential - Provide easier way to enter credentials (may be drop down of tool name that requires auth).

Steps to reproduce the problem:

Create a workflow with credential.
Notice that I have to enter a credential as a tool url to a specific tool's credential  like - github.com/otto8-ai/tools/github/credential.

Expected Behavior:
Having to enter credential as a tool url to a specific tool's credential  is error prone.
Can we provide a drop down option with all tools (that require credentials) that user can pick instead?

not changing this.


Suggestion: Hide skills overview with a keypress

Currently, the skills overview takes up a lot of the screen. Would be lovely to be able to hide it with a bindable keypress :)

As a temporary solution you can change your Minecraft settings. The overview is tied to the GUI scaling option in Options -> Video Settings (GUI Scale: 2 seems pretty appropriate), but I'll add your consideration to the list. Merry Christmas!


Bugfix media_player volume_ up and down

Description:
I think that should be a better fix as #5265. It move logic to async like async_toggle. Some platform have overwrite that with device api stuff. So ee need support to overwrite that too.

This is a better solution. Good thinking.
Can you integrate the tests from #5265? These will make sure both behaviors work and don't get broken in the future.

Yeah, after we merge this, you can change/rebase your PR with unittest and I will merge it too 👍

@balloob done


chore: fix classname

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[ ] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

chore: 修复迭代过程的问题

[x] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #1304 (f8264cf) into develop (492d477) will increase coverage by 0.15%.
The diff coverage is 67.68%.

:exclamation: Current head f8264cf differs from pull request most recent head 8ceb1e9. Consider uploading reports for the commit 8ceb1e9 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1304      +/-   ##
===========================================
+ Coverage    57.94%   58.09%   +0.15%
===========================================
  Files          407      410       +3
  Lines        15371    15241     -130
  Branches      2931     2888      -43
===========================================
- Hits          8907     8855      -52
+ Misses        6187     6116      -71
+ Partials       277      270       -7

Impacted Files
Coverage Δ

src/calendar/const.ts
100.00% <ø> (ø)

src/cascader/cascader.tsx
64.00% <ø> (ø)

src/color-picker/color-picker.tsx
81.25% <ø> (ø)

src/date-picker/base/Header.tsx
7.57% <0.00%> (-0.37%)
:arrow_down:

src/date-picker/date-picker-panel-props.ts
100.00% <ø> (+90.00%)
:arrow_up:

src/date-picker/date-range-picker-panel-props.ts
100.00% <ø> (+90.90%)
:arrow_up:

src/date-picker/date-range-picker-props.ts
42.85% <0.00%> (-11.69%)
:arrow_down:

src/date-picker/hooks/useRange.ts
35.89% <ø> (ø)

src/date-picker/hooks/useSingle.ts
37.28% <ø> (ø)

src/date-picker/hooks/useTableData.ts
17.64% <ø> (ø)

... and 147 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


API for configuring JWT-based authentication

Vaadin should provide API for configuring JWT-based authentication:

issuer
expiration
JWSAlgorithm

The configuration API could be sth like
protected void setJwtSplitCookieAuthentication(HttpSecurity HTTP, String issuer, long expires_in, JWSAlgorithm algorithm)

Implemented in https://github.com/vaadin/spring/pull/900


Add Learnyounode by Node School to Node path

Learn you node is an excellent command-line course for learning Node.js. - It presents a problem and you solve it given the hints they give you, and explanations of increasingly complicated NodeJS features. Can even be done without an internet connection.
This PR has that class added to node, and the "B" removed from the Biotech folder name (--> biotech).

learnyounode: https://github.com/workshopper/learnyounode
node school has other similar "Workshoppers": http://nodeschool.io/


Wait for web fonts to load before rendering

Since our text is rendered with Canvas, any CSS font can be specified in our text.font block in the scene file. This opens the door to use custom fonts in our styles. But for web fonts (e.g. loaded via CSS, not built-in system fonts), the Canvas draw text API is unaware of a given font face's current load/validity state. This means web fonts can't be used reliably (often the first tile or two to render without the font but cause the browser to begin the font loading process; later tiles draw with the font once it has loaded). See #281.
The CSS Font Loading Module Level 3 provides an API for detecting font loads through the FontFaceSet object, but is only natively supported by Chrome and FF. FontFaceObserver provides a partial polyfill that can be used to detect font loads across all browsers.
Solution
This PR provides reliable web font support with the following flow:

text-based styles collect unique font face (family, style, weight) combinations per tile
When text sizes are requested (CanvasText.textSizes()), a new method CanvasText.loadFonts() is called to ensure that all fonts have been checked for availability
CanvasText.loadFonts() does the following:

For each new font face it hasn't seen yet, it creates a promise via FontFaceObserver that will determine the font face's availability (it will resolve if it is available, and reject if it is not)
A Promise.all() collection is returned for all currently pending font face checks for the tile.

Actual text rendering is unchanged whether the font face is available or not (it will fallback to a default font face if the requested one is not available). The purpose of checking for font face load status is to provide consistent rendering across tiles (e.g. all tiles have the same font face).

An example of POIs rendered with the Montserrat font:

Implementation Issues
The current version of FontFaceObserver only recognizes true web fonts in native FontFaceSet mode; common system fonts such as Helvetica actually timeout, creating an undesirable 3 second load penalty. This PR currently solves this via a fork that calls document.fonts.check() (which includes system font checks and returns synchronously) before following the polyfill's existing document.fonts.load() path: https://github.com/tangrams/fontfaceobserver/commit/5c260094d198b8128c9ff52de0d39bebd0d6d6ac. A question is out to the maintainer as to this method.
Additionally, FontFaceObserver would not load within a web worker as-is. The module itself is not needed within the worker (it requires DOM access that is not possible on worker threads), but due to the way that Tangram currently loads its workers (see #252), almost all code is shared the module is still loaded anyway (and was throwing an error). The least invasive way to solve this was to shim window and window.document in worker threads, to be empty but defined objects (which allows the module to load). This is however a brittle solution that may point to the advantage of smarter main/worker thread package delineation.

:heart: Montserrat

Superseded by #326.


Set up controller lifecycle methods

Create menu component
Create placeholder page for second stock synth
Add frequency analyzer destroy method
Add sequencer reset method
Add synth connect/disconnect controller methods
Style logo and menu
Add logo

coverage is dropping... hmmmm

Looks good.


feat: add privacy level [SD-781]

This PR adds the privacy level parameter to the public SDK.
I was only able to test the creation of the Synthesizer. The training fails because the DS lib version with the privacy layer is not yet deployed in the dev environment.

Here is a usage example:
from ydata.sdk.synthesizers import RegularSynthesizer, PrivacyLevel
from ydata.sdk.datasources import DataSource

X = DataSource.get('{ds-uid}')
synth = RegularSynthesizer()
synth.fit(X, privacy_level=PrivacyLevel.HIGH_PRIVACY)
sample = synth.sample(n_samples=50)

We would need an example of usage (see what has been done for the Anonymizer).

An example with the privacy level was added.


[NIFI-13876] - Adding context aware error banners

NIFI-13876
Now, instead of only having a single spot in the store for errors to land that drive banners... we have support for named/contextual spots. This helps support having 2 components on the screen with different errors in a banner at the same time.
<context-error-banner> is now the preferred way of adding error banners to a screen/dialog. It only takes the ContextErrorKey it is interested in as input. The component handles watching the store for errors of that key and clearing the store when it is destroyed and when the user hits the dismiss button too.

I am +1. If we decide the padding at the bottom is too much that is an easy fix.


Kernel discovering not locating python kernels

I have a "main" jupyter environment py3.8, and a secondary environment rap_env. I would like to use nb_conda_kernels to access the environment of the second within a jupyterlab server from the first.
I've installed nb_conda_kernels==2.3.1 on the first notebook, and ipykernel on both environments per the installation instructions, additionally running:
python -m ipykernel install --user --name env_name --display-name "env_name-k"

Checking jupyter kernelspec list shows all the kernels:
(py3.8) [ci411@cm23 ~]$ jupyter kernelspec list
Available kernels:
  conda-root-py    /home/ci411/.local/share/jupyter/kernels/conda-root-py
  py3.8-k          /home/ci411/.local/share/jupyter/kernels/py3.8-k
  python3          /home/ci411/.local/share/jupyter/kernels/python3
  rap_env-k        /home/ci411/.local/share/jupyter/kernels/rap_env-k

However using nb_conda_kernels list does not:
(py3.8) [ci411@cm23 ~]$ python -m nb_conda_kernels list
[ListKernelSpecs] Removing existing kernelspec in /home/ci411/.local/share/jupyter/kernels/conda-root-py
[ListKernelSpecs] Installed kernelspec conda-root-py in /home/ci411/.local/share/jupyter/kernels/conda-root-py
[ListKernelSpecs] [nb_conda_kernels] enabled, 1 kernels found
Available kernels:
  conda-root-py    /share/apps/anaconda3/2020.07/share/jupyter/kernels/python3

My configuration is as follows:
(py3.8) [ci411@cm23 ~]$ python -m nb_conda_kernels.install --status --verbose
Determining the status of nb_conda_kernels...
CONDA_PREFIX: /scratch/ci411/.conda/envs/py3.8
Entry points:
  - conda = nb_conda_kernels.discovery:CondaKernelProvider
  NOTE: entry points not used in Jupyter 6.1.7
Configuration files:
  - /etc/jupyter: <no files>
  - /usr/local/etc/jupyter: <no files>
  * $CONDA_PREFIX/etc/jupyter:
      jupyter_config.json: {
          "NotebookApp": {
            "kernel_spec_manager_class": "nb_conda_kernels.CondaKernelSpecManager"
          }
        }
      jupyter_notebook_config.json: {
          "NotebookApp": {
            "nbserver_extensions": {
              "nb_conda": true
            }
          }
        }
  - ~/.jupyter:
      jupyter_config.json: {
          "CondaKernelSpecManager": {
            "kernelspec_path": "--user"
          }
        }
      jupyter_notebook_config.json: {
          "NotebookApp": {
            "password": "sha1:e4e8c97497ff:e7a7087290cde39f76f4cfdffb35afae14df46eb"
          }
        }
Status: enabled

I can see the kernels listed from jupyter kernelspec list in my notebooks, but they seem to point to the host environments packages, defeating the purpose of switching. What am I missing in the setup of my environment that will allow me to switch between conda environments in jupyter? Thanks for your help.

Exporting both environments to yaml files and rebuilding them seems to have fixed the issue, although I'm unsure as to the cause/solution.


calling shap.TreeExplainer() in a loop for individual trees

When calling shap.TreeExplainer() in a loop, the following observation is puzzling: if I explicitly call tree.predict(), in the loop, the shap.TreeExplainer(tree) prints its message "Setting feature_perturbation ..." for each iteration in the for loop, which "proves" to me that it is being executed each time. But not when the tree.predict() is commented out. In that case, the message is printed only once, and I am worried that shap.TreeExplainer(tree) is not really executed every time?
A short notebook is posted here

That is odd. I think it must have to do with the warnings package or with how Jupyter is dealing with repeated stderr outputs...but I don't know. It is really executed since print(id(explainer)) changes through the loop.

Thanks, that is very good to know!


[MERGE ON 6/8] Beam Quest Blogpost

Fixes #27003
A couple of comments:

I don't think we need any images, but if we were to include one, it could be an image of the skill badge itself? Thoughts?
Currently, the last paragraph reads that if there are issues, they can reach out to the Beam community, in addition to qwiklabs support. Should we include that in this feedback workflow?

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @aaltay
R: @rszper

Thank you. I added a few comments, please take a look.

Thanks. Made the changes. I think we should include a pic of the skill badge for ease of reading. cc: @sysede

Thanks. Made the changes. I think we should include a pic of the skill badge for ease of reading. cc: @sysede

That is a great idea.

LGTM

retest this please


Creating a Sign up page(GSSoC 21)

Proposal
(A clear and concise description of what the proposal is.)
The webite of our project will be containing a sign up pagte in order to create an account.
it will ask for important information like name, mobile no, city, country etc
it will ask to make a username and a password

I like to work on this issue. Pls assign me this project

Done #19


ExecutionPlan visitor example documentation

Which issue does this PR close?

Closes #10012
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@alamb FYI

Thanks @alamb, I have updated.


Proposal: Convert to Typescript

@andjosh would you be open to migrating (me) the project to typescript.
The mistake/bug introduce with my previous refactoring would have been detected automatically. Then editors like VSCode, the Intellij-family or anything supporting LSP get supercharged.
Let me know what you think.

I'd be open to that!
I don't have much experience with TypeScript (I've used Flow), but if you're up for it, I'm on board.


ExpBoost time not accumulating

*Detailed description of the issue:
Hi, i was wondering if there is a way to accumulate time (not the multiplicator) from exp/money/point boost using the command ? It don't work by doing the command multiple time

Jobs version: <IP_ADDRESS>
Server Type (Spigot/Paper/etc): Paper
Server Version (using /ver): 1.18.1-152

There isint any command currently to add time to existing timer, you can only enable it for defined time or disable.


Update dartdoc to 0.24.1

Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v0.24.1
No change to current warnings or doc output.  The most significant change is @gspencergoog 's fix of a bug I accidentally introduced where dartdoc won't hard fail even when errors are detected.

@fkorotkov, is the build problem here a result of changing the Cirrus git client?  The target repo has a branch with the right name, so I'm not sure why git is failing to clone.

Also, it's able to clone just fine on all the other platforms...

@gspencergoog I don't see dartdoc-0.24.1 branch at the moment. Maybe it got removed before macOS started executing?

Wait. It's from a fork... Weird.

Yeah, it's not a branch on the flutter repo, it's a branch on the fork.

Wow. This is some big GitHub glitch. Here is the event that initialized the build (stripped some useless fields to make it more compact):
{
  "action": "requested",
  "check_suite": {
    "id": 20437609,
    "head_branch": "dartdoc-0.24.1",
    "head_sha": "8a8169be3c6ef96f1f8d19aff37ec98c76cf6824",
    "status": "queued",
    "conclusion": null,
    "url": "https://api.github.com/repos/flutter/flutter/check-suites/20437609",
    "before": "0000000000000000000000000000000000000000",
    "after": "8a8169be3c6ef96f1f8d19aff37ec98c76cf6824",
    "pull_requests": [

    ],
    "app": {
      "id": 3232,
      "node_id": "MDM6QXBwMzIzMg==",
      "owner": {
        "login": "cirruslabs",
        "id": 29414678,
        "type": "Organization",
        "site_admin": false
      },
      "name": "Cirrus CI",
    },
    "check_runs_url": "https://api.github.com/repos/flutter/flutter/check-suites/20437609/check-runs",
    "head_commit": {
      "id": "8a8169be3c6ef96f1f8d19aff37ec98c76cf6824",
      "tree_id": "224b8da7c3eec6c189d7b83f93aa68956983129a",
      "message": "Update dartdoc to 0.24.1",
      "author": {
        "name": "Janice Collins"
      },
      "committer": {
        "name": "Janice Collins"
      }
    }
  },
  "repository": {
    "id": 31792824,
    "name": "flutter",
    "full_name": "flutter/flutter",
    "private": false,
    "owner": {
      "login": "flutter",
      "id": 14101776,
      "type": "Organization",
      "site_admin": false
    },
    "fork": false,
    "clone_url": "https://github.com/flutter/flutter.git",
    "default_branch": "master"
  },
  "organization": {
    "login": "flutter",
    "id": 14101776
  },
  "sender": {
    "login": "jcollins-g",
  },
  "installation": {
    "id": 104037
  }
}

It's definitely states "head_branch": "dartdoc-0.24.1" and "full_name": "flutter/flutter" which makes it appear like this. And seems for a small period of time the ref actually worked since linux builds were able to clone it.
Reporting now to GitHub folks.

@gspencergoog it's some crazy weird stuff. 😲

@fkorotkov I didn't think about this earlier, but one possible source of the glitch is that I accidentally pushed my branch to the flutter/flutter repo due to a typo.  I then deleted the branch and uploaded it to my fork, which is where it is supposed to go.
It seems possible to me that GitHub might have a bug where if a branch of the same name is (or ever was?) present in the main repo it might give you that rather than the forked repo it is supposed to use...

OK, I made a copy of this PR: https://github.com/flutter/flutter/pull/23275
The odd thing THERE is that none of the CI is running on it, just the CLA/google check, WIP and the flutter-build check, no Cirrus checks.

I am still unable to make the checks run for MacOS on this PR.   @fkorotkov, if it is helpful for your debugging I can leave this PR open, otherwise I intend to close it in favor of #23275.

@jcollins-g I have one question though about you pushing here first and then to your fork. Did you update the PR to point to jcollins-g:dartdoc-0.24.1 branch manually?

@fkorotkov No.  All of the things I mentioned occurred before creating the PR.

This was landed in another PR.