pass the click event to the callback

The pull request https://github.com/lynndylanhurley/redux-auth/commit/b126755a09a31f998162ce71252342c74a0e32a5 broke the functionality of the EmailSignUpForm and EmailSignInForm in the default and the material-ui version. Both components expected an event object which was never passed to their callbacks causing that the submission was never done and ending into the exception
Uncaught TypeError: Cannot read property 'preventDefault' of undefined

This did not affect the bootstrap version since there the callback was passed directly to the react-bootstrap button which passes the event correctly to the callback.
Will fix issue https://github.com/lynndylanhurley/redux-auth/issues/34

Coverage decreased (-0.3%) to 96.669% when pulling 700379df8e190d068b93a392ad4580d4e78c6f74 on jlonardi:master into 7d0875e2770f7c5e9d390ce876bc26df72fd99b5 on lynndylanhurley:master.


Typescript (tsc) firebase-admin has no default export

firebase --version
3.18.4

"firebase-admin": "^5.12.0",
"firebase-functions": "^1.0.2",
"firebase-tools": "^3.18.4",

tsc --version
Version 2.8.3

In my firebase project I have a file with following import;
file.ts
import admin from "firebase-admin";
// rest of the code
Once I run tsc I am getting following error:

Starting compilation in watch mode...
functions/file.ts(1,8): error TS1192: Module '"/node_modules/firebase-admin/lib/index"' has no default export.

Is there any way to avoid the error?

OK I had to use
import * as admin from "firebase-admin";
as mentioned at https://github.com/Microsoft/TypeScript/issues/3337


Keep conformance artifacts on the top level

Signed-off-by: Petr Horacek<EMAIL_ADDRESS>
What this PR does / why we need it:
Without this change, artifacts are kept under actifacts/conformance
directory which prevents junit files from being exposed and introduces
an unneeded subdirectory.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Artifacts in the current state: https://gcsweb.apps.ovirt.org/gcs/kubevirt-prow/logs/periodic-kubevirt-push-nightly-conformance/1308001288461488128/
Release note:

/release-note-none

/lgtm
/approve


Segment* ops need more tests

Segment* ops need more tests. List of ops:

segment_max
segment_mean
segment_min
segment_prod
segment_sum
unsorted_segment_max
unsorted_segment_mean
unsorted_segment_min
unsorted_segment_prod
unsorted_segment_sqrt_n
unsorted_segment_sum

Unsorted_segment... has known problems
//2019/05/21 - Failing on AVX2/512 intermittently (Linux, OSX), passing elsewhere
//2019/05/21 - Failing on windows-x86_64-cuda-9.2 only -

I'm not quite sure these issues are still reproducible, since ops got overhaul recently. Can you please confirm it's still a problem?

Not reproduced locally. I will activate those tests.

Any news?


Update hyperkube base to v0.0.2

@Oats87 Per @superseb's suggestion it is just to rebuild the base to get apt-get updated

@Oats87 Per @superseb's suggestion it is just to rebuild the base to get apt-get updated

No, that makes sense, works for me! Thanks for the explanation

No, that makes sense, works for me! Thanks for the explanation


feat(playground-v2): supported tokens for playground

Screencast from 23-11-04 14:18:54.webm
It seems that the default token has a problem, doesn't show the list of tokens


feat: add rviz config and update ros2 control

Description

#118

This PR solves the issue by adding a configuration with TF and a robot model. The robot model is expected under hardware/robot_description which should be correct once https://github.com/aica-technology/frontend/issues/1053 is through.
Additionally, I updated to the most recent tags of ros2 control and its dependencies, so we'll have to see what updates we need to make to account for that

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

[ ] Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

Fairly happy with that, it seems that the required changes downstream are minimal and I've already tested a robot with a mock interface with this new base image

I would have preferred these two changes to be separate (rviz and ros2_control) but let's go for it 👍

You're right, especially if we want to revert stuff this would be cleaner


README refers to wrong/old script-name

The README states the script should be fss-scheduler.py, however the script actually is snapshot-scheduler-tool/fss-snapshot-scheduler.py

Thanks you. I will fix this.

This has been fixed. thank you


feat(l1): long running assertoor test on cd

Motivation
TODO
Description
TODO
Closes #920

This will be deprioritized for the moment in favor of #847

Closed due to priorities, it will be tackled in the future


Run integration test from pr

Maintainers will complete the following section

[ ] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered (check the PR coverage on codecov)
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

Codecov Report
Attention: Patch coverage is 71.42857% with 10 lines in your changes are missing coverage. Please review.

Please upload report for BASE (main@cc4675c). Learn more about missing BASE report.

Files
Patch %
Lines

tekton/integration_pipeline.go
0.00%
7 Missing :warning:

internal/controller/snapshot/snapshot_adapter.go
88.46%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage        ?   72.70%
=======================================
  Files           ?       42
  Lines           ?     3968
  Branches        ?        0
=======================================
  Hits            ?     2885
  Misses          ?      791
  Partials        ?      292

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Possibility to set cache time or to clear caches manually

The default cache time of the repo cache is 5 minutes and is hardcoded. We should discuss strategies for local development and testing where one might want to disable the cache, or reduce the time, or clear it manually with a button click / command.

Maybe as part of PackageRepository spec?

Hey Folks! Is this open for grabs?

hey @rakshitgondwal sorry, unfortunately it is not at this point.


Support Themes

Gazelle will continue to support themes. Users will be allowed to select a theme from their profile settings to personalize the basic look & feel of the site.
Some issues that need to be addressed:

Scope what a theme is from a technical standpoint:

Is it an entire stylesheet?
Is it a Meteor package? Or some other kind of module?
Is it a stylesheet that overrides a core stylesheet? And if so, what elements are considered "core" styles, & what elements are considered "themable"?

Currently, the Meteor build process concats all stylesheets together. Determine how to control this step & separate stylesheets as we see fit.

Determine how to inject stylesheets into the DOM at runtime using Meteor.

I think stylesheets being meteor packages might be a bit too much, as this will make it impossible for users to run their own stylesheets like they can now: by just inserting a CSS url.

@ajax-wcd Speaking to you a week or so ago I thought you had mentioned we wouldnt be supporting this on the rewrite?

@sneakysneakysneaky @thomwiggers @rhomes-wcd Officially we will only support one or two stylesheets, most likely a light and dark variant.
However we will be introducing new tools to replace/coexist with the "Laboratory" forum where users can share their custom stylesheets and choose to apply stylesheets created by others.

If the site is going to support more than one stylesheet, either created by us or by third parties, this issue applies.

@sneakysneakysneaky Indeed, just wanted to clarify.

if we organise our rule using https://smacss.com/book/categorizing, we could still have one code pro module and one theme that will overwrite above rules ??

We're using BEM, not SMACSS. But i believe the principle is the same.
I fear the concept of a core stylesheet. It feels very much like a legacy concept to me. Runs the risk of too much of a footprint. Rules will get created in the core stylesheet just to be overridden & never used in the theme stylesheet. Even if we keep the core stylesheet to a bare minimum, some styles will inevitably be overridden into oblivion.
I am much more in favor of theme = stylesheet. Keep markup as semantic as possible. Let authors style it how they will. The code for the default theme will be open source; authors can use that as a base.


Invalid eslint error for "import/no-extraneous-dependencies" when it's reference self

{
  "name": "@ts/deferred",
  "version": "1.0.0",
  "description": "The deferred library implemented in Typescript",
  "license": "MIT",
  "scripts": {
    "build": "yarn run build:esm && yarn run build:cjs && yarn run build:types",
    "build:esm": "tsc -p tsconfig.mjs.json",
    "build:cjs": "tsc -p tsconfig.cjs.json",
    "build:types": "tsc -p tsconfig.types.json",
    "test": "jest --config ../../jest.config.ts"
  },
  "module": "./dist/mjs/index.js",
  "main": "./dist/cjs/index.js",
  "types": "./dist/types/index.d.ts"
}

Error:
[{
	"resource": "/c:/work/tslibs/packages/deferred/test/deferred-in-js.test.js",
	"owner": "eslint",
	"code": {
		"value": "import/no-extraneous-dependencies",
		"target": {
			"$mid": 1,
			"external": "https://github.com/import-js/eslint-plugin-import/blob/v2.26.0/docs/rules/no-extraneous-dependencies.md",
			"path": "/import-js/eslint-plugin-import/blob/v2.26.0/docs/rules/no-extraneous-dependencies.md",
			"scheme": "https",
			"authority": "github.com"
		}
	},
	"severity": 8,
	"message": "'@ts/deferred' should be listed in the project's dependencies. Run 'npm i -S @ts/deferred' to add it",
	"source": "eslint",
	"startLineNumber": 1,
	"startColumn": 22,
	"endLineNumber": 1,
	"endColumn": 45
}]

Self-reference only works with the "exports" or "imports" field, which this plugin doesn't yet support.
You shouldn't be able to self-require the package otherwise.

Yarn workspaces, and I assume npm and pnpm workspaces too, installs all local packages to node_modules/package-name.
In the tests of a package I want to reference the built package. The file
packages/my-package/__tests__/my-package.test.js
imports my-package (resolving to packages/my-package/dist/index.js), which triggers import/no-extraneous-dependencies.

@jacobrask yes, in that case it should Just Work. If it doesn't, and you can run the node repl and require.resolve(specifier) works, then please file a separate issue.

Self-referencing only works in node via the "exports" or "imports" fields, which this package (via resolve) does not yet support - but will hopefully, soon.
It should not be expected to work otherwise.

In my case, since it is a custom rollup project, it works as expected, but I get your point, deleting my comments to prevent bad practices/habits. :+1:

Self-referencing only works in node via the "exports" or "imports" fields, which this package (via resolve) does not yet support - but will hopefully, soon.
It should not be expected to work otherwise.

@ljharb Do we have an idea on when this will be added to this plugin? or waiting on someone to contribute this?

@rmarkins-godaddy it needs to be added to resolve, and i'm working on the reverse algorithm for list-exports first to serve as test fixtures.
Since it's a best practice to make packages backwards-compatible to pre-exports node, i'd hope this feature gap is minimally impactful in the meantime.

What's the status on this? It's already been a year and it seems to be still unsolved. I would have to guess that resolve still doesn't support it?

@lxsmnsyc it's been 4 years since node shipped "exports", and yes, resolve still doesn't support it.

@ljharb how is resolve different from, say, resolve.exports package? or is it possible to transition to it?

There's a lot of functionality we'd need - in particular, we'd need the ability to lint against a particular version of node's support, and nothing in the ecosystem provides that (resolve, however, will).
No matter how much longer it takes, I'm unlikely to switch from resolve.


Login and sign up page with beautiful design

this is a template which the login and sign up page would be based on the right hand side blue circle would be replaced by a 3d design.
I'm in GSSoC'23.
Do assign me this issue.

Ohk that's looking great

And also have to add some framer Motion animation in 3D images ok

sure i'll try my best, btw what would be the deadline for this as i have some college work to take care of

This is in critical label but I can give you last 2-3 days

sure that's fine

Do provide appropriate labels to this issue


Is there way to make MemFS have intellisense for js/ts files?

I tried this sample:
https://github.com/Microsoft/vscode-extension-samples/tree/master/fsprovider-sample
It's awesome but I find it lost intellisense for js/ts editing. Is it possible to make it work with intellisense in current vscode?

Duplicate of #253


npm shrinkwrap: extraneous history dependency in node_modules

Way to reproduce this:
cd examples/webpack-example && npm i
npm shrinkwrap

Found Error
➜  webpack-example git:(master) npm shrinkwrap
npm ERR! Darwin 15.0.0
npm ERR! argv "/Users/lizhiye/.nvm/versions/node/v4.2.1/bin/node" "/Users/lizhiye/.nvm/versions/node/v4.2.1/bin/npm" "shrinkwrap"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! extraneous<EMAIL_ADDRESS>/private/tmp/material-ui/examples/webpack-example/node_modules/material-ui/node_modules/history
npm ERR!

Not sure which incurs this?

even npm ls gives the same error

Deps in 0.13.2
"dependencies": {
    "inline-style-prefixer": "^0.3.3",
    "lodash.throttle": "~3.0.4",
    "lodash.debounce": "~3.1.1",
    "react-tap-event-plugin": "^0.2.0",
    "react-addons-transition-group": "^0.14.0",
    "react-addons-update": "^0.14.0",
    "react-addons-create-fragment": "^0.14.0",
    "react-addons-pure-render-mixin": "^0.14.0",
    "warning": "^2.1.0"
  }

Output of npm ls for material-ui
├─┬<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>extraneous
│ ├─┬<EMAIL_ADDRESS>│ │ ├──<EMAIL_ADDRESS>│ │ └─┬<EMAIL_ADDRESS>│ │   ├─┬<EMAIL_ADDRESS>│ │   │ ├──<EMAIL_ADDRESS>│ │   │ └──<EMAIL_ADDRESS>│ │   ├─┬<EMAIL_ADDRESS>│ │   │ ├─┬<EMAIL_ADDRESS>│ │   │ │ ├─┬<EMAIL_ADDRESS>│ │   │ │ │ └──<EMAIL_ADDRESS>│ │   │ │ └──<EMAIL_ADDRESS>│ │   │ └─┬<EMAIL_ADDRESS>│ │   │   ├──<EMAIL_ADDRESS>│ │   │   ├──<EMAIL_ADDRESS>│ │   │   └──<EMAIL_ADDRESS>│ │   └──<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ ├──<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └──<EMAIL_ADDRESS>
Why is<EMAIL_ADDRESS>extraneous even there

That's because of the devDependencies. Also the dependencies are wrong since we moved some of them out of peerDependencies in the main package.json.

@oliviertassinari thanks. Any idea how to fix this?

This PR should fix them https://github.com/callemall/material-ui/pull/2160.

@grobot I'm glad to hear it. Sorry, we have merged a lot of PRs lately.

@grobot How did you test with v0.13.2
Did you build material ui locally?

@vijayrawatsan Just clone the master branch and go to example.

@oliviertassinari @grobot
Thanks guys.

@oliviertassinari thanks for the fix! When can we expect a new version?  Thanks

@oliviertassinari Can we have a new patch release for this. This is an important requirement for anyone who want to release his/her code to production.

@vijayrawatsan I can't release.
I'm gonna fix the server side rendering. Then I think that I would be good to do a fix release @shaurya947.


⚠ Samsung has degraded performance

In 9a8ed33, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2557 ms

Resolved: Samsung performance has improved in 77ef68d.


flutter plugin xcode build

Failed to build iOS app
Error output from Xcode build:
↳
** BUILD FAILED **
Xcode's output:
↳
=== BUILD TARGET Runner OF PROJECT Runner WITH CONFIGURATION Debug ===
ld: framework not found Flutter
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I have the same exact problem!! Have you solved it yet? Can anyone help PLEASE!

reinstall the flutter sdk

yup, I did that already and it worked. thanks!


If statements in Handlebars

I want to add an if statement to check if the navigation label equals a certain ...label... Is this possible? (The idea is if it equals a specific static post in the navigation, it would add a dropdown menu).
I assumed something like {{#if navigation.label === "value"}} would work, but that's more of javascript logic than handlebars.

This is what i have right now to do what I want:
'{{#foreach navigation}}

{{/foreach}}'
I am hoping there is a more elegant way to do this...

can i see into this one

What is your use case for this? Handlebars very intentionally comes without
if helpers.
On Oct 18, 2015 2:50 PM, "BlehDes"<EMAIL_ADDRESS>wrote:

can i see into this one
—
Reply to this email directly or view it on GitHub
https://github.com/TryGhost/Ghost/issues/5966#issuecomment-149008582.

I attached a jpg with the code. It essentially allows me to shiv a sub-menu into the Ghost populated navigation. Since Ghost doesn't do it natively (or archiving, listing of blogs, etc except RSS), I had to find a way to get it to work.
It works live www.builtbygoat.com (albeit the CSS was a pain to finagle).

It isn't a pretty solution. I was hoping for a better alternative. I haven't really played with handlebars as much yet, just the few snippets Ghost uses.

I'm not sure where to register helpers in Ghost, but in Handlebars this can be solved with a eq helper like this:
Handlebars.registerHelper('eq', function(a, b) {
  return a === b;
});

And then in your template with Handlebars use subexpressions:
{{#if (eq a b)}}
  ...
{{else}}
  ...
{{/if}}

Good call topaxi.
We would have to add to ghost/core/server/helpers/ to create this kind of functionality. Aka, get it into the repo (or every time we'd upgrade, we'd have to redo it).
Lemme see how to go about fiddling with the helpers.

Yeah, looks like the only real thing would be to add a helper that would allow you to do:
{{#foreach navigation}}
{{#if (eq a b)}}
subnav
{{/if}}
{{/foreach}}

Hi @kaiserhase, this sort of logic is, as you have discovered, not possible with handlebars. The Ghost theme documentation is here: http://themes.ghost.org and the handlebars documentation is here: http://handlebarsjs.com/
In the short term your best bet is to use JavaScript, the way you have done. Ghost's navigation menu exists to serve the majority of use cases for blogs - which is a very simple flat menu. If that's not what you need, then the expectation is you would hard code your own menu that fits your needs.
If you have any further questions, please join the #themes channel of our slack community. GitHub is for tracking bugs & issues with the Ghost software.

sigh

I was considering replacing the if statements with case statements, I was
once in that kind of situation
On Sun, Oct 18, 2015 at 6:45 PM, Brett<EMAIL_ADDRESS>wrote:

sigh
—
Reply to this email directly or view it on GitHub
https://github.com/TryGhost/Ghost/issues/5966#issuecomment-149025849.


Manually upgrade Python to avoid brew failures

It looks like perhaps some sort of upgrade rename around Python/Python 3 has
gone on so I'm hoping this might help.
Deliberately not signed off (yet) because I think our bot is broken and I want to
test that too.

I've converted this into a proper workaround (details in the new code comment) for now, please review.
I'll raise a reverting PR as soon as this is merged to provide a canary for the base image being fixed.


Loading Benchmarks

🚀 Pull Request
Description

Adds our tried and tested (offline and in iris-esmf-regrid) framework for stable generation of test data for benchmarks.
Introduces a method (create_um_files()) for generating synthetic FF/PP/NetCDF files for benchmarking, using Mule.

This avoids reliance on [potentially enormous] real files.
We can size the files appropriately for benchmarking purposes.
A useful tool when following up on performance regressions that need more info.

Ports our existing loading benchmarks from the offline benchmark suite.
With some adaptations to use the new synthetic data generation.

I believe synthetic FF file generation removes the last major blocker to fully migrating our remaining offline benchmarks onto GitHub 🤞

Consult Iris pull request check list

Have decided against caching the generated benchmark data in the GHA job - GHA relies on working out whether or not to cache at the start of the job, it is not possible to check for changes during/after. This therefore forces us to always cache, which adds time/resource when 95% of the time it would be unnecessary.
Given benchmarks run during CI will necessarily be quick - i.e. small synthetic data - it is quicker and simpler to generate data files fresh at the start of the GHA job. The benchmarks at least have the intelligence to re-use the files once they are there.

I don't know how complicated your data gen scripts are, but it might be the case that regen is actually faster than restoring from cache if CPU gen speed > network IO speed.

I don't know how complicated your data gen scripts are, but it might be the case that regen is actually faster than restoring from cache if CPU gen speed > network IO speed.

Exactly. My thoughts, but more succinct!

Does it make sense to use real data in some of these benchmarks as well as synthetic (as a sanity check perhaps?). I believe that the benchmarks already have access to the test data

Does it make sense to use real data in some of these benchmarks as well as synthetic (as a sanity check perhaps?). I believe that the benchmarks already have access to the test data

We've seen a few issues where a pp file with lots of layers is significantly less performant than one with a few - could we try another shape (if I understand what's here correctly) that's not very wide but quite deep?

@wjbenfold even if I make no more changes to this PR, I'm already worried about:

The CI runtime
The size of the changes in this PR

Better coverage is always good in principle, but benchmarks take a long time to run. So to solve Point 1 I have some future plans for splitting benchmarks into categories: CI / semi-regular / on-demand, but the complexity of that runs up against Point 2. So I'd like to lay that groundwork in a future PR, not this one, after which the whole team will hopefully find it much easier to expand benchmark coverage without my help/interference.

Thanks @pp-mo!


Can't create vms in new regions

Description
I'm using azure cli to create vm in different regions. I 'm trying to create vm in germanycentral, southafricawest and centeralindia. According to this link this regions are available. When I'm trying to create vm in these regions I received the following error:
ERROR: Deployment failed. The provided location 'centeralindia' is not available for resource type 'Microsoft.Network/virtualNetworks'. List of available regions for the resource type is 'westus,eastus,northeurope,westeurope,eastasia,southeastasia,northcentralus,southcentralus,centralus,eastus2,japaneast,japanwest,brazilsouth,australiaeast,australiasoutheast,centralindia,southindia,westindia,canadacentral,canadaeast,westcentralus,westus2,ukwest,uksouth,koreacentral,koreasouth'.

Environment summary
Install Method: How did you install the CLI? (e.g. pip, interactive script, apt-get, Docker, MSI, nightly)
Answer here: pip
CLI Version: What version of the CLI and modules are installed? (Use az --version)
Answer here:2.0.12
OS Version: What OS and version are you using?
Answer here: Ubuntu 16.04.2 LTS
Shell Type: What shell are you using? (e.g. bash, cmd.exe, Bash on Windows)
Answer here: bash

Additionally, centralindia is also listed in the error message as being available for that resource type. @yugangw-msft do you think this is a service bug or are we compiling an erroneous help message?

I 'm trying to create vm in germanycentral, southafricawest and centeralindia

The centeralindia has a typo, and the error message calls out the correct spelling of  centralindia


STORM-1600: Do not report exceptions after jvm shutdown

@HeartSaVioR  - Here is the proposed change. Can you suggest some way to reproduce a scenario which I could also add as a test case?

Regarding test case, we're trying to shutdown JVM and throwing exception concurrently, so I wonder we can make it consistent. I also don't have an idea regarding the test which tries to shutdown JVM, and wonder it can be passed without affecting other tests.


Develop builds are on travis-ci.org, not github

Resolves #2177
(Note the changes to the contributors list are line-endings only)

This is incorrect, develop builds do not seem to be available on travis either


GUI Font

Load the Cyber raygui font. see if there's a way to include the font in the binary.

Here it is the portable style including the font: style_cyber.zip
To use it on your code:
#define RAYGUI_IMPLEMENTATION
#define RAYGUI_SUPPORT_ICONS
#include "raygui.h"                     // Required for: IMGUI controls

#undef RAYGUI_IMPLEMENTATION            // Avoid including raygui implementation again
#undef RICONS_IMPLEMENTATION            // Avoid including raygui icons data again

#include "style_cyber.h"                // raygui style: cyber

Call on init:
GuiLoadStyleCyber();


Unify rollup configs

WHY are these changes introduced?
As part of joining the repos, we also started using rollup across the board. However, to make the changes smaller, I chose not to change the existing build pipelines for the previous shopify-api-js repo packages, which meant we had a bit of duplication.
WHAT is this pull request doing?
Using the same rollup-utils functions to build all of the packages.

@paulomarg tested with shopify-api!


docker logout error with private registry

Describe the bug
docker logout from a private registry gives an error.
To Reproduce

docker login to a private registry (all variable and site address below need to be replaced with your docker private registry login credential)

docker login -u $USER -p $PASS https://PRIVATE.DOCKER.REGISTRY
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Login Succeeded

try logout

docker logout
Removing login credentials for https://index.docker.io/v1/
WARNING: could not erase credentials:
https://index.docker.io/v1/: error erasing credentials - err: exit status 1, out: `The specified item could not be found in the keychain.`

Expected behavior
I expect logging out will be finished without error (successful logout).
${HOME}/.docker/config.json has an entry of my private registry after login, but not cleared after a failed logout.
cat .docker/config.json
{
	"auths": {
		"PRIVATE.DOCKER.REGISTRY": {}
	},
	"credsStore": "osxkeychain"
}%

Diagnostic report (required)
OrbStack info:
Version: 0.15.1 (150100)
Commit: d9dbc033855331b22ecd7fb67da89b9ca5fa9d0f (v0.15.1)
System info:
macOS: 13.4.1 (22F82)
CPU: arm64, 8 cores
CPU model: Apple M1 Pro
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2023-07-31T06-46-57.628136Z.zip

Screenshots and additional context (optional)
/Applications/OrbStack.app/Contents/MacOS/xbin/docker -v
Docker version 24.0.5, build ced0996

This is standard Docker behavior, not specific to OrbStack. docker logout is for the default registry. You have to use docker logout private.docker.registry instead.

This is standard Docker behavior, not specific to OrbStack. docker logout is for the default registry. You have to use docker logout private.docker.registry instead.

I see. Thanks for a quick reply!


Add cover to BMZ export

During a BMZ export, there is the possibility to pass a cover to the bioimage.io core library. The cover then ends up being show in the bioimage model zoo card corresponding to the model.
By default, the cover is generated automatically from the input and output arrays. It would be nice to allow users to add their own cover.

Note that the cover is no longer generated automatically by bioimage.io.core, so we should do it ourselves.


fix(coagents-research-canvas): remove container property for ResearchCanvas

What does this PR do?
This PR fixes an issue where the ResearchCanvas component had the container property applied. As such, its size was bound to the screen size. This was not aligned at larger screen sizes which causes a gap between the ResearchCanvas and CopilotChat.
Checklist

[X] I have read the Contribution Guide
[X] If the PR changes or adds functionality, I have updated the relevant documentation

Replaced by #928


suggest: props can be used without declare is better

In my case, I always define an component which is suit for almost all scene. And always I will extend this component to fit one project. In vue, props should be declared in component, which makes it complex, I need to declare the same props again. So why not just like rect, props just used for validation.

Do you define your function with () signature, and then use arguments?

@simplesmiler what's that mean?

I understand the convenience of this in react world.
However, the props of vue components are assigned under this while react has dedicated property this.props. So allowing to pass props without declaration possibly occur naming conflict with data, computed or methods.

@ktsn Yeah, this is a problem. But in my opinion, especially in vue2.0 which we can use jsx style, my issue is more usefully. besides we can use props validation to avoid your problem or just like react put props in props object.
Also, vue is great, and I will use vue2.0 to restructure my app, I just want it get better😁

Like @ktsn explained, this is not feasible in Vue.
And imo it's more maintainable to always declare props.


Add ACHORDION_TYPING_STREAK_TIMEOUT

This change adds a new feature to disable mods when in typing streak.

It seems like this can be useful, please let me know if that makes sense for Achordion.

@TristanCacqueray thank you for the contribution! A typing streak timeout is a great addition.
In order to merge this, I need you to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. You (or your employer) retain the copyright to your contribution. This simply gives permission to use and redistribute your contributions as part of the project. See https://cla.developers.google.com/ for your current agreements on file or to sign a new one. Thanks!

@getreuer sure, that should be good now.
Well I can't tell this really works as expected, it seems like it, but it would be great if you can check that is correctly implemented.
Thanks in advance.

@getreuer thank you for the feedback, I'm glad this is helpful. I have updated the PR with your suggestions, though I haven't tested the change on my keyboard yet.

You're welcome, thanks again for sharing your keymap and its features!


WIP: Performance Enhancements

Not yet ready to merge, need to clean up some and add more comments to new functions.
I did some profiling with perf on the benchmarks. I found that clone()ing the input Vecs was adding a lot of overhead, so I changed the benchmarks to accept slices instead. I also found that the read benchmark wasn't unwrap()ing the Result<Reader, _>, so it wasn't actually running.
Please let me know if you have any objections, concerns, questions, etc.!
Here is a high level list of changes made:
Read

Check if the write_schema and read_schema are the same. If so, don't run schema resolution. This improved read time by ~50%.
Added an internal Block<R> struct that can read byte blocks into an internal buffer.
This reduces the number of allocations that occur. Block<R> then incrementally decodes Value objects, instead of storing them in a VecDeque<Value>.
This further improved read time by ~30%.
Reduced recursive calls, allocations and moves in decode. ~10% improvement.

Write

encode was spending a lot of time moving data around. I added an encode_ref function which operates on a &Value. This improved performance as well (will provide numbers soon).
Added pub fn extend_from_slice(&mut self, slice: &[Value]).

Other Benchmark Changes

Added a comparable JSON benchmark which uses serde_json for comparison.
Added a bench_from_file function and a file from the goavro repository for comparison.

Results
These tests were compiled with the latest rust nightly use the command:
cargo +nightly bench -- read

These were all captured on my local machine, which was mostly idle other than running the tests.
Running Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz on Ubuntu 16.04.
 -- In the future if I have more contributions I'll try to make the pull request smaller in scope so the review isn't as arduous.
I'll address your latest comments, and I'd like to document the methods added to Writer to the same standard as the others before I remove the WIP status.


Typo fixes

Not sure why the diff doesn't highlight the specific changes, but they are:

annecdote -> anecdote
pen paper -> pen and paper

Hmm, it looks like the build is broken, btw:
$ npm test

><EMAIL_ADDRESS>test /home/ubuntu/Eve
> ./test.sh

sh: 1: ./test.sh: not found
npm ERR! Test failed.  See above for more details.

npm test returned exit code 1


Fix multiple yaml parsing with the same key

Using seqerakit launch1.yaml launch2.yaml launch3.yaml fails because the parse_all_yaml method doesn't merge lists for overlapping keys but instead, the merged data is overwritten by the last list (i.e. last yaml read in). We need to fix the logic here to account for overlapping top-level keys.

Fixed with #79


How to make the browser not automatically open on grunt serve

I have a kind of silly problem. I'm running all my development on a VMware virtual machine (Debian) and every time I run grunt serve it open up Iceweasel on the VM, which is both annoying and not needed as I'm viewing it from my host machine. I've looked through the Gruntfile.js but I haven't been able to spot where it automatically makes the browser start. Any way to disable this?

Ran into the same problem on most recent build, but browsersync was opening the browser automatically. Had to add open: false as an option to browsersync to fix.


Implement Bollinger Bands in Ninjabot Chart

To implement Bolinger Bands, we need to implement a new Struct similar to EMA: https://github.com/rodrigo-brito/ninjabot/blob/516e75064107daf73495bf1d091b5dc1cba18c09/plot/indicator/ema.go
The struct must implement the following interface:
type Indicator interface {
	Name() string
	Overlay() bool
	Metrics() []IndicatorMetric
	Load(dataframe *model.Dataframe)
}

BB Indicator contains 3 metrics (upper band, mid-band, and lower band)
You can use TALIB to get these values: talib.BBands(...)
To test the new indicator, you can include it here:
https://github.com/rodrigo-brito/ninjabot/blob/516e75064107daf73495bf1d091b5dc1cba18c09/examples/backtesting/main.go#L58-L63
And run: go run examples/backtesting/main.go

Hi, sir, can I please have the pleasure to implement that?

Hi, sir, can I please have the pleasure to implement that?

Shure!


US ID14: As a player I want to know how much time remains until the answer phase starts in order to be able to prepare myself to click on the correct bubble.

[ ] The round consists of a fixed number of questions.

[ ] A question is shown for a limited amount of time.

[ ] For every question there is a countdown tracking how long the question will remain displayed.

[ ] After the countdown finishes, the answer bubbles appear.

proposed additional tasks:
Backend:
upon a call form the client, a timer for an indiviual question is initialized and started
the timer is comunicated to all players via socketio

@a1ps chammer schliesse, oder?


Add security_audit feature

Create AUDIT log entry when datastore keys are being decrypted either manually (via API which is used by the st2 CLI) or when a workflow/action is triggered and the action's metadata or parameters accesses a secret from pack config or decrypts a datastore key.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.David seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Please also address the CLA issue here
https://github.com/StackStorm/st2/pull/5594#issuecomment-1076876956

I was reviewing this on my phone before. I just pushed a commit to move the audit logs slightly so I don't have to keep annoying you (sorry!). @dmork123 what do you think about this? If you're happy with what I did, I'll merge it.

I was reviewing this on my phone before. I just pushed a commit to move the audit logs slightly so I don't have to keep annoying you (sorry!). @dmork123 what do you think about this? If you're happy with what I did, I'll merge it.
Hi @cognifloyd
No worries thats all good thank you for your prompt responses I am happy with this, please merge it thank you :)


How to run bore on a Kubernetes cluster

I added a README file containing the steps needed to set up bore on a Kubernetes cluster. I also included an example architecture diagram. Please check if the instructions are clear enough and/or correct.

Oh wow, thanks for the detailed instructions. This is really quite a lot. I don't know if I have enough Kubernetes knowledge to review this. It's really a lot of complicated configuration :(

Ok, thank can work too. I'll massage it into a Gist and let you know.


[Browser] onTabChanged event

Hi
Can you explain how to get a moment when tab is switched? onTransitionEnd is fired only if animateTransitions is true but how get the same result when onTransitionEnd is false. I use it for restore scroll position.
Thanks.

I can use onChangeIndex.


Look Into Bun as a potential runtime

Currently, Bun is not able to handle the existing app with the issue tracked here, wait for the update, need to wait and watch for the update
https://github.com/oven-sh/bun/issues/4708
cc @DerekRoberts

looks like this is now fixed, will give it a shot cc @DerekRoberts


Advanced Metric Calculator Classes

To calculate multiple distances at once the design below was proposed by Pawel.
`class Scorer:
"""Provide a set of callable metrics to score trees, given curried metrics."""
def __init__(self, metrics: dict[str, Callable[[TreeNode], float]]) -> None:
    """Initialize Scorer with a set of metrics curried with a TreeNode."""
    self.metrics = metrics

def score(self, t: TreeNode) -> dict[str, float]:
    """Score a tree with the metrics."""
    return {name: fun(t) for name, fun in self.metrics.items()}

class Analyzer:
"""Analyze trees from MCMC runs given a Scorer."""
def __init__(self, scorer: Scorer) -> None:
    """Initialize Analyzer with a Scorer."""
    self.scorer = scorer

def analyze(self, mcmc_samples: PureMcmcData) -> dict[str, list[float]]:
    """Analyze trees from MCMC runs given a Scorer."""
    scores = {name: [] for name in self.scorer.metrics.keys()}
    for tree in mcmc_samples.trees:
        for name, score in self.scorer.score(tree).items():
            scores[name].append(score)
    return scores

`
Originally posted by @pawel-czyz in https://github.com/cbg-ethz/PYggdrasil/pull/86#discussion_r1235311754

Outdated - can be archived.


Apparent race condition is causing failures

Submitting requests quickly to a mock that processes requests through a callback class triggers NoSuchElement: null Exceptions stemming from RequestLogFilter.onRequest(...)'s used of the EvictingQueue.
Reproduction:

Create a mock with a callback class that does some moderately time consuming task (such as reading a fixture from disk; or sleep for ~10 seconds before responding to test)
submit requests to that mock at a moderate frequency (15 second delays were sufficient in our app; using multiple threads to send concurrent requests, or using a load testing tool should be sufficient although I have not tried that.)
Observe exceptions of the form:

java.util.NoSuchElementException: null
	at java.util.ArrayDeque.removeFirst(ArrayDeque.java:280)
	at java.util.ArrayDeque.remove(ArrayDeque.java:447)
	at com.google.common.collect.EvictingQueue.add(EvictingQueue.java:105)
	at org.mockserver.filters.RequestLogFilter.onRequest(RequestLogFilter.java:41)
	at org.mockserver.filters.Filters.applyOnRequestFilters(Filters.java:33)
	at org.mockserver.mock.action.ActionHandler.processAction(ActionHandler.java:27)
	at org.mockserver.mockserver.MockServerHandler.channelRead0(MockServerHandler.java:179)
	at org.mockserver.mockserver.MockServerHandler.channelRead0(MockServerHandler.java:41)
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:307)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:293)
	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHand
...

This appears to be happening because the filter and the queue's underlying that filter are not thread-safe, allowing multiple threads to pass the size check in EvictingQueue.add(E .){...} before invoking delegate.remove().  Thus, delegate.remove() is being called when delegate.size() == 0, triggering the exception seen above.
The workaround we've found is to slow the request frequency to (an essentially unusable) 1 request / minute.
I apologize for not submitting a minimal test example; ran out of time today while debugging this crash.  Since the RequestLogFilter has synchornized keywords (in comments) it seems like this is probably due to a recent change that may be easy to revert, or to finish the transition to making this class thread safe.
In short: I think you all may know how to fix this quickly an easily without a minimal example, if not, let me know and I'll try to cook one up.

Closing as now fixed, I don't believe the fix is in the current RELEASE version.  However I will issue a new RELEASE version the next few days once a TLS workout is complete to handle badly behaving TLS servers.

Thanks!
On Wed, Jun 21, 2017 at 9:35 AM James D Bloom<EMAIL_ADDRESS>wrote:

Closed #300 https://github.com/jamesdbloom/mockserver/issues/300.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jamesdbloom/mockserver/issues/300#event-1133264056,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPusFvsBsqWaAWh1NpN9XZlkN98GGofks5sGUZSgaJpZM4K_p7M
.

Does release 3.10.8 fix this?
And if not, in which version is the fix expected?
Thanks in advance! :)


Enable web apps to open external databases they don't own

When opening an external database as a user, it's necessary to authenticate with the database.
When in a web application, this authentication must happen via the account-web-vault flow which prompts the user to scan a QR code and have the Verida Wallet generate accessToken and refreshToken for each endpoint the connecting account uses for the requested context.
However, when opening an external database, the endpoint that requires authentication is no necessarily (in fact unlikely) one of the endpoints the account is associated with.
As such, it's necessary to make the following changes:

account-web-vault support making an authentication request, which specifies storage node(s) to authenticate with for a given context
client-ts support supplying an endpoint(s) when opening an external database
account support connecting to an account for a specific endpoint
Verida Wallet support authenticating with a storage node endpoint sent in the QR code auth request

This scope of work is incorrect.
Instead create a new PreConfiguredAccount in @verida/account-node that allows injecting authContext configurations, but doesn't load them from anywhere.


Special support for Python interop

Pull Request Description
Fixes #7418 by adding specialized date/time/zone conversions in EpbLanguage before calling into Python.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] All code follows the
Scala,
Java,
All code has been tested:

[x] Unit tests have been written where possible.

There is a Date_Time_Spec.enso:456 failure on Mac OS X that needs to be investigated.

There is a Date_Time_Spec.enso:456 failure on Mac OS X that needs to be investigated.

Wow that is weird

Looks as if the date-time value fails identity check?
We can try to repro it locally running on macOS and overriding the timezone to somewhere in USA (I'm not sure if mac or Timezone are more important here) and try to debug it. Maybe the true issue is something else and I'm reading the report wrong (could have the line numbers shifted after this test was run?)

Looks as if the date-time value fails identity check?

self date gets converted to Enso and other stays Pythonian as following picture shows:

We can try to repro it locally running on macOS and overriding the timezone to somewhere in USA (I'm not sure if mac or Timezone are more important here) and try to debug it.

I tried on my Mac (with Europe/Prague zone) and alas, there is no failure...


defaultIfEmpty micro perf test broken for Rx 4.0.0

Currently it's not returning any value at all.

Seems I got some clue.. will update PR.


test for --shutdown-on-slot-synced

details here - https://github.com/input-output-hk/cardano-node/pull/3670

I don't expect it to be a widely used functionality but like anything we make publicly available, it might and will be used by the community too, so having a test for it in our regression would make sense.
I agree that compared with the other tasks in our backlog this has a lower priority.


Layer ordering

Hey again,
Do you have a suggested approach to ensure layers are always ordered correctly on z axis?
Here is a paste of my messy map JSX:
const journeyTotal = journeys.length;
return (
  <MapGL style={MAP_STYLE} accessToken={API_TOKEN} {...this.state.viewport}>{
    journeys.map((type, idx) => (
      <Layer key={idx} type="line" {...type.style}>{
        type.segments.map((segment, idx) => (
          <Feature key={'segment-'+idx} coordinates={segment.coordinates}  />
        ))
      }</Layer>
    ))
    }<Layer key={journeyTotal} type="circle" paint={LOCATION_SHAD_STYLE}>{
      this.props.locations.map((location, idx) => (
        <Feature key={'location-shad-'+idx} coordinates={location.lngLat} />
      ))
    }</Layer>
    <Layer key={journeyTotal+1} type="circle" paint={LOCATION_STYLE}>{
      this.props.locations.map((location, idx) => (
        <Feature key={'location-'+idx} coordinates={location.lngLat} />
      ))
    }</Layer>
    <Popup {...this.props} />
  </MapGL>
);

Have a look at the key attribute on my layers.  This approach is the only way I found to ensure the layers are ordered as they appear in the JSX.  Without the sequential indexes (I tried arbitrary high numbers like 9999 without success), the layer order is unpredictable.  Once I filter the data using other functionality, the indexes can become out-of-sequence and breaks ordering.
The order of layers in this array is how mapbox-gl will render the layers.  The package doesn't appear to take advantage of this, using componentWillMount and addLayer, which appears to be asynchronous as my most expensive layers are rendered last / on top (the journey polylines).
Any ideas?

This is how react fundamentally works. The key ensures an order and identification for each child element of a React component. We could add sth else that overrides this behavior, but that would just be a redundancy ;)

Follow up actually, we can make use of the key actively and pass the elements to mapbox gl in a stable order, but I'm not sure if that adds a lot of value. Can you elaborate on the purpose here a bit?

Sure,
I have routes which are styled based on transport type - different colours, and flights have an arc. Since styling happens at the Layer level, I've made an array of layer types under journeys with their own 'paint' and 'layout' objects along with a LineString.
Then I have locations which are waypoints along these polylines, and need to sit on top or else they are obscured.
If you can suggest some ideas as to how to fix this I'd be happy to get it done and submit a PR.

This is my first React project, so I'm no expert, but something that's related is it's not obvious how to go about splitting the map layers into different components.  For example it felt natural in this scenario to create a new component for Map, Journey Layers, and Location Layers.  Using JSX and regular HTML, I could render several items wrapped in a <div>, but I couldn't think of an alternative using the <Map><Layer ... /></Map> syntax for Journeys.
I'm wondering if what is really needed is a new Source component, as child of Map, which can have multiple Layers as children, and the ability to keep different Sources ordered, and keep it's source data separated (as in mapbox.getSource()).
Then the map could be simple and optimised for simple maps, or have a bit more control for more complex maps.
Thoughts?

Hi @daviestar,
I have added support for the before property when adding a layer to the map. https://github.com/alex3165/react-mapbox-gl/commit/f4917fa7cd06374f6f7bc862f3455d8f3487095e
This should solve your problem of ordering the layers, you have to specify the id of another layer (it imply to generate the id yourself and pass through the props) and the layer will be displayed just  before the id of the layer you specified.

Great, that seems like a really nice and simple solution - I have been thinking how I would fix it and had only come up with much more complicated approaches!


Fixed invalid name in pl.yml

I've removed first name — (em dash)  from pl.yml. This isn't valid name in polish language and it randomly trips tests in my projects concerning models which validates more than simple presence of name field.
I've also expanded a little standard test for checking names because it would fail otherwise with short names with polish diacritics.

:+1:


Add upwinding to Jacobian

This PR adds a flag for upwinding, which is used in the implicit tendency and the Jacobian computation for the vertical advection of energy and tracer variables. The flag is set just like the energy variable flag (through a command-line argument and a function that returns a symbol). The possible values for this flag are

:none, which uses central differencing for vertical advection; i.e., ᶜvariableₜ = -ᶜdivᵥ(ᶠinterp(ᶜvariable) * ᶠw)
:first_order, which uses first-order upwinding; i.e., ᶜvariableₜ = -ᶜdivᵥ(ᶠinterp(ᶜρ) * ᶠupwind_product(ᶠw, ᶜvariable / ᶜρ)), where ᶠupwind_product = Operators.UpwindBiasedProductC2F()
:third_order, which is the same as :first_order, but with ᶠupwind_product = Operators.Upwind3rdOrderBiasedProductC2F(bottom = Operators.FirstOrderOneSided(), top = Operators.FirstOrderOneSided())

Note that we could also use Operators.ThirdOrderOneSided() instead of Operators.FirstOrderOneSided() for :third_order. I don't think this makes too much of a difference, so I've just hardcoded Operators.FirstOrderOneSided() as the default.

bors r+


diffrent output of color presets in Home App

Thanks for your plugin! I works well and so far I am so thankful for they do not loose connection like they did when they were nativly paired, but...
...it looks like there is a problem with the colorsettings.
I have two Mi Smart Beside Lamp 2...
...when both paired via your plugin the same colorsetting lead to a diffrent output on the lamps (using the 6 presets after default settings).
When pairing nativly the problem does not occur. I then get exact the same output on both lamps.
Have a look on it please. Thank You!

hi, I also have 2 lamps and I don't have any issues with the colors.
check the homebridge logs to see if the same values for hue/saturation gets send to the lamps. you can also check with the shortcuts app the state of the current set values.

Thanks for answering...
[28.2.2022, 10:42:21] [Ns Nachttischlampe] set 'On' to => true
[28.2.2022, 10:42:29] [As Nachttischlampe] set 'On' to => true
[28.2.2022, 10:42:32] [As Nachttischlampe] set 'Brightness' to => 100
[28.2.2022, 10:42:41] [Ns Nachttischlampe] set 'Brightness' to => 100
[28.2.2022, 10:42:46] [Ns Nachttischlampe] set 'Saturation' to => 10
[28.2.2022, 10:42:46] [Ns Nachttischlampe] set 'Hue' to => 331
[28.2.2022, 10:43:05] [As Nachttischlampe] set 'Saturation' to => 10
[28.2.2022, 10:43:05] [As Nachttischlampe] set 'Hue' to => 331

...leads to [As Nachtischlampe] white and [Ns Nachtischlampe] white with a pink touch
I will try to reset and pair again to see if there is anything I missed during the setup.

the hap-contoller package had 2 updates since I released this plugin. one change was
(Apollon77) Make sure calls on a http connection are queued to not overlap

maybe there is something "slower" in your network as in mine and the 2 values won't get published correct to the lamps. I will make some tests with updated hap-controller to see if it works correctly and will then update the bslamp plugin.

Perfect, ty

Thank you so much. 🙏🏽
After months of struggling with my 4 Mi BS2 Lamps, I decided to do something about it today. After realising that Xiaomi has deliberately borked the LAN functionality of these, I came across your HB plugin.
Install and config could not be easier and so far the connection looks solid. Will report back after a couple of days if Siri and HK automations work reliably.

the hap-contoller package had 2 updates since I released this plugin. one change was
(Apollon77) Make sure calls on a http connection are queued to not overlap

maybe there is something "slower" in your network as in mine and the 2 values won't get published correct to the lamps. I will make some tests with updated hap-controller to see if it works correctly and will then update the bslamp plugin.

Just wanted to say...
Thank you so much. 🙏🏽
After months of struggling with my 4 Mi BS2 Lamps, I decided to do something about it today. After realising that Xiaomi has deliberately borked the LAN functionality of these, I came across your HB plugin.
Install and config could not be easier and so far the connection looks solid. Will report back after a couple of days if Siri and HK automations work reliably.

@GoanSausage thank you :) would be nice if you can also test if your colors are set correct or if you also have the issues from @Arijuz

Will test and report back on that as well.

What do you mean with "high brightness/warm white mode"?
If you press Edit on a preset in HomeKit, you get 2 "tabs" - one to set color and one to set temperature.

What do you mean with "high brightness/warm white mode"?
If you press Edit on a preset in HomeKit, you get 2 "tabs" - one to set color and one to set temperature.

There is a colour mode and then a white lamp mode on the BSII's the white lamp mode can only be accessed from their own apps and by holding down the top button ton the lamps itself.
This mode isn't exposed to HK. It's much brighter than any colour temp/brightness available in HK.
I'm guessing there are additional white LEDs inside the lamp in addition to the RGB LEDs. These white LEDs only come on in this mode.
Try it yourself.

Oh, I didn't know this mode 😄 I will check if this mode can be accessed through the exposed HomeKit api of the lamps.

@GoanSausage there is no option exposed to toggle this mode, so no way for me to add this mode...

@GoanSausage there is no option exposed to toggle this mode, so no way for me to add this mode...

I thought so, since the functionality isn't exposed to HomeKit.
No worries, connectivity and responsiveness have been rock sold since install. 🙏🏽

as no one else reported or confirmed this issue, I will close it now

@Arijuz I have more or less rewritten the complete plugin to work with the new functions of the hap-controller package.
would be interesting to know if your color issue still exists now 🙂

Hi, I’ll have a look at it these days. Will reply later next week. Greetings


Unable to determine the disk for widget Backend\FormWidgets\MarkdownEditor" on line 166

I'm using a fresh instance of Winter CMS 1.21
Need to configure AWS SES in mail config. All is working ok.
But when I go to template configuration in mail settings. I am getting this error:
"Unable to determine the disk for widget Backend\FormWidgets\MarkdownEditor" on line 166 of D:\...\plugins\winter\driveraws\behaviors\StreamS3Uploads.php

@bkrajendra try commenting out https://github.com/wintercms/wn-driveraws-plugin/blob/main/Plugin.php#L154 and see if that solves the issue.

I can confirm this bug, the same happens in my installation with the dev-main branch of this plugin. Commenting out the L154 "fixes" the problem.

@LukeTowers I was able to resolve it with your solution.


Page preview - not renderized

First, great job!
When creating or editing a post, the toggle preview page does not show the rendered content.
Here are some prints.

I don't know if it is relevant information, but, when I clicked the Toogle preview button, I checked an information that appeared in my browser devtools.

I tested using a private gitlab repository and a public repository on github, deploying with netlify.

Hi! Preview templates could be added in order to show rendered previews but due to time constraints I have no plans to do this currently.
This feature does exist in my Eleventy starter project so if you want you can see how it's been implemented over there. If you feel like submitting a PR, it could be a nice addition to this project.
The document.write() warning might be caused by jekyll-watch if you are running Jekyll locally, although I'm not 100% sure. If you provide more info I can try to reproduce.


[FEATURE REQUEST] ... Credit Card Payments

Is your feature request related to a problem? Please describe.
no problem
Describe the solution you'd like
When you click Record Payment you get a popup that gave you two radio buttons with a message that asks if you would like to pay the Cleared Balance or the Working Balance. Select one, click Ok, and the appropriate transaction is created.
Describe alternatives you've considered
Another option would be to have a setting allowing you to pick cleared or working balance. This way all credit card payments work off the same balance.
Additional context
Currently when you click "Record Payment" for a credit card the transaction amount is the Working Balance. Most credit cards will not allow you to make a payment for more than what has cleared when paying through their systems. If you pay through your bank you can always pay more. I only have the Apple Credit card which makes you pay through their system, so every time I record a payment I have to change the amount paid.

+1.

+1 ... however, I would prefer a persistent option associated with the account.  Once I've said that I pay the working balance on this account, I want it remembered for the next time I send a payment.

+1.
I would suggest a toggle option in the Toolkit Settings.  I enjoy paying all my credit cards weekly, in full (whether that makes sense or not doesn't matter to me, it brings me peace, so I do it).  While I am giving the cc company money they haven't asked for yet, I also don't want to give them more than they have on record.  If the transactions haven't cleared yet, I'm not paying for them.
Currently, YNAB wants me to pay the full, uncleared balance.  It would be ideal if I could just toggle it in settings to use only the cleared balance when I click on the Record Payment button.

+1 especially to @Patatsky 's suggestion. A toggle option for "Always pay Cleared Balance when clicking Record Payment" would be perfect. I too pay off my CCs multiple times per month for only the amount cleared and none of my CCs even let me pay more than the cleared amount so changing the amount each time I pay ends up being time consuming.

+feature

We use Trello to track Feature Requests so that users can vote on what they'd like to see next. This is crucial for us since there are so many requests and so little time amongst those of us who work on the Toolkit.
Your feature request has been added here and will need to be manually sorted.
This issue can now be closed.


Doesn't derive Debug for all structs

With .derive_debug(true) on the Builder, Debug doesn't get derived for all types. Complete example: https://github.com/Ploppz/mcp2210-bindings
... in which this struct doesn't get Debug implemented:
pub struct SPIDataTransferStatusDef {
    pub NumberOfBytesReceived: c_uint,
    pub SPIEngineStatus: c_uint,
    pub DataReceived: [c_uchar; 60],
    pub ErrorCode: c_int,
}

This is expected because the DataReceived array is has more elements than the maximum number of elements for which Rust implements Debug for arrays (32).
You can use Builder::impl_debug and/or --impl-debug to have bindgen generate an impl Debug for ... block.


Filter separator is ';' instead of ',' when printing with ffmpeg.compile()

I'm currently debugging the ffmpeg calls that I get from ffmpeg-python and I'm taking the output of ffmpeg.compile() and paste it into the console. However, the different filters in filter_complex  are being printed out with a separator ';' instead of the usual ',' and my terminal recognises that as an end of the command, giving me the error:
'Filter [trim] has an unconnected output'
My terminal is:
GNU bash, version 4.3.48(1)-release (x86_64-pc-linux-gnu)
in an ubuntu 16.04 container, inside a tmux virtual terminal inside a remote ec2 instance (if it's worth to mention).
Is there any reason why you prefer ';' instead of ',' to separate the filters?
Thank you!

When testing on the command line, just surround that part in ", like this:
… -filter_complex "[1:a:0]atempo=0.5[s0];[s0]atempo=0.5[s1];[s1]atempo=0.5[s2]" …

@avibrazil  could you suggest how to use such ^ filter as argument in the ffmpeg.filter function?

Sure… this is snippet from a program of mine:
original  = ffmpeg.input("video.mov")
audioStretched = original['a:0'].filter('atempo',0.5).filter('atempo',0.5).filter('atempo',0.5)

muxer=ffmpeg.output(
                            original['v:0'],
                            audioStretched,
                            "output.mov",
                            acodec='alac',
                            vcodec='copy',
                            scodec='mov_text',
                            movflags='faststart+use_metadata_tags',
                    )

muxer.run()

My code does other things too, but it produces an ffmpeg command similar to this:
ffmpeg -r 30 -i original.h264 -i original.mov -filter_complex [1:a:0]atempo=0.5[s0];[s0]atempo=0.5[s1];[s1]atempo=0.5[s2] -map 0 -map [s2] -map 2 -acodec alac -metadata:s:v rotate=180 -movflags faststart+use_metadata_tags -vcodec copy output.mov -hide_banner


Status DHCP Leases show CID and other enhancements

If there is a Client Id specified then show it (otherwise it is possible to define a Static Mapping that has only Client Id and all other fields empty, which would look like an empty row in the displayed table).
Ignore empty static lease entries - when an interface has no static mappings the "static" section of the DHCP server settings can be "" which was resulting in a single-element that was empty being displayed as an empty row.
If there are no leases to display, then make a row with the message "No leases to display" so the user knows the system at least tried.
If there are no leases in use, then make a row with the message "No leases are in use" so the user knows the system at least tried.

Style of "if" statement changed to match surrounding code as requested.


test_simplest doesn't run when the remote ontology is not available

Hi,
When I run the the test_simplest test locally, without remote access to the biolink ontology, the test returns an error.
As this is the first test we run when reading the documentation, it would be convinient to have a locally stored ontology for it.
Best regards,
Claire Laudy

We should have a local copy of BioLink in the tests directory and reference it from the config.
Problem: BioCypher seems to only take URL, which forces an absolute path reference with file:://, which we cannot do.
Should we add a BioCypher constructor that takes strings and/or relative paths to files?


Exported csv filename

I noticed that we export the csv file as simply export on iOS. Is it from here (L135)?

yup. I remember there was some issue with the extension but I look back at this 2+ years ago, so we might want to revisit.
I guess your expectation is that the .csv would be set correctly in the filename?

I guess your expectation is that the .csv would be set correctly in the filename?

Yes this


[fix](inverted index) fix the issue where need_read_data does not han…

…dle non-pushdown conditions
Proposed changes

Fixed the previous optimization of https://github.com/apache/doris/pull/35346 not handling non-pushdown conditions.

run buildall

run buildall

run buildall

run buildall

run cloud_p1

run buildall


Update scala3-library to 3.0.2

Updates org.scala-lang:scala3-library from 3.0.1 to 3.0.2.
GitHub Release Notes - Version Diff - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.0.1).
You might want to review and update them manually.
.scalafmt.conf

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala3-library" } ]

labels: library-update, semver-patch, old-version-remains

Codecov Report

Merging #318 (38f2296) into main (b2aec69) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   59.87%   59.87%
=======================================
  Files          30       30
  Lines         987      987
  Branches       64       64
=======================================
  Hits          591      591
  Misses        396      396

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2aec69...38f2296. Read the comment docs.


Excercise04

uploaded a folder

This worked! It was just erroring because it was missing the module name before the function call. Once I changed affordable_housing_proportion() to housingcal.affordable_housing_proportion() it ran just fine.


Avoid EINTR in readline by repeating poll-call.

Fixes #402 by repeating the call on EINTR.

Thanks.
But I am not sure we should loop.

https://github.com/kkawakam/rustyline/blob/master/src/tty/unix.rs#L417
Here, we try to make the distinction between a single ESC and an escape sequence.
I guess we can safely assume that a single ESC was received if an EINTR is raised.
https://github.com/kkawakam/rustyline/blob/master/src/tty/unix.rs#L705
Here, we try to find the current cursor position.
I guess we can safely assume that cursor position is OK if an EINTR is raised.

An EINTR can be caused by any signal, including SIGSTOP, SIGCHLD, SIGWINCH or SIGUSR1.

See #420.


feat: download data progress

Implemented download progress for https://github.com/fairDataSociety/fdp-storage/issues/264
Closes: https://github.com/fairDataSociety/fdp-storage/issues/264

Everything seems good except maybe calling the callback function in async manner? Because if the callback function is complex it can block function execution.


[BUG] Getting dependency from DryIoC container creates dependency object twice

Describe the bug
When using a DryIoC container with Splat, calling Locator.Current.GetService<MyViewModel>() leads to two MyViewModel objects being created.
The same goes for ReactiveUIs view locator, which resolves IViewFor<MyViewModel> twice thus creating two instances of a view.
This can have a negative impact on performance and lead to unexpected behavior.
Steps To Reproduce
var container = new Container();
container.UseDryIocDependencyResolver();
container.Register<MyViewModel>();

// Using a breakpoint in the MyViewModel constructor
// it can be observed that it is created twice.
var vm = Locator.Current.GetService<MyViewModel>();

Expected behavior
Resolving a dependency should not lead to multiple objects of the resolved type being instantiated.
Screenshots
Environment(please complete the following information):

OS: Android
Version: 10 (EMUI 12)
Device: Huawei P40 Lite 5G

Additional context
I think I narrowed down the problem to the behavior of Enumerables in DryIocDependencyResolver, though I am not sure how to fix it.
In its GetServices implementation, the Any() method is called, which iterates the Enumerable and therefore instantiates the object the first time.
https://github.com/reactiveui/splat/blob/9636f354928f0862f300004b9d5f8678a93d496f/src/Splat.DryIoc/DryIocDependencyResolver.cs#L47
Afterwards the original Enumerable is returned to the GetService implementation, where LastOrDefault() iterates the enumerable again, creating another object.
https://github.com/reactiveui/splat/blob/9636f354928f0862f300004b9d5f8678a93d496f/src/Splat.DryIoc/DryIocDependencyResolver.cs#L34
This was reproducible for me by using the container directly to verify this behavior like so:
var fromContainer = container.ResolveMany(typeof(MyViewModel), serviceKey: null);
if (fromContainer.Any()) // after this call, MyViewModel constructor is called
    _ = fromContainer.LastOrDefault(); // after this call, MyViewModel constructor is called again

I tried reproducing it in a unit test, but this might be prevented from happening by .NET6.0 LINQ improvements, especially the TryGetNonEnumeratedCount which is likely being used by the Any() call.
One idea would be to pass ResolveManyBehavior.AsFixedArray to the ResolveMany() call. But I am uncertain if this would fix the issue.
Any ideas? Does anybody else have this issue?

One way is it implement https://github.com/dotnet/runtime/blob/57bfe474518ab5b7cfe6bf7424a79ce3af9d6657/src/libraries/System.Linq/src/System/Linq/Count.cs#L96 for non 6 platforms

I'm very time limited at the moment but if I get time I'll fix this on the weekend. @dpvreony may also have time to help out on this one.

This may be related to #889 as well

Hey, thanks for the quick reply.
I tried using a custom IDependencyResolver inheriting from DryIocDependencyResolver to set ResolveManyBehavior.AsFixedArray in the ResolveMany() call.
This seems to work fine. The duplicate calls are gone as far as I can tell.
Since (as described) the LastOrDefault call iterates the enumerable anyways, this shouldn't add any additional resource usage.
If this would be a valid fix, I am happy to submit a PR.
Not sure how to trigger this behavior in a unit test though, they seem to run using .NET 6...

I guess this could be an argument to bring back net48 target framework to the tests

Turns out I must have done something wrong, when I first tried it with net6.
It was indeed reproducible, so I filed a PR with a test and fix. No need to bring back net48 (although I tried and it didn't change anything).

There has been a release https://github.com/reactiveui/splat/releases/tag/14.1.58
Thanks for the help.


Register modules through annotation

It would be nice to have something like
@Modules(activityModule.class)
public class Activity

Instead of
https://github.com/stephanenicolas/toothpick/blob/master/smoothie-sample/src/main/java/com/example/smoothie/RxMVPActivity.java#L35
You should be able to generate the instantiation and pass whatever this is when creating the scope

Though this annotation is not inside the JSR, we could add a feature like this. It makes me wonder about the sharpness of the lib though. Also, I am really not sure that we can always get the value of all params of a module, they can indeed be coded in so many ways (using an application, an activity, a service are common requirements but you can really do what you want programmtically).
Though, what would be interesting for TP is a new module to support dagger 1 or dagger 2 modules. It would definitely help people to migrate from these to TP.

It looks like no one is interested in implementing this, I close the issue.


[Draft] [System.ClientModel] ILogger-based logging policy prototype

TODO

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.ClientModel

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.ClientModel

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.ClientModel


Octo repo list throws error

Issue Description
The :Octo repo list command throws the below error. For some reason, executing another command (e.g. :Octo search) beforehand allows it to work correctly.
Type: bug report
Describe what happened (or what feature you want)
Error message:
Error executing Lua callback: ...m/lazy/octo.nvim/lua/octo/pickers/telescope/provider.lua:925: bad argument #2 to 'graphql' (value expected)
stack traceback:
	[C]: in function 'graphql'
	...m/lazy/octo.nvim/lua/octo/pickers/telescope/provider.lua:925: in function 'repos'
	...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:138: in function 'a'
	...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:356: in function 'octo'
	...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:16: in function <...a/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:15>

Describe what you expected to happen
I expect telescope to show a list of my repos.
How to reproduce it (as minimally and precisely as possible)

:Octo repo list

Tell us your environment
MacOS 13.3
Neovim v0.9.1
Anything else we need to know?

@pwntester It works now, thanks!

My fault, I left a debug print around. should be ok now


Error: Failed to open sequence file example_MOB_temp_mob.faa for reading

Hi, @pianpianyouche
I installed Plascad as you mentioned in the tutorial with conda environment. However, it will report an error when I ran Plascad with example.fasta or my own plasmids files.
Error: Sequence file example_MOB_temp_mob.faa is empty or misformatted

Error: Sequence file example_MOB_temp_mob.faa is empty or misformatted

cat: *ATPase.hmm_domtblout_parsed_out: No such file or directory
cat: *T4CP*_domtblout_parsed_out: No such file or directory
cat: example*MPFF*_result_out: No such file or directory
cat: example*MPFG*_result_out: No such file or directory
cat: example*MPFI*_result_out: No such file or directory
cat: example*MPFT*_result_out: No such file or directory

Hi, that's weird! I have tried to install this tool to different workstations, all work very well.
Could you install it with pip? but you need to install the dependencies (Python >=3.6, blast >=2.7.1, prodigal >=2.6.3, hmmer >=3.2.1) in your PATH.

I have tried to use Plascad on another server and it works very well. But when I install it with pip3 on the previous server,  it reported the error again. I don't know what contributes to this problem... Could you please provide a docker image for Plascad? Thanks! @pianpianyouche


Thanks for your work, Can I use this code draw an MR-FPPI curve?

Not yet, I will add it to the TODO list.

I am looking forward for your work, Support your work!

Any update on this?


peer to peer code review project for contact form

we suggest that you first read and understand the feedback from the code reviewer before restoring the branch
Then please resolve the linter errors because the stylelint isn't successful

I resolved the linter errors and worked as reviewed by my morning session team .


dubbo demo start failure

as the picture shows

I think the references dubbo project in your demo project is missing.

this download in https://github.com/apache/incubator-dubbo/tree/master/dubbo-demo ,missing?

I use 2.5.10 demo ,Can start

2.6.1 demo, got same error message.  My issue #1739

The latest dubbo-demo codes should work with 2.6.2-SNAPSHOT, if you are using latest demo with 2.6.1, you need to register a name space handler manually in the demo code:
You can manually register the NamespaceHandler by adding META-INF/spring.handlers with the following content:
http\://dubbo.apache.org/schema/dubbo=com.alibaba.dubbo.config.spring.schema.DubboNamespaceHandler


Closures

Summary
Issue #2197
Extends the following functions to support closure-like objects:
count_vars(...)
deep_copy_vars(...)
accumulate_adjoints(...)
save_varis(...)
zero_adjoints(...)
value_of(...)

That should be enough for any variadic higher-order function to support closures almost automatically.
The stanc3 PR exposing this in the language is stan-dev/stanc3#742
Tests
I added a couple of tests for integrate_ode_rk45, ode_rk45, and reduce_sum.
Side Effects
I don't think so.
Release notes
Implement closures.
Checklist

[X] Math issue #2197

[X] Copyright holder: Niko Huurre
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[X] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[X] the code is written in idiomatic C++ and changes are documented in the doxygen

[X] the new changes are tested

A quick example:
vector[N] v = rep_vector(1.0, N);
real myfunc(row_vector s) {
  return s * v;
}

The C++ type of myfunc is approximately
template<bool Ref>
class myfunc_type {
  capture_type_t<VectorXd, Ref> v;
  public:
  auto operator()(const auto& s) {
    return s * v;
  }
  // ...
  // + methods for accessing autodiff stack of the private member v
}

When the closure is first created the template type capture_type_t is a constant reference.
class myfunc_type {
  const VectorXd& v; // capture_type_t<VectorXd, true>

That's efficient but means the closure object cannot outlive the scope in which v was defined. If you need to use the closure outside of its initial scope (e.g. adjoint ode autodiff needs it during the reverse pass) then you must call myfunc.copy_of__() or myfunc.deep_copy_vars__() to make closure that holds copies of its captures.
class myfunc_type {
  VectorXd v; // capture_type_t<VectorXd, false>

@nhuurre if you get a chance can you review https://github.com/stan-dev/math/pull/2397? When that is in I'll do a version for algebra solver, and then when we have that then we can support all the high order stuff except map_rect.
Then I guess it's a matter of adding tests here and the Math part of this is done.

where recursive_sum just keeps summing everything until out pops a scalar.

I think we already have templates that do this for existing types in the math library.  The general recursive template pattern is also used for the vectorized form of scalar real functions.

@bbbales2

if you get a chance can you review #2397? When that is in I'll do a version for algebra solver, and then when we have that then we can support all the high order stuff except map_rect.

The PR looks good to me but I'm not very familiar with integrate_1d code.
If you're looking into the algebra solver then I'm pinging @charlesm93 because the last post in the ancient Discourse thread is him saying he'd do it. Not sure if he's still up to it but anyway.
And I think map_rect is feasible. I have a partial implementation of serialization, start here. Does the second test in that file correctly imitate MPI data flow?

Does the second test in that file correctly imitate MPI data flow?

Yeah, this looks right. I'd have to dig in more to the MPI to know. As the caching is implemented now can lead to bugs.
The current map_rect takes a function:
vector f(vector phi, vector theta, data real[] x_r, data int[] x_i);

phi are parameters shared between every node.
So if we took a closure, g(vector phi, vector theta, data real[] x_r, data int[] x_i) => vector and the compiler built a non-closure function h that wrapped g with the appropriate deserialization then I think this would work.
So h would look something like:
vector h(vector phi, vector theta, data real[] x_r, data int[] x_i) {
  g_closure g(closure_vars(phi), closure_x_r(x_r), closure_x_i(x_i));
  return g(non_closure_part_of_phi(phi), theta, non_closure_part_of_x_r(x_r), non_closure_part_of_x_i(x_i));
}

And so what you have looks right to me. I'd have to think more closely to know for sure though.

I think the routine would be define another map_rect that takes in a first argument that is a closure. This map_rect would pack up all the data and then call the regular map_rect (regular map_rect is here).
Regular map_rect takes as a template argument a functor type F, which is the thing that will get called. I'm not sure if this is a thing that would need constructed by the compiler, or if we can build the F from the type of the functor that got passed in.
Regardless, we would need to build a special F that unpacked all the data and then called our closure function. I think if we can do those two things we're good.

Also there are some weird macros floating around that I'm not sure about: https://github.com/stan-dev/math/blob/develop/stan/math/prim/functor/map_rect_mpi.hpp#L48

Is this still being worked on? Happy to take on the review if so!

Is this still being worked on?

I haven't resolved the merge conflicts here because I figured everyone is too busy with the adjoint ODE stuff anyway. I do have a branch that is up to date with it https://github.com/stan-dev/math/compare/feature/adjoint-ode...nhuurre:closures-adjoint-ode (huge diff because the adjoint ODE PR hasn't merged in develop for a while, I think)
You can download https://github.com/nhuurre/cmdstan/releases/download/closures-v0.2/cmdstan-closures-adjoint-ode.tar.gz
IIRC I found some benchmark model in the adjoint ode discussion and tried running it with no changes to Stan code, so basically an empty closure, it was like 10% slower which was pretty depressing because I have no idea where to start debugging that.

Don‘t wait for adjoint ODE...I am not sure how busy this is keeping others than myself. However, I will merge develop into the adjoint branch rather soon, since now the ODE testing branch is in develop.

FYI: the adjoint ODE branch is now up to date with develop

Should we resurrect this? I think closure are really helpful and it‘s worth to do even if there is a performance penalty.
Is there a design doc or some other high-level doc to look at? I am not really blessed with a lot of free time, but I am happy to support this effort as I really think this will bring Stan to a new level in terms of model complexity (which we need sometimes).
Monitoring the performance loss would be a good thing to start with. 10% is not nice, but this is for ODEs which are extremley critical in terms of RHS evaluation performance. That‘s likely not so critical for reduce_sum and for map_rect (and a map_rect MPI with closure support would be super cool…though I would probably drop support for that in a first version unless you, @nhuurre, found a „trivial“ solution).

Should we resurrect this?

This isn't dead. It's waiting for the stanc3 branch which in turn is waiting for my latest stanc3 pull req (type-error-explanations) to resolve some merge conflicts. After syncing with stanc3 I'm going to update the ODE tests here to the new framework and ask for reviews.

Once the algebra solver stuff is in place here, then the only thing that can't support closures as they are implemented here is map_rect (the ode solvers, reduce_sum, integrate_1d, and the algebra solvers can all work).
I'm happy making closure-to-map-rect a compile error. Otherwise gotta figure out the MPI-variadic thing. I don't like leaving the implementation just hanging here. @nhuurre has had this together for a long time now and the design has been up for a long time too. Of course if the MPI-variadic thing gets figured that's great too.
That doesn't address the performance thing but I assume there's a solution there. Last time I looked through the implementation here I remember liking it from the C++ side well-enough.
I also don't have much time now, but that's the status from my angle.

Great to hear this is rolling. @nhuurre if you could also answer the review questions from @bbbales2 - that would be great.
Just ping me once I should spend more time on this.
Is this, https://github.com/stan-dev/design-docs/blob/master/designs/0004-closures-fun-types.md The design doc for this implementation?

Ready for review.
CmdStan tarball: https://github.com/nhuurre/cmdstan/releases/download/closures-v0.3/cmdstan-closures.tar.gz

Alright I looked over some of this and the stanc side and I think if we make a few changes to the stanc side of things we can simplify the code here a lot. Mostly just having a member function get_members() that gives back a tuple of the members. Then we just do a for_each() or apply()over the tuple with the functions that already exist

Mostly just having a member function get_members() that gives back a tuple of the members.

I don't follow how that's supposed to work. You wrote
    template <typename F, require_stan_closure_t<F>* = nullptr>
    auto deep_copy_vars(F&& f) {
      return stan::math::for_each([](auto&& x) { return deep_copy_vars(x);}, f.get_members());
    }

but this deep_copy_vars would return a tuple, not a closure, right? So it's not callable and can't be passed to higher-order functions as-is. In particular, what is ode_closure_adapter supposed to do with it?

Oh I totally forgot about higher order functions. Okay looking at this now what if we had a make_functor function we could give the type of the functor we want to construct. Then I think we can remove these functions from the actual closure impl?
namespace internal {
/**
 * Makes a functor from a tuple
 */
template <class F, class Tuple, std::size_t... I, require_stan_closure_t<F>* = nullptr>
constexpr decltype(auto) make_functor_impl(F&& f, Tuple&& t,
                                    std::index_sequence<I...> i) {
  return f(std::forward<decltype(std::get<I>(t))>(std::get<I>(t))...);
}
}

template <class F, class Tuple>
constexpr decltype(auto) make_functor(F&& f, Tuple&& t) {
  return internal::make_functor_impl(
      std::forward<F>(f), std::forward<Tuple>(t),
      std::make_index_sequence<
          std::tuple_size<std::remove_reference_t<Tuple>>{}>{});
}

template <typename F, require_stan_closure_t<F>* = nullptr>
auto deep_copy_vars(F&& f) {
  // Note: I'd like to change CopyOf__ to nix double underscores like copy_functor_
  return make_functor<std::decay_t<F>::CopyOf__>(stan::math::for_each([](auto&& x) { return deep_copy_vars(x);}, f.get_members())));
}

I think having something generic like this in math would make the closure impl a bit cleaner. Though I think my  first scheme above would work fine for things like zero_adjoint(), accumulate_adjoints(), etc.

I think having something generic like this in math would make the closure impl a bit cleaner.

Yes, that sounds reasonable. I opted to have stanc3 generate the impls instead of having a make_closure in stan-math mostly because I don't know enough C++ template magic to create a sufficiently generic make_closure.

Check out how we do apply() and for_each() which should give you an idea of how to unpack the tuples

The generator thing from @SteveBronder looks nice to me. I guess @SteveBronder can help out with C++ magic here?
I wanted to benchmark this closure thing based on an ODE RK45 example. To do so I took the SIR example showing how to convert to variadic ODEs: https://mc-stan.org/users/documentation/case-studies/convert_odes.html
The cool thing is: The new closure ODE stuff is 10% faster for this example. It's a mystery to me why that is, but I take that, of course. I'd need to dig deeper to understand better as to why things speed up...which is great!
Needless to say that the same results are reported from Stan. I took the above cmdstan version.
Here is the closure Stan file (really cool to define everything once):
// Simple SIR model inspired by the presentation in
// http://www.ncbi.nlm.nih.gov/pmc/articles/PMC3380087/pdf/nihms372789.pdf
data {
  int<lower=0> N_t;
  real t[N_t];
  vector[4] y0;
  int stoi[N_t];
  real B[N_t];
}

transformed data {
  real t0 = 0;
  real<lower=0> kappa = 1000000;    // C_{50}
}

parameters {
  real<lower=0> beta;    // water contact rate
  real<lower=0> gamma;   // recovery rate
  real<lower=0> xi;      // bacteria production rate
  real<lower=0> delta;   // bacteria removal rate
}

transformed parameters {
  vector<lower=0>[4] y[N_t];

  function
  vector simple_SIR(real time, vector yt) {
    vector[4] dydt;

    dydt[1] = -beta * yt[4] / (yt[4] + kappa) * yt[1];
    dydt[2] = beta * yt[4] / (yt[4] + kappa) * yt[1] - gamma * yt[2];
    dydt[3] = gamma * yt[2];
    dydt[4] = xi * yt[2] - delta * yt[4];

    return dydt;
  }

  y = ode_rk45_tol(simple_SIR, y0, t0, t,
                   1e-6, 1e-6, 1000);
}

model {
  vector[N_t] y_diff;
  y_diff[1] = y0[1] - y[1, 1];
  for (n in 2:N_t)
    y_diff[n] = y[n - 1, 1] - y[n, 1];

  beta ~ cauchy(0, 2.5);
  gamma ~ cauchy(0, 1);
  xi ~ cauchy(0, 25);
  delta ~ cauchy(0, 1);

  stoi ~ poisson(y_diff);
  B ~ lognormal(log(y[, 4]), 0.15);
}

Here is the R file controlling the benchmark:
library(cmdstanr)

set_cmdstan_path("~/nwork/cmdstan-closures")

rebuild_cmdstan(cores=6)

base_model  <- cmdstan_model("sir.stan")

initials <- list(beta=1.0, gamma=0.2, xi=10.0, delta=0.35)

fit <- base_model$sample(
  data = "sir.data.R",
  seed = 123,
  chains = 1,
  parallel_chains = 1,
  refresh = 500,
  init=list(initials)
)

fit$time()

fit$summary("lp__")

closure_model  <- cmdstan_model("sir-closure.stan")

cfit <- closure_model$sample(
  data = "sir.data.R",
  seed = 123,
  chains = 1,
  parallel_chains = 1,
  refresh = 500,
  init=list(initials)
)

cfit$time()

cfit$summary("lp__")

The new closure ODE stuff is 10% faster for this example.

Your code seems to test a closure on cmdstan-closures against a bare function on cmdstan-closures instead of a function on cmdstan-develop. For simplicity I removed the ode_functor structs in favor of wrapper closures so it's possible that what you're seeing is a 10% slowdown for everything that isn't a closure.

Ok, I see. So I get:

vanilla 2.27: 52.5s
closure branch, no closures: 58s
closure branch, closures: 53.8s

so it looks like the closure stuff is taking off a little bit.

@nhuurre sorry for not coming back to this, is this ready to be looked at again?

Closing this PR for now. @nhuurre, if this is still active, please reopen.


hbase-indexer jetty header size larger than approx 4192 bytes yields HTTP 413

This issue happens when running on kerberos. Proposal is to change hbase-indexer to do something like HADOOP-8816, i.e. do setHeaderBufferSize(64*1024) by default and make that value configurable via ConfKeys.java

I'll submit a PR shortly.

PR is here: https://github.com/NGDATA/hbase-indexer/pull/72


Allow us to extend launch configurations

I have a launch.json with two configurations that are basically exactly the same except for the args that I set.
I would like to be able to extend an existing launch configuration and add on just my changes rather than rewriting the entire configuration. E.g.:
{
    "type": "node",
    "request": "launch",
    "name": "A",
    "program": "...",
    "runtimeExecutable": "...",
    ...
},
{
    "name": "B",
    "extends": "A",
    "args": ["arg1", "arg2"]
}

Can we revisit this? I have giant launch configs. My current workaround is to comment out the arguments to test with but it's a pain to switch between when it could be in a nice dropdown menu.
I really like pushkin-'s idea. It's simple and exactly what I need. It could be implemented at a more generic level, where we could "include" a json block anywhere (although more invasive). This would be really useful for c_cpp_properties.json too, where I am copy/pasting giant blocks of include and search paths.
"environment": [ <project-wide-env-vars> ],
"setupCommands": [ <project-wide-gdb-setup-comands> ],

would be great to have

This would allow different folks on the team to change launch configurations to use either Chrome or Edge based on their preference without generating a Git change.
Current state:
{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Debug config",
            "type": "msedge",
            ...
        },

Ideal state:
{
    "extends": "launch.local.json",
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Debug config",
            ...
        },

launch.local.json:
{
    "configurations": [
        {
            "type": "msedge",
        },

Of course, how to merge the configs would be a discussion to have for sure so both augmenting and completely replacing configuration nodes would be possible.


Fix ScrollController listener invokes callback post-disposal leading to errors

See issue: https://github.com/Ashish-Raturi/scroll_loop_auto_scroll/issues/7

@Ashish-Raturi Any plans to check this MR?


Be able to seamlessly mute the video stream

When I need to deal with tough bandwidth scenarios I sometimes also need to manually mute/unmute the videostream. This is currently only possible with a re-subscription which results in a short connection break where the user is disconnected for a short period of time.
It would be great if I could mute/unmute the video as easy as muting the audio channel.
http://licode.readthedocs.io/en/master/client_api/#schemes describes that licode is already able to mute the video e.g. audio-only mode.

notify-break: Licode will notify subscribers, stop adapting the publisher to problematic subscribers and relegate them to audio-only mode.

My hope is that this functionality can just be explicitly exposed to the client.

We don't have a mute video feature currently in the client, but we'll considering adding it in the future, thanks!


MINOR: Fix LogDirFailureTest flake

Ensure that TestUtils.waitUntilTrue(..) is blocked on both send completed and a new leader being assigned
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please

@dhruvilshah3 Could you please review when you have a moment?

@gardnervickers Thanks for the PR. Could you explain a bit why this test is currently flaky and why the PR fixes the issue?

Sure @lindong28, I believe the issue we were seeing was that producer.send(record) would fail silently because we were not calling producer.send(record).get(), but producer.partitionsFor(topic).asScala.find(_.partition() == 0).get.leader().id() != leaderServerId would return true anyway. Because the producer send was never retried, the test below times out
    // Consumer should receive some messages
    TestUtils.waitUntilTrue(() => {
      consumer.poll(0).count() > 0
    }, "Expected some messages", 3000L)

This patch ensures that both producer.partitionsFor(topic).asScala.find(_.partition() == 0).get.leader().id() != leaderServerId  passes and we successfully send a record before breaking out of the waitUntilTrue loop and progressing to the rest of the test.

Related exception from  jenkins tests:
java.lang.AssertionError: Expected some messages
at kafka.utils.TestUtils$.fail(TestUtils.scala:351)
at kafka.utils.TestUtils$.waitUntilTrue(TestUtils.scala:741)
at kafka.server.LogDirFailureTest.testProduceAfterLogDirFailureOnLeader(LogDirFailureTest.scala:189)
at kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll(LogDirFailureTest.scala:60)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(De

@gardnervickers I see. Thanks for the explanation.
In general we want to make sure that every API will either succeed or timeout within a given limited time in test. So it is preferred to use producer.send(record).get(6000, TimeUnit.MILLISECONDS) rather than producer.send(record).get().
Also, would it be better to fix the test by simply adding producer.send(record).get(6000, TimeUnit.MILLISECONDS) after the code block used for Wait for producer to update metadata for the partition? In comparison to the current fix, the alternative solution seems simpler (by just adding one line). And the logic may also be clearer as we first what for metadata to be updated and then use producer.send(...).get(...) to verify that the message will be sent successfully without any exception.

@lindong28 Thanks! I added a timeout for the producer.send(). I think that we need the producer.send() to be retried inside the waitUntilTrue because we need to wait on a KafkaStorageException to force a metadata update for the producer.


Update to use MediaRecorder instead of Web Audio

We just enabled MediaRecorder in Chrome 49. Would be great to see Voice Memos start using it instead of manually capturing PCM data from web audio.
@samdutton
@miguelao

Yes! It's on my radar, hoping to wire it up next week :)

This is in the latest deployed version :tada: