podvm: disable cloud-init unsafe modules for CoCo

this is executed when CONFIDENTIAL_COMPUTE_ENABLED=yes or based on the EXPLICIT_adapt_cloud_init value, if set
in either case, this is currently disabled for the libvirt provider
Fixes: KATA-3269

tmporary change was to test wheter this is works with libvirt provider, currently thanks to @ajayvic it seems to be failing so i removed this patch for now
[  OK  ] Reached target Cloud-init target.
         Starting Agent Protocol Forwarder...
         Starting Record Runlevel Change in UTMP...
[  OK  ] Finished Record Runlevel Change in UTMP.
[FAILED] Failed to start Agent Protocol Forwarder.
See 'systemctl status agent-protocol-forwarder.service' for details.
[  OK  ] Started Confidential Data Hub TTRPC API Server.


Outage for non US traffic

It appears within the United states vscode.dev is working well but outside of the USA (Ukraine/India) are having issues. Users are stuck connecting.

USA is having issues as well now

Screenshot with possible error on code cli server:

Dev tunnels work on the latest version of vscode. So this apepars to be a vscode related issue


Not compiling with Xcode 6.3, Swift 1.2

Hi!
Thanks for a great library! I used it heavily in an earlier project!
However, in this new project I am experiencing some difficulties due to what I believe to be Swift 1.2.
I am including Block-KVO in my podfile and importing Block-KVO into my Bridging-header file:
'#import <Block-KVO/MTKObserving.h>'
But the project won't compile due to objc_msgsend has too many arguments. This is caused by ENABLE_STRICT_OBJC_MSGSEND being set to YES by default by cocoapods. I have successfully fixed that by adding the followint post_installer script setting said flag to NO.
post_install do |installer|
	installer.project.targets.each do |target|
		target.build_configurations.each do |config|
			config.build_settings['ENABLE_STRICT_OBJC_MSGSEND'] = "NO"
		end
	end
end

I am getting warning 'Block-KVO/MTKObserving.h' file not found.
Just for debugging purposes I than changed that line in the Bridging-Header to use the absolut path to said file, which takes me one step further (which is strange?!?!), and yields this error in the file MTKObserving.h:
"'keypath.h' file not found"
What to do? Any idea?
Thanks a bunch!

Is it related to this code in -observeObject:property:withSelector:?
default: {
    // +3
    // -someObject:didChangeSomethingFrom:to:
    void(*msgSend)(id, SEL, id, id, id) = (typeof(msgSend))objc_msgSend;
    msgSend(weakSelf, observationSelector, weakObject, old, new);
    break;
}

@iMartinKiss Exactly! As I metioned, it seams related to Cocoapods as well: https://github.com/CocoaPods/CocoaPods/issues/3060
But however, my post installer script should fix that. So it seams something else is wrong?
Have you been able to reproduce the error? Just use XCode 6.3 Beta, Swift project with Block-KVO integrated via Cocoapods. Use Cocoapods version 0.36.0. I have iOS 8 as deployment target.
Would be amazing if this could be fixed since I really like Block-KVO :+1:  Thanks!

When you say exactly, does your code contain this line?
void(*msgSend)(id, SEL, id, id, id) = (typeof(msgSend))objc_msgSend;

If it doesn’t, please, pull the latest revision.

@iMartinKiss I have made an example project. Open it using Xcode 6.3 and use Cocoapods 0.36 or 0.36.1, fails on both.

So how do I achieve:
void(*msgSend)(id, SEL, id, id, id) = (typeof(msgSend))objc_msgSend;

?
Thanks a lot! :smile:

Version on CocoaPods is not up to date and it will never be updated again. You should use this repositary directly, the latest commit is correct.

On 27 Mar 2015, at 17:45, Alexander Georgii-Hemming Cyon<EMAIL_ADDRESS>wrote:
@iMartinKiss As you can see in the podfile of the example project I am just using
pod 'Block-KVO'
Which results in version 2.2.1, which results in 'NSObject+MTKObserving.m' containing:
objc_msgSend(weakSelf, observationSelector, weakObject, old, new); // Fuck off NSInvocation!
So how do I achieve:
void(*msgSend)(id, SEL, id, id, id) = (typeof(msgSend))objc_msgSend;
?
Thanks a lot!
—
Reply to this email directly or view it on GitHub.

@iMartinKiss ah okay! Sorry I did not know that. Maybe you can add that info to the README? And also how to "use this repository directly" - can you point me the correct direction on how to do that?
Thanks a bunch!

on my Podfile i tried:
platform :ios, '7.0'

target "GeLoBeaconOTAConfiguration" do
    # pod "Block-KVO", "~> 2.2.1"
    pod 'Block-KVO', :git => 'https://github.com/iMartinKiss/Block-KVO.git'
end

target "GeLoBeaconOTAConfigurationTests" do

end

but im getting the same error.
My apologies if it is wrong but im new on iOS projects. I am trying to run https://github.com/GeLoInc/GeLo-OTAC-iOS .
Cheers

@iMartinKiss, why Cocoapods version will never be updated?


"go back" action when using the CLI

Is your feature request related to a problem? Please describe.
When I use the amplify CLI (eg: amplify update api), I need to select an option among different choices, I sometimes choose the wrong option and I then need to exit amplify and rerun it, it could be nice if I could go back to the previous question

Describe the solution you'd like
an idea would be to trigger a "go back" action by clicking on a key, like Escape

pressing Escape will go to the previous question.

@anisg thanks for the idea, we are aware, unfortunately, the question walkthroughs today are linear and not implemented as a wizard/form, so going back is not viable. We will considering this possibility as well when we redesign/change the DX of the CLI.

@anisg thanks for the idea, we are aware, unfortunately, the question walkthroughs today are linear and not implemented as a wizard/form, so going back is not viable. We will considering this possibility as well when we redesign/change the DX of the CLI.

I would like to see this feature as well, lots of time spent re-doing prompts after typos or mis-interpretations are made

Also waiting for this feature. It's very annoying during setup of Auth category, where you have more than 20 steps during manual configuration and I just did a mistake in one of last of them 😢

👍  Upvote for this feature as well! Can be as simple as adding a new option to choose that goes back haha.


Add self to bash completion of docker node inspect

docker node inspect --help advertises the use of the special nodename self:
root@270166cbebbc:~# docker node inspect --help

Usage:  docker node inspect [OPTIONS] self|NODE [NODE...]

This PR adds it to bash completion.
A minor improvement, does not have to go into 1.12.1.

LGTM :cat:

LGTM


Server side rendering: Whats the deal with glamor usage?

As PR #214 falls short of what i'd like to see in quite a few aspects, i'm trying to implement SSR into styled-components. glamor, which i've always thought this project was based on, has very good  SSR capabilities and also copies the API of aphrodite, which is why i'd also want to go that route and reuse most of the existing glamor functionality such as renderStatic, renderStaticOptimized etc.
After starting to implement, i realized that glamor is used as a dependency, but only certain things are relied on/used. Also, the sheet.js of glamor is not used from the package, but vendored and changed in some way.
Why is a part of glamor vendored exactly? Was this a conscious decision because you wanted to move away from glamor? Can this be reverted? I'm not sure that copying a lot of glamor functionality is a good decision - i'd rather use it directly instead ;)

Why is a part of glamor vendored exactly?

Because it was changed massively.
Contrary to glamor, we have to inject our CSS all at once, not one by one, because we have do it at component creation time to preserve the declaration order. This also means we have to be able to insert CSS at arbitrary places within the style sheet, something glamor doesn't (need to) do either!
See #31 for the bug report, and https://github.com/threepointone/glamor/pull/59 for an abandoned PR to glamor to change that behaviour.
So, no, we cannot revert this I'm afraid. We don't actually really use glamor's functionality, the only thing we can (and do) use is the injection mechanism because it's fast.

Please chime in over at #214 with your suggestions of things you need for server-side rendering, would love to hear which APIs we should add! Thanks!

Also /cc @threepointone @geelen if they have anything to add.


add benchmarks for user-function application

These new benchmarks are meant to exercise user-defined function application. The wrap10_integer nests 10 monomorphic user-defined functions calls. accum applies a function to a list of integers.
These benchmarks are added to measure the impact of adding return-type checking for user-defined functions in #1209.
Cherry-picking these benchmarks onto #1209 and modifying it to run return-type checking an arbitrary number of times gives the following timing results:
$ cabal run -O2 benchmark:bench -- -m prefix defun

Summary for return-type checking
wrap10 and wrap10_integer cost about 3 microseconds per run per return-type check replicate. accum costs about 0.3 microseconds per run with return-type check replicate. These two results are compatible because wrap10 involves 11 function applications, so when we instrument the code to repeat type checking N times, wrap10 will end up type checking 11*N function applications.

Object argument size
object-size/*-object tests user-defined functions applied to various sizes of object.
small-object has a single integer field. medium-object has 8 fields of type integer, bool and small-object. large-object has 16 fields with those same types.
small-object (1 field): 182us +/- 18us
medium-object (8 fields): 236us +/- 16us
large-object (16 fields): 300us +/- 20us
=> About 8us per record field

List argument size
list-tc/000-items: 185us +/- 10us
list-tc/001-items: 171us +/- 4us
list-tc/100-items: 385us +/- 11us
=> About 2.2us / item

@jwiegley Yeah, Emily and I have started brainstorming on ideas of how to keep a chronology of benchmark results, so we could treat certain changes as regressions. Wonder if we should do some discussion about this as an epic.


Kelvin?

Can't set kelvin on RGBWWCW lamps. Is it possible to fix that?

Hi.
Thanks for using node-red-contrib-milight. I'll add support for setting the white temperature asap. Note, however, it is not possible to provide a kelvin value directly, but a relative value (ranging from 0 .. 100) can be set.

released


Made it worse

Hey I have encrypted blank grabber with blankrypt and its even worse before encrytion virustotal said 30 detections but after the encryption it said 32

Thats because its being used by many people to crypt their viruses. A way to fix it is to build the crypter from source (which is not possible anymore due to new Vlang updates)
And so this project is discontinued


Average size of commons.js

Hey, just wondering what the average size of your commons.js is. Because for me I have just run one of the samples and it's already > 3mb.
Is this normal?
Thanks,
Nico

Ah it was probably because I was running in dev mode 🙈


Add missing instructions for docs. build

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.723%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
9910

Relevant Lines:
11697

💛  - Coveralls


DeviceBatteryXX icons look all the same.

I created a react component with a card and list with list items representing each and every icon found in the material-ui project. I am noticing that some of the icons look the same:

At the same time, I am noticing a new message that appeared in the chrome console:

The component in question is:
https://github.com/codefoundries/isomorphic-material-relay-starter-kit/blob/master/webapp/components/MUI_Icons.js
Link to the whole project:
https://github.com/codefoundries/isomorphic-material-relay-starter-kit
In case it makes any difference, the list of icons was generated using:
https://github.com/codefoundries/isomorphic-material-relay-starter-kit/blob/master/scripts/generate_MUIIconList.js

The battery icon looks the same because of the wrong fill-opacity property.
For instance battery-50 shoud look like

Turns out, that's a duplicate of https://github.com/callemall/material-ui/issues/1577.

@thelordoftheboards That should be easy to fix, I'm gona make a PR.

Thank you this is awesome!


support multiple nodes of a graph, apply different endpoint env for different node

Description
#166
this PR also adopt the new manifest, when new manifest is merged, some unnecessary code will be removed for simplicity
mark it as draft
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.
Type of change
List the type of change like below. Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would break existing design and interface)

Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.

use #203 to commit code


Issue with spacebar in new update

With apologies for being totally illiterate when it comes to coding, I'm experiencing an issue related to typing habits that I think was occasioned by the new update, specifically the autocomplete feature using the spacebar.
When Roam42 is enabled, shift+space does not produce a space; when disabled, it does. It's made me realize that I often press the spacebar before I've dismounted the shift, as when I begin sentences with "I."
The problem is surely with my own typing habits, but it'd be nice to have the option to disable this function, as you've done for some of the other functions.
In any case, thanks for your great work on this! I love Roam42.

Thank you for reporting this. I think I have fixed it. I will just test it for a day or two, then push it out to the public. So please try again in a few days. If it's still not working, please reopen this issue.
good catch!! :-)


fix: Inconsistent/broken behavior in parseDate

This is a rebasing of PR #3988 by @maranomynet on top of the current main branch.
Some minor changes relative to the commits in #3988:

changed assert to expect in tests
file names changed from .js to .ts
in index.tsx, removed minDate parameter when calling parseDate

Other than that, same changes and same commit messages with the same 4 commits as PR #3988.
Contribution checklist

[X] I have followed the contributing guidelines.
[X] I have added sufficient test coverage for my changes.
[X] I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Can you take a look at the merge conflicts? I think we can release this with a major upgrade soon.

This should be ready to be merged, but let me know if any further work is required.

Hey all, any thoughts on when this might merge? This is quite valuable for data consistency

@jseibert I think because this is a breaking change, it requires a major version bump.
@martijnrusschen Is there any timeline for a v8.0 release?


Add zijianjoy (jamxl) to Kubeflow.org, Google and ci-team members, fixed instruction in README

Add James Liu to kubeflow.org and Google team members.
Update command line instruction for running pytest.

/lgtm
/approve
@zijianjoy Welcome to Kubeflow!


Make pando debug-check explicit

Describe your changes
Instead of using process.env[NODE_ENV], which is framework dependent (see #1264), this moves the debug check into an explicit variable, which can be set by downstream users using setDebugMode.
The original design is to have the isDebug flag in calc, but there are multiple free functions accessing this env variable as well, so I move it into module-wide variable.
Currently, it can only be toggled on or off, but it can be separate into "calculator debug" and "tag database debug" if needed.
Issue or discord link
https://discord.com/channels/785153694478893126/819643218446254100/1171934532899971172
Testing/validation
n/a
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code, in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] Ran yarn run mini-ci locally to validate format + lint.
[x] If there were format issues, I ran nx format write to resolve them automatically.

Address, for pando specifically, #1264 (which may still be ongoing for other modules).


Clean up behavior of "next step button"

Right now, it sometimes looks like it should have submit button functionality when it does not. Also, it and the countdown should maybe not be at the top of the page. See https://github.com/littleweaver/django-brambling/commit/37f4f8a2263e#commitcomment-8032523 and nearby comments

My going theory is to make more of the views single column and have a static side column that has the timer, and the next step button.

Gonna try it.

Resolved by bf65fd06185e83ff208f3b4bbfef08b0beb1756b


WIP: Device by path

This PR attempts to solve the problem of the library only expecting there to ever be one key connected. It tries to solve this by moving many of the global functions which act upon a device (using the get_device) function into member function of a device.
So far I've moved the the get_info and pin functions into the fidokey module. You can see in the updated get-info example how this is used, and can now fetch the info of all connected keys instead of just the first one the library happens to see.
This also adds build tests for macOS and Ubuntu to ensure that any changes I make at least don't break the build across multiple platforms.
Finally, I've removed the linux specific code and am testing it more extensively on some linux machines that I have to determine exactly what from them is still needed :)

@gebogebogebo, drop me a line on Keybase @obelisk and we can discuss this PR and future work there more easily if needed!

Confirmed this breaks Linux 😓
Working on fixing that!

Hello, I'm Linux!
----- get-info start : key_auto = true -----
get_hid_devices()

vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=1 usage=6 serial_number=4082-59-8f-c2-d0 path="/dev/hidraw1""
vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=1 usage=2 serial_number=4082-59-8f-c2-d0 path="/dev/hidraw1""
vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=1 usage=1 serial_number=4082-59-8f-c2-d0 path="/dev/hidraw1""
vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=65280 usage=1 serial_number=4082-59-8f-c2-d0 path="/dev/hidraw1""
vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=65280 usage=2 serial_number=4082-59-8f-c2-d0 path="/dev/hidraw1""
vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=65280 usage=4 serial_number=4082-59-8f-c2-d0 path="/dev/hidraw1""
vid=0x046d , pid=0xc52b , info="product=USB Receiver usage_page=65280 usage=1 serial_number= path="/dev/hidraw0""
vid=0x046d , pid=0xc52b , info="product=USB Receiver usage_page=65280 usage=2 serial_number= path="/dev/hidraw0""
vid=0x046d , pid=0xc52b , info="product=USB Receiver usage_page=65280 usage=4 serial_number= path="/dev/hidraw0""
vid=0x1b1c , pid=0x0c04 , info="product=Integrated USB Bridge usage_page=65280 usage=1 serial_number= path="/dev/hidraw4""
vid=0x1050 , pid=0x0407 , info="product=YubiKey OTP+FIDO+CCID usage_page=1 usage=6 serial_number= path="/dev/hidraw7""
vid=0x1050 , pid=0x0407 , info="product=YubiKey OTP+FIDO+CCID usage_page=61904 usage=1 serial_number= path="/dev/hidraw8""
vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=1 usage=6 serial_number=0 path="/dev/hidraw3""
vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=1 usage=128 serial_number=0 path="/dev/hidraw5""
vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=12 usage=1 serial_number=0 path="/dev/hidraw5""
vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=1 usage=6 serial_number=0 path="/dev/hidraw5""
get_fidokey_devices()

vid=0x1050 , pid=0x0407 , info="product=YubiKey OTP+FIDO+CCID usage_page=61904 usage=1 serial_number= path="/dev/hidraw8""
get_info()
versions                           = ["U2F_V2", "FIDO_2_0", "FIDO_2_1_PRE"]
extensions                         = ["credProtect", "hmac-secret"]
aaguid(16)                         = C5EF55FFAD9A4B9FB580ADEBAFE026D0
options                            = [("rk", true), ("up", true), ("plat", false), ("clientPin", false), ("credentialMgmtPreview", true)]
max_msg_size                       = 1200
pin_uv_auth_protocols              = [1]
max_credential_count_in_list       = 8
max_credential_id_length           = 128
transports                         = ["usb", "lightning"]
algorithms                         = [("alg", "-7"), ("type", "public-key"), ("alg", "-8"), ("type", "public-key")]
max_serialized_large_blob_array    = 0
force_pin_change                   = false
min_pin_length                     = 0
firmware_version                   = 0
max_cred_blob_length               = 0
max_rpids_for_set_min_pin_length   = 0
preferred_platform_uv_attempts     = 0
uv_modality                        = 0
remaining_discoverable_credentials = 0

get_pin_retries()
error: response_status err = 0x35 CTAP2_ERR_PIN_NOT_SET No PIN has been set.
get_info_u2f()
U2F_V2
----- get-info end -----

Ok I think this works now, I changed the backend out for linux-static-hidraw. This should give us better parity with macOS, and Windows as well as being able to remove all the Linux specific code!
Here is some output from the new get-info build (note that VID and PID are now present):
Hello, I'm Linux!
----- get-info start : key_auto = true -----
get_hid_devices()
- vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=1 usage=6 serial_number=4082-59-8f-c2-d0 path=\"/dev/hidraw1\""
- vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=1 usage=2 serial_number=4082-59-8f-c2-d0 path=\"/dev/hidraw1\""
- vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=1 usage=1 serial_number=4082-59-8f-c2-d0 path=\"/dev/hidraw1\""
- vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=65280 usage=1 serial_number=4082-59-8f-c2-d0 path=\"/dev/hidraw1\""
- vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=65280 usage=2 serial_number=4082-59-8f-c2-d0 path=\"/dev/hidraw1\""
- vid=0x046d , pid=0x4082 , info="product=USB Receiver usage_page=65280 usage=4 serial_number=4082-59-8f-c2-d0 path=\"/dev/hidraw1\""
- vid=0x046d , pid=0xc52b , info="product=USB Receiver usage_page=65280 usage=1 serial_number= path=\"/dev/hidraw0\""
- vid=0x046d , pid=0xc52b , info="product=USB Receiver usage_page=65280 usage=2 serial_number= path=\"/dev/hidraw0\""
- vid=0x046d , pid=0xc52b , info="product=USB Receiver usage_page=65280 usage=4 serial_number= path=\"/dev/hidraw0\""
- vid=0x1b1c , pid=0x0c04 , info="product=Integrated USB Bridge usage_page=65280 usage=1 serial_number= path=\"/dev/hidraw4\""
- vid=0x1050 , pid=0x0407 , info="product=YubiKey OTP+FIDO+CCID usage_page=1 usage=6 serial_number= path=\"/dev/hidraw7\""
- vid=0x1050 , pid=0x0407 , info="product=YubiKey OTP+FIDO+CCID usage_page=61904 usage=1 serial_number= path=\"/dev/hidraw8\""
- vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=1 usage=6 serial_number=0 path=\"/dev/hidraw3\""
- vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=1 usage=128 serial_number=0 path=\"/dev/hidraw5\""
- vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=12 usage=1 serial_number=0 path=\"/dev/hidraw5\""
- vid=0xfeed , pid=0x1307 , info="product=ErgoDox EZ usage_page=1 usage=6 serial_number=0 path=\"/dev/hidraw5\""
get_fidokey_devices()

---------------------------------------------
- vid=0x1050 , pid=0x0407 , info="product=YubiKey OTP+FIDO+CCID usage_page=61904 usage=1 serial_number= path=\"/dev/hidraw8\""
get_info()
- versions                           = ["U2F_V2", "FIDO_2_0", "FIDO_2_1_PRE"]
- extensions                         = ["credProtect", "hmac-secret"]
- aaguid(16)                         = C5EF55FFAD9A4B9FB580ADEBAFE026D0
- options                            = [("rk", true), ("up", true), ("plat", false), ("clientPin", false), ("credentialMgmtPreview", true)]
- max_msg_size                       = 1200
- pin_uv_auth_protocols              = [1]
- max_credential_count_in_list       = 8
- max_credential_id_length           = 128
- transports                         = ["usb", "lightning"]
- algorithms                         = [("alg", "-7"), ("type", "public-key"), ("alg", "-8"), ("type", "public-key")]
- max_serialized_large_blob_array    = 0
- force_pin_change                   = false
- min_pin_length                     = 0
- firmware_version                   = 0
- max_cred_blob_length               = 0
- max_rpids_for_set_min_pin_length   = 0
- preferred_platform_uv_attempts     = 0
- uv_modality                        = 0
- remaining_discoverable_credentials = 0

get_pin_retries()
error: response_status err = 0x35 CTAP2_ERR_PIN_NOT_SET No PIN has been set.
get_info_u2f()
U2F_V2
----- get-info end -----

Thank you !
Please give me a moment to take a closer look at the code.

Any thoughts on this? Would like some feedback before I jump in and try to refactor more functions.

One PR contains many issues.
Is it possible to divide the discussion into multiple PRs of smaller units?
I find it difficult to make a decision because of the volume of revisions I have to make.
I would like to at least divide it into the following issues

Handling of Multiple Devices.
Per-command packaging (refactoring).
Linux Support Improvements(I do not declare Linux support, I support Raspberry Pi OS)
adds build tests

How about creating one feature branch and then creating multiple small issues to merge into that branch?
Once you have received consent, create a FEATURE branch.

I can split the PR into a few. Definitely the build tests are easy to split out. Linux support is also easy. The handling of multiple devices though and the per-command packaging are intertwined so they cannot be easily separated.
In addition, the per-command packaging is dependent on the Linux PR so while I can split it, we'd need to merge the linux support first.
As for Raspberry Pi OS support, that is Linux. Raspberry Pi OS is based on Debian Linux, so this will support that, plus others with less code here if we move to the new backend for hidapi on Linux :)

Thank you.
I don't speak English very well.

How about creating one feature branch and then creating multiple small issues to merge into that branch?
Once you have received consent, create a FEATURE branch.

What I wanted to say here is that I want you to create a PR that merges into the development branch, not a PR to master.
I just published a [develop] branch.
https://github.com/gebogebogebo/ctap-hid-fido2/tree/develop
Please give PR to this branch. :)

@gebogebogebo Your English is better than my Japanese! You can always message me on Keybase if you need.
I've split the PRs up anyway, since that's probably the better thing to do. Can we merge the build and Linux ones to master, then we can move discussion of the refactor to #46 ?
In that PR, let's discuss the path forward!

Closing this in favour of #44 #45 #46


create a resolver for requirejs syntax

Need a resolver to handle require.js syntax:
require(['lib/myDependency'], function {
    //Do What you want
});

where lib/myDependency is relative to current js file and omitt .js suffix.

I've never used requirejs. Could you give me a bit more details on exactly what you'd like to have happen?
Resolvers use asset names taken from the humpty configuration. Are you suggesting that the requirejs configuration be read instead?


Preview app failing when NodeJS's version is not >=20

Describe the Bug
Ran the automatic install commands to set up some boilerplate using pnpm create email.
When running pnpm dev, I get presented with the following error:
Error: The "path" argument must be of type string. Received undefined

pointing to the following code:
https://github.com/resend/react-email/blob/7028a581bac498bec90dce91277e0ec1de8f3221/packages/react-email/src/actions/get-emails-directory-metadata.ts#L67-L71
Which package is affected (leave empty if unsure)
react-email
Link to the code that reproduces this issue
https://github.com/resend/react-email
To Reproduce
Run pnpm create email, install the packages, run pnpm dev.
Expected Behavior
No error.
What's your node version? (if relevant)
18

I am having the same problem.

Really weird issue, are you all using Windows?

Just had the same issue. Updating to nodejs 21.6.1 helped.

@tim3w4rp Were you using Windows?

Really weird issue, are you all using Windows?

No, I'm using macOS

@GeovannyGil Would you mind making a quick reproduction of the issue?

@tim3w4rp Were you using Windows?

macOS 14.2.1 (23C71)
nodejs 19.8.1
using npm to run it
reproduction was basically same as the original post

Upgrading to node 21.6.1 was the fix for me

The issue is that dirent.path was introduced in Node v20.1.0.
(property) Dirent.path: string
The base path that this fs.Dirent object refers to.

@since — v20.1.0

PR open for this #1257, thanks @connorwinston for pointing this out.

Fixed a new canary release<EMAIL_ADDRESS>lmk if it works out for you all.

@gabrielmfern I added<EMAIL_ADDRESS>and I am still presented with this issue.
Same stack trace is presented.
Node v18.16.1
OSX


Add SIG Architecture Conformance spotlight interview

Spotlight article on SIG Architecture: Conformance, the first of the series.
Contributor-site PR: https://github.com/kubernetes/contributor-site/pull/431 ; content is currently in sync, and I will update this one with the result of the review in the contributor-site PR, so for general changes please add to that one (changes specific to the website  are welcomed here though).

/hold
publication date not yet confirmed

/lgtm

/hold cancel

Previewed this locally; it looks OK to me
/approve


User completes the organization profile

Description:
As an org rep, I want to complete the organization profile so that  I can start registering facilities
As John Smith (aka Prime Gertrude), I want to submit a request on behalf of 123 Co. to register in OBPS
Assumption: John has already logged in to his individual BCeID account, which is connected to 123 Co.'s Business BCeID (so that we can confirm John is associated with 123 Co.)
See https://www.figma.com/file/LsDmLDCdnJqI8UahyqvOD8/Registration-app?type=design&node-id=4-2&mode=design&t=lp8DwUm6T8XDYKso-0 for wireframes
Acceptance Criteria:
Given I am an external user logged in to my Business BCeID account
When I request access to the Registration app on behalf of my company
Then a record should be created that captures my company's request to register for OBPS
Development Checklist:

[ ] API endpoint to POST request on behalf of organization to register
[ ] when the request is received by the API, database should be updated to indicate that a request has been received for the organization to register
[ ] when the request is received by the API, database should be updated to indicate that John Smith submitted the registration request
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

Hey team! Please add your planning poker estimate with Zenhub @andrea-williams @BCerki @dleard @JoshLarouche @Sepehr-Sobhani

Is the "organization profile" the form Prime Gertrude will have to fill out before clicking "request access to the registration app"?

We won't be able to test this until we receive development data from https://app.zenhub.com/workspaces/team-moose-sprint-board-60d216175a2689000ec774d0/issues/gh/bcgov/cas-registration/198.


Dialog sheet adaption on native with snapPointsMode="fit"

Current Behavior
The problem with Dialog with Sheet adaption on native. When snapPointsMode="fit" is set on Sheet root component, the Adapt.Contents is rendering in a wrong way:
There is some extra bottom padding added on the bottom of the sheet on Android device. When I am trying to inspect that to check if it is some extra padding which I added by mistake I cannot even inspect that space by clicking on it.
Moreover closing animation is some kind of laggy - Sheet jumps up and then is closing.
Also Sheet content is disappearing while sheet is closing but I assume that is desirable behaviour of the Adapt.Contents
https://github.com/tamagui/tamagui/assets/108800119/fb3c9206-499d-4518-a6a8-7b90cd360757
Expected Behavior
When snapPointsMode="fit" is given to Sheet component it should work and behave in the same way as snapPointsMode="percent" (default) - No flickering of animations and no extra bottom space on android
https://github.com/tamagui/tamagui/assets/108800119/0e16aa38-dbd4-4c59-b18c-fcdf3fc10bb7
Tamagui Version
v1.86.4

Platform (Web, iOS, Android)
iOS, Android

Reproduction
https://github.com/Maciej-Siara/tamagui-issue

System Info
System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M2
    Memory: 90.94 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.5.0 - ~/.nvm/versions/node/v20.5.0/bin/node
    Yarn: 4.0.2 - /usr/local/bin/yarn
    npm: 10.2.5 - ~/.nvm/versions/node/v20.5.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.234
    Firefox: 112.0.1
    Safari: 17.2.1
  npmPackages:
    @babel/runtime: ^7.18.9 => 7.21.0
    @manypkg/cli: ^0.19.1 => 0.19.2
    check-dependency-version-consistency: ^3.0.3 => 3.0.3
    eslint: ^8.21.0 => 8.39.0
    node-gyp: ^9.3.1 => 9.3.1
    prettier: ^2.7.1 => 2.8.8
    turbo: ^1.10.3 => 1.10.3
    typescript: ^5.3.3 => 5.3.3

Bumping this, have seen the same issue were using "fit" adds extra padding to the bottom only on some Android device.

It is still happening in v1.97.1 with modal flag active and snapPointsMode 'fit', only in Android devices.

@Maciej-Siara @thed24 I managed to solve solve the problem by doing the following:

and using "bottomFixPosition" in overlay bottom and Shhet.Frame bottom property.

@Maciej-Siara @thed24 I managed to solve solve the problem by doing the following:
and using "bottomFixPosition" in overlay bottom and Shhet.Frame bottom property.

Thanks @valdenio the workarround worked. U can implement the workarroun for sheet base component directly like this:
const FrameStyled = forwardRef<View, GetProps<typeof Frame>>((props, ref) => {
	const { top } = useSafeAreaInsets();

	const bottomFixPosition = useMemo(() => {
		return Platform.select({
			android: top * -1,
			default: undefined,
		});
	}, [top]);

	return <Frame bottom={bottomFixPosition} {...props} ref={ref} />;
});

const SheetSuspended = withSuspenseInitialRender(SheetStyled, {
	fallback: null,
});

const Sheet = withStaticProperties(SheetSuspended, {
	CloseButton: SheetCloseButton,
	Footer,
	Frame: SheetBase.Frame,
	FrameWithFitContent: FrameStyled,
	Header,
	Overlay: SheetBase.Overlay,
	SearchBar,
	Subtitle,
	Title,
});

export { Sheet };

here i'm creating new frame for Fit snap point only


Add list constraint logic and integration tests

What does this PR do?
Adds the list filters on resources fetched from Conjur server
What ticket does this PR close?
Resolves #91
Checklists

[x] Logic has been implemented
[x] Integration tests have been added
[x] Forward facing logs have been reviewed and approved by PO/TW

Change log

[x] The CHANGELOG has been updated, or
[ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

[x] This PR includes new unit and integration tests to go with the code changes, or
[ ] The changes in this PR do not require tests

Documentation

[ ] Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
[ ] This PR does not require updating any documentation
Docs will be addressed in a separate PR

Add return types to functions using -> at the function decleration

Add return types to functions using -> at the function decleration


lightswitch: masking (espruino/Espruino#2151) + oversize

@gfwilliams Utilizing the issue espruino/Espruino#2151 to stop the corresponding event handlers works very nice on my own watch for the last two month, but I don't know if it is "good manners".
Update ChangeLog and metadata.json
Update README.md and settings.json

add oversize setting + description
Update settings.js
add oversize setting
correct default value of touchOn according to value in README.md
Update widget.js
add oversize setting
correct default value of touchOn according to value in README.md
add masking touch and drag input by adding own event listeners first and messing up the handler on a widget related event, using espruino/Espruino#2151

Hi, I'll merge this but...

Utilizing the issue https://github.com/espruino/Espruino/issues/2151 to stop the corresponding event handlers works very nice

I'm pretty iffy about this, as it really is taking advantage of a bug. When it finally gets fixed, that functionality in your app will stop working. Not sure if there's a way I could implement the feature nicely in Espruino (doing something based on the return value?).


Split memcache client into generic and Frank parts

@tomwilkie Should we move the metric tracking to the generic memcache code? That way there's more we can reuse when backporting to Scope.

1 minor nit, otherwise LGTM


Non-Ferocity Pet Talent Ability Usage Missing

Describe the bug
Some abilities such as Wolverine Bite and Roar of Recovery never seem to be used by the selected Cunning pet, with the necessary talents picked. This results in lower than actual DPS when non-ferocity pets are selected.
To Reproduce
Steps to reproduce the behavior:

Go to Hunter Sim
Click on Talents, Select Pet, Select for instance a Cunning Pet such as a Dragonhawk.
Unlearn some talents so you can learn Roar of Recovery for instance or Wolverine bite
Start a sim
Check the combat log of the sim
Search for "wolverine" or "recovery" and you won't find these abilities used at all.

Expected behavior
I would expect Wolverine Bite to be used constantly, though I am not sure if it's a DPS increase.
Roar of Recovery should be used for instance the first time the Aspect of The Viper would be turned on, at the user setting of 20% mana or whatever.
Sim Links and Screenshots
Desktop (please complete the following information):

OS: Windows
Browser Opera GX
Version: -

It does use Wolverine Bite, but there's a different issue with the icon not loading properly so the row is not easily noticeable (the icon is simply blank). I'll look into fixing this.

@jimmyt857 Thanks for the reply.
I ran another simulation this time with a spider pet with Wolverine Bite learned and I still can't see it in the simulation log.
spider_cunning_wolverine_bite.txt
Uploading the log here.

Here's the link to the build, I'm not sure if it contains the pet talent selections as well but it might make things easier for you.
https://wowsims.github.io/wotlk/hunter/#eJztVE1oE0EU3vfy082gdCz+TMKmpntahMJuQqARyqwFMQcPUS8e9WDx4CH01PYUlUrpyYBKzEWxCJ6KiNoE6x/2UrG2RGhRLLRiJGLFCCoFe+ibrB6KigTizY/9Zmffm3nfm5k3y6I6cLDAhh44BlnIAZwHuAk4D1AD6Nuh3DFyZ8g5CnADoIDYgT0Q+R44A8HMqeNDJwZ05BiZANbOH9ZQvI+awbtPcGUSmZ+vV5Ft4R/foliOmj5la+P5ByguGjR6cgrF7bAZJPPzWWSMz91CMdJpgsa28hI5Lximn5wahTj7DkXe8EK080ek84l08iU8V1Ix18ooLhkkWJxSsmNl1a7eV+3SSzVg+h6KL1GmUfcxdQuGyXVUyz7qH1TLpsVdQ0qigNp//BYddrMzhnVVPoJKZ+8Q258GC3XY1vC4V9y+GEM9QGwjhog6kRF9RCSCU7ysUJapRAMvZAYiNhXbrshOalXZous7iVkcVMdXAOjydOsyNftMYVVaMAZW0na6bTuZsJNOd9ImJOLqpWKSNe4ol0PPGxD61Tnk41UU16sYW6yg9bSC9kIFa+CvQ6gI2ivQiqiZrzHUkMr1u2EvzRmZ8tTnZVd/AwsyfgdjR4S+5x8XVf2024owuZnplsRpBt6eHVxy93nfazJNP6LDmy6id/qBH7ktS2+/P8sWpeD+VO5li+PZ3m9y98iHQ6XOr03Gr7cqn7/i14uYXhnePnEg7P5pxgb4haJ9

It's in the log too, but the same issue is present where the name is blanked out. Try searching for the spell ID (53508) instead of the name and you'll see some of the debug log statements.
Here it is in the results tab:


Document ibmcloud Lenovo machine boot order requirement

Better yet, lets start a document expanding any vendor specific boot order or bmc configuration requirements.

The boot order for lenovo hardware should be:
Legacy Boot -> CD/DVD Rom -> Network -> Hard Disk
** CD/DVD Rom: Must to be first for image for mounting virtual media (also for SuperMicro hardware)
I have attached a screenshot with the right boot order:

Is this still relevant?
If that's the case, @ebattat could you please open a PR to update the docs?
Thanks

We can close this issue


Can't connect to host

Hello!
At first, I would like to thank for the development of this server! Sir Ochii thank you for your hard work!
We are overtaken by the following error: User 's unreadied in room and kicks from the server for loading 10%.
We are opened server on GCP (google cloud platform). Opened all ports for server needed.
We can enter on the server and can join in room but we cant play together with my friends.
As soon as I start the server my friends loading to 10% and it stops. Then 10-20 seconds later he have kicked from room with error Game server connection failed and in the consoce serve writes it:
host "DraveMor" updated room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s settings (id: 2) user "DraveMor" tried to toggle a room's game start countdown, although it can't start. room name "CSO2_UI_DEFAULT_ROOMTITLE_001" room id: 2 user "GudVether" readied in room "CSO2_UI_DEFAULT_ROOMTITLE_001" (id 2) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 6 (host says it's at 6) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 5 (host says it's at 5) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 4 (host says it's at 4) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 3 (host says it's at 3) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 2 (host says it's at 2) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 1 (host says it's at 1) room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id 2) countdown is at 0 (host says it's at 0) host "DraveMor" started room "CSO2_UI_DEFAULT_ROOMTITLE_001"'s (id: 2) match on map 7 and gamemode 3 user "GudVether" unreadied in room "CSO2_UI_DEFAULT_ROOMTITLE_001" (id 2) toggleUserReadyStatus: host tried to toggle ready

NodeJS -v: 10.15.3
NPM -v: 6.4.1
OS: Windows server 2016
Please help...
Server release latest.

Make sure the room's host has enabled NAT in its network's router. Does the server allow inbound/outbound UDP traffic?

Make sure the room's host has enabled NAT in its network's router.
Does the server allow inbound/outbound UDP traffic?
Also put your server version instead of saying it's the latest one

NAT is enabled on host router.
UDP traffic is allowed as well:

And server version is - 0.8.14

Try adding this code to line 185:
        // ...
        if (packet.isHeartbeat()) {
            console.log('Received holepunch heartbeat, ignoring...')
            return
        }
        // ...

This will log any incoming "heartbeat" (side note: I'm not sure if it's a heartbeat) packets.
And in line 206:
        // ...
        console.log('User %s holepunched. IP: %s (internal %s) Client Port: %i (internal %i)'
            + 'Server Port: %i (internal %i)',
            user.userName, user.externalIpAddress, user.localIpAddress,
            user.externalClientPort, user.localClientPort)
        // ...

This will log an user's internal and external IP addresses, and the ports to be used by the host or guest.
Feel free to hide the IP addresses. I want to know if the server is receiving any holepunching attempt.

Yes send me please a build, I'll test it now

https://a.uguu.se/SH1ayQscRgqy.gz

log.txt
Here is a log file from server. We can't connect with my friend again. Error 2004 still have.

Did you try to play in some other server?

We now trying run server with hamachi network with another computer. And problem is solved. We are successfully connect and playing

In google RPD problem still have. And I don't know how it resolve.
For any decision my trouble I would grateful

In google RPD problem still have. And I don't know how it resolve.
For any decision my trouble I would grateful

Run a OpenVPN server on your server and disallow Internet traffic should be good.

you and the host need connect to a virtual LAN, or need host in the public IP state (you can use https://pingmyip.org/ for testing), currently the server will not be responsible for forwarding the traffic data between the two people.
if no one has a public IP, this can be solved by using the P2P hole punch tool (just like Hamachi), or connect to a virtual LAN through a VPN

I have the same situation.
My friend has such a problem. (Although the launcher"CSO2" are the same).
My ports are all open.
NPM: 6.4.1
NodeJS: v10.10.0
OS Server: Debian 4.9.110-3+deb9u2 (Linux)

I have the same situation.
My friend has such a problem. (Although the launcher"CSO2" are the same).
My ports are all open.
NPM: 6.4.1
NodeJS: v10.10.0
OS Server: Debian 4.9.110-3+deb9u2 (Linux)

as I said above, there is no other solution, if the situation allows, and the number of people is not large, the use of P2P hole punch tool is the fastest solution.

Can you ping it?


ensures opengl texSpaceMat is initialized from the get-go

cleans up those
0(473) : warning C7050: "objToTangentSpace[0]" might be used before being initialized
0(473) : warning C7050: "objToTangentSpace[1]" might be used before being initialized
0(473) : warning C7050: "objToTangentSpace[2]" might be used before being initialized
warnings.

Sounds like a good idea!


Return error code when process exits with error

Current behavior
With the exception of this metadata error that usually occurs when you're not running inside a project:
https://github.com/holmgr/cargo-sweep/blob/475ac9ec16518596fc21cb2ea77bd8045b5a4a6d/src/main.rs#L154-L157
For every possible error in cargo-sweep, it reports the error and exits with a success exit code.
Expected behavior
The cargo-sweep process should exit with an error exit code.

Some technical details for someone who wants to pick this:
I suggest you move contents from main to a new run function, and execute it from main, then use the error! macro in case Result::Err is returned from run.
Fixing on main will break some integration tests that panic when they see an error exit code.

I suggest you move contents from main to a new run function, and execute it from main, then use the error! macro in case Result::Err is returned from run.
Fixing on main will break some integration tests that panic when they see an error exit code.

I don't agree with this, I think we should continue to use anyhow::Error in main to report errors. To fix the tests we can just update them to look at stderr instead of stdout.
See also https://github.com/holmgr/cargo-sweep/pull/88#discussion_r1096578892.

@jyn514 but we can't return anyhow::Error in main, because we are using error! to report our errors and not Debug.
Why call error! for each error instead of having the caller receive it with .context() and have just one place for reporting? It's pretty common to have functions return an error with all the details to be reported.

@jyn514 but we can't return anyhow::Error in main, because we are using error! to report our errors and not Debug.
Why call error! for each error instead of having the caller receive it with .context() and have just one place for reporting? It's pretty common to have functions return an error with all the details to be reported.

I don't think we should be using error! though - if you look at the current code, we're inconsistent about what uses error!, e.g. https://github.com/holmgr/cargo-sweep//blob/c4c5e19dffe36b86bd6c76b186d40b8fcc1de53f/src/main.rs#L184-L186 and what returns an error from main, e.g. https://github.com/holmgr/cargo-sweep//blob/c4c5e19dffe36b86bd6c76b186d40b8fcc1de53f/src/main.rs#L154-L162
I guess standardizing on error! instead of main is fine, but it does seem like a bit of extra work for little benefit.

I guess standardizing on error! instead of main is fine

By main you mean Err returning on main, right?
My suggestion of wrapping stuff around a run function is just if you choose to be consistent using error!(), but of course, it doesn't make sense for what you suggested (returning Result on main, but that changes how most errors are currently reported).

Shouldn't this issue be closed by now? I can't reproduce exit code 0 on errors. Some of the erroring commands I've tried:

cargo sweep -r -t 30 -i from #111
cargo sweep --file from #117
cargo sweep --stamp name_here from #118

I found some https://github.com/holmgr/cargo-sweep/blob/507575643ff344cfd0326a8d13ec0b6836f16fda/src/main.rs#L187-L190


Thesis/support for dependency resolving in Winery

Start and end date: 01.04.2020 - 26.11.2020
Contributor: Emre Barlas, @barlasemre
Supervisor: Lukas Harzenetter, @lharzenetter
This pull request contains the changes to integrate the Packager Framework(https://github.com/zimmerml/TOSCA_packager) with Winery via Export CSAR process.
In order to support the dependency resolving of the VM Images, we have to download and include the relevant ISO files when creating a CSAR export. If the files are already existing in our repository, find them based on their naming pattern and use it for the export. Same applies for the Docker images. Docker containers will be builded during the process of exporting.

[ ] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[ ] Ensure that the commit message is a good commit message
[ ] Ensure to use auto format in all files
[ ] Ensure that you appear in NOTICE at Copyright Holders
[ ] Tests created for changes
[ ] Documentation updated (if needed)
[ ] Screenshots added (for UI changes)

Can one of the admins verify this patch?

It seems you created your branch based on the ustutt branch from the OpenTOSCA origin, which is wrong. You have to create your branch based on origin/master. Please fix this since otherwise we are not able to merge your changs.

changed the base branch. Re-opened with another branch


Update README.md

add zerotaxjobs.com to remote jobs section of README.md

@sammokhtary Please read the contributions guide before submitting a PR. Thanks!


Ollama running locally with very high latency

What is the issue?
I have installed ollama and tried to run llama2, llama3:8b but it is generating just 5 to 8 tokens per second , my system config: windows os, 16gb RAM
I also tried it on ec2 instance  in aws with g5.xlarge instance type but facing the same latency, why it is happening?
OS
Windows
GPU
Intel
CPU
Intel
Ollama version
0.1.39

Certainly! Here's a GitHub Issue in the proper format for reporting the high latency experienced while running ollama locally and on AWS EC2 instances.
# Issue #4843 - High Latency with Ollama Running Locally and on AWS EC2

## Description of the Issue

I have installed `ollama` and tried to run `Ilama2` and `Ilama3:8b`. However, the performance is significantly lower than expected, generating only 5 to 8 tokens per second. This issue is observed both on my local system and on an AWS EC2 instance.

### Local System Configuration:
- **Operating System:** Windows
- **RAM:** 16GB
- **CPU:** Intel (Specific model not mentioned)
- **GPU:** Intel

### AWS EC2 Configuration:
- **Instance Type:** g5.xlarge

Despite the hardware differences, both environments exhibit the same high latency.

---

### Steps to Reproduce

1. Install `ollama` version `0.1.39`.
2. Attempt to run `Ilama2` or `Ilama3:8b`.
3. Monitor the token generation rate, which is consistently between 5 to 8 tokens per second.

### Actual Result

In both local and EC2 environments, the application generates only 5 to 8 tokens per second, indicating high latency.

### Expected Result

A higher rate of token generation that aligns with the capabilities of the specified hardware, especially on a powerful g5.xlarge EC2 instance.

---

### Environment Details

**Local System:**
- **OS:** Windows
- **RAM:** 16GB
- **CPU:** Intel

**AWS EC2 Instance:**
- **Instance Type:** g5.xlarge

**Ollama Version:**
- **0.1.39**

---

### Additional Information

- **EC2 Instance type `g5.xlarge`** is typically optimized for GPU-based workloads.
- **Local System** resources (16GB RAM and an Intel CPU) should provide better performance than experienced.
- The issue is consistent across different environments indicating a potential software issue or configuration problem.

---

### Screenshots / Logs

*(Please attach any relevant logs or screenshots that can help in diagnosing the issue.)*

---

### Tagging

**Reported by:** vsatyakiran

**Maintainer:** *(Tag relevant maintainer if known)*

### Comments

Any insights, suggestions, or guidelines to improve performance would be greatly appreciated. Thank you!

---

End of Issue

This issue report includes a detailed description of the problem, the steps to reproduce it, expected vs. actual results, environmental details, and a request for assistance. It ensures that sufficient information is provided to help diagnose and address the issue.

@vsatyakiran you're almost certainly running on the CPU instead of the GPU. What is the output of ollama ps? Also, what type of GPU are you trying to use? With the g5.xlarge I believe it's an a100 and there was an issue w/ nvidia driver version 555 which should be fixed in Ollama 0.1.40.

It sounds like you're dealing with a performance issue where your computations are running on the CPU rather than the GPU. Let's address your problem step by step.
1. Check if Processes are Running on GPU:
First, you need to determine whether your processes are indeed running on the GPU. To do that, you can run the command mentioned:
ollama ps

This command should give you an overview of the processes and indicate whether they're utilizing the GPU or not.
2. Inspect Your GPU Type:
You mentioned you're working with a g5.xlarge instance. Indeed, this instance type typically comes with an NVIDIA A100 GPU.
3. Check for Driver Issues:
There may be an issue with the NVIDIA driver version you are using. Specifically, version 555 has known issues with the A100 GPU. Make sure you have the correct driver version installed for your GPU.
4. Update Ollama:
Ensure you have the latest version of Ollama installed, as the issue with driver version 555 was purportedly fixed in Ollama version 0.1.40. You can update Ollama to the latest version using the package manager you've installed it with, typically:
pip install --upgrade ollama

or if you're using conda:
conda update ollama

5. Verify NVIDIA Drivers:
Check the NVIDIA driver version on your machine. You can do this using the following command:
nvidia-smi

This will display the details of the installed NVIDIA driver and should help you confirm which version you are running. If you find it’s version 555, you may need to update the drivers to a more suitable version.
6. Transition Database to GPU:
Finally, ensure that your workload configurations are set to utilize the GPU. Some libraries and frameworks require explicit instructions to switch computations to the GPU.
For example, in PyTorch, you can transfer a tensor to the GPU using:
import torch

device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
tensor = tensor.to(device)

In TensorFlow, you might set the GPU with:
import tensorflow as tf

gpus = tf.config.experimental.list_physical_devices('GPU')
if gpus:
    try:
        # Currently, memory growth needs to be the same across GPUs
        for gpu in gpus:
            tf.config.experimental.set_memory_growth(gpu, True)
    except RuntimeError as e:
        # Memory growth must be set before GPUs have been initialized
        print(e)

Summary:

Confirm processes are running on GPU with ollama ps.
Ensure you’re using the correct GPU and that it's not disabled.
Update Ollama to version 0.1.40 or later.
Verify and, if necessary, update the NVIDIA driver.
Make sure your workflow explicitly targets the GPU.

By following these steps, you should be able to identify and resolve the issue, ensuring your computations leverage the GPU’s performance benefits.

@vsatyakiran if you're still having troubles, please upgrade to the latest version, and if that doesn't get you running on your GPU, please share your server log and I'll reopen the issue.
https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md


QA: add guidelines for manual test case creation

Description

Added new guidelines on creating manual test cases
Cleaned up warnings by updating dictionary

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix the bug of globalCmpFeedback

Fixed the crash problem caused by not initialized when applying for globalCmpFeedback memory. Invalid test cases will be generated due to the crash in the program being tested.

Thank you!


Add ability to wrap variable names in \text{}

I like putting non-math text in \text{} commands so things don't get overly italicized. I added an optional use_text argument to extract_eq_lm() that wraps variable names with \text{}:
# Simple model
mod1 <- lm(mpg ~ cyl + disp, mtcars)
extract_eq_lm(mod1, use_text = TRUE)
#> $$
#>  \text{mpg} = \alpha + \beta_{1}(\text{cyl}) + \beta_{2}(\text{disp}) + \epsilon
#> $$

It works with categorical variables too:
# Categorical variables
mod3 <- lm(Sepal.Length ~ Sepal.Width + Species, iris)
extract_eq_lm(mod3, use_text = TRUE)
#> $$
#>  \text{Sepal.Length} = \alpha + \beta_{1}(\text{Sepal.Width}) + \beta_{2}(\text{Species}_{\text{versicolor}}) + \beta_{3}(\text{Species}_{\text{virginica}}) + \epsilon
#> $$

Great idea. Thanks Andrew! I’ll take a closer look at this but I like it a lot. If you want to also edit the DESCRIPTION file I’d be happy to add you as a contributor.

My additions to add_dummy_subscripts() violate all sorts of DRY principles, but extract_eq_lm() is fairly straightforward

All looks good to me. I need to do some refactoring anyway (it's one of the issues) and that should help some of this out. Thanks again!


Fix/holders credential controller api

Seperating the api documentation from the holders credential controller into a seperate file
https://github.com/eclipse-tractusx/managed-identity-wallet/issues/145

changed to identifier


Add message list to campaigns

TL;DR
This PR adds a slideover messaging pane for chatting with riders from a specific campaign. Commits are (relatively) atomic.
Screencapture
https://github.com/bikebrigade/dispatch/assets/12987958/eaf96322-b71f-462e-b3c1-35278b7aca97
Details

I pitched this feature to dispatchers last week and got some positive feedback and interest
I created a prototype and iterated on it. Along the way I refactored some now shared code into components and cleaned up the styles on the messages.
Currently dispatchers are required to a) go to /messages, find their rider, and correspond, or b) go to the campaign > click on a rider > click message, which will jump them to the chat.
I have also updated the design of the messages to use a bit more space, as well as add borders between sms-messages.

To do still:

[x] write tests
[ ] get dispatcher input at the next BB meeting on the UI/UX.

@mveytsman Feel free to review now.

Think I hit everything. Only one comment probably needs a quick glance.

Rebased and made a small copy change. Whatever updated, we're getting a lot more compiler warnings when running tests, so I'll make a ticket to fix that.


connect eris-contracts.js to eris-keys

This temporary hack needs to get fixed and having eris-contracts.js talk to eris-keys via eris-keys.js is a necessity.

This will be part of the API rewrite.


Unit of work : get the count of scheduled insertions / updates / deletes

It will be interesting to have the count of scheduled update / insert /delete in the unit of work,
Currently there is getScheduledEntityInsertions( ), getScheduledEntityUpdates( ), getScheduledEntityDeletions( ), but it return arrays.

So, um, call count() on them?

Closing as per @alcaeus' answer

"So, um, call count() on them?"
The objetctive was to increment a counter on each add / update / delete and get the count directly without counting on a full array of entities ...

That's up to you to do - no advantage in that ORM-side
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On Thu, Sep 14, 2017 at 11:56 AM, Arthur Spitznagel <
<EMAIL_ADDRESS>wrote:

"So, um, call count() on them?"
The objetctive was to increment a counter on each add / update / delete
and get the count directly without counting on a full array of entities ...
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/issues/6702#issuecomment-329433970,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakHj_ZA8kjFnTUaiMSxgJguIZtzxEks5siPhJgaJpZM4PVyr1
.

The objetctive was to increment a counter on each add / update / delete

What good would that do? For one, updates are only available once changeset computation has been done (which is normally done inside a commit()).

get the count directly without counting on a full array of entities

You are aware that there is no computational overhead in returning the "full array of entities" and count is rather fast (except maybe if your array has hundreds of thousands of elements, in which case I'd assume you have a different performance problem on your hands before that)?
But sure, I'll bite: what's the use case of storing a counter instead of just running count?

@alcaeus An import script , and I have thousand of entities
@Ocramius ok if you think so, you are the expert

@alcaeus SLOW!

@alcaeus An import script , and I have thousand of entities

@arthursp counting/incrementing is really up to you there: if you even work in a controlled environment, then you don't need any UnitOfWork facilities, as you know what you are doing, and can count the operations manually.

@Ocramius yes but if the ORM can help me for free :)
But I respect you point of view : not the ORM role.


Configure fms (2),fsx (10),glacier (2)

External name configuration of 2 resources in the fms group:

aws_fms_admin_account
aws_fms_policy

External name configuration of 10 resources in the fsx group:

aws_fsx_backup
aws_fsx_data_repository_association
aws_fsx_lustre_file_system
aws_fsx_ontap_file_system
aws_fsx_ontap_storage_virtual_machine
aws_fsx_ontap_volume
aws_fsx_openzfs_file_system
aws_fsx_openzfs_snapshot
aws_fsx_openzfs_volume
aws_fsx_windows_file_system

External name configuration of 2 resources in the glacier group:

aws_glacier_vault
aws_glacier_vault_lock

These API groups were configured without testing


Feb 6th publish

Push out updated content to live site.

OPS Build status updates of commit e69a34c:
:clock10: Preparing: average preparing time is 46 sec(s)

OPS Build status updates of commit e69a34c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/azure-devops-docs-sdk-web, working directory: W:\o0mj-s, target branch: live, target branch commit: 094d9ce84b71ac66376a8ad876e2325209e266ac, source branch: master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Deprecated API

Note: /react-native-android-wifi/android/src/main/java/com/devstepbcn/wifi/AndroidWifiModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Not sure what it is

Got the same error on react-native: 0.46.4
Would love to find a solution.

.../node_modules/react-native-android-wifi/android/src/main/java/com/devstepbcn/wifi/AndroidWifiPackage.java:12: error: AndroidWifiPackage is not abstract and does not override abstract method createJSModules() in ReactPackage
public class AndroidWifiPackage implements ReactPackage {
^
Note: .../node_modules/react-native-android-wifi/android/src/main/java/com/devstepbcn/wifi/AndroidWifiModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
:react-native-android-wifi:compileReleaseJavaWithJavac FAILED
FAILURE: Build failed with an exception.
Tried on RN 0.43 - 0.47 no success

Thanks, ok now on RN 0.42.3

Thanks @AlexanderKosianchuk !


Add gradle script to upload release to maven central

Summary
Because jcenter will be sunset soon, migrating release versions to maven central.
https://www.notion.so/jcenter-to-mavenCentral-migration-ae91d4b4ec15403e834d3493502daf45#23b73100083147b4b0770a00fc763d43
Reference
https://github.com/line/apng-drawable/pull/82
https://github.com/line/apng-drawable/pull/83

The file https://github.com/line/line-sdk-android/blob/master/.github/workflows/publish.yml could be delete as well.


oasis-node freezes when address is not valid

If you mistype the -a address when running oasis-node, for example
$ oasis-node stake list -a unix:/internl.socket

It just freezes. This was introduced in 36020d3acae8e833c374427d84137e2609d15f16
Before, it correctly responded
$ go/oasis-node/oasis-node stake list  -a unix:/internl.socket
ts=2019-11-27T14:29:41.942784116Z level=warn module=cmd/stake caller=stake.go:70 msg="failed to query accounts" err="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial unix internl.socket: connect: no such file or directory\"" attempt=1

The same happens, if you forget unix: before the filename and it tries to connect to a tcp socket.

The reason for "freezing" is that we added the WaitReady gRPC option which waits for the socket/host to appear. This is useful if you want to start the client before the node is fully initialized, but it does result in an apparent freeze if you mistype the path/host.
We could make the tools emit a message saying something like "waiting for host/socket to appear".


Concurrent API calls

I want to be able to fire multiple actions for an event.
View:
  onLoad:
    - action: invokeAPI
      name:
      onResponse:
    - action: invokeAPI
      name:
      onResponse:

not critical, closing as stale. @amin-nas feel free to re-open


upgrading from 2.7.2 to 3.0.1 causes  Class "Intervention\Image\ImageServiceProvider" not found

Describe the bug
When upgrading from 2.7.2 to 3.0.1 composer will show  Class "Intervention\Image\ImageServiceProvider" not found error and the whole system will break.
Code Example
composer update
Expected behavior
should pass composer and work
Images
n/a
Environment (please complete the following information):

PHP Version: 8.1.23
OS: 20.04.6 LTS
Intervention Image Version:
GD or Imagick:

Version 3 no longer contains a ServiceProvider for Laravel. I didn't like the close connection to the framework and decided to take a more agnostic approach with the major update.
Alternatives are to create your own provider or to do without it altogether.
See: https://image.intervention.io/v3/introduction/upgrade#other-changes


import/unnamed: Avoid duplicating

When rewriting unnamed imports like so, gopatch would sometimes fail to
delete the old import because it didn't realize that that import was no
longer used.
@@
var X identifier
@@
-import "example.com/foo/internal/lib"
+import "example.com/foo/lib"

  lib.X

This is because when detecting whether the import has been replaced, it
recorded the package name for the old import as unknown.
This changes it to guess the package name for the old import based on its
basename.
Caveat: Like the other place where we guess package names for unnamed
imports, this won't work when the package name doesn't match basename. We
can write a best effort heuristic for this, but I think our recommendation
here more generally should be to recommend a patch with a named import
metavariable so that we can handle both, named and unnamed imports, and
have a good idea of the package name from the patch.

Codecov Report

Merging #30 (5a7feeb) into main (633d570) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   86.40%   86.41%   +0.01%
==========================================
  Files          38       38
  Lines        2030     2032       +2
==========================================
+ Hits         1754     1756       +2
  Misses        221      221
  Partials       55       55

Impacted Files
Coverage Δ

internal/engine/import.go
95.31% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633d570...5a7feeb. Read the comment docs.


Add transform compensation for additional bones in bone chains

Currently the retargeting requires that the two skeletons are similar in bone hierarchy while names can be different. Bone chains between source and target skeleton need to have the same number of bones, only additional leaf bones at the end of retargeted bones are allowed.
Complex skeletons, e.g. Genesis or Character Creation rigs, often have additional bones between the retargeted bones, e.g. twist bones for legs and arms, but if not both source and target rig share those bones the calculated bone transforms will always be wrong.
The retargeting process needs to make an additional pass and crawl through parent bones to find additional bones that could influence the transforms of the retarged bones.
Would partially solve issues like seen in #19 when retargeting from simple rigs to more complex rigs and vice versa.

Added to the feature tracker.


Introduce wrapper to launch ssh

Directly using ssh as the application launched by the csshw-client does not work as the keys don't get correctly propagated.
Using git-cmd.exe does correctly propagate the keys.
So how about creating small wrapper that will be launched by the csshw-client and in turn just starts the ssh process.
Maybe this way both key propagation and direct input will work.

By replacing std::process::Command with tokio::process:Command we fixed the issue that required a wrapper in the first place.
This removed the dependency towards WSL2 as well as the need for this item.


Invalid/expired invite links

Community name that is currently listed:
See below.
Describe the issue:
Invite codes for the following servers have expired:
{
    "ekgFE4s": "Code::Together",
    "48Zxcpy": "Programmers Palace",
    "YXvuN8X": "Climate Science",
    "5vkPupa": "Amulius - Engineering  & Chill",
    "W8v5EK2": "Electrical Engineering",
    "bVVbSqQ": "Raspberry Pi",
    "b2kTasd": "r/HomeKit",
    "iphone": "r/iPhone",
    "nPEHdsyjDg": "Smartwatch",
    "TPpQv2H": "Official Commodore Amiga",
    "ZPErMGW": "#include",
    "92yyRb2": "cascading-style-sheets",
    "Y8Mqbkk": "JS Programming Language Community",
    "KbDHDez": "Ruby",
    "RXNsMXc": "Ärorust",
    "qvGgnVx": "Doom Emacs",
    "mr5hVu8": "Files",
    "Aak7YGU": "Adobe Systems Community",
    "EhaMzy2": "XDA-Developers",
    "qc89CQkX7j": "Hackintosh x86 & Tech",
    "9pfb5ZB": "Linux Café",
    "Gentoo": "Gentoo Linux",
    "EVVtPpw": "Linux Mint Community",
    "grakn": "Grakn",
    "VzThBmB": "Pi-Hole",
    "vy75f7W": "CyberSecLabs Lounge",
    "Q8YsA7S": "LOCKE",
    "Nu59kq5": "The Cyber Mentor",
    "KCNDp9m": "PINCE",
    "TUr9RDU": "Cardano Community",
    "unreal-slackers": "Unreal Slackers",
    "a6zm2T8": "RPCS3",
    "vrd6385": "Steam ROM Manager",
    "usAgsbK": "VKx",
    "CbVJYtz": "Artificial Intelligence",
    "NRnrWE7": "r/DataIsBeautiful",
    "rGwhXJv": "CS Career Hackers"
}

Expected:
Correct invite codes.

Some of them have already been reported by other users.


Maximum call stack exceeded & others

While trying to reproduce #91 in a sandbox I bumped on a very strange behaviour. I can't tell which part of the ecosystem is misbehaving (might be not fault of ember-resources), but it is somewhat alarming because it crashes the app and it's somewhat random. Also the message / error is different from browser to browser. And in some cases (Firefox) disappears when I don't use @cached in one particular place (but that might be just a matter of luck).

Edge: lazy_load.js:75 Uncaught RangeError: Maximum call stack size exceeded.
Firefox/Safari: Error while processing route: index – "decorator is not a function. (In 'decorator(target, property, desc)', 'decorator' is undefined)"

I created a full reproduction repo here: https://gitlab.com/michal-bryxi/bugreport/ember-resources-bugreport
If this is a concern of other part of the Ember ecosystem, I'm happy to re-report.

Looks like you're missing https://github.com/ember-polyfills/ember-cached-decorator-polyfill

🤦  Remove the keyboard from me


Unpredictable results.

Over the same dataset I trained on different machines, the misclassified samples are different.
Although few of the all data samples are misclassified over the given dataset, the results varies from machine to machine. Test samples properly identified on one machine are mislabeled on the other.
Do you have any idea about this?

The algorithms have randomness inherently.

So, there's no way the results can be certain ?

right.

@code-player by mislabeled you mean the results are incorrect & the matching is not showing correct results ?

Yeah. Definitely. Over the same dataset (say A-Z) trained over two different machines. One machine misidentifies some users (let say D, M, P) and perfectly identifies the rest, the other machine misidentifies some other users, (like F, O, X) and identifies the rest properly.
This was the issue I asked about.


rmlui docs

Shouldn't RmlUi be spelled RmlUI?

Shouldn't RmlUi be spelled RmlUI?

I used the capitalization from the official docs


fix(deps): update terraform time to latest for the deployable architecture solution

This PR contains the following updates:

Package
Type
Update
Change

time (source)
required_provider
minor
>= 0.8.0, <1.0.0 -> >= 0.11.1, < 1.0.0

Release Notes

hashicorp/terraform-provider-time (time)
v0.11.1
Compare Source
NOTES:

No functional changes from v0.11.0. Minor documentation fixes. (#299)

v0.11.0
Compare Source
FEATURES:

functions/rfc3339_parse: Added a new rfc3339_parse function that parses an RFC3339 timestamp string and returns an object representation. (#280)

v0.10.0
Compare Source
BUG FIXES:

resource/time_offset: Fix bug preventing multiple offset arguments from being set (#189)

v0.9.2
Compare Source
NOTES:

This release introduces no functional changes. It does however include dependency updates which address upstream CVEs. (#263)

v0.9.1
Compare Source
BUG FIXES:

resource/time_rotating: Correctly retrieve the Terraform state during update (#132)

v0.9.0
Compare Source
NOTES:

provider: Rewritten to use the new terraform-plugin-framework (#112)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.2.2 :tada:
The release is available on:

GitHub release
v1.2.2

Your semantic-release bot :package::rocket:


Implementation of Non-Gaussian transition models

@hpritchett-dstl
Features:

Introduce a new family of transition models that generalise transition models driven by white noise to the Levy process.
Provides support for normal sigma-mean and normal variance-mean mixture processes.
Users can inject the desired driving processes into the selected transition model
Introduce marginalised particle filtering for inferencing the newly-introduced class of models.
Added a tutorial notebook for the new class of models and marginalised particle filter

Refactored:

Improve inference speed for Levy models with known state transition matrices, e.g. LevyLangevin model
Wrote minimal tests to lock down the behaviour of the introduced models. Some of Simon's students will still actively contribute to his work here, and I would require their help to improve the test coverage.
Better separation of concerns/class design than before.

Todo:

Implementation of PDF and log PDF functions, certain Levy distributions have non-trivial PDFs/CDFs, currently looking into inverse FFT methods involving characteristic functions.
Provide support for more models, e.g. Singer
Improve tests.

Additional comments:
I believe the current design is a good compromise between speed and compatibility with the existing stone soup framework to avoid introducing any breaking changes. The newly introduced models decouple the deterministic (transition model) and non-deterministic (noise driver) components. That being said, suggestions are welcome and highly appreciated.

@hpritchett-dstl
I believe I’ve addressed all your comments and refactored the code accordingly. However, my tests on CircleCI for Python 3.8 seem to be failing due to the KS test from SciPy. I’m not entirely sure what’s causing this, so I’d appreciate it if you could take a look and help troubleshoot.
Additionally, I noticed that some of my formatting changes might have affected other parts of the repository that aren’t mine. I’ll need more time to undo those, but it might be helpful if we had standardized code styles throughout the repository. For example:

Using absolute imports instead of relative imports
Configuring flake8 and black consistently, ideally with a pre-commit hook

Lastly, it would be really helpful to have a local development setup that mirrors the CircleCI test environment. This way, I could run the tests locally and address any issues before pushing changes. A docker image would be great!


Document the lexical syntax of depfiles

The manual just says they are "like makefiles" but nobody really knows what that means.
Would have helped with the comment at the bottom of #56.

I think this is important. Do you think this should be in the manual, or on a wiki page?

I like the manual.  Sorry about asciidoc though, these days it's weird to use anything but markdown. :~(

Related, but not exactly the same as, https://github.com/ninja-build/ninja/issues/510


update tip placement

Summary
Fix placement of tips 3 (add channels tip) and 4 (menu tip)
Ticket Link
https://mattermost.atlassian.net/browse/MM-37956
Related Pull Requests
none
Screenshots

Release Note
No release note: this is for a bug fix to new UI that has not yet been released.
NONE

Hello @neallred,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Thanks @neallred!

Cherry pick is scheduled.

Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   891dadbf2..9ad409aca  MM-32342_remove-legacy-sidebar -> upstream/MM-32342_remove-legacy-sidebar
   9d463da42..279d167b7  cloud      -> upstream/cloud
   66f296580..0b2637fcf  master     -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#8602-upstream-release-6.0-1629214601
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#8602-upstream-release-6.0-1629214601'
Branch 'automated-cherry-pick-of-mattermost-webapp-#8602-upstream-release-6.0-1629214601' set up to track remote branch 'release-6.0' from 'upstream'.

+++ About to attempt cherry pick of PR #8602 with merge commit 0b2637fcf88549816c6422634f974eb5ee76187e.

error: could not apply 0b2637fcf... update tip placement (#8602)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU sass/components/_tutorial.scss
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

/cherry-pick cloud

Cherry pick is scheduled.


Uninstall button of plugins should ask for confirmation

The "Uninstall" button of community plugins just remove, without asking for any confirmation.

This can lead to errors when the users click it by mistake (for example: his intention was to click "Settings" or "Disable")

Hi @keul, I moved your issue on the proper repository: atom/settings-view#699
I'm closing this one then.


Add upgrade hook functionality to operator

We need a backdoor mechanism for any upgrade related fixups.

This is marked as a 1.4 P0, do we have an owner?

Happy to take this one, thanks!

@elfinhe sorry I thought this is what you were already working on. Feel free to unassign if that's not the case -- I didn't intend to give you more work, just make github match reality.

resolved by https://github.com/istio/operator/pull/385


WIP - Add Button Dropdown Component

Please have a look over what I have done so far, I have more to do on this.

Coverage decreased (-13.0%) to 84.727% when pulling 873584fd2c4e0fbdccd957dea58d3dca9e21fa28 on button-dropdown into da8bfeb60e6bfce04c1127ce094a71ea681eef39 on master.

Coverage decreased (-13.0%) to 84.727% when pulling 873584fd2c4e0fbdccd957dea58d3dca9e21fa28 on button-dropdown into da8bfeb60e6bfce04c1127ce094a71ea681eef39 on master.

Have finished this now so if you can have a look over what I have done. I have not put any grid/layout in as per our other components. Have included  below Ignore the overlap of spacing as there is no grid/gutters. Will need to write some unit tests for these also once reviewed. Cheers

Coverage decreased (-12.7%) to 85.252% when pulling cb3602724eac2e20f0fab03ae82e019e2528f7ce on button-dropdown into b4a47193b37c0398ebb13d7e21d3e3b549405686 on master.

Last fix done now

Coverage decreased (-12.5%) to 85.405% when pulling 4ef10e334207e5c2a661fb1b7af507b4e391ee4b on button-dropdown into b4a47193b37c0398ebb13d7e21d3e3b549405686 on master.

Have added some unit tests for these now - I have had to skip 3 tests as these aren't working so could do with your help as to why so if you get a min. Thanks

Coverage decreased (-0.8%) to 97.093% when pulling ab8cb16ca470e28b0a722a318a72cf688f4cc07a on button-dropdown into b4a47193b37c0398ebb13d7e21d3e3b549405686 on master.

Coverage decreased (-0.8%) to 97.087% when pulling c3dabd5a72e2a1bde32f79c06b49e30b0c83eb29 on button-dropdown into b4a47193b37c0398ebb13d7e21d3e3b549405686 on master.

Changes Unknown when pulling 522532ee625bd1345bdb445212ebae4503f631a9 on button-dropdown into ** on master**.

Please have look over this - have added additional tests to the wrapper


Randomise the races.

Is there a way to randomise the races so it doesn't do them all in a row. I don't want to have 1 - 1000 be only one race and then have 1001 - 2000 be the next race.

Forgot to mention I am using branch 4

Would also like to know a way to do this

I'm also curious about this

const getRace = (_editionCount) => {
let race = "No Race";
if (Math.random() > 0.3) {
race = "HumanMale"
} else {
race = "HumanFemale"
}
return race;
};
PS: If you have code to stop overlapping layers eg: IF Mask THEN No CIG. I'd appreciate some help in return! The code i've supplied will be placed in Index.js :)

Thank you so much for the code I added the ability to have as many races as you want:
const getRace = (_editionCount) => {
let race = "No Race";
// max is the amount of races you need //
if (Math.floor(Math.random() * (max - 1+ 1)) + min == 1){
race = "HumanMale"
}
else if (Math.floor(Math.random() * (max - 1+ 1)) + min == 2){
race = "HumanFemale"
}
else if (Math.floor(Math.random() * (max - 1+ 1)) + min == 3){
strain = "Alien"
}
else if (Math.floor(Math.random() * (max - 1+ 1)) + min == 4){
strain = "Martian"
}
return race;
};
What are you trying to do with the layers that is making them overlap?

const getRace = (_editionCount) => {
let race = "No Race";
if (Math.random() > 0.3) {
race = "HumanMale"
} else {
race = "HumanFemale"
}
return race;
};
PS: If you have code to stop overlapping layers eg: IF Mask THEN No CIG. I'd appreciate some help in return! The code i've supplied will be placed in Index.js :)

Not sure why you are getting layers overlapping have you changed the original code on layer building?

No, have you got a link to the video, might of missed that. I want an IF statement which cancels layer building if a mask is supplied first

const getRace = (_editionCount) => {
let race = "No Race";
if (Math.random() > 0.3) {
race = "HumanMale"
} else {
race = "HumanFemale"
}
return race;
};
PS: If you have code to stop overlapping layers eg: IF Mask THEN No CIG. I'd appreciate some help in return! The code i've supplied will be placed in Index.js :)

Not sure why you are getting layers overlapping have you changed the original code on layer building?

read above brotha

const getRace = (_editionCount) => { let race = "No Race"; if (Math.random() > 0.3) { race = "HumanMale" } else { race = "HumanFemale" } return race; };
PS: If you have code to stop overlapping layers eg: IF Mask THEN No CIG. I'd appreciate some help in return! The code i've supplied will be placed in Index.js :)

Hey, where does this code go? Do I have to remove the race weights? Is there anything else I need to do? I'm assuming I replace HumanMale and HumanFemale with my two races? would appreciate a quick reply


examples: remove session-ttl config from template

What problem does this PR solve?

Issue link:
ref: https://github.com/pingcap/tiflow/pull/7404
What is changed and how it works?
session-ttl is no longer used in tiflow, and remove it before https://github.com/pingcap/tiflow/pull/7404 got merged is safe since it has a default value.
Code changes

[ ] Has Go code change
[ ] Has CI related scripts change

Check List
Tests

[ ] Unit test
[ ] E2E test
[ ] Stability test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Breaking backward compatibility
[ ] Other side effects:

Note for reviewer

Codecov Report
Base: 5.61% // Head: 5.61% // No change to project coverage :thumbsup:

Coverage data is based on head (596886f) compared to base (39e52a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #43   +/-   ##
======================================
  Coverage    5.61%   5.61%
======================================
  Files          19      19
  Lines        1905    1905
======================================
  Hits          107     107
  Misses       1785    1785
  Partials       13      13

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[API] Invalid Value Error when editing a workload from the UI

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a Project and Namespace and add an nginx workload

One pod is ok, do not enter the Port.

Wait until the pod is available.
Click in Edit the workload.
Click the Add Port in Port Mapping, enter 80 and NodePort (On every Node)
API Error.

Result:

Validation failed in API: Deployment.apps "testnx" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{}: `selector` does not match template `labels`

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head
Installation option (single install/HA): single/Custom.

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Custom/Infrastructure Provider

Machine type (cloud/VM/metal) and specifications (CPU/memory): Cloud

Docker version (use docker version):

19.03.1

This issue doesn't seem to be reproducible all the time, as I sometimes have to edit the workload in different ways:
This is a sample PUT:
PUT /v3/project/c-8tqb4:p-9t767/workloads/deployment:default:nx HTTP/1.1
Host: <IP>
Connection: keep-alive
Content-Length: 2872
Pragma: no-cache
Cache-Control: no-cache
Sec-Fetch-Mode: cors
DNT: 1
x-api-action-links: actionLinks
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.75 Safari/537.36
content-type: application/json
x-api-no-challenge: true
accept: application/json
x-api-csrf: e416160605
Origin: https://<IP>
Sec-Fetch-Site: same-origin
Referer: https://<IP>/p/c-8tqb4:p-9t767/workloads/run?namespaceId=default&upgrade=true&workloadId=deployment%3Adefault%3Anx
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9,es;q=0.8

{
  "hostIPC": false,
  "hostNetwork": false,
  "hostPID": false,
  "paused": false,
  "annotations": {
    "cattle.io/timestamp": "2019-09-16T16:58:14Z"
  },
  "baseType": "workload",
  "containers": [{
    "initContainer": false,
    "restartCount": 0,
    "stdin": true,
    "stdinOnce": false,
    "tty": true,
    "allowPrivilegeEscalation": false,
    "image": "nginx",
    "imagePullPolicy": "Always",
    "name": "nx",
    "ports": [{
      "containerPort": 8080,
      "dnsName": "nx-nodeport",
      "kind": "NodePort",
      "name": "80tcp01",
      "protocol": "TCP",
      "type": "/v3/project/schemas/containerPort"
    }, {
      "containerPort": 80,
      "type": "containerPort",
      "kind": "NodePort",
      "protocol": "TCP"
    }],
    "privileged": false,
    "readOnly": false,
    "resources": {
      "type": "/v3/project/schemas/resourceRequirements",
      "requests": {},
      "limits": {}
    },
    "runAsNonRoot": false,
    "terminationMessagePath": "/dev/termination-log",
    "terminationMessagePolicy": "File",
    "type": "container",
    "capAdd": [],
    "capDrop": [],
    "environmentFrom": [],
    "livenessProbe": null,
    "volumeMounts": []
  }],
  "created": "2019-09-16T16:44:06Z",
  "createdTS":<PHONE_NUMBER>000,
  "creatorId": null,
  "deploymentConfig": {
    "maxSurge": 1,
    "maxUnavailable": 0,
    "minReadySeconds": 0,
    "progressDeadlineSeconds": 600,
    "revisionHistoryLimit": 10,
    "strategy": "RollingUpdate"
  },
  "deploymentStatus": {
    "availableReplicas": 2,
    "conditions": [{
      "lastTransitionTime": "2019-09-16T16:44:13Z",
      "lastTransitionTimeTS":<PHONE_NUMBER>000,
      "lastUpdateTime": "2019-09-16T16:44:13Z",
      "lastUpdateTimeTS":<PHONE_NUMBER>000,
      "message": "Deployment has minimum availability.",
      "reason": "MinimumReplicasAvailable",
      "status": "True",
      "type": "Available"
    }, {
      "lastTransitionTime": "2019-09-16T16:44:06Z",
      "lastTransitionTimeTS":<PHONE_NUMBER>000,
      "lastUpdateTime": "2019-09-16T16:44:37Z",
      "lastUpdateTimeTS":<PHONE_NUMBER>000,
      "message": "ReplicaSet \"nx-64566675c\" has successfully progressed.",
      "reason": "NewReplicaSetAvailable",
      "status": "True",
      "type": "Progressing"
    }],
    "observedGeneration": 4,
    "readyReplicas": 2,
    "replicas": 2,
    "type": "/v3/project/schemas/deploymentStatus",
    "unavailableReplicas": 0,
    "updatedReplicas": 2
  },
  "dnsPolicy": "ClusterFirst",
  "id": "deployment:default:nx",
  "labels": {},
  "name": "nx",
  "namespaceId": "default",
  "projectId": "c-8tqb4:p-9t767",
  "publicEndpoints": [{
    "addresses": ["<IP_ADDRESS>"],
    "allNodes": true,
    "ingressId": null,
    "nodeId": null,
    "podId": null,
    "port": 31454,
    "protocol": "TCP",
    "serviceId": "default:nx-nodeport",
    "type": "publicEndpoint"
  }],
  "restartPolicy": "Always",
  "scale": 2,
  "scheduling": {
    "scheduler": "default-scheduler",
    "node": {}
  },
  "selector": {
    "matchLabels": {
      "workload.user.cattle.io/workloadselector": "deployment-default-nx"
    },
    "type": "/v3/project/schemas/labelSelector"
  },
  "state": "active",
  "terminationGracePeriodSeconds": 30,
  "transitioning": "no",
  "transitioningMessage": "",
  "type": "deployment",
  "uuid": "dc842029-0d63-4897-a968-738837870bdd",
  "workloadAnnotations": {
    "deployment.kubernetes.io/revision": "2",
    "field.cattle.io/creatorId": "user-sm5z4"
  },
  "workloadLabels": {
    "cattle.io/creator": "norman",
    "workload.user.cattle.io/workloadselector": "deployment-default-nx"
  },
  "volumes": []
}

Response from above request:
{
  "baseType": "error",
  "code": "Invalid",
  "message": "Deployment.apps \"nx\" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{}: `selector` does not match template `labels`",
  "status": 422,
  "type": "error"
}

Will open a new issue if this problem occurs again, this is not reproducible on latest release.