resource search sorting

at time the sorting on resource search is slightly off
from website

Identifying aquatic invertebrates using nex ... from Contentful
created
Yesterday, 3:38 PM
updated
Yesterday, 6:53 PM
published
Yesterday, 6:53 PM

Developing a common structural framework for d... from Contentful
created
4 hours ago
updated
8 minutes ago
published
8 minutes ago

elastic search query (showing the one from yesterday above the one from 4 hours ago)
NB: Using "origin": "2017-09-29T15:13:00.196Z" instead of now/d returns the expected result
{
	"size": 2,
    "query": {
        "function_score": {
            "functions": [
                {
                    "gauss": {
                        "createdAt": {
                            "origin": "now/d",
                            "scale": "7d",
                            "decay": 0.75
                        }
                    },
                    "weight": 10
                }
            ],
            "query": {
                "bool": {
                    "must": [
                        {
                            "term": {
                                "searchable": "true"
                            }
                        },
                        {
                            "term": {
                                "contentType": "dataUse"
                            }
                        }
                    ]
                }
            }
        }
    }
}

Elastic search response (some keys removed)
{
    "took": 7,
    "timed_out": false,
    "_shards": {
        "total": 49,
        "successful": 39,
        "failed": 10,
        "failures": [
            {
                "shard": 0,
                "index": "country",
                "node": "V-MvNfiRRViOgV_7aPTP5g",
                "reason": {
                    "type": "parsing_exception",
                    "reason": "unknown field [createdAt]",
                    "line": 1,
                    "col": 0
                }
            }
        ]
    },
    "hits": {
        "total": 227,
        "max_score": 0.13189553,
        "hits": [
            {
                "_index": "datause1506689838917",
                "_type": "content",
                "_id": "3gCOvQwphmS6kkKuWQKq2W",
                "_score": 0.13189553,
                "_source": {
                    ...
                    "title": {
                        "en-GB": "Identifying aquatic invertebrates using next generation sequencing"
                    },
                    "searchable": true,
                    "createdAt": "2017-09-28T14:37:39.196Z",
                    "contentType": "dataUse",
                    "homepage": true,
                    "updatedAt": "2017-09-28T16:53:50.631Z"
                }
            },
            {
                "_index": "datause1506689838917",
                "_type": "content",
                "_id": "3zGBIwOLH2QsM6IcUm0ecW",
                "_score": 0.13180104,
                "_source": {
                    "title": {
                        "en-GB": "Developing a common structural framework for data papers"
                    },
                    "searchable": true,
                    "createdAt": "2017-09-29T12:34:33.587Z",
                    "contentType": "dataUse",
                    "homepage": true,
                    "updatedAt": "2017-09-29T12:56:30.688Z"
                }
            }
        ]
    }
}

Elastic search full response
{
    "took": 7,
    "timed_out": false,
    "_shards": {
        "total": 49,
        "successful": 39,
        "failed": 10,
        "failures": [
            {
                "shard": 0,
                "index": "country",
                "node": "V-MvNfiRRViOgV_7aPTP5g",
                "reason": {
                    "type": "parsing_exception",
                    "reason": "unknown field [createdAt]",
                    "line": 1,
                    "col": 0
                }
            }
        ]
    },
    "hits": {
        "total": 227,
        "max_score": 0.13189553,
        "hits": [
            {
                "_index": "datause1506689838917",
                "_type": "content",
                "_id": "3gCOvQwphmS6kkKuWQKq2W",
                "_score": 0.13189553,
                "_source": {
                    "summary": {
                        "en-GB": "Using large-scale DNA barcode sequencing to effectively identify species of samples archived for up to 12 years "
                    },
                    "primaryImage": {
                        "file": {
                            "en-GB": {
                                "url": "//images.contentful.com/uo17ejk9rkwj/3mBCu5D8mQ0GEMGsMu2Sm8/262e6612b61efd1d3ef962075b309241/original__2_.jpg",
                                "details": {
                                    "size": 927874,
                                    "image": {
                                        "width": 2048,
                                        "height": 1366
                                    }
                                },
                                "fileName": "original (2).jpg",
                                "contentType": "image/jpeg"
                            }
                        },
                        "description": {
                            "en-GB": "Xanthagrion erythroneurum by Ry Beaver via iNaturalist. Photo licensed under CC BY-NC 4.0."
                        },
                        "title": {
                            "en-GB": "Xanthagrion erythroneurum"
                        }
                    },
                    "citation": "Carew ME, Metzeling L, St Clair R and Hoffmann AA (2017) Detecting invertebrate species in archived collections using next-generation sequencing. Molecular Ecology Resources. Wiley-Blackwell. Available at: https://doi.org/10.1111/1755-0998.12644.",
                    "topics": [
                        "ECOLOGY"
                    ],
                    "countriesOfResearcher": [
                        "AU"
                    ],
                    "title": {
                        "en-GB": "Identifying aquatic invertebrates using next generation sequencing"
                    },
                    "body": {
                        "en-GB": "In studies of aquatic invertebrate biodiversity, restraints on time and expenses often mean that communities are only identified to family levels. Archived samples stored in ethanol may, however, be identified more specifically at a later stage.\n\nThis study uses next-generation sequencing (NGS) of DNA barcodes to systematically identify species in archived macroinvertebrate samples from two sites in Australia, some of which had been stored up to 12 years at room temperature. Despite anticipated DNA degradation, the researchers were able to amplify partical DNA barcodes from most samples, and using these, identify the species often by more than one amplified sequence.\n\nNot all families had identifiable species, however, when the researchers compared the number of identified species per family with estimated equivalents in GBIF, they revealed potential gaps in the barcode library that could explain the lack of identified species.\n"
                    },
                    "type": "Entry",
                    "searchable": true,
                    "space": {
                        "sys": {
                            "type": "Link",
                            "linkType": "Space",
                            "id": "uo17ejk9rkwj"
                        }
                    },
                    "gbifRegion": [
                        "OCEANIA"
                    ],
                    "revision": 2,
                    "createdAt": "2017-09-28T14:37:39.196Z",
                    "countriesOfCoverage": [
                        "AU"
                    ],
                    "audiences": [
                        "GBIF_NETWORK",
                        "DATA_USERS"
                    ],
                    "primaryLink": {
                        "id": "19Fbu6S8gAE4s8YEsYGeES",
                        "label": {
                            "en-GB": "Original article (may require subscription)"
                        },
                        "url": {
                            "en-GB": "https://doi.org/10.1111/1755-0998.12644"
                        }
                    },
                    "id": "3gCOvQwphmS6kkKuWQKq2W",
                    "resourceUsed": "222 families",
                    "contentType": "dataUse",
                    "homepage": true,
                    "updatedAt": "2017-09-28T16:53:50.631Z"
                }
            },
            {
                "_index": "datause1506689838917",
                "_type": "content",
                "_id": "3zGBIwOLH2QsM6IcUm0ecW",
                "_score": 0.13180104,
                "_source": {
                    "summary": {
                        "en-GB": "Describing the structure of data papers through analysis of journals, their templates and guidelines"
                    },
                    "primaryImage": {
                        "file": {
                            "en-GB": {
                                "url": "//images.contentful.com/uo17ejk9rkwj/5SithJUWqs8QWeWYu6ci0o/2b02ececdb678e3559af46a535507dfa/gulls.png",
                                "details": {
                                    "size": 1527953,
                                    "image": {
                                        "width": 1500,
                                        "height": 500
                                    }
                                },
                                "fileName": "gulls.png",
                                "contentType": "image/png"
                            }
                        },
                        "description": {
                            "en-GB": "Map excerpt from data paper by Stienen et al. in Zookeys describing a bird tracking dataset."
                        },
                        "title": {
                            "en-GB": "Map excerpt from data paper \"GPS tracking data of Lesser Black-backed Gulls and Herring Gulls breeding at the southern North Sea coast\" by Stienen et al published 2016 in Zookeys."
                        }
                    },
                    "citation": "Chen Y-N (2017) An analysis of characteristics and structures embedded in data papers: a preliminary study. Libellarium: journal for the research of writing, books, and cultural heritage institutions. University of Zadar 9(2). Available at: https://doi.org/10.15291/libellarium.v9i2.266.",
                    "topics": [
                        "DATA_PAPER"
                    ],
                    "countriesOfResearcher": [
                        "TW"
                    ],
                    "title": {
                        "en-GB": "Developing a common structural framework for data papers"
                    },
                    "body": {
                        "en-GB": "Many institutions, including GBIF, encourage sharing of research data through [data papers](/data-papers) that extend metadata in a way that mirrors the traditional scientific publication model. Dozens of journals now accept data papers, however, as highlighted by this study, they lack a common standard.\n\nBy reviewing submission templates and guidelines from 26 data journals, the authors describe a unifying framework consisting mainly of three distinct components: 1) basic information (e.g. title, abstract, author, etc.), 2) dataset descriptions (i.e. how was data collected, how it formatted, what does it cover, etc.), and 3) relationships (i.e. links and references). \n\nThe authors use the proposed framework to highlight the successful case of mapping metadata directly derived from the GBIF [Integrated Publishing Toolkit (IPT)](/ipt) onto a data paper template that can be edited and submitted to a journal for consideration.\n\nAs of September 2017, authors have contributed to more than [50 data papers describing datasets published in GBIF](/resource/search?contentType=literature&topics=DATA_PAPER&relevance=GBIF_PUBLISHED)."
                    },
                    "type": "Entry",
                    "searchable": true,
                    "space": {
                        "sys": {
                            "type": "Link",
                            "linkType": "Space",
                            "id": "uo17ejk9rkwj"
                        }
                    },
                    "gbifRegion": [
                        "ASIA"
                    ],
                    "revision": 2,
                    "createdAt": "2017-09-29T12:34:33.587Z",
                    "audiences": [
                        "GBIF_NETWORK",
                        "DATA_USERS",
                        "DATA_HOLDERS"
                    ],
                    "primaryLink": {
                        "id": "62GlLSdFN6YMSsMqIEiyIq",
                        "label": {
                            "en-GB": "Original article"
                        },
                        "url": {
                            "en-GB": "https://doi.org/10.15291/libellarium.v9i2.266"
                        }
                    },
                    "id": "3zGBIwOLH2QsM6IcUm0ecW",
                    "contentType": "dataUse",
                    "homepage": true,
                    "updatedAt": "2017-09-29T12:56:30.688Z"
                }
            }
        ]
    }
}

Using "origin": "2017-09-29T15:13:00.196Z" returns the expected result

Looks like an issue of the query being now/d which is just the day, not the full time

closed by https://github.com/gbif/portal16/blob/fe03cae5dcbb4ecc79f266e5d435a32fb57e4da7/app/controllers/api/resource/search/resourceSearch.js#L204


Corrects confusing error message when manifest not found

Resolves SOUS-1020; includes #804; See https://github.com/opentable/sous/pull/805/files#diff-91432d762aa99853969261d3158edbb4R15 for test case covering the bug report, and https://github.com/opentable/sous/pull/805/commits/e13914ca4845dc165bbe1da6887be4c8e7f07aac for the resolution.

LGTM!
No errors, no warnings. :shipit:

  Generated by :no_entry_sign: Danger


Add animepahe as extension

Hello admin, can you add animepahe  extension? Cause it is one of the best sites to watch and there is a quality selection , the 720,1080 both compressed size compare to 4anime and the existing extension you add ,  and my issue is that i have only 16gb of internal storage ,thanks for making this kind of app..

Yes,you are absolutely right. I also like this website.

closing cause AP is already added


CASMINST-6532: Update lists of RPMs that CFS installs/updates on nodes

Summary and Scope
This update the list of RPMs that are installed/updated from Nexus by CFS. Among other things, this will address the fact that it was not updating the Cray CLI RPM on NCNs.
Issues and Related PRs

Source PR
stable/1.5 backport PR
release/1.4 PR

Testing
I tested the updated configuration on bradi, where the problem was originally discovered after it was updated to CSM 1.4.1.
Risks and Mitigations
Low risk
Pull Request Checklist

[X] Version number(s) incremented, if applicable
[X] Copyrights updated
[X] License file intact
[X] Target branch correct
[X] CHANGELOG.md updated
[X] Testing is appropriate and complete, if applicable

/backport stable/1.5


Dependency-check return null with folder link alias

I've noticed that the plugin fails its scan and return null when it tries to scan a node_module folder link. It tries to go inside the folder but doesn't find a real folder, so it fails and returns error:
WARN] An unexpected error occurred during analysis of '/project/npm-shrinkwrap.json' (Node.js Package Analyzer): null
[ERROR]
java.lang.NullPointerException: null
	at org.glassfish.json.JsonObjectBuilderImpl$JsonObjectImpl.getString(JsonObjectBuilderImpl.java:199)
	at org.owasp.dependencycheck.analyzer.NodePackageAnalyzer.processDependencies(NodePackageAnalyzer.java:253)
	at org.owasp.dependencycheck.analyzer.NodePackageAnalyzer.processDependencies(NodePackageAnalyzer.java:259)
	at org.owasp.dependencycheck.analyzer.NodePackageAnalyzer.analyzeDependency(NodePackageAnalyzer.java:226)
	at org.owasp.dependencycheck.analyzer.AbstractAnalyzer.analyze(AbstractAnalyzer.java:138)
	at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:88)
	at org.owasp.dependencycheck.AnalysisTask.call(AnalysisTask.java:37)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
[INFO] Finished Node.js Package Analyzer (0 seconds)

Monorepo or big projects has lots of submodules with their dependencies and folder links helps npm i for better performances, but this represents a problem for the plugin.
I don't know if it is a bug or a possible feature, but I think it's a good idea to let you know about this behaviour. Is it possible for dependency-check to follow the link and scan the correct folder (and complete correctly the scan) or is it a project self limit if this plugin is used for it?
Thank you very much

It should be a bug btw, is there a way to change the issue label?

Hello @b82 , sorry for the long delay, I just see your issue, and maybe having something similar .
If I correctly understand, your project include some other projects ? in sub_folders ?
Are the other package.json checked by dependency-check ?
Did you agree that skipping the scan of the sub modules, when scanning the root  npm-shrinkwrap.json can be a solution ?
Maybe you can share your npm-shrinkwrap.json ?
Else, are your submodules respecting this schema (in npm-shrinkwrap.json) ?
Is version the same schema ? file:name_of_the_submodule
{
    "fake_submodule": {
      "version": "file:fake_submodule",
      "requires": {
        "braces": "^1.8.5"
      },
      "dependencies": {
        "braces": {
          "version": "1.8.5",
          "resolved": "https://registry.npmjs.org/braces/-/braces-1.8.5.tgz",
          "integrity": "sha1-uneWLhLf+WnWt2cR6RS3N4V79qc=",
          "requires": {
            "expand-range": "^1.8.1",
            "preserve": "^0.2.0",
            "repeat-element": "^1.1.2"
          }
        }
      }
    }
}

I'm running into this issue as well. Any linked package, such as below, causes the error:
"node_modules/utils": {
    "resolved": "packages/utils",
    "link": true
},

Does anyone know how to avoid the error? It scans all the dependencies, but the exception is always logged and makes you wonder whether it missed some dependencies.

I'm running into this issue as well. Any linked package, such as below, causes the error:
"node_modules/utils": {
    "resolved": "packages/utils",
    "link": true
},

Does anyone know how to avoid the error? It scans all the dependencies, but the exception is always logged and makes you wonder whether it missed some dependencies.

I've been digging into this as well today, as I'm struggling with the same NPE as result. I think the code needs updating to recognize a "link" entry, and simply skip it without trying to parse the version attribute (which doesn't get added by NPM to the link entry). I'm not an expert on the NPM package_lock file, but examining https://github.com/jeremylong/DependencyCheck/blob/main/core/src/main/java/org/owasp/dependencycheck/analyzer/NodePackageAnalyzer.java suggests that a partial fix was added to shouldSkipDependency, but an additional change is also needed in processDependencies where it blindly assumes that every entry that is a JsonObject has a version key.
Unfortunately because it's a crash, I can't see a quick and easy way to work around it, unless there is a way to tell DependencyCheck to not report a failure in such a case.
A potential "fix" might be something like:
                if (entry.getValue() instanceof JsonObject) {
                    jo = (JsonObject) entry.getValue();

                    // Ignore/skip linked entries
                    if (jo.getBoolean("link", false) {
                        continue;
                    }

                    version = jo.getString("version");
                    optional = jo.getBoolean("optional", false);
                    isDev = jo.getBoolean("dev", false);
                } else {
                    version = ((JsonString) entry.getValue()).getString();
                }

@rturner-edjuster any chance you could open a PR with the suggested fix?

@jeremylong Sure -- might take me a few hours as I'll need to get all set up with the project, etc, and learn all the project semantics, and how to get an automated test in for it, etc. But I'll see what I can do this evening.

@jeremylong PR is up and waiting for approval to run workflows, etc. Seems to fix the issue in my environment locally, and the test I added passes with the fix, and crashes without. Let me know if you need any other changes done, or if I haven't completed things in compliance with the project guidelines.

When is this going to be release?

This should be fixed in 8.0.0.


Add missing consumePurchase plugin method for GodotPayment

cc @timoschwarzer

Whoops sorry! I didn't have any consumables to test 😅
Thank you!

Can you make a PR for master too?

@akien-mga no problem. Will that soon.

@timoschwarzer you don't have to be sorry. I appreciate you for all of your work. I'm just testing your nice work. :smile:

Thanks!


Add transport unit

#67
The transport unit can carry personnel and armored units across bodies of water. See its definition in Elite Command: https://github.com/cvincent/elite-command/blob/c84a3afb3eb2aad3b88c9cc34a7c497caa156010/config/initializers/unit_definitions.rb#L1147

@djwhitt If a player wants to load an infantry unit into a transport unit, the infantry should be selected and the transport should be targeted, right?

Related question: should a transport unit be allowed to move the same turn that units have been loaded into it?

Other question: should the transport cost for each unit type be put into a map somewhere in the data file, such as
:transport-costs {:personnel 1 :armored    3}
or should it be hardcoded into each unit definition (the same way only personnel can capture but that information is represented as a bool within every unit definition)?

One more question: when a unit is loaded into a transport unit, what should happen to its representation in the database? It could be retracted, all of its relevant information (unit-type, round-built, count) stored within the transport unit's data, and re-added when it leaves the transport unit. If a transport unit is destroyed, all of its passengers would automatically go down too (which I imagine is the intended behavior). But I don't know what issues this could cause or if it's unidiomatic.

@djwhitt I had a lot of questions, so I'm consolidating them into this post.

If a player wants to load an infantry unit into a transport unit, should the infantry be selected and the transport unit should be targeted, right? Is the action being done by the infantry?
Should a transport unit be allowed to move the same turn that units have been loaded into it?
Should a unit only be able to load into a transport unit if the transport unit is one tile away?
Should a unit only be able to load into a transport unit if the transport unit is in a port?
Should the transport cost for each unit type be put into a map somewhere in the data file, such as
:transport-costs {:personnel 1 :armored 3}
or should it be hardcoded into each unit definition (the same way only personnel can capture but that information is represented as a bool within every unit definition)?
When a unit is loaded into a transport unit, what should happen to its representation in the database? It could be retracted, all of its relevant information (unit-type, round-built, count) stored within the transport unit's data, and re-added when it leaves the transport unit. If a transport unit is destroyed, all of its passengers would automatically go down too (which I imagine is the intended behavior). But I don't know what issues this could cause or if it's unidiomatic.

Yep, infantry selected and transport targeted. Infantry should perform the boarding action.
Yes.
As long as the transport is within movement range, it should be possible to board it.
No, loading anywhere along the shore should be allowed.
By cost do you mean the space occupied inside the transport? If so, then it should be part of each unit definition. It'll likely be the same for all personnel, but I could see it varying for armored units.
There should be a unit/units-contained attribute on the transport. When a unit boards, it should get related to the transport using that attribute, and its location should be retracted. When the unit deboards, the transports unit/units-contained attribute should be retracted and the new location should be added to the unit.

Thanks for these answers. Follow ups:
3/4. I'm having a bit of trouble determining when a passenger unit can board a transport unit, if the transport unit is on a terrain the passenger unit cannot move to. It might be better for me to leave it unfixed for now and we can look more closely at the code together when I make a PR.

Yeah, cost = space occupied. Elite Command gave personnel a cost of 1 and armored a cost of 3. For now, I've assigned 1 to all personnel and 3 to all armored, naval, and air (in their unit defs).

And some new questions:
Whenever a unit with units contained is selected, I imagine information about each of those contained units should be displayed. I'm thinking it could either appear below the screen (above or below the hover/terrain-effects info) or a button could appear (labeled something like "View units contained") that would trigger a modal with the same information (probably in a nicer, less compact format like the unit picker, with corresponding images for each unit).

Which option seems better to you? Or do you have another idea entirely?
What information should be displayed? I think only unit-type and count matter since the unit can't really do anything while being transported.

3/4. Ah, I hadn't fully thought through the implications of not being able to move to the terrain the transport is on. Pressing on sounds good and I'll keep thinking about it.
Re viewing contained units, I was thinking about this a bit when you asked your previous set of questions and wondered what your plan was. :smile:
I think a "View units contained" (or something similar) button + modal popup is the better option. I don't love either choice, but I haven't though of anything better. I agree about the information displayed. Unit type and count are all that's needed.

Cool, I was also thinking the button + modal popup would be better so I'll get that working soon. We can always replace it later if someone thinks of a better design.

I'm returning to this with the Datascript knowledge I gained fixing #87 and I'm wondering if I should also use a relation instead of a regular value for the stored/contained units.

Yes, units/units-contained should be relation.

Thanks.
Should a transport unit and its passenger separately store the same value (like a random integer) as a way to reconnect when loading a game from a URL?

I don't think a coordinating value is necessary. I'd just nest the passenger units under the transport when serializing the game state.
Also, on a different note, I like the "passengers" term. I think :unit/passengers is better than :unit/units-contained as an attribute name.

I've changed "units-contained" to "passengers" and fixed the :unit-passengers relation, so I've moved back to working on boarding and disembarking passengers. I'm wondering if instead of boarding by effectively moving to the location of the transport unit--which is difficult because the transport unit may be in a terrain-type the potential passenger cannot move to--a unit should able to move before boarding and board when it is one tile away from a transport unit.

I think splitting it into two actions is fine (move, then board adjacent transport). From a UI perspective, we may want to have a way to combine those (move + board in a single click), but don't worry about that until it's working.

Cool. Should we also disembark passengers with a two step process because of the same terrain issues?

Yeah, I agree, two step disembarking makes sense.


Animation about showing completion of step 5 doesn't load successfully on tutorial "Simple Extensions"

Describe the bug
Animation about showing completion of step 5 doesn't load successfully on tutorial "Simple Extensions"
Steps to reproduce the behavior

Navigate to https://arcade.makecode.com/
Click "Simple Extensions" on "Tutorial" -> "Start tutorial"
Click Step 5

Expect behavior
Animation about showing completion of this step loaded successfully
Actual behavior
Animation about showing completion of this step doesn't load successfully

Additional context

OS: Windows(rs6)
arcade version: 0.15.13
Microsoft MakeCode version: 5.30.40

Looks like this GIF might of got whacked in #1623.

Ahh, I spent a while making a nice gif for this one too, must have mis-saved and lost it :(

It's this now...
docs/static/tutorials/simple-extensions/create-tilemap.gif


Testing broken pipelines on ci no. 2

Is this check enough?
If examined and consumed are canonically the same, but examined points to the BufferSegment before the one pointed to by consumed, the examined BufferSegment would get returned. Considering _bufferSegmentPool is used like a stack, GetLength could quickly be called with a _lastExamined segment that's been reused and been given a new RunningIndex.

We found it1


fixes #78: make sure the correct Signature elements are  verified

checks that the found Signature elements match their expected schema locations, and that there's only one of each
make sure the expected Signatures are always verified
a few other small hardenings

Coverage decreased (-0.1%) to 96.495% when pulling 40eacc65c616b647363d5e6797f870a7e4a30d49 on miszobi:issue/78-avoid-response-signature-spoofing into cc296ae9b98eddbf2d1941bd2b891fc3c29a4716 on onelogin:v2.0.0.

Let me the weekend to review the PR and maybe find an alternative solution, and let's push that and more tests to prevent it on monday.

The only strictly required part is the one in processSignedElements.
The others are general security hardening fixes: using absolute xpaths where applicable, making sure the nodes we expect a single occurrence of actually appear only once - all these are good practices, as recommended by OWASP (also here)

I'm agree with the improvement except the change of the validateSign method and the checkSignature method.
Can we do the wantResponseSigned & wantAssertionSigned check on the processSignedElements instead doing that at the validateSign method?

I can drop the wantResponseSigned & wantAssertionSigned parameters from validateSign- the signatures being present, singular, and in the right spot is in fact done by processSignedElements.
However the proposed implementation of validateSign doesn't check the Assertion signature if the Response signature is found.
As per SAML core I believe both should be checked if present:
lines 637-640:

The SAML assertion MAY be signed, which provides both authentication of the issuer and integrity protection.
If such a signature is used, then the ds:Signature element MUST be present, and a relying party MUST verify that the signature is valid

lines 1562-1565:

The SAML request MAY be signed, which provides both authentication of the requester and message integrity.
If such a signature is used, then the ds:Signature element MUST be present, and the SAML responder MUST verify that the signature is valid

So I believe we should go with something like:
    public static Boolean validateSign(Document doc, X509Certificate cert, String fingerprint, String alg) {
		try {
            final NodeList responseSignature = query(doc, RESPONSE_SIGNATURE_XPATH);
            final NodeList assertionSignature = query(doc, ASSERTION_SIGNATURE_XPATH);

            if (responseSignature.getLength() == 0 && assertionSignature.getLength() == 0) {
                return false;
            }

            boolean validResponseSignature = responseSignature.getLength() == 1 ? validateSignNode(responseSignature.item(0), cert, fingerprint, alg) : true;
            boolean validAssertionSignature = assertionSignature.getLength() == 1 ? validateSignNode(assertionSignature.item(0), cert, fingerprint, alg) : true;

			return validResponseSignature && validAssertionSignature;
		} catch (XPathExpressionException e) {
			log.warn("Failed to find signature nodes", e);
		}
		return false;
    }

If you validate the integrity of the container (Response), the Assertion included should be consider correct too.

True, but the spec does specifically say each MUST be checked if present. I see it as an additional defense-in-depth check, where even if the attacker could for example wrap the Response signature, the Assertion signature will also be checked. Any reasons for not doing it this way?

Only the over cost.

Also take in mind that when the encryption appears on the assertion, the signature validation is not that easy:

Signature Response validation should use the original SAMLResponse.
Signature Assertion validation should use the SAMLResponse with the EncryptedAssertion decrypted.

Right. So maybe instead of calling validateSign from SamlResponse.isValid, and assuming that both signatures come from the same document, let's have two calls, each pointing to the right document. The added benefit would be that isValid knows which signatures it expects, and can make the right calls. Does that sound reasonable?
As for performance, using a simple benchmark of running the assertions in testValidateSignInvalidInputs 1000 times, the change does seem introduce a ~20% performance cost:
check one signature:
1000x testValidateSign: 8s161ms

check both signature:
1000x testValidateSign: 9s833ms

However note that each of those tests runs validation 12 times, so that's 12000 validations, changing the per-validation cost from ~68ms to ~82ms. Seeing as during authentication the caller is usually dealing with several http requests and redirects, I don't think this is really notable. Also as mentioned above we'd be following the spec on this, and adding some extra verifications to the authentication process.

Ok, sound reasonable.

Coverage decreased (-0.03%) to 96.572% when pulling bb18cf23147a2b70f869c8d14139a4701263a7d2 on miszobi:issue/78-avoid-response-signature-spoofing into cc296ae9b98eddbf2d1941bd2b891fc3c29a4716 on onelogin:v2.0.0.

Updated as discussed.


Broken connection fix

Short Description:
Fixes:

Added reconnecting_timeout to config params
Added waiting for reconnecting_timeout minutes if NotLoggedInException is raised

You are making changes to code not related to subject, such as initial_transfer_worker.py.
Clean up the code and please create a new clean PR


Loading RGD JSON for human genes.

Closes #140.

note: we will still be getting some human data from rat after 0.3.  Disease associations, for example.


<EMAIL_ADDRESS>decompress error

scoop bucket add extras
scoop install extras/wingetui
Installing 'wingetui' (3.1.1) [64bit] from 'extras' bucket
Loading WingetUI.Installer.exe from cache
Checking hash of WingetUI.Installer.exe ... ok.
Extracting WingetUI.Installer.exe ... ERROR Exit code was 1!
Failed to extract files from C:\Users\user\scoop\apps\wingetui\3.1.1\WingetUI.Installer.exe.
Log file:
  ~\scoop\apps\wingetui\3.1.1\innounp.log

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=wingetui%403.1.1%3a+decompress+error

Log:
Signature detected: Inno Setup Setup Data (6.3.0)
This is not directly supported, but i'll try to unpack it as version 5602
; Version detected: 6300
Critical error: The setup files are corrupted. Please obtain a new copy of the program.

Current Scoop version: 0.5.2
'extras' bucket version: 1.7.0

Duplicates #13709.

Fix linked here https://github.com/ScoopInstaller/Extras/issues/13444#issuecomment-2213509434


neovim-remote: disable tests

Description of changes
The only enabled test started to fail with write errors. Setting HOME=$TMPDIR works, but then it fails the same way than the disabled ones
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

with master c3fafea4edcfed02a37f5f9dfa36c871d1b00e8d , it builds ok for me (linux), what's the error ?

Huh, maybe it's a macOS only issue:
----------------------------- Captured stdout call -----------------------------
[!] Can't connect to: pytest_socket_20a44d4e-a32d-4e56-b024-9432907def1d

    The server (nvim) and client (nvr) have to use the same address.

    Server:

        Specify the server address when starting nvim:

        $ nvim --listen pytest_socket_20a44d4e-a32d-4e56-b024-9432907def1d

        Use `:echo v:servername` to verify the address.

        Alternatively, run nvr without arguments. It defaults to
        starting a new nvim process with the server name set to
        "/tmp/nvimsocket".

        Security: When using an Unix domain socket, that socket should
        have proper permissions so that it is only accessible by your
        user.

    Client:

        Expose $NVIM_LISTEN_ADDRESS (obsolete in nvim but still
        supported by nvr) to the environment before using nvr or use
        its --servername option. If neither is given, nvr assumes
        "/tmp/nvimsocket".

        $ NVIM_LISTEN_ADDRESS=pytest_socket_20a44d4e-a32d-4e56-b024-9432907def1d nvr file1 file2
        $ nvr --servername pytest_socket_20a44d4e-a32d-4e56-b024-9432907def1d file1 file2
        $ nvr --servername <IP_ADDRESS>:6789 file1 file2

    Use -s to suppress this message.

----------------------------- Captured stderr call -----------------------------
Error detected while processing function <SNR>14_LoadRemotePlugins[5]..<SNR>14_GetManifest[1]..<SNR>14_GetManifestPath:
line   10:
E739: Cannot create directory /homeless-shelter: read-only file system

When HOME is set to TMPDIR the last part is not shown, but it still with Can't connect to: pytest_socket_20a44d4e-a32d-4e56-b024-9432907def1d (as the already disabled tests do)

Maybe change to doCheck = !stdenv.isDarwin instead.

Done 👍


Addition to the compaction_report.html file which shows the W value changing over time graphically.

In the drop down menu, select W value to see how W changes
over your test (more useful for adaptive tests than
static scaling parameter tests).

Let's make sure that the graph extends to negative values of W by changing the code in the graph.html template, line 241. It should use a calculation of the minimum similar to the next line, but we also should make sure we use 0 as the minimum if no value is negative (we can use Math.min(0, ...) to achieve  that).


HBASE-29005 Cannot split split system tables when quota enforcement is enabled

When quotas are enabled, splitting the quota table fails due to the namespace region quotas system being partially initialized.
2024-11-28T14:11:38,672 ERROR [PEWorker-2 {}]
procedure2.ProcedureExecutor(1844): CODE-BUG: Uncaught runtime
exception: pid=7, state=RUNNABLE:SPLIT_TABLE_REGION_PRE_OPERATION,
hasLock=true; SplitTableRegionProcedure table=hbase:quota,
parent=3c1dbd551845ed2e8033b76570c6d8f6,
daughterA=a8f5e70728d93859d7c3d95aa5a0f63b,
daughterB=c71f49ad7e689a57742a9fe65b918d08
java.lang.NullPointerException: Cannot invoke
"java.util.concurrent.atomic.AtomicInteger.addAndGet(int)" because the
return value of "java.util.Map.get(Object)" is null
at org.apache.hadoop.hbase.namespace.NamespaceTableAndRegionInfo.incRegionCountForTable(NamespaceTableAndRegionInfo.java:101) ~[classes/:?]
at org.apache.hadoop.hbase.namespace.NamespaceStateManager.checkAndUpdateNamespaceRegionCount(NamespaceStateManager.java:95) ~[classes/:?]
at org.apache.hadoop.hbase.namespace.NamespaceAuditor.checkQuotaToSplitRegion(NamespaceAuditor.java:116) ~[classes/:?]
at org.apache.hadoop.hbase.quotas.MasterQuotaManager.onRegionSplit(MasterQuotaManager.java:544) ~[classes/:?]
at org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.preSplitRegion(SplitTableRegionProcedure.java:607) ~[classes/:?]
at org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.executeFromState(SplitTableRegionProcedure.java:298) ~[classes/:?]
at org.apache.hadoop.hbase.master.assignment.SplitTableRegionProcedure.executeFromState(SplitTableRegionProcedure.java:98) ~[classes/:?]
at org.apache.hadoop.hbase.procedure2.StateMachineProcedure.execute(StateMachineProcedure.java:188) ~[classes/:?]
at org.apache.hadoop.hbase.procedure2.Procedure.doExecute(Procedure.java:941) ~[classes/:?]
at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.execProcedure(ProcedureExecutor.java:1825) ~[classes/:?]
at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1503)~[classes/:?]
at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.runProcedure(ProcedureExecutor.java:2154) ~[classes/:?]
at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216) ~[classes/:?]
at org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2181) ~[classes/:?]

See discussion on the dev list, https://lists.apache.org/thread/gdnjb1ys8m93lowykdrh4m7o55mgw3vo

FYI @droudnitsky

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  9s

master passed

+1 :green_heart:
compile
3m  6s

master passed

+1 :green_heart:
checkstyle
0m 36s

master passed

+1 :green_heart:
spotbugs
1m 33s

master passed

+1 :green_heart:
spotless
0m 44s

branch has no errors when running spotless:check.

-0 :warning:
patch
0m 51s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
3m  7s

the patch passed

+1 :green_heart:
javac
3m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

+1 :green_heart:
spotbugs
1m 38s

the patch passed

+1 :green_heart:
hadoopcheck
10m 46s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 43s

patch has no errors when running spotless:check.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 49s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed

+1 :green_heart:
shadedjars
8m 55s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
255m 33s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

294m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6501

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 08ae5fd19425 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4a6a5149dc7ca43d115f88a5ed7f19a595b5e19d

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/2/testReport/

Max. process+thread count
4738 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.001 s - in org.apache.hadoop.hbase.TestSplitMergeQuotaTable

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 32s

master passed

+1 :green_heart:
compile
3m 17s

master passed

+1 :green_heart:
checkstyle
0m 38s

master passed

+1 :green_heart:
spotbugs
1m 47s

master passed

+1 :green_heart:
spotless
0m 49s

branch has no errors when running spotless:check.

-0 :warning:
patch
0m 55s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 15s

the patch passed

+1 :green_heart:
compile
3m 13s

the patch passed

+1 :green_heart:
javac
3m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 37s

the patch passed

+1 :green_heart:
spotbugs
1m 59s

the patch passed

+1 :green_heart:
hadoopcheck
14m 59s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 59s

patch has no errors when running spotless:check.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 20s

the patch passed

+1 :green_heart:
compile
1m  2s

the patch passed

+1 :green_heart:
javac
1m  2s

the patch passed

+1 :green_heart:
javadoc
0m 29s

the patch passed

+1 :green_heart:
shadedjars
6m  1s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
247m 30s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

275m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6501

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux 56e3a88d58df 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4a6a5149dc7ca43d115f88a5ed7f19a595b5e19d

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/3/testReport/

Max. process+thread count
5040 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/3/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 29s

master passed

+1 :green_heart:
compile
3m 13s

master passed

+1 :green_heart:
checkstyle
0m 41s

master passed

+1 :green_heart:
spotbugs
1m 46s

master passed

+1 :green_heart:
spotless
0m 52s

branch has no errors when running spotless:check.

-0 :warning:
patch
0m 59s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 20s

the patch passed

+1 :green_heart:
compile
3m 20s

the patch passed

+1 :green_heart:
javac
3m 20s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 38s

the patch passed

+1 :green_heart:
spotbugs
1m 50s

the patch passed

+1 :green_heart:
hadoopcheck
12m  7s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 47s

patch has no errors when running spotless:check.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 17s

the patch passed

+1 :green_heart:
compile
0m 59s

the patch passed

+1 :green_heart:
javac
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed

+1 :green_heart:
shadedjars
6m  1s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
221m 51s

hbase-server in the patch passed.

248m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6501

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux e06afcd0942b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4a6a5149dc7ca43d115f88a5ed7f19a595b5e19d

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/4/testReport/

Max. process+thread count
4991 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6501/4/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Web Interface: On "Printer Defaults" page you get a form submission error when changing too many settings at the same time

Describe the bug
Withe the recent addition of vendor PPD option support in the PostScript Printer Application, a very long list of options can appear on the "Printer Defaults" page, especially for higher-end laser printers, like the Sharp AR-C260F PS, but the 8 vendor options of the HP OfficeJet Pro 8730 (an inkjet multi-function printer) are already enough to trigger this bug.
It is no problem to have a long option list. If one changes only one arbitrary option and submits the form, the option gets correctly changed (and the change saved in the state file), but if one changes all the vendor options and then submits the form one gets a form submission error. It looks like that the changes get added to a buffer and for changing all the options the buffer is too small.

@tillkamppeter Strange, the form read buffer is 64k and so shouldn't fill up so quickly. Can you provide a debug log from your printer application when trying to change the options?
Also, what browser are you using?

Browser is the Chromium which comes with Ubuntu 20.10 Groovy, version 85.0.4183.83.

I am not able to reproduce it any more, even with the Sharp where there are many more options.


Create scaffolding for LCCS tool

This PR adds constants, text content and component stubs for the LCCS tool

@mukhtyar I think this is a great start. I would suggest merging this before doing anything further.

 LCCS: Create scaffolding


PaddleReid

aicity 2020 track2 vehicle re-identification training code

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Break out parsers into their own files

Currently, the parsers are included in the functions that collect data. I like that approach, generally speaking. However, breaking them out into their distinct modules declutters the collector files and makes it easier to do doctests on the parsers.

We are no longer using a parsers file.


Channels vagrant deploys, but alerts not working

Hi,
I managed to get a vagrant up from the channels branch, but unable to receive any alerts for incidents. Here is what I did to test it, please advise if anything is wrong:

I created a new superuser to login since I don't know the password for the existing users
Access the site at localhost:8000 (using Firefox 44.0.2 on Win 7)
Login with user from step 1
Draw a new area of interest at http://localhost:8000/tracker/area_of_interest/create/ with a severity of medium
Open http://localhost:8000 in browser window 2 and zoom in to the area of interest
In browser window 1 create an incident within the area of interest with medium severity
Expect a alert to popup in browser window 2 => no alerts
Refresh browser window 2 and there is a marker within the area of interest but no alerts

Is there any step that I am missing?
Cheers,
SN

It seems there's a problem with uWSGI (it works just fine with the development server). I'm looking into it right now.

As I suspected, channels 0.8 didn't have the code to adapt wsgi to asgi. I fooled around with the latest version of channels, asgi_redis and asgiref and everything seems to be working (no obvious errors) but messages aren't send through the WebSockets. I'll try with newer versions as soon as they're available, and I'll update this project accordingly.

Thanks for looking into this. Meanwhile I also tried the master branch vagrant and it works fine. As someone who is just getting into websockets, which of the tracker_project branches would you suggest to work with? Would the conclusions mentioned in the gevent-socketio post be an issue? The node_js approach seems more common but I have yet to try it.
Cheers,
SN

I would personally go with the Node.js branch as gevent-socketio seems to have been abandoned.

I've updated the code to work with the latest channel code. Everything should work now.

Thanks, I'll check it out!

Update: Just tested using the Vagrantfile, I can confirm that the incident alerts work again. Much appreciated.
Cheers,
SN

Update 2: There seems to be an issue where alerts stop appearing after a while. I keep the Incidents and Areas of Interest page open in one window and keep creating new incidents in another one. Alerts stop appearing by the 4th incident. Here is the last output from the console log (same on Firefox 44 and Chromium 49):
close close { target: WebSocket, isTrusted: true, wasClean: false, code: 1006, reason: "", currentTarget: WebSocket, eventPhase: 2, bubbles: false, cancelable: false, defaultPrevented: false, timeStamp:<PHONE_NUMBER>372000 }

Cheers,
SN

I've implemented a simple connection try mechanism and a connection status label on the home interface.

It looks like there is a moment when the map stops showing alerts (with connection still green) and then the socket.onclose event is triggered which reconnects (and alerts start showing) until it repeats again.


Fix bug when comparing env data to selected environment

Description
We use the getEnvironmentIdentifier to identify environments but in this case, we were not comparing the unique identifier. Instead, we were comparing the env type only. This fixes it.
Steps to Test
Outline the steps to test and verify the PR here.
Example:
The test cases can be found in BB8-7140

Run the test case in ^ and verify it's failing
Checkout this PR
Run npm link
Re-run the test case in ^ and verify it's fixed
Enjoy

@elazzabi when is this planned to be released?

@chrean well, I forgot to merge it, and now we need to release a new version 🤣

@chrean just noting that this was merged part of the 2.0.5 release


[Python] Delete accumulated output in failed writes

If a write fails, a dead feather file remains.

Fixed in Feather 0.4


Reduce number of results in wikidata integration tests

Description

Related Issues

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.

merging this, will need to fix the bugs in the wikidata unit tests using a mockup


Remove temporary file.

What was this file used for?

It appears to be a small test/experiment that snuck into a commit, probably from using git add . or similar.

Yes, git add . , chalk it under @debedb being a dummy.


kapp controller should support nested imgpkg bundles

What steps did you take:
I am attempting to utilize imgpkg to deploy a set of nested imgpkgs that are used to release versioned applications.  I would like to nest specific versions into a parent imgpkg that is curated for a specific deployment target.
I have created an imgpkg with 2 nested image packages.  I am able to do a pull recursive on the image package and I see both bundles in the .imgpkg folder and things looks OK.
When I point kapp controller at the parent imgpkg bundle I get a different outcome:
apiVersion: kappctrl.k14s.io/v1alpha1
kind: App
metadata:
  name: env1-bundle-imgpkg
  namespace: kapp-gitops-mgmt
spec:
  serviceAccountName: kapp-sa
  fetch:
    - imgpkgBundle:
        image: <registry>/env-bundle-imgpkg/env-bundle-copy:env1
  template:
    - ytt: {}
    - kbld:
        paths:
        - "-"
        - .imgpkg/images.yml
  deploy:
    - kapp: {}

What happened:

template:
    error: 'Templating dir: Error (see .status.usefulErrorMessage for details)'
    exitCode: 1
    stderr: |
      kbld: Error: Validating imageslock/ (imgpkg.carvel.dev/v1alpha1) cluster:
        Validating Overrides[0]:
          Expected Image or ImageRepo to be non-empty
    updatedAt: "2021-05-05T15:52:34Z"
  usefulErrorMessage: |
    kbld: Error: Validating imageslock/ (imgpkg.carvel.dev/v1alpha1) cluster:
      Validating Overrides[0]:
        Expected Image or ImageRepo to be non-empty

What did you expect:
I expected my imgpkg to at least begin to reconcile.
Anything else you would like to add:
Environment:

kapp Controller version (execute kubectl get deployment -n kapp-controller kapp-controller -o yaml and the annotation is kbld.k14s.io/images): 0.19.0
Kubernetes version (use kubectl version)  v1.19.1+vmware.2

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Opened related PR in vendir. Once thats merged, we can update kc to leverage it

Looks like the PR was merged in vendir but a new version hasn't been released yet.

Looks like this did make it to the released version of Vendir:
https://github.com/vmware-tanzu/carvel-vendir/issues/62#issuecomment-867169923

Nice catch, @frizzr! Closing.


Typing text in a link - underline shifts after a second

Does not repro in 1.9

Have an underlined link in an editor
Type more text in the link
Its underline starts too high, then after a second, drops down to the right spot

Introduced with #19645


Firefox: check if RTCSessionDescription and RTCIceCandidate exist before overwriting them

since i'm anticipating @jan-ivar dealing with this soon :-)

Yeah this makes sense, LGTM.


Use curl from default apk repo

Description
Changes proposed in this pull request:

Use curl from default apk repo

/test all

/test all


Support for connection client-provided name

I'd like to be able to specify a connection name to easily distinguish different clients from the Rabbit MQ admin portal.  Currently, RabbitMQConnectionCache will automatically use the Host if there's a cluster available when calling CreateConnection, and leave the name empty if not (link).
The bug on the RabbitMQ side of things for the .NET client was fixed back in May.
As I'm new to using RabbitMQ, though, I'm not sure if this would be of value to others. I'm happy to create a PR with the change (adding another property to RabbitMqHostSettings for client name) but wanted to check beforehand. Is this something worth submitting a PR for?

I think it sounds great, a sensible default should be specified as well. The Client Properties are already set using the process/assembly/machine names, so perhaps use a combination by default and then allow it to be overridden in the x.Host(...) block of the bus configuration.

@phatboyg Ok thanks :) Will put something together over the weekend.

The Client Properties are already set using the process/assembly/machine names,

Just so I'm sure, you're referring to this and suggesting that's where I set the default?

@phatboyg Here's my first attempt - https://github.com/Trov/MassTransit/pull/1

I assumed all the current Host methods needed to remain for backwards-compatibility so I added the overload as you mentioned. Briefly looked into modifying IRabbitMqHostConfigurator instead but it didn't seem right; happy to take that approach if you'd like though :)

I want to add unit tests although a) I wasn't sure where exactly to add tests for this and b) figured it would be better to wait until I was sure this approach was ok.

Should I worry about the change to SolutionVersion.cs?


DisallowCloakingCheck should allow props

DisallowCloakingCheckSniff should not error on properties
    if (isset($this->modelClass)) {
        $this->loadModel();
    }

Especially given #[\AllowDynamicProperties] could be used in the object hierarchy
it is fair that one would want to check on the existence this way.
Same for empty() and !isset()/!empty().
We can add a strict config (default false), though to keep the current strict check as opt-in.

https://github.com/php-collective/code-sniffer/commit/a9088644fcec3aaec4698903b88c13e1b9bfeef9


Latest version fails to build for android

I am not able to build for android when using the latest version of your package with the following error.

Thank you for reporting. Please follow the recommendations in issues #432 and #446 so that openjp2 is excluded from building for that platform. You can also try PR #449.

Hey I am kinda new to rust how can I use the version from your PR?

At your Cargo.toml:
[dependencies]
dicom = { git = "https://github.com/Enet4/dicom-rs", branch = "change/openjp2-opt" }

This also works when fetching individual crates.
See also: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories

Thanks a lot for the responses, I still get the same issue. Here is my build command
rustup target add
aarch64-linux-android
armv7-linux-androideabi
x86_64-linux-android
i686-linux-android
Build the android libraries in the jniLibs directory
cargo ndk -o $JNI_DIR
--manifest-path ../Cargo.toml
-t armeabi-v7a
-t arm64-v8a
-t x86
-t x86_64
build --release
and my environment is MacOS Sonoma 14.2.1, M2 CPU

@Enet4 Thanks a lot! I was able to solve the issue with the PR by updating the dicom-pixeldata dependency, which was still on the official version. Here's the updated Cargo.toml. This might be helpful for someone else who encounters the same problem.
``toml
dicom = { git = "https://github.com/Enet4/dicom-rs", branch = "change/openjp2-opt" }
dicom-pixeldata = { git = "https://github.com/Enet4/dicom-rs", branch = "change/openjp2-opt", default-features = false, features = [
"rayon",
"openjpeg-sys",
"image",
] }


[WIP] Add code coverage reports

@redapple any idea what's wrong with Scrapy spider test?

No idea, I was hoping you had seen that before

See https://github.com/scrapinghub/frontera/pull/166


Parsing queries with reused variable generates different queries than with distinct variables

I try to compare the following queries by parsing them to cypherdsl and rendering again
Query 1:
MATCH (this:Film:Multimedia)
CALL {
	WITH this
	MATCH (this_actors:Actor:Person)-[this0:ACTED_IN]->(this)
	WITH this_actors {
		.name
	} AS this_actors
	RETURN collect(this_actors) AS this_actors
}
RETURN this {
	.title,
	actors: this_actors
} AS this

Query 2:
MATCH (this:Film:Multimedia)
CALL {
	WITH this
	MATCH (actor0:Actor:Person)-[actedIn0:ACTED_IN]->(this)
	WITH actor0 {
		.name
	} AS actors
	RETURN collect(actors) AS actors
}
RETURN this {
	.title,
	actors: actors
} AS this

The normalized queries are:
Normalized query 1:
MATCH (v0:Film:Multimedia)
CALL {
  WITH v0
  MATCH (v1:Actor:Person)-[v2:ACTED_IN]->(v0)
  WITH v1 {
    .name
  } AS v3
  RETURN collect(v3) AS v4
}
RETURN v0 {
  .title,
  actors: v4
} AS v1

Normalized query 2:
MATCH (v0:Film:Multimedia)
CALL {
  WITH v0
  MATCH (v1:Actor:Person)-[v2:ACTED_IN]->(v0)
  WITH v1 {
    .name
  } AS v3
  RETURN collect(v3) AS v4
}
RETURN v0 {
  .title,
  actors: v4
} AS v3

Here is a diff view of everything:

As you can see for query 1 the result alias is v1 (which  is not an error itself), but the semantically equally query 2 parses to a different result alias v3.
To normalize the queries I use the following code:
val renderer = Renderer.getRenderer(Configuration.newConfig()
    .withPrettyPrint(true)
    .withGeneratedNames(true)
    .build())

renderer.render(CypherParser.parse(cypher, Options.newOptions()
    .createSortedMaps(true)
    .alwaysCreateRelationshipsLTR(true)
    .build()))

I won't be able to fix this I am afraid, without breaking tons of other things.

Please have a look at the last PR added to this branch… https://github.com/neo4j/cypher-dsl/tree/issue/does-itscope and test your thing with it. It fixes stuff, to truly keep queries semantically equal (reusing aliases, too). Please note that the queries above won't normalize the same as the former uses this_actors 3 times, but actors only 2 times. I can only track the aliases introduced, I am not doing a full semantic analysis here (and I won't).
See which tests I needed to touch, essentially all that uses this as a symbolic name at the start of the match and overwrite it with this {.something} as this in the end.
Stuff hunted me in my dreams last night, pls refrain from more issues today, need to get some rest ;)


PEAR-748: Add spinners when loading or redrawing can be slow or confusing [PART2]

Description
Default value as "..." when the venn diagram is loading in cohort comparison app.
Checklist

[ ] Added proper unit tests
[ ] Left proper TODO messages for any remaining tasks
[ ] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

weird. I see the "...", then the "0" flash real quick, then the final numbers in the venn diagram.

weird. I see the "...", then the "0" flash real quick, then the final numbers in the venn diagram.

It should be smoother now. I did a bit more changes.

seems to work now! I didn't spot the "0"! 👍


abnormal melanosome maturation

Add new term:
abnormal melanosome maturation
DEF: any anomaly in the developmental processes that are required for a melanosome to attain its fully functional state; melanosome maturation occurs through sequential stages (I-IV) that can be defined based on morphology and melanin content; stage I pre-melanosomes are roughly spherical, lack pigment, contain intraluminal vesicles, and resemble multivesicular bodies i.e. structures found along the endosomal pathway; stage II melanosomes are elongated (ellipsoidal) in shape, lack pigment, and contain intraluminal matrix fibers organized in a striated array; deposition of melanin along the matrix fibers begins in stage III melanosomes; stage IV melanosomes, corresponding to fully-melanized mature organelles, are characterized by a dense homogeneous deposit of melanin that covers all the internal structures of the matrix
SOURCE: PMID:16303920, PMID:12445206, https://books.google.gr/books?isbn=0080911951

Added new term:
abnormal melanosome maturation MP:0030915


M-FAC-like pruner crashes due to the GPUtil not seeing any GPUs

I am experimenting with M-FAC like BaseGradualPruningModifier and what I've Implemented is the class inheriting
from either MFACPruningModifier and ACDCPruningModifier which I've called ACDCMFACPruningModifier.
@PyTorchModifierYAML()
class ACDCMFACPruningModifier(ACDCBasePruningModifier, MFACPruningModifier):
   ....

I init the Modifier via the SparseML recipe:

  - !ACDCMFACPruningModifier
    compression_sparsity: 0.75
    start_epoch: 150
    end_epoch: 500
    update_frequency: 10
    params: ['re:(.*blocks.*.attn.qkv.weight)|(.*blocks.*.attn.proj.weight)|(.*blocks.*.mlp.fc.*weight)']
    mask_type: unstructured
    global_sparsity : True
    num_grads: 256
    fisher_block_size: 64

And for the long run, as in this recipe at the start of the compression stage training crashes on this step:
2022-03-27 21:37:34 sparseml.pytorch.sparsification.pruning.modifier_pruning_mfac INFO     Using Small Block Fast Fisher Inverse Implementation
Using Small Block Fast Fisher Inverse Implementation
...
File "/nfs/scistore14/alistgrp/dkuznede/miniconda3/envs/deep_learning/lib/python3.9/site-packages/sparseml/pytorch/sparsification/pruning/modifier_pruning_mfac.py", line 1506, in _get_free_gpu_memory
    return [gpus_all[idx].memoryFree for idx in gpu_idx]
  File "/nfs/scistore14/alistgrp/dkuznede/miniconda3/envs/deep_learning/lib/python3.9/site-packages/sparseml/pytorch/sparsification/pruning/modifier_pruning_mfac.py", line 1506, in <listcomp>
    return [gpus_all[idx].memoryFree for idx in gpu_idx]
IndexError: list index out of range

I've delved into the issue and found out, that at this step:
gpus_all = GPUtil.getGPUs()
returns empty list.
I've rerun the experiment with a short run with a few epochs.
start_epoch: 2
end_epoch: 8
update_frequency: 1

There were no any issues and the GPUtil returned the list of all GPUs available. Training finished normally.
The SparseML recipe is instantiated in the standard way:
manager = ScheduledModifierManager.from_yaml(args.sparseml_recipe)
# wrap optimizer
optimizer = manager.modify(model, optimizer, steps_per_epoch=len(loader_train))

Seems like it's some a hardware-like issue underhood. What could you suggest to look into?
I am working with the nightly release of SparseML.
Version of packages installed
sparseml-nightly              <IP_ADDRESS>20326
cudatoolkit               11.3.1               h2bc3f7f_2
GPUtil                        1.4.0
torch                         1.10.2
System
GPU - RTX3090
OS - Debian GNU/Linux 10 (buster)

Thank you @Godofnothing for the issue and details.
We will take a closer look and get back to you.
Best, Jeannie / Neural Magic

Hi @Godofnothing, the issue that's happening is the GPU utils package we're using is failing to return the proper info later in the runs. We haven't seen this issue before and are unsure of why this might be popping up. To enable a quick remedy we've put up the following diff to attempt to cache those results: https://github.com/neuralmagic/sparseml/pull/650. This will be landing shortly on main and will be pushed up to the next nightly if you'd like to see if that remedies the issues you're seeing.
Thanks,
Mark

Closed due to #650 landing which adds the proposed fix to the issue. Please reopen if any further issues are noticed.

@bfineran , @KSGulin thanks all for help!


Issue 53 spline segmentation export

Rescaled the spline segmentations to match the spacing of the original image (if this is anisotropic).
To correct the alignment, the 'Offset' attribute of MHD images was exposed in the MetaImage class. This is then set in the segmentation image metadata.

Lot of merge conflicts. Need to PR the base first, and then code the fix for issue #53


added app info command, with tests

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@purplecabbage I took the freedom to merge this so that I can reuse it in my POC pr, thanks !


Text input is not sanitized leading to massive XSS potential.

Fixed in https://github.com/Matt-Allen44/Quik/commit/91804771d9bea67b94015e93080534d3fc2de760

Fixed in https://github.com/Matt-Allen44/Quik/commit/91804771d9bea67b94015e93080534d3fc2de760


in multiscale heatmaps

why are you only plotting to 'n-1', instead of to 'n'?

there is a merge conflict in 'plot_simulation_heatmaps'
but i don't understand why you are not showing the last row/col of the heatmaps
i modified it in plot_panel5 to show up to n,
but i'm confused why you did that in the first place

fixing the heatmap screw.
Also I modified panel 5 back.
Because we are always showing scales from 2 to n, instead of 1 to n. (scale 1 will have zero correlation and power).
In code it is 1 to n-1, rather than 2 to n.

all fixed and synced.

i see.


attempt to index local 'version' (a userdata value)

I'm using neovim nightly build. It seems the version check you have done doesn't work in the 0.11 version. I think the error occurs because vim.version().build returns nil
lua =vim.version()

{
  api_compatible = 0,
  api_level = 12,
  api_prerelease = false,
  build = vim.NIL,
  major = 0,
  minor = 11,
  patch = 0,
  prerelease = "dev",
  <metatable> = {
    __eq = <function 1>,
    __index = <function 2>,
    __le = <function 3>,
    __lt = <function 4>,
    __newindex = <function 5>,
    __tostring = <function 6>
  }
}

vim.version.parse("v0.10.0")
{
  major = 0,
  minor = 10,
  patch = 0,
  <metatable> = {
    __eq = <function 1>,
    __index = <function 2>,
    __le = <function 3>,
    __lt = <function 4>,
    __newindex = <function 5>,
    __tostring = <function 6>
  }
}

The same error occurred also on neovim v0.10.0 from Arch repo

Thanks for reporting the issue!
I didn't think this would be changed. My bad.

I have removed the version check part. Can you check if the plugin works now?

Yeah it's now good on Arch

That's great 👍.
I will wait for confirmation from the other user before closing the issue.

Fixed


[SPARK-37206][BUILD][FOLLOWUP] Update avro to 1.11.0 in SparkBuild.scala

What changes were proposed in this pull request?
This is a follow-up of https://github.com/apache/spark/pull/34482 to update the Avro version consistently in both Maven and SBT.
Why are the changes needed?
Due to the mismatch, there occur some compilation failures in some systems.
$ build/mvn dependency:tree -pl core | grep avro
[INFO] +- org.apache.avro:avro:jar:1.11.0:compile
[INFO] +- org.apache.avro:avro-mapred:jar:1.11.0:compile
[INFO] |  \- org.apache.avro:avro-ipc:jar:1.11.0:compile

$ build/sbt "core/dependencyTree" | grep avro
[info]   +-org.apache.avro:avro-mapred:1.11.0
[info]   | +-org.apache.avro:avro-ipc:1.11.0
[info]   | | +-org.apache.avro:avro:1.10.2
[info]   +-org.apache.avro:avro:1.10.2

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually verified.

cc  @sarutak and @HyukjinKwon .

@dongjoon-hyun Nice catch! It LGTM, pending CIs.

Thank you, @sarutak .

@dongjoon-hyun I found extra 2 occurrence of 1.10.2.
https://github.com/apache/spark/blob/26e93f98636449643859fd6725e2c4343de2eb4c/connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala#L80
https://github.com/apache/spark/blob/master/connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala#L87
Should we fix them in this PR too?

Oh. Thank you! I'll include them too

It seems that the documentation is a little complicated. I found more.
$ git grep avro.apache.org
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala:   * See https://avro.apache.org/docs/1.10.2/spec.html#schema_record .
connector/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala:   * See Avro spec for details: https://avro.apache.org/docs/1.10.2/spec.html#schema_record .
docs/sql-data-sources-avro.md:Currently Spark supports reading all [primitive types](https://avro.apache.org/docs/1.10.2/spec.html#schema_primitive) and [complex types](https://avro.apache.org/docs/1.10.2/spec.html#schema_complex) under records of Avro.
docs/sql-data-sources-avro.md:It also supports reading the following Avro [logical types](https://avro.apache.org/docs/1.10.2/spec.html#Logical+Types):
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala:    // https://avro.apache.org/docs/1.8.1/spec.html#Logical+Types

If the links are still valid in 1.11.0, I'll update all of them.

Oh, I didn't notice them in docs. Thank you!

BTW, it might be better to note that we need to modify other occurrences of the version when we upgrade Avro.

Update docs and added note.

cc @gengliangwang too

Thank you, @HyukjinKwon , @gengliangwang , @sarutak (again)

Merged to master and branch-3.3

Thank you, @wangyum !


chore: update CODEOWNERS

That should reduce a bit of noise in notifications, people can still review each other's PR of course but won't get pinged for everything

Note: We can merge without CI tests since it's just a .md file here


Random code 3

Description
This pull request includes changes to two files: .github/PULL_REQUEST_TEMPLATE.md and src.js. Here's a summary of the changes:

.github/PULL_REQUEST_TEMPLATE.md:

Added a new file PULL_REQUEST_TEMPLATE.md.

src.js:

Modified the code in src.js to improve the dampen function.
Removed unnecessary code related to args, disp, and timeout.
Refactored the run function for better readability.
Updated the export statement.

Overall, these changes aim to enhance the functionality and readability of the dampen function. Please review the code and provide any feedback or testing instructions.

code-companion-ai pause


Full screen map: implement "subsetting mode" for when there is no overlay variable

Requires: https://github.com/VEuPathDB/web-components/issues/421
Extend the useMapMarkers hook to perform filtered and unfiltered calls to map-markers and construct DonutMarkers (cumulative mode) or ChartMarkers in the standard pink/grey colour scheme.
At some point there will be a legend with a radio selector for donut/chart markers.

No longer needed in SAM land


Added swagger extensions and good patterns document in this repo

Copied Swagger extensions doc from Autorest repo and good patterns from semantic rules in autorest repo

Hi @kirthik, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (kirthik). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

No modification for Ruby

No modification for NodeJS

No modification for Python


Native Chef Helpers functions duplicated as node methods

I don't understand why some of the native Chef helper functions [1] -- like def linux?, def macos?, def debian_family?, et al -- are being duplicated in fb_helpers, cpe_helpers.
Rather than extending the node object to contain functions already available to the Chef DSL, why not just use the built-in ones?
Frame number: 0/26

From: /etc/chef/local-mode-cache/cache/cookbooks/cpe_my_org_init/recipes/default.rb:17 Chef::Mixin::FromFile#from_file:

    12: # of patent rights can be found in the PATENTS file in the same directory.
    13: #
    14: require 'pry'
    15: binding.pry
    16: # Start an empty run_list so we can append to it
 => 17: run_list = []
    18:
    19: # All machines
    20: run_list += [
    21:   'global_base',
    22:   'my_org_base',

[1] pry(#<Chef::Recipe>)> show-method linux?

From: /opt/chef/embedded/lib/ruby/gems/3.0.0/gems/chef-utils-17.7.29/lib/chef-utils/dsl/os.rb:28:
Owner: ChefUtils::DSL::OS
Visibility: public
Signature: linux?(node=?)
Number of lines: 3

def linux?(node = __getnode)
  node["os"] == "linux"
end
[2] pry(#<Chef::Recipe>)> show-method node.linux?

From: /etc/chef/local-mode-cache/cache/cookbooks/fb_helpers/libraries/node_methods.rb:50:
Owner: Chef::Node
Visibility: public
Signature: linux?()
Number of lines: 3

def linux?
  self['os'] == 'linux'
end

Can anyone explain why this is necessary/beneficial?
[1] See: https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/os.rb & https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/platform.rb & https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/platform_family.rb

The darwin? one, for example, was added in 15.5:
https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/os.rb#L47
These predate nearly all of the built-in helper functions. We've just never
migrated because it didn't make a difference.
On Thu, Nov 4, 2021 at 7:35 AM Austin Culter @.***>
wrote:

I don't understand why some of the native Chef helper functions [1] --
like def linux?, def macos?, def debian_family?, et al -- are being
duplicated in fb_helpers, cpe_helpers.
Rather than extending the node object to contain functions already
available to the Chef DSL, why not just use the built-in ones?
Frame number: 0/26
From: /etc/chef/local-mode-cache/cache/cookbooks/cpe_my_org_init/recipes/default.rb:17 Chef::Mixin::FromFile#from_file:
12: # of patent rights can be found in the PATENTS file in the same directory.
13: #
14: require 'pry'
15: binding.pry
16: # Start an empty run_list so we can append to it

=> 17: run_list = []
18:
19: # All machines
20: run_list += [
21:   'global_base',
22:   'my_org_base',
[1] pry(#Chef::Recipe)> show-method linux?
From: /opt/chef/embedded/lib/ruby/gems/3.0.0/gems/chef-utils-17.7.29/lib/chef-utils/dsl/os.rb:28:
Owner: ChefUtils::DSL::OS
Visibility: public
Signature: linux?(node=?)
Number of lines: 3
def linux?(node = __getnode)
node["os"] == "linux"
end
[2] pry(#Chef::Recipe)> show-method node.linux?
From: /etc/chef/local-mode-cache/cache/cookbooks/fb_helpers/libraries/node_methods.rb:50:
Owner: Chef::Node
Visibility: public
Signature: linux?()
Number of lines: 3
def linux?
self['os'] == 'linux'
end
Can anyone explain why this is necessary/beneficial?
[1] See:
https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/os.rb
&
https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/platform.rb
&
https://github.com/chef/chef/blob/main/chef-utils/lib/chef-utils/dsl/platform_family.rb
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/facebook/IT-CPE/issues/265, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJFTX6VT4DYQ4LGDMT56MLUKKKZ7ANCNFSM5HLS6RBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Nick McSpadden
@.***

Would you entertain a PR to remove them? Or is your fleet of devices running pre-15.5 client versions and such a PR would break them?

We likely wouldn't accept that PR without pretty thorough testing in our
environment. I'd encourage you to put one up to kickstart the conversation,
but migrating that is also pretty low-pri unless there's a demonstrable
difference in performance/time - or some other indication of problem that
this is causing.
On Thu, Nov 4, 2021 at 8:51 AM Austin Culter @.***>
wrote:

Would you entertain a PR to remove them? Or is your fleet of devices
running pre-15.5 client versions and such a PR would break them?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/IT-CPE/issues/265#issuecomment-961176396,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJFTX3H6EKZXKBSUL5TRLDUKKTZVANCNFSM5HLS6RBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Nick McSpadden
@.***

We likely wouldn't accept that PR without pretty thorough testing in our environment. I'd encourage you to put one up to kickstart the conversation, but migrating that is also pretty low-pri unless there's a demonstrable difference in performance/time - or some other indication of problem that this is causing.
…
On Thu, Nov 4, 2021 at 8:51 AM Austin Culter @.> wrote: Would you entertain a PR to remove them? Or is your fleet of devices running pre-15.5 client versions and such a PR would break them? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#265 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFTX3H6EKZXKBSUL5TRLDUKKTZVANCNFSM5HLS6RBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- -- Nick McSpadden @.

PR opened. Let me know if you have any concerns or discover any issues when you get around to testing internally.

Yesterday I discovered namespace collisions breaking a lot of our linux logic. https://github.com/facebook/chef-cookbooks/issues/211


Enhancing "install" goal to use packaged zips on the DHE maven repo

The Liberty Maven plugin should have a task to install (unzip) the liberty zip freemium editions currently located on the DHE maven repo, and eventually on maven central.

This is now supported via #48.


Set hostname on podman/docker run command line

The container hostname is embedded in the generated API certificate. Using
a known hostname (like "microshift") allows the developer to expose the API
at different addresses without invalidating the certificate by placing an
appropriate entry in /etc/hosts or equivalent.

@larsks I can see this as a "how-to" instead, where you'd include adding the entry in /etc/hosts, a bit about why (valid certificates) and a typical use-case for doing this. It would be a file here: https://github.com/redhat-et/microshift-documentation/tree/main/content/en/docs/user-documentation/how-tos
@fzdarsky wdyt?

@sallyom Why not just include this as part of the default instructions? It's not as if it substantially changes the complexity of the existing command line, and it means the generated certificate is immediately more useful. I'm not sure I understand the argument against making the change.


change work channel buffer

fix work channel block
If ctx done

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @zzhzero
Thanks for the pull request. However, I believe this would introduce a breaking change to the platform, unless you can provide more of an explanation on why this change was necessary and some unit tests. I will close for now, but feel free to raise again if you want to do the above.
Cheers,
Eoin


Getting "No component factory" error while opening a Material Dialog in lazy loaded Component

Hi,
Im getting the following error when i try to open Material Dialog in ConfirmBoxComponent.

No component factory found for ConfirmBoxComponent. Did you add it to @NgModule.entryComponents?

I have already added ConfirmBoxComponent in entryComponents list
    declarations: [
      ConfirmBoxComponent
    ],
    exports: [ConfirmBoxComponent],
    entryComponents: [
      ConfirmBoxComponent
    ],

The module that contain ConfirmBoxComponent is loaded via Lazy loading technique.
I'm not sure this is  bug or not.
I'm using latest version of Angular and Material
   "@angular/core": "^5.0.0",
  "@angular/material": "^5.0.0-rc0"

Have you checked #1491?

Ya . But its not working for me .
I have  added component for md-dialog in entry components of my lazy loaded Module. But i'm getting that error.

Can you please share your entire NgModule setup?

Hi, check now
https://gist.github.com/nithindan/f1a027e4b8589c59af9ec763b0ffded8

@jelbourn Is there any way to fix this ?

You need to import MatDialogModule in ConsumerModule in order for it to know about the entryComponents there

thanks a lot @jelbourn . it worked <3

Is this still the solution for this issue? Or has something else changed as of late?
I can't seam to get this to work, this is basically the exact same setup I got, but only getting:
No component factory found for LoginDialogComponent

In regards to Angular v6+: in case anyone is using the MatDialog service inside another injectable service and is using the { providedIn: 'root' } option for that service, you'll need to instead provide that service in the providers array of the module where your dialog components are declared.

@travtarr thanks so much for the answer.... I had that exact same issue.
Plus it also only started working after i killed off ng serve
In short: If you the service building your component is only provided in root, be sure to also provide it in the lazy loaded module!
Why does that need to be like this though?

@travtarr  "you'll need to instead provide that service in the providers array of the module where your dialog components are declared." this will declare a new instance of the service so it's not possible to have a singleton in the app to launch dialog ?

@jingignoli I didn't clarify in my original post, but you'll want to remove the providedIn: 'root' when you provide it in a module.

Thanks for your answer but the service will be scoped to the module.
I need a singleton in my app to control my modals.

@jingignoli Then you'll probably need to place your modal declarations in a non-lazy-loaded module to avoid this issue.

@jingignoli have you addressed this issue? I have same issue as yours :(

@min-w-park no i haven't created an issue for this, i don't know if it's a bug or a normal behavior.

I have the same question about it，When I open lazyload module.


HREF with reference.content_path in UsageView doesn't do anything

Issue Summary
In the UsageView for a Page or Snippet, the Field column displays a list of fields containing a reference to that object. In references_cell.html, each reference is wrapped in a link to that object's edit view, appended with #content-path-{{ reference.content_path }}. This appears to be meant as a way to jump to that specific field when opening the edit page, but no such ids are present on the elements and so they don't do anything - each link just opens the edit page from the top content, as usual.

Steps to Reproduce

From the edit view for a Page or Snippet, click on the "i" Status icon in the top right and then go to the Usage page (provided there is at least one occurrence)

From the Usage page, click any example under the field column to go to the edit page for that item.

The url for the edit page will end in something like edit/#content-path-body_streamfield.85af2509-0a67-4848-9808-b5f432492258, but no such id exists on the page.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project:

Yes. Confirmed on a new install of Bakery demo.

Technical details

Python version: 3.11.3
Django version: 5.0.3
Wagtail version: 6.1.2
Browser version: Chrome on Mac v125.0.6422.142

Working on this

Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.

Confirmed. For StreamField block references, for example, the ref path is something like
content-path-body.81e913c4-b95b-4cae-8b91-326fff250bb1 whereas the block id is block-81e913c4-b95b-4cae-8b91-326fff250bb1-section.
For regular fields, ref is something the id in the editor is content-path-FIELDNAME

This is a tricky problem, because the panel IDs we have in the HTML are generated differently for different BoundPanels:
https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/wagtail/admin/templates/wagtailadmin/shared/panel.html#L19-L20
https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/wagtail/admin/templates/wagtailadmin/panels/object_list.html#L8-L10
https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/wagtail/admin/panels/group.py#L101-L106
https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/wagtail/admin/panels/inline_panel.py#L108-L113
https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/wagtail/blocks/struct_block.py#L350-L352
https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/client/src/components/StreamField/blocks/BaseSequenceBlock.js#L134-L136
The reference index stores a "content path" to the reference in a given model instance, which is unrelated to how the string for the panel ID is generated. To fix this issue, we need to either:

Calculate the correct ID to use as the anchor when linking to the reference

I don't think this is possible without traversing the panel tree and following the same code path as how the panel IDs are generated, which can be too complex given that we may be dealing with different model instances when rendering the "Usage" view.
Some of the logic for generating the ID exists in client-side code for stuff like StreamField blocks, which aren't fully rendered by the server (they are partially rendered by the client). This is shown in the BaseSequenceBlock.js snippet above.
Some inputs don't have a <section> element, e.g. a field in a MultiFieldPanel.

Instead of relying on the link to point to the correct ID for the panel, use a smarter (or possibly fuzzy) logic on the client to find the closest panel based on the content path of the reference index. I think all fields have a corresponding data-contentpath attribute where the value is the part that makes up the full content path for the reference index.

For example, the content path of the reference index may be something like body.df102372-cd23-463c-b594-29b224bd409e.725285ae-b823-404e-8439-f5ebe3b48b31.text. We can make use of the data-contentpath attribute, I think we can target the appropriate element by using the following selector:'[data-contentpath="body"] [data-contentpath="df102372-cd23-463c-b594-29b224bd409e"] [data-contentpath="725285ae-b823-404e-8439-f5ebe3b48b31"] [data-contentpath="text"]'

I believe this was the original intention in https://github.com/wagtail/wagtail/blob/49ef72725a96d8102e970c86416310248074b5cc/wagtail/admin/templates/wagtailadmin/tables/references_cell.html#L6 but of course it didn't work because you can't use data attributes for # anchors, so this needs some additional logic in the JS.


Update go.mod + go.sum

Signed-off-by: Maxime Soulé<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 207

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.686%

Totals

Change from base Build 205:
0.0%

Covered Lines:
4448

Relevant Lines:
4462

💛  - Coveralls