Wrapped php-http/cache-plugin option blacklisted_paths

Added option for a list of regular expressions to match paths not to be cached.

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
yes

Deprecations?
no

Related tickets
-

Documentation
https://github.com/php-http/documentation/commit/f04eb3b549a8b78d6abab9bac7297139622ac8e1

License
MIT

What's in this PR?
Adding blacklisted_paths option of cache plugin
Why?
New option.
Example Usage
httplug:
    cache:
        config:
            blacklisted_paths: ['\/path\/not-to-be\/cached']

Checklist

[X] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
[-] Documentation pull request created (if not simply a bugfix) - Already done: https://github.com/php-http/documentation/commit/f04eb3b549a8b78d6abab9bac7297139622ac8e1

thanks! i will wait with merging until we tag a release of the cache plugin.

Could you also update composer.json in require dev to fetch cache-plugin 1.7? (We will soon release that version)


Move to Go modules

The commits in this PR should move us to go modules.
These changes require go 1.14+ as they assume the presence of a vendor folder at the top level of a module will be used by default, without requiring the -mod=vendor flag. (This means we don't have to augment any of the flags we use when building.)
Future improvements should be made around our go tools as they get installed into the default $GOPATH/bin directory ($HOME/go/bin by default). These tools should really be installed to a location within the build tree and our scripts should be updated to explicitly reference the install location instead of relying on the $PATH.
Note to reviewers: I recommend reviewing commit by commit. The largest number of changes are in the first commit where dep was replaced with modules as it changed a fair bit of the vendored code by pulling in files that were excluded by dep and other miscellaneous things.

I opened FAB-17735 as a follow on to do the tools work

will wait for someone from docs to review as well over the next day.  if not, will merge

This makes me happy!

Docs look good. We should update the prerequisites page here in a follow on PR: https://hyperledger-fabric.readthedocs.io/en/latest/prereqs.html#go-programming-language

Docs look good. We should update the prerequisites page here in a follow on PR: https://hyperledger-fabric.readthedocs.io/en/latest/prereqs.html#go-programming-language

Agreed; however, I believe that article should be focused on the requirements for app and chaincode development instead of "Fabric" development. While there is some overlap. they are distinct roles and the requirements differ quite a bit.
For the "Go" section, in particular, Go 1.14 is not needed for chaincode development and GOPATH or not is really up to the chaincode developer. This was the gist of the offline discussion I initiated last week.
@nikhil550, are you (docs experts) going to make the updates to the "prereqs" page that is part of "getting started" or is that something you need me to draft?
Thanks.


Unable to choose identity card.

hi,
i am not able to choose identity card.
Only getting option Driver's License.
Sdk version: 3.0.3

Hello @applesubir please update version to 3.1.0

when I am pod install with version 3.1.0
[!] CocoaPods could not find compatible versions for pod "Mati-Global-ID-SDK":
In Podfile:
Mati-Global-ID-SDK (~> 3.1.0)
None of your spec sources contain a spec satisfying the dependency: Mati-Global-ID-SDK (~> 3.1.0).
You have either:

out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
mistyped the name or version.
not added the source repo that hosts the Podspec to your Podfile.

Please tell me what I do

@applesubir Hello, please try latest version 3.2.1


[openebs/openebs] Update OpenEBS charts instructions

Updated README
Updated Helm repo location

Signed-off-by: Murat Karslioglu<EMAIL_ADDRESS>Special notes for your reviewer:
Due to the deprecation and obsoletion plan of the Helm charts repository this chart has been moved to a new repository. Added additional step to add openebs/openebs chart repo. Updated instructions to use openebs/openebs repository.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Title of the PR starts with chart name (e.g. [openebs/openebs])

@muratkars we have to bump the version in Chart.yaml file.

@muratkars we have to bump the version in Chart.yaml file.
@prateekpandey14 Bumped the version number to 1.11.1.


[FEATURE] Search Stamps 🟠

Problem
Cannot currently search stamps
User Story(s):
As a _______, I want to ____, so that I can
Description
Description of solution
Acceptance Criteria

[x] search stamps by name
[x] search stamps by deploers

Limitations
Outline any potential limitations
Resources

outline links and relevant resources, references implementations

It's currently searching by contract's name, contract's address and by contract's deployer


Create and list the aliases

Example with use
rhc.alias.list('MyId', function(err, list){

});

rhc.alias.list('MyId', {
   id : 'is.example.com'
},function(err, result){

});

Thanks @alejonext - I built on what you'd done here
https://github.com/feedhenry/rhcjs/commit/e03a47727d2f1f5e1e285a263e8136f1ec3118d8
and added acceptance tests, unit tests, docs, and a remove function.
The API signature has changed a little - sorry - just wanted to keep it consistent with our other function calls.

Published
+<EMAIL_ADDRESS>

Ok!!! :)


feat: Expose protocol warnings through the HTTP API

Overview
The HTTP API should be able to convey nonfatal protocol warnings, like if the user uses a deprecated Protocol API method or otherwise does something questionable.
The old ticket #3535 tracked this same feature request for our obsolete RPC system. The old ticket #3536 is still around to track the app-side work.
Implementation details
TBD!
Design
TBD!
Acceptance criteria
TBD!

Not prioritized. If/when this is prioritized, it will be on Jira.


Popup duplicate stacking

About the PR

Makes duplicate popups stack on top of each other and add a x# at the end.
I didn't check super hard that it doesn't combine with another popup, but it should be ok, since all the values provided to popup are compared.
Why / Balance

This makes it possible to see what the message is when popups are spammed.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

https://github.com/space-wizards/space-station-14/assets/10494922/381c0b20-a0d8-4804-8721-e6c25086137e
Breaking changes

Changelog

:cl:

tweak: Popups with the same message now stack together and append a x# to the end.

Holy sheet, we need this cjhat too! Nice pr


Ars Nouveau & RFTools can break the bedrock ores

If you use a break+amplify spell from Ars Nouveau for mining harder materials, the bedrock ores are destroyed, opening a path to the void. If you use a RFTools Builder (RFTools Utility mod) with a (clearing) quarry card, it always break the bedrock ores completely and somehow you get the resources.
Not sure if this is something you can fix easily, but thought I'd report anyways
dadobugbedrockores-1.3.5-forge.jar on Forge 40.1.20 for Minecraft 1.18.2

This is also the case for Create mechanical drill, using same version of bedrock ores, forge and minecraft version as above.

I am unable to fix these issues myself, but I have put issues on all of these mods issue trackers. If/when they add in compatibility, I will push an update to curseforge and comment here.

Ars Nouveau & RFTools have been fixed.
RFTools self-patched
Ars Nouveau accepted pull request
Create is tracked in #6
Closing issue, yay!

Thanks! :D


Feature/dem 805/implement samepling rate float parameter

Changes proposed in this pull request:

Set and Get the sampling rate of the ZIUHFLI using float.

@WilliamHPNielsen @jenshnielsen @astafan8

@astafan8 I addressed the your comments except the one with self.scope_samplingrate_float._save_val(ZIUHFLI._convert_to_float(nearest_frequency)) as it was left with a question mark. Should I do it?

@WilliamHPNielsen I very well see your point and I'm not going to try and convince you. This behavior of setting the nearest point is how it works in the m4i driver, so there was a request for it in the uhfli driver as well.
But having the option of excepting and returning the sampling rate as float would still be very handy to have in many cases. So what if I make the "nearest" frequency a static method that finds the nearest allowed frequency, given some floating point number, that can in turn be used to set the sampling frequency? Something like:
sampling_rate = ZIUHFLI.round_to_nearest_sampling_frequency(desired_sampling_rate)
uhfli.scope_samplingrate_float(sampling_rate)

?

@qSaevar I think what you propose with
sampling_rate = ZIUHFLI.round_to_nearest_sampling_frequency(desired_sampling_rate)
uhfli.scope_samplingrate_float(sampling_rate)

is a nice and clean solution.
Then the scope_samplingrate_float parameter can have an Enum validator only accepting the correct values, and the round_to_nearest_sampling_frequency method should then take care not to introduce floating-point errors, but that should not be too hard to implement.

@WilliamHPNielsen I updated the PR so now the scope_samplingrate_float parameter only accepts sampling rates that are allowed by the device. There is also a helping method that returns the closest sampling rate from some desired value and it is no longer linear as before.

Looks terrific!


Add hot reload to web process

Add hot reload to web process so we don't need to refresh the page every single time we modify front-end files.

As we are using webpack-dev-server during development, we already have live reload enabled and for now it's probably sufficient for us.


Error when uploading alexa-app to aws lamba

Hi,
I am trying to create a basic alexa-app and upload the zip file to lambda.
I have used generator-lambda to create a basic skeleton.
This is the error I keep on getting
{
  "errorMessage": "Cannot read property 'new' of undefined",
  "errorType": "TypeError",
  "stackTrace": [
    "new alexa.request (/var/task/node_modules/alexa-app/index.js:149:29)",
    "/var/task/node_modules/alexa-app/index.js:227:21",
    "tryCatcher (/var/task/node_modules/alexa-app/node_modules/bluebird/js/main/util.js:26:23)",
    "Promise._resolveFromResolver (/var/task/node_modules/alexa-app/node_modules/bluebird/js/main/promise.js:480:31)",
    "new Promise (/var/task/node_modules/alexa-app/node_modules/bluebird/js/main/promise.js:70:37)",
    "request (/var/task/node_modules/alexa-app/index.js:226:12)",
    "handler (/var/task/node_modules/alexa-app/index.js:357:10)"
  ]
}

Try your skill out anyways. I find that the error only occurs on upload and testing in Lambda, but the skill itself works just fine. :/

That is likely because you haven't changed the Test payload in Lambda. The default one is not an Alexa payload. You can change it to a simple LaunchRequest or something as a good way to sanity check that the uploaded codeworks.

Closing this, please let us know if you're still having issues @siddhartha-lahiri.

@dblock I got this error.
I have an app uploaded to Lambda.
The error is caused on getting AudioPlayer events. I got it twise: one for AudioPlayer.PlaybackStarted and one for AudioPlayer.PlaybackFinished I suppose.
{
    "errorMessage": "Cannot read property 'new' of undefined",
    "errorType": "TypeError",
    "stackTrace": [
        "new alexa.request (/var/task/node_modules/alexa-app/index.js:219:27)",
        "/var/task/node_modules/alexa-app/index.js:317:18",
        "tryCatcher (/var/task/node_modules/alexa-app/node_modules/bluebird/js/main/util.js:26:23)",
        "Promise._resolveFromResolver (/var/task/node_modules/alexa-app/node_modules/bluebird/js/main/promise.js:483:31)",
        "new Promise (/var/task/node_modules/alexa-app/node_modules/bluebird/js/main/promise.js:71:37)",
        "request (/var/task/node_modules/alexa-app/index.js:316:10)",
        "handler (/var/task/node_modules/alexa-app/index.js:448:8)"
    ]
}

Maybe ^^^ should go into that PR. It's by no means finished, seems like you're hitting issues from that?


Ability to abort installation of an extension

As of now, Vs Code lacks the ability to cancel an installation once you have clicked the "install" button. This can be quite frustrating, especially when the extension takes a significant amount of time to install, only for you to realize later that it is not the extension you wanted or that it hasn't been updated in years. Having the option to cancel installations would greatly benefit many users and alleviate this annoyance.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Picking works through the Earth

Rotate this demo to place the object on the back side of the globe.  The object is large, mostly to prevent it being culled while on the back, but this also makes it very easy to "guess" where the object might be on the opposite side of the globe.  Picking this object works even when it's on the other side.  Sometimes it takes a few tries.
Reported by @GatorScott.
Live demo
Code:
var czml = [{
    "id" : "document",
    "name" : "Basic CZML billboard and label",
    "version" : "1.0"
}, {
    "id" : "some-unique-id",
    "name" : "AGI",
    "description" : "
Analytical Graphics, Inc. (AGI) founded Cesium.
",
    "billboard" : {
        "image" : "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAAXNSR0IArs4c6QAAAARnQU1BAACxjwv8YQUAAAAJcEhZcwAADsMAAA7DAcdvqGQAAACvSURBVDhPrZDRDcMgDAU9GqN0lIzijw6SUbJJygUeNQgSqepJTyHG91LVVpwDdfxM3T9TSl1EXZvDwii471fivK73cBFFQNTT/d2KoGpfGOpSIkhUpgUMxq9DFEsWv4IXhlyCnhBFnZcFEEuYqbiUlNwWgMTdrZ3JbQFoEVG53rd8ztG9aPJMnBUQf/VFraBJeWnLS0RfjbKyLJA8FkT5seDYS1Qwyv8t0B/5C2ZmH2/eTGNNBgMmAAAAAElFTkSuQmCC",
        "scale" : 10
    },
    "label" : {
        "fillColor" : {
            "rgba" : [255, 255, 255, 255]
        },
        "font" : "12pt Lucida Console",
        "horizontalOrigin" : "LEFT",
        "pixelOffset" : {
            "cartesian2" : [8, 0]
        },
        "style" : "FILL",
        "text" : "This is a really long label that takes a whole lot of space.",
        "showBackground" : true,
        "backgroundColor" : {
            "rgba" : [112, 89, 57, 200]
        }
    },
    "position" : {
        "cartesian":[
            1216361.4096947117, -4736253.175342511, 4081267.4865667094
        ]
    }
}];

var viewer = new Cesium.Viewer('cesiumContainer');
viewer.dataSources.add(Cesium.CzmlDataSource.load(czml));

Duplicate #4290


ARM Support?

It's good to see .Net Core mature into the platform it's becoming, but I miss one small feature from the roadmap - ARM support. This one little thing could mean that over 2 billion devices could receive .Net goodness  in the near future.
I suppose this could fall under the "broader Linux distro support" part, but I think it would be important to get .Net Core up and running on ARM devices too.

+1

Totally agree. Our daily builds https://github.com/dotnet/core-setup/blob/master/README.md . It's still early but it is starting to come up. I can't speak to the quality of the builds yet. Happy to have community help on that effort as well.

Howdy @Petermarcu @fonix232  i realize this is closed but you guys need ondemand build servers, we can offer  up (via Packet.net) our 96-core ARMv8 to anyone in the community.


ANCM Event log entry missing commit SHA

I'm guessing this is an artifact of moving to AzDo.
Log Name:      Application
Source:        IIS AspNetCore Module V2
Date:          4/5/2019 2:16:33 PM
Event ID:      1027
Task Category: None
Level:         Error
Keywords:      Classic
User:          N/A
Computer:      SOSHIR-DESK2
Description:
Unable to locate application dependencies. Ensure that the versions of Microsoft.NetCore.App and Microsoft.AspNetCore.App targeted by the application are installed.
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="IIS AspNetCore Module V2" />
    <EventID Qualifiers="0">1027</EventID>
    <Level>2</Level>
    <Task>0</Task>
    <Keywords>0x80000000000000</Keywords>
    <TimeCreated SystemTime="2019-04-05T21:16:33.275299700Z" />
    <EventRecordID>178114</EventRecordID>
    <Channel>Application</Channel>
    <Computer>SOSHIR-DESK2</Computer>
    <Security />
  </System>
  <EventData>
    <Data>Unable to locate application dependencies. Ensure that the versions of Microsoft.NetCore.App and Microsoft.AspNetCore.App targeted by the application are installed.</Data>
    <Data>Process Id: 11408.</Data>
    <Data>File Version: 13.0.19094.0. Description: IIS ASP.NET Core Module V2. Commit: </Data>
  </EventData>
</Event>

@jkotalik was feeling like he didn't have much to do in preview 5 so he's going to take a look :).

I'll take a glance.

The native dll is just missing the commit hash.


Have not implemented fetching 'recommendations' from Yahoo API

CODE:
import yfinance as yf)
tsla = yf.Ticker('TSLA'))
recommendations = tsla.get_recommendations())
print(recommendations)
ERROR:
yfinance.exceptions.YFNotImplementedError: Have not implemented fetching 'recommendations' from Yahoo API

It seems that the 'recommendations' feature is not currently implemented in the yfinance library for fetching data from the Yahoo API. The error you encountered indicates that this specific functionality is not available.
To work around this issue, you can try using other libraries or APIs that provide recommendations data for stocks. Some popular alternatives include Alpha Vantage, Finnhub, or using a financial data provider such as Bloomberg Terminal or Refinitiv Eikon.
Here's an example of using the Alpha Vantage API to fetch stock recommendations for Tesla (TSLA):
import requests
API_KEY = 'YOUR_ALPHA_VANTAGE_API_KEY'
symbol = 'TSLA'
url = f'https://www.alphavantage.co/query?function=OVERVIEW&symbol={symbol}&apikey={API_KEY}'
response = requests.get(url)
data = response.json()
if 'RecommendationKey' in data:
recommendation = data['RecommendationKey']
print(f"Recommendation for {symbol}: {recommendation}")
else:
print("Recommendation data not available.")

Thanks for the code, but this url does return recommendations for me. According to https://www.alphavantage.co/documentation/#company-overview, function=OVERVIEW response does not include analyst recommendations. My API KEY appears to work okay. Do you maybe have a higher-level service/subscription??

Yes sir I do, what do you want to achieve so I scale, and see my availability for your project

Ooops! I omitted a NOT from my comment above, rendering it incoherent. I apologize. Edited it to now say:
'...this url does NOT return recommendations for me.'
My question about your possible subscription to AlfaVantage was just to determine whether that could be the reason that you get more information than I do from that url.
Thanks for your patience.

AlphaVantage has changed its web services availability at some point in the last week of 2023-06. "Sustainability" is currently no longer available. Please check on https://www.alphavantage.co/ the current documentation.

Any movement on this?
yfinance version = 1.3.5
Still getting
yfinance.exceptions.YFNotImplementedError: Have not implemented fetching 'recommendations' from Yahoo API

Yeah, that would be really nice. I'm using version 0.2.28 from Anaconda repository and still getting not implemented exception.

With a little bit of research, it seems that Yahoo Finance has cut off the API for sustainability and recommendations. I think we're going to have to find another way to scrape it.

@AustinBrownLaw That's hard to believe. Normally the Yahoo webpage fetches data from API. A quick browser inspection shows me the API for ESG scores.

@AustinBrownLaw That's hard to believe. Normally the Yahoo webpage fetches data from API. A quick browser inspection shows me the API for ESG scores.

I have to admit that I'm pretty new at this--I'm coming from doing more straightforward stats on my own data--but I'm not finding sustainability. When I inspect the site, I'm seeing nothing but formatting around the score written as a float.

Firefox -> F12 -> Network -> F5. It isn't hard, just takes time.

Fixed and done at #1754
@ValueRaider close it please


Typo "Jupyter notebook"→"Jupyter Notebook"

https://docs.microsoft.com/en-us/azure/notebooks/quickstart-clone-jupyter-notebook

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Note that the product name is Jupyter Notebook. Referring to multiple instances of the product would seem to be "Jupyter Notebook files" or similar. Although the organization refers both to "a Jupyter Notebook," "Jupyter notebooks," and "Jupyter Notebooks" on its website.

This topic is no longer present in the docs. #please-close


JustReleased misbehavior on Ubuntu family

Hey, guys. I've been surprised to find out that it has been a two years (wew) since I first encountered this issue, back then we've discussed it on gitter and unfortunately nothing came out of it, I've poked around for some time but was unable to resolve it on my own.
Since then I've change several workstations and Ubuntu 18 has been released, I thought I might try again, but unfortunately the issue is still there and it's really upsetting.
To summarize the problem: whenever keyboard button goes through Press/Release state, right after Release it repeats the Press/Release cycle.
I've recorded a short video to demonstrate the problem, running latest adventure demo: https://webm.xyz/webm/5ae7009561f4bc000f1671f8
With this behavior it's impossible to make any sort of keyboard controls.
Also the following scenario doesn't work at all:
LeftButton is pressed -> we move left.
RightButton is pressed while LeftButton is pressed -> we move right
RightButton is released while LeftButton is pressed -> we should back to moving left, but we stop.
When I first encountered this issue I had an Arch machine around and I was not able to reproduce this issue there. The issue persisted through 16, 17 and now 18 Ubuntu versions.
I wasn't able to find anything in the issue tracker related to this problem and it makes me wonder whether I'm the sole Ubuntu user, which seems to be unlikely. But anyways I would really appreciate any tips that might shed light on this problem.
Thanks a lot!

Hello @nvma! I've got a fix that works for me here https://github.com/EngoEngine/engo/tree/just-released-bug if you want to check it out

@Noofbiz hey, sorry that couldn't react earlier. Unfortunately no impact on my end running the latest adventure demo.
Would you please tell me what happens on your machine when you press, say, 'D' for a ten or so seconds, when the character has already reached the edge of the world, and then release it? Does animation immediately stop?
Because for me, the longer you keep the button in pressed state, the longer it will be 'pressed' again after I release it.

It appears to be a bug with glfw itself and is present in the C version as well [here] (https://github.com/glfw/glfw/issues/747). Looks like the fix is actually in, but is in glfw 3.3, which is currently in beta. I've got an issue here #531 to upgrade to it when it's ready. That should fix this issue. Thanks for your help and reporting!

@Noofbiz thank you so much for sorting this through! On a glfw related note, every time I'm trying to launch an Engo program I get the following message in a terminal
 🔥 adventure git:  go run adventure.go
# github.com/nvma/adventure/vendor/github.com/go-gl/glfw/v3.1/glfw
In file included from glfw_linux_joystick.c:2:0:
glfw/src/linux_joystick.c: In function ‘_glfwInitJoysticks’:
glfw/src/linux_joystick.c:239:46: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 9 [-Wformat-truncation=]
             snprintf(path, sizeof(path), "%s/%s", dirname, entry->d_name);
                                              ^~
In file included from /usr/include/stdio.h:862:0,
                 from /usr/include/X11/Xcursor/Xcursor.h:26,
                 from glfw/src/x11_platform.h:38,
                 from glfw/src/internal.h:89,
                 from glfw/src/linux_joystick.c:28,
                 from glfw_linux_joystick.c:2:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 12 and 267 bytes into a destination of size 20
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It then hangs for a about a minute before actually starting up. I've tried to google it up, but without much success. Curious of its origin, might be related?

Yeah, this happens to me to. It used to say to report it to go-gl but that's been fixed. As for hanging for a bit, mine hung the very first time I ran it after a fresh install for a couple minutes but after that it only took a few seconds to build after the first build.

Any time frame on 3.3? Alternatively could a 3.2.2 release be made? Right now glfw is not that useful on Fedora Linux due to the phantom key presses.

Fixed by #700 ^_^


Remote Jupyter Server Ignoring jupyter.notebookFileRoot VS Code Setting

Environment data

VS Code version: 1.63.2
Jupyter Extension version (available under the Extensions sidebar): v2021.11.1001550889
Python Extension version (available under the Extensions sidebar): v2022.1.5
OS (Windows | Mac | Linux distro) and version: Ubuntu 18.04.6 LTS
Python and/or Anaconda version: conda 4.11.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Jupyter server running: Local | Remote | Remove

Expected behaviour
Using Azure ML, I create to a new compute instance. I then connect to the compute instance via VS Code.
I set jupyter.notebookFileRoot = ${fileDirname} in all contexts: User, Remote and Workspace.
I expect that when I run !pwd in a cell in a Jupyter notebook for it to return the current directory that the notebook is running in.

/mnt/batch/tasks/shared/LS_root/mounts/clusters/my-compute/code/Users/OWilkins/azure-ml-project/notebooks/

Actual behaviour
Running !pwd instead prints this directory:

/mnt/batch/tasks/shared/LS_root/mounts/clusters/my-compute/code

Steps to reproduce:

Using Azure ML, create a new compute instance.
Connect to the compute instance via VS Code.
Inside the Settings UI set the jupyter.notebookFileRoot setting to ${fileDirname} for User, Remote and Workspace.
Create a directory inside your user folder called: azure-ml-project. Your file structure will most likely look something like this:

code
  Users
    your-username
      azure-ml-project

Create a notebook inside azure-ml-project.
Inside that notebook, run: !pwd.

I understand that this may be something specific to Azure ML and may be outside the remit of this repository but I am at a loss! Any help would be greatly appreciated!

We setup the working directory only if the Jupyter URI is localhost or if we start a local kernel.
Based on what I know with AML its a jupyter server on the remote machine and we're connecting to it via the AML proxy server.
We might have to put in some special casing code just for the AML scenario as we cannot rely on localhost or the like to determine whether its a locally running Jupyter Uri or not.
Suggestion:

If is AML
If running remote VS Code
Then set CWD

I expect that when I run !pwd in a cell in a Jupyter notebook for it to return the current directory that the notebook is running in.

@okwilkins
Currently this works as expected without jupyter.notebookFileRoot = ${fileDirname}.
i.e. please remove the setting and it should work.
If not, please:

Provide the output from the Jupyter output panel
Please provide the output for the cell !pwd

Thanks for coming back to me!

Currently this works as expected without jupyter.notebookFileRoot = ${fileDirname}.

Forgive my ignorance if I am missing something here, but isn't ${fileDirname} the default value for jupyter.notebookFileRoot?
It's also my understanding that ${fileDirname} should return the directory that the notebook resides in.
This is what I am wanting to happen.

i.e. please remove the setting and it should work.

Removing the setting does not change the behaviour, unfortunately!

I investigated this a bit further and the problem only occurs when I connect to Jupyter via: Azure ML compute instance.
It works fine when connecting to localhost (the first option).

Note: When it says start a server on localhost, this is all happening on the compute:

This is what this cell outputs when I connect via Azure ML compute instance:

Thanks for bringing this to our attention @okwilkins -- I can elaborate on the problem a bit.
I'm assuming you're connecting to the compute instance from the Azure ML Studio? The bottom-left of the screenshots you sent show "Azure ML: owilkins-low-cost" as the resource indicator meaning that you're connected to your compute instance through a remote VS Code window.
Within this window, all components (terminal, Jupyter server, debugger, extensions) are in the "remote" context. This means that when you connect to the "Default" Jupyter server, you're connecting to a Jupyter server running on the compute instance. The Jupyter extension behaves as expected and understands the Notebook as it is on the compute -- this is why when you !pwd you're seeing the right path (cloudfiles/code/Users//azure-ml-project/notebooks).
The "Azure ML Compute Instance" option in the Jupyter server selector was meant to allow users to connect to their compute instances from their local Notebooks. Only the notebook, not the VS Code window, is connected to the remote compute. When the Jupyter extension creates the remote connection, they create a temporary Notebook at the root of the Jupyter server (cloudfiles/code/). This placeholder Notebook is then used to relay the commands of the local Notebook however all execution context is per the placeholder notebook. This is why when you run !pwd after choosing the "Azure ML Compute Instance" option you're seeing the path as cloudfiles/code/ where cloudfiles == /mnt/batch/tasks/shared/LS_root/mounts/clusters/.
I think what is confusing in this experience is that once you're connected to the remote compute (through the full window), we still surface "Azure ML Compute Instance" as an option. This doesn't make sense as you're already connected to the compute, so the default localhost option is connecting you to the right server. I think the right approach here is for us to hide the "Azure ML Compute Instance" option when you're in the remote window. Keeping the option in the local window makes sense, as users that wish to only connect their local Notebooks to a remote compute can still do so in a streamlined way.

@sevillal @shsuman @tbombach I think it makes sense to move this issue to the Azure ML extension repository. We should also consider removing the "Azure ML Compute Instance" option from the list of Jupyter servers when the user is already connected to their remote instance. We contribute that option, so it makes sense for our extension to check the window context and hide the "Azure ML Compute Instance" option.

Thank you very much for the explanation @SiddhanthUnnithan! This perfectly explains the confusion I was having! I can now relay this information to my team, as we all found this confusing within the context of AML computes.

Happy to help! Really sorry about the confusion here. We'll evaluate getting rid of that option :)

I think transferring this issue to our repository makes sense. Although, I think we should close this issue and open a new issue regarding removing the Compute instance option in the remote window. As far as I understand, everything explained in this issue is our current expected behavior and their is no underlying bug.

Is there anything to verify here?

No the issue was essentially transferred.


Invalid object name 'sys.login_token'

Hi,
I get that error on my Azure Sql Server Database on creation of the tableDependency instance.

Exception:

{System.Data.SqlClient.SqlException (0x80131904): Invalid object name 'sys.login_token'.
at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)    at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose)    at System.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)    at System.Data.SqlClient.SqlDataReader.TryConsumeMetaData()    at System.Data.SqlClient.SqlDataReader.get_MetaData()    at System.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString)    at System.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean async, Int32 timeout, Task& task, Boolean asyncWrite, SqlDataReader ds)    at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)    at TableDependency.SqlClient.SqlTableDependency1.CheckIfUserHasPermissions(String connectionString)
at TableDependency.TableDependency1..ctor(String connectionString, String tableName, IModelToTableMapper1 mapper, IUpdateOfModel`1 updateOf, ITableDependencyFilter filter, DmlTriggerType dmlTriggerType, Boolean executeUserPermissionCheck)
at SignalRCore.Web.Hubs.InventoryDatabaseSubscription.Configure(String connectionString) in C:\Source\VSTS\SignalR-Core-SqlTableDependency\src\SignalRCore.Web\Hubs\InventoryDatabaseSubscription.cs:line 32
ClientConnectionId:cdf7e9e8-2617-4775-b22d-65116017cdbe
Error Number:208,State:1,Class:16}

The sample is from there: https://github.com/vany0114/SignalR-Core-SqlTableDependency
I reported the issue there , too. Because I don't know he is responsible for that error.
Thanks for your help in advance
best
Eric

Please check:
https://github.com/christiandelbianco/monitor-table-change-with-sqltabledependency/issues/31

https://docs.microsoft.com/en-us/azure/sql-database/sql-database-features

Thanks. Maybe the new Azure Sql Database Managed Instance (PREVIEW) can solve it because Service Broker is supported there:
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-features

sys.login_token is part of a select used by SqlTableDependency to check if user specified in your connection string has the right grants needed to create database objects (trigger, queue, message type ect...) used for delivering record changes.
If you are sure that user has enough grants, you can skip this test simply setting the executeUserPermissionCheck constructor parameter to false.

Ciao Christian,
did I correctly understand you, that setting executeUserPermissionCheck - false will fix the issue?
When I´m right, could you please post the example where to set false instead of true?
Many Thanks in advance.
best regards
bpnkt

well, no, it does not.
if you set executeUserPermissionCheck = false, when start SqlTableDependency does not check if your user has grants expected by SqlTableDependency.

making executeUserPermissionCheck = false I get later a different exception in Azure:
Statement 'CREATE MSGTYPE' is not supported in this version of SQL Server


Concordium Node Dashboard missing http cache control header

Node Dashboard html page does not have required cache control parameter and due to lack of that parameter, browser showing cached content. at least below headers should be included.
<META HTTP-EQUIV="Pragma" CONTENT="no-cache">
<META HTTP-EQUIV="Expires" CONTENT="-1">

view-source:http://localhost:8099/

I agree with Emre, due  the caching at some time, it takes too long to browse the page.

@EmreNOP I don't think the cached HTML should be an issue. Are you suggesting that something else is being cached that shouldn't be and thus causing problems? What problems are you seeing?
@namekutuk your comment seems to suggest the opposite, that caching is making it worse...? Can you also be clearer on what issue you're seeing?

my recommendation is not just about cached html. so might be js, css etc. whatever in use.
We talked a lot on the discord and tons of people noticed that, if you not open dashboard in incognito mode, dashboard showing old content about baking, (waiting time, join delegation queue button etc)
i have two example for instance.
first one, 4 days a go, i joined stake delegation queue. (In Testnet stake delegation queue, waiting time 46h1m.) and after around 50mins, i noticed that "Testnet stake delegation pending, will become active in 1h31m"
but it was already active and ive had joined queue. There was also some kind of inconstancy on the dashboard but i dont have ss for them.

Okay, thanks for the detail. I don't think this has anything to do with asset caching, but will take a look.

@EmreNOP, from your elaboration, it sounds like you experienced another instance of the browser's local storage status failing to automatically update.
Please try to clear the local storage manually, by using the following keys while being on the node dashboard:
Windows/Linux: ctrl + delete
MacOS: ctrl + fn + backspace
Once pressed, you will be prompted to confirm the action. You can also delete the entries in the browser's local storage manually and immediately refresh the webpage before it re-inserts the entries again.
There is a more detailed description and workarounds under troubleshooting.

im using brave on linux workstation. technically, im clearing all cached contents (cookie,js, images like static contents) at every restart of browser.(this is my default settings). how ever, if i notice again in same browser session, i'll try.
but i guess ctrl+delete is useless in brave or chromium. could it be ctrl+f5 ?
Emre

Here is the additional findings for this.
I switched my ssh port mapping one node to another node. in first screenshot, my secondary node is looking like have assinged baker but its not. second ss from incognito brave session. everything is normal as expected.
then i close my tab and open again with normal browser session. output was still same. new node, and other node baking output.
then i completely closed my browser (main one) and than everything is looking ok. im  not sure this is related with my clear cache settings but anyway. you can produce same thing from here that i believe.

@EmreNOP it sounds like while you let a lot of stuff clear out, maybe your LocalStorage is still being retained (and only cleared for some reason when you close Brave completely).
If you see this again, please do try the steps from troubleshooting to clear LocalStorage specifically. Simply refreshing the tab after that should work to "unstick" things.

Node dashboard to be reworked in future.


Add v to version in make vendor-tarball

The EL rpm specs use a v preceeding the version number when looking for the vendor tarballs.
Signed-off-by: Brent Baude<EMAIL_ADDRESS>

LGTM


Dev branch broken after merge

The backend will restart over and over with the same error message:
Traceback (most recent call last):
  File "/usr/local/bin/daphne", line 8, in <module>
    sys.exit(CommandLineInterface.entrypoint())
  File "/usr/local/lib/python3.10/site-packages/daphne/cli.py", line 171, in entrypoint
    cls().run(sys.argv[1:])
  File "/usr/local/lib/python3.10/site-packages/daphne/cli.py", line 233, in run
    application = import_by_path(args.application)
  File "/usr/local/lib/python3.10/site-packages/daphne/utils.py", line 17, in import_by_path
    target = importlib.import_module(module_path)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/backend/./backend/asgi.py", line 20, in <module>
    "http": get_asgi_application(),
  File "/usr/local/lib/python3.10/site-packages/django/core/asgi.py", line 12, in get_asgi_application
    django.setup(set_prefix=False)
  File "/usr/local/lib/python3.10/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/usr/local/lib/python3.10/site-packages/django/apps/registry.py", line 116, in populate
    app_config.import_models()
  File "/usr/local/lib/python3.10/site-packages/django/apps/config.py", line 269, in import_models
    self.models_module = import_module(models_module_name)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/app/backend/./usermanagement/models.py", line 3, in <module>
    from .utils import random_filename
ModuleNotFoundError: No module named 'usermanagement.utils'

Seems like it could not find usermanagment.utils

https://github.com/memaar92/transcendence/blob/75b17fc8892acb1841de5aead8f81922c3cba704/backend/usermanagement/models.py#L3C1-L4C1
Hier wird ein utils file imported was es nicht gibt

Fixed with #3

Fixed with #3

Fixed with https://github.com/memaar92/transcendence/pull/3


Liked datasets/maps filter is not working properly

If says there is only one liked dataset but it keeps returning all datasets.

uhmm, yes, there is no filter to show "only liked visualizations", I implemented a "order by likes", so then this is a new feature.
But despite that it should show at the first page the vis with 1 like, then the ones without likes, does that work ok (screenshot shows that no)?

The problem is we have a order by 'most liked':

And then a filter related with likes. That makes the list order a bit confused.

Yep, that's what I meant, there's no filter for likes coded :D
I'll do it as soon as possible

After a quick local hack, this is where it was at the import process when it tried to enqueue the ghost table register:
2015-01-19 16:00:21 UTC: Before persisting metadata 'leadership_in_homing_pigeon_flocks_columba_liv' data_import_id: b785636b-b9a0-449e-9d9c-25ddb5ca7682

Pending internal code polishing, but filter working \o/
to use it, add a only_liked=true filter (I've maintained same signature style of only_shared)


Event Subscriber Bug

To Reproduce
E.g.
There is publisher in Customer table:

I created subscriber for this publisher but changed record from Customer to Currency:

Published extension and triggered that publisher and got result like this:

Expected behavior
Get error in Visual studio code that record does not match
Versions:

AL Language: 4.0.194000
Business Central: 15.1.37793.0

Thank you for the repro! This seems to be a duplicate of #5464 . We will fix the issue in the next CU.


Phasecurve

Create the initial PhaseCurve class, contains the modules required to initialise an sbpy phase curve model, get the model reduced mag from phase angle and do some a simple model fit to observations. Unit tests to follow.
Closes #44
Review Checklist for Source Code Changes

[x] Does pip install still work?
[ ] Have you written a unit test for any new functions?
[ ] Do all the units tests run successfully?
[x] Have you used black on the files you have updated to confirm python programming style guide enforcement?

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.66%.  Consider uploading reports for the commit 07a2de4 to get more accurate results

Files
Patch %
Lines

src/adler/adler.py
0.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   69.84%   66.66%   -3.18%
==========================================
  Files           3        3
  Lines          63       66       +3
==========================================
  Hits           44       44
- Misses         19       22       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Added some basic unit tests

I think you need to re-pull and merge main here - this isn't compatible with the latest changes to the dataclasses (sorry!). When I run:
>> adler -s<PHONE_NUMBER>335894776
I'm getting:
Traceback (most recent call last):
  File "/home/smerritt/.local/bin/adler", line 8, in <module>
    sys.exit(main())
  File "/home/smerritt/adler/src/adler/adler.py", line 31, in main
    runAdler(args)
  File "/home/smerritt/adler/src/adler/adler.py", line 13, in runAdler
    pc = PhaseCurve(abs_mag=planetoid.SSObject.r_H, phase_param=0.2, model_name="HG")
AttributeError: 'SSObject' object has no attribute 'r_H'

This should be SSObject.H[2], I believe. SSObject's filter-dependent class attributes are now lists in the order of the requested filters.

Cool, I forgot about the command line stuff. I'll just change that bit to what you suggested. This will probably be changed later when issue #77 is dealt with


Add "set-variables-in-scripts" file

Now only in the release variables page, there is a tutorial about how to use the variables on Batch/PowerShell/Shell.
It's would be great if it will also available in the Build variables page.

Thanks for the PR. We had this section in here, but it's been moved here: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=vsts&tabs=yaml%2Cbatch#set-in-script

Ok, I missed this page :) but why is also exist on https://docs.microsoft.com/en-us/azure/devops/pipelines/release/variables?view=vsts&tabs=batch ?

Ok, I missed this page :) but why is also exist on https://docs.microsoft.com/en-us/azure/devops/pipelines/release/variables?view=vsts&tabs=batch ?

@alexhomer1 might be able to advise on that question.


"roundPixels" incorrect on hiDPI screens

I don't have a hiDPI screen to hand so I suppose it is possible that what I am seeing is down to the Firefox HiDPI emulation.  But that said having peered through the source code of PIXI it does indeed appear to be a bug.
I have only tested this with the WebGL rendere.
Currently if you enable roundPixels and have a screen with a pixelRatio of 2, everything gets rounded to every full pixel.  When in fact you want everything to be rounding to every 0.5 pixels.  Or in otherwords, it should be rounding to the nearest pixel fraction of the screen.
e.g. On a screen with a pixelRatio of 3, it should round to every 0.333333 pixels.  PixelRatio of 4? round to 0.25 etc.
Assuming that I have not dramatically misunderstood something then the fix is really quite easy.
Just change the rounding in the Webgl renderer to account for the resolution, like so:

 if (this.renderer.roundPixels)
        {
            // xy
            positions[index] = Math.round((a * w1 + c * h1 + tx) * this.renderer.resolution)/this.renderer.resolution;
            positions[index+1] = Math.round((d * h1 + b * w1 + ty) * this.renderer.resolution)/this.renderer.resolution;

            // xy
            positions[index+5] = Math.round((a * w0 + c * h1 + tx) * this.renderer.resolution)/this.renderer.resolution;
            positions[index+6] = Math.round((d * h1 + b * w0 + ty) * this.renderer.resolution)/this.renderer.resolution;

            // xy
            positions[index+10] = Math.round((a * w0 + c * h0 + tx) * this.renderer.resolution)/this.renderer.resolution;
            positions[index+11] = Math.round((d * h0 + b * w0 + ty) * this.renderer.resolution)/this.renderer.resolution;

            // xy
            positions[index+15] = Math.round((a * w1 + c * h0 + tx) * this.renderer.resolution)/this.renderer.resolution;
            positions[index+16] = Math.round((d * h0 + b * w1 + ty) * this.renderer.resolution)/this.renderer.resolution;
        }

Changing to the above in the webGL render makes roundPixels snap properly, inline with the DPI of the screen.
Obviously the above is using Math.round which is slower than other forms of javascript rounding like bitwise operators etc.  But this was the quickest way to fix the issue.  I'm sure someone else will have a more performant method.

Great catch @GordoRank. Thanks for providing the solution too :)
I have just pushed the fix to the dev branch :+1:


fix positioning of middle characters

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
25

Relevant Lines:
25

💛  - Coveralls


OpenRead always retuns size 0

When I try to download a file using FluentFTP the OpenRead always returns a stream with size 0
What could be the cause for this ? The files are there and I can download them with filezilla or total commander so there is no security problem or anything
here is my code
            FtpClient client = new FtpClient();
            client.Host = drv["Host"].ToString();
            client.Port = (int)drv["Port"];
            client.Credentials = new NetworkCredential(drv["UserName"].ToString(), drv["PassWord"].ToString());
            client.EnableThreadSafeDataConnections = false; // the ftp server only allows one connection per username
            client.Connect();

            client.SetWorkingDirectory(remoteDir); // GetListing with a folder does not works

                using (Stream stream = client.OpenRead(remoteFile))
                {
                     SaveStreamToFile(localFile, stream);
                }

    private void SaveStreamToFile(string fileFullPath, Stream stream)
    {
        if (stream.Length == 0)
              return; // I always get here. Why ????????

        // Create a FileStream object to write a stream to a file
        using (FileStream fileStream = System.IO.File.Create(fileFullPath, (int)stream.Length))
        {
            // Fill the bytes[] array with the stream data
            byte[] bytesInStream = new byte[stream.Length];
            stream.Read(bytesInStream, 0, (int)bytesInStream.Length);

            // Use FileStream object to write to the specified file
            fileStream.Write(bytesInStream, 0, bytesInStream.Length);
        }
    }

Can you provide your login details in order for me to test? If not then can you create a test FTP account on your server and provide that? Its really difficult to debug such use-case issues without connecting to the actual server. You could just add a comment with it, and delete the comment immediately after. I will get the details by email.

After strugling with this all day I tested another ftp library which does not has this problem, so I am going to switch to that library.
Sorry but this library is just not stable enough for me.

I added a high level API for client.DownloadFile. If you wish to check it out you may.
And which library did you find that works better? I myself use FTP in my apps so I would like to know.

Currently I am using this one
http://enterprisedt.com/products/edtftpnet/
It worked straight from my first try and my code is 4 times smaller
I have it in production only one day yet so still to wait if any problems can occur, but until know my logs are clear from exceptions and all files where downloaded.
I use it in a windows service.
Van: Harsh Gupta<EMAIL_ADDRESS>Verzonden: vrijdag 6 januari 2017 6:29
Aan: hgupta9/FluentFTP<EMAIL_ADDRESS>CC: Guido<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Onderwerp: Re: [hgupta9/FluentFTP] OpenRead always retuns size 0 (#28)
I added a high level API for client.DownloadFile. If you wish to check it out you may.
And which library did you find that works better? I myself use FTP in my apps so I would like to know.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/hgupta9/FluentFTP/issues/28#issuecomment-270834579, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXyAowLEdgyJoFc38_ycfDH8q56WnxzSks5rPdEhgaJpZM4LboMh.

Thanks for the info!


Task view randomly doesn't work

Extension Name: vscode-gradle
Extension Version: 3.6.1
OS Version: Windows_NT x64 10.0.19043
VSCode version: 1.59.0-insider
Sometimes, when opening Gradle panel in the activity bar, Gradle Tasks view shows nothing

After refreshing, it works well.
There is another bug, might come from the same root cause, sometimes collapse all button is disabled by default

it also works after refreshing or other operations (such as run a gradle task, etc.)

After investigation and debugging, I think it's the root cause of this issue.
When resolving tasks, there is an async function is awaiting.
https://github.com/microsoft/vscode-gradle/blob/f5bf5f8687d07a27848b4dd2fb1c2c7f7f0c00ba/extension/src/views/gradleTasks/GradleTasksTreeDataProvider.ts#L120
When awaiting this promise, there is a refresh command might be triggered, which comes from https://github.com/microsoft/vscode-gradle/blob/f5bf5f8687d07a27848b4dd2fb1c2c7f7f0c00ba/extension/src/Extension.ts#L185
To describe it simply, a new refresh is requested during the get task process, which results in there is no items in the view. you can easily reproduce this bug if you quickly click the Gradle in the Activity Bar once it appeared.
@badsyntax I'm not very sure about what is this.client.onDidConnect(() => this.refresh()); for. I just try to comment it and this issue seems not to appear again and do not break other features. Could you please give some suggestion or comment on this? Is there any side effect if we just remove this?

@CsCherrYY I've been able to replicate this behaviour. Unfortunately it looks like a race condition but it's not clear why. (FYI I have not seen this behaviour in the past, perhaps this race condition is due to a recent change in vscode.)
The purpose of this.client.onDidConnect(() => this.refresh()); is to refresh the task last after the client has reconnected. A use case for this scenario is when the server gets kills unexpectedly, in which case the extension will prompt the user to restart the server, and the grpc client will re-connect, but the task list is not automatically updated, which is why we are explicitly calling refresh().
You can see this yourself by killing the Java server process (on macos/linux killall java)
It would good to understand why this bug occurs (it's really not clear to me) but a possible workaround is to only add this event handler after the server has stopped, possibly in this method:
https://github.com/microsoft/vscode-gradle/blob/cd69c0c451526803b6700c13596f2f8dfb246e7e/extension/src/client/GradleClient.ts#L71-L73
(If we add it there we'll need to unsubscribe the event handler after it's called.)
I can't think of other use cases that require this.client.onDidConnect(() => this.refresh()); so I think it's safe to move that event handling to handleServerStop.

To clarify a bit more, if we don't want the task list updated after the server has restarted then I think it's safe to remove that line.

@badsyntax Thanks a lot for the clarification! It seems a VSCode treeview issue and I just find https://github.com/microsoft/vscode/issues/129019 (though it's about a start-as-closed view, but for other start-as-open views I can sometimes reproduce it) might be related this issue, I'll keep eyes on it. From our side, we can currently have a workaround.
For the restarting server scenario, I'm wondering if the view's content would be changed after we call this.refresh() again. IMO the case causing "out of sync" is that the project has been changed during the client misses the connection to the server. Otherwise, the refreshing will bring the same result. Thus, I prefer to just removing it. Does this make sense?

Yes I can also replicate the treeview bug when I drag the gradle tasks view into the main file explorer view (start-as-open) and restart vscode (but as you say that issue might still be related).

IMO the case causing "out of sync" is that the project has been changed during the client misses the connection to the server. Otherwise, the refreshing will bring the same result. Thus, I prefer to just removing it. Does this make sense?

It makes sense yes. Refreshing will bring the same result in most cases. Maybe I added it for extreme edge cases where maybe the task view was not previously rendered with anything due to a server start failure, but i can't remember and the PR that introduced that change doesn't describe exactly why I added it. I think it's totally fine to remove it 👍


fix: Simple theme is missing resources for TimePicker & DatePicker

What does the pull request do?

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/avalonia-docs with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #12702

You can test this PR using the following package version. 11.0.999-cibuild0039355-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


Point users to use a configuration file from the import menu

I was thinking we can put a link just next to the Edit advanced options or as a help text.

From a design point of view, I'd suggest a help text would be more efficient because a link to the advanced settings page would not exist before the project is added and clicking 'Next' to add the project would redirect the user to a different page anyway.
I'm new here and not very certain of the design aspect, but this seems like a good first issue. Can I work on this after we reach a design consensus?

Hi @dhruvkb
@stsewd had already assigned this issue to himself and @davidfischer.
I would suggest you to please look into another issues.
Thanks

@dhruvkb thanks for the interest, but as mentioned, this work is already assigned. And for clarification, we are talking about this configuration file https://docs.readthedocs.io/en/stable/config-file/index.html

Of the configurable options on the import screen's "advanced options", the only one that can be configured in the YAML file is the documentation type (sphinx, mkdocs, etc). That's also the only one that really must be configured before a project can be built. All the others are just metadata about the project.

Proposal

I think we should completely remove the the "advanced project options" checkbox and form. This is totally unnecessary as all those things other than the documentation type can be tuned after the project is imported and built.
Instead, we should point people to the YAML config file documentation on the manual import page and we should even provide a sample config file with the most common options. Something like this:

version: 2
formats: all

# Build documentation in the docs/ directory with Sphinx
sphinx:
  configuration: docs/conf.py

python:
  version: 3.7

  # Python requirements required to build your docs
  install:
    - requirements: docs/requirements.txt


Not compatible with ecto_sql 3.0

When trying to install I get:
Failed to use "ecto" (versions 3.1.0 to 3.1.7) because
  votex (version 0.3.0) requires ~> 2.1

Is ecto 2.1  a necessity?

Create a fork that supports latest, https://github.com/silentcoder-ctrl/votex.git


Night CI 2024-02-26: Failed

action url: https://github.com/spidernet-io/egressgateway/actions/runs/8054839747

 [It] test IP allocation [R00008, P00009]
  /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:72

  Timeline >>
  > Enter [BeforeEach] IP Allocation - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:37 @ 02/26/24 20:18:31.129
  succeeded create egw: egw-3513ab91-77d1-490c-8f9b-95044b03c2cf
  < Exit [BeforeEach] IP Allocation - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:37 @ 02/26/24 20:18:35.649 (4.52s)
  > Enter [It] test IP allocation - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:72 @ 02/26/24 20:18:35.649
  STEP: create egressPolicies by gaven pods - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:74 @ 02/26/24 20:18:35.649
  Automatically polling progress:
    IP Allocation test IP allocation (Spec Runtime: 24.52s)
      /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:72
      In [It] (Node Runtime: 20s)
        /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:72
        At [By Step] create egressPolicies by gaven pods (Step Runtime: 20s)
          /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:74

        Spec Goroutine
        goroutine 599 [sleep]
          time.Sleep(0x1dcd6500)
            /opt/hostedtoolcache/go/1.20.5/x64/src/runtime/time.go:195
          github.com/spidernet-io/egressgateway/test/e2e/common.WaitEgressPolicyStatusReady({0x29747b0, 0xc0000501b8}, {0x297c380, 0xc00065e7e0}, 0xc0005d3500, 0x1, 0x0, 0xc00012c919?)
            /home/runner/work/egressgateway/egressgateway/test/e2e/common/egp.go:320
          github.com/spidernet-io/egressgateway/test/e2e/common.CreateEgressPoliciesForPods({0x29747b0, 0xc0000501b8}, {0x297c380?, 0xc00065e7e0}, 0x0?, {0xc000586200, 0x32, 0xc0008f1cf8?}, 0xe5?, 0x0, ...)
            /home/runner/work/egressgateway/egressgateway/test/e2e/common/egp.go:393
        > github.com/spidernet-io/egressgateway/test/e2e/reliability_test.glob..func1.2()
            /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:75
              | // create egresspolicies
              | By("create egressPolicies by gaven pods")
              > egps, _, err = common.CreateEgressPoliciesForPods(ctx, cli, egw, pods, egressConfig.EnableIPv4, egressConfig.EnableIPv6, creationThresholdTime)
              | Expect(err).NotTo(HaveOccurred())
              |
          github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0x0, 0xc000900600})
            /home/runner/work/egressgateway/egressgateway/vendor/github.com/onsi/ginkgo/v2/internal/node.go:463
          github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
            /home/runner/work/egressgateway/egressgateway/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:889
          github.com/onsi/ginkgo/v2/internal.(*Suite).runNode
            /home/runner/work/egressgateway/egressgateway/vendor/github.com/onsi/ginkgo/v2/internal/suite.go:876
  STEP: create extra egressPolicies - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:78 @ 02/26/24 20:19:41.571
  STEP: delete all egressPolicies - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:89 @ 02/26/24 20:19:42.368
  STEP: create egressPolicies by gaven pods - /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:94 @ 02/26/24 20:19:48.168
  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0008349b0>:
      timeout to wait egressPolicy status ready
      {
          s: "timeout to wait egressPolicy status ready",
      }
  occurred
  In [It] at: /home/runner/work/egressgateway/egressgateway/test/e2e/reliability/reliability_ip_test.go:96 @ 02/26/24

same with #1207


Feature: disable import line wrapping

Feature: disable import line  wrapping
There should be a setting to disable wrapping of long import lines.
Reason
I've been having some issues with
line wrapping breaking imports, and generally not agreeing with Prettier, which is my go-to code formatter.
Prettier also handles wrapping of long import statements. In alignment with the Unix philosophy, it
should be possible to make typescript-hero (which by the way is a really nice tool) do fewer things, but
do those things well. Then other tools can concentrate on doing other stuff well. If I could make
typescript-hero do just import sorting, removal and grouping, I could leave formatting to a more specific
formatting tool.
I'll try to cook up a PR, I assume this feature isn't that hard to implement.

I've never contributed to a VSCode extension, so I'm a bit confused as to how to get my local version up and running. Is it possible to get any pointers on this?


Support .zip decompression in S3 source

Is your feature request related to a problem? Please describe.
The data prepper S3 source only supports gzip decompression
Describe the solution you'd like
Support .zip decompression

spoke with @dlvenable and I will be working on this


rename n_classes to num_classes

Resolves https://github.com/Project-MONAI/MONAI/pull/2842
Description
unify n_classes and num_classes across model arguments
Status
Ready/Work in progress/Hold
Checks

[ ] Notebook runs automatically ./runner [-p <regex_pattern>]

Mark: this PR bring an error for nvflare tutorial since it relies on monai 0.6.0.


background.remove is not safe

background.remove is not safe to use. The job IDs are re-used frequently thus are not unique over a time period. Therefore the remove operation could delete job which is was created after the to-be-deleted job.

Fixed with version 1.0.1  27b4b87


Modify molecule scenarios to test Oracle Linux 9

Description
this PR aims to add molecule tests for Oracle Linux 9 support
Fixes # ANSIENG-2479
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
ZK cluster on amd architecture
Kraft cluster on amd architecture
ZK cluster on arm64 architecture
Kraft cluster on arm64 architecture
Checklist:

[x] Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
[x] I have added tests that prove my fix is effective or that my feature works
[ ] If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

Should we define variable like oracle_java_package_name similar to redhat_java_package_name to allow users to choose java version

Should we define variable like oracle_java_package_name similar to redhat_java_package_name to allow users to choose java version

we don't need to do that, since they belong to the same OS family i.e redhat, we can use the same variable in oracle linux to allow users to choose java version


Question?

is it possible to select more than one contact?

Not with this plugin at the moment. You'd have to query the address book yourself, present a multi-selection UI and then fetch the details yourself.


[Feat] Bug & Feature Preset Add

BUG & Feature Preset
🟥 There should be an existing form for raising an issue or requesting a feature for your repo.
Like this :

Please add hactoberfest and GSSoC24 tag. You can assign me for this issue.

@4F24L Sure, you can proceed with it. Please remember to -

Send a photo here of of the new design before raising a PR
Star the repo :)

All the best!


add more helps to s3-compatible remote

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@johnnychen94 I see the problem you are trying to solve, but let's think a bit about alternative approaches. The problem is very general and --global could be used in a lot of cases (not only s3-compatible, and not only even s3)
should it be made clear in the the dvc remote modify docs that --global could be used in a way to override/set certain values?

A good suggestion, I've moved it to the example part https://dvc.org/doc/command-reference/remote/add#example-customize-an-s3-remote. Might be something obvious for oss users but at least it's worth giving a warning.

Closing this as stale. @johnnychen94 feel free to reopen it when you have a bit more time to address the comments.


Persist task position in TaskFragments, allowing them to instantiate their own ViewModel

Fixes #1458
@scolsen PTAL?

/gcbrun

Looks like it's failing with:  The parameters in the factory method must match the @Assisted parameters in com.google.android.ground.ui.datacollection.DataCollectionViewPagerAdapter.

Looks like it's failing with: The parameters in the factory method must match the @Assisted parameters in com.google.android.ground.ui.datacollection.DataCollectionViewPagerAdapter.

I think that should be fixed now.

/gcbrun


Use Alpine.clone to avoid existing component being reset when navigating using the history.

When user click back, we want to show the previous state of all the Alpine components rather than reinitialise them.

Would you take a Pull Request for this?

Yeah, sure. It may need some thinking and discussion though because it might not be the desired behavior.

What do you think? Maybe we should cache them only if there is a specific attribute.

I actually think in that case the state should be preserved on the back button in that case. I do worry about how it will work with removing Alpine generated DOM nodes.

I'm not sure people would agree, if they hit back and a modal was already open, I think they would report it as a bug

So, I've been using data-turbolinks-permanent to preserve client state across navigation, but I can see how the "back button" would semantically be different than clicking on a link ("get me back to my previous state.") In 99% of the cases I suspect that wold be the correct/expected behaviour, but don't think you could add something like this without a way of opting out of it.

yeah, I'm not convinced because stuff like modals and submenus could open when you go back menu if you clicked on a link inside them which feels a bit weird. I'm trying to understand if it's perceived as an issue at the moment before doing anything.
As you said, if I ever add anything will be either an opt-out (data-alpine-no_cache) or maybe even an opt-in mechanism so people don't get errors if they update without reading the release notes.
I'm still thinking about it for now.

Closing for now. The unexpected side effects are far worse than the benefits.


Add some sort of symlink management for indirect backups

GSM has a "Steam Spreader" function for moving/symlinking game installs, as well as a "Link & Sync" function for doing the same just for save data. It may be worth adding similar functionality here for users coming from GSM, since it provides a way to redirect game saves to a cloud storage folder or alternative drive, thus acting as another form of backup. This would require some care to ensure it works well cross-platform and that it won't break anything (e.g., if folders/files are affected that shouldn't be or if it could interfere with the operation of Steam/etc).

I tried the feature for a day and this is why I like to say, having this feature for game files makes no sense since you can move them from steam easier imo, for save files I feel making the back up location in ludusavi a linked folder (to any service) makes it easier, it is true that it will be all automatic,
But here is the point, having game play backup and backing up the files on a synced folder is much easier than or maybe some kind of tracker that looks at the active exe files, and backed up that game each 10 minutes or so, or user can decide, it feels redundant If I have to be honest.
In short having steam spreader feels a waste of time, and sync and link feature can be considered redundant and gameplay backup can be modified to be better.
 I personally agree, and I do have some other reservations around this feature.
I think it would be hard to get right, and the cost of failure is high since it could corrupt save data. I don't want it to turn into a footgun, and I don't think it really fits the design goals of Ludusavi. Some specific challenges:

Behavior from Steam and other clients could be unpredictable. What works today might not work tomorrow, and individual games might have trouble handling unexpected symlinks. I never want Ludusavi to corrupt people's save data by accident.
Currently, Ludusavi backs up the target of symlinks, but not the symlinks themselves. If Ludusavi were also responsible for creating symlinks, it would have to back those up in a different way from "unmanaged" symlinks. However, that means if you cleared out your Ludusavi config (e.g., reinstall or even running as a different user), then it may not be able to back up/restore them properly. Someone ran into a similar issue with GSM: https://forum.gamesave-manager.com/viewtopic.php?p=716

For anyone interested in this, you could still use Ludusavi's CLI (with --api) to automate something that reports/symlinks files that exceed a certain size. I think this is a good opportunity for another script/tool to build on top of Ludusavi.


draft - ignore! replacement property icon

@kimberleyamackenzie okay to close this?

@susanev yup, sorry, closed!


README: Section "Read Navigation File Example"

Hello,
Thanks for your great work. Just a little mark.
In your readme section "Read Navigation File Example", Function readRinexNav does not exist.
perhaps, you mean rinexnav or rinexnav2 or rinexnav3?
Thanks

The documentation was updated, thanks!


Update AbsoluteLayout.xml

fixes #80

Docs Build status updates of commit 53866dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Xamarin.Forms/AbsoluteLayout.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin.Forms. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI is the replacement for Xamarin.Forms, and its API docs are built from /// in the dotnet/maui repository. Therefore, any PRs for the .NET MAUI API docs should be opened in that repository.


fixes #9 by sending new messages instead of overwriting on every send

See #9
This should also prepare the node for the upcoming Node-RED 1.0.

Will republish new version to npm as soon as I get a chance this weekend.


[Bug]: Cannot change the difficulty of created worlds

/mv version -p output
https://pastebin.com/YkJLVtuB
Server logs
https://paste.gg/p/anonymous/153069b1e13d4fb882dd9dda6c8f91d4
Server Version
This server is running LoliServer version 1.16.5-109 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT, Forge version 36.2.8)

Server Version
I created a new world named "testDIM". When I tried to modify the difficulty using "/mvm set diff PEACEFUL testDIM", I found the difficulty of "world" "DIM-1" "DIM1" changed to peaceful while "testDIM" not.
Then I modified the "world.yml" file and used "/mv reload" to change the difficulty. But still failed. The difficulty in file reset to "EASY" ( this also happened when I restarted the server).
Thus, I could not change the difficulty level of my new world.
However, for other properties such as "gamemode", I could successfully change them. (use /mvm set mode creative testDIM)
Steps to reproduce

Start a server with only Multiverse installed
Log in as an op
/mv create testDIM normal
/mv tp testDIM
/mvm set difficulty peaceful testDIM
BUG comes

Another way:

Change difficulty of testDIM to peaceful in world.yml.
Start the server (or use "/mv reload" if server is running)
The difficulty is still easy (world.yml reset)

Agreements

[X] I have searched for and ensured there isn't already an open or resolved issue(s) regarding this.
[X] I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

Really? Is it really about which platform you use? Blaming on using forge does not make sense.
I am currently using a hybrid server and, the most strange thing I’ve ever met happened, which is seemed to be a total implementation issue. I tried to use some commands like /mvmodify set difficulty peaceful world and it said Success and you guess what? Nothing changed.
May be there was still some reasonable reasons why the command did nothing? But how could I find another reason for this?
I tried changing content in worlds.yml. Fortunately I found something useful to me like monster-spawn, gamemode and difficulty. I changed it to the desired value, executed /mv reload, but nothing changed either. I assumed it was because the server is running and the plugin may NOT know what I did to the configuration instantly, so I rebooted the server and even the instance running the server.
You guess what, everything turned back to what they were originally in the configuration file. How could this happen?
Could you say "It’s forge" again?
**Note: ** I am sure I’d saved my file :)

And even if we run /mv modify set diff easy testworld, it will only change the difficulty settings of world, DIM1 and DIM-1
But when we run /mv modify set animals false testworld, it works

If you can reproduce the issue on spigot or paper, we will be happy to look into it.


Fix service initialization when run in FastBoot server

Don’t try and configure Stripe global when it doesn’t exist because w…e’re running from a FastBoot server. Fixes #53

@drauschenbach thanks for the PR! It looks like the tests are failing on Travis. I might also recommend a test for the branching logic here, if possible.

I might also suggest giving a glance to #44.


Generate Waze portal links.

It would be great if "Map Links" popup window from portal info screen had a url for Waze links.
Waze links format is:
http://waze.to/?ll=[latitude],[longitude]&navigate=yes

The benefit of using Waze link is that during an op agents can share back their current real-time location(similar to glympse) and eta to destination.

@umer936 btw, just noticed that this is still around. On mobile, Chrome Beta and Link Bubble, it still doesn't open the Waze app. =(


CORS

Look forward to joining CORS support!

Hello my friend can we talk by e-mail?
Please send me an e-mail to<EMAIL_ADDRESS>Thank you!


Add Dockerfile for building a Docker image running nova

This Dockerfile should build a Docker image which contains a working "nova" binary.
Can be partnered with a script to link in required directories/env variables at run time.

Coverage decreased (-0.1%) to 68.919% when pulling 4d2a70fbb1af17304b116d81f540e038cc28b573 on feature/dockerfile into 54cc03362786fdef97ddd9123548d1d69cb208bf on master.

Coverage decreased (-0.1%) to 68.919% when pulling db140291a2e3925fec27998330b0dada8da4f1f5 on feature/dockerfile into 54cc03362786fdef97ddd9123548d1d69cb208bf on master.

Deploy won't work with this script as the nova from the Docker container can't communicate with the Docker on host machine.

Coverage increased (+0.3%) to 69.364% when pulling 61aac5678976a4b3b6dc2b37bfbb6f0223e571f6 on feature/dockerfile into 54cc03362786fdef97ddd9123548d1d69cb208bf on master.

It works fine now!

Image is missing the nova templates in ~/.nova and - at least when building and running it locally - the aws credentials in ~/.aws

You have to use the supplied script -- aws credentials have to be linked in to the container, amongst other things.
For the nova templates, it currently uses an env variable to point at your local copy -- I'll change this to bake the templates into the image -- with an override if you want to point at your copy instead.

Coverage increased (+0.4%) to 69.493% when pulling 9579f52b66d2bf1345d622bdac48ef6af32b0f6a on feature/dockerfile into 54cc03362786fdef97ddd9123548d1d69cb208bf on master.

Coverage increased (+0.4%) to 69.493% when pulling 9579f52b66d2bf1345d622bdac48ef6af32b0f6a on feature/dockerfile into 54cc03362786fdef97ddd9123548d1d69cb208bf on master.

Updated:

script now requires no env variables, though NOVA_DOCKER_IMAGE can be set to override the name of the image used.
clones gilt/nova-shared-templates (at build time), and links to /root/.nova
includes a Makefile for building new versions of the Docker image.

Coverage decreased (-0.1%) to 69.364% when pulling dc1782a213490d54875a0deed6da665913cd1959 on feature/dockerfile into 816f81e624f28a88f3745050bb774f5d2dd4a8c7 on master.

The aws credentials pass-through isn't working for me:
IRL-ML-GHEINE1-7:api gheine$ /Users/gheine/Code/nova/nova/bin/nova deploy giltaws staging 1.2.2-40-g7a44304
Traceback (most recent call last):
  File "/usr/local/bin/nova", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/nova/cli/main.py", line 83, in main
    app.run()
  File "/usr/local/lib/python2.7/site-packages/cement/core/foundation.py", line 797, in run
    return_val = self.controller._dispatch()
  File "/usr/local/lib/python2.7/site-packages/cement/core/controller.py", line 472, in _dispatch
    return func()
  File "/usr/local/lib/python2.7/site-packages/cement/core/controller.py", line 478, in _dispatch
    return func()
  File "/usr/local/lib/python2.7/site-packages/nova/cli/controllers/deploy/deploy.py", line 62, in default
    deployer.deploy()
  File "/usr/local/lib/python2.7/site-packages/nova/core/deploy/deploy_stack.py", line 51, in deploy
    print("Deploying to account '%s'..." % self._aws_manager.account_alias)
  File "/usr/local/lib/python2.7/site-packages/nova/core/managers/aws_manager.py", line 45, in account_alias
    self._account_alias = self.iam_client.list_account_aliases()['AccountAliases'][0]
  File "/usr/local/lib/python2.7/site-packages/botocore/client.py", line 278, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/usr/local/lib/python2.7/site-packages/botocore/client.py", line 572, in _make_api_call
    raise ClientError(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (ExpiredToken) when calling the ListAccountAliases operation: The security token included in the request is expired
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/local/lib/python2.7/site-packages/nova/core/deploy/deploy_stack.py", line 260, in __cleanup
    raise NovaError(e)
NovaError: coercing to Unicode: need string or buffer, NoneType found
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/local/lib/python2.7/site-packages/nova/core/deploy/deploy_stack.py", line 260, in __cleanup
    raise NovaError(e)
nova.core.exc.NovaError: coercing to Unicode: need string or buffer, NoneType found

botocore.exceptions.ClientError: An error occurred (ExpiredToken) when calling the ListAccountAliases operation: The security token included in the request is expired
You should be better if you run awstoken.
I'll file a bug against nova to give a good error message rather than "coercing to Unicode: need string or buffer, NoneType found"

I did and still got that error. But trying the same thing again later it worked... :shrug:

Updated

Coverage decreased (-0.1%) to 69.364% when pulling 36336b984f4748b03bbf5fc97dca0248e6cab47d on feature/dockerfile into 816f81e624f28a88f3745050bb774f5d2dd4a8c7 on master.

LGTM 👍  merge when you think it's ready!


No need to require at the top of authenticated controller as of 0.0.4

Also, apparently something changed with the facebook_url, so I needed to take that out of the initializer.

👍🏻


Proper type assertion without temporary variable

Search Terms
"ensure literal type typescript", "force typecheck typescript", "force literal typecheck typescript"
This limitation is widely recognized: https://basarat.gitbooks.io/typescript/docs/types/type-assertion.html
Suggestion
I would like to have syntax to enforce typechecking without need to create temporary variable.
Use Cases
Less code, better typechecking of object literals.
Examples
Now I have to write:
const foo: Foo = getFoo();
if (!foo.id) {
    const temp: Partial<Foo> = {
        id: generateId()
    };
    Object.assign(foo, temp);
}

I would like to write
const foo: Foo = getFoo();
if (!foo.id) {
    Object.assign(foo, {
        id: generateId()
    } as! Partial<Foo>); // "as! type" is only idea
}

Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

This seems like a good case for a helper function:

function assignPartial<T>(o: T, p: Partial<T>) {
    Object.assign(o, p);
}
if (!foo.id) {
    assignPartial(foo, {
        id: generateId(),
    });

    assignPartial(foo, {
        id: 42 // err
    });

    assignPartial(foo, {
        notId: 42 // err
    });
}

Don't think special syntax is really warranted here.

So let's add to situation other variations on Partial. Eg. TypeORM QueryDeepPartialEntity<T> or:
type PartialOrFunction<T> = {
   [K in keyof T]? T[K] | () => T[K]
}

Moreover, I tried to add some type safety to joi definitions by making eg.
const validator = object({

} as SchemaMapFor<IArticle>);

Duplicate #7481 ?

@RyanCavanaugh Yes, it is.


Create image for use with hadoop-test-cluster

hadoop-test-cluster is a tool for providing a quick and easy way of setting up hadoop clusters for testing and demonstrations. The images provided are extensible - it would be good to create one to demonstrate this full setup.

Fixed by https://github.com/jcrist/jupyterhub-on-hadoop/commit/fb40a8df3c24179173f864cf102638c64c8ab96c


Suggestions for the texture workflow

I find the new material flow very good and easy implemented. So keep up the good work :-)
As already mentioned, Gimel-Studio should be able to connect one node with several nodes (otherwise a node system hardly makes sense). I tried 3 other open source texture node systems: Material Maker, TextureLab and Graph.ical.
Material Maker has the most functions, but is already so complex that I can stay with the cycle editor. TextureLab makes a very good impression. But it only uses procedural textures and can't load an image map. This is a pity, because the interface looks quite good. But my absolute favorite is the web application Graph.ical. Not only the selection of the 42 nodes is excellent for 3D graphic artists. Above all, it is the fast and dirty workflow that outshines all others.  A new node is appended to the selected one. Double-clicking or Ctrl and clicking enlarges the node. You can select (and edit) one node and Ctrl+click to display another. In the large view you have a tiled preview (seamless) and a button to save. You cannot even specify a file name.
But the whole thing is so fast that you can actually edit images in seconds.
The only disadvantage: no 3D preview.
By the way, it works with dark reader ;-)
So you should have to look at the three apps.

I have tried Material Maker and Graph.ical. I think I will take a look at TextureLab too.
I plan to have a similar way of adding nodes to the node graph in Gimel Studio as you explained, with some differences.
I am going to be honest here, but I actually didn't like everything about the flow of Graph.ical. I personally like more along the lines of Blender's node editor. That's the reason you have user preferences, though -one person likes something different than another, right? :-)

LOL  Yes it looks like I am the only one who likes Graph.ical
I only wanted to describe the workflow once, because I realize that 90% don't understand it. I discovered it very early, because I was looking for an open source alternative to Substance Designer for a long time. At that time there was no alternative, otherwise I probably wouldn't have bothered with it. ;-)
But also agree to orientate yourself with Gimel-Studio towards the Blender Editor.
So I'm really looking forward to Gimel-Studio with more nodes and a better connection behaviour.
Thank you for being open for my ideas and of course for making Gimel-Studio.

I have just implemented better connection behavior for the nodes. It's in the master branch if you would like to try it. :) I am still working on getting all the nodes re-implemented for the huge changes I made to the api, backend, etc. though.

Thank you for being open for my ideas and of course for making Gimel-Studio.
HalleluYAH! Glad you like it. Your suggestions and feedback have been a great help.


docs: remove redundant headings (box/box-openapi#442)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 92.239%

Totals

Change from base Build<PHONE_NUMBER>9:
0.02%

Covered Lines:
10162

Relevant Lines:
11017

💛  - Coveralls


egui 0.29 support

Egui added "multipass" rendering for cases when multiple passes are needed to layout UI correctly.
For now this feature can be used manually (See simple multipass example) or old behaviour can still be used by default.
In future probably begin_frame_pass, end_frame_pass systems and all user systems could be rerun. But investigations how to do set of system rerun in bevy must be done.

Thank you for the PR!
I'll push a little change soon to fix the test CI pass. I'll also move manual_run to EguiSettings and convert it to a component to allow users control running per context.


Create a page for updating an order

Currently there is no page with a form where users can update their order
So create a dedicated page with the form where form should be pre-filled with the previous data for users to update their order(should be able to add food name, customer name and quantity)
Check code for what should be the action for the patch request

I would like to work on this issue

I would like to work on this!


AttributeError: function 'SharedMemoryControlContextCudaRegister' not found (Windows 10)

Description
After successfully building the trtis-clients and installing the wheel file into python, I am confronted with this error:

Environment information:

OS: Windows 10 Version 10.0.19041 Build 19041
Python: 3.7.7
Path includes the 'vcpkg\installed\x64-windows\bin' for everything installed using vcpkg in the guide below; otherwise I get a "OSError: [WinError 126] The specified module could not be found"
tensorrtserver version (as listed by pip): 1.13.0.dev0

Triton Information
20.03
Are you using the Triton container or did you build it yourself?
Built myself (clients only)
To Reproduce

Build the clients following the guide here.
Then run pip install tensorrtserver-1.13.0.dev0-py3-none-win_amd64.whl from the build/trtis-clients/install/python directory.
Then, in a command prompt, run:

> python
>>> import tensorrtserver.api

Describe the models (framework, inputs, outputs), ideally include the model configuration file (if using an ensemble include the model configuration file for that as well).
N/A
Expected behavior
Successful import of tensorrtserver.

Sorry that the windows client is so broken. We will improve our test coverage. Can you try applying #1461 before building to see if it fixes your problem.

@deadeyegoodwin
You're good. I completely understand these issues. I'm not bothered at all.
Would I be correct in assuming you are porting from Linux to Windows instead of rebuilding from scratch?

And thank you for the timely fixes, I appreciate it. I'll let you know if I encounter further issues.

The windows version of the python client was done after the linux version, and both versions use a C/C++ shared library for some functionality. With the upcoming version 2 of the clients (can read about it in the Roadmap section of the README) the python client should be much easier to build/use on different platforms because it will be pure python (with an exception for shared-memory support).

I was able to successfully build, install and run the clients with the changes made in #1461. I got an error message from image_client.py (Exception: expecting 1 output, got 3) which is expected as I have an object detection model currently loaded on the server.
This tells me that everything up until sending the inference request is working. I'll give a better update when I am at my workstation tomorrow morning.
Thank you again for your hard work @deadeyegoodwin (and whoever helped with this issue)!

Sorry for the wait. Can confirm #1461 did fix my issue and has not caused any further issues. I successfully ran 10 tests on my end using my own images and got accurate results back in optimal time.
Closing now.


Fixed linker error in OSX for module sfm

Please remove unnecessary merge commits.

Oh, sorry. How do I do that?

git rebase -i upstream/master (or in your case this may work: git rebase -i Itseez/master).
Leave only 1 line with required commit (possible there is already 1 line, so nothing to edit here)
Save changes.
git push -f origin master to update source branch

I did as you said, and it sold me that the rebase was successful. But even with push -f git tells me that everything is up to date.

It is strange, try git rebase -i HEAD~3

BTW, there is also similar thing with GLOG_LIBRARIES. I believe it also should be moved out of "if" and placed near GFLAGS_LIBRARIES fallback.

You're probably right

Hehe after changing that running the rebase routine again, it worked :)
Thanks

:+1:


[DRAFT][Closes #30]  HTTP retrying

A draft of closing Issue #30. 5 HTTP retries before failing and calling panic!()

@tfanelli-rh Also, please take care in writing your commit messages. There are a few characteristics that make up a great commit message that other developers will find useful when reviewing your code or checking the history of the repository.


Tablerulesets can be specified from a YAML source

Current, tablerulesets are defined using a python-dict notation:
manyrules = TableRuleset([
  { 'if': ['not weekend'],
    'then' : ['fare * 1'],
    'target' : ['fare'],
  },
  { 'if': ['not sunday'],
    'then' : ['fare * 1.5'],
    'target' : ['fare'],
  }
])

The goal is to specify this in YAML:
ruleset: <name>
- rule: <name>
    if:
    - not weekend
    then:
    -  fare * 1
    target:
    -  fare
[...]

Basically the structures should match, if they don't, the JSON structure should be the one that counts, change the yml structure accordingly.
Expected behavior

Tablerulesets can be instantiated by a YML source. In particular, if the class definition contains a specs attribute (see #13), the tableruleset should take this as if it were specified as a dict in __init__.

Rules inside ruleset don't have names, so there's no use for "- rule: ". Same goes for for ruleset names (unless we plan to generate multiple TableRuleset's from a single YAML file, which I don't think is the case). So an example would be:
- if:
    - not weekend
  then:
    - fare * 1
  target:
    - fare
- if:
    - not sunday
  then:
    - fare * 1.5
  target:
    - fare

This gives the following python structure:
[{'if': ['not weekend'], 'target': ['fare'], 'then': ['fare * 1']},
 {'if': ['not sunday'], 'target': ['fare'], 'then': ['fare * 1.5']}]

Rules inside ruleset don't have names, so there's no use for "- rule: "

they don't, but they should. Think of a ruleset with 1000 rules -- untraceable without names. For rules other than those in table rulesets, the name is the class name. For tablerulesets we need to be able to give a name => rule:

Same goes for for ruleset names

Giving names to things makes it easier to debug. I know the engine only runs one rule set (but there is no limit to it running more than one at once, in principle).

Basically the structures should match, if they don't, the JSON yml structure should be the one that counts, change the JSON yml structure accordingly.

ok, that was the wrong way around. Appologies!


Operator implementations?

I'm working on time and duration.  I'd like to be able to do something like
duration = time1 - time2

however, it looks like operators are hard coded right now. Could that be defined as an interface to implement, like Comparable?
Ideally I'd like to be able to do
time2 = time1 + duration

So unlike CompareSameType, it would not require the two to be the same type.  The function would need to figure out the type and behave accordingly.

A user-defined type can participate in arithmetic and other binary operators by implementing the HasBinary interface.  (There's no counterpart for unary operators such as -x.)

Ahh, oops, missed that. Thanks!