Unexpected and slow interaction between #hashedLocations and #computeValidJumpDests

(This is extracted from a slow proof from the evm-semantics repository.)
This is simplified example where, simplifying #computeValidJumpDests and #hashedLocation in the same configuration takes much longer than simplifying either one of these functions by themselves (on the same inputs respectively).

enabled
time (min:sec)

both
7:30

just #computeValidJumpDests
0:36

just #hashedLocation
0:07

To build the file evm-simple.k run:
make build

To run the example proof tests/allowance-spec.k run:
make prove

Version info:
> kompile --version
K version:    5.1.64
Build date:   Tue Jun 15 22:32:32 UTC 2021

> kprove --version
K version:    5.1.64
Build date:   Tue Jun 15 22:32:32 UTC 2021

evm-simple.zip

We should first look at https://github.com/kframework/kore/issues/2757 to get a better understanding of #computeValidJumpDests by itself.

#2779 appears to have fixed this issue.


Exclude list item link that are buttons from link color override.

This is purely my point of view, but list items that are link-type buttons text color should not be overrided. I've ran multiple times to this problem when I try to create a list of buttons and all the time the text on the link is in the wrong color.

I agree that's incorrect. I think it's probably safe to use the :not(.ui). This is used elsewhere to avoid link stylings and is one of the nice side benefits of scoping elements to ui


android api level 34 SecurityException

Caused by: java.lang.SecurityException: Starting FGS with type mediaProjection callerApp=ProcessRecord{caf526f 20919:eu.vidavo.remotepatient/u0a196} targetSDK=34 requires permissions: all of the permissions allOf=true [android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION] any of the permissions allOf=false [android.permission.CAPTURE_VIDEO_OUTPUT, android:project_media]
Manifest
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_MEDIA_PROJECTION" />
<uses-permission android:name="android.permission.CAPTURE_VIDEO_OUTPUT" />
<uses-permission android:name="android:project_media" />

        <service
        android:name="org.jitsi.meet.sdk.ConnectionService"
        android:permission="android.permission.BIND_TELECOM_CONNECTION_SERVICE"
        android:foregroundServiceType="mediaProjection"
        android:exported="true">

        Any help?

same problem

+1

Please provide a reproducible example.

Please provide a reproducible example.

just try using this plugin on android api level 34
when joining a room  this exception will be fired

+1

Same issue, any solution?


plot a transcript with all transcripts as background

Hello,
I want to ask for a further skill on how to keep all the transcripts as background when I only plot a transcript. I tried plot the gene first, then plot a transcript, the figure shows mix figures, rather the gene as light background in the tutorial. If I only plot the transcript, after read the swan.p in, I cannot see the other transcripts in my plot. Thanks

Is this the sort of plot you're trying to make? Can you send me a screenshot of your output? Thanks!

Yes, exactly~ However, when I want to have other transcripts as background for one of my transcript, it looks as the second fig. Thank you

Whoa, yeah this doesn't look correct. Can you please send me the code you used starting from loading your SwanGraph up through the call that you made to produce the weird figure? Additionally, could you please tell me how and when you installed Swan?
As a side note, Swan has some "clever" code to try and prevent from having to recompute the plotted representation of a gene for which (as you've found out) not all cases are accounted for. A workaround that commonly fixes this in my experience is just reloading the SwanGraph and remaking the plot that's giving you trouble.

Hi, here is the code.
import swan_vis as swan
sg = swan.read('swan.p')
cmap = {'exon': '#003476'}
sg.set_plotting_colors(cmap)
sg.plot_graph('full_gene', indicate_novel=True)
sg.plot_transcript_path('PB.13560.539', indicate_novel=True)
swan.save_fig('figures/PB.13560.539.png')
I installed the swan around 2 months ago I think. I load miniconda module first, create conda environment, activate conda environment, then install swan_vis with pip... It's a sever at school...

One more question -- is 'full_gene' the gene that 'PB.13560.539' is from?

Hi, there are multiple transcripts of the 'full_gene', it's a single gene. 'PB.13560.539' is one of the transcripts. Thank you very much

I was unfortunately not able to reproduce your problem. However I did encounter some difficulty using Swan's save_fig function where I was getting blank figures. I was able to solve this by calling save_fig in the same Jupyter notebook cell as the plot that was produced (see this post where there is a comment mentioning that that's the case. Because of this I wanted to ask -- are you running Swan from a Python notebook? The command line? A script?
Additionally, I wanted to ask you to try providing the prefix argument to plot_transcript_path. This strategy should automatically generate a file name for your figure and save it which circumvents some of the issues I encountered using iPython notebooks. Please let me know if this works for you!

I use a small script as below, then sbatch it.
module load miniconda
conda activate swan
python Swan_visualization.py
In the Swan_visualization.py, I use swan.save_fig('figures/PB.13560.539.png') to save the figure.
I will try the prefix. Thank you so much, and good night


Testing

Introduce the testing structure and do tests for database interaction

Created basic testing
More in depth testing will have to be created for each function that requires more testing within the database wrapper

complete with #7


Use new LINQ Order() methods instead of OrderBy(static x => x)

PR Summary

Less code, a bit faster, less allocations.
Introduced in .NET 7 Preview 7
Docs for Order(IEnumerable) and Order(IEnumerable, IComparer)
Related dotnet/runtime PR and issue:
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

@microsoft-github-policy-service agree

@turbedi Please link to documentation for Order<T>(IEnumerable<T>) in the pull request description.

Added links to documentation to the related dotnet/runtime PR and issue.

@iSazonov Should we be caching IComparer<PSObject> objects, e.g. CommandNameComparer?

@xtqqczze We should investigate whether List<CommandInfo> _accumulatedResults can be of type IEnumerable<CommandInfo>, in order to avoid allocations.

@turbedi @xtqqczze I prefer to keep the PR simple and leave only the first commit.

@turbedi @xtqqczze I prefer to keep the PR simple and leave only the first commit.

Done

@iSazonov @turbedi Could you please push a commit addressing rewording of code comments.

@iSazonov @turbedi Could you please push a commit addressing rewording of code comments.

I don't see wrong comments, but you could try to reword them in follow PR.

I can do a follow-up PR to apply the code suggestions and to rename/remove related comments.

@daxian-dbw CommandPredictionTests doesn't work as expected 😕


v0.0.1 prep

Codecov Report

Merging #1 (14f68d4) into main (7fdbd9c) will decrease coverage by 1.16%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff            @@
##            main      #1      +/-   ##
========================================
- Coverage   9.58%   8.43%   -1.16%
========================================
  Files          5       5
  Lines         73      83      +10
========================================
  Hits           7       7
- Misses        65      75      +10
  Partials       1       1

Impacted Files
Coverage Δ

accessors_logger.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


${CMAKE_INSTALL_LIBDIR} not respected for *.pc files

*.pc files, similarly to libraries and cmake configuration files, should be installed in directory respecting ${CMAKE_INSTALL_LIBDIR} (which is /usr/lib64 on most 64-bit distributions) instead of hardcoded ${CMAKE_INSTALL_PREFIX}/lib.
Fix:
--- CMake/AbseilHelpers.cmake
+++ CMake/AbseilHelpers.cmake
@@ -181,7 +181,7 @@
 Libs: -L\${libdir} $<JOIN:${ABSL_CC_LIB_LINKOPTS}, > $<$<NOT:$<BOOL:${ABSL_CC_LIB_IS_INTERFACE}>>:-labsl_${_NAME}>\n\
 Cflags: -I\${includedir}${PC_CFLAGS}\n")
       INSTALL(FILES "${CMAKE_BINARY_DIR}/lib/pkgconfig/absl_${_NAME}.pc"
-              DESTINATION "${CMAKE_INSTALL_PREFIX}/lib/pkgconfig")
+              DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig")
     endif()
   endif()

Thanks for letting us know. I will patch this issue.


Use platform alloc & intrusive lists for managing MinMdns responders

Problem
We place an upper limit on number of fabrics supported for operational functionality by statically allocating some responders. this has several drawbacks:

we generally overallocate (6 fabrics currently)
we use platform::alloc anyway, so there should be no limit except if enforced internally and then it should be done at some 'advertise' level instead

Note that Responders are still limited and changing that will be done in a separate PR.
Part of #8000, however note that altough advertisers themselves can be created now, they will not be registered for 'response' until a followup PR is made.
Change overview
Create a intrusive list holder for advertiser allocators, use that instead.
Testing
ran minmdns server/client demo and it advertised
updated and ran unit tests
CI will heavily test commissioning and connecting side which exercises minmdns on linux.

Would you mind just opening a quick issue to track the discussion on whether a static/dynamic configurable pool would be workable here? It might not, but if we could replace the platform New with an option to have static allocation it might be beneficial for some platforms so they don't have to worry about running out of heap and being unable to support the required number of fabrics.


[codemod] Add private-imports for v5

The goal of this codemod is to convert all private imports to public. For example:

imports from @material-ui/core/styles

-import createTheme from "@material-ui/core/styles/createTheme";
+import { createTheme } from "@material-ui/core/styles";

imports from @material-ui/core/colors

-import yellow from "@material-ui/core/colors/yellow";
+import { yellow } from "@material-ui/core/colors";

Where this fails is in the private components under the components. For example:

import TableContext from '@material-ui/core/Table/TableContext';
import TabScrollButton from '@material-ui/core/Tabs/TabScrollButton';
import SwitchBase from '@material-ui/core/internal/SwitchBase';

None of these are exported from their parent directory, so the codemod basically breaks these imports. We have several options to fix this:

export these from their parent directory, so the codemod would correctly transform them
List them in the codemod to be ignored, so those imports would still stay the same
If we really think they should stay private, list that as Breaking changes and do nothing for them.

~I would go with Option 1 (will need a way to find all examples of this pattern)~
Will go with Option 2.

[x] TODO: handle the privates imports from 3.

Edit: I've added allow list for the internal components.

None of these are exported from their parent directory, so the codemod basically breaks these imports

They have always been private, AFAIK, I would almost advocate for removing the imports, but what we currently do, by ignoring them sounds great too.

They have always been private, AFAIK, I would almost advocate for removing the imports, but what we currently do, by ignoring them sounds great too.

The codemod is currently NOT ignoring them, but I could make a list of the imports we want to still support and they can be ignored.

Hmm, I tried running the codemod on a local project, but none of the imports were converted :\
npx https://pkg.csb.dev/mui-org/material-ui/commit/3a16144e/@material-ui/codemod v5.0.0/private-imports src

This is the content of one of the files there:
import * as React from 'react';
import { Button, Typography } from '@material-ui/core';
import yellow from '@material-ui/core/colors/yellow';
import createTheme from '@material-ui/core/styles/createTheme';

function App() {
  return (
    <div style={{ background: yellow[500]}}>
      <Button>Button</Button>
      <Typography>Typography</Typography>
    </div>
  );
}

export default App;

On the other hand the tests are passing.

@eps1lon I believe it is good to go now. I've basically just copied the optimal-imports and replaced /es/ with /modern/ in the paths.

@eps1lon I believe it is good to go now. I've basically just copied the optimal-imports and replaced /es/ with /modern/ in the paths.

It's still unclear from the PR description and name what this codemod is supposed to do. If this is just v4.0.0/optimal-imports then name it as such (v5.0.0/optimal-imports). But we don't want to touch private imports at all since we couldn't convert them anyway (otherwise they're not private).

It's still unclear from the PR description and name what this codemod is supposed to do. If this is just v4.0.0/optimal-imports then name it as such (v5.0.0/optimal-imports). But we don't want to touch private imports at all since we couldn't convert them anyway (otherwise they're not private).

We could rename it to optimal-imports, I've renamed it to private-imports because of https://github.com/mui-org/material-ui/pull/27321#discussion_r671132310

We could rename it to optimal-imports, I've renamed it to private-imports because of #27321 (comment)

I would ignore that statement since it is based on some false assumptions and statements that are missing context:

In v4, we have introduced a codemod https://github.com/mui-org/material-ui/blob/next/packages/material-ui-codemod/README.md#optimal-imports to migrate ALL these private import instances.

We do not migrate all: https://github.com/mui-org/material-ui/blob/4b128c53b895b863e5fd7c4069b53c1598203421/packages/material-ui-codemod/src/v4.0.0/optimal-imports.test/expected.js#L59-L61

optimal suggests that it's optional, it's not.

The same applies to the v4 version. The problem still stands that we can't codemod private imports. We could only remove these imports which would break the build (which makes the codemod not suitable for preset-safe). Instead, we should add a lint rule for path imports that has a fixer for those path imports that are available via public paths.
But that's probably out-of-scope. For now we just want the same implementation of optimal-imports so let's document it as such (PR descriptions are important). optimal-imports was not a good name, private-imports is just as much but these days "concerns" seem to matter more. If somebody feels strongly about their concerns we can go with either name since I don't think the naming matters.
The problem was that the PR description was incomplete so all I could go off was the name and the name was inaccurate.


Lighthouse fails on 11.3.0-plus1

11.3.0-plus1 fails with message about lighthouse.  The only addional option i've added was
--plugins.add /lighthouse
[2019-11-25 19:31:26] ERROR: Lighthouse could not test https://www.example.com/path please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: no known mark: lh:gather:afterPass:OptimizedImages
at Object.exports.stop (/lighthouse/node_modules/marky/lib/marky.cjs.js:76:13)
at Function.timeEnd (/lighthouse/node_modules/lighthouse-logger/index.js:128:11)
at Function.afterPass (/lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:407:11)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async Function.runPass (/lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:665:5)
at async Function.run (/lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:573:29)
at async Function._gatherArtifactsFromBrowser (/lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:215:23)
at async Function.run (/lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:81:21)
at async runLighthouse (/lighthouse/runAudit.js:33:19)
at async runAudit (/lighthouse/runAudit.js:61:19)
at async Object.processMessage (/lighthouse/index.js:148:22)

Hi! Can confirm that multi-URL lighthouse tests are not working
[2019-11-26 09:31:05] INFO: Start collecting Lighthouse result for https://www.sauto.cz iteration 1
[2019-11-26 09:31:05] INFO: Start collecting Lighthouse result for https://www.sauto.cz/inzerce/osobni iteration 1
[2019-11-26 09:31:05] INFO: Start collecting Lighthouse result for https://www.sauto.cz/detail-prodejce/aaa-auto/2 iteration 1
[2019-11-26 09:31:16] ERROR: Lighthouse could not test https://www.sauto.cz/detail-prodejce/aaa-auto/2 please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: no known mark: lh:gather:loadBlank
    at Object.exports.stop (/usr/src/plugin-lighthouse/node_modules/marky/lib/marky.cjs.js:76:13)
    at Function.timeEnd (/usr/src/plugin-lighthouse/node_modules/lighthouse-logger/index.js:128:11)
    at Function.loadBlank (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:45:9)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Function.runPass (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:632:5)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:573:29)
    at async Function._gatherArtifactsFromBrowser (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:215:23)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:81:21)
    at async runLighthouse (/usr/src/plugin-lighthouse/runAudit.js:35:19)
    at async runAudit (/usr/src/plugin-lighthouse/runAudit.js:64:19)
    at async Object.processMessage (/usr/src/plugin-lighthouse/index.js:148:22)
[2019-11-26 09:31:16] ERROR: TypeError: Cannot read property 'lhr' of undefined
    at Object.processMessage (/usr/src/plugin-lighthouse/index.js:199:28)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
[2019-11-26 09:31:16] ERROR: Lighthouse could not test https://www.sauto.cz please create an upstream issue: https://github.com/GoogleChrome/lighthouse/issues/new?template=Bug_report.md Error: no known mark: lh:gather:afterPass:Accessibility
    at Object.exports.stop (/usr/src/plugin-lighthouse/node_modules/marky/lib/marky.cjs.js:76:13)
    at Function.timeEnd (/usr/src/plugin-lighthouse/node_modules/lighthouse-logger/index.js:128:11)
    at Function.afterPass (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:407:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Function.runPass (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:665:5)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/gather/gather-runner.js:573:29)
    at async Function._gatherArtifactsFromBrowser (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:215:23)
    at async Function.run (/usr/src/plugin-lighthouse/node_modules/lighthouse/lighthouse-core/runner.js:81:21)
    at async runLighthouse (/usr/src/plugin-lighthouse/runAudit.js:35:19)
    at async runAudit (/usr/src/plugin-lighthouse/runAudit.js:64:19)
    at async Object.processMessage (/usr/src/plugin-lighthouse/index.js:148:22)
[2019-11-26 09:31:16] ERROR: TypeError: Cannot read property 'lhr' of undefined
    at Object.processMessage (/usr/src/plugin-lighthouse/index.js:199:28)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)

Note that only 2 out of 3 runs are failing and that might be due to the fact that all test are starting simultaneously.

Yes.  When I changed my script to run a single page, it passes with no issues.

Yeah this must have been introduced by https://github.com/sitespeedio/plugin-lighthouse/pull/36

Yeah the problem is that it tries to fire away multiple tests at the same time.

I've just pushed 11.4.0 that fixes that, but please verify that it works for you. I've missed adding a test case for multiple URLs in Travis, sorry.

verifying now.  should have an answer in 30 mins
On Tue, Nov 26, 2019 at 5:51 PM Peter Hedenskog<EMAIL_ADDRESS>wrote:

I've just pushed 11.4.0 that fixes that, but please verify that it works
for you. I've missed adding a test case for multiple URLs in Travis, sorry.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sitespeedio/plugin-lighthouse/issues/42?email_source=notifications&email_token=AAHZTSURGKSPBMO4YLGYTDDQVWR5TA5CNFSM4JRPJW6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHWKNA#issuecomment-558851380,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHZTSQHTR3H2MN2N5ZITM3QVWR5TANCNFSM4JRPJW6A
.

--
/khalid#

I think this works now.


Fix several issues with the local docker based cluster documentation.

cc @pwittrock

@pwittrock fixed the templates issue. This should be good to go..

would you publish the changes if you have not done so already?

@pwittrock All changes have been pushed. Github is rendering the diff incorrectly - https://github.com/kubernetes/kubernetes.github.io/pull/250/files#diff-5a22218f3795c88fddf5fdc0ff75453aL131

Have you pushed to http://vishh.github.io/docs/getting-started-guides/docker/?

Updated that now.
On Fri, Mar 25, 2016 at 4:50 PM, Phillip Wittrock<EMAIL_ADDRESS>wrote:

Have you pushed to
http://vishh.github.io/docs/getting-started-guides/docker/?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/250#issuecomment-201595162

Great, thanks guys :)


Proposal: Mirroring Support for Private Registries

Docker-DCO-1.1-Signed-off-by: Josh Hawn<EMAIL_ADDRESS>(github: jlhawn)

@SvenDowideit any chance of this getting merged soon?

(eg: people expected significantly better performance thanks to mirroring - which it failed to deliver in a number of cases, given perf issues are rather engine-side)

I disagree completely here, though sure there may be some performance issues on the Docker side, for those that are using docker across multiple regions pay a pretty big penalty in latency, throughput and cost for shipping images across continents. To avoid an incredibly confusing setup with multiple registries and having users push their image to multiple places and keeping it all in sync, it's easier to have a single master registry (at least without a lot of extra tooling) and that means systems running in multiple sites or regions pay the price of slower image pulls.
If the V2 protocol is coming along nicely, this can certainly be a consideration in that design, but why do we need to hold this change up? It's a pretty trivial change and this code is likely going to be removed or changed for V2 anyway?

@dmp42 Yes, there's a ton of speed problems.  This is just addressing one of them and believe me I'm fully aware that docker push and docker pull will still be glacially slow.  But at least now it'll be glacier-with-global-warming slow instead of fully frozen :P
This is about as trivial of a change as it gets - the registry-mirror option before only worked for mirrors of the public Docker registry, but now it works with private mirrors as well.  The change makes no new policy decisions about authentication, private content, or any other 'sensitive' items.  I even added documentation of the (already mostly existing) behavior which was previously undocumented!
I'm also not sure why you want a proposal at this point - this PR has been open for 2 months already and all a proposal will be is "Propose to do what this patch over here does."  At the very least hearing that feedback in November would be a lot less frustrating than hearing it now.
I'm sure the V2 registry will be great but do understand that we've already been waiting most of a year for any improvements to speed and an answer of 'just wait for the Next Great Thing' really leaves your users out in the cold :(

Sorry for butting in, can someone give me a quick explanation of what this PR provides that registry mirroring options didn't already? I'm a bit out of the loop I'm afraid.

@shin- They work together.  For example, the setup I want is:
central.company.com is our "source of truth" registry.
mirror-us.company.com
mirror-eu.company.com are mirrors of central via the mirroring options you indicate.
Then, the Docker clients are configured e.g.
--registry-mirror=mirror-us.company.com --registry-mirror=central.company.com for US instances, so they first try the local mirror but fall back to central if it is down or unavailable.

@shin- said:

Sorry for butting in, can someone give me a quick explanation of what this PR provides that registry mirroring options didn't already? I'm a bit out of the loop I'm afraid.

Currently, the mirroring options only allow you to mirror official repositories from index.docker.io. This PR allows mirroring outside of this condition.

@jlhawn FWIW You should be able to set mirroring.source to a private registry URL. But I do understand @stevenschlansker 's use case.
Thanks - as far as I can tell, this is not exclusive to or tied into registry v1, and the change is relatively trivial, so I see no reason to refuse it on those grounds.

@shin- said:

FWIW You should be able to set mirroring.source to a private registry URL

Yup, but the configured mirrors have been getting ignored when pulling a non-docker-hub image.

@tarnfeld

(eg: people expected significantly better performance thanks to mirroring - which it failed to deliver in a number of cases, given perf issues are rather engine-side)

I disagree completely here, though sure there may be some performance issues on the Docker side,

Please see https://github.com/docker/docker-registry/issues/785
@jlhawn

Yup, but the configured mirrors have been getting ignored when pulling a non-docker-hub image.

For a good reason. Private content / authnz do not work well / is unspecified with mirroring as it is designed right now.
Also raise considerations about the integrity of the namespace.
@shin-

there is no documentation (or support, see below) for private registries mirroring on docker-registry
it's largely untested (see Sven comment: "I'm assuming that @stevenschlansker has tested this PR")
behavior is unspecified with regard to authentication, private / public content, mirror chaining...
the security angle is unevaluated as far as I can tell (what happens if I bind to index.docker.io and prompt the user for their credentials? can I as a mirror gain access to private content?)
impact on the global namespace is unevaluated
this is tied into v1, and if this is merged, will have to be supported, no matter how good or bad its design is (meaning: it should be good)

I'm not opposed to this feature in itself - it just needs to be worked on further.
Fixing problems that people have is definitely a good thing - but quality is important too.
Hope that clarifies.

(eg: people expected significantly better performance thanks to mirroring - which it failed to deliver in a number of cases, given perf issues are rather engine-side)

I disagree completely here, though sure there may be some performance issues on the Docker side,

Please see docker/docker-registry#785

Well in the situation I was testing, I verified the client was hitting the primary registry, so we're talking about different issues. Also, the network you're operating in and across will hugely affect the behaviour, especially if the link to the primary registry is so drastically slow the speed difference is clear.

That said, I do agree with the statements about authentication.

Well in the situation I was testing, I verified the client was hitting the primary registry, so we're talking about different issues. Also, the network you're operating in and across will hugely affect the behaviour, especially if the link to the primary registry is so drastically slow the speed difference is clear.

@tarnfeld that person was hitting their mirror as well, and everything was configured like it should - still pulling from their mirror was not any faster than from the hub itself, for the reason I mentioned (lies in docker itself, see below).
The bottom-line being:

people with terrible links, like Sven, (X<1MB) will enjoy speed benefits from mirroring (from X up to 1MB)
people with a link that is able to deliver anything above 1MB/sec (and this is not much) will likely not enjoy any speed improvement

The good news is that speed improvements are being worked on, actively: https://github.com/docker/docker/pull/9720
About bandwidth, certainly, you can definitely save on that, there is no argument about that - I'm interested in knowing more about people usage on that front - how much bandwidth they push a month through their private registry? how much does that cost?

@dmp42 The behavior today is to only use mirrors instead of talking to the public registry, which is the only case that login credentials are relevant, and that behavior exists in the release today.  This change only allows mirroring of private registries, which don't interact with index.docker.io as you worry about.
That also brings up some scary implications, namely:

docker will send login credentials to servers which are not correctly signed as index.docker.io?
docker sends credentials in cleartext rather than some sort of challenge/response?!

Also, the administrator has to explicitly configure these mirrors on the docker daemon.  IMO it is therefore up to the administrator to ensure that their mirrors are protected well otherwise arbitrary content could be served anyway, aside from the worry about credentials.
As for the v1 vs v2 concerns, I'm happy to have this feature change / disappear / anything after the v2 registry is stable and usable and covers our use cases.

@tarnfeld that person was hitting their mirror as well, and everything was configured like it should - still pulling from their mirror was not any faster than from the hub itself, for the reason I mentioned (lies in docker itself, see below).

Sorry perhaps I didn't explain my point well enough. The testing I did resulted in the mirror never being hit and I verified the code path with verbose logging, the mirroring code never gets hit in the client hence why this fix is being proposed. The client always went to the primary registry directly regardless of the mirror configuration, because the code does not allow private registries to go via mirrors.

There is a lot of confusion here regarding what we call mirrors in the docker daemon, and what we call mirrors in the docker-registry code, which makes the conversation all the more difficult to follow.

as an anecdote :)
before the --registry-mirror code was released working, hub downloads of the golang image used up about 80% of my bandwidth quota for the preceding month or 2 (whenever we started using it for boot2docker - now, it is not quite irrelevant.
each fresh test of a boot2docker vm would re-download the docker project build images, which would take in the order of an hour, whereas now, its close enough to instant that i don't have time to make another coffee.
so I imagine for a distributed organisation using private registries for their internal workflows, the problem is just as big a deal.

Imagine that you deploy 800mb app (2 layers) 20-40 times a day to 150 machines daily. You deploy it from private registry and you also have mirror set up because docker hub is giving you images at 14kbps.
Right now workflow is:

Push image to local registry
Pull image from local registry on every node directly

With this change:

Push image to local registry
Pull image from local mirror, figure out that it's not there (images deployed once, why would it be there?), start mirroring in 150 parallel forks.
If that worked, pull image from mirror that is not a bit faster than local registry because it shares the same distributed storage backend.

Why do that? I don't see a reason to break existing behavior, since we cannot disable mirroring for local registries.
If you really need to mirror private registries — go ahead and set up caching nginx in front of your private registry, it is just highly cacheable http service after all. You have a solution. I don't see which solution do I have except "avoid docker upgrades before v2 registry is out".

Your "private mirror" could be replaced with nginx that only does caching (with locking) for layer files. Just point private registry domain to that nginx in every location. I fully understand you goals and desire to do that with registry itself.
My concern is that now we are breaking my existing setup without giving me an ability to fix it. I have 1gb link to my mirror and 1gb link to my registry.
[host] - 1gb -> [local registry] changes to [host] - 1gb -> [mirror] - 1gb -> [local registry].
Just let me have the old way without an extra hop. I'd love to see mirroring for private registries, but with the way to disable it for local ones.

@bobrik This is an optional configuration. A mirror is not required to be able to use a private registry, nor will it be with this change.

I fully understand you goals and desire to do that with registry itself.

This change has nothing to do with the actual registry, this is a configuration option in the docker client which allows you to tell it to point to the [mirror]. Without this, your example [host] - 1gb -> [mirror] - 1gb -> [local registry] is impossible.
Is your concern that you would like to use your registry as a mirror for index.docker.io BUT not for your own private images?

Is your concern that you would like to use your registry as a mirror for index.docker.io BUT not for your own private images?

Exactly. I want to use mirroring registry for index.docker.io and all private registries, except my own registry that cannot become faster with mirroring.

I see, that makes sense. Intriguing that you're using multiple private registries but that's a legit issue. @stevenschlansker any thoughts?

@bobrik @tarnfeld If your mirror has a mirror of public registry content but not your private registry, then when it fails to serve the image Docker will fall back to the 'real' private registry that you want it to read from.  So as long as your 'mirror of index.docker.io' registry does not mirror your actual content, the only regression here is that it must check once that the image is not there before doing the same pull as it always did.
Do you agree?

I agree. How do I do that?

A copy-edit and a minor question. Once those nits are picked, docs LGTM.

It looks like the merge of https://github.com/docker/docker/pull/8456 causes this entire patch to end up as a merge conflict.
It looks like that PR changes how mirrors are handled, without mentioning that fact at all in the description.  I did a brief read-through of #8456 but can't see how to resolve this patch against that one.  And I'm not terribly thrilled about rebasing this patch again.  Maybe someone who knows Docker better than I do will care enough to rebase.

@stevenschlansker
I'm a little confused right now, I don't see any code in this PR right now.  Did you remove those commits or what's up?
I'm sure someone else or one of the maintainers can rebase the PR for you.

@crosbymichael Yes, I removed the code commit for now because https://github.com/docker/docker/pull/8456 made it very different and now explicitly sets mirroring for the official "indexInfo" config. We'll have to rethink how to specify mirrors for private registries - probably a new CLI option on the daemon.

Docs LGTM

Closing this as it is now tracked on docker/distribution (I guess docker/distribution#19 is a good entrypoint).


Allow combined logical groups to generate working queries

Allow combined logical groups. I.e.:
filter=(name.givenName eq "Jane" OR name.givenName eq "Jaden") and (name.familyName co "avi" or name.familyName ew "ith")

Without this fix, the parser assumes it can't process a logical operation at the end of a group.
With this fix it produces the following SQL:
SELECT "mock_users".*
FROM "mock_users"
WHERE ("mock_users"."first_name" ILIKE 'Jane' OR "mock_users"."first_name" ILIKE 'Jaden')
    AND ("mock_users"."last_name" ILIKE '%avi%' OR "mock_users"."last_name" ILIKE '%ith')

@xjunior #61, #62, #65 and #66 now all merged and released as v2.5.0, then back-ported to V1 as v1.6.0. Thanks again for the contributions.


Cache API calls

Add caching of API calls to speed up and make less calls

I always appreciate your contribution 😃


modinfo: ERROR: Module hid_sensor_gyro_3d not found

Required Info

Camera Model
D435i

Operating System & Version
Ubuntu Mate armv7l

Kernel Version (Linux Only)
4.4.38

Platform
Raspberry Pi 3  ARMv7

SDK Version
2.0

Issue Description
Hi, I followed the instructions in the below link for installing Intel Realsense on Raspberry Pi 3 Model B: https://github.com/IntelRealSense/librealsense/blob/v2.20.0/doc/distribution_linux.md
However, I had two issues.

sudo apt-get install librealsense2-dkms"
This error came up:
"modinfo: ERROR: Module hid_sensor_gryo_3d not found
mod: hid_sensor_gryo_3d
modinfo: ERROR: Module hid_sensor_accel_3d not found
mod: hid_sensor_accel_3d"

sudo apt-get install librealsense2-utils"
This error came up:
"E: Unable to locate package librealsense2-utils"

Kindly assist.

@OOyindamola  hello,
The debian distribution currently supports X86 architecture PCs.
For ARM-based board check the Building from Source guide

Thanks a lot.
I reinstalled the Ubuntu Mate 64-bit Version and my kernel version is 4.15. I did not get the error from installing the librealsense2-dkms package as I had earlier but I was not able to install librealsense2-utils. The error is still "unable to locate package librealsense2-utils".
Kindly assist.

@OOyindamola, I'm not sure that I understand  which PC you're trying to install - is it ARM or X86 Based?
To deploy the debian installation on X86/X64 Debian you should follow this link.
The Non-debian/manual installation link is available in the previous reply.

At the moment instructions for getting librealsense on the Pi necessitate building the library from source, you cannot install the library via apt-get.


Zone 1/2 Heat Requested Shift limits are out of range

** Versions **

Home Assistant version (for instance 2023.9): 2024.1.2
This integration version (for instance 1.1.0): 1.5.1
Heat pump (if it matters): WH-MXC09J3E5 9 1ph T-CAP
HeishaMon version: 3.2.3

Describe the bug
I am using "Zone 1 Heat Requested Shift" (number.panasonic_heat_pump_main_z1_heat_request_temp) to control the house heating temperature, this has worked fine for months.  Unfortunately after upgrading from 1.4.6 to 1.5.1 the lower limit of both Zone 1 & 2 Heat Requested Shift seems to be 20C.  This is not ideal as I used to run it at 18C and my house has become too hot!
Rolling back to version 1.4.6 seems to fix this, albeit the maximum value is then 20*C. I rolled back a version at a time and can confirm the issue starts with version 1.4.7.
I know I should really be using the climate entity (climate.panasonic_heat_pump_main_z1_temp) for this, but this has never worked for me either.  Pressing the + or - to change the temperature just results in it trying to set it to 5*C no matter what the current temperature set point is.  It then just reverts back to what it was before.  Using "Zone 1/2 Heat Requested Shift" worked fine for me previously.  Not sure if this is just me or a wider issue as it's always been like that - I'm more than happy to try and provide any more info around the climate entity not working if required.
To Reproduce
Steps to reproduce the behavior:

Go to Integrations and find the Heat Pump indoor unit
Scroll down to 'Configuration' and find 'Aquarea Zone 1 Heat Requested Shift'
Try and set it to anything below 20*c
See error

Expected behavior
Allowable Zone 1/2 temperature range between 10*-30*C. I have confirmed this is the range the Panasonic indoor controller allows - on my unit at least

It looks like it's related to this pull request
https://github.com/kamaradclimber/heishamon-homeassistant/pull/170
I think something has gone wrong there as the Heat Requested Shift is being used for the flow temperature in whatever mode is being used there, so the main/max values are correct in 1.4.7 onwards. In the mode I am using, Heat Requested Shift is for room temperature so definitely doesn't want to be 20-60*C.

i think it soon will be fixed, Panasonic have couple of heating options with it's own temperature ranges.. so it's need to implement some changes (#167) .. after that i think it will be possible to better control thermostat.

Sorry for the bug and its impact. It's hopefully fixed in 1.5.2 of this integration


addSpecificOrientationListener only reports LANDSCAPE or PORTRAIT on Android

I noticed that there seems to be no code for LANDSCAPE-LEFT or LANDSCAPE-RIGHT for Android right now. Maybe it's worth mentioning in the docs?

Same problem for me on Android...


Fixed grammar mistakes in "3 simple ways to secure your websites applications" blog

Checklist

[X] You have read the Contribution Guidlines before creating this PR.
[X] You created a branch from dev branch
[X] Blog follows Blog Guidelines.
[X] Checked for all grammatical errors in the blog.
[X] Checked for any duplicate blog entry.
[X] You PR is raised on dev branch and not onmaster.

Description of change

Author Details for Blog Post Entry

@Kashya24 As this post does not follow our contribution guidelines as well changes your proposed might be what original author may not want. Hence this is not valid PR. Closing it due to #342


fix some etcd3 registry bugs.

What is the purpose of the change

service node may be lost at startup.
Separate push notifications and keepalive threads.

Verifying this change
ci passed.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #3632 into master will decrease coverage by 0.15%.
The diff coverage is 2%.

@@             Coverage Diff              @@
##             master    #3632      +/-   ##
============================================
- Coverage     63.99%   63.83%   -0.16%
  Complexity       71       71
============================================
  Files           700      700
  Lines         30684    30705      +21
  Branches       4973     4974       +1
============================================
- Hits          19636    19602      -34
- Misses         8788     8838      +50
- Partials       2260     2265       +5

Impacted Files
Coverage Δ
Complexity Δ

.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...c/main/java/org/apache/dubbo/common/Constants.java
93.33% <100%> (+0.47%)
0 <0> (ø)
:arrow_down:

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-13.05%)
0% <0%> (ø)

...ache/dubbo/remoting/transport/AbstractChannel.java
75% <0%> (-12.5%)
0% <0%> (ø)

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-10.53%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyServerHandler.java
61.9% <0%> (-9.53%)
0% <0%> (ø)

...onfig/spring/extension/SpringExtensionFactory.java
78.04% <0%> (-7.32%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65b589...d2998e6. Read the comment docs.


Rename j2objcBuildAllObjcLibraries to j2objcBuildAllLibraries

Rename j2objcBuildAllObjcLibraries to j2objcBuildAllLibraries
Capitalize Objective-C

Folder Structure

Alphabetical ordering
Indicate which are folders
Fix j2objcCycleFinder enable docs

@advayDev1, @confile - this should be straight forward

LGTM with above comments

I've fixed the issues you reported with the folder structure. It was just wrong.
Also clarified which are generated folders and what should be listed in .gitignore

@brunobowden  - important: this task is gone in #189.  it never made much sense to use anyway.  j2objcAssemble is the only client-relevant task in building libraries

Removed j2objcBuildAllLibraries from task list, leaving behind j2objcAssemble
I think this should be good to go now.

LGTM (just Fix conflicts with #189 )

fyi: You may wish to change your commit's title as it doesn't exist anymore

Fixed conflicts, reworded title and commit... finally time to merge


Some of museum like say WAM may not have timespan for Actor, though just birth location exists

I expected to see:
Optional {
crm:P4_has_time-span ?birth_timespan.
?birth_timespan a crm:E52_Time-Span;
crm:P82a_begin_of_the_begin ?earliest_birthdate;
crm:P82b_end_of_the_end ?latest_birthdate;
}
but instead I saw:
Its not optional
The current query was:
PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?display_birthdate ?earliest_birthdate ?latest_birthdate ?birth_location_class ?birth_location
WHERE {
<http://collection.britishmuseum.org/id/person-institution/70240> a crm:E39_Actor ;
    crm:P92i_was_brought_into_existence_by ?birth_event.
?birth_event a crm:E63_Beginning_of_Existence;
    crm:P4_has_time-span ?birth_timespan.
?birth_timespan a crm:E52_Time-Span;
      crm:P82a_begin_of_the_begin ?earliest_birthdate;
      crm:P82b_end_of_the_end ?latest_birthdate;
OPTIONAL { ?birth_timespan rdfs:label ?display_birthdate.}
OPTIONAL {
  ?birth_event crm:P7_took_place_at ?birth_location_class .
  OPTIONAL {
    ?birth_location_class a crm:E53_Place;
              rdfs:label ?birth_location.
  }
}

}

Hi David,
I also have  similar issue. For IMA actor data, we have only one of the value from P82a and P82b. In te query  on review site, we are checking for both the properties which is resulting in null values for actual birth/death date which is available as  rdfs:label under E52 timespan object.
Nilay

Got it.  I think I fixed this—let me know if it works?

(And to clarify ... the reason for E63 Beginning of Existence not E67 Birth, is that we don't know that the actor is a person ... it could be an organization or even a software agent, that are not "born")

Hi David,
There is still one issue. In updated query also you have put p82a and p82b in the same scope. As mentioned, ima actor data just has p82a and not p82b but it does have birth, death place and rdfs: label for birth/death date.
I think we need both of them in separate optional block.

A TimeSpan has to have both.  If there's only one date, then use it for both 82a and 82b.

OK then I will update the model


chore(Deps) dependency next to v14

This PR contains the following updates:

Package
Type
Update
Change

next (source)
dependencies
major
^13.0.6 -> ^14.0.0

Release Notes

vercel/next.js (next)
v14.1.4
Compare Source

[!NOTE]
This release is backporting bug fixes. It does not include all pending features/changes on canary.

Core Changes

Update React from 60a927d to 4b84f11 (#63476) @ztanner
fix revalidation issue with route handlers (#63213) @ztanner
ensure mpa navigations to the same URL work after restoring from bfcache (#63155) @ztanner
Ensure PromiseLikeOfReactNode is not included in .d.ts files (#63185) @timneutkens
Fix metadata url cases should not append with trailing slash (#63050) @huozhi
feat: add deploymentId config (#63198) @styfle
fix: bump<EMAIL_ADDRESS>(#61538) @styfle
fix x-forwarded-port header (#63303) @Ethan-Arrowood
fix: x-forwarded-port header is 'undefined' when no port in url (#60484) @yuvalotem

Test Changes

test: switch order of tests to avoid flakniess (#63482) @huozhi
fix broken create-next-app tests (#63019) @ztanner

v14.1.3
Compare Source
Core Changes

Upgrade to latest @edge-runtime packages: #62955
Fix output: export with custom distDir: #62064
Migrate locale redirect handling to router-server: #62606

Credits
Huge thanks to @ijjk
v14.1.2
Compare Source
Note: this is a backport release for critical bug fixes -- this does not include all pending features/changes on canary
Core Changes

Fix sitemap generateSitemaps support for string id (#61088)
Fix: generateSitemaps in production giving 404 (#62212)
Fix redirect under suspense boundary with basePath (#62597)
Fix: Add stricter check for "use server" exports (#62821)
ensure server action errors notify rejection handlers (#61588)
make router restore action resilient to a missing tree (#62098)
build: remove sentry from the externals list #61194
Reduce memory/cache overhead from over loader processing #62005

Credits
Huge thanks to @huozhi, @shuding, @Ethan-Arrowood, @styfle, @ijjk, @ztanner, @balazsorban44, @kdy1,  and @williamli for helping!
v14.1.1
Compare Source
Note: this is a backport release for critical bug fixes -- this does not include all pending features/changes on canary
Core Changes

Should not warn metadataBase missing if only absolute urls are present: https://github.com/vercel/next.js/pull/61898
Fix trailing slash for canonical url: https://github.com/vercel/next.js/pull/62109
Fix metadata json manifest convention: https://github.com/vercel/next.js/pull/62615
Improve the Server Actions SWC transform: https://github.com/vercel/next.js/pull/61001
Fix Server Reference being double registered: https://github.com/vercel/next.js/pull/61244
Improve the Server Actions SWC transform (part 2): https://github.com/vercel/next.js/pull/62052
Fix module-level Server Action creation with closure-closed values: https://github.com/vercel/next.js/pull/62437
Fix draft mode invariant: https://github.com/vercel/next.js/pull/62121
fix: babel usage with next/image: https://github.com/vercel/next.js/pull/61835
Fix next/server api alias for ESM pkg: https://github.com/vercel/next.js/pull/61721
Replace image optimizer IPC call with request handler: https://github.com/vercel/next.js/pull/61471
chore: refactor image optimization to separate external/internal urls: https://github.com/vercel/next.js/pull/61172
fix(image): warn when animated image is missing unoptimized prop: https://github.com/vercel/next.js/pull/61045
fix(build-output): show stack during CSR bailout warning: https://github.com/vercel/next.js/pull/62594
Fix extra swc optimizer applied to node_modules in browser layer: https://github.com/vercel/next.js/pull/62051
fix(next-swc): Detect exports.foo from cjs_finder: https://github.com/vercel/next.js/pull/61795
Fix attempted import error for react: https://github.com/vercel/next.js/pull/61791
Add stack trace to client rendering bailout error: https://github.com/vercel/next.js/pull/61200
fix router crash on revalidate + popstate: https://github.com/vercel/next.js/pull/62383
fix loading issue when navigating to page with async metadata: https://github.com/vercel/next.js/pull/61687
revert changes to process default routes at build: https://github.com/vercel/next.js/pull/61241
fix parallel route top-level catch-all normalization logic to support nested explicit (non-catchall) slot routes: https://github.com/vercel/next.js/pull/60776
Improve redirection handling: https://github.com/vercel/next.js/pull/62561
Simplify node/edge server chunking some: https://github.com/vercel/next.js/pull/62424

Credits
Huge thanks to @huozhi, @shuding, @Ethan-Arrowood, @styfle, @ijjk, @ztanner, @balazsorban44, @kdy1,  and @williamli for helping!
v14.1.0
Compare Source
Core Changes

Turbopack: switch to a single client components entrypoint: #59352
Update swc_core to v0.86.98 and turbopack: #59393
Fix cases for the optimize_server_react transform: #59390
Use new JSX transform: #56294
loading.tsx should have no effect on partial rendering when PPR is enabled: #59196
Update font data: #59426
Remove CacheNode.status field: #59472
Rename CacheNode.data → .lazyData : #59473
Generate Params Cleanup: #59431
Fix webpack chunks handling in traces: #59498
Rename CacheNode.subTreeData -> .rsc : #59491
fix NODE_OPTIONS=inspect: #59530
Add CacheNode.prefetchRsc field: #59537
allow passing wildcard domains in serverActions.allowedDomains: #59428
Page Info Cleanup: #59430
Fix force-static and fetch no-store cases: #59549
Should not show no index for client rendering bailout: #59531
Enable build worker by default: #59405
Fork navigateReducer into PPR and non-PPR versions: #59538
cleanup magic segment strings: #59552
chore: update Turbopack: #59589
Fix another magic segment string constant: #59591
Make CacheNodeSeedData match FlightRouterState more closely: #59590
transpilePackages should override default settings for external packages: #59385
move segment constants to separate file: #59587
Revert "Page Info Cleanup (#59430)": #59592
Fix useOptimistic in server components bug. Add tests for invalid React server APIs: #59621
Partial Pre Rendering Headers: #59447
Add tests for invalid React server APIs: #59622
Refactor setup-dev-bundler to make Turbopack/Webpack split clearer: #59650
refactor and simplify app dynamic components: #59658
Change manifestPath to pagesManifestPath: #59657
Fix issue with outputFileTracingExcludes and pages/api edge runtime: #59157
Update font data: #59722
Remove path normalization logic when uploading .next/trace traces: #59305
LayoutRouter: Support segment value of Promise to asynchronously bail out and trigger a server patch: #59724
fix: Allow start turbopack dev server for a project using middleware: #59759
fix: gracefully shutdown server: #59551
Revert "fix: gracefully shutdown server (#59551)": #59792
Optionally bundle legacy react-dom/server APIs based on usage: #59737
fix default handling in route groups that handle interception: #59752
Transpile all code on app browser layer: #59569
Initial implementation of PPR client navigations: #59725
fix(turbopack): prevent edge entrypoint from becoming an async module: #59818
Ensure we validate revalidate configs properly: #59822
Update error check in validateRevalidate: #59826
Rename confusing loaders: #59827
Upgrade og dependencies: #59541
[PPR Navs] Bugfix: Dynamic data never streams in if prefetch entry is stale: #59833
fix parallel catch-all route normalization: #59791
fix router prefetch cache key to work with route interception: #59861
Alias nextjs api entry to esm version for app router: #59852
Remove duplicate standalone check: #60085
Remove return on void function: #60087
Ensure NextBuildContext is only used during build: #60099
Add PageExtensions type: #60108
Ensure instrumentation file does not affect middleware count: #60102
Use WebpackError type instead of any: #60105
Remove root parameter: #60112
Remove extra duplicate pages warning: #60113
Add MappedPages type: #60106
Always call createPagesMapping for root paths: #60107
Fix path issues on linux machines when build created on windows: #60116
fix: Fix wrong cjs detection of auto-cjs pass: #60118
chore: update Copyright time from 2023 to 2024: #60071
Filter out duplicate paths in build output: #59858
chore: align webpack config node version: #59862
gracefully handle client router segment mismatches: #60141
Fix start build log being overwritten by logs from page: #60122
Allow using ESM pkg with custom incremental cache: #59863
Fix emitting ESM swc helpers for 3rd parties CJS libs in bundle: #60169
Move cacheDir logic to getCacheDir: #60133
Refactor to unify writeFile, readFile, and add readManifest: #60137
chore: bump<EMAIL_ADDRESS>#60172
fix: <Script> with beforeInteractive strategy ignores additional attributes in App Router: #59779
Fix invalid comment: #60182
Refactor: Separate RSC renderer from SSR wrapping component: #59676
fix: cache next font during development to avoid FOUC: #60175
Add writeManifest: #60138
Add writePrerenderManifest: #60158
Add writeStandaloneDirectory: #60162
Always write FunctionsConfigManifest: #60163
Upgrade @vercel/og: #60205
Improve consistency of issues and diagnostics for napi calls: #60198
Change server actions cache default to no-store: #60170
Allow undefined environment variables in config: #58247
Add writeFullyStaticExport: #60200
fix: Mark file as ESM if it has an export from auto-cjs pass: #60216
log a dev warning when a missing parallel slot results in a 404: #60186
Fix: Throw an error for empty array return in generateStaticParams with output:export: #57053
Ensure appPathsManifest variable is inside if block: #60210
Remove NEXT_TURBO_FILTER_PAGES internal variable: #60217
fix: add node-web-audio-api to server-external-packages.json: #60243
Disable 2mb limit for custom incrementalCacheHandler: #59976
[PPR Nav] Fix: Page data should always be applied: #60242
Add writeImagesManifest: #60209
feat(next-core): apply rsc transform in turbopack: #59629
Move buildId logic to getBuildId: #60132
fix catch-all route normalization for default parallel routes: #60240
micro fix of the cache limit check: #60249
parallel routes: fix @children slots: #60288
Bump webpack-bundle-analyzer: #58442
docs: Add docs for next dev --experimental-https: #60357
Update React from 0cdfef1 to f1039be: #60368
Simplify if condition: #60250
Fix dynamic sitemap detection: #60356
chore(font): enable minification: #60319
chore(precompile): remove obsolete precompiled assets : #60316
refactor: simplify the call in lib.picocolors: #60386
chore(precompile): re-add watchpack to the precompile: #60309
refactor(dev-overlay): remove chalk: #60317
Fix: HMR in multi-zone handling 🌱: #59471
HMR development stats: include updatedModules for App Router and Turbopack changes: #59785
Change color of output bundle size: #60385
Fix TypeError when using params in RootLayout with parallel routes: #60401
Fix missing source code display for some jsx errors: #60390
Refactor unstable_cache implementation: #60403
Missing Postpone Detection Fix: #59891
refactor(next/core): reorganize next.js custom transforms for next-swc/turbopack: #60400
Fix custom cache handler importing on windows: #60312
Display original failed fetch trace: #60274
feat(app-router): introduce experimental.missingSuspenseWithCSRBailout flag: #57642
update turbopack: #60208
update turbopack: #60478
feat(turbopack): support named client references properly: #59578
Fix intercepted segments with basepath: #60485
parallel routes: fix client reference manifest grouping for catch-all segments: #60482
Group small chunks in shared js section of output: #60479
filter default segments from prerender manifest: #60499
Add experimental options for more parallelization in webpack builds: #60177
move custom allocator flag and add rustls-tls comment: #60128
fix: redirect logic missing basePath in App Render: #60184
Revert "feat(app-router): introduce experimental.missingSuspenseWithCSRBailout flag": #60508
add retry logic to loadClientReferenceManifest: #56518
Turbopack hmr: record forwarded client spans: #60500
chore(turbopack): check for unsupported next config options instead of supported ones: #58781
Handle non server action post requests safely: #60526
Fix global-error for nested routes: #60539
chore(examples): use default prettier for examples/templates: #60530
Update default error rate for client filter: #60542
Enable windowHistorySupport by default: #60557
Fix logging order of build jobs: #60564
propagate notFound errors past a segment's error boundary: #60567
Tracing: attach Turbopack session value to root span: #60576
[PPR Nav] Fix flash of loading state during back/forward: #60578
Fix react-refresh for transpiled packages: #60563
Ensure client filter with basePath is correct: #60580
Update React from f1039be to 60a927d: #60619
Add cache reason for using fetch with noStore: #60630
chore: remove unused export: #60647
remove next build turbopack version: #60655
fix breakpoints on reload: #60507
Fix hmr updates with rebuilding for build errors: #60676
graceful shutdown: #60059
refactor(next-swc): remove unused crashreporter: #60593
chore(eslint-plugin-next): upgrade glob dependency: #60732
Fix client reference keys of barrel-optimized files: #60685
Fix recursive ignoring case in build traces: #60740
Telemetry: allow disabling of fetch tracing: #60588
chore: typo, responseCookes to responseCookies: #60654
Telemetry code load: #60594
allow to pass available chunk items when creating a chunk group: #60554
separate chunking per layout parts: #60569
feat(next-core): port remaining next.js custom transforms: #60498
Reapply "feat(app-router): introduce experimental.missingSuspenseWithCSRBailout flag" (#60508): #60751
Skip postcss config location resolving in node_modules: #60697
apply page transforms only on pages: #60779
fix layout segment key to match up with manifest: #60783
Fix locale domain public files check: #60749
Stabilize custom cache handlers and changing memory size.: #57953
feat: stabilize unstable_getImgProps() => getImageProps(): #60739
Fix Server Actions compiler bug: #60794
Dev Server: Preserve globals overwrites in the initialization hook: #60796
add missing function call to normalize-catchall-routes test case: #60777
Use snapshots for component-stack tests: #60768
Support next/og usage in ESM nextjs app: #60818
fix(ts): auto-complete next/headers: #60817
Remove the warning for build worker when custom webpack present: #60820
chore(deps): update browserslist and caniuse-lite: #60827
feat: support custom image loaders in turbopack: #60736
Ensure request specific caches for revalidate are reset: #60810
Add metrics names for unstable_cache: #60802
Fix: respect init.cache if fetch input is request instance: #60821
Revert "Fix: Throw an error for empty array return in generateStaticParams with output:export": #60831
turbopack: rename custom cache handler configs: #60828
dx: warn the deprecated cache configs are used: #60836
Enable missing suspense bailout by default: #60840

Documentation Changes

Docs: Update Server Actions Docs: #59080
Docs: Polish Server Actions Page 💅🏼 : #59400
Update 10-route-handlers.mdx: #59443
docs: remove broken link: #59487
Docs: Add App Router Testing Guides and update /examples: #59268
docs: fix bad closed tag: #59575
Fix closing tags for jest docs: #59579
Docs: Fix formatting in testing docs and update examples dependencies: #59572
Docs: Add missing closing tag: #59581
Docs: Review and update getServerSideProps page: #59545
docs: add note for environment variables on Vercel deployment: #59237
docs(accessibility): updates WCAG version to 2.2: #59646
docs: small tweaks: #59638
docs: fix broken backtick for link: #59717
Docs: Document generateSitemaps: #59626
Docs: Polish testing section: #59618
docs: improve docs around geolocation and IP headers: #59719
Docs: Review and Typo Fix - getServerSideProps: #59616
docs: fix vitest example link in testing with vitest: #59659
docs: fix grammar issue in 03-get-server-side-props.mdx: #59670
Includes section to @next/third-parties documentation for Google Analytics: #59671
Change file extension to .tsx: #59763
docs: clarify data fetching pattern: #59602
change 'themeColor' to 'viewport' in the viewport section: #59764
docs: add missing comma to sitemap.mdx: #59788
Chore docs fix runon and definition of trailing slash redirect: #59889
Minor grammar edits: #59887
Introduce cache version history in cache API: #59799
docs: correct type in sitemap.mdx: #59787
chore(docs): Remove typesafe-i18n from thrid-party i18n options: #59624
docs: Add Chakra UI setup guide: #59275
Update not-found.mdx: #59478
Updates references for styled-components configuration in next.config.js: #59495
Update 05-mdx.mdx: #57988
Mention remark-mdx-frontmatter in frontmatter docs: #59238
Docs: Rename React Query to TanStack Query: #59004
Add cwd to VSCode debugging setup steps: #58689
[Docs]: fix tiny typo: #59897
[docs] Add sensible name for Cookie deleting functions: #57893
Update generate-viewport.mdx: #57701
Update opengraph-image.mdx: #57810
[docs] Update example links.: #57891
docs: clarify setting and reading cookies from Route Handlers: #59915
docs: add Sirv loader for next/image: #57102
docs: fix prettier lint: #59918
docs: Add media example for icon metadata: #56141
Fix typo in generate-sitemaps.mdx docs: #59964
Update 02-server-actions-and-mutations.mdx: #59935
Update 08-parallel-routes.mdx: #59966
Updates "No Before Interactive" error message for App router: #56033
docs: Update Middleware docs on ignoring prefetches: #56799
docs: add note that contentlayer is unmaintained: #59927
docs: small changes to linking docs: #59982
docs: opengraph / twitter image needs absolute URL: #59985
docs: fix typo for useFormState: #60010
docs: clarify using redirect with client components: #60056
Update documentation to reflect added support for 'userScalable' field in 'viewport': #60033
docs: Add section for CSP without nonces: #60067
docs: update install count: #60072
docs: fix version history order in sitemap.mdx: #60054
docs: clarify generateStaticParams and dynamicParams: #60083
docs: update maxDuration info: #60086
docs: ⌘+Enter for forms: #60090
Clarify measurement ID in Optimizing: Third Party Libraries: #60136
Update 03-css-in-js.mdx : fix typo: #60114
docs: small wording fix for 03-linking-and-navigating.mdx: #60089
Docs: If revalidatePath's path has dynamic segment path, type must be page.: #59149
docs: improve grammar: #60149
Fix config code in the CSS-in-JS chapter: #60164
Updating example with required content type in header: #59990
Adds a section to Optimizing: Third Party Libraries on tracking pageviews for Google Analytics: #60176
Update route-segment-config.mdx: #60179
docs: Fix typo on generate-sitemaps.mdx: #60188
small correction in 11-middleware.mdx: #60189
docs(trailingSlashes): add note for SSG generation: #57628
docs: fix typos and broken links in the image.mdx: #60221
Docs: Fix revalidate type annotation: #60230
Update 02-server-actions-and-mutations.mdx: #60222
fix(docs): add missing docs on external packages: #60244
Docs: Add "Going to production" page for App Router: #59304
Docs: Update compression docs: #60264
Docs: Clarify useSearchParams behavior: #60257
Docs: Add more clarification about compress : #60268
Clarify searchParams is not passed to Layouts: #60277
docs(testing): add bun command to running your tests section: #60281
chore(docs): add section for Custom Type Declarations: #60282
docs: small corrections to bundle analyzer docs: #60285
docs: typo fix in compression page: #60318
docs: add example of webhooks with App Router: #60276
docs: add optional catch-all segments typescript example: #60237
Update use-search-params.mdx: #55357
docs: address a few open issues: #60329
docs: next/head: Document error cases with head/body-tags; add subheadings: #56412
Fix bundle analyzer NPM package name in documentation: #60339
[doc] Update 03-linking-and-navigating.mdx: #60345
add missing types: #60346
docs: update docs for remotePatterns to mention what happens when prop is omitted: #60387
Docs: Update note on @next/third-parties being experimental: #60372
chore(docs): fix 14 upgrade guide mentioning export: #60429
chore(docs/errors): Improve documentation grammar: #60452
Docs: Address Community Feedback: #60476
for #59178 - addition to robots.mdx - Customize user-agent rules: #60361
Docs: Document windowHistorySupport flag, and add pushState/replaceState examples: #60374
docs: correct windowHistorySupport title: #60503
chore: correct subject-verb conjugation in Client Components doc: #60538
Add "Redirecting" page in the Routing section: #60435
docs: small fix in Redirecting page: #60583
fix(mdx): update word order, fix typo: #60466
Add documentation for client router filter: #60585
docs: Update Google Analytics error doc: #60612
docs: remove Next 13 mention for App Router: #60632
Fix Typo in Testing Documentation Description: #60601
chore: remove duplicate package name: #60652
chore(docs): add docs for .svg unoptimized behavior: #60735
add authentication docs page: #60388
chore(docs): fix example documentation for Art Direction: #60823
docs: add build worker optout error back with upgrade advice: #60826
Docs: Use JS comment for MDX: #60825
Fix error from the auth docs.: #60829

Example Changes

Updates the with-vitest example. Unlocks the tests passing with server-only usage: #58902
Add text-wrap: balance to CNA template for card descriptions: #59384
fix: Invalid next version tag name in with-cypress example: #59647
Fix: Add matcher for middleware: #59651
examples: Add new NextAuth.js example: #56914
examples: add required env vars to auth example.: #59901
examples: update Redis to App Router: #59311
examples: remove broken deploy button: #58794
examples: progressive enhancement for Redis example: #59937
Update .env.local.example of with-firebase example: #59954
Upgrade with-algolia-react-instantsearch example to latest major version and use app router: #59961
Rename .env.local.example to .env.example: #59984
Update Convex Example: #59789
examples: Update next-forms example: #60052
chore(cms-contentfu): fix contentful instructions: #60050
examples: improve typings for i18n app dir: #60160
chore(examples): migrate image-component example to App Router: #60289
fix(#58695): improve zustand example: #58696
examples: add allow-unauthenticated option to cloud run deploy: #58792
fixed import path in with-jest template.: #60332
chore(examples): fix image-component example viewsource paths, shimmer page filename: #60451
Update cache-handler-redis example dependencies: #59458
examples: Update hello world: #60502
chore: Fix typo s/desireable/desirable/: #60518
chore: Fix multiple typos: #60531
examples: Update redis example with useOptimistic: #60596
Update README.md: #60595
chore(example): update storybook: #60737

Misc Changes

Revert "Skip latest commit check for stable release": #59401
ci(workflow): restore publish wasm binary: #59414
ci: only run release commit check on canary releases: #59423
test(runner): preserve browser tracing if test fails: #59469
Adding Google analytics to next/third-parties: #58418
ci(test): upload playwright artifacts seperately: #59496
fix integration test workflow: #59508
Fix third party typings: #59503
test(fixture): try to include sources in the snapshot: #59499
chore: bump typescript-eslint to 6.14: #59514
Update Deployment Testing: #59448
fix(playwright): teardown when global quit force terminates browser: #59548
chore(create-next-app): bump prompts to v2.4.2: #59006
types: cover the tests with root tsconfig.json: #59550
Fix test/tsconfig.json alias for internal test utils: #59570
test(integration): adjust fixture to work with turbopack: #59595
Add test for importing client components from server actions: #59615
chore: extends from shared base tsconfig: #59776
Update Turbopack test manifest: #59798
Fix CI: Skip test in PPR dev mode, too: #59817
Add unstable_cache validate test case: #59828
Update swc_core to v0.87.10: #59834
chore: add github bug report item type module resolution: #60121
chore: add myself to created-by: Next.js team: #60144
chore: include required Next.js stages to issue template: #60142
searchParameters test for PPR: #59678
Getting rid of a few TypeScript anys.: #60017
fix responsiveness in starter templates: #60140
fix(generators): update errors gen: #60233
chore: test against latest sharp: #60226
style: enforce prop immutability in new next app: #58845
Update flakey test from port re-use: #60291
chore: update pnpm to the latest (v8.14.0): #60295
docs: update broken link in UPGRADING.md: #60342
Update Turbopack test manifest: #60306
Update Turbopack test manifest: #60371
Update swc_core to v0.87.16: #60192
Add replay.io test suite dependencies: #60381
chore: update turbo to the latest: #60294
Update Turbopack test manifest: #60413
Update testing contributor guide: #60421
chore: skip flaky turbopack navigation test: #60431
ci: skip cron workflows on forks: #60422
Add reproduction for HMR moving  / renaming files.: #57230
add tests for incremental-cache: #60331
chore: fix postinstall when using tarball: #60443
test: use replay jest runner to add current test name to recording: #60438
misc: Skip cron workflows on forks: #60487
Handle pages double render for useParams in tests: #60486
Transition some check calls in tests to retry: #60489
Use next.config.mjs for CNA templates: #60494
Update Turbopack test manifest: #60504
run tests from test suite that are not listed in the manifest: #58401
Add --ci to jest tests in CI: #60432
Ensure aliased variable is used in test: #60428
Update Turbopack test manifest: #60506
Skip webpack loader test in Turbopack: #60509
Revert "Skip webpack loader test in Turbopack": #60513
Revert "Revert "Skip webpack loader test in Turbopack"": #60514
Remove unused target: es5 from tsconfig.json in create-next-app: #60521
refactor(cna): make create-next-app even smaller and faster: #58030
Expand hydration error test to check recovery: #60423
chore: update pull_request_approved workflow: #60537
chore: add issue_popular workflow: #60543
Update Turbopack test manifest: #60553
chore: update next-repo-info actions: #60559
chore(git): add .git-blame-ignore-revs: #60582
chore: remove pr_approved workflow & update popular_issues workflow: #60584
test(fixture): update assertion for turbopack: #60579
Remove duplicate pages -> app test: #60589
Update flakey dev middleware test: #60590
Add hasRedbox fix: #60522
Turbopack test updates: #60662
Remove normalizeSnapshot as it is no longer used: #60664
Stabilize flakey edge-module-error test: #60728
Update module-layer test for Turbopack: #60707
chore: bump nissuer: #60706
test(fixture): update assertion for turbopack: #60750
Update developing.md to include "Install Rust and Cargo" as 1st step: #60761
Fix tests exit race condition: #60757
Update ReactRefreshRegression test snapshot for Turbopack: #60767

Credits
Huge thanks to @delbaoliveira, @OlehDutchenko, @sokra, @huozhi, @shuding, @kwonoj, @ztanner, @eps1lon, [@acdlite](htt

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

🦙 MegaLinter status: ⚠ WARNING

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ ACTION
actionlint
1

0
0.02s

✅ COPYPASTE
jscpd
yes

no
1.15s

✅ CSS
stylelint
1
0
0
1.66s

✅ JAVASCRIPT
standard
1
0
0
1.66s

✅ JSON
eslint-plugin-jsonc
3
0
0
3.59s

✅ JSON
npm-package-json-lint
yes

no
0.72s

✅ JSON
prettier
3
0
0
0.35s

✅ JSON
v8r
3

0
10.31s

✅ MARKDOWN
markdownlint
8
0
0
0.57s

✅ MARKDOWN
markdown-link-check
8

0
1.61s

✅ MARKDOWN
markdown-table-formatter
8
0
0
0.26s

✅ REPOSITORY
gitleaks
yes

no
0.1s

✅ REPOSITORY
git_diff
yes

no
0.01s

✅ REPOSITORY
grype
yes

no
11.07s

✅ REPOSITORY
secretlint
yes

no
1.32s

⚠ REPOSITORY
trivy
yes

11
6.14s

✅ REPOSITORY
trivy-sbom
yes

no
1.94s

✅ YAML
prettier
3
1
0
1.62s

✅ YAML
v8r
3

0
5.25s

See detailed report in MegaLinter reports
MegaLinter is graciously provided by

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Fixes URLs for Docs viewed on Github

This patch fixes the links in the .docs markdown so that the docs work both when viewed through RTD as well as when viewed on Github.
This PR handles issue #336.

Hi @cantbewong & @clintonskitson,
Would you both please review the PRs docs on Github for broken URLs. Thanks!

Reviewed, LGTM

Changes Unknown when pulling c0bd53e9b3de289f09420faf5cf1b1508f744c0a on akutz:bugfix/doc-gh-url-fix into ** on emccode:master**.

Current coverage is 91.08%

Merging #337 into master will not affect coverage as of 7807dc1

@@            master    #337   diff @@
======================================
  Files            8       8
  Stmts          729     729
  Branches        14      14
  Methods          0       0
======================================
  Hit            664     664
  Partial         14      14
  Missed          51      51

Review entire Coverage Diff as of 7807dc1

Uncovered Suggestions

+1.37% via ...re/drivers_volume.go#183...192
+1.23% via ...re/drivers_volume.go#344...352
+0.96% via ...re/drivers_volume.go#220...226
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Failure to install in Integrations

Hi, I can't sign up to the forums on home assistant, as they're not accepting new accounts, so I hope it's okay to post here.
I have followed the instructions, and I am in Integrations and adding both the cloud and local Dyson as new integrations and I get this message:

This integration does not support configuration via the UI. If you followed this link from the Home Assistant website, make sure you run the latest version of Home Assistant.

I am running the latest version of HA as of today - Home Assistant Core 2022.5.3

I have the exact same issue when trying to install the cloud version. In the logs it was complaining that component dyson_local was missing. So I added it to hacs as well. Now when I try to add the integration I get the following error:
Logger: homeassistant.config_entries
Source: config_entries.py:745
First occurred: 15:08:39 (3 occurrences)
Last logged: 15:14:48

Error occurred loading configuration flow for integration dyson_cloud: cannot import name 'DysonPurifierHumidifyCoolFormaldehyde' from 'libdyson' (/usr/local/lib/python3.9/site-packages/libdyson/__init__.py)
Error occurred loading configuration flow for integration dyson_local: cannot import name 'DysonPurifierHumidifyCoolFormaldehyde' from 'libdyson' (/usr/local/lib/python3.9/site-packages/libdyson/__init__.py)

You should not install the cloud version, it is not maintained anymore. Please only use the local version. Uninstall the cloud and the local versions if you have both, and then reinstall the local version.


[Android] Cannot see controls

Updated to the latest version the other day, testing on Android, I am not seeing any player controls (controls is set to true in xml).

Any update on this? Seems like the onTouch event never fires.
this._android.setOnTouchListener(new android.view.View.OnTouchListener({
            get owner(): Video {
                return that.get();
            },
            onTouch: function (/* view, event */) {
                this.owner.toggleMediaControllerVisibility();
                return false;
            }
        }));

Haven't touched this in a while @manijak - I'm finding some more time here in the coming weeks so I'll circle back and fix issues on some plugins soon.

I am having an issue with the controls not showing also. Will fork and attempt to debug and fix.

Looks like the controls show properly when the video player is just in a stack layout. A complex hierarchy seems to make the controls not appear. Still testing on what exactly makes them disappear.

It appears that when the video player is in a modal the controls don't show. They might be behind the modal in the view stack?

Sounds like a layering issue. Testing this on Android I'm assuming?

Yep on android.

possibly adding a bringToFront() call on the player controls will fix it.

Okay, so yea likely a layering issue. Those are a pain to deal with, had some in the past on this plugin I think.

Yea at one time I think we even messed with the zIndex settings or something but it was temporary fix.

ill test it out

so this.mediaController.bringToFront(); did not seem to do it.

I was also curious why a native MediaPlayer was not used?

Check some of the history on the android source and you'll find some layer stuff we worked around long time ago. Might help some

will do

Sorry, disregard the MediaPlayer question. I just saw the TextureView at first.

So for sure the controls are there behind the modal, that is confirmed when the opacity of the modal page is set to 0.

Hey @markhatchell if you're on NS slack community you can hit me up with any questions and I can assist

We dont use the default controls on our project so we never tested that after switching to textureView

@bnussey Hey, I am not yet on the community, certainly want to join though!

@bnussey I can not seem to find the slack channel could you send me an invite please.

http://developer.telerik.com/wp-login.php?action=slack-invitation

hmmm...  The parent container is a cardview. The controls show the first time and after a few seconds they hide. Tapping on the videoplayer does nothing. So I can't pause/stop the video once it starts :)
Should say that initially my videoplayer is without a source. So when the view is loaded, there is no url set. It is set when the user is ready to play the video. This is on android, ios works like a charm.
PS. As I understand there is no fullscreen feature in the player?

Yea no full screen out of the box ☹

The controls are visible for me in the demo app on Android 5.1, 6.0 and 4.4.
@manijak care to share your layout, might help uncover what's happening.

I found out why that was happening in my app. I had a layout over the videoplayer, like a overlay, with image and play button. When the user taps it, it animates to 0 opacity and starts the video.
So when the user taps the video player, nothing happens. Had to add visibility=collapsed on the overlay, for the player controls to show up... This was not the case on iOS, therefore the confusion :)


Improve error handling

Fix error formatting and remove error swallowing to ensure underlying issues are surfaced to the console.

thanks for these improvements! appreciate it!


Update nock to v13

Which problem is this PR solving?
Update Nock to v13
Fixes #1303
Short description of the changes
Nock version was updated and the deprecated and unstable http.ClientRequest.abort() method was replaced with destroy(), to ensure the behavior of the tests was correct and stable.

what about replacing socketDelay in favour of delayConnection ?

@obecny I only saw two occurrences of socketDelay, which I've replaced.  If I am missing any, could you point them out?  Nothing else shows up in the project search feature of my editor.

@obecny I only saw two occurrences of socketDelay, which I've replaced. If I am missing any, could you point them out? Nothing else shows up in the project search feature of my editor.

hmm I somehow missed those changes, thought there were more :), thx

This is mergeable but I don't have permission to update the branch

@cole-easton Could you please rebase the branch so we can merge it ? (If possible allow us maintainers to edit your branch so we can it ourselves before merging it)

I still cannot merge this without permission to update your branch

@vmarchaud @dyladan Sorry for the delay.  I just rebased -- you should be able to merge now.

Rerunning tests to see if the browser test failure was a fluke. If not, you will need to fix the test.

Have you looked into the browser test failures?

@cole-easton can you fix the conflicts so this can be merged?

@cole-easton bump

Hi @dyladan - can you please re-assign this issue to @rltoSD so that these conflicts can be resolved and the PR can be completed. Thanks!

Hi @dyladan - can you please re-assign this issue to @rltoSD so that these conflicts can be resolved and the PR can be completed. Thanks!

I believe he need to comment on the issue/PR so we can assign it

@alolita i already did that at @2652

Closed in favor of #2652

Hi, can take over the issue!


Unable to open file h5py.h5f.open()

Hi there,
I'm facing an error when the training starts (deepinsight.train.run_from_path)

....

error:
OSError: Unable to open file (unable to lock file, errno = 35, error message = 'Resource temporarily unavailable')
I did change the tensorflow version in the "requirements.txt" when installing it
tensorflow==1.13.0-rc1
I'm not sure if that could be the issue.
Any insights?
Thanks in advance

Hi all,
solved it by restarting the kernel and changing the "fp_deepinsight" filename.


py35 tests failing

See https://github.com/dask/s3fs/pull/140
Presumably some upstream version change?

I can confirm that the test suite does pass on py35, for the set of package versions I have locally.


Update README.md

Remove the "platform" and "misc" directory from the source layout section
Fix markup for some command

Hi,
your commit is not signed thus the IP validation failed.
Regards,

For small changes / comment or readme changes, the IP validation is not necessary as far as I know, that's at least how other eclipse projects handle it. I edited the readme here on github, so can't validate.
Cheers, David


Disable some eslint rules.

Signed-off-by: Jérôme Benoit<EMAIL_ADDRESS>

Command line needed to merge, I just reported the fix myself in master-qa.
Then I close this issue.


Drivers.exti

select example ( https://github.com/eerimoq/pumbaa/blob/master/examples/select/main.py ) crashes on drivers.exti
how to reproduce :

import drivers
drivers.Exti

Traceback (most recent call last):
File "", line 1, in
AttributeError: 'module' object has no attribute 'Exti'

Which board do you have? The Exti driver is only implemented for ARduino Due and ESP8266, not the ESP32.

Yes, that makes sense, you are right.
Thank you.


Remove lelux.fi from the list

https://github.com/LittleCordines/hosts/blob/master/TorrentBlocklists
Note that lelux.fi is not a torrent site.
tracker.lelux.fi and tracker6.lelux.fi are opentracker instances, though. But they are not torrent sites either.

Also, torproject.org is not a torrent site either.
https://github.com/LittleCordines/hosts/blob/f9afc4eabbad826e1ad6a1766ffcd9ddc318505e/TorrentBlocklists#L21

...why would you block torrents anyway? you can't block them with a hosts file.

thanks for info. btw i just testing it. and yes its not working..


chore(main): release 1.4.6

:robot: I have created a release beep boop
1.4.6 (2024-11-20)
Bug Fixes

set the USER for the blsq image; remove g+w on the wrap_up.py & merge install.packages together (456febf)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

1.4.6
:sunflower:


Any way to force update the gradient?

Is there any way to forcefully update the gradient if I change the colours at runtime?

Hi,
There is no method in UI gradient to update the gradient but you can set the Graphic component(UI.Image  or UI.Text for example) dirty to force the update:
var graphics = GetComponent<Graphic>();
graphic.SetVerticesDirty();

Oh, thanks!


Add Styles.Attributes enum for common NSAttributedString attributes

Fixes #856.

One problem is that I’m about to replace a lot of the fonts with the new TextStyle type from the StyledText framework. The problem with fonts is they store a size, so dynamic content size changes won’t work (size has to change, this font has to change).
Sent with GitHawk

@rnystrom Ok, so should I abandon this for now, until the fonts are replaced?

Ya let's hold off on this until some of the foundational text refactors are wrapped up.


Upgrade nodejs rules

Please replace every line in curly brackets ( { like this } ) with an appropriate description, and remove this line.
What is the goal of this PR?
{ Please describe the goal of this PR, why they are valuable to achieve, and reference the related GitHub issues. }
What are the changes implemented in this PR?
{ Please explain what you implemented, why your changes are the best way to achieve the goal(s) above, and reference the GitHub issues to be automatically closed, such like 'closes #number'. }

Included in #107


Trac Login pass with any username/password

Hi, Your project is awesome and very helpful but I'm having this bug:
The only admin user is trac_admin that's ok. The problem is that in login page, if I type trac_admin as username and type any password (even with an empty password) trac logins successfully. The default password is: passw0rd but it enters with whatever you type in. I hope you can help me. Thanks!

After some research, I found the problem.
First you need to enable TracAccountManager plugin.
Then in admin > account > configuration:
Set HtPasswdStore with  filename: /trac/.htpasswd and hash_type:  md5
also, HttpAuthStore with auth_url: /authFile


D:login

@microsoft-github-policy-service agree [company="{EMMASADVENTURES}"]

Hi @milkgod773 ,
This PR is not valid. We'll close it. Please create a valid one with a meaningful title and description. Thanks.

@microsoft-github-policy-service agree
On Mon, Jul 3, 2023 at 3:58 PM Yan Xu @.***> wrote:

Closed #338 https://github.com/Azure/login/pull/338.
—
Reply to this email directly, view it on GitHub
https://github.com/Azure/login/pull/338#event-9715815890, or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAICGNIYFFVIBDIOVCY2FUTXON2ENANCNFSM6AAAAAAZUXE5ZI
.
You are receiving this because you were mentioned.Message ID:
@.***>