ignore 1st column in lime tabular explainer

Is there a way i can ignore the 1st column without dropping it from data from lime tabular explainer and use just remaining columns in analysis.

If you don't want the first column to be perturbed, you can write a custom __data_inverse (see here), or write a hacked prediction function (probably easier). Assuming x is the instance you want to explain, pp_fn is the predict_proba function, and explainer is a LimeTabularExplainer which was initialized with data that does not contain the first column:
def explain_without_first(x, pp_fn, explainer, **kwargs):
  first = x[0]
  # remove first column from x
  x = x[1:]
  def new_pp(xs):
    n = xs.shape[0]
    firstcol = np.repeat(first, n).reshape(-1, 1)
    # adds the original value back before predicting
    xs = np.hstack((firstcol, xs))
    return pp_fn(xs)
  return explainer.explain_instance(x, new_pp, **kwargs)


docs(spec/readme.md) fix typos and rename to README.md

Summary
Fixed typos and simplified sentences.
Full changelog

Fix typos and simplify sentences.
Rename readme.md to README.md

Note: The failing test is the same one as in the master branch (2350e1a). This PR only involves typo fixes and file renaming.

@thehanimo Merged, thank you!!


Remove  and update docs

Also removed a few leftovers from <OrthographicCamera>

@grischaerbe I addressed most of the review comments and updated the branch with upstream, if you want to take another look.


"Zuvelcați" is listed in the drop-down menu

Description:
"Zuvelcați" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Zuvelcați" in the search bar.

Expected results
The location is listed in the drop-down menu as "Zuvelcați, Argeș (Bârla)".


Add Korean

Fixes Or Enhances
Make sure that you've checked the boxes below before you submit PR:

[ ] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Thanks for the PR, the code isn't compiling though, I think because of an errand character here https://github.com/go-playground/validator/blob/0acfe6f4fb7d31a1ef6525abf44a8504c9354154/translations/ko/ko.go#L1175

Korean translation. Error fixed

translation: "{0}는 올바른 ISBN 번호여야 합니다".,
to
translation: "{0}는 올바른 ISBN 번호여야 합니다.",

The ko_test.go file has also been modified in the same way.


Feature: add support for an http logger

Add an option to support including a remote logging handler to the initialize_logging utility for users who have a HTTP POST service running and capable of receiving logging information for storage, analysis, ... Includes an example Handler.
For it to work, a URL must expose and accept POST requests, and handle the provided data.

Ready for another look @chamshop . Comments addressed. I believe the test is fixed on Windows too. Please confirm manually on this one test as CircleCI is having some issues.

Thanks for thre re-review. Let's review that other (fragile) test separately. Merging.


Error in gpio_install_isr_service() description

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for noticing this. I've cherry-picked it into our internal review & merge queue.

Thanks for the PR @sintech, it has been cherry-picked as 31de20a.


Demonstrate adding findsecbugs to spotbugs.

Demonstrate adding findsecbugs to spotbugs. This commit is a demonstration and is not intended to be merged as-is.
Findsecbugs reports several findings for this plugin, but all of them can be safely suppressed or reworked. There are a few that could be a concern, but examination shows that as currently used they do not introduce a vulnerability. The MD5 hash is not stored so it can be easily converted to a more reliable algorithm.
This also uses the exclude file for a couple of finding types that are fairly common in Jenkins but not considered a concern.

My plan is to add findsecbugs at the plugin pom after sufficient testing and communication. At that point, it would make sense to add the suppressions, but not the pom file changes from this PR.

@jeffret-b is this still valid

We don't need to leave it open. I'll close it.


Add Badge to OnePage Payment Label

Seller requested that we add an Amazon Payments badge to the label that appears in the radio button payment options in their OnePage checkout.


Fix for android 11

In Android 11 getView is deprecated and return null, i managed this to avoid the application crash

is this going in @EddyVerbruggen ?


Save documentation in ./docs directory

./elm-docs is a bit redundant and unclear.

I know we've talked about this on Slack, but I want to put this here as a reminder when we revisit this.
I like that elm-docs sticks out as an internal directory like node_modules and elm-stuff. But more important than that is the fact that it won't accidentally collide with repository directories.


Debian 10 has removed support for s390x

Debian 10 has removed support for s390x, therefore we should remove script support and data file for it.

Debian 10 is an old release with extremely limited support overall, so :+1: to removing it from the script.
We should also remove Fedora 37 and older (see: https://docs.fedoraproject.org/en-US/releases/eol/) and openSUSE Leap 15.3 and 15.4 (see: https://endoflife.date/opensuse).

@Princee215 Does removing script means removing from the data_files?
https://github.com/openmainframeproject/software-discovery-tool-data/tree/main/data_files

@Princee215 Does removing script means removing the json from the data_files? https://github.com/openmainframeproject/software-discovery-tool-data/tree/main/data_files

Yes, we should also remove them from the data repository.

@Princee215 Does removing script means removing the json from the data_files? https://github.com/openmainframeproject/software-discovery-tool-data/tree/main/data_files

Yes, Apurv that would do the same as @pleia2 suggested.


Update hub page to have correct name and link for components

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

index.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Move reused worflows to the "reusable" directory.

WIP
What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
[ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Closing this PR - I might have triggered some GitHub bugs.


VoidChannelPromise eats exceptions...

Expected behavior
voidPromise
ChannelPromise voidPromise()
Return a special ChannelPromise which can be reused for different operations.
It's only supported to use it for write(Object, ChannelPromise).

Be aware that the returned ChannelPromise will not support most operations and should only be used if you want to save an object allocation for every write operation.
You will not be able to detect if the operation was complete, only if it failed as the implementation will call ChannelPipeline.fireExceptionCaught(Throwable) in this case.

when writing a packet with a void promise, an exception should be thrown on failure.
Actual behavior
the exception is eaten and it's not forwarded to the channel pipeline
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
This is CLEARLY a Bug.
in this function https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java#L736
when exception is thrown the logic goes to here
https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java#L834
and...the exception is ignored.
If the promise is void, it should be forwarded to the pipeline as stated in the API...
cc @Scottmitch @normanmaurer
Netty version
4.1.9-FINAL
JVM version (e.g. java -version)
OS version (e.g. uname -a)

From 7beda8e105e05eb3b3c7e0c6b2f99a069370137f Mon Sep 17 00:00:00 2001
Date: Tue, 11 Apr 2017 17:34:36 +0200
Subject: [PATCH] Fix encoder exceptions being discarded when writing with a VoidPromise.

Motivation:

According to documentation of Channel#voidPromise(), if encoding of the message throws an exception, exception should be passed to the channel pipeline.
Unfortunately, that's not the case, which this commit fixes.
I've been ripping my hair out for hours trying to find out a memory leak without any clue.
There was an exception thrown in my handler which made the reason very obvious, but it was being silently discarded.
Fixes #6622

Modifications:

Fix the logic of notifyOutboundHandler to handle a case when the promise is not void.

Result:

Encoder exceptions will be properly propagated to the pipeline when used with void promise, in accordance to javadocs of Channel#voidPromise()
---
 transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java | 2 ++
 1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
index 55e596f..d138307 100644
--- a/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
+++ b/transport/src/main/java/io/netty/channel/AbstractChannelHandlerContext.java
@@ -834,6 +834,8 @@ abstract class AbstractChannelHandlerContext extends DefaultAttributeMap
     private static void notifyOutboundHandlerException(Throwable cause, ChannelPromise promise) {
         if (!(promise instanceof VoidChannelPromise)) {
             PromiseNotificationUtil.tryFailure(promise, cause, logger);
+        } else {
+            invokeExceptionCaught(t);
         }
     }

--
libgit2 0.24.0

@normanmaurer could you take a look at this patch :)

@ninja- yes this is clearly a bug... Your fix is not 100 % correct as it not handles all the cases tho. Please check https://github.com/netty/netty/pull/6634 for a full fix.  Thanks for reporting!

Thanks! Would you mind explaining which case I would miss with my version of the fix :)?

@ninja- the problem in the ChannelOutboundBuffer and also it would not start at the head of the pipeline

I've been pretty confident that I chose the function that starts propagation at the head...But OK thanks :)

Fixed by https://github.com/netty/netty/pull/6634


Imports for data types.

It would be nice to have a import 'whatnot' show ClassImInterestedIn for each data types in our docs. Right now, it's not always so easy to figure what you need to import.

dartdoc has this information.  We should be able to generate it automatically.  /cc @devoncarew
It's currently displayed in the header.  For example, "Flutter > material > AppBar" on https://docs.flutter.io/flutter/material/AppBar-class.html .  But it's not obvious from that what import statement to type.

This seems like a bug which could/should be moved to dartdoc and closed?

This is https://github.com/dart-lang/dartdoc/issues/1251.


Update choco nuspec through ADO package pipeline

We should update version and url in sqlcmd.npspec  via the package pipeline.
Currently this needs to be modified manually.

We shouldn't need to update the nuspec file. We should be able to generate a nupkg with the proper version by parameterizing the script that calls pack


Use Textarea to gather Custom system message instead of alert modal.

From a UX perspective, alert inputs can be all over the place, but in my case, not good! This PR inlines the Custom systemMessage gathering.

[x] Use Textarea to gather Custom system message instead of alert modal.
[ ] Confirm that switching after already having started a chat works correctly for new inline "Custom" behavior.

Preview screenshot:

Great PR, thanks for contributing this. Much better UX!!!
Once set, the custom prompt can be edited in the conversation ("show system text" in the menu), but edits won't be persisted to disk or reused if you clear the chat. Looking for feedback (#35 ) on how to make any preset editable as well.


Enable archiving from agenda

closes #339
Needs some more testing. Looks to me like it may archive more than intended

[ ] docs
[ ] unit tests

it should work fine
It only does when the file where the headline to be archived is located is opened. Otherwise it will e.g. archive the whole top-level parent tree of a level three headline. Need to investigate

This line returns an empty string and consequently messes with the call to refile_file_headline_to_archive, I think

It only does when the file where the headline to be archived is located is opened. Otherwise it will e.g. archive the whole top-level parent tree of a level three headline

I can't reproduce this. Once you have reproducible steps let me know so I can take a look

create a test file:

* foo
** bar
*** heading to archive
    <2022-06-30>

nvim -u minimal_init.lua
<leader>oa     -- leader is mapped to
navigate to heading to archive
<leader>o$

Archiving the headline works, but at this point the whole parent tree of the headline in question is removed from the test file (leaving it empty in this case, but not necessarily). So far this always went up to the top-level parent heading

@kristijanhusak maybe I'm overlooking something, but we don't have unit tests for archiving yet, correct? Should we add some?

We don't have any. I'm always in for more tests. It was a bit tricky to add them, but if you figure out a way to do some testing around it, please do so.

Alright, then let's open an issue for that and handle it separately. Not sure when I get around to it.

Let's use org_agenda_archive instead of org_agenda_archive_subtree, to follow Emacs convention https://orgmode.org/manual/Agenda-Commands.html#:~:text=short %24 (-,org-agenda-archive,-)

Let's use org_agenda_archive instead of org_agenda_archive_subtree

done


Unexpected SafeQL crash when Database Server is not started

Describe the bug
SafeQL crashes with an internal error: when the Postgres database server is not started/running.
To Reproduce
Steps to reproduce the behavior:

Clone Project:

git clone https://github.com/Eprince-hub/safeql-simple-repro

Install dependencies
Check the database.ts file for the reported error

Expected behavior
SafeQL shouldn't crash but rather provide a useful error message. Right now, it only says Internal error:
Screenshots
If applicable, add screenshots to help explain your problem.

Video
https://github.com/ts-safeql/safeql/assets/74430629/a68abc5b-1156-4bc8-a13b-db8100d3c10c
Desktop (please complete the following information):

OS: macOS
PostgreSQL version 15.7
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Getting different results:
/.../safeql/demos/basic-migrations-raw/src/index.ts
  13:6  error  createdb: error: connection to server at "localhost" (<IP_ADDRESS>), port 5432 failed: Connection refused
        Is the server running on that host and accepting TCP/IP connections?
  @ts-safeql/check-sql
  23:6  error  Internal error: connect ECONNREFUSED <IP_ADDRESS>:5432                                                                                @ts-safeql/check-sql
  32:6  error  Internal error: connect ECONNREFUSED <IP_ADDRESS>:5432                                                                                @ts-safeql/check-sql

can you share a reproduction link?

@Newbie012
Thanks for the quick response, I created a repro for this issue, Issue updated accordingly
https://github.com/Eprince-hub/safeql-simple-repro


change the cadence-server image for the corresponding version

What changed?
cadence-server image in docker-compose-multiclusters.yml point to master insted the image of this version

Why?
Docker-compose for multicluster doesn't work properly until this fix

How did you test it?
In a local environment, following the guides in https://cadenceworkflow.io/docs/concepts/cross-dc-replication/

Potential risks
No

Release notes
No need for this simple case

Documentation Changes
No need for this simple case

Pull Request Test Coverage Report for Build d47e4147-9333-4ca3-aa16-25307790451c

0 of 0   changed or added relevant lines in 0 files are covered.
90 unchanged lines in 12 files lost coverage.
Overall coverage increased (+0.04%) to 60.492%

Files with Coverage Reduction
New Missed Lines
%

host/signalworkflowTest.go
1
95.49%

service/history/execution/mutable_state_task_refresher.go
1
74.4%

common/persistence/sql/common.go
2
48.65%

common/persistence/sql/sqlplugin/mysql/db.go
2
84.72%

common/persistence/sql/sqlVisibilityStore.go
2
61.66%

service/history/execution/mutable_state_builder.go
2
69.92%

common/persistence/dataManagerInterfaces.go
3
65.33%

common/task/fifoTaskScheduler.go
3
84.54%

service/history/task/transfer_standby_task_executor.go
4
90.42%

common/persistence/persistenceMetricClients.go
5
44.47%

Totals

Change from base Build d0fcff2f-2828-4b21-8230-7d5a4ba8e23d:
0.04%

Covered Lines:
90857

Relevant Lines:
150197

💛  - Coveralls


adding new things to improve mental health

The green theme calms the mood and brings peace but i would rather suggest to add some calming musics and making the website somewhat me time moment like we can add solo games here with the quiz section too and motivational quotes should be displayed with a slide of photos.
I would like to contribute in changing the themes and adding new features like calming music or self spa or linking solo games

@tarunsinghofficial can i get someone's help too as the task would take much time.


Update README.md

This is a few changes I have tried for. Give me a few more days. I have a lot of assignments to be completed.

I have done the changes. I am new to Open Source can you help me with understanding these messages.

I have also a doubt. I am a College Student from India. I face problems in Algorithms and Data Structures please advise me how to tackle this out.


Roll compensation becomes global?

Using the Ricoh Theta S which includes roll information, it appears Pannellum reads this and compensates... but only for the first picture, then uses that "correction" globally for subsequent loadScenes and hotspots.  Here's an example: http://bobwells.net/dorimckinney/muni/rolltest3.html
In the above link, the first image shown, "foyer" (roll of nearly 0) is displayed correctly, but clicking on "backyard" (image has a roll of -2.3 degrees), that image is not compensated. However, if the backyard scene is loaded first, then Pannellum compensates but applies that erroneous compensation to foyer.
The latest master branch (c268...) was used.  The behavior also manifests in the CDN version using just hotspots, only the first picture's roll is evaluated, example:
http://bobwells.net/dorimckinney/muni/rolltest4.html
The hotspot is toward the rear of the first image.
It appears config.ignoreGPanoXMP is always being set true causing the XMP data to be ignored.

I'm withdrawing this issue... if I put ignoreGPanoXMP as the initial config parameter (before default and individual scenes) the "problem" disappears. I "mistakenly" thought it could be  scene argument.

It's setting ignoreGPanoXMP to true because you're setting a parameter that's set by the metadata, northOffset. Since the XMP metadata is loaded after the scene settings, it would override any existing settings if applied, so it's disabled if any of the settings it sets are manually specified (haov, vaov, vOffset, or northOffset).
The part about the roll setting from the first image being used for all of them (if it's not specifically set by a later image) was a bug, which I just fixed in c649c83326c0b8a968c3491139bc95831f0c2c88.

While I can appreciate the logic of haov, vaov and vOffsetcausing XMP data to be ignored, I'm not quite as sure about why specifying northOffsetshould do the same. I haven't used the Ricoh Theta S that much, but I suspect the internal compass of the camera is much less reliable than say, the roll sensor.  In the short time I've used the camera, I've come to doubt the accuracy of the built-in compass; however, the roll sensor thus far has seemed quite accurate. I'm going to take some photos later today as an experiment/illustration.  Perhaps setting northOffset should simply cause the image's XMP compass data to be ignored, not the whole XMP packet.
And thanks for fixing the bug wherein the first image with XMP data overrode all other images.

I agree that the compass on the Theta S is pretty bad; if I remember correctly, it only reports the heading in 22.5 degree increments.
The reason the metadata is ignored is due to the internal architecture; otherwise, I'd only have it ignore the specific parameters that were set. The scene parameters are loaded when the transition is triggered; the metadata isn't processed until the image finishes loading. Since nothing keeps track of which parameters are specifically set and which are defaults, either all the metadata has to be used or none of it is.

Well, that does give some concern regarding images with roll <> 0 and compass errors… though I was unable to get the Theta’s compass to be inaccurate during my testing today. I hadn’t noticed the 22.5 degree resolution of the compass and couldn’t find that listed on the web, but it agrees with observations.
From: Matthew Petroff<EMAIL_ADDRESS>Sent: Wednesday, June 29, 2016 12:53 PM
To: mpetroff/pannellum<EMAIL_ADDRESS>Cc: Bob<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [mpetroff/pannellum] Roll compensation becomes global? (#181)
I agree that the compass on the Theta S is pretty bad; if I remember correctly, it only reports the heading in 22.5 degree increments.
The reason the metadata is ignored is due to the internal architecture; otherwise, I'd only have it ignore the specific parameters that were set. The scene parameters are loaded when the transition is triggered; the metadata isn't processed until the image finishes loading. Since nothing keeps track of which parameters are specifically set and which are defaults, either all the metadata has to be used or none of it is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/mpetroff/pannellum/issues/181#issuecomment-229468649 , or mute the thread https://github.com/notifications/unsubscribe/AA5CU_PVUK5d161x8bL2D1sGDB65TIeaks5qQsz-gaJpZM4JAm2w .  https://github.com/notifications/beacon/AA5CU_rcfIagO7nrEmTMYCSYzw89mtmkks5qQsz-gaJpZM4JAm2w.gif

Turns out to be not such a big deal... I need the roll information in the XMP, so I must have ignoreGPanoXMP be false. I've found I can use exiftools (or presumably any XMP editor) to fix the heading/compass data in the image (exiftools is a great command line tool). XMP data is not present in google street view panoids or in images after they've been edited with something like Windows Paint.

I changed things in 94024f7d343eedef9063e7f4ac3ae03b6ae997ca such that overriding individual XMP set parameters doesn't disable use of the rest of the metadata.

Thanks Matthew, as always... you're the best. When I have new photos with absent/incomplete/wrong XMP data, I'll give the update a test. Does specifying northOffsetno longer force ignoreGPanoZMP:true?

Correct.

I confirmed that northOffsetno longer forces ignoreGPanoXMP. Is there a way to specify on a per-scene basis, the image roll? I didn't see it in the edits. This might make a nice enhancement for images that contain no XMP data (ie, Google street view tiles). It can be worked around (editing image with exiftools for example), I'm simply curious. Otherwise, I'm comfortable closing the issue.

The horizon pitch and roll support were originally added to support Ricoh Theta images (the parameters are not part of Google's Photo Sphere XMP data specification), which is why they weren't configurable. Since they could be useful in other cases, I made them configurable in 234201ea41dd9e8fc948690ed371843379b8fcfb.


How to re-render data in grid?

Is it possibble to rerender data in datagrid? Im using provider with Consumer. Consumer is running but data doesn't change.
Consumer is embracing complete Plutogrid widget.

If Provider is used as the parent of PlutoGrid, the entire PlutoGrid is re-rendered, which is very inefficient.

I think that I tried stateManager.notifyListeners() but it didn't work. I will try it again.

Your example is a fragment and I can't run it.
I think there must be a minimum code that I can run to check it.

My example is about situation where I regulary fetch data from server by http request. When data are recieved then it is necessary to refresh PlutoGrid and there is my problem, because it is no possible to redraw data in PlutoGrid by Provider and its Consumer. My solution is using setState() and refresh all page with FutureBuilder now. But it would be great to have simple solution to redraw all PlutoGrid when we have another data during the time.

I also encountered this problem when refresh table with plutoGridStateManager.notifyListeners()
however, table can be refresh if
stateManager?.removeRows(stateManager.rows);
stateManager?.appendRows(buildRows(_finishedData));

Yes, I would like to have to update PlutoGrid without setState() too.
I use stateManager to change value but the cell UI only refresh when setState().
Anyway to circumvent this?

I also encountered this problem when refresh table with plutoGridStateManager.notifyListeners() however, table can be refresh if
stateManager!.removeRows(stateManager.rows);
stateManager!.appendRows(buildRows(dataMap));

It's kinda like notifyListeners won't map changed data to new rows.
#183 is a similar situation, but I don't think UniqueKey is a solution to this.

I will try that solution later. Maybe I will try solution with UniqueKey as well. Thank you.

i think if there override function to rebuild data grid will resovle this problem like syncfusion

Is there any update? It would be greate to have method for refreshing records in table.


cleanup and reorganize codegen compiler

With the Fragment codegen gone the current structure doesn't really make sense anymore.

The data model was simplified.
For the generators I've moved everything into the general codegen package. I've also updated
some names, the parts that are shared between activity and destination codegen are now generally
prefixed with Component since they relate to the generated component.
On the parser side there is now just KspParser and AnvilParser.

Current dependencies on/for this PR:

main

PR #636

PR #637   👈

PR #638

This stack of pull requests is managed by Graphite.


Incorrect Version of QDM Model Info File Updated to Handle QDM 5.4 Errata Changes

Hi @brynrhodes
The incorrect model info file version was updated with snapshot 1.3.2 to handle QDM 5.4 errata changes. Updates were made to the QDM 5.3 model info file, but they should have been made to the QDM 5.4 model info file.

Indeed, it looks like I applied to the wrong model info. I'll back the changes out and apply to the correct, and release a new version. Apologies for the mixup.

Note that based on discussions with the QDM Owner, we are also aligning on Id, rather than Identifier to avoid changing the existing model info. So prescriberId and dispenserId of type QDM.Id.

Included in release 1.3.3-SNAPSHOT


Arabic translation of Upper Intermediate Algorithm Scripting

[ ] Make a Person Incomplete
[ ] Map the Debris Incomplete
[ ] Pairwise

Closing in favor of https://github.com/FreeCodeCamp/TranslationExpansion/issues/28


⚠ Secret Website 3 has degraded performance

In 7d1ce3c, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 6209 ms

Resolved: Secret Website 3 performance has improved in 4eee80c.


Added Kessex

will search for more edge cases

things like battledepths would be a good shout, the eotn layout is all over the place

@franneck94 If you would like me to, I can help find more locations for you and send you a list in a word document or something? I could even help with the code if needed? I know that finding every location can be tiresome and all.

@franneck94 If you would like me to, I can help find more locations for you and send you a list in a word document or something? I could even help with the code if needed? I know that finding every location can be tiresome and all.

Send me on discord the list

@franneck94 If you would like me to, I can help find more locations for you and send you a list in a word document or something? I could even help with the code if needed? I know that finding every location can be tiresome and all.

You can post the list here.

@franneck94 If you would like me to, I can help find more locations for you and send you a list in a Word document or something. I could even help with the code if needed. I know that finding every location can be tiresome and all.

You can post the list here.

Sure thing, I will post a list together for you.

@BearsMan Have you already colected some examples?

@BearsMan Have you already colected some examples?

@franneck94 I haven't been able to get around to it. I
Will try and get it done today. May I ask? Which cases do you need?

@franneck94 Which map ID cases are needed I am on the game now and can sort it if you would like me to.

Regarding VQ i am done. I will maybe add a PR for Bountys in the future

thanks


Link RS doc in Deployment doc

Published at http://janetkuo.github.io/docs/user-guide/deployments/
@kubernetes/docs

cc @madhusudancs

Agreed, you gotta add that space. Then, we're ready to go here.

Fixed.


add release number to every log

This adds an internal release number to the raven handler. The release
number is added to what is sent to sentry unless something already is
present because a release number was sent via "context" or "extra".
An abstraction might be introduced somewhere to represent release number generators, so that different generators might be implemented, but I am not sure where, and I am also unsure whether such a class should be injected instead of the release number. In short, should it work like this :
$releaseNumberGenerator = new GitDescribeReleaseNumberGenerator();
$ravenHandler->setRelease($releaseNumberGenerator->generate());

or like this :
$ravenHandler->setReleaseGenerator($releaseNumberGenerator);
// the handler calls generate() internally

or if both things should be possible.
Finally, I named the internal variable "release" instead of "releaseNumber" because of what already existed, but I am ok to change that.

:+1

ping @Seldaek

Thanks


Proposal: Move to PSR-4?

Just a thought if anyone has any reason why Teapot shouldn't move to PSR-4? @localheinz any thoughts?

@shrikeh
Do you also want to flatten the directory structure, maybe?

Ha, never mind.


[Repeater] Fire pageChange event

I think I found a bug in the following event: pageChanged.fu.repeater
https://github.com/ExactTarget/fuelux/blob/3.7.x/js/repeater.js#L89-L91
I think it is only fired if the user changes the page using the so-called primaryPaging, but not if he uses the regular previous/next arrows. Also, these events should be documented in the documentation.
My JS skills are not good enough to provide a PR for this :(

I don't have a timeframe for fixing the bug, but we will update the repeater documentation soon. See #1324.


encrypt float numbers if possible

As an user, I want to encrypt float numbers. In that way, I will be able perform homomorphic operations for percentage calculations. This is already supported in multiplying a ciphertext with a known constant.
Logic for converting float to int: https://github.com/serengil/LightPHE/blob/master/lightphe/models/Ciphertext.py#L116
Where this logic should be used, too: https://github.com/serengil/LightPHE/blob/master/lightphe/init.py#L113
You may consider to move __convert_to_int to somewhere common

Closed with PR https://github.com/serengil/LightPHE/pull/10


Normal Vote

independent of the "mint vote" idea, enable onchain voting on the nounsvote.wtf client - could enforce that they have to add a reason with n minimum characters :)

yes want to do this, thanks @onnnnnnnion ! Thoughts @ethandaya ?

@onnnnnnnion one thing I'd like to have is a sort of re-vote-with reason. Vote with a quote of someone else's vote

Thinking we should have heroicon write icon, like a tweet button, up by connect wallet after you've connected. Pressing this show show a modal. There's a dropdown picker of the prop you want to vote on it. It should include all active props, minus what you've already voted on. Anyone can vote, not just nouns voter. Probably should show how many votes they're voting with? But we'd need to query snapshot for that. Want to make sure it has plenty of space on screen for long vote reasons, by default it should end with voted with voter.wtf or maybe sent from voter.wtf. On mobile probably take over whole screen like a tweet

Should useContractWrite from Wagmi. Will need to use wagmi generate to get a ts abi


CrazyEnvoy flare glowing

Describe the feature
option to make the flare item could glow like enchanted item or enchanted book
i use 1.20.6 purpur
exmaple:
glow: true // this option make the flare item glow
Other
its simple feature i have no screenshot or something for it

Added in 56de4de


⚠ Ixtanet SAT has degraded performance

In 2a0b1af, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20676 ms

Resolved: Ixtanet SAT performance has improved in 781b47d.


Freeze after Multi disappear/reappear

Hi,
I found today, that when the Multiplus disappears shortly (because settings update by VRM remote settings upload), the aggregate batteries driver just freezes its values. All other parts like SerialBatteries work normal.
Log (in UTC):
INFO:root:2023-03-19 07:58:44.612685: Max. charging voltage: 56.0V
INFO:root:2023-03-19 07:58:44.613781: Max. charging current: 21.0A Max. cell voltage: 3.279V
INFO:root:2023-03-19 07:58:44.614596: Max. dircharging current: 98.0A Min. cell voltage: 3.271V
ERROR:root:2023-03-19 09:43:01.669795: Victron current read error. Using BMS current and power instead.
INFO:dbusmonitor:com.victronenergy.vebus.ttyUSB2 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyUSB2, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyUSB2 has device instance 290
INFO:dbusmonitor:com.victronenergy.vebus.ttyUSB2 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:com.victronenergy.battery.ttyUSB1 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyUSB2, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyUSB2 has device instance 290
INFO:dbusmonitor:Found: com.victronenergy.battery.ttyUSB1, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.ttyUSB1 has device instance 3
INFO:dbusmonitor:com.victronenergy.vebus.ttyUSB2 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyUSB2, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyUSB2 has device instance 290
Data Monitoring (in UTC+1)

Remote Console: (all values updating, but not aggragate bat)

after a manual ./restart.sh its ok again.

Hello, I found the mistake. I'll make a new commit ASAP.

Please try. Thanks.

Please try without Smart Shunt. I don't have it and cannot test.

I unplugged the Smartshunt and removed it from the system in VRM.
After some minutes I forced a Multiplus reset by sending a new config. In the instance that the Multiplus disappears the AggregateBattery freezes its values in remote console.
This is the log:
INFO:root:2023-03-22 17:16:54.519274: Max. dircharging current: 0.0A; Min. cell voltage: 0.117V
INFO:root:2023-03-22 17:16:55.523458: Max. dircharging current: 140.0A; Min. cell voltage: 3.268V
INFO:dbusmonitor:com.victronenergy.battery.ttyUSB1 disappeared from the dbus. Removing it from our lists
INFO:root:2023-03-22 17:17:18.550437: Max. dircharging current: 0.0A; Min. cell voltage: 0.117V
INFO:root:2023-03-22 17:17:20.549922: Max. dircharging current: 140.0A; Min. cell voltage: 3.272V
INFO:root:2023-03-22 17:17:33.558515: Max. dircharging current: 0.0A; Min. cell voltage: 0.117V
INFO:root:2023-03-22 17:17:34.559231: Max. dircharging current: 140.0A; Min. cell voltage: 3.270V
INFO:root:2023-03-22 17:18:33.602991: Max. dircharging current: 0.0A; Min. cell voltage: -18.432V
INFO:root:2023-03-22 17:18:34.603059: Max. dircharging current: 140.0A; Min. cell voltage: 3.268V
INFO:root:2023-03-22 17:18:37.608634: Max. dircharging current: 0.0A; Min. cell voltage: 0.117V
INFO:root:2023-03-22 17:18:39.611544: Max. dircharging current: 140.0A; Min. cell voltage: 3.270V
INFO:root:2023-03-22 17:19:12.635970: Max. dircharging current: 0.0A; Min. cell voltage: -8.448V
INFO:root:2023-03-22 17:19:13.636879: Max. dircharging current: 140.0A; Min. cell voltage: 3.268V
ERROR:root:2023-03-22 17:20:09.681779: Victron current read error. Using BMS current and power instead.
INFO:dbusmonitor:com.victronenergy.vebus.ttyUSB2 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyUSB2, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyUSB2 has device instance 290
INFO:dbusmonitor:com.victronenergy.vebus.ttyUSB2 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:Found: com.victronenergy.vebus.ttyUSB2, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.vebus.ttyUSB2 has device instance 290
INFO:dbusmonitor:com.victronenergy.battery.ttyUSB4 disappeared from the dbus. Removing it from our lists
INFO:dbusmonitor:Found: com.victronenergy.battery.ttyUSB4, scanning and storing items
INFO:dbusmonitor:       com.victronenergy.battery.ttyUSB4 has device instance 1
What are these min cell voltage logs? Seems broken. I never see such values in the gui.

Hello, the minimum cell voltage you can see under AggregateBatteries->Details:

It is the minimum value of paths '/System/MinCellVoltage' of all battery instances.  Please check by dbus-spy.

broken values: I see them occasionally. The Daly driver is not so save implemented. I created a pull request with added checksum checks, but also this is not perfect. Not the fault of Aggregate Batteries anyhow
frozen values: since these changes and the use of a installer that created proper service links the system seems to work flawless. maybe the fact that I now don't restart it as often as in the begining of the project also helps ;-)

for me this is no problem any more. close it for now.


goplay extractor broken

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Belgium
Provide a description that is worded well enough to be understood
goplay.be now loads newer videos in a new format. (DASH MPD)
which means the current extractor is broken.
Extracted the following information so far;
curl -X POST https://pubads.g.doubleclick.net/ondemand/dash/content/2615619/vid/10150078534976527/streams

{
  "stream_id": "091f9127-c615-4354-9006-af3fb09ac261",
  "duration": 2687.64,
  "stream_type": "on_demand",
  "stream_manifest": "https://pubads.g.doubleclick.net/ondemand/dash/content/2615619/vid/10150078534976527/GRQ/streams/091f9127-c615-4354-9006-af3fb09ac261/manifest.mpd",
  "manifest_format": "dash",
  "time_events_url": "https://pubads.g.doubleclick.net/ondemand/dash/content/2615619/vid/10150078534976527/GRQ/streams/091f9127-c615-4354-9006-af3fb09ac261/time-events.json"
}

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['--verbose', '-o', '/media/data2/series/Big Brother/Season 3/%(series)s - S0%(season_number)sE%(episode_number)s.%(ext)s', '--no-hls-use-mpegts', '-u', 'PRIVATE', '-p', 'PRIVATE', '-N', '8', '-f', 'bestvideo+bestaudio', '--merge-output-format', 'mp4', 'https://www.goplay.be/video/big-brother/big-brother-s3/big-brother-s3-aflevering-32']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8 (No ANSI), error utf-8 (No ANSI), screen utf-8 (No ANSI)
[debug] yt-dlp version 2023.01.06 [6becd2508] (linux_exe)
[debug] Python 3.10.6 (CPython x86_64 64bit) - Linux-5.15.0-60-generic-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2
[debug] Optional libraries: Cryptodome-3.17, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, secretstorage-3.3.1, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1767 extractors
[GoPlay] Logging in
[GoPlay] Authenticating username
[GoPlay] Authenticating password
[GoPlay] Extracting URL: https://www.goplay.be/video/big-brother/big-brother-s3/big-brother-s3-aflevering-32
[GoPlay] big-brother-s3-aflevering-32: Downloading webpage
[GoPlay] 5bd06f78-6e20-439b-8d67-cfe152c0cd68: Downloading JSON metadata
ERROR: An extractor error has occurred. (caused by KeyError('manifestUrls')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp/extractor/common.py", line 693, in extract
  File "yt_dlp/extractor/goplay.py", line 83, in _real_extract
KeyError: 'manifestUrls'

Doesn't look like it's just newer videos - for example, I could download De Rechtbank S12E05 just fine last sunday using the "old" URL format, but S12E02 right now has the new format too.
Thanks for your investigation though, I thought I was going crazy.

@jeroenj do you have any insight?

@michaelarnauts @cnugteren do any of you have an idea how to fix this issue, since you were involved in older patches? De Mol is going to start again soon and I am desperate :(

Same for me, GoPlay moved over for some streams to the doubleclick service, where ads are injected directly in the stream. It's a totally different stream compared with the usual streams.
You might find more info when searching about https://pubads.g.doubleclick.net/ondemand/dash
Maybe there is another service that is using doubleclick that had some more documentation.

I haven't looked into this yet either. Since the GoPlay app now supports AirPlay I'm using that instead of downloading it first.

Currently receiving errors on https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/goplay.py#L83
I checked it and indeed the request returns no object with 'manifestUrls' key.
--
I checked the network tab and found a 'https://pubads.g.doubleclick.net/ondemand/dash/content/' url and when downloading that using yt-dlp it downloads a 1080p file but only the first 18-19min..

Currently receiving errors on https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/extractor/goplay.py#L83
I checked it and indeed the request returns no object with 'manifestUrls' key.
--
I checked the network tab and found a 'https://pubads.g.doubleclick.net/ondemand/dash/content/' url and when downloading that using yt-dlp it downloads a 1080p file but only the first 18-19min..

I noticed the same. As @b12e said, the audio and video is now split up in 3 parts, probably to have 2 blocks of ads in-between. There should be a way to download the 3 parts and then merge them, but I'm not that knowledgeable about ffmpeg and did not have time yet

you can download all parts according to the wiki:
yt-dlp -F <url to manifest> will give a list of all formats, each leading with a tag
yt-dlp -f <tag> <url to manifest> will download that specific video
The problem that I have is that I don't know how to select what audio file to download together with the video, so I have the wrong audio file stitched to the video unfortunately. I also don't know how to merge all video parts

I figured it out manually how to match the video + audio and indeed download every part. I guess stitching can be down using ffmpeg.. I can explain how I matched them on discord if you want, maybe someone can figure out how to do it automaticly and update the extractor

Would it be possible to explain it here? That way other people can also have a workaround and as you said, it might inspire people to write a workaround in the extractor

Thanks! Currently at work so I'll check myself later, much appreciated! How did you figure out what audio goes with what video?

I figured out how to merge the files successfully with the help of this stackoverflow article: first make a document with all names of the files that looks like this
$ cat mylist.txt
file '/path/to/file1'
file '/path/to/file2'
file '/path/to/file3'

and then execute the following ffmpeg commando
$ ffmpeg -f concat -safe 0 -i mylist.txt -c copy output.mp4

just tested the ffmpeg stitching works great :D
now someone has to automate it

As an alternative, you could concatenate the fragments list for all periods and have them downloaded by yt-dlp as a single file.
I made an update to the goplay extractor that does this. It works on the recent De Mol streams.
It's not ideal to do this at the goplay extractor level, I guess. I assume other sources with multi-period MPD streams will have the same problem, so it would be better if the MPD code could separate the periods (and perhaps merge them).

@alard thank you for your contribution, I tried automating the process above, but my python skills are “undefined”. JavaScript developer 😅

@alard tested it, it only downloaded 22min instead of the full 44min: tested using https://www.goplay.be/video/assisen/assisen-s1/assisen-s1-aflevering-6#autoplay

@KevinDenys what exactly did you do to download the files manually?

Then I downloaded them using
part1: yt-dlp -f qualityID+audioID part2: yt-dlp -f qualityID+audioID part3: yt-dlp -f qualityID+audioID

I want to try this too myself but isnt there a need for a url or reference to the files?

It looks like the linked PR is done. Is there something that needs to be tested still?

@azertyalex are there videos that aren't DRM protected on the site?

I went down the drm/widevine rabbit hole. I guess this is where it stops?

The DRM seems to be limited to some of the shows. Here are three links to different shows that still work (from a Dutch IP address):
https://www.goplay.be/video/de-mol/de-mol-s11/de-mol-s11-aflevering-1 (published last year)
https://www.goplay.be/video/achter-de-schermen/achter-de-schermen-s2/achter-de-schermen-s2-aflevering-7 (published this week)
https://www.goplay.be/video/de-tafel-van-gert/de-tafel-van-gert-s3/de-tafel-van-gert-s3-aflevering-20 (this week)
For @azertyalex's link, https://www.goplay.be/video/de-slimste-mens-ter-wereld/de-slimste-mens-ter-wereld-s21/de-slimste-mens-ter-wereld-s21-aflevering-4 , I do get the DRM warning listed above.

It's nice to see some videos that don't have drm.

I went down the drm/widevine rabbit hole. I guess this is where it stops?

It never stops.

This should now work. If you get any ffmpeg errors at the end, try a different ffmpeg version, such as the yt-dlp custom builds (see also #9262).


[PATCH] Support for Sony Ericsson Xperia (mini) pro

Here is the patch:
https://github.com/mmatuska/irssiconnectbot/commit/f67cd77994d467bbc398060343df8395361f7449

Pull Request here too. Thanks ;)


Make SFX for Hestmor Rolling In Flesh

Again, a fleshy surface made completely of meat and flesh.

So, we hear how her skin may squish against it.
And also, here's the rolling animation.

HestmorFleshRoll.zip
@vitormaduro

Feature done. Now Hestmor plays rolling sfx depending on the ground type (flesh or rock). Waiting for Vitormaduro approval :)

HestmorFleshRollQuieter.zip
@vitormaduro @Hhk187

@vitormaduro @Hhk187 if this was implemented, please close the issue.


Add custom styles

creating to show difference of custom styles without render functions

This is just an example PR to show the changes in https://github.com/caglardurmus/react-native-insta-story/pull/35


"multi" collectionFormat is generated as a simple CSV blocking the service

Hi, when generating the SDK client library for Azure Maps service it occurred that there are several instances when the server expects the array parameter to be repeated in the URL instead of concatenated with a comma as a delimiter. However even though the Swagger contains "collectionFormat": "multi" the generated code is just using simply AppendQueryDelimited<T> from Azure.Core.RequestUriBuilderExtensions that effectively treats the input array as a CSV.
My proposal is to extend RequestUriBuilderExtensions with AppendQueryMulti<T> that would iterate over the collection IEnumerable<T> and do the AppendQuery for each of the items together with the name of the parameter.
I also saw another Azure service that commented out the test case due to this lack of implementation: Azure.Search.Documents, so I believe that resolving this issue can help other service teams as well.
Swagger for Azure Maps PR
SDK for NET PR
Test in Azure.Search.Documents commented out

Python says it has test coverage on this, so we likely have tests in testserver already.

In m4 they used expanded true false not collectionFormat: multi

@chamons thanks for taking look at that. Can you clarify what is "m4" and what "expanded" means in your comment? Is there something we can use to achieve the expected result?

Sorry, I should have noted that those were reminder technical comments I left future me (or others) when we look at resolving this issues.
m4 is short for modelerfour and is part of the autorest core that autorest.csharp sits upon. The internal data model they send us does not use a  collectionFormat: multi like I expected but a boolean expanded true false.
I was also noting that autorest.python already has test coverage on this, so we can likely leverage the test swagger they submitted.
There isn't a way I know of resolving this without fixing the generator. Please let me know if this is blocking a service, and it'll be prioritized accordingly.

Thanks a ton, @chamons ! Let me get back once the priority is known.
Also: would it help if I opened a PR with the fix proposal or it's better to leave it for you?

@chamons: This has been addressed at #1529


Increment version for containerregistry releases

Increment package version after release of Azure.Containers.ContainerRegistry

/check-enforcer evaluate


Recommended new Power Platform baseline policy - Restrict the creation of Power Pages to administrators only.

💡 Summary
Microsoft in their review of Power Platform recommended adding a new Power Platform baseline policy that restricts the creation of Power Pages (websites) to admin users
This will restrict the creation of the Apps to users to the following roles.

Global Admin,
Power Platform Admin
Dynamic 365 Admin

This control currently can only be implemented via PowerShell i.e no GUI. This setting can be checked via ScubaGear as the cmdlet that retrieves this setting is already invoked in the Power Platform Provider.
Set-TenantSettings -RequestBody @{ "disablePortalsCreationByNonAdminUsers" = $false }

Question for CISA

Should we add this new policy to the Power Platform baseline?
Are there use cases where non-administrative users would want to create Power Pages?

This seems sensible, though I'm not sure we have enough data on operational impact to make a decision.  I suggest we include it as a SHOULD control.

at the SHOULD level


Add commands and tests for sensor calibration

When handling a drone fleet, it is useful to calibrate the drones from DroneKit's API without resorting to QGroundControl, which requires manual operation.
This is especially true for the calibrations which don't require any manual intervention (gyro, barometer, board level), since they can be carried out on the entire fleet in parallel.
In this PR, I added the support for the calibration of:

Magnetometer
Accelerometer
"Simple accelerometer" calibration
Barometer
Gyroscope
Board level

To test the commands, I developed a generic function able to listen to the COMMAND_ACK messages and to assert that a specific command has been ACKed.
The accelerometer calibrations are expected to return the MAV_RESULT_FAILED status, since in the SITL there's nobody moving the drone.
Still, it's useful to check the ACK status to make sure that the autopilot does not respond with an "unsupported" or "denied" status.
The magnetometer calibration is expected to return the MAV_RESULT_UNSUPPORTED status in the tests because the MAV_CMD_DO_START_MAG_CAL is not supported in APM Copter 3.3 (the current version of the SITL), however it is supported in the latest ArduPilot master.
PX4, on the other hand, handles the magnetometer calibration using the standard MAV_CMD_PREFLIGHT_CALIBRATION message, so I had to handle the two cases in Vehicle.calibrate_magnetometer().

Looks great. @peterbarker Is the right person to review this.
Just FMI, does a calibration "clear" existing settings when started - ie might you choose not to run an accelerometer calibration, because you could be clearing an already properly calibrated vehicle?

Yes, if you calibrate a vehicle the previous settings (e.g. accelerometer offset and scale parameters) are cleared and replaced.

Yes, if you calibrate a vehicle the previous settings (e.g. accelerometer offset and scale parameters) are cleared and replaced.

Thanks. So arguably you might choose not to do this "automatically" for acceleration because you wouldn't want to undo "possibly good" settings (at least without checking the current calibration state).

On Sun, 18 Nov 2018, Pietro De Nicolao wrote:

def calibrate_board_level(self):

On QGroundControl for PX4, the calibration is called "Level horizon". I'd
like to keep the "calibrate" in the method name.

You know the board may not be even close to level at that point, 'though?
ArduPilot supports dozens of board orientations - and I very much doubt
PX4 is different.

From what I know, that calibration tells the board which orientation corresponds to 0° roll, 0° pitch. Isn't it the same of saying "board level" (or better, "vehicle level")?

On Tue, 20 Nov 2018, Pietro De Nicolao wrote:

From what I know, that calibration tells the board which orientation
corresponds to 0° roll, 0° pitch. Isn't it the same of saying "board level"
(or better, "vehicle level")?

vehicle level should be appropriate (give or take tailsitters on some
autopilot systems, probably!).
Board level is not.  Some indication:
https://github.com/ardupilot/ardupilot/blob/master/libraries/AP_Math/vector3.cpp#L35
Several of my vehicles have their autopilots oriented upside down, for
example.

The functions here are a bit of a mis-mash, really. Some of the functions are done straight-away (e.g. the AHRS trimming, simple accel cal). Some of them require significant user interaction (e.g. the mag calibration.) Not saying they're not a good idea, just that there are multiple concepts/workflows involved in these and it might be worth considering that.

@peterbarker I think I've resolved all the other issues; how do we deal with this?
My user experience with API-initiated calibration is the following:

For the calibrations which do not require user interaction (gyro, vehicle level), I select all the drones in my application and run the calibration in parallel on all of them. STATUSTEXT messages and the beeping of the boards indicate the progress of the calibration.
For the calibrations which do require user interaction (accelerometer, magnetometer) I calibrate the drones one by one. This is still convenient as I don't have to open and connect QGroundControl to each drone, which is a time-consuming process. In this case I still rely on the aid of STATUSTEXT messages and beeps to know how to move the vehicle.

In this workflow, I think it's reasonable to have API methods to initiate the calibration. AFAIK there's no way, in MAVLink, to read the calibration progress other than parsing STATUSTEXT messages.

On Sat, 24 Nov 2018, Pietro De Nicolao wrote:

For the calibrations which do not require user interaction (gyro, vehicle level), I select all the drones in my application and run the calibration in
parallel on all of them. STATUSTEXT messages and the beeping of the boards indicate the progress of the calibration.

Just musing: the SkyViper production line had a very simple calibration
procedure which didn't require anything but putting the vehicle in a clamp
and pressing "go".  So it is possible to do things very smoothly :-)

For the calibrations which do require user interaction (accelerometer, magnetometer) I calibrate the drones one by one. This is still convenient as I
don't have to open and connect QGroundControl to each drone, which is a time-consuming process. In this case I still rely on the aid of STATUSTEXT
messages and beeps to know how to move the vehicle.

In this workflow, I think it's reasonable to have API methods to initiate the calibration. AFAIK there's no way, in MAVLink, to read the calibration
progress other than parsing STATUSTEXT messages.

I'm not familiar with PX4's calibration procedures, sorry :-)
In fact, it occurs to me that the magnetometer calibration in this PR is
not the way ArduPilot does things.  It's all on-board with
MAG_CAL_PROGRESS messages informing the GCS what's going on.

This PR has no support for tracking calibration progress, still the MAV_CMD_DO_START_MAG_CAL command looks like the correct way to initiate a magnetometer calibration on ArduPilot: https://github.com/ArduPilot/ardupilot/blob/027beb0dc1feb59d12e71ffeb4d9d07c09e37bd6/libraries/AP_Compass/AP_Compass_Calibration.cpp#L290

I see that in the ardupilotmega.xml dialect of MAVLink there are some commands specific to magnetometer calibration.
However, I have no idea how to correctly use them.
Do you think this PR is viable without the magnetometer calibration part?

@peterbarker Do you have an opinion on this?
My general answer to this sort of thing is "push it in as-is and revisit the other bits when you can get clarity".

Looking good.  I think I'll merge this as-is, 'though I'm not sure we're choosing the correct calibration routines for ArduPilot.


Not able to select elements in multiple select drop down

What is your Scenario?
Here is the select element with option groups

UI looks like this , can select multiple elements with CTRL

What is the Current behavior?
Not able to select any element in that dropdown
What is the Expected behavior?
Shall be able to select one or multiple elements using locators. I have tried with different locators

select[name ="campaignSites"]

Also tried typing text as mentioned in https://stackoverflow.com/questions/62932588/unable-to-select-drop-down-list-in-testcafe, but not working
What is your public website URL? (or attach your complete example)
Uploaded image as above
What is your TestCafe test code?
async function selectElementsByText(element: Selector, text: string): Promise {
//https://testcafe.io/documentation/402806/recipes/basics/test-select-elements
const listOfOptions = element.find('option');
await t.click(element).click(listOfOptions.withText(text).with({ visibilityCheck: true }).with({ timeout: 15000 }));
}
Calling this in my function
const siteDropdown = Selector('select[name="campaignSites"]'); // Initialized in constructor
await selectElementsByText(this.siteDropdown) , "France");
Your complete configuration file
{
"browsers": "chrome",
"src": "test/step-definitions/*.ts",
"screenshots": {
"path": "./artefacts/screenshots/",
"pathPattern": "${DATE}${TIME}/test-${TEST_INDEX}/${RUN_ID}/${TEST}${TIME}${FILE_INDEX}.png",
"thumbnails": false,
"takeOnFails": true,
"fullPage": false
},
"videoPath": "./artefacts/videos/",
"videoOptions": {
"singleFile": false,
"r": 20,
"aspect": "4:3",
"failedOnly": false,
"pathPattern": "${DATE}${TIME}/test-${TEST_INDEX}/${USERAGENT}/${FILE_INDEX}.mp4"
},
"reporter": [
"spec",
{
"name": "nunit3",
"output": "test/reports/TEST-testcafe-report.xml"
}
],
"skipJsErrors": true,
"buildName": "Parallel iOS Tests TestCafe on Azure",
"concurrency": 1,
"selectorTimeOut": 25000,
"assertionTimeOut": 25000,
"pageLoadTimeOut": 120000,
"pageRequestTimeout": 120000,
"ajaxRequestTimeout": 120000,
"speed": 1,
"console": true
"quarantineMode": {
"successThreshold": 1,
"attemptLimit": 2
}
}
Your complete test report
No response
Screenshots
No response
Steps to Reproduce

Select options in that dropdown

TestCafe version
"testcafe": "1.18.0",
Node.js version
v14.17.0
Command-line arguments
"test:ci": "gherkin-testcafe chrome:headless test/features/.feature test/step-definitions/.ts --skip-js-errors --disable-multiple-windows",
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

Hi @samplehub,
The Testcafe team knows about this case, and we have a corresponding issue: https://github.com/DevExpress/testcafe/issues/5339. Please track this issue. We will update it once we have news.
As a workaround, you can use ClientFunction:
test(`Select`, async t => {
  const setSelected = ClientFunction(option => {
    option().selected = true;
  });

  const options = Selector('#city').find('option');
  const option1 = options.withText('London');
  const option2 = options.withText('Paris');

  await setSelected(option1);
  await setSelected(option2);
  await t.debug();
});

Hello @Aleksey28 , Thanks for your response unfortunately the above workaround is not working for me.
Its selecting the options fine but not saving them .
Is there any other way to get around this please?? Thanks.

In order to assist you, I need to research a simple working sample where this workaround doesn't work. Please refer to the help topic that illustrates how to create this example: https://testcafe.io/402636/faq#how-to-create-a-minimal-working-example-when-you-submit-an-issue.


Why do not syntax highlight the php codes?!

Why do not syntax highlight the php codes?!
Is not this important?!

This is a limitation from the Jupyter's pygment plugin.
You can enable syntax highlighting by writing this as the first line:
//<?php

Thanks, But It's bad when we need to print and provide reports and documentations.


fix:  Unable to fetch ami based on existing criteria

Description

This PR solves empty result we are getting , whenever we try to fetch ami for asg

@antonbabenko  👍


Web Panel Can't login

I can't login and get this error code
/auth-ajax.php","line":11,"function":"getConn","args":[]}]

Can you post the full error? But make sure that you have PHP 7.4 or newer.

Here is my log file I just changed out my domain name from it
logs.zip

You need the SQLite3 PHP driver.

Where do I find that?

Are you hosting the webserver yourself or are you using some online webhost?

Online webhost

Then you're going to have to look up how to enable it in your webhost if possible, I haven't seen a webhost that doesn't have the SQLite3 PHP driver enabled by default before but seems like some don't then.


Fix for yii\db\Connection events documentation [skip ci]

Fixes #15799

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#15799

Thank you


Implement pager as a "storage driver"

Description
Add components responsible for managing low-level file access:

the Pager reads and writes to files based on (Page.h)
Pages which are the smallest unit accessible to the Pager (Page.h)
the PageCache optimizes disk access using an LRU write-behind policy. (PageCache.h)

Test suite
For Page (Page.cpp):

Creates a page and performs various operations on it: reading data, writing a different one, comparing, fetched bytes, etc.

For PageCache (PageCache.cpp):

Creates a cache of small size and tries to put more pages than possible in it. Page contents are modified in order to mark them as dirty and sync the disk versions with the memory ones.
At the end the actual file contents are compared with the expected values.

Environment
Using gcc (GCC) 11.1.0 on a x86_64 machine with GNU/Linux.

This PR makes changes which ...

[x] are thoroughly tested
[ ] are well documented

LGTM!

I think I know where I have seen such an answer :smile:


issue #368, data.table problems

That's a very annoying bug which should be fixed. Data.table v1.9.5 has fixes for "fread" function and a lot more, which make my life easier. Also i've checked that this fix works for data.table v 1.9.4 nicely.
I haven't observed any degradation in time.
Thank you for the great library.

Thanks will check it today or tomorrow.

Thanks for the PR !


Dependabot/npm and yarn/json5 and json5 and jest 2.2.3

Bump transitive/peer dependencies as well.

@c-harding I updated the deps. However, one question remains: do we want to force users periodically to update  jest and typescript or do we want to find a setup which has relaxed requirements (e.g. using babel for running the tests instead of ts-node)?

@torfmaster sorry, please could you recreate this? It seems like Dependabot got confused and closed this, thinking it was its own PR


Bug in manage_collections.py

A while back I changed _extract_cesm_date_str method to something I thought was  simple and correct. However, today when generating CESM collection catalog from files with hsi, I got this error:
/gpfs/u/home/abanihi/devel/intake-cesm/intake_cesm/manage_collections.py in _build_cesm_collection_df_files(self, resource_key, resource_type, direct_access, filelist)
    233
    234         for f in tqdm(filelist):
--> 235             fileparts = self._cesm_filename_parts(os.path.basename(f), self.component_streams)
    236
    237             if fileparts is None:

/gpfs/u/home/abanihi/devel/intake-cesm/intake_cesm/manage_collections.py in _cesm_filename_parts(self, filename, component_streams)
    169
    170         # define lists of stream strings
--> 171         datestr = self._extract_cesm_date_str(filename)
    172
    173         for component, streams in component_streams.items():

/gpfs/u/home/abanihi/devel/intake-cesm/intake_cesm/manage_collections.py in _extract_cesm_date_str(self, filename)
    162     def _extract_cesm_date_str(self, filename):
    163         """Extract a datastr from file name."""
--> 164         b = filename.split(".")[-2]
    165         return b
    166

IndexError: list index out of range

@matt-long, I was wondering whether you ever saw this error before? It appears that everything in build_collections notebook ran smoothly for you. I am not sure why It breaks on my part.

My change:
def _extract_cesm_date_str(self, filename):
        """Extract a datastr from file name."""
        b = filename.split(".")[-2]
        return b

is clearly not robust....
Putting back
def _extract_cesm_date_str(filename):
    '''Extract a datastr from file name.'''

    # must be in order of longer to shorter strings
    # TODO: make this function return a date object as well as string
    # should it also return a freq?
    datestrs = [r'\d{12}Z-\d{12}Z',
                r'\d{10}Z-\d{10}Z',
                r'\d{8}-\d{8}',
                r'\d{6}-\d{6}',
                r'\d{4}-\d{4}']

    for datestr in datestrs:
        match = re.compile(datestr).findall(filename)
        if match:
            return match[0]

    raise ValueError(f'unable to match date string: {filename}')

breaks the rest of the code though.

@andersy005 your code should work if the file conforms to the expected pattern. I am not sure when this change came in: I presume I was running with it yesterday? Did you change anything else? The HSI command puts all its output (as far as I can tell) to stderr, so there are both files AND error messages in the returned list.  Typical errors look like this
*** hpss_Opendir: Access denied [-13: HPSS_EACCES]
    /CCSM/csm/CESM-CAM5-BGC-LE/cases/b.e11.B20TRLENS_RCP85.f09_g16.xaer.017/ocn/hist
*** hpss_Opendir: Access denied [-13: HPSS_EACCES]
    /CCSM/csm/CESM-CAM5-BGC-LE/cases/b.e11.B20TRLENS_RCP85.f09_g16.xaer.018/ocn/hist
*** hpss_Opendir: Access denied [-13: HPSS_EACCES]
    /CCSM/csm/CESM-CAM5-BGC-LE/cases/b.e11.B20TRLENS_RCP85.f09_g16.xaer.019/ocn/hist

Both approaches have shortcomings. The regex approach might find more than one match. Perhaps we should have
   return match[-1]

Your approach might be more robust and could be inured against the error you are getting by testing the length of the list returned by split.
POP also writes files like this: "b.e11.B20TRLENS_RCP85.f09_g16.xaer.003.pop.h.once.nc" where the date string is "once". Your code should handle this nicely, the regex approach would fail as currently implemented.

It would be good to print a message with the filename so we can understand what we are missing.


Gradient editor displays bright magenta background instead of checker background for transparent colors

Godot version: Git https://github.com/godotengine/godot/commit/7a62b94bcae4da685144ce11aa6f1c8ad19b7c71
OS/device including version: Fedora 31, GeForce GTX 1080 (NVIDIA 440.100)
Issue description:
The Gradient editor fails to display its checker background for transparent colors and will display a bright magenta color instead.

This GUI component is drawn by scene/gui/gradient_edit.cpp.
Steps to reproduce: Create a Gradient resource in the Inspector dock by using the New Resource button, then edit one of its points to have an alpha value lower than 1.0.
Minimal reproduction project: N/A

Hey there,
I'd like to take a crack a this no one minds?
I've got a potential fix in place but I'm not sure if it's exactly what is wanted:

I assume it would better if it matched the color picker sample area?

@callumW That's a good start, but it ideally, it should display a repeating checkerboard like this:

That's how it looks in 3.2.3.

Cool, I think that would look better too. I'll take a look 😀
It looks like the color picker is a little broken too as it doesn't repeat like that, rather it displays stretched out as shown above.
Should that be raised as a separate issue or fixed in this one?

@callumW What do you mean by the color picker being broken? Other than the "pick" icon being offset, I don't see any differences.
If you meant the checkerboard texture stretched instead of repeating, that's something you need to reimplement in your PR.


Add suport for install, update and uninstall events to BaseInstaller

Hello,
in the current installers, it seems only be possible for me, to provide paths, to where the packages are being installed. Sometimes however, it might be necessary to do additional things, after the package has been installed.
Composer supports this with it's custom installers, since the InstallerInterface provides methods for install, update and delete.
Would it be possible to add these hooks to the BaeInstaller aswell?

I think custom installers are better suited for those use cases.


Add Piotr Zawadzki to Contributors list

Please add  my name

@zaramid, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve added a tweet feature to our web app recently. Can you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


MM-27312 Allow uploading 10 files per post

Summary
Increase the amount of files allowed per post, from 5 to 10.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/15645
Jira: https://mattermost.atlassian.net/browse/MM-27312
Related Pull Requests

Has server changes (https://github.com/mattermost/mattermost-server/pull/16235)

Thanks @DigasNikas, can you confirm that the error messages that appear when trying to upload > 10 files are updated accordingly?

/update-branch

@esethna The test server allowed me to test it and seems to work as expected.

@esethna just created the following PR in mobile: https://github.com/mattermost/mattermost-mobile/pull/5028

/update-branch

@saturninoabril my experience with cypress is very short. The task would require from me more effort than what I can really offer right now. I must pass :(

No worries. We'll take care of it. Thank you for your contribution @DigasNikas!


Lock icon only shows up in explorer when clicking on the file

Notice that terminalSuggestMain.js does not have the lock icon:

This is because it's showing up only after I open the file. After I close the file it remains, leading to a weird inconsistent state.

@Tyriar you did not use the find widget in this scenario right (just to make sure it was not caused by some recent work)
@lramos15 you aware of this?

I think we could do this but it will also add noise:

The explorer maintains decorations here:
https://github.com/microsoft/vscode/blob/c5001f6dd570bbdaa082a7f95ade855d5bcbbe17/src/vs/workbench/contrib/files/browser/views/explorerDecorationsProvider.ts#L19
If we decide to really show the 🔒 for all files that are readonly, just add:
if (fileStat.isReadonly) {
	return {
		letter: Codicon.lockSmall,
		tooltip: localize('readonly', "Read-only"),
	};
}

to the end.

@bpasero how about making it resolved model + open in an editor since the former is invisible to the end user? If you disagree feel free to close.

I think I would either make it consistently showing in all cases or keep what we have now but not add something new that is still not consistent.


spring-cloud-starter-aws: setting configurationSetName

Type: Feature
Is your feature request related to a problem? Please describe.
Ability to specify configuration set when sending emails with SimpleEmailServiceJavaMailSender.
It seems like perfectly fine use case that if we use SimpleEmailServiceJavaMailSender and as such SES client we can control which config set is used. It is impossible because org.springframework.cloud.aws.mail.simplemail.SimpleEmailServiceJavaMailSender#send(javax.mail.internet.MimeMessage...) does not expose any way to inject configurationSetName into SendRawEmailRequest object coming from AWS SDK.
I don't have preference as to implementation but I am included to say that ability to set configurationSetName scoped to an instance of SimpleEmailServiceJavaMailSender is a solution that I like. For one I don't feel like it would be clear API to allow to set it on send(...) method because of incompatibilities with parent class. Another idea to create protected method to create SendRawEmailRequest would require you to subclass anyway so I would simply add a second constructor that allows to specify configuration set name and later on set on on SendRawEmailRequest.
Describe the solution you'd like
I want to be able to specify configuration set name.
Describe alternatives you've considered
Subclassing SimpleEmailServiceJavaMailSender and overriding entire send method.
Additional context
        <dependency>
            <groupId>org.springframework.cloud</groupId>
            <artifactId>spring-cloud-starter-aws</artifactId>
            <version>2.2.4.RELEASE</version>
        </dependency>

PS. I might be able to help out.

Couple of things:

component is ses and not sns :P
I've just read you can actually specify configuration set-name per message so wonder if API change is not actually needed to correlate message with configuration set name.

My bad, thanks for pointing it out.
I can see supporting this on the mail sender level, but if its needed per message I don't think we can include it in Spring Cloud AWS, at least not in 2.x. You're welcome to try things out and if you come up with nice solution we can think about integrating it.

@kornicameister You're welcome to contribute a PR!

Closing due to lost interest ;-)


Issues while building in Noetic + 20.04

Hello,
I am trying to build this repo using catkin build in Ubuntu 20.04 & ROS -Noetic.
All other packages build fine except for the 'Auto' package.
The error seems to be related to pcl-conversions/ pcl-ros but I am unable to resolve it.
I have attached the entire error message.
PCL-conversions' error.odt
Any help would be greatly appreciated!

Try replacing
# check c++11 / c++0x
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=c++11" COMPILER_SUPPORTS_CXX11)
CHECK_CXX_COMPILER_FLAG("-std=c++0x" COMPILER_SUPPORTS_CXX0X)
if(COMPILER_SUPPORTS_CXX11)
    set(CMAKE_CXX_FLAGS "-std=c++11")
elseif(COMPILER_SUPPORTS_CXX0X)
    set(CMAKE_CXX_FLAGS "-std=c++0x")
else()
    message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} has no C++11 support. Please use a different C++ compiler.")
endif()

with
# check c++14/  c++11 / c++0x
include(CheckCXXCompilerFlag)
CHECK_CXX_COMPILER_FLAG("-std=c++14" COMPILER_SUPPORTS_CXX14)
CHECK_CXX_COMPILER_FLAG("-std=c++11" COMPILER_SUPPORTS_CXX11)
CHECK_CXX_COMPILER_FLAG("-std=c++0x" COMPILER_SUPPORTS_CXX0X)
if(COMPILER_SUPPORTS_CXX14)
    set(CMAKE_CXX_FLAGS "-std=c++14")
elseif(COMPILER_SUPPORTS_CXX11)
    set(CMAKE_CXX_FLAGS "-std=c++11")
elseif(COMPILER_SUPPORTS_CXX0X)
    set(CMAKE_CXX_FLAGS "-std=c++0x")
else()
    message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} has no C++11 support. Please use a different C++ compiler.")
endif()

pcl_ros include files for ubuntu uses c++14 syntax. so if you try to build with c++11 it fails.

Hello,
Thank you for your response.
Yes, this does seem to work. I did something similar. I just did.
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
and commented out the other CMAKE related lines.


fix: make PhoneNumber usable externally

Description

allow usage of PhoneNumber externally, by shifting responsibility of providing translations  to library user
fix bug where initially selected value wasn't translated
simplify how custom countryCodes are provided

Related Issue
Related to https://github.com/infermedica/component-library/issues/380, although it doesn't fix it.
Motivation and Context
There was an issue with dynamic imports of i18n-iso-countries translations which prevented us from using PhoneNumber component externally. I attempted to fix this so we can get future improvements like https://github.com/infermedica/component-library/issues/413 and uncovered some other issues.
How Has This Been Tested?

Screenshots (if appropriate):
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

In the console there is a warning:

in the story With Custom Country Codes With Timeout, the button ui-phone-number-prefix-toggle after 3sek should display text of the first element on the list like here, but it stays empty

In the file UiPhoneNumber.stories.ts there are some type errors like this one:

in the story With Custom Country Codes With Timeout, the button ui-phone-number-prefix-toggle after 3sek should display text of the first element on the list like here, but it stays empty

Out of curiosity, what's the purpose of this timeout? 🤔

TODO: if countryCodes is passed (without US), but not modelValue.prefix, nothing will be selected. Probably 1st value should be selected.

TODO: selectedCountryInfo should work on either countryCode or code, not only countryCode, in case we've just phone number, without meta info.

in the story With Custom Country Codes With Timeout, the button ui-phone-number-prefix-toggle after 3sek should display text of the first element on the list like here, but it stays empty

Out of curiosity, what's the purpose of this timeout? 🤔

This story I added to show how the behaviour PhoneNumber when waiting for custom prefixes list

Update: after looking into "US" being chosen by default, I thought that maybe we sometimes don't want to do that. Discussed this with Piotr and we came up with new design, with possibility of placeholder:
https://www.figma.com/design/2p8nMM7W88FU6r0kA52fAA/MGP-Component-Library?node-id=7220-19068&t=fgffiEVNqaDSatCl-0
Unfortunately, this means new error too. 😅
Currently the error handling is done a bit wonky, since it doesn't do any validation on itself - but I think it's fine as a starter.


Updating to Go 1.18

Description of the change:
Motivation for the change:
Reviewer Checklist

[ ] Sufficient unit test coverage
[ ] README updated with relevent examples
[ ] Commit messages are sensible and descriptive

/assign @sttts

/lgtm


feat: upgrade dependencies

https://dai-shi.github.io/excalidraw-animate/ is deployed.
https://www.npmjs.com/package/excalidraw-animate/v/0.6.0 is published.
@baabouj Would you like to work on excalidraw-claymate too??

Hey @dai-shi 👋
Yeah definitely! I will work on it too😄


Docs: Improve description of Array concat operator

I opened a more comprehensive PR, which I believe supersedes this one: https://github.com/godotengine/godot/pull/59701

Makes sense :)


Disable console logging color automatically on PCF. Addresses #196

Guys, made the suggested modifications to solve #196. However, I was unable to find a way to unit test it, because I couldn't find a way to retrieve the DisableColors property. If you think it is extremely necessary to generate a unit test for this change, I'd ask you to help me find a way.
Additionally, as it was necessary to reference Platform, I had to add a reference to Steeltoe.Common, which also required to upgrade LoggingVersion from 2.1.0 to 2.20.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: cesinhaugusto sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hey, this looks functional and works in my PCF environment, thank you! There are just a couple changes needed for .csproj and .sln files, and we can test this code... it didn't work when I tried to push changes to your branch, but if you could either pull them in or re-implement them, this is about what I'm looking for: https://github.com/SteeltoeOSS/steeltoe/commit/bc106d94ccb94cc82bc58d86cb92bab0c776e57e
If that's too much of a hassle I can just come back through and clean it up later

I'll gladly pull them, don't worry. My bad on the missing refs on .csproj and .sln. Simply forgot them.
Also, thanks for writing the tests. I wrote the same tests but was unable to think on how to write this line: var options = services.GetService(typeof(IOptions<ConsoleLoggerOptions>)) as IOptions<ConsoleLoggerOptions>;
It's always good to keep learning!


Make ActiveRecord::Migration class name dynamic

Previously, when testing ActiveRecord::Migration in multiverse, a static line determined the correct class syntax depending on the ActiveRecord version. This commit replaces where these static calls were made with a method call, which was added to test_helper.rb
closes #1208
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Describe the changes present in the pull request
Submitter Checklist:

[ ] Include a link to the related GitHub issue, if applicable
[ ] Include a security review link, if applicable

Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist

[ ] Perform code review
[ ] Add performance label
[ ] Perform appropriate level of performance testing
[ ] Confirm all checks passed
[ ] Add version label prior to acceptance

Moving a portion of this work to PR #1268 [PR 1268] in order to address core CI failures that are outside the scope of this PR and the related ticket #1208


Many things still unclear, it's needed to improve the guide and infos

Hi, I've several problems implementing it, first I've complained with the guide written in TuyAPI about the connection guide, I've done all the stept and now I'm wondering to now if somthing is wrong with module, cause I can't connect
Thank you for your kind reply, I'm ready to collaborate to know things better and improve our results.
Here are the results of my experiment, what I wrote there:
My device, which is a S1-B (WT) trailing/leading Tuya edge triac, no battery and direct to AC power, here are the results of my experimenting:

When I wrote the post I was working only with Bluetooth, I've understood it today when deelply I've analyzed my LAN trafic and understood the device wasn't connected to WiFi at all. Since cloud recognized the device I thought it was online, I was wrong.. those datas are submitted by Smart Life app, doesn't matter the device itself, so be careful here.

I've deleted, pressed button and paired again, now I saw on my router 2 new MACs, one of them asked for IP and present itself with name wlan0, the second which shares the same first bytes values and differs only on the last 2, disappeared after minutes.
The dimmer broadcasts regulary on LAN with UDP dest port 6667
The dimmer keeps alive the connection with <IP_ADDRESS>:8883 and from this address (cloud) receives command when is not connected on the same WiFi name as dimmer, and here I got 2 casesM
a) if LAN has another WiFi on the same IP subnet/Layer2 broadcast it worked only by cloud, stopping gateway it didn't work more (bluetooth also off), when I switched phone to the same wifi it worked back.
b) on the second attempt it worked also with the second wifi, the app start controlling the dimmer using broadcast LAN address with UDP destination port 7000. Probably it attempt to connect with broadcast at beginning, if dimmer doesn't reply it fails somehow and don't attempt more.

the app is broadcasting UDP to <IP_ADDRESS>:7000 each time a command is set, which is not the LAN broadcast, this packet is probably useless, I'm not sure it becomes with broadcast MAC destination since it's out of subnet, it will die on the router. The app does try use the correct LAN broadcast only when cloud and bluetotth are unavailable. The app never connect directly to the dimmer IP

Now, using the module, assuring dimmer is cloud connected, I can't connect with it by ID and neither by its IP:

using ID + secret (which I obtained by tuya-cli wizard), I can't connect with any 3.1 3.2 and 3.3 protocols, I always have "connecting"
By IP, using the known right IP of device, I got timeout errors. It's stange to try a direct connection since the Smart Life app doesn't try this, it uses the broadcast LAN IP to send UDP on port 7000, I've tried specify there also the broadcast address but same result, probably the device never answer on LAN requests, I can ping device, no TCP porta are listening/answer, on UDP to get an answer you need to send proper command.

What can I do?
Thanks

It's also complicated for me to understand how to drive the dimmer, in your example you have inject nodes and function it produces:
msg.payload ={   dps: 20, set : true} for turn on, what is dps? it should be always 20? How can I set the dimming value?

proceding with tests, broadcast packet UDP:7000 from app looks only announcement, the dimmer connects by Bluetooth when near or cloud, there is no direct IP connection neither LAN broadcast command to dimmer.  It looks to me these devices should be refleshed to get control from LAN, amazing


How I convert '0x77359400'

Hey, I'm trying to use your converter, but my API return 0x77359400 as value. How can I convert this to wei?
King regards.

I'm testing some codes that I found then I'll create a PR.

Hello @amandiobm,
Would a new method similar to this one work for you: https://web3js.readthedocs.io/en/1.0/web3-utils.html#hextonumber

Basically the API return "0x4e0fb2f17db64ac00", which is equal to ETH 89.998579358, or Wei<PHONE_NUMBER>8000000000. I manage to convert using this approach.
private function decodeHex($input)
{
    if (substr($input, 0, 2) == '0x') {
        $input = substr($input, 2);
    }

    if (preg_match('/[a-f0-9]+/', $input)) {
        return hexdec($input);
    }

    return $input;
}

I would advise against using PHP's built-in hexdec() function to perform the conversion from hex to decimal, as PHP will represent the larger numbers as float internally, and you will very likely encounter floating-point arithmetic errors.
I'd recommend using a safe arithmetic library such as https://github.com/krowinski/bcmath-extended to avoid such errors. There is a PR currently open (https://github.com/krowinski/bcmath-extended/pull/25) which calls for adding hexdec() and dechex() functions into the library. While the PR is still pending, consider using your own custom function, that you can define like this:
<?php

require 'vendor/autoload.php';

use BCMathExtended\BC;

function bchexdec($hex) {
    $remainingDigits = substr($hex, 0, -1);
    $lastDigitToDecimal = \hexdec(substr($hex, -1));

    if (strlen($remainingDigits) === 0) {
        return $lastDigitToDecimal;
    }

    return BC::add(BC::mul(16, BC::hexdec($remainingDigits)), $lastDigitToDecimal, 0);
}

$valueInWei = '0x4e0fb2f17db64ac00';

echo hexdec($valueInWei);
// output is: 8.9998579358E+19

echo bchexdec($valueInWei);
// output is:<PHONE_NUMBER>8000000000

And to illustrate the potential floating-point arithmetic problems with your current approach, consider the following example:
$firstValueInWei = '0x4e0fb2f17db64ac00';
$secondValueInWei = '0x0ea1277359400abcd';

// Using PHP's built-in hexdec() function and performing an arithmetic operation:
// ===========================================
echo hexdec($firstValueInWei);
// output is: 8.9998579358E+19

echo hexdec($secondValueInWei);
// output is: 1.6866674626456E+19

echo hexdec($firstValueInWei) + hexdec($secondValueInWei);
// output is: 1.0686525398446E+20

echo BC::convertScientificNotationToString(1.0686525398446E+20);
// output is:<PHONE_NUMBER>84460000000

// Using BCMath library and your custom function
// ===========================================
echo bchexdec($firstValueInWei);
// output is:<PHONE_NUMBER>8000000000

echo bchexdec($secondValueInWei);
// output is:<PHONE_NUMBER>6455972813

echo BC::add(bchexdec($firstValueInWei), bchexdec($secondValueInWei));
// output is:<PHONE_NUMBER>84455972813

As you can see, in the first example, your value is off by 4027187 Wei!

@amandiobm https://github.com/krowinski/bcmath-extended/pull/25 was accepted, and  https://github.com/krowinski/bcmath-extended now includes the hexdec() and dechex() functions, so you can just use:
<?php

require 'vendor/autoload.php';

use Bezhanov\Ethereum\Converter;
use BCMathExtended\BC;

$valueInWei = '0x4e0fb2f17db64ac00';
$converter = new Bezhanov\Ethereum\Converter();
$valueInEther = $converter->fromWei(BC::hexdec($valueInWei), 'ether');

printf('%s Wei is %s Ether', $valueInWei, $valueInEther);
// outputs: "0x4e0fb2f17db64ac00 Wei is 89.9985793580000000000000000000000000000 Ether"

@amandiobm PR https://github.com/krowinski/bcmath-extended/pull/25 was accepted, and  https://github.com/krowinski/bcmath-extended now includes the hexdec() and dechex() functions out of the box, so you can just use:
<?php

require 'vendor/autoload.php';

use Bezhanov\Ethereum\Converter;
use BCMathExtended\BC;

$valueInWei = BC::hexdec('0x4e0fb2f17db64ac00');
$converter = new Bezhanov\Ethereum\Converter();
$valueInEther = $converter->fromWei($valueInWei, 'ether');

printf('%s Wei is %s Ether', $valueInWei, $valueInEther);
// outputs: "89998579358000000000 Wei is 89.9985793580000000000000000000000000000 Ether"

@mbezhanov tks buddy, I installed and works perfectly.

For anyone who is having issue with much bigger value.
try to remove starting 0x from the string.
it works perfectly.


Krishna2323/issue/49286

Fixed Issues
$ GH_LINK https://github.com/Expensify/App/issues/49286
Details: This PR updates the sanitizeURL utility function to accept a new parameter, scheme. The scheme parameter allows us to specify the scheme as needed. The default value is https, but we can pass http or any other scheme as the scheme parameter to override it.
Tests

What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?

QA

What does QA need to do to validate your changes?
What areas to they need to test for regressions?

@rlinoz I'll take over as I'm assigned to the parent issue


Adding lazy loading feature

issue : #146  Solved

@Suryanshomar7240  hey, can you plz review it?


doc(python): document the  method in fts

Ah, I see the reason for part of my confusion: This docstring says True, but the code above it says False. That needs to be fixed.

Ok so I now see that the code shows that phrase query is False by default. But some tests and examples on structured queries would also be nice :)

@changhiskhan the syntax description as it exists is very confusing, so I rephrased it as per your comments and discussions in #797 and #769. The "Syntax" subsection is renamed to "Phrase queries vs. structured queries" for clarity.
I feel like my modified verrsion is easier to follow (at least in my head), so it would be great if you and @wjones127 could carefully give that section a read and see if my understanding is correct.
I still think there are a few parts that aren't very clear when it comes to syntax, and looking through the code didn't help me much.

How exactly is the syntax "they could have been dogs OR cats" being marked as invalid by LanceDB? Is it simply checking for the presence of logical operators like AND or symbolic operators like - in every query that's enclosed in double quotes?
If the above is true, then how is a query like "(Old AND Man) AND Sea" marked as valid? How does the parser know what constitutes a phrase, and what constitutes a keyword?
The phrase_query argument is true by default in the query builder. By this logic, does this mean that LanceDB will always try to parse the query first as a phrase query under all conditions? If so, how does the user enforce structured query execution if they want it?

The parsing is all controlled by tantivy. I was going to propose just linking to tantivy docs but it's also lacking in detail:
"""
// QueryParser may fail if the query is not in the right
// format. For user facing applications, this can be a problem.
// A ticket has been opened regarding this problem.
"""
Maybe we could link to Lucene documentation? https://lucene.apache.org/core/2_9_4/queryparsersyntax.html
I'm not sure whether Tantivy follows this exactly (I implicitly assume it does but it's not explicitly stated anywhere in their docs)

Ok so I now see that the code shows that phrase query is False by default. But some tests and examples on structured queries would also be nice :)

i added a couple of examples

Makes sense now, thanks! Just two small nits to update.

done. Thanks for the review!

@prrao87 lmk if everything is good now. thanks!


This invalid e-mail passes validation

This e-mail is invalid:
<EMAIL_ADDRESS>And it passes parsley e-mail validation as valid e-mail.

I believe it actually is valid, and I double checked that it is supported by gmail.


Compile additional information blocks

You can make your resume less formal by adding additional blocks that contain useful information but present it in an "entertaining" way.

It was possible to complete this task


WIP: add verify-zk native for pact zk hooks

Pending:

What is the input/output format of a generalized ZK proof object?
Should rebase to @jmcardon's zk primitives PR

Closing this PR, since after discussion with @emilypi it seems we will not be needing these changes.


Changing letsencrypt.sh to dehydrated

Following the instructions the following warning appears:
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! letsencrypt.sh has been renamed to dehydrated !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Due to trademark violation letsencrypt.sh had to be renamed and is know called dehydrated.

To make a clean cut dehydrated doesn't use the old config locations /etc/letsencrypt.sh and
/usr/local/etc/letsencrypt.sh anymore, also the script file has been renamed.

If you were using the default WELLKNOWN location please also update your webserver to use /var/www/dehydrated.

You are currently running (or reading) a temporary wrapper which handles the old config locations,
you should update your setup to use /etc/dehydrated and the 'dehydrated' script file as soon as possible.

Thanks; I've updated the instructions to point at dehydrated instead of letsencrypt.sh.


AWS: disable unlimited CPU credits

From the AWS example at https://forums.aws.amazon.com/message.jspa?messageID=927938

I'm guessing that's a static IP?

It's a weird local-only internal IP that AWS uses to provide metadata to instances.
We'll see if this actually works in a second.


Surefire fails when system.exit is called during unit tests execution

Steps to reproduce:

Delete CosmosKey from ngsa/secrets folder
Execute mvn test

Expectation:
Unit tests should gracefully fail for missing secrets
Ref:
https://stackoverflow.com/a/25034102
https://stackoverflow.com/a/51099769

Surefire does not support tests or any referenced libraries calling System.exit() which inherently causes process crash
An alternative would be throwing unchecked exception instead but exception handling requires lots of work-arounds to stop the server thread. If threads are not stopped, unit tests continue to execute and throws multiple failures.
Since it affects small subset of flow, we will fix this by fixing error logging.

Ref:

Prevent system.exit by updating security manager https://stackoverflow.com/a/309427