CacheFilter: Upgrade GET requests whose upgrade headers are not removed should bypass the cache

CacheFilter (#7198) should bypass cache for websocket protocol requests as defined by RFC6455§1.2.

We don't have enough information for why this is needed at the moment. I'll close the issue.


Mechanism to build DEB packages

I know there is already a mechanism to generate Flatpaks but I've been trying to generate MacOS bundle via CPack and nothing works. Yet generating DEB packages works fine. I think I'm loosing my sanity 😅
If you think this mechanism is redundant then please feel free to close this PR.

I'm not sure if one deb package can work across multiple distro and version (e.g. work on both Debian and Ubuntu 20.04 22.04 etc.). If not maybe we should stick with Flatpak or something similar.

Regarding the discussion in #123 maybe we should focus on AppImage instead of distro-specific package?


Intermittent CI issues: subprocess.CalledProcessError - Fatal Python error: _enter_buffered_busy: could not acquire lock

I am noticing an intermittent subprocess.CalledProcessError error in CI mentioning locks and stderr. This has been seen in https://github.com/dask-contrib/dask-ctl/runs/5448329455?check_suite_focus=true and mentioned in #36 too.
subprocess.CalledProcessError: Command '['daskctl', 'cluster', 'create', '-f', '/home/runner/work/dask-ctl/dask-ctl/dask_ctl/tests/specs/simple.yaml']' died with <Signals.SIGABRT: 6>.

        The returned instance will have attributes args, returncode, stdout and
        stderr. By default, stdout and stderr are not captured, and those attributes
        will be None. Pass stdout=PIPE and/or stderr=PIPE in order to capture them.

        If check is True and the exit code was non-zero, it raises a
        CalledProcessError. The CalledProcessError object will have the return code
        in the returncode attribute, and output & stderr attributes if those streams
        were captured.

        If timeout is given, and the process takes too long, a TimeoutExpired
        exception will be raised.

        There is an optional argument "input", allowing you to
        pass bytes or a string to the subprocess's stdin.  If you use this argument
        you may not also use the Popen constructor's "stdin" argument, as
        it will be used internally.

        By default, all communication is in bytes, and therefore any "input" should
        be bytes, and the stdout and stderr will be bytes. If in text mode, any
        "input" should be a string, and stdout and stderr will be strings decoded
        according to locale encoding, or by "encoding" if set. Text mode is
        triggered by setting any of text, encoding, errors or universal_newlines.

        The other arguments are the same as for the Popen constructor.
        """
        if input is not None:
            if kwargs.get('stdin') is not None:
                raise ValueError('stdin and input arguments may not both be used.')
            kwargs['stdin'] = PIPE

        if capture_output:
            if kwargs.get('stdout') is not None or kwargs.get('stderr') is not None:
                raise ValueError('stdout and stderr arguments may not be used '
                                 'with capture_output.')
            kwargs['stdout'] = PIPE
            kwargs['stderr'] = PIPE

        with Popen(*popenargs, **kwargs) as process:
            try:
                stdout, stderr = process.communicate(input, timeout=timeout)
            except TimeoutExpired as exc:
                process.kill()
                if _mswindows:
                    # Windows accumulates the output in a single blocking
                    # read() call run on child threads, with the timeout
                    # being done in a join() on those threads.  communicate()
                    # _after_ kill() is required to collect that and add it
                    # to the exception.
                    exc.stdout, exc.stderr = process.communicate()
                else:
                    # POSIX _communicate already populated the output so
                    # far into the TimeoutExpired exception.
                    process.wait()
                raise
            except:  # Including KeyboardInterrupt, communicate handled that.
                process.kill()
                # We don't call process.wait() as .__exit__ does that for us.
                raise
            retcode = process.poll()
            if check and retcode:
>               raise CalledProcessError(retcode, process.args,
                                         output=stdout, stderr=stderr)
E               subprocess.CalledProcessError: Command '['daskctl', 'cluster', 'create', '-f', '/home/runner/work/dask-ctl/dask-ctl/dask_ctl/tests/specs/simple.yaml']' died with <Signals.SIGABRT: 6>.

/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/subprocess.py:528: CalledProcessError
----------------------------- Captured stderr call -----------------------------
/home/runner/work/dask-ctl/dask-ctl/dask_ctl/cli.py:15: FutureWarning: typename is deprecated and will be removed in a future release. Please use dask.utils.typename instead.
  from distributed.utils import typename
Exception in thread AsyncProcess Dask Worker process (from Nanny) watch process join:
Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads
Python runtime state: finalizing (tstate=0x559447276ac0)

Current thread 0x00007f7f2bd16740 (most recent call first):
<no Python frame>
=============================== warnings summary ===============================
dask_ctl/cli.py:15
  /home/runner/work/dask-ctl/dask-ctl/dask_ctl/cli.py:15: FutureWarning: typename is deprecated and will be removed in a future release. Please use dask.utils.typename instead.
    from distributed.utils import typename

dask_ctl/tests/test_cli.py::test_list
dask_ctl/tests/test_lifecycle.py::test_snippet
  /opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/scheduler.py:5715: UserWarning: Scheduler already contains a plugin with name worker-status; overwriting.
    warnings.warn(

dask_ctl/tests/test_cli.py::test_autocompletion
dask_ctl/tests/test_discovery.py::test_discover_cluster_names
dask_ctl/tests/test_lifecycle.py::test_snippet
  /opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/client.py:1354: RuntimeWarning: coroutine 'wait_for' was never awaited
    self.close()

dask_ctl/tests/test_cli.py::test_autocompletion
dask_ctl/tests/test_discovery.py::test_discover_cluster_names
dask_ctl/tests/test_lifecycle.py::test_snippet
  /opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/client.py:1354: RuntimeWarning: coroutine 'Client._close' was never awaited
    self.close()

dask_ctl/tests/test_discovery.py::test_discover_clusters
  /home/runner/work/dask-ctl/dask-ctl/dask_ctl/discovery.py:100: UserWarning: Cluster discovery for proxycluster timed out.
    warnings.warn(

dask_ctl/tests/test_discovery.py::test_discover_clusters
  /opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning: Exception ignored in: <function Client.__del__ at 0x7f16362e7e50>

  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/client.py", line 1354, in __del__
      self.close()
    File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/client.py", line 1597, in close
      sync(self.loop, self._close, fast=True, callback_timeout=timeout)
    File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/utils.py", line 371, in sync
      raise TimeoutError(f"timed out after {callback_timeout} s.")
  asyncio.exceptions.TimeoutError: timed out after 2 s.

    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))

dask_ctl/tests/test_lifecycle.py::test_snippet
Exception in thread AsyncProcess Dask Worker process (from Nanny) watch process join:
  /opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/node.py:180: UserWarning: Port 8787 is already in use.
  Perhaps you already have a cluster running?
  Hosting the HTTP server on port 43767 instead
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

---------- coverage: platform linux, python 3.9.10-final-0 -----------
Name                         Stmts   Miss  Cover
------------------------------------------------
dask_ctl/__init__.py            10      0   100%
dask_ctl/cli.py                162     53    67%
dask_ctl/config.py               8      0   100%
dask_ctl/discovery.py           34      4    88%
dask_ctl/lifecycle.py           42      9    79%
dask_ctl/proxy.py               46      2    96%
dask_ctl/spec.py                14      1    93%
dask_ctl/tests/conftest.py      [11](https://github.com/dask-contrib/dask-ctl/runs/5448329455?check_suite_focus=true#step:5:11)      1    91%
dask_ctl/utils.py               18      0   100%
------------------------------------------------
TOTAL                          345     70    80%

=========================== short test summary info ============================
FAILED dask_ctl/tests/test_cli.py::test_create - subprocess.CalledProcessErro...
============ 1 failed, 11 passed, [12](https://github.com/dask-contrib/dask-ctl/runs/5448329455?check_suite_focus=true#step:5:12) skipped, 12 warnings in 34.43s ============
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/threading.py", line 973, in _bootstrap_inner
    self.run()
  File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/threading.py", line 910, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/hostedtoolcache/Python/3.9.10/x64/lib/python3.9/site-packages/distributed/process.py", line 216, in _watch_process
Fatal Python error: _enter_buffered_busy: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads
Python runtime state: finalizing (tstate=0x55883c7ff240)

Current thread 0x00007f163932b740 (most recent call first):
<no Python frame>
/home/runner/work/_temp/58de1659-75dd-4396-916b-3d1fc3[13](https://github.com/dask-contrib/dask-ctl/runs/5448329455?check_suite_focus=true#step:5:13)2720.sh: line 1:  [17](https://github.com/dask-contrib/dask-ctl/runs/5448329455?check_suite_focus=true#step:5:17)06 Aborted                 (core dumped) pytest

If I understand correctly, the issue is that there are daemon threads involved somewhere that try to print to stderr on shutdown. Since there's no explicit use of threading here I suppose this should actually be forwarded to distributed?


services/horizon/expingest: Update DatabaseProcessor with trust lines

PR Checklist
PR Structure

[x] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[x] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

Summary
This commit adds trust lines to ingestion pipeline.
Goal and scope
In https://github.com/stellar/go/issues/1765, https://github.com/stellar/go/issues/1766 and https://github.com/stellar/go/issues/442 we need trust lines in Horizon DB to serve the requests. This commit is adding a code needed by all of the issues above.
Summary of changes

Adds a new migration file adding a new trust_lines table.
Updates db2/history package with trust lines related interfaces and structs.
Updates DatabaseProcessor to process trust lines in state and ledger pipelines.

Known limitations & issues

No tests for the new code.
~State verifier not updated to check trust lines.~ Done in 3b74910.

However, if you want to start working on any of https://github.com/stellar/go/issues/1765, https://github.com/stellar/go/issues/1766 and https://github.com/stellar/go/issues/442 you can branch off from this PR branch.

@bartekn to support the /assets endpoint it seems like we'll need a table equivalent to asset_stats from the old ingestion system. Will that be implemented in this PR?

@tamirms no, this PR only adds trust lines (shared code needed in #1765, #1766 and #442). asset_stats table should be added in #1765).

I think this PR is ready for review.
When it comes to tests, I'd like to continue discussion started here: https://github.com/stellar/go/pull/1699#discussion_r323455894. I created tests for TrustLinesQ methods that are not using postgres but mocked version of db.Session. I did this because the idea here is slightly different than what @tamirms described in his PR: it's not storing data in memory, it just checks if the queries and arguments are properly built before passing them to Exec function. Unfortunately it required small changes in history.Q to allow mocking. Let me know what you think, it's easy to revert the changes and write tests that use postgres.

@bartekn the code looks good to me. Regarding the tests, I would prefer if services/horizon/internal/db2/history/trust_lines_test.go interacted with postgres. In the current tests, if the sql query is not correct (e.g. there is a typo in one of the columns, or a column is missing, or there is a violation of some constraint) we would be relying on code review to catch these errors. I think if the tests ran the queries against postgres we would have better chances of catching these types of errors even if they slipped through code review.

@tamirms ok, tests are using DB now. PTAL!

In the current tests, if the sql query is not correct (e.g. there is a typo in one of the columns, or a column is missing, or there is a violation of some constraint) we would be relying on code review to catch these errors.

Yes, but such things should be checked during integration tests run in CI. The holy grail, imho, is to have unit tests that are fast and doesn't require any 3rd party tool installed (including docker). But I agree that we should probably stick to the old method until we have a good integration tests in CI.


Open LazyGit for the repo that contains the current buffer's file

Would be nice when browsing any file, to open LazyGit to the repo that contains that file. Right now it appears to open the repo that contains the directory/file I originally opened in neovim

Hey there,
this feature is just awesome! Wouldnt it be great if LazyGit also has the option to open gits root folder for the current buffer?

Yeah, here the same.
Feature request: Option to open lazygit focused on current buffer in file explorer
When working with multiple file changes, I often want to check the diff of just the current buffer. It would be helpful to have an option that opens lazygit with the cursor already focused on the filename entry in the files view. This would avoid repeatedly navigating or filtering to find the specific file I'm working on.
Thanks for this fantastic plugin - it's been transformative for my neovim workflow!


Request for license change

Hello,
I stumbled upon your project and I find it perfect for our needs: it's clean, easy to use and simply  achieves easily the goal of throttling the logs :)
We then saw that this project is GPL licensed and we would not be able to use it unfortunately as it is, so the question we would like to ask is if you would be willing to change the license to MIT or BSD.
Thank you in advance for your time, looking forward to hear back from you if this is a possibility!
Have a nice weekend!

Hi,
We are happy to see that this project can be helpful for you. We changed the license to Apache 2.0 and now you can freely use it in your commercial project.


Clear resourceManager editor special code

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Codecov Report
Base: 44.49% // Head: 43.35% // Decreases project coverage by -1.13% :warning:

Coverage data is based on head (b1e034e) compared to base (bbc153c).
Patch coverage: 25.00% of modified lines in pull request are covered.

:exclamation: Current head b1e034e differs from pull request most recent head 2199ce2. Consider uploading reports for the commit 2199ce2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   44.49%   43.35%   -1.14%
==========================================
  Files         347      347
  Lines       18331    18331
  Branches     2540     2540
==========================================
- Hits         8156     7948     -208
- Misses       9525     9774     +249
+ Partials      650      609      -41

Impacted Files
Coverage Δ

packages/loader/src/AnimatorControllerLoader.ts
5.55% <ø> (ø)

packages/loader/src/MaterialLoader.ts
4.65% <ø> (ø)

packages/loader/src/SceneLoader.ts
12.24% <ø> (ø)

packages/loader/src/SpriteLoader.ts
27.27% <ø> (ø)

...oader/src/gltf/extensions/OASIS_materials_remap.ts
60.00% <ø> (ø)

packages/core/src/asset/ResourceManager.ts
42.73% <25.00%> (ø)

packages/core/src/RenderPipeline/RenderContext.ts
44.44% <0.00%> (-55.56%)
:arrow_down:

...ges/core/src/RenderPipeline/BasicRenderPipeline.ts
25.00% <0.00%> (-29.42%)
:arrow_down:

packages/core/src/Camera.ts
31.84% <0.00%> (-19.91%)
:arrow_down:

packages/rhi-webgl/src/WebGLRenderer.ts
45.06% <0.00%> (-19.76%)
:arrow_down:

... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Block alignment [Feature]

Would it be possible to add a feature of alignment of blocks such as
<p align="center">
or similar for other blocks and alignment? (Left, Right, Top, Middle, etc.) / (h1, h2, etc.)?
Also font attributes such as color, size, etc. ?
Thank you for all your work.

I was able to achieve this by modifying the ParagraphComponent within the Components folder. The modification was a quick and dirty one which will probably be refactored and cleaned up some later. However wanted to provide it here just in case anyone else is looking for this type of solution. In this component, the following code was added.
        else if (listItemNode.IsBlockNode())
          {
              var attributes = listItemNode.GetAttributes();
              foreach (var attribute in attributes)
              {
                  if (attribute.Name == "align")
                  {
                      if(attribute.Value.ToLower() == "left")
                      {
                          container = container.AlignLeft();
                      }
                      if (attribute.Value.ToLower() == "center")
                      {
                          container = container.AlignCenter();
                      }
                      if (attribute.Value.ToLower() == "right")
                      {
                          container = container.AlignRight();
                      }
                  }
              }

This is after the if statement checking whether it is a numbered list within the Compose method. Around line 45.


Package for debian/ubuntu

Is your feature request related to a problem? Please describe.
Install git-cliff for debian/ubuntu is not necessarily quick. It would be convenient if a debian package could be provided.
Describe the solution you'd like
Provide an AMD64 debian package that simply packages up the gnu-linux binary.

Hi!
I updated the release workflow to publish Debian packages (built via cargo-deb).
See the related commit: efd827f59f8394dd894ebd35a5d630ff558a3ebe
Thanks for the suggestion! 🐻


Import states

Prior to this PR an Import only had an implicit state - something that was reflected by the way the ImportResult worked. We'd simply count how many of an Import's RawInput records had a nil state and when that number was zero then we knew that the Import was finished.
That worked, but isn't going to cut it moving forward.
Instead, what @gnilekaw and I talked about late last week was adding a state column to the Import and being more declarative about the various states it can be in. To accomplish this, I reviewed the libraries one could use and found something that I really like: micromachine. It's a tiny little library compared to the competition, which is something that I really like about it - you can easily read the whole thing because it's just one class.
So I played around with it and it turns out I think it's a great fit for the states of an Import. I subclassed with ImportMicroMachine to encapsulate the configuration so the impact on the Import class is about as trim as I could make it. But make no mistake, this PR does add responsibility to Import. It is now the owner of the knowledge about how states and jobs relate to one another. Rather than that knowledge being spread around the system, I've centralized it on the model. You mad?
While this is a fairly large PR, it's actually more of a refactoring than anything else - all I've really done is shuffle around some things. But, what this PR does is set us up with a better foundation on which to build. From here we can introduce the concept of finalizing an Import where we export errors to S3 and ping the team on Slack.
Introducing a pre-flight step is as easy as registering new states in the machine and then writing the job to do it.
And the real punchline will be when we're ready to add the state for syncing with RedShift - we'll be able to tell if an Import's data is in sync because we'll have done the work to ensure our states make sense.
Final note: this work is on top of #127 which itself is on top of #123 - I just couldn't get this done without stacking things like this. I'll happily rebase as things get merged!!

This is awesome. Makes sense to centralize everything in the model. Api reads nice also.


ci: only run build when all others succeed

Only run build job if other (faster) jobs succeed.

I feel like  it makes sense not to run the heavy build job unless the faster-failing ones complete. We could even rewrite them all in a dependant chain based on test speed, to save resources and get faster red dots...
See below how the build job was only triggered by all others completing.


[SR-511][Parse] Add 'associatedtype' keyword and fixit

Adds an associatedtype keyword to the parser tokens, and accepts either
typealias or associatedtype to create an AssociatedTypeDecl, warning
that the former is deprecated. The ASTPrinter now emits associatedtype
for AssociatedTypeDecls.
Separated AssociatedType from TypeAlias as two different kinds of
CodeCompletionDeclKinds. This part probably doesn’t turn out to be
absolutely necessary currently, but it is nice cleanup from formerly
specifically glomming the two together.
And then many, many changes to tests. The actual new test for the fixit
is at the end of Generics/associated_types.swift.
There is one open question at the moment, which is what should happen
with using associatedtype in a non-Protocol context:
protocol P9 {
  associatedtype A1 : P8
}
struct Y9 : P9 {
  typealias A1 = X8
}

Currently the code still expects typealias in the struct, and it is a
typealias as far as the compiler is concerned. But I can certainly
imagine users mistakenly thinking that they are ‘assigning’ a specific type to an
associatedtype instead. With this current commit, using the
associatedtype keyword there will assert an unexpected token. It should
either accept it or have a nice error, and I’m not sure which.

I think that a specific diagnostic for the case of writing 'associatedtype' in a non-protocol would be useful. Something like
associated types can only be defined in a protocol; define a type or introduce a 'typealias' to satisfy an associated type requirement

Otherwise, this looks great!

@DougGregor Thanks for the better language on the diagnoses! Committed those fixes.

Can you squash these and then I'll merge?

On Jan 13, 2016, at 3:06 PM, Greg Titus<EMAIL_ADDRESS>wrote:
Adds an associatedtype keyword to the parser tokens, and accepts either
typealias or associatedtype to create an AssociatedTypeDecl, warning
that the former is deprecated. The ASTPrinter now emits associatedtype
for AssociatedTypeDecls.
Separated AssociatedType from TypeAlias as two different kinds of
CodeCompletionDeclKinds. This part probably doesn’t turn out to be
absolutely necessary currently, but it is nice cleanup from formerly
specifically glomming the two together.
And then many, many changes to tests. The actual new test for the fixit
is at the end of Generics/associated_types.swift.
There is one open question at the moment, which is what should happen
with using associatedtype in a non-Protocol context:
protocol P9 {
associatedtype A1 : P8
}
struct Y9 : P9 {
typealias A1 = X8
}
Currently the code still expects typealias in the struct, and it is a
typealias as far as the compiler is concerned.

The code should not be requiring a typealias; it never did before.  This should work:
struct Y9 : P9 {
struct A1 : P8 {}
}

But I can certainly
imagine users mistakenly thinking that they are ‘assigning’ a specific type to an
associatedtype instead. With this current commit, using the
associatedtype keyword there will assert an unexpected token. It should
either accept it or have a nice error, and I’m not sure which.
You can view, comment on, or merge this pull request online at:
https://github.com/apple/swift/pull/964 https://github.com/apple/swift/pull/964
Commit Summary
[SR-511][Parse] Add 'associatedtype' keyword and fixit
File Changes
M include/swift/AST/DiagnosticsParse.def https://github.com/apple/swift/pull/964/files#diff-0 (4)
M include/swift/IDE/CodeCompletion.h https://github.com/apple/swift/pull/964/files#diff-1 (1)
M include/swift/Parse/Tokens.def https://github.com/apple/swift/pull/964/files#diff-2 (1)
M lib/AST/ASTPrinter.cpp https://github.com/apple/swift/pull/964/files#diff-3 (2)
M lib/IDE/CodeCompletion.cpp https://github.com/apple/swift/pull/964/files#diff-4 (7)
M lib/IDE/REPLCodeCompletion.cpp https://github.com/apple/swift/pull/964/files#diff-5 (1)
M lib/Parse/ParseDecl.cpp https://github.com/apple/swift/pull/964/files#diff-6 (17)
M test/Constraints/associated_types.swift https://github.com/apple/swift/pull/964/files#diff-7 (2)
M test/Constraints/diagnostics.swift https://github.com/apple/swift/pull/964/files#diff-8 (3)
M test/Constraints/generic_overload.swift https://github.com/apple/swift/pull/964/files#diff-9 (4)
M test/Constraints/generics.swift https://github.com/apple/swift/pull/964/files#diff-10 (4)
M test/Constraints/invalid_archetype_constraint.swift https://github.com/apple/swift/pull/964/files#diff-11 (2)
M test/Constraints/invalid_constraint_lookup.swift https://github.com/apple/swift/pull/964/files#diff-12 (6)
M test/Constraints/patterns.swift https://github.com/apple/swift/pull/964/files#diff-13 (2)
M test/Constraints/same_types.swift https://github.com/apple/swift/pull/964/files#diff-14 (4)
M test/Generics/Inputs/associated_types_multi_file_helper.swift https://github.com/apple/swift/pull/964/files#diff-15 (2)
M test/Generics/associated_self_constraints.swift https://github.com/apple/swift/pull/964/files#diff-16 (6)
M test/Generics/associated_type_typo.swift https://github.com/apple/swift/pull/964/files#diff-17 (4)
M test/Generics/associated_types.swift https://github.com/apple/swift/pull/964/files#diff-18 (27)
M test/Generics/associated_types_inherit.swift https://github.com/apple/swift/pull/964/files#diff-19 (2)
M test/Generics/deduction.swift https://github.com/apple/swift/pull/964/files#diff-20 (2)
M test/Generics/function_defs.swift https://github.com/apple/swift/pull/964/files#diff-21 (26)
M test/Generics/generic_types.swift https://github.com/apple/swift/pull/964/files#diff-22 (4)
M test/Generics/requirement_inference.swift https://github.com/apple/swift/pull/964/files#diff-23 (22)
M test/Generics/same_type_constraints.swift https://github.com/apple/swift/pull/964/files#diff-24 (34)
M test/IDE/complete_associated_types.swift https://github.com/apple/swift/pull/964/files#diff-25 (126)
M test/IDE/complete_enum_elements.swift https://github.com/apple/swift/pull/964/files#diff-26 (4)
M test/IDE/complete_value_expr.swift https://github.com/apple/swift/pull/964/files#diff-27 (2)
M test/IDE/print_ast_tc_decls.swift https://github.com/apple/swift/pull/964/files#diff-28 (24)
M test/IDE/print_ast_tc_decls_errors.swift https://github.com/apple/swift/pull/964/files#diff-29 (26)
M test/IDE/print_types.swift https://github.com/apple/swift/pull/964/files#diff-30 (2)
M test/IDE/print_usrs.swift https://github.com/apple/swift/pull/964/files#diff-31 (4)
M test/NameBinding/accessibility.swift https://github.com/apple/swift/pull/964/files#diff-32 (2)
M test/NameBinding/name_lookup.swift https://github.com/apple/swift/pull/964/files#diff-33 (2)
M test/NameBinding/stdlib.swift https://github.com/apple/swift/pull/964/files#diff-34 (2)
M test/Parse/type_expr.swift https://github.com/apple/swift/pull/964/files#diff-35 (2)
M test/SILGen/errors.swift https://github.com/apple/swift/pull/964/files#diff-36 (2)
M test/Sema/accessibility.swift https://github.com/apple/swift/pull/964/files#diff-37 (30)
M test/Sema/availability_versions.swift https://github.com/apple/swift/pull/964/files#diff-38 (2)
M test/Sema/circular_decl_checking.swift https://github.com/apple/swift/pull/964/files#diff-39 (4)
M test/Sema/diag_values_of_module_type.swift https://github.com/apple/swift/pull/964/files#diff-40 (2)
M test/SourceKit/CodeComplete/complete_override.swift.response https://github.com/apple/swift/pull/964/files#diff-41 (9)
M test/SourceKit/DocSupport/Inputs/cake.swift https://github.com/apple/swift/pull/964/files#diff-42 (2)
M test/SourceKit/DocSupport/Inputs/main.swift https://github.com/apple/swift/pull/964/files#diff-43 (2)
M test/SourceKit/DocSupport/doc_source_file.swift.response https://github.com/apple/swift/pull/964/files#diff-44 (110)
M test/SourceKit/DocSupport/doc_swift_module.swift.response https://github.com/apple/swift/pull/964/files#diff-45 (106)
M test/attr/accessibility.swift https://github.com/apple/swift/pull/964/files#diff-46 (8)
M test/attr/accessibility_print.swift https://github.com/apple/swift/pull/964/files#diff-47 (14)
M test/attr/attr_autoclosure.swift https://github.com/apple/swift/pull/964/files#diff-48 (4)
M test/attr/attr_noescape.swift https://github.com/apple/swift/pull/964/files#diff-49 (4)
M test/decl/ext/extensions.swift https://github.com/apple/swift/pull/964/files#diff-50 (2)
M test/decl/ext/generic.swift https://github.com/apple/swift/pull/964/files#diff-51 (6)
M test/decl/ext/protocol.swift https://github.com/apple/swift/pull/964/files#diff-52 (32)
M test/decl/nested.swift https://github.com/apple/swift/pull/964/files#diff-53 (10)
M test/decl/protocol/conforms/associated_type.swift https://github.com/apple/swift/pull/964/files#diff-54 (2)
M test/decl/protocol/conforms/failure.swift https://github.com/apple/swift/pull/964/files#diff-55 (10)
M test/decl/protocol/conforms/inherited.swift https://github.com/apple/swift/pull/964/files#diff-56 (2)
M test/decl/protocol/indirectly_recursive_requirement.swift https://github.com/apple/swift/pull/964/files#diff-57 (4)
M test/decl/protocol/protocol_overload_selection.swift https://github.com/apple/swift/pull/964/files#diff-58 (6)
M test/decl/protocol/protocols.swift https://github.com/apple/swift/pull/964/files#diff-59 (18)
M test/decl/protocol/recursive_requirement.swift https://github.com/apple/swift/pull/964/files#diff-60 (18)
M test/decl/protocol/req/associated_type_default.swift https://github.com/apple/swift/pull/964/files#diff-61 (6)
M test/decl/protocol/req/associated_type_inference.swift https://github.com/apple/swift/pull/964/files#diff-62 (40)
M test/decl/protocol/req/func.swift https://github.com/apple/swift/pull/964/files#diff-63 (10)
M test/decl/protocol/req/optional.swift https://github.com/apple/swift/pull/964/files#diff-64 (2)
M test/decl/protocol/req/recursion.swift https://github.com/apple/swift/pull/964/files#diff-65 (6)
M test/decl/subscript/subscripting.swift https://github.com/apple/swift/pull/964/files#diff-66 (2)
M test/decl/typealias/associated_types.swift https://github.com/apple/swift/pull/964/files#diff-67 (2)
M test/decl/typealias/dependent_types.swift https://github.com/apple/swift/pull/964/files#diff-68 (4)
M test/decl/var/properties.swift https://github.com/apple/swift/pull/964/files#diff-69 (2)
M test/type/protocol_types.swift https://github.com/apple/swift/pull/964/files#diff-70 (2)
M tools/SourceKit/lib/SwiftLang/CodeCompletionOrganizer.cpp https://github.com/apple/swift/pull/964/files#diff-71 (1)
M tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp https://github.com/apple/swift/pull/964/files#diff-72 (6)
Patch Links:
https://github.com/apple/swift/pull/964.patch https://github.com/apple/swift/pull/964.patch
https://github.com/apple/swift/pull/964.diff https://github.com/apple/swift/pull/964.diff
—
Reply to this email directly or view it on GitHub https://github.com/apple/swift/pull/964.

-Dave

@dabrahams No, the typealias isn't required at all, but it does appear to be a fairly common pattern to write something like it - @DougGregor 's suggested diagnosis text is great for telling people it isn't needed.
Also: squashed!


change messaging to reflect multi link selecting and deleting

@calebissharp I'm thinking the quick win to getting client linking to match on all client id's is to make minimal changes to this page and do it from the endpoint.

Superseded by #852


assert_eq_text!(expected, actual) calls are reversed in a lot of cases

assert_eq_text!(expected, actual) Is how this is written but most callers have the arguments swapped.

@kjeremy  Hi, I'd like to work on this issue.

@kjeremy  Hi, I'd like to work on this issue.

Go for it!
On Fri, Jan 15, 2021, 8:14 PM Y.Horie<EMAIL_ADDRESS>wrote:

@kjeremy https://github.com/kjeremy Hi, I'd like to work on this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/7283#issuecomment-761282248,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBACRB4EAOQVDLXNNV3U63S2DR7VANCNFSM4WEGPKIQ
.

Go for it!
On Fri, Jan 15, 2021, 8:14 PM Y.Horie<EMAIL_ADDRESS>wrote:

@kjeremy https://github.com/kjeremy Hi, I'd like to work on this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/issues/7283#issuecomment-761282248,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBACRB4EAOQVDLXNNV3U63S2DR7VANCNFSM4WEGPKIQ
.


Set remote user to orchestration_ansible_user

Problem
The corrected task tries to log in to managed node as root, when in fact it should be the orchestration_ansible_user
Solution
remote_user value switched from root to orchestration_ansible_user

Thank you, for the PR. These changes are already included in SDAF - Release 3.9.0


Support for tabs

Current Behavior
When using Docusaurus Tabs only the first tab is captured.
Expected Behavior
Using Docusaurus Tabs and generating a PDF, content from all tabs should be shown

In Docusaurus official demo the DOM hidden by the hidden attribute. I think you can made them visible using custom CSS.


[Bug]: Animated gifs not working with next/image on netlify

Summary
When I import an gif with next/image the image processing on netlify somehow makes the gif not animate anymore.
Steps to reproduce
import Image from 'next/image';

export const whoa = (
  <Image
    src="/mind-blown-shocked.gif"
    alt="whoa"
    width={30}
    height={50}
    style={{ display: 'inline-block' }}
  />
);

https://react-docgen.dev/_next/image?url=%2Fmind-blown-shocked.gif&w=64&q=75
A link to a reproduction repository
https://github.com/reactjs/react-docgen/tree/main/packages/website
Next Runtime version
4.29.3
More information about your build

[ ] I am building using the CLI
[X] I am building using file-based configuration (netlify.toml)

What OS are you using?
Mac OS
Your netlify.toml file

`netlify.toml`
[build]
command = "pnpm build"
publish = ".next"

[[plugins]]
package = "@netlify/plugin-nextjs"

Your public/_redirects file
No response
Your next.config.js file

`next.config.js`
const withNextra = require('nextra')({
  theme: 'nextra-theme-docs',
  themeConfig: './theme.config.tsx',
});

module.exports = withNextra();

Builds logs (or link to your logs)
https://app.netlify.com/sites/react-docgen/deploys/639d0da968a9cd0008809b18

Yeah, the problem here is that it's automatically converting it to webp. I'm not sure what the best workaround is for that (i.e. whether we need to special-case gifs)

I was also reading #787 which seems to be the same issue and I wonder why it doesn't work, as ipx does seem to have added support for gif: https://github.com/unjs/ipx/blob/main/src/ipx.ts#L125

It's because we use content negotiation, which means we explicitly set the output format. Otherwise we'd only ever return the response in the same format as the original image, rather than using next-gen formats like webp

Closing as duplicate https://github.com/netlify/next-runtime/issues/1841


337: Basic Accordion implementation

Fix #337
Test URLs:

Before: https://main--hlx-test--urfuwo.hlx.live/resources/data-management-glossary

After: https://337-accordion-basic-block--hlx-test--urfuwo.hlx.live/resources/data-management-glossary

[x] New Blocks introduced in this PR

Block Name
Documentation
Library Link

accordion
doc-link
Library Link

Can we move the icons to the left like we have in Figma?

@mhaack We can, there will be a follow up PR with all the styling changes


Patch category trait

fixes #19

Closing this. @MindaugasR is working to change behaviour with content traits. These changes will be incompatible anyway.


Not honoring test group configurations [6.0.1 -> 6.1.x]

When updating the Maven dependency from v6.0.1 to v6.1.1, the test suite fails due to the parameters not being supplied. This occurs because the tests are being run outside of their test group and the params are selectively configured in the YAML file.
See,
http://code.google.com/p/concurrentlinkedhashmap/source/browse/trunk
Configuration:
http://code.google.com/p/concurrentlinkedhashmap/source/browse/trunk/src/test/resources/testng.yaml
All tests are run regardless of what group is requested to be executed, such as by executing the command:
$ mvn -P caliper test
should run a benchmark inside of a sub-package. Instead it fails as below.
Note that this works correctly in v6.0.1, but not in v6.1.x. Please see the README.md file if you want to build the project.
Thanks,
Ben

T E S T S
Running TestSuite
org.apache.maven.surefire.booter.SurefireExecutionException:
Parameter 'iterations' is required by @Parameters on method public com.googlecode.concurrentlinkedhashmap.MultiThreadedTest(int,int,int)
but has not been marked @Optional or defined in /usr/local/google/bmanes/clients/lru/src/test/resources/testng.yaml; nested exception is org.testng.TestNGException:
Parameter 'iterations' is required by @Parameters on method public com.googlecode.concurrentlinkedhashmap.MultiThreadedTest(int,int,int)
but has not been marked @Optional or defined in /usr/local/google/bmanes/clients/lru/src/test/resources/testng.yaml
org.testng.TestNGException:
Parameter 'iterations' is required by @Parameters on method public com.googlecode.concurrentlinkedhashmap.MultiThreadedTest(int,int,int)
but has not been marked @Optional or defined in /usr/local/google/bmanes/clients/lru/src/test/resources/testng.yaml
at org.testng.internal.Parameters.createParameters(Parameters.java:144)
at org.testng.internal.Parameters.createInstantiationParameters(Parameters.java:52)
at org.testng.internal.ClassHelper.createInstance1(ClassHelper.java:315)
at org.testng.internal.ClassHelper.createInstance(ClassHelper.java:284)
at org.testng.internal.ClassImpl.getDefaultInstance(ClassImpl.java:109)
at org.testng.internal.ClassImpl.getInstances(ClassImpl.java:181)
at org.testng.internal.TestNGClassFinder.(TestNGClassFinder.java:120)
at org.testng.TestRunner.initMethods(TestRunner.java:402)
at org.testng.TestRunner.init(TestRunner.java:228)
at org.testng.TestRunner.init(TestRunner.java:198)
at org.testng.TestRunner.(TestRunner.java:147)
at org.testng.SuiteRunner$DefaultTestRunnerFactory.newTestRunner(SuiteRunner.java:525)
at org.testng.SuiteRunner.init(SuiteRunner.java:156)
at org.testng.SuiteRunner.(SuiteRunner.java:110)
at org.testng.TestNG.createSuiteRunner(TestNG.java:1235)
at org.testng.TestNG.createSuiteRunners(TestNG.java:1222)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1074)
at org.testng.TestNG.run(TestNG.java:999)
at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:74)
at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:92)
at org.apache.maven.surefire.Surefire.run(Surefire.java:180)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.813s
[INFO] Finished at: Mon Jul 18 14:12:06 PDT 2011
[INFO] Final Memory: 5M/79M
[INFO] ------------------------------------------------------------------------

This doesn't seem to be a problem anymore with TestNG 6.12.
Here's what I have
Github69TestClass.java
import org.testng.annotations.Parameters;
import org.testng.annotations.Test;

@Test(groups = {"github69"})
public class Github69TestClass {
    private String name;
    private int age;

    @Parameters({"name", "age"})
    public Github69TestClass(String name, int age) {
        this.name = name;
        this.age = age;
    }

    public void testMethod() {
        System.err.println(String.format("[%s is %d years old]", name, age));
    }
}

Yaml file used is as below
name: ConcurrentLinkedHashMap

tests:
  - name: Stress Tests
    parameters:
      name: "Old Monk"
      age: 65
    classes:
      - com.rationaleemotions.github.issue69.Github69TestClass

Maven surefire plugin looks like below
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>2.19.1</version>
    <configuration>
        <groups>github69</groups>
        <suiteXmlFiles>
            <suiteXmlFile>src/test/resources/github69.yaml</suiteXmlFile>
        </suiteXmlFiles>
    </configuration>
</plugin>

Selective Output looks like below
✔ ~/githome/PlayGround/testbed
09:27 $ mvn clean test
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building testbed 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ testbed ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running TestSuite
...
... TestNG 6.12 by Cédric Beust<EMAIL_ADDRESS>...

[Old Monk is 65 years old]
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.351 sec - in TestSuite

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.741 s
[INFO] Finished at: 2017-09-17T09:29:28+05:30
[INFO] Final Memory: 36M/328M
[INFO] ------------------------------------------------------------------------
✔ ~/githome/PlayGround/testbed

Cloning the github repo and making changes to run on Java 8 (removing the CHM backport), it fails when upgrading to 6.11 (latest on Central). This isn't blocking me as I don't use this format in Caffeine, the successor.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18:test (default-test) on project concurrentlinkedhashmap-lru: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.18:test failed: There was an error in the forked process
[ERROR] org.testng.TestNGException:
[ERROR] Parameter 'threads' is required by @Parameters on method public com.googlecode.concurrentlinkedhashmap.MemoryLeakTest(int,long) but has not been marked @Optional or defined
[ERROR] in /Users/ben/projects/concurrentlinkedhashmap/src/test/resources/testng.yaml
[ERROR] 	at org.testng.internal.Parameters.createParameters(Parameters.java:199)
[ERROR] 	at org.testng.internal.Parameters.createInstantiationParameters(Parameters.java:88)

@ben-manes - Can you please help share a small project which can be executed to recreate the problem ?

You can clone the repository, download the patch file, and use git apply testng.txt. Probably that's the easiest since I haven't looked at this problem for 6 years (and fine it closed as too old to revisit).

@ben-manes - I will give this a try and let you know how it goes. If its a problem, I would like to try and fix it, than close it off as too old to revisit :) If I can reproduce it, I will re-open the issue.

Thanks. FYI, in the NOTES it has build instructions as there was a dependency not on Central (I think it later became JBoss Railgun)
mvn install:install-file \
    -Dfile=lib/cache-benchmark/benchmark-fwk.jar \
    -DpomFile=lib/cache-benchmark/pom.xml

Able to reproduce the issue using TestNG 6.12 using the information and patch that @ben-manes has shared.

@ben-manes - I spent sometime trying to debug the problem and it looks like it boils down to the below section in your suite yaml file
tests:
  - name: Standard Tests
    parameters:
      capacity: 100
    packages:
      - name: com.googlecode.concurrentlinkedhashmap
        exclude:
          - RingBufferTest
          - MemoryLeakTest
          - MultiThreadedTest

Here TestNG is expecting that you provide with a package name in the exclude list, but you have provided class names. That is why when TestNG is initializing itself for the test Standard Tests it is not excluding these three classes. TestNG tries to instantiate MemoryLeakTest and finds that it has a @Parameters annotated constructor, but there are no parameters called "threads", "statusInterval" being passed from the <test> which explains the failures.
You should be passing in a valid package name for exclude:
I tried relocating those tests to another package called special
✔ ~/githome/OpenSource/concurrentlinkedhashmap/src/test/java/com/googlecode/concurrentlinkedhashmap [master|●3✚ 9…55]
13:30 $ tree special/
special/
├── MemoryLeakTest.java
└── MultiThreadedTest.java

And then I reran the tests with the same command and the tests run (of-course the JVM crashes but I don't think its related to the current problem )
Here's how the modified section of the yaml file looks like
tests:
  - name: Standard Tests
    parameters:
      capacity: 100
    packages:
      - name: com.googlecode.concurrentlinkedhashmap
        exclude:
          - com.googlecode.concurrentlinkedhashmap.special.*

Here's the execution output
13:30 $ mvn -P caliper test
[INFO] Scanning for projects...
[WARNING] The project com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:jar:1.4.3-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building ConcurrentLinkedHashMap 1.4.3-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-maven) @ concurrentlinkedhashmap-lru ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ concurrentlinkedhashmap-lru ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap/src/main/resources
[INFO]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ concurrentlinkedhashmap-lru ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 7 source files to /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap/target/classes
[INFO]
[INFO] --- animal-sniffer-maven-plugin:1.13:check (check-java16-sun) @ concurrentlinkedhashmap-lru ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16-sun:1.0
[INFO]
[INFO] --- maven-bundle-plugin:2.5.3:manifest (bundle-manifest) @ concurrentlinkedhashmap-lru ---
[WARNING] Manifest com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:jar:1.4.3-SNAPSHOT : Unused Import-Package instructions: [sun.misc.*]
[INFO]
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ concurrentlinkedhashmap-lru ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 5 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ concurrentlinkedhashmap-lru ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:2.18:test (default-test) @ concurrentlinkedhashmap-lru ---
[INFO] Surefire report directory: /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running TestSuite

[Caliper Benchmark]
Running GetPutBenchmark
Experiment selection:
  Instruments:   [allocation, micro]
  User parameters:   {cache=[Guava, ConcurrentHashMap, LinkedHashMap_Lru_Lock, ConcurrentLinkedHashMap]}
  Virtual machines:  [default]
  Selection type:    Full cartesian product

This selection yields 16 experiments.
Starting experiment 1 of 16: {instrument=allocation, method=Get, vm=default, parameters={cache=Guava}}
The worker exited without producing data. It has likely crashed. Run with --verbose to see any worker output.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.131 s
[INFO] Finished at: 2017-09-17T13:31:00+05:30
[INFO] Final Memory: 25M/308M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18:test (default-test) on project concurrentlinkedhashmap-lru: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.18:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap && /Library/Java/JavaVirtualMachines/jdk1.8.0_131.jdk/Contents/Home/jre/bin/java -jar /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap/target/surefire/surefirebooter2031855192755535703.jar /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap/target/surefire/surefire6877731661671688379tmp /Users/krmahadevan/githome/OpenSource/concurrentlinkedhashmap/target/surefire/surefire_02971522054735753782tmp
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException

Please let me know if that makes sense.

Interesting. It was nice to be able to exclude classes. Do you know why that feature was dropped in 6.1?

Ping @cbeust
What is the expected behavior?


Delete VMware Workstation Pro

Workstation Pro is now free for personal use, but the dowload is locked behind a Broadcom account and extensive data sharing.
Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest

Workstation Pro is now free for personal use, but the dowload is locked behind a Broadcom account and extensive data sharing.
Broadcom has ceased VMware Download servers: now downloads go trough Broadcom's servers. The new download link is https://downloads2.broadcom.com/?file=VMware-workstation-full-17.5.2-23775571.exe but it doesn't work without your personal authentication headers.
This package in a broken state right now.
There's no solution to this sad change, hence removing it.
Source: I am a Broadcom (ex VMware) employee.
Microsoft Reviewers: Open in CodeFlow

URL: https://download3.vmware.com/software/WKST-1750-WIN/VMware-workstation-full-17.5.0-22583795.exe
Response Error: The remote server returned an error: (522).
(Automated message - build 887)

Hi @auanasgheps,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 881.)

It's still possible to download VMWare Workstation Pro without any registration from this link.
It would not be a drop-in replacement since they've decided to "compress" the files.
I'm not familiar with winget but I guess it would not be too hard to support .tar extraction.

仍然可以从此链接下载 VMWare Workstation Pro，无需任何注册。（来自官方域名）
由于他们决定“压缩”文件，因此它不会成为直接替代品。 我对此并不熟悉，winget但我猜支持提取不会太难.tar。

Latest version url:
https://softwareupdate.vmware.com/cds/vmw-desktop/ws/17.5.2/23775571/windows/core/VMware-workstation-17.5.2-23775571.exe.tar

Hi, thanks for letting me know, but tar packages are not supported by winget.
We have to wait for #2899

Just to clarify, waiting for: https://github.com/microsoft/winget-cli/issues/2899

It's still possible to download VMWare Workstation Pro without any registration from this link. (from the official domain)

For some reason it needs to be https://softwareupdate.vmware.com/cds/vmw-desktop/ws/, not https://softwareupdate.vmware.com/cds/vmw-desktop/ws. Without the / at the end, clicking the version links leads to Object Not Found.


Login page

Ned to create a login page. user able to insert the username and password as inpput values

Done!


Mergebot config for DCOS-UI.

This is the config for mergebot. It enables integrate-it for your repo.

When the owners in the file give a command integrate-it, it will automatically create a buildinfo.json change pull request against dcos/dcos.
Let me know who else needs to be in the owners.json and I will add it.

Looks I like deleted the fork of the project and I don't have write access to update the PR. I will send another PR with these review comments addressed. Sorry for this churn.

Here is the PR with the review comments addressed: https://github.com/dcos/dcos-ui/pull/1321
I like to close this PR and please review the update one. Thank you!


[Problem] Largest palindrome product

Largest palindrome product
Palindromic number reads the same both ways.
The largest palindrome made from the product of two 2-digit numbers is 9009 = 91 × 99.

Find the largest palindrome made from the product of two 3-digit numbers.

Hello ademclk,
I would love to try out this challenge,
Can it be assigned to me ??

Hello Ademclk,
I have created a PR for this Issue,
waiting for your review

It doesn't work properly. Result: 580085. It should be 906609.

Thank you Ademclk
It has been resolved


Handle many items in category nav menu

See screenshot
Apparel 'Brands' has a long list of items
We should scroll after a configurable # of items and/or automatically put into columns (brainstorm what's best to do considering we also support a second level already)

Don't know where to find this "Brands" list. It/was it a filter? Is this depreciated?

Change content catalog from electronics-spa to apparel-de. You should then see different assortment, menus and so on.

I am getting response "Base site apparel-de doesn't exist". Same with apparel-uk and apparel.

i added occ impex to https://dev-com-5.accdemo.b2c.ydev.hybris.com:9002 which has apparel
Accelerator is https://apparel-uk.dev-com-5.accdemo.b2c.ydev.hybris.com:9002/yacceleratorstorefront/

url for testing http://localhost:4200/apparel-de/de/EUR/

Tested on dev2.


Improvements for ITN orchestrator

This PR delivers a number of improvements to orchestrator/generator.
Explain your changes:

Add support for stop-daemon command to orchestrator and generator
Add support for parallel execution of funding commands

Significantly speeds up start of an experiment (from 2 hours to ~20 minutes)

Add support for use of multiple daemons in funding step

Increases reliability of funding step

Add support for max-cost transactions to generator
Fix a bug in zkapp command handling on orchestrator

Explain how you tested your changes:

Tested by repeatedly running the tool on a cluster

Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? None

Closes #0000

!ci-build-me

!approved-for-mainnet


Possibly Incorrect Info Regarding 2nd Self-Paid Dose

Possible Issue

If you previously got your first dose through this program, you can schedule your second shot directly with your hospital.

I can't find any official reference to support this statement. Do you happen to have a citation for this?
According to the official CECC announcement  on 5/15, it states:

後續視國內疫情狀況及疫苗進口數量，再行調撥疫苗，提供出國民眾自費接種使用

This seems to only indicate that, in the future, they will reconsider and possibly allocate doses to the self-paid program using two factors: (1) the state of the pandemic; and (2) the number of vaccine doses that are imported.
Possible Change
Perhaps a link to the official CECC announcement regarding this should be provided instead of asserting whether or not someone can book a second shot. Something like:
For more information, please refer to the official CECC announcement.

Hey, thanks for stopping by! Got a lot of questions about this one too. :) My source so far is my recollection of Chen Shih-Chung's press conference the day he cancelled the self-paid vaccination program. I am going to call 1922, the hotline to confirm this, and also see if I can find the press conference again.

@mrblueblue hey there! I took a look on the CDC transcripts on this timestamp of the video on May 15, 2021. This seems to be what I heard. If not, we can always call 1922 again to confirm.


ImagePull failure - can't unmount tmpmount

Description
We occasionally get ImagePull errors, particularly at node start time, but at other times too.
Steps to reproduce the issue

Describe the results you received and expected
Expected: images that exist and are accessible on other nodes pull on every node
Actual (I've added extra line breaks so that the output is readable):
May 17 02:30:09 ip-172-18-13-191.us-west-2.compute.internal kubelet[4461]: E0517 02:30:09.771490
    4461 pod_workers.go:1300] "Error syncing pod, skipping" err="failed to \"StartContainer\" for \"kafka\"
with ErrImagePull: \"failed to pull and unpack image \\\"docker.io/confluentinc/cp-kafka:7.3.3\\\": failed to extract layer
sha256:969795712c492f0c43031ce89dfb3d6ca2c08221fc28fb4479c7e0a370af7342: failed to unmount /var/lib/
containerd/tmpmounts/containerd-mount2055904353: failed to unmount target /var/lib/containerd/tmpmounts/
containerd-mount2055904353: device or resource busy: unknown\"" pod="management/kafka-1" podUID="31a80586-
e277-4270-93ae-eb14a2615692"

bash-5.1# grep /var/lib/containerd/tmpmounts/containerd-mount2055904353 /proc/1/mountinfo
19294 128 259:16 /var/lib/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1389/fs//deleted
/var/lib/containerd/tmpmounts/containerd-mount2055904353 rw,nosuid,nodev,noatime
 shared:68 - xfs /dev/nvme1n1p1 rw,seclabel,attr2,inode64,logbufs=8,logbsize=32k,noquota

I've tried straceing this but all I see is EBUSY returned from the umount2 system call. I can't find any candidates for the mount being used elsewhere - I've looked for candidate processes similar to fluent from #9530 but we don't seem to hostPath mount /var/lib or /var/lib/containerd anywhere.
What version of containerd are you using?
containerd github.com/containerd/containerd 1.6.31+bottlerocket e377cd56a71523140ca6ae87e30244719194a521
Any other relevant information
bash-5.1# runc --version
runc version 1.1.12+bottlerocket
commit: 51d5e94601ceffbbd85688df1c928ecccbfa4685
spec: 1.0.2-dev
go: go1.21.9
libseccomp: 2.5.5
bash-5.1# crictl info
bash: crictl: command not found
bash-5.1# uname -a
Linux ip-172-18-13-191.us-west-2.compute.internal 6.1.87 #1 SMP PREEMPT_DYNAMIC Wed May  8 18:52:52 UTC 2024 x86_64 GNU/Linux

Show configuration if it is related to CRI plugin.
version = 2
root = "/var/lib/containerd"
state = "/run/containerd"
disabled_plugins = [
    "io.containerd.internal.v1.opt",
    "io.containerd.snapshotter.v1.aufs",
    "io.containerd.snapshotter.v1.devmapper",
    "io.containerd.snapshotter.v1.native",
    "io.containerd.snapshotter.v1.zfs",
]

[grpc]
address = "/run/containerd/containerd.sock"

[plugins."io.containerd.grpc.v1.cri"]
enable_selinux = true
# Pause container image is specified here, shares the same image as kubelet's pod-infra-container-image
sandbox_image = "602401143452.dkr.ecr.us-west-2.amazonaws.com/eks/pause:3.1-eksbuild.1"

[plugins."io.containerd.grpc.v1.cri".containerd]
default_runtime_name = "shimpei"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.shimpei]
runtime_type = "io.containerd.runc.v2"
base_runtime_spec = "/etc/containerd/cri-base.json"

[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.shimpei.options]
SystemdCgroup = true
BinaryName = "shimpei"

[plugins."io.containerd.grpc.v1.cri".cni]
bin_dir = "/opt/cni/bin"
conf_dir = "/etc/cni/net.d"

Hey @willthames, are you running some kind of monitoring/security software on your nodes by any chance. If yes, it might be something similar as https://github.com/containerd/containerd/issues/5538

@Fricounet not as far as I can tell - we do have a few daemonset agents that could theoretically be responsible but none of them mount the host volumes that would be needed to keep the tmpmounts files open.
We also don't have anything weird running on the host outside of containers - our production instances are bottlerocket instances using AWS's AMIs
kubectl get ds -A -o custom-columns="NAMESPACE:.metadata.namespace,NAME:.metadata.name,VOLUMES:.spec.template.spec.volumes[*].hostPath.path"
NAMESPACE       NAME                                  VOLUMES
ingress-nginx   nginx-ingress-controller-internal     /var/lib/observability/nginx.conf
kube-system     calico-node                           /lib/modules,/var/run/calico,/var/lib/calico,/run/xtables.lock,/sys/fs/,/sys/fs/bpf,/proc,/opt/cni/bin,/etc/cni/net.d,/var/log/calico/cni,/var/lib/cni/networks,/var/run/nodeagent
kube-system     kube-proxy                            /var/log,/run/xtables.lock,/lib/modules
management      ebs-csi-node                          /var/lib/kubelet,/var/lib/kubelet/plugins/ebs.csi.aws.com/,/var/lib/kubelet/plugins_registry/,/dev
management      efs-csi-node                          /var/lib/kubelet,/var/lib/kubelet/plugins/efs.csi.aws.com/,/var/lib/kubelet/plugins_registry/,/var/run/efs,/var/amazon/efs,/etc/amazon/efs
monitoring      datadog                               /proc,/sys/fs/cgroup,/etc/os-release,/etc/redhat-release,/etc/fedora-release,/etc/lsb-release,/etc/system-release,/var/lib/kubelet/seccomp,/sys/kernel/debug,/lib/modules,/usr/src,/var/tmp/datadog-agent/system-probe/build,/var/tmp/datadog-agent/system-probe/kernel-headers,/etc/apt,/etc/yum.repos.d,/etc/zypp,/etc/pki,/etc/yum/vars,/etc/dnf/vars,/etc/rhsm,/etc/passwd,/,/var/lib/datadog-agent/logs,/var/log/pods,/var/log/containers,/var/lib/docker/containers,/var/run
monitoring      fluent-bit                            /var/log,/var/lib/docker/containers,/etc/machine-id
monitoring      monitoring-prometheus-node-exporter   /proc,/sys,/
monitoring      node-outbound-exporter                <none>
wiz             wiz-sensor                            /var/lib/wiz/

I'm going to close this one as there is a subtle / in the datadog mount list that I didn't spot when adding the previous comment. Not giving datadog access to / has reduced the occurrence of this problem considerably (and increased security and didn't seem to really affect what we get out of the datadog pod)


myAlgoWallet.connect() is only returning 1 address even if you have multiple addresses present in your MyAlgoWallet.

Tried playing around with the API and noticed that an array of addressess is intended to be returned by the myAlgoConnect.connect() method. I have imported a 2nd address over but the method is only returning the first address at the moment. I'm not sure if this is intended behaviour and would appreciate some clarity as to how would I access the second address stored in the wallet.

Probably session related, closed everything reopened and could view both addresses

Hello @raelyz ! One important thing is that MyAlgo Connect will only share accounts created by a mnemonic or ledger. (Multisig account or track account it is not supported).

Hey @Alex99y! Thanks for pointing that out, if that is the case are there any intentions to include support for multisig/track accounts?

@raelyz Currently, we have no plan to share track accounts but multisig accounts yes. Do you mean by using Ledger Live it shows you more than one address?

@Alex99y yup, Ledger Live shows me more than one address but myalgo wallet only shows me 1.

@raelyz Yes, because Ledger Live derivates more public keys. Currently, MyAlgo only gets the first derivation, and it is in our plan to support wallet HD from Ledger Wallet.


fix(chat): fix folder selection in unpublish request modal (Issue #1867)

Description:

fix selectable folders in unpublish modal

Issues:

Issue #1867

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review


Fake Currecny Detection

@Niketkumardheeryan Can you please assign me the issue soon

@Niketkumardheeryan Please assign me this issue

@Saipradyumnagoud the issue is assigned.


excess comma removed

This is how i remove commas

Thanks for the explanation, really appreciated. I would like to translate
this project to Turkish. Do you think it is a good idea? Should i start it ?
On Wed, 28 Nov 2018 at 21:40, rodgoeliz<EMAIL_ADDRESS>wrote:

@rodgoeliz commented on this pull request.
In README.md
https://github.com/ryanmcdermott/clean-code-javascript/pull/248#discussion_r237210747
:

@@ -108,7 +108,7 @@ saveCityZipCode(address.match(cityZipCodeRegex)[1], address.match(cityZipCodeReg

const address = 'One Infinite Loop, Cupertino 95014';
const cityZipCodeRegex = /^[^,\\]+[,\\\s]+(.+?)\s*(\d{5})?$/;
-const [, city, zipCode] = address.match(cityZipCodeRegex) || [];
+const [city, zipCode] = address.match(cityZipCodeRegex) || [];

@jankoboz <https://github.com/jankoboz> The entire string is matched
because of the capturing groups, "( )" in the regex :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/ryanmcdermott/clean-code-javascript/pull/248#discussion_r237210747>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AZT_hWUCADtPohAtU74Q42XDWcIxuBtRks5uztiRgaJpZM4YXSnT>
.


Book Issue - Route prerequesites example

Not sure if this is the right place for this but in the section of chapter 3 discussing route prerequsites, the code example shows two arrays for pre but I think it's supposed to be mixed with an object to demonstrate the serial/parallel difference.

Hi Mike,
Thanks for the note!  Sorry that it isn't clear but both the variables series and parallel are objects like:
var series = { method: handler, assign: 'some_name' };
var parallel = { method: handler, assign: 'another_name' };

Everything in the outer array (in the pre) is going to be executed in series. So it does the first series, then the second. But when it gets to the array of parallel's, those two would executed in parallel before moving on to the final series.
pre: [
  series,
  series,
  [...],
  series
]

It kind of makes more sense if you keep reading and finish out that section.  But, we'll discuss ways to make that a lot clearer in the next update.

Ok I understand. Thanks for the reply I was confused but it's clear now.


Suggest release the .css files in the template in .scss format

Since all the MDL styles are developed using SASS, why the styles in the template are developed in raw CSS? If there's no copy right issue, would it make sense to release the SASS version of the styles?

They are raw CSS to show developers how to customize it to their needs. There are no Sass versions of those sources.
There won't be any modifications to the V1 template system at this point as it is a non-critical piece.
Thank you.


[DNM] test: adjust Migrator tests (NFCI)

This adjusts the test diffing to ignore the whitespace changes across
different platforms.  raw_fd_ostream will write out OF_Text files
with the platform's line endings, which may differ from the source
file's.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @gottesmm @JDevlieghere

PR Test: https://dev.azure.com/compnerd/swift-build/_build/results?buildId=24219&view=results

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 63d64b2a9608a153765c0343c26f32a580837d11

Build failed
Swift Test OS X Platform
Git Sha - 63d64b2a9608a153765c0343c26f32a580837d11

Merged through master.


Small Bug: API Version on Connections page does not change when Kong is upgraded.

The auto detected connections kong version is static, so while you may upgrade your kong connection version, this page will not detect that and leaves it at the original version the detection code must have seen originally. Needs to do a quick-check when that page loads to get the latest version and compare to current and update it if needed.

@jeremyjpj0916 ,
As a temp workaround, the node version is updated if you disable-reenable it from the connections page.

Right yeah I had noticed that behavior, not too shabby :).

@jeremyjpj0916 ,
this issue is addressed at v0.10.2.
Feel free to reopen if things are not working as expected.

Glad to see you back in action bud!


Improved docs or handling for closing the mobile menu

Was having trouble figuring out how to close the mobile menu programatically. On desktop one can bind to the ref method closeDropdown(), but for mobile there's no such method. For mobile, it's possible to bind a v-model to the vsm-mob component and switch it to true or false programatically. However, closeDropdown() would make more sense as handling the mobile dropdown as well. Or at least put in the docs that one can bind v-model to vsm-mob.

Added closeDropdown() method [1.5.0].


Change sass-rails dependency to sassc-rails?

sass-rails uses Ruby sass which is being deprecated in 26 March 2019 (http://sass.logdown.com/posts/7081811). Any thoughts of switching this project over to its replacement sassc-rails?

Yes I've been wondering what to do. We could switch it over but then I realized we don't have dependencies for other asset types like JS or images. I wonder if it might be better to just remove the dependency in a major release and in the installation instructions note that you have to have either sass-rails or sassc-rails in your Gemfile. What do you think? I think this would be ideal since that way you can choose now rather than let the library define it. Also sass-rails will be default be listed in any Rails generated Gemfile so it should be good.

I would be fine with removing the dependency and changing the installation instructions. Your reasoning makes sense to me. I had already changed my Gemfile to point to sassc-rails, so I'm already prepared.

Any news on this? The deadline is nearing rapidly.

Yes. I choose not to do anything because I found out that the plan is likely you won't have to make any changes. The sass-rails gem will be updated to use sassc under the hood.
https://github.com/activeadmin/activeadmin/pull/5504#issuecomment-456839445
https://github.com/rails/sass-rails/pull/424

I updated master so this gem no longer depends on sass-rails but instead on railties.
In the end everything has been fine since sass-rails was released as just a light wrapper around sassc-rails anyway.


Can't compile on Arch - no static gmp & sodium

Arch only provides dynamic libs for libgmp and libsodium, which I think is causing this to fail, even with the workaround listed here - https://github.com/madMAx43v3r/chia-plotter/issues/70
Attempted on both gcc-10 and 11

I confirm.
[ 95%] Built target test_disk_sort
[ 95%] Building CXX object CMakeFiles/check_phase_1.dir/test/check_phase_1.cpp.o
[ 96%] Linking CXX executable test_phase_4
[ 96%] Built target test_phase_4
/usr/bin/ar: /usr/lib/libgmp.so: file format not recognized
make[2]: *** [lib/bls-signatures/src/CMakeFiles/combined_custom.dir/build.make:73: lib/bls-signatures/src/CMakeFiles/combined_custom] Error 1
make[1]: *** [CMakeFiles/Makefile2:477: lib/bls-signatures/src/CMakeFiles/combined_custom.dir/all] Error 2

Issue is /usr/bin/ar     aims to extract   /usr/lib/libgmp.so    which isn't possible.   When for example static versions of libs sodium and gmp are installed   then you would find the lib files with ending .a   for example  /usr/lib64/libgmp.a

Issue is /usr/bin/ar aims to extract /usr/lib/libgmp.so which isn't possible. When for example static versions of libs sodium and gmp are installed then you would find the lib files with ending .a for example /usr/lib64/libgmp.a

Installed both static version plus modification mentioned in https://github.com/madMAx43v3r/chia-plotter/issues/70#issuecomment-857664855.
Managed to compile it but seems it doesnt work.
It closes itself after
Final Directory: ./ws/
Number of Plots: 20
Number of Threads: 4
Number of Sort Buckets: 2^7 (128)

Arch only provides dynamic libs for libgmp and libsodium, which I think is causing this to fail, even with the workaround listed here - #70
Attempted on both gcc-10 and 11

Arch has libgmp-static and libsodium-static libs. You can install them with yay (instead of pacman).

Arch only provides dynamic libs for libgmp and libsodium, which I think is causing this to fail, even with the workaround listed here - #70
Attempted on both gcc-10 and 11

Arch has libgmp-static and libsodium-static libs. You can install them with yay (instead of pacman).

For the record: https://aur.archlinux.org/packages/libsodium-static/ and https://aur.archlinux.org/packages/libgmp-static/

should be fixed now


Space - Stephanie

React Tic Tac Toe
Congratulations!  Please reflect on the assignment with these questions.
Reflection

Prompt
Response

How are events / event handlers and useState connected?
You can change the state based on events as triggers.

What are two ways to do "dynamic styling" with React? When should they be used?
Im not positive, but I think it means when you style right in the code, and when you style separately.

Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content.

CS Fundamentals Questions

Question
Answer

What do you think is the BigO complexity of the method you use to compute a winner?
O(n)

Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?Speculate wildly about what the Big-O time complexity of that code might be.
Well now I think its probably much bigger lol.

React Tic Tac Toe

Major Learning Goals/Code Review

Criteria
yes/no, and optionally any details/lines of code to reference

Demonstrates proper JavaScript coding style.
✔

Correctly passes props to child components.
✔

Correctly passes callback functions to child components and calls them to respond to user events.)
✔

Maintains the status of the game in state.
✔

Practices git with at least 6 small commits and meaningful commit messages
✔, you have 6 commits, but I strongly suggest that you use commit messages that describe functionality added rather than wave numbers.

Uses existing stylesheets to render components
✔

Functional Requirements

Functional Requirement
yes/no

The Square component renders properly and executes the callback on a click event.
✔

The Board component renders a collection of squares
✔

The App component renders a board and uses state to maintain the status of the game.
✔

Utilizes callbacks to UI events to update state
✔

Overall Feedback

Overall Feedback
Criteria
yes/no

Green (Meets/Exceeds Standards)
5+ in Code Review && 3+ in Functional Requirements
✔

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality
Yes?

Perfect Indentation
✅

Elegant/Clever
✅

Descriptive/Readable
✅

Concise
✅

Logical/Organized
✅

Summary
Nicely done.  You hit the main learning goals here.  I did spot one minor bug with resetGame, but otherwise this was very well done.  Nice work managing state in the application.


Missing scripts/data_preparation/

Hi,
I am not able to find the directory data_preparation as described in README. It would be really helpful if it can be added.
Thanks

Hi @hiraksarkar ,
thanks for mentioning! Please find the directory for data preparation here.
I added the respective notebook for the MERFISH - brain dataset.
We moved data preparation to notebooks, as this is currently only required for the MERFISH - brain dataset. For the remaining datasets no preprocessing was applied. Happy to link you to the original datasets or assist further if needed.

I left a comment on the Merfish dataset front in the tutorial issue (It seems without the CSV we can not run NCEM unfortunately). For other datasets it's not entirely clear to me which files should be downloaded and how to provide them to NCEM. Apologies if there is already a tutorial that I have missed.
For example, in  case of "CODEX cancer" data, the actual paper leads to a dataset directory. It contains around 2 TB of processed images. Should I download that ? Given that directory I am not sure how do I call NCEM on that. The merfish data should be more straightforward given I can obtain the metadata.csv file.
Thanks

Hi @AnnaChristina amazing, really appreciate the help, trying this now. I have some questions about the manuscript, should I just email them if that's possible.
Again, thanks a lot for helping.

Sure! Please feel free to raise additional issues whenever needed. Yes, just email me and @davidsebfischer. Happy to discuss and answer!

Hi @AnnaChristina ,
Just wanna mention the dataloader assumes scMEP_MIBI_singlecell.csv is inside a directory scMEP_MIBI_singlecell and not the zipped file.
Except that it is working fine, although I am using same variable values as mentioned for Zheng tutorial.

Hi @hiraksarkar,
Yes. The dataloader expects certain folder structures.  We will enhance this in the future.
Great. You can basically run the tutorial for each dataset with similar parameters. For more explanation on how to set specific parameters (e.g. radius), more information can be found in the data exploration notebooks and the manuscript.


[Bug]: Hardcoding of rolename avoids redeployment of multiple stacks

Describe the bug
Since IAM is global every new role name and policy name should be unique.
Having rolename hard coded throws error saying the role already exists and hence cannot create new role.
https://github.com/opensearch-project/opensearch-ci/blob/main/lib/compute/jenkins-main-node.ts#L93
To reproduce
Deploy stack in one region and try deploying the same stack in another region
Expected behavior
Stacks should deploy in multiple regions
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

We need the rolename defined for managing trust relationships with different stacks in roleArn. Any possible solutions on how we can export the auto-generated rolename to different stacks?

Looks this is by design since role are manually updated in other AWS accounts for trust relationship. Even the deployments won't change the role name as such however, the blast radius is huge here. Considering that, closing this issue for now.


Rename allow_concurrent_inputs in protobuf

Describe your changes
Rename allow_concurrent_inputs to target_concurrent_inputs in protobuf
 Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

[x] Client+Server: this change is compatible with old servers
[x] Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.

I am a little confused about this PR juxtaposed with https://github.com/modal-labs/modal-client/pull/2163/files; here we are doing allow_concurrent_inputs -> target_concurrent_inputs but in the other PR it looks like we're considering allow_concurrent_inputs the maximum and exposing a separate target parameter?


How to combine FeatureFlags settings from multiple providers / sources?

Say that I want to do the following:

use Azure App Configuration to set Feature Flags

for the production environment
as a baseline for the development environment

have a way for locally overriding the Feature Flags in the development environment, e.g. using cookies

The usecase for this is e.g. for testers / product owners to switch on/off Features when checking their behavior or presenting them, without needing access to Azure and without impacting others members of the development team.
The documentation explains how to add Azure App Configuration as a source for FeatureManagement. I assume I would need to implement an IFeatureFilter or an ISessionManager to provide the values from the cookies, but I don't see this documented.
I believe an IFeatureFilter should be able to independently provide a Feature value, so how can we set what source gets preference over the other? The comparison cannot be done inside the IFeatureFilter I believe.
The logic I want to achieve is this:

Azure App Configuration feature state
Local (cookie-based?) feature value
Calculated feature result

false
null
false

true
null
true

false
false
false

true
false
false

false
true
true

true
true
true

For now we decided to not use (cookie) overrides in our production environment. However it would be still a good thing to document I think.

Solved in https://github.com/microsoft/FeatureManagement-Dotnet/issues/37, so this can be closed.
There is also some feedback there (https://github.com/microsoft/FeatureManagement-Dotnet/issues/37#issuecomment-567612042) that it would be nice if the Feature Manager page of the Azure App Configuration product would integrate well with this usecase (being able to set a default with the on/off switches).


Update to 1.4.0

This PR includes the PR #13.
What this PR does:

changes everything from .ns to .js
change "hack" command suggestions from find.js to "backdoor"
fix stock scripts to use new TIX Methods
adds a new Stock-Script from u/ferrus_aub
optimize runHacking.js to start playerServers.js before mainHack.js to utilized new bought servers
adds automatic Stock Script start up based on api capabilities

The easiest it would be if you create a start.js with the following code and run it:
export async function main(ns) {
  if (ns.getHostname() !== "home") {
    throw new Exception("Run the script from home");
  }

  await ns.wget(
    `https://raw.githubusercontent.com/ComictypX/bitburner/master/src/initHacking.js?ts=${new Date().getTime()}`,
    "initHacking.js"
  );
  ns.spawn("initHacking.js", 1);
}

If you just want a single script, you can browse my repo at this URL: https://github.com/ComictypX/bitburner/tree/master
(The pr2 Branch is just to revert the repo address to moriakaices repo :) )

thanks :)


Dont create cluster-related objects if there is no cluster ready or installed

Actually maybe a "--safe" mode makes more sense. so that the user can use this mode to be safe on the dependant objects.

Closing this as this should be managed with a wait flag. See the issue here: https://github.com/SystemCraftsman/strimzi-kafka-cli/issues/92


Fix bug when loading nursery data

Signed-off-by: abigailt<EMAIL_ADDRESS>Description
Fix bug when loading nursery data with raw=True + added option for 1-hot encoded but not scaled data.
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ X] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
nursery unit test + shadow models tests
Test Configuration:

OS MacOS 10.6
Python version 3.8

Checklist

[ X] My code follows the style guidelines of this project
[X ] I have performed a self-review of my own code
[X ] I have commented my code
[ ] I have made corresponding changes to the documentation
[X ] My changes generate no new warnings
[X ] I have added tests that prove my fix is effective or that my feature works
[X ] New and existing unit tests pass locally with my changes

Codecov Report

Merging #1460 (7cb254b) into dev_1.10.0 (9546b41) will decrease coverage by 66.04%.
The diff coverage is 6.66%.

@@               Coverage Diff               @@
##           dev_1.10.0    #1460       +/-   ##
===============================================
- Coverage       89.86%   23.81%   -66.05%
===============================================
  Files             244      244
  Lines           19761    19750       -11
  Branches         3495     3239      -256
===============================================
- Hits            17758     4704    -13054
- Misses           1204    14978    +13774
+ Partials          799       68      -731

Impacted Files
Coverage Δ

art/utils.py
17.14% <6.66%> (-74.00%)
:arrow_down:

art/evaluations/evaluation.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/estimators/object_detection/utils.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/evaluations/security_curve/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

art/attacks/poisoning/perturbations/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...essing/expectation_over_transformation/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...rmation/natural_corruptions/contrast/tensorflow.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...formation/natural_corruptions/zoom_blur/pytorch.py
0.00% <0.00%> (-93.94%)
:arrow_down:

...mation/natural_corruptions/zoom_blur/tensorflow.py
0.00% <0.00%> (-93.55%)
:arrow_down:

art/attacks/evasion/shapeshifter.py
5.89% <0.00%> (-93.30%)
:arrow_down:

... and 181 more


[0.34] bugfix influxdb node_id

Description:
Do not convert node_id to float
Related issue (if applicable): fixes #4709

@lukas-hetzenecker Sorry for the issue caused by #4642 and this should get your issue fixed up however it may not solve everything for you.
Influxdb has some major issues with the way it is implemented it in Home Assistant. I invite you to please take a look at #4696. I want to get people that are familiar with influxDB and are using it with HASS so we can come up with a real solution.

I'm confused. In the issue you say that you are working on converting all IDs to floats, which would then break everything again?

Correct. In #4696 I propose a change to the measurements sent. To combine them all into 2 measurements, metrics and counters. That change alone will make all existing metrics to no longer get updates. But it allows much better queries like getting the average of all thermostats and temp sensors or the number of times any light or switch was changed over time.
At the moment nearly all metrics go to their own unique series and while you can query multiple series at once you cannot group or merge them into a single set of results. This means if you get all light and switch entities you end up with 30-40 different lines on a graph and no way to group them up if you want.
This PR to me is more of a temporary solution to prevent @lukas-hetzenecker from having to recreated the series. The other option at the moment is to drop and recreated either the database or those series. Unfortunately there isn't a clean way to get it all working without resulting in some data loss or fragmentation.
Much like the recorder database all entities will now go into a single series(table) but instead of making everything a string it will be a float to allow all numeric values. Any string values will not be logged to the metrics series but will still be incremented in the counter series.

After upgrading from 33.4 to 34.4 I'm now getting errors like this:
raise InfluxDBClientError(response.content, response.status_code) influxdb.exceptions.InfluxDBClientError: 400: {"error":"field type conflict: input field \"supported_features\" on measurement \"light.desk_lamp\" is type float, already exists as type integer"}

Unless I miss something, I don't believe the fix here would affect this field as it doesn't end in _id.  Should I raise a separate bug?


Graphs show events with a future date

Describe the bug
Graphs can show events with a future date.
And it's changing depending on the "Since" period selected.
If I pick "1 month", the graph displays the event as it happened today. (not true)
If I pick "1 year", the graph displays the event as it will happen on May 1. (not true)
The actual event occurred like a week ago.

Actual occurrence date:

How to reproduce it
Select a time range longer than 24 hours.
Expected behaviour
The graph should display the correct event time.
Environment

Falco version:
Tue Apr 16 09:47:30 2024: Falco version: 0.37.1 (x86_64)
Tue Apr 16 09:47:30 2024: Falco initialized with configuration file: /etc/falco/falco.yaml
Tue Apr 16 09:47:30 2024: System info: Linux version 5.15.0-102-generic (buildd@lcy02-amd64-080) (gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #112-Ubuntu SMP Tue Mar 5 16:50:32 UTC 2024
{"default_driver_version":"7.0.0+driver","driver_api_version":"8.0.0","driver_schema_version":"2.0.0","engine_version":"31","engine_version_semver":"0.31.0","falco_version":"0.37.1","libs_version":"0.14.3","plugin_api_version":"3.2.0"}

System info:
Tue Apr 16 09:48:12 2024: Falco version: 0.37.1 (x86_64)
Tue Apr 16 09:48:12 2024: Falco initialized with configuration file: /etc/falco/falco.yaml
Tue Apr 16 09:48:12 2024: System info: Linux version 5.15.0-102-generic (buildd@lcy02-amd64-080) (gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #112-Ubuntu SMP Tue Mar 5 16:50:32 UTC 2024
Tue Apr 16 09:48:12 2024: Loading plugin 'k8saudit' from file /usr/share/falco/plugins/libk8saudit.so
Tue Apr 16 09:48:12 2024: Loading plugin 'json' from file /usr/share/falco/plugins/libjson.so
Tue Apr 16 09:48:12 2024: Loading plugin 'k8smeta' from file /usr/share/falco/plugins/libk8smeta.so
parse error: Invalid numeric literal at line 1, column 4
Tue Apr 16 09:48:12 2024: Loading rules from file /etc/falco/falco_rules.yaml
Tue Apr 16 09:48:12 2024: Loading rules from file /etc/falco/falco-incubating_rules.yaml
Tue Apr 16 09:48:12 2024: Loading rules from file /etc/falco/falco-sandbox_rules.yaml
Tue Apr 16 09:48:12 2024: Loading rules from file /etc/falco/k8s_audit_rules.yaml
Tue Apr 16 09:48:12 2024: Loading rules from file /etc/falco/rules.d/argocd-application-controller-allowed-secret-consuming_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/clear-dpkg-log_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/container-running-as-root-enabled_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/falco-daemonset-allowed-mounting-proc_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/falco-write-root-sigstore_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/fluentbit-exclude-container-running-as-root_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/k3s-cloud-controller-manager-add-to-allowed-users_override.yaml
Tue Apr 16 09:48:13 2024: Loading rules from file /etc/falco/rules.d/k3s-supervisor-allowed-secret-consuming_override.yaml
Tue Apr 16 09:48:14 2024: Loading rules from file /etc/falco/rules.d/kubernetes-dashboard-allowed-reading-secrets_override.yaml
Tue Apr 16 09:48:14 2024: Loading rules from file /etc/falco/rules.d/local-path-provisioner-allowed-creating-sa-in-kube-system_override.yaml
Tue Apr 16 09:48:14 2024: Loading rules from file /etc/falco/rules.d/metrics-server-allowed-creating-sa-in-kube-system_override.yaml
Tue Apr 16 09:48:14 2024: Loading rules from file /etc/falco/rules.d/redis-write-temp-rdb_override.yaml
Tue Apr 16 09:48:14 2024: Loading rules from file /etc/falco/rules.d/sealed-secrets-allowed-creating-sa-in-kube-system_override.yaml

Cloud provider or hardware configuration:

OS:
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Kernel:
Linux falco-6dp4r 5.15.0-102-generic #112-Ubuntu SMP Tue Mar 5 16:50:32 UTC 2024 x86_64 GNU/Linux

Installation method:
Kubernetes

Additional context
N/A

this is strange, I'll try to create fake data to reproduce the bug. thanks

OK, I found the problem, I need to work on the algorithm I implemented to aggregate the data in buckets. Don't know yet if I can improve it. I'm facing more and more issues with the Redis used as backend and I'm considering more and more to replace it. Will keep you updated anyway.

Amazing, thanks a ton!

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Add hint for presto locality.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2169/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/2169/
Test PASSed.