Reimplement query grammar to support OR

And also boolean logic with nesting and precedence.
The matching interface is cleaner and should also be faster.
Stopped erasing type information for tagged objects by converting
everything to strings (only having to parse it back later).
With this grammar and interpreter it would be easy to add other helpers and operations.
Signed-off-by: Silas Davis<EMAIL_ADDRESS>

Fipf


community: DocumentLoaderAsParser wrapper

Description
This pull request introduces the DocumentLoaderAsParser class, which acts as an adapter to transform document loaders into parsers within the LangChain framework. The class enables document loaders that accept a file_path parameter to be utilized as blob parsers. This is particularly useful for integrating various document loading capabilities seamlessly into the LangChain ecosystem.
When merged in together with PR https://github.com/langchain-ai/langchain/pull/27716 It opens options for SharePointLoader / OneDriveLoader to process any filetype that has a document loader.
Features

Flexible Parsing: The DocumentLoaderAsParser class can adapt any document loader that meets the criteria of accepting a file_path argument, allowing for lazy parsing of documents.
Compatibility: The class has been designed to work with various document loaders, making it versatile for different use cases.

Usage Example
To use the DocumentLoaderAsParser, you would initialize it with a suitable document loader class and any required parameters. Here’s an example of how to do this with the UnstructuredExcelLoader:
from langchain_community.document_loaders.blob_loaders import Blob
from langchain_community.document_loaders.parsers.documentloader_adapter import DocumentLoaderAsParser
from langchain_community.document_loaders.excel import UnstructuredExcelLoader

# Initialize the parser adapter with UnstructuredExcelLoader
xlsx_parser = DocumentLoaderAsParser(UnstructuredExcelLoader, mode="paged")

# Use parser, for ex. pass it to MimeTypeBasedParser
MimeTypeBasedParser(
    handlers={
        "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet": xlsx_parser
    }
)

Dependencies: None
Twitter handle: @martintriska1

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

I've written down am extra explanation of why one might need to mutate Document Loader into parser. If you're unsure about that, please keep reading:

Document loaders function as <whatever> -> documents
BlobParsers process blob -> documents.
Many document loaders actually implement logic until they have a blob. Then the actual parsing is done by calling parser with similar name. As an example you can look at AmazonTextractPDFLoader and AmazonTextractPDFParser.
Some document loaders may want to process numerous filetypes. An example is a SharePointLoader that is supposed to fetch all parsable files, parse them and produce documents. Until recently it processed only 3 file types doc, docx, pdf and ignored everything else. Recently I got this pr merged that enables a user to pass in dict mapping file types (or mime types) to parsers. Now one can easily use SharePointLoader with any files where suitable parser is available.
Unfortunatelly many document loaders do not define BlobParser but rather handle everything directly inside the loader class. UnstructuredLoader is one of those.
Originally I went ahead and implemented separate ExcelParser (this PR). However this duplicated some of the code. That could be mitigated by replacing the part of the code inside UnstructuredExcelLoader responsible for parsing the file with calling the Parser. This would basically bring it to agreement with how things are done for ex. in PDF Loaders.
However I found out that I'd have to do this shuffling for a fairly long list of document loaders. Given how much time such effort would require, I opted to create DocumentLoaderAsParser wrapper. This wrapper can be used on any DocumentLoader that accepts file_path argument and turns it into BaseBlobParser.

So the idea is to be able to do:
xlsx_parser = DocumentLoaderAsParser(UnstructuredExcelLoader, mode="paged")
mp3_parser = DocumentLoaderAsParser(GoogleSpeechToTextLoader, project_id="...")

# create dictionary mapping file types to handlers (parsers)
handlers = {
    "xlsx": xlsx_parser,
    "mp3": mp3_parser
}
loader = SharePointLoader(document_library_id="...",
                            handlers=handlers # pass handlers to SharePointLoader
                            )
documents = loader.load()

Hope this makes sense.

@vbarda Please take a look :)

@efriis Would you mind taking a look yourself please? Seems like @vbarda might not have the throughput right now? Thank you and please let me know if there is anything I can do on my part to move this forward.

Thanks for this.
1. Can we add tests?

I've had tests in previous commits that I had rolled back. The problem was that for the tests to run, I needed to add unstructured module to requirements. I was getting:
INTERNALERROR> Failed: Package unstructured is not installed but is required for extended tests. Please install the given package and try again.
Back when working on this, I remember developers were asked not to add dependencies to pyproject.toml? I see there is new guidance now, I'll try to get the test working and will report back shortly.

2. Thinking through alternatives, does it make sense to add a "sub" document loader class as an optional attribute of `O365BaseLoader` or `SharePointLoader`? Introducing a new abstraction brings some risk if we don't get the interface right (or it's not as generic / extendable as we thought).

This was my original thought. However after spending some time on this issue, I found this approach much better. Except for cleaner code, it should help with reusability.
In general, this is very simple concept. Many document loaders accept file_path and return list of documents. Parsers accept blob and return list of documents. All we need to do is to open the file_path as blob and call corresponding loader. There are classes that require parser(s) to be passed in. We can have either universal adapter, or we can go hunting for piece of code where parser is used and update the code so document_loader could be used instead.

3. If we were to introduce a new class or method, consider decorating it with a `@beta` parameter if we're not 100% on the API (see example [here](https://github.com/langchain-ai/langchain/blob/f5f53d1101ea73d8465deb7d73b0a4e70bb556e7/libs/community/langchain_community/graph_vectorstores/base.py#L708)).

I can add @beta parameter. What version should I say that it will be added in?

Regarding unstructured: I would favor use of the langchain-unstructured package over the integrations in community. The community integrations are older and could be deprecated but we have not put in the work to verify that we don't lose functionality in langchain-unstructured.
Got it, I will be using langchain-unstructured going forward. It should not have material influence on this PR since DocumentLoaderAsParser can be used on either (any many other loaders)

ps: sorry for the mess in last 2 commits, I screwed up a rebase onto master and had to reset and rebase again...


ForecastDFDataset constructor mismatch in Hugging Face Blog, Tutorial and Codebase.

In the tutorial and hugging face blog for PatchTST, we have:
ForecastDFDataset(
    time_series_preprocessor.preprocess(train_data),
    id_columns=id_columns,
    input_columns=forecast_columns,
    output_columns=forecast_columns,
    context_length=context_length,
    prediction_length=forecast_horizon,
)

But there are no input_columns and output_columns in the class construction definition.
Am I missing something here? Does this also cause downstream issues?

I suppose they got replaced by observable_columns and target_columns but would like to see if the author agrees as well. Cheers 😄


Module web.curl

We have to implement a module for libcurl
http://curl.haxx.se/libcurl/

thinking to myself, I really don't know if curl must stay under web module...

I think it makes sense on std.net.

indeed


@Nested on Property where the type contains @Input* should consider implicit task dependencies

Expected Behavior

Consider the following:
class Foo {
    @Input
    URL url
}

abstract class FooTask {
    @Nested
    abstract ListProperty<Foo> foos
}

def urlGeneratorTask = tasks.register(...) {...}

tasks.register('foo', FooTask) {
    foos.addAll(urlGeneratorTask.flatMap { it.outputProviderOfUrls }.map { new Foo(it) })
}

Executing ./gradlew foo should automatically depend on urlGeneratorTask as the provider contains such information and the intent is to use as input for the task foo.
Current Behavior

Implicit task dependencies are not considered and we need to work around this by adding dependsOn(foos) inside the constructor of FooTask.
Context

Making everything Provider!
Steps to Reproduce

Follow the pseudo code above.
Your Environment

Build scan URL: None.

Found a related issue https://github.com/gradle/gradle/issues/13386, specifically this comment.

@lacasseio I looked at your pseudo-code and don't understand why urlGeneratorTask.flatMap { it.outputProviderOfUrls } would still depend on urlGeneratorTask: flatMap loses the dependency information, right? And outputProviderOfUrls seems to be a collection of URLs, so it can't be marked with @Output*, since Gradle doesn't support non-file outputs.
Though I see the bug you are hinting at. Is this the same as #13386, or do you have a different reproducer?

That may be the same issues, I don't really have another reproducer. After 2 years, I'm confident I found a workaround to the issue. Still, providers have a lot of gaps making it extremely hard for normal users to properly use them.

Workaround:
Add a dummy input property to the consumer task that consumes the nested property.
The value of the property is irrelevant, e.g. empty string.
In the following example I registered the input property in the consumer task constructor:
def producer = tasks.register('producer', Producer)

tasks.register('consumer', Consumer) {
    messages = producer.flatMap { it.outputFiles }.map { it.collect { new Message(it.text) } }
}

abstract class Producer extends DefaultTask {
    @OutputFiles
    abstract ListProperty<File> getOutputFiles()
}

abstract class Consumer extends DefaultTask {
    Consumer() {
        getInputs().property("messages-ValueProducer-Receiver", messages.map { "" });
    }

    @Nested
    abstract ListProperty<Message> getMessages()
}

class Message {
    @Input
    String text
}

Test run:
$ gradle consumer --dry-run
:producer SKIPPED
:consumer SKIPPED

BUILD SUCCESSFUL in 488ms


Importing Transkribus PAGE-XML

Current situation
Users cannot readily use the PAGE-XML results of Transkribus in an OCR-D environment, because Transkribus' flavor of PAGE-XML is based on the older 2013 variant and contains proprietary constructs and extensions.
How it should be
Users should be able to use Transkribus, e.g. for segmentation, and subsequently OCR-D for e.g. text recognition.
Steps

[ ] Finish initial implementation of https://github.com/kba/transkribus-to-prima and move to OCR-D organisation
[ ] Test with real-life example of data as provided by Transkribus
[ ] Integrate into ocr-fileformat
[ ] Update ocrd_fileformat
[ ] Update documenation, such as workflow guide

@kba does this belong to the MVP?


Use existing report for koverVerify

Is it possible to use an existing kover report (generated with koverXmlReport) when running koverVerify?
My case:

I have a legacy and a new codebase. The legacy code is placed inside the app module. The new code is split into modules.
I am generating coverage report using "include" only for the new modules.
I need to run verify task on PRs, but only for modified files (I can pass a list of modified classes to the verify task). But now I have a problem that if the legacy code has also been modified, the verify task would fail. I can't "exclude" the legacy code, since its base path is contained in each modules path (since the legacy code is in the app).
So I have a "correct" xml report (only for the new code) and I want to use it for verification. Is this possible?

Hi,
could you clarify, do you want to verify only those classes that have been changed?
If so, have you tried specifying "includes" filters for verification?

Could you clarify which command you are running verification with?
If using the koverVerify command, then you need to configure the default verification report:
koverReport {
    defaults {

        verify {
            filters {
                includes {
                    classes(<list-of-classes>)
                }
            }
        }

    }
}

Specifying filters at the top level may not work due to the bug.

I created a sample project to illustrate my case.
But the main question remains the same: "Can a report created with koverXmlReport be used in a koverVerify task?".

Answering the question:

Can a report created with koverXmlReport be used in a koverVerify task?

No, Kover Gradle Plugin uses binary reports and cannot use previous data that was generated with other inputs.
According to your example: as far as I can see, if the command :koverHtmlReport is run, the AppClassOne class does not get into the report because the inclusion filter tat.mukhutdinov.koversample.feature.* is applied.
When the classes(changedFiles.split(',')) filter for the verification rule is applied, the tat.mukhutdinov.koversample.feature.* filtering does not occur. Unfortunately, Kover summarizes the filters rather than checking them sequentially.
As a workaround, you can first filter the list of modified files, and then transfer them to the Kover filters - so you get a result similar to an HTML report.
In rule filters:
                filters {
                    includes {
                        classes(changedFiles.split(',').findAll {it.startsWith("tat.mukhutdinov.koversample.feature.") })
                    }
                }

Thank you!


Publish builds stats that are easy to browse

Adds two new tags, run-extra-build-macos and run-extra-build-stats to trigger corresponding build jobs on any PR.
Also reworks the guild stats gathering jobs to run on the new agent and push the resulting html onto a public S3.
This way, we now are able to post the results as

https://neon-github-public-dev.s3.amazonaws.com/build-stats/03ef6ec3b798c00a71f79f45c48d1cd388f4b9d5/4065912911/cargo-timing.html

It seems that full, cache-less rebuild of our binaries in release mode takes less than 3 mins:
https://github.com/neondatabase/neon/actions/runs/4065912911/jobs/7001266484
which is close to 4.30 mins that a corresponding job needs to build postgres and deal with caches:
https://github.com/neondatabase/neon/actions/runs/4065241838/jobs/6999682386
Looks like we might remove the caching alltogether and gather build stats every time, doing a clean build every time, with not that big time degradation.
Or, if that sounds too bad, we can move the "gather build stats" job into the main suite and always run it.

Do I need to solve the retention issue here? The files are small, so if the bucket is able to clean up its old contents already, it would be great.


rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I rerendered the recipe in conda-forge/tensap-feedstock#2.


Use gorilla mux.

The intention is to be able to share middlewares between key server and
verification server.
NOTE: some of the changed lines are not strictly required (e.g. the
Prometheus /metrics handler can use the Go http mux perfectly fine), but
are changed to be consistent.

see test failures
Also - any objection to holding this until after v0.20 is cut? I would like it to sit in our dev environment longer

see test failures
Also - any objection to holding this until after v0.20 is cut? I would like it to sit in our dev environment longer

see test failures
Also - any objection to holding this until after v0.20 is cut? I would like it to sit in our dev environment longer

SG

see test failures
Also - any objection to holding this until after v0.20 is cut? I would like it to sit in our dev environment longer

SG

/hold cancel

/hold cancel


Basically one commit

Task :compileKotlin FAILED
e: /home/runner/work/KStom/KStom/src/main/kotlin/world/cepi/kstom/CoroutinesUtils.kt: (14, 43): Unresolved reference: BlockBatch

e: /home/runner/work/KStom/KStom/src/main/kotlin/world/cepi/kstom/CoroutinesUtils.kt: (46, 20): Unresolved reference: BlockBatch
Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Error with CI, maybe Minestom isn't bumped?

Yeah, I guess I had an old version of minestom where BlockBatch was still in api


Create an issue

Hi,
I would like to implement a method in Dart, something like the following:
int nullFirstCompare<T extends Comparable<T>>(T? a, T? b) {
  return switch ((a, b)) {
    (null, null) => 0,
    (null, _) => -1,
    (_, null) => 1,
    (final a, final b) => a.compareTo(b), // does not compile
  };
}

So, my hope would be that by the 4th case in the switch the Dart compiler would deduce that none of the record fields can be null. It does not, therefore the 4h case does not compile.
I wonder if this is a limitation or a bug in the compiler. Also if there is some elegant way to rewrite this code to make it work with the current Dart compiler.
% dart --version
Dart SDK version: 3.0.6 (stable) (Tue Jul 11 18:49:07 2023 +0000) on "macos_arm64"

Thanks!
Marton

I suggest you edit the issue to have a more fitting title of your problem.

We have discussed this topic before. In particular, this issue is somewhat similar: https://github.com/dart-lang/language/issues/2503, but also https://github.com/dart-lang/language/issues/2896 and https://github.com/dart-lang/language/issues/2641. In https://github.com/dart-lang/language/issues/2977 the main topic is lists, but it is still somewhat similar.
In short: That would be nice, but the discussions about how to deal with it are ongoing.
I'll transfer this issue to the language repository, it's a better fit there.


tidevice xctest failed!

I did code signing webdriveragent-runner by enterprise distribution provision with no errors.
but, when i run xctest using tidevice, it failed.
ex) tidevice xctest -B my_webdriveragent-runner.xctrunner
i don't know why. let me know any solutions. plz.
I found same issues: https://github.com/alibaba/taobao-iphone-device/issues/14.

any bug report can you provide？

@NoneTypeCoder
This is logogs of the same issue from other people.
[I 210201 21:10:10 _device:912] BundleID: com.xxxxxxxxxx.WebDriverAgentRunner-Runner
[I 210201 21:10:10 _device:914] DeviceIdentifier: 00008030-xxxxxxxxxxxxE
[I 210201 21:10:10 _device:775] SignIdentity: 'iPhone Distribution: xxxxxxxxx Co., Ltd.'
Traceback (most recent call last):
File "/Users/xx/.pyenv/versions/uiauto8/bin/tidevice", line 8, in
sys.exit(main())
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/main.py", line 429, in main
actionsargs.subparser
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/main.py", line 209, in cmd_xctest
d.xctest(args.bundle_id, logger=setup_logger(level=logging.INFO), env=env)
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/_device.py", line 985, in xctest
pid = self._launch_wda(bundle_id, session_identifier, env=env, logger=logger)
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/_device.py", line 786, in _launch_wda
for fname in fsync.listdir("/tmp"):
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/_sync.py", line 106, in listdir
pkg = self._recv()
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/_sync.py", line 77, in _recv
buf = buf + self.recvall(FHeader.size - len(buf))
File "/Users/xx/.pyenv/versions/3.8.6/envs/uiauto8/lib/python3.8/site-packages/tidevice/_safe_socket.py", line 55, in recvall
raise MuxError("socket connection broken")
tidevice.exceptions.MuxError: socket connection broken

I maybe know why this issue happened. Can you provide me the version of Xcode, iOS, and WDA which you used?

@NoneTypeCoder
Yes, that's right. I used abc.xctrunner as a bundle, is there a solution?

I have a guess about this problem， in this step which showed in screenshot，We need to access the /tmp folder，when I added the print statement the printed path is /tmp/WebDriverAgentRunner-D927F243-1159-478F-A429-0F850623BBE9.xctestconfiguration). So we can get access to this file which make this problem happened.
Another related issue https://github.com/libimobiledevice/ifuse/issues/24#issuecomment-93119672.

As said above，only work with apps that are deployed via XCode and Ad-Hoc distribution. So thats maybe why we cant get the access from the app that code signing by enterprise distribution.

@NoneTypeCoder
I'm trying to deploy an enterprise distribution to install webdriveragent to any devices.
From your answer, it looks like there's no way to do it.

@myungkyojung Im trying to do this too. In order to solve this problem,  I have tried many ways like modify the Info.plist file, modify the .mobileprovision file or check all the optional options when signing the enterprise. But no one works. Maybe this problem is unsolvable.

When I modify the Info.plist file and then code signing webdriveragent-runner by enterprise distribution provision. And I modify fsync = self.app_sync(bundle_id, command="VendDocuments") then I get the error below:
AFCPacket(status=<AFCStatus.INVALID_ARG: 7>, data=bytearray(b'\x07\x00\x00\x00\x00\x00\x00\x00'), payload=bytearray(b''))
Traceback (most recent call last):
File "D:\ENV\lib\site-packages\tidevice_sync.py", line 328, in _context_open
yield h
File "D:\ENV\lib\site-packages\tidevice_sync.py", line 413, in push_content
raise MuxError("write error: {!s}".format(pkg.status))
tidevice.exceptions.MuxError: write error: AFCStatus.INVALID_ARG
It seems like I have no access to wirite, compared with before I made these changes, it can be sent and read now. I don't know what I can do anymore.

@NoneTypeCoder Is there a solution now?

I came across this problem too, and it turns out if your device is jailbroken and has AFC2 installed, the solution is quite simple.
As NoneTypeCoder noted above, tidevice complains about this because it has no access to the <app container>/tmp directory. If we're jailbroken, we can easily access it by invoking the AFC2 service. To do this, you simply make a few modifications to the code as detailed below.

in tidevice/_device.py, look for the _launch_app_runner method, and replace the following code:

fsync = self.app_sync(bundle_id, command="VendDocuments")

for fname in fsync.listdir("/tmp"):
    if fname.endswith(".xctestconfiguration"):
       logger.debug("remove /tmp/%s", fname)
       fsync.remove("/tmp/" + fname)
fsync.push_content(xctest_path, xctest_content)

with
fsync = self.sync

for fname in fsync.listdir(app_container + "/tmp"):
    if fname.endswith(".xctestconfiguration"):
       logger.debug("remove /tmp/%s", fname)
       fsync.remove(app_container + "/tmp/" + fname)
fsync.push_content(app_container + xctest_path, xctest_content)

in tidevice/_proto.py, look for the LockdownService class, and replace AFC = "com.apple.afc" with AFC = "com.apple.afc2"

And you're good to go!

but my ios devices is not jailbroken,how can i do?
Guard you（神思者）
@.***

------------------ Original ------------------
From:                                                                                "alibaba/taobao-iphone-device"                                                                                @.>;
Date: Wed, Oct 11, 2023 03:59 PM
@.>;
Cc: "Guard<EMAIL_ADDRESS>Subject: Re: [alibaba/taobao-iphone-device] tidevice xctest failed! (Issue #277)
I came across this problem too, and it turns out if your device is jailbroken and has AFC2 installed, the solution is quite simple.
As NoneTypeCoder noted above, tidevice complains about this because it has no access to the <app container>/tmp directory. If we're jailbroken, we can easily access it by invoking the AFC2 service. To do this, you simply make a few modifications to the code as detailed below.
in tidevice/_device.py, look for the _launch_app_runner method, and replace the following code:
fsync = self.app_sync(bundle_id, command="VendDocuments") for fname in fsync.listdir("/tmp"):     if fname.endswith(".xctestconfiguration"):        logger.debug("remove /tmp/%s", fname)        fsync.remove("/tmp/" + fname) fsync.push_content(xctest_path, xctest_content)
with
fsync = self.sync for fname in fsync.listdir(app_container + "/tmp"):     if fname.endswith(".xctestconfiguration"):        logger.debug("remove /tmp/%s", fname)        fsync.remove(app_container + "/tmp/" + fname) fsync.push_content(app_container + xctest_path, xctest_content)
in tidevice/_proto.py, look for the LockdownService class, and replace AFC = "com.apple.afc" with AFC = "com.apple.afc2"
And you're good to go!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


[PDI-16684] Text File Input Not Recognized Escaped Characters At End of String

[PDI-16684] Text File Input Not Recognized Escaped Characters At End of String
-added supporting escaped escape

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtils.java
  engine/src/test/java/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtilsTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.5% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ifnull.IfNullMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.googleanalytics.GaInputStepMeta

Branch Change: -1.9% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

@mbatchelor I'm very sorry for my mistake. I removed my technical debugging comment. Could you please merge it?

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtils.java
  engine/src/test/java/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtilsTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -3.1% :small_red_triangle_down:
Complexity Change: -3.1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapinput.LDAPInputMeta

Branch Change: -1.6% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtils.java
  engine/src/test/java/org/pentaho/di/trans/steps/fileinput/text/TextFileInputUtilsTest.java

Newly Broken Tests:
org.pentaho.di.core.logging.MetricsPainterTest.testDrawTimeScaleLineInfinityLoop:
:red_circle: java.lang.Exception
java.lang.Exception: test timed out after 1000 milliseconds
	at org.pentaho.di.core.logging.MetricsPainterTest.testDrawTimeScaleLineInfinityLoop(MetricsPainterTest.java:65)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.core.lifecycle.KettleLifecycleSupport

Branch Change: -8.4% :small_red_triangle_down:
Complexity Change: -9.1% :small_red_triangle_down:

org.pentaho.di.core.logging.MetricsPainter

Branch Change: -8.3% :small_red_triangle_down:
Complexity Change: -10.5% :small_red_triangle_down:
Instruction Change: -19% :small_red_triangle_down:
Line Change: -17.9% :small_red_triangle_down:
Method Change: -14.3% :small_red_triangle_down:

org.pentaho.di.job.entries.evalfilesmetrics.JobEntryEvalFilesMetrics

Branch Change: -0.4% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.setvalueconstant.SetValueConstantMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:


Moving window in El Capitan

I know this has apparently been fixed and awaiting release but I've pulled the master branch and built in xcode.  Some things appear to be fixed (UI rendering, Last.fm) but I still can't move the window around.  For some reason it seems to highlight the search bar.  Is there any way around this?
Thanks.

Just done so more testing...
If I click anywhere within the display I can't move the window but the window loses focus e.g. click desktop I can then move it.  Very strange.

yep, got the same issue here.

same issue here.

I have exactly the same issue. Though it was connected with my usage of betterTouchTool but when it is disabled behaviour is the same.

This is fixed in master and should go out this weekend as 1.6

@jacobwgillespie Thanks for this but even with 1.6.2 (download and building from the master branch) I'm still unable to move the window unless it looses focus first.  It tries to highlight the test within the search bar.
Also, the UI bug still exists with the frozen display upon minimizing i.e. play a track from an album view, minimise app, open and everything is frozen.
Am I missing something?

Both the issues you've mentioned are still present - we're looking into them.
There was an issue a while ago where moving the window broke completely, which might be what @jacobwgillespie's referring to. Because of the delayed release, it's easy to confuse the 2 issues :-/

@chrismou Ah ok.  No problem.  The work around still exists anyway (change window size which triggers the redraw).  Thanks!

@leemm yeah, the UI bug still exists (#408)
For moving the window, what are the steps to reproduce the bug you're seeing?  I am able to move the window correctly (I think, unless I'm confused) by dragging the title bar...

@jacobwgillespie I thought a vid might be better.  http://sendvid.com/9l0gipq2 Radiant Player had just been opened.  I have 3 macs all running El Capitan and the situation is same, click the desktop and it works - once. :)

Hmm...  And this is on 1.6.2?

Yes, the compiled release and building it myself from master.

Actually, I'm not seeing that exact issue. For me, when I drag the window it sometimes just acts like I've let go of the mouse button and stops dragging.  When that happens, the search box usually highlights like in your video.
One thing I've noticed is I only get it when I drag from the lower part of the top bar -ie, the custom bit. If I drag from the very top (ie, where the title bar would usually be) I don't see the issue.
I have no idea if the 2 issues are related

Is it worth 'un-closing' this issue?  I've noticed people are still talking about it in other threads.  Thanks!

I'm still seeing this on 1.6.2 as well.  I can only initiate a window drag when the window doesn't have focus.

Anybody who's still experiencing this issue, can you describe your environment?  What software / hardware / OS version, etc.  I'm unable to reproduce, but there must be some common denominator between those of you who can.

In the newest version it works for me.

I've done some more playing and I'm absolutely convinced this is a combination of the lack of a title bar and WAYWindow.
Simply commenting these two lines in the applicationDidFinishLaunching event now allows me to move the window using the standard title bar - not pretty but functional:
[self useTallTitleBar];
[ApplicationStyle applyYosemiteVisualEffects:webView window:window appearance:NSAppearanceNameVibrantLight];

What's even stranger is that it also fixes the second issue i.e. minimising the app to dock while playing.  I no longer get any lockups of the display when it's restored meaning the resizing the window fix is no longer required.
Only tested on the default style, not sure if it still affects the custom ones.

Thanks for looking into this - it's something I've had on my list of todos for a while but not had time to properly look in to.
If this fixes the problem, I'd be happy to go down this route. But it's a bit enough aesthetic change that I'd want a few contributors to chime in with their opinions before it's merged in
If it's as simple as a 2 line change, do you fancy putting a PR in for it?  Just thinking with a PR it'll give us one place to discuss it.  Plus it'll make it easier to test and compare.

OK, so to get the title bar back in the darker themes I had to edit
ApplicationStyle.m::applyYosemiteVisualEffects too.  The window is much more responsive - no lagging at all.
Will also need to unhide the maximize/minimize buttons - thats in AppDelegate.m (326)
@leemm Do you want to sort this or are you happy for me to fix up and put in the PR?  Now we've identified a potential fix I'm keen to get this reviewed ASAP

@chrismou I'm fine for you to do the PR if you don't mind.  I'm working on a big project and getting the spare time is a pain at the moment.  Good catch on the themes, I didn't get the chance to check that properly (if at all).
Also, since this only seems to affecting El Capitan maybe it's worth making it a conditional thing via the version number of Mac OS?  Personally I think just having it across the board is better and responsiveness is excellent with the native title bar so maybe just take it out entirely.

Cool, no worries, will try and sort it tonight.  And yeah, I agree, generally I prefer to see stuff like this implemented for all platforms, otherwise it just creates more work down the line.
Either way, this will most likely just turn out to be a stop-gap fix until we can puzzle out why the custom stuff performs so badly when the titlebar is hidden.  Judging by some of the stack overflow questions I've read, it doesn't look like we're the only ones affected and no-one had come up with a reasonable solution yet. One consistent thing is that everyone has noticed it after upgrading to El Capitan.

@jacobwgillespie Out of interest, when you drag the window (and don't see a lag), where are you clicking?  I'm noticing that if I click and hold right at the top of the window (where the titlebar would be if it wasn't hidden) it moves OK for the most part.  The worst of the lag starts when I click any lower than that.
The interesting thing is with the titlebar visible, there's no lag regardless of where you click.  So it's almost as though just having the titlebar transparent is enough to affect drag performance.

The thing is the title bar is actually still there but is using a transparency hack to remove visibility.  Perhaps upon dragging it has to continuinely re-draw, applying the hack repeatedly?  I think this might be quite difficult to prove.
Also, it appears the only time I can move the window via the custom titlebar is after it looses focus e.g. clicking the desktop.  My point is the right-click workaround doesn't appear to work on this mac at all.

Even more interesting is I'm watching the profiler and Energy and Memory usage are staying reasonably low despite continuous music playing and loads of clicking around.
It's a bit optimistic to think this will fix #377 and #308 but it's something I'll be keeping an eye on tonight

Now I'm thinking it's probably best if I add this as a preference so people can decide for themselves whether to use a custom or standard title bar.
I'll try and find some time this weekend to finish it off

Great idea.  I'd suggest the custom title bar is off by default.  A lot of users are now upgraded to El Capitan and to them it looks like a broken app...

See #480 for the PR

I just wanted to note, I was having this issue (unable to move window unless focus was lost) and wanted to test a bit because not everyone was getting the issue. When I disabled the preference for back and forward buttons the issue went away, and I was able to drag the window.

Am experiencing the same issue - only works on lost focus. Disabling preference for back and forward buttons made no diff for me. Also tried complete uninstall/reinstall.
Radiant 1.6.2 on El Cap 10.11.3, MacBook Pro

@scarroll825 @skrodal @jmcnevin
Pre release build is here: https://github.com/chrismou/radiant-player-mac/releases/tag/1.7.0-pre
Would appreciate having a quick test to see if it fixes the issue for you, if you get some time.  Will probably release this weekend, pending any major issues.

Thanks @chrismou,
Believe I did a complete removal of previous version (1.6.2) and installed your pre-release. Same issue as before.
Please note - version of new linked pre-release still says 1.6.2 (not 1.7.0).

Thanks for testting @skrodal!  Now worries about the version, our release process sorts all that out. By keeping it at 1.6.2, you can theoretically keep using my test build, and when the official release it pushed it should still update automatically.

So this should essentially be fixed in 1.7.  If you're still experiencing issues, feel free to open another ticket


rewrite(removal_records_integrity): Don't check for double-spend

With this change, the removal records integrity program no longer checks that the Bloom-filter indices are unset for the input being spent. This change is made to reduce the computational cost of the transaction initiator. This change must be done by the miner.
This commit reduces the computation cost of this program by more than 90 %. It divides the table height by between 11 and 12.

LGTM

I added a new structure RemovalRecordsIntegrityWitnessMemory for handling the initial memory layout. And then I moved everything that saved clock cycles from being initialized in memory to the secret-in stream. This saves a few clock cycles in the program and, more importantly, makes the memory layout simpler and easier to reason about.


Read me update :relaxed:

1.Request to Update Current images used in the documentation, due to usage rights. The proposed, public domain images, replacements are :
- Photo by Ketut Subiyanto
- Photo by cottonbro

Request to correct typo  in the Getting Started section :
-If dont you want to do run binaries without installing rust replaced to If you want to run binaries without installing rust

Fixed in #3


Allow to set URIEncoding on AJP 1.3 Connector

It would be great to be able to set the URIEncoding="UTF-8" on AJP 1.3 Connector.

1

#152 added

Thanks!
May I suggest to set the value for URIEncoding in attributes so another value than UTF-8 could be used?

Sure I'd say make it a different pull request. I'm terribly selfish and horrible and just require the utf-8 but wouldn't mind it being configurable.

#152 modified :)

First off I'm very sorry that it's taken so long to get back to you on this issue.  For a significant period of time there was no active Chef Software Inc. maintainer for this repository and things languished.  We're now actively maintaining this cookbook again, and as part of that I've rewritten the cookbook with new custom resources for installing Tomcat from Apache Org sources.  This will ship in an upcoming 2.0 release and then we'll remove the existing recipes and providers in a future 3.X release.  With those new providers I believe the need for this change goes away so I'm going to close this out.  I encourage you to give the new providers a try and let me know if we can tackle more Tomcat management without the attributes bloat the current code suffers from.  They're on the master branch and once the documentation and testing improves a bit they'll be released as a 2.0 cookbook.


Docker container rebuild

There is an issue with docker container.
Image needs to be rebuild one in docker hub is no the one in Dockerfile. Automated build would be great also in docker hub there is no link back to github or builded Dockerfile, this looks kind a bad.
Also would be great if entry point has raised php memory limit. Or in readme could be example how to raise memory limit with docker by overriding entry point.
 docker run -it -v $PWD/src:/inspect --entrypoint "/usr/local/bin/php" mihaeu/dephpend:latest -n -d memory_limit=-1 /usr/src/dephpend/bin/dephpend text /inspect

Thanks Martin 😅 will take care of it later this week. Docker build was
kind of rushed, I agree 😅
On Mon, May 20, 2019, 3:21 AM Martin Zajíc<EMAIL_ADDRESS>wrote:

There is an issue with docker container.
Image needs to be rebuild one in docker hub is no the one in Dockerfile.
Automated build would be great also in docker hub there is no link back to
github or builded Dockerfile, this looks kind a bad.
Also would be great if entry point has raised php memory limit. Or in
readme could be example how to raise memory limit with docker by overriding
entry point.
docker run -it -v $PWD/src:/inspect --entrypoint "/usr/local/bin/php" mihaeu/dephpend:latest -n -d memory_limit=-1 /usr/src/dephpend/bin/dephpend text /inspect
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mihaeu/dephpend/issues/48?email_source=notifications&email_token=AAQRO7IRFQRHMRDYZQG7I5LPWJNR7A5CNFSM4HN7SDJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUVFGCA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQRO7PFDQUFWJ4PEXTMWXTPWJNR7ANCNFSM4HN7SDJQ
.

Should be fixed with f3ba7966975536e16974e508c477bb8837ece905 and 2f8f3e20fc0c4174dcb8170850f2797befba390c. Autobuild is now enabled. Feel free to pull latest and verify @zajca.
And thanks again for the find.


I wish the interactive candlestick widget would be developed

The interactive candlestick widget is necessary for all stock and cryptocurrency App, developing a candlestick widget will be appreciated.

IMO, such widget would be best served by the community instead of part of the official package, e.g. for JavaScript is http://techanjs.org/ (random googling). You could probably wrap it inside a webview, although I'm not sure of the performance.


Horizenio subfolder migration

/botio build

From: MushinBot (botio-academy.horizen.io)

Received
Command cmd_build from @cronicc received. Current queue size: 0
Live output at: https://botio-academy.horizen.io/53973b7e8509dd3/output.txt

From: MushinBot (botio-academy.horizen.io)

Success
Full output at https://botio-academy.horizen.io/53973b7e8509dd3/output.txt
Total script time: 3.75 mins
You can download the generated site at: https://botio-academy.horizen.io/latest.tar.gz
Or view a preview at https://devweb-academy.horizen.io


Licenses text for 5.2.0 Alpha Release

Done, Please check.
LICENSE(wso2carbon-kernel-5.2.0-alpha).TXT


[BUG] EKS public + private enabled clusters fail to come up active in Rancher v2.9

Rancher Server Setup

Rancher version: v2.9.1-rc3
Installation option (Docker install/Helm Chart): ha helm

Information about the Cluster

Kubernetes version: 1.30, 1.29, 1,28
Cluster Type (Local/Downstream): EKS private

User Information

What is the role of the user logged in? Admin

Describe the bug
When provisioning a downstream EKS private cluster, the cluster hangs in waiting state and never comes up active.
Rancher UI displays: Failed to communicate with cluster: dial tcp <redacted>: i/o timeout
To Reproduce

Fresh install of Rancher v2.9.1-rc3
Provision a downstream EKS hosted private cluster

Result
EKS cluster is up and active in AWS Console, but Rancher cannot connect to it, and it never stabilizes as active, it hangs in waiting state w/ the following message Failed to communicate with cluster: dial tcp <redacted>: i/o timeout
Expected Result
Cluster expected to come up active and stable
Screenshots

Additional context
This is also getting hit in v2.9.0.  This is not seen on v2.9.1-rc3 when using k8s 1.27.
And this is NOT seen in Rancher v2.8

Encountered the same error as reported, however after applying manifest to register the private cluster, it comes up Active.

Apply registration:
$ curl --insecure -sfL https://<REDACTED>/v3/import/jmqdbnp9gssqrtbvvvwcrt775xltplnqrzlttvtcc8k442mwb9wh2k_c-j5b86.yaml | kubectl apply -f -
clusterrole.rbac.authorization.k8s.io/proxy-clusterrole-kubeapiserver created
clusterrolebinding.rbac.authorization.k8s.io/proxy-role-binding-kubernetes-master created
namespace/cattle-system created
serviceaccount/cattle created
clusterrolebinding.rbac.authorization.k8s.io/cattle-admin-binding created
secret/cattle-credentials-1d45e70 created
clusterrole.rbac.authorization.k8s.io/cattle-admin created
deployment.apps/cattle-cluster-agent created
service/cattle-cluster-agent created

Initial investigation by Highlander leads to remote dialer (SURE-8776)
Asking @MKlimuszka and @prachidamle for help.

Not sure if this qualifies as a release blocker or if a section in the release notes is sufficient 🤔

Already happens in 2.9.0, a note in the release notes will suffice. To be fixed in 2.9.2.

It is not bug or issue, for EKS clusters with only Private API endpoint it is needed to register cluster based on documentation comment https://ranchermanager.docs.rancher.com/reference-guides/cluster-configuration/rancher-server-configuration/eks-cluster-configuration#private-only-api-endpoints
and instruction from comment https://github.com/rancher/rancher/issues/46778#issuecomment-2304005228

confirmed to be a non-issue; closing this out

Can we remove the release note label to prevent confusion, since this was decided to not be a bug or issue?


Added ability to configure minimal term length required to show suggestions.

Hello Ludwik,
I think that sometimes it might be needed to configure the minimal term length required to show suggestions.
Best Regards,
Ernest
P.S. Explanations and use case examples can be added if needed.

Looks good :) While you are at it maybe you could add some indentation to the JavaScript in the widgets.py file?

Sure. This must be done.


Revert "[build] Serialize nested components with their kit-name if they are instantiated via a kit"

Reverts breadboard-ai/breadboard#3015
Bug with gemini kit, will investigate tomorrow.

Reverting in favor of https://github.com/breadboard-ai/breadboard/pull/3018


Add API to fetch the list of apps that require OpenMobile ACL feature (bug 1181575)

https://bugzilla.mozilla.org/show_bug.cgi?id=1181575
This returns a list of manifest URLs, that fireplace can then directly compare
to require('apps').getInstalled() when handling the ACL install activity.

r+ w/ rebase. I love how our search filters make it easy to add new search endpoints.


Add Electra block and state objects from CL spec

Adds Electra block and state objects from CL spec as per v1.5.0-alpha.5 release

need to apply changes from https://github.com/ethereum/consensus-specs/pull/3875

need to apply changes from ethereum/consensus-specs#3875

following these changes, I think we will want the SignedBlindedBeaconBlock to contain an execution_requests_root instead of the execution_requests data
this would be mirrored in the builder-specs so that we don't need to worry about execution requests leaking any MEV in the builder exchange

following these changes, I think we will want the SignedBlindedBeaconBlock to contain an execution_requests_root instead of the execution_requests data

makes sense, I applied the changes as per https://github.com/ethereum/builder-specs/pull/101

Merging this as it at least should be close, and smaller PRs will be easier to adjust if any slight tweaks need to be made.


Increasing the number of slots for shortcuts to plugins

I would like to increase the number of free slots because now their number is 100.
It is not enough, but it causes the attempt to add a shortcut for plug 101 to end with the following message: "All FX shortcut arę in use.  Please delete a shortcut in order to ad a new one. "
When you use a MIDI controller to run plug-ins, where any effect can be triggered directly from it, it becomes irritating.
Can you ask to increase the number of slots to at least 300?  - for future safety :)
I searched the files a bit and found that it was a file called "reaper-fxoptions.ini".
Maybe it can be somehow increased without the need to update?
I would be very grateful!
Thank you in advance! :)

This is about functionality provided by Reaper natively, not by SWS, so SWS can do nothing about it.

This is about functionality provided by Reaper natively so SWS can do nothing about it., sorry.
There's already an existing feature request you could bump:
https://forum.cockos.com/showthread.php?t=232919


rename openshift-tools-scripts-monitoring-zagg-client

...to openshift-tools-scripts-monitoring
fix up dependencies, use new RPM name everywhere, package up unpackaged files, and remove leftover unpackaged files

ok to test

ok to test


Add SDK usage examples to coincide alongside XDR structure explanations

There are a lot of parts of the JavaScript SDK that have low discoverability because they are only documented in the SDK itself. This adds cross-references in the appropriate parts of the Interacting with Soroban via Stellar page to make these abstractions more apparent.
Related: #595 #608

Preview is available here:http://soroban-docs-pr699.previews.kube001.services.stellar-ops.com/


Does sails-hook-swagger-generator not support sails v0.12

Does sails-hook-swagger-generator not support sails v0.12

it should be backward compatible, are you having any issues running it with sails v0.12?

closed this now


chore: bump manifest headers to 2024

The license headers for the manifests are generated as part of the presubmits, and need to be bumped for the new year.

/assign @karlkfi

My understanding is that Google policy is to only update copyright  years on file creation, not updates.
Is this change needed to satisfy validation? If so, it seems like maybe the tooling doesn't match the policy.

My understanding is that Google policy is to only update copyright years on file creation, not updates (go/copyright#the-year).
Is this change needed to satisfy validation? If so, it seems like maybe the tooling doesn't match the policy.

Yes, this is needed to satisfy the presubmit validation. Currently the CRDs are generated from code and headers are injected, and then the tooling checks if there is a git diff. So the validation now fails since the generated headers have the new year.

Can you log a bug to fix the automation to preserve the earliest copyright date, instead of always re-generating it?

Can you log a bug to fix the automation to preserve the earliest copyright date, instead of always re-generating it?

Created a bug


ROU-3029 - Added new MerceColumn feature

This PR is for a new API  - MergeColumnCells.

Created new API on ColumnManager
Created new feature  - ColumnCellMerging

Checklist

[x] tested locally
[x] documented the code
[x] clean all warnings and errors of eslint
[x] requires changes in OutSystems (if so, provide a module with changes)
[ ] requires new sample page in OutSystems (if so, provide a module with changes)

sonarcloud warning is false-positive, as it is complaining about API code repetition, due to performance and error methods.


Per-week unavailability support

Hi,
Thanks for making this great library available! We're actively migrating to it in our new app. There is one missing feature though that we'd need to make full use of it.
We require being able to set availability on a day-by-day basis. In other words, we don't have repeated availability by default, so we cannot use the current unavailability, which assumes it's the same info for each week. Note that we actually use availability, which we then convert to unavailable hours using xspans, which is totally fine. No need to change that.
It would therefore be great if the "unavailable hours" could support dates as an index as opposed to just day numbers. Would this be something that you'd like to add? I'm a bit short on time, otherwise I'd look into it myself.

Can you give me some pictures, videos, or any apps that have this feature?

Is this the feature you want?

That's exactly what we need indeed!
I'm not aware of other apps that have this feature, but to be honest I haven't actively looked for it. I noticed the unavailableHours feature and thought we may as well use that. Great if you can make this a unique selling point of this library!

Ok. I think it's not too hard to do. I'll add this feature when I wake up ☺

@howljs Hello, how to set unavailable time for hours and minutes like 9.30am to 4.30pm ?

@howljs Hello, how to set unavailable time for hours and minutes like 9.30am to 4.30pm ?

You can use a decimal number for the start and end values, e.g. for your example it would be
{
  start: 9.5,
  end: 16.5
}

@bartvanandel  You can update to v1.8.0
https://github.com/howljs/react-native-calendar-kit/releases/tag/v1.8.0


Not sure if Meteor Issue or I'm just stupid...

Firstly congrats on the great package, it's very useful and everything is quite intuitive. However, I must be doing something wrong when specifying the api key using GoogleMapsLoader, as I continue to get warnings about missing API keys. Has anyone experienced anything like this before when using meteor? Any input much appreciated!

    <GoogleMapLoader
  query={{key: "mykeyhere"}}
     googleMapElement={
    <GoogleMap
    name="mymap" options={this.data.mapOptions}
    />
    }
    />

I'm using it in Meteor as well. How are you loading the API Script? Here's what I'm using:


Change Layer Solid Color?

Hi,
Might be a noob question but how do I change the color of a solid?
I tried this code:
        {
            "type": "data",
            "layerName": "background",
            "property": "Effects.Skin_Color.Color",
            "value": [
                0,
                165,
                190
            ]
        }

But got this error:
Error: nexrender: Can't find a property sequence Skin_Color.Color for key: Skin_Colorwithin layer: background
aerender ERROR: Runtime error in After Effects.

Also, how do I find any undocumented nested properties like Skin_Color, Source Text.font, etc?

The easiest and most complicated solution is to get Extend Script Debugger in a form of older separate app or a newer VS code plugin and attempt to find the needed property via long process of trial and error, especially for something undocumented like this.
If you do succeed in this matter, please let us all know! You would save a lot of poor souls with this one. :)


Notifications to organization admins when a new pledge is made on the teams behalf

Fixed by https://github.com/polarsource/polar/pull/1602


error with yuglify collectstatic ?

I'm having this error when running collectstatic
any ideas?
if this issue is not related to django-pipeline plz close thx
jauria@jauria-studio:~/Proyectos/homeAutomation$ ./manage.py collectstatic
You have requested to collect static files at the destination
location as specified in your settings:
/home/jauria/Proyectos/homeAutomation/static_files

This will overwrite existing files!
Are you sure you want to do this?
Type 'yes' to continue, or 'no' to cancel: yes
Post-processed 'controlPanel/css/main.css' as 'controlPanel/css/main.css'
Post-processed 'controlPanel/js/main.js' as 'controlPanel/js/main.js'
Traceback (most recent call last):
File "./manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/usr/local/lib/python2.7/dist-packages/django/core/management/init.py", line 338, in execute_from_command_line
utility.execute()
File "/usr/local/lib/python2.7/dist-packages/django/core/management/init.py", line 330, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
File "/usr/local/lib/python2.7/dist-packages/django/core/management/base.py", line 393, in run_from_argv
self.execute(*args, **cmd_options)
File "/usr/local/lib/python2.7/dist-packages/django/core/management/base.py", line 444, in execute
output = self.handle(*args, **options)
File "/usr/local/lib/python2.7/dist-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 168, in handle
collected = self.collect()
File "/usr/local/lib/python2.7/dist-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 114, in collect
for original_path, processed_path, processed in processor:
File "/usr/local/lib/python2.7/dist-packages/pipeline/storage.py", line 33, in post_process
packager.pack_javascripts(package)
File "/usr/local/lib/python2.7/dist-packages/pipeline/packager.py", line 112, in pack_javascripts
return self.pack(package, self.compressor.compress_js, js_compressed, templates=package.templates, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/pipeline/packager.py", line 106, in pack
content = compress(paths, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/pipeline/compressors/init.py", line 67, in compress_js
js = getattr(compressor(verbose=self.verbose), 'compress_js')(js)
File "/usr/local/lib/python2.7/dist-packages/pipeline/compressors/yuglify.py", line 13, in compress_js
return self.compress_common(js, 'js', settings.PIPELINE_YUGLIFY_JS_ARGUMENTS)
File "/usr/local/lib/python2.7/dist-packages/pipeline/compressors/yuglify.py", line 10, in compress_common
return self.execute_command(command, content)
File "/usr/local/lib/python2.7/dist-packages/pipeline/compressors/init.py", line 244, in execute_command
raise CompressorError(stderr)
pipeline.exceptions.CompressorError:
/usr/local/lib/node_modules/yuglify/bin/yuglify:77
throw(err);
^
Error
at new JS_Parse_Error (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:263:18)
at js_error (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:271:11)
at croak (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:733:9)
at token_error (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:740:9)
at unexpected (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:746:9)
at /usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1112:13
at maybe_unary (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1209:19)
at expr_ops (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1236:24)
at maybe_conditional (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1240:20)
at maybe_assign (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1264:20)
at /usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1278:20
at vardefs (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1065:32)
at var_ (/usr/local/lib/node_modules/yuglify/node_modules/uglify-js/lib/parse-js.js:1077:26)

I noticed that this only happends whit jquery.js in vendor group

sry forgot about
PIPELINE_ENABLED = True


Tar task also needs encoding

@bigdaz @mark-vieira
Tar task has a little different with Zip, the Untar in current Ant version (1.9.3) does not support to set encoding, and I noticed that there was a revert of Ant version from 1.9.5 to 1.9.3.
As mentioned in Apache Ant Homepage

Ant 1.9.6 fixes a regression in the zip package introduced with Ant 1.9.5.

I think Ant 1.9.6 could make us all good ;)

@AlphaHinex Thank you for the pull request. The comment I just made about the related PR is relevant for this case as well. Please take a look at https://github.com/gradle/gradle/pull/520

@AlphaHinex is the upgrade to Ant 1.9.6 strictly necessary for this PR or is it just to have support for setting encoding when using ant.untar?

I think it's the second one

If that's the case then let's pull that out into potentially a separate PR. If the Ant upgrade isn't required for this PR then it shouldn't be included.

@AlphaHinex we haven't heard from you in a little while. Are you still interested in this change? If so, separating the ant upgrade into a separate PR, would be a great way to expose the encoding property to the tar task. Let us know if you are going to be able to continue working on this.

Sorry for the late. I don't understand why should we separate the upgrade, because our tar action relied on the TarOutputStream of Ant, and without the upgrade, maybe we will do more to support encoding.

Sorry to be lazy and ask this here instead of just looking it up myself. Are you saying that version 1.9.3 of the ant launcher jar doesn't support an "encoding" argument when creating a TarOutputStream, but 1.9.6 does?  So, for us to be able to add support for an "encoding" option in the Tar task, we'll either have to upgrade to ant 1.9.6 or do a lot more work to figure out a way to support encoding on tar operations.
If that's your argument, I still think it would be good to separate out the changes just so we are changing one thing at a time. If the change in the ant version causes us problems by itself, it will be easier to recognize the cause of the problems if the change is in its own commit. Granted, we wouldn't be able to revert it without also reverting the changes to the TarCopyAction, but we'd rather keep them as focused as possible and risk having to keep track of inter-commit dependencies like this one. Make sense?

Sorry, I made a mistake. It's Untar, not TarOutputStream that needs to upgrade Ant.
Untar is only used in test code, maybe the upgrade is not necessary. I need some time to check in details, after all this PR was a long time ago.

Needs #579 to make unit tests pass

Given that we now have a design doc #599 I'm reopening this pull request expecting that something very close to this will be desired as a result of that design discussion.

@AlphaHinex The design doc has been approved and merged in. Are you interested in picking this change back up and adjusting it according to the decisions that came out of the design?
I'm going to hand over the review of this change to @eskatos who is super-familiar with Tar.

Yes, maybe I should close this PR and create a new one to implement the metadata encoding part in the design.

Hi @AlphaHinex,
Yes please, feel free to close this PR and create a new one according to the new plan.
Please review the design doc, it has been updated since then.
About testing, you could look how similar integration tests in ArchiveIntegrationTest, ZipIntegrationTest and JarIntegrationTest are setup and introduce a TarIntegrationTest.
Cheers

@AlphaHinex According to the discussion, we are going to close this PR. We are looking forward to your new PR.


prompt format (input vs instruction).

In the readme you say input->instruction->response, but during training it's instruction->input->response. Now the latter seems like a mistake, but it is what it is src.
So perhaps you need to change your prompting to match the training?

Maybe it won't make a difference, since alpaca seems fairly robust to prompt formatting, but the results will be interesting either way!

That's very interesting thanks. So maybe there is no point in using input, and it's better just to stick to the prompt_no_input format (context, instruction, response format) found [here](https://github.com/tloen/alpaca-lora/blob/main/templates/alpaca.json#L4]?


Is there a non-NAT version of the extender?

As the title says

No, not on this code base.
Von: Rikka0_0小六花 @.>
Gesendet: Dienstag, 23. Januar 2024 12:06
An: martin-ger/esp_wifi_repeater @.>
Cc: Subscribed @.***>
Betreff: [martin-ger/esp_wifi_repeater] Is there a non-NAT version of the extender? (Issue #529)
As the title says
—
Reply to this email directly, view it on GitHub https://github.com/martin-ger/esp_wifi_repeater/issues/529 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2UTCZZDDTMVPD55JZJZVTYP6KSLAVCNFSM6AAAAABCGZFSNGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TKOBSGQ4TSNA .
You are receiving this because you are subscribed to this thread.  https://github.com/notifications/beacon/AF2UTC7KNI6P3BVC23IJQE3YP6KSLA5CNFSM6AAAAABCGZFSNGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHHZ26AMI.gif Message ID: @.*** @.***> >


[BUG]

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When the user is present somewhere down on the Icons page, clicking the eos-icons logo in Navbar does nothing.
Expected Behavior
Clicking the Navbar logo should restore the site to its default state i.e. how the site looks on the first-page load, clearing the How to use section, search and URL params.
Steps To Reproduce

Open the site and scroll down.
Select any icon and try to click the logo in the Navbar

Anything else?
No response
What browsers are you seeing the problem on?
No response

Can you give this issue a proper title?


Allow subpaths along with vhost in the RabbitMQ connection string. Extract them from the URL using string operations

Allow subpaths along with vhost in the RabbitMQ connection string.
Extract them from the URL using string operations.
Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Changelog has been updated and is aligned with our changelog requirements
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #2634

Thanks for the improvement ❤ Could you add some unit test to check this new parameter? Additionally, this new parameter needs to be documented in keda-docs repository

Hi, sure, thanks for the quick review and response from you ❤ I will do it ASAP

Changes look good to me @AmorBielyi .
Did you test the above changes on a RabbitMQ setup with pathPrefix?
Ref: https://github.com/kedacore/sample-go-rabbitmq

Changes look good to me @AmorBielyi .
Did you test the above changes on a RabbitMQ setup with pathPrefix?
Ref: https://github.com/kedacore/sample-go-rabbitmq

Not yet. I will test it today

@AmorBielyi Could you get the changes work with the amqp protocol? What I realized during my test is that the amqp go library does not support subpath in host URI at all.
https://github.com/kedacore/keda/blob/main/vendor/github.com/rabbitmq/amqp091-go/uri.go#L34

/run-e2e rabbit

Rebase main branch please, there are some required changes for e2e tests

Changes look good to me @AmorBielyi .
Did you test the above changes on a RabbitMQ setup with pathPrefix?
Ref: https://github.com/kedacore/sample-go-rabbitmq

Yes, tested

@AmorBielyi Could you get the changes work with the amqp protocol? What I realized during my test is that the amqp go library does not support subpath in host URI at all.
https://github.com/kedacore/keda/blob/main/vendor/github.com/rabbitmq/amqp091-go/uri.go#L34

I suppose we don't need to support subpaths in connection string for amqp case, it's only necessary for RabbitMQ Management HTTP API

Could you update your PR? it's done against release/v2.10 instead of main

sure, done, could you check please?

it's still against the wrong branch:

To update the branch:

Once the branch is updated, the PR will calculate the code agains main branch

it's still against the wrong branch:
To update the branch:
Once the branch is updated, the PR will calculate the code agains main branch

Hi, thanks! sorry about this, I've done, the branch now is 'main', all conflicts were resolved, unit test for RabbitMQ passed, let me know when you finished with review please

/run-e2e rabbit

There are still some style issues + DCO :(

There are still some style issues + DCO :(
Yeah.. I know, thanks) I am trying to resolve them now

Is it okay?

That's perfect. If DCO is solved, np at all
During the rebase something hasn't gone well, because the changelog isn't correct. The other changes than yours are wrong. If you check the original changelog, they aren't there :/
Could you just remove them? I hope that it's enough 🤞

/run-e2e rabbit

@JorTurFer oh, there was a simple conflict just right before an auto-merge, I resolved it right now so let's wait workflow's tests one more time, please enable auto-merge again

/skip-e2e

@JorTurFer great! could you please approve PR if everything is done

I thought they I done it, sorry


version 1.4.0 project build fail

using the keys F6, F9, F7 shows an error and doesn't perform anything
vs code: 1.47.2
electron: 7.3.2
chrome: 78.0.3904.130
node.js: 12.8.1
v8: 7.8.279.23-electron.0
os: windows x64 10.0.18362

1.40 暂时移除了快捷键


Can wg-portal autocreate peers on ldap sync?

Hello, this is a great tool, but (as far as I understood) user needs to login and only then wg-peer is generated. It would be great if there is/would be an option to autogenerate peers on ldap sync. Is there such an option?
As a workaround I added CreateUserDefaultPeer to updateLdapUsers ldapsync.go:
		if err := s.CreateUserDefaultPeer(user.Email, s.wg.Cfg.GetDefaultDeviceName()); err != nil {
			// Not a fatal error, just log it...
			logrus.Errorf("failed to automatically create vpn peer for %s: %v", user.Email, err)
		}

Ok,  i'll do the PR then as it looks rather simple.
I've got one more question: (I'll create a separate issue if needed)
I think it would be neat if there would be an option to create certs (when there are multiple interfaced) based on (ldap) groups. what do you think about this?


Background Android - not working

Hi everyone!
version: 1.0.3 (Not running latest version)
react-native: 0.62.2
I'm working on a project that main idea is to connect with a specific device, and send commands and receive responses. After getting all this data, I'm persisting into a local database. It works very well for IOS, however, it doesn't for Android. For Android, functions like receives and sends stopped when the app goes to the background or sleep mode.
I know that the way IOS and Android handle the background task is different. So I would like to confirm with you guys if exist any other solution for that.
I believe that this question is more in terms of the architecture of how to use this library.
Current app:
React-native (layer) =>

Bluetooth state;
Connection with the device;
Device logic;
Send commands, and receive responses;
Manage the state of devices;
Persisting write commands/read response into a database; (It is dispatched by device state changes); **** doesn't work for Android, the app stop completely

Android native (layer) => I'm doing nothing right now;
=============================================================
Proposed solution app:
React-native (layer) => Do nothing;
Android native (layer) =>

Bluetooth state;
Connection with the device;
Device logic;
Send commands, and receive responses;
Manage the state of devices;
Persisting write commands/read response into a database;

I NEED to persist the send commands and the receive responses into a database.

In other words, I need to know the device's state (connected/disconnected) / also some business states. The only solution that I found was to reimplement all flow of Bluetooth in this native part. Does anyone have more solutions for that?
Let me know if it wasn't clear.
Thank you guys

I am experiencing exactly the same problem.


Make easily understandable documents

README.md
Contributing.md
Wiki

Should explain How RefMutContainer works
Explain Rust's Ownership and why this lib requires users understand this.
Explain RefMutContainer's is from tokenizer crate.

This is now being performed in Wiki.


[TC6BETA4] Focus crafting crashes game.

Specifically, the Plan and Exchange focus.
When you try to combine the two of them, the game will crash,
Edit: After further testing, I think Focus crafting is borked. I can't drag two options into the sockets without the game crashing on me. I'll do the test again, but with only TC6.
Edit2: With only Thaumcraft-1.10.2-6.0.BETA4 and Baubles-1.10.2-1.3.13, it still crashes when you try to put more than one focus options into the focus crafting grid. Running Forge <IP_ADDRESS>1, and Minecraft 1.10.2

I'm having an error with even crafting the initial touch-flame focus.
crash report

Duplicate of this one I think: https://github.com/Azanor/thaumcraft-beta/issues/237

I am running into this issue as well

same this is a big issue

having the same problem, definitely a  fatal bug


Upload .HDC button not working properly

          Also, none of the powers or martial maneuvers are being imported either.

Originally posted by @RPMiller1 in https://github.com/dmdorman/hero6e-foundryvtt/issues/28#issuecomment-1457092665

As for the powers and maneuvers, I import the HDC file and I get the characteristics and skills populated, but no powers are martial maneuvers are populated. At a minimum, I would have expected all the standard maneuvers to be in there, but there is nothing.

Could you attach the .HDC file you're using?

The upload button definitely needs some rework. Hopefully I'll be able to get to it tonight

All 6 of them?

Just one will work

It won't let me attach HDC files here, so just a moment while I zip them up.
Combatants.zip

Sorry, gave you all 6. I did notice inconsistencies when uploading them, so you might want to try them all anyway.

Thanks!

I believe this is addressed by changes I made in 2.0.4
Something to be aware of is the 'powers' type items are broken right now and will require a rewrite. My suggestion for powers is to create the item separately and then drag it onto the character sheet.
You can create the item from the upper right hand side. Its the icon in-between the person and book icons. Then choose 'power' for type.
Then open the desired actor sheet and you should be able to drag the power from the right hand side to the actor sheet

I just tried uploading 6e versions of two of the characters and I got this error:

6thEdition.zip
I've attached the two files causing the problem. The other ones do not appear to be causing this error.

I know what causes this. Should be able to fix tonight
If you want to get around this you can edit those characters in Hero Designer and make sure every power/perk/talent/etc has a name defined. Though this is definitely a bug in how the Upload .HDC button handles things

No worries. I'm not in a rush, so I can wait.

looks like this was probably caused by the blank spaces in the the .HDC file. Didn't know you could do that lol.
The error message in this case seems like nothing to worry about. Setting a release that should suppress this message.

Up next would be either a power item rework or actor sheet redesign

Either one would be great, but I think the power item would be more useful, but likely more work I'm sure. Actually, as I think about it, what would be really awesome would be to automatically include all the default maneuvers in the actor sheet. That would be great especially for new players. I'm introducing my son's group to the system and using your module to make it as easy as possible and having all those default maneuvers would be a huge boon. But I'm guessing that would still be a lot of effort because you would likely need to still incorporate all the martial maneuvers to make it fully functional?

The default maneuvers should be there (unfortunately only after uploading a .HDC file). If their missing that's a bug lol. You should also be able to add optional maneuvers by changing the settings and doing a .HDC upload again.
Yeah I need to move the martial maneuvers stuff over with the default maneuvers.
The bug with the power type items has to do with editing the items from the actor sheet directly. You should still be able to create powers on the right hand side, but Uploading .HDC files won't get you any of the automation that comes with building out the item.

Okay. I'll take a look at that again and see if they are there now, and let you know. I'll also look into building the items. I'm new to Foundry as a VTT as well, so I'm learning it at the same time I'm trying to get the Hero functionality. I've seen Hero System APIs written in java in other VTTs, so I get what a massive undertaking it is and appreciate all the time you've invested.


Gulp error handler in browser thingy

After the new task system comes out, it would be cool to have a chrome extension (or use devtools somehow) that shows errors from gulp in the browser so you don't have to keep switching back and forth between the terminal and your app.
Suggested by @distracteddev
This would be in its own repo, just putting it here for brainstorming purposes

Going to close this, as there are a few user-land tools people can use


OCPBUGS-33081: Skip images that don't follow standards, semver and na…

…ming
Description
This fix addresses the issues when image names are missing as well as incorrect semver usage. The images will be skipped and not mirrored, the console will output a warning with relevant image (in semver case only).
Fixes # OCPBUGS-33081
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
I used the following imagesetconfiguration
apiVersion: mirror.openshift.io/v2alpha1
kind: ImageSetConfiguration
archiveSize: 4
mirror:
  operators:
    - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.15
      packages:
      - name: aws-load-balancer-operator
  - catalog: registry.redhat.io/redhat/community-operator-index:v4.15
    full: false

Executed with the following command
bin/oc-mirror --config ocpbugs-33081.yaml --v2 docker://localhost:5000/m2m  --workspace file://ocpbugs-33081 --dest-tls-verify=false --loglevel info

Expected Outcome
As this was a fairly large mirroring (+ 880) images I had issues with mirroring the whole catalog.
I have included a  truncated console output
2024/05/15 16:50:25  [WARN]   : ⚠  --v2 flag identified, flow redirected to the oc-mirror v2 version. This is Tech Preview, it is still under development and it is not production ready.
2024/05/15 16:50:25  [INFO]   : 👋 Hello, welcome to oc-mirror
2024/05/15 16:50:25  [INFO]   : ⚙  setting up the environment for you...
2024/05/15 16:50:25  [INFO]   : 🔀 workflow mode: mirrorToMirror
2024/05/15 16:50:25  [INFO]   : 🕵  going to discover the necessary images...
2024/05/15 16:50:25  [INFO]   : 🔍 collecting release images...
2024/05/15 16:50:25  [INFO]   : 🔍 collecting operator images...
2024/05/15 16:51:37  [WARN]   : mirroring skipped : reference name is empty
2024/05/15 16:51:37  [WARN]   : mirroring skipped : unable to parse image centos/postgresql-10-centos7 correctly : tag and digest are empty
2024/05/15 16:51:37  [WARN]   : mirroring skipped : unable to parse image registry.redhat.io/openshift4/ose-kube-rbac-proxy correctly : tag and digest are empty
2024/05/15 16:51:37  [WARN]   : mirroring skipped : unable to parse image quay.io/noobaa/pause correctly : tag and digest are empty
2024/05/15 16:51:37  [WARN]   : mirroring skipped : unable to parse image registry.redhat.io/openshift4/ose-kube-rbac-proxy correctly : tag and digest are empty
2024/05/15 16:51:37  [INFO]   : 🔍 collecting additional images...
2024/05/15 16:51:37  [INFO]   : 🚀 Start copying the images...
2024/05/15 16:51:37  [INFO]   : === Overall Progress - copying image 1 / 882 ===
2024/05/15 16:51:37  [INFO]   : copying release image 0 / 0
2024/05/15 16:51:37  [INFO]   : copying operator image 1 / 882
2024/05/15 16:51:37  [INFO]   : copying additional image 0 / 0
2024/05/15 16:51:37  [INFO]   : ================================================
2024/05/15 16:51:37  [INFO]   : copying image: docker://public.ecr.aws/aws-controllers-k8s/organizations-controller:0.0.6

@kasturinarra @zhouying7780 - I would appreciate if you could test this thoroughly. I ran out of space using the original imagesetconfig as posetd in the JIRA issue

/jira refresh

/retest

lgtm

Hi @lmzuccarelli
Nice work!
I was wondering if all the images we skip (images with both tag and digest, empty ref, semver incompatible, etc) should be added to the file used in Batch to list images in error.
This way,  the end user is informed via the file in case oc-mirror is running in a CI where warnings will not be viewed.
WDYT?

Hi @lmzuccarelli Nice work! I was wondering if all the images we skip (images with both tag and digest, empty ref, semver incompatible, etc) should be added to the file used in Batch to list images in error. This way, the end user is informed via the file in case oc-mirror is running in a CI where warnings will not be viewed. WDYT?

Yes good point, I'll add them in

/label qe-approved

/lgtm

/jira refresh

/cherry-pick release-4.16