[Bug]: vpc not created on getting started

Welcome to Amazon EKS Blueprints!

[X] Yes, I've searched similar issues on GitHub and didn't find any.

Using macOS
Terraform
❯ terraform version
Terraform v1.2.1
on darwin_amd

AWS CLI
❯ aws --version
aws-cli/2.7.4 Python/3.9.11 Darwin/21.4.0 exe/x86_64 prompt/off

What did you do and What did you see instead?
Using a fresh aws account, no VPC in west-2, only the default vpc there
Following getting started here https://aws-ia.github.io/terraform-aws-eks-blueprints/getting-started/
git clone https://github.com/aws-ia/terraform-aws-eks-blueprints.git
cd examples/eks-cluster-with-new-vpc/
terraform init
terraform plan

Running the apply stated in the doc to create VPC
terraform apply -target="module.aws_vpc"

It doesn't create the VPC, here is the output
❯ terraform apply -target="module.aws_vpc"

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.
╷
│ Warning: Resource targeting is in effect
│
│ You are creating a plan with the -target option, which means that the result of this plan may not represent all of the changes
│ requested by the current configuration.
│
│ The -target option is not for routine use, and is provided only for exceptional situations such as recovering from errors or
│ mistakes, or when Terraform specifically suggests to use it as part of an error message.
╵
╷
│ Warning: Applied changes may be incomplete
│
│ The plan was created with the -target option in effect, so some changes requested in the configuration may have been ignored and the
│ output values may not be fully updated. Run the following command to verify that no other changes are pending:
│     terraform plan
│
│ Note that the -target option is not suitable for routine use, and is provided only for exceptional situations such as recovering from
│ errors or mistakes, or when Terraform specifically suggests to use it as part of an error message.
╵
╷
│ Warning: Redundant ignore_changes element
│
│   on .terraform/modules/eks_blueprints.aws_eks/main.tf line 298, in resource "aws_eks_addon" "this":
│  298: resource "aws_eks_addon" "this" {
│
│ Adding an attribute name to ignore_changes tells Terraform to ignore future changes to the argument in configuration after the object
│ has been created, retaining the value originally configured.
│
│ The attribute modified_at is decided by the provider alone and therefore there can be no configured value to compare with. Including
│ this attribute in ignore_changes has no effect. Remove the attribute from ignore_changes to quiet this warning.
╵
╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│
│   on .terraform/modules/eks_blueprints_kubernetes_addons.ondat/locals.tf line 2, in terraform:
│    2:   experiments = [module_variable_optional_attrs]
│
│ Experimental features are subject to breaking changes in future minor or patch releases, based on feedback.
│
│ If you have feedback on the design of this feature, please open a GitHub issue to discuss it.
│
│ (and 72 more similar warnings elsewhere)
╵

Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Additional Information
No response

@csantanapr can this be closed as well?

@vara-bonthu this is a dupe and is working for me now with correct module command “terraform apply -target=module.vpc”


Fixes #3006: Markdown misinterpreting issue URLs

Markdown module is now more strict about what URLs it interprets as issue and commit URLs.
The main change is that it now checks to see if the URL starts with the setting.AppUrl before treating it as an issue or commit URL.

Could you clean up to 1 commit?
And one minor comment, otherwise LGTM.

@Unknwon, all done

Thanks!


FR: set "null" value default

Hey, it's me again.  Could we have a setting to set the default of a "null" field to 0 or blank?  The string throws off some of the other plugins' workflows.  Thanks.

Hi! this issue has also been metionned by others : https://github.com/mdelobelle/metadatamenu/issues/233#issuecomment-1370295698
It's a core behavior of obsidian. I've asked the devs if they can improve it somehow https://discord.com/channels/686053708261228577/989603365606531104/1061219891149017119
I'm waiting for their feedback.

In version 0.3.10 of the plugin this does not happen. I have been using this version until the problem is fixed and it works fine

Hi you can test it in 0.4.11

In this version it works fine. thanks for the hard work


Toggle Tick after Rezone

Is it able to Make a auto Tick func if you Rezone?
If i toggle Pcons in GH it will obvious Tick (as long as i got it in settings obviously..)
If team TPs into Doa my tick is out, so i have to Tick manual, or Disable - Enable Cons again to get my Pick.. Probably make a auto Tick after rezone into another outpost

how about every time you zone, TB checks if you have pcons on, and ticks if you do?

honestly, I disagree. Ticking is the player saying "I'm here and I'm ready". If toolbox did that, the player could be AFK and the tick would lose its meaning.
Personally, I quickly toggle pcons on and off to re-tick and I think it's ok.


Support for different robot_description ROS params

Historically, a <Urdf> node underneath <Kinematica> specified the rosparam on which the URDF was. These are still in all initialisation files, but unused.
Instead, robot_description is hard-coded in the Scene.cpp initialisers.
In some cases, e.g. for the husky, the robot_description channel contains another description than the one we'd like. [We're seeing rviz-crashes due to the differences for instance]
We'd like to be able to set the param on which to look for the description as one of the initialisation flags, as it used to be. E.g. /exotica/robot_description

Hence,
a) would we like to reactivate use of the <Urdf> tag - or perhaps another tag or directly in a server parameter (where we now have packages and urdf file names inside packages)
b) would we like to delete all instances of the <Urdf> tag remnants and switch to something else?
cc @VladimirIvan

Proposal:

We'll add an optimal parameter RobotDescription to the Server.
If RobotDescription is found, it uses the param name defined there. If it's not, it falls back to robot_description.

Does that sound fair?


Change pre-commit

Changed max line lenght, since 500 is crazy for python, 88 is the default
Add isort, this makes the files a littler prettier to read, moves all the imports to the top.

Actually it breaks stuff... will test this still before merging


Convert to ES modules

See https://github.com/facebook/react/pull/18145
Test Plan
I've verified this locally and the build outputs aren't changed due to this. They're only slightly different due to the dependency updates.

It’d be great to discuss major changes like this before making them; enzyme will need to use a shallow renderer that’s developed using the same standards enzyme itself is.

@ljharb could you clarify why this would affect enzyme's usage of this package at all? I have verified the build outputs and there shouldn't be any difference, i.e. there's no need to do require('react-shallow-renderer').default if that's what you're worried about?

Sorry we didn't communicate this clearly; this is mirroring the change we did in the React repo: https://github.com/facebook/react/pull/18145. It shouldn't affect the build in any meaningful way for the CJS mode.

@gaearon ie the intention for Facebook to continue maintaining a parallel implementation, or will this become the canonical one?

The plan is for this to be the canonical one.


Exception at deployment: Unable to parse HTTP response content (Service: AWSLambda; Status Code: 400

What could cause this?

[ERROR] Failed to execute goal org.lambadaframework:lambada-maven-plugin:0.0.6:deploy (default) on project MYPROJECT: Exception at deployment: Unable to parse HTTP response content (Service: AWSLambda; Status Code: 400; Error Code: null; Request ID: null) -> [Help 1]

Resolved: This issue was caused by setting the value of  to the word 'default'. Changing the value to 'production' fixes this particular error.


Missing Docker/Alpine images for ARM64

I sadly recognized, that there are no ARM64 Docker images based on Alpine available. 😢
Alpine itself provides images for ARM64.
Would like to use Temurin in Docker/Alpine on my Apple silicon CPU.
docker pull eclipse-temurin:17-jre-alpine

17-jre-alpine: Pulling from library/eclipse-temurin
no matching manifest for linux/arm64/v8 in the manifest list entries

duplicate of https://github.com/adoptium/containers/issues/158


capa-iam-operator pods fail to be admitted

Found during https://github.com/giantswarm/roadmap/issues/2023. Version 0.5.1 works, so it's likely the seccomp change in 0.6.0. Compare to https://github.com/giantswarm/aws-vpc-operator/pull/38 for the likely fix.

We should finish https://github.com/giantswarm/capa-iam-operator/pull/157 and then add latest changes to https://github.com/giantswarm/capa-iam-operator/pull/156 before releasing.

We need to wait until we confirm that the cert-manger role changes work.

Pod admission works, so closing this. https://github.com/giantswarm/roadmap/issues/1981 is a separate topic to test.


Forms edit

We need to develop editing mode for forms assessment.

The buttons on the screen are working. But after saving the form and opening it again the data is shown like it was not deleted.

fixed


bug:  fix the dupllicate rerendering of head() and toast, model updated

Bug Description:
[Describe the bug in detail here. Include any error messages, unexpected behavior, or other relevant information.]
Versions Affected:

[x] v3
[ ] v2
[ ] v1

Steps to Reproduce:

Train an manually inputed model

Wait for execution to complete
Expected Behavior:

You see Welcome to Decenter Again

And entire rerendering of head() due to experimental rerender

Actual Behavior:

Don't rerender toasts, alerts

Additional Information:
[Include any additional information that may be helpful in understanding and resolving the bug. This may include screenshots, code snippets, or logs.]
Environment:

[x] Decenter-AI
[x] Local
[x] Public Hosted

Ignore the following for  Decenter-AI

Python Version: 3.10.0
Operating System: Macos/Linux/Macos

Relevant Code Snippet:

Resolved in #46


[Feature] Implement application deletion

Notion ticket link

Implement application deletion

Implementation description

Application/request deletion feature
Designed to maintain consistency with #310

Notes

Database schema changes will need to be enabled to allow for on delete cascade

Testing
Before deleting Application 3
rcd=# select * from replacement_applications where application_id = 3;
 application_id | reason |     lost_timestamp     | lost_location | stolen_police_file_number | stolen_jurisdiction | stolen_police_officer_name |                      event_description                      |         created_at         |         updated_at
----------------+--------+------------------------+---------------+---------------------------+---------------------+----------------------------+-------------------------------------------------------------+----------------------------+----------------------------
              3 | LOST   | 2020-01-03 00:00:00+00 | DC Library    |                           |                     |                            | I left my APP on the table and when I came back it was gone | 2023-09-03 09:26:59.326+00 | 2023-09-03 09:26:59.326+00
(1 row)

rcd=# select * from permits where application_id = 3;
 rcd_permit_id |   type    | expiry_date | active | application_id | applicant_id |         created_at         |         updated_at
---------------+-----------+-------------+--------+----------------+--------------+----------------------------+----------------------------
             2 | PERMANENT | 2025-01-01  | t      |              3 |            3 | 2023-09-03 09:26:59.377+00 | 2023-09-03 09:26:59.377+00
(1 row)

rcd=# select * from application_processing where id = 3;
 id | status  | rejected_reason | app_number | app_number_employee_id |   app_number_updated_at    | app_holepunched | app_holepunched_employee_id | app_holepunched_updated_at | wallet_card_created | wallet_card_created_employee_id | wallet_card_created_updated_at | review_request_completed | review_request_completed_employee_id | review_request_completed_updated_at | invoice_number | documents_s3_object_key | documents_url_employee_id |  documents_url_updated_at  | app_mailed | app_mailed_employee_id |   app_mailed_updated_at    | payment_refunded | payment_refunded_employee_id | payment_refunded_updated_at |         created_at         |         updated_at
----+---------+-----------------+------------+------------------------+----------------------------+-----------------+-----------------------------+----------------------------+---------------------+---------------------------------+--------------------------------+--------------------------+--------------------------------------+-------------------------------------+----------------+-------------------------+---------------------------+----------------------------+------------+------------------------+----------------------------+------------------+------------------------------+-----------------------------+----------------------------+----------------------------
  3 | PENDING |                 |            |                        | 2023-09-03 09:26:59.326+00 | f               |                             | 2023-09-03 09:26:59.326+00 | f                   |                                 | 2023-09-03 09:26:59.326+00     | f                        |                                      | 2023-09-03 09:26:59.326+00          |                |                         |                           | 2023-09-03 09:26:59.326+00 | f          |                        | 2023-09-03 09:26:59.326+00 | f                |                              | 2023-09-03 09:26:59.326+00  | 2023-09-03 09:26:59.326+00 | 2023-09-03 09:26:59.326+00
(1 row)

rcd=# select * from applications where id = 3;
 id | first_name | middle_name | last_name |   phone    |          email           | receive_email_updates |  address_line_1   | address_line_2 |   city    | province | country | postal_code | permit_type | payment_method | processing_fee | donation_amount | paid_through_shopify | shopify_payment_status | shopify_confirmation_number | shopify_order_number | shipping_address_same_as_home_address | shipping_full_name | shipping_address_line_1 | shipping_address_line_2 | shipping_city | shipping_province | shipping_country | shipping_postal_code | billing_address_same_as_home_address | billing_full_name | billing_address_line_1 | billing_address_line_2 | billing_city | billing_province | billing_country | billing_postal_code |    type     | notes | applicant_id | application_processing_id |         created_at         |         updated_at
----+------------+-------------+-----------+------------+--------------------------+-----------------------+-------------------+----------------+-----------+----------+---------+-------------+-------------+----------------+----------------+-----------------+----------------------+------------------------+-----------------------------+----------------------+---------------------------------------+--------------------+-------------------------+-------------------------+---------------+-------------------+------------------+----------------------+--------------------------------------+-------------------+------------------------+------------------------+--------------+------------------+-----------------+---------------------+-------------+-------+--------------+---------------------------+----------------------------+----------------------------
  3 | Applicant  |             | Three     |<PHONE_NUMBER> |<EMAIL_ADDRESS>| f                     | 789 Vancouver Rd. |                | Vancouver | BC       | Canada  | B1C2D3      | PERMANENT   | CHEQUE         |         $31.00 |         $100.00 | f                    |                        |                             |                      | t                                     |                    |                         |                         |               |                   |                  |                      | t                                    |                   |                        |                        |              |                  |                 |                     | REPLACEMENT |       |            3 |                         3 | 2023-09-03 09:26:59.326+00 | 2023-09-03 09:26:59.326+00
(1 row)

Demo
https://github.com/uwblueprint/richmond-centre-for-disability/assets/77544794/a24f9f3a-1f2d-4e5a-98ff-a133845da141
After deleting Application 3
rcd=# select * from replacement_applications where application_id = 3;
tion_id = 3;
select * from application_processing  application_id | reason | lost_timestamp | lost_location | stolen_police_file_number | stolen_jurisdiction | stolen_police_officer_name | event_description | created_at | updated_at
----------------+--------+----------------+---------------+---------------------------+---------------------+----------------------------+-------------------+------------+------------
(0 rows)

rcd=# select * from permits where application_id = 3;
 rcd_permit_id | type | expiry_date | active | application_id | applicant_id | created_at | updated_at
---------------+------+-------------+--------+----------------+--------------+------------+------------
(0 rows)

rcd=# select * from application_processing where id = 3;
 id | status | rejected_reason | app_number | app_number_employee_id | app_number_updated_at | app_holepunched | app_holepunched_employee_id | app_holepunched_updated_at | wallet_card_created | wallet_card_created_employee_id | wallet_card_created_updated_at | review_request_completed | review_request_completed_employee_id | review_request_completed_updated_at | invoice_number | documents_s3_object_key | documents_url_employee_id | documents_url_updated_at | app_mailed | app_mailed_employee_id | app_mailed_updated_at | payment_refunded | payment_refunded_employee_id | payment_refunded_updated_at | created_at | updated_at
----+--------+-----------------+------------+------------------------+-----------------------+-----------------+-----------------------------+----------------------------+---------------------+---------------------------------+--------------------------------+--------------------------+--------------------------------------+-------------------------------------+----------------+-------------------------+---------------------------+--------------------------+------------+------------------------+-----------------------+------------------+------------------------------+-----------------------------+------------+------------
(0 rows)

rcd=# select * from applications where id = 3;
 id | first_name | middle_name | last_name | phone | email | receive_email_updates | address_line_1 | address_line_2 | city | province | country | postal_code | permit_type | payment_method | processing_fee | donation_amount | paid_through_shopify | shopify_payment_status | shopify_confirmation_number | shopify_order_number | shipping_address_same_as_home_address | shipping_full_name | shipping_address_line_1 | shipping_address_line_2 | shipping_city | shipping_province | shipping_country | shipping_postal_code | billing_address_same_as_home_address | billing_full_name | billing_address_line_1 | billing_address_line_2 | billing_city | billing_province | billing_country | billing_postal_code | type | notes | applicant_id | application_processing_id | created_at | updated_at
----+------------+-------------+-----------+-------+-------+-----------------------+----------------+----------------+------+----------+---------+-------------+-------------+----------------+----------------+-----------------+----------------------+------------------------+-----------------------------+----------------------+---------------------------------------+--------------------+-------------------------+-------------------------+---------------+-------------------+------------------+----------------------+--------------------------------------+-------------------+------------------------+------------------------+--------------+------------------+-----------------+---------------------+------+-------+--------------+---------------------------+------------+------------
(0 rows)

Checklist

[x] My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
[x] I have run the appropriate linter(s)
[x] I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

I think you should add an Actions column to the requests page to allow for faster request deletion and to match the functionality of applicant deletion.

@ChinemeremChigbo There isn't an existing actions menu on the requests page so it'll take some more work. I suggest we merge this first and then add it if we have bandwidth in the future, or if RCD asks for it specifically.

I think you should add an Actions column to the requests page to allow for faster request deletion and to match the functionality of applicant deletion.

@ChinemeremChigbo There isn't an existing actions menu on the requests page so it'll take some more work. I suggest we merge this first and then add it if we have bandwidth in the future, or if RCD asks for it specifically.

Sound good!

Closing this as branch was mistakenly made off main instead of staging.


docs: update description catalog json

Description
Update catalog.json file correcting whitespaces and add long description
Types of changes in this PR
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[x] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

:tada: This PR is included in version 7.0.1 :tada:
The release is available on:

GitHub release
v7.0.1

Your semantic-release bot :package::rocket:


Feat xdp map pinning

Enable bpf map pinning for CNDP
tested with https://github.com/intel/afxdp-plugins-for-kubernetes/pull/47
Tested with the AF_XDP device plugin and standalone.

LGTM, I only had one comment. Sorry it took me so long to review.

TY for reviewing. no worries at all. I still have to rework based on our discussion. I will remove the unnecessary flags and repost

Ok - I think this is finally ready for review. I've gotten rid of the privileged key for lports. it's automatically configured if the uds or xsk pinned map is used.
Last outstanding things is to clean up the rust implementation...
Do we want to support xsk pinned map for the lport groups?

Not sure if we want to support xsk pinned map in lport group. I guess I do not fully understand the reason to add it, sorry.
Being I do not fully understand, I think it is up to you  and if it provides any extra feature or support. If the feature is to be used by everyone then I would say yes, but it only is some very small number of use cases then we add it as an enhancement for later.

Not sure if we want to support xsk pinned map in lport group. I guess I do not fully understand the reason to add it, sorry.

It would be needed if we want to use this config script in K8s Pods... But as this isn't supported today (group script for configuring a large number of ports in the pod) then it's not needed.
I will add an issue for the rust support.
Also - can I just say I hate the superlinter :) it has dinged so many scripts that I just deleted a line from... but of course I will fix the complaints :)

Yes the super linter is not very good as it does not support Go code very well and has some strange configurations. :-(

Added an issue for rust support here


Compatibility issue: 'ValueError: Graph disconnected' error with models using dict as inputs?

Hello,
It's really exiting to see Keras moving forward and offering us an opportunity to jump into JAX / Pytorch without a steep learning curve!
We understand the current project status, and what "high velocity" means of course, and we would like to contribute some feedback on a design pattern that does not seem covered by your examples.
We have since many years now normalized our TF/Keras model architecture patterns to use model creation functions that take dict for inputs and return dict for outputs.
In the attached minimal example python file, we have found that when the model creation function receives a dict, but uses the tensor after some operations, like intensity normalization, cast, ... instead of feeding it to a Layer,  the following error is raised at model creation:
ValueError: Graph disconnected: cannot find parent for tensor <KerasTensor shape=(None, 16), dtype=float32, name=keras_tensor_2> at operation '<Dense name=dense_1, built=True>'. The following previous operations were accessed without issue: []

This error is not raised for the current TF/Keras, and is present for all the backends, which should not be surprising given the early stage at which it is raised.
We have hundredths of code/models using this approach, and we would appreciate your feedback concerning its status (bug or definitely not supported).
Anyway, thanks a lot for your excellent work.
minimal_example.py.txt

Thanks for the report. Can you provide a reproducible code snippet to show the issue (i.e. a piece of code that can actually be run, in a standalone way)?

Hi François,
I attached a minimal example to my issue (please rename it as github does not allow .py files)

I attached a minimal example to my issue (please rename it as github does not allow .py files)

The code cannot be run since it is pseudocode. Please provide an executable code snippet.

Hi, really?
it is python code, just rename to .py. github don't want me to attach a .py file.

Thanks a lot.

This should now be fixed at HEAD. Please check. You can pull the code from GitHub and run python pip_build.py --install to build and install the latest version of the package.


configure everything by command line

Is your feature request related to a problem? Please describe.
to integrate pgcat into our testing ci(gitlab ci), it's inconvenient to do a file mapping
Describe the solution you'd like
pgcat accept config file pass in as string
pgcat --config '[general]\n host="<IP_ADDRESS>"\n ...'

Describe alternatives you've considered
set each config by command line
pgcat --config.general.host "<IP_ADDRESS>" --config.general.port 6432 ...

Additional context
gitlab ci reference

we are using pgcat as a service in the ci and haven't figured out a way to easy adding a file :)
in case someone needs it , I build the image using entrypoint
EXPOSE 6432
ADD entrypoint.sh /
ENTRYPOINT [ "/entrypoint.sh" ]

#!/bin/sh
if [ -n "$PGCAT_CONFIG" ]
then
    mkdir -p /etc/pgcat
    echo "$PGCAT_CONFIG" > /etc/pgcat/pgcat.toml
    echo "write to /etc/pgcat/pgcat.toml"
fi

exec "$@"


Error Installing library

****/node_modules/react-native-network-info/ios/RNNetworkInfo.h:10:9: 'React/RCTBridge.h' file not found
This is my config.

The 1.0 release requires react-native .40 or above. Can you try to update your react-native and see if the problem persist?
Alternatively you can downgrade reactive-native-network-info to 0.2.0

I'll assume this is resolved by upgrading react native. Let me know if not.


Possible bug: Incorrect counting for Todo

Example:
* Todo [0/3]
  [ ] Hello

* ABC
  [ ] do W

* CDE
  X,Y, happened
  -> [ ] do Z

Behaviour: For [X] Hello, the count updates to [1/3]. For [X] do W or -> [X] do Z, the count does not update. I think that the desirable behaviour would be Todo [0/1] which updates only when [ ] Hello is updated.

Ah, yes this is not consistent.  I guess the count should be "* Todo [0/1]" in this case.


Support Fargate compute environment in AWS Batch

AWS added support for this late last year: https://aws.amazon.com/blogs/aws/new-fully-serverless-batch-computing-with-aws-batch-support-for-aws-fargate/
However when setting the Type to FARGATE in ComputeResources, we get an error that mandates unsupported options such as MinvCpus, MaxvCpus, InstanceRole, etc. because CloudFormation advises against the use of those options for Fargate type Compute Environments.
Sample errors when not mentioning the aforesaid unnecessary options:
failed (Resource MaxvCpus required in type <unknown type> (title: BatchComputeResources))
failed (Resource InstanceRole required in type <unknown type> (title: BatchComputeResources))
failed (Resource InstanceTypes required in type <unknown type> (title: BatchComputeResources))

The resource has been updated with the above commit to reflect some of the properties being not required. Note: MaxvCpus is required according to the documentation.


Pick up 1ES PT prerequisites fixes

On 2024-04-03, the 1ES team rolled out a number of improvements. At least one of those improvements affected the windows-1es-pt-prerequisites-v2 artefact. We should recreate our base images and then the custom images to ensure we include this fix in our next rollout.

Release Note Category

[x] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description
Regenerated our base and custom images to pick up a windows-1es-pt-prerequisites-v2 fix. That fix should avoid ESLint issues in 1ES PT pipelines that had caused some teams to use 1es-* images instead of something closer to their "before times" choices.

New images now exist. image-generation build #20240404.05 reported 15 new images for the day (UTC time). A check of one of the Windows logs confirmed the windows-1es-pt-prerequisites-v2 artefact installed Node.js in a private location. It also sets $env:NODE_1ESPT_LOCATION, presumably for use in SDL tasks that require Node.js.

done


App freezing when the link is pressed and the app is not in the background

This was seen several times in the current build on iOS. Can be replicated on Android as well?

Click here to accept Keeper request for AnantS Hexa wallet- link will expire in 24 hours
https://hexawallet.io/sta/atcg/AnantS/b1ce8f509dececd973505aba9116e495ee29bca4000bdc1ea7f62407e2bedb784cc0bd92181391e97d234de6b3fb144460133e492c92c89eadbfb657192344cb69bbc2240efa4aaba283fb05a2ccf538/num/861/1600590329683/v1.1.2

Not happening with Android device.Tested on 1.1.2(115)


dashboard/app: link heatmap generation

Please review.

@dvyukov stamp please
It adds the second "coverage" menu item.


Esp32 bluetooth beacon sample not working

Describe the bug
The Bluetooth beacon sample is not working in Zephyr RTOS version 4.0.0. However, the same sample code works perfectly in version 3.7.0. It seems there might be an issue with the HAL module in version 4.0.0. I am using an ESP32 DevKitC WROOM.
To Reproduce

Build and flash the bluetooth beacon sample for v4.0.0. Afterwards flash the sample with v3.7.0.
Expected behavior

Advertising the Zephyrproject website.
Impact

In version 4.0.0 i can't see an advertisement but the log-output is the same as in version 3.7.0.
Logs and console output

*** Booting Zephyr OS build v4.0.0-978-g113875d53c7a ***
Starting Beacon Demo
[00:00:00.174,000] <inf> esp32_bt_adapter: BT controller compile version [241c96c]
[00:00:00.394,000] <inf> bt_hci_core: Identity: E8:31:CD:C4:D3:EC (public)
[00:00:00.394,000] <inf> bt_hci_core: HCI: version 4.2 (0x08) revision 0x030e, manufacturer 0x0060
[00:00:00.394,000] <inf> bt_hci_core: LMP: version 4.2 (0x08) subver 0x030e
Bluetooth initialized
Beacon started, advertising as E8:31:CD:C4:D3:EC (public)

*** Booting Zephyr OS   build v3.7.0 ***
Starting Beacon Demo
[00:00:00.169,000] <inf>   esp32_bt_adapter: BT controller compile version [946b762]
[00:00:00.472,000] <inf>   bt_hci_core: Identity: E8:31:CD:C4:D3:EC (public)
[00:00:00.472,000] <inf>   bt_hci_core: HCI: version 4.2 (0x08) revision 0x030e, manufacturer   0x0060
[00:00:00.472,000] <inf>   bt_hci_core: LMP: version 4.2 (0x08) subver 0x030e
Bluetooth initialized
Beacon started, advertising as   E8:31:CD:C4:D3:EC (public)

Environment:

OS: Windows
Zephyr SDK 0.17

Additional context

@Treblin1 Thanks for reporting, we are checking the root cause.


Azure Devops CI/CD For Aks

I have been going through the docs of CI/CD for AKS using azure pipeline.
There are certain docs for CI/CD but those are based on yaml file.
I have successfully deployed to AKS from Azure CI/CD with Azure devops classic editor pipeline.
I didn't get any docs regarding CI/CD using classic editor. So I am Prepared some docs for the Pipeline process . Is there any changes for approval if i Send a PR for the CI CD process for deploying app to aks .?
Let me know if its relevant then i will contribute .

@partha-sarathi-sarkar to clarify, are you hoping to make pull requests to existing docs? Can you please link those docs here?
The guide for contributing is here: https://docs.microsoft.com/en-us/contribute/#quick-edits-to-existing-documents

@partha-sarathi-sarkar Just following up here... Feel free to take a look at the contributing guide shared and create the PR. Once the PR is created, the assigned reviewer would help you further by providing feedback and walk you through in getting the doc merged.

@partha-sarathi-sarkar Hope you were able to work up a PR from the links shared.
Since there is no doc related feedback to address here, we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Add Publisher Tag to metadata

Feature Description
CBZ files have a publisher tag metadata field and I think it would be nice if it was to tag the CBZ files with the series' publisher. The reader that I host sorts series by publishers so I think it would be useful to have this tag.
Solution you would like
No response
Alternatives you have considered
No response
Additional context
No response

Tagging metadata is handled by mangal. So this is out of Kaizoku's capabilities.


Feature request: Dropbox share link after upload?

I just installed Kap on Ventura 13.2.1 and it seems to work great. One feature I would LOVE to have, and it would be a gamer changer in my opinion. After uploading to Dropbox if the app could display the SHARE link that Dropbox provides, a quick "copy" of that link, and I could share it with clients using Dropbox! Possible? Thanks for the great app. Love it so far

Hi there, thanks for the kind words. There is a plugin for this, but it's quite old so I've no idea if it still works: https://www.npmjs.com/package/kap-dropbox
You can install this from your preferences in Kap itself.

Hi there, thanks for the kind words. There is a plugin for this, but it's quite old so I've no idea if it still works: https://www.npmjs.com/package/kap-dropbox
You can install this from your preferences in Kap itself.

I'm in the preferences and I don't see how to install a new plugin. I see the list of available but not sure how to search or add this? Do you have a newbie guide on how that is done? I'll test it

Sorry, now I see what you mean. So I have notifications turned on for the Dropbox plugin. It does upload fine. I can get a share link in Dropbox, but no desktop notification is showing, so there is no way to capture the share link from the application itself. I can login dropbox to get the link, but obviously that's not a great workflow... Possible fix?

Note: I am not running the Dropbox app, or anything Dropbox on my computer. Just the Kap app itself.

According to the plugin readme, there is a mute option that is on by default. If you configure the plugin from the installed plugins preference pane, you are able to turn this off:

Yep, I tried that. I don't seem to get any notifications without the Dropbox app. Let me test some more. Back in a few

Update: Ok, notifications are working! I had to switch completely off (slider) the Share on Dropbox plugin, then re-enable it. Then it prompts to "configure" and then I turned off the default mute option. Now when I export to Dropbox I get a pop up on the desktop that copies the share link to clipboard. Thanks for your help.

Ah, thanks for debugging! I'm glad you got it working. Please don't hesitate to submit another issue if you have any problems.


4.3.3, обновлён configor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.786%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
1134

Relevant Lines:
1263

💛  - Coveralls


D2 trained on some custom dataset?

Since coco really takes a long time to train, did u consider train D2 with a smaller dataset?
Also, I believe yolov5 repo can easily get AP up to 40+ on coco now.

Someone reported doing well in a competition with the D2 on a custom dataset, it works. Very minimal tweaks to the train script if you have annotations in coco format. The Kaggle example linked on the README shows a clean usage of a completely custom dataset and albumentations aug pipeline.
Yolov5 is good, lots of other detection models can pass 40 too. Tradeoffs for all of them. The EfficientDet D2 is roughly 1/3 the param count and 1/4 the FLOPS of Yolov5-m, yet EffDet is slower on GPU due to the depthwise separable convs... so always tradeoffs, tradeoffs. I'd point out the latest Yolos are using mosaic aug and use giou or ciou in the loss. Mosaic + giou/ciou/diou could add gains here.... the augmentation currently being used here is extremely simply.


find objects by name

At the moment we can access one single atlas/parcellation/space/region by id.
Since siibra-python has the feature of a fuzzy search, we could implement the same feature for siibra-api.
For example:
.../parcellation/<par-id>/region?find=<region-name>
This would search fuzzy by region name and either return a single region or a Bad Request Response if more than one region was found.

hmm, in fact the current parcellation/<parc-id>/region/<region-id> already performs the said fuzzy search (though not explicit in doc/rest pattern)
I would argue that the new endpoint /region?find=<fuzzy-region-name> should return a list of regions that matches the query?

I actually thought we have the fuzzy search for region only until we have IDs for each region.
But you are right we could also return a list of all found regions. Would make more sence for a find-feature.


Modal does not work and presents the following errors in the console

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
I am upgrading from version v4.0 to version v5.1.3 where I only have this problem, I should add that I am using jquery v3.6.0 and popper v2.11.2
 <a  href="javascript:void(0)" data-bs-toggle="modal" data-bs-target="#<?php echo controller_esc_html(controller_category_id()) ; ?>"><label style="color: #ddd;"class="fa fa-<?php echo controller_mel_html(incubus_category_icon( controller_category_id() )); ?> category-icon fa-lg">
print console
Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '#2' is not a valid selector.
at r (https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.1.3/js/bootstrap.min.js:6:920)
at HTMLAnchorElement. (https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.1.3/js/bootstrap.min.js:6:35242)
at HTMLDocument.s (https://cdnjs.cloudflare.com/ajax/libs/bootstrap/5.1.3/js/bootstrap.min.js:6:4721)
details
const getElementFromSelector = element => {
  const selector = getSelector(element)

  return selector ? document.querySelector(selector) : null        //problem
}

I would be very grateful if you give me some clues on how to solve this problem that I have been looking for and is reported in previous versions but that have no solution for me.
Reduced test cases
codepen does not have an optimal development environment to fully reproduce my problem
What operating system(s) are you seeing the problem on?
Linux
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
v5.1.3

Just try to put a string prefix to your ids and you 'll be fine ;)
(document.queryselector doesn't support numeric id selectors)

to add to this: while the html spec removed restrictions on id, allowing any kind of string (as long as it has at least one character, and doesn't contain spaces), CSS3 still disallows id values that start with a number. and as document.querySelector effectively runs a CSS query, any ids that start with a number will fail.


fix integration read only /proc test

When there are no port mapping we do not have to set the sysctl.
This made it through CI because me merged two PR without rebasing.

/hold cancel

/lgtm


Add expand/collapse without animation

Ideally, we should add a noAnimation flag to the setPanelState method. Feel free to update your PR, and i'll merge it.


Layout container

Description
fixing #320
List of proposed changes:

Moved LayoutContainer implementation to the Layout component for each page
Removed the use of it from individual pages along with redundant divs

Additional Notes
None of the content of the pages was edited at all, just the line indenting.

Some issues with the splash page. Looks like it's still taking the footer somehow and the background image isn't stretching the full page

Funny enough, the footer has been there for a while... both issues fixed now.


feat: Add method argument to onIndexChange callback

This argument is either gesture/tap and allows one to differentiate between the action user took to change the active scene.
Motivation
In the app I am building, I need to track the change method for analytics.
Test plan
Verified manually that this change did not cause any regressions.

Rebased on top of the TS conversion.

I'm not sure about this. jumpToIndex being called doesn't mean it's a tab press.

In the app I am building, I need to track the change method for analytics.

You can use the onTabPress callback to check tab changes due to tab press.

I'm not sure about this. jumpToIndex being called doesn't mean it's a tab press.

Did you mean to write jumpTo? Since in the PR jumpToIndex of TabView only forwards the passed argument.
Using onTabPress requires me to use an instance variable to prevent sending a second analytics event from onIndexChange callback.

What if I change the implementation like this:

Add second argument to Pager.jumpTo and pass it along to calls to this.props.onIndexChange in its body.
Modify onPress handler of TabBarItem inside TabBar.tsx to and add a second argument 'tap' to this.props.jumpTo call
[Optional] Change constant string 'gesture' to 'other' for semantic reasons (it might be a gesture or a reaction to a changed index in props)

I need to think about it a bit.

Using onTabPress requires me to use an instance variable to prevent sending a second analytics event from onIndexChange callback which is not very elegant.

For now this seems reasonable. We do similar in react-navigation.

Used onTabPress and got the functionality I wanted.
this PR can be closed from my perspective


Made tty? public (as documented in code)

Describe the change
Makes the Spinner#tty? method public.
Why are we doing this?
This allows users to check if the spinner will produce output and write their own output if not.
Benefits
See above.
Drawbacks
It's an extra method to maintain.
Requirements
Put an X between brackets on each line if you have done the item:
[x] Tests written & passing locally?
[x] Code style checked?
[x] Rebased with master branch?
[x] Documentation updated?

Coverage increased (+0.01%) to 98.209% when pulling 416294f91a00d1e98d5de42da7329130394cddb0 on ankane:tty into fe28df1640f1383beeb2e0a559e6f94bcef43f57 on piotrmurach:master.

Thanks ❤

Thanks Piotr!


Renames generated folder to js_interop.

Renames generated folder to js_interop.
Fixes the analyzer error except for public_member_api_docs and non_constant_identifier_names.
Removes the unused interface Promise.then

Fixes #101855
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the [CLA].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
[x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

This LGTM! Have you managed to verify this works with the google_sign_in/google_sign_in example app?

Yes. I ran the all the integration tests for the example app with flutter_driver and all the test has passed.

I ran the all the integration tests for the example app with flutter_driver and all the test has passed.

@peixinli I meant the demo app of the core plugin (this one), but I think the API it uses was deprecated mid last year so it might not work for reasons other than our code change :(

I ran the all the integration tests for the example app with flutter_driver and all the test has passed.

@peixinli I meant the demo app of the core plugin (this one), but I think the API it uses was deprecated mid last year so it might not work for reasons other than our code change :(

Verified it works on the example app!

This is fully green and should land soon (?)


make metadata storage use gateway

the metadata storage needs to authenticate requests. to do that it needs to look up users ... at the gateway: also part of https://github.com/owncloud/ocis/pull/657/files?file-filters[]=.go#diff-b84d51d5e5422fb71fac4eb8110295ee3ca12512189a4244683f4c3f4ac70becR100
closing here


cfssl: 1.3.2 -> 1.4.1

[x] Jep, cfssl server works (now) with embedded static files
[x] All built commandos tested manually for --help

nix-review outputs in comment below.

/marvin opt-in
/status needs_reviewer

Result of nixpkgs-review pr 94123 1

1 package built:
- cfssl

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/234

/status awaiting_changes

Thanks for the commit message catch. That would have been bad for parseability.

go-ryce: init at 1.0.0 you had it right earlier :(
Otherwise LGTM

Oh, I assumed the original package name prevails "go.rice" - since the nix one is to avoid the ".". I'll change that tomorrow.

/status awaiting_changes

/status needs_merger

@GrahamcOfBorg build cfssl

Whoop Whoop! :partying_face:


Fix for #602 - SplashScreen management

Removed d's property 'endSplashHandler' now useless
use the QRunnable pointer received as parameter
call the handler, if not null, at 'startup()' end

Thanks for fixing this!


add query path if starts with / and use query if facet is ft

What is this contribution about?
Loom

Record a quick screencast describing your changes to show the team and help reviewers.

Link

Please provide a link to a branch that demonstrates this pull request in action.

I think it is died. I was using on deco-sites/poc-als


Adding reserved func pointer.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Remember to update the copyrights on those files to 2016.

Thanks @murgatroid99 I'm not sure that I need this PR in the first place (have it there to launch a build) but I'll keep it in mind if I decide to go through.

I convinced myself that this is not needed as we can extend the plugin API with breaking changes. See 17a7bd6f582d21370954b91fac6755c3e153a568 if you are interested...


Unable to resolve a configuration into a single file for use as a Task input

Current Behavior
There does not appear to be a workable way to resolve a configuration into a single output file for use as a Task input.  Various API was attempted to be used unsuccessfully (see reproducer).  Any attempts are resolving beyond resolveConfig.incoming.files (e.g., resolveConfig.incoming.files.singleFile) fails at ConsumerTask execution-time.
As a result, if the task being configured accepts a File or Property<File>, there is no way to properly configure it.
Expected Behavior
Existing APIs should:

Cause the configuration to resolve
Resolution of the configuration should trigger the producer task
Configurations with a single artifact file should be able to provide this artifact file as a task input

Context (optional)
We are working toward project isolation but have some cross-project artifact sharing that requires feeding a task with a single input file.  The existing task definition cannot be changed to accept a ConfigurableFileCollection.  The result is that we are unable to define out project in a manner which is considered best practice and project isolation- ready.
Self-contained Reproducer Project
The following can reproduce the project:
First, the producer module (:) with its build.gradle.kts file:
import org.gradle.api.artifacts.type.ArtifactTypeDefinition.ARTIFACT_TYPE_ATTRIBUTE

tasks.register("clean", Delete::class.java) {
    delete(project.layout.buildDirectory)
}

val producerConfig = configurations.consumable("producerConfig") {
    attributes {
        attribute(ARTIFACT_TYPE_ATTRIBUTE, "repro-producer")
    }
}

abstract class ProducerTask : DefaultTask() {
    @get:OutputFile
    abstract val output: RegularFileProperty

    @TaskAction
    fun run() {
        logger.lifecycle("ProducerTask")
        output.asFile.get().writeText(System.currentTimeMillis().toString())
    }
}

val producerTask = tasks.register("producer", ProducerTask::class.java) {
    output.set(layout.buildDirectory.file("producer.txt"))
}

project.artifacts.add(producerConfig.name, producerTask)

Second, the consumer module (:consumer) with its build.gradle.kts file:
import org.gradle.api.artifacts.type.ArtifactTypeDefinition.ARTIFACT_TYPE_ATTRIBUTE

abstract class ConsumerTask : DefaultTask() {
    @get:InputFiles
    abstract val input: ConfigurableFileCollection

    @TaskAction
    fun run() {
        logger.lifecycle("ConsumerTask")
        input.files.forEach { file ->
            logger.lifecycle("file = $file: ${file.readText()}")
        }
    }
}

tasks.register("clean", Delete::class.java) {
    delete(project.layout.buildDirectory)
}

val resolveConfig = configurations.create("consumerConfig") {
    isCanBeResolved = true
    isCanBeConsumed = false
    dependencies.add(project.dependencies.project(":"))
}

tasks.register("consumer", ConsumerTask::class.java) {
    /*
     * This works.  The `producer` task is automatically run and feeds the `consumer` task.
     */
    //input.setFrom(resolveConfig.incoming.files)

    // ..but I need to feed the (existing) task with a single file, not a file collection!

    /*
     * None of the following work.  The producer task is not run and the consumer task fails.
     *
     * Execution failed for task ':consumer:consumer'.
     *   > java.io.FileNotFoundException: /Users/username/src/ebay/repro-gradle-config/build/producer.txt (No such file or directory)
     */

    input.setFrom(resolveConfig.incoming.files.singleFile)

//    input.setFrom(provider { resolveConfig.incoming.files.singleFile })

    /*
     * This doesn't work either, failing with a different message:
     *
     * > Could not create task ':consumer:consumer'.
     *  > Collection is empty.
     */
//    input.setFrom(resolveConfig.incoming.files.asFileTree.single())
}

With the above in place, the following reproduces the failure:
./gradlew clean consumer

Gradle version
8.10.2
Build scan URL (optional)
No response
Your Environment (optional)

Gradle 8.10.2
Build time:    2024-09-23 21:28:39 UTC
Revision:      415adb9e06a516c44b391edff552fd42139443f7
Kotlin:        1.9.24
Groovy:        3.0.22
Ant:           Apache Ant(TM) version 1.10.14 compiled on August 16 2023
Launcher JVM:  17.0.6 (Azul Systems, Inc. 17.0.6+10-LTS)
Daemon JVM:    /Users/username/Library/Java/open-jdk-<IP_ADDRESS>-apple/zulu-17.jdk/Contents/Home (no JDK specified, using current Java home)
OS:            Mac OS X 14.6.1 aarch64

Does getElements work for you?
https://docs.gradle.org/current/javadoc/org/gradle/api/file/FileCollection.html#getElements()

Hah!  Somehow I missed that API while trying pretty much everything else.  It does indeed appear to work!
    input.setFrom(resolveConfig.incoming.files.elements.map { it.first().asFile })

Thanks!


PR: voyager-java-integ-test

In this PR 1) An env var "LB_TYPE" is added. Set it to "VOYAGER" to use it as loadBlancer instead of the default TRAEFIK; 2) Correspondingly VOYAGER operator and VOYAGER ingress-per-domain resource will be installed/created; 3) For 2 domains testcase, the 2nd domain will use "30306" instead of the default "30305" as loadBalancerWebPort.

@vanajamukkara On Jenkins I can see Voyager logic is kicked in on http://wls-jenkins.us.oracle.com/view/weblogic-operator/job/weblogic-kubernetes-operator-javatest/1102/
but didn't get luck. It looks an intermittent issue.
I just started another run

@vanajamukkara...there are some "TODO" commented out code I'm going to delete.


"UseSampling" is hard to discover. Consider moving it into the same namespace as TelemetryProcessorsChainBuilder

Consider moving UseSampling into the same namespace as telemetryProcessorsChainBuilder to simplify discovery of this method

@upendras, @vitalyf007 what do you think of moving it to the namespace Microsoft.ApplicationInsights.Extensibility?

makes sense...right now you have to look at documentation to find it...


Add client close frame

Continuing on from #51, this PR uses the existing close frame logic from the Protocol class to provide a close reason. The method (getCloseFrame()) was actually misnamed because it returns a Payload, ready for use.
Two other bugs fixed: we weren't masking, and in Connection: the Payload object was given to send() rather than the string buffer.

wow, thanks, @dominics !!! =)


[flow] no-unused-modules: add flow type support

Adds support for reporting flow type exports. Fixes #1540

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.

Coverage decreased (-5.8%) to 90.672% when pulling 3d33b70438dd9030cbd8bfd8bc99631ca67fd809 on rfermann:1540 into 112a0bf442e52b25cd7029a9905df2508e191ac1 on benmosher:master.


Add support for delete and update statements

@rugg2 Thanks for raising an issue. Could you provide more insight into what you're looking for? I'm just a bit confused because dataframe_sql isn't a database, it's just an abstraction on operations that you might perform on a pandas dataframe, like selection, aggregation, grouping, etc.

My use case: I've got a bunch of SQL queries that insert and delete records from a database, but we're moving our data out of the RDS, so no more SQL queries are available. I'm interested in your library to handle those queries.
I imagine you could:

update the original data frame: so if doing delete operation, update the data frame in place: effectively in memory database
alternatively you could return a new data frame: perhaps with different syntax of the type df_out = df_in.sql("delete rows query"), where df_out returns the state
under the hood, whether you want to keep the original dataset immutable, remove rows, or add a logical delete flag on the rows, I have no opinion

@rugg2 Ok very interesting! I'll definitely look into adding this


Rust install does not work.

I think the rust url is wrong or outdated. The output is shown below:
~/P/p/golowkster ❯❯❯ nv ls-versions --rust-prebuilt                                                                fizzbuzz_example ⬆ ◼
* rust-prebuilt:
nightly-2016-10-27
~/P/p/golowkster ❯❯❯ nv rm rust                                                                                fizzbuzz_example ⬆ ◼
Environment rust was deleted.
~/P/p/golowkster ❯❯❯ nv mk --rust=nightly-2016-10-27 rust                                                          fizzbuzz_example ⬆ ◼
Creating environment: rust ...
 * installing rust==nightly-2016-10-27 ...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   183  100   183    0     0    948      0 --:--:-- --:--:-- --:--:--   948
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
envirius: failed to download 'http://static.rust-lang.org/dist/rust-nightly.tar.gz'
envirius: unable to fetch source file for rust==nightly-2016-10-27

Should be fixed by #20

I don't think so. Synced up and re-installed and still got this:
~/S/envirius_latest ❯❯❯ nv version                                                                                master
nv 0.8.1
~/S/envirius_latest ❯❯❯ nv mk rust --rust-prebuilt=1.12.1                                                                        master
Creating environment: rust ...
 * installing rust-prebuilt==1.12.1 ...
plug_post_install_actions:6: no such file or directory: /home/lowks/.envirius/envs/rust/bin/activate-rust
plug_post_install_actions:7: no such file or directory: /home/lowks/.envirius/envs/rust/bin/activate-rust
plug_post_install_actions:8: no such file or directory: /home/lowks/.envirius/envs/rust/bin/activate-rust
plug_post_install_actions:9: no such file or directory: /home/lowks/.envirius/envs/rust/bin/activate-rust
chmod: cannot access '/home/lowks/.envirius/envs/rust/bin/activate-rust': No such file or directory
plug_post_install_actions:13: no such file or directory: /home/lowks/.envirius/envs/rust/bin/deactivate-rust
chmod: cannot access '/home/lowks/.envirius/envs/rust/bin/deactivate-rust': No such file or directory
nv_cmd_default:190: no such file or directory: /home/lowks/.envirius/envs/rust/envirius.info
 * done (in 0 secs.)

@lowks try one more time, please

@lowks btw, i don't see 1.12.1 for rust atm:
➥ nv ls-versions --rust-prebuilt
* rust-prebuilt:
0.1         0.2         0.3         0.3.1       0.4
0.5         0.6         0.7         0.8         0.9
0.10        0.11.0      0.12.0      nightly-2016-10-28

➥ curl -s https://static.rust-lang.org/dist/index.html | grep "rust-0.12.1.tar.gz" | wc -l
0
➥ curl -s https://static.rust-lang.org/dist/index.html | grep "rust-0.12.0.tar.gz" | wc -l
2

Works for me:
➥ nv version
nv 0.8.2
➥ nv mk --rust-prebuilt=0.12.0
Creating environment: rust-prebuilt-0.12.0 ...
 * installing rust-prebuilt==0.12.0 ...
 * done (in 5 secs.)
➥ nv on rust-prebuilt-0.12.0
Environment rust-prebuilt-0.12.0 activated.
(rust-prebuilt-0.12.0) ➥ rustc --version
rustc 0.12.0 (ba4081a5a 2014-10-07 13:44:41 -0700)

Hang on. Can I know what does rust-prebuilt mean ? If I wanted to install a rust release ... which is at 1.12.1 how do I do that ?

If you do nv mk --rust=0.12.0 then rust's sources will be downloaded and it will be compiled/installed from the sources (unpack, configure, compile):

https://github.com/ekalinin/envirius/blob/master/src/nv-plugins/rust#L23

If you do nv mk --rust-prebuilt=0.12.0 then just rust's pre-compiled binaries will be downloaded and installed (it's much faster):

https://github.com/ekalinin/envirius/blob/master/src/nv-plugins/rust-prebuilt#L17


Don't show error dialog when disconnecting some media sources

Some media sources show an error dialog when disconnecting because we cant really know if its clean exit or an actual error
So don't show at all and only log?
Or rework the dialog to a snackbar?

Show all errors in a snackbar by default.


Progress on image download

The web interface shows progress on image upload (thanks!).
However, it does not show any progress if you specify a URI to download, which for larger images could be quite useful.

@cco3 yes!
progress reporting is a difficult matter, especially here where we eventually have multiple ways to fetch things using multiple libraries. For container and docker registries, e.g., "docker://" URLs we use skopeo, which itself does not report progress yet. (See https://github.com/containers/skopeo/issues/658#issuecomment-982345744 )
Otherwise, for HTTP URLs we use mostly Python requests that should be able to provide some progress reporting by iterating through the content stream.  https://towardsdatascience.com/how-to-download-files-using-python-part-2-19b95be4cdb5 has a nice article on streaming in requests.
A tool or library-independent alternative could be to track progress with files being written, but tools usually do not write progressively except to some opaque temp file, making this less practical and harder or not possible.

One idea would be to delegate the actual fetching of inputs to the pipeline execution task.
Project would be instantly created and the download part would happen at the start of the pipeline task, as a pre-step, to ensure all the project inputs are available.

Note that we now have a spinner in the web UI when the upload takes place for start. But that's not what you are looking for exactly @cco3 , right?

One idea would be to delegate the actual fetching of inputs to the pipeline execution task.

I am inclined to go with this. There is always a risk that the time of creation/check and the time of download/use creates some small TOCTOU issue but that may be minor if understood. One way to mitigate this would be to make the background download optional (in the UI, API and in the CLI).
We would still have an issue of progress reporting on docker:// URLs until there is upstream support

A spinner doesn't tell me how much progress has been made.  Given the size of these images, something larger would be helpful.

The solution is related to https://github.com/nexB/scancode.io/issues/410

The download of Project's inputs now takes place in the pipeline run.


Game Version 1.0 selected by default

Could it be possible to make the last game version available (or the one detected if possible) as the default selected game version?
At the moment, when launching the app it defaults to 1.0 which is often misleading regarding mod availability.
Thanks a lot

+1, Same problem here.


Fix an infinite loop when all 65536 requests are done

Also use a CSPRNG for generating random numbers (fallback to paragonie/random_compat for PHP 5)

That's not a robust solution. I think we should just use a second port when there's too high concurrency.

Good point … totally not thought about opening a separate UDP connection…

This will though require a bit more of a refactor … delaying then to sometime else.

The possible infinite loop is fixed in the Amp v2 version.


Draft - Adds Hilt example.

Creates a HelloHilt app module replicating the existing HelloDagger example.
Differences vs Vanilla Dagger sample

Application now includes @HiltAndroidApp.
AppComponent has been removed, and existing modules are now @Installed in Hilt's ApplicationComponent.
An @EntryPoint replaces AppComponent#viewModelFactories.

Limitations
Hilt doesn't support @AssistedInject yet. Hilt checks that included modules also have the @InstallIn annotation. Temporarily we'd have to disable that check.
(see https://dagger.dev/hilt/compiler-options for more detail).
The only solution I could think of is writing the @Module in Java.

Thanks for taking a look @gpeal, ready for another pass! : )


Views don't update during animations, is there a way to override this?

By default, Views in NestedViewList don't update until animations have completed. Is there a way to override this or force it to call the render method once before animating?

@clauderic - If you change state on a component it will render. You could try setting a state variable for "render" within the component to false in the initialState, and then set it to true before you begin the animation, so that it forces a render on the component. To set it back, you can then use willReceiveProps to update it to false again.


Refactor sui-client for Sui Rust SDK and Rust SDK example project

Still working on some docs, but code changes are ready for review.
Changes summary:

new sui-client crate contains all the essential apis to interact with the Sui gateway and fullnode via JSON RPC.
Cleaned up sui-json-rpc-api, moved all of the client code to sui-client and renamed it to sui-json-rpc-types
Added a copy of Rpc Api traits in sui-client crate due to jsonrpsee limitation
A new SuiRpcClient supporting http or ws rpc calls.
Created a tic-tac-toe CLI as an Sui SDK example project.
Docs for running the tic-tac-toe example.

Tic-tac-toe CLI screenshot

WIP:
SDK Docs
TODOs (future PRs):

A example project using WS and event API
A example project talking to the full node
Rethink jsonrpsee server and client implementation, we might want to handcraft the server instead of using the jsonrpsee proc macro.

license-check is complaining about the example project should be in the crate folder.... how do I whitelist this?

license-check is complaining about the example project should be in the crate folder.... how do I whitelist this?

There is no way to whitelist this (intentionally so). All rust crates should be in the crates directory, so i'd recommend you move the crate into the crates directory.

Cool. Should sui-client be called sui-sdk then?

Docs are ready for review as well @Clay-Mysten


Add confirmation when deleting review on reviews page, and ability to update review

[ ] Delete review confirmation
[ ] Update review

Dependent on #270

@advayanand  please update @SenghoungLim once this is resolved, thanks!

Dependent on issue #243 to attempt logging in on staging instance


Visual glitches in Options dialog for dark mode

Brief description of your issue
Earlier it was said, that dark mode is kinda experimental and any bug report for it will be ignored. So i will try to post here found visual issues for SI then :)
Inconsistent margins between checkboxes and labels:

Tool status:

Updater:

UserNotes (shouldn't it be named "User notes" with space between words?)

NetworkTools (same as above - "Network tools"?)

Al on SI 3.0.5553

margins between checkboxes and labels

Checkboxes are a known issue. It's caused by DrawTextW with Tahoma fonts. It just needs to be switched to uxtheme drawing whenever we have spare time.

UserNotes (shouldn't it be named "User notes" with space between words?)
NetworkTools (same as above - "Network tools"?)

These are the the plugin names/filenames. They're supposed to match so you know what options are for which plugin (and what options are lost when disabling plugins).

It just needs to be switched to uxtheme drawing whenever we have spare time.

OK, accepted.
Then i just leave this issue opened to rerember that this problem is known and will be fixed somewhen.

Only serious issue I'm seeing that needs fixing is

If it doesn't appear initially, it maybe toggling the use old colours that triggered this.
Use Old Colors shows in dark mode, but this doesnt, text is turned white, so iit appears to be just the background not changing

Fixed in latest nightly


Configure azure pipelines to run windows job

Purpose
Configure azure pipelines to run windows job
Fixes #
Check List

[ ] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19333 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19333   +/-   ##
=======================================
  Coverage   67.44%   67.44%
=======================================
  Files           5        5
  Lines         129      129
  Branches       19       19
=======================================
  Hits           87       87
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df21b9...5f0ff52. Read the comment docs.


feat(design): create chevron mixin to remove fontawesome dependency in design library

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
FontAwesome is only used in one instance in the design library (up/down chevron for accordion). We don't need to load the whole FontAwesome library if it's only used in one instance.
Fixes: #264
What is the new behavior?
Create chevron mixin to handle icons for accordion.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@damienwebdev squashed

@xelaint this includes changes from a different place, please fix.

@damienwebdev fixed it.


update vite

I haven't tested the build output - it still builds I assume it works... will test in a bit

@frank-weindel - changed peer to  "vite": "*" - so it won't worry about which vite a user uses as both work. Ran with demo app and built fine. Feel free to merge and do a release


Issue with javascript_importmap_tags "application-mcj" import-map/sprockets resolving [v0.3.3]

After update 0.3.2 > 0.3.3
it started to fail when accessing UI pages (RAILS_ENV=development)
web     |   Rendered /usr/local/bundle/gems/mission_control-jobs-0.3.3views/mission_control/jobs/queues/index.html.erb within layouts/mission_control/jobs/application (Duration: 9.9ms | GC: 0.0ms)
web     |   Rendered layout /usr/local/bundle/gems/mission_control-jobs-0.3.3views/layouts/mission_control/jobs/application.html.erb (Duration: 341.7ms | GC: 101.9ms)
web     | Completed 500 Internal Server Error in 554ms (ActiveRecord: 11.8ms (8 queries, 0 cached) | GC: 133.5ms)
web     |
web     |
web     |
web     | ActionView::Template::Error (Asset `controllers/application.js` was not declared to be precompiled in production.
web     | Declare links to your assets in `app/assets/config/manifest.js`.
web     |
web     |   //= link controllers/application.js
web     |
web     | and restart your server):
web     |
web     | Causes:
web     | Sprockets::Rails::Helper::AssetNotPrecompiledError (Asset `controllers/application.js` was not declared to be precompiled in production.
web     | Declare links to your assets in `app/assets/config/manifest.js`.
web     |
web     |   //= link controllers/application.js
web     |
web     | and restart your server)
web     |      9:   <meta name="turbo-cache-control" content="no-cache">
web     |     10:   <link rel="stylesheet"<EMAIL_ADDRESS>web     |     11:   <%= stylesheet_link_tag "mission_control/jobs/application", "data-turbo-track": "reload" %>
web     |     12:   <%= javascript_importmap_tags "application-mcj" %>
web     |     13: </head>
web     |     14: <body>
web     |     15:
web     |

Rails app itself uses sprockets, so I suppose it is related to issue that caused 0.3.3 fix https://github.com/rails/mission_control-jobs/issues/169
my app is not api-only and had no issues with 0.3.2, but it failed to make assets:precompile in production env with 0.3.2
still need to try, but maybe https://github.com/rails/mission_control-jobs/pull/163 is in the right direction (as in current error message it suggests manifest.js from parent app, but not from the mission_control engine, maybe it mixes them while precompiling?)
declaring it in "parent app" manifest.js liek suggested //= link controllers/application.js does not help (and I believe it should not), not sure why application-mcj is being translated into controllers/application.js path.

This is connected issues
https://github.com/rails/mission_control-jobs/issues/140
In our setup we are also useing esbuild to compile JS. And sprockets-rails to handle "assets:precompile".
I see that importmap-rails are also in the Gemfile, but it is not being used by our app.

While I still believe there should be a real solution, like PRs mentioned above.
Solution for those who are trying to find a workaround and have the same pre-conditions like mine:

this solution assumes that you are using smth else, not importmaps in yout Rails app! and Importmap was just pregenerated by rails new and never used, but also not removed.
remove gem "importmap-rails" from Gemfile
remove config/importmap.rb file

now mission_control does not overlap own importmap with your app's default importmap and works as expected!

Hey @iJackUA, this should have been fixed by #163. Do you mind verifying if things look good for you?

Going to close this one as it should be fixed now by #163.


Support for .html not available as answer, rather than only .png

In contrast to .pdf .html could work, tested also this, but also .html as answer did not work here.  Could be another useful alternative to .png (or images) in certain situations, meaning where you have already some .html but no .png, so why not just using that .html directly.

Can you expand on the example? I'm not exactly sure what you mean?
Like a secondary .html file that is used is just inserted as is?

Yes, exactly, as you put the path to .png, we would put the path to some .html file on our harddisk, same as pdf example would be a prepared .html with a few sentences only inside.
One example:  Those .html files could contain source codes, converted from source codes via highlight for example, just as one use case scenario.

Ye it's an interesting idea but I really don't think there is much demand for something like that.
Also the add-on already support source code with syntax highlighting

Well, I do not use it for source codes.  :smile:  It should be just an example so many people understand where it could be used.  I create my own language definitions, on the fly, just adding a list of "important" words, so those are shown in a different color or bold, just to emphasize them.  If you want to convert quickly a huge list of sentences, for example books  :smile_cat: this technique can be useful, even not knowing what the book is about beforehand, you would just do some pre analysis on most used words, most used word pairs, filtering out disturbing stopwords, plus use automatically generated noun lists, a combination of those, then take e.g. head 50 of those words, just as one technique.   We can combine tools freely, even if it was developed originally for source code highlighting, we can highlight any other text as well.
Regarding not much demand, is a weak thinking style, but no problem, whoever needs it so hardly can develop and use it, the idea is here now, anyone can read and think about it.  Thanks for responding.
Those important words one could not only highlight but also cloze delete!

Regarding not much demand, is a weak thinking style, but no problem, whoever needs it so hardly can develop and use it, the idea is here now, anyone can read and think about it. Thanks for responding.

To be more clear on what I really mean is that without a few people asking for something I do find it a bit hard to understand exactly what their usecase is. Thus is can be hard to design acceptance criteria to meet them. I general the conversation is a lot easier with some who is technical as they can express more clearly what they want.
For the example of the html files a few question would come to to mind straight away.

Would Anki support a full html page being embedded eg <html>.......</html>
Should I expect a full html page from the user
If i just support sinppets instead because anki does support a full page do I warn users that they are uploading won't work or do I try and parse out a snippet from what they have provided
etc

This is not necessary, just take the content of body, ignoring rest.
No, only what is output of highlight.  Preprocessed according to 1.

Important is to find a way which will work always in Anki.
Probably I should check the requirements of Anki first.


Native builds don't log warnings unless the build fails.

@donalmacc commented on Fri Nov 04 2016
Expected Behavior
If the compiler detects a warning, the user should be notified in the build, even if the build is succesful
Current Behavior
If a warning is generated, it is suppressed unless the build fails. This has been discussed before on the forums
Steps to Reproduce (for bugs)
If running on windows,

int main()
{
	return 0;
}

and build.gradle

model {

    components {
        Main(NativeExecutableSpec) {
            sources {
                cpp{
                    source{
                        srcDirs "src"
                        include "**/*.cpp"
                    }
                }
            }
        }
    }

}

generates a warning by default with MSVC 2013:
warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc
If the compile is successful, the warning is suppressed. remove the semicolon from return 0 and the build fails, but also logs the warning.
Your Environment
Gradle 3.1
Windows 10 pro x64
MSVC 2013 and 2015.
Can repro on debian jessie using gradle 3.1, with gcc 4.9 using a more complex example.

@lacasseio commented on Mon Nov 07 2016
Thanks @donalmacc for the report. To comment further on this issue, this can be seen as a regression when BuildOperationLogger was introduced but that modification was a necessity to fix interleaving logs from the parallel compilation. The current workaround would be to use /WX flag which "treats all warning as errors" for both the compiler and the linker.

@big-guy commented on Mon Nov 07 2016
To provide a little bit of history, this was something we did intentionally (to hide all output from the underlying tool) until we could find something better. The output was pretty useless when it was all jumbled together.

@lacasseio commented on Mon Nov 07 2016
We could probably print an excerpt of the output (just like when there is an error) all the time. This way we could at least see some warning. Better modeling could be done to grab and display the warning message in a more IDE friendly output. However, there is also the possibility to improve the integration of Gradle with Visual Studio. @donalmacc, could you comment on the use case for log warning? Are they needed in the context of the CLI or the IDE?

@donalmacc commented on Fri Nov 25 2016
Hi Daniel
Apologies for the delay getting back to you. I would argue that a jumbled/interleaved output is better than no output whatsoever. If I put a print statement in a closure and its executed in parallel, It's logged, albeit not in order. I'm actually quite shocked that the solution to this was to suppress the output of the tools.
@lacasseio Ideally we would have it working in both IDE and CLI builds. We have developers using the IDE for builds, and we have CI machines using CLI builds. If the developers and CI builds are receiving different information, that's not good.

@lacasseio commented on Mon Nov 28 2016
Good point @donalmacc. The discussion we had internally was to show compiler output on the console, but not interleave the output of parallel compilations. Gradle should collect the output for a compiler invocation as it does now, and write it to the console atomically once the compiler invocation has completed.

@donalmacc commented on Mon Nov 28 2016
Ideally it would output in-progress, (of course), but having it all flushed after the compile has completed would do perfectly.

dupe #226


Cloud switcher

Which issue this PR addresses:
Partially fixes 8644408
Based on https://github.com/Azure/ARO-RP/pull/1257
What this PR does / why we need it:
Adds script to switch between clouds and their secrets easily during development.
Usage: ./hack/select-cloud.sh and follow menu options.
Test plan for issue:

[x] Run script locally, observe that it performs intended behavior and does not result in permanent loss of original secrets folder (should be backed up to secrets-old), break either affected make target, or have any other problems.
[ ]  Pass E2E test, which uses modified make secrets

Is there any documentation that needs to be updated for this PR?
Yes, will update development documentation with instructions on how to use script.

going to try a different approach

going to try a different approach

discussed on Slack - let's look at the possibility of replacing "secrets" in our repo with $SECRETS

discussed on Slack - let's look at the possibility of replacing "secrets" in our repo with $SECRETS


Add pythainlp.tools.safe_print

Handle Unicode print on console

coverage: 32.633% (-0.6%) from 33.191%
when pulling 1650f24e051de7227577b820787b73fdda698bed on bact:add-safe-print
into c35e0f7d3199a9a583ac41ad24324020d2e7792a on PyThaiNLP:dev.


project still alive ?

Hi, i'm wondering if this project is still active ?
because, i don't want to use in my composition =/ and i t would too bad, because it's really usefull, in my opinion !

It is active. If you need a specific enhancement, please file a gitissue and/or submit a PR. Thanks.


Feature/1958/remove glyphicons

Replace all glyphicons with material icons and some fontawesome
ga4gh/dockstore#1958
Also removed tokens.component.ts and html because it does not appear to be used.
Also fixed cytoscape popper error when re-registering plugin
Fixed some state issues

Fixes for small bugs that were discovered while removing glyphicons.  Converted some components to material to maintain the same style as material icons


Portainer incorrectly marks used images as unused

Description

In the latest version, Portainer marks images which are in use as unused. You can see in the above screenshot that it failed to delete an image marked as unused because it is in use.

Steps to reproduce the issue:

Unknown how this was produced. This happens to some but not all of the images in use.

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Technical details:

Portainer version: 1.13.3
Target Docker version (the host/cluster you manage): 17.05.0-ce
Platform (windows/linux): Linux
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): Docker compose file
Target Swarm version (if applicable): 17.05.0-ce
Browser: Chrome 59 on Ubuntu

Well, Portainer will show the Unused label in front of images when there is no container using this image. Your issue is different, the Docker engine tells you that this image has dependent child image which is different from being used by any container.
I'm not sure what we should do here, maybe specify what the 'Unused' label means somewhere on this view.

Maybe add two colours?
On the one hand, I don't think that being unused is a 'warning' level message. E.g., images on the host which are run for specific tasks, not as services. So, I'd suggest to use a 'info' button for the actual behaviour.
On the other hand, I think that knowing that dependent child images exist is a warning level message, because it does not allow to remove it directly (unless it is forced).
However, some further discussion is required to come up with a consistent and clean implementation. The main issue here is that labels are independent:
hasRunningContainer ? '' : 'Unused [info]';
hasChildImage ? '' : 'Unused [warning]';

Then, what should be the result when hasRunningContainer XOR hasChildImage? I think that ORing them would make it difficult to understand.
My suggestion is to explicitly tell that an image is being used by a container, and mark it as Unused only when it can be directly removed (without -f). For example:

hasRunningContainer
hasChildImage
Label

no
no
Unused

no
yes
None

yes
no
Running [info]

yes
yes
Running [warning]

I think that the goal here is to differentiate which image are used by containers and which one are not. I'd rather have a single 'Unused' label to avoid cluttering the UI. Maybe the 'Unused' tag should not be associated to images that have children tho, even if they are not used by any containers.

Maybe the 'Unused' tag should not be associated to images that have children tho, even if they are not used by any containers.

Then, the tag won't be useful to know which images are used by containers and which are not:

hasRunningContainer
hasChildImage
Label

no
no
Unused

no
yes
None

yes
no
None

yes
yes
None

I like this approach, since it is what 'unused' really means (not used at all). However, that would break the feature for those who don't mind child images and want to focus on running containers.
That's the point that made me suggest to use a single button but with two different labels (text).

However, that would break the feature for those who don't mind child images and want to focus on running containers.
I do think that the most interesting part of this feature for our users is to be able to isolate images that are not associated to any containers.
The fact that the image got children should not be related to the Unused label IMO, so we might want to update this view to give details about what the Unused label really means.

As an addition to this, portainer also marks images used by a hidden container as Unused.
I'm running a lot of containers but don't want to see the portainer container, so I set it to hidden (in the settings, with a label), but that doesn't mean the image is unused.

when i try to remove Unused docker images got the below
2017/10/18 02:31:27 http: panic serving <IP_ADDRESS>:33078: interface conversion: interface {} is map[string]interface {}, not []interface {}
goroutine 44 [running]:
net/http.(*conn).serve.func1(0xc420276140)
/usr/local/go/src/net/http/server.go:1721 +0xd0
panic(0x9cace0, 0xc4202f2d80)
/usr/local/go/src/runtime/panic.go:489 +0x2cf
github.com/portainer/portainer/http/proxy.getResponseAsJSONArray(0xc420385a70, 0x0, 0x0, 0x0, 0x8000101, 0x0)
/go/src/github.com/portainer/portainer/http/proxy/response.go:42 +0xa4
github.com/portainer/portainer/http/proxy.serviceListOperation(0xc420467500, 0xc420385a70, 0xc42036ca80, 0x0, 0x0)
/go/src/github.com/portainer/portainer/http/proxy/services.go:22 +0x32
github.com/portainer/portainer/http/proxy.(*proxyTransport).executeRequestAndRewriteResponse(0xc420130240, 0xc420467500, 0xa9a1e0, 0xc42036ca80, 0x0, 0xec0000c420033630, 0xc420050400)
/go/src/github.com/portainer/portainer/http/proxy/transport.go:289 +0x8d
github.com/portainer/portainer/http/proxy.(*proxyTransport).rewriteOperation(0xc420130240, 0xc420467500, 0xa9a1e0, 0x9, 0x1, 0x997960)
/go/src/github.com/portainer/portainer/http/proxy/transport.go:280 +0xca
github.com/portainer/portainer/http/proxy.(*proxyTransport).proxyServiceRequest(0xc420130240, 0xc420467500, 0xa78909, 0x9, 0xc4202f7301)
/go/src/github.com/portainer/portainer/http/proxy/transport.go:102 +0x33c
github.com/portainer/portainer/http/proxy.(*proxyTransport).proxyDockerRequest(0xc420130240, 0xc420467500, 0xf, 0xc42028ca80, 0xe)
/go/src/github.com/portainer/portainer/http/proxy/transport.go:47 +0x3fa
github.com/portainer/portainer/http/proxy.(*proxyTransport).RoundTrip(0xc420130240, 0xc420467500, 0xf, 0xc42028ca80, 0xe)
/go/src/github.com/portainer/portainer/http/proxy/transport.go:33 +0x35
net/http/httputil.(*ReverseProxy).ServeHTTP(0xc420130200, 0xd4e5c0, 0xc420376c40, 0xc420467300)
/usr/local/go/src/net/http/httputil/reverseproxy.go:205 +0x3ce
net/http.StripPrefix.func1(0xd4e5c0, 0xc420376c40, 0xc420467300)
/usr/local/go/src/net/http/server.go:1977 +0xcf
net/http.HandlerFunc.ServeHTTP(0xc42023a660, 0xd4e5c0, 0xc420376c40, 0xc420467300)
/usr/local/go/src/net/http/server.go:1942 +0x44
github.com/portainer/portainer/http/handler.(*DockerHandler).proxyRequestsToDockerAPI(0xc42028e480, 0xd4e5c0, 0xc420376c40, 0xc420467300)
/go/src/github.com/portainer/portainer/http/handler/docker.go:93 +0x243
github.com/portainer/portainer/http/handler.(*DockerHandler).(github.com/portainer/portainer/http/handler.proxyRequestsToDockerAPI)-fm(0xd4e5c0, 0xc420376c40, 0xc420467300)
/go/src/github.com/portainer/portainer/http/handler/docker.go:34 +0x48
net/http.HandlerFunc.ServeHTTP(0xc420289220, 0xd4e5c0, 0xc420376c40, 0xc420467300)
/usr/local/go/src/net/http/server.go:1942 +0x44
github.com/portainer/portainer/http/security.(*RequestBouncer).mwCheckAuthentication.func1(0xd4e5c0, 0xc420376c40, 0xc420467200)
/go/src/github.com/portainer/portainer/http/security/bouncer.go:146 +0xf4
net/http.HandlerFunc.ServeHTTP(0xc42028c9a0, 0xd4e5c0, 0xc420376c40, 0xc420467200)
/usr/local/go/src/net/http/server.go:1942 +0x44
github.com/portainer/portainer/http/security.mwSecureHeaders.func1(0xd4e5c0, 0xc420376c40, 0xc420467200)
/go/src/github.com/portainer/portainer/http/security/bouncer.go:76 +0xfd
net/http.HandlerFunc.ServeHTTP(0xc42028c9c0, 0xd4e5c0, 0xc420376c40, 0xc420467200)
/usr/local/go/src/net/http/server.go:1942 +0x44
github.com/gorilla/mux.(*Router).ServeHTTP(0xc42029e000, 0xd4e5c0, 0xc420376c40, 0xc420467200)
/go/src/github.com/gorilla/mux/mux.go:133 +0x101
net/http.StripPrefix.func1(0xd4e5c0, 0xc420376c40, 0xc4204c4600)
/usr/local/go/src/net/http/server.go:1977 +0xcf
net/http.HandlerFunc.ServeHTTP(0xc42023a3c0, 0xd4e5c0, 0xc420376c40, 0xc4204c4600)
/usr/local/go/src/net/http/server.go:1942 +0x44
github.com/portainer/portainer/http/handler.(*Handler).ServeHTTP(0xc4202e0580, 0xd4e5c0, 0xc420376c40, 0xc4204c4600)
/go/src/github.com/portainer/portainer/http/handler/handler.go:52 +0x925
net/http.serverHandler.ServeHTTP(0xc4200cf290, 0xd4e5c0, 0xc420376c40, 0xc4204c4600)
/usr/local/go/src/net/http/server.go:2568 +0x92
net/http.(*conn).serve(0xc420276140, 0xd4ef80, 0xc42028e700)
/usr/local/go/src/net/http/server.go:1825 +0x612
created by net/http.(*Server).Serve
/usr/local/go/src/net/http/server.go:2668 +0x2ce

@zwx168238 could you give me reproduction steps? I'm unable to reproduce this. Do you have any error message in app?
I believe the error message that you see in the logs is not related to images, but to services...

the error message in app is "Failure Unable to  remove image"

Reproduction:
docker run --name tmp -t alpine:3.4 sh -c "apk add -U --no-cache wget"
docker commit tmp alpine:3.4
docker rm -f tmp

In my experience, images are wrongly marked as Unsed when logged with a user that has no access privileges to the container running that image.
If the user tries to delete it, it fails saying that some container (the user can't see) is using it


save slurp file after a snapshot is created

Otherwise, we won't have this snapshot in the list of snapshots in the
slurp file, and we'll miss it.
Signed-off-by: Tycho Andersen<EMAIL_ADDRESS>

jenkins: test this please


doc: fix release date in CHANGELOG

Coverage remained the same at 100.0% when pulling 22942cd66118519d816891f1c751a2df07d17cbc on urish-patch-1 into 165d7ba88411278dcb2204a59da790fe034a14d7 on master.


Change environment settings (deploy_path) on the fly

Q
A

Issue Type
Question

Deployer Version
3.3.0

Local Machine OS
OS X 10.11.6

Remote Machine OS
Ubuntu 16.04

Description
I try to use a deploy all task to deploy multiple projects into different target folder on webserver.
/var/www
  - PROJECT
  - OTHER_PROJECT

First deployment works fine, but next deployment tries to use same release_path as previous project
Steps to reproduce
Content of deploy.php
task('set-project1-settings', function () {
    set('repository', 'MY_GIT_REPO');
    \Deployer\Task\Context::get()->getEnvironment()->set('deploy_path', '/var/www/PROJECT');
});

task('deploy-project1', [
    'set-project1-settings',
    'deploy'
]);

task('set-project2-settings', function () {
    set('repository', 'MY_OTHER_GIT_REPO');
    \Deployer\Task\Context::get()->getEnvironment()->set('deploy_path', '/var/www/OTHER_PROJECT');
});

task('deploy-project2', [
    'set-project2-settings',
    'deploy'
]);

task('deploy-all', [
    'deploy-project1',
    'deploy-project2'
]);

Output log
➤ Executing task deploy:release
↳ on [dev]
> if [ -d /var/www/deployer-test/OTHER_PROJECT/releases/20161012124120 ]; then echo 'true'; fi
> mkdir /var/www/deployer-test/OTHER_PROJECT/releases/20161012124120
> cd /var/www/deployer-test/OTHER_PROJECT && if [ -h release ]; then rm release; fi
> ln -s /var/www/deployer-test/OTHER_PROJECT/releases/20161012124120 /var/www/deployer-test/OTHER_PROJECT/release
• done on [dev]
✔ Ok [457ms]
➤ Executing task deploy:update_code
↳ on [dev]
> /usr/bin/git clone -b master --recursive -q --reference /var/www/deployer-test/OTHER_PROJECT/releases/20161012123128 --dissociate git@bitbucket.org:kkrieger/OTHER_PROJECT.git  /var/www/deployer-test/PROJECT/releases/20161012124120 2>&1
> /usr/bin/git clone -b master --recursive -q git@bitbucket.org:kkrieger/OTHER_PROJECT.git /var/www/deployer-test/PROJECT/releases/20161012124120 2>&1

  [RuntimeException]
  fatal: destination path '/var/www/deployer-test/PROJECT/releases/20161012124120' already exists and is not an empty directory.

More Output log:
➤ Executing task deploy:release
↳ on [dev]
> if [ -d /var/www/deployer-test/OTHER_PROJECT/releases/20161012124120 ]; then echo 'true'; fi
> mkdir /var/www/deployer-test/OTHER_PROJECT/releases/20161012124120
> cd /var/www/deployer-test/OTHER_PROJECT && if [ -h release ]; then rm release; fi
> ln -s /var/www/deployer-test/OTHER_PROJECT/releases/20161012124120 /var/www/deployer-test/OTHER_PROJECT/release
• done on [dev]
✔ Ok [457ms]

In deploy:release, there were used right folders

It seems that in https://github.com/deployphp/deployer/blob/master/recipe/common.php#L206
{{release_path}} is not correct:
Code:
try {
            run("$git clone $at --recursive -q --reference {{deploy_path}}/releases/{$releases[1]} --dissociate $repository  {{release_path}} 2>&1");
        } catch (RuntimeException $exc) {
            // If {{deploy_path}}/releases/{$releases[1]} has a failed git clone, is empty, shallow etc, git would throw error and give up. So we're forcing it to act without reference in this situation
            run("$git clone $at --recursive -q $repository {{release_path}} 2>&1");
        }

{{deploy_path}}/releases/{$releases[1]} is correct to /var/www/deployer-test/OTHER_PROJECT/releases/20161012123128
{{release_path}}is wrong: /var/www/deployer-test/PROJECT/releases/20161012124120

Create separate deploy.php files for each project. And do not modify params with set in task during execution. I will add runtime exception for this case in v4.


Plugin defines cargo dependencies to be implicit dependencies

Here is a project graph:

As you can see all dependencies declared in apps/esteem/Cargo.toml are added as implicit dependencies. By definition, only in-workspace projects qualify as implicitDependencies.So in the above example only esteem_core should be display in the graph.
I could not find any specific documentation for this, but you can test it easily by adding a random name to your project.json.
As an example:

And here is the output of build

The fix is pretty easy, and I am willing to make a PR for the same.

I will make a PR for this once #21 is merged to prevent merge conflicts.

@IgnisDa I wrote this plugin which solves the above problem. You can install it from NPM https://www.npmjs.com/package/@ignisda/nx-rust.

This is fixed now — I was trying to emulate what Nx does with its own tracking of npm dependencies for JavaScript projects, but the way I was going about it was kind of a hack and probably not actually very useful.
External dependency tracking will be fixed properly once this plugin upgrades to Nx v19.x, but that won't happen until I can validate that the new Nx version doesn't cause any issues with my main project that's consuming this plugin.