Vector3 - perpendicular

3.2.2
Issue description:
Have a Vector3, would like to get a vector perpendicular to it.
For my application I want to draw a tube around a vector:

Using v1, find perpendicular vector (v2)
Normalize v2, the resize to desired radius
Rotate v2 around v1.normalized() to get an array of vectors
Construct tube using these

Also could be nice for orbiting particles, spiraling particles, etc
https://stackoverflow.com/questions/11132681/what-is-a-formula-to-get-a-vector-perpendicular-to-another-vector

Are you looking for Vector3.cross()?

Cross product is something different. I'm not asking for help I'm sugesting an enhancement.

Sorry I guess my comment - this was what the perpendicular vector would be used for in real life - I have used it to create a tube that has my vector in the center.

@monk-e-boy Please open feature proposals on Godot proposals. Note that core features that aren't going to be used very often are unlikely to be accepted.


Does Kata-conatiner support aufs/overlay filesystem?

Description of problem
I run a kata-container and install docker inside it , found that default filesystem in docker is vfs, which is slow and want to use aufs/overlay
Expected result
Support aufs/overlay
Actual result
root@c43d1b58e8e1:/# docker info
Client:
 Debug Mode: false

Server:
 Containers: 0
  Running: 0
  Paused: 0
  Stopped: 0
 Images: 0
 Server Version: 19.03.6
 Storage Driver: vfs
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: b34a5c8af56e510852c35414db4c1f4fa6172339
 runc version: 3e425f80a8c931f88e6d94a8c831b9d5aa481657
 init version: fec3683
 Security Options:
  seccomp
   Profile: default
 Kernel Version: 4.19.75-44.container
 Operating System: Ubuntu 18.04.3 LTS (containerized)
 OSType: linux
 Architecture: x86_64
 CPUs: 1
 Total Memory: 1.95GiB
 Name: c43d1b58e8e1
 ID: UCXF:FA7D:VQKK:QPBW:2SIZ:TPHB:FWMZ:ODY3:AWEE:5GVB:HX2R:XDPE
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

When I change it to overlay by setting daemon.json to
{
  "storage-driver": "overlay2"
}

the docker error is
time="2020-02-24T06:48:29.687283268Z" level=error msg="'overlay2' is not supported over overlayfs" storage-driver=overlay2
time="2020-02-24T06:48:29.692526734Z" level=info msg="stopping event stream following graceful shutdown" error="context canceled" module=libcontainerd namespace=plugins.moby
time="2020-02-24T06:48:29.692853627Z" level=info msg="stopping healthcheck following graceful shutdown" module=libcontainerd
failed to start daemon: error initializing graphdriver: backing file system is unsupported for this graph driver

To be clear then, you are running docker inside a Kata container :-)
Looking at our kernel config (fragments), it looks like OVERLAY is enabled, specifically to allow docker to run:
https://github.com/kata-containers/packaging/blob/master/kernel/configs/fragments/common/fs.conf#L48
That code was added over on this PR, which might be worth a read:
https://github.com/kata-containers/packaging/pull/716
@egernst - do you know the current state of running Docker inside Kata?

@grahamwhaley  Hi, I had ready tried overlay before and still got the error. Just paste the overlay2 for bug report. Wait me update the storage driver.

root@bde3fec11d66:/# cat /etc/docker/daemon.json
{
  "storage-driver": "overlay"
}
root@bde3fec11d66:/# service docker start
 * Starting Docker: docker                                                                          [ OK ]
root@bde3fec11d66:/# docker info
Client:
 Debug Mode: false

Server:
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
errors pretty printing info

And the error is failed to start daemon: error initializing graphdriver: backing file system is unsupported for this graph driver
Full docker log is:
time="2020-02-24T10:38:57.875084586Z" level=info msg="containerd successfully booted in 0.064627s"
time="2020-02-24T10:38:57.912231782Z" level=warning msg="unable to modify root key limit, number of containers could be limited by this quota: open /proc/sys/kernel/keys/root_maxkeys: no such file or directory"
time="2020-02-24T10:38:57.927444606Z" level=info msg="parsed scheme: \"unix\"" module=grpc
time="2020-02-24T10:38:57.927794591Z" level=info msg="scheme \"unix\" not registered, fallback to default scheme" module=grpc
time="2020-02-24T10:38:57.927990871Z" level=info msg="ccResolverWrapper: sending update to cc: {[{unix:///var/run/docker/containerd/containerd.sock 0  <nil>}] <nil>}" module=grpc
time="2020-02-24T10:38:57.928522377Z" level=info msg="ClientConn switching balancer to \"pick_first\"" module=grpc
time="2020-02-24T10:38:57.934537817Z" level=info msg="parsed scheme: \"unix\"" module=grpc
time="2020-02-24T10:38:57.934648967Z" level=info msg="scheme \"unix\" not registered, fallback to default scheme" module=grpc
time="2020-02-24T10:38:57.934786659Z" level=info msg="ccResolverWrapper: sending update to cc: {[{unix:///var/run/docker/containerd/containerd.sock 0  <nil>}] <nil>}" module=grpc
time="2020-02-24T10:38:57.934895038Z" level=info msg="ClientConn switching balancer to \"pick_first\"" module=grpc
time="2020-02-24T10:38:57.947041899Z" level=warning msg="[graphdriver] WARNING: the overlay storage-driver is deprecated, and will be removed in a future release"
time="2020-02-24T10:38:57.950995568Z" level=error msg="'overlay' is not supported over overlayfs" storage-driver=overlay
time="2020-02-24T10:38:57.955319706Z" level=info msg="stopping event stream following graceful shutdown" error="context canceled" module=libcontainerd namespace=plugins.moby
time="2020-02-24T10:38:57.955835037Z" level=info msg="stopping healthcheck following graceful shutdown" module=libcontainerd
failed to start daemon: error initializing graphdriver: backing file system is unsupported for this graph driver

I wish we really did have DinK (Docker-In-Kata) documented - we have an Issue open for it, with some useful discussion (you may wish to reference if you did not already @YongHaoWu ) over at https://github.com/kata-containers/runtime/issues/1429#issuecomment-477385283
Any takers for making a formal markdown doc for this in the Kata docs repo?

@gabibeyer  Seems #1429 (comment) is just mount kata container's host's /var/run to the kata container, which is not perfect as containers all share the same /var/run.

@YongHaoWu We had added support for overlay as far as I remember, let me try to reproduce your issue.
@grahamwhaley Agree we need docs for DinK, I suppose I can work on that since I will be taking a look at this issue.

@amshinde hi, any feedback? Can u reproduce the issue? thanks.

The issue you're seeing is running overlay on top of virtio-fs.  We are working to add support for this, but today there is a limitation in the checking that is done by the overlayfs driver.

@egernst Hi, how can I ensure that I was running on top of virtio-fs?
I did run kata container on VM, does it matter?

It depends on how you have setup your snapshotter/graph driver (if you are using overlayfs, for example, for docker/CRI), and then it depends on your Kata configuration.toml.
See https://github.com/kata-containers/runtime/blob/master/cli/config/configuration-qemu.toml.in#L106-L109 for the toml setting I am referring to.

@egernst Hi, I had checked my configure file and it just used the default value virtio-9p of shared_fs. So is virtio-9p had the same issue as virtio-fs?

@egernst  @amshinde  Hi, sry to bother u. Any resp?

@YongHaoWu yes virtio-9p fails the same reason as virtio-fs -- they cannot be used as overlayfs top layers. There is ongoing work in upstream kernel community to make it work for virtio-fs but it requires some time to be there.

@YongHaoWu Any chance if you can give https://github.com/kata-containers/runtime/issues/1429#issuecomment-477385283 a try? It puts guest /var/run to guest memory tmpfs and should fix the issue. Nothing is mounted on the host.

@bergwolf  Aah, sry for my misunderstanding. I don't quite know the method @grahamwhaley  provide before.
#1429 (comment)   seems a beautiful solution. Thanks.
Will try later.

@bergwolf  Thanks, it works.
root@localhost:~# docker run  --privileged     --mount type=tmpfs,destination=/var/lib/docker,tmpfs-mode=1770     -it --memory 5g --cpus 8  harbor.shopeemobile.com/cloud/virtualdev:ubuntu1604

root@c3408a616395:/#
root@c3408a616395:/# service docker start
 * Starting Docker: docker                                                                                [ OK ]
root@c3408a616395:/# docker info
Client:
 Debug Mode: false

Server:
 Containers: 0
  Running: 0
  Paused: 0
  Stopped: 0
 Images: 0
 Server Version: 19.03.6
 Storage Driver: overlay2
  Backing Filesystem: tmpfs
  Supports d_type: true
  Native Overlay Diff: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 35bd7a5f69c13e1563af8a93431411cd9ecf5021
 runc version: dc9208a3303feef5b3839f4323d9beb36df0a9dd
 init version: fec3683
 Security Options:
  seccomp
   Profile: default
 Kernel Version: 5.4.15-45.container
 Operating System: Ubuntu 16.04.6 LTS (containerized)
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 6.95GiB
 Name: c3408a616395
 ID: Z5IL:N2FW:36UX:XKAH:D72O:ZQVC:AAQN:LWT6:ME2H:JRMU:RA7B:RUBD
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false

WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
root@c3408a616395:/# docker run hello-world
Unable to find image 'hello-world:latest' locally
latest: Pulling from library/hello-world
1b930d010525: Pull complete
Digest: sha256:f9dfddf63636d84ef479d645ab5885156ae030f611a56f3a7ac7f2fdd86d7e4e
Status: Downloaded newer image for hello-world:latest

Hello from Docker!
This message shows that your installation appears to be working correctly.

To generate this message, Docker took the following steps:
 1. The Docker client contacted the Docker daemon.
 2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
    (amd64)
 3. The Docker daemon created a new container from that image which runs the
    executable that produces the output you are currently reading.
 4. The Docker daemon streamed that output to the Docker client, which sent it
    to your terminal.

To try something more ambitious, you can run an Ubuntu container with:
 $ docker run -it ubuntu bash

Share images, automate workflows, and more with a free Docker ID:
 https://hub.docker.com/

For more examples and ideas, visit:
 https://docs.docker.com/get-started/

root@c3408a616395:/# docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
root@c3408a616395:/# docker ps -a
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS                      PORTS               NAMES
ef62f7872b6d        hello-world         "/hello"            13 seconds ago      Exited (0) 11 seconds ago                       peaceful_tesla

@bergwolf @grahamwhaley  But mount /var/lib/docker as a tmpfs filesystem has a issue, if the container was restarted, all the docker container data were lost.
Any good idea to solve this?

@YongHaoWu If you want to restart containers, you need something persistent to store the data. Maybe you can try to add a block device to your container and mount it to /var/lib/docker in your init script inside the DinD container, with the --device option.

@bergwolf  I do use this method in runc container before. Just wonder whether there are better methods in Kata runtime. Thanks.

Given that we have a workaround and nothing to fix we are closing this issue.

Given that we have a workaround and nothing to fix we are closing this issue.

Hi, I think the workaround is not the good solution for this issue.
It would be better that u can implement this in kata-container.

I also don't think that the workaround is a good solution. In my opinion this should be reopened.


confusion about how to calculate the credit per hour;

[Enter feedback here]
based on the example it provided, for a B16 with 16 CPU, to use 80% vCPU for a hour, it would require 606 credit, however, based on the formula:
1 Credits accumulated/credits used in an hour is equivalent to: ((Base CPU perf of VM - CPU Usage) / 100) * 60 minutes.
( (270% - 80% x 16 ) /100 ) * 60 = -6.06
it's either the formula is wrong with "/" instead it should be "x 100", or the example is giving the wrong figure. Please let me know if my understanding is not correct. Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0cd2e24b-0fd3-d698-2840-3f8206933026
Version Independent ID: 832dc371-480a-c74a-e956-e1904473af31
Content: B-series burstable - Azure Virtual Machines
Content Source: articles/virtual-machines/sizes-b-series-burstable.md
Service: virtual-machines
Sub-service: sizes
GitHub Login: @rishabv90
Microsoft Alias: risverma

@daisygithuba
Thanks for your feedback! We will investigate and update as appropriate.

@iamwilliew Can you work with the sizes team to double check the math for the B-series?

@rishabv90
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

@rishabv90
Can you please check and add your comments on this doc update request as applicable.

Do we have any update on this?

@rishabv90 is there any update on the calculations issue?

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing, so we've created an internal work item to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary. #please-close


Update docs on how to add a new UI page

Looks good! Love that you went through both legacy React and React hooks way of handling state. Nice work.  Might it be worth using langstrings in the examples?

Yeah i think i'll merge this first, it's something that needs to be documented at some point though


Added New Annealing Solver Type for Discrete Optimization Problems: sa_disc_type

The existing OpenFSAM is very powerful and can solve many different kinds of optimization problems, but one class of problems seems to have been left out: discrete optimization problems! (Finding the ground state of the Ising model, the Quadratic Unconstrained Binary Optimization problem, MAX-2-SAT, etc.) To address this, I've written a new annealing type called sa_disc_type to be used for such problems.
The sa_disc_type extends sa_type_base and adds a few important object properties:

var_values: An array that allows the end user to specify the domain for their discrete objective function
num_perturb: Borrowed from the sa_cont_type, it specifies the number of parameters to perturb when seeking a new neighbouring state. Defaults to only changing one parameter at a time.

The new function get_neigh_disc finds a new neighbouring state by perturbing num_perturb parameters of the energy function. (It is flexible enough to allow for any number of possible domain values, not just functions with binary parameters.)
To complement this additional type, I've added an example that initializes and optimizes the Ising model.
The README has also been updated to accommodate the new type.
Side Note
Note that the sa_comb_type can technically be used to solve these discrete optimization problems, but the implementation is rather ugly. It requires setting an initial state which contains as many values as there are distinct values in the domain. (In the case of a problem with n binary parameters, this means 2n values.) Then, in the energy function, only the first n values must be used when calculating the performance of the given state. This technique comes with the additional downside that only one parameter can be perturbed in each iteration.

Nice! This is actually something I had setup to do using the sa_cont_type and binding ranges of reals to certain continuous values in the energy function. But this is much cleaner and easier to setup. Looks good! Thanks!


rename to adafruit_ble_radio?

I'm thinking maybe we should rename the repo and the library to adafruit_ble_radio from adafruit_radio, to indicate the transport technology?

@tannewt Could you comment on this, because if we do rename the library, we should do it sooner rather than later.

I'm game to rename. It'll better future proof it. Want me to?

Sure, thank you! So repo name, short name, example filenames, and the bundle (if it's in the bundle yet).

Done.


ThenInclude Method not found

The issue
After upgrade to 1.1.0. Run  Query to load navigation property then got  the error as below.
Code
   var all = db.Category.Include(c => c.CategoryPics).ThenInclude(p => p.Picture);
       var result = all.ToList();

Error
MissingMethodException: Method not found: 'Microsoft.EntityFrameworkCore.Query.IIncludableQueryable`2<!!0,!!2>
Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ThenInclude(Microsoft.EntityFrameworkCore.Query.IIncludableQueryable`2<!!0,System.Collections.Generic.ICollection`1<!!1>>, System.Linq.Expressions.Expression`1<System.Func`2<!!1,!!2>>)'.

Further technical details
EF Core version: 1.1.0
Operating system:
Visual Studio version: VS 2015 Update 3
Other details about my project setup:

Sorry~~
Please close this issue.This issue is my library project are forgot upgrade and still stay on 1.0.0.

I just ran into this issue.
I have a ASP.NET Core 1.0 host app that references a library (netstandard14). The library references EF Core 1.0. The library has no SqlServer dependencies (just uses a DbContext). The host puts the DbContext in DI and configures SqlServer as the provider.
I then update the host app to ASP.NET Core 1.1 (and EF Core 1.1 and SqlServer 1.1), but still rely upon the same library that depends on EF Core 1.0. I run my code and now get this exception:
MissingMethodException: Method not found: 'Microsoft.EntityFrameworkCore.Query.IIncludableQueryable`2<!!0,!!2> Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ThenInclude(Microsoft.EntityFrameworkCore.Query.IIncludableQueryable`2<!!0,System.Collections.Generic.ICollection`1<!!1>>, System.Linq.Expressions.Expression`1<System.Func`2<!!1,!!2>>)'.
IdentityServer4.EntityFramework.Stores.ResourceStore.GetAllResources()
IdentityServer4.Stores.IResourceStoreExtensions+<GetAllEnabledResourcesAsync>d__2.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
IdentityServer4.Endpoints.DiscoveryEndpoint+<ExecuteDiscoDocAsync>d__9.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
IdentityServer4.Hosting.IdentityServerMiddleware+<Invoke>d__3.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
IdentityServer4.Hosting.FederatedSignOutMiddleware+<Invoke>d__6.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
IdentityServer4.Hosting.AuthenticationMiddleware+<Invoke>d__2.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware+<Invoke>d__18.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware+<Invoke>d__18.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNetCore.Cors.Infrastructure.CorsMiddleware+<Invoke>d__7.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
IdentityServer4.Hosting.BaseUrlMiddleware+<Invoke>d__2.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware+<Invoke>d__7.MoveNext()

As an experiment I then  updated the library to EF 1.1 and it all worked. This leads me to believe there was a binary and thus breaking change in EF 1.1.

Re-opening to discuss in triage. This is a known binary breaking change; we may consider fixing it in a patch release.

I was informed today that .NET Core and ASP.NET Core (and then presumably EF Core) are not following semantic versioning across the LTS and current release paths. Thus this issue could be closed as updates are not expected to binary compatible. I'd ask you to confirm that internally if what I was told matches your expectations. The worst case scenario would be that some libraries/projects from Microsoft decide to do semver and others do not.

I have also just hit this issue, however I am only trying to go from 1.0.0 to 1.0.1..

@brockallen That's incorrect. We do follow semantic versions and any binary breaking changes we make between 2 versions that are supposed to be compatible is a mistake and should be fixed.

So I misread the email -- 1.0 to 1.1 was not meant to be semver, but 1.1 and beyond is. Is that closer to accurate?

fyi I have had good success with this library for performing automated checks of your public API, to detect breaking changes. Might be worth considering: https://github.com/JakeGinnivan/ApiApprover

Agreed, we will look at making this binary compatible in a patch

So I misread the email -- 1.0 to 1.1 was not meant to be semver, but 1.1 and beyond is. Is that closer to accurate?

Major versions, not point releases or patches of those point releases. So 1.1 will be compatible with 1.2 etc. Up until the next major. The only places this doesn't apply are inside of the .Internal namespaces.

This is fixed and merged. Leaving the bug open for patch approval.

Justification: Assemblies compiled against 1.0 assembly will throw when using 1.1 assembly unless they are re-built.
Risk: Low--Adding back in the API that was removed; functionality is unchanged.

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.


Adding Machine Learning Algorithms

Hi,
I added machine_learning directory, as it was not present.
Notes that you care about

[x] Added machine learning directory
[x] Added linear_regression algorithm

Thank you

Hello, Thanks for reviewing.
Sorry, but I am not able to get the suggestion you made. Is it the "full report at Codecov" you suggested.
Thank you

Hello, Thanks for reviewing. Sorry, but I am not able to get the suggestion you made. Is it the "full report at Codecov" you suggested. Thank you

I did it for you since it is just a minor change in documentation. No need to add tests too since these are ml algorithms. it should be good then

@Navaneeth-Sharma Thanks for the contribution! :D

Thank you @uncomfyhalomacro for merging and for the support.
I will try to contribute more to this repository.  :)


Put example

Could you add an example of how to build a message with the put procedure? All the tests use the previous get and I'm trying to build a message without success.
The first problem I get into is the deprecation of typeGetter. How may I use the type directly?
If I use typeGetter nevertheless I get a segmentation fault when I try to set the values:
import binarylang

struct(hello):
  8: *first

proc main() =
  var data: typeGetter(hello)
  data.first = 3
  var stout = newStringBitStream()
  hello.put(stout, data)

main()

First of all, instead of typeGetter(hello), simply use Hello (name of parser capitalized). Also, the convenient procs toHello and fromHello are generated. Lastly, you are getting segmentation fault because your data object is not initialized, so when you do data.first = 3 your are trying to access the field first, but data is nil.

Thanks for the quick response! I knew I was doing something wrong and even saw the warning over the typeGetter but could not find an example usage
Using the parser name capitalized work perfectly:
var data = Hello()
data.first = 3

with typeGetter it would be:
 var data: typeGetter(hello)()

to contruct an object

I think the reason I was using it incorrectly is that I started using binaryparse before changing to binarylang.
Thank you for this excellent library


feat: better lint rules

🛠 Fixes Issue
Closes #112
👨💻 Changes proposed

Removed all eslint-disables
Added more linting rules
Applied new lint rules to files
Added types/unknown where-ever necessary

🔧 Check List (Check the type of issue it fixes)

[x] Bug Fix
[ ] New Extension
[x] Enhancement
[ ] Documentation

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules
[x] I have done git pull before adding my new changes
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
📷 Screenshots

Can you resolve the merge conflicts


replace imgui with nuklear

Pros:
single header lib in C
Cons:
lacks some features (?)

I think functionality-wise, imgui is considerably superior.  Though imgui is really just a debugging GUI library, while nuklear seems more viable for game GUI's.
I was planning on removing imgui or at the very least making it option as I dislike depending on a c++ compiler.  I might add in nuklear as an extra optional thing somewhere down the line so keep this issue open until then.


Array to string conversion error using form field name 'dates'

I have a textarea form field using the name 'dates' set up this way;
{!! Form::textarea('dates', isset($notes->dates) ? $notes->dates : null,                                          ['class' => 'form-control', 'rows' => '1']) !!}
When $notes->dates has a value it works fine. When $notes->dates is not set Laravel generates an array to string conversion error in the form builder.
If I change the code to isset($notes->dates) ? $notes->dates : '', it does not generate an error if $notes->dates is not set.
I'm using the latter in my code so I'm good to go but thought I should report this just in case it's not due to my own ignorance.

We don't have a form class in 5.1.+.


Option: look for @prettier annotation before applying format-on-save

I'd like to propose a new option for prettier-vscode.
eslint-plugin-prettier supports a pragma comment.  This comment tells eslint which files to apply prettier formatting rules to.  This is a great affordance for incremental adoption in large codebases.
It would be great if format-on-save functionality could match this behaviour and respect a pragma comment.
Option would look something like:
  // If set, prettier will only apply formatting rules to files with this pragma in the heading docblock.
  "prettier.pragma": "@prettier",

IMO this is a good idea but not in this extension. It would be better in prettier itself.
Why only when formatOnSave?

formatOnSave is the most problematic experience, that's just where I'm coming from.
Prettier supports formatting of selections as well as entire files, which I'm surmising could make it awkward to support handling of a pragma comment.
That said, I'm happy with any solution that achieves this effect.

I have posted an issue against prettier, to start a discussion: https://github.com/prettier/prettier/issues/2397

Closing it here as it is discussed in prettier.

Even if it is resolved in prettier itself, prettier-vscode will need to add support,  I guess we can open a separate issue at such time?

If we need to.
Currently, I think prettier will simply return the original text if it encounters such a pragma. In that case, we won't need to do anything.

It sounds like it's most likely to be implemented as a command line flag, so it would just be a matter of supporting a new option and translating it to the command-line flag, I expect.
Thanks for coordinating on this. 👍

Seems my last comment was the opposite of what it should be.
We will certainly need to have an option to only run on pragma files. So yes an issue or a PR (referencing this) at that time would make sens.

Prettier now supports this. Can we reopen this issue, or create another?


GhostBSD official release for Pi5

Describe the feature or enhancement
Official porting of Ghost in ARM64.
Why this request?
Because I am a beginner user that needs of a privacy oriented OS with powerful feature (running on FreeBSD).
I have not the skills to use command line. I need of FreeBSD with GUI.

It is a work in progress, but we lack the hardware to build an entire package repository.


Asterisk 13 relevant changes and things already merged to 1.1 branch

So this is what I have at the moment -

Restructured ParkEvents and HoldEvents to better comply with Asterisk 12 AMI Spec
Removed properties and getters/setters that unnecessarily overrode ManagerEvent (don't think I caught them all, yet, though)
Backward compatibility for DialBeginEvents by building fake legacy DialEvent
Small NullPointer fix in MeetMeManager
Plus the changes that were already included in the 1.1 release branch.

Do let me know if you have any questions...

OK, thanks for the submission. Looks pretty good except that the formatting is a bit wobbly.
Can you reformat the code to bring it in line with rest of the AJ code formatting.
Once done please resubmit your pull request and we will merge the code.
Brett

Ok, I've been able to setup the project code template in my IDE now (sorry for not having done that in the first place) and applied it to the changed classes. I hope this is what you had in mind.
I also added a fix for a small issue I came across in the mean time which led to MeetMeEvents not processing correctly in Asterisk 13.
Do let me know if further work on the formatting is needed...

yes importing the code template into eclipse is the way to go.
On 20/05/15 17:09, elara-leitstellentechnik wrote:

Ok, I've been able to setup the project code template in my IDE now
(sorry for not having done that in the first place) and applied it to
the changed classes. I hope this is what you had in mind.
I also added a fix for a small issue I came across in the mean time
which led to MeetMeEvents not processing correctly in Asterisk 13.
Do let me know if further work on the formatting is needed...
—
Reply to this email directly or view it on GitHub
https://github.com/asterisk-java/asterisk-java/pull/50#issuecomment-103784046.

--
S. Brett Sutton
Ph: 1300 NOOJEE (1300 666 533)
Noojee Telephony Solutions - On Demand Contact Centres Solutions
www.noojee.com.au


[improve][client] Add backoff for seek

Motivation
Currently, only seek doesn't support backoff in consumer side, see :
https://github.com/apache/pulsar/blob/2ab184e49a036a1dd10dc537bef4ab034a5ad5e0/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L2151-L2166
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #20963 (1f7bdf4) into master (2ab184e) will decrease coverage by 3.80%.
Report is 10 commits behind head on master.
The diff coverage is 53.96%.

@@             Coverage Diff              @@
##             master   #20963      +/-   ##
============================================
- Coverage     37.11%   33.32%   -3.80%
- Complexity    12250    12310      +60
============================================
  Files          1698     1621      -77
  Lines        129813   129555     -258
  Branches      14156    14047     -109
============================================
- Hits          48179    43168    -5011
- Misses        75318    80807    +5489
+ Partials       6316     5580     -736

Flag
Coverage Δ

inttests
24.06% <41.26%> (-0.34%)
:arrow_down:

systests
?

unittests
32.03% <53.96%> (-0.19%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...va/org/apache/pulsar/client/impl/ConsumerImpl.java
55.90% <53.96%> (+0.02%)
:arrow_up:

... and 413 files with indirect coverage changes

Is it possible to add a test to cover the new changes?

Added test.


Run tests for private plugins as well

@lachmanfrantisek
There will be one test failure but I'll fix that one I see it being run here.

Seems there's wrong indentation in the config? The use_internal_tf key should be on the same level as targets?

@psss Lets see. How that https://github.com/oamg/convert2rhel/blob/d6ab73ec534224d5a1eb1aa34640a694fa5d6f9a/.packit.yaml#L48 doesn't contain metadata key at all?

Just a small update, we are sorting this out with packit, why it does not map to the distro as configured ...

@thrix any ETA? We can add just fedora-internal now and extend with rhel-8 in separate PR.

Hi!
Sorry about the troubles with the mapping. packit/packit-service#1599 (merging now) will solve your particular case and packit/packit-service#1612 will solve this in general. (Someone from the team will pick the card soon = ~next/following week.)

With the latest changes everything seems to be green except for /tests/minute/list/{images,flavors}:
The minute API is currently unavailable. Please check your connection or try again later.

Which seem to be caused by the outage.

That is not good. Locally it works. Do you have time to investigate? Since this morning minute plugin is working again (or should be)

Running again, it used hash: 96622c3 but current head for internal tests is newer (1cafbf4)

testing-farm:fedora-36-x86_64:internal — Tests passed
Nice, hooray. @psss
@lachmanfrantisek thanks for the help
@happz @thrix I'd propose to include this in typing branch, WDYT?

Nice! +1 to add to the typing branch. The list of flavors is empty though... but I guess this would be related to the broken infra, right?

That is a bug somewhere. When I run it locally or in tmt-redhat CI those tests pass.

Would be nice to include this into type-annotations-staging so we have results without manual exec.

@happz @thrix I'd like to include this in typing branch, WDYT?

+1 from me, looks like a clear benefit to current storm of patches.


Progress indicator for switching kernels should be displayed next to icon

When switching a kernel we display a progress indicator at the bottom (its a message).
This doesn't feel right. The user has clicked the icon on the top right of VS Code, and a progress indicator is at the bottom.
I believe a better UX is to change the icon the user clicked into a spinner or sorts.
After all, that's where the users focus is, not on the bottom right, but top right of VS Code.

See https://github.com/microsoft/vscode-python/issues/8716

I did change switching kerrnels to make it look like it's busy now, is that enough? Otherwise we need a spinner icon from the design team.

Closing for now. See if anybody else asks for it.


feat(ui-debug): update the view

install and use @mui/x-tree-view instead of the beta version of TreeView
update style
use SplitView
fix data type definition
fix issue with list.txt file displayed like a folder

Probably due to the MUI update you have a type issue in SelectSingle.tsx component (in common). (The issue is coming from the Props interface)


Github logging changes coming in Github Enterprise Server 3.9

<EMAIL_ADDRESS>3.9.0-rc.1: Changes
Field names for some service logs on GitHub Enterprise Server have changed as part of GitHub's gradual migration to internal semantic conventions for OpenTelemetry. Additional field names will change in upcoming releases. If any tooling or processes in your environment rely on specific field names within logs, or log entries in specific files, the following changes may affect you.

level is now SeverityText.
log_message, msg, or message is now Body.
now is now Timestamp.
Custom field names such as gh.repo.id or graphql.operation.name use semantic names.
Log statements that the instance would previously write to auth.log, ldap.log, or ldap-sync.log now appear in containerized logs for github-unicorn if the statement originated from a web request, or in logs for github-resqued if the statement originated from a background job.

For a full list of mappings, download the OpenTelemetry attribute mapping CSV.

@adammike hi, thanks for info. SC4S is not doing any extractions based on affected fields so this release should not affect us. We only assign index, source, sourcetype etc based on the message format.


Laravel 10 support

Please, as soon as possible, provide Laravel 10 support.
 statikbe/laravel-nova-chained-translation-manager[v3.0.0, ..., v3.0.7] require illuminate/validation ^8.0|^9.0 -> found illuminate/validation[v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.0] but these were not loaded, likely because it conflicts with another require.

@ayvazyan10 We have this on our planning, but a pull request is welcome!

you need change only one line of code in composer.json,
this-> "illuminate/validation": "^8.0|^9.0", to this-> "illuminate/support": "^8.0|^9.0|^10.0"


Remote repeated settings override workspace settings

Type: Bug
i have custom setting for clangd extension in my workspace project:
"clangd.arguments": [
            "--clang-tidy",
            "--clang-tidy-checks=*,-llvm*,-fuchsia*,-modernize-use-trailing-return-type",
            "--background-index",
            "--header-insertion=never",
            "--compile-commands-dir=/home/vl-trifonov/misc/compile_commands"
        ]

but starting clangd via extension didn't use this arguments (they were empty):
I[20:30:01.518] clangd version 15.0.6 (https://github.com/llvm/llvm-project 088f33605d8a61ff519c580a71b1dd57d16a03f8)
I[20:30:01.518] Features: linux+grpc
I[20:30:01.518] PID: 570
I[20:30:01.518] Working directory: /home/vl-trifonov/alice-arcadia/arcadia/alice
I[20:30:01.518] argv[0]: /home/vl-trifonov/.vscode-server/data/User/globalStorage/llvm-vs-code-extensions.vscode-clangd/install/15.0.6/clangd_15.0.6/bin/clangd
I[20:30:01.518] Starting LSP over stdin/stdout
...

I've added some test argument in remote settings.json:
"clangd.arguments": [
        "kek"
    ]

Now in clangd output:
[Error - 8:31:14 PM] Clang Language Server client: couldn't create connection to server.
  Message: Pending response rejected since connection got disposed
  Code: -32097
[Error - 8:31:14 PM] Restarting server failed
  Message: Pending response rejected since connection got disposed
  Code: -32097
clangd: Unknown command line argument '--test-arg'.  Try: '/home/vl-trifonov/.vscode-server/data/User/globalStorage/llvm-vs-code-extensions.vscode-clangd/install/15.0.6/clangd_15.0.6/bin/clangd --help'
clangd: Did you mean '--tweaks'?

it seems like overriding of repeated parameters doesn't work right, because workspace settings must override remote ones https://code.visualstudio.com/docs/getstarted/settings#_settings-precedence
VS Code version: Code 1.74.3 (Universal) (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T17:07:18.579Z)
OS version: Darwin arm64 21.6.0
Modes:
Sandboxed: No
Remote OS version: Linux x64 4.19.100-23

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
3, 2, 2

Memory (System)
16.00GB (0.06GB free)

Process Argv
--crash-reporter-id e6183ef3-acca-4e62-a667-a7a261311f77

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: ---

OS
Linux x64 4.19.100-23

CPUs
Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz (64 x 2599)

Memory (System)
107.20GB (104.03GB free)

VM
0%

Extensions (26)

Extension
Author (truncated)
Version

jupyter-keymap
ms-
1.0.0

remote-containers
ms-
0.266.1

remote-ssh
ms-
0.94.0

remote-ssh-edit
ms-
0.84.0

remote-wsl
ms-
0.72.0

vscode-remote-extensionpack
ms-
0.23.0

remote-explorer
ms-
0.0.3

clock
ang
1.0.1

vscode-clangd
llv
0.1.23

isort
ms-
2022.8.0

python
ms-
2022.20.2

vscode-pylance
ms-
2023.1.20

jupyter
ms-
2022.11.1003412109

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.13

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-slideshow
ms-
0.1.5

cpptools
ms-
1.13.9

vs-sequential-number
nep
1.1.0

vscode-yandex-arc
per
0.158.0

html-preview-vscode
tht
0.2.5

shellcheck
tim
0.29.3

sort-lines
Tyr
1.9.1

vscode-terminal-here
Tyr
0.2.4

prettify-selected-json
vth
1.0.3

vscode-proto3
zxh
0.5.5

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
pyindex848cf:30577861
nodejswelcome1cf:30587006
3biah626:30602489
f6dab269:30613381
fim-prod:30623723

/extC++

It looks like this is caused by the C++ extension. Please file the issue to the C++ extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Conbee 3

Hi
Is the new Conbee III gateway allready supported?
Thx
Arkadi

Haven’t received it yet, but I don’t expect any differences in the API, so most likely Homebridge deCONZ wouldn’t even notice.

@ebaauw Just went through the migration according to https://phoscon.de/de/conbee3/upgrade
Only thing I had to do was storing the new API Key by pressing the "3rd party App - allow connection" button in Phoscon GUI.
Only messages I received at the beginning during the API connection are those:
[10/11/2023, 16:57:32] [deCONZ] Phoscon-GW: unlock gateway to obtain API key - retrying in 15s [10/11/2023, 16:57:32] [deCONZ] Phoscon-GW: warning: request 2: /: api error 101: link button not pressed [10/11/2023, 16:57:47] [deCONZ] Phoscon-GW: warning: websocket communication error: Unexpected server response: 400 [10/11/2023, 16:57:47] [deCONZ] Phoscon-GW: websocket connection to ws://<IP_ADDRESS>:443 closed - retry in 15s [10/11/2023, 16:57:47] [deCONZ] Phoscon-GW: Firmware Revision: set to "9.38.69" (from "0.0.0") [10/11/2023, 16:57:47] [deCONZ] Phoscon-GW: warning: 203485A54C: potentially stale api key: {"create date":"2023-06-05T12:29:34","last use date":"2023-11-10T14:01:57","name":"homebridge-deconz#homebridge"} [10/11/2023, 16:57:47] [deCONZ] Phoscon-GW: warning: 81C3C12649: potentially stale api key: {"create date":"2023-11-10T14:06:25","last use date":"2023-11-10T14:06:56","name":"homebridge-deconz#homebridge"}
I assume it stored another API key next to the "old" one?
And let's see if we have to do the dynamic configuration again for the gateway and accessories, since already some messages in the log are re-appearing even after I've set the loglevel:0 weeks ago:
[10/11/2023, 17:02:17] [deCONZ] Phoscon-GW Button: Programmable Switch Event: Single Press
So far what I can contribute

I'm not sure what you have done.  If you do a proper backup and restore of deCONZ, the new coordinator device should be configured with the mac address of the old device, and the database, containing the API keys should be restored.  The bridgeid (taken after the coordinator device's mac address) should not have changed and Homebridge deCONZ would not have to obtain a new API key.
I fear with the new bridgeid, deCONZ has created a new Zigbee network, and your Zigbee devices need to be re-paired to that network.
Also, the new bridgeid will cause Homebridge deCONZ to see a new deCONZ instance, and, indeed, you would have to redo the dynamic configuration.

As mentioned, I followed the migration steps from deCONZ which is literally just creating a backup, shutting down of the Pi, unplugging Conbee stick and inserting new one and fully booting the Pi again.
Then i just restored the backup in the Phoscon GUI and everything was set and done.
According to the Homebridge log the plugin couldn't connect to the gateway, even after an homebridge reboot. So i pressed the link button again.
Thats it, lights where controllable again after that in Homebridge and Homekit. No loss of automations etc.

This is not the kind of use case I do regularly, but I might try this on a test network.
Anyways, I think we can conclude that Homebridge deCONZ works just as well with deCONZ using a ConBee III.  I'm just surprised that the bridgeid changed.

@Patr-ick How did you get rid of messages like:
[11/23/2023, 10:45:36 AM] [deCONZ] Phoscon-GW Button: Programmable Switch Event: Single Press
It's not a big deal but rather annoying

@arkadicolson This question was asked and answered multiple times. Please see the closed issues, for e.g. https://github.com/ebaauw/homebridge-deconz/issues/145 or https://github.com/ebaauw/homebridge-deconz/issues/30

Got the ConBee III and, indeed, Homebridge deCONZ doesn't see any difference from the ConBee and RaspBee I and II (other than the device type).

@ebaauw Did you had to also grant a new API key and remove the old stale one?

The API key is part of the deCONZ REST API plugin.  It has nothing to do with the coordinator device.


Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working

Summary
Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working
Impact
Now users will get it working because it selects automatically the required features
Testing
ESP32-DEVKIT

Ok, I think new solution is better, I will sent a patch proposing to enable FS_TMPFS by default if !DEFAULT_SMALL

@acassis some defconfig is still not normalized?

@acassis some defconfig is still not normalized?

@xiaoxiang781216 I did a git pull here in my upstream branch and did:
$ ./tools/refresh.sh --silent --defaults all
$ git diff
It didn't show any defconfig modified. I'll force the github CI to tested, let see!

@xiaoxiang781216 could you please merge?


test: add buffer to channel to avoid goroutine leak

Description
Channel done has one send operation in a created goroutine, and one receive operation in a select. If the select statement at line 55 chooses case <-time.After(10 * time.Second), then the goroutine created at line 42 will be blocked forever.
This commit adds 1 buffer to the channel done. So the send operation will never be blocked.
This commit is safe because it doesn't change the semantics of the unit test: the receive will still wait for the send operation.

Thanks!


JVM: Fix bug in prompt example

This PR fixes a typo in the example for JVM prompts.

/gcbrun skip


Newly created functions can not be built

Versions used:
pojntfx@fedora:~$ go version
go version go1.21.1 linux/amd64
pojntfx@fedora:~$ scale version
scale version v0.1.7-dev12 (build date: Sat Oct 21 00:42:52 UTC 2023 git commit: 676f8de0feb1371469be159c3de896848f4e61e5 go version: go1.21.3 build platform: linux/amd64)

Steps to reproduce:
Rust:
$ scale function new questions:latest -d classifiers/questions -l rust -s felicitaspojtinger/classifier:latest
Successfully created new rust scale function questions:latest
$ scale function build -d ./classifiers/questions/
error: failed to parse manifest at `/home/pojntfx/.config/scale/builds/486625c4-2ba4-4947-acac-f58adb703676/compile/Cargo.toml`

Caused by:
  registry index was not found in any configuration: `scale`
Error: failed to build scale function: unable to compile scale function: exit status 101

Go:
$ scale function new questions:latest -d classifiers/questions -l go -s felicitaspojtinger/classifier:latest
Successfully created new go scale function questions:latest
$ scale function build -d ./classifiers/questions/
Error: failed to build scale function: unable to parse go.mod file: go.mod:6: replacement module without version must be directory path (rooted or starting with ./ or ../)

closed - https://github.com/loopholelabs/scale-cli/commit/993b98a8464b35c99924efebda0359b1ef316abc


use with assistant_library_demo.py

Hi....it´s posible to use with assistant_library_demo.py
thanks....

use this  https://github.com/senyoltw/custom-hotword-for-aiy-voicekit/blob/master/assistant_library_with_snowboy_demo.py
how to use
cd AIY-voice-kit-python
chmod a+x src/examples/voice/assistant_library_with_snowboy_demo.py
src/examples/voice/assistant_library_with_snowboy_demo.py src/mod/resources/alexa/alexa_02092017.umdl


Latest PaperMC

Hi,
This plugin is broken in the latest paper version. You cannot use this plugin at all with the latest version as you can take items from the shop menu out like a normal chest.

Cannot duplicate.
I am using the latest Paper version (updated weekly) and have never experienced this issue.

Cannot duplicate.
I am using the latest Paper version (updated weekly) and have never experienced this issue.

It was fixed in this update
https://github.com/PaperMC/Paper/issues/5222


Task: Deployment and validation

Deploy the CloudFormation script to create the required resources on AWS and validate that they are functioning correctly.

@inkonito: To validate AWS CloudFormation templates, we can use the tool AWS CloudFormation Linter | cfn-lint within a CI job.

@delager @inkonito @hocinehacherouf @ssgueye2 is this tested ? might we close it now ?

@kbeaugrand Yeah Raphael did it and it worked. i can retest it again if you want but it may take time

@kbeaugrand Yeah Raphael did it and it worked. i can retest it again if you want but it may take time

since you realized this, someone else should test it and validate it. ;) ..

I tested the CF scripts, I had some changes to make. This has been provided in #2087


fix: login

尝试修复登录问题 #139

There are still some bugs to fix before merging.

Need to resolve conflicts.

139 问题依旧


dupe AppBarLayout

activity_garden.xml has nested AppBarLayouts..

Good catch! We're fixing this internally and will push an update soon.


Issue - Fix ternary formatting for all cases. #54362

Fixes #
#54362

You just added a function mapLongExpressionToResult but don't use it anywhere. How is this going to fix the issue?

No, I can not. I don't know it. I just saw this PR you submitted to fix the issue, but it doesn't seem to fix the issue.

@jakebailey Any comment on this PR?

The code in this PR doesn't look like it has anything to do with the linked issue or the PR title.

This isn't fixing any bug or implementing anything we've agreed to add.


{"message":"The provided secret has expired."}

When we got on View on a drupal content to get the preview, sometimes it works but take a long time, and few times after, I've got this error :
{"message":"The provided secret has expired."}
It seems that the token is not refreshed well from the nextjs side

Yes. Right now, a new token is created when you visit the View page. It does not refresh automatically. You have to refresh the page to get a new token.
You could work around this by setting a larger expiration time for preview secrets.

Thanks for your answer, but on a AWS EC2 instance, it makes it crash, so the token could not be refresh.
It looks like it takes too much time so get a response, so it crashes
Any idea to fix this bug ?
Thanks

I think this issue is a duplicate of #422.


IoT build: skip calling Gulp if solution does not install it as dependency

To be fixed for 4.0.3

Fixed by #353


Add command line interface

Consider either just hooking in to VROOM's CLI, or create a new CLI thin wrapper.

Solved with #41. Using VROOMS CLI for the time being.


Question about the "numeric_properties.txt"

Thanks for sharing the codes! I have one question.
In "fix_freebase_literal_format.py", I observe that "numeric_properties.txt" is opened, but I could not find the file in this repository. Could you please upload this file, or somewhere I can get this file?
Thank you very much!
I am looking forward to receiving your comments.

This may be helpful: https://github.com/dki-lab/GrailQA/blob/0de52d18463e986047165dfeb085272513cad1ad/utils/search_over_graphs.py#L38

just uploaded the file. It should be the file that I used for the processing but I'm not exactly sure, so feel free to let me know if that doesn't work.

Thanks very much!

closing for now since this seems solved.


Add shouldNice option to AxisOptionsBase

added shouldNice: boolean option to AxisOptionsBase type
using this value as default when deciding whether to nice or not
fixed checks for extrema when building a time axis

Looks like this build errored, so a new version didn't get released. Can you look into that build error and PR a fix for it?

:tada: This PR is included in version 3.0.0-beta.33 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No quick fixes shown when editorconfig is not in project root folder

Issue Description
After enabling editorconfig support, problems are correctly reported, but there are no quick fixes shown.
Also sometimes there are actually quick fixes for formatting that don't respect the settings in .editorconfig (probably because these are the standard C# quick fixes).
Steps to Reproduce
I enabled editorconfig support as described here:
"omnisharp.enableEditorConfigSupport": true,
"omnisharp.enableRoslynAnalyzers": true

Open a CS file (from a Unity project) and see the problems highlighted in the editor, but no quick fixes.
Expected Behavior
See a list of quick fixes that can be applied.
Actual Behavior
No list of quick fixes presented.
Logs
OmniSharp log

Starting OmniSharp server at 3.8.2019, 14:34:10
    Target: f:\Projekte\UnityLibs\RxStateMachine\workspace\workspace.sln
OmniSharp server started.
Path: C:\Users\Andre.vscode\extensions\ms-vscode.csharp-1.21.0.omnisharp\1.34.0\OmniSharp.exe
PID: 2376
    Starting OmniSharp on Windows 6.2.9200.0 (x64)

    DotNetPath set to dotnet

    Located 3 MSBuild instance(s)
        1: Visual Studio Build Tools 2017 15.9.28307.222 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin"
        2: Visual Studio Community 2017 15.9.28307.222 - "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin"
        3: StandAlone 16.0 - "C:\Users\Andre\.vscode\extensions\ms-vscode.csharp-1.21.0\.omnisharp\1.34.0\.msbuild\Current\Bin"

    MSBUILD_EXE_PATH environment variable set to 'C:\Users\Andre\.vscode\extensions\ms-vscode.csharp-1.21.0\.omnisharp\1.34.0\.msbuild\Current\Bin\MSBuild.exe'

    Registered MSBuild instance: StandAlone 16.0 - "C:\Users\Andre\.vscode\extensions\ms-vscode.csharp-1.21.0\.omnisharp\1.34.0\.msbuild\Current\Bin"
        CscToolExe = csc.exe
        CscToolPath = C:\Users\Andre\.vscode\extensions\ms-vscode.csharp-1.21.0\.omnisharp\1.34.0\.msbuild\Current\Bin\Roslyn
        MSBuildExtensionsPath = C:\Users\Andre\.vscode\extensions\ms-vscode.csharp-1.21.0\.omnisharp\1.34.0\.msbuild
        MSBuildToolsPath = C:\Users\Andre\.vscode\extensions\ms-vscode.csharp-1.21.0\.omnisharp\1.34.0\.msbuild\Current\Bin

    Detecting Cake files in 'f:\Projekte\UnityLibs\RxStateMachine\workspace'.

    Could not find any Cake files

    Detecting projects in 'f:\Projekte\UnityLibs\RxStateMachine\workspace\workspace.sln'.

    Queue project update for 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp.csproj'

    Queue project update for 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp-firstpass.csproj'

    Detecting CSX files in 'f:\Projekte\UnityLibs\RxStateMachine\workspace'.

    Could not find any CSX files

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0

    Loading project: f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp.csproj

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.EditorConfigWorkspaceOptionsProvider, Order: 200

    Configuration finished.

    Omnisharp server running using Stdio at location 'f:\Projekte\UnityLibs\RxStateMachine\workspace' on host 7748.

    Successfully loaded project file 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp.csproj'.

    Adding project 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp.csproj'

    Loading project: f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp-firstpass.csproj

    Successfully loaded project file 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp-firstpass.csproj'.

    Adding project 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Assembly-CSharp-firstpass.csproj'

    Update project: Assembly-CSharp

    Unable to resolve assembly 'f:\Projekte\UnityLibs\RxStateMachine\workspace\Temp\bin\Debug\Assembly-CSharp-firstpass.dll'

    Update project: Assembly-CSharp-firstpass

    Solution initialized -> queue all documents for code analysis. Initial document count: 8.

    Applying code action: Formatierung beheben

Last code action is one of the wrong formatting quick fixes.
Environment information
VSCode version: 1.36.1
C# Extension: 1.21.0
Dotnet Information
A valid dotnet installation could not be found.
Visual Studio Code Extensions

Extension
Author
Version

atom-keybindings
ms-vscode
3.0.6

csharp
ms-vscode
1.21.0

node-module-intellisense
leizongmin
1.5.0

python
ms-python
2019.6.24221

unity-code-snippets
kleber-swf
1.3.0

unity-debug
Unity
2.7.2

unity-tools
Tobiah
1.1.1

vscode-eslint
dbaeumer
1.9.0

workspacesort
iciclesoft
1.5.7

C# log
Where's that?

thanks - unfortunately at the moment it is not very clear what is not working here.
could you please:

share your editorconfig file and explain which settings are not working for you?
show a sample of code that gets an analyzer but doesn't get a code fix (not every analyzer must have a code fix)
set "omnisharp.loglevel" to debug or trace and share the output of the log again

I noticed you have your system in german, does the same happen when the os language is set to English? also, is it possible for you to share the repro (have you tried on a normal .NET core project, instead of unity?)

Thanks for the quick answer, @filipw !
It seems I have misinterpreted the problem due to a couple of reasons:

the Quick Fix... button, when hovering, doesn't work (no code actions available), but quick fixes using the keyboard shortcut or the yellow bulb do work in normal C# projects (non-Unity)
my .editorconfig is simply ignored in projects created by Unity (I thought it worked, because I had similar rules).

it seems Unity-specific rules are used (e.g. a naming rule for starting methods with a capital letter), but I have no idea where they come from

I think 1. may be a bug in omnisharp-vscode. For 2. I have no idea where the problem comes from. Do you?

would you be able to provide a repro for this project somewhere on github? that would be very helpful - thanks

Sure thing, here it is:
https://github.com/FunkMonkey/omnisharp-vscode-issue-3212
Normally the sln and csproj are excluded from the git repo, but I provided them for reference. The Project was created using Unity 2019.2.0f
Here the difference between VS Code and VS Community 2017:

Thanks for the help!

Oh, I just saw how many absolute paths are in the csproj. Maybe you better delete both files and let them get recreated by Unity.

Any update on this?
Thanks a lot!

@filipw I did some more tests and it seems I misinterpreted the reasons once again.
It has nothing to do with Unity projects! The omnisharp extension simply ignores the .editorconfig if it is in a subfolder. (e.g. Assets/scripts as in my Unity project).
It would be nice, if the location of the .editorconfig file didn't matter. For my case putting the .editorconfig in the root folder would mean that other cs files in my repository (e.g. Unity plugins) will be reformatted or throw formatting errors.
Thanks a lot!

This appears to have been fixed with the latest plugin, at least as far as I can tell:

Please do ping back if you don't see similar behavior.


Improve .NET Core project.json

Specify the exact dependencies instead of relying on NETStandard meta package
Add Debug and Release configurations
UTests: use "platform" type to avoid specifying the runtimes
UTests: remove useless version field

Seems you're pretty busy those days, I'll probably soon be curious about what project you're on :)

hehe, nothing really special, I'm mostly just having fun with .NET Core :)
I'm trying to migrate some existing projects and do some benchmark.


Is it possible to use the same kind of view controller in all tabs?

I am wondering if it is possible to use the same view controller in all tabs without adding all the same view controller that I need in the array. I think it might be a waste of memory.
Can anybody help me? Thank you in advance!

Am also looking solution for this.
http://stackoverflow.com/questions/13866342/need-to-dynamically-create-viewcontroller-objects-from-a-tableview-selection-in

In my opinion is not the best solution to use this menu for it. It is a pretty good page menu in order to use many different view controllers in your app. You should use only a segmented control with scroll and then, depends on the selected tab you should create and present the view controller that you need. In my case, I always needed to present the same view controller so I had to change the data. For example, if the view controller contains a tableview, you will have to upload the data.

Solution is,
NSMutableArray *controllerArray = [[NSMutableArray alloc] init];

TestViewController *viewControllerToDisplay;
for(int k=0; k<=3;k++) {
    // controllerArray =  = @[controller1, controller2, controller3, controller4];
    if(k==0) {
        [controllerArray addObject:controller1];
    }
    if(k==1) {
        [controllerArray addObject:controller2];
    }
    if(k==2 || k==3) {
        //controller3.title = @"MUSIC1";
        viewControllerToDisplay = [[TestViewController alloc] initWithNibName:@"TestViewController" bundle:nil];

        viewControllerToDisplay.passdata = @"MUSIC1";
        viewControllerToDisplay.title = @"MUSIC1";
        if(k==3) {
        viewControllerToDisplay.passdata = @"Discover";
        viewControllerToDisplay.title = @"Discover";
        }

        viewControllerToDisplay.parentNavigationController = self.navigationController;
        [controllerArray addObject:viewControllerToDisplay];
    }
}

The Music1 and Discover sharing same view controller.

Actually my apps want to show last 10 years timesheet horizontally scroll. So thats why i used this pagemenu.

Dharani1984 , I am trying to archive the same thing? would you mind help me with some example project? It will be a lot helpful.


Tests: Add unit tests for org.osbuild.mkfs.btrfs stage

Add unit tests for mkfs.btrfs stage

Since it's a common pattern I'll point it out here: I'm fine with using re.search for substrings :)

Still needs the re import removed.


Support Recording Voice Messages from Chat Plugin

Currently: the Airy Live Chat Plugin does not support recording voice messages.
Ideally: if a contact sends an audio recording via the Chat Plugin, it should be displayed in the system user's Inbox with a way to quickly and easily listen to the message.
Within the UI: if an audio message is received, the Airy system user should be able to view the conversation and listen to the audio message. This feature should be bidirectional.

@lizhutter How should users be able to send voice messages when they have the chatplugin open? There are many different ways of designing this.
See for instance messenger

or Telegram

Could you provide us with a reference? :)

@chrismatix I think a design similar to what is used for instance messenger would be our best solution here :)

DESIGN ATTACHMENT:
Figma Files:
https://www.figma.com/file/62OHAAms7NULEbpv4Dy5NO/Support-Vocal-Messages?node-id=0%3A1


Add redirect to GCSE controller if GCSE is missing

For the edit/update actions in the GCSE TypeController, redirect to the
application form if the GCSE doesn't exist.
This fixes a bug seen in production
https://sentry.io/organizations/dfe-bat/issues/2438946737/
It's unclear how a candidate would navigate to the edit action normally
without first creating the GCSE, however manual URL manipulation is
plausible.
Context

Changes proposed in this pull request

Guidance to review

Link to Trello card

Things to check

[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] API release notes have been updated if necessary
[ ] Required environment variables have been updated added to the Azure KeyVault

@malcolmbaig this looks good but can you add a request spec to verify this behavior please!


Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.1
Time: Mon Mar 14 2016 12:50:03 GMT 0100 (Romance Standard Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\xavie\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\inject\GPMInject\interface\mouseButtonNavigation.js:8:8.
    at BrowserWindow.callIntoRenderer (C:\Users\xavie\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\lib\rpc-server.js:201:19)
    at emitTwo (events.js:92:20)
    at BrowserWindow.emit (events.js:172:7)
    at EventEmitter.<anonymous> (C:\Users\xavie\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\main\features\core\controlBar.js:10:45)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)
    at EventEmitter.<anonymous> (C:\Users\xavie\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\api\lib\web-contents.js:134:25)
    at emitTwo (events.js:87:13)
    at EventEmitter.emit (events.js:172:7)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #470


Allow static build.

The aim of this PR is to give users a static build target uvw_a.
Users will be able to compile uvw as a dependency in their project.
In order to statically build the uvw, the cmake flag -DBUILD_STATIC_LIB=ON has to be added and the uvw_a has to be added to the project as a link target.

I'm pretty sure a lot of people will appreciate this. :+1:


Sync eng/common directory with azure-sdk-tools for PR 1615

Sync eng/common directory with azure-sdk-tools for PR https://github.com/Azure/azure-sdk-tools/pull/1615  See eng/common workflow

/check-enforcer override


TypeError: slide.useSlideLayout is not a function

Greetings, thank you for the great tool first, I know that you just uploaded new changes, but I already have a question about them.
pptx-automizer version: 0.3.0
env: Node v16.13.0 + TS
I want to combine several slides together into one slide deck, they have different layouts and I've seen that you've updated a version with the changes I'm looking for (hopefully).
I've tried to use the same way as in the example:
// Import a slideMaster and its slideLayouts:
pres.addMaster('SlidesWithAdditionalMaster.pptx', 1);

// It is also possible to use the original slideLayout of any added slide:
pres.addSlide('SlidesWithAdditionalMaster.pptx', 3, (slide) => {
  // To use the original master from 'SlidesWithAdditionalMaster.pptx',
  // we can skip the argument:
  slide.useSlideLayout();
  // This will also auto-import the original slideMaster, if not done already,
  // and look for the created index of the source slideLayout.
});

But it seems like slide.useSlideLayout is missing in export, or I did something wrong.
Also, the same situation with :
 // Always use the original slideMaster and slideLayout of any
 // imported slide:
 autoImportSlideMasters: true,

Thanks in advance, looking forward to your reply!

Hi! I'm glad you like it :)
Please, try again with version 0.3.1! I needed to fix the ISlide interface in order to get rid of the messages mentioned above. Sorry for the inconvenience.
The new version also includes some methods to prevent corrupted pptx files, especially when importing e.g. images, charts or think-cell contents from slideLayouts.
It would be great if you could give feedback on any further issues with the new feature.

I needed to refactor slideLayouts handling to improve support of related contents. If you are having trouble with corrupted pptx files, you can try 0.3.2.

I've used the old 2007 format, and It works well with different themes. New formats work as well, even during 2-way migration from GS to local and then back.
I've found some cases with slide resolution conversion (I've tried to combine your slides from examples and other slides and elements' positions, text sizes, etc were changed). But this is expected behavior for me.
Didn't find any issues with importing even in v0.3.0.
In any case, I'm going to run more tests with production data very soon and will keep you updated if find something :)
Many thanks!

That sounds good! Thank you for testing.
I can confirm the issues with slide resolution, but I think this doesn't need to be improved.
The recent changes to src/enums/image-type-map.ts will fix broken relations needed in Content_Types; in my case this has been Think-Cell related stuff. This is a good place to add more extensions in case ppt complains on opening a pptx file.
Feel free to re-open this issue if you encounter repair messages by powerpoint.


fix(loading): fix glitch on loading sequence

Description:
Refactor such that the LoadingBolt component is only mounted once, in the root component.
Motivation and Context:
The loading bolt was being shown in several distinct places, which was resulting in a glitch between completing onboarding and showing the wallet ui.
How Has This Been Tested?
Manually - complete onboarding in various ways and see how the app transitions from the loading bolt to the wallet ui.
Screenshots (if appropriate):
Types of changes:
Bug fix
Checklist:

[ ] My code follows the code style of this project.
[ ] I have reviewed and updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes where needed.
[ ] All new and existing tests passed.
[ ] My commits have been squashed into a concise set of changes.

Tested ACK 05f30c4
@mrfelton one tiny comment


Create Dynamic Theme-Plugin

Hi There!!
Changes

Created a theme plugin.

this is just like the VSCode Catppuccin extension. Allows users to control accent color and dynamically adjust the theme.

Closes #12
Redo catwalk images and assets
Finally implement accents!! hooray!
Refactor some unused variables inside the main entry point file

Why?

Lying in bed one day, I randomly realized this port did not use accent colors. It was one of those  moments.

To remedy this missing feature, this PR merges a RemNote plugin that automates the building of the LESS file and allows certain user-configurated settings to modify how the less file is built.
That is all,
Thank you!

removed the review because the review request for tobbi worked :)

[ ] upload plugin and themes to RemNote
[ ] publish live on RemNote


ResponsiveElement doesn't pass down custom props

Bug Report
ResponsiveElement doesn't pass down custom props
Description
I have Aggregator wrapped around ResponsiveElement. Aggregator sends down aggegatorDelegate prop and that is not being passed to the components in the responsiveElement since the responsive element doesn't send down custom props
Steps to Reproduce
<Aggregator> #sends down aggregatorDelegate prop
   <ResponsiveElement>
       tiny={<someComponent>//this component doesn't get aggregatorDelegate prop }
   </ResponsiveElement>
</Aggregator>

Expected Behavior
Responsive Element should send down customProps. So that the user doesn't have to use wrapper around responsiveElement to get the props and again pass the custom props down to responsive element.
Possible Solution
Modify ResponsiveElement to send down customProps

Talked through some options of passing props directly to children or use new context API to make props available to children.

After discussions with the Terra team we are closing this issue.
There are concerns around cloning and overriding props on each element defined within the responsive element. The custom property pattern is intended to be applied only to a top-level component wrapper that has a defined set of PropTypes. Spreading custom properties onto unknown elements poses a risk of introducing unsupported properties and overriding existing properties.


Feature request: Location "MapLink"

Would be nice to have a button next to the location name that opens up the in-game map and moves the view to the location of the task.
Or if that's too challenging or impossible then perhaps have a button that opens up the wiki to the location header of the npc. For example, if I had a greater demon task you could have a button directing to https://oldschool.runescape.wiki/w/Greater_demon#Locations for convenience of map-link.

+1


Fixed a bug that easy install incorrectly parsed Python 3.10 version string

Summary of changes
Fixed a bug that easy install incorrectly parsed Python 3.10 version string.
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in changelog.d/.
(See documentation for details)

Looks like this bug was reported in #3001.
Can you add a test?

Sorry I don't have time for now.
Maybe you can help add one. Or I can do it sometime next week.

Looks like this bug was reported in #3001.
Can you add a test?

Sorry I don't have time for now.
Maybe you can help add one. Or I can do it sometime next week.

As the existing tests are not running properly, I think the best here would be an update, So here it goes...
@Mergifyio update

Hi @liuzhe-lz, @jaraco I added some tests to the proposed fix. Please feel free to remove it, change or add any other tests.
(I also reordered a bit the commits, because I wanted to see the test failing before the fix is applied and study how to better represent the situation in #3001).

Notes:
I noticed the stdlib version of distutils sometimes create a path that contains a literal string 'None', which seems to be a bug already solved in the vendored version.
Another thing that I noticed is that for Windows 3.10, there might be a ValueError: invalid variable 'py_version_nodot_plat', which I guess is already solved by https://github.com/pypa/distutils/commit/1560a1fe4e56e00392d3658a59e6fc7238e26a8a and will be eventually pulled into setuptools.

Thanks everyone!


Update regex for email validation, so the tests pass

The regex used is: [A-Z0-9a-z._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,6}
Some tests fail:

<EMAIL_ADDRESS>was considered valid, but it is not
<EMAIL_ADDRESS>was considered valid, but it is not
<EMAIL_ADDRESS>was considered valid, but it is not
<EMAIL_ADDRESS>was considered valid, but it is not
<EMAIL_ADDRESS>was considered valid, but it is not
<EMAIL_ADDRESS>was considered valid, but it is not

Fixed in ca52b0035878b759c21551a8a5503456ec58e102

@mariusc You shouldn't merge your own pull requests when changing functionality like this. Merging a typo fix pull request is ofc fine, but this might affect performance, functionality and our existing apps.
The new expression looks and works ok (in a few of my tests), but is 3 - 4 times slower than the previous one. Let's leave it there for now, as it probably won't be an issue, but just for the future reference, keep the PR opened for some time and assign someone to it :)

@nickskull Got it :+1:


How to align text using Toast UI Vue Editor Text Alignment?

Hi Maintainers! my question same as above, how to align text using toast UI editor in Vuejs? after reading master docs, the editor provides a total of 16 toolbar items and there are no options for text alignment and font size.

@justirva09
Our editor does not provide that functionality because it is based on markdown and markdown syntax can't support that kind of functionality.
If you want to use the feature in wysiwyg, it needs to be implemented directly.

@js87zz
Can u give me an example, if I need to implement it directly with wysiwyg editor?


DPO training -7B model, OOM on A6000

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Capable of DPO training for 7B models in A6000-48G memory environment
Current behaviour
I used an A6000 (48GiB) * 8 device for DPO training based on the 7B model, and during the training, there was OOM behavior. For the official training of dolphin-2.6-microl-7b-dpo using dolphin-dpo.yml, I have tried to reduce the graphics memory through parameters, but OOM still occurs。
1、The comparison of YML is as follows：
1）Official DPO training using YML（https://huggingface.co/cognitivecomputations/dolphin-2.6-mistral-7b-dpo/blob/main/configs/dolphin-dpo.yml）
base_model: cognitivecomputations/dolphin-2.6-mistral-7b
model_type: MistralForCausalLM
tokenizer_type: LlamaTokenizer
is_mistral_derived_model: true

load_in_8bit: false
load_in_4bit: true
strict: false

rl: true
datasets:
  - path: argilla/ultrafeedback-binarized-preferences-cleaned
    split: train
    type: ultra_apply_chatml
  - path: unalignment/toxic-dpo-v0.1
    split: train
    type: toxic_apply_chatml

dataset_prepared_path: last_run_prepared
val_set_size: 0.0
output_dir: /workspace/dolphin-2.6-mistral-7b-dpo

adapter: qlora
lora_model_dir:

sequence_len: 2048
sample_packing: false
pad_to_sequence_len: false

lora_r: 64
lora_alpha: 32
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:
lora_target_modules:
  - gate_proj
  - down_proj
  - up_proj
  - q_proj
  - v_proj
  - k_proj
  - o_proj

wandb_project: dolphin
wandb_entity:
wandb_watch:
wandb_run_id:
wandb_log_model:

gradient_accumulation_steps: 4
micro_batch_size: 4
num_epochs: 1
optimizer: paged_adamw_8bit
lr_scheduler: cosine
learning_rate: 2e-5

train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: true

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

warmup_steps: 10
eval_steps:
eval_table_size:
eval_table_max_new_tokens: 128
save_steps: 239
debug:
deepspeed:
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:
save_safetensors: true

2）The YMl I am using
base_model: /data1/ljf2/data/dolphin-2.6-mistral-7b-sft-yhy
model_type: MistralForCausalLM
tokenizer_type: LlamaTokenizer
is_mistral_derived_model: true

load_in_8bit: false
load_in_4bit: false
strict: false

rl: true
datasets:
  - path: /data1/ljf2/data/dpo-16k-new
    split: train
    type: ultra_apply_chatml

dataset_prepared_path: /data1/ljf2/data/data_out
val_set_size: 0.0
output_dir: /data1/ljf2/data/dpo_out

adapter: lora
lora_model_dir:

sequence_len: 16384
sample_packing: false
pad_to_sequence_len: false

lora_r: 64
lora_alpha: 32
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:
lora_target_modules:
  - q_proj
  - v_proj
  - k_proj
  - o_proj
gradient_accumulation_steps: 1
micro_batch_size: 1
num_epochs: 1
optimizer: paged_adamw_8bit
lr_scheduler: cosine
learning_rate: 2e-5

train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

warmup_steps: 10
save_steps: 100
save_total_limit: 3
debug:
deepspeed: /data1/ljf2/data/load_zero2.json
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:
save_safetensors: true

2、Screenshot of video memory usage：

3、OOM Error screenshot：

4、Deepspeed zero configuration used：
{
  "train_batch_size": "auto",
  "train_micro_batch_size_per_gpu": "auto",
  "gradient_accumulation_steps": "auto",
  "gradient_clipping": "auto",
  "zero_allow_untested_optimizer": true,
  "bf16": {
    "enabled": "auto",
    "loss_scale": 0,
    "initial_scale_power": 16,
    "loss_scale_window": 1000,
    "hysteresis": 2,
    "min_loss_scale": 1
  },
  "zero_optimization": {
    "stage": 2,
    “offload_optimizer": {
    "device": "cpu",
    "pin_memory": true
    },
    "offload_optimizer": {
    "device": "cpu",
    "pin_memory": true
    },
    "allgather_partitions": true,
    "allgather_bucket_size": 5e8,
    "reduce_scatter": true,
    "reduce_bucket_size": 5e8,
    "overlap_comm": false,
    "contiguous_gradients": true
  }
}

Steps to reproduce
docker：winglian/axolotl:main-py3.10-cu118-2.0.1
Start Training：
export CUDA_VISIBLE_DEVICES=0,1,2,3,4,5,6,7
export PYTORCH_CUDA_ALLOC_CONF=max_split_size_mb:256
export TOKENIZERS_PARALLELISM="true"
accelerate launch -m axolotl.cli.train dpo.yml
Config yaml
No response
Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

you need to set one of these to true
load_in_8bit: false
load_in_4bit: false

and then set adapter:  to lora or qlora depending on the one you set to true


typo: neccessary -> necessary

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/manufacturing-guide/07a-ManufacturingCheckList.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: enable all job settings

Fixes #915 . Open to feedback if there's a better way to do this, just tried to keep it simple.
I've added @schemastore/github-workflow to get the typing for concurrency, but could also use that to get the type for Job instead of having to maintain that in this project

fyi this pr would also solve the immediate problem for needing concurrency, but doesn't future proof against the need for customising other job settings in future

interesting points! I see the logic, but I'd argue that while maintaining control of types is really important for your own constructs, it's an extra overhead to maintain types for someone else's repo. if you have the resources to keep them updated, happy to remove the extra package
re future proofing, that's a pretty reasonable position. the other open pr to expose concurrency matches a lot more closely with your feedback, so if that approach makes more sense I don't mind, just interested in the outcome!

Sounds good @clairemr. I will go ahead and merge #905 today to get this in and released. As for the types package, thank you for bringing that to my attention. At least for now, I see more potential problems with introducing that dependency than maintaining our own types. But you are right, that requires some level of maintenance on this project. This project has grown some legs in the past year or so, which is awesome. I am still willing to maintain this repo and at the very least check in 1-2 times a week to make sure that things don't get too stagnant. I'll also look to see if we can utilize community help on this project too. Closing the PR for now, but happy to keep conversing in a github issue or any future PR!


removechild fix when rename existing file repeately

The issue will lead to removeChildUnlocked panic.
It relate the issue https://github.com/kahing/goofys/issues/216.

could you write a test for this also? That way this won't accidentally happen again

thanks for finding this bug, I don't think your fix is correct but I've just checked in a proper fix.

In essense, the issue is relate with relationship between inode and dentry(in goofys,call child).  one inode may have multiply dentries ref . such as rename ,we remove child ,we should not remove all dentry relate with the inode .Instead, we should remove the dentry relate the name rename op supplied to.


Base64-encode byte arrays

I wonder if maybe we should hex encode them instead? Like
08 12 AF ED
08 12 AF ED
08 12 AF ED

It makes sense in case someone wants to view or edit the raw bytes. I have converted Bytes to use https://docs.rs/serde_with/latest/serde_with/hex/struct.Hex.html instead of Base64.


📝[Docs]: changing the style

changing the style of meet pet in adopt .html it is not aligned properly

@Krishna100604  please assign me this issue


Update log4cats-core, log4cats-slf4j, ... to 1.4.0

Updates

org.typelevel:log4cats-core
org.typelevel:log4cats-slf4j
org.typelevel:log4cats-testing

from 1.3.1 to 1.4.0.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.3.1).
You might want to review and update them manually.
CHANGELOG.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel" } ]

labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains

Superseded by #304.


Custom tags for workspace resource groups

Is there a way to specify custom Azure tags per-workspace?
Description
I would like to crate workspaces in the TRE where the Azure resource group has a custom tag applied to it. I.e., the tag name would be the same for all resource groups, but the tag value would differ.
This is mostly useful in terms of managing costs, monitoring and billing by project etc. So a typical example of a tag would be cost_centre = 12345 for project A, cost_centre = 54321 for project B, and so on. That said, there are other cases where we might want to add arbitrary tags to resource groups when they're created.
It looks to me like this isn't supported. Has anyone considered this before?

Hi @TonyWildish-BH yes we've done something similar for a customer.
The tag is created in a workspace then we used policy to add it to the resources within the RG.

thanks for the quick answer Tim. Is there some code to go with this, or is it all done manually?

Here's the policy resource we used.
Outside of this we have a local local.custom_tags that builds a map of tags that's built from some variables passed in from a customised porter template of the base workspace.
resource "azurerm_policy_definition" "custom_tre_tags" {
  name         = "custom_tre_tags_${local.workspace_resource_name_suffix}"
  display_name = "Azure TRE ${local.workspace_resource_name_suffix}: Custom Tags"
  description  = "Add custom tags to all resources in TRE ${local.workspace_resource_name_suffix}"
  policy_type  = "Custom"
  mode         = "Indexed"

  metadata = <<METADATA
  {
    "category": "Tags",
    "version": "1.0.0"
  }
  METADATA

  policy_rule = jsonencode({
    "if" : {
      "allOf" : [
        {
          "field" : "tags['tre_workspace_id']",
          "equals" : var.tre_resource_id
        },
        {
          "anyOf" : [
            for tag_key, tag_value in local.custom_tags : {
              "field" : "tags['${tag_key}']",
              "notEquals" : tag_value
            }
          ]

        }
      ]
    },
    "then" : {
      "effect" : "modify",
      "details" : {
        "conflictEffect" : "audit",
        "roleDefinitionIds" : [
          "/providers/Microsoft.Authorization/roleDefinitions/b24988ac-6180-42a0-ab88-20f7382dd24c"
        ],
        "operations" : [
          for tag_key, tag_value in local.custom_tags : {
            "operation" : "addOrReplace",
            "field" : "tags['${tag_key}']",
            "value" : tag_value
          }
        ]
      }
    }
  })
}

Thanks Tim, that looks very useful!


DashBoard

default search condition can not change.
need show all stories.

all stories should go to story list page


organize import statements

What this PR does / why we need it:
Maybe you like it, maybe you don't :-)
go get go.xrstf.de/gimps && gimps . to rerun.
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Optional Release Note:
NONE

/retest


fix add key_bound initialization check when lookup_row_key

Proposed changes
key_bound may be inital failed when be is out of memory, so should add an  initialization check before compare key.
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

LGTM

after discussion, when be is out of memory, it may not work normally, so in this scenario, just let be core is not a bad idea, so no need to change the code in lookup_row_key, close this pr.


error while running python unit test

I get an error saying
'ImportError: No module named tensorframes'
Can you suggest as to how do I install it?

Did you run build/sbt assembly before running run-tests.sh ? The assembly should pull in tensorframes automatically, and run-tests.sh should add the built assembly to PYTHONPATH, so you shouldn't need to do anything specific for tensoframes.

Yeah its working fine now .. thanks a lot

cool! please re-open if you run into any other issues.

Does it only supports python2 now? it seems if I use the python3, it still shows “No module named 'tensorframes'“ error.


Improvement for .gitpod.yml

Fixes for developers.  Removed some hard coded points.

Completed.

Done.


Will you update scripts for 2.0.1?

V2_0_0_API_BREAK.txt

Yes, see #184

Lines 466 and 467 in "work-for-faction.js" can be updated as such:
        return ns.print(`Your combination of Hacking mult (${formatNumberShort(player.mults.hacking)}), exp_mult ` +
            `(${formatNumberShort(player.mults.hacking_exp)}), and bitnode hacking / study exp mults ` +

All skills have been reconfigured from "player.strength" to "player.skills.strength" for example.

getFactionReputation has been changed to getFactionRep

@notacompletemoron All of the issues you mentioned should now be resolved.

I think this is mostly taken care of now, let's just open up new tickets for each individual discovered issue from here on.


[Bug🐞/or I am doing something completely wrong🤔] - mocking response is not send

I have a test WPF app that sends request to https://graph.microsoft.com/v1.0/me.
When I use chaos mode and a failure is generated I get the correct behavior, which means I get the error in the response

When I use the same mocking the response to return 500 it seems the request is caught but I as a response I don't get the error from the proxy but I get response from graph API

this is my mock.json file:
{
  "responses": [
    {
      "url": "https://graph.microsoft.com/v1.0/me",
      "method": "GET",
      "responseCode": 500
    },
    {
      "url": "https://customapiendpoint/test/gettest",
      "method": "GET",
      "responseCode": 500
    }
  ]
}

Am I missing something or is it a bug?
TBH the same kind of scenario worked fine in v0.3 meaning I got an error in the response when mocking.

Could you please share with us your appsettings.json and mock.json so that we can repro it?

mock.json file
{
  "responses": [
    {
      "url": "https://graph.microsoft.com/v1.0/me",
      "method": "GET",
      "responseCode": 500
    },
    {
      "url": "https://customapiendpoint/test/gettest",
      "method": "GET",
      "responseCode": 500
    }
  ]
}

appsettings.json:
{
  "plugins": [
    {
      "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
      "name": "GraphSelectGuidancePlugin",
      "urlsToWatch": [
        "https://graph.microsoft.com/v1.0/*",
        "https://graph.microsoft.com/beta/*",
        "https://graph.microsoft.us/v1.0/*",
        "https://graph.microsoft.us/beta/*",
        "https://dod-graph.microsoft.us/v1.0/*",
        "https://dod-graph.microsoft.us/beta/*",
        "https://microsoftgraph.chinacloudapi.cn/v1.0/*",
        "https://microsoftgraph.chinacloudapi.cn/beta/*"
      ]
    },
    {
      "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
      "name": "GraphBetaSupportGuidancePlugin",
      "urlsToWatch": [
        "https://graph.microsoft.com/v1.0/*",
        "https://graph.microsoft.com/beta/*",
        "https://graph.microsoft.us/v1.0/*",
        "https://graph.microsoft.us/beta/*",
        "https://dod-graph.microsoft.us/v1.0/*",
        "https://dod-graph.microsoft.us/beta/*",
        "https://microsoftgraph.chinacloudapi.cn/v1.0/*",
        "https://microsoftgraph.chinacloudapi.cn/beta/*"
      ]
    },
    {
      "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
      "name": "GraphSdkGuidancePlugin",
      "urlsToWatch": [
        "https://graph.microsoft.com/v1.0/*",
        "https://graph.microsoft.com/beta/*",
        "https://graph.microsoft.us/v1.0/*",
        "https://graph.microsoft.us/beta/*",
        "https://dod-graph.microsoft.us/v1.0/*",
        "https://dod-graph.microsoft.us/beta/*",
        "https://microsoftgraph.chinacloudapi.cn/v1.0/*",
        "https://microsoftgraph.chinacloudapi.cn/beta/*"
      ]
    },
    {
      "configSection": "mocksPlugin",
      "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
      "name": "MockResponsePlugin",
      "disabled": false
    },
    {
      "configSection": "randomErrorsPlugin",
      "pluginPath": "GraphProxyPlugins\\msgraph-developer-proxy-plugins.dll",
      "name": "RandomErrorPlugin",
      "disabled": false
    }
  ],
  "urlsToWatch": [
    "https://graph.microsoft.com/v1.0/*",
    "https://graph.microsoft.com/beta/*",
    "https://graph.microsoft.us/v1.0/*",
    "https://graph.microsoft.us/beta/*",
    "https://dod-graph.microsoft.us/v1.0/*",
    "https://dod-graph.microsoft.us/beta/*",
    "https://microsoftgraph.chinacloudapi.cn/v1.0/*",
    "https://microsoftgraph.chinacloudapi.cn/beta/*",
    "https://*.sharepoint.*/*_api/*",
    "https://*.sharepoint.*/*_vti_bin/*",
    "https://*.sharepoint-df.*/*_api/*",
    "https://*.sharepoint-df.*/*_vti_bin/*",
    "https://customapiendpoint/test/gettest"
  ],
  "mocksPlugin": {
    "mocksFile":  "responses.json"
  },
  "randomErrorsPlugin": {
    "rate": 50,
    "allowedErrors": [ 429, 500, 502, 503, 504, 507 ]
  },
  "labelMode": "text",
  "logLevel": "info"
}

It seems like in your config you're pointing to responses.json but your mock file is named mock.json. Could this be the issue?

You're right and I can repro the error. Let me see what's wrong. Thank you for reporting it and sorry for the trouble.

You're right and I can repro the error. Let me see what's wrong. Thank you for reporting it and sorry for the trouble.

That's totally ok. Let me know if you need any help. I started debugging it anyway to get to know the plugin approach for my plugin but I doze off in front of the laptop 😅.
Better luck next weekend

I found the issue and submitted a PR. We'll try to get it processed asap and perhaps could release a beta to test it early.

Cool thanks 👍
I will test it from debug today over the night from the branch from your PR to double check if it's working on 'my machine' as well 😅.
Thanks for your quick reaction to the issue. You rock 👍

@waldekmastykarz I tested your changes done in the PR and in general it works 👍. The only difference I see is that in v0.3 the proxy also returned some response.content added to the error, now it is empty.
So previously in response.content for 500 I got something like this

now actually the content is empty. BUT I guess this is fine as long as the status code is correctly returned which is 500 (InternalServerError), so I sliglthy modified my test app to print the status code as well and now my output is like

Totally fine if you ask me 😉. But just wanted to let you know 👍.
Awesome work 👍 Thank you for your ASAP response on this one 🤩 Can't wait for this to be merged since it is also needed for my custom plugin (but no rush 😉)