Doc Expansion

requires #884 to be merged first

I like the restructuring of the .md files, but I'll want to do a final spelling/wording pass before merging this.

Approved for merge. My one remaining comment can be tackled in a later PR because the currently recommended code does work.


[Removal]: Exotic Blood Falcon

Hotspot Name
Exotic Blood Falcon
Hotspot b58 Address
112aGenH8LuxvnBjRJdPeGpHR7u9C1x1cUPCe6wkKVYLsUawbdQC
Discord Handle
Marco-polo#0495
Hotspot Manufacturer
SenseCAP
Removal Reason
Some-one just banned my wallet without any proof, we are telecom provider
Modifications
No
Extra forwarders
No
Extra antennas
Yes
Additional Information
External 6 dbi omni, 70m building
Great site, but all telecom towers with good earning did end up the denylist.
So i have todo this 50+ times ?
More info via PM, discord.
Regards
A 500+ telecom tower owner.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Move AbsentStudents to the main harkness view and style them around a table (circle)

We decided not to do this for initial release.


[tools/generator] add automation and release command for track2

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/azp run

I have tried sdk automation in test branch. PR is in https://github.com/openapi-env-test/azure-rest-api-specs/pull/2967. @ArcturusZhang


HealthIndicator always returning UNKNOWN status even if connected

Hey there !
I'm experiencing an issue with Spring Cloud Stream, the Kafka Stream Binder, and the auto configured Health Indicator for the Actuator.
Here is a sample minimal project that reproduces my issue. You'll need a Kafka running (I'm working with an older 2.2.0 version, which constraints me to keep the Hoxton.SR8 and avoid Hoxton.SR9 and further) with two topics, IN and OUT.
Just startup the application (after adapting the broker's address/port of course), you may try to send it a message and see that it goes through without issue.
I'm then calling the Health endpoint, which returns me the following:
{
  "status": "UP",
  "components": {
    "binders": {
      "status": "UNKNOWN",
      "components": {
        "enricherKStreamBinder": {
          "status": "UNKNOWN"
        }
      }
    },
    "diskSpace": {
      "status": "UP",
      "details": {
        "total":<PHONE_NUMBER>12,
        "free":<PHONE_NUMBER>28,
        "threshold": 10485760,
        "exists": true
      }
    },
    "ping": {
      "status": "UP"
    }
  }
}

As the application is working as properly and can talk to Kafka, I would have expected to see a $.component.binders.status and $.component.binders.components.enricherKStreamBinder set to UP.
When debugging, I see that the code goes through org.springframework.cloud.stream.config.BindersHealthIndicatorAutoConfiguration.BindersHealthContributor#getContributor(), called with an empty Map as argument, causing it to return the static private static final HealthIndicator UNKNOWN = () -> {return Health.unknown().build();};.
I naively would expect the map to not be empty there, but I'm no expert.
Hoping you can help, it may only be a configuration issue.
Thanks a lot for your work !
And of course feel free to redirect me if i'm in the wrong repo, or anything.

Apologies, wrong repo...

Apologies, mixed up the repos. This one seems to be the one, feel free to redirect me if not !

@mborgraeve Any chance you can upgrade to 3.0.x? The version you are using 2.2.x is based on Spring Boot 2.1.x which is EOL'ed.

No, unfortunately I have no control over the Kafka setup. I wish we could upgrade too...

@mborgraeve Sorry for the confusion. I didn't realize that the 2.2.x you mentioned is the Kafka version. You are using the latest Spring Cloud Stream, so I will see if it is an issue. Which SR8 did you mention above?

Ahh I see, no worries.
SR8 is the spring-cloud-dependencies train version, Hoxton.SR8, it's in the pom.xml

@mborgraeve Is this working if you don't use multi binder setup? Can you remove the multi binder configuration and make it a single binder context application and see if that works? I am still trying to see if there are some issues with multi binder setup and health check in Kafka Streams binder. Thanks!

@mborgraeve Is this working if you don't use multi binder setup? Can you remove the multi binder configuration and make it a single binder context application and see if that works? I am still trying to see if there are some issues with multi binder setup and health check in Kafka Streams binder. Thanks!

@mborgraeve There was an issue in the way health indicators were configured when using an application with a multi-binder context. This is now addressed on both master and 3.0.x branches. Thanks for pointing out this issue.

@mborgraeve There was an issue in the way health indicators were configured when using an application with a multi-binder context. This is now addressed on both master and 3.0.x branches. Thanks for pointing out this issue.

For some reason I wasn't notified of your answers, apologies.
Thanks a lot, and glad I could help.

This is now addressed on both master and 3.0.x branches.
I'm unsure how this fix would end up in the Spring Cloud Dependencies release train. I was using spring-cloud-dependencies:Hoxton.SR8, which pulls soring-cloud-stream:Horsham.SR8, which pulls spring-cloud-stream-binder-kafka-streams:3.0.8. Moving to Hoxton.SR9 brings Horsham.SR9 and 3.0.9.

Would these be updated with your fix, or should I update to SR9 or another release train version?

For some reason I wasn't notified of your answers, apologies.
Thanks a lot, and glad I could help.

This is now addressed on both master and 3.0.x branches.
I'm unsure how this fix would end up in the Spring Cloud Dependencies release train. I was using spring-cloud-dependencies:Hoxton.SR8, which pulls soring-cloud-stream:Horsham.SR8, which pulls spring-cloud-stream-binder-kafka-streams:3.0.8. Moving to Hoxton.SR9 brings Horsham.SR9 and 3.0.9.

Would these be updated with your fix, or should I update to SR9 or another release train version?

@mborgraeve The fixes are not released yet. They will be part of the next Horsham release train (Horsham.SR11). We can try to include that in Hoxton.SR10 of spring cloud. I will have to find out if/when a release for that is scheduled.
There will be an SR1 for 3.1.x line release (current master) coming up later this month which will be picked up by spring-cloud 2020.0.1 release, but that is using a different version of spring boot.

@mborgraeve The fixes are not released yet. They will be part of the next Horsham release train (Horsham.SR11). We can try to include that in Hoxton.SR10 of spring cloud. I will have to find out if/when a release for that is scheduled.
There will be an SR1 for 3.1.x line release (current master) coming up later this month which will be picked up by spring-cloud 2020.0.1 release, but that is using a different version of spring boot.


0.0.2 gem contains files with 0600 modes

$ curl -sO https://rubygems.org/downloads/omniauth-jwt-0.0.2.gem

$ gem unpack omniauth-jwt-0.0.2.gem
Unpacked gem: '/Users/richardc/src/omniauth-jwt-0.0.2'

$ find omniauth-jwt-0.0.2 -ls
8600003236        0 drwxr-xr-x   13 richardc         staff                 416 27 Mar 18:01 omniauth-jwt-0.0.2
8600003241        8 -rw-r--r--    1 richardc         staff                 236 27 Mar 18:01 omniauth-jwt-0.0.2/Guardfile
8600003238        8 -rw-rw-r--    1 richardc         staff                  26 27 Mar 18:01 omniauth-jwt-0.0.2/.rspec
8600003253        0 drwxr-xr-x    4 richardc         staff                 128 27 Mar 18:01 omniauth-jwt-0.0.2/spec
8600003258        8 -rw-rw-r--    1 richardc         staff                 906 27 Mar 18:01 omniauth-jwt-0.0.2/spec/spec_helper.rb
8600003254        0 drwxr-xr-x    3 richardc         staff                  96 27 Mar 18:01 omniauth-jwt-0.0.2/spec/lib
8600003255        0 drwxr-xr-x    3 richardc         staff                  96 27 Mar 18:01 omniauth-jwt-0.0.2/spec/lib/omniauth
8600003256        0 drwxr-xr-x    3 richardc         staff                  96 27 Mar 18:01 omniauth-jwt-0.0.2/spec/lib/omniauth/strategies
8600003257        8 -rw-------    1 richardc         staff                2423 27 Mar 18:01 omniauth-jwt-0.0.2/spec/lib/omniauth/strategies/jwt_spec.rb
8600003243        8 -rw-rw-r--    1 richardc         staff                3211 27 Mar 18:01 omniauth-jwt-0.0.2/README.md
8600003244        8 -rw-rw-r--    1 richardc         staff                 109 27 Mar 18:01 omniauth-jwt-0.0.2/Rakefile
8600003237        8 -rw-rw-r--    1 richardc         staff                 154 27 Mar 18:01 omniauth-jwt-0.0.2/.gitignore
8600003245        0 drwxr-xr-x    3 richardc         staff                  96 27 Mar 18:01 omniauth-jwt-0.0.2/lib
8600003246        0 drwxr-xr-x    5 richardc         staff                 160 27 Mar 18:01 omniauth-jwt-0.0.2/lib/omniauth
8600003248        0 drwxr-xr-x    3 richardc         staff                  96 27 Mar 18:01 omniauth-jwt-0.0.2/lib/omniauth/jwt
8600003249        8 -rw-rw-r--    1 richardc         staff                  61 27 Mar 18:01 omniauth-jwt-0.0.2/lib/omniauth/jwt/version.rb
8600003247        8 -rw-rw-r--    1 richardc         staff                  64 27 Mar 18:01 omniauth-jwt-0.0.2/lib/omniauth/jwt.rb
8600003250        0 drwxr-xr-x    3 richardc         staff                  96 27 Mar 18:01 omniauth-jwt-0.0.2/lib/omniauth/strategies
8600003251        8 -rw-------    1 richardc         staff                1552 27 Mar 18:01 omniauth-jwt-0.0.2/lib/omniauth/strategies/jwt.rb
8600003240        8 -rw-rw-r--    1 richardc         staff                  97 27 Mar 18:01 omniauth-jwt-0.0.2/Gemfile
8600003242        8 -rw-rw-r--    1 richardc         staff                1071 27 Mar 18:01 omniauth-jwt-0.0.2/LICENSE.txt
8600003239        8 -rw-rw-r--    1 richardc         staff                  63 27 Mar 18:01 omniauth-jwt-0.0.2/.travis.yml
8600003252        8 -rw-rw-r--    1 richardc         staff                1188 27 Mar 18:01 omniauth-jwt-0.0.2/omniauth-jwt.gemspec

The problematic file there is omniauth-jwt-0.0.2/lib/omniauth/strategies/jwt.rb.  It's 0600 which means if I install it as a system gem only the user who installed it can use it.
Could you ship a 0.0.3 with that permission corrected?  Thanks

Came here to upvote this issue.
Please, fix it.


Fishious Rend currently is not classified as a "biting move" in the damage calculator

This is important because of Dracovish's ability Strong Jaw, which boosts biting moves.  Fishious Rend is a biting move.
Please fix, because this is important to us Fish users!
Thanks for the awesome tool!

I was wrong, just kidding! I accidentally had it on the max move setting


Image generator failed request handling

A token is consumed before a bad request. Token usage should follow a successful response.
A failed request doesn't report to the channel - it fails silently.

Fixing in 0.11.1 - also noticed inconsistent application of awaits for Discord channel .send() and .reply() calls and fixed.

A token is now consumed at the start of the function, and refunded in the catch block.
catch block now has a catch-all for logging errors. Silly miss.

I had nested try/catch blocks in the _embedImageFromPromptMessage() function which was a mess to read. I cleaned it up into a single level, and the code is much tidier.


ECR-1164 Add flat proof

https://jira.bf.local/browse/ECR-1164

@dmitry-timofeev Thanks for your help! Sorry it took so long.
Spikes for design tasks are a great idea that could save quite some time in this case, I'm glad we are doing those now.


flutter downgrade to version

I have
Flutter 1.22.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision d408d302e2 (3 days ago) • 2020-09-29 11:49:17 -0700
Engine • revision 5babba6c4d
Tools • Dart 2.10.0
when I do
~ flutter downgrade
Downgrade flutter to version 1.20.1
? [y|n]
but the previous stable is 1.20.4
It would be nice to be able to specify the version to downgrade to. Especially in cases when flutter gets it wrong, but there may be other reasons too.

Hi @pvegh
Flutter does not support downgrade to a specific version. Please see the following for more info:
https://github.com/flutter/flutter/issues/63635#issuecomment-676654404

which channel are you using?

Flutter Version Manager might help!
https://medium.com/better-programming/discover-flutter-flutter-version-manager-fvm-411dc2bff4b4


[platform] Separate transport-related functions from platform.

Is your feature request related to a problem? Please describe.
Transport is an integral part of the platform.
All functions that initialize and process UART, SPI transport are currently called inside the platform-dependant implementation of the following functions:
otSysInit
otSysDeinit
otSysProcessDrivers
from the openthread-system.h header (located in examples/platforms).
NCP and CLI are using the implementation of transport functions from the platform library.
Describe the solution you'd like
The transport layer is separated from the platform and is linked to program in independent library:

UART, SPI initialization and process functions are called from the new system functions, for example:
otSysTransportInit
otSysTransportDeinit
otSysTransportProcessDrivers

In addition to otSysInit and otSysProcessDrivers, user calls otSysTransportInit and otSysTransportProcessDrivers to use UART/SPI transport in the application.

All transport-related functions are in separate precompiled library.

Transport headers (uart.h, spi-slave.h) are moved from include/openthread/platform to include/openthread/transport.

Describe alternatives you've considered
Moving transport to a new library does not have to be done for every platform.

@piotrkoziar, thank you for raising this issue.
For background, the otSys prefix denotes functions that are neither used nor provided by the OpenThread library. The otPlat prefix denotes functions that are used to interface between the OpenThread library and platform-specific code.
Can you explain further the motivation and rationale for separating out UART/SPI functions into a separate namespace and library? Also the motivation and rationale for moving transport-specific headers to include/openthread/transport?
Thanks.

@jwhui Thank you for your answer.
The idea is to eliminate the need for rebuilding of OpenThread platform libraries when modification of transport-related functions is required. In particular, the rebuild is unwanted when the OpenThread libraries has been already certified.
In other words, separating out UART/SPI functions into a separate library gives the freedom of defining the transport functions without changing the Thread certified stack.

@piotrkoziar, that makes sense to me. Thanks for the clarification!

@piotrkoziar, was this issue addressed by #4673 or are you going to propose more changes?

@jwhui #4673 implemented #4630 to some degree - transport-related functions are delivered in separated library.
However #4630 proposes further changes:

moving transport initialization and processing from system.c to application code (e.g. otSysTransportInit). As a result, the transport will be completely separated from the platform (and certified code).
moving headers with transport function declarations to separate folder.

Points above require modification of each platform code. I can try to prepare PR with proposed changes.

@piotrkoziar, thanks for the update.
Regarding moving headers to a separate folder, you had proposed include/openthread/transport, what about include/openthread/platform/transport give that these are platform APIs?

@jwhui Agree, that sounds reasonable.

@piotrkoziar , any updates on this effort?

@jwhui We are no longer interested in implementing this. The platform - transport relation as it is now is sufficient. Maybe in the future, there will be a good case for implementing this solution.


drivers/pipes: fix write busy loop because POLLOUT always ready.

Summary
drivers/pipes: fix write busy loop because POLLOUT always ready.
the size of pipes buffer +1 as compensate the full indicator
Signed-off-by: dongjiuzhu1<EMAIL_ADDRESS>Impact
fix write busyloop for local socket
Testing
vela ci

why close this PR, @Donny9 ?

why close this PR, @Donny9 ?

Sorry, let's use PR #8369.


Control Panel CSS is installed with schema version 1.0.0, but project.yaml expects 2.0.

Getting this error when installing craft with php craft setup.
$schemaVersion = $pluginRef->getProperty('schemaVersion')->getDefaultValue(); on line 1206 in craftcms/cms/src/migrations/Install.php always returns 1.0.0 but it expects 2.0.0 set in composer.
The default value of craft is 1.0.0 if there is no schemaVersion property set.
Adding the schemaVersion property in CpCSS.php fixes this.
/**

@var string The plugin’s schema version number
*/
public string $schemaVersion = '2.0.0';

Hi, thanks for reporting. I'm just a hair confused about the circumstances surrounding this error.
If you were installing a fresh copy of Craft, how did you already have CP CSS as part of the equation?

I cloned a starter project, where CP CSS was installed. Somehow this bug slipped in when updating Craft CMS on the starter.
Using php craft setup on a newly cloned project this occurs, because there craft is not installed yet.


[RFC] rbd: Add timers check for cluster osd

The rados osd op timeout must be longer than the timeouts to detect
unreachable OSDs (osd heartbeat grace + osd heartbeat interval) or
we will end up failing the transport connection when we just needed
to try a different OSD.
Signed-off-by: Xiubo Li<EMAIL_ADDRESS>

In timer_check_and_set_def is the use of atof needed or should it be am integer call like atol or atoi, etc?
I don't have easy access to the ceph code or docs so I was not sure if it is possible to do a float/double.

Sorry for late, yes from the ceph code we can see that the type of "rados_osd_op_timeout" is float, and i meant to s/atoi/atof, but just forgot to commit that change.


Fixed msi_isigw rebar.lock dependencies

Fixes issue with isgwte build:
make release
<snip>

Solved by other means


Types in Prelude not Shared in Gamefile

Types are not properly shared across the prelude and gamefile. When the prelude is parsed, the prelude's types are not included into the environment of the Gamefile, leading to some weird issues where types have to be redundantly declared (which should also lead to a parser error, but does not).
A patch is already in the works for this, and should be up later today.

Closed by #107


Update cron-parser from 4.2.0 to 4.2.1

Change-type: patch
Signed-off-by: Josh Bowling<EMAIL_ADDRESS>

@balena-ci I self certify!


Health check enabled instances stuck in "Initilaizing" state forever because of ip inject failure.

Tested with Rancher server - latest Build from master
Ros version - v0.4.4
Longhorn catalog template from - https://github.com/cjellick/longhorn-catalog (image - cjellick/longhorn:dev3)
Steps to reproduce the problem:
Create a service(health check enabled) with VM having ROOT Volumes in longhorn.
Once the VM has started , notice that  it is in "Unhealthy" state for a few seconds after which it gets deleted. A new instance then gets created , which starts successfully and gets to "healthy" state.
VM instance is in "unhealthy" state for a long time because ip injection failing:

"initializingTimeout" is set to 1 mt (60000 msec) for the VMs ( This is the default setting from UI).

The primary issue here is that the VM is not getting the IP all the time and possibly can get it after multiple retries.  If you increase the timeout, then it would take that much longer to recreate the VM.

Server version - Build from master
Longhorn controller image - rancher/longhorn:v0.1.0-rc1
3 ROS hosts with 108 GB memory.
Steps to reproduce the problem:
Start a VM service (rancher/vm-ubuntu:14.04) with ROOT and DATA disk (size=1 gb) in longhorn with health check enabled  with following health check configs:
"healthyThreshold": 2,
"initializingTimeout": 6000000,
"interval": 2000,
"name": null,
"port": 22,
"reinitializingTimeout": null,
"requestLine": null,
"responseTimeout": 2000,
"strategy": "recreate",
"unhealthyThreshold": 3,
},

Power down the host where the VM is running . When VM starts it gets stuck in "Initializing" state forever ( initializingTimeout set to 1 hour), since the VM did not get an Ip address.

mysql> select id,name,state,health_state,created,removed from instance where name like "%ui10%";
+-----+-------------------------------------------------------------------------+---------+--------------+---------------------+---------------------+
| id  | name                                                                    | state   | health_state | created             | removed             |
+-----+-------------------------------------------------------------------------+---------+--------------+---------------------+---------------------+
| 577 | longhorn_testui10_1                                                     | purged  | unhealthy    | 2016-05-13 18:46:05 | 2016-05-13 18:54:31 |
| 578 | volume-longhorn-testui10-1-062add9-root_controller_1                    | purged  | unhealthy    | 2016-05-13 18:46:08 | 2016-05-13 18:53:49 |
| 579 | volume-longhorn-testui10-1-062add9-root_replica_replica-binary_1        | purged  | NULL         | 2016-05-13 18:46:08 | 2016-05-13 18:53:39 |
| 580 | volume-longhorn-testui10-1-062add9-root_controller_controller-agent_1   | purged  | NULL         | 2016-05-13 18:46:11 | 2016-05-13 18:53:49 |
| 585 | volume-longhorn-testui10-1-062add9-root_replica_1                       | purged  | unhealthy    | 2016-05-13 18:46:29 | 2016-05-13 18:53:41 |
| 586 | volume-longhorn-testui10-1-062add9-root_replica_replica-healthcheck_1   | purged  | NULL         | 2016-05-13 18:46:32 | 2016-05-13 18:53:40 |
| 587 | volume-longhorn-testui10-1-062add9-root_replica_sync-agent_1            | purged  | NULL         | 2016-05-13 18:46:33 | 2016-05-13 18:53:41 |
| 588 | volume-longhorn-testui10-1-062add9-root_replica_replica-binary_2        | stopped | NULL         | 2016-05-13 18:46:34 | NULL                |
| 593 | volume-longhorn-testui10-1-062add9-root_replica_2                       | running | healthy      | 2016-05-13 18:46:59 | NULL                |
| 594 | volume-longhorn-testui10-1-062add9-root_replica_replica-healthcheck_2   | running | NULL         | 2016-05-13 18:47:02 | NULL                |
| 595 | volume-longhorn-testui10-1-062add9-root_replica_sync-agent_2            | running | NULL         | 2016-05-13 18:47:02 | NULL                |
| 599 | volume-longhorn-testui10-1-062add9-mydata_controller_1                  | purged  | unhealthy    | 2016-05-13 18:47:30 | 2016-05-13 18:54:07 |
| 600 | volume-longhorn-testui10-1-062add9-mydata_replica_1                     | purged  | unhealthy    | 2016-05-13 18:47:30 | 2016-05-13 18:53:13 |
| 601 | volume-longhorn-testui10-1-062add9-mydata_controller_controller-agent_1 | purged  | NULL         | 2016-05-13 18:47:34 | 2016-05-13 18:54:07 |
| 602 | volume-longhorn-testui10-1-062add9-mydata_replica_replica-healthcheck_1 | purged  | NULL         | 2016-05-13 18:47:34 | 2016-05-13 18:53:12 |
| 603 | volume-longhorn-testui10-1-062add9-mydata_replica_sync-agent_1          | purged  | NULL         | 2016-05-13 18:47:35 | 2016-05-13 18:53:13 |
| 604 | volume-longhorn-testui10-1-062add9-mydata_replica_2                     | running | healthy      | 2016-05-13 18:47:36 | NULL                |
| 605 | volume-longhorn-testui10-1-062add9-mydata_replica_replica-healthcheck_2 | running | NULL         | 2016-05-13 18:47:40 | NULL                |
| 606 | volume-longhorn-testui10-1-062add9-mydata_replica_sync-agent_2          | running | NULL         | 2016-05-13 18:47:41 | NULL                |
| 609 | longhorn_testui10_1                                                     | running | initializing | 2016-05-13 18:52:26 | NULL                |
| 618 | volume-longhorn-testui10-1-062add9-root_replica_replica-binary_1        | stopped | NULL         | 2016-05-13 18:52:42 | NULL                |
| 620 | volume-longhorn-testui10-1-062add9-mydata_replica_1                     | purged  | initializing | 2016-05-13 18:52:44 | 2016-05-13 18:53:23 |
| 625 | volume-longhorn-testui10-1-062add9-mydata_replica_replica-healthcheck_1 | purged  | NULL         | 2016-05-13 18:52:57 | 2016-05-13 18:53:45 |
| 631 | volume-longhorn-testui10-1-062add9-mydata_replica_sync-agent_1          | purged  | NULL         | 2016-05-13 18:52:57 | 2016-05-13 18:53:45 |
| 633 | volume-longhorn-testui10-1-062add9-root_replica_1                       | running | healthy      | 2016-05-13 18:52:59 | NULL                |
| 636 | volume-longhorn-testui10-1-062add9-root_controller_1                    | running | healthy      | 2016-05-13 18:53:09 | NULL                |
| 638 | volume-longhorn-testui10-1-062add9-root_replica_replica-healthcheck_3   | running | NULL         | 2016-05-13 18:53:24 | NULL                |
| 640 | volume-longhorn-testui10-1-062add9-root_replica_sync-agent_3            | running | NULL         | 2016-05-13 18:53:25 | NULL                |
| 648 | volume-longhorn-testui10-1-062add9-root_controller_controller-agent_1   | running | NULL         | 2016-05-13 18:53:41 | NULL                |
| 651 | volume-longhorn-testui10-1-062add9-mydata_replica_1                     | running | healthy      | 2016-05-13 18:53:45 | NULL                |
| 655 | volume-longhorn-testui10-1-062add9-mydata_replica_replica-healthcheck_1 | running | NULL         | 2016-05-13 18:53:52 | NULL                |
| 658 | volume-longhorn-testui10-1-062add9-mydata_replica_sync-agent_1          | running | NULL         | 2016-05-13 18:53:53 | NULL                |
| 660 | volume-longhorn-testui10-1-062add9-mydata_controller_1                  | running | healthy      | 2016-05-13 18:54:02 | NULL                |
| 661 | volume-longhorn-testui10-1-062add9-mydata_controller_controller-agent_1 | running | NULL         | 2016-05-13 18:54:06 | NULL                |
+-----+-------------------------------------------------------------------------+---------+--------------+---------------------+---------------------+
34 rows in set (0.01 sec)

Tested with Rancher server - v1.1.0-dev2-rc2
Ros version - v0.4.5
Longhorn catalog template from -  rancher/longhorn:v0.1.0-rc4
rancher/vm-net:v0.2.0
When health-check enabled instances get HA-ed ,sometimes the new VMs do not get Ip address assigned to them as part of dooting up. But they get assigned an Ip eventually , after about 5 mts.
Following are the errors seen in  dhcp service logs relating to 1 such Ip assignment that took very long time:
 5/14/2016 7:14:42 PMoption:dns-server,<IP_ADDRESS>
5/14/2016 7:14:42 PM2016/05/15 02:14:42 Sending SIGHUP to dnsmasq
5/14/2016 7:14:42 PMdnsmasq: read /etc/hosts - 7 addresses
5/14/2016 7:14:42 PMdnsmasq-dhcp: read /tmp/dnsmasq-hosts382119233
5/14/2016 7:14:42 PMFirst:  false
5/14/2016 7:14:42 PMdnsmasq-dhcp: read /tmp/dnsmasq-opts402415532
5/14/2016 7:14:55 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:14:55 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:14:58 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:14:58 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:15:03 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:15:03 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:15:17 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:15:17 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:15:36 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:15:36 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:15:49 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:15:49 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:15:59 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:15:59 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:16:09 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:16:09 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:16:26 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:16:26 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:16:34 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:16:34 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:16:51 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:16:51 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:17:05 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:17:05 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:17:24 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:17:24 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:17:40 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:17:40 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:17:52 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:17:52 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:18:05 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:18:05 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:18:24 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:18:24 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:18:30 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:18:30 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:18:46 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:18:46 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:18:55 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:18:55 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:19:16 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:19:16 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:19:34 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:19:34 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:19:55 PMdnsmasq-dhcp: not using configured address <IP_ADDRESS> because it is leased to 02:b1:f6:49:77:fb
5/14/2016 7:19:55 PMdnsmasq-dhcp: DHCPDISCOVER(eth0) <IP_ADDRESS> 02:b1:f6:8e:dc:a3 no address available
5/14/2016 7:20:03 PM2016/05/15 02:20:03 New Configuration
5/14/2016 7:20:03 PM02:b1:f6:9a:d6:cb,ip-10-42-150-13.compute.internal,<IP_ADDRESS>,infinite
5/14/2016 7:20:03 PM02:b1:f6:8e:dc:a3,ip-10-42-162-239.compute.internal,<IP_ADDRESS>,infinite
5/14/2016 7:20:03 PMoption:router,<IP_ADDRESS>
5/14/2016 7:20:03 PMoption:netmask,<IP_ADDRESS>
5/14/2016 7:20:03 PMoption:dns-server,<IP_ADDRESS>
5/14/2016 7:20:03 PM2016/05/15 02:20:03 Sending SIGHUP to dnsmasq
5/14/2016 7:20:03 PMdnsmasq: read /etc/hosts - 7 addresses
5/14/2016 7:20:03 PMFirst:  false
5/14/2016 7:20:03 PMdnsmasq-dhcp: read /tmp/dnsmasq-hosts382119233
5/14/2016 7:20:03 PMdnsmasq-dhcp: read /tmp/dnsmasq-opts402415532

Tested with rancher-server version - v1.1.0-dev2-rc3
longhorn version - rancher/longhorn:v0.1.0
When health-check enabled instances get HA-ed ,and  new VMs land on the same host (that they were on at some point) Ip assignment happens as soon as the VM boots.


Support running as symlink?

I like to do e.g. jean@X1:~/.local/bin$ ln -s ~/Downloads/structurizr/structurizr.sh so that the command is on my path.
This fails with the current script. The following works, but I don't know if it works in all the same places as BASH_SOURCE:
diff --git a/etc/structurizr.sh b/etc/structurizr.sh
index a87c6e8..317fdd8 100755
--- a/etc/structurizr.sh
+++ b/etc/structurizr.sh
@@ -1,3 +1,3 @@
 #!/bin/bash
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+SCRIPT_DIR="$( cd "$( dirname "$(readlink -f "$0")" )" >/dev/null 2>&1 && pwd )"
 java -jar $SCRIPT_DIR/structurizr-cli-1.11.0.jar "$@"

(I'd actually prefer to do stow structurizr (ref) but that works best if the zip contents look like structurizr/{bin,doc,...}.)

I have been running into the same issue a few times in the past so I would welcome a change that allows symlinking the .sh script out of the box.

I'm not a *nix expert I'm afraid, and have tried a few things, but didn't find anything that worked across multiple platforms (e.g. readlink -f doesn't work on my Mac, but readlink does). If you have an example of something that works, please do share. Otherwise, it might be easier to create your own script ... all you need to do is start a named Java application (com.structurizr.cli.StructurizrCliApplication) with parameters.


Dead plant has no plant, can't be burned: "execution reverted: Land had no Plant"

Display from "visiting my plant" shows dead plant: This plant is dead!
I tried to burn it. Maybe it failed once? Every time I try to burn now:
"execution reverted: Land had no Plant"

If this happens, it is possible to "fix" state by going to the plant contract and calling burn(id, yourAddress) directly to clean it up.

Can still plant a new plant on the land but then loading the land shows the old plant.

Also now this different error:
    "code": -32603,
    "message": "Internal JSON-RPC error.",
    "data": {
        "code": 3,
        "message": "execution reverted",
        "data": "0x82b42900"
    }
}```

I think it's a bug in `clearPlanted`.


add zerolog and structured logging

added context and put logger in the context. Useful for future with tracing/correlationIDs, etc...


AmbiguousMatchException in Html.TextBox() when model has shadowed properties

Calling Html.TextBox() for a property that is shadowing an inherited property, a AmbiguousMatchException exception is thrown.
For example, the following setup will generate the error:
Models.cs
namespace Test
{
    public class SearchBase
    {
        public string Search { get; set; }
    }

    public class SearchModel : SearchBase
    {
        public new int Search { get; }
    }
}

Index.cshtml
@model Test.SearchModel

@Html.TextBox("Search")

HomeController.cs
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;

namespace Test
{
    public class HomeController : Controller
    {
        public IActionResult Index()
        {
            var model = new SearchModel();

            return View(model);
        }
    }
}

Generates the following exception:
System.Reflection.AmbiguousMatchException: Ambiguous match found.
   at System.RuntimeType.GetPropertyImpl(String name, BindingFlags bindingAttr, Binder binder, Type returnType, Type[] types, ParameterModifier[] modifiers)
   at System.Type.GetProperty(String name, BindingFlags bindingAttr)
   at System.Reflection.RuntimeReflectionExtensions.GetRuntimeProperty(Type type, String name)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataEvaluator.GetPropertyValue(Object container, String propertyName)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataEvaluator.InnerEvalComplexExpression(Object indexableObject, String expression)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataEvaluator.EvalComplexExpression(Object indexableObject, String expression)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.ViewDataEvaluator.Eval(ViewDataDictionary viewData, String expression)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ExpressionMetadataProvider.FromStringExpression(String expression, ViewDataDictionary viewData, IModelMetadataProvider metadataProvider)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.DefaultHtmlGenerator.AddPlaceholderAttribute(ViewDataDictionary viewData, TagBuilder tagBuilder, ModelExplorer modelExplorer, String expression)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.DefaultHtmlGenerator.GenerateInput(ViewContext viewContext, InputType inputType, ModelExplorer modelExplorer, String expression, Object value, Boolean useViewData, Boolean isChecked, Boolean setId, Boolean isExplicitValue, String format, IDictionary`2 htmlAttributes)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.DefaultHtmlGenerator.GenerateTextBox(ViewContext viewContext, ModelExplorer modelExplorer, String expression, Object value, String format, Object htmlAttributes)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.GenerateTextBox(ModelExplorer modelExplorer, String expression, Object value, String format, Object htmlAttributes)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.HtmlHelper.TextBox(String expression, Object value, String format, Object htmlAttributes)
   at Microsoft.AspNetCore.Mvc.Rendering.HtmlHelperInputExtensions.TextBox(IHtmlHelper htmlHelper, String expression)
   at AspNetCore._Views_Home_Index_cshtml.<ExecuteAsync>d__0.MoveNext() in C:\Users\Phil\AmbiguousMatchExceptionMvc\Views\Home\Index.cshtml:line 3
--- End of stack trace from previous location where exception was thrown ---

Hi @neoGeneva , we decided a while ago to not support shadowed properties: https://github.com/aspnet/Mvc/issues/4646#issuecomment-219521703
It's not a common scenario and not recommended in general, so we chose not to support it. It introduces many complexities to the whole system and the system just wasn't designed for it.

Hey @Eilon, thanks for letting me know, but if that is the case then surely are more relevant exception should be thrown?
The "AmbiguousMatchException" doesn't really info necessary to fix the problem, it took me a little while to figure out exactly what was going on.

@neoGeneva this is a fairly rare case, so we just haven't invested much time or effort into it, including error cases. If you can propose a fix for this it's something we'd consider taking.

Hey @Eilon, that makes sense.
Maybe something to revisit if more people raise the same issue, and even the the solution might be just to add something to the docs to mention that shadowed properties aren't supported, just so there's something more specific to point to.


Setup Tasking Manager

We're going to migrate the current tasking manager instance into the OHM infrastructure. Thanks to Bert for the database dump. Here's a quick summary of what we'll do:

[x] Migrate the database to work with TM4
[ ] Add TM4 into osm-seed, and make that available on OHM
[ ] Import the database dump
[ ] Setup SSL
[ ] Deploy

I'll use this ticket for tracking progress.
cc @batpad @jeffreyameyer @danrademacher

I've pushed a mirror of the customized old TM here https://github.com/OpenHistoricalMap/tasking-manager-deprecated/tree/develop -- will now create a fresh fork of TM4.
TM4 recently merged some changes that we worked on to allow for OSM environment customizations https://github.com/hotosm/tasking-manager/pull/3564

@geohacker - what's the status of this ticket?

@geohacker - what's the status of this ticket?

all is working at:
http://tasks.openhistoricalmap.org/
and
https://tasks-staging.openhistoricalmap.org/


Add cmd acceptance tests

I probably won't have time to even start these any time soon but it would be nice to have some tests that involve actually hitting a dummy AWS account. Primarily as a sanity-check before releases, however if AWS wants to donate a small account we could use it for CI as well.

if AWS wants to donate a small account we could use it for CI as well

<3


No first use

Several things don't work while pending first use. Work-around to get things working is to manually create /var/luna/preferences/ran-first-use and reboot

Fix is to build qtbase_git with "-qpa wayland" instead of "-qpa wayland-git". Will push a bbappend soon.

Fixed


Disconnect

  /Users/gregor/JavaScripts/hood.ie/pouchdb-hoodie-sync/lib/disconnect.js:7:1: Mixed spaces and tabs.
  /Users/gregor/JavaScripts/hood.ie/pouchdb-hoodie-sync/lib/disconnect.js:7:4: Expected indentation of 4 characters.
  /Users/gregor/JavaScripts/hood.ie/pouchdb-hoodie-sync/lib/disconnect.js:9:1: Trailing spaces not allowed.
  /Users/gregor/JavaScripts/hood.ie/pouchdb-hoodie-sync/tests/specs/disconnect.js:21:1: Trailing spaces not allowed.

:)


[Bug Report]: node:resized 事件说明缺失

发生了什么？

目前文档中“事件”部分缺少 node:resized 事件的相关说明，搜索也无法查到。
仅有 “插件 => 节点缩放（NodeResize）” 这部分有相关内容，但是该部分内容具有即将废弃的tag，并且事件回调参数也不对。望完善。
logicflow/core版本
2.0.1
logicflow/extension版本
2.0.1
logicflow/engine版本
No response
浏览器&环境
No response

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


Add DMs on infractions

DM_ON_ACTIONS

Seems like I used user instead of target, will fix in a good hour


Windup report comparison test

This adds a new subcommand to run windup and analyzer both with a test application and compare results of the analysis and print.

Lurk to


Custom without formula

Not really an issue, but i was wondering if there was a way to have points set to whatever I want without it needing to be formula based?
The points I want to use do not scale based on any current measure and it all custom

it is not clear for me if you are talking about the formula to calculate how many spell points a character get from it's class or lever, or the formula to calculate the spell point cost for each slot when you cast a spell..
you can ignore the automatic spell point calculation when your character level up and set the number od spell points to anything you want directly editing the resource.
and about of the cost in spell point for each spell level it can be anything, you can set it to 100 for first level spells and 54 for 9th level spells..
can you give me an exhample?


Sort JSON keys of integration test snapshots

Sometimes PR diffs reorder CFN template snapshots without any functional change. We should store the snapshots with sorted JSON keys to avoid noisy diffs.

No longer needed as we have replaced the snapshot tests with the cdk assertions library


Support decoding timeseries Thresholds from YAML

https://github.com/K-Phoen/grabana/blob/092b4d3027b029893ffdba61d2933fd42845185d/timeseries/timeseries.go#L270-L277

Feel free to contribute :)


Copy Paste

ready to merge
This adds support for copy-pasting content from one Content Kit to another, and from Google Docs to Content-Kit.

Rename PostParser -> DOMParser, remove old DOMParser

Add HTMLParser (parses from HTML to PostAbstract)

Add many fixtures with example HTML from copying in a google doc document

Add postEditor#insertPost. It inserts the sections from a post into the current editor's post at the passed Position, with some logic for merging/inserting into the section with the cursor in it. It returns a Position used to position the cursor after inserting content

Only allow certain attributes from parsed content (currently only "href" and "rel" are acceptable attributes. These are defined in Markup's VALID_ATTRIBUTES)

[x] support for pasting multi-section copy data

[x] support for pasting unstructured HTML

[x] lock down allowed element attributes when parsing HTML

For a separate PR:

[ ] support for copying non-markerable sections like cards (and list sections)
[ ] parse lists properly from HTML. They currently cause a MarkupSection with tagName "li" to be created, but we want them to cause a ListSection and ListItem(s) to be created instead.

For later:

[ ] Add the ability to handle more exotic pasted data, such as images.

fixes #111

Many tests added for parsing google-docs-style copy/pasted HTML

Lookin' pretty sweet @bantic :-) :-) :-) :-) :-)

@mixonic Ready for :eyeglasses: when you can.

If you're curious to see what the HTML result of copy/pasting something from Google docs looks like, you can use this tool to see it.

needs to handle "cut" in addition to "copy" event


test: adjust RepositoryServiceTest.testInvalidBranch

The GHFileNotFoundException message has been changed and therefore
the test validation needs to be adjusted.
Also switch from pull_request_target to pull_request, because the
pull_request_target trigger runs on the main branch context, so it
won't verify the actual changes in the pull request.
Therefore, re-open the issue #378.

@heubeck we would need to force-merge this one, because currently the pull_request_target one will always fail.


string "/eureka" should match pattern "/eureka/*" or "/eureka/**"

Enhance TracePathMatcher, "/eureka/*" or "/eureka/**" can match "/eureka".

After my test, AntPathMatcher do not match this rule.
AntPathMatcherAntPathMatcher().match("/eruka/*", "/eruka") // false

If this does follow ant path match, I have concerns about this, whether this us reasonable.

If this does follow ant path match, I have concerns about this, whether this is reasonable.

@wu-sheng /eureka/** matches /eureka, but /eureka/* not.

OK, got your point. Both should support.

I just want to ask, whether 2 configs make more sense than supporting this kind of config? After all, /* means at least having a /.
My concern is about this.

Is there other tools supporting in this way?

@wu-sheng
No, I means the current behavior of AntPathMatcher is /eureka/** matches /eureka, but /eureka/* not.

I am don't sure my FastPathMatcher's behavior, I will get test for it.

There are my test result, use 'AntPathMatcher/FastPathMatcher'
matches("/eureka/*", "/eureka") = false/false
matches("/eureka/*", "/eureka/") = true/true
matches("/eureka/*", "/eureka/test/") = false/true
matches("/eureka/*", "/eureka/test") = true/true
matches("/eureka/*/", "/eureka") = false/false
matches("/eureka/*/", "/eureka/") = true/false
matches("/eureka/*/", "/eureka/test") = false/false
matches("/eureka/*/", "/eureka/test/") = true/true
matches("/eureka/**", "/eureka") = true/false
matches("/eureka/**", "/eureka/") = true/true
matches("/eureka/**", "/eureka/test/") = true/true
matches("/eureka/**", "/eureka/test") = true/true
matches("/eureka/**/", "/eureka") = true/false
matches("/eureka/**/", "/eureka/") = true/true
matches("/eureka/**/", "/eureka/test") = true/true
matches("/eureka/**/", "/eureka/test/") = true/true

Highlights for diff
matches("/eureka/*", "/eureka/test/") = false/true
matches("/eureka/*/", "/eureka/") = true/false
matches("/eureka/**", "/eureka") = true/false
matches("/eureka/**/", "/eureka") = true/false

Are these diff from previous or PR version?

The diff is about Spring's AntPathMatcher between my FastPathMatcher in current production version of skywalking.
I am not compare the PR version.

By comparison, FastPathMatcher seems more intuitive?
Case 1:
/eureka/* vs /eureka/test/

means zero or one path part, but a path part may have ends with / or not.

Case 2:
/eureka/*/ vs /eureka/

means zero or one path part, but if it means zero, the path should be /eureka//, can we omit the double /?

Case 3:
/eureka/** vs /eureka
/** means at least one /
Case 4:
/eureka/**/ vs /eureka
**/ means path should ends with /

I feel like the current version is good. I am not sure why Spring works in a different way.

Spring's AntPathMatcher is copy from Apache Ant.

@xjs1919 Please update with us, why do you think this behavior makes sense?

@xjs1919 Please update with us, why do you think this behavior makes sense?

i want to ignore path contains "actuator", so i have to config like this :
trace.ignore_path=${SW_AGENT_TRACE_IGNORE_PATH:/actuator/,GET:/actuator}
it works, however a little redundant and not graceful，and Spring's AntPathMatcher can match "/eureka" with pattern "/eureka/**"

I am not sure why AntPathMatcher works like that, but to be honest, I don't think it is the standard.
/eureka/** ignoring /eureka seems unreasonable. Maybe Spring team has their reasons, but logically, this is right.

Closing due to support @devkanro 's opinion(original author)


feat: improve handling aria props

What is motivation for this changes?

What is motivation for this changes?

@ogonkov https://github.com/gravity-ui/uikit/issues/1929


Research dead reckoning in ground transport applications

Trackcycle currently isn't as intelligent with dead reckoning as I think it could be. The problem is that it's mostly just checking to see if the angle between its last known trajectory and current trajectory is big enough.
This issue is not necessarily to implement any changes, but rather to research whether dead reckoning is used for longer off duty cycles in ground based transportation without set paths (like cars). Many of these likely also use gyroscope, accelerometer, and/or magnetosphere readings (although I didn't see many tapping into magnetometer readings when I initially worked on this).

The application of dead reckoning to bicycles in particular seems to be sparse. There is some academic interest in using inertial dead reckoning for estimating pedestrian location (pedestrian dead reckoning, PDR) and supporting localization for autonomous vehicles, especially underwater and in flight. Some of these could be applicable here. There is a lot of mention of the Kalman filter, so that is probably a topic that needs to come back into the spotlight here. Regardless, I think the following papers about dead reckoning could be useful:

[ ] Body-Centered Dynamically-Tuned Error-State Extended Kalman Filter for Visual Inertial Odometry in GNSS-Denied Environments
[ ] Self-Contained Pedestrian Navigation Fusing ML-Selected GNSS Carrier Phase and Inertial Signals in Challenging Environments
[ ] Seamless Mobile Indoor Navigation With VLP-PDR
[ ] Design of a 2D/3D Positioning System and Its Real-Time Application With Low-Cost Sensors

Furthermore, here are a couple of papers to read on Kalman filtering:

[ ] An Introduction to the Kalman Filter
[ ] Kalman Filtering
[ ] Tutorial: The Kalman Filter.
[ ] Introduction to Kalman Filter and Its Applications

And finally, some about odometry in general:

[ ] Accurate Relative Localization Using Odometry
[ ] Accurate Odometry and Error Modelling for a Mobile Robot

As a note, a lot of the odometry papers are talking about visual odometry, which uses cameras to determine egomotion. This is irrelevant for us. We want gyroscopic and inertial odometry.
Another note, many sources on dead reckoning use encoder signals attached to wheels as a data source. We could think about that, but that's not an option right now.

There's a good chance I'm going to need to do some research on statistical concepts and some review of linear algebra concepts before I can actually start to understand Kalman filters again, which is sort of a prerequisite to understanding anything meaningful with the PDR estimation.


aya: fix tc name limit

The buffer for attributes should be sized to hold at least 256 bytes, based on CLS_BPF_NAME_LEN = 256 from the kernel:
https://github.com/torvalds/linux/blob/02aee814/net/sched/cls_bpf.c#L28
This pull request also includes integration tests with an eBPF program of type classifier with a 256-byte-long name.
Fixes: #610

I'm happy with the change to up the buffer to the next nearest power of 2.
Tamir's comments need addressing before merge.

@pooladkhay ping?

@pooladkhay ping?

@alessandrod  pong! 😃
Life hasn't been easy lately, I should have notified earlier.
I'll get back to this asap, please let it be open...

@pooladkhay ping?

@alessandrod pong! 😃
Life hasn't been easy lately, I should have notified earlier. I'll get back to this asap, please let it be open...

hugs ❤ and sorry if I made you feel rushed it wasn't my intention

@pooladkhay ping?

@alessandrod pong! 😃
Life hasn't been easy lately, I should have notified earlier. I'll get back to this asap, please let it be open...

hugs ❤ and sorry if I made you feel rushed it wasn't my intention

No worries at all 🙋♂

Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @alessandrod, @dave-tucker, and @pooladkhay)

test/integration-test/src/tests/load.rs line 19 at r2 (raw file):

#[test]
fn tc_name_limit() {

Looks like these tests are failing:
failures:

---- tests::load::tc_name_limit stdout ----
thread 'tests::load::tc_name_limit' panicked at test/integration-test/src/tests/load.rs:31:32:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- tests::load::tc_name_limit_exceeded stdout ----
thread 'tests::load::tc_name_limit_exceeded' panicked at test/integration-test/src/tests/load.rs:60:32:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

It's the qdisc_add_clsact("lo").unwrap(); calls that seem to be failing.

That's true,
Two commands are being used to run the tests:
cargo xtask integration-test local which succeeds, and cargo xtask integration-test vm <KERNEL_IMAGE> which is the faulty one. Running it on my local machine fails too.
Is it possible that the loop back interface which I'm trying to attach an eBPF program to, is not available on that image?

Reviewed 7 of 7 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alessandrod, @dave-tucker, and @pooladkhay)

test/integration-test/src/tests/load.rs line 19 at r2 (raw file):
Previously, pooladkhay (Mohammad Javad Pooladkhay) wrote…
Yep, seems likely that it is not available. Can we create a network namespace so that we aren't reliant on ambient resources?

Could you please give me more hints, and maybe an example?

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alessandrod, @dave-tucker, and @pooladkhay)

test/integration-test/src/tests/load.rs line 19 at r2 (raw file):
Previously, pooladkhay (Mohammad Javad Pooladkhay) wrote…

Could you please give me more hints, and maybe an example?

See
https://github.com/aya-rs/aya/blob/b1769678f48f7abf6c987a1d686bbaffd5d1e664/test/integration-test/src/tests/xdp.rs#L137

I tried that. Namespace is created but the test still fails with the same error:
test tests::load::tc_name_limit ... Entered network namespace aya-test-168-0
thread 'tests::load::tc_name_limit' panicked at test/integration-test/src/tests/load.rs:623:32:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Exited network namespace aya-test-168-0
FAILED

I wonder what is the purpose of this step in testing?
What is the main difference between cargo xtask integration-test vm and cargo xtask integration-test local if the tests are running on a linux machine?
Is this related to kernel versions? maybe being able to test on a specific version?
I took a look and the CI file and realised runs-on: ubuntu-22.04 is set at the top but there are also checks like this one: if: runner.os == 'macOS'.
Considering those checks checking runner.os, maybe  cargo xtask integration-test vm is used in a scenario where the runner is not a linux image?
If that's the case, I'm unable to make sense of it because of runs-on: ubuntu-22.04.
Or maybe I'm missing something here...


fix: update datetime gcf

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Received an offline approval from Camie


Create LICENSE

Close #1 .

This software for me has been particularly useful,  and I really appreciate your generosity in sharing it with this license.
Best regards,
Brian


K3S-SERVER-CA internal certificate is expired today (4 JUN 2021). All ranchers becomes unavailable

Hello, guys,
looks like today 4 jun 2021 expired your internal certificate for Rancher k3s API Server which works on https://<IP_ADDRESS>:6443 inside Rancher container.
Our Rancher version is 2.4.3 and we also see this problem on higher versions f.e. on 2.4.15.
Restarting and recreating of new Rancher image from scratch with full images cleaning does not helps.
Looks like this certificate hardcoded some where in this Rancher image.
To view problem you can run inside Rancher container:
sh-4.4# curl --insecure -vvI https://<IP_ADDRESS>:6443
* Rebuilt URL to: https://<IP_ADDRESS>:6443/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 6443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS Unknown, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Unknown (8):
* TLSv1.3 (IN), TLS Unknown, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Request CERT (13):
* TLSv1.3 (IN), TLS Unknown, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS Unknown, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS Unknown, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Client hello (1):
* TLSv1.3 (OUT), TLS Unknown, Certificate Status (22):
* TLSv1.3 (OUT), TLS handshake, Certificate (11):
* TLSv1.3 (OUT), TLS Unknown, Certificate Status (22):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: O=k3s; CN=k3s
*  start date: Oct 15 09:07:59 2019 GMT
*  expire date: Jun  4 12:35:47 2021 GMT <---------------------------------------------!!!!!!!!!!!! Expired !!!!!!!!!!!!
*  issuer: CN=k3s-server-ca@1571130479
*  SSL certificate verify result: unable to get local issuer certificate (20), continuing anyway.
* TLSv1.3 (OUT), TLS Unknown, Unknown (23):
> HEAD / HTTP/1.1
> Host: <IP_ADDRESS>:6443
> User-Agent: curl/7.58.0
> Accept: */*
>
* TLSv1.3 (IN), TLS Unknown, Certificate Status (22):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS Unknown, Unknown (23):
< HTTP/1.1 401 Unauthorized
HTTP/1.1 401 Unauthorized
< Content-Type: application/json
Content-Type: application/json
< Www-Authenticate: Basic realm="kubernetes-master"
Www-Authenticate: Basic realm="kubernetes-master"
< Date: Fri, 04 Jun 2021 16:59:13 GMT
Date: Fri, 04 Jun 2021 16:59:13 GMT
< Content-Length: 165
Content-Length: 165

We also find /var/lib/rancher/k3s/server/tls/server-ca.crt certificate, and it expiration date is 12 Oct 2029, but it looks like this cert file is not applied to k3s API configuration on container startup, and k3s uses old certificate from etcd or some other source.
Please, tell us,
how to apply this certificate (/var/lib/rancher/k3s/server/tls/server-ca.crt) to k3s API cluster and replace old one?

We rollback time on hosted VM to be able to connect to k3s cluster and replaced there k3s-serving in kube-system namespace  secret (PEM & Key parts) with new values from /var/lib/rancher/k3s/server/tls/server-ca.key and pem files. (Pem you can generate by joining .crt with .key files together)

@fzendron
You must to login to the host with rancher container via ssh.
Change date on the date before certificate expiration.
Enter to the rancher container with command:
docker exec -it rancher /bin/bash
Change certificate in the secret k3s.
Show current secret you can with command:
kubectl get secret k3s-serving -n kube-system
We take certificates from /var/lib/rancher/k3s/server/tls
Delete old secret:
kubectl delete secret k3s-serving -n kube-system
Add new secret:
kubectl create secret tls my-tls-secret --cert=/var/lib/rancher/k3s/server/tls/server-ca.crt --key=/var/lib/rancher/k3s/server/tls/server- ca.key
Then logout rancher container and set the current date.
Rancher container must restart.


Fix the localisation code

The localisation for special characters still doesn't work perfectly.  It is capable of reading special characters in the save file pathway, but not within the configuration file.

If #461 update looks like it solved it, this issue could be closed.

I'm not sure it did - I'm honestly getting confused but I think this is actually a frontend issue (the whole special characters in filenames not working problem.


Change version commit message

The Dofus release title is alway changing. I'd like to fix it once for all. Use latest english title in rss.

Closed via #39 - Use VERSION file to get the version number


[Fix] Custom review items set not working

Problema:
Usando la preferencia:
ReviewScreenPreference reviewScreenPreference = new ReviewScreenPreference.Builder()
                ...
                .setItemsReview(pagofacilReview)
                ...
                .build();

Debería verse:

Y se ve:

Codecov Report

:exclamation: No coverage uploaded for pull request base (v3@f005bd8). Click here to learn what that means.
The diff coverage is 0%.

@@          Coverage Diff          @@
##             v3     #567   +/-   ##
=====================================
  Coverage      ?   25.19%
=====================================
  Files         ?      199
  Lines         ?    15307
  Branches      ?     1366
=====================================
  Hits          ?     3856
  Misses        ?    11034
  Partials      ?      417

Impacted Files
Coverage Δ

...dopago/providers/ReviewAndConfirmProviderImpl.java
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f005bd8...8bb7e47. Read the comment docs.


[Snyk] Security upgrade aiohttp from 3.8.6 to 3.9.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

requirements.txt

⚠ Warning
datasets 2.13.2 has requirement dill<0.3.7,>=0.3.0, but you have dill 0.3.7.

Vulnerabilities that will be fixed
By pinning:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity

661/1000  Why? Recently disclosed, Has a fix available, CVSS 7.5
Infinite loop SNYK-PYTHON-AIOHTTP-6808823
aiohttp:  3.8.6 -> 3.9.4
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@rultor merge

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 12min)


all output in a single line for xxd -ps -c0

It can be useful to have xxd output in plain hexdump style result
in a single line (i.e., POSIX text) without additional newlines.
Support this use case by specifying a column width of 0 (-cols 0).
For input data of less than or equal to LONG_MAX bytes, giving
-cols $LONG_MAX can be used.  Using -cols 0 removes this size
limit.
On POSIX compatible systems, alternatively the output of xxd -ps
could be piped through tr -d '\n', which removes all newlines
(this is no longer POSIX text), and then a newline could be appended,
e.g.:
$ { xxd -ps INPUT | tr -d '\n'; echo; } | wc -l
1

But this seems to be cumbersome to me, and xxd supports non-POSIX
platforms, too, where this does not work.
I sent a slightly different patch without any tests in May 2018[1],
but was asked to provide a test before this could be considered.
That initial patch changed more than intended, i.e., the behavior
of -cols 0 for the other hexdump styles, while only that for
plain hexdump style should have been changed.
[1] https://groups.google.com/g/vim_dev/c/SfaksjJiDV4/m/mVAMNFpNBgAJ

Thanks :-)


feat(bpdm): post endpoint to upload business partner data using csv file

Description

This pull request contains changes for new POST api endpoint on BPDM Gate service, which will accept the CSV file as input for upsetting business partner input data. This endpoint enable way for user to create/update business partner using file.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files

@nicoprow,
In general, I tried covering almost all necessary changes.
Just except,  REST API conformity with permissions about new resource and will also adjust default realm files for both helm chart and test.

@nicoprow, In general, I tried covering almost all necessary changes. Just except, REST API conformity with permissions about new resource and will also adjust default realm files for both helm chart and test.

@nicoprow, I have adapted changes this changes. Kindly review the changes made.

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions.

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions.

I the current app version is 6.0.1-SNAPSHOT. Since this pull request adds a new feature to the app, we need to increase the SNAPSHOT version to 6.1.0-SNAPSHOT. Likewise, we need to increase the chart's SNAPSHOT version to 5.1.0-SNAPSHOT as well as update its appVersion to the 6.1.0-SNAPSHOT.

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions.

@SujitMBRDI I the current app version is 6.0.1-SNAPSHOT. Since this pull request adds a new feature to the app, we need to increase the SNAPSHOT version to 6.1.0-SNAPSHOT. Likewise, we need to increase the chart's SNAPSHOT version to 5.1.0-SNAPSHOT as well as update its appVersion to the 6.1.0-SNAPSHOT.

@nicoprow, Done. I have adapted changes.


Audio Only

Judging from lib/gateway.py line 49 you already have support for creating audio only feeds. How do I subscribe to them? Is there any front end? If not I think it would be a good feature to implement. I would propose an optional GET argument ?audioonly=true.
I'm not that fluent in Python and struggled following the flow of your application, so I unfortunately cannot do it myself. Maybe you could offer me some help so I can prepare a pull request myself (not really sure if I'll be able to do it, though) or you could do it yourself? :)

Hi!
Actually, yes, that feature is already there, and you almost guessed how to trigger it! Just append ?audio=true to the URL, like so:
.../playlist/PLKCGCG9W_E0GKM3KPlS-u-NTR2Elad61T?audio=true


talk: search for a dm, clicking sidebar doesn't change

start a new dm with ~sapdex-diflyx in talk (or any other patp) (click new message, enter patp into search field)
It's okay if you have an existing dm with the patp but do the flow above anyway
click the mention pop up that appears which will bring you to the dm, your page should now look like the image below

click a different patp in the sidebar
observe that no matter what you click, you can't navigate away from the one you're on
Click the X in the search field of the mention
Observe you can now navigate the sidebar as expected

This is a UX issue, the way out is to click “Cancel” in the header.
Will group it in with similar issues that relate to the search/start/existing interaction with the ShipSelector.

This is a duplicate of #1883


Many2Many Lazy Load via Preload

Needed this for my project so I went ahead and started the work... seems to work so far but I have not done extensive testing.

Hello @LiranCohen
Thank you for your work, but seems like the code doesn't works with latest gorm due to some change I made already
Let me see if I could port your code into master

Any Updates on this? Would be happy to have this in :D :+1:

Hello @daMupfel this pull requests can't be merged due to some code conflicts, and also no tests included in it, when I get sometime, I will look on this again

+1


Add an option to disable nonce in the OAuth2 filter

cognito login page doesn't handle state value properly and the nonce doesn't stay in the state but gets raised directly to the url parameter and when coming back to callback nonce has disappeared from the state. In their documentation they do not support urlencoded json state values (and I guess this extends to any format, json just so common that it was mentioned).

xref: https://github.com/envoyproxy/envoy/issues/36871

/assign

cc @derekargueta


Open file shortcut .ink in vscode

Open .ink file from explorer should point to the respective file from another location. I think this should be much helpful if you have a file in any other location or a folder which is not trusted. Then a shortcut is required to point to that respective file.

Duplicate of https://github.com/microsoft/vscode/issues/89743

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Getting a strange error on compilation relating to the plugin, with no recent changes to my code.

ERROR #11321  PLUGIN
"gatsby-source-notion-database" threw an error while running the sourceNodes lifecycle:
Cannot convert undefined or null to object
50 |     })
51 |     // console.log(_dbMap, cacheTable)

52 |     let db = await nb.fetchAll(_dbMap)
|              ^
53 |     await Promise.all(Object.entries(db).map(async (i) => {
54 |         let [tableName, collection] = i
55 |         await genApiData(nb, collection, tableName, 'id', createNode, createNodeId, createContentDigest, cacheTable)

File: node_modules\gatsby-source-notion-database\gatsby-node.js:52:14

Wondering if anybody else had similar experiences, did Notion close their API?

I'm having the same problem, also all of the SVGs stopped loading as content at the same time. I suspect notion updated their API


Handles hooks load error

I changed the behavior when Parse Server fails to load _Hooks collection to prevent it from launching with incomplete state. If Parse Server fails to load _Hooks entries, currently it ignores error and launches without setting hooks. This behavior causes serious problems. (For example an important validation logic doesn't work in Before Save Hook.) So my change forces Parse Server to shutdown before it accepts requests.

Feel free to revise my English in source code. I'm not native English speaker.

20151211-Public-Folder-Info-Paper.pdf

[ ]

@facebook-github-bot
_f_logo_guidelines.pdf

[ ] #3458

@yuki-takeichi I'll be closing this one now, feel free to reopen when the addressing the conflicts and requests.


Simplify tracker implementation

The main goal of these changes are to help make the tracker easier to understand and work on in the future. Documentation is automatically generated from the code (thanks to FastAPI) and served at / of running tracker instances. E.g.
heron-tracker --port=8080 &
sleep 5
open http://localhost:8080/

Type annotations are included throughout. Adding mypy to the builds [e.g.] would be good to take advantage of the typing, but it would take additional work due to the pex_* rules instead of regular py_* ones.
A lot of things were touched, but I tried to leave things that looked suspicious but might be relied on as a feature, and didn't intentionally make changes to the interface aside from dropping the redirect at / and some methods returning objects with None values instead of undefined values (hopefully inconsequential - its managable in FastAPI/Pydantic that way). The tests now pass locally.
The API feels a bit rough, for example returning objects with all None values rather than just a None, but I am not addressing things like that now as that would touch additional services.
The commits will be squashed down on merge so I'll clean up the commit message then.
Tracker changes

requires Python 3.7+ (due to using generic Pydantic model for ResponseEnvelope)
replace Tornado with FastAPI for self documentation of API
use async outbound HTTP requests - may give lower latency to some metrics queries
remove unnecessary use of unittest as pytest is already in use

There's probably still refinement potential, but I'm happy with the improvements to readability.
Exceptions may not appear as graceful in logs, but that's to help highlight where oddities occur so they can be factored out rather than just quietly skipped over.
Behaviour changes

replace / → /topologies redirect with (OpenAPI on ReDoc) documentation
deprecate executiontime and always return 0.0 for it in the response envelope - this could probably be put back in, but I don't think it's worth it
inbound requests aren't terminated if they take over 120s. At the moment, every outbound request has a 5s limit (due to httpx default) so I wouldn't expect the timeout to be needed (even in metrics queries which may transform data). A replacement timeout could be added in if necessary.

To do
This PR:

[ ] review changes
[x] clean up notes
[x] revert changes to tools/python/checkstyle.ini (it currently allows TODO/XXX/FIXME)
[ ] update images and docs for the new minimum required version of Python

Follow ons:

#3644 Replace tracker /topologies/{config,physicalplan,executionstate,schedulerlocation,metadata} with /topologies/info
#3645 Factor out passing of strings as exceptions in tracker query_operator.py

'replace Tornado with FastAPI for self documentation of API'
Do we replace Tornado with FastAPI for just Heron-Tracker, or do we plan to replace Tornado for all Heron Python web server?
If I remember correctly, all Heron python webserver align with a single webserver lib/framework, which is Tornado. Curious shall we keep this convention?

While cleaning up and adding type annotations to python code in other parts of the codebase I have already been changing Tornado to python (e.g. in heron ui). The last remaining users of tornado after this are heron shell and one in integration test component.
p.s. on the lines of servers and async in python, heron instance uses asyncore (deprecated) which could probably also benefit from a clean up

Great! Less dependencies is better~
On Sat, Dec 5, 2020 at 1:40 AM Oliver Bristow<EMAIL_ADDRESS>wrote:

While cleaning up and adding type annotations to python code in other
parts of the codebase I have already been changing Tornado to python (e.g. in
heron ui https://github.com/apache/incubator-heron/pull/3597). The last
remaining users of tornado after this are heron shell and one in
integration test component.
p.s. on the lines of servers and async in python, heron instance uses
asyncore (deprecated) which could probably also benefit from a clean up
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-heron/pull/3642#issuecomment-739153079,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQPBH57AH2AUKZMEMQX5DLSTH52RANCNFSM4UKP6TZQ
.

Is this ready to merge, or do we still need to complete the "To Do" section found in the above description?

Is this ready to merge, or do we still need to complete the "To Do" section found in the above description?

I just updated the checklist; the python versions in Dockerfiles needs updating, as well as docs on it - 3.8 works, but 3.7 or 3.8 may be the minimum.
I wouldn't want to merge this at the moment with the Heron 0.20.3 being almost finalised, but it would be good to after. I'd be happiest with someone using this branch in their environment to make sure it works outside of the limited unit-tests. When this is confirmed as working, it will be easier to understand what is going on and add tests to cover that functionality over time.

Yes.  Let's hold off on merging until we get 0.20.3-incubating-rc8 fully released.  We are still going through the vote process on<EMAIL_ADDRESS>

I rebased this after seeing a PR went in for python 3.8 support, but it looks like the properly supported version isn't that high yet.
There's still the issue of requiring python 3.7+ for this PR. I don't have the time to go through and update and test all of the Docker images which would get this in a good place for testing.

I rebased this after seeing a PR went in for python 3.8 support, but it looks like the properly supported version isn't that high yet.
There's still the issue of requiring python 3.7+ for this PR. I don't have the time to go through and update and test all of the Docker images which would get this in a good place for testing.

Do you think the work done on this branch is worth one of us following up on to fix the Mac OS build issues related to pex?

I rebased this after seeing a PR went in for python 3.8 support, but it looks like the properly supported version isn't that high yet.
There's still the issue of requiring python 3.7+ for this PR. I don't have the time to go through and update and test all of the Docker images which would get this in a good place for testing.

Do you think the work done on this branch is worth one of us following up on to fix the Mac OS build issues related to pex?

Do you think the work done on this branch is worth one of us following up on to fix the Mac OS build issues related to pex?

If the core bazel rules required a newer version of Python then that would be a separate line of work to this, which would unblock this PR. I haven't checked in on it so no idea if an upgrade would be needed for it, but could hope not, or that at least it would be apparently very early on from reading bazel's docs.
I don't think there's anything in this PR as is which would help the migration to drop the PEX rules. The closest I can imagine is that this PR is towards removing the last of the tornado requirements, but that shouldn't matter.

Closing as #3646 now has the changes from this PR.


WAR to build upstream-pax for ARM64

Upstream-pax for ARM64 fails to build lingo with the latest bazel-7.2.0, but OK with bazel-7.1.2. Force to use last but one version of bazel, while lingvo team address this issue.
(a bug to lingvo upstream https://github.com/tensorflow/lingvo/issues/359)

LGTM Have you filed a bug against upstream? Can you link to it?

Added link to the PR description


c4ev3 text to speech

Parent issue: #27

[ ] add espeak and sox compiled for EV3 to ora-cc-rsc
[ ] update UI to download easpeak and sox binaries to sd card/usb drive
[x] add to c4ev3 a function that:

uses espeak to generate wav file (RIFF (little-endian) PCM, 16 bit, mono 22050 Hz)
converts generated wav to compatible wav (RIFF (little-endian) PCM, 8 bit, mono 8000 Hz)
plays wav file

* [x]  add to c4ev3 a function that:

  1. uses espeak to generate wav file (RIFF (little-endian) PCM, 16 bit, mono 22050 Hz)
  2. converts generated wav to compatible wav (RIFF (little-endian) PCM, 8 bit, mono 8000 Hz)
  3. plays wav file

This method is very slow, try to

[ ] generate/find espeak language files already encoded in (RIFF (little-endian) PCM, 8 bit, mono 8000 Hz) to avoid the need of sox

FYI: there is https://github.com/espeak-ng/espeak-ng/issues/88 for espeak to support other sample rates.

thank you! I didn't see the issue. If I understood it correctly the feature isn't implemented yet, is it?
I was thinking about using espeakedit to recompile the espeak data directly to the needed sample rate, what do you think? doing this we would avoid the cost of converting the audio files at runtime


Detect Keiser bike version and set stats timeout accordingly.

Keiser changed the broadcast interval in firmware revision 6.30 from ~ 2 seconds to ~ 0.3 seconds. As a result bikes before version 6.30 (old) need to use a higher stats timeout value of 7 seconds to detect a communication failure, while bikes starting with version 6.30 (new) can use a lower stats timeout value of 1 second.
This change determines the bikes firmware version on first discovery and sets the stats timeout value accordingly.
For unknown firmware versions (e.g. 5.12, which doesn't exist) a "safe" stats timeout value of 7 seconds is considered.

Nice one!

anything needing testing @chriselsen @ptx2 ?

anything needing testing @chriselsen @ptx2 ?

Sure. More testing is always a good idea. Although here the hope is that you won't notice a functional difference. As this has been merged into 'main' now, you can try this via:
To try this out:
Start with current Gymnasticon Pi image

Setup build environment:

sudo apt-get install git
cd
git clone https://github.com/ptx2/gymnasticon.git
cd gymnasticon
sudo service gymnasticon stop
sudo setcap cap_net_raw+eip $(eval readlink -f $(which node))

Build it and test it

npm install
npm run build
npm link
NODE_DEBUG=gymnasticon:bike* gymnasticon --bike keiser

When your Keiser bike is detected, it should show the bike's version ID as well as the internally used stats timeout. Other than that, you should not see any changes.

worked fine!


Add loading screens?

When a petition page is opened, it briefly shows default values like Untitled Petition. On the home page, it briefly shows an empty list. This can be confusing, specially for someone with a bad internet speed. Probably should show a loading screen when data is being fetched in both of these screens. Not sure what the loading screen should look like tho.

Yes pls. You wanna?

not right now, no. wanted to start the conversation so someone takes it up

okay.

Done.


Linter/formatter?

Is there a standard linter / formatter that you're using @jongwook?
Thanks!

Hi I wasn't diligent enough to use one. I have the default PEP8 warnings turned on in IntelliJ with an exception of allowing 120-character columns. But I didn't enforce that using a build script or a hook.

Ok cool thanks!