cask-repair: audit options match CI checks

I noticed that audit checks in cask-repair would pass but would fail when run on Travis. When looking at the Homebrew CI file, I noticed that Travis will run the command line equivalent to brew cask audit --download --appcast --token-conflicts [token]. This script currently runs the basic brew cask audit [token].
It would be nice to have both this script and Travis run the same brew cask audit commands.

Thank you, but this is the correct fix.

That works better. I wasn't sure if --download should be included in the main brew cask audit check or not.

I wasn't sure if --download should be included in the main brew cask audit check or not.

cask-repair generates the shasum, so it will be correct. The check would just make the process longer.

Had a thought about it, and I’m going to reverse. --appcast should not be run when updating in cask-versions, and the token conflict is a guideline, not a rule that prevents submission.

The lower barrier to entry for newcomers, the better in my opinion; so I understand that not making --appcast a requirement will help.
It's just convenient to run a single command and you're almost always guaranteed the CI will not fail. (The whole reason I brought it up and suggested the change was that I had the CI fail on the appcast while running this script didn't.)

It's just convenient to run a single command and you're almost always guaranteed the CI will not fail.

On the other hand, this was making legitimate submissions fail.

Well, I guess just about any major change will break someone else's workflow. 🤷♀ It's all good.

@vitorgalvao, would you consider making, or accepting a PR, that generates a warning if --appcast --token-conflicts fails? Something like, "This request will not be automatically merged. We recommend waiting until the appcast is updated."
A warning might help prevent the issue in https://github.com/Homebrew/homebrew-cask/pull/76434, and would help my workflow.

a PR, that generates a warning if (…) --token-conflicts fails

There’s no point in showing a warning for that case—it always needs to be reviewed.

Something like, "This request will not be automatically merged.

No, that’s the wrong approach. You should never expect a request to be automatically merged.

We recommend waiting until the appcast is updated."

Even worse. We definitely do not recommend that. Appcasts are as good as their synchronicity with the app updates. Some appcasts only need a bit of waiting, while others need to be replaced. If people stop submitting until appcasts are updated, we’ll never know which are bad.
The appcast check is to avoid unstable versions (betas and the like) being submitted when they shouldn’t. Those PRs take longer to be merged because it’s time consuming to check if the issue is with the appcast or the submission.
If on submission a user points out the appcast is outdated and links to proof, that can be done way faster. So what we need is more information in the PRs, not less PRs. I’m open to suggestion on how to make that clear.

Thanks for the explanation. What if cask-repair prompted the user to add that proof and included that in the PR it submitted?

What if cask-repair prompted the user to add that proof and included that in the PR it submitted?

I question the usefulness of making the message show from cask-repair. I don’t think that’s the solution, as many people submit automatically without checking.


use gzip where possible?

hanna:~ job$ wget "https://lg.coloclue.net/birdseye/api/routeserver/0/routes/filtered/?protocol=peer_AS3257_0"
--2017-02-23 19:41:39--  https://lg.coloclue.net/birdseye/api/routeserver/0/routes/filtered/?protocol=peer_AS3257_0
Resolving lg.coloclue.net... <IP_ADDRESS>
Connecting to lg.coloclue.net|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 13880757 (13M) [application/json]
Saving to: ‘index.html?protocol=peer_AS3257_0’

index.html?protocol=peer_AS3257_0                    100%[====================================================================================================================>]  13.24M  4.11MB/s    in 3.2s

2017-02-23 19:41:48 (4.11 MB/s) - ‘index.html?protocol=peer_AS3257_0’ saved [13880757/13880757]

hanna:~ job$

this takes too long :-)

even when the json blob is loaded in the browser, the sheer size of it seems to cause issues when rendering the table: https://lg.coloclue.net/birdseye/app/routeservers/0/protocols/peer_AS3257_0/routes is not working, this is a peer with "accepted: 167114, rejected: 14682"

This peer serves for an interesting benchmark. I will think of a few ways to make this faster.
Just as a heads-up: I will open a birdwatcher issue, because the service performance is better addressed there. As for the frontend being unable to render it, I will see what I can do to reducre the footprint of the React components.

Plenty of other big peers to compare with! https://lg.coloclue.net/birdseye/app/routeservers/0

Thanks a lot, that's a great use case.

@hellerve if you want access to the routers so you can do real time debugging of components like birdwatcher or birdseye that is no issue, just mail me<EMAIL_ADDRESS>

Thanks, I'll probably need that tomorrow. For now I'm going to enjoy the evening. Thanks for all of your bug reports and feature requests today, much appreciated!

was this done?

It is currently in a feature branch awaiting review. I will ping the reviewer.

I reviewed and merged it.
I'll have to patch the python backend though to support the gzipped result.
I'll keep you all posted :)


filetime 0.1.14 issue on Solaris

I have tried to build Cargo 0.23 with filetime 0.1.14 (since the default version 0.1.12 expects lutimes() which is not available on Solaris). But I'm still getting following error (on Solaris). Note that with version 0.1.10 builds.
error[E0425]: cannot find value utimensat in module libc
--> /scratch/userland-rust-s11.3/components/rust/cargo/build/.cargo/registry/src/github.com-eae4ba8cbf2ce1c7/filetime-0.1.14/src/unix/utimensat.rs:8:45
|
8 |     super::utimensat(p, atime, mtime, libc::utimensat, 0)
|                                             ^^^^^^^^^ did you mean utimes?
|
help: possible candidate is found in another module, you can import it into scope
|
1 | use imp::utimensat;
|
error[E0425]: cannot find value utimensat in module libc
--> /scratch/userland-rust-s11.3/components/rust/cargo/build/.cargo/registry/src/github.com-eae4ba8cbf2ce1c7/filetime-0.1.14/src/unix/utimensat.rs:12:45
|
12 |     super::utimensat(p, atime, mtime, libc::utimensat, libc::AT_SYMLINK_NOFOLLOW)
|                                             ^^^^^^^^^ did you mean utimes?
|
help: possible candidate is found in another module, you can import it into scope
|
1  | use imp::utimensat;
|
error[E0425]: cannot find value AT_SYMLINK_NOFOLLOW in module libc
--> /scratch/userland-rust-s11.3/components/rust/cargo/build/.cargo/registry/src/github.com-eae4ba8cbf2ce1c7/filetime-0.1.14/src/unix/utimensat.rs:12:62
|
12 |     super::utimensat(p, atime, mtime, libc::utimensat, libc::AT_SYMLINK_NOFOLLOW)
|                                                              ^^^^^^^^^^^^^^^^^^^ not found in libc
error[E0425]: cannot find value AT_FDCWD in module libc
--> /scratch/userland-rust-s11.3/components/rust/cargo/build/.cargo/registry/src/github.com-eae4ba8cbf2ce1c7/filetime-0.1.14/src/unix/mod.rs:64:17
|
64 |         f(libc::AT_FDCWD, p.as_ptr() as *const _, times.as_ptr(), flags)
|                 ^^^^^^^^ not found in libc
error: aborting due to 4 previous errors
--
Any idea what could be possibly wrong?

https://github.com/rust-lang/libc/commit/4a58331883ac84e7858c08665370c7ea56c26338 closes this issue.

Yay!


n_jobs increase the memory of GPU

With default n_jobs i am using less than 2GB out of 8GB GPU ram. But as soon as i change n_jobs to 2, my GPU ram goes to 8 GB.

Is the expectation that it only doubles? Can you provide a minimal working example so that I can reproduce? Thanks!

n_jobs=1

n_jobs=2

same code as #257


Add AMD Milan Support

This PR adds support for AMD Milan. Testing at NAS shows that:
elseif (${proc_description} MATCHES "EPYC 7..2")

matches the Romes and that:
elseif (${proc_description} MATCHES "EPYC 7..3")

matches the Milan processors on AWS.
We mainly do this to use -znver3 on AWS.

I'm going to block this until I can actually test on Milan. Probably good not to break things. 😄

Well, testing with the Bill Branch shows it crashes with any optimization it seems. znver2, znver3, native...
I'll try stock GEOSgcm...


Add basic validation support

added basic validation support
refactoring and coding style fixes

Coverage decreased (-0.9%) to 90.833% when pulling b56d36fb624368b9d86f9e54546b1f791493ddb6 on OriHoch:add-validation into 9929166f2852ec49af371dea616b3c9fb241fa66 on frictionlessdata:master.


Initiate global state in a Gatsby v4 compatible way

Keep backward compatibility to v3.

[ ] Follow docs

Part of #139

✋

Released: v2.3.0


Track Requests: "Assigned" filter matches assigned and completed requests

What Happened
In Track Requests, the "Assigned" request status filter appears to match both assigned and completed requests.
What Should Happen
The "Assigned" request status filter should only match assigned requests, and not completed requests.
To Reproduce
Steps to reproduce the bug:

Go to MOVE prod and log in;
Go to Track Requests in the left navbar;
Click "Filter";
Find the "Assigned" filter, select it, and "Save";
Page through search results

At this point, you'll see completed requests mixed in with the assigned requests.
Screenshots

I notice that this only happens with bulk studies (aka projects), not individual requests.

This may be fixed with our next web release.

Migrated to Jira board. Closing issue.


404 from localized pages

Hello,
I compiled the pages handles for the three languages (it,en,fr), but when I try to load a page http://localhost/website/it/home with a lhandle, example is http://localhost/website/fr/accueil/, http://localhost/website/en/homepage/ I get a 404.
It works though if I load http://localhost/website/en/home/or http://localhost/website/fr/home/
The app seems to render pages which are requested through the general (not localised) url handle.
This is the .htaccess hunk:
### LANGUAGE REDIRECT RULES start
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(it|en|fr)-?()?\/(.*\/?)$ index.php?language=$1&region=$2&symphony-page=$3&%{QUERY_STRING} [L]
### LANGUAGE REDIRECT RULES end

I'm using Flang Detection 1.1, Sym 2.3.4, Page LHandles 2.9, Frontend Localisation 1.7.1, Languages 1.2
Thanks

Can you find the line in your .htaccess where you have a beginning with RewriteBase ?
Can you also show me the regular symphony rewrite please ? thanks!

Ping @Manaus !

Closing as no feedback in 6 weeks. Please re-open or comment as needed.


Support for arrays with non-zero lower bounds

Low priority. Not exposed from any of the mainstream .NET languages.
The work would likely span:

System.Private.CoreLib support
Type system support
Compiler support
Support in the reflection metadata format
Support in the native layout metadata format
Runtime type loader support

What is the purpose of this?

.NET Framework and .NET Core on CoreCLR support them today for historic reasons. It is very rarely used feature; it may never get done for CoreRT. That's why it is tagged with P2 tag.


[Bug/Wrong way] when limited access resource by searchQuery

Description
Product (hasMany Pricing)
Pricing (belongsTo Tax): product_id, tax_id, salesman_display
PricingResource: only return for salesman when salesman_display is true
public function searchQuery(RestRequest $request, Builder $query)
{
    if (auth()->user()->isSalesman()) {
        return $query->where('salesman_display', true);
    }

    return $query;
}

When filter Product includes.relation: 'pricings' then query:

select * from `pricings` where `pricings`.`product_id` in (?, ?, ?) and `salesman_display` = ?

-> SQL is include salesman_display=true

But when filter Product includes.relation: 'pricings.tax' then query:

select * from `pricings` where `pricings`.`product_id` in (?, ?, ?)
select * from `taxes` where `taxes`.`id` in (?)

-> SQL is not include salesman_display, so limited access Pricing is not working, it's return all Pricing

hmm, TaxResource should be public for all, Pricing is limited.
Schema including Product.Pricing.Tax: this mean Tax only belongs when Pricing is present

then if the resource should be public you shouldn't impact the "search query" but instead apply a filter on your include


Re-enable dockertest of piped-base image

This reverts commit b9d972907f9d008413061bfe21ddd2fc55f1ba57.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve


Linux runtimes don't render properly when creating web app

This happens in basic & advanced create.

From the App Service team:

A Stack with Particular Version can be identified by “Stack Name”+” ”+displayVersion (previously display version had stack name in it as well).

So the extension needs updating to use this method as well.


refine project owner experience

Overview
Let's refine the project owner experience to better align with user needs. Specifically, gate actions in the ui that they don't have permission to perform and give more permissions related to teams within their projects.
Ideal state
Should

all editor role actions, including access and editor on event feed, applications, infrastructure, compliance, node integrations, and node credential pages
should be able to list users
should be able to manage members of policies in their project
should be able to view their projects and detail pages
should be able to assign projects they are part of to any resources they are allowed to create or update

Teams

should be able to create teams within their project
should be able to delete teams within their project
should be able to move teams to other projects they have permissions on
should be able to change the name of teams within their project
should be able to add/remove users from teams in their project

Shouldn't

shouldnt see notifications or be able to create/update them
shouldnt be able to make changes to the data lifecycle
shouldnt be able to try and delete a user
shouldnt be able to see users detail pages
shouldnt be able to reset users password (beyond their own)
shouldnt be able to update policies, beyond member management
shouldnt be able to update projects, beyond assigning that project to new resources they are allowed to create
shouldnt see roles, or api tokens, or their detail pages or be able to update or create them
shouldnt be able to create new users

Current state

project owners do not have access to unassigned
project owners can see the users list
project owners can try and delete users, and get an error back
project owners can get user detail pages
project owners can attempt to reset a password, and get an error back
project owners can add users to teams
project owners can assign user to policies
project owners can attempt to delete or change the name of a team and get an error back

auth team convo

should project owners be able to have more control over teams, and api tokens in projects they have permissions on?
open question: what about roles and policies?
should project owners be able to change the project name?

should project owners get access to (unassigned) by default?  no

this work has been deprioritized, so closing.


DRDT:Completed the listicle template funcationality

Lighthouse test passed! The score of 63 isn't less than the acceptable score of 19 (5 less than the score of 24 on the master branch)
View the full Lighthouse performance report for pull/18 and compare it to the Lighthouse performance report for the master branch

Visual regression test failed!


[RR Request]: framework-x v4.0

Open Source Project name
3rd planets's framework x
What is your project?
framework x is  all about substance over style! 3rd Planet's Framework X is like a well-oiled machine for API development, powered by Node.js and Express. It's all about getting the job done efficiently and effortlessly. No flashy gimmicks, just pure development bliss.
Version
4.0
Date
August 10th, 2023
Description of breaking changes
nill
GitHub Repo
https://github.com/3rd-planet/framework-x
Website
https://3rd-planet.github.io/framework-x/
Link to changelog
https://github.com/3rd-planet/framework-x/compare/v3.6.1...v4.0.0
Social media
https://twitter.com/msamgank/status/1690054063293898760
Anything else to add?
No response

Congrats on being featured in the August-September, Hacktoberfest Release Radar Special 🥳

Read the blog here
Feel free to retweet Mish's tweet featuring you


Updating guidelines for accid.ges

Clarifying the use of accid.ges following discussion #261

Is this still the desired wording?

As far as I understand, there's a consensus that this wording would be better.
However we haven't reached a conclusion on how to address the consequences:

forget prima practica
allow both practices, but require an explicit statement which practice is in use in a particular customization.

As Jo reminds us, MEI is a framework, and one of it's greatest power is documentation, so I too lean towards the second option.

Unless we can clearly identify the advantage of having two practices I would suggest to forget the prima practica, at least for now. We can still adopt it later but with the addition of an encoded description of it in  as suggested in the discussion. This pull request is fixing the inconsistency we currently have between the documentation and all our examples.

I will wait for Perry's changes to be merged into develop before merging this one.

I guess this can now be ignored since @pe-ro has clarified the use of accid.ges

@lpugin do we have a link to the other thread?

https://github.com/music-encoding/music-encoding/pull/261

Yeah, I think adding @visible on <accid> and <artic> isn't necessary at this point.


Codekit wont compile with XY Grid

For some reason this will not compile when I enable the XY Grid imports?  Do I need to disable some others?

It may be related to https://github.com/zurb/foundation-sites/issues/10279
We're going to turn around a patch release tomorrow that has fixes to the above.

The issue is definitely in @include xy-grid;.  If I comment that one out it works

Hmm... as a way to narrow in on if it's likely the same issue, can you try doing
@include foundation-xy-grid-classes($vertical-grid: false)
and see if it still errors?

Yes that works fine that way.  Compiles as it should

Ok, I'm almost 100% sure this is due to the same underlying issue as #10279 and is fixed with https://github.com/zurb/foundation-sites/pull/10286
We'll have a patch update out tomorrow with that fix in. I'll leave this open until we're able to confirm

Great.  Thank you.

I tried that fix and it did not seem to help.  We will try it again tomorrow after you  put out the patch.

I think its by @include xy-grid, as this mixins is:
`@mixin xy-grid(
$direction: horizontal,
$wrap: true
) {
$direction: if($direction == 'horizontal', row, column);
$wrap: if($wrap, wrap, nowrap);
display: flex;
flex-flow: $direction $wrap;
}`
think that for building foundation with xy-grid system we need only to include:
@include foundation-xy-grid-classes; @include foundation-flex-classes;
so, the docs are wrong about xy-grid include, just check what foundation-everything is doing :)

Yep that looks like an error in the docs, you are right it shouldn't be listed at the top and should just be the classes mixin. @kball or @IamManchanda could one if you remove that from the top of the docs page? I'll be home and back to normal from Sunday :smile:

So to use XY Grid and flex classes it should be this correct?
@include foundation-global-styles;
@include foundation-xy-grid-classes;
// @include foundation-grid;
@include foundation-flex-grid;
@include foundation-flex-classes;
@include foundation-typography;
@include foundation-forms;
@include foundation-button;
@include foundation-accordion;
@include foundation-accordion-menu;
@include foundation-badge;
@include foundation-breadcrumbs;
@include foundation-button-group;
@include foundation-callout;
@include foundation-card;
@include foundation-close-button;
@include foundation-menu;
@include foundation-menu-icon;
@include foundation-drilldown-menu;
@include foundation-dropdown;
@include foundation-dropdown-menu;
@include foundation-responsive-embed;
@include foundation-label;
@include foundation-media-object;
@include foundation-off-canvas;
@include foundation-orbit;
@include foundation-pagination;
@include foundation-progress-bar;
@include foundation-slider;
@include foundation-sticky;
@include foundation-reveal;
@include foundation-switch;
@include foundation-table;
@include foundation-tabs;
@include foundation-thumbnail;
@include foundation-title-bar;
@include foundation-tooltip;
@include foundation-top-bar;
@include foundation-visibility-classes;
// @include foundation-float-classes;

can I also comment out the @include foundation-flex-grid;?

@bgarrant yep comment that out too as the flex grid is the legacy flexbox grid which you don't need. And yep looks fine otherwise.

Works great now. Just need to fix the docs. Also the setup example for Sass does not have the new XY class entry in the list in the docs.

The component list needs updating on this page http://foundation.zurb.com/sites/docs/sass.html

This seems fixed in #10307 ... I am closing this!


Adds the Bolt robot to the repo

Fixes #71 .

Good catch! Will do the cleanup later today.

Thanks for this contribution ;)
It would be also nice if you remove those files from the git history.

I've removed the obj files and squashed the commits to remove them from the git history.

The gitlab-ci  is failing. How can I see why?

The gitlab-ci is failing. How can I see why?

If you clip in "Details" you can see where it is failing. You should also run locally the unittests.
Btw, you also need to resolve some conflicts with the devel branch.

Thanks @cmastalli for the hint about pressing "Details".
It also seems as if the unittests are failing. I take a look.

All checks pass and the commits are rebased for devel.
Please let me know if there is anything else to do before this can be merged.


COD1026 Job Link Usage, OnBeforeMatchUsageSpecified

Can the OnBeforeMatchUsageSpecified please be added to MatchUsageSpecified in the following way:
LOCAL PROCEDURE MatchUsageSpecified@8(JobLedgerEntry@1000 : Record 169;JobJournalLine@1001 : Record 210);
VAR
  JobPlanningLine@1002 : Record 1003;
  JobUsageLink@1003 : Record 1020;
  TotalRemainingQtyPrePostBase@1004 : Decimal;
  PostedQtyBase@1007 : Decimal;
  TotalQtyBase@1005 : Decimal;
  IsHandled@1100366000 : Boolean;
BEGIN
  //<< DC
  OnBeforeMatchUsageSpecified(JobPlanningLine, JobJournalLine, JobLedgerEntry, IsHandled);
  IF IsHandled THEN
	EXIT;
  //>> DC

Publisher:
[Integration(DEFAULT,TRUE)]
PROCEDURE OnBeforeMatchUsageSpecified@1100366000(VAR JobPlanningLine@1100366000 : Record 1003;VAR JobJournalLine@1100366001 : Record 210;VAR JobLedgerEntry@1100366002 : Record 169;VAR IsHandled@1100366003 : Boolean);
BEGIN
END;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Added more tests

Minor refactoring and improvements in tests
Added robots.txt test
Added favicon.ico test
Added additional test for Dotenv

:+1:


Error when suggestions is const

NoSuchMethodError: The method 'map' was called on null.

Just don't make it const.


Disable mount/remount of screen when navigating to the same screen in a StackNavigator

I want to wrap a container around some screens in my app that share some basic UI elements. As an example, I created two navigator routes that redirect to the same screen (the container with some shared ui), but with a different childComponent. The child component is the "real" screen, where the content of the screen will be.

The problem is that the HomeContainer gets unmounted and remounted when changing screen, destroying its state. Is there anyway to wrap UI over components, without destroying the state of the container when switching screens?
This is my Navigator:
const MainNavigator = StackNavigator(
  {
    Home: {
      screen: props => <HomeContainer {...props} screenProps={{component: ChildComponent}} />,
      navigationOptions: { title: 'HomeScreen' }
    },
    AlternativeHome: {
      screen: props => <HomeContainer {...props} screenProps={{component: ChildComponent2}} />,
      navigationOptions: { title: 'Other Screen' }
    },
 });

These are the ChildComponents, the screens where the main content will be:
const ChildComponent = (
  <View>
    <Text>I am a childcomponent</Text>
    <Text>This is the "real screen"</Text>
  </View>
);
const ChildComponent2 = (
  <View>
    <Text>I am a alternative childcomponent</Text>
    <Text>Haha</Text>
  </View>
);

The HomeContainer renders the shared UI and returns the component:
render() {
  return (
    <View>
      <Text>I am the Container</Text>
      <Text>This is some shared UI between all screens</Text>
      <Text>Below is my childComponent</Text>
      <Card>
        {this.props.screenProps.component}
      </Card>
      <Button title="Go to Other Screen" onPress={() => this.props.navigation.navigate('AlternativeHome')} />
    </View>
  );
}

The screenshot above is the result of this code.
So, to recap, when I press the button to navigate to the other screen, the HomeContainer unmounts and remounts again. I would like it to stay mounted.
If there is another way to have shared, persistent UI accross screens, I'm open to suggestions. I tried multiple things already, but the above solution is the closest I came to what I want.

To give some insight in another approach to solve this issue, here is something else I tried.
I wrapped the screens that share the same ui elements in a HomeContainer
const MainNavigator = StackNavigator(
  {
    Home: {
      screen: HomeContainer,
      navigationOptions: { title: 'Home' },
    },
    Login: {
      screen: LoginScreen,
      navigationOptions: { header: false },
    }
);

Then, inside the HomeContainer, I put the shared UI components, along with a new Navigator:
navigateTo(routeName) {
  const nav = NavigationActions.navigate({
    routeName: 'Home',
    action: NavigationActions.navigate({ routeName: 'Home2' }),
  });
  this.props.navigation.dispatch(nav);
}

render() {
  const HomeNavigator = StackNavigator(
    {
      Home: {
        screen: MessageScreen,
        navigationOptions: { header: false }
      },
      Home2: {
        screen: MessageScreen2,
        navigationOptions: { header: false },
      },
    }
  );

  return (
    <View style={{ flex: 1 }}>
      <Text>I am the Container</Text>
      <Text>This is some shared UI between all screens</Text>
      <Text>Below is my childComponent</Text>
      <HomeNavigator />
      <Button title="Go to Other Screen" onPress={this.navigateTo.bind(this, 'Home2')} />
    </View>
  );
}

The problem here is that I can't get the button to work. I used the solution of #1401[(direct link to comment)](https://github.com/react-community/react-navigation/issues/1401#issuecomment-299699164), but this doesn't seem to work since HomeNavigator is no direct child of MainNavigator: there is a Container in between.

Any ideas on this one?

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!

@spencercarli  why these issues and similar ones keep getting closed without any clear solutions or updates ?
@xanderberkein  did you manage to find a solution for this ? I am facing a similar issue and very annoyed as it seems all the similar threads are being closed with no solution ...

No, I didn't find a solution, I just redesigned the app to use a less complicated routes layout. Far from ideal, but the other navigation I tried (wix navigation) didn't meet my needs either.

@xanderberkein  Thanks for your feedback.. I am giving the "react-native-navigation" a shot which I think is also called wix ! ...  will let you know here if I found a solution ...


Handle revocation notification message

As a Holder, I want to be notified as soon as possible if my credential is revoked so that I can take appropriate action to regain my credential and not accidentally use my revoked credentials and be unsuccessful in a proof request.
Handle revocation message:

Display notification

Display notification for revoked credential

Mark credential as revoked

Revoked credential in Credential List
Revoked credential detail

Update testing harness to support revocation

Acceptance Criteria:
Blocked By

https://github.com/hyperledger/aries-framework-javascript/issues/493
https://github.com/hyperledger/aries-framework-javascript/pull/579

Scenario: Holder is Notified that their credential has been revoked
Given that a revocable credential is being stored in the wallet
And a connection to the issuer exists
When the issuer revoke a credential
And sends a revocation message to the holder
Then The holder receives a revocation message notification
Scenario: Holder review revocation message
Given that holder has received a revocation message
And a notification is showed in the notification list
When the holder selects the message in the notification list
Then the holder seems a the content of the message
and an "Okay" button
and an "Keep?" button
Questions:

How the holder get a notification/message of revocation?

AFJ should handle the revocation message, fetch revocation registry entries, and flag credential as revoked

being worked under https://github.com/hyperledger/aries-mobile-agent-react-native/pull/504

Reviewed the revocation message with Akiff and updates are good to complete this ticket. Bugs were identified and will be added as new tickets. These bugs include were : 1. Card UI doesn't update with revocation UI unless user closes and opens the wallet 2. When a user receives a proof request, then their credential is revoked, the proof request does not update with the new credential status.

I cannot test this this locally

Needs to check the layout. The icon and the colors are not matching the design

@knguyenBC The acceptance criteria in this ticket states that the Credential details after a revoke, would have an Okay and Keep. Is this still the way we want it or should we change the acceptance criteria to Dismiss instead?
Assuming if Keep is selected, the notification stays?

Updated to ticket to reflect the newest designs and flows.

@wadeking98 the third acceptance criteria is not met: Scenario: Holder prompts the revocation message again.

Resolved by: https://github.com/hyperledger/aries-mobile-agent-react-native/pull/819

After revoking a credential from agent side, I am not receiving any notification for revoked credential on app.
Instead I am getting the following error in the console:
WARN WARN: Failed to process revocation notification message {
"error": {
"name": "AriesFrameworkError",
"message": "Incorrect revocation notification threadId format: \n79389b4b-efc4-425e-b951-3e5ed07ecd5f\ndoes not match\n"indy::<revocation_registry_id>::<credential_revocation_id>"",
"stack": "Error\n at captureStackTrace (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:114073:32)\n%5Cn) at BaseError (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:114111:22)\n%5Cn) at construct (native)\n at _createSuperInternal (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:114012:406)\n%5Cn) at call (native)\n at BaseError (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:114032:26)\n%5Cn) at construct (native)\n at _createSuperInternal (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:113991:406)\n%5Cn) at call (native)\n at AriesFrameworkError (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:114004:25)\n%5Cn) at v1ProcessRevocationNotification$ (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:185308:121)\n%5Cn) at call (native)\n at tryCatch (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20534:23)\n%5Cn) at invoke (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20680:32)\n%5Cn) at anonymous (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20574:30)\n%5Cn) at call (native)\n at tryCatch (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20534:23)\n%5Cn) at invoke (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20599:30)\n%5Cn) at anonymous (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20624:19)\n%5Cn) at tryCallTwo (/tmp/hermes/staging/hermes/cmake/intlDebug/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:61:9)\n at doResolve (/tmp/hermes/staging/hermes/cmake/intlDebug/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:216:25)\n at Promise (/tmp/hermes/staging/hermes/cmake/intlDebug/arm64-v8a/lib/InternalBytecode/InternalBytecode.js:82:14)\n at callInvokeWithMethodAndArg (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20623:33)\n%5Cn) at enqueue (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20627:157)\n%5Cn) at anonymous (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20574:30)\n%5Cn) at anonymous (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:20641:69)\n%5Cn) at v1ProcessRevocationNotification ([http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.ariesbifold&modulesOnly=false&runModule=true:185295:82)\n](http://localhost:8081/index.bundle?
},
"threadId": "79389b4b-efc4-425e-b951-3e5ed07ecd5f"
}
Can anyone help in what I might be doing wrong?


chore: fix typo

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.50%. Comparing base (6abd865) to head (fa24232).

:exclamation:  There is a different number of reports uploaded between BASE (6abd865) and HEAD (fa24232). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (6abd865)
HEAD (fa24232)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20099       +/-   ##
===========================================
- Coverage   79.31%   57.50%   -21.82%
===========================================
  Files         501      501
  Lines       46984    46984
  Branches     8659     8659
===========================================
- Hits        37266    27017    -10249
- Misses       7970    18292    +10322
+ Partials     1748     1675       -73

Flag
Coverage Δ

keras
57.50% <ø> (-21.67%)
:arrow_down:

keras-jax
?

keras-numpy
57.50% <ø> (ø)

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update ForceDotCom.gitignore

In order to support latest Salesforce.com development tools the following paths were added
.metadata - This folder contains metadata information which is related to Force.com IDE which working as a plugin for Eclipse Platform
During a past few years Mavensmate (http://mavensmate.com/) is going to be a primary IDE for Force.com developers. This IDE works on top of Sublime Text editor, thus the following files and folders must be excluded from git repository:
*.sublime-project
*.sublime-settings
*.sublime-workspace
config - Mavensmate configuration
apex-scripts/log - logs of execution Apex code from Mavensmate
build.properties - properties for Apache Ant which is used as a base for Salesforce.com Ant Migration Tool. This tool provides a build automation functionality. Especially for Force.com projects this file contains credentials and keys which should not be added into git repository.

A couple of things:

to make it easier to maintain, we track IDE-specific rules in separate templates, like SublimeText.gitignore - this means changes only need to be updated in one spot on our end. Do you think that's a reasonable compromise here? We could add a note here for users to also incorporate Global/SublimeText.gitignore into their own projects

the additional Mavensmate rules could be documented in their own section to indicate they are related to the IDE


Tests for session.save, session.touch, session.destroy

Codecov Report

Merging #173 into master will decrease coverage by 2.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
- Coverage   71.01%   68.70%   -2.32%
==========================================
  Files          49       51       +2
  Lines        1756     1885     +129
  Branches      441      478      +37
==========================================
+ Hits         1247     1295      +48
- Misses        508      589      +81
  Partials        1        1

Impacted Files
Coverage Δ

packages/session/src/index.ts
70.84% <100.00%> (+13.47%)
:arrow_up:

packages/forwarded/src/index.ts
0.00% <0.00%> (ø)

packages/proxy-addr/src/index.ts
0.00% <0.00%> (ø)

packages/cors/src/index.ts
100.00% <0.00%> (+5.00%)
:arrow_up:

packages/pug/src/index.ts
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6720e18...d9e4511. Read the comment docs.

pls turn PR intro a draft cuz there are more tests to come

@all-contributors add @alcar for test


docs: Improve language across multiple documentation files

Enhanced clarity and readability of the content across 11 documentation files.
Corrected various grammar, syntax, and punctuation errors.
Improved phrasing and use of terminology where required.
Ensured consistency in language and style across the documents.
Optimized sentence structure for better understanding.

Thank you very much ❤


[BUG] Windows with security problems with the app (bloxstrap).

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
Well, I don't know for sure, it could be because the new version of the application was released yesterday, I've already checked everything and it still shows this false warning on the Windows smartscreen.

Bloxstrap keeps crashing please fix this developer :(

and it still shows this false warning on the Windows smartscreen.


Binary xcframeworks do not seem to be built for distribution

https://github.com/adobe/aepsdk-core-ios/blob/b80fa96731b73e353615513fc17e9af3dfd4db92/Makefile#L153
The correct build constant is BUILD_LIBRARY_FOR_DISTRIBUTION but the Makefile (here and in all other aepsdk-*-ios projects I looked at) misspell it as BUILD_LIBRARIES_FOR_DISTRIBUTION, so that setting has no effect.  The value of YES seems to be set in the project but maybe CocoaPods does something with it.  In any event, when I tried to use a built xcframework with Xcode 16, it tells me that the swift versions do not match, which is usually an indication it was not built for distribution.  It would be nice to be able to use the built xcframeworks (either directly or through a .binaryTarget reference in a package).
The error I get is:
"Failed to build module 'AEPCampaignClassic'; this SDK is not supported by the compiler (the SDK is built with 'Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>)', while this compiler is 'Apple Swift version 6.0.2 effective-5.10 (swiftlang-<IP_ADDRESS>.2 clang-16<IP_ADDRESS>)'). Please select a toolchain which matches the SDK."

OK, following up -- looks like something in my environment was mixing source packages and the binaries.  After a few attempts, I got them to all binaries, and the compile started working.  So while the constant in the Makefiles is wrong, it's not causing incorrect builds.  Sorry for the false alarm :-)

@carllindberg Thanks for bringing this to our attention. We will fix the makefiles.


Amethyst improvements / bug fixes

Correcting Floating Frequency Percentage Issue in Amethyst Node Graphs Using Math.ceil, this happens when you try to load an old .ANG on a newer version of amethyst.

Here are the themes that I pushed
Sapphire

Ruby

Rose

Emerald

Onyx


It shows an incorrect number of visible messages in the original queue explorer if cancel the move messages activity log

Storage Explorer Version: 1.34.0-dev (98)
Build Number: 20240401.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.4(Apple M1 Pro)
Architecture: x64/x64/arm64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Queues.
Create a queue -> Import one csv file that contains more than 32 rows to the queue.
After the csv file has been imported successfully -> Click 'Move -> Move All...' -> Select another queue to move.
Click 'Cancel' next to the move messages activity log.
Go to the original queue explorer.
Check whether it shows a correct number of visible messages.

Expected Experience
It shows a correct number of visible messages.

Actual Experience
It shows an incorrect number of visible messages.

Additional Context
It will show a correct number of visible messages after manually refreshing.

Verified this issue on the main build 20240409.1. Fixed.


Add ambassador_id in the ambassador Module

This optional field was missing, although we have a nice example in the Running Ambassador page.

Hey, thanks for this! Since this is doc-only, can you open it against the ambassador-docs repo? That makes it easier to make it available on the website.
Thanks!

Done 🚀


[spi_device] Upload to use SRAM Grant @ SYS_CLK

Issue was discussed in #10065.
This commit opens grant ports for CmdFifo/AddrFifo in the upload module.
The grant signals come from the SYS SRAM arbiter. With the change, the
module and the SW wait until the request is acked.

Merging now...


Support for Orion to support 2+ clients (especially for inference workloads)

As discussed in https://github.com/eth-easl/orion/issues/24, opening this issue to track Orion's ability to handle multiple clients.

@aravindhank11 I am closing this issue after merging some fixes for multi-client setups.
The mult-client configuration files are structured similarly to the 2-client ones (i.e. the high-priority job is the last one in the configuration file). I added an example here.

Thank you!


Add benchmarks

This PR adds some benchmarks
Benchmark for simple case
Fastify Plugin x 98,947 ops/sec ±2.54% (79 runs sampled)
Fastify Plugin Typescript x 98,539 ops/sec ±1.91% (85 runs sampled)
Fastest is Fastify Plugin Typescript

Benchmark for fastify version checking
Fastify Plugin x 96,928 ops/sec ±2.53% (78 runs sampled)
Fastify Plugin Typescript x 97,231 ops/sec ±1.88% (82 runs sampled)
Fastest is Fastify Plugin Typescript

Benchmark for fastify dependencies checking
Fastify Plugin x 100,273 ops/sec ±1.89% (80 runs sampled)
Fastify Plugin Typescript x 99,840 ops/sec ±1.68% (83 runs sampled)
Fastest is Fastify Plugin

Benchmark for fastify decorators checking
Fastify Plugin x 98,176 ops/sec ±2.01% (80 runs sampled)
Fastify Plugin Typescript x 99,913 ops/sec ±1.75% (84 runs sampled)
Fastest is Fastify Plugin Typescript

tried to open a PR to the wrong repo, sorry 😅


dynamically rendered DOM renders the QR code repeatedly

dynamically rendered DOM renders the QR code repeatedly

This can happen if you have a lot of dynamic DOM


⚠ SolarOscp has degraded performance

In 4d0360e, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 105 ms

Resolved: SolarOscp performance has improved in 5b6af74 after 10 minutes.


docs(admin) Update service pagination info

Summary
While working with pagination in the 0.14.1 version of kong I discovered an inconsistency in behavior between various endpoints that is not reflected by the documentation.
r = requests.get(f'{kong_url}/services')
>>> r.json()['next']
'/services?offset=WyJmNmExOWYzNi1hOGYzLTQzYmMtOWNlMy0wZjcyMjk2ZTU0MWUiXQ'
>>> r = requests.get(f'{kong_url}/plugins')
>>> r.json()['next']
'<kong_url_ommitted>/plugins?offset=Mg%3D%3D&size=100'

The /services endpoint does not include the domain when it returns the url to the next page, but the /plugins endpoint does. Presumably this is fixed in later versions of kong, but the documentation for 0.14 should reflect it. I do not know how far back this problem exists. Please let me know if I should update other older documentation.
Full changelog

Edited docs to reflect actual pagination behavior of the 0.14.X /services endpoint

Checklist:

[x] Commit message & atomicity checked
[ ] Documentation <N/A>
[x] Adheres to Kong style guide
[x] Spellchecked my updates
[ ] Tagged "Team Docs" as reviewers (Do I have to be a member to tag them?)
[x] Ready to be merged

I dont think I have the permissions to tag Team Docs.
@kikito may be able to do it.

@levfishbluefish


docs: add badge for unit tests

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Codecov Report

Merging #333 (7429bf6) into main (d5e8fd7) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   44.31%   44.47%   +0.16%
==========================================
  Files         313      313
  Lines       17822    17753      -69
  Branches     2327     2314      -13
==========================================
- Hits         7897     7895       -2
+ Misses       9924     9858      -66
+ Partials        1        0       -1

Impacted Files
Coverage Δ

...ader/src/scene-loader/resources/TextureResource.ts
0.00% <0.00%> (-6.90%)
:arrow_down:

packages/draco/src/decoder.ts
0.00% <0.00%> (ø)

packages/loader/src/scene-loader/Oasis.ts
0.00% <0.00%> (ø)

...ackages/loader/src/scene-loader/ResourceManager.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e8fd7...7429bf6. Read the comment docs.


Do not erase implicit arguments unless they are marked @0

Currently agda2hs erases all implicit arguments in the translation to Haskell code, which may change the semantics of the program. For example, consider the following program:
open import Haskell.Prelude
open import Haskell.Prim.Bool

data Vec (a : Set) : {n : Nat} → Set where
  Nil  : Vec a {zero}
  Cons : {n : Nat} → a → Vec a {n} → Vec a {suc n}
{-# COMPILE AGDA2HS Vec #-}

sneaky : {n : Nat} → Vec Bool {n} → Int
sneaky     Nil            = 0
sneaky {1} (Cons True xs) = 1
sneaky     (Cons x xs)    = 2
{-# COMPILE AGDA2HS sneaky #-}

result = sneaky (Cons true (Cons false Nil))
{-# COMPILE AGDA2HS result #-}

Agda2Hs translates this to the following:
data Vec a = Nil
           | Cons a (Vec a)

sneaky :: Vec Bool -> Int
sneaky Nil = 0
sneaky (Cons True xs) = 1
sneaky (Cons x xs) = 2

result :: Int
result = sneaky (Cons True (Cons False Nil))

When evaluating result in Agda, the result is 2, however after erasing implicit arguments the result of evaluating result in Haskell is 1. Worse, one could prove a property of an Agda program that fails to hold for the translated Haskell program.
There is a relatively simple way to solve this problem, which is to only erase arguments if they are marked as erased with @0. This way Agda's type system guarantees that the run-time value of an expression does not depend on parts of the expression that are erased. However, this is a quite fundamental change in the current design of Agda2Hs, so it should be considered carefully.
One other advantage of making this change is that it becomes really super simple to explain what parts of the Agda source code are erased: precisely those marked with @0. This is in contrast to the current situation where implicit arguments are erased, irrelevant arguments are erased, and instance arguments are erased sometimes except when they are translated to a constraint instead.
If we decide to go through with this change there's one choice to be made of whether to translate non-erased implicit arguments to explicit arguments in Haskell, or to disallow them completely. My vote would go to the latter option since it is the least likely to lead to confusion or mistakes.

One more thought: if we decide on this approach, we could also require that top-level definitions that should not be compiled to Haskell must be annotated with @0, which would remove the need for having a {-# COMPILE AGDA2HS ... #-} pragma for every definition that you want to compile.

+1 for this, much more intuitive and well behaved!

which would remove the need for having a {-# COMPILE AGDA2HS ... #-} pragma for every definition that you want to compile.

Since we rely on these pragmas to pass additional information to the backend (classes, deriving, etc...), it seems awkward to have only part of the definitions like that. Maybe stick to always having a pragma, to also be consistent with the other major backends?

Yeah after thinking about it some more perhaps getting rid of the pragmas isn't such a good idea after all. In particular, it would require the ability to add @0 annotations to data and record types, which is currently not possible.

After experimenting a bit with this change I've come to the unfortunate conclusion that Agda is currently not quite ready to fully move to erasure annotations for Agda2Hs. In particular, there are two problems with the way type classes are implemented:

When opening a record type with open R {{...}} syntax, the parameters are not marked as erased in the types of the projections (see https://github.com/agda/agda/issues/5769)
The parameters are not marked as erased either in the types of definitions inside a record type, no matter how you open the record module (see https://github.com/agda/agda/issues/5769#issuecomment-1027039109)

Workarounds for both problems are possible but require major changes to the Agda code that make it much less nice to write and look much less like the generated Haskell code, so I gave up on trying those. So unless someone (perhaps @UlfNorell ) thinks of a very clever workaround, we're stuck with the current approach until these two issues are fixed.

So actually the second issue is actually really easy to fix, the only problem is that it breaks some existing code. So I tried adding it under a flag --erase-record-parameters instead: https://github.com/agda/agda/pull/5771/. As a nice bonus, enabling this flag actually also solves the first issue (or rather, it is not an issue anymore in the first place). So one option would be to go through with the change to Agda2Hs proposed here, but for the moment change it to install from an unreleased version of Agda (until a version of Agda with the --erase-record-parameters is released). I could even make a branch of the latest release of <IP_ADDRESS> and backport this flag to it, so that users of Agda2Hs wouldn't have to worry about unreleased changes to Agda. What do you think of this option?

The --erase-record-parameters has been merged into the master branch of Agda, and there have been no negative remarks about this proposal. We also ran five student project with the version of Agda2Hs that relies on explicit erasure annotations, so I believe it is safe to say that this is the way to go forward with Agda2Hs.


Add Crate level documentation and Cargo attributes

Fixes #418
Fixes #423

@AndyGauge I see some travis failures; I suspect they are unrelated to this PR, but would you mind rebasing?

The upgrade from try! to ? has caused 1.12 to error.  I think that's a travis.yml change that is required.  I'll submit an issue.

OK, this is ready for review.
Thanks

Thanks!


Fixes error messages that point to list items

poetry printed a misleading error message when the error stemmed from an item in a field. i didn't add a test because i wasn't able to spot an error messaging related that would exist.

Thanks!


feat: add searchbar

Summary
This PR closes #5  by adding a searchbar.
Functionality implemented

[x] indexes the whole site at build time.
[x] component persistance after view transition.

Functionality to be implemented

[ ] index specific elements instead of whole site.
[ ] component at navbar or only /blog and /learning ?
[ ] dark mode support/ other visual changes.
[ ] fix dev mode.
[ ] filtering/ sorting

@NitanJana Hmm, the default styles do not align with the overall template. I see some loss of UX when doing page transitions. I have changed the base of this branch so that we can more before merging it to main.


Fix NPM publishing

The last published version of the CLI lacks the following items:

The CHANGELOG version should link to a visual diff of all the commits between the version and the previous one. See the bottom of the CHANGELOG.md for examples.

The commit that was published to NPM should have an annotated tag whose value equals vx.y.z, for consistency with the other tags.

These issues were fixed when publishing v4.0.1.


Add Soroban support.

Checklist

[x] App update process has been followed
[x] Target branch is develop
[x] Application version has been bumped

We need to merge this PR first.

Codecov Report
Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (4a4b1cd) 76.87% compared to head (ab094c0) 77.72%.

Files
Patch %
Lines

src/transaction/transaction_parser.c
80.35%
56 Missing :warning:

src/transaction/transaction_formatter.c
91.50%
9 Missing :warning:

src/swap/handle_check_address.c
0.00%
3 Missing :warning:

src/utils.c
75.00%
3 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #81      +/-   ##
===========================================
+ Coverage    76.87%   77.72%   +0.85%
===========================================
  Files           14       14
  Lines         2378     2779     +401
===========================================
+ Hits          1828     2160     +332
- Misses         550      619      +69

Flag
Coverage Δ

unittests
77.72% <82.51%> (+0.85%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Really looking forward to see Soroban supported by the Ledger app!

Due to my plan to submit a new PR with a lot of updates recently, in order to save resources, let's close this PR first.


Inconsistencies in types definitions

The following two definitions are both correct, but they are inconsistent:

A monoid is some data type and a two parameter function ...

An object with a map function that adhere to certains rules. ...

I don't know which of the two is better. The "object with some methods" style of definition, limits us in some ways, for example we cannot say "pure functions form a monoid under functional composition".  The other one seems impractical. Maybe we should incorporate both.

Functions are objects so it's not too much worry to me
On Wed, Mar 23, 2016, 8:30 AM boris<EMAIL_ADDRESS>wrote:

The following two definitions are both correct, but they are inconsistent:
A monoid is some data type and a two parameter function ...
An object with a map function that adhere to certains rules. ...
I don't know which of the two is better. The "object with some methods"
style of definition, limits us in some ways, for example we cannot say
"pure functions form a monoid under functional composition". The other one
seems impractical. Maybe we should incorporate both.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/hemanth/functional-programming-jargon/issues/29

Not my point.
I think we should either say A monoid is...

An object with a map method which accepts a function.
A datastructure plus some method which accepts that datastructure plus a function.

We all know that these two things are essentially the same but we should stick with one of them in order to be consistent (else a person who is reading the docs would presume that there is some difference between the two concepts.
Another way that is more verbose but also clearer is to say both things. Something like...
"A monoid is an object with a map method (or a separate function)..."
Cheers everyone.

I think we should say function instead of method. While methods can be
used, that won't always be true and anything you can do with methods you
can do with functions. Number and add are a monoid but i can't don't expect
it to be implemented as a method, nor for compose
On Fri, Mar 25, 2016, 1:45 AM boris<EMAIL_ADDRESS>wrote:

Not my point.
I think we should either say A monoid is...

An object with a map method which accepts a function.
A datastructure plus some method which accepts that datastructure
plus a function.

We all know that these two things are essentially the same but we should
stick with one of them in order to be consistent (else a person who is
reading the docs would presume that there is some difference between the
two concepts.
Another way that is more verbose but also clearer is to say both things.
Something like...
"A monoid is an object with a map method (or a separate function)..."
Cheers everyone.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/hemanth/functional-programming-jargon/issues/29#issuecomment-201203892

All references to "method" have been removed from the document so I think we can call this resolved.


[cli] add -b, --best-window.

At this point there is an -r parameter but it does not work as described:
-r, --reuse-window                 Force to open a file or folder in the last active window.
Works like:
-b, --best-window                  Force to open a file or folder in the best opened window.
And there is no way to be sure that the file will open in the current window.

The action repair -r is relatively simple  (https://github.com/Microsoft/vscode/issues/51254 I compiled the VSC and check the operation). And to search for the best window worked, propose to add -b.

@MarekLew What does "best" opened window mean?

@RMaclane

...
we can provide the best working environment for a file if it is opened in the context of the folder ...

https://github.com/MarekLew/vscode/commit/9c5b31ef6c6da3a9045c93d677de40ec5519c6e3


Added matchers for Result (#836)

Closes #836

I can't merge yet as it says branch is out of date.

I can't merge yet as it says branch is out of date.

Make sense merge if the tests are not passing by the problem that I reported on the issue?

I can't merge yet as it says branch is out of date.

Make sense merge if the tests are not passing by the problem that I reported on the issue?

I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in.

I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in.

Actually, this PR is a draft. I was planning to remove the draft when I understand and solve the problem I reported on the issue.

There seem to be some failing tests tho.
Could you take a look at them?

I think it just means you need to rebase or something. Not quite sure. Try making another fork/branch and copying the changes in.

Actually, this PR is up-to-date, but it's a draft. I was planning to remove the draft when I understand and solve the problem I reported on the issue.

No I didn't see your comment ?

What is this waiting on? Do I need to do something?

We are waiting for the issue on kotlin to be solved. Please, see the issue from this task, #836 Everything is detailed there

I just pushed the workaround suggested by @sksamuel on the issue. We need to keep tracking the issue on kotlin issue tracker to solve this.

:+1:


Add agent modules health cli

Please ensure your pull request adheres to the following guidelines:

[ x] For first time contributors, read Submitting a pull request
[ x] All code is covered by unit and/or runtime tests where feasible.
[x ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Add hive module health injection to support for module health reporting (pulled from @joamaki prototype)
Add swagger health apis
Surface agent module health via agent CLI

Signed-off-by: Fernand Galiana<EMAIL_ADDRESS>Add Cilium CLI health command to report agent's modules health status.

This is toast! Going to axe and resubmit.


Use Jekyll SEO Tag and Jekyll Feed

This pull request changes the head template to use Jekyll SEO Tag and Jekyll Feed, rather than hard coding the SEO meta and feed template into the site. The idea for both being (A) pulling code out of the site where possible, (B) relying on battle-tested templates that can account for more edge cases, rather than custom logic, and (C) more open source, more better. :smile:
Jekyll feed
There should be little or no change in behavior here, other than using a more widely tested template that can account for all sorts of edge cases, like relative URLs in posts. As an added bonus, it'll now include author information, thumbnails, and a short summary/description in addition to the full post text.
Before

After

Jekyll SEO Tag
Again, the actual change in output should be subtle, but it lets you pull a bunch of code out of the templates and benefit from more widely tested logic/best practices, and subsequent upstream improvements. The big change is the addition of JSON-LD metadata for richer indexing, and the inclusion of author information for posts.
Homepage before
<title>Electron</title>
<meta name='description' content='Build cross platform desktop apps with JavaScript, HTML, and CSS.'>

<meta name="google-site-verification" content="eOAFtDphTbbm4OPKva2d3Z0Z_2bBxWMGdkD0IRQ6VeA" />
<meta name='twitter:card' content='summary_large_image' />
<meta name='twitter:site' content='@electronjs' />
<meta name="twitter:creator" content="@github">
<meta name='twitter:title' content='Electron' />
<meta name='twitter:description' content='Build cross platform desktop apps with JavaScript, HTML, and CSS.' />
<meta name='twitter:image' content='http://electron.atom.io/images/opengraph.png' />
<meta property='og:title' content='Electron' />
<meta property='og:description' content='Build cross platform desktop apps with JavaScript, HTML, and CSS.' />
<meta property='og:type' content='website' />
<meta property='og:url' content='http://electron.atom.io/' />
<meta property='og:image' content='http://electron.atom.io/images/opengraph.png' />
<meta property="og:image:width" content="1200" />
<meta property="og:image:height" content="630" />
<meta property='og:site_name' content='Electron' />
<meta content='#2f3241' name='theme-color' />
<link rel='shortcut icon' href='/images/favicon.ico'/>
<link rel='stylesheet' href='/css/index.css'>
<link rel='canonical' href='http://electron.atom.io/'>
<link rel='alternate' type='application/rss+xml' title='Electron' href='http://electron.atom.io/feed.xml' />

Homepage after
<!-- Begin Jekyll SEO tag v1.4.0 -->
<title>Electron - Build cross platform desktop apps with JavaScript, HTML, and CSS.</title>
<meta property="og:title" content="Electron" />
<meta name="description" content="Build cross platform desktop apps with JavaScript, HTML, and CSS." />
<meta property="og:description" content="Build cross platform desktop apps with JavaScript, HTML, and CSS." />
<link rel="canonical" href="http://electron.atom.io/" />
<meta property="og:url" content="http://electron.atom.io/" />
<meta property="og:site_name" content="Electron" />
<meta property="og:image" content="http://electron.atom.io/images/opengraph.png" />
<meta property="og:image:height" content="630" />
<meta property="og:image:width" content="1200" />
<meta property="og:type" content="article" />
<meta property="article:published_time" content="2016-05-11T10:30:07-04:00" />
<link rel="next" href="http://electron.atom.io/releases/" title="Electron Releases" />
<link rel="prev" href="http://electron.atom.io/docs/guides/" title="Electron Guides" />
<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:site" content="@ElectronJS" />
<meta name="google-site-verification" content="eOAFtDphTbbm4OPKva2d3Z0Z_2bBxWMGdkD0IRQ6VeA" />
<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "WebSite",
  "name": "Electron",
  "headline": "Electron",
  "image": "http://electron.atom.io/images/opengraph.png",
  "datePublished": "2016-05-11T10:30:07-04:00",
  "description": "Build cross platform desktop apps with JavaScript, HTML, and CSS.",
  "logo": "http://electron.atom.io/images/opengraph.png",
  "url": "http://electron.atom.io/"
}
</script>
<!-- End Jekyll SEO tag -->
<link type="application/atom+xml" rel="alternate" href="http://electron.atom.io/feed.xml" title="Electron" />

Post before
<title>Electron 1.0</title>
<meta name='description' content='For the last two years, Electron has helped developers build cross platformdesktop apps using HTML, CSS, and JavaScript. Now we’re excited to share a majormi...'>

<meta name="google-site-verification" content="eOAFtDphTbbm4OPKva2d3Z0Z_2bBxWMGdkD0IRQ6VeA" />
<meta name='twitter:card' content='summary_large_image' />
<meta name='twitter:site' content='@electronjs' />
<meta name="twitter:creator" content="@github">
<meta name='twitter:title' content='Electron 1.0' />
<meta name='twitter:description' content='For the last two years, Electron has helped developers build cross platformdesktop apps using HTML, CSS, and JavaScript. Now we’re excited to share a majormi...' />
<meta name='twitter:image' content='http://electron.atom.io/images/opengraph.png' />
<meta property='og:title' content='Electron 1.0' />
<meta property='og:description' content='For the last two years, Electron has helped developers build cross platformdesktop apps using HTML, CSS, and JavaScript. Now we’re excited to share a majormi...' />
<meta property='og:type' content='website' />
<meta property='og:url' content='http://electron.atom.io/blog/2016/05/11/electron-1-0' />
<meta property='og:image' content='http://electron.atom.io/images/opengraph.png' />
<meta property="og:image:width" content="1200" />
<meta property="og:image:height" content="630" />
<meta property='og:site_name' content='Electron' />
<meta content='#2f3241' name='theme-color' />
<link rel='shortcut icon' href='/images/favicon.ico'/>
<link rel='stylesheet' href='/css/index.css'>
<link rel='canonical' href='http://electron.atom.io/blog/2016/05/11/electron-1-0'>
<link rel='alternate' type='application/rss+xml' title='Electron' href='http://electron.atom.io/feed.xml' />

Post after
<!-- Begin Jekyll SEO tag v1.4.0 -->
<title>Electron 1.0 - Electron</title>
<meta property="og:title" content="Electron 1.0" />
<meta name="description" content="For the last two years, Electron has helped developers build cross platformdesktop apps using HTML, CSS, and JavaScript. Now we’re excited to share a majormilestone for our framework and for the community that created it. The releaseof Electron 1.0 is now available from electron.atom.io." />
<meta property="og:description" content="For the last two years, Electron has helped developers build cross platformdesktop apps using HTML, CSS, and JavaScript. Now we’re excited to share a majormilestone for our framework and for the community that created it. The releaseof Electron 1.0 is now available from electron.atom.io." />
<link rel="canonical" href="http://electron.atom.io/blog/2016/05/11/electron-1-0" />
<meta property="og:url" content="http://electron.atom.io/blog/2016/05/11/electron-1-0" />
<meta property="og:site_name" content="Electron" />
<meta property="og:image" content="http://electron.atom.io/images/opengraph.png" />
<meta property="og:image:height" content="630" />
<meta property="og:image:width" content="1200" />
<meta property="og:type" content="article" />
<meta property="article:published_time" content="2016-05-11T00:00:00-04:00" />
<link rel="prev" href="http://electron.atom.io/blog/2016/03/25/electron-37" title="What's new in Electron 0.37" />
<meta name="twitter:card" content="summary_large_image" />
<meta name="twitter:site" content="@ElectronJS" />
<meta name="twitter:creator" content="@jlord" />
<meta name="google-site-verification" content="eOAFtDphTbbm4OPKva2d3Z0Z_2bBxWMGdkD0IRQ6VeA" />
<script type="application/ld+json">
  {
    "@context": "http://schema.org",
    "@type": "BlogPosting",
    "headline": "Electron 1.0",
    "image": "http://electron.atom.io/images/opengraph.png",
    "datePublished": "2016-05-11T00:00:00-04:00",
    "description": "For the last two years, Electron has helped developers build cross platformdesktop apps using HTML, CSS, and JavaScript. Now we’re excited to share a majormilestone for our framework and for the community that created it. The releaseof Electron 1.0 is now available from electron.atom.io.",
    "logo": "http://electron.atom.io/images/opengraph.png",
    "url": "http://electron.atom.io/blog/2016/05/11/electron-1-0"
  }
</script>
<!-- End Jekyll SEO tag -->
  <link type="application/atom+xml" rel="alternate" href="http://electron.atom.io/feed.xml" title="Electron" />

Other changes
Beyond adding the two plugins, I ran bundle update, hence the updated Gemfile.lock noise.
Last, by adding :group => :jekyll_plugins to the Gemfile, the Pages Gem will set configuration defaults for you, so we were able to remove some default from the site config.

/cc @leereilly :eyes:

Some quick feedback (haven't pulled this down locally to test):
1. The og:type for the homepage should be website (and I think it's safe to drop article:published_time too).
2. The blog post authors in the posts are GitHub handles. They're not guaranteed to be the same as the author's Twitter handle. E.g. the following twitter:creator markup would be inaccurate as @jlord's handle on Twitter is @jllord:
<meta name="twitter:creator" content="@jlord" />

3. I don't think it makes sense to include the prev/next link tags on the static pages here. E.g. the individual guides (as they are now at least) are grouped, ordered alphabetically, and not really a paginated collection:
<link rel="next" href="http://electron.atom.io/releases/" title="Electron Releases" />
<link rel="prev" href="http://electron.atom.io/docs/guides/" title="Electron Guides" />

I don't think it makes sense to include the prev/next link tags on the static pages here

The behavior of these is going to change via https://github.com/jekyll/jekyll-seo-tag/pull/87.

The og:type for the homepage should be website (and I think it's safe to drop article:published_time too).

The issue is that the site's using a collection called _pages to group pages. Which isn't how the feature's intended to be used, but didn't think reorganizing the site was within the scope of this pull request.

The blog post authors in the posts are GitHub handles. They're not guaranteed to be the same as the author's Twitter handle.

We can add Twitter handles, if we want, the plugin supports it. Again, didn't think it was within the scope of this PR, but glad to add 'em.

. Again, didn't think it was within the scope of this PR, but glad to add 'em.

It feels within scope of this PR since before this information wasn't present and now in this PR it is present but inaccurate

@benbalter :wave: any updates here regarding the issues @leereilly raised? Each of the three issues he raised seem worth addressing in this pull request. Thanks.

any updates here regarding the issues @leereilly raised?

Next/Previous - Will be addressed in the next release of Jekyll SEO via https://github.com/jekyll/jekyll-seo-tag/pull/87.

Twitter handles - Will add them to the PR

Type - Will update the PR to use pages as pages, rather than a collection called pages, unless there's any reason not to do so.

Address Twitter handles, type, and date published via https://github.com/electron/electron.atom.io/pull/248/commits/059ba663acfb65a82a16767fb7e22d8f5fd9dacd and https://github.com/electron/electron.atom.io/pull/248/commits/9f66f701fc5b2c5c9df3bd234a18a2266faaf2ec.
Will get https://github.com/jekyll/jekyll-seo-tag/pull/87 on to Pages shortly, which, once it does, should address all of the above concerns.

Will get jekyll/jekyll-seo-tag#87 on to Pages shortly, which, once it does, should address all of the above concerns.

Pages now runs Jekyll SEO Tag v2.0.0, which includes https://github.com/jekyll/jekyll-seo-tag/pull/87.
Believe this should be good to go from my point of view.

Believe this should be good to go from my point of view.

@benbalter did this pull request change the <title> tags for each page?
When I run script/server locally, the main page's title is now <title>Electron - Electron</title>. On the current site it generates as just <title>Electron</title>

did this pull request change the  tags for each page?

Great catch. With 1157530, the homepage title is now Electron - Build cross platform desktop apps with JavaScript, HTML, and CSS..
For the other pages, since many all already in the form of "Election X", we have two options:

Tell the plugin not to touch the titles and blindly output <title>{{ page.title }}</tittle> for all pages. This wouldn't help pages like http://electron.atom.io/docs/tutorial/application-distribution/, which would just have a title of "Application Distribution" (unless we updated them all to be, e.g., "Electron Application Distribution")

Change the page titles to just X, e.g., "Guides", "Releases", and let the plugin append " - Electron" so the titles would be, e.g., "Releases - Electron" and "Guides - Electron". I find this format makes tab titles a bit more friendly, and it'd help the docs pages, but it's really a matter of preference.

Awesome, looks great to now, I'll create a follow on pull request that drops the Electron prefix from the pages you mentioned.
Thanks so much for this @benbalter, really appreciate it 👍 💚 🚢

My pleasure. Sorry it took so long, and thanks for helping to make the plugin better for users (and other GitHub sites).
One thing to note, it looks like the auto-generated excerpt is off for some of the docs. In the config, we've got excerpt_separator: "---", which means it's trying to split the docs on the first HR, which doesn't always exist (thus the full body is being crammed into the description).
The best solution, would be to remove that flag (I don't see the custom excerpt being used anywhere), which would default things to "\n\n", and allow the first paragraph to become the auto-generated excerpt when one isn't manually provided.
But... the docs have the title as an H1 in the doc body, meaning, the autogenerated excerpt and the title would be the same. Unless the docs are used elsewhere, glad to submit a PR to remove the H1 from the document body, and update the template to include <h1>{{ page.title }}</h1> if you're interested, which should allow Jekyll to properly grab the first paragraph as an excerpt for descriptions.

One thing to note, it looks like the auto-generated excerpt is off for some of the docs.

Yeah, good point, thanks for mentioning that, will take a look, /cc @jlord

Thanks for adding this stuff, @benbalter!


Test FailureReason struct when executing contracts

Possible Failure reasons

[ x] Out of gas #600

[ ] Deploy failure


Merge into community repository?

I note that there are many commits on top of Russell91's code at:
https://github.com/taylorskalyo/sshrc
Would it be worthwhile merging some of those commits, or perhaps starting a community repo (sshrc/sshrc) based off that code?
Thanks very much for the AUR package, BTW :partying_face:

Moving into [community] requires an Arch TU, it's their decision if they want to merge it.
I can take a look at the other commits to see if any are worth merging some time, sure.

Just looking at this again, are there some commits or fixes  in particular which you were thinking about merging from https://github.com/taylorskalyo/sshrc? Happy to cherry pick some, but the whole thing looks like almost a total rework.

Looking more into that codebase I'd agree -- there's a lot of improvements in there, including the -J to ssh.
Just a thought: perhaps it would be better to package that one if it's more up to date?

You can see all active forks and sort by "Last Push" to find some more actively maintained forks…


using Axios for REST API call

Better to add them as Community Helpers. https://github.com/Codeception/CodeceptJS/wiki/Community-Helpers


Improve Style bindings with Animated

This PR updates Style module to reduce complexity when working with Animated values. Fixes #246
It's a breaking change. There's no Interpolated(value) now to be used when defining a style. Use Animated(value) instead.
Note: Before merging, let me check all the properties to make sure we allow Animated values where React Native supports them. Would be great to have a type-error instead of a runtime red screen when trying to animate a non-supported property. That's a secondary thing. Let me know by reviewing this PR whether you like the overall idea.

We should also check what values accept Animated and what not to protect against runtime errors.

It is a breaking change and removes Interpolated from styles in favor of using Animated everywhere.

@grabbou don't be discouraged by my use of Request Changes. It has this scary red look but I don't mean it 😄. I just try to communicate clearly.

Thanks for the review! You are totally right. Just updated the PR.

Yeah, I auto-generated this file one more time after changing types here and there. I would leave it as is unless there's a way to add white-spaces automatically. Otherwise, might be a bit tricky to maintain in the future.


improve tts

Hi, me again.
I'm training your tts. My dataset is about 16 hours
First, because my dataset utterance is similar to yours, I'm training acoustic model use 2 approach:

Continue to train your acoustic_checkpoint to 1.46M step: val loss:0.227 and it's gonna converge.

Here is my result:

Train from scratch: about 800k step - val loss: 0.301

Here is full detail : https://drive.google.com/drive/folders/1j0OT7KgJOk5hmcOVNPdcdkaekRRxHekk?usp=sharing
Second, I train Hifigan Vocoder (with acoustic 1.46M) about 290k step:
My transcript text: "xin chào tôi là phương anh bản thử số chín"

I got this : https://drive.google.com/file/d/1UtgE1gTC8mwo1SV1b7chauvWPC7uPjxM/view?usp=sharing
=> The result that speaker talk non-sense but intonation is quite good.

Here is 50k vocoder + 1.46M acoustic, just to compare:
https://drive.google.com/file/d/1InQ8ykYC_P7qaKhv_58SmTC0r-b_4_0h/view?usp=sharing

And from 50k vocoder + 800k from scratch: https://drive.google.com/file/d/1E-FjOfBqFf9vHTKXmAUhamtB2FsAlAMT/view?usp=sharing

I got stuck, should I focus on acoustic or vocoder or dataset to improve the result ?
Thanks!

It seems to me that you are using a wrong lexicon file when generating speech.
The default scripts use the lexicon file assets/infore/lexicon.txt from Infore dataset, when working with your own dataset, you should replace it with your lexicon file.

I don't think so, in lexicon file just convert word to characters. I also record audio with text the same to the original dataset

In the function,
https://github.com/NTT123/vietTTS/blob/346d46798ab066014b64d971be0735f3f3019703/vietTTS/nat/data_loader.py#L11
we use the lexicon file to compute phoneme set, and use that set to compute phoneme index. A mismatched phoneme set at training and inference will cause problems.

So, I have to train again or replace my lexicon file ?

My advice is to use the lexicon file that is used to train your model. Usually, it is at train_data/lexicon.txt
Generate speech with:
python3 -m vietTTS.synthesizer \
  --lexicon-file=train_data/lexicon.txt \
  --text="hôm qua em tới trường" \
  --output=clip.wav

I got confused, because when training I'm use your lexicon file (because my audio is the same to the orginal). I already change to your instruction, but result is the same

@Lethanhson9901, can you show a few lines in your train_data/lexicon.txt and an example *.textgrid file?
I suspect that there is a mismatch somewhere as your loss, mel-spectrogram seems alright to me.

https://drive.google.com/drive/folders/1l2DstG-l77AGvXpQdtayegOfA9X1yIwC?usp=sharing

@Lethanhson9901 Everything seems alright to me. I don't think I can help much in this case.

@Lethanhson9901
My advice:

train duration (10 minutes) and acoustic model (50 minutes) on InfoRE dataset and generate speech to make sure everything is working correctly (even though the speech is not good but it should be understandable )

train duration (10 minutes) and acoustic model (50 minutes) on Your dataset and generate speech (using your the pretrained hifigan). The speech should be understandable.

Thanks for your help !

I'll try. Many thanks !

Hey, Thanks god, you're right. And it's work

B.t.w, if I want the voice is more natural and better, which part of training I should focus to ? Or pre-process data ? (like denoising, ...) and should I use audio augmentation in training ( by now I don't think it's work)

@Lethanhson9901
I'm not sure data augmentation can help. There are few things that can help:

A better dataset:

Better recording voice: clear voice, correct pronunciation.
Higher sample rate, 16k -> 22k -> 24k -> 48k
More data: 20hours -> 40 hours -> 100 hours
Better text transcripts: cover all Vietnamese phonemes with approximately equally phoneme's frequencies.
Clean the dataset: make sure text and speech are perfectly matched.

Bigger model:

If you have more data, use decoder RNNs with 1024 units (currently, it currently is 512 on InfoRE dataset)

Train acoustic model and Hifigan model longer.
Fine-tune Hifigan model with your acoustic model.

One more, I see the different between pretrain and train from scratch data:
Here is detail: https://drive.google.com/drive/folders/1r_jLDO2EL7NcYrn4A7LFIbK3PM8aY_uV?usp=sharing
Pretrain : 1.49M acoustic + 505k vocoder: the audio is noisy
=> Q1: Can I improve it by train more acoustic or hifigan ?
Scratch: 900k acoustic + 505k vocoder: is clean but not smooth like pretrain
=> Q2: I can't train more acoustic because it's converge. So how can I improve ?

Hey, Thanks god, you're right. And it's work

Hi, How did you fix it? I got the same issue!

Hi @NTT123,
Could you please give me an instruction on how I can modify the decoder RNNs with 1024 units for my dataset?

@nampdn You will need to modify the file vietTTS/nat/config.py by setting acoustic_decoder_dim=1024

Fantastic, thank you!


Remeber settings if installed

Does not remember custom network settings after closing when using as a service

Okay, it's a know issue, but are there any plans to fix this?

Probably not any time soon as it has to be changed to persist that information. If this is being installed as a service, it seems unlikely that most people will be frequently enabling/disabling the proxy, which is where this is useful.

Hi. I previous used DNSCryptWin-v0.0.6.exe, and this is the first day I use this dnscrypt-winclient. Thanks for this great work.
I also find that it doesn't remember the custom setting after closing, but I don't know whether I am running it as a service. I just open the dnscrypt-winclient.exe file, select the network devices for use of it, select the provider, and leave everything else untouch, and then click 'start'. This way does not remember my setting. What does it mean by 'Install'? If I install it, will it remember the setting? And by installing, do I install it with the provider I selected or could I switch to another provider later even if I install it now?
Another question is, what does that mean by 'act as a gateway device'? I tried to select this option, but the then when using ipconfig to check my device's gateway, it still shows my wifi router as gateway, not this one.

Probably that's a UX issue. (the buttons are not self-explanatory)
So I'll try to explain them:

'start'.

Starts the dnscrypt-proxy exe with the current settings. After a computer restart the process will not be restarted again.

'Install'

Installs dnscrypt-proxy as a Windows service, which starts when the computer starts.

If I install it, will it remember the setting?

The UI does not show the settings, but dnscrypt-proxy will remember the settings and use them at every start.

do I install it with the provider I selected

Yes.

could I switch to another provider later even if I install it now?

Yes, but AFAIK you have the first choose your new provider and install it ("on top" of the previous "installation").

'act as a gateway device'

This allows other devices in your LAN to use the device where dnscrypt-proxy is running as a DNS server.

Hi rugk. Thanks a lot for the clear explanation. There is one question left: if I choose a new provider, and then click the 'install' again, would it replaces the previous installation, or do I have to uninstall the previous installation first? You said it would be "on top" of the previous "installation", but I don't know what that "on top" exactly mean. Thanks.

AFAIK it replaces the previous settings.

Thanks!

This client can remember setting now.

I guess we can expect this pull request to be received, we can get the solution with this request.

Recently DNSCrypt introduced a configuration file to load & save settings, so I think we can get the way to fix this issue.


Module does not seem to be on terraform registry yet

Hi
I just found this awesome tf module and wanted to test it but I can't as the module does not seem to be released on terraform registry: https://registry.terraform.io/namespaces/jenkins-x
Maybe it is because there is still some work to do before opening it to the public ?
Let me know if I can help with anything !

/assign @chrismellard

Now the CI is almost there I'll look at getting the release sorted to publish this to registry

It think @rawlingsj is going to raise an  issue with Hashicorp as we're unable to figure out why this module won't publish on there.

Is this to be pushed to the Terraform registry soon?

We're able to use the module using the git source, for example https://github.com/jx3-gitops-repositories/jx3-azure-terraform/blob/270267bd03e59c32faab4fed8e688bd18fe36896/main.tf#L2
As we're able to do that I've not pursued Hashicorp as it wasn't obvious the right channel to go down.  If someone knows a good way to raise issues then we should take it up with them for sure.


auth-error :google cloud  invalid jwt issue

i am facing issue while annotation of  encoded image using LABEL_DETECTION of  google vision api.

Can you paste the traceback?

Please feel free to re-open if you can provide more information.


Hello, my account has been disabled, but I have not sent spam harassment emails. I am just sending a notification email to the users of my company website. Can I verify and release the account suspension? I am unable to submit a new technical request for support. I am very anxious to use!                                                                  Looking forward to your reply

Expected content
Actual content
Link to page:

Hello sigle0724,
We're sorry you're running into this issue! You can access support contact options by logging into https://support.sendgrid.com.
SendGrid Docs Team


Update index.md

testing github action

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Status code 302, Something went wrong when try two step verification and enter security code.

Version:
raiym/instagram-php-scraper v0.10.1
Code:
$instagram = \InstagramScraper\Instagram::withCredentials(new \GuzzleHttp\Client(), $username, $password, new \Phpfastcache\Helper\Psr16Adapter('Files'));
$instagram->login(false, true);
$instagram->saveSession();

Result:
Select where to send security code
Phone: +** *** *** **** - 0
Email<EMAIL_ADDRESS>- 1
Your choice: 1
Enter security code: 111111

Error:
Fatal error: Uncaught InstagramScraper\Exception\InstagramAuthException: Something went wrong when try two step verification and enter security code. Please report issue. in C:\Nabi\wamp\instagram\instagram-php-scraper\vendor\raiym\instagram-php-scraper\src\InstagramScraper\Instagram.php:1808
Stack trace:
#0 C:\Nabi\wamp\instagram\instagram-php-scraper\vendor\raiym\instagram-php-scraper\src\InstagramScraper\Instagram.php(1650): InstagramScraper\Instagram->verifyTwoStep(Object(InstagramScraper\Http\Response), Array, Object(InstagramScraper\TwoStepVerification\ConsoleVerification))
#1 C:\Nabi\wamp\instagram\instagram-php-scraper\save_medias.php(55): InstagramScraper\Instagram->login(false, Object(InstagramScraper\TwoStepVerification\ConsoleVerification))
#2 {main}
  thrown in C:\Nabi\wamp\instagram\instagram-php-scraper\vendor\raiym\instagram-php-scraper\src\InstagramScraper\Instagram.php on line 1808

Source:
https://github.com/postaddictme/instagram-php-scraper/blob/1e7545ec2df2c0532d6bd7255cb60d269a5ed113/src/InstagramScraper/Instagram.php#L1808
Response:
InstagramScraper\Http\Response Object
(
    [code] => 302
    [raw_body] =>
    [body] =>
    [headers] => Array
        (
            [Content-Type] => Array
                (
                    [0] => text/html; charset=utf-8
                )

            [Location] => Array
                (
                    [0] => https://www.instagram.com/
                )
:
:

Seem the allow_redirects was should be enable.

I was update to dev-master 530c2a5 but still have same error: Instagram.php:1846

I was update to dev-master 530c2a5 but still have same error: Instagram.php:1846

Same issue here... @NabiKAZ have u been able to fix?

Same issue here... @NabiKAZ have u been able to fix?

This is what i am getting on examples/twoStepAutoVerification/loginWithEmailAutoCponfirm.php
{ code: 429, raw_body: "{"message":"","spam":true,"status":"fail"}", body: { message: "", spam: true, status: "fail" }, headers: { Content-Type: [ "application/json; charset=utf-8" ], Vary: [ "Accept-Language, Cookie" ], Content-Language: [ "en" ], Date: [ "Fri, 08 Jan 2021 10:58:59 GMT" ], Strict-Transport-Security: [ "max-age=31536000" ], Cache-Control: [ "private, no-cache, no-store, must-revalidate" ], Pragma: [ "no-cache" ], Expires: [ "Sat, 01 Jan 2000 00:00:00 GMT" ], X-Frame-Options: [ "SAMEORIGIN" ], content-security-policy: [ "report-uri https://www.instagram.com/security/csp_report/; default-src 'self' https://www.instagram.com; img-src data: blob: https://*.fbcdn.net https://*.instagram.com https://*.cdninstagram.com https://*.facebook.com https://*.giphy.com; font-src data: https://*.fbcdn.net https://*.instagram.com https://*.cdninstagram.com; media-src 'self' blob: https://www.instagram.com https://*.cdninstagram.com https://*.fbcdn.net; manifest-src 'self' https://www.instagram.com; script-src 'self' https://instagram.com https://www.instagram.com https://*.www.instagram.com https://*.cdninstagram.com wss://www.instagram.com https://*.facebook.com https://*.fbcdn.net https://*.facebook.net 'unsafe-inline' 'unsafe-eval' blob:; style-src 'self' https://*.www.instagram.com https://www.instagram.com 'unsafe-inline'; connect-src 'self' https://instagram.com https://www.instagram.com https://*.www.instagram.com https://graph.instagram.com https://*.graph.instagram.com https://*.cdninstagram.com https://api.instagram.com https://i.instagram.com wss://www.instagram.com wss://edge-chat.instagram.com https://*.facebook.com https://*.fbcdn.net https://*.facebook.net chrome-extension://boadgeojelhgndaghljhdicfkmllpafd blob:; worker-src 'self' blob: https://www.instagram.com; frame-src 'self' https://instagram.com https://www.instagram.com https://*.instagram.com https://staticxx.facebook.com https://www.facebook.com https://web.facebook.com https://connect.facebook.net https://m.facebook.com; object-src 'none'; upgrade-insecure-requests" ], cross-origin-embedder-policy-report-only: [ "require-corp;report-to="coep"" ], report-to: [ "{"group": "coep", "max_age": 86400, "endpoints": [{"url": "/security/coep_report/"}]},{"group": "coop", "max_age": 86400, "endpoints": [{"url": "/security/coop_report/"}]}" ], origin-trial: [ "AuqWincgAuXeuu3KypEMnrrFEJHySaesyJS3EaIH40zvafzrU0Irhb7+5QwZpOqMZrPTjgvFl7Z5jJgy1dNAcQMAAAB6eyJvcmlnaW4iOiJodHRwczovL2luc3RhZ3JhbS5jb206NDQzIiwiZmVhdHVyZSI6IkNyb3NzT3JpZ2luT3BlbmVyUG9saWN5UmVwb3J0aW5nIiwiZXhwaXJ5IjoxNjEzNDExNjYyLCJpc1N1YmRvbWFpbiI6dHJ1ZX0=" ], cross-origin-opener-policy: [ "same-origin-allow-popups;report-to="coop"" ], X-Content-Type-Options: [ "nosniff" ], X-XSS-Protection: [ "0" ], x-aed: [ "37" ], Access-Control-Expose-Headers: [ "X-IG-Set-WWW-Claim" ], Set-Cookie: [ "ig_did=52A6277B-33A5-4799-BE11-71B1C97B1E69; Domain=.instagram.com; expires=Sun, 08-Jan-2023 10:58:59 GMT; HttpOnly; Max-Age=63072000; Path=/; Secure", "mid=X_g68wALAAHqCuNQJGbMHHEaYefC; Domain=.instagram.com; expires=Sun, 08-Jan-2023 10:58:59 GMT; Max-Age=63072000; Path=/; Secure" ], X-FB-TRIP-ID: [ "1679558926" ], Alt-Svc: [ "h3-29=":443"; ma=3600,h3-27=":443"; ma=3600" ], Connection: [ "keep-alive" ], Content-Length: [ "42" ] } }

This is what i am getting on examples/twoStepAutoVerification/loginWithEmailAutoCponfirm.php
{ code: 429, raw_body: "{"message":"","spam":true,"status":"fail"}", body: { message: "", spam: true, status: "fail" }, headers: { Content-Type: [ "application/json; charset=utf-8" ], Vary: [ "Accept-Language, Cookie" ], Content-Language: [ "en" ], Date: [ "Fri, 08 Jan 2021 10:58:59 GMT" ], Strict-Transport-Security: [ "max-age=31536000" ], Cache-Control: [ "private, no-cache, no-store, must-revalidate" ], Pragma: [ "no-cache" ], Expires: [ "Sat, 01 Jan 2000 00:00:00 GMT" ], X-Frame-Options: [ "SAMEORIGIN" ], content-security-policy: [ "report-uri https://www.instagram.com/security/csp_report/; default-src 'self' https://www.instagram.com; img-src data: blob: https://*.fbcdn.net https://*.instagram.com https://*.cdninstagram.com https://*.facebook.com https://*.giphy.com; font-src data: https://*.fbcdn.net https://*.instagram.com https://*.cdninstagram.com; media-src 'self' blob: https://www.instagram.com https://*.cdninstagram.com https://*.fbcdn.net; manifest-src 'self' https://www.instagram.com; script-src 'self' https://instagram.com https://www.instagram.com https://*.www.instagram.com https://*.cdninstagram.com wss://www.instagram.com https://*.facebook.com https://*.fbcdn.net https://*.facebook.net 'unsafe-inline' 'unsafe-eval' blob:; style-src 'self' https://*.www.instagram.com https://www.instagram.com 'unsafe-inline'; connect-src 'self' https://instagram.com https://www.instagram.com https://*.www.instagram.com https://graph.instagram.com https://*.graph.instagram.com https://*.cdninstagram.com https://api.instagram.com https://i.instagram.com wss://www.instagram.com wss://edge-chat.instagram.com https://*.facebook.com https://*.fbcdn.net https://*.facebook.net chrome-extension://boadgeojelhgndaghljhdicfkmllpafd blob:; worker-src 'self' blob: https://www.instagram.com; frame-src 'self' https://instagram.com https://www.instagram.com https://*.instagram.com https://staticxx.facebook.com https://www.facebook.com https://web.facebook.com https://connect.facebook.net https://m.facebook.com; object-src 'none'; upgrade-insecure-requests" ], cross-origin-embedder-policy-report-only: [ "require-corp;report-to="coep"" ], report-to: [ "{"group": "coep", "max_age": 86400, "endpoints": [{"url": "/security/coep_report/"}]},{"group": "coop", "max_age": 86400, "endpoints": [{"url": "/security/coop_report/"}]}" ], origin-trial: [ "AuqWincgAuXeuu3KypEMnrrFEJHySaesyJS3EaIH40zvafzrU0Irhb7+5QwZpOqMZrPTjgvFl7Z5jJgy1dNAcQMAAAB6eyJvcmlnaW4iOiJodHRwczovL2luc3RhZ3JhbS5jb206NDQzIiwiZmVhdHVyZSI6IkNyb3NzT3JpZ2luT3BlbmVyUG9saWN5UmVwb3J0aW5nIiwiZXhwaXJ5IjoxNjEzNDExNjYyLCJpc1N1YmRvbWFpbiI6dHJ1ZX0=" ], cross-origin-opener-policy: [ "same-origin-allow-popups;report-to="coop"" ], X-Content-Type-Options: [ "nosniff" ], X-XSS-Protection: [ "0" ], x-aed: [ "37" ], Access-Control-Expose-Headers: [ "X-IG-Set-WWW-Claim" ], Set-Cookie: [ "ig_did=52A6277B-33A5-4799-BE11-71B1C97B1E69; Domain=.instagram.com; expires=Sun, 08-Jan-2023 10:58:59 GMT; HttpOnly; Max-Age=63072000; Path=/; Secure", "mid=X_g68wALAAHqCuNQJGbMHHEaYefC; Domain=.instagram.com; expires=Sun, 08-Jan-2023 10:58:59 GMT; Max-Age=63072000; Path=/; Secure" ], X-FB-TRIP-ID: [ "1679558926" ], Alt-Svc: [ "h3-29=":443"; ma=3600,h3-27=":443"; ma=3600" ], Connection: [ "keep-alive" ], Content-Length: [ "42" ] } }

The next day, after resetting my PC, The problem was solved by itself!

The next day, after resetting my PC, The problem was solved by itself!