Merge two different objects by a key

it might be best to have feature like linq query that we can merge different objects by a key and return new object without using foreach and create a different object.
ex:
$scope.obj1={id:001, name:jone};
$scope.obj2={empid:001, employeeType: permanent }
Expect : $scope.obj3={id:001,name:jone, empid:001, employeeType: permanent}
to get this we have to write foEach, compare keys and push. but if we have something like below would be great
data-ng-options="o.id for o in obj1 JOIN obj2 | where:  obj1 .id==obj2.empid"
{{o.id}} {{o.name}} {{o.employeeType}}

@lilan123 yes, this sounds like a handy utility, but it is probably better done outside of the core. We are trying to limit number of utilities in the framework to keep in lean and focused.
I'm afraid that we are going to pass on this one...

when you think of an application performance if we do this outside of the core will be leaded to performance issues. lets say if it is a huge data set comes from the API where API no longer accessible for modification this kind of features will lead the much user friendly framework. why wouldn't be added this to core and it won't break anything?

@lilan123 the same work needs to be done, inside or outside of the core - I don't see how embedding the same code in the framework make it more performant...
The downside of embedding it in the core is that it makes the core bigger for everyone, even for people that don't need this feature....

Just a heads-up: You don't necessarily need a forEach to accomplish property merging into a new object (in the controller).
Based on the nature of your objects, angular.extend() might do the trick (in a less verbose way):
var obj1 = {...};
var obj2 = {...};
var obj3 = angular.extend({}, obj1, obj2);

Well, it is not really, var obj3 = angular.extend({}, obj1, obj2); will give a new merge object without compare the keys of merging objects. it has to be in forEach. :)
ex:
$scope.obj1={id:001, name:jone};
$scope.obj2=[{empid:001, employeeType: permanent },{empid:002, employeeType: permanent }]
Expect : $scope.obj3={id:001,name:jone, empid:001, employeeType: permanent}

That's why I said "based on the nature of your objects" :)
In your initial example obj2 was an object. If it is an array of objects, the logic needs to be changed (the same holds when using forEach).
For your second example, the following might work (still being less verbose than forEaching):
var obj3 = angular.extend.apply(null, [{}, obj1].concat(obj2));

I am really sorry, feel like i forgot my manners. Thanks a lot for the help.
But anyway not only this purpose like looping and merging. If we can have something like Lambda Expressions from angularJs core will be great feature for developers. :)

Based on the description of #11175, it seems like I totally misunderstood your usecase.
My suggested solution (using angular.extend()) is invalid.
Sorry for that :)


Error handlers for fail requests

The error handlers developed by @J535D165 are delivered to the front end with custom error messages.

[x] Home screen

[x] Project page

[x] Article panel in the review zone

[x] Server connection error

[ ] ......

When fail to retrieve projects on the home screen:

When fail to open a project:

When fail to retrieve new documents in the review zone:

When the server connection is down:

@terrymyc super nice!
@JoukjeWillemsen did you already design a graphic to use here?

@terrymyc super nice!
@JoukjeWillemsen did you already design a graphic to use here?

Really nice, that we give feedback on problems that can occur (good user feedback). The only remark I have is the text for this one: When the server connection is down: "The software has been shut down". That raises questions like; "But I am in the software right now, and it is still running (for example). Consider to make it like: "Connection lost with the server".
Still, good job! The User Experience Value will go up, thanks to you!

When the server connection is down: "The software has been shut down". That raises questions like; "But I am in the software right now, and it is still running (for example). Consider to make it like: "Connection lost with the server".

@MartijnUX Thanks! Good point! See the changed screenshot above.


Bumped dependencies

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   92.12%   92.12%
=======================================
  Files          17       17
  Lines         546      546
  Branches       14       14
=======================================
  Hits          503      503
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 591f434...e359874. Read the comment docs.


Fixing the issue when getting null field at translator, Update logProcessorEnabled into True

Issue #, if available:
Fixing the An issue when we handler an object contains null field.
Description of changes:
Update logProcessorEnabled into True
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Also, please close our #25 since this PR includes those changes.


Bluetooth communication

Would be possible somehow that the lock is unlocked via bluetooth (like when you don't have the bridge)? I believe this would make it faster and also more reliable for those who live in apartments and have to drop connection when getting inside the lift and then facing a situation where they leave the lift, there is still not 100% 4G available and the home wifi at the door is trying to connect.

Although I do believe that it’s possible, it would require reverse engineering the Bluetooth communication, for which I don’t have the knowledge or time to do it.
Unless anyone else is willing to do this and open a PR, I’ll be closing this issue.


add test case with EKU in CSR

The PR adds a test with CSR that contains a timestamping EKU (generated using https://github.com/dmitris/gencert/tree/csr-eku, go run main.go).  The test attempts to verify that the generated Certificate does contain that EKU - but currently it fails.  We need to figure out why and what's going on.
Failing test output (below and build output):
$ go test -v -run '^TestDecodeRequest/good-req-nonempty-eku$'

=== RUN   TestDecodeRequest
=== PAUSE TestDecodeRequest
=== CONT  TestDecodeRequest
=== RUN   TestDecodeRequest/good-req-nonempty-eku
=== PAUSE TestDecodeRequest/good-req-nonempty-eku
=== CONT  TestDecodeRequest/good-req-nonempty-eku
2023/07/14 20:45:16 [INFO] good-req-nonempty-eku, EKU #0: 2
2023/07/14 20:45:16 [INFO] good-req-nonempty-eku, EKU #1: 1
    encode_test.go:169: good-req-nonempty-eku: ExtKeyUsageTimeStamping (8) not found
--- FAIL: TestDecodeRequest (0.00s)
    --- FAIL: TestDecodeRequest/good-req-nonempty-eku (0.00s)
FAIL
exit status 1
FAIL	github.com/theparanoids/crypki/x509cert	0.418s

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

replaced by https://github.com/theparanoids/crypki/pull/29 (the draft PR was a demo)


Cyanogenmod 12.1 stuck - selinux

Program starts and stays at "opening /dev/hidg0 and /dev/hidg1".
Found a closed issue from prodoomman, he told me to either write a selinux policy for hidg* or deactivate selinux. I can't write policys but deactivating it did the trick.
As the program already asks for root permissions this is quite annoying

Good point.
I'll make it deactivate SELinux automatically in the next version.
On Mon, Jun 29, 2015 at 8:48 PM, 0uro<EMAIL_ADDRESS>wrote:

Program starts and stays at "opening /dev/hidg0 and /dev/hidg1".
Found a closed issue from prodoomman, he told me to either write a selinux
policy for hidg* or deactivate selinux. I can't write policys but
deactivating it did the trick.
As the program already asks for root permissions this is quite annoying
—
Reply to this email directly or view it on GitHub
https://github.com/pelya/android-keyboard-gadget/issues/30.

I still dont like the idea also in redhat selinux preinstalled when there are more to chose from.
So thats a yes please.
I like apparmor couse it keeps freedom of choice instead of bricking your distro by removal.


Compatibility with runtime type checkers

Goal: support beartype like runtime type checkers for tensor shape, type checking.
Question: do we need it, or does type checking come for free with onnx?
Related:

beartype discussion https://github.com/beartype/beartype#jax-arrays
Jaxtyping https://github.com/google/jaxtyping
torchtyping https://github.com/patrick-kidger/torchtyping

@gramalingam mypy doesn't seem to play nicely with these types
https://github.com/microsoft/onnx-script/blob/main/onnxscript/onnx_types.py#L67-L82
is there a way we can reconcile this?

I think there is non-trivial work to be done for integrating the multiple requirements here. There are one or two things to be done first:
(a) Aaron has a first extension to enable intellisense in visual-code and other environments.
(b) We need to integrate the type annotation classes with the actual runtime class (tensor.Tensor).
As for integrating it with other runtime and static type-checkers, that could be more complex. I don't have an answer off the top of my head. It's worth looking into. If you have suggestions, please let me know, thanks.

With regards to the earlier question: for onnxscript code, I think we can do the checking ourselves (both statically and dynamically) and I think that will be better (than trying to use other systems), at least that is my first reaction. However, using the other checkers for our code, in general, may be useful. When we do that, we may run into some issues in the test-related code, where both code co-exist.

BTW, what is the specific issue with mypy? It is possible that Aaron's PR in-progress, which makes FLOAT etc. derived classes of TensorType, might fix it. (Though, generally, there are broader challenges in handling things like FLOAT["M", "N"] etc.)


ZulipRemoteUserBackend not functioning with simple setup

I can't get the ZulipRemoteUserBackend to work properly in it's simplest form. I keep getting the htpasswd login dialog, then I get redirected to "https://zulip.olindata.vm/accounts/login/sso/?next=/". With a red message saying: "Enter a valid email address."
None of the error logs tell me anything useful so far.
I am probably doing something wrong on the zulip-sso backend of things, but I can't figure out what
Here's what I have tried:

install git and vim, you'll need them: aptitude install git vim

add hosts entry to /etc/hosts so it looks something like this:
root@zulip:~# cat /etc/hosts
<IP_ADDRESS> localhost
<IP_ADDRESS> galera001
<IP_ADDRESS> galera002
<IP_ADDRESS> galera003
<IP_ADDRESS> master
<IP_ADDRESS> zulip.olindata.com zulip

create the required ssl certs:
apt-get install openssl
openssl genrsa -des3 -passout pass:x -out server.pass.key 4096
openssl rsa -passin pass:x -in server.pass.key -out zulip.key
rm server.pass.key
openssl req -new -key zulip.key -out server.csr
openssl x509 -req -days 365 -in server.csr -signkey zulip.key -out zulip.combined-chain.crt
rm server.csr
cp zulip.key /etc/ssl/private/zulip.key
cp zulip.combined-chain.crt /etc/ssl/certs/zulip.combined-chain.crt

Get Zulip:
wget https://www.zulip.com/dist/releases/zulip-server-latest.tar.gz
tar -xf zulip-server-latest.tar.gz
mv zulip-server-1.3.7 /root/zulip

Run the installer: /root/zulip/scripts/setup/install

Configure settings.py:
sed -i 's/example.com/olindata.com/g' /etc/zulip/settings.py
sed -i "s/#.*backends.ZulipRemoteUser.*$/'zproject.backends.ZulipRemoteUserBackend',/g" /etc/zulip/settings.py
sed -i 's/SSO_APPEND_DOMAIN = None/SSO_APPEND_DOMAIN = "olindata.com"/g' /etc/zulip/settings.py

Set up the apache SSO backend:
sed -i 's/puppet_classes.*/puppet_classes = zulip::voyager, zulip::apache_sso/g' /etc/zulip/zulip.conf
/home/zulip/deployments/current/scripts/zulip-puppet-apply
mv /etc/apache2/sites-available/zulip-sso.example /etc/apache2/sites-available/zulip-sso.conf
sed -i 's/example.com/olindata.com/g' /etc/apache2/sites-available/zulip-sso.conf
aptitude install apache2-utils
htpasswd -bc /home/zulip/zpasswd<EMAIL_ADDRESS>olindata
a2ensite zulip-sso
service apache2 restart

run the initial db script: su zulip -c /home/zulip/deployments/current/scripts/setup/initialize-database

thanks for posting a detailed report of what you did!  I don't see anything obviously wrong; can you check the logs to see exactly what step is failing to happen properly?

${APACHE_LOG_DIR}/zulip_auth_access.log
If this is empty you may want to change LogLevel to "debug" in the apache config file

/var/log/zulip/{errors.log,server.log}
/var/log/nginx/access.log

Since this will likely help with debugging, here's a summary of how this system works:

Since you've configured /etc/zulip/settings.py to only define the zproject.backends.ZulipRemoteUserBackend, zproject/settings.py makes the non-logged-in homepage /accounts/login/sso
you visit /accounts/login/sso/ to try to login
nginx proxies the request to apache via the config in /etc/nginx/zulip-include/app.d/external-sso.conf (using the upstream localhost:8888 defined in /etc/nginx/zulip-include/upstreams)
The Apache zulip-sso site which you've enabled listens on localhost:8888 and presents the htpasswd dialogue; you provide correct login information and it sends the request with REMOTE_USER set to the WSGI copy of the Zulip django instance being run via Apache ; that request goes to zerver.view.remote_user_sso, which just checks the REMOTE_USER variable and either logs in (sets a cookie) or registers the new user (depending whether they have an account).
That process then redirects the user back to the nginx instance, which sees the cookie and loads the site homepage with them logged in.

This system is a little finicky to network setup in particular (e.g. issues with /etc/hosts not mapping settings.EXTERNAL_HOST to the Apache listening on localhost, for example).  So I would try things like changing your /etc/hosts to have zulip.olindata.com zulip resolve to <IP_ADDRESS> (or change the Apache config to listen on all interfaces rather than just <IP_ADDRESS>) as you debug this.  I also seem to recall in the past it being helpful to change /etc/nginx/zulip-include/app.d/external-sso.conf to proxy_pass to a more explicit URL possibly not over HTTPS when debugging.
Let me know if there's anything else I can do to help!  Would love to expand the instructions here to be super clear and easy to follow (also I should note if you have any config changes you need to files installed via puppet we should try to get those fixes into mainline so that your server doesn't break on every upgrade with puppet overwriting the config).

@timabbott thanks for the itemized explanation of how the ZulipRemoteUserBackend works, that should go straight into the documentation I'd say ;)
I ran the login while tail -f'ing the log files you listed and it leads to the followign output:
root@zulip:~# tail -f /var/log/apache2/zulip_auth_*.log /var/log/zulip/{errors.log,server.log} /var/log/nginx/access.log
2015-11-09 18:54:57,234 INFO     Tornado   0.0% busy over the past 60.0 seconds
2015-11-09 18:55:02,914 INFO     <IP_ADDRESS>       GET     302   1ms / (unauth via ?)

==> /var/log/nginx/access.log <==
<IP_ADDRESS> - - [09/Nov/2015:15:55:02 -0800] "GET / HTTP/1.1" 302 5 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:02 -0800] "GET /accounts/login/sso?next=/ HTTP/1.1" 301 193 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

==> /var/log/apache2/zulip_auth_access.log <==
<IP_ADDRESS> - - [09/Nov/2015:15:55:02 -0800] "GET /accounts/login/sso/?next=/ HTTP/1.1" 401 796 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

==> /var/log/nginx/access.log <==
<IP_ADDRESS> - - [09/Nov/2015:15:55:02 -0800] "GET /accounts/login/sso/?next=/ HTTP/1.1" 401 381 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

==> /var/log/zulip/server.log <==
2015-11-09 18:55:03,232 INFO     Tornado   0.0% busy over the past 60.0 seconds
2015-11-09 18:55:08,233 INFO     Tornado   0.1% busy over the past 60.0 seconds

==> /var/log/apache2/zulip_auth_error.log <==
[Mon Nov 09 18:55:11.218380 2015] [:error] [pid 11493:tid<PHONE_NUMBER>89696] 2015-11-09 18:55:11,218 INFO     <IP_ADDRESS>       GET     200  10ms (db: 1ms/2q) /accounts/login/sso/ (unauth via ?)

==> /var/log/zulip/server.log <==
2015-11-09 18:55:11,218 INFO     <IP_ADDRESS>       GET     200  10ms (db: 1ms/2q) /accounts/login/sso/ (unauth via ?)

==> /var/log/nginx/access.log <==
<IP_ADDRESS> -<EMAIL_ADDRESS>[09/Nov/2015:15:55:11 -0800] "GET /accounts/login/sso/?next=/ HTTP/1.1" 200 1346 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

==> /var/log/apache2/zulip_auth_access.log <==
<IP_ADDRESS> -<EMAIL_ADDRESS>[09/Nov/2015:15:55:11 -0800] "GET /accounts/login/sso/?next=/ HTTP/1.1" 200 1916 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

==> /var/log/nginx/access.log <==
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/min/common.3591e79c495e.css HTTP/1.1" 200 119352 "https://zulip.olindata.vm/accounts/login/sso/?next=/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/min/portico.b75db56fba37.css HTTP/1.1" 200 73276 "https://zulip.olindata.vm/accounts/login/sso/?next=/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/min/common.72b7e7fcaf20.js HTTP/1.1" 200 148967 "https://zulip.olindata.vm/accounts/login/sso/?next=/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/min/signup.4b95190e1421.js HTTP/1.1" 200 23479 "https://zulip.olindata.vm/accounts/login/sso/?next=/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET<EMAIL_ADDRESS>HTTP/1.1" 200 10142 "https://zulip.olindata.vm/accounts/login/sso/?next=/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/third/sourcesans/SourceSansPro-Regular-webfont.3c2733515735.woff HTTP/1.1" 200 86252 "https://zulip.olindata.vm/static/min/portico.b75db56fba37.css" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/third/sourcesans/SourceSansPro-Light-webfont.3ccd984982c5.woff HTTP/1.1" 200 82976 "https://zulip.olindata.vm/static/min/portico.b75db56fba37.css" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"
<IP_ADDRESS> - - [09/Nov/2015:15:55:11 -0800] "GET /static/third/zocial/zocial-regular-webfont.7be15762b0d7.ttf HTTP/1.1" 200 18805 "https://zulip.olindata.vm/static/min/portico.b75db56fba37.css" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

==> /var/log/zulip/server.log <==
2015-11-09 18:55:14,234 INFO     Tornado   0.1% busy over the past 60.0 s

I'll now go take a look at the other pointers you gave to see if I can spot the problem.

@walterheck ok submitted a PR to put a cleaned up version of this into the documentation: https://github.com/zulip/zulip/pull/288
Definitely let me know if you figure out what's broken!  Would love to have a clear solution we can post.

@timabbott I can't seem to find out what the problem really is. Can you (or anyone else) reproduce my problem anyway?

I do note that when I use the above instructions and then reboot my virtualbox node, it comes back with a rabbitmq-server service that fails to start.
application_start_failure,kernel,{{shutdown,{failed_to_start_child,net_sup,{shutdown,{failed_to_start_child,net_kernel,{'EXIT',nodistribution}}}}}

Does that mean anything to you?

Search this issue tracker for the issues on AMQP/rabbitmq/epmd; there's a bunch of tickets about rabbitmq not starting that have a few different causes -- from insufficient RAM, to /etc/hosts configuration, etc.  See if any of those work for you...
I don't have a setup handy for doing a reproducer but if you aren't able to figure this out I might have time this weekend to try reproducing.

This was resolved with #288.


live <=master

Docs Build status updates of commit db670cf:
:warning: Validation status: warnings

File
Status
Preview URL
Details

advocates/index.html.yml
:warning:Warning
View
Details

advocates/abhishek-gupta.yml
:white_check_mark:Succeeded

advocates/map.yml
:white_check_mark:Succeeded
View

advocates/media/profiles/abhishek-gupta.jpg
:white_check_mark:Succeeded

advocates/rod-trent.yml
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

advocates/index.html.yml

Line 10, Column 8: [Warning-file-not-found] Invalid file link: './map'.
Line 12, Column 8: [Warning-file-not-found] Invalid file link: './tweets'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Import team from Pokémon Showdown for team defense mode

The https://www.pkmn.help/defense/team/ mode is helpful, and I'd love it if I could simply copy the exported text version of a team from Pokémon Showdown instead of entering in the types and abilities myself for each Pokémon. The exported text will have slightly different details depending on the generation (like tera types), but the types and ability (if Gen III+) are all that should be needed.
Example of the type of text from Gen IX that'd be able to be imported:
Heracross @ Flame Orb
Ability: Guts
Tera Type: Normal
EVs: 252 Atk / 4 Def / 252 Spe
Jolly Nature
- Megahorn
- Close Combat
- Trailblaze
- Facade

I've only played Showdown a couple times so I had to go mess around with the team builder to see what you meant... I think the main issue here would be looking up Pokemon with their forms correctly
Alomomola @ Eviolite
Ability: Hydration
Tera Type: Water
IVs: 0 Atk

Calyrex-Ice
Ability: As One (Glastrier)
Tera Type: Psychic

Calyrex-Shadow
Ability: As One (Spectrier)
Tera Type: Psychic

Calyrex
Ability: Unnerve
Tera Type: Psychic

Muk-Alola
Ability: Poison Touch
Tera Type: Poison

In this example Ice Rider Calyrex is called Calyrex-Ice... so I'd have to perform some kind of "best match" search to find the most similar sounding Pokemon to what was entered. Since ultimately my page doesn't care about individual monsters at all, just type combos... and I don't use shortened versions of the names.
I'm unsure if there's other things like abilities that may not map well. Pokemon Showdown supports 10000x more stuff than my site does haha...
Apparently you can enter nicknames too, so the parsing format gets even more complicated. I'm no stranger to writing parsers, but it's hard to know what possibilities I even need to support 🤔


Additional folder icons

A few additional folder icons would be really nice.
Would also be in keeping with the file icons.

Add folder icon
Open folder icon

Adding an open folder gives active state in tree views.

Adding a create folder icon syncs with the create file icon

Just added the "create" folder 🤙

@sschoger awesome thanks!


[Bug]: Logged out user still able to perform transactions

Description
After a user logs out, they can still be able to perform transactions including viewing history or buying airtime.
Steps to reproduce

Open Stax App
Click on Settings on the top right
Scroll down and click log out, confrim log out
Perform any transaction on the app - buy airtime, check history.

Expected result

As a user, when a log out I should be taken to a screen where I should be able to login again.
I should not be able to check history of the logged out account

Actual result
I am not taken to the login screen and I am able to check transactions of the logged out account.
Link to screenshots/screen recordings
https://drive.google.com/file/d/1Izfmq4vGVDGG_VCJaRE83mwT-9_OnhO2/view?usp=sharing
Device name
Redmi 9A
Android OS
10
Is your phone dual SIM or single SIM?
Dual SIM
Which telco are you using for this test?
Safaricom
Stax device ID or email address
5ea7f09261718216

@kibettheophilus thank you for this, this is expected and we plan on making product improvements in the future. We will scope your request in line with our product roadmap.


Feature/cloudinary image upload

Summary

adding the configuration of Cloudinary  for managing images in the application.
adding middleware formData in formData.ts file in midleware folder.
adding a POST request to the "/test-formdata" endpoint in app.ts

The environment variables were defined to configure the Cloudinary library in the application.
To load the environment variables, the dotenv library had to be installed using npm and then the environment variables were loaded in this way:
require("dotenv").config();

The name of the endpoint that uses the 'formdata' middleware in app.ts has been changed to: "/send-formdata"


misleading error when wrong MIME type returned

I created a Vue CLI 3 app with the PWA plugin, and followed instructions to test locally by serving the dist directory with a simple http server.
When I used the python's SimpleHTTPServer, I received the error: Error during service worker registration: Error: Service worker not found at ./service-worker.js.
This was misleading because the file was indeed served successfully. Had to debug the module to find that the content type wasn't returned as text/javascript by the python server.
I suggest emitting a more precise error in this case.
I'm happy to PR.

If the client-side thrown error actually contains information indicating it's about wrong MIME type, then yes. But I doubt it.

I think the culprit is this line:
    if (         response.status === 404 ||         response.headers.get('content-type').indexOf('javascript') === -1       )
I saw that indeed response.status is 200, so we can split the conditions and in the second case emit another error. What do you think?

Yeah, that makes sense

Great, I will make a PR soon


quantification of PAS usage by APAIQ

How to quantify?
Quantification is very important for me; it is my purpose.

"python APAIQ/regression/evaluateRegression.v.2.py   -h"  showed:
usage: evaluateRegression.v.2.py [-h] --model MODEL --factor_path FACTOR_PATH
[--input_file INPUT_FILE]
[--input_plus INPUT_PLUS]
[--input_minus INPUT_MINUS]
[--pas_file PAS_FILE] [--out OUT]
[--threshold THRESHOLD] [--depth DEPTH]
[--window WINDOW] [--genome GENOME]
Evaluate each locus with RNAseq coverage exceed threshold and return prediction score.
optional arguments:
-h, --help                   show this help message and exit
--model MODEL         the model weights file
--factor_path FACTOR_PATH               normalization file path
--input_file INPUT_FILE                       unstranded bedGraph file
--input_plus INPUT_PLUS                    plus strand bedGraph file
--input_minus INPUT_MINUS              minus strand bedGraph file
--pas_file PAS_FILE    pAs location file to be predicted expression level
--out OUT                 output file path
--threshold THRESHOLD                        peak length lower than threshold will be fiter out
--depth DEPTH               total number of mapped reads( in millions)
--window WINDOW       input length
--genome GENOME       assembly name of the genome. i.e. hg19, hg38, mm10

For FACTOR_PATH, should I chang normalize_factor for my data ? https://github.com/christear/APAIQ_release/tree/main/regression
PAS_FILE is the output of apaiq?
--genome is required ?
Could you please write wiki or detail steps for apaiq ? Thanks.

I tried evaluateRegression.v.2.py and apaiq_reg, but there is error:
Evaluation based on regression model
Loading RNAseq coverage
Reading facotrs from APAIQ/regression/normalize_factor
loading the PAS list from 1_APAIQ_All60/mRNA_SRR8462062_GSM3572799_NA18498_Input.predicted.txt
Traceback (most recent call last):
File "/home/yp/.conda/envs/apaiq_env/bin/apaiq_reg", line 33, in
sys.exit(load_entry_point('apaiq==1.2.0', 'console_scripts', 'apaiq_reg')())
File "/home/yp/.conda/envs/apaiq_env/lib/python3.7/site-packages/apaiq-1.2.0-py3.7.egg/apaiq/evaluateRegression_v2.py", line 111, in main
ValueError: could not convert string to float: 'chr1:+:1'

Please used common bed-format files as input of regression model, in which the 5th column should be numbers. The APAIQ output is in bed graph format that is convenient to load to genome browser for visualization. I will add more details for regression.

Please used common bed-format files as input of regression model, in which the 5th column should be numbers. The APAIQ output is in bed graph format that is convenient to load to genome browser for visualization. I will add more details for regression.

The 5th column of BED is the 4th column of apaiq output?

Please just use the provided files under regression directory. The output of the regression model is RPM (reads per million) and you need to calculate pas usage by yourself.

Please just use the provided files under regression directory. The output of the regression model is RPM (reads per million) and you need to calculate pas usage by yourself.

How to calculate? Could you please give a link?

You need to annotate PAS firstly by overlapping the identified PAS with gene annotation. Next for each gene, the usage of each PAS was calculated by PAS_expression/Sum of PAS_expression from this gene. There is not available link for this.

You need to annotate PAS firstly by overlapping the identified PAS with gene annotation. Next for each gene, the usage of each PAS was calculated by PAS_expression/Sum of PAS_expression from this gene. There is not available link for this.

OK. Thanks.
BTW: Although more than 10 tools are available for APA analysis, but all of them have some big drawbacks
https://rnajournal.cshlp.org/content/29/12/1839.full
Hope your tool will be maintained and updated, and will work well.

I met the same problem. The quantification of PAS usage can not be executed with the apaiq_reg command although I used the data in the APAIQ_release-main/demo file.

The error should be caused by the head. I will modify the code to skip this.

The problem should be solved with the latest version of the code.

The problem should be solved with the latest version of the code.

ok, many thanks. I will try it again with the latest code.

The problem should be solved with the latest version of the code.

ok, many thanks. I will try it again with the latest code.

Now, it did not occur error by using the data in the APAIQ_release-main/demo file. But when I applied it to my RNA-seq data of drosophila. It raised an error "Error message was: * Input error: Chromosome chr2L doesn't present in the .genome file. "

The most important thing I want to know is whether this software could be used for drosophila melanogaster.

It would be better to retrain a model specifically for fruit fly.


Chore: Update link to lavalink-basic-bot.rs

Update the link to lavalink-basic-bot.rs in the twilight example.

Simple enough; thanks!


release the cumulation buffer after firing upstream

I opened a jira issue for the bug:
https://issues.jboss.org/browse/NETTY-453
This patch is applied to 3.2 and master branch. So it will be part of 3.2.7.Final. Thanks


logging library doesn't seem to work well with spyder

Hello,
I'm trying to run a script using python standard library 'logging' module. This script works fine from Python IDE but when run from Spyder, it can't adjust the level and save log.
import logging
logging.basicConfig(level=logging.WARNING)
logging.debug('Hello debug!')
logging.info('Hello info!')
logging.warning('Hello warning!')
logging.error('Hello error!')
logging.critical('Hello critical!')
=====================================
import logging
logging.basicConfig(filename='example.log',level=logging.DEBUG)   #level is not workable
logging.debug('This message should go to the log file')
logging.info('So should this')
logging.warning('And this, too')
======================================

Hi @Ian19890607 thanks for the feedback! I think the problem is that is not possible to dynamically re-config the logging once you have call baseConfig (basically you can only call baseConfig one time to setup the params of the logging). Checking, seems like starting from Python 3.8 a force argument was added to enable recalling the baseConfig and overwriting the previously setup params.
For more info you can check:

https://stackoverflow.com/q/12158048
https://docs.python.org/3.8/library/logging.html?highlight=logging#logging.basicConfig (basicConfig -> This function does nothing if the root logger already has handlers configured, unless the keyword argument force is set to True.)

Since seems like this is not directly related with Spyder so I'm closing the issue. I hope the info above helps you :)

Hi @Ian19890607 thanks for the feedback! I think the problem is that is not possible to dynamically re-config the logging once you have call baseConfig (basically you can only call baseConfig one time to setup the params of the logging). Checking, seems like starting from Python 3.8 a force argument was added to enable recalling the baseConfig and overwriting the previously setup params.
For more info you can check:

https://stackoverflow.com/q/12158048
https://docs.python.org/3.8/library/logging.html?highlight=logging#logging.basicConfig (basicConfig -> This function does nothing if the root logger already has handlers configured, unless the keyword argument force is set to True.)

Since seems like this is not directly related with Spyder so I'm closing the issue. I hope the info above helps you :)

@dalthviz   Thank you for your quick reply. But I didn't call basicConfig twice.  Sorry to confuse you, previous posts are two example codes.
I should say, "basicConfig " is invalid for spyder, but it is workable on Python official IDE.  Maybe you can trial un on two example codes (I provided previously) in spyder IDE and modify the parameters in the "basicConfig", you will find out what I want to express.

@dalthviz   Thank you for your quick reply. But I didn't call basicConfig twice.  Sorry to confuse you, previous posts are two example codes.
I should say, "basicConfig " is invalid for spyder, but it is workable on Python official IDE.  Maybe you can trial un on two example codes (I provided previously) in spyder IDE and modify the parameters in the "basicConfig", you will find out what I want to express.

Oh I see @Ian19890607 I'm reopening this one then. However, testing I was able to correctly set the config calling basicConfig. Just in case, how are you running the snippets you mention? and what is the version of Spyder that you are using? (the current release and the version I checked this is 4.2.1). Also, if you can, please submit here a GIF or video to check the way this behavior is being trigger in your side (since I'm being unable to reproduce it).
Also, take into account that running a file multiple times will make him run in the same IPython Console (current one or dedicated depending in your per file run configurations) so the values that set the config of the logging will be the ones in the initial run of the file unless you restart your IPython Console or pass the force argument (as mentioned if you have Python 3.8+).
Any new info to reproduce this is greatly appreciated :)

Oh I see @Ian19890607 I'm reopening this one then. However, testing I was able to correctly set the config calling basicConfig. Just in case, how are you running the snippets you mention? and what is the version of Spyder that you are using? (the current release and the version I checked this is 4.2.1). Also, if you can, please submit here a GIF or video to check the way this behavior is being trigger in your side (since I'm being unable to reproduce it).
Also, take into account that running a file multiple times will make him run in the same IPython Console (current one or dedicated depending in your per file run configurations) so the values that set the config of the logging will be the ones in the initial run of the file unless you restart your IPython Console or pass the force argument (as mentioned if you have Python 3.8+).
Any new info to reproduce this is greatly appreciated :)

Closing due to lack of response


Only one receive state reference is needed in the broadcast_audio_sink sample

Describe the bug
In  broadcast_audio_sink/main.c there are two bt_bap_scan_delegator_recv_state pointers referencing the same address:
static const struct bt_bap_scan_delegator_recv_state *sink_recv_state;
const struct bt_bap_scan_delegator_recv_state *broadcast_recv_state;

In function pa_sync_req_cb(), both these pointers get assigned the passed recv_state parameter.
There should only be need for one pointer here : static const struct bt_bap_scan_delegator_recv_state *sink_recv_state
To Reproduce
Code observation
Expected behavior
No effect on the application behaviour
Impact
It will add confusion for other developers
Logs and console output
N/A
Environment (please complete the following information):

OS: Windows 11
Zephyr main branch
Latest commit

@Thalley


Enable unused variable error prone check

#4188 Enable UnusedVariable error prone check

@brandboat many thanks for taking the unused var check to the completion. Good job!


Footnote normalize transformer.

As discussed in #256.

Typo found in filename: Please rename NormilizeFn.test.js to NormalizeFn.test.js.

Pardon me.

Tests are correct so far, but could be split into separate tests instead of checking everything in one. Better do "test normalize disp-quote wrapped in p" and "test normalize element-citation > disp-quote".
Example with element-citation is actually unlikely to happen (and maybe not a good test) as that would be invalid JATS. If you have time, please see if there's a better example that would pass JATS but should be turned into a p element too. or stripped completely.
For example someone could do this silly thing:
<fn>

<fig>Fig 1
<title>bla</title>
the caption text

<graphic></fig>

</fn>

The only valid thing you could do here is dropping everything except for the p elements in the structure. Like fn.find('p p') - find all nested p's and pull them out to the top level:
<fn>

the caption text

</fn>

If no nested p's are found in the weird structure then and p must be created e.g.
<fn>

<graphic/>

</fn>

to
<fn>

</fn>

That's what transformer doing already, but in other way.
My idea was to test that there that footnote didn't contain any other things except paragraph, e.g. there is no disp-quote, <element-citation> there. However you are definitely right that it should be valid JATS, I will do this with your example, thx.


"Operation not permitted" messages logged after initialization

I want to establish an MPTCP connection between two servers with multiple subflows on each side.
Configuration of both servers

multiple CPUs
4-port 1 Gbps Ethernet interface
Linux Fedora 38 Server (up-to-date)
Linux Kernel 6.6.2-101.fc38.x86_64
mptcpd-0.11-2.fc38 installed
sudo ip mptcp limit show
add_addr_accepted 3 subflows 3

Configuration of server 1

sudo ip mptcp endpoint show
<IP_ADDRESS> id 1 signal subflow dev eno1
<IP_ADDRESS> id 2 signal subflow dev eno2
<IP_ADDRESS> id 3 signal subflow dev eno3
<IP_ADDRESS> id 4 signal subflow dev eno4

Configuration of server 2

sudo ip mptcp endpoint show
<IP_ADDRESS> id 1 signal subflow dev eno0
<IP_ADDRESS> id 2 signal subflow dev eno1
<IP_ADDRESS> id 3 signal subflow dev eno2
<IP_ADDRESS> id 4 signal subflow dev eno3

On both servers the mptcpd service could be started but logs "Operation not permitted" messages.
Service logs (reversed order) - mptcpd
12:11 PM add_addr: Operation not permitted
12:11 PM set_limits: Operation not permitted
12:11 PM add_addr: Operation not permitted
12:11 PM set_limits: Operation not permitted
12:11 PM add_addr: Operation not permitted
12:11 PM set_limits: Operation not permitted
12:11 PM add_addr: Operation not permitted
12:11 PM set_limits: Operation not permitted (2 occurrences)
12:11 PM MPTCP single-subflow-per-interface path manager initialized.
12:11 PM MPTCP address advertiser path manager initialized.
12:11 PM Started mptcp.service - Multipath TCP service.
Log message details
set_limits: Operation not permitted
CODE_FILE
commands.c
CODE_FUNC
mptcpd_check_genl_error
CODE_LINE
71
PRIORITY
3
_BOOT_ID
271ac867969843c09c09ed3c84cfc958
_CAP_EFFECTIVE
1000
_CMDLINE
/usr/libexec/mptcpd --log=journal
_COMM
mptcpd
_EXE
/usr/libexec/mptcpd
_GID
62966
_HOSTNAME
HP-DL380-1
_MACHINE_ID
fbfba620f3184e6fb75ce66a4090bfe8
_PID
1784
_RUNTIME_SCOPE
system
_SELINUX_CONTEXT
system_u:system_r:mptcpd_t:s0
_SOURCE_REALTIME_TIMESTAMP
1701343190958054
_SYSTEMD_CGROUP
/system.slice/mptcp.service
_SYSTEMD_INVOCATION_ID
9d552c1842244fda9d963265648ca149
_SYSTEMD_SLICE
system.slice
_SYSTEMD_UNIT
mptcp.service
_TRANSPORT
journal
_UID
62966
__CURSOR
s=c3ce83a68e9e4cc99c5dd7f4f91e3a23;i=77b46;b=271ac867969843c09c09ed3c84cfc958;m=17a557b;t=60b5cd489c412;x=80846d23a838ac4f
__MONOTONIC_TIMESTAMP
24794491
__REALTIME_TIMESTAMP
1701343190959122
add_addr: Operation not permitted
CODE_FILE
commands.c
CODE_FUNC
mptcpd_check_genl_error
CODE_LINE
71
PRIORITY
3
_BOOT_ID
271ac867969843c09c09ed3c84cfc958
_CAP_EFFECTIVE
1000
_CMDLINE
/usr/libexec/mptcpd --log=journal
_COMM
mptcpd
_EXE
/usr/libexec/mptcpd
_GID
62966
_HOSTNAME
HP-DL380-1
_MACHINE_ID
fbfba620f3184e6fb75ce66a4090bfe8
_PID
1784
_RUNTIME_SCOPE
system
_SELINUX_CONTEXT
system_u:system_r:mptcpd_t:s0
_SOURCE_REALTIME_TIMESTAMP
1701343199804620
_SYSTEMD_CGROUP
/system.slice/mptcp.service
_SYSTEMD_INVOCATION_ID
9d552c1842244fda9d963265648ca149
_SYSTEMD_SLICE
system.slice
_SYSTEMD_UNIT
mptcp.service
_TRANSPORT
journal
_UID
62966
__CURSOR
s=c3ce83a68e9e4cc99c5dd7f4f91e3a23;i=77c51;b=271ac867969843c09c09ed3c84cfc958;m=201533a;t=60b5cd510c1d1;x=ebc3b2a80e6ec26f
__MONOTONIC_TIMESTAMP
33641274
__REALTIME_TIMESTAMP
1701343199805905
Expected behavior
There are no errors/warnings after service mptcpd has been started and initialized.

Happening to me in an up to date RHEL 9.4 server...

The set_limits and add_addr operations executed by the addr_adv plugin require the CAP_NET_ADMIN capability if not running as root.  Otherwise those operations will result in the "Operation not permitted" (EPERM) error that you're seeing.
The mptcpd.service systemd unit file used to start mptcpd should already set up the necessary capabilities for the mptcp dynamic user under which mptcpd runs.  If you're running mptcpd without systemd and want to use the addr_adv plugin without running as root, you'll have to explicitly set the CAP_NET_ADMIN capability, as described in the README.

With the mptcpd-0.8-3.el9 package installed it doesn't work.
If I run it as root manually with /usr/libexec/mptcpd then it does work.
Maybe some other capability is needed too?
# systemctl cat mptcp
# /usr/lib/systemd/system/mptcp.service
# SPDX-License-Identifier: BSD-3-Clause
#
# Copyright (c) 2017-2019, Intel Corporation

[Unit]
Description=Multipath TCP service
Documentation=man:mptcpd(8)

[Service]
Type=simple
DynamicUser=yes
ExecStart=/usr/libexec/mptcpd --log=journal
CapabilityBoundingSet=CAP_NET_ADMIN
AmbientCapabilities=CAP_NET_ADMIN
LimitNPROC=1

[Install]
WantedBy=sockets.target

Thanks!!


Fix kube2sky flakes. Fix tools.GetEtcdVersion to work with etcd > 2.0.7

Etcd has a race where <url>/v2/members returns an empty list of client IDs, and the go-etcd client library interprets this as a single machine with url "". This causes requests to fail, and retry forever (https://github.com/coreos/go-etcd/issues/210).
This updates kube2sky to initialize the client until it has an actual url for a machine.
In the process of debugging this, I also upgraded the etcd in the kube-dns pod to 2.0.9. This failed (https://github.com/GoogleCloudPlatform/kubernetes/issues/6852) until I updated the GetEtcdVersion() function to handle etcd > 2.0.7 (string version instead of JSON).
Once this gets an LGTM, I'll push a 1.3 of kube2sky to google_containers and change the skydns rc spec to point at it.

Travis & Shippable both failed.

CJ this is awesome. Well debugged!  Have you run the DNS e2e test over this a few times?  I'd recommend at least 10 times, creating a fresh test cluster each time.
Also, build is failing with:
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/tools/etcd_helper_test.go:710: assignment count mismatch: 3 = 2
_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/tools/etcd_helper_test.go:725: assignment count mismatch: 3 = 2
FAIL	github.com/GoogleCloudPlatform/kubernetes/pkg/tools [build failed]
That needs to be addressed (see my comment).

Yeah I completely ignored unit tests when I sent this out last night. Things should be clean now.
I've confirmed that my previous repro steps no longer cause DNS to fail. I'll run a full e2e and then loop on up-e2e-down to add a little extra confidence.

LGTM.

Addresses #7548

I've built and pushed google_containers/kube2sky:1.3, so this is ready to merge on green.

I see Nikhil merged this.  Rather than roll it back, please file a separate PR to address the review comments.  Thanks.

I am sorry, I saw the LGTM tag and shippable was green so merged. Didnt know you were still reviewing.

No worries Nikhil.  I had all morning to review but left it until you merged :-)

@pires: Are you using the quay.io version of etcd? I switched our kube-dns to use the gcr.io version to align with the apiserver, which takes slightly different arguments.


Update api and agent packages to consume new dwn-sdk-js

Update dwn-sdk-js to v0.2.16 across the agent and api package.
Bump agent to v0.2.7
Bump api to v0.8.5

@LiranCohen should bump the versions for identity-agent and proxy-agent to keep them all on the same version of @web5/agent.

Replaced by #445


fez failed to remove a module before the 24h deadline is up

I tried to removed my module that I just uploaded less than an hour ago, but failed:
jkuan@greymatter Shell-DSL:[0] $ fez  list
>>= Shell::DSL:ver<0.0.4>:auth<zef:kjkuan>

jkuan@greymatter Shell-DSL:[1] $ fez remove 'Shell::DSL:ver<0.0.4>:auth<zef:kjkuan>'
Use of uninitialized value of type Any in string context.
Methods .^name, .raku, .gist, or .say can be used to stringify it to something meaningful.
  in sub try_dateparse at /home/jkuan/Applications/rakudo-moar-2023.06-01-linux-x86_64-gcc/share/perl6/site/sources/3FB5A1380765B6B54BC90128DD7DBCBF6135B015 (Fez::Util::Date) line 46
Use of uninitialized value of type Any in string context.
Methods .^name, .raku, .gist, or .say can be used to stringify it to something meaningful.
  in sub try_dateparse at /home/jkuan/Applications/rakudo-moar-2023.06-01-linux-x86_64-gcc/share/perl6/site/sources/3FB5A1380765B6B54BC90128DD7DBCBF6135B015 (Fez::Util::Date) line 46
Use of uninitialized value of type Any in numeric context
  in block  at /home/jkuan/Applications/rakudo-moar-2023.06-01-linux-x86_64-gcc/share/perl6/site/sources/25EDD0451E77FD0D53C7B66A004B7DEABDAA075A (Fez::CLI) line 601
=<< FATAL: It's past the 24 hour window for removing modules

@kjkuan i have some time tomorrow morning and will take a look at this

@kjkuan too late to remove that one but updating to the latest fez will resolve this (it no longer does a soft check client side)

this is going to get released in v55

released -


Added Rival 110 support

We had a go at making the Rival 110 work. It turned out to be fairly close to the 100, but the commands needs trailing null bytes to a certain length. The biggest difference is the wide array of DPI settings available.

Hi,
The DPI setting looks close to the Rival/Rival 300 one (https://github.com/flozz/rivalcfg/blob/master/rivalcfg/profiles/rival.py#L16-L19) but I cannot explain the inconsistent gap in the list:
200: 0x04,
300: 0x06,
400: 0x08,

→ +100: +2

400: 0x08,
500: 0x0b,

→ +100: +3

Merged, thank you for your contribution :)

Thank you!
Yeah, the 2/3 jumps are a bit confusing. You can probably use the same function that the 300 uses and no-one will notice :). When I saw the jumps were inconsistent I figured it was better to just sniff the values for every selectable DPI in the SteelSeries Engine. So, hence the big list.

hi thanks ! it works (in linux) :)


Code for PointNet++

Hey,
In your paper you mentioned finetuning pointrcnn for 3D object detection. PointRCNN uses pointnet++ backbone but your code only has unet. How did you finetune pointrcnn with a unet backbone? Or do you plan to upload the code with pointnet++ ? Also, what are the hyperparameters used for finetuning pointrcnn on 5% Kitti? For example, epochs, the optimizer, learning rate, weight decay and lr scheduler etc.
Thanks!

Hi, we have used the OpenPCDet repo to run everything. This is the toolbox also used in one of the baselines, so we just made some adaptations to extract the point-wise features using the MinkUNet backbone instead of the PointNet++. You can check the code for object detection in this docker image. Inside the image, you will find the subsets of training and the hyperparameters for fine-tuning.

Hey,
Thank you for replying.
I have 2 more questions:

For training on 5% kitti, do you use the dbinfos from the 100% train set or do you create dbinfos from 5% kitti split and only use that. For example, for kitti_infos_train_5_0.pkl, did you create kitti_dbinfos_train_5_0.pkl or used the kitti_dbinfos_train.pkl?
From your image, I see that in segcontrast_pretrained_0p05_0.yaml, number of epochs is set to 80. Does this mean that in your paper the results for finetuning on 5% kitti are for 80 epochs?

Thank you!

The dbinfo file is the same. We just use the kitti_infos_train_5_0.pkl that is on the docker image.
Yes, for all the training subsets we use 80 epochs. In our paper we just increase the number of epochs for few training data for the semantic segmentation.


XGBoost4J release supporting scala 2.13

An XGBoost4J release supporting Scala-2.13 would be terrific.  Even a estimate of when such support might be coming would really help me out.
Thanks.

No concrete estimate yet. We are short-handed right now, especially for the JVM and R packages.

No concrete estimate yet. We are short-handed right now, especially for the JVM and R packages.

Also, Spark 3.0 is built with Scala 2.12. The policy is that XGBoost uses the version of Scala that's used by Spark.

Also, Spark 3.0 is built with Scala 2.12. The policy is that XGBoost uses the version of Scala that's used by Spark.

Hi is there any update to this issue or its timeline? Seems like Spark 3.2 is now supporting Scala 2.13 at least.
Personally this is the only dependency blocking my project from upgrading to 2.13, so would appreciate an update on if it's still not planned for a while.

@wbo4958 Could you please take a look when you are available?

This is no a high-priority issue, let's keep it here and will check it when I got time.

Any update on supporting scala 2.13 yet?

Duplicates https://github.com/dmlc/xgboost/issues/8650

Support for Scala 2.13 was added in #9099


Upload to NPM?

Hi, thanks to continue this project guys, but is possible to upload to NPM?

And installation section in readme.


Remove right-association in concat

It occurred to me: we already right-associate as part of the stack safety in flatten and flattenOption. As a result, the left side of a Union is already right associated no matter what we do. This property (and the fact that we unwind in the rendering loops already) breaks any O(N^2) performance.
I verified that with some benchmarks:
before:

[info] Benchmark                    (size)   Mode  Cnt      Score       Error   Units
[info] PaigesBenchmark.docConcat         1  thrpt    3   7271.123 ±  3786.344  ops/ms
[info] PaigesBenchmark.docConcat        10  thrpt    3   1127.478 ±   566.950  ops/ms
[info] PaigesBenchmark.docConcat       100  thrpt    3     27.731 ±    12.220  ops/ms
[info] PaigesBenchmark.docConcat      1000  thrpt    3      0.196 ±     0.012  ops/ms
[info] PaigesBenchmark.docConcat     10000  thrpt    3      0.002 ±     0.001  ops/ms
[info] PaigesBenchmark.fill              1  thrpt    3   6758.951 ±  1874.077  ops/ms
[info] PaigesBenchmark.fill             10  thrpt    3    992.742 ±    67.802  ops/ms
[info] PaigesBenchmark.fill            100  thrpt    3    105.708 ±    23.570  ops/ms
[info] PaigesBenchmark.fill           1000  thrpt    3     10.077 ±     0.527  ops/ms
[info] PaigesBenchmark.fill          10000  thrpt    3      0.954 ±     0.772  ops/ms
[info] PaigesBenchmark.fill0             1  thrpt    3   4284.970 ±   875.741  ops/ms
[info] PaigesBenchmark.fill0            10  thrpt    3    405.274 ±   135.203  ops/ms
[info] PaigesBenchmark.fill0           100  thrpt    3     40.118 ±    17.804  ops/ms
[info] PaigesBenchmark.fill0          1000  thrpt    3      4.055 ±     0.555  ops/ms
[info] PaigesBenchmark.fill0         10000  thrpt    3      0.383 ±     0.600  ops/ms
[info] PaigesBenchmark.fill100           1  thrpt    3   4133.444 ±  5187.297  ops/ms
[info] PaigesBenchmark.fill100          10  thrpt    3    366.609 ±   396.782  ops/ms
[info] PaigesBenchmark.fill100         100  thrpt    3     28.006 ±     3.910  ops/ms
[info] PaigesBenchmark.fill100        1000  thrpt    3      2.631 ±     0.677  ops/ms
[info] PaigesBenchmark.fill100       10000  thrpt    3      0.313 ±     0.112  ops/ms
[info] PaigesBenchmark.intercalate       1  thrpt    3   5124.273 ±  1666.794  ops/ms
[info] PaigesBenchmark.intercalate      10  thrpt    3    885.737 ±   156.115  ops/ms
[info] PaigesBenchmark.intercalate     100  thrpt    3    100.038 ±     8.381  ops/ms
[info] PaigesBenchmark.intercalate    1000  thrpt    3      9.171 ±     4.922  ops/ms
[info] PaigesBenchmark.intercalate   10000  thrpt    3      0.937 ±     0.804  ops/ms
[info] PaigesBenchmark.mkstring          1  thrpt    3  16543.735 ± 22436.725  ops/ms
[info] PaigesBenchmark.mkstring         10  thrpt    3   3792.448 ±   812.854  ops/ms
[info] PaigesBenchmark.mkstring        100  thrpt    3    421.648 ±   130.509  ops/ms
[info] PaigesBenchmark.mkstring       1000  thrpt    3     42.594 ±    25.004  ops/ms
[info] PaigesBenchmark.mkstring      10000  thrpt    3      4.629 ±     0.564  ops/ms

after
[info] Benchmark                    (size)   Mode  Cnt      Score      Error   Units
[info] PaigesBenchmark.docConcat         1  thrpt    3   7276.434 ± 3751.882  ops/ms
[info] PaigesBenchmark.docConcat        10  thrpt    3   1694.660 ±  287.643  ops/ms
[info] PaigesBenchmark.docConcat       100  thrpt    3    185.314 ±   33.240  ops/ms
[info] PaigesBenchmark.docConcat      1000  thrpt    3     17.140 ±    2.967  ops/ms
[info] PaigesBenchmark.docConcat     10000  thrpt    3      1.727 ±    0.246  ops/ms
[info] PaigesBenchmark.fill              1  thrpt    3   6918.803 ± 2140.622  ops/ms
[info] PaigesBenchmark.fill             10  thrpt    3   1043.449 ±  436.240  ops/ms
[info] PaigesBenchmark.fill            100  thrpt    3    111.763 ±   19.795  ops/ms
[info] PaigesBenchmark.fill           1000  thrpt    3     11.003 ±    6.272  ops/ms
[info] PaigesBenchmark.fill          10000  thrpt    3      0.997 ±    0.394  ops/ms
[info] PaigesBenchmark.fill0             1  thrpt    3   4394.953 ± 1730.850  ops/ms
[info] PaigesBenchmark.fill0            10  thrpt    3    402.138 ±  383.729  ops/ms
[info] PaigesBenchmark.fill0           100  thrpt    3     40.492 ±    3.267  ops/ms
[info] PaigesBenchmark.fill0          1000  thrpt    3      4.114 ±    0.454  ops/ms
[info] PaigesBenchmark.fill0         10000  thrpt    3      0.395 ±    0.097  ops/ms
[info] PaigesBenchmark.fill100           1  thrpt    3   4353.119 ±  557.545  ops/ms
[info] PaigesBenchmark.fill100          10  thrpt    3    406.700 ±   90.665  ops/ms
[info] PaigesBenchmark.fill100         100  thrpt    3     30.169 ±    6.833  ops/ms
[info] PaigesBenchmark.fill100        1000  thrpt    3      2.807 ±    0.923  ops/ms
[info] PaigesBenchmark.fill100       10000  thrpt    3      0.313 ±    0.178  ops/ms
[info] PaigesBenchmark.intercalate       1  thrpt    3   5340.003 ± 2000.812  ops/ms
[info] PaigesBenchmark.intercalate      10  thrpt    3    897.176 ±  269.250  ops/ms
[info] PaigesBenchmark.intercalate     100  thrpt    3    103.967 ±   14.309  ops/ms
[info] PaigesBenchmark.intercalate    1000  thrpt    3      9.767 ±    1.206  ops/ms
[info] PaigesBenchmark.intercalate   10000  thrpt    3      1.013 ±    0.173  ops/ms
[info] PaigesBenchmark.mkstring          1  thrpt    3  17555.149 ± 5272.955  ops/ms
[info] PaigesBenchmark.mkstring         10  thrpt    3   4455.296 ± 1117.310  ops/ms
[info] PaigesBenchmark.mkstring        100  thrpt    3    444.815 ±   64.634  ops/ms
[info] PaigesBenchmark.mkstring       1000  thrpt    3     43.614 ±    4.103  ops/ms
[info] PaigesBenchmark.mkstring      10000  thrpt    3      4.604 ±    2.041  ops/ms

Note that after this change everything is as fast or faster, and naive a + b loops are MUCH faster (avoiding an N^2 perf bottleneck there).
I think all that is required to keep this is to add an invariant to Union that the left side is right-associated, which I made a comment for. And again, we actually already had this property after #20 .

Aha! Great observation. Huge 👍


deps(apiops): bump apiops to v0.1.22

OAS conversion updates:

changes generated names to be more Inso like
adds an option to skip generating ID's

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c589a3a) 33.58% compared to head (096cf77) 33.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
- Coverage   33.58%   33.57%   -0.02%
==========================================
  Files         101      101
  Lines       12430    12434       +4
==========================================
  Hits         4175     4175
- Misses       7848     7852       +4
  Partials      407      407

Files
Coverage Δ

cmd/file_openapi2kong.go
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update documentation and examples

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #117
Summary:

Update dynamic menu example to fix bugs
Update dependencies

Type of change:

[x] Other (Docs)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 1.9.12 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Scale images in detail view properly

I think this is okay now, somehow. Or, at least, I don’t know of any feeds where it’s not working. Could be re-opened (or re-filed) at a later date.


GEOPY-92

GEOPY-92 - Example for MT inversion
Adding an app_initializer to the MT .constants to reproduce the MT inversion I ran overnight last night.

Re-opening with new GEOPY-92 branch


Update aws-java-sdk-bundle to 1.11.1011

Updates com.amazonaws:aws-java-sdk-bundle from 1.11.999 to 1.11.1011.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-bundle" } ]

labels: library-update, semver-patch

Superseded by #1327.


SW-6038 Added module info to event APIs

Merge activity

Sep 18, 1:00 PM EDT: @tommylau523 merged this pull request with Graphite.


Update maven-core, maven-model-builder, ... to 3.6.3

Updates

org.apache.maven:maven-core
org.apache.maven:maven-model-builder
org.apache.maven:maven-repository-metadata
org.apache.maven:maven-settings
org.apache.maven:maven-settings-builder

from 3.0 to 3.6.3.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (3.0).
You might want to review and update them manually.
pom.xml
src/it/codegen-java-vavr/pom.xml
src/it/codegen-java/pom.xml
src/it/codegen-scala/pom.xml
src/it/codegen-spring-mvc-java/pom.xml

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.maven" } ]

labels: library-update, old-version-remains

Superseded by #68.


Enhancement - cloudflare_teams_location - ecs_support option

Current Terraform and Cloudflare provider version
Cloudflare provider - v4.26.0
Description
Propose to add option to cloudflare_teams_location resource.
To include the ecs_support option (Enable the EDNS client subnet for the DNS location in Cloudflare)
Available on the Cloudflare API
https://developers.cloudflare.com/api/operations/zero-trust-gateway-locations-create-zero-trust-gateway-location
https://developers.cloudflare.com/api/operations/zero-trust-gateway-locations-create-zero-trust-gateway-location#:~:text=false-,ecs_support,True if the location needs to resolve EDNS queries.,-Example%3A
Use cases
Enable the EDNS client subnet setting for a DNS location in Cloudflare Gateway
Potential Terraform configuration
resource "cloudflare_teams_location" "name" {
account_id     = "account id"
name           = "name"
client_default = true
ecs_support = true / false
networks {
network = "network"
}
References
No response

This issue has been closed as we are now tracking this internally with service teams directly. If you would like an update or to be notified when/if the product ships with this change, please reach out to Cloudflare Support or your account team who can watch the internal feature request for you.


Better bundling

Better bundling for release
Below is a screenshot from node_modules after npm installing Blue

This PR updates the build process of Blue from using Webpack to Babel. It also adjusts the npm publish process to publish just the dist directory, instead of the entire project.
These updates allow a consumer of Blue to do something like:
import Button from '@helpscout/blue/components/Button'

Resolves: https://github.com/helpscout/blue/issues/80

Coverage remained the same at 100.0% when pulling 8a6d1fe4fad5e4aba0d88b2a68c4fef36c92ecf7 on better-bundling into 44fc2c5e771c0b361ad11cae71af97f9e4087b53 on master.


Selector errors

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Whenever bootstrap.min.css is included in the angular build, we get a "Selector Error" during server side rendering (with angular universal). The error message is: "Cannot read properties of undefined (reading 'type')"
"dependencies": {
"@angular/animations": "^14.0.0",
"@angular/common": "^14.0.0",
"@angular/compiler": "^14.0.0",
"@angular/core": "^14.0.0",
"@angular/forms": "^14.0.0",
"@angular/platform-browser": "^14.0.0",
"@angular/platform-browser-dynamic": "^14.0.0",
"@angular/platform-server": "^14.0.0",
"@angular/router": "^14.0.0",
"@nguniversal/express-engine": "^14.2.0",
"bootstrap": "^5.2.0",
"express": "^4.15.2",
"rxjs": "~7.5.0",
"tslib": "^2.3.0",
"zone.js": "~0.11.4"
},
Angular CLI: 14.2.1
Node: 16.15.0
Package Manager: npm 8.5.5
OS: win32 x64
Angular: 14.2.0
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router
Package                         Version
@angular-devkit/architect       0.1402.1
@angular-devkit/build-angular   14.2.1
@angular-devkit/core            14.2.1
@angular-devkit/schematics      14.2.1
@angular/cli                    14.2.1
@nguniversal/builders           14.2.0
@nguniversal/express-engine     14.2.0
@schematics/angular             14.2.1
rxjs                            7.5.6
typescript                      4.7.4
Reduced test cases
I was able to recreate the error by creating a new angular universal project and including the bootstrap library.
What operating system(s) are you seeing the problem on?
Linux
What browser(s) are you seeing the problem on?
Chrome
What version of Bootstrap are you using?
5.2.0

Thanks for opening this issue @lightbulb110. Do you see the same thing with the 5.2.1 of Bootstrap as well?

Yes, same issue with 5.2.1

Right on, you got it.

@XhmikosR Is this fixed?

Just some information regarding this issue for the one searching into our repository.
The issue doesn't come from the CSS selector used by Bootstrap but rather from Angular Universal itself (and probably because of the critters package it has as a dependency).
Some modifications in angular.json seem to work for some people in https://github.com/ng-bootstrap/ng-bootstrap/issues/4306 but the real issue should be tackled by Angular Universal.

For reference, this is the root cause: https://github.com/GoogleChromeLabs/critters/issues/103


Add more build artifacts and automatically publish to BAR.

Upgrade Arcade scripts.
Add build steps to:

Collect all artifacts into one tarball (so it includes all RID-specific as well as non-RID-specific packages).
Publish this tarball (and an empty nupkg for dependency uptake) to BAR.

Add offline legs for Ubuntu and Debian so we consistently use the Offline-built packages for this tarball.
Add more artifacts to the list to publish:

runtime and SDK product tarballs
generated git-info and PackageVersions.props
list of all files in the repo after the build

Example builds: (old) https://dev.azure.com/dnceng/internal/_build/results?buildId=438340, https://dev.azure.com/dnceng/internal/_build/results?buildId=438343, (latest) https://dev.azure.com/dnceng/internal/_build/results?buildId=438639, https://dev.azure.com/dnceng/internal/_build/results?buildId=438643.
@dagood, added you if you don't mind taking a look, I think you're more familiar with this than any of us.

Superseded by #1784 and #1785.


Add freq support to land.doy_qmax

Description

I don't think the current implementation of doymax supports resampling.

For more context: https://xarray.pydata.org/en/stable/generated/xarray.Dataset.idxmax.html

The generic indices does not, but the Indicator does, I think it's good enough.


Custom Effects Added to Favorites Not Visible

Describe the bug
Adding any Custom Effects to "Favorites" via the right-click menu with the "Convenient Effects" box does not work. Custom Effect disappears from "Custom" folder and does not appear in "Favorites" folder.
To Reproduce
Steps to reproduce the behavior:

Go to Convenient Effects within Foundry
Click on Custom Effects Folder
Right-Click and Custom Effect
Add to Favorites
Item disappears from Custom Effects, doesn't appear in Favorites.

Expected behavior
The effect should appear in Favorites, and does not.
Screenshots
Not able to create a screenshot that shows this particular error; unable to produce a video clip at this time, unfortunately.
Additional context
Pre-made (non-Custom) effects do appear in Favorites when following the process above.
Additionally, effects linked in the macro bar still do "work" - so they're still present somewhere. They're just not visible anywhere.
Thanks in advance for any guidance!

Ah, thanks for the report. I'll fix this!

No problem; happy to help. Love the module.
Cheers!

Fixed in v4.1.1


Actual last tweaks (okay more than tweaks)

Okay, so I think I have some kind of problem stopping, because this is basically the 3rd large update / refactor since I said 'yeah, let's lock it in, we're about ready to go here'... This is more than anything else, a re-organization of the codebase. Again, nothing functional, in terms of the algorithm, should have changed.
The upshot is that I think by this point I hit about every last thing that struck me as annoying / weird / problematic (and I'm going to stop looking for more), so I do think this leaves the module in a good place, and is more of a general organization refactor, to hopefully give us a nice organization to stick to from here on out, that also helps maintainability.
Changelog:

Make FOOOFGroup hold onto PSDs matrix as an attribute. Includes re-work of add_data, helps with returning FOOOF objects from group, makes data available for use.
Update from_group: Initially I overloaded it in FOOOFGroup, to fix up it's actions there, then realized that overload rendered the FOOOF.from_group classmethod has no clear use case. So FOOOF.from_group is removed, added and renamed as FOOOFGroup.get_fooof.
Add a method to print out instructions of how to report bad / weird fits (or bugs) to use.
Reorg / Refactor:

Move out the formatted string generation, report creation, IO activities, and plots to their own files.

This increases modularity a lot. Everything in FOOOF & Group object files is specifically about the model (or core object organization), and all peripheral activities are externalized. Nothing that doesn't operate on object data is kept in fit.py or group.py.

Several object methods are now aliases to external functions, so there is now also a more function-based approach to the API (this in itself isn't necessarily a good thing itself, since it violates the 'one way' principle), but this 'alternate API' is fairly hidden, but increases flexibility if one wants it.

Due to 'methods as aliases', there is some trickery to have docs written out in one place only, and appropriately added to aliased methods.

After all this, I re-organized the file locations internally. It doesn't change anything in terms of the user-facing API.

Overhaul testing. This is largely driven by the internal re-organization, testing the independent functions separately. Also, make testing smarter about recycling data objects, not regenerating data and fits more than it needs to. There is still room for improvement in terms of testing accuracy (still largely in the 'smoke tests' realm), but that's a v0.2 thing.

Notes

Part of the reorg / modularization is that it also should make it easier/clearer to have a Py2 version: the core fit & group need to run, but any incompatible peripheral files can just be wiped.
I'm actually done updating now (I'm going to hold myself to that). My last job tomorrow is a sweep through with API checklist, PEP-8, and naming conventions, then update the tutorial. Release stuff (outside module) is mostly ready on 'release' branch, so then we can merge that and push to PYPI!

Codecov Report

Merging #52 into master will increase coverage by 0.86%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   96.59%   97.46%   +0.86%
==========================================
  Files          17       32      +15
  Lines         822     1024     +202
==========================================
+ Hits          794      998     +204
+ Misses         28       26       -2

Impacted Files
Coverage Δ

fooof/plts/templates.py
100% <ø> (ø)

fooof/core/funcs.py
100% <ø> (ø)

fooof/tests/test_plts_templates.py
100% <100%> (ø)

fooof/utils.py
100% <100%> (ø)
:arrow_up:

fooof/tests/test_core_reports.py
100% <100%> (ø)

fooof/core/modutils.py
100% <100%> (ø)

fooof/core/reports.py
100% <100%> (ø)

fooof/tests/conftest.py
91.3% <100%> (+3.8%)
:arrow_up:

fooof/synth.py
100% <100%> (ø)
:arrow_up:

fooof/analysis.py
93.33% <100%> (+10.98%)
:arrow_up:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4aadf8...f31f15f. Read the comment docs.

Considering the large diff:

I can also give you a primer on the updates, if you want to sit down and have a quick look
A useful / quick sanity check: clone the branch, run on a couple PSDs and eyeball nothing weird seems to happen (even better, compare back to older FOOOF), and run the tests locally, to check nothing weird breaks (running py.test in root after cloning should just work).

We can sit down this week and go over everything in detail, but this is looking very good! I'm impressed.


Naive fix of floating point error in validate anneal. Added test.

Naive solution for #273
This may not be the best way to do this, but it solves the problem.
Other option would be using numpy.close() or another method with some tolerance but I didn't want to add a dependency to this module.
Not sure how, but this seems to be managed successfully once the problem is submitted to the machine, maybe the method used there is more appropriate.

Maybe just python's built in round function

Yeap, if the precision can be matched to how it's handled by the machine.


Extend parseable formats

Hi!
So, I've added more separators (- / .) for parsing to fix #174.
Additionally, I've added tests for them, as per #242.
Cheers!

Thanks @arvindch


Pre-trained model on Visual Genome

Hello,
is it possible to get the actual model, which has been trained on Visual Genome? README has only some pieces of information about detection results, but no link to actually download the model.
Would be really great if getting this model is possible!
Thanks.

Oh


Fix Feast Serving not registering its store in Feast Core

What this PR does / why we need it:
Fixes Feast Serving not registering its store into Feast Core.

Adds registerSource() to CoreSpecService to register source spec in in Feast Core.
Adds missing registerSource() call in CachedSpecService to register its store in Feast Core.
Adds a unit test to ensure that cached spec service registers its store with Feast Core.

Which issue(s) this PR fixes:

Fixes #640
Does this PR introduce a user-facing change?:

NONE

/lgtm

/test-serving

/test test-serving

/approve


Query regarding impact on guest accounts

Please can you confirm what happens to guest account access when a custom domain is removed.
E.g: Your users have been granted access to multiple third party tenancies using their M365 accounts. Your users have the domain @constoso.com associated with their accounts. You remove the @contoso.com domain to another M365 tenancy during an acquisition or merger.  Your users revert back to @onmicrosoft.com during the domain removal.
What happens in this instance? I'm assuming that the @onmicrosoft.com accounts continue to have access and the users will need to reach out to the orgs to have them re-invite them in their new tenancy?

@hittensa Please indicate which document you are referring to . Thanks

The article is: https://learn.microsoft.com/en-us/microsoft-365/admin/get-help-with-domains/remove-a-domain?view=o365-worldwide

@hittensa Thank you for your feedback. You are correct, the respective onmicrosoft.com accounts get access and they suers will need to reach out to the organization to have them re-invite them in their new tenancy.
Hope this helps!
Thanks
Sri


Time series issues

warning upone converting to datetime
hw_plot1.assert_xydata(xy_expected=monthly_max.reset_index(),
                       xtime=True,
                       xcol="datetime",
                       ycol="17663_00060_00003",
                       m="oops - you messed up")

out
/anaconda3/envs/earth-analytics-python/lib/python3.6/site-packages/numpy/core/numeric.py:2586: FutureWarning: Converting timezone-aware DatetimeArray to timezone-naive ndarray with 'datetime64[ns]' dtype. In the future, this will return an ndarray with 'object' dtype where each element is a 'pandas.Timestamp' with the correct 'tz'.
	To accept the future behavior, pass 'dtype=object'.
	To keep the old behavior, pass 'dtype="datetime64[ns]"'.
  a1, a2 = asarray(a1), asarray(a2)

i am going to close this issue. we decided that trying to mess with conversions is not a good use of effort because it's fragile. instead we will pull the data from the expected plot using a get_data method and then test that way


Generator

This supercedes #1158. The original code from @dhe128 has been rebased onto the latest master and I've added a few tweaks based on the review from @jeffmo.
The remaining items:

delegate property to be filed on ESTree
a new test for yield inside an arrow function within a generator

Now that I'm thinking about it again, I think it should be delegating and not delegate.
Thoughts @ikarienator @jeffmo?

FWIW: I find delegating slightly (not to be overstated) confusing because it's not immediately clear what the delegator/delegate is in the the context (and the meaning of the variable gets a little fuzzy).
Going further, delegates came to mind -- but I realized it's odd because it's unclear that it's referring to the verb (rather than a list of delegates).
Of the names I can think of, isDelegator seems most clear to me. delegating seems survivable.

Seems like a good discussion to move to the ESTree repo for resolution :)

Since there seems to be no objection, I'm going to land this soon.


Proposal: Update background color of selected ListBox item to meet contrast ratio requirement

Describe the bug
This is similar to the bug as reported for selected ListView items in #2908: Selected [ListBoxItems] do not currently meet the 3:1 contrast ratio requirement relative to unselected items, as specified in MAS 1.4.11 - Non-text Contrast.
The ListBoxItem uses the exaxt same brushes as the ListViewItem for its selected rest/hover/pressed visual states: https://github.com/microsoft/microsoft-ui-xaml/blob/86a7d62bf8141a1f3e141d3ade7a69bce02063c1/dev/CommonStyles/ListBox_themeresources.xaml#L129
This leads to a color contrast between selected and unselected items of 1.9:1 in dark mode:

And a color contrast of 1.7:1 in light mode:

As a fix I propose to use the same brushes we settled on in PR https://github.com/microsoft/microsoft-ui-xaml/pull/2962 to fix the color contrast ration for the ListViewItems. This would also keep the selection brushes used consistent between the ListBoxItem and the ListViewItem.
As you saw in the linked control template code above, the ListBox currently does not have an own set of theme resources corresponding to the ListViewItems: A theme resource like ListBoxItemBackgroundSelected does not exist. Instead, the default ListBoxItem control template references the different SystemControlHighlightListAccent*Brush theme resources directly. We could either

update the ListBoxItem control template to reference the updated SystemControlHighlightListAccent*Brush the ListView item now uses as part of PR https://github.com/microsoft/microsoft-ui-xaml/pull/2962 or
create an own set of theme resources for the ListBoxItem which will reference the updated brushes

The ListBox control seems to be in a low-priority mode based on the documentation (similar perhaps to the Pivot control?):

As such, it might not be worth the effort to introduce a whole bunch of ListBoxItem* theme resoures and we should just update the control template to reference the same SystemControlHighlightListAccent*Brushes the ListViewItem now does due to PR https://github.com/microsoft/microsoft-ui-xaml/pull/2962. If, however, there are still valid use cases for the ListBox control in new apps (and not just ported Windows 8 apps) then we should invest the effort into creating a set of dedicated theme resources for the ListBoxItem and I would be willing to do that. I would like input from the team here (like @YuliKl).
Note: There are theme resources like ListBoxItemSelectedBackgroundThemeBrush but they all seem to be unused in the default ListBoxItem template. Can we do something about that? It's confusing to developers that the ListBox theme resource file contains a bunch of theme resources which are completely unused. If we cannot remove them for now because of the breaking apps concern, could we at least indicate via a comment that those theme resources are not in use so there is no point for developers to override them in their apps? They are also no candidate for the set of dedicated ListBoxItem theme resources we could create as part of fixing this bug here because they don't follow the current naming scheme used throughout WinUI for these theme resources.

Thank you for filing this issue, I would love to see it fixed. The note in the docs is accurate, we are not making active investments in ListBox - although I would like to make an exception for this MAS requirement. To minimize code churn, I would prefer option 1 as the direction of the fix:

update the ListBoxItem control template to reference the updated SystemControlHighlightListAccent*Brush the ListView item now uses as part of PR #2962

I'm not certain whether we can update the control template of this inbox control in WinUI 2 without waiting for WinUI 3. Hopefully we can, as this sounds similar in spirit to e.g. rounded corners changes we've already made.
The existence of unused theme resources is very annoying but right now may not be the appropriate time to fix this situation. Perhaps we need to wait until WinUI 3 to delete these unused brushes. That feels like the right time to also change ListBox's template to use light-weight styling resources with names that match the current naming convention. Although given our lack of investment in ListBox, I'm not certain this change would be a good use of anyone's time.

@YuliKl

I'm not certain whether we can update the control template of this inbox control in WinUI 2 without waiting for WinUI 3. Hopefully we can, as this sounds similar in spirit to e.g. rounded corners changes we've already made.

We absolutely can! The ListBoxItem control template was moved out of the OS into the WinUI 2 repo previously and I just checked that overriding the used brushes for selection works as it does for the ListViewItem - which is the case 🙂

The existence of unused theme resources is very annoying but right now may not be the appropriate time to fix this situation. Perhaps we need to wait until WinUI 3 to delete these unused brushes. That feels like the right time to also change ListBox's template to use light-weight styling resources with names that match the current naming convention. Although given our lack of investment in ListBox, I'm not certain this change would be a good use of anyone's time.

Yep, for now it will be fine to just update the referenced brushes without investing time into creating a whole set of new ListBox specific theme resources. After all, even if we only update the referenced brushes, we will still

improve the color contrast for selected ListBoxItems and match ListViewItems and
developers can still customize the used brushes - they just have to locally override a SystemControlHighlightListAccent*Brush instead of, for example, a ListBoxItemSelectedBackground resource

I would also much rather invest time into improving the lightweight customization story for a control like the NumberBox (tracked in https://github.com/microsoft/microsoft-ui-xaml/issues/2844) instead of a control like the ListBox which has already been superseded by another control like the ListView.
I will create a PR following option 1 then.

This begs the question: How should deprecation be handled in the future?
Should there be a WinUI 3.x build that receives changes that are not breaking, as 3.x.y releases.  With more breaking changes in 3.x (and massive overhaul changes in 4.x, 5.x releases)?

@mdtauk It was suggested that WinUI 4.0 could be the first version where we could make these kinds of breaking changes (while that context was only about theme resources, this should be valid for other public APIs too). If semver is followed, 3.x versions shouldn't contain breaking changes.

@mdtauk It was suggested that WinUI 4.0 could be the first version where we could make these kinds of breaking changes (while that context was only about theme resources, this should be valid for other public APIs too). If semver is followed, 3.x versions shouldn't contain breaking changes.

I understand that Felix, but will the team be backporting fixes to 3.x.y versions, whilst releasing 4.x versions?

I'm not sure on that. While @ryandemopoulos did say that WinUI 2 will be kept supported for a while after WinUI 3.0 has been released, this is arguably a special situation (host backdrop acrylic, etc...) so it might be handled differently than future major WinUI releases.

I'm not sure on that. While @ryandemopoulos did say that WinUI 2 will be kept supported for a while after WinUI 3.0 has been released, this is arguably a special situation (host backdrop acrylic, etc...) so it might be handled differently than future major WinUI releases.

I am not expecting there to be an answer at this stage, but it may be a conversation worth having at some point, so it can be added to public facing information, and appropriate branches and dev mechanisms can be in place once the code goes open.


Support filter-pool argument

Let's support a filter-pool argument which should filter to:

[x] Blocks issued by the pool
[x] Delegation transactions to the pool
[x] Pool registration changes

This would be awesome especially for a screen and audio tracking a pool for blocks won, delegation, and maybe even big stake increases within the wallet, perhaps event pool certificate changes.

Currently, blocks won, delegation (in), and pool changes can be tracked easily. For wallet, you would need to track the stake of every single wallet, which would also need rewards calculations. We're not quite there, yet.

Blocks: #112
Delegation: #209
Registration: #210


Persist comment blocks before stored procs/views per issue 1362

update SQLServerSqlStatementBuilder.java so that no comments are discarded. This will prevent comment headers from being removed.
https://github.com/flyway/flyway/issues/1362
see comments on https://github.com/flyway/flyway/pull/1767.
If this is the correct direction, then i will be happy to write a test around it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: izep:x: Preston ZauggPreston Zaugg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Blazor Viewing unit without support relationship fails

You encounter an error if you try to view a building that has no support relationships.  My guess is we tried to two-birds-with-one-stone our requests to the API, and it freaks out when there's no relationship(s).
See https://itpeople-test.iu.edu/Departments/192 fails,
but https://itpeople-test.iu.edu/buildings/741 works

Fixed on the units branch.


Fix output bytes

make([]byte, n) makes fixed buffer. So append() grow-up the bytes
before

after

Oh, Thanks :pray:


New version: JLSO v1.2.0

Registering package: JLSO
Repository: https://github.com/invenia/JLSO.jl
Created by: @rofinn
Version: v1.2.0
Commit: 925a8c2f51caf78abf65dab66f2496a5159a67ae
Reviewed by: @rofinn
Reference: https://github.com/invenia/JLSO.jl/commit/925a8c2f51caf78abf65dab66f2496a5159a67ae#commitcomment-35856660

The following dependencies do not have a compat entry that has an upper bound: BSON, CodecZlib

Do you wanna fix this? [noblock]

Neither of those package have been causing problems and they aren't on 1.0 yet, so I'd rather not. If we run into issues we'll just set an upper bound and make a patch release.

If we run into issues we'll just set an upper bound and make a patch release.

It's not that simple; you need to retroactively go back to e.g. this release and fix stuff too, but :man_shrugging:


Work on navigation.

Navigating while Kelsey drives.

Figured out horizontal navigation - make this pretty later.


SparqlQueryRenderer does not support SPARQL 1.1

(Migrated from https://openrdf.atlassian.net/browse/SES-2206 )
SPARQL 1.1 constructs cannot be rendered via the SparqlQueryRenderer class.
For example If I parse this query with QueryParserUtil.parseQuery:
{code}
SELECT * WHERE {
?s ?p ?o .
BIND(uri("http://test-graph.com/") AS ?foo) .
}
{code}
And then render the ParsedQuery back out again with SPARQLQueryRenderer, it appears to lose the binding clause, returning the following string:
{code}
select ?g ?s ?p ?o ?g2
where {
GRAPH ?g {
?s ?p ?o.
}}
{code}
Looking at renderTupleExpr in SparqlTupleExprRenderer I can see that the following lines are commented out:
{code:java}
// aRenderer.mProjection = new ArrayList(mProjection);
// aRenderer.mDistinct = mDistinct;
// aRenderer.mReduced = mReduced;
// aRenderer.mExtensions = new HashMap<String, ValueExpr>(mExtensions);
// aRenderer.mOrdering = new ArrayList(mOrdering);
// aRenderer.mLimit = mLimit;
// aRenderer.mOffset = mOffset;
{code}
With the following commented out in SPARQLQueryRenderer:
{code:java}
// SPARQL does not support this, its an artifact of copy and
// paste from the serql stuff
// aQuery.append(mRenderer.getExtensions().containsKey(aElem.getSourceName())
// ?
// mRenderer.renderValueExpr(mRenderer.getExtensions().get(aElem.getSourceName()))
// : "?"+aElem.getSourceName());
//
// if (!aElem.getSourceName().equals(aElem.getTargetName()) ||
// (mRenderer.getExtensions().containsKey(aElem.getTargetName())
// &&
// !mRenderer.getExtensions().containsKey(aElem.getSourceName())))
// {
// aQuery.append(" as ").append(mRenderer.getExtensions().containsKey(aElem.getTargetName())
// ?
// mRenderer.renderValueExpr(mRenderer.getExtensions().get(aElem.getTargetName()))
// : aElem.getTargetName());
// }
{code}
I believe these lines are commented out in error and that they should be commented back in in order to get be able to round trip queries from SPARQL text into the AST and back out again.
Other SPARQL 1.1 queries that fail include:
{code}
SELECT (COUNT (*) as ?c) WHERE { ?s ?p ?o }
{code}
is rendered as
{code}
select ?c where { ?s ?p ?o }
{code}
and the query
{code}
SELECT (?p as ?x) WHERE { ?s ?p ?o }
{code}
is rendered as
{code}
select ?p WHERE { ?s ?p ?o }
{code}

Hit this issue today. What is the best way to render sparql from the AST? I see FedX has its own utils for doing this: https://github.com/eclipse/rdf4j/blob/master/tools/federation/src/main/java/org/eclipse/rdf4j/federated/util/QueryStringUtil.java. I guess I could just extend the RDF4J class and add the missing visitors, oh wait, its final.... I guess I'll have to resort to copy&paste then 👎


[WIP] check-cjk fontbakery profile

In progress and not ready for review or merge yet
This pull request adds check-cjk profile support to fontbakery.
cc: @JeremieHornus
Closes #2593

@felipesanches https://github.com/googlefonts/fontbakery/pull/2594#issuecomment-514446509 will require you to acknowledge your commits that are part of this PR

@googlebot I consent

@JeremieHornus Will you please sign the CLA as indicated in https://github.com/googlefonts/fontbakery/pull/2594#issuecomment-514575929.  We will need this in order to merge this PR.  Thanks!

This PR fails the Travis build because it includes a boilerplate fontbakery check on Lib/fontbakery/profiles/cjk.py which should be modified to implement the first check in the new CJK profile.

We will get this cleaned up Felipe.  I see that you included unit tests in the template commit too.  Is it OK to add some CJK fonts (likely Noto Sans CJK) for these tests? Will be bulky.  Likely ~5-6 MB / file.

yeah, it is OK as long as it is not an extremely large ammount of data

Squashed to https://github.com/googlefonts/fontbakery/commit/7c620b00d4dafa8842a761a8c7692ee7a868eb13
Eliminated the snippets files as part of this commit

@felipesanches I have a condition in place and want to confirm that I simply need to return True (condition passed) or False (condition did not pass) to satisfy the mechanics of a condition test that is defined on a check?  Do I need to check the result of the condition in some fashion within the function that defines the checks?  The images that you posted in https://github.com/googlefonts/fontbakery/issues/2593#issuecomment-515139138 seems to indicate that there is information being passed from condition to check via the arguments.

@felipesanches I have a condition in place and want to confirm that I simply need to return True (condition passed) or False (condition did not pass) to satisfy the mechanics of a condition test that is defined on a check?

yes. Returning True or False is enough. The Font Bakery check runner engine will automatically skip the check if the condition is False. Actually, it doesn't even need to be really boolean values. It is only necessary to be a "falsy" expression to have the check skipped. For instance, returning None, or even not returning anything at all (None implicitely) will cause a check to skip as well. And the "True-ish" expression can also be any python object. This is useful because then such object can be used in the check routine. That's why sometimes we also pass the condition name as an attribute to the check function.

Do I need to check the result of the condition in some fashion within the functions that define the checks?
No. It is all done automatically.

The images that you posted in #2593 (comment) seem to indicate that there is information being passed from condition to check via the arguments.
This is because when the condition is met, its non-False result is actually something useful that is used in the check routine implementation. In that case it was an object representing the family metadata fields parsed from a METADATA.pb file. In your use case of the is_cjk_font condition, you don't need to pass the condition name as an attribute, because the condition is merely returning True/False.

That is extremely helpful information Felipe.  Thank you!  Is there a list of what arguments are automated when defined across the checks or can you point to the source where this logic exists?  It looks like you can define a ttFont argument for a fonttools object but there appear to be more options that are supported as check arguments.

ttfont - the filename of one of the fonts being checked
ttfonts - the filename of all fonts
ttFont - the fontTools object representation of one of the fonts being checked
ttFonts - objects for all fonts

oops... I replied too quickly!
But now I edited my previous message to fix a typo. :-)

you can also use any of the condition names as arguments to a check (even if they are not declared as conditions in the check)

tyvm! awesome!

I will close this now since it did not have much going on in the past few months it seems. But feel free to open a new pull request whenever you have something to submit and I will be glad to review.
I will not delete the branch so you can still use it as a reference.

Hmmm... actually, it will be better to leave it open anyway. (I thought this one was my original one, but now I see it is already the one with code from you and Jeremie) Sorry, I did not mean to be rude by closing the PR. It is now reopened.

No worries Felipe.  This is a good reminder.   I forgot about it...

this PR will need to be git-rebased and then the is_cjk_font code removed since it is now available in fontbakery's shared_conditions module so it can be imported directly from there. It will also be used on the notofonts profile.

Rebase @ https://github.com/googlefonts/fontbakery/commit/039eb3f2c95fa4dcd997c95bb1dbdd3b40c1af99
Need for refactor understood.  I will get back to this.

@chrissimpkins please do not worry about this. I have decided that it is wiser for us to add universaly useful CJK checks to the universal profile using is_cjk_font as a condition. That way, all unversally accepted good practives will continue to be placed in the same profile and the condition will help us to only run the checks when needed.

So, our next step here is to open new issues with proposals of things to check on CJK fonts. Or new PRs with implementations of such new checks to be ideally placed on the universal profile.