Cluster

The ClusterHelloWorld example
when i restart the node1 , can not receive message from node2 like this
[REMOTING] Starting Proto.Actor server on <IP_ADDRESS>:12000
[REMOTING] Started EndpointManager
Started PartitionActor HelloKind
Started MemberListActor
Cluster started
[REMOTING] Started EndpointWriter for address <IP_ADDRESS>:13001
[REMOTING] EndpointWriter connecting to address <IP_ADDRESS>:13001
[REMOTING] EndpointWriter connected to address <IP_ADDRESS>:13001
[REMOTING] EndpointWriter lost connection to address <IP_ADDRESS>:13001, reason Sta
tus(StatusCode=Unavailable, Detail="{"created":"@1492861722.540000000","descript
ion":"Endpoint read failed","file":"c:\jenkins\workspace\gRPC_build_artifacts\ar
chitecture\x64\language\csharp\platform\windows\vsprojects..\src\core\ext\trans
port\chttp2\transport\chttp2_transport.c","file_line":1851,"grpc_status":14,"occ
urred_during_write":0,"referenced_errors":[{"created":"@1492861722.540000000","d
escription":"An existing connection was forcibly closed by the remote host.\r\n"
,"file":"c:\jenkins\workspace\gRPC_build_artifacts\architecture\x64\language\csh
arp\platform\windows\vsprojects..\src\core\lib\iomgr\tcp_windows.c","file_line"
:176}]}")
[REMOTING] gRPC Failed to send to address <IP_ADDRESS>:13001, reason Status(StatusC
ode=Unavailable, Detail="{"created":"@1492861722.540000000","description":"Endpo
int read failed","file":"c:\jenkins\workspace\gRPC_build_artifacts\architecture
x64\language\csharp\platform\windows\vsprojects..\src\core\ext\transport\chttp2
\transport\chttp2_transport.c","file_line":1851,"grpc_status":14,"occurred_durin
g_write":0,"referenced_errors":[{"created":"@1492861722.540000000","description"
:"An existing connection was forcibly closed by the remote host.\r\n","file":"c:
\jenkins\workspace\gRPC_build_artifacts\architecture\x64\language\csharp\platfor
m\windows\vsprojects..\src\core\lib\iomgr\tcp_windows.c","file_line":176}]}")

Are you running Consul for the cluster service discovery?
Do you use any specific antivirus?

[REMOTING] EndpointWriter connected to address <IP_ADDRESS>:13001
[REMOTING] EndpointWriter lost connection to address <IP_ADDRESS>:13001, reason Sta
tus(StatusCode=Unavailable,

Thisd section look strange to me, it looks like the node managed to connect to the other node, but then the connection was last for some reason.

I have run the Consul service.
First time, i running the node1 like this, There is no problem.
[REMOTING] Starting Proto.Actor server on <IP_ADDRESS>:13001
[REMOTING] Started EndpointManager
Started MemberListActor
Cluster started
[REMOTING] Started EndpointWriter for address <IP_ADDRESS>:12000
[REMOTING] EndpointWriter connecting to address <IP_ADDRESS>:12000
[REMOTING] EndpointWriter connected to address <IP_ADDRESS>:12000
Hello from node 2

And then, I restart node1 ,The node2 throw exception
[REMOTING] gRPC Failed to send to address <IP_ADDRESS>:13001, reason Status(StatusC
ode=Unavailable, Detail="{"created":"@1492928176.903000000","description":"Endpo
int read failed","file":"c:\jenkins\workspace\gRPC_build_artifacts\architecture\
x64\language\csharp\platform\windows\vsprojects\..\src\core\ext\transport\chttp2
\transport\chttp2_transport.c","file_line":1851,"grpc_status":14,"occurred_durin
g_write":0,"referenced_errors":[{"created":"@1492928176.903000000","description"
:"An existing connection was forcibly closed by the remote host.\r\n","file":"c:
\jenkins\workspace\gRPC_build_artifacts\architecture\x64\language\csharp\platfor
m\windows\vsprojects\..\src\core\lib\iomgr\tcp_windows.c","file_line":176}]}")

Same as #251
Fixed


It's complicated, IINM ;-)
$ rm -f ql.db
$ ql 'CREATE TABLE foo (s string NOT NULL, t time NOT NULL);'
$ ql 'SELECT s FROM foo ORDER BY foo.t DESC LIMIT 1' # (1)
$ ql 'INSERT INTO foo (s, t) VALUES ("bar", now());'
$ ql 'SELECT s FROM foo LIMIT 1;'
"bar"
$ ql 'SELECT s, t FROM foo ORDER BY t DESC LIMIT 1' # (2)
"bar", 2016-10-13 18:13:15.457108189 +0200 CEST
$

The ORDER BY pipeline stage cannot check the validity of foo.t before getting the first result from the SELECT stage. The reason is that the particular combination of select and from can produce field names and field qualifiers not known at prepare ("compile") time. Select statements can be compiled before the underlying tables even exist.
In case (1) the pipeline produces no records, so the order by stage can never check the first record of the record set for matching/non matching field name, or qualifier.name, in this case foo.t, and cannot complain.
In case (2) it works, provided additionaly listing t as the output field (or using *), but the original ORDER BY foo.t will not, because the particular record set has no such named field.`
$ ql 'EXPLAIN SELECT s FROM foo ORDER BY foo.t DESC LIMIT 1'
┌Iterate all rows of table "foo"
└Output field names ["s" "t"]
┌Evaluate s as "s",
└Output field names ["s"]
┌Order descending by foo.t,
└Output field names ["s"]
┌Pass first 1 records
└Output field names [s]
$

OK! Thanks for the fast reply and the workaround.


add phone number as a connection

Refs

Issue: N/A
Bug Report: N/A

What?
Allow devs to create a user with a phone number.
Why?
Needed for SupTho
How?

Screenshots:

How can this feature be tested?

Warnings (or deploy instructions)

Do we need to change CreateUserArguments?

greeeeat catch. edited the users.d.ts file on accident as they are all in the same repo. updated!


How Blockchain can transform India and other developing countries.

Target Audience? Everyone ( Social Implications and uses of Blockchain tech)
Time? 30 min talk
Alone or With A Team?
2 people presenting. Speaking about on ground realities, and how these issues can be changed by utilizing blockchain technology.
This talk will be given by Narasimha and Maan.
Narasimha is a web3 researcher/dev from India and Maan is a web3 Game Dev from Yemen. They will come together to talk about the issues plaguing their countries and how blockchain and web3 has the potential to solve these problems and change their country's systems, governments and exploring current use cases of blockchain and future ideas/use cases around building . Topics such as resource distribution,  voting,  verification,  and governance through blockchain will be explored. Furthermore : blockchain as a philosophy will be explored.

Hey!
Can you please add the description too?


CI: add 2.7

Coverage decreased (-0.1%) to 81.612% when pulling f6dc3d0a52fb9c78c5fb9de800993b5fdbde93f4 on olleolleolle:patch-1 into e03611a38b5b07ddbd9c1b4a3ac32421cf5c2840 on socketry:master.


Stop printing during ray status.

Current dependencies on/for this PR:

main

PR #467   👈

This stack of pull requests is managed by Graphite.


Edge detail page update modal trigger ellipsis menu

How to reproduce:
From a commissioned NuvlaEdge, click on ellipsis menu, choose "Update NuvlaEdge", go to advanced accordion, enter input "project" for example, click arrow on keyboard. The ellipsis menu will be shown and should not.

Relevant

https://github.com/Semantic-Org/Semantic-UI-React/issues/3174


Revert "[ubuntu] Add GCC 11 (#3291)"

This reverts commit 3ebf601284cae6a4406b7ea1ad08cd593a4d619b.
Description
Bug fix
It is a not good idea to add experimental toolchain to the image, as the addition/modification of standard C/C++ headers and libraries can have wide-ranging (and often undesired) consequences across the whole system.
Related issue:
#3376

This reverts commit 3ebf601.
Description
Bug fix
It is a not good idea to add experimental toolchain to the image, as the addition/modification of standard C/C++ headers and libraries can have wide-ranging (and often undesired) consequences across the whole system.
Related issue:
#3376

Thanks for the pr, this also fix #3432

If we fellow your logic, then gcc-9 and gcc-10 should be also removed from Ubuntu 18.04
Both of gcc-9 and gcc-11 are installed from the same ppa.

If we fellow your logic, then gcc-9 and gcc-10 should be also removed from Ubuntu 18.04
Both of gcc-9 and gcc-11 are installed from the same ppa.

If we fellow your logic, then gcc-9 and gcc-10 should be also removed from Ubuntu 18.04
Both of gcc-9 and gcc-11 are installed from the same ppa.

So be it. In my opinion, things as important as the toolchain should never be pulled from an unsupported and experimental PPA. Users who wish to use them at their own risk should pull them themselves. Strictly speaking, only the ones in the Ubuntu archive should be deemed ready for production.
Put that aside, I understand that many people would like to have newer toolchain available. In this case, gcc-9 and gcc-10 are "ready for use", but gcc-11 is not.
See my previous comment: https://github.com/actions/virtual-environments/discussions/3459#discussioncomment-787734. Likely the Ubuntu maintainers are still working on this new version. Meanwhile, it is inappropriate to sabotage the entire environment with this experimental (and "useless") toolchain.

/azp run ubuntu1804, ubuntu2004


chore: test mega refactor

This pull request marks the work being done to refactor the integration tests to make them simpler to execute. It's also meant to cut down on breaking test changes when building future features.

Coverage decreased (-2.8%) to 94.097% when pulling e98eb0cea6bf3ae64263bef33a75ebda137b79aa on 127873377-test-mega-refactor into 6ee59ddea888ed2d1b66ebfd84452f574a993aa2 on master.

Coverage decreased (-2.8%) to 94.097% when pulling 3bbb335c7ac2a288316f3b4d2f83f5332b30efd3 on 127873377-test-mega-refactor into 53d0251bc34df0b88c5e614ff072a9f19c2a6ace on master.

At some point, this will be merged in. I haven't had a chance to continue working on this for quite some time now. Only a few more weeks of school left and I should have time to pick this back up and carry this PR across the finish line and begin work on the other important tasks.

Finally got a chance to work on this again. Tests still fail, but fewer are now!
Still have some more work to be done, but I'll be able to merge this in and then modify some behavior and work on further support.

Coverage decreased (-2.7%) to 94.17% when pulling 884545873e8f68f8c852b82dd388dcdd6f8e5b5d on 127873377-test-mega-refactor into 53d0251bc34df0b88c5e614ff072a9f19c2a6ace on master.


Disable fragment routing

Hello!
We just started using this fantastic product (hey, it actually made me like Swagger again, so props to you!). We are using it inside a React app, and it mostly works. This React app is an old app though, which uses fragment based routing. You might see where this is going: our React app and RapiDoc are currently fighting over who controls the hash. RapiDoc seems to win, which I guess is good for you, but it gives us some difficulties 😅
We could switch over to using the browser history API in our React app, but that is sadly not straight forward. So, before going down that route, is it possible to stop RapiDoc from manipulating the fragment? Either an official way, or through some nasty hacking?

There are certain things that is inter-connected with location hashes. for instance you can create links to various sections of the spec using markdown which depends on location-hash.
I dont thinks there is any hack that would allow you to override the default behavior. The next best thing that you can do is modify the code and build it on your end.
To stop updating the location-hash try commenting out history.replaceState throughout the codebase https://github.com/mrin9/RapiDoc/search?q=history.replaceState
I have add included this feedback to our Integration pain points that we maintain internally. but do not depend this getting ant traction anytime soon

Alright, its just a minor issue when refreshing the page as of now so I think we'll just live with it for now :) Thanks though!


refactor(repo): remove vulnerable polished library, clean up other un-used deps

Closes #3050
Summary
polished is a helper library for styled-components that wasn't used anymore, so I thought I'd check if there were other things that aren't used anymore or other ways we could clean up the repo a bit.
Change List (commits, features, bugs, etc)

mockdate is only used in tests -- switched to devDep
polished isn't used at all -- removed. It was originally added as a helper to styled-components years ago, but isn't used anywhere now.
react-transition-group isn't used at all -- removed. It was originally added years ago but has since been removed.
update all references to /lib/ to /es/ in carbon packages (icons mainly)
fbjs removed -- I completely removed it, and didn't have any issues with linking it locally with using "carbon-addons-iot-react": "link:../../pal-build" in the package.json (pal-build is a directory containing the built files copied into it), but it was only added back in April https://github.com/carbon-design-system/carbon-addons-iot-react/pull/2276, so I'd like for @scottdickerson to smoke-test this for us, but it's passing in the CI build test.
downshift isn't used. removed. It was originally added when smoke-testing an old carbon upgrade, but it's a dependency of carbon, so we don't need to explicitly include it or pin the version. https://github.com/carbon-design-system/carbon-addons-iot-react/pull/1462
lodash - replace lodash with lodash-es. @carbon/charts uses lodash-es, so instead of having consumed applications have both, this makes them only build with one. This was a pretty automated replacement using a regex search and replace, and then running eslint --fix and yarn format to pretty it up. Added the custom eslint rule to point people toward lodash-es instead.

Current with lodash
After Switch to lodash-es

Acceptance Test (how to verify the PR)

confirm removed packages have no affect

Regression Test (how to make sure this PR doesn't break old functionality)

fbjs could potentially cause issues with local linking, so we need to test that thoroughly

Things to look for during review

[ ] Make sure all references to iot or bx class prefix is using the prefix variable
[ ] (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
[ ] UI should be checked in RTL mode to ensure the proper handling of layout and text.
[ ] All strings should be translatable.
[ ] The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
[ ] Unit test should be written and should have a coverage of 90% or higher in all areas.
[ ] All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
[ ] Changes or new components should either write new or update existing documentation.
[ ] PR should link and close out an existing issue

hey @scottdickerson. Do you have a moment to check this PR?

if a local yarn link from a downstream project worked for you @davidicus then we're good I think

if a local yarn link from a downstream project worked for you @davidicus then we're good I think

Yes, we yarn link in our test app that we build in our github actions so we should be good.


New detours detection

As stated in the documentation, a plan is currently considered a detour if one of this cases occurs:

The trajectory contains parts that increase the distance to the goal.
This is checked by comparing the orientations theta_i with the goal heading
If the scalar product is below the \c threshold param, the method returns true.
The trajectory consist of backwards motions at the beginning of the trajectory,
e.g. the second pose is behind the start pose w.r.t. to the same goal heading.

This approach unfortunately fails whenever the robot has to turn around a "long" obstacle (and has no other way to reach the target): the distance to the target might initially increase to later decrease, and the heading might be completely different from the start-goal heading.
The current implementation also forces the hcp planner to ignore the orientation of the initial plans provided, which again can result in unfeasible paths when detouring obstacles (see the picture below).

The new discard logic uses a different approach: the start orientation of the current best-teb is considered to be the reference one; this is computed as the orientation of a vector starting in the first point of the trajectory and ending in the first pose whose distance is at least "length_start_orientation_vector" (see computeStartOrientation function).
The start orientation of the other plans is computed using the same approach: these are considered detours if their heading differs from that of the best teb of at least "detours_orientation_tolerance".
The user can now enable/disable this functionality through a parameter and choose to keep the orientation of the global plan with the parameter trajectory.global_plan_overwrite_orientation.

thanks for this PR! Looks good to me and I agree that using the orientation of the current best plan is more suited than relying on the goal heading.
Just one last case to discuss:
If I got it correctly, you want to allow paths that turn around an obstacle in case no alternative exists.
However, we do not consider the following case yet (see figure):
the obstacle continuously moves to the bottom right and the trajectory extends accordingly (at least until max_samples is reached) without getting erased.
On the other hand,  the straight-line alternative exists, so keeping this plan is not necessary.
What do you think about including this case?

I see, maybe we could handle this deleting alternative plans that have a length (or cost / traversing time) much bigger than that of the best plan? Or can you think about other strategies to delete them?

yes, we could compare the traversing time, e.g. getSumOfAllTimeDiffs()  from here. (Hmm, maybe we should rename this method to getTransitionTime() or similar).
We could mark a trajectory as a detour if cur_teb->getSumOfAllTimeDiffs() / best_teb->getSumOfAllTimeDiffs() > factor (excluding div by 0) with factor around 2 (new ros parameter).
However, iterating all time differences again for all alternatives requires some additional (minor) computational resources.
We could add a method getApproximateTransitionTime() wich returns sizeTimeDiffs()*TimeDiff(0) if sizeTimeDiffs()>0 as the grid is quasi-uniform.
What do you think?

Sounds reasonable, yes :)
I would assume getSumOfAllTimeDiffs to not be computationally very demanding in comparison with other parts of the code, and I'd try that in a first iteration (I'm afraid that anomalies/inaccuracies in the uniformity of the dts could make the computation less reproducible). But should it really be relevant we can for sure try your trick :) I'll PR later or next week

thanks a lot, I will wait for it before pushing a new release and merging into melodic :)

Done, I kept a bigger default limit ratio (3.0) because I found that new bands generated "on the fly", so without many optimization cycles, tend to have a relatively high traversing time even if their length is not much longer than that of the best teb. If, after playing with it, you think that a different value would fit more use-cases, we can of course change it, or switch to a length-based logic :)

thank's, looks good ;-)


Improve font performance and lie detection

use pseudo content + var() or attr() to load fonts

concept: https://jsfiddle.net/j6gc8amy/10/

64 font test (final with lie detection): https://jsfiddle.net/8p13cj5o/ (35-70ms, 350ms on load)

485 font test w/o lie detection: https://jsfiddle.net/djgwycbp/ (160-250ms, ~1000ms on load)

detect via:

scrollWidth,
scrollHeight
offsetWidth
offsetHeight
clientWidth
clientHeight

https://stackoverflow.com/a/21064102
use css pseudo selectors: https://stackoverflow.com/a/48939094

lie detection - needs testing
const { offsetWidth, offsetHeight } = span
if (offsetWidth != width.toFixed(0) || offsetHeight != height.toFixed(0)) {
    lied = true
}

[requires more research]


Implementation of PokeSnipers

Short Description
Use Sniping websites like pokemon https://pokesnipers.com/ | pokesniper.org/ | pokesnipe.de/ to find uncommon/rare pokemons.
Possible solution
http://pokeapi.pokesnipe.de/ this site offers a json api that can be implemented. after going to location and encountering the pokemon(DON'T CATCH IT YET OR YOU'LL GET BANNED) return to the last stable location or your location before using sniper, and then catch it. using this method, one dosen't get banned.
How it would help others
It would help in getting better "VIP" pokemons

Currently maps.pikabot.org is working for me. It pulls locations of pokemon and you snipe them. It has a priority list in the config so it doesn't just snipe some Ratata in China. But yeah, this would be a cool implimentation, but I believe maps.pikabot.org is better (not because I'm biased towards PokamonGoF products) but because you can priority Charmander and it's evolutions if you want one to evolve or catch a Charizard and so on.

pokesnipers (and other json type sites) are now supported by the new Sniper task. Closed.


WSL2 iptables port forwarding from Distro port to Windows port host doesn't work

Environment
Windows build number: **[Version 10.0.18363.1082]**
Your Distribution version: **Release:        20.04**
Whether the issue is on WSL 2 and/or WSL 1: **WSL 2**

Steps to reproduce
Start Apache http server on port 8282 on the Windows host.
Log into WSL Ubuntu distro and execute the following set of commands:
export WSL_WINDOWS_HOST=$(tail -1 /etc/resolv.conf | cut -d' ' -f2)
export WSL_LOCAL_IP=`ip addr show eth0 | grep -oP '(?<=inet\s)\d+(\.\d+){3}'`

sudo vim /etc/sysctl.conf
... Uncomment net.ipv4.ip_forward = 1
sudo sysctl -p
sudo sysctl --system
sudo iptables -t nat -A PREROUTING -p tcp --dport 8282 -j DNAT --to-destination $WSL_WINDOWS_HOST:8282
sudo iptables -t nat -A POSTROUTING -p tcp -d $WSL_WINDOWS_HOST --dport 8282 -j SNAT --to-source $WSL_LOCAL_IP
telnet $WSL_WINDOWS_HOST 8282 -> Connects as expected
telnet $WSL_LOCAL_IP 8282 -> Fails to connect -  Unable to connect to remote host: Connection refused
Expected behavior
Since Apache is running on port 8282 on the Windows host and port forwarding rules were added to WSL, I expect that telnet telnet $WSL_LOCAL_IP 8282 actually works and connects to the Windows host.
Actual behavior
I'm getting connection refused.
Basically, what I'm trying to achieve is to forward all traffic on port 8282 of the WSL distro to port 8282 to the Windows host

hi, how to solve it?

How does it work?


Manage Users route protection

Non-admin users will not see link to users page, will be redirected if they try to type in url

Added some error handling to transaction forms to prevent empty item data, added new transaction reducer to display list of transactions after new one is added, modified styling of update transaction form to closer match new transaction form. Not 100% match and still needs click outside of modal to close it


allow Entity to be deserialized with serde_json

Objective

serde_json assumes that numbers being deserialized are either u64 or i64.
Entity serializes and deserializes as a u32.
Deserializing an Entity with serde_json fails with: Error("invalid type: integer 10947, expected expected Entity"

Solution

Implemented a visitor for u64 that allows an Entity to be deserialized in this case.
While I was here, also fixed the redundant "expected expected Entity" in the error message
Tested the change in a local project which now correctly deserializes Entity structs with serde_json when it couldn't before

bors r+


Tab's name becomes like "DOWNLO~1"

Describe the bug
When I open folders using Files from other applications(e.g.Chrome), the tab's name becomes like "DOWNLO~1."
To Reproduce
Example of open Files from Chrome.

Open Chrome
Download something.
Right-click on it and open the folder.

Expected behavior
Please show the full name of the folder.
Screenshots

Desktop (please complete the following information):

OS Version: [Windows 10 20H2 19042.746]
App version: [v<IP_ADDRESS>]

Additional context
Log file
debug.txt
debug_fulltrust.txt

Hasnt this been fixed


Unable to install release 1.0 via Cocoapods

Hello,
Currently having issues trying to install via Cocoapods.  'pod install' returns the following error: [!] Unable to find a specification for 'SwiftyPlistManager'

Try
pod 'SwiftyPlistManager', :git => 'https://github.com/rebeloper/SwiftyPlistManager.git', :tag => '1.0.1'


Add actionview-svelte-handler

Action View Svelte Handler is a template handler for Svelte files which allows for seamless creation of .html.svelte views with props!

@reesericci Thanks so much, sorry for delay!


Incorrect CI PR benchmark comparison

Hi,
while trying to set up benchmarking in CI for Vapor's JWTKit, I'm running into some issues I can't get a hold of. The main issue is the wrongly measured comparison between branches, of which you can see an example here (it's a fork of the repo to keep the main repo "clean" until I find a solution). This PR brings absolutely no changes to the benchmarked code, it's just a test README update and as you can see the measurements are completely wrong. The same happens on the main repo too: https://github.com/vapor/jwt-kit/actions/runs/8492609046/job/23265790197?pr=152
The result is always either a benchmarkThresholdRegression or benchmarkThresholdImprovement error, that's why I tried to increase the thresholds for the benchmarks over here, however this doesn't seem to work as the threshold in the results (you can check the first linked PR results) is always 5. I also tried setting the thresholds on the single benchmarks directly but no luck. It's not a caching issue or similar as I tried enabling and disabling various metrics and that seems to work (as you can see the only thing enabled right now is throughput): something else must be wrong when updating the metrics. Finally, here is the workflow we're using to benchmark PRs, we tried following the one in this repo.
I've also considered that it might be solved with a private GH runner. What do you think?
Thanks!

Thanks for the report, unfortunately away for a couple of weeks and won't have time to check on this until then, sorry for delay.

Hi @ptoffy,
Yes I believe it is due to running on GitHub's CI infrastructure and "noise neighbours" for the most part.
Can verify locally by creating 3 runs on where development was done:
swift package --disable-sandbox benchmark baseline update run1 --target Signing
swift package --disable-sandbox benchmark baseline update run2 --target Signing
swift package --disable-sandbox benchmark baseline update run3 --target Signing

And comparing them:
swift package benchmark baseline compare run1 run2
swift package benchmark baseline compare run1 run3
swift package benchmark baseline compare run2 run3

The metrics on macOS have less variations than on Linux for me it seems; but they're a lot less than the linked workflow result.
You may find that increasing the number of samples by increasing the test duration will also create more stability:
Benchmark.defaultConfiguration.maxDuration = .seconds(10)

Hi @ptoffy , yeah @vsarunas is correct, running time/throughput measurements on GitHub infrastructure isn't a good proposition (which is why we recommend a standalone runner for such metrics if you want them in CI) - the environment is simply not controlled enough. We are considering adding e.g instruction count also (in https://github.com/ordo-one/package-benchmark/issues/242) which could be a better proposition (if we can get those stats on the runner, remains to be seen..) as it then is a proxy of the runtime in practice. Other metrics such as malloc count and sys calls works fine on GitHub ci though. Closing this for now, feel free to open up follow up issues as needed.


Getters only retrun const refs now!

#115
I have tried to check through everything, so this should be dealt with.

I have changed what I could, I need your input for the rest because I'm not sure how best to go about it.

OK, I have made use of member functions and I think this should be better now :)

In general make sure we get results that make sense, where they evolve where we expect them to evolve. Both in Debug and Release.

Sure, will do! Will merge if all goes well.

OK, it's not working. I will try to figure it out and fix it, but it might also be worth making a test that checks if mutate is called correctly?

@swom I think I have found the problem, but I am not sure how to fix it.
Since I have switched the getters to const refs, we have many cases where we want to copy a constant individual into a new individual.
What this changes is that now, the copy = operator is being used instead of the move = operator.
If my understanding of the situation is correct, the copy = operator is faulty : since only the value of the network is copied rather than the pointer, the type of mutator network is not copied, which messes things up.
One solution I could see is to change the copy = operator to instead re-construct a new individual with the same characteristics. Does that seem like a right approach or can you think of something easier?


Add unit tests

We should be able to test whether or not our various inspects are working properly. That means adding unit tests for each part of MEV-Inspect-py.

On-going but we have some unit tests now :)


Value mapping & message mapping types are not getting synced using the sync action

Value mapping & message mapping types are not getting synced using the sync action.

ddd

found the solution


How do I get the latest code on github.

When I use vcpkg_from_github in https://github.com/microsoft/vcpkg/pull/8233 , e.g.
vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO chokkan/crfsuite
    REF 0.12
    SHA512 7cb02c1ac72613bafd639e1ef9a7ce7ddb0d36b2e7038c45f9745ad177344c3f20c7df48dfc1bdce364af1d0a85957a918ed8fee078232d5a2c91ab3796ee7f0
    HEAD_REF master)

The code will be downloaded from Downloading https://github.com/chokkan/crfsuite/archive/0.12.tar.gz, which is different from the code in https://github.com/chokkan/crfsuite.
For example, the os.h file under include.
Could you please tell me how to get the latest code via vcpkg_from_github?
Thanks.

Hi @ava-YangL, you can get the latest code from latest commit on crfsuite source page(https://github.com/chokkan/crfsuite/commits/master). You need modify verison in CONTROL file and REF in portfile.cmake, See more information here:
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/control-files.md#version
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_from_github.md#ref

It works! Thanks Lily  👍 👍


[master]update doc for deleting the resize code when creating image

Signed-off-by: wgxoyun<EMAIL_ADDRESS>

Are you sure this doc change related to deleting resize code?

Yes, before the deletion, zcc uses resize command to resize disk, after deletion, we use cloud-init to resize disk, so zcc will depend on cloud init. So i change the image creation document to tell user the cloud-init is necessary. @bjhuangr

@dongyanyang please double check.


Remove top const from dynamic array types and pointer types in IFTI.

The change Walter and Andrei decided.
All test suites pass, and following original sample also compiles.
import std.algorithm;
void main() {
    const arr = [1, 2, 3];
    assert(reduce!"a*b"(arr) == 6);
}

That was fast!


Fix some uses of Field inside of Annotated

Fixes https://github.com/pydantic/pydantic/issues/6353

please review


hydra.errors.MissingConfigException: Could not load hydra/hydra_logging/default

🐛 Bug

I installed fairseq as described in the README and ran the command as described IWSLT'14 German to English (Transformer)
Then the following error occurred at training step.
CUDA_VISIBLE_DEVICES=0 fairseq-train \
    data-bin/iwslt14.tokenized.de-en \
    --arch transformer_iwslt_de_en --share-decoder-input-output-embed \
    --optimizer adam --adam-betas '(0.9, 0.98)' --clip-norm 0.0 \
    --lr 5e-4 --lr-scheduler inverse_sqrt --warmup-updates 4000 \
    --dropout 0.3 --weight-decay 0.0001 \
    --criterion label_smoothed_cross_entropy --label-smoothing 0.1 \
    --max-tokens 4096 \
    --eval-bleu \
    --eval-bleu-args '{"beam": 5, "max_len_a": 1.2, "max_len_b": 10}' \
    --eval-bleu-detok moses \
    --eval-bleu-remove-bpe \
    --eval-bleu-print-samples \
    --best-checkpoint-metric bleu --maximize-best-checkpoint-metric
Traceback (most recent call last):
  File "/home/hoge/.pyenv/versions/3.6.6/bin/fairseq-train", line 33, in <module>
    sys.exit(load_entry_point('fairseq', 'console_scripts', 'fairseq-train')())
  File "/work/yoshimura/fairseq/fairseq_cli/train.py", line 385, in cli_main
    cfg = convert_namespace_to_omegaconf(args)
  File "/work/yoshimura/fairseq/fairseq/dataclass/utils.py", line 324, in convert_namespace_to_omegaconf
    composed_cfg = compose("config", overrides=overrides, strict=False)
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/experimental/compose.py", line 37, in compose
    with_log_configuration=False,
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/_internal/hydra.py", line 512, in compose_config
    from_shell=from_shell,
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/_internal/config_loader_impl.py", line 156, in load_configuration
    from_shell=from_shell,
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/_internal/config_loader_impl.py", line 262, in _load_configuration
    run_mode=run_mode,
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/_internal/config_loader_impl.py", line 804, in _merge_defaults_into_config
    hydra_cfg = merge_defaults_list_into_config(hydra_cfg, system_list)
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/_internal/config_loader_impl.py", line 783, in merge_defaults_list_into_config
    package_override=default1.package,
  File "/home/hoge/.pyenv/versions/3.6.6/lib/python3.6/site-packages/hydra/_internal/config_loader_impl.py", line 715, in _merge_config
    raise MissingConfigException(msg, new_cfg, options)
hydra.errors.MissingConfigException: Could not load hydra/hydra_logging/default

Expected behavior
I tried the following:

pip uninstall hydra-core and pip install hydra-core --upgrade
pip uninstall hydra-core and pip uninstall fairseq and  reinstall fairseq (pip install --editable .)

but, it didn't work (same error)
Environment

fairseq:  1.0.0a0+6815772
PyTorch: 1.5.0
OS: Ubuntu
How you installed fairseq (pip, source): source
Build command you used (if compiling from source): pip install --editable .
Python version: 3.6.6

@omry do you know whats going on here?

No. I have never seen this.
I am not familiar with fairseq-train. is it an argparse based app using the Compose API?

Can you show the output of pip freeze?
Can you try to run one of the standard Hydra example apps from the Hydra repo and see if they run?

Is this still an issue? I wasn't able to reproduce it on master or the latest stable release (0.10.1). Can you try one of those and reopen if this is still a problem?

It could be a version issue of hydra-core(1.0.6? or 1.1.2 for different versions of fairseq)

@kokeman, It could be a version issue of hydra-core(1.0.6? or 1.1.2 for different versions of fairseq)


[metricsadvisor] update sample links

Resolves #14087

/check-enforcer reset

/check-enforcer

/check-enforcer override


The "reply as topic" function does not work

Nodebb v. 1.19.0
No link to a new topic is created, only text

Can you share a screenshot from the composer showing what the content is when click reply as topic

barisusakli

Yes

Everything works correctly on the nodebb forum
https://community.nodebb.org/topic/16290/my-test

Seems like an issue with the composer you are using then.

Seems like an issue with the composer you are using then.

I  use quill v. 2.3.1,  nodebb plugin composer default is disabled.


[release/1.2] Unpack should set 0755 when the parent directory doesn't exist.

For https://github.com/containerd/containerd/issues/3017.
Cherrypick of #3018
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM


Unable to start vite server once I added this plugin

Following the readme and adding this plugin results in an error when trying to start the vite dev server. Simply removing that last plugin call, and of course all code added to use it in other files and the server starts up fine again.
╰─ yarn vite-tauri dev                                                                                ─╯
yarn run v1.22.11
$ vite-tauri dev
23:22:04 PM [vite-plugin-tauri]  Starting Vite dev server...
failed to load config from /vite.config.ts
file:///vite.config.ts.js?t=1630466524160:15
    Layouts({
    ^

TypeError: Layouts is not a function
    at file:///vite.config.ts.js?t=1630466524160:15:5
    at ModuleJob.run (node:internal/modules/esm/module_job:183:25)
    at async Loader.import (node:internal/modules/esm/loader:178:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)
    at async loadConfigFromFile (/node_modules/vite/dist/node/chunks/dep-972722fa.js:75819:31)
    at async resolveConfig (node_modules/vite/dist/node/chunks/dep-972722fa.js:75434:28)
    at async createServer (node_modules/vite/dist/node/chunks/dep-972722fa.js:73957:20)
    at async dev (node_modules/vite-plugin-tauri/bin/index.js:156:18)
    at async node_modules/vite-plugin-tauri/bin/index.js:184:7
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

And for reference here are some files:
vite.config.ts
import { defineConfig } from 'vite'
import Vue from '@vitejs/plugin-vue'
import Pages from 'vite-plugin-pages'
import Layouts from 'vite-plugin-vue-layouts'
import { resolve } from 'path'

// https://vitejs.dev/config/
export default defineConfig({
	resolve: {
		alias: {
			'@': resolve(__dirname, 'src')
		}
	},
	plugins: [
		Vue(),
		Layouts({
			layoutsDir: 'src/layouts'
		}),
		Pages({
			exclude: ['**/components/*.vue'],
			pagesDir: [
				{ dir: 'src/pages', baseRoute: '' },
				{ dir: 'src/features/**/pages', baseRoute: 'features' },
				{ dir: 'src/admin/pages', baseRoute: 'admin' }
			]
		})
	]
})

tsconfig.json
{
	"compilerOptions": {
		"target": "esnext",
		"module": "esnext",
		"moduleResolution": "node",
		"strict": true,
		"jsx": "preserve",
		"sourceMap": true,
		"importHelpers": true,
		"skipLibCheck": true,
		"resolveJsonModule": true,
		"allowSyntheticDefaultImports": true,
		"experimentalDecorators": true,
		"esModuleInterop": true,
		"pretty": true,
		"baseUrl": ".",
		"paths": {
			"@/*": ["./src/*"]
		},
		"lib": ["esnext", "dom", "DOM.Iterable", "ScriptHost"],
		"types": ["vite/client", "vite-plugin-vue-layouts/client", "vite-plugin-pages/client"]
	},
	"include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue"],
	"exclude": ["node_modules", "**/*.spec.ts"]
}

No idea, it works for me and others.  Can you create a reproduction repo?

I just publish a clone repo so you can see it.
Repo that has the issue.
Commenting out the relevant lines for this plugin in vite.config.ts and also from code/router.ts and the server starts up.

OK, I see the error, but I'm completely stumped.  The one thing I see in VS Code when comparing it to Vitesse is that something is creating a vite.config.ts.js file.  In the standard templates, that file is not created.  Vite doesn't need it. I feel like that is the problem but I can't figure out why that file is being created here and not in the standard templates.

Figured it out.  Take this out of package.json
    "type": "module",

That seems to break all sorts of things


Add documentation for available status codes

There was no way to determine what actual names were available outside
of looking at the source code. They were not listed in the documentation
or accessible through the interactive help.
In addition, doing pydoc requests.status_codes displayed some pretty
unhelpful information - the utf-8 encoding string was included in the
module name, there was no description, and internal variables used for
initialisation leaked into the module scope:
DATA
    code = 511
    codes = <lookup 'status_codes'>
    title = 'network_authentication'
    titles = ('network_authentication_required', 'network_auth', ...

This change prevents the internal variables from leaking, adds a
docstring (which has the side-effect of correcting the module name), and
appends information on the allowed status code names to the docstring
when the module is initialised.
The improved module documentation is then used in the API documentation
to provide another easy reference to the complete list of status codes.

Codecov Report

Merging #4394 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4394      +/-   ##
==========================================
+ Coverage   89.05%   89.08%   +0.03%
==========================================
  Files          18       18
  Lines        2055     2062       +7
==========================================
+ Hits         1830     1837       +7
  Misses        225      225

Impacted Files
Coverage Δ

requests/status_codes.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68ef0e...c250701. Read the comment docs.


bug(MatDatepicker): Updating FormControl value with emitEvent: false still trigger valueChanges

Reproduction
Use StackBlitz to reproduce your issue: https://stackblitz.com/edit/angular-ivy-ad4d4j?file=src/app/app.component.ts
Steps to reproduce:

Use <mat-date-range-input> to create a date range picker
Wait until the view has rendered
Update the value of start or end date for the FormControl when using { emitEvent: false }
FormGroup.valueChanges will be triggered even though it should not

// Using this code after the view has initialized should not emit a new value for `FormControl.valueChanges`
this.form.controls.start.setValue(new Date(), { emitEvent: false });

Expected Behavior
No value emitted on FormControl.valueChanges
Actual Behavior
A new value emitted on FormControl.valueChanges
Environment

Angular: 12.2.5
CDK/Material: 12.2.4
Browser(s): Chrome v95
Operating System (e.g. Windows, macOS, Ubuntu): Windows

https://github.com/angular/components/issues/9295 seems slightly related to this, but not fully. As far as I could see, it seems likely that both issues are caused by re-running validation that triggers emission of new values.

I believe that this is the same root cause as #21875. The tl;dr is that the built-in start/end date validators require the opposite input to be change detected which means that have to trigger some changes manually, causing events to be emitted. I've added a topic for our next team meeting to discuss potentially removing these validators, because they've been a source for a lot of bugs.


Support widget customization

Suggested new feature or improvement
IWidgetProvider2 got released in WinAppSDK 1.4
Scenario
Users could customize their widgets.
Additional details
No response

Duplicate of #113


pre-release v3.6.0

About this change—what it does
v3.6.0 pre release

running acceptance test https://github.com/aiven/terraform-provider-aiven/actions/runs/2961676389


Views do not have "ctid"

What happens?
Cannot use postgres_scan over a view, as ctid is not defined:
Error: IO Error: Unable to query Postgres: ERROR:  column "ctid" does not exist

To Reproduce
Try to read a view
OS:
Ubuntu 22.04
PostgreSQL Version:
9.6.22
DuckDB Version:
v0.8.1
DuckDB Client:
v0.8.1
Full Name:
Francesco Frassinelli
Affiliation:
NINA
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

See #81


feature: Support of jdtls Java extensions.

Did you check the docs?

[X] I have read all the docs

Is your feature request related to a problem? Please describe.
We are not able to use the jdtls Java extensions. I tried to use require('java.utils.jdtls') but is not working.
local jdtls = require('jdtls')

-- Helper function for creating keymaps
function nnoremap(rhs, lhs, bufopts, desc)
  bufopts.desc = desc
  vim.keymap.set("n", rhs, lhs, bufopts)
end

-- The on_attach function is used to set key maps after the language server
-- attaches to the current buffer
local on_attach_jdtls = function(client, bufnr)

  -- Java extensions provided by jdtls
  nnoremap("<C-o>", jdtls.organize_imports, bufopts, "Organize imports")
  nnoremap("<space>ev", jdtls.extract_variable, bufopts, "Extract variable")
  nnoremap("<space>ec", jdtls.extract_constant, bufopts, "Extract constant")
  vim.keymap.set('v', "<space>em", [[<ESC><CMD>lua require('jdtls').extract_method(true)<CR>]],
    { noremap=true, silent=true, buffer=bufnr, desc = "Extract method" })
end

Describe the solution you'd like
It will be great to support the jdtls Java extensions, like "Extract variable",  "Organize imports", "Extract constant" at least like keymaps. If possible we can go further and have them as commands.
Describe alternatives you've considered
It looks like we can use these features when nvim-jdtls is installed. For more details: https://sookocheff.com/post/vim/neovim-java-ide/
Additional context
No response

@bmihovski nvim-java (this plugin) and nvim-jdtls are two different plugins for Neovim. In nvim-jdtls has refactoring features. Those are not yet implemented in nvim-java. If you have plans to use nvim-java then you should remove nvim-jdtls.

You can watch this https://github.com/nvim-java/nvim-java/issues/96 for future updates


C++-TempConverter

Pull Request Type
What kind of change does this PR introduce?
[ ] Solved an issue/task
added Temp Converter.cpp
This program converts Temperature in Fahrenheit to celsius

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


a2_questionnaire_design_part_a.md

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist

[ ] I can confirm that my changes are working as intended

@amanda-ng518  Hello Amanda. I revised based on your comments. Please approve. Thanks.


Modification of LoRA Setup and Correction of Supplementary Information

Default LoRA_dict arguments have been changed.
{"LoRA_1" : 0.5 , "LoRA_2" : 0.7 ,...} → {'LoRA_1' : 0.5 , 'LoRA_2' : 0.7 ,...}
クオーテーション関連のミスを修正
Modification of LoRa Setup.
added deps["accelerate"] into install_requires to enable LoRA
specify diffusers version as 0.24.0 to use tiny auto encoder

Looks good! Merged.


Currency conversion

Add a dialog to choose a source and destination currency, and automatically do the conversion for the average rate on the date of each transaction.

Could use money.js or for the lookups, but that would require an API key field, too. Seems like a Ux PITA.
Could use google or yahoo finance api too, but in my experience they're not terribly reliable.

What's the use case for this? Deutsche bank always converts the money right away (you can't withdraw dollars from an account with euros). So, purchases from a foreign currency are already converted, plus any charges, etc. Seems like any attempt for this tool to convert would be unlikely to be 100% accurate, which would just cause more issues on import into YNAB. What do you think?

The use case is to support accounts in multiple currencies - anyone with a bank account in a currency other than their primary. For example, I have a US bank account and an EU one. I live in the EU, so my YNAB "primary currency" is €. My US account is denominated in USD. If I want to have both bank accounts on YNAB, I have to do the conversion from USD to EUR before import.
The inaccuracy thing isn't much of an issue TBH. Between the bank's markup, and normal variance from the average rate, I just expect about a 5% fudge factor for my final account balance when I import/reconcile. It works well, since a secondary-currency account is almost by definition a secondary account. If your YNAB primary currency doesn't match your primary account, you're either Doing It Wrong, or Too Complicated For A Personal Budgeting Tool.

I understand your point now. I'm in the same situation, living in the EU with accounts in the US. My currency is €, but I just pretend all my accounts are in €. This is a bit inaccurate for the US accounts, but the € and $ aren't that far apart these days. Converting currency before import would lead to a more accurate overall total, but you wouldn't be able to really reconcile those accounts, since the totals would never match. I rely on those final numbers matching to know I'm up to date and that the import was successful, so this is a deal breaker for me.
That said, I probably won't work on implementing this feature. But feel free to make a fork or open a PR.

Yep, I created the issue as a placeholder. Looking forward to writing a pr.
Any recommendation on a docker or vagrant environment that should be able
to build it?
On Fri, Jan 27, 2017, 6:34 PM Colin Howald<EMAIL_ADDRESS>wrote:

I understand your point now. I'm in the same situation, living in the EU
with accounts in the US. My currency is €, but I just pretend all my
accounts are in €. This is a bit inaccurate for the US accounts, but the €
and $ aren't that far apart these days. Converting currency before import
would lead to a more accurate overall total, but you wouldn't be able to
really reconcile those accounts, since the totals would never match. I rely
on those final numbers matching to know I'm up to date and that the import
was successful, so this is a deal breaker for me.
That said, I probably won't work on implementing this feature. But feel
free to make a fork or open a PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cjhowald/ynab-csv/issues/10#issuecomment-275724420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3X-d0A6A64_Shj8UcsoMBzvyX0EMnRks5rWiq3gaJpZM4LqiFW
.

--
Campbell Vertesi
Classical Music and Code
http://campbell.vertesi.com
Twitter: @campbellvertesi


Updates

Readme fixed, images added, minor upds

@gtep96 does the comments in https://github.com/citros-garden/turtlebot3/pull/11/files#diff-754ecac19042046070bb2e94dc03a40e65757df5724c44615fdfb8c3c0546e22R51-R55 are necessary or we can delete them for cleanup?

@iftahnaf
This was for Gazebo launch, i've deleted it.


This is modded kext for MacBookPro 2010 with wifi upgrade card

http://forums.macrumors.com/threads/modded-continuity-activation-tool-btle-cards-with-el-capitan-is-working.1890715/page-16#post-22006544
http://speedy.sh/EvSE4/Archivio.zip

Thanks, I've already seen the file on macrumors and will try to update CAT to support the 2010 macbook pro again.


Bug in TRANSLATE

DATA s TYPE string.
s = 'A'.
TRANSLATE s USING 'ABBC'.
WRITE s.

result: C, correct: B
A character in text that has already been replaced cannot be replaced again in the same TRANSLATE statement.
https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abaptranslate.htm

starting this task now

@mbtools try again, 2.7.84 published

👍


[dv,clkmgr] clkmgr regression fix

add more delay for shadow registers in slow clock domain

Signed-off-by: Jaedon Kim<EMAIL_ADDRESS>

Create a new PR(https://github.com/lowRISC/opentitan/pull/12920) for this. Close this now


[BugFix] Avoid overriding the input parameter of the following tools in flow agent

Description
Remove the input parameters from params in flow agent, since this input should only applies to the current tool instead of overriding all following tools.
Related Issues
Resolves #2836
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[x] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I don't quite get the fix. The original logic is that if the current tool has input parameter, then use it for tool running. In your example, I saw PPLTool having its input parameter which should be used to run PPLTool. So I have some confusion here. It's a valid case that a following tool uses the original input parameter if they don't have it. Removing it totally doesn't make sense for me.
The CI failed due to flow agent test cases, did you try to fix them and add your test case covering your fix? I think you might have new findings when you fixing the existing test cases.

I don't quite get the fix. The original logic is that if the current tool has input parameter, then use it for tool running. In your example, I saw PPLTool having its input parameter which should be used to run PPLTool. So I have some confusion here. It's a valid case that a following tool uses the original input parameter if they don't have it. Removing it totally doesn't make sense for me.
The CI failed due to flow agent test cases, did you try to fix them and add your test case covering your fix? I think you might have new findings when you fixing the existing test cases.

In my example, the input parameter of PPLTool is from toolSpec.getParameters(),
https://github.com/opensearch-project/ml-commons/blob/b51f47f5c5263c93b24e65c22ba7eb71bd3e1ce0/ml-algorithms/src/main/java/org/opensearch/ml/engine/algorithms/agent/MLFlowAgentRunner.java#L274

while what I remove is the input parameter from params, which is a parameter of AgentTool. They are different. My point is the original input parameter in params should be apply to the first/current tool, so I remove it once it has been put into the executeParams of the current tool.
If it also makes sense that a following tool uses the original input parameter if they don't have it, I think we should adjust the sequence of putting toolSpec.getParameters() and putting params, so toolSpec's parameter could override params instead. Do you think this fix is acceptable? @jngz-es

It seems that params could be an immutable map, I think the above method of changing sequence won't break this test then.

Good to see this PR. Can you also fix the bug in MLConversationalFlowAgentRunner?

Good to see this PR. Can you also fix the bug in MLConversationalFlowAgentRunner?

Seems the method of getToolExecuteParams is duplicate between MLConversationalFlowAgentRunner and MLFlowAgentRunner, I think maybe we should deduplicate it by putting it in the super class.

@jngz-es Do you know why we do not have unit test file for conversational flow agent?


Add Support For Multiple Rooms

@geekgonecrazy @Sing-Li

added simplified setup through npm link (docs needed)
added support for multiple rooms

Can I get some :eyes: on these changes?

Looks good.  Some reason doesn't work through docker.
Couple of little things:
ROCKETCHAT_ROOM probably should just have GENERAL in it.  Since that other rooms id will be different on other servers.
ROCKETCHAT_URL probably should be localhost by default

Going to try it here, in my 'lab environment',  on docker as well. reporting back shortly.

Had to purge node_modules and do npm install again.  Now works.
Maybe we can include some of this in the image in the future

@geekgonecrazy
I have some notes I need to add to the Hubot documentation around how to build without requiring a Hubot dependency.  That will make it easier for deployments too.

@leefaus sounds good.  No fun writing documentation, but sure is helpful :+1:


reactPHP Plugin dosen't work in new version of workerman

After update workerman to new version, reactphp plugin dumped in php7+
I checked the files changed and  found Workerman/Events/React/ has update.
Base.php implements LoopInterface, so I got the error :
" Declaration of Workerman\Events\React\Base::addReadStream($stream, $listener) must be compatible with React\EventLoop\LoopInterface::addReadStream($stream, callable $listener)"

Please try to update react/event-loop to the latest version.
React/event-loop changed the React\EventLoop\LoopInterface since v0.5.0.


Bifrost & Mover build on Olde CI

:+1:

The change looks good, but also take the lines from erchef's build.sh to upload packages for both ubuntu-10.04 and ubuntu-12.04, instead of using the source machine type. You can then delete lines 10,11,12

Extra note: use caution - when I copy-pasta'd that from erchef to mover, I got tripped up because the deploy of mover used underscores in the file name, while I had used hyphens.  I changed the cookbook in that case, because +1 to consistency...

It seems odd to me that we have to hard-code the version number into this. Is there something we can do consistently across these projects to dynamically generate the release version number?

Not the version number, just 'ubuntu-10.04' and 'ubuntu-12.04'

:+1:


Verify signed Container images- Broken link Fix

Fix: #34854
Note: The coorect link for Configuration options (https://kubernetes.io/docs/tasks/administer-cluster/verify-signed-images/#verifying-image-signatures-with-admission-controller) isn't found yet. Apart from that, The broken link for 'Installation' has been fixed.

/retitle Update hyperlink for installing cosign
/sig release

/kind cleanup
Preview:
https://deploy-preview-34872--kubernetes-io-main-staging.netlify.app/docs/tasks/administer-cluster/verify-signed-images/#verifying-image-signatures-with-admission-controller

Thanks @NitishKumar06 .
/lgtm

/approve


Add assertion on DDL concurrency

MySQL 5.6+ supports concurrency on DDL statements. This feature is
called Online DDL. There is syntax changes to enable the Online
DDL, but an assertion can be made to check if full concurrency is
allowed during the DDL.
More information can be found here:
https://dev.mysql.com/doc/refman/5.6/en/innodb-create-index-overview.html
Closes #656

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Fixed changeling armor not equipping regardless of worn equipment

About the PR

This PR fixes the changeling's chitinous armor and space suit abilities. Previously, when attempting to use them, they would display overlapping popup errors and simply do nothing, even if the changeling was wearing absolutely nothing.
This PR also includes an additional integration test to check the behavior of ling armor and space suit in the future.
Technical details

ChangelingComponent now contains a new field named ActiveArmor, which contains all the entities that make up the changeling's current armor. This is used to determine whether a changeling is toggling armor on or off.
The clothing code of ChangelingSystem.TryToggleItem was split into a new method ChangelingSystem.TryToggleArmor for handling armor separate from other equipment.
Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Changelog
:cl:

fix: Fixed changeling armor refusing to equip regardless of your current equipment

Summary by CodeRabbit

New Features

Introduced integration tests for changeling armor functionality, ensuring correct equipment interactions.
Enhanced the changeling system with improved ability handling and clearer player feedback through popup messages.

Bug Fixes

Adjusted logic for armor toggling and damage application to ensure accurate gameplay mechanics.

Documentation

Updated class and method declarations to reflect new features and changes in functionality.

The AI is hallucinating changes to MaxBiomass, this PR does not touch that field at all.


docker-machine curl fails on windows 8.1 with msysgit 1.9.5-preview20150319

When trying to execute curl -L https://github.com/docker/machine/releases/download/v0.3.0/docker-machine_windows-amd64.exe > /bin/docker-machine with msysgit version 1.9.5-preview20150319 I recieve the following output:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   410    0   410    0     0    298      0 --:--:--  0:00:01 --:--:--   298
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.

When using msysgit version 1.9.5-preview141217everything is working fine.
A workaround of course is the --insecure flag but as curl -L https://get.docker.com/builds/Windows/x86_64/docker-latest.exe > /bin/docker passes without any issues and no such thing is mentionend in the docs I thought it worth a ticket.

Experienced same issue

If I experience this, sadly I usually just resort to -k, but I wonder what the underlying issue is.

same problem for me except that msysgit 1.9.5-preview20150319 fails also with the same message.
docker-latest.exe OK from https://get.docker.com with available cert.
docker-machine_windows-amd64.exe FAILED from https://s3.amazonaws.com with missing cert
The latter gets its binary from AWS and ther cert is no available

this is an issue for me as well actually


This fix the broken tsd links

Summary:
Change the old tsd links to a more complex link in statsboard built in the group_view
Test Plan:
Check if the graph match the ones in this list
https://statsboard.pinadmin.com/search?q=autoscaling

Getting
Traceback (most recent call last): File "/usr/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/local/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view return self.dispatch(request, *args, **kwargs) File "/usr/local/lib/python2.7/site-packages/django/views/generic/base.py", line 88, in dispatch return handler(request, *args, **kwargs) File "/opt/deploy_board/deploy_board/webapp/group_view.py", line 960, in get ''' % (env.envName, env.stageName)) AttributeError: 'dict' object has no attribute 'envName'

with this change.


testing for data processing

streamlined data processing, but it has too much data causing the model to run too many epoch and still not get good results.
seen in the Seismic data from station NUPH 0

view from the branch instead
not yet ready to push to main


Adds a civic.json file

Merge this to add a civic.json file to your project. This little bit of metadata will make your project easier to search for at https://www.codeforamerica.org/brigade/projects and elsewhere. :mag: You can read more about the status attribute at https://www.codeforamerica.org/brigade/projects/stages. It takes about an hour to update. :watch: If you have questions about any of this just ping @GovInTrenches. :raised_hands:

@GovInTrenches it still says 'forked from original project'. You might want to submit a new PR that just has one merged/fixed commit?


[fix] unicode_emoji.h now compiles properly

[x] My pull request is made against the dev branch.
[x] I have ensured that the changed library can be built on your target system. I did not introduce any platform-specific code.
[x] I have ensured that all methods and functions are fully documented using doxygen style comments.
[x] I tested my commits, by adding a test case to the unit tests if needed
[x] I have ensured that I did not break any existing API calls.
[x] My code follows the coding style guide (if you are not sure, match the code style of existing files including indent style etc).
[x] I have not built my pull request using AI, a static analysis tool or similar without any human oversight. Where I have generated this pull request using a tool, I have justified why this is needed.

Does it btw

Actually, all the variables will also need to be inline so as to not cause ODR violations if included in multiple TUs

i will merge this and create a second PR off the back of this that fixes the invalid symbol names.


Transfer semconv issues from spec repo to this repo?

Do we plan to move open semconv issues to this repo?

This is still under discussion.

We're deciding if we want to preserve the same labels between them
As seen from otel-proto, we still expect folks to open bugs in the specification repo, so we'll still need to look at it
It's unclear if specification repo issues still need to fix specification components or are PURELY semconv.

We haven't decided one way or the other yet, but it wasn't a clear "yes"

We're deciding if we want to preserve the same labels between them

👍 We may want some non-default labels, but only if there is any benefit (did anyone ever filter for semconv + trace for example?)

It's unclear if specification repo issues still need to fix specification components or are PURELY semconv.

Most open semconv issues should be clearly moved here. There might be a few where it's unclear, but the spec repo has enough open issues as it is, so in doubt I would move to semconv. One could also make this a largish effort and clean out old stale tickets (i.e., close instead of move some/many tickets)

As seen from otel-proto, we still expect folks to open bugs in the specification repo, so we'll still need to look at it
After https://github.com/open-telemetry/opentelemetry-specification/issues/3504 this should hopefully be rare. And then "we'll still need to look at it" is no longer really true, for the few that may still be misdirected, IMHO the spec repo owners are responsible for transferring them (there is a large overlap anyway at the moment between spec and semconv people)


kubelet's stats/summary misses container memory metrics

Hi,
It looks like that since version 1.14 of microk8s, the kubelet's stats/summary endpoint doesn't return memory metrics for containers. I did check this on the same k8s version running on Minikube, and it works just fine on any of 1.13-17. It does work with microk8s version 1.13.
I also tried to blame it on docker but using minikube, both containerd and docker makes that api respond the same way.
Inspecting services
  Service snap.microk8s.daemon-cluster-agent is running
  Service snap.microk8s.daemon-flanneld is running
  Service snap.microk8s.daemon-containerd is running
  Service snap.microk8s.daemon-apiserver is running
  Service snap.microk8s.daemon-apiserver-kicker is running
  Service snap.microk8s.daemon-proxy is running
  Service snap.microk8s.daemon-kubelet is running
  Service snap.microk8s.daemon-scheduler is running
  Service snap.microk8s.daemon-controller-manager is running
  Service snap.microk8s.daemon-etcd is running
  Copy service arguments to the final report tarball
Inspecting AppArmor configuration
Gathering system information
  Copy processes list to the final report tarball
  Copy snap list to the final report tarball
  Copy VM name (or none) to the final report tarball
  Copy disk usage information to the final report tarball
  Copy memory usage information to the final report tarball
  Copy server uptime to the final report tarball
  Copy current linux distribution to the final report tarball
  Copy openSSL information to the final report tarball
  Copy network configuration to the final report tarball
Inspecting kubernetes cluster
  Inspect kubernetes cluster

WARNING:  Docker is installed.
Add the following lines to /etc/docker/daemon.json:
{
    "insecure-registries" : ["localhost:32000"]
}
and then restart docker with: sudo systemctl restart docker
Building the report tarball
  Report tarball is at /var/snap/microk8s/1176/inspection-report-20200218_152501.tar.gz

Hi @smiklos
this looks like something we recently fixed at https://github.com/ubuntu/microk8s/pull/941/files#diff-ec14edf3916df14921355aacd66c84cbR14 it should be on edge.
You can either do a snap install microk8s --classic --edge or add the line --containerd=${SNAP_COMMON}/run/containerd.sock into /var/snap/microk8s/current/args/kubelet and restart MicroK8s with microk8s.stop; microk8s.start.

@ktsakalozos thanks, you are right that flag helps. Closing the issue


Linux Build

enough said

+69420

+65535

I could maybe attempt to do that tomorrow, as it's already nine in the evening for me.
I'd be interested to contribute without needing to know how to code in whatever language this uses.
Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

I did, I need a worse browser.

I could maybe attempt to do that tomorrow, as it's already nine in the evening for me.
I'd be interested to contribute without needing to know how to code in whatever language this uses.
Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

I did, I need a worse browser.

better*

Think we need to base the linux support on a lutris install script.

Think we need to base the linux support on a lutris install script.

Absolutely great idea! Unfortunately I don't know how to make such a script, so someone with that knowledge should do that.

Think we need to base the linux support on a lutris install script.

This is a SCANDAL!!! This NEVER should be running in Wine. Since every browser needs a kernel level AntiCheat to make sure no one "Inspects Element", I'm pretty sure it will be coming soon. Since it's impossible to write a kernel AntiCheat for Linux (that's what I heard from Tim Sweeney, and he is a SMART man), we shouldn't allow these Linux hackers to access this browser!

I could maybe attempt to do that tomorrow, as it's already nine in the evening for me.
I'd be interested to contribute without needing to know how to code in whatever language this uses.
Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

I did, I need a worse browser.

better*

than opera gx*

that's not hard

From: Llixuma @.>
Sent: Sunday, December 17, 2023 4:41:58 PM
To: Pissandshittium/pissandshittium @.>
Cc: Derry Tutt @.>; Comment @.>
Subject: Re: [Pissandshittium/pissandshittium] Linux Build (Issue #3)
I could maybe attempt to do that tomorrow, as it's already nine in the evening for me.
I'd be interested to contribute without needing to know how to code in whatever language this uses.
Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?
I did, I need a worse browser.
better*
than opera gx*
—
Reply to this email directly, view it on GitHubhttps://github.com/Pissandshittium/pissandshittium/issues/3#issuecomment-1859308957, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATXE5QMCKCFQS3XF3VMPRWDYJ5YLNAVCNFSM6AAAAABAU6CW5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJZGMYDQOJVG4.
You are receiving this because you commented.Message ID: @.***>

I could maybe attempt to do that tomorrow, as it's already nine in the evening for me. I'd be interested to contribute without needing to know how to code in whatever language this uses.
Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

i came here from him

Think we need to base the linux support on a lutris install script.

or just make a zip, that contains the windows build and a completely useless random wine binary?

 There's your reason for a lack of Linux build.

I could maybe attempt to do that tomorrow, as it's already nine in the evening for me. I'd be interested to contribute without needing to know how to code in whatever language this uses.
Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

@Stehlampe2020 Maybe you could take over for me?

I've been working on a flatpak but I got busy, so... yeah anyone else wanna take it here from me
https://github.com/Pissandshittium/xyz.aikoyori.Pissandshittium

Thank you. Flatpak is exactly the right choice for Pissandshittium.

No flatpak is too good for pissandshitium

No flatpak is too good for pissandshitium We need to offer linux users the Mac OS build so that they use darwin (a mac os emulation layer that can barely run GUI apps)and make sure to break wine support to push people to use darwin

darling*

Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

too many people

Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?
Probably a lot lol

What about a snap that builds the binary.

What about a snap that builds the binary?

docker image that builds the binary

But in all seriousness: https://github.com/Pissandshittium/xyz.aikoyori.Pissandshittium
We have a flatpak manifest but who's gonna fix it. Not joking. We want Pissandshittium to have a Linux build

linux users should know how to install a browser on their own by now

i dont use gentoo btw

linux users should know how to install a browser on their own by now

i dont use gentoo btw

I mean yeah but consider:
If there's an official Linux release, it can force users to run Pissandshittium as root.

How about giving linux users an absolute horsesh*t of an install doc and to get it, they gotta solve like another Cicada puzzle. In it we just copy the chromium dev install notes.

I'm now running a GitHub action to build Pissandshittium tarballs for packagers.
The tarball is basically the Pissandshittium repo pre-bootstrapped using depot_tools
https://github.com/Pissandshittium/chromium_source_tarball

I agree that Wine is problematic and using that to run Pissandshittium is not a solution, I would instead like to propose the following:

First, complete the Android port and make builds (see #11, #72, #83, #86)
Since Chrome OS is just a Linux distro (Gentoo-based afaik) with support to Android apps, we will automatically get Linux support via the Android build
At this point, the Linux build is essentially available as the Android build, which will reduce confusion and allow for a more agile management of the project. If people really need Pissandshittium on other Linux distros, we could simply tell them to run it in an Android emulator, or even better make packages for every distro which directly bundle the Android emulator + latest Pissandshittium build.
Actually, this is a good time to say that our priority here is really to go forward with making Pissandshittium OS... having to depend on Google with Chrome OS or Android is not ideal long-term. I will create an issue about it. Then users will simply be able to install that as their daily Linux distro and have all their Pissandshittium necessities satisfied.

I propose that we put it on Steam and force Linux users to use Proton.

From: andrigamerita @.>
Sent: Wednesday, December 20, 2023 10:55:10 AM
To: Pissandshittium/pissandshittium @.>
Cc: Derry Tutt @.>; Comment @.>
Subject: Re: [Pissandshittium/pissandshittium] Linux Build (Issue #3)
I agree that Wine is problematic and using that to run Pissandshittium is not a solution, I would instead like to propose the following:

First, complete the Android port and make builds (see #11https://github.com/Pissandshittium/pissandshittium/issues/11, #72https://github.com/Pissandshittium/pissandshittium/issues/72, #83https://github.com/Pissandshittium/pissandshittium/issues/83, #86https://github.com/Pissandshittium/pissandshittium/issues/86)
Since Chrome OS is just a Linux distro (Gentoo-based afaik) with support to Android apps, we will automatically get Linux support via the Android build
At this point, the Linux build is essentially available as the Android build, which will reduce confusion and allow for a more agile management of the project. If people really need Pissandshittium on other Linux distros, we could simply tell them to run it in an Android emulator, or even better make packages for every distro which directly bundle the Android emulator + latest Pissandshittium build.
Actually, this is a good time to say that our priority here is really to go forward with making Pissandshittium OS... having to depend on Google with Chrome OS or Android is not ideal long-term. I will create an issue about it. Then users will simply be able to install that as their daily Linux distro and have all their Pissandshittium necessities satisfied.

—
Reply to this email directly, view it on GitHubhttps://github.com/Pissandshittium/pissandshittium/issues/3#issuecomment-1864818544, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATXE5QJFIUX2MX4F4IWWGP3YKMJ65AVCNFSM6AAAAABAU6CW5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUHAYTQNJUGQ.
You are receiving this because you commented.Message ID: @.***>

we need this tho just give me a damn appimage

pkgbuild when

im sure it's every arch user's dream to download and build 50 gigs of source code every time it updates

my poor paru cache folder is gonna get fucked

every arch user's dream to download and build 50 gigs of source code

Maybe not Arch user's, but Gentoo user's, as I've heard that Gentoo by default only installs source packages where you build the apps yourself and the download is the source code plus assets instead of the compiled binaries plus assets.

the source directory is 5.9GB, not 50GB

Well, I already wondered. Normally the compiled program isn't much different in size to the source code plus assets, so a reasonably-small executable from 50GB of source code would be kind-of an off-norm thing.

I'm just going to add that the source itself without the history is around what you days but If i wanted to still sync with latest chromium I'll have to download another 45GB

I thought that GitHub repos are limited to 5gb.

From: Aikoyori @.>
Sent: Saturday, December 23, 2023 12:15:41 AM
To: Pissandshittium/pissandshittium @.>
Cc: Derry Tutt @.>; Comment @.>
Subject: Re: [Pissandshittium/pissandshittium] Linux Build (Issue #3)
I'm just going to add that the source itself without the history is around what you days but If i wanted to still sync with latest chromium I'll have to download another 45GB
—
Reply to this email directly, view it on GitHubhttps://github.com/Pissandshittium/pissandshittium/issues/3#issuecomment-1868219096, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATXE5QLEKW55AJLKNG75OILYKZZI3AVCNFSM6AAAAABAU6CW5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGIYTSMBZGY.
You are receiving this because you commented.Message ID: @.***>

@everypizza1 Maybe not for giants like Google?  I don't know.

I should be able to work on this tomorrow, but keep in mind that it'll probably be broken on both Wayland and X. Sorry to everyone using niche desktop environments.

I should be able to work on this tomorrow, but keep in mind that it'll probably be broken on both Wayland and X. Sorry to everyone using niche desktop environments.

How are we going to use it without x or Wayland support blud 😭

I should be able to work on this tomorrow, but keep in mind that it'll probably be broken on both Wayland and X. Sorry to everyone using niche desktop environments.

How are we going to use it without x or Wayland support blud 😭

tty

I should be able to work on this tomorrow, but keep in mind that it'll probably be broken on both Wayland and X. Sorry to everyone using niche desktop environments.

How are we going to use it without x or Wayland support blud 😭

tty

Fr True

I should be able to work on this tomorrow, but keep in mind that it'll probably be broken on both Wayland and X. Sorry to everyone using niche desktop environments.

How are we going to use it without x or Wayland support blud 😭

X10

I'm just going to add that the source itself without the history is around what you said but If i wanted to still sync with latest chromium I'll have to download another 45GB

We need a datacenter

where linux?!

where linux?!

Nowhere, I think. Build it yourself.
I clearly couldn't do it because I have too much other stuff to do (i.e. I don't have the time), it seems to be the same with everybody else in here who offered to build it for Linux.

pee poo

L bad browser wouldnt recommend

where linux?!
Build it yourself.

Based.

Quick question: How many of the people seeing this comment came here through Brodie Robertson's video?

I am :)

when linux

when linux

any day now

you can only hope


Remove BNSx from lookup for account names

To help reduce the overall query load on Hiro's API and avoid rate limiting for power users.
Related: https://github.com/hirosystems/stacks-blockchain-api/issues/2026

@alter-eggo please link the relevant PR


Waiting time to start is too long in win10+

As the title says, it needs more than 10s in windows 10.
It will pop up a prompt while waiting, but it was too fast to close and I can 't see what it show.

@buqiyuan bu


nixos/polybar: init

Motivation for this change
It is a bit difficult to get polybar working. It looks strange when a font is missing, and might be missing compile-time support for some use-cases. Adding a NixOS module takes care of the font and makes package configuration more discoverable to the user.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Polybar maintainers: @afldcr @filalex77

Since we're adding a polybar module to nixpkgs, would we want to merge some of home-manager's polybar code?

@aaronjanse probably? I don't use home-manager but the more I think about, its must be more of a home-manager problem than a nixos problem. Is time better spent on improving home-manager rather than expanding nixos/modules/programs?

I personally would like to see as much as home-manager as nixpkgs as possible. Otherwise, external modules have to juggle duplicated options between home-manager and nixpkgs, which could get ugly.

I personally would like to see as much as home-manager as nixpkgs as possible

I can't parse that sentence

I personally would like to see as much as home-manager as nixpkgs as possible

I can't parse that sentence

Oops, I forgot a word!
"I personally would like to see as much of home-manager merged into nixpkgs as possible."
In other words, if something in home-manager can be merged into nixpkgs, I would personally want it to be merged ;-)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/why-isnt-more-of-home-manager-merged-into-nixpkgs/6096/5

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/why-isnt-more-of-home-manager-merged-into-nixpkgs/6096/6

To be honest, this looks to trivial for a module to include in nixpkgs. It doesn't do anything except add a font to the system fonts. Is that even necessary in all cases? If I use another font for my polybar, I won't need the siji font, will I? Of course you need the fonts that you use in configs.

I'm closing this issue, as polybar support belongs in something like home-manager.

To be honest, this looks too trivial for a module to include in nixpkgs. It doesn't do anything except add a font to the system fonts. Is that even necessary in all cases? If I use another font for my polybar, I won't need the siji font, will I? Of course you need the fonts that you use in configs.

I simple solution could be to just add documentation for using the polybar package. I believe there's a section for that in the nixpkgs manual.


What is method like React.addons.batchedUpdates ?

I want to write a library called preact-test-utils instead of react-test-utils, It only mock some apis that used in enzyme. The best problem is  batchedUpdates , Simulate , findAllInRenderedTree. What is your  suggestion ?

If I understand correctly, batchedUpdates executes a user-provided callback and in the context of that callback, multiple setState calls on a component only result in a single-rerender of the component once the callback has finished running.
Preact does this batching by default, so batchedUpdates is unnecessary in the context of a normal application. When setState is called, the component is added to a queue of dirty components. All components on that queue are then rendered once in the next tick of the event loop.
In the source code, see src/component.js and src/render-queue.js.
If you want to flush the queue of pending updates synchronously rather than waiting for the next tick of the event loop, call the rerender function that Preact exports.

See also https://github.com/developit/preact/issues/146

@robertknight - good point about rerender()!

And, What about findAllInRenderedTree? Any hooks like react ?

@windyGex That's probably a good library to write.  You can either crawl the DOM and look for ._component properties, which recursively lead to components (including compositional components), or crawl the VDOM tree doing the same.
Here's an example that does the former:
https://gist.github.com/developit/63ffcd531381bee5a3d9959e3a90035b

Ok. Now I can mock findAllInRenderedTree method, but I can't find hook like react when access vnode from instance, Could you add this to component instance? I'm not sure whether to add here。
https://github.com/developit/preact/blob/master/src/vdom/component.js#L204
React instance

Preact compat instance

Well, I find code from here, and I redefine this code.
https://github.com/developit/preact/blob/master/devtools/devtools.js#L32
import preact from 'preact-compat';
const ATTR_KEY = typeof Symbol ==='function' ? Symbol.for('preactattr') : '__preactattr_';
const REACT_ELEMENT_TYPE = (typeof Symbol === 'function' && Symbol.for && Symbol.for('react.element')) || 0xeac7;
const Component = preact.Component;

function extend(base, props) {
	for (let key in props) {
		if (props.hasOwnProperty(key)) {
			base[key] = props[key];
		}
	}
	return base;
}

function createReactDOMComponent(node) {
    const childNodes = node.nodeType === 1 ? Array.from(node.childNodes) : [];
    const isText = node.nodeType === 3;
    return  {
        _currentElement: isText ? node.textContent : {
            $$typeof: REACT_ELEMENT_TYPE,
            type: node.nodeName.toLowerCase(),
            // Here are different from the react
            // react contains children
            // but polyfill have not
            props: node[ATTR_KEY]
        },
        // Here react return null
       //  but polyfill return array and contains a element
        _renderedChildren: childNodes.map(function(child){
            return child._component || child;
        }),
        getPublicInstance() {
            return node;
        },
        _stringText: isText ? node.textContent : null
    }
}

function createReactCompositeComponent(component) {
    const _currentElement = createReactElement(component);
    const node = component.base;
    return {
        _instance: component,
        _currentElement,
        _renderedComponent: createReactDOMComponent(node)
    }
}

function createReactElement(component) {
    return  {
        $$typeof: REACT_ELEMENT_TYPE,
        type: component.constructor,
        key: component.key,
        ref: null,
        props: component.props,
        // dev mode, we don't need
        _store: {}
    }
}

function patch (component) {
    extend(component._reactInternalInstance, createReactCompositeComponent(component));
}

function PolyfillComponent(props, context, opts){
    Component.call(this, props, context);
    this._reactInternalInstance = {};

    const component = this;
    const componentDidMount = component.componentDidMount;
    const componentDidUpate = component.componentDidUpate;
    this.componentDidMount = function() {
        patch(component);
        if (componentDidMount) {
            componentDidMount.apply(component, arguments);
        }
    }
    this.componentDidUpdate = function() {
        patch(component);
        if (componentDidUpdate) {
            componentDidUpdate.apply(component, arguments);
        }
    }
}

PolyfillComponent.prototype = new Component();

PolyfillComponent.prototype.constructor = PolyfillComponent;

preact.Component = PolyfillComponent;

export default preact;

but it has a problem that mock _currentElement from dom nodes。For examples
class App extends React.Component {
   render() {
     return
123

   }
   componentDidMount() {
     console.log(this)
  }
}

ReactDOM.render(<App/>, document.getElementbyId('app'))

If mock from dom nodes, the result will be difference from react, Any way can process?
@developit @robertknight
React Result

Preact polyfill Result

You might be able to mock that out:
import { options } from 'preact';

let old = options.vnode;
options.vnode = vnode => {
  let f = vnode.nodeName;
  // wrap the `render()` method for all Components (unless already wrapped)
  if (typeof f==='function' && f.prototype && f.prototype.render && !f.protoype._originalRender) {
    f.prototype._originalRender = f.prototype.render;
    f.prototype.render = injectedRender;
  }
  if (old) old(vnode);
};

// a wrapper around render() that retains a reference to the returned VNode
function injectedRender() {
  let vnode = this._originalRender.apply(this, arguments);
  let inst = this._reactInternalInstance || (this._reactInternalInstance = {});
  inst._currentElement = vnode;
  return vnode;
}

Thx for your quick reply. I‘m so sorry, I still have a problem about ShallowRenderer. It looks need to modify internal code of preact, is right?

@windyGex I've been wanting to implement a preact-shallow-render module, which would probably meet that usecase.  It should just render VDOM to resolved VDOM - useful for testing.

@developit is there any news on the ShallowRenderer on preact?

No, not at this time.

I'm closing this issue as the original question was answered above. Feel free to continue the other discussion.


Fix asset creation when asset file names aren't valid nix drv names

I have:

[x] Based work on latest develop branch
[x] Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
[x] Run the test suite: $(nix-build -A selftest --no-out-link)
[ ] (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

It looks like something similar was added to nixpkgs, recently:
https://github.com/NixOS/nixpkgs/blob/3b4df94aeb6e215085d08e3d5b0edc1313b9f584/lib/strings.nix#L698-L726
I don't think we have access to it, but maybe we should leave a note to use that once it's available.

Aha thanks. I did ask on IRC if such a thing existed already. Thanks for locating it.

FTR These names don't case path collisions because they are appended to the hash of the file in the nix store path.


Ensure ewma int64s are always aligned.

Fixes #2666
Not super happy with this solution, but I've confirmed the extra alignment in the ewma struct is necessary.

@juliusv said:

How about just making them pointers to independently allocated structs then (with a big fat comment that it should stay this way)? Saves us all the extra padding fields in tomwilkie@f1806c3. AFAIU there is no guarantee about those padding fields creating alignment either?

 Saves us all the extra padding fields in tomwilkie@f1806c3. AFAIU there is no guarantee about those padding fields creating alignment either?

Done, and tested that this still fixed the problem on ARM.

:+1: besides nit.

Sorry about that - fixed; would you believe I've been trying to catch my typos before sending for review?

@tomwilkie :D Thanks!


Fix handle_tool_call function placement

The function is now coming before the chat() function, as a function must be defined before calling/invoking it. This change prevents the "handle_tool_call" is not defined error.

Ah @Ishan-Karpe I very much appreciate your contribution.. but...
I have made several blunders in my code in my time. But on this occasion, I don't believe I have an error! Unless I'm misunderstanding you, it's completely allowed (and very common) to call a function within another function before it's been defined. So this is valid python - try it out in a Jupyter notebook!
def function1():
    function2()

def function2():
    print("Tada!!")

function1()

And week2 day4 code runs nicely as is, as evidenced by the attached screenshot below - all cells have run, and the tool is called!
If you were having problems, is it possible you didn't execute all of the cells?
Let me know if I've misunderstood.


[ATIP-android] add new step to launch test app

-add new step to launch test app by click app icon

verified locally. @Honry please review it.

LGTM


using docker endpoint incorrectly

see: https://github.com/opensyllabus/osp-api/pull/51#discussion_r127600735

Thanks @meyskens :3

Resolved in upcoming feature/deploy-to-ecr commit...


Fix ClusterInitTest#should_wait_for_each_contact_point_at_most_once.

Use TestUtils.numberOfLocalCoreConnections to get correct number of core connections used based on protocol version.  Was failing on 2.1 running against a 2.1+ cassandra cluster.

I committed this directly to master closing


Why is such low CFG required? Also watermarks…

First off, this model is awesome. Excellent job. It can produce some really good results.
I do want to ask though, why is such low CFG required? I typically use CFG 7 and get great results, but I see the samples in this repo use 3.5. I have also had to use 3.5 to get good results otherwise the results are quite oversaturated.
I also noticed that there seems to be some watermark pollution when using this. It doesn’t happen on every image but it is quite frequent especially with Getty watermarks… Could this be an artifact from training? Negative prompts don’t seem to help much.
Once again, this model and work is quite excellent. Just wanted to provide my observations

It's not required to set a low CFG. In our online, it is fine to use CFG=5/6/7. It depends on your base model.
As we train on in the wild dataset, watermark does exist. One suggestion is to generate in other size, such as 1024x768, instead of 1024x1024. This helps.


chore(dev-deps): update semantic-release monorepo

This PR contains the following updates:

Package
Type
Update
Change

@semantic-release/release-notes-generator
devDependencies
patch
11.0.3 -> 11.0.4

semantic-release
devDependencies
patch
21.0.6 -> 21.0.7

Release Notes

semantic-release/release-notes-generator (@semantic-release/release-notes-generator)
v11.0.4
Compare Source
Bug Fixes

deps: update dependency read-pkg-up to v10 (68772c4)

semantic-release/semantic-release (semantic-release)
v21.0.7
Compare Source
Bug Fixes

deps: update dependency read-pkg-up to v10 (#2862) (70996e0)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Find a better name for helpers

Assistants! Butlers! Service personnel!

Nice ones :stuck_out_tongue_winking_eye:
The point of helpers are to ease the injection of a specific interface into another object. These are basically traits implementing the methods of an "aware" interface.


add manual interface for borrowing a GuestPtr

Alex pointed out this issue here: https://github.com/kubkon/wiggle/pull/39#discussion_r389212980

Ah good point. I was thinking that was covered by as_raw but you may need to borrow something you're just making a copy of as well, in case of overlaps.