Some agents aren't deallocated

I have some agents which are shutting down, but not being deallocated.
This is a similar, if not the same, issue as #64 however the fix given there doesn't work in my case. We did originally have a different idle timeout to our current one, but the agents which are failing to deallocate where created after the timeout was last changed.
Here is the relevant server log, where you can see that tcagent3 has been found to be stopped. You can also see an agent which was successfully deallocated (tcagent2) gets the Stopping virtual machine tcagent2 message. There is not a Stopping virtual machine tcagent3 message.
[2017-11-04 01:30:39,254]   INFO [ey'{id=arm-1} 2] - base.tasks.UpdateInstancesTask - Updated instance 'tcagent3' status to Stopped based on API information
[2017-11-04 01:30:39,254]   INFO [ey'{id=arm-1} 2] - uds.base.AbstractCloudInstance - Changing tcagent3(247c3648) status from Running to Stopped
[2017-11-04 01:30:40,647]   INFO [uled executor 5] - .server.impl.CloudEventsLogger - Cloud instance entered 'stopped' state, profile 'Azure'{id=arm-1}, AzureCloudInstance{myName='tcagent4'}
[2017-11-04 01:30:40,647]   INFO [uled executor 5] - .server.impl.CloudEventsLogger - Cloud agent Unregistered agent "tcagent4" {id=298} is no longer recognized as cloud agent because instance has gone: profileId=arm-1, imageId=tcagent, instanceId=tcagent4
[2017-11-04 01:30:40,647]   INFO [uled executor 5] - ver.instances.AgentRemoverImpl - Removing cloud agent Unregistered agent "tcagent4" {id=298} because: Cloud instance (id=tcagent4, imageId=tcagent, profileId=arm-1) has gone (is not reported by cloud profile)
[2017-11-04 01:30:40,663]   INFO [uled executor 5] - .server.impl.CloudEventsLogger - Cloud instance entered 'stopped' state, profile 'Azure'{id=arm-1}, AzureCloudInstance{myName='tcagent3'}
[2017-11-04 01:30:40,665]   INFO [uled executor 5] - .server.impl.CloudEventsLogger - Cloud agent Unregistered agent "tcagent3" {id=299} is no longer recognized as cloud agent because instance has gone: profileId=arm-1, imageId=tcagent, instanceId=tcagent3
[2017-11-04 01:30:40,666]   INFO [uled executor 5] - ver.instances.AgentRemoverImpl - Removing cloud agent Unregistered agent "tcagent3" {id=299} because: Cloud instance (id=tcagent3, imageId=tcagent, profileId=arm-1) has gone (is not reported by cloud profile)
[2017-11-04 01:34:44,822]   INFO [uled executor 5] - ances.KillIdleRunningInstances - Terminating instance AzureCloudInstance{myName='tcagent2'}, profile 'Azure'{id=arm-1} with idle time 15 minutes (idle time is 15 minutes)
[2017-11-04 01:34:44,834]   INFO [uled executor 5] - l.instances.StopInstanceAction - Terminating instance: AzureCloudInstance{myName='tcagent2'}, profile 'Azure'{id=arm-1}, reason: idle timeout of 15 minutes reached
[2017-11-04 01:34:44,837]   INFO [uled executor 5] - r.impl.DBCloudStateManagerImpl - Image: AzureCloudImage{myName='tcagent'}, profile: profile 'Azure'{id=arm-1} was marked to CONTAIN agent
[2017-11-04 01:34:44,840]   INFO [uled executor 5] - uds.base.AbstractCloudInstance - Changing tcagent2(47caa6e6) status from Running to Scheduled to stop
[2017-11-04 01:34:44,840]   INFO [onPool-worker-1] - ouds.azure.arm.AzureCloudImage - Stopping virtual machine tcagent2
[2017-11-04 01:34:45,787]   INFO [uled executor 1] - .server.impl.CloudEventsLogger - Cloud instance entered 'scheduled to stop' state, profile 'Azure'{id=arm-1}, AzureCloudInstance{myName='tcagent2'}
[2017-11-04 01:34:52,681]   INFO [nio-80-exec-188] - ver.instances.AgentRemoverImpl - Removing cloud agent "tcagent2" {id=294} because: Instance has been terminated. AzureCloudInstance{myName='tcagent2'}, profile 'Azure'{id=arm-1}
[2017-11-04 01:34:52,708]   INFO [nio-80-exec-188] - .server.impl.CloudEventsLogger - Cloud agent Unregistered agent "tcagent2" {id=294} is no longer recognized as cloud agent because instance has gone: profileId=arm-1, imageId=tcagent, instanceId=tcagent2
[2017-11-04 01:34:52,709]   INFO [nio-80-exec-188] - ver.instances.AgentRemoverImpl - Removing cloud agent Unregistered agent "tcagent2" {id=294} because: Cloud instance (id=tcagent2, imageId=tcagent, profileId=arm-1) has gone (is not reported by cloud profile)
[2017-11-04 01:37:15,210]   INFO [onPool-worker-1] - uds.base.AbstractCloudInstance - Changing tcagent2(47caa6e6) status from Scheduled to stop to Stopped
[2017-11-04 01:37:15,210]   INFO [onPool-worker-1] - ouds.azure.arm.AzureCloudImage - Virtual machine tcagent2 has been successfully terminated
[2017-11-04 01:37:15,826]   INFO [uled executor 2] - .server.impl.CloudEventsLogger - Cloud instance entered 'stopped' state, profile 'Azure'{id=arm-1}, AzureCloudInstance{myName='tcagent2'}
[2017-11-04 02:44:45,752]   INFO [uled executor 4] - ances.KillIdleRunningInstances - Terminating instance AzureCloudInstance{myName='tcagent5'}, profile 'Azure'{id=arm-1} with idle time 15 minutes (idle time is 15 minutes)
[2017-11-04 02:44:45,757]   INFO [uled executor 4] - l.instances.StopInstanceAction - Terminating instance: AzureCloudInstance{myName='tcagent5'}, profile 'Azure'{id=arm-1}, reason: idle timeout of 15 minutes reached
[2017-11-04 02:44:45,759]   INFO [uled executor 4] - r.impl.DBCloudStateManagerImpl - Image: AzureCloudImage{myName='tcagent'}, profile: profile 'Azure'{id=arm-1} was marked to CONTAIN agent
[2017-11-04 02:44:45,761]   INFO [uled executor 4] - uds.base.AbstractCloudInstance - Changing tcagent5(68ab4c2e) status from Running to Scheduled to stop

Here is the agent log from tcagent3 where we can see it has decided to shutdown. This log is a bit odd since our timeout is currently 15 minutes.
[2017-11-04 01:24:33,067]   INFO - l.directories.DirectoryMapImpl - Cleaning up old checkout directories. Default lifetime = 192 hour(s)
[2017-11-04 01:29:32,582]   WARN - rver.clouds.azure.IdleShutdown - Agent was idle for 25 minutes. Cloud profile timeout was 25 minutes. Instance will be shut down
[2017-11-04 01:29:32,582]   WARN - rver.clouds.azure.IdleShutdown - Agent was idle for 25 minutes. Cloud profile timeout was 25 minutes. Instance will be shut down
[2017-11-04 01:29:32,582]   INFO - rver.clouds.azure.IdleShutdown - To change this command define 'teamcity.agent.shutdown.command' property with proper shutdown command in the buildAgent.properties file
[2017-11-04 01:29:32,582]   INFO - rver.clouds.azure.IdleShutdown - To change this command define 'teamcity.agent.shutdown.command' property with proper shutdown command in the buildAgent.properties file
[2017-11-04 01:29:32,582]   INFO - rver.clouds.azure.IdleShutdown - Shutdown instance commands for windows server 2012 r2
[2017-11-04 01:29:32,582]   INFO - rver.clouds.azure.IdleShutdown - Shutdown instance commands for windows server 2012 r2
[2017-11-04 01:29:32,582]   INFO - rver.clouds.azure.IdleShutdown - Shutting down agent with command: shutdown -s -t 1 -c "TeamCity Agent Azure Instance shutdown on idle time" -f
[2017-11-04 01:29:32,582]   INFO - rver.clouds.azure.IdleShutdown - Shutting down agent with command: shutdown -s -t 1 -c "TeamCity Agent Azure Instance shutdown on idle time" -f
[2017-11-04 01:29:32,798]   INFO - rver.clouds.azure.IdleShutdown - Shutdown exit code:0
[2017-11-04 01:29:32,798]   INFO - rver.clouds.azure.IdleShutdown - Shutdown call:

[2017-11-04 01:29:32,798]   INFO - rver.clouds.azure.IdleShutdown - Shutting down agent with command: shutdown /s /t 1 /c "TeamCity Agent Azure Instance shutdown on idle time" /f
[2017-11-04 01:29:32,798]   INFO - rver.clouds.azure.IdleShutdown - Shutdown exit code:1190
[2017-11-04 01:29:32,798]   INFO - rver.clouds.azure.IdleShutdown - Shutdown call:

A system shutdown has already been scheduled.(1190)

[2017-11-04 01:29:32,798]   INFO - rver.clouds.azure.IdleShutdown - Shutting down agent with command: shutdown /s /t 1 /c "TeamCity Agent Azure Instance shutdown on idle time" /f
[2017-11-04 01:29:32,813]   INFO - rver.clouds.azure.IdleShutdown - Shutdown exit code:1190
[2017-11-04 01:29:32,813]   INFO - rver.clouds.azure.IdleShutdown - Shutdown call:

A system shutdown has already been scheduled.(1190)

[2017-11-04 01:29:32,813]   INFO - rver.clouds.azure.IdleShutdown - Shutdown exit code:1190
[2017-11-04 01:29:32,813]   INFO - rver.clouds.azure.IdleShutdown - Shutdown call:

A system shutdown has already been scheduled.(1190)

[2017-11-04 01:29:33,048]   INFO - r.artifacts.impl.HttpDiskCache - Cleaning up items with life time in cache greater than 172800 seconds
[2017-11-04 01:29:33,048]   INFO - r.artifacts.impl.HttpDiskCache - Finished cleaning up expired items, 0 items removed
[2017-11-04 01:29:33,048]   INFO - dDirectoryBasedCleanupRegistry - Removing files from C:\BuildAgent\temp\.old
[2017-11-04 01:29:33,048]   INFO - dDirectoryBasedCleanupRegistry - Removing files from C:\BuildAgent\work\.old
[2017-11-04 01:29:33,067]   INFO - l.directories.DirectoryMapImpl - Cleaning up old checkout directories. Default lifetime = 192 hour(s)
[2017-11-04 01:29:35,152]   INFO -    jetbrains.buildServer.AGENT - Received stop command from launcher
[2017-11-04 01:29:35,152]   INFO -    jetbrains.buildServer.AGENT - Stop command was not performed. No build to stop with reason: BuildInterruptReason.AGENT_SHUTDOWN
[2017-11-04 01:29:35,152]   INFO -    jetbrains.buildServer.AGENT - Starting agent shutdown sequence, reason: Stop command called
[2017-11-04 01:29:35,168]   INFO - agent.impl.AgentPortFileWriter - Delete agent runtime file from C:\BuildAgent\logs\buildAgent.xmlRpcPort
[2017-11-04 01:29:35,168]   INFO -    jetbrains.buildServer.AGENT - Unregistering from the server. Agent id: 298
[2017-11-04 01:29:35,230]   INFO -    jetbrains.buildServer.AGENT - Shutdown agent WebServer start
[2017-11-04 01:29:35,261]   INFO -    jetbrains.buildServer.AGENT - Shutdown agent WebServer finish
[2017-11-04 01:29:35,261]   INFO -    jetbrains.buildServer.AGENT - Shutdown agent finish
[2017-11-04 01:29:35,261]   INFO -    jetbrains.buildServer.AGENT - Shutdown agent and exit with code DIE_USER_COMMAND
[2017-11-04 01:29:35,261]   INFO - ent.impl.upgrade.AgentExitCode - Agent exited. Stop command called
[2017-11-04 01:29:35,261]   INFO - buildServer.agent.AgentMain2$2 - Closing jetbrains.buildServer.agent.AgentMain2$2@2286778: startup date [Sat Nov 04 01:03:59 UTC 2017]; root of context hierarchy

Since the Stopping virtual machine tcagent3 message never appears in the server log, the terminateInstance method doesn't seem to be getting called for it, despite the agent deciding to shutdown. The shutdown of the agent VM causes it to be in the 'Stopped (incurring charges)' state but since the server-side plugin didn't enter terminateInstance (and then stopVmAsync), the deallocation never happens.
So the bug here seems to be that the agent is shutting down when the server-side plugin isn't in terminateInstance. I don't know why this is the case. Let me know if I can provide further logs which might be of use.

@tom-dudley, I see that you are using the ARM plugin to start these machines, but in the agent log from vm tcagent3 mentioned IdleShutdown which is not used in the latest plugin builds.
Could you please verify that you're using latest version of ARM plugin and check that you don't have installed Azure Classic plugin? You could do that on the Administration -> Plugins List page.

We have the following relevant plugins on our server:

Azure integration 0.2.51
Azure Support: Resource Manager integration SNAPSHOT-20170918103035

I assume the first plugin is the Classic plugin and we're find to remove it since we only use ARM (I guess they're in conflict with one another)

@tom-dudley, yes, Azure integration is old name of Azure Classic plugin and it affects build agents started by ARM plugin.

Thanks @dtretyakov , feel free to close this issue.


[HUDI-4344] fix use of HoodieDataBlock#getRecordIterator

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Ok, so make your PR title more reasonable?

@xushiyan ok. I'll pay attention next time.


When translating a Kata, typing in the description or code window scrolls the description to the top

Issue: When translating a Kata, typing in the description or code window scrolls the description to the top
How to reproduce: Create a new Kata translation, scroll the description/Kata specs window to the bottom, and type in the code window.
Temp fix: Replacing jQuery.style with a dummy function, e.g. jQuery.style = () => null, causes this issue to disappear. The user's scroll position is likely lost when the styles are reset.
Note: This issue is separate from #1202 / #1204 and has been occurring for a while.

Duplicate of https://github.com/Codewars/codewars.com/issues/353


Feed pane: folder properties do not open

Right clicking a folder in the feeds area shows up a context menu (Update, Mark all..., Delete, Prop
erties).

Clicking on the last entry "Properties" is not  possible / does not trigger anything.

I'll look into this soon, probably is caused due to removal of existing templating system to satisfy AMO requirements

Fixed in 2.17.0


Feature documentation

List of all features with a short description.

This issue will be closed because I'm not actively working on Lychee anymore. The repository of Lychee will stay available, but the main development continues under the Lychee Organisation. A fork maintained by the community. Important issues have been migrated. Feel free to re-add your issue(s) when necessary.


fix: Updated compose syntax specifying file

Issue #, if available:
#444
Description of changes:
Adjusted the up command after the file is defined so that the command executes successfully. Huzzah for small differences between docker-compose and docker compose.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @stevenfollis !


Feature Request: product form hook

It would be great to have a hook, maybe named useProductForm, that lets you manage the current product form on a product page. It would provide the methods and state for tracking which options are selected (and the current variant as a result.)
I'm currently working on a Gastby + Shopify store, and I have a hook for this. It's not perfect, but I figured I'd put the code below in case it's helpful.
I'm aware that this code is very messy and wouldn't actually make its way into this library itself. It's heavily inspired by this implementation from the gatsby-shopify-starter. I'm only posting it below to show that this hook can be very useful 😇
It seems like you have a similar implementation in your starter. The ideal approach for this hook would be for it to work with any options a product may have, rather than specific ones like color, etc.
The api would be like this: give us the Shopify product as an argument, and this hook returns the functions needed to update the current variant selected.
Let me know if that makes sense, happy to clarify too.
import { ShopifyProduct } from '../../graphql-types'
import { useState, useContext, useEffect, useCallback } from 'react'
import StoreContext from '../context/StoreContext'
import find from 'lodash/find'
import isEqual from 'lodash/isEqual'

export const useProductForm = ({
  product,
  initialVariantSku,
}: {
  product: ShopifyProduct
  /**
   * An optional SKU for the first variant we want selected.
   *
   * If there is none, then we will fall back the first possible variant.
   */
  initialVariantSku?: string
}) => {
  const { variants, priceRange, shopifyId } = product
  const minVariantPrice = priceRange?.minVariantPrice
  const firstVariant = variants?.[0]
  const [variant, setVariant] = useState(() => {
    // we use a function here for a potentially-expensive initial state
    const initialVariant =
      initialVariantSku &&
      variants?.find(
        variant => variant?.sku && variant.sku === initialVariantSku
      )
    return initialVariant || firstVariant
  })
  const [quantity, setQuantity] = useState(1)
  /**
   * I'm using a custom context for this app. This part probably isn't necessary for this library's API.
   */
  const { addVariantToCart, client } = useContext(StoreContext)

  const productVariant =
    client.product.helpers.variantForOptions(product, variant) || variant
  const [available, setAvailable] = useState(productVariant.availableForSale)

  useEffect(() => {
    // this is messy...should probably change it.
    const checkAvailability = (productId: string) => {
      client.product
        .fetch(productId)
        .then((fetchedProduct: ShopifyBuy.Product) => {
          // this checks the currently selected variant for availability
          const result = fetchedProduct.variants.find(
            variant => variant.id === productVariant.shopifyId
          )
          if (result) {
            setAvailable(result.available)
          }
        })
    }
    if (shopifyId) checkAvailability(shopifyId)
  }, [client.product, productVariant, shopifyId])

  /**
   * A function passed to your quantity selection Input.
   *
   * @example
   * ```jsx
   * <input onChange={handleQuantityChange} />
   * ```
   */
  const handleQuantityChange = useCallback(({ target }) => {
    setQuantity(Number(target.value))
  }, [])

  const handleOptionChange = useCallback(
    (optionIndex: number, value: string) => {
      if (!variant) return
      const { selectedOptions = [] } = variant
      // @ts-ignore
      const currentOptions = [...selectedOptions]

      currentOptions[optionIndex] = {
        ...currentOptions[optionIndex],
        value,
      }

      const selectedVariant = find(
        variants,
        ({ selectedOptions }: ShopifyProduct) =>
          isEqual(currentOptions, selectedOptions)
      )

      // return

      setVariant(selectedVariant)
    },
    [variant, variants]
  )

  const handleAddToCart = useCallback(() => {
    addVariantToCart(productVariant.shopifyId, quantity)
  }, [addVariantToCart, productVariant.shopifyId, quantity])

  /*
  Using this in conjunction with a select input for variants
  can cause a bug where the buy button is disabled, this
  happens when only one variant is available and it's not the
  first one in the dropdown list. I didn't feel like putting
  in time to fix this since its an edge case and most people
  wouldn't want to use dropdown styled selector anyways -
  at least if the have a sense for good design lol.
  */
  const checkDisabled = (name, value) => {
    const match = find(variants, {
      selectedOptions: [
        {
          name: name,
          value: value,
        },
      ],
    })
    if (match === undefined) return true
    if (match?.availableForSale === true) return false
    return true
  }

  const price = Intl.NumberFormat(undefined, {
    currency: minVariantPrice?.currencyCode ?? 'USD',
    minimumFractionDigits: 0,
    style: 'currency',
  }).format(Number(variant?.price ?? 0))

  // I use this to let my image gallery know which image to show when I change variants
  const variantImageId = variant?.image?.id

  return {
    variant,
    quantity,
    price,
    handleOptionChange,
    checkDisabled,
    handleQuantityChange,
    handleAddToCart,
    available,
    variantImageId,
  }
}

I definitely see a use for this hook, but the goal of gatsby-theme-shopify-manager is to be more of a data theme, and the hook you're describing is more presentation logic. Because storefronts are widely varied in what they need to do within their product forms, I think it would be best to add a useProductForm into a separate package that consumes gastby-theme-shopify-manager.

@nandorojo When you copy and redistribute code under the MIT license you're also required to satisfy the conditions of the MIT license. /cc @AlexanerProd

@nandorojo When you copy and redistribute code under the MIT license you're also required to satisfy the conditions of the MIT license. /cc @AlexanderProd


[13pt] Add dynamic pathing for output files

gms_run_unit.sh (and its children) put files in data/output docker mount folders instead of the /output docker mount folders. This resulted in outputs not going to the new data/outputs_fim_share_maas folder.
All code (including tools) will need to be reviewed as it is suspected that this exists in other places as well.

Replaced by issue 813 Change all phrases of "data/outputs" to "/outputs"


Add Express.js jesting section.

Summary
Added an article to show how to use jest to test an Express.js app.

Test plan
Just updated the documentation. No tests required.

Codecov Report

Merging #6879 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6879   +/-   ##
=======================================
  Coverage   66.98%   66.98%
=======================================
  Files         250      250
  Lines       10358    10358
  Branches        3        4    +1
=======================================
  Hits         6938     6938
  Misses       3419     3419
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432937b...c9a4ff2. Read the comment docs.


Support of accounting via Radius?

HI, is any plans for adding radius accounting support?

I marked another similar ticket as a feature request and I'm trying to find the most requested features of this project to announce. This ticket is a duplicate of #101 . Please thumbs up there if you want this implemented.


Kconfig WIFI_AIROC should not depend on infineon SOC family selection

Describe the bug
Murata manufactures the 1YN module which includes both WiFi and BT modules. The module hosts an Infineon CYW43439 processor and this module can comunicate via UART (BT) and SDIO (WiFi) with a host processor thus offloading the main processor in regards of networking.
It is not possible to select the following because of wrong Kconfig rules:
CONFIG_NETWORKING=y
CONFIG_WIFI=y
CONFIG_WIFI_AIROC=y
CONFIG_CYW43439=y
CONFIG_CYW43439_MURATA_1YN=y
CONFIG_WIFI_OFFLOAD=y
CONFIG_NET_OFFLOAD=y

I am using a STM32U5 (stm32u5a9xx) processor as a SoC.
I am testing on the main branch

To Reproduce
dts:
/dts-v1/;
#include <st/u5/stm32u5a9Xj.dtsi>
#include <st/u5/stm32u5a9njhxq-pinctrl.dtsi>
#include <zephyr/dt-bindings/input/input-event-codes.h>

/ {
	model = "Board module";
	compatible = "st,stm32u5a9j_dk";

};

&sdmmc1 {
	pinctrl-0 = <&sdmmc1_d0_pc8 &sdmmc1_d1_pc9
		&sdmmc1_d2_pc10 &sdmmc1_d3_pc11
		&sdmmc1_d4_pb8 &sdmmc1_ck_pc12
		&sdmmc1_cmd_pd2>;
	pinctrl-names = "default";
	status = "okay";

	/* Wifi configuration */
	airoc-wifi {
		status = "okay";
		compatible = "infineon,airoc-wifi", "infineon,airoc-wifi-sdio";

		/* Wi-Fi control gpios */
		wifi-reg-on-gpios    = <&gpioi 12 GPIO_ACTIVE_HIGH>;
		wifi-host-wake-gpios = <&gpioi 14 GPIO_ACTIVE_HIGH>;
	};

};

Steps to reproduce the behavior:

west build -b stm32u5a9j_dk -t menuconfig
See error

Expected behavior
It should include the necessary drivers in order to communicate with the 1YN module via SDIO (Wifi).
Impact
It's not possible to use a 1YN module connected to a host processor which is different than an Infieon chip.
Logs and console output
Loading Zephyr default modules (Zephyr base (cached)).
-- Application: /home/user/projects/board/board_sw_workspace/board_sw/app
-- CMake version: 3.22.1
-- Cache files will be written to: /home/user/.cache/zephyr
-- Zephyr version: 3.7.99 (/home/user/projects/board/board_sw_workspace/zephyr)
-- Found west (found suitable version "0.14.0", minimum required is "0.14.0")
-- Board: board1, qualifiers: stm32u5a9xx
-- Found host-tools: zephyr 0.16.8 (/home/user/zephyr-sdk-0.16.8)
-- Found toolchain: zephyr 0.16.8 (/home/user/zephyr-sdk-0.16.8)
-- Found BOARD.dts: /home/user/projects/board/board_sw_workspace/board_sw/app/boards/tinv/board1/board1.dts
-- Generated zephyr.dts: /home/user/projects/board/board_sw_workspace/board_sw/app/build/zephyr/zephyr.dts
-- Generated devicetree_generated.h: /home/user/projects/board/board_sw_workspace/board_sw/app/build/zephyr/include/generated/zephyr/devicetree_generated.h
-- Including generated dts.cmake file: /home/user/projects/board/board_sw_workspace/board_sw/app/build/zephyr/dts.cmake
Parsing /home/user/projects/board/board_sw_workspace/board_sw/app/Kconfig
Loaded configuration '/home/user/projects/board/board_sw_workspace/board_sw/app/build/zephyr/.config'

warning: USE_INFINEON_ABSTRACTION_RTOS (defined at modules/hal_infineon/Kconfig:80, modules/hal_infineon/Kconfig:80) has direct dependencies SOC_FAMILY_INFINEON_CAT1 || SOC_FAMILY_PSOC6_LEGACY || ((SOC_FAMILY_INFINEON_CAT1 || SOC_FAMILY_PSOC6_LEGACY) && 0) with value n, but is currently being y-selected by the following symbols:
 - WIFI_AIROC (defined at drivers/wifi/infineon/Kconfig.airoc:5), with value y, direct dependencies DT_HAS_INFINEON_AIROC_WIFI_ENABLED && WIFI (value: y), and select condition DT_HAS_INFINEON_AIROC_WIFI_ENABLED && WIFI (value: y)

error: Aborting due to Kconfig warnings

CMake Error at /home/user/projects/board/board_sw_workspace/zephyr/cmake/modules/kconfig.cmake:389 (message):
  command failed with return code: 1
Call Stack (most recent call first):
  /home/user/projects/board/board_sw_workspace/zephyr/cmake/modules/zephyr_default.cmake:132 (include)
  /home/user/projects/board/board_sw_workspace/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include)
  /home/user/projects/board/board_sw_workspace/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:97 (include_boilerplate)
  CMakeLists.txt:12 (find_package)

Environment:

OS: Ubuntu
Zephyr SDK 0.16.8
Latest main branch

Additional context

We have filed an internal ticket to address this and should have a fix up in the next 24 hours. We had previously fixed this, but some MR regressed it. We are also going to develop an internal CI test to make sure future regressions don't occur or are detected ASAP.

Hi @ivanwagner ,

I prepared PR https://github.com/zephyrproject-rtos/zephyr/pull/77039 with fix.
Also please refer to https://github.com/zephyrproject-rtos/zephyr/blob/main/boards/infineon/cy8cproto_062_4343w/Kconfig.defconfig to check what addition Kconfig need for AIROC WIFI (NET_L2_ETHERNET, HEAP_MEM_POOL_ADD_SIZE_BOARD)

Also notice, that AIROC driver requires SDHC driver for SDIO communication, currently Zephyr doesn't support this driver for STM32 platforms (see https://github.com/zephyrproject-rtos/zephyr/tree/main/drivers/sdhc).
Regards,
Nazar

Hi @ifyall and @npal-cy, thank you for the prompt reply.


Parsed response is displaying the raw response doubled

For example, the following raw response:
+------------------------------------------------------------------------------------------------------------------------------+
| name                                                                                |
+------------------------------------------------------------------------------------------------------------------------------+
| "×××× 120x180 ×¡"×, 4A4"                                                                                |
+------------------------------------------------------------------------------------------------------------------------------+
1 rows

Hi,
Which version of the app are you using right now? It was fixed and released yesterday.

Duplicate of the #778


Force compose stack on a specific node

Use Case: Using Portainer at Home
Have you reviewed our technical documentation and knowledge base? Yes

Question:
Is there a way to force the deployment of a compose stack via portainer API (type 2 - method string) on a specific node (host) in the swarm?
I don't see any option to do that, and since the docker-compose doesn't accept "deploy" configuration, I don't know how to do that.
Thank you for your help!

@gbozzetti
You will need to use placement constraints.  Please review documentation here:  https://docs.docker.com/engine/swarm/services/#placement-constraints
Thanks!

Hi @tamarahenson
thank you for your feedback, but I'm afraid your solution doesn't work because via the api endpoint /stack by using the type 2 (compose stack not swarm stack) the containers are deployed not as stacks/services but just as normal containers, so all the placement constraints configurations are ignored.


Fix polyfit fail on deficient rank

[x] Closes #4190
[x] Tests added
[x] Passes isort -rc . && black . && mypy . && flake8
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

Fixes #4190. In cases where the input matrix had a deficient rank (matrix rank != order) because of the number of NaN values, polyfit would fail, simply because numpy's lstsq returned an empty array for the residuals (instead of a size 1 array). This fixes the problem by catching the case and returning np.nan instead.
The other point in the issue was that RankWarning is also not raised in that case. That was due to the fact that da.polyfit was computing the rank from the coordinate (Vandermonde) matrix, instead of the masked data. Thus, is a given line has too many NaN values, its deficient rank was not detected. I added a test and warning at all places where a rank is computed (5 different lines). Also, to match np.polyfit behaviour of no warning when full=True, I changed the warning filters using a context manager, ignoring the RankWarning in that case. Overall, it feels a bi ugly because of the duplicated code and it will print the warning for every line of an array that has a deficient rank, which can be a lot...

Overall, it feels a bi ugly because of the duplicated code

Looks fine to me.

and it will print the warning for every line of an array that has a deficient rank, which can be a lot...

That could be annoying as a user. This happens in results = da.apply_along_axis(nputils._nanpolyfit_1d, ...), right? Can you use a warnings.simplefilter("once") so the error is only issued once - something along the lines of:
with warnings.catch_warnings():
    warnings.simplefilter("once", np.RankWarning)
    results = da.apply_along_axis(
        nputils._nanpolyfit_1d,
        ...
    )

I think this also warrants tests and a whats-new entry.

So while adding tests, I realized there were more bugs concerning deficient rank matrices and full=True output. I believe I fixed all I could find.
However, I was not able to reduce the number of warnings for the case using dask : the computation occurs outside of the catch_warnings() context...
Also, there is a bug in the dask.array.linalg.lstsq output (see issue dask/dask#6192), so if full=True we must use  skipna=True with dask.  Same when rank != order (deficient rank), dask.array.linalg.lstsq will fail, so we work around by using our (slower) nan-skipping method.

Pity that the dask warnings are not caught but I guess there's not much we can do about that.
Does this now work for the originally posted issue? Could you add it as a test?

@mathause Fixed the tests to catch the warning and added a case for the specific of the issue : too many nans causing a rank deficiency.

thanks @aulemahal!


fix - Fix #68

This changes smart merge to be more conservative in certain cases (child is missing include/exclude).

Codecov Report

Merging #69 into master will decrease coverage by -0.48%.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   95.76%   95.28%   -0.48%
==========================================
  Files           4        4
  Lines         189      191       +2
  Branches       61       62       +1
==========================================
+ Hits          181      182       +1
- Misses          8        9       +1

Impacted Files
Coverage Δ

src/join-arrays-smart.js
93.24% <100%> (-1.21%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf05fae...bb521ef. Read the comment docs.


V3 relatedness

A few things to consider in this PR:
First, do we want to change infer_families signature to take expressions instead of columns, that would mean the following changes to params:

Remove relationship_ht
i_col: str = 'i' => i_expr: hl.expr.StringExpression
j_col: str = 'j' => jexpr: hl.expr.StringExpression
 relationship_col: str = 'relationship' => relationship_expr: hl.expr.StringExpression

Second, do we want to keep duplicated_samples as a parameter of infer_families ?
We could simply return all trios including duplicates and let it up to the user to filter dups first if he wants to?
Third, in get_relationship_expr, there are two thresholds that are a little annoying because they don't really make sense: The min part of ibd1_0_thresholds and the max part of ibd2_100_thresholds. These are here because of how Hail's pc_relate does output weird low/high values in certain corner cases. Below are plots showing this from (gs://gnomad/sample_qc/v3_genomes_sample_qc.ipynb).

 Now we can leave as is, remove these values and just treat these samples as duplicates (at least for syndip they are!) despite the weird values.

Adding one more item for thoughts: Should filter_duplicate_samples be moved from sample_qc.py to relatedness.py ?

Thanks for writing up all these functions! Overall looks good, I just had to make a few edits in order to get things to run and we'll want to start thinking about how to extend it past just trios.
1-Yes, i think it would make more sense to have infer_families take expressions instead of columns
2-Thinking parameter of whether or not to keep duplicated_samples for infer_families would make sense?
3-Not sure i understand, but for now think keeping the ibd1_0_thresholds and the max part of ibd2_100_thresholds makes sense
4- Should filter_duplicate_samples be moved from sample_qc.py to relatedness.py? i think it should be moved, i got confused on where things were coming from and went looking for it

Thanks for writing up all these functions! Overall looks good, I just had to make a few edits in order to get things to run and we'll want to start thinking about how to extend it past just trios.
1-Yes, i think it would make more sense to have infer_families take expressions instead of columns
2-Thinking parameter of whether or not to keep duplicated_samples for infer_families would make sense?
3-Not sure i understand, but for now think keeping the ibd1_0_thresholds and the max part of ibd2_100_thresholds makes sense
4- Should filter_duplicate_samples be moved from sample_qc.py to relatedness.py? i think it should be moved, i got confused on where things were coming from and went looking for it

So regarding (3), the weird thing with having a min on IBD1_0_threshold is that conceptually the 0 is for no IBD1 and hence there is no minimum to it; as in there is no sample pair that shares less than 0 IBD1 segments. Same for the max boundary.... If you don't mind taking a quick other look at this question and at the plots it'd be great!

All right @klaricch, I went through the comments and just generally took a good look at the module.
The main  thing is streamlining the flow. It now goes:

annotate pc_relate results with get_relationship_expr
get_duplicated_samples
get_duplicate_samples_ht
infer_families

The output from one is naturally an  argument to the next. I ended up keeping the HT / cols as str rather than expr for most parts as it allows for in/output flow with defaults.
I've also made sure that everything works with that clunky struct in the i, j cols of the pc_relate output. No need to  worry about this anymore: it can just go through the pipeline and eventually during infer_family will be cast to str if it is a struct since Pedigree only takes str.
As a note, I didn't really find any better way to handle the different levels of certainty w.r.t. relationships (e.g. parent/offspring is a first degree relative). I think for now this is fine and if needs be we can add more logic when the time comes.

Note that it'd be great if you can  still take a look at my previous comment regarding (3)

I think it's fine to keep as is. Would it make sense to add the plotting code somewhere showing the threshold set by the user so they can easily visualize where they put the cutoffs? I don't know how much this will vary according to the dataset, I don't get any weird values for ibd1, ibd2 but i'm not using pc_relate.

Yes, we should have plotting code available, but I think this is outside the scope of this PR.


HBASE-27857 Fix timeout exception handling in HBaseClassTestRule

HBaseClassTestRule applies a timeout and a system exit rule to tests. The timeout rule throws an exception if it hits the timeout threshold. Since the timeout rule is applied after the system exit rule, the system exit rule does not see the exception and does not re-enable the system exit behavior which can cause maven to hang on some tests.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  7s
the patch passed

+1 :green_heart:
compile
0m 16s
the patch passed

+1 :green_heart:
javac
0m 16s
the patch passed

+1 :green_heart:
shadedjars
4m 49s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 15s
hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 49s
hbase-common in the patch passed.

12m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5231

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1e83cb88cae7 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5cea8112fd

Default Java
Temurin-1.8.0_352-b08

mvninstall
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-jdk8-hadoop3-check/output/branch-mvninstall-root.txt

compile
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-jdk8-hadoop3-check/output/branch-compile-hbase-common.txt

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-jdk8-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-jdk8-hadoop3-check/output/branch-javadoc-hbase-common.txt

javadoc
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-common.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/testReport/

Max. process+thread count
162 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 16s
master passed

+1 :green_heart:
compile
0m 50s
master passed

+1 :green_heart:
checkstyle
0m 23s
master passed

+1 :green_heart:
spotless
1m  6s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 46s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  9s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
0m 20s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m  1s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 58s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 53s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

47m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5231

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 7f65005089fd 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5cea8112fd

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
85 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Mind explain a bit more? IIRC, the SystemExitRule is to forbid System.exit call, so what is actual problem here?

Mind explain a bit more? IIRC, the SystemExitRule is to forbid System.exit call, so what is actual problem here?

Yes, the SystemExitRule is supposed to forbid the System.exit call while a test is running so that the various test servers running in the surefire forked jvm don't cause it to exit before a test has finished IIUC. The SystemExitRule will restore the normal System.exit behaviour when the test completes. The problem is, if a test times out, the test doesn't actually complete. The forked jvm really does need to exit but the SystemExitRule hasn't restored System.exit so it can't.
Note that the timeout exception originates in the timeout rule part of HBaseClassTestRule. The timeout rule actually runs the test method in a separate thread in a Future with a timeout value.
The change in this PR applies the systemExitRule first so when the timeout rule throws an exception it will go through the try...finally block in the systemExitRule which restores the normal System.exit and the forked jvm can exit normally when it needs to.
Without this change, you can see that org.apache.hadoop.hbase.TestSecurityManager shows up in the stacktrace if a test times out:
Created at 2023-04-27T15:51:58.947
org.apache.hadoop.hbase.SystemExitRule$SystemExitInTestException
        at org.apache.hadoop.hbase.TestSecurityManager.checkExit(TestSecurityManager.java:32)
        at java.base/java.lang.Runtime.exit(Runtime.java:114)
        at java.base/java.lang.System.exit(System.java:1752)
        at org.apache.maven.surefire.booter.ForkedBooter.acknowledgedExit(ForkedBooter.java:381)
        at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:178)
        at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 22s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 48s
master passed

+1 :green_heart:
compile
0m 14s
master passed

+1 :green_heart:
shadedjars
4m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 48s
the patch passed

+1 :green_heart:
compile
0m 14s
the patch passed

+1 :green_heart:
javac
0m 14s
the patch passed

+1 :green_heart:
shadedjars
4m 39s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 41s
hbase-common in the patch passed.

18m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5231

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dbfeed27a172 5.4.0-1099-aws #107~18.04.1-Ubuntu SMP Fri Mar 17 16:49:05 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e343584b50

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/2/testReport/

Max. process+thread count
163 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/2/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 16s
master passed

+1 :green_heart:
compile
0m 32s
master passed

+1 :green_heart:
checkstyle
0m 15s
master passed

+1 :green_heart:
spotless
0m 41s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 32s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 12s
the patch passed

+1 :green_heart:
compile
0m 32s
the patch passed

+1 :green_heart:
javac
0m 32s
the patch passed

+1 :green_heart:
checkstyle
0m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m  1s
Patch does not cause any errors with Hadoop 3.2.4 3.3.4.

+1 :green_heart:
spotless
0m 41s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m  9s
The patch does not generate ASF License warnings.

30m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5231

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux cdc6d774ffa7 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / e343584b50

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-common U: hbase-common

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5231/2/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Support JDK9 JEP 238: Multi-Release JAR Files

We're looking to adopt JDK9 rather early in order to provide Akka users additional performance by using the new fences and var handle APIs etc.
In order to manage that as a clean transition and not complete fork of Akka we'll need Multi-Release JARs that are coming in in JDK9: http://openjdk.java.net/jeps/238
It is rather simple AFAICS and boils down to putting classes under META-INF if they are meant to be "only jdk9" etc:
jar root
  - A.class
  - B.class
  - C.class
  - D.class
  - META-INF
     - versions
        - 9
           - A.class
           - B.class

Is this something you have looked at or not yet, if not yet and not planning to I'm willing to help out (work on it, may need some hints).
Do you think this is something that would fit well to provide in sbt itself and not as a plugin?
I thought it would be good to provide this in sbt itself since it's a JDK thing - WDYT?

Hmm... I guess actually it may relate more to the packaging plugin and not sbt itself hm WDYT @eed3si9n ?

The thing that i can say 2.12 and those sources only are used in 2.12.

https://github.com/sbt/sbt/pull/1799

.. and there @eed3si9n points to crossPaths and crossTarget. That should start pointing you to the right places.

Ok thanks, will poke around it on airports then 👍

I think this would be great @ktoso. Glad to hear you're working on it.

Status update: not currently working on it, will report back if on it.

Status update, we'll definitely need it so will look into it I guess

Can this feature be utilised for cross building Scala as well?

I don't think so, it's hardcoded to know about JDK versions, nothing else. It can handle /META-INF/versions/9, /META-INF/versions/10 etc, but there's no way to smuggle in scala versions there AFAICS

That's a pity.

It's something we could perhaps bring up during our discussions with them - @retronym FYI.
I guess they did the minimal thing they needed for 9, rather than doing a full API around it since time pressure to ship 9.

Blog about how to configure this with Maven.

I have done so in a strawman proposal for Akka https://github.com/ktoso/akka-streams-jdk9-strawman-mvn :)

I'm working on it FYI @retronym @dwijnand @eed3si9n
Starting as a plugin: https://github.com/sbt/sbt-multi-release-jar
I hope to have it complete by the end of this week. Fingers crossed there won't be any roadblocks to uncover.


added fix for navbar tests

What is the change?
fix tests for navbar (#164)
Is it bug?
No

Steps to repro
Expected
Actual

*Dev Tested?

[x] Yes
[ ] No

Tested on
NodeJs environment
Before / After Change Screenshots

Can you also add before and after changes for test coverage?

Thank for improving the test coverage and integration of remix stub


Change the environment diff algorithm to support removed keys

A work in progress to support unset in hooks and propagate those to subsequent hooks and phases. The primary use case for this being AWS credentials stored in environment variables.
Fixes #1471

Tested this with a local agent:

I felt like I had already done this, or something like it. Turns out I was thinking of https://github.com/buildkite/agent/pull/1232 which allowed hooks to introduce empty environment variables. A different facet of the same category of problems, I guess.


How to dynamically select a function based on user input

For example, there are 100 interfaces in my database. I can't put them all into functions at once. Instead, I need to match the most likely 3 interfaces each time based on the user's question.

I have some ideas but I'll give other researchers a chance to take a look.

For some inspiration... https://gorilla.cs.berkeley.edu/ :D

This is a common problem in production. Solvable. Low-hanging fruits for researchers.


Added authentication skip if config is empty

This allows the client to skip the login screen if auth items is empty (which implies that the authentication data comes from cookies)

👍


Can't get value from input in the last slide, if "loop: true"

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 4.2.2

Platform/Target and Browser Versions: Chrome.

Live Link or JSFiddle/Codepen or website with issue: https://codepen.io/ahmadzakiy/pen/mjxEbY

Problem
I make 5 slides and for the last slide I put the form (input email and button), problem comes when I'll try to get the input's value, Events works but the value is empty, if I put the form in slide 1 or 2 or 3 or in config "loop" is set false, I can get the value.
Thank you.

[UPDATE]
After inspecting the DOM, I think the problem where I can't get the value from the input is because, when you set "loop: true" swiperJS will duplicate the first and the last slide, so there will be 2 first slides and 2 last slides, render at the DOM and if you put "Input" at those slides and try to select "Input" with the selector, it will never get the value.
My solution, for now, is to put the "input" in the second slides at the code, and then set back two times so that will be the last side in the view. what I custom at swipper.js are:
set back slide two times: second slides will be last slides
line 4993: var $bullet = bullets.eq(current - 2);
set clickable pagination
line 5133: swiper.slideTo(index + 2);

Or do it right https://codepen.io/anon/pen/PByxQQ


walkWithIndex

I ran into the need for walkWithIndex, would you like a PR for this?

Hey Ryan, if you look at the signature for walk you'll see that it already provides the index
walk : Array2D a, state, WalkOptions *, (state, a, Index -> state) -> state

In many cases where List has a WithIndex version I've opted for providing the index by default, since it's commonly helpful in this context. This is probably something where hosting the docs (#1) will make things more clear.
Does that make sense?

@mulias awesome, I missed that. I just looked at the name. Thanks!


Cannot fetch bundles from ejabberd

When my account is on prosody and their account is on ejabberd 16.09, I cannot fetch their device bundle, because the iq result only arrives 1 sec after the timeout. This is true with timeout 10 secs as well as 50 or 60 secs. Strangely enough fetching device lists works (same procedure, only difference I spotted is missing "max_items=1" in the query. Fetching bundles from prosody <-> prosody works (tested on one server).
I'm not sure, if this is an upstream issue of smack, prosody or ejabberd or just a faulty configuration. Maybe @Flowdalic has heard of something like this/has an idea how to debug this?

I observed, that bundles only arrive, after another iq was sent to the server.
So I send the first iq (id 1) and wait for the response, nothing happens.
If I send another iq (id 2) to the server, a response for the first iq (id 1) arrives.
This is also true, if I send iq 1 to ejabberd, iq 2 to prosody and again iq 3 to ejabberd.
After sending iq 3 to ejabberd, response 1 arrives. So this is highly likely to be an ejabberd bug.

I created a ejabberd bug report: https://github.com/processone/ejabberd/issues/1710

May it worth considering to send another small iq to the server as a workaround?
Ask @Flowdalic about this...

I tried to reproduce the issue by fetching the bundle from ejabberd using conversations on home.zom.im.
It took a long time (~80 seconds), but the bundles did arrive.
This might be because of other iq requests being sent though...

May it worth considering to send another small iq to the server with every bundle iq as a workaround?

I'd usually have a policy to not implement workarounds for broken XMPP implementations in Smack. They usually cause more trouble (more code to maintain) and decrease the pressure that those broken implementations get fixed.
That is, if we are really talking about a non-Smack issue here.

Yeah, I guess its just my server installation.

Reopen: https://community.igniterealtime.org/thread/60891#265181

I remembered where I say this behavior and what is likely causing this too: Whenever you perform a blocking operation in a synchronous IQ handler. Then the connections incoming processing chain will also be blocked, until the operation times out, which will also cause the dammed incoming stanzas to get processed again (which will make them appear in Smack's debugger).
Let's see if we can find that piece of code that is responsible for this.

Where are those bundles fetched?

@Flowdalic The Bundles are fetched in OmemoService.fetchBundle(). I cannot see anything, which might block :/

this was fixed a while ago.


import vue-material css file failed

as the demo code you set
import Vue from 'vue'
import VueMaterial from 'vue-material'
import 'vue-material/dist/vue-material.css'

and the webpack is set  like below
  module: {
    preLoaders: [

    ],
    loaders: [
      {
      test: /\.css$/,
       include: /node_modules/,
       loader: 'style-loader!css-loader'
      }
    ]
  },

but it always shows an error like
Module not found: Error: Cannot resolve 'file' or 'directory' /Users/admin/Documents/learn/vue/vue2-test/node_modules/vue-material/dist/vue-material.js/dist/vue-material.css

This is a problem with your webpack configuration, not vue-material. Can you post the whole thing? The fact that it's searching for the file at node_modules/vue-material/dist/vue-material.js/dist/vue-material.css instead of node_modules/vue-material/dist/vue-material.css  means something wonky is going on.

This is a problem with your webpack configuration, not vue-material. Can you post the whole thing? The fact that it's searching for the file at node_modules/vue-material/dist/vue-material.js/dist/vue-material.css instead of node_modules/vue-material/dist/vue-material.css  means something wonky is going on.

fixed! thanks

fixed! thanks


Add version check for WordPress version less than 4.7.0

Sage checks if the version of PHP installed is less than 5.6. However, if the installed version of WordPress is less than 4.7, a fatal error is thrown. This check produces a more friendly "Sage Style" error instead of a boring default php fatal error.
See: https://discourse.roots.io/t/undefined-function-app-get-theme-file-path/8455

@JulienMelissas

Awesome, thanks 👏


Add support for initContainers

This allows the usage of initContainers to fix possible filesystem permission issues

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much for the contribution @syepes!

Hey @syepes, I'd like to merge the PR but there are some failing CI checks. Could you please run helm-docs to update README?


Resolved Page not found

📥 Pull Request
Description
One problem in sliding window was with wrong url
Fixes #177
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar please look into it


Error Handling (Specifically ProgrammingError handling)

Driver version

redshift_connector==2.0.902
Problem description

Everything is working like expected so this is not a "this is terrible" post.  I'm trying to figure out how to handle errors when trying to execute a statement.  The statement in question is "CREATE USER ____ WITH PASSWORD ____" where I am connected to a redshift cluster.  If the user isn't there, all is great!  When the user is there, I need to handle that error.  I just can't seem to figure out error handling in that response.  I notice that there is a returned class (`<class 'redshift_connector.error.ProgrammingError'>) and this is totally fine.  I just want to know how I can handle those errors in a programmatic way.  Is there any documentation on this?

You can do as below:
try:
          with con.cursor() as cursor:
              cursor.execute("drop table if exists t1")
      except redshift_connector.ProgrammingError:
          // ProgrammingError and handle the error

You can find more in the "test" folder. Above snippet is from test/integration/test_query.py
Hope this helps.

Hi @mattdavis17 -- thank you for your feedback. I hope iggarish's response above addressed your question. Please let me know if any more information is needed. We will work to add documentation about this topic.

We've added documentation to our readme regarding exceptions in  2.0.903.


Added warning when disabling editable_instance

Added warning when disabling editable_instance to prevent data loss. This fixes #17547
The warning is currently this:

It looks a bit odd.. Any suggestions?

There should be a period after "default". Also, I think "editable_instance" should be inside quotations, like in this comment.

Updated the warning, this looks better:

*instance

Thanks!


Missing tr1/unordered_map

Hi,
I am interested in your work.
After I clone your code, i notice that the file "tr/unordered_map" is missing"

tr/unordered_map is part of c++ standard library:
http://stackoverflow.com/questions/4511350/c-map-vs-unordered-map-vs-tr1-unordered-map-vs-ext-unordered-map
However, c++11 does not have it anymore:
https://cplusplusmusings.wordpress.com/2013/06/03/whats-up-with-tr1-and-c11-and-libc/
On Wed, Feb 8, 2017 at 4:37 AM, JiangYu<EMAIL_ADDRESS>wrote:

Hi,
I am interested in your work.
After I clone your code, i notice that the file "tr/unordered_map" is
missing"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/olga-perederieieva/TAsK/issues/1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKba9TQ1BwHzRDeclOlVEPCey2VssBGsks5raI_CgaJpZM4L5pZ6
.


Slurmqueue naming validation errors

Issue: Error when using hyphens in SlurmQueue names
AWS ParallelCluster Version

Tested on versions: 3.10 & 3.11

Description
When configuring a cluster with hyphens in the SlurmQueue names, the following error occurs:
Example Configuration snippet:
SlurmQueues:
  - Name: a10-medium
    JobExclusiveAllocation: true
    ComputeResources:
      - Name: a10-medium
        InstanceType: g5.12xlarge
        MinCount: 0
        MaxCount: 4
        Efa:
          Enabled: true

Error Message
{
  "configurationValidationErrors": [
    {
      "level": "ERROR",
      "type": "NameValidator",
      "message": "Invalid name 'a10-medium'. Name must begin with a letter and only contain lowercase letters, digits and hyphens."
    }
  ]
}

Expected Behavior
The configuration should allow hyphens in SlurmQueue names without producing a validation error.
Steps to Reproduce

Define a cluster configuration with a SlurmQueue name that includes hyphens (e.g., a10-medium).
Attempt to create the cluster.

Request
Is there any plan to adjust the validation rules to allow hyphens in SlurmQueue names, or should I follow a different naming convention?
Thanks!

Hi,
indeed your right, but even with the new update comment it errors

Hi @QuintenSchrevens
I added a10-medium as the Slurm and Compute resource Name in 3.10.0 and 3.11.1 cluster creation and didnt face any issue with validation that you see. I used pcluster create-cluster  CLI command.
Can you please mention how you are creating the cluster? Are you using CLI commands, PCUI, terraform, etc?


Use new prompt for QuestionAnswerTool

Required by #322
Purpose

This PR includes changes the prompt used in the QuestionAnswerTool to the main_prompt used in On Your Data.
The new prompt includes a mix of system, user and AI messages, instead of one single user message
The new prompt also includes an example to help the LLM, which can be configured on or off
For backwards compatibility, if the old prompt has been set in the config, then this will continue to be used, with no changes
Increase unit test coverage (not for streamlit)

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Run app and admin app locally
Ask questions from the frontend
Change the prompt in the Admin app

What to Check
New prompt is being used

Example has been disabled, can also see chat history

Can still set old prompt if required

Get review from Project Wednesday before merging

Putting in draft for now, to attempt to add few-shot example to the config


New pip release?

Seeing that 1.6.4 from Jan 25, 2022 is still the current version served by pip and there have been quite a few changes since then, I was wondering if there are any updates for a new pip release are planned. :)

I also am curious if this will get updated. :)

Hi, a lot of the commits made after the last release I'm currently unsure-of as in if they actually make a difference good or bad, hence I haven't yet made a stable release for. If you guys don't mind testing it out and seeing if you find any problems, it may speed up release. The main issues I'm concerned with atm is if there's any loss to support for any input/output bit depth or format combinations, and any speed or memory usage changes.

I can do some testing next week.
Anything a bit more specific to test?
I assumed, so far, input needed to be:
a. mod4
b. RGBS or RGBH
c. pc luma scale

With VSGAN, afair (I havent worked on it or used it in ages), it supports any combination of input format, so long as it wasnt YUV.

Okay, I tested compatibility only atm.:
input: RGB24, RGB27, RGB30, RGB36, RGB42, RGB48, RGBH, RGBS
2-3 different models per architecture with different scalings.
(for EGVSR. I only used: EGVSR_iter420000.pth)
tested with:
vsgan = ESRGAN(clip=clip,device="cuda")
=> no problems
vsgan = SwinIR(clip=clip,device="cuda")
=> no problem
vsgan = HAT(clip=clip,device="cuda")
=> no problem
vsgan = EGVSR(clip=clip,device="cuda")
=> broken, different colored and wrong output for the tested RGBXX inputs.

Ran a few speed comparisons with different ESRGAN models and the new one seems to be slightly faster (~1%) for normal models, but a bit faster (~7%) for compact models.
I didn't test EGVSR and the color changing depending on the input is also broken in the old version, but the output wasn't as broken. => EGSVR doesn't seem to work properly.


[7204] POST degree missing validations

Context
https://trello.com/c/TymIkYpu/7204-post-degree-missing-validation
Changes proposed in this pull request

Added validations to Degrees so that they are properly validated on POST and PUT
Refactored the Degrees pipeline a bit
Couple of other small tweaks

Guidance to review
Do the POST and PUT Degree endpoints validate as expected for uk and non_uk degrees.
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

The only issue I can see is that unmappable values are treated as empty from a validation point of view so the error isn't super helpful.

@stevehook You're right, when there are unmappable values the error messages aren't great. I'm going to split that into a separate ticket so we can get this one through.


feat(avatar): add focus styled examples

COMUI-2665

Hi @daragh-king-genesys,
Is this ok to go ahead? It will likely change again with the photo elements but for now?
Thanks,
Gillian


Adding R language support for function call split/join

Added sj#r#SplitFuncall which expands R function calls into one-line-per-argument style
Added sj#r#JoinFuncall which joins R function calls into one-line style
Added a few helpers for navigating visual selections which are used throughout to capture bounding parentheses
Added one really helpful function, sj#r#ReplaceMotionPreserveCursor, which walks the text to be replaced and the replacement text to try to figure out where the cursor should end up. At least for this simple case it works well to always keep your cursor on the same character that it was on before replacing the text. For more complicated rearrangements with insertions or deletions, it would probably require some extra features.
I don't know ruby, but I added in a test case stub file with comments itemizing some test cases that one could use if a ruby expert would like to take a stab at it.

I'm still learning vimscript - open to critique and pointers if there's room to improve the code.

Thanks @AndrewRadev. At this point I think I've addressed all of your comments. Please let me know if there's anything else you would like me to follow up on or if there was anything I missed.

You didn't add the documentation entry I mentioned, but I wrote it up myself -- it's not a big deal. I also found a bit of a bug in the case when the "retry at the end of the line" call would fail to join, the cursor wasn't being restored -- I applied a fix. With this, I think it's fine to merge :+1:


updated flash (<IP_ADDRESS>6)

@vitorgalvao Played around with the autopkg recipies and got this.
Works for me and seems to do the same thing as the old installer.
@andyli Maybe a derivative of this could help with flash-player for you also? At least, the appcast should be OK to reuse, assuming the two get updated at the same time.

@adidalal Stellar work!
@andyli Usually updates them all (don’t forget pepper-flash) at once so I’d say the appcast should be reusable, yes. Also, pepper-flash might also have a pkg inside its app.

Merged as 4214264d263c6d13ec3c36d832af03a1ed266aea.


opcode BEFORE_ASYNC_WITH causes compilation crash.

When compiling a personal project, I ran into this crash when compiling a module.
[411/663] pyee._trio
  label_0:
  {
    x = __pypperoni_IMPL_load_global(f, __consts_pyee__trio[98]);
    if (x == NULL) {
    f->f_lineno = 77;
    goto error;
    }
    Py_INCREF(x);
    PUSH(x);
  }
  label_2:
  {
    x = fastlocals[0];
    if (x == NULL) {
    PyErr_SetString(PyExc_UnboundLocalError, PyUnicode_AsUTF8(__consts_pyee__trio[99]) /* local variable 'self' referenced before assignment */);
    f->f_lineno = 77;
    goto error;
    }
    Py_INCREF(x);
    PUSH(x);
  }
  label_4:
  {
    x = __consts_pyee__trio[100]; /* '_nursery' */
    Py_INCREF(x);
    PUSH(x);
  }
  label_6:
  {
    x = Py_None;
    Py_INCREF(x);
    PUSH(x);
  }
  label_8:
  {
    v = NULL;
    u = __pypperoni_IMPL_call_func(&stack_pointer, 3, v);
    if (u == NULL) {
    f->f_lineno = 77;
    goto error;
    }
    PUSH(u);
  }
  label_10:
  x = POP();
  err = __pypperoni_IMPL_check_cond(x, &result);
  Py_DECREF(x);
  if (err != 0) {
  f->f_lineno = 77;
  goto error;
  }
  if (!result)
  {
    goto label_22;
  }
  label_12:
  {
    x = fastlocals[0];
    if (x == NULL) {
    PyErr_SetString(PyExc_UnboundLocalError, PyUnicode_AsUTF8(__consts_pyee__trio[101]) /* local variable 'self' referenced before assignment */);
    f->f_lineno = 78;
    goto error;
    }
    Py_INCREF(x);
    PUSH(x);
  }
  label_14:
  {
    v = TOP();
    x = PyObject_GetAttr(v, __consts_pyee__trio[102]);
    if (x == NULL) {
    f->f_lineno = 78;
    goto error;
    }
    Py_DECREF(v);
    SET_TOP(x);
  }
  label_16:
  {
    retval = POP();
    w = _PyAsyncGenValueWrapperNew(retval);
    Py_DECREF(retval);
    if (w == NULL) {
    retval = NULL;
    f->f_lineno = 78;
    goto error;
    }
    retval = w;
    *why = WHY_YIELD;
    f->f_lasti = 18;
    f->f_lineno = 78; /* in case of throw() */
    goto end;
  }
  label_18:
  {
    v = POP();
    Py_DECREF(v);
  }
  label_20:
  {
    goto label_66;
  }
  label_22:
  {
    x = fastlocals[0];
    if (x == NULL) {
    PyErr_SetString(PyExc_UnboundLocalError, PyUnicode_AsUTF8(__consts_pyee__trio[103]) /* local variable 'self' referenced before assignment */);
    f->f_lineno = 80;
    goto error;
    }
    Py_INCREF(x);
    PUSH(x);
  }
  label_24:
  {
    v = TOP();
    x = PyObject_GetAttr(v, __consts_pyee__trio[104]);
    if (x == NULL) {
    f->f_lineno = 80;
    goto error;
    }
    Py_DECREF(v);
    SET_TOP(x);
  }
  label_26:

 77           0 LOAD_GLOBAL              0 (getattr)
              2 LOAD_FAST                0 (self)
              4 LOAD_CONST               1 ('_nursery')
              6 LOAD_CONST               0 (None)
              8 CALL_FUNCTION            3
             10 POP_JUMP_IF_FALSE       22

 78          12 LOAD_FAST                0 (self)
             14 LOAD_ATTR                1 (_nursery)
             16 YIELD_VALUE
             18 POP_TOP
             20 JUMP_FORWARD            44 (to 66)

 80     >>   22 LOAD_FAST                0 (self)
             24 LOAD_ATTR                2 (_manager)
             26 BEFORE_ASYNC_WITH
             28 GET_AWAITABLE
             30 LOAD_CONST               0 (None)
             32 YIELD_FROM
             34 SETUP_ASYNC_WITH        18 (to 54)
             36 STORE_FAST               1 (nursery)

 81          38 LOAD_FAST                1 (nursery)
             40 LOAD_FAST                0 (self)
             42 STORE_ATTR               1 (_nursery)

 82          44 LOAD_FAST                0 (self)
             46 YIELD_VALUE
             48 POP_TOP
             50 POP_BLOCK
             52 LOAD_CONST               0 (None)
        >>   54 WITH_CLEANUP_START
             56 GET_AWAITABLE
             58 LOAD_CONST               0 (None)
             60 YIELD_FROM
             62 WITH_CLEANUP_FINISH
             64 END_FINALLY
        >>   66 LOAD_CONST               0 (None)
             68 RETURN_VALUE
Exception in threadTraceback (most recent call last):
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\cmake.py", line 170, in __worker
    self.__process_one(name, module)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\cmake.py", line 151, in __process_one
    module.generate_c_code(f, self.modules)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1445, in generate_c_code
    self.__gen_code(f, modname, modules, self.code, [], True)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1331, in __gen_code
    context = self.__handle_chunk(chunks[0], f, name, modules, codeobj, consts, [])
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1353, in __handle_chunk
    self.__handle_one_instr(codeobj, context, label, op, oparg, line)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 98, in __handle_one_instr
    self.handle_op(codeobj, context, label, op, oparg, line)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1005, in handle_op
    context._consts)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1331, in __gen_code
    context = self.__handle_chunk(chunks[0], f, name, modules, codeobj, consts, [])
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1353, in __handle_chunk
    self.__handle_one_instr(codeobj, context, label, op, oparg, line)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 98, in __handle_one_instr
    self.handle_op(codeobj, context, label, op, oparg, line)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1005, in handle_op
    context._consts)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1331, in __gen_code
    context = self.__handle_chunk(chunks[0], f, name, modules, codeobj, consts, [])
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1353, in __handle_chunk
    self.__handle_one_instr(codeobj, context, label, op, oparg, line)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 98, in __handle_one_instr
    self.handle_op(codeobj, context, label, op, oparg, line)
  File "E:\Misc-Projects\SixFlagsSeasonPassPrices\pypperoni\module.py", line 1318, in handle_op
    label))
ValueError: 52 (BEFORE_ASYNC_WITH) @ pyee._trio/.<module>_48.TrioEventEmitter_44.context/26

I take a look though the code, and this appears to be caused by BEFORE_ASYNC_WITH not having it's own definition in module.py.
GET_AWAITABLE actually appears to handle the BEFORE_ASYNC_WITH opcode, but because BEFORE_ASYNC_WITH is called before GET_AWAITABLE, it leads to this issue.

Can you provide a minimal source code example that reproduces the issue?

@loblao Apologies about the delay in responding to your comment.
I have attached a proof of concept project.
BugPOC.zip
When ran in CPython 3.6, it outputs:
Bug!
But Pypperoni throws an identical ValueError:
ValueError: 52 (BEFORE_ASYNC_WITH) @ bug/.<module>_34.triggerBug/4
It appears that this error is due to not implementing the opcodes for asynchronous context mangers to work correctly. Specifically, the opcode BEFORE_ASYNC_WITH is suppose to push the return of aenter, as well as aexit to the stack.

@loblao Apologies about the delay in responding to your comment.
I have attached a proof of concept project.
BugPOC.zip
When ran in CPython 3.6, it outputs:
Bug!
But Pypperoni throws an identical ValueError:
ValueError: 52 (BEFORE_ASYNC_WITH) @ bug/.<module>_34.triggerBug/4
It appears that this error is due to not implementing the opcodes for asynchronous context mangers to work correctly. Specifically, the opcode BEFORE_ASYNC_WITH is suppose to push the return of aenter, as well as aexit to the stack.

Remember to pull latest Python changes too. Your proof of concept is now 03-async in samples. Note that asyncio has never been properly tested on Pypperoni so bug reports are welcome.

Remember to pull latest Python changes too. Your proof of concept is now 03-async in samples. Note that asyncio has never been properly tested on Pypperoni so bug reports are welcome.

 The bug is fixed!
I can't wait to experiment with this now.
Thanks again.

 The bug is fixed!
I can't wait to experiment with this now.
Thanks again.


What about the "amr" claim

The "amr" claim appears in the id_token.   Not documented in this page.
Documentation for "amr" can be found here:
https://openid.net/specs/openid-connect-core-1_0.html#IDToken

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0cace34-34bf-32f7-c857-e4d71d535a77
Version Independent ID: cdbbc4ae-5894-da21-42d7-928b3674bbd1
Content: Microsoft identity platform ID tokens - Microsoft identity platform
Content Source: articles/active-directory/develop/id-tokens.md
Service: active-directory
Sub-service: develop
GitHub Login: @hpsin
Microsoft Alias: hirsin

@MattPeterson1 Thank you for the feedback!  We are investigating this and will get back to you shortly.

@MattPeterson1 That's a good catch!  This is a non exhaustive list of JWT claims that are in most id_tokens by default.  If we continue in the documentation to Access tokens, we'll see that amr is only present in v1.0 tokens:

"Only present in v1.0 tokens. Identifies how the subject of the token was authenticated. See the amr claim section for more details."

The amr claim section in turn gives us a more robust description along with a list of values and their descriptions:

Microsoft identities can authenticate in different ways, which may be relevant to your application. The amr claim is an array that can contain multiple items, such as ["mfa", "rsa", "pwd"], for an authentication that used both a password and the Authenticator app.

You can also see this if you look at the v1.0 sample token in jwt.ms, and then navigate to the Claims tab next to the amr claim type.

@MattPeterson1 Thank you again for pointing this out!  Readers looking for amr claim documentation can find it in the links mentioned above, so we are going to close this issue as resolved.  If you have any additional questions about the documentation, tag me in your reply and I'd be happy to continue the conversation.

Hi,
What are the replacements for amr and acr claims?
We have a need whereby the client needs to verify that the user has authenticated with MFA.
Kind regards,

@haneef95 Would you mind opening a new issue with this question?  It will help us with our tracking, as well as help other readers with the same question.  Thank you!


Addresses open question for ValkeyJSON rfc

Addressing open question in the RFC - We would set the config json.max-document-size to -1 by default , meaning the size of JSON key will be unlimited.
This is based on the observation that RedisJSON, a related project, does not have a built-in size limit, and the core data types in the Valkey system also do not have such a restriction.

Looks good.

@valkey-io/core-team Please approve if you have any concerns with this change to finalize the JSON RFC?

I notice after Madolson and BinBin approve, Vikctor update the json.max-document-size as 0, Can we confirm 0 is the correct default value?

I notice after Madolson and BinBin approve, Viktor update the json.max-document-size as 0, Can we confirm 0 is the correct default value?

Yeah, I think 0 is the right value.


⚠ Bofrost.at has degraded performance

In dc1a2a1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2362 ms

Resolved: Bofrost.at performance has improved in 52eea5f.


Add support to Prefect runtime processor type.

Is your feature request related to a problem? Please describe.
As mentioned by https://github.com/elyra-ai/elyra/issues/2258, it should be easy now to integrate new processor executor type into Elyra definition. This is just a tracker to support Prefect. Ideally, the implementation should be similar to Airflow considering the similarities between each other.
Describe the solution you'd like
A pipeline that supports Prefect runtime processor.
Describe alternatives you've considered
There is an alternative to create a generic pipeline with Prefect code, but it would be nice to have it built-in.

Is it possible to include runtimes as a plugin? So, we don't need to open requests like these. We could just maintain a separate elyra-<runtime_type> and if it is relevant, it can be incorporated in the future.

Is it possible to include runtimes as a plugin? So, we don't need to open requests like these. We could just maintain a separate elyra-<runtime_type> and if it is relevant, it can be incorporated in the future.

unfortunately we dont have the plumbing in place yet for a more modular way of including additional processor runtimes, this includes packaging (see in progress https://github.com/elyra-ai/elyra/pull/2259).
Makes sense to keep this open as an umbrella issue for adding support for prefect in elyra, we would be happy to help answer any questions or issues that come up and look forward to this contribution.