Time offset

I have been using Xteve and have successfully added m3u and xmltv data. Everything works great but I would like to alter the time for some channels. Ie  Channels like discovery.us have an east coast and west coast feed but only one set of data is provided in the guide xml.  The one in my time zone is correct but the one in the other is not so I would like to change the time offset for this one. I have noticed that when Xteve sets up a dummy guide it executes Create Dummy Guide:    Time offset -0500 - US: Dicovery (west) | HD.  I have figured out how to connect to connect to Xteve though API is there any way to send it a cmd to set this time offset to -0800?  Any help would be appreciated. Thanks!

No, there is no way to set a time offset. The times are taken unchanged from the source and the time and time zone from the computer are used for the Dummy.
If you are missing data you can take a look at zap2it (US only) or Schedules Direct.

No, there is no way to set a time offset. The times are taken unchanged from the source and the time and time zone from the computer are used for the Dummy.
If you are missing data you can take a look at zap2it (US only) or Schedules Direct.

I commented in #17 but it might be missed since that issue is closed so just commenting here too for greater visibility.
I just need to shift a couple of channels and tvg-shift in the M3U seems to be the recommended way of doing this in the documentation of most clients and providers. For example both Emby and my EPG source support tvg-shift but Xteve tries to handle this via the EPG xml.
Example: #EXTINF:-1 tvg-chno="1" tvg-id="Syfyplus1.uk" tvg-name="Syfy" tvg-logo="xxxx.jpg" group-title="Example" tvg-shift="-1",Syfy http://example.ts

As explained....It uses the time from your machine...Use the offset in your Media Player (If it has one)

My client doesn't support time offset... I'm using Plex. I need to offset the EPG data in the XML file upstream, and I'm trying to find the tools necessary to do that. I figured xteve would be the optimal place to do that in an automated fashion since it's passing that EPG data to Plex. If xteve doesn't do that, and there's not an intent to handle that (I presume many people are in this boat), since my IPTV provider handing me the EPG XML data doesn't have a way to set timezone (I'm trying to figure out if third part EPG providers like iptv-epg; maybe they provide a better way?) the only way I can think to overcome this is to build a custom script to go in and edit the utc codes in the XML file plex is reading from xteve based on channel offsets I could keep in another xml file... it's a hack, and a lot of work if there's already a way people are handling this... anyone have information I'm just ignorant of? or, can we get xteve to just handle this for us as part of its own development?

Time is set by the Machine that xTeVe is on. Any manipulation can be done that way.

Timezone manipulation on the machine I'm on is a non-starter for a number of reasons, again I expect this is an issue for many people. I'm running xteve and my plex server on my unraid machine, which is running other things needing correct time (could run xteve in a VM and bulk offset that way, but not going to do that); also I'm not entirely sure every channel's epg time shift would be the same. When browsing the channels from my provider I feel like one or two were an extra hour or more off relative to the mass of them, so per channel control would likely be necessary, and pushing to plex, again the time codes in epg xml it receives would be the only place to inject any shift, which basically leaves me with only a few options 1.) Write a script to modify the epg xml utc codes themselves 2.) Move away from plex to a dedicated IPTV client with per channel offset support (making xteve completely irrelevant to the solution) 3.) Obtain content through a non-iptv provider.
Option 1 is a fair bit of work for me, though not impossible, so I just haven't pursued it. Option 2 is a big fat maybe for me, but doesn't provide me the option of mixing the experience in with the rest of my media consumption handled through plex, and would require me to buy new hardware at each TV in my home. Option 3 is likely the best route for me... I only care about consuming a small portion of racing content which is harder to automate adding to my library through sonarr/sickbeard/ragetv etc, though it is available in other ways, and while it would be nice to have a live tv feel for the whole family it seems like it simply isn't reasonably possible to integrate into my current set of systems without a bit of work and/or money... If xteve or anyone else ever creates a method for modifying the epg data in the way I discussed I'll happily jump back to attempting to get IPTV integrated with my plex setup, but until then I think it might just be an experiment requiring too much of my time and/or money to warrant pursuit.

You could also fork xTeVe and re-code it some way to make EPG Offset possible. I can't see this being done by us for such a small audience.

@iammeuru, I made a branch of xTeVe that supports basic channel time offset / timeshifting.  I'm not 100% sure the best term to use, because timeshifting has traditionally meant any DVR which could record and play back at a different (non-live) time, whether buffered or stored on disk.  Regardless, I use the term "timeshift" to support the Tvg-shift attribute in the M3U files.  I then recalculate the EPG program start and stop times based upon the timeshift offset.
There isn't much error correcting in my code yet, as it assumes you are entering numbers and not random characters.  However, it seems to work for me and my testing when I use a single EPG source for both East Cost (GMT -4) and West Coast (GMT -7) programs.
I wrote this modification because it's useful to me and may be useful to others, but I'm not a native Go/GoLang programmer, so my code is very basic.  Please feel free to look over my changes and/or test my code.  The only other significant change is that I wanted to preserve the channel number from the M3U file instead of using a base channel that is incremented for each new channel.  I would like to make that a per-filter option, but for right now, I just made it a global change to test out for my purposes.
Hope that helps...

I know this is an old thread, but I faced this problem, so i thought I'd share my solution, and it's sort of [iammeuru}'s solution, but that doesn't work.  Plex ignores the offset in the EPG XML file and works solely on the timezone set while adding the tuner.  So I wrote a PS script that works channel by channel (for channels that need to change), with an offset, then changes the timestamp for start and finish in the xmltv file based on the offset for that channel.

takes a bit of manual configuration, but if the EPG says a show starts at 16:00, but it actually starts at 14:00, the script allows to amend the EPG, for that channel, to show srtatime as -2, or 14:00.  Or +.  Also tells xTeve to update once the work is done, so has to be run between the default EPG update in xTeve and the Plex import of the EPG.

@briansturrock - are you able to share the script?

sure - let me clean it up and document it and i'll dm it to you (if i can figure out how!)

great work @briansturrock - I'd love to see the code too, if possible?

Excellent. Many thanks for this.

From: briansturrock @.>
Sent: Wednesday, June 29, 2022 3:46:35 PM
To: xteve-project/xTeVe @.>
Cc: Simon D'Morias @.>; Mention @.>
Subject: Re: [xteve-project/xTeVe] Time offset (#205)
My xTeve runs on Windows Server Core, so I just have a task that runs this. I've updated it as well, so it also tells Plex to download the lastest available guide. so long as it runs after xTeve does its daily update it works fine.
epg_timezone_fix.txthttps://github.com/xteve-project/xTeVe/files/9011594/epg_timezone_fix.txt
.
—
Reply to this email directly, view it on GitHubhttps://github.com/xteve-project/xTeVe/issues/205#issuecomment-1170076418, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADBMOSDNHJDB6GCUBQTZKGTVRROUXANCNFSM4VWPAPMA.
You are receiving this because you were mentioned.Message ID: @.***>

It's important to figure out the offset from the Plex epg, as Plex tries to fix them based on the source xmltv, it's just that it for whatever reason (probably source data) it fails.  So it's not a simple matter of that channel is that timezone and I'm in this timezone, so it's a -5 offset, for example.  It won't be.  it might actually only be only -2 once Plex has tried, so you'll need to figure it out for each channel by watching the channel and seeing what's on and figuring out the offset you need.  Sometimes you see things like, "News at 6," so from the ACTUAL TZ offset (what 6 is in that TZ versus your own), you can figure out what offset you need to use for that channel - so that makes it easier.  You just need to shift it by x hours.

Thanks mate, really appreciate you sharing. My Plex server is running in a Docker container on a Linux server, and I definitely don’t have the skills to do the translation!

From: briansturrock @.>
Sent: Thursday, June 30, 2022 1:52:43 AM
To: xteve-project/xTeVe @.>
Cc: red-centre @.>; Comment @.>
Subject: Re: [xteve-project/xTeVe] Time offset (#205)
It's important to figure out the offset from the Plex epg, as Plex tries to fix them based on the source xmltv, it's just that it for whatever reason (probably source data) it fails. So it's not a simple matter of that channel is that timezone and I'm in this timezone, so it's a -5 offset, for example. It won't be. it might actually only be only -2 once Plex has tried, so you'll need to figure it out for each channel by watching the channel and seeing what's on and figuring out the offset you need. Sometimes you see things like, "News at 6," so from the ACTUAL TZ offset (what 6 is in that TZ versus your own), you can figure out what offset you need to use for that channel - so that makes it easier. You just need to shift it by x hours.
—
Reply to this email directly, view it on GitHubhttps://github.com/xteve-project/xTeVe/issues/205#issuecomment-1170159968, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AV4QXBFIZWYMSMETBX4RI2DVRRWMXANCNFSM4VWPAPMA.
You are receiving this because you commented.Message ID: @.***>

@briansturrock thank you for the file, i am trying to adapt this to my needs but i receive this error "Invoke-WebRequest : Locked [423]" when executing the following line:
Invoke-WebRequest -Uri $uri -Method POST -Body ($body|ConvertTo-Json) -ContentType "application/json" -UseBasicParsing
I have also a doubt, should i change something in this line? i don't have that file
$body = @{"cmd"="update.xmltv"}
This is the complete error:
Invoke-WebRequest : Locked [423]

Invoke-WebRequest -Uri $uri -Method POST -Body ($body|ConvertTo-Json) ...

  + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc
 eption
  + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand

Any thoughts will be apreciated, thanks


Regenerated API clients with Kiota

@baywet any idea why this line keeps jumping around? This is the third day in a row that the generation has moved this one particular line - it keeps jumping from above to below the import {BaseRequestBuilder, HttpMethod... line, and back again.
Closes #3344

I think this is a side effect from that change introduced by @koros and an another thenBy should be added in the ordering of things.
https://github.com/microsoft/kiota/pull/2996


Generate statistics on various contributor activities across product releases

Is your feature request related to a problem? Please describe
I would like to know how well we're doing with engaging the open-source community for OpenSearch, release after release.
Describe the solution you'd like
A way to generate/visualize answers to the following questions:

How many non-Amazonians/Amazonians contributed to OpenSearch 2.0?
How many non-Amazonians/Amazonians contributed to OpenSearch clients this year?
How many new features were introduced by non-Amazonians in OpenSearch 2.0?
How many bug fixes were made in OpenSearch 2.0.
What is the % of contributions that are maintenance, i.e. aren't features or bug fixes?

Describe alternatives you've considered
No response
Additional context
I have been looking at various numbers of contributors to opensearch-project/OpenSearch week-over-week, but I have many more questions release-after-release.

[Triage] @CEHENKLE will be looking into this issue.

@prudhvigodithi Lets track this as part of the metrics initiative.

@prudhvigodithi Lets track this as part of the metrics initiative.

Sure @bbarani this issue best suits the metrics initiative.

Closing this issue as we have https://github.com/opensearch-project/project-tools repo to understand the metrics.


Version 2.1.5 and 2.1.6 missing from Maven Central

Is there any chance you could publish 2.1.6 and 2.1.5 to Maven Central? They appear to be missing and the latest it seems to have is 2.1.4.
Link: https://search.maven.org/artifact/io.lenses/secret-provider

@tginsberg We no longer publish to maven. Is there are reason you require it?

@andrewstevenson No, not any longer. We worked around it.


add a restore initial code button

🚀 Feature Proposal
A clear and concise description of what the feature is.
Motivation
Please outline the motivation for the proposal.
Contribution
Please describe the solution if you'd like to submit a PR.

Your code is either saved on Leetcode if you submit it or your local text file where you edit it. So it seems this feature is already there.


Error: how I can run the test from pygen_src?

Hi, I got the error when I try to run the riscv_instr_base_test.py
Traceback (most recent call last):
  File "test/riscv_instr_base_test.py", line 16, in <module>
    from pygen_src.riscv_instr_gen_config import cfg  # NOQA
ModuleNotFoundError: No module named 'pygen_src'

Do I miss anything to run it? Thank you

Hi @danghai
For running riscv_instr_base_test.py, you need to run it from test directory.
The dependencies are already added in requirement.txt
Try installing the dependencies and run it from the test directory.
-Anil

Hi @aneels3 . It works for me now. Thanks


Package can't be built with github dependency

If your project has a dependency on a github depot lambda-packager throws an error during package creation.
Example dependency in pyproject.toml
[tool.poetry.dependencies]
lambda-packager = {git = "https://github.com/hmrc/python-aws-lambda-packager.git"}

Run lambda-packager and you get this error:
ERROR: Can't verify hashes for these requirements because we don't have a way to hash version control repositories:
    lambda-packager@ git+https://github.com/hmrc/python-aws-lambda-packager.git@master from git+https://github.com/hmrc/python-aws-lambda-packager.git@master (from -r /var/folders/_n/dzhlknk14cx3b398vlcm8r140000gp/T/tmp6636q_6j/requirements.txt (line 10))

This prevents me from being able to use my own shared libraries as dependencies with lambda-packager.

This should now work in version 1.2.0 using the without_hashes setting


Docs for Typer CLI

:sparkles: Docs for Typer CLI

Codecov Report

Merging #64 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   99.96%   99.96%
=======================================
  Files         166      166
  Lines        2925     2925
=======================================
  Hits         2924     2924
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fe78c...ef742a2. Read the comment docs.


[FLI-901] Java: Add Get/ListFlags support

Add GetFlag support in Java SDK like #148
Add ListFlags support in Java SDK like #127
FLI-901

Hi @markphelps , I would like to work on this task.

thank you @devumesh ! much appreciated


No NVIDIA TX1 USB support

Currently, I am finding that the Silicon Labs cp210x driver for the Naze32/Flip32 board is not supported by the kernel that is compiled for the TX1. It is best to use the UART on the Naze32 and connect that to an FTDI USB cable or go directly to UART1 on the TX1.

Thanks for finding this @dallinbriggs.
This should be fixed with other boards that don't use the SI chip.  For example the F4 boards use USB directly, and don't go through a UART->USB conversion.  That should help in the future.

It'd be nice to figure out how to get the cp210x driver installed on the TX1 and include it in our documentation for other people who want to use this setup maybe? Or at least describe Dallin's fix in a troubleshooting section of our documentation


Group Updated Chapters Together

Describe your suggested feature
In the updates screen, if there is multiple chapters of a work that were newly added, they should all be under one title that can be clicked for a drop-down to see the individual new chapters, just like Yokai and Tachij2k had.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.11.2.
[X] I will fill out all of the requested information in this form.

Duplicate of #64


Matomo doc

Description of the change

Description here

Type of change

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists
Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests
[ ] All tests related to the changed code pass in development

Code review

[ ]  This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
[ ] "Ready for review" label attached to the PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one other engineer
[ ] Issue from task tracker has a link to this pull request

As we have updated the overall docs architecture, merging this PR would cause a major conflict. Hence, created a new PR here and will address all the changes/suggestions/feedback. @rohithkaza @ItsSudip


Add automatic processing when using Obsidian web clipper

It seems that automatic processing does not work when page is saved from Obsidian web clipper, even though "Automatic processing" and "Process all new markdown files" options are enabled. Would be very useful, if you made processing to work on new clips.

I support this request 👍
The current workaround seems to be to periodically invoke the Download all media files for all your notes. (I'm yet to try this though.) Maybe set a reminder to do this as part of your monthly vault maintenance? 😁 Of course, this would be much easier if there was an option to auto run this command on O. startup or once every x hours.


Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.

I'm using Meteor but I don't think that's the issue since I tried the same code in the regular console and got the same errors.
I tried doing both $(document).foundation(); for the entire layout and I tried doing this.offCanvas = new Foundation.OffCanvas($('#offCanvasLeft')); but both cases give me the same stack trace (below).
I also tried using a regular HTML non-jQuery element with new Foundation.OffCanvas(document.getElementById('offCanvasLeft') and that gave me this error
// error when using regular element
foundation.js:4158 Uncaught TypeError: this.$element.data is not a function(…)

// stack trace when using .foundation() or .OffCanvas
debug.js:41 Exception from Tracker afterFlush function:
debug.js:41 TypeError: Failed to execute 'getComputedStyle' on 'Window': parameter 1 is not of type 'Element'.
    at TypeError (native)
    at OffCanvas._init (http://localhost:3000/packages/zurb_foundation-sites.js?5617ebc8cbe851ac55391427ddd6422e66df21e7:4387:55)
    at new OffCanvas (http://localhost:3000/packages/zurb_foundation-sites.js?5617ebc8cbe851ac55391427ddd6422e66df21e7:4293:10)
    at null.<anonymous> (http://localhost:3000/app/client/templates/nav/side_nav.js?e86a65060bb9d5e37a29aba87121df59bbeb322e:3:24)
    at http://localhost:3000/packages/blaze.js?695c7798b7f4eebed3f8ce0cbb17c21748ff8ba8:3338:22
    at Function.Template._withTemplateInstanceFunc (http://localhost:3000/packages/blaze.js?695c7798b7f4eebed3f8ce0cbb17c21748ff8ba8:3679:12)
    at fireCallbacks (http://localhost:3000/packages/blaze.js?695c7798b7f4eebed3f8ce0cbb17c21748ff8ba8:3334:12)
    at null.<anonymous> (http://localhost:3000/packages/blaze.js?695c7798b7f4eebed3f8ce0cbb17c21748ff8ba8:3427:5)
    at http://localhost:3000/packages/blaze.js?695c7798b7f4eebed3f8ce0cbb17c21748ff8ba8:1788:14
    at Object.Blaze._withCurrentView (http://localhost:3000/packages/blaze.js?695c7798b7f4eebed3f8ce0cbb17c21748ff8ba8:2219:12)

Ok, that is caused by the fallback to select a transition time for the off-canvas wrapper. Try setting the option for that directly and see if it still gives you issues.
new Foundation.OffCanvas($('selector'), {transitionTime: 500});

or
...data-off-canvas data-transition-time="500"...

I did the first option which got rid of the error. But I can't actually open the Off Canvas section.

So it was working correctly the whole time? Or there's still an issue of accessing the computed style?

Just tried it without the transitionTime fix and it did work. Apologies for the incorrect bug.
To prevent incorrect bug reports like this in the future, I think that it would be helpful if there was some console logging when a plugin can't find the correct data attributes

I think that's a great idea, care to write a pr that drops in the proper error handling in our try/catch init? :smile:

Absolutely glorious - I did not forget a dash - & was still getting this error. Adding a transition time fixed it.  :)


Swap axis, moveaxis, expanddims added

PR Summary

Added functions to manipulate axes for arrays.
PR Checklist

[x] "closes" moveaxis, swapaxis and expanddims in issue #134.
[x] new and changed code is tested
[x] relevant changes added to CHANGELOG.md
[x] new functionality is documented

I realized I missed the pydocs test. Working on fixing it now

All suggested changes should be fixed now!

Oh, and can you please add these to the documentation https://github.com/apytypes/apytypes/blob/main/docs/api/apyfixedarray.rst (and apyfloatarray.rst).

Should be finished now!


Dangerous Site Show when open in laptop deviceS

I need to work on this issue under gssoc24 could you assign me this label level 3 and gsoc.
This is not good when for  your website..  See this
I try to fix within a day.. @codervivek5

lets try if you can

https://664ee5ce2fe4dfb7b5d9c2bc--eclectic-travesseiro-ae184a.netlify.app/
Here is deployment of your website but I could not able to change from your about us section.  You change it.
I only able to add in readme file.


Fix link to metapackage

The link in the note that was supposed to be to the new metapackage was instead to the same page that contained the note.

@breyed Thank you for catching this and fixing it. Much appreciated.


Add the make release function

Create a make release function, which allows to create a release from a tag with given options.

Hi @alexcanessa. Thank you for your contribution!
Before we can merge your PR, can you include some tests and update the README file to document your method? Also, are all the options you mention mandatory? It might be worth to specify that as well.

Hi @alexcanessa. Did you have the chance to update this PR? I'd love to merge it.

I've also found that this PR is a subset of https://github.com/michael/github/pull/162. However the other PR is very old, so if you can update yours to include all the methods while proving tests and documentation, we can keep this one.

This feature is already in the library. http://michael.github.io/github/docs/1.1.0/Repository.html#createRelease


Cleanup and remove processed jobs

old jobs (the ones processed) should be automatically delete from:

redis queue

Is already the case with: https://github.com/geometalab/osmaxx-frontend/blob/d7feb8c8ddaec246ae6de19b9aada6b60208136a/osmaxx/conversion/management/commands/result_harvester.py#L65


mmt start hangs if moses throws an exception at startup

To reproduce:
Create an invalid moses.ini, e.g. by specifying an invalid model file path. Then run ./mmt start. Moses will throw an exception, visible in runtime/default/slave/logs/process.log, but this fact never occurs to the mmt script, which waits happily for the slave to report back, which never happens.
Expected behavior:
./mmt start should print an error and exit if the slave has died during startup.
Actual behavior:
$ ./mmt start -e baseline

Starting MMT engine 'baseline'... OK
Loading models...

<hangs indefinitely here>

Rationale:

During development, it is easy to run into a situation where moses throws an exception at startup. ./mmt start should exit instead of hanging indefinitely after moses (the MMT slave process) has crashed.
There may be myriad reasons for moses crashing even in production (like out-of-memory, corrupted models, ...), and most of the time a crash will be immediately on startup.

This is the same issue of #81


Merge with CsaGuzzleBundle

There is another bundle: https://github.com/csarrazi/CsaGuzzleBundle
Do you think about merging to it?

Hi,
thanks for your info. I will take a look at it to see if this can be done.
Best regards
Florian


RxValueAnimator support for RxJava 1.2+

Recently, RxJava 1.2.0 has been released and they've made some backward-incompatible changes related to Completables, specifically:

CompletableSubscriber -> rx.CompletableSubscriber
CompletableOnSubscribe -> rx.Completable.OnSubscribe

After upgrading to it, I'm getting the following gradle build issues on :
RxValueAnimator.from(myValueAnimator, animator ->{
              ...
 });

Error:(347, 24) error: cannot access CompletableOnSubscribe class file for rx.Completable$CompletableOnSubscribe not found

Hi, thank you for reporting this issue.
I will look into it and publish fix soon, so stay tuned :)

Also look into RxAnimationBuilder which has the same issue too.

Fixed in release version 0.9.0.
Once again, thank you for reporting this issue 👍


Consider a flag on events to make them non-searchable

A bot that posts a daily update sure does make it hard to search for things. /me glares at mscbot

Alternatively, we could just support richer filtering for search..

That fixes one half of the problem.  Richer filtering just means the user spends more time filtering things out than they do finding things.

Yep, I understand but I do question whether it should be up to the sender to decide if something should be indexed. I guess it could be a useful hint flag in the event's contents which some homeservers could ignore if they wanted.
My reasoning for not wanting the flag is because I'm not sure I want others to dictate how my indexing works, but granted there is also a need to not index everything.
Regardless, richer filtering is certainly something that would be nice to have imo.

I'd imagine it's more a "I'm a bot that would send a m.notice but my use case says that's not reasonable, so don't index this" thing (I'm somewhat confident that implementations don't currently index notices)


Shelley: Implement GetCurrentLedgerState query

I don't understand the need and usefulness of CBOR-in-CBOR here. If it's CBOR-in-CBOR, the client becomes responsible for deserialization, rather than us providing the serializer; this means that if the client writes their own deserializer, we are even more restricted in how we change stuff, it doens't really seem to help with compatiblity. And if not for compatibility, then why would clients want the raw CBOR?

So @mrBliss explained to me that the idea here is that if we don't use CBOR-in-CBOR, the client running the local state query protocol will disconnect if the serialization format has changed and it gets a CBOR error, whereas the CBOR-in-CBOR forces the client to do the decoding and therefore take alternative action if that decoder fails. Ok, seems reasonable, but then I do wonder, if the client is asking for a UTxO, but it can't decode it, what kind of alternative action will it take? Is there something useful it can do? Because if not, then just getting the disconnected error doesn't seem a whole lot worse.
It also feels a bit ad-hoc by the way to have CBOR-in-CBOR for this one specific query. If this really is seful, I'd prefer something like
GetSerialised :: Query a -> Query (Serialised a)

There may be other queries that require CBOR-in-CBOR.

bors merge


topmost() is deprecated

It uses a standard navigation component, according to the API on the site https://svelte-native.technology/docs#navigate.
In the console it writes:
JS: topmost() is deprecated. Use Frame.topmost() instead.
This works when called:
navigate({ page: DetailPage, props: { message: "Hello from master" } });

Thanks, I take it this is for nativescript 6.4?, I'll have to update svelte-native to support. It can be safely ignored in the short term

it this is for nativescript 6.4?

Actually, I also have this warning using 6.2:
❯ npm list | grep<EMAIL_ADDRESS>
│ └─┬<EMAIL_ADDRESS>

i have same warning by using<EMAIL_ADDRESS>

0.8.4 should resolve this


Clean up command

Clean up command will delete some rows from _ClassToPlan and _ClassToLecturer table that no longer has valid foreign key.

Some query
select * from _ClassToPlan cp
where cp.B not in (select id from Plan);
delete from _ClassToPlan cp where cp.B not in (select id from Plan);

select * from _ClassToPlan cp
where cp.A not in (select id from Class);
delete from _ClassToPlan cp where cp.A not in (select id from Class);

select * from _ClassToLecturer cl
where cl.B not in (select id from Lecturer);
delete from _ClassToLecturer cl where cl.B not in (select id from Lecturer);

select * from _ClassToLecturer cl
where cl.A not in (select id from Class);
delete from _ClassToLecturer cl where cl.A not in (select id from Class);

#27


fix doc

Please answer these questions before submitting a pull request

Why submit this pull request?
fix doc

the config name is submited by me recently. And 8.2.0 has not been released, i think i can fix it

@wu-sheng PR fail is because of the poorly connection with central repository.

I submitted a rerun.


As the Designer, I want to install clang-format to that my C++ code is formatting to the clang standard.

[x] Use brew on Darwin
[x] Test LinuxBrew
[x] test

Git-commit e1d5f55 completed this task.


Fix/record attribute exception/lp 7622

Can one of the admins verify this patch?

test this please


[FEAT] Rework add page

Is your feature request related to a problem? Please describe.
Navigating the user to a whole new page for only 2 fields is a bit too much.
Describe the solution you'd like

Having a dummy card transforming into a form and then a real card.

Or

A pop up card at the top of the add button with the 2 fields. The add button transform into a validation button. Once validated, the card slide into its place.

This issue will be part of  #56


Improvement for k8s.io/docs/reference/networking/ports-and-protocols/

Please include the protocol, so TCP or UDP.

My fault - forget it.


Test for and fix encoding errors on Windows

This is a followup to https://github.com/gradle/gradle/pull/25261.
Let's enable the use of non-ASCII paths for Windows integration tests, and fix any discovered problems.

Actually, those code points stand for something completely different... 🤔
But I tried running the child process from Java with ProcessBuilder, using the explicit character code \u0219 and got:
> Sending:  te?t, chars: [ u0074 u0065 u0219 u0074 ], bytes: [ 74 65 c8 99 74 ]
> Received: te?t, chars: [ u0074 u0065 u003f u0074 ], bytes: [ 74 65 3f 74 ]

It doesn't matter if I use cmd:
new ProcessBuilder("cmd", "/u", "/c", "java", "-cp", ".", "-Dvar=" + value, "Main")

(with or without /u)
Or execute Java directly:
new ProcessBuilder("java", "-cp", ".", "-Dvar=" + value, "Main")

One option I can imagine working is to encode the parameters ourselves with some ASCII-only encoding. URI encoding comes to mind, but % would need to be double-escaped...

Also note that if I try to send non-ASCII characters that are part of CP1252, like tést, the transmission works (though the console output is still garbled, the codepoints are correct):
> Sending:  t??st, chars: [ u0074 u00c3 u00a9 u0073 u0074 ], bytes: [ 74 c3 83 c2 a9 73 74 ]
> Received: t??st, chars: [ u0074 u00c3 u00a9 u0073 u0074 ], bytes: [ 74 c3 83 c2 a9 73 74 ]

Using chcp 65001 to set the codepage to something unicode-i fixes my console, but doesn't fix the process invocation:
> Sending:  teșt, chars: [ u0074 u0065 u0219 u0074 ], bytes: [ 74 65 c8 99 74 ]
> Received: te?t, chars: [ u0074 u0065 u003f u0074 ], bytes: [ 74 65 3f 74 ]

Certain specific characters in the Windows username break compilation of project (#29213)
When the Windows username contains the "ï" character, it is not possible to compile NeoForge mods.

Of course, I apologize for getting into this issue. - I also have this error
Path: C:.gradle*


New App Submission Coinbase wallet

App Logo (Required)
(Attach image here)
App Details (Required)
Type: Wallet or Dapp
Name:
Homepage Url:
Chains supported:
App Url (Required - at least one)
Browser Url:
iOS Url:
Android Url:
Mac Url:
Windows Url:
Linux Url:
Mobile Linking (Optional)
Deep Link:
Universal Link:
Desktop Linking (Optional)
Deep Link:
Universal Link:
Metadata (Optional)
Short Name:
Primary Color:
Secondary Color:

Any updates on Coinbase being added?

Please direct this feature request to Coinbase.


Ability to create custom bot commands

Similar to this project: https://github.com/Chikachi/DiscordIntegration
Custom commands that can be linked to certain console commands, specified in the config.

Closing out feature requests to keep this tracker to bugs-only. This does not mean that this feature is a "won't-add". Further discussion is being moved to the Discord.


Update docs to reflect removal of jsx command

Just so the next guy won't go wondering why it's won't come up for him :o

Thanks!


Bug has been fixed in Edge

I am 100% sure that has been fixed in Edge - because I was the one who added that notice but on an other feature, someone copied over wrong.
Also see here - it's mentioned three times but once wrong.

Thanks!


list assumed overheads and other related parameters in the config tab

Is your feature request related to a problem? Please describe.
It's not clear how the ROT is calculated.
Describe the solution you'd like
In the Config tab, we can list the numbers for the unit exposure time and assumed overheads for calibration, fiber configuration, etc. as non-editable boxes.
Describe alternatives you've considered
List these parameter in the documentation.

It's listed in the doc as well.


Auto update doesn’t run the container

My image gets updated by ourobros, but the container shows it’s created but not running. And sometime , container can’t start, then I hvae to remove and recreate it.

Do you have any debug output?

Closing as there has been no progress. If you find time to reply let us know

sorry for the late
    network.connect(**new_network_config),   File "/usr/local/lib/python3.7/site-packages/docker/models/networks.py", line 57, in connect,     container, self.id, *args, **kwargs,   File "/usr/local/lib/python3.7/site-packages/docker/utils/decorators.py", line 19, in wrapped,     return f(self, resource_id, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/api/network.py", line 242, in connect_container_to_network,     ipv6_address=ipv6_address, link_local_ips=link_local_ips,   File "/usr/local/lib/python3.7/site-packages/docker/api/container.py", line 649, in create_endpoint_config,     return EndpointConfig(self._version, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/types/networks.py", line 17, in __init__,     self["Links"] = normalize_links(links),   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in normalize_links,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)],   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in <listcomp>,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)], ValueError: too many values to unpack (expected 2), 2019-03-24 20:03:59 : INFO : ouroboros : Version: 1.3.1-master, 2019-03-24 20:04:03 : WARNING : NotifyEmail : A Connection error occured sending Email notification to <IP_ADDRESS>., 2019-03-26 02:05:30 : INFO : dockerclient : zabbix_sub will be updated, 2019-03-26 02:05:37 : ERROR : base : Job "Interval container update for unix://var/run/docker.sock (trigger: interval[10:00:00], next run at: 2019-03-26 12:04:03 CST)" raised an exception, Traceback (most recent call last):,   File "/usr/local/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job,     retval = job.func(*job.args, **job.kwargs),   File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 321, in update,     self.recreate(container, latest_image),   File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 157, in recreate,     network.connect(**new_network_config),   File "/usr/local/lib/python3.7/site-packages/docker/models/networks.py", line 57, in connect,     container, self.id, *args, **kwargs,   File "/usr/local/lib/python3.7/site-packages/docker/utils/decorators.py", line 19, in wrapped,     return f(self, resource_id, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/api/network.py", line 242, in connect_container_to_network,     ipv6_address=ipv6_address, link_local_ips=link_local_ips,   File "/usr/local/lib/python3.7/site-packages/docker/api/container.py", line 649, in create_endpoint_config,     return EndpointConfig(self._version, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/types/networks.py", line 17, in __init__,     self["Links"] = normalize_links(links),   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in normalize_links,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)],   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in <listcomp>,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)], ValueError: too many values to unpack (expected 2), 2019-03-26 22:06:10 : ERROR : dockerclient : Issue detecting aria2_sub's image tag. Skipping..., 2019-03-27 08:05:32 : INFO : dockerclient : gogs_sub will be updated, 2019-03-27 08:05:44 : INFO : NotifyEmail : Sent Email notification to<EMAIL_ADDRESS>2019-03-27 18:09:04 : ERROR : dockerclient : Issue detecting ouroboros_sub's image tag. Skipping..., 2019-03-27 18:09:04 : ERROR : dockerclient : Issue detecting shaarli_sub's image tag. Skipping..., 2019-03-27 18:09:04 : ERROR : dockerclient : Issue detecting portainer_sub's image tag. Skipping..., 2019-03-27 18:10:50 : INFO : dockerclient : redis_sub will be updated, 2019-03-27 18:10:58 : INFO : dockerclient : postgres_sub will be updated, 2019-03-27 18:11:13 : INFO : NotifyEmail : Sent Email notification to<EMAIL_ADDRESS>2019-03-28 04:06:00 : INFO : dockerclient : ttrss_sub will be updated, 2019-03-28 04:06:11 : INFO : dockerclient : nextcloud_sub will be updated, 2019-03-28 04:06:13 : ERROR : base : Job "Interval container update for unix://var/run/docker.sock (trigger: interval[10:00:00], next run at: 2019-03-28 14:04:03 CST)" raised an exception, Traceback (most recent call last):,   File "/usr/local/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job,     retval = job.func(*job.args, **job.kwargs),   File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 321, in update,     self.recreate(container, latest_image),   File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 157, in recreate,     network.connect(**new_network_config),   File "/usr/local/lib/python3.7/site-packages/docker/models/networks.py", line 57, in connect,     container, self.id, *args, **kwargs,   File "/usr/local/lib/python3.7/site-packages/docker/utils/decorators.py", line 19, in wrapped,     return f(self, resource_id, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/api/network.py", line 242, in connect_container_to_network,     ipv6_address=ipv6_address, link_local_ips=link_local_ips,   File "/usr/local/lib/python3.7/site-packages/docker/api/container.py", line 649, in create_endpoint_config,     return EndpointConfig(self._version, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/types/networks.py", line 17, in __init__,     self["Links"] = normalize_links(links),   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in normalize_links,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)],   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in <listcomp>,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)], ValueError: too many values to unpack (expected 2), 2019-03-28 14:06:12 : INFO : dockerclient : wordpress_sub will be updated, 2019-03-28 14:06:16 : ERROR : base : Job "Interval container update for unix://var/run/docker.sock (trigger: interval[10:00:00], next run at: 2019-03-29 00:04:03 CST)" raised an exception, Traceback (most recent call last):,   File "/usr/local/lib/python3.7/site-packages/apscheduler/executors/base.py", line 125, in run_job,     retval = job.func(*job.args, **job.kwargs),   File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 321, in update,     self.recreate(container, latest_image),   File "/usr/local/lib/python3.7/site-packages/pyouroboros/dockerclient.py", line 157, in recreate,     network.connect(**new_network_config),   File "/usr/local/lib/python3.7/site-packages/docker/models/networks.py", line 57, in connect,     container, self.id, *args, **kwargs,   File "/usr/local/lib/python3.7/site-packages/docker/utils/decorators.py", line 19, in wrapped,     return f(self, resource_id, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/api/network.py", line 242, in connect_container_to_network,     ipv6_address=ipv6_address, link_local_ips=link_local_ips,   File "/usr/local/lib/python3.7/site-packages/docker/api/container.py", line 649, in create_endpoint_config,     return EndpointConfig(self._version, *args, **kwargs),   File "/usr/local/lib/python3.7/site-packages/docker/types/networks.py", line 17, in __init__,     self["Links"] = normalize_links(links),   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in normalize_links,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)],   File "/usr/local/lib/python3.7/site-packages/docker/utils/utils.py", line 447, in <listcomp>,     return ['{0}:{1}'.format(k, v) if v else k for k, v in sorted(links)], ValueError: too many values to unpack (expected 2),


refactor: full rewrite for v2

the code base was starting to be a bit confusing, so I guess it was time for a rewrite ;-)
the workflow is now simpler:

first step: retrieve the previous version
second step: bump the version

with different implementations (strategies) for each
I kept the existing features of:

reading the version from files
reading the version from git tags
the same-release flag, which is now implemented using a pattern to filter git tags (see README)

a few more notes:

no more dependency on the git binary, we're using the go-git lib to query the git repo
using a single semver lib instead of 3: github.com/Masterminds/semver
using github.com/zbindenren/cc to parse the conventional commits

@jstrachan @rawlingsj :

I also cleaned the OWNERS file, and added myself in it, to help maintain this repo. Tell me if it's ok with you
can you please add the SonarCloud integration in this repo, same as what was done for https://github.com/jenkins-x/jx-pipelines-visualizer? thanks

BREAKING CHANGE: the default behaviour is now to use semantic release

Hi @vbehar. Thanks for your PR.
I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sonar cloud doesn't like a bit of duplication in the unit tests, so I created https://github.com/jenkins-x-plugins/jx-release-version/pull/60 to disable the copy/paste detector for the unit tests - which needs to be merged first

/ok-to-test
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Create CODEOWNERS

PJ owns the entire abuse stack. He should be code owner here. I don't mind whether the second code owner is me or Chris.

that's kind of weird though, he did not even contribute to this repo, I added him anyway


[FLINK-18130][hive][fs-connector] File name conflict for different jobs in filesystem/hive sink

What is the purpose of the change
The sink of different jobs (or the same SQL runs multiple times) will produce the same file name, the rename will fail, and different file systems will produce different results:

HadoopFileSystem: ignore new data.
LocalFileSystem: overwrite old data.

Brief change log
We can add UUID to prefix, make sure there is no conflict between jobs.
Verifying this change

HiveTableSinkITCase.testBatchAppend
HiveTableSinkITCase.testStreamingAppend
FileSystemITCaseBase.testInsertAppend
FileSystemITCaseBase.testInsertOverwrite

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no

CC: @gaoyunhaii @lirui-apache

Thanks @gaoyunhaii for review, merging...


Native LatLngBounds ContainsLocation?

Is there any chance to implement GMSGeometryContainsLocation() (iOS) and LatLngBounds.contains() (Android) methods?
Already implemented LatLngBouns.contains() works only for regular shapes like rectangles and squares. If the bounds is circle, trapezoid etc., the methods fails (returns true even the given point is not in bounds).
I guess the native methods will solve it properly.

I see. But I'd like to above executing the native method as much as possible.
Because it takes a callback.
I will try to implement JS code.

Any update of this please?

Sorry, I'm so busy.
But you can try this by yourself. The source code is fully open.
https://github.com/mapsplugin/cordova-plugin-googlemaps/blob/bf6156189d28ec838bddf36517a5c661305e3a54/src/android/plugin/google/maps/PluginMap.java#L2293-L2330

Thank you for waiting long time. I implement two methods in JavaScript.
In order to use these methods, please reinstall the plugin from the multiple_maps branch (not the master branch).

poly.containsLocation()

poly.isLocationOnEdge()

By the way, I appreciate if you support for this project.
This is not mandatory asking, but I appreciate if you donate some tip because I spend my private time.
This is $5 donation link at paypal
When you donate some amount to the project, please include your issue number in your name.

Thanks, it works.
There seems to be bug in multiple_maps branch in Polygon section.
While remove() method called on created polygon, I got error: TypeError: undefined is not an object (evaluating 'self._isRemoved') — Polygon.js:131

Thank you for letting me know. I fixed it. Please try again.
By the way, I really appreciate for your donation!!


How in the world did master TodePond Make this part in their newest video??

https://youtu.be/ZMklf0vUl18?t=176 How did they make this seemingly infinite quality sand?? I get the basic idea but I can't get it right

It's a different project https://github.com/TodePond/SandLab

Ah thanks. Is it possible on cellpond ya think or nah
prolly not or atleast not to easy

its not possible to code it with the visual editor in cellpond. the underlying engine can support it, but there's no useful API for it. SandLab is kinda like my in-progress sequel to cellpond. It lets you do madder stuff! (but theres no visual editor for it yet)

What would it take to do so? And how would I do it in sandlab? I'm learning abt it rn


Fix babel source map parsing

Fixes babel source map parsing by ignoring new field; added appropriate test case.
Supersedes #2.

Proof test case fails before patch:

Thanks


login flash message not working

It seems that when login fails the flash messages don't appear.
The user is redirected to login without any informative message.

Looking into it now

It appears that flash messages don't get sent through when the redirect() method is called to render a template. They only go through when render_template() is called... Interesting behavior.
I'll look into the behavior of redirect() vs render_template() tomorrow and see if I can find a way to send flash messages via redirect().


[Trouble finding the leprechaun] Two suggestions

I am doing another play-through, and I have installed many mods, some of which cause
odd problems, so perhaps this is related to it in a way.
At any rate, I can not find the leprechaun. Normally he is in the middle of the map, but
when I check, he is not there. I re-checked several times but he was not found.
I have two suggestions to make, just in the event that this is related solely to the mod
rather than some other mod interfering (or perhaps it affects the mod too, I don't
know):

When one is trying to find the leprechaun, it may be helpful to be able to re-ask
the NPC who gives the task. Right now he does not seem to want to talk to me at
all after I accepted the quest. This could also be used to re-populate the
leprechaun into the default spawning position. Or, if it is by design, to tell the
player again where the leprechaun could be found alternatively, if not in
the main spawning position.

Perhaps a second check could be done, after, say, 48 hours or so, to have
the routine be called again "if leprechaun was not found, respawn him" or
something like that. I am not sure what is the problem because in prior
play-throughs the leprechaun was found.

Actually, a bug related to that has already been fixed and will be included in the next release. Now, the fact that Michelson does not appear is something I cannot replicate unless I know which mods you are referring to; it's possible that one of them affects a variable in the Dusk mod. I can think about what to do to prevent that from happening and will definitely add it in the same release. Those tips are very helpful, thank you.


Need to update securevault.bat file before run the securevault.bat file

Description:
Need to update the following configuration in the securevault.bat file before encrypting passwords in synapse configurations in secure vault implementation for windows.
Default configuration in securevault.bat.
set CARBON_CLASSPATH=.\conf
FOR %%c in ("%CARBON_HOME%\wso2\components\plugins\org.wso2.micro.integrator.security*.jar") DO set
CARBON_CLASSPATH=!CARBON_CLASSPATH!;".\wso2\components\plugins\%%~nc%%~xc"

Before run the securevault.bat file we need to update it as shown bellow.
set CARBON_CLASSPATH=.\conf
FOR %%c in ("%CARBON_HOME%\wso2\components\plugins\org.wso2.micro.integrator.security*.jar") DO (
set CARBON_CLASSPATH=!CARBON_CLASSPATH!;".\wso2\components\plugins\%%~nc%%~xc")

Documentation link : https://ei.docs.wso2.com/en/latest/micro-integrator/develop/creating-artifacts/encrypting-synapse-passwords/
Suggested Labels:
securevault, micro.integrator
Affected Product Version:
WSO2 Micro Integrator 1.1.0
OS, DB, other environment details and versions:
Windows

Fixed.


cannot delete files

i can create new file and edit old ones, but i cannot delete them
i'm using latest version of winsshfs and dokan
version <IP_ADDRESS> works
thanks in advance

Verified installing latest version today, configuration from this comment, and there deleting files does work correctly for me. This looks like an issue that has been since fixed.


The file resources/assets/js/slugify.js is not include in app.js?

Laravel Version: 5.5
Voyager Version: 1.0.2
PHP Version: 7.1.8
Database Driver & Version: MySQL

Description:
I have created a pull request for this file to fix error with the slug in Vietnamese country.
Link to pull request: https://github.com/the-control-group/voyager/pull/1699
I check in webpack.mix.js file, it using folder publishable/assets/js to generate app.js file.
I find on app.js, but don't have any a code I was committed.
Example:
have this._map_latvian(), at line 121. don't have the line _map_vietnam() at line 120.
Have any method to quick fix that? I updated for Voyager 0.9.x to 1..0.2. And lost my JS for to config for my language because Voyager using Mix to compile resource.

PR has been merged.  Please make sure to add a comment like "fix [issue number]" in the PR when opening it, so it will automatically close these related issues)


Improve deleted file experience

At present, when a file is deleted (https://zulip.com/help/manage-your-uploaded-files), this results in a confusing experience when looking at a message where that file appeared:

Clicking on the file link, the user sees:

To clarify that the situation is not a Zulip bug, we should:

[ ] Replace the "File not found." text with: "This file does not exist or has been deleted."

[ ] Replace the image thumbnail with an image-not-found image with the following text: "This image does not exist or has been deleted."

It's fine to submit a PR addressing just one of these points.
CZO discussion

@zulipbot claim

@zulipbot claim

@alya I just wanted to clarify the second task. When you mean "image preview" do you mean the thumbnail displayed under the file link, or do you mean the image displayed on a new tab after clicking on the thumbnail, or both?

@janiduVBR Thanks for asking! I meant the thumbnail.
I guess it could also be an improvement to change what we show in the preview UI once you click on it. I'll post about it on the linked CZO thread for discussion.

Ah, right, if we change the thumbnail image, it should probably change the preview UI display without any extra work, which seems good. Updated the issue description accordingly.

Hi!
I'm interested to contribute in this issue. Can I start working on it ?

@Avijit-ap I believe at the moment I have a working solution, but if anything changes I'll let you know.

can i please help  you out with this issue

@zulipbot claim

Hi Aryan,
You are more than welcome to work on the issue. I've been unfortunately
very busy with other responsibilities so I have not had the time to work on
this issue. As such I would be glad to hand the issue to you. I recommend
you look at my previous pull request as it almost solves the issue, it just
needs a few testing changes.
On Mon, Jan 9, 2023 at 12:02 AM Aryan Bansod @.***>
wrote:

can i please help you out with this issue
—
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/issues/23739#issuecomment-1375108414, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AXFR3FWWASE4NO2HD3OSQ73WROLWDANCNFSM6AAAAAASSOI24I
.
You are receiving this because you were mentioned.Message ID:
@.***>

@zulipbot claim

In #24037, a duplicate of this, I wrote:

When a user deletes an attachment, we:

remove the contents from disk
delete the Attachment row
send an event to the user that deleted that attachment, so they can update their list of attachments in their personal settings.

Notably, we don't adjust anything about the messagelist. This has a couple side-effects:

New clients that have never fetched the image will try to do so and get an inline broken image link, since the server will 404; this is pretty ugly.
Old clients that have a cached copy of the contents will continue to render it ((even with shift-reload, often), giving an inconsistent result with new users.

This is the opposite of #17348, in some senses. Both are due to not using the many-to-many relationship we have to cascade updates across Attachments <-> Messages.
We should:

[ ]  Update the contents of all messages which link to the attachment, to contain some static "this image has been removed by its owner" image.
[ ]  Notify clients that can see it that the attachment has gone away; this is probably a natural outcome of doing the above edit, by sending an "update message" event.

I am not able to make a pull request it is asking for permission

just working on it

@Aryanryn09 are you still working on this issue? I am a new contributor, would be great if you can hand this issue to me, I'll definitely try to work on this 😊

@Aryanryn09 are you still working on this issue? I am a new contributor, would be great if you can hand this issue to me, I'll definitely try to work on this 😊

you can claim this issue.

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot Claim

@zulipbot claim

claim

I want to work on this. If the issue is open, please assign it to me.

@zulipbot claim

I am interested in this Issue. Can I do Pull Request or you can assign this issue to Me.

If this issue is still open kindly assign it to me.

first point resolved please check
please check commit #94e80e3

@zulipbot claim

@zulipbot claim

@zulipbot claim

first point resolved please check please check commit #94e80e3

We have not merged any commits that resolve this point.

@alya Can you please assign this issue to me. I am new to open source and I would like to contribute.

Hi!
I'm interested to contribute in this issue. Can I start working on it ?

@zulipbot Hi! I'm interested to contribute in this issue. Can I start working on it ?

Hey there, kindly assign me this issue, I would like to work on it.

@zulipbot claim

if the issue isn't solved yet. i want to work on this issue! Please assign it to me.

@zulipbot claim

@Aveepsita This issue cannot be claimed, as someone else is already working on it. Please see our contributor guide for advice on finding an issue to work on. Thanks!

Ok,thank you

@zulipbot claim

@zulipbot claim

then only file not found line i get is in channel.test.js ,is that the one we have to change
@alya

@zulipbot claim

@zulipbot I am still working on it

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot unassign me

claim

@zulipbot claim

@zulipbot  claim

@zulipbot I have submitted a PR #25423. It is waiting for review. Thanks.

@zulipbot I have submitted a PR #25432 . It is waiting for review. Thanks.

If the issue had been fixed, it would be closed.
As noted in the contributor guide:

What if there is already a pull request for the issue I want to work on? Start by reviewing the existing work. If you agree with the approach, you can use the existing pull request (PR) as a starting point for your contribution. If you think a different approach is needed, you can post a new PR, with a comment that clearly explains why you decided to start from scratch.

@zulipbot claim

Are these issues still open to claim ?

Hi , I am willing to contribute to fix these issues !

Hi, I can solve this issue, just give me the steps to recreate the issue.

@zulipbot claim

@zulipbot Claim

@zulipbot claim

Hi, I have solved the first point of issue: Replace the "File not found." text with: "This file does not exist or has been deleted."
I also updated the corresponding unit tests, and all Automated checks have passed.
The PR is #25920
I will also start working on the second point of the issue.
Thanks
Arghyadeep

is this issue still open.. or has the issue already been fixed?
if it is not fixed then please assigned this issue to me.

Hey, @abhishekcha790 it's good to see that you want to claim this issue. But right now this issue is in progress.
You can always go ahead and find some issues that are not being worked on -- by searching for issues with the label     help wanted. You can find more details about claiming an issue from our documentation.

claim

@zulipbot claim

Added this to the issue description as well, but a detailed technical design discussion for how to do this correctly is available here: https://chat.zulip.org/#narrow/stream/3-backend/topic/404s.20for.20deleted.20files

@zulipbot claim

I am really sorry as I was somewhat busy last few days. I will surely do this within this week. Thanks

I would like to solve this issue

Hi,
I would like to work on this issue,  @zulipbot claim, and work on the second part of the issue.
If available please assign it to me.

@zulipbot claim

I will try to solve this issue in the next 24 hours. Thanks for assignment!

@alexmv Hello, I was working on this issue, had changed the text . Can i take reference from your commit and create a pull request. As this is my first time contributing this would be helpful !


Inconsistent overlay network size limits

File: engine/swarm/networking.md, CC @mistyhacks states that only 256 IP addresses can be used within overlay network, while File: engine/reference/commandline/network_create.md, CC @mistyhacks shows example with CIDR /16 for overlay network and doesn't state any network size limitations. Can you please upgrade one or another so we know how big the overlay network can be?

Closing in favor of upstream PR.


Feature Request: Custom instruction for entire project/file

Thank you for the great extension. It works great and is helpful for a non-tech guy like me. Can custom instructions be included that Claude Dev can use throughout the project? This is in line with Claude's Project feature, where I can give custom instructions and Claude refers them throughout the project chats.
Use Case: Let's consider I'm trying to enhance the UI/UX of the web application I have built. Now, to achieve this task I have to give expectiation of mine in the prompt always and Claude Dev changes it in every file.  After adding more screens, now again I have to do this. I feel more tokens are getting wasted because of this. But if I have a custom instruction set for my entire project, it will be easy for Claude dev to reuse/adopt to recent changes quickly than running through the entire code base.
Not sure how much of the expectation is possible. But itd be great if this is possible. Cheers :)

When you first bring up the extension from the sidebar of tools you will see a gear icon in the upper right.  There you can make settings changes and there is a custom instructions area there.

Great, i will play around with it. Thank you so much!

I dont see any option to upload images for references. Does it not support uploading images/docs?

Where you type in your prompt over to the right there is a camera button that allows you to attach an image.

Yes, Im aware of this, but I was referring to the image in the custom instructions. Sorry for not being clear in my previous question. Appreciate your response!

out of curiosity, what kind of custom instruction would you want to do using an image?

To use UI/UX screenshots as reference

It's not possible adding images to the system prompt. Maybe you can ask claude to give a detailed description of the images and add that to custom instructions?


[Generator | Base] - Upgrade 0.28

Ignite Base Change

[x] Works on iOS/Android/XDE
[x] Tests Pass (run: npm run test)
[x] Code is StandardJS compliant (run: npm run lint)

Generator Change

[x] package.json lists all generators under "files"
[x] I have run and tested npm compile with latest src

@skellock  - plz review

Bad @GantMan! Base package.json does not match package.json.template

Looks good.  The whole indentation changes in Info.plist threw me for a loop for a sec, but I'm sure it's just that tool you're using reformatting things.
:shipit:

@skellock  - fixed indentation, it bugged me, too.

Its a trigger for me because of my .NET days.  Sometimes the act of open up a project in Visual Studio would change the source file.   /cut /cut /tears


warning 'No test points were found' appears even when test results were published

'No test points were found' appears in the pipeline summary, but tests results were found and published.

Pipeline output shows the warning and the published result.
##[debug]Mapping framework results to testpoints...
##[debug]evaluating 'has title' ({"name":"has title","stacktrace":"","failure":"","outcome":2,"properties":{}})
##[debug] TestConfigMatchStrategy: 0
##[debug] TestNameMatchStrategy: 0
##[debug]evaluating 'get started link' ({"name":"get started link","stacktrace":"","failure":"","outcome":2,"properties":{}})
##[debug] TestConfigMatchStrategy: 0
##[debug] TestNameMatchStrategy: 0
##[debug]evaluating 'test' ({"name":"test","stacktrace":"","failure":"","outcome":2,"properties":{}})
##[debug] TestConfigMatchStrategy: 0
##[debug] TestNameMatchStrategy: 1
##[warning]No test points were found.
##[debug]Processed: ##vso[task.issue type=warning;]No test points were found.
##[debug]accessToken=***
##[debug]collectionUri=https://dev.azure.com/xxxx/
##[debug]dryRun=false
##[debug]testRunTitle=PublishTestPlanResults
##[debug]Publishing test results...
Creating TestRun for Project: 'xxxx-a93c-4339-b8e2-927242607c49' TestPlan: '4802'.
##[debug]createTestRun projectId:xxxx-a93c-4339-b8e2-927242607c49 testPlanId:4802 testPoints: (1 items)
##[debug]getTestResults projectId:xxxx-a93c-4339-b8e2-927242607c49 testRunId:525
##[debug]0: getTestResults projectId:xxxx-a93c-4339-b8e2-927242607c49 testRunId:525 skip:0
##[debug]updateTestResults projectId:xxxx-a93c-4339-b8e2-927242607c49 testRunId:525 testCaseResults: (1 items)
##[debug]updating TestRun (state=Completed)
##[debug]task result: Succeeded
##[debug]Processed: ##vso[task.complete result=Succeeded;]

This warning is a false positive. When processing the test framework results, the extension gradually reduces the available test points to ensure that test points aren't updated more than once. If there are more test framework results than test points, this warning appears.


Add quick start deployment manifests

Why are these changes needed?
Address #114. With this change, it's much easier for user to bring up the KubeRay in their environments.
Related issue number
#114
Checks

[x] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

I have not updated helm chart yet. Let's leave this part to fork who work on that part.

Look good to me


Ignoring files for testing

Excludes unnecessary files from redist package. The average user does
not need tests in the package. They need developers.
About README.md and LICENSE:

Certain files are always included, regardless of settings:

package.json
README (and its variants)
CHANGELOG (and its variants)
LICENSE / LICENCE

Hi @mrmlnc, thanks!


Incorrect chunk matching with netconf 1.1 (and ## in output)

Hello,
I have an issue while reading a device config, using a simple GetConfig("running"): the output returned by Result is truncated.
Looking further, It's truncated here:
<next-hops>
         <next-hop>
          <index

The original data returned by the device is visible in the logs:
      <next-hops>
         <next-hop>
          <index>##<IP_ADDRESS>##</index>

We can see that the output is truncated at the ## character.
I think the issue lies with the record1dot1() function (since the router is using netconf 1.1),
In particular,
chunkSections := patterns.v1dot1Chunk.FindAllSubmatch(r.RawResult, -1)

is cutting the final chunk at the <index>  tag.
I can see with the debugger that the final chunk has length 45100, but it's size should be 106234. This sets the r.Failed (which I didn't notice before investigating this issue).
I therefore think that the v1dot1Chunk is wrong. A chunk on my device looks like this:
#106234
  <netconf-yang xmlns="http://cisco.com/ns/yang/Cisco-IOS-XR-um-netconf-yang-cfg">
   <agent>
    <ssh/>
   </agent>
  </netconf-yang>

and the pattern is v1dot1Chunk: regexp.MustCompile(`(?ms)(\d+)\n(.*?)#`),.
I had success on this router by changing the pattern to (?ms)(\d+)\n(.*?)^#, but I don't know if it breaks other things.

@netixx looks like this is on XR
do you have other routers to try your fixed pattern with?

I am like... 99% sure this was set this way for a reason... but of course I dont remember what that reason is anymore 😂
I wonder if something like (?ms)(\d+)\n(.*?)^\s?# would at least be a bit "safer", as in less strict, so hopefully less possibility of breaking things. I wonder also if we could do it more like scrapli python where we simply find the chunk sizes with a regexp then slice out that amount of characters. I feel like I thought this regexp way was an improvement, but maybe I was wrong!
In any case, for this, I'm quite happy to defer to the two of ya'll since I dont do anything with netconf at this point and have no real way to test other than the small clab setup I have (that of course passes as is or I would have changed things!).
Thoughts?

I can check the proposed regexp on SR OS and likely on Arista.
Will defer to @netixx for Jun and Cisco

I don't have a juniper that supports netconf 1.1.
From what I gather from https://datatracker.ietf.org/doc/html/draft-ietf-netconf-rfc4742bis#section-4.2, the chunk delimiter should always be on a line on it's own (somethink like \n#(\d+)\n).

From what I gather from https://datatracker.ietf.org/doc/html/draft-ietf-netconf-rfc4742bis#section-4.2

Hehe, yeah I mean... 100% agree with you... but I tend to take the rfc like speed limits -- a suggestion -- so would be great to test as much as we can before updating things! whatever we decide I will run all the tests against clab so we will have at least covered a good chunk of the most common stuff.
*I obviously never speed, that would be illegal and bad! 😅


Make HEVC files correct framerate

Saved road facing camera hevc files are saved at 50FPS, but should be 20FPS

probably somewhere in here https://github.com/commaai/openpilot/blob/master/selfdrive/loggerd/encoder.c

Just linking this here in-case somebody from the future is trying to see what's up with VLC and wondering why repro isn't happening.
https://trac.videolan.org/vlc/ticket/22681#comment:1
GitHub View of commits mentioned:
https://github.com/videolan/vlc/commit/fe88719c808cda0e91fd4d3da5c67218cb3e73f5
https://github.com/videolan/vlc/commit/f851387a45c3147e13437765206f0dca179f2c4a

Err, there isn't really a way to do this. There's not a wrong frame rate, there's no frame rate, so it becomes the player default. The hevc files are not in a container, adding one would change the format, so will not fix.


Update GCM to 9.8+  issue #1319

Old gms:play-services-gcm:9.0.2+ will crash the app if you update your Google Play Services to the lastest version
Description
Change
gms:play-services-gcm:9.0.2+
To
gms:play-services-gcm:9.8.+
Related Issue
https://github.com/phonegap/phonegap-plugin-push/issues/1319
Motivation and Context
Make the dependency up to date
How Has This Been Tested?
Tested with Android 6.0.1 / Nexus 7
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@macdonst I'll merge this so that people have the master to use for testing.
@hung-doan Thanks for doing this!

Thanks to both @hung-doan and @fredgalvao, I was traveling last week speaking and ended up catching the flu. I'm just starting to feel like myself. I'm going to let people respond to the merge on master then bump a new release.


Scripting convenience

Please have a look at the individual commit messages for the details.

This change is

Merging despite the unrelated AppVeyor failure.


[FOOTER] - Enhance the privacy and policy page with more enhancements

hi @thecuriousteam i'd love to work on this!

I would like to work on this . Please could you assign me this issue under GSSOC'24

@Kalyan9064 you can start working on this
Instructions
You can start working on it by taking latest pull from main branch

[ ] Please raise pull request to main
[ ] Please read the contributors guidelines Contributing Guidelines.
[ ] Please follow the code of conduct Code Of Conduct
[ ] Don't Forget to join onboarding group for knowledge flow and direct conversation and support from admins
[ ] Link Curious Developers Community - Curious Connect
[ ] Please attach the screenshots and video of the development work once it is done
[ ] Contributions more than 3 will be awarded a certificate of appreciation from curious ecosystem
[ ] please mail to<EMAIL_ADDRESS>for claiming certificate and please attach your issue number

if any help required reach-out to admins or mentors in the onboarding group default meeting link and approach to admins - GOOGLE MEET Issue Discussion Google Meet
Respect Co Developers And Please Reach-out to admins if any issues

Assign to me this for privacy policy page i can make it more enhanced

@alpharsh you can working on it brother

Subject: Enhancement of Privacy and Policy Page
Hello @thecuriousteam ,
I hope this message finds you well. I wanted to bring to your attention the recent enhancements made to our Privacy and Policy page.
Before

After

Previously, the information was presented in a plain text format. Now, I've implemented an accordion-style layout, making the page more user-friendly and easily navigable. Users can now access the information they need with greater ease, enhancing their overall experience on our platform.

privacy policy section enhancement has been done please review @thecuriousteam

My name is Harshwardhan Singh Panwar and I'm a contributor at GSSOC'24 .
idea:- By incorporating div CSS and animations, I can design the UI in an interactive manner, making it visually appealing.
Please assign this task to me, GSSOC'24 .

I love to work on that

brother
]


pallet-mmr: Discuss reducing the number of methods in runtime API and RPC API

Since we're changing the pallet-mmr runtime & RPC APIs as part of #12339 it's a good opportunity to revisit some other decisions related to the API:

Whether we should have 2 separate methods generate_batch_proof() and generate_historical_batch_proof(). Since in the end generate_batch_proof() is a special case of generate_historical_batch_proof(). See the discussion here: https://github.com/paritytech/substrate/pull/12324#discussion_r976692621
If we should keep generate_proof(), verify_proof(), and verify_proof_stateless() since all these can be done via batching methods (e.g. generate_batch_proof(), etc)

cc: @acatangiu @Lederstrumpf  @svyatonik

I agree with this, but drop "batching" or "historical" from new "universal" API name, should be simple generate_proof(), verify_proof(), and verify_proof_stateless() with optional extra params.
Documentation should also be very clear to explain specific param combinations.

I agree with unifying all, but drop "batching" or "historical" from new "universal" API name, should be simple generate_proof(), verify_proof(), and verify_proof_stateless() with optional extra params.
Documentation should also be very clear to explain specific param combinations.

ditto: I support unification, and if unified, then batching & historical qualifiers are superfluous and should be dropped.

Sounds good ! I also agree with these naming scheme.


Tune the background fetcher

Is your feature request related to a problem? Please describe.
https://github.com/awslabs/soci-snapshotter/pull/214 adds a background fetcher that will download spans over time, even if they are not requested by a synchronous file read. The fetcher has a few tunable parameters:
// SilencePeriodMSec defines the time (in ms) the background fetcher
// will be paused for when a new image is mounted.
SilencePeriodMSec int64 `toml:"silence_period_msec"`

// FetchPeriodMSec specifies how often a background fetch will occur.
// The background fetcher will fetch one span every FetchPeriodMSec.
FetchPeriodMSec int64 `toml:"fetch_period_msec"`

These are set arbitrarily to try to balance downloading all the data quickly to reduce the dependency on the network and not downloading so quickly that it competes with synchronous accesses in terms of CPU/Network/SOCI lock contention.
Describe the solution you'd like
We should run some experiments while changing these parameters to see how it affects the overall performance of the snapshotter. The benchmarking framework might be a good place for this. The outcome should be a reasonable set of deafult values/recommendations for these parameters.
Describe alternatives you've considered
This type of tuning might be dependent on how exactly the snapshotter is being used across multiple containers and so our tuning could end up being overly aggressive in a real world scenario. It might only make sense to do this sort of tuning by the consumers of the snapshotter.
Additional context
N/A

It would be great the snapshotter can decide the values. It knows how busy the FUSE part is and has access to host-level information such as CPU utilization.

I think you're probably right, but designing and implementing a dynamic background fetcher seems like a much larger task. I think this is decent intermediate goal. What do you think?

Yeah. We should pick okay-enough defaults. But we shouldn't try too hard to find the best defaults.

TL;DR: +1.
Performance is a non-goal for the background fetcher; it is an availability feature.  It exists to achieve one thing: To close the window where a new container failure mode is possible (due to a network issue, or other problem that could cause lazy loading to fail). As such, background fetching should be very conservative, since the priority is to make sure that it does not interfere with operations that are performance related.
To echo what @kzys said, the background fetcher is in the best position to know what else is going on in the system, and to throttle itself accordingly. That's why it's implemented as a singleton. And to echo what @Kern-- said, that's a harder problem than tuning some default. But it is the right problem to solve.


add scipy sparse support to lime explainer

This is the initial PR to add scipy sparse support to LIME explainer.
Please see this issue for design discussion:
https://github.com/marcotcr/lime/issues/335

gentle ping @marcotcr

Thanks!

I made a small change before merging, I think there was a bug. Let me know if I was mistaken.

hi @marcotcr ,
Thank you for merging the commit.
I think part of your commit is fine and is functionally equivalent to my previous code:
            fnames = [self.exp_feature_names[i] for i in self.feature_indexes]
            fweights = [weights[i] for i in self.feature_indexes]
            out_list = list(zip(fnames,
                                self.feature_values,
                                fweights))

however, I'm not sure about this specific part:
            if not show_all:
                out_list = [x for x in out_list if x[2] != 0]

While you can do this, it is not functionally equivalent to the dense code, because the dense code uses "x in exp" which is sorted by weight after going through feature selection:
https://github.com/marcotcr/lime/blob/master/lime/lime_tabular.py#L102
out_list = [out_list[x[0]] for x in exp]

In the dense version we get the most important features ordered by weights due to feature selection.  Now in the sparse case, with the new commit, we are not using the sorted order, if I am reading the code correctly.  Let me double-check in the debugger.

Looking at the debug, it looks like the code I wrote wasn't correct because it wasn't zipping the values properly.  The new code isn't correct also because it is not sorting the values by importance like the dense case.

@marcotcr I've created another PR to fix the ordering of values for sparse case here:
https://github.com/marcotcr/lime/pull/349
thanks for finding the issue!


[BUG]: Compiling nanobind master branch on musllinux result in error: 'nullptr_t' has not been declared

Problem description
Compiling nanobind master branch on musllinux result in error: 'nullptr_t' has not been declared. This seems to be a regression.
Github action log: https://github.com/laggykiller/apngasm-python/actions/runs/8060668383/job/22017067643#step:4:4735
Reproducible example code
No response

Done git bisect, b3c483edbfe729c1064c3ec1758de3c8ff0ad458 is the first bad commit

Thanks!

It's not solved yet: https://github.com/laggykiller/apngasm-python/actions/runs/8063189658/job/22024496317#step:4:1

oops, try again please.

Can confirm that it is properly fixed, thanks!


Redo FFI bindings using rust-bindgen and move them into a unique portaudio-sys crate along with the build script.

Many users have been experiencing issues with the bindings, particularly with the Linux ALSA backend. As the ffi.rs module was written by hand quite a while ago, there's a chance that some error might have been introduced due to human error. By generating the bindings using rust-bindgen we can have higher assurance that the struct layouts are correct and that we aren't missing bindings to any parts of the API.
By moving the bindings into their own crate portaudio-sys we can isolate FFI related issues and hopefully achieve slightly faster compilation. We could also move the build script into this crate in order to keep rust-portaudio clean and focused on the rust-esque abstractions, while portaudio-sys takes care of building the C portaudio lib and FFI. All bindings to platform-specific extensions could be done in this crate also.
#128, #136 and #133 may be related.

I guess this can be marked as resolved now due to merging #152 .

Almost, I just realised we won't be able to publish the changes without first publishing the portaudio-sys crate. I believe that in order to publish using cargo, all dependencies must also be on crates.io. I'd publish it as portaudio-sys, however it already exists.
Our options are:

Publish our generated bindings under a different name like rust-portaudio-sys.
See if we can use the existing portaudio-sys crate. If they too used rust-bindgen, then I imagine their bindings may almost be identical.

I think option 2 would be nice to avoid more fragmentation and share the maintenance burden, however they don't have a linked repository on crates.io so I'm unsure how easy it would be to collaborate or add patches if we need them.

For reference, the bindgen command I used is here and everything after /* automatically generated by rust-bindgen */ is untouched.
I gave a quick look at portaudio-sys, I’d say it is less like the default output. Might be because of different parameters, a couple of manual edits, or they used an older version of bindgen. The biggest difference is the use of libc.
I don’t remember why I constified some enums exactly, because of the way error codes are handled maybe.
To answer a previous message, libc is still used by Buffer in stream.rs which needs malloc and free.

I just found the other repo. @mitchmindtree I definitely agree that sharing the burden and preventing fragmentation is reasonable but i can't estimate whether it's a lot of work to integrate the other bindings. I think it might turn out to as much afford as #152. @cdghibaudo what do you think?

Just thought about it again. Isn't it maybe better to just make our portaudio-sys an internal module (not a seperate crate).
Basically I think the bindgen generated part shouldn't be edited at all, to make sure that no ffi-related bugs occur. Since the ffi shouldn't change noone would have to maintain the ffi.
Furthermore if we would do edit the ffi for some reason we would not have to watch out for compability with portaudio-rs.

Yeah i agree this sounds like the best/simplest option :+1:
On Fri, 26 May 2017 19:22 joeschman<EMAIL_ADDRESS>wrote:

Just thought about it again. Isn't it maybe better to just make our
portaudio-sys an internal module (not a seperate crate).
Basically I think the bindgen generated part shouldn't be edited at all,
to make sure that no ffi-related bugs occur. Since the ffi shouldn't change
noone would have to maintain the ffi.
Furthermore if we would do edit the ffi for some reason we would not have
to watch out for compability with portaudio-rs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RustAudio/rust-portaudio/issues/137#issuecomment-304234884,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEX_bWB6_GvFKWO6MfCrz_AFrPjBBb09ks5r9pnDgaJpZM4Ii-wm
.

I agree, it isn’t much of a burden.

I came here following from https://github.com/RustAudio/rust-portaudio/issues/128 because I'm facing the same issue I think. Wondering whether this discussion was concluded.


issue while installing with npm

Hi,
I was interesting to test your work within a npm install. As such I did
npm install --save  https://github.com/svrcekmichal/react-sketchpad
Because of the .npmignore the .src was not included, as then the import of Sketchpad did not work.
Any reason why this src directory was not included ?

@gilles747 you can use npm i -S react-sketchpad to install it. Hope it helps.


Matchers section is missed in ContractVerifierTest

I'm use 2.0.1.RELEASE.
I have response body
[
  {
    "id": "00000bb0b000b00000b0b000",
    "name": "Admin test project 1"
  },
  {
    "id": "11111bb1b111b11111b1b111",
    "name": "Admin test project 2"
  }
]

My contract in yaml
request:
  method: GET
  url: /projects
  headers:
    Content-Type: application/json;charset=UTF-8
response:
  status: 200
  headers:
    Content-Type: application/json;charset=UTF-8
  matchers:
    body:
      - path: $[0].id
        type: by_regex
        value: "[0-9a-z]{24}"
      - path: $[1].id
        type: by_regex
        value: "[0-9a-z]{24}"

The generated ContractVerifierTest don't has matchers part
        // given:
            MockMvcRequestSpecification request = given()
                    .header("Content-Type", "application/json;charset=UTF-8");

        // when:
            ResponseOptions response = given().spec(request)
                    .get("/projects");

        // then:
            assertThat(response.statusCode()).isEqualTo(200);
            assertThat(response.header("Content-Type")).isEqualTo("application/json;charset=UTF-8");

It will be good if matchers section will be generated even if no body section, since in this situation I have anonymous array with dynamic data that can't be verified in body section.

Nope, body is mandatory. There's no reason why you shouldn't provide the response body when you require matchers for it

@marcingrzejszczak Ok, please can you recommend what to put in the body section for described response body?

[
  {
    "id": "00000bb0b000b00000b0b000",
    "name": "Admin test project 1"
  },
  {
    "id": "11111bb1b111b11111b1b111",
    "name": "Admin test project 2"
  }
]

This trough file or there way to specify it in yaml directly?
Also id's here is dynamic, name is static, I run service with full context initialization.

Have you read the docs? https://cloud.spring.io/spring-cloud-static/Finchley.SR1/single/spring-cloud.html#spring-cloud-contract-verifier-intro-three-minute-tour-producer
Id will be dynamic for test side, not the stub side?

Have you read the docs? https://cloud.spring.io/spring-cloud-static/Finchley.SR1/single/spring-cloud.html#spring-cloud-contract-verifier-intro-three-minute-tour-producer
Yes I have read that part and it's not cover my situation with anonymous array.
I still not understand how to add my static names in body section from two entities(since I have array).

This contract does not generate the java file:
(By the way no errors was throung during running of spring-cloud-contract:generateTests)
request:
  method: GET
  url: /projects
  headers:
    Content-Type: application/json;charset=UTF-8
response:
  status: 200
  headers:
    Content-Type: application/json;charset=UTF-8
  body:
    - "name": "Admin test project 1"
    - "name": "Admin test project 2"
  matchers:
    body:
      - path: $[0].id
        type: by_regex
        value: "[0-9a-z]{24}"
      - path: $[0].userId
        type: by_regex
        value: "[0-9a-z]{24}"
      - path: $[1].id
        type: by_regex
        value: "[0-9a-z]{24}"
      - path: $[1].userId
        type: by_regex
        value: "[0-9a-z]{24}"

Id will be dynamic for test side, not the stub side?
Id will be dynamic on the producer side, also possibly consumer will put some dynamic id's too.

@Hronom you would just have to add ids (correct ones, that could be used in the stubs) in the body section for all entries - during the tests, the response will be tested against the provided matchers and not the explicit values from the body.
@danhyun it's required so that we take the values from the body directly to stubs, rather than having to generate all the values based on matchers during stub generation.

As a Spring user I'm accustomed to enjoying sane defaults out of the box but always have an ability to get the exact behavior I need when I need to, even to my own detriment because of external factors I can't change.
I was hoping spring cloud contracts would fit closer to this model since it's valuable enough to use but painful enough with all of these limitations that I'm on the verge of making my own fork because I feel my use cases are being explained away as bad user behavior.
I don't think my use cases are unique or uncommon as demonstrated by other users reporting similar points of confusion/frustration.

Let me get this straight. You're saying that the fact that you have to provide an element of the body is a limitation that pushes you to fork the repo?
We would have to rebuild the whole structure of e.g. a JSON by looking at the regex the user provides. What if the regex has a * on a json path. How will we rebuild that structure?
What other limitations are there that push you to forking the repo?
Also, since it seems that you have the motivation to work on this, please go ahead and file a PR with the feature you're requesting. We would be more than happy to discuss it with you there and wiem on it so that our community is satisfied.

Let me be perfectly clear that I don't want to fork this project, I've been feeling hopelessly frustrated.
My current experience working with spring cloud contracts has been a mix of pain and pleasure.
When I voice my frustration in the form of GH issues or on Twitter the typical responses I receive are in the form of "you're doing it wrong".
Some examples:
https://github.com/spring-cloud/spring-cloud-contract/issues/738#issuecomment-425594993
https://twitter.com/MGrzejszczak/status/1082373049788350464
https://github.com/spring-cloud/spring-cloud-contract/issues/866#issuecomment-462847000
If I'm doing it wrong then I'm abusing the product and my use cases are not common with other users of this product.
Any support for features/bug fixes/ergonomic issues that I encounter:

Support for data table driven stub generation
Ability to provide matchers without providing static matchers
Ability to reference request/response information in dynamic matchers especially within Regex type matchers

Will not benefit other users.
While I do have motivation to incorporate these features/fixes it should be noted that it's out of frustration of feeling unheard.
I would be doing this out of anger and at the expense of reduced productivity and active development of projects that rely on cloud contracts to be more ergonomic to my use cases.

While I do have motivation to incorporate these features/fixes it should be noted that it's out of frustration of feeling unheard.

@danhyun you are heard. If there are more users that are interested in those kind of solutions that you mentioned we will think of putting it into our backlog.
Until then try using the tool in the way we suggest to use it and then for sure your frustration will be lower.

@marcingrzejszczak hello, well my opinion about spring-cloud-contract its good project without alternatives(right now) but my feeling same as @danhyun. I was trying to integrate this framework in our company to make better flow with microservices, but it seems like there no description about workflow recommended by spring-cloud-contract.
And spring-cloud-contract very strict about some abstract workflow(the true way of spring-cloud-contract)
It will be cool if you write somewhere in spring blog about desired by spring-cloud-contract workflow. There you describe complete workflow of how two microservices goes from code to prod with your tool.
BTW
Back to initial issue, I can't understand why spring-cloud-contract not throws errors if usage of matches without static body not acceptable. Just throw error about this and you will don't have such questions.
If you don't throw error then put this matches in the ContractVerifierTest:
      // given:
            MockMvcRequestSpecification request = given()
                    .header("Content-Type", "application/json;charset=UTF-8");

        // when:
            ResponseOptions response = given().spec(request)
                    .get("/projects");

        // then:
            assertThat(response.statusCode()).isEqualTo(200);
            assertThat(response.header("Content-Type")).isEqualTo("application/json;charset=UTF-8");

This will at least verify producer and obliviously not putted to stubs since it's too generic.
Otherwise, this is bug!

I was trying to integrate this framework in our company to make better flow with microservices, but it seems like there no description about workflow recommended by spring-cloud-contract.

I don't think I can agree with this statement:

https://spring.io/projects/spring-cloud-contract under Spring Boot Config
https://cloud.spring.io/spring-cloud-static/Greenwich.RELEASE/single/spring-cloud.html#_how_it_works
http://cloud-samples.spring.io/spring-cloud-contract-samples/workshops.html#_tasks

It will be cool if you write somewhere in spring blog about desired by spring-cloud-contract workflow. Where you describe complete workflow of how two microservices goes from code to prod with your tool.

We will be working on the documentation to make things more visible.

Back to initial issue, I can't understand why spring-cloud-contract not throws errors if usage of matches without static body not acceptable. Just throw error about this and you will don't have such questions.

Good point. Can you file an issue please?

Good point. Can you file an issue please?
Please can you use this issue?

I've created the issue myself https://github.com/spring-cloud/spring-cloud-contract/issues/891


Minimum separator character

Not sure if this question makes sense and it may also be machine-dependent, but I'm wondering if there is a delimiter char I can use to separate words in the input to libdivsufsort so that this char will sort less than any of the characters in my text (the usual ascii set) and thus not otherwise affect the order of the suffix array ?

What you want is called a generalized suffix array in literature. Libdivsufsort is by now fairly old, unmaintained and not state of the art. Pretty sure you will find software better suited for your job.
That said libdivsufsort is machine independent and will simply sort an array of unsigned 8 bit integers. So can simply use the 0 value as a seperator if it does not appear anywhere in your strings. (Haven't looked at the code in quite some years. Might be the case that you have to use 1).

I assume you mean ascii 0 (NUL) rather than ascii 48 (0)... That was the first thing I tried, but got some strange results. I'll try next with ascii 1. Any pointers to a library for a generalized suffix array would be great too. Thanks.

Hi Daniel. You could try gsufsort: https://github.com/felipelouza/gsufsort
Best regards.
On Thu, Jul 25, 2024 at 11:36 AM Daniel Howe @.***>
wrote:

I assume you mean ascii 0 (NUL) rather than ascii 48 (0)... That was the
first thing I tried, but got some strange results. I'll try next with ascii

Any pointers to a library for a generalized suffix array would be great
too. Thanks.

—
Reply to this email directly, view it on GitHub
https://github.com/y-256/libdivsufsort/issues/28#issuecomment-2250490072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAPS7ZGSKMZJE5YYTQK6BXDZOEEO7AVCNFSM6AAAAABLNZV2YSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJQGQ4TAMBXGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Daniel Saad Nogueira Nunes

libdivsufsort does't know about ascii it sorts bytes independent of encoding that's why I wrote "value 0".
If you had issues with using zero then it might be that libdivsufsort treats them as string terminator. I haven't looked into the code since 2016 so ... no idea.