Packages are lost on WinBle.characteristicValueStream

I have an app where I have implemented flutter_blue_plus for Android and IOS  and  win_ble for Windows. So, via win_ble packages is being lost.
Look at the first value in arrays, it should be  incremented +1.
 On Android via flutter_blue_plus data is ok.
Please, could you fix this? win_ble is the only package that works on Windows...

#6 I'm also facing loss of data packets when streamed data from windows. were you able to find a workaround for this? or any other plugin that works

As @GorIvanov mentioned this is the only plugin that works for windows, would it be possible to resolve this issue. Would really appreciate it. @rohitsangwan01
Thanks

@GorIvanov @ext-danny can you try with https://github.com/rohitsangwan01/win_ble/pull/22 pr ?


focal scaling v.s. original focal loss

Hi,
Thanks for sharing the great repo! Could you explain what are the differences between the focal scaling and the original focal loss?
From the implementation here: ./detectron2/modeling/roi_heads/fast_rcnn.py#L630, seems like it is a special case of focal loss that alpha=1 and gamma=0.5.
Besides, why is the focal scaling effective in mitigating forgetting of concepts learned pertaining stage that contains a small number of categories?
Looking forward to your reply! Thank you!

Hi @Cogito2012, the focal scaling in our paper extends the key idea of original focal loss, that is, suppressing the confident predictions. In our training (using only base categories), the models tend to bias to those base categories, making the confidence scores high. Focal scaling makes our model less biased to these training samples and thus reduces the forgetting.


Create RemoveDuplicatesFromSortedArray.cpp

If you close the PR then I cannot and will not merge it to main in simple words your PR is rejected by yourself and will not be counted.


ValidationAttribute should be extended

ValidationAttribute should be extended not implemented, it's an abstract class not an interface

Good catch, thanks!


docs(intro): What is Krustlet?

While writing the announcement post, I noticed in the documentation that we don't have a section that explains Krustlet. The README goes into a little detail, but it'd be great to have a section in the introductory material that answers the question "what is Krustlet, and how is it relevant to my interests?"

hm... and "how this project keep compatibillity with k8s/upstream?"

In what way?

In what way?

In anyway :) So we will not keep compatibillity ?

I'm still not fully sure what you're trying to get at here, @k82cn.


JSONB fragment

Environment

Elixir version (elixir -v): 1.6.1
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): Postgres 9.6.1
Ecto version (mix deps): 2.1.6
Database adapter and version (mix deps): 0.13.4
Operating system: MacOS 10.12.4

Current behavior
workout.details is a JSONB field with a shape like {"movements": [{"id": 2}]}
Interpolating by a fragment in a JSONB query fails:
 movement_id = 2
 from wo in Workout,
        where: fragment(~s(?#>'{movements}'@>'[{"id": ?}]'), wo.details, ^movement_id)

Error: invalid input syntax for type json
A direct SQL query works:
SELECT *
FROM workouts
WHERE workouts.details#>'{movements}'@>'[{"id":2}]'

I have also tried
json = ~s('[{"id": #{movement_id}}]')
from wo in Workout, where: fragment(~s(?#>'{movements}'@>?), wo.details, ^json)

Which runs successfully, but incorrectly returns no results.
Hardcoding the id works as expected:
 from wo in Workout,
        where: fragment(~s(?#>'{movements}'@>'[{"id": 2}]'), wo.details)

You can't put value placeholders inside of strings in fragments. All the database will see is string with ? (or $n) inside of it - it won't know it has to interpolate into that string.
A solution is to build the whole json value on the elixir side:
 movement_id = 2
 from wo in Workout,
   where: fragment(~s(?#>'{movements}' @> ?), wo.details, ^[%{id: movement_id}])


Make wide tables horizontally scrollable, revert special  handling

This supersedes and closes #66, see also #61.
This restores the <img> handling of the basic theme, making images behave like in most themes.
This has the disadvantage that images that are heavily scaled up (with :scale:) will become distorted.
This is bad, but I don't know a good solution, and all Sphinx themes seem to have that same problem.
Rendered:

https://insipid-sphinx-theme--68.org.readthedocs.build/en/68/showcase/tables.html#large-table
https://insipid-sphinx-theme--68.org.readthedocs.build/en/68/showcase/images.html#scaled-image

Cool, thanks, it does indeed work

I've tried an alternative solution in #105.
This avoids the JavaScript manipulations but makes all tables left-aligned instead of centered.
What do you think about that?

Cool, so we can avoid JavaScript altogether.
As you said, tables are now left aligned instead of centered, but I think this fits well with the theme.


font-weight ignored unless font is passed

Currently, if you create a <text> element with no font attribute, any other supported font modifier will be ignored:
<text font-weight="bold">Hello, world!</text>

However, the following works:
<text font="body" font-weight="bold">Hello, world!</text>

Also, the medium weight is missing.

I believe we intend to remove attr modifiers in favor of the modifier syntax from #52

In other words, we want a single lane for functionality rather than two. The attr style was the original idea and I like it but once we go more than one level deep it falls apart.

Ok, makes sense, especially since the font-related modifiers can apply to any View, not just Text. I'll close this and the PR.


multiple enties, each entry has its own chunkLoadingGlobal

Feature request

What is the expected behavior?
multiple enties, each entry has its own chunkLoadingGlobal，example "webpackChunk_[entryName]"。
What is motivation or use case for adding/changing the behavior?
my application is loaded by qiankun, main application and child application has same chunkLoadingGlobal cause scope conflict
How should this be implemented in your opinion?
no idea
Are you willing to work on this yourself?
yes

That is expected, you can use optimizations.runtimeChunk to extract this into own chunk https://webpack.js.org/configuration/optimization/#optimizationruntimechunk. You have multi compiler mode please set the name option


feat(notification-manager): added new offset property

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.009%) to 84.497%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
9383

Relevant Lines:
10270

💛  - Coveralls


fluxcd: 0.40.1 -> 0.40.2

fluxcd: 0.40.1 -> 0.40.2
Release: https://github.com/fluxcd/flux2/releases/tag/v0.40.2
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 218828 run on aarch64-darwin 1

1 package built:

fluxcd


Flutter development workflow: conventional commits

The case is quite simple: https://www.conventionalcommits.org/en/v1.0.0/

There are some public GitHub repositories (like ESLint) using conventional commits workflow, personally I like it too.
I see many people using feat, chore, bug prefixes for their commit messages on GitHub.
There are some tools which allow to validate commit messages against conventional commits standard and tools to generate change log.

What do you think about following this formal specification for git commit messages for Flutter repository?

Really need this to enforce.. can't find any conventional commit setup like husky + commitlint + standard version at node.js
with those conventional commit, I also able to manage my change-log file

Really need this to enforce.. can't find any conventional commit setup like husky + commitlint + standard version at node.js
with those conventional commit, I also able to manage my change-log file

I'm going to close this issue. If someone on the team wants to argue for this process change, we should start from a design doc and discuss it in the Discord.


Fix article loading on direct link to wiki

This PR allows direct links to wiki articles using the freecodecamp domain load the appropriate page from the wiki. This does not however update the URL when the wiki page changes.
Originally I was going to include that logic here as well, but it looks like that might be more involved, so I'll submit it as a separate PR .

Live on beta!

@BerkeleyTrue I was testing this out and I couldn't seem to get the URLs to navigate to the specific wiki articles. For example, I tried https://beta.freecodecamp.com/wiki/Epilogue and it just navigated me to a blank page.
Am I understanding this PR correctly? Could you give me an example URL that should work?

@QuincyLarson You need to add the language in the url.


Resetting Existing Users to reset Password

I have started using  devise_security_extension gem specifically (:secure_validatable) feature but I have found 1 problem in gem . Basically users who have signed up before I have installed this gem may have password which does not fulfill strong password criterion , So is there any extension in this gem by which i can redirect users which have invalid password to the "reset password" page??

You can just do this using a before_filter.  Here's the basic steps.
Add an attribute to your user model that can be used to track whether or not a user needs to reset their password:
class AddRequirePasswordResetToUsers < ActiveRecord::Migration
  def change
    add_column :users, :require_password_reset, :boolean, default: false
  end
end

In a base controller used for authenticated actions, setup a before_filter to check this new attribute:
class AuthenticatedController < ApplicationController
  before_filter :require_password_reset

  def require_password_reset
    if current_user && current_user.require_password_reset
      redirect_to edit_user_registration_path, flash: { warning: "Before you can continue, you must reset your password." }
    end
  end
end

Skip the filter for the actions that are needed to update the password:
class RegistrationsController < Devise::RegistrationsController
  # Don't force password resets on the actions we are using to allow the user to change their password
  skip_before_action :require_password_reset, only: [:edit, :update]
end

On your user reset the attribute, when the password gets updated:
class User < ActiveRecord::Base
  before_save :require_no_password_reset, if: Proc.new{ |user| user.encrypted_password_changed? }

  def require_no_password_reset
    self.require_password_reset = false
    true
  end
end

@steakchaser his solution seems valid, but it requires some changes. I faced the same situation and I think I solved it in a more elegant way. You can add devise :password_expirable.
I wrote a small rake script to update the password_changed_at for all exiting users to a date before the value defined in  config.expire_password_after = 3.months


Fix custom http client not being used when fetching related resources

I found this issue when I was first trying to fix strictSSL issues when fetching the WSDL, but initially worked around it with wsdl_options. However, since I will need to rewrite some urls on the fly, I need the full custom client to work when fetching the wsdl and all related resources.
_socketStream.js can also be used to clean up client-customHttp-test, on which I based my test (which is why I put it in a separate file).
In summary: a 1 line fix, with 208 additional lines of test code. :beers:

Coverage increased (+0.004%) to 92.183% when pulling 6ecbf3284282020b1d8ab53007297450dedb4522 on forivall:fix-customclient-link-download into 536025df67924299c299045cae4b0e4b8cab94d5 on vpulim:master.

Coverage increased (+0.008%) to 92.188% when pulling 4ba7c3e43ed7caddd93c6ab5d687602ee10c4339 on forivall:fix-customclient-link-download into 536025df67924299c299045cae4b0e4b8cab94d5 on vpulim:master.

@herom updated! My personal preference is braces when the body of the statement is on the next line, but I'm fine with following your style. JSCS / eslint would be great in communicating your preferences :+1:

Thanks a lot for your time & effort @forivall - we appreciate it a lot :+1:


Polish core module code

LGTM

test this please

I may be missing something, but what kinds of tests are necessary? This PR is about refactoring, and it does not add any new functions or something. I guessed it was okay simply if existing tests passed.


New UI:  and ~ view showing 404 for items with DRM

Describe the bug
Only happens in 2018.2
Seems to be an issue with the LegacyContent api
To Reproduce
Steps to reproduce the behavior:

Ensure the new ui is enabled
Contribute/publish an item that contains an attachment with drm
On the item summary page append  or ~ to the end of the url
You will see a 404 error

Expected behavior
XML for the item should displayed when  is appended to an item url
Platform:

OpenEquella Version: 2018.2
OS: windows 10
Browser [e.g. Chrome, Firefox]

Reopening, as this came up in support (discovered and reported by Carl, not by a client.)

@PenghaiZhang or @snehanaik22 , in your recent DRM work have you come across this issue? Is it still an issue?
Do we need @cathfitz to schedule it in?

Seems everyone (@PenghaiZhang , @snehanaik22 and @cathfitz ) missed my last comment on this one. I will follow up more directly.

Tested on 2022.1 and <XML> and ~ view work fine.


some minor fix for web hooks

Hi, thanks for this amazing lib!
This my modest and minor contribution... I need this to be able to use this lib with gitlab webhook.
Have a nice day

Thanks @manland!


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.35 to before v4.14.255",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=f931551bafe1f10ded7f5282e2aa162c267a2e5d",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=60833707b968d5ae02a75edb7886dcd4a957cf0d"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "f931551bafe1f10ded7f5282e2aa162c267a2e5d",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "60833707b968d5ae02a75edb7886dcd4a957cf0d",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.255 by commit 60833707b968d5ae02a75edb7886dcd4a957cf0d, it was introduced in version v2.6.35 by commit f931551bafe1f10ded7f5282e2aa162c267a2e5d. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001964


Improve the readme

Hello.
I recently introduced rubydnn on reddit.
The reddit comment was "improve the documentation".
I'm not an engineer or a programmer.
I don't really understand deep learning / neural networks.
But, I think the concept of ruby-dnn is nice.
Please brush up the README. This will encourage many people to use it.
I think the following list is useful.
https://github.com/matiassingers/awesome-readme
Flux.jl
https://github.com/FluxML/Flux.jl
Reddit
https://www.reddit.com/r/ruby/comments/bwnely/rubydnn/

Hello.
Thank you for issue report.
I will in the README, add the example of MNIST in MLP and the list of implemented Layers and Optimizers.
Currently, I am making a version 0.10.0.
So,  When I update to version 0.10.0, add them.

How about adding CI badge?

.travis.yml already exists in the repository. Is setup completed?

I want adding CI badge.
However, I don't know travis CI well.
(The repository on .travis.yml remains as automatically generated by the bundle gem command)
So I need to learning more about it.
Therefore it'll take some time.

Okay. It's easy to set up. Just log in and press a few buttons.

Added CI batch.
README is still insufficient, but I will add the contents in the future.


Double Dash in a "INTRO BLURB" Field Is Not Expanded (Feature)

- Do you want to request a feature or report a bug?
Feature, I guess
- What is the current behavior?
Double dash (--) is expanded/replaced only in editor of BODY, but not inside editor of INTRO BLURB.
- If the current behavior is a bug, please provide the steps to reproduce.
Create new post and try to fill the fields accordingly.
- What is the expected behavior?
Double dash should be expanded in editors of both fields (and in title editor too!).
- Please mention your node.js, and operating system version.
One that is used by netlify when currently deployed.

@ilyaigpetrov The reason for this is that the body is a rich text editor, while the intro blurb is set to plain text. If you want the intro blurb to have the same behavior, you can set its type to markdown.

I don't think we should be doing any processing on the output of a plain text control, so I'm going to go ahead and close this. @ilyaigpetrov, @tech4him1's suggestion to set type: markdown on that widget in the config.yml will get you the behavior you want. Feel free to ask here or on Gitter if you need any further pointers on how to do that.


Rename *subText to *textSub

It seems that the JXT API has changed between 6.x and 7.x.
The JXT type functions in client.stanzas.utils mostly seem to resemble what can be seen here. There's a little irregularity in the naming: *subText should (according to all the other function names) be something like *textSub, so that it matches the predominantly used scheme given by other type functions, for instance, boolSub, dateSub, enumSub or numberSub.
This comprises:
multiSubText → multiTextSub
subLangText → langTextSub
subText → textSub
That is, unless there is a good reason for having two naming schemes or I'm missing out on something.
(Oh, and just out of interest: What is a "sub" anyway — a substitution?)

This would be an issue for https://github.com/otalk/jxt, but I agree.
client.stanzas.utils is just a JXT registry instance, so this will require bumping the major version for JXT first.
("sub" is just short for "sub-element")

I just updated to 7.0.6 and noticed that nothing broke for me. stanzas.utils now references both textSub and subText, langTextSub is not a property (but subLangText still is) and both multiSubText (old) and multiTextSub (new) are also properties. Did you mean to do this?


[Bug] Error when using LLAVA 1.5 for llava bench

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[X] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 5. Please use English, otherwise it will be closed.

Describe the bug
I want to follow https://github.com/sgl-project/sglang/blob/main/benchmark/llava_bench/README.md and perform batch inference on llava.
First I launch a llava v1.5 7b model from the local path using:
python3 -m sglang.launch_server --model-path /root/llm-project/utils/models/models-repo/llava-v1.5-7b --tokenizer-path llava-hf/llava-1.5-7b-hf --port 30000 --disable-cuda-graph
Every thing look fine:
[2024-11-23 20:21:11] server_args=ServerArgs(model_path='/root/llm-project/utils/models/models-repo/llava-v1.5-7b', tokenizer_path='llava-hf/llava-1.5-7b-hf', tokenizer_mode='auto', skip_tokenizer_init=False, load_format='auto', trust_remote_code=False, dtype='auto', kv_cache_dtype='auto', quantization=None, context_length=None, device='cuda', served_model_name='/root/llm-project/utils/models/models-repo/llava-v1.5-7b', chat_template=None, is_embedding=False, host='<IP_ADDRESS>', port=30000, mem_fraction_static=0.88, max_running_requests=None, max_total_tokens=None, chunked_prefill_size=8192, max_prefill_tokens=16384, schedule_policy='lpm', schedule_conservativeness=1.0, tp_size=1, stream_interval=1, random_seed=415803303, constrained_json_whitespace_pattern=None, watchdog_timeout=300, download_dir=None, base_gpu_id=0, log_level='info', log_level_http=None, log_requests=False, show_time_cost=False, enable_metrics=False, decode_log_interval=40, api_key=None, file_storage_pth='SGLang_storage', enable_cache_report=False, dp_size=1, load_balance_method='round_robin', dist_init_addr=None, nnodes=1, node_rank=0, json_model_override_args='{}', enable_double_sparsity=False, ds_channel_config_path=None, ds_heavy_channel_num=32, ds_heavy_token_num=256, ds_heavy_channel_type='qk', ds_sparse_decode_threshold=4096, lora_paths=None, max_loras_per_batch=8, attention_backend='flashinfer', sampling_backend='flashinfer', grammar_backend='outlines', disable_radix_cache=False, disable_jump_forward=False, disable_cuda_graph=True, disable_cuda_graph_padding=False, disable_disk_cache=False, disable_custom_all_reduce=False, disable_mla=False, disable_overlap_schedule=False, enable_mixed_chunk=False, enable_dp_attention=False, enable_torch_compile=False, torch_compile_max_bs=32, cuda_graph_max_bs=160, torchao_config='', enable_nan_detection=False, enable_p2p_check=False, triton_attention_reduce_in_fp32=False, num_continuous_decode_steps=1, delete_ckpt_after_loading=False)
Some kwargs in processor config are unused and will not have any effect: num_additional_image_tokens.
Some kwargs in processor config are unused and will not have any effect: num_additional_image_tokens.
[2024-11-23 20:21:21 DP-1 TP0] Automatically turn off --chunked-prefill-size and adjust --mem-fraction-static for multimodal models.
[2024-11-23 20:21:21 DP-1 TP0] Init torch distributed begin.
[2024-11-23 20:21:21 DP-1 TP0] Load weight begin. avail mem=38.97 GB
[2024-11-23 20:21:22 DP-1 TP0] lm_eval is not installed, GPTQ may not be usable
Loading pt checkpoint shards:   0% Completed | 0/3 [00:00<?, ?it/s]
/root/anaconda3/envs/sglang/lib/python3.10/site-packages/vllm/model_executor/model_loader/weight_utils.py:425: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
  state = torch.load(bin_file, map_location="cpu")
Loading pt checkpoint shards:  33% Completed | 1/3 [00:00<00:01,  1.43it/s]
Loading pt checkpoint shards:  67% Completed | 2/3 [00:29<00:16, 16.97s/it]
Loading pt checkpoint shards: 100% Completed | 3/3 [01:36<00:00, 39.92s/it]
Loading pt checkpoint shards: 100% Completed | 3/3 [01:36<00:00, 32.09s/it]

[2024-11-23 20:23:10 DP-1 TP0] Load weight end. type=LlavaLlamaForCausalLM, dtype=torch.float16, avail mem=25.72 GB
[2024-11-23 20:23:10 DP-1 TP0] Memory pool end. avail mem=6.28 GB
Some kwargs in processor config are unused and will not have any effect: num_additional_image_tokens.
[2024-11-23 20:23:12 DP-1 TP0] max_total_num_tokens=39590, max_prefill_tokens=16384, max_running_requests=4097, context_len=4096
[2024-11-23 20:23:12] INFO:     Started server process [169184]
[2024-11-23 20:23:12] INFO:     Waiting for application startup.
[2024-11-23 20:23:12] INFO:     Application startup complete.
[2024-11-23 20:23:12] INFO:     Uvicorn running on http://<IP_ADDRESS>:30000 (Press CTRL+C to quit)
[2024-11-23 20:23:13] INFO:     <IP_ADDRESS>:44342 - "GET /get_model_info HTTP/1.1" 200 OK
[2024-11-23 20:23:13 DP-1 TP0] Prefill batch. #new-seq: 1, #new-token: 7, #cached-token: 0, cache hit rate: 0.00%, token usage: 0.00, #running-req: 0, #queue-req: 0
[2024-11-23 20:23:15] INFO:     <IP_ADDRESS>:44354 - "POST /generate HTTP/1.1" 200 OK
[2024-11-23 20:23:15] The server is fired up and ready to roll!

Then I run the llava_bench using python3 bench_sglang.py --num-questions 60, an error occured:
The server side:
[2024-11-23 20:20:03] INFO:     <IP_ADDRESS>:52700 - "GET /get_model_info HTTP/1.1" 200 OK
[2024-11-23 20:20:03 DP-1 TP0] Prefill batch. #new-seq: 1, #new-token: 33, #cached-token: 1, cache hit rate: 2.44%, token usage: 0.00, #running-req: 0, #queue-req: 0
[2024-11-23 20:20:03] INFO:     <IP_ADDRESS>:52704 - "POST /generate HTTP/1.1" 200 OK
[2024-11-23 20:20:06 DP-1 TP0] Traceback (most recent call last):
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/managers/scheduler.py", line 1407, in run_scheduler_process
    scheduler.event_loop_overlap()
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
    return func(*args, **kwargs)
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/managers/scheduler.py", line 388, in event_loop_overlap
    self.process_input_requests(recv_reqs)
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/managers/scheduler.py", line 493, in process_input_requests
    self.handle_generate_request(recv_req)
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/managers/scheduler.py", line 556, in handle_generate_request
    req.origin_input_ids = self.pad_input_ids_func(
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/models/llava.py", line 67, in pad_input_ids
    num_patch_width, num_patch_height = get_anyres_image_grid_shape(
  File "/root/anaconda3/envs/sglang/lib/python3.10/site-packages/sglang/srt/mm_utils.py", line 173, in get_anyres_image_grid_shape
    possible_resolutions = ast.literal_eval(grid_pinpoints)
  File "/root/anaconda3/envs/sglang/lib/python3.10/ast.py", line 110, in literal_eval
    return _convert(node_or_string)
  File "/root/anaconda3/envs/sglang/lib/python3.10/ast.py", line 109, in _convert
    return _convert_signed_num(node)
  File "/root/anaconda3/envs/sglang/lib/python3.10/ast.py", line 83, in _convert_signed_num
    return _convert_num(node)
  File "/root/anaconda3/envs/sglang/lib/python3.10/ast.py", line 74, in _convert_num
    _raise_malformed_node(node)
  File "/root/anaconda3/envs/sglang/lib/python3.10/ast.py", line 71, in _raise_malformed_node
    raise ValueError(msg + f': {node!r}')
ValueError: malformed node or string: None

zsh: killed     python3 -m sglang.launch_server --model-path  --tokenizer-path  --port 30000

The python code (running bench_sglang.py) side:
uncher 58987 -- /root/llm-project/sglang/benchmark/llava_bench/bench_sglang.py
  0%|                                                                                | 0/60 [00:00<?, ?it/s]/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/lang/interpreter.py:339: UserWarning: Error in stream_executor: Traceback (most recent call last):
  File "/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/lang/interpreter.py", line 337, in _thread_worker_func
    self._execute(expr)
  File "/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/lang/interpreter.py", line 380, in _execute
    self._execute(x)
  File "/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/lang/interpreter.py", line 375, in _execute
    self._execute_gen(other)
  File "/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/lang/interpreter.py", line 502, in _execute_gen
    comp, meta_info = self.backend.generate(
  File "/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/lang/backend/runtime_endpoint.py", line 163, in generate
    res = http_request(
  File "/root/anaconda3/envs/llava/lib/python3.10/site-packages/sglang/utils.py", line 100, in http_request
    resp = urllib.request.urlopen(req, data=data, cafile=verify)
  File "/root/anaconda3/envs/llava/lib/python3.10/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
  File "/root/anaconda3/envs/llava/lib/python3.10/urllib/request.py", line 519, in open
    response = self._open(req, data)
  File "/root/anaconda3/envs/llava/lib/python3.10/urllib/request.py", line 536, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
  File "/root/anaconda3/envs/llava/lib/python3.10/urllib/request.py", line 496, in _call_chain
    result = func(*args)
  File "/root/anaconda3/envs/llava/lib/python3.10/urllib/request.py", line 1377, in http_open
    return self.do_open(http.client.HTTPConnection, req)
  File "/root/anaconda3/envs/llava/lib/python3.10/urllib/request.py", line 1352, in do_open
    r = h.getresponse()
  File "/root/anaconda3/envs/llava/lib/python3.10/http/client.py", line 1375, in getresponse
    response.begin()
  File "/root/anaconda3/envs/llava/lib/python3.10/http/client.py", line 318, in begin
    version, status, reason = self._read_status()
  File "/root/anaconda3/envs/llava/lib/python3.10/http/client.py", line 287, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

  warnings.warn(f"Error in stream_executor: {get_exception_traceback()}")
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 60/60 [00:03<00:00, 17.06it/s]
Latency: 3.821
Write output to answers.jsonl

Reproduction
Follow https://github.com/sgl-project/sglang/blob/main/benchmark/llava_bench/README.md
Environment
Python: 3.12.4 | packaged by Anaconda, Inc. | (main, Jun 18 2024, 15:12:24) [GCC 11.2.0]
CUDA available: True
GPU 0,1: NVIDIA A100-PCIE-40GB
GPU 0,1 Compute Capability: 8.0
CUDA_HOME: /usr/local/cuda-12.4
NVCC: Cuda compilation tools, release 12.4, V12.4.131
CUDA Driver Version: 550.107.02
PyTorch: 2.4.0+cu121
sglang: 0.3.6
flashinfer: 0.1.6+cu124torch2.4
triton: 3.0.0
transformers: 4.46.3
torchao: 0.6.1
numpy: 1.26.4
aiohttp: 3.9.5
fastapi: 0.115.4
hf_transfer: 0.1.8
huggingface_hub: 0.26.2
interegular: 0.3.3
psutil: 5.9.0
pydantic: 2.9.2
multipart: 0.0.17
zmq: 25.1.2
uvicorn: 0.32.0
uvloop: 0.21.0
vllm: 0.6.3.post1
openai: 1.54.3
anthropic: 0.39.0
NVIDIA Topology:
        GPU0    GPU1    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      PHB     0-7     0               N/A
GPU1    PHB      X      0-7     0               N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

ulimit soft: 1048576
I1123 14:38:57.196000<PHONE_NUMBER>48288 torch/_dynamo/utils.py:335] TorchDynamo compilation metrics:
I1123 14:38:57.196000<PHONE_NUMBER>48288 torch/_dynamo/utils.py:335] Function    Runtimes (s)
I1123 14:38:57.196000<PHONE_NUMBER>48288 torch/_dynamo/utils.py:335] ----------  --------------
V1123 14:38:57.196000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats constrain_symbol_range: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats evaluate_expr: CacheInfo(hits=0, misses=0, maxsize=256, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats _simplify_floor_div: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats _maybe_guard_rel: CacheInfo(hits=0, misses=0, maxsize=256, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats _find: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats has_hint: CacheInfo(hits=0, misses=0, maxsize=256, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats size_hint: CacheInfo(hits=0, misses=0, maxsize=256, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats simplify: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats _update_divisible: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats replace: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats _maybe_evaluate_static: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats get_implications: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.197000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats get_axioms: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)
V1123 14:38:57.198000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats safe_expand: CacheInfo(hits=0, misses=0, maxsize=256, currsize=0)
V1123 14:38:57.198000<PHONE_NUMBER>48288 torch/fx/experimental/symbolic_shapes.py:116] lru_cache_stats uninteresting_files: CacheInfo(hits=0, misses=0, maxsize=None, currsize=0)

It is not maintained anymore.
Please try newer llava v1.6/ llava next /llava onevision.
https://github.com/sgl-project/sglang/blob/main/examples/frontend_language/quick_start/local_example_llava_next.py
https://github.com/sgl-project/sglang/tree/main/examples/runtime/llava_onevision
https://github.com/sgl-project/sglang/blob/731146f6cbec40f502e16dc971a150ed46b207ad/test/srt/test_vision_openai_server.py#L31


Fix Go dependencies

https://github.com/stellar/go/pull/5084 broke the Go dependencies, because:

go mod tidy wasn't invoked before merging leading to a misaligned Go version in go.mod (we should probably enforce this in CI and make sure there are no diffs)
It ugraded github.com/creachadair/jrpc2 to 1.1.1 which requires Go 1.21 (breaking the two-Go-release compatibility guarantee we make)

I'm surprised you're saying that go mod tidy wasn't called. I did call that, and deployed 1.19 before doing that.
Also, if it broke the build, how come all the CI tests passed ?!

It wasn't, since otherwise it would had written 1.21 to go.mod

Also, if it broke the build, how come all the CI tests passed ?!

Because go updates go.mod when building

Also, if it broke the build, how come all the CI tests passed ?!

I never wrote it broke the build, it broke the two-Golang release policy. I guess CI works because Go updates go.mod when building with 1.21 (or does a best effort when using an earlier version)

that's a bit concerning. should we add a test to verify that the go.mod/go.sum doesn't get updated during the build ? i.e. so that it's only developer-driven ?

that's a bit concerning. should we add a test to verify that the go.mod/go.sum doesn't get updated during the build ? i.e. so that it's only developer-driven ?

Yes, I suggested that in the PR description:

we should probably enforce this in CI and make sure there are no diffs

I guess CI works because Go updates go.mod when building with 1.21

This is surprising. Go since version 1.16 has not updated the go.mod automatically.
In the release notes for Go 1.16 it says:

Build commands like go build and go test no longer modify go.mod and go.sum by default. Instead, they report an error if a module requirement or checksum needs to be added or updated

Ref: https://go.dev/doc/go1.16
This was strengthened in Go 1.18 with additional commands being changed to not modify go.mod:

Automatic go.mod and go.sum updates
The go mod graph, go mod vendor, go mod verify, and go mod why subcommands no longer automatically update the go.mod and go.sum files. (Those files can be updated explicitly using go get, go mod tidy, or go mod download.)

Ref: https://go.dev/doc/go1.18
I think something else is probably happening.


Align dlib v2

Added align_v1 and align_v2 to AlignDlib class and added --version argument to align-dlib script, defaults to 2.

Btw I fixed the problem you were having with some of the images,  the I had the width and height mixed up :) Oops!
It's fixed now though, and will work on all size images. Its still slower than the cv version, but the results are clearly better.

Btw I fixed the problem you were having with some of the images, the I had the width and height mixed up :) Oops!

Great! Can you fix the travis errors? The flake errors are usually easily fixed with autoflake or autopep and you need to add a skipMulti parameter and pass it into the bounding box function. I've also added a few inline comments. In the tests, modify every test that uses the align function and to check both  align_v1 and align_v2.
-Brandon.

Can't figure out why it's saying "--version 2" is an unknown argument. Will revisit soon, let me know if theres anything else that needs to be done besides fixing the "version" argument issue with the tests.

It's an issue with your imports. Your scripts are not importing from the local copies. On my docker image, its using the old, preinstalled ones in /usr/local/lib/python2.7/dist-packages/openface, and I'm guessing something similar is happening in Travis.
Not sure how to fix this without overhauling your imports, unless I'm missing something. Please advise.

Hi @Godrek - sorry about this! I thought Travis was prepared to test PRs changing the library like this. Travis shares the code version that it's testing with the Docker container and then calls python3 setup.py install before running the tests. I'm looking into this now.

Travis passed with your latest change! This looks great and I'm almost ready to merge it. As a last step, can you squash all of your commits into a single one and then force-push? This way the history will just have a single, clean commit for this change. https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
-Brandon.

Thanks for the quick changes and great PR, merged!
-Brandon.


Bug: GardenActivityTest need fix, it doesn't work well

Hi try to test from command line
./gradlew connectedAndroidTest
com.google.samples.apps.sunflower.GardenActivityTest > clickOnPlantListDrawerMenuItem_StartsPlantListActivity[SM-G950F - 7.0] FAILED
        android.support.test.espresso.NoActivityResumedException: No activities in stage RESUMED. Did you forget to launch the activity. (test.getActivity() or similar)?
        at dalvik.system.VMStack.getThreadStackTrace(Native Method)
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: -2
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: numtests=14
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: stream=
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: test=clickOnAndroidHomeIcon_OpensAndClosesNavigation
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: class=com.google.samples.apps.sunflower.GardenActivityTest
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: current=2
11:24:24 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: 1

com.google.samples.apps.sunflower.GardenActivityTest > pressDeviceBack_CloseDrawer_Then_PressBack_Close_App[SM-G950F - 7.0] FAILED
        android.support.test.espresso.NoActivityResumedException: No activities in stage RESUMED. Did you forget to launch the activity. (test.getActivity() or similar)?
        at dalvik.system.VMStack.getThreadStackTrace(Native Method)
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: -2
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: numtests=14
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: stream=
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: test=onRotate_NavigationStaysOpen
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: class=com.google.samples.apps.sunflower.GardenActivityTest
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: current=4
11:25:30 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: 1

Problem happened while my test devices are all in "sleep".


proposal: cmd/go: add project config to go.mod

The way things are today, go relies on environment variables for things like build architecture and os, as well as resolving private repos. This isn't good because they live outside of source control, so the build breaks when someone else clones the repo and tries to run go get or go build.
Instead, what about making these settings live in go.mod, similar to how node has a package.json? It might look like
env (
    GOOS linux
    GOPRIVATE github.com/myOrganization
)

My goal is to ensure it builds the same way every time for everyone that clones the repo, without them having to do any manual environment config.

See previously #39005 (CC @dominikh @mvdan @jayconrod @matloob)

See also #33985.

Note that #39005 was not about altering the default build behavior, though. It was simply about listing the "build configurations" which are well supported by a module.

Hmm, I hadn't considered different build configs. That is definitely a useful feature though. For security, I'm not experienced enough with Go to know all the options, but I'm thinking of just setting build options, not necessarily going as far as allowing shell scripts. Perhaps something like, where you have different available configs for the build:
buildConfig (
    default (
        Output myApp
        GOOS linux
        GOPRIVATE github.com/myOrganization
    )
    windows (
        Output myApp.exe
        GOOS windows
        // Inherits GOPRIVATE value from default
    )
)

I'm still not convinced that a "default" makes sense. It would be very confusing for go build on Linux to produce a Windows binary, or to produce a binary in an unexpected directory, for example.
I think we should design the semantics (what do we want to list, and for what purpose?) before we worry about what file it would go under or with what syntax. The semantics is why #39005 was retracted, after all - it opened up the go tool to executing arbitrary code, and overall the idea gained no traction.

So I'm thinking that the build config section would be optional. Any values omitted would use the current behavior, so if an organization was running locally and had a mix of windows and linux machines, they could still omit the GOOS variable so that it would use the OS's default. My particular use case is we've got a small app that's being deployed to aws lambda, so it always needs to build for linux, and my org uses several private repos, so when I first tried to build the project, I got a bunch of errors and had to do a bunch of googling to figure out how to get it to work.
Coming from a web background, the npm and webpack ecosystems offer a lot more tooling. It's normal to have a default task that builds and runs in dev mode, often with hot code reloading, then you've got a task that builds in release mode. It's expected that things just work out of the box and that each module you import is self contained. Coming from that, it just seems strange to have to make global environment changes to get a local project to build, or to have to pass a bunch of flags every time. I've worked around this in the meantime by putting all my flags in a shell script that calls go build, but this seems like a pretty common use case, so I think it'd be nice if Go natively supported it.

As an alternative, note that you could at least reduce the number of environment variables from many to just one, by setting the GOENV environment variable to point to a location within your repo.

As an alternative, note that you could at least reduce the number of environment variables from many to just one, by setting the GOENV environment variable to point to a location within your repo.

Setting environment variable is not user friendly, it cannot be checked into the repo (it can through a file) and requires an extra step for new developers (new clone) to get started.
For example, one requires to source env.sh first before go build. Comparing to rust, one can just cargo build with the options in Cargo.toml.

I build app releases for Linux, Windows, and MacOS. Each release includes a platform specific tree of files beside the executable, and is packed into a TGZ or ZIP file. I built a shell script to do this, tho I could have used a makefile. I've essentially duplicated the script in multiple projects.
If there's a Go-native way to do this, I overlooked it.

In general go.mod is very narrowly scoped to information about dependency versions. It's not a catch-all for all possible configuration, in contrast to similar files in other systems, like package.json.
I would suggest that you check in a script with environment settings to be sourced, if you want your developers to be on the same page.

Based on the discussion above, this seems like a likely decline.

Even if this specific proposal is declined, the root problem still exists of building a project from source without having to do any manual configuration. I'm not locked in to my specific proposal, but I do think this needs to be addressed for go to be on par with other language ecosystems. It may be as simple as choosing a tool such as make, and updating the official docs to say something like "we recommend building with this tool in order to get consistent builds".

@rsc already suggested checking in a script that sets environment variables.  Is that sufficient, or would something else be required?  Would it suffice to declare a convention for what the script should be called?
We seem to only be talking about environment variables.  We currently already have a three level hierarchy for them: environment variables have default values set when Go is installed, which are overridden by values set by go env -w, which are overridden by values set in the environment when invoking the go tool.  It sounds like you are suggesting that we need to another level in that hierarchy, in between go env -w and the user environment: module level environment variables.  Does that sound right?

My main point would be that we need a single source of truth for build config that lives in source control. From someone who's relatively new to Go, it feels like kind of a mess right now, where your build might be pulling values from any of the sources you mentioned, none of which are in source control.
If the Go team doesn't want to go the route of package.json and do a full build file, I think it might be enough to update the docs to recommend creating a make file, or perhaps a shell script, to controls the build. Or, at least having a warning that Go relies on things outside your project's repo, and if you don't like that, then you need to implement a custom solution.

Part of the reason we don't worry about this too much is that setting these environment variables is rarely necessary.  Your example suggests setting GOOS=linux, but that will never be correct on a per-module basis.  And setting GOPRIVATE is also not per-module, but rather a characteristic of the organization.  So while it makes sense to put that kind of thing into source code control, the module does not seem like the right place for it.

Well, at least for my use case, it is always necessary to build with GOOS=linux, and I did have to manually set up GOPRIVATE when I first cloned the repo. Any top level project is probably going to have well-defined build targets. Like, if your company is deploying to aws, you always want to build the same way, regardless of whether the developer is on windows or linux.
You do have a point though about the os architecture not being applicable at the module level. Really, it's at the build target level, like you wouldn't expect imported modules to affect your build params in any way. However, for GOPRIVATE, it seems like that is still applicable to a module since that affects the module's imports.

Create a module-local go.env file, list your GOOS, GOPRIVATE and other (if any) Go environment adjustments there, build with GOENV=go.env go build. If you need scripting, custom targets (e.g. with tags), use make. I don't think this is something that should be ported into Go.
I can see that someone coming from web background is used to tooling lock-in. Anyone with systems background is perfectly comfortable with creating a Makefile when additional configuration/tasks are needed in the build process. Using make (or one of the many alternatives) actually makes your project tooling-agnostic, not even the language is set in stone: one can mix and match tools, libraries, components and languages in whatever way makes the most sense for their project's goals.

Even if this specific proposal is declined, the root problem still exists of building a project from source without having to do any manual configuration.

Just to reply to this, that root problem is not something the go command aims to solve. Shell scripts and more complex build systems are possible solutions.

No change in consensus, so declined.


DotNetCoreCLI - Pack missing doc & wierd usage

Note
This could be related to issue #9789
Required Information
Question, Feature?
Type: Feature  / Cleaning
Enter Task Name: DotNetCoreCLIV2
Environment

Server - Azure Pipelines
Agent - Hosted

Issue Description
DotNetCoreCLI@2 provide a documented way for packing, who is I think mispelling / hard to get into / easier to get lost.
Like:
- task: DotNetCoreCLI@2
  displayName: 'Pack - Manager'
  inputs:
    command: 'pack'
    projects: '$(Build.SourcesDirectory)/src/CM/CM.csproj'
    includesymbols: true
    includesource: true
    nobuild: true
    verbosityPack: 'normal'
    outputDir: '$(Build.StagingDirectory)'

projects won't be used during pack cmd and will be override by searchPatternPack who is required but has a default. And it seem to have one alias packagesToPack who is not set or documented.

I just lost several hours because of this bug. Could you emit a warning if projects is used in combination with pack and link to this issue @sachinma ?

Was this fixed in the meanwhile?

Was this fixed in the meanwhile?

Was this fixed in the meanwhile?

Also I think there are differences between projects and searchPatternPack - I am able to pass a multiline string to projects for a restore or build command, but not pack. For example I am trying to build a reusable template to restore/build/pack like this:
parameters:
- name: projects
  type: string
steps:
- task: DotNetCoreCLI@2
  inputs:
    command: restore
    projects: ${{ parameters.projects }} # other options omitted
- task: DotNetCoreCLI@2
  inputs:
    command: build
    projects: ${{ parameters.projects }}
- task: DotNetCoreCLI@2
  inputs:
    command: pack
    searchPatternPack: ${{ parameters.projects }}

however, if I try to use this template with a multiline string, only restore and build succeed:
variables:
  projects: |
    some/project/A.csproj
    other/project/B.csproj
- template: my-template
  parameters:
    projects: $(projects)

Those 2 projects will be found by the restore and build tasks and work fine, but the pack task seems to use different logic for discovering projects and requires a ; separated string instead of newline. So it will fail saying No files matched the search pattern

Was this fixed in the meanwhile?

Was this fixed in the meanwhile?

Was this fixed in the meanwhile?


Highlighting token pairs does not work

Quick gif demonstrating the issue https://cl.ly/0H1r123U350r.

Good catch.

Thought it would be a simple fix, but this uncovered another issue: https://cl.ly/2D4404372y1O
The input overlay currently has pointer-events: none to allow select/click events to pass through to the input itself. But I had to counteract that with pointer-events: auto on the highlighted tokens, to allow for the click and hover events. So the problem is when you start a selection inside the token and try to drag to non-token text, it breaks since you're selecting text in the overlay span rather than the input itself.
Not really sure how to get around this other than disabling the hover effect and click event on the highlighted token. Any ideas?

Why not store the up/down click state of the cursor? When the mouse state is down you know can allow selecting of the textarea, when it's up you can display the overlay.


Support for Domoticz's Log

I don't see any events from zigbee2mqtt plugin in Domoticz log. So need to have another tool or open Linux console to see the output from Zigbee2mqtt. It would be useful to get zigbee2mqtt events in Domoticz itself to see relationships between different events in the system.

@loglux What events do you mean, did you try to enable "Debug" mode in the plugin?


Feature: Autofilling zat theme preview credentials

Hi,
I'm starting out with zat. Wondering is there a way to autofill subdomain, email, password so it's way easier to start running in on local machine.
I'd like to be able to pass credentials as CLI arguments.

So far I tried writing the node.js script that "wraps" the proxies zat theme preview. So that I can change the current working directory. My theme source files are not in the root of the repo.
But also tried listening for the child process stdout to see when I get Enter your Zendesk subdomain or full URL (including protocol): so I can pass back to its data to autofill it.
But wasn't able to get Enter your Zendesk subdomain or full URL (including protocol): line, it doesn't seem to be output tostdout.

Never mind. Find out that you can create a .zat file or pass environmentals


Question - Case insensitive decode

I'm trying to parse a json object where the properties come from two different systems which have different fields with different case.
Here is a sample
system1:
[      {"id": "39336bd7-ecdc-4755-ac21-8f852d70d311", "data": ["one", "two", "three", "four"], "userid": "user22", "deviceid": "device123", "timestamp": 2345} ]
system2:
[      {"id": "39336bd7-ecdc-4755-ac21-8f852d70d312", "data": ["one", "two" ], "userId": "user122", "deviceId": "device123", "timestamp": 2346} ]
Have a look at userId and deviceId
Here is my decoder:
Decode.object
                    (fun get ->
                          {
                              Id = get.Required.Field "id" Decode.guid
                              Data = get.Required.Field "data" JObjectDecoder
                              DeviceId = get.Required.Field "deviceid" Decode.string
                              Timestamp = get.Required.Field "timestamp" Decode.int64
                              UserId = get.Required.Field "userid" Decode.string
                          }
                    )

How can I get it to support both cases?

Hello,
Out of the box the solution would be to use Decode.oneOf to handle both possible case:
Decode.oneOf with Decode.object
    static member Decoder =
        Decode.oneOf [
            Decode.object
                (fun get ->
                    {
                        Id = get.Required.Field "id" Decode.guid
                        Data = get.Required.Field "data" (Decode.list Decode.string)
                        DeviceId = get.Required.Field "deviceid" Decode.string
                        Timestamp = get.Required.Field "timestamp" Decode.int64
                        UserId = get.Required.Field "userid" Decode.string
                    }
                )

            Decode.object
                (fun get ->
                    {
                        Id = get.Required.Field "id" Decode.guid
                        Data = get.Required.Field "data" (Decode.list Decode.string)
                        DeviceId = get.Required.Field "deviceId" Decode.string
                        Timestamp = get.Required.Field "timestamp" Decode.int64
                        UserId = get.Required.Field "userId" Decode.string
                    }
                )
        ]

You can also use Decode.mapX to reduve a bit the redundant code:
Decode.oneOf with Decode.map5
    static member Decoder2 =
        let deviceIdDecoder =
            Decode.oneOf [
                Decode.field "deviceId" Decode.string
                Decode.field "deviceid" Decode.string
            ]

        let userIdDecoder =
            Decode.oneOf [
                Decode.field "userId" Decode.string
                Decode.field "userid" Decode.string
            ]

        Decode.map5 (fun id data deviceId timestamp userId ->
            {
                Id = id
                Data = data
                DeviceId = deviceId
                Timestamp = timestamp
                UserId = userId
            }
        )
            (Decode.field "id" Decode.guid)
            (Decode.field "data" (Decode.list Decode.string))
            deviceIdDecoder
            (Decode.field "timestamp" Decode.int64)
            userIdDecoder

A cleaner solution would be to implement your own version of Decode.object or Decode.field which are case-insensitive.
ℹ The implementation is done using Thoth.Json and not Thoth.Json.Net because it was easier for me for providing a real live example. The logic is exactly the same, you just need to adapt for Newtonsoft APIs.
// Partially copied from Thoth.Json
module internal Helpers =
    [<Emit("typeof $0")>]
    let jsTypeof (_ : JsonValue) : string = jsNative

    let inline getField (fieldName: string) (o: JsonValue) = o?(fieldName)

    [<Emit("$0 === null ? false : (Object.getPrototypeOf($0 || false) === Object.prototype)")>]
    let isObject (_ : JsonValue) : bool = jsNative

    [<Emit("Object.keys($0)")>]
    let keys (_ : JsonValue) : string array = jsNative

    let isUndefined (o: JsonValue): bool = jsTypeof o = "undefined"

module Decode =

    let caseInsensitiveField (fieldName: string) (decoder : Decoder<'value>) : Decoder<'value> =
        fun path value ->
            if Helpers.isObject value then
                let realFieldName =
                    value
                    |> Helpers.keys
                    |> Array.tryFind (fun name ->
                        name.ToLower() = fieldName.ToLower()
                    )

                match realFieldName with
                | Some realFieldName ->
                    let fieldValue = Helpers.getField realFieldName value
                    if Helpers.isUndefined fieldValue then
                        Error(path, BadField ("an object with a field named `" + fieldName + "` (case insensitive)", value))
                    else
                        decoder (path + "." + fieldName) fieldValue

                | None ->
                    Error(path, BadField ("an object with a field named `" + fieldName + "` (case insensitive)", value))

            else
                Error(path, BadType("an object", value))

Usage:
    static member Decoder3 =
        // I don't use Decode.object as an example because I would have to re-implement it entirely
        // But you could create your own Decode.insensitiveObject
        Decode.map5 (fun id data deviceId timestamp userId ->
            {
                Id = id
                Data = data
                DeviceId = deviceId
                Timestamp = timestamp
                UserId = userId
            }
        )
            (Decode.caseInsensitiveField "id" Decode.guid)
            (Decode.caseInsensitiveField "data" (Decode.list Decode.string))
            (Decode.caseInsensitiveField "deviceId" Decode.string)
            (Decode.caseInsensitiveField "timestamp" Decode.int64)
            (Decode.caseInsensitiveField "userId" Decode.string)

REPL demo
You are not the first one with a JSON where the properties name is case insensitive. The first person was having problem using the Auto module and because I agree to add support for it in Auto decoders I should probably include a case insensitive version for the different manual decoders.
Please note, that case insensitive version will be less performant because it needs to iterate over the properties name until it finds one that matches or none.

@MangelMaxime thanks for the detailed examples and the fast response.


two button ng-click only click the first button

when press the minus button the add button press too。。。。a bug or  ?   $scope.minus can not be called 。

.]()

Greetings @Jaware!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Greetings @Jaware!
My sensors indicate that you have created an issue on our tracker requesting usage help, rather than an actual error with Ionic framework.
This GitHub issue tracker is used to track framework features, problems, and development.
If you wish to get help using the framework itself, the recommended place is the forum. There are many humans there who would be happy to offer sage advice.
Thank you for allowing me to assist you.

the forum is  a little complicated,can you help me again?the problem is very strange,angular supports this ,however in  ionic  only one button can be bind to the controller method in a list .


⚠ BCR Bot has degraded performance

In cbdaa56, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1268 ms

Resolved: BCR Bot performance has improved in 7f63053.


The history navigation methods don't work well

These methods doesn't work well:

controller.canGoBack()
controller.goBack()
controller.goForward()
controller.canGoForward()

The canGoBack() and canGoForward() returns wrong values. The canGoForward() returns false even though we should be able to go forward because we have browsing history.
I have investigated it a bit and the wrong values are returned in the add_HistoryChanged callback. It seems the issue is caused by logic that allows us to filter and decide which page should be loaded and which not: WinNavigationDelegate.onNavigationRequest implemented mainly in add_NavigationStarting handler.

Fixed, and pushed to github.
Please give it a try.

I tested and it works almost perfectly!
I wonder if we should allow going back to about:blank or only to the first loaded page? I think we shouldn't if we want to be consistent with how it works for Mobile platforms. I have checked it on Mobile and we can go back to the first loaded page only.
It seems that change should fix that utf16Url.compare(L"about:blank") == 0:
  if (m_isNowGoBackForward          || nowLoadingUrl.compare(url.get()) == 0          || utf16Url.rfind(L"data:text/html;", 0) == 0          || utf16Url.compare(L"about:blank") == 0) {
If you agree I can create a PR, or you can just commit it, please. :)

I tried to:
load("about:blank")
-> load("https://www.google.com")
-> canGoBack() return true
-> call goBack() will show blank page
-> call goForward() will go to google site
It seems there is no problem ?
import 'dart:developer';

import 'package:flutter/material.dart';
import 'package:webview_win_floating/webview.dart';
import 'package:webview_flutter/webview_flutter.dart';

void main() {
  WindowsWebViewPlatform.registerWith();
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final controller = WebViewController();
  final srollController = ScrollController();

  @override
  void initState() {
    super.initState();
    controller.setJavaScriptMode(JavaScriptMode.unrestricted);
    controller.setBackgroundColor(Colors.cyanAccent);
    controller.setNavigationDelegate(NavigationDelegate(
      onNavigationRequest: (request) {
        log("onNavigationRequest");
        if (true) return NavigationDecision.navigate;
        if (request.url.startsWith("https://www.google.com")) {
          return NavigationDecision.navigate;
        } else {
          log("prevent user navigate out of google website!");
          return NavigationDecision.prevent;
        }
      },
      onPageStarted: (url) => print("onPageStarted: $url"),
      onPageFinished: (url) => print("onPageFinished: $url"),
      onWebResourceError: (error) =>
          print("onWebResourceError: ${error.description}"),
    ));
    controller.loadRequest(Uri.parse("about:blank"));
  }

  @override
  Widget build(BuildContext context) {
    Widget webview = WebViewWidget(controller: controller);
    webview = Column(children: [
      Row(children: [
        ElevatedButton(
            onPressed: () async {
              controller.loadRequest(Uri.parse("https://www.google.com"));
            },
            child: const Text("Google")),
        ElevatedButton(
            onPressed: () async {
              bool b = await controller.canGoBack();
              print("canGoBack: $b");
              controller.goBack();
            },
            child: const Text("Back")),
        ElevatedButton(
            onPressed: () async {
              bool b = await controller.canGoForward();
              print("canGoForward: $b");
              controller.goForward();
            },
            child: const Text("Forward")),
      ]),
      Expanded(child: webview),
    ]);

    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Windows Webview example app'),
        ),
        body: webview,
      ),
    );
  }
}

Thank you for the example code.
I think the whole trick is about what page you load as the first page. In your example, both Mobile and Windows work the same, indeed.
But if we consider this change:
  @override
  void initState() {
    ....
    controller.loadRequest(Uri.parse("https://www.wikipedia.com")); // don't load the blank page as first page
  }

Then we have some discrepancies between Mobile and Windows.
On Mobile, we can't go to the blank page, but it is possible on Windows.

That is actually an interesting case because probably there is no perfect answer to how it should work.
The code I proposed in the previous comment isn't perfect because it will break your example but will work well for mine.


chrore: Add CredentialProvider to Bottlerocket settings

Fixes #5507
Description
This PR adds support for settings.kubernetes.credential-providers for Bottlerocket.
How was this change tested?
By building a dev version of Karpenter with the changes of this PR, pushing the image to a private ECR repository and switched the image URL of Karpenter with the dev image on an existing EKS cluster which was already using Karpenter.
When Karpenter was deployed, it spun up a new Bottlerocket instance with the example configuration of the original issue.
After going into the node with SSM I was able to confirm the configuration was updated as expected (which wasn't the case before).
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 82.615%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
5004

Relevant Lines:
6057

💛  - Coveralls


Hello, may I ask for your help?

Hello, may I ask for your help?
After I modify the code, I get an incorrect hash value.
		buff = (BYTE *)"abc";
		checkCudaErrors(cudaMallocManaged(&buff, (3)*sizeof(char)));
		jobs[i] = JOB_init(buff, 3, argv[index]);

That's because you are changing the code incorrectly.
You are not supposed to change:
checkCudaErrors(cudaMallocManaged(&jobs, n * sizeof(JOB *)));

Into:
checkCudaErrors(cudaMallocManaged(&buff, (3)*sizeof(char)));

Try reading the code again to understand what that line actually does.

Thanks you, sir. I will check it now. :D


Fix pubsub regression test broken by rename of 'Message.attrs' -> 'attributes'.

Changes Unknown when pulling 37ad9e255b368a39e0a2783dab49e3b627d59f4b on tseaver:pubsub-fix_regression-message_attributes into ** on GoogleCloudPlatform:master**.

LGTM.
Can you link to the broken build?

https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/57419833


Sorry, softer NMS is not currently on our schedule of implementations.


Upload file

Part of https://www.pivotaltracker.com/story/show/106019418
Implement the front-end designs for the upload page

retest this please

As discussed, this PR is broken and includes a number of commits that have already been merged.


V1.20.0 first time playing Spotify music from Spotify App does not play TTS "connect spotify"

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

When using the latest sdk v1.20.0 with enable Spotify Patch, playing music from Spotify App the device does not play the TTS "connect spotify", and this issue is not happened on avs device sdk v1.18.0. we find that the AVS Spotify Api changed. from the old api: The TTS will received from this API  ExternalMediaPlayer.Login
What is the expected behavior?

when first time play Spotify music from Spotify App, it does not play "connect spotify" TTS
What behavior are you observing?

when first time play Spotify music from Spotify App, it will play "connect spotify" TTS
Provide the steps to reproduce the issue, if applicable:

after the device initialize, open Spotify app
find the device from Spotify App, then connect the device
play some music from Spotfy App

Tell us about your environment:

What version of the AVS Device SDK are you using?
avs device sdk: v1.20.0
spotify patch: Spotify-1.20.tar.gz
Tell us what hardware you're using:

[ ] Desktop / Laptop
[ ] Raspberry Pi
[ * ] Other - tell us more:

Tell us about your OS (Type & version):

[ * ] Linux
[ ] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @keying-linkplay,
Due to the nature of the issue, can you please reach out through your Amazon Business Representative and we can debug this using a separate communication channel.

OK


BUG Relax requirements to allow larger minor version

We shouldn't require specific minor versions of our dependencies.

Can you explain why we don't want to bind to micro? Make it easier to grab bug fixes?


Bug in syntax highlighting

Issue Type: Bug
Enter code:
asd = "_string";
A string that contains the symbol underscore is highlighted as a number (Pink).
Then, after this the semicolon is highlighted as a code error (Red) and all the code is incorrectly highlighted.
VS Code version: Code 1.25.0 (0f080e5267e829de46638128001aeb7ca2d6d50e, 2018-07-05T13:11:58.697Z)
OS version: Windows_NT x64 10.0.15063

Extensions (5)
Extension|Author (truncated)|Version
---|---|---
vs-color-picker|lih|0.7.0
identical-sublime-monokai-csharp-theme-colorizer|max|0.10.0
vscode-language-pack-ru|MS-|1.25.2
csharp|ms-|1.15.2
color-highlight|nau|2.3.0

In what language does that happen?

The programming language is C#

I got an issue w/ highlighting variable type in typescript
only first typed var is highlighted. the following two are not

breaking it apart highlights the first two but if you add types to the following vars it's not highlighted

@PaVolDev Can you paste the sample code?

@aeschli,
The sample code (C#):
using System.Collections;
public class GameSettings : MonoBehaviour {
	public string gameMode = "_none";
	public static int scores = 4568;
	public static int kills = 123456;
	public static int allMoney = 123456;
}

The semicolon is highlighted as a code error (Red) and all the code is incorrectly highlighted

It seems I found the problem.
I have the installed extension "identical-sublime-monokai-csharp-theme-colorizer" v0.10.0.
I disabled this extension and the problem disappeared.

Thanks for finding the issue. Looks like this already reported here: https://github.com/Maximetinu/Sublime-Text-Monokai-theme-for-Visual-Studio-Code/issues/1


Gaze Detection and Center Viewport Restriction

[x] Configure a model for gaze detection and center viewport restriction
[x] Create a simple React component which implements this functionality

Requirements:

Should track (as boolean) whether or not the user's face is within the center viewport.
Signal a violation if the check failure crosses a threshold

@sidrao2006 please update to me the changes you have done for gaze detectioon.

@AllyNav I'm on leave today. I'll be back tomorrow and we can discuss this then or please talk to @akashreactdeveloper regarding this.


Make loading screens responsive

Loading screens shouldn't prevent players from switching to another application or to the desktop! Also it should be possible to abort the loading process.
Make it possible :)

Did we already suggest to abort a loading process? Loading the wrong map (Xenon) can cost some time.

Not yet, I added this above.

+1

Does this issue arise in fullscreen mode or in windowed?

Both (im on Windows 64 here)
You could still minimize it with Taskmanager but then it could crash

I am not sure whether we can get around this in Fullscreen, but in windowed you should always be able to leave inexor.


LINK-1817 | Add phone number field for signup

Description
Add phone number field to each signup
Validate that phone number is not empty if phone number is set as mandatory field
Closes
LINK-1817
Screenshot

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (602f02e) 99.61% compared to head (ec26cff) 99.61%.
 Consider uploading reports for the commit cbe1856 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   99.61%   99.61%
=======================================
  Files         188      188
  Lines        3631     3634    +3
  Branches      595      598    +3
=======================================
+ Hits         3617     3620    +3
  Misses         13       13
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


refactor: More directory layout refactoring

Approving but there's a bug on one of the snippets source properties, I've flagged it there.
Otherwise, the only thing I'm not certain about is the sepration in two of ApiLayout. I understand the need to use one or the other of repo-root and output, but other than that I don't understand why we'd need the distinction. And the using of one root or the other can be solved with factory methods. But, I know I might be missing something, so this is not a blocker for me.

Separating the two into different types with different properties makes it less likely that someone will use the wrong one. For example, because GeneratorApiLayout doesn't have CreateDocsLayout, you can't accidentally try to use the generator layout (which is incapable of building docs) when you need anything about docs. In the other direction, if you're using anything about "tweaks" but you're expecting a full repo, then there's probably something wrong. (Obviously we can add properties if we really need to.)


remove method & path from httpRequest(close #523)

Codecov Report

Merging #524 (53e0299) into main (9dbe010) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
- Coverage   80.61%   80.39%   -0.23%
==========================================
  Files          87       87
  Lines       10103    10103
==========================================
- Hits         8145     8122      -23
- Misses       1508     1533      +25
+ Partials      450      448       -2

Impacted Files
Coverage Δ

pkg/object/mqttproxy/session.go
74.23% <0.00%> (-7.98%)
:arrow_down:

pkg/cluster/syncer.go
76.28% <0.00%> (-1.29%)
:arrow_down:

pkg/cluster/cluster.go
51.87% <0.00%> (-1.03%)
:arrow_down:

pkg/object/mqttproxy/client.go
79.63% <0.00%> (-0.91%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbe010...53e0299. Read the comment docs.


Upgrade Octant to v0.16.1 & Add alerts for traceflow UI

To add alerts for traceflow UI, we need to upgrade Octant to v0.16.1 first to make alerts available in Octant plugins.
In Octant, alerts appear on the top of webpage like this:

In default, it will expire after 10 seconds.
When a user creates a traceflow via UI successfully, we will notify the user like the image above.
When there's something illegal in users' input, we will notify the user how it went wrong:

@mengdie-song Could you help me add reviewers for this pull request as I do not have permission to do so?

@ZhangYW18 Sure, I will also review this later.

Codecov Report

Merging #1371 into master will decrease coverage by 22.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1371       +/-   ##
===========================================
- Coverage   64.32%   42.06%   -22.26%
===========================================
  Files         159       85       -74
  Lines       12674    10300     -2374
===========================================
- Hits         8152     4333     -3819
- Misses       3668     5583     +1915
+ Partials      854      384      -470

Flag
Coverage Δ

#integration-tests
?

#kind-e2e-tests
?

#unit-tests
42.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/default.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/ovs/openflow/logs.go
9.52% <0.00%> (-90.48%)
:arrow_down:

pkg/controller/networkpolicy/tier.go
0.00% <0.00%> (-90.00%)
:arrow_down:

pkg/apis/controlplane/register.go
0.00% <0.00%> (-85.72%)
:arrow_down:

pkg/ovs/openflow/ofctrl_group.go
0.00% <0.00%> (-84.38%)
:arrow_down:

pkg/agent/client.go
0.00% <0.00%> (-77.42%)
:arrow_down:

pkg/ovs/ovsconfig/ovs_client.go
0.00% <0.00%> (-72.30%)
:arrow_down:

pkg/ovs/openflow/ofctrl_action.go
17.76% <0.00%> (-72.09%)
:arrow_down:

... and 122 more

@gran-vmv Will you review this PR?

/test-all

/test-all

I believe the failure in e2e is not related. But just in case, testing another time.
/test-e2e


Uploading files in Vizro apps

Which package?
vizro
What's the problem this feature will solve?
Perhaps there is a way already to do it, but I want the user to be able to select a file on the local computer and use it for analysis. I was hoping that there was a "vizro" object to do uploads, but I can't find one. Lacking that, can one somehow include a dcc object, such as Upload, into a "vizro" app? I saw one place that said one vizro object was "a thin wrapper" on a dcc object, but I don't know if there is someway for me to do that. Also lacking that, could I make a multipage app where I could have a dcc Update on a separate page or perhaps as a dropdown? If not, I think you really should have an "Upload" object or some object that includes that functionality.
Describe the solution you'd like
I described ideally want to do Upload in a vizro object in the "What's the problem" section above.
Alternative Solutions
I described alternative solutions in the "What's the problem" section above.
Additional context
Is there a vizro forum for discussing this sort of issue? I looked at the "dash" forum, but it only seemed to mention vizro in one post.
Code of Conduct

[X] I agree to follow the  Code of Conduct.

Hello @bcichowlas and thanks very much for raising this very good issue.

Is there a vizro forum for discussing this sort of issue? I looked at the "dash" forum, but it only seemed to mention vizro in one post.

At the moment there's no dedicated forum for vizro - the best place to ask questions is here in Github issues or on the plotly forums. Feel free to respond to the post I made there about vizro or make a new topic, and I'm sure that @Coding-With-Adam will make sure we see it.

You ask a very good question. The basic answer is that there's not yet a native way to do this built into vizro, but depending on your exact requirements it's probably possible to get something working. And maybe in the future there will be a native way to do it. This is actually the first time I've heard this user request on vizro, but it's a very reasonable one I think. So I'd be very interested in hearing whether other users would find this useful also. At the moment we're reworking how the data manager works and will definitely take this into consideration.
It's definitely possible to make a new vizro component that wraps dcc.Upload. This should be pretty easy but let me know if you can't get it working.
The main challenge you'll face willbe: what do you want to do with the output? And here the right solution depends heavily on your exact requirements, e.g.

what vizro components should change dependent on the uploaded file? Some graphs I imagine?
do you want to persist the uploaded data to disk or just keep in memory? How big are the files you're uploading? (e.g. https://github.com/fohrloop/dash-uploader might be more suitable than dcc.Upload)
does this need to be production ready or just for your personal development purposes? Are you concerned about security of the solution?
will you have multiple users? Do they need to have independent user sessions? Should one user be able to see the results from another user's uploaded files?

So if you could explain exactly what you're looking for then I can try to offer some more suggestions.


Maven-cache analysis is missing some Jar files from .m2/repository

This issue might be related to #439, #441 and even part of #492.
While testing v9.6.1 of cdxgen (using Docker image) with "--type maven-cache" we have noticed that not all jar files are added to SBOM file. We have noticed that by comparing files in .m2/repository and in result SBOM.
Content of .m2/repository:

├── javassist
│   └── 3.18.2.GA
│       ├── javassist-3.18.2.GA-p2artifacts.xml
│       └── javassist-3.18.2.GA.jar
...
├── com.google.guava
│   └── 23.0.0
│       ├── com.google.guava-23.0.0-p2artifacts.xml
│       └── com.google.guava-23.0.0.jar
...

We see that those files are analysed because next is present in the log:

Executing 'jar tf /root/.m2/repository/p2/osgi/bundle/javassist/3.18.2.GA/javassist-3.18.2.GA.jar'
...
Executing 'jar tf /root/.m2/repository/p2/osgi/bundle/com.google.guava/23.0.0/com.google.guava-23.0.0.jar'

Though we do not see those packages mentioned in SBOM file.

@theold190 Interesting! Are there any errors if we run the jar tf command manually?

@prabhu I have searched code for "jar tf" command and found only one place (https://github.com/CycloneDX/cdxgen/blob/7cce238ba21966e34d76f6a4932c30114adc2406/utils.js#L5198). Though, if I read code correctly, it is possible that debug output is printed, but no analysis is actually done.
For example, if ".pom" file is not present in the same folder as ".jar" file and path for ".jar" file doesn't contain ".gradle/caches". In that case nothing would be analysed and no error would be printed. And both seems of those conditions are true for project I work on.
If there is a way to enable more detailed debug outputs, I can of course enable them.

@theold190 We will work on the fix. Meanwhile, could you share a script to detect such misses? For #492

Thanks!
We don't yet have a script to detect those misses. We just got lucky noticing that miss. We did a fast review of results of "tree .m2/repository" where we noticed that in some cases ".pom" file was missing. And we assumed that it might affect result output  from cdgen.

In https://github.com/CycloneDX/cdxgen/pull/510 a fix to discover and report osgi bundles is added. Now all osgi bundles are reported as part of a p2.osgi.bundle group. As a result, those components are not recognized by a Dependency tracker. So Dependency tracker can't show info about vulnerabilities.
Right now we are using a small hack to get osgi bundles reported in a "good" way. By extracting a pom.xml file, renaming it and placing next to .jar file we get "normal" entries in SBOM file. Though it works only for .jar files that has pom.xml file.

Thanks @theold190. I did consider this workaround briefly, which was also proposed in one of the threads, but decided against it since the same jars would've been reported differently in maven-cache vs. cyclonedx maven plugin mode.
The second option is to use component pedigree
https://cyclonedx.org/docs/1.5/json/#components_items_pedigree_variants
The third option is to use p2 type in purl.
I am unsure if the dependency track or any tools support options 2 or 3, so I didn't spend time implementing this.
Please do not hesitate to file a ticket if you find a better approach.


Cannot use the annotation tool

After open the 2D annotation tool, the picture will show but cannot be labelled. Only the shortcut command for quit will work, the others won't. The 3D annotation cannot initiate for the missing file "jointAngleModel_v2.npy". Will you please re-upload the full package of this annotation tool, or did I ignore something?

After open the 2D annotation tool, the picture will show but cannot be labelled. Only the shortcut command for quit will work, the others won't. The 3D annotation cannot initiate for the missing file "jointAngleModel_v2.npy". Will you please re-upload the full package of this annotation tool, or did I ignore something?

Hi, can you share some error message is any for the 2D pose estimation?
For the missing file, it can be downloaded here:https://drive.google.com/drive/folders/1MUcR9oBNUpTAJ7YUWdyVLKCQW874FszI.
You can refer to https://github.com/Nicholasli1995/EvoSkeleton/blob/master/docs/HHR.md to prepare the files.

Please re-open this issue if there's further question.

i am having the same issue, and there is no error message. it does nothing when i click on it

i am having the same issue, and there is no error message. it does nothing when i click on it

Can you share more information? What is your operating system, Python version and Matplotlib version?


bug with save nodes

Hi, I just recently found out about this player and was very surprised that such a thing exists, but I ran into a problem. When there are no nodes, you can save the preset, and when you have configured it for yourself, then the save button does not work, neither the top nor in the context menu

https://github.com/user-attachments/assets/36968847-4f45-4b81-a9f6-5234502d67ed
I found out this is only because of the addition of the 8-band equalizer

Hi, I just recently found out about this player and was very surprised that such a thing exists, but I ran into a problem. When there are no nodes, you can save the preset, and when you have configured it for yourself, then the save button does not work, neither the top nor in the context menu
bandicam.2024-07-23.13-22-11-026.mp4

I found out this is only because of the addition of the 8-band equalizer

I have confirmed this issue on the master and v2 branch. I most likely found the issue in the code, but I do not have the best overview of how it all works so me fixing it might take some time.


Base URL within Documentation is no deprecated

Thanks for sharing your code. I'd love to use it but it seems like the TSA API is deprecated. Do you have any suggestions on alternatives?
See below for the base_url that's now deprecated and mentioned in the code: http://apps.tsa.dhs.gov/MyTSAWebService/GetTSOWaitTimes.ashx

Thanks for checking on it! It looks like that was replaced with https://apps.tsa.dhs.gov/MyTSAWebService/GetConfirmedWaitTimes.ashx, with usage examples given as https://apps.tsa.dhs.gov/MyTSAWebService/GetConfirmedWaitTimes.ashx?ap=DCA
[returns XML of last 25 wait times for DCA airport]
https://apps.tsa.dhs.gov/MyTSAWebService/GetConfirmedWaitTimes.ashx?ap=RDU&output=json
[returns JSON of last 25 wait times for RDU airport]
Though I'm afraid at the moment I don't have time to confirm that it's live and giving proper results. Hope that helps!


[ZEPPELIN-63] add interpreter for Apache Ignite

Currently it is very early stage of implementation.
My idea is implementing 2 interpreter for ignite,

[ ] IgniteInterpreter - Let user use ignite API (scala) by embedding scala compiler.
[x] IgniteSqlInterpreter - use JDBC driver to make sql query

While IgniteSqlInterpreter can be simply implemented using JDBC driver, i'd like to work on IgniteSqlInterpreter first and than work on IgniteInterpreter.
Work in progress ..

Ignite interpreter is done by https://github.com/apache/incubator-zeppelin/pull/108. i'm closing this pr.


Bower Install Bootstrap 4 missing dist js file

Installing bootstrap v4 with bower the js file in dist folder is missing. Attaching the snapshot.

Bower doesn't include dist files—only source.


Update Utility Listing Process

In response to UFWG mtg of 08-Dec-2020, the criteria for listing a project needs to be more explicit.
Additionally, The KOB and CanaCred projects are being removed or their listing postponed until further details can be provided.
See Pull Request #24 .

@vinomaster  I have updated the convener and stakeholder for KOB. Please let me know if there is any else that needs to be called out.


[sockets] check for dead socket connections server-side too

While this is not a blocking issue, this is not clean and triggers lots of error messages.
note: Find a way to programmatically reproduce the problem, to make sure to track down all possible implications (ghost states, etc.)

see https://github.com/collective-soundworks/soundworks/commit/e0605773ff9c7929ef6baf4ceb8676c047fc6a14, (hopefully fixed)

should do proper tests anyway

ok it's not...
Error: write EPIPE
    at afterWriteDispatched (internal/stream_base_commons.js:156:25)
    at writevGeneric (internal/stream_base_commons.js:139:3)
    at Socket._writeGeneric (net.js:783:11)
    at Socket._writev (net.js:792:8)
    at doWrite (internal/streams/writable.js:375:12)
    at clearBuffer (internal/streams/writable.js:521:5)
    at Socket.Writable.uncork (internal/streams/writable.js:317:7)
    at Sender.sendFrame (node_modules/ws/lib/sender.js:398:20)
    at Sender.send (node_modules/ws/lib/sender.js:294:12)
    at WebSocket.send (node_modules/ws/lib/websocket.js:361:18) {
  errno: -32,
  code: 'EPIPE',
  syscall: 'write'
}

see https://github.com/websockets/ws/issues/1172

seems to reproduce when we have minimum 6 emulated clients (i.e. 12 opened sockets) and reload the page


React dependency

It seems there is an issue with the React dependency "react": "file:../node_modules/react".
Shouldn't there be a React version number instead of local files?

Thank you for taking the time to report. The plugin is in a very early stage, and we will take a close look at some point.

Same issue here, following.

experiencing the same issue, following 👀

Same here, "yarn add realm-flipper-plugin-device" causes error Package "react" refers to a non-existing file '"/home/sve/code/node_modules/react"'. Have to install react in my ~/code directory first, how strange!

@nicolaslevavasseursmile Until it's been fixed, you can get around it by specifically installing version 1.0.11 🙂
yarn add<EMAIL_ADDRESS>


Color by species when filtered

Colors aren't matching when in the IRIS dataset I choose colors by species and then I filter on navio by a specie

Fixed!


Add code coverage badge to README.md

Currently we have only the "build: passing" badge in the README.md. It would be nice to add the code coverage badge.
As this project has a frontend and a backend running unit tests with jest separately, we could either have two badges (one for the frontend and other for the backend), or then if possible have a unified badge.
We are using Travis CI.

Open PR: https://github.com/Fabianopb/express-react-ts-ci/pull/6

Done!


Solved Cpp Easy Tasks

Pull Request Type
What kind of change does this PR introduce?
[ ✅] Solved an issue/task
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
Issue Number: #1306 #1305 #1309

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!