Val loss changes, with quite a few other changes. This is in place of the earlier PR(https://github.com/lucidrains/DALLE2-pytorch/pull/67)

This PR implements the following:

Validation loss is getting calculated every N steps, for a small batch of 100 embeddings
hyperparameters logging to wandb for each run
Some code cleanup in the report_cosine_sims() function.
load_diffusion_model and save_diffusion_model added

I left some comments about naming and one about doc.
The rest LGTM
Can you also take a look @lucidrains ? I think it's almost good now.

Let's add some minimal doc about the load and save functions in the readme
Then LGTM

Ok LGTM
@krish240574 can you start a new run with all these last changes in? I'm curious to see how it looks on wandb
@lucidrains your turn to review :)

https://wandb.ai/laion/diffusion-prior/runs/1blxu24j - wandb run for your perusal.

Looks good!

@krish240574 @rom1504 thank you Kumar (and Romain for the reviewing)
this lgtm to me also :rocket: !

moving forward, i'm also going to push for an experiment tracker agnostic setup, just because of the difficulties we faced last time around trying to scale on the supercomputing cluster in Germany https://github.com/lucidrains/DALLE2-pytorch/issues/73 we can do the refactor the next PR!


Share buttons break after in-app navigation

Share buttons work fine upon loading the landing page.
But if a line page is viewed, and then the back button in the navbar is tapped, the share buttons don't appear correctly on the landing page anymore.

Not reproducible after latest refactorings.

Makes sense since the routing model was changed.


getComments will throw out an error when the comment count of the video is 0

Steps to reproduce
Example:
1.find a video that with no coment( for example: Ja2H4xHnX-0 )
2.take its video id and invoke getComents function
Failure Logs
(node:17108) UnhandledPromiseRejectionWarning: Error: Expected to find "onResponseReceivedEndpoints" with content "commentRenderer" but got undefined
    at Object.findNode (D:\code\demo\youtubeReptile\node_modules\youtubei.js\lib\utils\Utils.js:39:22)
    at parseComments (D:\code\demo\youtubeReptile\node_modules\youtubei.js\lib\parser\index.js:281:27)
    at Parser.#processComments (D:\code\demo\youtubeReptile\node_modules\youtubei.js\lib\parser\index.js:351:12)
    at Object.COMMENTS (D:\code\demo\youtubeReptile\node_modules\youtubei.js\lib\parser\index.js:33:48)
    at Parser.parse (D:\code\demo\youtubeReptile\node_modules\youtubei.js\lib\parser\index.js:37:22)
    at Innertube.getComments (D:\code\demo\youtubeReptile\node_modules\youtubei.js\lib\Innertube.js:239:8)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:17108) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:17108) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Expected behavior
return normal response with 0 comment count.
Current behavior
throw out an error when the comment count of the video is 0
Version
Default
Anything else?
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

Hey, thanks for your report.
I believe this has already been fixed in the dev version. See #65, you can try it if you have time.

Hey, thanks for your report. I believe this has already been fixed in the dev version. See #65, you can try it if you have time.
Edit: And do note that the structure of the response in the dev version is a bit different, but also much better. You can find examples here.

Hey, thanks for your report. I believe this has already been fixed in the dev version. See #65, you can try it if you have time.
Edit: And do note that the structure of the response in the dev version is a bit different, but also much better. You can find examples here.

I changed to the new version. But it didn't work.

I get into youtubei.js/node_modules and run npm install. The function works fine now.
But when I use getInfo function , another error comes.

Sorry about that, I forgot to mark all dependencies as external in the build command. Should be fixed now (d1f2369e43bb8a78cfadef0a25798846113ba351).

I get into youtubei.js/node_modules and run npm install. The function works fine now. But when I use getInfo function , another error comes.

Don't worry about that, it's just a silent error and doesn't crash/change anything in the results, it's there just to tell you that there is something missing and it should be reported. Anyhow, thank you.

I use the newest version. The one with your dependencies repaired.
But pops out a new error.

@LuanRT Can you please check this problem?

@LuanRT Can you please check this problem?

Hi there, it's likely a network error. I haven't changed anything related to that in the latest commits so it might be something else. You can try using the debug parameter (...Innertube({ debug: true })) and see how far the library is able to make requests.

Problem above network problem, sorry about that,
But when I fixed the problem, another bug pops.
I'm pretty sure is not network issue.
I already intall the lastest version.
Can you tell me how to fix it? Thanks. @LuanRT


Can't resolve './locale' using react-moment

Had an issue when I run develop script.
package.json
"moment": "^2.25.1",
"react-moment": "^0.9.7"

jsx component
import Moment from 'react-moment'
throws

warn Module not found: Error: Can't resolve './locale' in 'D:\Projects\development\sample-site\node_modules\moment\src\lib\locale'

rolling back to 2.24.0 fixed the issue. Closing this ticket


Instantiate Simplifiable types within contextual type instantiation when inference candidates are available

Fixes #46201
Highly related to #48823
The problem was that in this case, even though there were some inference candidates here, the conditional type was not instantiated "soon enough". It was especially surprising to me, as a user, as changing the position of this conditional type was fixing the issue:
   assignment: (ev: TEvent) => void
 ): ActionObject<TEvent>;

+type NoOp<T> = { [K in keyof T]: T[K] };
+
 declare function createMachine<
   TTypesMeta extends TypegenConstraint = TypegenDisabled
 >(
   config: {
     types?: TTypesMeta;
   },
-  action?: TTypesMeta extends TypegenEnabled
-    ? { action: ActionObject<{ type: 'WITH_TYPEGEN' }> }
-    : { action: ActionObject<{ type: 'WITHOUT_TYPEGEN' }> }
+  action?: {
+    action: TTypesMeta extends TypegenEnabled
+      ? ActionObject<{ type: "WITH_TYPEGEN" }>
+      : ActionObject<{ type: "WITHOUT_TYPEGEN" }>;
+  >
 ): void;

You can checkout the playground with both variants here.
So how both of those cases were different?
The working variant was able to retrieve the contextualType within inferTypeArguments as:
TTypesMeta extends TypegenEnabled ? ActionObject<{ type: "WITH_TYPEGEN"; }> : ActionObject<{ type: "WITHOUT_TYPEGEN"; }>

Where within getContextualTypeForObjectLiteralElement  the getApparentTypeOfContextualType was returning:
{ action: TTypesMeta extends TypegenEnabled ? ActionObject<{ type: "WITH_TYPEGEN"; }> : ActionObject<{ type: "WITHOUT_TYPEGEN"; }>; } | undefined

and from that type a type for the action property was unpackages by getTypeOfPropertyOfContextualType. So a conditional type itself, as a type for this property, was returned to inferTypeArguments and it was simply instantiated using instantiateType(contextualType, outerMapper), so the correct type was computed just fine here.
The problem with the broken variant was that the conditional type wasn't instantiated in getApparentTypeOfContextualType (while the contextualType there was this conditional type) and it was passed to mapType(instantiatedType, getApparentType, true). This converted the conditional type to a union of its branches:
{ action: ActionObject<{ type: "WITH_TYPEGEN"; }>; } | { action: ActionObject<{ type: "WITHOUT_TYPEGEN"; }>; } | undefined

This has lost the relation between the condition and those union members.
So my idea is that we could just instantiate conditional types early to avoid such situations because if we can evaluate the condition it should always be better to focus on the resulting branch than to unionize both of them.

@ahejlsberg this fix tries to fix the weird inconsistency where the position of the conditional type in the second parameter to a function call changes what is inferred for types without callable signatures (see the seemingly harmless position change in the diff presented at the top of this thread here, or play with this TS playground).
The problem is that the contextualType is a conditional type here and because it's not instantiated "soon enough", the type for an object property becomes a union of both branches of that conditional type. So the idea here is that if there are some inference candidates already, gathered from the previous argument then we should be able to resolve this conditional type - effectively choosing one of its branches. This allows the whole thing to be narrowed down correctly and as expected. It removes the weird effect that the inferred type is so sensitive to the position of the conditional type in the second argument.

@RyanCavanaugh @ahejlsberg any thoughts on this approved PR?

@jakebailey would you be so kind to create a playground for this PR? 😉

thank you ❤

Is there anything that could be done to move this approved PR forward? @RyanCavanaugh @ahejlsberg

@ahejlsberg can you give your opinion on this PR?

This PR would be greatly appreciated for XState v5 🥺 🙏

Since it's a good time in the release schedule to land things right now... @ahejlsberg friendly 🏓

From what I gathered, the team stops accepting new language features~ for 5.4 in a week. Is there anything that could be done to move this forward or at least get some update about the status of this one? cc @RyanCavanaugh @ahejlsberg @gabritto @weswigham

@typescript-bot pack this
@typescript-bot test this
@typescript-bot test top200
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top200
@typescript-bot run dt
@typescript-bot perf test
@typescript-bot perf test public

Ok, I have some investigation to do here 😉

Woah. This isn't breaking because the PR is 600 some commits behind, right? (I didn't implement the error deltas pipelines so I don't know if they're actually using the right commits on PRs.)

@jakebailey could you re-run the same suite of tests for me here now? I've synced with main (the last sync was in June).

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot perf test public
@typescript-bot user test tsserver
@typescript-bot test tsserver top100

Seems like it wasn't a fluke, and this is very breaky?

Seems like it wasn't a fluke, and this is very breaky?

Yeah, it seems like it. I reviewed a couple of those and started work on extracting new test cases. I think that all of those might be related to instantiating indexed access types. This is something that wasn't originally in this PR - I only added it because it felt like maybe they would fall into the same category as conditional types. I removed this now and it would be cool to rerun all of those tests.
I will also take another look at the core issue. I created this PR almost 2 years ago and I learned a lot about the codebase in the meantime 😉 Maybe I will be able to figure out some alternative solution to the original issue (but maybe not).

@typescript-bot test top200
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot perf test public
@typescript-bot user test tsserver
@typescript-bot test tsserver top100

Oh, that's not great for me 😅 I'll have to extract some test cases out of this to add as tests to the repo, and... gonna get back to the drawing board to figure out a different fix for this.


Expansion on PR #854, missed this hardcoded section in the auto-dump (shift + D).

Expansion on PR #854, missed this hardcoded section in the auto-dump (shift + D).

 Fresh PR incoming.


MB-4425 Filter Move Orders by Office User GBLOC in TOO

Description
An TOO should only see move orders that have their same GBLOC, so apply a GBLOC filter to the move orders queue
Reviewer Notes

Setup

Open admin user app and create a new admin user, stop at the point that the form expands to include roles

make clean db_dev_e2e_populate
make server_run
make admin_client_run

Bring up client user app and create a move
Choose a Transportation Office that is different from the one your chose for the  admin user.

make client_run

On admin app, choose Tansportation Ordering Officer

Open Office App, sign in as TOO with your admin user

make office_client_run

The Move created should not appear on the list.

Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
this article explains more about the approach used.

Screenshots
If this PR makes visible UI changes, an image of the finished UI can help reviewers and casual
observers understand the context of the changes. A before image is optional and
can be included at the submitter's discretion.
Consider using an animated image to show an entire workflow instead of using multiple images. You may want to use GIPHY CAPTURE for this! 📸
Please frame screenshots to show enough useful context but also highlight the affected regions.

Messages

:book:
:link: MB-4425

  Generated by :no_entry_sign: dangerJS against 9a9f988cc8249701f72d70e868e9f3dda68c8665

A couple of notes:

Do we need to authorize the get orders handler endpoint? In my PR, I am only allowing office users with the TIO role to fetch the list of payment requests.
I noticed that we never wrote a test for this endpoint. The pkg/handlers/ghcapi/move_order_test.go file does not test the ListMoveOrdersHandler function.

I will be pushing my PR up soon, which makes it easy to set the roles in the session for testing authorization.


Reorg docs and docs menu bar

Preserve existing URLs with Hugos aliases front matter property

Move all Language Family Buildpacks content into the How To
section though eventually these may be split up and parts of
them moved to the reference section. For now, perhaps with
some small title changes, they fit better under How To.

Closes #186
Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

PR DEPLOYED TO: https://paketo-staging--reorg-docs-186-zyxni2e6.web.app
SITE EXPIRES AT: 2021-07-05T06:11:17.541144468Z (in 72h)

Still a draft because I have to deal with the .Net Language Buildpack module stuff still.


added event.preventDefault()

Added event.preventDefault() referring to issue #189

@ghosh , new PR request sent #191


Create xcNFT.md

Project Abstract
xcNFT is a common good pallet/substrate module meant to enhance the cross-chain experience and bring real adoption to cross-chain non-fungible asset sharing in Polkadot and Kusama ecosystems.
Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[x] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[x] I have read the application guidelines.
[x] Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
[x] I understand that an agreed upon percentage of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
[x] I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
[x] The software delivered for this grant will be released under an open-source license specified in the application.
[x] The initial PR contains only one commit (squash and force-push if needed).
[x] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

Hey @semuelle ,
Thanks for your feedback.
We haven't been in contact with the Unique team. While we believe, that the NFT Collective is a good initiative, we still believe, that more solid XCM NFT pallet options are viable for the ecosystem. Our solution adds many UX improvements and useful features on top of what xNFT currently offers extending the possibilities further. We also wish for our solution to be fully curated by the community once it is ready and we also had an idea of creating a collective where Parachains could vote on what should and shouldn't be added to the pallet. After the pallet is fully developed, this project could also become part of NFT Collective where Parachain teams will directly curate the next features as we originally planned, making the process simpler for us and the community. We will get in touch with the Unique team about this matter later on once the major part of work is done.
As for the benefactor/legal entity/business that is stated in the application:
The benefactor of the proposal is ParaSpell team receiving funds to a business called Michael Absolon with a Business address in Postajok 270/5, 085 01 Bardejov. The Business is registered in Slovakia. I will update the application to reflect this.

Thanks for your approval @semuelle .
We will fill out this form as soon as possible.
I will ping you about the completion of KYB afterwards.

Hey @semuelle ,
The KYB form has been filled out.
With kind regards,
Team ParaSpell✨

Hey @semuelle ,
The KYB form has been filled out.

Hello there, I'm a core dev from the Unique Network team.
As I can see, your proposal mainly highlights two issues: 1) the lack of adoption of cross-chain NFTs in the Polkadot ecosystem
and 2) the related UX problems.
I want to leave my comments on both of the matters.
Adoption
First, there's nothing really to adopt if we speak about Substrate-based tools.
The PoC we made in cooperation with Karura isn't a general solution. And other tools have their limitations.
We did make a generalized version of the PoC pallet.
However, eventually, we deemed it too concrete to be a universal solution and not aligned with the spirit of the Polkadot SDK (where we want to include all the XCM NFT-related Substrate tools).
This is the reason why our XNFT pallet hasn't received any updates. We were implementing an abstract and granular solution
that requires less effort to integrate with any existing NFT engine. In some cases, it even doesn't require an additional pallet to support NFT derivatives.
Our current Substrate solution is in the review stage.
We are in contact with the Parity team, so not all discussions happen in the PR at the moment.
This solution includes rich doc-comments, but we will also separately release the detailed documentation and guidelines as they are already covered by the Treasury grant.
It might seem intimidating if you look at the implementation size, but it is relevant only to SDK maintainers, not the users.
The parachain teams will use only the parts they need according to the guidelines we release.
We are developing a general solution so that everyone can benefit from cross-chain NFTs regardless of the particular NFT implementation they have on their chain.
We believe it is important because NFTs have much greater potential than just artwork. For example, they can be various capability tokens, on-chain shared variables, in-game characters and objects, etc.
Because of this potential, it is natural to expect many different NFT engines with unique capabilities to exist on various chains.
We believe all of them should have a clear way of integrating with XCM (including the EVM+Substrate engines).
This is the reason why XCM functionality is separated from NFT engines.
Moreover, our solution aligns with the existing XCM framework from theoretical and practical perspectives.

Theoretical: Our current work is based on the reserve-based transfer model. The teleports are outside the scope of the current grant but are planned for the future.
Practical: Our solution provides tools to easily build an XCM Asset Transactor compatible with the XCM executor.

Your proposal doesn't fit into the existing XCM framework. I see you're using Transact to perform the transfers. Essentially, you're modeling the teleports as follows: you destroy an entity on the sender chain and create another on the receiver chain. So, you are attempting to make a custom mechanism without utilizing the transfer model provided by the XCM[^1].
Even if you were using the teleports, you'd still need to provide a custom data communication system (again, using the Transact). However, it is inherently not universal. For the XCM data communication problem, we proposed the RFC Draft "XCM Asset Metadata", which we will finalize after the primary XCM NFT efforts.
At this moment, we focused on the reserve-based model since it is the most general way of transferring entities between chains without inducing trust between the communicating parties. There are use cases for NFT reserve-based transfers even without metadata operations. For details, see my Sub0 presentation.
UX

Once enough Parachain teams implement cross-chain NFT support - ecosystem/dapp developers might want to create JS/TS packages that provide simple wrappers lifting developers from implementation complexity further.

There is no need to wait since the XCM interface already supports NFTs. How to implement this interface on-chain is an implementation detail.
We are in the final stages of developing our "Simple XCM" TypeScript library. It supports every XCM version transparently to users, estimates total fees on all communicating chains (thanks to the XcmPaymentApi by Unique Network and the XCM DryRunApi by Parity), reports descriptive errors if found, and provides a registry of XCM locations and currencies (+ the registry can be modified dynamically).
Thanks to the provided registry, the library user can use descriptive names for locations (accounts, chains, asset IDs, etc.) instead of relying on XCM Locations directly.
Moreover, the library supports both pallet-xcm and pallet-xtokens.
Hovewer, there is an extra issue regrding Asset Trapping: we want to have a clear way to rescue NFT assets if they are trapped regardless of fee estimation. Our accepted XCM RFC "Custom Asset Claimer" solves this.
Conclusion
I believe you can use the tools we are developing and build something on top of it. Our abstract Substrate solution takes into account that a collection can be viewed as an asset, for example. So, you can implement your vision of transferring whole collections across chains.
I would like to propose that we collaborate to maintain and improve the upcoming "Simple XCM" library. Our goal is for this library to be maintained by the community, rather than just by us. It would be fantastic if we could work on this together as members of the NFT Collective.
Another thing we can work on together is developing and refining educational materials around the XCM NFT stack.
The Treasury covers these activities as part of our grant.
[^1]: When I started my research, I thought I would do the same. I described something similar to your solution (and some other variants) on the Polkadot Forum but eventually realized this path wasn't correct.

@mrshiposha , thanks for finding time to respond to this Grant proposal PR. We appreciate it as it adds to the discussion.
We agree with you about the following:

We believe it is important because NFTs have much greater potential than just artwork. For example, they can be various capability tokens, on-chain shared variables, in-game characters and objects, etc.
Because of this potential, it is natural to expect many different NFT engines with unique capabilities to exist on various chains.

Our vision towards the future is to enhance and support such unique use cases - as that is where the power of NFTs shines and unlocks the ability to introduce unique niche projects to the ecosystem.
We believe, that this isn't correctly understood from your side:

Your proposal doesn't fit into the existing XCM framework. I see you're using Transact to perform the transfers. Essentially, you're modelling the teleports as follows: you destroy an entity on the sender chain and create another on the receiver chain. So, you are attempting to make a custom mechanism without utilizing the transfer model provided by the XCM1.

The solution you were looking at is our PoC solution - Demo. Think of it as the PoC your team delivered to the Karura. This solution will look completely different after refactoring and feature implementation. While it isn't meant to be directly implemented into SDK like the solution you propose it brings another perspective (Like the one you proposed in your PoC, but better in abstraction of complex details. Eg. PolkadotXCM (SDK) vs xTokens (3rd party implementation)). While we agree with you, that it isn't fully universal, it off-lifts maintenance requirements on SDK proposed by your Substrate solution. This allows our/other teams to release/implement updates/bug fixes faster without having to rely on a third party (Some updates in SDK can take a while to be merged as the amount of code is insane and maintenance needed to keep everything up requires lots of effort from multiple people within Parity team (For which we think they are heroes in many ways).

We are in the final stages of developing our "Simple XCM" TypeScript library. It supports every XCM version transparently to users, estimates total fees on all communicating chains (thanks to the XcmPaymentApi by Unique Network and the XCM DryRunApi by Parity), reports descriptive errors if found, and provides a registry of XCM locations and currencies (+ the registry can be modified dynamically).
Thanks to the provided registry, the library user can use descriptive names for locations (accounts, chains, asset IDs, etc.) instead of relying on XCM Locations directly.
Moreover, the library supports both pallet-xcm and pallet-xtokens.

This isn't new. We already offer everything you mentioned at ParaSpell for quite a while now in both XCM SDK & XCM API.

I believe you can use the tools we are developing and build something on top of it. Our abstract Substrate solution takes into account that a collection can be viewed as an asset, for example. So, you can implement your vision of transferring whole collections across chains.

Could you explain what the benefits of having collections viewed as an asset are?

I would like to propose that we collaborate to maintain and improve the upcoming "Simple XCM" library. Our goal is for this library to be maintained by the community, rather than just by us. It would be fantastic if we could work on this together as members of the NFT Collective.

We would suggest you to check what ParaSpell XCM libraries currently offer. We believe we offer the best UX abstraction from developers on the market. Perhaps forces could rather be joined to perfect already existing XCM Tools at ParaSpell and further increase XCM adoption in the ecosystem.
Let us know what you think.
Once again thanks for taking your time responding to this proposal. This is much appreciated!

@dudo50 Thanks for the clarification.

This isn't new. We already offer everything you mentioned at ParaSpell for quite a while now in both XCM SDK & XCM API.

We aim to create something simple to maintain and use with solid fee estimation mechanisms (using the new Runtime APIs). The XCM SDK you mentioned looks similar in idea, but it is more comprehensive than the simple library we want to create.
However, we could collaborate on fee estimation. Maybe we can split our library into several packages so you can re-use the fee estimation based on Runtime APIs without introducing the dependency on our whole library—just a tiny package. (I see you have fee estimation, but it seems it is scenario-based, not xcm-dry-running-based. Please correct me if I'm wrong.)

Could you explain what the benefits of having collections viewed as an asset are?

Looking at your PoC, I noticed that you've added support for cross-chain transfers of collections (collection_xtransfer).
It's possible to use the existing XCM interface (pallet-xcm / xtokens) to support this use case if a collection is viewed as an asset. This way, it is possible to teleport the collection like other assets (assuming data communication is implemented).
In short, the benefit is the client interface consistency.

@dudo50 Thanks for the clarification.

@mrshiposha No worries!

However, we could collaborate on fee estimation. Maybe we can split our library into several packages so you can re-use the fee estimation based on Runtime APIs without introducing the dependency on our whole library—just a tiny package. (I see you have fee estimation, but it seems it is scenario-based, not xcm-dry-running-based. Please correct me if I'm wrong.)

That would be brilliant and we are more than open to it! We have been looking to improve the fee mechanism for a while now. Having more precise fee calculation would be a great benefit for all three of our XCM tools (XCM SDK, XCM API & mainly XCM Router). Here is my telegram handle - Dudo50 feel free to contact me and we can establish a ParaSpell<>Unique telegram group where we can cooperate on this matter.

Looking at your PoC, I noticed that you've added support for cross-chain transfers of collections (collection_xtransfer).
It's possible to use the existing XCM interface (pallet-xcm / xtokens) to support this use case if a collection is viewed as an asset. This way, it is possible to teleport the collection like other assets (assuming data communication is implemented).
In short, the benefit is the client interface consistency.

Thanks for clear explanation. We agree, that this could be beneficial for the user. However as the functionality is not yet present(merged) we will try to implement it our way first to see, if we can come up with another solution that makes sense and is user friendly (Because we have something in mind for this). However, in the future, once your solution is merged, we are more than happy to replace the mechanism if it will outperform what we designed.
Looking forward to hearing from you on telegram in regards to the fee estimation package.
Take care!

@dudo50 thx for pinging and sorry for the delay. I'm planning to give you feedback by tomorrow EOD.

Hi @dudo50 what name did you submit for KYB under? I'm not finding anything under ParaSpell Research Foundation?

Hey @keeganquigley ,
Under business name mentioned in the proposal: Michael Absolon

Hey @dudo50 , we have released a dev environment to play with the NFT XCM as it will go into production, see here for instructions: https://gist.github.com/mrshiposha/42797eff799b33e7e1599665638330d2
Feel free to reach out to the team for any assistance.

Thanks @am-uniquenetwork , we will have a look on it asap! Could you leave us your telegram where we could reach you guys? Thanks!

@NFTXCM is a channel, just set it up

Could you send us invite link? Or you can directly invite me and I will invite my colleague - @Dudo50

https://t.me/+AIYQDXg-EKU1MzRi
On Fri, Sep 27, 2024, 3:36 PM Dusan Morhac @.***> wrote:

Could you send us invite link? Or you can directly invite me and I will
invite my colleague - Dudo50
—
Reply to this email directly, view it on GitHub
https://github.com/w3f/Grants-Program/pull/2358#issuecomment-2379303303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLUW2X3ANK7XIUOWIJPL5D3ZYVNMNAVCNFSM6AAAAABMAXO67KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZZGMYDGMZQGM
.
You are receiving this because you were mentioned.Message ID:
@.***>


VS Code does not recognize javascript anymore after update

VSCode Version: 0.10.11 (0.10.11) f291f4ad600767626b24a4b15816b04bee9a3049
OS Version: OSX 10.11.4

Ever since VS Code updated and restarted, no files or projects have intellisense nor does it have peek definition, go to definition, etc. It cannot find references to symbols either.
I've tried the insider release and the 10.10 as well. This just started happening within the last week and I have been using Code since release in 2015.
Steps to Reproduce:

Open any project (including new express app in the node example page)
Nothing works and VS Code does not resolve any references.

I've added jsconfig.json as well and restarted, but it did not make any difference.

Same here with:

VSCode version 1.0.0
Windows 10

It was working before updating yesterday. I have a jsconfig.json and some d.ts files but I'm not getting any intellisense or go to definition etc.
After I updated, I got a lightbulb saying that I should add a jsconfic.json even though I already had one.

I seem to have got it working again by closing VSCode and then re-opening it using the Open with Code context menu item. Just closing and re-opening didn't help, but opening it this way did.
Fingers crossed it'll be that simple for @mshi.

@dbaeumer any idea what could have gone wrong here?

@mshi how is your OSX file system configured in terms of case sensitiveness. We have reports that JS features disappear on a case sensitive OSX file system.

@mshi would you be able to share your workspace ?

@dbaeumer Hi, yes my OSX file system is case sensitive. This only started happening recently, as mentioned in original post.
And no, sorry I am unable to share my workspace. But like i mentioned, downloading a fresh copy and starting a fresh template express project results in the same behaviors.

@mshi you are affected by this: https://github.com/Microsoft/TypeScript/issues/8139
Closing as dup.


Docs incorrectly claim that decimal is fixed point

This documentation seems to insinuate that decimal represents a fixed point number, when really it is a floating-point number like double and float.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb6905a9-e9ec-df6f-5733-dfb25a41b97a
Version Independent ID: fe0e2716-651b-a883-6371-ded1ace94a11
Content: Numbers in C# - Introduction to C# tutorial
Content Source: docs/csharp/tutorials/intro-to-csharp/numbers-in-csharp-local.md
Product: dotnet-csharp
Technology: csharp-get-started
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Related (for the interactive tutorial): #17103

We also have this issue in the standard. We're planning to address it there, so I'm happy to see us fix it here as well.


[release 2.0] cherry pick EntryCache fix to release 2.0

Signed-off-by: MyonKeminta<EMAIL_ADDRESS>What have you changed? (mandatory)
This PR picks https://github.com/tikv/tikv/commit/f30f494d05156db45931a161bb26ea27f6f84fd2 (PR #3529) to branch  releae-2.0.
What are the type of the changes? (mandatory)

Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)
make dev.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No

@zhangjinpeng1987 make dev passed on my own PC, but it seems there are some configuration issues on circle ci so that it cannot run on this old branch.

@MyonKeminta
Please fix CI.


CASSANDRA-19635 - Run integration tests with C* 5.x

JIRA link: https://issues.apache.org/jira/browse/CASSANDRA-19635
PR contains necessary changes to run integration tests with Apache Cassandra 5.0-beta1. Developers can run the tests using:
$ mvn clean install -Dccm.version=5.0-beta1 -DtestJavaHome=/opt/java17/home -Ptest-jdk-17

Make sure you have latest CCM version installed locally and available in $PATH.

Agree with @tolbertam ; well done @lukasz-antoniak!  There are a few nits I'd like to see cleaned up but once those are in place I think I'm a 👍 as well.

Excellent, thanks for making those final changes so quickly @lukasz-antoniak!  With your most recent work I believe we have all the code changes we need to get this merged!
The next step is to consolidate all of these changes down to a single commit.  If it's useful we've provided some fairly detailed instructions on how to do this in a comment on a prior PR.  In your case the commit message should read something like the following:
CASSANDRA-19635: Run integration tests with C* 5.x

patch by Lukasz Antoniak; reviewed by Andy Tolbert, and Bret McGuire for CASSANDRA-19635

Feel free to ask questions if any part of that process isn't clear!

Yup, this looks good to me.  Thanks @lukasz-antoniak!


chore: add initial packages/backend directory

chore: add initial packages/backend directory
What does this PR do?
Moves the file structure to the packages/backend directory in
preparation for shared and frontend directories.
Screenshot / video of UI

N/A, should compile / build / etc as normal
What issues does this PR fix or reference?

Closes https://github.com/containers/podman-desktop-extension-bootc/issues/169
How to test this PR?

Be able to use it as normal / as before. All normal functions such as
yarn watch and yarn build will work.
To test you WILL have to supply the backend directory to Podman Desktop:
yarn watch --extension-folder ../bootc/packages/backend
Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

FYI this includes some "svelte" information which will be applicable for webview shortly (build page PR coming this week).


Can not find / install ffmpeg and nasm

brew config output
HOMEBREW_VERSION: 3.1.3-91-gfb7d19c
ORIGIN: https://github.com/Homebrew/brew
HEAD: fb7d19c6618f90b30c463fa854ae241fb5e0bacc
Last commit: 18 hours ago
Core tap ORIGIN: https://github.com/Homebrew/brew
Core tap HEAD: fb7d19c6618f90b30c463fa854ae241fb5e0bacc
Core tap last commit: 18 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 4
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: quad-core 64-bit ivybridge
Clang: 12.0 build 1200
Git: 2.24.3 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.2.3-x86_64
CLT: <IP_ADDRESS>.1.1610135815
Xcode: 12.4

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Suspicious https://github.com/Homebrew/homebrew-core git origin remote found.
The current git origin is:
  https://github.com/Homebrew/brew

With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
  git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin https://github.com/Homebrew/homebrew-core

[X] I ran brew update and am still able to reproduce my issue.
[x] I have resolved all warnings from brew doctor and that did not fix my problem.

What were you trying to do (and why)?
I just want to install ffmpeg with some extras.
What happened (include all command output)?
~ brew install ffmpeg -s --with-srt<EMAIL_ADDRESS>--with-openssl --with-openjpeg --with-decklink --with-fdk-aac  --with-libssh --with-game-music-emu
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/cask).
==> Updated Casks
Updated 7 casks.
==> Installing ffmpeg from homebrew-ffmpeg/ffmpeg
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
Error: No available formula with the name "nasm" (dependency of homebrew-ffmpeg/ffmpeg/ffmpeg).
==> Searching for a previously deleted formula (in the last month)...
Error: No previously deleted formula found.
==> Searching taps on GitHub...
Error: No formulae found in taps.
➜  ~ brew install nasm
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
Error: No available formula or cask with the name "nasm".
==> Searching for a previously deleted formula (in the last month)...
Error: No previously deleted formula found.
==> Searching taps on GitHub...
Error: No formulae found in taps.
➜  ~ brew search ffmpeg
==> Formulae
amiaopensource/amiaos/ffmpegdecklink                                                                               homebrew-ffmpeg/ffmpeg/ffmpeg
The failure also appears when using:
brew install homebrew-ffmpeg/ffmpeg/ffmpeg
What did you expect to happen?
Flawless installation of ffmpeg and all dependencies.
Step-by-step reproduction instructions (by running brew commands)
brew install homebrew-ffmpeg/ffmpeg/ffmpeg
brew install nasm

Are you sure you did this?

I have resolved all warnings from brew doctor and that did not fix my problem.

Because I'm pretty sure the advice from this warning should fix it:

With a non-standard origin, Homebrew won't update properly.
You can solve this by setting the origin remote:
 git -C "/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core" remote set-url origin >https://github.com/Homebrew/homebrew-core

ORIGIN: https://github.com/Homebrew/brew
HEAD: fb7d19c6618f90b30c463fa854ae241fb5e0bacc
Last commit: 18 hours ago
Core tap ORIGIN: https://github.com/Homebrew/brew
Core tap HEAD: fb7d19c6618f90b30c463fa854ae241fb5e0bacc
Core tap last commit: 18 hours ago
Core tap branch: master

Git thinks your core tap and Homebrew software are identical, right down to the HEAD commit. This strongly suggests that your core tap wasn't cloned completely. The easiest (and probably safest) way to fix this:
rm -fr $(brew --repo homebrew/core)
brew tap homebrew/core

Are you sure you did this?
@carlocab Yes, i did, afterwards my installation was kind of broken. So i completely reinstalled homebrew but the issue was still there.

@gromgit Thank you, that solved it 👍 However, i do not understand why i had to do this even my homebrew AND OSX installation were kind of fresh.

Great, glad that's resolved. The suggested command from brew doctor could probably be improved here, then.


Convert Tensorflow model to TFLite Model light weight converting

1. System information

Windows
-Tensorflow2

2. Code
import tensorflow as tf
import numpy as np
model_path ="Model\Path"
model = tf.saved_model.load(model_path)
converter=tf.lite.TFLiteConverter.from_keras_model(r"\saved_model.pb") #model_path
converter.optimizations=[tf.lite.Optimize.DEFAULT]
converter.experimental_new_converter = True
tflite_model = converter.convert()
tflite_model = converter.convert()
tflite_model_path="converted_.tflite"
with open(tflite_model_path,"wb") as f:
f.write(tflite_model)
Option A: Reference colab notebooks

### 3. Failure after conversion
f not isinstance(self._keras_model.call, _def_function.Function):
AttributeError: 'str' object has no attribute 'call'

### 5. (optional) Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Please give the issue a title that is relevant. This helps with searching for similar issues

I Try to convert Tensorflow model [Frozen_Graph.pb & label.pbtxt ] Into TFLite Model light weight converting.

@selvakarna Could you use the model path as follows;
converter = tf.lite.TFLiteConverter.from_saved_model(model_path)

Please ensure you're loading the TFLite model correctly using tf.lite.Interpreter.
Thank you!


Make from_dict backwards compatible in Python client.

Problem
1.24.0 release introduced backwards-incompatible change in from_dict method of Python client.
Solution
Bring back from_dict to expect transport section extracted only and deprecate the method in favor of config argument.
Checklist

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
[x] Your changes are accompanied by tests (if relevant)
[x] Your change contains a small diff and is self-contained
[ ] You've updated any relevant documentation (if relevant)
[ ] Your comment includes a one-liner for the changelog about the specific purpose of the change (not required for changes to tests, docs, or CI config)
[ ] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
[ ] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2024 contributors to the OpenLineage project

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.73%. Comparing base (159e571) to head (c5d00a1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3226   +/-   ##
=======================================
  Coverage   85.73%   85.73%
=======================================
  Files          54       54
  Lines        3119     3119
=======================================
  Hits         2674     2674
  Misses        445      445

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Newsletter-2023-05-03-translate-in-French

@bitschmidty , I think I need your help to fix the problem with ZH name please

Yeah ! check pass
Thanks @bitschmidty !


Property 'name' does not exist on type 'object'.

hi
I clone the code from the githup m and when i run the ionic ,I get this error:
 Property 'name' does not exist on type 'object'.
src/pages/home/home.ts
}
 return claims.name;
 }

I saw this issue on a different project yesterday, but I'm not able to reproduce it on this one. What class do you get this error in? Things to try:

Identify the type of claims as any.
Try using claims['name'].

What version of Node.js are you using? I'm using v6.11.0 on a Mac.

Fixed with https://github.com/oktadeveloper/okta-ionic-auth-example/commit/7b5387864a407e80717d69794e49444f356a555a.

How can i fix this error? @mraible
thanks

Have you tried my answer above? What does your code look like?

@mraible   May you help me with this please?

Can you please post this as a question on Stack Overflow? It doesn’t sound
like it has anything to do with this particular example. I’m on vacation
until next week.
On Mon, Aug 6, 2018 at 11:52 Perfect Developer<EMAIL_ADDRESS>wrote:

@mraible https://github.com/mraible May you help me with this please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oktadeveloper/okta-ionic-auth-example/issues/3#issuecomment-410756345,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABF5KdrYN42Y9MWxFWtXE2Q2hLd8wrRks5uOGZZgaJpZM4O6Gfy
.

Angular Script Code
export class SignupComponent implements OnInit {
public form = {
name: null,
email: null,
password: null,
password_confirmation: null
};
public error = [];
constructor(
private Jarwis: JarwisService,
// private Token: TokenService,
private router: Router
  ) {
    // this.signup = this.signup.bind(this)
   }

onSubmit() {
this.Jarwis.signup(this.form).subscribe(
data => this.handleResponse(data),
error => this.handleError(error)
);
}
handleResponse(data) {
// this.Token.handle(data.access_token);
this.router.navigateByUrl('/profile');
}
handleError(error) {
this.error = error.error.errors;
}
##Signup HTML FORM

                Username
                <input type="text" name="name" id="name" class="form-control"  [(ngModel)] = "form.name" required>

                {{error.name}}

                Email address
                <input type="email" name="email" id="email" class="form-control"  [(ngModel)] = "form.email" required>

                {{error.email}}

                Password
                <input type="password" name="passowrd" id="password" class="form-control" [(ngModel)] = "form.password" required>

                {{error.password}}

                Confirm Password
                <input type="password" name="password_confirmation" id="password_confirmation" class="form-control" [(ngModel)] = "form.password_confirmation" required>

                <input type="submit" class="btn btn-primary btn-sm" [disabled]="!signupForm.valid" value="signup">
                Login

        </form>

ERROR OCCUR
Property 'name' does not exist on type 'any[]'

@nabeeltahir785 Please do not comment on a closed issue. This project does not have a signup form, so your problem doesn't have anything to do with this project. Please post your question to Stack Overflow. I'm sure there will be some folks that can help you out there.


how to use your code ?

i see etcd_browser  'https://github.com/henszey/etcd-browser'  and this only support v2,   in your README.MD  i didn't see anywhere how to use  and where you set wenclient url  and port .

look cmd/config.yaml，run go run  etcd_browser
:octocat: From gitme iOS


remove FedoraResource::getNode from fcrepo-kernel-api

Resolves: https://jira.duraspace.org/browse/FCREPO-1869
This will clearly have significant implications on certain downstream projects. If this approach seems sensible, then I will create related PRs for those projects.

Do you want to create the abovementioned PRs for downstream projects before merging this?

Yes, I would like to create those other PRs before this gets merged. I was mostly waiting for feedback on whether this seems like a good approach.

Well, I buy it. :+1:

OK, then. More work for me :-)

@ajs6f I submitted PRs for all the downstream projects affected by this.

I'm going to let this whole thing sit until tomorrow to give everyone a chance to comment, then I'll merge en mass.


Add preemptible feature

Adds boolean parameter "preemptible" to be set in platforms. As Molecule instances are often short lived instances this will allow to mitigate the financial consequences of a forgoten running instance (particularly for pay-as-you-go licenced VMs, such as Windows or SLES/RHEL).


Hijack not dropping connection immediately but returns 404

Describe the bug
Hijack not dropping connection immediately but returns 404
To Reproduce
HijackHandlerHertz = func(c network.Conn) {
  c.Close()
  return
}
ctx.Hijack(HijackHandlerHertz) // returns 404 instead of dropping conneciton and not returning anything.

Expected behavior
drop connection immediately without further processing, without returning anything.
Screenshots
returns 404 not found
Hertz version:
0.5.1
Environment:
go 1.20

HijackHandler is not used for close conn. It is used for websocket.

You can read the comment.

how do i drop connection immediately?
if badIP(ip) {
how to drop connection here?
}

you can use WithOnAccept when you init your server like this:
h := server.New(server.WithOnAccept(func(conn net.Conn) context.Context {
	// do something
}))

@Duslia @wzekin i have drop bad ips inside withonaccept already but there's internal mechanism to detect queries, and in my logic if there's multiple bad queries made, the ip will be made bad and then drop inside and AFTER withonaccept.
for this query, how do i drop as fast as possible?
also, withonaccept only works if server is directly facing the client.
in my server, it's mostly fronted by cloudflare or other proxies. so still need to use x-forwarded-for ip to DROP connection as fast as possible. how do i this drop?

Not supported, establishing a connection is a Tcp level job, but x-forwarded-for is an HTTP header field and the protocol is not a hierarchy. You can read the data from the connection yourself to determine this, but hertz will not support it.

@li-jin-gou i already did the data reading from the connection. i have the ip.
now i want to drop the connection. how do i drop the connection asap? (i already detected as badip)
the problem is, i did hijack
HijackHandlerHertz = func(c network.Conn) {
  c.Close()
  return
}
ctx.Hijack(HijackHandlerHertz) // returns 404 instead of dropping conneciton and not returning anything.

this way but it returns 404 instead of not returning anything.
how to not return anything?


Added nginx dockerfile generator

What issue does this relate to?

https://github.com/digitalocean/nginxconfig.io/issues/137

What should this PR do?

generate nginx dockerfile with generated configurations

@MattIPv4 Thank you for suggestion! I applied your suggestion, can you review them? Thanks again

@MattIPv4 Committed your suggestions, thank you!


Quick sort  added

Closes: #1204
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

Looks Good. Great Work

Thanks for contribution.  :star_struck:
Keep Contributing.


Fixes problems with iter_lines when the delimiter is split

I ran into this problem today where my data would randomly have additional null strings from iter_lines.  I added a test to show the issue, then fixed it.
The only weirdness might be when no data comes back, how should iter_lines behave?  Should there be a single yield of a null string, or should it just return without yielding anything?  This edit performs the latter.

The specific issue happens when attempting to retrieve lines with a multi-byte delimiter.  Very occasionally, the delimiter ends up split between data chunks.  This results in the yielding of an additional null string.  For reading an MJPEG data stream with iter_lines('\r\n') it was causing a garbled frame every 10 seconds or so.

I see you've marked it with the Breaking API Change.  I suppose that's correct, as it was previously inconsistent.  If a null-string chunk were received then the port closed, iter_lines() would not yield anything and exit, but iter_lines(any_delimiter) would yield a null-string then exit.  With this change they both consistently yield nothing and exit.

Which I think is the more historically expected behavior.

Please define historically. In the context of the project, empty strings are historically the normal, intentionally or not.
For what it's worth, this can still be merged before 3.0 but I wanted to ensure no one merged this accidentally before we had a chance to discuss it.

Please define historically.

Sure.  Prior to the change that added the ability to define the delimiter, empty strings would not have been emitted as that only came about as a result of using split(delimiter) in place of splitlines() - they have different behavior.  split will always provide at list of at least length 1, whereas splitlines will occasionally provide a zero length list.  Because of this, when the delimiter is split across chunks, nulls are occasionally emitted.  Also, when the socket (or iter_content) emits a zero length string and nothing more, the behavior is as follows:
Behavior prior to October 2014:

iter_lines() - returns without yielding anything.

After October 2014:

iter_lines() - returns without yielding anything.
iter_lines(delimiter) - yields a zero-length string, then returns.

Side-effect of proposed fix:

iter_lines() - returns without yielding anything.
iter_lines(delimiter) - returns without yielding anything.

All this is an aside from my proposed fix, which essentially yielding if and only if there's a full line of content.  If I'm expecting a string that looks like this:  "--boundary\r\nContent-Type: image/jpg\r\nContent-Length: 65535\r\n" I'd expect iter_lines('\r\n') to yield once per \r\n.  I expect it to behave exactly as if I iterated over:
[
    '--boundary',
    'Content-Type: image/jpg',
    'Content-Length: 65535'
]

But once in a while, the delimiter is split across chunks internally, and without any change to the source content, I occasionally get an extra '' at seemingly random intervals:
[
    '--boundary',
    'Content-Type: image/jpg',
    '',
    'Content-Length: 65535'
]

The proposed change fixes the routine so that it behaves more consistently with null-string input and does not yield when there's not a line of data** in the input stream.
**Okay, there's one additional issue that's been in there since at least October 2014 that I didn't address: if using iter_lines() (without the delimiter option) AND the delimiters are \r\n AND the delimiter gets split across chunks, a spurious '' will be emitted.  That is, usually the string 'a line\r\n' will end up as ['a line'], but once in a while it'll be ['a line', ''].  This could be rectified by providing the actual expected delimiter - using iter_lines('\r\n') instead.

Here's a breakdown as I understand it.
Prior to October 2014:

Input
Process
Result

''
iter_lines()
[]

'line'
iter_lines()
['line']

'line\n'
iter_lines()
['line'] but occasionally ['line', '']

'line\r\n'
iter_lines()
['line'] but very occasionally ['line', ''] and very rarely ['line', '', '']

After October 2014:

Input
Process
Result

''
iter_lines()
[]

| `iter_lines(delimiter='\r\n')` | `['']`

'line\n' | iter_lines() | ['line'] but occasionally ['line', '']
|  'iter_lines(delimiter='\r\n') | ['line\n']
'line\r\n' | iter_lines() | ['line'] but very occasionally ['line', ''] and very rarely ['line', '', '']
|  'iter_lines(delimiter='\r\n') | ['line'] but occasionally '['line', '']'
Proposed Change:

Input
Process
Result

''
iter_lines()
[]

| `iter_lines(delimiter='\r\n')` | `[]`

'line\n' | iter_lines() | ['line'] but occasionally ['line', '']
|  'iter_lines(delimiter='\r\n') | ['line\n']
'line\r\n' | iter_lines() | ['line'] but very occasionally ['line', ''] and very rarely ['line', '', '']
|  'iter_lines(delimiter='\r\n') | ['line'] always
Since 'iter_lines() is and always has been inconsistent, it's unreliable and introduces subtle bugs.  iter_lines(delimiter=x), after October 2014 has the same problem.  My proposed change makes iter_lines(delimiter=x) consistent, but leaves the inconsistency of the original version.

This PR hasn't seen any love in a long time. @ianepperson, would mind performing a rebase to make this once-again mergable?
@sigmavirus24 @Lukasa +1? -1? I want to get this merged or closed out.

I'm generally +1 on this, though it needs to be merged into 3.0.0 rather than the master branch.

Closing in favour of #3745.


Adding mock for species_info_file from openghg_defs

Akin to PR #576 - adding mock for species_info_file as well.

Mocking the call to openghg_defs within the tests to use a static version of "species_info.json" within tests data folder.

This is to future proof this to ensure the tests aren't influenced by external changes to the openghg/supplementary_data repository.

Codecov Report

Merging #582 (72ddec0) into devel (f1d66ac) will increase coverage by 0.03%.
The diff coverage is 100.00%.

:exclamation: Current head 72ddec0 differs from pull request most recent head 22e0ef6. Consider uploading reports for the commit 22e0ef6 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##            devel     #582      +/-   ##
==========================================
+ Coverage   32.51%   32.54%   +0.03%
==========================================
  Files         173      173
  Lines       12999    13006       +7
==========================================
+ Hits         4226     4233       +7
  Misses       8773     8773

Impacted Files
Coverage Δ

tests/util/test_site.py
100.00% <ø> (ø)

tests/conftest.py
80.85% <100.00%> (+0.85%)
:arrow_up:

tests/util/test_lifetime.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


rename Maybe[A] to MaybePointer[A]

This patch is for #567: it renames Maybe[A] to MaybePointer[A] in Pony code.  The tests pass on Linux.  I didn't rename any of the internal compiler functions (e.g. is_maybe()) -- should I do those as well?

Thanks!


paket push show progress fix

thanks

mhm. still doesn't work for me.

any ideas? I'm not sure what's wrong.


Proxy authentication prompt

Hi,
I followed your instructions but when I try to open a site in a browser, I get a pop up asking for username/password. If I input correct domain\username & password, the pop up reappears.
My corporate proxy uses NTLMv2.
Any suggestions?

I am sorry, it only support basic auth, does not support ntlmv2 currently. Maybe i forgot to mention it clearly in readme. It seems possible to support ntlmv2, i just have no time to do it now.

Fair enough. Thank you.


⚠ Bofrost.be has degraded performance

In 96caf9c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1390 ms

Resolved: Bofrost.be performance has improved in 937a8c8 after 54 minutes.


[WIP] Submit/Cancel Buttons missing for VM reconfigure after Patternfly conversion

https://github.com/ManageIQ/manageiq/issues/4378

@miq-bot add_label ui, bug, wip

I have added an rspec to test for the presence of the Submit and cancel buttons in the response's body - although this test would not detect this issue caused by the haml missalignment.
Before:

After:

@miq-bot remove_label wip

@dclarizio  - please review


The LLM's response is generator and cannot be pickle

Bug Description
This issue arises when streaming=True is selected, causing the LLM's return value to be a generator, which cannot be pickle. The return value of the get_chat_result function in model/model.py is a generator, as shown in the following image.

However, in the build_vertex function in graph/base.py, it calls await set_cache(key=vertex.id, data=vertex_dict), which includes a generator. Consequently, an error occurs during the subsequent pickle process.
Reproduction

Use langflow version 1.0.15 and start langflow with make init. Configure .env to use Redis (other options like memory, disk, async also have similar errors).
Use the Basic Prompting (Hello, World) template.
Enable the Stream option with the configuration as shown in the following image.

5. After running, an error occurs while building the OpenAI model.
6.

Expected behavior
It should normally print streaming output instead of being unable to build the component with streaming=true when configuring RedisCache or reporting an error of no cache found in the conversation when configured to memory.
I hope you can provide an example of the correct usage of streaming=true.
Who can help?
@italojohnny @ogabrielluiz @nicoloboschi @zzzming @jordanrfrazier @mfortman11 @NadirJ
Operating System
Alibaba Cloud Linux 3 (Soaring Falcon)
Langflow Version
1.0.15
Python Version
3.12
Screenshot
No response
Flow File
No response

I have the same question, please fix it ASAP

Confirmed that this still exists in 1.0.18 - generators cannot be pickled. Will look into this coming week.

Has this issue been resolved? Our team has also encountered this problem. It did not exist in version 1.0.14, but it has been present since version 1.0.15.

It's a relatively tricky problem to pickle generators. We're discussing the best solution (and open to ideas!). For now, you may use the in-memory cache rather than Redis to avoid this issue, if possible for your use case. I will keep this thread updated as we discuss a solution.

@jordanrfrazier  I have debugged this issue in depth , and realized the generator functions are the main culprit and if you try to serialize it to store to redis than the purpose of generators will be defeated . As Inorder to seralize it you have to resolve its value than its not the good solution even will not work and causes memory issues.
But this issue needs special attention as if we keep relying on inmemory than it will not be scalable.

@deekshanee Thanks for looking into this. The team is in the process of designing our story around scalability and stability in our v2 API. I'll make sure that this is included in those discussions, but I don't have a timeline I can share right now. As you said, it's a tricky problem, as fully serializing the generator defeats the purpose in many cases. Certain stateful generators may have a solution, but without further investigation I don't want to go with the "easy" fix of resolving the generator and unintentionally creating harder-to-diagnose memory issues.

@jordanrfrazier Sounds reasonable to me , Definately it will take time , thanks for
the perspective


Add ArcGISRest capabilities + some classes from Territorium/gwt-elem

Added some usefull classes from Territorium Online's GWT-Elemental API
Add ImageArcGISRest capabilities

The


fix: Secret Creation sync error

Changes

(Temp) remove secret from secret generator (Will be Rolled back with a better fix)
Add a new secret which will work until secret generation is possible with sync waves
Use ArgoCD sync waves set -1 for secret and 0 for deployment

/lgtm


Report button not showing

The report button isn't showing up. http://puu.sh/q7L1C/188dc4dd0d.png
someone's not following their panel, and I have to disable ANBT to report.. ಠ_ಠ

Please check the settings page. Removing flagging is a feature.

oh, sorry :L


Project is maintained again so removed unmaintaind status from the re…

Removed the unmaintained status from the README.md

#199


Release v0.27

@digitalcraftsman @moorereason I have just trimmed the release notes; add/edit if you want.
Note: We now release from CircleCI and this branch so to create a little less noise add [ci skip] to your commit messages. You will not accidently trigger a release.
That process is now in broad steps:

Release process is triggered from branch names release-
There is a manual approve step after the basic build
First it creates a release notes draft.
A rename to "-ready.md" then triggers a second build-approve-release flow which does the actual binary building and releasing.


TTL failure does not trigger .on("failed",...) event

I have a fairly simple excerpt below (using 0.9.4):
var job = queue.create('test_job', {title: 'test_job1'}).ttl(5000).save().removeOnComplete(true).on("complete", function(){
console.log("success");
}).on("failed", function(){
console.log("failed");
});

For some reason, after 5 seconds, even though express shows the job as TTL failed, the console never prints "failed". It would always proceed until completion. Any ideas why?
Thanks!

in above code you are not using a queue.process, so queued job never gets in active.
TTL feature is activated on active jobs


Possible iOS 9 issue - one push alerts twice

When sending a single push to an iOS 9 app, the iPhone (6) alerts two times. Note that the badge is correct and also the number of shown notifications is also correct once you look in the notifications tab at the end.
It does not happen on iOS 8. Also, no problem on Android.
The app is question is built in an XCode 7 environment using iOS 9 SDK. This was tested against sandboxed/development gateway(s). pushwoosh-cordova-plugin ver. 3.6.5-1.
Here's a video recording:
https://youtu.be/cab02jKZXk0

Could you provide logs from the console of the app on iOS9?  That's super weird. Do you use release version of iOS9 (not beta)?

Yep, I used the official iOS9.
Please provide your email address since the log contains a bit of sensitive information.

Could you please send the logs to Pushwoosh suppport, please mention this thread on github.

@shaders done. Find email with subject "pushwoosh-phonegap-3.0-plugin, GitHub issue 125" / request 10710.

I just also confirmed the same issue for app using Production (aka Distribution) gateway.

Did you change Provisioning Profile / Developer Certificate on that app? I can see your device in the Database with different push token that the one in the logs file. However push token change is fine and handled correctly on Pushwoosh side.
But if HWID was changed - this could be a problem. In this case device will be subscribed twice (with two different HWID's). That's why you could receive two pushes instead of one.

It's a iPhone 6 i use for development and it has taken iOS updates from 8.x to 9.0 betas and now has the official 9.0 on it. Surely I haven't done anything directly to change HWID. Is that even possible?
And yes, I normally develop and test with two different editions of the app. One is built and signed for development and testing and is configured to talk the Pushwoosh sandbox "application". The other one is built and signed for production and release in app store, configured to to talk to the Pushwoosh production "application" / gateway.
At last, I'd say this issue is not too important unless it can or has happened to others. And as a reminder that an iPhone 5 sitting next to me with iOS 8 on it does not manifest the problem.

I would recommend to unregister device from push notifications (by calling unregisterDevice method). Then try to send push notification to check if it will arrive (that will confirm duplicate HWID theory)?

Yes, that's interesting but it won'† lead anywhere since it's an app that has own user login and logout functionality. PW registration is done upon login and un-registration on logout.
I'll try to find a little time soon to reproduce using a new test app based on https://github.com/Pushwoosh/phonegap-3-sample-app or something.

hmm.... I think I'm seeing the same issue with iOS9 on a iPhone 6 app.  After registering the app to pushwoosh, notifications are alerted twice.
Strange thing is, from looking at my server logs and pushwoosh history, my server only sent out 1 notification and pushwoosh's history shows likewise, only one notification, yet on the device itself, the alert goes off twice.

Got the same reproduced here. Looks like iOS9 bug :(
What is interesting that if Alert Style is set to "Alerts" - only one alert is displayed.
It's only "Banners" that trigger alert twice.
If you go to the lock screen - only one alert is displayed as well. If you are in the app - the push received only once.
So you can see two alerts only when display mode is set to "Banners" (which is default one) and you are on the home screen.
Tested on iPhone 6 plus, iOS 9.

+1 Same problem

We're seeing the same issue - one notification in our logs, pushwoosh logs, and the notification tray, but two alerts. Has anyone found any leads on this?

Maybe a bit unrelated but I'm running into the exact same issue using the phonegap-plugin-push plugin (once when locked, once in-app, twice at home screen)

I'm having same issue with local notification,  anyone figured this our yet ?

Found the reason for this. It's a bug of iOS 9.X (still happening in the latest version), but I think it's possible to workaround.

And fixed in https://github.com/Pushwoosh/pushwoosh-phonegap-3.0-plugin/commit/db0a73431e99d97e3ffbd7ca9858a5f64a8f195c

Can you specify what the workaround is? We are having the same issue with our native app on iOS9 and iPhone 6.

Just update to the latest version of the plugin.

Thanks shaders, but maybe I wasn't clear enough. We don't use the plugin, but we have the same issue in our iOS app, and we wanted to apply the same fix. This is why I'm asking what was the workaround.

Why don't you use plugin? You can send push token to your server and use your system but still have all the features available by Pushwoosh!

You use two kinds of push?

I use two kinds of here, I do not know whether there is an inevitable link

Just to re-ask mirono's question, but what workaround exactly did you guys do? I'm not using this plugin, and I was wondering if I could apply the same technique/workaround on what I'm working on. Thanx

If you receive two alerts - update to the latest plugin version. This thread is closed now.

I am also getting same issue When sending a single push to an iOS 9 app, the iPad mini alerts two times.(It is getting twice ,sound also getting twice  but it display once in notification bar)


[docs] Add an example with Popper and react-autosuggest

Closes #11824

not sure this solution worked for me. will retry later this weekend.

Really appreciate all these examples ... this was exactly what I needed to transition from the old react-popper implementation.

@jacobweber I'm happy to have helped :).

Yes, thanks also for this great library and for the autosuggest examples.
There may be a little bug though: when navigation with the arrow keys through the suggestions popper/paper will not scroll if the selected item is outside the visible area. Setting max-height and overflow-hidden: auto as suggested by the author did not work.
Only way I found to solve this is to omit the renderSuggestionsContainer function (styling by hand then)


Pods getting stuck into "Terminating" state on deletion after the cluster is upgraded to k8s v1.24

Rancher Server Setup

Rancher version: v2.6.6 -> v2.6-head(2c21373)
Installation option (Docker install/Helm Chart): Docker

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details:

Information about the Cluster

Kubernetes version: v1.23.7-rancher1-1 -> v1.24.2-rancher1-1
Cluster Type (Local/Downstream): Downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): ec2 custom cluster with 1-cp, 1-ectd, 2-worker

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) Admin

If custom, define the set of permissions:

Describe the bug

After upgrading the rancher from v2.6.6 to v2.6-head(2c21373) and then upgrading the downstream cluster from v1.23 to v1.24 the pods deployed before the rancher upgrade gets stuck into Terminating state on deletion with below error:

error killing pod: failed to "KillPodSandbox" for "3b4c7244-42ad-469d-960b-59ebb51a6563" with KillPodSandboxError: "rpc error: code = Unknown desc = networkPlugin cni failed to teardown pod \"ngnixtest-7769bd65df-7g7rn_default\" network: could not retrieve port mappings: key is not found"

Note: During the v1.24 KDM upgrade checks this issue was occurring on all the downstream clusters with network providers -> canal, flannel, weave, calico.

To Reproduce

Deploy a rancher server v2.6.6
Create a downstream custom cluster(1-cp, 1-etcd, 2-w) using k8s v1.23.7-rancher1-1
Create a Deployment in defalut ns using nginx(with clusterIp port-80) and create an ingress pointing to it.
Scale the nginx deployment to 2:

Upgrade the rancher server from v2.6.6 to v2.6-head(2c21373)
Upgrade the downstream cluster from v1.23.7-rancher1-1 to v1.24.2-rancher1-1
Now scale the nginx deployment to let's say 5.
From the nginx Deployment delete the older pods, NOT the one's created after scaling it up.
Pods will get stuck into Terminating state.

Result

The pods will get stuck into Terminating state with below error in recent events:

error killing pod: failed to "KillPodSandbox" for "3b4c7244-42ad-469d-960b-59ebb51a6563" with KillPodSandboxError: "rpc error: code = Unknown desc = networkPlugin cni failed to teardown pod \"ngnixtest-7769bd65df-7g7rn_default\" network: could not retrieve port mappings: key is not found"

Expected Result

Pods should terminate successfully on deletion.

Additional context

Note: This happens on 2.6head 2c21373 with no rancher upgrade, but on a k8s upgrade from 1.23 to 1.24

https://github.com/Mirantis/cri-dockerd/issues/52

This is getting fixed by bumping cri-dockerd as part of https://github.com/rancher/rke-tools/pull/155.
Also, the severity of this issue was misjudged and it should have been considered a release blocker. Luckily, new release of cri-dockerd with the fix has just became available and we're good to include it into 2.6.7.

Verified that this is addressed on v2.6-head https://github.com/rancher/rancher/commit/6a739218709a4b232a95b5739f10abdd135c14bf.
ENVIRONMENT DETAILS

Rancher Install: Docker
Rancher version: v2.6-head https://github.com/rancher/rancher/commit/6a739218709a4b232a95b5739f10abdd135c14bf
Browser: Chrome

TEST RESULT
PASS
VERIFICATION STEPS

Setup Rancher and navigate to the UI in a browser.
Created a standard user and login to Rancher as that user.
Provisioned a downstream RKE1 node driver cluster with v1.22.11-rancher1-1.
Upgraded the cluster to v1.24.2-rancher1-1; verified the cluster and nodes come up as Active and correctly reflect v1.24.2.
Navigated to Cluster Explorer > cluster > Workloads > Pods.
Restarted the nginx-ingress pods; verified that they come back up as Active:


chore: code improvements

chore: code improvements

I am going to pull down this branch and work on it to incorporate the changes and I'll push to this branch after which we can review and merge.


FEAT: Restrict Registration

Reading the registration code, it looks like anyone can register users. (I'd imagine people wouldn't host this publicly facing, but conversely their is no guide to configure this behind a reverse proxy 😉).
Adding an option through either environment variables (preferred) or a config file could allow configuration of registration restrictions, like rallly. You don't use email addresses like rallly does, so it would have to be a flag to disable registration all together, or require a invite key.

# If the value is set, the create user page will require one of the keys listed below.
REGISTER_KEYS=rick-ashley,no-secure-key,foobar

# Enable or Disable the registration page.
DISABLE_REGISTRATION=1

DISABLE_REGISTRATION (gitea)

Hey, thanks for the idea and concern about the security of the users!
GitSave is currently built for just a single user (which can be registered at setup). There's no way for anyone to create a second user unless they change the code or edit the database directly. So the DISABLE_REGISTRATION=1 would basically be set automatically after the setup first user is created.
I'll keep this suggestion in mind for the future, when adding support for multiple accounts.
Do you agree this is fine or did I miss your point?

Ahh I didn't see the middleware: userExistCheck


Luna tests are broken with the new parser

Exact issues to be identified and reported. Possibly add workarounds.

One is https://github.com/luna/luna/issues/329. Another one already reported https://github.com/luna/luna/issues/308


Do not set a context class loader when creating thread.

When creating a thread, the current context class loader (if any) will
be used to set the initial context class loader for the thread.
In Gradle's case, the initial class loader is the VisitableClassLoader
instance for the current build.
Because thread usages will always set/reset the context class loader
before/after any work actions, the initial context class loader
will be kept forever during the lifetime of the daemon.
Issue #16797
Signed-off-by: Jerome Dochez<EMAIL_ADDRESS>Backport of #17270

@bot-gradle test and merge

OK, I've already triggered a build for you.

Superseded by #17385.


Driver class, add driver, delete driver, list driver command

Looks good! Btw is it possible to add a getNextFreeDriver method in the UniqueDriverList?

Looks good! Btw is it possible to add a getNextFreeDriver method in the UniqueDriverList?

I think can. But by now in this version, we should create order by manually indicate the driver I think. I think you are suggesting the same kind of function as #49. We can do it in the next iteration after I finish the Status class.

Ok!! I'll update the Order class to use strings first

adddriver and deletedriver works well, also able to see the number of available drivers via listdriver free.

Codecov Report

Merging #70 (6206457) into master (c69abbf) will decrease coverage by 8.22%.
The diff coverage is 8.88%.

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     62.68%   54.46%   -8.23%
- Complexity      405      411       +6
============================================
  Files            84      100      +16
  Lines          1447     1704     +257
  Branches        150      186      +36
============================================
+ Hits            907      928      +21
- Misses          503      736     +233
- Partials         37       40       +3

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
68.18% <0.00%> (-3.25%)
:arrow_down:

...seedu/address/logic/commands/AddDriverCommand.java
0.00% <0.00%> (ø)

...du/address/logic/commands/DeleteDriverCommand.java
0.00% <0.00%> (ø)

...eedu/address/logic/commands/ListDriverCommand.java
0.00% <0.00%> (ø)

...u/address/logic/parser/AddDriverCommandParser.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
69.56% <0.00%> (-10.44%)
:arrow_down:

...ddress/logic/parser/DeleteDriverCommandParser.java
0.00% <0.00%> (ø)

.../address/logic/parser/ListDriverCommandParser.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
76.08% <0.00%> (-21.14%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69abbf...6206457. Read the comment docs.


docs: update readme

What this PR does:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/assign

/retest

/assign

/lgtm

/lgtm

/lgtm

/hold

/hold

/approve


Handling Many To Many Navigation Properties

I've got a MVC application with an entity that has various nested navigation properties: one to one, one to many, many to many.  I think one-to-one and one-to-many properties work fine; .ApplyChanges handles everything automagically. But I've had no luck getting Trackable Entities  to manage Many-To-Many
I ended up just clearing and rebuilding collections on the entity wholesale which works but of course... get worse as the graph gets deeper, I'll paste a snippet in at the bottom, I expect you can gleen approximately what the graph looks like.
Does this sound right? I found some discussion of M-to-M a few years ago where it sounded like it was supported but I haven't seen much discussion since, and I gather there were significant changes with EF 5 related to this.
_context.ApplyChanges(thingInput);
await _context.SaveChangesAsync();

ThingDefinition thingEntity = _context.thingDefinitions
  .Include(x => x.NodeDefinitions)
  .ThenInclude(x => x.Transform)
  .ThenInclude(x => x.Positions)
  .Where(x => x.id == thingInput.id)
  .FirstOrDefault();

//Go over the nodes that have been saved to the context - .ApplyChanges has already managed adding/removing nodes. Now do this to handle many-to-many props.
foreach (NodeDefinition nodeEntity in thingEntity.NodeDefinitions) {
	//Find the matching node that came in from the client
	NodeDefinition nodeInput = thingInput.NodeDefinitions.Where(x => x.id == nodeEntity.id).FirstOrDefault();

	//Pull the selected entities from the context using the Ids that came in from the client
	List<Position> positionsToAdd = _context.Positions.Where(x => nodeInput.Transform.PositionIds.Contains(x.id)).ToList();

	if (nodeEntity.Transform.Positions == null) {
		nodeEntity.Transform.Positions = new List<Position>();
	} else { //Clear the collection on the entity
		nodeEntity.Transform.Positions.Clear();
	}

	//and now just add everything that came in as Input
	nodeEntity.Transform.Positions.AddRange(positionsToAdd);
}

_context.SaveChangesAsync();

My mistake; I didn't realize this was in the .Sample branch.


MassFlowSources require nPorts>=1

Underlying issue: If the mass flow source has nPorts=0 (the default) the model is singular (since the mass-flow is given in some way and also zero since there is nothing connected). Note that the other fluid-boundary elements do not have this restriction, and flow-sources in other domains at least have the connector-elements.
In general this can be complicated to detect - but in this case we can just set a minimum for nPorts to document that the model requires nPorts>=1 (the actual value of nPorts should be indirectly set by connecting to the ports), and help tools test this model and detect when it is used incorrectly. That's what I did.
It might be that this modifier should be on the original declaration in PartialFlowSource instead, and/or that an assertion would be clearer.

@casella Any comment on this?


unexpected results when passing an array of keys to the through the fallbacks backend

The fallbacks backend returns early if it finds a matching translation.
Any modifications to the options hash must either be reverted in two
places or the modifications can be done to a duplicate, in which case no
cleanup is required.

Looks like this bug has already been fixed in master. I just tried applying this PR to my local master branch, and I removed the fix included in the PR, but the test still passed.
Going to close.


65 text styling

Add some stylings, would like to discuss if anything should be altered. Nothing too major.

Thanks @loganhochwald!
I've been trying to enforce semantic commit messaging for easier cherry picking and reverse commit lookup as needed. Your commits are good but it will just be easier if we have a universal convention/categories to search by for the future.
why use conventional commits
conventional commits is a widely used revision upon angular commit message format


Fix tests skipped in #282

#282 skips some tests for all GPUs except from Gen9.
It is better to investigate the problem and fix tests for available GPUs.

too old and not actionable anymore


Expand latest charge

[X] Adds the ability to expand latest_charge on PaymentIntent

Sent a bit too much with this PR.  Will recreate.


Check that cert paths exist before trying to use them

If an invalid cert path is specified, we currently give the confusing error:
error binding to <IP_ADDRESS>:443: certificate parse error

We should check that the cert exists.

The entire https system is being deprecated in favor of just using nginx


JSON Settings select bug

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.57.0 7771be8
OS Version: Windows 10 20h2

Steps to Reproduce:
It's opens options and select the first option with one click.

I can repro. @sbatten what do I do to keep the context menu from showing up directly under the cursor?

@roblourens you can specify the anchor and layout to the context menu service. If you pass the entire pencil element as the anchor, I think there should be no issue. If you wouldn't mind pointing me to the code where this is created, I would like to see what the current args are to see why this is happening.

We pass x/y coords. But if I change it to get the HTMLElement, I have the same problem.
The code is here
https://github.com/microsoft/vscode/blob/85ed0a54d1259e0f65e4a9b79bbe554a6d105214/src/vs/workbench/contrib/preferences/browser/preferencesRenderers.ts#L825
If I change the anchor line to this, which uses the full element of the pencil codicon button, same issue
getAnchor: () => e.target.element as HTMLElement,

https://user-images.githubusercontent.com/323878/118753858-ae6d6f00-b81a-11eb-8990-a878cccf07bb.mp4

@roblourens passing y+10 tells the menu service that the mouse is 10 px down so when it has to draw upwards, it avoids that zone which isn't where the mouse actually is. To create that 10px buffer, you can pass height: 10 as part of the anchor and it will draw with a buffer down. But fyi, the menu service already does this with a 2px buffer.