raspiblitz.conf permissions

The raspiblitz.conf config file is created under /mnt/hdd with permissions root:root -wr-r--r--r.  When installing bonus features such as sphinxrelay there are permission denied messages since the script is running under admin.   For instance, Line 158 of bonus.sphinxrelay.sh does not use sudo to make edits to this config file.  It seems like ownership of raspiblitz.conf should be changed to admin:admin so that sudo is not required.  Has anyone else encountered this?  Thoughts?
https://github.com/rootzoll/raspiblitz/blob/fc1d44104bc22d85ebebd7b0d6ee2240722a9edf/home.admin/40addHDD.sh#L107-L109
https://github.com/rootzoll/raspiblitz/blob/fc1d44104bc22d85ebebd7b0d6ee2240722a9edf/home.admin/config.scripts/blitz.migration.sh#L95-L97

https://github.com/rootzoll/raspiblitz/blob/7ff2ca32f29eb7383ae810dd0d3ffc688863b69c/home.admin/config.scripts/bonus.sphinxrelay.sh#L156-L159

https://github.com/rootzoll/raspiblitz/blob/7ff2ca32f29eb7383ae810dd0d3ffc688863b69c/home.admin/config.scripts/bonus.mempool.sh#L66-L69

https://github.com/rootzoll/raspiblitz/blob/7ff2ca32f29eb7383ae810dd0d3ffc688863b69c/home.admin/config.scripts/bonus.btc-rpc-explorer.sh#L67-L70)

https://github.com/rootzoll/raspiblitz/blob/7ff2ca32f29eb7383ae810dd0d3ffc688863b69c/home.admin/config.scripts/bonus.electrs.sh#L238-L241

https://github.com/rootzoll/raspiblitz/blob/7ff2ca32f29eb7383ae810dd0d3ffc688863b69c/home.admin/config.scripts/bonus.thunderhub.sh#L55-L58

https://github.com/rootzoll/raspiblitz/blob/7ff2ca32f29eb7383ae810dd0d3ffc688863b69c/home.admin/config.scripts/lnd.keysend.sh#L20-L22

If this is acknowledged as an issue then this may be a potential solution using "tee" command:
Source:
https://www.cyberciti.biz/faq/sudo-append-data-text-to-file-on-linux-unix-macos/
Method 1: Use tee command
The tee command read from standard input (such as keyboard) and write to standard output (such as screen) and files. The syntax is:
echo 'text' | sudo tee -a /path/to/file
echo '<IP_ADDRESS> router' | sudo tee -a /etc/hosts

Sample outputs:
Password:
<IP_ADDRESS>   router
This solution is simple and you avoided running bash/sh shell with root privileges. Only append or write part needed root permission.

Confirmed working fix:

echo "BTCRPCexplorer=off" | sudo tee -a /mnt/hdd/raspiblitz.conf
Should I prepare a PR to replace ">>" operators with " | sudo tee -a"?

Are you now building with the branch pre-1.7.1 ? Because this clearly was not a problem in v1.7.0.

No.  I'm still using 1.7.  It could easily go unnoticed in v1.7 since the script is just establishing defaults in the config file.  I believe it would not stop the bonus features from actually functioning.  If you are running 1.7 and try typing echo "BTCRCexplorer=off" >> /mnt/hdd/raspiblitz.conf as admin you should get the same result.  This command would require logging in as root to be successful.

on my vanilla v1.7 node:
admin@David:~ $ ls -la /mnt/hdd/raspiblitz.conf
-rwxrwxrwx 1 root root 367 Jul 21 22:01 /mnt/hdd/raspiblitz.conf

the /mnt/hdd/raspiblitz.conf is owned by root, but writable by all users.
The problem you encounter is that on your system the raspiblitz.conf has stricter permissions.

I should have noticed that. The config file must have been created by a different branch of code when I had trouble with localIP issue on Odroid HC2.  I'll review the code to see where this could have happened and report back.  We may need to check permissions after config creation if it doesn't happen normally at 40addHDD.sh

I looked through the code.  Every location that creates raspiblitz.conf seems to set 777 permissions right after.  I manually changed the permissions using chmod 777.  I'm not sure how they got altered.  I will most likely save blockchain data, wipe and start with a fresh image.  The most likely culprit is user error on my part while tinkering.  I'm going to close this issue.

when a script is run with sudo it runs with root user
so a command like:
echo "anything" >> raspiblitz.conf
would create the file with default permissions (not 777) if it wouldn't exit before.
It was probably a wrong order of scripts with some failing.

That makes a lot of sense.  I did manually run individual scripts with sudo to troubleshoot.  It was a valuable lesson learned, thanks.

The bootstrap script now makes sure that the raspiblitz.conf gets the chmod 664 with owner=root & group=sudo (admin user is in group sudo) this way every config-script called by root or admin can simply edit/write to the raspiblitz.conf but other users like additional apps can just read and not write to it. I think thats a good balance of security for now.

This will be part of the v1.7.1rc1. To be tested if:

[ ] after fresh setup raspiblitz.conf if 664 with root:sudo
[ ] after recover/update raspiblitz.conf if 664 with root:sudo
[ ] after migration raspiblitz.conf if 664 with root:sudo
[ ] other scripts running fine with the new permission

@rootzoll in af3db7f I added the cl.check.sh which makes sure there are no config entries in the CL config which would stop it running.
It runs with the bitcoin user which has no sudo access, but can uninstall the problematic plugins.
Can we add 777 permissions on raspiblit.conf or can you think of a better solution to be able to swithc those plugins off in the config if they are deactivated by cl.check.sh?

I would like to keep the raspiblitz.conf not writable to other users - especially so that other additional apps can just read it, but not write it. We can think about the bitcoin user to  the sudo group ... but the whole idea of having a seperate bitcoin user was to keep it seperated from the admin user with sudo rights - but that would be at least better than just setting 777 permissions on the raspiblitz.conf file.

Maybe having a seperate file for the cl plugins that can then be part of the CL data dir makes more sense anyway for the CL plugins? That way it would keep a clean seperation.


[cli-tool] Removing externalConfig entity doesn't clean up Vault config

Apologies if this is known/desired behavior. I did some digging through existing issues but wasn't able to find anything.
Is your feature request related to a problem? Please describe.
It seems that if you remove a Vault CR's externalConfig entity in-place, the related entity in the Vault instance's config isn't removed, leaving a "dangling" resource that isn't represented as code.
In other words, if I apply a Vault CR with this externalConfig:
  externalConfig:
    policies:
      - name: allow_secrets
        rules: path "secret/*" {
          capabilities = ["create", "read", "update", "delete", "list"]
          }
      - name: test
        rules: path "secret/*" {
          capabilities = ["create", "read", "update", "delete", "list"]
          }

And the re-apply with same CR with the externalConfig block modified as such, with the test policy removed:
  externalConfig:
    policies:
      - name: allow_secrets
        rules: path "secret/*" {
          capabilities = ["create", "read", "update", "delete", "list"]
          }

...Vault's config will still retain the test policy.
Describe the solution you'd like
In the interest of keeping application config declarative, it'd be nice if bank-vaults configure was (optionally?) able to clean-up externalConfig entities that are no longer under its management.
Describe alternatives you've considered
I guess one could remember to manually clean up old config resources in Vault when they're removed from the Vault CR, but that would defeat the purpose of having declarative config.

Hi @chrisob,
yes, this is some kind of limitation of the configurer currently. The configurer right now doesn't keep a state like configuration history, so that one definitely needs to be implemented first, so we could implement this feature. Storing those configuration entries in ConfigMaps or in CRs it's a good question, but right now we don't have something like this. It gets complicated even further when people use external configuration sources like ConfigMaps and Secrets which are selected via labels.
I'm open to extending the configurer with a state store.

The only issue with this if someone adds some config manually outside, we would delete that as well, which is not fortunate.

How about adding some config option to the CR which enables "garbage collection" of Vault config which doesn't exist in the CR? FluxCD does something like this with the --sync-garbage-collection CLI flag.
That way, users that don't want manual config cleaned up can avoid setting this option, and users that want the Vault CR to be the Single Source of Truth :tm: for their Vault config can set it.

Actually this sounds like a good idea, however, scanning Vault for all configuration options sounds like a tedious task :)

@bonifaido a good discussion here. Wanted to add my 2 cents too as I've been tracking this issue and wanted a solution and feel bank-vaults could solve it.
The problem can be further broken down and analyzed. Lets see the real issue faced by teams maintaining it.
There could be 2 sets of problem here:

A team that wants all configuration to go via vault-CR and externalConfig to be the source of truth and vault to be always in sync. So anyone looking at this vault-CR should know what's in Vault. No need of keeping an eye manually or audits (ofcourse we love automation, human shouldn't be syncing stuff). Comes with an unexpected removal of config added manually which could break stuff but for this case as @chrisob mentioned a flag could be introduced.

A team which needs a way to remove certain things that already went in either intentionally or unintentionally, either via vault-CR or manually. Just a way to configure in vault-CR to remove certain configs. As almost everything is automated via this lovely project :), it is reasonable to expect that to drop a role/policy someone shouldn't need to manually do it via vault cli/api (tedious, technical for a maintainer who doesn't know how vault works, or like our team who doesn't want to get into the business of giving out tokens to individuals to do things, we do almost everything via vault-CR cicd pipeline). Probably another option like externalConfig in the vault-crd to specify stuff to be removed.

I understand the tedious task thingi, just wanted to pen down my thoughts.

Indeed, it is great that you are bringing this topic up.
In short: to support of full lifecycle of configuration like policies, auth, groups, group-aliases in declarative way.
The proposed solution is to have:

a garbage collector that removes configuration that is not declared
a garbage collector flag, so a user can enable/disable this feature

Comparing running vault configuration against declared one should not be a very problematic issue but I can imagine that the order of removing things may matter.

Indeed, it is great that you are bringing this topic up.
In short: to support of full lifecycle of configuration like policies, auth, groups, group-aliases in declarative way.
The proposed solution is to have:

a garbage collector that removes configuration that is not declared
a garbage collector flag, so a user can enable/disable this feature

Comparing running vault configuration against declared one should not be a very problematic issue but I can imagine that the order of removing things may matter.

Just in case anyone comes here after realizing that this operator doesn't remove the configured policies and why this issue is open since 2019 ... here is the summary:

The operator doesn't save the state nor compares the old and new config.
According to the code in operator_client.go The operator works only with create/update and doesn't have any functions that handle the config removal.

That's unfortunately a deal-breaker to use this operator in production.

I believe that making a global purge is too much and will add an extra unnecessary load.
So IMO the best way to handle that is to save the difference between the old and new config then remove it. And that needs to do the 2 parts mentioned above (handling the differences and storing them in a Secret or so, and removing the config from Vault).
I will try to make a PR with that approach.


Switching to generic XSD model

This is the final version for this repo, thereby switching to brodband forum XSD model.

https://jenkins.code.rdkcentral.com/job/github-triggered/23513/ started

https://jenkins.code.rdkcentral.com/job/build-component/58800/ started.

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/16253/ started

https://jenkins.cmf.code.rdkcentral.com/job/build-component-platform/27652/ started.

build-brcm-va Console Log uploaded to Gist URL: https://gist.github.com/f6b28077a0eadaebbb06928836cc925b

Smoke tests for ['build-rpi-hybrid-refapp2'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/128357/

Smoke tests for ['build-rpi-hybrid-wpe-dunfell'/'build-rpi-mc-wpe-dunfell'] added.
https://jenkins.cmf.code.rdkcentral.com/job/test-components-flow/128358/

https://jenkins.cmf.code.rdkcentral.com/job/github-triggered/16359/ started


Communities cleanup

This is part one.
Part 2 will offer changes that might need to be debated first.
I can split this into several PRs easily if requested.
Rheinbach's websites are currently broken Troisdorf/Rhein-Sieg wasn't able to reach the person in charge. This was weeks ago.
It's the only change that might be reverted at some point if they fix their stuff.

I haven't done any before and after comparisons, yet.
https://github.com/freifunk-gluon/census-exporter/pull/41#issue-2282703047
If I understand the code correctly, it's enough to run the python exporter script.
I will update this PR, once I did that for all commits to verify their changes.

ok, so I performed tests
I removed the Dortmund related change since it causes fluctuations in the data which impede's my tests (their nodes.json is not available most of the time)

which?
unique nodes
duplicates skipped

Master without 487e3afe6d07b255d56277208e49e16a4bfe75b8
44940
1993

drop Tuttlingen
44940
1887

Update 4830.org
44940
1887

drop Uelzen
44940
1887

drop Lippe
44940
716

update Divonet
44964
716

update Greifswald
44953
716

drop Groß-Gerau
44952
716

update Hannover
44952
716

add MK
45254
717

drop Leipzig
45145
717

drop Malmö
45251
717

drop Niersufer
45251
717

update Freifunk Nord
45379
717

update Nordheide
45379
717

add Flensburg
45470
717

add Helgoland
45530
719

drop Rheinbach & Troisdorf
45530
120

drop Roenkhausen
45530
120

update Trier
45530
120

drop Ulm
45530
120

update Südpfalz
45530
120

drop Kitzingen
45530
120

sort communities by alphabet
45530
120

add Westerwald
45565
120

add Euskirchen, drop KBU v1
45302
117

add Altmühltal
45323
117

add Mittelsachsen
45452
117

add Herford
45554
117

add Luxembourg
45578
117

add Magdeburg
45607
118

Leipzig appears to be lower due to Hamburg or another request running into a read timeout.
As you can see from looking at Malmö which has 3 nodes less.
http://karte.leipzig.freifunk.net:8018/meshviewer2/data/meshviewer.json contains only 3 Gluon nodes (Leipzig switched from Gluon to OpenWrt and a new map domain)


support macos

Hey Zou.
Exciting stuff!.

@googlebot I signed it!

Thx. a lot for that addition! .

Hey Zou. Ran into some problems with the Circle CI tests.
Have to revert until we have those under control.
===
#!/bin/bash -eo pipefail
go test -v ./...
github.com/google/goterm/term
term/termios.go:302:34: undefined: syscall.TIOCPTYGNAME
term/termios.go:304:65: undefined: syscall.TIOCPTYGNAME
term/termios.go:389:85: undefined: syscall.TIOCPTYUNLK
term/termios.go:394:77: undefined: syscall.TIOCPTYGRANT
github.com/google/goterm/term [github.com/google/goterm/term.test]
term/termios.go:302:34: undefined: syscall.TIOCPTYGNAME
term/termios.go:304:65: undefined: syscall.TIOCPTYGNAME
term/termios.go:389:85: undefined: syscall.TIOCPTYUNLK
term/termios.go:394:77: undefined: syscall.TIOCPTYGRANT
FAIL	github.com/google/goterm/term [build failed]
Exited with code exit status 2
CircleCI received exit code 2

Hey zouguangxian@ are you sorting out the tests for this PR?
You could use Conditional Compiling to split the linux and MacOS tests.
Eg. http://blog.ralch.com/tutorial/golang-conditional-compilation/
I'd love to have MacOS support for GoTerm , if you don't have the cycles I'll try to find some cycles to sort out the tests. With your permission ofcourse.

Hey @skalle, Yes, you can fully control the code, I'm glad you have the cycles to do fix it.


Refactor commands execution logic into command design pattern

[x] I have searched the issues of this repo and believe that this is not a duplicate.

Feature Request

Refactor commands execution logic into the strategy design pattern.
There already was one ticket for refactoring logic from CLI: #38. However, it mainly refactored common code parts into separate classes for reusability across the entire project. But, there still are some logic leftovers inside CLI commands. Each feature/enhancement/bug_fixe might grow it, which makes testing more complex, code less readable, and more difficult to extend and maintain codebase. This is already taking its toll at the current stage of development.
Benefits:

Possibility to swap algorithms used inside an object at runtime
Isolate the implementation details of an algorithm from the code that uses it.
Code more oriented towards single-responsibility principle and open–closed principle
Ease of adding a new interface or implementing API for programmatically executing fastapi-mvc actions. (Not that this is utterly needed, but still a benefit)
Should be easier to unit test and maintain the codebase

Tradeoffs:

Refactoring effort, and the possibility of bugs introduced with this change.
One needs to know the strategy design pattern. This can make entry-level more complex.
This approach assumes one can wrap algorithms implementation in some kind of abstraction. The less similarity between implementations (method signature, needed classes/functions, etc.), the more difficult it is to implement and utilize this pattern.

On second thought, command design pattern will be a much better fit.
Since strategy and command are very similar, the benefits and tradeoffs are nearly the same. The most significant swap here is:
Possibility to swap algorithms used inside an object at runtime to the possibility to implement undo/redo
which is IMHO much better scenario for this project. Ex, in the future generators, can have --dry-run options, or possibility to "ungenerate" ex:  fastapi-mvc generate ... fastapi-mvc delete ...
Moreover, the codebase will be easier to understand and follow. Last but not least, a strategy design pattern is a good fit when you have a lot of similar classes that only differ in the way they execute some behavior. Which isn't the case here. Different commands can have totally different execution methods signatures and may require some before and after logic.
In the end, refactoring effort from strategy to command is very low because of their similarity.


Chapter3 - PT - 2.mdx

#51
Portuguese version of chapter3/2.mdx.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hi @lewtun, could you please take a look at this PR and see if something is missing? Thank you


Admin interface can create a user

Closes #55

Coverage remained the same at 79.532% when pulling 0765728b0b8a647400d14871966f744c27fe3aab on bug/55 into 061d3f553151b207ebcd9a3002bc377b9ebecc6c on master.


add_raw_html_prop

The main content extraction capability of "trafilatura" is great,
but it is a waste that the final output is text.
The raw_html property has been modified to return the HTML after the main content has been extracted.

Hi @HawkClaws, thanks but unfortunately the change you implemented is a duplicate of the output_format="xml" option as the HTML is converted to XML during processing. So the PR doesn't appear to be useful at this point.

Oops, you were already able to output with output_format="xml",
I should have read the documentation properly... shame on me!
Thank you for pointing that out.
I'll close it.


[resotometrics][feat] Turn metrics type into enum

Description
Turn metrics type into enum
Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Codecov Report

Merging #912 (d542e98) into main (829f363) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   90.25%   90.25%
=======================================
  Files          68       68
  Lines       10198    10198
=======================================
  Hits         9204     9204
  Misses        994      994

Flag
Coverage Δ

resotocore
90.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resotocore/resotocore/model/model.py
92.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829f363...d542e98. Read the comment docs.


No way to remove selected items from stream

There is the remove all button which clears the whole stream, and there are the individual buttons which remove a specific track, but no button to remove the currently selected tracks.
Also applies to playlists.

This is actually fixed in the development version. :)


Redis#mget - handle int keys too

When we do a mget which calls values_at, we normalize the keys only for checking expiration and deleting the key. Then when we call super the keys are passed as is without normalize.

Added a failing spec too.

Please let me know if you have any feedback on this.

@guilleiguaran Did you get a chance to take a look at this?


RaiseError not handled as an error

Here's a repro test script and example of the behavior:
print 1.0/(floor(cast(datepart(ms,getutcdate()) as int)) / 100)
raiserror('Some sort of status message here',0,1) with nowait;
raiserror('*** Blah blah',0,1) with nowait;
waitfor delay '00:00:00.3'
go 60
In SSMS you can see that there are errors somewhere in there even if they're not visible:

Then you can scroll to find them:

But in Azure Data Studio you can't tell there are errors in the mix:

Originally posted by @vickyharp in https://github.com/Microsoft/azuredatastudio/issues/3315#issuecomment-469916862

Jumping in here to add to this issue as this problem also applies to THROW.

In the MSDN docs I see this:

New applications should use THROW instead.

Is this in backlog because of feature deprecation? I also get the same error pattern in ADS when using THROW:


Mongo cluster support

Environment

VerneMQ Version: 1.0.0rc2

Expected behavior
It'd be great if the broker could support a mongo cluster/replica set.
The settings could look like:
vmq_diversity.mongodb.host = host1:port1,host2:port2,host3:port3
Guys, do you have any plans to support that?
Without it, mongo support has not that much sense I guess :)
Thanks!

Hi @ig0r
Thanks for suggesting this improvement. I think this would be a good feature to support and looking at the driver we use it looks like it supports both replicasets and sharded mongodb setups.
As it's not clear how much effort is needed and what the priority of this should have compared to other tasks I can't give you any indication on if/when we'll get to work on it.

ok, thanks for info!

i ran into the same issue
i tried setting the host as it is suggested for the mongo cli client
mongo --host replicaSetName/host1[:porthost1],host2[:porthost1],host3[:porthost3] databaseToConnect
so i set this environment variable
DOCKER_VERNEMQ_VMQ_DIVERSITY__MONGODB__HOST: "rs0/mongo1:27017,mongo2:27017,mongo3:27017"
unfortunately the driver can not handle this and crashes
I don't know how a verne cluster handles the mongodb connections, but would it be a workaround to connect each verne instance in the cluster to the corresponding mongodb instance?
So
Node1: MongoDB1 <- VerneMQ1
            |           |
          rs0           |
            |           |
Node2: MongoDB2 <- VerneMQ2
            |           |
          rs0           |
            |           |
Node3: MongoDB3 <- VerneMQ3

Is this something that is being developed? Is this hard to do in Erlang? In the NodeJS MongoDB-driver, this is a piece of cake. Just pass a connection string instead of each parameter separately.

I guess there are two things to find out: 1) does the mongodb driver used support clustering (I think it does) and 2) how to be able to configure this from the existing configuration format (possibly adding new config options.
I don't suppose it'd be very hard, but we haven't had time to look into this yet, so PRs are very welcome.

+1 for this improvement.
Just came across this limitation now, and am trying to figure out a solution, which will probably involve using MySQL...

+1
The issue is evident by looking at the driver used: https://github.com/comtihon/mongodb-erlang.
The client used is mc_worker_api, which supports only direct connections. For this feature, it should be used this one: https://github.com/comtihon/mongodb-erlang#mongoc----client-with-automatic-mongodb-topology-discovery-and-monitoring, also in the same package.
Please write also with suggestions, I would do it, but I have no experience whatsoever in Erlang.

(Sorry for the broken link above :) )
Maybe it could be done using the mongo_api:connect method aside the mc_worker:start_link existing call, maybe giving this another name (like mongodb-shard or similar) and subsequent exclusive set of variables, other than the one already existing.
The existing part will be then unaffected and could still be used for direct connection.

I'm more concerned with how to configure this in the vernemq.conf file. Granted, I haven't really given it any real thought yet, but that's where we have to be careful to not make backwards incompatible changes. If that can be etched out, then I think we could work on this.

+1
any decent project that uses mongo will use a cluster. if vmq cant connect to it and needs its own authentication db then why use vmq?

Any progress with MongoDB cluster support in VMQ?

Progress has been made, but there are some technical issues that have been identified with the connection pool the mongodb driver uses. The mongodb one is a fork of the one vernemq uses(poolboy) and we need to figure out how to reconcile these differences and/or use a different mongodb driver.

Checking in on MongoDB cluster support. I'm evaluating the MongoDB cloud service Atlas. All users and authentication has to be done through the admin db. The vmq_acl_auth collection is in another db which cause problems with the parameters in vernemq.conf file. Is there a way to point the authentication to the admin db but use another db where vmq_acl_auth collection resides?

@ncpe20012003 as your question isn't related to the issue topic, please open a new issue to keep the discussion here focused.

any update on mongo cluster ?

@harikrishhb work on MongoDB cluster support has stalled, at least currently. Open to contributions, but it's kind of a complex issue. But that's what I think :)
Maybe @codeadict can share some further insights, as he seemed to have taken a look into it too a while back.

@miqmago can you please check the note on SRV/replica sets in the documentation here: https://docs.vernemq.com/configuring-vernemq/db-auth#mongodb? to determine if that's  what you need.

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Ok, verified and working in the latest version, it can read from secondary clusters, thank you very much.
I think this is no longer an issue.


Support bulk block download

Originally during syncing we would download blocks from our sync peer one at a time, which was slow. This PR upgrades PoS nodes to download blocks in batches via a minimally-invasive change that has a low likelihood of breaking anything.
This upgrade has been tested between two PoS regtest nodes as well as a PoS node syncing from an existing testnet node. They both worked like a dream.

Anything else needed for this PR?

#1146
#1144
#1143  👈
feature/proof-of-stake

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @diamondhands0 and the rest of your teammates on  Graphite


[Feature Request] gRPC command for generate boiler code

Tell us about your feature request
"Hi maintainers 👋, I would like to add a tool that generates gRPC handlers as boilerplate code. This would allow us to focus more on business logic without having to manually declare function signatures. I'm really excited to work on my first open-source feature request!
Example repo: https://github.com/pandakn/GrpcGenie
Disclaimer

[X] I agree

There is already a ticket #246  open that proposes the same thing. We need to see the implementation and then decide if it goes into the codebase, but only as an advanced flag.


Open in a separate window

What an awesome idea! When I tried it, it replaced my current workspace with the remote one; I'd prefer if it opened in a new window (with the RemoteHub: Open GitHub Repository... command).

💯% agree -- Right now there isn't a good option for providing that. Here is the open request: https://github.com/Microsoft/vscode/issues/34770

Fixed in 0.5


Entity max speed setting in default global config too low

I am currently running

SpongeForge version: 1.12.2-2838-7.1.7-RC3902
SpongeVanilla version: 1.12.2-7.1.7-RC272
Java version: 8
Operating System: Windows 10

Plugins/Mods: None

Issue Description
Default config value of max-speed for entities is too low. PrimedTNT is deleted when fired from a medium-sized cannon (16 propellent) as it instantly exceeds the 10m/tick limit. Recommend changing the default to 1000 instead of the current 100.

100 (300 if you're flying with an elytra) is the value used internally by minecraft .
We should probably keep it that way.

@ImMorpheus Sorry, my bad. Forgot to mention the cannon works as expected in vanilla.
Maybe this setting doesn't normally effect PrimedTNT?


Upgrade project to XCode 11.2.1

I'm just going to close this PR. I'll be maintaining a fork over at https://github.com/sethgho/webviewscreensaver
Thanks for this screensaver! I'll be using it to power my team's metric dashboards on a TV at Atlassian.


Add reddit support

I'm submitting a ...

[ ] bug report
[x] feature request

Current behavior:

Expected behavior:

Steps to reproduce:

I would like to work on this.

closing since reddit is also not a search engine


TERM Lite built in priorities

Like in #8, this should be an optional column whose behavior is handled by the prioritization function.

Blocked by #3

One possible design consideration for both this issue and #8 is to only provide built-in functionality that is required by the model itself. Since both of these only determine prioritization, which is a user-defined problem, this make may sense to be a documented option or only necessary for using standard TERM LITE prioritization metrics, if they are built in.

Building off a the previous comment, I do not believe that this issue is relevant to the reproducing the core of TERM Lite or creating a demonstration test case. Thus I am closing this issue.


[BUG] Stack Overflow icon is broken

The Stack Overflow Icon is broken. It kinda looks like a miniature version of what it's supposed to be.

Info

OS: Windows 10
Obsidian Version: v0.12.12

I will make a fix for it. It seems I have used the wrong logo, instead of using only the logo mark, I used the logo mark + type.

I have made a local fix for myself from an other icon source.
I'll make a pull request, if you'd like. Do you have technical or license considerations? I just found an icon wherever, resized it to 12px, and URL encoded it.
I also have some more icons made like this for more sites in my local vault. Would you like more added to the theme?

you can make a PR and I would code review it.


Line numbers/offsets for nodes

I have need of knowing what line number in the source document a node comes from. This is so I can display useful errors to authors when they have errors in their markup. You could imagine a symbol on the node that gives row/col info.
Since row/col comes with some cost to performance, you could instead have a symbol for offset and let consumers map to row/col themselves, although the total overhead of consumers re-scanning the document for linebreaks is larger than just doing that work at parse-time.

We have a location info in parse5, shouldn't be hard to implement

Making a public commitment to work on this on my next jsdom day. I keep forgetting.

@inikulin looking in to this, I think this would become much easier if parse5 kept track of \ns (or \r\ns??) it encountered and included them in __location. Otherwise it's going to be a pain to translate index into line number...

@bterlson what would you think is appropriate for implicitly-created nodes? Just null locations?

Hmm. After much thinking I have a few options here:

Wait for @inikulin to update parse5 to include line and column numbers
Slow down parsing by computing line/column numbers at parsing time
Have a slow-ish jsdom.nodeLocation(node) that does the computation when it is called... at the cost of keeping the original HTML in memory, so that we can compute the line/column number.
Have an ugly and slow-ish jsdom.nodeLocation(node, originalHTML) that does the computation when it is called, and relies on the caller to keep the original HTML around
Have jsdom.nodeLocation(node) return just { character } for now, pending a future expansion to { character, line, column } later. In the meantime jsdom users would have to do the computation themselves.

So, questions:

@inikulin, do you think you'd be able to update parse5 soon with line + column? Maybe we can avoid this whole debate?
@bterlson, what do you think of the above tradeoffs?

IMO don't slow down parsing by default for something rarely needed.
On one hand I don't think it's unreasonable to provide only character offsets and let users do the mapping if they need line/col, but on the other hand an efficient implementation requires at least a binary search which is annoying. I like the last option, where line and column can be enabled via config.

@domenic I've had idea adding line/col support for parse5 and I think it will be a good addition for the v2.0 However, I'm on vacation right now, far from my laptop and good internet connection. I'll be back in the mid-september. So, please, fill an issue to the parse5, so it will not get lost in the notifications avalanche I've got right now.


Support topologies other than TriangleList

Objective
Fixes https://github.com/bevyengine/bevy/issues/3346
Solution
I've encoded the topology in the MeshKey similar to how MSAA samples are handled.

Makes sense to me!

bors r+


"Default Bicep Configuration" snippet shows up in settings.json autocomplete

Type: Bug
I see noisy Biceps entries when filling in values in VS Code's settings.json, which doesn't make sense.

Extension version: 0.17.1
VS Code version: Code - Insiders 1.79.0-insider (f1258a5fbed44b8f84a097c73c1799c13c5c3646, 2023-05-17T05:27:27.525Z)
OS version: Darwin x64 22.4.0
Modes:
Remote OS version: Linux x64 5.4.0-1106-azure

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
2, 3, 3

Memory (System)
64.00GB (0.11GB free)

Process Argv
--enable-proposed-api digitarald.chat-ai-plugins --log trace --crash-reporter-id 4cf0a6f0-aaf8-4da3-9b2b-81f6c639c12b

Screen Reader
no

VM
0%

Item
Value

Remote
Codespaces

OS
Linux x64 5.4.0-1106-azure

CPUs
Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz (8 x 2793)

Memory (System)
15.63GB (11.88GB free)

VM
0%

https://github.com/microsoft/vscode/issues/185710

There's nothing I can do unless vscode fixes https://github.com/microsoft/vscode/issues/185710 (and then I need to make a change to the extension).

Actually, I think it makes sense to remove this snippet altogether because:

we already have this command:

the snippet doesn't contain much:

we already have Intellisense for the file *if the user first saves it as "bicepconfig.json" before trying to edit
currently we only show the snippet if you set a new file to JSONC, and not JSON (because bicepconfig.json is set to be JSONC and it helps reduce the places where we incorrectly show the file, but it means that in the common scenario of creating a new file then setting it to JSON, you will already not see the snippet).


(Feature) #864 Dashboard api calls should run once in X minutes

Description
Add a new optional variable that points on minutes interval for performing background requests.
Created a new interval wrapper function for prepareLoginToken and checkBonusesToRedeem functions to send requests once per X minutes.
About #864
New ENVIRONMENT variable:
REACT_APP_BACKGROUND_REQS_INTERVAL
Default value: 10
Optional
How Has This Been Tested?
Set REACT_APP_BACKGROUND_REQS_INTERVAL value to 1
Register/login to the app.
Open network tab in browser developer tools panel.
On the dashboard screen try to reload the page a few times - you will see that requests sending only once per 1 minute.
Also, try to switch between another tab/window to check if the window focus functionality for 'checkBonusesToRedeem' fn works in the same way (means sending once per X minutes).
Checklist:

[x] PR title matches follow: (Feature|Bug|Chore) Task Name
[x] My code follows the style guidelines of this project
[x] I have followed all the instructions described in the initial task (check Definitions of Done)
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have added reference to a related issue in the repository
[x] I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
[ ] I have added screenshots related to my pull request ( for frontend tasks)
[ ] I have pasted a gif showing the feature.
[x] @mentions of the person or team responsible for reviewing proposed changes

I tested and review the latest changes locally - it seems like everything (claim animation, redeem bonus request timer, displaying of addWebApp popup) working fine.


Credentials refactor

Initial PR for re-routing credentials to use the native credentials (intercepted keytar node module) to save credentials.

[ ] TODO: Discuss scope of Native Credentials Setting
[ ] Test credential migration story on Linux (old to new system)

Pull Request Test Coverage Report for Build 699201704

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.216%

Totals

Change from base Build 699058099:
0.0%

Covered Lines:
25474

Relevant Lines:
53777

💛  - Coveralls

Closing this because I opened a new one here - https://github.com/microsoft/azuredatastudio/pull/14984


Attribution models for Marketing Channels with "Override Last-Touch Channel" unchecked

Issue in ./help/analyze/analysis-workspace/attribution/faq.md
Can the marketing Channels section be expanded to document what happens to Marketing Channels when the "Override Last-Touch Channel" is unchecked.  This information cannot be found anywhere and I am hearing conflicting views on this.
"Adobe provides generic ‘Marketing Channel’ and ‘Marketing Channel Detail’ dimensions so you can use them with your desired attribution model. These generic dimensions behave identically to Last Touch Channel dimensions" - this would indicate that a channel such as "Direct" would not override another channel on a Last Touch basis.  But what happens for other models such as linear and participation?

Does anyone from Adobe look at these?  There has been no response here.

Hi Kristi,
The team is behind in resolving some issues. But someone has been assigned this one and should be working on it in the next week or so.
Thanks for pointing out this issue -- getting it fixed is important!

@kritikality - here is the response I got from Consulting:
"Custom attribution models like linear or participation will allocate credit only to non-null instances of a dimension. The MC configuration determines only when MC and MCD instances are written and how its persistence works, etc. If an MC configuration specifies that a channel match (like Direct) should not override last touch channel, then often the matches of that channel ruleset will not result in an MC instance. In those scenarios lacking an instance, there is nothing against which to attribute credit from a custom attribution model."
I hope that helps.


.10 Beta Crash-to-desktop while pregenerating world

Also on 1.11.2 with a BoP world under the "chisel" type - but with tall city buildings and some other cfg changes.
crash paste
I was using a chunk pregeneration command block to pregen a potential server world and the crash occured very early on.  If there's more info i can get you here (cfgs or world seed) let me know.
FYI, I dont necessarily post these from a "hey there, mod developer, fix my bugs" perspective, but just to give you more info that might help you in your efforts to optimize the mod.  If it becomes more noise than signal, just let me know.

I will check it out. Thanks for reporting

Fixed in 0.0.11 which will be released shortly


about INSTALL.md and composer

Hi i am a bit confuse,
Is this package the same repo,
"connect20/Cloudinary_Cloudinary": "1.1.0"
If it is can be nice to change it in the install.md,
Thanks,

I'm sorry for my response delay.
Our Magento module can be found in here too:
https://www.magentocommerce.com/magento-connect/cloudinary-image-management-in-the-cloud.html
I'm sorry, but I'm not sure whether that's the connect20 module you referred to.

@taragano  suggest we just remove the reference to the version number in the install MD.  Its pretty clear what the latest version is.
This should be picked up in the next release
@eduardo-g-silva  - thanks for pointing it out - its confusing!

Closing after shifting to Magento marketplace and due to time elapsed.
Please feel free to reopen the issue if yet it's still relevant.


definition errors

so this is probably easily solvable but for the life of me i cant figure it out these 2 issues
#include "../features.hpp"
i get an error on the "#" and it says "invalid macro definition: /std:c++latest"
i cant find where that is defined, help!
also, this part in the code:
//call it in createmove hook,after prediction.
legitbot::aimbot(cmd);
where is createmove hook? what does that mean? Im still a bit new. the "legitbot::aimbot(cmd);" is all red lined
thanks for the help!

you ll find it in project proprieties->somewhere in c++

where in c++? theres like 12 different tabs
On Tue, Aug 11, 2020 at 11:51 AM Marius<EMAIL_ADDRESS>wrote:

you ll find it in project proprieties->somewhere in c++
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/designer1337/csgo-cheat-base/issues/75#issuecomment-672030918,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQFLP3J5MKIYZ5SIPEWDV5DSAFSHJANCNFSM4P2EO45A
.

where in c++? theres like 12 different tabs
…
On Tue, Aug 11, 2020 at 11:51 AM Marius @.***> wrote: you ll find it in project proprieties->somewhere in c++ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQFLP3J5MKIYZ5SIPEWDV5DSAFSHJANCNFSM4P2EO45A .

c/c++->preprocessor->preprocessor definitions


[Snyk] Fix for 1 vulnerabilities

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Regular Expression Denial of Service (ReDoS) SNYK-JS-ASYNC-7414156
  631

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)

Checkmarx One – Scan Summary & Details – 54f66707-c9eb-4b55-8b01-7c0f9e2c48ac
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2021-23440
Npm-set-value-2.0.0
Vulnerable Package

CVE-2021-23440
Npm-set-value-0.4.3
Vulnerable Package

CVE-2021-32050
Npm-mongodb-3.3.2
Vulnerable Package

CVE-2021-32050
Npm-mongodb-3.5.9
Vulnerable Package

CVE-2021-4264
Npm-dustjs-linkedin-2.5.0
Vulnerable Package

CVE-2022-24441
Npm-snyk-1.278.1
Vulnerable Package

CVE-2022-25881
Npm-http-cache-semantics-4.1.0
Vulnerable Package

CVE-2022-25883
Npm-semver-1.1.4
Vulnerable Package

CVE-2022-25883
Npm-semver-5.7.1
Vulnerable Package

CVE-2022-25883
Npm-semver-5.5.0
Vulnerable Package

CVE-2022-25883
Npm-semver-6.3.0
Vulnerable Package

CVE-2022-25883
Npm-semver-5.7.0
Vulnerable Package

CVE-2022-33171
Npm-typeorm-0.2.24
Vulnerable Package

CVE-2022-48285
Npm-jszip-3.2.2
Vulnerable Package

CVE-2023-26115
Npm-word-wrap-1.2.3
Vulnerable Package

CVE-2023-26136
Npm-tough-cookie-2.4.3
Vulnerable Package

CVE-2023-3696
Npm-mongoose-5.7.3
Vulnerable Package

CVE-2023-42282
Npm-ip-1.1.5
Vulnerable Package

CVE-2023-45133
Npm-babel-traverse-6.26.0
Vulnerable Package

CVE-2023-46234
Npm-browserify-sign-4.0.4
Vulnerable Package

CVE-2024-33883
Npm-ejs-1.0.0
Vulnerable Package

CVE-2024-33883
Npm-ejs-0.8.8
Vulnerable Package

CVE-2024-4068
Npm-braces-2.3.2
Vulnerable Package

CVE-2024-4068
Npm-braces-3.0.2
Vulnerable Package

MongoDB_NoSQL_Injection
/routes/index.js: 39
Attack Vector

MongoDB_NoSQL_Injection
/routes/index.js: 39
Attack Vector

MongoDB_NoSQL_Injection
/routes/index.js: 191
Attack Vector

MongoDB_NoSQL_Injection
/routes/index.js: 219
Attack Vector

CVE-2017-20162
Npm-ms-0.7.3
Vulnerable Package

CVE-2017-20162
Npm-ms-0.6.2
Vulnerable Package

CVE-2017-20162
Npm-ms-0.7.1
Vulnerable Package

CVE-2022-22984
Npm-snyk-mvn-plugin-2.7.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-python-plugin-1.16.0
Vulnerable Package

CVE-2022-22984
Npm-snyk-sbt-plugin-2.11.0
Vulnerable Package

CVE-2022-22984
<EMAIL_ADDRESS>Vulnerable Package

CVE-2022-22984
Npm-snyk-gradle-plugin-3.2.2
Vulnerable Package

CVE-2022-22984
Npm-snyk-docker-plugin-1.33.1
Vulnerable Package

CVE-2023-0842
Npm-xml2js-0.4.19
Vulnerable Package

CVE-2023-0842
Npm-xml2js-0.4.23
Vulnerable Package

CVE-2023-28155
Npm-request-2.88.0
Vulnerable Package

CVE-2024-29041
Npm-express-4.12.4
Vulnerable Package

CVE-2024-4067
Npm-micromatch-3.1.10
Vulnerable Package

Cx9b9f022f-6dff
Npm-marked-0.3.5
Vulnerable Package

Privacy_Violation
/routes/index.js: 43
Attack Vector

Unpinned Actions Full Length Commit SHA
/snyk-test-sarif.yml: 15
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code.yml: 15
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-test-sarif.yml: 8
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 57
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 71
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 46
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code.yml: 8
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/snyk-code-manual.yml: 13
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity
Issue
Source File / Package

CVE-2018-16490
Npm-mpath-0.1.1

CVE-2020-13110
Npm-kerberos-0.0.24

CVE-2020-7610
Npm-bson-0.4.23

Code_Injection
/routes/index.js: 213

Code_Injection
/routes/index.js: 155

Code_Injection
/routes/index.js: 213

Code_Injection
/routes/index.js: 155

Code_Injection
/routes/index.js: 213

Code_Injection
/routes/index.js: 155

Code_Injection
/routes/index.js: 213

Code_Injection
/routes/index.js: 155

Cx3ac14f8c-0652
Npm-mongoose-4.2.4

Cx3ec48c7c-8c0c
Npm-handlebars-4.0.11

Cxd6c215a2-86bd
Npm-mongodb-2.0.46

CVE-2007-2379
Npm-jquery-2.2.4

CVE-2014-6071
Npm-jquery-2.2.4

CVE-2019-2391
Npm-bson-0.4.23

Cx65603961-769c
Npm-debug-3.1.0

Cx65603961-769c
Npm-debug-4.1.1

Cx65603961-769c
Npm-debug-2.6.9

Cx65603961-769c
Npm-debug-3.2.6

Cx65603961-769c
Npm-debug-2.2.0

Cx73e331a8-9e08
Npm-parse-url-5.0.1

Host Namespace is Shared
/docker-compose.yml: 15

Host Namespace is Shared
/docker-compose.yml: 3

Host Namespace is Shared
/docker-compose.yml: 20

Networks Not Set
/docker-compose.yml: 15

Networks Not Set
/docker-compose.yml: 3

Networks Not Set
/docker-compose.yml: 20

Update Instruction Alone
/Dockerfile: 9

Open_Redirect
/routes/index.js: 213

Open_Redirect
/routes/index.js: 71

Open_Redirect
/routes/index.js: 304

Open_Redirect
/routes/index.js: 91

Open_Redirect
/routes/index.js: 213

Open_Redirect
/routes/index.js: 71

Open_Redirect
/routes/index.js: 304

Open_Redirect
/routes/index.js: 91

Open_Redirect
/routes/index.js: 213

Open_Redirect
/routes/index.js: 71

Open_Redirect
/routes/index.js: 304

Open_Redirect
/routes/index.js: 91

Use_Of_Hardcoded_Password
/routes/index.js: 315

Use_Of_Hardcoded_Password
/routes/index.js: 315

Use_Of_Hardcoded_Password
/routes/index.js: 315

Use_Of_Hardcoded_Password
/routes/index.js: 315


Fix version switcher on readthedocs

Description
This updates the version switcher styling on readthedocs and configures a .json file for the version switcher dropdown
Fixes #2766
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all
[x] The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

The reason why all the versions are being shown in green is because json_url is not configured in html_theme_options yet, I shall do that in this PR

@tinosulzer the readthedocs build is passing but I can not test how it would look like (if it will show versions with the correct colour scheme when hosted) – I added the version switcher dropdown to the header like you requested but it is currently not including past versions on my local build and shows up blank:

Though this configuration matches that of the numpy docs, which is why I suspect it should work as intended.
Also, the new file docs/_static/versions.json will have to be updated with the latest version on the creation of each release.  Right now there's the option "check_switcher": True in html_theme_options but that can only test whether versions.json can be found/read, and not if the file includes the latest version. Happy to write some sort of check or a warning for this if needed in the existing workflows if you could guide me with it

To keep the version up to date, add the appropriate code to https://github.com/pybamm-team/PyBaMM/blob/develop/scripts/update_version.py. This file gets run automatically at the end of every month to update the version in the various places it needs to be updated.
Also, make sure your changes don't kill the existing day/night switch and social links

You can see the built docs here, it's missing the links https://pybamm--2769.org.readthedocs.build/en/2769/
I think when "navbar_end" is not specified it defaults to the day/night and link checker, which is why they were removed by you adding a "navbar_end" without them included

That makes more sense, I updated it to include the links and the day/night button. Also TIL one can see the docs built from a PR this way

I was able to show the versions in the dropdown locally (the colours appear in the readthedocs build). This should be ready to merge now

This was done by adding the .json file at a static URL (tried it with a link to the raw file in this PR) – I was not able to get it to work with a local file:/// URL despite multiple tries (according to the second point in the docs), but remote URLs do work. So I put a link to https://pybamm.readthedocs.io/en/latest/_static/versions.json as the first point suggests; this link currently returns a 404 (fails Lychee as well), but that would be fixed after this PR gets merged and versions.json gets added to the codebase.

Looks good, thanks!


When using autoprefixer-stylus with gulp-stylus and trying to generate inline source maps file property is missing.

Hey guys, sorry for creating multiple issues in different projects but I don't know where's the problem exactly. So could you take a look at azu/multi-stage-sourcemap#3 please?

Already discussed here: https://github.com/jenius/autoprefixer-stylus/issues/17
It's an issue with gulp. I'll try to get this worked out eventually. For now, you can use gulp-autoprefixer instead and people have reported that it works fine.


Subquery ranges are left-closed and right-closed when returning the subquery result directly

What did you do?
I performed a query like metric[20s:5s] at T=30s.
What did you expect to see?
Following https://github.com/prometheus/prometheus/issues/13213 and https://github.com/prometheus/prometheus/pull/13904, I expected the result to include 4 points: T=15s, T=20s, T=25s and T=30s, ie. the point on the left boundary (at T=10s) is excluded.
This mirrors the behaviour of range selectors.
What did you see instead? Under which circumstances?
The point on the left boundary (T=10s in the example above) was included.
This is visible in tests like this one, where the point at T=10000 is included in the result, but should be excluded if the range is left-open: https://github.com/prometheus/prometheus/blob/101b1c307f2b80b142c38f7cebcc3db50084ed8f/promql/engine_test.go#L1830-L1842
System information
No response
Prometheus version
No response
Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Interestingly, #13904 did change a lot of the subquery tests, and the changes seem consistent with a left-open behavior, see https://github.com/prometheus/prometheus/pull/13904/files#diff-b1b1097ed667a65058420400e50e96853141ff29f6f46758f4abb6691778e18d

Maybe this is an artifact of how the test above is performed? The regular framework tests seem to work as expected, as does a user-driven end-to-end test. See this screenshot:

Note that I did manually align the query timestamp above (to get the "perfect alignment", which is the usual way of triggering the "one more sample than expected" case.

This is super weird. Now I managed to trigger the 5-sample case with the exact same setup as above in the screen shot.

OK, clarified by inspecting the actual HTTP requests. The UI sometimes still adds some milliseconds to the query time even if a fixed time is set. If it actually sends a perfectly aligned timestamp, I see the five samples.
Still trying to explore why the framework tests work as expected.

I think I have found something, but still have to work out the details.

Fix to be released in v3.0.1

Thanks for addressing this so quickly @beorn7!


kubelet service not running on workernode  (eks  setup)

systemctl status kubelet
● kubelet.service - Kubernetes Kubelet
Loaded: loaded (/etc/systemd/system/kubelet.service; disabled; vendor preset: disabled)
Active: activating (auto-restart) (Result: exit-code) since Wed 2020-01-01 20:09:05 UTC; 2s ago
Docs: https://github.com/kubernetes/kubernetes
Process: 29398 ExecStart=/usr/bin/kubelet --cloud-provider aws --config /etc/kubernetes/kubelet/kubelet-config.json --allow-privileged=true --kubeconfig /var/lib/kubelet/kubeconfig --container-runtime docker --network-plugin cni $KUBELET_ARGS $KUBELET_EXTRA_ARGS (code=exited, status=255)
Process: 29397 ExecStartPre=/sbin/iptables -P FORWARD ACCEPT (code=exited, status=0/SUCCESS)
Main PID: 29398 (code=exited, status=255)
Jan 01 20:09:05 ip-192-168-101-196.ec2.internal systemd[1]: Unit kubelet.service entered failed state.
Jan 01 20:09:05 ip-192-168-101-196.ec2.internal systemd[1]: kubelet.service failed.
Hint: Some lines were ellipsized, use -l to show in full.
[root@ip-192-168-101-196 /]# journalctl -xe see kubelet start describe logs
Failed to add match 'see': Invalid argument
Failed to add filters: Invalid argument
note:- on api server iam running kubectl get nodes (no resource found error)
Please assist me how to fix the issue.

hi i have been facing an issue. Issue is that when i start a container in kubernetes using yml file with image centos/ubuntu it goes to CrashLoopBackOff. when i create container using nginx image in yml file it works fine. Can you guide me please?

kubelete container is also not running at worker node


UI issues

Did not change the existing circles' card since it uses some external library. Should I redo the card entirely?

We can discuss existing circles' cards.
There's an issue with the problem shelves' card. When a user checks the section of listed problems, the highlighted orange card will stipple the eyes. So please make it minimal as we did in the mentor card.


Move tests to another repo

The nimPNG repo includes a tests folder which is quite large.  Also, some of the links in the tests are very inappropriate. I don't want kids using my game engine (which depends on nimPNG) to see that :see_no_evil:

If you install via Nimble, the test files don't get copied to the pkgs directory. However, they do remain if you are using Atlas or simply managing your own dependencies via git submodules.
Therefore I think it would be best to move the tests to another repo.

nimPNG doesn't use external links for test data. maybe they come from other sources?

The file in question is urls.10k under nimPNG/tests/zcorpus

Thank you for looking into this. I wasn't aware there are something like this in the compression test data. They were taken from other compression project.
As a compression library developer, we basically only check if the roundtrip compress-decompress works. While the content itself I never look into.
I will remove it.


Replace /var/tmp/edpm-ansible with $REMOTE_SOURCE_DIR

The variable was not used everywhere it could be used.
Signed-off-by: James Slagle<EMAIL_ADDRESS>

recheck


Add ehthumbs_vista.db as Windows thumbnail cache file

Reasons for making this change:
Add the missing entry ehthumbs_vista.db used by Windows Vista Media Center to store thumbnails, like ehthumbs.db
Links to documentation supporting these rule changes:

https://nctritech.wordpress.com/tag/ehthumbs_vista-db/
https://thumbsviewer.github.io/
https://www.file-extensions.org/db-file-extension-windows-thumbnail-database

@mems thanks!


MNT Reuse existing classes for behat test

Reuses existing classes, to replace the ones we're removing in https://github.com/silverstripe/silverstripe-frameworktest/pull/196
Issue

https://github.com/silverstripe/.github/issues/287

Found a simpler solution


Implement ixnotify

Execute command when a wallet IX transaction is successfully locked (%s in cmd is replaced by TxID)

This is fancy! Great idea. We could use this for applications like the vending machine .

closing this in favor of #749


Change WebSocket project to target netcoreapp3.0

#3754
This only changes the WebSocket package. The tests and samples were already updated.
These aren't getting updated, correct?
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore
Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore
Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests

Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore should be updated to netcoreapp3.0 since it will need to compile with FrameworkReference before we ship RTM (#4257)
Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore can stay netstandard.
Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests should update to test on netcoreapp3.0 + .net framework.

Need? No, but it's a good reminder that it's using a completely different stack for interop testing.


Revert "Upgrade regalloc2 to 0.9.4"

Reverts bytecodealliance/wasmtime#9191
We need to yank regalloc-0.9.4 and bump it to 0.10.0, as a function was removed in 0.9.4.

Oh I think this is fine to leave in wasmtime, yanks don't delete the crate it just prevents new dependencies being formed on the crate. In that sense if you yank regalloc2 now then wasmtime will keep building. In that sense this shouldn't be necessary

Ah, I misunderstood what the effect of yanking the crate was. I'll close the revert :+1:

If anyone tries to depend on the wasmtime version on the main branch as library, they can't if they didn't have a lockfile from before 0.9.4 got yanked and there is no regalloc2 version semver compatible with the 0.9.4 dependency requirement. If a non-yanked 0.9.5 existed, this one would be picked, but alas it doesn't exist and thus cargo will return an error.

Ah that's a good point, if that's causing issues for you I can approve/merge a revert too

Should we upload a 0.9.5 that's just a re-release of 0.9.3?

Let's just revert the update and restore the changes when we release regalloc2 0.10.0 with safepoint support removed next week.


Add support for ECDSA and ED25519 keys

Description
Adds suport for ed25519 and ecdsa elliptic curve host keys as they are safer and shorter.
Development tasks

Create a default serverspec suite
Fix apt cookbook include for Debian-based systems
Get ed25519 and ecdsa host keys before RSA and DSA keys

Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] The CLA has been signed. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

This change is

@tas50 Let me know if anything can be fixed or improved

HI @josacar, This looks pretty solid. The one thing is that it's still using the partial_search functionality from the partial_search cookbook. I'm going to go ahead and accept this, but if you have time and are willing could you investigate eliminating that dependency in a future PR? Thanks so much for your contribution.


feature: omit empty deleted attribute in hooks

Hi!
As a developer,
I want to have the possibility to receive documents that have no "deleted" attribute by default as not deleted documents.
Why do I need this feature?
When I install the package first time, I don’t want to write additional migration to add deleted attribute to each entry in db.
Thank you.

Thank you for you contribution. Unfortunately I will not be merging this pull request since this will have a negative impact on performance. If you have a good motivation for when using $ne is better, I might be open if you change your code to add this as a setting that can be activated in these cases. But generally you would be better of just migrating your data to add deleted: false to your documents. If you don't want deleted:false in your response you can add for a "private" plugin that removes the deleted property from your toJSON response (for example https://github.com/vs-archive/mongoose-private)
Mongodb explains it here (https://www.mongodb.com/docs/manual/reference/operator/query/ne/)

The inequality operator $ne is not very selective since it often matches a large portion of the index. As a result, in many cases, a $ne query with an index may perform no better than a $ne query that must scan all documents in a collection. See also Query Selectivity.


clone(...) returns str not Voice

I've never done a PR before, I don't even know if it's allowed. Here's the code I had:
    voice = clone(
        name=name,
        files=[str(sample_path)]
    )
    voice.settings.similarity_boost = order.similarity
    voice.settings.stability = order.stability

But that raises an exception AttributeError: 'str' object has no attribute 'settings'
So the solution I found was:
    voice_id = clone(
        name=name,
        files=[str(sample_path)]
    )
    voice = Voice.from_id(voice_id=voice_id)
    voice.settings.similarity_boost = order.similarity
    voice.settings.stability = order.stability

While I got it working for myself, I looked into the implementation, and the code is misleading:
From Voice.py:
class Voice(API):
    ...

    @classmethod
    def from_clone(cls, voice_clone: VoiceClone) -> Voice:
        url = f"{api_base_url_v1}/voices/add"
        data = voice_clone.dict()
        data["lables"] = str(data.pop("labels"))
        del data["files"]
        files = data.pop("_files_tuple")
        try:
            voice_id = API.post(url, data=data, files=files).json()["voice_id"]
        except APIError as e:
            if e.http_error.status == "can_not_use_instant_voice_cloning":
                raise UnauthorizedVoiceCloningError(e.http_error)
            raise
        return voice_id

    ...

We can see that from_clone(...) -> Voice should return a Voice object, but instead it returns voice_id which is the voice id returned by the http request, a string. Perhaps return Voice.from_id(voice_id) would avoid the problem?

Hi! You are right, clone should return a Voice object. This has been fixed in v0.2.16


W4.5c[Tutorial 11-Group1] Shearer Tan

LO-Exceptions

Hello, you've made a pull request to the wrong repository, please close this pull request and submit a new one to nus-cs2103-AY1718S2/addressbook-level2 repository.


add new line before the first boundary

Thanks!

:+1:
Sorry for no descriptions. Previous commit will occur error when we have attachment because there is not new line before boundary.


Does spin-up include module outputs?

I have modules that depend on outputs from other modules.
As an example, I have a  module for provisioning etcd nodes that will need the subnet ids from my vpc module.
Can I do something like  subnets = ${module.vpc.subnet_ids} in my etcd module instantiation?

I didn't think this one through, I should ofcourse use the remote state from the vpc.


Update docker.io/renovate/renovate Docker tag to v24.30.0

This PR contains the following updates:

Package
Update
Change

docker.io/renovate/renovate
minor
24.29.4 -> 24.30.0

Release Notes

renovatebot/renovate
v24.30.0
Features

config: Rename packageRules selectors (#6939) (72b0b85)

Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Gladly :)

Gladly :)


NaT.isoformat() returns 'NaT'.

NaT.isoformat() returning 'NaT' allows users to use Timestamp to
rehydrate any _Timestamp object from its isoformat. This means that it
is safe to use _Timestamp.isoformat() as a serialization format for
timestamps where NaT is a valid value.

I am not sure if this is actually a good change. NaT is not defined by iso so idk if this is misleading. I just wanted to raise the issue.

this would change the way JSON serializes I think. IIRC its the only thing that uses .isoformat internally at least.

@llllllllll this looks fine. pls rebase and well put in.

build is passing, thanks!

thanks @llllllllll


Old branch name appearing in Mauro

I created a branch called CR8000 - National Eye Colour Data Set Version 11 so I could rename it to CR8000 - National Eye Colour Data Set Version 1.
When I am editing an item both 1 and 11 are displayed. It is over a week since I created and renamed the branch.
Why is this happening and when will it update to 1?
Why does it show version 11 on the right hand frame when I access an item?

We have been investigating the issue of changing the branch name under a dictionary branch, and the complexity of the problem is extremely large. System C do not have the capabilities at the moment to develop such a wide ranging change, this will need to be a problem to discuss with the Mauro team and @jamesrwelch.

30/07/24 - James will fix this if Peter can't fix it as it is a more general Mauro issue.

James will investigate to see if it can be resolved for migration as it is a more general issue.
James thinks there is an easy workaround for this.


Including Files and Using Constants

Hi I am developing an API application and i am having issues including file in Flight.
I wrote
require '/flight/Flight.php';
define('APPKEY', '7823873268723671256126,);

And in my index
require __DIR__.'/appCore/API/Constants.php';

Flight::route('GET /', function(){
    echo APPKEY;
});

And all i have been getting is error,
I'm i calling the file wrongly or what am i doing wrong
There is no doc on multiple files structure
Thanks

@acefxlabs in order to use flight, you need to call Flight::start(); after registering your routes.

You have to post what the error is. We can't help you without the error message.

Thanks alot, Resolved


Update index.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM

I closed/re-opened in an attempt to clear Travis cli error.
LGTM

Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Not able to install

Hey,
I'm on OSX, installed libgroove manually by running:
git clone https://github.com/superjoe30/libgroove
mkdir build && cd build
cmake .. -DDISABLE_PLAYER=true -DDISABLE_LOUDNESS=true
make -j4 && sudo make install

which passed and installed it to:
Install the project...
-- Install configuration: "Debug"
-- Up-to-date: /usr/local/lib/libgroove.5.0.0.dylib
-- Up-to-date: /usr/local/lib/libgroove.5.dylib
-- Up-to-date: /usr/local/lib/libgroove.dylib
-- Installing: /usr/local/lib/libgroove.a
-- Up-to-date: /usr/local/include/groove/encoder.h
-- Up-to-date: /usr/local/include/groove/fingerprinter.h
-- Up-to-date: /usr/local/include/groove/groove.h
-- Up-to-date: /usr/local/include/groove/loudness.h
-- Up-to-date: /usr/local/include/groove/player.h
-- Up-to-date: /usr/local/include/groove/waveform.h

Now running npm install groove still fails with:
npm install groove

><EMAIL_ADDRESS>install /Users/sulf/Development/libgroove/build/node_modules/groove
> node-gyp rebuild

  CXX(target) Release/obj.target/groove/src/groove.o
In file included from ../src/groove.cc:4:
../src/file.h:6:10: fatal error: 'groove/groove.h' file not found
#include <groove/groove.h>
         ^
1 error generated.

Any hints?

Same error for me, i use node-groove v2.5.01 and libgroove v5.0....

Have the same problems..

Running xcode-select --install fixed this error for me. But then installation fails with ../src/player.h:6:10: fatal error: 'grooveplayer/player.h' file not found


convert all outgoing channels/voips.ms subaccounts to foo and bar

We register with a voip.ms subaccount for each extension. Each extension has its own outgoing channel, which is that subaccount. Why do we do that? We should just have two voip.ms subaccounts, foo and bar, an installation registers with the appropriate one, each voip.ms sends incoming to that one, switch when we promote stage.
Then add a subaccount for each devbox so they don't register a 2nd time and steal incoming calls. Alternately, set up a different voip.ms account for dev. Don't change callcentric, keep that the same until we phase it out.
Do we lose anything important with that? Current devbox doesn't register with the production subaccounts, just registers with the demo or test subaccount, so incoming calls don't go to devbox, only demo extensions work for outgoing/incoming.

voip.ms support is recommending we do this to prevent the outgoing congestion.
This would not impact 911 calls, that works with the callerID.
We could make devbox work by adding a dev type. Or an entirely separate dev voip.ms account.
To implement:
Create prod-foo, prod-bar, dev-oscule, dev-tishbite subaccounts.
Update sip_callcentric.conf.foo|bar to register with prod-foo|bar (keeping existing registration)
Remove sip_callcentric.conf.virtualbox and replace with sip_callcentric.conf.tishbite|oscule
Update sip_callcentric.conf.oscule|tishbite to register with dev-oscule|tishbite and no other voip.ms subaccounts. Keep any existing callcentric dev for now (although something is broken with that, we're getting callcentric-tishbite metrics on prod, maybe #52?)
Test by firing up dev VM and connecting with an extension that should work
Create a new voipms-extension stanza in sip.conf
Update all sip_callcentric.conf to add creds to voipms-extension
Update 668 and 669 to both use voipms-extension
Test by firing up dev VM and connecting to working dev extension and to 668 and 669
Branch, deploy, test.
Continue with all other voip.ms extensions
Add a dev-name and sip_callcentric.conf.name when we add a dev that wants to use a dev VM
Add a dev-devdeployed and sip_callcentric.conf.devdeployed when we deploy a dev box.


Added basic support for splat (...) operator in PHP 5.6

I haven't yet tested references or type-hints in combination with the splat operator.

Relevant part of the RFC for references - https://wiki.php.net/rfc/variadics#by-reference_capture

Related HHVM regression: facebook/hhvm#5762.

Manually rebased and merged, closing this PR.


[add-resource] New Skeleton: Oxygen

Please add my new skeleton "Oxygen" to the Grav repository.
Project details: kittyfishfrommars/grav-skeleton-oxygen
Changelog: CHANGELOG.md

skeleton added to GPM for next release


Setup CI for this repo

CI should at least check that the examples build with the latest e-g versions. It would also be nice to check the actual output of the examples like e-t does: https://github.com/embedded-graphics/embedded-text/blob/master/.github/workflows/rust.yml

I'm going to close this as done, as we've been building against a few versions now.
Comparisons are tricky, as the analog clock example generates a different image every time it's run due to displaying the current system time. I think it's ok to manually check the screenshots are up to date from time to time.

I'm going to close this as done, as we've been building against a few versions now.

But this issue was specifically for testing the eg-next branch.

Comparisons are tricky, as the analog clock example generates a different image every time it's run due to displaying the current system time. I think it's ok to manually check the screenshots are up to date from time to time.

Sure, for the clock examples this is difficult, but all other examples should produce the same output every time.
We don't need to set this up right now, but I still think this is a good idea for the future.

@jamwaffles Would you mind if we reopen this issue for later?

Sure, sorry for being overzealous with my closures!


Ignore hidden files for datadriven tests

Hidden files have a leading . and are picked up by the datadriven test framework. This should handle many cases of picking up unwanted files. fix #913

+1

+1  modulo optional quibble above.

Improved readability and merged.


AIX crashes 8u282 but not 8u265

Summary
We have seen many crashes in a number of locations. We first thought it was JIT related so we disabled  JIT and we see the same crashes, This is definitely a regression from 8u265 that is present in 8u282.
stacks.txt
javacore.20210302.071234.25625076.0002.txt
Steps to reproduce
Here is where the problem is.  There are no steps that you can duplicate we found it during automated testing and can reproduce with a subset of the test. The people who sign my pay check require I write this report sending a javacore and stacks. We have many stacks that indicate the same thing,

Expected results
Test runs correctly
Actual results
Crashes is many places
Triaging info

Java version:
This is the release that is causing issues
[root@pautoaixnext:/opt/ibm/domino/notes/latest/ibmpow/jvm/bin]#./java -version
openjdk version "1.8.0_282"
OpenJDK Runtime Environment (build 1.8.0_282-b08)
Eclipse OpenJ9 VM (build openj9-0.24.0, JRE 1.8.0 AIX ppc64-64-Bit Compressed References 20210120_953 (JIT enabled, AOT enabled)
OpenJ9   - 345e1b09e
OMR      - 741e94ea8
JCL      - ab07c6a8fd based on jdk8u282-b08)
This release works fine
[root@pautoaixnext:/opt/ibm/domino/notes/latest/ibmpow/jvm/bin]#cd ../../jvmback/bin
[root@pautoaixnext:/opt/ibm/domino/notes/latest/ibmpow/jvmback/bin]#./java -version
openjdk version "1.8.0_265"
OpenJDK Runtime Environment (build 1.8.0_265-b01)
Eclipse OpenJ9 VM (build openj9-0.21.0, JRE 1.8.0 AIX ppc64-64-Bit Compressed References 20200728_769 (JIT enabled, AOT enabled)
OpenJ9   - 34cf4c075
OMR      - 113e54219
JCL      - c82ff0c20f based on jdk8u265-b01)
What is your operating system and platform?
OS Level         : AIX 7.2
2XHCPUS        Processors -
3XHCPUARCH       Architecture   : ppc64
3XHNUMCPUS       How Many       : 8
3XHNUMASUP       NUMA is either not supported or has been disabled by user
How did you install Java?
We install the entire JRE within a JVM directory in our product.

Did it work before?
Works with 8u265 and fails with 8u272.  We can take 8u272 and place it in a previous version of our product and it will fail the same way

The Java version
Did you test with other Java versions?
Yes see above

@ed03875

you mention both 8u282 and 8u272, pls confirm 8u272 is the first build that shows the problem.
is it possible to get us a test case that reproduces the problem?
if not, can we get a system core file of the crash? We can't do anything from what has been provided. You can compress the system core and put it on a file sharing service. Email me directly if you don't want it public.
there are some things you can try to help narrow down what component is causing the problem

run the test case with -Xshareclasses:none to see if the problem still reproduces
run the test case with -Xint. This disables the JIT so it will run much slower, it's not necessarily feasible to do this depending on how complicated the test case is, as the run time may be too long.

@tajila @zl-wang fyi

These crashes occur with 8u282 but not with 8u272.  If we move the JRE from version to version of Domino the crash moves with the JRE
As I explained we can not supply a test case as that would require a Domino setup and automation very large
I have sent a javacore and stacks I will send a system core I believe we have one
We have already disabled JIT as explained in my summary there was no change
We have since found the same problem with Linux it does not happen with Windows
This is clearly a regression as we test this for every release.

So have you tested 8u272 or 8u275, can you confirm it doesn't crash which this version? If you haven't tried this version pls try it. It helps to narrow down the list of changes from the working to non-working build.

My mistake we have not tested with 27? only 282 and 265.

Have you looked at the stacks I supplied there are many different crashes but they all show this
fatal_error@AF35_19
Along with some other seemingly similar stacks

It looks like memory has been corrupted, so the stacks show places that crashed due to the corruption but don't help track what caused the corruption. The system core file allows looking at the corrupted data, which may or may not help to track down the problem.
The javacore file indicates there was a trace assert. There should be some information in the console output for the tracepoint which asserted. You could provide that if it's available, although again I don't expect it will help track the cause of the problem.

Do you have a site we can put this core file on ? I do not believe we have
a public site that can be used for that purpose.
From:   Peter Shipton @.>
To:     AdoptOpenJDK/openjdk-support @.>
Cc:     ed03875 @.>, Mention @.>
Date:   03/12/2021 10:02 AM
Subject:        Re: [AdoptOpenJDK/openjdk-support] AIX crashes 8u282 but
not 8u265  (#279)
It looks like memory has been corrupted, so the stacks show places that
crashed due to the corruption but don't help track what caused the
corruption. The system core file allows looking at the corrupted data,
which may or may not help to track down the problem.
The javacore file indicates there was a trace assert. There should be some
information in the console output for the tracepoint which asserted. You
could provide that if it's available, although again I don't expect it
will help track the cause of the problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

There are some sites listed here https://www.gflesch.com/elevity-it-blog/best-file-sharing-software-platforms
If you have a Linux core file we may prefer to look at that one.

You could also join the OpenJ9 Slack and drag and drop the compressed file to me. See "Join OpenJ9 slack" on https://www.eclipse.org/openj9/ for the invitation.

See also option 4 in https://blog.hubspot.com/marketing/send-large-files

We have tested with 8u272 and it also shows the same problem so no need to test with 275.

We can not use public sites with HCL data do you have a dropbox we can send this file to ?

No sorry. Maybe you can send it via IBM support, do you have contacts there?

I have tried a number of things but due to restrictions currently in place zip split is the only workable option
core1.zip
core2.zip
core3.zip
core4.zip
core5.zip
I will be working on a better way but for now and before I start hearing from management that I only read about in the newspapers I need to get this to you.  I hope it helps

Dmitri is looking at the core. While that occurs, we have a milestone 1 build for the next release. If you want to try it, maybe the problem has already been resolved.
https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u292-b05_openj9-0.26.0-m1

We will thank you

So I pulled down OpenJDK8U-debugimage_ppc64_aix_openj9_8u292b05_openj9-0.26.0-m1.tar.gz
And here is where I get lost.  The bin directory contains what one would expect but there is no JVM directory so I looked into the lib directory and I find the directories I would expect to see in jre bin but without the contents I expect. I see
libjsig.debuginfo  libjvm.debuginfo.   I was looking for .so files what I see is .debuginfo files.  I had hoped for a useable jre in the debug but what I have I do not understand. Please explain

The debugimage files are overlays for the JDK or JRE, and add debug symbols to help diagnose problems. It's a separate download to keep the JDK and JRE smaller.

Thanks for the help
One thing that came up in discussion here.  Is there anything that has been done to the JVM that would drastically change its positioning in our address space when loaded ?  We can't help but question if this problem that looks like memory being overwritten is something that we are doing and we just have not seen it before but a change to the JVM brings it to light.

Hard to say, there are many changes
https://github.com/eclipse/openj9/releases/tag/openj9-0.22.0
https://github.com/eclipse/openj9/releases/tag/openj9-0.23.0

8u292 failed in a similar way
###################################
thread 163/166 :: server pid=21955018, k-id=79233423 , pthr-id=41379
stack          :: k-state=wait, stk max-size=264328, cur-size=13640
###################################
raise.nsleep(??, ??) at 0x90000000003f4c4
sleep@AF4_1(??) at 0x90000000017d04c
OSRunExternalScript(0x12bba6060, 0x100000001) at 0x9000000088e3510
OSFaultCleanupExt(0x0, 0x100000001000, 0x0, 0x0, 0x0, 0x0) at 0x9000000088e2bb8
fatal_error@AF35_19(0xb0000000b, 0x12bba66d0, 0x12bba6420) at 0x9000000089dc3c4
nextSlot__33GC_ConstantPoolObjectSlotIteratorFv@AF2_1(??, ??) at 0x90000001452ba44
nextSlot__16GC_ClassIteratorFv(??) at 0x90000001452b6d8
scavengeIndirectObjectSlots__20MM_ScavengerDelegateFP22MM_EnvironmentStandardP8J9Object(??, ??, ??) at 0x9000000145bc324
scavengeRememberedSetList__12MM_ScavengerFP22MM_EnvironmentStandard(??, ??) at 0x9000000145a6228
workThreadGarbageCollect__12MM_ScavengerFP22MM_EnvironmentStandard(??, ??) at 0x90000001459fbc0
run__23MM_ParallelScavengeTaskFP18MM_EnvironmentBase(??, ??) at 0x9000000145d2a90
workerEntryPoint__21MM_ParallelDispatcherFP18MM_EnvironmentBase(??, ??) at 0x9000000146233ac
dispatcher_thread_proc2__FP14OMRPortLibraryPv(??, ??) at 0x9000000146224fc
omrsig_protect(??, ??, ??, ??, ??, ??, ??) at 0x900000012e8be48
dispatcher_thread_proc(??) at 0x90000001462312c
thread_wrapper(??) at 0x900000012ef975c

No core file generated

Is there a way for me to get at the nightly or milestone builds for earlier releases  so we can help narrow this down ? We know the problem exists in 272 so a build between 262 and 272 might help.  Is there a way to get at m1 or m2 for 272 ?  I have looked but I don't seem to be able to get one.  I must be missing something

The milestone builds are as follows.
https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u272-b08_openj9-0.23.0-m1
https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/tag/jdk8u272-b09_openj9-0.23.0-m2
You can find nightly builds here https://adoptopenjdk.net/nightly.html?variant=openjdk8&jvmVariant=openj9
Look for builds prior to 2020-09-24. This date should be quite close to the branch for 0.23.0 (m1). You can go back to 2020-06-05 which is about when the 0.21.0 release (u262/u265) was branched.

@ed03875 We need more cores to look.
In the core provided in https://github.com/AdoptOpenJDK/openjdk-support/issues/279#issuecomment-797702623 memory has been corrupted (zeroed). Most possible case that previous memory allocation has been written out-of bound. In this core previous allocation belong to JIT Data Cache (see https://github.com/eclipse/openj9/issues/12207#issuecomment-799697007)
If we look to different core(s) and see the same pattern (previous allocation JIT Data Cache) it will help obviously

We tested 8u272 milestone one and it crashed.  I am working on getting you another core file for analysis.  We have 32 crashes and only 4 core files which is unfortunate

We have a core where JIT is turned off

Any core will help in this situation. Crash points are meaningless due random corruption of memory (just victims), so we need to find pattern.
Cores for Linux are preferable, you AIX is not configured to include Read Only segment to the core, so all strings (names) are unavailable.

I will see if we can crash and get a core from linux right now all we have is AIX
core1.zip
core2.zip
core3.zip
core4.zip
core5.zip
We are going to send you the cores we have in the hope something shows a pattern

Here is another one
core1.zip
core2.zip
core3.zip
core4.zip
core5.zip
core6.zip
core7.zip

We have a core where JIT is turned off

This one would be useful, as the problem cannot be related to "JIT Data Cache" since it occurs with JIT disabled.

Here is another one from AIX trying to get you a Linux core
core1.zip
core2.zip
core3.zip
core4.zip
core5.zip
core6.zip

The core from March 11 has JIT turned off

That would be the last one I sent you

@ed03875 Are you aware about https://www.ibm.com/support/pages/apar/IJ30808? This is specific for AIX 7.2.5 and this is AIX malloc() problem. I can see from the core you are using AIX 7.2, is it a chance this is 7.2.5?

Thank you I was not aware of the issue but we are looking into it now.  Unfortunately we experience the same crash with Linux is there a problem there also ?

I guess may be on Linux there is another problem. Would you please send me core for Linux as soon as you got one?

Also using https://www.eclipse.org/openj9/docs/tool_jextract/ might help to collect required libraries for debugging. For example in the cores sent to us two of them have crashes in custom or system libraries (for example /opt/ibm/domino/notes/latest/ibmpow/libnotes_r.a)

We are trying to get you a Linux core without success so far but people are actively working on it

Responding to the AIX version question. The test system we are using is at 7.2 TL 1 so it's not that high of level

I looked to four cores so far, all for AIX. All of them have assertions/crashes at random places (typical for memory corruption). Another common symptom is number of problems with classes (discovered by GC Check). Most common is ramStatics is NULL but romClass->objectStaticCount is one (can it be explained by memory corruption)?
This is summary:

https://github.com/AdoptOpenJDK/openjdk-support/issues/279#issuecomment-797702623
There is assertion in Port library at free memory (bad j9memtag). Looks like area of memory has been zeroed. Previous allocation (with zeroed closing tag) is 2m JIT Data Cache

https://github.com/AdoptOpenJDK/openjdk-support/issues/279#issuecomment-799735838
Assertion in BytecodeInterpreter.hpp:7979: ((0 )). I guess this another victim of random memory corruption.

https://github.com/AdoptOpenJDK/openjdk-support/issues/279#issuecomment-799744793
Segmentation error in /opt/ibm/domino/notes/latest/ibmpow/libnotes_r.a
There is not much I can do without custom library

https://github.com/AdoptOpenJDK/openjdk-support/issues/279#issuecomment-799750503
This core does not have JIT running
Segmentation error at (?):

c-stack:
malloc_y(0x1190540f0, 0x0, 0x9001000a007d620, 0x0, 0x0, 0x4af0103, 0x0, 0xb7a9010c9f92080) at 0x90000000004b214 [untrusted: /usr/lib/libc_r.a(shr_64.o)]
malloc_common@AF104_87(??) at 0x90000000002e668 [untrusted: /usr/lib/libc_r.a(shr_64.o)]
_cleanup_push@AF79_34(??, ??, ??, ??) at 0x9000000005a3dd8
localtime64_tz_r(??, ??, ??) at 0x90000000009d048 [untrusted: /usr/lib/libc_r.a(shr_64.o)]

0x90000000004b214 (malloc_y+0xdf4) f8640000            std   r3,0x0(r4)

@tajila FYI

More information for you daily builds August 12th and July 29 also crash
core from July 29 daily build
core.server.12255738.zip

Unfortunately I can not open this core ("No JRE"). I guess this file is truncated, corrupted or has source other than JVM

That is unfortunate but explains why it was so small
Will try for another

A little late, but if it helps I've figured out you can add files here
https://ibm.ent.box.com/f/15280665b3554efca921efb919634cd6
and Dmitri or others can access them via https://ibm.box.com/s/5tfl1f5sspwaep4qef3gdlaz73ej5d9e

Well it has been a long several days but the good news is we finally found the problem and it is in our code. Looks like C++ objects were being instantiated by C in two places that we were unaware of.  Thank you very much for your help.  We are sorry we took your time on this one but initially we were crashing and every crash had the JVM in the stack and the stack was a mess.

You are welcome. Thank you for using OpenJ9


Fill in descriptions/tutorials for various best practices

I started jupyter notebooks for most of the things we listed on the whiteboard.  They're just placeholders at the moment, but I think that'll be a good way of describing things.

I did that for a lab meeting presentation once; those notebooks are at https://github.com/tbekolay/jneurosci2013-bts Could be a starting point for some of these.


Ability to import jest functions from module (helpful for intellisense)

🚀 Feature Proposal
import jest from 'jest'; doesn't contain any jest test functions. Why???
It's not so difficult to implement jest.d.ts
Motivation
I need to look for every function in jest documentation for using it. It's difficult and annoying
import and IntelliSense in this case will be helpful

Which version of Jest are you using, that seems to be working fine for me in a .ts file.

All right. You import jest-compiler. But there are no-jest globals like
jest.fn()
expect

You can install @types/jest, and you will get  jest IntelliSense work.

Yeep. It's a little bit confusing because node_modules/jest/index.d.ts exists, as<EMAIL_ADDRESS>is completely different and contains jest-globals.
Anyway. The issue is resolved. Thank you for your attention.

Awesome, glad it works now

I got this issue when typescript compiler use broken node_modules/jest/build/jest.d.ts instead of<EMAIL_ADDRESS>on import 'jest';
	"devDependencies": {
		"@testing-library/vue": "^6.4.0",
		"@types/jest": "^26.0.22",
		"@vue/compiler-sfc": "^3.0.11",
		"html-loader": "^2.1.2",
		"html-webpack-plugin": "^5.3.1",
		"jest": "^26.6.3",
		"ts-jest": "^26.5.4",
		"ts-loader": "^8.1.0",
		"typescript": "^4.2.4",
		"vue-loader": "^16.2.0",
		"vue-jest": "^5.0.0-alpha.8",
		"webpack": "^5.31.2",
		"webpack-cli": "^4.6.0"
	},

It worked with jest 24.* because jest.d.ts reexported all from jest-cli and node_modules/jest-cli/build/index.d.ts contained all required functions.

Managed to fix it with
import { describe, expect, test } from '@jest/globals';

That's what the docs says to use
https://jestjs.io/docs/api


fix for gitlab-ce images using postgresql on Bluemix

With the change to docker hub gitlab-ce images, the credentials for the PostgreSQL db on Bluemix need to be managed directly into the deployment file as deployment that requires parsing kubernetes secrets won't work without a custom entrypoint.sh.
Update README and gitlab-postgres-svc.yaml file.

Thanks @timroster
@paulczar since it fixes the PR you submitted - please have a look
@Tomcli also check once

LGTM. I think it could be more clarify if we can add some comments above the values that we want to replace in the yaml file.

@timroster can @Tomcli suggestion be a quick fix for you?

@animeshsingh put something in above each field. @Tomcli lmk if better.

Yeah it looks great to me.


Add-In button missing in OneNote Web

The page says to add a OneNote Add-In via a button on the Insert tab, the button is missing on the web and desktop versions.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a6ed3136-1d12-66c2-a8b1-1e7e43553aae
Version Independent ID: 0e40308a-2d3d-a27b-04d5-1bdd7c09b501
Content: Build your first OneNote task pane add-in - Office Add-ins
Content Source: docs/quickstarts/onenote-quickstart.md
Product: onenote
Technology: add-ins
GitHub Login: @o365devx
Microsoft Alias: o365devx

Hi @Bingomzan,
I'm sorry to hear you're having difficulties with the quick start. To be clear, Office Add-ins are only supported on OneNote for the web.  Could you please share what you're seeing in your Insert tab on the ribbon? Here's what mine looks like.

Additionally, are you able to find the Office Add-ins button in the classic ribbon or by using TellMe?

This is what my ribbon looks like. I am on a GCC tenant if that makes a difference.

Thanks @Bingomzan. I'm following up internally about the GCC support for sideloading.

Hi @Bingomzan,
It's possible your admin has disabled add-ins or sideloading in some way. Could you please confirm with them if that's the case?


Project list view

Created test case for rendering project list, couple of TODO for error handling, Will need to test completely with "gather list items" story.

LGTM