Configuration option to preserve blank lines at start of block

Adds the option for

Functions
Control flow blocks
Expression statements (i.e. let x = { ... };)
Traits
Trait Impls
Mods
Foreign Mods

If I am missing a kind of item, let me know :)
Closes #2868

(don't let the 900 line diff scare you; ~800 of it is tests)

(don't let the 900 line diff scare you; ~800 of it is tests)

That made me chuckle, as my eyes did pop at first before I saw that note :eyes:

I know the original issue only referenced start of blocks, but I have a suspicion that a decent size chunk of users that would leverage this config option may also be interested in something similar for the end of blocks.
Do you think an equivalent end-of-block config and behavior would be feasible, and if so would it make sense for those to be two distinct config options or easier to use as one? Based on the explanation in the linked issue it sounds like there's scenarios where folks may want to keep the lines at the beginning but still trim at the end so separate would probably be best for more granular control.

That makes sense to me, if people want one they may want the other. I definitely think it's feasible (and probably easily doable, but those are famous last words). However I also think it's worth waiting and seeing if there are any requests for such a configuration option, as it's easier to add an option than remove one (from a stability and "how many people are using this?" point of view). What do you think?

This is totally orthogonal, but it would be interesting to pull GitHub data and see what are the most common rustfmt options are too.

However I also think it's worth waiting and seeing if there are any requests for such a configuration option, as it's easier to add an option than remove one (from a stability and "how many people are using this?" point of view). What do you think?

Agreed, and certainly no need to do anything with end of block lines as part of this PR, I'm betting it'll get requested sooner or later though.

but it would be interesting to pull GitHub data and see what are the most common rustfmt options are too.

Definitely! Funny you should mention this, as just the other day I was thinking about how beneficial it would be to have quantitative data about config option usage. There's some that we know are used pretty extensively in their respective corners (indent_style, hard_tabs, use_small_heuristics, etc.) but there's plenty of others where we don't really know.

Thanks for the updates! I'll try to get back to this soon, though have also requested a review from @topecongiro for the reasons mentioned earlier in the thread.
One of the things that I can't quite shake is a feeling that there's a little too much going on with advance_to_first_block_item and/or some of the internal logic is leaking out a bit that has to be conditionally interpreted by consumers of the function.
For example, I can see 3 different branches internal to the function that can all result in function returning the exact same thing, an empty string, and the length of the returned string (or more precisely whether or not it's empty) is significant for at least some consumers.
I don't have any specific suggestions/modifications just yet (although maybe wrapping the return string in an Option could help?) and I wouldn't say this is a blocking concern for me; just wanted to share my thinking. Properly (and idempotently) maintaining line spacing is certainly a nontrivial task and you've done a great job here!

a little too much going on with advance_to_first_block_item

I tried to condense the logic a bit, lmk what you think

https://github.com/rust-lang/rustfmt/pull/4295/files broke this, so there is probably a better way to handle this using the code there...

Thanks for the changes @ayazhafiz! I know it was fairly minor but I definitely appreciate the updated  advance_to_first_block_item :+1:


Lint YAML files

It seems that YAML files are not being linted and auto-fixed by pre-commit. This functionality should be added.

pre-commit should lint and auto-format YAML files
Lint check should also check PRs for the same rule

For example, consider this one-off 4-space indentation in a file that is otherwise indented by 2 spaces.
https://github.com/WordPress/openverse-api/blob/e2c490ad9d0f6ca47e5e2f4fd06205b7eac13c45/docker-compose.yml#L60

I am....so sorry for that :sweat_smile: I need to figure out how to set per-file indentation on PyCharm :woman_facepalming:
Either way, love the idea of linting these!

It's perfectly understandable to miss a couple of spaces, especially in YAML with all the hyphen-indents and what-not. Which makes linting them all the more necessary 👍.


Alert content output for spike rules

I'm asking if the alert content for spike rules is limited. (alert is working well, the issue is only on the content output)
Using alert_subject/text_args, I can only get one field in the alert output : "source"
Here is the yaml :

name: "spiketest"
index: graylog_*
filter:

query:
query_string:
query: 'event_ip: <IP_ADDRESS>'

type: spike
spike_height: 3
spike_type: up
query_key: source
use_terms_query: true
doc_type:  message
timeframe:
minutes: 3
alert_subject_args: ["event_ip"]
alert_subject: "Spike_for_{0}"

alert_text_args: ["event_ip", "event_src", "source"]
alert_text: |
IP: {0}
Event source: {1}
Source: {2}
alert_text_type: alert_text_only

Here is the output :

Spike_for_MISSING VALUE
IP: MISSING VALUE. Event source: MISSING VALUE Source: client_test

Here is json from a document  :

{
"_index" : "graylog_41",
"_type" : "message",
"_id" : "668a5190-3ad7-11e7-8a84-0242ac120006",
"_version" : 1,
"found" : true,
"_source" : {
"event_facility" : "9",
"level" : 6,
"streams" : [ "000000000000000000000001" ],
"event_severity" : "6",
"source" : "client_test",
"message" : "(CRON) info (No MTA installed, discarding output)",
"type" : "syslog",
"gl2_source_input" : "58e6013eb9d8210001e5600a",
"@timestamp" : "2017-05-17T08:04:06.987Z",
"full_message" : "(CRON) info (No MTA installed, discarding output)",
"event_prog" : "CRON",
"gl2_source_node" : "363a611c-edc8-4f56-9d7e-0d35633ef004",
"event_src" : "client_test",
"facility" : "gelf-rb",
"event_time" : "2017-05-17T10:04:06+02:00",
"timestamp" : "2017-05-17 08:04:06.987",
"event_ip" : "<IP_ADDRESS>"
}

We can see that fields requested in alert output (event_ip and event_source) exists so that's why I'm asking if output fields for spike are limited
When using no argument for alert content, I have this output :

IP:  MISSING VALUE . Event source:  MISSING VALUE  Source: client_test
An abnormal number (82) of events occurred around 2017-05-17 16:47 CEST. Preceding that time, there were only 19 events within 0:03:00
@timestamp: 2017-05-17T14:47:21.307403Z reference_count: 19 source: client_test spike_count: 82

Thanks for your support ! :-)

Does somebody could give a feedback on the output for this type of rule (spike) ?
Thx ! :-)

When you add use_terms_query: true, Elastalert only get's numbers back from Elasticsearch, not full fields. If you remove that, you'll get the full document that triggered the alert.
You don't have to remove that though. you can also add top_count_keys. See http://elastalert.readthedocs.io/en/latest/ruletypes.html?highlight=top_count_keys#top-count-keys

Works perfectly now. Thank you @Qmando !


Starting node prints Bitcoin server starting

Starting node prints Bitcoin server starting to the console. It should print Radiant server starting.

Fixed in https://github.com/RadiantBlockchain/radiant-node/pull/7


DBeaver CE from Microsoft Store Broken After Update

Description

Error message: A Java Runtime Environment (JRE) or Java Development Kit (JDK) must be available in order to run DBeaver.  No Java virtual machine was found after searching the following locations. <filepath\javew.exe> javaw.exe in your current PATH
DBeaver Version
Community Edition, cant tell version because of error.
Operating System
Windows 11
Database and driver
N/A
Steps to reproduce
Launch DBeaver in windows.
Additional context
No response

Thanks for the bug report. This is a known issue in the latest release.
As a workaround, you can either download DBeaver from https://dbeaver.io/files or install JRE 11 or greater.
Closing as a duplicate of #18960


[folding] Collapse button is too close to text when selecting

When I am selecting text that starts near a collapse button I way to often hit the collapse button instead.  This may be most prominent on my laptop where the precision of my mouse pad is not as high as a gamers mouse.
Instead of adding more space, would it be possible to change the event handler of the collapse to mouse up and check to make sure it is still over the button?  For example, if the user accidentally clicks on the button but continues to drag the mouse to select text, the collapse action will not happen.

I'm not able to reproduce this. The fold action reacts to mouse up and checks that the mouse down happened on the same line. See https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/folding/folding.ts#L407


Azure build agents fail to download docker build image (unauthorized)

Thank you for reporting a broken build! Please fill in the following details:

Jenkins link to the failing log:
Which platforms (OS+arch) are affected: All xLinux on tonight's JDK8 builds
If you look at the historic logs, does the problem appear to be specific to one machine? No - my local machine can pull the image without problems
Link to any upstream project bug report (e.g. OpenJ9/JBS) n/a

Log: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-x64-hotspot/901/console
18:10:28  + docker pull adoptopenjdk/centos6_build_image
18:10:28  Using default tag: latest
18:10:30  Error response from daemon: unauthorized: authentication required

Slightly different on the OpenJ9 ones: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-x64-openj9-linuxXL/lastFailedBuild/console
18:10:41  + docker build -t build-image --build-arg image=adoptopenjdk/centos6_build_image -f pipelines/build/dockerFiles/cuda.dockerfile .
18:10:41  Sending build context to Docker daemon  17.66MB

18:10:41  Step 1/6 : ARG image
18:10:41  Step 2/6 : FROM $image
18:10:44  latest: Pulling from adoptopenjdk/centos6_build_image
18:10:44  831490506c47: Pulling fs layer
18:10:44  c388bbfe10ff: Pulling fs layer
18:10:44  3f7414369ae3: Pulling fs layer
18:10:44  6d0337ea7090: Pulling fs layer
18:10:44  cacbb7d741ce: Pulling fs layer
18:10:44  1cb0e6973b2f: Pulling fs layer
18:10:44  ad5c9cab7f0c: Pulling fs layer
18:10:44  0a91c7f86643: Pulling fs layer
18:10:44  cacbb7d741ce: Waiting
18:10:44  0a91c7f86643: Waiting
18:10:44  ad5c9cab7f0c: Waiting
18:10:44  1cb0e6973b2f: Waiting
18:10:44  6d0337ea7090: Waiting
18:10:45  831490506c47: Downloading
18:10:45  3f7414369ae3: Verifying Checksum
18:10:45  3f7414369ae3: Download complete
18:10:45  6d0337ea7090: Download complete
18:10:46  1cb0e6973b2f: Verifying Checksum
18:10:46  1cb0e6973b2f: Download complete
18:10:46  ad5c9cab7f0c: Verifying Checksum
18:10:46  ad5c9cab7f0c: Download complete
18:10:46  0a91c7f86643: Verifying Checksum
18:10:46  0a91c7f86643: Download complete
18:10:48  c388bbfe10ff: Verifying Checksum
18:10:48  c388bbfe10ff: Download complete
18:11:15  cacbb7d741ce: Verifying Checksum
18:11:15  cacbb7d741ce: Download complete
18:11:44  unauthorized: authentication required

Hmm, I thought that we could still do anonymous pull. Let me check the details of this

Doesn't appear to be the same as #2323 (rate limit) but I thought it was worth mentioning.

We can easily add a login but I'm trying to avoid that approach as it requires everyone who uses our codebase to have a credential stored in jenkins with the same credential id as what we use.

Looking at https://status.docker.com/pages/history/533c6539221ae15e3f000031 it seems that the issue was upstream at dockerhub rather than with us. I've kicked off a build this morning and it seems fine


fix: incorrect and misleading attribute description for person detection samples

List of changes:
Changed descriptions for person detection samples
Fixes https://b.corp.google.com/issues/155666202


Autocomplete: Auto activate top suggestion in panel

Bug, feature request, or proposal:
Feature request
What is the expected behavior?
A user starts to write text and when sees that top option is suited just presses Enter (top option is selected)
What is the current behavior?
A user starts to write text and when sees that top option is suited he must first press 'Down' and only after that 'Enter'.
What is the use-case or motivation for changing an existing behavior?
A user can select top option faster. a user filling a big form can spend less time.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 4.2.2
Material 2.0.0-beta.6
OS Windows 10 (build 15063.0)
TypeScript 2.3.4
All supported browsers
Is there anything else we should know?
I think the best way is to make this feature switchable via input property

I'm not sure if this would play well with the expected interaction pattern for role="combobox" for screen-readers.

Hacky solution until official support arrives:
You can watch for options changes and use autocomplete._keyManager.setFirstItemActive().
I'm setting options manually, so I ended up with something like this:
class Component {
    @ViewChild('autocomplete') autocomplete: MdAutocomplete;

    changeOptions(options) {
        this.options = options;
        setTimeout(() => this.autocomplete._keyManager.setFirstItemActive());
    }
}

<md-autocomplete #autocomplete="mdAutocomplete">
    <md-option *ngFor="let option of options">
        {{ option }}
    </md-option>
</md-autocomplete>

I would love to see official support for this behavior with a simple property on the directive.  Note that this would have to be carefully negotiated if used in conjunction with selection-follows-focus ( #4951 ) -- we'd have to differentiate between an "active" item that the user has navigated to and an "active" item that we've highlighted in preparation for the user hitting Enter (or, and I hate having to keep this fight going, Tab).
As an aside, the autocomplete right here in Github agrees with me -- type an octothorpe here in the comment editor and you immediately get a list of suggested issues to reference.  The first one is highlighted immediately, though you can of course keep typing to narrow the list, and pressing tab activates the highlighted item, because that's what we've been trained to expect.  (Again, if this is incompatible with a particular a11y philosophy, I would argue that the solution is not to hobble the non-screen-reader experience but to modify behavior specifically for screen-reader users.)


Highlighting fails in long and messy fortran files

I work with a few old and very messy fortran77 physics codes, and they tend to "loose track" when syntax highlighting. Usually everything ends up being the default colour for variables.
See for instance this file: https://github.com/Jadzia626/SixTrack/blob/master/SixTrack/sixtrack.s
I'm using fixed form. I'm not sure whether this is Atom failing or the language pack.

There is a bug in the code there that fails to close a parenthesis correctly (line 27465). Seems to be the cause, however highlighting should recover from this. Other editors seem to do. Again, not sure whether this is the language plugin or atom.

Thanks, for posting! I know where the source of the problem stems from. It has to do with the rule for the parentheses attached to the sqrt function which is looking for a closed bracket in order to terminate. In older versions of the package, it would also terminate when it reached the end of a line (assuming no line continuation statement was present), however this was changed to allow the rules to be applied more generally to both fixed and free form files, since fixed form allows a line continuation marker to appear on the line after the line being continued.
So this behavior is semi-intentional to allow parentheses to span multiple lines in fixed form source files. However, it could be useful if the rules also looked for clear signs that something has gone wrong, e.g., the start of an if statement or some other statement than can't exist inside of a set of parentheses, to avoid scenarios where an unmatched parentheses consumes the entire file. I'll see what I can do when I have some free time this week. In the mean time, make sure those parentheses are closed! 😄

The problem is of course really that breaking lines across compiler pre-processor blocks is messy. (The +if lines are for a custom written pre-processor for this code.) The code compiles just fine as the two blocks are mutually exclusive so the code is technically correct. I just submitted a patch to fix this in our source, so highlighting works again for me now. But it would be great if the syntax highlighting could manage such cases. It seems to work fine in for instance Geany and Emacs. Not sure what logic these editors apply to this case.
Anyway, good to see someone made the fortran package for atom. I'm not at all surprised that the repository is owned by an astrophysicist!

I'm not familiar with either Geany or Emacs syntax highlighting engines, but I can at least attest to the fact that the Atom syntax engine (which is derived from the Textmate and Sublime Text engines) isn't particularly well suited for how the Fortran language is structured. A large portion of the problem comes from the source code being broken up into lines before being processed for syntax highlighting. Fortran has a number of features that can span multiple lines and sometimes you have to be able to look ahead to the next line in order to accurately highlight the line you are on. Unfortunately doing so isn't possible in Atom. In order to extend highlighting to be as accurate as it can be given these limitations, this package has expanded to cover much more of the source than most other syntax packages (almost everything in a Fortran source file is assigned a scope as opposed to only assigning scopes to things like keywords, constants, and function names). The down side of doing it this way is that it makes things more fragile to deviations.


R Integration.pyt "ImportError: DLL load failed: %1 is not a valid Win32 application."

Using ArcGIS Desktop 10.5 (Advanced) on Windows 10 (64-bit), I am experiencing an issue which is quite similar to #14. The R side seems to be setup properly
> arcgisbinding::arc.check_product()
product: ArcGIS Desktop ( <IP_ADDRESS>91 )
license: Advanced

and %USERPROFILE%\Documents\R\win-library\3.2\arcgisbinding has been successfully linked to ...\Desktop10.5\Rintegration (i.e., a folder .\arcgisbinding exists therein) using mklink. But still, R Integration.pyt does not reveal an installation script no matter if ArcGIS has been launched as Admin or not. Here's the output from 'Check Synthax...':

Alright, for future users facing the same problem: I've taken inspiration from a related GeoNet post and was thus able to solve this issue by introducing a PYTHONPATH system environment variable with the following content linking to
a) ArcGIS's Python2.7 installation (C:\...) and
b) the directory where ArcGIS10.5 is installed (E:\...):
C:\Python27\ArcGIS10.5\DLLs;C:\Python27\ArcGIS10.5\Lib;C:\Python27\ArcGIS10.5\Lib\lib-tk;C:\Python27\ArcGIS10.5;E:\apps\ArcGIS\Desktop10.5\bin;E:\apps\ArcGIS\Desktop10.5\arcpy;E:\apps\ArcGIS\Desktop10.5\ArcToolbox\Scripts


match statement performs strict type checking unlike if, causing it to fail unexpectedly when comparing String to StringName

Godot version
4.0 alpha5
System information
linux
Issue description
im trying to use "match" statement when an animation has finished.
however it doesnt work anymore. print debug doesnt see the match of an animation name
an "if" statement does work however
Steps to reproduce
func _on_animation_player_animation_finished(anim_name):

	if anim_name == "Fire":
		isfiring = false

	match anim_name:
		"Fire":
			isfiring = false
			print_debug("no match, anim_name=", anim_name)`

Minimal reproduction project
No response

PS: Code blocks should use triple backticks like this (with an optional language name for syntax highlighting):
```gdscript
code here
```
I edited your post accordingly, but remeber to do this in the future :slightly_smiling_face:

match is more strict than == and only matches if the types are the same, and anim_name is StringName in 4.0.
https://docs.godotengine.org/en/latest/classes/class_animationplayer.html#signals
It works with:
match anim_name:
	&"Fire":
		pass

it used to work fine in godot3.

Godot 3.x didn't have a StringName type exposed to GDScript, so everything was a String – including anim_name in your example.

so this is the new syntax i should be using then?

Yes :slightly_smiling_face:

it used to work fine in godot3.

Godot 3.x didn't have a StringName type exposed to GDScript, so everything was a String – including anim_name in your example.

so this is the new syntax i should be using then?

Yes slightly_smiling_face

ok so no bug then
works fine now, tnx!

Is there any logic behind match being more strict than ==?  It seems kinda unintuitive.  Do other languages do that?

Is there any logic behind match being more strict than ==? It seems kinda unintuitive. Do other languages do that?

i use it to test many anim_names at once. its much cleaner code imo
my example was just one anim_name but my script tests multiple at once
func _on_animation_player_animation_finished(anim_name):
	match anim_name:

		&"Hide":
			isequipped = false
		&"Weild":
			isequipped = true
		&"ReloadA":
			isreloading = false
		&"ReloadB":
			isreloading = false
		&"Fire":
			isfiring = false
		&"FireLast":
			isfiring = false

Is there any logic behind match being more strict than ==? It seems kinda unintuitive. Do other languages do that?

I agree, it seems unintuitive.

I just ran into this and disagree with the current design. Philosophically, match is only supposed to be syntactic sugar for if a == b statements.
var property: StringName = "alpha"

#matches
if property == "alpha":
     pass

# doesn't match, but should
match property:
    "alpha":
          pass

To have match and if function differently is poor design and a bug IMO.
Also, in GD3, String was supposed to provide unique references, so I could type "alpha" everywhere, or pass it in functions or compare it and it would only pass/compare the reference rather than copying or comparing each letter like a C array.
In GD4, String still says Strings are reference-counted and use a copy-on-write approach, so passing them around is cheap in resources. which suggests they should still be unique like StringNames which makes it seem that the latter class is redundant.
StringName further says You will usually just pass a String to methods expecting a StringName and it will be automatically converted, but that's clearly not happening here with match.

To have match and if function differently is poor design and a bug IMO.

Seconded

I also think match should perform loose type matching like if, but this is something @vnen should decide. It may also have performance implications to be considered.

i have no problem using an 'if' statement instead of match, i only posted it cause the syntax was changed

i have no problem using an 'if' statement instead of match, i only posted it cause the syntax was changed

That's fine, and I'm glad you have a solution. This is now no longer about your individual issue. It's about a philosophical design choice in the language that needs to be worked out for all Godot game devs. So far about 6 people have expressed a desire for reverting the change and no people or reasons for keeping the new behavior.

See also:

#74462
#74872


Browse object properties for "Folder" itemtype do not show in /exp debugging session.

I would like to thank you in advance for this project. Finally... Finally! we can customize the project experience like a normal human being would...
Scenario

I want to add a simple property to a folder node within a project.

Problem

Configuring the property viz "folder.xaml" does not work. Debugging sessions yield property-naked folders

Reproduction
1. Create a new project viz File > New > Project > Templates > Visual C# > Extensibility >  Property Type
2. Focus on the *.ProjectType project
3. Find "BuildSystem\Rules". folder
4. Open "folder.xaml"
5. Add a simple property (e.g. <StringProperty name="FoonaldTrump" />)
6. Save. Press F5
7. In Debugger, create a new project from your new Project Type
8. Once project loads, right click project node and choose Add > NewFolder.
9. Right click the folder with your cursor. Look in the properties window. For me, no configurations appear.
Let me know if this is indeed an issue, or if I need some guidance on how this type of configuration works. FYI: I am able to configure and subsequently see expected results for all of the other files just fine. Keep up the great work!

I just realized that my issue is more about the project system, and not Roslyn. I am moving it there.

This is well-known feature gap and is on the backlog for Visual Studio "15".


Fix/homedir tilde expansion

Improve os specific home directory detection and support tilde expansion.

This is working for me

utACK 519cf23

Pull Request Test Coverage Report for Build 1120

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 34.675%

Totals

Change from base Build 1119:
0.0%

Covered Lines:
357

Relevant Lines:
897

💛  - Coveralls


Token filters - remove_duplicates [DOC]

What do you want to do?

[ ] Request a change to existing documentation
[x] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Create a separate page for Token filter: remove_duplicates
Part of META issue: https://github.com/opensearch-project/documentation-website/issues/1483
*Version: all

@vagimeli I can take this one


Can not share my presence

Made a simple Console app RPC, It works for me but not for everyone else, whitelisted my friend in the project page, but still not working for him

Can you elaborate on this? What exactly prevents you from "sharing your presence?" How are you using the library that causes this issue?

Tha twas fast

It should be clear now

Thank you for providing more information. Could you possibly attach some of the code you're using? Thanks in advance.

Yes, but its kotlin, can you understand it?

Yes.

https://gist.github.com/Aregev2/17a1ce8604172719672e4cb34c3d4ebd
There you go.

@kkirigaya But then I do not have control over the presence (name and assets),

@kkirigaya there is no such thing as "approved" application id's. Discord offers a whitelist to enable global access to "Ask to Join" and "Spectate" for your application, however anyone may use it as they please.

@MinnDevelopment Ah, you're right, I got confused. My bad! Thanks for clarifying it for me.
@Aregev2 Aside from testing RPC, the presence is supposed to be set programmatically, for example, when a user enters a match or starts a game. If you want control over the presence rather than the user, you'll have to set it up to programmatically set the state, details, etc.
Regardless, Vatuu's lib was being used when this issue was made, so none of this really applies here. 😄


APPS-1146 Remove excessive configuration properties

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3d20c6d) 64.86% compared to head (198c93a) 64.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   64.86%   64.86%
=======================================
  Files          12       12
  Lines         538      538
=======================================
  Hits          349      349
  Misses        161      161
  Partials       28       28

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ruff

Codecov Report
Base: 64.86% // Head: 64.86% // No change to project coverage :thumbsup:

Coverage data is based on head (91baa2a) compared to base (e039d98).
Patch has no changes to coverable lines.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   64.86%   64.86%
=======================================
  Files           4        4
  Lines         185      185
=======================================
  Hits          120      120
  Misses         65       65

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Video playback in landscape orientation crashes the app

I noticed SociaLite was crashing when starting video playback in landscape orientation, and I think this line configuring the PiP window is causing the error: https://github.com/android/socialite/blob/main/app/src/main/java/com/google/android/samples/socialite/ui/player/VideoPlayerScreen.kt#L182
On the device I was testing with, it seems we're getting width 2340 and height 790, which is an aspect ratio of 2.96 and outside the 2.39:1 - 1:2.39 bounds that are accepted https://developer.android.com/reference/android/app/PictureInPictureParams.Builder#setAspectRatio(android.util.Rational)
Some possible solutions:

Clamp the aspect ratio to the accepted range 2.39:1 - 1:2.39
Remove the line explicitly setting the aspect ratio
I'm inclined to guess we're not actually using the video size when calculating this aspect ratio - this might require setting up a listener to properly update the PiP window aspect ratio once ExoPlayer has finished preparing the video

Fixed by @MagicalMeghan in PR #57 - thank you!


NFS SetUp and sample Usage in Kubegene

What this PR does / why we need it:
This PR explains related to NFS , how user can setup and use it in kube gene
Fixes: #4

Thanks @SrinivasChilveri  for this nfs help docs.


Show fwlink on certificate errors (#83)

#83

The CertificateLoader will be used for other scenarios than loading the HTTPS certificate. We're using it to load signing certificates as well. So I don't think the information about how to enable HTTPS is being added in the right context. I.e. you don't need instructions about setting up HTTPS if the configuration for your signing certificate is invalid. I think the HTTPS information needs to be added when setting up HTTPS with Kestrel.
Also, we should log a warning if the CertificateLoader try to find a certificate with a particular subject name in a store but doesn't find any.


Mondo to YNAB

This is not really me saying you should build this into the library, but it's a cool idea. Mondo (https://getmondo.co.uk/docs/) have an API with webhooks. It would be pretty cool to push them directly into YNAB.

I have released an initial version of this: https://github.com/scottrobertson/mondo-to-ynab

Good to see the library used !


Pipeline step SETUP: Transfer JMeter Files to Storage Account error- Error: unknown flag: --source

Running the pipeline and getting this error on the AZCopy step,
pipelines/azure-pipelines.load-test.yml Line 62
`- script: |
azcopy
--source $(JMETER_DIRECTORY_INPUT)
--destination $(terraform output storage_file_share_url)
--dest-key $(terraform output storage_account_key)
--recursive
workingDirectory: ./terraform
displayName: 'SETUP: Transfer JMeter Files to Storage Account'`
And the error:
`
jobs        Sub-commands related to managing jobs
list        List the entities in a given resource
load        Sub-commands related to transferring data in specific formats
login       Log in to Azure Active Directory (AD) to access Azure Storage resources.
logout      Log out to terminate access to Azure Storage resources.
make        Create a container or file share.
remove      Delete blobs or files from an Azure storage account
sync        Replicate source to the destination location
Flags:
--cap-mbps float                      Caps the transfer rate, in megabits per second. Moment-by-moment throughput might vary slightly from the cap. If this option is set to zero, or it is omitted, the throughput isn't capped.
-h, --help                                help for azcopy
--output-type string                  Format of the command's output. The choices include: text, json. The default value is 'text'. (default "text")
--trusted-microsoft-suffixes string   Specifies additional domain suffixes where Azure Active Directory login tokens may be sent.  The default is '.core.windows.net;.core.chinacloudapi.cn;.core.cloudapi.de;.core.usgovcloudapi.net;*.storage.azure.net'. Any listed here are added to the default. For security, you should only put Microsoft Azure domains here. Separate multiple entries with semi-colons.
-v, --version                             version for azcopy
py [command] --help" for more information about a command.
unknown flag: --source
##[error]Bash exited with code '1'.
Finishing: SETUP: Transfer JMeter Files to Storage Account
Bash exited with code '1'.
`

Fixed it, just updated my pipeline with the txt file in this other issue https://github.com/Azure-Samples/jmeter-aci-terraform/issues/58 , deleted my jmeter resource group, re-ran the pipeline and got past that step. Next issue is some other image registry credentials but at least past the first part.

Password issue was due to not having admin user enabled on the ACR I created
on main.tf line 75, in resource "azurerm_container_group" "jmeter_workers":
75: resource "azurerm_container_group" "jmeter_workers" {
Error: expected "image_registry_credential.0.password" to not be an empty string, got
on main.tf line 75, in resource "azurerm_container_group" "jmeter_workers":
75: resource "azurerm_container_group" "jmeter_workers" {


Delete all marker

Hello everybody,
How can i remove all marker without using map.clear()?
Thanks.

Declare markers colection, i.e
window.markers = [];
And every time a marker added, push it
wondow.markers.push(newMarker);
You can remove them later by looping through
window.markers[i].remove();

Yes, this should be the right way. I will consider adding some more API-Methods in the future (like removeAllMarkers, removePolygon() etc)

@FaisalAriyanto I've just checked the SDKs. There is no official way for it, so I won't add it (I could do it JS-side, but when I save all Markers and Polygons by default, it would be address to much memory, so I will drop this. @jokorivai's suggestions is the right path (on angular, you could also use a $rootScope or something similar)


[symfony-cloud] broken links

Just ran across this while working on a different project - issue does not cover something specific to docs-builder but is more or less a reminder to dig into this a bit more as time allows.
aside links break from secondary pages

We've deployed some changes to symofny.com so I'm closing this as fixed.
I was wrong and the problem was not about the RST parser but about how we render the sidebar menu on symfony.com. Cheers!


Dev blync

Blync Deploy!
The following files were deployed

courses/ruby-primer/01-level-getting-started/01-variables/body.md

Blync Deploy!
The following files were not deployed

courses/ruby-primer/01-level-getting-started/01-variables/body.md - {
"error": "Record not found",
"status": 404
}
courses/ruby-primer/01-level-getting-started/01-variables/instructions.md - {
"error": "Record not found",
"status": 404
}

Blync Deploy!
The following files were not deployed

courses/ruby-primer/01-level-getting-started/01-variables/body.md - {
"error": "Record not found",
"status": 404
}
courses/ruby-primer/01-level-getting-started/01-variables/instructions.md - {
"error": "Record not found",
"status": 404
}

Blync Deploy!
The following files were not deployed

courses/ruby-primer/01-level-getting-started/01-variables/body.md - {
"error": "Record not found",
"status": 404
}
courses/ruby-primer/01-level-getting-started/01-variables/instructions.md - {
"error": "Record not found",
"status": 404
}

Blync Deploy!
The following files were not deployed

courses/ruby-primer/01-level-getting-started/01-variables/body.md - {
"error": "Record not found",
"status": 404
}
courses/ruby-primer/01-level-getting-started/01-variables/instructions.md - {
"error": "Record not found",
"status": 404
}

Blync Deploy!
The following files were not deployed

courses/ruby-primer/01-level-getting-started/01-variables/body.md - {
"error": "Record not found",
"status": 404
}
courses/ruby-primer/01-level-getting-started/01-variables/instructions.md - {
"error": "Record not found",
"status": 404
}


Add datafactory as an extension to the devcontainer

Add datafactory as an extension to the devcontainer.
As I understand it (?), the devcontainer is being built from the main branch now, so this needs to go in before the PR where it is actually needed: https://github.com/UCLH-Foundry/FlowEHR/pull/156

/test

/test

/test


[WIP] Ftr: configuration store docs

Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description

Issue reference

Closing this issue in favor of https://github.com/dapr/docs/pull/1959


Uncaught TypeError: Cannot read property 'getScreenPosition' of undefined

Consistent repro steps in safe mode:

create empty coffee spec file
type req then tab
type some things. I typed grim
hit esc to clear the multiple cursors
move to end of line
make some new lines
type be then tab
:boom:

This has bracket matcher in the trace, but I'm not sure who the originator is.
See https://github.com/atom/bracket-matcher/issues/88
Atom Version: 0.185.0-30e3813
System: Mac OS X 10.9.5
Thrown From: bracket-matcher package, v0.71.0
Stack Trace
Uncaught TypeError: Cannot read property 'getScreenPosition' of undefined
At /Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1393

TypeError: Cannot read property 'getScreenPosition' of undefined
    at TextEditor.module.exports.TextEditor.getCursorScreenPosition (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1393:34)
    at TextEditor.module.exports.TextEditor.isFoldedAtCursorRow (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:2652:44)
    at BracketMatcherView.module.exports.BracketMatcherView.updateMatch (/Applications/Atom.app/Contents/Resources/app/node_modules/bracket-matcher/lib/bracket-matcher-view.js:111:23)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/bracket-matcher/lib/bracket-matcher-view.js:94:26
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)
    at /Applications/Atom.app/Contents/Resources/app/src/cursor.js:70:25
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)
    at Marker.module.exports.Marker.destroyed (/Applications/Atom.app/Contents/Resources/app/src/marker.js:264:20)
    at /Applications/Atom.app/Contents/Resources/app/src/marker.js:51:24
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:82:11)

Commands
     -0:17.1 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -0:17.1 snippets:expand (atom-text-editor.editor.is-focused)
     -0:13.9 editor:move-to-next-word-boundary (atom-text-editor.editor.is-focused)
     -0:13.4 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
  2x -0:12.9 editor:newline (atom-text-editor.editor.is-focused)
     -0:10.3 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -0:10.3 snippets:expand (atom-text-editor.editor.is-focused)
  5x -0:08.6 core:select-up (atom-text-editor.editor.is-focused)
  2x -0:07.7 core:backspace (atom-text-editor.editor.is-focused)
     -0:05.8 snippets:next-tab-stop (atom-text-editor.editor.is-focused)
     -0:05.8 snippets:expand (atom-text-editor.editor.is-focused)
     -0:03.3 core:backspace (atom-text-editor.editor.is-focused)
     -0:02.8 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:02.0 core:move-right (atom-text-editor.editor.is-focused)
  2x -0:01.6 editor:newline (atom-text-editor.editor.is-focused)
     -0:00.4 snippets:next-tab-stop (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "autosave",
      "color-picker",
      "css-color-highlighting",
      "font-viewer",
      "atom-css-comb",
      "live-archive",
      "atomatigit",
      "minimap",
      "autocomplete"
    ],
    "themes": [
      "one-light-ui",
      "one-light-syntax"
    ]
  }
}

Installed Packages
# User
welcome, v0.23.0

# Dev
metrics, v0.45.0
notifications, v0.30.0
snippets, v0.76.0
welcome, v0.23.0

Cursor merging changed recently. I wonder if it's related to that. Hitting esc and merging the cursors is the key to making this happen.
If I move to the end of the line and merge the cursors, everything is fine.
cc @nathansobo

I reproduced it using your steps

Will look at this tomorrow.

This seems to be a bug in the snippets package.

This is because the snippets package is only listening to move events on a single cursor, but that cursor ends up getting destroyed and replaced by a new one when the selection is cleared, so snippets doesn't realize that you've moved outside of the last snippet expansion.

This issue was moved to atom/snippets#112


#26 Improve Domain Name detection Regexp

This PR resolve issue #26

The patch is ready for review.
This patch enforces hostname validation according to different RFC. The public API does not change, only the League\Uri\Components\Host::isDomain method is made more strict and thus the League\Uri\Components\Domain class is also made stricter.
The patch still leaves two special registered names as valid domain name whereas they technically not.
<?php
use League\Uri\Components\Host;

(new Host(null))->isDomain(); // will still return true
(new Host(''))->isDomain(); // will still return true

These two exceptions are kept to help with usage and to reduce BC breaking. Depending on your feedback I will add this information in the documentation to be as transparent as possible. Maybe this one may be drop during another major release 🤔
@pawelkg , @kelunik what do you think ?

The first thing I noticed is that IDN domain will not pass isDomain() test because toUnicode() is called after test itself.
Meaby it's good idea to add isIDN() method by the way?
As I can see in 1.x branch isDomain() for null and '' return false (which is correct; see: uri-components/tests/Components/HostTest.php lines 171 and 183), so this should be consider as fix not BC breaking change.

The first thing I noticed is that IDN domain will not pass isDomain() test because toUnicode() is called after test itself.

@pawelkg registered name are kept internally in ascii mode the isValidDomain method is only called on the ascii form of the domain name so no issue their 😉

As I can see in 1.x branch isDomain() for null and '' return false (which is correct; see: uri-components/tests/Components/HostTest.php lines 171 and 183), so this should be consider as fix not BC breaking change.

Then this means more changes and documentation changes in v2 at least for the Domain object.

PR updated by removing support for the empty string and null as valid domain names


Various IKEA tradfri gateway enhancements

Use a random identity on new setups
Alow multiple gateways to be set up, either in the config file or auto discovered
configuration.yaml now accepts a list of gateways. (required attribute: host, optional attributes: name, allow_tradfri_groups)
configuration panel now includes a checkbox for 'allow_tradfri_groups' (depends on: https://github.com/home-assistant/home-assistant-polymer/pull/581)
gateway setup timeouts after 10 seconds and then shows a persistent notification
allow_tradfri_groups is written to the .tradfri_psk.conf (which actually should've just been named .tradfri.conf, but for backward compatibility we'll leave it there)
all changes should be backward compatible with current configurations (both manual config or autodiscovered configs)

Hey!
thanks for this! just wanted to look at the issues...
I checked the code. when the key is found but the is invalid one gets a lot of errors like these:
Nov 06 19:17:15 ALRT 20 invalidate peer 2017-11-06 19:17:15 ERROR (MainThread) [coap] Fatal DTLS error: code 20 Nov 06 19:17:15 WARN received alert, peer has been invalidated 2017-11-06 19:17:15 ERROR (MainThread) [coap] Exception CancelledError() can not be represented as errno, setting -1. Error in close: -1
maybe catching it and logging one error would be nice. maybe just restart setup process.
empty .tradfri_psk.conf leads to just one:
2017-11-06 19:18:48 ERROR (MainThread) [homeassistant.setup] Error during setup of component tradfri Traceback (most recent call last):   File "/home/flo/git/home-assistant/homeassistant/setup.py", line 190, in _async_setup_component     result = yield from component.async_setup(hass, processed_config)   File "/home/flo/git/home-assistant/homeassistant/components/tradfri.py", line 136, in async_setup     known_hosts = yield from hass.async_add_job(_read_config, hass)   File "/usr/lib/python3.5/asyncio/futures.py", line 361, in __iter__     yield self  # This tells Task to wait for completion.   File "/usr/lib/python3.5/asyncio/tasks.py", line 296, in _wakeup     future.result()   File "/usr/lib/python3.5/asyncio/futures.py", line 274, in result     raise self._exception   File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run     result = self.fn(*self.args, **self.kwargs)   File "/home/flo/git/home-assistant/homeassistant/components/tradfri.py", line 248, in _read_config     return json.loads(f_handle.read() or '{}')   File "/usr/lib/python3.5/json/__init__.py", line 319, in loads     return _default_decoder.decode(s)   File "/usr/lib/python3.5/json/decoder.py", line 339, in decode     obj, end = self.raw_decode(s, idx=_w(s, 0).end())   File "/usr/lib/python3.5/json/decoder.py", line 357, in raw_decode     raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 2 column 1 (char 1)
better if this was caught and normal setup starts IMHO.
deleting .tradfri_psk.conf does what it should: resume the normal setup process.

also there is some weird behavior regarding the groups checkbox. Selection results seem to be inverted.

created a pull request against your branch trying to improve the weird OSError. (NovapaX/home-assistant/pull/1)
new to asyncio, don't know how to kill the subprocess. Would it be a possibility to kill it from within the except block?

Thanks for looking at it. I'll merge your fixes.
But I was told that this PR was a bit 'overwhelming' and it's better to split things up a bit.
So I made a new PR for the unique identity fix.
First priority should be getting that error/loop out now.
But we need someone with great skill to look at it ;-)
Then we can do some proper error handling and feedback.
I'll close this PR (again)


Allow newer versions of duckdb

Duckdb 0.7.1 has a lot of bug fixes and interesting features like support for filesystems: https://duckdb.org/docs/guides/python/filesystems
Removing duckdb pin from 0.6.1 to 0.6.1-0.8.0. Is there any concern with this change?

@JorgeGarciaIrazabal  thanks for the PR - I think we had some issues with latest duckdb - we will review and check the tests and upgrade it.

@JorgeGarciaIrazabal thanks for the PR - I think we had some issues with latest duckdb - we will review and check the tests and upgrade it.

thank you

@JorgeGarciaIrazabal  thanks a lot for the PR - merged it via https://github.com/sodadata/soda-core/commit/dcb66f4d6d989a5124da10cc50e3ae3201795278
We will release a new tag today with the fix.

We will release a new tag today with the fix.

@vijaykiran  just following up, any updates on the release?

@JorgeGarciaIrazabal 3.0.38 has been tagged with the fix. Can you check?

@vijaykiran I didn't see in the releases in github but it is in pypi. This works for us, thank you very much!


Fixes nested convert failure when using source mapping

This issue was caused by the wrong logic of creating merged mappings of source mapping.
Resolved: #331

@chhsiao90,
Looks good and works fine.
When will we see it in public repository? :)
Thank you!


Root Element of XML-Views

Hi,
i was wondering what should be used as the root element of XML-Views?
Looking at the code that parses xml views  i found that it ignores the name of the root element by using the documentelement property.

The documentation mentions View of namespace sap.ui.core and the example snippets in the documentation are using it too:

<core:View controllerName="sap.hcm.Address" xmlns="sap.ui.commons" xmlns:core="sap.ui.core" xmlns:layout="sap.ui.commons.layout">
   <layout:MatrixLayout>
      ...

The demo apps and many examples i've found are using View with namespace sap.ui.core.mvc:

<mvc:View
	controllerName="sap.ui.demo.tdg.view.Master"
	displayBlock="true"
	xmlns:mvc="sap.ui.core.mvc"
	xmlns="sap.m">

For fragments the code defines the Element FragmentDefinition of namespace sap.ui.core and the examples and documentation conform with it.
Is there any convention on what element and namespace to use for Views?

Hi Bernhard,
the truth is (and this has led to the different examples you see) that the root element's name and namespace is pretty much ignored. Nevertheless, the correct thing to do is using a "View" tag in the "sap.ui.core.mvc" namespace. This is the correct package name of the "View" class.
Any occurrence of the core namespace should be changed, I'll look into the examples you gave.
Regards
Andreas


Enzyme 3 - Static Rendering skimming most outer tag

package.json
 "enzyme": "^3.2.0"
 "enzyme-adapter-react-16": "^1.1.0"
 "react": "16.1.1",

import React from 'react';
import { shallow, render } from 'enzyme';

import { configure } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';

configure({ adapter: new Adapter() });

const Foo = () => {
  return
FooContent

}

console.log(render(<Foo />).html())
console.log(shallow(<Foo />).html())

xit('let me run the test', () => {});

console.log(render(<Foo />).html())

it will log  FooContent
console.log(shallow(<Foo />).html())

it will log
FooContent

when using render the most outer tag from the component doesn't get rendered.
Is it the expected behaviour?
I could not find any reference to this change in this document https://github.com/airbnb/enzyme/blob/master/docs/guides/migration-from-2-to-3.md
or the in the Static Rendering doc:
http://airbnb.io/enzyme/docs/api/render.html
Thanks in advance!
Please let me know any further info you guys need!

Yes, this is expected behavior, and due to the breaking change in cheerio v1.

It might be a silly question, do we get any benefit out of it?
The only reason I ask is because, now we need wrap our components in div's on the test to be able to test it, using render.

It's a change cheerio made; enzyme can't stay on 0.22 forever, so we had to upgrade eventually.

Thanks for the prompt answers @ljharb !
I would suggest the following in this case.
in: https://github.com/airbnb/enzyme/blob/27d05a0829221b3f1eca0917a0ab7393e4148804/packages/enzyme/src/render.js#L22
instead of
return cheerio.load('')(html);

it could be:
return cheerio.load(html)('body');

Then the return would still the same as before(enzyme version 2). So the cheerio upgrade would not be a breaking change. Let me know If that sounds like a good idea, if so,  I can create a PR for it.

At this point, making that change would be a breaking change for enzyme 3.

I see, in this case there is nothing to be done about i.
Thanks, and have a great day! :)


Suggest commands are not serialized

Related: https://github.com/microsoft/vscode/issues/210753
Currently on shell start up all aliases/commands are sent over from pwsh. This is not being serialized land restored so suggest doesn't work properly after.
Before reload:

After reload:

Am I verifying this correctly?

Install the PowerShell extension
New pwsh terminal
G in the terminal
See suggest show with lots of good cmdlet suggestions
Reload window.
G in the same re-attached terminal
See suggest show with lots of good cmdlet suggestions

yep 👍


Remove ref links & update tests

As we're now passing Spectral's raw {{description}}; {{error}} to the end user, we should clean up the {{error}} by removing the unnecessary reference link as API Insights already handled mitigation/recommendation separately.
As a part of this, all tests also had to be updated to test/match against the new message format.

@npateriya, @coliu19
Discussion: Where new message format doesn't lead to a better user experience
Where {{description}} and {{error}} are the same
Old: Error representations include a useful human-readable message. (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: Error representations include a useful human-readable message.; Error representations include a useful human-readable message.
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-8a66d52e04f9cee5af214b2398e47b2bc3f0ec50821cae7925fae86983b28718
Old: API uses path-based versioning. (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: API uses path-based versioning.; API uses path-based versioning.
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-e5e461f83ba6be3fcf9a92a0b7327e4ff8651444b87d7e373b05dba5ed1f64d5
Old: API shows only major version numbers on the path; not the revision numbers. (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: API shows only major version numbers on the path; not the revision numbers.; API shows only major version numbers on the path; not the revision numbers.
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-a153529541ef29325cde67eabefbb844427003211bb99f39db09ac9ad9ca9895
Where {{description}} and {{error}} have redundancy
Old: When returning a paginated collection, include a "max" query parameter (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: Pagination is designed using a \'max\' query parameter and \'Link\' headers per RFC 5988.; When returning a paginated collection, include a "max" query parameter
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-79ef91f79c5bdfa1073afd31ced18a5b10250b772a01f85ac144c6be759c7e1b
Old: It is recommended to add a "sort" query parameter to sort this collection (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: Sorting collections is designed with a \'sort\' query parameter.; It is recommended to add a "sort" query parameter to sort this collection
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-fcb0925a2ffdb9ee11a58ef26af424385814ecddb835f9cf207c280e7353d74a
Where meaningful information is actually removed
Old: Accept-Charset must have a default defined (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: HTTP headers follow the syntax specified in the corresponding RFCs.; "[0].default" property must be truthy
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-2e6a6ece477f8a580febd19925d95cba23240a445d7908fca29bfe2885f674a0
Old: Default for Accept-Charset must be UTF-8 (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: HTTP headers follow the syntax specified in the corresponding RFCs.; "test" must match the pattern "^[Uu][Tt][Ff]-8$"
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-d19f85b90c9967bbbaa3660bacbe76974185db358d89f6763943c0e071c0c0bd
Old: Date header should be type \'string\' and should not use the built-in OpenAPI format. Instead, \'pattern\' should be used to specify a custom format (https://developer.cisco.com/docs/api-insights/#!api-guidelines-analyzer)
New: HTTP headers follow the syntax specified in the corresponding RFCs.; "[0].pattern" property must be truthy
See: https://github.com/cisco-developer/api-insights-openapi-rulesets/pull/20/files#diff-9ecd8724949dd6e21e3a3ab1705c3ec7741c8b8b50ad4a0c171f8fced1354bc0

For these cases, I think we have two ways to handle them. The first one may be better choice.

Modify the message in ruleset to make it more meaningful. so we can keep all place in same mesage-error format.
Specially handling for some case, not use message-error format.

For these cases, I think we have two ways to handle them. The first one may be better choice.

Modify the message in ruleset to make it more meaningful. so we can keep all place in same mesage-error format.
Specially handling for some case, not use message-error format.

@coliu19  Can you please add meaningful comments for above cases, as you are most familiar with code.


Update 'released' fonts to version 2.000

Updates the versionString, versionMajor, and versionMinor values
to 2.000 to indicate that these fonts are considered 'release quality'
when built with our current toolchain.
(Note that SansTamilUI is generated from the Tamil.glyphs file but is
not ready for release yet, this is an exception).

LGTM


How to repair a Substrate Chain in the way time warp?

Issue
Our test network is suspended for some reason. We want to use the way time warp to restore it. I found the issue #4464. But there is a big difference between the  version which we use ( our version is polkadot-v0.9.18).
I also read here（https://substrate.stackexchange.com/questions/168/how-to-unbrick-a-substrate-chain-revert/175#175）, but there is no detailed description of how to perform time warp.
Questions
About time warp, can you give some help base on the version  polkadot-v0.9.18（or a newer version）？  @andresilva @rphmeier

https://github.com/paritytech/substrate/commit/d0decd934335f98398f159b4c0ca7117e2641f91
These are the changes you need to apply temporarily to your nodes. You need to change REVIVE_TIMESTAMP to the time  in the future when you are expecting to start the warp (i.e. most validators will be running this code by then), and the FORK_TIMESTAMP to the time of the last block that was authored before the chain bricked. Also make sure you adapt the WARP_FACTOR to something that is sensible to your chain's block time, the block time during warp will be normal block time / WARP_FACTOR, so if you have say 6s block time I'd advise not to increase WARP_FACTOR higher than 12. You should also test this locally before you distribute binaries to validators.
This is a very error-prone and time-consuming process, if this is a test network then I suggest that you just export the state and restart it from genesis (you can use https://github.com/maxsam4/fork-off-substrate for this).
We will not be able to provide you with further support in this task.

I succeeded in repairing the chain in this way. Thank you very much.

@anonymousGiga A simple idea.
First, you need to backup the chain's data beforehand, saving the VALIDATOR KEY.
Second, when the chain is down for any reason, you can use the backup file to restore it on multiple nodes, and it needs to be noted that your time needs to be adjusted to the recorded time of the backup file;.
Third, keep generating blocks for each epoch, you can make it out of 10 blocks, and then use the script to modify the time according to the epoch period set by the chain, you need to note that when modifying the time, you need to shut down the node temporarily, and after the modification is finished, open the node.
Finally, when your node time and the current time are less than 1 epoch, you can directly modify the node time to the current time, thus restoring the chain successfully.

You can also use the link for hard spoon: https://github.com/maxsam4/fork-off-substrate, which I think would be a different application scenario.
When you need to keep historical block data, or want the block to roll back, then you can use the method I described.
When you don't need to keep historical block data, just use the script in the link directly.


Avoid double metrics.metrics package name

Motivation
package metrics.metrics looks more than just bizarre. Moving the two concrete 'implementations' for our Metrics to a slightly better named package (impl)
Description
Fixing odd package structure
Progress

[x] Done Task

Additional Notes

I don't like package name impl, interface, etc because for me it means nothing. But if people like it let's move on.

I think that metrics.impl is much better than metrics.metrics :)
but we can rename the impl to something more meaningful
On Wed, Feb 21, 2018 at 12:27 PM, Daniel Passos<EMAIL_ADDRESS>wrote:

I don't like package name impl, interface, etc because for me it means
nothing. But if people like it let's move on.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aerogear/aerogear-android-sdk/pull/63#issuecomment-367296348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJnzueKqoKrmpRVY4VqO7y3uXcRSEVQks5tW_2ogaJpZM4SNPT5
.

--
Matthias Wessendorf
github: https://github.com/matzew
twitter: http://twitter.com/mwessendorf


Urobiome package term suggestion host_gender_identity

New term details
Term name - host gender
Structured comment name - host_gender_identity
Definition - Gender of the host if relevant for the study.
Expected value -  free text
Value syntax - {text}
Example - trans woman
Preferred unit -
Package - Urobiome

Additional context
Suggested as part of the Urobiome package.

We have confirmed that this is distinct from other mixs terms


do not lose the KUBECONFIG environment variable when clobbering it

So I've always maintained a custom KUBECONFIG=$HOME/.kube/config:$HOME/.kube/foo:$HOME/.kube/bar. This works great for kubeswitch on the first time I run it - and then it overwrites the env var with its custom tempfile. The second time I run kubeswitch the values are lost, and only the default $HOME/.kube/config file is shown as options of context's to switch to. I would expect it to save the KUBECONFIG value somewhere and on subsequent invocations show me all of those options.
Alternatively I can define switch-config.yaml and maintain it separately but then of course I have it maintained in two locations when I'd prefer to use the "standard" support in kubectl in some situations.
PS thanks for this tool - it scratches an itch I've had for a really long time and you've done a much nicer job implementing it than anything I was thinking to do for myself!

Thanks for your suggestion!
The only thing I can currently think of is to introduce another env variable (say KUBECONFIG_PREVIOUS set already in switch.sh script) that remembers the last KUBECONFIG env and includes these paths in a subsequent search with switch.
A caveat I can already think of is that switch would need to remove duplicate paths in case KUBECONFIG_PREVIOUS and KUBECONFIGcontain the same path - possibly using a set datastructure with the path as key.
Possibly there are more implications that I have not thought about.
I'll update here when I have time to give it a shot.

I know there's mention of kubeswitch using a cache, and I figured that things like this would be its purpose when initially reading the docs... like that it would take the KUBECONFIG env var and cache it before clobbering it. I think I misunderstood the purpose of that cache because otherwise it feels like it would belong there - but yes I would expect it should be a per-terminal cache.
Some sort of secondary env var makes sense to me and probably favorable versus a second per-terminal tempfile... Could also consider writing it into the existing per-terminal tempfile and parsing it back out but feels a bit hacky just to get it down to one tempfile.

I ended up using this trick to get around this limitation
kubectx(){
  CURRENT_KUBECONFIG=$(echo $KUBECONFIG | sed -e 's/^.*\.switch_tmp\/config.[0-9]*\.tmp://g')
  switch $@
  set -a
  export KUBECONFIG=$KUBECONFIG:$CURRENT_KUBECONFIG
  set +a
}

kubens(){
  CURRENT_KUBECONFIG=$(echo $KUBECONFIG | sed -e 's/^.*\.switch_tmp\/config.[0-9]*\.tmp://g')
  switch . > /dev/null 2>1
  switch ns
  set -a
  export KUBECONFIG=$KUBECONFIG:$CURRENT_KUBECONFIG
  set +a
}

@sherifabdlnaby 's solution works flawlessly


onConsoleLog error should indicate which test the logging came from

Clear and concise description of the problem
If we use onConsoleLog to handle uncaught errors, it does not seem possible to see which test the error came from.
As an example, the Apollo GraphQL client can throw a "No more mocked responses" error. This alone does not cause a test to fail in Vitest. I would like to catch these errors and ensure they fail a test.
By default, the test output shows me the problematic test, but does not fail.

stderr | src/tests/MyTest.tsx > My test
No more mocked responses for the query...

If I update vite.config.mts to force an error...
onConsoleLog(log, type) {
   if (log.startsWith('No more mocked responses')) throw new Error(`${log}`)
}

The tests now fail, however it no longer indicates which file is the problem.

Unhandled Rejection.  Error: No more mocked responses for the query...

Suggested solution
If these outputs could be combined so onConsoleLog indicates the problem test, it would solve the issue.
Alternative
Currently I use onConsoleLog to force an error in the case of "No more mocked responses". I then have to comment it out, re-run the test and look for the uncaught error message telling me which test it is.
Additional context
Thank you for all your work on Vitest, it's amazing and I'm so happy to be free from Jest 😁
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Can you provide a reproduction? From the description only, I failed to see what exactly is happening in your scenario. For example,

the Apollo GraphQL client can throw a "No more mocked responses" error. This alone does not cause a test to fail in Vitest.

I feel Vitest's default behavior is usually fails the tests on uncaught errors. So is Apollo really throwing an error? Maybe they are just doing only logging with console.error without throwing?

I have to guess but I think I understand your situation.
I think Apollo only uses console.error since it's not technically a hard error from Apollo's standpoint, but you want to make it hard error. In this case, (ab)using onConsoleLog or custom reporter's onUserConsoleLog doesn't seem appropriate since these hooks runs on main process (not during the tests). Anything you do there would be too late and I don't think you can utilize it like you imagine even if Vitest exposes more metadata to onConsoleLog.
For your situation, one trick came to my mind is to monkey-patch console.error to just catch Apollo's log inside tests:
beforeAll(() => {
  const original = console.error;
  console.error = function (...args) {
    original(...args);
    if (args[0].startsWith('No more mocked responses')) {
      throw new Error(args[0]);
    }
  }
});

If you think Apollo's logging should be a hard error, then maybe you can send a feature request there to provide some option to make it a hard error.


[BUG] Firestore triggers need to use handler syntax

The current syntax used by Firestore-triggered functions is:
functions.firestore.document(config.mailchimpMemberEvents.watch).onWrite(async (event, context) => {

However, extensions should use the handler syntax to set up functions. It would be look like:
functions.handler.firestore.document.onWrite(async (change, context) => {

A user can configure the document that the extension watches by configuring it with a param

This change has been made and merged, closing issue.


Function called by minimizer is ignoring user-defined prior penalty function

Compare https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L1037 to https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L849

Looks like this came from @ts4051 and @philippeller here: https://github.com/IceCubeOpenSource/pisa/blame/master/pisa/analysis/analysis.py#L338

The option is uncommented in https://github.com/IceCubeOpenSource/fridge/blob/master/analysis/common/analysis/core/oscillations_analysis.py#L816, though I don't know where else it could have been used

I believe this has been solved by now, as evidenced by https://github.com/icecube/pisa/blob/master/pisa/analysis/analysis.py#L2667.


Make 1.0 compatible with Flow 6.x

Just add the possibility to use Neos.Eventsourcing 1.0 with Flow 6.x based projects.

I added a PR https://github.com/neos/Neos.EventSourcing/pull/254

#254 was reverted because it potentially breaks with Flow 6 due to the ObjectManager => EntityManager change

How about closing this issue? It's stale and I don't think anyone should put energy into 1.0 or making something compatible with Flow 6.x. There's PHP 8.1, we'll have Flow 8 soon, don't look back ;-)


Makes secure crates harder to break into

Made a metallic damage type that can't be damaged below a rather high threshold (read: nearly impossible to break without high end weapons like captains sabre or guns / laser weapons). This means far less cargonia.
:cl:

tweak: Sad day for Cargonia. All secure crates have been buffed so your basic tools won't break them anymore,

yo can this be applied to doors

Fixes #5742

I only partially agree with this. I think that without the emag being in, this makes cargo traitor borderline impossible. Raising the threshold on the gun crates is fine, since that gives security plenty of warning when they hear the inevitable emitter noises - but I think cargo should be reasonably able to build an AME if they want, or get bombsuits.
A better solution would be to implement order history on the console and put cargo computers in the HoP office/on the bridge in most stations to make it clear if and when cargo orders guns.

What if I PR an initial version of the emag (opens + breaks doors, crates, lockers)? Both will merge at the same time cos feature freeze right?

I only partially agree with this. I think that without the emag being in, this makes cargo traitor borderline impossible. Raising the threshold on the gun crates is fine, since that gives security plenty of warning when they hear the inevitable emitter noises - but I think cargo should be reasonably able to build an AME if they want, or get bombsuits.
A better solution would be to implement order history on the console and put cargo computers in the HoP office/on the bridge in most stations to make it clear if and when cargo orders guns.

Fair comments. It's simple to for now just set the parent for those crates back to genericcrate rather than basesecurecrate or however I named it.
2nd solution assumes you have competent players which right now we do not. We have cargonia every single round and self antags. In Ss13 I don't recall ever being able to break into a crate without a mining mech but I do agree maybe gun crates should realistically be more secure than bomb suit crates or w/e.

On second thought no I think this stands. Cargo shouldn't be able to get stuff in secure crates and if they do want it then they can steal an ID or get HoP.
Cargo making AME is bad stuff.


docs: updates based on recent packaging changes

Recent RPM and DEB package build changes have added/removed
packages. Update the installation guide and setup scripts to
match.
Signed-off-by: Tim Whisonant<EMAIL_ADDRESS>

Coverage increased (+0.03%) to 65.481% when pulling 0f300199efe824877361e87b4216de7a1f906ddf on tswhison/docs into 3ec482a2f75441ddacf36f93c9788b0768c115f4 on master.


Modifying Pinned Points of SoftBody3D is broken

Tested versions

Godot 4.3.beta2

System information
Godot v4.3.beta2 - Windows 10.0.22631 - Vulkan (Forward+) - integrated Intel(R) Iris(R) Xe Graphics (Intel Corporation; <IP_ADDRESS>86) - 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 Threads)
Issue description
I'm not sure if this issue is just related to the SoftBody3D pinned points array or PackedInt32Arrays in general as I haven't been able to find other uses of it quickly.
When modifying values and position of points in the Pinned Points array of a SoftBody3D, behaviour is unstable. Current bahaviour observed is as follows:

Increasing value using the value arrows occasionally swaps the position in the array and is inconsistent in whether the values are actually changed or not (this can occur even if you miss click the arrows and just click on the item)
Clicking an entry not at the end of the array will delete the last entry in the array.
Trying to increment the last entry in the array deletes it instead
Moving an entry to another position in the array just deletes the entry also.

I have also observed that occasionally entering values directly, by typing them in, will delete the last value too.
In addition to the issues mentioned above, setting pinned points via the 3D viewport doesn't work. Clicking on the handles does nothing and deselecting and reselecting the node doesn't change this meaning it's not just a visual glitch. However, clicking and dragging on a vertex will select it, but only the vertex where the drag began is selected and it must begin on the vertex.
Steps to reproduce
MRP contains a single scene with a SoftBody3D node. The mesh is a simple plane primitive. Issue can be observed by attempting to modify the pinned points of this soft body.
Minimal reproduction project (MRP)
test.zip

Pretty sure this works in 4.2.2 stable and not work in 4.3-beta2. Sometimes it is hard to click.

I'm finally starting to get a bit more familiar with the code base, but still not entirely confident yet. Having said that, I may have isolated the issue:
https://github.com/godotengine/godot/blob/82cedc83c9069125207c128f9a07ce3d82c317cc/editor/plugins/node_3d_editor_plugin.cpp#L1930-L1933
This is from the mouse button section when the button is released. It seems that changes to gizmo handles are only committed if the mouse has moved. This makes sense for things such as the transform gizmos but not so much for other types.
Is there any reason this check needs to be there? I'm not confident I know all the dependencies well enough to know if this would affect something else.

Can confirm the above code is the cause of clicking handles not registering in the 3D viewport, and was introduced in this PR. Obviously, I'd like to keep these modifications if possible, so I'll do some further investigation to see if there's a way to keep these optimisations while fixing the issue (obviously there's more than just this one addition, but this seems to be the only one affecting SoftBody handles). I'm also going to do some investigation into the other issues mentioned above before opening a PR for this fix.

So I've fixed the 3D viewport issue by just removing the check and it seems fine with no recurrence of the issue addressed in the mentioned PR. I also added an update_gizmos() call as handles weren't updating until the mouse moved off of the handle.
With regards to the issue of modifying pinned points via the inspector, I've narrowed down the issue to this bit of code in the _set_property_pinned_points_indices() function:
https://github.com/godotengine/godot/blob/ff8a2780ee777c2456ce42368e1065774c7c4c3f/scene/3d/soft_body_3d.cpp#L197-L211
Somewhere between line 199 and 210 the pinned_points vector gets resized. My assumption is that it's something in _pin_point(), either with how they're set or removed.
I ran a test with some data and this is the results:
Starting Data
pinned_points = [6, 4, 3, 2, 1] <- pinned point indices prior to update
p_indices = [5, 4, 3, 2, 1] <- expected indices after update

Output
w = [5, 4, 3, 2, 1] <- pointer used in update with correct indices
pinned_points = [5, 2, 4, 3] <- the actual pinned point indices after update


Request to add product in Start Flutter

Hello,
I am Maheshwari from team GeekyAnts. On behalf of Start Flutter, we add open source products which we find helpful to the community & also we provide credits to author itself.
Let me know if you are interested showcase your product in our open source website.
If yes, then I request you to add MIT Licence in your repo.
Looking forward to hear from you.

Hey,
The project is using Apache license - https://github.com/vintage/scratcher/blob/master/LICENSE


spray.json.JsArray to sequence of case classes

How do I convert a spray.json.JsArray to sequence of case classes?
e.g. I have a variable
movieArray which is of typespray.json.JsArray and I would like to turn it into a sequence of Movie case classes case class Movie(id: Int, title: String)
I tried already movieArray.convertTo[Seq[Movie]] and movieArray.map(_.convertTo[Movie]), but neither seemed to work.

Can you define does "not work" mean here? Pasting the compile or runtime errors  you encountered would make helping you easier.
This works:
    "works" in {
      case class Movie(id: Int, title: String)

      import spray.json._
      import DefaultJsonProtocol._ // if you don't supply your own Protocol (see below)
      implicit val movieFormat = jsonFormat2(Movie)

      val x = """
        |[
        |  { "id": 12, "title": "that movie" }
        |]
      """.stripMargin.parseJson

      info("it + " + x.convertTo[Seq[Movie]])
    }

"not work" -meant that I got the following errors
Cannot find JsonReader or JsonFormat type class for Seq[Movie]
value map is not a member of spray.json.JsValue
Followed your instructions, and now I got an error which says...
Cannot automatically determine case class field names and order for 'Movie', please use the 'jsonFormat' overload with explicit field name specification
Any suggestions for next step?

Apparently I had a problem in my class. Your solution is correct. Thanks

Happy hakking


[Question] Incorrect conversation creation parameters (CreateConversationAsync)

System Information (Required)

SDK Language: C#
SDK Version: Microsoft.Bot.Connector.Teams (0.5.6), Microsoft.Bot.Builder.Azure (3.2.2)
Development Environment: Azure App Service

Issue Description
I am getting the following error from the CreateConversationAsync:
Incorrect conversation creation parameters

The documentation says that the teamsChannelId and teamsTeamId parameters are obsolete, so I am using channel, team and tenant objects in the channelData object.
The workaround mentioned in #3061 didn't work for me, I have tried various combinations of parameters.
Code Example
            var channelData = new TeamsChannelData
            {
                Channel = new ChannelInfo(subscription.ChannelId),
                Team = new TeamInfo(subscription.TeamId),
                Tenant = new TenantInfo(subscription.TenantId)
            };

            var newMessage = Activity.CreateMessageActivity();
            newMessage.Type = ActivityTypes.Message;
            newMessage.Text = message.ToString();    // about 600 characters
            var conversationParams = new ConversationParameters(
                isGroup: true,
                bot: null,
                members: null,
                topicName: date.ToString("d. M. yyyy"),
                activity: (Activity)newMessage,
                channelData: channelData);

            var connector = new ConnectorClient(new Uri(subscription.ServiceUrl));
            var result = await connector.Conversations.CreateConversationAsync(conversationParams);

Can you advise what are the conditions for the Incorrect conversation creation parameters error?

During my last tests 2 weeks ago, I couldn't create a conversation on MS Teams using the classic CreateConversationAsync of the framework but got to use a method from Microsoft.Bot.Connector.Teams, called CreateOrGetDirectConversation
The following code works to create a conversation:
// Connector init
MicrosoftAppCredentials.TrustServiceUrl(connectorClientUrl, DateTime.Now.AddDays(7));
var account = new MicrosoftAppCredentials(msAppId, msAppPassword);
var connector = new ConnectorClient(new Uri(connectorClientUrl), account);

// Conversation members init
ChannelAccount channelFrom = new ChannelAccount(fromId, fromName);
ChannelAccount channelTo = new ChannelAccount(recipientId, recipientName);

// Create Conversation
// Tenant ID can be found on https://portal.azure.com/#blade/Microsoft_AAD_IAM/ActiveDirectoryMenuBlade/Properties
ConversationResourceResponse conversation = connector.Conversations.CreateOrGetDirectConversation(channelFrom, channelTo, myTenantID);

Then you can send a message to this conversation:
// Create message Activity and send it to Conversation
IMessageActivity newMessage = Activity.CreateMessageActivity();
newMessage.Type = ActivityTypes.Message;
newMessage.From = channelFrom;
newMessage.Recipient = channelTo;

newMessage.Locale = (locale ?? "fr-FR");
newMessage.ChannelId = channelId;
newMessage.Conversation = new ConversationAccount(id: conversation.Id);
newMessage.Text = message;

// Send 1st message to the conversation
var resp = await connector.Conversations.SendToConversationAsync((Activity)newMessage);

Thank you. I don't know whether the CreateOrGetDirectConversation can be used when you need to post to a specific channel, but I got my code working by adding this:
MicrosoftAppCredentials.TrustServiceUrl(serviceUrl, DateTime.MaxValue);

Also, I have specified the app id and password in the constructor of ConnectorClient explicitly but I believe I don't have to as they are fetched from the configuration automatically.

If you look at my code you will see that it's using a variable providing the channel yes.
Finally you didn't use it? Looks like what was missing in my old implementation is the channelData containing the tenantId in that case, thanks.


Do we need to worry about nullability of columns?

Are there situations where we want to be careful about this?
Current behavior:
sc <- spark_connect(master = "local")
df1 <- copy_to(sc, data.frame(id = c("a", "b"), value = 1L), "df1")
df2 <- copy_to(sc, data.frame(id = c("a", "b")), "df2") %>%
  mutate(value = 1L)
df3 <- copy_to(sc, data.frame(id = c("d", "e"), value = c(1, NA)), "df3")
df4 <- rbind(df2, df3)

list(df1, df2, df3, df4) %>%
  lapply(spark_dataframe) %>%
  lapply(purrr::partial(invoke, method = "schema"))
# [[1]]
# <jobj[376]>
#   class org.apache.spark.sql.types.StructType
# StructType(StructField(id,StringType,true), StructField(value,IntegerType,true))
#
# [[2]]
# <jobj[377]>
#   class org.apache.spark.sql.types.StructType
# StructType(StructField(id,StringType,true), StructField(value,IntegerType,false))
#
# [[3]]
# <jobj[378]>
#   class org.apache.spark.sql.types.StructType
# StructType(StructField(id,StringType,true), StructField(value,DoubleType,true))
#
# [[4]]
# <jobj[379]>
#   class org.apache.spark.sql.types.StructType
# StructType(StructField(id,StringType,true), StructField(value,DoubleType,true))

Right now, 'null' is treated the same as missing / NaN by sparklyr, as R does not have a way of representing NULL values within atomic vectors. This was necessary to ensure faster serialization, but does imply a lost of information re: the distinction between null and NA.

All special types: NaN, NA, NULL, "", etc. under serialization deserve a careful second look, I think.

We will revisit all special types under https://github.com/rstudio/sparklyr/issues/941, closing this one.


feat(metrics): record sync count for Subscriptions, labeled with name and installedCSV

This increments a count whenever we sync a CSV, labelled with the name and phase of the CSV. This should let us see which operators are being installed and what their lifecycle generally looks like.
Open to suggestions for better ways to report; the count seemed like the simplest thing. If OLM should be syncing one of them long enough to max the count, it should wrap back around.
Example queries:
Sync counts by name
sum(subscription_sync_total) by (name, installed)

Element
Value

{installed="postgresoperator.v4.0.0-rc10",name="crunchy-postgres-operator"}
4

{name="crunchy-postgres-operator"}
7

(in grafana you can do label_values(subscription_sync_total, name) to get just a list of names)

/hold
I want to test in a real cluster first, but otherwise fine to review

/retest

/hold cancel

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest

/retest
On Wed, Jul 17, 2019 at 5:39 PM OpenShift CI Robot<EMAIL_ADDRESS>wrote:

@ecordell https://github.com/ecordell: The following tests failed,
say /retest to rerun them all:
Test name Commit Details Rerun command
ci/prow/e2e-aws 8e9c523
https://github.com/operator-framework/operator-lifecycle-manager/commit/8e9c5235918c19877a181e722763ff2e4fd735eb
link
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/951/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws/2468 /test
e2e-aws
ci/prow/e2e-aws-olm 8e9c523
https://github.com/operator-framework/operator-lifecycle-manager/commit/8e9c5235918c19877a181e722763ff2e4fd735eb
link
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/951/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws-olm/2488 /test
e2e-aws-olm
ci/prow/e2e-aws-upgrade 8e9c523
https://github.com/operator-framework/operator-lifecycle-manager/commit/8e9c5235918c19877a181e722763ff2e4fd735eb
link
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/operator-framework_operator-lifecycle-manager/951/pull-ci-operator-framework-operator-lifecycle-manager-master-e2e-aws-upgrade/682 /test
e2e-aws-upgrade
Full PR test history
https://prow.svc.ci.openshift.org/pr-history?org=operator-framework&repo=operator-lifecycle-manager&pr=951.
Your PR dashboard
https://prow.svc.ci.openshift.org/pr?query=is:pr+state:open+author:ecordell.
Please help us cut down on flakes by linking to
https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests
an open issue
https://github.com/operator-framework/operator-lifecycle-manager/issues?q=is:issue+is:open
when you hit one in your PR.
Instructions for interacting with me using PR comments are available here
https://git.k8s.io/community/contributors/guide/pull-requests.md. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://go.k8s.io/bot-commands.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/operator-framework/operator-lifecycle-manager/pull/951?email_source=notifications&email_token=AAAOFR4P66HGDI3GACPF43LP76GQJA5CNFSM4IBWWLH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2GVL5A#issuecomment-512579060,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAOFR2D4NHA4KXGMXWEN4TP76GQJANCNFSM4IBWWLHQ
.

/retest

/retest

/cherry-pick 4.1

/cherry-pick release-4.1


Using Arachne with Django

@kirankoduru Please how do i implement this concept with Django application and how do i declare multiple spider in SETTINGS. Thanks

Hi @samsoft00 I haven't ported this application for Django yet. But I can write a guide for it soon.


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/scienceplots-feedstock#2.


what should we do about this repo?

It seems to be unmaintained, which may not be a problem if the text is primarily intended to showcase an archive or if it is updated to exclude overly dynamic information.

I think this could be re-purposed where we build out the best practices for contributing and being a part of the gno.land ecosystem. In essence a directory of sorts that lays out the guide of being a gnome.
A Guide to Contributing so to say, or a 'Hitchhiker's Guide to gno.land' we could include the contributing md link and provide the what makes a good contributor and how to showcase your work.
The steps recommended: namespace, home realm, and documenting your journey...etc. We could include the available tools that are at the contributors disposal.
My question: do we want to transition this type of information to gnoverse?
My take: The gno repo, should provide the canonical guides, and information for contributors and gnoverse is where they go to add their projects for ecosystem consumption.
My question: Would this idea compete with getting started?
My take: Probably not, as getting started is more about the technical side of gno.land where a contributors guide is more about the individual in the ecosystem.
This might be a good place one day for the constitution?

My question: do we want to transition this type of information to gnoverse?

Gnolang should still be initial point of contact, and Gnoverse should be a safe space to play around with Gno.
As such, it makes more sense to have the bulk of the contributing info on gnolang, and some gnoverse specific info on gnoverse. Both should have clear links to each other.

My question: Would this idea compete with getting started?

We can have a clear distinction between the two types of content. I'd be happy to drive the effort for this repo.


the script syncs only events created by the page

EXPECTED BEHAVIOUR
sync all events added to my Facebook page (not only the one created by it)
this is how I can add whatever event to my page:

CURRENT BEHAVIOUR
the script synchronize only the events created by the page :(

I think this has to do with the scope of your facebook token. You may not be able to view all events with the same token.


(AzureCXP) fixed the EventHub name char limit

As per this article the EH Char name limit is 256: https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-quotas#common-limits-for-all-tiers

@navba-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@tfitzmac Could you please review this PR once you get a chance ?

#sign-off


Password recovery: The birthdays field is required

Users cant restore their accounts cause its require Birthdays too, but restore-form didnt have this fields.
When you enter the new password and fill in the confirmation, when you press Save changes with new password you will see "Birthday field is required".

Fixer 👍
   ```

$rules['birthday'] = [
'sometimes',
Rule::when($isRequired && ! $flarumValidator->getUser(), 'required', 'nullable'),
'date',
sprintf('before:-%s years', (int) $this->settings->get('datlechin-birthdays.min_age')),
];


Release 2.9 clone

Description
What-if attempting the update on GitHub
Update  from release branch (centre balloon)
https://datasift.github.io/gitflow/GitFlowMasterBranch.png
In particular, I'm not sure if I merged properly for the following, watch out for a screwed up merge conflict in:

:grimacing:

ui redesign buttons by @KimberleyChong
gravatar fix by @svonworl

You primarily just want to focus on the merge commit
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4050
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-4050
Please make sure that you've checked the following before submitting your pull request. Thanks!

[ ] Check that your code compiles by running npm run build
[ ] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[ ] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[ ] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[ ] Do not use cookies, although this may change in the future
[ ] Run npm audit and ensure you are not introducing new vulnerabilities
[ ] Do due diligence on new 3rd party libraries, checking for CVEs
[ ] Don't allow user-uploaded images to be served from the Dockstore domain

We don't need https://github.com/dockstore/dockstore-ui2/pull/1490/commits/740e260635a4c4db164229f01ed5d2a5c969a2b9, the file changed by that commit (src/app/search/basic-search/basic-search.component.html) was correct beforehand, I think.

We don't need 740e260, the file changed by that commit (src/app/search/basic-search/basic-search.component.html) was correct beforehand, I think.

breaks the tests though


feat: add vault secret store impl

What type of PR is this?
/kind feature

What this PR does / why we need it:
add vault secret store impl
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

115 of 151 (76.16%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 75.352%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/secrets/providers/hashivault/vault.go
115
151
76.16%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
6591

Relevant Lines:
8747

💛  - Coveralls


fixes bug 1298045 - Remove "Recruitment Message" functionality

Coverage decreased (-0.01%) to 86.085% when pulling 8d5c3478ee2802f86788a725fd33effa7673f68d on peterbe:bug-1298045-remove-recruitment-message-functionality into f7b0fdf3f674831ff92f13f75cf9464f6b49fa07 on mozilla:master.


Add chmod as installation step

The second step (chmod) is mentioned on the web and also after the dryup.sh script execution. As it is a legitimate installation step, it should be mentioned in the readme too.

Makes sense, thanks!!


Frobenius norm promotes float32 matrix to float64 norm

When applying a Frobenius norm on a float32 matrix, a float64 outcome is generated. A float32 should be expected (similar to numpy). I will try to have a look at this problem next week. Not sure whether the same is true for int-type and complex-type matrices. It might also improve the calculation speed a bit.
Cheers.
Minimal Complete Verifiable Example:
import numpy as np
a_64 = np.random.rand(500,500)
a_32 = a_64.astype(np.float32)
print(a_64.dtype, a_32.dtype) # float64 float32
print(np.linalg.norm(a_64, 'fro').dtype, np.linalg.norm(a_32, 'fro').dtype) # float64 float32

import dask.array as da
da_a_64 = da.asarray(a_64)
da_a_32 = da.asarray(a_32)
print(da_a_64.dtype, da_a_32.dtype) # float64 float32
print(da.linalg.norm(da_a_64, 'fro').dtype, da.linalg.norm(da_a_32, 'fro').dtype) # float64 float64

Environment:

Dask version: '2021.04.0'
Numpy version: '1.19.2'
Python version: 3.8.3
Operating System: Windows 10

da.linalg.norm always hits a np.promote_types call:
https://github.com/dask/dask/blob/94dae165dfa30f1fdf76eef28e24414ff246d0f4/dask/array/linalg.py#L1461-L1462
Perhaps this should be avoided for float32 inputs?

@RogerMoens Thanks for reporting this! I just checked and this is still an issue on Dask 2021.07.2 and (Dask main).
Touching base to see if you were able to take a look at this, do you still want to take a crack at it?

@ncclementi , I will try to give it a go next week.

I don't see any similar thing (i.e. promoting the precision) being performed within the NumPy linalg norm function:
https://github.com/numpy/numpy/blob/5ae53e93b2be9ccf47bf72a85d71ea15d15a2eed/numpy/linalg/linalg.py#L2500
So, an easy fix would be to remove the promotion of types. However, I am trying to figure out why this was required. Would it be possible that it is done to handle complex input matrices? Do you have any idea why the type promotion is performed? @douglasdavis @ncclementi
To add to the speed of float32 vs float64 (@douglasdavis), if the matrix does not fit into memory (mostly the case when you go to float32 I presume), then it could be a tremendous speed up w.r.t. read/write.


thumbnails not showing

Hello
The folder preview and thumbs were not showing.
I removed the / before vendor in the line below in laradrop.js and now the folder shows.
folderImage = options.folderImage ? options.folderImage : 'vendor/jasekz/laradrop/img/genericThumbs/folder.png',
In the database public_resource_url if I remove the leading / then the thumbnails show.
I must have a setting wrong somewhere?
Thanks for any help.
Regards
Del

ok worked it out thanks