Increase heap size of the generate compilation process

Alternate continuation of https://github.com/prisma/prisma2/issues/254
The scope of the #611 (which was to be the next step in #254) is big enough that we want to tackle that after https://github.com/prisma/photonjs/issues/238
This issue offers an alternative short term solution to unblock people from #254 is to increase the heap size of the generate process that runs the TS compiler.

Will this make it in time for Preview 14?

It is targeted for Preview 14 yes but preview 14 lands on 10th October (because we are experimenting with 2 week sprints)

Released in the latest preview. We increased the heap size to 2048 mb. Please let us know, if that already helps with your bigger schemas 🙏

Hi @timsuchanek, I just tried again using Preview 14 but I'm still receiving the error spawn E2BIG.
The Schema that I'm trying to introspect is running on a Heroku Postgres DB (140 Tables, 8.34 MB)
ERROR  Introspection failed:
Error: Command failed with exit code 7 (E2BIG): /home/will/.nvm/versions/node/v1
1.15.0/lib/node_modules/prisma2/query-engine-linux-glibc-libssl1.1.0 cli --dmmf_
to_dml

Let me know if there is any additional info that I can provide

Preview 14.1 Yields the same result.
After doing some digging through the output I have found various issues such as
"documentation": "Field name normalization failed because of a conflicting field name."

"documentation": "Field name normalization failed because of a conflicting field name.\\nCould not auto-generate backwards relation field, field name would be ambiguous.\\nPlease specify the name of this field and the name of the relation manually.\\nIt references PropertyAccess.nearestInternationalAirport."

I don't know if these are a symptom or a cause of the error?

We increased this further to 8096 here: https://github.com/prisma/prisma2/commit/e04d81be1b0a2495d33a80bec24177e80a310ec8
Closing this issue. Please ping me if you think that this issue should not be closed.
Note that this is a temporary fix to unblock users, the proper fix is tracked here: https://github.com/prisma/prisma2/issues/611


article social links

fix styling on bookmark icon

this bug is actually that the bookmark icon cannot be clicked because the profile menu is overlapping it when it's opacity is 0. need to set the z-index as well i think so it doesn't block the social icons.


When modal have just one step the first next button must be the complete button

See the bug on modal-sample-3 demo.

I fixed this issue and this is work for me. Maybe you check? I added below code to $modal .on('show.bs.modal', function(){  last line before closing }
My code is:
var steps = $modal.find('div[data-step]').length;
if (parseInt(steps) === 1){
	$btnNext
		.attr('data-step', 'complete')
		.html(settings.btnLastStepHtml);
} else {
	$btnNext
		.attr('data-step', nextStep)
		.html(settings.btnNextHtml);
}


Fit canvas to the scaled image OR prevent panning unless the image overflows

I would like to prevent panning unless the image itself goes outside of the bounds of the viewer. So if a user zooms out, no panning because there's no need, or if the scaled image doesn't take the full height of the viewer there's no reason to pan up and down (which looks like moving the image up and down), etc.
My thoughts on how to do this have been:

Find the size of the scaled image after it loads and then update my div OpenSeadragon mounts into to match that size
Determine if the container has overflow and disable panning in each direction it does not
Figure out what size the scaled image will be and set the height and width on the div before initializing OpenSeadragon

I feel like the first two bullet points should be doable and I'm just missing it. Everything I have tried so far either matches the size of my div container I mount OpenSeadragon to or the original full size of the image I am loading.

@jmichalicek I think the second bullet point is the easiest option. I personally wouldn't want to also have to handle potential html layout issues when a viewer zoom changes.
The OpenSeadragon.Viewport class has the methods to handle the coordinates and any conversions you need.
A Viewer canvas-drag event handler could be used to prevent dragging when necessary

Thanks @msalsbery I had been looking at those methods for coordinates on the Viewport class and playing with them, but straight up brainfarting on it.
I ended up with this to get the functionality I wanted when going at it with a fresh brain instead of doing it after work.
viewer.addHandler('canvas-drag', (dragEvt) => {
      const imageBounds = viewer.world.getItemAt(0).getBounds()
      const viewportBounds = viewer.viewport.getBounds()

      const hasTopOverflow = viewportBounds.y > 0
      const hasBottomOverflow = viewportBounds.y + viewportBounds.height <= imageBounds.height
      const hasLeftOverflow = viewportBounds.x > 0
      const hasRightOverflow = viewportBounds.x + viewportBounds.width <= imageBounds.width

      const preventDragUp = dragEvt.delta.y < 0 && !hasBottomOverflow
      const preventDragDown = dragEvt.delta.y > 0 && !hasTopOverflow
      const preventDragRight = dragEvt.delta.x > 0 && !hasLeftOverflow
      const preventDragLeft = dragEvt.delta.x < 0 && !hasRightOverflow
      if (preventDragUp || preventDragDown) {
        dragEvt.delta.y = 0
      }
      if (preventDragLeft || preventDragRight) {
        dragEvt.delta.x = 0
      }
    })


Broken in Firefox and IE

As you said in the Readme this widget is not working in IE and FF.
I've found the issue in the setCenter fn.
Here is a solution that worked for me.
setCenter: function() {
    var clockRadius, svgNode, height, width;
    svgNode = this.refs.svgContainer.getDOMNode();
    height = svgNode.getClientRects()[0].height;
    width = svgNode.getClientRects()[0].width;
    if (height > width) {
      clockRadius = width / 2;
    } else {
      clockRadius = height / 2;
    }
    return this.setState({
      xCenter: width / 2,
      yCenter: height / 2,
      clockRadius: clockRadius
    });
  }

Oh cool! Would you mind submitting a pull request with the change and updating the docs? If not I may get it in there in the next month or so.

Sure, i'll submit in a couple of days :smile:

I've tried writing coffescript, but i gave up after a while.
To whoever wants to use the component, just replace the function in the above post.

I forgot all about this. I'll try to merge it in myself.
On Jul 7, 2015 9:12 AM, "grasuxxxl"<EMAIL_ADDRESS>wrote:

I've tried writing coffescript, but i gave up after a while.
To whoever wants to use the component, just replace the function in the
above post.
—
Reply to this email directly or view it on GitHub
https://github.com/parris/react-clock-timepicker/issues/2#issuecomment-119216689
.


added superembed stream server

can you describe what are all changes seems a lot

I just added Superembed stream server to movie url


I wonder how to change bandwidth every 3 seconds.

Have you read the Tutorials?
Y
Have you read the FAQ and checked for duplicate open issues?
Y
What version of Shaka Player are you using?
3.1.3
Please ask your question
First of all, thank you for developing a good program.

I want to change the bandwidth information every 3 seconds using the setTimeOut function, but is there a related API in Shaka? The bandwidth information of the video was obtained as shown in the code below.

I wonder how to change the approximation bandwidth closest to 7.0m using the find() function when pressing the button.

I'm always grateful to you :)

I am not sure I understand your question.  Do you want to change the selected track based on the bandwidth requirements of that track?  Or do you want to artificially change Shaka's understanding of the available bandwidth, and force it to choose certain tracks through that?

I relied on a translator and couldn't properly convey my intention. I'm sorry :(
What I want to do is get the chunk size of mpd, and when I get the chunk three times, I want to change it to the next bandwidth track.
If the chunk size is 4, change to the next track in 12 seconds.

I wonder if there is an API in the shaka player that receives the chunk size of the mpd image.

If I receive the chunk 3 times, can I change it to the next bandwidth track?

So first,The player's bandwidth was created as a list.
var trackList = player2.getVariantTracks();
console.log(trackList);
0: {id: 0, active: true, type: 'variant', bandwidth: 1000000, language: 'und', …}
1: {id: 1, active: false, type: 'variant', bandwidth: 3000000, language: 'und', …}
2: {id: 2, active: false, type: 'variant', bandwidth: 5000000, language: 'und', …}
3: {id: 3, active: false, type: 'variant', bandwidth: 7000000, language: 'und', …}

There is not an API to receive the chunk size, but if you know the way your content is encoded, you could hard-code the time interval.  Alternately, you could explore the manifest structure (player.getManifest()) and get the size of the first segment of an arbitrary track, and use that to compute your time interval.
Changing tracks is easy.  After getVariantTracks(), select an item from that list and call selectVariantTrack().  Be sure to disable ABR in the player configuration first, or else ABR will make its own choices periodically.
Does this help?

The answer was helpful.
console.log(player2.getManifest().variants[0].video)
The segment could be confirmed. Thank you.
Is there a way to change to the next track every time I receive three chunk?

You can change tracks using the API I mentioned before.  To know when you've received three chunks, you could use a network filter.  Our license server authentication tutorial has examples of network filters:
https://shaka-player-demo.appspot.com/docs/api/tutorial-license-server-auth.html
You would want to look for request type of SEGMENT instead of LICENSE, and you won't need to modify anything in the request.  Just observe and count.
Does this help?

It helped me a lot. Thank you!


Add description when the fit method can be called with different paramters to optimize attack models

I just researched a little bit, which parameters ART provides for the attack model fitting. There are not really many options via ART but I just documented everything - including ideas that are not yet possible with ART- below. I also added ideas, that are more general and not directly dependent on parameters but still are possible ways to optimize the attack model.
For the MembershipInferenceBlackBox fitting:

There are no direct parameters for the fit function to optimize the attack model
In general: Providing more training data
In general: Providing an own attack_model which performance better
If no custom attack_model is provided and the attack_model_type is 'nn': You could adjust the epochs, batch_size, learning_rate of the training process via calling attack.art_attack.epochs = ...
If no custom attack_model is provided and the attack_model_type is 'gb' or 'rf': For both types sklearn implementations are used. You could check the documentation of sklearn (there are plenty parameters to tweak these models) and then call something like attack.art_attack.attack_model.<parameter_name> = ...

This is all not really pretty due to a lack of options via the ART framework.

I just researched a little bit about which parameters ART provides for the attack_model fitting. There are not really many options via ART but I just documented everything - including ideas that are not yet possible with ART- below. I also added ideas, that are more general and not directly dependent on parameters but still are possible ways to optimize the attack_model.
For the MembershipInferenceBlackBox fitting:
* `ART` do not provide any direct parameters for the `fit` function to optimize the attack_model

* In general: You could provide more training data

* In general: You could provide your own `attack_model` which performance better

* If no custom `attack_model` is provided and the `attack_model_type` is `'nn'`: You could adjust the `epochs`, `batch_size`, `learning_rate` of the training process via calling `attack.art_attack.epochs = ...`

* If no custom `attack_model` is provided and the `attack_model_type` is `'gb'` or `'rf'`: For both types `sklearn` implementations are used. You could check the documentation of sklearn (there are plenty parameters to tweak these models) and then call something like `attack.art_attack.attack_model.<parameter_name> = ... `

This is all not really pretty due to a lack of options via the ART framework.
For the MembershipInferenceBlackBoxRuleBased fitting:
* There is no `fit` function

For the LabelOnlyDecisionBoundary fitting:
* In ART the `fit` function is called `calibrate_distance_threshold`

* In general: You could provide more training data

* The following parameters to optimize the `attack_model` are provided by `ART`

:Keyword Arguments for HopSkipJump:
            *norm*: Order of the norm. Possible values: "inf", np.inf or 2.
            *max_iter*: Maximum number of iterations.
            *max_eval*: Maximum number of evaluations for estimating gradient.
            *init_eval*: Initial number of evaluations for estimating gradient.
            *init_size*: Maximum number of trials for initial generation of adversarial examples.

I have not added any documentation to the code yet. It's just a summary so that we can decide where this info should go. What do you think @Friedrich-Mueller?

This whole post is pretty neat and we should discuss incorporating it into the readme? Below the attack descriptions? Or maybe we split this post and append a piece of it to each of the attacks?

Yes, I think the README is a good place to provide some general info on how to optimize the fitting process. I think splitting it and adding it for each attack respectively makes the most sense to provide the info in the right context. Nevertheless, I would still add the parameters for the LabelOnlyDecisionBoundary to the docstrings of the fit() method.


telemetry: add tokio runtime metrics

This PR introduces a new unstable API for collecting tokio runtime metrics which is gated behind --cfg tokio_unstable and --cfg foundations_unstable.
This doesn't add all metrics. In particular, tokio's poll duration histogram is not present since some additions might need to be made to our histogram API.

One thing I realized - we probably need a way to deregister runtimes or at least to drop them if the runtime goes away.

@inikulin I've added deregistration and addressed the last bit of feedback.


[bug] Version 2.0.0 crash in Windows

Description (bug summary)
I am getting Problem getting monitor brightness in the debug console with this error dialog.

Step to reproduce (how to reproduce the bug)
Run debug with version 2.0.0, 2.0.0+1 or 2.0.0+2 are showing the same error. It will only work if I change back to 1.0.1.
Platform (Android/iOS/macOS/Windows)
Windows

Hi, @chsi020. Can you show some example code?

Hi @aaassseee,
import 'package:screen_brightness/screen_brightness.dart';

@override
  Future<void> registerDependencies({required GetIt getIt}) async {
    final screenBrightnessPlugin = ScreenBrightness();

    getIt
      ..registerLazySingleton<ScreenBrightness>(() => screenBrightnessPlugin);
}

import 'package:screen_brightness/screen_brightness.dart';

mixin ScreenBrightnessMixin<T extends StatefulWidget> on State<T> {
  double get brightness => 1; // overridable by consumer

  @override
  void initState() {
    super.initState();
    try {
      getIt<ScreenBrightness>().setApplicationScreenBrightness(brightness);
    } catch (e) {
      throw Exception('Failed to get system brightness');
    }
  }

  @override
  void dispose() {
    try {
      getIt<ScreenBrightness>().resetApplicationScreenBrightness();
    } catch (e) {
      throw Exception('Failed to reset system brightness');
    }
    super.dispose();
  }
}

Hi, @chsi020. Can you show some example code?

Just adding the library to pubspec is enough
You don't even need to reference it anywhere.
When running the application, the message “Problem getting monitor brightness” appears in the console
So here's a question
Why is the plugin trying to perform some actions without my knowledge)?

Hi @TheLastFlame. I reason that the plugin run at start is, the plugin needs to remember the system brightness on the current monitor for use to reset back to. There is no system brightness on windows system, so the plugin needs to remember this initial brightness when launching the application.

And the crash happened when the app is started or after adjusting the system or the application brightness?

Hi @aaassseee,
I ran the sample code, and it started up fine. I am using an HP ZBook notebook along with an old Dell monitor. The crash occurred when the app started. The only way to make it work was to revert the pub version back to 1.0.1.
Best regards,
James

@chsi020 Is that means the sample code works fine without any crash?

@chsi020 Is that means the sample code works fine without any crash?

Hi @aaassseee,
The sample code works fine without crash.

We are also running into the same issue. Our app crashes on startup, and the only error message logged is also Problem getting monitor brightness.
However, we are able to run the example app correctly...

Hi @chsi020 , @vincent-hoodoo . Can you gays provide a minimum runnable example for me to test? It is hard to reproduce.

Hi @chsi020 , @vincent-hoodoo . Can you gays provide a minimum runnable example for me to test? It is hard to reproduce.

It is enough to create a new project with Empty application template and execute flutter pub add screen_brightness in the terminal
This is the most minimal example.
This error probably cannot be reproduced on your device.

Hi @TheLastFlame thanks for the screen capture. May I ask is that downgrade to 1.0.1 will not crash?

Hi @TheLastFlame thanks for the screen capture. May I ask is that downgrade to 1.0.1 will not crash?

Right, after downgrading to 1.0.1 the problem disappears

Thanks for the help, I will take a look.

@aaassseee
I also encountered this annoying issue, and it seems I found the trigger condition for this problem. The above error is thrown when this package runs together with the most popular Flutter audio and video component, media_kit. I looked into the internals of media_kit, and it also references screenbrightness_android and screenbrightness_platform_interface internally to implement the brightness adjustment function of its built-in player control panel. I think this might be causing the issue, but I am not sure where exactly the problem is coming from.

Hi @ALL, are you guys are all using windows notebook?

@aaassseee Yeah, I working on laptop.

Hi @Predidit, can you help me to comment lines of code in https://github.com/aaassseee/screen_brightness/blob/175b30d7df16ece10420e2c643f6f56e7f5431b4/screen_brightness_windows/windows/src/screen_brightness_windows_plugin.cpp#L24-L31 to test is the plugin can run without crash?

@aaassseee
Sorry, but I don't know how to fix the problem here. If you want to make any changes, I would be happy to test them for you.
It seems to be an issue from the CMake build system because it can be triggered simply by referencing both the screen_brightness and media_kit packages in pubspec.yaml and initializing the media_kit package. The screen_brightness package doesn't even need to be imported in any part of the Dart code. It is possible that the CMake file of media_kit modifies some CMake variables globally. I don't know why screen_brightness 1.0.1 doesn't trigger this issue.

@Predidit But @chsi020 @TheLastFlame @vincent-hoodoo said that

Hi @chsi020 , @vincent-hoodoo . Can you gays provide a minimum runnable example for me to test? It is hard to reproduce.

It is enough to create a new project with Empty application template and execute flutter pub add screen_brightness in the terminal This is the most minimal example.
This error probably cannot be reproduced on your device.

using the minimal project would also produce this crash.
Would you help to fact check this plugin itself causing the crash?

And are you using the media_kit with screen_brightness at the same time will cause this crash? If so, I can give it a try.

Okay, I will create a completely blank project for testing. I would like to add that the try-catch block above worked. When the media-kit package is not present, the console outputs a brightness fetch error message that does not prevent the program from continuing to run.

Okey! That must be one of the clued.  Thanks for the help though @Predidit.

@aaassseee
Sorry, after testing with a blank project, I think I made a serious mistake. The crash occurs with just flutter pub add screen_brightness, without needing any other packages. The complex dependencies in my actual project interfered with the initial test.

@Predidit Not a problem though,. Can you help me to remove the lines from local pub cache
https://github.com/aaassseee/screen_brightness/blob/175b30d7df16ece10420e2c643f6f56e7f5431b4/screen_brightness_windows/windows/src/screen_brightness_windows_plugin.cpp#L24-L31
To test if getting the initial brightness causing the crash?

@aaassseee still crash

@Predidit that's weird. Can you undo the changes than comment this part?
https://github.com/aaassseee/screen_brightness/blob/175b30d7df16ece10420e2c643f6f56e7f5431b4/screen_brightness_windows/windows/src/screen_brightness_windows_plugin.cpp#L61C1-L72C143

@aaassseee still crash
I removed the code on line 72 to pass the compilation.

if comment the whole section from
https://github.com/aaassseee/screen_brightness/blob/175b30d7df16ece10420e2c643f6f56e7f5431b4/screen_brightness_windows/windows/src/screen_brightness_windows_plugin.cpp#L61-L85

If still crash, can you undo the changes and comment this part?
https://github.com/aaassseee/screen_brightness/blob/175b30d7df16ece10420e2c643f6f56e7f5431b4/screen_brightness_windows/windows/src/screen_brightness_windows_plugin.cpp#L346-L409

@aaassseee good news
I removed L346-L408 (all the HandleWindowProc function)
It doesn't crash now.
But it still crash when I only remove L348-L377.
We are getting close. I am trying to find the breakpoint.

@Predidit Thanks for the help bro.
I think I know where is the problem.

@Predidit It seems missing the try catch on HandleWindowProc method

@Predidit just the last test. Can you able to run the program with replacing the HandleWindowProc function with this fix?
	std::optional<LRESULT> ScreenBrightnessWindowsPlugin::HandleWindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
	{
		try {
			switch (message)
			{
			case WM_SIZE:
				switch (wParam)
				{
				case SIZE_MINIMIZED:
					if (!is_auto_reset_)
					{
						return std::nullopt;
					}

					OnApplicationPause();
					break;

				case SIZE_MAXIMIZED:
				case SIZE_RESTORED:
					if (!is_auto_reset_)
					{
						return std::nullopt;
					}

					GetScreenBrightness(minimum_screen_brightness_, system_screen_brightness_, maximum_screen_brightness_);
					HandleSystemScreenBrightnessChanged(system_screen_brightness_);
					if (application_screen_brightness_ == -1)
					{
						HandleApplicationScreenBrightnessChanged(system_screen_brightness_);
					}

					OnApplicationResume();
					break;
				}
				break;

			case WM_DESTROY:
			case WM_CLOSE:
				OnApplicationPause();
				break;

			case WM_ACTIVATEAPP:
				if (!is_auto_reset_)
				{
					return std::nullopt;
				}

				bool is_activate = bool(wParam);
				if (is_activate)
				{
					GetScreenBrightness(minimum_screen_brightness_, system_screen_brightness_, maximum_screen_brightness_);
					HandleSystemScreenBrightnessChanged(system_screen_brightness_);
					if (application_screen_brightness_ == -1)
					{
						HandleApplicationScreenBrightnessChanged(system_screen_brightness_);
					}

					OnApplicationResume();
					break;
				}
				else
				{
					OnApplicationPause();
				}
				break;
			}
		}
		catch (const std::exception& exception)
		{
			std::cout << exception.what() << std::endl;
		}

		// allow another plugin to process message
		return std::nullopt;
	}

@aaassseee
It works very well

@Predidit @chsi020 @vincent-hoodoo @TheLastFlame Thanks for you guys help.

Issue has been solved in version 2.0.1, please download and test again.

Thank you @aaassseee
I just tested version 2.0.1, and the app no longer crashes. Thank you so much for sorting this out for us. Much appreciated.

All good on our side too, thank you for taking the time to fix it.

@chsi020  @vincent-hoodoo You are welcome.


Slow Inference Speed (GPU Mode)

Hi again,
I intend to deploy your model in real time, so I tried to time the inference speed of your model (ENetDepth). I fonud that it took 0.05 - 0.06 s per inference with GPU for image of size (240, 320). Though it is acceptable for real time purpose, but it has a gap to the speed u report. (40Hz) Do you have any idea how I can speed up the model inference?
For the sake of speed analysis, I have uploaded the code in another repo for easier replication: https://github.com/riven314/ENetDepth_Tmp. You can simply run webcam_predict.py to get the average speed result. Below is a sample output of the script:

A bit details about my hardware spec: I am using Lenovo Y740 notebook with GeForce RTX 2070 Max Q.

(apology for the exaggerated issue topic, the model has moderate inference speed in GPU, but it deserves a faster speed i believe)

Just took a quick look at your repo. I'd say the times you report are 2x slower than what they were on my end. Although I'm not super sure why this'd be the case, here's what I can think of:

Latency in calling model.eval() each time?
I'd also assume the pytorch dataloaders are much faster at loading data (as they multiprocess).

It'll be worth timing regular pytorch dataloaders. (If you're doing webcam stuff, probably use the new torchvision loaders that directly transfer images to gpu)

I tried to time the inference speed again, this time:

I added 3 test cases (small image case, medium image case and large image case)
time the GPU inference computation with synchronization
only pass model.eval() once

This time, the speed seems faster than what I recorded last time:

I tried to time it again without (2), (3), the yielded time is similar. I still can't figure out why I got relatively slow speed last time. (anyway)
And surprisingly, I found that the model could give reasonable inference speed even for large image (e.g. 720, 1280, 3 as example).
Now, I am finding place for further speed optimization.


Fixed broken encoding for track param for Stream

By default, requests use the quote_plus() encoding method which breaks Twitter API filtering with track param.
So instead + we need to use %20 encoding for space.

The code you wrote only work for PY3.
The namespace is different for PY2, so six.moves.urllib is safer to use.
If you do want to drop PY2 support with your code as is, be expicit about this like I mentioned above here. The maintainers may not want to drop support just yet and so six is needed, or maybe your approach is fine.
Also, do you think your code will work as intended if you collapse your nested function call into a single call to urllib.parse.quote_plus ?
Some unit test would be good too to capture the intent of converting even if you have to move your logic to a new function so it can be tested alone. Though quote_plus itself will probably have good coverage in its original library

which breaks Twitter API filtering with track param

This shouldn't be the case, and I'm unable to reproduce any issues with spaces in phrases for the track parameter of Stream.filter. Feel free to create a new issue if you have a reproducible example of this breakage.

which breaks Twitter API filtering with track param

This shouldn't be the case, and I'm unable to reproduce any issues with spaces in phrases for the track parameter of Stream.filter. Feel free to create a new issue if you have a reproducible example of this breakage.


msg: remove gencpp and genmsg submodules; remove gencpp imports

Describe problem solved by this pull request
After some verification, I noticed:

We are not using gencpp for anything (!) - there was probably a reason it was added some years ago, but now it's just there, occupying space as an unused dependency and submodule;
If we were using genmsg and gencpp from source because of lack of compatibility with other OS's, after some search I found that we do have genmsg available by pip: https://pypi.org/project/pyros-genmsg/. It just needs to be tested in other platforms, like Windows and MacOS.

Describe your solution
Completely remove the  genmsg and gencpp submodules and all the places where gencpp was being imported (since it wasn't really being used).

Sounds good to me. Goodbye submodules!

For this to build correctly, we are going to need to update the base bionic and xenial containers to install python-genmsg by apt. python3-genmsg is being installed on the ROS2 containers, since is being used by px4_ros_com to generate the micro-RTPS agent code, but I guess to make this compatible with Python 3 as well, and following the developments in https://github.com/PX4/Firmware/pull/12809, the install of python3-genmsg should also be moved to the base containers.

Tested on macOS, built fine after pip3 install --user empy pyros-genmsg.

Tested on macOS, built fine after pip3 install --user empy pyros-genmsg.

Great stuff! Let's make sure we update the containers accordingly! @MaEtUgR can you do something about AppVeyor?

@dagar are you able to update the MacOS side on CI? For now, pip2 install --user empy pyros-genmsg should be enough (as we are still moving to Python3). But you can always install it for both and it stays already solved.

Containers to be updated in https://github.com/PX4/containers/pull/213.

I keep bumping into the same error as in :
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3356: ordinal not in range(128)

@julianoes do you know what might be causing this? I can't reproduce it locally (and I have the same Python version)

We might have to setup these on the base containers. As soon as I get a chance I will test it locally on the containers.

@MaEtUgR is it possible for you to update the Windows CI here for the python genmsg dependency?

Can you improve the error outputs? I'm getting
python import error:  No module named 'genmsg'

Required python packages not installed.

On a Debian/Ubuntu system please run:

  sudo apt-get install python3-empy
  sudo pip3 install catkin_pkg

On MacOS please run:
  sudo pip3 install empy catkin_pkg

On Windows please run:
  easy_install empy catkin_pkg

Whereas pyros-genmsg is needed.

Can you improve the error outputs? I'm getting
python import error:  No module named 'genmsg'

Required python packages not installed.

On a Debian/Ubuntu system please run:

  sudo apt-get install python3-empy
  sudo pip3 install catkin_pkg

On MacOS please run:
  sudo pip3 install empy catkin_pkg

On Windows please run:
  easy_install empy catkin_pkg

Whereas pyros-genmsg is needed.

Yes absolutely.

https://github.com/PX4/containers/pull/214 brings the fix for the decoding issues. Tested locally and on Jenkins. Just needs a container update now.

@dagar with the update to GCC 9 on the containers, it's becoming a nightmare to get this in. Is there a follow-up work after the update?

@MaEtUgR can you please bring pyros-genmsg as well to the Cygwin Toolchain? Thanks!

Looks like a good plan you have with this pr!
I added them to the Windows toolchain here: https://github.com/PX4/windows-toolchain/commit/8f8fbb42052a3718429534a7ee8f2965277dee52
I'll do a new toolcahin version and add it to CI asap.

@MaEtUgR thanks for the toolchain update. The main issue now is with GCC 9.

I need to make sure all dockerhub docker builds are ready and then re-run CI here.

@dogmaphobic this fails on your Mac. Could you please install the pip dependencies for Python3?
pip3 install pyserial empy toml numpy pandas jinja2 pyyaml

Could you please install the pip dependencies for Python3?
pip3 install pyserial empy toml numpy pandas jinja2 pyyaml

Done!

$ pip3 install pyserial empy toml numpy pandas jinja2 pyyaml
Collecting pyserial
Collecting empy
Collecting toml
Collecting numpy
Collecting pandas
Collecting jinja2
Collecting pyyaml
Collecting python-dateutil>=2.6.1
Collecting pytz>=2017.2
Collecting MarkupSafe>=0.23
Requirement already satisfied: six>=1.5 in /usr/local/lib/python3.7/site-packages (from python-dateutil>=2.6.1->pandas) (1.13.0)
Installing collected packages: pyserial, empy, toml, numpy, python-dateutil, pytz, pandas, MarkupSafe, jinja2, pyyaml
Successfully installed MarkupSafe-1.1.1 empy-3.3.4 jinja2-2.10.3 numpy-1.18.0 pandas-0.25.3 pyserial-3.4 python-dateutil-2.8.1 pytz-2019.3 pyyaml-5.2 toml-0.10.0

$ pip3 install empy pyros-genmsg
Requirement already satisfied: empy in /usr/local/lib/python3.7/site-packages (3.3.4)
Collecting pyros-genmsg
  Downloading https://files.pythonhosted.org/packages/37/46/c5e3076ce9480d4002e87268c09270a1db17d3173a7b97fe1501827d27c6/pyros_genmsg-0.5.8-py2.py3-none-any.whl
Installing collected packages: pyros-genmsg
Successfully installed pyros-genmsg-0.5.8

Still failing.
Any clues?

Some dependencies seem wrong because pip2 is overwritten by pip3 in some containers, see: https://github.com/PX4/containers/pull/222

Some dependencies seem wrong because pip2 is overwritten by pip3 in some containers, see: PX4/containers#222

Yeah let's hope that fixes it.

@julianoes with respect to http://ci.px4.io:8080/blue/organizations/jenkins/PX4%2FFirmware/detail/PR-13572/33/pipeline, we need to add a condition in CMake that in the case of building with catkin, it looks for Python 2 instead of 3.

WRT http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-SITL_tests/detail/PR-13572/33/pipeline#step-177-log-165: https://github.com/PX4/containers/pull/233.

@LorenzMeier anything that can be done WRT http://ci.px4.io:8080/blue/organizations/jenkins/PX4_misc%2FFirmware-compile/detail/PR-13572/33/pipeline? Can you do it yourself or someone else with access to these? Thanks!

@julianoes success!! Finally :D

Let's bring this in and update the docs where needed.


ValueError: Could not load model BELLE-2/Belle-whisper-large-v3-zh with any of the following classes:

ValueError: Could not load model BELLE-2/Belle-whisper-large-v3-zh with any of the following classes: (<class 'transformers.models.auto.modeling_auto.AutoModelForCTC'>, <class 'transformers.models.auto.modeling_auto.AutoModelForSpeechSeq2Seq'>, <class 'transformers.models.whisper.modeling_whisper.WhisperForConditionalGeneration'>). See the original errors:
while loading with AutoModelForCTC, an error is thrown:
Traceback (most recent call last):

details of traceback is lost, please give more infos


Make MTRServerAttribute threadsafe.

If two API clients are both touching the same instance of MTRServerAttribute on different threads, we should handle that correctly.

Fast-tracking platform-specific change with platform owner review.


Docs update and warning frozen defined both

Change Summary
This PR addresses an issue where defining frozen both in the @dataclass decorator and config=ConfigDict(frozen=True) led to confusing and inconsistent behavior.
The changes made in this PR aim to clarify the expected behavior and provide better guidance to users.

docs change

    It's not recommended to define both `frozen` in the `dataclass` decorator and `ConfigDict`.
    If both are defined, the setting from the dataclass decorator will take priority.

In the dataclasses.md file, there was no specific explanation about frozen, so I added an explanation about the frozen setting in ConfigDict(config.py).

code change

            # It's not recommended to define both, as the setting from the dataclass decorator will take priority.
            if config_wrapper.frozen:
                warn(
                    "Both 'dataclass' decorator and 'config.frozen' are defined. 'config.frozen' take priority.",
                    UserWarning,
                )

Related issue number
fix #9850
Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review: @sydney-runkle

Hi @sydney-runkle,
Could you please check the PR when it'll be possible!

As @Viicos mentioned, I'd love to see a test (and the stacklevel specification)

I'll go ahead and merge this and add a test in a separate PR


Errors when running on other cuda devices

Hi, I am currently running into an error. The grouped_gemm could perform on tensors on device:0 but fails on device:1. Do you have any idea about this error? Thanks.
Here is one example code.
from grouped_gemm import ops
import torch

num_expert = 15
expert_input_dim = 1000
expert_output_dim = 500

expert_parameters = torch.randn(num_expert, expert_input_dim, expert_output_dim, dtype=torch.bfloat16)
expert_parameters = expert_parameters.to("cuda:1")

input_dim = 1000

input = torch.randn(8235, input_dim, dtype=torch.bfloat16)

selected_expert = torch.tensor([578, 578, 596, 371, 612, 564, 558, 481, 492, 489, 591, 474, 455, 607,
        789])
selected_expert = selected_expert.to(torch.int64)
input = input.to("cuda:1")

output = ops.gmm(input, expert_parameters, selected_expert, False)
print(output)

Hi! Could you share more details about the error you're seeing?

Hi. Thanks for your reply. Here is the error.
Traceback (most recent call last):
  File "/home/yuweia/MoE-Inference/test/group_gemm.py", line 20, in <module>
    output = ops.gmm(input, expert_parameters, selected_expert, False)
  File "/home/anaconda3/envs/yuweia/lib/python3.10/site-packages/grouped_gemm/ops.py", line 33, in gmm
    return GroupedGemm.apply(a, b, batch_sizes, trans_b)
  File "/home/anaconda3/envs/yuweia/lib/python3.10/site-packages/torch/autograd/function.py", line 598, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/anaconda3/envs/yuweia/lib/python3.10/site-packages/grouped_gemm/ops.py", line 11, in forward
    return backend.gmm(a, b, batch_sizes, trans_a=False, trans_b=trans_b)
  File "/home/anaconda3/envs/yuweia/lib/python3.10/site-packages/grouped_gemm/backend.py", line 27, in gmm
    backend.gmm(a, b, c, batch_sizes, trans_a, trans_b)
RuntimeError: CuBLAS Error

It's likely an issue of torch CUDA extension. Try setting the CUDA device ID before running the program.
import torch
torch.cuda.set_device(1)


suggestion: dark mode

Light mode is yikes so you know 😄
Last time I checked crux it used to have dark mode 🤔

yes. we just changed to tailwind + react, so we havent added a darkmode yet


BUG: When stopping a service that doesn't start and other service depend on (pending), when starting other services keep pending

for example: service A , service B depends on A
service A is starting, B is pending
service A fails to start because of  a bug, B is pending
force stop service A, B is pending (Maybe should be stopped now?)
fix the bug, start A
B is still pending..

fixed
now when service is in the factor loop, when the service started successfully the start phase will continue, if the user chose to stop a STARTING service, all other PENDING services will be stopped too
available from v0.0.25


Third

refactoring api client to network client, auth api client, image downloader, api client excreptions, configuration and account api client

looks very good


Next dialogue and default "Objection!" clips fixed

This pull request contains a few small SFX fixes:

The sound effect used when moving to the next dialogue box was different from what is used in-game (see https://youtu.be/XBR35H_ya4g?t=9426). I think the old sound was what would play when switching pages in the Court Record?

Upon looking into some videos of the game online, I think it might use "sfx-bip" in between text where the character is the same, and "sfx-pichoop" when there's a delay between boxes. That being said, "sfx-pichoop" is closer than "sfx-blink".

The default objection sound clip had Payne's voice. The SFX files also contain a version without any voice, which is what the games use when a minor character yells something. I changed the default objection clip to use this instead, and added support for Payne's objection specifically.

This seems fine.
Thanks a lot for it. 💯


add autosens prefs for ratio limits and if targets should be adjusted

I like it.  What testing have you done so far?

I'm running it in production now, and allowing autosens to adjust targets again since it's easy to disable if it becomes a problem.  Only part I haven't seen get triggered is the logging when autosens rate gets limited.

Cool.  Merging.


Swift 6.0.x crash on win/arm64 Release build

Description
A compiler crash (assertion failure) occurs with swift build --configuration release on Windows ARM64.  This is reproducible with Swift 6.0 and 6.0.1. With both Swift versions, the same code compiles without issue in debug configuration, or release on x64.
Summary of observed results:

Swift version
Architecture
Configuration
Result

6.0
arm64
release
💥 crash

6.0
arm64
debug
✅ works

6.0
x64
release
✅ works -- https://github.com/royalapplications/royalvnc/actions/runs/11513028067/job/32049003371#step:7:909

6.0.1
arm64
release
💥 crash

6.0.1
arm64
debug
✅ works

6.0.1
x64
release
✅ works -- https://github.com/royalapplications/royalvnc/actions/runs/11513740438/job/32051009618#step:7:910

Reproduction
Clone the repo and check out the relevant commit:
> git clone https://github.com/royalapplications/royalvnc.git
> cd royalvnc
> git reset aaca28ae04a93615489e3a6ab9f21b6f6bf51086 --hard

Run swift build and observe the debug build succeds:
> swift build
Building for debugging...
[<<< build output elided >>>]
Build complete! (73.07s)

Run swift build --configuration release and observe assertion failure and build crash:
> swift build --configuration release
Building for production...
error: compile command failed due to exception 3 (use -v to see invocation)
error: failed parsing the Swift compiler output: unexpected JSON message: {
  "exception" : 3,
  "kind" : "abnormal-exit",
  "name" : "compile",
  "output" : "Assertion failed: getAlign() && *getAlign() == Align && \"Alignment representation error!\", file C:\\Users\\swift-ci\\jenkins\\workspace\\swift-6.0.0-windows-toolchain-arm64\\llvm-project\\llvm\\lib\\IR\\Globals.cpp, line 140\r\nPlease submit a bug report (https:\/\/swift.org\/contributing\/#reporting-bugs) and include the crash backtrace.\r\nException Code: 0x80000003\r\nAssertion failed: getAlign() && *getAlign() == Align && \"Alignment representation error!\", file Rename failed: C:\\dev\\royalvnc\\.build\\aarch64-unknown-windows-msvc\\release\\RoyalVNCKit.build\\VNCRegion+CG.swift-fb46aa97.o.tmpC:\\Users\\swift-ci\\jenkins\\workspace\\swift-6.0.0-windows- -> toolchain-arm64\\llvm-project\\llvm\\lib\\IR\\Globals.cpp,C:\\dev\\royalvnc\\.build\\aarch64-unknown-windows-msvc\\release\\RoyalVNCKit.build\\VNCRegion+CG.swift.o line 140\r\n: permission denied\r\n",
  "pid" : 3180,
  "process" : {
    "real_pid" : 3180
  }
}: dataCorrupted(Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "kind", intValue: nil)], debugDescription: "invalid kind", underlyingError: nil))

Stack dump
> swift build --configuration release
Building for production...
error: compile command failed due to exception 3 (use -v to see invocation)
error: failed parsing the Swift compiler output: unexpected JSON message: {
  "exception" : 3,
  "kind" : "abnormal-exit",
  "name" : "compile",
  "output" : "Assertion failed: getAlign() && *getAlign() == Align && \"Alignment representation error!\", file C:\\Users\\swift-ci\\jenkins\\workspace\\swift-6.0.0-windows-toolchain-arm64\\llvm-project\\llvm\\lib\\IR\\Globals.cpp, line 140\r\nPlease submit a bug report (https:\/\/swift.org\/contributing\/#reporting-bugs) and include the crash backtrace.\r\nException Code: 0x80000003\r\nAssertion failed: getAlign() && *getAlign() == Align && \"Alignment representation error!\", file Rename failed: C:\\dev\\royalvnc\\.build\\aarch64-unknown-windows-msvc\\release\\RoyalVNCKit.build\\VNCRegion+CG.swift-fb46aa97.o.tmpC:\\Users\\swift-ci\\jenkins\\workspace\\swift-6.0.0-windows- -> toolchain-arm64\\llvm-project\\llvm\\lib\\IR\\Globals.cpp,C:\\dev\\royalvnc\\.build\\aarch64-unknown-windows-msvc\\release\\RoyalVNCKit.build\\VNCRegion+CG.swift.o line 140\r\n: permission denied\r\n",
  "pid" : 3180,
  "process" : {
    "real_pid" : 3180
  }
}: dataCorrupted(Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "kind", intValue: nil)], debugDescription: "invalid kind", underlyingError: nil))

Expected behavior
The assertion failure observed with arm64/release is unexpected. The build should work the same as arm64/debug locally, and x64/release on GitHub CI -- producing a compile error, or completing successfully.
Environment
> swiftc --version
Swift version 6.0.1 (swift-6.0.1-RELEASE)
Target: aarch64-unknown-windows-msvc

> ver
Microsoft Windows [Version 10.0.22621.4317]

Additional information
ref. https://github.com/royalapplications/royalvnc/pull/11#issuecomment-2437042388

Repro steps updated and simplified -- involving only Swift tools.

Tested swiftc 6.0.2 and the issue is still reproducible.

I think this is caused by an MSVC arm64 miscompile issue that I reported here which was reported to MS and fixed here.
The upshot is that Visual Studio 17.9.x and 17.10.x (MSVC 14.39.x and 14.40.x, respecitively) compilers have an arm64 optimization bug and we need to use Visual Studio 17.8.x or earlier or 17.11.x or later to build the Windows/arm64 Swift toolchain to avoid this issue.
It appears that the swift.org CI is currently set up to use VS 17.9.x (MSVC 14.39.x). The latest release 6.0.3 still has the issue, unfortunately.


Cache paths already verified during a munch

I've filed this as a bug because I think it is unintentional, but it could be considered a feature/improvement request as well.
Describe the bug
When performing a munch for items, spells, monsters, thousands of repeat createDirectory calls are made with the same path.
On a local filesystem, this is not that impactful, but when calling forgeCreateDirectory and sending the requests to the Forge API, these thousands of unnecessary requests can negatively impact server performance, cause rate limiting to be applied, and cause the munch to take longer or indeed cause the browser to become unresponsive up as the number of calls stack up but take increasingly long time to respond.
A relatively simple fix for this could be to cache the paths already created and if that path has already been created in this run of the munch, do not call the new folder create again. This can also be specific to the forgeCreateDirectory method.
Something like this, for example
async newFolder(path) {
   if (this._newFolderRequests[path] === undefined) {
     this._newFolderRequests[path] = FilePicker.newFolder(path);
  }
  return this._newFolderRequests[path];
}

To Reproduce

Perform any munch, item munch works better than spell munch to illustrate the point.
Use browser dev tools network tab with filter for new-folder, and see how many calls point to the same path.

Expected behavior

Create new-folder the first time a new path is required, but if that path has already been created in this importer run, it is not necessary to call that endpoint again.

Screenshots

In my case it goes up to around ~4400 for item munches and takes a while. I have heard that monster munches take much longer (I confirmed that when I was patreon subscribed, though I am not currently patreon subscribed to grab a screenshot on the monster munch).
The main problem is that the new-folder requests are all for the same few paths, usually variations on base path ddb-images which already exist and should not need to be created again

Environment:

Browser any, but generally only an issue on Forge (or where a distributed filesystem or server is involved)
Foundry Version [e.g. 10.291]
5e System Version [e.g 2.1.5]
Module Version [e.g 3.4.18]
Does this behaviour occur with other modules disabled: Yes

Additional context
The caching fix could potentially be done for browse calls for specific paths during a munch and their results, to prevent repetitive browse calls to the same path, though this may become memory intensive. It may improve munch times especially on The Forge

I already do substantial caching here, so this might just be from the forge uploader - I'll make an additional tweak which might be causing additional calls for Forge only, so if you can test in the next release and let me know.

I already do substantial caching here, so this might just be from the forge uploader - I'll make an additional tweak which might be causing additional calls for Forge only, so if you can test in the next release and let me know.

Thanks! I'll definitely have a look and test. Just let me know which version it's included in👍

The change is in version 3.4.19, thanks

Awesome, thanks @MrPrimate 👍

I already do substantial caching here, so this might just be from the forge uploader - I'll make an additional tweak which might be causing additional calls for Forge only, so if you can test in the next release and let me know.

Heya 👋
I've had a look at this and can confirm that DirectoryPicker.createDirectory() gets hit in the items.map(async (item) => {...}) before CONFIG.DDBI.KNOWN.CHECKED_DIRS.add(directoryPath); from FileHelper.generateCurrentFiles() is reached.
This happens on local and on Forge, but it's not a problem on a local filesystem because the Foundry FilePicker can handle the many folder creation calls elegantly enough. On a distributed filesystem (like on Forge where the folders are created with an API call to server) it can be problematic and impose rate limiting.
As mentioned above, this happens because the functions getDDBItemImages and getDDBEquipmentIcons functions use:
const itemMap = items.map(async (item) => {...}

This pattern appears in a couple of different places, and it is sensible to use, but the .map() function does not synchronously iterate through the contents of the items array. That means that for each of items, we may reach createDirectory before CONFIG.DDBI.KNOWN.CHECKED_DIRS.add(directoryPath); is reached.
It becomes much more likely when createDirectory makes a network call.
One possible solution here could be to change the .map() function to a for...of loop, iterating through each of the items in series, for example:

It might also be possible to do more than one loop through the items/entities, first loop collecting common paths and ensuring that they exist, and then the second loop creating the items themselves.

Okay, good luck! And thanks for checking out this issue :)


How can I exclude healthcheck url in springboot ?

I saw the similar issue in github. (https://github.com/naver/pinpoint/issues/5942). but I couldn't getthe answer.
I'm using Pinpoint 2.0.1 and spring boot. => collect requests well.
I want to exclude certain url. (ex. healthcheck, actuator)
I set up the configuration as below,but it continues to be collected.
profiler.tomcat.enable=true
profiler.tomcat.conditional.transform=false
profiler.tomcat.excludeurl=/healthcheck, /actuator/**
profiler.springboot.enable=true
Is there anything else I need to set up or check?

@ksh901016
It depends on which spring-boot-starter you use.
If spring-boot-starter-webflux is used, it must be configured in Reactor Netty.
profiler.reactor-netty.server.excludeurl=

I use spring-boot-starter-web. So how do I set it up?
Should I set it differently from the below?
=> profiler.tomcat.excludeurl=/healthcheck, /actuator/**


Use "callable" typehint instead of "\Closure"

Laravel Version: 5.1, 5.2, 5.3, master
PHP Version: 5.6, 7.0, 7.1
Database Driver & Version: n/a

Description:
Real world use-case. I'm building flexible models in Lumen framework, while using Illuminate\Database - and I have a base model, which returns a query builder.
This query builder does some basic mapping between column names in database, and column names in entities, so I wanted to generate the schema from within the model itself:
// SomeMigration.php
use App\Domain\Models;
class MyMigration extends Migration
{
    public function up()
    {
        Schema::create('some_table', [Models\SomeModel::class, 'generateSchema']);
    }
}

// App\Domain\Models\SomeModel.php
namespace App\Domain\Models;
class SomeModel extends Base
{
    /**
     * @param Blueprint $table
     */
    public static function buildSchema(Blueprint $table)
    {
        $table->charset = 'utf8mb4';
        $table->collation = 'utf8mb4_general_ci';

        $table->increments('id');
        $table->integer('number');
        $table->char('code', 4);
        $table->char('type', 1);
        $table->string('full_name');
        $table->timestamps();

        $table->unique(['number']);
        $table->index(['code']);
    }
}

This throws an exception:
  [Symfony\Component\Debug\Exception\FatalThrowableError]
  Type error: Argument 2 passed to Illuminate\Database\Schema\Builder::create() must be
  an instance of Closure, array given, called in
  /var/www/someproject/vendor/illuminate/support/Facades/Facade.php on line 237

Why it doesn't work
It doesn't work. because \Illuminate\Database\Schema\Builder::create expects type of \Closure. However, as of PHP 5.4 you can use typehint callable. So the fix, in this case, would be to fix illuminate/database/Schema/Builder.php, line 140:
    /**
     * Create a new table on the schema.
     *
     * @param  string    $table
     * @param  callable  $callback
     * @return void
     */
    public function create($table, callable $callback) // <-- note the different typehint
    {
        $blueprint = $this->createBlueprint($table);

        $blueprint->create();

        $callback($blueprint);

        $this->build($blueprint);
    }

This will allow the user to submit anything, that is invokable - whereas \Closure requires anonymous function.
see https://secure.php.net/manual/en/functions.anonymous.php

Anonymous functions, also known as closures, allow the creation of functions which have no specified name. They are most useful as the value of callback parameters, but they have many other uses.

Callback is a pre-5.4 pseudo type https://secure.php.net/manual/en/language.pseudo-types.php#language.types.callback
5.4 introduces callable as a correct typehint.
yay or nay?

Refs some previous PRs : #10450, #9565,
and the "current" discussion on internals: https://github.com/laravel/internals/issues/25.

oh, sorry, didn't search :(
closing

Still, good to bring this up.


Not able to extract colors in .h

Hi it is exporting colors in .h file.

@kNeerajPro off topic question, do you remember with which version of Blender you worked with at the time you posted this? (asking this because I can't install the addon with latedt blender 2.72)


TypeError: Cannot read property 'PropTypes' of undefined

This is more of a question than an issue.
I see the problem on line 548 of formatted minified file. I do not have react in my project, do we need react for this widget to work? I also use the preact version of instantsearch.js
I would really appriciate some help.
Another thing that I wanted to point out was you probably want to update the readme to point to https://cdn.jsdelivr.net/instantsearch-googlemaps/1.2.6/instantsearch-googlemaps.min.js intead of the 1 that it points to right now.
Thanks

I see the problem on line 548 of formatted minified file. I do not have react in my project, do we need react for this widget to work? I also use the preact version of instantsearch.js

Ah sorry, that's the issue you cannot use for now instantsearch-googlemaps with the preact build. You need to use the React build.

Thanks, things seem to work with react

Nice!


Miss Emperor of Fire and Iron Boss?

It seems there is an error in the boss data "Emperor of Fire and Iron", in genshin-db the monster is considered a normal monster

ermmmmmmmmmmmm

looks like something in my extractor is mixing up the boss crab with the mob crab xdd

looks like something in my extractor is mixing up the boss crab with the mob crab xdd

XD

published under<EMAIL_ADDRESS>

published under<EMAIL_ADDRESS>
thanks sir


[ACM-5634] build locutus from stolostron/locutus in Dockerfile

Clone locutus project into stolostron, cherry pick fix
build locutus from stolostron/locutus in Dockerfile

/lgtm

Good catch.
/lgtm


Is there a way to download the song I generated?

Could you make a way to download the generated full song? Or the loop??

Although not the original, but on my pseudo-fork you can : https://github.com/jonathanneels/LofiPlayer_3D

Currently we don't have any plan to add the feature in the near future, but I personally use screen recording or stream the browser audio to record.


Feature addition to network benchmark tests

What would you like to be added: I was looking into the network benchmarking tests available under /network/benchmarks/netperf. The tests present there are pretty old and very restrictive in how we study and publish them. Adding new test is not very trivial and there are a lot of conditionals involved. I was thinking of cleaning the way these network tests are written and also add additional output options like json which can be used to save and publish much more information than it do currently.
Why is this needed: This will make the tests more useful, easy to change, and more developer-friendly.

@ritwikranjan I will happy to review a new proposal, a google doc or something similar can work

Sounds great, I will write a proposal and send it here!

Hey @aojea, please find the doc attached, if it looks good I'll start working on a PR.
proposal_perf_tests.docx

I have created a PR for first of a few changes I am planning to do on my fork. Feel free to take a look and suggest changes and improvements.
https://github.com/ritwikranjan/perf-tests/pull/1
I will make all the changes on my fork and open an upstream PR.

Bumping up the thread, Hey @aojea did you had the chance to take a look?

Bumping up the thread, Hey @aojea did you had the chance to take a look at the proposal?

can you put the proposal in a shareable format? google docs, hackcmd or even a PR should be valid,

I have opened a PR with majority of the changes I have put in the proposal and I am going to make the proposal document in an online format as well.


Allow access to patron route for developers

curl https://bibdata-staging.princeton.edu/patron/cac9 available from the devs boxes
Potentially VPN access

If we add VPN access this allows anyone on the university access to all the students and historical students. @kevinreiss we may not want to do this, since it allows anyone in the university access to student information that is not widely available.

closing as wontfix


Add revolution & rotation speed to the CSV

Hi there!
I'd like to thank you first for the great mod! I could plan which system to visit.
However, it'll be nice if we have each of the planets' revolution & rotation speed. Might not be useful essentially, but it's nice to see the variance in the game.
I was on a planet in a black hole system and it rotated at 89 seconds. How the stars in the sky moved so fast amazed me.
Then there's also a 6th planet with 40 thousands seconds of revolution speed. Imagine the length of the summer/winter for your poles.

@araishikeiwai 14 additional parameters are now configurabily enableable in release v3.0.1.

thanks for this! I'll try it tonight


allow cordon and drain only for worker nodes

https://github.com/rancher/rancher/issues/15300

LGTM


open JDK binary source URL does not come up

[kind/bug]

What versions of software are you using?

On OpenShift CI (4.2 cluster)
Uncomment the test - https://github.com/openshift/odo/blob/master/tests/integration/java_test.go#L94 and send the pr
Test failure can be observed in OpenShift CI
NOTE: I am unable to reproduce the failure on my aws cluster. Seems it happens only on OpenShift CI (4.2 cluster)
Actual behavior
app page is not comimg up
Expected behavior
app page should come up
Any logs, error output, etc?

@kadel @girishramnani @cdrage @mik-dass @dharmit @mohammedzee1000 ping

@amitkrout You mean the URL doesn't become ready?

@amitkrout You mean the URL doesn't become ready?

@mik-dass yes

@amitkrout https://github.com/openshift/odo/pull/2045#issuecomment-525610268

@amitkrout #2045 (comment)
If you were not able to reproduce this issue on your AWS cluster, how many average retries were required for the URL to be available. Also did increasing the timeout help?

@mik-dass The number of retries was mostly less than 30.  Increasing timeout could not help in OpenShift CI

@mik-dass The number of retries was mostly less than 30 on my aws cluster. Increasing timeout could not help in OpenShift CI

Locally it worked too under 15 secs

We should probably revert https://github.com/openshift/release/pull/4741 before we figure out what is happening there.

@amitkrout have you tried to debug this to see what the reason for this failure?

Another point is that we shouldn't test just against 4.2, we need to test both 4.1 and 4.2

I probably found the reason for java test failing.
The application jar doesn't support Java 11
The 4.1 java:latest points to java:8
The 4.2 java:latest points to java:11
This makes me wonder how it could ever pass on 4.2! Maybe it got changed only in recent 4.2 builds?

I probably found the reason for java test failing.
The application jar doesn't support Java 11
The 4.1 java:latest points to java:8
The 4.2 java:latest points to java:11
This makes me wonder how it could ever pass on 4.2. Maybe it got changed only in recent 4.2 builds?

@kadel Yup, you are right.
I did the cross verification and hit the issue on my OpenShift 4.2 aws cluster but on 4.1 cluster it went fine.
It's correct that the jar is not supported on java:11. So by passing version with component type should fix the issue then. For example
helper.CmdShouldPass("odo", "create", "java:8", "sb-jar-test", "--project", project ... )

Please share if you have any better idea atm

@amitkrout already opened PR to use java:8 everywhere -  #2059


[CLI] ErrorAndExit deprecated

Towards Issue #6317

ErrorAndExit function is deprecated.  Now every error is propagated instead of exiting directly.

For best practices

How did you test it?

Potential risks

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update http4s-blaze-client, ... to 0.21.25

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-blaze-server
org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.21.24 to 0.21.25.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #116.


Update README to point things to the right repo

Currently the test results and such aren't properly displayed in the README.md

Yeah, thanks!


Implement a Kotlin/Native SQLite driver to replace the SQLiter

Due to the low update frequency of SQLiter, So, I plan to implement a Kotlin/Native SQLite driver by myself and replace the SQLiter.
The driver will be written to the native sourceSet from sqllin-driver. Including Kotlin interop with C language and build a set of APIs similar with Android SDK SQLite API.

It's finished, see the PR#23.


Make visual shader's DefaultTextureParam use Texture instead of Texture2D

Fixes https://github.com/godotengine/godot/issues/93051
There might be other reasons to use Texture2D, feel free to correct me.

CI needs to be fixed, use doctool next time (https://docs.godotengine.org/en/latest/contributing/documentation/updating_the_class_reference.html#updating-class-reference-when-working-on-the-engine). Don't forget to squash the commits after the change.

Well looks like it breaks the compatibility...

It breaks API compatibility which requires updating the API files (see hlthe ci for instructions) but it shouldn't break functional compatibility as it's an argument and takes a more general type so any calls are still safe
You also need to register a compatibility method

Is there any document on how to do this?  I'm a little confused on what to do 😢

There's one in the works!

https://github.com/godotengine/godot-docs/pull/9158

https://github.com/godotengine/godot/pull/95126 supersede this PR

Closed since it's superseded by https://github.com/godotengine/godot/pull/95126


Site TODO List

General TODO list for the frontend. In no particular order:

[ ] Setup tabs on the website [D/F]
[ ] Enable vue locale detection [F]
[ ] Setup multiple routes for the campaigns. [F]
[ ] Get a sample dataset (for schema) of the MP/CM email list and set that up
[ ] Maybe add "phone number" as a first-class field
[ ] "Render" the response template (we have different ones for banks/MPs for now).
[ ] i18n. Not sure how to tackle this best with jekyll.
[ ] Directions for mygov submission (Srikrishna Committee on Data Protection)
[ ] Add google-analytics (maybe with vuejs integration?)
[ ] Grep for TODO in the codebase for more large/small fixes.
[ ] Setup gmail/yahoo in mobile via intents (just copy over code from STI)
[ ] Make send tweet functional using twitter API (halfway done)
[ ] Fix extra commas in email list (trim before split)
[ ] Make the site design responsive [D]
[ ] Add css, maybe add a framework to make it look better? Currently it is running default jekyll stylesheet. [D]

On mobile, a mailto: link will accept several kilobytes of payload. Nothing else is needed. However, Google Inbox truncates the payload when it encounters some characters (as I recall, em dashes), so that needs extra testing.

Need better tweet text

Tested the mailto on mobile, works nicely. Need to check on why bcc didn't work.

I'm worried that if em dashes broke Inbox, maybe local language text will as well. We may need a backup copy-paste flow for mobile.

Current flow:

Mobile

Show 3 links for gmail/yahoo/mailto

Desktop

One button for send email
copy text on click

success: show message to paste body in the mail client and open mail client
failure: show instructions to copy, and then open mail client

I'm trying to detect the user-initiated-copy event so I can open the popup as soon as the user copies the text. Right now it is based on a 2 second timeout.
TODO: Open all mailto links in new tab.

More issues:

Someone has reported that Yes Bank is appearing out of order.
We need drafts reverified against the English version, since we’ve been making amendments.
Show cc emails somewhere for people copy-pasting everything


Filtering keys by property type doesn't narrow the actual property types

TypeScript Version:  3.2.0-dev.20181023

Search Terms:
keyof, filter, type is not assignable to type
Code
type WantedTypes = string | number

type WantedKeys<T> = { [K in keyof T]: T[K] extends WantedTypes ? K : never }[keyof T]

function foo<T> (obj: T, key: WantedKeys<T>): WantedTypes {
    return obj[key]
}

class DerivedProperty<T extends WantedTypes> { }

type Derived<T> = {
    [K in WantedKeys<T>]: DerivedProperty<T[K]>
}

Expected behavior:
Compiles without errors.
Actual behavior:
test.ts:6:5 - error TS2322: Type 'T[{ [K in keyof T]: T[K] extends string | number ? K : never; }[keyof T]]' is not assignable to type 'string | number'.
  Type 'T[{ [K in keyof T]: T[K] extends string | number ? K : never; }[keyof T]]' is not assignable to type 'number'.

6     return obj[key]
      ~~~~~~~~~~~~~~~

test.ts:12:43 - error TS2344: Type 'T[K]' does not satisfy the constraint 'string | number'.
  Type 'T[K]' is not assignable to type 'number'.

12     [K in WantedKeys<T>]: DerivedProperty<T[K]>
                                             ~~~~

I couldn't find any similar issues here.

I don't necessarily know what we could do to keep track of that information. By the time the keys from WantedKeys are produced, we don't have any way to track constraints developed around T[K]. Any ideas for alternative ways to write this @ahejlsberg?

With TypeScript v3.5.1, I want to write:
type PossibleKeys<T, V, K extends keyof T = keyof T> = T[K] extends V ? K : never;

But finally I can only write
type PossibleKeys<T, V, K extends keyof T = keyof T> =
    K extends keyof T
    ? T[K] extends V ? K : never
    : never;

The original example works when written as follows:
type WantedTypes = string | number

type WantedKeys<T> = { [K in keyof T]: T[K] extends WantedTypes ? K : never }[keyof T]

function foo<T extends Record<K, WantedTypes>, K extends WantedKeys<T>>(obj: T, key: K) {
    return obj[key];
}

class DerivedProperty<T extends WantedTypes> { }

type Derived<T extends Record<K, WantedTypes>, K extends WantedKeys<T> = WantedKeys<T>> = {
    [K in WantedKeys<T>]: DerivedProperty<T[K]>
}

The key here is to ensure T is constrained to a type where all properties are of type WantedTypes such that T[K] ends up being constrained to WantedTypes. In order for the original example to work as written we would need K in T[K] to somehow carry a constraint for T which is not an ability we have, nor one I could imagine us implementing.

@gdh1995 That's the intended behavior. The first form is not a distributive conditional type, but the second form is (see #21316 for definition). You could also write it as any one of the following:
K extends K ? T[K] extends V ? K : never : never;
K extends any ? T[K] extends V ? K : never : never;
K extends unknown ? T[K] extends V ? K : never : never;


Authentication with user managed identity fails / hardcoded APIPA ip-address

Describe the bug
I am trying to authenticate with an user managed identity and then subsequently upload some files to an Azure Storage account. However, the login fails due to hardcoded APIPA IP-addresses in the request, it can be seen in the error message
Related command
az login --identity --username $userID --debug
Errors
cli.azure.cli.core.azclierror: MSI endpoint is not responding. Please make sure MSI is configured correctly.
Error detail: MSI: Failed to acquire tokens after 12 times
az_command_data_logger: MSI endpoint is not responding. Please make sure MSI is configured correctly.
Error detail: MSI: Failed to acquire tokens after 12 times
cli.knack.cli: Event: Cli.PostExecute [<function AzCliLogging.deinit_cmd_metadata_logging at 0x000002344B066160>]
Issue script & Debug output
msrestazure.azure_active_directory: MSI: wait: 0.1s and retry: 1
urllib3.connectionpool: Starting new HTTP connection (1): localhost:8888
urllib3.connectionpool: http://localhost:8888 "GET http://<IP_ADDRESS>/metadata/identity/oauth2/token?resource=https%3A%2F%2Fmanagement.core.windows.net%2F&api-version=2018-02-01&msi_res_id=%2Fsubscriptions%2FSubscriptionID%2Fresourcegroups%2FRG-123%2Fproviders%2FMicrosoft.ManagedIdentity%2FuserAssignedIdentities%2FManagedID HTTP/1.1" 504 None
msrestazure.azure_active_directory: MSI: Retrieving a token from http://<IP_ADDRESS>/metadata/identity/oauth2/token, with payload {'resource': 'https://management.core.windows.net/', 'api-version': '2018-02-01', 'msi_res_id': '/subscriptions/SubscriptionID/resourcegroups/RG-123/providers/Microsoft.ManagedIdentity/userAssignedIdentities/ManagedID'}
Expected behavior
Login succesful with an auth token as output
Environment Summary
azure-cli                         2.55.0
core                              2.55.0
telemetry                          1.1.0
Dependencies:
msal                            1.24.0b2
azure-mgmt-resource             23.1.0b2
Python location 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\B046750.azure\cliextensions'
Python (Windows) 3.11.5 (tags/v3.11.5:cce6ba9, Aug 24 2023, 14:38:34) [MSC v.1936 64 bit (AMD64)]
Legal docs and information: aka.ms/AzureCliLegal
Unable to check if your CLI is up-to-date. Check your internet connection.
Additional context
The same issue applies to azcopy login --identity

Thank you for opening this issue, we will look into it.

Which type of resource (VM, App Service, Azure Functions, ...) is this user assigned managed identity assigned to? It is possible this is a unsupported resource. See https://github.com/Azure/azure-cli/issues/25860


Feature/updatestatus endpoint

Problem

Added updatestatus endpoint
Jira Ticket

Solution
Created REST API endpoint with JEST tests.
Change Summary:

f0bef50 - added tests for updatestatus endpoint

Important:

I'm not quite sure how an applicant_id will be passed to this endpoint... will it be just the auth0 numbers or the full auth0|12312312... type string ? Not sure of this incoming data type...
Also not quite sure if these tests are encompassing enough... only tests endpoint behaviors not firestore behavior

Hey Zach, Looks really good! The only change I made was to lift the user_id to the request parameters. The benefit is we don't have to check if the user_Id is sent -- the endpoint won't be called without some value there. Otherwise status codes are good, and control flow seems to cover everything. Good work!


Included TLS 1.3 ciphers in "openssl ciphers -V <crappy_pattern>"

OpenSSL 1.1.1-pre3 (beta) 20 Mar 2018
built on: Fri Mar 23 12:35:22 2018 UTC
platform: linux-x86_64
options:  bn(64,64) md2(char) rc4(16x,int) des(int) idea(int) blowfish(ptr)
compiler: gcc -fPIC -pthread -m64  -Wa,--noexecstack -fsanitize=address -fno-omit-frame-pointer -g -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DDSO_DLFCN -DHAVE_DLFCN_H -DOPENSSL_PIC -DOPENSSL_CPUID_OBJ -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DRC4_ASM -DMD5_ASM -DAES_ASM -DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DX25519_ASM -DPADLOCK_ASM -DPOLY1305_ASM -DZLIB -DNDEBUG -DOPENSSL_USE_BUILD_DATE
OPENSSLDIR: "/etc/ssl"
ENGINESDIR: "/usr//lib64/engines-1.1"
Seeding source: os-specific

apps/openssl ciphers  -V RC2                                                                                master
          0x13,0x02 - TLS_AES_256_GCM_SHA384  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(256) Mac=AEAD
          0x13,0x03 - TLS_CHACHA20_POLY1305_SHA256 TLSv1.3 Kx=any      Au=any  Enc=CHACHA20/POLY1305(256) Mac=AEAD
          0x13,0x01 - TLS_AES_128_GCM_SHA256  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(128) Mac=AEAD

apps/openssl ciphers  -V aNULL                                                                                master
          0x13,0x02 - TLS_AES_256_GCM_SHA384  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(256) Mac=AEAD
          0x13,0x03 - TLS_CHACHA20_POLY1305_SHA256 TLSv1.3 Kx=any      Au=any  Enc=CHACHA20/POLY1305(256) Mac=AEAD
          0x13,0x01 - TLS_AES_128_GCM_SHA256  TLSv1.3 Kx=any      Au=any  Enc=AESGCM(128) Mac=AEAD
          0x00,0xA7 - ADH-AES256-GCM-SHA384   TLSv1.2 Kx=DH       Au=None Enc=AESGCM(256) Mac=AEAD
          0x00,0xA6 - ADH-AES128-GCM-SHA256   TLSv1.2 Kx=DH       Au=None Enc=AESGCM(128) Mac=AEAD
          0x00,0x6D - ADH-AES256-SHA256       TLSv1.2 Kx=DH       Au=None Enc=AES(256)  Mac=SHA256
          0x00,0xC5 - ADH-CAMELLIA256-SHA256  TLSv1.2 Kx=DH       Au=None Enc=Camellia(256) Mac=SHA256
          0x00,0x6C - ADH-AES128-SHA256       TLSv1.2 Kx=DH       Au=None Enc=AES(128)  Mac=SHA256
          0x00,0xBF - ADH-CAMELLIA128-SHA256  TLSv1.2 Kx=DH       Au=None Enc=Camellia(128) Mac=SHA256
          0xC0,0x19 - AECDH-AES256-SHA        TLSv1 Kx=ECDH     Au=None Enc=AES(256)  Mac=SHA1
          0x00,0x3A - ADH-AES256-SHA          SSLv3 Kx=DH       Au=None Enc=AES(256)  Mac=SHA1
          0x00,0x89 - ADH-CAMELLIA256-SHA     SSLv3 Kx=DH       Au=None Enc=Camellia(256) Mac=SHA1
          0xC0,0x18 - AECDH-AES128-SHA        TLSv1 Kx=ECDH     Au=None Enc=AES(128)  Mac=SHA1
          0x00,0x34 - ADH-AES128-SHA          SSLv3 Kx=DH       Au=None Enc=AES(128)  Mac=SHA1
          0x00,0x9B - ADH-SEED-SHA            SSLv3 Kx=DH       Au=None Enc=SEED(128) Mac=SHA1
          0x00,0x46 - ADH-CAMELLIA128-SHA     SSLv3 Kx=DH       Au=None Enc=Camellia(128) Mac=SHA1
          0xC0,0x16 - AECDH-RC4-SHA           TLSv1 Kx=ECDH     Au=None Enc=RC4(128)  Mac=SHA1
          0x00,0x18 - ADH-RC4-MD5             SSLv3 Kx=DH       Au=None Enc=RC4(128)  Mac=MD5
          0xC0,0x17 - AECDH-DES-CBC3-SHA      TLSv1 Kx=ECDH     Au=None Enc=3DES(168) Mac=SHA1
          0x00,0x1B - ADH-DES-CBC3-SHA        SSLv3 Kx=DH       Au=None Enc=3DES(168) Mac=SHA1
          0xC0,0x15 - AECDH-NULL-SHA          TLSv1 Kx=ECDH     Au=None Enc=None      Mac=SHA1

This is correct behaviour. See:
https://github.com/openssl/openssl/blob/master/CHANGES#L16
Also see the description of the cipherlist argument to the ciphers command line app, here:
https://www.openssl.org/docs/man1.1.1/man1/ciphers.html

it breaks programs using the cmdline interface. It's a breaking change I do not see a reason for.
Sent from my mobile. Excuse my brevity&typos+the phone's autocorrection

The problem is that not doing it the current way breaks more. If
you can come up with a good proposal on how to deal with this, we
always want to know.

Am 23. März 2018 19:13:15 MEZ schrieb Kurt Roeckx<EMAIL_ADDRESS>
The problem is that not doing it the current way breaks more. If
you can come up with a good proposal on how to deal with this, we
always want to know.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/openssl/openssl/issues/5736#issuecomment-375755284

okay. In order to answer this and come up with a proposal I need to understand the reason why you're doing this and why it can't be hidden from the user.
As said from the user perspective it breaks programs. Besides the response of the ciphers command looks utterly awkward.
Cheers, Dirk
--
Sent from my mobile. Excuse my brevity&typos+the phone's autocorrection

Have you read this?
https://www.openssl.org/blog/blog/2018/02/08/tlsv1.3/
There are lots of people that set up their cipher list specifying
ciphers, and none of the TLS 1.3 ciphers matches.
The only alternative is not to use TLS 1.3, which we think is even
worse.
I'm also not sure how it broke things for you.
Kurt

See #5359 and #5392 for a discussion on some of the issues. TLSv1.3 ciphersuites do not work like TLSv1.2 and below ciphersuites. All options we have considered for introducing them break something - short of disabling TLSv1.3 by default which we do not want to do. This is the least breaking change we can come up with.


Implement progress bar for package installation process

Implement progress bar for package installation process
Description
This PR adds a visual progress bar to the package installation process, providing users with real-time feedback on the installation status.
Changes

Add visual progress bar to show package installation status
Implement dynamic progress updates based on initial and link phases
Use setInterval for smooth progress animation
Handle 'Link step' detection for accurate phase transition

Additional notes

I have tested this on my machine that runs a wsl2 ubuntu

Please review and let me know if any further changes or information are needed.
Fixes #110

Thank you for the amazing feedback! @rin-st
Made some changes that changes the way things work. Now we "assume" that an install would take 60 seconds and if the install ends sooner, we update faster to load to 100 before we move on.
I agree that magic numbers are not cool but we should choose some numbers here i guess.

Thanks for this Port!
 I saw that before you were checking some stuff in the output (link), but not anymore?
Like if someone has a slow connection (takes 5 minutes to complete)... how would be the bar for them?

Thanks for this Port!
 I saw that before you were checking some stuff in the output (link), but not anymore?
Like if someone has a slow connection (takes 5 minutes to complete) ... how would be the bar for them?

So here is the current logic...
We take 60 seconds as the base, and
-> if the installation takes 60 seconds the user will see an ever-progressing bar till 100%.
-> if the installation takes less than 60 seconds, after yarn install is over, we quickly fill the bar and move on
-> if the installation takes more than 60 seconds, we are stuck at 100% for how long it takes.
Here is what we can do to avoid it:
-> load fast till 50 then little bit slower to 70 and dead slow to 100 and if it ever completes, just load it extremely fast

The problem with showing a real progress bar is the link step in yarn, we don't know how much time it will take for it to complete and as far as I know, there is no way to measure it with confidence

We take 60 seconds as the base, and
-> if the installation takes 60 seconds the user will see an ever-progressing bar till 100%.
-> if the installation takes less than 60 seconds, after yarn install is over, we quickly fill the bar and move on
-> if the installation takes more than 60 seconds, we are stuck at 100% for how long it takes.

makes sense to me, on third point maybe
if the installation takes more that 60 sec, we stuck it at 99% and display a message to user "Seems like its taking longer than usual"?
also created #113 which may go hand in hand with this PR showing realtime logs or maybe be mutually exclusive this. Both have their advantages/disadvantages incase we go with either or,

#111
#113

- output is great but may trick users a bit
- output is not that great but user is able to see logs and whats going on

Umm if plan to go with either one of them lol I kind of lean towards this PR because how its nicely displayed, I am 55% on this 45% on #113

I actually find that a lot better than the progressbar. @technophile-04
But the problem is how are we going to display the progress bar of the link step?
Or should we go and find where yarn is keeping the link cache files and check its length? I feel like that would be over-engineering it.
What do you think about showing the link step progress bar? Or maybe it is okay not to show it


unittest: DartEditor warnings

html_print.dart: still uses string '+' operator
test_case: error and fail have param names that match instance field names, which confuses the editor
SVN bleeding_edge 8755

This issue has been moved to dart-lang/test#140.


[Feature] Avoid manually importing Grafana dashboard JSON file

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
In #1278, we ask users to import the JSON file default_grafana_dashboard.json file from the /tmp/ray/session_latest/metrics/grafana/dashboards/ in the head Pod to Grafana.
Use case
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

cc @alanwguo is there any pointer to create a dashboard in Grafana for a Ray cluster in the Ray dashboard initialization process?


move responsability of reconnect to reflashAsync

For the micro:bit, don't disconnect from DAPlink after flashing -- since it stays alive anyway. This reduces the number of disconnect/reconnect.
The responsibility of reconnect is now moved to the reflashAsync function.
Tested v1/v2.

@abchatra needs integration

ported to stable6.0


Theme support

Inline with how redux-devtools-log-monitor does it (at least redux-devtools-themes).
Not a game-breaker, of course, just a wish.

Done! :)

Awesome, thank you :)


Add ingredient with incompatible units does not print a good error message

also, the RHS of the addition (here, '5') should probably be the combined quantities of the entire set of ingredients, cos right now it only prints for the first (or last -- or something) set. (i had 29 blueberries)


Don't allow reduction in capacity to less than current signups

Originally created by Tom Smyth at 2015-08-19 01:24, migrated from redmine-#2872

Priority changed from 4 to 3

By Tom Smyth at 2015-08-19 07:19

Status changed from New to Closed

By Tom Smyth at 2015-08-29 23:41

Priority changed from 3 to 2

By Tom Smyth at 2015-08-27 18:10


SocketProvider's Realtime Events not working and doubts about authentication token

override func viewDidLoad() {
super.viewDidLoad()
let feathersApp = Feathers(provider: SocketProvider(baseURL: URL(string: "https://my.backend.address")!, configuration: [], timeout: 5))
    feathersApp.authenticate([
        "strategy": "local",
        "email": "bla@blabla",
        "password": "password"
        ])
        .on(failed: {
            failure in
            print("Failed: \(failure.error)")
        }, value: {
            response in
                print("Token: \(response)")

            let userService = feathersApp.service(path: "users")
            userService.on(event: .created)
                .on(value: { entity in
                    print(entity) // Prints the object that was just created
                })
        })
    .start()
}

I launch on my terminal/real device, then I create a new user using postman, new user creates succesfully but my RealTime event trigger on .created for "users" service never get called.
Furthermore, I would ask: what is best practice to check if user did already logged in after I reopen the app on the device? I would avoid to generate a new token every time. The problem is that after authentication, If I properly understood, the JWT access token is backed up by the application for the further sdk methods. So, must I authenticate every time I reopen the app?

@mikegazzaruso I just tested this and I was able to receive real-time events in a sample app I have. Are you sure that your event filters are set to emit events on the server?
Right now there's no mechanism for verifying that a token is still valid. Those are coming in the not-so-far future. The JS client currently has three methods for doing so: getJWT, verifyJWT, and payloadIsValid. I'll be adding those along with a refresh mechanism so if any request gets a 401 it'll automatically attempt to refresh the token then replay the original request but that part is a bit farther off. It'll probably take the form of an internal hook.

Hi, yes... and thus when I create a user, it enters into the function and return data, if I put a console.log(data); the server outputs new created user. But no way for me to get the data back from my swift client.
Could you provide your working code (or an excerpt) please?
Thank you
P.S.: If I query the property supportsRealtimeEvents on my Provider it return true

It could be a number of things, like not retaining a reference to a service/provider/feathers client or some server side configuration. Based on the code you provided, it's likely that userService is going out of scope because you're not retaining it anywhere.

Here's some example code of how services should be used @mikegazzaruso:

struct Providers {
    static let feathersApp = Feathers(provider: SocketProvider(baseURL: URL(string: "https://my.backend.address")!, configuration: [], timeout: 5))
}

public final class ExampleViewController: UIViewController {

    let userService = Providers.feathersApp.service('users')

    public override func viewDidLoad() {
        super.viewDidLoad()
        Providers.feathersApp.authenticate([
        "strategy": "local",
        "email": "bla@blabla",
        "password": "password"
        ])
        .on(failed: {
            failure in
            print("Failed: \(failure.error)")
        }, value: {
            response in
                print("Token: \(response)")
        })
    .start()

    userService.on(event: .created)
        .on(value: { entity in
             print(entity) // Prints the object that was just created
         })
    }
}

Hi, your code and mine are pretty the same (I don't create a struct for my Providers, but simply let feathersApp = = Feathers(provider: SocketProvider(baseURL: URL(string: "https://my.backend.address")!, configuration: [], timeout: 5))
}, no need to make it static due it's simply a test where all happens on a single ViewController, for now, next I'd like to use a Singleton class).
It's weird, how I was telling you, server-side all system go: if I follow examples I get back a feedback on creating new users, using example's listeners

Is it normal this warning? Maybe this directive should be triggered "start()"?
However I understand, it generates a Signal and not a SignalProducer, so I cannot have a start() command on it. Maybe it is advisable to do a
let _ = userService.on.etc.etc. (but the question is: could this have something to do with the issue)
Thanks again

@startupthekid could you please give me assistance on this, ? I'm trying to get out from this but no way... which are features server-side that could cause this? I could paste here my server-side code (also if, as I wrote above, I have no problems with normal JavaScript websocket client)

@startupthekid I made a short video to show you that server-side code should be ok: I created a listener on the server in javascript from another location, and all is ok. But on iOS event never get fired. Maybe being on an iOS emulator is the problem?
Video is here:
http://www.videosprout.com/video?id=f6dc4c57-d44d-4472-a465-e4ad72457ca2

You're not observing any value from the returned Signal.
userService.on(event: .created)
        .observeValues(value: { entity in
             print(entity) // Prints the object that was just created
         })
    }

this is assumed to be an error? Don t understand.. This is just from your example code.. How should I observe?
Thanks

Oh ok I just read.... Sorry I have not read the previous comment... Ok.. But so I think you should update docs with exact syntax.. Right?
Thanks, in the next hours I will try this way

@startupthekid Ok, now it works. But only a little correction:
userService.on(event: .created)
.observeValues({ entity in
print(entity) // Prints the object that was just created
})
(without parameter name "value", only the closure that capture [String:Any] and returns Void)
Now it works like a charm.
Thank you for the support, though I think it would be nice to update your docs... cheers!

Glad I could help! I updated the docs to reflect the correct usage.


SAC log_alpha different from paper

Thanks for the great work on this project! The issue is illustrated in the following line in the SAC trainer:
https://github.com/rail-berkeley/rlkit/blob/master/rlkit/torch/sac/sac.py#L161
In the SAC trainer, it seems as though log_alpha is being trained as though it is alpha, and then an exponentiation is being performed when computing the soft policy & critic losses. Initially I thought that log_alpha was being used for numerical precision reasons, but the loss function for alpha is not modified to work in log space, so it looks like what is happening is log_alpha is really alpha, and then in the soft policy & critic objectives exp(alpha) is being used in place of alpha.
I have not seen any discussion of this choice in the literature. If my understanding is correct, I think this technically breaks the soft-policy iteration and dual-descent theory in the original SAC papers (specifically the follow-up paper that introduced the auto-tuning entropy version of SAC)
It would be great if there could be some clarification as to why this choice was made or, at the very least, a comment/note saying that this deviates from the original (auto-entropy tuning) version of SAC.

This problem has been bothering me for a long time! It doesn't affect the program's operation, but the auto-alpha function doesn't work and degenerates into an alpha=1 effect.


i unable to install live server

If you have a problem launching a live-server, please try following steps:

Make sure you use the right hotkeys. After v2.0.0, the keys became ctrl-alt combination.
Try launching live-server from top menu: Package -> live-server -> Start Server to see if it works.

thanks its help full.


Incorrect path to script & dataset

Step 7. fails as the path to the scripts and datasets is incorrect
cd ~/serverless-spark-workshop/lab-01/
gsutil cp -r cell-tower-anomaly-detection/00-scripts gs://$CODE_AND_DATA_BUCKET/cell-tower-anomaly-detection/00-scripts
gsutil cp -r cell-tower-anomaly-detection/01-datasets gs://$CODE_AND_DATA_BUCKET/cell-tower-anomaly-detection/01-datasets

The paths in the repo seem to be:

cell-tower-anomaly-detection/cell-tower-anomaly-detection/00-scripts
cell-tower-anomaly-detection/cell-tower-anomaly-detection/01-datasets

Fixed.  Thanks @pbavinck for the catch.


Didn't recognize "Hi World"

Challenge write-reusable-javascript-with-functions has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

// Example
function ourReusableFunction() {
  console.log("Heyya, World");
}

ourReusableFunction();

// Only change code below this line
function reusableFunction () {
  console.log("Hi World");
}

reusableFunction();

It would not pass my "Hi World". There was a red X beside this criteria even though it was identical. Again, refreshing fixed it.

@gelbelle Thank you for reporting the issue
Sometimes the tests crash and the page is needed to be refreshed.
Seems that you have solved the issue yourself
Good luck coding


block: Advertise block support for q35

Add block device capability for q35 as this machine type supports it.
This was never added with the introduction of q35 support.
Fixes #771
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

/test

/test

Please fix UT:
--- FAIL: TestQemuAmd64Capabilities (0.00s)
	assertions.go:239:

	Error Trace:	qemu_amd64_test.go:34

	Error:      	Should be false

lgtm

Ping @amshinde - tests still borked :)

The "trace called before context set" messages are probably harmless as those scenarios are being generated by the tests (which doesn't care about tracing).
The last error looks like it might be a real problem though and that is probably what's making the test fail. However, I cannot recreate that last error locally with this branch.

OK - I'll spin the CIs again, and we'll keep an eye on them, and for any other occurrences of that error.

/test

I opened this PR and recalled that our CI used to fail with q35, specifically the devicemapper tests.
I see that the tests are passing now.
@chavafg Wanted to check with you if we still use devicemapper in our CI for crio tests before we actually go ahead and merge this one.

@amshinde the CI does not run using qemu q35. It uses PC, I think that is the reason of the tests passing.
And yes, we are still using devicemapper for our cri-o tests.

I've marked DNM as it's now not clear to me if this should be merged or not - @chavafg @amshinde - pls discuss/decide - and if good to go feel free to drop the DNM and merge...

I'll open a PR in the tests repository to configure kata to use q35 and run using this PR, lets see how it goes.

opened https://github.com/kata-containers/tests/pull/789, tests running using q35.

@amshinde The CI on https://github.com/kata-containers/tests/pull/789 uses q35 and this patch. So it seems everything is working good.
You can see the logs here: http://jenkins.katacontainers.io/job/kata-containers-tests-ubuntu-16-04-PR/559/consoleText

@chavafg Thats great.  Thanks for testing this out.
@grahamwhaley I think we are good to merge this PR now.


[CI] Container failing on start

Description
Logs:
mkdir /home/appuser/.meshery: permission denied

@leecalcote can we close this now?

@leecalcote can we close this now?

Yes, indeed. Thanks for fixing this.

Yes, indeed. Thanks for fixing this.