Downgrade also the download-artifact action

It has to have the same version as upload-artifact.

This is a fix for https://github.com/openssl/openssl/actions/runs/8602356302

given our release timeline, should this be urgent?

given our release timeline, should this be urgent?

Technically this is master branch only thing. So it does not really matter.

This pull request is ready to merge

Merged to the master, 3.3 and 3.2 branches. Thank you for the reviews.


Android: Will never finish "Syncing... 31 private payments left"

This version is installed.
No matter how many times I launch, login, wait, force stop, launch, login, wait, the 31 private payments left indicator never goes away. I managed to get a full backup done (does that cover all wallets in the app or just the active wallet?), so should I just delete all app data & restore from backup, or will that mean the 31 private payments won't be received?
Pretty sure I got all I was due from the Nov 4 airdrop, maybe not.
ETA: Transition Bot shows 2 fresh blackbyte payments, while the indicator endlessly cycles.

I have a similar issue on Android I have lost about 60GBB, 157 private payments left.


String properties > 100 characters fail on ActiveNode 'inspect'

Test case, simple ActiveNode class with String.
File t.rb contains
require 'neo4j'

class T
  include Neo4j::ActiveNode
  property :s, type: String
end

Neo4j::Session.open(:server_db, 'http://localhost:7474')
puts 'environment loaded'

Load irb
$ irb
irb(main):001:0> load 't.rb'
environment loaded
=> true
irb(main):002:0> t = T.new
=> #<T uuid: nil, s: nil>
irb(main):003:0> t.s = '0'*100
=> "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
irb(main):004:0> t
=> #<T uuid: nil, s: "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000">
irb(main):005:0> t.s = '0'*101
=> "00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
irb(main):006:0> t
(Object doesn't support #inspect)
=>

The issue appears to be line 54 in active_node/property.rb
...
attribute_pairs = attributes.except(id_property_name).sort.map do |key, value|
    [key, (value.is_a?(String) && value.size > 100) ? value.dup.first(100) : value]
end
...

'first' is not a method on String.
Maybe the line should read like this?
[key, (value.is_a?(String) && value.size > 100) ? value.dup[0..100] : value]

Thanks for reporting this!  Unfortunately, I'm not able to reproduce...  What version of neo4j are you using?

Thanks for reporting this.  Was discussed on Gitter and we found that the use of first is from Rails.  Changing to [0..100] fixes for non-Rails.  Released as 6.0.6 and 6.1.2


Make RehydrationToken members public

Resolves https://github.com/Azure/azure-sdk-for-net/issues/43260
Then we can remove workaround in
https://github.com/Azure/azure-sdk-for-net/blob/7d04683d350c0908dbc4907444e87a97a207d640/sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs#L100-L112
and
https://github.com/Azure/azure-sdk-for-net/blob/7d04683d350c0908dbc4907444e87a97a207d640/sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs#L225-L226

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Core

I thought the plan was to move the code that needs to access these properties from shared sources to Azure.Core and then make the properties internal. Is that not the case?

Oh, then I have misunderstood the plan, will update this later.


Can't execute gitea.exe on Windows in cmd.exe

Description
>gitea-1.18.0-rc1-windows-4.0-amd64.exe --help
2022/12/07 23:15:28 ...s/setting/setting.go:516:1() [F] Failed to get app path: exec: "gitea.exe": cannot run executable found relative to current directory

From powershell it starts normally.
And it' working as expected in cmd.exe for 1.17.3
>gitea-1.17.3-windows-4.0-amd64.exe --help
NAME:
   Gitea - A painless self-hosted Git service

Gitea Version
1.18-rc1
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
Windows 11
How are you running Gitea?
Official gitea-1.18.0-rc1-windows-4.0-amd64.exe
Database
None

Duplicate of #21943
NOTE: it might have been premature to close the other issue as it just captures a "workaround" not the change in behaviour (or regression...)

but it still runs as windows service as previously.

I wonder if this would fix this?
diff --git a/modules/setting/setting.go b/modules/setting/setting.go
index f0d7f0292..6d99ffa0f 100644
--- a/modules/setting/setting.go
+++ b/modules/setting/setting.go
@@ -6,6 +6,7 @@ package setting

 import (
 	"encoding/base64"
+	"errors"
 	"fmt"
 	"math"
 	"net"
@@ -465,6 +466,13 @@ func getAppPath() (string, error) {
 		appPath, err = exec.LookPath(os.Args[0])
 	}

+	if err != nil {
+		if !errors.Is(err, exec.ErrDot) {
+			return "", err
+		}
+		appPath, err = os.Getwd()
+		appPath = filepath.Join(appPath, os.Args[0])
+	}
 	if err != nil {
 		return "", err
 	}

The trouble is I can't test this because I don't run windows.

The trouble is I can't test this because I don't run windows.

If I can figure out how to cross compile in Gentoo , I can test

make release-windows

ok so it looks like my patch does work!
Right I'll try to clean it up a bit and push it up as a fix.


Stack in cpp

@sauravjaiswalsj can i take this up?

@sauravjaiswalsj  can i work on this?

@sauravjaiswalsj  i have made a pull request #348  in reference to this issue. Kindly verify it.


Can't install go-gtk on Mac OSX Yosemite (10.10.4)

When I try to install it using the command go get github.com/mattn/go-gtk/gtk, I get the following error:
 # github.com/mattn/go-gtk/gdk
 ../../../golang/src/github.com/mattn/go-gtk/gdk/gdk_darwin.go:5:10: fatal error: 'gdk/gdkx.h' file not found
 #include <gdk/gdkx.h>
          ^
 1 error generated.

I've checked and pkg-config is correctly configured (I installed gtk+ with brew):
 $ pkg-config --cflags gdk-2.0
 -D_REENTRANT -I/opt/X11/include/cairo -I/opt/X11/include/pixman-1 -I/opt/X11/include -I/opt/X11/include/freetype2 -I/opt/X11/include/libpng15 -I/opt/X11/include -I/usr/local/Cellar/gtk+/2.24.28_2/include/gtk-2.0 -I/usr/local/Cellar/gtk+/2.24.28_2/lib/gtk-2.0/include -I/usr/local/Cellar/pango/1.36.8_1/include/pango-1.0 -I/usr/local/Cellar/gdk-pixbuf/2.30.8/include/gdk-pixbuf-2.0 -I/usr/local/Cellar/libpng/1.6.17/include/libpng16 -I/usr/local/Cellar/glib/2.44.1/include/glib-2.0 -I/usr/local/Cellar/glib/2.44.1/lib/glib-2.0/include -I/usr/local/opt/gettext/include

and the files that it searches exist (gdk/gdkx.h).
Any suggestions on how to solve this ? Thanks a lot !

could you please show me go get -x github.com/mattn/go-gtk/gtk

Of course, here it is:
WORK=/var/folders/zc/sbpcg8qx7456m579jjjymlj00000gn/T/go-build733179269
mkdir -p $WORK/github.com/mattn/go-gtk/gdk/_obj/
mkdir -p $WORK/github.com/mattn/go-gtk/
cd /Users/achedeuzot/golang/src/github.com/mattn/go-gtk/gdk
pkg-config --cflags gdk-2.0 gthread-2.0
pkg-config --libs gdk-2.0 gthread-2.0
CGO_LDFLAGS="-g" "-O2" "-L/opt/X11/lib" "-L/usr/local/Cellar/gtk+/2.24.28_2/lib" "-L/usr/local/Cellar    /pango/1.36.8_1/lib" "-L/usr/local/Cellar/gdk-pixbuf/2.30.8/lib" "-L/usr/local/Cellar/glib/2.44.1/    lib" "-L/usr/local/opt/gettext/lib" "-lgdk-quartz-2.0" "-lpangocairo-1.0" "-lpango-1.0" "-lcairo" "-    lgdk_pixbuf-2.0" "-lgobject-2.0" "-lgthread-2.0" "-lglib-2.0" "-lintl" /usr/local/Cellar/go/1.4.2/    libexec/pkg/tool/darwin_amd64/cgo -objdir $WORK/github.com/mattn/go-gtk/gdk/_obj/ -- -D_REENTRANT -I/    opt/X11/include/cairo -I/opt/X11/include/pixman-1 -I/opt/X11/include -I/opt/X11/include/freetype2 -I/    opt/X11/include/libpng15 -I/opt/X11/include -I/usr/local/Cellar/gtk+/2.24.28_2/include/gtk-2.0 -I/usr    /local/Cellar/gtk+/2.24.28_2/lib/gtk-2.0/include -I/usr/local/Cellar/pango/1.36.8_1/include/pango-1.    0 -I/usr/local/Cellar/gdk-pixbuf/2.30.8/include/gdk-pixbuf-2.0 -I/usr/local/Cellar/libpng/1.6.17/    include/libpng16 -I/usr/local/Cellar/glib/2.44.1/include/glib-2.0 -I/usr/local/Cellar/glib/2.44.1/lib    /glib-2.0/include -I/usr/local/opt/gettext/include -I $WORK/github.com/mattn/go-gtk/gdk/_obj/ gdk.go     gdk_darwin.go
# github.com/mattn/go-gtk/gdk
../../../golang/src/github.com/mattn/go-gtk/gdk/gdk_darwin.go:5:10: fatal error: 'gdk/gdkx.h' file     not found
#include <gdk/gdkx.h>
         ^
1 error generated.

I got the same error on gdk_darwin.go.

I'm also having this issue and it apparently originates from gtk+ using the quartz backend instead of x11.
gdkx.h is x11's backend header file
gdkquartz.h is quartz's backend header file
not sure if the solution is to add support for quartz or a way to get gtk+ compiled with x11.
I've installed everything via brew, which appears to have dropped all support for x11.

X11 backend is gone (https://github.com/Homebrew/homebrew/pull/39868). GTK+ homebrew formula is quartz only now.

If you have xQuartz installed on your computer, all you need to do is create a symlink to the header files
ln -s /opt/X11/include/X11 /usr/local/include/X11

I have this issue too:
go get -x github.com/mattn/go-gtk/gtk
WORK=/var/folders/kw/zqb4h35d5_5bcwb8b4sd_gc00000gn/T/go-build869683713
mkdir -p $WORK/github.com/mattn/go-gtk/gdk/_obj/
mkdir -p $WORK/github.com/mattn/go-gtk/
cd /Users/username/go/src/github.com/mattn/go-gtk/gdk
pkg-config --cflags gdk-2.0 gthread-2.0
pkg-config --libs gdk-2.0 gthread-2.0
CGO_LDFLAGS="-g" "-O2" "-L/usr/local/Cellar/gtk+/2.24.28_3/lib" "-L/usr/local/Cellar/pango/1.38.1/lib" "-L/usr/local/Cellar/cairo/1.14.4/lib" "-L/usr/local/Cellar/gdk-pixbuf/2.32.1/lib" "-L/usr/local/Cellar/glib/2.46.1_1/lib" "-L/usr/local/opt/gettext/lib" "-lgdk-quartz-2.0" "-lpangocairo-1.0" "-lpango-1.0" "-lcairo" "-lgdk_pixbuf-2.0" "-lgobject-2.0" "-lgthread-2.0" "-lglib-2.0" "-lintl" /usr/local/go/pkg/tool/darwin_amd64/cgo -objdir $WORK/github.com/mattn/go-gtk/gdk/_obj/ -importpath github.com/mattn/go-gtk/gdk -- -D_REENTRANT -I/usr/local/Cellar/gtk+/2.24.28_3/include/gtk-2.0 -I/usr/local/Cellar/gtk+/2.24.28_3/lib/gtk-2.0/include -I/usr/local/Cellar/pango/1.38.1/include/pango-1.0 -I/usr/local/Cellar/harfbuzz/1.0.4/include/harfbuzz -I/usr/local/Cellar/pango/1.38.1/include/pango-1.0 -I/usr/local/Cellar/cairo/1.14.4/include/cairo -I/usr/local/Cellar/pixman/0.32.8/include/pixman-1 -I/usr/local/Cellar/fontconfig/2.11.1/include -I/usr/local/Cellar/freetype/2.5.3_1/include/freetype2 -I/usr/local/Cellar/freetype/2.6_1/include/freetype2 -I/usr/local/Cellar/libpng/1.6.18/include/libpng16 -I/usr/local/Cellar/gdk-pixbuf/2.32.1/include/gdk-pixbuf-2.0 -I/usr/local/Cellar/libpng/1.6.18/include/libpng16 -I/usr/local/Cellar/glib/2.46.1_1/include/glib-2.0 -I/usr/local/Cellar/glib/2.46.1_1/lib/glib-2.0/include -I/usr/local/opt/gettext/include -I $WORK/github.com/mattn/go-gtk/gdk/_obj/ gdk.go gdk_darwin.go
github.com/mattn/go-gtk/gdk
go/src/github.com/mattn/go-gtk/gdk/gdk_darwin.go:7:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
^
1 error generated.

Sorry, I don't have Mac OSX. So anyone please give us hints.

$ pwd
/usr/local/Cellar/gtk+/2.24.28_3/include/gtk-2.0/gdk
$ ls gdk.h
gdk.h
ls gdkx.h
ls: gdkx.h: No such file or directory

#248 fixes this, but it have never been merged.
I recommend people to try https://github.com/gotk3/gotk3

пиздец


DCA retrieves manifest for incorrect project

Describe the bug
When selecting a project, data type template and folder, the app retrieves the dataset manifest for the wrong project.
To Reproduce
Steps to reproduce the behavior:
Select a project, dataset folder, and dataset type in the HTAN production app:

looks like selection is reflected in properly in the UI

however the generated template contains the manifest for the wrong project (TNP SARDANA: HTA13)

Expected behavior
The manifest sheet should have contained the manifest for HTAN Duke's project (i.e. starting with HTA6). Duke's manifest is here and is accurate.
Priority (select one)

[ ] Minor ⬇
[ ] Major 📢
[ x] Critical 🆘

Desktop (if applicable, please complete the following information):

OS: [e.g. Mac OS X]
Browser [e.g. chrome]
Version [e.g. Version 99.0.4844.84 (Official Build) (x86_64)]

Additional context
This is critical bug since it exposes info across projects.

@milen-sage thanks for reporting, looking into it.

Just confirming, it looks like the bug is in on the DCA's end.
schematic retrieves the right project's manifest from the CLI.

@milen-sage Although I didn't figure which changes cause this bug, but using the latest schematic solves the issue. I have updated the prod site and the example ^ now retrieves correct project:

Thanks @rrchai! @rrchai and @adamjtaylor would you mind testing if validation and submission (e.g. using CenterA's project) works as expected? We have been making some changes on the schematic 'develop' branch and just want to make sure things work as expected.
We are moving to a more structured release schedule next sprint, so you won't have to work on bleeding edge code in 'develop'.

I'm not seeing the incorrect manifest issue now in the prod site....  This might be a user error on my behalf so I will try again later. @rrchai let me know if you see similar behaviour?

@adamjtaylor Thanks for catching this bug. There is one flag in the submit function missing in DCA. I just created a pr to fix:

https://github.com/Sage-Bionetworks/data_curator/pull/318

@rrchai I left a comment on #318. It looks like you might need a minor change when passing the manifest_record_type (i.e. pass "both" as record type).
@adamjtaylor We can chat in more detail, but we introduced these options to gradually move away from creating entities for biospecimen and patients.  This change addresses the issues around fileview limits on number of entity folders. With this code being deployed in the DCA now, we're essentially testing if this feature works as expected and we can transition to creating biospecimen and patient tables, while stopping creating entities. It should also resolve the crash you were experiencing earlier, as @rchai noted.

Validating that this now seems fixed. I am able to validate and submit a manifest in a test project.

That is great. Thank you for testing! @adamjtaylor

Thanks everyone! @ychae we might want to follow up on Jira?

@milen-sage sounds good! I see that @adamjtaylor has already updated the folks on Slack and so I'll go ahead and update and close the Jira ticket. @milen-sage please close this ticket if all ACs have been met, thanks!


v1.11 backports 2022-06-29

#19379 -- add support for AKS BYOCNI (@nbusseneau)

Once this PR is merged, you can update the PR labels via:
$ for pr in 19379; do contrib/backporting/set-labels.py $pr done 1.11; done

Closing as per the discussion here.


[NOT AN ISSUE] Does Unity Catalog supports hive-style partitioning?

Is your feature request related to a problem? Please describe.
In the TableInfo model there is no information about partition column. Does UC actually supports partitioning? Is it possible to create a partitioned table via an API?
Describe the solution you would like
A separate field in TableInfo that contains information about partition columns. This field may be empty, of course.
Additional context
.

Hey @SemyonSinchenko, the column info contains optional partition index.

Hey @SemyonSinchenko, the column info contains optional partition index.

How is the partition index of columns corresponding to the partitioning of the table?
When I'm registering a delta table, for example, in Hive metastore, I can specify the partition column:
CREATE TABLE my_table (
)
USING delta
PARTITIONED BY my_partition_column

Is it possible to register a partitioned table in UC?

Yes, it is possible. partitioning index is ordered in the same way the order of partition columns specified the CREATE TABLE.


Update DotnetRuntimeMetadata.json to consume the .NET 8.0.0-preview.3 release

PR Summary
Update DotnetRuntimeMetadata.json to consume the .NET 8.0.0-preview.3 release

The following test consistently fails in CIs. This change has nothing to do with the failure, so I will merge it to unblock the preview release.
Invoke-WebRequest and Invoke-RestMethod support Cancellation through CTRL-C.Invoke-RestMethod: CTRL-C after stalled JSON download processes JSON response


Register the library on pypi

Wait for #25 to be resolved
Put the library on pypi.

Done - https://pypi.org/project/mirdata/


documentation update for dprint (javascript)

Hello,
Here's the recipe to format js files with the new prettier alternative called dprint. Written with rust, it's fast.
install dprint
cargo install dprint

in your project folder, init dprint
dprint --init

update sublime-fmt rule
{
    "rules": [
        {
            "cmd": [
                "$HOME/.cargo/bin/dprint",
                "fmt",
                "--stdin",
                "$file"
         ],
            "selector": "source.js"
        }
    ],
}

Apologies but I totally forgot about these. Will try to get around to it this week.

no problems, I was just trying to cleanup my issues list :) Thank you for  fmt. I have been using it in places where LSP could not reach.
Also, dprint had some nice updates for both markdown, and prettier integrations.  Between fmt and a global dprint config, they will solve majority of sublime's formatting troubles.


Add Cython functionality to directly wrap grpc_arg

Provide a simple way for Cython code to return pointer args set up from Core in wrapped tuple format without the dance to cast to-and-from pointer representation and assign vtable directly.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,654      Total (=)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,775,732      Total (<)     10,775,735

 No significant differences in binary sizes


There is no warning message in the 'Rename Connection' dialog when first opening it

Storage Explorer Version: 1.27.0-dev
Build Number: 20221025.2
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Monterey 12.6 (Apple M1 Pro)
Architecture: ia32/x64
How Found: Ad-hoc testing
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> Tables.
Select one table -> Attach it.
Right click the attached table -> Click the action 'Rename connection...'.
Check whether there is a warning message.

Expected Experience
There is a warning message indicating 'the name should be different'.

Actual Experience
There is no warning message.

Additional Connext
This issue also reproduces for one attached file share.

This is by design. Validation errors are meant to show errors in user input. Please recall that we do not want to show an error message in dialogs until the user has made some kind of input. Therefore, we do not show any errors when the dialog first opens. The error will show if the user modifies the input and changes it back.

@craxal thank you for the updates.
For the clone/rename dialog, there is a warning message showing on the dialog. Do we need to keep them consistent?

@v-xianya Yes, they should be consistent.


Infinite log files

I'm currently experiencing some weird issues.
For one the cpu usage is rather high:

And there are infinite log files open:

I can close them but it won't change anything. Root: Close All won't do anything either.
This problem could 100% be on me as I crashed the application a lot and gave the core.log function some cruel inputs.
I tried removing everything in ~/.config/lite-xl/ws and recompiling lite-xl from source (current master).

Yeah; we should only ever have one log view open. Should be a fairly straightforward fix.

when restarting with Core: restart a new log is always opened

Only allowing one open log file is probably a good idea but I'm not sure if it has much to do with my problem. Are there caches/files or something else that I could try and delete?

Only allowing one open log file is probably a good idea but I'm not sure if it has much to do with my problem. Are there caches/files or something else that I could try and delete?

I don't think there's anything beyond what's in ~/.config/lite-xl. Maybe try nuking the whole folder?

Hmm, this is really a bug we should solve. I will see if I can sort-of-reproduce the problem and find some way to fix it.
There is a problem for sure, sometimes you have an error with a plugin but you cannot see it because there are too many lines in the log saying plugin XY was successfully loaded. You may remove this kind of message from  core/init.lua to see if there is a real error that is triggering all these problems.
Another problem is that the workspace memorize the Log document and will open it again when you start a new session. This is definitely something we can fix.

Perhaps there should be feature that allows you to save the log in a text file. This would make debugging easier and get over the log limit.

I think this was fixed. If I'm wrong, please re-open issue, but I think this was quashed.


⚠ Bofrost.de has degraded performance

In 607ba41, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1325 ms

Resolved: Bofrost.de performance has improved in b7ef725 after 51 minutes.


unauthorized

Hey,
This seems to return unauthorized when calling any of the private endpoints, any idea whats going on?
Thanks

@snub-fighter hi you, would be nice to have an answer/follow-up on this.

@robinsingh-bw can u provide more info.  Example?

@snub-fighter I'm trying to use any bitrue api. I tried also a branch on ccxt and I get this error.
Does the account method work for you, to check your balance? Using curl, I get UNAUTHORIZED.
Using ccxt I get unauthorized. I double checked my api key/secret and it had "Read information (required)" only.
I edited the api key and checked the checkbox for "Trading available". That fixed the "unauthorized".
Wow, what an api, I was thinking that reading permission was enough to actually read my account info... nope, it worked only with trading permission. Mystery solved...

Excellent.  Sounds like a Bitrue issue not the package.
On Sat, Nov 7, 2020, 10:46 AM firepol<EMAIL_ADDRESS>wrote:

@snub-fighter https://github.com/snub-fighter I'm trying to use any
bitrue api. I tried also a branch on ccxt and I get this error.
Does the account method work for you, to check your balance? Using curl, I
get UNAUTHORIZED.
Using ccxt I get unauthorized. I double checked my api key/secret and it
had "Read information (required)" only.
I edited the api key and checked the checkbox for "Trading available".
That fixed the "unauthorized".
Wow, what an api, I was thinking that reading permission was enough to
actually read my account info... nope, it worked only with trading
permission. Mystery solved...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/snub-fighter/python-bitrue/issues/4#issuecomment-723474103,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHTXASQGER2DAAF4JEWYZ3SOWBXFANCNFSM4SIIVQDA
.

Exactly, I informed bitrue, see: https://github.com/Bitrue-exchange/bitrue-official-api-docs/issues/8
I guess you can close this issue ;)

It is a shame.  They dont care about API or trading all that much.  They love their lending platform more.


Transalte to spanish messages

Please read http://developer.android.com/guide/topics/resources/localization.html and update your PR accordingly. Also, there is a typo in the commit summary.

I think thats ok

Looks better. Please fix the remaining issues and squash your commits into one.

Ok, the string name="" is in english ?

Yes, the value of "name" is the key which identifies a translation. It would make little sense to translate this common key.

Ok, already

Okay, now please squash your changes and fix the typo commit message: https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request#squash-your-changes

I have to create branch new ?

No, please read my link, it explains every step.

I don´t understand, You cant help me ?

Just read the article, it is not that hard...


Rewrite tests in py.test

Since nose is abandonware

I will try to do this in the next few days, while i'm not working. 👍 for py.test!


added missed "inactive" risk card

Hi, this PR adds missed "Risiko-Ermittlung nicht möglich" risk card. According to below specification we should show this risk card for automatic mode and .unknownOutdated risk level.
Automatic mode

Manual mode

Screenshot of this risk card

Hmm I don't seem to understand how this can happen and if it does happen if the call to action is the right one.

On the top users sees that Risiko-Ermittlung is a active, but the call for action is "Risiko-Ermittlung einschalten" 🤔

Hmm I don't seem to understand how this can happen and if it does happen if the call to action is the right one.
On the top users sees that Risiko-Ermittlung is a active, but the call for action is "Risiko-Ermittlung einschalten" 🤔

Oh, I think, I'd taken this screenshot with some modifications in the code like this
let riskLevel: RiskLevel? = .unknownOutdated // state.exposureManagerState.enabled ? state.riskLevel : .inactive
in setupRiskConfigurator()
it leads to misleading, I need to delete the screenshot or update it.


feat: allow creation of mock results from UI

Is this adding or improving a feature or fixing a bug?
Adding feature.
What's the new behavior?

Can create new Callback Actions even if no callback is selected.

User must provide custom name to identify action in lists and other training

Can create new Mock Results on Actions from UI

Controls in mock result modal are now editable
Can show errors for missing entities or value mismatches

Adds additional tests to cover new cases

There are likely more complicated error cases about verifying behaviors on entity edits, but given the expected low value/usage it can be added later if needed.

Mind providing some screen shot / video?   Alternatively, maybe you can give Thomas and I demo.  Thanks!

Mind providing some screen shot / video? Alternatively, maybe you can give Thomas and I demo. Thanks!

Hah, yea, that's twice you hit me with the preemptive thanks. I can't tell if it's intentional or habit. I will as long as everyone else also does this for their PR's

Not sure what you mean by preemptive thank?  In any case, an in person demo is probably less work, so let’s go with that.
From: Matt Mazzola<EMAIL_ADDRESS>Sent: Monday, February 3, 2020 9:07 AM
To: microsoft/conversationlearner<EMAIL_ADDRESS>Cc: Lars Liden<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [microsoft/conversationlearner] feat: allow creation of mock results from UI (#35)
Mind providing some screen shot / video? Alternatively, maybe you can give Thomas and I demo. Thanks!
Hah, yea, that's twice you hit me with the preemptive thanks. I can't tell if it's intentional or habit. I will as long as everyone else also does this for their PR's
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fconversationlearner%2Fpull%2F35%3Femail_source%3Dnotifications%26email_token%3DABRZ3ZXNI7HF2DUU72FWAU3RBBFJ7A5CNFSM4KOOKQS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUTZPQ%23issuecomment-581516478&data=02|01|Lars.Liden%40microsoft.com|e1729a19631e4244822a08d7a8cb7174|72f988bf86f141af91ab2d7cd011db47|1|0|637163464046849444&sdata=Ys5shOsEA2C67830eVbcyCty0ctX2scJhFfpRZ5oni4%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABRZ3ZX5WE5MLZG6Z2CJBQLRBBFJ7ANCNFSM4KOOKQSQ&data=02|01|Lars.Liden%40microsoft.com|e1729a19631e4244822a08d7a8cb7174|72f988bf86f141af91ab2d7cd011db47|1|0|637163464046849444&sdata=ykPO6QUC5823qIjAadNEKBfMAWueYYTN8Ig5Ij80KYc%3D&reserved=0.

Image of tests. It includes tests from first PR but should give idea of what feature means.

Demo Video of new features:
https://microsoft.sharepoint.com/:v:/t/convsysresearch/ERZ_HLw8W6BGooY5EG5YnQwBVJ2bePPRFsWMmz4a0zzTOA?e=8TIiil

Thanks for the video.   Super helpful.  Looks good.  A few thoughts / comments:

Is the “- code” after the code-based mock results what you names them or added by the UI?   If added by the UI, I’m not a fan.  I didn’t like you thought about dividing the code and non-code mocks into two sections.  Makes it much more obvious that they are different and why one can be edited.   Wouldn’t take up a lot of screen space
I think defaulting to “clear” when no entity value is provided could be confusing and prone to errors.  Seems like a hidden side effect.  Would recommend that they have to click on the “clear” checkbox. If not, that entry is just ignored
Wondering if we should move the mock results creation below required entities?   (Not sure which is more important or edit more often)
Nice work detecting errors.  Can we bump that up to the edit creator / editor level so you can see that an error exists without opening the mock editing pane?  Even better if we can also bump it up to the entity list page too
In the webchat view, rather than showing “Result” below, I think it might be better to call it “Mock”. Seems clearer to me as you are showing the name of the mock result
The callback card render needs some work.  Thing we could make this look better / make it easier to read (can discuss ideas in person)
In the mock selection dropdown, can we make the “Enter name for callback” a button like we do in the “new entity” case.  Would make the UI more consistent

<EMAIL_ADDRESS>
In the GetMovies example, it would be helpful to show in the action selection UI that the API call doesn’t exist yet (as opposed to other ones where code exists).  Maybe a “mock only” label?

May have marked this in the wrong place.   It’s the last entry in the UI below:
<EMAIL_ADDRESS>From: Matt Mazzola<EMAIL_ADDRESS>Sent: Monday, February 3, 2020 1:16 PM
To: microsoft/conversationlearner<EMAIL_ADDRESS>Cc: Lars Liden<EMAIL_ADDRESS>Review requested<EMAIL_ADDRESS>Subject: Re: [microsoft/conversationlearner] feat: allow creation of mock results from UI (#35)
@mattmazzola commented on this pull request.

In packages/ui/cypress/support/constants.tshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fconversationlearner%2Fpull%2F35%23discussion_r374345028&data=02|01|Lars.Liden%40microsoft.com|a6da821aa83a4a50616208d7a8ee461b|72f988bf86f141af91ab2d7cd011db47|1|0|637163613638760352&sdata=1pzlyIqjr9N5carwBH8%2BMWZyfsK%2FSYJgH17IBJnF7qc%3D&reserved=0:

@@ -20,6 +20,9 @@ export const constants = {

 events: {

     selectWord: 'Test_SelectWord',

 },

strings: {

   customCallbackName: 'Enter name for callback',

I'm not sure what you mean. The key is for whatever option allows giving custom callback names, and the value has to match the actual option name for the tests to select it.
If you wanted a different option name I think that's defined in the action creator modal.
I think those proposed names are misleading. It's not creating a new callback, those can only defined in code. You're creating a new action and giving a temporary name until it's defined. Also don't want to confuse people with the word mock. Mock results is already poor generic name so we want to only use those there.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fconversationlearner%2Fpull%2F35%3Femail_source%3Dnotifications%26email_token%3DABRZ3ZXVJRMIFMSDDS5XZE3RBCCQ7A5CNFSM4KOOKQS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUB4DQA%23discussion_r374345028&data=02|01|Lars.Liden%40microsoft.com|a6da821aa83a4a50616208d7a8ee461b|72f988bf86f141af91ab2d7cd011db47|1|0|637163613638760352&sdata=huSum2eupUMZl9pL7EJiLtxLuEMd7Goim1%2B9Y2qkkz0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABRZ3ZQK63YVKDRENMUUTR3RBCCQ7ANCNFSM4KOOKQSQ&data=02|01|Lars.Liden%40microsoft.com|a6da821aa83a4a50616208d7a8ee461b|72f988bf86f141af91ab2d7cd011db47|1|0|637163613638770309&sdata=e7ElPLCaG89AXyPAUUAflm2%2BV8HdJfYpLqRUcHg9tvs%3D&reserved=0.

Is the “- code” after the code-based mock results what you names them or added by the UI?

Named them for tests clarity. Needs to test different behaviors based on type.

Makes it much more obvious that they are different and why one can be edited.

Are you suggesting to split the lists?

I think defaulting to “clear” when no entity value is provided could be confusing and prone to errors.
Hah, so contradicting.  I thought you were the original one who said make empty string clear it since that's what memory manager does and you wrote that. memory.Set('entityName', '') being a delete is confusing I agree!

So if you add and entity and set it to nothing you want that to be ignored? Seems like a worse problem than assume then meant to remove the value. If they didn't want something to happen to the entity they wouldn't have added it. The clear button is what's weird to me.
Anyways, which do you want

Clear checkbox required to clear and empty values ignored
Work as is where entities set with no values are implicitly cleared.

Wondering if we should move the mock results creation below required entities?   (Not sure which is more important or edit more often)

Nah, mock results are directly related to the callback you choose and only for callback actions. They should be should be co-located and that section with logic and render arguments is dynamic based on type. The below stuff like required entities and options are across all action types.

Nice work detecting errors.  Can we bump that up to the edit creator / editor level so you can see that an error exists without opening the mock editing pane?  Even better if we can also bump it up to the entity list page too.

Yea, probably could. I'm not sure what you mean about entity list page.  I think actions list page would be more helpful if we did it.

In the webchat view, rather than showing “Result” below, I think it might be better to call it “Mock”. Seems clearer to me as you are showing the name of the mock result.

Ok, I don't feel too strongly about this.  There are only two words in "mock result" so think it depends on how you look at it. I chose the second word "result" since it's the outcome or result the score step / action represents and you chose "mock" to put more emphasis on it being fake. Will change it to "Mock"

The callback card render needs some work.  Thing we could make this look better / make it easier to read (can discuss ideas in person)

Yea, I think it needs to at least show the mock result name and the callback name similar to normal callback cards. I'd prefer if they were on separate lines like:
Callback Name: "GetMovies"
Mock Result Name: "5 Movies"

But it was either huge card, with double text entries or I think they strip out new lines within single text entries. Unless you know a way? I tried that and it kept going to single line so they I made it a string.

In the mock selection dropdown, can we make the “Enter name for callback” a button like we do in the “new entity” case.  Would make the UI more consistent

Better question is what are the alternatives? We can't keep putting buttons inside dropdowns. It's not what the control is meant for. The "New Entity" case isn't an Office Fabric control. We made that control. This closest thing is the Add Condition button which already outputs errors in console about invalid markup.

Makes it much more obvious that they are different and why one can be edited.
Are you suggesting to split the lists?

Correct.  One list for code mock, one list of UI Mocks

I think defaulting to “clear” when no entity value is provided could be confusing and prone to errors.
Hah, so contradicting. I thought you were the original one who said make empty string clear it since that's what memory manager does and you wrote that. memory.Set('entityName', '') being a delete is confusing I agree!
Ø  To me there is  difference between code on UI.  In the code you are explicitly saying “Set”.  In the UI you can click to bring up an edit box for that entity.  In some cases if you leave it blank it just ignores it (if there is more than one box for an entity), in other cases is acts as a “clear” action.  This seems inconsistent to me and I’d find that hard to predict
So if you add and entity and set it to nothing you want that to be ignored? Seems like a worse problem than assume then meant to remove the value. If they didn't want something to happen to the entity they wouldn't have added it. The clear button is what's weird to me.
Anyways, which do you want

Clear checkbox required to clear and empty values ignored
Work as is where entities set with no values are implicitly cleared.

I’m suggesting #1

Nice work detecting errors. Can we bump that up to the edit creator / editor level so you can see that an error exists without opening the mock editing pane? Even better if we can also bump it up to the entity list page too.

Yea, probably could. I'm not sure what you mean about entity list page. I think actions list page would be more helpful if we did it.

Yea, action list page.

The callback card render needs some work. Thing we could make this look better / make it easier to read (can discuss ideas in person)

Yea, I think it needs to at least show the mock result name and the callback name similar to normal callback cards. I'd prefer if they were on separate lines like:
Callback Name: "GetMovies"
Mock Result Name: "5 Movies
Ø You can do multi-line.  Check out the placeholder API where it puts each entity on a separate line
Example:
<EMAIL_ADDRESS>But it was either huge card, with double text entries or I think they strip out new lines within single text entries. Unless you know a way? I tried that and it kept going to single line so they I made it a string.

A bit of work but you canalso  create an adaptive card and rending it however you want.  Also<

In the mock selection dropdown, can we make the “Enter name for callback” a button like we do in the “new entity” case. Would make the UI more consistent

Better question is what are the alternatives? We can't keep putting buttons inside dropdowns. It's not what the control is meant for. The "New Entity" case isn't an Office Fabric control. We made that control. This closest thing is the Add Condition button which already outputs errors in console about invalid markup.

Then I’d suggest a button off to the side of the dropdown.


Support PHP 7.1-8.0

Q
A

Bug fix?
yes

New feature?
yes

BC breaks?
no

Deprecations?
no

License
MIT

Drop PHP <7.1
Use hrtime to avoid negative timing when the system clock changes (which can happen quite a lot - my Macbook seems to change the system clock by a few seconds more than once an hour)
Add support for PHP 7.4 and 8.0
Move to GitHub actions for testing

Tests pass: https://github.com/GrahamCampbell/logger-plugin/runs/866077906.

the high resolution time module is not bundled with php according to https://www.php.net/manual/en/hrtime.installation.php

The hrtime function (https://www.php.net/manual/en/function.hrtime.php) is not the same as the hrtime extension (which provides an OOP timing library). The function is a core function added to PHP 7.3. If it is not available (if and only if the PHP version is less than 7.2), we fallback to the symfony polyfill I already required. As far as I'm aware, it is not possible to compile PHP 7.3+ without the hrtime function. :)

great, thanks for the explanation. i somehow assumed the function would be part of the extension - learned something new today :-D

🎉 Thanks for your super speedy reviews. :)

well, thanks for all the work you put into the libraries! :+1:


Syntax error when a function expression with a nonempty body is a default parameter in an arrow function

I'm using JSHint version 2.9.2. The following code is valid es6 that compiles fine with Babel:
// jshint esversion: 6
const foo = (x = function () { return; }) => x;

But JSHint gives this output:
jshint-error.js: line 2, col 46, Expected '(' and instead saw 'x'.
jshint-error.js: line 2, col 47, Expected an identifier and instead saw ';'.
jshint-error.js: line 3, col 1, Unrecoverable syntax error. (100% scanned).

3 errors

Notably, there are no errors if the inner function body is empty:
const foo = (x = function () {}) => x;

Nor if the outer function is a function declaration:
function foo(x = function () {}) {}

Nor even if the outer function is a function expression using the old syntax:
const foo = function(x = function () {}) {};

Thanks for the report, Brian! I've submitted a fix at gh-3003.
In case you're curious: the return statement is a bit of a red herring. The
actual source of the bug is the semicolon token. Weird!

Wow, that was quick. In case you're wondering what kind of a crazy use case I could have for this, it's here, specifically the factorial example, where I first wrote factAcc as a long-form function before I realized that recursive arrow functions are possible in default params.


samples: bluetooth: Increase nRF54H20 stack for hci_ipc

Increase the stack size for hci_ipc on nRF54H20 since the IPC communication increases stack usage.

Wouldn't IPC usage increase stack usage for any board, i.e. why not put this into prj.conf instead since this app is all about IPC?

Wouldn't IPC usage increase stack usage for any board, i.e. why not put this into prj.conf instead since this app is all about IPC?

Actually, 1024 is the default main stack size, so why do you even need this change to begin with? Does the board override the default somewhere and then you need to override the override? Doesn't sound like a very nice solution.
https://github.com/zephyrproject-rtos/zephyr/blob/2f583a8369ef5b67c4438c40d17721d31db952a0/kernel/Kconfig#L156-L160
Requesting changes until we get some clarity on the above

In the prj.conf this sample sets the main stack to 512:
https://github.com/zephyrproject-rtos/zephyr/blob/ab6e59615c63479ba405794e96727b653b6a1b43/samples/bluetooth/hci_ipc/prj.conf#L6
I see no reason to affect the  nrf5340 for this since it seems to work with a reduced stack.

I see no reason to affect the nrf5340 for this since it seems to work with a reduced stack.

"Seems to work" could mean that it's very close to the limit or even slightly over it and you just get lucky that it doesn't trigger a stack overflow panic. I'd advise to at least do some profiling of exactly how much is consumed there. If there's any chance that other platforms (even non-Nordic ones) using hci_ipc might be close to the limits, I think it's safer to update prj.conf than to do this only for one single board.

I see no reason to affect the nrf5340 for this since it seems to work with a reduced stack.

"Seems to work" could mean that it's very close to the limit or even slightly over it and you just get lucky that it doesn't trigger a stack overflow/panic. I'd advise to at least do some profiling of exactly how much is consumed there. If there's any chance that other platforms (even non-Nordic ones) using hci_ipc might be close to the limits, I think it's safer to update prj.conf than to do this only for one single board.

Agreed. It's unclear why this specific board would need additional stack

I see no reason to affect the nrf5340 for this since it seems to work with a reduced stack.

"Seems to work" could mean that it's very close to the limit or even slightly over it and you just get lucky that it doesn't trigger a stack overflow/panic. I'd advise to at least do some profiling of exactly how much is consumed there. If there's any chance that other platforms (even non-Nordic ones) using hci_ipc might be close to the limits, I think it's safer to update prj.conf than to do this only for one single board.

With "seems to work" I meant that there are CI plans which run this sample and pass. I don't work closely with bluetooth, maybe the original author of this stack size can give us a comment here. @kapi-no can you give your opinion about increasing the stack size globally here?
The reason that I made this change is that I enabled in our SDK the IPC communication for this device and I realized that this image cannot run anymore because of stack overflow. So I am afraid that I don't have a very detailed description why this stack increase is needed. @Thalley could you be more specific what type of explanation do you need for increasing the stack?

Is there some reason why we can't just drop all references to MAIN_STACK_SIZE in this app? Then the option would just get the default value from kernel/Kconfig which is 1024 for the boards that you care about.

Is there some reason why we can't just drop all references to MAIN_STACK_SIZE in this app? Then the option would just get the default value from kernel/Kconfig which is 1024 for the boards that you care about.

Maybe there is but I don't know why they reduced the stack size in the first place. I mentioned in my previous message the author of the line which reduces the stack size, hopefully we can get some more information about this.

could you be more specific on what type of explanation do you need for increasing the stack?

Basically, why does the nRF54H20 need more stack than e.g. the nRF5340?
And why 1024? Why not e.g. 768?

I am okay with the stack size increase as long as the Zephyr CI and NCS CI do not expose any RAM overflow issues.

I am okay with the stack size increase as long as the Zephyr CI and NCS CI do not expose any RAM overflow issues.

CI may not catch all RAM overflows: https://github.com/zephyrproject-rtos/zephyr/issues/81044

could you be more specific on what type of explanation do you need for increasing the stack?

Basically, why does the nRF54H20 need more stack than e.g. the nRF5340? And why 1024? Why not e.g. 768?

Unfortunately I cannot provide these details myself. I am not aware of stack profiling reports for the IPC mechanisms and it is not my domain as well. I am a user of IPC, I am not developing/testing it.  So I chose 1024 because it the default in Zephyr and I saw in practice that it passes CI tests.
The reason that this got noticed now is that in our sdk its the first time that IPC is enabled by default and thus some tests failed because of this.

The reason that this got noticed now is that in our sdk its the first time that IPC is enabled by default and thus some tests failed because of this.

But it isn't failing on the nRF5340?
I think it's worth figuring out why, and if there's something that requires additional stack space on the nRF54H20 that shouldn't do that, or if the nRF5340 is also at or near the limit

Closing this as it was decided to handle it in our sdk and not in upstream Zephyr.


Property is never written on inversed side of OneToOne relation properties

Hello,
First of all thank you for all your work, it's great!
We recently upgraded to the latest phpstan/phpstan and phpstan/phpstan-doctrine and we started to have some errors reported on  inversed side of OneToOne relationship properties.
For example, I have two entities:
class Signature {
  // ...

  /**
   * @ORM\OneToOne(targetEntity="App\Entity\Author", inversedBy="signature")
   * @ORM\JoinColumn(onDelete="SET NULL")
   *
   * @var Author|null
   */
  private $author;

  // ...
}

class Author {
  // ...

  /**
   * @ORM\OneToOne(targetEntity="App\Entity\Signature", mappedBy="author")
   *
   * @var Signature|null
   */
  private $signature;

  // ...
}

Both entities have a constructor and they are both non read-only entities.
When I run phpstan I received the error Property App\Entity\Author::$signature is never written, only read. 💡 See: https://phpstan.org/developing-extensions/always-read-written-properties.
Following the rules explained in https://phpstan.org/developing-extensions/always-read-written-properties it's correct that this error is raised but, I was wondering, if this is really a wanted behavior for this particular case.
If it's not, I'd be happy to try to find a fix for it and submit a PR.
phpstan/phpstan version: 1.3.0
phpstan/phpstan-doctrine version: 1.0.2

did you configure the object manager in the phpstan extension?

Yes

I'm seeing the same behaviour here, with a properly configured object manager.

Did anybody find a solution or workaround? I experienced the same with one-to-one relation and properly configured object manager.
Btw, It works fine with $id fields of entities which is never written too. But not with one-to-one

Seeing same issue with self referenced parent - child table.

Hello,
I have the same problem on the inversed side of a one-to-one, it looks not "pouplated" to PhpStan. Below taskcollection and tasklistitem are 1-1, with the foreign key beign set on tasklisitem (so I am going reverse here). PhpStan thinks that the "reverse call" will always return NULL.
$item = $taskCollection->getTaskListItem();
if (!is_null($item)) {

gives
  79     Call to function is_null() with AppBundle\Entity\TaskList\Item will
         always evaluate to false.
         🪪  function.impossibleType


Correction for raw affiliation Dept. Learning and Innovation, Aeres Wageningen Applied University, Netherlands

Correction needed for raw affiliation Dept. Learning and Innovation, Aeres Wageningen Applied University, Netherlands
raw_affiliation_name: Dept. Learning and Innovation, Aeres Wageningen Applied University, Netherlands
new_rors: 03jnx2c74
previous_rors:
works_examples: W4320806745
contact: bc238fcd7eab130b193a3e3025811d42:f5c7c4d2931c345a741e @ hotmail.com

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


[FormControlLabel] Enable disabled label CSS modifications

Move disabled label color definition from root component to the label.
Add labelDisabled CSS API property.
Fixes #10822

@vkentta Having a quick look at the issue, I believe we can remove the disable styles from the FormControlLabel. It seems we don't need it.

@oliviertassinari I think those should be still there. The pointer in enabled state is 'pointer' and having that in the disabled state makes it seem like it's clickable.


Setup should detect if it was successful and issue message to user

Travis CI actually failed a build because ARM-GCC did not download properly, causing the application building portion of the code fail.
This is a critical issue as it could keep students from being able to use SJSU-Dev2 initially.

Resolved as of #624.


Improve input name / data-name functionality

Improvement on #409 to work with latest sir-trevor and add basic docs on usage.
Also improves #352

Thanks for merging, @raffij!

No worries @morpheus-87 . If you still want it for 0.5 then let me know and we can work something out.


build: publish to npm only if needed

Motivation
So far, we've been incrementing the version of all libraries when we publish, even if some of them received no improvements or fixes. I find this approach a bit cumbersome. Since I propose to commit to semantic versioning (#431), a better approach would be most welcomed. That's why this PR introduces a publication script that handles the publishing of libraries only if they were actually modified.
Changes

use shasum to compare local library with npm and publish only upon differences

LGTM, how did you test that it works?

I compared with juno-js.
I get different shasum using ic-js, which is correct as most recent changes are not published, and similar shasum in juno-js because of the contrary.

LGTM, how did you test that it works?

I compared with juno-js.
I get different shasum using ic-js, which is correct as most recent changes are not published, and similar shasum in juno-js because of the contrary.

Thanks!


Pre-release fixes

The key in the links database is a composite of both the link source and the target, so we can catch the same bad link on multiple pages when it occurs at once.
Will continue to add fixes to this branch until it looks like we're catching all the faults, then merge and make a release (0.1.0?)

This commit's check should be the one that has the viable report in it:

https://github.com/kingdonb/link-checker-gpt/pull/9/commits/d295ff6a05779a929735ad8dca23e4e0523d7048

Next step: search and destroy relative links, update everything we can in the 1573 PR until we've handled every exception in the report, and we think it's time to re-run this check, (then we should be able to see it go green! 🏁 ✅ )

Confirmed:
https://github.com/kingdonb/link-checker-gpt/actions/runs/5868433466?pr=9#:~:text=exit code 1.-,Artifacts,-Produced during runtime
The artifact here contains a CSV file, which I imported into Google Drive here:
https://docs.google.com/spreadsheets/d/1FmAZ7aO8gFt0gCMZfYFwEkW8bTXtQw4j8jE-Gs8v24Q/edit?usp=sharing
You can see on line 21 it correctly identifies the source of a bad anchor link, and the link (so you can see where it currently lands based on whatever redirect may already exist)

link_source
bad_target

https://deploy-preview-1573--fluxcd.netlify.app/flux/flux-e2e/
https://deploy-preview-1573--fluxcd.netlify.app/flux/components/image/imagepolicies/#filtertags

(The report is similar to as above, but with a bit more detail)
We can iterate on it until it's presentable enough that users don't have to think about it. Now let's take action on the feedback.

Merging this, so we can investigate and fix more bugs.
All of the changes are in PRs. There is one weird link that shows up in the report that doesn't make sense. Will follow it up after merging this.


calling Remote REPL from Java program fail (probably compiling interpBridge.sc)

I created a case class in Scala that starts a REPL Server and created an instance of this class in a Java program.
(new repl.RemoteREPL(22222)).runREPL();

When I call this program it starts the repl server, but when I open an SSH session on another terminal it immediately terminates with this error Connection to localhost closed.. See detail:
ssh scala@localhost -p 22222
Password authentication
Password:
Compiling (synthetic)/ammonite/predef/interpBridge.sc
Connection to localhost closed.

My Scala code is:
package repl

import ammonite.sshd._
import org.apache.sshd.server.auth.password.PasswordAuthenticator
import org.apache.sshd.server.session.ServerSession

case class RemoteREPL(port: Int = 22222)  {
    object passwordChecker extends PasswordAuthenticator {
      def authenticate(username: String, password: String, session: ServerSession): Boolean = {
        username == "repl" && password == "passwd"
      }
    }

    def runREPL() {
      val replServer = new SshdRepl(
        SshServerConfig(
          address = "localhost", // or "<IP_ADDRESS>" for public-facing shells
          port = this.port, // Any available port
          passwordAuthenticator = Some(passwordChecker) // or publicKeyAuthenticator
        )
      )
      replServer.start()
    }
}

What is going wrong ?

I put scala-depedecies in my pom.xml
<dependency>
  <groupId>org.scala-lang</groupId>
  <artifactId>scala-compiler</artifactId>
  <version>2.11.8</version>
</dependency>
<dependency>
  <groupId>org.scala-lang</groupId>
  <artifactId>scala-library</artifactId>
  <version>2.11.8</version>
</dependency>

but that didn't solve the problem.


Inline suggestions shouldn't appear when moving cursor

This might be a duplicate of https://github.com/microsoft/vscode/issues/146524 , but it appears to be slightly different
https://github.com/microsoft/vscode/blob/4fcd6376131a484046ce91b663ab19249c668ecc/src/vs/editor/contrib/linesOperations/test/browser/moveLinesCommand.test.ts#L384
Version: 1.67.0-insider
Commit: 909602cf04e0fa42528d692676d0d4e15e67bba2

duplicate line up
delete Configuration from the identifier
do arrow right to move to the type
observe that inline suggestions show after doing arrow right, which is unexpected for me
moving to the line below and back again up doesn't show the inline completion, as expected

https://user-images.githubusercontent.com/5047891/161246860-39641ac4-67e1-412c-b659-95654c2c7da2.mp4

Here's a slight variation, where inline suggestions show on double click after a deletion in an unrelated word on the line:

delete Configuration
double click on languageService

https://user-images.githubusercontent.com/5047891/161247433-267f1369-570c-4b2a-8d45-6f1ceaac01d5.mp4

Currently, an inline completion session is started for a single but whole line.
If you edit something in that line, it gets triggered. If you move the cursor in that line, the provider is asked again.
That causes the observed behavior.
Should the inline completion session be canceled on cursor change events?

fyi @bpasero

This was causing unit test failures, so I reverted it via https://github.com/microsoft/vscode/commit/e2b873e1af23a412f85a82998cf7d2a007a82238


_3mux: 0.2.0 -> 1.0.1

Motivation for this change
https://github.com/aaronjanse/3mux/releases/tag/v1.0.1
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

What's the best way to remove the fuzz binary from $OUT/bin? Maybe a simple post-install rm command?

Would you mind adding the following, based on the way gotools removes an unneeded module?
  postPatch = ''
    rm -rf fuzz
  '';

@Mic92 I read through #88258, but I have a question about vendorSha256: is the actual SHA-256 exactly the same as modSha256 (e.g. it's only a rename), or is it generated differently?

@Mic92 I read through #88258, but I have a question about vendorSha256: is the actual SHA-256 exactly the same as modSha256 (e.g. it's only a rename), or is it generated differently?

It is generated differently hence the rename.

@GrahamcOfBorg build _3mux

I think I figured it out: 3mux cross-compiles to darwin if CGO_ENABLED = 1

I don't have a darwin setup to test this on, but other than that, this LGTM

@GrahamcOfBorg build _3mux

meanwhile: this was bumped to 0.3.0

See https://github.com/NixOS/nixpkgs/pull/116272 for an update to v1.1.0. Thank you @Br1ght0ne!


Replace roc-lang.org with WIP site

This PR

Updates www/ bash scripts www/build.sh and www/build-dev-local.sh to replace the roc-lang.org site with the contents of WIP site
Removes generate_tutorial as this is replaced by WIP site
Removes www/public/repl as this is replaced by WIP site
Adds www/content/repl/index.md which generates new web REPL using the same navbar and styles as site
Rename #homepage-repl-container to #repl-container as this is used for web REPLs on / and /repl routes

Closing in preference for a branch on roc-lang/roc


Optional object type attributes are experimental [terraform v1.0.9]

Apply fails with an error when I use this module with tf version 1.0.9:
│ Error: Optional object type attributes are experimental
│
│   on .terraform.xxx/modules/chatbot_slack_workspace/modules/slack_workspace/variables.tf line 12:
│   12: variable "channels_config" {
│
│ This feature is currently an opt-in experiment, subject to change in future
│ releases based on feedback.
│
│ Activate the feature for this module by adding
│ module_variable_optional_attrs to the list of active experiments.

744be50


Executor not starting with custom image

Hi all,
I'm trying to start a simple spark-pi application using custom image with spark 3.3.0. The operator logs showed the spark-pi-driver is running. The driver pod logs showed however no spark-submit command. What could be the problems?
Thank you.
the yaml file:
apiVersion: "sparkoperator.k8s.io/v1beta2"
kind: SparkApplication
metadata:
  name: spark-pi
  namespace: boc
spec:
  type: Scala
  mode: cluster
  image: "registry.cn-shanghai.aliyuncs.com/bmsoncloud/spark-operator-image:3.3.0-2.12"
  imagePullPolicy: Always
  mainClass: org.apache.spark.examples.SparkPi
  mainApplicationFile: "local:///opt/spark/examples/jars/spark-examples_2.12-3.3.0.jar"
  sparkVersion: "3.3.0"
  restartPolicy:
    type: Never
  volumes:
    - name: "test-volume"
      hostPath:
        path: "/tmp"
        type: Directory
  driver:
    cores: 1
    coreLimit: "1200m"
    memory: "512m"
    labels:
      version: 3.1.1
    serviceAccount: spark
    volumeMounts:
      - name: "test-volume"
        mountPath: "/tmp"
  executor:
    cores: 1
    instances: 2
    memory: "256m"
    labels:
      version: 3.1.1
    volumeMounts:
      - name: "test-volume"
        mountPath: "/tmp"

spark-pi-driver log:
++ id -u
+ myuid=0
++ id -g
+ mygid=0
+ set +e
++ getent passwd 0
+ uidentry=root:x:0:0:root:/root:/bin/bash
+ set -e
+ echo 0
+ echo 0
+ echo root:x:0:0:root:/root:/bin/bash
0
0
root:x:0:0:root:/root:/bin/bash
+ [[ -z root:x:0:0:root:/root:/bin/bash ]]
+ exec /usr/bin/tini -s -- /usr/bin/spark-operator driver --properties-file /opt/spark/conf/spark.properties --class org.apache.spark.examples.SparkPi local:///opt/spark/examples/jars/spark-examples_2.12-3.3.0.jar

last few lines of operator logs:
I0721 02:54:27.802016      10 controller.go:837] Update the status of SparkApplication boc/spark-pi from:
{
  "sparkApplicationId": "spark-a19662a073ab4c578a148cc87871b9a4",
  "submissionID": "fed49493-7e5d-4175-ae83-d5176145d119",
  "lastSubmissionAttemptTime": "2022-07-21T02:54:26Z",
  "terminationTime": null,
  "driverInfo": {
    "webUIServiceName": "spark-pi-ui-svc",
    "webUIPort": 4040,
    "webUIAddress": "<IP_ADDRESS>:0",
    "podName": "spark-pi-driver"
  },
  "applicationState": {
    "state": "SUBMITTED"
  },
  "executionAttempts": 1,
  "submissionAttempts": 1
}
to:
{
  "sparkApplicationId": "spark-a19662a073ab4c578a148cc87871b9a4",
  "submissionID": "fed49493-7e5d-4175-ae83-d5176145d119",
  "lastSubmissionAttemptTime": "2022-07-21T02:54:26Z",
  "terminationTime": null,
  "driverInfo": {
    "webUIServiceName": "spark-pi-ui-svc",
    "webUIPort": 4040,
    "webUIAddress": "<IP_ADDRESS>:0",
    "podName": "spark-pi-driver"
  },
  "applicationState": {
    "state": "RUNNING"
  },
  "executionAttempts": 1,
  "submissionAttempts": 1
}
I0721 02:54:27.802070      10 event.go:282] Event(v1.ObjectReference{Kind:"SparkApplication", Namespace:"boc", Name:"spark-pi", UID:"57674684-fe8f-43cb-9d4d-3ad895867670", APIVersion:"sparkoperator.k8s.io/v1beta2", ResourceVersion:"3298672", FieldPath:""}): type: 'Normal' reason: 'SparkDriverRunning' Driver spark-pi-driver is running
I0721 02:54:27.807706      10 metrics.go:112] Incrementing spark_app_running_count with labels map[app_type:Unknown]
I0721 02:54:27.807739      10 controller.go:274] Ending processing key: "boc/spark-pi"
I0721 02:54:27.808213      10 controller.go:227] SparkApplication boc/spark-pi was updated, enqueuing it
I0721 02:54:27.808231      10 controller.go:267] Starting processing key: "boc/spark-pi"
I0721 02:54:27.808273      10 controller.go:274] Ending processing key: "boc/spark-pi"

the spark.properties in the driver pod:
spark.kubernetes.container.image.pullPolicy=Always
spark.driver.port=7078
spark.submit.pyFiles=
spark.kubernetes.resource.type=java
spark.kubernetes.driver.label.sparkoperator.k8s.io/launched-by-spark-operator=true
spark.kubernetes.namespace=boc
spark.app.submitTime=1658372065132
spark.kubernetes.executor.label.sparkoperator.k8s.io/submission-id=fed49493-7e5d-4175-ae83-d5176145d119
spark.kubernetes.driver.label.sparkoperator.k8s.io/submission-id=fed49493-7e5d-4175-ae83-d5176145d119
spark.kubernetes.submitInDriver=true
spark.kubernetes.authenticate.driver.serviceAccountName=spark
spark.kubernetes.driver.pod.name=spark-pi-driver
spark.executor.instances=2
spark.kubernetes.driver.label.sparkoperator.k8s.io/app-name=spark-pi
spark.executor.memory=256m
spark.driver.memory=512m
spark.master=k8s\://https\://<IP_ADDRESS>\:443
spark.driver.cores=1
spark.kubernetes.driver.limit.cores=1200m
spark.kubernetes.driver.label.version=3.1.1
spark.executor.cores=1
spark.kubernetes.submission.waitAppCompletion=false
spark.app.name=spark-pi
spark.submit.deployMode=cluster
spark.driver.host=spark-pi-7785f7821ead878e-driver-svc.boc.svc
spark.driver.blockManager.port=7079
spark.app.id=spark-a19662a073ab4c578a148cc87871b9a4
spark.kubernetes.container.image=registry.cn-shanghai.aliyuncs.com/bmsoncloud/spark-operator-image\:3.3.0-2.12
spark.kubernetes.executor.label.sparkoperator.k8s.io/launched-by-spark-operator=true
spark.kubernetes.memoryOverheadFactor=0.1
spark.kubernetes.executor.label.sparkoperator.k8s.io/app-name=spark-pi
spark.kubernetes.executor.label.version=3.1.1
spark.jars=local\:///opt/spark/examples/jars/spark-examples_2.12-3.3.0.jar

I think this might have nothing to do with custom image cause this seems to happen to other people too:
https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/789

Was facing same issue,
My findings so far, above driver logs shows it is running /usr/bin/spark-operator, which is for spark controller and not for driver pod I guess.
The developer guide https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/docs/developer-guide.md, I guess its for creating spark operator image on our custom spark image and not docker driver/executor image.

If you need to build driver/executor spark image you can refer to this, https://github.com/debugger24/spark-on-k8s-images/blob/main/Dockerfile.spark-3-1-3-python-3-9
I took entryfile script from one of their example spark image gcr.io/spark-operator/spark-py:v3.1.1 and added on top of my spark installation.

For anyone who might be interested, I came across a post which says you should also change the operator image value in this file:
spark-on-k8s-operator/charts/spark-operator-chart/values.yaml.
And it worked. But the post did not explain why.

I am struggling with the exact same thing, anyone come up with a solution?

@LinzeSu what did you change in the values.yaml specifically?

@LinzeSu I installed the operator using helm with the tag image.repository set to my image but since this image repo needs to refer to where to find the operator, it did not install properly. Could you please show me what you did to get your app to run properly?

@karinakanjaria Hi, if you're having exact same issue with me, try change the repository and tag under the image field according to your own configuration. These values will fit in somewhere when you use helm to install the operator. See below.
image:
  # -- Image repository
  repository: change.to.your.own.repository
  # -- Image pull policy
  pullPolicy: IfNotPresent
  # -- if set, override the image tag whose default is the chart appVersion.
  tag: "andYourOwnTag"

Using this. But this is failing with exact same issue.
image:
-- Image repository
repository: ghcr.io/googlecloudplatform/spark-operator
-- Image pull policy
pullPolicy: IfNotPresent
-- if set, override the image tag whose default is the chart appVersion.
tag: v1beta2-1.3.8-3.1.1

In my case the problem was that I specified the operator image in the FROM of the Dockerfile for the driver and executor image (the image you must specify in the sparkapplication.yaml, e.g., spark-pi.yaml). As soon as I switched my driver and executor image to a typical Spark base image (which has nothing to do with the Spark Operator), I got the Spark submit back.


Add Bill Splitting Page

Is your feature request related to a problem? Please describe.
Bill splitting is an essential part of a flat sharing application
Describe the solution you'd like
WIP - we will need to have a meeting to spec this task out.
Potential requirements:

Bills for electricity, internet, Rent etc.
Ability to add bills and split them among flat members
Ability to mark your own bills as paid
Keeping track of how much everyone owes etc

Checklist:

[x] I have double checked that the issue does not currently exist.
[x] I have added the appropriate labels (e.g. feature, front-end, back-end).
[x] I have added the Platform Project project

Moved to a new issue.


chore: slsa 3 provenance generation

Signed-off-by: Batuhan Apaydın<EMAIL_ADDRESS>experimental try out with slsa 3 provenance generation for ko project
cc: @imjasonh @ianlewis

https://github.com/developer-guy/ko/releases/tag/v0.0.0

@laurentsimon possibly superceding https://github.com/google/ko/pull/730 ?

Codecov Report

Merging #753 (98c2c67) into main (9139f45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #753   +/-   ##
=======================================
  Coverage   51.19%   51.19%
=======================================
  Files          44       44
  Lines        3313     3313
=======================================
  Hits         1696     1696
  Misses       1404     1404
  Partials      213      213

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9139f45...98c2c67. Read the comment docs.

We're working on a solution that will help you keep GoReleaser and attach provenance to it, see https://github.com/slsa-framework/slsa-github-generator/tree/main/internal/builders/generic#provenance-with-goreleaser
TL;DR: it will let you build yourself, and the generator will attest to the origin of the repo ("provenance" requirement in SLSA https://slsa.dev/spec/v0.1/requirements). This won't satisfy the "build" requirements of SLSA, but it's still a good improvement.
We'll release this provenance generator this month. Later, when our Go builder has feature parity (or close to) with GoReleaser, we can discuss Go builder :)
Wdut?

Sounds good to me. I'm glad so many folks are looking into improving the SLSAbility of these release workflows, and I'm happy to just ride that wave 🏄

I updated my original https://github.com/google/ko/pull/730 and just realized your PR does the same thing :) We released the generic container today, and it supports uploading the provenance using upload-assets: true.
Let me know if I should drop my PR and let this one go thru, or the other way around.
I'm excited either way :)!

#730 was merged, closing this
Please feel free to reopen this or open a new issue if there's anything else we should do on top of #730


Increase Team

Hi @Chunnyluny,
How are you?
You need help with this mod?
Cheers,
Yuri.

Hi @Chunnyluny,
How are you?
You need help with this mod?
Cheers,
Yuri.

If it is possible yes. It is my first mod . It uses some xml and some c

Hi @Chunnyluny,
How are you?
You need help with this mod?
Cheers,
Yuri.

I'm fine I need some help since this is my first mod. For example the structure is where I get stuck

Sure, I understand. If you'd like, I can help you. Lately, I've been working with some mods for RimWorld/Necesse/Guild 3.
I'm a Database Administrator, and besides SQL, XML is one of my primary languages... Although XML is not a programming language.
Do you have an email, Discord, Telegram, or something similar?

Sure, I understand. If you'd like, I can help you. Lately, I've been working with some mods for RimWorld/Necesse/Guild 3.
I'm a Database Administrator, and besides SQL, XML is one of my primary languages... Although XML is not a programming language.
Do you have an email, Discord, Telegram, or something similar?

Yes I have a discord server which you can join through this link. I have made a channel where the mod project is specially discussed. The link https://discord.gg/uu7pxAHQ to join.


Ability to limit which processes the debugger attaches to in launch.json

I would like a configuration option in launch.json to limit the processes the debugger will attach to when using Debug: Start Debugging.
For example, in a Node.js project my launch config runs a script from package.json which in turn runs another couple of scripts. It is not necessary for the debugger to attach to the three pnpm processes, swc, or nodemon, all of which slow down the launch.
Ideally I would be able to add a filter like the debug.javascript.autoAttachSmartPattern setting, where I would perhaps limit to attaching to "${workspaceFolder}/dist/**".

Duplicates https://github.com/microsoft/vscode-js-debug/issues/1246 🙂


"OR" logic is broken when creating slices

The "|" join is broken when creating new slice.

Only happens when filters are top level, not in a group.


Modpack sorting no longer works

Just updated to <IP_ADDRESS> and modpack sorting is borked. No matter what is chosen it goes back to the default "All" and "Monthly Downloads."

Fixed in dev.


DX: fix UPGRADE.md

This is test issue from https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5099 to see if after passing Travis build the https://cs.symfony.com/download/php-cs-fixer-v2.phar will be 2.16 version.

:+1:
thanks so  much :+1:  @kubawerlos
merged through https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5149
sorry I didn't know/find a better way to keep you the author :(

@SpacePossum no problem, this PR was more to test https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5099 rather than do anything useful ;)


upgrade SurfaceFluxes

bors try

bors try

@charleskawczynski Two EDMF GABLS jobs fail in this PR. They will be fixed by #724. But Anna and I think it doesn't make sense to combine these two PRs. So we are thinking about disabling these two tests in this PR, and adding them back in 724. What do you think?

Sounds good to me

Oh @charleskawczynski, do I need to Increment the reference counter as well if I remove some regression tests?

Oh @charleskawczynski, do I need to Increment the reference counter as well if I remove some regression tests?

Yeah, or, I think, you could remove the entries from the mse table

bors r+


No Saradomin Sword?

Was trying to replace Voidwaker spec animation to the regular Sara Sword spec animation since its the closest of the rs2 animation, but I don't see the sword anywhere in the list?

I never added the spec. I've never owned a saradomin sword. Although for the rest of the animations, I think they are the same as the godswords.
I can add it. although I don't have anything set up to add the lightning gfx atm.

Yeah, its just the spec that have its unique animation. Well, take your time, I was just wondering, but yeah, would be great!
The lightning + sound effect is almost identical to the old korasi spec if I remember correctly.

I never added the spec. I've never owned a saradomin sword. Although for the rest of the animations, I think they are the same as the godswords.
I can add it. although I don't have anything set up to add the lightning gfx atm.

is it not possible to show the current weapon being held instead of the sara sword on the spec? also when you spec while moving the legs do not move, which I assume its animation layered and missing the bottom part animation?

Oh, I didn't notice that it had the weapon hardcoded into the animation. That does suck, but that's just how some animations are.
Runelite doesn't have anything to easily deal with it. I could ask if adam could add API for it but he seems pretty busy.


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter sonoff for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.sonoff
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E254] Version "3.2.0" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.

WARNINGS:

[ ] :eyes: [W252] Version of package.json (3.2.0) doesn't match latest version on NPM (3.1.2)
[ ] :eyes: [W529] Plugin "manual-review" missing at .releaseconfig.json. Please add.

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #401
@mcm1957 for evidence
Last update at Sun, 06 Oct 2024 21:25:36 GMT based on commit 28d63c63f5ee79d5b18868342b52702a5bd14d22
ioBroker.repochecker 3.1.2

@iobroker-bot recreate


Add timeout for SPDM message

Fix: #272
Signed-off-by: Qi Zhang<EMAIL_ADDRESS>

Hi @steven-bellock , what do you think about sleep_lib?

Hi @steven-bellock , what do you think about sleep_lib?

Ah sorry. I did not see that it had been updated. I'll have a look today.

@qizhangz @jyao1 @jcahill0 I think we should produce a rough design before coding can begin. In particular how the asynchronous wait case would be handled and how all this would be tested.

I will reconsider the implementation as all comments. So I close this PR and will submit a new PR for the new implementation.
Thank you!


Convert "Fixture Builder" README to sphinx documentation.

What is wrong?
The file at eth/tools/fixture_builder/README.md provides instructions for how to use the fixture_builder tools to write state tests.  This is both not easy to find and not the easiest to read docs.
How can it be fixed
Convert these to be docs in the formal sphinx based docs.

Done in #1219


remove duplicate angular interceptor. Fixes #1096

This PR fixes #1096 and is a step forward towards fixing the issues related with 401/403 status code responses not being handled properly by the client. Consider reading @mleanos post that summarizes the situation.

LGTM.

Thanks!
@pgrodrigues please re-base in order to maintain 1 commit and update the commit message to a format according to our guidelines: https://github.com/meanjs/mean/blob/master/CONTRIBUTING.md#commit-message-guidelines

I'll close this for now and make a new pull request.


clipboard manager protocol

Is there interest in supporting a clipboard manager protocol?
The clipboard manager would be an out of process application that gets an api for clipboard contents. Primarily hooks for clipboard selection change it can use to change the contents of a copy/paste.
The clipboard manager can use this to:

store history of clipboard contents
offer an interface to get/set the contents of the clipboard (like xclip or xsel).
show a tray icon where the user can select clipboard contents from history
multiple clipboard selections handled by the manager

For more on what a clipboard manager can do, see this list of clipboard managers.

Yes, I think we should do this at some point.

Is the current behaviour the same as in i3, that when an application is closed anything copied from that program is lost?

Yes.

Just a wild idea, password managers could probably use the input method protocol in the long run. And just input the password directly (gui or cli manager shouldn't matter much I think).

Closing because this has moved to wlr-protocols: https://github.com/swaywm/wlr-protocols/issues/20


Discussion: When to do checks of user inputs?

Describe the feature and the current behavior/state.
Currently, we don't have a policy specifying when to do checks on numerical values (user input checks). Sometimes, it's done in eager mode only, sometimes in eager and graph mode...
For example: https://github.com/tensorflow/addons/pull/1338#discussion_r398463749
To have maximum speed, it would be better if the checks are not running, but we need a way of debugging too. But eager mode is not a garantee of debug mode. Some people us eager mode for flexibility because they can't use graph mode.
To have a strong policy would allow us to do very expensive checks and would improve the UX by allowing users to have checks on their numerical values if they want to do a dry run.
I propose the we do the following:
if tf.executing_eagerly() and __debug__:
    # do very expensive checks of user inputs here, like comparing values, raising exceptions and such.

the __debug__ directive is True by default in python (yes it's strange). If python is run in optimized mode with python -O, the __debug__ variable is set to False.
In the end, user have several choices:

graph mode and maximal performance.
eager mode and maximal performance: python -O my_script.py
eager mode and debug mode to monitor strange values: python my_script.py.

Of course this doesn't concern checks of user inputs done in __init__ functions because those parts are never critial for performance.
Relevant information

Are you willing to contribute it (yes/no): yes
Are you willing to maintain it going forward? (yes/no): yes
Is there a relevant academic paper? (if so, where): no
Is there already an implementation in another framework? (if so, where): not that I'm aware of. If people know other libraries doing similar things, I'd like to know about it.
Was it part of tf.contrib? (if so, where): no

Which API type would this fall under (layer, metric, optimizer, etc.)
All APIs
Who will benefit with this feature?
Users as they would benefits from many checks while having maximal performance in graph mode as all checks would have been removed.
Any other info.

It sounds good.

I don't know if we could or it is safe enough to check only sys.gettrace to see if we are really under a debugger and to enable only the checks in that case.
It seems to me not so much UX friendly to require to use python -O my_script.py for having performance in eager_mode if we want to be eager friendly by default.
I have not read many other docs about explicit -O in other libraries so my point is just related to the user experience point of view and habits.

I have not read many other docs about explicit -O in other libraries

Because it's not possible to turn off runtime checks in most libraries. So we're already better than most in this regard. Furthermore, many people debug by using prints (not that it's a good practice), but we need to support this use case, it's not possible with sys.gettrace. -O turns off assert statements too so it's been made precisely for this use case.
From the zen of Python:

Errors should never pass silently.
Unless explicitly silenced.

Eager mode is completely aligned with Python here.

I could agree with you if we want to use print debugging. I think in that case the alternative could be to use some processor.
At UX level the backward interpretation was not so friendly also for other users. See comment on the upvoted reply at https://stackoverflow.com/questions/482014/how-would-you-do-the-equivalent-of-preprocessor-directives-in-python.

Errors should never pass silently.
Unless explicitly silenced.

Ok but I think that we are not adopting this philosophy cause we tell to the the user:

The error should pass silently if you are in graph mode
The error should not pass silently if you are in eager mode

Also could we have any significant side effect in Autograph loop with -0?

Note: If debug is True, AutoGraph limits the number of iterations in normal Python loops to prevent infinite loops and raise an error if the limits are exceeded. However, the iteration limits are very large and may take a while to trigger an error.

Sorry for not reacting to this issue earlier.

we don't have a policy specifying when to do checks on numerical values (user input checks)

Can you clarify what you mean by "checks on numerical values" exactly? I would assume that most if not all input checks are related to checking the input shape.

To have maximum speed, it would be better if the checks are not running

This is true but when we talk about shape checks, they are an order of magnitude faster than the actual layer runtime. So I'm not sure performance is a concern here.

I would agree with @bhack that the mismatch between eager and graph mode would be confusing, if not error-prone. As a library, I think we should treat both modes the same way.
For example, I know that the error checking in the seq2seq module is a bit old-style but it is consistent in all modes:

use Python to check static values (e.g. static depth dimension, tensor rank)
use TensorFlow asserts to check dynamic values (e.g. batch size)

I believe we should support other types of error checks to be able to provide a better user experience. For example:

Inputs are in the expected range, for example for functions expecting images between 0 and 255 or between 0 an 1.
In functions like resampler ops or cutout where one tensor contains the indices of another tensor, we could check all indices are in the expected range.
The sum of all inputs is 1 for losses that expect predictions, or even all predictions are between 0 and 1.
In hamming_distance, we could checks all values are either 0 or 1.

Those should help greatly when a user wants to debug a neural network that doesn't work as expected. Shape checks are helping, but the most painful bugs in neural networks are when the values are not in the expected range, precisely because the errors are silent. We could provide a lot of value if we help the user detect those.
I believe that the checks are light right now, so mostly shape checking, because we couldn't turn them off, so we couldn't afford more expensive ones.

So the policy you are describing in this issue is only for the checking the actual input values and not the shapes?

Good question. When I made the issue, I didn't think about what checks were negligable in running time, I had more in mind that we should have a mode where we have maximal performance, where we drop all checks. Making a check technically stops the flow of computation, so I though it was expensive. That may not be the case for shapes.
Overall, if we can unify the way we do checks, that's better though. Do you think we should discern by category of check?

So Is It not better to handle these with a classical loglevels approach?

Do you think we should discern by category of check?

I think shape checks should always run and work in both eager and graph mode.
On the other hand, it sounds reasonable to only run numerical checks in a eager debug mode. But it should probably be disabled by default, what do you think? It could be enabled with a global function such as tfa.enable_numerical_checks.

But it should probably be disabled by default, what do you think?

It's a hard decision.
If it's disabled by default in eager mode, it's likely that a very small subset of our userbase will know about it. Most users just google whatever layer/metric/loss they're looking for and grab it from tensorflow addons. They don't look at the readme because they don't need to. So most of them will never activate it, even when debugging their model.
If we enable it by default in eager mode, it's good for a very big userbase, the one who uses model.fit (graph mode by default here) and run eagerly to debug only. But it's bad for the users running in full eager. It would seems weird though because there is very little penalty for users to run Addons' stuff in graph mode. Why would they need eager mode inside our functions except for debugging?
Overall, it's a good point that we don't want the users running everything in eager mode to get a silent drop in performance.
What we could do, is to use the method we used when loading custom ops. We throw a warning the first time. It would look like this.

def some_addons_function():

    if __debug__ and tf.executing_eagerly():
        tfa.utils.warn_numerical_checks()
        # do expensive checks here

# in utils.py
already_warned = False
def warn_numerical_checks():
    global already_warned
    if not already_warned:
         warnings.warn("Numerical tests are running because you are using eager mode."
                       "it impacts performance negatively but helps you debug your model "
                     " by checking that values are in the expected range and such and will throw an"
                     " error if something happens. For example it can check that the sum of a prediction "
                     " tensor is 1 all the time, with all values between 0 and 1. If such a condition is not "
                     "respected, an exception will be raised to help you debug what's wrong. "
                    " you can turn it off by either running tensorflow addons functions in graph mode "
                    " or running python in optimized mode `python -O my_file.py`")
       already_warned = True

So a good compromise would be enabled by default for eager mode + warning the first time a numerical check is performed. Do you think it's a good idea?

IMHO I prefer to have an API call with an env to pilot this like[1] cause I still think that the big user base at the more or less entry level and that don't read the documentation has no habit to use -0.
Then we could talk about what is the best default behavior in eager mode.
[1]https://github.com/tensorflow/tensorflow/blob/v2.2.0/tensorflow/python/autograph/utils/ag_logging.py#L40-L88

Also I want to open a new point in the discussion. How many numerical checks we have in the main library?
Cause I suppose that users will expect to have a quite consistent experience in the whole library (TF + addons).
If you start to expect to be "safe" with extra-guards in addons at some point you could expect to have this "feature"  available also in the whole library cause APIs are regular mixed in real use cases.
I understand that probably this point is more marginal that the other ones but library consistency of  has its own weight in the user experience.

So a good compromise would be enabled by default for eager mode + warning the first time a numerical check is performed. Do you think it's a good idea?

It seems reasonable to think that eager mode is mostly used for development where performance is not critical. Overall I don't have a strong opinion here as long as the condition is isolated in a function so that it can easily be changed if required.

TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


2024 Book Dash Planning

Report of 2023
First meeting with Book Dash Working group to review dates and committee members
Plan dates for May 2024
Plan dates for Nov 2024

Adding notes from 1:1 (16 January)

Review possible memberships/invitations for the working group (strategic)
Choose chair for the WG
Discuss planning committee (as opposed to working group)

Book Dash Working group and repo: done
Planning committee application hub: done
Local hub form: done

To be done:

Book Dash timeline  (AAA)
Define November dates
Book updates

@estherplomp


Integration with Micropython

I've got one of these hooked up to an ESP32 and I'll be trying to get this driver working in Micropython.  Any insight by someone who's done something similar would be appreciated.

Hi @visualecho1 ,
Which interface would you be controlling the sensor via? Also, any specific breakout boards that you will be utilizing?

Oh, Hello!  I'm not sure I actually expected a response.  Thank you!
I'm using Loboris' fork of Micropython ( here at https://github.com/loboris/MicroPython_ESP32_psRAM_LoBo ) for Espressif ESP32-WROVER, but currently putting it on a ESP32-WROOM (smaller memory).  I have general purpose I/O lines connected to COM1, COM2, INT, and RESET, and otherwise configured for I2C operation.  The ESP32 can set any of those lines for SPI, I2C, or bit-banging, and I have Python code to call 'C' functions in the ESP32 I2C hardware driver.  I think I can cause an interrupt on the INT line, but not quite sure how to do that yet.
Using available examples, I need to synthesize the module driver that connects this sensor driver in 'C' to the MicroPython hardware I2C functions and the MicroPython import library space.   I don't know the Bosch BNO055 IMU sensor chip that well (YET!) and I'm pretty new to this fork of MicroPython, so I have a few things to learn and a few hundred lines of detailed code to write, however none of it looks particularly difficult to me... just lots of research and debugging.  Board is a new circuit I melted in a toaster last weekend, on single-layer aluminum.

Okay sorry, I like showing off the shiny.
Here are key examples (these are for my reference as well)
I2C interfacing - this contains both maps to Python functions and the I2C calls themselves
https://github.com/loboris/MicroPython_ESP32_psRAM_LoBo/blob/master/MicroPython_BUILD/components/micropython/esp32/machine_hw_i2c.c
Bosch Sensortec BNO055 driver code (and this may not be the best place to put this)
https://github.com/MDVE/MicroPython_ESP32_psRAM_LoBo/tree/master/MicroPython_BUILD/components/micropython/extmod/bno055
Module glue file (no commit yet)
MicroPython_BUILD/components/micropython/esp32/modbno055.c
an example of what to put in there is in the I2C driver as well as the MQTT module at
https://github.com/MDVE/MicroPython_ESP32_psRAM_LoBo/blob/master/MicroPython_BUILD/components/micropython/esp32/modmqtt.c

The IMU is taking I2C commands, so I know that's working.  By directly talking to it via Python I2C commands, I can set it to suspended power mode and read that register back correctly, here is a scope of the write:

Hi @visualecho1 ,
That's a cool board! If you are familiar with the Arduino environment, you can find here an example of how to quickly configure the sensor. The NAxesMotion library is a wrapper based on the BNO055 code you have already used.
The tricky part would be mapping the read-write functions.
Additionally, you may not need to integrate the bno055_support.c file.
You will observe clock stretches on the bus. This can be reduced with a firmware update. Watch the BNO055 page for updates.


Ensure Machine level tags have precedence over infrastructure level tags

#15 introduced a change to ensure tags are updated post Machine creation. However, it didn't account for the tags in the Machine spec as we do on create, as such, any tags set on the Machine themselves were removed on first update and discarded.
This resolves the issue so now the tags from the Machine spec are included as they were before

/retest-required

@damdo Good catch, I've removed it


set chart width between data

Hi, how to set width between data or set fontSize chart data?

But u begeoo nga bisa di install bego bin pusing
Lu nga bagi" ilmu

width between data depends on the number of data points. You can supply less or more data to change width between points