Allow injecting user synchronization modules

This PR allows injection of modules containing synchronization flip-flops (answers https://github.com/chipsalliance/Cores-VeeR-EL2/issues/51).
The config script allows to set additional parameters which end up in code as capitalized defines:
tech_specific_rv_sync - enables usage of the user module
user_rv_sync - specifies the module name
The PR is based on https://github.com/chipsalliance/Cores-VeeR-EL2/pull/54 and should be reviewed and merged after it.

Hi @mkurc-ant , what is the status of this issue?

Hi @varuns-nvidia. This PR is ready but marked as draft as it is based on https://github.com/chipsalliance/Cores-VeeR-EL2/pull/54 (shared codebase) which has not yet been reviewed.

@varuns-nvidia FYI this is ready for review.

@nstewart-amd I changed the required user synchronizer cell model to be 1-bit and without any initial blocks. I left the behavioral code in design/dmi/dmi_jtag_to_core_sync.v as it was like that before my changes (It would be best to tackle this in a separate PR if needed). I also left the behavioral code in user_rv_sync as it is not used by default. When enabled it is used only in the testbench.


cargo-fuzz: 0.11.4 -> 0.12.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rust-fuzz/cargo-fuzz/releases.
meta.description for cargo-fuzz is: Command line helpers for fuzzing
meta.homepage for cargo-fuzz is: https://github.com/rust-fuzz/cargo-fuzz
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.12.0 with grep in /nix/store/3plwjpsxkni0zvxzh1yjnwl9k1g1mn9y-cargo-fuzz-0.12.0
found 0.12.0 in filename of file in /nix/store/3plwjpsxkni0zvxzh1yjnwl9k1g1mn9y-cargo-fuzz-0.12.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cargo-fuzz

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3plwjpsxkni0zvxzh1yjnwl9k1g1mn9y-cargo-fuzz-0.12.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-fuzz https://github.com/r-ryantm/nixpkgs/archive/cf1b76e6811d91275dd16b456a61760b92bb8b3e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/cf1b76e6811d91275dd16b456a61760b92bb8b3e#cargo-fuzz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3plwjpsxkni0zvxzh1yjnwl9k1g1mn9y-cargo-fuzz-0.12.0
ls -la /nix/store/3plwjpsxkni0zvxzh1yjnwl9k1g1mn9y-cargo-fuzz-0.12.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cargo-fuzz

Maintainer pings
cc @Ekleog @matthiasbeyer for testing.

Pushed the backported changes to https://github.com/NixOS/nixpkgs/pull/286757


Doc: Getting Started: Image fix for PDF generation

The pdftex utility that is used for PDF documentation generation does not support GIF images.
This fix replaces the animated ReelBoard-Blinky.gif with an animated PNG (APNG) image ReelBoard-Blinky.png.
Note that APNGs are backwards  compatible with "normal" PNGs. Modern web browsers will display APNGs in the same way as animated GIFs, while any application that can read PNG files can read APNG files successfully.
Signed-off-by: Chris Pearson<EMAIL_ADDRESS>

had something similar in #36674, but I like this solution better. Need to get docs building in CI and  resolve compliance issues.

Thanks! I hadn't seen #36674 or I would have simply commented on it there.


Adding support for restore api

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind new feature
/kind bug fix
/kind cleanup
/kind revert change
/kind design
/kind documentation
/kind enhancement

/kind new feature
What this PR does / why we need it:
PR adds support for restore API.
Which issue(s) this PR fixes:

Fixes #
Test Report Added?:

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED
/kind NOT-TESTED

/kind NOT-TESTED (Autogenerated code)
Test Report:

NA
Special notes for your reviewer:

@skdwriting @joseph-v @wisererik @sushanthakumar
Please review

@skdwriting @joseph-v @wisererik @sushanthakumar
Please review

@joseph-v @sushanthakumar @PravinRanjan10
Fixed all review comments
PTAL

LGTM


doc: strange line in documentation

In documentation page
http://solettaproject.github.io/docs/c-api/group__HTTP__CLIENT.html
The line that describes sol_http_client_connection_cancel() and sol_http_client_request_with_interface() functions have extra "struct sol_http_client_connection" as return values.

I believe it's somehow related to SOL_ATTR_WARN_UNUSED_RESULT SOL_ATTR_NON_NULL(2, 4);

yeah, looks like doxygen isn't able to deal very well with attribute
I'll send a PR for this issue soon

ouch, I pushed the commit fixing it directly to master when I merged the fix for #2247
Anyway, it seems to be fixed now.
If not, please let me know.
Thanks

Instead, would be possible to set the macro SOL_ATTR_WARN_UNUSED_RESULT to empty when DOXYGEN_RUN is set? That way we only change where the SOL_ATTR... is defined, not in all places that use it.

uhm... most probably it would be possible to do something like that, indeed.
Setting all these macros making doxygen fail to empty should work as well

If it works, it's better. Otherwise to use those Soletta macros, one always will have to put two more lines for Doxygen ifdefs.


Bug: Loaded tweets from infinite scroll in a thread have regular checkmark

How to reproduce: Go to a thread with many twitter blue subscribers and start blocking them. After a few the icon will be the regular checkmark icon.
Edit: Okay, I tried reproducing it and it appears to be linked to the infinite scroll when it loads new thread replies. The old replies that were loaded still had the changed icon but the new loaded tweets had the usual check mark.

When I was testing hiding blue replies in threads (still in development), I discovered Twitter was sometimes inserting completely empty elements into the thread timeline, which I haven't seen before in the main timeline.
This was causing an error which would prevent new tweets from being processed, which is probably the cause of this.


TPOT Regression Classifier

Let's see how good a performance we can get on a traditional sci-kit algorith. Whatever we come up with could inform what we put into the app.
We've already gotten ~68% just doing focused vs relaxed samples. For this next push let's organize the problem as a regression with an X matrix containing all freq bins for each electrode and a Y vector containing cognitive test data.
Outstanding Q's:
To accurately train on something that will be reflected during Pomodoro work sessions, we'll want to use a smart metric from the cognitive test. It seems like periods in which performance drops after 'mental fatigue' sets in and difficulty starts decline are what we want to ID. In that case, the derivative of difficulty is a really good measure to have. Does performance capture that accurately? How might we normalize the performance metric to make it most responsive to mental fatigue?

I've been working with TPOT in Dano's CORVO TPOT Notebook
Most runs point to K Nearest Neighbors as being a good algorithm for regression. I'm still playing with datasets and munging data to try and get better performance.


Move options should be disabled by default

The MOVE button in the toolbar should be disabled until items in the List View have been checked off, using the checkboxes.

outdated - closing


Pagination on Commit Graph Page

Can we add pagination to commit graph page?

Maybe the UI can be a 'Load more' button. In this kind of view I think you want to see the context.

but in this case if you want to see 10th page, u need to click 10 times 😕


No Releases Available

I'm unable to install to Foundry, Getting an "error: not found" at https://github.com/mclemente/fvtt-dice-tray/releases/latest/download/module.json

I am not having this issue. At the time of your post, Github was having issues, so that might have been it.


sidecar API is not IPV6 compatible

Bug Description
The sidecar API attributes seem to be not considering IPv6 addresses.
For eg: see defaultEndPoints, bind attributes at https://istio.io/latest/docs/reference/config/networking/sidecar/#IstioIngressListener.
For eg: The sidecar api restricts the defaultEndpoints in the IstioIngressListeners to IPv4 address only.
(Interestingly, the default <IP_ADDRESS> seems to be resolved in the sidecar proxys on pods in our IPv6 cluster – as well as [::]. not sure how)
A config like below results in an error:
apiVersion: networking.istio.io/v1alpha3
kind: Sidecar
metadata:
  name: ingress-sidecar
#  namespace: istio-system
spec:
  workloadSelector:
    labels:
      app: httpbin
      version: v1
  ingress:
  - port:
      number: 9080
      protocol: HTTPS
      name: external
    defaultEndpoint: '[::]:80'
    tls:
      mode: MUTUAL
      privateKey: "/etc/istio/certs/tls.key"
      serverCertificate: "/etc/istio/certs/tls.crt"
      caCertificates: "/etc/istio/certs/ca.crt"
  - port:
      number: 9081
      protocol: HTTP
      name: internal
    defaultEndpoint: '[::]:80'

kubectl apply -f sidecar.yaml
Error from server: error when creating "sidecar.yaml": admission webhook "validation.istio.io" denied the request: configuration is invalid: 4 errors occurred:
* sidecar: defaultEndpoint must be of form <IP_ADDRESS>:, <IP_ADDRESS>:, unix://filepath, or unset
* sidecar: defaultEndpoint port () is not a number: strconv.Atoi: parsing "": invalid syntax
* sidecar: defaultEndpoint must be of form <IP_ADDRESS>:, <IP_ADDRESS>:, unix://filepath, or unset
* sidecar: defaultEndpoint port () is not a number: strconv.Atoi: parsing "": invalid syntax
Version
istioctl version

1.15

kubectl version

1.23

Additional Information
No response

If we relax the validation webhook to allow IPv6 address, will it work well?

Hi @kfaseela, I submitted a PR for this issue, the validation for Sidecar's defaultEndpoint does not support IPv6 format.

Thanks a lot @zhlsunshine for quick response :) Let us also explore the bind attribute, apart from defaultEndPoint, and see if that requires a fix as well.


Using Geo Intents for multiple poinst

Hi
'geo:' property only for one point but I need multiple points
geo:latitude,longitude
//geoURL='geo:'+originLat+','+originLot+'q='+DestinationLat+','+DestinationLong;
var geoURL='maps://?q='+DestinationLat+','+DestinationLong;
window.open(geoURL,'_blank');
in my app(JS) user click "open with  maps navigation" button and I navigate my user current location to selected point(latitude,longitude) but now I need to navigate my user to point A,then point B and finally Point C
how can I handle that?Can I use geo: with multiple points such as
geo:[latitude,longitude;latitude1,longitude1;latitude2,longitude2] how can I fix that problem?are there any alternatives with maps navigation? There is waypoints but it does not work with maps navigation

Hi, looks like you've opened issue in wrong repository


v10 breaking change

With v10, this code now no longer works.  What needs to be adjusted?
    public class CachingBehavior<TRequest, TResponse> : IPipelineBehavior<TRequest, TResponse> where TRequest : ICacheableMediatrQuery
Where ICacheableMediatrQuery looks like this
    public interface ICacheableMediatrQuery     {         /// <summary />         public string Foo{ get; set; }         /// <summary />         bool BypassCache { get; }         /// <summary />         string CacheKey { get; }         /// <summary />         TimeSpan? SlidingExpiration { get; }     }

See the migration guide:
https://github.com/jbogard/MediatR/wiki/Migration-Guide-9.x-to-10.0

Could you put a "Breaking Changes in v10" or "Migration Guide" link prominently in the README?

To all of them? There's multiple migration guides.

I'd say either just the most recent one, or to a page that has all of them. Either would have saved me time a few minutes ago. Also for some reason your README doesn't appear (fully) on Nuget.org, which is where I first looked for a "Breaking Changes in this Version" link:

@jbogard
Getting below errors after upgrade to MediatR 10.0.1

Reference to type 'IBaseRequest' claims it is defined in 'MediatR', but it could not be found
Reference to type 'IRequest<>' claims it is defined in 'MediatR', but it could not be found
Reference to type 'IRequest' claims it is defined in 'MediatR', but it could not be found

Any clues on these?

@Sandeep7OnShell Looks like the types that we moved to the MediatR.Contracts package, I've updated the upgrade guide accordingly: https://github.com/jbogard/MediatR/wiki/Migration-Guide-9.x-to-10.0

@jbogard Using the new package and still getting the same errors.

Can you open a new issue? It's not related to the one here.


When to support grails 3.3?

Steps to Reproduce
Per this link https://github.com/grails/gorm-hibernate5/issues/25, the correct multiple datasources config syntax for grails 3.3 is:
dataSource:
    # primary dataSource config ("dataSource")
dataSources:
    secondary:
        # secondary dataSource config ("dataSource_secondary")

rather than:
dataSources:
    dataSource:
        # primary dataSource config ("dataSource")
    secondary:
        # secondary dataSource config ("dataSource_secondary")

But the grails-database-migration tool supports only the second format. I've tried to provide a PR for quick fix, but it broken lots of tests since grails 3.3's test framework has been changed totally. https://github.com/grails-plugins/grails-database-migration/pull/140

Hi @graemerocher @jameskleeh,
Have you been aware of this?

@kevinclcn Have you tried version 3.0.3 of the plugin? As far as I can tell it's fixed there

hi @jameskleeh , I created a demo for this issue: https://github.com/kevinclcn/dbmigrationIssue
clone it and run ./gradlew dbmUpdate, it would complain:
    Command execution error: Cannot get property 'password' on null object
    :dbmUpdate FAILED

But once I commented out the second datasource(the app datasource in application.yml), the migration works fine.
I problem I found is in the method DatebaseMigrationCommand::getDataSourceConfig(), see the pr:
https://github.com/grails-plugins/grails-database-migration/pull/140/files

We are having the same issue, the application starts up and runs migrations ok but commands like dbm-gorm-diff fail if you don't have a dataSource inside the dataSources block still.


Update Netlify API client to 2.2.1

Update API client to 2.2.1 to help address https://github.com/netlify/cli/issues/161#issuecomment-433201317

Coverage remained the same at 100.0% when pulling ba28234aa14f9df7702c7985a7fdeeb90fb0841a on update-client into 329132e491f4d7b5581df38a6937d44e0f6999eb on master.


add bitfields documentation

Implementation: https://github.com/dlang/dmd/pull/13568

@CyberShadow can we please have a way to find what the errors are with DAutoTest?

With DautoTest (unless you have LeTeX error in which case you're screwed) scroll all the way to the bottom of of the Build Log (click view).
In this case your problem is
Searching for tabs
./spec/struct.dd:134:	b.x = 4;

Oh, I clicked on "base view". No errors there. I wonder what that is.
Anyhow, thanks! Hope it works now.

The text mentions unit several times, but never says what it is.

@MrSmith33 it does now!

The dmd bitfields PR has been merged, under the -preview=bitfields switch. This one needs to be, too.

The dmd bitfields PR has been merged, under the -preview=bitfields switch. This one needs to be, too.

OK - As soon as it mentions the preview flag I will merge it

does the best practices section at line 44 still hold?

DeclaratorInitializer should also get a rule with BitfieldDeclarator in the grammar. DeclaratorIdentifier is only used for declarators after the first comma, while DeclaratorInitializer is used for the first declarator.

Another potential ambiguity in the grammar:
void f()
{
    a: b;
}

The statement could be a bitfield with a as type and b as width, but it could also be a labeled statement with a as label and b as a statement. Bitfields are probably only allowed in classes and structs, but the grammar would also allow them in functions.

@WalterBright you may want to update this part: https://github.com/dlang/dlang.org/blob/ae9d2d63077db4daff8407280d4e6ece1547e942/spec/struct.dd#L90-L94

@maxhaton If bitfields are here to stay it would be good to merge this after adding any of the diff suggestions as you see fit. After that I can make a pull to fix https://github.com/dlang/dlang.org/pull/3190#issuecomment-1140274338

We really shouldn't document this useless trash feature that never passed the DIP review to be added to the language.

you may want to update this part

Done.

Ready to merge.

@dkorpel see https://github.com/dlang/dlang.org/pull/3190/files#diff-dee70e840ada3a820b3a373d649812b1157fd584ed0837e4a937ea3418f093e3R212

A preview switch doesn't imply it's not part of the language, there are preview switches for current language features.

Since bitfields do not influence anything else in the language semantics, there's no longer a purpose to putting bitfields behind a preview switch.


added missing translations for 5.3 dungeons + small additions

this is just a reminder for when this PR is merged:
"replaceText": Translation "Teleport" is never used!
"replaceText": Translation "Thin Ice" is never used!

this is just a reminder for when this PR is merged:
"replaceText": Translation "Teleport" is never used!
"replaceText": Translation "Thin Ice" is never used!

Sorry, when I re-did the o1s timeline properly I never added back the teleport lines and used the ability name instead of the effect name Thin Ice.
When you say "just a reminder", are you expecting me to do something here? Who is this reminder for?
Do you want to remove these two lines here, since I know why they're not used?

yes i can remove them here and usually you want a seperate commit form them (but was not able to do it due to work thats why i did it as a comment xD)


Fix: unify stdlib for workflow and kubevela

Signed-off-by: FogDong<EMAIL_ADDRESS>Description of your changes

Fix: unify stdlib for workflow and kubevela
I have:

[x] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

what's fixed? Is it only a code refactor?

Yes it's more like a code refactor, this fix unifies the op.cue in workflow and kubevela, so that we don't need to change op.cue in every repository.


VMs with SQL Server backup configured: local or azure sql backup?

Regarding the snapshot troubleshooting titled 'VMs with SQL Server backup configured', is this referencing a locally configured SQL backup or a remote backup via Azure's preview Recovery Services Sql Backup feature?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7f030558-66a5-d963-54a2-3f71643c5ef0
Version Independent ID: 2cdf6775-5ee9-83b6-3a1b-b87a682c1b1c
Content: Troubleshoot backup errors with Azure virtual machines
Content Source: articles/backup/backup-azure-vms-troubleshoot.md
Service: backup
GitHub Login: @srinathv
Microsoft Alias: srinathv

@badbob001 Thanks for the Comment. We are actively investigating and will get back to you soon.

It refers to both. IaaS VM backup by default truncates log backups and this can have an issue when taking snapshot. So, if you have configured Sql backup either locally or via Azure Backup enhanced protection, it will get into the same issue. So, in order to avoid that, we request you to set VSSCOPY to true so that we don't truncate the logs.

@badbob001 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


July 9, 2020 Release

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   39.77%   39.77%
=======================================
  Files          19       19
  Lines         636      636
  Branches       85       85
=======================================
  Hits          253      253
  Misses        381      381
  Partials        2        2

Overrode Googlebot because it got confused by my personal gmail

Overrode Googlebot because it got confused by my personal gmail


concourse deployment should support ELB

Concourse web VMs should have an ELB in front of them, but currently there is no ELB information in the cloud config, meaning I have to download the cloud config, manually add ELB, and re-upload it, which means I'm working outside of the bbl tool, and I imagine that my config will be removed next time I run bbl (I haven't confirmed this though).
Also, we will need to configure cert information for the ELB somehow via bbl, otherwise we have to upload the certs out of band.

Already on roadmap:

support LB in Cloud Config: https://www.pivotaltracker.com/story/show/115989445
support specifying certs: https://www.pivotaltracker.com/story/show/115989461


Fix label tag retrieval query

The first few results when retrieving >20 labels will have an error when retrieving tags. All label tags will be retrieved, rather than just the ones that belong to that label.

Fixed in 75c24c97fb38b68ae783a28443f0489398241cf6


Bug fix validate.go

Current code only works if a string is passed as the version.  If no string is provided, the a clone is attempted on a branch name of "v", which won't exist in the public OC repo

Pull Request Functional Test Report for #3598 / 2915228b9203ebf95f82f59f5248b5ff89652f43
No tests identified for validation.
Help


Create Ansible inventory

Contains definitions for homelab servers reachable via wintermelons.me.
These servers can be reached via public DNS, so they should be safe to commit.

lgtm

Did you mean to approve, instead of close?


 This Dockerfile will contain an ARG, but I'm okay with not being able to set a non-default value (i.e. it's fine if the ARG acts like an unconfigured ENV, which Dazzle supports).
Expected behavior: Dazzle successfully builds the Dockerfile (without ability to set a non-default ARG value)
Actual behavior: Dazzle sees an ARG and decides to fail early

Required to fix https://github.com/gitpod-io/workspace-images/pull/303 (adds two ARGs)

Ping @csweichel 😇


Restore the blacklisters-approved/rejected icons in PR comments

We used to store these icons behind a camo.githubusercontent.com link, but attempting to access that link throws a 403 now.
Example PR comment where the image is no longer visible: https://github.com/Charcoal-SE/SmokeDetector/pull/11282#issuecomment-2127452764
The source for these images is from https://shields.io/ 's static badge generator. It has an API that this PR uses to generate and return a specified label with a given style.
We just need a simple green/red coloring for the "blacklisters|approved" and  "blacklisters|rejected" actions we perform, and the URL for that is very simple.
Here's how these two URLs will be rendered in a comment:

Where the markdown is ![Approved with SmokeyApprove](https://img.shields.io/badge/blacklisters-approved-green)

Where the markdown is ![Rejected with SmokeyReject](https://img.shields.io/badge/blacklisters-rejected-red)
Shields.io has been around for a loooong time, since 2013 (?) and is unlikely to be deprecated in the near term as far as I can tell. An alternative approach, which we could do, is to store the image in SE's i.sstatic domain instead and refer to that. I am not against changing this to do so instead of relying upon shields.io's API, if requested.

Thanks for the contribution, and sorry for leaving it unreviewed for so long.


Configure paths

By default the plugins maps the path of the Vagrantfile, however, we've setup a synced folder with our code, outside of the Vagrant location (config.vm.synced_folder "~/code", "/srv/code", type: "nfs"). Perhaps you could make the hostpath and guestpath an optional config item? This way we can define our application folders correctly. For example:
config.notify_forwarder.host_path = "~/code"
config.notify_forwarder.guest_path = "/srv/code"

I'm totally unfamiliar with Ruby, so I can't submit a PR.

Well, fixing it was easier than I thought. See PR #4 :smile:


Get list of entities

Something like "GTA::World::GetPeds"/"GTA::World::GetVehicles". There doesn't seem to be a native function for this though (correct me if I'm wrong), so need to do this differently somehow (GTAIV ScriptHook read it directly from game memory for example).

World::GetNearbyPeds() and World::GetNearbyVehicles() both work properly now, but we should still leave this issue open for now.  Both methods seem to only return entities within a maximum radius of 55 units

And it only works by passing another ped, it would be nice to have methods were you just have to pass a position.

I'm working on this. The address of the entity pool is at *(GTA5.EXE+29A1920). The way pools are laid out in the memory is pretty much the same as GTA 4 so you can see how it can be implemented in original ScriptHook .Net.

:+1:

@Sergeeeek That's great to know!

Discussion continues in #191 , should be merged soon :+1:


Checkpoint 2

Hi @droberts84,
I am having trouble installing/injecting firebase to my app. In my scripts/controllers/HomeCtrl.js file
I added a test phrase to the scope of my home controller and then went to templates/home.html
and accessed the test phrase there just to test if my controller was working and it does. However,
when I inject 'Room' in my controller this stops working and my js console shows me this error:
angular.js:13708Error: [$injector:unpr] http://errors.angularjs.org/1.5.7/$injector/unpr?p0=NaNirebaseArrayProvider%20%3C-%20%24firebaseArray%20%3C-%20Room
which made me realize that in services/Room.js:
(function() {
  function Room($firebaseArray) {
    var ref = firebase.database().ref().child("rooms");
    var rooms = $firebaseArray(ref);

    return {
      all: rooms
    };
  }

  angular
    .module('blocChat')
    .factory('Room', ['$firebaseArray', Room]);
})();

There's an undefined variable firebase. I figured this is something I need to install so then I added the script in my index.html page and added it to my scripts/app.js as such:
  angular
    .module('blocChat',['ui.router', 'firebase'])
    .config(config);

but this still doesn't work. Could you please advise?

There's an undefined variable firebase. I figured this is something I need to install so then I added the script in my index.html page and added it to my scripts/app.

Did you actually see an error undefined variable firebase or assume that on your own firebase should actually be the global firebase library, added by this script tag.  See more details in the firebase docs.  Basically.. this is unlikely to be the issue.
Ok, so now lets examine this error message:
 [$injector:unpr] http://errors.angularjs.org/1.5.7/$injector/unpr?p0=NaNirebaseArrayProvider%20%3C-%20%24firebaseArray%20%3C-%20Room

Well that is a pretty horrible error message.. but it still provides some hints we can work with.  I see FirebaseArrayProvider and Room in there.. so there is a decent chance it has to do the Room service.  We can also google  [$injector:unpr] which indicates these errors are typically associated with not being able to resolve dependencies.
It takes a dependency called $firebaseArray.  Where does that come from?
It looks like its a service included in the Angular Fire project.  (Check the README which describes it).  Looking at your index.html you don't seem to be using AngularFire.  Make sure you follow their quick start guide


Fixed the problem with the only parameter functionality

See issue https://github.com/flugger/laravel-responder/issues/118

Thank you for explaining the issue in such detail in https://github.com/flugger/laravel-responder/issues/118.
I've been tinkering a bit and there is indeed a bug as it should handle both arrays and strings. However, your solution creates new problems, which one of the unit tests picked up on.
We need to merge the fields with already parsed fields for the same entity, but it should also be explicitly casted to an array if it's a string. I believe this should work fine:
$fieldsets[$key] = array_unique(array_merge(key_exists($key, $fieldsets) ? $fieldsets[$key] : [], $fields));

Thanks for the quick reply, and sorry for my late response! I will look into it tomorrow, and edit my PR after I've tested it with your code. Keep you updated!

I had this code already, I casted it in my project to quickly work with it because I needed it immediately but forgot to update it in the laravel-responder library folder (because I was experimenting)! 🤦♂ Now I casted the field explicitly to an array, and by doing the short-handed if/else (instead of the coalescing operator (??)) block it is fixed.
Thanks for the reminder, it works like a charm! Hope to see it updated, so I can remove it from my vendor folder where it shouldn't be so I can update your package 👍 :)
Besides this issue, good work on this nice library! Keep up the good work 💯
@flugger

Thanks! I’ll tag a release soon :)


Error 'The state parameter is not for this browser session'

Description
Hello I deployed my app on AWS lambda and am using API gateway to trigger my slack App lambda. when I access through function URL of my slack app lambda, it works fine. However, when I try to install my app via API gateway https://myappDomain.com/slack/install I get to the page where Slack asks a user if they want to grant a permission to this app without a problem. But when a user press Allow button, it is throwing me the error, 'The state parameter is not for this browser session' which I found on Cloudwatch.
What does that error mean exactly? and what can I do to solve the issue?
Thank you.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[ x ] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[ x ] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[ x  ] I've read and agree to the Code of Conduct.
[ x ] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
package version:
node version:
OS version(s):
Steps to reproduce:

Expected result:
What you expected to happen
Actual result:
What actually happened
Attachments:
Logs, screenshots, screencast, sample project, funny gif, etc.

Hi @esphoenixc, thanks for writing in!

What does that error mean exactly?

The OAuth flow for your Slack app installation verifies whether the installing user is the same user agent for better security. Refer to the following resources and their links:

https://github.com/slackapi/bolt-js/releases/tag/%40slack%2Fbolt%403.11.0
https://github.com/slackapi/node-slack-sdk/issues/1435

and what can I do to solve the issue?

A browser cookie is used for transferring the user state to verify the OAuth flow is safe. The possible causes of your situation would be:

/slack/install and /slack/oauth_redirect is not in the same domain
Either /slack/install or /slack/oauth_redirect is not an https:// URL
More than 10 minutes (the default timeout) passed after visiting /slack/install

I hope this was helpful to you and you will figure the case out soon!

@seratch Thank you!! one of the possible causes of my situation you gave me : /slack/install and /slack/oauth_redirect is not in the same domain
Yeah that was the issue and I solved it. Thank you so much again for your help!!!!!


is matrix multiplication rather than elementwise multiplication

I understand that it might be too late to change this for compatibility reason.  I feel awkward when mixing * operator with numpy because they have different meaning.  But this behavior is not emphasized enough in the tutorial since this is inconsistent with numpy and and pep465.  We need to use multiply to do the element-wise multiplication.
In numpy, @ is reserved for matrix multiplication and * is reserved for element-wise multiplication.

Yes, this is a difference with numpy that will not change for compatibility and other reasons. The main reason was that I need a reasonable matrix multiplication symbol in Python 2.7, and it would be confusing to have * mean one thing in Python 2.7 and another in Python 3. I could see emphasizing this more in the tutorial certainly

I've updated the documentation to emphasize this. It'll be reflected on the website within the next week or so.


Change squbs activator templates to giter8

With activator being EOL'd
https://www.lightbend.com/community/core-tools/activator-and-sbt
we need to change the squbs templates to giter8.

see
https://developer.lightbend.com/blog/2017-03-17-how-to-migrate-activator-template/?_ga=1.170155300.581444229.1485490982


Creating a Frontend UI for the Pharmacogenomics widget using the PharmGKB data

We want to create a UI for the Pharmacogenomics widget where we can integrate PharmGKB data into the Platform.
This ticket is for the development of the UI which will be done by the FE team
Dependencies

[x] The JSON schema details compiled by the data team can be found here: #3110
[ ] Mapping ChEBI identifiers to ChEMBL #3116
[ ] The product and design related discussion can be found here: #3098
[ ] Process PharmGKB data #3128
[x] Implement the required backend changes #3127

Tasks

[x] To create a frontend for the Pharmacogenomics widget (diagram in the comments below)

Acceptance tests

Netlify link and tested in the development deployment

I think there are a few bits that needs to be clarified (make the epic more granular):

Any implications on PIS
Any implications on POS

Draft of Pharmacogenetics widgets below (discussed with Irene and reviewed by Ellie):
Built on this Json Schema

Widget on target ( "Targetfromsourceid”) profile page
Will be placed between the ”Safety” and "Chemical probes” widgets
Datatypeid: "clinical_annotation”

Widget on drug ("Drugid”) page
Will be placed between the ”Drug warnings” and the “Pharmacovigilance” widgets
Datatypeid: "clinical_annotation”

Please note comment from Ellie: we could choose to display just 1A and 2A values for the evidenceLevel field. This will probably enrich the data with drugs that have a Chebi/Chembl mapping as per #3116
Tagging @ireneisdoomed to this as well.

Thanks @jdhayhurst everything looks great!

Thanks @jdhayhurst. My understanding from looking at the schema you posted earlier in the comments is that some of those fields would expand to a full object?
Looking at the mockups for the widgets, it seems some columns require for example tooltips.
Example for widget on Target page:
GenotypeId: needs full object for id (genotypeId.title?) and description for tooltip
Variant consequence: needs variant info for tooltip, not sure which field
Drugs: needs drug name and id for the link
Adverse outcome: phenotypeText.title + phenotypeFromSourceId for the link; tooltip: genotypeAnnotationText.title
Adverse Outcome Category: possibly pgxCategory.title ?
Confidence: is that evidenceLevel.examples ?

Thank you @LucaFumis and @jdhayhurst for looking into it!
Some comments on top of @buniello 's specifications:
Target and drug widgets

variantFunctionalConsequence is nullable. This is a SO term that needs to be resolved.
phenotypeText is still not filtered to pick out actual adverse outcomes from drug responses. @LucaFumis, can you rename "Adverse Outcome" to "Drug Response" and "Adverse Outcome Category" to "Drug Response Category"? These are more general terms.

Target widget

Drug column:

The text should be drugFromSource
Hyperlink to drugId. Not all drugs will have a drugId.
@jdhayhurst we are not using drugFromSourceId anywhere. So strictly speaking you could omit this field from the API if you wanted.

Drug widget

Gene column:

The text should be the name of the resolved Ensembl ID in  targetFromSourceId
Hyperlink to targetFromSourceId
@LucaFumis, tooltip text is now built based on isDirectTarget

when True: "The variant is in the drug's primary target gene.."
when False: "The variant is outside the drug's primary target gene."

The rest of the fields are as pointed out in the widget prototype.
Please chip in @opentargets/data-team @d0choa if you have any comments

Thank you @ireneisdoomed and @jdhayhurst for the feedback and input. I probably won't be working on it, but let me know in case anything needed...

@chinmehta is working on the UI now. By now, we will be using sample data, and as soon as the data is in dev, we change it.

@prashantuniyal02 @jdhayhurst
Missing fields from mockup/api
Target and drug

[ ]  genotypeId → tooltip see here for more details, "here" link is missing
[ ]  source→ pharmgkb is missing
[ ]  literature→ link to pmid, complete link details and multiple literature id shown details
if more than one id-> open in a drawer / show in same column

For point 3, can we adopt the same behaviour as is present in the GEL PanelApp, UniProt literature or UniProt curated variants widget which have a Literature column?

@chinmehta that is a good idea!

Already discussed and benchmarked with @chinmehta - (please let me know if anything is not clear)
We would like to harmonise the pharmacogenomics widget to the Clinvar one, by adding:

[ ] Chip/link to ProtVar for missense variants
[ ] Hyperlinks to Ensembl for rsids
[ ] VEP/ProtVar chips should look exactly same as in the Clinvar widget

@chinmehta, as already discussed on slack, please see points below and let me know if everything is clear

[ ] The current preview position of PGx widget in both target and drug pages are good.

[ ] There is a typo in the widget header in drug page e.g.: https://deploy-preview-283--ot-platform.netlify.app/drug/CHEMBL2010601.

Header should spell:  Genetic variants that are associated with the response to drugId. Source: [PharmGKB](https://www.pharmgkb.org/). the drugId` field should expose the drug name.

Latest version of drug and target profile PGx widgets are in the testing phase (external and internal test included).

@chinmehta Some comments on the widget on drug and target pages:

The box for the Level 2 evidence is white, so it looks like there is no data.
The tooltip that has a granular description of the genotype is "floating" when the drug response phenotype is null. @buniello, not sure what is the best way to show this.

Good catch @ireneisdoomed! will discuss these with @chinmehta on wednesday

A bug in the widget:

[ ] The widget crashes when the search query is not found in the table (similar to #3084) - This will keep happening till we fix the root cause for this. @chinmehta

2 points raised by David:

Should the default sorting be done in the confidence level (1A > 1B > 2A > 2B)?
Are the color pallets for 1B correct? (1A and 1B are green and 2A and 2B are blue in PharmGKB)

Case in point: /target/ENSG00000167397

FYI @buniello


Query from cache makes component render twice

Intended outcome:
Example app has a TopComponent, which executes query. This component has a nested BottomComponent, which also executes the same query.
I expect BottomComponent to render only once since data is fetched from cache or at least to have some kind of loading / complete state.
Actual outcome:
TopComponent executes query. When loading prop is false, BottomComponent is rendered. It takes query from cache and renders the same component twice with the same props.
How to reproduce the issue:
The app is as simple as that:
// App
const App = () => {
  const networkInterface = createNetworkInterface({
    uri: 'http://admin.localhost:3000/graphql'
  })
  const apolloClient = new ApolloClient({ networkInterface })
  const store = configureStore(apolloClient)

  console.log('render app')

  return (
    <ApolloProvider store={store} client={apolloClient}>
      <TopComponent />
    </ApolloProvider>
  )
}

// TopComponent
const TopComponent = ({ data: { loading, error } }) => {
  console.log('render top component', loading, error)
  if (loading) {
    return
loading

  }

  if (!loading && error) {
    return
error

  }

  console.log('before render bottom component')
  return (
    <BottomComponent />
  )
}

export default graphql(query)(TopComponent)

// BottomComponent
const BottomComponent = ({ data: { loading, error } }) => {
  console.log('render bottom component', loading, error)

  return (

bottom component

  )
}

export default graphql(query)(BottomComponent)

The result output:

As you can see, BottomComponent renders twice with the same props.
Version

<EMAIL_ADDRESS><EMAIL_ADDRESS>

➤ Paul Myburgh commented:
Yep running into this issue as well it seems. Causing havok trying to get CSS-in-JS styles working with fela - as the style renderer creates different stylesheets on each render now which collide with each other and the styles get all muddled.
I'm pretty sure this is also related to the previous issue I created #996 , where I noticed two renders being enacted on both server and client.
I uploaded an example project that shows it happening, here: https://github.com/lostpebble/apollo-two-render

➤ stale[bot] commented:
This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

➤ Vlad Shcherbin commented:
What a useless bot, wow. What activity do you expect, it's an issue tracker, not a chat room.

➤ stale[bot] commented:
This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

➤ Jean-François Ducarroz commented:
I am experiencing the same issue!
Looks like GraphQL subscribes to the query on GraphQL.componentDidMount which will force a render once the subscription returns data (via next). This despite it already got the query result when calling GraphQL.dataForChild during the initial GraphQL.render.

Facing same issues, React-apollo query wrapper render the components two times


[doods] new chart

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [radarr])

@billimek this chart needs an edge you therefore it would not work in the cicd system

@runningman84 as with https://github.com/k8s-at-home/charts/pull/153 do you think you refactor this into a chart that uses the common library?
I just pushed a change to zwave2mqtt which shows how the lib can be used with attaching a device.
https://github.com/k8s-at-home/charts/tree/master/charts/zwave2mqtt

Is the configuration in the ConfigMap reusable for everyone? Or does it need setup/user-specific content? Because in that case I think the file contents may be better off in a value in the values.yaml

@runningman84 Instead of just rebasing, you also need to process the feedback from maintainers in the comments section... just to be sure ;-)

I've marked this PR as stale, since there hasn't been any activity for quite some time

Closing this one, since there hasn't been any activity for quite some time


pytorch_pretrained_bert vs transformers

The README has a link to https://github.com/huggingface/pytorch-pretrained-BERT, but this redirects to https://github.com/huggingface/transformers and I think the former is deprecated. The pytorch-pretrained-bert package still exists on PyPI (link), but I installed transformers instead. Now I'm getting ModuleNotFoundError: No module named 'pytorch_pretrained_bert'. In line 12 shown below, I simply replaced pytorch_pretrained_bert with transformers:
https://github.com/getalp/disambiguate/blob/d6c0e75fb8739c57b519fb3c9a5ac1216c96a0ab/python/getalp/wsd/modules/embeddings/embeddings_bert.py#L8-L14
This gets me a little further, but then I see this (partial traceback):
  File "/home/mwg/wsd/disambiguate/python/getalp/wsd/modules/embeddings/embeddings_bert.py", line 69, in forward
    inputs, _ = self.bert_embeddings(inputs, attention_mask=pad_mask, output_all_encoded_layers=False)
  File "/home/mwg/wsd/disambiguate/py36/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in __call__
    result = self.forward(*input, **kwargs)
TypeError: forward() got an unexpected keyword argument 'output_all_encoded_layers'

I looked at the following link but did not see anything about output_all_encoded_layers: https://github.com/huggingface/transformers#Migrating-from-pytorch-pretrained-bert-to-transformers
I saw https://github.com/huggingface/transformers/issues/3541 and then changed line 13 above to have the parameter output_hidden_states=False and removed the output_all_encoded_layers=False parameter from line 69 (shown below):
https://github.com/getalp/disambiguate/blob/d6c0e75fb8739c57b519fb3c9a5ac1216c96a0ab/python/getalp/wsd/modules/embeddings/embeddings_bert.py#L69
After this I was able to get some output. Can you confirm if these changes are sufficient? If so I can put together a PR for the fix.

Thank you for pointing that out !
Everything looks good, but I will have to be sure that it doesn't break anything after the change, at least by reproducing the main results of our paper. I will do it when I have time !


Bump svgo to 0.7.0

https://github.com/svg/svgo/releases/tag/0.7.0
Thanks for grunt-svgmin ❤

From their changelog:

Required Node.js version has increased to 0.12

Could you remove 0.10 from the .travis.yml and change the minimum version in package.json?

Thanks @kevva - updated and added node 6

Thanks 👍


Remove "apps" database tables

refs https://github.com/TryGhost/Team/issues/221
Context
The concept of "apps" has been removed in Ghost some time ago but there were database tables left as these would be potentially long running migrations. With a preparation of Ghost 4.0 we can add migrations which would need longer time to run.
Solution
Remove the tables apps, app_settings, app_fields and permissions_apps - as they are not used.

[x] drop tables (https://github.com/TryGhost/Ghost/commit/606212d18767d7ed5a61b62be7a68341224c7ed7)
[x] cleanup old data (https://github.com/TryGhost/Ghost/pull/12596)

Related

https://github.com/TryGhost/Ghost/pull/10682

refs https://github.com/TryGhost/Team/issues/221
Context
The concept of "apps" has been removed in Ghost some time ago but there were database tables left as these would be potentially long running migrations. With a preparation of Ghost 4.0 we can add migrations which would need longer time to run.
Solution
Remove the tables apps, app_settings, app_fields and permissions_apps - as they are not used.
Related

https://github.com/TryGhost/Ghost/pull/10682

refs https://github.com/TryGhost/Team/issues/221
Context
The concept of "apps" has been removed in Ghost some time ago but there were database tables left as these would be potentially long running migrations. With a preparation of Ghost 4.0 we can add migrations which would need longer time to run.
Solution
Remove the tables apps, app_settings, app_fields and permissions_apps - as they are not used.
Related

https://github.com/TryGhost/Ghost/pull/10682

The https://github.com/TryGhost/Ghost/pull/12596 landed in master, which was last bit needed for full cleanup.


Tab bars should stay even when using loading.json

Because loading.json is a standalone view of its own, currently whenever you try to switch between tabs, the tab bars go away for a while before coming back.
When navigating between tabs, the loading.json shouldn't mess with the tab bar and assume that there will be the same tab bar where it's headed.

Fixed with https://github.com/Jasonette/JASONETTE-iOS/commit/4c702990dc43ca43ed94edc9c47864b50637d3d4


Revert "Fix mypy typing errors in pytorch_lightning/strategies/single_tpu.py"

Reverts Lightning-AI/lightning#13534
In the previous PR I explained that the condition is_overridden("on_post_move_to_device", self.lightning_module) can not be True. This is incorrect. I missed the heritage of LightningModule with ModelHooks.
Indeed, ModelHooks implements on_post_move_to_device.
I am very sorry for this.
I think I did not see it in the unit tests because this function has been deprecated in v1.5 and will be removed in v1.7, therefore it is not tested. According to this test: https://github.com/Lightning-AI/lightning/blob/61c28cb428a13c2aea6d7f3f55e0f00431a4ea4e/tests/tests_pytorch/deprecated_api/test_remove_1-7.py#L64

Probably no need to revert it, as #13534 will be merged to 1.7 only and won't be included in 1.6.X

@Cyprien-Ricque Thank you for your action! The change shouldn't have been part of your previous PR #13534, but as mentioned above, there's no need to revert the change because my PR #13548 will remove it anyway as part of #12521 and the change won't be included in 1.6.x. Could you close this PR?


Lab0405 numeronyms and stringer implementation

Fixes #67
Fixes #70
Changes proposed in this PR:

Implement Numeronyms and corresponding unit test
Implement Stringer and corresponding unit test

Please fix build and commit messages first.

Hi,
There has been  no activity in the last 20 days so I will close this PR.
Feel free to open it again if you have something to add.
Thanks!
Julia


why i can't import anythin since 0.5x

when i update rn into 0.5x

and here is Urls.js

https://stackoverflow.com/questions/49232344/react-native-unable-to-resolve-module-tty-from-node-modules-window-siz
……………………………………
i am tring to using this ,but nothing help


Building with CentOs: 404 The specified blob does not exist

Getting a 404 when building with CentOs
https://sfprebuilt.blob.core.windows.net/binaries/WinFab.Linux.Libs.2.4.1-centos.nupkg

BlobNotFound

The specified blob does not exist. RequestId:35e28e2e-601e-0050-5e82-124ac9000000 Time:2019-05-24T22:46:09.6220063Z

Uploaded the missing package.  Should be fixed!

Thanks!

hello
I deployed the service fabric on my local Centos 7 1908, and executed ./runbuild.sh -centos in the /root/service-fabric directory. When the progress reached 89%, the following fault code would pop up:
clang-5.0: error: unable to execute command: Killed
clang-5.0: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 5.0.0 (https://github.com/GorNishanov/clang.git a7b79f4b65825ad3c0da0aae7b15c95fac7624f6) (https://github.com/GorNishanov/llvm.git f3e85a45cfc3745f0db04cfeeee892c463e30e7b)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm-5.0/bin
clang-5.0: note: diagnostic msg: PLEASE submit a bug report to http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and associated run script.
clang-5.0: note: diagnostic msg:
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang-5.0: note: diagnostic msg: /tmp/StoreStateProviderFactory-7aba2c.cpp
clang-5.0: note: diagnostic msg: /tmp/StoreStateProviderFactory-7aba2c.sh
clang-5.0: note: diagnostic msg:
make[2]: *** [src/data/tstore/lib/CMakeFiles/objects_TStore.dir/__/StoreStateProviderFactory.cpp.o] Error 254
make[1]: *** [src/data/tstore/lib/CMakeFiles/objects_TStore.dir/all] Error 2
make: *** [all] Error 2
Error: cmd failed: make
Can you take a look for me? thanks


Update reference-connect-version-history.md

Updated with guidance for deleted devices due to rule changes

@RobdeJong : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Reset specific StackRouter with key

Motivation
There is no way to build a Login/Register flow without the ability to reset the router to the top-level nav state without hacky workarounds.
#691 #723
By allowing a key to be passed along with a reset action, you can specify what level of state you want to reset to.
Test plan (required)
I added a test case that verifies the functionality.
I'm happy to add more test cases or documentation, if you find this PR useful.

Can we get some input on this? It would be really nice to get this merged in if there's no other plans to implement this functionality.
cc @satya164 @ericvicenti

Thanks for contributing @scbrady.
For tests, I have installed react-navigation from your master. And it really works fine, solving the issue I have, like reported here #395.
But, I have noticed another issue. I don't know if it has relation with your modifications.
In my present screen, the this.props.navigation.setParams({ foo: 'test' }) doesn't works. This doesn't update the state.params.
An example:
class MyScreen extends React.Component
{
  static navigationOptions = {
    title: ({ state }) => state.params.title,
    // others props
  }

  componentDidMount()
  {
    this.props.navigation.setParams({
      title: 'Super Title',
    });
  }
}

If I put a console.log here:
static navigationOptions = {
  title: ({ state }) => {
    console.log('the state', state);
    return 'Super Title'
  },
  // others props
}

There is no params inside the state. Just this { routeName: 'MyScreen', key: 'Init' }.
As I said, I don't know if this issue is related with yours modifications. But, I hope it will helpful.

any reason this hasn't been reviewed yet?

This is working great for my purposes, I ended up implementing a custom StackNavigator with this change added to it.  Would love to see this merged.

This looks pretty great! I'll land it now. Can somebody go and add this to the docs?

Does this PR include the ability to specify the key as root, as described in @ericvicenti's comment?
As of now this PR is mostly solving my issues, but I'm having a problem resetting all the way back to the root navigator because there are multiple routes with the same key (Init0 seems to be a default somewhere that keeps getting used, but I can't find where it's being set in the StackRouter source).
I suppose another solution to this issue would be the ability to specify a route's key as it's been navigated to, but I haven't been able to find documentation/code that does this. Is it possible?

@stevenleeg The root navigator doesn't actually have a key if I remember correctly, so I made it so you can pass the key null into it and it will reset to the root navigator.
NavigationActions.reset({ actions, index, key: null })

Interesting. Sending null to the action seems to work, but I'm still having trouble navigating in my particular scenario.
Is there a way to set the key of a screen? If so that would help me immensely, as my issue would go from needing to figure out how to reset the navigation to a certain state to dispatching back given the view's key (I can't do that now because I have no idea what that screen's key will be when it's placed on the stack).

What version will this be built into? I am on beta.7 but I don't see the change.

@radicalnerds It looks like this PR just landed in the newest beta version (v1.0.0-beta.9)

Can somebody please add this to the docs with an example. I think this would be really helpful to a lot of people. @ericvicenti
Thanks for the work you're doing!

@felixus95 did you figure out how to use this feature? I'm trying to use it for replace like functionality (replace a screen in the stack). However, it always routes to the index and doesn't seem to take key into account:
let resetAction = NavigationActions.reset({
    index: 1,
    key: 'Home',
    actions: [
    NavigationActions.navigate({ routeName: 'Home' }),
    NavigationActions.navigate({ routeName: 'SecondScreen' })
    ]
})
this.props.navigation.dispatch(resetAction)

I would expect this to go to the Home screen using the key, however, it goes to the SecondScreen using the index (I assume).

@MrHubble
We are using custom Navigation Actions instead. You should be able to manipulate the index in a way to make it reset/swap like behaviour.
It's documented well in the docs now. But if you have problems hit me up again.

I'm new to React Navigation, and to this issue, but like many others I'm trying to navigate from a "not logged in" to a "logged in" state. I've managed to pull it off using the key, however I really dislike that this drops any form of animation (tested on Android).
// From not logged-in state.
// Animations aren't shown.
        dispatch(NavigationActions.reset({
          index: 0,
          key: null,
          actions: [
            NavigationActions.navigate({
              routeName: 'LoggedIn'
            })
          ]
        }));

What I want is not a replace like others, I want a navigate and reset option, so that the animation works, but once the user has landed on the page, they can't go back to the previous element in the stack. I did try the following, but the result is really odd... The stack ends up being Login -> Home -> Home.
// From Login state.
      dispatch(NavigationActions.navigate({
          routeName: 'Home',
          actions: [
            NavigationActions.reset({
              index: 0,
              key: null
            })
          ]
        }));

This seems like an interesting approach. Now I wonder if my approach is flawed. I like to separate the login/signup stack completely from the app stack, so I have two separate stacks which are selectively rendered in the main render function, like this:
renderInitialRoute() {
  if (this.props.isLoggedInOrAnonymous) {
    return <AppRouter />;
  } else {
    return <LoginRouter />;
  }
}

Of course I don'e get any animations between the stacks, but I'm ok with that.

@MrHubble
It has been a while since I've looked at the code, but I believe the keys are something that are auto generated when you make a new stack. Usually it is something like Init or Init-{id} if I remember correctly. I'm not sure if you can set the keys manually. If you are using Redux to store the navigation state, you can take a look at what the keys are.

My app is structured as an outer TabNavigator, with StackNavigators inside each tab. I’m really struggling to reset the StackNavigator state in another tab than the current one. I had hoped that this PR would do the trick, but I see that it only touches StackNavigator files. Could the logic in this PR be used in TabNavigator too, so that I can reset StackNavigators across TabNavigator boundaries, so to speak?
I might take a stab at a PR if someone can confirm that the functionality I need is just missing, not impossible to implement.


[Doc] Mention how to work with Twig macros in Twig Components

Q
A

Bug fix?
no

New feature?
no

Issues
-

License
MIT

Made during the #SymfonyHackday

Thanks Javier! :)

@javiereguiluz @Kocal
I feel this is how macros work and not something related to HTML syntax (nor components in general)
I have tried quickly and none of this work:

{# Classic embed #}
{% embed 'FooBar.html.twig' %}
    {% block content %}
        {% from _self import message_formatter as embed_formatter %}
        {{ embed_formatter('.abc.') }}
    {% endblock %}
{% endembed %}

{# Component template manually embeded #}
{% embed 'components/Alert.html.twig' %}
    {% block content %}
         ❌ Will not work..
        {% from _self import message_formatter as embed_formatter %}
        {{ embed_formatter('.abc.') }}
    {% endblock %}
{% endembed %}

{# Component tag with implicit "content" block #}
{% component 'Alert' %}
      ❌ Will not work..
    {% from _self import message_formatter as component_formatter %}
    {{ component_formatter('.abc.') }}
{% endcomponent %}

{# Component tag with explicit "content" block #}
{% component 'Alert' %}
    {% block content %}
          ❌ Will not work..
        {% from _self import message_formatter as component_formatter %}
        {{ component_formatter('.abc.') }}
    {% endblock %}
{% endcomponent %}

Did something in particular made you guys think it was due to HTML syntax?
Did i miss something here ?

Did something in particular made you guys think it was due to HTML syntax?

I don't think so.
@javiereguiluz do you have more info about that?

No worries, I should have been more careful too!
Can you revert the PR? Usually I use the button "Revert" from GitHub UI, but I do not see it :/

Changes reverted in #2437.

No need to be sorry of anything 😃  this kind of different behaviours between component tags and HTML syntax is quite frequent.. I was more afraid that something had changed recently / worked before "by chance" etc.
❤


Using these compiled gems with bundle

I compiled a gem successfully but now I want to use it with bundle.
In directory A, I have vendor/cache and into vendor cache I put unf_ext-<IP_ADDRESS>-x86-mingw32.gem, the compiled gem, but when I try to use it with bundle like so:  bundle install --local --path ../vendor --without development, I get this error:
Some gems seem to be missing from your vendor/cache directory.
Could not find unf_ext-<IP_ADDRESS> in any of the sources

So what is the correct way to use these precompiled gems with bundle?

Hello @fxfactorial
I'm not a Bundler expert or understand fully your setup and what you're trying to achieve (or how this relates in any way with gem-compiler or your previous report #25), but going to try to answer.
I created an empty directory and setup, for testing, just unf_ext gem:
https://gist.github.com/luislavena/4c24c4881f071578441eb4876d064a01
With just Gemfile (no lockfile), I proceed to generate the lockfile without installing any gem:
$ ls
Gemfile

$ bundle lock
Fetching gem metadata from https://rubygems.org/.
Fetching version metadata from https://rubygems.org/
Resolving dependencies...
Writing lockfile to ~/code/_sandbox/gem-compiler-issue-26/Gemfile.lock

Inspecting the lockfile will show the contents from the gist liked above.
Now, installing the gems from the bundle:
 $ bundle install --path vendor/bundle
Fetching gem metadata from https://rubygems.org/.
Fetching version metadata from https://rubygems.org/
Using bundler 1.15.4
Fetching unf_ext <IP_ADDRESS>
Installing unf_ext <IP_ADDRESS> with native extensions
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Bundled gems are installed into ./vendor/bundle.

Notice Installing unf_ext <IP_ADDRESS> with native extensions, this means it installed the ruby platform gem (no platform in the gem) and then proceeded to compile.
Doing bundle package now will place unf_ext-<IP_ADDRESS>.gem in vendor/cache:
 $ bundle package
Using bundler 1.15.4
Using unf_ext <IP_ADDRESS>
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Bundled gems are installed into ./vendor/bundle.
Updating files in vendor/cache
  * unf_ext-<IP_ADDRESS>.gem

$ ls vendor/cache/
unf_ext-<IP_ADDRESS>.gem

Now, going to produce a native gem for my current platform (x86_64-linux) and place the precompiled version inside the cache:
$ gem compile vendor/cache/unf_ext-<IP_ADDRESS>.gem
Unpacking gem: 'unf_ext-<IP_ADDRESS>' in temporary directory...
Building native extensions.  This could take a while...
... lot of warnings due dependencies ...
  Successfully built RubyGem
  Name: unf_ext
  Version: <IP_ADDRESS>
  File: unf_ext-<IP_ADDRESS>-x86_64-linux.gem

$ mv unf_ext-<IP_ADDRESS>-x86_64-linux.gem vendor/cache/

$ ls vendor/cache/
unf_ext-<IP_ADDRESS>.gem  unf_ext-<IP_ADDRESS>-x86_64-linux.gem

Next, going to remove the installed bundle (from vendor/bundle used during bundle install) and proceed to install using --local flag:
$ rm -rf vendor/bundle/

$ bundle install --local
Using bundler 1.15.4
Installing unf_ext <IP_ADDRESS> (x86_64-linux)
Updating files in vendor/cache
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Bundled gems are installed into ./vendor/bundle.

Notice how this time the gem was not compiled but instead the pre-compiled binary was used instead.
From your report, seems you don't have the non-platform specific gem, or maybe you're just adding the platform specific (windows) to vendor/cache and not the non-precompiled one, not sure.
This is as far I can go on this since this relates more to Bundler and how it works than gem-compiler itself.
I will recommend you reach out to Bundler for support (see here)
Hope that helps.
Cheers.


Time for training a new style

Hi,
I am using p2.xlarge in AWS (NVIDIA K80 GPU, 61GB RAM , 128GB Space). To check it out I was using COCO's val2017(5K images). It downloaded the vgg-model file and it has been blank for a very long while.
0.How much time does it take to get trained for 5000 images?
1.Also when I am trying to kill the python process with "kill -9 PID", it is not getting killed, is it because of the multi threading ? How do I end the training process in between ?
--> I am able to run 'eval' option using cuda 1 and it takes about 1-2 seconds to generate output images. So I am assuming all the package installations are fine on my side.
Please help me resolve the issues.

It should be able quite fast on 5000 images, if you want to see if it starts training or not modify the --log-interval parameter to 1 and see if output messages are printed. Also run the training command using the unbuffered parameter position: python -u train.py..., you can test training with a batch size of 1 on your local laptop/desktop to check if everything is working correctly before running on AWS.

@abhiskk How many images should we use when training a new model?
Is it worth it to go over 10K, 20K, 80K images?

@glesperance you can get good results with around 10K images.


Docs/lakefs setup with dynamodb

First go - Updated lakeFS deployement on AWS with DynamoDB

closes #3895

See comments inline. I don't think we should merge it to master, it also includes many irrelevant commits.

@itaiad - merge target branch modified to reflect the original base. Thanks for pointing this out


test: refactor source e2e tests with "inline" style

In https://github.com/risingwavelabs/risingwave/pull/12344, we introduced an "inline" style for writing source e2e tests. Basically, it consists of two points:

Interacting with external systems by executing system commands with system ok.
https://github.com/risingwavelabs/risingwave/blob/08b72f6f3a3d749f2b0f46f861d5de0fb0b5a3f5/e2e_test/source/cdc_inline/alter/postgres_alter.slt#L3-L7
Furthermore, by setting the environment variables like PGHOST, PGPORT, PGPASSWORD, we can avoid repeating them in the commands.

Using environment variables in SQL. Enable this with control substitution on.
https://github.com/risingwavelabs/risingwave/blob/4f7ea7112c8db6c94c01f762fad1ce1477be608d/e2e_test/source/cdc_inline/alter/postgres_alter.slt#L9-L21
By also leveraging the canonical environment variables with psql client, we make the CDC table definition here consistent with the psql system commands. Also, setting default values for these variables allows for painless local execution of the test cases.

This can be much clearer and more flexible than writing the test logic in shell scripts inside ci/scripts, where sqllogictest must be interleaved with psql or mysql calls. This also empowers the tests with complicated procedures, like schema change on both sides.

More aggressively, to further simplify the test scripts, I think we don't need to provide a default value at all. As mentioned https://github.com/risingwavelabs/risingwave/issues/15995#issuecomment-2029171270, it can be loaded via risedev slt.
And we can define a large env var like
WITH_OPTIONS_PG="
     connector = 'postgres-cdc',
     hostname = '...',
     port = '...',
     username = '...',
     password = '...',
     database.name = '...'
"

I want to elaborate the motivation and some further designs (according to recent discussions with @BugenZhao), to explain why "inline" style is a good idea.
Motivation
A good test framework should have these characteristics:

We can run tests easily both in CI and locally.
Otherwise if the setup is too complex for local run, when we need to add new tests or new features (especially if the developer is not the original writer of the tests, or is even new to the module), we will just wait for CI. And if it failed, we just make some new random attempts and pray it works. (low productivity) And consequentially, we are not willing to write new tests. (lack of test cases)
We can write tests easily.
Otherwise, we don't want to write new tests. And when we write, we only write very simple cases. (lack of complex cases)

We do have all these problems above (bold font).
Our current test pipeline is like this:
The entrypoint is: ci/scripts/e2e-source-test.sh. It run some setup scripts or commands, and then run the slt test cases.
For each kind of connector (actually even each test cases of the same connector), we run test cases in different commands. This is much worse compared with './e2e_test/streaming/**/*.slt' https://github.com/risingwavelabs/risingwave/blob/8b09aeb30504bcf409b3fc5355d6783d98af89c1/ci/scripts/e2e-source-test.sh#L166-L175
Specifically, the main problems are:
a. Test cases (slt) and setup scripts (sh) are put in different places. So test cases themselves are not understandable, and not runnable for new developers (even for original authors themselves as time passes by).

Note that setup scripts are all over the place:

e2e_test/source
scripts/source
ci/scripts/run-e2e-test.sh

b. We can only run setup script, and then run test case, instead of alternately executing commands between external systems and RisingWave. So some complex scenarios like split change are not well tested.
c. The setup scripts hardcoded ports like kafka-topics.sh --bootstrap-server message_queue:29092, so they are not for local run at all.
Now imagine if I'm a new developer, to run a specific test.slt, I need to

start RisingWave (mainly via risedev d)
start external service
set up data in external service for test.slt (if I can find it)
run test.slt

Note that step 3 & 4 are not always available as the scripts hardcoded the ci env.
Proposed Solution
The system command, as proposed by the original issue, is a good idea to solve most of the problems:

For problem a, it puts setup scripts and test cases in the same file.
For problem b, it changes the mindset from "setup scripts" to "commands", making it more composable, and easier to construct more complex cases.
For problem c, it uses environment variables to make it configurable.

Essentially, it merges previous step 3 & 4:

start RisingWave (mainly via risedev d)
start external service
(new step) set environment variables of the external service
run test.slt (with system commands)

It provides a good foundation, but still not perfect enough.

The new step 3 above is still a little troublesome. We need to find what ports are used by the services, find what env vars are used in the test script, and set it correctly. Can we do it automatically?
When testing, we usually want to setup a clean environment, or frequently clean the environment. This is not convenient e.g., if we are using Postgres on Mac with brew services.

So we can go one step further.
Enhancement 1: Integrate external services with RiseDev
If a service is managed by RiseDev (more precisely, risedev-dev)

We can save the trouble of setting envvars or CLI args.
This is inspired by using risedev psql to simplify psql -h localhost -p 4566 -d dev, and similarly risedev slt. (This is achieved by loading risedev-env file, which is written when risedev d is called)
We can easily destroy and start a clean environment.

Take the test case in the original post as an example,
https://github.com/risingwavelabs/risingwave/blob/f31698df52575e0e43d11147cf515bac262d325f/e2e_test/source/cdc_inline/alter/postgres_alter.slt#L3-L21
Assume we have postgres in risedev.yml, then we will write PGPORT etc in risedev-env, and load risedev-env in the slt` task.
With this, our testing workflow will become as simple as:

start RisingWave and external services via risedev d
run test.slt via risedev slt

How to manage external systems in RiseDev?
One challenge is some services are hard to configure and start; another challenge is that CI uses docker-compose, but local RiseDev doesn't.
If we restart from scratch now (with lightweight containers like orb in Mac), maybe we will choose to let risedev-dev be a thin wrapper over docker-compose. But changing it requires some hard work now.
The genius idea we have is user-managed. Previously we use this to debug RisingWave components; now we can use this to fake the service is managed by RiseDev, and provide necessary environment variables. Alternatively, we may also have something like risedev-env.user to provide env vars, but put everything in risedev.yml one place can be better.
In CI, we also don't need to provide a fake risedev-env (as we do in some places now), and just use user-managed services.
Locally,

For new services like mysql, postgres, we can let them be user-managed only services.
In the future, we can support starting them via docker compose backend for Risedev. We can do this in a very progressive manner.

Enhancement 2: Further simplify test script writing with RiseDev envs and commands (optional)
The env vars simplified running tests a lot, but when writing tests, there are still a lot of copy-pasting.
Solution:

We can define a large env var like below to simplify WITH optionsRISEDEV_WITH_OPTIONS_PG_COMMON="
     connector = 'postgres-cdc',
     hostname = '...',
     port = '...',
     username = '...',
     password = '...',
     database.name = '...'
"

Not all command line tools support environment variables like psql, e.g., we might need to copy-paste kcat -b ${RISEDEV_KAFKA_BOOTSTRAP_BROKERS} .... We can simplify this with risedev kcat.

Example: Integrate Kafka
https://github.com/risingwavelabs/risingwave/pull/16244
What's changed in this PR:

Support user-managed kafka in risedev.yml. This is mainly for CI env. For local env we have native Kafka.
Add new risedev-env vars: RISEDEV_KAFKA_BOOTSTRAP_SERVERS, RISEDEV_KAFKA_WITH_OPTIONS_COMMON, RPK_BROKERS
New test https://github.com/risingwavelabs/risingwave/pull/16244/files#diff-1ab35726d1a9569223d3c3460801d24d581cafc8e03371236a4ca2e17e6adf64 uses rpk to write system commands for Kafka, and rpk uses env var RPK_BROKERS. It is nothing different from the other "inline" tests like psql.
Added some helpful risedev commands. They can be used by slt tests (but not used yet), and also run manually.

Discussions
One may argue that most of the trouble we have is because the setup sh scripts are not well written, and are scattered. If we can rewrite them in a good shape (including supporting local run) and put them in one single place, it will be good enough, and there's no need to introduce a new framework.
Although there are some additional benefits mentioned above that is not achievable by good bash scripts only, the argument makes some sense to me. But my feeling is that this is somehow similar to "with C++ we can do good things, so there's no need to change to Rust". The reality is developers are not good at writing and organizing scripts. With the new framework, developers are encouraged to write composable commands to create complex test scenarios and prepare the setup not only for CI but also for local run.
Limitations
I don't find anything not achievable yet. Comments are welcome.

P.S. We don’t need to rewrite existing tests into the new style any time soon. We can just write new tests and/or copy-on-write old tests.
P.P.S. I think this idea also applies to sink tests.

One may argue that most of the trouble we have is because the setup sh scripts are not well written, and are scattered. If we can rewrite them in a good shape (including supporting local run) and put them in one single place, it will be good enough, and there's no need to introduce a new framework.

Interestingly, when DocSlt was introduced, you had very similar comment😄: https://github.com/risingwavelabs/risingwave/issues/5117#issuecomment-1237389589.
Btw, I strongly +1 for this proposal, just because of the same reason I introduced DocSlt at that time. Not everyone (actually I think only a few of us) can write good and clean shell scripts, and also many don't like to write comments like "refer to xxx.sh for the source setup process". It can be way more clear to put setup and teardown process together with the test body.

Is it possibly to execute risedev kill or other risedev commands in the .slt file (aka. the inline style)? Because we also need to test recovery scenario in the e2e source test.

Is it possibly to execute risedev kill and other risedev commands in the .slt file (aka. the inline style)? Because we also need to test recovery scenario in the e2e source test.

Currently not possbile, because one slt corresponds to one database session. It's possible to extend sqllogictest-rs to support sth like --recreate-session.
Alternatively, the newly supported RECOVER command might be OK, if the frontend is not killed.

Other risedev commands is completely OK.

Interestingly, when DocSlt was introduced, you had very similar comment😄: #5117 (comment).

Yes, when I wrote this, I was also thinking about me opposing to DocSlt. 😄
Actually, the "inline" connector e2e tests have a lot in common with DocSlt:

very simple idea, and easy to implement (so workload/ROI is not an issue)
both try to put scattered stuff in one place.

I changed my mind about DocSlt because of the fact that DocSlt (perhaps along with @wangrunji0408 's expr macro) together made it much painless to add new expressions -- we just need to change one file for everything. And the result is we added many new (tested) expressions.
So smooth DX matters, a lot. I'd like to quote "Why Care About Build Times":

That being said, compilation time is a multiplier for basically everything. Whether you want to ship more features, to make code faster, to adapt to a change of requirements, or to attract new contributors, build time is a factor in that.
It also is a non-linear factor. Just waiting for the compiler is the smaller problem. The big one is losing the state of the flow or (worse) mental context switch to do something else while the code is compiling. One minute of work for the compiler wastes more than one minute of work for the human.

I'm feeling that testing is also a multiplier for developing features.


fix: indy dependency version format

Fix python-indy version restrictions format.
Previous format was breaking for poetry-based builds: Invalid constraint (python3-indy (>=1.11.1<2) ; extra == 'indy') found in aries-cloudagent-1.0.0rc1 dependencies, skipping
Version restrictions are supposed to be conformant to: https://peps.python.org/pep-0440/#version-specifiers
Signed-off-by: Clément Humbert<EMAIL_ADDRESS>

@chumbert -- the branch is still out of date.  Not sure why, but there is no magic "update branch" button. :-(


[pt-br] Add docs/concepts/architecture/cri.md

Hello everyone,
Brazilian portuguese translation for the Container Runtime Interface page.
Related issues
https://github.com/kubernetes/website/issues/13939

Hello there, @AnaCarolinaRodriguesLeite!
Thank you very much for your contribution! 🎉
It looks like the website requires us to provide glossary entries translated for use with the glossary_definition shortcode. Could you please translate the container-runtime-interface glossary entry and add it in this pull request?
I'll be back for review once this is done. I'm holding the PR for now, feel free to /unhold it yourself once this is added.
Thanks again!
/hold
/cc

Hi @AnaCarolinaRodriguesLeite!
Thanks for your contribution!
Try to keep the "título" and "tipo de conteúdo" in English. I think the bot doesn't recognize these words written in Portuguese.
would be like this:
título -> title
tipo de conteúdo -> content_type

/unhold

/retitle [pt-br] Add docs/concepts/architecture/cri.md

Hi there, @AnaCarolinaRodriguesLeite!
It seems two new files were added to this branch. I don't think they belong here (and it also seems like their content was fully removed). Could you please revert this change?
/hold

Hello Mauren Berti, how are you?
I tried reverting the file that wasn't part of it and I think I didn't do the right thing. But I believe that all changes are here. Can you check?

Hi again, @AnaCarolinaRodriguesLeite!
It seems after your latest force-push the debug-init-containers.md file reappeared here. I'm suspecting that might be because you added that file to another branch that you're now using to rebase this branch.
The other two files are still around in this branch as well. If they stay, two empty files will be created in the project. Therefore, I cannot approve this pull request until this issue has been solved.
If fixing this branch is too difficult, perhaps closing this pull request and opening a new one with the content for CRI might be an easier path.
May I suggest that you create a separate branch with the three files that we want to merge for CRI (pt-br/docs/concepts/architecture/cri.md, pt-br/docs/reference/glossary/container-runtime-interface.md, and pt-br/docs/reference/glossary/cri.md) and then create a new pull request with that content?
If you need any help with this process please don't hesitate to reach out to the localization team on Kubernetes Slack (channel #kubernetes-docs-pt).

Hello Mauren Berti,
So... I tried to do what you suggested and I think it might not have worked. Could see?
https://github.com/kubernetes/website/pull/38962

I think I couldn't do it, I created the new branch but still, the files are not where they should be.

Would you help me?

Hi there, @AnaCarolinaRodriguesLeite!
Can you send me a message on Slack (Kubernetes Slack)?
I can help you figure out what is going on.


ImageBlock

when i click on an image at a particular index in collection view that moment i want to download a high resolution image and pass that image in the imageviewer.
unitl the image downloads the screen gets stuck and doesn't present the image controller

Hi @hbhasin1,
Could you provide us with a code sample of what you exactly are trying todo? The first thing which pops to my mind is that you do the download of the high-res image on the main- thread which blocks the UI before animating further.
Could you check if you are downloading on the main thread, instead of a background thread?

func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
        let configuration = ImageViewerConfiguration { config in
            if let url: String = self.cloneProductListDataObj?.images[indexPath.row].largeResolutionImgSrc {
                let urlStr: String = url.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed)!
                if let searchURL = URL(string: urlStr) {
                    if let imageData : Data = try? Data(contentsOf: searchURL) {

                        config.image = UIImage(data: imageData, scale: 1.0)
                    }
                }
            }
        }
        present(ImageViewerController(configuration: configuration), animated: true)
    }

This is what i am doing on collection view didSelect method

Yes, so as I was mentioning before. You are doing the download on the main-thread, this blocks the UI from performing the transition- animation.
Ideally you have the image already downloaded or set the image after it's downloaded in the background.
@LcTwisk Any ideas how to keep a nice transition from the gallery to the imageviewer and replace the original image with the downloaded version?

Hi @eelcokoelewijn-afrogleap!
That's where the imageBlock prop is for:
        let configuration = ImageViewConfiguration { config in             config.imageBlock = { block in                 if let url = self.cloneProductListDataObj?.images[indexPath.row].largeResolutionImgSrc,                     let urlStr = url.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed),                     let searchURL = URL(string: urlStr) {                     URLSession.shared.dataTask(with: url) { data, response, error in                         guard let data = data, let image = UIImage(data: data) else { return }                         DispatchQueue.main.async() {                             block(image)                         }                     }                 }             }         }         present(ImageViewerController(configuration: configuration), animated: true)

@hbhasin1 Can you check if the purposed solution by @LcTwisk ☝ and see if your issue is resolved?

let configuration = ImageViewerConfiguration { config in
config.imageBlock = { block in
if let url = self.cloneProductListDataObj?.images[indexPath.row].largeResolutionImgSrc, let urlStr = url.addingPercentEncoding(withAllowedCharacters: .urlQueryAllowed), let searchURL = URL(string: urlStr) {
URLSession.shared.dataTask(with: searchURL) { data, response, error in guard let data = data, let image = UIImage(data: data) else { return }
self.cloneProductListDataObj?.images[indexPath.row].imgData = data
DispatchQueue.main.async {
block(image)
}
}
}
}
}
self.present(ImageViewerController(configuration: configuration), animated: true)
Did same exactly but didn't work

@hbhasin1 Could you be a bit more specific on what didn't work? Do you still have the same behaviour, where the UI is stuck until the image is downloaded? If possible could you provide us with a sample project including the code you are using now?

@hbhasin1 Did the missing resume() fix-it?

Yes that fixed the issue.
and is there any way to give background color to the image viewer?
Thanks


Fix markup for a ASDL grammar link

I suggest to correct a bit of text for proper Markdown formatting.
-The abstract syntax trees are automatically generated from the ASDL
-grammar used in the
-[https://github.com/python/cpython/blob/main/Parser/Python.asdl](CPython
-implementation).
+The abstract syntax trees are automatically generated from [the ASDL grammar which is used in the CPython implementation](https://github.com/python/cpython/blob/main/Parser/Python.asdl "Abstract-type and scheme-definition").

Fixed. Thanks!


chore(version): 0.1.0

Codecov Report

Merging #27 (c49f2c5) into main (7cd3b5d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   96.66%   96.66%
=======================================
  Files           1        1
  Lines          90       90
=======================================
  Hits           87       87
  Misses          2        2
  Partials        1        1


SEPG Automated Release - v3.1.0

SEPG Details
Release Build Link: http://sou-jenkins2.swinfra.net:8080/job/Auto-Release/431/
Build Token: github.com/CAFapi/buildenv-dotnet-image/master/ae84f681b6cf2803209598ec18d561607eeea494
Versioning Behaviour: Roll on to next minor
Artifacts For Release
Docker

cafapi/buildenv-dotnet:3.1.0 (Static Tag)
cafapi/buildenv-dotnet:3.1 (Dynamic Tag)
cafapi/buildenv-dotnet:3 (Dynamic Tag)
cafapi/buildenv-dotnet:latest (Dynamic Tag)

 Build Stage
Action
Status

Release Checks
completed
:heavy_check_mark:

Gather Release Data

:white_small_square:

QA Documentation Site Deployment

:white_small_square:

QA Deployment Branch Promotion

:white_small_square:

Docker Image Promotion

:white_small_square:

Maven Artifact Promotion (Closed Source)

:white_small_square:

NuGet Artifact Promotion

:white_small_square:

Artifactory Release Artifact Tagging

:white_small_square:

Generic Artifact Promotion

:white_small_square:

Maven Artifact Promotion (Open Source)

:white_small_square:

Maven Staging Repository Removal (Open Source)

:white_small_square:

Git Tagging

:white_small_square:

Git Release

:white_small_square:

Git Release Asset Deployment

:white_small_square:

Pull Request Merge

:white_small_square:

Release Branch Deletion

:white_small_square:

view the build log here


Warning: Failed prop type: Link: unknown props found: forwardedRef

Bug description
I'm not sure it's a bug or not. But I've been digging around for a while and couldn't find any solution. Here is what happens in console. (The generated link is just fine and working)
Warning: Failed prop type: Link: unknown props found: forwardedRef

This only happens when I'm trying to use Link exported from i18n.js config file. If I import it from 'next/link' no warning happens. This is i18n.js file:
const NextI18Next = require('next-i18next').default;
const locales = require('./static/locales');

const otherLanguages = [];
const localeSubpaths = [];

Object.keys(locales).map(value => {
  otherLanguages.push(value);
  localeSubpaths[value] = value;
  return true;
});

const NextI18NextInstance = new NextI18Next({
  defaultLanguage: locales.en.value,
  otherLanguages,
  ignoreRoutes: ['/_next/', '/static/', 'robots.txt'],
  localeSubpaths: { ...localeSubpaths }
});

module.exports = NextI18NextInstance;

Occurs in next-i18next version
^2.0.0
Steps to reproduce
I'm using styled-component. Not sure it's relevant or not. However, this is the code that make this happen:
<Link href="/">

        <Logo src="/img/logo.svg" />

</Link>

This will produce a tag like below which is working fine:

I'm using styled-component. Not sure it's relevant or not

It clearly is, based on that stack trace. Let me know if you investigate further!

I guess It was a problem with the dependencies. I did the steps below to fix the issue.

I removed node_modules directory.
I checkout to the commit that everything was working fine
On that stage I installed the dependencies that I need for the next commits (react-select, toastify, ...)
I copied the content of package.json and indeed yarn.lock to a temp file.
I checked out to the last commit. And replaced the package.json and yarn.lock with the copied content.
I installed dependencies again with the new package.json and yarn.lock.

The warning is now gone and code is working correctly. I'm not sure why this issue happened. But my guess is, It happened due to a mess in yarn.lock file.

I've installed a clean version of my app, and got react-i18next 11.2.1, since then I get the same warning.
I've checked the changes log, and saw this PR that passes this new prop to Link component.
We should filter it out, WDYT? should I PR it?

@felixmosh PRs welcome!

@felixmosh PRs welcome!

https://github.com/isaachinman/next-i18next/pull/563 :]


Error Domain=kCFErrorDomainCFNetwork Code=-1205 "The server “” did not accept the certificate."

i have problem with iOS 11 with cer.
Error Domain=NSURLErrorDomain Code=-1205 "The server "" did not accept the certificate." UserInfo={NSURLErrorFailingURLPeerTrustErrorKey=<SecTrustRef: 0x60000010dec0>, _kCFStreamErrorDomainKey=3, _kCFStreamErrorCodeKey=-9834, NSUnderlyingError=0x6040002590e0 {Error Domain=kCFErrorDomainCFNetwork Code=-1205 "The server "" did not accept the certificate." UserInfo={NSErrorFailingURLStringKey=https:///content?id_TERMS_PRIVACY, _kCFNetworkCFStreamSSLErrorOriginalValue=-9834, kCFStreamPropertySSLPeerCertificates=(
"<cert(0x7ff5cc0b9c00) s:  i: DigiCert SHA2 Secure Server CA>",
"<cert(0x7ff5cc0bb400) s: DigiCert SHA2 Secure Server CA i: DigiCert Global Root CA>",
"<cert(0x7ff5cc08f200) s: DigiCert Global Root CA i: DigiCert Global Root CA>"
), _kCFStreamPropertySSLClientCertificateState=2, kCFStreamPropertySSLPeerTrust=<SecTrustRef: 0x60000010dec0>, NSLocalizedDescription=The server  did not accept the certificate., _kCFStreamPropertySSLClientCertificates=(
"<SecIdentityRef: 0x60000022d880>",
"<cert(0x7ff5cb50e360) s:  i: DigiCert SHA2 Assured ID CA>",
"<cert(0x7ff5cc09ee00) s: DigiCert SHA2 Assured ID CA i: DigiCert Assured ID Root CA>",
"<cert(0x7ff5cc09f800) s: DigiCert Assured ID Root CA i: DigiCert Assured ID Root CA>"
), _kCFStreamErrorDomainKey=3, NSErrorFailingURLKey=https://content?id=_TERMS_PRIVACY, _kCFStreamErrorCodeKey=-9834}}, NSErrorPeerCertificateChainKey=(
"<cert(0x7ff5cc0b9c00) s: i: DigiCert SHA2 Secure Server CA>",
"<cert(0x7ff5cc0bb400) s: DigiCert SHA2 Secure Server CA i: DigiCert Global Root CA>",
"<cert(0x7ff5cc08f200) s: DigiCert Global Root CA i: DigiCert Global Root CA>"
), NSErrorClientCertificateChainKey=(
"<SecIdentityRef: 0x60000022d880>",
"<cert(0x7ff5cb50e360) s:  i: DigiCert SHA2 Assured ID CA>",
"<cert(0x7ff5cc09ee00) s: DigiCert SHA2 Assured ID CA i: DigiCert Assured ID Root CA>",
"<cert(0x7ff5cc09f800) s: DigiCert Assured ID Root CA i: DigiCert Assured ID Root CA>"
), NSLocalizedDescription=The server did not accept the certificate., NSErrorFailingURLKey=https:///content?id=_TERMS_PRIVACY, NSErrorFailingURLStringKey=https:///content?id=_TERMS_PRIVACY, NSErrorClientCertificateStateKey=2}

@sallyahmed I've got the same issue.Did you find the solution?

hello,I have the same problem.Did you solve it?

You should make sure that your server support TLS v 1.2
After updating app works great

For general help, please ask on StackOverflow.

@sallyahmed is right!


Fix LandingPagesNavigation undefined style bug

fix undefined style bug

@gkLeo Could you please add a little context on how to reproduce the issue? Thanks!

@gkLeo Could you please add a little context on how to reproduce the issue? Thanks!
@adoprog Modify the GridParameters of the Navigation rendering to empty on /landing-pages (/sitecore/content/PLAY/playwebsite/home/landing-pages), also make sure that the Styles is also empty, then save the changes and open the /landing-pages (https://www.xmcloudcm.localhost/landing-pages), 2 'undefind' classes are rendered in FE.