importlib_metadata.PackageNotFoundError: jeepney

We run pipenv update --dev in our CI pipeline for a while now. After pipenv 2022.9.8 bumped its version of pipdeptree #5343 , we are now getting the following stacktrace which seems related to your recent change.
If I were to guess, it looks like you are catching ImportError but not importlib_metadata.PackageNotFoundError.
[2022-09-08T16:20:55.706Z] pipenv update --dev
[2022-09-08T16:20:55.961Z] Running $ pipenv lock then $ pipenv sync.
[2022-09-08T16:20:55.962Z] Locking [packages] dependencies...
[2022-09-08T16:20:55.962Z] Locking [dev-packages] dependencies...
[2022-09-08T16:20:55.962Z]
Building requirements...
[2022-09-08T16:20:55.962Z]
Resolving dependencies...
[2022-09-08T16:21:01.205Z]
FAIL
[2022-09-08T16:21:01.205Z]
[2022-09-08T16:21:01.205Z] Traceback (most recent call last):
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/resolver.py", line 867, in <module>
[2022-09-08T16:21:01.205Z]     main()
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/resolver.py", line 862, in main
[2022-09-08T16:21:01.205Z]     dev=parsed.dev,
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/resolver.py", line 834, in _main
[2022-09-08T16:21:01.205Z]     pre, clear, verbose, system, write, requirements_dir, packages, dev
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/resolver.py", line 794, in resolve_packages
[2022-09-08T16:21:01.205Z]     results = clean_results(results, resolver, project, dev)
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/resolver.py", line 651, in clean_results
[2022-09-08T16:21:01.205Z]     reverse_deps = project.environment.reverse_dependencies()
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 730, in reverse_dependencies
[2022-09-08T16:21:01.205Z]     for req in self.get_package_requirements():
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 710, in get_package_requirements
[2022-09-08T16:21:01.205Z]     return [self._get_requirements_for_package(p, key_tree) for p in nodes]
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 710, in <listcomp>
[2022-09-08T16:21:01.205Z]     return [self._get_requirements_for_package(p, key_tree) for p in nodes]
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 685, in _get_requirements_for_package
[2022-09-08T16:21:01.205Z]     for c in get_children(node)
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 686, in <listcomp>
[2022-09-08T16:21:01.205Z]     if c.project_name not in chain
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 685, in _get_requirements_for_package
[2022-09-08T16:21:01.205Z]     for c in get_children(node)
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 686, in <listcomp>
[2022-09-08T16:21:01.205Z]     if c.project_name not in chain
[2022-09-08T16:21:01.205Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/environment.py", line 673, in _get_requirements_for_package
[2022-09-08T16:21:01.205Z]     d = node.as_dict()
[2022-09-08T16:21:01.206Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/pipdeptree/__init__.py", line 241, in as_dict
[2022-09-08T16:21:01.206Z]     "installed_version": self.installed_version,
[2022-09-08T16:21:01.206Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/pipdeptree/__init__.py", line 205, in installed_version
[2022-09-08T16:21:01.206Z]     return guess_version(self.key, self.UNKNOWN_VERSION)
[2022-09-08T16:21:01.206Z]   File "/usr/local/lib/python3.7/site-packages/pipenv/vendor/pipdeptree/__init__.py", line 49, in guess_version
[2022-09-08T16:21:01.206Z]     return importlib_metadata.version(pkg_key)
[2022-09-08T16:21:01.206Z]   File "/root/.local/share/virtualenvs/cd.yml-X1meJv26/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 553, in version
[2022-09-08T16:21:01.206Z]     return distribution(distribution_name).version
[2022-09-08T16:21:01.206Z]   File "/root/.local/share/virtualenvs/cd.yml-X1meJv26/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 526, in distribution
[2022-09-08T16:21:01.206Z]     return Distribution.from_name(distribution_name)
[2022-09-08T16:21:01.206Z]   File "/root/.local/share/virtualenvs/cd.yml-X1meJv26/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 194, in from_name
[2022-09-08T16:21:01.206Z]     raise PackageNotFoundError(name)
[2022-09-08T16:21:01.206Z] importlib_metadata.PackageNotFoundError: jeepney

I actually did consider catching that separately, but skipped it because PackageNotFoundError is already a subclass of ImportError
https://github.com/python/importlib_metadata/blob/53e42d6d70bd2068cd5bf0d351df89aa3cc0af31/importlib_metadata/__init__.py#L51
But looks like it wasn't a subclass of ImportError the past, it was changed 3 years ago in version 0.13 https://github.com/python/importlib_metadata/commit/73651fd9b8df0c9c79de087b61246294bf89418f
And if we go even farther back in time then PackageNotFoundError didn't even exist https://github.com/python/importlib_metadata/commit/12a1e5da835d5552c113497c465553cd8df57858.
So maybe the fix should be to except Exception to handle all problems with importlib_metadata API changes.
You can also fix this on your end by using a newer version of importlib_metadata.

Actually I was wrong about the 3 years ago thing, the BaseClass is either ImportError or ModuleNotFoundError (which is subclass of ImportError) even in the original version that introduced PackageNotFoundError https://github.com/python/importlib_metadata/blob/12a1e5da835d5552c113497c465553cd8df57858/importlib_metadata/api.py#L7-L10.
So not sure why you get the error, and probably updating importlib_metadata won't help you.

I see your point and it is backed up by https://docs.python.org/3.7/library/exceptions.html#ImportError
In the meantime, we are pinned to pipenv==2022.9.4 which is using pipdeptree==2.2.1


Added userInfo and changed interface for request execution

This is a convenience change on interface for request to enable configuration with userInfo dictionary
Issue: https://github.com/aronbalog/Vox/issues/3

Codecov Report

Merging #4 into master will increase coverage by 0.06%.
The diff coverage is 77.27%.

@@            Coverage Diff            @@
##           master      #4      +/-   ##
=========================================
+ Coverage   90.14%   90.2%   +0.06%
=========================================
  Files          31      31
  Lines        2091    2104      +13
=========================================
+ Hits         1885    1898      +13
  Misses        206     206

Impacted Files
Coverage Δ

...ox/Plugins/Alamofire/JSONAPIClient_Alamofire.swift
97.91% <100%> (ø)
:arrow_up:

Vox/Core/Networking/Class/Request.swift
75.47% <100%> (+0.47%)
:arrow_up:

VoxTests/DataSource/PaginationSpec.swift
82.41% <100%> (ø)
:arrow_up:

VoxTests/DataSource/DataSourceSpec.swift
86.89% <70.58%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e02efd5...99d62c4. Read the comment docs.


DOC mistakes

nonempty(n, "empty!", "not empty!") inserts "empty!" if insert n is empty, "not empty!" if it isn't

nonempty(n, "non empty!", "empty!") makes sense in fact
https://github.com/L3MON4D3/LuaSnip/blob/c599c560ed26f04f5bdb7e4498b632dc16fb9209/lua/luasnip/extras/init.lua#L131-L147

Some other mistakes in the documentation are found too. I can open a PR to fix them.

Ohh, yes you're right, easy to get confused with wording there :P
Please do, I very much appreciate improvements to the documentation :)

The sentence in here is hard to understand:

multiline_vars: (fn(name:string)->bool)|map[sting, bool]|bool Says if certain vars are a table or just a string, can be a function that get's the name of the var and returns true if the var is a key, a list of vars that are tables or a boolean for the full namespace, it's false by default.

Why we need that argument? It would be better to add an example for it.
I found a snippet in the test suits:
https://github.com/L3MON4D3/LuaSnip/blob/c599c560ed26f04f5bdb7e4498b632dc16fb9209/tests/integration/dynamic_spec.lua#L301-L322
The expansion is:
1..1
2..2..

which I still don't understand, because

a list of string is passed in multiline_vars, which doesn't belong to (fn(name:string)->bool)|map[sting, bool]|bool
if the line of multiline_vars is commented, the expansion is the same

Why we need that argument?

That's a bit involved :sweat_smile::
With regular expansion multiline_vars does not make a difference, it becomes necessary once get_docstring() is called on some snippet. This function tries to expand the snippet without actually having a buffer to work with, and returns an accurate string-representation of the snippet.
This expansion also includes evaluating dynamicNodes, so their functions have to still work when called in this static (that's how it's called in most of the codebase, basically without a correct associated buffer) context.
So, we make some effort to have as many functions as possible still work as-is.
One of these efforts is replacing the value of variables (because stuff like TM_FILENAME cannot be filled accurately when there is no buffer) with their name (parent.snippet.env.TM_FILENAME -> "$TM_FILENAME") (see fake_env) (This has the added benefit of leading to more descriptive docstrings)
Now, there's a problem: We want to avoid errors when evaluating functions, but functions can contain both code like parent.snippet.env.STRING_VAR .. "some string" and parent.snippet.env.MULTILINE_VAR[1], but both should still evaluate successfully when get_docstring()d.
So, we have to return the expected type from fake_env, but we don't know which type a variable has (string vs string[]), until we evaluate the variable, which we probably don't want to do in that "static" context. Because of that we require that namespaces announce which of their variables are tables, and which are strings (this is implicit ofc.), so we can return the correct type from fake_env.
You can see the difference by calling print(snip.get_docstring()[1]) on that snippet (here both run successfully, just the # returns a different number)
I agree that some motivation for this option should be given, a link to this comment might do it.

a list of string is passed in multiline_vars, which doesn't belong to (fn(name:string)->bool)|map[sting, bool]|bool

Ouh, yeah, string[] should be appended to it :sweat_smile:

It's much clear for me after some local testing:
No multiline_vars
ls.env_namespace("DYN", {
  vars = { ONE = "1", TWO = { "1", "2" } },
})

And given the same function node:
ls.add_snippets("all", {
  s("dyn_addsnip", d(1, function(args, parent)
    return sn(nil, {
      t(parent.snippet.env.DYN_ONE),
      t "..",
      t(table.concat(parent.snippet.env.DYN_TWO)),
      t "..",
      t(tostring(#parent.snippet.env.DYN_TWO)), -- This one behaves as a table
      t "..",
      t(parent.snippet.env.WTF_YEA), -- Unknow vars also work
    })
  end, {}))
})

local dyn = s("dyn_return", d(1, function(args, parent)
  return sn(nil, {
    t(parent.snippet.env.DYN_ONE),
    t "..",
    t(table.concat(parent.snippet.env.DYN_TWO)),
    t "..",
    t(tostring(#parent.snippet.env.DYN_TWO)), -- This one behaves as a table
    t "..",
    t(parent.snippet.env.WTF_YEA), -- Unknow vars also work
  })
end, {}))

return { dyn }

Run both of thme and we get the same result 1..12..2.., which works perfectly.
multiline_vars is a must
However if we use get_docstring without multiline_vars, like this
return {
  parse("dyn_parse", table.concat(dyn:get_docstring())),
}

An error pops up:
Error while evaluating dynamicNode@1 for snippet 'dyn_return':
[string "require("luasnip").setup_snip_env() -- local ..."]:31: bad argument #1 to 'concat' (table expected, got string)

So the solution is:
ls.env_namespace("DYN", {
  vars = { ONE = "1", TWO = { "1", "2" } },
  multiline_vars = { "TWO" }
})

But there are some weird things in the case:

the result of print(dyn:get_docstring()[1]) is ${1:$DYN_ONE..$DYN_TWO..1..$WTF_YEA}$0: the number 1 should be 2
the expansion of dyn_parse is1..1
2..1..

which differs with 1..12..2.. and is not correct now.

But there are some weird things in the case:

the result of print(dyn:get_docstring()[1]) is ${1:$DYN_ONE..$DYN_TWO..1..$WTF_YEA}$0: the number 1 should be 2

Mhmm, I can see how that would be better in this case, but in general, I'm not convinced that matching the number of lines in an env-var really provides additional value.
I don't think there are any snippets that really depend on some env-variable-table containing ie. exactly two entries.

the expansion of dyn_parse is1..1
2..1..

Oh, mhmmm, that's unexpected, no idea where that linebreak is coming from o.O

Ahh nvm, of course it's coming from DYN_TWO, it contains a linebreak after all.
So ofc, parsing ${1:$DYN_ONE..$DYN_TWO..1..$WTF_YEA}$0 yields a new snippet with those variables (check out the parse_from_ast-branch, there the WTF_YEA also show up correctly)

(Btw, funny idea feeding the generated docstrings back to luasnip, hadn't occured to me as of yet :D)

So, what's the canonical way to use snip:get_docstring()? :)

You can see one usage here, so it's mostly used to show what a snippet looks like in completion-engines.


Avoid pulling in clap crate by the library

names has made questionable decision to depend on clap by the default which brings unnecessary dependencies for the library users: https://github.com/fnichol/names/blob/b5023b03e2339bf6e860bdcef20557ab81f3ec55/Cargo.toml#L21

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

CI was broken before. Im merging as is

Thanks


Add metadata to snapshots.

Addresses http://github.com/elastic/elasticsearch/pull/41281 (issue: http://github.com/elastic/elasticsearch/issues/40638)
Part of #4001

Ported to master


Auto complete needs a improvement

Hi, I tried @ the user npub1fyd0awkakq4aap70ual7mtlszjle9krffgwnsrkyua2frzmysd8qjj8gvg
using his first name: Rafa, but it was not listed his profile in auto complete. And I even follow the user.
https://github.com/PrimalHQ/primal-android-app/assets/1178856/ebcba872-c90b-49b2-9db2-9e79b1ce24dd

Another example that could be improved.  I follow someone with name leLeo. If I search Leo, Primal doesn't find this user to auto complete. Maybe because doesn't start with Leo, but has Leo in the end of the name, so I think should list yes in auto complete list.


Connected to Metamask but not created the Session

Describe the bug
I have created the URI from the Pair. instance.create() and generated the QR code for the URI and connected with the metamask.
It shows the wallet connected successfully but when I tried to check the wallet connect sessions in the metamask, it shows empty
No Session is created.
Also need to know, how to check the session details from the socket.
SDK Version

Client: Swift
Swift Verison: 5
iOS Version: 14

To Reproduce
Steps to reproduce the behavior:
`let metadata = AppMetadata(
name: "Example Wallet",
description: "Wallet description",
url: "example.wallet",
icons: ["https://avatars.githubusercontent.com/u/37784886"]
)
Pair.configure(metadata: metadata)
let uri = try await Pair.instance.create()
    let namespaces: [String: ProposalNamespace] = [
        "eip155": ProposalNamespace(
            chains: [
                Blockchain("eip155:80001")!,
            ],
            methods: [
                "eth_sendTransaction",
                "personal_sign",
                "eth_signTypedData"
            ], events: []
        ),
    ]

try await Sign.instance.connect(requiredNamespaces: namespaces, topic: uri.topic)

        url = uri.absoluteString
        QRCodeImgView.image = generateQRCode(from: uri.absoluteString)
        `

Expected behavior
Need to update the session in the wallet and need to check session details from the socket.
Screenshots

Seeing the same issue.

I face the same issue. No Session is created.
SDK Version
Client: Swift
Swift Verison: 5
iOS Version: 15
To Reproduce
Steps to reproduce the behavior:
`
    let methods: Set<String> = ["eth_sendTransaction", "personal_sign"]
    let blockchains: Set<Blockchain> = [Blockchain("eip155:1")!]
    let namespaces: [String: ProposalNamespace] = [
        "eip155": ProposalNamespace(
            chains: blockchains,
            methods: methods,
            events: []
        )
    ]

    let defaultSessionParams =  SessionParams(
                                    requiredNamespaces: namespaces,
                                    optionalNamespaces: nil,
                                    sessionProperties: nil
                                )
    WalletConnectModal.configure(
        projectId: "xxxx",
        metadata: metadata,
        sessionParams: defaultSessionParams
    )

`

Same issue. ETA for fix?

@alexander-lsvk can you take a look?

Any update?

Duplicate issue : https://github.com/WalletConnect/WalletConnectSwiftV2/issues/981

Same result ((

Yes. There is a session in MetaMask but WalletConnect doesn't provide session back in sample app after confirm connection on the MetaMask app.  Like in https://github.com/WalletConnect/WalletConnectSwiftV2/issues/981


Cygwin support

I'm trying to build the library on Cygwin:
mkdir build-cygwin
cd build-cygwin
cmake -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="$(PREFIX)" -DSDL_gpu_DEFAULT_BUILD_DEMOS=OFF ..
make

This fails with errors about CALLBACK macro not being defined. It's defined in bundled GLEW/gl.h only if both _WIN32 and __CYGWIN__ macros are present, so I added this switch to cmake commandline:
 -DCMAKE_C_FLAGS="-D_WIN32"

The library now compiles, but linking step fails:
[  9%] Linking C shared library cygSDL2_gpu.dll
cd /cygdrive/c/Users/User/.../sdl-gpu/build-cygwin/src && /usr/bin/cmake.exe -E cmake_link_script CMakeFiles/SDL_gpu_shared.dir/link.txt --verbose=1
/usr/bin/cc  -D_WIN32   -shared -Wl,--enable-auto-import -o cygSDL2_gpu.dll -Wl,--out-implib,libSDL2_gpu.dll.a -Wl,--major-image-version,0,--minor-image-version,0 CMakeFiles/SDL_gpu_shared.dir/externals/glew/glew.c.o
[skipped]
CMakeFiles/SDL_gpu_shared.dir/externals/stb_image_write/stb_image_write.c.o /cygdrive/c/Users/User/.../libroot/cygwin/lib/libSDL2.dll.a -Wl,-Bstatic -lm -Wl,-Bdynamic -lGL
CMakeFiles/SDL_gpu_shared.dir/externals/glew/glew.c.o:glew.c:(.text+0x4ff): undefined reference to `__imp_wglGetProcAddress'
CMakeFiles/SDL_gpu_shared.dir/externals/glew/glew.c.o:glew.c:(.text+0x4ff): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `__imp_wglGetProcAddress'
CMakeFiles/SDL_gpu_shared.dir/externals/glew/glew.c.o:glew.c:(.text+0x537): undefined reference to `__imp_wglGetProcAddress'
CMakeFiles/SDL_gpu_shared.dir/externals/glew/glew.c.o:glew.c:(.text+0x537): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `__imp_wglGetProcAddress'

I've tried adding -lopengl32 to linker flags, but this didn't change anything. Any pointers are appreciated! I'm trying to link against native OpenGL, not the Cygwin's
X11 OpenGL.

I'll put in a fix for that macro when I have a moment.  I did really think wgl was in OpenGL32, but maybe not?  Can you try linking gdi32 as well?

The WGL stuff is definitely in OpenGL32. It's documented in MSDN and I've been loading it all in my OGL binding for D for years.
https://msdn.microsoft.com/en-us/library/windows/desktop/dd374386(v=vs.85).aspx

@grimfang4 @mdparker It turned out I had X11 OpenGL installed. On a clean Cygwin installation cmake failed on find_package(OpenGL), but after adding -DCMAKE_LEGACY_CYGWIN_WIN32=1 it finally found the system OpenGL. Then I found the following related issue:
https://public.kitware.com/Bug/view.php?id=13050
So, it seems that X11 OpenGL is now the preferred one and system one will be used only if CMAKE_LEGACY_CYGWIN_WIN32 is set to 1. Imho, for games it makes more sense to use the system one, as it doesn't require X server to be bundled with the game.
Now the library links succesfully, demos still don't link - WinMain not found, investigating.

Seems to be SDL issue, it generates WinMain only when it detects MSVC. I disabled compilation of demos and the lib itself is working with my app.

Summarizing: build steps for Cygwin with native OpenGL are:
PREFIX = $(shell pwd)/libroot/cygwin

mkdir -p SDL/build-cygwin
(cd SDL/build-cygwin; ../configure --prefix="$(PREFIX)"; make; make install)

mkdir -p sdl-gpu/build-cygwin
(cd sdl-gpu/build-cygwin; cmake -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX="$(PREFIX)" -DCMAKE_LEGACY_CYGWIN_WIN32=1 -DCMAKE_C_FLAGS="-D_WIN32" -DSDL_gpu_BUILD_DEMOS=OFF ..; make; make install)

Additionally, WinMain should be defined in the app.

Could you check with the latest commit that you no longer need to explicitly define _WIN32?

Latest master without -DCMAKE_C_FLAGS="-D_WIN32" :
...ThirdParty/sdl-gpu/src/externals/glew/GL/glxew.h:98:22: fatal error: X11/Xlib.h: No such file or directory
 #include <X11/Xlib.h>
                      ^�

Is X11 ever desired by Cygwin users?

Cygwin is switching to be X11-only, native OpenGL is deprecated mode... But shipping standalone games with separate X server is inconvenient. Probably it would make more sense to use MinGW or VS instead, but I'm using Swift lang which is currently stable only on Cygwin. I'm not sure if it's worth fixing this mode (Cygwin+native OpenGL) in sdl_gpu.
Here's my template project for using Swift with SDL, I'm in process of adding sdl_gpu (now works on OS X and Cygwin):
https://github.com/zmeyc/sdl-game-swift

Okay, I'll leave it the way it was for now, since I am not set up to test X11 on Cygwin.
Eric Wing has done some cool stuff with Swift.  You might want to compare notes: http://blurrrsdk.com/


why?

error

What does the response message say? It's a 400 so it should have a message. Also the API container logs should show additional information.

响应消息消息？这是一条 400 所以它应该有一条消息。此外，API 容器日志应显示其他信息。

I'm unable to read your question, can you please post in English if possible. Looking at the stack trace this can happen if there a massive amount of resolved stacks for the current filter like you are looking at all events across all projects which appears to be the case. How many stack documents do you have?

Very few

Can you tell me how many stack documents you have in your Elasticsearch index?

I reinitialized the data. It seems normal, but I don't know why it was like this before

响应消息消息？这是一条 400 所以它应该有一条消息。此外，API 容器日志应显示其他信息。

好家伙，终于看到国人了。哈哈，这玩意国内教程少得可怜。。

Can you please post all replies in English or use a translator. From your stack trace, we are working on improving the search experience in the latest nightly builds.

Please try out the 7.1.0 release and leave a comment with your findings and also make sure you run the CleanupData job :).


Add Psalm support

Particularly because we can add it right into PhpStorm
https://psalm.dev/docs/running_psalm/language_server/

IDE support seems to time out on my systems, but I have it added now


Using __ in the field name brokes VS 2017 compilation

File: include/wsman-client-api.h
client_opt_t struct using two prefix underscore in the field  name: char *__reserved[16];
which is not supported by Visual Studio 2017 compiler
changing it to char * reserved__[16]; solves the issue

Ugh, the ANSI C standard seems to have room for interpretation.


require value causing issues with webpack

https://github.com/Plutonomicon/cardano-transaction-lib/blob/6d47a100781379b54debc801b4f13a21ea182c23/src/Types/ScriptLookups.purs#L454-L455
Since this project is still using PureScript 0.14 (0.15 has switched to ES modules) the fact that this is called require has caused webpack to misbehave. It's not even an exposed module, could it be renamed to something like require'?

I suggest requireValue


Let github collapse BUILD.bazel files in certain locations

What this PR does / why we need it:
BUILD.bazel files in pkg/, staging/ and tests/ are 100% auto-generated
and pretty much 100% of the time not something which need a review.
These paths are also the places where most of the code changes happen.
Let's mark them as dependencies which should be collapsed by default on PR reviews.
In the only case where they are normally an issue and need to be fixed
is when unintended custom modifications were done. In this case CI will
uncover that.
Properties are detected correctly:
$ git check-attr --all pkg/container-disk/BUILD.bazel
pkg/container-disk/BUILD.bazel: linguist-vendored: set
$ git check-attr --all tests/conformance/
BUILD.bazel     conformance.go  def.bzl
$ git check-attr --all tests/conformance/
BUILD.bazel     conformance.go  def.bzl
$ git check-attr --all tests/conformance/BUILD.bazel
tests/conformance/BUILD.bazel: linguist-vendored: false
$ git check-attr --all tests/BUILD.bazel
tests/BUILD.bazel: linguist-vendored: set
$ git check-attr --all staging/src/github.com/BUILD.bazel
staging/src/github.com/BUILD.bazel: linguist-vendored: set

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/cc @enp0s3

/retest

/retest

Hi @rmohr, thank you for the PR! IIUC the aim of it is to make the GH language stats more precise? so that the new stats will have: "Go, Shell, Other" (This is what I see in your fork)

Oh I did not even think about that. The idea was that they get auto-collapsed on github reviews, so that it is easier to spot important code changes on a review.

PR content updated. I formulated it not clear there.


[emacs] Don't require tramp to be loaded.

@dabrahams, does this still do the right thing on your side?


Spy++ is not visible under Tools in VS2019 after following these instructions

Using VS2019 community 16.4.3, under "Individual Components", there is no package called "Visual Studio C++ core features". However, there is "C++ core features". I have installed this package. I have also installed the "C++ profiling tools" package.
After installing these packages, Spy++ is NOT visible under the tools menu. However, the executable spyxx.exe is located on my hard drive at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\Tools.
Am I missing a step? Maybe these instructions need to be updated for VS2019.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 45e38caf-7077-963a-acd2-e815846041eb
Version Independent ID: a24346a4-06e1-4943-c2c5-a4c0000ab980
Content: How to: Start Spy++ - Visual Studio
Content Source: docs/debugger/how-to-start-spy-increment.md
Product: visual-studio-windows
Technology: vs-ide-debug
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@asfarley Thanks! I'll update this.

Checked Spy++ in a couple of versions of VS 2019 16.4, and I can't repro the issue. To make sure that this is logged in the right place, please use the Report a Problem tool to report the issue. When you do this, your report becomes part of the work items that are listed in the in the Visual Studio Developer Community, which allows you to engage directly with the engineering team while they address and fix the problem.


[Enhancement] - Workspace and environments

Notes for Reviewers
This PR fixes #

[x] Disable save button transfer items
[x]  Update create/edit workspace modal buttons (Update/Save)
[x]  Description of the workspace to bring front

Signed commits

[x] Yes, I signed my commits.

@anshitmishra would you like to give this PR a review?


Repo widget - Get SCM type from collectorItems

This PR adds changes to get scm type from collectorItems instead from widgetConfig.

@tabladrum LGTM


how to incorporate zarr's new open_consolidated method?

Zarr has a new feature called consolidated metadata. This feature will make it much faster to open certain zarr datasets, because all the metadata needed to construct the xarray dataset will live in a single .json file.
To use this new feature, the new function zarr.open_consolidated needs to be called. So it won't work with xarray out of the box. We need to decide how to add support for this at the xarray level.
I am seeking feedback on what API people would like to see before starting a PR. My proposal is to add a new keyword argument to xarray.open_zarr called consolidated (default = False). An alternative would be to automatically try open_consolidated and fall back on the standard open_group function if that fails.
I played around with this a bit and realized that https://github.com/zarr-developers/zarr/issues/336 needs to be resolved before we can do the xarray side.
cc @martindurant, who might want to weigh on what would be most convenient for intake.

My proposal is to add a new keyword argument to xarray.open_zarr called consolidated (default = False)

This sounds like a pretty safe approach to me. (We could imagine later changing this to be the default behavior, if we end up deciding that we usually want to write Zarr datasets with consolidated metadata.)


Avd schema eos designs

Change Summary

Related Issue(s)
Fixes #
Component(s) name
arista.avd.<role-name>
Proposed changes

How to test

Checklist
User Checklist

N/A

Repository Checklist

[ ] My code has been rebased from devel before I start
[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation and documentation have been updated accordingly.
[ ] I have updated molecule CI testing accordingly. (check the box if not applicable)

Replaced bu #2242


Resource Manager Labels Update is broke

The resource manager update fails when setting a label, in the style according to the docs.
>>> client = resource_manager.Client()
>>> project = client.fetch_project('purple-spaceship-124')
>>> project.labels['color'] = 'purple'
>>> project
<Project: None ('purple-spaceship-124')>
>>> project.update()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/waprin/.virtualenvs/resourcemanager/lib/python2.7/site-packages/google/cloud/resource_manager/project.py", line 207, in update
    method='PUT', path=self.path, data=data)
  File "/Users/waprin/.virtualenvs/resourcemanager/lib/python2.7/site-packages/google/cloud/_http.py", line 336, in api_request
    error_info=method + ' ' + url)
google.cloud.exceptions.BadRequest: 400 Request contains an invalid argument. (PUT https://cloudresourcemanager.googleapis.com/v1beta1/projects/purple-spaceship-124)

Will likely submit a PR to fix this myself, digging into it, making issue in case I'm doing something silly.

Thanks @waprin


Update manifests/t/Trados/TradosStudio/2021/16.2.9305/Trados.TradosStudio.2021.locale.en-US.yaml

Fixes an issue where this package has multiple different monikers
Microsoft Reviewers: Open in CodeFlow

[Policy] Reset Labels


Translation extraction & synchronisation for client and backend

closes https://github.com/OpenSlides/OpenSlides/issues/6479
Add translation scripts & utils for easy client & backend translation synchronisation. Docs will follow.

Docs added.

tests are failing until the new release, since the client needs to be updated


test_usm_ndarray_interop fails without gpu

test_usm_ndarray_interop gpu doesn't skip when there is no dpnp in environment (Windows)
Example: https://github.com/1e-to/numba-dppy/pull/1/checks?check_run_id=3533839223#step:13:1101

The test was redesigned to now use dpctl.tensor.usm_ndarray and supports both windows and linux.


HttpRequestDecoder decode() problem (rarely but occured)

@normanmaurer , I encoutered httpRequestDecoder problem in my prod environment. here comes the stacktrace from the log (hope if you have spare time, please take a look and feed back) :
io.netty.handler.codec.DecoderException: HttpRequestDecoder.decode() did not read anything but decoded a message.
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:335)
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:230)
at io.netty.channel.ChannelHandlerInvokerUtil.invokeChannelReadNow(ChannelHandlerInvokerUtil.java:84)
at io.netty.channel.DefaultChannelHandlerInvoker.invokeChannelRead(DefaultChannelHandlerInvoker.java:153)
at io.netty.channel.PausableChannelEventExecutor.invokeChannelRead(PausableChannelEventExecutor.java:86)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:389)
at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
at io.netty.handler.codec.MessageToMessageCodec.channelRead(MessageToMessageCodec.java:111)
at io.netty.channel.ChannelHandlerInvokerUtil.invokeChannelReadNow(ChannelHandlerInvokerUtil.java:84)
at io.netty.channel.DefaultChannelHandlerInvoker.invokeChannelRead(DefaultChannelHandlerInvoker.java:153)
at io.netty.channel.PausableChannelEventExecutor.invokeChannelRead(PausableChannelEventExecutor.java:86)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:389)
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:956)
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:127)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:514)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:471)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:385)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:351)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:116)
at io.netty.util.internal.chmv8.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1412)
at io.netty.util.internal.chmv8.ForkJoinTask.doExec(ForkJoinTask.java:280)
at io.netty.util.internal.chmv8.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:877)
at io.netty.util.internal.chmv8.ForkJoinPool.scan(ForkJoinPool.java:1706)
at io.netty.util.internal.chmv8.ForkJoinPool.runWorker(ForkJoinPool.java:1661)
at io.netty.util.internal.chmv8.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:126)
By the way, I used the 5.0.0 snapshot2 version in my prod environment. I don't know the reason for such error.

@bwzhang2011 please upgrade to 5.0.0.Alpha3-SNAPSHOT and re-open if it still persist

@normanmaurer, I did find the same log while upgraded to 5.0.0.Alpha3-SNAPSHOT and it occurred rarely.

Any reproducer?

Am 23.03.2015 um 06:54 schrieb bwzhang2012<EMAIL_ADDRESS>@normanmaurer, I did find the same log while upgraded to 5.0.0.Alpha3-SNAPSHOT and it occurred rarely.
—
Reply to this email directly or view it on GitHub.

@normanmaurer, like this(part of the pipeline):
// 压缩与否自动支持
pipeline.addLast(DEFLATOR_TAG,new HttpContentCompressor());
// http编码支持
pipeline.addLast(ENCODER_TAG,new HttpResponseEncoder());
// http解码支持
pipeline.addLast(DECODER_TAG,new HttpRequestDecoder());

we can reproduce this. Started happening when we upgraded from 4.0.23.Final to 4.0.26.Final.

@Iker-Jimenez can you share an app and steps to reproduce this with me ? Or a unit test that reproduce this ?

I think this is the same as https://github.com/netty/netty/issues/3247

@Iker-Jimenez Did you downgrade back to 4.0.23.Final or did you try with 4.0.24.Final ? 4.0.25.Final seems have the issue per https://github.com/netty/netty/issues/3247#issuecomment-69491567 so I'm trying to see how far back we need to downgrade...

@ddossot we didn't try 4.0.24, we knew 4.0.23 was good and we went back to it. We cannot reproduce this easily in non-prod systems so we took the safe approach.

@Iker-Jimenez Gotcha, we have the same problem: this issue only shows in prod so we'll probably follow your path and play it safe...

@Iker-Jimenez sorry I totally missed this.
I think this was fixed by @trustin in netty 4.0.27.Final by this:
https://github.com/netty/netty/commit/2c14406b55e2879a6acef051049eccca24ed0202#diff-bf7a179a319b29e0262d5badaf3770e0
Could you please try to use netty 4.0.32.Final and see if the issue is still there ?


docs: setup and cli installation details

Give an overview of the tasks completed

Adds docs to setup and install Arbiter CLI, building from source
README typo fix

Link to issue(s) that this PR closes
Resolves #557

Paging @Autoparallel or @kinrezC for a review here


FVWM Installation

BUGGED : Installing the dependencies: dont show anything
FVWM
Installation:
Below are the installation steps to install these dotfiles. Click on a step to expand it.

Installing the dependencies:
Installing the GTK Theme:
Installing the Dotfiles:

Are you on Ubuntu?

i mean when you click the arrow thingy and its supposed to show you the dependencies, it doesn't.

It only shows them for archlinux, there isn't any guide for ubuntu based distros, as I don't support them

What do you mean its GitHub DUDE. It should show for ALL. Do you put something special in your code. You might not support them, But other people do and might want to know the dependencies


[Appearanc] Search layout and tag appearance

Posts
[Appearance] Add   before each tag in posts
[Appearance] Fix: wrap tags in posts
Search
[Appearance] Hide scrolling bar in tag list in search
[Appearance] Search box & article container in search
[Appearance] Tag margin, border, color, selected in search

Thank you Reynold, I'll check it out soon 😃


Typings: onOk and onCancel returns selected item

Adds the selected item in the onOk and onCancel methods.

@hectahertz Just a typings fix, doesn't change code


Any plans to make this into a module and be available via NPM?

Hi there! Your library looks promising any plans to release it as a javascript module via NPM?

Does anyone know how we can do this, or how we can make the work easier for sharonchoong? Unfortunately, I don't know how to set this up, or what steps are necessary for this ...


Specify eslint-env globally?

Is there a way to set ESLint environments globally (via config or setting) without having to specify ESLint eslint-env flags in each file? (ie: /*eslint-env and, mocha */)
When I run $ standard in one of our project's directories, I get a bunch of these warnings in dozens of files:
/tests/spec/views/ready.js:109:8: 'it' is not defined.
/tests/spec/views/reset_password.js:7:0: 'define' is not defined.
/tests/spec/views/reset_password.js:28:4: 'describe' is not defined.
/tests/spec/views/reset_password.js:50:6: 'beforeEach' is not defined.
/tests/spec/views/reset_password.js:63:12: '$' is not defined.
/tests/spec/views/reset_password.js:67:6: 'afterEach' is not defined.
/tests/spec/views/reset_password.js:72:8: '$' is not defined.
/tests/spec/views/reset_password.js:77:6: 'describe' is not defined.
/tests/spec/views/reset_password.js:78:8: 'it' is not defined.
/tests/spec/views/reset_password.js:79:20: '$' is not defined.
/tests/spec/views/reset_password.js:82:8: 'it' is not defined.
/tests/spec/views/reset_password.js:113:6: 'describe' is not defined.
/tests/spec/views/reset_password.js:114:8: 'it' is not defined.
/tests/spec/views/tooltip.js:58:8: 'it' is not defined.
/tests/spec/views/tos.js:7:0: 'define' is not defined.
/tests/spec/views/tos.js:17:4: 'describe' is not defined.
/tests/spec/views/tos.js:22:6: 'beforeEach' is not defined.
/tests/spec/views/tos.js:38:6: 'afterEach' is not defined.
/tests/spec/views/tos.js:43:6: 'it' is not defined.
/tests/spec/views/unexpected_error.js:7:0: 'define' is not defined.
/tests/spec/views/unexpected_error.js:16:4: 'describe' is not defined.
/tests/spec/views/unexpected_error.js:19:6: 'beforeEach' is not defined.
/tests/spec/views/unexpected_error.js:28:6: 'afterEach' is not defined.
/tests/spec/views/unexpected_error.js:34:6: 'it' is not defined.
/tests/test_start.js:130:6: 'beforeEach' is not defined.
/tests/test_start.js:134:6: 'afterEach' is not defined.
...

Put it into .eslintrc file in your /tests folder like this.

@rlidwka, odd, that didn't seem to work:
$ standard --version # 3.7.0

$ cat tests/.eslintrc
env:
  mocha: true
  amd: true

$ standard tests
$ standard tests --verbose

$ cd tests
$ standard
standard: Use JavaScript Standard Style (https://github.com/feross/standard)
  ./app/tests/lib/blanket_lcov.js:9:0: Unexpected space between function name and paren.
  ./app/tests/lib/helpers.js:7:0: 'define' is not defined.
  ./app/tests/mocks/canvas.js:7:0: 'define' is not defined.
  ./app/tests/mocks/crosstab.js:7:0: 'define' is not defined.
  ./app/tests/mocks/crosstab.js:13:37: Extra semicolon.
  ./app/tests/mocks/dom-event.js:7:0: 'define' is not defined.
  ./app/tests/mocks/file-reader.js:7:0: 'define' is not defined.
  ./app/tests/mocks/fxa-client.js:7:0: 'define' is not defined.
  ./app/tests/mocks/history.js:6:0: 'define' is not defined.
  ./app/tests/mocks/oauth_servers.js:5:0: 'define' is not defined.
  ./app/tests/mocks/profile.js:7:0: 'define' is not defined.
  ./app/tests/mocks/router.js:7:0: 'define' is not defined.
  ./app/tests/mocks/window.js:7:0: 'define' is not defined.
  ./app/tests/mocks/window.js:59:34: There should be no spaces inside this paren.
  ...

$ standard | wc -l
standard: Use JavaScript Standard Style (https://github.com/feross/standard)
    1554

Just add a /* global define, it, describe */ comment at the top of each file.

FWIW, we have about 108 .js files in our /app/tests/* directory.
Currently we're using JSHint and can just specify the globals in the .jshintrc file in one place instead of copy/pasting into over a hundred files separately.

What I like about embedding the globals in the comments is that a JavaScript file then becomes standard "certified" in a sense. External configs remove this.
@pdehaan I know it's painful as I've done it with a couple of projects now. To ease the pain, what if you whipped up a quick script (using recast or just prepend text) to insert the global comments in every file?

@jprichardson Yeah, it's not difficult/impossible to do, but gets exponentially worse if we change our tests to some other library that uses different globals or syntax. I'd either have to go through and search/replace all these crazy /*global define, it, describe, afterEach, beforeEach, ... */ strings in every file or else manually go through them and tweak them so we don't end up with 2-3 different /*global ... */ blocks or a mix of /*global ... */ and /*eslint-env ... */ blocks.
But I totally agree with the I disagree with rule X, can you change it docs in the README. Plus the Can you make rule X configurable? docs clearly say:

Can you make rule X configurable?
No. Use eslint directly if you want to configure hundreds of options individually.

@pdehaan Totally understand. If you do change to another testing library, you could use recast to rewrite each file with the new globals. If you haven't used recast yet, it's one of the easiest ways to use esprima and parse/emit JavaScript. It's worth checking out at some point :)

So I'm a little confused here.  I'm see the same behavior as @pdehaan.  However, http://eslint.org/docs/user-guide/configuring#specifying-environments says that the environment mocha is explicitly supported.  So, is this a problem only when linting with standard?  It seems to work correctly if I npm install -g eslint eslint-config-standard then eslint . | grep describe in my project directory (there's no output because nothing got greped).
In my project, I've simply done npm install --save-dev standard, then invoked it via $(npm bin)/standard.  When I lint this way, I get 'describe' is not defined messages.
Is this expected behavior from standard?  I don't really like the suggestion by @feross (https://github.com/feross/standard/issues/122#issuecomment-95347801) to litter all files with eslint directives; it seems like creating a .eslintrc in my test/ directory with content
{
  "env": {
    "node": true,
    "mocha": true
  }
}

should do the trick.  I'd appreciate clarification by a knowledgeable somebody.  :)

.eslintrc and .eslintignore files are not supported by standard. Your options are:

Add /*eslint-env mocha */ to the top of the file with mocha globals.

Add "env": [ "mocha" ] to the package.json under the "standard" property.

I have myFile.js and myFile.test.js side by side in a directory. How can I make it work? It also says that expect is available in myFile.js which is false.


Implementation of ReFL StableDiffusionXL with LoRA

Hi,
This PR implements training ReFL with LoRA using SDXL, which enables faster fine-tuning with higher batch size.

Cool! Thanks a lot!


[WIP] rearrange dep work loop to try to regain some speed

@danmcp This seems like it might be a bit faster. I dumped all the URIs hit during a run and no API calls are getting hit twice, so it looks like caching is working as intended. Spending a lot of time in Trello::List#cards and Trello::Card#checklists, so maybe it's just going to be slow now? :(

@dobbymoodge That doesn't really make sense.  It was twice as slow and the job does a lot of other things.  How long does it take if you just have it process the docs board work still?

@danmcp I'll test that out in just a minute.

@danmcp Processing just the docs labels brings it down to 12 minutes, which is still 2x as long as before. Going to have to dive a bit deeper...

@danmcp yeah, this little change fixes everything. :)


More alignment issues

The search-placeholder and the list items aren't aligned, and neither have the correct distance from the left edge of the screen

The padding left and right of the "Cancel" button is inconsistent.

Nice catches!  Fixed in build 616.


Lease expire rate increases as thread count increases

The only difference between 4 cases is read pool size. The sizes are 4, 8, 16, 32 respectively. QPS of both 8, 16, 32 are the same however the lease expire count increases when thread count increases.
https://github.com/tikv/tikv/blob/4a828f036fb1c92d2d5e4341089e77edf858bfde/components/raftstore/src/store/peer.rs#L3367
Above code expires the lease which cause the remote one expires (dropped) too, so every threads have to renew their leases by fallback to raftstore and get a new lease. Maybe it's better to just drop local one and keep the remote one, so that renewing remote lease only requires an atomic store.
/cc @overvenus @5kbpers

Thx, I will try to l fix it.

I think this happens because every thread in the read thread pool have a LocalReader and when the thread count increase, the number of read requests the LocalReader handled increase if the leader lease is expired the lease expire rate increase, the QPS did not change because LocalReader redirect request to raftstore but the store thread number not change. I think the key to handling this problem is to keep the leader lease not expired, maybe https://github.com/tikv/tikv/pull/9307 can improve it.


Linux equiv of VCP

Good afternoon,
this is not strictly your problem and I understand that but I cannot find the answer anywhere else...
My previous attempt to install multi miner on Linux mint 17.1 was performed before I had the miner plugged in.
Everything worked flawlessly,  running under mono and installing BFG miner etc was no problem,  however as soon as the miner arrived it was impossible to detect it and no amount of jiggery pokery over many days would let it be found or would let me find and install the equivalent of VCP STM32,  so I gave up.
Your Linux install notes specify "Debian", based so my question today is ... "If I install Linux mint Debian edition with the miner plugged in,  will it detect and install the equivalent of VCP that will allow MultiMiner to find the miners on USB ports?
Many thanks
Rob

@Robeardley please see the following page for which drivers to install on which OS and for which miners:

https://github.com/nwoolls/MultiMiner/wiki/Drivers


open manipulator x unable to connect to port error

I am getting this error and am unsure what to do. ROS was installed correctly, and I am able to manipulate the arm using dynamixel_wizard2

Hi @gandrade2
If you are using U2D2 as USB-DYNAMIXEL interface, make sure to use the command below without any options
$ roslaunch open_manipulator_controller open_manipulator_controller.launch

If you are using OpenCR as an interface, please upload the usb_dxl Arduino sketch to the OpenCR.
https://emanual.robotis.com/docs/en/platform/openmanipulator_x/quick_start_guide/#communication-interface
Click on the Option2 box to unfold the content.

Thanks!

@ROBOTIS-Will I am having the same issue and i am using U2D2 board for the control with the above-mentioned command and still it shows the same error. I have also tried changing the USB connector cable but no luck.

Apologies for the delayed response. We have assembled a TF team to address OpenManipulator-x issues and are actively working on resolutions. Please note that we do not support EOL (End-of-Life) ROS versions; our support currently extends to Noetic and Humble versions. We kindly ask that you try again with the latest version. If the same issue arises, please feel free to resubmit it, and we will address it promptly.


Building using Game-CI causes more required features for android than manual build

Bug description

Building using Game-CI causes "com.google.ar.core.depth" to be required event when set to optional in project settings.  Manual build causes no such issue. This in turn significantly reduces the number of compatible devices.

How to reproduce

Create a new unity project and install AR-foundation and AR-core
In project settings -> XR-plugin management set plug-in provider for android to AR-core
In project settings -> XR-plugin management--> ARCore set depth to "Optional"
Build manually and you will find the requirement of feature "com.google.ar.core.depth" to be false in androidManifest.xml. Building using Game-CI causes the same feature to be true in androidManifest.xml.

Expected behavior
Building using Game-CI should not set "com.google.ar.core.depth" to required when set as optional in project settings.
Additional details
This is the code used for building:

Building using Game-CI causes "com.google.ar.core.depth" to be required event when set to optional in project settings. Manual build causes no such issue.

This is most likely not caused by GameCI specifically, but just by running the build from command line. GameCI is just a tool that makes it easy for you to run a build from command-line. It's probably wise to report this to the plugin maker or set the correct setting in your build script (that are otherwise set automatically when building from the GUI).

Hm interesting, however the changes in the GUI relates to changes in the file "/Assets/XR/Settings/AR Core Settings.asset" which as you can see in the build script I print out to make sure it is correct. Could this still be an issue with building from the terminal even though this file is correct, as the setting then exist in a file even without an active GUI of unity open?

Yea definitely. It wouldn't be the first time. It could be that some required library isn't present and (silently?) doesn't let us know, and we've seen command-line behaving different than the UI in quite a few other cases as well.
One example is the compression for WebGL builds.


Question: can I create a server with IdentityServer4 without a UI or using a framework such as Angular 2?

All the samples I've seen for IdentityServer4 use some variation of the QuickStartUI  which uses MVC for the UI.
I would like to build my login/logout/etc screens using a framework such as Angular2 and I'm struggling to figure out if it's possible given that every sample in some way uses a redirect to an MVC UI implementation.
Could someone explain to me or show me a sample that is API based and uses a Framework for UI?

It's entirely possible, although someone more experienced than I would have to chime in to advise on security of it.
I had a go at it (basically API only IdentityServer and UI hosted elsewhere) a month or so ago, but dropped it because I persuaded us to move in a different direction where having a login page on idsrv was acceptable.
At a very basic level, you'd have to create an API which returned data you needed e.g. external IdP's/Consent for a particular app. Which is simple enough. Inspect what logic the existing controllers do and look at what the views do wrt generating URL's and replicate these on API/your SPA respectively.
As for C/XSRF you can do something like this http://stackoverflow.com/a/44035774/3515174 Not sure what else needs doing for security -- as in, I'm genuinely not sure -- to me this is rather scary -- I would stick with MVC UI...
ProTip: You can pass idp through acr_values to automatically redirect to external IDP.

The UI is up to you, but the communication between the UI and the IdSvr middleware endpoints is mainly via the authentication cookie that the UI is expected to set. IMO, the UI is much easier to write in server-side rendered code, rather than SPA style.

I believe you need to look at the Resource Owner Password flow. Submit your username and pass and receive an access_token, along with a refresh_token. Make sure to set "offline_access" to true in your client config.

It would be great if you could add a sample of doing this with vanilla javascript. Then everybody could addapt it to their dear framework.  The sample could be as simple as possible to just know what are the minimal required things.

You mean like this one? https://github.com/IdentityServer/IdentityServer3.Samples/tree/master/source/Clients/JavaScriptResourceOwner

Thank you! I will look at it and see how to adapt it to IdentityServer4.

@rgozim Hi! I'm right with this same drawback of the UI. In some way I manage to solve it, or as it proceeded? I'm thinking about carrying out the password flow and not the implicit one but this openly breaks the OpenID protocol, but the truth is that using Razor and trying to adapt it with Angular or React is being a real headache or very frustrating. If you have any resource to help me do this, I would greatly appreciate it.

If you don't ask user permission for sending data to the client, then you cannot claim to be using openid connect

@TomCJones Hi, I do not understand your answer, was it for me? What I need to do is change the Razor UI to a UI with Angular or React or any other framework. For now I am experimentally exploring an SPA from .NET and consume the drivers of the QuickStart and modify this logic a little to suit my Angular Front-End application, however I do not know what the result will be.

Sorry, some how I read your request as asking for an id server with no ui. That would be hard to reconcile with the standard

@TomCJones No. He is not asking for an Id server without UI. He is asking for a UI implemented using just a plain Javascript client and not a MVC ASP.NET one where logic for the UI is delivered by the server. A Javascript client must connect to the ID server just using REST

@RaulRG Thanks for clarifying it. As I was investigating, I can have a SPA directly in an MVC project and make the connection with the .NET drivers to be able to do all the authentication. Now I am experimenting with this, but it is not functioning correctly yet.

Hi anyone has any opinion now?

I'm having the same kind of challenge making a UI using React to deal with all process (login, email confirmation, password reset, new user registration). The lack of guidance in this area is a pity.

@gersonDias, i have achieved this by configuring userinteraction options login url. I set the login url to single page application url and from there, you are on your own in writing functionality for the above asked use cases

I'm having the same kind of challenge making a UI using React to deal with all process (login, email confirmation, password reset, new user registration). The lack of guidance in this area is a pity. Would be nice if someone shares some code about this subject...

I think everyone is having a hard time understanding the relationship between the UI and IdentityServer. The short answer is the authentication cookie. Make your UI do whatever it needs to for any of those things. It's really unrelated to IdentityServer, But when your user wants to authenticate, then you need your server code behind the UI to issue the authentication cookie using the default authentication scheme from in the ASP.NET Core host. That's it. Once that cookie is issued, requests into IdentityServer will then do their job.

@brockallen Could IdentityServer4 be leveraged for mobile application using a framework such as Flutter? Thanks!

@brockallen is there any chance to post some working example of vanilla Javasrcipt(or Angular) and IdSrv4? I think it would be very useful because lot of developers use this kind of frontend/backend  implementation...

There's one here: https://github.com/IdentityModel/oidc-client-js/tree/dev/samples/VanillaJS
and here: https://github.com/IdentityServer/IdentityServer4.Samples/tree/release/Clients/src/JsOAuth2

that's great, but i think there is another thing that bother all of us here, we already have login screen in angular, so is there a way to avoid MVC and contact IdentityServer from Angular app?

Personally, this does not make any sense to me.
As the person responsible for implementing the Front End, I did these types of things a nice number of times. I have implemented logins with Identity Server using Angular code in the past just like this...
login(_username: string, _password: string) {         return this.http.post(             'api/token',             grant_type=password&username=${_username}&password=${_password}, this.options)             .then(res => res.json())             .then((x) => {                 localStorage.setItem('token', JSON.stringify(x));                 return x;             });     }
I feel like Identity Server is stepping back into the 1990s with requiring to run a Razor page.
My front end is dependent on numerous Front-End architectures that are shared fro the project, like shared components (buttons) and shared theme and a WPA. It would be imposable to share this all out to the Razor page, so it should all work in harmony.
At a point when Front-End is getting more complex and dynamic, does it make sense to remove the functionality of having it integrated into your project?

Just to clarify - you can use whatever front-end technology you want to create your login UI. Our samples use Razor. That's all.

@leastprivilege I see that you did not understand what I was writing. My issue is not 'what' tech I am using, my issue is that it has to be INTEGRATED AND PART of my application so that I can have all shared assets used in the login page, not with a redirect and a separate application.
Please let me know if I am misunderstanding something. Thanks!

if that's what you want, then I have to tell you that this is not how it works. You need to make the front-end round-trip to the token service to get SSO.
If you don't need SSO then you can embed the login UI in your client and use resource owner flow for the authentication/token requests.

If you don't need SSO then you can embed the login UI in your client and use resource owner flow for the authentication/token requests.

Can you elaborate on this or point me to an article? Thanks

@david-genger  I think you do misunderstand the concept of OpenID Connect,  The entire point of OpenID Connect is having a separate application for login, IdentityServer4 is just implementing that protocol.
Please check this out What is OpenID Connect? How does it work?
Not only IdentityServer4 does this, all other Identity Provider that implement the OpenID Connect protocol does the same thing.  For example, Azure AD B2C, Auth0 and Amazon Cognito
If you do not want a separate application for login, I believe the easiest way is just do not use any Identity Provider, and store your user credential (ex. user and password) in your own application.

@david-genger check out this quickstart for using ROPC with IdentityServer4: http://docs.identityserver.io/en/dev/quickstarts/2_resource_owner_passwords.html
But, please don't use it: https://www.scottbrady91.com/OAuth/Why-the-Resource-Owner-Password-Credentials-Grant-Type-is-not-Authentication-nor-Suitable-for-Modern-Applications

Not recommended but you can use the resource owner password workflow and get an access token. It can be done if you own the resource api and the identity server, but again, it is not encouraged.

I think the conversation derailed from its original purpose. The main topic was about having a sample providing a "port" of the Quickstart.UI sample to implement screens such us Register, Login, Logout, Consent and others for IdentityServer4, but in Angular or React instead of just Razor.
The samples provided by @leastprivilege are only for client apps, not for IdSrv4 itself. Also, I don'tknow how implementing the OwnerCredentials flow would be of any use in a case like this.

Not recommended but you can use the resource owner password workflow and get an access token. It can be done if you own the resource api and the identity server, but again, it is not encouraged.

https://www.scottbrady91.com/OAuth/Why-the-Resource-Owner-Password-Credentials-Grant-Type-is-not-Authentication-nor-Suitable-for-Modern-Applications

If this is still an issue I can help with building an angular/react UI for login page without using a resource owner password.

If this is still an issue I can help with building an angular/react UI for login page without using a resource owner password.

I'd be interested about that

hey @CesarD - it took a while but I wrote it down here:
https://medium.com/@piotrkarpaa/using-spa-react-angular-ui-with-identity-server-4-dc1f57e90b2c

Thanks for the example @karpikpl this was helpful.
Is it possible to use IS4 without any redirects whatsoever? I.e. use a single SPA which lazy-loads the authenticated JS once the user has logged in?
If this is a security concern, could someone please explain why? There are many enterprise apps which have this kind of login process (no redirects), so I'm wondering why this would not be achievable.

@Gearshxft in your client app you can set it up to open popups. This will let your app function without redirects.
Take a look at https://github.com/karpikpl/oidc-spa-client

Really struggling with this. The suggestions are all over the map. I like @karpikpl implementation, but I had to have to override an IdentityServer4 class. Why does IS4 assume a localUri for valid return URL?
Also, how is this any different from using the ROPC flow?
I would love if someone would explain the best/safest way to have your SPA app take the Username/Password fields, and authenticate with them.

You only have to override returnUrlParser if the IdentityServerUi is hosted on a different domain (the question here was about having the login page hosted as SPA).
When you have an SPA app and run Identity server 4 with server side rendering (like the UI samples), you don't have to override anything.
Look at the OIDC client on GitHub, there are some samples for JS clients. Similar to what I have in my repos.

@karpikpl I should have been more specific, I was wondering if it's possible with no popups or redirects at all (do everything inside a single HTML page).
If you are able to configure IS4 to use an SPA for the login page, is there any reason why you couldn't just host your entire SPA on IS4? An SPA only needs a single HTML page to serve as the entry point, so why serve anything from .NET Core at all?

What you're trying to do is possible but not using code or implicit flow (which are recommend for SPAs). You would have to use RO password grant.
From documentation:
The OAuth 2.0 resource owner password grant allows a client to send username and password to the token service and get an access token back that represents that user.
The spec generally recommends against using the resource owner password grant besides legacy applications that cannot host a browser. Generally speaking you are typically far better off using one of the interactive OpenID Connect flows when you want to authenticate a user and request access tokens.
If you want to host everything in one app without redirects than the best option is not too use OIDC but maybe old fashioned cookies?

@karpikpl Maybe I'm missing something, but your solution has a controller method that takes username/password directly. How is it different than ROPC inadequacies?
Is the security issue here basically about URL query  vs a POST containing username/password? Because query strings can be logged or cached in odd places and expose the password easier?

@foconnor-DS: the method that I assume you mentioned must be the one Login from AuthenticateController. That's not the same as ROPC. That's a method for IdServer's own UI (now based on an SPA instead of MVC), and it's also protected by CORS, so not any webapp can send requests to validate credentials.
Also, ROPC is meant for a client to use it directly. In this case if you are using implicit flow, you still have to redirect the user to log into IdS4 using its SPA UI and not using your own app UI. All security issues about giving your credentials to your own app (which could do anything with them) doesn't exist and user can stay assured that he/she is only dealing with a secure login.
Hope this makes sense.

I fully understand and agree with the conclusion of this thread. However since the topic does not specify which client technology we are talking about - it should be something like Angular - I have the guts and ask:
What if HTTP redirect is not an option for some clients, but our web based clients are already using IS4? Lets say we have desktop clients as well and would like to utilize all the advantages of token based authorization and a centralized identity solution.
Would it be suggested to extend IS4 with a custom login API endpoint that returns an access token? Or is it still a security concern to send user/pwd from anywhere else than IS4 login page itself? So it is necessary for desktop apps (as well) to integrate browser based authentication?

Desktop ones would use a different flow since desktop/mobile clients can maintain secrets client side (where browser cannot)
I think device flow is pretty well described in IS4 docs.
I’ll sit later and find it

https://youtu.be/YF8coyfQb0Y?t=1660

@karpikpl in your example how are cookies handled ? i know that IDSRV depends on cookies to determine whether the user is logged into the token authority or not. based on that it displays the login page or just redirects back with a successful response (based on the flow)

The cookie is still issued on the identity server domain, so when the redirect in the browser happens, cookie is included and the login page is skipped.
The length of that "SSO" session is controlled independently in IS4.
I've added a logout action in the sample that's supposed to kill that cookie and force the user to see the login page again.
We've been using that in production.
The thing that was confusing to most people was that expiration of JWT and expiration of the IS4 cookie are totally independent.


Access to deploymentAccount from a contract:deploy:beforeDeploy plugin. Accept "random" as privateKey configuration.

[] Enabling contract:deploy:beforeDeploy plugins to access deploymentAccount value by adding it into the contract object.
[] Allow user to specify "random" as privateKey configuration. In such case embark generates some random privateKey for the account.

What's the benefit of generating a random private key for contract deployment?

@emizzle , when we are running embark test we use twenty-something accounts for testing various things. It is convenient to use random privateKeys instead of creating and copy-pasting them all into the configuration.

This PR was split into #676 and #677 .


Drop domain entity and related subclasses

We are going to drop the Domain Entity paradigm and use the MappableConcept class defined in #80.
This will require us to use MappableConcept in places where domain entities were previously used.
We will also reorganize the schema folder directories, and consolidate all classes into one core specification document.
We will rename GKS Common (repo name) to GKS Core.

This was discussed at length again today, this time with @mbrush. We have decided to stay the course on this decision, but additionally to build necessary Element data structures for complex data types as needed in downstream repos such as VA Spec.
Domain Entities may be reconsidered within VA Spec at a later date, following the 1.0 spec release.


No progress after connecting to Mysql.

After the connection is established to mysql server and asked to press 'tab' nothing happens.
The terminal remains in suspended animation.
 System:
    OS: macOS 10.15.5
    CPU: (8) x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
    Memory: 1.21 GB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.14.0 - ~/.nvm/versions/node/v12.14.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v12.14.0/bin/npm
  Managers:
    CocoaPods: 1.9.2 - /Users/serdarmustafa/.rvm/gems/ruby-2.6.3/bin/pod
    Gradle: 6.4.1 - /usr/local/bin/gradle
    Homebrew: 2.4.0 - /usr/local/bin/brew
    Maven: 3.6.3 - /usr/local/bin/mvn
    pip3: 20.0.2 -<EMAIL_ADDRESS>    RubyGems: 3.0.4 - /Users/serdarmustafa/.rvm/rubies/ruby-2.6.3/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 4.2.1 - /usr/bin/gcc
    Git: 2.24.3 - /usr/bin/git
    Clang: 1<IP_ADDRESS> - /usr/bin/clang
    Mercurial: 5.4 - /usr/local/bin/hg
    Subversion: 1.10.4 - /usr/bin/svn
  Servers:
    Apache: 2.4.41 - /usr/sbin/apachectl
  Virtualization:
    Docker: 19.03.8 - /usr/local/bin/docker
  SDKs:
    iOS SDK:
      Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.3, 29.0.3
      System Images: android-28 | Google Play Intel x86 Atom
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
    Nano: 2.0.6 - /usr/bin/nano
    Sublime Text: Build 3211
    VSCode: 1.46.0 - /usr/local/bin/code
    Vim: 8.1 - /usr/bin/vim
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
  Languages:
    Bash: 3.2.57 - /bin/bash
    Java: 1.8.0_152 - /usr/bin/javac
    Perl: 5.18.4 - /usr/bin/perl
    PHP: 7.3.11 - /usr/bin/php
    Python: 2.7.16 - /usr/bin/python
    Python3: 3.8.3 -<EMAIL_ADDRESS>    Ruby: 2.6.3 - /Users/serdarmustafa/.rvm/rubies/ruby-2.6.3/bin/ruby
  Databases:
    MySQL: 5.7.29 -<EMAIL_ADDRESS>    PostgreSQL: 12.3 - /usr/local/bin/postgres
    SQLite: 3.32.1 - /usr/local/opt/sqlite/bin/sqlite3
  Browsers:
    Chrome: 83.0.4103.106
    Firefox: 68.0
    Firefox Developer Edition: 77.0
    Safari: 13.1.1
  Monorepos:
    Lerna: 3.22.1

Try to press Enter key after that step. It's a reported issue that I will definitely look into

Sadly, that doesn't work for me. Looking forward to a fix.

Rolling out fixes soon

Yes i have the same issue, even for ubuntu on Windows, and Ubuntu on Mac. both...

This project has been abandoned for a while. Will be rolling out fixes as soon as I can

After the connection is established to mysql server and asked to press 'tab' nothing happens.
The terminal remains in suspended animation.
 System:
    OS: macOS 10.15.5
    CPU: (8) x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
    Memory: 1.21 GB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.14.0 - ~/.nvm/versions/node/v12.14.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - ~/.nvm/versions/node/v12.14.0/bin/npm
  Managers:
    CocoaPods: 1.9.2 - /Users/serdarmustafa/.rvm/gems/ruby-2.6.3/bin/pod
    Gradle: 6.4.1 - /usr/local/bin/gradle
    Homebrew: 2.4.0 - /usr/local/bin/brew
    Maven: 3.6.3 - /usr/local/bin/mvn
    pip3: 20.0.2 -<EMAIL_ADDRESS>    RubyGems: 3.0.4 - /Users/serdarmustafa/.rvm/rubies/ruby-2.6.3/bin/gem
  Utilities:
    Make: 3.81 - /usr/bin/make
    GCC: 4.2.1 - /usr/bin/gcc
    Git: 2.24.3 - /usr/bin/git
    Clang: 1<IP_ADDRESS> - /usr/bin/clang
    Mercurial: 5.4 - /usr/local/bin/hg
    Subversion: 1.10.4 - /usr/bin/svn
  Servers:
    Apache: 2.4.41 - /usr/sbin/apachectl
  Virtualization:
    Docker: 19.03.8 - /usr/local/bin/docker
  SDKs:
    iOS SDK:
      Platforms: iOS 13.5, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 28, 29
      Build Tools: 28.0.3, 29.0.3
      System Images: android-28 | Google Play Intel x86 Atom
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>41897
    Nano: 2.0.6 - /usr/bin/nano
    Sublime Text: Build 3211
    VSCode: 1.46.0 - /usr/local/bin/code
    Vim: 8.1 - /usr/bin/vim
    Xcode: 11.5/11E608c - /usr/bin/xcodebuild
  Languages:
    Bash: 3.2.57 - /bin/bash
    Java: 1.8.0_152 - /usr/bin/javac
    Perl: 5.18.4 - /usr/bin/perl
    PHP: 7.3.11 - /usr/bin/php
    Python: 2.7.16 - /usr/bin/python
    Python3: 3.8.3 -<EMAIL_ADDRESS>    Ruby: 2.6.3 - /Users/serdarmustafa/.rvm/rubies/ruby-2.6.3/bin/ruby
  Databases:
    MySQL: 5.7.29 -<EMAIL_ADDRESS>    PostgreSQL: 12.3 - /usr/local/bin/postgres
    SQLite: 3.32.1 - /usr/local/opt/sqlite/bin/sqlite3
  Browsers:
    Chrome: 83.0.4103.106
    Firefox: 68.0
    Firefox Developer Edition: 77.0
    Safari: 13.1.1
  Monorepos:
    Lerna: 3.22.1

It's actually NOT hung, it's processing. If you add console.logs to migrate.js, you'll see it's processing. You can also check the outputted json folder, to see it's building.


issue with !clinicadl tsvtool getlabels

Hello there! Happy Thanksgiving to everyone!
When I ran this command to get the labels from my OASIS 3 Data:
!clinicadl tsvtool getlabels Oasis3D2ClinicalData/metaData/RestrictResults.tsv Oasis3D2ClinicalData/missingMod/missing Oasis3D2ClinicalData/missingMod/results
I got this error message:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 3361, in get_loc
return self._engine.get_loc(casted_key)
File "pandas/_libs/index.pyx", line 76, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc
File "pandas/_libs/hashtable_class_helper.pxi", line 5198, in pandas._libs.hashtable.PyObjectHashTable.get_item
File "pandas/_libs/hashtable_class_helper.pxi", line 5206, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'ses-M00'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "pandas/_libs/index.pyx", line 717, in pandas._libs.index.BaseMultiIndexCodesEngine.get_loc
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexes/base.py", line 3363, in get_loc
raise KeyError(key) from err
KeyError: 'ses-M00'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexes/multi.py", line 3080, in _get_loc_level
return (self._engine.get_loc(key), None)
File "pandas/_libs/index.pyx", line 720, in pandas._libs.index.BaseMultiIndexCodesEngine.get_loc
KeyError: ('sub-OAS30001', 'ses-M00')
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/bin/clinicadl", line 8, in
sys.exit(cli())
File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1128, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1053, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1659, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1659, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1395, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.7/site-packages/click/core.py", line 754, in invoke
return __callback(*args, **kwargs)
File "/usr/local/lib/python3.7/site-packages/clinicadl/tsvtools/getlabels/getlabels_cli.py", line 74, in cli
remove_smc=not keep_smc,
File "/usr/local/lib/python3.7/site-packages/clinicadl/tsvtools/getlabels/getlabels.py", line 490, in get_labels
baseline_diagnosis = subject_df.loc[(subject, "ses-M00"), "diagnosis"]
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexing.py", line 925, in getitem
return self._getitem_tuple(key)
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexing.py", line 1100, in _getitem_tuple
return self._getitem_lowerdim(tup)
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexing.py", line 822, in _getitem_lowerdim
return self._getitem_nested_tuple(tup)
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexing.py", line 906, in _getitem_nested_tuple
obj = getattr(obj, self.name)._getitem_axis(key, axis=axis)
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexing.py", line 1164, in _getitem_axis
return self._get_label(key, axis=axis)
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexing.py", line 1113, in _get_label
return self.obj.xs(label, axis=axis)
File "/usr/local/lib/python3.7/site-packages/pandas/core/generic.py", line 3771, in xs
key, level=0, drop_level=drop_level
File "/usr/local/lib/python3.7/site-packages/pandas/core/indexes/multi.py", line 3082, in _get_loc_level
raise KeyError(key) from e
KeyError: ('sub-OAS30001', 'ses-M00')
Is there a way to fix this issue?
Thanks in advance

Hello,
Thank you for your interest in ClinicaDL!
Actually there are many things that are still hard-coded in tsvtools, and this is why this is not working on new data sets such as OASIS-3.
We intend to tackle this issue next week by redesigning all these tools.
Right now what all you can do is to extract the labels yourself... Then other tools such as split or kfold should work normally.

Hello, I was able to successfully run !clinicadl tsvtool getlabels Oasis3D2ClinicalData/metaData/RestrictResults.tsv Oasis3D2ClinicalData/missingMod/missing Oasis3D2ClinicalData/missingMod/results  after I modified getlabels.py.
However, I ran into other issues when I do :
clinicadl random-search LAUNCH_DIRECTORY NAME
clinicadl train NETWORK_TASK CAPS_DIRECTORY TSV_DIRECTORY PREPROCESSING_JSON OUTPUT_MAPS_DIRECTORY
Since it is different issue, you can close this one, and I will open another issue. Thanks

Issue solved.


[gdapi-python] old requirements

Hi,
I can't use cattle-cli in my project, due to conflicting version requirements for the requests package.
Any reason why the setup.py file is so hard-wired to a specific version, by using the requirements.txt file ?

 Want to put in a PR? :-)

Ok, will do :)
In the mean time.. https://caremad.io/2013/07/setup-vs-requirement/


Add delete button for unregistered torrents

Working model complete. Just need to add safety features and permissions now


Could not start ipctool on original firmware

Hi and thanks for your work.
I have Hi3518ev100 (ESCAM QF001) camera.
I could not run ipctool on original firmware. I could install OpenIPC and ipctool works there, but I think sensor detected incorrectly.
chip:
  vendor: HiSilicon
  model: 3518EV100
board:
  vendor: OpenIPC
  version: <IP_ADDRESS>
ethernet:
  mac: "00:12:16:b4:3c:3e"
  u-mdio-phyaddr: 1
  phy-id: 0x02430c54
  d-mdio-phyaddr: 0
  phy-mode: mii
rom:
  - type: nor
    block: 64K
    partitions:
      - name: boot
        size: 0x40000
        sha1: 42f2bad9
      - name: env
        size: 0x10000
        sha1: b82436a1
        contains:
          - name: uboot-env
            offset: 0x0
      - name: kernel
        size: 0x200000
        sha1: 8259e82a
      - name: rootfs
        size: 0x500000
        path: /,squashfs
        sha1: e9ba9523
      - name: rootfs_data
        size: 0xb0000
        path: /overlay,jffs2,rw
    size: 8M
    addr-mode: 3-byte
ram:
  total: 64M
  media: 32M
firmware:
  u-boot: "2010.06 (Nov 14 2022 - 19:25:39)"
  kernel: "3.0.8 (Wed Jun 14 10:11:57 UTC 2023)"
  toolchain: buildroot-gcc-12.2.0
  sdk: "Hi3518_MPP_V1.0.B.0  (Nov 19 2015, 16:37:04)"
sensors:
- vendor: Silicon Optronics
  model: JXH42
  control:
    bus: 0
    type: i2c
    addr: 0x60
  vicap-state: down

So in original FW I got:
hisilicon # tftp 0x82000000 ipctool
Hisilicon ETH net controler
miiphy_register: non unique device name '0:1'
miiphy_register: non unique device name '0:2'
MAC:   00-12-16-B4-3C-3E
UP_PORT : phy status change : LINK=UP : DUPLEX=FULL : SPEED=100M
TFTP from server <IP_ADDRESS>; our IP address is <IP_ADDRESS>
Download Filename 'ipctool'.

Am I doing something wrong?

You need ro run ipctool in stock linux, not in bootloader shell.

Oh, that's sad but explains the issue.
Unfortunately I could not reach a stock linux shell yet, will try harder.

Oh, that's sad but explains the issue.
Unfortunately I could not reach a stock linux shell yet, will try harder.


Add a fit for the characteristic curve

Try a 5th degree polynomial.

Instead of adding a high order polynomial fit, the interpolation function was changed from a 1D interpolation to a CubicSpline, which should improve the predictions when only a few data points are used.

This issue is closed due to the addition of CubicSpline and PchipInterpolator methods inside the code.


Add docs on using cargo-expand to view generated types

A common question is, is there a way to "preview" the types that are generated by generate_types? Though not specific to our crate, it would be helpful to document use of cargo-expand in our crates.io docs and shopify.dev.

https://github.com/graphql-rust/graphql-client#alternative-workflow-using-the-cli


Moving aborts navigation

When I move my character or the camera, the navigation stops. How can I make sure the navigation stays active until I'm at the destination?
https://youtu.be/5oPpDLhpAB0
dump_2024-06-29_02-50-31.json

there is no console output

Thank you very much for reporting. Did it happen after upgrading any plugins or the server?

Hi!
I'm on DaniDipp's team and we did some investigating into this bug. I've made a PR with a fix.
https://github.com/CubBossa/PathFinder/pull/81

Awesome, thank you very much!
Don't worry about the build failing in the PR, there's something off with the check in general. I'll merge and release later today or tomorrow


Add ptrace and reshape

Add ptrace, reshape and column manipulation specializations.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

71 of 73 (97.26%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 96.61%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/qutip_jax/reshape.py
70
72
97.22%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
228

Relevant Lines:
236

💛  - Coveralls

This is okay to merge @Ericgig


The option services.xserver.displayManager.sddm.package does not exist

I tried to rebuild my OS and got this error message:
error:
       … while calling the 'seq' builtin

         at /nix/store/jp7nlmyb8hwhf3d11s5ylkry7kv4bncv-source/lib/modules.nix:320:18:

          319|         options = checked options;
          320|         config = checked (removeAttrs config [ "_module" ]);
             |                  ^
          321|         _module = checked (config._module);

       … while calling the 'throw' builtin

         at /nix/store/jp7nlmyb8hwhf3d11s5ylkry7kv4bncv-source/lib/modules.nix:296:18:

          295|                     ''
          296|             else throw baseMsg
             |                  ^
          297|         else null;

       error: The option `services.xserver.displayManager.sddm.package' does not exist. Definition values:
       - In `/nix/store/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx-source/configuration.nix':
           {
             _type = "if";
             condition = true;
             content = <derivation sddm-unstable-2023-12-29>;
           }

I'm not sure, how I can fix this. But as it worked before, I assume, it's some broken dependency?

Use the latest version of nixos-unstable.

I see, thank you!


[Bug] hidet.ops.tan cannot work

Describe the bug
I found that hidet.ops.tan cannot work, the following is a part of traceback info:
Traceback (most recent call last):
  File "/root/test/test/test.py", line 6, in <module>
    y = ops.tan(hidet.from_torch(x))
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/graph/ops/arithmetic.py", line 893, in tan
    return TanOp(x).outputs[0]
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/graph/ops/arithmetic.py", line 452, in __init__
    super().__init__(x, op=lambda a: primitives.tan(a), name='tan')
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/graph/ops/arithmetic.py", line 268, in __init__
    self.op = UnaryElementwiseOperation.from_callable(op, name, attributes, task_attributes)
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/graph/ops/arithmetic.py", line 46, in from_callable
    y = op(x)
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/graph/ops/arithmetic.py", line 452, in <lambda>
    super().__init__(x, op=lambda a: primitives.tan(a), name='tan')
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/ir/primitives/math.py", line 372, in tan
    return generic_math_function_set.tan(a)
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/ir/primitives/math.py", line 253, in tan
    return self.call('tan', a)
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/ir/primitives/math.py", line 241, in call
    entry = lookup_primitive_function(f'generic_{name}')
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/ir/primitives/func.py", line 105, in lookup_primitive_function
    return primitive_func_pool.lookup_by_name(name)
  File "/root/miniconda3/envs/smore/lib/python3.10/site-packages/hidet/ir/primitives/func.py", line 77, in lookup_by_name
    raise ValueError(
ValueError: Can not find primitive function with key: generic_tan, candidates:
generic_sin
generic_cos
generic_tanh
generic_exp
generic_round
generic_abs
generic_floor
generic_ceil
generic_sqrt
generic_rsqrt
generic_erf
...

To Reproduce
The following is my code for test:
import hidet
import torch
from hidet import ops

x = torch.randn([2, 2])
y = ops.tan(hidet.from_torch(x))
print(y)

Expected behavior
I hope it work normally.
Enviroment

OS: Ubuntu 22.04

Others: hidet version: 0.3.0

Hi @CBalaa ,
Thanks so much for trying out Hidet and reporting this bug! This bug has already been fixed in our internal branch, which will be released as part of our 0.4.0 release milestone (i.e., end of June). As a reference to other people who might've encountered the same bug, I'll keep this issue open until 0.4.0 is actually released. Stay tuned!


Fix upgrade mode (#2497) (#2599)

Fix bug introduced in 1f9fb7fe

/azp run

Closing this as I added the fix to #2677 to avoid issues with merging later on.


Replace the IoT Platform instance to fix failing tests

The previous one hit its free tier quota.

Upgraded IoT to regular plan.


Fix the Confirm-ForestExists topic example

The topic Confirm-ForestExists has the wrong cmdlet on its example section:
Confirm-TargetsAreReachable -Forest "TEST.CONTOSO.COM"
Link:
https://learn.microsoft.com/en-us/azure/active-directory/hybrid/connect/reference-connect-adconnectivitytools#confirm-forestexists

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 672f8e89-d61f-7ddf-34c9-117171b943ba
Version Independent ID: bc57914f-f6e0-53ff-2052-6bec47051fa7
Content: Azure AD Connect: ADConnectivityTools PowerShell Reference - Microsoft Entra
Content Source: articles/active-directory/hybrid/connect/reference-connect-adconnectivitytools.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@douglasgaigher
Thanks for your feedback! We will investigate and update as appropriate.

@douglasgaigher
Thanks for contributing towards enhancement of document. We have performed the required changes and it will reflect in the document itself once approve by content author.


Wait for listener's exit during restart test

Overview
To test a config listener's restart we are deleting event handler in config_event and then immediately checking event manager.
This creates race when we can be a slightly early and catch old handler yet to be removed or slightly late and get new handler that already been installed.
This patch trying to address this by doing the check immediately after old handler exits and then incrementally waiting for new handler to be installed.
Testing recommendations
Run for an isolated test:
make eunit apps=couch_log suites=couch_log_config_listener_test tests=couch_log_config_test_

GitHub issue number
Fixes #581
Checklist

[x] Code is written and works correctly;
[x] Changes are covered by tests;
[ ] Documentation reflects the changes;

Ironically your test for this build failed on the couch_log_config_listener_test:
https://travis-ci.org/apache/couchdb/jobs/240997782

Ironically indeed :/
Since it's guaranteed that the old handler was gone, it sent 'DOWN' after all, that means this is a new registered handler already spawned by sup. I'll have to bash my head now to figure out what can be done about this.

So I've been pondering on this for a while and I don't see a good solution on how we can fix this race without altering the test.
The issue here is that when we are trying to confirm that handler got removed from config_event manager we are aiming in a pretty narrow gap between config_listener's terminate and couch_log_sup spawning and registering new config_listener_mon.
We can ensure that we are not checking handlers before old listener dies, but we can't delay supervisor without mocking couch_log_sup to set delay in its handle_config_terminate.
And mocking the very module we are testing doesn't seems right to me.
So I removed assertion on that short moment when handler is not in config_event and used it as a flag to wait on new listener to start. Then I've added assertion on that it is indeed a new listener and it is registered as the same handler id, which should be enough to confirm that listener's restart is working as expected.
@davisp I believe you are the original author of this test. Do you think this change is acceptable and doesn't compromise integrity of the test?

+1
I didn't even remember writing this test so I went back to look at history. The reason this got all mixed up was the big config API changes that happened around the time I wrote this test. Originally it was its own gen_server which would wait 5s between reloads of the config listener but then we changed the config listener to be in the supervision tree which as you point out makes it quite the race. Looks like we hit that and then just changed the timeout without actually rethinking the test.
Your changes to wait for the handler to exit, wait for a new one wiht the same id and a different pid I agree perform the same logical assertion that the restart is working.
Good work on this!


AlertDialog not closing after providing input

Description
I'm using one of your tutorial scripts for the chat application. For some reason, the AlertDialog is not closing after providing input. It disappears when I refresh the browser tab. I tried different browsers/environments.

Code example to reproduce the issue:
import flet as ft

class Message():
    def __init__(self, user: str, text: str, message_type: str):
        self.user = user
        self.text = text
        self.message_type = message_type

def main(page: ft.Page):

    chat = ft.Column()
    new_message = ft.TextField()

    def on_message(message: Message):
        if message.message_type == "chat_message":
            chat.controls.append(ft.Text(f"{message.user}: {message.text}"))
        elif message.message_type == "login_message":
            chat.controls.append(
                ft.Text(message.text, italic=True, color=ft.colors.BLACK45, size=12)
            )
        page.update()

    page.pubsub.subscribe(on_message)

    def send_click(e):
        page.pubsub.send_all(Message(user=page.session.get('user_name'), text=new_message.value, message_type="chat_message"))
        new_message.value = ""
        page.update()

    user_name = ft.TextField(label="Enter your name")

    def join_click(e):
        if not user_name.value:
            user_name.error_text = "Name cannot be blank!"
            user_name.update()
        else:
            page.session.set("user_name", user_name.value)
            page.dialog.open = False
            page.pubsub.send_all(Message(user=user_name.value, text=f"{user_name.value} has joined the chat.", message_type="login_message"))
            page.update()

    page.dialog = ft.AlertDialog(
        open=True,
        modal=True,
        title=ft.Text("Welcome!"),
        content=ft.Column([user_name], tight=True),
        actions=[ft.ElevatedButton(text="Join chat", on_click=join_click)],
        actions_alignment="end",
    )

    page.add(chat, ft.Row([new_message, ft.ElevatedButton("Send", on_click=send_click)]))

ft.app(target=main, view=ft.WEB_BROWSER)

Describe the results you received:
Page updates but the popup window is there until I refresh the page

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
Version: 0.14.0

Operating system:
Windows 11

Additional environment details:
Tried with a docker image, incognito window, various browsers (mostly using chrome)

It works on my end as expected.
Please can you retry with the latest version and report?


Upgrade slim-rails 3.1.3

Coverage remained the same at 100.0% when pulling b94e9eef69fc2b7751d38ae68f2689ec73043a9b on upgrade/slim-rails-3.1.3 into c8909feae88b5d0898eae8d9853e1a911ed1d24f on master.


Filter out objects correctly based on layer

Objects not on layer 0 were still exported with Export all layers off.
This PR filters them out properly in filter_apply, thus making sure that e.g. associated meshes are also left out of the export.

Thanks!


"REST and OData API Documentation" - missing constraint (HATEOAS) and RMM

In this style guide the About REST APIs section talks about how an individual REST API is defined, listing various aspects. A fundamental aspect of REST, namely HATEOAS, is missing from the list. While HATEOAS is a constraint normally found only in APIs that have attained RMM level 3 and many pragmatic RESTful APIs exist without implementing that constraint, don't you think that we should at least mention the Richardson Maturity Model and include a fundamental aspect of REST in this list, rather than exclude it (see https://www.youtube.com/watch?v=bhn-Dl87SDE for background)?

Hi DJ,
I am going to discuss this with Steffen Goebel in the API and Events CPA working group, which I am a member. My gut feeling is that we don't need to mention this, but let's see what they say.

Hi,
This is covered in an internal document that will be added to the public one very soon.

Thanks, it will be good to see a complete description of REST in this section soon 👍


Splash screen can take a lot of space in low resolution screens

When starting Spyder in my laptop screen (1366 x 768) the splash looks like this (kind of big):

However in my secondary screen (1920×1080) the splash looks better:

Thanks for reporting @dalthviz. @juanis2112 will take care of it.


Fixed missing breaks. Linked libs to PayableExchangeIssue. Added Weth…

…Mock dependency to core migration.

Pull Request Test Coverage Report for Build 4050

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 4047:
0.0%

Covered Lines:
888

Relevant Lines:
888

💛  - Coveralls


JOSS papers about already included packages

Carbonr is already on the main list. Should we add https://joss.theoj.org/papers/10.21105/joss.06932 to papers.md, too?

Thanks @RichardLitt The paper.md was created automatically via Ecosyste.ms. @andrew extracts the paper from the README using regular expressions, I guess, or some other way to parse the URLs. There is no API for this service yet, but we should consider creating a spreadsheet that automatically maps papers to open source projects, similar to what we currently do with projects and organisations in Grist. It would be cool to know the paper cited the most in this open source space :).

Here's the code I used to generate papers.md, we can potentially turn it into a github action that runs on a regular basis: https://github.com/ecosyste-ms/ost/blob/main/lib/tasks/papers.rake
carbonr doesn't mention the joss paper in it's readme, but maybe we should start indexing joss papers to be able to double check for those references?

Both a GitHub Action and a JOSS-checker makes sense to me. :)