Interface dispatch support

Emit the supporting data structures for interface dispatch:

Interface dispatch cell for each call site providing the resolution function entry point as well as the interface type and interface method slot number
Interface map on EETypes specifying the list of interfaces they implement
Dispatch map that provides, for each type, the lookup rows for interface type, interface method slot, and implementing method's VTable slot
Dispatch map table that provides dispatch map pointers (the index into this table is stored on an EEType instead of a pointer to the map for space savings)

Added a work-around in the runtime to provide access to the dispatch map table until full module headers are implemented

@jkotas @davidwrighton @smosier Please take a look. David, I removed a couple type system asserts in TypeSystemContext::GetMethodForInstantiatedType. For interface method impls, they had instantiations in my testing and removing the asserts seemed to work fine :)
Scott: I added you to make sure you're okay with my temporary workaround for no ModuleHeader support.  I plumbed the dispatch map table in via a RuntimeInstance helper.

For Unix, could you please just fix the build breaks (e.g. by adding dummy methods to portable.cpp)? We can deal with porting the assembly code in separate change.

LGTM otherwise

@jkotas @MichalStrehovsky @davidwrighton Updated based on your feedback.
Also, I split TypeDesc.MethodImpls.cs into two (based on the type names stored in it): MetadataType.MethodImpls.cs, InstantiatedType.MethodImpls.cs
I added a stub .S for the cross-plat assembly code needed for dispatch. Portable.cpp should already have the missing entry points (we'll see when CI finishes).

@nattress Could you add stub for Linux arm and arm64 as well?

split TypeDesc.MethodImpls.cs into two (based on the type names stored in it)

The split files need to be in the common directory - you have added them to the compiler directory.
We have been going back and forth on whether the files should be split for cases like this or not. I believe that we have been leaning towards keeping them together. Splitting these into multiple files rigorously leads to way too many little files.


youtube-dl: 2016-12-15 -> 2016-12-20

Motivation for this change
youtube-dl update
most notable changes:

Improve fragment URL construction for DASH media
Fix codec information extraction for mixed audio/video DASH media
[vimeo] Add support for DASH formats
Recognize DASH formats in html5 media entries

Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

thanks!


De-dupe via uniq

Ruby 2.3.0 no longer mutates arrays when iterating so the delete_if approach no longer works. This quick fix changes just the de-duping to use uniq instead.

This is great, thanks for taking the time to do this!
I'd like to get this gem set up with Travis CI or something that will test it against multiple Ruby versions before I merge this PR. That way, we can get a failing test case for 2.3.0, and your commit should fix it.
I'll try my best to be speedy about it.

@phallguy  I integrated Travis CI with this project, which tests it against Ruby 2.3.x. Because of this bug, the build for that version is passing when it should be failing instead. Are you able to write a failing test case that passes with your fix, please?

Yep, added failing spec.

@reprah were you able to see the spec failing in 2.3 but working with the new patch?

@phallguy Yes I did! I wasn't able to see the failure in Travis because of the order of commits, so I copied your branch locally, reverted your fix and upgraded my Ruby version to 2.3.0 to see the spec failure. I'm going to merge this in now and release a new version, thanks for your patience.

@phallguy I released 1.2.2 with your PR in it onto Rubygems.

Awesome! thanks for following through on this


Cannot find module /node_modules/laravel-precognition/dist/client'

Laravel Precognition Plugin Version
0.3.2
Laravel Version
10.4.1
Plugin
React
Description

ready started server on <IP_ADDRESS>:3000, url: http://localhost:3000
event compiled client and server successfully in 556 ms (18 modules)
wait compiling...
event compiled client and server successfully in 121 ms (18 modules)
wait compiling /_error (client and server)...
wait compiling /login (client and server)...
event compiled client and server successfully in 3.6s (1272 modules)
warn Fast Refresh had to perform a full reload. Read more: https://nextjs.org/docs/messages/fast-refresh-reload
error Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/thuraaung/Works/solinx/next-testing/node_modules/laravel-precognition/dist/client' imported from /Users/thuraaung/Works/solinx/next-testing/node_modules/laravel-precognition/dist/index.js
at new NodeError (node:internal/errors:399:5)
at finalizeResolution (node:internal/modules/esm/resolve:231:11)
at moduleResolve (node:internal/modules/esm/resolve:850:10)
at ESMLoader.defaultResolve (node:internal/modules/esm/resolve:1058:11)
at ESMLoader.resolve (node:internal/modules/esm/loader:323:32)
at ESMLoader.getModuleJob (node:internal/modules/esm/loader:172:38)
at ModuleWrap. (node:internal/modules/esm/module_job:76:40)
at link (node:internal/modules/esm/module_job:75:36) {
digest: undefined
}

Steps To Reproduce
Here i just done

install fresh laravel with laravel new testing
install fresh nextjs with mui
install the package npm install laravel-precognition-react-inertia
follow the guide for react https://laravel.com/docs/10.x/precognition#using-react
run npm run dev

Sounds like the same issue as #30.
I've left a temporary solution in my reply at https://github.com/laravel/precognition/issues/30#issuecomment-1635107810 and we'll see if we can improve this.


[ Feat ]: Support Cloudflare runtime

Cloudflare wrangler reports an error when an Authenticator uses TOTPStrategy. The error seems to be reported during load time so the authenticator does not execute.

https://github.com/mw10013/remix-auth-totp-sandbox demonstrates the error.

Created using pnpm create remix@latest --template remix-run/remix/templates/cloudflare-page
Uses the latest versions of remix and wrangler
remix.config.js needed serverNodeBuiltinsPolyfill to compile

serverNodeBuiltinsPolyfill: {
    modules: { crypto: true, stream: true },
    globals: {
      process: true,
    },
  },

In package.json, added compatibility-flags option to start script for node:process

"start": "wrangler pages dev ./public --compatibility-date=2023-12-13 --compatibility-flags=\"nodejs_compat\""

app/auth.server.ts has createAuthenticator() which returns an Authenticator with skeleton TOTPStrategy. It's non functional and contains just enough implementation to compile to check if any load issues. If the authenticator. use() statement is commented out, there will be no load error so it seems that loading the code for TOTPStrategy may be causing the error.

Hello @mw10013, thanks for reporting this.
I recently released remix-auth-totp, an evolution of the earlier remix-auth-otp. The key upgrade in this library is the shift to using @epic-web/totp for generating and managing One-Time Passwords (OTPs), enhancing the encryption and decryption processes.
Previously, with remix-auth-otp, an issue related to Cloudflare and authentication was reported. This issue was linked to the use of node-crypto. However, since @epic-web/totp does not utilize node-crypto — as far as I'm aware — the same issues should not occur.
Despite this, I must admit I haven't had the chance to get deeper into the specifics of Cloudflare's systems, which makes it challenging to understand what could be happening (the library works as expected outside of it).
I'm considering reaching out to Sergio Xalambrí, the creator of remix-auth. He might have some insights into what could be causing these Cloudflare issues.
Let me know if you have more information or a specific error that could lead us to a solution!

Update: I had a talk with Sergio, who pointed out a possible case that could be causing the Cloudflare issues.
Compatibility Issue with Cloudflare:
remix-auth is compatible with Cloudflare, but some dependencies, such as jws and jsonwebtoken, might not be. This could be one of the potential issues since this library uses jsonwebtoken as an extra security layer for data reaching the client. Although it's not necessary and it could be stripped off.
Specific Package Problems:
The thirty-two package may also have issues with Cloudflare. It's important to note this because it's used in dependencies like @epic-web/totp. In this case, Kent C. Dodds should be informed, as he is involved with the pointed library.
Potential Solutions:
Replacing jsonwebtoken might resolve some of the issues. Also considering using node-crypto or crypto-es as alternatives to deprecated packages like crypto-js. Another option is to utilize the Web Crypto API globally, which is supported in Cloudflare, Deno, Bun, Node (since v20), and browsers.
I'll check this out @mw10013. I'll definitely find some time to look into it and come up with a solution.
I'll leave the issue open and update you on any changes.
Thanks again for bringing this up!

@epic-web/totp, which has thirty-two as dependency seems to work in Cloudflare with tweak to remix.config.js.
serverNodeBuiltinsPolyfill: {
    modules: { buffer: true, crypto: true },
    globals: {
      Buffer: true,
    },
  },

https://github.com/mw10013/remix-auth-totp-sandbox/blob/epic-totp/app/routes/_index.tsx
export function loader() {
  const { otp, secret, digits, period, algorithm } = generateTOTP({
    algorithm: "SHA256",
    period: 10 * 60,
  });
  const isValid = verifyTOTP({ otp, secret, digits, period, algorithm });

  return { otp, secret, period, digits, algorithm, isValid };
}

Cloudflare definitely supports the Web Crypto API.
https://github.com/mw10013/remix-auth-totp-sandbox/tree/jsonwebtoken
"The Workers runtime implements the full surface of this API, but with some differences in the supported algorithms compared to those implemented in most browsers."
I'm unable to get jsonwebtoken working. This branch (https://github.com/mw10013/remix-auth-totp-sandbox/tree/jsonwebtoken) contains only jsonwebtoken and compiles with tweak to remix.config.js
serverNodeBuiltinsPolyfill: {
    modules: { crypto: true, stream: true },
    globals: {
      process: true,
    }
  },

Runtime error starting up.

Alright, so we can mostly confirm that the issue could be the implementation of jsonwebtoken.
I'll need to review the source-code from the Strategy to confirm if jsonwebtoken can be stripped out or replaced. If I recall correctly, it was added as an extra security layer, but it wasn't necessary or required at the time.
I'll look into it, @mw10013.
If you have any other information or want to report something else, feel free to do so!

Jose may be another option, https://github.com/panva/jose
"jose is JavaScript module for JSON Object Signing and Encryption, providing support for JSON Web Tokens (JWT), JSON Web Signature (JWS), JSON Web Encryption (JWE), JSON Web Key (JWK), JSON Web Key Set (JWKS), and more. The module is designed to work across various Web-interoperable runtimes including Node.js, browsers, Cloudflare Workers, Deno, Bun, and others."

Could you please give it a try to jose the same way you did with jsonwebtoken @mw10013? If it works, could be a replacement for jsonwebtoken.

All right @mw10013, could you try this implementation of jose on a new development package called remix-auth-totp-dev? Here's the package: remix-auth-totp-dev
Feel free to give it a try and let me know if it works as expected or if you encounter any new errors that we can address.
The tests pass successfully, although I will be fixing some minor incompatibilities with expiration periods, between strings and numbers, due to the new jose implementation."

Thanks for turning this around so quickly!
I'm now able to get my non-functional skeletal sandbox to compile and load with tweak to remix.config.js.
  serverNodeBuiltinsPolyfill: {
    modules: { buffer: true, crypto: true },
    globals: {
      Buffer: true,
    },
  },

I'll be working on a functional version and will report back here.

With the remix-auth-totp-dev package, I'm getting a "Code is no longer active" error when I submit the code in a verify form.
As a sanity check, I forked https://github.com/dev-xo/totp-starter-example, created a branch named remix-auth-totp-dev, and replaced the remix-auth-totp package with remix-auth-totp-dev. I get the same error, "Code is no longer active", when I submit it in the verify form. I also tried the case of clicking on the magic link in the email and get redirected to login.
For reference, the branch is https://github.com/mw10013/totp-starter-example/tree/remix-auth-totp-dev

Can you please try again with the updated remix-auth-totp-dev? I made some changes, that could fix it.

totp-starter-example and my example program work with remix-auth-totp-dev @ v1.3.3. Thanks for the timely fixes!

Does that mean we have support for Cloudflare, @mw10013?
In that case, would you like to create a totp-starter-cloudflare template?
It would help other people get started with it easily.
Also, tomorrow I will publish these changes to the official remix-auth-totp package.

Yes, I can confirm the basics work in Cloudflare local dev with wrangler/miniflare. Need to get further along in the example program I'm working on to cover more cases and then get it running in Cloudflare production. I would like the example program to help folks get started and will circle back with you for review and inclusion when it's further along.

All code has been moved to the main repository @mw10013. Feel free to try out the v1.4.0 Release and let me know if it works as expected!
Again, thank you for reporting this.
It would be great to see a remix-cloudflare-example template from you!


Texting.SendMessage opens texting app

When the attached app runs Texting.SendMessage, it opens one of my separate texting apps, rather than sending it quietly using internal App Inventor libraries. This happened while using the AI2 Companion 2.51a on a Pixel 2 running Android version 9 (April 5, 2019). Please let me know what other information would be helpful.
MillsRaffle.aia.zip

Hi. Just confirming, do you want your app to  send messages without opening default messaging app of your phone?
There is this method, Texting.SendMessageDirect() which sends message immediately without opening any other messaging app.

Just confirming, do you want your app to send messages without opening default messaging app of your phone?

Yes.

There is this method, Texting.SendMessageDirect() which sends message immediately without opening any other messaging app.

I had not realized the behavior of the original method had changed. Thank you for letting me know what to use in the future.

No worries. Both these methods(Texting.SendMessage() and Texting.SendMessageDirect()) are available for use depending upon developers' requirements.

Note that the reason for this change is because of Google Play policy changes with respect to texting and phone call permissions. We were not allowed to keep the permissions needed for the old behavior in the companion app distributed through the Play Store. If you want to test the functionality you will need to install the version from AI2 under Help>Companion Information. The version is 2.51au.

On Apr 13, 2019, at 17:03, Ankriti Sachan<EMAIL_ADDRESS>wrote:
No worries. Both these methods(Texting.SendMessage() and Texting.SendMessageDirect()) are available for use depending upon developers' requirements.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ewpatton, Okay. I just checked version history regarding changes done in Texting so far. Thanks for the information.

@ewpatton Shouldn't we close this issue or anything needs to be done here?


feat: change http library

Previous import workaround causes segfault, which tracked down is an ever-open engine bug https://github.com/ethersphere/bee-js/issues/837

[ ] Re-add before/after hooks
[ ] Re-add retry / timeout
[ ] Re-add custom errors
[ ] Cleanup public interface of request options
[ ] Cleanup utils

Release v6.0.0 addresses this.


fix variables that werent being called

ok there are some key things to checkout here and I will comment in line :innocent: found a few bugs

LGTM

LGTM 🐯


update to node v18, update tansack, fix typescript error in useApprov…

…eAst

this PR is redundant with 2 other active PRs. Can be closed after the other PRs are merged


fix: Select needs two clicks to show the popup when showSearch is true or allowCreate is true

Types of changes

[ ] New feature
[X] Bug fix
[ ] Enhancement
[ ] Documentation change
[ ] Coding style change
[ ] Component style change
[ ] Refactoring
[ ] Test cases
[ ] Continuous integration
[ ] Typescript definition change
[ ] Breaking change
[ ] Others

Background and context
在火狐浏览器下Select组件在设置showSearch=true或者allowCreate=true的时候，需要点击两次才能弹出popup

#1232
Solution
select-view.tsx中原先代码逻辑设置windth： 0去隐藏input，经过测试这种隐藏方式在火狐浏览器下确实存在问题，同时看了代码中的注释需要保证tab键可以聚焦到input上面，最终选择opacity: 0这种最小影响整体代码逻辑的隐藏input方式

How is the change tested?
通过已存在的用例进行测试

Changelog

Component
Changelog(CN)
Changelog(EN)
Related issues

Select
firefox浏览器下当showSearch=true或allowCreate=true时，Select需要单击两次才能显示弹出popup
Fix Select needs two clicks to show the popup when showSearch is true or allowCreate is true
Close: #1232

Checklist:

[X] Test suite passes (npm run test)
[X] Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
[X] Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to main branch)

Other information

抱歉 review 晚了，样式修改不需要更新快照的


Show final build status at the end of the build

Like:
All builds succeeded

Or:
Windows: succeed
Linux: failed

As a workaround:
$ out=$(mktemp -t bran) && bran build | tee $out; grep "1mBuild" $out


Add Spinnaker VMSS CI test

@rguthriemsft @dcaro FYI - enabling the VMSS tests was super easy! They ran just fine using the same structure as the kubernetes test. Example output:
+ PYTHONPATH=.:spinnaker python tests/azure_smoke_test.py --native_host=localhost --spinnaker_azure_account=my-azure-account
test_a_create_app (__main__.AzureSmokeTest) ... ok
test_b_create_security_group (__main__.AzureSmokeTest) ... ok
test_y_delete_security_group (__main__.AzureSmokeTest) ... ok
test_z_delete_app (__main__.AzureSmokeTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 71.209s

OK
Wrote ./azure_smoke_test.html


Big endian support

Check support of big endian platforms.

The remaining issues are image related: blending functions, image loading, etc.

Remaining issues:

BMP loading/saving
Vectorized tvpgl functions


Comparing matlab-mexutils and mexplus

Would you mind comparing matlab-mexutils and mexplus? So that users can quickly know which project they should use according to their requirements.

@vincent-hui - The most striking difference (I just looked at his code very briefly) is that mexplus requires more overhead than mexutils because mexplus keeps C++ instances within C++ and Matlab accesses them via session ID. mexutils on the other hand converts the raw pointer to an 64-bit int and let MATLAB class to manage it. So, I suspect mexplus is more foolproof but a little slower.
Hope this helps


fix: support building on windows

Current dependencies on/for this PR:

main

PR #374   👈

This comment was auto-generated by Graphite.


Yoga description

Add Yoga Description Component

Insert in Ashtanga, Vinyasa, and Private page
Add media query style
Update query to have short_description, yoga_description, yoga_systems

 Yoga Page Component: Yoga Description


Please merge revision #83a615cf4b4acfd6c0fb58a15ed82b09ff1669cf into dev channel

@whesse @mit-mit
Please merge 83a615cf4b4acfd6c0fb58a15ed82b09ff1669cf to ~stable~ dev.  This will pull a new linter (0.1.58) into the SDK.  0.1.58 includes 0.1.57 which adds.

fix to lines_longer_than_80_chars to handle CRLF endings
doc improvements
set max SDK version to <3.0.0
fix to non_constant_identifier_names to better handle invalid code
new lint: curly_braces_in_flow_control_structures

This merged cleanly 👍

Merged in 2.0.0-dev.69.1


167 fix parseurl query

Add action which sets all routing params at once
Change navbar so that it sets the query points and the routing profile at once
make the query store digest the setrutingparamsatonce action

fixes #186

Hups, just noticing that I gave the wrong ticket number in the branch 😅


New package: QCDNUM v0.1.0

Registering package: QCDNUM
Repository: https://github.com/cescalara/QCDNUM.jl
Created by: @cescalara
Version: v0.1.0
Commit: 99adf2121ea379f4f8ec54c581ace24a820d5dc4
Reviewed by: @cescalara
Reference: https://github.com/cescalara/QCDNUM.jl/commit/99adf2121ea379f4f8ec54c581ace24a820d5dc4#commitcomment-60972712
Description: Fast QCD evolution and convolution

Hi, the package is a wrapper so the name is chosen to reflect the original software name (https://www.nikhef.nl/~h24/qcdnum/), hence the all-caps. Let me know if this is a problem.


If clonePath is set, sync to it

Signed-off-by: John Collier<EMAIL_ADDRESS>What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
What does does this PR do / why we need it:
This PR updates the sync code to sync to the devfile's clonePath folder if it's set. Certain devfiles, such as the official Go devfile, rely on this field being set properly (see https://github.com/eclipse/che-devfile-registry/blob/5a41b4b0c85893a6ee99059fcceab35b8a71780c/devfiles/go/devfile.yaml#L46 for example)
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/2741

/retest

@johnmcollier Can you please add steps for how to validate this change with an example. Later we can think upon the possibility of integration test script.

@amitkrout I've added instructions on how to validate.
How to validate:

Download devfile with a project that uses the clonePath field (try https://raw.githubusercontent.com/eclipse/che-devfile-registry/5a41b4b0c85893a6ee99059fcceab35b8a71780c/devfiles/go/devfile.yaml)
Pull down the project specified in the devfile and put in the same folder as the devfile (as https://github.com/openshift/odo/issues/2582 hasn't been implemented)
Build my branch
Run odo push
Verify the project gets synced to /projects/<clonePath> in the remote container

@kadel Thanks for the review! I've updated the PR with changes to only allow relative clonePaths and to not allow .. in the clonePath.

/approve


unable to access ocf_datapipes, encountering gcp permission error

Describe the bug
I am trying to access ocf_datapipes in the project using pv.netcdf in the config file.
code
import ocf_datapipes  # noqa
from ocf_datapipes.training.example.simple_pv import simple_pv_datapipe

import os
import certifi
import ssl

os.environ['SSL_CERT_FILE'] = certifi.where()
ssl._create_default_https_context = ssl._create_unverified_context

config_file = 'pv_config.yaml'
data_pipe = simple_pv_datapipe(configuration_filename=config_file)

try:
    for batch in data_pipe:
        print(batch)  # For debugging: print the shape of the batch
except Exception as e:
    print(f"Encountered an error: {e}")

Screenshot

@peterdudfield, can you please help me with this and let me know if I need to change something in the code?

Would you be able to share what is in pv.yaml?  Perhaps we can modify it so that it doesnt try to get some gcp data

@peterdudfield
input_data:
  pv:
    pv_files_groups:
      - pv_filename: "pv.netcdf"
    time_resolution_minutes: 15
    history_minutes: 60
    forecast_minutes: 30

Ah you'll have to add something for nwp see https://github.com/openclimatefix/ocf_datapipes/blob/main/ocf_datapipes/config/model.py#L592
It would be great to point at ICON, https://github.com/openclimatefix/Open-Source-Quartz-Solar-Forecast/blob/main/quartz_solar_forecast/eval/utils.py#L51, and others

Hello @peterdudfield , i am a bit confused, simple_pv.py handles only pv data. i downloaded the pv.netcdf file from hugging face and is using for testing. It is in my repository.

Ah I see. Hmm. The trace back says it trying to open a nwp file. Can you see where it's doing that?

I think you need to change this
pv_metadata_filename='gs://solar-pv-nowcasting-data/PV/PVOutput.org/UK_PV_metadata.csv
You need to add pv_metadata_filename to your config

Glad we solved it, do you want to close this bug?


add html support for text in Sections

With this change the text of the sections can have html.
As we generate the website locally it should pose any risks

Thanks!


Transfer domain to Cloudflare or Google Domains

Cloudflare Registrar currently doesn't accept .dev domains, even if initially registered elsewhere.
Google Domains is currently unavailable in Denmark.

Transfer the vezel.dev domain to whichever of these is available first. It is currently registered at Dynadot.

Just for the record, I tried to transfer the domain to Google Domains in the hope that it might work even if registering new domains through Google Domains is not possible in Denmark. Unfortunately, that's not the case.


Platform Support

Does not render properly on Safari

Cannot replicate :/

can replicate on MacOS
https://github.com/Leg3ndary/APMC/assets/66791664/f589b16e-b34e-4fba-ab9f-71b7b6982b19

Believe it's been fixed, you can re-open if issue persists


nixos: init moosefs module and test

Motivation for this change
Moosefs is a fault tolerant, distributed filesystem. The package has been in nixpkgs for a quite a while now. This PR adds a module to make it usable in NIxOS.  I had the out-of-tree module successfully running for about one year now. This is good time to mainline the module for 21.11.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for the feedback. I implemented your suggestions and also added an openFirewall option.


Canonical JSON

The spec currently recommends canonical JSON. That has the following requirement:

The members production in object must consist of keys in lexicographically sorted order.

However, a majority of the implementations use Go's encoding/json package which outputs fields in the order they are included in the struct. Should the spec be updated to align with the common behavior, and call out the OCI provided Go structs as the recommended order of the fields?

I'd honestly just axe that whole section -- JSON isn't supposed to be order-dependent (even though it is in practice).

I have an ideal goal of reproducible JSON, even if it doesn't follow the official canonical spec. Reproducible images today, when implemented, often depend on using the same builder, sometimes even the same version of that builder. If we can get to the point of different tools being able to reproduce each other's output, that would improve security in the ecosystem, detecting issues not just with a build host, but an issue with the build tooling itself. I'm hoping the spec can give those implementations a way to interoperate.

If we say our structs are the "canonical order", then 1) we need to evaluate all our structs to decide if we "like" their ordering and 2) decide what to do with fields we don't specify (yet?), which are valid per the spec.  I don't think the benefits are worthwhile here -- if users want "reproducible" images, they'll need to choose an order, and "sorted" order is much saner and more well-supported in general than "the arbitrary order of the structs in the image-spec repo" (which in some languages/tools will be impossible to enforce/adhere to).
See https://github.com/golang/go/discussions/63397#discussioncomment-7201221 for some related discussion in the Go context specifically (in the encoding/json/v2 pre-proposal discussion).

If we say our structs are the "canonical order", then 1) we need to evaluate all our structs to decide if we "like" their ordering

They've been widely used for a long time, so I think there's implicit agreement from the community with the current order.

and 2) decide what to do with fields we don't specify (yet?), which are valid per the spec.

I'm not sure those matter for the reproducibility issue. New fields would get added as needed, with a location decided at the time of the PR, likely with omitempty. Anyone using a new field is intentionally non-reproducible with older tools that do not use the new field. And anyone that adds a custom field is similarly non-reproducible with other tools that don't have those same custom fields.

I don't think the benefits are worthwhile here -- if users want "reproducible" images, they'll need to choose an order, and "sorted" order is much saner and more well-supported in general than "the arbitrary order of the structs in the image-spec repo" (which in some languages/tools will be impossible to enforce/adhere to).

I agree that sorted is saner, and an ideal I'd like to get to. But from the current tooling, it's largely not done, so I'm looking to document the existing state of the ecosystem.

See golang/go#63397 (comment) for some related discussion in the Go context specifically (in the encoding/json/v2 pre-proposal discussion).

If the json/v2 makes sorted struct entries easy to implement, then I'd be in favor to change the advice back to remove the exception for field ordering when that's used in the ecosystem. We could even make that an implementers note now to encourage a future migration.

JSON isn't supposed to be order-dependent (even though it is in practice).

because folks use the same tooling, hence get the same order?
Also, not all tooling is expected to be in golang?

if users want "reproducible" images

hmm.. mandate this in spec and move to "ordered maps" in imeplementation?

Looking over Go's json/v2, I'm seeing functionality for converting JSON output to canonical JSON output: https://pkg.go.dev/github.com/go-json-experiment/json/jsontext#Value.Canonicalize
I think there are a few options:

Delete the canonical recommendation, which makes reproducibility between tools a problem for individual tools to resolve.
Leave the canonical recommendation as is, and leave the spec unchanged, and Go implementations ideally migrate to json/v2 and canonicalize their output in the future. This leaves a gap where our advice does not match real world usage of the spec.
Change the recommendation to align with the common Go output today, with a note that canonical output will likely be recommended in the future (pending json/v2).
Reorder the structs to make Go's output match canonical output. There will be difficult edge cases in trying to implement this, particularly with the embedded Platform field in https://github.com/opencontainers/image-spec/blob/5325ec48851022d6ded604199a3566254e72842a/specs-go/v1/config.go#L101

Of these choices, I feel that 3 gives the best guidance to implementers of the spec.

My vote is still 1


refactor: Use forked ast-utils

The reason we're forking eslint's ast-utils.js file is to allow this plugin
to be compatible with eslint 6. The location of the ast-utils.js file has
changed in eslint 6.

Coverage decreased (-16.9%) to 65.729% when pulling 555d4fb36abadd61913f26c3d1e43d4a72f9abc2 on fketchakeu:make_eslint6_compatible into 2eac37fcaa4cfa86ad7a36793e4a8908e90bfbb6 on silvermine:master.

@fketchakeu I just discussed this IRL with @jimjenkins5 and don't agree with forking this AST code. Forking code comes at great cost and should be avoided in all but the worst-case scenarios. It seems like most of the "need" to fork this is tied up in two causes:

The circular dependency we have because this plugin uses our own config to lint itself, which in turn depends on an older version of this plugin itself, and eslint. Because eslint is a peer dependency, only one version is installed, so at linting time, the new version that the upgraded code depends on is used, but by the old (plugin) code, which breaks.
The concern that the AST code is internal to eslint, who moves it whenever they please.

It seems like the first problem generally only exists for the span of a single MR. I believe we can come up with a way to work around that - either for each time it's needed (roughly one MR in duration), or a more permanent solution. Perhaps doing some kind of "safe require" that looks in multiple places for the AST code would work.
The second problem is a concern as long as eslint considers AST internal. Because their stance on adding features to rules is generally "fork it for yourself," and because those rules generally need the AST code, I've asked @jimjenkins5 to raise an issue (if none already exists) with eslint asking them to expose the AST code as part of their interface - either with the eslint package, or separating it into its own package.
Can you two put your heads together on any innovative solutions you find that allow us to upgrade the plugin to eslint 6 without forking the AST code?

Closing in favor of https://github.com/silvermine/eslint-plugin-silvermine/pull/44.


[2 of 2] Expose EventTypes and add filters for plugins

Preceded by #24
This PR exposes EventTypes and allows filters to decide when the form is ready for submission.

Reviewer: @rcorral


DSSP integration

The DSSP algorithm is a modified version of the Alba Plug-in for Grasshopper (module for secondary structure). In next steps, this version may need reviewing.


Calling fit on FAMD object with numerical data only gives ValueError exception

Observed behavior: I used the example Iris dataset that is given in the documentation. Instead of creating a PCA object, I create a FAMD object.
Not sure exactly why this is happening.
Expected behavior: For purely numerical data (such as in the IRIS dataset) I would expect that the FAMD should produce identical results to the PCA. I see the documentation says to use PCA in this case. So I guess it's a matter of interpretation as to what the expected behavior should be. But at the least another exception saying use 'PCA for purely numerical data'. Anyway, please let me know your thoughts.

FAMD will not work if the data set contains only quantitative variables.

Indeed FAMD should be equivalent to PCA if all the data is numerical. I'm looking into this edge-case now.

Okay I've written a fix. It turns out that it doesn't make any sense to do an FAMD if you don't have both categorical data and numerical data. Fitting an FAMD to a dataset that doesn't contain both type will now raise a helpful ValueError that suggests to the user MCA or PCA (depending on the data).

@MaxHalford  That sounds much better. Thanks.


Slider is going to 1st slide if we scroll the page to bottom on iOS

Hey, this may be similar to #85 I pushed a changed can you check if that solves the issue.

Thanks @vramana

Hey, Can you release a new version?

Yes. I will do it in the evening.

released 0.6.4 with this fix

This issue still exist on iphone

Tested on iphone safari browser.
This is no longer present in latest version (0.6.9)


Parse the serial number during refresh

Parse the serial number of host during refresh.
This is required for:
https://bugzilla.redhat.com/show_bug.cgi?id=1410183
This is dependent on:
https://github.com/ManageIQ/manageiq-providers-ovirt/pull/97

@masayag @pkliczewski @jhernand can someone please review?

Is it RHV specific report? I do not see any information about it. If not how it would behave if the information is not there?

@borod108 can you add a screenshot of what this looks like when it is populated and to @pkliczewski's point can you test what happens when it is not populated (i.e. currently every other infra provider)

@agrare hi, I will add a screen shot, for others it will just show an empty column, not great :(
Do you know how I can limit it for ovirt provider only?

@borod108 I think its fine as an empty column, the UI throws exceptions for missing fields sometimes that's all I wanted to check for :)

 Serial Number parsing in reports


Refactor secrets volume plugin to separate builder and cleaner types

Fixes #9139 for the secret volume
@thockin @markturansky

Assigning to @thockin feel free to rebalance

LGTM

@pmorie  please rebase to fix shippable

@mikedanese rebased

cc @lavalamp


Add last_year_holiday_start_date, last_year_holiday_end_date and last_year_holiday_type to AlertImpendingHoliday

I like the method simplification but probably would have gone for more methods like the name_of_last_year_holiday one to avoid extra instance variables

Thanks @tbhi - was just going with the same format as is there already for consistency 👍


Add support for Local Persist Volume Plugin for Docker

Feature request:
Would like to see support for Local Persist Volume Plugin for Docker: https://github.com/CWSpear/local-persist
E.x when adding volumes on an existing docker service, the choice of using local-persist plugin and specifying host path for the data.

We already support (and use actually) cwspears local-persist.
Just install the driver from the cli, create a volume on the cli using the driver, and from then on, its a drop down choice in Portainer
Rgds,
Neil Cresswell
On 18/04/2018, at 5:21 AM, kjellml80 <notifications<EMAIL_ADDRESS>wrote:
Feature request:
Would like to see support for Local Persist Volume Plugin for Docker: https://github.com/CWSpear/local-persisthttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_CWSpear_local-2Dpersist&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=zsg4mIX7HhPkJrivB2UUzjaxyJGWo8ATQagcGVGrqXY&s=MU9j-F36qFGhcqLL579DlQSF1bkdG5FAXYLMskge9BI&e=
E.x when adding volumes on an existing docker service, the choice of using local-persist plugin and specifying host path for the data.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_1821&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=zsg4mIX7HhPkJrivB2UUzjaxyJGWo8ATQagcGVGrqXY&s=dxjxoYynWqsR6vxAmZpv3zowyWIJcPGV67tcvL7dGl0&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlcNND6lmajyoshBjRf6jN3ZMudURks5tpiR8gaJpZM4TYuOr&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=zsg4mIX7HhPkJrivB2UUzjaxyJGWo8ATQagcGVGrqXY&s=iGWaD9XH7t0baSqeoPmCQJ0-aXvtF0CQ2B_TICtJ-Og&e=.

@kjellml80 as Neil stated, we already support this. What do you think is missing?

I think perhaps the issue here is arm is not supported (raspberry pi)

What is missing is that the volume creation from the web interface doesn't work.

Hi @ea1het , if you are having an issue with Portainer I suggest that you open a bug report and we can take it from there.

I have the same problem. Is opened a ticket already?

@catalin-florescu it appears there has not yet been an bug report opened for this. Feel free to open one yourself :)

@itsconquest i had opened the bug here: https://github.com/portainer/portainer/issues/2907

I will now close this feature request as the feature is already supported.
Please refer the bug report here: #2907 for any discussion or updates on the mount point issue.

Why is this not easily accessible in the web interface?


Implement getOutputAmount() in all pair interface to pre-compute final output

Implement getOutputAmount() in all pair types to compute the output amount given an input token & input amount.
Implement getOutputAmount() inside swappa router to compute the final output of a given swap path

thanks for doing this. I like this version a lot more and this is probably fine to merge.

I'm looking through the deployer script, and I think if we treat this change as a version bump, we'd need to:

bump ISwappaPair interface to interface ISwappaPairV2 is ISwappaPairV1 and have the new method only in the V2 interface
define ISwappaRouterV1 interface, and define ISwappaRouterV2 interface with the new method
Move the swappa router changes to contract SwappaRouterV2 is SwappaRouterV1, ISwappaRouterV2
Update the TS code that interacts with SwappaV1 contract to instead refer to interface ISwappaRouterV1, later point it to interface V2 when router V2 is deployed

How do you want to handle the migration? Version bump to V2 or just keep it all as V1 and just re-deploy with the existing V1 deployer script?

I'm looking through the deployer script, and I think if we treat this change as a version bump, we'd need to:

bump ISwappaPair interface to interface ISwappaPairV2 is ISwappaPairV1 and have the new method only in the V2 interface
define ISwappaRouterV1 interface, and define ISwappaRouterV2 interface with the new method
Move the swappa router changes to contract SwappaRouterV2 is SwappaRouterV1, ISwappaRouterV2
Update the TS code that interacts with SwappaV1 contract to instead refer to interface ISwappaRouterV1, later point it to interface V2 when router V2 is deployed

How do you want to handle the migration? Version bump to V2 or just keep it all as V1 and just re-deploy with the existing V1 deployer script?

This will require re-deploying all contracts anyways so version bump in the name isn't necessary. I will handle deployments and all that since it will require re-verifying source for SwappaRouter.
Only change/inconvinience for users is that they will need to approve new SwappaRouter address since it will change.

i wil lactually merge and do final cleanups.


The Wall

The original issue https://github.com/cryogen/throneteki/issues/139 was closed after https://github.com/cryogen/throneteki/commit/ba44633dec2ca68c87197263b7654098b16389ee but it was not fixed.

When a duped The Wall is knelt, a prompt to trigger it at the end of the challenge phase is still shown (not sure the duplicate is responsible for this but that was the situation).

A duped Wall will also auto-provide its boost twice (and maybe thrice if there's a triplicate).

Related suggestion: add a menu to the Wall, where you can add/remove the +1 to all NW characters in play on the right side of the board? (especially useful for Nightmares)

The fix is not deployed yet :)

Ah I thought it had been committed into master already? I need to learn how to read Github right, apologies!

It has, but the server needs to be restarted to get the latest code

Server now has the latest code


[Refactor]: remove webapck in main-app

Ref: https://github.com/netless-io/flat/pull/1678
Now we use esbuild in main-app, so webpack library can remove.

I m looking into it.

We already moved main-app from webpack to esbuild, closing as it was implemented.


Error handlers missing next param

Found a weird thing, not sure if it's a bug from express or express-generator.
Generated app.js contains this

// development error handler
// will print stacktrace
if (app.get('env') === 'development') {
    app.use(function(err, req, res) {
        res.status(err.status || 500);
        res.render('error', {
            message: err.message,
            error: err
        });
    });
}

// production error handler
// no stacktraces leaked to user
app.use(function(err, req, res) {
    res.status(err.status || 500);
    res.render('error', {
        message: err.message,
        error: {}
    });
});

and I have some routers used like this app.use('/users', usersRouter), but if I do next(e) in some route when an error happen, it never goes inside error handlers. I pull my hair a thousand time before find out that adding next at the function signature make it goes in!
So now my error handlers are like
app.use(function(err, req, res, next) {
    res.status(err.status || 500);
    ...

Is that normal?

Yes. This is how error middleware work in Express, so it's not a bug. You must have a function that takes exactly 4 arguments. You can read more about it here: http://expressjs.com/guide/error-handling.html

So it's a bug in express-generator then.

Yep. It's been fixed for a long time, so you need to upgrade it on your machine.


Feature/994/195 test verbosity

What this PR changes/adds

./gradlew clean test does not log anything from (successful) test runs.
A runtime flag is available (and documented) to make test runs verbose.
With ./gradlew clean test, if a test fails, the test name and failure cause are printed

Why it does that
Improve developer experience
Further notes
Fixed BaseRuntime so as not to apply a shutdown hook to tests, that was causing extra logging at test completion.
Sample run showing clear message when a test fails:
https://github.com/agera-edc/DataSpaceConnector/runs/5749889045?check_suite_focus=true
2022-03-30T07:23:21.2000714Z CoreServicesExtensionIntegrationTest > shouldProvideHostnameExtension(Hostname) FAILED
2022-03-30T07:23:21.2001408Z     java.lang.AssertionError: Something strange happened
2022-03-30T07:23:21.2002146Z         at org.eclipse.dataspaceconnector.core.CoreServicesExtensionIntegrationTest.shouldProvideHostnameExtension(CoreServicesExtensionIntegrationTest.java:40)
2022-03-30T07:23:27.6996011Z

Linked Issue(s)
Related to #195
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] added relevant details to the changelog? (skip with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #197 (33b41cc) into feature/994-test-verbosity (705a447) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@                       Coverage Diff                        @@
##             feature/994-test-verbosity     #197      +/-   ##
================================================================
- Coverage                         63.09%   63.06%   -0.04%
+ Complexity                         2551     2550       -1
================================================================
  Files                               633      633
  Lines                             13679    13684       +5
  Branches                            953      954       +1
================================================================
- Hits                               8631     8630       -1
- Misses                             4606     4611       +5
- Partials                            442      443       +1

Impacted Files
Coverage Δ

...paceconnector/boot/system/runtime/BaseRuntime.java
0.00% <0.00%> (ø)

...econnector/core/health/HealthCheckServiceImpl.java
97.67% <0.00%> (-2.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 705a447...33b41cc. Read the comment docs.


Creating a template

I feel the main issue when trying to use this gem is creating the template and adding mail merge feature. It took me some time to figure it out, so I decided to list out the steps to prevent others from going through the pain of learning it again.

Thanks very much for the detailed documentation.


MacOS macports compile fails

LocalAI version:

commit e022b59
Environment, CPU architecture, OS, and Version:

Darwin pebbles.local 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:31:00 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6020 arm64
Describe the bug

when using macports to compile, compilation fails
To Reproduce

do make build with dependencies installed via macports instead of homebrew
Expected behavior

compilation should succeed
Logs

[ 94%] Building CXX object examples/grpc-server/CMakeFiles/hw_grpc_proto.dir/backend.grpc.pb.cc.o
In file included from /Users/rlippmann/Source/LocalAI/backend/cpp/llama/llama.cpp/build/examples/grpc-server/backend.grpc.pb.cc:5:
/Users/rlippmann/Source/LocalAI/backend/cpp/llama/llama.cpp/build/examples/grpc-server/backend.pb.h:10:10: fatal error: 'google/protobuf/port_def.inc' file not found
#include <google/protobuf/port_def.inc>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[4]: *** [examples/grpc-server/CMakeFiles/hw_grpc_proto.dir/backend.grpc.pb.cc.o] Error 1
make[3]: *** [examples/grpc-server/CMakeFiles/hw_grpc_proto.dir/all] Error 2
make[2]: *** [all] Error 2
make[1]: *** [grpc-server] Error 2
make: *** [backend/cpp/llama/grpc-server] Error 2
Additional context

It looks like the makefiles aren't looking in /opt/local/include, where macports stores its includes.

I've never used macports personally but one thing that I have to do in order to get my directories to work properly with is to set up the following two variables:
export C_INCLUDE_PATH=/usr/local/include
export CPLUS_INCLUDE_PATH=/usr/local/include

Therefore... can you clean your build, then try running the following command in your terminal before rebuilding?
export C_INCLUDE_PATH=/opt/local/include
export CPLUS_INCLUDE_PATH=/opt/local/include

I am really glad you posted this issue - I was about to hardcode the /usr/local/include stuff by default on OSX builds as so far, this seemed like a pointlessly painful step... Guess I'll need to revisit that idea and try to come up with some way to tell the difference between homebrew and macports!

Oh, and the C_INCLUDE_PATH and CPLUS_INCLUDE_PATH worked :)


Your Coffee is returning a perms error

Looking to send  a th$ but clicking the Paypal returns:
You do not have permission to access or perform operations on this resource.
(I'm able to log into my paypal acct via the submitted email)

Sorry Steve, I'm not sure what's wrong it could be the web site having an issue. I added the alternative site
http://ko-fi.com/brianmello
Try that out instead.

Worked -- thx!


Pagination broken (at least for beta datastore emulator)

TL;DR: Recommended pagination termination check of info.moreResults !== Datastore.NO_MORE_RESULTS fails.  The variable info.moreResults is alwaysMORE_RESULTS_AFTER_LIMIT, even if query returned no results.
Steps to reproduce

The code is available here: https://github.com/tianhuil/react-static-ts/blob/test-datastore/gae/backend/src/datastore.int.test.js
The makefile is available here: https://github.com/tianhuil/react-static-ts/blob/test-datastore/gae/Makefile

Just clone the repo, cd into the GAE directory, run npm i, and make test-datastore after appropriate node.  You'll need a beta datastore emulator's host / port set to the environment variable DATABASE_HOST.
The code has two versions of the pagination code:

One checks only info.moreResults !== Datastore.NO_MORE_RESULTS and fails (infinite loop)
The other checks info.moreResults !== Datastore.NO_MORE_RESULTS && entities.length > 0 and completes with the correct answer.

Environment details

OS: OSX
Node.js version: v12.6.0
npm version: 6.11.3
@google-cloud/datastore version: 4.3.0

Thanks!

This is unfortunately a long standing bug with the emulator :( https://github.com/GoogleCloudPlatform/google-cloud-datastore/issues/130

Thanks!

Our library already does the NOT_FINISHED check. The user in an emulator could check for entities.length, although I’m not sure if that has any gotchas.


Review specificity of Exception catches within SMARTS

Is it a problem? Please describe.
Exception catching has smothered issues within the project.
Describe the solution you'd like
A review of the smarts directory code for all instances of Exception catches to ensure that exception catches response is specific to the exception that has been thrown.
Additional context
https://github.com/huawei-noah/SMARTS/pull/1156

Hey, I would like to work on this, can you suggest me ways to get started?

Hello @PracticalMetal , thank you for reaching out and I am happy to hear that you wish to help out.
The problem
The main intention of this problem is to ensure that exception catches are not accidentally hiding issues within the smarts directory code. The need here is to find cases where we are catching the generic Exception, or where we are catching a specific exception type and throwing a generic Exception.
Helpful information
Over today I will be putting up a number of other issues if you wish to pick one of them.
We have a guide for setting up SMARTS here: https://github.com/huawei-noah/SMARTS/tree/develop#setup
We have some guidelines here for contributing: https://github.com/huawei-noah/SMARTS/blob/develop/CONTRIBUTING.md
I also believe the following information is relevant:

We currently support python 3.7 and 3.8 officially. You will get varying millage out of other versions of python.
It is possible upon following the setup guide that the test_smarts_doesnt_leak_tasks_after_reset will still fail without giving a proper explanation why. This is a known issue here: https://github.com/huawei-noah/SMARTS/issues/1154. Even if this specific case fails you can still use the parts of SMARTS that do not require rendering.
You will want to make a fork of the SMARTS repository so you can open up a pull request against it.
Work towards the release is merged into the develop branch, documentation should be read from the develop branch version
Right now we are working towards a 0.5 release so changes are allowed to break the currently existing public interface

If you have any other questions feel free to ask.


Incorrect URL on apiary documentation

Was using the documentation to create user groups via the API, kept getting 404 errors. Turns out the URL in the doc is 'api/groups' instead of 'api/user_groups', at least I assume because I got a real response for the latter.

Linked to https://github.com/zooniverse/Panoptes/commit/da8579bc0edac797c9a6ca79d2cea480c091a7dd, will get a fix in for the docs soon. @bruggsy feel free to submit PR's for the api docs when you discover mistakes.


Alternate version 2: do analysis on CloudFormation

[ ] support more resources (computing edges, computing constraints)
[ ] add mechanism for user-provided metric estimates
[ ] add mechanism for user-provided constraint generator

S3:

[ ] LambdaConfigurations
[ ] EventBridgeConfiguration
[ ] QueueConfigurations
[ ] TopicConfigurations
[ ] AccessPoint
[ ] metrics.....

Lambda EventSourceMapping:

[ ] monthly_requests

SQS:

[ ] monthly_requests

Lambda:

[ ] user-provided constraint generation

SNS Subscription:

[ ] monthly_requests (?)

SNS Topic:

[ ] monthly_requests (?)

S3 AccessPoint:

[ ] constraints....


Remove symlinks

Coverage remained the same at 100.0% when pulling 610179a91791610fd3d0c459befcb619e94b625e on remove_symblinks into a0b3580bcbd625fc9dc9e26d72be53379fe551f0 on master.

Coverage remained the same at 100.0% when pulling aacec000f384e380f928333730cc5f225ee3b504 on remove_symblinks into a0b3580bcbd625fc9dc9e26d72be53379fe551f0 on master.

Coverage remained the same at 100.0% when pulling 6f5df5d63a637ae0db173e0c11815fe0ef23b2b3 on remove_symblinks into a0b3580bcbd625fc9dc9e26d72be53379fe551f0 on master.

Coverage remained the same at 100.0% when pulling 6f5df5d63a637ae0db173e0c11815fe0ef23b2b3 on remove_symblinks into a0b3580bcbd625fc9dc9e26d72be53379fe551f0 on master.

This should hopefully resolve the following issue: https://github.com/tom-lord/regexp-examples/issues/9


Crash on start

Hi! I have followed the installation guide, using kubridge and rePatch plugins, but my game crashes on startup without loading anything.
It does look like I did something wrong with the installation, but I double checked everything twice. The only thing that I have only version 1.1.5 of the original HOMM3 Android vpk and files. Could that be the issue? Could you please help me trace the problem?
Attached my crash dump. psp2core-1703023367-0x00000b2657-eboot.bin.zip

Yeah, 1.1.5 is definitely a problem. The wrapper was made with 1.1.6 is mind, so any other version is unsupported.


Uncaught Error: No encoding-indexes.js

Just encountered this intermittent issue with the vtt.min.js library. When loaded in a browser, it occassionally throws this error and stops execution:

Sometimes it blocks execution, sometimes it works, either way when in the context of a web browser this is not needed, per the code comments:
// If we're in node require encoding-indexes and attach it to the global.
if (typeof module !== "undefined" && module.exports) {
  this["encoding-indexes"] = require("./encoding-indexes.js")["encoding-indexes"];
}

Any ideas? We're going to remove it at this point from our build...

Hi tvpmb, I am getting a similar issue on my end when introducing vtt.js as a dependency. Did removing it from the build work for you?

That piece of code comes from https://github.com/inexorabletash/text-encoding/blob/3f330964c0e97e1ed344c2a3e963f4598610a7ad/lib/encoding.js#L11-L16.
It's likely that if you're using the dist file of vtt.js and things get compiled into one file, it's not loading from the right directly.
FWIW, in the Video.js fork of vtt.js we've removed the dependency on text-encoding as most of the time it isn't an issue.


Enhancement: Improvements to iohyve list and info

This pull request contains three commits to improve the visibility of multiple pool installations. See each commit for full details.
2f2b3c7:
iohyve info was rewritten to include the description when spaces are present. Each pool gets it's own table of output but everything is aligned as a single block of output for readability. The -d flag was removed.
0548ceb
iohyve list now contains the pool name in the output. This is to increase visibility for multi pool installations.
1f44663
This supports the documentation (man page, text, and iohyve help) to reflect changes from 2f2b3c7.

Alright, this is a tricky one.
I already had some list cleaning I wanted to do (briefly mentioned here).
Part of this was completely removing description from the info function and adding tap and con instead.
I would like to keep the list function simple, with basically what it has now, so maybe adding pool to the info function would be better.
Last but not least, I wanted to add a --less flag so you could scroll through a large list that takes up too much of the terminal.
If you do not want to make these changes, no problem, I'll add these specific points to the roadmap above. Especially the pool option.
I'm open to discussion.

Also, I'd like to mention we generate the iohyve.8 man page with a one-liner utilizing txt2man:
cat iohyve.8.txt | txt2man -t iohyve -s 8 -v "FreeBSD System Manager's Manual" > iohyve.8

Thank you for the heads up on the rebuilding the man page file. I noticed the header about the same time you posted and was trying to figure it out when I noticed your message here. Thank you.
Added commits to update a couple definitions and then a properly rebuilt man page file.

Did you happen to see my previous notes before the man page comment?

I missed that post actually, thanks.
First thing I have to ask, is do you really have that many guests that --less is necessary? Can you ballpark a number?
What if I kept the output format I have created so far but put it under -v for verbose and then made something more to your liking under the normal command? Also maybe use -l instead of --less.

tparis@DeltaFlyer:~/iohyve % iohyve list | wc -l
      46
tparis@DeltaFlyer:~/iohyve %

They all don't run at the same time, only about ~8ish at a time, but I have different VMs for different projects and ideas. Some are clones of templates, too.  I usually just manually run iohyve list | less or iohyve info | less.  You should see my snaplist output.
Let's keep the list function untouched, but remove description from the info function.
Maybe info without options will output size, cpu, ram, and pool.

Be sure to read the previous post on GitHub, not on email, so you can see my edits before I accidentally closed this PR.

Wow, that's quiet a few guests.
I will work on these changes this weekend.

Is it possible to list IPs of the VMs when using the iohyve list command?
I have all of the VMs using DHCP. It is a pain to console into each VM to get the IP

Not within iohyve, especially when using DHCP. Maybe add static DHCP mapping to your DHCP server and then add the IP in the description property?

Ok thanks for the workaround

Okay I made some changes. I hope they are to your liking.
There is more code in list() but there are flags to dial up the verbosity. The description field is removed by default as requested above. The tap and con fields are turned on by -v, the description field is turned back on by -dflag, and using the -l flag pipes the output to less.
I also reworked info() as well, the code is very similar to list(). There is a lot more code due to the extra fields but I am very happy with the flexibility of it. The old code was so concise. This sub-function follows the same pattern as list where the verbosity can be dialed up using flags. The default output is to list guest name, size, CPU, and RAM. Using the -p flag turns on the pool field; the -v(verbose) flag turns on the OS, loader, tap, and con fields; the -s (status) flag turns on the VMM, running, and rcboot fields; the -d flag turns on the description field; and using the -l flag pipes the output to less.
To use all some flags for info the command would be iohyve list -psl or any order on the flags. The order of the flags does not influence the order of the columns, sorry. Any combination of flags can be used, I wrote the code to be flexible enough for that.
Let me know if you would like to see any further changes. I hope you like the results.
Also @pr1ntf thank you for amusing my curiosity with the number of guests. It was pure curiosity, I re-read the question and realized it could of come off as aggressive. My sincerest apologies if it came off that way, not my intention at all. Also thank you with the follow ups yesterday, it was quiet a long day with little sleep.
Here is the before and after for iohyve list
Before:
root@bhost:~ # iohyve list
Guest      VMM?  Running  rcboot?  Description
testing    YES   YES      NO       Thu Apr  7 10:37:59 MDT 2016
guest      YES   YES      NO       Ubiquiti mFi Controller Appliance
gst01      NO    NO       NO       Internal https
obsdguest  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016

After:
root@bhost:~ # iohyve list
Guest      VMM?  Running  rcboot?
testing    YES   YES      NO
guest      YES   YES      NO
gst01      NO    NO       NO
obsdguest  NO    NO       NO
root@bhost:~ # iohyve list -d
Guest      VMM?  Running  rcboot?  Description
testing    YES   YES      NO       Thu Apr  7 10:37:59 MDT 2016
guest      YES   YES      NO       Ubiquiti mFi Controller Appliance
gst01      NO    NO       NO       Internal https
obsdguest  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016
root@bhost:~ # iohyve list -dv
Guest      VMM?  Running  rcboot?  Tap      Con     Description
testing    YES   YES      NO       tap7011  nmdm17  Thu Apr  7 10:37:59 MDT 2016
guest      YES   YES      NO       tap7003  nmdm1   Ubiquiti mFi Controller Appliance
gst01      NO    NO       NO       tap7004  nmdm10  Internal https
obsdguest  NO    NO       NO       tap7010  nmdm16  Wed Apr  6 14:18:44 MDT 2016
root@bhost:~ # iohyve list -dvl
root@bhost:~ #

Here is the before and after for iohyve info
Before:
root@bhost:~ # iohyve info
Name             Size  RAM     CPU  OS         Loader
testing          -     256M    1    default    bhyveload
testing/disk0    10G   256M    1    default    bhyveload
guest            -     4G      2    debian     grub-bhyve
guest/disk0      200G  4G      2    debian     grub-bhyve
gst01            -     512M    1    default    bhyveload
gst01/disk0      40G   512M    1    default    bhyveload
obsdguest        -     256M    1    openbsd59  grub-bhyve
obsdguest/disk0  8G    256M    1    openbsd59  grub-bhyve
root@bhost:~ # iohyve info -d
Name             Size  RAM     CPU  OS         Loader      Description
testing          -     256M    1    default    bhyveload   Thu          Apr  7           10:37:59          MDT      2016
testing/disk0    10G   256M    1    default    bhyveload   Thu          Apr  7           10:37:59          MDT      2016
guest            -     4G      2    debian     grub-bhyve  Ubiquiti     mFi  Controller  Appliance
guest/disk0      200G  4G      2    debian     grub-bhyve  Ubiquiti     mFi  Controller  Appliance
gst01            -     512M    1    default    bhyveload   Internal         https
gst01/disk0      40G   512M    1    default    bhyveload   Internal         https
obsdguest        -     256M    1    openbsd59  grub-bhyve  Wed          Apr  6           14:18:44          MDT      2016
obsdguest/disk0  8G    256M    1    openbsd59  grub-bhyve  Wed          Apr  6           14:18:44          MDT      2016

After:
root@bhost:~ # iohyve info
Guest            Size  CPU  RAM
testing          -     1    256M
testing/disk0    10G   1    256M
guest            -     2    4G
guest/disk0      200G  2    4G
gst01            -     1    512M
gst01/disk0      40G   1    512M
obsdguest        -     1    256M
obsdguest/disk0  8G    1    256M
root@bhost:~ # iohyve info -p
Guest            Size  CPU  RAM     Pool
testing          -     1    256M    apool
testing/disk0    10G   1    256M    apool
guest            -     2    4G      zpool
guest/disk0      200G  2    4G      zpool
gst01            -     1    512M    zpool
gst01/disk0      40G   1    512M    zpool
obsdguest        -     1    256M    zpool
obsdguest/disk0  8G    1    256M    zpool
root@bhost:~ # iohyve info -pv
Guest            Size  CPU  RAM     Pool       OS         Loader      Tap      Con
testing          -     1    256M    apool      default    bhyveload   tap7011  nmdm17
testing/disk0    10G   1    256M    apool      default    bhyveload   tap7011  nmdm17
guest            -     2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1
guest/disk0      200G  2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1
gst01            -     1    512M    zpool      default    bhyveload   tap7004  nmdm10
gst01/disk0      40G   1    512M    zpool      default    bhyveload   tap7004  nmdm10
obsdguest        -     1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16
obsdguest/disk0  8G    1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16
root@bhost:~ # iohyve info -pvs
Guest            Size  CPU  RAM     Pool       OS         Loader      Tap      Con     VMM?  Running  rcboot?
testing          -     1    256M    apool      default    bhyveload   tap7011  nmdm17  YES   YES      NO
testing/disk0    10G   1    256M    apool      default    bhyveload   tap7011  nmdm17  NO    NO       NO
guest            -     2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    YES      NO
guest/disk0      200G  2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    NO       NO
gst01            -     1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO
gst01/disk0      40G   1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO
obsdguest        -     1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO
obsdguest/disk0  8G    1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO
root@bhost:~ # iohyve info -pvsd
Guest            Size  CPU  RAM     Pool       OS         Loader      Tap      Con     VMM?  Running  rcboot?  Description
testing          -     1    256M    apool      default    bhyveload   tap7011  nmdm17  YES   YES      NO       Thu Apr  7 10:37:59 MDT 2016
testing/disk0    10G   1    256M    apool      default    bhyveload   tap7011  nmdm17  NO    NO       NO       Thu Apr  7 10:37:59 MDT 2016
guest            -     2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    YES      NO       Ubiquiti mFi Controller Appliance
guest/disk0      200G  2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    NO       NO       Ubiquiti mFi Controller Appliance
gst01            -     1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO       Internal https
gst01/disk0      40G   1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO       Internal https
obsdguest        -     1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016
obsdguest/disk0  8G    1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016
root@bhost:~ # iohyve info -pvsdl
root@bhost:~ #

Great work! Buuuuuuut..... I'm sorry for the confusion, I wanted the list function to remain unchanged.

Let's keep the list function untouched, but remove description from the info function.
Maybe info without options will output size, cpu, ram, and pool.
Info with the -v flag can add os, loader, tap, and con.

I'm so sorry to be the benevolent dictator of iohyve, especially when you've been helping out so much.
If you've got other ideas and suggestions, I'm all ears.

Is it alright if the other flags remain?
If I am understanding correctly, below is the desired output for flagless and using -v flags. The -l is there as a request to pipe to less. The other flags are there because they make my heart go pitter-pat. In addition, if new properties are added with this code base they will be easy to flag in without changing the look from previous versions.
Here is the before and after for iohyve list (Revised)
Before:
root@bhost:~ # iohyve list
Guest      VMM?  Running  rcboot?  Description
testing    YES   YES      NO       Thu Apr  7 10:37:59 MDT 2016
guest      YES   YES      NO       Ubiquiti mFi Controller Appliance
gst01      NO    NO       NO       Internal https
obsdguest  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016

After:
root@bhost:~ # iohyve list
Guest      VMM?  Running  rcboot?  Description
testing    YES   YES      NO       Thu Apr  7 10:37:59 MDT 2016
guest      YES   YES      NO       Ubiquiti mFi Controller Appliance
gst01      NO    NO       NO       Internal https
obsdguest  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016
root@bhost:~ # iohyve list -v
Guest      VMM?  Running  rcboot?  Tap      Con     Description
testing    YES   YES      NO       tap7011  nmdm17  Thu Apr  7 10:37:59 MDT 2016
guest      YES   YES      NO       tap7003  nmdm1   Ubiquiti mFi Controller Appliance
gst01      NO    NO       NO       tap7004  nmdm10  Internal https
obsdguest  NO    NO       NO       tap7010  nmdm16  Wed Apr  6 14:18:44 MDT 2016
root@bhost:~ # iohyve list -vl
root@bhost:~ #

Here is the before and after for iohyve info (Revised)
Before:
root@bhost:~ # iohyve info
Name             Size  RAM     CPU  OS         Loader
testing          -     256M    1    default    bhyveload
testing/disk0    10G   256M    1    default    bhyveload
guest            -     4G      2    debian     grub-bhyve
guest/disk0      200G  4G      2    debian     grub-bhyve
gst01            -     512M    1    default    bhyveload
gst01/disk0      40G   512M    1    default    bhyveload
obsdguest        -     256M    1    openbsd59  grub-bhyve
obsdguest/disk0  8G    256M    1    openbsd59  grub-bhyve
root@bhost:~ # iohyve info -d
Name             Size  RAM     CPU  OS         Loader      Description
testing          -     256M    1    default    bhyveload   Thu          Apr  7           10:37:59          MDT      2016
testing/disk0    10G   256M    1    default    bhyveload   Thu          Apr  7           10:37:59          MDT      2016
guest            -     4G      2    debian     grub-bhyve  Ubiquiti     mFi  Controller  Appliance
guest/disk0      200G  4G      2    debian     grub-bhyve  Ubiquiti     mFi  Controller  Appliance
gst01            -     512M    1    default    bhyveload   Internal         https
gst01/disk0      40G   512M    1    default    bhyveload   Internal         https
obsdguest        -     256M    1    openbsd59  grub-bhyve  Wed          Apr  6           14:18:44          MDT      2016
obsdguest/disk0  8G    256M    1    openbsd59  grub-bhyve  Wed          Apr  6           14:18:44          MDT      2016

After:
root@bhost:~ # iohyve info
Guest            Size  CPU  RAM     Pool
testing          -     1    256M    apool
testing/disk0    10G   1    256M    apool
guest            -     2    4G      zpool
guest/disk0      200G  2    4G      zpool
gst01            -     1    512M    zpool
gst01/disk0      40G   1    512M    zpool
obsdguest        -     1    256M    zpool
obsdguest/disk0  8G    1    256M    zpool
root@bhost:~ # iohyve info -v
Guest            Size  CPU  RAM     Pool       OS         Loader      Tap      Con
testing          -     1    256M    apool      default    bhyveload   tap7011  nmdm17
testing/disk0    10G   1    256M    apool      default    bhyveload   tap7011  nmdm17
guest            -     2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1
guest/disk0      200G  2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1
gst01            -     1    512M    zpool      default    bhyveload   tap7004  nmdm10
gst01/disk0      40G   1    512M    zpool      default    bhyveload   tap7004  nmdm10
obsdguest        -     1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16
obsdguest/disk0  8G    1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16
root@bhost:~ # iohyve info -vs
Guest            Size  CPU  RAM     Pool       OS         Loader      Tap      Con     VMM?  Running  rcboot?
testing          -     1    256M    apool      default    bhyveload   tap7011  nmdm17  YES   YES      NO
testing/disk0    10G   1    256M    apool      default    bhyveload   tap7011  nmdm17  NO    NO       NO
guest            -     2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    YES      NO
guest/disk0      200G  2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    NO       NO
gst01            -     1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO
gst01/disk0      40G   1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO
obsdguest        -     1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO
obsdguest/disk0  8G    1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO
root@bhost:~ # iohyve info -vsd
Guest            Size  CPU  RAM     Pool       OS         Loader      Tap      Con     VMM?  Running  rcboot?  Description
testing          -     1    256M    apool      default    bhyveload   tap7011  nmdm17  YES   YES      NO       Thu Apr  7 10:37:59 MDT 2016
testing/disk0    10G   1    256M    apool      default    bhyveload   tap7011  nmdm17  NO    NO       NO       Thu Apr  7 10:37:59 MDT 2016
guest            -     2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    YES      NO       Ubiquiti mFi Controller Appliance
guest/disk0      200G  2    4G      zpool      debian     grub-bhyve  tap7003  nmdm1   NO    NO       NO       Ubiquiti mFi Controller Appliance
gst01            -     1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO       Internal https
gst01/disk0      40G   1    512M    zpool      default    bhyveload   tap7004  nmdm10  NO    NO       NO       Internal https
obsdguest        -     1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016
obsdguest/disk0  8G    1    256M    zpool      openbsd59  grub-bhyve  tap7010  nmdm16  NO    NO       NO       Wed Apr  6 14:18:44 MDT 2016
root@bhost:~ # iohyve info -vsdl
root@bhost:~ #

Don't even worry about touching the description function at all.
The info changes look great, though! :+1:
Again, sorry for the confusion.
I've done quite a bit to the script the past week, there are conflicts with this PR.

I am guessing you meant list function. I left the -l flag to pipe to less. Let me know if that needs to be removed too.
Thanks.

Lookin good in the neighborhood.


Update dependency version in envoyproxy/envoy to 0.1.11

Hi 👋 - hope this is the right place. I opened this issue here rather than in Envoy because it seems like @dgoffredo is a maintainer here, and is the one updating the version in Envoy. If this is not the right place, my apologies.
It seems like Envoy is still using the 0.1.8 version of this library here. This is true as of the latest release (yesterday, 1.19.4). It should probably be updated to 0.1.11. I'm not too sure how involved this is, or I would open a PR - plus I think it's probably more likely to be accepted by the maintainers here.

Hi, Ben. A recent release of dd-trace-cpp contains changes that would break the Datadog-related unit tests within Envoy.
My teammate is working on a PR within Envoy that will make the tests compatible with more recent versions of dd-trace-cpp.
Then, we will update the version of dd-trace-cpp used within Envoy.
Is there a feature or fix in more recent versions of dd-trace-cpp that you're looking for in Envoy?

Great to hear.
The issue we're running into is that with Envoy 1.27 the span names are different than with 1.26. In 1.26 the span names are envoy.proxy, while in 1.27 they show up as (what looks to be) the name of the service. This in turn leads some metrics to go missing (specifically trace.envoy.proxy.hits). At least - I think that's what's happening. I haven't got too much hands on experience with tracing / cpp though.
That said, when I dug a bit into the tracing code and old PRs, I saw that the changes here (specifically the change to setOperation) don't exist in release/v1.27 of envoy. I think the backport here was probably missing some things.
It's a little late for me, but would be happy to try updating the backport tomorrow if this sounds like it's the right direction.

Yes, the "operation name is wrong in v1.27 and v1.28" was fixed and backported onto those release branches. You can pick up those changes whenever Envoy produces another release in either series. That will fix that problem.
The "setting the 'resource.name' tag doesn't work anymore" issue was fixed on the main branch, but the process of proposing backports has stalled. Perhaps I can propose the backport PRs myself.

I haven't worked on Envoy much, but I found these docs if it's helpful. Specifically, they say that if you add backport/review as a label, that starts the process (apparently).

Just to follow up, I opened backport PRs against 1.27, 1.28, hope that's ok:

https://github.com/envoyproxy/envoy/pull/30892
https://github.com/envoyproxy/envoy/pull/30893

Interesting experience getting everything running locally, but tests were passing locally for both patches.

Hello everyone,
I work for Wayfair, and we had a support case with DD number 1339031. I've been following multiple issues in the past two months, and it seems that the problem is finally resolved. If I understood correctly, we would still need new builds for Envoy 1.27.x and 1.28.x versions, and they will be included in the next Istio patch versions. Is that correct?
Are you planning to upgrade the official documentation once this is done? It appears that the latest supported version is v.1.17, and that was what the support was referring to when we were complaining about traces being broken in Istio v.1.19.
Could you also describe any changes related to the DD tracing library that we can expect in Istio versions newer than v1.17, such as the one related to the resource name not being taken from the tag resource.name? These changes may require some of additional adjustments on our side, and we need to communicate this to developers.
Including these details in the official documentation would help to clarify that it's related to DD Istio integration.

Hi, Njegos. I don't know which case number 1339031 refers to. There is Zendesk, which I believe Datadog uses to communicate with customers about Support issues, and then we use another system internally when Support interacts with Engineering. What is the issue that you're referring to with number 1339031?
The table in the environment variables section of the documentation you linked is indeed not up to date. I wasn't aware that it exists.
The changes to Envoy that have caused these issues (the unexpected change in operation name, the inability to set the resource name via the "resource.name" tag, and an unintended sampling override) were made to move Envoy from an older OpenTracing-based Datadog tracing library to this newer tracing library (dd-trace-cpp). So, the version numbers tabulated will not be comparable for present and future versions of Istio that use the newer Envoys. On the other hand, dd-trace-cpp has major version zero (0.x.y), so there might not be any confusion.
I'll see to it that the documentation is updated. We have a work item to revisit our Istio documentation more extensively, as methods of deployment have changed since we initially developed the integration.
None of these problematic changes were intentional, and so I can't anticipate what others, if any, might be found. Here's a list of recent Envoy Datadog tracing issues (i.e. issues starting with Envoy v1.27) that I know about:

The default Datadog span name changed for spans created by Envoy: https://github.com/envoyproxy/envoy/pull/29932
The ability to set the Datadog resource name by setting the "resource.name" tag stopped working: https://github.com/envoyproxy/envoy/pull/30503
When Envoy's sampling rate (not to be confused with Datadog's sampling rate) is less then 100%, then drop decisions made by Envoy override any decision extracted from incoming request headers (this can break traces): https://github.com/envoyproxy/envoy/pull/30577

Backports onto Envoy v1.27 and v1.28 are merged for all of these issues ((2) thanks to @Smeb :tada:)
The relationship between Istio and the Datadog tracing library is the following:

Istio has a version of Envoy that it calls istio-proxy. istio-proxy is based on a release of Envoy. The correspondence between Istio releases and the Envoy releases on which istio-proxy is based are tabulated here.
Envoy builds dd-trace-cpp from source and combines the library with other Datadog-specific code within Envoy (this is where I put the bugs).
The version of dd-trace-cpp on which Envoy depends is determined by envoy/bazel/repository_locations.bzl within the Envoy source tree.
In summary:

A release of Istio tracks a particular release of Envoy.
A release of Envoy contains both Datadog-specific code and a particular version of dd-trace-cpp, determined by the build.
dd-trace-cpp contains the core Datadog tracing code, and is released as a source tarball on GitHub.

Hi David,
Thank you for the detailed updates and explanations. To be honest, I don't personally use DataDog, but our developers heavily rely on it. In early October, we initiated Istio upgrades, but had to revert in most of the clusters due to the "issue" with tracing.
Starting from Istio v1.18, we observed significant visual differences in Datadog tracing. Some of the main issues include, but are not limited to:

the function changing from envoy.proxy to <service-name>_<url for cluster>.
the istio.operation tag seems to be dropped or turned off.
runtime-id and process_id are missing from traces.

More details are available in the linked issue. When we approached support, we were informed that this is related to the DataDog tracing library that Envoy uses and that DataDog doesn't support Istio versions beyond v1.17, according to their documentation.
I plan to open a new support case with additional details that I cannot share here. I will mention this issue and then discuss it with our account manager.
Our primary concern is understanding when we can expect the same tracing functionality we had in previous versions. If not, could this be documented?

@njegosrailic please share the support case number with me once it is created, so I can inquire about it internally.
Your first bullet point is the "operation name" issue discussed previously. The other two changes of behavior that you mention are news to me. istio.operation I haven't heard of before. The runtime-id and process_id tags are added by the underlying tracing library, so it is a surprise that they are missing.

Hi @dgoffredo,
I have created a new support case https://help.datadoghq.com/hc/en-us/requests/1453323 and I'm providing the old one https://help.datadoghq.com/hc/en-us/requests/1339031 for reference.
Thank you for the help.

This will be resolved when https://github.com/envoyproxy/envoy/pull/31526 is merged.

envoyproxy/envoy now uses dd-trace-cpp v0.1.12.

Note - this is only true for the latest release (1.29) which isn't currently available in Istio. Should we backport the changes again? The changes look non-trivial, but I guess they're all in the same place.

I recommend that we do not backport a newer version of dd-trace-cpp onto Envoy release branches v1.27 and v1.28.
There have been several Datadog tracing problems in Envoy since v1.27, but all of them are due to changes made in Envoy's Datadog extension, not in the separate dd-trace-cpp library.

As a customer of Datadog this warning sent me down the path to finding this issue:

For me this indicates I should do something about it but after reading this thread I think I'm hearing this is an envoy/DD relationship. If it's true that as a customer I don't have the ability to fix it the warning may be a bit much.

Thanks for the details @dgoffredo ! I created an internal support ticket: 1565944 if that helps.


feat: add uptime kuma integration

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow use of ts-node-dev in pnp yarn berry

With yarn 2 (aka berry) pnp is now default.
This change allows ts-node-dev to work in yarn 2, and is backwards compatible with npm and yarn 1

+1 need this merged.

@whitecolor

As a workaround you can use yarn unplug ts-node-dev source-map-support and make sure to pass it a relative path yarn ts-node-dev ./src/index.ts

The child-require-hook changes has been fixed in Yarn.
The resolve-main changes is a bug in the yarn patch (https://github.com/yarnpkg/berry/issues/897) and will be fixed upstream


rsf/change is updating two different models

I have two very similar reducers that are made up of nested reducers, like so:
// login.js
export default combineReducers({
    model: createModelReducer('auth.login.model', {
        email: '',
        password: ''
    }),
    form: createFormReducer('auth.login.model')
});

// registration.js
export default combineReducers({
    model: createModelReducer('auth.registration.model', {
        email: '',
        password: ''
    }),
    form: createFormReducer('auth.registration.model')
});

So the final state tree looks like:
    auth:
        login: {
            form,
            model
        },
        registration: {
            form,
            model
        }
    }

I have ensured that the model props on the <Field/> components are correctly set to auth.registration.model.email and auth.login.model.email respectively. However, when I start entering text into one of the inputs, the email field on both of these model reducers are responding to rsf/change actions, and they are both being updated with the same text, even though the payload of the change action only references one of the models. Any ideas?
Thanks for your work on this awesome package!

Hey @joshgeller, thanks for the issue report! Are you on the latest version? I believe this was fixed in 0.3.4 with the latest version being 0.3.6. Check here for a demo; I wasn't able to recreate the issue:
http://esnextb.in/?gist=66b01dd977a6f601259b

Updating did the trick. Thanks!


Synchronization of shared Modules

Shared or External Modules might be an extremely powerful way for organizations to share user-defined Lambdas in their Excel sheets/applications.
Currently, Modules can only be manually imported from GitHub, which poses two concerns:

In larger organisations, there might be procedural hurdles against putting company code on GitHub
It requires manual resync every time there may or may not be an update

Hence, I'd love to see if it were possible to
a) Save modules into an external file (could be a .txt for all that matters)
b) Import modules from an external file (filesystem or HTTP)
c) Link to an external module, or at least a regular synchronization with it (at least import)
Then organisations could publish standard modules containing vetted lambdas for their users to integrate and then use in their tools, while retaining a single source of code which can be maintained.

Just realized that there's a very significant other benefit to external, file-stored modules: You could use other code editors (e.g. VS Code) to edit those.

One more benefit this would have: If Modules can be stored in external files, it'd be trivial to edit them using powerful code editors such as VSCode, trace them in version control systems etc.

Import modules from an external file (filesystem

I'm looking into adding file upload

I was also looking for a more robust solution for this. I wondered if in some future enhancement there may be the possibility to save these modules into a personal workbook that could be applied to any other sheet (something similar to VBA).
I also really like the original suggestion of importing a file or synchronisation too!


Pinned object has no createdAt

I have noticed that when I pin a newly created object, its createdAt value is null. I must save the object and then fetch it from the server again in order to see the createdAt value populated.

This is intended and by design.
createdAt designates a date when the object was created on the server.
If you need a client-side createdAt - I would suggest creating your own custom column.


[8.x] Added test for unsetting relations on model refresh

The Docs say that when calling $model->refresh() the models relationships will also be refreshed:

In addition, all of its loaded relationships will be refreshed as well

I expected this to un-set a relation which no longer exists in the database.
However I noticed that if the relation is already loaded - it does not get unset.
I've tested this on branch 8.x and 9.x
Example
I've added a failing test to demonstrate the problem.
Adding $child->unsetRelation('parent'); right after $child->refresh(); gives the result I expected.
Fix
I'm not sure the best way or place to fix - happy to submit a PR to make the test pass with a bit of guidance if this is desired behaviour.
 Please submit this PR from your personal account. Thanks

@driesvints Ah sorry about that, I can do that.
A quick question if I may first:
Is there a way to do it from the organisation account at all (I'm trying to organise things better and do them as the Org) or is the only way to re-fork with the personal account and start a PR from there?

Done, I've transferred the Fork and PR to my personal account and ticked the box to give you access!
Can this PR be re-opened or shall I create a new one?

Cool, thanks 👍

I'm not sure if we will be taking any action on this issue to be honest.
If someone wanted to take a stab at a PR I could review it but if it was a complex change it likely would not be merged.

Thanks @taylorotwell .
I've worked around this by overriding the refresh() method on my models so will probably not look into this further at the moment.
    public function refresh()
    {
        $this->unsetRelations();
        return parent::refresh();
    }


Add remaining preview/sov cloud sub configs to common dir

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


Appstudio update test-component-pac-crys

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-crys-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
22 seconds
inspect-image

✅ Succeeded
30 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clair-scan

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
13 seconds
label-check

✅ Succeeded
13 seconds
optional-label-check

✅ Succeeded
10 seconds
show-summary

Pipelines as Code CI/test-component-pac-crys-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
34 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
inspect-image

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
17 seconds
optional-label-check

✅ Succeeded
16 seconds
label-check

✅ Succeeded
8 seconds
show-summary


Cannot change RASA X port

Rasa version:
1.0.1
Python version:
3.7
Operating system (windows, osx, ...):
Ubuntu
Issue:
Starting Rasa X in local mode... 🚀
[2019-05-27 17:09:47 +0900] [16856] [ERROR] Unable to start server
Traceback (most recent call last):
File "uvloop/loop.pyx", line 1112, in uvloop.loop.Loop._create_server
File "uvloop/handles/streamserver.pyx", line 58, in uvloop.loop.UVStreamServer.listen
File "uvloop/handles/streamserver.pyx", line 95, in uvloop.loop.UVStreamServer._fatal_error
OSError: [Errno 98] Address already in use
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/sanic/server.py", line 745, in serve
http_server = loop.run_until_complete(server_coroutine)
File "uvloop/loop.pyx", line 1451, in uvloop.loop.Loop.run_until_complete
File "uvloop/loop.pyx", line 1684, in create_server
File "uvloop/loop.pyx", line 1116, in uvloop.loop.Loop._create_server
OSError: [Errno 98] error while attempting to bind on address ('<IP_ADDRESS>', 5002): address already in use
Is there any way to configure the RASA X port number?
The following
rasa x --port PORT
does not work
Content of configuration file (config.yml):

Content of domain file (domain.yml) (if used & relevant):

The thing is that we actually need two ports, one to run rasa-x (e.g. delivering the UI) and another one to run a normal rasa server. --port only changes the port of the rasa server, there is no argument to change the rasa-x port.
I think we should add a new argument to specify the rasa-x port and throw an error explaining the two ports thingy if binding to the address fails.

Same error in MacOS Sierra.
Rasa X not work.
2019-05-28 16:10:11 INFO     root  - Starting Rasa Core server on http://localhost:5005
[2019-05-28 16:10:12 +0200] [32965] [ERROR] Unable to start server
Traceback (most recent call last):
File "uvloop/loop.pyx", line 1112, in uvloop.loop.Loop._create_server
File "uvloop/handles/streamserver.pyx", line 58, in uvloop.loop.UVStreamServer.listen
File "uvloop/handles/streamserver.pyx", line 95, in uvloop.loop.UVStreamServer._fatal_error
OSError: [Errno 48] Address already in use
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/sanic/server.py", line 745, in serve
http_server = loop.run_until_complete(server_coroutine)
File "uvloop/loop.pyx", line 1451, in uvloop.loop.Loop.run_until_complete
File "uvloop/loop.pyx", line 1684, in create_server
File "uvloop/loop.pyx", line 1116, in uvloop.loop.Loop._create_server
OSError: [Errno 48] error while attempting to bind on address ('<IP_ADDRESS>', 5002): address already in use

Feature will be included in the next minor release.

i give
rasa x --debug --enable-api --cors "*" --port 5007 --rasa-x-port 5008
and  get
Starting Rasa Core server on http://localhost:5007
Error: Cannot connect to host localhost:5008 ssl:None [Connect call failed ('<IP_ADDRESS>', 5008)]
(http://localhost:5008/api/health is not responding)
The server is running at http://localhost:5002/login?
can you please share what i am breaking while changing the port from 5002?

Rasa version:
1.1.4
Python version:
3.7
Operating system (windows, osx, ...):
Windows

rasa-x : 0.19.0

I guess, you need to use at least rasa-x version 0.19.1. Can you use that version and try again?

indeed you are right
but now i am getting the below output on http://localhost:5008/api/version
after i installed from https://pypi.rasa.com/simple/rasa-x/
{
"rasa": {
"production": "1.1.4",
"worker": "1.1.4"
},
"rasa-x": "UNDEFINED - this package is not installed"
}


Endorsed community update

Make sure tobe is on there https://www.tiktok.com/t/ZTRqAKqEF/
make sure Hispanic community is the one recommended by ROBE

Also mention it early in the course, during community resources not job search prep

Techqueria L (according to two different hispanics in tech i know)

why pick one? i should recommend both. as a candidate, more options = W

arguably a "rule of N" applies where significantly participating in more than N (n=3?) communities is unrealistic and/or just becomes a distraction/noise/inhibits job search progress


New colours on map?

e.g. Red or orange line for flood protection infrastructure? To contrast the flood maps. Lighten pipelines. Make pipeline colour the dike colour.

Duplicate of #2.


Apply appropriate display width for radio and checkbox detail answers

What is the context of this PR?
This PR has been raised to apply the appropriate display width for number input fields on radio and checkbox detail answers.
How to review
Use the test_checkbox_numeric_detail_answers and test_radio_numeric_detail_answers schemas to check the width of the input fields on the detail answer options.

 [F] Update number field to set appropriate width on Text Fields within Radio options - Number of Vehicles (S)