UB in libregexp

I never upstreamed this because upstreaming to a dead project seemed pointless, but maybe qjs-ng wants to adopt the patch: https://codeberg.org/kiesel-js/kiesel/src/branch/main/patches/libregexp.patch

We certainly take patches here. Would you mind sending a PR?


seterr(...='ignore') does not seem to suppress exception raising

The super-common trick to avoid numerical overflow in softmax is to subtract maximal value from vector before actual exponentiation; though, in some cases, it does underflow, but it's okay as soon as we do some numerical regularization like, x + \epsilon before applying anything that requires strictly positive input (e.g. log), right?
Doing
import autograd
import autograd.numpy as anp
anp.seterr(under='ignore')
import numpy as _np
_np.seterr(under='ignore')
from autograd.core import np as ag_np
ag_np.seterr(under='ignore')

before the actual softmax code does not seem to suppress underflow exception raising.
Thank you for your great work :)

Glad you like the project!

Btw, there's also a context manager for the same thing:
with np.errstate(divide='warn'):
    np.arange(3) / 0.

This is behaving as expected for me:
from __future__ import division
import autograd.numpy as np
from autograd import grad

def logsumexp(a):
   cmax = np.max(a)
   return np.log(np.sum(np.exp(a - cmax))) + cmax

a = np.array([-4000., -3900., -10., 0., -np.inf, -np.inf])

with np.errstate(under='ignore'):
   print grad(logsumexp)(a)

with np.errstate(under='raise'):
   print grad(logsumexp)(a)

@mattjj yes, you're right, I also wrote few code snippets and it seems to work as expected; I have been struggling with this issue for a few days, but I can't isolate and reproduce it as a "minimal failing example" too, for some reason; sorry for (most likely) false alarming :(
I'll update this issue if I succeed in isolating it, but yes - that is basically the same code you posted above, so everything must be okay on autograd side; but thank you very much for such a prompt reply!
off topic: I remember seeing a video with Linus Torvalds giving a talk somewhere, saying that the most exiting part is not the transition from one thousand of active users to a million, but rather first few hundreds that start using and giving their feedback on your work, as you see many people getting excited about your work and starting talking to their co-workers about it, etc :) I hope that autograd is going to get a significant attention, because it really rocks - especially when it comes to fast prototyping and (!) user-friendly debugging a model, I don't know any other library that could do better than autograd
fyi, here's another interesting project from Berkley, that attempts to be a "theano done right" with fast compilation, out-of-box palatalization, but no automatic broadcasting (for some reason - that's a feature, not a bug), but it seems to be somewhat abandoned for ~four month already

Thanks for the kind words about autograd!
We keep our eyes on projects that might serve as "backends" for autograd. It's too bad that CGT might be losing steam, but TF is gaining a lot of traction.
I'm going to close this issue for now; reopen it if there is a problem with autograd along these lines.


feat(V2 Clients): OSV.dev client

Implementation of the OSV.dev client, which we'll want to move to osv.dev repository at some point.
Part of step 3 of the osv-scanner V2 refactor.
Thanks to VishalGawade1 for the makeRetryRequests testing code in #1390

Codecov Report
Attention: Patch coverage is 73.43750% with 51 lines in your changes missing coverage. Please review.

Project coverage is 67.19%. Comparing base (0b07b76) to head (40e2f8b).
Report is 7 commits behind head on main.

Files with missing lines
Patch %
Lines

internal/osvdev/osvdev.go
71.97%
34 Missing and 17 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
- Coverage   67.34%   67.19%   -0.16%
==========================================
  Files         193      194       +1
  Lines       18254    18353      +99
==========================================
+ Hits        12294    12333      +39
- Misses       5303     5347      +44
- Partials      657      673      +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Agenda in CW20 study - clarify point on time keeper

Describe the change being requested
enable no additional time keeper being needed - this needs rewritten but I'm not sure what the meaning is
State the reason for the change
clarifying
Describe the impact of the change on other parts of the SSI-EOG
none
Describe any alternatives you have considered (if applicable)
N/A
Additional context
N/A

line updated - removed section on time keeper not being needed and added the fact that we told the speaker the length of the talk.


Localized Info.plist files are wiped

Hey, I have just localized my Info.plist file, which requires creating a strings file called "InfoPlist.strings", clicking the localize button in Xcode, then filling it with strings in the corresponding languages in the following format:
NSCalendarsUsageDescription = "This allows us to save the appointments you make.";
Localization works correctly. Note that the key does not have quotes marks around it. If you run the BartyCrouch script as part of your build phases, these files are wiped.
This breaks the localization. I can have a look at this in depth when I have time, but in the meantime I have had to remove BartyCrouch from my project, if anyone is around to have a look I'd really appreciate it!

Just had a quick look at the repo and it looks like at some point perhaps an attempt was made to handle this situation, see here: https://github.com/Flinesoft/BartyCrouch/blob/b651fb970616a9739834cd2e7837e446b4786437/Sources/BartyCrouchKit/FileHandling/StringsFilesSearch.swift#L14
Although we declare a reference to the file as we should be avoiding it ("blacklistedStringFileNames"), it doesn't seem to actually be used anywhere

Thanks for reporting this, it sure looks like something went wrong. I hope we can easily reproduce and fix it. Will have a look soonish – but feel free to drop a PR if you get the chance to fix it yourself. We probably had the same problem somewhere and started to fix it, as you can see in the code above. But why didn't finish it, I don't know. Maybe we found a workaround?
Maybe @fredpi can give more insight here?

In a project of ours where we use BartyCrouch in conjunction with Info.plist Localizations, everything works fine – but I guess that's just because the InfoPlist.strings files are in a different folder ("App/SupportingFiles") than the Localizable.strings files ("App/Resources"): A folder that's not parsed by BartyCrouch, as can be seen in the configuration.
Configuration
Here's our .bartycrouch.toml:
[update]
tasks = ["interfaces", "transform", "normalize"]

[update.interfaces]
path = "App/Sources"

[update.transform]
codePath = "App/Sources"
localizablePath = "App/Resources"
transformer = "swiftgenStructured"
supportedLanguageEnumPath = "App/SupportingFiles"

[update.normalize]
path = "App"
sourceLocale = "de"

[lint]
path = "App"

Workaround
Of course this issue should be fixed soon, but in the meantime you can probably work around it by moving the localizations into a folder that's not configured to be parsed by BartyCrouch.

Hi. Looks like the problem persists.
Of note: I have installed barty crouch for the first time a week ago, after the fix was merged, but bartycrouch reports it's version as 4.0.0 even though the latest (and the one brew claims to have installed) is 4.0.2
Before bartycrouch update:

After:

This happens with default bartycrouch.toml generated by bartycrouch init
Version discrepancy:

Hi. Looks like the problem persists.
Of note: I have installed barty crouch for the first time a week ago, after the fix was merged, but bartycrouch reports it's version as 4.0.0 even though the latest (and the one brew claims to have installed) is 4.0.2

Any workarounds? I tried brew and mint, version also shows 4.0.0 although installing 4.0.2
Gotta copy paste infoplists for all localizations every update command..

I am also having this issue.
I think this occurs when adding new Localized files (as described in the first post).
bartycrouch was working great, but now I've added two more Localizable-blah.strings files, and they are wiped out when I run bartycrouch.
I really need a way to ignore these files, but I doubt bartycrouch should be wiping files like this...

I am also having this issue.
I think this occurs when adding new Localized files (as described in the first post).
bartycrouch was working great, but now I've added two more Localizable-blah.strings files, and they are wiped out when I run bartycrouch.
I really need a way to ignore these files, but I doubt bartycrouch should be wiping files like this...

Revisiting this topic again in my Friday Open Source live stream, I think things have gone quite wrong here while trying to fix the original posters request. What they had said is this:

NSCalendarsUsageDescription = "This allows us to save the appointments you make.";
Localization works correctly. Note that the key does not have quotes marks around it. If you run the BartyCrouch script as part of your build phases, these files are wiped.

So the actual issue, I'm guessing now, was that the key didn't have "quote marks around it", which probably caused BartyCrouch's regexes to not recognize them as keys. That's probably why these keys were wiped. The actual fix probably would have been to just add quote marks around the key like this:
"NSCalendarsUsageDescription" = "This allows us to save the appointments you make.";
Then nothing should have been wiped. But because I missed that part back then and misunderstood some things, I actually excluded the Info.plist file from translated Strings files in https://github.com/Flinesoft/BartyCrouch/pull/138. But that was totally unnecessary and is now causing multiple other people to report that InfoPlist.strings files are not being updated by BartyCrouch (as in English language keys being added to other languages automatically, for example).
So, I think the best way to deal with this is to make the now "fixed" ignoring of the InfoPlist.strings file a configuration option so that everyone who doesn't want these files to be "updated" by BartyCrouch to exclude them, and those who want to just keep that option empty so every Strings file gets updated. I'll be keeping you updated.


pem or p12/cer?

Hello! Wanna use it in backend, Perfect server on swift f.ex. Than I have plans to set up it on linux, so need I a pem format of leave it p12?

The Library supports "p12" certificates. Maybe, I will be do support of pem/cer.
But I think use "p12" it easy.

Yep, but I saw a lot of tutorials where on Linux it usually uses pem-format... Just for the future :)


Two minor fixes

Use kubernetes API instead of openshift in the ClusterRoleBinding (for minikube support)
Create role dedicated-admins-openshift-logging before trying to apply it

order of role and rolebinding creation shouldn't matter, were you seeing errors @dak1n1 ?
/lgtm
/approve


Azure Africa

When will South Africa data centers be available to test latency etc?

I've created a PR. #71

South Africa North is added.  South Africa West does not show up in region list in azure portal, I can not add it, latency test requires a storage account created in the target region.

I am closing this now, if anyone knows how to access to South Africa West region, please feel free to re-open

Thanks

Thank you.
As it turns out, the South African West region is setup as a backup for the North.
You need to request special access to use South Africa West.
Explained here... https://azure.microsoft.com/en-us/global-infrastructure/geographies/
"South Africa North: All
South Africa West: Reserved for South Africa North customers requiring in-country disaster recovery"
Thanks again!

@unlaudable Thanks for your research! It seems there is nothing I can do now as South Africa West: is reserved for limited Azure customers.
I will add South Africa West when it's public to all Azure customers.

Seems the spelling of South Africa is incorrect, please fix


Test classes are being skipped

TestNG Version
7.6.1
Description
Not all of the test case classes are executed when the classes aren't ordered by alphabetical order, one class extends another class and the base class contains a test method which other tests in this class and the extended class depend on.
Expected behavior
All the test case classes should be executed.
Actual behavior
Only the first test case class is executed.
Is the issue reproducible on runner?

[X] Shell
[ ] Maven
[ ] Gradle
[ ] Ant
[X] Eclipse
[ ] IntelliJ
[ ] NetBeans

Test case sample
<suite name="Suite"  >
  <test name="testCases" >
    <classes>
      <class name="tests.testCases.TestCaseB"/>
      <class name="tests.testCases.TestCaseA"/>
    </classes>
  </test>
</suite>

public class TestCaseA
{
    @Test
    public void testA1()
    {
        System.out.println("testA1");
    }

    @Test(dependsOnMethods = "testA1")
    public void testA2()
    {
        System.out.println("testA2");
    }
}

public class TestCaseB extends TestCaseA
{
    @Test(dependsOnMethods = "testA1")
    public void testB1()
    {
        System.out.println("testB1");
    }
}

I am not able to reproduce the problem. Please check github_2784.zip for a sample.
I have run this on the command line and from within IntelliJ. If this is a problem that is specific to running tests in eclipse, then please file the issue under https://github.com/cbeust/testng-eclipse
If this problem persists on the maven command line as well, please feel free to alter the attached project to be able to reproduce the problem and comment back.

I'm running TestNG programmatically as Java application and not via TestNg plugin.
package tests.testCases;

import java.util.ArrayList;

import org.testng.TestNG;
import org.testng.xml.XmlClass;
import org.testng.xml.XmlSuite;
import org.testng.xml.XmlTest;

public class test
{

    public static void main(String[] args) throws ClassNotFoundException
    {
        XmlSuite suite;
        XmlTest test;
        TestNG testNG;
        XmlClass xmlClass;
        ArrayList<XmlClass> testClasses;
        ArrayList<XmlSuite> testSuites;
        ArrayList<XmlTest> tests;

        testNG = new TestNG();
        testNG.setVerbose(10);

        testSuites = new ArrayList<XmlSuite>();
        suite = new XmlSuite();
        suite.setName("Suite");

        test = new XmlTest();
        test.setName("testCases");
        test.setSuite(suite);
        test.setGroupByInstances(true);

        testClasses = new ArrayList<XmlClass>();
        xmlClass = new XmlClass(Class.forName("tests.testCases.TestCaseB"));
        testClasses.add(xmlClass);
        xmlClass = new XmlClass(Class.forName("tests.testCases.TestCaseA"));
        testClasses.add(xmlClass);
        test.setClasses(testClasses);

        tests = new ArrayList<XmlTest>();
        tests.add(test);

        suite.setTests(tests);
       suite.setGroupByInstances(true);

        testSuites.add(suite);

        testNG.setXmlSuites(testSuites);

        testNG.run();
    }
}

@valeriM1

I'm running TestNG programmatically as Java application and not via TestNg plugin.

You didn't mention this earlier, which is what caused the confusion. Thanks for clarifying this part now.
I am able to reproduce the problem with the below attached sample
  public void anotherTest() {
    TestNG testng = new TestNG();
    XmlSuite xmlsuite = new XmlSuite();
    xmlsuite.setName("my_suite");
//    xmlsuite.setGroupByInstances(true); <-- Enabling this gives another assertion failure
    XmlTest xmlTest = new XmlTest(xmlsuite);
    xmlTest.setName("my_test");
    xmlTest.setXmlClasses(Arrays.asList(
        new XmlClass(TestCaseB.class),
        new XmlClass(TestCaseA.class)
    ));
    System.err.println(xmlsuite.toXml());
    testng.setXmlSuites(Collections.singletonList(xmlsuite));
    MethodLogger listener = new MethodLogger();
    testng.addListener(listener);
    testng.run();
    List<String> expected = Arrays.asList(
        "com.rationaleemotions.TestCaseB.testA1",
        "com.rationaleemotions.TestCaseB.testA2",
        "com.rationaleemotions.TestCaseB.testB1",
        "com.rationaleemotions.TestCaseA.testA1",
        "com.rationaleemotions.TestCaseA.testA2"
    );
    assertEquals(listener.getLogs(), expected);
  }

There are two issues that I am noticing:

When xmlsuite.setGroupByInstances(true); is enabled, the number of methods executed itself is incorrect.
When the group by instances is not enabled, then the order of the method execution changes and the assertion fails.

@valeriM1 - I spent some more time on this issue and it looks like TestNG is working as designed here.

When xmlsuite.setGroupByInstances(true); is enabled, the number of methods executed itself is incorrect.

The root cause of this problem is because by default preserve-order is always true and group-by-instances and preserve-order don't go well with each other especially when there's no factories involved (I believe group-by-instances is relevant ONLY when used along with @Factory produced test classes, because that's where there would be multiple test class instances of the same class). Flipping preserve-order to false would fix this.

When the group by instances is not enabled, then the order of the method execution changes and the assertion fails.

This is because the listener that I was using internally makes use of org.testng.ITestNGMethod#getQualifiedName which returns getRealClass().getName() + "." + getMethodName(). The sad part here is that, getRealClass().getName() is not the same as getInstance().getClass().getName() because getRealClass() refers to the parent class (when there's inheritance involved), but getInstance() always resorts to the current object's class.
Long story short, if you flip getQualifiedName() with
testResult.getInstance().getClass().getCanonicalName() + "." + method.getTestMethod().getMethodName()

this failure would also go away.


Add docker support

Based on this guide, and https://github.com/shakeelmohamed/raspberry-pi-2/issues/1

The coding is all done for now!
TODO:

[ ] rename the repo, readme, etc.
[ ] Register the repo on dockerhub
[ ] Set a real number in package.json
[ ] Add screenshots
[ ] Add setup steps
[ ] Rename shell scripts
[ ] Tag a release

Run docker rmi $(docker images -q -f dangling=true) if running out of disk space

After downloading the "Hypriot Docker Image for Raspberry Pi" img.zip and extracting from http://blog.hypriot.com/downloads/:
diskutil unmountdisk /dev/disk2
sudo dd if=hypriotos-rpi-v1.0.0.img of=/dev/rdisk2 bs=1m


Login credentials not working under Linux

Current implementation of cryto_file_handler.py does not work under Linux.
Steps to reproduce:

Install pyJiraCli using pip install .
Run pyJiraCli login --server hello  so that it tries to use the encrypted file.

Traceback:
Traceback (most recent call last):
  File "/home/greyes/miniconda3/envs/py38/bin/pyJiraCli", line 8, in <module>
    sys.exit(main())
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/__main__.py", line 161, in main
    ret_status = args.func(args)
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/cmd_login.py", line 157, in execute
    return _cmd_login(args)
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/cmd_login.py", line 173, in _cmd_login
    ret_status = _store_login_info(args)
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/cmd_login.py", line 206, in _store_login_info
    ret_status = _store_information(data1, data2, args, expiration_date)
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/cmd_login.py", line 224, in _store_information
    crypto_h = Crypto()
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/crypto_file_handler.py", line 101, in __init__
    self._root_key = _get_device_root_key()
  File "/home/greyes/miniconda3/envs/py38/lib/python3.8/site-packages/pyJiraCli/crypto_file_handler.py", line 543, in _get_device_root_key
    _uuid = sub.check_output(UUID_CMD_UNIX).replace('"', '\n').split()[-1]
TypeError: a bytes-like object is required, not 'str'

Possible change of handling passwords using Keyring:
https://github.com/jaraco/keyring
Simple file encryption:
https://github.com/frispete/keyrings.cryptfile


FIX rmi.server.hostname is set up properly - enables remote JMX conne…

…ction

LGTM. Travis build ran without problems and the change is small.


fix typo in class name

Note
This repository is for Vue 1.x and 2.x only. Issues and pull requests related to 3.x are managed in the v3 doc repo: https://github.com/vuejs/docs-next.

Hi @aletar89! If I'm not mistaken, the new class name only applies to Vue 3. Vue 2 still uses the normal .enter and not .enter-from class. If I'm mistaken, feel free to open another issue with a repo that shows an example of this.
Thanks for the PR!
If I'


Add NANDO cross references

Instead of making them exact, as discussed, just add them as xrefs for this version.

Mistake in QC, fixed in https://github.com/monarch-initiative/mondo/pull/7761


improvement: init logger before other module start

Pull Request Test Coverage Report for Build 1152

12 of 12 (100.0%)  changed or added relevant lines in 4 files are covered.
16 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.1%) to 63.258%

Files with Coverage Reduction
New Missed Lines
%

core/config/config.go
1
68.84%

chassis.go
1
50.29%

core/config/sr_config.go
2
0.0%

core/loadbalancer/randam.go
2
64.29%

core/registry/servicecenter/cache.go
2
43.73%

core/handler/transport_handler.go
3
21.95%

core/router/cse/translate.go
5
33.8%

Totals

Change from base Build 1150:
0.1%

Covered Lines:
5010

Relevant Lines:
7920

💛  - Coveralls


[PMR-01C] Deprecated Concatenation Syntax

PMR-01C: Deprecated Concatenation Syntax

Type
Severity
Location

Code Style

PearlMigrator.sol:L238, L261

Description:
The referenced statements make use of the abi.encodePacked function to concatenate bytes / string payloads which has been deprecated.
Example:
bytes memory toAddress = abi.encodePacked(to);

Recommendation:
We advise the functionally equivalent bytes.concat method to be used, optimizing the legibility of the codebase.

These are not string concatenations. These are in fact just byte encoded addresses.


Added auth token management to view and remove github auth tokens

General question is what is the intended visibility of this feature? The reason I ask is because it is not currently navigable via the site. However, it is accessible to get to what you tested in cucumber via url hacking. If you just wanted to get this chunk in before exposing this to a user.
It is approved pending the small textual changes.
If that was not the intent add navigation to make it visible to normal users.

The intent was to add functionality in small iterations and progress to a point where account management can be exposed.

:+1:


Issue

Error while creating build definition: The classic pipelines are disabled for this project / organization. Error while creating release definition: The classic pipelines are disabled for this project / organization.

@Tiagoalaz Looks like the creation of classic build and pipeline has been disabled in your organization.
Please follow the link for more information on enabling/disabling classic pipelines.


 It does not handle diffs of files which have lines which
are too long.
Fix #17738
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #17739 (b4affc2) into main (a85e75b) will increase coverage by 0.07%.
The diff coverage is 58.34%.

@@            Coverage Diff             @@
##             main   #17739      +/-   ##
==========================================
+ Coverage   45.44%   45.52%   +0.07%
==========================================
  Files         802      807       +5
  Lines       89233    89873     +640
==========================================
+ Hits        40556    40915     +359
- Misses      42140    42411     +271
- Partials     6537     6547      +10

Impacted Files
Coverage Δ

cmd/migrate_storage.go
0.00% <0.00%> (ø)

cmd/web_graceful.go
0.00% <ø> (ø)

cmd/web_https.go
0.00% <0.00%> (ø)

cmd/web_letsencrypt.go
0.00% <0.00%> (ø)

models/error.go
38.76% <0.00%> (-0.06%)
:arrow_down:

models/issue_list.go
71.80% <0.00%> (ø)

models/issue_lock.go
0.00% <0.00%> (ø)

models/statistic.go
0.00% <0.00%> (ø)

models/user.go
56.63% <ø> (-0.06%)
:arrow_down:

modules/doctor/dbconsistency.go
6.83% <0.00%> (ø)

... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fa41b6...b4affc2. Read the comment docs.


Error introspect

Hi Prisma Team! The following command just crashed.
Command
introspect --schema=[redacted]
Versions

Name
Version

Platform
darwin

Node
v18.15.0

Prisma CLI
4.9.0

Engine
ceb5c99003b99c9ee2c1d2e618e359c14aef2ea5

Error
Error: Error in migration engine.
Reason: [libs/sql-schema-describer/src/mssql.rs:341:30] called `Result::unwrap()` on an `Err` value: "Couldn't parse default value: ` -- correzione default per AnagraficoLineetrattamento in offerte\r\nCREATE DEFAULT visualizzainoffertedflt AS 1\r\n`"

Please create an issue with your `schema.prisma` at
https://github.com/prisma/prisma/issues/new

Hey @robolmatteo98, can you please share the Prisma schema, the SQL Server version you're using, and the necessary steps to reproduce this crash? Thank you!

Hey @robolmatteo98, would you please have any updates on this? Thanks.

Hey @robolmatteo98, closing this issue due to inactivity. Feel free to leave a comment asking to re-open the issue in case you have more info available. Thanks!


⚠ Bofrost.at has degraded performance

In 9793c87, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1050 ms

Resolved: Bofrost.at performance has improved in a933191 after 8 minutes.


Use full width of page

Until we start work on #17 there is no point wasting half the horizontal width of the page with an empty panel. We should use the full width — especially since we so often show "all columns" and there are always so darned many of them that we spend our lives side-scrolling.

I want to revise this one. Half the width is plenty for the query form — where we lose out on width is just with the results. But the fact that the results table appears only below the half-screen with the query form is just a straight-up bug, as there is no way we'd want it to work that way when we have joins across multiple query forms.
So I plan to leave the query-form pane as it is (and it's useful for now to have the right-hand pane for debug info), but to spread the results table across the whole width of the bottom part of the page.


add explicit order by for latest account

closes: https://github.com/spacemeshos/go-spacemesh/issues/4825
it was overlooked in initial development. the order is not guaranteed by sqlite despite primary key ordered by in the order that is expected by vm . so sqlite free to choose any order it "likes" for optimal reasons. generally the optimal should be iterating over (account, layer_update) tree, but on different environment it may not be true

bors merge

@kacpersaw

bors merge


WinTADS: Add version 1.3.4

WinTADS is the standard way for playing TADS text adventure games on Windows.

I think this should be in the Games bucket.

It's a 20 year old release. I have doubts regarding this.

Please shift this PR to Games bucket.

Please shift this PR to Games bucket.


Allow button to work after lightbox is closed

Users were unable to open the lightbox a second time after closing the
initial lightbox. This happened because showLightbox was not being set to
false.

Set state to change showLightbox to false when the user closes the lightbox

Fixes Issue #1584.


OpenAI API returned an API Error with clean installation

I receive this error with a clean installation:
Error: Cannot process your request due to Exception: OpenAI API returned an API Error: Error code: 404 - {'error': {'message': 'Invalid URL (POST /chat/completions)', 'type': 'invalid_request_error', 'param': None, 'code': None}}
This is my taskweaver_config.json:
{
"llm.api_base": "https://api.openai.com/",
"llm.api_key": "[MY_KEY]",
"llm.model": "gpt-4-1106-preview"
}
My python version is 3.11.3, and openai 1.3.7.
Any ideas?
Thanks!

It worked when I added /v1/ to the api_base. I think the example file should contain the working url by default.


TypeError: undefined is not an object (evaluating '_reactNative.Image.propTypes.source')

I've updated my app to expo SDK 46, which also includes react native version 0.69.3
Only importing the slider:
import Slider from "react-native-smooth-slider";
throws the error:
TypeError: undefined is not an object (evaluating '_reactNative.Image.propTypes.source') at node_modules/react-native/Libraries/Core/ExceptionsManager.js:95:4 in reportException at node_modules/react-native/Libraries/Core/ExceptionsManager.js:141:19 in handleException at node_modules/react-native/Libraries/Core/setUpErrorHandling.js:24:6 in handleError at node_modules/expo-dev-launcher/build/DevLauncherErrorManager.js:46:19 in errorHandler at node_modules/expo-dev-launcher/build/DevLauncherErrorManager.js:51:24 in <anonymous> at node_modules/expo-error-recovery/build/ErrorRecovery.fx.js:12:21 in ErrorUtils.setGlobalHandler$argument_0

Maybe adding and using ImagePropTypes will fix it:
import { ViewPropTypes, ImagePropTypes } from 'deprecated-react-native-prop-types'; line 14
trackImage: ImagePropTypes.source, line 174
thumbImage: ImagePropTypes.source, line 184

<EMAIL_ADDRESS>fix it :yum:


AST: simplify AKAFormatString

Remove the unnecessary use of the positional arguments in the diagnostic
formatting.  This is not portable as it is a SUS extension and the Microsoft C
runtime does not support this extension.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test and merge


Add a project license

The repository currently doesn't seem to contain any license. Could you add one, please? See Choose a License for more information :slightly_smiling_face:
For reference, most public Godot add-ons use the MIT license (like Godot itself).

Done !


Fix url with slices

This was just not implemented.

Changelog:

One corner case: How does it work with () as slicing?

(basically there is the same bug in UrlSelectionTable, cause it was a copy paste, i prefer to use the same base code for now)

@t20100  what () should do? i have no idea.

Actually

() -> slice=
(1, ) -> slice=1

I suggest to rework that to have

() -> slice=,
(1, ) -> slice=1,

but i am really not sure, it's maybe better to change that in another PR

what () should do?

From https://numpy.org/doc/stable/user/basics.indexing.html :

An empty (tuple) index is a full scalar index into a zero-dimensional array. x[()] returns a scalar if x is zero-dimensional and a view otherwise. On the other hand, x[...] always returns a view.

Basically it returns everything but it also works with scalars:
In [6]: s = numpy.array(1)
In [7]: s[()]
Out[7]: 1
In [8]: s[...]
Out[8]: array(1)
In [9]: s[:]
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)

In [10]: a = numpy.array([1])
In [11]: a[:]
Out[11]: array([1])
In [12]: a[...]
Out[12]: array([1])
In [13]: a[()]
Out[13]: array([1])

Acutally it should be OK as it is.

Ok, nice, i prefer not to touch this semantic.
It's just that there is an inconsistency because 1 is the same as (1,), which is a bit weird. But with this 2 entries the  result should also be the same so it's fine.


1.19 Request

If you're not too busy, please consider updating to 1.19. Thank you!

Done: https://www.curseforge.com/minecraft/mc-mods/better-ping-display/files/3825525


chore: set longer timeout for releases

Increases timeout for stage.sh from default (180) to 300 mins - we started hitting this timeout limit in recent release jobs.

Can you comment (document URL) where you found timeout_mins: 300 property?

Can you comment (document URL) where you found timeout_mins: 300 property?

@suztomo  The 300 is just an arbitrary value (on the safe side), I've followed up with the internal link in our chat thread. There are a number of other repos that set custom values for this property as well: https://github.com/search?q=org%3Agoogleapis+timeout_mins&type=code

The GraalVM check looks similar to the nightly build ones - logging here and re-triggering to see if they persist:
[INFO] Running com.google.cloud.compute.v1.integration.ITPaginationTest
[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 42.66 s <<< FAILURE! - in com.google.cloud.compute.v1.integration.ITPaginationTest
[ERROR] testPaginationIterating  Time elapsed: 8.558 s  <<< FAILURE!
java.lang.AssertionError: Zone us-central1-a was not found for cloud-java-ci-test in zones list (size: 46).
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at com.google.cloud.compute.v1.integration.ITPaginationTest.testPaginationIterating(ITPaginationTest.java:124)

Thank you for the document.


Register package

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/9684
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 9e8954caa554cccbacc84453f990d09e4a850508
git push origin v0.1.0

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/9684
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" e8334d73ced77e16d27715832451fd52996f4fb2
git push origin v0.1.0


Improve select prompt (with search)

Hi,
I've finally found the time to experiment with the select prompt with auto-complete and here is the feedback.
Ctrl-C keeps the console dirty
When someone ctrl-c's instead of validating the prompt, the options stay displayed and clutter the terminal.

If it is possible, it'd be nice to catch the SIGINT signal and cleanup.
Less-strict search method
The current search method shows a few improvement opportunities IMO:

it currently only matches the values. This has the drawback that when searching in options with names, the values are not displayed and may not share a single character in common with the values (ex: {name: 'Blue', value: '#0000AA'}).
is searches at the beginning of the value and not everywhere (meaning new does not match Add a new feature).

I think it would be better to search on names when provided and to use a case-insensitive-match-anywhere search method.
Something like:
function searchMethod (allOptions, searchText) {
  return allOptions
    .filter(option => !option.disabled)
    .reduce(
      (seed, option) => {
        const lowerCaseName = option.name.toLocaleLowerCase();
        const lowerCaseValue = option.value.toLocaleLowerCase();
        const lowerCaseSearch = searchText.toLocaleLowerCase();

        const matchesPerfectly = lowerCaseName === lowerCaseSearch || lowerCaseValue === lowerCaseSearch;
        if (matchesPerfectly) { // Put perfect match first!
          return [ option, ...seed ];
        }

        const matches = lowerCaseName.includes(lowerCaseSearch) || lowerCaseValue.includes(lowerCaseSearch);
        return matches ? [ ...seed, option ] : seed;
      },
      [],
    );
}

WDYT?

I can help with implementation if you want to take these, and can split issues etc... :-)

thx for the feedback @quilicicf!

normely the output should be cleaned on ctrl+c, if not than this is a bug. But i can not reproduce this on my mac. Which operating system and deno version do you use? And can you show me your code?

I was already working on a fuzzy search implementation, but it was not so easy to get this work together with autosuggestions. So i decided to add a simple solution first. But i would like to add fuzzy search before v1.0.

Clear terminal on SIGINT
I'm using Deno 1.7.0 on Ubuntu 20.
The code is available here (nothing fancy).
I can provide a simpler reproduction code if that helps.
Fuzzy search
As for the fuzzy search it'd be great! If I can be of any help, don't hesitate to ask :-)

thx! With docker it was also working for me, but i can reproduce it on a real debian machine now. Will try to fix it.

@quilicicf the issue with the stdout should be fixed now. i realized, there was realy no logic for clearing the stdout. i think, it was just my zsh and docker which cleared the stdout automatically.

Noice!
I've tested it and it works on commit a6b5d36 thanks :-)


Override nodename for IcebergScanTransformer

What changes were proposed in this pull request?
Override nodename for IcebergScanTransformer to distinguish the nodename of BatchScanExecTransformer
How was this patch tested?

@zhztheplayer  can you help to review? thanks

Thanks. What's the node name before this change?


build: fix yarn errors upon npm install minidump

Only run git submodule update when running out of a git working copy
Don't require yarn for end-user installation (or any installation, since it's not listed as a dep)

Closes #93
This fixes the following 3 errors:
development without yarn installed globally
$ git clone git@github.com:electron/node-minidump.git && cd node-minidump
$ npm install
><EMAIL_ADDRESS>preinstall
> yarn submodule && node build.js

sh: 1: yarn: not found

end-user installing of minidump (or any package depending on it) without yarn installed locally or globally
$ mkdir newproj && cd newproj && echo {} > package.json
$ npm i minidump
npm ERR! command failed
npm ERR! command sh -c yarn submodule && node build.js
npm ERR! sh: 1: yarn: not found

end-user installing of minidump (or any package depending on it) in a non-git-controlled working directory:
$ mkdir newproj && cd newproj && echo {} > package.json
$ npm i yarn
$ npm i minidump
npm ERR! command failed
npm ERR! command sh -c yarn submodule && node build.js
npm ERR! yarn run v1.22.22
npm ERR! $ git submodule update --init --recursive
npm ERR! info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! warning ../../package.json: No license field
npm ERR! fatal: not a git repository (or any of the parent directories): .git

Note: simply reverting 4be7737 will solve the last two end-user problems, presumably a situation like the first one was what that commit was attempting to solve (and it did solve it, as long as you have yarn installed globally, which, as far as I know, is not generally recommended), hopefully my addition to build.js will solve more elegantly solve the development case without needing to add external (non-dev) dependencies.

Updated (and force-pushed) to remove trailing command that was causing a style check failure.


added hvv metrobus and xpressbus routes

The hexagon shape is not yet supported, so the test fails… :(


Fix for Apple MacOS M1

fixes: https://github.com/kiali/kiali/issues/5580

Please create a Kiali issue and associate it with this PR (i.e. put fixes: <link to issue> in the description of this PR). Please do not submit PRs to the Kiali project without an associated issue so we can track issues better. Thanks.
Putting on a DNM label until we get an issue for this PR.

Please create a Kiali issue and associate it with this PR (i.e. put fixes: <link to issue> in the description of this PR). Please do not submit PRs to the Kiali project without an associated issue so we can track issues better. Thanks.
Putting on a DNM label until we get an issue for this PR.

Thank you for the comments. Created an issue and associated it with this PR

Works on my machine. Confirmed it pulls down helm 3.10.1, and the build-helm-charts target still works. Nothing breaks. I don't have an ARM machine to test, but I assume that will work since that's the whole point :)


fix for NUTCH-2580 contributed by r0ann3l

This patch includes changes in:
lib-rabbitmq (new)

Common functionalities like: open a new connection with a RabbitMQ server, open a channel over the connection and binding between an exchange and a queue. All is wrapped into RabbitMQClient.class.
Upgrade of the RabbitMQ's library version from 3.6.5 to 5.2.0.
Support for the arguments supported by RabbitMQ when an exchange, a queue or a binding is created.
Username, password, hostname, port and virtual host, merged into a single property.

indexer-rabbit (modified)

A single or multiple documents into each message.
Optional binding.
Headers from NutchDocument's fields.
Static headers.

publish-rabbitmq (modified)

Optional binding.
Static headers.

+1 lgtm. Thanks, @r0ann3l!

Ok, after merging #218/NUTCH-1480 this PR fails to merge. @r0ann3l, I'm sure you've already used both improvements together? If not, let me know, and I'll try to resolve the conflicts. Thanks!


Feature: os_touch - Ensure that entire folder structure exists

This is done to avoid a crash when taking a ReadLock while reading a folder of objects.
I was experiencing a problem where I got the following error:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\path\\to\\AppDirData\\1.0\\database\\.ddb\\projects\\9c25eb71-8be2-487f-8c18-a96c49416ecd.11232.1692961820740517700.need.read.lock'

when trying to do roughly the following:
DDB.at("projects", project.id).create(
    project.model_dump(),
    force_overwrite=True,
)

res = DDB.at("projects", "*", where=...).read()

It seems that locking writes a lock file using os_touch and in case of folders, at least on Windows in my case, it fails if the parent folder (projects) is not present.
The solution seems to be to just create the folder structure.

Makes sense. I have updated the code now.

Nice! Thanks for your contribution

Thank you!

Hi again! Is it possible to release a new version now that the PR is merged in? 😊

Done!

Much appreciated!


Allow to customize publish.Namer

Fixes #476

Adds ability to pass custom publish.Namer
Adds ability to override default path separator, allowing use with container registries that don't allow nested repositories (Quay, Docker Hub etc.)

Exposing this as an option seems fine, but I'm less excited about another flag for this... want to split this into 2 PRs so we can land the namer change?

Okay. That seems reasonable to me. I would only need the code change, as I'm embedding ko in my build tools, so I think I'll just drop the flag out in this PR.

Codecov Report

Merging #477 (975fbe4) into main (6447264) will decrease coverage by 1.77%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   53.13%   51.36%   -1.78%
==========================================
  Files          36       40       +4
  Lines        1848     2048     +200
==========================================
+ Hits          982     1052      +70
- Misses        715      822     +107
- Partials      151      174      +23

Impacted Files
Coverage Δ

pkg/commands/options/publish.go
48.78% <93.75%> (ø)

pkg/publish/default.go
56.86% <0.00%> (-4.98%)
:arrow_down:

pkg/commands/commands.go
72.72% <0.00%> (-2.28%)
:arrow_down:

pkg/commands/deps.go
15.18% <0.00%> (-2.06%)
:arrow_down:

pkg/build/gobuild.go
56.45% <0.00%> (-1.99%)
:arrow_down:

pkg/commands/config.go
56.14% <0.00%> (-1.39%)
:arrow_down:

pkg/commands/resolver.go
31.57% <0.00%> (-0.94%)
:arrow_down:

pkg/build/strict.go
100.00% <0.00%> (ø)

pkg/commands/apply.go
51.35% <0.00%> (ø)

pkg/commands/build.go
68.75% <0.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6447264...975fbe4. Read the comment docs.

Thanks!


Chinese Yuan has a few problems

Several defects with Chinese Yuan (CNY) in currency-format.json.

The name should be 'Chinese Renminbi', not 'Yuan Renminbi'. Yuan is the base unit, equivalent to dollar.
The grapheme should be ¥, not 元. 元 is the Chinese character for yuan.
Template should be $1 in order to produce ¥100, not 100 ¥.

The Wikipedia article for Renminbi has examples/evidence of all these points.
¥ is also used for JPY, so it's not unique. I don't know what the standard is for a unique symbol (or if there is one)

Suggested modification on CNY and JPY.
// CNY change of currency name, grapheme and template

"CNY": {
"exponent": 2,
"iso_code": "CNY",
"iso_numeric": "156",
"name": "Chinese Renminbi",
"symbol": {
"grapheme": "¥",
"rtl": false,
"template": "$1"
}
},

// JPY removal of the uniqueSymbol secton

"JPY": {
"exponent": 0,
"iso_code": "JPY",
"iso_numeric": "392",
"name": "Yen",
"symbol": {
"grapheme": "¥",
"rtl": false,
"template": "$1"
}
},

Clarified the name of the currency - "Chinese Yuan Renminbi". And fixed the template, from "1 $" to "1$".
We deliberately decided to leave the symbol 元, to preserve the uniqueness of CNY and JPY to display symbols using uniqSymbol. Because two currencies are popular.
And both way of spelling (元 and ¥) are correct to use.
tomdaffurn, "unique symbol" is not standard. We recommend to use uniqSymbol if you want to exclude a repetition of symbols in different currencies.
@tomdaffurn and @vf-1, thank you.


Backtesting Results

Would it be possible to provide a file with the model output from the 2008-2016 backtests? I know I could just run the files myself but that would be time-consuming. It would be helpful if people could see the backtesting results to better compare this model to others.

There is a summary of 2008-2016 output in readme.md. What else are you looking for?
On Feb 1, 2021, 11:51 -0500, balexanderstats<EMAIL_ADDRESS>wrote:

Would it be possible to provide a file with the model output from the 2008-2016 backtests? I know I could just run the files myself but that would be time-consuming. It would be helpful if people could see the backtesting results to better compare this model to others.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I did not see that.


How would i trigger another Ripple using TouchableHighLight onLongPress prop

I was wondering how i would trigger another ripple using TouchableWithoutFeedback onLongPress prop.
I guess it will look something like this. i am not sure.
<TouchableWithoutFeedback
    onLongPress={() => this.secondDarkerRipple()}
    rippleDuration={200}
>
    <MKRipple
       rippleColor="rgba(0.5, 0.9, 0.1, 0.04)"
    >
        <View style={styles.container} />
    </MKRipple>
</TouchableWithoutFeedback>

Did you mean you want two different ripple effect on the same view, one for single click, another for long press?

@xinthink Yeah, that is exactly what i mean. Thanks.

@miknonny were you able to implement this? Did you need any more help?


ESM1.5 COVID fossil runs

resolution_complete type_CMIP6 (other)   |    by<EMAIL_ADDRESS>
10 member ensemble of COVID strong green simulations (2015-2050)
(ensemble size might be increased to 30)
exp name: SSP-245-fos-01 .. 10
branched from: HI-05..14
cmip6 exp name: ssp245-cov-fossil
cmorisation only at this stage, but experiments will be published under DAMIP

Issue migrated from trac:387 at 2024-01-31 18:36:47 +1100

<EMAIL_ADDRESS>changed milestone from Run complete to Archived

<EMAIL_ADDRESS>set resolution to complete

<EMAIL_ADDRESS>changed status from new to closed


fix: support multi keys exists

change
The modified code achieves the same effect as the redis exists command.

Thanks for your contribution. The test failed. Can you edit the string_test.go file? Delete this part and submit it.

Thanks for your contribution. The test failed. Can you edit the string_test.go file? Delete this part and submit it.

done，fix and add more ut.

done，fix and add more ut.

Thank you so much🌹


Add reset-network molecule test scenario in Corda

Description
As a developer I want to run molecule test so that I can test my reset-network roles.
Acceptance Criteria
1.Molecule tests should cover delete/gitops_files, delete/vault_secrets, delete/flux_releases and related roles
2. Verification step should be configured.
3. Tests should complete successfully

I will be working on this task


CLI does not handle new Master election

if a new master is elected, dcos CLI reports an error because core.mesos_master_url does not point to the correct master.

We don't yet support ZK in core.mesos_master_url.  We will at some point.  If you instead use core.dcos_url with a DCOS cluster, the master connection will work as expected.

I've filed this as a feature request internally @clca.


HDFS-16456. EC: Decommission a rack with only on dn will fail when the rack number is equal with replication

HDFS-16456
In below scenario, decommission will fail by TOO_MANY_NODES_ON_RACK reason:

Enable EC policy, such as RS-6-3-1024k.
The rack number in this cluster is equal with or less than the replication number(9)
A rack only has one DN, and decommission this DN.
The root cause is in BlockPlacementPolicyRackFaultTolerant::getMaxNodesPerRack() function, it will give a limit parameter maxNodesPerRack for choose targets. In this scenario, the maxNodesPerRack is 1, which means each rack can only be chosen one datanode.

int maxNodesPerRack = (totalNumOfReplicas - 1) / numOfRacks + 1;
here will be called, where totalNumOfReplicas=9 and  numOfRacks=9
When we decommission one dn which is only one node in its rack, the chooseOnce() in BlockPlacementPolicyRackFaultTolerant::chooseTargetInOrder() will throw NotEnoughReplicasException, but the exception will not be caught and fail to fallback to chooseEvenlyFromRemainingRacks() function.
When decommission, after choose targets, verifyBlockPlacement() function will return the total rack number contains the invalid rack, and BlockPlacementStatusDefault::isPlacementPolicySatisfied() will return false and it will also cause decommission fail.
  public boolean isPlacementPolicySatisfied() {     return requiredRacks <= currentRacks || currentRacks >= totalRacks;   }
According to the above description, we should make the below modify to fix it:

In startDecommission() or stopDecommission(), we should also change the numOfRacks in class NetworkTopology. Or choose targets may fail for the maxNodesPerRack is too small. And even choose targets success, isPlacementPolicySatisfied will also return false cause decommission fail.
In BlockPlacementPolicyRackFaultTolerant::chooseTargetInOrder(), the first chooseOnce() function should also be put in try..catch..., or it will not fallback to call chooseEvenlyFromRemainingRacks() when throw exception.
In verifyBlockPlacement, we need to remove invalid racks from total numOfRacks, or isPlacementPolicySatisfied() will return false and cause fail to reconstruct data.

@tasanuma Please review, thank you.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 38s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 13s

trunk passed

+1 :green_heart:
compile
23m  2s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 15s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 37s

trunk passed

+1 :green_heart:
mvnsite
3m 25s

trunk passed

+1 :green_heart:
javadoc
2m 29s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m  1s

trunk passed

+1 :green_heart:
shadedclient
26m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 39s

the patch passed

+1 :green_heart:
compile
24m 19s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
24m 19s

the patch passed

+1 :green_heart:
compile
21m 51s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 33s
/results-checkstyle-root.txt
root: The patch generated 1 new + 155 unchanged - 0 fixed = 156 total (was 155)

+1 :green_heart:
mvnsite
3m 21s

the patch passed

+1 :green_heart:
javadoc
2m 25s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 18s

the patch passed

+1 :green_heart:
shadedclient
23m 55s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 10s

hadoop-common in the patch passed.

-1 :x:
unit
431m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

668m  1s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4126

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 03872bc8785a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 77ef6540bee60ad045fe12008cf36049dd673ba8

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/1/testReport/

Max. process+thread count
2772 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 34s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 15s

trunk passed

+1 :green_heart:
compile
22m 54s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 10s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 38s

trunk passed

+1 :green_heart:
mvnsite
3m 25s

trunk passed

+1 :green_heart:
javadoc
2m 30s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 31s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
5m 58s

trunk passed

+1 :green_heart:
shadedclient
23m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s

the patch passed

+1 :green_heart:
compile
22m 15s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
22m 15s

the patch passed

+1 :green_heart:
compile
20m  2s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 36s

the patch passed

+1 :green_heart:
mvnsite
3m 19s

the patch passed

+1 :green_heart:
javadoc
2m 27s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 18s

the patch passed

+1 :green_heart:
shadedclient
24m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 49s

hadoop-common in the patch passed.

-1 :x:
unit
420m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 11s

The patch does not generate ASF License warnings.

650m 45s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4126

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 9a71fa74327b 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 372cf01e09848e8f3372b3eca599f7f109d59c2f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/2/testReport/

Max. process+thread count
2533 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma  The failed UT don't seem to relate to this patch, please help to check.

@tasanuma  Yes, I think clusterMap.getNumOfRacks() in BlockPlacementPolicyDefault should also be updated because only non empty rack makes sense.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  3s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 14s

trunk passed

+1 :green_heart:
compile
26m 33s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
22m 52s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 56s

trunk passed

+1 :green_heart:
mvnsite
3m 25s

trunk passed

+1 :green_heart:
javadoc
2m 27s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 19s

trunk passed

+1 :green_heart:
shadedclient
24m 36s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s

the patch passed

+1 :green_heart:
compile
22m 59s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
22m 59s

the patch passed

+1 :green_heart:
compile
21m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 40s

the patch passed

+1 :green_heart:
mvnsite
3m 15s

the patch passed

+1 :green_heart:
javadoc
2m 18s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 27s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
7m  4s

the patch passed

+1 :green_heart:
shadedclient
25m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 10s

hadoop-common in the patch passed.

+1 :green_heart:
unit
242m 29s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  6s

The patch does not generate ASF License warnings.

501m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4126

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 33711d5ec556 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 662323a9701a50f4f95edb4632b6d0bf0d4b8d9c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/4/testReport/

Max. process+thread count
3325 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@surendralilhore Please comment if you have any concerns.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 55s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 29s

trunk passed

+1 :green_heart:
compile
26m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
23m  9s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
3m 45s

trunk passed

+1 :green_heart:
mvnsite
3m 38s

trunk passed

+1 :green_heart:
javadoc
2m 43s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 26s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 45s

trunk passed

+1 :green_heart:
shadedclient
24m 45s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 17s

the patch passed

+1 :green_heart:
compile
23m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
23m 30s

the patch passed

+1 :green_heart:
compile
22m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 40s

the patch passed

+1 :green_heart:
mvnsite
3m 23s

the patch passed

+1 :green_heart:
javadoc
2m 21s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
3m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
6m 40s

the patch passed

+1 :green_heart:
shadedclient
25m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 27s

hadoop-common in the patch passed.

-1 :x:
unit
429m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 15s

The patch does not generate ASF License warnings.

697m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4126

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 97de28519e31 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 662323a9701a50f4f95edb4632b6d0bf0d4b8d9c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/3/testReport/

Max. process+thread count
2633 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4126/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma Thank you for your review and giving a lot of useful suggestions.


What is this error?

Illegal digit in hex char in name: -1
 at error (http://localhost/lib/pdf/shared/util.js:221:15)
at Object.Lexer_getName [as getName] (http://localhost/lib/pdf/core/parser.js:733:59)
at Object.Lexer_getObj [as getObj] (http://localhost/lib/pdf/core/parser.js:818:23)
at Object.Parser_shift [as shift] (http://localhost/lib/pdf/core/parser.js:53:32)
at Object.Parser_getObj [as getObj] (http://localhost/lib/pdf/core/parser.js:58:12)
at Object.Parser_getObj [as getObj] (http://localhost/lib/pdf/core/parser.js:88:34)
at Object.XRef_fetchUncompressed [as fetchUncompressed] (http://localhost/lib/pdf/core/obj.js:1261:28)
at Object.XRef_fetch [as fetch] (http://localhost/lib/pdf/core/obj.js:1218:26)
at Object.XRef_fetchIfRef [as fetchIfRef] (http:/localhost/lib/pdf/core/obj.js:1199:19)

Can you please provide the PDF which produces this error? Also other relevant information like pdf.js version used.

When reporting an issue, please make sure that you read (especially the first paragraph): https://github.com/mozilla/pdf.js/blob/master/CONTRIBUTING.md.

I'm downloaded from the banner on the right side.
PDF file send to e-mail

GitHub doesn't support attaching PDF files, and neither does the mailing list (cross-posted here).
@vivacewith Please upload the PDF file to a file sharing service, such as e.g. Dropbox, Google Drive, or PDFy, and attach a link to the file here.

I don't think PDF here a fault, but it's how the PDF.js is deployed. You did not provide enough information about how the custom application was deployed. The best way for us is to see that via public URL we can access. Otherwise describe in details what you did so we can reproduce your steps.

This problem does not occur in most PDF.JS program. Even if working properly loaded in the demo code http://mozilla.github.io/pdf.js/web/viewer.html. However, the code is applied to my server results in an error. I'm not a matter of PDF.JS I want to know that you are applying to any part would raise the wrong article. Uploading a PDF file edaga It will be meaningless tasks.

Closing as incomplete. If we cannot reproduce this error, it is almost impossible to find the cause of it. Make sure your server uses the most recent version of PDF.js. Provide steps to reproduce the issue (for example a link to your server) to reopen.


use credentials iff not _is_remote

This just couples the cases:

inside the container: never use credentials
outside: always use credentials (there's no longer optionality)

The point is to remove the dependency on ClientHello

I think this is mostly a gap on my side, but I'm still not quite sure what the defined behavior is going to be for users creating a client using Client.from_credentials in a remote environment. Otherwise looks good.

Thanks @mwaskom!


1.1.0-preview4 scaffolding explodeds with Could not load file or assembly 'Microsoft.DotNet.InternalAbstractions'.

After upgrading your application to 1.1.0 (our current verification bits) attempting to scaffold a controller results in:

We encountered this in the last verification process and ended up fixing it by adding a direct package reference to Microsoft.DotNet.InternalAbstractions. That fix doesn't seem to have made it back to the current release. This was needed because one of the dependent Scaffolding packages required Microsoft.DotNet.InternalAbstractions at one point and was since removed.
For reference the project that I'm attempting to scaffold on is:
{
  "userSecretsId": "aspnet-_11RTMSignOff-e536f60b-f423-4f85-b426-73d926def78c",

  "dependencies": {
    "Microsoft.NETCore.App": {
      "version": "1.1.0",
      "type": "platform"
    },
    "Microsoft.AspNetCore.Authentication.Cookies": "1.1.0",
    "Microsoft.AspNetCore.Diagnostics": "1.1.0",
    "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.1.0",
    "Microsoft.AspNetCore.Identity.EntityFrameworkCore": "1.1.0",
    "Microsoft.AspNetCore.Mvc": "1.1.0",
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.1.0-preview4-final",
      "type": "build"
    },
    "Microsoft.AspNetCore.Routing": "1.1.0",
    "Microsoft.AspNetCore.Server.IISIntegration": "1.1.0",
    "Microsoft.AspNetCore.Server.Kestrel": "1.1.0",
    "Microsoft.AspNetCore.StaticFiles": "1.1.0",
    "Microsoft.EntityFrameworkCore.SqlServer": "1.1.0",
    "Microsoft.EntityFrameworkCore.SqlServer.Design": {
      "version": "1.1.0",
      "type": "build"
    },
    "Microsoft.EntityFrameworkCore.Tools": {
      "version": "1.1.0-preview4-final",
      "type": "build"
    },
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.1.0",
    "Microsoft.Extensions.Configuration.Json": "1.1.0",
    "Microsoft.Extensions.Configuration.UserSecrets": "1.1.0",
    "Microsoft.Extensions.Logging": "1.1.0",
    "Microsoft.Extensions.Logging.Console": "1.1.0",
    "Microsoft.Extensions.Logging.Debug": "1.1.0",
    "Microsoft.Extensions.Options.ConfigurationExtensions": "1.1.0",
    "Microsoft.VisualStudio.Web.BrowserLink.Loader": "14.0.0",
    "Microsoft.VisualStudio.Web.CodeGeneration.Tools": {
      "version": "1.1.0-preview4-final",
      "type": "build"
    },
    "Microsoft.VisualStudio.Web.CodeGenerators.Mvc": {
      "version": "1.1.0-preview4-final",
      "type": "build"
    }
  },

  "tools": {
    "BundlerMinifier.Core": "2.0.238",
    "Microsoft.AspNetCore.Razor.Tools": "1.1.0-preview4-final",
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.1.0-preview2-final",
    "Microsoft.EntityFrameworkCore.Tools": "1.1.0-preview4-final",
    "Microsoft.Extensions.SecretManager.Tools": "1.1.0-preview4-final",
    "Microsoft.VisualStudio.Web.CodeGeneration.Tools": {
      "version": "1.1.0-preview4-final",
      "imports": [
        "portable-net45+win8"
      ]
    }
  },

  "frameworks": {
    "netcoreapp1.0": {
      "imports": [
        "dotnet5.6",
        "portable-net45+win8"
      ]
    }
  },

  "buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true
  },

  "runtimeOptions": {
    "configProperties": {
      "System.GC.Server": true
    }
  },

  "publishOptions": {
    "include": [
      "wwwroot",
      "**/*.cshtml",
      "appsettings.json",
      "web.config"
    ]
  },

  "scripts": {
    "prepublish": [ "bower install", "dotnet bundle" ],
    "postpublish": [ "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%" ]
  }
}

/cc @Eilon @pranavkm @mlorbetske

Doesn't look like https://github.com/aspnet/Scaffolding/commit/94a73fc282710f04ea6547f7fc39d7f0fa465b09 was merged back in to dev.

Also shouldn't the project.json file use the latest IIS integration tools?
"Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.1.0-preview4-final"

@dougbu wasn't on the feed when I built the project 😄 is now.

@pranavkm the 1.1.0 package for scaffolding we're testing with is being built from the rel/1.1.0 branch right?

The changeset needs to be cherry-pick to rel/1.1.0 and then merged in to dev.

The commit wasn't merged to dev in the hopes that dev would be used for Msbuild based development. I will move the commit to this branch shortly.

Fixed in https://github.com/aspnet/Scaffolding/commit/3adfd92312a6f2cbe0ed31258ea04fe72f5a5193

https://github.com/aspnet/Scaffolding/issues/311


[Compute] az snapshot grant-access: Add parameter --file-format to support specifying file format when making request for SAS on a VHDX file format snapshot

Related command

az snapshot grant-access
Description

Close: #28320
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Compute


API reported an unknown status for device

Please help me. Cant understand where is problem.i am using sonoff 4ch,which is set up to open my garage and door(all system is working on low voltage settings with build in remote from garage and door),and everything is working find in original program, but cant get it work  in homebridge. please give me some help!
[eWeLink] A total of [1] accessories were loaded from the local cache
[2018-7-3 00:43:48] [eWeLink] Requesting a list of devices from eWeLink HTTPS API at [https://eu-api.coolkit.cc:8080]
[2018-7-3 00:43:48] Homebridge is running on port 51826.
[2018-7-3 00:43:48] [eWeLink] eWeLink HTTPS API reports that there are a total of [1] devices registered
[2018-7-3 00:43:48] [eWeLink] Evaluating if devices need to be removed...
[2018-7-3 00:43:48] [eWeLink] Verifying that all cached devices are still registered with the API. Devices that are no longer registered with the API will be removed.
[2018-7-3 00:43:48] [eWeLink] Device [Гараж/Ворота] is regeistered with API. Nothing to do.
[2018-7-3 00:43:48] [eWeLink] Evaluating if new devices need to be added...
[2018-7-3 00:43:48] [eWeLink] Device with ID [100032a58f] is already configured. Ensuring that the configuration is current.
[2018-7-3 00:43:48] [eWeLink] Updating recorded Characteristic.On for [Гараж/Ворота] to [false]. No request will be sent to the device.
[2018-7-3 00:43:48] [eWeLink] Setting power state to [off] for device [Гараж/Ворота]
[2018-7-3 00:43:48] [eWeLink] API key retrieved from web service is [----------]
[2018-7-3 00:43:48] [eWeLink] Connecting to the WebSocket API at [wss://eu-pconnect3.coolkit.cc:8080/api/ws]
[2018-7-3 00:43:48] [eWeLink] Sending login request [{"action":"userOnline","userAgent":"app","version":6,"nonce":"153056782866700","apkVesrion":"1.8","os":"ios","at":"2266269c506a9887e119401c04540e7c22912546","apikey":"========","ts":"1530567828","model":"iPhone10,6","romVersion":"11.1.2","sequence":1530567828667}]
[2018-7-3 00:43:48] [eWeLink] WebSocket messge received:  {"error":0,"apikey":"-------","config":{"hb":1,"hbInterval":145},"sequence":"1530567828667"}
[2018-7-3 00:44:28] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:44:28] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:44:39] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:44:39] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:44:42] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:44:42] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:46:20] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:46:21] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:46:27] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:46:27] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
WebSocketClient: retry in 5000ms 1006
[2018-7-3 00:46:28] [eWeLink] WebSocket was closed. Reason [1006]
[2018-7-3 00:46:29] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:46:29] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
WebSocketClient: reconnecting...
[2018-7-3 00:46:34] [eWeLink] Sending login request [{"action":"userOnline","userAgent":"app","version":6,"nonce":"153056799424100","apkVesrion":"1.8","os":"ios","at":"---------","apikey":"=======","ts":"1530567994","model":"iPhone10,6","romVersion":"11.1.2","sequence":1530567994241}]
[2018-7-3 00:46:34] [eWeLink] WebSocket messge received:  {"error":0,"apikey":"-------","config":{"hb":1,"hbInterval":145},"sequence":"1530567994241"}
[2018-7-3 00:46:43] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:46:43] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:46:45] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:46:45] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:47:02] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:47:02] [eWeLink] API reported an unknown status for device [Гараж/Ворота]
[2018-7-3 00:47:04] [eWeLink] Requesting power state for [Гараж/Ворота]
[2018-7-3 00:47:04] [eWeLink] API reported an unknown status for device [Гараж/Ворота]

Did you solve the issue? If yes, how?
Thank you.

I have the same problem with son off 2 chanel.  I hope that i don't need to change os ewe link to other one (tasiota or other one).
Thanks for you help.

Hi,
I fixed my problem with the index.js of MrTomash (thanks Tom).  So, the file have a litle error in definition of number of chanel.
switch(deviceInformationFromWebApi.extra.extra.model) {
case 'PSF-B04-GL' :
switchesAmount = 3;
break;
case 'PSB-B04-GL' :
switchesAmount = 2;
break;
case 'PSF-A04-GL' :
switchesAmount = 4;
break;
PSF-04-GL have 2 switches, not 3.  I did this change (in 2 places in the code:  deviceInformationFromWebApi.extra.extra.model end deviceToAdd.extra.extra.model) and now, all works fine in my homekit. (I placed a remark two of case because i don't know which model have 3 or 4 switches) .
switch(deviceInformationFromWebApi.extra.extra.model) {
case 'PSF-B04-GL' :
switchesAmount = 2;
break;
//case 'PSB-B04-GL' :
//    switchesAmount = 2;
//    break;
// case 'PSF-A04-GL' :
//   switchesAmount = 4;
//   break;
Richard

Hello, I'm new to this ewelink-homebridge, so if i don't know somethink easy, i apologize.
In which line did you add this thing? I'm having same problem, but i can't find this line?


TN - Missing required information from results from ^05D2195670^CLIA

Angie -<EMAIL_ADDRESS>8/23 10:32am
Starting on 8/15, TN started receiving results from CDC Prime for what looks to be a new sending facility. The following are missing from the 15 messages received so far:
MSH-4.1: You are only sending ^05D2195670^CLIA
OBR-4.1 and OBR-4.2
OBX-3.1 and OBX-3.2
We would need all messages for this new facility resend. We would also ask that when possible to inform us when you go live with a new MSH-4 so that we can keep an eye out of issues quickly. Below are a list of messages to resend. If resending using the same MSH-10, we ask that .rerun be appended to each file or one single file if sending a batch to avoid the messages from being flagged as duplicate.
SH00116_a8b496e2c9f5474ba65c4c8f2f20ee66
SH00116_cf42888c78da461c981fa335c58b838c
SH00116_073678df92b144799b3e26d9c8558d0b
SH00116_b370d077deaa4628844497edda627ab3
SH00116_ff2637129806485cbae4beab9a68d567
SH00116_b1100993e6c14f43a84f094ca3841ab2
SH00116_41f0c50509f54742b691c62ef323139d
SH00116_7aff0d00114541f4aab5a06c46969bd0
SH00116_b67d5c4e88944d58b9c921a0be688a01
SH00116_c9e723fd158d434bac08cb9c9b3416a7
SH00116_00ff5870c054419282d6cc82464fa5f9
SH00116_312ff4eb5f9749ab91f0eec34b895b10
SH00116_aa9e3c3e3a7a4ea082c8edfec5ec1969
SH00116_d9ecb6b90f624590ac03873a39b47aa2
SH00116_4e4a18cae0364eaab679831abaa39bbf

Hello,
Any updates on fixing this issue as we are still get messages that we cannot process.
Thanks,
Angie

This issue is related to the SafeHealth Epic issue that they are currently correcting. SafeHealth is currently working on modifying their submission csv file to RS so that the data quality issues are resolved.

Sent Senders update, please see below the communication to TN -<EMAIL_ADDRESS>and LA -<EMAIL_ADDRESS>Greetings,
We have been working with the original sender and they advised that they will release their updates into production today.
Thank you for your patience.
Best regards,
Sharon
The ReportStream Support Team
Contact us at<EMAIL_ADDRESS>Support hours:  8:00 am through 9:00 pm Eastern time
Monday-Friday, excluding US public holidays

TN asked if the they will be receiving all the messages from the original sender.

Update requested from TN - CEDS Informatics:
Hello,
We wanted to check if all these messages have been resent to TN?
Thanks,
CEDS Informatics

Not yet. They sent a sample backlog on monday but there were still issues with the messages. So I sent feedback yesterday. Not sure about a timeline but I relayed the importance of reporting results in a timely manner.

@brick-green I'll let them know that we are still waiting on the Sender to update/finalize the messages prior to sending back out.

Email from CEDS:
Hello,
We wanted to check if messages have been resent?
Thanks,
CEDS Informatics

Update from CEDs Informatics on 10/3/2022:
Hi Sharon,
We did not get any confirmation that the messages were resent. Please confirm this on your end and we would check if we received anything.
Thanks,
CEDS Informatics

Update from TN CEDS Informatics on 3:50 PM:
Hello,
TN can confirm we received 28 backlog of messages that has previously failed to process in our system and has no issues with them. We consider this case closed.
Thanks,
CEDS Informatics


USHIFT-1426: remove openvswitch pin in test image blueprint

This depends on #2114
/assign @ggiguash @zshi-redhat

/hold
This PR passes because the 4.13 RPM still pins openvswitch3.1 to the version where the RPM installation creates the user and group properly. We need to merge #2114 and then have a new 4.13 z-stream release without the pin, then re-test this change.

microshift-4.13.8-202308031445.p0.g717bea4.assembly.4.13.8.el9 includes 236f3377699fd269623a6258b5f37e2f4751ac09, which removes the version cap for openvswitch3.1 from the release-4.13 branch but that version does not appear to be available through public repos, yet.

Looks like 4.13.8 has been tagged. Unholding the PR.
$ sudo dnf clean all
$ sudo dnf search --showduplicates  microshift*  | grep 4.13.8
Last metadata expiration check: 0:00:25 ago on Tue 08 Aug 2023 01:20:54 PM UTC.
microshift-4.13.8-202308031445.p0.g717bea4.assembly.4.13.8.el9.x86_64 : MicroShift service
microshift-greenboot-4.13.8-202308031445.p0.g717bea4.assembly.4.13.8.el9.noarch : Greenboot components for MicroShift
microshift-networking-4.13.8-202308031445.p0.g717bea4.assembly.4.13.8.el9.x86_64 : Networking components for MicroShift
microshift-release-info-4.13.8-202308031445.p0.g717bea4.assembly.4.13.8.el9.noarch : Release information for MicroShift
microshift-selinux-4.13.8-202308031445.p0.g717bea4.assembly.4.13.8.el9.noarch : SELinux policies for MicroShift

/unhold

/lgtm


Adapt install script to new release assets naming

Purpose of Changes and their Description
Update the install.sh script according to the new release assets name template, for instance:
allorad_${OS}_${ARCH} => allora-chain_${VERSION_DIGITS}_${OS}_${ARCH}
The installed binary is still allorad.
I took the opportunity to update the default version installed to the current latest (i.e. 0.7.0).
Can be tested before merging with:
curl -sSL https://raw.githubusercontent.com/allora-network/allora-chain/arnaud%2Fadapt-install-script/install.sh | bash -s -- v0.7.0

Link(s) to Ticket(s) or Issue(s) resolved by this PR
Are these changes tested and documented?

[x] If tested, please describe how. If not, why tests are not needed.
[x] If documented, please describe where. If not, describe why docs are not needed.
[x] Added to Unreleased section of CHANGELOG.md?

this is fine although I think it makes sense to start storing this kind of stuff in an .env or something in the repo

This script being used to as an install oneliner through curl -sSL https://raw.githubusercontent.com/allora-network/allora-chain/refs/heads/main/install.sh | bash storing the latest version in a .env or resolving dynamically using the repo content won't work. But maybe updating it through a CI action could help keep it up to date.


rebar3 ex_doc throws on OTP-27.0-rc1

Reference: https://erlangforums.com/t/erlang-otp-27-0-rc1-released/3300/13
Local PR to make it visible from CI: https://github.com/starbelly/rebar3_ex_doc/pull/80
I'm still looking at why this is, but am preemptively opening the issue so it's visible for those who search in this repo.

I did the same with OTP-26.2.1 and ✅

I did the same with OTP-25.2 and ✅

I did the same with Elixir 1.16.0 and ✅

I did the same with Elixir 1.14.5 and ✅

⚠ It seems we haven't released a new rebar3_ex_doc version in a while. I'll adapt CI to use the newest version, in any case, since I'm not sure the issue is not originated in that (not releasing and having ex_doc adapt to OTP 27, for example). @starbelly, should we release soon? (and maybe think about a more regular release schedule, at least closer to ex_doc's)


Install chrome driver for current chrome version

Sadly xenial (or maybe just travis) has upgraded chrome but not chromedriver, seems safer to try to download the correct version of chromedriver for the version of chrome we have, but it wasn't super easy to work out how :P


Popup re-opens on language change

Clik on a feature
Close the popup with close button of the popup
Change the lanaguage
----> the popup is reopening

Expected :
The popup stays closed

Ok I fix it

This bug happens on reducing as well:

Clik on a feature
Reduce the popup
Change the lanaguage
----> the popup is reopening


feat: Front Matter support

This introduces support for Front Matter (and threading) as raised in #166.
Implemented at present:

Basic parsing for all Front Matter requested in the issue + validation
Threading support (including Front Matter support for each thread item)
Reply support
(Quote) retweet support
Media attachment support from local files
Polls (needs Ads API access)

(This also adds support for invoking the library with --file flag, making development easier locally)
TODO:

Body ^ syntax for attachments
Media alt text support
Polls via v2 status API, not Ads
PR tests?
Code coverage?

Resolves #151
Resolves #134
Resolves #101
Resolves #92

Thank you Matt! I hope to be able to look at your PR this Sunday! I'm excited to see others contribute, and to see the whole project move forward 🚀

Awesome, thank you! I'll keep chipping away at the other functionality that's supported in the front matter (retweets, schedule, etc.) and push those up once done. I've been writing some tests for pushes based on the new stuff, but would love some feedback on getting the tests up to scratch (looks like PRs are also tested? and coverage is yelling at me).

Sorry I run out of Sunday 😴 I am looking forward to review your work, as soon as I find some time, I won't forget. Please give me a few more days

So, here's where we're at:
I've written all the logic for all the features that feel relatively simple to implement, and limited tests for all of them. (Except for the body syntax for attachments, I'll try to get that done soon:tm:.)
I'd love some more help on getting full test coverage for everything I've added (PR tests, plus improving the push tests as well).
Also worth noting that I've not actually tested any of this code against Twitter, only with the in-repo tests and referring to Twitter docs. It seems like testing this properly is either going to need faking a lot of GitHub data, or setting up a test repo using this branch in an action.
I'm not sure I really want to handle scheduling in this tweet. Looking at the Twitter docs for scheduling, it feels super limited unless I'm missing something -- you can schedule a tweet, but not anything else, so if a poll were to be added to a scheduled tweet, the poll would likely be expired when the tweet gets sent, as polls start from when they are created (at least, according to the docs).
My gut feeling on scheduling is that this'd be better handled through automation in GitHub, rather than relying on Twitter. E.g. automation that only merges a new tweet PR at the right time. That's why I'm feeling it'd be best not to tackle it as part of this PR, and move it to a separate discussion/issue/PR.

I've written all the logic for all the features that feel relatively simple to implement, and limited tests for all of them. (Except for the body syntax for attachments, I'll try to get that done soon™.)

Awesome!!

Also worth noting that I've not actually tested any of this code against Twitter, only with the in-repo tests and referring to Twitter docs. It seems like testing this properly is either going to need faking a lot of GitHub data, or setting up a test repo using this branch in an action.

We can use this repo and the twitter test account (https://twitter.com/commit2tweet/) for testing, no problem, I can share the credentials with you.

My gut feeling on scheduling is that this'd be better handled through automation in GitHub, rather than relying on Twitter. E.g. automation that only merges a new tweet PR at the right time. That's why I'm feeling it'd be best not to tackle it as part of this PR, and move it to a separate discussion/issue/PR.

Sounds like a good plan!

I'm still very underwater with life, and it will be this way until May. But things do clear up a little :) If you get blocked by anything please let me know and I'll try to find time to help out as soon as possible, otherwise I plan to have time for twitter-together in May. Wow, time flies!

Where has this stalled out? Where can I help out at all? I'd really like to see some of these features for the jenkins project

sorry I did not forget about y'all, this PR is the oldest and now only remaining item on my TODO backlog. Please give me a few more days to catch up with new work from this week, I'm really looking forward to dive into it

👀 Taking a look at why media tweets don't work (waiting for an account to get approved for v1 API access to I can test on an actual account)

Ah! Alt text is causing the issue as the twitter library this project uses doesn't support JSON payloads, which is required for that endpoint. I'll comment that out for now and it will likely be something that can be fixed when #195 is addressed.

I should also note that polls should theoretically work for accounts with Ads API access, but I do not have an application that has access to that. Again, with #195 this can be solved for more properly by just using the direct polls option when creating a tweet via the v2 API.

@gr2m I think this is probably good to go (I ran through all the new push to main tests using the file flag against my account, only pools fails as I don't have Ads API access), unless you want to look at adding more testing?

@IstoraMandiri if you could give the latest version a few final tests, that'd be great, I'll try to do the same myself. Then I plan to merge on Monday if that's okay with both of you?
If you are interested in continuing to contribute, I'd be happy to invite you both as maintainers. No worries if not, just let me know.

I'm not sure how much time I'd be able to throw at maintaining this on a regular basis, but am hoping to look at the v2 API update next, as it'll unblock a few things as a follow-up to this PR (and make the project more accessible w/o the need for applying for v1.1 or ads API access)

Hey @gr2m sorry for the delay.
We are probably going to be working with this in production in the coming weeks and would be happy to help maintain it, including implementing v2 and adding additional features, fixing some bugs, and deletions being a must have.
https://github.com/ethereumclassic/twitter-together/issues

Once this PR gets merged I'll follow up with a fix for that trailing whitespace 👍 Just needs some regex updated

can you look into the failing tests? Otherwise this is good to go.
I think this might also be a good time to move the repository to the @twitter-together org. I'll invite you both as collaborators, not expectations though, just lowering barriers for further contributions.

The only thing failing with tests is coverage, which I think would be a substantial chunk of further work to write out the PR test variants for every combination of FrontMatter.
Happy to do it here if you want that (will delay the PR for quite a while longer), or we can lower the coverage requirement for now and create a tech debt issue to restore full coverage?

The only thing failing with tests is coverage

got it, let's lower the coverage requirement for now

This should be good to go -- all existing tests in the repo are passing w/o modification, and all the new tests are passing too, so I'm hopeful this should be safe to land 💙

Hey I just realized we didn't document all the new features yet. Can you update the README?
Are the remaining TODOs from the pull request body still up to date? We can create follow up issues once we merge

🤦 Ah yes, will do some quick docs writing.
Yeah, those TODOs are up-to-date -- I'll file issues once this is merged (a few are already covered by existing issues)

I'm looking into the failing tests, the are related to the repository rename

I think I got through all of them but one
npx tap test/push-main-setup/test.js

My kids just woke up, I won't be able to look into it before tomorrow. If you like and have the time, can you have a look? Maybe you figure out the last one?

👀 Will have a look

✅ Fixed -- so it looks like one of your recent commits to main as part of the rename bumped the lockfile to v2 badly, when this branch is still expending lockfile v1 and Node.js 12.
We can properly bump the lockfile to v2 and start using Node.js 16 with #196

(Interestingly the CI is already using Node.js 16 and is happy now, so I figure something unexpected must've happened within the lockfile itself)

@gr2m If you're around enough to be able to merge this, that'd be ace ❤ I'll jump right on doing the Node.js 16 upgrade properly to fix this weird lockfile situation

@MattIPv4 shall we do a follow up issue for scheduled tweets explaining why we didn't add it and discuss there what might be done? I did create https://github.com/gr2m/merge-schedule-action for this very reason, but having it built-in would be nice. If a poll is the only limitation for scheduling, maybe we fail the CI if a scheduled tweet also includes a poll?

Let's take the discussion over to #41 and use that as the hub for the continued discussion of that 👍


[SMN] [Feature Request] Egi Order in phases.

As it is we have to look at the timestamps for each egi. It would be better to have them sorted by time, and put on the small header for each demi phase.

Alternative:

Are they not currently sorted by time? Your pictures change just hides the time stamp which I think can be useful for seeing if there were delays between the egis.

They are not, in fact, sorted by time:

My changes don't hide anything as the text on the header is something I added:

This would give a great overview of the kind of things that I want to see in a rotation for a given parse. Egi order would be easy to look at without reading timestamps.