Memory leak caused by hashbrown

I have a segfault randomly with the following code, I ran it with valgrind and I got this memory leak.
rustc 1.80.1 (3f5fd8dd4 2024-08-06) Ubuntu
Code
extern crate spider;
extern crate env_logger;

use std::hash::{DefaultHasher, Hash, Hasher};

use newspaper::{Newspaper, NewspaperModel, Paper};
use spider::website::Website;
use spider::tokio;
use env_logger::Env;

use meilisearch_sdk::client::*;

pub mod newspaper;

async fn indexing(papers: &[Paper]) {
    println!("Indexing {} papers", papers.len());
    let client = Client::new("http://localhost:7700", Some("a")).unwrap();

    let res = client.index("papers").add_documents(papers, Some("hash_url")).await;
    match res {
        Ok(_) => println!("Indexing done"),
        Err(e) => println!("Error: {}", e),
    }
}

#[tokio::main]
async fn main() {
    let env = Env::default()
    .filter_or("RUST_LOG", "error")
    .write_style_or("RUST_LOG_STYLE", "always");

    let file = std::fs::File::open("newspapers.json").unwrap();
    let newspapers: Vec<NewspaperModel> = serde_json::from_reader(file).unwrap();

    let newspapers = newspapers.iter().map(|newspaper| Newspaper::from(newspaper.clone())).collect::<Vec<_>>();
    let mut hasher: DefaultHasher = DefaultHasher::new();
    // TODO: Use a thread pool to scrape multiple websites concurrently
    for paper in newspapers {
       let mut website = Website::new(paper.get_url().as_str());
        website.with_limit(100);
        println!("Scraping {}", paper.get_title());
        website.scrape().await;
        println!("Scraping done");
        let mut papers = Vec::new();
        if let Some(pages) = website.get_pages() {
            println!("Scraping pages");
            for page in pages.as_ref() {
                let html = page.get_html();

                let document = scraper::Html::parse_document(&html);
                for selector in paper.get_selectors() {
                    let texts = document.select(selector).flat_map(|el| el.text()).collect::<Vec<_>>();
                    if texts.is_empty() {
                        continue;
                    }
                    page.get_url().hash(&mut hasher);
                    papers.push(Paper {
                        title: page.get_url().to_string(),
                        url: page.get_url().to_string(),
                        content: texts.join(" "),
                        hash_url: hasher.finish()
                    });
                    break;
                }

                if papers.len() >= 500 {
                    indexing(papers.as_slice()).await;
                    papers.clear();
                }
            }
        }
        if papers.is_empty() {
            continue;
        }
        indexing(papers.as_slice()).await;
    }
}

Valgrind
Scraping done
Scraping pages
Indexing 14 papers
Indexing done
Error leaked 816 B in 1 block
        Info at malloc
             at alloc::alloc::alloc (alloc.rs:100)
             at alloc_impl (global.rs:35)
             at allocate (global.rs:100)
             at hashbrown::raw::inner::alloc::inner::do_alloc (alloc.rs:36)
             at hashbrown::raw::inner::RawTableInner::new_uninitialized (mod.rs:1750)
             at hashbrown::raw::inner::RawTableInner::fallible_with_capacity (mod.rs:1788)
             at hashbrown::raw::inner::RawTableInner::with_capacity (mod.rs:1815)
             at hashbrown::raw::inner::RawTable<T,A>::with_capacity_in (mod.rs:901)
             at hashbrown::raw::inner::RawTable<T>::with_capacity (mod.rs:836)
             at hashbrown::map::HashMap<K,V,S>::with_capacity_and_hasher (map.rs:505)
             at hashbrown::map::HashMap<K,V>::with_capacity (map.rs:324)
             at hashbrown::set::HashSet<T>::with_capacity (set.rs:190)
             at __static_ref_initialize (page.rs:68)
             at core::ops::function::FnOnce::call_once (function.rs:250)
     Summary Leaked 816 B total

Cargo tree
crawler v0.1.0 (/home/dimitri/Development/fact-cheker/crawler)
├── meilisearch-sdk v0.27.1
│   ├── reqwest v0.12.7
│   │   ├── h2 v0.4.6
│   │   │   ├── indexmap v2.4.0
│   │   │   │   └── hashbrown v0.14.5
├── spider v2.1.2
│   ├── hashbrown v0.14.5 (*)

I have a segfault randomly with the following code, I ran it with valgrind and I got this memory leak.
rustc 1.80.1 (3f5fd8dd4 2024-08-06) Ubuntu
Code

extern crate spider;

extern crate env_logger;

use std::hash::{DefaultHasher, Hash, Hasher};

use newspaper::{Newspaper, NewspaperModel, Paper};

use spider::website::Website;

use spider::tokio;

use env_logger::Env;

use meilisearch_sdk::client::*;

pub mod newspaper;

async fn indexing(papers: &[Paper]) {

    println!("Indexing {} papers", papers.len());

    let client = Client::new("http://localhost:7700", Some("a")).unwrap();

    let res = client.index("papers").add_documents(papers, Some("hash_url")).await;

    match res {

        Ok(_) => println!("Indexing done"),

        Err(e) => println!("Error: {}", e),

    }

}

#[tokio::main]

async fn main() {

    let env = Env::default()

    .filter_or("RUST_LOG", "error")

    .write_style_or("RUST_LOG_STYLE", "always");

    let file = std::fs::File::open("newspapers.json").unwrap();

    let newspapers: Vec<NewspaperModel> = serde_json::from_reader(file).unwrap();

    let newspapers = newspapers.iter().map(|newspaper| Newspaper::from(newspaper.clone())).collect::<Vec<_>>();

    let mut hasher: DefaultHasher = DefaultHasher::new();

    // TODO: Use a thread pool to scrape multiple websites concurrently

    for paper in newspapers {

       let mut website = Website::new(paper.get_url().as_str());

        website.with_limit(100);

        println!("Scraping {}", paper.get_title());

        website.scrape().await;

        println!("Scraping done");

        let mut papers = Vec::new();

        if let Some(pages) = website.get_pages() {

            println!("Scraping pages");

            for page in pages.as_ref() {

                let html = page.get_html();

                let document = scraper::Html::parse_document(&html);

                for selector in paper.get_selectors() {

                    let texts = document.select(selector).flat_map(|el| el.text()).collect::<Vec<_>>();

                    if texts.is_empty() {

                        continue;

                    }

                    page.get_url().hash(&mut hasher);

                    papers.push(Paper {

                        title: page.get_url().to_string(),

                        url: page.get_url().to_string(),

                        content: texts.join(" "),

                        hash_url: hasher.finish()

                    });

                    break;

                }

                if papers.len() >= 500 {

                    indexing(papers.as_slice()).await;

                    papers.clear();

                }

            }

        }

        if papers.is_empty() {

            continue;

        }

        indexing(papers.as_slice()).await;

    }

}

Valgrind

Scraping done

Scraping pages

Indexing 14 papers

Indexing done

Error leaked 816 B in 1 block

        Info at malloc

             at alloc::alloc::alloc (alloc.rs:100)

             at alloc_impl (global.rs:35)

             at allocate (global.rs:100)

             at hashbrown::raw::inner::alloc::inner::do_alloc (alloc.rs:36)

             at hashbrown::raw::inner::RawTableInner::new_uninitialized (mod.rs:1750)

             at hashbrown::raw::inner::RawTableInner::fallible_with_capacity (mod.rs:1788)

             at hashbrown::raw::inner::RawTableInner::with_capacity (mod.rs:1815)

             at hashbrown::raw::inner::RawTable<T,A>::with_capacity_in (mod.rs:901)

             at hashbrown::raw::inner::RawTable<T>::with_capacity (mod.rs:836)

             at hashbrown::map::HashMap<K,V,S>::with_capacity_and_hasher (map.rs:505)

             at hashbrown::map::HashMap<K,V>::with_capacity (map.rs:324)

             at hashbrown::set::HashSet<T>::with_capacity (set.rs:190)

             at __static_ref_initialize (page.rs:68)

             at core::ops::function::FnOnce::call_once (function.rs:250)

     Summary Leaked 816 B total

Cargo tree

crawler v0.1.0 (/home/dimitri/Development/fact-cheker/crawler)

├── meilisearch-sdk v0.27.1

│   ├── reqwest v0.12.7

│   │   ├── h2 v0.4.6

│   │   │   ├── indexmap v2.4.0

│   │   │   │   └── hashbrown v0.14.5

├── spider v2.1.2

│   ├── hashbrown v0.14.5 (*)

Hi thanks for the issue. Did you put an issue in the hashbrown project? Also if you can put your OS so we can better triage if not.

Hi thanks for the issue. Did you put an issue in the hashbrown project? Also if you can put your OS so we can better triage if not.

Hi, yes, I have.
I'm using Ubuntu 24.04 LTS. After some tests, the error doesn't occur on macOS with M1. The reason for the previous leak could be explained by the lazy static that intentionally leaks.
I've been running my program for 3 hours now with Valgrind. I don't know why, but it's really slow, and I still haven't encountered a segfault.
Here are my logs, I don't know why but this time the error occurs at a different step :
cargo run --release
    Finished `release` profile [optimized] target(s) in 0.12s
     Running `target/release/crawler`
Scraping Le Monde
Scraping done
Scraping pages
Segmentation fault (core dumped)

I think that it isn't impossible that another crate cause the segfault but according to my logs sometimes it's caused by .scrape(), others Html::parse_document (not this one since a cargo update).
So I will start to investigate my PC.
Morever if it's caused by scraper it's realy strange because when I run it with the html page which has been run just before the segfault the segfault doesn't occur again.

I've been running my program for 3 hours now with Valgrind. I don't know why, but it's really slow, and I still haven't encountered a segfault.

So I started it again without valgrind in release and this time again it's caused by the .scrape() method. But it's strange, in release the segfault are realy more frequents.

So I commented all the code consering meilisearch  and scraper . The segfault occurs again.
Here are a part of the logs :
Getting page:
https://www.lemonde.fr/archives-du-monde/
Parsing page
Page done
Getting page:
https://www.lemonde.fr/sport/jo-paralympiques-2024/resultats/
Parsing page
Page done
Getting page:
https://www.lemonde.fr/crise-ukrainienne/
Parsing page
Page done
Getting page:
https://www.lemonde.fr/series-d-ete/article/2024/08/28/trump-fictions-fast-and-furious-pied-au-plancher_6297338_3451060.html
Segmentation fault (core dumped)

And here the related code :
       let mut website = Website::new(paper.get_url().as_str());
        website.with_limit(10_000);
        println!("Scraping {}", paper.get_title());
        website.scrape().await;
        println!("Scraping done");
        //let mut papers = Vec::new();
        if let Some(pages) = website.get_pages() {
            println!("Scraping pages");
            for page in pages.as_ref() {
                println!("Getting page:");
                println!("{}", page.get_url());
                let html = page.get_html();
                println!("Parsing page");
            }
          println!("Page done");
   }

In the meantime you can switch to subscriptions and process each one  instead of waiting and holding all the data in memory. The memory for the hashmap should release on drop.

The issue is in debug builds from the UTF encoding only in non release builds:
This is the code inside the Rust default String::from_utf8_lossy
debug_assert_eq!(valid.len(), v.len());

This is now handled automatically 2.2.0 so that you can get the locales encoded correctly.

I'm sorry but I still have the segfault, in release and debug.
Here are the logs but it can happen elsewhere.
On .scrape()
...
[2024-08-29T10:42:47Z INFO  spider::utils] fetch - https://www.lemonde.fr/international/article/2023/09/08/hongkong-connait-un-niveau-record-de-precipitations-qui-entrainent-des-inondations_6188376_3210.html
[2024-08-29T10:42:47Z INFO  spider::utils] fetch - https://www.lemonde.fr/planete/article/2024/06/20/paris-2024-l-objectif-climatique-des-jeux-ne-sera-pas-tenu-en-raison-des-deplacements-en-avion-selon-un-rapport-independant_6241833_3244.html
[2024-08-29T10:42:47Z INFO  spider::utils] fetch - https://www.lemonde.fr/politique/article/2024/06/21/pouvoir-d-achat-retraites-croissance-comment-le-nouveau-front-populaire-a-compose-son-programme-pour-les-legislatives_6241927_823448.html
[2024-08-29T10:42:47Z INFO  spider::utils] fetch - https://www.lemonde.fr/portraits-de-famille/
Segmentation fault (core dumped)

On .scrape()
...
[2024-08-29T10:45:13Z INFO  spider::utils] fetch - https://www.lemonde.fr/resultats-legislatives-2024/tressin-59602/
[2024-08-29T10:45:13Z INFO  spider::utils] fetch - https://www.lemonde.fr/resultats-legislatives-2024/hoerdt-67205/
[2024-08-29T10:45:13Z INFO  spider::utils] fetch - https://www.lemonde.fr/en/international/article/2024/05/18/in-bulgaria-revelations-about-a-mysterious-air-disaster_6671797_4.html
double free or corruption (fasttop)
Aborted (core dumped)

on the get_url()
...
[2024-08-29T10:45:55Z INFO  spider::utils] fetch - https://www.lemonde.fr/sport/article/2024/08/07/athletisme-aux-jo-2024-gabriel-tual-dans-le-gotha-mondial-du-800-m_6272133_3242.html
[2024-08-29T10:45:55Z INFO  spider::utils] fetch - https://www.lemonde.fr/en/culture/article/2024/03/20/inside-zola-s-home-where-literature-and-pleasure-coexisted_6636181_30.html
[2024-08-29T10:45:55Z INFO  spider::utils] fetch - https://www.lemonde.fr/en/culture/article/2024/08/23/in-emilia-perez-jacques-audiard-tells-the-story-of-a-transgender-kingpin-in-the-world-of-mexican-cartels_6720692_30.html
Scraping done
Scraping pages
Getting page:
https://www.lemonde.fr/
double free or corruption (fasttop)
double free or corruption (fasttop)
double free or corruption (fasttop)
```

It's strange because it's not always at the same step and same memory issue.
It doesn't happen on my mac.

Everything is caused by openssl, I'm trying to disable it


correct the blog publish date

@animeshsingh Should this be PMML vis ML Server ?  The V2 inference protocol pushes a standard and easy-to-use high performance REST/gRPC API across multiple model servers, such as Triton and MLServer, to increase the portability of the model ensuring the client/server can operate seamlessly.


Satisfy tests in SQL analysis showing a confidential column propagating across unary and binary operations.

This builds on #352 , but further requires that we can propagate confidentiality tags across a unary and binary operation. We can model any binary operation as a merge (#350); a unary operation can simply be a merge with both inputs being the single operand.

This is done.


Typo fix

The notebook had minor typos namely "probably" was spelled as "provably", fixed that.

@adityavenkatesh97 thanks for the contribution!


benchmark codes could not compile in virtualbox since AVX2 is defined but not FMA.

VirtualBox guest system: Ubuntu18.04
It complaints that FMA instructions could not be found. I checked the compiler flags, AVX2, AVX are defined but not FMA.

Processors supporting AVX2 are supposed to support FMA instructions too, so VirtualBox might provide different headers that we don't include. Can you post the error log please?

Yes, you're right, it's from VirtualBox side. But FYI, here are error messages:
In file included from /usr/lib/gcc/x86_64-linux-gnu/7/include/immintrin.h:85:0,
                 from /usr/lib/gcc/x86_64-linux-gnu/7/include/x86intrin.h:48,
                 from ~/lib/xsimd/include/xsimd/types/../config/xsimd_include.hpp:17,
                 from ~/lib/xsimd/include/xsimd/types/xsimd_types_include.hpp:12,
                 from ~/lib/xsimd/include/xsimd/types/xsimd_traits.hpp:14,
                 from ~/lib/xsimd/include/xsimd/xsimd.hpp:14,
                 from ~/tests/UseXSIMD.cpp:9:
/usr/lib/gcc/x86_64-linux-gnu/7/include/fmaintrin.h: In static member function ‘static xsimd::detail::batch_kernel<double, 2>::batch_type xsimd::detail::batch_kernel<double, 2>::fma(const batch_type&, const batch_type&, const batch_type&)’:
/usr/lib/gcc/x86_64-linux-gnu/7/include/fmaintrin.h:39:1: error: inlining failed in call to always_inline ‘__m128d _mm_fmadd_pd(__m128d, __m128d, __m128d)’: target specific option mismatch
 _mm_fmadd_pd (__m128d __A, __m128d __B, __m128d __C)
 ^~~~~~~~~~~~

Feel free to close this issue.


CalendarDay.from(int year, int month, int day) issue in month

CalendarDay day = CalendarDay.from(2016, 9, 29);
I was expecting that it will result into September 29, 2016.
but why is that it results to October 29, 2016.

duplicate with #459, the index of Month of java.util.Calendar starts from 0
so when you code
CalendarDay.from(2016, 9, 29);

it actually means
CalendarDay.from(2016, Calendar.OCTOBER, 14);

Duplicate of https://github.com/prolificinteractive/material-calendarview/issues/459.


udpate bridge doc to use correct glauth datastore

@davitol this should solve your https://github.com/owncloud/oauth2/issues/262#issuecomment-624466154
In the logs of glauth you should see what datastore is used:
2020-05-06T17:19:01+02:00 INF Using backend datastore=owncloud name=glauth service=glauth verbosity=3

@davitol this should solve your owncloud/oauth2#262 (comment)

Indeed 👍


Batch composition for ReadItem

Batch composition for ReadItem

Please add more details - batch supports ReadItem with the item returned deserialized to the type the user wants via batchResponse.GetOperationResultAtIndex(index).Resource


add reducers for lazy loaded modules

Is it possible to add reducers at runtime (e.g. for lazy loading)?

@maku seems more like a pure redux question :)
Does this help? http://stackoverflow.com/questions/32968016/how-to-dynamically-load-reducers-for-code-splitting-in-a-redux-application

You are right, thank you


Removing a few more non-trivial struct memsets, part 3.

The remaining test failures are unrelated. Merging.


The rank column from fts5 extension is not of integer type

I wrote the following query:
SELECT * FROM table_name LEFT JOIN (SELECT rowid AS search_rowid, rank AS search_rank FROM table_name_search WHERE table_name_search MATCH ?) ON table_name.id = search_rowid ORDER BY search_rank DESC

where table_name_search is an fts5 table.
I started getting FormatException: Invalid radix-10 number, followed by numbers like -0.0123, on any attempts of getting data from that query. Replacing searchRank: row.readInt('search_rank'), with searchRank: 0, in the generated code fixed the exceptions, and since I don't really care about that rank for any reason other than sorting I can move on, but I think this needs to be fixed. I guess the problem is here:
https://github.com/simolus3/moor/blob/c7e7683edecdf3dff4f19422cc019b6e9fdc691f/sqlparser/lib/src/engine/module/fts5.dart#L167
but I don't actually know.
pubspec.lock:
  moor:
    dependency: "direct main"
    description:
      name: moor
      url: "https://pub.dartlang.org"
    source: hosted
    version: "3.4.0"
  moor_generator:
    dependency: "direct dev"
    description:
      name: moor_generator
      url: "https://pub.dartlang.org"
    source: hosted
    version: "3.4.1"
  sqlite3:
    dependency: transitive
    description:
      name: sqlite3
      url: "https://pub.dartlang.org"
    source: hosted
    version: "0.1.8"
  sqlite3_flutter_libs:
    dependency: "direct main"
    description:
      name: sqlite3_flutter_libs
      url: "https://pub.dartlang.org"
    source: hosted
    version: "0.3.0"
  sqlparser:
    dependency: transitive
    description:
      name: sqlparser
      url: "https://pub.dartlang.org"
    source: hosted
    version: "0.11.0"

If you're not interested in he rank, couldn't you just use this?
SELECT table_name.* FROM table_name LEFT JOIN (SELECT rowid AS search_rowid, rank AS search_rank FROM table_name_search WHERE table_name_search MATCH ?) ON table_name.id = search_rowid ORDER BY search_rank DESC

But I agree that this needs to be fixed, thanks for the report!

The problem should be fixed now. Until that is released, you can apply the workaround I suggested. Let me know if you run into more problems!


Fix: Replace CRLF to LF from revision.template

Godot version: 4.0 master
OS/device including version: Ubuntu 16.04 (i tried in two different machines with Ubuntu 16.04)
Issue description: ./thirdparty/glslang/glslang/Include/revision.template has CRLF for new lines and makes git modify it automatically, generating unwanted changes

I search the entire project with a script (searching for 0x0d0a), and no other file has CLRF.
Steps to reproduce: Download the repository on Ubuntu 16.04 with Git 2.7.4 without setting "git config core.autocrlf input" and simple type "git diff"

Merged

A tip for future PRs :) https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords


Import trace for requested module:(useState)

Describe the bug
Import trace for requested module:
<EMAIL_ADDRESS>./src/app/(site)/page.tsx

_ModuleDependencyError: export 'useState' (imported as 'React') was not found in 'react' (possible exports: Children, Fragment, Profiler, StrictMode, Suspense, _SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, cache, cloneElement, createElement, createRef, createServerContext, forwardRef, isValidElement, lazy, memo, startTransition, use, useCallback, useContext, useDebugValue, useId, useMemo, version)
Recently i was working with Nextjs 13.1 project and installed React Table but i can't fix this error , It keeps saying Import Trace not found for useState, i have checked the tanstack folder in node modules and i couldn't find the export there also
Your minimal, reproducible example
No link
Steps to reproduce

just install the package in Nextjs 13.1 and try to create a Simple Data table ,this error will popUP

Expected behavior
Table should be rendered but instead getting this error
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
Linux
react-table version
8.7.6
TypeScript version
4.9.4
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

I have a slightly different error message, but it looks like the same issue.
Im using next 13.4.2 and react-table 8.9.1

Having same problem with:
"next": "^13.2.3",
"@tanstack/react-table": "^8.7.9",
Here is the error:

It's worth noting that I'm using this exact same version of the table with Next "12.0.7" and not having this problem.
Which makes me wonder if it has something to do with either the new "app" directory (which I'm using).

This just has to do with trying to use useReactTable as a server component, which is obviously not supported.


2.0.8 beta 2 Fabric 1.20.1 incompatibility with "First Person Model" mod

Cannot see first person body (or even arms) when using the First-person Model mod. https://modrinth.com/mod/first-person-model, from what I understand this mod uses your third person model while you're in first person view. Thanks for fixing the mouse sensitivity issue btw

Same reason with #50
Solved in 490b9ca


Add a full config.ru example

The README contains some documentation for setting up a custom LDP server with Rackup, but simply points to app/lamprey for details.
A proper practical example should be added.

Closed by 2a90afab53cb


bump sirupsen/logrus v1.4.1

Full diff: https://github.com/sirupsen/logrus/compare/v1.3.0...v1.4.1
Fixes:

Remove dependency on golang.org/x/crypto
Fix wrong method calls Logger.Print and Logger.Warningln
Update Entry.Logf to not do string formatting unless the log level is enabled
Fix infinite recursion on unknown Level.String()
Fix race condition in getCaller
Fix Entry.WithContext method to return a copy of the initial entry

New:

Add DeferExitHandler, similar to RegisterExitHandler but prepending the handler to the list of handlers (semantically like defer)
Add CallerPrettyfier to JSONFormatter and TextFormatter
Add Entry.WithContext() and Entry.Context, to set a context on entries to be used e.g. in hooks
Enhance TextFormatter to not print caller information when they are empty

LGTM
Looks like some k8s stuff is still using that terminal check from golang.org/x/crypto

Looks like some k8s stuff is still using that terminal check from golang.org/x/crypto

Yes, I noticed it didn't get removed here (in moby it was removed). Possibly something to check if they really needed it as well. Just thought it was good to not require a crypto package in a logger 😅

Codecov Report

Merging #3171 into master will decrease coverage by 4.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3171      +/-   ##
==========================================
- Coverage   49.21%   45.14%   -4.08%
==========================================
  Files         100      111      +11
  Lines        9423    11971    +2548
==========================================
+ Hits         4638     5404     +766
- Misses       3960     5733    +1773
- Partials      825      834       +9

Flag
Coverage Δ

#linux
49.21% <ø> (ø)
:arrow_up:

#windows
40.47% <ø> (?)

Impacted Files
Coverage Δ

snapshots/native/native.go
43.04% <0%> (-9.99%)
:arrow_down:

metadata/snapshot.go
45.8% <0%> (-8.96%)
:arrow_down:

archive/tar.go
43.79% <0%> (-7.07%)
:arrow_down:

metadata/containers.go
47.97% <0%> (-6.62%)
:arrow_down:

content/local/writer.go
57.84% <0%> (-6.36%)
:arrow_down:

content/local/store.go
48.51% <0%> (-5.03%)
:arrow_down:

metadata/images.go
57.57% <0%> (-4.99%)
:arrow_down:

archive/tar_opts.go
28.57% <0%> (-4.77%)
:arrow_down:

archive/compression/compression.go
58.69% <0%> (-4.7%)
:arrow_down:

metadata/buckets.go
56.33% <0%> (-4.6%)
:arrow_down:

... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9977b5...7c1365b. Read the comment docs.


Convert to rust NIF

This changes all the math code from erlang to a rust based NIF.
NOTE: Also removes the miles conversion (we have never used it).

@vihu if we ever find the time, let's create a template rust-nif module project. We waste so much time every time we do this with little things like forgetting the .cargo/config.toml


config/v1: add disable all option to operatorhub API

Add an option disableAllDefaultSources that allows a user to disable all default hub sources
Revert omitempty removal from Status json tag
Add json tag to embedded HubSource to satisfy openAPIValidation generation
Ran make generate-with-container

/cc @smarterclayton @derekwaynecarr @jwforres @shawn-hurley

@shawn-hurley I have made the change you requested. Please take a look.

minor doc update requested.
I'd like to see the tradeoff with using a * key in sources explained in the description, but I this looks fine if it's the preference.
@jwforres

@deads2k I have made the changes you requested. Please take a look.

/lgtm

/approve
/hold
hold for @jwforres if she wants.

/hold cancel


Designs: Facility-specific confirmation email

Description:
This ticket is to create any relevant designs for facility specific messaging on DUP. Web confirmation page will require moving some components around on the page as well as adding in icons, text and links to convey message.
Acceptance Criteria:

[ ] Confirmation email designs for facility specific messaging are in figma and linked here

Dependencies

Blocked by #343

Relevant documentation as reference

teams chat with more info: https://teams.microsoft.com/l/message/19:07e0829d25914edc840a9e0f6015ffd3@thread.tacv2/1713300125334?tenantId=6fdb5200-3d0d-4a8a-b036-d3685e359adc&groupId=cb2c4bec-527d-4097-80b2-6e40e98d36bf&parentMessageId=1713300125334&teamName=Parks %26 Recreation Transformation (Open X-Gov)&channelName=[Product] Day Use Pass&createdTime=1713300125334

Definition of Ready

[ ] Acceptance criteria are included
[ ] Wireframes are included (if applicable)
[ ] Design / Solution is accepted by Product Owner (if applicable)
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

Definition of Done

In progress:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] UI meets accessibility requirements
[ ] Unit tests are written
[ ] Work is traceable in GitHub
[ ] PR linked to ticket number
[ ] If needed/required - Dev adds flag/label to highlight any migration steps necessary prior to PROD deployment

Code review:

[ ] Code is peer reviewed and has passed CI/CD tests

QA:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] Code is potentially shippable to the production environment
[ ] Functional features have been tested and passed by QA
[ ] UI components tested by designer
[ ] Code is deployed to PROD when moved to 'done' column (unless requested otherwise by PO)

PO Review:

[ ] Acceptance criteria are tested (Functionality meets the acceptance criteria defined in the ticket)
[ ] Reviewed and approved by Product Owner

Notes:

Refinement notes:
Want to be able to provide facility-specific confirmation messaging after someone books a facility. they would see specific information in their email that shares info/heads-up info about where they are going. eg: safety, make sure you know before you go, etc.
Content is being drafted.
Aim is to iron this out prior to the following sprint for implementation.
Depends on capacity of Nicole since we are doing a lot for backcountry etc.

Notes from refinement May 28, 2024:

should this be split into two design tickets: success confirmation page and email confirmation (@meyerdarcie will split into 2)

info/text will be the same but two separate locations for updates

@MarshallHenson is working on content that can be added to designs

content is located here

Refinement notes:

we'll break out these tickets (design/implementation) further async this week - and Darcie to meet with Nicole/Marshall to clarify some details. Eg: split tickets by park.

@MarshallHenson to re-draft content for the email templates in word doc:
https://bcgov.sharepoint.com/:w:/r/teams/031072/Shared Documents/[Product] Parking Services/DUP Reso Site Content/Day Use Pass Confirmation 2022 Email Update.docx?d=w04e16b37aa0247f19ee6970ed3a9d29b&csf=1&web=1&e=TkMQf7
FYI @ndelraye


Move export_models to serialization

Change Summary

renames export_models.md to serialization.md
updates all links
adds a note about use of "serialize" and "dump"

Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Please review


Allow path overrides in test crates

Allows to change the (relative) path to different files needed by tests through environment variables.

+1+1 = +1 reached, merging.


Support node v6

Supporting node v6 requires a couple different PRs to be merged and this issue tracks the list of what needs to be done. So far, the PRs that are needed are:
PR #1033
PR #1074
PR #1073
PR #1072

@assaf My fork of zombie with v6 support has been used for a while now and I haven't heard of any issues with it. Would you mind merging the fixes into master and releasing a new version so that others can get v6 support?
If you don't mind sharing access to the project, I'm happy to do my part in helping maintain zombie. I could merge and release versions as needed.

Thanks. Going to add you as collaborator on Github and npm.

Thank you so much! I'll merge the branch and clean up some of the PRs.

I've merged the changes, and published a the version v4.3.0 with node v6 support.


Opens orders in resolved markets cancellation fails

Note the market title is undefined
And going through to the market shows it's awaiting finalisation

Still seeing these issues but instead of failing it goes to the confirmation screen but doesn't disappear even when navigating away and back to my account.
Market title is still undefined


Vue Quill is logging messages in the console

Version
"@vueup/vue-quill": "^1.0.0",
Describe the bug
Messages are being logged in the browser console by VueQuill.

To Reproduce
Steps to reproduce the behavior:

Insert  component in a template of a vue signle file component.
When the respective component is rendered the message appears in the console.

Expected behavior
No messages should be logged in the console.
Browser (please complete the following information):

Chrome
Version 107.0.5304.88 (Official Build) (64-bit)

It doesn't for me, you may just have activated the debug module (or one of your added modules did) which is globaly activated https://quilljs.com/docs/api/#debug

Hello,
It does the same for me, I am using in a nuxt app ... is there a solution ?


esptool.exe  error: argument --chip/-c: invalid choice: 'p'

I just tried to flash my d1 mini as described in the wiki.
When running the command as described:
esptool -cp COM6 -cd nodemcu -cb 921600 -cf ino.bin -ca 0x200000 -cf fs.bin
I get the following error:
usage: esptool [-h] [--chip {auto,esp8266,esp32,esp32s2,esp32s3beta2,esp32s3,esp32c3,esp32c6beta,esp32h2beta1,esp32h2beta2,esp32c2,esp32c6}] [--port PORT] [--baud BAUD] [--before {default_reset,usb_reset,no_reset,no_reset_no_sync}]
               [--after {hard_reset,soft_reset,no_reset,no_reset_stub}] [--no-stub] [--trace] [--override-vddsdio [{1.8V,1.9V,OFF}]] [--connect-attempts CONNECT_ATTEMPTS]
               {load_ram,dump_mem,read_mem,write_mem,write_flash,run,image_info,make_image,elf2image,read_mac,chip_id,flash_id,read_flash_status,write_flash_status,read_flash,verify_flash,erase_flash,erase_region,merge_bin,get_security_info,version}
               ...
esptool: error: argument --chip/-c: invalid choice: 'p' (choose from 'auto', 'esp8266', 'esp32', 'esp32s2', 'esp32s3beta2', 'esp32s3', 'esp32c3', 'esp32c6beta', 'esp32h2beta1', 'esp32h2beta2', 'esp32c2', 'esp32c6')

I'm using the latest version of esptool (4.3)

how's going there?
any progress?
Thanks

@summerfind the wiki has been updated to fix some issues with the latest ESP tool.
Just follow the instructions here:
https://github.com/rvdbreemen/OTGW-firmware/wiki/How-to-install-firmware-on-your-ESP

@rvdbreemen Any particular reason the wiki still suggests to use a tool that is not maintained any more since 2018?
It seems a better solution to move to the official ESP tools and get that supported.

@0crap nothing wrong with a working tool, even if it's old ;-)
But the official tools will not flash 0.9.5 bin's for some reason. I have not tried to get it to work with esptool.py.
The next release will be flashable with the official ESP tools once more (already verified).


Delegate schema loading and validation to datapackage-validate-py

At first I encapsulated the validation inside the Schema class, but then realized that I should've used the datapackage-validate-py package. When realizing that, I've done a few small changes to use that package (i.e. changing the Schema.validate() to it). It worked, but after the changes done on https://github.com/dataprotocols/schemas/pull/33, it won't anymore. It's not enough to simply pass the Schema dict to datapackage-validate-py, but it also needs to know the registry's base path (if it exists), so it can resolve the schema's relative paths.
In the end, the Schema class should be moved to datapackage-validate-py.

Done :+1:


sgx-tools/dist/rpm: fix a typo

Signed-off-by: Yilin Li<EMAIL_ADDRESS>

This pr is used to test and fix the current cicd, so please don't merged it before fix all cicd error. @jiazhang0


first scroll event ignored after application was inactive

VSCode Version: <IP_ADDRESS>-insider
OS Version: Arch Linux

Steps to Reproduce:

switch to another application
switch back to vscode
scroll

Does this issue occur when all extensions are disabled?: Yes

Can you please provide a screen recording?

Can you please provide a screen recording?

you won’t see me scrolling, will you?

you won’t see me scrolling, will you?

there is actually no fancy application switching necessary
i just opened code-insiders --disable-extensions
selected Help → Release notes and tried to scroll: the first event gets eaten

there is actually no fancy application switching necessary
i just opened code-insiders --disable-extensions
selected Help → Release notes and tried to scroll: the first event gets eaten

i scrolled twice here, idk what you want to see

i scrolled twice here, idk what you want to see

What window manager are you using? Can you reproduce in any other application?

What window manager are you using? Can you reproduce in any other application?

GNOME/Mutter, happens in X11 as well as Wayland
now that you say it it seems to happen in slack as well, so probably an electron bug

GNOME/Mutter, happens in X11 as well as Wayland
now that you say it it seems to happen in slack as well, so probably an electron bug

ok, so it seems to be more widespread
it works fine in Firefox as well as e.g. ksysguard, but doesn’t in gnome-system-monitor, nautilus or sublime text
i guess i have to dig more and create an issue somewhere else

ok, so it seems to be more widespread
it works fine in Firefox as well as e.g. ksysguard, but doesn’t in gnome-system-monitor, nautilus or sublime text
i guess i have to dig more and create an issue somewhere else


SVG renderer does not always include attributes

When rendering an SVG using the chassis lib like so:
<svg src="path/to/svg.svg" class="icon" />
the "class" attribute is not included in the final output in some cases. For example, see Fenix filebrowser template.

This was fixed when NGN.DOM.guarantee was added, but I forgot to associate the commit with this issue. A rather extensive RegExp was created to support this, along with a basic unit test, and I can no longer recreate the issue. I'm closing since it appears to be fixed.
@gbdrummer - Reopen this if you still encounter this issue with NGN v1.1.0+


[0.9.2] No 'Access-Control-Allow-Origin' header is present on the requested resource

In the Admin page I get a
XMLHttpRequest cannot load http://localhost:8086/query?q=SHOW+DATABASES&db=. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8083' is therefore not allowed access. The response had HTTP status code 405.

both with and without auth enabled.
@wolfkiss0929 @wuhongyuan

@mjdesa I believe https://github.com/influxdb/influxdb/pull/3474 fixes this issue.

@mjdesa can you attempt a repro with a nightly to see if the PR fixed the problem?

@beckettsean yup its fixed.


signature does not works for String type

Bug Description
Default string value specified by signature (example: #[pyo3(signature=(num, text = ""))]) works for &str but does not work for String type.
// works fine
#[pyfunction]
#[pyo3(signature=(num, text = ""))]
fn some_func(num: i32, text: &str, opt: Option<i32>) -> PyResult<()> {
    todo!()
}

// fails
#[pyfunction]
#[pyo3(signature=(num, text = ""))]
fn some_func2(num: i32, text: String, opt: Option<i32>) -> PyResult<()> {
    todo!()
}

Screenshot of VS Code:

Is this an intended behavior?
This may be a problem with async since async fn  requires Send + 'static for parameters.
Steps to Reproduce
As shown in the description above.
 Did you use a virtualenv?
I installed Python via winget. I use venv.
Additional Info
No response

This is the intended behavior. The signature attribute just takes Rust expressions which should evaluate to the given type. For your String example you could use
#[pyfunction]
#[pyo3(signature=(num, text = String::new(), opt = None))]
fn some_func2(num: i32, text: String, opt: Option<i32>) -> PyResult<()> {
    todo!()
}

or
#[pyfunction]
#[pyo3(signature=(num, text = String::from("Some other default string."), opt = None))]
fn some_func2(num: i32, text: String, opt: Option<i32>) -> PyResult<()> {
    todo!()
}

@Icxolu
Thank you! I close this because my question was resolved.


Add external events interface

Allow registration of parse/ingest triggers which fire off an external notification (i.e. URL or possibly AWS SMS/SQS) with the new file information. This would allow external systems to use notifications instead of polling or a custom job which just does the notification.

Closing all issues > 2 years old.


How to install and run?

Is there any tutorial on how to install schemalex, I did make build but it gave an error
$ make build
echo " * Building schemalint for darwin/amd64..."
 * Building schemalint for darwin/amd64...
go build -ldflags "-X main.version=v0.0.8" -o /Users/mukesh/Projects/schemalex/artifacts/v0.0.8/schemalex_darwin_amd64/schemalint cmd/schemalint/schemalint.go
 * Building schemalex for darwin/amd64...
cmd/schemalex/schemalex.go:13:2: use of internal package not allowed
make: *** [/Users/mukesh/Projects/schemalex/artifacts/v0.0.8/schemalex_darwin_amd64/schemalex] Error 1

please use binary release. you can download from here https://github.com/schemalex/schemalex/releases


Support for hourly interval data points

This is a great for providing access to BC Hydro's data, since they do not have an API you can access directly.
The addition of the hourly interval data would be handy for some use cases.

I agree, hourly data would be a fantastic feature. I just tested the consumption-data.html chart endpoint - it doesn't expose this in the website, but there is a header for Granularity=daily and changing it to Granularity=hourly actually works!
<Point type="SMI" quality="ACTUAL" dateTime="2020-08-07T00:00:01-07:00" endTime="2020-08-07T01:00:00-07:00" value=".78" cost="0.08"/>
<Point type="SMI" quality="ACTUAL" dateTime="2020-08-07T01:00:01-07:00" endTime="2020-08-07T02:00:00-07:00" value=".48" cost="0.05"/>
<Point type="SMI" quality="ACTUAL" dateTime="2020-08-07T02:00:01-07:00" endTime="2020-08-07T03:00:00-07:00" value=".47" cost="0.05"/>
<Point type="SMI" quality="ACTUAL" dateTime="2020-08-07T03:00:01-07:00" endTime="2020-08-07T04:00:00-07:00" value=".48" cost="0.05"/>

I've been trying to rewrite the code to login to FortisBC but I'm not able to get past the login page. It looks to be doing things a bit differently in that department so might not be possible.

@planetawylie - FortisBC integration is an interesting idea. I don't have an account with them, and given the name of this package it might be out of scope for this repo. Nevertheless I'll keep that in mind, maybe we could start a new repo and analyze the other site.
@appletalk - @Nebual has just solved a handful of problems for us, and he added support for hourly granularity in https://github.com/emcniece/bchydro/pull/2 ! I'll release v0.7 shortly. Unfortunately it seems that while we can obtain hourly granularity, it only comes in bulk and refreshes every 24h... so we can't get the real-time-ish value of the last hour of electricity usage.
To see hourly granularity you can now do the following:
async def main():
    a = BCHydroApi(os.environ.get("BCH_USER"), os.environ.get("BCH_PASS"))
    await a.authenticate()
    usage = await a.get_usage(hourly=True)

I'll mark this as closed as the closest possible solution to the feature request has been met. It does make me sad that we can't get closer to real-time data, but I plan to chase down the BCHydro dev team to see if there are any other options.

@emcniece I've been playing around with this, did you ever get any traction about closer to realtime data? I was playing with the export-consumption.html endpoint as well but it seems the same.

Unfortunately not. The data returned from the API is only for the previous day, regardless of the granularity. It appears we can't get anything close to real-time.


unit-1/sprint-1

This is my first submission for the challenge. It's almost at spec. I'd need another 30 minutes.

Oops! Wrong repo! Sorry!


Bug centerMode in version 1.8.1

When the first slide element is active, the slick-center class is set for the incorrect cloned slide element. That is, if there are 5 elements in the slide and the first element of the slide is active, the slick-center class is set for the clone of the second element of the slide, not for the first element. In version 1.6.0, everything works fine
====================================================================
[  https://codepen.io/Oleksandr07/pen/GRWrggv  ]
https://codepen.io/Oleksandr07/pen/GRWrggv
https://i.imgur.com/e6NcraB.png
====================================================================
What is the expected behaviour?
The slick-center class must be specified for the clone of the first element of the slide
====================================================================
More Details

Which browsers/versions does it happen on?
The problem was found in the Chrome browser, others have not been tested
Which jQuery/Slick version are you using?
Version JQuery 3.6.0, version Slick 1.8.1
Did this work before?
Works well in the version Slick 1.6.0

Hi,
I think the exact same problem is showing in my application:
I have a combined carousel and a slider where I use the carousel 'asnavfor' the other in a Drupal 8 site. The carousel is centred and infinitive. There are 12 slides and by going from 12 (index 11) to 1 (index 0), the first slide is not found by your script. So the controlled slider pauzes 1 slide and then catches up from the second one up. You can see the problem happening quickly by using the cursor keys. The same problem happens by going backwards. Then it is again the first slide after the loop around that doesn't show... but then after slide 1, slide 11 is not shown...
Site in development: http://dev.alfavisionmuseumservices.eu/ it's the second slider on the beige background...
Any suggestion would be more than welcome!


Are CTS relationship endpoints being looked up in correct location?

It appears the TestSupportedRelationshipLifecycle looks up the endpoint EntityDef's from the types found in the repository itself: should it be looking up against these, or against the known open metadata types?
EntityDef end1Type = entityDefs.get(relationshipDef.getEndDef1().getEntityType().getName());
EntityDetail end1 = this.addEntityToRepository(workPad.getLocalServerUserId(), metadataCollection, end1Type);
EntityDef end2Type = entityDefs.get(relationshipDef.getEndDef2().getEntityType().getName());
EntityDetail end2 = this.addEntityToRepository(workPad.getLocalServerUserId(), metadataCollection, end2Type);

I ask as in a repository that only implements the "leaf" nodes of the inheritance hierarchy (like IGC which implements things like Database, Person, etc but not their supertypes), this results in NPE's for relationships whose endpoint definitions refer to more abstract types (like Asset, DataSet or ActorProfile) -- that is, those EntityDefs are not implemented in the repository, just their subtypes (including all the properties of the supertype).
Hence I wonder if these lookups should be against the open metadata types archive rather than the set of definitions available in the repository itself?
(Which I believe would also ensure that if the repository has "overridden" these definitions for any reason, that we are still testing they adhere to the open metadata types themselves rather than a repository's own type implementation?)

I think there may be two aspects to this.
One is that the test case should only ask the repository connector to instantiate ends using entity types that the repository supports. The repository can legitimately verify that it supports a relationship type that has end definitions specifying types that are more abstract than any entity types supported by the repository - and when the CTS needs to instantiate a relationship of that type it (the CTS) should hunt for a sub-type that is supported by the repository.
The other is that, as you say, the CTS should be getting the type definition from the active set, not from what was returned by the repository connector.

Resolved by #2093


Add DigitalOcean as a provider

Would also be great to have DigitalOcean onboard :)

Would also be great to have DigitalOcean onboard :)

DigitalOcean does not currently allow custom reject rules only allow rules


Add 1.38 version of tutorials

This picks up the changes to the 2 collaboration tutorials.
No issue logged

@sfitts, can you merge this and the other 2 PRs for 1.38?
then I'll get a UI branch up for changing the UI to use the new 1.38 directories


Test automated deployment of registry-api and provenance on AWS from jenkins

💡 Description

Using the existing terraform scripts in repository:

registry-api https://github.com/NASA-PDS/registry-api
registry-sweepers https://github.com/NASA-PDS/registry-sweepers (to be renamed)

We first whant to experiment with github actions

jenkins is not something we want to use anymore, w don't want to be spread thin between multiple technologies and regarding CICD we are going for github actions.


[incubator/jaeger] Fix render error when ingress enabled

There is a bug when ingress is enabled and hosts are set.
helm install incubator/jaeger \
  --set query.ingress.enabled=true \
  --set query.ingress.hosts={example.com}

The error looks like
Error: render error in "jaeger/templates/query-ing.yaml":
  template: jaeger/templates/_helpers.tpl:44:40:
  executing "jaeger.query.name" at <include "jaeger.full...>:
  error calling include:
    template: jaeger/templates/_helpers.tpl:27:14:
    executing "jaeger.fullname" at <.Values.fullnameOver...>:
    can't evaluate field Values in type string

Hotrod ingress is not affected.

/ok-to-test

cc @dvonthenen @mikelorant @pavelnikolov

/lgtm


Using lib azure-eventhubs-3.2.2 with MSI in a Java App Service.

Using azure-eventhubs-3.2.2 and customer is getting the below errors:
The call is trying to connect to this endpoint "http://<IP_ADDRESS>/metadata/instance?api-version=2020-09-01" and get connection refused.
Error during managedIdentityScenario. Exception: [Ljava.lang.StackTraceElement;@35fc6dc4
java.lang.RuntimeException: java.net.ConnectException: Connection refused (Connection refused)
The above setup works on a VM but not on a web app hosted on Azure App Service.
Issue is fixed when using azure-messaging-eventhubs 5.0.2.
Question is, we don't like to use the new library, is there a way to use azure-eventhubs-3.2.2 with MSI on an App Service?

@conniey could you please follow up with @TeplrGuy

@joshfree looks like the solution is to use AppServiceMSICredentials  class instead of MSICredentials
https://github.com/Azure/azure-libraries-for-java/blob/master/AUTH.md#using-msicredentials--appservicemsicredentials
Follow up question is: what is the main difference between using azure-eventhubs-3.2.2 vs using azure-messaging-eventhubs 5.0.2

@TeplrGuy

Follow up question is: what is the main difference between using azure-eventhubs-3.2.2 vs using azure-messaging-eventhubs 5.0.2

azure-messaging-eventhubs is an entirely rewritten library for Azure Event Hubs. We rewrote many of the Java libraries to follow the same set of Azure SDK principles so consumers would get a unified feel for development. Here is a quick video on motivation (https://www.youtube.com/watch?v=38RYIx7a2M4) and our guidelines https://azure.github.io/azure-sdk/java_introduction.html

@TeplrGuy Looks like you found the solution to the auth problem and @conniey has addressed your follow up question.
We will go ahead and close this issue.
Do try out the newer azure-messaging-eventhubs package and share any feedback you have.


Add version: pnpm.pnpm version 8.14.1

Pull request has been created with komac v2.0.4 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335226 2024-02-11 13:41:47.098 [CLI ] ShellExecute installer failed: 1

(Automated response - build 720.)


[FSDE-6902] Customize columns behavior update

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-193/1/. :white_check_mark:

You can check this PRs instance in https://2f8c09d9fc6d438f5bb04593a0811400fa8755a2-chi-pr.enterprise.ctl.io

Hi @evansito, how can I test this? The dynamic environment does not provide access to the Customize Columns component. Would you like demoing it to me, please? Thanks in advance.

Hi @evansito, how can I test this? The dynamic environment does not provide access to the Customize Columns component. Would you like demoing it to me, please? Thanks in advance.

Sure!


Adds more information to script will never generate a response errors

Adds a bit more information to the logs for "script will never generate a response" including a URL to upcoming docs.
This should only be merged after the docs changes here get in.

@jasnell bumping this for re-review now that the URL I added is up?


Fix deprecation warnings with latest rust nightly

from_str() -> parse()
into_string() -> to_owned()

The build failure is unrelated to my branch - doing make test on master also fails with the same errors.

@sjaensch yes I see
For easier review you can also link actual change in Rust (sure it's not necessary but will be helpful)
Thank you


Allow sorting of imports

Similar to how Eclipse's Java formatter allows sorting of imports, it'd be really nice if we could automatically sort all the imports. Even something as simple as alphabetically would be nice.

Use scala-refactoring


bad compile

$ make build
GOOS= GOARCH= go get -u github.com/prometheus/promu

building binaries
/home/chander/work/langs/golang/path/bin/promu build --prefix /home/chander/work/langs/golang/path/src/github.com/prometheus/prometheus
prometheus

github.com/prometheus/prometheus/discovery/targetgroup
discovery/targetgroup/targetgroup.go:81:5: dec.DisallowUnknownFields undefined (type *json.Decoder has no field or method DisallowUnknownFields)
!! command failed: build -o /home/chander/work/langs/golang/path/src/github.com/prometheus/prometheus/prometheus -ldflags -X github.com/prometheus/prometheus/vendor/github.com/prometheus/common/version.Version=2.4.2 -X github.com/prometheus/prometheus/vendor/github.com/prometheus/common/version.Revision=4c524007087ef50f02a396e1f4529340ee81783f -X github.com/prometheus/prometheus/vendor/github.com/prometheus/common/version.Branch=master -X github.com/prometheus/prometheus/vendor/github.com/prometheus/common/version.BuildUser=chander@chander-desktop -X github.com/prometheus/prometheus/vendor/github.com/prometheus/common/version.BuildDate=20180926-08:35:12  -extldflags '-static' -a -tags netgo github.com/prometheus/prometheus/cmd/prometheus: exit status 2
Makefile.common:102: ошибка выполнения рецепта для цели «common-build»
make: *** [common-build] Ошибка 1

To build Prometheus from the source code yourself you need to have a working Go environment with version 1.10 or greater installed.
Looks like the go version being used is not the latest. Please upgrade and try again.

Bingo! It is has already compiled.
But there is no default config file here.


Run vault operator step-down as a preStop lifecycle hook

Challenge is that the API call requires root/sudo on /sys/step-down which the pod needs to be able to make such a call.

K8S sends SIGTERM, which invokes this anyway


Example error

Hi I'm receving this error:
2021-09-02 16:00:51.015 ComponentRequestHandler: GET streamlit_bokeh_events.streamlit_bokeh_events/bootstrap.min.css.map read error
Traceback (most recent call last):
FileNotFoundError: [Errno 2] No such file or directory: 'c:\users\borg7803\anaconda3\envs\streamlit\lib\site-packages\streamlit_bokeh_events\frontend\build\bootstrap.min.css.map'

Can you give a bit more context about the error ? When are u getting the error ? A minimal reproducible example would be great.

I was keen that the example you have in your README required only a pip install streamlit-bokeh-events to get that example working. However I got the error above. Am I missing somehting?

Hi - I've been testing out the exmaples that @ash2shukla kindly prepared.
With the example called widget_with_plot.py, I receive the following error...
2021-11-14 15:51:15.222 ComponentRequestHandler: GET streamlit_bokeh_events.streamlit_bokeh_events/bootstrap.min.css.map read error
Traceback (most recent call last):
  File "/path/to/my/app/.venv/lib/python3.8/site-packages/streamlit/components/v1/components.py", line 321, in get
    with open(abspath, "rb") as file:
FileNotFoundError: [Errno 2] No such file or directory: '/path/to/my/app/.venv/lib/python3.8/site-packages/streamlit_bokeh_events/frontend/build/bootstrap.min.css.map'

Also, any charts or maps in the examples no not render, with warnings and errors in Chrome console..

I'm using a Virtual Environment on Mac for python 3.8.8. with the following installed via Pip:

streamlit              1.2.0
streamlit-bokeh-events 0.1.2
bokeh                  2.4.1

Happily to try and troubleshoot.

removed sourceMap ref, this and some other minor fixes available in 0.1.3+


Added support for multiple GitHub mount points and added schema attributes to userpass login function

Per the Vault documentation on GitHub authentication, it is possible to mount auth backends at any location. This PR parameterizes the mount point in the command
On a related sidenote, the userpass login function requires a password parameter which is not being enforced on the client side.

Updated my PR to reflect some of the CI/build changes as part of 0.6.0.
My local testing has worked really well with these changes. But I've focused mainly on the GitHub and userpass changes.

In doing a bit of experimenting, Vault mounts all auth backend paths with a prefix of /auth. So I trimmed out that static value from the optional mount_point content.
Still seems to work well in my local testing, but the CI process seem inconsistent. Fair to assume that isn't related to my changes?

@owenfarrell No, it's not your fault 😉 There are some hickups with the docker setup on travisci. Will hopefully fix it soon.

@owenfarrell Please merge latest master branch where I fixed the integration test on Travis CI 🙏

@owenfarrell Meanwhile I merged #69 where ldapLogin is also implemented with an example. Would you please be so kind and merge again with master and solve possible conflict? Then we can finally merge 😉  🙏

There weren't any conflicts, but it looks like some of the commands moved around. So it took me a couple tries to get the PR looking clean. I think its there now.

@owenfarrell Thanks 🙏

@kr1sp1n - Thank you!
Any plans on a dot release to roll this out?

@owenfarrell  Just released your changes as v0.7.1 🎉
Thanks for your contribution! 🙏


Support full path for -project/-p paramater

Fixes #2869.

Supports full path for -project
Requires tsconfig(-*).json file name for potential future tsconfig format change
Shows proper diagnostic message when tsconfig file cannot be found.

I'm not sure we need the tsconfig- base, but I'm not against it. I think if you pull changes in and make sure lint rules are passing etc, this should be good.
@mhegazy @RyanCavanaugh @vladima opinions? Can you take a quick look?

@weswigham any idea why the lint rule is freaking out?

I've got a fix ready in #5709.

@SaschaNaz can you resolve the merge conflicts?
I'm inclined to agree with @paulvanbrenk but I'd like to hear others' opinions on the matter.

@DanielRosenwasser @paulvanbrenk I'm also not completely sure we should force the name format, I can remove it if there is no good reason. Maybe there will be other options when we once make some breaking changes on the tsconfig file format..

I agree with @paulvanbrenk we do not really need this restriction. the tooling (VS, Sublime, VSCode, atom, etc..) will still look for your root/tsconfig.json just because having multiple of these does not tell you which one to use. but you can have tsconfig.dev.json or just es6.json and pass that to the --p option on the command line, and it should just work.

The restriction is now removed as everyone thinks it is not needed.

:+1:

:+1:

Looks great. I'm very excited to use this myself!

Documented for 1.8 at https://github.com/Microsoft/TypeScript-wiki/commit/e529568c442a88b53c5cfb0d92b2dcccde542b2b
Thanks @SaschaNaz!


Convert NATFIXME markers in Time to blocks

Another one for #963

Progress: |=======================..........*natalie20230814-8668-wb6c8d: /natalie/ext/tm/include/tm/string.hpp:39: TM::String::String(const char*): Assertion `str' failed.
 FAIL ruby/spec::spec/core/time/plus_spec.rb#test_0001_passes all specs (1748.55s)
        Expected #<Process::Status: pid 8667 exit 1> to be success?.
        /natalie/test/ruby/ruby_specs_test.rb:21:in `block (4 levels) in <top (required)>'

======................*natalie20230814-10508-hyxzz4: /natalie/ext/tm/include/tm/string.hpp:39: TM::String::String(const char*): Assertion `str' failed.
 FAIL ruby/spec::spec/core/time/minus_spec.rb#test_0001_passes all specs (2116.73s)
        Expected #<Process::Status: pid 10507 exit 1> to be success?.
        /natalie/test/ruby/ruby_specs_test.rb:21:in `block (4 levels) in <top (required)>'

That is an interesting error

I can run it with gdb or lldb and hopefully figure out where we are passing null into the String constructor. 👀

@seven1m  That would be most welcome, I've tried this on three different machines and I haven't been able to reproduce the issue.

I could only reproduce this inside Docker, so I added a rake task to help with that. I believe 64b4f73a6f0bf73c4dde250ae328b500a00fab11 fixes the issue.

That seems to work
TZ= bin/natalie -e 'Time.now.zone'
natalie20230815-117795-m1ng89: natalie/ext/tm/include/tm/string.hpp:39: TM::String::String(const char*): Assertion `str' failed.


Flake template creates flake.nix, example.cabal, src/Main.hs instead of flake.nix only

Isn't it supposed to only create the flake.nix?
Will throwing an error as the value for example.root resolve this?
https://github.com/srid/haskell-flake/blob/7c4af21238b3c94e5eb61daad78fec7df4eaec51/example/flake.nix#L13-L16

Some templates do create only flake.nix:

https://github.com/NixOS/templates/tree/master/python

Some create the whole project layout:

https://github.com/NixOS/templates/tree/master/c-hello

Meanwhile, the nix flake init manual says that it "create a flake in the current directory from a template".
It is not entirely clear whether there is a firm convention here ...


bull-board(v1.0.0-alpha.0) getting errors while testing the alpha, might be doing something wrong?

import {  router } from 'bull-board';

app.use('/ui', router)

trace:
 at Function.render (/Users/dev/platform/node_modules/express/lib/application.js:580:17)     at ServerResponse.render (/Users/dev/platform/node_modules/express/lib/response.js:1012:7)     at exports.entryPoint (/Users/dev/platform/node_modules/bull-board/src/routes/index.ts:8:7)     at Layer.handle [as handle_request] (/Users/dev/platform/node_modules/express/lib/router/layer.js:95:5)     at next (/Users/dev/platform/node_modules/express/lib/router/route.js:137:13)     at Route.dispatch (/Users/dev/platform/node_modules/express/lib/router/route.js:112:3)     at Layer.handle [as handle_request] (/Users/dev/platform/node_modules/express/lib/router/layer.js:95:5)     at /Users/dev/platform/node_modules/express/lib/router/index.js:281:22     at Function.process_params (/Users/dev/platform/node_modules/express/lib/router/index.js:335:12)     at next (/Users/dev/platform/node_modules/express/lib/router/index.js:275:10)

Along with a similar trace I'm getting the error message Error: Failed to lookup view "index" in views directory ...

Same error as @philefstat { Error: Failed to lookup view "index" in views directory "/Users/jamesholcomb/code/myapp/node_modules/bull-board/dist/../src/ui"

Hey folks! Thank you for testing the alpha, sorry for the bugs tho 😅
Is it still happening in the v1.0.0-alpha.1 version?

v1.0.0-alpha.0

same issues with v1.0.0-alpha.1

It is possible to use bull-board with bullmq right now? Have the same issue with alpha1. Is the stable version works with bullmq?

we are going to take a look at why is this problem happening and make another alpha version available! sorry for the delay 😄
@Deadly0 the latest stable 0.6 does not support bullmq unfortunately 👍

Error: Failed to lookup view "index" in views directory "/usr/src/app/node_modules/bull-board/dist/../src/ui" seems like something isn't getting compiled properly, hence the .../src

The problem is that the index.ejs file from /src/ui/index.ejs is not copied to the dist folder when the package was built.
Create a duplicate of this file https://github.com/vcapretz/bull-board/blob/master/src/ui/index.ejs in /dist/ui should fix the problem.

Hey folks, sorry if I take too long to review/comment in the issues 😓
btw, I just released v1.0.0-alpha.5, for what I could test it works now!
let me know if this particular bug is solved and if you find any others please start new threads 😄

closing for now, please open new issues if you find any other problems 😄


SEO Metadata

Is your feature request related to a problem? Please describe.
I know I can manually add the meta tags in the Page's  but I'd prefer to do it through the gui as data is duplicated across tags.
Describe the solution you'd like
I propose a SEO button next to HTML CSS Fields buttons in Page IDE mode which would bring up a modal with the following inputs:

Live Base URL (needed for og:url and image urls)
Title
Description
Author
Favicon (have the user upload a 512x512 pixel image and then generate the web manifest file along with the other resolutions and .ico)
Robots (multiple select of noindex, nofollow, notranslate, noarchive ... etc)
Page type (select from website, article, product etc, and also add their special fields e.g. publish_date, price etc.)
Twitter Card Type
Canonical URL (in case we use the same content in another page/website)
Image (multiple select consisting of the images already used in the page, no need to upload them again)

And generate the appropriate html tags or JSON+LD for the published site. In multi-language sites it must also include og:locale and hreflang tags.
Describe alternatives you've considered
There are a few svelte meta tag packages, but they wouldn't help much apart from replicating how they work.

You should be able to do most of this now by creating Page Fields & connecting them via the Page HTML like so:
<title>{title}</title>
<meta name="description" content={description} />
...

You should be able to do most of this now by creating Page Fields & connecting them via the Page HTML like so:
<title>{title}</title>
<meta name="description" content={description} />
...

Yeah I know but still it's 2 steps rather than 1 and even if you use the same variables you will still have 3 description tags, 3 title tags etc...
I understand Primo is (svelte) dev oriented atm and I don't know what's your goal with the project, I just mention features that can automate much of the website building process and the average Joe will just switch to another tool if Primo doesn't have them.

What do you mean by 3 description tags? That HTML only appears once in the HTLM head tag.

I understand Primo is (svelte) dev oriented atm and I don't know what's your goal with the project, I just mention features that can automate much of the website building process and the average Joe will just switch to another tool if Primo doesn't have them.

This definitely isn't for the "average Joe" at this stage, but that's a good reminder that I should write the goal of the project somewhere. Basically, we're trying to make web development as smooth as possible without removing flexibility, with the goal being that developers can build tailored [no-code] experiences for content editors.
So although this would make it easier to add SEO data to a page,

Not all of these options are relevant to every site or content editor. For instance, when I make a site for someone who isn't a marketer, the only options I'd want them to see are Title and Description. I'll probably have to explain what "SEO" means too. In that case, having an SEO button with an exhaustive list of fields would introduce more friction.
HTML, CSS, and Fields are each their own domains and unlock functionality which isn't possible in the others, but SEO would just be an implementation of Fields - it wouldn't enable new functionality, just make things a little easier for users who happen to want that functionality.
The cost to the codebase (in terms of development time and additional complexity) isn't worth the benefit.

Hopefully that's enough to show why this won't be implemented as-is.
However, I think it would be helpful to keep the conversation going to see how things could be smoothed out while holding to the project's goal, so I'm going to convert this into a discussion.


add Dependabot

https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/

I don't expect this to be able to edit our Gradle config; it's pretty custom. Would be good to use something uniform if robots are doing the updates.

@sullis Is there example output, or what it would change?  Can you link to other high profile OSS libraries already adopting so we can see the cadence and information in a typical PR?
I have read the blog post.

Example from Apple servicetalk https://github.com/apple/servicetalk/pull/1089
micronaut https://github.com/micronaut-projects/micronaut-core/pull/3548/files
twilio-java https://github.com/twilio/twilio-java/pulls

cc @sullis Does this handle indirect version numbers?  I'm assuming no, like Jesse says.

Perhaps we should switch to wildcard dependencies (+) and use a lock file instead? I would assume it could update lock files (it does for Rust and Ruby).


Consider the full path in changing PUSH to REPLACE

Fixes #166
Organizing the changelog a bit ahead of adding something for #141 to hopefully make it a bit more usable.

LGTM. Thanks for tackling that.
As for your question why I used getCurrentLocation(), I think I wanted to avoid race conditions and mimic the default browser behavior as close as possible. Right now I can't think of any realistic condition where using location instead would be a problem, so I'm good with that change.

I believe in a base history, transitions are fully synchronous, so I don't think race conditions are an issue. Let's go with this for now and patch later if needed.

@taurose I think there might be a separate related race condition when using async routes in ReactRouter.useRoutes, though - i.e. where the transition is async, so the user can e.g. change their mind and try to PUSH a separate location while the old routing state is still shown... for browser-mimicking that should get changed to a REPLACE, but we can't even handle that in history since the route state management is all downstream.

@taion Yeah that seems like a feature we lost from 0.13. Since history doesn't deal with data loading (or anything that happens after the URL changes), I'd say this should be handled by the router.

Yeah, the router can just use listenBefore.


More sensible time axis and tick labels for 2D plots

🚀 Pull Request
Description

Removed the date2num conversions from datetimes to floats in plot.py.  I'm not clear why these were there, but I assume were an ancient workaround for something.  They had been there since the initial commit to github.  Without them, the time axis ticks get labelled with datetime information instead of floats (see the updated images in the test data PR).
Pulled in the axis label change from #5484.  As discussed at #5426, we only want to label these axes as "time".
Reverted the quickplot change from #616, as [2] is a more general version of this.

Closes #5484 and closes #5426

Consult Iris pull request check list

Test data PR: https://github.com/SciTools/iris-test-data/pull/87

Note that users who specified a DateFormatter and DateLocator should not see any difference.  E.g. this plot is the same with main and with my branch:
import matplotlib.pyplot as plt
import matplotlib.dates as mdates

import iris
import iris.plot as iplt
import iris.tests.stock

cube = iris.tests.stock.realistic_4d()
cube = cube[:, 0, 0, :]

fig, _ = plt.subplots(layout="constrained")

iplt.contourf(cube)
ax = plt.gca()
ax.yaxis.set_major_locator(mdates.MinuteLocator(interval=10))
ax.yaxis.set_major_formatter(mdates.DateFormatter("%M minutes after %H"))

plt.savefig("test.png")


First test engine

We use test-driven development for creating b4bp. We need an initial test-script, which is suitable for testing initial functions of template script. It should be based on b3bp. We need

[x] Automatic or quasi-automatic test-case development
[x] Automatic or quasi-automatic test-case driven
[x] Verbose log-style output
[x] Preparing for merging future b4bp test-engine

All user story implemented.


fix: #39 - Improve constructor performance

Updated the isCID() implementation to use a (private)
intermediate method to validate CID
without relying on the error being thrown during validation.
The validateCID() method also uses this intermediate method,
and its behavior has been preserved (e.g., with regards to
throwing an error for invalid CIDs).

I removed the karma/mocha dev-dependencies. Getting the same build error as before. @diasdavid Any suggestions?

Sorry for the mixup. All CI builds pass at this point. Thanks.

Updated per feedback:
(1) Created a new cid-util.js and its corresponding test spec.
(2) Simplified the test runner so that it now takes only one CID implementation. Will need to run the test multiple times for each alternative implementation.

@diasdavid Jenkins build fails on Mac. Is there anything I can do to fix this?


No Clang archive url specified for current platform (CYGWIN)

Couldn't build cquery on Windows 10 via cygwin b/c of the above error message.
Filing issue as requested in cmake output

I'm not super familiar with cygwin. Does it use the same program binaries that a normal Windows installation uses?

As far as I know, it doesn't. Otherwise, ycmd would work on cygwin.

@mlangiu Could you test if cquery works with a system installation of Clang? I'd like to know if cquery works on cygwin at all before adding clang download support for cygwin to cmake.
Instructions for building with system clang can be found here

I did, here's the output
 $ cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=release -DCMAKE_EXPORT_COMPILE_COMMANDS=YES -DSYSTEM_CLANG=ON
-- The CXX compiler identification is GNU 7.3.0
-- Check for working CXX compiler: /usr/bin/c++.exe
-- Check for working CXX compiler: /usr/bin/c++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Using system Clang
-- The C compiler identification is GNU 7.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for pipe2
-- Looking for pipe2 - found
-- Could NOT find Clang: Found unsuitable version "5.0.1", but required is at least "6.0.0" (found _libclang_LIBRARY-NOTFOUND)
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Configuring done
CMake Error at CMakeLists.txt:17 (add_executable):
  Target "cquery" links to target "Clang::Clang" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?

-- Generating done
-- Build files have been written to: /cygdrive/c/Users/m.langiu/sciebo/IEK-10/cquery/clang_build

It looks like it's not happy about my clang version, but in the near future I probably won't  find the time to set up and compile a newer clang version, since it seems tu be quite a hustle to get it right...
Any other suggestions?

cquery should still work with older clang versions but it seems CMake can't find libclang.so. Can you verify libclang.so is available?
You can also try editing cmake/DownloadAndExtractClang.cmake to add support for downloading for cygwin. It should be sufficient to add OR ${CMAKE_SYSTEM_NAME} STREQUAL Cygwin to the if statement at the start of the file that sets the archive name required by cygwin. I have no idea if any of the official binaries released by LLVM work on Cygwin however.

cquery should still work with older clang versions

There are some deal-breaking bugs with anything lower than 6.0.0 though, e.g. #488.

but it seems CMake can't find libclang.so.

I think it did find it judging by Found unsuitable version "5.0.1".

It's followed by found _libclang_LIBRARY-NOTFOUND however. It might be a bug in FindClang.cmake. I'll need to update it to provide a clearer error.


[Idea] Schema validation

Hello!
Thanks for this simple and awesome plugin :)
It would be nice to be able to provide a json validation schema, to provide more specific errors.
You could use https://python-jsonschema.readthedocs.io/ for that.
I'd be happy to contribute, if you could point me where I should hook up and the PR has a chance to be merged :)

I think the validation part needs to be in the form were you are using the widget.

Ok, but as the whole json is considered as a single field from the form's point of view, doing so makes it impossible to show errors specific to the json key. An invalid key of value for instance.

@koleror in OpenWISP we use another widget for more complicated JSON structures which has JSON schema validation and UI generation, but we could not finish to extract it as a separate package, it's very tied to openwisp-controller. We had started to work on it but we didn't finish it: https://github.com/openwisp/django-jsonschema-widget/tree/master/django_jsonschema_widget
In this particular widget, I am not sure it's worth adding it for several reasons:

here we only intend to deal with a flat JSON structure, every member of the JSON object is a string, so the amount of JSON schema features we can use is limited, by using a different solution like the one we use in OpenWISP Controller, which is based on https://github.com/json-editor/json-editor you get the possibility to use any JSON structure you like and the UI is auto-generated, which is nice
at least for what concerns OpenWISP, we don't need JSON schema validation in this widget and I do not want to add burden to our few maintainers to maintain this feature in the coming years

So I suggest you to either use directly something like https://github.com/json-editor/json-editor or just fork this package and use a forked version of it in which you implement what you need.
There may be other django packages based on https://github.com/json-editor/json-editor, although I'm not sure if they're maintained.  But I recommend double checking.


Add EntityBuilder::marked

r? @omni-viral @kvark

Thanks for your review @Rhuagh!
bors r+

Great!


need to upgrade version of graceful-fs

npm WARN deprecated<EMAIL_ADDRESS>graceful-fs version 3 and before will fail on newer node releases. Please update to<EMAIL_ADDRESS>as soon as possible

Duplicate of https://github.com/gulpjs/gulp/issues/1568 - stop opening these


#8466: FileValidator - fixed tooBig and tooSmall error messages

Closes #8466
I've added additional option formattedLimit for tooBig and tooSmall error messages.
Then I translated almost all languages, where it was obviously easy.
I found inconsistency in maxSize check condition, also fixed.
Need a review.

:+1:

looks great.


Is asynchronous editor open source component?

I'd async editor open source component?
If yes where can I get source code of it ?
Is it allowed to embed the async editor in any other application ?

Hi @tnpradeep! Yes, the editor is open source and can be embedded as you wish. Note however, it's a work in progress with no documentation yet: https://github.com/asyncapi/editor.


Android : endAllCall Api is not removing the callkit when in full screen.

If we call the FlutterCallkitIncoming.endAllCalls() when the callkit is showing in the full screen. Then just ringing stop but callkit screen is not getting off.

Android : endAllCall Api is not removing the callkit when in full screen

What is the solution?

Same here, wanna know the solution, Please help

Please update to version 2.0.0 (make sure you check the changelog, because the input structure has been changed)


Added note for the translate function for clarity

@gavinlive  please push your changes to master branch , closing this PR


Telefunc Collab

Author of Telefunc here.
Nice work on Samen, congrats 👌.
If you guys are up for some kind of collaboration, let me know!

Thanks man, you too! Let's schedule a meet soon to discuss this. Will get back to you asap 👍

@brillout I've sent you an email about this 😊

Yes I've seen :-).
I think the biggest blocker for this is whether we want to focus on Samen or Telefunc.
I'm obviously biased, but so far I believe Telefunc to be the "superior" approach. I don't mean any offense, and I'm more than happy to be shown wrong!
I know it's very tough but I think it's very well worth it if we somehow manage to align ourselves. It'd tremendously amplify our collective impact.
How do you see this?

We feel the same, but the other way around 😄 What do you think about having a call, where you can do a demo of telefunc and tell us what's better about it, and we do the same to you?

Closing this issue for now, feel free to contact us at<EMAIL_ADDRESS>


[GUI] Popup window always in same position

The popup windows (e.g. controls for setting the CP) always open up in the same position, even if dragged to the side before.

It should always open in the middle of the window, and this is mainly to aid for when you're using a small touchscreen to run TAMV.

Could do a pre-check if it is going to be visually, then?!

So you mean if you've got enough display resolution, make sure it reopens in the same space? If yes, then I could look into it, I'm sure its something that can be supported.

OK finally tracked down the root cause: the dialog windows are being created outside of the main init() function for the application, and that is causing their position to become lost.
I will modify the code to fix this, but its going to take a couple of days, since a lot of logic is built into the init() classes of each dialog box, and that has to be pulled out and refreshed.
Removing the wontfix label!


feat: estimate gas fee with provider if data has provided

According few meetings we had it seems that so far we are actually calculating the fees correctly. On the contrary it needed some improvements in the UI to prevent transaction to be made with to low balance. We might come to this later but, at this point it seems fine.


Drive API is deprecated

com.google.android.gms.drive.Drive is deprecated
google play service lib 9.0 over

@masteage Only Google Drive API is deprecated, but SnapshotClient is not. So I wonder how to save game onto google drive using the Rest API with SnapshotClient.


Migrates to Swift 4

You should remove the need for SwiftyJSON and use Swift 4 Codable.  Or is that the plan after this PR is merged?

Codecov Report

Merging #56 into develop will decrease coverage by 1.18%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop   #56      +/-   ##
========================================
- Coverage    85.18%   84%   -1.19%
========================================
  Files            1     1
  Lines           54    50       -4
========================================
- Hits            46    42       -4
  Misses           8     8

Flag
Coverage Δ

#Controller
84% <100%> (-1.19%)
:arrow_down:

Impacted Files
Coverage Δ

Sources/Controller/Controller.swift
84% <100%> (-1.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cffb40...ffa5341. Read the comment docs.

@troyibm Good catch, we will certainly tackle that as part of these changes.

@rolivieri that would be awesome. Thanks.  Also, I was having trouble pushing the kitura-starter to bluemix this weekend.  I was using the swift-4 branch on https://github.com/sandmman/Kitura-Starter.

@troyibm We are in the process of installing a new version of the buildpack on bluemix. In the meantine, if you intend to push to bluemix a Swift application that uses Swift 4, you'd need to update the manifest.yml file and use the following value for the buildpack element: https://github.com/IBM-Swift/swift-buildpack#develop.


Missing source

In the datasetSectors object of kingdom Plantae is a source with key: 1141:
https://api.catalogue.life/dataset/3LR/tree/0/children?limit=10000&offset=0&insertPlaceholder=true&catalogueKey=3LR&type=CATALOGUE
Trying to fetch this source fails: https://api.catalogue.life/dataset/3LR/source/1141

there are 157 source datasets for 3LR, but 163 distinct sources in the sectors.
Sth not right indeed...


Generate a Workflow using GitHub APIs and start working on it

Issue completed using the auto-version-update repo


Update PPP

Codecov Report

Merging #217 (e389897) into master (2fdb37c) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
- Coverage     54.72%   54.59%   -0.13%
- Complexity      747      750       +3
============================================
  Files           160      160
  Lines          3291     3306      +15
  Branches        363      367       +4
============================================
+ Hits           1801     1805       +4
- Misses         1368     1374       +6
- Partials        122      127       +5

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/person/Person.java
66.19% <0.00%> (-1.99%)
:arrow_down:

src/main/java/seedu/address/model/group/Group.java
33.73% <0.00%> (-0.79%)
:arrow_down:

src/main/java/seedu/address/ui/GroupViewCard.java
0.00% <0.00%> (ø)

...ss/logic/commands/persons/DeletePersonCommand.java
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fdb37c...e389897. Read the comment docs.


[Tizen] Add Thread stack manager implementation

Problem
Thread Stack Manager is not implemented for Tizen.
Change overview
Add Thread Stack Manager implementation and thread network commissioning driver for Tizen.
Testing
chip-tool and chip-lighting-app examples

Refer the previous PR
https://github.com/project-chip/connectedhomeip/pull/16749
Re-raised the PR since in previous PR old docker image was being used leading to workflow failures.

Because of the some env issue, under PR failed to Build Example.
https://github.com/project-chip/connectedhomeip/pull/16749
So we re-raise the PR with the same change.
The previous PR already get the approve.


missing dependency on colcon-package-selection and colcon-ros

The package is missing dependencies on:

colcon-package-selection in order to select specific packages via --packages-select (as per documentation)
colcon-ros to actually discover standard ROS packages that use CMake

Depending on the support for other build systems, more dependencies are required.

resolved in 7c4605e1e1970a21a13d1c8e3cb92a6e1fa4b039 (v0.3.1)


Option type

So, currently a super common pattern that keeps coming up is the valid/data pattern:
module foo(bit data_valid, bits<16> data);

This is, of course, the Option type. How do we express that?
A struct is better than nothing:
struct Option<T> {
    bit valid;
    T data;
}

but still isn't perfect, since you can access the data without checking the valid bit.
In Rust, this is handled by enums being able to contain data:
enum Option<T> {
    Some(T),
    None
}

which we could do also - essentially, we would extend #10 such that the tag exists alongside data. Because this gets complicated if we do types like onehot<my_enum>: Does that become onehot<Option<T>>? What does that mean? The enum is now both a high-level specification of the tag, and also very concrete attached data.

It seems like a bit of a waste to store both A and B, I think it would be fine to store it as a union

@Bobxcat Consider this code (I'm stealing Rust's syntax):
enum Container {
    A(bits<4>),
    B(bits<4>),
}

module foo(Container c) -> (Container cout) {
    cout[t] = match c[t] {
        Container::A(a) => Container::A(a + 1),
        Container::B(b) => Container::B(b),
    };
}

If it's struct-like (bits<sizeof(tag)+sizeof(A)+sizeof(B)>), this can be implemented with four LUT4 elements with a combinatorial depth of just 1 LUT.
If it's union-like (i.e. bits<sizeof(tag)+max(sizeof(A)+sizeof(B))>), then either you need four LUT5 elements[1], or you need more LUTs after the adder to select based on the tag (and thus have a combinatorial depth of greater than 1).
And in this case, nothing is being stored anywhere, so the extra bits come free. Of course, if we register Container somewhere, then that becomes an issue because the extra bits consume flip-flops.
[1] For a 1-bit tag. For an N-bit tag, each bit adder needs to be a 4+N input LUT, so if you have more than a 2-bit tag you're forced to use a tree approach.


Application won't detect proper DPI scaling

Description
I'm working on a dual monitor setup.
Primary monitor is 4k, DPI scale is set to 200%
Secondary monitor is 1440p, DPI is set to 125%
When I move the app's window across monitors - it won't rescale itself properly resulting in unreadable text

Steps to reproduce
Have monitors with different DPI scale and drag the window from one to another.
It also seems to be random at times, depending on what monitor the app starts on.
Environment

RenderDoc version: 1.31
Operating System: Windows 11
Graphics API: Doesn't matter

Additional info
Maybe updating to the latest Qt6 will fix this? They seems to have added per-monitor DPI functionality over there.

This might just be a Qt5 issue, DPI stuff is largely out of our hands. I believe we should support per-monitor DPI at least but probably not switching from one to the other on the fly.
Does it work correctly if the layout is loaded with panels on their respective monitors - i.e. is it only broken when dragging from one to another?
There are no plans to ever switch to Qt6 FWIW.

To clarify - is it random or does it depend on the monitor the app starts on? If you close and reopen the program the location of all windows should be saved and be consistent and it should appear in the same monitor each time - does that ever change or does it always behave the same given a certain layout?
If you're able to find a workaround/fix that would be great. I'm somewhat unable to test this as I don't use DPI scaling on my system and can't really go very high with the scaling on my normal monitors without breaking the layout in a way that makes testing a little dubious.

To clarify - is it random or does it depend on the monitor the app starts on?

Yes sorry for being unclear - there's two variants of this issue.
1 - The app starts on the main monitor and then dragged onto the secondary (diff res and scale) - and rescales improperly.
2 - The app starts on the second monitor - the UI is already scaled improperly, and if you drag it to another monitor - it gets even worse.
The second scenario is a bit random, as sometimes it starts on the secondary monitor and looks fine. Still not sure why.

OK thanks for clarifying. I would definitely be interested in figuring out what is happening in the second variant when it breaks - the fact that it works sometimes suggests that the code in theory handles what I thought it did (i.e. everything except dragging/dynamic DPI change), but it sometimes not working is curious. I wonder if that is some kind of behaviour where the window opens on the wrong monitor long enough for the DPI to latch, before the layout is properly loaded and moves it to the second monitor.

Just to check, did you have any time to dig into the code with this, or find the pattern in when it shows up as improperly scaled on the second monitor when the application starts there?
I do still want to try and look into this if I find a way I'm able to, but as mentioned all of my monitors are normal monitors not high DPI so reproducing this will be challenging.

Sorry for the late reply, was quite busy.
So I think I managed to get why it was so "random" - because of my hybrid work model (WFH + office) I can Remote Desktop to my work PC from home for some stuff, and then when I come to the office - RenderDoc would go in this "weird scaling" mode, until I reboot my PC.
So it has something to do with Remote Desktop. I might debug it when I have spare time to better understand why it happens, but you can close this "bug" if you want, as this seems to be a specific case.

There are no plans to ever switch to Qt6 FWIW.

Why?

Thanks for looking into it iOrange, if you notice any more of a pattern to it or find something more specific that could be fixed please open a new issue.


add RSpec task to Rakefile

rake test now runs the RSpec tests as advertised in the documentation.

HI @jabbrwcky,
thanks for the pull request.
Can you please fix following issues in you PR?
Use ruby 1.9/2.x hash style syntax:
task default: :test

Display a helpful error message when you catch the exception that rspec is not present. The user may run bundle install in order to fix this issue.


The Lovelace example uses vacuum entity, which does not exist after 2.0.0

Hi there!
Thank you for your ongoing support of the Robonect integration.
I'm using your example card pretty much 1:1, but since release 2.0.0 the vacuum entity which was used before is now non existent.
It probably isn't a direct replacement after looking at both entities in the developer tools, same for the commands according to the documentation.
If the example card could be updated to 2.0.0 standards as well, this would be awesome!
Thank you very much in advance!

I changed it but forgot to merge it from the dev branch 👍
Thanks for noticing


Refactor Repeated API Request Logic

Duplicated code increases maintenance complexity. When changes are needed (e.g., modifying how the API request is made), you have to modify it in multiple places, increasing the risk of missing one.
https://github.com/XichengTong/SoftwareSupplyChainSecurity_HW1/blob/e32bee2352c30a83d3f281323abb1bd64c0ea378/main.py#L23
https://github.com/XichengTong/SoftwareSupplyChainSecurity_HW1/blob/e32bee2352c30a83d3f281323abb1bd64c0ea378/main.py#L102
Create a helper function like fetch_from_rekor(api_url) to handle all API requests and reuse it throughout the code. This will reduce code duplication.

same as magic number issue #1 Solved with making a new function