Bug with z/map

Hey, not sure if it's a bug with z/map, but if I have a seq of children nodes and I want to map over them removing the nodes, it doesn't not work
(->> "([foo :as f] [bar :as b] [car :as c])"
     z/of-string
     (z/map z/remove))
 ;; => [<forms: ([bar :as b] [car :as c])> nil] [2 times]

It seems it removes only the first element, so I did a workaround that almost work:
(defn ^:private safe-remove-node
  [node]
  (let [removed-node (-> node z/remove)]
    (if (z/list? removed-node)
      (z/down removed-node)
      (z/up removed-node))))

But If I have to remove all elements it doesn't work, it always reduce the children to only one.

Hey @ericdallo, thanks so much for reaching out with your observation!
Although the docstring does not currently mention it, I think that z/map was not intended to be used with operations that affect the zipper location.
After [foo :as f] is removed the zipper locates to the "the first non-whitespace
node that would have preceded it in a depth-first walk".
So we are now at list ([bar :as b] [car :as c]) which has no siblings to the right and therefore the map operation finishes.
I'd like to leave this issue open until I get around to updating the z/map docstring with a caveat.
If you are still looking for a way to remove nodes, please follow up with your use case(s) and we'll try to help.
If you are just wanting to replace a node with an empty list then this can work:
(require '[rewrite-clj.zip :as z])

(-> "([foo :as f] [bar :as b] [car :as c])"
    z/of-string
    (z/replace (list))
    z/root-string)
;; => "()"

Hey @ericdallo, thanks so much for reaching out with your observation!
Although the docstring does not currently mention it, I think that z/map was not intended to be used with operations that affect the zipper location.
After [foo :as f] is removed the zipper locates to the "the first non-whitespace
node that would have preceded it in a depth-first walk".
So we are now at list ([bar :as b] [car :as c]) which has no siblings to the right and therefore the map operation finishes.
I'd like to leave this issue open until I get around to updating the z/map docstring with a caveat.
If you are still looking for a way to remove nodes, please follow up with your use case(s) and we'll try to help.
If you are just wanting to replace a node with an empty list then this can work:
(require '[rewrite-clj.zip :as z])

(-> "([foo :as f] [bar :as b] [car :as c])"
    z/of-string
    (z/replace (list))
    z/root-string)
;; => "()"

Thank you for the reply @lread!
I did a very ugly workaround for that here 😅
But I'd like to know the canonical way to fix that if possible :).
The issue is that in the code, I need to walk into each require (children nodes) and check if it's unused in the code, if so, remove it, I really thought z/map was the way to do that, although I'd love to hear the correct function for that

Thank you for the reply @lread!
I did a very ugly workaround for that here 😅
But I'd like to know the canonical way to fix that if possible :).
The issue is that in the code, I need to walk into each require (children nodes) and check if it's unused in the code, if so, remove it, I really thought z/map was the way to do that, although I'd love to hear the correct function for that

Heya @ericdallo!
I find z/remove a little challenging sometimes myself.
There are many ways to solve a problem, I personally think your work-around isn't horribly ugly.
I think the difficulty in your use case is that you want to constrain conditional removal to direct children but z/remove moves the zipper location outside of your desired constraint in ways that are not easy to detect.
There are certainly other solutions, but one way to constrain the tree you are working on is through subediting.
We can use z/end? to test if we have iterated through our constrained tree.
Here's my stab at a little function that might apply to your use case:
(require '[rewrite-clj.zip :as z])

(defn remove-children [parent-zloc pred?]
  (z/subedit->> parent-zloc
                z/down
                (iterate (fn [zloc]
                           (when (not (z/end? zloc))
                             (if (pred? zloc)
                               (-> zloc z/remove z/next)
                               (-> zloc z/right)))))
                (take-while identity)
                last))

;; we'll use your original example but add in some other stuff just to better test our little fn
(def t-zloc (-> "(other-stuff ([foo :as f] [bar :as b] [car :as c]) more-stuff)"
                z/of-string
                z/down   ;; down to 'other-stuff
                z/right  ;; right to your original list
                ))

;; and some contrived examples

;; remove first child
(-> (remove-children t-zloc (fn pred? [child-zloc] (= 'foo (-> child-zloc z/down z/sexpr))))
    z/root-string)
;; => "(other-stuff ([bar :as b] [car :as c]) more-stuff)"

;; remove 2nd child
(-> (remove-children t-zloc #(= 'bar (-> % z/down z/sexpr)))
    z/root-string)
;; => "(other-stuff ([foo :as f] [car :as c]) more-stuff)"

;; remove 1st and 3rd child
(-> (remove-children t-zloc #((-> % z/down z/sexpr) #{'foo 'car}))
    z/root-string)
;; => "(other-stuff ([bar :as b]) more-stuff)"

;; remove all children
(-> (remove-children t-zloc (constantly true))
    z/root-string)
;; => "(other-stuff () more-stuff)"

If others have different better solutions, I am happy to learn about them.

Heya @ericdallo!
I find z/remove a little challenging sometimes myself.
There are many ways to solve a problem, I personally think your work-around isn't horribly ugly.
I think the difficulty in your use case is that you want to constrain conditional removal to direct children but z/remove moves the zipper location outside of your desired constraint in ways that are not easy to detect.
There are certainly other solutions, but one way to constrain the tree you are working on is through subediting.
We can use z/end? to test if we have iterated through our constrained tree.
Here's my stab at a little function that might apply to your use case:
(require '[rewrite-clj.zip :as z])

(defn remove-children [parent-zloc pred?]
  (z/subedit->> parent-zloc
                z/down
                (iterate (fn [zloc]
                           (when (not (z/end? zloc))
                             (if (pred? zloc)
                               (-> zloc z/remove z/next)
                               (-> zloc z/right)))))
                (take-while identity)
                last))

;; we'll use your original example but add in some other stuff just to better test our little fn
(def t-zloc (-> "(other-stuff ([foo :as f] [bar :as b] [car :as c]) more-stuff)"
                z/of-string
                z/down   ;; down to 'other-stuff
                z/right  ;; right to your original list
                ))

;; and some contrived examples

;; remove first child
(-> (remove-children t-zloc (fn pred? [child-zloc] (= 'foo (-> child-zloc z/down z/sexpr))))
    z/root-string)
;; => "(other-stuff ([bar :as b] [car :as c]) more-stuff)"

;; remove 2nd child
(-> (remove-children t-zloc #(= 'bar (-> % z/down z/sexpr)))
    z/root-string)
;; => "(other-stuff ([foo :as f] [car :as c]) more-stuff)"

;; remove 1st and 3rd child
(-> (remove-children t-zloc #((-> % z/down z/sexpr) #{'foo 'car}))
    z/root-string)
;; => "(other-stuff ([bar :as b]) more-stuff)"

;; remove all children
(-> (remove-children t-zloc (constantly true))
    z/root-string)
;; => "(other-stuff () more-stuff)"

If others have different better solutions, I am happy to learn about them.

Uow, what a detailed reply, thank you very much for the example @lread, I could understand and I'll try to change the workaround for this ASAP!
I let you know if it works

Uow, what a detailed reply, thank you very much for the example @lread, I could understand and I'll try to change the workaround for this ASAP!
I let you know if it works

@lread it worked!
I just changed it a little bit to map-children since for my case since not necessarily want to remove it, for other cases I want to replace it with another node, but the core is what you suggested, thank you very much!
This is the final code

@lread it worked!
I just changed it a little bit to map-children since for my case since not necessarily want to remove it, for other cases I want to replace it with another node, but the core is what you suggested, thank you very much!
This is the final code

Glad it worked for you @ericdallo, thanks for following up!

Glad it worked for you @ericdallo, thanks for following up!


[BottomNavigation] onClick does not fire if tapped while scrolling

When i try to tap (touch click) on a BottomNavigationAction while the page is currently scrolling, the onClick event handler is never called. The TouchRipple effect however runs flawlessly, which makes me believe that this is an issue with how touch events are handled in ButtonBase. If i change my onClick for a onTouchStart it is called as expected, but of course this is not a viable solution, as it does not take swiping into account.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
If i press the BottomNavigationAction while the page is scrolling, the page stops scrolling and the TouchRipple effect runs. If i press again, now that the page has stopped scrolling, the onClick event handler is called.

Expected Behavior 🤔
When i press the BottomNavigationAction while the page is scrolling, the TouchRipple effect runs and my onClick handler is called.

Steps to Reproduce 🕹

Steps:

Go to a page where you have a BottomNavigation, where you can scroll vertically
Swipe up
While the phone is scrolling, tap the BottomNavigationAction

Context 🔦
When you scroll on mobile, it takes a while for it to stop scrolling, if you do it fast enough. Therefore i want it to be possible, to click the BottomNavigationAction while the phone is scrolling.

Your Environment 🌎
I experience the issue when running mobile emulation in Chrome Devtools. A tester is also experiencing this issue on an iPhone 11 Pro on Safari.

Tech
Version

Material-UI
v4.9.1

React
v16.12.x

Browser
Chrome

TypeScript
v3.9.3

@oliviertassinari How is this support? I am reporting unexpected behaviour? Surely that must be a bug.

@oliviertassinari Please reopen this issue and reign in your trigger-happy support bot. This is a bug in MUI without a doubt.

A couple of thoughts:

A reproduction of the issue https://codesandbox.io/s/material-demo-forked-w444e?file=/demo.tsx.
The first click attempt will stop the scroll, the second click attempt with go through. It's how the web works.
The visible ripple originates from a tradeoff. You can check the source of TouchRipple.js and its history to gain more information about it.
I have tried to create a reproduction with ionic to see how they would behave. I couldn't, their documentation was missing too much information for doing such. I have hatted the experience. I think that it would be great to add a new demo, using the previous codesandbox as inspiration as well as https://material-ui.com/components/app-bar/#bottom-app-bar
On Android and iOS a touch start doesn't stop the scroll, on the web, it does, I don't think that we can do anything about it.
On Android and iOS a touch end, if it completes on the same element that the touch start was, will trigger a click.

This POC seems to fill the task just right:
diff --git a/packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js b/packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
index a1956c844d..020b125b30 100644
--- a/packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
+++ b/packages/material-ui/src/BottomNavigationAction/BottomNavigationAction.js
@@ -69,6 +69,9 @@ const BottomNavigationAction = React.forwardRef(function BottomNavigationAction(
   } = props;

   const handleChange = (event) => {
+    clearTimeout(timer.current);
+    console.log('click')
+
     if (onChange) {
       onChange(event, value);
     }
@@ -78,6 +81,9 @@ const BottomNavigationAction = React.forwardRef(function BottomNavigationAction(
     }
   };

+  const start = React.useRef();
+  const timer = React.useRef();
+
   return (
     <ButtonBase
       ref={ref}
@@ -89,6 +95,25 @@ const BottomNavigationAction = React.forwardRef(function BottomNavigationAction(
         },
         className,
       )}
+      onTouchStart={(event) => {
+        const { clientX, clientY } = event.touches[0];
+
+        start.current = {
+          clientX,
+          clientY,
+        }
+      }}
+      onTouchEnd={(event) => {
+        const target = event.target;
+        const { clientX, clientY } = event.changedTouches[0];
+
+        if(Math.abs(clientX - start.current.clientX) < 10 && Math.abs(clientY - start.current.clientY) < 10) {
+          timer.current = setTimeout(() => {
+            alert('foo')
+            target.dispatchEvent(new Event("click", { bubbles: true }));
+          }, 10);
+        }
+      }}
       focusRipple
       onClick={handleChange}
       {...other}

Could you try it out in your application? Do you want to work on a pull request? (we would need to add a new demo, add tests, and cleanup the POC)

@oliviertassinari Sure, i'd like to work on a pull request. What do you want the demo to showcase? I'm also unsure how i would write a test for this scenario. Do you have anything similar in the codebase i can look at for a rough reference?

@EliasJorgensen We have no prior-art in messing with the onclick, so nothing we can directly use as inspiration. For the demos, we have seen developers ask: how do I correctly position the bottom navigation a couple of time? We could solve this question with a new demo at the end of the page, similar to my reproduction.

@oliviertassinari Alright cool, i'll take a look at it next week :ok_hand:

@oliviertassinari i have implemented your PoC, cleaned it up, and added a single unit test for it, to show how i solved testing it. The only way i could figure out testing the onTouchStart/End handling of the component, was by adding a useImperativeHandle to the BottomNavigationAction component, in order to call the handlers directly. This however hijacks the ref, as far as i can tell anyway, such that it never reaches the ButtonBase like it normally does. I'm not sure how we can test the touch handling without doing this however. Is this problem something you have experienced before?
You can take a look at what i mean here: https://github.com/EliasJorgensen/material-ui/commit/cc507f1c0f2ae90b0fc632c241ebdba6f0ef40ee

i have implemented your PoC, cleaned it up, and added a single unit test for it

@EliasJorgensen Great. Things I could see: if a parent provides onTouchStart/onTouchEnd the event is not forwarded.

I'm not sure how we can test the touch handling without doing this.

We can't move forward with an approach that leverages the ref to trigger the action. However, you can apply the approach we use in the other components, e.g.:
https://github.com/mui-org/material-ui/blob/ceb813e855778dc544b1056c600633c4d2aa27b3/packages/material-ui/src/Slider/Slider.test.js#L138.
Now, I don't think that this feature can "truly" (as ent-to-end) be tested with our stack. It relies on the fact that if a scroll is in progress the onClick event is never triggered. But I guess it's still interesting to add one :)

@oliviertassinari Nice, fireEvent was just what i wanted to do, but couldn't figure out how. I'll use that instead, and make sure to forward the events.

@oliviertassinari In your PoC, what is the point of the timout when dispatching the click event?

@EliasJorgensen Wait for a potential click event to fire, if click fires, we need to cancel the touch start/touch end sequence.

@oliviertassinari Ah i see, so we create the timeout, and if we receive a native click event, the handleChange function clears the timeout. Gotcha. Thanks for clearing it up :+1:

@EliasJorgensen How is it going? Are the changes ready for a pull request :)?

@oliviertassinari I have the implementation and testing done, i just need to throw together the demo you wanted. I'm planning on doing it after work today :) If you have any comments for the implementation/testing, they are more than welcome.

Re-opening since the fix for this issue (https://github.com/mui-org/material-ui/pull/22524) causes another bug: https://github.com/mui-org/material-ui/issues/27664#issuecomment-896572656.
BottomNavigationAction should not have different click behavior compared to any other button-like element.
The ripple starting is not an indication that a click will be dispatched. It's just indicating that the button is "arming".

@eps1lon I disagree, the ripple starting indicates to the user (at least any user who does not know how MUI works) that the button has been clicked. When the ripple starts, the user then expects the appropriate action to occur. If the given action does not occur, the user will interpret this as an error. The whole reason i opened this issue in the first place, is because a (non-technical) customer believed this to be a bug in the software we built for them.
When one person interpret this as a bug, there must be a whole lot more who just haven't said anything.

The question that's currently unanswered: How would a native <button />, <Button /> or any other clickable behave under the same circumstances. They should behave just like the <BottmonNavigationAction />.

I also do not necessarily agree on this. If you are scrolling around on a page at a certain pace, you would not have a 100% hit rate, when trying to press a given button element. No matter how fast you scroll though, a fixed bottomnavigationaction will always be the same place, and you will likely always hit it whenever you try, as navigation quickly becomes muscle memory. Therefore a user would expect it to fire an action, no matter how fast the page is scrolling.

@eps1lon I have investigated the issue discussed in #27664. It seems to be a timing issue, where the time used by Firefox to fire the onClick event exceeds the 10ms used in the touch timeout here: https://github.com/mui-org/material-ui/pull/22524/files#diff-9bd1b68cd4c10ba7a546c4e18fb32dd88299f9a9de53f2efe599f54cdf24ae92R112.
If i increase the timeout, then i can no longer reproduce the issue in Firefox, using the demo from #27664 (i checked out a commit before the author changed it to use a button element).
The 10ms delay were taken without thought, from this PoC from @oliviertassinari, but i can see that the ripple uses an 80ms delay (https://github.com/mui-org/material-ui/blame/next/packages/material-ui/src/ButtonBase/TouchRipple.js#L12). I imagine that it is that high, due to the exact same issue as this. Thus, using the same delay would resolve this issue.
Of course this do not resolve the question of functionality raised by @eps1lon, but it fixes the bug reported in #27664 without removing behaviour that i, and users of mine, regard as expected. :smile:

Agree, I think that we could increase the timeout from 10 ms to 80ms. It's still enough to make the UI feel responsive.
@rxdrag Could you expand on how the double click event is problematic in your use case? I get that it's not ideal but if the annoyance is only about calling a "cheap" (from a runtime perspective) method twice. It sounds like an interesting tradeoff to take this double click pain in and get the UI feel more responsive on iOS.

@eps1lon I would be careful about requiring that BottomNavigationActions and buttons act exactly the same. The crucial difference here is that BottomNavigationActions always remain static as the user scrolls, whereas buttons are usually embedded in the scrolling content.
It is natural for a user to expect to be able to interact with static elements before other content has stopped scrolling. But as a user, I would not be surprised that I cannot activate a button as it scrolls by. In fact I would stop the scroll before making the attempt to make sure I hit the right button.

whereas buttons are usually embedded in the scrolling content.

They can be static just like the BottomNavigationAction.

how the ripple works

To expand on what the 80ms of https://github.com/mui-org/material-ui/blob/a9194b570c7384ae869023020d084229fdc0dc32/packages/material-ui/src/ButtonBase/TouchRipple.js#L12
is about. It's about being long enough to accurately know if a click event is going to happen. It's also about being short enough to make the ripple feel instant.
The problem we face seem to strick the same tradeoff

@EliasJorgensen Do you want to work on a PR based on https://github.com/mui-org/material-ui/issues/22368#issuecomment-899355677?

@oliviertassinari Sure. What do you want done? Just changing the timeout? :)

Mostly to make sure we don't regress with #27664.

@oliviertassinari I have reapplied the changes that were reverted in #27690 and changed the 10ms delay, to use DELAY_RIPPLE imported from TouchRipple.js instead.
As mentioned in https://github.com/mui-org/material-ui/issues/22368#issuecomment-899355677, that delay fixed the issue in Firefox for me, and i could no longer reproduce it.
Should i just open a PR with this, or is there anything else you wanted me to look into? :)

@oliviertassinari I guess you are being flooded, due to the v5 launch, so ping :ping_pong: :smile:


cluster manager: add new feature connection pool per stream info

Commit Message: new feature connection pool per unique stream info format. Cluster-manager creates connection pool per unique key derived for the format specified.
Additional Description: This feature is not enforced if "connection_pool_per_downstream_connection" is set to true because the later is most granular i.e one upstream connection for each downstream connection.
Risk Level: Medium
Testing: Add UT to validating connection pool per unique key in cluster manager
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #26817

/wait-any wait the API review.

/wait-any wait the API review / CI

Ping @markdroth

Before start the code review, I hope to ensure if this feature is acceptable for the community. So, a LGTM to API should be necessary.
Seems @markdroth is busy, so if @markdroth still be non-responsitive, we can re-assign this to another api shepherd at tomorrow.
/wait-any

Hi, @adisuissa could your take a look at this PR when you have free time? Thanks.

/wait


url path regex

It is very time-consuming to submit a regex and find out that it doesn't work after 2 to 3 hours. Is there a quick way of testing the regex in the Verizon CDN interface? Also for a paid service, the interface is very slow and web interface performance is not up to the standards.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3409e329-7cfe-fc82-a918-3bc78488726d
Version Independent ID: afee3972-145c-a4cd-ba70-78931afc1c96
Content: Azure CDN from Verizon Premium rules engine match conditions
Content Source: articles/cdn/cdn-verizon-premium-rules-engine-reference-match-conditions.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

@jeevaeastpoint
Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Sending to PM for review
#reassign:@mdgattuso

Assigning to PM for review
#reassign:@amitsriva

#reassign: gunjanj

Thank you for you dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


yokai-php/messenger-bundle#10 SwiftMailer configuration harmonization

Now only use from, nor from_addr

@nicolas-joubert after merging your preview PR, this branch has conflicts

@yann-eugone I've resolved it

@nicolas-joubert can you add some tests with configuration loading and from as array (multiple occurence, name => email pairs) ?


⚠ ClamAV has degraded performance

In eb8a05b, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 247 ms

Resolved: ClamAV performance has improved in c6d0d1e after 9 minutes.


Added es_MX translation

Added the spanish (Mexico) translation based on the latest commits of the master branch and based on the templates from Pull Request #236.
This translation covers all the RST files and is related to Issue #134.

@axelitus thanks for the translation, I will add it to RTD and give you feedback here when it's done

I merged it, created a project on RTD for it and added it to the original DesignPatternsPHP project on RTD, but unfortunately I can only choose spanish for the language (only "es" not "es_MX") now it shows two es languages in the docs and they seem to be equal to me (URL definitely is the same: http://designpatternsphp.readthedocs.io/es/latest/README.html). Any idea how we could fix it?

Mmmmm I don't really know. I haven't used RTD that much...


Add .circleci/config.yml

Pull Request Template
The code review checklist below is used for all pull requests.

Review the list before submitting your pull request.
Leave the list intact for the code reviewer's use.

Checklist

[ ] Latest code from master has been merged into the pull request branch
[ ] Code is camelCased
[ ] No commented out code (if required, place // TODO above with explanation)
[ ] No linting issues
[ ] Automated tests exist and pass
[ ] Build is successful (npm run build)
[ ] Works in IE 11, Chrome, Firefox, and Edge

Thanks!
:heart:

Coverage remained the same at 91.525% when pulling f2a36c12482afa9ee8ff54f6db3cb45c683048d9 on AskarAitzhan:circleci-project-setup into a7b0c6111cceaf88ffa4c24df3b38401f045a3d1 on coryhouse:master.


tail: Cargo.toml: Remove unneeded features of uucore and the nix dependency

This pr removes the unused features ringbuffer and lines of the uucore dependency. The nix dependency wasn't in use either, so it's removed, too.

cool
how did you notice that?

I had to adjust the Cargo.toml file in a pr because of the change to workspace.dependencies and then I noticed the unused dependencies. It's a little bit my fault too because I removed the need for these dependencies in some pr before, but didn't notice they're not in use elsewhere.

Hmm too bad cargo udeps doesn't flag this. I wonder if we can run it per util too and get a warning automatically.

So running it per util could still be useful.

yeah I think too this would be great. In another issue/pr?

Yes!


Increase the sampling rate of the joystick for remote control

The rate set at the behavior controller seems to be 7 Hz. This is a little low and could be increased.

The joystick seems to disconnect when starting the roslaunch file:
[11807.520437] usb 1-1.4: USB disconnect, device number 34
[11807.521133] xpad 1-1.4:1.2: xpad_irq_in - usb_submit_urb failed with result -19
[11807.530237] xpad 1-1.4:1.4: xpad_irq_in - usb_submit_urb failed with result -19
[11807.539069] xpad 1-1.4:1.6: xpad_irq_in - usb_submit_urb failed with result -19
[11991.694815] l3gd20_gyr 2-006b: power off
[11994.652811] usb 1-1.4: new full-speed USB device number 35 using musb-hdrc
[11994.777445] usb 1-1.4: New USB device found, idVendor=045e, idProduct=0719
[11994.777464] usb 1-1.4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[11994.777473] usb 1-1.4: Product: Xbox 360 Wireless Receiver for Windows
[11994.777481] usb 1-1.4: Manufacturer: ©Microsoft
[11994.777489] usb 1-1.4: SerialNumber: FF958890
[11994.782188] input: Xbox 360 Wireless Receiver as /devices/platform/ocp/47400000.usb/47401c00.usb/musb-hdrc.1.auto/usb1/1-1/1-1.4/1-1.4:1.0/input/input77
[11994.788060] input: Xbox 360 Wireless Receiver as /devices/platform/ocp/47400000.usb/47401c00.usb/musb-hdrc.1.auto/usb1/1-1/1-1.4/1-1.4:1.2/input/input78
[11994.790116] input: Xbox 360 Wireless Receiver as /devices/platform/ocp/47400000.usb/47401c00.usb/musb-hdrc.1.auto/usb1/1-1/1-1.4/1-1.4:1.4/input/input79
[11994.796232] input: Xbox 360 Wireless Receiver as /devices/platform/ocp/47400000.usb/47401c00.usb/musb-hdrc.1.auto/usb1/1-1/1-1.4/1-1.4:1.6/input/input80

It appears the Xbox 360 Wireless Receiver is very sensible to high loads (USB bus or CPU), and automatically disconnects in such case. I have also tried the xboxdrv userspace driver (and blacklisted xpad), which seems a little more stable for a while but failed eventually during recording. At the end, the generic wired USB joystick was the most stable.

See commit 10e4455 for a more efficient joystick implementation (stateless) that doesn't require subscribing to the robot topics for manual control. Also with the optimization in message publishing to be done in #31, the load on the CPU will be greatly reduced and this should avoid having errors as below due to bad interrupt handling.


clientserver without X

Is your feature request about something that is currently impossible or hard to do? Please describe the problem.
In order to use clientserver feature, not only linking with X libraries but also X server is necessary on runtime.
To do something like vim --servername VIM_SERVER --remote-tab test , you need to start full x server or virtual x server. --remote-tab is very useful when you open from vim :sh or :terminal. On Mac, it's especially painful to link with xquartz and have it running. On SSH only server, you'd run Xvfb.
Describe the solution you'd like
Ideally vim directly supports or vim project can generate a tiny server binary, and vim can open remote tab through unix domain socket or tcp.
Describe alternatives you've considered
None. I cannot think of things other than socket for IPC for this.
Additional context
None

Duplicate of #3509.


Release<EMAIL_ADDRESS>

Coverage remained the same at 81.951% when pulling 8ccb771a4c97bf4a9a678fe631bc7fae99074733 on 1.3.4-release into 705ea014a94cd53a5dc28dc87e684ef418ceb542 on dev.


TST: Add sparse arithmetic ops test

[x] tests added / passed
[x] passes git diff upstream/master | flake8 --diff
[x] whatsnew entry

thanks!


Integrate Cupra Born

As of now, it is not working for my Cupra Born. Could you please implement this as well?

First changes in the weconnect libary are added for Cupra Born, if the work is done there i will try to add it.
Don't now if i need to change the name for the integration after this tough :P

I offered the the developer of https://github.com/tillsteinbach/WeConnect-python which is used by this intergration access to My Cupra account to add the Cupra Born into the weconnect library. Hopefully he will add this. When that's done it can be added here and offcourse I can offer acces to My Cupra account for testing.

I have a Cupra Born too and seems they got it working in the WeConnect-python library.

There is an open issue https://github.com/tillsteinbach/WeConnect-python/issues/26 where I and a couple of others are offering help getting the python script going. Early tests are succesful and I can actually show info from my Cupra Born in the python application.

I'd appreciate it if anyone with a VW could go to the above issue and test my changes. I have a Cupra Born, so I can't regression test the existing VW support.

I've got basic sensor integration with Home Assistant using the volkswagen_we_connect_id integration going here:
https://github.com/alangibson/volkswagen_we_connect_id/tree/feature/cupra-support
Caveats:

Buttons don't work
Climate sensors don't work
I haven't tested sensors during active charging yet

My changes are now quite complete for charging. Test it out with:
ssh<EMAIL_ADDRESS>git clone -b 'feature/cupra-support' https://github.com/alangibson/volkswagen_we_connect_id.git
cp -R volkswagen_we_connect_id/custom_components/volkswagen_we_connect_id /config/custom_components/
ha core restart

Hey @alangibson,
if I remember correctly, i'm using your fork (feature branch) for our born. The integration fails for a few days now and no data can be received at all. Does it still work for you and do you have a clue on what's wrong? Thanks in advance.

This error originated from a custom integration.
Logger: homeassistant.config_entries
Source: custom_components/volkswagen_we_connect_id/init.py:92
Integration: Volkswagen We Connect ID (documentation)
First occurred: 12:42:29 PM (3 occurrences)
Last logged: 1:18:07 PM
Error setting up entry Volkswagen We Connect ID for volkswagen_we_connect_id
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 387, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/volkswagen_we_connect_id/init.py", line 92, in async_setup_entry
hass.config_entries.async_setup_platforms(entry, PLATFORMS)
AttributeError: 'ConfigEntries' object has no attribute 'async_setup_platforms'


Problem starting it up

Description of Issue: Problem starting it up
MCEdit Version: <IP_ADDRESS> testing win64
Minecraft Version the world was last opened in: none
Operating System: windows 10
A screenshot or full text of the error from the console: http://prntscr.com/jw0vg1
How to reproduce: i just opened it
what am I doing wrong?
Read before submitting
If we are not able to reproduce the error, we may ask for you to submit a world so we can test it. Same process for schematics.
If you have included enough information for each section, please delete the above header and all the text below.

What is the full file path that the executable is located at?


owncloud-client: 2.3.4 -> 2.4.1

Motivation for this change
Version bump
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Any hope to have this merged?

@GrahamcOfBorg  build owncloud-client

Success on x86_64-linux (full log)
Attempted: owncloud-client
Partial log (click to expand)
shrinking /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib64/libowncloudsync.so.2.4.1
shrinking /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/bin/owncloud
shrinking /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/bin/owncloudcmd
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib64  /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/bin
patching script interpreter paths in /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1
checking for references to /build in /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1...
moving /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib64/* to /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib
postPatchMkspecs
postPatchMkspecs

Failure on x86_64-darwin (full log)
Attempted: owncloud-client
Partial log (click to expand)
  "Qt5MacExtras" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:218 (include)

-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-owncloud-client-2.4.1.drv-0/owncloudclient-2.4.1/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/iyriz96wpkhahvsj9pipkslwg5zwp0v0-owncloud-client-2.4.1.drv' failed with exit code 1
error: build of '/nix/store/iyriz96wpkhahvsj9pipkslwg5zwp0v0-owncloud-client-2.4.1.drv' failed

Success on aarch64-linux (full log)
Attempted: owncloud-client
Partial log (click to expand)
shrinking /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64/libowncloudsync.so.2.4.1
shrinking /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64/owncloud/libocsync.so.2.4.1
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64  /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/bin
patching script interpreter paths in /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1
checking for references to /build in /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1...
moving /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64/* to /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib
postPatchMkspecs
postPatchMkspecs
/nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1


Twitch integration problems

Hello
I tried configuring thump to work with twitch, since twitch uses irc chat. It works fine to send messages/achievements from minecraft>irc. However, I dont see any messages from irc to minecraft.
Also, about the commands, I wanted to know if there is a way to receive an irc message to trigger a command on minecraft, or even say in minecraft (there is a chatdetector block on RandomThings that sends redstone signals every time a player says a specific word)
I am using thump for 1.10.2  (4.03.04) on a single player world. I usually open the world to Lan because I forgot to allow cheats on creation.

This sounds like a Twitch related problem in Warren (the library used to do the IRC stuff) - did you follow a guide for connecting to Twitch that I could follow, to try and reproduce the issue?

Here is my config file
`# Configuration file
~CONFIG_VERSION: 2
connections {
soudescolado {
    #  [default: ]
    S:Server=irc.chat.twitch.tv

    #  [range: 1 ~ 65535, default: 6697]
    I:Port=6667

    #  [default: thump-server]
    S:Nickname=YOURTWITCHUSERNAME

    #  [default: ]
    S:Channels <
        #THECHANNELYOUWANTTOJOIN
     >

    #  [default: ]
    S:IgnoredNicks <
     >

    #  [default: ]
    S:ServerPassword=oauth:YOUR OAUTHKEYHERE

    auth {

        nickserv {
            #  [default: false]
            B:IdentifyWithNickserv=false

            #  [default: ]
            S:NickservAccount=

            #  [default: ]
            S:NickservPassword=
        }

        sasl {
            #  [default: false]
            B:IdentifyWithSASL=false

            #  [default: ]
            S:SASLAccount=

            #  [default: ]
            S:SASLPassword=
        }

    }

    tls {
        #  [default: true]
        B:UseTLS=false

        #  [default: false]
        B:ForceAcceptCertificates=false

        # Leave blank with 'ForceAcceptCertificates' on to enter the danger zone and forcefully accept all presented certificates [default: ]
        S:ForciblyAcceptedCertificates <
         >
    }

    reconnect {
        #  [default: true]
        B:ShouldReconnectAutomatically=true

        #  [range: 0 ~ 3600, default: 60]
        I:AutomaticReconnectDelaySeconds=60

        #  [range: 1 ~ 5, default: 3]
        I:MaxConsecutiveReconnectAttempts=3
    }

}

}
events {
#  [default: true]
B:ChannelMessage=true
#  [default: true]
B:ChannelAction=true
B:channelAction=true
B:channelMessage=true

}
##########################################################################################################
formats
#--------------------------------------------------------------------------------------------------------#
Formatting tokens: {u} -> user, {c} -> channel, {m} -> message, {s} -> server
##########################################################################################################
formats {
#  [default: {c}: <{u}> {m}]
S:ChannelMessage={c}: <{u}> {m}
#  [default: {c}: * {u} {m}]
S:ChannelAction={c}: * {u} {m}

#  [default: IRC network ready: {m}]
S:NetworkReady=IRC network ready: {m}

#  [default: IRC network disconnected: {m}]
S:NetworkDisconnected=IRC network disconnected: {m}

}
general {
#  [default: true]
B:LogIRCToServerConsole=true
# Dumps raw incoming IRC lines to the console using INFO level - leave disabled when you don't need it! [default: false]
B:LogRawIncomingIRCLinesToConsole=true

}
`
https://twitchapps.com/tmi/ < Is the website that gives the oauth you need to use when you connect

I am failing hard to post the code in the right way

# Configuration file

~CONFIG_VERSION: 1

commands {
    #  [default: !]
    S:Prefix=!

    #  [default: true]
    B:Players=true
}

events {

    minecraft {
        #  [default: true]
        B:PlayerJoined=false

        #  [default: true]
        B:PlayerLeft=false

        #  [default: true]
        B:PlayerAchievement=true

        #  [default: true]
        B:PlayerMessage=false

        #  [default: true]
        B:PlayerMessage=false

        #  [default: true]
        B:PlayerAction=true

        #  [default: true]
        B:PlayerDeath=true

        #  [default: true]
        B:ServerMessage=true

        #  [default: true]
        B:ServerAction=true
    }

}

##########################################################################################################
# formats
#--------------------------------------------------------------------------------------------------------#
# Formatting tokens: {u} -> user, {c} -> channel, {m} -> message, {de} -> contextual death emoji
# Note that only tokens listed in the defaults are supported for each message!
##########################################################################################################

formats {

    minecraft {
        #  [default: <{u}> {m}]
        S:PlayerMessage=<{u}> {m}

        #  [default: * {u} {m}]
        S:PlayerAction=* {u} {m}

        #  [default: {m} ðŸŒŸ]
        S:PlayerAchievement={m} ðŸŒŸ

        #  [default: {m} {de}]
        S:PlayerDeath={m} {de}

        #  [default: {u} has joined the game]
        S:PlayerJoined={u} has joined the game

        #  [default: {u} has left the game]
        S:PlayerLeft={u} has left the game

        #  [default: Players online: {m}]
        S:PlayersOnline=Players online: {m}

        #  [default: There are no players online]
        S:PlayersOnlineNone=There are no players online
    }

}

general {
    # Inserts a zero-width character in to source usernames going from Minecraft to other services - commonly used to prevent unnecessary pings. [default: true]
    B:ObfuscateUserSourceFromMinecraft=true
}

This is the config.cfg

I've just tried this locally, and it appears the nickname is strictly case sensitive, and expects lowercasing. Could you try setting your nickname in irc.cfg to be lowercase please?

My bot name on twitch is BotDescolado, however on the irc.cfg I put the name all lowercase. like         S:Nickname=botdescolado
I put in uppercase here just to show where

Ok, I've found a couple of bugs, and I'll try the fixes on my own Twitch channel first.

If you need help testing just tell me. You can say on my twitch channel if Im online

I believe this is fixed in Thump-1.10.2-<IP_ADDRESS> - could you try this version please? https://ci.carrot.codes/job/Willow Chat/job/Thump/job/feature%252F1.10/lastSuccessfulBuild/artifact/build/libs/Thump-1.10.2-<IP_ADDRESS>.jar
If it works for you, I'll upload it to CurseForge.

Ill check, A moment please

It works! Now I receive the messages from IRC on Minecraft.
It still doesnt detect the words with RandomThings chat detector, but its better than not working. If possible, can you also fix the 1.7 version? I want to use it on infinity evolved too :)

I'm watching your stream, and the bug appears to be fixed, but the chat detector isn't detecting the message because they're sent to players specifically (so, only your client).
Doing it that way is the safest, and I'm not sure there's a way to make messages available to blocks like you want - feel free to open another bug to track it.

Is there a way to send commands directly to the game? Like when someone says !weather it does /weather clear?

Not currently. A command system is planned but probably not in the near future. It's made more for server links than Twitch interactivity, but it's nice that the basic chat functionality works!

Also, it would be too much work to backport to 1.7.10, sorry!

Thank you o/


Use common denomination for hashrate

Its pretty common to use a denomination like TH/s for hashrate. Whenever we show a hashrate, we should use the appropriate denomination (e.g. H/s, KH/s, MH/s, GH/s, TH/s). We should create a file for this in the utils folder so it can be easily reused. It should take a number an argument and return a string.

Can I work on it?

I think this issue pertains to challenge 2 and challenge 3. Currently challenge 3 is in the works with vinayak. Once he merges his pr, we can begin QA and see where we can address this issue specifically. Let's follow up on this then.

Hey Kevin. Circling back on this.
Right now we decided to show hashes in exponential form rather than TH/s. Reason for this is to visually show the scale to the user as they mine.
However in Ch. 3, there will be the ability for the player to click on the exponents to either toggle or display the appropriate H/s, KH/s, MH/s, GH/s, TH/s denominations.
I still think it'd be helpful to keep these in a util folder so we can easily reuse them in later chapters if needed in the UI. WDYT?

Yeah, I'm not sure we have any code right now that converts between the different units so we can add it later if we ever need it. Closing this for now.


Update core team info

This PR updates the contact info and members of the Core Team. The correspondin PR for ESMValCore is https://github.com/ESMValGroup/ESMValCore/pull/942

[x] CODE_OF_CONDUCT.md
[x] NOTICE - might need more revisions
[x] introduction.rst

@ESMValGroup/esmvaltool-coreteam The file NOTICE contains a list of recipes and institutes haveing the copyright. Do we want to keep this list? If so, this list needs some updates to also include more recent recipes.

@ESMValGroup/esmvaltool-coreteam The file NOTICE contains a list of recipes and institutes haveing the copyright. Do we want to keep this list? If so, this list needs some updates to also include more recent recipes.


proposal: Add some way to explore packages and structs inside.

Is there some way to get all the packages and subpackages in the standard library, and all the structs inside those packages?
Something like what: https://golang.org/pkg/  outputs, but in a parseable format such as json

Have you looked into the go doc and godoc commands?
If this is a proposal, it should propose something more specific. For example, adding JSON output to eithere of those tools (assuming there isn't yet such a feature) could be a proposal.

its clear go doc has the capability. Adding JSON output is what I'm referring to.

Well, the proposal is very short, so I'm making no assumptions as to what you meant.

Start with go list std (look at go help list for formatting info). Then feed that to go doc / godoc / go/doc or something else custom to match your exact needs.

thanks @josharian


naukri-link-added

Fixes Issue
Closes #2271
Changes proposed
It's a platform that helps you get the job and place the job
Screenshots

Note to reviewers
updated-description

Hi @parma1111. Your PR is off to a good start. The description of your chosen resource could use some work, so I provided some advice on how to improve it. :)

Now review the PR @CBID2

@rupali-codes
Deployment!

I can't access this website.

It works for me @aftabrehan

I guess it's an issue from my side. Feel free to merge it then.

@rupali-codes, we got a merge issue here

@rupali-codes, we got a merge issue here

what's it

@rupali-codes, we got a merge issue here

what's it

For some odd reason, we can't merge this Pull Request despite approving it.

@rupali-codes, we got a merge issue here

what's it

For some odd reason, we can't merge this Pull Request despite approving it.

what is it showing? screenshot please

@rupali-codes, we got a merge issue here

what's it

For some odd reason, we can't merge this Pull Request despite approving it.

what is it showing? screenshot please

Well, i don't know why is it showing this, but let me merge it for now


📝 added solution to "Parsing error"

I just added a step in the readme in case one gets an error while setting up the plugin.

Looks good. Thank you 😄


Rating exports as float value instead of integer

Rating exports as *.0 with trailing zero instead of whole number.
Will delve deeper into this.

I tested it, and this does not affect the data when uploaded to letterbox.


ProjectRequest and ProjectDtoImpl are missing the Note field

Maybe this should be a separate issue, but I've noticed ProjectRequest and ProjectDtoImpl are missing the Note field
Originally posted by @GEPatSeeker in https://github.com/Morasiu/Clockify.Net/issues/11#issuecomment-653082056

I'm happy to add this.
@Morasiu have you had any luck fixing Estimate?

This looks like an easy to fix problem.
Estimate is working on develop. I'm just out of time and will probably release new version soon (Saturday)

Notes added, along with relevant test

Fixes in PR #15


SPIKE: Define a DB Rollback Strategy for Cloud Environments

Currently there is no way to perform database rollbacks other than to manually generate the commands that liquibase would have run and to execute them manually. We can do better than this. This ticket is a SPIKE to determine what the SOP should look like, and will be followed up with a DevOps ticket to formalize this process

[ ] Develop a strategy and document it

[ ] Create a new ticket to implement it

Timebox: 1.5 days

Assumptions: we can't publicly expose a given database. Meaning, any solution needs to use an Azure resource that can talk to the DB - nothing from local machines or Github.
Potential solutions:

A write-up on how to use the Liquibase CLI from a VM to roll back a given DB
Using an Azure Function to use the Liquibase CLI to roll back a given DB

I think the following is probably the most maintainable/repeatable way to do this:

Start using tags for new changesets going forward; potentially backfill existing changesets as well?
Update the rollback workflows to accept a tag parameter (required? default value of most recent?)
Use the Liquibase CLI to generate a SQL changeset file to roll back to the provided tag value
Parameterize the spring.liquibase.changeLog setting to conditionally point to the file just generated
Deploy as normal - the rollback changeset will be executed instead of the standard db.changelog-master.yaml, rolling back to the specified tag in a cloud environment

Ticket created: #2177


HTML escape issue in mail alert

I was doing some tests with blind xss payload when i found this strange behaviour: using the following XSS sink and payload it is possible to escape the mail alert html:
Hello world !

I am <iframe src=<?php echo $_GET['xxx'];?>/>

Payload:
a'"></textarea>

Please note that it seems correctly escaped in the report page:

Fixed this in https://github.com/ssl/ezXSS/commit/0a6d380ad9b7c7f559af46a4de2bd294ae2160f1 :)
Thanks again.


take a peek at mine - fccvotingappwithtwitter

https://github.com/MatthiasLiszt/fccvotingappwithtwitter
Sorry, for abusing the issue function for that ...
plz, suggest a better way and I hope you can somehow erase this issue

Wow @MatthiasLiszt  that looks solid! If you want to present or talk about it at the FFC meetup let me know! Iam pretty sure that's interesting for a lot of people- especially FCC users.  Great work!
And no problem that you are using the issue here. I will update the whole repo soon :)


More consistent health check behavior

HealthCheck status is currently tracked via a mutable master InstanceInfo which can be set manually via ApplicationInfoManager or automatically through HealthCheckHandler.  This design gives rise to several race conditions since there is a circular dependency in setting the status.
This PR changes the behavior of InstanceInfo so that its status is only set via the InstanceInfoReplicator.  The status for ApplicationInfoManager is tracked internally instead of through the master InstanceInfo.  Using this new method the health check is only consulted if ApplicationInfoManager.getInstanceStatus() is UP.  Otherwise the status in ApplicationInfoManager is used.
There still exists the possibility for instance status info to be 'inconsistent' if client code sets the master InstanceInfo.setStatus() manually.  This is unavoidable given the current design without a more significant refactoring.

closing this for now.


First example is incorrect

When trying the same as the first example you have in your README.md file, calling $this->client->response->getBody()->getContent() returns "" in my test meaning the following does not work:
$this->client->get('/');
$this->assertEquals('Hello World', $this->client->response->getBody());

Your example code:
class VersionTest extends LocalWebTestCase
{
    public function testVersion()
    {
        $this->client->get('/version');
        $this->assertEquals(200, $this->client->response->getStatusCode());
        $this->assertEquals($this->app->config('version'), $this->client->response->getBody());
    }
}

We have our own version (replicated) of WebTestCase as we have our own config and setup process.
To get it working, our test make-up is the following:
    public function testHomePage()
    {
        $body = $this->client->get('/');
        $this->assertEquals(200, $this->client->response->getStatusCode());
        $this->assertContains('Hello world', $body);
        $this->assertContains('<title>Welcome</title>', $body);
    }

The main difference with mine is that I am assigning $body = $this->client->get('/'); as ::get calls ::request but ends with return (string)$this->response->getBody();.
Am I missing something or have the docs not been updated? I can PR on the fix in the docs providing I am not missing something first.

It will be next week before I can investigate this. I don't particularly like having to fetch into a temporary $body variable. It sounds like something else may be going on.

Hi @craig-davis, no worries. If I can get chance I will clone and see what I can find if that helps, but I too am pretty stretched out with spare time at the moment.

I've made you a contributor. If you're blocked by something, go ahead and be a responsible member of the group :)

@craig-davis thank you, much appreciated.


Refresh model in yii\rest\CreateAction ?

I have a model where I use TimestampBehavior like this:
[
'class' => TimestampBehavior::className(),
    'value' => new Expression('NOW()'),
]

This class is then extended from when creating a Rest API.
Now, when creating a new object using the API's default yii\rest\CreateAction a new object is created, but when returning the newly created object to the view-action all date-time attributes related to TimeStampBehaviour still show the unevaluated value: "object Expression('NOW()')".
If I insert "$model->refresh" after "$model->save()" in the run-action of yii\rest\CreateAction it works as expected, but that is obviously not the way to solve it.
Guess I could make another CreateAction or point to another ViewAction using the CreateAction->$viewAction parameter.
Or is this something that could be improved in yii\rest\CreateAction ?

Solved it by adding this to my API-model...
public function afterSave($insert, $changedAttributes) {
    $this->refresh();
}

Seemed like the easiest solution.

@qiangxue problem is still not solved both in CreateAction and UpdateAction. Proposal is to add refresh() call.

Adding refresh() to the framework by default would be waste of ressources when it is not needed. the solution proposed above, by adding it to afterSave() would be the way to go in such cases.

@cebe it could be tuneable with the action parameter and turned off by default. Solution above is not a good idea when you implement crud apis for tens of models. Model must not be responsible for the context of it's usage.


appimage-run: Fix type-1 support, used wrong directory

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

How can test this?

I found a way. Is a backport required?

Some Appimages will not work for users of 18.09. I don't know if that requires a backport, though it probably wouldn't hurt

There is a merge conflict when backporting I did not had a closer look.


kubernetes-helm: 2.10.0 -> 2.11.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/helm/versions.
meta.description for kubernetes-helm is: '"A package manager for kubernetes"'.

Checks done (click to expand)

built on NixOS
/nix/store/gf7w7csiw5rhrnwii1cvd8jmih74gr48-helm-2.11.0/bin/helm passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 2.11.0 with grep in /nix/store/gf7w7csiw5rhrnwii1cvd8jmih74gr48-helm-2.11.0
directory tree listing: https://gist.github.com/2817fd434f554420c714554ca384a59d
du listing: https://gist.github.com/7e91e67e680c279f43ac4ccb4891818b

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/bcd662dd02869203cda89a421f96d4bdc9a9d6d3.tar.gz -p kubernetes-helm
ls -la /nix/store/gf7w7csiw5rhrnwii1cvd8jmih74gr48-helm-2.11.0

cc @rlupton20 for testing.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: kubernetes-helm
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)
Attempted: kubernetes-helm
Partial log (click to expand)
  /nix/store/w9c9nx7hjicfrzkxlqpqv42w3kyv8ksc-helm-2.11.0.drv
building '/nix/store/zfspd0s9mi26sziicgnnwk054fw40f9r-helm-v2.11.0-darwin-amd64.tar.gz.drv'...

trying https://kubernetes-helm.storage.googleapis.com/helm-v2.11.0-darwin-amd64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 19.3M  100 19.3M    0     0  10.7M      0  0:00:01  0:00:01 --:--:-- 10.7M
fixed-output derivation produced path '/nix/store/kysy7axx7pnzscb25rhwj3m1rjjxps5v-helm-v2.11.0-darwin-amd64.tar.gz' with sha256 hash '03xb73769awc6dpvz86nqm9fbgp3yrw30kf5lphf76klk2ii66sm' instead of the expected hash '1l8y9i8vhibhwbn5kn5qp722q4dcx464kymlzy2bkmhiqbxnnkkw'
cannot build derivation '/nix/store/w9c9nx7hjicfrzkxlqpqv42w3kyv8ksc-helm-2.11.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/w9c9nx7hjicfrzkxlqpqv42w3kyv8ksc-helm-2.11.0.drv' failed

Success on x86_64-linux (full log)
Attempted: kubernetes-helm
Partial log (click to expand)
100 18.2M  100 18.2M    0     0  19.9M      0 --:--:-- --:--:-- --:--:-- 19.9M
building '/nix/store/bis12dhi920316fgbjhlgmpfa8s7pgk5-helm-2.11.0.drv'...
building
installing
linux-amd64/
linux-amd64/tiller
linux-amd64/README.md
linux-amd64/helm
linux-amd64/LICENSE
/nix/store/gf7w7csiw5rhrnwii1cvd8jmih74gr48-helm-2.11.0

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: kubernetes-helm
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: kubernetes-helm
Partial log (click to expand)
100 19.3M  100 19.3M    0     0  17.9M      0  0:00:01  0:00:01 --:--:-- 17.9M
building '/nix/store/8jqh8fiy8iv9x907mcfd8yf1c36hkxd8-helm-2.11.0.drv'...
building
installing
darwin-amd64/
darwin-amd64/tiller
darwin-amd64/README.md
darwin-amd64/helm
darwin-amd64/LICENSE
/nix/store/invvv9kpspw9xqzps6hny5ma4g6snrc0-helm-2.11.0

Success on x86_64-linux (full log)
Attempted: kubernetes-helm
Partial log (click to expand)
100 18.2M  100 18.2M    0     0  24.4M      0 --:--:-- --:--:-- --:--:-- 24.4M
building '/nix/store/bis12dhi920316fgbjhlgmpfa8s7pgk5-helm-2.11.0.drv'...
building
installing
linux-amd64/
linux-amd64/tiller
linux-amd64/README.md
linux-amd64/helm
linux-amd64/LICENSE
/nix/store/gf7w7csiw5rhrnwii1cvd8jmih74gr48-helm-2.11.0


Const ArcSwapOption doesn't update values

Hello, I am writing a program that uses a global ArcSwapOption<String>, but it seems the values I put into it aren't updated.
I call store to put something into it, but calling load afterwards still returns None.
A quick reproduction example: (you can run it directly with cargo script)
// cargo-deps: arc-swap="=1.5.0"
extern crate arc_swap;

use arc_swap::*;
use std::sync::Arc;

pub const SWAP: ArcSwapOption<String> = ArcSwapOption::const_empty();

fn main() {
    SWAP.store(Some(Arc::new("test".to_owned())));
    std::thread::sleep_ms(1000);
    dbg!(SWAP.load());
    dbg!(SWAP.load_full());
}

The program outputs...
[arc_swap_test.rs:12] SWAP.load() = None
[arc_swap_test.rs:13] SWAP.load_full() = None

...even though I clearly put the string test into the ArcSwapOption.
Am I doing something wrong here? Or is this a bug?

This is actually a weirdness of how const works, const is a compile time „bit pattern“ that can be copied any time it is used even though the type is not Copy. I'm not sure if I can prevent this trap from inside the crate in some way, I think (I'm not looking for it right now) it's even mentioned in the documentation somewhere to watch out for it.
Anyway, the solution is to use static SWAP: ... instead of const SWAP: ...

Ah I see, static fixed it. Thanks for the quick response.


Pinpoint grpc module netty channel executionerror occur is ok?

I use pinpoint 2.2.2.
Today I find agent log message like below.
INFO  c.n.p.g.c.ChannelzUtils
-- ExecutionError 5-Socket-7 io.netty.channel.ChannelException: getsockopt() failed: Protocol not available
is this no problem? only information?
OS is centos 6.

It's an information message.
If the agent calls getsockopt() when the socket is closed, a problem may occur.


Probe hanging without any error

Hi there,
I have a function that is used to upload images to S3
async function uploadToBucket(options={}) {
  Sentry.addBreadcrumb({category: 'async'})

  const {bucket, stream: body, file, extension, mimetype} = options
  const filename = filenameHandler(file, extension)

  const m = meter()
  const s3Stream = new stream.PassThrough()
  const dimensionStream = new stream.PassThrough()
  body
    .pipe(m)
    .pipe(s3Stream)

  body.pipe(dimensionStream)

  const {width, height} = await probe(dimensionStream)

  const s3Upload = await s3.upload({
    Bucket: bucket,
    Key: filename,
    Body: body,
    ContentType: mimetype,
  })
    .promise()
    .then(res => {
      return {
        filename,
        mimetype,
        size: m.bytes,
        width,
        height
      }
    })
    .catch(error => {
      logger.error(`S3 Failed: ${error}`)
    })

  return s3Upload
}

This has been working well with basically anything we've thrown at it. Except for this one image that wouldn't get uploaded. After some debugging I saw that the line where the upload to S3 is actually done would never be reached. Commenting out const {width, height} = await probe(dimensionStream) would make the upload work.
I tried wrapping probe in a try/catch block but to avail as no error is thrown. Probe just seems to be hanging. Any idea of what may be happening?
FYI this is the image that is creating this issue

node ./support/dump.js https://user-images.githubusercontent.com/4171627/119978058-748a2e80-bfb9-11eb-85e2-0e4b337ac276.jpg
https://user-images.githubusercontent.com/4171627/119978058-748a2e80-bfb9-11eb-85e2-0e4b337ac276.jpg: {
  width: 1200,
  height: 627,
  type: 'jpg',
  mime: 'image/jpeg',
  wUnits: 'px',
  hUnits: 'px',
  orientation: 1,
  length: 1007537,
  url: 'https://user-images.githubusercontent.com/4171627/119978058-748a2e80-bfb9-11eb-85e2-0e4b337ac276.jpg'
}

Can not reproduce.

Closing as not reproducible / stale.
If you have more info - feel free to add anytime to reopen.


Update TemporaryDrawer.js

Pretty sure this needs to be onRequestClose for the overlay click to close the drawer

@kpennell Thanks for taking the time to submit a PR, however even though 'onRequestClose' is more technically correct for controlled components (it's fired when the component wants to close, not when it closes), it was changed to onClose for brevity in PR https://github.com/mui-org/material-ui/pull/9451.
Is there something not working with that demo?

We have renamed the property in #9451.

It could be just some bungled way I setup my child component (calling the parent function from the app navbar child component). But changing to onRequestClose allowed the overlay to close the right drawer.

What version do you have installed?

"material-ui": "^1.0.0-beta.22",

On Thu, Dec 28, 2017 at 3:28 PM, Matt Brookes<EMAIL_ADDRESS>wrote:

What version do you have installed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/pull/9660#issuecomment-354373937,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAuIdHDh4o6hTtQnZrcZlgMg6s9kG4Pks5tFCQEgaJpZM4ROvSs
.

That's why. 👍

Aha! Aha! should be [image: npm package]
https://www.npmjs.org/package/material-ui?
On Thu, Dec 28, 2017 at 3:29 PM, Matt Brookes<EMAIL_ADDRESS>wrote:

That's why. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/pull/9660#issuecomment-354374034,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAuIaKYJz9KvtYuXnR4vlyyUsqvTZBYks5tFCRSgaJpZM4ROvSs
.

25?
On Thu, Dec 28, 2017 at 3:33 PM, Kyle Pennell<EMAIL_ADDRESS>wrote:

Aha! Aha! should be [image: npm package]
https://www.npmjs.org/package/material-ui?
On Thu, Dec 28, 2017 at 3:29 PM, Matt Brookes<EMAIL_ADDRESS>wrote:

That's why. 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mui-org/material-ui/pull/9660#issuecomment-354374034,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABAuIaKYJz9KvtYuXnR4vlyyUsqvTZBYks5tFCRSgaJpZM4ROvSs
.

You can track beta releases here: https://github.com/mui-org/material-ui/releases (Or follow @MaterialUI on twitter.


Prevent stripping the edges of strings when using Find in Files

Edit: Fixes https://github.com/godotengine/godot/issues/48464
Why would Find in Files remove trailing whitespaces from the string? Users want to search for exactly what they typed.
Didn't add special case for trimming when Whole Words is checked. Still, the new behavior is consistent with that of the Find & Replace bar. In fact, we should probably unify their functionality somehow to avoid such inconsistencies in the future?

See also existing PR https://github.com/godotengine/godot/pull/48596

Ah, yeah that's the same thing. I didn't find related issues but forgot to look for related PRs. Should probably close this as there's a better fix?

Thanks!

Cherry-picked for 3.6.


feat: deprecated URI generator

deprecated URI generator code

The IRI generator is available at Maven Central as
implementation("zone.cogni.semanticz:irigenerator:1.0.1")


Error while resolving packages: com.daltonlima.core

Hello, sorry, I would like to open your project on GitHub but when I download the .Zip it gives me some errors in Unity when I open it, could you tell me how I can download and open the project safely without giving me errors?

Hi,
What Unity version are you using? Currently the project is using Unity 2020.2.1f1. You could try using this same version if you are new to Unity.
Look here for the older versions https://unity3d.com/get-unity/download/archive
Otherwise you need to provide more details about the error.

Thank you very much for answering I thought you would not :c
Look at these are the problems I have and I don't have much experience in unity either so if you help me I would appreciate it a lot and a thousand times thanks for your help seriously...

Thank you for the interest in the project! The error says that we need a dependency (some extra code) that couldn't be imported.
You need to install git on your machine (Unity requires that for downloading those packages). Maybe a restart is needed, then try to import the project again.
https://git-scm.com/
By the way, if you are interested in programming (for Unity or in general) I recommend you to learn at least the basics of Git.
Let me know how it goes.

Thank you very much I managed to open it now and a curiosity I would like to be able to control the two characters at the same time either on the same device or locally in lan or bluetooth like other games I do not know if you understand me and if so, could you help me with it with a advice or guide? Poss data I think about bringing the game to the Android platform

I'll close this ticket as the problem was solved before. And even now in the current version, I removed that external package dependency for simplicity's sake.
It is possible to extend the project to multiplayer controllers, as the code was built with that possibility in mind, as the swap player avatars can show. It should be a matter of binding controllers.
For feature requests, such as multiplayer support or mobile port, feel free to open specific tickets for that. Even though I don't have plans to further develop this game. I am considering making some videos on YouTube to talk about the project and do some basic updates on it.


Publish extension to Open VSX Repo?

Discussed in https://github.com/microsoft/vscode-python/discussions/16730

Originally posted by clin1234 July 20, 2021
For the sake of VSCodium users, please be generous in the spirit of open-source and also publish it in Open VSX?

Cool, already 9/5 upvotes provided.

Do note this repository is open source and under an MIT license, so anyone can fork this repo and publish on Open VSX w/o us (people already do this for Vim).

Totally, but it is obviously "better" to not create unnecessary forks or build the complete repo regularly to just check "maybe there is a new version to publish".

@GitMensch we publish on the same day as VS Code does for major releases (which is roughly once a month; there isn't a release of VS Code in the month of January).  We also create an issue under the https://github.com/microsoft/vscode-python/labels/release plan label for all major releases (and we pin them to the top of our issue tracker here).
We also publish all releases to https://github.com/microsoft/vscode-python/releases, so you can subscribe to this repo and choose to only be notified when we make a new release, big or small.
We also create release branches for all major versions.

So, is this a "no, please use some CI to publish to open-vsx" (after asking for enough upvotes to do this)?

@GitMensch I don't know as I have not discussed this with anyone (I transferred 59 discussions to issues, so I did not filter what got moved over; every created issue got the same comment with no judgement on the merit of the feature request). But do note the message says, "If there's enough upvotes then we will consider this feature request in our future planning", not that we would definitively take it if there was enough votes.
But you specifically said you didn't want to "build the complete repo regularly to just check 'maybe there is a new version to publish'", and so I gave you multiple ways of how to check if there's an update w/o creating a VSIX. I was just trying to be helpful, not send some coded message.

Thanks for the follow-up. In general I'd also like to see an "official" publishing, but I have no problem to wait for the final decision on that - it is good that you've created an issue to track this.

Thanks for everyone who voted, but after thinking this over we have decided to not proceed with supporting Open VSIX. Having to support another Marketplace would also mean needing to directly support that Marketplace's users and we are not prepared to take on that increase support requirements of supporting e.g. Theia.
That being said, the extension is and will continue to be open source, and so anyone wanting to upload their own VSIX is welcome to do so as long as the MIT license is met.


Is the library avoiding C++11 on purpose?

There's a number of things in this library that could be improved by using C++11 features (e.g. using constexpr float pi instead of #define M_PI, using alignas instead of #pragma pack, using scoped enumerations), but before I raised any of those things as issues I wanted to check - is there a particular reason why C++11 features are being (or at least appear to be) avoided?

Not at all- we're just used to a different paradigm of C/C++ so we're still catching up with C++11 (yes I know it's nearly a decade old at this point). We'll keep this in mind!

alignas isn't quite the same as #pragma pack.

alignas isn't quite the same as #pragma pack.
I've checked and you're quite right, they are related but not equivalent.

In this case the usage I referred to is slated for removal so ultimately that example is probably redundant anyway.


tf.test.is_gpu_available return False

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Amazon Linux 2 AMI
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): pip3
TensorFlow version:tensorflow-gpu-1.14.0
Python version:3.7.3
Installed using virtualenv? pip? conda?:pip3
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:10.1
GPU model and memory:Nvidia Tesla K80, 11441MiB

Describe the problem
tf.test.is_gpu_available returns Flase
Provide the exact sequence of commands / steps that you executed before running into the problem
python3
import tensorflow as tf
tf.test.is_gpu_available()
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

I removed CUDA 10.1 and reinstalled 10.0 but the error persists

@aspenlin Please check software requirements for Cuda10 here.
Software requirements
The following NVIDIA® software must be installed on your system:

NVIDIA® GPU drivers —CUDA 10.0 requires 410.x or higher.
CUDA® Toolkit —TensorFlow supports CUDA 10.0 (TensorFlow >= 1.13.0)
CUPTI ships with the CUDA Toolkit.
cuDNN SDK (>= 7.4.1)
(Optional) TensorRT 5.0 to improve latency and throughput for inference on some models.

Looking at error trace, I strongly feel CUDA drivers were not compatible to load CUDA10. Tensorflow correctly detects your GPU, but cuDNN you have is 3.7 (major 3 and minor 7) where as the requirements say it is compatible with >=7.4.1. I would say, please check NVIDIA drivers you have installed. It requires >= 410.48. Please check table 1 in this NVIDIA resource. Thanks!
CUDA 10.0 | >= 410.48

Yep you are right. Somehow AWS installs CUDA for you but some of the libraries are missing. I solved the problem by 'sudo yum install cuda-libraries-10-0' and install new cudnn. And now tensorflow.test.is_gpu_available() returns True!

@aspenlin Thanks for posting solution here as it will help other users. Thanks again.

I'm running 441.08, which is >= 410.48 with Cuda compilation tools, release 10.0, V10.0.130 and tensorflow 2.0.0 yet, despite having 2 1070 GPUs, is_gpu_available == False:
In [3]: tf.test.is_gpu_available()
2019-12-09 16:50:55.953081: I tensorflow/core/platform/cpu_feature_guard.cc:145] This TensorFlow binary is optimized with Intel(R) MKL-DNN to use the following CPU instructions in performance critical operations:  AVX AVX2
To enable them in non-MKL-DNN operations, rebuild TensorFlow with the appropriate compiler flags.
Out[3]: False


nbterm - new notebook not starting with any kernel (it seems)

When I use nbterm new_notebook.ipynb it displays a notebook but when I try to run something in the cell like 2+2 it just shows that it's executing but nothing seems to happen, I doubt if it's because no Kernel is initialized ?
I've multiple kernels like R, python and Jupyter notebook usually initializes with Python.

Probably my assumption is wrong, when I run it with no-kernel nothing happens like executing. so it's something else.

Just to add, If I open an existing jupyter notebook (Python kernel) it works just fine.

I'm wondering what are these ^Z^Z in you cell, maybe it's because of that?

No that was actually me trying to figure out different options to exit as Ctrl+q wasn't working as well

Did you get any error message when starting nbterm (before seeing the notebook)?
Did you exit the cell (with Esc) before you run (Ctrl-r)?

Did you get any error message when starting nbterm (before seeing the notebook)?
Did you exit the cell (with Esc) before you run (Ctrl-r)?

I got an error message.
│Exception ignored in: <function Socket.__del__ at 0x000001609E8D8C10>                                     │ Traceback (most recent call last):───────────────────────────────────────────────────────────────────────────────────┘   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\zmq\sugar\socket.py", line 67, in __del__    self.close()   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\zmq\_future.py", line 160, in close     self._clear_io_state()   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\zmq\asyncio\__init__.py", line 60, in _clear_io_state     self.io_loop.remove_reader(self._fd)   File "c:\users\dell\appdata\local\programs\python\python38\lib\asyncio\events.py", line 504, in remove_reader     raise NotImplementedError NotImplementedError:

I just installed nbterm and I have the same issue including "ctrl-q" not working.

Existing notebooks are also not running
Traceback (most recent call last):   File "c:\users\dell\appdata\local\programs\python\python38\lib\runpy.py", line 194, in _run_module_as_main     return _run_code(code, main_globals, None,   File "c:\users\dell\appdata\local\programs\python\python38\lib\runpy.py", line 87, in _run_code     exec(code, run_globals)   File "C:\Users\dell\AppData\Local\Programs\Python\Python38\Scripts\nbterm.exe\__main__.py", line 7, in <module>   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\nbterm\nbterm.py", line 43, in cli     typer.run(main)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\typer\main.py", line 859, in run     app()   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\typer\main.py", line 214, in __call__     return get_command(self)(*args, **kwargs)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\click\core.py", line 829, in __call__     return self.main(*args, **kwargs)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\click\core.py", line 782, in main     rv = self.invoke(ctx)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\click\core.py", line 1066, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\click\core.py", line 610, in invoke     return callback(*args, **kwargs)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\typer\main.py", line 497, in wrapper     return callback(**use_params)  # type: ignore   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\nbterm\nbterm.py", line 29, in main     nb = Notebook(notebook_path, no_kernel=no_kernel or False, save_path=save_path)   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\nbterm\notebook.py", line 61, in __init__     self.read_nb()   File "c:\users\dell\appdata\local\programs\python\python38\lib\site-packages\nbterm\format.py", line 13, in read_nb     self.json = json.load(f)   File "c:\users\dell\appdata\local\programs\python\python38\lib\json\__init__.py", line 293, in load     return loads(fp.read(),   File "c:\users\dell\appdata\local\programs\python\python38\lib\encodings\cp1252.py", line 23, in decode     return codecs.charmap_decode(input,self.errors,decoding_table)[0] UnicodeDecodeError: 'charmap' codec can't decode byte 0x90 in position 3556: character maps to <undefined>

After installation under python 3.9.5 it does not run cells in a new notebook nor in existing notebooks. The status line says
python3 (busy)


Update GO to 1.19 and format code

Description
Update GO to 1.19 and format code
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/491

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[ ] I have inspected the Grafana dashboards to verify the data is displayed properly
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[ ] make check test

Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources

[ ] Yes
[x] No

allowedlist.yaml is temporarily added to address vulnerability  CVE-2022-27664.

run e2e test

run e2e test


Fix missing link for management between cluster tier manager entity and cluster tier entities (server stores)

all tests pass locally

@ljacomet @anthonydahanne : unstable test!

test this please

waiting for 5.2.0-pre15 release...

test this please


Consider reducing account ID size to 60 bits

Currently, account ID requires 64 bits. This doesn't cleanly map to number of characters needed for base32 or base64 encoding. However, if we change the number of bits to 60, we'd get the following:

base16: 15 chars.
base32: 12 chars.
base64: 10 chars.

Making this change should be pretty straight-forward: we can require that the 4 least significant bits of account ID are zeros. Since this will require additional work, we can reduce PoW requirements on railing zeros of account seed hash.

I like this proposal.  Having a 10 character representation of an account ID will be good for user experience.

I believe we can still support the encoding for 64 bits, even though it doesn't cleanly map, by interpreting the missing bits of the last base 64 element as 0's. This would result in an additional character count e.g. base64: 11 chars.

Superseded by #140.


server disconnecter (code: 1006)

I run the container successfully.
i see the web interface but i get a "server disconnected (code: 1006)" when hovering the cursor over the X , near the logo.
tried to add code to the nginx.conf, as described in the instruction - but that did not help.
i am running the docker over Ubuntu 18.04
I

s there something to do ?

Did you try with to clear your browser cache?  Do you have the same issue with another browser?

Cleared the cache in Edge browser and still not seeing the menu.
Tried in Google Chrome and seeing

Microsoft Edge: cleared the cache and still not working.
Firefox and Chrome: working great !
Thanks.


Clang format check

Adds clang-format check to the tests.
Also required to reformat some files with the included settings so that the test passes.

Thanks @miguelprada.
Used a regular merge to retain the two separate commits.


Enable user configurable section ordering

Currently, the sections are ordered: General User Stats, Repository Stats, Contribution Stats, and Language chart.
Provide an input to action enabling user to change the section ordering.

Closed by #33


Create options struct for logging initialization

What does this PR change?
The struct contains the previous PFlag options from
InitLoggingFromFlags, plus a new option to disable the all-level "Log
level set to XYZ" message on completion of initialization.
Does this PR relate to any other PRs?

Used by, and tested in, https://github.com/kubecost/kubectl-cost/pull/119

How will this PR impact users?
N/A
How was this PR tested?
Tested by building cost-model with standard options and observing the
expected "Log level set to info" message and by updating kubectl-cost to
use the new DisableLogLevelReportMessage flag and observing the expected
lack of the "Log level set to XYZ" message.
Does this PR require changes to documentation?
N/A

Closing in favor of https://github.com/kubecost/opencost/pull/1262


when preparing upgrade tests, wait for others to notice up

trying this change out here: http://cassci.datastax.com/view/Parameterized/job/upgrade_tests-all-custom_branch_runs/5/


error: failed to verify the checksum of flate2 v1.0.24

Trying to build a project on my work PC that forced me to set my check-revoke = false due to IT sniffing our HTTPS packages with a custom SSL certificate. After doing this I keep getting a checksum failure for flate2 v1.0.24. I tried downgrading to 1.0.20 but got the same issue. Is there a way to bypass the checksum or figure out why flate2's checksum is failing when other packages aren't? I tried doing this on a windows 10 machine and then once again on a docker image based off of ubuntu and got the same error each time. Oddly enough on my non-work PC running windows 11 flate2 gets downloaded and everything is happy.

I have the same error in the same context ($env:CARGO_HTTP_CHECK_REVOKE = 'false'). Are there any updates on the issue?

Could someone provide steps to reproduce the issue? The docker image @mstumpf585 used might be helpful to debug.

So a colleague of mine was able to figure out what was wrong. Apparently Cisco blocked the download which would lead to a checksum failure. We had to raise an issues with IT and we double checked the crate for vulnerabilities and we unblocked it. @JeroenKnoops please feel free to add to this if you have any other information.

Indeed. The crate was unrightfully marked as malware. Now it's unblocked in Cisco Umbrella.

I guess I'll close this out since it was an issue on our end.


Generate fast paths for LdSuper, LdSuperCtor, and SetHomeObj

Generate fast paths for LdSuper, LdSuperCtor, and SetHomeObj
Replace lowerer code that generate helper calls with code that generate fast paths
for these opcodes. The goal is to improve performance of jitted code for class methods
with super dot property access, class constructors with super calls, and class
instantiation operations.

This is for https://github.com/Microsoft/ChakraCore/issues/26

@boingoing @rajatd @MikeHolman @pleath @abchatra
Could you take a look pls?

Rest looks good

@rajatd Thanks. All updated.

@boingoing @MikeHolman @pleath @abchatra
Any comment?


Not all boost source files included?

So I wanted to see if I could compile the driver myself - and it seems as if you're using "boost" (whose website is confusing, as it's libraries for the sake of libraries? What is the purpose of boost?), but I get a bunch of "cannot open source file" errors when compiling, due to missing files.

No they aren't included, that's the main idea behind a library. What platform are you on?

Same Problem, I checked the gitignore, looks like the author ignored some boost files.

Same Problem, I checked the gitignore, looks like the author ignored some boost files.

Also the libCurl
libcurl\x64\Release\libcurl.lib


DOJO(admin) Manage exercises tab

Create this page https://www.figma.com/file/f9xRyl1bJOjtBRd8zFORzg/c0d3?node-id=204%3A4588
Things need to be done before creating the page:

Create the Exercise card
Create a search/filtering input
Add flagged and flaggedReason columns to the Exercise model

Figma is good.

Filtering box and pagination are what's remaining.


CTRL+C does not exit tests in watch mode

Describe the bug
When I am running tests in watch mode and make some minor changes in the test files, after a while, vitest can not exit watch mode. Hitting CTRL+C multiple times does not work either. I tried to isolate the problem, but strangely this only happens when some tests are run together.
Running vitest with pnpm run test:server or pnpm run test:native does not make vitest hang. But running pnpm run test:only which is a combination of both previous tests makes vitest hang after a while. In the only-native.spec.ts file I am using Fastify native, in the only-server.spec.ts file Fastify is completely mocked out.
Reproduction
fastify-vitest-shutdown
System Info
System:
    OS: Linux 5.15 Ubuntu 22.04.3 LTS 22.04.3 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD Ryzen 7 5700G with Radeon Graphics
    Memory: 15.87 GB / 30.73 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.8.0 - ~/.nvm/versions/node/v20.8.0/bin/node
    npm: 10.1.0 - ~/.nvm/versions/node/v20.8.0/bin/npm
    pnpm: 8.14.0 - ~/.local/share/pnpm/pnpm
  Browsers:
    Chrome: 120.0.6099.216
  npmPackages:
    vite: ^5.0.11 => 5.0.11
    vitest: ^1.2.0 => 1.2.0

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I tried the reproduction case on Github Codespaces but wasn't able to reproduce the issue.

make some minor changes in the test files

Could you write down more specific steps describing what exactly has to be changed in test files?

I mean any changes which trigger a reload of the test watcher, like changing one letter in a test description or making a change for a test to fail. I also could not reproduce the failure on github codespaces, but realized that this happens on my machine only when node is version 20 or 21. With node 16 or 18 I can not reproduce this behavior. I also wiped the whole pnpm file cache and reinstalled everything but it did not make any change.

I am also seeing this (and have been for a number of weeks) but I am struggling to narrow down what exactly causes the issue.
For me, I start vitest with the vitest command and all is well for a short while. However, after a few minutes of making changes to my code, the test watcher becomes unresponsive and I can't quit using q or crtl-c. I have to close the terminal instance and then issue a SIGSTOP to kill the underlying process. The offending process is also running at 100% CPU when the problem occurs.
I am on node 20, using Kitty terminal emulator on OSX. Vitest v1.

I created a Dockerfile in which I can reproduce the same error. I added it to my repository. If I build and run the Dockerfile and connect to it from two terminals, then I can run pnpm run test:only in one terminal and edit the statusCode to be 20 with vim src/only-native.spec.ts, than after saving the file, the test runner hangs in the other terminal.

I can reproduce this issue using the provided Dockerfile. Is fastify or some of your dependencies using Node's native fetch? It seems that as soon as I switch Vitest to use --pool=forks the issue goes away.

I am not using in any way fetch from node. What cached my eyes is that the @types/node for version 20 imports the undici-types package. The version for node 18 does not import this package. But this package contains only types. When I use node prior to version 20 or  set the flag --pool=forks this issue does not happen.

What cached my eyes is that the @types/node for version 20 imports the undici-types package. The version for node 18 does not import this package.

The types for node 18 do as of more recent versions; this is definitely unrelated to the issue.

I am not using in any way fetch from node.

It's possible that the root cause of https://github.com/nodejs/undici/issues/2026 that makes node:worker_threads stuck is not directly fetch - it could be other module like ReadableStream or similar. Maybe one of your dependencies is using those.

I mocked all dependencies out, except the package effection, which imports nothing from any other package. It is still the same issue.

I tried to make a minimal reproduction. When I remove one of the following things than it seems not to fail (with this minimal example it can take many repeated changes before it hangs):

kysely which is not used in the function
yield* createPool(...);
Remove any of the fastify.register(routesBenchmark) or fastify.register(routesScope)
fastify.addSchema(schemas)

fastify-vitest-shutdown

not in watch mode, but when using javascript debug terminal, i guess its more or less same issue
https://github.com/vitest-dev/vitest/issues/5039


Split XChange core repo and each xchange in multiple repos

As this project is getting bigger, it would be great to split it in multiple repos, using git submodule for linking the core superproject to each xchange implementation repo.

this would make core refactors much harder to work with (multiple PRs instead of one) and implementatiosn would fall out of sync fast
all pain but I see no gains from this approach


Site Support Request: rtp.pt

Checklist

[x] I'm reporting a new site support request
[x] I've verified that I'm running youtube-dl version 2019.05.20
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that none of provided URLs violate any copyrights
[x] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://www.rtp.pt/play/p4897/a-guerra-dos-abismos
Single video: https://www.rtp.pt/play/p4897/e409009/a-guerra-dos-abismos

Description

This was closed without any comment, see #20484


Doesn't detect gulpfile in open folder

Created as requested.

started gulp-app
opened folder.
checked menu / watched output.
After bringing the window into focus a couple more times it seemed to get it.

After found it listed multiples of my build task.  No additional console logs to associate with behavior.
Like mentioned elsewhere i'd suggest ditching this method.  Its cool... but doesn't work well.  Doesn't stay locked etc.

Closing as this app is now deprecated.

Closing as this app is now deprecated.


Minor fix: redundant default parameters

What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
No needed
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing

Thanks


_app_list cannot return entire list of apps

The way that the ios_app_list and android_app_list work cannot return the entire list of apps because the API can return a subset of the apps.
To fix this, the nextPageToken should be reviewed and the API should be called again with that token.

https://github.com/AckeeCZ/fastlane-plugin-firebase_management/pull/3
Hopefully this can be merged soon. Until then I'm going to have gem read from https://github.com/tmaly1980/fastlane-plugin-firebase_management/tree/patch-1

Resolved in #3. Thanks you guys 👍

Please release version 1.0.2 with the fix. Thanks!

Please release version 1.0.2 with the fix. Thanks!

✅