Remove "final" keyword and make methods protected.

This adds extensibility to the API and makes custom implementation
of the server possible.

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +1.1% +2.59Ki [None]                                                                               +6.83Ki  +0.1%
      +1.2% +2.50Ki [Unmapped]                                                                           +6.73Ki  +0.1%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
       +25%      +8 vtable for grpc::CompletionQueue                                                          +8   +25%
       +25%      +8 vtable for grpc::ServerCompletionQueue                                                    +8   +25%
  +0.4%    +140 src/cpp/server/server_cc.cc                                                             +140  +0.4%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
       +34%     +47 grpc::Server::SyncRequestThreadManager::Wait                                             +47   +34%
      +3.7%     +41 grpc::Server::ShutdownInternal                                                           +41  +3.7%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.8%     +15 grpc::Server::Server                                                                     +15  +0.8%
      +2.5%      +6 [Unmapped]                                                                                +6  +2.5%
  +1.5%     +67 src/cpp/client/channel_cc.cc                                                             +67  +1.5%
      [NEW]     +67 grpc::CompletionQueue::Next                                                              +67  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

  +0.8% +2.86Ki TOTAL                                                                                +7.09Ki  +0.1%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +1.1% +2.59Ki [None]                                                                               +6.83Ki  +0.1%
      +1.2% +2.50Ki [Unmapped]                                                                           +6.73Ki  +0.1%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
       +25%      +8 vtable for grpc::CompletionQueue                                                          +8   +25%
       +25%      +8 vtable for grpc::ServerCompletionQueue                                                    +8   +25%
  +0.4%    +140 src/cpp/server/server_cc.cc                                                             +140  +0.4%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
       +34%     +47 grpc::Server::SyncRequestThreadManager::Wait                                             +47   +34%
      +3.7%     +41 grpc::Server::ShutdownInternal                                                           +41  +3.7%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.8%     +15 grpc::Server::Server                                                                     +15  +0.8%
      +2.5%      +6 [Unmapped]                                                                                +6  +2.5%
  +1.5%     +67 src/cpp/client/channel_cc.cc                                                             +67  +1.5%
      [NEW]     +67 grpc::CompletionQueue::Next                                                              +67  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

  +0.8% +2.86Ki TOTAL                                                                                +7.09Ki  +0.1%

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                      cpu_time    real_time
---------------------------------------------  ----------  -----------
BM_PumpStreamServerToClient<InProcess>/262144  -5%         -5%

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
   +14%     +80 src/cpp/common/completion_queue_cc.cc                                                    +80   +14%
      [NEW]     +67 grpc::CompletionQueue::Next                                                              +67  [NEW]
       +43%     +13 [Unmapped]                                                                               +13   +43%
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

 -------------- SHRINKING                                                                            --------------
  -0.3%    -104 src/cpp/server/server_cc.cc                                                             -104  -0.3%
      [DEL]    -194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -194  [DEL]
     -10.9%    -121 grpc::Server::ShutdownInternal                                                          -121 -10.9%
     -26.8%     -37 grpc::Server::SyncRequestThreadManager::Wait                                             -37 -26.8%
      -2.3%      -8 grpc::ServerInterface::GenericAsyncRequest::GenericAsyncRequest                           -8  -2.3%
      -3.8%      -8 grpc::ServerInterface::RegisteredAsyncRequest::IssueRequest                               -8  -3.8%
      -5.2%      -8 grpc::Server::AddListeningPort                                                            -8  -5.2%
      -1.4%      -3 grpc::Server::InProcessChannel                                                            -3  -1.4%
     -37.5%      -3 grpc::Server::server                                                                      -3 -37.5%
     -37.5%      -3 grpc::Server::c_server                                                                    -3 -37.5%
  -0.4%     -16 src/cpp/client/channel_cc.cc                                                             -16  -0.4%
      -2.4%     -16 grpc::Channel::WaitForStateChangeImpl                                                    -16  -2.4%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  +1.1% +2.61Ki [None]                                                                                -939  -0.0%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
       +23%     +24 [None]                                                                                0  [ = ]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
       +25%      +8 vtable for grpc::CompletionQueue                                                          +8   +25%
       +25%      +8 vtable for grpc::ServerCompletionQueue                                                    +8   +25%

  +0.7% +2.63Ki TOTAL                                                                                -912  -0.0%

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                           cpu_time    real_time
------------------------------------------------------------------  ----------  -----------
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/2  -5%         -5%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.3%    +594 [None]                                                                               +33.9Ki  +0.7%
      +0.2%    +475 [Unmapped]                                                                           +33.8Ki  +0.7%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
       +23%     +24 [None]                                                                                0  [ = ]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
       +25%      +8 vtable for grpc::CompletionQueue                                                          +8   +25%
       +25%      +8 vtable for grpc::ServerCompletionQueue                                                    +8   +25%
   +14%     +80 src/cpp/common/completion_queue_cc.cc                                                    +80   +14%
      [NEW]     +67 grpc::CompletionQueue::Next                                                              +67  [NEW]
       +43%     +13 [Unmapped]                                                                               +13   +43%
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

 -------------- SHRINKING                                                                            --------------
  -0.2%     -69 src/cpp/server/server_cc.cc                                                              -69  -0.2%
      [DEL]    -194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -194  [DEL]
     -10.6%    -118 grpc::Server::ShutdownInternal                                                          -118 -10.6%
     -26.8%     -37 grpc::Server::SyncRequestThreadManager::Wait                                             -37 -26.8%
  -0.4%     -16 src/cpp/client/channel_cc.cc                                                             -16  -0.4%
      -2.4%     -16 grpc::Channel::WaitForStateChangeImpl                                                    -16  -2.4%

  +0.2%    +656 TOTAL                                                                                +34.0Ki  +0.7%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.3%    +594 [None]                                                                               +33.9Ki  +0.7%
      +0.2%    +475 [Unmapped]                                                                           +33.8Ki  +0.7%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
       +23%     +24 [None]                                                                                0  [ = ]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
       +25%      +8 vtable for grpc::CompletionQueue                                                          +8   +25%
       +25%      +8 vtable for grpc::ServerCompletionQueue                                                    +8   +25%
   +14%     +80 src/cpp/common/completion_queue_cc.cc                                                    +80   +14%
      [NEW]     +67 grpc::CompletionQueue::Next                                                              +67  [NEW]
       +43%     +13 [Unmapped]                                                                               +13   +43%
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

 -------------- SHRINKING                                                                            --------------
  -0.2%     -69 src/cpp/server/server_cc.cc                                                              -69  -0.2%
      [DEL]    -194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -194  [DEL]
     -10.6%    -118 grpc::Server::ShutdownInternal                                                          -118 -10.6%
     -26.8%     -37 grpc::Server::SyncRequestThreadManager::Wait                                             -37 -26.8%
  -0.4%     -16 src/cpp/client/channel_cc.cc                                                             -16  -0.4%
      -2.4%     -16 grpc::Channel::WaitForStateChangeImpl                                                    -16  -2.4%

  +0.2%    +656 TOTAL                                                                                +34.0Ki  +0.7%

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                                              cpu_time    real_time
-------------------------------------------------------------------------------------  ----------  -----------
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/262144                   -6%         -6%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/0  -6%         -6%

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.1%    +186 [None]                                                                               +30.3Ki  +0.6%
      +0.1%    +172 [Unmapped]                                                                           +30.3Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
       +23%     +24 [None]                                                                                0  [ = ]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
       +25%      +8 vtable for grpc::ServerCompletionQueue                                                    +8   +25%
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

 -------------- SHRINKING                                                                            --------------
  -0.2%     -69 src/cpp/server/server_cc.cc                                                              -69  -0.2%
      [DEL]    -194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -194  [DEL]
     -10.6%    -118 grpc::Server::ShutdownInternal                                                          -118 -10.6%
     -26.8%     -37 grpc::Server::SyncRequestThreadManager::Wait                                             -37 -26.8%
  -0.4%     -16 src/cpp/client/channel_cc.cc                                                             -16  -0.4%
      -2.4%     -16 grpc::Channel::WaitForStateChangeImpl                                                    -16  -2.4%

  +0.0%    +168 TOTAL                                                                                +30.3Ki  +0.6%

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +381 [None]                                                                               +40.1Ki  +0.8%
      +0.1%    +302 [Unmapped]                                                                           +40.0Ki  +0.8%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.2%     +80 src/cpp/server/server_cc.cc                                                              +80  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.8%     +15 grpc::Server::Server                                                                     +15  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

  +0.1%    +528 TOTAL                                                                                +40.2Ki  +0.8%

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +381 [None]                                                                               +31.8Ki  +0.6%
      +0.1%    +302 [Unmapped]                                                                           +31.8Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.2%     +80 src/cpp/server/server_cc.cc                                                              +80  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.8%     +15 grpc::Server::Server                                                                     +15  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%

  +0.1%    +528 TOTAL                                                                                +32.0Ki  +0.6%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +365 [None]                                                                               +31.5Ki  +0.6%
      +0.1%    +286 [Unmapped]                                                                           +31.4Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%
  +0.2%     +64 src/cpp/server/server_cc.cc                                                              +64  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%

  +0.1%    +496 TOTAL                                                                                +31.6Ki  +0.6%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +365 [None]                                                                               +31.5Ki  +0.6%
      +0.1%    +286 [Unmapped]                                                                           +31.4Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%
  +0.2%     +64 src/cpp/server/server_cc.cc                                                              +64  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%

  +0.1%    +496 TOTAL                                                                                +31.6Ki  +0.6%

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +365 [None]                                                                               +31.6Ki  +0.6%
      +0.1%    +286 [Unmapped]                                                                           +31.5Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%
  +0.2%     +64 src/cpp/server/server_cc.cc                                                              +64  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%

  +0.1%    +496 TOTAL                                                                                +31.8Ki  +0.6%

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +365 [None]                                                                               +31.6Ki  +0.6%
      +0.1%    +286 [Unmapped]                                                                           +31.5Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%
  +0.2%     +64 src/cpp/server/server_cc.cc                                                              +64  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%

  +0.1%    +496 TOTAL                                                                                +31.8Ki  +0.6%

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE                                                                                FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%    +365 [None]                                                                               +31.6Ki  +0.6%
      +0.1%    +286 [Unmapped]                                                                           +31.5Ki  +0.6%
      [NEW]     +40 vtable for grpc::ServerBuilder                                                           +40  [NEW]
      [NEW]     +23 typeinfo name for grpc::ServerBuilder                                                    +23  [NEW]
      [NEW]     +16 typeinfo for grpc::ServerBuilder                                                         +16  [NEW]
  +0.6%     +67 src/cpp/server/server_builder.cc                                                         +67  +0.6%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +0.5%     +18 grpc::ServerBuilder::BuildAndStart                                                       +18  +0.5%
      [NEW]     +18 grpc::ServerBuilder::~ServerBuilder                                                      +18  [NEW]
      +2.1%     +16 grpc::ServerBuilder::ServerBuilder                                                       +16  +2.1%
       +11%     +15 [Unmapped]                                                                               +15   +11%
  +0.2%     +64 src/cpp/server/server_cc.cc                                                              +64  +0.2%
      [NEW]    +194 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +194  [NEW]
      +3.0%     +48 grpc::Server::SyncRequestThreadManager::DoWork                                           +48  +3.0%
      +0.8%     +16 grpc::Server::Start                                                                      +16  +0.8%
      +0.4%      +1 [Unmapped]                                                                                +1  +0.4%

  +0.1%    +496 TOTAL                                                                                +31.8Ki  +0.6%

Force merging this because CLA bot seems broken.

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                            cpu_time    real_time
-------------------------------------------------------------------  ----------  -----------
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/262144  +6%         +6%

[trickle] No significant performance differences

Nico, I think the CLA bot was legitimately concerned. Makarand's commits were ill-formed because his config had a missing email address.

[trickle] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                               cpu_time    real_time
----------------------------------------------------------------------  ----------  -----------
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/262144     +10%        +10%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2097152      +5%         +5%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/262144  +4%         +4%

[microbenchmarks] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                                               cpu_time    real_time
----------------------------------------------------------------------  ----------  -----------
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/262144       +4%         +4%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/262144  +4%         +4%


Optimal colorbar placement + save space for GeoMakie

Current GeoMakie (as of ClimaAnalysis v0.5.10) colorbar waste a lot of space.
Placing the colorbar horizontally below the globe map would save a lot of space, as well as reducing space between the map and the colorbar.
MWE:
using GeoMakie
using CairoMakie
fig = Figure(size = (800, 500))
ga = GeoAxis(
    fig[1, 1]; # any cell of the figure's layout
    dest = "+proj=wintri", # the CRS in which you want to plot
)
lines!(ga, GeoMakie.coastlines()) # plot coastlines from Natural Earth as a reference
scatter!(ga, -120:15:120, -60:7.5:60; color = -60:7.5:60, strokecolor = (:black, 0.2))
b = Colorbar(fig[2,1],
        vertical = false,
        width = Relative(0.75),
        label = L"\text{GPP} \, (\mu\text{mol m}^{-2} \, \text{s}^{-1})")
save("fig.png", fig)

key elements in MWE are vertical = false, and width = Relative(0.75),
Note that the default padding (white space betwwen plot and edges, or between map and colorbar) is still very large, reducing it would be amazing.

@Sbozzolo does that sound okay to you? (for ClimaAtmos and all users)

I am fine, but I would like to see a ClimaCoupler bias/leaderboard plot before merging this.
Let me point out that the plotting functions in ClimaAnalysis are probably not the best tool for publication-grade plots (they have to be general enough to be good enough for most uses). In that case, when you want to have full control of the plot, you can use ClimaAnalysis to extract the data, but make the plot with your favorite tool (Makie, Python, LaTeX, ...).

It's okay to put low priority on this. I agree with your point about publication quality, this is more intended for most use - for example to make quick slides, or for the dashboard


resolving peer dependency warnings for react 17

can we update the react dependencies in the package.json to remove these warnings?
warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>for context, our project is on react 17. would we be able to add
"peerDependencies": {
    "react": "^16.8 || ^17.0",
    "react-dom": "^16.8 || ^17.0",
  },

Let's include 18 as well. Not sure if React 17 is really used anywhere around - it was quite a temporal version.

ok thanks @theKashey what will the timeline look like on updating this peer dependency?


test_size_of_spdm_requester dosent works on Linux

1.Any particular reason why test_size_of_spdm_* is not added under Linux  and only for windows.
CMakelists.txt
if(CMAKE_SYSTEM_NAME MATCHES "Windows")
    if(ARCH STREQUAL "x64")
       if(NOT TOOLCHAIN STREQUAL "LIBFUZZER")
        ADD_SUBDIRECTORY(unit_test/test_size/test_size_of_spdm_requester)
        ADD_SUBDIRECTORY(unit_test/test_size/test_size_of_spdm_responder)
        endif()
    endif()
endif()

If i remove windows check and build for Linux with all the configs enable in spdm_lib_config.h
i see that size comes to around 1.2K does this size make sense?

[root@neutron libspdm]# ls -alh ./build/bin/test_size_of_spdm_responder
-rwxr-xr-x. 1 root root 1.2K Feb 10 05:51 ./build/bin/test_size_of_spdm_responder

[root@neutron libspdm]# file ./build/bin/test_size_of_spdm_responder
./build/bin/test_size_of_spdm_responder: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, BuildID[sha1]=a0f98b7c0eebe8603b9882fec30bed3a27de71b4, not stripped

It is OK to turn on for GCC, if you have send a PR. (it is just not enabled before.)
The MSVC data is shown at https://github.com/DMTF/libspdm/discussions/603.
1.2K is too big. It does not make sense at all.
Is it release build, with size optimization, and link time optimization?

Sorry, I thought it is 1.2M.
1.2k is too small, definitely.
Just checked the code, I use
#if defined(_MSC_EXTENSIONS)
#pragma optimize("", off)
#endif

I think we may need GCC way to turn off opt for this specific file.

270K is full feature + no encryption? that is big.
Maybe you can help check the symbol to see if any unnecessary functions are included.

This was fixed by #1320.


Make sure BY-COVID website can be archived fully

While of course we would like the BY-COVID website to remain active for a long time, we know from experience that it is common for EU project websites to eventually disappear.
I've tried archiving the website using Wayback Machine, however the navigation does not seem to work from any of the hyperlinks:
https://web.archive.org/web/20230917132941/https://by-covid.org/
I suspect there are some javascript taking over the hyperlinks that is not happy once running at Wayback machine.
Tested with Firefox and Microsoft Edge.
Note that the Wayback Machine is able to detect these outgoing links and archived those as well, however it is the links to get to them does not work from the archived page.

Hi @stain, thanks for pointing this out.
I was looking into this and discovered that the Wayback Machine toolbar covers the website menu bar, which can be seen if I close the WM toolbar.
I checked with other websites, and it does push down the top header, but not for the BY-COVID website. I changed the HTML a bit and checked if it makes any difference, but it still picks up the old one because I think it's already been archived.
I was using Chrome.

I did a new capture https://web.archive.org/web/20230919123848/https://by-covid.eu/, but it still has the top-bar issue.
The bigger issue is that any of the hyperlinks further down don't seem to work, even if it seems these many page-data json files are loaded.  The URL bar changes to e.g. https://web.archive.org/web/20230919123848/https://by-covid.eu/outputs#publications but the content stays the same. If I then click on URL bar to load it again, the navigated to page will show correctly.


feat: encrypt native secret values

This feature will make it so all secret values get encrypted with a passphrase. A default passphrase has been added to the docker-compose and will be a new required field in the next release.
Work will need to be done for the release notes to provide a script/query to encrypt secrets in versions below 0.7.x. Alternatively, we could put this feature behind a feature flag. Which would make it so administrators that are running clusters today do not need to modify the secrets by default when upgrading.
fixes: https://github.com/go-vela/community/issues/100

Looking at updating hashing to sha256

We should make sure we propagate the docker-compose changes to the rest of the repos to include VELA_SECRET_NATIVE_KEY


Reconnect does not work. When connection lost, it crash (CRITICAL)

It does not survive redis server disconnect / restart.
events.js:160
throw er; // Unhandled 'error' event
^
Error: Redis connection to <IP_ADDRESS>:6379 failed - connect ECONNREFUSED <IP_ADDRESS>:6379
at Object.exports._errnoException (util.js:1022:11)
at exports._exceptionWithHostPort (util.js:1045:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1087:14)

Providing pubClient and subClient fix.
const socketioRedisAdapter = socketioRedis({
pubClient: redisPubClient,
subClient: redisSubClient
})


Updated composer.lock and reverted yoda notations

inline with recently updated coding standards

This PR will resolve one of three test failures with my other PR #2


Data Authenticity

Can you please let me know whether the source data is authentic data released by the government. I work for a renowned NGO and our reports are viewed more. So planning for a publishing report.

@Mchockalingam We refer to state govt bulletins for number of tests and cases details. For state level vaccination, we refer to cowin api. For nation level tests/vaccination, we refer to mohfw bulletins.


added prometheus sample for keda2

added prometheus sample for KEDA2
Autoscale Kubernetes pods based on ingress request — Prometheus, KEDA, and K6

Provide a description of what has been changed
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)
[x] A PR is opened to update the documentation on our docs repo

Fixes #

Thanks, @zroubalik!
I added the signed-off-by in my commit accordingly and also updated the KEDA spell in my blog.
Could you kindly review it again?

@kcfigaro thanks. Thanks for the addition, it's a great stuff!


Set up CI/CD to bot's server

Initial idea for CD is to create a bash script that will be deployed to remote server and executed using Travis. The script would pull this repository, install the dependencies using pip and start the components. Configuration info will be installed in remote server by hand before the deployment or added using Travis.

At the moment CD is setup in cd branch


Pure functions calling impure ones

This is my first Pull Request for OSVVM.
My current GHDL (0.34dev; win32; mcode, build some days ago) complains about pure functions calling impure ones.
Changed function declarations:

impure GenCross(...)

Sorry, I selected the false source and destination branches for the suggested merge ...
See #3 for the hopefully correct PR.


Import error?

When i try to import SA, i get this error:
`Traceback (most recent call last):
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/numpy/core/init.py", line 23, in
from . import multiarray
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/numpy/core/multiarray.py", line 10, in
from . import overrides
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/numpy/core/overrides.py", line 6, in
from numpy.core._multiarray_umath import (
ImportError: libz.so.1: cannot open shared object file: No such file or directory
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "main.py", line 5, in
import scratchattach as scratch3
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/scratchattach/init.py", line 1, in
from ._cloud import *
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/scratchattach/_cloud.py", line 2, in
from numpy import var
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/numpy/init.py", line 141, in
from . import core
File "/home/runner/scratch-image/venv/lib/python3.8/site-packages/numpy/core/init.py", line 49, in
raise ImportError(msg)
ImportError:
IMPORTANT: PLEASE READ THIS FOR ADVICE ON HOW TO SOLVE THIS ISSUE!
Importing the numpy C-extensions failed. This error can happen for
many reasons, often due to issues with your setup or how NumPy was
installed.
We have compiled some common reasons and troubleshooting tips at:
https://numpy.org/devdocs/user/troubleshooting-importerror.html

Please note and check the following:

The Python version is: Python3.8 from "/home/runner/scratch-image/venv/bin/python"
The NumPy version is: "1.24.3"

and make sure that they are the versions you expect.
Please carefully study the documentation linked above for further help.
Original error was: libz.so.1: cannot open shared object file: No such file or directory`
I'm using replit.

Try running kill 1 in the Shell tab of your repl

Thanks, now it does work!
I have another question: I made an Image Render a while ago, but sometimes (especially in high res) a piece of the data gets lost, completely destroying the image. Is there any way to check if all the data is correct?

scratchattach's cloud requests are supposed to detect that, maybe that isn’t working properly. You could check in the Scratch project if the length of the received data is valid

ok, thank you for helping.


Jrapsoa 440 narrow object

HHH-9932 - Separate logger for StatefulPersistenceContext.narrowProxy

Sorry, wrong branch with to many changes.


allow-unrelated-histories

Script git-submodule-rewrite always failed for me.
It prints can not merge unrelated histories,
I have to add  --allow-unrelated-histories to git merge --allow-unrelated-histories -s ours --no-commit ${ALLOW_UNRELATED_HISTORIES} "${sub}/master" to fix this issue.
Hope it would be fixed in main repo also.

What version of git are you using (git --version)?  This pull request made suppresses the "--allow-unrelated-histories" option, so that the script could support older git versions that don't have a --allow-unrelated-histories option.  It's possible that there's a but in that commit.
https://github.com/jeremysears/scripts/pull/2

@jeremysears
git version 2.13.2, I suppose you compare versions in wrong order:
${OP_VERSION} -le ${GIT_VERSION}

mean if 2.8.4 <= cur_git_version; then ALLOW_UNRELATED_HISTORIES=""
but you need if cur_git_version <= 2.8.4; then ALLOW_UNRELATED_HISTORIES=""
or actually you can remove all version checking and do something like:
git merge  -s ours --no-commit "${sub}/master" || git merge --allow-unrelated-histories  -s ours --no-commit "${sub}/master"

Fixed in pull request #5


Replace production public key and add backup

This replaces the production public key with a new one and adds a backup production public key.
Signed-off-by: Joseph Reynolds<EMAIL_ADDRESS>

Closing this for bookkeeping.  We rebase and delete the old backup key which was added in https://github.com/ibm-openbmc/ibm-acf/pull/10

The updated PR is in https://github.com/ibm-openbmc/ibm-acf/pull/15


[AnimationTrackEdit] Cancel key drag when popup is shown.

Fixes https://github.com/godotengine/godot/issues/92884

Thanks!


Add test_live_render

Basic test for object LiveRender
Type of changes

[ ] Bug fix
[ ] New feature
[ ] Documentation / docstrings
[x] Tests
[ ] Other

Checklist

[x] I've run the latest black with default args on new code.
[x] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
[x] I've added tests for new code.
[x] I accept that @willmcgugan may be pedantic in the code review.

Description
I saw there are no direct test for the object LiveRender.

Thanks!


chore: Add some cypress tests for Admin settings page

Description

Added some cypress tests for Admin settings page which were missing

Fixes #12453
Type of change

Add cypress tests

How Has This Been Tested?

Ran the newly added tests on local machine and checked if they complete successfully.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:white_circle: Total coverage has not changed
// Code coverage diff between base branch:release and head branch: chore/admin-cypress-tests

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
app/client/src/selectors/commentsSelectors.ts
85.25 (1.64)
64.71 (2.95)
73.33 (0)
90.59 (2.35)

/ok-to-test sha=cc8eb17


Use Git LFS

It’s not too urgent but I think it might be good to utilize Git LFS and allow for larger datasets to be added. More here.
Users who want to download the whole resource can still do that with git clone, but they'll need git LFS installed and set up for their user account, or they can download the zip file from GitHub. We can add this information to the README.
Later, we can save all the changes in one branch and, in an active branch (master branch when all this gets merged), we can squash all the old commits to reduce the repo space.

It looks like LFS support was added by e447f5657e001e73642756b664ea1421408aa967 and a7f3f89291fee80751ff1befd01068088f501671. Can this be closed, or is there still work to do before LFS is 'fully' supported?

Yes. I think we can close this now.


"Create New Knowledgebase" wont allow browsing to upload a local file

The "Knowledge Source" field says "Enter a URL or browse to upload a file" - but there is no way to browse.

hi @Markyboy944 - this is a bug in the placeholder text. We don't yet support local file uploads for this scenario. cc @hibrenda @luhan2017

Ah - ok thanks Chris @cwhitten

Yan sez "Enter a URL"


Pull Request: Release version v1.0.0 to main

This pull request merges the version v1.0.0 branch into the main branch, marking the official release of version 1.0.0.

Summary
This pull request merges the version v1.0.0 branch into the main branch, marking the official release of version 1.0.0.
Changes

Completed migration from monolithic architecture to microservices architecture.
Implemented job-service, company-service, and review-service as standalone microservices.
Set up Eureka Server for dynamic service discovery and registration.
Added mappers for DTO and entity conversions using MapStruct.
Enhanced JobDTO to include reviews and updated job-service to handle this integration.
Updated the README file with project overview, setup instructions, and API documentation.

This merge signifies the official release of version 1.0.0, featuring a fully functional microservices architecture for improved scalability and maintainability.


Update visual-studio-code-overview.md

Docs Build status updates of commit bb5e608:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 5093c0b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit a2e7170:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ddec330:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7b8f353:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit ab9cf3e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Have our own List of license identifiers

Context/goal: have a stable link on our doc to link to, in the context of the upcoming metadata validation
Question: should we split that list into its own page? (i feel like its ok like this)

Will we enforce the license tag to contain one of these?

license can be unspecified but if it's there, yes it will be enforced that it's a valid identifier (we'll fix existing models)

UI selector on the Web UI

yes, on the roadmap!


test_unix_socket hangs on MacOS due to OSError: AF_UNIX path too long

When running test_serving.py, the tests hang on test_unix_socket.
When debugging test_unix_socket, an OSError is thrown:
Exception has occurred: OSError
AF_UNIX path too long
  File "/Users/katherinebancroft/dev/werkzeug/src/werkzeug/serving.py", line 596, in __init__
    HTTPServer.__init__(self, server_address, handler)
  File "/Users/katherinebancroft/dev/werkzeug/src/werkzeug/serving.py", line 710, in make_server
    host, port, app, request_handler, passthrough_errors, ssl_context, fd=fd
  File "/Users/katherinebancroft/dev/werkzeug/src/werkzeug/serving.py", line 852, in inner
    fd=fd,
  File "/Users/katherinebancroft/dev/werkzeug/src/werkzeug/serving.py", line 896, in run_simple
    inner()
  File "/Users/katherinebancroft/dev/werkzeug/tests/conftest.py", line 67, in _dev_server
    serving.run_simple(application=app, **testsuite_app.kwargs)
  File "/Users/katherinebancroft/dev/werkzeug/tests/conftest.py", line 186, in <module>
    _dev_server()

This seems to be because the default testing path is too long. Two similar issues:
https://github.com/ethereum/trinity/issues/404
https://github.com/aio-libs/aiohttp/issues/3572
Path length limitations to be aware of.
https://github.com/aio-libs/aiohttp/blob/385b03ef21415d062886e1caab74eb5b93fdb887/tests/conftest.py#L108
N.B. Different OS kernels have different fs path length limitations
for it. For Linux, it's 108, for HP-UX it's 92 (or higher) depending
on its version. For for most of the BSDs (Open, Free, macOS) it's
mostly 104 but sometimes it can be down to 100.

Environment:

Python version: 3.7
Werkzeug version: current master
OSX: 10.15.5

I'm not sure if something changed with a new pytest or just the fact that the test itself changed, but I can't reproduce this. I don't have a Mac, but tests have been passing consistently on CI. I checked the length of the path on Linux, and got the following:
Running pytest:
/tmp/pytest-of-david/pytest-3/test_server_unix_socket_0/test.sock
len: 65

Running tox (different tmp dir):
/home/david/Projects/werkzeug/.tox/py/tmp/test_server_unix_socket_0/test.sock
len: 77

Even substituting in a longer username or a different base path like your output doesn't get to the 92/100/104 character limits (the tox path gets to 85 characters). I'm going to close this for now as I don't want to pull in all the code to generate our own path if I don't have to, but I'll keep it in mind in case it comes up again.

I'm not sure if something changed with a new pytest or just the fact that the test itself changed, but I can't reproduce this. I don't have a Mac, but tests have been passing consistently on CI. I checked the length of the path on Linux, and got the following:
Running pytest:
/tmp/pytest-of-david/pytest-3/test_server_unix_socket_0/test.sock
len: 65

Running tox (different tmp dir):
/home/david/Projects/werkzeug/.tox/py/tmp/test_server_unix_socket_0/test.sock
len: 77

Even substituting in a longer username or a different base path like your output doesn't get to the 92/100/104 character limits (the tox path gets to 85 characters). I'm going to close this for now as I don't want to pull in all the code to generate our own path if I don't have to, but I'll keep it in mind in case it comes up again.

If you have time, give the latest code a try, I'd be interested if it's still failing and what the path is if so.

If you have time, give the latest code a try, I'd be interested if it's still failing and what the path is if so.


Rename generic type

WHAT
Rename generic type
WHY
In order to make it more concise.
Checklist :clipboard:

[x] Add explicit visibility modifier and explicit return types for public declarations
[x] Run spotless check
[x] Run tests
[x] Update metalava's signature text files

LGTM


search and replace in visual block mode applies to whole lines

I expect (maybe wrongly) to be able to use search and replace on the current visual selection, regardless of the method used (e.g. mouse, visual, visual line or visual block mode).
That said, while all the others behave the proper way, selecting with visual block does not. Starting with ^-v then :s/A/B/ does replace as if visual line mode was used. I've not been able to find a bug report about it (maybe many years ago) but there is even a vim plugin that fixes this. If this is not considered a bug, I wonder why consistent behaviour is not wanted or what other logic is behind the current behavior.

:substitute is a line-wise command.  The only information it has is the start/end lines.
You can use the \%V atom to restrict the search to the visually selected region within the lines that :substitute is operating over.
Also, general usage questions should be asked on the user list, rather than via the issue tracker.

I agree with kjyv this is a bug. it's a design bug. :substitute should respect intra-line range restriction. I believe the solution is to fix :substitue:, not to simply wave off the issue a by design. i.e. fix the design for usability.
Cheers


Revise index recovery tests

Describe the bug
A while ago 8 s3 parquet tests were marked as xfail supposedly due to regression in pandas. We need to revise if the problem is still present and if it's possible to resolve it now.
Enabled the tests in the branch tests/remove-index-eq-xfail
How to Reproduce
*P.S. Please do not attach files as it's considered a security risk. Add code snippets directly in the message body as much as possible.*

Expected behavior
No response
Your project
No response
Screenshots
No response
OS
OSX
Python version
3.9
AWS SDK for pandas version
2.17.1
Additional context
No response

Tested this and the AssertionError is still present with pandas 1.5.3 and modin 0.19.0


Dart version problem 😭

Steps to Reproduce

flutter create salesapp
cd salesapp
edit the pubspec file to add flutter_oauth: "^0.0.1" in dependency section

Logs

[salesapp] flutter packages get
Running "flutter packages get" in salesapp...
The current Dart SDK version is 2.1.0-dev.0.0.flutter-be6309690f.

Because salesapp depends on flutter_oauth any which requires SDK version >=1.8.0 <2.0.0, version solving failed.
pub get failed (1)
exit code 1

shashwat@shashwatpc:~$ flutter doctor -v
[✓] Flutter (Channel beta, v0.6.0, on Linux, locale en_IN)
    • Flutter version 0.6.0 at /home/shashwat/flutter
    • Framework revision 9299c02cf7 (5 weeks ago), 2018-08-16 00:35:12 +0200
    • Engine revision e3687f70c7
    • Dart version 2.1.0-dev.0.0.flutter-be6309690f

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
    • Android SDK at /home/shashwat/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.1
    • ANDROID_HOME = /home/shashwat/Android/Sdk
    • Java binary at: /usr/local/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.1)
    • Android Studio at /usr/local/android-studio
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] VS Code (version 1.27.2)
    • VS Code at /usr/share/code
    • Flutter extension version 2.18.0

[✓] Connected devices (1 available)
    • Moto G 5 Plus • ZY2244F3QD • android-arm • Android 7.0 (API 24)

• No issues found!

Ive even tried changing the environment to 1.9.0
it showed error like this
[salesapp] flutter packages get
Running "flutter packages get" in salesapp...
The current Dart SDK version is 2.1.0-dev.0.0.flutter-be6309690f.

Because salesapp requires SDK version 1.9.0, version solving failed.
pub get failed (1)
exit code 1

What shall i do solve this problem 😭

Flutter_oauth is an old package that doesn't work with Dart 2. There's newer alternatives now, like oAuth2. If you really want to use the old one, you can try converting it to Dart 2.

How to exactly???

@ShashwatHiregoudar you can clone it and fix the issues the DartAnalyzer is listing and then publish it under a new name, or use a Git or path dependency to add it to your project.


qt5.qtbase: Build all QPA backends by default

Motivation for this change
It looks like there is no reason to disable any of these backends any more.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Did you check closure size?

@ttuegel Yes I did! The out output is increased by 2M and bin is increased by 1M.


Code style does not conform to Google Python style

Observed behaviour
Using yapf to automatically format source code with --style '{based_on_style: google}' results in massive changes across all Python files in the project.
Expected behaviour
BRIEF.md states that "For Python code style, we conform to Google Python Style Guide".
Resources and exact process needed to replicate
yapf -i --style '{based_on_style: google}' **/*.py
docformatter -i **/*.py
Do you accept massive PRs with style changes? ;)

Do you accept massive PRs with style changes? ;)

No ;-)
See also:  #838

But I would naturally accept removing the "Google Python Style Guide" sentence from that markdown file


Scrolling issue across entire site when using Chrome

There are scrolling issues across the entire site when using Chrome.
User experience is clunky and sluggish as you scroll.
At first I thought this issue was on the recent eu / acc blog post but after checking out other posts, can confirm this is site-wide.
I tried reproducing this on Safari and it seems to be working fine. So it could be a Chrome or extensions issue.
Just flagging for now.

Had the same issue and mitigated it by disabling JavaScript (thanks HN for the tip!).

Nice!


TorchSharp version?

https://github.com/dotnet/TorchSharp
https://github.com/dotnet/TorchSharp/discussions/334#discussioncomment-1258501
Apply the Deep-MAT-Deformation using Torchsharp on Godot (TorchSharp works on Godot) and we currently have Deep Reinforcement Learning in .NET running on Godot

As of now, Deep-MAT-Deformation is a CNN that predicts deformations of a medial axis to describe the surface of an organ. It might be interesting to reimplement Deep-MAT-Deformation using Torchsharp, as it would allow me to visualize the deformations of the Medial Axis in Godot and possibly make a registration of it alongside the CT/Medical imaging of the patient. Unfortunately, it would take some time, and since this is my university thesis project, my current priorities are documenting this project and write the thesis.

Take your time.. hopefully U will eventually find time learning TorchSharp


Presets config extension

Fixes #19
PR extends the config provider to consume presets loaded during the dependency injection stage.
Includes base "global" presets that are there to be extended by a future PR

[ ] Tests pass
[ ] Appropriate changes to README are included in PR
[ ] Documentation updates added

Leaving as Draft until morning July 31st for testing.


Question: Is it possible to define ignore files/folders?

Hi there,
First off, I want to say that the ClaudeDev plugin is fantastic—it's been a great addition to my workflow!
I have a quick question: Is it possible to define specific files or folders to be ignored by the plugin? I’m looking to exclude certain files or directories from being processed or analyzed.
Any guidance on how to set up an ignore list or configure exclusions would be greatly appreciated!
Thanks in advance!

First off, I want to say that the ClaudeDev plugin is fantastic—it's been a great addition to my workflow!

Thank you for saying this ❤

Is it possible to define specific files or folders to be ignored by the plugin?

The best way to do this right now is to go to Settings > Custom Instructions and adding something along the lines of "Do not ask to read or write to the following files <file paths>". In any case claude never reads any files without your permission, the most information that he gets automatically is a list of your project's file paths but aside from that you're in control of what information he gets.
Some of the folks in our discord are thinking through a concept of adding .context/.context-ignore to let you more clearly define what kinds of context you want claude to have from the start or things you want him to ignore. So better support for what you want  is in the works!


Update index.html

Gave the Web Page a H1 Heading
Description
Created a Header for webpage.
Additional Context

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


feat: added simple logging for webhook

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds simple logging functionality for webhooks to show success or failure
Also vscode setting to enter debug mode

What is the current behavior? (You can also link to an open issue here)

There's no logging

What is the new behavior (if this is a feature change)?

Before sending will show this in the log:
[Webhook] Trying to send webhook to https://mywebhook.com

Webhook with response will show message like:
[Webhook] Webhook post response status: 200 | statusText: OK | url: https://mywebhook.com

Webhook with error will print full error to log

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
N/A

Yep, agree - we should switch to Pino


generic proxy: complete the development of HTTP1 codec

Commit Message: generic proxy: complete the development of HTTP1 codec
Additional Description:
Finally, it is there. The basic HTTP support of generic proxy filter.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

friendly ping @soulxu

FWIW, waiting label means a PR is waiting for the author to resolve or address some problems. wait:review should be used here.

/retest

/retest


Monitor bucket debug info solution?

Hi all,
I'm using bucket for my full sequence lstm experiments, and I want to watch the parameters during the training.
First, I tried use Monitor for debug, but Mxnet tells me "monitor does not support bucket now"
So, I follow./example/numpy-ops/custom_softmax.py to write a python-based operator(DebugOperator), whoes output is the same as the input. Inside the DebugOperator, I can print out the parameters I want to see.
Here is the code:
import mxnet as mx

class DebugOperator(mx.operator.CustomOp):
    def forward(self, is_train, req, in_data, out_data, aux):
        ###Here One Can Print Out The Debug Info
        print "here is the debug info"
        print in_data[0].asnumpy()
        self.assign(out_data[0], req[0], in_data[0])

    def backward(self, req, out_grad, in_data, out_data, in_grad, aux):
        self.assign(in_grad[0], req[0], out_grad[0])

@mx.operator.register("debug_info")
class DebugOperatorProp(mx.operator.CustomOpProp):
    def __init__(self):
        super(DebugOperatorProp, self).__init__(need_top_grad=True)

    def list_arguments(self):
        return ['data']

    def list_outputs(self):
        return ['output']

    def infer_shape(self, in_shape):
        data_shape = in_shape[0]
        output_shape = in_shape[0]
        return [data_shape], [output_shape], []

    def create_operator(self, ctx, shapes, dtypes):
        return DebugOperator()

I use the customed operator in this way:
#to print out the test_symbol
test_symbol = mx.sym.Custom(data=test_symbol, name='debug', op_type='debug')

When I used this customed operator, I get this error:
Traceback:
File "_ctypes/callbacks.c", line 313 in "calling callback function"
File "../mxnet/python/mxnet/operator.py", in line 600, in creator
        op_prop = prop_cls(**kwargs)
Type Error: __init__() got an unexpected keyward argument 'data'
Segmentation fault

Since I'm new to mxnet, I'm not sure if I defined this operator in the right way. But I do believe this is a solution for debuging bucket info, which is not supported in current version.

As you have registered your custom operator with the name "debug_info", you have to reference it with the same name when calling it, so
test_symbol = mx.sym.Custom(data=test_symbol, name='debug', op_type='debug_info')

@5urprise  thx, actually, I passed a list of symbol to this function
test_symbol = mx.sym.Custom(data=test_symbol, name='debug', op_type='debug')

the test_symbol I feed in should be a symbol


Fix TypeScript issues from Flex UI 2.7.0

Summary

Session data from Redux is now possibly undefined; switch to manager.user
SupervisorWorkerState type definition moved files; switch to any where needed to maintain cross-version-compatibility
Update Flex UI version in package

Checklist

[x] Tested changes end to end
[x] Updated documentation
[x] Requested one or more reviewers

LGTM! ✅
No ESLint errors or warning running locally, or any other errors during a simple validation of Flex: receiving a task and interacting with the UI.


site style css

style the site using CSS and help it be as responsive as possible.

CSS IS ON IT WAY


add maturity progress bar to tx.tmpl

As described in #247
Some sample scenarios:

At 256 confirmations,.Maturity is still considered "False", so I've added +1 to the progress logic to make the progress bar represent when it is actually spendable. Does that make sense?

this is still a wip, this should use b.params.TicketMaturity so it works on testnet

I love the concept and the look.  Haven't tested yet though.

alright, updated the progress bar to use the network params and put some better text for when its about ticket progress

Thinking this ones ready to go

I gave this a test run, looks good.


This is now detected by VAC

just a reminder for people wanting to use this, and maybe for developer to make a fix

nevermind. they are fake pictures


Use resource name to resolve services.

This solves problems with linking shared addons.

cc/ @fnando

:+1:

Actually, there is a case that this doesn't handle well.

There you go, fixed.


Size of the Image

Hi, I've been looking for the specific limitations of the Company Communicator. Our last search on the github showed 1MB limit for a Image, but some tests with Images until 2MB worked as well.
Also I haven't found any information about characters limitations (I've been using 1.000 characters as a reference).
Can you guys help me out with those informations?

@priyank29 Need guidance on this

The underlying limit for images comes from the Teams platform, and the current limits are documented here: https://docs.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/cards-reference#inline-card-images
For text, 1,000 characters is a good conservative size. Two limits come into play here:

Bots can send a maximum message size of 28KB (this is for the entire message).
Azure table storage has a maximum size of 64KB per cell

If you are unsure of these limits, we recommend using the "Preview" function to send it to the authors team first. (In fact we recommend doing this always, since there can be some differences between the preview in the app, and how the card is ultimately rendered in Teams.)


Refactor the lifecycle control of flink application mode -dosubmit

What changes were proposed in this pull request
Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
KubernetesNativeApplicationClient.doSubmit 适配到  FlinkOperator. deployApplicationJob;
(or)
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes / no)
yes

cc @Al-assad

cc @wolfboys

cc @Al-assad

cc @Al-assad

@Al-assad The response returns some null values for the time being, and it will be improved after discussing with people in the community

cc @Al-assad


Enable & test encryption for watchOS/tvOS

Should be possible with core 0.95 (#2874).

Can anyone confirm with Realm teams, if encryption is actively being looked into for usage on tvOS platform? (thanks in advance)

Not at the moment.

The lack of encryption on watchOS and tvOS means that it's not possible to use the Realm Mobile Platform on those platforms yet.
If it's possible to enable encryption on those platforms, this would definitely expand the number of devices that could take advantage of online sync. :)

Is this still being worked on? I just tried to include realm object server into my watch extension and I keep getting this error:
libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: Encryption not enabled
Thanks


Handle ip addresses (with commas) fanging

When fanging ip address consisting commas, it gives wrong result
ioc_fanger.fang('ip 23,45,67,89') 'ip <IP_ADDRESS>'

Thanks for raising this issue @bhargava-kush. What do you expect ioc_fanger.fang('ip 23,45,67,89') to produce?
When I run:
import ioc_fanger
ioc_fanger.fang('ip 23,45,67,89')

with the latest version of this package, it outputs: ip <IP_ADDRESS> (which is what I expect).

@fhightower Thanks for the help, I thought comma-separated numbers will not be treated as IP address.

Ok. Comma-separated numbers are converted to IP addresses because some people "defang" ip addresses using commas.


Swift 2.3 support needed

#145 can help

Sorry but I do not plan on adding/maintaining support for swift 2.3.


Fix gtest_dm_minmax_index.cpp clang tidy.

Signed-off-by: Jigao Luo<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #4604
Problem Summary:
What is changed and how it works?
Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @ywqzzy

/run-unit-test

@cakebytheoceanLuo Thanks for your contribution!

/merge


[ROCm] Bazel build and continuous integration infrastructure

This pull request is to start introduce support for ROCm platform to TensorFlow. In this initial pull request, 2 components are addressed:

bazel build system
continuous integration logic

Authors:

Jack Chung<EMAIL_ADDRESS>Jeffrey Poznanovic<EMAIL_ADDRESS>Peng Sun<EMAIL_ADDRESS>

ping?

@gunan could you please take another look?

@rmlarsen / @gunan please hold it for now . I haven't finished addressing all comments from reviewers yet. will ping you guys once i feel more comfortable with the PR.

a gentle ping?

@gunan / @jlebar wondering if you could provide additional inputs to this pull request? There are a few other pull requests I'm preparing depends on the infrastructure established in the PR (ex: if_rocm_is_configured, TENSORFLOW_USE_ROCM). And some others PRs already filed ( such as #20709 / #20712 / #20715 ) also depends on this PR so they can be further revised / reviewed / merged.

Hi, I work with Jack @whchung here at AMD.    Jack suggested the command-line below - is this what is desired?    So would produce 3 PIPs at the end of the build, but the overall build would be faster since we only compile the common code once?
bazel build //tensorflow/tools/pip_package:build_cpu_pip_package //tensorflow/tools/pip_package:build_cuda_pip_package //tensorflow/tools/pip_package:build_rocm_pip_package
We are not bazel experts so implementing this looks fairly scary, but perhaps not for someone with proper understanding of the build architecture and access to internal test frameworks.    Can someone provide a reference implementation for the existing targets (CPU, CUDA, etc) - then we could modify this PR to fit into that template?  Or we can treat the unified build steps as a separate feature/PR ?

OK, looks like we are ready to start merging this PR. As we also need some internal work on this, it will take some time.
Before I do my final review and approve, could you resolve the final conflicts, one final time?

@gunan thx. i was out of town yesterday. let me revise the PR one more time so you can take a look at it.

@gunan resolved the merge conflict. please help review it once again. thanks.

@gunan I addressed the build errors found by CI. Would you mind re-approve and re-commence the tests? Thanks.

Looks like all build system seems broken.
Do you have a mac machine you can locally iterate on?
Looks like trying just the CPU build will be useful.

@gunan I'll try get a Mac to locally reproduce the issue. It seems some of my earlier editions to remove Darwin and Windows from ROCm build path could be related. Since ROCm doesn't support Windows & OSX yet, what would be the best practice to do so?
For Ubuntu it's weird that we are seeing this error:
ImportError: libtensorflow_framework.so: cannot open shared object file: No such file or directory

In my downstream fork we are always getting this shared lib properly built. I'll need to study it a bit better.

@gunan I resolved one merge conflict earlier today but all previous build logs were gone. Is there a way to get them?

All new commits invalidate older builds. I will retrigger them.

@yifeif copybara said "An error happened while migrating the change". Trying again.

@whchung  could you check the build failures?

@gunan I’m working on this. I’ve already resolved Mac and windows errors on my local boxes. Still haven’t quite sure what’s going on with libtensorflow_framework.so on those Ubuntu targets . I haven’t seen such issues on my end thus far. I’ll revise this PR once I got this figured out

@whchung looks like it is proving to be too difficult to get everything in this change to work all at once.
I propose breaking this up this way:
1 - only the toolchains in third_party/gpus/rocm*
2 - tensorflow.bzl changes
3 - BUILD file changes
4 - configure and bazel.rc changes
5 - Dockerfile.rocm
6 - build script changes.
it will be 6 PRs, but they will be much easier to work with to get our CI green for both you and us.

@gunan Just to inform you I'm working on some final touches to this PR and should be able to revise it later today. All failures in previous run should have been addressed. I'll inform you when it's ready.

@gunan I believe with the new commit I should have addressed all previous build errors encountered on Mac, Windows, and Linux. Could you help restart the test? Thanks.

@gunan many thanks for executing the test. there is only 1 failure in MacOS Contrib target, and from the log i really don't believe it has anything to do with this PR but a timing issue. Would it be possible to re-run that target once again?

@gunan in Ubuntu Sanity there is one error but its log is cryptic to me and again I don't really think it has anything related to the PR itself:
=== Sanity check step 3 of 13: do_check_futures_test (Check that python files have certain __future__ imports) ===
Traceback (most recent call last):
  File "check_futures_test.py", line 107, in <module>
    main()
  File "check_futures_test.py", line 103, in main
    raise AssertionError('Error in %s: %s' % (short_path, str(e)))
AssertionError: Error in contrib/lite/tools/accuracy/ilsvrc/generate_validation_labels.py: Missing futures: division absolute_import print_function

Neither in this PR nor in TensorFlow master branch do we see this generate_validation_labels.py so it leads me to believe it's a configuration issue in the CI test node.

Sanity failure is a known issue, so it did pass all presubmits.
Reviewers, could you take one final look?
@yifeif How should we approach pulling this change into google?

cc @parallelo for awareness
@gunan / @yifeif , do we expect to see new test targets once this PR gets merged?

No, we  do not have the hardware, toolchains, license reviews or anything in place for us to be able to build with ROCm. So they definitely wont become blocking presubmits for now.
This, of course will be subject to review later.
In the meantime, we can work with you to setup community supported builds, as outlined here:
https://github.com/tensorflow/community/blob/master/sigs/build/community-builds.md

@gunan Thanks for sharing the community build page with me. @parallelo would look into it and adapt our CI infrastructure to accommodate that.
Also we do like to revive our other outstanding PRs, specifically those in StreamExecutor and GPU common runtime which are blocked by this particular PR. Also we'll start submitting PRs to enable operators on ROCm which condition upon TENSORFLOW_USE_ROCM introduced in this PR. Would it be possible to help expedite allowing this PR be merged? Thanks a lot.
With more developers working on TensorFlow ROCm port now we expect subsequent PRs be revised / maintained in timely fashion.

This will need a manual pull for sure @gunan. @whchung do you mind resolving the latest conflicts? Reviewers, let me know if this is ready and I can give pulling a shot.

@yifeif @gunan, my colleague @deven-amd has debased and modified the PR

@yifeif any update to pull this PR in?

@aaroey @meteorcloudy any additional comments?

Oh, it looks like we have to import this manually.

@yifeif is working on the manual import of this, she has been working on this for 2 weeks now.

We had to revert some "if_cuda_is_configured" uses to if_cuda to make all internal tests to pass, but other than that all of this change has been merged.

We finally got this change merged! Thanks for the patience. We needed to change if_cuda_is_configured in tf_cuda_library back to if_cuda to get some internal targets to pass. Feel free to send another PR if this causes any issue and we can work out a patch.

Woohoo! Thank you @yifeif !

Thank you @yifeif and @gunan . We’ll revise other pending PRs for ROCm , as well as submitting new ones :)


Only upload packages on 'release style' tag.

Only upload packages for "release-style" tags.

The final CI failure was expected (version number wasn't updated, so packages can't be uploaded - I was just pushing a tag to check the trigger worked).


Add hover artist card to holdings

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[x] Refactoring

What's new?

[x] PR closes #2785
[ ] <brief_description_of_what_I've_added>

add hover artist card to holdings
refactor: remove any type on holder\holding component  cc @roiLeo

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[x] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 100

😍 Perfect, I’ve sent the payout
💵 $100 @ 172.39 USD/KSM ~ 0.58 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x2b67a305bbea5f515f0dd9363da209b886bcaa3ed216ac22b493d45a05a91be8
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Mike Rogers showing-up under two different Thomas IDs

He's under 01704 and 01651.  And the bioguides are different as well, but do correspond with their respective Thomas IDs.

They are two different individuals. ;-)
On February 8, 2015 5:41:23 PM EST, Brian DeBusk<EMAIL_ADDRESS>wrote:

He's under 01704 and 01651.  And the bioguides are different as well,
but do correspond with their respective Thomas IDs.

Reply to this email directly or view it on GitHub:
https://github.com/unitedstates/congress-legislators/issues/243

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Yet the legislators file only list one -- the 01704 member.

There are two legislators files. (One of the two Mike's is no longer serving.)


Bootstrapping documentation

Starting on documentation site.  Using tut + microsites + gh-pages.
Did nothing as far as documentation goes so far.  Just want to have the doc generation lined up so I can just start writing docs.
The site is up at the very least.  Next I plan on putting together some documentation.  The documentation is geared toward OO people new to Scala.
Check it ... https://pauljamescleary.github.io/scala-pet-store/

Closes #40


how can i use simplecov gem with cypress-on-rails

Hi friends.
Can somebody help me please.
It is good idea to initialize simplecov gem
https://github.com/colszowka/simplecov#getting-started
inside
config/initializers/cypress_on_rails.rb
like this
if defined?(CypressOnRails)
  CypressOnRails.configure do |c|
    c.cypress_folder = File.expand_path("#{__dir__}/../../cypress")
    # WARNING!! CypressOnRails can execute arbitrary ruby code
    # please use with extra caution if enabling on hosted servers or starting your local server on <IP_ADDRESS>
    c.use_middleware = Rails.env.test?
    c.logger = Rails.logger
  end
  require 'simplecov'
  SimpleCov.start 'rails'
end

Thanks for  help.

The best way to do it is in the spec_helper (or equivalent test set-up file), as described in the simplecov documentation.
https://github.com/colszowka/simplecov#use-it-with-any-framework
It should not be started in an initializer, that would be "too late" for it to cover all you want to cover.

The question in this Issue is perhaps best asked as a StackOverflow question.

Thanks, i found answer
https://stackoverflow.com/a/10548281
# config/boot.rb
if ENV["SELENIUM"]
  require 'simplecov'
  SimpleCov.start 'rails'
end