Explanation: we have a build flag requiring at least Go 1.13 to build the iris integration: https://github.com/getsentry/sentry-go/commit/8a225f85eab0a62ee9eace6568d618049311cfa8.
Looks like more people run into this problem with Iris recently -- https://github.com/kataras/iris/issues/1422
In our case here, I could not see a single reference to github.com/kataras/iris, it is always github.com/kataras/iris/v12 -- however, as per Travis logs, go get seems to be trying to install github.com/kataras/iris

I found that jet, a dependency of iris merged a breaking change to their API 6 days ago in https://github.com/CloudyKit/jet/pull/112. This means that when GO111MODULE=off we pull the latest version of everything, and then iris and jet expect incompatible types, such that go get fails to build iris.

@rhcarvalho that change was reverted with https://github.com/CloudyKit/jet/pull/126, is that still an issue?

@tooolbox thank you for asking. I've re-run the Travis build https://travis-ci.com/getsentry/sentry-go/builds/143639883 and it is green :)
Thank you!!

Closing this issue for now, cutting another one to track the maintainability of integrations with external frameworks. With the introduction of Go Modules, there is less incentive to work with GO111MODULE=OFF, thus we may need some adjustments going forward to state what version combinations are supported and also improve the Travis config to prevent build failures in sentry-go in the same fashion as this case here (i.e., we should probably not try to support "go get all" without versions).


form select input value to form display

Laravel Version: 5.8.8
PHP Version: 7.2.8
Laravel-admin: 1.6.10

Description:
$form->select('employee')->options(Employee::all()->pluck('name', 'id'));         $form->display('old_department');         $form->divider();         $form->select('new-department')->options(Department::all()->pluck('name', 'id'));         $form->textarea('note')->rules('nullable');
how to get the value from select employee to display on old_department.
so the old_department will be showing the current department for selected employee
Steps To Reproduce:

one possible solution with the chance to modify the output:
            $form->display('old_department')->with(function ($value) {
                return $value;
            });

this is how i solve this issue, not the best solution but its working
MutationController.php
`
protected function form()
{
$form = new Form(new Mutation);
    $form->select('employee')
        ->options(Employee::all()
            ->pluck('name', 'id'))
        ->loads(['old_department', 'new_department'], [ '/admin/api/old_dept', '/admin/api/new_dept']);
    $form->select('old_department', 'Old Department');
    $form->divider();
    $form->select('new_department', 'New Department');
    $form->textarea('note')
        ->rules('nullable');
    $form->hidden('user_id')->value(Admin::user()->id);

    $form->saved(function(Form $form){
        // update employee department after save to table
        $newDept = $form->input('new_department');
        $newDeptId = Department::where('name', $newDept)->first()->id;
        $employeeId = $form->input('employee');
        $employee = Employee::find($employeeId);
        $employee->department = $newDeptId;
        $employee->save();
    });

    $form->footer(function ($footer) {
        $footer->disableReset();
        $footer->disableViewCheck();
        $footer->disableEditingCheck();
        $footer->disableCreatingCheck();
    });

    return $form;
}

`
EmployeeController.php
`
public function old_dept(Request $request)
{
$employeeId = $request->get('q');
$employee = Employee::find($employeeId);
$department = Department::find($employee->department);
return [$department->id => $department->name];
}
public function new_dept(Request $request)
{
    $employeeId = $request->get('q');
    $employee = Employee::find($employeeId);
    $department = Department::where('id', '!=', $employee->department)->get()->pluck('name', 'id');
    return $department;
}

`
routes.php
// API     Route::group(['prefix' => '/api/'], function(Router $router) {         $router->get('old_dept', 'HR\EmployeeController@old_dept');         $router->get('new_dept', 'HR\EmployeeController@new_dept');     });


Part of input bar being covered by button

When you hide the left panel,  a small portion of input bar will be covered under the "unhide" button.

OK, closing this issue then; @jiahao-c feel free to reopen the issue if you think otherwise.


Add acm:DeleteCertificate permission to developer role

as per Slack request https://mojdt.slack.com/archives/C01A7QK5VM1/p1710772027207819 user would like temp permissions to delete certificates.
(also sorted the acm permissions alphabetically)

This will add it to all users and add a risk that someone could delete a cert in prod


Changed arm-none-eabi-objcopy to $(PREFIX)objcopy

It's simpler

Yeah, makes life easier. I'm always a mess with makefiles. Thank you.


Digital Pen input is interpreted as touch instead of mouse after Windows 1709 Fall Creator Update

VSCode Version: Code 1.17.2 (b813d12980308015bcd2b3a2f6efa5c810c33ba5, 2017-10-16T13:59:46.104Z)
OS Version: Windows_NT x64 10.0.16299
Extensions:

Extension
Author (truncated)
Version

xml
Dot
1.9.2

gitlens
eam
5.6.5

cpptools
ms-
0.13.1

csharp
ms-
1.12.1

PowerShell
ms-
1.4.3

I just installed Windows Fall Creator Update and my Windows version is Windows 10 Pro 1709 build 16299.19.  My computer is the Microsoft Surface 3 (Intel Atom)
Before the Windows upgrade.  The Digital Pen in VSCode has functioned like a mouse.  It was possible to use it to select text in the editor.  Using Touch you could pan the open document like touch in a web browser.
After the Windows upgrade
VSCode interprets the Digital Pen as touch.  Attempting to highlight text the Pen will not select text but instead pan the document like panning a web page or using Touch.  I can't use Touch to select text.
I don't always have a keyboard handy and use VSCode to review code.  I use the Digital Pen to select text and make notes in OneNote.  I am unable to do this with the Pen.
The Digital Pen functions as expected in Notepad and other applications tested.
The new upgrade has also broken the ability to use the Touch Keyboard in full keyboard mode to use shift+arrow keys to select text.  I was unable to work this morning.
I have tried rebooting the computer.  I have not tried reinstalling VSCode.

Steps to Reproduce:

A computer with a Digital Pen (Surface 3 Intel Atom)
Windows 10 Pro 1709
Open a document in VSCode
Attempt to use the Digital Pen to select text in the document.
Instead of selecting text the document will pan in VSCode.

Reproduces without extensions: Yes/No

@binaryWard I believe this is a Chromium issue (VS Code is built with Chromium v58).
Can you please double check this by trying the editor at https://microsoft.github.io/monaco-editor/ in Chrome ?

I have found that using the digital pen right-click (holding the right-click button) allows me to select text.  Then using the digital pen right-click (holding it on) allows me to move text.    The right-click action is still able to pop up the context menu.
I have a wacom based Samsung ATIV 500T that is locked at an older Windows 10.  Last night I installed the latest version of VSCode on it and the digital pen worked as expected on that device.  This was the 32-bit version of VSCode.  I am using the 64-bit version on the Surface 3.
I will attempt to try the suggestion to test on the link based upon the assumption of chromium.

I don't think I know what I should do with the monaco editor.  I was not able to figure out how to test it as VSCode uses it. I have only been able to run it via a web browser (Google Chrome) which highlighted text as expected.

@binaryWard
The Monaco Editor uses 100% the same source code as the VS Code editor UI part, especially around input handling. So, from the input handling point of view, the Monaco Editor running on Chrome is almost equivalent to VS Code, except perhaps differences in the underlying Chromium version. VS Code uses Chromium v58, while Chrome is now at v62 I believe.
Since text is highlighted as expected in Chrome v62 in the Monaco Editor, the only difference remains in Chromium versions. I therefore believe that once we update to an Electron version that uses Chromium v62, the issue will be resolved.
The ultimate proof would be that the issue reproduces in the Monaco Editor using Chromium 58, but does not reproduce using Chromium 62. To validate this, you could check if input handling in Chromium 58 fails in the same way VS Code fails:

VS Code uses Chromium 58.0.3029.110
Downloading an older version of Chromium is a bit tricky.
Using https://omahaproxy.appspot.com/ we can find  Branch Base Position for: 454471
http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/ will list all build snapshots for Chromium
Since 454471 doesn't appear to exist there, I suppose 454473 will be close enough; I might be wrong, but this is usually what I do in these circumstances.
So finally, some incarnation of Chromium v58 is available at http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/454473/

@binaryWard

The Monaco Editor uses 100% the same source code as the VS Code editor UI part, especially around input handling. So, from the input handling point of view, the Monaco Editor running on Chrome is almost equivalent to VS Code, except perhaps differences in the underlying Chromium version. VS Code uses Chromium v58, while Chrome is now at v62 I believe.

If you can reproduce on Chrome v62 on your machine with the Fall Creator Update, then please open an issue against https://bugs.chromium.org/p/chromium/issues/list .

If you cannot reproduce on Chrome v62 on your machine with the Fall Creator Update, I suppose you could also try Chrome v58 (which is what VS Code uses currently):

VS Code uses Chromium 58.0.3029.110
Downloading an older version of Chromium is a bit tricky.
Using https://omahaproxy.appspot.com/ we can find  Branch Base Position for: 454471
http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/ will list all build snapshots for Chromium
Since 454471 doesn't appear to exist there, I suppose 454473 will be close enough; I might be wrong, but this is usually what I do in these circumstances.
So finally, some incarnation of Chromium v58 is available at http://commondatastorage.googleapis.com/chromium-browser-snapshots/index.html?prefix=Win_x64/454473/

I am able to reproduce the issue using playground https://microsoft.github.io/monaco-editor/playground.html
Google Chrome Version 62.0.3202.62 (Official Build) (64-bit) would not let me select any text with the digital pen.  I could not even use the right-click function.
Microsoft Edge 41.16299.15.0 presents the same problem.  The digital pen will scroll like touch.  Using the digital pen right click allowed the selection of text.
Internet Explorer 11.15.16299.0 digital pen fails to select text.  acts like chrome.
I don't have firefox to test.  I have not been able to test an older build of chrome.

We have seen the Chrome version 61 work as expected on a Windows 10 1709.  Although checking the browser it is now updating.

More testing results using the playground.  Because it is via a web browser I have put together some notes on different platforms and browsers.
I do not know if the input handling is designed to handle input relative to the OS or if it is wanting to have a uniform input handling on all platforms.
I have access to

Device
Operating System
Digital Pen

Microsoft Surface 3 (Intel Atom)
Windows 10 Pro 1709 16299.19 64-bit
Microsoft Pen (n-trig)

Microsoft Surface Book 4
Windows 10 1709 64-bit
Microsoft Pen (n-trig)

Samsung ATIV 500T
Windows 10 Pro 1607 32-bit (Microsoft locked out this device from newer updates)
S-Pen (wacom)

I have access to an iPad Pro with digital pencil, Samsung Note 5, and older Laptop with a Wacom pen running Windows 7 I will test it when I have a chance.
I have added a matrix matching the Windows mouse input to the digital pen input.  On Windows the Pen and Mouse actions have the same actions for all applications.
Rarely does an application not respond to the pen as mouse input. Web content in a web browser may have different behaviors.

Mouse
Digital Pen
Note

left-click
tap

left-click + drag
tap + drag

left-double-click
double-tap

left-double-click + drag
double-tap + drag

right-click
long-tap

right-click
button + tap

(none)
button + tap + drag
select text, drag window

Here are the results from my testing.
There is one unique test I performed and that was on the Surface 3 I opened a Remote Desktop connection to another Windows 10 workstation to see how the digital pen input would be handled.  This was done because I often am using this combination.
I didn't have this result matrix when I was testing.  If I have time I will attempt to replicate the testing based upon the matrix.
The tests were using the playground at https://microsoft.github.io/monaco-editor/playground.html
I performed the tests in the text editing windows after the page loaded.

Device
Browser
tap
tap+drag
double-tap
button+tap
button+tap+drag
long-tap

Surface 3
Chrome v62.0.3202.62 (64-bit)
position cursor
pan text editor
position cursor
menu
menu when pen lifted
menu

Surface 3
Edge v41.16299.15.0 EdgeHTML 16.16299
position cursor
left text editor pan whole web page and scroll bars did not respond.  right text editor pan scroll bars responded.
position cursor
menu
select text.  tap on unselected text clear selection.  does not work if all text selected.
menu

Surface 3
IE v11.15.16299.0 (11.0.47)
position cursor
pan text editor
position cursor
menu
menu when pen lifted
menu

Surface 3
FireFox v56.0.1 (64-bit)
position cursor
pan text editor
position cursor
menu
select text.  tap clear selection
menu

Surface 3 -> RDP -> Windows 10
Chrome v61
---
text selection
---
---
---
---

Surface 3 -> RDP -> Windows 10
Edge v41.16299.15.0
---
pan whole page
---
---
select text. text cleared on tap outside of selection
---

Surface 3 -> RDP -> Windows 10
IE v11.15.6299.0
---
pan text editor
---
---
menu at pen lift
---

Surface 3 -> RDP -> Windows 10
Chrome v62
---
pan text editor
---
---
menu at pen lift
---

Surface 3 -> RDP -> Windows 10
FireFox v56.0 32-bit
---
select text
---
---
select text
---

Surface 3 -> RDP -> Windows 10
FireFox v56.1 64-bit
---
select text
---
---
select text
---

Samsung ATIV 500TT
Chrome v61 32-bit
---
selected text
---
---
selected text
---

Samsung ATIV 500TT
Edge 25.10586.672.0
---
pan
---
---
---
---

Samsung ATIV 500TT
FireFox 56.1 32-bit
---
selected text
---
---
selected text
---

Surface Book 4
Chrome v61
---
selected text
---
---
selected text
---

For what it's worth, this new behavior in 1709 really bit me in the butt, not only in VSCode but in Edge as well. I prefer to use my pen for text selection over scrolling the screen (pretty much everywhere; and I use finger-based-touch to scroll), and it appears 1709 changed the default behavior of the pen to pan/scroll instead of text selection. There doesn't appear to be a way to change this behavior system-wide.
I have an HP x360 (late 2017) and two pens: Surface pen and the default HP pen. Happy to help test.

This issue also persists in Atom. I used to use my pen as a mouse, and fingers for touch-events.
Same as VSCode, holding the Surface Pen's right-click button allows me to highlight text,
but where I often hold ctrl+click to select multiple spots,
that is now treated the same as a normal right-click.

I'm having similar issues in edge and chrome, and some web-apps with 1709. My only solution so far was to revert to 1703 and block 1709 from installing. I filed a bug with edge regarding this, and they say it's by design now. I'm using pen and touch in a similar fashion. select with drag button to copy paste.
I don't understand how anyone could sign pen scrolling off without an off-switch.
Some functionality that can break in various apps and web-apps are:

Text selection (you can select with barrel button in some cases but no longer copy with it.)
Drag and drop, will scroll instad of drag&drop. Or do both in some cases (conflict)
Drawing/Inking in some apps and web-apps can scroll instead of draw, or do both(conflict)
Barrel button functionality. (wrong context menu showing read aloud instead of copy paste etc)
Double/Tripple taps to select word/paragraph.

I hope someone at microsoft can escalate this, because it's causing a lot of problems for a lot of pen users. Issues with this in feedback hub seems to be ignored so far. There needs to be a setting somewhere to revert to opd behaviour.
I can't file bugs with every app/developer I use to create workarounds for this. Hoping for a fix soon.
This is serious issues that have broken a workflow for a lot of people.

"Drawing/Inking in some apps and web-apps can scroll instead of draw, or do both(conflict)"
This is a huge issue in my organization. We have students and teachers that need to draw and ink in web apps, and that feature is now broken, for a redundant implementation of an easy to use finger gesture. This boggles my mind, as I don't understand the use case imagined where making the stylus equivalent to a finger makes any sense. Having two touch based inputs act exactly the same, when the pen used to add a whole different set of touch based inputs seems like a leap backwards.

This is a systemwide nuisance. If someone has got a feedback hub issue to upvote I'd be in.
Othrrwise I'll open one and post a link.

Excellent suggestion! The current behaviour is odd and unfeasible, indeed.
I added an implementation suggestion to your feedback (which in the meantime apparently has been moved to here: https://aka.ms/V3s0ff ).

Please take a look at a recent post on Reddit that provides some more context in regard to controlling the pen behavior on Windows 10 with legacy Win32 applications.
https://www.reddit.com/r/Windowsink/comments/8508fi/controlling_pen_behavior_in_windows_10/
Hope this helps! Again, we really appreciate the feedback as we continue to enhance Windows Ink!
– Thanks, David

Same behavior in Photoshop CS6 (64bit). Using Thinkpad X230 Tablet with a passive pen on Wacom digitizer built into the screen.
Reproduction instructions:

Select Hand tool or hold Spacebar.
Make sure Standard Screen Mode is selected under View->Screen Mode.
Maximize your Photoshop window.
Zoom in so that the current canvas is larger than your window/viewport.
Press down and drag the pen across the screen in various directions, recentering the canvas when it jumps.
Once you get the hang of reproducing this behavior (it's inconsistent, but notice that the scrollbars in your zoomed-in Photoshop project may transmogrify into some alien appearance when it happens), try moving your zoomed focus above the top-left corner of your canvas, then drag straight down or straight to the right with the Hand tool. The entire window will get pulled slightly, exposing the inactive windows and desktop behind Photoshop. This points to the hypothesis that it's a Windows feature acting badly.

Please if anyone has suggestions, this is a serious bug for me. I need my pen to work as a pen, not as a finger. And I really want toggle switches for all such "features" going forward. Any kind of clear, user-modifiable settings panel might actually make Microsoft's UX designers capable of triple-checking all their features for conflicts before release. Instead they seem to break basic features all the time just because they aren't dog-fooding them.

Same problem as @effeffitis , I went back to the previous update to "fix" the issue.. but still this is very annoying, hope they fix it.

The problem is these changes appear to be influenced from Apple iPad.  Remember the first iPads never had a digitizer pen.  The users that used a pen on these devices we're using pens that emulated a finger.  Now with the iPad pro with a digital pencil the same experience with all applications.  OneNote on the iPad pro is a nightmare if you are a user from Windows or Android with a digital pen.  These are changes based upon a user base that had devices emulating a finger.  Wacom and Ntrig emulated the mouse.
The primary issue we have with the changes is one is more natural to a real pen than the other.  When writing on real paper we do not use our pens to move papers or change pages in a notebook.  We use our fingers.
Users are already aware they can use their fingers to scroll and pan.  It is odd to explain the pen must toggle between a finger input and writing when it is a pen while using writing applications.  The ink team defends their choice.  The Android OneNote team rolled back the mistake.  The digital pen input problem is far larger than vscode.  This is a fundamental shift in how a digital pen will be expected to work in the future.
The pen based on mouse input was far more natural than the pen based on finger input.

The problem is these changes appear to be influenced from Apple iPad
Now with the iPad pro ...

Yup, things seem a bit skewed towards these devices.
But Windows 8/8.1 had the side-by-side view for apps and that was a good thing IMHO, and Apple apparently thought so too and incorporated something similar in their iPad Pro.
Also the swype from left border to bring up the last active app or the "swype loop" from left border and back to bring up the active apps view (similar to the swype from right border on iPad pro) was intuitive once you learnt its magic - but while iPad Pro still has these features Win10 has killed them.
M$ mimiks the useless things but relinquishes their own great ideas so that others can take them up and "sell" them as special features - they seem to be aiming to get rid of the M$ and rebrand to M¢ 😉

MS Feedback only displays the most recent 50 reports, so - to prevent it from getting into oblivion - I'd like to repeat my suggestion to MS on how to implement both behaviours in one go here:

Two possible, alternative implementations would be easy to grasp and implement:

[ ] (A)
Add a Boolean (i.e. "either/or") option to Windows 10, so the user may decide on how he/she wants to use the pen (i.e. either scroll or text select when holding down the pen onto the screen (i.e. Morse code equivalent letter: "T")).

– or –

[ ] (B)

Whenever the user "double-clicks" and holds the pen (i.e. Morse code letter equivalent: "A") on a non-interactive area (i.e. text), he/she wants to select text.
On the other hand, when he/she justs holds the pen (i.e. Morse code letter equivalent: "T") he/she wants to scroll.

I would prefer option (B) to get implemented by MS:

And, please, MS, add a Boolean (i.e. "on/off") option to Windows 10 that will keep scroll bars from auto-hiding. It's uttermost tedious to look out for scroll bars if you don't see them. I neither need, like nor want scroll bars to auto-hide.

No @SetTrend I disagree with both of your implementations. The reason is because you are designing only for a tablet productivity user, whereas I am a digital artist user. I know other users who only write in Evernote then put their pen down. I'm sure there are other kinds of users out there I can't imagine. My point is that I use the pen as a drawing implement, and any other layers of usability that I cannot disable and modify in detail (e.g., scrolling, text selection, window swiping out of the way, et al.) have the very real potential to ruin my day or the day of someone else.
Please consider all usage scenarios before offering such a narrow range of implementations for the WindowsInk team, since they may only see your very smartly illustrated post and ignore others, working to please you, the most notable member of a disgruntled and very competent userbase, and in so doing ignoring the core problem: THERE'S NO ADVANCED SETTINGS MENU!

You are right, an Advanced pen menu would be perfect.
My proposal is for mainstream users indeed, because they aren't supported either. Currently no-one is satisfied. With my proposal a fair share of users would be satisfied, leaving a minor - yet undoubtedly important - group aside.
If the Windows Ink team agreed to provide even more advanced options, that'd be perfectly fine with me.
So, what'd be your suggestion on how the pen should specificly work to satisfy your needs?

There was nothing wrong with the old behaviour. If you wanna scroll with a pen you can buy one of those capacitive pens with a rubber tip.
Text selection in 1709 is inconsistent. Some places it works one way (old way) some places it doesn't work with barrel button, and sometimes like touch.

Open Notepad, and write something or open any txt file. Select text with the pen. Works exactly like expected. Writer, also works the same way.

Open edge and go to twitter, here or any other comment input field. Write something, and try to select the text. Sometimes you don't even get the handlebars, to change the span of the selection. Extremely frustrating.

Any kind of editing of text (selection, copy, paste etc) with the new behaviour is hard, tedious, and broken...
The new behaviour is so terribly poorly implemented it's not even funny. No amount of personalized settings would make it good, unless you can completely turn it off.
Best text selection I have encountered so far is in Firefox, in 1703. It uses the old behaviour along with handle bars.
Does anyone know where I can send my invoice to MS so I can charge them for lost productivity by completely ruining my workflow?

I believe this is a Windows issue, not a chromium one. After fall creators update, digital pen is treated as touch throughout the OS, including in menus and in Photoshop.

I can't see any particular improvement after installing that update?
No extra setting to opt-in/out of the touch behaviour, pen is still interpreted as finger touch.

same issue here. pen used to be able to select text, sections of code. Now it just interprets the pen as a finger touch instead of a mouse touch. Anyone fine solutions??

Dear tireless working AI,
run vscode in compatibility mode for Windows 7 and check 'Allow my pen to act as mouse in legacy applications in the 'Pen & Windows Ink' settings
now take a pen in your virtual hands and see how the pen selects text as it should, while touches keep scrolling
but please do not close this issue overzealously,  not all is well now, you can't grab tabs neither by pen or touch, scrollbar and minimap do not respond to touch drags, and who really wants to run good and modern vscode in compatibility mode (not all terminal and extension stuff may work as intended)
BTW, thank you for keeping open issues under 10000+ by diligently finding doubles, and last but not least give my best regards and hints (on this issue) to your human coworkers ...
Sincerely

AFAIK there is no possible code change we can do in VS Code to influence how these events reach us, so there is nothing I can do in our code base.


Open ai media streaming sample

Added sample code.
updated rt-client

NIT: I did a quick eslint, I found a few issues, I don't think they are critical, but I thought it was worth sharing it
\src\app.ts
   35:43  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   35:53  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   80:51  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
   80:56  error  'res' is defined but never used           @typescript-eslint/no-unused-vars
   80:61  error  Unexpected any. Specify a different type  @typescript-eslint/no-explicit-any
  107:70  error  Empty block statement                     no-empty

\src\azureOpenAiService.ts
  58:9  error  'configMessage' is never reassigned. Use 'const' instead  prefer-const


Custom OAuth issues since RC 3.0.0

My Setup

Operating System: Win10  Pro x64
App Version: 2.17.2 & 2.17.7
Installation type: exe

[ x] I have tested with the latest version
[ ] I can simulate the issue easily

Description
We use Keycloak for OAuth here. Since the Server Update to Version 3.0.0 multiple users, but not all,  experience login problems with the desktop client. They click on the login button, the circle animmation on the button starts, and then nothing happens. On the server side no logs are generated.
The browser version is not affected.
What we had to do after the update of RC:

Nodejs had to be updated as well, which caused some trouble.
We had to change the custom OAuth settings (login URL) from https to http, since our nginx has a redirect configured. With https we could not login anymore at all with OAuth. I know that the Android App and the Desktop Client had some issues with this roughly less than a year ago.

This issue could be related to this: 1468
I've posted there already, but that was a different matter (misconfiguration of IE settings for Kerberos SSO). The affected users now have standard settings.
Reload ignoring cache, un- and reinstalling the Client, deleting the RC Profile folder under Appdata\Roaming, and updating from 2.17.2 to 2.17.7 did not help either.
Current Behavior
Login fails, nothing happens.
Expected Behavior
Login via OAuth should work on all clients.

Hi! #1468 is my issue.
And I can tell you, that we a currently testing RC 3.0.0 in test environment and have no problem with KeyCloak login nor at domain joined computers nor at workgroup computers where KeyCloak FQDN is in Local Intranet security zone on Internet Explorer. If I remove KeyCloak FQDN from Local Intranet security zone on Internet Explorer - I get white screen with RC.Electron 2.17.7 and RC 3.0.0.
Can you try it in your environment on clients with problem?

Hi,
I've just double checkend and can confirm, that all our machines have the same settings. The Keycloak FQDN is set in the internet options (tab "security" -> intranet zone -> sites -> additional settings) on all our machines. Why would some of them fail to login?
We do not get the "white screen" since we use the redirect option in the custom OAuth settings. Our symptom is a frozen login button.
I've tried different users on the affected machines. It's definitely not a user problem :)
I've also tried different client versions. 2.16.2 does not handle the nginx redirect properly, 2.17.0 crashes after 1 second and 2.17.1 and above fail to log in.

I've just double checkend and can confirm, that all our machines have the same settings. The Keycloak FQDN is set in the internet options (tab "security" -> intranet zone -> sites -> additional settings) on all our machines. Why would some of them fail to login?

Could you please try to add Keycloak FQDN to Local Intranet security zone on Internet Explorer on onw single computer with problem? Just for a test reasons.

We do not get the "white screen" since we use the redirect option in the custom OAuth settings. Our symptom is a frozen login button

Yes, that's because you set to redirect. If you try to set New window you will get a white screen in that new window.

Sorry, there was a typo there. It should say intranet, not internet. It is already set. Yes, i can also confirm the white window.

Sorry, there was a typo there. It should say intranet, not internet. It is already set. Yes, i can also confirm the white window

You need to find out what is the difference between nornal and problem computers. For example, maybe problem computers go to KeyCloak though proxy server and normal computers has direct connection (KeyCloak URL excluded from proxy)

Can be closed. We had an old config entry in the systemd service file "node --tls-cipher-list". After removing that all our clients started to behave normally again. Some had to wait for the Keycloak token to expire. IOs and Android apps seem to be ok now. The frozen login button in the desktop app apparently is also fixed apparently.


⚠ PrivateHD has degraded performance

In 6b2a450, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 3493 ms

Resolved: PrivateHD performance has improved in 1ea8840.


What is right way to configure routes implemented in separate module?

We are splitting our frontend app into modules or features/plugins(in terms of aurelia).
Basically we want "module/feature" be an independent set of view-models, components and services that could be plugged in to main application.
Example:
plugin A:
   components:
    ....
   services:
        user-api.js
   vm
        users.js
        users.html
        user-edit.js
        user-edit.html

in the configure function of the plugin we add list of routes provided by the module to the main app:
        aurelia.use.plugin('user-management', (config) => {
            // this thing just add plugin routes to the registry
            routesFactory.registerModuleRoutes(config.routes);
        });

the issue we run into is how to specify moduleId for modules located in plugins?
I we specify moduleId: "./vm/users" router attempts load a file from apppath/vm/users.js which obviously does not exist. How to tell loader to load from jspm_packages instead?

Please ask questions in our public gitter channel. gitter.im/aurelia/discuss

Just in case someone will have a same question, the answer is pretty simple - just prefix module path with jspm dependency name, e.g.
moduleId: "user-management/vm/users.js"
where

user-management  is a module name
vm/users.js path to view model within a module

Basically  there is RouteLoader implementation that constructs viewModel name

//TemplatingRouteLoader.loadRoute (in templating-routing)

relativeToFile(config.moduleId, Origin.get(router.container.viewModel.constructor).moduleId)

relativeToFile resolves moduleId relatively viewModel that router belongs to.
so in case router is configured in dist/app.js and moduleId starts with "." (dot)  viewModel will be dist/moduleId.
then
CompositionEngine.ensureViewModel get called and actuall loading is happening in loadModule (aurelia-loader-default) where System.normalize resolve moduleId into the module path
      var newId = System.normalizeSync(id);
      var existing = this.moduleRegistry[newId];


Segmentation fault when execute insert into

Bug Report

`[n196-081-196] 2023.03.22 03:33:05.131951 [ 286 ]  BaseDaemon: ########################################
[n196-081-196] 2023.03.22 03:33:05.132052 [ 286 ]  BaseDaemon: (version <IP_ADDRESS> scm <IP_ADDRESS>, build id: 551E8F5B2EBF293E) (from thread 171) (query_id: b4a194b2-04f6-4451-b691-a81135d06eeb) Received signal Segmentation fault (11)
[n196-081-196] 2023.03.22 03:33:05.132090 [ 286 ]  BaseDaemon: Address: 0xffffffffffffff58 Access: read. Address not mapped to object.
[n196-081-196] 2023.03.22 03:33:05.132127 [ 286 ]  BaseDaemon: Stack trace: 0x14b6ae10 0x14a7c105 0x14058d72 0x140569ac 0x140560f4 0x140561ae 0x13aa1943 0x14d37caf 0x14d32b78 0x14d3fe5c 0x18f04c4c 0x18f0512c 0x18fe5dda 0x18fe398c 0x7f48ce31bea7 0x7f48cce2da2f
[n196-081-196] 2023.03.22 03:33:05.207677 [ 286 ]  BaseDaemon: 3. /data01/minh.dao/git/ByConity/src/Storages/MergeTree/MergeTreeDataWriter.cpp:364: DB::MergeTreeDataWriter::writeTempPart(DB::BlockWithPartition&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::__1::shared_ptr<DB::Context const>, unsigned long, long, long) @ 0x14b6ae10 in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.263677 [ 286 ]  BaseDaemon: 4. /data01/minh.dao/git/ByConity/src/Storages/MergeTree/MergeTreeBlockOutputStream.cpp:31: DB::MergeTreeBlockOutputStream::write(DB::Block const&) @ 0x14a7c105 in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.323805 [ 286 ]  BaseDaemon: 5. /data01/minh.dao/git/ByConity/src/DataStreams/PushingToViewsBlockOutputStream.cpp:190: DB::PushingToViewsBlockOutputStream::write(DB::Block const&) @ 0x14058d72 in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.335528 [ 286 ]  BaseDaemon: 6. /data01/minh.dao/git/ByConity/src/DataStreams/AddingDefaultBlockOutputStream.cpp:0: DB::AddingDefaultBlockOutputStream::write(DB::Block const&) @ 0x140569ac in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.340081 [ 286 ]  BaseDaemon: 7. /data01/minh.dao/git/ByConity/src/DataStreams/SquashingBlockOutputStream.cpp:0: DB::SquashingBlockOutputStream::finalize() @ 0x140560f4 in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.344551 [ 286 ]  BaseDaemon: 8.1. inlined from /data01/minh.dao/git/ByConity/contrib/libcxx/include/memory:2844: std::__1::shared_ptrDB::IBlockOutputStream::operator->() const
[n196-081-196] 2023.03.22 03:33:05.344578 [ 286 ]  BaseDaemon: 8. /data01/minh.dao/git/ByConity/src/DataStreams/SquashingBlockOutputStream.cpp:51: DB::SquashingBlockOutputStream::writeSuffix() @ 0x140561ae in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.354364 [ 286 ]  BaseDaemon: 9.1. inlined from /data01/minh.dao/git/ByConity/src/Common/Stopwatch.h:32: Stopwatch::elapsedNanoseconds() const
[n196-081-196] 2023.03.22 03:33:05.354400 [ 286 ]  BaseDaemon: 9.2. inlined from /data01/minh.dao/git/ByConity/src/Common/Stopwatch.h:34: Stopwatch::elapsedMilliseconds() const
[n196-081-196] 2023.03.22 03:33:05.354419 [ 286 ]  BaseDaemon: 9. /data01/minh.dao/git/ByConity/src/DataStreams/CountingBlockOutputStream.cpp:78: DB::CountingBlockOutputStream::writeSuffix() @ 0x13aa1943 in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.443781 [ 286 ]  BaseDaemon: 10. /data01/minh.dao/git/ByConity/src/Server/TCPHandler.cpp:614: DB::TCPHandler::processInsertQuery(DB::Settings const&) @ 0x14d37caf in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.524204 [ 286 ]  BaseDaemon: 11.1. inlined from /data01/minh.dao/git/ByConity/src/Common/Stopwatch.h:43: Stopwatch::nanoseconds() const
[n196-081-196] 2023.03.22 03:33:05.524259 [ 286 ]  BaseDaemon: 11.2. inlined from /data01/minh.dao/git/ByConity/src/Common/Stopwatch.h:28: Stopwatch::stop()
[n196-081-196] 2023.03.22 03:33:05.524280 [ 286 ]  BaseDaemon: 11.3. inlined from /data01/minh.dao/git/ByConity/src/DataStreams/BlockIO.h:68: DB::BlockIO::onFinish()
[n196-081-196] 2023.03.22 03:33:05.524320 [ 286 ]  BaseDaemon: 11. /data01/minh.dao/git/ByConity/src/Server/TCPHandler.cpp:366: DB::TCPHandler::runImpl() @ 0x14d32b78 in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.620599 [ 286 ]  BaseDaemon: 12. /data01/minh.dao/git/ByConity/src/Server/TCPHandler.cpp:1874: DB::TCPHandler::run() @ 0x14d3fe5c in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.622078 [ 286 ]  BaseDaemon: 13. /data01/minh.dao/git/ByConity/contrib/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x18f04c4c in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.626651 [ 286 ]  BaseDaemon: 14. /data01/minh.dao/git/ByConity/contrib/poco/Net/src/TCPServerDispatcher.cpp:114: Poco::Net::TCPServerDispatcher::run() @ 0x18f0512c in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.630546 [ 286 ]  BaseDaemon: 15.1. inlined from /data01/minh.dao/git/ByConity/contrib/poco/Foundation/include/Poco/ScopedLock.h:36: ScopedLock
[n196-081-196] 2023.03.22 03:33:05.630577 [ 286 ]  BaseDaemon: 15. /data01/minh.dao/git/ByConity/contrib/poco/Foundation/src/ThreadPool.cpp:213: Poco::PooledThread::run() @ 0x18fe5dda in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.633877 [ 286 ]  BaseDaemon: 16.1. inlined from /data01/minh.dao/git/ByConity/contrib/poco/Foundation/include/Poco/SharedPtr.h:156: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicyPoco::Runnable >::assign(Poco::Runnable*)
[n196-081-196] 2023.03.22 03:33:05.633914 [ 286 ]  BaseDaemon: 16.2. inlined from /data01/minh.dao/git/ByConity/contrib/poco/Foundation/include/Poco/SharedPtr.h:208: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicyPoco::Runnable >::operator=(Poco::Runnable*)
[n196-081-196] 2023.03.22 03:33:05.633936 [ 286 ]  BaseDaemon: 16. /data01/minh.dao/git/ByConity/contrib/poco/Foundation/src/Thread_POSIX.cpp:360: Poco::ThreadImpl::runnableEntry(void*) @ 0x18fe398c in /root/app/usr/bin/clickhouse
[n196-081-196] 2023.03.22 03:33:05.634009 [ 286 ]  BaseDaemon: 17. start_thread @ 0x7ea7 in /lib/x86_64-linux-gnu/libpthread-2.31.so
[n196-081-196] 2023.03.22 03:33:05.634055 [ 286 ]  BaseDaemon: 18. clone @ 0xfca2f in /lib/x86_64-linux-gnu/libc-2.31.so
[n196-081-196] 2023.03.22 03:33:05.759949 [ 286 ]  BaseDaemon: Calculated checksum of the binary: 26CE6A2543BDC31DB6339A026B71E95F. There is no information about the reference checksum.
Exception on client:
Code: 32. DB::Exception: Attempt to read after eof: while receiving packet from <IP_ADDRESS>:18684 SQLSTATE: 22000
Connecting to <IP_ADDRESS>:18684 as user default.
Code: 210. DB::NetException: Connection refused (<IP_ADDRESS>:18684) SQLSTATE: 08000`
Briefly describe the bug
Segmentation fault when execute insert into
The result you expected
How to Reproduce
CREATE OR REPLACE TABLE test_jx (     id UInt64,     name String ) ENGINE = MergeTree ORDER BY id;
insert into test_jx values(1,'1');
Version
use docker : byconity/byconity-server:stable which is pushed to repository

Hi, the MergeTree engine is not used in ByConity. Can you use ENGINE = MergeTree ?
For the core of usage MergeTree, we will take a look.

Hi, the MergeTree engine is not used in ByConity. Can you use ENGINE = MergeTree ?
For the core of usage MergeTree, we will take a look.

Do you mean CnchMergeTree ?  CnchMergeTree is good.

And I have an another question: the docker which I depolyed is not built on the current code of master.
docker pull byconity/byconity-server:stable
I use the docker command above to get it from public repository.
Is it very different from the current version ?

MergeTree

oh，yes, my fault, it is CnchMergeTree

And I have an another question: the docker which I depolyed is not built on the current code of master. docker pull byconity/byconity-server:stable I use the docker command above to get it from public repository. Is it very different from the current version ?

^^ we are now testing  Byconity, if byconity/byconity-server:stable is too old, we will rebuild the docker

Yes, you can follow this guid to build https://github.com/ByConity/ByConity/blob/master/docker/executable_wrapper/Update_docker_image.md

Yes, you can follow this guid to build https://github.com/ByConity/ByConity/blob/master/docker/executable_wrapper/Update_docker_image.md
So,  You mean byconity/byconity-server:stable is indeed very different from the current version ?

it is behind master but not too much.

it is behind master but not too much.

OK, thank you very mach!


Adding Public recipes views

Things I have done:

[ ] Added public recipe view
[ ] Added link to recipe details
[ ] Added delete recipe button for authorized users

Hello @SnakyMz
Great job, Your project is complete! There is nothing else to say other than... it's time to merge


Point (De-)Cluster Renderer

It would be useful to display vector data using a clustering or de-clustering visualisation.
Ideally configurable in the appContext.
There are already OpenLayers based implementations from ol-ext

demo
cluster interaction

Would you be interested in a contribution for this?
Or would it be more valuable to work on #261 first?

Hi @spwoodcock,
both of those would be valuable contributions, so it's definitely appreciated if you pick one and work on it.
Regarding #261 I'm not familiar with the latest state. Since we're in the process of moving towards Wegue 2 a migration to OL 7 would become feasible. But it's probably a good idea to move in small steps and support the latest OL 6 version first.
Cheers Felix

Hi @spwoodcock , thanks for your will to contribute. Very much appreciated! Recently we had a project where I did something in the direction of clustering / declustering. Unfortunately the clustering algorithm is not optimal in the current Wegue OL Version 6.4.3. But it got optimized in later OL 6 versions. Therefore I'd suggest to go to latest OL v6 before working on a clustering solution.

Hi @chrismayer, I also have worked on a project with clustering on ol6.4+ and it worked nicely.
Let's wait for #320 then before starting this.


Confusing docs for .parse

Bit confused by the docs for parse:

Given any Zod schema, you can call its .parse method to check data is valid. If it is, a value is returned with full type information! Otherwise, an error is thrown.

IMPORTANT: In Zod 2 and Zod 1.11+, the value returned by .parse is a deep clone of the variable you passed in. This was also the case in<EMAIL_ADDRESS>and earlier.

OK, but what does it return now? I would have assumed a deep clone. I looked in the changelog but it just says "Parsing no longer returns deep clone".

Good call, just pushed a clarificaiotn


added internet connection detector

Related Issue
Closes: #1790
Describe the changes you've made
added a new project which detect you are connected with internet or not.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots
Put any screenshot(s) of the project here.
Online

Offline

Add Project in projectlist. Rest everything is fine

done please check


Issue client decoding client certificate forwarded from nginx

The example for forwarding client certificates from nginx does not compile.
The method X509Certificate2.CreateFromPem(certPem) no longer(?) exists. It requires a private key which is not provided from the client.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35b7960d-6de5-78ee-bc45-d7218239bbc8
Version Independent ID: d2db534b-198a-dc99-5b5a-0525582d39ac
Content: Configure certificate authentication in ASP.NET Core
Content Source: aspnetcore/security/authentication/certauth.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @blowdart
Microsoft Alias: bdorrans

Thank you for contacting us. Due to a lack of activity on this discussion issue we're closing it in an effort to keep our backlog manageable. If you believe there is a concern which hasn't been addressed, please file a new issue.


Submit a prompt with prior prompts-responses as context

Implemented in https://github.com/tomzx/autogpt/commit/e2775b6eba6baa6b805c41cc83d4dae741656562.


Support Package.swift version 2 Specification

Fixes Issue
Description of Change
With the recent release of Swift 5.6 there is a new specification for the Package.resolved dependencies file. This PR aims to support the new spec on the analyzer since the structure of the file has changed.
Have test cases been added to cover the new functionality?
yes

Thank you for the PR! This will get merged - but we are going to do a bug fix release first.


Latest activity section can't be closed

Weird.
The post game summary showing X% of players have this achievement has the close button for me.
Though yours lacks the Post-Game Summary header, so dunno if this is a similar-but-different dialog.

Seems like they fixed it with todays release, thanks for the advice!


Documentation does not reflect behavior of endpoint: Tenant Configuration - Save

Hi, I've been tampering with this endpoint now and found what i think is discrepancies in the behavior of the endpoint.
Event though it's noted in the description that this is a long running operation, and that you can receive both a 200 OK and a 202 Accepted, I've only received 200 OK, instantly. This behavior led me to believe that the operation was successful and just worked fast since i got an id in the response body like:
{
  "id": "72a02da15fff1710544e8fbb"
}

However, this response body does not seem to match any of the response objects documented, and the operation is indeed not completed so I think I should have gotten a 202!
I've linked to the documentation below:
https://github.com/Azure/azure-rest-api-specs/blob/d006e1d15d8fe19a6c558861dd5bba6b7baa8dd8/specification/apimanagement/resource-manager/Microsoft.ApiManagement/stable/2021-08-01/apimtenant.json#L596-L647

After further investigation the validate and apply configuration endpoints behave very similar.
The request returns a 200 OK with an id, which I consider indicate success, but is infact still running in the background. How do i get a 202 with the status URL?

I did just realize that this is a case of me just needing to RTFM a bit better.
For anyone finding this issue in the future, the API did indeed respond with a 202, and the section where they specify
location: https://management.azure.com/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1/tenant/operationResults/5a1af64e2a6d2e0b688d751e?api-version=2021-08-01
It's of course the location HEADER in the HTTP request and not the body, which makes total sense.
This doc resource might also be valuable for you.


translate concepts/workloads/pod

translate concepts/workloads/pod

Preview is here.
https://deploy-preview-35--kubernetes-docs-ja.netlify.com/ja/docs/concepts/workloads/pods/pod-overview/


I had the privilege to read your article. May I ask when your code will be published?

Hi @weiran102 . Thank you for your interest in our work! We will share the codes by the end of this month. Please follow the updates.


Book typos

Hi @apotonick
I just finished reading the book and I have to say there's a lot of great ideas in it ... Thanks for all the experimentations and hard work you put into it !
As you said I might need to let it sink a bit. I think I'll wait for the next decently-complex feature request to pop up and try to use Trailblazer to implement parts of it. Would you have some recommendations on just this ?
Anyway, alongside my reading I filled this Google Sheet with a few typos and inconsistencies I found.
A humble attempt to repay for your efforts. :bow:

Further to @jerefrer's comments on @apotonick's book, it would be great if you could run:
s/gonna/going to/g
on the source material

Ok, finally, I managed to incorporate all your fixes @jerefrer and I have to say, I'm impressed by your work. This was an amazing help, thank you so much for going through all this with that fine-toothed comb :joy: !
I would like to offer you a year of free membership for Trailblazer Pro (coming soon). Let me know if you're interested? :heart:
@peterhoeg Done! Only 75 replaces :lowersheadinshame:.

Haha I'm touched by the kind word but really it's nothing compared to the time I imagine you put into all this.
Thank you @apotonick for incorporating them !
Of course I'd be happy to get some free stuff (who isn't ?!), even though I don't know what it is !
Anyway, now I can't wait to know more :open_mouth:.
PS: I don't know if this Pro thing would include screencasts, but I think it would be a great addition to the TB world. Having been a fan of Railscasts when I first learned Rails, I really felt that the lack of them with TB hold me back in my learning process.
Please, screencasts ? :wink:

Would love to do screencasts - if this whole TRB thing starts paying off, I will have time for more learning content.

Ok no worries, I'll dig into the book !
I wish you quick and huge success with what's coming ! :tada:

This is Pro: https://trbpro.herokuapp.com/ :tada:


[WIP] Glowstone++ Refactor

Refactored some things, using new Java 8 features, and some other optimizations/improvements.
This is just to track changes and progress. The PR is not ready to pull.

Closing this as the scope of this is huge. I have separated it into the jdk8 branch and microredux branch.


doc: Wrong documentation for totalConstMem

See https://github.com/ROCm-Developer-Tools/HIP/blob/685390469af762268ab766245933033455f8c29d/include/hip/hip_runtime_api.h#L99
The totalConstMem member has the same documentation as sharedMemPerBlock:
size_t sharedMemPerBlock;  ///< Size of shared memory region (in bytes).

@bertwesarg  Hi, were you able to resolve this issue on the latest HIP? If so can we close this ticket?

I'm not sure how I can resolve this. The code itself still looks the same:
    size_t totalConstMem;             ///< Size of shared memory region (in bytes).

@bertwesarg Internal ticket has been created to resolve this issue. Thanks!


Fix for cross-browser clearing test results is incomplete in 3.0.60

Fixes have been made in the clearing of test results between browsers per issue #419 and issue #293.  Closing both those per Eric's request and opening a new issue.
Marking as February since this is really part of one of the stability issues that was intended to be fixed for this drop.
Specific known problems:

[x] Have two project browsers open on two different test classes.  No other browsers open on any of these classes.
In one, go to the sunit tab and run tests.  See icons.
In the other, select the same class that is selected in the first browser.  See test icons disappear.

[x] Have two project browsers open on the same test class.  No other browsers open on this class.
In one, go to the sunit tab and run tests.  See icons.
In the other, edit a method (it's more compelling when you edit a method that isn't a test method, but it doesn't matter).  See test icons disappear.

These operations don't effect the Sunit browser.  If you have the Sunit browser sitting around, these bugs don't show themselves, since the Sunit browser creates great stickiness of test results.

Should be a fix for part 1 in https://github.com/GemTalk/Jadeite/commit/28b45e1b40d213ddd8a1663c7cd9a3779c6c277d

I'm pretty sure that the second item was fixed as part of the first in 3.0.61. Please reopen if that is not so.

still see some behavior that's not entirely solid when it comes to cross-browser sunit result; the banner is too quick to clear in the project browser and maybe not quick enough in the sunit browser, and I'm not sure the exact semantics of the browser in some cases.  However, it's no longer appears to be confusing, wrong or losing results, so I'll call it good enough.


Docker build with error /usr/lib/apt/methods/https could not be found.

Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[X] I have reproduced the issue with at least the latest released version of superset.
[X] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
https://github.com/apache/incubator-superset/commit/2d4a1ab68ad8d5a70c544e87104a2a59b9f3d949
Expected results
Build docker images without errors or warnings
Actual results
E: The method driver /usr/lib/apt/methods/https could not be found.
E: Failed to fetch https://dl.yarnpkg.com/debian/dists/stable/InRelease
E: Some index files failed to download. They have been ignored, or old ones used instead.

AND
debconf: delaying package configuration, since apt-utils is not installed

AND
Warning: apt-key output should not be parsed (stdout is not a terminal)

Steps to reproduce
bash -x docker-build.sh

I try to fix this problem by changed the Dockerfile.
add this line
RUN apt-get install -y apt-transport-https apt-utils


bump version 0.26.1

Description:
bump version 0.26.1
Related issue(s):
#1387
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch and project coverage have no change.

Comparison is base (adb53bc) 77.83% compared to head (8270fa6) 77.83%.

:exclamation: Current head 8270fa6 differs from pull request most recent head 47b6ee4. Consider uploading reports for the commit 47b6ee4 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           release/0.26    #1425   +/-   ##
=============================================
  Coverage         77.83%   77.83%
=============================================
  Files                32       32
  Lines              2599     2599
  Branches            539      539
=============================================
  Hits               2023     2023
  Misses              402      402
  Partials            174      174

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Bug - 2.3.4 - Expected string or number on left hand side of operation, got array.

Steps to replicate the issue
From https://source-academy.github.io/sicp/chapters/2.3.4.html#h2
I clicked this link https://share.sourceacademy.nus.edu.sg/4g to test the weight function. But the same errors happen for the symbols function.
I expected to get 11. However, this is what I guess:

Errors:
Line 7: Expected string or number on left hand side of operation, got array.
Hints:
Line 36: A type mismatch was detected in the function call:
  weight_leaf(tr ... ee)
The function expected an argument of type:
  [T0, [T1, [T2, T3]]]
but instead received an argument of type:
  [string, [T0, [List<T1>, T2]]]

Workaround
If I choose Source §3, it works correctly. However, I am not sure it affects anything then.

Solution
I am not familiar with how this really works behind. But my humble guess is that there are something missing in the sublanguage  Source §2.

This is already a problem in the original SICP (Scheme). The primitive function eq? is introduced in 2.3.1 as an operation on symbols (SICP JS uses strings to represent symbols), but the function leaf? (is_leaf) applies eq? to the first element of a code tree, which is a list. The problem shows up due to the recent restriction of === to strings and numbers. The fix is to give code trees a tag, like leaves. The fix is already installed in SICP JS, so you can run the example again and see that it works as expected.

Thank you. I confirm it's working now!


What does each branch mean?

now,the code have dev-0.2/dev-0.3/master/view branchs,What's the difference between them?if i want run it ,Which one branch should I choose?

master is the latest stable version, dev-0.2/dev-0.3  are dev; if you want run it,  you should choose dev-0.3.


Fatal error: Unexpectedly found nil while unwrapping an Optional value

report : SwiftHeicToJpgPlugin.swift, line 28

Sorry I made you wait too long.
I just fixed it.
And Thanks for reporting this issue!


Kanban board setup

We are two people in our project
Here is our project URL: https://github.com/users/Marcraphael12/projects/8

Hi @Marcraphael12 and @MoyasiGinko
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔  Good issue description
Required Changes ♻

[ ] Kindly name your columns on your board correctly, Your first column should be named as  Todo all your cards should be in the To Do column 👍🏿

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Status: Approved :heavy_check_mark:
Hi @Marcraphael12 & @MoyasiGinko, 👋 👋
Your project is complete! Great job for following the project requirement🥇and implementing the changes requested by the previous reviewer. There is nothing else to say other than... It's time to merge it 🍾🚢 :shipit: . Congratulations!  🎉💯🌟

Good Points 👍

Task properly assigned ✔
kanban board created ✔
Descriptive issues✔

Optional changes

[Optional] I would kindly suggest you give details about the two people involved in the project(i.e. their GitHub account details). Also provide the link to the project reop in the issue summary

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brainconnect93 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

Thanks for approving

Thanks for reviewing


TypeScript should respect "instanceof" in logical expressions

Hello!
Thank you for your hard work.
Please, consider this code:
class Foo {
    foo: string;
}
class Bar {
    bar: string;
}

function foo(value: Foo | Bar) {
    const isFoo = value instanceof Foo;
    const isBar = !isFoo && value.bar; // <-- causes error
}

The line above throws an error:
Property 'bar' does not exist on type 'Foo | Bar'.
Property 'bar' does not exist on type 'Foo'.

However, if I replace the logical variable with the expression directly, it works:
const isBar = !(value instanceof Foo) && value.bar;

The isFoo variable in my example is a boolean constant, it's value can't change, so I believe it should be statically analyzable.

Duplicate of https://github.com/microsoft/TypeScript/issues/12184


Update README.rst

make it more easier to understand for newbie users :)

I'm in the process of writing proper documentation for this plugin. I'll update the wording and take your suggestions into consideration and update the Readme in due course.
Thank you once again for your time and effort... don't forget to hit the 'star' button :-)
— Mishbah


Start task fails for preempted nodes because unzip prompts for overwrite

Some clusters with preempted low pri nodes are having their start task fail when the node comes back:
replace aztk/client.py? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
(EOF or read error, treating as "[N]one" ...)

We need to pass the -o overwrite flag to all unzip commands in the start task.

Fixed by #510


Update docs

Codecov Report

Merging #13 (9aced06) into master (5f49259) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #13   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity         5         5
===========================================
  Files              2         2
  Lines             10        10
===========================================
  Hits              10        10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f49259...9aced06. Read the comment docs.


Time literals should use single quotes in String representation

I am using the influxql package to parse an generic query and add a specific time clause to the query. Since a TimeLiteral needs single quotes when parsed I have updated the String representation to also use single quotes as well as the test cases.

@beckettsean, @dgnorton -- any comment?

+1 from me. Timestamps as strings should be in single-quotes to be consistent with strings elsewhere. Double-quotes should only be for identifiers.

Yep, agree. Thanks!


Feature: Moved Settings button to Sidebar

TBA in the next release.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

[ ] Add a temporary setting to manage preference of Settings button location
[ ] Add ability to render PathIcons and OpacityIcons in SidebarItem
[ ] Adjust margin

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Open Files app

Screenshots

I tested on my local but interaction test seems to be failing. @yaira2 how did you fixed the last time you encountered?

It seems to be related to this issue https://github.com/microsoft/microsoft-ui-xaml/issues/1971

I tested on my local but interaction test seems to be failing. @yaira2 how did you fixed the last time you encountered?

It seems to be related to this issue https://github.com/microsoft/microsoft-ui-xaml/issues/1971.

@0x5bfa the changes in c5b0cfd are still needed for the tests.

I'm quite sure that the test errors stem from the fact that the settings item is unable to resolve its position inside the list of items.
When implementing UIA patterns for lists (like the SideBar is), the elements should/need to determine where they sit in that list (SizeOfSet and PositionInSet). The settings item however is an outlier for this and the logic we currently use does not work for the settings item resulting in it not knowing its position in set (method throws an exception),

As Windows Terminal does, I tried to implement IList PaneFooterItems in SidebarView, but there was casting error and null ref at runtime as a result it caused xaml unhandled exception.
What’s the best way to overcome this issue?

Fixed

I think we need to fix the icon alignment on the footer item

Footer uses the same xaml. I think icon element has 40 width and centered, and leader has 8 padding from the left, in a result it keeping a correct alignment seemingly. But we should set column width to Auto.

[x] icon alignment DONE
[ ] hide the button in compact overlay FAILED
[x] tooltip should display keyboard shortcut DONE

hide the button in compact overlay FAILED

I think we can remove this requirement (especially if we end up switching Settings to a tab).

@yaira2 I’d like to close and re-implement after refactoring because this is most likely to be altered again when refactoring.


Retrospective Joan

what went well in the sprint?
Everything went well as the team had a good team work and communication
progress was fast since everyone is on the same page
what could be improve - team dynamic and management?
everything went well
what will we commit to improve?
more meetings


Describe each point in the agenda

Just started reviewing :) :octocat: Sent from GH.

Merged!
Thank you!


Support creating symlinks without elevated privileges

https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/

Directory symlinks already can be created without admin privileges on Windows by using the UV_FS_SYMLINK_JUNCTION flag with uv_fs_symlink(). The Node.js fs.symlink() API exposes that functionality using a type of 'junction'.
Is this request referring to file symlinks?

@jasongin Yes, this refers to file symlinks.  Ideally we'd always use the flag to do it without elevation, if it's supported, making it transparent to the user.

+100

I've made PR for this: https://github.com/libuv/libuv/pull/1346


Vendors not accepting items created by the profile editor

Versions

SPT-AKI Server version - 3.5.0
SPT-AKI Profile Editor version - 2.6

Describe the bug
Trying to sell to a vendor a item created using the profile editor results in negative from the vendor.
I played around with the profile file and noticed that the items created had non-hexadecimal characters. Somehow the game doesn't care about it, but the vendor notice it because once the invalid chars were replaced in the IDs, the items could the sold perfectly.
Additional context
profile.zip

I've created a PR with a fix
https://github.com/SkiTles55/SPT-AKI-Profile-Editor/pull/68

@havaed Good job. Thank you!


bcprov-jdk15to18-1.69.jar library vulnerability

Hi Team,
We found new vulnerability introduced in bcprov-jdk15on-1.69 library, so we need to get rid of it.

We have checked all runtime and compile time dependency, however we could not find  bcprov-jdk15to18-1.69.jar and its dependency.
Also we tried to download and extract war from bamboo artifact and checked under path /WEB_INF/lib, but we didn’t find jar and its dependency there as well.
Can any one please help here ?
Thanks.

Duplicate of #1505


integration test: Method of locating the meetup executable is needs improvement

It currently is a hard coded path. This has all the issues of that solution. Any new version of this would need to allow the majority of the meetup code to be tested.
The original environment for the meetup code was in a separate process. While that is the ideal solution to this, it is not a specific requirement.

Merged to master


react-dnd v9 uses spread operator, breaks older browsers

Describe the bug
Typically, consumers of libraries like react-dnd don't run their node_modules through Babel to transform newer syntax. There's a bit of a debate over when and how we should all start doing that, but it's not a great option right now. In v9, the es-modules exported version of react-dnd also started using some newer browser features (specifically, the spread operator) which if not transpiled out will fail to parse in browsers like MS Edge 17 which still don't support that syntax.
Reproduction
Steps to reproduce the behavior:

Bundle an app with v9 of react-dnd
Open in Edge 17.
SCRIPT1028: Expected identifier, string or number

Expected behavior
It's expected that libraries (even if they are vended as ES modules) do not use newer syntax, or that they include specific instructions in the README that they must be run through babel in order to work.

I'd recommend using babel-preset-env to transform the distributed source based on a list of supported browser versions.

Just noticed that problem too, do you implemented any workaround on your end?
I already use babel-preset-env in my project. But that does not help.

Have the same issue.

This is one of the reasons we ship two variants of the library. Why not use the react-dnd-cjs library?

So, the alternative would be to ship react-dnd with a folder structure like, which would require a major version cut. The default would be esm/esnext, but you could alias out to whatever module/target combo you want.
dist/umd/
dist/esm/esnext/
dist/esm/es2017/
dist/esm/es2016/
dist/esm/es2015/
dist/esm/es5/
dist/cjs/es2017/
dist/cjs/es2016/
dist/cjs/es2015/
dist/cjs/es5/

What most libraries do is to ship es modules, but use babel-preset-env to translate that source down to the least common denominator among the browsers they support.

Right, so we'd just have to decide what our ongoing preset-env  support would look like and add a babel step after typescript compilation.
I'd like to avoid endlessly supporting older browsers like IE11, so whatever preset we would ship with would be a live target.

I'll look into chaining babel after the tsc compilation. I think some light processing to hit a fixed browsers target ">.25%, not dead", makes sense

Actually, using babel directly for all transpilation is pretty great. And this wouldn't necessitate a major version cut


autoscroll when new message appears

Yet another change to the paradigm. This is the simple approach:

when a new message comes in, scroll to the bottom.

Fixes #190

I'm not sold on this paradigm. For bots, especially, there will be times I want to scroll back and look at previous results. I don't want the system scrolling me to the end every time something new comes in. Consider a bot that sends me updates on server issues even minute. If I'm looking at a big problem that happened an hour ago, I really want to keep looking at it.

Ok. As @jecristi has pointed out- we should also add a Toast mechanism telling the user that there are new messages. I will retract this PR.


Add cursor color and cursor_text_color

Closes https://github.com/connorholyday/kitty-snazzy/issues/5.
I took the cursor color from https://github.com/sindresorhus/hyper-snazzy/blob/f544d59f781bd4f510695c7dfeede40026b9a83c/index.js#L15. I realise, that it is very similar to kitty's default. Let me know if you prefer a different color.

Looks good to me, thanks for the work 👍


ABFS in Hue

Implements the Azure Lake Storage Version 2 into Hue
Note: Currently has bugs, will edit in future commits

Also nit: could you add the Hue jira number, e.g.
'HUE-XXX [adls2]' as prefix to all the commits?


PRED_SPLIT produces false negative results for XCFA

There are wrong results with the current version (5.1.1) of Theta.
See results:
split.zip
Ignore floats-cbmc-regression/float8.yml in the results, that has a different root cause.

Until this is fixed, the frontend rejects the --domain PRED_SPLIT argument with the message
Validation failed for rule NoPredSplitUntilFixed(https://github.com/ftsrg/theta/issues/267).

It seems like this issue exists only with lazy pruning.


chore: update strapi

:tada: This PR is included in version 1.4.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Incorrect anchor links on documentation website

The Parameters and Examples links in the Table of Contents of most pages on the documentation website point to the wrong heading id. The links contain hyphens and the id's contain underscores. For example, api-output/#parameters-3 should instead point to api-output/#parameters_3.
However, I'd rather adapt the id attributes in this case, and use hyphens in the urls.

Hello, JSDoc comments in the source are automagically converted to Markdown by documentationjs and then converted into HTML by Read The Docs.
The former correctly outputs Markdown with references containing hyphens but it looks like the latter is inconsistently converting these to underscores some of the time. It's probably a bug in either the recommonmark or readthedocs repo. I had a quick look at the open issues but don't see anything related.
If you're able to isolate the problem further and submit a bug report upstream, that would be great.

I found the source of the problem to be Python-Markdown that appends _1, _2, ... whenever it encounters duplicate headings. So it's not really a bug. Could ask for an option to use hyphens instead.

Great detective work, thank you Thomas.
Trying to get all the major Markdown libraries across all languages to agree on how to handle duplicate headers is probably a fool's errand.
Given that Read The Docs already generates its own TOC on the left, I'm not sure how valuable having another TOC at the top of each document is, so a quick fix might be to remove it via documentation build --markdown-toc=false - see https://github.com/lovell/sharp/blob/master/package.json#L59
Happy to accept a PR with this change if you're able.


Always register to state changes and new services

Since the component relies on these events internally to function, we
should always subscribe to them.

This solves my issue of binary motion sensors not triggering automations. Thank you!!


How to setup Traefik behind Hetzner Load Balancer to trust X-Forwarded-For?

Hey, I'm seeing incorrect X-Forwarded-For headers in my FastAPI Application. This is due to Traefik not trusting the X-Forwarded-For headers send by the Hetzner Load Balancer.
How to setup Traefik correctly behind Hetzner Load Balancer?
traefik:
  args:
    accesslog: "true"
    log.level: "ERROR"
    # does not work:
    # entryPoints.http.forwardedHeaders.insecure: "true"
    # does not work:
    # LOAD_BALANCER_IP
    # entrypoints.http.forwardedHeaders.insecure: "<IP_ADDRESS>/32,LOAD_BALANCER_IP"

traefik:
  args:
    entrypoints.web.forwardedHeaders.trustedIPs: <IP_ADDRESS>/8

Hey Matt Almeida,
thank you for your response. I'm afraid that doesn't work for me. Can someone reproduce / describe their setup if they face the same problem?

Our repo is open-source, so feel free to look at the full file. Our Hetzner load balancer is on 10.x.x.x so that's why it works:

Hey @northeastprince I have taken a look. Is your LB & server running in a Private Network? I currently refer to it via it's public IP as my server is also running with a public IPv4.

Yes, it's on the same private network as the LB.

Working through a similar issue with forwardedHeaders not functioning properly.
@liamvdv Did you get this working?
What I'm trying to solve for is I have Traefik as main reverse proxy, that manages routing to a Kamal deployed app (with the traefik-in-container). Each time I use the traefik args with entrypoints (and no other traefik config) my app redirects to https and is non functional.
I've debugged with turning on the Dashboard, noticed Kamal manages the http entrypoint as default, tried entrypoints.http.forwardedHeaders.trustedIPs but making no progress.
Furthermore, I realized that Kamal utilizes docker as a provider in traefik which would mean passing labels as configuration should be picked up as detailed: https://doc.traefik.io/traefik/routing/providers/docker/#routers

Hey @eminkel
no sadly not. It is still on our plate, yet other challenges have kept us busy. @dhh any idea as to why?
@eminkel if you figure it out, please come back here, we've easily sunken 6h+ into this...

@liamvdv, I just successfully got it working. This feels a bit clunky compared to the Kamal documentation of how this should work, but here it goes:
For your main web role hosts you'll want to add a label:
labels:
  traefik.http.routers.your-service.entrypoints: web

For the traefik config in your Kamal yaml file you'll then want to be sure to have the following set:
traefik:
   args:
     entrypoints.web.address: ':80'
     entrypoints.web.forwardedHeaders.trustedIPs: <IP_ADDRESS>,<IP_ADDRESS>/24

Once you have this set, blast away your traefik container with kamal traefik reboot, then kamal deploy.
Hope this helps get you up and going. I'm finally passing the proper IP in the logs in the Rails App.

@liamvdv - does @eminkel's solution work for you?

@eminkel this finally works. Thanks a lot for your help.
@djmb I'm sorry it took so long. Yes it now works like a charm.


[stable/docker-registry] Add pod annotations and checksum for configmap to deployment

The will allow us to annotate the pod as necessicary and will restart the Deployemnt on ConfigMap changes

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign
/ok-to-test

/lgtm

/assign @prydonius

/lgtm

@unguiculus There was a PR merged that updated the docker-registry so I had to rebase.
Can I get another review please?

/lgtm


Android MapRegion incorrectly constructed in OnCameraChange

When OnCameraChange is called on VisibleRegion is updated, the construction of MapRegion has its parameters incorrectly ordered.
In UnifiedMaps.Droid.UnifiedMapRenderer.cs:
var region = new MapRegion(mapRegion.Northeast.Latitude, mapRegion.Southwest.Longitude, mapRegion.Southwest.Latitude, mapRegion.Northeast.Longitude);
In MapRegion.cs:
public MapRegion(double minX, double maxY, double maxX, double minY)

Implemented in v1.3.6


Provide --complete-copy Option for Instrumentation as in Istanbul

I used to run my instrumentation step with istanbul using something like this:
cross-env NODE_ENV=test istanbul instrument -i ./src/main/webapp/src -o ./src/main/webapp/instrumented --complete-copy

It basically instrumented all of the .js files, but also copied everything else, so that I could then build that folder and package it with my backend code (in this case a Java backend).
I'm trying to find a way to do it with nyc. When I run:
cross-env NODE_ENV=test nyc instrument ./src/main/webapp/src ./src/main/webapp/instrumented

That takes care of the files needing instrumentation, but I cannot get the --complete-copy behaviour present in istanbul.
I am currently doing the build with Webpack and babel-plugin-istanbul, which takes care of the problem for now, but it would be great if there was an equivalent using nyc instrument.

@juancarlosfarah this sounds like a great addition to functionality.
For anyone who happens to come across this issue, this seems like a great first contribution.


Graceful error handling for host function calls from guest modules

This PR is intended to allow Go host modules to return errors to guest module function calls. In order for this to work properly, each of the PDKs also needs to be updated to expose an extism:host/env function called host_func_get_error which returns an offset to an error message, or 0 if no error was set. Host functions that return an error will save the error message within internal extism host state which is accessible by host_func_get_error.
See https://github.com/extism/rust-pdk/pull/73

After discussing with @zshipko I've changed the approach to use the existing error_set and error_get functions. Previously, the PDKs would use error_set to pass errors from the guest to the host. This changes allows the host to call error_set in order to pass host errors to the guest.
So long as guests always check for host errors after host function calls, and hosts always check for guest errors after guest function calls (which should be happening already as I understand it), then we would never see a conflict.
My assumption is that outdated PDKs that do not support this functionality will result in this PR having no effect since they would simply not know to call error_get.

This commit is a rough example of a possible solution to the problem discussed in office hour today -- specifically that if a guest PDK does not know to check and reset an error set by a host function, then the host will see its own error when it checks here
https://github.com/extism/go-sdk/blob/bef00f39873e5917d19b4d981e8ff1334c6a1868/extism.go#L529

Hey thanks for digging into this!
After discussing this with the team we're a little hesitant about the potentially large blast radius of this change and unsure about using special characters in error messages to signal intent. I don't think there is a good way to handle backwards compatibility if we're changing the semantics around error messages. Something closer to the posix errno API might be a better fit for Extism.
Adding error_get to PDKs and error_set to SDKs would allow you to implement this as something more specific to your application, without pulling it into Extism. We also considered that maybe exposing vars to host functions could allow for errors or other out of band data to be sent back to the plugin, which would just be a matter of adding var_set bindings to SDKs.
Additionally, if you're open to using an XTP schema to define your plugin interfaces you could use it to allow your plugin authors to stay up to date by leveraging the code generation. This would mean that changing the plugin interface to allow error messages as part of the call output could be added to your existing API without too much disruption!

@zshipko ultimately, if this is something that extism does not want to support, regardless of the implementation, then I understand.
Current Implementation
On the off-chance that there's just a misunderstanding of the implementation, let me clarify why I believe this is a backwards-compatible and safe change.

SDK
PDK
Result

Older
Older
Safe. Current behavior.

Newer
Older
Safe. Older PDKs don't know how to run "error_get".

Older
Newer
Safe. Older SDKs don't know how to run "error_set".

Newer
Newer
Safe. Both SDKs and PDKs know how to negotiate and check the error state.

It's certainly possible that I don't understand all the implications of this change, and if you'd like to provide specific examples of how this implementation is not backwards compatible, I can think through those. From my initial work on this, my understanding was that this approach would be backwards compatible.
The sentinel values used for denoting the error's source are configurable via environment variables, so a PDK does not have to commit now and forever to a specific sentinel value. In other words the SDK and PDK can dynamically negotiate the sentinel prefix. An errno would be better than nothing, but due to the fact that (1) it's impossible to enumerate all possible errors a PDK might want to through, and (2) err numbers don't communicate anything about the conditions leading up to those error, this solution would not work for our use-case. We have error messages like this
Get "http://<IP_ADDRESS>": dial tcp <IP_ADDRESS>:80: connectex: A connection attempt failed because the connected party did not properly respond after a period of time

While the errno could communicate the timeout, it could not communicate the HTTP path we were attempting to GET, or the IP address of the target we were requesting from, etc.
Vars Approach
This was actually the very first approach I took, even before opening a PR. There weren't any specific issues with this, other than it felt like a round-about way to solve a problem that, in my (admittedly biased) opinion, should be supported out-of-the-box by Extism on the basis that not every WASM use-case wants to abort execution if a host function fails.
Next Steps
As far as next steps, we're already running these PRs in production at our customers and it seems to be working well (though that cannot speak to the backwards compatibility question). If extism chooses not to solve this problem out-of-the-box, we can of course continue to maintain our forks.


[Codebundle] Postgresql Config Inspection Report

Scope
Runs a taskset inspection on a postgresql database, checking the config and returning a detailed report of issues and potential remediations.
Requested By (Optional)

RunWhen

Related Integrations

Postgresql

Definition of Done

[ ] Codebundle Implementation accomplishes scope (or provide a justification for why it may differ)
[ ] Attach a screenshot of the codebundle pushing a metric locally (if an SLI) or showing a report (if a taskset)
[ ] Attach a screenshot of the SLI or Taskset running in a workspace.

Optional Comments
This could potentially be split into 2 variants: one for public but authenticated db instances, and one for kubernetes workloads connected to via the kube api

This codebundle request and detail history is being migrated to an internal tracking tool for authors. Please reach out to the RunWhen team if you have any questions.


[ADD]: Brand collaborated with section

Above the footer add this section.

Can you assign it to me


bug: style property doesn't work in some cases

It looks like the new style of prop passing may've broken passing css custom properties, e.g.
            <IonFabButton
              size="small"
              style={{
                '--background': 'none',
                '--box-shadow': 'none',
                '--color': 'var(--ion-toolbar-color)',
              }}

no longer works

Same applies for class - it seems like both must be passed as HTML attributes instead

Hmm. For some reason, this still doesn't seem to work in certain cases.

This seems like a big issue. And it makes total sense to me now. Those are HTML attributes that should be inside HTML. class, styles, contentEditable, title and so on,.. If you use the Element property, you can reassign current value or something/somebody can reassign your value.
This is a typical issue.
const myDiv = document.createElement("div");
myDiv.onclick = () => doSomething();
myDiv.onclick = () => doSomethingElse(); // This will reassign the onclick event; old event handler is removed

When we use prop: property, it is direct assignment to JS property on the element, like the onclick above. So if the Ionic component itself assigns something to those properties, it will probably remove our assignments.
We should probably assign HTML attributes to props without prop: directive or we should use attr: to force the prop being handled as HTML attribute.
But if you say it does not work properly, there is something strange happening and it must be something inside Ionic or Stencil.

@spion Do you have some examples where the class/style fails?
I implemented generator based on reflection so I'd like to test it.
All I tested is working.

How the generated components looks like now:

I cannot reproduce the issue outside my larger project, especially after the regex update for class and style. I'm inclined to leave this be for now until there is a definite repro.

Just adding some info about what I found inside Solid.js. I may help us make a decision.
How the props are assigned to Node
https://github.com/ryansolid/dom-expressions/blob/c8dc99b1299cd03d2e59a0da04c414c44080a833/packages/dom-expressions/src/client.js#L313-L361
HTML attributes and events are whitelisted, based on this consts
https://github.com/ryansolid/dom-expressions/blob/c8dc99b1299cd03d2e59a0da04c414c44080a833/packages/dom-expressions/src/constants.js#L87

It looks like ref doesn't work either. Not 100% sure if its related or not.

To get my project unblocked, I'll update the regex to include ref in the excluded props, but happy to collaborate on the getType / reflection solution. The only bit I worry about is performance - not the reflection aspect as I understand you're targeting compile-time, but just how performant longer lists are to check.

I think we do prop:ref now so it's not ref technically. You have to exclude it like you excluded class and style.

Thats what I meant. Words are difficult :grinning:

Ahh,.. no. I didn't read the last message,.. I send it right after you posted it.. 😃

I can optimize it a little bit
// Auto-generated by scripts/generate.ts

import { defineCustomElement } from '@ionic/core/components/ion-accordion'
import type { JSX as IonicJSX } from '@ionic/core'
import { type JSX as JSXBase, splitProps } from 'solid-js'
import type { FixIonProps } from '../../lib'

defineCustomElement()

export type IonAccordionProps = FixIonProps<IonicJSX.IonAccordion> &
	JSXBase.HTMLAttributes<HTMLIonAccordionElement>

export function IonAccordion(props: IonAccordionProps) {
	const [ _, rest ] = splitProps(
		props,
		['disabled', 'mode', 'readonly', 'toggleIcon', 'toggleIconSlot', 'value']);
	const componentProps = () => ({
		'prop:disabled': props.disabled,
		'prop:mode': props.mode,
		'prop:readonly': props.readonly,
		'prop:toggleIcon': props.toggleIcon,
		'prop:toggleIconSlot': props.toggleIconSlot,
		'prop:value': props.value
	});

	return <ion-accordion {...componentProps()} {...rest} />;
}

that generates JS:
export function IonAccordion(props) {
  const [_, rest] = splitProps(props, ["disabled", "mode", "readonly", "toggleIcon", "toggleIconSlot", "value"]);
  const componentProps = () => ({
    "prop:disabled": props.disabled,
    "prop:mode": props.mode,
    "prop:readonly": props.readonly,
    "prop:toggleIcon": props.toggleIcon,
    "prop:toggleIconSlot": props.toggleIconSlot,
    "prop:value": props.value
  });
  return (() => {
    var _el$ = _tmpl$();
    _$spread(_el$, _$mergeProps(componentProps, rest), false, false);
    _el$._$owner = _$getOwner();
    return _el$;
  })();
}

We cannot avoid that spread it generates but we can maybe avoid that splitProps with mergeProps if we implement that manually, somehow.

I understand now, splitProps is provided by Solid as it preserves prop reactivity properly. I think it should be OK even without the optimizations now that I've looked at the implementation (https://github.com/solidjs/solid/blob/a72d393a07b22f9b7496e5eb93712188ccce0d28/packages/solid/src/server/rendering.ts#L166)
None of the ionic component props look particularly long, and since this is not React it doesn't happen on every render :grinning:

I think this is effectively resolved.


Fix table render in BulletListByTag view

I have raised the issue to dataview: blacksmithgu/obsidian-dataview#1984


Avoid having global variables.

My app uses boltdb and opens the db when the app is started.
It puts the DB instance pointer in the global variable so that i can refer the instance from the command implementation.
I prefer to refer it from the Context so that I don't have to use global variables.
Is there a good way to avoid having global variables in those case?
I'm thinking about put interface{} pointer to the App. So that I can put arbitrary object in the App when I initialized the App and refer it from each Command implementation. But not sure I'm on the right track.

Duplicate. Similar to #339


Patch command example error

for the example Update the “source1” source in the current project with a dataset:
datum patch -p proj/ --overwrite source1 path/to/dataset2:coco

There is two issue

for now the default branch name will be source-1
patch command can not correctly locate source-1 folder in the project, result in raising FileExistsError
Reproduce:

datum create -o proj
datum import -p proj -f coco -r annotations/instances_default.json  /home/dataset_merge_exp/a
datum patch -p proj --overwrite source-1 /home/dataset_merge_exp/b:coco

if we specify output dir, it will work correctly
datum patch -p proj -o proj/source-1 --overwrite source-1 /home/dataset_merge_exp/b:coco

Hi, thank you for reporting the issues.

for now the default branch name will be source-1

This is the designed behavior, because the word patch implies in-place operation by default. Using the -o/--output-dir is correct way to save results in another place. Please read the command description.
If this logic does not work well, could you describe your use case?

patch command can not correctly locate source-1 folder in the project, result in raising FileExistsError

Thanks, it looks like a Python bug on Windows, actually.


Create method get_user_stars()

Create method get_user_stars() to get the number of repositories a user has stared

Create the above method the function should return the count of stared repositories given a user as input


How to send sms?

Is it possible to use 'text me the app' function?
For instance, if our app is running on iPad, then user can input his/her number to get a download link like: https://dev.branch.io/features/text-me-the-app/guide/#insert-sendsms-snippet-into-your-page.
Thank you.

Hi @skleest. Thanks for getting in touch.
I don't think this involves the RN SDK or any other mobile app SDK. (The JS calls in that snippet involve the Branch web SDK). It should work without any setup outside the Dashboard, unless you want to customize the HTML as discussed in the doc you shared. In that case, I think you host the custom HTML yourself. I haven't worked with this feature much myself, but I've seen the default page appear numerous times. If you have any trouble with it, please let us know details, and we'll assist.

Thanks for the fast answer @jdee!
Yes, we've been working with the web landing page; was wondering if it would be possible to send to  users right from RN. Thanks again for the great component.

Hi @jdee,
Thanks for the further explanation! My use case was from sending from iPad (kiosk) to a phone, and since iPad does not have SMS capability, I thought I could take advantage of the function called from the desktop hosted page. It seems like I should generate the link then use Twilio to send it out!
Thanks!

@skleest There is one other option if you really want the SMS feature directly in your app. You can just use a WebView in the app and use an HTML/JS snippet like the one in the docs. This is a less standard approach, and it removes the other options from the share sheet. But if that's what you want, that also works.


Android touch fix: check for POINTER_UP and UP events

Implemented checks for AMOTION_EVENT_ACTION_POINTER_UP and AMOTION_EVENT_ACTION_UP flags to not register  pointers lifted during current event, otherwise they get stuck until next pointer event.

@di-ant It seems this code resets all touches when one finger is up, is this the expected behaviour?

@raysan5 Is it? It doesn't on my phone, at least.
Right now, on master,  as "up" events are coming in, they are counted as touch too, so int GetTouchPointCount(void); always returns correct amount of touch points only after following event. Even worse, after a first touch event, it cannot be less than one, because event when last finger left the screen still counts as a touch event, and cannot be changed until next touch event.
Idea behind this fix, is when "up" event is coming in, we just don't count it towards touch points, by subtracting one (only when event is "up" event). (Its touchPoints -= 1, not touchPoints = 1)
Order of touch points doesn't seem to be affected by this nanopatch, at least with my configuration, int GetTouchPointId(int index); works as expected (no misalignment between index and id), and int GetTouchPointCount(void); accurately reflects amount of fingers on my touchscreen.
Maybe it's just a problem with my environment, but i don't have anything else to test with.
My config is:
Build environment: linux, kernel 5.15.3
Android API level: 29
NDK: r23b
jdk: 13.0.2
smartphone: Redmi Note 10 Pro (Android 12)

I am really sorry, somehow i messed up the order. Should be good now.

actually, in specific cases it's not even guaranteed that last event's index is highest, so this is not totally correct, will be back with a real fix.


Update ExpenseItem amount when persisting Stripe charge

Bug caught by user and submitted through a support ticket:

Thank you for this!
Do we have some entries in the database that needs to be fixed?

Probably. It is on my to-do list to merge this and fix what's pending. Doing it ASAP.


Clean up optional arguments properly in chip-tool.

Otherwise in interactive mode we can end up with noise left over from
a previous command invocation.
Fixes https://github.com/project-chip/connectedhomeip/issues/20151
Problem
See issue above, but also we can get perfectly valid values getting carried over in interactive mode from a command that set an optional arg to one that is trying not to.
Change overview
Make sure to reset optional args during command shutdown.
Testing
Used test in #20151.

fast-tracking test tool change.


Explicitly build language server during pack-extension.ps1

The language server dll is not getting signed as it's not find in the correct location. It needs to be built without publishing it.

/azp run

/azp run