Remove override for INSTALL_NAME_DIR as the default behaviour is expected

Here is about the most trivial test case I think we could come up with - only for SystemC, but CCI suffers the same issue.
CMakeLIsts.txt:
cmake_minimum_required(VERSION 3.19)
project(test VERSION 1.0)
include(FetchContent)

FetchContent_Declare(
    cpm-cmake
    GIT_REPOSITORY https://github.com/cpm-cmake/CPM.cmake.git
    GIT_TAG v0.31.1)
FetchContent_MakeAvailable(cpm-cmake)
include(${cpm-cmake_SOURCE_DIR}/cmake/CPM.cmake)

# this one is good for building a moden package
<EMAIL_ADDRESS>CPMAddPackage("gh:fmtlib/fmt#7.1.3")

cpmaddpackage(
    NAME SystemCLanguage
    GIT_REPOSITORY https://github.com/accellera-official/systemc.git
    GIT_TAG main
)
add_executable(test test.cc)
target_link_libraries(test PUBLIC SystemC::systemc fmt::fmt)

install (TARGETS test DESTINATION ${CMAKE_INSTALL_BINDIR})

test.cc:
#include <systemc.h>

int sc_main(int argc, char* argv[])
{

    /* empty */
}

If you build this (on a Mac) along the lines of:
cmake -B build -DCMAKE_INSTALL_PREFIX=`pwd`/install
cd build
make
make install

Then use
otool -l install/bin/test

In the middle you’ll see
Load command 14
          cmd LC_LOAD_DYLIB
      cmdsize 88
         name /Users/mburton/work/test/install/lib/libsystemc.3.0.dylib (offset 24)
   time stamp 2 Thu Jan  1 01:00:02 1970
      current version 3.0.0
compatibility version 3.0.0
Load command 15
          cmd LC_LOAD_DYLIB
      cmdsize 48
         name @rpath/libfmt.7.dylib (offset 24)
   time stamp 2 Thu Jan  1 01:00:02 1970
      current version 7.1.3
compatibility version 7.0.0

Note how fmt gets the rpath correctly, while systemc takes the absolute path of where it was built :-(
(Even though, it’s installed SystemC in the install path).
IMHO it should do roughly the same as (e.g.) FMT, and use an rpath - allowing the user to set the rpath to include whatever they want (e.g. a relative path to the installed libraries, or an absolute path, or whatever).

lgtm, but could you rebase on main so that we have the full CI?


Fix uncomment multiple lines of code feature by changing token type to PsiCommentImpl from PsiJavaToken https://github.com/TiVo/intellij-haxe/issues/209

Fix uncomment multiple lines of code feature by changing token type to PsiCommentImpl from PsiJavaToken
https://github.com/TiVo/intellij-haxe/issues/209

https://github.com/TiVo/intellij-haxe/blob/FixMultilineComments/src/com/intellij/plugins/haxe/util/UsefulPsiTreeUtil.java#L96-96 may be fixed as well

Approved for pull.


Updated canvas version?

Can someone please update the canvas version to 2.11.0? The required one, 2.10.2 is not prebuilt for node18 (ABI v108) but the newer one is. I tried forcing the canvas dependency to the newer one but the plugin stops responding, did not debug why yet.

Can someone please update the canvas version to 2.11.0? The required one, 2.10.2 is not prebuilt for node18 (ABI v108) but the newer one is. I tried forcing the canvas dependency to the newer one but the plugin stops responding, did not debug why yet.

Please try v3

I have the same problem. node-pre-gyp error in node18.

Have you tried 3.3.0 ?


Approver access for Noel Miller

As per the governance I'd like to nominate Noel Miller for org-wide approver.
The ISO has been a bane of our existence and Noel made it happen.
Additionally I've synced with Marco and he's happy to emeritus out of org ownership, so I've moved Kyle and bsherman into owners. He's still around in Discord just busy with a new kid and happily consuming ublue instead.
cc @ublue-os/approver @ublue-os/member

:+1

:+1:

:+1:

Well deserved 👍

+1

👍

+1

👍

Thanks everyone! Looking forward to approving things :P


Even if you don't need it, your DB needs the "hstore" extension to be installed

Running a generation on a fresh database with no specific extension installed leads to this:
psycopg2.ProgrammingError: hstore type not found in the database. please install it from your 'contrib/hstore.sql' file

Fair enough. I don't know which one of these options is interesting:

Make the use of hstore optional, thus allowing to use populous without hstore installed the db. Eventually throw an error if you try to add a hstore field in your blueprints.
Make the use of hstore mandatory, but warn the user first in the doc and by gracefully send an error message when trying to a connect to a hstore-less db,

Yes, hstore should be optional. As well as ltree.
I'm pretty sure this is easy to handle.


 Starting Istio SDS Server
2024-08-02T13:56:15.502936Z     info    CA Endpoint istiod.istio-system.svc:15012, provider Citadel
2024-08-02T13:56:15.502961Z     info    Using CA istiod.istio-system.svc:15012 cert with certs: var/run/secrets/istio/root-cert.pem
2024-08-02T13:56:15.511367Z     info    ads     All caches have been synced up in 215.102503ms, marking server ready
2024-08-02T13:56:15.512435Z     info    xdsproxy        Initializing with upstream address "istiod.istio-system.svc:15012" and cluster "Kubernetes"
2024-08-02T13:56:15.514708Z     info    Pilot SAN: [istiod.istio-system.svc]
2024-08-02T13:56:15.515781Z     info    Starting proxy agent
2024-08-02T13:56:15.525594Z     info    Envoy command: [-c etc/istio/proxy/envoy-rev.json --drain-time-s 45 --drain-strategy immediate --local-address-ip-version v4 --file-flush-interval-msec 1000 --disable-hot-restart --allow-unknown-static-fields -l warning --component-log-level misc:error --concurrency 2]
2024-08-02T13:56:15.518047Z     info    sds     Starting SDS grpc server
2024-08-02T13:56:15.518214Z     info    starting Http service at <IP_ADDRESS>:15004
2024-08-02T13:56:15.582156Z     warning envoy main external/envoy/source/server/server.cc:835   Usage of the deprecated runtime key overload.global_downstream_max_connections, consider switching to `envoy.resource_monitors.downstream_connections` instead.This runtime key will be removed in future.      thread=17
2024-08-02T13:56:15.583273Z     warning envoy main external/envoy/source/server/server.cc:928   There is no configured limit to the number of allowed active downstream connections. Configure a limit in `envoy.resource_monitors.downstream_connections` resource monitor.    thread=17
2024-08-02T13:56:15.587489Z     info    xdsproxy        connected to delta upstream XDS server: istiod.istio-system.svc:15012       id=1
2024-08-02T13:56:15.599773Z     info    ads     ADS: new connection for node:reviews-svc-waypoint-67d8bd9644-hws5t.default-1
2024-08-02T13:56:15.601926Z     info    ads     ADS: new connection for node:reviews-svc-waypoint-67d8bd9644-hws5t.default-2
2024-08-02T13:56:15.689185Z     info    cache   generated new workload certificate      latency=173.254356ms ttl=23h59m59.310819206s
2024-08-02T13:56:15.689237Z     info    cache   Root cert has changed, start rotating root cert
2024-08-02T13:56:15.689251Z     info    ads     XDS: Incremental Pushing ConnectedEndpoints:2 Version:
2024-08-02T13:56:15.689287Z     info    cache   returned workload trust anchor from cache       ttl=23h59m59.310713517s
2024-08-02T13:56:15.689330Z     info    cache   returned workload trust anchor from cache       ttl=23h59m59.310669676s
2024-08-02T13:56:15.689445Z     info    cache   returned workload certificate from cache        ttl=23h59m59.310559642s
2024-08-02T13:56:15.689650Z     info    ads     SDS: PUSH request for node:reviews-svc-waypoint-67d8bd9644-hws5t.default resources:1 size:1.1kB resource:ROOTCA
2024-08-02T13:56:15.689685Z     info    ads     SDS: PUSH request for node:reviews-svc-waypoint-67d8bd9644-hws5t.default resources:1 size:4.0kB resource:default
2024-08-02T13:56:15.689709Z     info    cache   returned workload trust anchor from cache       ttl=23h59m59.310291352s
2024-08-02T13:56:15.699050Z     warning envoy config external/envoy/source/extensions/config_subscription/grpc/delta_subscription_state.cc:269      delta config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) kmesh-listener: Didn't find a registered implementation for 'envoy.listener.kmesh_tlv' with type URL: 'envoy.listener.kmesh_tlv.config.KmeshTlv'
        thread=17
2024-08-02T13:56:15.699080Z     warning envoy config external/envoy/source/extensions/config_subscription/grpc/grpc_subscription_impl.cc:138        gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) kmesh-listener: Didn't find a registered implementation for 'envoy.listener.kmesh_tlv' with type URL: 'envoy.listener.kmesh_tlv.config.KmeshTlv'
        thread=17
2024-08-02T13:56:16.044188Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:17.043234Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:18.043281Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:19.042492Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:20.043296Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:21.042916Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:22.042436Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:23.043188Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:24.042705Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected
2024-08-02T13:56:25.043364Z     warn    Envoy proxy is NOT ready: config received from XDS server, but was rejected: cds updates: 1 successful, 0 rejected; lds updates: 0 successful, 1 rejected

What you expected to happen:
reviews-svc-waypoint should be running after we use kubectl label service reviews istio.io/use-waypoint=reviews-svc-waypoint
How to reproduce it (as minimally and precisely as possible):
Follow the doc in https://kmesh.net/en/docs/userguide/try_waypoint/
Anything else we need to know?:
Environment:

Kmesh version: 0.4.0
Others:

@noobwei You should use:
[root@ ~]# kubectl annotate gateway reviews-svc-waypoint sidecar.istio.io/proxyImage=ghcr.io/kmesh-net/waypoint:latest

to replace the waypoint image with our own custom image. This is already written in th doc. Please follow the doc step by step without missing anything.

maybe highlight this command

Thanks!
By the way, the Running_STATUS_reviews-svc-waypoint can't appear after just running kubectl label service reviews istio.io/use-waypoint=reviews-svc-waypoint. Maybe add one output after the kubectl annotate gateway reviews-svc-waypoint sidecar.istio.io/proxyImage=ghcr.io/kmesh-net/waypoint:latest.
And I have solved this issue.


Dev/michu/add PowerShell module sample that interacts with the PowerApps checker serice

Change of direction so closing


Two arguments missed in label_search.py

Hello:
The first one is at line 70, config is not passed to utils.TriggerTemplatizer.init():
    templatizer = utils.TriggerTemplatizer(
        args.template,
        tokenizer,
        label_map=label_map,
        label_field=args.label_field,
        add_special_tokens=False
    )

The second one is at line 96, use_ctx is required:
train_dataset = utils.load_trigger_dataset(args.train, templatizer)

Regards.

Thanks for catching this!


NoEmptyStatementFixer - handle anonymous classes correctly

:+1:
however I like the suggestion (https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/1881/files#r60477545) to have a dedicated test :)

:+1:

@gharlan
please, could you rebase?

done

:ship:

Thank you @gharlan.


Remake the s3 url

It is necessary to make a more flexible url formation for accessing s3
Current config
storage_connects:
  - name: s3_store
    s3_params:
      bucket_name: bucket_name
      access_key_id: access_key_id
      secret_access_key: secret_access_key
      endpoint: 'obs.ru-moscow-1.hc.sbercloud.ru'

In this case, we get a url of the Path-style type - obs.ru-moscow-1.hc.sbercloud.ru/bucket-name/object.name
Now the provider is changing the s3 address to Virtual-hosted-style, which implies a different url construction
Virtual-hosted-style - bucket-name.obs.ru-moscow-1.hc.sbercloud.ru/object.name
When trying to change the endpoint and add bucket_name to it, the final url is formed incorrectly and we get the error
exec error: Some of backups failed with next errors:
1 error occurred:
 * exit status 2

Hi, @Ichthyony.
We have added endpoint handling and automatic detection of the connection type to s3. If endpoint domain starts with bucket name, Virtual-hosted style will be used.
This has been realized and released as part of the v3.11.0 release.
New ideas and suggestions are welcome.


non-pcmCruise: initialize to vEgoCluster

Should fix when you enable openpilot while traveling at x mph (as-shown on the device), and it sets the speed to x-y mph (y some small offset) when vEgoCluster is set to the car's dash and not pcmCruise

@sshane I can confirm that this pr sets the max speed to the currently displayed speed. On master my car tends to set to about 1-2 mph off from the currently displayed speed when going around 60 mph, but with this change it does properly set to the shown speed. Hyundai Santa Fe 2020 (2019)

I realized this will cause your car to speed up and show a vEgo higher than the set speed.
vEgo is 60 mph
vEgoCluster is 62 mph
Press set, cruise set to 62 mph.
Cruise is compared to real vEgo in long planner: 62 mph set speed vs 60 mph, so we speed up.
End result: 62 mph set speed, 62 mph real speed, maybe 64 mph cluster speed.
@pfeiferj did you see this?

I realized this will cause your car to speed up and show a vEgo higher than the set speed.
vEgo is 60 mph vEgoCluster is 62 mph
Press set, cruise set to 62 mph.
Cruise is compared to real vEgo in long planner: 62 mph set speed vs 60 mph, so we speed up.
End result: 62 mph set speed, 62 mph real speed, maybe 64 mph cluster speed.
We almost need to use vEgoCluster to control against.
@pfeiferj did you see this?

Yes, mentioned it in my other PR. This would still be needed once you have adjusted for the car speed when limiting though. Basically my PR that I made for the issue did the limiting thing you're mentioning but didn't fix the initial set of max like this does

For the limiting part you could take a look at: https://github.com/commaai/openpilot/pull/28595


whether could you provide me a example for tensorflow that predict by gpu ，and tell me the computer setting info？

          I'm not sure if this is caused by CUDA 12.1 you are using. Can you try CUDA 11.3? or use PyTorch engine?

Originally posted by @frankfliu in https://github.com/deepjavalibrary/djl/issues/2554#issuecomment-1514796760
unfortunately，i had used CUDA 11.3 still get unknow device.
whether could you provide me a example for tensorflow that predict by gpu ，and tell me the computer setting info？

thanks very much ，is real cause by my local enviroment。


WIP: Ensure test can fail.

A bad PR that was reverted. Want to be sure I can cause a failure.

@swift-ci please clean test os x platform

Build failed
Swift Test OS X Platform
Git Sha - ca66950867ced12074fbd42b8538264979e14f43

@swift-ci please clean test os x platform

Build failed
Swift Test OS X Platform
Git Sha - ca66950867ced12074fbd42b8538264979e14f43


Feature Request: prefix string for result backend

Hi, thanks for this great project!
When using Redis to store results, it might be nice to be able to add a prefix to the key to better organize the database. RedisInsight, for example, organizes keys into folders based on the : separator.
If desired I can submit a PR.

That would be nice to have. PRs are always welcome.


[FEATURE] Pls. add Similarity Score Threshold retriever to Flowise

Describe the feature you'd like
Pls add Similarity Score Threshold retriever to Flowise.
Docs:
https://js.langchain.com/docs/modules/data_connection/retrievers/how_to/similarity-score-threshold-retriever
Additional context
It adds some nice advanced retrieval methods to Flowise.
According to Langchain's chatbot, we should simply be able to set some Vectorstore parameters:
# Convert the vector store into a retriever with Similarity Score Threshold retrieval method
retriever = db.as_retriever(search_type="similarity_score_threshold", search_kwargs={"score_threshold": 0.5})

but that input is not available yet in Vector Store Retriever node.

Will definitely add that! In the meantime you can try using the Vector to Document node, that allows you to specify the similarity threshold

In the meantime you can try using the Vector to Document node, that allows you to specify the similarity threshold
I tried to search for "Vector to Document" in
https://docs.flowiseai.com/
but it hasn't found any such info,
so where is it available in the docs / Flowise?

try update your flowise version

https://github.com/FlowiseAI/Flowise/pull/1012

Thank you!


Fix bug when empty / too small tensor is provided to decompress()

This fixes a bug where decompress() returns an uninformative error when an input tensor is very small or empty Tensor.

thanks!


Android DevTool 调试报错

Android DevTool 调试报错，一直无法进入调试状态，页面也是空的，具体报错为：Uncaught DOMException: Failed to execute 'getItem' on 'Storage': access is denied for this [document.(见截图)

求大神指导

你用的应该是dev版或者beta版的chrome吧 县换到stable版把
我正在研究这个新版的权限问题

This PR/issue doesn't receive response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


Do not immediately send message when attachment is added

At present, when a user adds an attachment to a message (file, photo on the phone or new photo), the message is immediately sent. This is a bad and unexpected experience. The user may wish to confirm that they attached the right item, or add text to their message.
Rather than sending immediately, we should allow the user to:

Add text to the message if desire.
Send the message when ready.

Oops, we already have this one! https://github.com/zulip/zulip-mobile/issues/4540


PARQUET-463: Add local DCHECK macros, fix some dcheck bugs exposed

I was also able to remove the -Wno-unused-value compiler flag. Removing -Wno-unused-variable will have to take place in another patch (more work required).

green build: https://travis-ci.org/wesm/parquet-cpp/builds/112673546

rebasing now

+1

Rebased. Will post a green build when I have one

green build: https://travis-ci.org/wesm/parquet-cpp/builds/112738155

thank you!


Pipette new colour formats

It'd be neat if the pipette also displayed HTML colour codes and HSL values (like aegisub). A couple filters use the first (like TColorMask), and the latter may be useful for other applications and is common enough in a fansubber's life.

I believe the pipette already has a lot of stuff
Should we look into a select (RGB&YUV&RAW / HTML&HSL&[HWB or ASS]) or making it double height?

I believe there's still plenty of space to work with. Maybe see what happens?

Added in https://github.com/Irrational-Encoding-Wizardry/vs-preview/commit/137533f1497650d91a17e4c64bcb031d03c6e971


native: fix stale unreads

fixes two issues:
stale unread count after viewing a channel when you return to the chatlist
We now invalidate any queries like before instead of specifically targeting active ones. This was tripping things up and is the least risky way to resolve this in the short term.
incorrect unreads when you enter a channel subsequently after viewing it once
This was an issue with us getting stuck on the cached value in react query before it refetched. A simpler approach of just manually fetching the initial unread one time on mount is used instead.
Fixes TLON-2566

Lgtm to me overall, one question: how does this interact with the channel switcher? That's the only situation I can think of where we might want to refetch unread state.

how does this interact with the channel switcher?

good thought! Updated. This should clean up a pre-existing bug with the cursor logic in that context as well


Add to Seen History (Mark As Seen) Doesn't Work With All TV Shows

There appears to be a limit to the number of episodes you can mark as seen. For instance, with Saturday Night Live (SNL), on the popup of "What is the last episode you seen?", if you pick the current season/episode (42/3), nothing happens. If you select season 25, episode 20, those episodes will be marked as seen. I'm not sure why I can't mark all of the SNL episodes as seen, but without that ability, it messes up the home screen's "Next episode to watch" suggestions.

Thank you for giving detailed explanation. When inserting large number of rows, generated SQL query was too long. This should be now fixed.


refactoring a little bit some test script files

I'll review the changes more thoroughly, but so far I like what I see. Was there a particular problem you were solving? Or just wanted to contribute some code cleanup?

Thank you for the feedback! I’m eager to contribute more to this project. My main goal was to learn how it works, and I noticed some areas that could use a bit of code cleanup. I thought it would be a good way to start my first PR. I wasn’t addressing a specific issue; I just wanted to make a contribution and get involved.
Looking forward to your thoughts!


Assembly not located. Assembly binding incorrect. App config file out of sync?

Sorry, for the long post. Did not know where to post this:
Ran into an issue whereby we were calling azure storage tables from dev/debug environment and getting an error that the Newtonsoft assembly could not be located.
Could not load file or assembly 'Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
Fusion log on the exception object stated:
LOG: Redirect found in application configuration file: <IP_ADDRESS> redirected to <IP_ADDRESS>.
LOG: Post-policy reference: Newtonsoft.Json, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed
LOG: The same bind was seen before, and was failed with hr = 0x80131040.
Looking at the app config (not web.config) file in bin\Debug\net461\win7-x64 we saw this in the assemblyBinding section.
  <dependentAssembly>
    <assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
    <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
    <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
    <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
    <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
  </dependentAssembly>

We had posted to Azure support twitter account thinking it was maybe on their end initially. They pointed us to a article ( http://stackoverflow.com/questions/21974076/could-not-load-file-or-assembly-exception-from-hresult-0x80131040 ) that seemed to suggest deleting the bin and obj directories and rebuilding. So we tried a clean project and that did not work. So we physically deleted the bin and obj directories and our app config file now looks like.
  <dependentAssembly>
    <assemblyIdentity name="Newtonsoft.Json" publicKeyToken="30ad4fe6b2a6aeed" culture="neutral" />
    <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
    <bindingRedirect oldVersion="<IP_ADDRESS>" newVersion="<IP_ADDRESS>" />
  </dependentAssembly>

This in essence fixed the issue. I thought at one time it was said that assembly binding had gone away in asp net core? Not sure... At any rate just wanted to post and see if this led to a bug of some kind.

Original app binding section

Binding redirects are gone in .NET Core. You're using ASP.NET Core on .NET Framework (where they still exist). There's a known issue with the CLI where binding redirects get stale. Fix is to delete the output folder and build again and it should generate the correct ones.

Ok, gotcha. Thanks for the reply David. Much appreciated!


Part of #2151 - Remove [Activate] from ViewComponents

This change removes [Activate] from ViewComponents. Accessing context
should be done through [ViewComponentContext]. Accessing services should
be done though constructor injection.

:watch: mostly because I feel I'm missing something

Updated - changed to defensive copy of ViewContext instead of a copy of just ViewData

:shipit:


Jukebox/addlistener

Codecov Report

Merging #223 (8d7dae5) into master (1e0367a) will increase coverage by 0.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   29.85%   30.53%   +0.68%
==========================================
  Files          31       31
  Lines        2214     2217       +3
==========================================
+ Hits          661      677      +16
+ Misses       1553     1540      -13

Impacted Files
Coverage Δ

lnbits/core/services.py
21.21% <0.00%> (-0.50%)
:arrow_down:

lnbits/wallets/spark.py
15.50% <0.00%> (+0.11%)
:arrow_up:

lnbits/wallets/lndrest.py
15.78% <0.00%> (+0.16%)
:arrow_up:

lnbits/wallets/lntxbot.py
16.27% <0.00%> (+0.18%)
:arrow_up:

lnbits/wallets/clightning.py
18.82% <0.00%> (+0.21%)
:arrow_up:

lnbits/wallets/lnbits.py
19.17% <0.00%> (+0.25%)
:arrow_up:

lnbits/core/views/api.py
23.80% <0.00%> (+0.54%)
:arrow_up:

lnbits/tasks.py
45.09% <0.00%> (+1.70%)
:arrow_up:

lnbits/utils/exchange_rates.py
27.08% <0.00%> (+27.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0367a...8d7dae5. Read the comment docs.

Do black and prettier


Fix code for splitting KEY=VALUE env vars

Make docker-gen work with env values with = in them as well as entries of the form KEY (no =)
As reported in jwilder/nginx-proxy#110 and zettio/weave#422

thx for the fast try to fix this.
i've tested this with lokal build and passed the new docker-gen into jwilder/nginx-proxy with -v
but it seems not to fix this problem.
i'm not familiar with go, so i don't know how to debug or get more information.
i just got this:
root@2e0f48c2694e:/app# forego start -r
forego     | starting nginx.1 on port 5000
forego     | starting dockergen.1 on port 5100
dockergen.1 | panic: runtime error: index out of range
dockergen.1 |
forego     | starting dockergen.1 on port 5200
forego     | sending SIGTERM to dockergen.1
forego     | sending SIGTERM to nginx.1
and if i run the docker-gen like in the Procfile i get this:
root@2e0f48c2694e:/app# docker-gen -watch -only-exposed -notify "nginx -s reload" /app/nginx.tmpl /etc/nginx/conf.d/default.conf
panic: runtime error: index out of range
goroutine 16 [running]:
runtime.panic(0x796a80, 0x9ec79c)
/usr/lib/golang/src/pkg/runtime/panic.c:279 +0xf5
main.getContainers(0xc20804c200, 0x0, 0x0, 0x0, 0x0, 0x0)
/pool/build/docker-gen/docker_client.go:152 +0xcb3
main.generateFromContainers(0xc20804c200)
/pool/build/docker-gen/docker-gen.go:157 +0x35
main.main()
/pool/build/docker-gen/docker-gen.go:395 +0x40c
goroutine 19 [finalizer wait]:
runtime.park(0x41e620, 0x9f0808, 0x9eea49)
/usr/lib/golang/src/pkg/runtime/proc.c:1369 +0x89
runtime.parkunlock(0x9f0808, 0x9eea49)
/usr/lib/golang/src/pkg/runtime/proc.c:1385 +0x3b
runfinq()
/usr/lib/golang/src/pkg/runtime/mgc0.c:2644 +0xcf
runtime.goexit()
/usr/lib/golang/src/pkg/runtime/proc.c:1445
if you can give me some advises i can give you more information.

@jwilder LMK what you think about the Makefile commits. I can remove them from this branch before merging if you thing those changes need to be discussed separately or removed entirely.

After sleeping on this, I had a few thoughts.
I think that the strings.SplitN changes should go in no matter what. However, it looks like os.Environ() may guarantee an "=", so the append may not be necessary there.
In the case of the KEY environment variables, this is a case where Docker's env-passthrough functionality has been used with -e KEY, but $KEY is not defined in the invoking environment. If you run env inside such a container, KEY is not included in the output:
$ env KEY2= docker run --rm -e KEY1 -e KEY2 -e KEY3= debian:jessie env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=57347b4b5aea
KEY2=
KEY3=
HOME=/root

Because of this, it may be best to omit such variables in getContainers instead of including them with a value of "".

I amended this by extracting that splitting code into a utils func and added some tests.
Thanks @md5

Cool. I still think it might be best to leave out the KEY entries with no =, but it's a minor issue.

Looking forward to an update to nginx-proxy that includes these changes since that means we'll get 'parseJson` too :)


[BUG] Application doesnt stop when showing Interstitial or Reward ad on iOS

OS target (Android/iOS):
iOS
Godot version:
3.1.2
Issue description:
When the user emits the reward or interstitial ad to appear on Android the game stops, but on iOS, the game continues to running in background, causing it to force the programmer to make adjustments to the game code (get_tree(). paused = true), and on Android this is not necessary, only on iOS

If anyone has any idea how to pause the application in the module code, it will be of great help, I can test the implementation


redesign event page

redesign event page with same concept so that it look cool and show upcoming and past events

Hello, can I work on this one?

Yes it is all yours

Use development1. 0 branch

Got it. Thank you!

Hello @ravisaxena23! I just opened PR #178. Check it out! I hope you will be happy with redesign🙂.

If you will like my work I would like to contribute more to this project. I saw that you are not using any linter tool like ESLint or code formatter like Prettier. I can add them to project. Code will be more readable and with same styling. This will make contribution even more easier. Have a nice day!

It is a beauty of open source that we can contribute many things. And we
are pleased to work with you. I'm happy you are with us in this project. I
will surely check your pr once I'm free. Right now I'm in college classes.
I have my own startup apart from it. And yes we need a prettier you are
free to add things that really matters. I will be more than happy to work
with you. If you need anything else please contact me. And try to work in
our latest branch development1.0...thank you for your support and code.
It's beautiful.
On Sat, Oct 12, 2019, 14:09 branis97<EMAIL_ADDRESS>wrote:

If you will like my work I would like to contribute more to this project.
I saw that you are not using any linter tool like ESLint or code formatter
like Prettier. I can add them to project. Code will be more readable and
with same styling. This will make contribution even more easier. Have a
nice day!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/technojam/technojam-frontend/issues/157?email_source=notifications&email_token=AKRIN37BKQVRUYLD4TFL33DQOGEMNA5CNFSM4I526OA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBZ3GY#issuecomment-541302171,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRIN3ZXC562FF4WIL2FOD3QOGEMNANCNFSM4I526OAQ
.

You are welcome🙂! Looking forward to our further collaboration.

Our pleasure
On Sat, Oct 12, 2019, 14:24 branis97<EMAIL_ADDRESS>wrote:

You are welcome🙂! Looking forward to our further collaboration.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/technojam/technojam-frontend/issues/157?email_source=notifications&email_token=AKRIN37MYXLMFULB3EM23HLQOGGETA5CNFSM4I526OA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBB2FPY#issuecomment-541303487,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKRIN32WX7S7EGGZKBTLZ4LQOGGETANCNFSM4I526OAQ
.


Docker Compose - inventree-server crashing due to missing django_q_schedule table?

Deployment Method

[ ] Installer
[ ] Docker Development
[X] Docker Production
[ ] Bare metal Development
[ ] Bare metal Production
[ ] Digital Ocean image
[ ] Other (please provide a link Steps to Reproduce

Describe the problem*
I am trying to deploy InvenTree locally using the provided Docker compose file at:
https://github.com/inventree/InvenTree/blob/master/contrib/container/docker-compose.yml
I have placed the following three files in a single directory:

https://github.com/inventree/InvenTree/blob/master/contrib/container/docker-compose.yml
https://github.com/inventree/InvenTree/blob/master/contrib/container/.env
https://github.com/inventree/InvenTree/blob/master/contrib/container/Caddyfile

I then run:
docker compose pull
docker compose up -d

(At first, I got hit with a gotcha around the Caddyfile - it wasn't mentioned this was needed - and when Docker compose tried to spin everything up, it hit this error:
❯ docker compose up --detach
[+] Running 4/5
 ✔ Container inventree-cache   Running                                                                                0.0s
 ✔ Container inventree-db      Running                                                                                0.0s
 ✔ Container inventree-worker  Running                                                                                0.0s
 ✔ Container inventree-server  Started                                                                                0.0s
 ⠙ Container inventree-proxy   Starting                                                                                0.1s
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/Users/bytedance/inventree-docker/Caddyfile" to rootfs at "/etc/caddy/Caddyfile": mount /Users/bytedance/inventree-docker/Caddyfile:/etc/caddy/Caddyfile (via /proc/self/fd/6), flags: 0x5000: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type

(It seems at least one other person hit this - https://github.com/inventree/InvenTree/discussions/7401 - it might be worth documenting it - or figuring out why the Docker compose file doesn't fail gracefully here?)
Anyway, clearing that error - the next issue is that inventree-server and inventree-worker are both crashing.
(container logs output is below under "Relevant log output").
Steps to Reproduce

Download the following files, and place them into a directory
cd to that directory
Run docker compose pull
Run docker compose up -d
Run 'docker ps -ato see the status of the InvenTree containers. Notice thatinventree-serverandinventree-worker` are crashing
Run docker logs inventree-server to see the issuedpc

Relevant log output
Container logs for inventree-server:

LINE 1: SELECT 1 AS "a" FROM "django_q_schedule" WHERE "django_q_sch...
                             ^
Traceback (most recent call last):
  File "/root/.local/lib/python3.11/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/psycopg/cursor.py", line 732, in execute
    raise ex.with_traceback(None)
psycopg.errors.UndefinedTable: relation "django_q_schedule" does not exist
LINE 1: ...", "django_q_schedule"."intended_date_kwarg" FROM "django_q_...
                                                             ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/root/.local/bin/gunicorn", line 8, in <module>
    sys.exit(run())
             ^^^^^
  File "/root/.local/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 67, in run
    WSGIApplication("%(prog)s [OPTIONS] [APP_MODULE]", prog=prog).run()
  File "/root/.local/lib/python3.11/site-packages/gunicorn/app/base.py", line 236, in run
    super().run()
  File "/root/.local/lib/python3.11/site-packages/gunicorn/app/base.py", line 72, in run
    Arbiter(self).run()
    ^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/gunicorn/arbiter.py", line 58, in __init__
    self.setup(app)
  File "/root/.local/lib/python3.11/site-packages/gunicorn/arbiter.py", line 118, in setup
    self.app.wsgi()
  File "/root/.local/lib/python3.11/site-packages/gunicorn/app/base.py", line 67, in wsgi
    self.callable = self.load()
                    ^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 58, in load
    return self.load_wsgiapp()
           ^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/gunicorn/app/wsgiapp.py", line 48, in load_wsgiapp
    return util.import_app(self.app_uri)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/gunicorn/util.py", line 371, in import_app
    mod = importlib.import_module(module)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/inventree/src/backend/InvenTree/InvenTree/wsgi.py", line 17, in <module>
    application = get_wsgi_application()  # pragma: no cover
                  ^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/django/core/wsgi.py", line 12, in get_wsgi_application
    django.setup(set_prefix=False)
  File "/root/.local/lib/python3.11/site-packages/django/__init__.py", line 24, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/root/.local/lib/python3.11/site-packages/django/apps/registry.py", line 124, in populate
    app_config.ready()
  File "/home/inventree/src/backend/InvenTree/InvenTree/apps.py", line 57, in ready
    self.start_background_tasks()
  File "/home/inventree/src/backend/InvenTree/InvenTree/apps.py", line 116, in start_background_tasks
    for existing_task in Schedule.objects.all():
  File "/root/.local/lib/python3.11/site-packages/django/db/models/query.py", line 398, in __iter__
    self._fetch_all()
  File "/root/.local/lib/python3.11/site-packages/django/db/models/query.py", line 1881, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/django/db/models/query.py", line 91, in __iter__
    results = compiler.execute_sql(
              ^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/django/db/models/sql/compiler.py", line 1562, in execute_sql
    cursor.execute(sql, params)
  File "/root/.local/lib/python3.11/site-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/django/db/backends/utils.py", line 84, in _execute
    with self.db.wrap_database_errors:
  File "/root/.local/lib/python3.11/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/root/.local/lib/python3.11/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/lib/python3.11/site-packages/psycopg/cursor.py", line 732, in execute
    raise ex.with_traceback(None)
django.db.utils.ProgrammingError: relation "django_q_schedule" does not exist
LINE 1: ...", "django_q_schedule"."intended_date_kwarg" FROM "django_q_...
                                                             ^

Container logs for `inventree-worker`:

❯ docker logs inventree-worker
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!
Loading config file : /home/inventree/data/config.yaml
No idea what 'int.worker' is!

Hmm, looking at the postgres logs, I see this:
❯ docker logs inventree-db
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.

The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".

Data page checksums are disabled.

fixing permissions on existing directory /var/lib/postgresql/data/pgdb ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default max_connections ... 100
selecting default shared_buffers ... 128MB
selecting default time zone ... Etc/UTC
creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ok
initdb: warning: enabling "trust" authentication for local connections
You can change this by editing pg_hba.conf or using the option -A, or
--auth-local and --auth-host, the next time you run initdb.
syncing data to disk ... ok

Success. You can now start the database server using:

    pg_ctl -D /var/lib/postgresql/data/pgdb -l logfile start

waiting for server to start....2024-09-10 05:53:53.672 UTC [49] LOG:  starting PostgreSQL 13.16 (Debian 13.16-1.pgdg120+1) on aarch64-unknown-linux-gnu, compiled by gcc (Debian 12.2.0-14) 12.2.0, 64-bit
2024-09-10 05:53:53.674 UTC [49] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2024-09-10 05:53:53.680 UTC [50] LOG:  database system was shut down at 2024-09-10 05:53:53 UTC
2024-09-10 05:53:53.684 UTC [49] LOG:  database system is ready to accept connections
 done
server started
CREATE DATABASE

/usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/*

2024-09-10 05:53:53.990 UTC [49] LOG:  received fast shutdown request
waiting for server to shut down....2024-09-10 05:53:53.992 UTC [49] LOG:  aborting any active transactions
2024-09-10 05:53:53.993 UTC [49] LOG:  background worker "logical replication launcher" (PID 56) exited with exit code 1
2024-09-10 05:53:53.993 UTC [51] LOG:  shutting down
2024-09-10 05:53:54.003 UTC [49] LOG:  database system is shut down
 done
server stopped

PostgreSQL init process complete; ready for start up.

2024-09-10 05:53:54.103 UTC [1] LOG:  starting PostgreSQL 13.16 (Debian 13.16-1.pgdg120+1) on aarch64-unknown-linux-gnu, compiled by gcc (Debian 12.2.0-14) 12.2.0, 64-bit
2024-09-10 05:53:54.103 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2024-09-10 05:53:54.103 UTC [1] LOG:  listening on IPv6 address "::", port 5432
2024-09-10 05:53:54.104 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2024-09-10 05:53:54.108 UTC [64] LOG:  database system was shut down at 2024-09-10 05:53:53 UTC
2024-09-10 05:53:54.111 UTC [1] LOG:  database system is ready to accept connections
2024-09-10 05:53:54.552 UTC [71] ERROR:  relation "django_content_type" does not exist at character 106
2024-09-10 05:53:54.552 UTC [71] STATEMENT:  SELECT "django_content_type"."id", "django_content_type"."app_label", "django_content_type"."model" FROM "django_content_type"
2024-09-10 05:53:54.564 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112
2024-09-10 05:53:54.564 UTC [71] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1
2024-09-10 05:53:54.581 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112
2024-09-10 05:53:54.581 UTC [71] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1
2024-09-10 05:53:54.581 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112
2024-09-10 05:53:54.581 UTC [71] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1
2024-09-10 05:53:54.583 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112
2024-09-10 05:53:54.583 UTC [71] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1
2024-09-10 05:53:54.583 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112
2024-09-10 05:53:54.583 UTC [71] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1
2024-09-10 05:53:54.584 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112
2024-09-10 05:53:54.584 UTC [71] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1
2024-09-10 05:53:54.586 UTC [71] ERROR:  relation "common_inventreesetting" does not exist at character 112

I recommend reading the docs https://docs.inventree.org/en/stable/start/docker_install/#initial-database-setup

In particular:
https://docs.inventree.org/en/stable/start/docker_install/#update-database

@victorhooi this has now been fixed in #8126 - please update and check

I'm still seeing this issue on both the master and stable branches:
inventree-db      | 2025-01-01 02:32:31.220 UTC [85] ERROR:  relation "common_inventreesetting" does not exist at character 112
inventree-db      | 2025-01-01 02:32:31.220 UTC [85] STATEMENT:  SELECT "common_inventreesetting"."id", "common_inventreesetting"."value", "common_inventreesetting"."key" FROM "common_inventreesetting" WHERE UPPER("common_inventreesetting"."key"::text) = UPPER('CURRENCY_CODES') ORDER BY "common_inventreesetting"."id" ASC LIMIT 1


pd_client: reconnect leader only when members change

What problem does this PR solve?
Issue Number: close #9690
What's Changed:
Reconnecting leader only when members change to avoid disturbing heartbeats report unexpectedly.
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Release note

fix frequently reconnecting pd client

/lgmt

/lgtm

/merge

Can we cherry-pick to release-4.0?

/run-cherry-picker

@coocood I'm afraid it's not a critical issue that will be landed at 4.0.

Some users worried about the error log.


Make "Hello" part of notification emails use user's username if we don't know their real name

Fixes #2037

Merged in 7fee62f8ebb9db32b7ce474d87b2c2ec21c2a70a


Question: Why using bundled libtasn1?

I was wondering why we can't support PKCS#11 in openconnect, and I found an interesting story that involves several feedstocks.
In short, libtasn1 is on conda-forge, which claims it can be used to support gnutls and p11-kit, among others. But, here gnutls uses its bundle as oppose to the libtasn1 package:
https://github.com/conda-forge/gnutls-feedstock/blob/21b0c2f4f8126ac8a0f1c2be407ee87697d1348c/recipe/build.sh#L23
and p11-kit (which is needed by openconnect for PKCS#11) claims it can't depend on libtasn1 on OS X: https://github.com/conda-forge/p11-kit-feedstock/blob/891f18f736d2078d2314db591f6589dc20b433ee/recipe/meta.yaml#L15
Because both lines were edited like 4 years ago, I suspect they're both outdated, but I can't trace back to who made the claims.

Might as well try to build with the feature you need. conda-forge didn't have as many packages as it has now back then. so it might have just been a bandwidth problem.


⚠ Processors has degraded performance

In bf7dffa, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: Processors performance has improved in 9413c17.


[BackOffice][Catalog][Product-template-detail] More feature button is enabled to click when first load -> submit update form

Go to BackOffice -> Catalog -> Product templates -> Edit a template
Click on the gray More feature button -> error
Solution: The More Features button should be disabled when it is grayed out.

Resolved


Update packs dependency to v0.0.6

We're currently on v0.0.4

Is this short term?
Didn't we decide not to mess with this for the upcoming release unless there is a strong reason to?

post 0.2.0


404 not found on Sinsy-NG demos

How to reproduce:

In Firefox, go to https://github.gloomyghost.com/Sinsy-NG/ and attempt to play the Sinsy-NG demos listed.

Expectation: Sound files will play
Reality: Nothing plays.
I also tried copying the link and playing it in mpv, but I got the error:
[ffmpeg] https: HTTP error 404 Not Found
Failed to open https://raw.githubusercontent.com/740291272/Sinsy-NG/demo/demo/e.wav.
[ytdl_hook] ERROR: Unable to download webpage: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[ytdl_hook] youtube-dl failed: unexpected error ocurred

Maybe we could add a demo/demo/ directory to https://github.com/GloomyGhost-MosquitoSeal/Sinsy-NG

sorry for that, i deleted demo branches.


Error 500 on Selling Option Order

Hello,
Has anyone ran into an issue with getting the 500 error on a sell option order? If so, have you found a solution to this issue?

figured it out. I was using the wrong TickerId. I was using the tickerId of the actual ticker and not the tickerId of the option


Modinvup 59 declare compatible w inv store v25

INFO: api-schema-lint: Using api-schema-lint version: 1.0.5
INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/)
INFO: api-schema-lint: Found 21 JSON schema files under directory 'ramls'
ERROR: api-schema-lint: ramls/instance-with-hrid.json: Missing "description" for: series, subjects
ERROR: api-schema-lint: ramls/instance.json: Missing "description" for: subjects
ERROR: api-schema-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport.


Lecture05 Vlad Fedorenko

Coverage decreased (-0.3%) to 44.505% when pulling 32909224debf8c6110d68f700556a58223180dbb on vladfedorenko:lecture05 into 315d33f92428d9f59d2580d0102eb36ce0e3991e on rybalkinsd:lecture05.

+


Move Version file to common module

it will be useful in common module -- need to move

Originally posted by @nulls in https://github.com/saveourtool/diktat/pull/1625#discussion_r1137340452

Done: now we have two files: generated/KtLintVersion.kt in diktat-ktlint-engine and generated/DitktatVersion.kt in diktat-api


Update JSDoc for optional options

Updates IonImageryProvider.fromAssetId and Cesium3DTileset.fromIonAssetId to have optional options.  In both cases options arguments were not marked as optional in JSDoc causing them to be required in Typescript.
Fixes #11623 and fixes #11624
Test Plan
Run npm build-ts
Open the generated typescript definition file, and verify that both methods now include optinons?: instead of options: to mark them as optional
 static fromAssetId(assetId: number, options?: IonImageryProvider.ConstructorOptions): Promise<IonImageryProvider>;

 static fromIonAssetId(assetId: number, options?: Cesium3DTileset.ConstructorOptions): Promise<Cesium3DTileset>;

Thank you so much for the pull request @angrycat9000! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!
The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

:x: Missing CONTRIBUTORS.md entry.

Please add yourself to the contributors file!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

Updated with that suggestion @ggetz

Great, thanks @angrycat9000 !


Question: where would one point to a wallet rendering file?

First of all: the discussion around this subject was exactly what we needed in our project. I'm glad I do not have to reinvent the wheel!
I don't have a question about the definition itself but I wonder where I should reference or include this? Should this be part of a VC or part of a schema? Or something else entirely? In other words: how would a wallet find out about these display hints?

We have a suggestion for this, which is to store them as DID-Linked Resources. Note that this is not a standard/specification yet, just a suggestion on how to flexibly be able to define assets like schemas, wallet rendering files, images etc and have them resolvable via a DID query.

This is by no means a specification/standard yet, but on our DID method one of the techniques we've been exploring and wanna get standardised is to reference such assets (such as schemas, wallet rendering files, images etc) using DID queries, which could then resolve to an underlying centralised storage, decentralised storage, or ledger. We call this idea "DID-Linked Resources".
Using DID queries uses to resolve to a target is kinda like how service queries currently work, except service is only allowed for, well, services and not files. But semantically the technique is similar.
I know various people in the community have made their own efforts for wallet rendering, but AFAIK, I don't know a specific property per-se in VC data model spec that allows for defining things like wallet rendering file. So for now, we use an image property under credentialSubject or issuer to link specific sections of a VC to an image to render.
There's probably a need for describing this in a smarter way, e.g., even being able to describe multiple rendering formats like static image, Apple Wallet pass file, Google Wallet pass file etc.


I am having issues to get register_upstream_external_models() to work

I stripped down my usecase to the following basic example:

stg layer: 1 model that outputs intermediary data as an external csv file (stg_orders)
marts layer: 1 model that uses the staging layer to do some small calculation (orders)

Instead of running the whole project as one (which works) I wanted to split it up into 2 steps and use the register_upstream_external_models() to make sure that this would work.
When I run only the marts package, it fails because it says it cannot find the table.
09:54:37.537998 [error] [MainThread]: Runtime Error in model orders (models/marts/orders.sql)
09:54:37.539425 [error] [MainThread]:   Catalog Error: Table with name stg_orders does not exist!
09:54:37.540547 [error] [MainThread]:   Did you mean "temp.pg_catalog.pg_views"?
09:54:37.541653 [error] [MainThread]:   LINE 11: select * from "coffee_shop_test"."main"."stg_orders"

When I look in the logs I see the following:
09:54:37.225208 [debug] [MainThread]: Writing runtime sql for node "operation.coffee_shop.coffee_shop-on-run-start-0"
09:54:37.227409 [debug] [MainThread]: Using duckdb connection "master"
09:54:37.228500 [debug] [MainThread]: On master: BEGIN
09:54:37.229899 [debug] [MainThread]: SQL status: OK in 0 seconds
09:54:37.230767 [debug] [MainThread]: Using duckdb connection "master"
09:54:37.231775 [debug] [MainThread]: On master: /* {"app": "dbt", "dbt_version": "1.4.0", "profile_name": "duckdb", "target_name": "dev", "connection_name": "master"} */
create schema if not exists main
09:54:37.233732 [debug] [MainThread]: SQL status: OK in 0 seconds
09:54:37.237245 [debug] [MainThread]: Writing runtime sql for node "operation.coffee_shop.coffee_shop-on-run-start-0"
09:54:37.238110 [debug] [MainThread]: Using duckdb connection "master"
09:54:37.238579 [debug] [MainThread]: On master: /* {"app": "dbt", "dbt_version": "1.4.0", "profile_name": "duckdb", "target_name": "dev", "connection_name": "master"} */
create or replace view "coffee_shop_test"."main"."stg_orders" as (
            select * from 'coffee-data/stg_orders.csv'
          );
09:54:37.240719 [debug] [MainThread]: SQL status: OK in 0 seconds
09:54:37.243547 [debug] [MainThread]: Writing injected SQL for node "operation.coffee_shop.coffee_shop-on-run-start-0"
09:54:37.247490 [info ] [MainThread]: 1 of 1 START hook: coffee_shop.on-run-start.0 .................................. [RUN]
09:54:37.249385 [info ] [MainThread]: 1 of 1 OK hook: coffee_shop.on-run-start.0 ..................................... [OK in 0.00s]
09:54:37.251099 [info ] [MainThread]:
09:54:37.252567 [debug] [MainThread]: On master: ROLLBACK
09:54:37.254094 [debug] [MainThread]: Failed to rollback 'master'
09:54:37.254808 [debug] [MainThread]: On master: Close

09:54:37.259425 [info ] [MainThread]: Concurrency: 1 threads (target='dev')
09:54:37.260726 [info ] [MainThread]:
09:54:37.269843 [debug] [Thread-1 (]: Began running node model.coffee_shop.orders
09:54:37.271039 [info ] [Thread-1 (]: 1 of 1 START sql external model main.orders .................................... [RUN]
09:54:37.273265 [debug] [Thread-1 (]: Acquiring new duckdb connection 'model.coffee_shop.orders'
09:54:37.274562 [debug] [Thread-1 (]: Began compiling node model.coffee_shop.orders
09:54:37.289179 [debug] [Thread-1 (]: Writing injected SQL for node "model.coffee_shop.orders"
09:54:37.290757 [debug] [Thread-1 (]: Timing info for model.coffee_shop.orders (compile): 2023-02-24 09:54:37.275617 => 2023-02-24 09:54:37.290464
09:54:37.291590 [debug] [Thread-1 (]: Began executing node model.coffee_shop.orders
09:54:37.392108 [debug] [Thread-1 (]: Using duckdb connection "model.coffee_shop.orders"
09:54:37.393062 [debug] [Thread-1 (]: On model.coffee_shop.orders: BEGIN
09:54:37.393669 [debug] [Thread-1 (]: Opening a new connection, currently in state init
09:54:37.403457 [debug] [Thread-1 (]: SQL status: OK in 0 seconds
09:54:37.404068 [debug] [Thread-1 (]: Using duckdb connection "model.coffee_shop.orders"
09:54:37.404537 [debug] [Thread-1 (]: On model.coffee_shop.orders: /* {"app": "dbt", "dbt_version": "1.4.0", "profile_name": "duckdb", "target_name": "dev", "node_id": "model.coffee_shop.orders"} */

    create  table
      "coffee_shop_test"."main"."orders__dbt_tmp"
    as (

select * from "coffee_shop_test"."main"."stg_orders"
    );

09:54:37.440405 [debug] [Thread-1 (]: Timing info for model.coffee_shop.orders (execute): 2023-02-24 09:54:37.292091 => 2023-02-24 09:54:37.440173
09:54:37.440917 [debug] [Thread-1 (]: On model.coffee_shop.orders: ROLLBACK
09:54:37.443434 [debug] [Thread-1 (]: Failed to rollback 'model.coffee_shop.orders'
09:54:37.443952 [debug] [Thread-1 (]: On model.coffee_shop.orders: Close
09:54:37.448232 [debug] [Thread-1 (]: Runtime Error in model orders (models/marts/orders.sql)
  Catalog Error: Table with name stg_orders does not exist!
  Did you mean "temp.pg_catalog.pg_views"?
  LINE 11: select * from "coffee_shop_test"."main"."stg_orders"

The generated sql seems ok, but for some reason it seems to want to rollback, which is probably why it subsequently dbt model does not find the stg_orders view. It is strange that I do not see the actual error that caused the rollback. When I execute the create view statement manually in duckdb it is correct.
stg_orders.sql:
{{
    config(
        materialized = 'external',
        location='coffee-data/stg_orders.csv',
        format='csv'
    )
}}

select range from range(3)

orders.sql:
{{
    config(
        materialized = 'external',
        location='coffee-data/orders.csv',
        format='csv'
    )
}}

select * from {{ ref('stg_orders') }}

If I change the reference in the orders.sql to a source reference it works of course but is not what I want.
Am I missing something or is there something wrong with the register_upstream_external_models function?
Is the actual error swalled somehow, any idea how I could debug this further?
I am using dbt-duckdb 1.4.0 as well as dbt 1.4.0 and duckdb 0.6.1

@AlexanderVR curious if you have thoughts here- I can dive in when I’m back at “work” on Monday

Thanks @nclaeys for the very detailed report!
@jwills well this is embarrassing... https://github.com/jwills/dbt-duckdb/pull/109
I promise this was working on dbt-core==1.3.0 -- I have been using this macro separately there, just hadn't upgraded yet to dbt-duckdb 1.4.0.


Pretty Diff jsx wrap line length

Not working wrap line length or preserve new line
var New = React.createClass({
  render() {
    return (
      <InputText
        valid={validate}
        value={this.state}
        onChange={this.handleSalaryChange}
        label='test'
        onValidationError='test2'
        placeholder='test3'
        ref='test4'/>
    );
  }
});

After ctrl+alt+b i get
var New = React.createClass({
  render() {
    return (
      <InputText valid={validate} value={this.state} onChange={this.handleSalaryChange} label='test' onValidationError='test2' placeholder='test3' ref='test4'/>
    );
  }
});

Pretty Diff defect.

@jmlv If in the latest version of Pretty Diff you are no longer experiencing this problem would you mind recommending this issue be closed?

yes

Hi ! I'm on the last version of atom-beautify (0.29.7), and I get the same bug.
I setup JSX Wrap line length to 80, but it doesn't do anything (some lines in my code have a length of 100~110).
Is there any idea ?

I will investigate this weekend.

@AamuLumi I looked just now and could not reproduce the problem.  When I beautified the long defect sample in the first comment I get:
var New = React.createClass({
    render() {
        return (<InputText
            valid={validate}
            value={this.state}
            onchange={this.handlesalarychange}
            label='test'
            onValidationError='test2'
            placeholder='test3'
            ref='test4' />);
    }
});

Could you provide a code sample demonstrating this problem?


fix(usage): add chrome namespace to Window and add usage directions, fixes #17

Add dist/global.d.ts which takes the build output and adds it to the Window interface.
Update dist/README.md to document how to include this lib into a projects global typings.
Tell .gitignore to include dist/global.d.ts.
Update dist/package.template.json with some keywords for search on npm.

See this video for a little better explenation.  I also didn't want to modify any of the existing files so that we don't break the chrome types being used for dcc.

@devnook ptal

this will not force it to be a primary resolution in case some third party package installed @types/chrome

@olso-nordsec without being in the @types namespace this isn't an easy (possible?) thing to achieve. Additionally, merging with @DefinitelyTyped is something that makes sense to do. The way the typed libraries work with DefinitelyTyped and this lib work are very different. It would be interesting if there was a @types/* lib that digests what's generated and exports it would be interesting, but that depends on the bandwidth of the Chrome team.

For now, I'm using patch-package
diff --git a/node_modules/chrome-types/index.d.ts b/node_modules/chrome-types/index.d.ts
index 4438d02..41e7899 100644
--- a/node_modules/chrome-types/index.d.ts
+++ b/node_modules/chrome-types/index.d.ts
@@ -1,3 +1,4 @@
+declare module 'chrome-types' {
 /**
  * Copyright 2022 Google LLC
  *
@@ -28738,3 +28739,4 @@ declare namespace chrome {
     ): void;
   }
 }
+}

and then using it as
import type { chrome } from 'chrome-types';


Design and implement bulk operation statistics.

We need to decide how the statistics on bulk operations 'work'.  Of particular interest is how bulk operations can be related to their non bulk equivalents.  There is a related issue around how operations in general related to their logically equivalent operations, whether those are bulk to non-bulk breakdowns or compound to non-compound breakdowns.  The needs of JSR-107 are a particular constraining parameter set here.

From multiple discussions, what needs to happen here is that bulk stats should:

Offer operation statistics like  getAll count
Offer logical operations count like hits, misses, puts and removes

Current idea is to implement this inline, as is done for getAll counting hits and defer adding this support to the statistics framework.

Some bulk stats tests need to be added to org.ehcache.jsr107.StatisticsTest class, right???

Indeed, added to the PR


Update extending-filtering.md

Rephrased the text, fixes some punctuation errors.

Again ... thank you for your help on this project.

Join us on slack.chillicream.com and give me a ping there and we add you to the contributor channel.


React.js

Is it a good idea to get it working with React.js given that we'd be dealing with a virtual DOM?

I don't know if it's a good idea, but it would make me very happy. :)

I don't plan on doing anything specific to support React, but if there's something in particular you want me to do I might consider it.


Rename the helm mixin to helm2

This removes "helm" from the results of porter mixins search and ensures that it shows up as helm2 instead. If someone was installing the mixin with porter mixins install helm that will continue to work because we have old entries in our atom.xml but they will get the last version of the helm mixin before we renamed it.
Part of https://github.com/getporter/helm-mixin/issues/81

@vdice I have added a manual entry for helm2 to the mixin feed. It would require more work than we want to spend supporting a mixin where the name of the mixin is different from the binary name. So after people install the helm2 mixin, they will need to edit their porter.yaml file and change helm -> helm2,
e.g.
mixins:
- helm2

install:
- helm2:
   ...


Doc/example classification

Addresses Issue #90

@lorentzenchr this is my very first PR on github, maybe that's why I was not able to add you as a reviewer :)

First review round. In particular the HGBT model needs some more care.

@lorentzenchr thank you for the first review round, I tried to include all your feedbacks in the commits I have done.

Superseded by #121.


Edit hidden fields in model

Hello, I got in my model:
public $hidden = array('password', 'notes');

and in my admin model configuration:
'edit_fields' => array(
	'password' => array(
		'type' => 'password',
		'title' => 'Password'
	),
	'notes' => array(
		'title' => 'Admin Notes',
		'type' => 'textarea'
	)
)

With above code, i cannot see or set values in these fields. How can i do it?

A workaround that I've used:
// example class
class SomeClass extends Model
{
   protected $hidden = array('password', 'notes');
   ...
}

// Then define this model for use with laravel administrator only:
// here you can reset $hidden / $appends / $visible etc. to default values

class AdminSomeClass extends SomeClass {
    protected $hidden = [];

    // set the table name to match your original class, otherwise the class name is used for autonaming
    protected $table = 'some_class';

}

This seems like a problem that could be solved on the developer's end. It looks like the display list uses the object with accessors, because my hidden fields are displayed perfectly. And in the edit, editing fields actually does work, but when it loads the information into the admin fields, it uses a to_json or something else affected by $hidden, because hidden fields load in as blank, causing a huge issue for admins where it's easy to accidentally delete data by saving these empty fields while editing something else. If the edit_fields loaded their data the same as the display list, this wouldn't be a problem at all.
For now though, I think stevenbouma is right, and the only workaround is to create a separate model for admin use.


Rename Renaissance Tests

• Renamed Renaissance tests according to TRSS parser convention so that the results of these tests can be parsed and viewed on TRSS
• Disabled renaissance-finagle-chirper for now since it fails
Issue: https://github.com/AdoptOpenJDK/openjdk-tests/issues/1770
Signed-off-by: Piyush Gupta<EMAIL_ADDRESS>

Sanity Run:
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2986/console


Binding events outside initialization

I'm working with Bookshelf as my ORM in the context of websockets. My initial approach is to actually maintain long-running models/collections attached to the socket object, and while I'm not sure I'm going to stick with this approach, I do have another issue:
I want to attach to all of the Models' fetching/saving events in order to enforce saving/querying by the socket's user, as well as, in certain contexts, enforcing some defaults and broadcasting out to redis. Some of these (like the redis connection) can be added as an event binding in the model's initialize method, but many of the others need to be added in the context of the specific websocket connection and need to be added to all the models, even ones that haven't been created yet.
How would you go about adding these event bindings to models that don't "exist" yet?

Hi @mAAdhaTTah. Could you provide more detail about the situation in which you want an event? Is it as simple as wanting an event triggered every time you call Collection#fetch or Model#fetch? (ie. any time that a query goes out that will return some set of models.)

Both fetching and saving, in order to either constraint the query to just the socket's user for the former, or set the user id for the latter. There are some other things I would do with it as well, but those are the ones that seem like a common use-case, i.e. adding the event to constrain all queries after a user has logged as Express middleware.

I think I understand, sorry if I've missed the mark here.
It seems to me that what you're describing here is a simple relationship. A relationship is essentially what you say - when saving you default some properties. eg.
let user = User.forge({id: 1});
// Automatically sets user_id to 1
user.related('resources').create({ name: 'new-resource' }).then(//...

// Automatically constrains select query to user_id = 1.
user.related('resources').fetch().then(//...

My approach to this is to just use relations from User everywhere. Simply retrieve the appropriate User model from your socket connection.
So, I do something like this in express. I'm just going to use this generic 'Resource' model.
resourcesRouter = express.router();

resourcesRouter.use(function(req, res, next) {
  // req.user is attached by PassportJS
  req.models.resources = req.user.related('resources');
  next();
});

resourcesRouter.route('/')
.get(function(req, res, next) {
  req.models.resources
  .fetchAll()
  .then(res.json);
})
.post(function(req, res, next) {
  req.models.resources
  .create(req.body)
  .then(req.json);
});

resourcesRouter.route('/:resourceId')
.get(function(req, res, next) {
  // Also constrained by `user_id` because resources is a relation.
  req.models.resources
  .query('where', 'id', req.params.resourceId)
  .fetch()
  .then(res.json);
})
.patch(function(req, res, next) {
});

This works for me. I'm actually playing around with building a plugin that would do what I'm thinking of, though it may not even be necessary. Thanks for your help.


[ROCm][Bugfix] Fixed several bugs related to rccl path and attention selector logic

FILL IN THE PR DESCRIPTION HERE
FIX #xxxx (link existing issues this PR will resolve)
This pull request fixes several bugs introduced in previous commits, for example: https://github.com/vllm-project/vllm/pull/3661, https://github.com/vllm-project/vllm/pull/3625 , and previous refactoring in attention backend.
(1) Fixed the hard-coded wrong library path for rccl by using a robust way to check libtorch.so dependency.
Before:
ERROR 03-28 18:30:12 pynccl.py:52] Failed to load NCCL library from librccl.so.2 .It is expected if you are not running on NVIDIA/AMD GPUs.Otherwise please set the environment variable VLLM_NCCL_SO_PATH to point to the correct nccl library path.
INFO 03-28 18:30:12 pynccl_utils.py:17] Failed to import NCCL library: librccl.so.2: cannot open shared object file: No such file or directory
INFO 03-28 18:30:12 pynccl_utils.py:18] It is expected if you are not running on NVIDIA GPUs.

Now:
INFO 03-28 19:22:21 pynccl.py:45] Loading nccl from environment variable VLLM_NCCL_SO_PATH=/opt/rocm/lib/librccl.so.1

(2) a bug related to check whether to use ref-attention resulted from previous refactoring:
Before: even flash-attn is available, it uses naive attention.
WARNING 03-28 18:26:49 xformers.py:410] flash_attn is not installed. Using naive attention. This will take significantly more GPU memory.

Now:
INFO 03-28 18:30:12 selector.py:29] Cannot use FlashAttention backend for AMD GPUs.
Using XFormers backend.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Thanks for the contribution!
Some comments:
Because we import torch first, if torch already loads librccl.so , then it should just work . So we need to figure out how torch loads it. In NVIDIA case, torch always uses libnccl.so.2 to refer to the nccl library, that's why we use libnccl.so.2 .
For the rccl case, if the convention way of torch is to use librccl.so.1 , then we just need to append librccl.so.1 . It should work by default for pytorch users.
Furthermore, pytorch uses https://pypi.org/project/nvidia-nccl/ as a pip package to maintain nccl dependency. Does this apply for the rccl case? Or pytorch ships rccl with it? Or it just uses the rccl inside the OS?

I agree your method of finding rccl is very robust, but we don't need to be so complicated. By default, we just need it to work with the default way users install torch. Otherwise, when users want to use their own rccl library, we cannot really have a robust way to "find" it, because it might not be in the search path of ldd. That's why I left an environment variable there for further use.

In summary, the following information would be greatly helpful:

When people do pip install torch in rocm platform, how does torch use rccl? Does pytorch statically link librccl.a, or dynamically link to librccl.so? If the latter is true, does pytorch install its own version (and if yes, where?) or use the existing version in a typical search path (and if yes, where?)?
In the case of dynamic linking, what's the conventional name of librccl.so? For example, when I use rccl==2.18.3, do I get all of the librccl.so/librccl.so.2/librccl.so.2.18/librccl.so.2.18.3 ? Or just have one (if yes, what's the name)?

I can provide the above information for nvidia case, for your reference:

When people do pip install torch in cuda platform, pytorch dynamically links to libnccl.so. Pytorch install its own version in ${CONDA_PREFIX}/site-packages/nvidia/nccl/lib/ , and that path is embedded in libtorch_cuda.so's rpath.
The conventional name of libnccl.so is libnccl.so.2 .

Thanks for the contribution!
Some comments:
Because we import torch first, if torch already loads librccl.so , then it should just work . So we need to figure out how torch loads it. In NVIDIA case, torch always uses libnccl.so.2 to refer to the nccl library, that's why we use libnccl.so.2 .
For the rccl case, if the convention way of torch is to use librccl.so.1 , then we just need to append librccl.so.1 . It should work by default for pytorch users.
Furthermore, pytorch uses https://pypi.org/project/nvidia-nccl/ as a pip package to maintain nccl dependency. Does this apply for the rccl case? Or pytorch ships rccl with it? Or it just uses the rccl inside the OS?

The short answer for how pytorch finds rccl during its build, is in its cmake mechanism. By default, it finds rccl related version information in /opt/rocm/lib/cmake/rccl directory.

I'm ok with the modification in pynccl.py . Please ping others for approval on the other parts.

cc @simon-mo @WoosukKwon Please take a look at this one since right now users complained that naive attention is used which is 10x slower


WIP: new apt yum repos for release scripts

This a WIP patch to add yum repos and new apt repos to the Docker release process.
The idea is the following:
Docker APT Repository
hack/make.sh release-deb will create/update an apt repo which will allow for the following apt source format:
deb http://apt.dockerproject.org/repo $distro-$release $version

# For example:
deb http://apt.dockerproject.org/repo ubuntu-trusy main
deb http://apt.dockerproject.org/repo ubuntu-vivid testing
deb http://apt.dockerproject.org/repo debian-wheezy experimental
deb http://apt.dockerproject.org/repo debian-jessie main

Docker YUM Repository
hack/make.sh release-rpm will create/update an yum repos in the following format:
http://yum.dockerproject.org/$release/$distro/$distro-version

# For example:
http://yum.dockerproject.org/stable/fedora/22
http://yum.dockerproject.org/testing/centos/6
http://yum.dockerproject.org/experimental/fedora/21
http://yum.dockerproject.org/stable/centos/7

GPG Signing
Everything about this is made to be super modular in that the debs and rpms can be built on one server, then passed to another server where release-deb or release-rpm is run on the actual apt and yum repos.
Then out of process (or at the same time) you can sign the repo metadata with a GPG key using hack/make/sign-repo.
Things left remaining:

[ ] new install script which uses these repos and sets them up for users
[ ] a way for people to migrate away from get.docker.com / test.docker.com

ping @tianon @paultag @vbatts
:D

such
On Tue, Jun 2, 2015 at 8:12 PM, Jessie Frazelle<EMAIL_ADDRESS>wrote:

ping @tianon https://github.com/tianon @paultag
https://github.com/paultag @vbatts https://github.com/vbatts
:D
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-108137203.

Do you think we can remove that static builds altogether now?  It would really help when we want to link to new C dependencies and such.

We can probably just stop updating those and force people onto the new ones
On Mon, Jul 6, 2015 at 2:19 PM, Michael Crosby<EMAIL_ADDRESS>wrote:

Do you think we can remove that static builds altogether now? It would
really help when we want to link to new C dependencies and such.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-119001001.

Is there any reason that there is no note that the install script only works on certain distros. It's a bit misleading here and in the docker blog.

well now it will work on all, also this pr is not to change the install
script yet, so idk why this comment is here
On Tue, Jul 14, 2015 at 11:21 AM, Kevin Kirsche<EMAIL_ADDRESS>wrote:

Is there any reason that there is no note that the install script only
works on certain distros. It's a bit misleading here and in the docker
blog.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-121329164.

@jfrazelle this is here because this is where I was directed for the fact that your install script installs 1.6.2 instead of an actual experimental version. Considering you have one, it should do what it's supposed to IMO or it shouldn't be there as it's very misleading.

yes but commenting on a PR that is not changing the install script is not
the place.
On Tue, Jul 14, 2015 at 11:30 AM, Kevin Kirsche<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle this is here because this is
where I was directed for the fact that your install script installs 1.6.2
instead of an actual experimental version. Considering you have one, it
should do what it's supposed to IMO or it shouldn't be there as it's very
misleading.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-121331349.

@jfrazelle I disagree. Your project, your choice though

I have updated this PR, I think the remaining steps should be:

Review and Merge
We deploy the latest release to here as well as experimental
Write/Release epic blog post begging people to use the new stuff
high five each other

7 people keep complaining "why da f*ck doesn't docker provide dynamically linked builds"
8 add link to this PR and the epic blogs post
9 dry tears and put up "for rent sign" outside echo chamber
10 party!

hahahha

:+1:
On Jul 14, 2015 17:40, "Jessie Frazelle"<EMAIL_ADDRESS>wrote:

hahahha
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-121398903.

Other than my one clarification, LGTM! :+1: :metal:

I think this needs a checkbox for updating documentation as well?

yes for sure i think i will incorporate that into #14638

:+1: thanks!

I have pushed experimental rpms and debs to https://apt.dockerproject.org and https://apt.dockerproject.org
You can test with the following:
apt:
$ apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D
$ mkdir -p /etc/apt/sources.list.d

# you can replace debian-jessie below with something like ubuntu-trusty, etc
$ echo deb https://apt.dockerproject.org/repo debian-jessie experimental > /etc/apt/sources.list.d/docker.list

$ apt-get update
$ apt-get install -y -q docker-engine

yum:
# replace centos/7 with your version, such as fedora/22, on rhel still use centos as base
$ cat >/etc/yum.repos.d/dockerexperimental.repo <<-EOF
[dockerexperimentalrepo]
name=Docker Experimental Repository
baseurl=https://yum.dockerproject.org/repo/experimental/centos/7
enabled=1
gpgkey=https://yum.dockerproject.org/gpg
EOF

$ yum -y -q install docker-engine

@jfrazelle are RPMs for Oracle Linux on the yum repo as well? Can I use oraclelinux/6 and oraclelinux/7?

no not yet sorry, i will fix that tomorrow
On Tue, Jul 14, 2015 at 8:38 PM, Avi Miller<EMAIL_ADDRESS>wrote:

@jfrazelle https://github.com/jfrazelle are RPMs for Oracle Linux on
the yum repo as well? Can I use oraclelinux/6 and oraclelinux/7?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-121477139.

Is Docker Project going to stop shipping a standalone binary version?  Is deb/rpm going to be the only officially support approach?
@crosbymichael I like the static binary....

yes we are still doing binaries dont worrry

that was never in question

@Djelibeybi the & ones are up at oraclelinux/7 the other has not been merged yet :)

@jfrazelle champion, thanks. :+1:

Awesome!
Oh, thinking of one more checkbox for the list (which you probably already thought of); docker machine will probably need to be updated to use these, so
ping @ehazlett @nathanleclaire :-)

Yay!  This will be great thanks!
On Wed, Jul 15, 2015 at 2:38 AM, Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

Awesome!
Oh, thinking of one more checkbox for the list (which you probably already
thought of); docker machine will probably need to be updated to use these,
so
ping @ehazlett https://github.com/ehazlett @nathanleclaire
https://github.com/nathanleclaire :-)
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-121507322.

@ehazlett do you want me to backport the 1.7.1 release here to stable for you to integrate w machine and test

@jfrazelle that would be great -- thanks!!

:+1:

FTR, just tested the repo on Fedora 22 successfully (hence using dnf and not yum command, btw).
To be sure: it installed the "1.6.0-3.git9d26a07.fc22" version and not a 1.7.x one (current stable IIRC).
I suppose this is an "old" version because this is still being tested and when it's streamlined with your release process that repository will get updated at the same time of the rest with new releases?
Thanks for that improvement
Cheers

it should be a 1.8.0-dev version not 1.6.0, those are not even on that repo.....

@Batmat did you follow this exactly https://github.com/docker/docker/pull/13680#issuecomment-121462083

OK, I was a :goat: on this one.
Actually, no, I didn't follow the commands as-is. I almost read it correctly, but stupidly missed the fact the pkg was called docker-engine and not docker, and so actually installed the one provided in std by Fedora official repo...
For reference, here's what I did (after correction, let's say I just rebased -i, :sheep: /me) :
sudo dnf config-manager --add-repo https://yum.dockerproject.org/repo/experimental/fedora/22
sudo dnf remove docker
sudo dnf install docker-engine

But, now docker is not found in the PATH. Maybe it's related to the fact it's a dev version and it's installed somewhere else?

can you give me a little more output like install logs or something
On Wed, Jul 15, 2015 at 2:45 PM, Baptiste Mathus<EMAIL_ADDRESS>wrote:

OK, I was a [image: :goat:] on this one.
Actually, no, I didn't follow the commands as-is. I almost read it
correctly, but stupidly missed the fact the pkg was called docker-engine
and not docker, and so actually installed the one provided in std by Fedora
official repo...
For reference, here's what I did (after correction, let's say I just
rebased -i, [image: :sheep:] /me) :
sudo dnf config-manager --add-repo https://yum.dockerproject.org/repo/experimental/fedora/22
sudo dnf remove docker
sudo dnf install docker-engine
But, now docker is not found in the PATH. Maybe it's related to the fact
it's a dev version and it's installed somewhere else?
—
Reply to this email directly or view it on GitHub
https://github.com/docker/docker/pull/13680#issuecomment-121759052.

I just ran it in a container for fedora 22 and it worked

OK, still missed a step, about GPG... Installed using --nogpgcheck
Now it's working!
[HOME] [23:59:01] tiste:sonarqube $ d version
Client:
 Version:      1.8.0-dev
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   a031b64
 Built:        Wed Jul 15 06:30:58 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.0-dev
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   a031b64
 Built:        Wed Jul 15 06:30:58 UTC 2015
 OS/Arch:      linux/amd64

Thanks!

ok cool might be because im mid process deploying another ;)

Ok this works really well, can we merge, I tested in containers for all ;)

with updates too ;)

@jfrazelle fyi I just tested these (https://github.com/docker/machine/pull/1543) with CentOS 7, RHEL 7.1 and Fedora 22 and all work great.  Thanks!!

Wooooohoooo ship it!

On Jul 16, 2015, at 20:13, Evan Hazlett<EMAIL_ADDRESS>wrote:
@jfrazelle fyi I just tested these (docker/machine#1543) with CentOS 7, RHEL 7.1 and Fedora 22 and all work great. Thanks!!
—
Reply to this email directly or view it on GitHub.

After following all the steps on a ubuntu-trusty box I get the following
apt-get install docker-engine
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 docker-engine : Depends: init-system-helpers (>= 1.18~) but 1.14 is to be installed
                 Depends: libdevmapper1.02.1 (>= 2:1.02.90) but 2:1.02.77-6ubuntu2 is to be installed
E: Unable to correct problems, you have held broken packages.

did you remove your old package?

did you use ubuntu-trusty in the apt-repo

/me facepalm
Nope that fixed it

LGTM. Merging! :tada: :exclamation:

Yeah! Thanks @jfrazelle !!

Yay! :+1:


iOS Device Locale Returns Nothing

RN: 0.39.0
i18n: 0.1.1
iOS 10.1 running on simulator iPhone 6.
Here's my excerpt of code:
import React, { Component } from 'react';
import ReactNativeI18n from 'react-native-i18n';
const deviceLocale = ReactNativeI18n.locale;
console.log('LOCALE: ' + deviceLocale);
And the sample greeting in the README.
The Android simulator is returning the French translation: "Bonjour!" and logs "LOCALE: fr-CA", while iOS fallsback to English, and the console log returns "LOCALE: ". I can manually set the locale and it translates properly, but it's not reading the locale automatically from the device.

@MattyK14 Did you do anything else to resolve this issue? I've encountered it even though I'm running XCode 8.2.1 and iOS 10.2 in my simulator.

@stinodes Nope the update solved the problem. Did you link react-native-18n?

@MattyK14 I did (just using the react-native link-command though). Works fine on android, but returns an empty string on iOS, as you described.
I might go over the manual set-up to see if there's something missing though.

I have same issue on iOS :(


Can I modify the library to make networks run faster?

❓ Questions and Help
Hello, thank you for amazing library!
I am working on an application that requires near realtime processing (~10 fps, i.e. 100 ms) on ~1050 GPU on ~ 1280x720 images. Is there anything I could easily modify that can make the object detection networks faster. I tried Resnet-50-FPN and got ~160 ms on 1070 GPU. I was thinking to modify the number of proposals (number of objects in my images are < 14, classes are < 6) that are processed by ROI heads or can I modify the architecture itself easily (e.g. number of filters)? What would you recommend? I don't mind to suffer a small decrease in mAP.
Cheers,

I have a some smaller networks that runs faster, but have significantly worse map (24 map on COCO, compared to 36 for R-50). I might still look into getting smaller models with better accuracies, but I can't promise I'll get anything better for now.
Decreasing the number of proposals in the RPN and increasing the MODEL.ROI_HEADS.SCORE_THRESH will speed things up a bit as well

Smaller input will speed up inference time.

@wangzhangup MobileNet backend are expecting to extremly faster inference proccess

If anyone is willing to send a PR adding a MobileNet backbone, I'd be more than happy to help review it and merge it into the library


Error when trying to debug a test

Hello,
When trying to :OmniSharpDebugTest a test, I get an error:
Error detected while processing function OmniSharp#proc#vimOutHandler[11]..OmniSharp#stdio#HandleResponse[42]..<SNR>172_DebugTestsRH:
line    1:
E121: Undefined variable: FileName

I made a repository to help try and reproduce the issue here - configuration elements are in the README.
Can you tell me if you are able to reproduce it?

I moved my plugins folder recently and vimspector kept detecting netcoredbg was present but had issues using it from the new location.
I fixed it by removing vimspector, then reinstalling it, then reinstalling netcoredbg through it.


pkg/logging: move pkg/debugdetection to pkg/logging

Since the debug detection is only used for the log package it doesn't
make sense to have them split in different packages.
Signed-off-by: André Martins<EMAIL_ADDRESS>

This change is

test-me-please