skipper: skip cask, mas on Linux.

This is the best default functionality as these can never be installed.

At the moment my approach to this is a load of if OS.mac? conditions in Brewfiles, so this looks great! I guess we’ll still have to put Linux-only formulae (alternatives to casks on Linux, ie “linuxbrew/extra/aws-vault”) behind an if OS.linux? conditional. But this definitely tidies things up. Thanks for doing this!

I just tested this locally on Linux with a three line test Brewfile with brew and cask entries, and I get:
$ brew bundle --file=BrewfileTest
Error: undefined local variable or method `generic_skip' for Bundle::Skipper:Module

Probably want to add some Linux CI with this before I merge it. Yeh, Linux only formulae will need an if still. Thanks for the suggestion @colindean and testing @issyl0!

:tada: cool!


Feedback Testnet

I hope there will be an increase in the features of the asset section, it doesn't look good, it should be changed to make it more attractive, such as adding daily PNL / profit and please also add transaction history so that users can more easily check each transaction it would be nice not to mix earnings and liquidity so that people can know which is the liquidity pool and which is the earn pool for farming and staking
0x53f792e5442E7454BFc2c01Ac8A62976B4d35EbD

@mrstuti Thank you for your suggestions, we've taken your request and noted it within our potential enhancement document list!


Error: Objects are not valid as a React child (found: [object Promise]). If you meant to render a collection of children, use an array instead.

Screenshots

If applicable, add screenshots to help explain your problem.

pls assign this to me:)

@himanshujaidka  I think this was solved last night

@himanshujaidka I think this was solved last night
did you fetch it?

yes, sorry, confusion with multiple branches


[Intertnal]Need a page for announcement from homepage

Subject of the issue
Need a page for announcement from homepage
Your environment

version of your python
which browser and its version
OS Type (iOS/Android/Linux/Windows)

Steps to reproduce
Tell us how to reproduce this issue. Please provide a working demo as a GIF, if possible.
Expected behaviour
Tell us what and how exactly is it supposed to  happen
Actual behaviour
Tell us what happens instead or what went wrong

Could you verify if this is what's required.
Main Page

Announcements are maintained in the database so that they can be updated in the backend.
The announcements page

@theryecatcher The main page looks good. No need to put announcements inside a table. You can put the heading as the link and when we click on it, the announcement expands to show the rest of the content.

Announcements can be shown similar to blog-summaries

@PSNAppz Thanks will look into the collapsible part. The idea of a table was to avoid editing the page for each new entry of and when they are to be added.

I think @PSNAppz was talking about the front-end table.
The backend table should stay.

Yes, I believe.

Annoucements can show as Headlines in the top of the Page. we can show as moving one (sliders) - from Left to right

@namboodiri Yes, I was talking about the front-end only.

can't implement this as CMS??? data in the front-end keeps moving as a slider?

Yes a ticker seems to be a better option connected with the backend table. Am trying to implement that right now let me know if anyone else wants to take it up if they can do it faster.

May I know who all are working on this currently? Is there any PR currently raised? This would be a really good feature addition. Also, test it on mobile also guys, you can use chrome dev tools for this

I am trying to implement a ticker feed to the homepage.

I am trying to implement a ticker feed to the homepage.

We need the home page to load really fast - so no JS etc please.

I have submitted a PR #296 with the basic infra. Would need to populate the DB though with the links.

Anurag [11:41 AM]
Working on it.

@cyberjithu working on this now.

Need internal review @naveenpf

@biswaz also from @vigneshhari
I am skeptical about the db change involved. Please make sure that  the changes are not major.
Also the PR is under testing

Please see websockets also while on this issue  - https://www.fullstackpython.com/websockets.html

There is a PR #296 under testing. Please work on websockets if it won't put extra load on the server. Priority would be to serve the pages as soon as possible seieng low connection speeds.


Missing InBound actions

We have odatav4 service.The metadata has an action PostGoodsReceipt, but when i try to get action
const entity = service.EntitySetName;
console.log(entity.key(keys).PostGoodsReceipt);
is undefined

Hi,
The issue still exists. I am not able to call the standard EDIT action of V4 RAP. The documentation also says:
'We have implemented bound Actions now without aditional parameter.'.
BTW, I saw a merged PR on this topic.

Actions parameters are now supported since version 2.3.0. There should be no more issue with calling actions.


Built in function to count the number of bits set

Suppose you have a bits type like the following:
bits Features:
  0     [+1] Flag foo
  $next [+1] Flag bar
  $next [+1] Flag baz
  $next [+1] Flag abc
  $next [+1] Flag xyz

A packet contains a bitset like the one above with the number of flags enabled determining the size of a variable length array.
struct Data:
  0     [+1] Features features

  let num_features = (features.foo ? 1 : 0) + (features.bar ? 1 : 0) + ...
  $next [+num_features] UInt feature_values

The calculation of num_features can become quite a bit of toil. We have to physically write out the bits we wish to check. It would be easy to forget to add here if another needed to be checked in the future. It would be much easier to simply call out to a built in function which can do the counting for us.
Something like this would be so much better:
struct Data:
  0     [+1] Features features

  let num_features = bits_set(features)
  $next [+num_features] UInt feature_values

Are you asking for a POPCOUNT function + a way to reinterpret_cast a bits to UInt, or something that would actually analyze the bits and only pay attention to known Flag fields?

I was asking more for a std::popcount type approach.

Adding $popcount should be straightforward: a 1-adic function that takes an integer argument.  Min value is 0, max value is ciel(log2(input max val)), +1 if the input can be negative.  Would need some #ifs in the C++ implementation to use std::popcount() or __builtin_popcount() where available, and fallback to a C++11 native implementation otherwise.
Internally, a bits field and a UInt field (also Flag, Int, Float, etc.) are treated similarly, so some equivalent of reinterpret_cast that basically says "pretend this field is this other type and read it out" should be doable.  We would have to figure out a readable syntax -- there aren't many languages that let you cast pointers that way, so $reinterpret_cast<UInt>(field) might be the least-bad option.


Random Battle: Prevent generating teams with too many Uber Pokemon

At the moment, it doesn't properly account for Bank-Uber tiered Pokemon, resulting in matches like this : http://replay.pokemonshowdown.com/gen7randombattle-515699799
Also updated the comments to match the changes.

I wish Bank would come out already


how do you clear text?

Suppose I wanted to flicker text on the screen; how do I clear previous text? I've tried this:
      if(this.flicker) {
        display.drawText(33, 12, 'Generating ...');
      } else {
        display.drawText(33, 12, '              ');
      }

(where this.flicker changes every few seconds) but no dice.
Perhaps a display.clearText would be nice?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/24439871-how-do-you-clear-text?utm_campaign=plugin&utm_content=tracker%2F297828&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F297828&utm_medium=issues&utm_source=github).

Hmm, the drawText routine removes whitespace from each printed line, effectively trimming the string.
This is a complex issue, because rot.js breaks text into lines. I am not entirely sure how to solve this -- you do not know how many characters were actually printed using the first drawText statement.
If you are certain about the number, than doing .draw(x, y, " ") in a loop is sufficient. Or using a dedicated ROT.Display and clearing it completely.

In general, I do know the length of the string. What I ended up doing was just doing a display.clear() and then re-drawing everything. It's a bit hokey though, I think, because I also tried displaying a sequence of characters like so:
    this.flicker = 0;

    let dotStatus = ['.  ', '.. ', '...', ' ..', '  .'];

    this.interval = setInterval( () => {
      display.clear();
      this.render(display);

      display.drawText(33, 12, `Generating ${dotStatus[this.flicker]}`);

      this.flicker = ++this.flicker % dotStatus.length;
    }, 500);

And if I didn't have the display.clear in here, the results were very unpredictable.
All this said, I'm not sure the global value of having clearText but it might be something to consider.

You know the length of the input string, but you do not know how many characters were drawn. This is because the text gets broken into lines and every line has its leading whitespace removed.
For your case, using draw instead of drawText shall yield better experience. drawText is too smart because of its complex line breaking internals.

Ah, I see. Thanks for the heads up. If you'd like, feel free to close this issue -- I'll leave it open in case you want to put this in the documentation or somewhere else.


[1.3.0][Distribution][BUG] Job Scheduler failed the 1.3.0 build due to failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.

2022-03-08 16:42:15 INFO     Building job-scheduler
2022-03-08 16:42:15 INFO     Executing "git init" in /tmp/tmp8d7oail8/job-scheduler
2022-03-08 16:42:15 INFO     Executing "git remote add origin https://github.com/opensearch-project/job-scheduler.git" in /tmp/tmp8d7oail8/job-scheduler
2022-03-08 16:42:15 INFO     Executing "git fetch --depth 1 origin main" in /tmp/tmp8d7oail8/job-scheduler
2022-03-08 16:42:15 INFO     Executing "git checkout FETCH_HEAD" in /tmp/tmp8d7oail8/job-scheduler
2022-03-08 16:42:15 INFO     Executing "git rev-parse HEAD" in /tmp/tmp8d7oail8/job-scheduler
2022-03-08 16:42:15 INFO     Checked out https://github.com/opensearch-project/job-scheduler.git@main into /tmp/tmp8d7oail8/job-scheduler at ec916373d2a20c268ff8e49a82bbadfbbbfb5c5b
2022-03-08 16:42:16 INFO     Executing "bash /tmp/tmp8d7oail8/job-scheduler/scripts/build.sh -v 1.3.0 -p linux -a x64 -s true -o builds" in /tmp/tmp8d7oail8/job-scheduler
+ getopts :h:v:s:o:p:a: arg
+ case $arg in
+ VERSION=1.3.0
+ getopts :h:v:s:o:p:a: arg
+ case $arg in
+ PLATFORM=linux
+ getopts :h:v:s:o:p:a: arg
+ case $arg in
+ ARCHITECTURE=x64
+ getopts :h:v:s:o:p:a: arg
+ case $arg in
+ SNAPSHOT=true
+ getopts :h:v:s:o:p:a: arg
+ case $arg in
+ OUTPUT=builds
+ getopts :h:v:s:o:p:a: arg
+ '[' -z 1.3.0 ']'
+ [[ true == \t\r\u\e ]]
+ VERSION=1.3.0-SNAPSHOT
+ '[' -z builds ']'
+ ./gradlew publishToMavenLocal -Dopensearch.version=1.3.0-SNAPSHOT -Dbuild.snapshot=true
Downloading https://services.gradle.org/distributions/gradle-7.3.3-bin.zip
...........10%...........20%...........30%...........40%...........50%...........60%...........70%...........80%...........90%...........100%

FAILURE: Build failed with an exception.

* Where:
Build file '/tmp/tmp8d7oail8/job-scheduler/build.gradle' line: 28

* What went wrong:
A problem occurred evaluating root project 'opensearch-job-scheduler'.
> Failed to apply plugin class 'org.opensearch.gradle.info.GlobalBuildInfoPlugin'.
   > Could not create plugin of type 'GlobalBuildInfoPlugin'.
      > Could not generate a decorated class for type GlobalBuildInfoPlugin.
         > org/gradle/jvm/toolchain/JavaInstallation

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

BUILD FAILED in 7s
2022-03-08 16:42:23 ERROR    Error building job-scheduler, retry with: ./build.sh manifests/1.3.0/opensearch-1.3.0.yml --component job-scheduler --snapshot
Traceback (most recent call last):
  File "./src/run_build.py", line 79, in <module>
    sys.exit(main())
  File "./src/run_build.py", line 67, in main
    builder.build(build_recorder)
  File "/var/jenkins/workspace/distribution-build-opensearch/src/build_workflow/builder_from_source.py", line 54, in build
    self.git_repo.execute(build_command)
  File "/var/jenkins/workspace/distribution-build-opensearch/src/git/git_repository.py", line 83, in execute
    subprocess.check_call(command, cwd=cwd, shell=True)
  File "/usr/local/lib/python3.7/subprocess.py", line 363, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'bash /tmp/tmp8d7oail8/job-scheduler/scripts/build.sh -v 1.3.0 -p linux -a x64 -s true -o builds' returned non-zero exit status 1.

Seems like it is fixed now in https://github.com/opensearch-project/opensearch-build/pull/1717.
New error in: https://github.com/opensearch-project/opensearch-build/issues/1721
Thanks.


Dark mode

It's working, but Franz's Dark Mode compromises reading. Have a look:

Is there anything I or you can do about it? Otherwise nothing is wrong.
Thanks for making the plugin though, saved me the trouble of doing it myself ^^

This plugin save me too. If I could help in some way, just tell me

I don't use Evernote anymore but added it to check. Not sure I can replicate. This is basically just a window to the web app so Franz's dark mode should not interfere. Might be an Evernote issue? I honestly don't know. I'll leave this issue open in case anyone can help.


Wait for masks to be loaded before returning loaded object

Merged-in https://github.com/Blaxar/three-rwx-loader/commit/91f726318b0984eff2083a67f88d6bb452a224ec


Example Shadow DOM Styling

It would be nice if there was an example of how to style the Ionic components using CSS variables. Judging by comments on articles about Ionic 4, styling the components seems to be one of the major challenges for people upgrading.

Hi @garviand thanks for the feedback!
We are planning to update this starter with more examples.
Check https://github.com/ionicthemes/ionic-4-custom-components and
https://ionicthemes.com/tutorials/about/ionic-4-tutorial-mastering-web-components-in-ionic-4


Disable add bank account button for non-validated user

Details

We don't want to allow non-validated user to add bank account.
Fixed Issues

$ https://github.com/Expensify/App/issues/46386
PROPOSAL: https://github.com/Expensify/App/issues/46386#issuecomment-2254866226
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Sign in as a new user
Go to Settings > Wallet
Verify Add bank account button is disabled
Press Enable Wallet
Verify Add bank account button is disabled
Validate your account
Verify the Add bank account button in step 3 and 5 is enabled

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/7126cfba-608c-4757-8183-b03660afc52a

Android: mWeb Chrome

https://github.com/user-attachments/assets/654908e9-aa68-4138-9adc-81404a3a0ce6

iOS: Native

https://github.com/user-attachments/assets/34d1c4d8-f5f1-4cdd-911d-ab4796c834c8

iOS: mWeb Safari

https://github.com/user-attachments/assets/685c208f-40df-4f53-ac46-23739fabab47

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/6ca1c509-7541-4cbf-a231-505a8f681d9a

MacOS: Desktop

https://github.com/user-attachments/assets/4836773a-94a2-4320-857a-aa8d1121307e

Additional video showing the not found will show if the user tries to directly access the add bank account page by URL.
https://github.com/user-attachments/assets/ffbbb723-8476-4323-8865-7b1efacf7821

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/e10a87ff-ed74-4a2f-820c-1a8b7d42b9ce
https://github.com/user-attachments/assets/e8a64d3e-963b-4210-abb5-8e6a2f0c214b

MacOS: Desktop
https://github.com/user-attachments/assets/769c7308-f421-451d-b4d1-278fdc58a501

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.0.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Let CLI create a working VS boilerplate + create boilerplate

When moving VueStorefront to an NPM package we'll have a CLI and wish to have a command to easily create a VueStorefront project.
VueStorefront will be an NPM dependency.
Do we want to ask questions while creating the project such as

testing framework
type of backend (Magento|Shopware|etc)

One question that would be great would be to ask the format of the config.
Like yaml or json as example.
Should i open that as a feature request for version 2.0?


[FEATURE] sls_logs.proto建议定义成ms时间戳Again

Concisely describe the proposed feature
A clear and concise description of what you want. For example,

I would like to add an input plugin to collect logs by SNMP protocol so that my network devices' logs will be collected.

Describe the solution you'd like (if any)
A clear and concise description of what you want to achieve and implement. For example,

We can use the package github.com/gosnmp/gosnmp to act as an snmp server in a gesture to collect client logs.

Additional comments
Add any other context or screenshots about the feature request here.
For example, the ideal input and output logs.

The logs are supposed to have the following contents, e.g.,
{"_target_":"<IP_ADDRESS>","_field_":"DISMAN-EXPRESSION-MIB::sysUpTimeInstance","_oid_":".<IP_ADDRESS>.<IP_ADDRESS>.0","_type_":"TimeTicks","_content_":"10423593"}

@bbz525 预期输出里似乎没有时间戳相关的字段，可以再描述详细点吗？


Messaging Fixes

Overview

Update keyboard logic in ChatViewController to remove existing visual bugs and usability issues for messaging. Previous issues include the nav bar being transparent, messages disappearing off-screen, dates collapsing ontop of each other and overlapping cells, and the chat input view resetting if the app was exited.
Changes Made

Add keyboardWillChange listener, update chatTableView to be a grouped style so date section headers don't overlap with message cells. Change the view frame shift logic to constraint changes for specific UI elements with corresponding animations.
Test Coverage

Tested on device looking at long message chats, short ones and ones with no messages at all.
Screenrecording

New UI

https://user-images.githubusercontent.com/45302979/163693511-b975e594-ff4f-46be-beee-5d3538438ecd.mov

Old UI

https://user-images.githubusercontent.com/45302979/163693526-86730b22-1c35-4d36-919e-000381d039e9.mov

Nice PR! Excited to use the new texting experience to spam @snajima with messages :) Just one question: were you able to test with various keyboard settings? In your video your keyboard has suggested words, but others may have this setting turned off.

Yup this works with the predictive feature off!


AccessTokenResponse contains non-standard attribute

I'm running into a decoding failure when attempting a client credentials grant because my identity service is not returning a value for domain that AccessTokenResponse expects: https://github.com/ocadotechnology/sttp-oauth2/blob/b605d0be2f943e66a4c38931a3ba71c9e39c966c/oauth2/src/main/scala/com/ocadotechnology/sttp/oauth2/ClientCredentialsToken.scala#L24-L29
According to the OAuth 2.0 spec the only valid attributes for the response are access_token, token_type, expires_in, refresh_token, and scope.
Can domain be made optional, or have I missed something here? I'm using 0.10.1 of your library.

Thanks for reporting!
Had a quick look, this seems to check out but I'll defer to the local expert @majk-p 😅

Thanks for the prompt response @kubukoz. I'm happy to open a PR for the change if we all agree it's the correct approach.

Hi @vakhtang, thanks for the report! You are right that we don't follow the OAuth spec here, and we should fix that.
We were thinking about solution similar to this one: https://github.com/ocadotechnology/sttp-oauth2/pull/104 introduced for AuthorizationCodeGrant. The bottom line would be to allow end user to specify the response type, while we'd provide a basic one (similar to OAuth2TokenResponse.Basic).
If you are willing to implement it that way, we are happy to accept a contribution :+1:

@majk-p the default one should still be spec compliant, so we should probably make the field optional (and eventually remove it) anyway 😅

On one hand it makes sense to go step by step, making the field optional. On the other hand both of those are breaking the API and we'd like to have as few of them as possible.

I've looked into it, and it seems using generic solution described above might be an overkill. We might revisit this idea later, but I've prepared a PR fixing this specific issue in https://github.com/ocadotechnology/sttp-oauth2/pull/114

@vakhtang fix is now merged and released with v.0.11.0


user12986714: Watch money87.com

user12986714 requests the watch of the watch_keyword money87\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

money87\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


[Feature] Add check command

This feature would add a ‘ofc-bootstrap check -f init.yaml’ command which would run through a number of diagnostics and advise the user of the status of their deployment.
To start with, these items would be of most value to check:

Were secrets created?
Is OpenFaaS deployed?
Does the gateway respond?
Is the advertised DNS valid and pointing to the correct domain?
Is cert-manager available?
Is the registry credential valid?

@Waterdrips @csakshaug thoughts on this proposal?


thank you thank you :)

I was looking for such a simple library for a long time. finally there is a fast working emoji library.

Please keep improving, it would be great if you add theme dark modes and full screen features for mobile etc.


Declaration parsing fails with this mess of quotes, brackets & braces

I'm not sure if this is in scope for this project, but I was trying to parse this minified css:
.foo{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Ccircle r='3' fill='rgba(0,0,0,0)'/%3E%3C/svg%3E")}.btn{color:#FF0}.bar{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Cpath fill='%233ad599'/%3E%3C/svg%3E")}

which ought to be three selectors, .foo, .btn, and .bar.  However, css parses it as a single .foo selector with a very mangled background-image declaration:
var css = require("css");
var str = `.foo{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Ccircle r='3' fill='rgba(0,0,0,0)'/%3E%3C/svg%3E")}.btn{color:#FF0}.bar{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Cpath fill='%233ad599'/%3E%3C/svg%3E")}`;
console.log(css.stringify(css.parse(str)))
/*
.foo {
  background-image: url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Ccircle r='3' fill='rgba(0,0,0,0)'/%3E%3C/svg%3E")}.btn{color:#FF0}.bar{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Cpath fill='%233ad599'/%3E%3C/svg%3E");
}
*/

I traced the problem as far as the declaration regexp here: https://github.com/reworkcss/css/blob/434aa1733f275a67ea700311451b98a14f8cc21a/lib/parse/index.js#L227, where it's trying to use /^((?:'(?:\\'|.)*?'|"(?:\\"|.)*?"|\([^\)]*?\)|[^};])+)/ to match url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Ccircle r='3' fill='rgba(0,0,0,0)'/%3E%3C/svg%3E")}.btn{color:#FF0}.bar{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg%3E%3Cpath fill='%233ad599'/%3E%3C/svg%3E")} but I'm struggling to figure out suitable regexp magic to avoid the over-eager matching.

I'm having a similar problem, for me it's failing the parsing on "url(\"data:image/svg+xml;charset=utf-8,%3Csvg data-name='Layer 1' xmlns='http://www.w3.org/2000/svg' viewBox='0 0 202.5 202.5' stroke='%23fff'%3E%3Ctitle%3Esearch-mag-glass%3C/title%3E%3Ccircle cx='158.7' cy='247.5' r='56.7' transform='rotate(-45 -97.007 264.582)' fill='none' stroke-miterlimit='10' stroke-width='30'/%3E%3Cpath fill='none' stroke-miterlimit='10' stroke-width='30' d='M111.8 111.8l80.1 80.1'/%3E%3C/svg%3E\").
With the regex change in https://github.com/reworkcss/css/pull/110 it works.


New app: C25k

An app for helping with following the C25k programme without the need of a phone.

Looks great, thanks!


Allow user to pick from local jupyter session

When connecting to an existing jupyter session, user needs to enter the URL of the jupyter server.
We could instead pre-populate a list with the active jupyter servers.
We already have code to get the list of servers (it includes the token information as well).

Is this a must fix?


Q1 2021 DPP newsletter published

Task to do
Write and publish Q1 2021 newsletter
Reason
Inform others about progress
Result
The newsletter is published

https://osf.io/xdkcy/wiki/News letters/


OAuth2 Implicit Grant is vulnerable

https://defectdojo.readthedocs.io/en/latest/social-authentication.html#okta
In Step 4:

Check the Implicit box as well.

Implicit Grant is no longer recommended for use according to the following:
https://tools.ietf.org/html/draft-ietf-oauth-security-topics-09#section-2.1.2

The implicit grant (response type "token") and other response types
causing the authorization server to issue access tokens in the
authorization response are vulnerable to access token leakage and
access token replay as described in Section 3.1, Section 3.2,
Section 3.3, and Section 3.6.

i was able to configure Okta via OAuth2 in my company without enabling Implicit Grant and authorization into the app is working as expected so i think it's not required, despite what the documentation was saying


Fixing listAsync to properly use markers to list further files. Moved…

… s3client creation to its own factory class to aid in testing.

Merging it then.


Sometimes a double slash gets added

I can't pinpoint exactly how/when/why but I noticed sometimes the bassets have a double slash.
For example in our demo, using the CoreUIv2 theme, I get the following error:

While checking the returned content from a Inline Create modal endpoint I also found one of those:

You can test the last one in our demo in Monsters -> Relationship -> BelongsToMany + Ajax + Inline Create.
Ping me if I can help you debugging something else.

Heads-up - we have an online demo for v6 now, so we can point to specific URLs when we can prove problems in our demo. In this case it would be: https://demo-v6.backpackforlaravel.com/admin/monster/create#relationship
Howeeeever. On that page I get a completely different error now 🤦♂

I think that's a separate issue @tabacitu
I've identified it too, but I think it's related with the update to CKEditor v5, not specifically the theme or assets.

Didn't get this any more, for a while now, so I'm going to close it. If anybody gets this please provide more information and re-open.


Drag & drop - it's possible to drag a widget from below an existing one!

This is because drag&drop ignores z values, of course, and because z support is poor in general.

This exact issue is fixed.
But it's still possible to click a pushbutton hiding below another one.
And z values are still not implemented / ignored.

This exact issue is fixed.
But it's still possible to click a pushbutton hiding below another one.
And z values are still not implemented / ignored.

Fixed


Enchancement: to_raw_bytes(Variant) ->PackedByteArray: in GlobalScope

What
 to_raw_bytes(Variant) -> PackedByteArray

A new function in a GlobalScope to convert a Variant into PackedByteArray which does not include an encoding information (no type information is encoded, no possibility to de-serialize from result)
Why
There is no simple way to prepare a byte stream for push constants or for SSBO updates of the compute shaders in GDScript.  It is inconvenient, slow and error prone.
Here is a simple function that convert limited range of Variants (Array, int, float, bool, Vector2, Vector3,Vector4,Vector2i,Vector3i,Vector4i) into byte stream and returns it as PackedByteArray.
Nope, this function does not control the alignment if vec2,vec3 types, this is still responsibility of the user.
Here how it looks like:
    # Vectors are aligned to 16 bytes, so we need to pad vectors with some other 4 byte value like float, int or bool
    var array = [
        Vector3(camera_pos.x,camera_pos.y,camera_pos.z),
        float(seed),                                                    # padded for 16 byte alignment of the camera_position above
        Vector3(light_direction.x,light_direction.y,light_direction.z),
        float(scale),                                                   # padded for 16 byte alignment of the light_direction above
        [ 0, 1, true, 33.17, Vector3(0.1,0.2,0.3), false ]              # some other array values, Vector3 is padded for 16 byte alignment
                                                                            # by bool value, and before Vector3 there are 4 four-byte values
    ]

    var bytes:PackedByteArray = to_raw_bytes(array)                     # convert to raw bytes
    _rd.buffer_update(_buffer_rid, 0, bytes.size(), bytes)                # update existing SSBO

Bad
One should avoid using the result of this function with bytes_to_vars() function, because of the obvious possibility to not only get a garbage in return or impossibility to convert, but a danger of engine crash.

This warrants a proposal to discuss the specifics and the support for such a feature, make sure to fill in the form properly

This warrants a proposal to discuss the specifics and the support for such a feature, make sure to fill in the form properly
I fail to see the need for this, it can be easily worked around with the existing encode methods, and doing so gives you full freedom to control the alignment

It is as I wrote: It is not easy, inconvenient, slow and error prone.
I'll fill out the proposal now.

You didn't mention the encode methods in PackedByteArray which is what I mean here, which allows a lot of flexibility, is easy, and not error prone IMO

Thank you for contributing
Several issues, this needs to be rewritten based on this, and use more appropriate code IMO
You should probably use the encode_ methods, like encode_real, taking into account details

This is exactly what to_raw_bytes() have to avoid. See the proposal here in details: https://github.com/godotengine/godot-proposals/issues/7478
The problem with bit-wise conversion has no other solution than some trickery and workarounds in GDScript though, if any.
This is non serializable byte stream for the specific use with compute shaders params udpates.

Making this shader specific is not right, it should be general purpose if it is in @GlobalScope

You didn't mention the encode methods in PackedByteArray which is what I mean here, which allows a lot of flexibility, is easy, and not error prone IMO

I might be missing something here, care to elaborate?

Your suggested approach doesn't allow any flexibility on precision or details like that, which is a drawback, it also doesn't allow you to pass PackedInt*Array, PackedColorArray, or PackedFloat*Array, or even Color

You are correct in this regard. I didn't worked on this part yet as on the Dictionary conversion as well. I might extend it later though. However I'm not sure this proposal and the functionality will benefit someone beside me yet. So I acted early and we can decide if we go one with it or drop it completely.

Also I don't know if the example you provided is realistic, you will never send arbitrary data to a compute shader, you have to match the data format, so you can always use individual methods to do it, using the methods on the PackedByteArray, you should also know the size beforehand, so resizing the data to fit isn't really an issue either, IMO

There are a lot of scenarios to send arbitrary data to compute shaders, starting with any kind of procedural environment and ending with SFX, like rain drops or even SDF rendering.

you should also know the size beforehand, so resizing the data to fit isn't really an issue either, IMO

Yes that is the game developer task and you can't address this with the code in other way but some simplification for the cost of precision for example.

Making this shader specific is not right, it should be general purpose if it is in @GlobalScope

But there are already general purpose functions for serialization. The feature which is missing is specifically the workflow with GLSL shaders.

Let's take this to the proposal, this is for implementation specific things, and I commented before the proposal was made

Let's take this to the proposal, this is for implementation specific things, and I commented before the proposal was made

Here is the proposal, let's wait on proposal decision: https://github.com/godotengine/godot-proposals/issues/7478

I didn't read the discussion, sorry if the questions are repeated.

Why is there no inverse function? Note that it will require a Variant type parameter to decode.
For consistency with other methods, the names should be a_to_b and b_to_a.
If these methods are not going to be used often, I think it makes sense to put them in the Marshalls class instead of @GlobalScope.

Existing methods:

Return type
Signature

PackedByteArray
base64_to_raw(base64_str: String)

String
base64_to_utf8(base64_str: String)

Variant
base64_to_variant(base64_str: String, allow_objects: bool = false)

String
raw_to_base64(array: PackedByteArray)

String
utf8_to_base64(utf8_str: String)

String
variant_to_base64(variant: Variant, full_objects: bool = false)

Logical continuation:

Return type
Signature

PackedByteArray
variant_to_raw(variant: Variant, full_objects: bool = false)

Variant
raw_to_variant(array: PackedByteArray, allow_objects: bool = false)

What could be the methods:

Return type
Signature

PackedByteArray
variant_to_rawdata(variant: Variant, full_objects: bool = false)

Variant
rawdata_to_variant(array: PackedByteArray, type: Variant.Type, allow_objects: bool = false)

Note that binary serialization may encode additional data (see flags). For example, we can add information about typed arrays, see #78219.

I didn't read the discussion, sorry if the questions are repeated.
1. Why is there no inverse function? Note that it will require a `Variant` type parameter to decode.

That is the point it is not a serialization method, you can't deserealize from the result. No any metadata available in the raw byte stream.

2. For consistency with other methods, the names should be `a_to_b` and `b_to_a`.

It is impossible IMHO. Prove me wrong please.

3. If these methods are not going to be used often, I think it makes sense to put them in the `Marshalls` class instead of `@GlobalScope`.

Existing methods:
Return type 	Signature
PackedByteArray 	base64_to_raw(base64_str: String)
String 	base64_to_utf8(base64_str: String)
Variant 	base64_to_variant(base64_str: String, allow_objects: bool = false)
String 	raw_to_base64(array: PackedByteArray)
String 	utf8_to_base64(utf8_str: String)
String 	variant_to_base64(variant: Variant, full_objects: bool = false)
Logical continuation:
Return type 	Signature
PackedByteArray 	variant_to_raw(variant: Variant, full_objects: bool = false)
Variant 	raw_to_variant(array: PackedByteArray, allow_objects: bool = false)
What could be the methods:
Return type 	Signature
PackedByteArray 	variant_to_rawdata(variant: Variant, full_objects: bool = false)
Variant 	rawdata_to_variant(array: PackedByteArray, type: Variant.Type, allow_objects: bool = false)
Note that binary serialization may encode additional data (see flags). For example, we can add information about typed arrays, see #78219.

Serialization is not the scope of this function. The purpose of this function is one way conversion of GDScript Variant (limited subset of it) into uniforms of GLSL compute shaders keeping the bit-wise and semantic conversion at bay.

Serialization is not the scope of this function. The purpose of this function is one way conversion of GDScript Variant (limited subset of it) into uniforms of GLSL compute shaders keeping the bit-wise and semantic conversion at bay.

If this is such a specific task, then it should be a RenderingDevice method or some RD* class, not a global function.

Serialization is not the scope of this function. The purpose of this function is one way conversion of GDScript Variant (limited subset of it) into uniforms of GLSL compute shaders keeping the bit-wise and semantic conversion at bay.

If this is such a specific task, then it should be a RenderingDevice method or some RD* class, not a global function.

Probably. I can't decide it, I'm new to Ggodot engine. It has been mentioned in proposal. From my point of view, it will be implemented there were it should be and you will tell me where, though there is no decision on this enhancement yet.


Does this work with aframe react?

I am trying to implement this with AFrame React but not sure how to do it properly.
tried this:
<Scene antialias="true" >
    <Entity
                        bmfont-text={`text: Hello World;
                        fnt:${BASE_URL}assets/fonts/bmp/frutiger-light-45.fnt;
                        fntImage:${BASE_URL}assets/fonts/bmp/frutiger-light-45.png;
                        color:#ffffff;
                        width:50;
                        align:center;`}
                        position="50 50 50"
                        ></Entity>
</Scene>

and this with the primitive
<Scene antialias="true" >
    <a-entity
                        bmfont-text={`text: Hello World;
                        fnt:${BASE_URL}assets/fonts/bmp/frutiger-light-45.fnt;
                        fntImage:${BASE_URL}assets/fonts/bmp/frutiger-light-45.png;
                        color:#ffffff;
                        width:50;
                        align:center;`}
                        position="50 50 50"
                        ></a-entity>
</Scene>

Related issue? Maybe try asking there if that doesn't answer your question.
I don't use A-Frame React, so I can't offer much help unfortunately.

I think I was using Entity wrong.  I'll keep trying Thanks.


could not load library "libmkl_rt"

Not sure I am doing this correctly, but:
julia> ENV["JULIA_FFTW_PROVIDER"]="MKL"
"MKL"

(v1.3) pkg> build FFTW
  Building Conda → `~/.julia/packages/Conda/kLXeC/deps/build.log`
  Building FFTW ─→ `~/.julia/packages/FFTW/loJ3F/deps/build.log`
┌ Error: Error building `FFTW`:
│ ERROR: LoadError: could not load library "libmkl_rt"
│ dlopen(libmkl_rt.dylib, 1): image not found
│ Stacktrace:
│  [1] #dlopen#3(::Bool, ::typeof(Libdl.dlopen), ::String, ::UInt32) at /Applications/Julia-1.3.app/Contents/Resources/julia/lib/julia/sys.dylib:?
│  [2] dlopen at /Applications/Julia-1.3.app/Contents/Resources/julia/share/julia/stdlib/v1.3/Libdl/src/Libdl.jl:109 [inlined] (repeats 2 times)
│  [3] dlpath(::String) at /Applications/Julia-1.3.app/Contents/Resources/julia/share/julia/stdlib/v1.3/Libdl/src/Libdl.jl:232
│  [4] top-level scope at /Users/abradley/.julia/packages/FFTW/loJ3F/deps/build.jl:22
│  [5] include_relative(::Module, ::String) at /Applications/Julia-1.3.app/Contents/Resources/julia/lib/julia/sys.dylib:?
│  [6] include(::Module, ::String) at /Applications/Julia-1.3.app/Contents/Resources/julia/lib/julia/sys.dylib:?
│  [7] include(::String) at ./client.jl:424
│  [8] top-level scope at none:5
│ in expression starting at /Users/abradley/.julia/packages/FFTW/loJ3F/deps/build.jl:20
└ @ Pkg.Operations /Applications/Julia-1.3.app/Contents/Resources/julia/share/julia/stdlib/v1.3/Pkg/src/backwards_compatible_isolation.jl:649

(v1.3) pkg> st MKL FFTW
    Status `~/.julia/environments/v1.3/Project.toml`
  [7a1cc6ca] FFTW v1.1.0
  [33e6dc65] MKL v0.0.0 #master (https://github.com/JuliaComputing/MKL.jl)

julia> versioninfo()
Julia Version 1.3.0
Commit 46ce4d7933 (2019-11-26 06:09 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin19.0.0)
  CPU: Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.1 (ORCJIT, skylake)
Environment:
  JULIA_FFTW_PROVIDER = MKL

Note that FFTW doesn't use the MKL package; prior to the (as yet untagged) changes on the master branch, Conda was used to provide a download of MKL. Not sure why it doesn't seem to be working for you, but I'd be interested to know whether current master works for you. Could you try that?

master for Conda?

Seems to be fixed on master -  installs MKL_jll as advertised.

This should be exactly the error that led to the addition of IntelOpenMP to the package.

Seems to be fixed on master - installs MKL_jll as advertised.

I'm going to close the ticket


ISPN-9893 API 2.0

Ensure getAndRemoveAll present on all interfaces
Rework process methods
Modify CloseableIterable to not be Closeable itself
Ensure remove operations use WriteOperations
Make sure MutinyCache operations are all lazy

Merged