Attachment should be saved when Click on attachment file Popup Should be opened

Project Details are :
https://paste.apache.org/cpo8y
Test case is available on VDI.
Go to Accounts Recieveable from Select in Menu
Go to Sales Commission Scheme Setup from Setups in Menu
File : com/dbz/modules/AR/dbzSalesCommissionScheme.mxml
Click on New Button then Plus (+) button,Popup will be opened and then click Plus (+) Buttonn and then attachment icon,attach any files
Whole row should be highlighted when we select a row.File Name is not highlighted in Royale

and when we click on File Name the popup should be opened to save this File

In Royale when we click on Attachment File Name nothing happens

frd = new mx.net.FileReference();
frd.addEventListener(org.apache.royale.events.Event.OPEN, openHandler);
frd.save(file,name);

this functions doesn't triggered in Royale

You will have to use the DownloadButton as described in #838

@aharui ok thanks
But another issue is : when i click on row of attached file the row will be highlighted without the file name, filename should be highlighted as well as it is included in that row

I don't understand your last comment.  Maybe open a new issue about it.d

@aharui
I have replaced mx:LinkButton with
<mx:DownloadButton styleName="htmlLink" id="downloadButton"
label="{data.at_Name}"
toolTip="Save File"
click="btnDownload_clickHandler(data.at_Name,data.at_Bytes,data.at_Status)"/>

private function btnDownload_clickHandler(name:String,file:mx.utils.ByteArray,status:String):void {
	if(status!= "0") {
            downloadButton.defaultFileName = name;
	}
       else
	    Alert.show("File has been Removed.");
	}

but it doesn't download the file

Run the test app in #838 to see if that works for you.  Also read the discussion in #838.  DownloadButton requires a slightly different workflow than FileReference.save.  The information needs to be ready before the button is clicked.  You may need a popup instead.

@aharui
I have replaced
<mx:LinkButton styleName="htmlLink"  label="{data.at_Name}" toolTip="Save File"
click="btnDownload_clickHandler(data.at_Name,data.at_Bytes,data.at_Status)"/>
private function btnDownload_clickHandler(name:String,file:mx.utils.ByteArray,status:String):void {
        if(status!= "0") {
            frd = new mx.net.FileReference();
            frd.addEventListener(org.apache.royale.events.Event.OPEN, openHandler);
            frd.save(file,name);
            }
           else
	       Alert.show("File has been Removed.");
	    }

With
<mx:DownloadButton styleName="htmlLink" id="downloadButton"  label="{data.at_Name}"
 toolTip="Save File"
 click="btnDownload_clickHandler(data.at_Name,data.at_Bytes,data.at_Status)"/>

private function btnDownload_clickHandler(name:String,file:mx.utils.ByteArray,status:String):void {
	if(status!= "0") {
           downloadButton.defaultFileName = name;
           downloadButton.data = menuDataXMLList.toString()
        }
       else
	   Alert.show("File has been Removed.");
	}

```

fx:Declarations
<fx:XMLList id="menuDataXMLList">

</fx:XMLList>
</fx:Declarations>

if i remove   **downloadButton.data = menuDataXMLList.toString()** then file Name is shown
if i added  **downloadButton.data = menuDataXMLList.toString()** file Name doesn't visible,in both situation file download doesn't work.

As discussed in (https://github.com/apache/royale-asjs/issues/838) I have added

COMPILE::JS {
var saveData = (function () {
var a = document.createElement("a");
document.body.appendChild(a);
a.style = "display: none";
return function (data, fileName) {
var json = JSON.stringify(data),
blob = new Blob([json], {type: "octet/stream"}),
url = window.URL.createObjectURL(blob);
a.href = url;
a.download = fileName;
a.click();
window.URL.revokeObjectURL(url);
};
}());
var data = { x: 42, s: "hello, world", d: new Date() },
fileName = name;
saveData(data, fileName);
}

But after this there's a compilation Error
Implicit type coercion of blob from Object to etc
Access of possibly undefined URL with reference window
So i commented this part.

I am trying to fix this issue from last 2 to 3 days with multiple changes,nothing works for me,
I you have time then please write a correct code for me,or instruct me to write code

The key difference is that in Royale, the data and defaultFileName must be set before the button is clicked.  It cannot be setup in a click handler.  Look at the example in #838 more carefully.  If you don't have the data ready early enough, you may need to use a popup to give you a chance to prepare the data.

Hi Alex,
I dont know how to prepare data before click and how to create a popup.I
didn't understand the discussion in #838.
On Tue, Jun 23, 2020, 9:08 PM aharui<EMAIL_ADDRESS>wrote:

The key difference is that in Royale, the data and defaultFileName must be
set before the button is clicked. It cannot be setup in a click handler.
Look at the example in #838
https://github.com/apache/royale-asjs/issues/838 more carefully. If you
don't have the data ready early enough, you may need to use a popup to give
you a chance to prepare the data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/royale-asjs/issues/867#issuecomment-648262960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKB67E7PJHVQZ4J6BGSGIVDRYDHRRANCNFSM4N6AN2UQ
.

Which things should i use?
XMLList and json part is necessary for my attachment popup or not?
On Tue, Jun 23, 2020, 9:28 PM Pashmina Kazi<EMAIL_ADDRESS>wrote:

Hi Alex,
I dont know how to prepare data before click and how to create a popup.I
didn't understand the discussion in #838.
On Tue, Jun 23, 2020, 9:08 PM aharui<EMAIL_ADDRESS>wrote:

The key difference is that in Royale, the data and defaultFileName must
be set before the button is clicked. It cannot be setup in a click handler.
Look at the example in #838
https://github.com/apache/royale-asjs/issues/838 more carefully. If
you don't have the data ready early enough, you may need to use a popup to
give you a chance to prepare the data.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/royale-asjs/issues/867#issuecomment-648262960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKB67E7PJHVQZ4J6BGSGIVDRYDHRRANCNFSM4N6AN2UQ
.

In #838, the data was XML.  Is your data XML?  It looks like it is a regular ByteArray.  The data.at_Bytes ByteArray would be assigned to the DownloadButton.data, and the DownloadButton.defaultFileName would be assigned data.at_Name.
In Flex, the LinkButton would be created at startup, and later the user would click on it, and the data.at_Bytes could have changed between startup and the click based on other things the user did, including other code that could run when the user clicked on the LinkButton.
In Royale, the DownloadButton is created at startup and the data and defaultFileName must be set before the DownloadButton sees the click event so it is harder to deal with changes to the ByteArray based on what the user did after startup.
I don't know when your code has made the ByteArray ready, but that is the point at which it need to be assigned  to the DownloadButton's data property.  It can't be done in the DownloadButton's clickHandler

Ok,If I will create a separate function for preparing data before calling click handler
Example In that function I will do
private function PreparingData(name:String,file:mx.utils.ByteArray,status:String):void {
DownloadButton.data = data.at_Bytes;
DownloadButton.defaultFileName = data.at_Name;
}
where i call PreparingData function? and then when i am doing everything in that function,what should i do in ClickHandler function?

mx:DownloadButton and clickhandler function is inside these tags
mx:itemRenderer
fx:Component
<s:MXAdvancedDataGridItemRenderer height="22" >
fx:Script

As in the example in #838, you should no longer need a click handler.
I don't know when your application should set the DownloadButton.data.  It all depends on when you know what that data is.


Fix diff skipping lines

ParsePatch previously just skipped all lines that start with "+++ " or "--- "
and makes no attempt to see these lines in context.
This PR rewrites ParsePatch to pay attention to context and position
within a patch, ensuring that --- and +++ are only skipped if
appropriate.
This PR also fixes several issues with incomplete files.
Fix https://codeberg.org/Codeberg/Community/issues/308
Fix #13153
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Oh sorry I've spent so much time making the current tests pass I forgot to add the real one

Done

Codecov Report

Merging #13154 into master will increase coverage by 0.00%.
The diff coverage is 63.18%.

@@           Coverage Diff           @@
##           master   #13154   +/-   ##
=======================================
  Coverage   41.94%   41.94%
=======================================
  Files         681      681
  Lines       75121    75171   +50
=======================================
+ Hits        31506    31532   +26
- Misses      38481    38497   +16
- Partials     5134     5142    +8

Impacted Files
Coverage Δ

services/gitdiff/gitdiff.go
68.25% <63.18%> (-6.64%)
:arrow_down:

modules/log/log.go
58.08% <0.00%> (-2.95%)
:arrow_down:

services/pull/pull.go
40.29% <0.00%> (ø)

models/error.go
34.39% <0.00%> (+0.50%)
:arrow_up:

modules/git/repo.go
46.70% <0.00%> (+0.50%)
:arrow_up:

modules/log/event.go
61.79% <0.00%> (+0.94%)
:arrow_up:

models/issue_comment.go
45.71% <0.00%> (+1.95%)
:arrow_up:

services/pull/check.go
51.09% <0.00%> (+2.18%)
:arrow_up:

modules/process/manager.go
75.00% <0.00%> (+2.50%)
:arrow_up:

modules/git/utils.go
77.04% <0.00%> (+3.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb0333...4425616. Read the comment docs.

How about to use the package https://github.com/bluekeyes/go-gitdiff ?

That's not a backportable change and would require lots of other changes.
This isn't the last change I'm going to make to diff though and it's possible that that library could form part of it.


FLPATH-237: notification-service: add User or Group validation to NotificationMessage creation

What this PR does / why we need it:
When NotificationMessage is created, user must be assigned to it, this can be done by indicating
GroupName (all users under this group are assigned to the Notification)
Therefore, create API must include validation that there are users or groups added to the request
There is still open issue when creating NotificationMessage with GroupName
Opened another jira ticket for this (FLPATH-353)
Which issue(s) this PR fixes:
Fixes #FLPATH-237
Change type

[ ] New feature
[x] Bug fix
[x] Unit tests
[x] Integration tests
[ ] CI
[ ] Documentation
[ ] Auto generated SDK code

Impacted services

[ ] Workflow Service
[x] Notifivcation Service

Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.

/lgtm

/lgtm

/lgtm

/lgtm

/lgtm


NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Please include some context and the contents of the console in your browser's developer tools.
JavaScript Error
Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
    at yl (http://<IP_ADDRESS>:8000/dashboard:215:141677)
    at Xp (http://<IP_ADDRESS>:8000/dashboard:215:251692)
    at Kp (http://<IP_ADDRESS>:8000/dashboard:215:252053)
    at gh (http://<IP_ADDRESS>:8000/dashboard:215:267658)
    at HTMLUnknownElement.E (http://<IP_ADDRESS>:8000/dashboard:215:103604)
    at Object.Hn (http://<IP_ADDRESS>:8000/dashboard:215:103929)
    at qn (http://<IP_ADDRESS>:8000/dashboard:215:104890)
    at mh (http://<IP_ADDRESS>:8000/dashboard:215:265299)
    at t.unstable_runWithPriority (http://<IP_ADDRESS>:8000/dashboard:215:38289)
    at Ws (http://<IP_ADDRESS>:8000/dashboard:215:148107)

Reproduction Steps
Please tell us what you were doing when this error occurred, so we can more easily debug it and find a solution.

…

User Agent
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36

Hi @tambou-bryan, can you confirm you're on the latest version of spatie/laravel-ignition? You can run composer update spatie/laravel-ignition -W to make sure that you are.


Add a Dockerfile

I don't know if it's possible to run stringer in docker. If so, I suggest add a Dockerfile.

Relates to #378

I'm closing this issue because it was solved in this commit.


Add new check to warn about incorrect usage of audit_access permission

The audit_access permissions for the common file class has only an
affect in dontaudit rules (and to an extend in neverallow rules).
Warn about occurrences in allow and auditallow rules.
Refpolicy findings (due to usage in unconfined access):
kernel.te:          551: (W): Allow rule with audit_access permission (W-013)
kernel.te:          552: (W): Allow rule with audit_access permission (W-013)
kernel.te:          553: (W): Allow rule with audit_access permission (W-013)
kernel.te:          555: (W): Allow rule with audit_access permission (W-013)
kernel.te:          556: (W): Allow rule with audit_access permission (W-013)
kernel.te:          560: (W): Allow rule with audit_access permission (W-013)
kernel.te:          561: (W): Allow rule with audit_access permission (W-013)
kernel.te:          562: (W): Allow rule with audit_access permission (W-013)
kernel.te:          563: (W): Allow rule with audit_access permission (W-013)
kernel.te:          564: (W): Allow rule with audit_access permission (W-013)
kernel.te:          565: (W): Allow rule with audit_access permission (W-013)
kernel.te:          566: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      341: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      342: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      343: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      344: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      345: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      346: (W): Allow rule with audit_access permission (W-013)
filesystem.te:      347: (W): Allow rule with audit_access permission (W-013)
storage.te:          62: (W): Allow rule with audit_access permission (W-013)
storage.te:          63: (W): Allow rule with audit_access permission (W-013)
devices.te:         437: (W): Allow rule with audit_access permission (W-013)
devices.te:         438: (W): Allow rule with audit_access permission (W-013)
devices.te:         439: (W): Allow rule with audit_access permission (W-013)
files.te:           230: (W): Allow rule with audit_access permission (W-013)
files.te:           231: (W): Allow rule with audit_access permission (W-013)
files.te:           232: (W): Allow rule with audit_access permission (W-013)
files.te:           233: (W): Allow rule with audit_access permission (W-013)
files.te:           234: (W): Allow rule with audit_access permission (W-013)
files.te:           235: (W): Allow rule with audit_access permission (W-013)
files.te:           236: (W): Allow rule with audit_access permission (W-013)
Found the following issue counts:
W-013: 31

Calling this a "warning" seems questionable to me, since:

Every finding in current refpolicy seems incredibly innocuous.
Allowing access here is a noop.

The question is what to call it.  I do see the positive case for warning (broadly, "you presumably wrote this intending to do something, but it does nothing" sounds like a "warning".  It's just that the existing examples in refpolicy seem to me to make a positive case for inclusion of audit_access, and it's hard to call something that seems legitimate a "warning".
I think a question that could be helpful is: If we take this check, how would we modify refpolicy for passing?  These commands could be changed to use "*", we could add a disable comment, we could drop audit_access, or we could disable the check entirely.  I think dropping audit_access actually seems undesirable in this instance, since having an "unconfined" that's missing permissions is something that someone might look at and think is wrong.  Better to just avoid the question, since it's a noop.
"*" seems preferable to me so that any future permissions are included, since these are unconfined.  Although the lack of * now may indicate a desire by Chris to keep these lists explicit, in case some problematic new permission he didn't want to allow was added to the kernel.
Both disables are of course workable solutions, although creating a check just to disable it in refpolicy seems like a case that the check shouldn't be a "warning".
I think I'm talking myself into wanting to call this "style" rather than warning.  I'm very open to other suggestions, pushback, and thoughts about the "how to address the check in refpolicy" angle.

Initially I choose severity warning cause it's not so much about a question of style (how do I handle access(2) requests (allow, dontaudit, dontaudit with audit_access)), but more about a statement, which is from the access decision side is a noop, but probably might not be indented that way and might do the wrong thing (maybe the author wanted to allow the access(2) request, maybe he wanted to dontaudit it).
My way of handling the findings in Refpolicy would be to drop the permissions from the rules, since that would not change the behavior of the policy. Using the wildcard * permissions would add some permissions (watch_mount, watch_sb, watch_with_perm, watch_reads and sometimes map) and clash with check W-008. An alternative might be to introduce unconfined_*_perms, so added permissions in the future by the kernel need to be added only in one place.
@pebenito what is your opinion on the current usage of audit_access in allow rules, e.g. https://github.com/SELinuxProject/refpolicy/blob/abb3474508a94b7b704ac8cfcd88d0e4971d135d/policy/modules/kernel/kernel.te#L551, and the "severity" of them being a noop?

Since the only misuse of the perm is in the unconfined rules, I'd prefer to drop the permission. It seems like the default for selint should notify the user but be nonfatal. For refpolicy I would want it to be fatal.

SELinuxProject/refpolicy#543

Okay, I'm okay with calling this a warning.  Will merge.  Thanks!


[ubuntu 20.04] Error: AppArmor profile "container-default" specified but not loaded

/kind bug
Description
$ sudo podman run -it hello-world
Error: AppArmor profile "container-default" specified but not loaded

Steps to reproduce the issue:

Clean install of Ubuntu Desktop 20.04 on VirtualBox, minimal installation

Install podman 2.0 via the Kubic project packages

Run sudo podman run -it hello-world

Output of podman version:
Version:      2.0.0
API Version:  1
Go Version:   go1.13.8
Built:        Thu Jan  1 01:00:00 1970
OS/Arch:      linux/amd64

Output of podman info --debug:
host:
  arch: amd64
  buildahVersion: 1.15.0
  cgroupVersion: v1
  conmon:
    package: 'conmon: /usr/libexec/podman/conmon'
    path: /usr/libexec/podman/conmon
    version: 'conmon version 2.0.18, commit: '
  cpus: 4
  distribution:
    distribution: ubuntu
    version: "20.04"
  eventLogger: file
  hostname: shai-VirtualBox
  idMappings:
    gidmap: null
    uidmap: null
  kernel: 5.4.0-37-generic
  linkmode: dynamic
  memFree:<PHONE_NUMBER>
  memTotal:<PHONE_NUMBER>
  ociRuntime:
    name: runc
    package: 'runc: /usr/sbin/runc'
    path: /usr/sbin/runc
    version: 'runc version spec: 1.0.1-dev'
  os: linux
  remoteSocket:
    path: /run/podman/podman.sock
  rootless: false
  slirp4netns:
    executable: ""
    package: ""
    version: ""
  swapFree: 968105984
  swapTotal: 968105984
  uptime: 9m 35.21s
registries:
  search:
  - docker.io
  - quay.io
store:
  configFile: /etc/containers/storage.conf
  containerStore:
    number: 1
    paused: 0
    running: 0
    stopped: 1
  graphDriverName: overlay
  graphOptions: {}
  graphRoot: /var/lib/containers/storage
  graphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageStore:
    number: 1
  runRoot: /var/run/containers/storage
  volumePath: /var/lib/containers/storage/volumes
version:
  APIVersion: 1
  Built: 0
  BuiltTime: Thu Jan  1 01:00:00 1970
  GitCommit: ""
  GoVersion: go1.13.8
  OsArch: linux/amd64
  Version: 2.0.0

Package info (e.g. output of rpm -q podman or apt list podman):
podman/unknown,now 2.0.0~1 amd64 [installed]

Additional environment details (AWS, VirtualBox, physical, etc.):
Reproduced on a fresh Ubuntu 20.04 VirtualBox machine and a physical machine as well

@saschagrunert PTAL
My knowledge of AppArmor is very limited, Prefer SELinux :^)

It looks like the default profile name has changed by switching to github.com/containers/common/pkg/apparmor, I’ll dig into it.

I hoped we would have regressed on that in the CI. @lsm5 could it be the containers.conf in the Ubuntu packages?

So it looks like we stopped suffixing the version (was container-default-1.9.3, now just container-default). Was this change intended?

Thanks for tracking it down @saschagrunert!
I agree with readding the suffix. This will allow for installing a new (potentially updated) profile after an update while keeping the lazy loads.

Alright I think we have a mismatch in the usage of containers/common:

The default profile is set by the default config (which is containers-default)
The logic in containers/common which prevents the default profile to be loaded is there: https://github.com/containers/common/blob/e505f9348f51b6af02ab6be5c12d768feaea1b41/pkg/apparmor/apparmor_linux.go#L258-L269
This means that the profile either has to be empty or prefixed by apparmor_profile to be treated as a default profile.

A possible fix would be now to change or add another valid profile prefix which is containers-default-. WDYT?

@cevich are we testing on the Ubuntu VMs with AppArmor? This regression worries me a bit.

So 2 fixes:
* readd the version suffix in libpod

* allow `containers-default` as default profile prefix in containers/common

I think we need to resolve that in containers/common only. We shouldn't embed libpod in the name any more, such that multiple consumers share the same default profile.
Before we regressed (see https://github.com/containers/libpod/blob/v1.6/pkg/apparmor/apparmor.go#L10) we used the version package in libpod to embed the version into the profile name.
I suggest doing the same in containers/common (as we do in c/image already) and introduce containers/common/version. After that, we can do:
	// DefaultProfilePrefix is used for version-independent presence checks.
	DefaultProfilePrefix = "libpod-default" + "-"
	// DefaultProfile is the name of default AppArmor profile.
	DefaultProfile = DefaultProfilePrefix + version.Version

Please open a PR into containers/common and then we can roll this forward.

Please open a PR into containers/common and then we can roll this forward.

Yep, that’s the one: https://github.com/containers/common/pull/185

Hey, @mheon can we mention in the release notes that this has been fixed, too? Right now it’s implicitly hidden in the containers/common bump.

Sure


Add new with extra roots on other platforms

Add support of extra roots for the moment on macos and ios. I plan to add windows and android but I believe this is already ready for initial feedback.
The work is mostly based on @complexspaces branch https://github.com/rustls/rustls-platform-verifier/tree/shared/extra-roots-additions.
I've changed the signature of new_with_extra_roots (breaking) to be uniform on all platforms.

As a Git nit, would you mind adding me as a Co-authored-by: to 1bb8c1c0551bea10af23400029e9d0f4dfd14178 since its based off my original branch?

I plan to add windows and android

I planned on working on overhauling the Android verifier this week since it has a lot of outstanding problems as-is, including not supporting this pattern very cleanly. Maybe we could split the Windows and Android work?

Maybe we could split the Windows and Android work?

That sounds like a good idea to me :+1:

As a Git nit, would you mind adding me as a Co-authored-by: to 1bb8c1c since its based off my original branch?

Sure ! For what it's worth, I've already done it but it seems the change has been reverted, most likely because of a rebase

I planned on working on overhauling the Android verifier this week since it has a lot of outstanding problems as-is, including not supporting this pattern very cleanly. Maybe we could split the Windows and Android work?

All right, I will look into the windows implementation then. Maybe I will just do a rebase over https://github.com/rustls/rustls-platform-verifier/pull/131 to start cleanly.

I've rebased on top of https://github.com/rustls/rustls-platform-verifier/pull/131 and tried to implement the new_with_extra_roots for Windows, thanks to the guidance of @complexspaces

We can create a custom CERT_CHAIN_ENGINE_CONFIG and set cAdditionalStore to a custom, in-memory certificate store. This engine and store are then included in our call to CertGetCertificateChain.

Sadly, it keeps considering the custom CA as untrusted. I've tried to tweak the flags and various parameters, and add debug traces but without success. Anyone has any idea or how we can solve this ?
On GitHub there are very few usages of rghAdditionalStore/cAdditionalStore, most of them seems to use the same parameters as me. For instance here and here

I've rebased on top of https://github.com/rustls/rustls-platform-verifier/pull/131 and tried to implement the new_with_extra_roots for Windows

I think it would be better to land the MacOS code and handle Windows as a follow-up, especially if there are implementation issues to sort out. The MacOS code seemed ready mod review comments. WDYT?

Yes sure, I will split the Windows work on an other PR


[Question]: kg index embeddings insertion

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
Hello, I am wondering how can I can use embeddings for querying with this kg index in my script, I have used the include_embeddings=True and embedding_mode="hybrid" and then storing mt created index in a persistent storage. However, when I try to check if the embeddings are created and are present in my index, I run into problems, additionally, within my docstore in my persistent storage I can see the embeddings field being null, making me even more confused about if the embeddings are even being generated. Can anyone help me here?
from nebula3.gclient.net import ConnectionPool
from nebula3.Config import Config
from llama_index.core import (
    VectorStoreIndex,
    SimpleDirectoryReader,
    KnowledgeGraphIndex,
    Settings,
    StorageContext,
    PromptTemplate,
    load_index_from_storage
)
from llama_index.core import Document
from llama_index.embeddings.openai import OpenAIEmbedding
from llama_index.llms.openai import OpenAI
from llama_index.graph_stores.nebula import NebulaGraphStore
from llama_index.core.query_engine import KnowledgeGraphQueryEngine
from llama_index.core.retrievers import KnowledgeGraphRAGRetriever
from typing import List
from llama_index.core.schema import NodeWithScore, QueryBundle
import os
import json
import base64
import subprocess

# Configure OpenAI settings
Settings.llm = OpenAI(temperature=0, model="gpt-3.5-turbo")
embed_model = OpenAIEmbedding(model="text-embedding-3-large")
Settings.embed_model = embed_model
Settings.chunk_size = 512

# Environment variables for NebulaGraph connection
os.environ["NEBULA_USER"] = "root"
os.environ["NEBULA_PASSWORD"] = "nebula"
os.environ["NEBULA_ADDRESS"] = "<IP_ADDRESS>:9669"

# NebulaGraph store configuration
space_name = "embtest"
edge_types, rel_prop_names = ["relationship"], ["relationship"]
tags = ["entity"]

graph_store = NebulaGraphStore(
    space_name=space_name,
    edge_types=edge_types,
    rel_prop_names=rel_prop_names,
    tags=tags
)

storage_context = StorageContext.from_defaults(graph_store=graph_store)

# Load documents
documents = SimpleDirectoryReader("./data/paul_graham").load_data()

# Convert document text to lowercase
for doc in documents:
    doc.text = doc.text.lower()

# Generate embeddings and create KnowledgeGraphIndex
print("Generating embeddings and creating KnowledgeGraphIndex...")
kg_index = KnowledgeGraphIndex.from_documents(
    documents,
    storage_context=storage_context,
    max_triplets_per_chunk=10,
    space_name=space_name,
    edge_types=edge_types,
    rel_prop_names=rel_prop_names,
    tags=tags,
    max_knowledge_sequence=15,
    include_embeddings=True,
)

# Debug: Print out embeddings during the indexing process
for doc in documents:
    embedding = embed_model.embed(doc.text)
    print(f"Document ID: {doc.id}")
    print(f"Embedding: {embedding[:20]}")  # Print first 20 elements of the embedding

# Persist the KnowledgeGraphIndex
kg_index.storage_context.persist(persist_dir='./storage_graph2')
print("KnowledgeGraphIndex created and persisted.")

# Load the persisted KnowledgeGraphIndex
print("Loading KnowledgeGraphIndex from persistent storage...")
kg_index = load_index_from_storage(storage_context=storage_context, persist_dir='./storage_graph2')

# Print out embeddings from the loaded index
print("Printing embeddings from the loaded index:")
nodes = kg_index.graph_store.get_nodes()
for node in nodes:
    if hasattr(node, 'embedding'):
        embedding = node.embedding
        print(f"Node ID: {node.id}")
        print(f"Embedding: {embedding[:20]}")  # Print first 20 elements of the embedding

print("Loaded KnowledgeGraphIndex and printed embeddings.")

# Set up query engine using the as_query_engine method
query_engine = kg_index.as_query_engine(
    include_text=True,
    response_mode="tree_summarize",
    embedding_mode="hybrid",
    similarity_top_k=5,
)

# Execute a sample query
response = query_engine.query("What is Hacker news")
print(response)

The embeddings are in the index store

They won't be directly attached to the documents.


Documentation: Club Membership Registration

Add to the Github the Club Membership Registration process with detailed step by step instructions.
Motivation and benefits of becoming a member of the 3C: easier access to support for any needs the students see as an opportunity to grow professionally. E.g. going to a conference or workshop, doing an international publication, requesting access to equipment, putting forward a recommendation to ordering new equipment that is seen as the type of technology that will benefit the student skill set.

Please find the Documentation to Register to Cloud Computing Club and to add new members to your organization roster
https://github.com/3C-SCSU/Avatar/wiki/Cloud-Computing-Club:-Registration-Process
Please review and provide your feedback.


Yoduoy version update 2017 oct02

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Common-Errors.md
:white_check_mark:Succeeded

Skype/Skype-For-Business-Bot-Framework/docs/Bot-Hybrid-Support.md
:white_check_mark:Succeeded

Skype/UCWA/samples/CHANGELOG.TXT
:white_check_mark:Succeeded

Skype/UCWA/samples/Index.html
:white_check_mark:Succeeded

Skype/UCWA/samples/License Terms.rtf
:white_check_mark:Succeeded

Skype/UCWA/samples/README.txt
:white_check_mark:Succeeded

Skype/UCWA/samples/Styles.css
:white_check_mark:Succeeded

Skype/UCWA/samples/content-template.html
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ajax-loader.gif
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_flat_0_aaaaaa_40x100.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_flat_75_ffffff_40x100.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_glass_55_fbf9ee_1x400.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_glass_65_ffffff_1x400.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_glass_75_dadada_1x400.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_glass_75_e6e6e6_1x400.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_glass_95_fef1ec_1x400.png
:white_check_mark:Succeeded

Skype/UCWA/samples/images/ui-bg_highlight-soft_75_cccccc_1x100.png
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/AnonMeeting.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Authentication.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/AutoDiscovery.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Batch.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Cache.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/CallViaWork.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/ContactSearch.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Contacts.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Events.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/IM.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/MeDashboard.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Meeting.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Mime.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/OperationResource.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/PresenceSub.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/html/Transport.html
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/AdHocSubscription.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/AnonMeeting.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/AuthenticationAddUsage.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/AuthenticationUsage.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/AutoDiscoveryUsage.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/BatchUsage.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/CacheUsage.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/CallViaWork.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/ContactSearch.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/DeleteAdHocSubscription.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/DeleteGroupSubscription.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/EventsUsage.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/ExtendAdHocSubscription.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/ExtendGroupSubscription.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/GetContacts.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/GetNote.js
:white_check_mark:Succeeded

Skype/UCWA/samples/samples/javascript/GetPhoto.js
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


src/zfile.c: Use off_t instead of off64_t

First discovered in while building on musl 1. This is because musl-1.2.4 (9999 right now) will remove/removes the LFS compatibility hacks, like fopen64:

https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4
https://git.musl-libc.org/cgit/musl/commit/?id=25e6fee27f4a293728dd15b659170e7b9c7db9bc

The gist is that bad configure tests (suffering from -Wimplicit-function-declaration) would build and link successfully because musl provided these symbols as aliases, despite not needing them (musl natively supports both LFS & time64).
To head this off, these aliases are now gone, but remain in libc.so for binary compatibility.
The proper fix is to just use the regular functions and not anything _LARGEFILE64_SOURCE As a temporary workaround you can typedef off_t to off64_t 2 to get it working.
Signed-off-by: Brahmajit Das<EMAIL_ADDRESS>

@ggreer any plans on fixing this?


Building GWT throws Errors in usages of some methods

In: de/tomgrill/gdxfacebook/core/GDXFacebookMultiPartRequest.java
[ERROR] Line 51: No source code is available for type java.io.FileInputStream; did you forget to inherit a required module?
[ERROR] Line 117: The method file() is undefined for the type FileHandle
[ERROR] Line 139: The method file() is undefined for the type FileHandle
Java.io is not supported by GWT, so maybe use @GwtIncompatible annotation for the loadFile method.
The second and third lines are using com.badlogic.gdx.files package - so need to get those to GWT.
In: de/tomgrill/gdxfacebook/core/utils/Utils.java
[ERROR] Line 46: No source code is available for type java.net.URL; did you forget to inherit a required module?
[ERROR] Line 72: No source code is available for type java.net.MalformedURLException; did you forget to inherit a required module?
[ERROR] Line 81: No source code is available for type java.net.URLDecoder; did you forget to inherit a required module?
URLDecoder is weird, cause I'm using URLEncoder in another part of my game, and it compiles in GWT perfectly,

fixed with 1.2.2


Link update

Link is not pointing to the appropriate information.
Problem: https://github.com/MicrosoftDocs/OfficeDocs-Enterprise/issues/648

This isn't fixed. If all you did is update the link, then it's still pointing to an irrelevant page. I just checked, and https://github.com/MicrosoftDocs/OfficeDocs-Enterprise/blob/live/Enterprise/office-365-data-retention-deletion-and-destruction-overview.md says "For more information on expedited de-provisioning, see Cancel Office 365," linking to https://docs.microsoft.com/en-us/office365/admin/subscriptions-and-billing/cancel-your-subscription?view=o365-worldwide, which still says nothing about expedited de-provisioning.
I'll say it again: You can't write "For more info on X see Y" when Y doesn't contain any info about X.


Could you please share the code using GPT4 and prompt to generate visual instructions ?

Thanks for your brilliant work!
I want to follow your way to generate more data, but I don't know how to write the code ,even if I have openai api. Could you please share the code?

You can refer to the coder here.


Complete removal of installed tool

Im getting an update error for Novoalign which I see a few people are currently having (https://groups.google.com/forum/#!msg/biovalidation/ss3wTUCbUWM/mYMRmrvVEwAJ).
ERROR conda.core.link:_execute(502): An error occurred while installing package 'bioconda::novoalign-3.09.00-h7311fa2_1'.
LinkError: post-link script failed for package bioconda::novoalign-3.09.00-h7311fa2_1
running your command again with `-v` will provide additional information
location of failed script: /apps/bioinfo/share/bcbio/anaconda/bin/.novoalign-post-link.sh
==> script messages <==

========================= Novoalign information ===========================================
Novoalign is installed. Documentation installed in
/apps/bioinfo/share/bcbio/anaconda/share/doc/novoalign

Commercial use requires a license; contact<EMAIL_ADDRESS>License also adds multi-threading and other features.
Once you have a license file, run novoalign-license-register to install it.

Licensing information from Novocraft website:
--------------------------------------------------------------------------------------------

However im not actually using the tool at all so I'm keen on removing it from the installation. I've tried removing the package through conda and deleting installation directories, however whenever I go to update novoalign just re-installs. Whats the easiest way to completely remove a tool from bcbio?
PS: Apologies if this is detailed in the docs, I just can't see it

Jimmy;
Apologies about the issues with the novoalign install and thanks for the discussion. We don't have a way to exclude tools from the install like this. In general, our goals with bcbio are to create a stable distribution that doesn't require a lot of configuration to apply and maintain, so we'd rather approach this by trying to figure out what is wrong with the install so we can fix it for everyone. I haven't been able to reproduce this so have been struggling to fix, would you be able to report the output of:
bcbio_conda install --yes -c conda-forge -c bioconda novoalign -v

Does that provide any clue as to what is failing? Thanks much for the help debugging.

Thanks Brad. Here is the output:
bcbio_conda install --yes -c conda-forge -c bioconda novoalign -v
Solving environment: ...working...
done

## Package Plan ##

  environment location: /data/biohub/local/share/bcbio/anaconda

  added / updated specs:
    - novoalign

The following NEW packages will be INSTALLED:

    novoalign: 3.09.00-h7311fa2_1 bioconda

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... ===> LINKING PACKAGE: bioconda::novoalign-3.09.00-h7311fa2_1 <===
  prefix=/data/biohub/local/share/bcbio/anaconda
  source=/data/biohub/local/share/bcbio/anaconda/pkgs/novoalign-3.09.00-h7311fa2_1

$ bash -x /data/biohub/local/share/bcbio/anaconda/bin/.novoalign-post-link.sh
==> cwd: /data/biohub/local/share/bcbio/anaconda/bin <==
==> exit code: 48 <==
==> stdout <==

==> stderr <==
+ LMOD_PKG=/usr/share/lmod/lmod
+ LMOD_DIR=/usr/share/lmod/lmod/libexec
+ LMOD_CMD=/usr/share/lmod/lmod/libexec/lmod
+ MODULESHOME=/usr/share/lmod/lmod
+ export LMOD_PKG
+ export LMOD_CMD
+ export LMOD_DIR
+ export MODULESHOME
+ LMOD_VERSION=6.3.4
+ export LMOD_VERSION
+ '[' : '!=' : ']'
+ unalias ml
+ true
++ echo YES
++ /usr/bin/tr '[:upper:]' '[:lower:]'
+ export_module=yes
+ '[' -n '4.2.46(1)-release' -a yes '!=' no ']'
+ export -f module
+ export -f ml
+ unset export_module
+ '[' -n '' ']'
+ '[' 4 -ge 3 ']'
+ '[' -r /usr/share/lmod/lmod/init/lmod_bash_completions ']'
+ '[' -n '' ']'
+ set -e -o pipefail
+ MSGS=/data/biohub/local/share/bcbio/anaconda/.messages.txt
+ touch /data/biohub/local/share/bcbio/anaconda/.messages.txt
+ msg
+ echo
+ msg '========================= Novoalign information ==========================================='
+ echo ========================= Novoalign information ===========================================
+ msg 'Novoalign is installed.  Documentation installed in'
+ echo Novoalign is installed. Documentation installed in
+ msg /data/biohub/local/share/bcbio/anaconda/share/doc/novoalign
+ echo /data/biohub/local/share/bcbio/anaconda/share/doc/novoalign
+ msg
+ echo
+ msg 'Commercial use requires a license; contact<EMAIL_ADDRESS>+ echo Commercial use requires a 'license;' contact<EMAIL_ADDRESS>+ msg 'License also adds multi-threading and other features.'
+ echo License also adds multi-threading and other features.
+ msg 'Once you have a license file, run novoalign-license-register to install it.'
+ echo Once you have a license file, run novoalign-license-register to install it.
+ msg
+ echo
+ msg 'Licensing information from Novocraft website:'
+ echo Licensing information from Novocraft website:
+ msg --------------------------------------------------------------------------------------------
+ echo --------------------------------------------------------------------------------------------
+ curl --silent -L http://www.novocraft.com/bioconda/license.txt

========================= Novoalign information ===========================================
Novoalign is installed. Documentation installed in
/data/biohub/local/share/bcbio/anaconda/share/doc/novoalign

Commercial use requires a license; contact<EMAIL_ADDRESS>License also adds multi-threading and other features.
Once you have a license file, run novoalign-license-register to install it.

Licensing information from Novocraft website:
--------------------------------------------------------------------------------------------

===> REVERSING PACKAGE LINK: bioconda::novoalign-3.09.00-h7311fa2_1 <===
  prefix=/data/biohub/local/share/bcbio/anaconda

failed
An error occurred while installing package 'bioconda::novoalign-3.09.00-h7311fa2_1'.
LinkError: post-link script failed for package bioconda::novoalign-3.09.00-h7311fa2_1
running your command again with `-v` will provide additional information
location of failed script: /data/biohub/local/share/bcbio/anaconda/bin/.novoalign-post-link.sh
==> script messages <==

========================= Novoalign information ===========================================
Novoalign is installed. Documentation installed in
/data/biohub/local/share/bcbio/anaconda/share/doc/novoalign

Commercial use requires a license; contact<EMAIL_ADDRESS>License also adds multi-threading and other features.
Once you have a license file, run novoalign-license-register to install it.

Licensing information from Novocraft website:
--------------------------------------------------------------------------------------------

Attempting to roll back.

Rolling back transaction: ...working... done
Traceback (most recent call last):
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/exceptions.py", line 819, in __call__
    return func(*args, **kwargs)
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/cli/main.py", line 78, in _main
    exit_code = do_call(args, p)
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/cli/conda_argparse.py", line 77, in do_call
    exit_code = getattr(module, func_name)(args, parser)
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/cli/main_install.py", line 11, in execute
    install(args, parser, 'install')
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/cli/install.py", line 253, in install
    handle_txn(unlink_link_transaction, prefix, args, newenv)
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/cli/install.py", line 282, in handle_txn
    unlink_link_transaction.execute()
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/core/link.py", line 228, in execute
    self._execute(tuple(concat(interleave(itervalues(self.prefix_action_groups)))))
  File "/data/biohub/local/share/bcbio/anaconda/lib/python2.7/site-packages/conda/core/link.py", line 521, in _execute
    rollback_excs,
CondaMultiError: post-link script failed for package bioconda::novoalign-3.09.00-h7311fa2_1
running your command again with `-v` will provide additional information
location of failed script: /data/biohub/local/share/bcbio/anaconda/bin/.novoalign-post-link.sh
==> script messages <==

========================= Novoalign information ===========================================
Novoalign is installed. Documentation installed in
/data/biohub/local/share/bcbio/anaconda/share/doc/novoalign

Commercial use requires a license; contact<EMAIL_ADDRESS>License also adds multi-threading and other features.
Once you have a license file, run novoalign-license-register to install it.

Licensing information from Novocraft website:
--------------------------------------------------------------------------------------------

Looks like something from the license link. I can access that file ok. Perhaps the registration of the license?
Thanks for your help!

Jimmy -- thanks much for the detailed output. I agree with your assessment, something is going wrong with the call to the novoalign website, maybe it is intermittently failing. I pushed an updated package which I hope fixes the install issue by not failing on this registration. Could you try running the bcbio update again and see if that resolves the issue? Thanks again for all the help debugging.

Running now and it looks like its updated everything fine. Thanks again for your help !


Pip install not working for sensirion_i2c_lps22

Command:
'pip install sensirion_i2c_lps22
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
ERROR: Could not find a version that satisfies the requirement sensirion_i2c_lps22 (from versions: none)
ERROR: No matching distribution found for sensirion_i2c_lps22'
installing on RPI5 as per https://sensirion.github.io/python-i2c-lps22/installation.html

Sorry, I should have added it - I'm able to manually download from GitHub and install directly with 'pip install .'

Hello @mishave
Sorry about that, it seems we never actually published it to PyPi :(
We will that as soon as we have a moment
Thanks for reporting it
Quentin

Library is now deployed to pypi
https://pypi.org/project/sensirion-i2c-lps22/


Convert CDM file format

https://foxrefire.github.io/pssh-box-wasm/convert/

OK, thanks. It's a shame picocss doesn't have tabs; this would look better with tabs IMO.
I'll also add some documentation to help people understand what this does.


Cannot connect to codespace

Hey @kompasbank-brian, do you have any additional information about what you were doing when this failed? Is it working now?

Hi..
No unfortunately it does not work.. :(
I am on a Macbook Pro M1.
I am trying to start a codespace using Intellij Idea With Jetbrains
Gateway...
I can connect and see my workspaces in the gateway... I can click it and
attempt to start it.. but....
[image: Screenshot 2023-02-15 at 09.17.12.png]
[image: Screenshot 2023-02-15 at 09.17.19.png]
[image: Screenshot 2023-02-15 at 09.20.49.png]
Med venlig hilsen/ Kind regards
Brian Bjørnskou Petersen
Senior Software Developer | kompasbank.dk | LinkedIn
https://linkedin.com/company/kompasbank/about/
+45 26798048
On Tue, 14 Feb 2023 at 21:25, Thomas Sickert @.***>
wrote:

Hey @kompasbank-brian https://github.com/kompasbank-brian, do you have
any additional information about what you were doing when this failed? Is
it working now?
—
Reply to this email directly, view it on GitHub
https://github.com/github/codespaces-jetbrains-feedback/issues/82#issuecomment-1430329234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A23IIFF3Y2EJEX47UJZD3U3WXPS2PANCNFSM6AAAAAAUXRCRLE
.
You are receiving this because you were mentioned.Message ID:
@.***>


DCOS-44676: fix status bar tooltip

Ensure status bar tooltip shows correct pluralized message from translation catalog instead of bare id.
Closes DCOS-46676.
Testing

Create production build with npm run build-assets
Serve with npx http-server -p 4200 --proxy-secure=false -P https://frontend-ElasticL-15A1BH9DJMPZ6-380004668.us-west-2.elb.amazonaws.com ./dist (use up to date cluster url)
Go to Catalog - run Cassandra
Go (quickly) to services page and hover over the status bar in the services table while it's deploying
Should see tooltip with a regular looking sentence instead of translation message syntax

Trade-offs
Had to import Trans despite not using it in ServiceStatusProgressBar because otherwise the Plural message is not extracted. See lingui issue
Screenshots
See before screenshot in JIRA.
After:

:tada: This PR is included in version 2.36.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature Request]:  Add Solution to LC Problem - 2032

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Problem Name - Two Out of Three
I need to add solution to this Problem with detailed explanation
Use Case
Two Out of Three
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Hi @sreevidya-16,
Here are some Guidelines for Writing DSA Problem Solutions for your reference. Please ensure that all your contents follow these guidelines so that we can maintain the quality of the solutions at a high level.
Feel free to ask if you have any questions.


Binary Accuracy for multi-label classification discrepancies

While training, or evaluation, the model returns accuracies in the range of 90%.
However, per-class accuracy (while plotting precision vs recall graph) or the mean average precision is only about 40%.
Can someone please shine some light on why this might be happening?
Thanks in advance.

Class imbalance could explain it for example.
Imagine you have 90% of class A and 1% class B 1% class C 1% class D, ... 1% class J
You predict only A 100% of the time. Your model accuracy is thus 90%
But per-class accuracy is much lower.

That's what I wondered too; I have over 20 classes and some of them have a lot more data than other classes; and I am performing a multi-label multiclassification.
I understand the way binary crossentropy loss is calculated for this case; but I wanted to know in a more granular way how the accuracy was calculated. I looked up the implementation and it says that it performs an element-wise equality of the ground truth and predicted labels; and then gives the mean of the result.
I wanted to test that out myself by giving a dummy data to see how it works, but I guess it requires tensors and not numpy arrays (I am sure I ran into some issue like 'object does not have attribute dtype').
Is there any way we could test out the metrics by giving our own data (like sklearn does)?

Thank you! That should surely help. 👍 Closing this issue (for now)

Is it multi-label AND multi-class? If so, prediction False for all value can result in very high accuracy.

@maximus009 , could you explain how binary-crossentropy loss is calculated for this case? I noticed very small loss with binary crossentropy but  much larger loss with 'categorical_crossentropy'. The same for accuracy, binary crossentropy results in very high accuracy but 'categorical_crossentropy' results in very low accuracy. I believe it's just how the metrics calculated causing this big difference.

@lipeipei31 I think it depends on what activation you are using. If you are using 'softmax', you should use 'categorical crossentropy'; it does not make sense to use 'binary crossentropy'.
Binary crossentropy is just a special case of categorical crossentropy, where you deal with 2 classes.

@maximus009 Thanks for the response! I agree with you. But I found online that many people suggest 'sigmoid' and 'binary crossentropy' for multi-label classification. When I say multi-label, I mean for one sample, y_target is something like [1,0,0,1,0...]. You mentioned in the post that your problem is a multi-label classification problem. Is it the same as what I understood? Or your y_target is a one hot vector,i.e.[1,0,0,0,0...]. If it's the latter, then I think I am clear how the loss and accuracy are calculated. If it's the former, then I am curious how the loss is calculated if I choose  'binary crossentropy'.

@lipeipei31  the current binary_crossentropy definition is wrong. It should be K.sum(K.binary_crossentropy(y_pred, y_true), axis=-1) . For the accuracy if you are doing one-vs-all use categorical_accuracy as a metric instead of accuracy.

I agree with @myhussien. The current implementation of binary_crossentropy with K.mean makes the loss very low in the case of multilabel classification. For example, y_target has 100 elements with 99 zeros and 1 one, even though the model predicts all zeros, the loss value is still very low, like 1/100.

I do agree with @myhussien. K.mean makes the loss value of binary_crossentropy very low in the case of multilabel classifier. For example, y_target has 100 elements with 98 zeros and 2 ones, the value of loss is something like 2/100 in the case that the model predicts all elements as zeros.

I found the result of the binary_accuracy calculation for multi-label classification is very misleading too.
If you have 100 labels and only 2 of them are 1s, even the model is always wrong (that is it always predict 0 for all labels), it will return 98/100 * 100 = 98% accuracy based on this equation I found in the source code.
def binary_accuracy(y_true, y_pred):
    return K.mean(K.equal(y_true, K.round(y_pred)), axis=-1)

But the accuracy computation is correct. What matters is if accuracy is a relevant metric when it's about multi-label -- and it is not relevant due to those cases. So it might be misleading, but how could Keras automatically know this? It's user's responsibility to set a correct and relevant metric.

@keunwoochoi You are right. Keras cannot know about this. However, if you google the topic "multi-label classification using Keras", this is the recommended metric in many articles/SO/etc.
What I'm trying to say is that this metric is misleading for the "multi-label classification" in general especially for when there are many zeros and small number of ones for the labels as I showed in the example.

There are some metrics in sklearn for multi-label classification: http://scikit-learn.org/stable/modules/model_evaluation.html

So is there any recommendation for how to get around this issue? For example, I'm trying to train a network to predict binary semantic segmentation (i.e. output a mask with pixel-wise predictions of 0 or 1), however the number of 0's dominate the number of 1's. It sounds like the keras binary cross-entopy is not going to capture the class imbalance as is. Can anyone advise either a different metric or maybe a way to tweak that metric to account for class imbalances? From https://github.com/fchollet/keras/issues/3653 it looks like using sample_weights would work, however the kicker for my problem is I'm using a generator to augment my images, and fit_generator doesn't seem to have a sample_weight option (which makes sense, since the sample weights will change depending on the image augmentation and how to map that correctly isn't trivial..).
I have something so far like:
def weighted_binary_XE(y_true, y_pred):
    y_true_0, y_pred_0 = y_true[y_true == 0], y_pred[y_true == 0]
    y_true_1, y_pred_1 = y_true[y_true == 1], y_pred[y_true == 1]
    s0 = K.mean(K.binary_crossentropy(y_pred_0, y_true_0), axis=-1)
    s1 = K.mean(K.binary_crossentropy(y_pred_1, y_true_1), axis=-1)
    Npix = y_true.shape[0]*y_true.shape[1]*y_true.shape[2]
    return s0*len(i1)*1.0/Npix + s1*len(i0)*1.0/Npix

but at the first line in the above snippet I get:
y_true_0, y_pred_0 = y_true[y_true == 0], y_pred[y_true == 0]
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/array_ops.py", line 338, in _SliceHelper
sliced = slice(tensor, indices, sizes)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/array_ops.py", line 388, in slice
return gen_array_ops.slice(input, begin, size, name=name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/gen_array_ops.py", line 2001, in _slice
name=name)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/op_def_library.py", line 703, in apply_op
op_def=op_def)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 2312, in create_op
set_shapes_for_outputs(ret)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/ops.py", line 1704, in set_shapes_for_outputs
shapes = shape_func(op)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/ops/array_ops.py", line 1510, in _SliceShape
input_shape.assert_has_rank(ndims)
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/framework/tensor_shape.py", line 621, in assert_has_rank
raise ValueError("Shape %s must have rank %d" % (self, rank))
ValueError: Shape (?, ?, ?) must have rank 1
Any idea how to proceed? Thanks to anyone in advance.

What is the right metric to be used in such cases (Multi-label with sparse output vectors)?

@silburt Although it has nothing to do with Keras, the Focal Loss could be an answer to your question. Otherwise, you can check the weighted_cross_entropy_with_logits function from Tensorflow

@myhussien Just wanted to point out that your answer seems to be concordant with a recently published paper: https://arxiv.org/pdf/1711.05225.pdf
See where they say "sum of unweighted binary cross entropy losses" -- in the section referring to the multi-label classification problem.
I am still wondering how to implement this type of loss function in Keras. Would it be the following?:
def sum_binary_crossentropy(y_true, y_pred):
    return K.mean(K.binary_crossentropy(y_true, y_pred), axis=-1)

parallel_model.compile(
    loss=sum_binary_crossentropy,
    optimizer=opt,
    metrics=['categorical_accuracy'])

And would metrics = 'accuracy' or 'categorical_accuracy' ?

I am getting higher accuracy value while using binary accuracy as a metric but getting low value while using accuracy as a metric. using dstl kaggle satellite dataset for segmentation problem. Can anyone explain how this metrics are working?

maybe  tf.keras.metrics.CategoricalAccuracy(name='accuracy') can be useful


very slow after opening class that have big byte array

some APK's (and // protected by DexProtector)  in decryptions class have very big byte array.
if i want to open this class with jadx, It freezes
you can check class "co.palang.QuizOfKings.ProtectedCoronaApplication" in QuizOfKings game(download from googleplay)

If the UI is not capable o handle such large data you can still decompile the APK to sources using jadx on the command-line.
Afterwards you can check if any of your editors is capable to displays the large files.

@jpstotz i did what you said, open this class with Notepad++ not freezes my pc, just little slow, on scrolling.
but jadx fully freeze

The common Java UI components are not designed to handle extreme situations. This applies to most Java AWT/Swing gui components as well as SWT components.
Therefore Jadx can only use or not use those components. Furthermore exchanging central components like the source code viewer would cause significant amount of time as a lit of jadx functionality depends upon it.
If you are a Java developer feel free to make your own tests and provide improvements to jadx and/or any of the components Jadx uses (like RSyntaxTextArea which is used a source code viewer).

I just run the profiler and found that problem in line numbers rendering. Then disabled, code viewer works fine and not freeze. And that not RSyntaxTextArea fault, this component was added by me :(
I will try to optimize it or adjust condition to disable it as I did previously here.

Thank you, good luck

Fixed! Can anyone check the latest build to confirm the fix?

Now works  fine.

Yeeah works fine


Error codes

Hello,
I have installed a balcony power station with Hoymiles HMS-800-2T. At the moment it is very cloudy and therefore there is little to no production, but I am wondering about the error codes. Where can I find details on this? When I Google it, I can't find anything and there are no errors in the Hoymiles app.

After a firmware upgrade the errors disappear.


[RESOLVED] High ICMP ping response time

Problem started at 12:31:29 on 2023.06.16
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Operational data: Value: 197ms
Original problem ID: 28869
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23268&eventid=28869

Problem has been resolved in 3m 0s at 12:34:29 on 2023.06.16
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Original problem ID: 28869


fix expand_dims if axis< 0

Description
fix expand_dims if axis< 0
Checklist
Essentials

[x] Passed code style checking (make lint)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] For user-facing API changes, API doc string has been updated.
[x] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

(2, 3).expand_dims(axis=-1) should be (2, 3, 1) to be consistent with numpy. Currently it propagate (2, 1, 3).

We probably should make this change. But it will break existing code.
Need to note it in release notes.


Blank Screen

Hi,
when I open Photopea via right click on Load imagein comfy, no interface appears. But it shows up in my custom nodes and cmdline.
What am I doing wrong?
Greets,
Yogo

so do I

open https://www.photopea.com/ in another tag keep online than come back to ComfyUI it work !


unit test

Test this line to give 100% coverage on LfuNode.

coverage: 98.689% (+0.2%) from 98.474% when pulling e713eb0b6cffd4c04f1754840b38ab1df51746fe on users/alexpeck/debugtest into e783286c0c4ff499eaca6c093c6901e10f344926 on main.


Indentation rule behaviour

One thing I've noticed as since switch from SCSSLint is that the indentation rule behaves slightly different in SassLint. While I know there are some issues with maps, it also applies the rule to comments.
While I don't think this behaviour is any less correct, I think it would be great if we could have a option to disregard incorrectly indented comments.
An example of where this could happen:

SassLint - develop

Yeah i think the option to ignore comments would be a welcome addition. Im leaning more towards them being ignored by default with an option to include them.

I'd prefer them not ignored by default as it's an exception to the rule

On Sep 27, 2015, at 11:19 AM, Dan Purdy<EMAIL_ADDRESS>wrote:
Yeah i think the option to ignore comments would be a welcome addition. Im leaning more towards them being ignored by default with an option to include them.
—
Reply to this email directly or view it on GitHub.

Yeah makes sense, lets go with that.


nixos/systemd: Enable oomd

Description of changes

Closes #113903
Closes #142149
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Should this be enabled by default considering this?

@QuantMint that's why it's not enabled on the root slice.
As far as I understand the documentation, only units in cgroups that are configured to use oomd will be killed.
Since enabling oomd for -.slice is opt-in, the module doesn't really do anything until a slice/service is configured to be killed.
Please correct me if I'm wrong

Can the release notes more prominently describe that this doesn't do anything by default, and refer to the enable*Slice options?
I could also envision desktop environments that spin up new cgroups, like GNOME, to enable these slice options. Similar to what Fedora intends to do, depending on the installed DE.

Ok cool, so it's not enabled for any of the slices so I guess we don't need to go opt-out for any of the window managers? It's enabled but each slice is opt in right now?
https://github.com/NixOS/nixpkgs/issues/113903#issuecomment-857296349

@06kellyjac that's how I understand the documentation, yes.

So, this is not considered a breaking change (otherwise we froze already) and you still want to aim for 22.05?  If so, I think we should include this very soon (i.e. in the closest staging iteration).

You are right. systemd is release-critical and we alredy froze these.
I highly doubt this will break the package but I also respect the freeze process so let's wait until the last staging iteration that goes into 22.05 is done.

The schedule table says

Restrict breaking changes to Release Critical Packages

so by my understanding this PR could still pass.  But if there's no reason to hurry...

Ping for status.

For reference, current staging won't make it to 22.05 anymore.

What's the status of this?

This probably needs to be rebased, and the release notes need to be moved.

@dasJ will you get to this in the near future?

Yes, I just did

@flokli hopefully you find the time to merge this :)

I merged the mass-rebuild part to make this easier.  (it doesn't do anything by itself IIRC)

So should I wait for the staging merge and then target master?

As you prefer.  When you feel ready, you can merge wherever this commit is.  At least from perspective of rebuilds.

Should be good to merge now

is this PR on hold to not put it into 22.11 ?

The tests don't seem to work: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.systemd-oomd.x86_64-linux

The tests don't seem to work: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.systemd-oomd.x86_64-linux

The OOM prevention of backdoor service is incorrect. ManagedOOMMemoryPressure=auto would inherit the parent slice's behavior, which is kill from -.slice.
This would pass the test,
diff --git a/nixos/tests/systemd-oomd.nix b/nixos/tests/systemd-oomd.nix
index f0b5a5f8e01..7293b91473a 100644
--- a/nixos/tests/systemd-oomd.nix
+++ b/nixos/tests/systemd-oomd.nix
@@ -15,7 +15,10 @@ import ./make-test-python.nix ({ pkgs, ... }:
       serviceConfig.ExecStart = "${pkgs.coreutils}/bin/tail /dev/zero";
     };
     # Do not kill the backdoor
-    systemd.services.backdoor.serviceConfig.ManagedOOMMemoryPressure = "auto";
+    systemd.services.backdoor.serviceConfig = {
+      ManagedOOMPreference = "omit";
+      OOMScoreAdjust = -1000;
+    };

     virtualisation.memorySize = 1024;
   };

But with this patch applied, the test still first triggers the kernel OOM killer to kill the testservice, and follows by systemd-oomd killing some other services. systemd-oomd never runs before the kernel OOM killer. Not sure if that's expected.

Agreed on the config changes.
However, I assume we're also consuming memory too fast for oomd to react. Their manpage says:

It is highly recommended for the system to have swap enabled for
systemd-oomd to function optimally. With swap enabled, the system
spends enough time swapping pages to let systemd-oomd react.
Without swap, the system enters a livelocked state much more
quickly and may prevent systemd-oomd from responding in a
reasonable amount of time. See "In defence of swap: common
misconceptions"[1] for more details on swap. Any swap-based
actions on systems without swap will be ignored. While
systemd-oomd can perform pressure-based actions on a system
without swap, the pressure increases will be more abrupt and may
require more tuning to get the desired thresholds and behavior.

Maybe we should give this VM some swap?

Interesting. https://fedoraproject.org/wiki/QA:Testcase_Swap_Based_Killing does also just tail from /dev/zero.

The output of systemctl --user status systoomd_swap_test should say the unit is killed. The kill can be racy so you may or may not see "systemd-oomd killed <...> process(es) in this unit". But if you see that message and also mention of "oom-kill" (which means the kernel OOM killer also kicked in) please note that in the comments/results. Otherwise, if it was a systemd-oomd only kill there will be no mention of "oom-kill".

Feedback is at https://pagure.io/fedora-qa/issue/662#comment-720602, and https://testdays.fedoraproject.org/events/105. Some people mention kernel oom-kill has been triggered before oomd.

I looked through the Fedora defaults, https://src.fedoraproject.org/rpms/systemd/pull-request/58#request_diff sets DefaultMemoryPressureDurationSec=20s. We don't set this at all, and according to oomd.conf(5), it defaults to 30 seconds.
I doubt it takes us more than 30 seconds to fill swap by trying to read the end of /dev/zero. Maybe we should set this to the minimum (1 second) in the unit test? But it might still be too fast?
We could try doing something like https://fedoraproject.org/wiki/QA:Testcase_Memory_Pressure_Based_Killing instead?

The comment in this module says Fedora enables oomd on -.slice and<EMAIL_ADDRESS>by default, but this has changed in F37 and again on main 4 days ago.
It is now enabled on system.slice and on all user slices, both with the same config as<EMAIL_ADDRESS>previously.
Should we update the NixOS module with options matching Fedoras's defaults?

I have no preference whatsoever. I left everything disabled to have the least possible user impact

If we are going to have oomd run by default, it might as well do something by default.

Perhaps revise the in-code comments about Fedora to match their current reality?

If we don't want nixos's oomd to kill things by default, why not just disable the daemon by default? That would allow us to change the configuration defaults to something useful, rather than a no-op.
(Correct me if I'm wrong, but the current configuration is a no-op, right?)

The current configuration enables the systemd-oomd daemon, which monitors units that have the ManagedOOMSwap or ManagedOOMMemoryPressure options set, but we don't set those on any unit by default.
It is not a no-op however if the user has enabled any of the enableRootSlice, enableSystemSlice or enableUserServices options provided by this module, or has manually set ManagedOOMSwap or ManagedOOMMemoryPressure on any unit.
I'd be in favour of keeping the daemon enabled by default, and make it monitor system.slice and all user slices just like Fedora does. This is what a module copying the exact behaviour of Fedora could look like:
-    # Fedora enables the first and third option by default. See the 10-oomd-* files here:
-    # https://src.fedoraproject.org/rpms/systemd/tree/acb90c49c42276b06375a66c73673ac351025597
-    enableRootSlice = lib.mkEnableOption "oomd on the root slice (-.slice)";
-    enableSystemSlice = lib.mkEnableOption "oomd on the system slice (system.slice)";
-    enableUserServices = lib.mkEnableOption "oomd on all user services (user@.service)";

+    # Same defaults as Fedora, see the 10-oomd-* files here:
+    # https://src.fedoraproject.org/rpms/systemd/tree/1320fc300948e7c12d16ea8dd4e0fae3fd821d54
+    enableSystemSlice = lib.mkEnableOption "oomd on the system slice" // { default = true; };
+    enableUserSlices = lib.mkEnableOption "oomd on all user slices" // { default = true; };

-    systemd.slices."-".sliceConfig = lib.mkIf cfg.enableRootSlice {
-      ManagedOOMSwap = "kill";
-    };

-    systemd.slices."system".sliceConfig = lib.mkIf cfg.enableSystemSlice {
-      ManagedOOMSwap = "kill";
-    };

-<EMAIL_ADDRESS>= lib.mkIf cfg.enableUserServices {
-      ManagedOOMMemoryPressure = "kill";
-      ManagedOOMMemoryPressureLimit = "50%";
-    };

+    systemd.slices.system.sliceConfig = lib.mkIf cfg.enableSystemSlice {
+      ManagedOOMMemoryPressure = "kill";
+      ManagedOOMMemoryPressureLimit = "50%";
+    };

+    systemd.user.units.slice = lib.mkIf cfg.enableUserSlices {
+      text = ''
+        [Slice]
+        ManagedOOMMemoryPressure=kill
+        ManagedOOMMemoryPressureLimit=50%
+      '';
+      overrideStrategy = "asDropin";
+    };

I guess slightly modifying the behaviour of enableSystemSlice for the best is no big deal.
However, removing the enableRootSlice and enableUserServices options would be breaking changes, so should we keep them (disabled by default) for the time being, maybe with a deprecation warning?

I agree we should probably behave similarly to fedora. As long as we document that change, and how to revert to the old behaviour in our release notes.


Keyvault service readme updates

Docs Build status updates of commit bf48a89:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit bf48a89:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit bf48a89:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-mapping/reference-unified.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit bf48a89:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-mapping/reference-unified.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


[Feature request]: [CI] Deprecating set output commands

Feature suggestion
We are getting the following warning from some time:

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Current behaviour
N/A

Duplicated of #289


Circom frontend: allow to define the step_native in Rust

Currently in the Circom frontend the step_native method extracts the value for $z_{i+1}$ from computing the witness and extracting it from the Circom circuit.
This approach was done initially to simplify things for the end dev, but in some cases we would like to allow the dev to define their own step_native logic natively in Rust, even having the circuit defined in Circom.
The idea is to allow to define the step_native in Rust that "overwrites" the default step_native of the Circom frontend FCircuit, but if the rust version is not defined it should default to use the already existing logic that obtains the next step from computing and extracting the Circom circuit witness.
For example, for a circuit that computes the SHA256 hash function:
If the dev does not define their custom step_native, the Circom frontend still works, computing the next state $z_{i+1}$ from computing the witness of the circuit and extracting it.
But if the dev wants a more efficient way to compute the step_native (which internally computes the hash), they can define that logic in rust using the SHA256 rust library, and then Sonobe will use that custom step_native, ending up being much more efficient in the computation of the step_native compared to the other approach.

Merged!
Thanks @vuvoth !


[Feature Request]: Compatibility with Reinforced Shulker Boxes

Great mod!
Any chance of adding compatibility with the following mod (and its add on)?

Reinforced Shulker Boxes
Reinforced Shulker Boxes (Enderite Addon)

It just adds extra shulker boxes with different sizes.

Sure I can look in into that

@yesiam77 Check out version 2.0.0. You will just have to add each shulker box you want to enable into the config.
Let me know if you have any problems.


Pig spawns on the moon?

just found some :P

Do you have any biome-adding mods installed (like BOP), I have had biome conflicts do that to me.  Easiest way to check is F3-> biome name

yeah there is a id conflict with BOP
Could you make the biome ids configurable too?

Done for 0.3.1


Refactor to use block hash as block id

PR Checklist

[x] I've built the code cargo build. For major changes, cargo build --workspace --release is recommended.
[x] I've run the automated unit tests cargo test. This executes our automated unit tests.
[x] I've not broken any existing tests or functionality. In addition to cargo test, I've run cargo clippy
[x] I've not introduced any new known security vulnerabilities. I've run cargo audit

[x] I've included a brief description and a good title of the proposed changes and how to test them.
[x] I've read the contributing guidelines.
[x] I've associated an issue with this Pull Request.
[x] I've checked that the code is up-to-date with the pyrsia/main branch.
[x] I've read "What is a Good PR?"
[x] I've assigned this Pull Request to "pyrsia/collaborators"

Description
Fixes pyrsia/pyrsia#407
This PR refactor the code to use block hash as block id
Screenshots (optional)

Please delete the .db files

ok. It's better to add it to .gitignore.

Please delete the .db files

ok. It's better to add it to .gitignore.

No we have other issues like #82 that are duplicated. That just hides the problem


Update the HTTP/3 library dependencies

This updates boringssl with a fix for the toolset that comes with fedora:39:
https://bugs.chromium.org/p/boringssl/issues/detail?id=642
This also updates to the latest curl release, 8.2.1, and updates its ng* dependencies.

[approve ci]

[approve ci]

[approve ci]

[approve ci]

[approve ci]


GitHub workflow for updating the template code

Addresses the technical part of https://github.com/perseids-publications/treebank-template/issues/44 (we still need to update the Getting Started docs).
This PR creates a GitHub workflow called "update" that's based on git restore. It is triggered manually via GitHub's web interface and it updates the template code while keeping user-modified files like public/xml/*.xml and src/config.json.
This should allow people who use the template to keep everything up to date without having to understand the details of git merging. I forked an older repository to test it on and it seems to work (commit).
It takes advantage of the newly released workflow_dispatch trigger. While testing, I ran into a bug on GitHub's side: the action did not show up unless I changed the trigger to push then changed it back to workflow_dispatch. This only happened sometimes and seemed to be related to force pushes. Once the action was set up, everything went well. Still, I think we should be aware there could be issues while GitHub is still debugging this trigger.

A user triggers the workflow by clicking "Actions", clicking "update", optionally entering a tag, then clicking "Run workflow":

The only other comment I have is that the comments in several of the files say "It requires the repository to be in a very specific state." but it isn't explained exactly what that state is other than to refer to the README and update.yml. Would it be possible to just summarize that here?

That's a good idea. I'll add a line to the comments about that.

Btw, I think perhaps the update of the .env flie is something that is missing from the instructions I wrote. Should it be there?

Everything will still work if the .env file isn't updated. The values are only used for the title of the page and for the preview that shows up when posting a link to social media like Twitter or Facebook (here).


[Bigtable] Add support for getting IamInstance to Instance.php

Also fix minor issues of PHPDoc comments for copyrights.

@dwsupplee @jdpedrie
Do you have any ideas why Travis fails? It looks like unrelated to my change directly.

Happy to merge this, just a forewarning we may be doing away with the "connection" abstraction.


Odd console output in Windows

Noticing odd console output behavior in Windows.

Looks as if I'm missing a specific font or something. The status lines also don't appear until I scroll down and then scroll back up in the console.
Running Windows Server Technical Preview (Version 6.4.9841)

Thanks.  This is a duplicate of #501.


Update Eslint / Sass / Stylelint Dependencies

Jira
N/A
Summary
Updates NPM dependencies for Eslint / Prettier, Sass / Sass Loader, Stylelint, and Nightwatch.
No functional code changes other than auto-formatting  changes from Prettier + an update to the Webpack Sass loader config to use the new config syntax required.
How to test
Confirm build passes — updates for this should be super straightforward.

PR was released with v2.13.0


Issue on page /data-visualise.html

I ran the seaborn code but it threw an error. Probably because the package was updated.
so.Plot(mpg, x="displ", y="hwy").add(so.Scatter())
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
c:\Users\umair\Documents\testing.py in <cell line: 1>()
----> [12](file:///c%3A/Users/umair/Documents/testing.py?line=11) so.Plot(mpg, x="displ", y="hwy").add(so.Scatter())

AttributeError: module 'seaborn.objects' has no attribute 'Scatter'

It runs if I replace .Scatter with .Dots or .Dot.
Moreover, code with move parameter also throws error, both for the bar plot and the jittered scatter plot.

Thanks for flagging this; seaborn has recently been updated which led to the issues. This should be fixed in 5c8c128.


Debug panel issue

Overlay of the debug panel

Can not minimize the debug panel. Does it by design?

@Danieladu  this will be resolved once fix: debug panel UX improvements by alanlong9278 · Pull Request #5928 · microsoft/BotFramework-Composer (github.com) is merged. Most likely tomorrow's nightly.

closed by #5928


ZCL List data types are reversed on big-endian platforms

Problem
The ZCL ARRAY data structure (which is used to support List data types) is sent reversed over-the air when the ZCL server is running on a big-endian platform.

Looks resolved?


Added parameter -bs

Added parameter -bs [--book_selector] to show all owned books and select those to download

@luk6xff Can you have a look at this? Personally I'm not convince if it's needed, but if we decide it's I'd suggest fixing linter issues and using some CLI utility to be able to select items (just like you can do this in Debian installation, it probably needs looking for some click plugin).

@mjenczmyk  I agree to not introduce this option. No value added but only complicates the code and requires a lot of effort to keep it working when webpage content changes in future.
I think we can close it.

I'm closing the pull request.


Update csv

Overview
This PR is needed for https://github.com/cormorack/io2_portal/pull/312
It adds more instruments to CAVA.

Pull Request Test Coverage Report for Build 314

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals

Change from base Build 311:
0.0%

Covered Lines:

Relevant Lines:
0

💛  - Coveralls


bug: DragContent on top IonicList broken

Type: bug
Platform: mobile browser
When you test this codepen: http://codepen.io/anon/pen/rVXyvp?editors=0011
on Phone you will see that once you try to swipe right (or drag a content) to open up the side menu it does not work.
But if you go on and remove option button TAG in codepen , dragContent works fine.
I have created forum post as well why it is failing:

one of the condition evaluates differently.

http://forum.ionicframework.com/t/ioniclist-drag-content-bug-codepen-provided/31097
Already discussed with mike on slack and he confirmed that this is a bug.

Any news on this ?

Hello! Are you still experiencing this issue?

Hello, on the latest I am using I still can not swipe left to right in order to show side menu

@fkolar Would you mind putting up a codepen so that i can compare it to the above codepen? Thanks !

Hi Justin,
Not sure if I understand what is wrong on above codepen ? When I test now on iPhone I can not get to the side bar when I swipe.
Even when I change version 1.1.1 the result is the same.
THakns,
Frank

Yep, thats the issue! You cant seem to open the side menu when swiping on the list. Is that the same issue you are having? And is your code similar?

Yeap. on the list. And the above original codepen just shows it and the whole problem started from similar usecase.
I found its only a problem of the list. When I set the list to  have only 1 item and do swipe under the list the side menu shows up.

Ok awesome, thanks for the info!

Hello all! Is this still an issue with the latest version of ionic? Thanks!

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!


Visual Studio Code should not discriminate against .gitignore files. It should infact worship them.

VSCode Version: 1.19.1
OS Version: Windows 10 (latest public build as of 2/10/2018)

Steps to Reproduce:

Open a file
Hit "Save as" or use Control + Shift + A
Change the file type in the dropdown
Hover over "Plain Text"
You will see that it's calling .gitignore as a "plain text" file.

This is not okay, .gitignore should be be hailed, it is our saviour, our god. How dare they call it just a mere plain text. Hmph!
Here's an image:

Does this issue occur when all extensions are disabled?: Yes/No
Yes
(P.S I'm extremely sorry for this shitpost please don't hate me)

Also might as well add .gitignore highlighting

i keep accidentally opening microsoft visual studio
(why did you DM me this bin)

(and me too)

(same)

(same)

But why.

lolwat

He DMed it to me too
Okay, nice to see bin truely DMs his shitposts to EVERYONE

bin jesus do you use like a selfbot to mass dm

I am a god shitposter what do you mean

Me and Shiro are like true gods of all shitposting.
We may not shitpost much, but when we do: it's really good.

XD

That is a bad shitpost tho please delet

What no it isn't

I'm actually serious about this issue.

What does this have to do with Discord?

WHOMST

VS Code is a program. As such, it does not discriminate or worship.
If you are a real worshiper of .gitignore, consider making an extension to better support it: https://code.visualstudio.com/docs/extensions/overview


Handling duplicated entries gracefully

At present, if a bib entry is repeated, the whole process will exit with no attempt to continue/skip over/ remedy the situation meaning one has to then go hunting manually.
This can be replicated with:
python3 fixbibtex.py examples/duplicates.bib   # or mixedduplicates.bib which contains more than 1 simple repetition

(Examples are in my fork of the repo and PR to come).
Invoking the script gives the user the following traceback:
Traceback (most recent call last):
  File "fixbibtex.py", line 250, in <module>
    cli()
  File "fixbibtex.py", line 246, in cli
    main(args.path)
  File "fixbibtex.py", line 229, in main
    newbib = loop.run_until_complete(fix_bibtex(path))
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
    return future.result()
  File "fixbibtex.py", line 99, in fix_bibtex
    bib = parse_bibfile(path)
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/database/__init__.py", line 852, in parse_file
    return parser.parse_file(file)
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/database/input/__init__.py", line 51, in parse_file
    self.parse_stream(f)
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/database/input/bibtex.py", line 385, in parse_stream
    return self.parse_string(text)
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/database/input/bibtex.py", line 380, in parse_string
    self.process_entry(entry_type, *entry[1])
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/database/input/bibtex.py", line 347, in process_entry
    self.data.add_entry(key, entry)
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/database/__init__.py", line 150, in add_entry
    report_error(BibliographyDataError('repeated bibliograhpy entry: %s' % key))
  File "/Users/joehealey/Applications/miniconda3/lib/python3.6/site-packages/pybtex/errors.py", line 77, in report_error
    raise exception
pybtex.database.BibliographyDataError: repeated bibliograhpy entry: Hitchcock1986

Since duplicated entries aren't strictly an issue for use with TeX (a warning is usually given, but I believe compilation will continue without error, and duplicates are skipped). It would be good if the script could gracefully handle this scenario, even if the solution is just to skip the entry, and warn, as TeX does.

I have added a new commit addressing duplicate keys. Let me know if this is enough.
Detecting duplicated entries (I mean, same entries with different keys, even if not perfectly equal) could be also interesting to address, but that problem is not that trivial...

Tried it on the toy example I made and it seems to handle it quite nicely! I also threw it at my ~400 citation PhD bib file, and it warned about a dozen duplicates. Seemed to go on to complete correctly thereafter, so I'd call this a success - cheers Jaime!
One other observation (not sure if this is intentional or not but), it puts out the repeated entry warning twice, right at the start, and just before the patched file info.
I think the duplicate entries/different keys enhancement would be well worthwhile - but agreed, not easy. For my own thesis I grepped and string replaced through my .tex files to find incorrect multiple keys to correct them at the document compile time (but it would have been easier to have resolved it upstream in the bib file).

@jaimergp:
Detecting duplicated entries (I mean, same entries with different keys, even if not perfectly equal) could be also interesting to address, but that problem is not that trivial...

Maybe we can use minhash or other LSH techniques to address this. These techniques could also be applied to find similarity scores with search results. I have to look into that!


General question

Is it possible to have one static let reachability = Reachability() and use the .whenReachable in various VC to achieve different things? So in one VC it would execute one thing and in another VC it would execute something else

The Reachability class only has a single .whenReachable property. If you want to respond differently in different view controllers, you might find it easier for each VC to observe ReachabilityChangedNotification


(FM-3866) Release Supported version 1.0.0

[x] Sort the tickets into bug fixes and features and weed out the duplicates

@ferventcoder I thought metadata.json changes were always done via module-sync.

@cowofevil not that I'm aware of. It's too different to do so.

@puppetlabs/windows this is ready for review - compare to https://tickets.puppetlabs.com/browse/MODULES-2216

Well at least I got the branch name correct.


Store fields/methods and initialization missing from initial refactor work

With the initial phase 1 refactor work mostly complete, ensuring that the annotation tool starts up and moves through to the categorization page will require the addition and initialization of several store fields that were planned for but not yet implemented.
The following should be added:
State

[ ] categories field now initialized in state definition with keys for 'Subject ID', Age, Sex, Diagnosis but with empty objects for values (as mentioned during refactor planning)
[ ] colorInfo field added to store with colorPalette key value initialized in state definition. categoryToColorMap and categoryClasses are initialized via mutation setupCategoryColorMaps. This forecasts the upcoming change for dynamic categories and the (likely) need for more colors on the categorization page
[ ] pageData re-added to the store for page navigation functionality in tool-navbar and next-page components

Actions

[ ] #319

Mutations

[ ] Reintroduce mutation setupCategoryColorMaps which creates mappings between categories and general tool colors, and between categories and CSS style classes

Closed by #327


How to customize

Suggestion

How to customize the themes in terms of  - colors, padding, border, radius, font family? etc.
And there's already a limited collection of button type how can we extend that?

Like if you see the design system of vercel they at least have 2 - 3 type of button like - Primary, Ghost, With gradient, with custom SVG, loading state etc. https://vercel.com/design/button
So it could be possible if I can just extend this library to customize it. But the question is, Is it possible?

Hello, thanks for the suggestion.
In the demos there are different examples of variants and sizes see button for example. The code is highlighted on the relevant classes that give that particular style.
Xtend UI doesn't have a real theme (it's done for custom frontend development) but you can modify the colors and size and all the visuals by using different tailwind classes and tailwind theme variables.
I suggest creating global variables for the style you want to reuse (for example button.sizeMd) and reusing that variable.


Add aspnetcore(C#)

Fix for https://github.com/tbrand/which_is_the_fastest/pull/46

@tbrand when do you expect to update the results? I'm very curious :)

Today!

This commit has been included new release:tada:( https://github.com/tbrand/which_is_the_fastest/releases/tag/v1.1.2 )
Thanks again and waiting for your new commit! :smile:


Ask about HttpResponse.BufferOutput

Summary
Our repo uses HttpResponse.BufferOutput which is not supported by ASP.NetCore and this adapters.
I want to ask if there is equivalent and if there is plan to add them to adapter.
Motivation and goals
We need migrate code (an API in Sharepoint) to ASP.NetCore and we find that the APIs are not supported by ASP.NetCore.
In scope
HttpResponse.BufferOutput
I saw the comment in Harry's Issue https://github.com/dotnet/systemweb-adapters/issues/91
Could you explain more here?
Examples
bool hasWrittenResponse = !httpResponse.BufferOutput || httpResponse.DangerousInvoke<HttpResponse, int>("GetBufferedLength") > 0;

Looks like you just the need the getter. That can be enabled by adding the following:
internal interface IHttpResponseBufferingFeature
{
+   IsEnabled { get; }
}

Setting the value would be more complicated; if this is sufficient, feel free to submit a PR to enable this


OpenVPN Client 2.4 save correct protocol

This needs to be fixed the same as vpn_openvpn_server.php

@jim-p without this, the text description is saved to the config rather than the code, which then breaks the ovpn conf file that is written.

I thought I caught all of those, but the one slippy by, thanks!


fix(plyr.d.ts): add force to FullScreenOptions

According to documentation FullScreenOptions - fullscreen should have 'force' option.

Thanks 👍