Deployment commit for prod-stable

Merged main branch to prod-stable.
Use latest commit to update namespace ref in app-interface repo. Don't use merge commit, SHAs must be unique when images are created for each branch.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.96%. Comparing base (7960926) to head (d128088).

Additional details and impacted files
@@             Coverage Diff              @@
##           prod-stable    #1196   +/-   ##
============================================
  Coverage        76.96%   76.96%
============================================
  Files               68       68
  Lines              673      673
  Branches           100      120   +20
============================================
  Hits               518      518
+ Misses             155      139   -16
- Partials             0       16   +16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/ok-to-test


Fixed unintended fastlane folder generation bug

Containing the deliver related parts of #5825.

Thanks @chreno 🚀  Great tests!

Awesome, thanks @asfalcone! :)


indexOf implementation won't play well with jQuery

Please, take a look at this ticket:
http://bugs.jquery.com/ticket/10831

This issue was fixed in the following commit: https://github.com/kriskowal/es5-shim/commit/6f7878ed30d5c1f06c5978a06f71cf461404c0e7. You can verify the problem is solved at this fiddle: http://jsfiddle.net/bryanforbes/ULHHP/f

Wow. That was fast.

Refreshed minified source.


Broken link in CONTRIBUTING.md

Bug Report
A link to short document on reporting bugs in CONTRIBUTING.md is broken.
It links to /doc/dev/reporting_bugs.md file, which doesn't exist.

This appears to have been resolved since this had been opened and the link resolves for me. Poking around the git history for this files/directories didn't indicate much had changed since the introduction of those files.
https://github.com/operator-framework/operator-lifecycle-manager/blob/master/CONTRIBUTING.md#reporting-bugs-and-creating-issues looks like it correct links to https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/dev/reporting_bugs.md.


ModuleNotFoundError: No module named '_pytest'

slipcover seems to have an undeclared dependency on pytest now.
python -m slipcover run --json --out slipcover.json -m twisted.trial sometestsuite

fails:
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.9.12\x64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\hostedtoolcache\windows\Python\3.9.12\x64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\hostedtoolcache\windows\Python\3.9.12\x64\lib\site-packages\slipcover\__main__.py", line 153, in <module>
    wrap_pytest()
  File "C:\hostedtoolcache\windows\Python\3.9.12\x64\lib\site-packages\slipcover\__main__.py", line 112, in wrap_pytest
    import _pytest.assertion.rewrite
ModuleNotFoundError: No module named '_pytest'
Error: Process completed with exit code 1.

Ah indeed, I thought about this case but forgot to add it in (it's hard to test, requires a system without pytest).

Please try again with pip install -i https://test.pypi.org/simple/ slipcover==0.1.1.dev202204271309 and let me know if that solves it.  Thank you!

Yep, this works for me.  Thanks.


Wrong behavior when changing Tab Body With BottomNavigationBar

Problem when pulling body from right to left and very fast, something causes the selected item to move one more index in the BottomNavigationBar and TabBar and then return to the correct index, alone, as if it were a rubber band.
I could not reproduce the same problem by pulling from left to right
I found another identical case, already posted here in the community, but was closed for lack of information
how to get the page index #15673
Steps to Reproduce BottomNavigationBar
import 'package:flutter/material.dart';

class MainProfile extends StatefulWidget {
  @override
  MainProfileState createState() => new MainProfileState();
}

class MainProfileState extends State<MainProfile> with SingleTickerProviderStateMixin {
  // Create a tab controller
  int way = 0;
  int _currentIndex = 0;
  TabController _controller;
  VoidCallback onChanged;

  TabBarView tabBarView;

  @override
  void initState() {
    super.initState();

    _controller = new TabController(initialIndex: 0, length: 5, vsync: this);
    onChanged = () {
      setState(() {
        _currentIndex = this._controller.index;
        print(_controller.index);
      });
    };
    _controller.addListener(onChanged);
  }

  @override
  void dispose() {
    // Dispose of the Tab Controller
    _controller.removeListener(onChanged);
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return new Scaffold(

        // Set the TabBar view as the body of the Scaffold
        body: buildTabBarView(),

        // Set the bottom navigation bar
        bottomNavigationBar: buildBottomNavigationBar());
  }

  //Build the BottomNavigationBar
  BottomNavigationBar buildBottomNavigationBar() {
    return BottomNavigationBar(
      currentIndex: _currentIndex,
      onTap: (int index) {

        //WAY is the var just to test
        if(way == 0) {
          //This Way...
          setState (() {
            _controller.index = index;
          });
        }else {
          //Or this Way... the same problem
          _controller.index = index;
        }
      },
      type: BottomNavigationBarType.shifting,
      items: [
        buildBottomNavigationBarItem(0, Colors.teal, Icons.menu, Icons.restaurant_menu, Colors.white, Colors.white30, "First"),
        buildBottomNavigationBarItem(1, Colors.deepPurple, Icons.person, Icons.person_add, Colors.white, Colors.white30, "Second"),
        buildBottomNavigationBarItem(2, Colors.deepOrange, Icons.local_post_office, Icons.add, Colors.white, Colors.white30, "Third"),
        buildBottomNavigationBarItem(3, Colors.blueAccent, Icons.camera, Icons.camera_alt, Colors.white, Colors.white30, "Fourth"),
        buildBottomNavigationBarItem(4, Colors.redAccent, Icons.print, Icons.pregnant_woman, Colors.white, Colors.white30, "Fifth"),
      ],
    );
  }

  BottomNavigationBarItem buildBottomNavigationBarItem(int index, Color backgroundColor, IconData icon1, IconData icon2, Color colorIcon1, Color colorIcon2, String title) {
    return BottomNavigationBarItem(
      backgroundColor: backgroundColor,
      icon: _currentIndex == index
          ? Icon(icon1, color: colorIcon1,)
          : Icon(icon2, color: colorIcon2,),
      title: Text(title),
    );
  }

  //Build the TabBarView
  TabBarView buildTabBarView() {
    return new TabBarView(
      // Add tabs as widgets
      children: <Widget>[
        Icon(Icons.menu),
        Icon(Icons.person),
        Icon(Icons.local_post_office),
        Icon(Icons.camera),
        Icon(Icons.print),
      ],

      // set the controller
      controller: _controller,
    );
  }
}

Steps to Reproduce TabBar
class AppBarBottomSample extends StatefulWidget {
  @override
  _AppBarBottomSampleState createState() => _AppBarBottomSampleState();
}

class _AppBarBottomSampleState extends State<AppBarBottomSample>
    with SingleTickerProviderStateMixin {
  TabController _tabController;
  VoidCallback onChanged;

  @override
  void initState() {
    super.initState();
    _tabController = TabController(vsync: this, length: choices.length);

    onChanged = (){
      print(_tabController.index);
    };

    _tabController.addListener(onChanged);
  }

  @override
  void dispose() {
    _tabController.removeListener(onChanged);
    _tabController.dispose();
    super.dispose();
  }

  void _nextPage(int delta) {
    print(_tabController.index);
    final int newIndex = _tabController.index + delta;
    if (newIndex < 0 || newIndex >= _tabController.length) return;
    _tabController.animateTo(newIndex);

  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text('AppBar Bottom Widget'),
          leading: IconButton(
            tooltip: 'Previous choice',
            icon: const Icon(Icons.arrow_back),
            onPressed: () {
              _nextPage(-1);
            },
          ),
          actions: <Widget>[
            IconButton(
              icon: const Icon(Icons.arrow_forward),
              tooltip: 'Next choice',
              onPressed: () {
                _nextPage(1);
              },
            ),
          ],
          bottom: PreferredSize(
            preferredSize: const Size.fromHeight(48.0),
            child: Theme(
              data: Theme.of(context).copyWith(accentColor: Colors.white,),
              child: Container(
                height: 48.0,
                alignment: Alignment.center,
                child: TabPageSelector(controller: _tabController),
              ),
            ),
          ),
        ),
        body: TabBarView(
          controller: _tabController,
          children: choices.map((Choice choice) {
            return Padding(
              padding: const EdgeInsets.all(16.0),
              child: ChoiceCard(choice: choice),
            );
          }).toList(),
        ),
      ),
    );
  }
}

class Choice {
  const Choice({this.title, this.icon});

  final String title;
  final IconData icon;
}

const List<Choice> choices = const <Choice>[
  const Choice(title: 'CAR', icon: Icons.directions_car),
  const Choice(title: 'BICYCLE', icon: Icons.directions_bike),
  const Choice(title: 'BOAT', icon: Icons.directions_boat),
  const Choice(title: 'BUS', icon: Icons.directions_bus),
  const Choice(title: 'TRAIN', icon: Icons.directions_railway),
  const Choice(title: 'WALK', icon: Icons.directions_walk),
];

class ChoiceCard extends StatelessWidget {
  const ChoiceCard({Key key, this.choice}) : super(key: key);

  final Choice choice;

  @override
  Widget build(BuildContext context) {
    final TextStyle textStyle = Theme.of(context).textTheme.display1;
    return Card(
      color: Colors.white,
      child: Center(
        child: Column(
          mainAxisSize: MainAxisSize.min,
          crossAxisAlignment: CrossAxisAlignment.center,
          children: <Widget>[
            Icon(choice.icon, size: 128.0, color: textStyle.color),
            Text(choice.title, style: textStyle),
          ],
        ),
      ),
    );
  }
}

Please add the output of flutter doctor -v.

flutter doctor -v
[✓] Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.6 17G65, locale pt-BR)
    • Flutter version 0.5.1 at /Users/tiagosito/flutter
    • Framework revision c7ea3ca377 (7 weeks ago), 2018-05-29 21:07:33 +0200
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/tiagosito/Library/Android/sdk
    • Android NDK at /Users/tiagosito/Library/Android/sdk/ndk-bundle
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.2

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 26.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] Connected devices (2 available)
    • SM G900M • 8fc09a9b                             • android-arm • Android 6.0.1 (API 23)
    • iPhone X • 5FD53971-B439-45E2-AF07-65C116861EDF • ios         • iOS 11.4 (simulator)

• No issues found!

Flutter master v1.16.3-pre.56. BottomNavigationBar example

Yes, exactly what i'm talking about

There is what seems to be a related issue when current tab index is >= 2 AND the device orientation is changed. The result is there is either no child painted or the child of the next index is selected. Same issue with PageView.

Did you find any solution to this bug @tiagosito ?
@josephx86 for me the device orientation did not change but I have 4 tabs.
Here is my flutter doctor -v
    • Flutter version 1.19.0-1.0.pre at /Users/patricelynde/Development/flutter
    • Framework revision 456d80b9dd (2 weeks ago), 2020-05-11 11:45:03 -0400
    • Engine revision d96f962ca2
    • Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/patricelynde/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_SDK_ROOT = /Users/patricelynde/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[!] IntelliJ IDEA Community Edition (version 2020.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (2 available)
    • ONEPLUS A6003     • 77a97697                             • android-arm64 • Android 10 (API 29)
    • iPhone 11 Pro Max • E2AAE1DD-D73F-4DE6-8E8F-EFC403A09770 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)```

Você encontrou alguma solução para este bug @tiagosito ?
@ josephx86 para mim a orientação do dispositivo não mudou, mas eu tenho 4 guias.
Aqui está o meu flutter doctor -v
    • Flutter version 1.19.0-1.0.pre at /Users/patricelynde/Development/flutter
    • Framework revision 456d80b9dd (2 weeks ago), 2020-05-11 11:45:03 -0400
    • Engine revision d96f962ca2
    • Dart version 2.9.0 (build 2.9.0-7.0.dev 092ed38a87)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/patricelynde/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_SDK_ROOT = /Users/patricelynde/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.8052
    • Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

[!] IntelliJ IDEA Community Edition (version 2020.1.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.45.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.2

[✓] Connected device (2 available)
    • ONEPLUS A6003     • 77a97697                             • android-arm64 • Android 10 (API 29)
    • iPhone 11 Pro Max • E2AAE1DD-D73F-4DE6-8E8F-EFC403A09770 • ios           • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)```

not yet @lineablepatrice

The biggest problems I see in this bug is the fact that there is a rule on every tab to receive new data from the server every time the user has to go there, then the tab will trigger a get list call or something so from the server and with that I will spend client data and server resources unnecessarily, not to mention that this can also interfere with the flow of your business rule.
@zoechi, anything new about the issue?

Persists with current master 1.21.0-6.0.pre.41

flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-6.0.pre.41, on Mac OS X 10.15.6 19G73, locale en-GB)
    • Flutter version 1.21.0-6.0.pre.41 at /Users/nevercode/dev/flutter
    • Framework revision 39fa00201d (3 hours ago), 2020-07-27 21:11:43 -0700
    • Engine revision f27729e97b
    • Dart version 2.10.0 (build 2.10.0-0.0.dev 24c7666def)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.6, Build version 11E708
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (5 available)
    • Redmi Note 7 (mobile)       • 6345c469                                 • android-arm64  • Android 9 (API 28)
    • Nevercode’s iPhone (mobile) • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.6
    • macOS (desktop)             • macos                                    • darwin-x64     • Mac OS X 10.15.6 19G73
    • Web Server (web)            • web-server                               • web-javascript • Flutter Tools
    • Chrome (web)                • chrome                                   • web-javascript • Google Chrome 84.0.4147.105

• No issues found!


not working

files.forEach
TypeError: Cannot read property 'forEach' of undefined

ohh this is very old project.. let me try to see how this is not working.


refact: move nvim-highlite to other category

Hey, so I moved nvim-highlite from colorscheme category to colorscheme creation category because it makes a lot more sense in that way since nvim-highlite is just a template for creating your own colorscheme :)

Thanks for the PR! Great!


feature request: artisan command export default BREAD view for overriding

Laravel Version: 5.4.16
Voyager Version: 0.11.9
PHP Version: 7.1.2

Description:
feature request: artisan command export default BREAD view for overriding
Usage: user can export the default BREAD views to resources/views for editing
WHY: there is always some feature  to add into the views, add more custom field like map poi,
show softdeleted records, related model BREAD url links etc.

I think this is not important, because i was read wherever they won't support Categories, Posts and Pages in v1 so i don't think so this is important. You can create custom views for your BREADS, this is solution for you #1100

@AdrianKuriata, Issue 1100 is NOT the solution to every issue.
@ryh, this can be done manually following laravel documentation.  Just copy the view you need from under vendor/tcg/voyager/[...] to resources/views/vendor/voyager/[...]
Unfortunately we cannot create a Command to do everything or this package would get incredibly bloated.


[MTSRE-407] feat: new command for converting metadata to k8s resources

Summary
Adds convert command to mtcli for converting addon metadata to AddonMetadta Custom Resources.

Closing due to reduced focus on AMO.


[WIP] Feat/progressive app

Enables installing the application by selecting Add to home page in Chrome on Android and similar browsers.
Needs more work. Because you can't see the URL bar on progressive applications, some other way to select rooms needs to be integrated... :(

Should probably add a start (and exit) page before this is continued on.


Data Race when running schrddl test

What did you do?
Running this pr https://github.com/pingcap/tiflow/pull/4696 will raise the data race of sink module.
ci:
https://ci2.pingcap.net/blue/organizations/jenkins/cdc_ghpr_integration_test/detail/cdc_ghpr_integration_test/13349/pipeline
What did you expect to see?
Run normally
What did you see instead?
Data race of sink module:
github.com/pingcap/tiflow/cdc/sink/mysql.(*mysqlSink).execDDL()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/mysql/mysql.go:322 +0x23a
  github.com/pingcap/tiflow/cdc/sink/mysql.(*mysqlSink).execDDLWithMaxRetries.func1()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/mysql/mysql.go:296 +0x84
  github.com/pingcap/tiflow/pkg/retry.run()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/pkg/retry/retry_with_opt.go:57 +0x1a4
  github.com/pingcap/tiflow/pkg/retry.Do()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/pkg/retry/retry_with_opt.go:34 +0x84
  github.com/pingcap/tiflow/cdc/sink/mysql.(*mysqlSink).execDDLWithMaxRetries()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/mysql/mysql.go:295 +0x158
  github.com/pingcap/tiflow/cdc/sink/mysql.(*mysqlSink).EmitDDLEvent()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/sink/mysql/mysql.go:290 +0x84
  github.com/pingcap/tiflow/cdc/owner.(*ddlSinkImpl).run.func1()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/ddl_sink.go:182 +0x1118

Previous write at 0x00c002b13060 by goroutine 88:
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).asyncExecDDLEvent()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:634 +0xb1
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).asyncExecDDLJob()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:614 +0xc49
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).handleBarrier()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:535 +0x772
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).tick()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:248 +0x88b
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).Tick()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:160 +0x286
  github.com/pingcap/tiflow/cdc/owner.(*ownerImpl).Tick()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/owner.go:203 +0xb24
  github.com/pingcap/tiflow/pkg/orchestrator.(*EtcdWorker).Run()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/pkg/orchestrator/etcd_worker.go:247 +0x1343
  github.com/pingcap/tiflow/cdc/capture.(*Capture).runEtcdWorker()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:430 +0x1a4
  github.com/pingcap/tiflow/cdc/capture.(*Capture).campaignOwner()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:403 +0xd51
  github.com/pingcap/tiflow/cdc/capture.(*Capture).run.func2()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:279 +0x132

Goroutine 751 (running) created at:
  github.com/pingcap/tiflow/cdc/owner.(*ddlSinkImpl).run()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/ddl_sink.go:124 +0x230
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).initialize()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:365 +0xe43
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).tick()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:226 +0x285
  github.com/pingcap/tiflow/cdc/owner.(*changefeed).Tick()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/changefeed.go:160 +0x286
  github.com/pingcap/tiflow/cdc/owner.(*ownerImpl).Tick()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/owner/owner.go:203 +0xb24
  github.com/pingcap/tiflow/pkg/orchestrator.(*EtcdWorker).Run()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/pkg/orchestrator/etcd_worker.go:247 +0x1343
  github.com/pingcap/tiflow/cdc/capture.(*Capture).runEtcdWorker()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:430 +0x1a4
  github.com/pingcap/tiflow/cdc/capture.(*Capture).campaignOwner()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:403 +0xd51
  github.com/pingcap/tiflow/cdc/capture.(*Capture).run.func2()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:279 +0x132

Goroutine 88 (running) created at:
  github.com/pingcap/tiflow/cdc/capture.(*Capture).run()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:273 +0x6c5
  github.com/pingcap/tiflow/cdc/capture.(*Capture).Run()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/capture/capture.go:236 +0x2e4
  github.com/pingcap/tiflow/cdc.(*Server).run.func1()
      /home/jenkins/agent/workspace/cdc_ghpr_kafka_integration_test/go/src/github.com/pingcap/tiflow/cdc/server.go:255 +0x70
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /go/pkg/mod/golang.org/x/sync@v0.0.0-20220513210516-0976fa681c29/errgroup/errgroup.go:74 +0x86

stdout.log
Versions of the cluster
Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
Release Version: v6.0.0
Edition: Community
Git Commit Hash: 36a9810441ca0e496cbd22064af274b3be771081

Upstream TiKV version (execute tikv-server --version):
Release Version:   6.2.0-alpha
Edition:           Community
Git Commit Hash:   2e1513c83ffa62fc2edc3d6d28c14cb92e82ddbe

TiCDC version (execute cdc version):
v6.2.0-alpha-184-ge2e77ee17

/severity major

/unhold

I suspect the data race may be raised by closing the cdc process forcely,  not by normal DDL/DML sink, because I met another data race with the same check_table_exists timeout.
I will set the severity  to minor temporary.

/severity minor

/remove-may-affects-4.0

/assign hicqu


update formatHttpRequest and formatHttpResponse to handle client req and res

Currently formatHttpRequest and formatHttpResponse handle server-side request and response objects (from node core and some of the http frameworks). It would be nice to support the client-side request and response objects:

client-side request is a
http.ClientRequest returned from http.request() and http.get()
client-side response is a
http.IncomingMessage returned from the "response" event of a client http.request()

Normally I'm opposed to DWIM'ing, but it would be nice if it could be managed here without gross heuristics and ambiguity. Node core docs (and likely lots of community docs) commonly refer to both server-side and client-side requests and responses as req and res. Just logging those variables as is would be nice.
One potential issue is if this blows up to a desire to support many varying "client request" and "client response" objects from Node-land http client libraries. I don't know if that would be the case.
FWIW, some minor prior art is handling for client_req and client_res log record fields in Bunyan and client_req and client_res serializers for Bunyan in the restify-clients package.

I need to ask/check if client req/res events in ECS "http." fields would cause problems.

FWIW, here is what pino's stdSerializers will serialize for client req/res:
[1616438720932] INFO (14594 on pink.local): finished client req/res
    req: {
      "method": "GET",
      "url": "/",
      "remoteAddress": "<IP_ADDRESS>",
      "remotePort": 3000
    }
    res: {
      "statusCode": 200
    }

See this PR for discussion and code for extracting the url field, at least, from a ClientRequest object.


comparison operator

This PR tries to fix opened issue where @AlexMost pointed at the source code location :).
Comparison operators are currently written in JavaScript notation, but .po files structure and associated software (e.g. Poedit) uses different ones.
Tests has been modified and successfully passed.

Thanks for the PR!

ah, I just have tried this new version and seems like you have changed === to just = but not ==

Sorry if I missed some of them, but can't see which one do you mean?

I see that you have changed all === to = which is not a comparison operator. This line for instance - https://github.com/ttag-org/plural-forms/pull/2/files#diff-98a1cd4cb0257d4fa9ad62cd997700edR99

I see, totally missed that one out, created new PR


[WIP] Elasticity / memory allocations

Fix memory allocation problems with elasticity assembly.

Coverage increased (+0.06%) to 91.417% when pulling 3189ee215781d67c31aa425ad8c65d94287f85ad on elasticity/memory_allocations into 938b6245ce60c1bbe128b49474af0a17f01841af on master.

Coverage increased (+0.06%) to 91.283% when pulling bf2f8d4e881d91ce66169fabe1919fa7e44dcaec on elasticity/memory_allocations into 741bb8d0571f39f444876bcf2beaff272a0ea24a on master.

Coverage increased (+0.3%) to 91.751% when pulling b98556410c63cf3bfc23c3c8b46ece61abd17367 on elasticity/memory_allocations into 90fd63f3754e6582b63347100dd861ab7b45f6e0 on master.


Fix #104 - Support PostgreSQL alternative sink

This PR aims to fix issue 104, to support Serilog.Sinks.Postgresql.Alternative sink.
Hence, existing integration tests are according to Serilog.Sinks.PostgresSQL, I added some unit tests (QueryBuilderTests.cs) for query generation based on Serilog.Sinks.Postgresql.Alternative. Once we refactored integration tests and used sinks to insert log data, we could unify tests for both sinks.

@followynne I applied your comments; please re-review.


Add Integer awareness to RamUsageEstimator.sizeOf

Add RamUsageEstimator.sizeOf(Integer)
Improve estimation for both Long and Integer to not count VM Cache values.

Impl looks ok. In early versions we had an auto detector for the size of the cache, but we disabled it due to a bug in OpenJ9 (not sure about it anymore).
The comments still suggest that the auto detector is still there.
I have mixed feelings if we really need the size so exact? Do we really have many Integers and Longs in arrays or maps/sets?

I went looking for the previous change and found it in LUCENE-9117. Adding David for review request, since he was touching this last.
The JLS spec requires an Integer cache of at least [-128, 127], but in practice the upper bound can be higher. The Long cache is not required to exist, in current JVMs it looks like it is also hard coded for the same range, but no possibility to grow. I don't want to rely on vendor implementation of a JVM for the size of their boxed primitive caches though.
Maybe an aggressive compiler will figure out how to remove the checks that I'm adding here as well and we'll be stuck with misleading behavior again? If so, the other option is to update the comment so we're not claiming to be VM-cache-aware.

aaaaah... AOT, so my brain correlated that correctly to OpenJ9 (which also uses AOT)!
Yes, AOT could remove the check and then suddenly all Longs and Integers are zero size. At least your solution will not blow up when AOT jumps in. It will find identity in the obejcts and says "all longs/ints are cached", so size 0. The old code that Dawid removed went into an endless loop.
In my personal opinion, I would not check for the cache at all, unless we really overestimate for certain cases like and Integer[] array with thousands of small integers. But In Lucene code we have have this.
What is the real problem you are trying to solve?
Uwe

We saw some weird behavior in Solr with a size-limited Caffeine cache not getting as many entries as we thought it should have. That turned out to be because sizeOf(Integer) was returning 1024 (Solr's default guess for how big something is), and while investigating that missing piece, I found the incongruity between the comments and the code around LongCache.

We saw some weird behavior in Solr with a size-limited Caffeine cache not getting as many entries as we thought it should have. That turned out to be because sizeOf(Integer) was returning 1024 (Solr's default guess for how big something is), and while investigating that missing piece, I found the incongruity between the comments and the code around LongCache.

PRO TIP: On Guava's caches, I generally use the weighter() method in the cache builder to help the cache with a function how to calculate the "weight" of objects. This helps the cache more than exact sizes of elements. It allows it to figure out relatively large elements. Not sure if Caffeine has the same (I don't recommend to use caffeine because it uses Unsafe....).

Darn, I can't remember writing that code. :) LGTM though. With smarter and smarter compilers such memory estimation may become tricky like hell...

I still would not change the code here. Better to overestimate than having all Longs or Ints suddenly size=0 (when AOT jumps in).
I'd just remove the wrong comment.
And about Solr: Solr should use shallowSizeOf(Long.class) to tell Cafeine cache the reals size. That works consistent.

@uschindler my latest patch fixes the comment and adds Integer size. if you strongly disagree with adding the Integer size then we can roll that back too, but I think since we're already doing checks for Long it is ok to add other types here.

I don't recommend to use caffeine because it uses Unsafe....

@uschindler fyi Caffeine 3.x does not use Unsafe, which is what Solr uses. Unfortunatelly we did not have any good options prior to Java 9 (VarHandles), as atomic references would add memory bloat and atomic field updaters would use reflection. When Solr updated to Java 11 it was able to make the switch.

Thanks sorry, I just remembered the Solr 8.x times and the discussions and also bugs about caffeine which affected testing.

is it worth backporting to 9.x?

Yes. Wasn't that done?

@msokolov should be 090b05033e742c4db779dc3e0def83e8425b7ce3?

I think all is fine here. It is in change log of 9.4 and in 9x branch. So will be in release when 9.4 is branched away.

great, thanks!


Bit Slice with (start, length) instead of (start, end)

Type of issue: feature request

Impact: API addition (no impact on existing code)

Development Phase: request
Other information

#1079 is a fix for zero-width wires in bundles breaking asTypeOf. It is an instance of a more general problem: zero-width wires often break assumptions about widths. @ducky64 and @aswaterman noted that slicing with (start, length) is a clean way of dealing with zero-width wires and is also generally useful.
I think we could make something like 1 +: 3 work via implicits to produce a slice object, so we'd have
def apply(hi: Int, lo: Int) // exists now
def apply(slice: Slice) // new

implicit class SliceMaker(start: BigInt) {
  def this(start: Int)
  def +:(that: BigInt): Slice
  def +:(that: Int): Slice
  // possible to add other ways of slicing, if compatible with backend
}

It seems to me that with the way firrtl works it would be hard to do general slices, but (start, length) seems compatible with the way firrtl works so I don't think it needs any special backend support.

Since +: is "append to sequence" in the Scala collections, it has the potential to confuse.  I don't have a better suggestion right now, though.


[Aurora Generator Error] Mismatch post count after feature processing!

I also encountered this problem. I use node 16.3.0.

@EdisonKnew @RivenNero Can one of you show me what posts you have in your source folder?

@EdisonKnew @RivenNero Can one of you show me what posts you have in your source folder?

OK. This is my source folder structure:
+---about
|       index.md
|
\---_posts
        hello-world.md

This is about/index.md:
---
title: about
date: 2021-06-11 21:06:43
---

This is _posts/hello-world.md:

---
title: Hello World
---
Welcome to [Hexo](https://hexo.io/)! This is your very first post. Check [documentation](https://hexo.io/docs/) for more info. If you get any problems when using Hexo, you can find the answer in [troubleshooting](https://hexo.io/docs/troubleshooting.html) or you can ask me on [GitHub](https://github.com/hexojs/hexo/issues).

I see, so this happens when having less than 3 posts. I will test it out.

I see, so this happens when having less than 3 posts. I will test it out.

Maybe, because I was first use this theme. To be honest, it's a very nice theme!!
And I think this is the same as the other bug. #105


⚠ TorrentLeech has degraded performance

In a1d6e1c, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 5928 ms

Resolved: TorrentLeech performance has improved in ddd372f after 22 minutes.


Seeding

wikimedia
icones.js.org
Smashing / CSS-Tricks?
Brands of the World
PR to vsicons
Bikeshed / CSS-WG

GitHub topic for CSS: https://github.com/github/explore/tree/main/topics/css

vscode icon packs

Should this happen before w3c/csswg-drafts#11193 got resolved?

i dont think it needs to wait. maybe it'd give it more klout for the folks we introduce it to, but they likely adopted the community JS logo without Javascript ™ 's approval. but i dont think this logo is klout driven, it's community driven. wherever folks wants to use it, we're happy this is serving that purpose for them ❤
what were you thinking? waiting for it to be something more "official"?

Not exactly to be more "official" rather than to make sure there aren't small things the CSSWG points out that might need to be adjusted after seeding.
Would be annoying to reiterate through all of places to update the logo again, no?

i see, you're thinking there might be change requests still, gotcha!


[fltk] Fix build error on Linux

Related issue: #9989
There are no features need to test.

/azp run

Alright, looks good to me! Thanks Lily :)


"Dârlești" is listed in the drop-down menu

Description:
"Dârlești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Dârlești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Dârlești, Alba (Horea)".


support .cljc files

in lieu of getting clojureCLR to handle reader conditionals (https://github.com/clojure/clojure-clr/commit/fb7f09137516052271de86d8d5a3b6331bc29f19) Arcadia could at least recognize the .cljc mime type.
(Some libs use .cljc without any conditionals which allows usage in both jvm clojure and clojurescript )

Agreed. We hardcode clj in a bunch of places and shouldn't.

Do we really need this for 0.1? If it's going to be a pain I vote we kick it down the road.

It used to be as simple as changing the regex to ".cljc?$" in these two fns https://github.com/arcadia-unity/Arcadia/blob/develop/Source/arcadia/compiler.clj#L46-L62

I think it might be as simple as changing the regexp. Miller already ported reader conditionals to ClojureCLR. It would make a lot of packages more useable, maybe?

Should be fixed in 3656c7e09fc145990ad1cc64170ab256c484d6cd, but I'll reopen if this proves to be buggy.


"Notebook(Preview)" not working properly

Describe the bug
The "Notebook(Preview)" option is not working. When clicked, it shows a blank pop-up window.
Severity : Medium
Persona : Data Scientist
What happened?
I clicked on the "Notebook(Preview)" option and it showed a blank pop-up window.

What did you expect to happen?
I expected that the option will work.
How would you reproduce the bug?

Log in to your account and go to the Data Scientist persona.
In the home screen, click on the "Notebook(Preview)" option.

Did this happen via Desktop and/or Smartphone?
Desktop
Operating System
Windows 11
What browsers are you seeing the problem on?
Microsoft Edge
Version
No response
Device
Acer Laptop
What is your current role?
Student Ambassador
What technical topic is this bug related to?
No response
Relevant log output
No response

@Manya-tech, can you test this again? Looks like a network issue.

It happened for me too the options were not visible few times and again we need to refresh the page to see them.

This issue occurs when we miss this step:
Step 2
Enable Microsoft Fabric for your Tenant
Happened with me too and after doing this step, it starts working normally.
This is the guide:
https://techcommunity.microsoft.com/t5/educator-developer-blog/step-by-step-guide-to-enable-microsoft-fabric-for-microsoft-365/ba-p/3831115


Add ARM Windows

Can you try run the build again with maturin 1.7.7, it may have been fixed by https://github.com/PyO3/maturin/pull/2353


Question: Any plans on adding allure reporting?  (or any other reporting mechanism)

I tried added @wdio/allure-reporter to the npm global install list in Dockerfile
RUN apk --no-cache add \
    nodejs \
    npm \
    ffmpeg \
    android-tools@edgetesting \
  && npm install -g \
    npm@latest \
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
    @wdio/allure-reporter \
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\

and added the config in wdio.conf.js
reporters: ["spec", "allure"],
  reporterOptions: {
    allure: {
      outputDir: "allure-results",
      disableWebdriverStepsReporting: true,
      disableWebdriverScreenshotsReporting: true,
      useCucumberStepReporter: false
    }
  },

Here's the error I get
Stderr:
wdio_1          | [0-0] 2019-04-17T11:59:36.703Z ERROR @wdio/local-runner: Failed launching test session: Error: Couldn't find plugin "allure" reporter, neither as wdio scoped package "@wdio/allure-reporter" nor as community package "wdio-allure-reporter". Please make sure you have it installed!
wdio_1          |     at initialisePlugin (/usr/lib/node_modules/@wdio/local-runner/node_modules/@wdio/utils/build/initialisePlugin.js:62:9)
wdio_1          |     at BaseReporter.initReporter (/usr/lib/node_modules/@wdio/local-runner/node_modules/@wdio/runner/build/reporter.js:189:51)
wdio_1          |     at Array.map (<anonymous>)
wdio_1          |     at new BaseReporter (/usr/lib/node_modules/@wdio/local-runner/node_modules/@wdio/runner/build/reporter.js:34:39)
wdio_1          |     at Runner.run (/usr/lib/node_modules/@wdio/local-runner/node_modules/@wdio/runner/build/index.js:89:21)
wdio_1          |     at process.on.m (/usr/lib/node_modules/@wdio/local-runner/build/run.js:37:20)
wdio_1          |     at process.emit (events.js:187:15)
wdio_1          |     at emit (internal/child_process.js:812:12)
wdio_1          |     at process._tickCallback (internal/process/next_tick.js:63:19)

Thoughts on what I'm doing wrong?

Maybe you forgot to rebuild the Docker image?
I don't have plans to add additional packages to the blueimp/wdio Docker image.
The purpose of this project is more like a starter kit, so it's recommended to fork it and create your own Docker Hub Automated build if you require additional software inside the Docker image.
So if you make changes to the Dockerfile, you should build your own image, e.g.:
docker build -t YOUR_USERNAME/wdio .

Then in docker-compose.yml, replace blueimp/wdio with YOUR_USERNAME/wdio.
Also, the Allure outputDir must be in a writable directory, for example reports/allure:
exports.config = Object.assign({}, require('./hooks'), {
  // ...
  reporters: [
    'spec',
    [
      'allure',
      {
        outputDir: 'reports/allure',
        disableWebdriverStepsReporting: true,
        disableWebdriverScreenshotsReporting: true
      }
    ]
  ],
  // ...
})

oh, I see.
I'll give that approach a try.
Thanks again for your help.


Add support for redcatOS

Hi, I'd want support for my OS, redcatOS. I am currently working on it and want neofetch support as the logo currently is tux.
Description
Adds a new logo for neofetch on redcatOS Systems.
Features
New Logo

If redcatOS is based on Linux, it shouldn't be placed in the kernel name block but rather the ascii distro block. (aka. put it somewhere after Radix or Raspbian, don't put it after BSD or Linux)
You can test the ascii with the command ./neofetch --ascii_distro redcatOS

It is based on Linux, it just shows tux

The command shows tux because the ASCII art is misplaced. It should show your ascii logo if it's written correctly. (For example, if you try ./neofetch --ascii_distro fedora it would show a fedora logo)
You can fix it by moving the ASCII art to the correct place after Radix or Raspbian.

This is literally for my custom operating system


Linux -- ldid dependency

Not entirely sure that this is even an 'issue,' but thought it was worth mentioning ... during the initial install of dragon it will attempt to install ldid:
Installing Dependencies (ldid ). Press Enter to Continue. Reading package lists... Done Building dependency tree Reading state information... Done E: Unable to locate package ldid Installing dependencies failed. You need to manually install: ldid
This is unnecessary as ldid is bundled with whatever toolchain the dev chooses to use.

If this error message is removed, it may be worth noting in the readme to install a toolchain, since dragon grabs everything else for you and some may assume it has a pre-installed toolchain too if they're not prompted.


[Distribution] Standardize the device API.

Unify the string representation for the devices among all the backends, e.g. all devices should be lower case string, and standardized on 'cpu', 'gpu', 'tpu' with ':0' or ':1' as suffix of the position/index.

keras.device() API, which allows user to specify device placement logic in the code.
This should map to:

a. tf.device() in tensorflow https://www.tensorflow.org/api_docs/python/tf/device
b. jax.default_device() for JAX. https://jax.readthedocs.io/en/latest/_autosummary/jax.default_device.html#jax-default-device
c. pytorch https://pytorch.org/docs/stable/generated/torch.cuda.device.html

Note that it's already standardized in https://github.com/keras-team/keras/blob/master/keras/backend/jax/distribution_lib.py#L12 and https://github.com/keras-team/keras/blob/master/keras/backend/tensorflow/distribution_lib.py#L12

Kuik also suggested https://pytorch.org/docs/stable/generated/torch.set_default_device.html#torch.set_default_device for pytorch.


Add a session manager implementation for CosmosDB

Closing this as won't fix as there is not clear customer ask for this


Update requirements

The PRs created by dependabot will be closed automatically after this got merged. Besides, tests-pallets-min.in shouldn't be touched, I will close #4361, #4364, #4365 later manually.

I've started updating in 2.0.x instead of main, then merging forward, so that we are up to date on the support  too.


Media Path not working

When I try to add music using the settings page I enter /Users/xo/Desktop/Music, click scan and then get Error: The media path field is required..

Use full absolute path starting the root /home/username/Desktop/Music/

That is absolute, I'm on OSX. /Users/xo/Desktop/Music/ is the full path.

try by removing the last forward-slash.

Tried that too, I've tried relative, absolute, smb, ftp. No file paths seem to be working at all. I'm assuming this is OS X specific considering no one else seems to have had this issue.

try by using a cmd sync function php artisan koel:sync

➜  koel git:(master) ✗ php artisan koel:sync
Media path hasn't been configured. Exiting.

have the media path in setting and restart the koel, and please check the permission for the folder maybe its not accessible by koel.

Tried that too, it's running as my user xo and the paths that I've tried include on the desktop of the user I'm running koel as.

I'm having the same issue

The same for me , on Debian with full path:
"error: The media path is required"
Permissions and Path was ok !
Can we set PAth in config file ? to try with this command : php artisan koel:sync

you can set it in your database table settings and edit the key 'media_path' and edit it to your path value like this:  s:17:"/home/yugal/Music";

Of course since this is serialized data you need to adapt the 17 to whatever string length you put as a path.

after database modification it's working well on Debian !

Confirming here as well the sync button in the UI is not working as expected.
The issue seems to be the request body which is not formatted as the advertised JSON.
POST /api/settings HTTP/1.1
...
Content-Length: 10
...
Content-Type: application/json;charset=UTF-8
Accept: application/json, text/plain, */*
X-Requested-With: XMLHttpRequest
...

Request body:
/var/music

Hmm. Let me take a look.

Fixed. Laravel 5.2 changed Eloquent's lists behavior, and I missed this in my tests. Sorry guys.

:+1: Thanks for the fix!

Just do a git fetch --all && git checkout v1.1.1 and you should be set.


the "spawning animals exception" do not really work

 animals:
    ==: MVSpawnSubSettings
    spawn: 'true'
    exceptions:
    - ozelot

this means every animal spawns but NO ozelot.
ozelots still spawn.
if i set this to
animals:
==: MVSpawnSubSettings
spawn: 'false'
exceptions:
- cow
- chicken
- sheep
- pig
nothing spawns.... and if i set a spawn egg i or users arent able to get baby animals. the love mode works but the babys dont spawn.
and the second thing is that in my building world (flat world) are thousands of ozelots oO
thx for listening ; )
greets
Ardragoon

2019 and I'm wondering why this was closed without any info? I'm experiencing this exact issue spigot 1.14.4, mv-core 2.5..what's up?

Have a similar issue. The keep spawning. The only disappear once


Properly escape invalid escape sequences.

Fixes https://github.com/lmcinnes/umap/issues/805

Thanks for this. The errors seem to relate to some updates in tensorflow interacting badly with parametric UMAP which I will have to track down at a later date.


Upgrade tf-bridge to v3.40.0 and p/p to v3.53.1

Does the PR have any schema changes?
Found 2 breaking changes: Type "aws:fsx/OntapStorageVirtualMachineEndpointIscse:OntapStorageVirtualMachineEndpointIscse" missing Type "aws:fsx/OntapStorageVirtualMachineEndpoint:OntapStorageVirtualMachineEndpoint" missing property "iscses" No new resources/functions.

Should we be concerned that 2 breaking changes were found despite only the bridge and pu/pu being updated?


Change accessory type to Switch

Is your feature request related to a problem? Please describe:
i have a ceiling fan connected to Homekit and since the iRobot accessory type is fan, if i say, “hey Siri, turn on the fan,” both the fan & the iRobot turn on.
Describe the solution you'd like:
change the iRobot accessory type from Fan to Switch, or allow the user to select
Describe alternatives you've considered:
No response
Additional context:
No response
Node Version (optional):
No response
NPM Version (optional):
No response
Homebridge Version (optional):
No response
Plugin Version:
2.1.16
Operating System (optional):
No response

@bloomkd46 looks like there's already a pull request for this: https://github.com/bloomkd46/homebridge-iRobot/pull/167

Anyway to speed up the process to merge it and make it available? It's very annoying

Although it isn't a switch due to its lack of customization, I did change it from a fan. Feel free to try the latest beta:

Just gave the latest beta a try and got it working after a few minor hiccups. My previously configured robot didn't show up when upgrading from v3 -> v4. Manual configuration also doesn't seem to work for me be but I didn't have any issues using my iRobot login.
TBH I'm not sure I love the accessory type as a TV. I see the appeal of having everything in one place under the inputs, but you're not longer able to have automations for things like the bin being full.
I still think that ideally it would be a main switch with sub switches for actions and sensors for statuses. Then the user can chose to show it all as one tile or separately in HomeKit. Options in the Homebridge config to show what switches or sensors are displayed would be amazing.

I am intending to reintroduce the contact sensors for events, I just haven’t wrote it yet

Cool, I'll play with it some more. They way it always shows the current status the the tile is pretty nice.

I have to say after using it some more, having the device type as a TV is really neat. So far it works well and I haven't had any issues with Siri commands affecting TVs in the same room.


OEM driver alert is activated when not touching steering wheel

Describe the bug
I can’t seem to find the rhyme or reason, but every so often I get an alert from my OEM system saying that no driver hands are detected on the steering wheel
Part of the appeal of buying a comma was the promise that I wouldn’t have to touch the wheel
Which car does this affect?
2022 Hyundai Ionic 5
Provide a route where the issue occurs
02bf13f6ee29bc3e|2023-12-21--14-28-33--0
openpilot version
0.9.5
Additional info
There’s also another segment that it happened on:
02bf13f6ee29bc3e|2023-12-21--15-57-33--0
At 4:07pm pacific

Thanks for the routes! I requested upload of them, but in case the files aren't available anymore on the device, can you provide another segment?


Feature/file provisioning work

File provisioning hotfix for local files

[x] Check that you pass the basic style checks and unit tests by running mvn clean install

Coverage decreased (-0.07%) to 71.691% when pulling d88810694e4192d5348f71b511079465993402d3 on feature/file_provisioning_work into 480670a5b504193989873773fe74aa15ee785fe7 on develop.


Update broken stylesheet path in a default theme page

Should close #898. Tiny commit.
I can't see where this is used, but this is the only reference to the wrong css file in this theme, as far as I can tell.

Thanks!


Perplexing character next to the shortcut icons in the setting screen

Microsoft PowerToys version
v0.62.1
Running as admin

[X] Yes

Area(s) with issue?
Settings
Steps to reproduce
just open the setting screen, and switch to any tab that contains shortcut icons

✔ Expected Behavior
display shortcut without these characters
❌ Actual Behavior

Other Software
OS: Windows 10 Home (21H2,19044.1889)
System Language: Simplify Chinese

Are you still experiencing this issue? /needinfo


Consider using cookiecutter for the template

First of all, I love the way all the setup is designed, there  is clearly a lot of effort.
Nevertheless I think it could be a good idea to try to adapt the template design and convert it to a cookiecutter template. It is a widely used Python templates manager and the most nearly standardized way of creating new projects from templates and creating custom templates fully customizable. Also cross-platform support out of the box, which is great.
I think this template could be improved with that change and be used by more people.

Note: If you need some references of preexisting Python project templates using cookiecutter the best ones IMO are these:

https://github.com/audreyfeldroy/cookiecutter-pypackage (Quite simple and efficient but is not up to date with PEP 517)
https://github.com/cjolowicz/cookiecutter-hypermodern-python (Fully equipped template with lots of functionalities and CI/CD integration).

I previously used cookiecutter, but explicitly chose not to for this project for the following reasons:

Greater customization/control over the project creation process.
2.bootstrap uses naive find/replace, where the find tokens are still valid identifiers in most (python, toml, etc) languages. This allows CI, static analyzers, autocomplete to still work on the template. This wouldn't be possible with a jinja2-based template. This makes maintenance and adding features much easier and less error-prone.
bootstrap uses only python builtins, lowering the bar to entry slightly.


[Question] Application Shared Subscriptions

Component

Core

Description
My team is running into some issues with TBMQ around shared subscriptions (or at least how understand they are supposed to be working).
I have a Shared Subscription created to handle all topics, using "#" as the MQTT filter. It's configured with two partitions and have two Application clients connected to the shared subscription "$share/all-messages/#", both with persistent connections.  The kafka topic seems to be created properly and the consumer groups look correct, but it doesn't look like the broker is sending the messages round robin. Once I connect one client, it receives all the messages until I connect the second client after which the messages switch over to that  newly connected client. Basically it's only sending messages to one client at a time. If I disconnect one of the clients the messages then move over to the other client that is connected, so it's working as a failover, but I can't seem to get the round robin working.
So in short, are there any configuration steps I need to set to get the round robin working with Application clients or am I missing something with how to set up the shared subscriptions?
Environment

Deployment: TBMQ is deployed to our GCP cluster using the Azure instructions as a baseline. Kafka is running in GKE and Redis is running in GCP. We also stood up a separate Postgres instance for TBMQ. Most of the configurations are the defaults besides some definitions to get it integrated with the rest of our system.
TBMQ: v1.2.0

hey @gardnerd !
Thank you for the raised question and the greatly explained issue.
Based on the details you provided, it seems to me that the configuration you have done as well as the shared subscription setup for Application clients is correct. The reason for such behavior is Kafka itself. The Kafka producer is configured inside TBMQ that sends messages from MQTT clients (mqtt publishers) to the Kafka topic with partition = null and key = null. This logic is applied for publishing messages for Application shared subscription topics only.
The default partitioner (see below) is used for all the producers. Here are some details about how it is working:

The link: https://redpanda.com/guides/kafka-tutorial/kafka-partition-strategy
Here the explanation is a bit more precise.
https://docs.confluent.io/platform/current/installation/configuration/producer-configs.html#partitioner-class
The important part from that is - "If no partition or key is present, choose the sticky partition that changes when at least batch.size bytes are produced to the partition."
Since the Kafka topic has 2 partitions and you connect 2 App clients - each of them is assigned with 1 partition. For a better control and view I can recommend deploying to the cluster the Kafka UI. Here is the yaml definition.
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: tb-broker-kafka-ui
spec:
  serviceName: tb-broker-kafka-ui
  replicas: 1
  podManagementPolicy: Parallel
  selector:
    matchLabels:
      app: tb-broker-kafka-ui
  template:
    metadata:
      labels:
        app: tb-broker-kafka-ui
    spec:
      containers:
        - name: server
          imagePullPolicy: IfNotPresent
          image: docker.redpanda.com/redpandadata/console:latest
          resources:
            requests:
              cpu: 200m
              memory: 200Mi
            limits:
              cpu: 200m
              memory: 200Mi
          ports:
            - containerPort: 8080
              name: http8080
          env:
            - name: KAFKA_BROKERS
              value: "PUT_KAFKA_URL_HERE"
      restartPolicy: Always

Note: replace PUT_KAFKA_URL_HERE with actual url.
After it is deployed you can port-forward it to open in the browser:
kubectl port-forward tb-broker-kafka-ui 8080:8080

What can be interesting for you is how partitions receive messages:

I can reproduce such behavior as well. It is even more reproducible if the message rate is not so high. But when it is high enough - the messages begin to come into both partitions.
Anyway, we will consider such a behavior in the upcoming releases and will try to make it work smoother.
If you have any more questions, please let me know.
Best regards!

@dmytro-landiak Thank you so much for the quick response and explanation. The partition balancing coming from Kafka makes perfect sense and I'll keep that in mind moving forward. I was able to reproduce the behavior you described when there's a high message rate as well. In my testing I was only using a low rate which you were correct to assume. I was also able to get closer to a round robin behavior with a low message rate by changing the linger-ms and batch-size settings for the producer.


Error today: Node with given id does not belong to the document

After many successful runs, this error happened today:
2021-02-12 18:27:05.568 R2G GitHub Actions path found
2021-02-12 18:27:05.571 R2G Create browser
2021-02-12 18:27:06.308 R2G Login
2021-02-12 18:27:06.362 R2G - Navigating to login page
2021-02-12 18:27:07.647 R2G - Checking for email field
2021-02-12 18:27:10.035 R2G ERROR - Error: Protocol error (DOM.resolveNode): Node with given id does not belong to the document
    at /tmp/roam2github/node_modules/puppeteer/lib/cjs/puppeteer/common/Connection.js:208:63
    at new Promise (<anonymous>)
    at CDPSession.send (/tmp/roam2github/node_modules/puppeteer/lib/cjs/puppeteer/common/Connection.js:207:16)
    at ExecutionContext._adoptBackendNodeId (/tmp/roam2github/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:299:47)
    at ExecutionContext._adoptElementHandle (/tmp/roam2github/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:314:21)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Frame.waitForSelector (/tmp/roam2github/node_modules/puppeteer/lib/cjs/puppeteer/common/FrameManager.js:846:24)
    at async /tmp/roam2github/roam2github.js:173:13
R2G Exit after: 4.473s
Error: Process completed with exit code 1.

I'm hoping the next run will be fine, but figured you would want to see it anyway.

Hmm... That is odd. You can try re-running the job if you don't want to wait until next run. I do get occasional puppeteer errors that can't really be duplicated, because it always works when re-run. I just ran it a backup successfully, so probably not a change to the Roam login page. Likely to be a fluke. Let me know if happens more often.

Thank you for your advice! Honestly I am surprised with your kind comments as I am newbie here. I updated env in case they were wrong.

@takaokay You're welcome! If your Secrets were wrong, you could expect an error from this list: https://github.com/everruler12/roam2github/blob/main/documentation/Common error causes.md
The error in this GitHub issue happened when trying to locate the email field, so I don't think it's related to wrong env values

Rerunning the action worked fine by the way. I assume that occasionally with hiccups on the Roam side we will inevitably get random failures.
This is outside of the scope of your tool, but I wish Github actions had something along the lines of "only notify of failure for two consecutive failures". I don't really care to be notified unless the job fails over and over.

@sinoth Thanks for following up. Yeah, I wish email notifications could be set that way, too. Theoretically, it might be possible to disable the Actions notifications, then set up another Action workflow to send an email when triggered by multiple failures in the backup workflow. If you get this same error pretty often, I could try adding an additional check and retry, instead of failing on the first time.

Oh! This is the first time for backing up over 11 mins since the set-up.  I hope this works!

Unfortunately it failed. Not yet succeeded ever. Logs says "TimeoutError: waiting for selector .loading-astrolabe to be hidden failed: timeout 600000ms exceeded". This occurs every single time.  No Idea.

Updated graph name and it worked.


[PF2e] 0.4.2 Token not providing cover

Config:

Video of issue:
cover issue.webm

I have this issue in PF2e 4.9.3, Foundry ver 10 b 291, and ATV 0.4.3

The cover setting from this module just straight up dont work, which is a bit strange, since pf2e has its own cover conditions.

Is this still an issue in v0.4.4?

Fixed in v0.4.5. As for PF2e cover effects, the last time I looked at them, I could not figure out a viable way to assign them correctly. Plus PF2e has fewer hooks than dnd5e, which makes it difficult or impossible to mess with the combat workflow. But I intend to take another run at better integrating with PF2e cover effects.


CastShadow and ReceiveShadow

Are these on?
Here is a test graph: http://destroy.vizor.io/fthr/bowser-in-a-room
The bowser is set to castShadow and the Box is set to receiveShadow.

Looking at the Spot light description in the three.js manual, I think the light needs to be a spot light if you want shadows:  http://threejs.org/docs/#Reference/Lights/SpotLight


ASAN CI

Add ASAN flags for compilation and link extra paths needed for tests
Also adds a settings map

Hi @thansen-amd, is this PR still relevant or stale?

This is stale, closing. #468 should pick up asan


Update predict.md

Removed "peaks" as an option for maxATAC, given potential issues with the peak-centric mode in maxATAC.

I agree with Xiaoting -- provided peak centric is working as expected (predictions limited to a set of .bed intervals), let's keep it. As I recall, there might have been some issue that peak centric sometimes outputted predictions outside of the .bed intervals, due to overhang -- but this should be easy to fix with a bedtools intersection clean-up step at the end.

Hello everybody:
This is likely an edit I proposed for v1.0.5, where prediction restricted to an input set of intervals did not work (see some of my previous emails comparing whole-genome vs. "peak-centric" mode for maxATAC predict). It looks like this now works in v1.0.6, so we can ignore these edits!
Please let me know if you have any questions!
Akshata Rudrapatna

From: Emily Miraldi @.>
Sent: Tuesday, January 23, 2024 2:03:08 PM
To: MiraldiLab/maxATAC @.>
Cc: Rudrapatna, Akshata (rudrapan) @.>; Author @.>
Subject: Re: [MiraldiLab/maxATAC] Update predict.md (PR #124)
External Email: Use Caution
I agree with Xiaoting -- provided peak centric is working as expected (predictions limited to a set of .bed intervals), let's keep it. As I recall, there might have been some issue that peak centric sometimes outputted predictions outside of the .bed intervals, due to overhang -- but this should be easy to fix with a bedtools intersection clean-up step at the end.
—
Reply to this email directly, view it on GitHubhttps://github.com/MiraldiLab/maxATAC/pull/124#issuecomment-1906738752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBKU2MJOX5SKLNZGBEGX5HLYQACOZAVCNFSM6AAAAAA646PLICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWG4ZTQNZVGI.
You are receiving this because you authored the thread.Message ID: @.***>


add baseline editorconfig

Addresses https://github.com/astrolicious/astro-theme-provider/issues/87 though potentially incompletely. Note that I tried to stay as close to the Biome defaults. One unspecified setting was insert_final_newline, which I usually enable, but disabled here.
Additionally, it may make sense to add extra configuration patterns for things like markdown files to avoid unintended trim_trailing_whitespace.

Awesome, thanks for adding this!

BTW I need to fix a workflow, I am going to use this PR as an opportunity to test a fix


ValueError for cookies with null values

It would be nice if Splash could handle cookies fields containing null values.
Currently ValueError is raised:
https://github.com/scrapy-plugins/scrapy-splash/blob/master/scrapy_splash/utils.py#L44

@kmike I believe you fixed this in 225793bab7f44241144bd65811669f6cbb5d6b9d


Remove transaction when listing projects

What this PR does / why we need it:
Listing projects is a read only operation and therefore should not need the @Transactional Hibernate annotation.
Having @Transactional annotation results in excessive locks being used when listing projects because of the INSERT and DELETE queries generated. As a result, when other operations such as job updates (which is also Transactional) is running, users trying to list projects will often encounter GRPC error TimeoutExceeded because ListProjects will wait a long for the shared lock to be available.
When there is at least one feature set registered, these are the generated queries when listing projects:
sql.with.transaction.log
sql.no.transaction.log
Without @Transaction no INSERT and DELETE queries are generated and hence it will not wait for lock to be available when listing projects.

The generated queries can be logged with this log4j2 configuration in feast-core:
<Logger name="org.hibernate.SQL" level="debug" additivity="false">
      <AppenderRef ref="ConsoleAppender"/>
</Logger>

Which issue(s) this PR fixes:

NONE

Does this PR introduce a user-facing change?:

NONE

IMO none of these methods need to be transactional, but
/lgtm


Airbnb Superset LDAP authentication with Active Directory

Good morning. I'm trying to authenticate users in Superset through Active Directory using LDAP parameters in config.py but it's not working. I've followed the oficial docs instructions but without success. Can someone help me, please?
My environment info:
Description: Ubuntu 16.10
Release: 16.10
Codename: yakkety
python2.7
Flask-LDAP
python-ldap
pyldap
Airbnb Superset: {"GIT_SHA": "", "version": "0.18.5"}
Database: Remote MySQL Server
Active Directory: Windows server 2008 R2
config.py - LDAP configs
import ldap
from flask_appbuilder.security.manager import AUTH_OID,
AUTH_REMOTE_USER,
AUTH_DB, AUTH_LDAP,
AUTH_OAUTH,
AUTH_OAUTH
AUTH_TYPE = AUTH_LDAP
AUTH_USER_REGISTRATION = True
AUTH_USER_REGISTRATION_ROLE = "Alpha"
AUTH_LDAP_SERVER = "ldap://192.168.0.ip"
AUTH_LDAP_USE_TLS = False
AUTH_LDAP_BIND_USER = "CN=my_user,OU=my_users,DC=my,DC=domain"
AUTH_LDAP_BIND_PASSWORD = "mypassword"
AUTH_LDAP_SEARCH = "DC=my,DC=domain"
AUTH_LDAP_UID_FIELD = "sAMAccountName"
AUTH_LDAP_FIRSTNAME_FIELD = "givenName"
AUTH_LDAP_LASTNAME_FIELD = "sn"
AUTH_LDAP_EMAIL_FIELD = "mail"
AUTH_LDAP_APPEND_DOMAIN = 'my.domain'
Error Log
Traceback (most recent call last): File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1997, in __call__ return self.wsgi_app(environ, start_response) File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1985, in wsgi_app response = self.handle_exception(e) File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1540, in handle_exception reraise(exc_type, exc_value, tb) File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1982, in wsgi_app response = self.full_dispatch_request() File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1614, in full_dispatch_request rv = self.handle_user_exception(e) File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1517, in handle_user_exception reraise(exc_type, exc_value, tb) File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1612, in full_dispatch_request rv = self.dispatch_request() File "/root/venv/lib/python2.7/site-packages/flask/app.py", line 1598, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/views.py", line 402, in login user = self.appbuilder.sm.auth_user_ldap(form.username.data, form.password.data) File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/manager.py", line 630, in auth_user_ldap if not self._bind_ldap(ldap, con, username, password): File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/manager.py", line 578, in _bind_ldap user = self._search_ldap(ldap, con, username) File "/root/venv/lib/python2.7/site-packages/flask_appbuilder/security/manager.py", line 556, in _search_ldap self.auth_ldap_email_field File "/root/venv/lib/python2.7/site-packages/ldap/ldapobject.py", line 602, in search_s return self.search_ext_s(base,scope,filterstr,attrlist,attrsonly,None,None,timeout=self.timeout) File "/root/venv/lib/python2.7/site-packages/ldap/ldapobject.py", line 595, in search_ext_s msgid = self.search_ext(base,scope,filterstr,attrlist,attrsonly,serverctrls,clientctrls,timeout,sizelimit) File "/root/venv/lib/python2.7/site-packages/ldap/ldapobject.py", line 591, in search_ext timeout,sizelimit, File "/root/venv/lib/python2.7/site-packages/ldap/ldapobject.py", line 108, in _ldap_call result = func(*args,**kwargs) TypeError: ('expected string in list', u'givenName')

Authentication is handled by flask-app-builder not superset. Also please use the triple blacktick when quoting errors.

Hi,
I have same issue. I use also followed the oficial docs instructions. But i get this error. I don't understand why.
Anyone can already this issue?
2017-08-08 16:51:46,353:WARNING:werkzeug: * Debugger is active!
2017-08-08 16:51:46,353:INFO:werkzeug: * Debugger PIN: 691-843-783
2017-08-08 16:51:49,358:INFO:werkzeug:<IP_ADDRESS> - - [08/Aug/2017 16:51:49] "GET / HTTP/1.1" 302 -
2017-08-08 16:51:49,437:INFO:werkzeug:<IP_ADDRESS> - - [08/Aug/2017 16:51:49] "GET /superset/welcome HTTP/1.1" 302 -
2017-08-08 16:51:49,621:INFO:werkzeug:<IP_ADDRESS> - - [08/Aug/2017 16:51:49] "GET /login/ HTTP/1.1" 200 -
2017-08-08 16:51:59,737:ERROR:flask_appbuilder.security.manager:(2, 'No such file or directory')
2017-08-08 16:51:59,739:INFO:werkzeug:<IP_ADDRESS> - - [08/Aug/2017 16:51:59] "POST /login/ HTTP/1.1" 302 -
2017-08-08 16:51:59,804:INFO:werkzeug:<IP_ADDRESS> - - [08/Aug/2017 16:51:59] "GET /login/ HTTP/1.1" 200 -

@mauriciozambretti
I have same issue. Have you find any solution for Ldap connexion?
Thanks

You should open an issue on the FAB side
https://github.com/dpgaspar/Flask-AppBuilder

To everyone aiming at enabling LDAP for Superset, consider reading the corresponding Flask-AppBuilder documentation page and applying the corresponding changes in the Superset configuration.

https://ranying666.github.io/2019/06/06/superset-ldap/


Document backend commands/operations to help separate frontend/backend

@thadguidry is currently using Structure101 to begin documenting what will be the backend API.
However mostly this is already documented from a high-level in /main/webapp/modules/core/MOD-INF/controller.js

A first mapping is available on the page 5 of OpenRefine Batch Processing with Apache Beam document.

Just noting that the backend and frontend are separated - there is no particular coupling to be undone as far as I am aware. Unless someone has a clear example of what they find problematic?
That being said we can always document the existing API commands, that definitely cannot hurt.

I think @tcbuzor found some coupling... will ask him to comment here.
@jackyq2015 was the one who originally was speaking about this.  Is he still around to comment?

I propose we close this in a few weeks unless anyone can come up with a concrete coupling issue.

The problem is that you can't deploy backend services and frontend separately, they are tightly coupled

That is not what I would call backend/frontend coupling… That would be the case if the backend was rendering HTML there directly, which is not the case: it just serves a single-page app which then does API calls to interact with the frontend. So I don't see any big architectural issue here.
The fact that the frontend is served on the same web server as the backend is desired (you want them to be served on the same port). The concrete separation between the two parts will change when we migrate out of Butterfly.
If we agree that Butterfly is the issue here, can we stop calling that "coupling" and use "migrate out of Butterfly" instead?

yes, "migrate out of butterfly" is the issue that i see also

closing this issue... we have a better roadmap now


[SP-4631] Backport of PDI-17345 - Adding/Removing a checkpoint causes…

… duplication of  tag (8.1 Suite)
@pentaho-lmartins @cravobranco @ricardosilva88

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,core,plugins/pur/core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core,plugins/pur/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/xml/XMLHandler.java
  core/src/test/java/org/pentaho/di/core/xml/XMLHandlerUnitTest.java
  engine/src/main/java/org/pentaho/di/core/attributes/AttributesUtil.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryBase.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryCopy.java
  engine/src/test/java/org/pentaho/di/core/attributes/AttributesUtilTest.java
  plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/AttributesMapUtil.java
  plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/JobDelegate.java
  plugins/pur/core/src/test/java/org/pentaho/di/repository/pur/AttributesMapUtilTest.java
  plugins/pur/core/src/test/java/org/pentaho/di/repository/pur/JobDelegateTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entry.JobEntryCopy

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.3% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.sort.SortRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.repository.pur.AbstractDelegate

Branch Change: -6.7% :small_red_triangle_down:
Complexity Change: -6.7% :small_red_triangle_down:
Instruction Change: -1.9% :small_red_triangle_down:
Line Change: -3.6% :small_red_triangle_down:

org.pentaho.di.repository.pur.AttributesMapUtil

Branch Change: -31.1% :small_red_triangle_down:
Complexity Change: -23.8% :small_red_triangle_down:
Instruction Change: -28.9% :small_red_triangle_down:
Line Change: -24.7% :small_red_triangle_down:

org.pentaho.di.repository.pur.JobDelegate

Branch Change: -5.4% :small_red_triangle_down:
Complexity Change: -4.3% :small_red_triangle_down:
Instruction Change: -13.2% :small_red_triangle_down:
Line Change: -14.2% :small_red_triangle_down:
Method Change: -14.3% :small_red_triangle_down:

org.pentaho.di.repository.pur.RepositoryProxy

Branch Change: -6.1% :small_red_triangle_down:
Complexity Change: -1.4% :small_red_triangle_down:
Instruction Change: -3.3% :small_red_triangle_down:
Line Change: -2.7% :small_red_triangle_down:
Method Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/main/java/org/pentaho/di/job/entry/JobEntryCopy.java. Found 2017. Was expecting 2018

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'engine,core,plugins/pur/core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core,plugins/pur/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/xml/XMLHandler.java
  core/src/test/java/org/pentaho/di/core/xml/XMLHandlerUnitTest.java
  engine/src/main/java/org/pentaho/di/core/attributes/AttributesUtil.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryBase.java
  engine/src/main/java/org/pentaho/di/job/entry/JobEntryCopy.java
  engine/src/test/java/org/pentaho/di/core/attributes/AttributesUtilTest.java
  plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/AttributesMapUtil.java
  plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/JobDelegate.java
  plugins/pur/core/src/test/java/org/pentaho/di/repository/pur/AttributesMapUtilTest.java
  plugins/pur/core/src/test/java/org/pentaho/di/repository/pur/JobDelegateTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes.


Add REST documentation

Summary
Add REST documentation
Checklist

[x] I have run nox and all the pipelines have passed.
[x] I have made unittests according to the code I have added/modified/deleted.

Related issues
Closes #42

LGTM, just a few typos that need fixing and one or two comments. Ping me when you've amended those and I'll approve it :+1:

@nekokatt all fixed :+1:


Implement AI Features and Performance Optimizations

This Pull Request introduces significant updates to the pyqlib project, integrating advanced AI features to enhance its capabilities. The main focus of these updates includes:

AI Integration and Enhancements:

Azure OpenAI Integration: The script now includes functionality to integrate with Azure OpenAI services. This allows for advanced AI models to be utilized, enhancing the platform’s ability to process and analyze data.
Model Argument Preparation: Enhanced preparation of model arguments to include AI-specific parameters such as temperature, max tokens, and streaming options, ensuring optimized interactions with AI models.

Microsoft Defender for Cloud Integration:

User Data Handling: Integration with Microsoft Defender for Cloud is enabled, allowing for enhanced security and user data management. This includes fetching and utilizing authenticated user details and integrating security features directly within the application.

CosmosDB Client Initialization:

AI-Driven Data Handling: The CosmosDB client initialization has been updated to support AI-driven data processing. This includes handling conversation data and feedback more effectively, leveraging Azure’s cloud capabilities for scalable and efficient data management.

Cython Extensions for Performance:

C++ Extensions: Added Cython extensions for performance improvements in data processing tasks. These extensions are implemented in C++ and are crucial for optimizing performance in computationally intensive operations.

Dependencies and Requirements:

Updated Dependencies: Updated package dependencies to include necessary libraries for AI and data processing, ensuring compatibility with the latest AI tools and frameworks.

These updates aim to significantly enhance the capabilities of the pyqlib platform by incorporating cutting-edge AI technologies and improving data processing and security features. The integration of Azure OpenAI and Microsoft Defender for Cloud not only adds advanced AI functionalities but also ensures robust security and data management.

Description

Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[ ] Add new feature
[ ] Update documentation

This pull request introduces new AI features and enhancements to the pyqlib repository. The primary updates include:

AI Integration:

Azure OpenAI: Integrated support for Azure OpenAI services, allowing the platform to leverage advanced AI models for improved data analysis and interaction.
Model Parameters: Updated the model argument preparation to include parameters like temperature, max tokens, and streaming options for better control over AI model behavior.

Microsoft Defender for Cloud:

Security Enhancements: Added integration with Microsoft Defender for Cloud to enhance security and manage user data effectively.
User Data Handling: Implemented functionality to handle authenticated user details securely and integrate security features within the application.

CosmosDB Client Improvements:

Data Processing: Enhanced CosmosDB client initialization to support AI-driven data processing and manage conversation data and feedback more efficiently.

Performance Optimization:

Cython Extensions: Added Cython extensions to optimize performance for data processing tasks, utilizing C++ for improved computational efficiency.

Dependency Updates:

Updated Libraries: Updated dependencies to ensure compatibility with the latest AI tools and frameworks, including necessary libraries for AI and data processing.

Details:

The integration with Azure OpenAI adds advanced AI capabilities to pyqlib, enhancing its functionality for data analysis.
Microsoft Defender for Cloud integration improves security and user data management.
Performance improvements through Cython extensions ensure more efficient data processing.
Updated dependencies support the latest AI features and tools.

Thank you!


ScrollViewer doesn't show scrollbars sometimes with SizeToContent

If you take the following XAML:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:idc="clr-namespace:ControlCatalog.ProportionalStackPanel"
        x:Class="ControlCatalog.MainWindow"
        SizeToContent="WidthAndHeight">
  <ScrollViewer>
    <Border Height="12000" Width="20" Background="Red" />
  </ScrollViewer>
</Window>

and run on Windows the content is displayed without a scrollbar, even though the full Border isn't visible.

related to: https://github.com/zkSNACKs/WalletWasabi/issues/3462

This happens because the window has SizeToContent="WidthAndHeight" set, which causes the controls in the Window to be measured with Size.Infinity. When the window is arranged, Avalonia then tries set to a height of 12000 which is larger than the maximum window height allowed by the OS.
This causes the Arrange pass to be invoked with a finalSize of less than the DesiredSize of ScrollViewer. The template for ScrollViewer contains a Grid, and Grid does not like this: seems that if you arrange a Grid with a size less than its DesiredSize, it will ignore the request and just use DesiredSize.
This doesn't cause a problem in WPF, because a Window's content is measured with the max window size instead of infinity.

There are a few solutions I can see to this:

Measure the window with the max client size instead of infinity. We used to do this, but that behavior was changed by https://github.com/AvaloniaUI/Avalonia/pull/1021 - unfortunately there's no explanation of why it was changed

Maybe it would be tricky to do x-plat and accounting for multiple monitors? The backends currently have a [naive implementation[(https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.X11/X11Window.cs#L918) which doesn't look like it would work well with multiple monitors -- @kekekeks ?

Measure the window twice, once with infinity and then again if, after setting the window size, it's not what we requested

Would result in two measure passes

Fix Grid

Might be a good idea, but do we want to risk changing Grid's behavior from that of WPF?

I'd bet that very few if anyone is relying on this behavior in Grid, maybe if we fixed it, but all the existing grid tests still passed it would be acceptable to fix this in Grid... might turn out thats not possible though.

If there is a nice easy fix, we can also submit it to WPF repo

Maybe it would be tricky to do x-plat and accounting for multiple monitors

We'll need MaxClientSizeChanged event then.

Also, keep in mind that MaxClientSize isn't a hard limit: window can be manually resized to a larger size. It's mostly needed for auto-sizing purposes.

We'll need MaxClientSizeChanged event then.

Yep, that's solution 2 in https://github.com/AvaloniaUI/Avalonia/issues/3791#issuecomment-614809655 - and yeah it is a giant hack ;)

I have tested @danwalmsley wasabi branch which updates avalonia, and here the scrollbar issue is fixed!
ACK and thank you all!