Add defaulting support for ratelimiters in MCP options.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS [ayj,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

prow/istio-unit-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

prow/istio-unit-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

prow/istio-unit-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

prow/istio-unit-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

prow/istio-unit-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test e2e-simpleTests-cni

prow/istio-unit-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks like the mcp unit test harness had a race int it (note: not the production code itself). The change below should fix the problem.
diff --git a/pkg/mcp/source/source_test.go b/pkg/mcp/source/source_test.go
index 1be33f0fe..87825c3de 100644
--- a/pkg/mcp/source/source_test.go
+++ b/pkg/mcp/source/source_test.go
@@ -203,11 +203,7 @@ func (h *sourceTestHarness) Watch(req *Request, pushResponse PushResponseFunc) C
                ch <- struct{}{}
        }

-       return func() {
-               h.mu.Lock()
-               defer h.mu.Unlock()
-               delete(h.watchResponses, req.Collection)
-       }
+       return func() {}
 }

 func (h *sourceTestHarness) injectWatchResponse(response *WatchResponse) {
@@ -220,6 +216,7 @@ func (h *sourceTestHarness) injectWatchResponse(response *WatchResponse) {
                for _, watch := range watches {
                        watch(response)
                }
+               delete(h.pushResponseFuncs, collection)
        } else {
                h.watchResponses[collection] = response
        }

$ go test ./pkg/mcp/source/... -race -count=100
ok  	istio.io/istio/pkg/mcp/source	405.158s

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e87e3eedbc973105dfe657639a052823e2ff32a1
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj, ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kyessenov
If they are not already assigned, you can assign the PR to them by writing /assign @kyessenov in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/mcp/OWNERS [ayj,ozevren]
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ayj, ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ayj,ozevren]
pkg/mcp/OWNERS [ayj,ozevren]
tests/e2e/tests/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
24e58e782293258201ab81d937ed599a5ea5a41f
link
/test e2e-simpleTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests.sh
24e58e782293258201ab81d937ed599a5ea5a41f
link
/test e2e-simpleTests

prow/e2e-simpleTests-cni.sh
24e58e782293258201ab81d937ed599a5ea5a41f
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-integ-k8s-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e_pilotv2_auth_sds.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
7819d6bec91ae5ee8cb8e938c70154a4cd8c284e
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ayj, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

galley/OWNERS [ayj,ozevren]
pkg/mcp/OWNERS [ayj,ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
e4fe286d62538615eed6abd944ffe675f7f3c08d
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rometheus-646dbcbbbf-tc47c               0/1       Init:0/1   0          16m

@ozevren: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test e2e-mixer-no_auth

prow/e2e_pilotv2_auth_sds.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
53f33d1c431b1c5071f56e2c3836458a58e03414
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


feat[CL]: integrate superfluid slashing and locks

Closes: #4840
What is the purpose of the change
We initially wanted to reimplement freezing when migrating positions. This was so that, in the event of a slashing event, we could retroactively slash accounts that were in the migration period. This felt like a really bad design, and also felt like it was resting on the assumption that a slashing event was not going to happen.
This PR instead implements locks in place of freezing logic. This does twofold:

If a user was locked and not superfluid staked, they migrate and begin unlocking from where they started
If a user was locked and superfluid staked, they migrate their superfluid position and begin unlocking from where they started

In the event of a slash, the user's concentrated lock gets slashed which represents the liquidity they have within their position's state entry. When that lock is slashed, it updates the underlying position state entry accordingly.

More on concentrated locks!
Concentrated locks behave differently than normal locks. Normal locks, once unlocked and fully mature, send the locked funds back to the user. In our case, we are creating tokens (of denom cl/pool/{poolID}/{positionID}) that are not meant to be traded / sent, and are solely used to track the underlying state entry liquidity. This also serves as a link between superfluid slashing and state entry liquidity (non-tokenized).
Side note to self: Maybe we shouldn't do this. Maybe we should still follow the exact same path for everything lock wise, and only pull the funds at the last moment when matured.
Brief Changelog

Reorders lockupKeeper to be before concentratedKeeper, since concentratedKeeper now relies on it
Adds underlyingLockId to the Position proto

This is the state entry that links a lock from the lockup module to a single position in the cl module
If set to 0, this implies the position was either never locked or the lock has matured

Withdraw position no longer allows a user to withdraw if their position has an underlying lock that has not matured (TODO: Make it so that we check the liquidity trying to be withdrawn vs the liquidity locked. There may be cases where a subset of the position should be withdraw-able)
Adds CreateConcentratedLock, which is a normal lock but it just does not send the underlying funds to the lockup module account
Exports SetPosition in CL, as it must be accessible to superfluid  when migrating (updates the underlying lock ID to the newly created concentrated lock)
Adds CreateFullRangePositionUnlocking which is used in locked or unlocking gamm position migrations. As soon as we migrate their position, we begin unlocking the newly created concentrated lock
Adds logic to unlockFromIterator that does not sum coins that come from concentrated locks
Core logic for not sending cl tokens to user is added in unlockMaturedLockInternalLogic
Adds SlashTokensFromLockByIDForConcentratedLocks, which the only difference from the normal slashing logic is instead of sending the shares like gamm pools does, it figures out what the underlying coins are represented by the liquidity value and sends that underlying to the community pool instead
UnlockAndMigrate in superfluid needs to be heavily reviewed
slashSynthLocks adds separate branch for concentrated locks

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

Side note to self: Maybe we shouldn't do this. Maybe we should still follow the exact same path for everything lock wise, and only pull the funds at the last moment when matured.

What is the full scope of this alternative?


Intercept ICY onMetadataChanged calls

This question is based on an idea from a closed issue thread (see #258)

In order to update the media item (audio stream) metadata from a different source other than the initial or in-stream metadata, we've used a ForwardingPlayer like suggested, see https://github.com/androidx/media/issues/258#issuecomment-1453449978
So far it works quite well, but somehow the ICY metadata keeps getting delivered to listers that attach to the MediaController build from the Session which uses the ForwardingPlayer. (The notification e.g. only shows the metadata I propagate and not the ICY metadata)
I assumed that the ForwardingPlayer subclass which is passed to new MediaSession.Builder(...), would be the MediaController I get with MediaController.Builder(context, mediaSessionToken), but that doesn't seem to be the case.

The icy metadata is quite limited and we try to present only the richer information from an external API, but we might need the icy metadata as a trigger, though. So we can't totally block any icy onMediaMetadataChanged calls from within the actual player.
The idea based on the suggestion was, catch onMediaMetadataChanged calls in the ForwardingPlayer (maybe use them as a trigger to fetch 'richer' metadata from an api) and then call onMediaMetadataChanged with custom metadata on every attached listener.

}

Session
class SessionService : MediaLibraryService() {

    override fun onCreate() {
        mediaSession = MediaLibrarySession.Builder(this, MetadataForwardingPlayer(actualPlayer), callback).build()
        (...)
    }
    (...)
}

Controller
private val mediaSessionToken: SessionToken = SessionToken(context, ComponentName(context, sessionServiceClass))

private val mediaControllerFuture = MediaController.Builder(context, mediaSessionToken).buildAsync()

This is the problematic line:
override fun addListener(listener: Player.Listener) {
    super.addListener(listener.also { listenerSet.add(it) })
}

Because if I have a handle to your MetadataForwardingPlayer and I call addListener then the listener I register is registered directly on the delegate Player, so any calls that the underlying player makes to onMediaMetadataChanged will propagate out to my listener.
Instead of directly passing this listener to the delegate, you will need to wrap it in a Player.Listener implementation that drops all onMediaMetadataChanged calls from the delegate player on the floor. If you do this, you need to be careful of how you handle removeListener too, in terms of forwarding it to the delegate (because it's expected to pass the same Listener instance to both addListener and removeListener). See how ForwardingPlayer.ForwardingListener overrides equals in order to make this work:
https://github.com/androidx/media/blob/e268a2e1e2ffac4a13bb655e8f924b65466a20be/libraries/common/src/main/java/androidx/media3/common/ForwardingPlayer.java#L1124-L1135

Yes right, now I get it.
Really appreciate the help, thank you!

Reopening this issue, because I've stumbled upon some strange behaviour regarding bluetooth devices and metadata updates. This might be worth a separate ticket, but as its closely related to the things described above so I'll start with reopening this one.

The implementation described above works perfectly fine for my use case, the only issue I've got is related to bluetooth devices that are able to display metadata (e.g. car consoles). It seems like those devices do not receive the custom metadata calls we trigger, they get stuck after the first metadata update they receive and only update when the player state changes.
Is there a way to trigger custom metadata updates on bluetooth devices as well?


Add Tenderize

Revision checks

[x] Your Safe App include a manifest.json file at the root with the required data
[x] The app can be loaded as a custom Safe App in the Apps section of https://gnosis-safe.io/app
[x] The app auto-connects to the Safe
[x] You are able to trigger and execute one transaction with a Safe
[x] RPC requests are optimized (not triggering many requests in a very short time period)

Name/Description
Tenderize
Connecting web3 with DeFi through liquid staking

Type

New addition

Compatible Networks

- Mainnet
- Arbitrum

Code for review

https://github.com/Tenderize/tender-app
contracts: https://github.com/Tenderize/tender-core
deployed addresses: https://docs.tenderize.me/contracts/deployments
IPFS hash/App URL

https://app.tenderize.me
Desired date

a coordinated anouncement should be set together with the app launch, we can provide a draft for this

Is there information about audits?

Hi @mikhailxyz , see https://blog.tenderize.me/tenderize-passes-hacken-audit-with-a-9-8-10/

Hola guys! Starting my testing with the app. I can see that the Tenderize icon is completely white which kind of conflicts with our white background, looking as if there where none:

If by any chance you have an alternative one I think the app would look cooler on the list :)

Hi @JagoFigueroa thanks for the feedback !

The error is fixed in our latest release which we cut yesterday. It is because the default token being loaded is on arbitrum (LPT) but the safe is connected  to mainnet. We now prevent firing hooks when on the wrong chain.

The UX indeed seems stuck. We have noticed that through gnosis safe it takes a long time before the transaction status shows as confirmed from the app POV whereas it has already confirmed for 30 seconds or so in reality.  We're investigating the issue https://github.com/Tenderize/tender-app/issues/287

For the approval, we do the check based on the input. If you were to input an amount to deposit again it would disappear. We'll consider changing this behaviour so that the approve button isn't displayed when the input field is empty. https://github.com/Tenderize/tender-app/issues/291

When adding liquidity the button should have been disabled when both input fields are not filled out, we'll fix this ASAP. https://github.com/Tenderize/tender-app/issues/290

We'll let you know when these issues are addressed, thanks again !

Hi @JagoFigueroa
Our latest release includes fixes for https://github.com/Tenderize/tender-app/issues/291 and https://github.com/Tenderize/tender-app/issues/290
However after investigation of https://github.com/Tenderize/tender-app/issues/287 it does seem that the transaction does eventually confirm when it confirms in the gnosis safe. Since I believe this uses the provider injected by gnosis safe I think there's little we can do to speed it up I think.
Our graphic designer is currently on holiday but I'll revert to her asap about a better suiting logo format when she's back.

Morning guys! Here with my second round of testing. Can confirm that most of the issues above have been fixed :)
The only thing that I still can see is the console error popping on the safe app. Not too worrisome as I can see it fixed on the dapp itself so it should be a matter of time for the fix to pop up for the safe app.
Another potential issue / edge case I noticed is this one:

Trying to swap my staked tMATIC for MATIC:

https://user-images.githubusercontent.com/92332710/175878987-6cbfa8d7-a8f4-4dce-a207-b3469a2f78ab.mp4
My guess is that it is expected to not be possible to swap staked assets but I feel like some visual feedback is missing is here. Shouldn't maybe the staked tMATIC be hidden (for example) to avoid this scenario of trying to create a tx that shouldn't be possible to create?
I can see this staked tokens also pop up when trying to add liquidity:

Which I think it can be quite tricky for users too.
Cheers!

Hi @JagoFigueroa sorry for getting back so late on this. In the meantime the issues should have been resolved.
Gnosis safe confirmations still take a little bit longer than in our regular app but are coming through.
Mind giving this another look ? Many thanks !
Also I've noticed that some of our tokens show up in the gnosis safe assets , some don't. How can we make sure all of them are included ?

Morning! No worries at all, I'll give the app a second look during the day :)
Regarding the missing tokens, the infra team would be the one to reach. Let me talk to them for the proper way to report token additions and I'll get back to you.
Cheers!

I am still experiencing some issues on mainnet when trying to swap my tMATICs for MATIC (or the other way around, last time I remember being able to do it) :(

Could you have a look? the tx confirmation pop up is still not popping up for me after the screenshot above.

@JagoFigueroa Sorry you're right, I missed one boolean condition ! Should be fixed now.
They are all ERC-20 tokens (as minimal EIP-1165 proxies), it's weird that it picked up those for tGRT but not the others.

I came across this article https://help.gnosis-safe.io/en/articles/4261681-add-an-erc-20-token-to-the-safe-token-list
Is there any way we can provide this information so that the tokens are added to the list ?
They're not on coingecko (yet, it's pending)

Hey @JagoFigueroa I've added a new logo that might be better suited.

Much nicer now, thanks!
I will let the team know so that they give the app a final check and should be all good to be added to the list.
Cheers ;)

Great, thanks ! Who do I best contact regarding a co-announcement on e.g. twitter ?

Morning! Unfortunately this is not something that we do for safe app additions. Of course you are more than welcome to do an announcement from your side :)
App should be added shortly (we will notify you in this ticket)
Cheers!

Okay we'll just do the announcement and short demo from our side then , looking forward to see it listed ❤

App should be soon available in the list
Thank you


validate header, to prevent junk blocks

Closes 1172

Go-header v0.3.0 does the check automatically


Refactor auth to use react-router-oauth module

over the course of the past few weeks, @cowboy and i have worked on writing the nest service catalog in react and one milestone is ben's new react-router-oauth module (https://github.com/bocoup/react-router-oauth) which i plan to implement here in people

woot! can't wait to see it


Fix dtrace implementation

With -c we should pid == $target instead of trying to match the
executable name. This is more performant and more correct as it
will only match exactly this process not any process with this
name.

Nice reduction of complexity, thanks!


BUG: can not git clone repo

Sealos Version
laster
How to reproduce the bug?
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:
'service/license/src/components/Account/index.tsx'
'service/license/src/components/account/index.tsx'
'service/license/src/components/Signin/auth/useAuthList.tsx'
'service/license/src/components/signin/auth/useAuthList.tsx'
'service/license/src/components/Signin/auth/useCustomError.tsx'
'service/license/src/components/signin/auth/useCustomError.tsx'
'service/license/src/components/Signin/auth/useLanguage.tsx'
'service/license/src/components/signin/auth/useLanguage.tsx'
'service/license/src/components/Signin/auth/usePassword.tsx'
'service/license/src/components/signin/auth/usePassword.tsx'
'service/license/src/components/Signin/auth/useProtocol.tsx'
'service/license/src/components/signin/auth/useProtocol.tsx'
'service/license/src/components/Signin/auth/useSms.tsx'
'service/license/src/components/signin/auth/useSms.tsx'
'service/license/src/components/Signin/background.tsx'
'service/license/src/components/signin/background.tsx'
'service/license/src/components/Signin/index.tsx'
'service/license/src/components/signin/index.tsx'
What is the expected behavior?
git clone repo
What do you see instead?
No response
Operating environment
1

Additional information
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:
'service/license/src/components/Account/index.tsx'
'service/license/src/components/account/index.tsx'
'service/license/src/components/Signin/auth/useAuthList.tsx'
'service/license/src/components/signin/auth/useAuthList.tsx'
'service/license/src/components/Signin/auth/useCustomError.tsx'
'service/license/src/components/signin/auth/useCustomError.tsx'
'service/license/src/components/Signin/auth/useLanguage.tsx'
'service/license/src/components/signin/auth/useLanguage.tsx'
'service/license/src/components/Signin/auth/usePassword.tsx'
'service/license/src/components/signin/auth/usePassword.tsx'
'service/license/src/components/Signin/auth/useProtocol.tsx'
'service/license/src/components/signin/auth/useProtocol.tsx'
'service/license/src/components/Signin/auth/useSms.tsx'
'service/license/src/components/signin/auth/useSms.tsx'
'service/license/src/components/Signin/background.tsx'
'service/license/src/components/signin/background.tsx'
'service/license/src/components/Signin/index.tsx'
'service/license/src/components/signin/index.tsx'

The error you're encountering is related to case-sensitive paths on a case-insensitive filesystem, which is common on filesystems like those used by macOS and Windows. These filesystems treat files with names that differ only by case as the same file, leading to conflicts.


Navigation texts didn't get translated

Hello, and thanks for your work.
I had set up several languages and changed default language.
Then I added some .yml files to language folder. Lot of texts got translated but nav texts don't change. Ie: Index, Tags, Categories, etc.. stay in English.
thanks again

@lupa18 Navigation text is written on the theme _config.yml  file, you can change it to any text you want.

Hello @blinkfox !
As I can see, it's actually configured in navigation.ejs Both languages seems to be configured there, hard coded.
Then, in languages/default.yml text keys are available.
Maybe some could be changed there to call text keys from land yml and got multi-language working?

@lupa18 The design purpose of the navigation menu at the time was to allow users to customize the menu name, so instead of reading the text in languages, the user was allowed to set the menu name in _config.yml, the following is my custom Menu name:
menu:
  My Index:
    url: /
    icon: fas fa-home
  My Tags:
    url: /tags
    icon: fas fa-tags
  My Categories:
    url: /categories
    icon: fas fa-bookmark
  My Archives:
    url: /archives
    icon: fas fa-archive
  关于我们:
    url: /about
    icon: fas fa-user-circle
  联系我们:
    url: /contact
    icon: fas fa-comments
  Friends Link:
    url: /friends
    icon: fas fa-address-book

ok, thanks. I'm not sure how to make it compatible with a multi lingual site :-/
thanks !


Keep find my mouse on until turned off

Description of the new feature / enhancement
Expected behavior: a way to toggle the find my mouse display on and keep it on even through mouse clicks or keyboard interaction until toggled off again.
Scenario when this would be used?
To enhance visibility of the mouse; For accessibility
Supporting information
No response

Yes, this has been requested quite a number of times actually. I'm thinking something like
Dismiss:

- after 3 seconds of no activity
- on any key press or mouse click
- by pressing Esc

Duplicate of #14448

/dup #14448


References on transformer 4.4 and pytorch 1.6 but image version no longer exists on ECR

Instructions on https://github.com/aws/sagemaker-huggingface-inference-toolkit suggests the following:
# create Hugging Face Model Class
huggingface_model = HuggingFaceModel(
    transformers_version='4.4',
    pytorch_version='1.6',
    env=hub,
    role=role,
    name=hub['HF_MODEL_ID'],
)

However it comes back with "The image '763104351884.dkr.ecr.us-east-1.amazonaws.com/huggingface-pytorch-inference:1.7.1-transformers4.4-gpu-py36-cu110-ubuntu18.04' does not exist.."
I found this blog that references a different transformer and pytorch version:
https://aws.amazon.com/blogs/machine-learning/announcing-managed-inference-for-hugging-face-models-in-amazon-sagemaker/
# create Hugging Face Model Class
huggingface_model = HuggingFaceModel(
   model_data="s3://bucket/model.tar.gz", # S3 path to your trained sagemaker model
   role=<SageMaker Role>, # IAM role with permissions to create an Endpoint
   transformers_version="4.6", # transformers version used
   pytorch_version="1.7", # pytorch version used
   py_version="py36", # python version of the DLC
)

Could you update this repo to prevent further confusion?

can be closed @vdantu


Add screenshot features for linux and win32

Sharing for reference. Hopefully can serve as a starting point, not sure I can figure out much more myself.

Linux

[x] Visible
[x] Full document

Win32

[x] Visible
[ ] Full document: no luck

https://github.com/MicrosoftEdge/WebView2Feedback/issues/529#issuecomment-772540317

WinRT: haven't looked at.
Macos

[x] Visible
[ ] Full document: not sure yet

I update the snapshot handler on mac and now it can handle the snapshot now.
The next thing to do is to convert UIImage to bytes.

okay, now basic mac support is also done.
While we are exploring full document on mac, I feel like we should think about the API too.
It also supports PNG at the moment. It feels weird to pass a vector of bytes.
Perhaps the parameter should just be a path to create the file?

Great stuff @wusyong

I feel like we should think about the API too.
It only supports PNG at the moment. It feels weird to pass a vector of bytes.
Perhaps the parameter should just be a path to create the file?

The current API was a dirty hack to get some image from A to B :smile:.
For many browser implementations, they offer saving to file, but also copy to clipboard. And some apps may want to do their own processing of the image? Being able to grab some image buffer could have some utility.
So that's why I thought about passing some platform independent image handle to the callback.
Bonus that the platform specific screenshot implementations don't need to include file IO.

If that's so, I think we could pass an image type we define instead of vector then.
It could provide methods to create file, copy to clipboard and support many other file formats.

Yeah that sounds good to me.
Possibly we could get rid of the cairo png dependency for Linux with that as well at least in the screenshot stage.


Support typechecking through_defaults for ManyToManyField

From the relevant django documentation section:
beatles.members.add(john, through_defaults={"date_joined": date(1960, 8, 1)})

It would be nice if django-autotyping could verify that date_joined belongs on the Membership model and that the value is the correct type.

Thanks for the feature request, I'll try to see if it's possible to work on it next week.


Added Add & Clear function to World, Model, and Link

Signed-off-by: Nate Koenig<EMAIL_ADDRESS>🎉 New feature
Summary
Add functions that allow adding SDF elements to World, Model, and Link DOM objects.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[x] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[x] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Codecov Report

Merging #765 (1d67954) into sdf12 (b95f44d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            sdf12     #765      +/-   ##
==========================================
+ Coverage   89.15%   89.23%   +0.08%
==========================================
  Files          76       76
  Lines       12001    12081      +80
==========================================
+ Hits        10700    10781      +81
+ Misses       1301     1300       -1

Impacted Files
Coverage Δ

src/Link.cc
97.16% <100.00%> (+0.50%)
:arrow_up:

src/Model.cc
90.31% <100.00%> (+0.78%)
:arrow_up:

src/World.cc
93.73% <100.00%> (+0.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95f44d...1d67954. Read the comment docs.


Unclear Terminology: Settings / Preferences / Configure / Customize

Testing #127319.
We now use the terms Settings, Preferences, Configure and Customize in commands.
They all refer to the same thing, which makes searching for the right Command hard.
Also see #95202.

Similar to https://github.com/microsoft/vscode/issues/127303

probably needs a solution with better command palette search since the names are what they are for a while


crossCompilation working to 2.12

A few tests dependent on specific values of hashing were specific enough on 2.11 that they failed on 2.12. Now these tests were modified so that the expected messages from exceptions can be either a  2.11 message or 2.12 message (no pattern match).
Target jvm1.8 was not working below 2.11.5.
Recommendations

get Travis CI to do a sbt + package and if it fails, fail a PR.
revisit set of scala compiler versions needed to support for this project, including default such as 2.11.8.

Current coverage is 96.87% (diff: 100%)

Merging #53 into master will decrease coverage by 0.54%

@@             master        #53   diff @@
==========================================
  Files            12         12
  Lines           658        544   -114
  Methods         576        480    -96
  Messages          0          0
  Branches         82         64    -18
==========================================
- Hits            641        527   -114
  Misses           17         17
  Partials          0          0

Powered by Codecov. Last update c8d2859...7312460

Current coverage is 96.87% (diff: 100%)

Merging #53 into master will decrease coverage by 0.54%

@@             master        #53   diff @@
==========================================
  Files            12         12
  Lines           658        544   -114
  Methods         576        480    -96
  Messages          0          0
  Branches         82         64    -18
==========================================
- Hits            641        527   -114
  Misses           17         17
  Partials          0          0

Powered by Codecov. Last update c8d2859...7312460

I'd suggest to refactor those tests so that the code is shorter, Set(...).map(...) should contain ...
Other than that, looks good.

I'd suggest to refactor those tests so that the code is shorter, Set(...).map(...) should contain ...
Other than that, looks good.

I'll address your suggestion to make code cleaner and avoid excessive duplication.

I'll address your suggestion to make code cleaner and avoid excessive duplication.


[Bug] DisconnectionHandler Future inside ValueListener's OnValueChanged never completes.

[REQUIRED] Please fill in the following fields:

Pre-built SDK from the website or open-source from this repo: Pre-built SDK from the website
Firebase C++ SDK version: 8.8.0
Problematic Firebase Component: Database
Other Firebase Components in use: Auth, Firestore
Platform you are using the C++ SDK on: Windows
Platform you are targeting: Desktop

[REQUIRED] Please describe the issue here:
If i have DisconnectionHandler inside OnValueChanged function of ValueListener, it's future never complete and times out, but outside DisconnectionHandler somewhere else works fine.
(Please list the full steps to reproduce the issue. Include device logs, Unity logs, and stack traces if available.)
Steps to reproduce:
Debug Logs:
DEBUG: [pc_0] Authentication success
DEBUG: [pc_0] Restoring outstanding listens
DEBUG: [conn_0] Sending data: {"d":{"a":"o","b":{"d":{"last_changed":"2022-01-13T18:27:00","state":"offline"},"p":"status/userid"},"r":3},"t":"d"}
DEBUG: [conn_0] Sending data: {"d":{"a":"o","b":{"d":{"last_changed":"2022-01-13T18:27:02","state":"offline"},"p":"status/userid"},"r":4},"t":"d"}
DEBUG: [conn_0] Sending data: {"d":{"a":"o","b":{"d":{"last_changed":"2022-01-13T18:27:02","state":"online"},"p":"status/userid"},"r":5},"t":"d"}
DEBUG: [conn_0] websocket message received
DEBUG: [conn_0] ProcessMessage (length: 43)
DEBUG: [conn_0] received data message
DEBUG: [pc_0] Trigger handler for request 3
DEBUG: [conn_0] websocket message received
DEBUG: [conn_0] ProcessMessage (length: 43)
DEBUG: [conn_0] received data message
DEBUG: [pc_0] Trigger handler for request 4
DEBUG: [conn_0] websocket message received
DEBUG: [conn_0] ProcessMessage (length: 43)
DEBUG: [conn_0] received data message
DEBUG: [pc_0] Trigger handler for request 5
Have you been able to reproduce this issue with just the Firebase C++ quickstarts ?
What's the issue repro rate? (eg 100%, 1/5 etc)
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
If you have a downloadable sample project that reproduces the bug you're reporting, you will
likely receive a faster response on your issue.
Relevant Code:
class ConnectionValueListener : public ValueListener
{
public:
    void OnValueChanged(const firebase::database::DataSnapshot& snapshot) override
    {
        bool status = snapshot.value().AsBool().bool_value();

        if (!status) {
            return;
        }

        auto res = databaseRef.OnDisconnect()->SetValue(isOfflineForDatabase);

        if (res.error() == firebase::database::kErrorNone) {
            res = databaseRef.OnDisconnect()->SetValue(isOnlineForDatabase);
            return;
        }
    }

    void OnCancelled(const firebase::database::Error& error_code, const char* error_message) override
    {
        LogMessage("ValueListener canceled: " + std::to_string(error_code) + error_message);
    }
};

@arslaanzafar
May I know how you learn that the future timeout?
If you try to access the future right after this line
auto res = databaseRef.OnDisconnect()->SetValue(isOfflineForDatabase);

The future is definitely not ready since it is an async operation.
Could you show us the code about what you mean by outside DisconnectionHandler somewhere else works fine.?
Thank you,
Shawn


Page with url: false not retured by search.pages

Version
1.18.5
Platform
Linux
What steps will reproduce the bug?

Search for pages by tag in a JSX template (e.g. search.pages("update")).
Confirm that this works as expected.
Set url: false for those pages.

How often does it reproduce? Is there a required condition?
Reproduces every time.
What is the expected behavior?
I expect the behavior of search.pages to not change, as the documentation states that "[the page] is still visible by other pages, for example, in paginations"
What do you see instead?
The same call to search.pages that previously worked as expected now returns an empty array.
Additional information
I did some digging around the code. The Searcher gets a reference to this.pages in the Site constructor, then this.pages is later modified to remove pages with url === false. This looks like it would also modify the array that the Searcher got. Maybe the Searcher needs a copy of that array, not a reference to it? (Sorry if this analysis is wrong. My JavaScript skills are very rusty, and my TypeScript skills very new.)

I think the issue is in the documentation. Probably this is the old behavior and at some point this was changed but the documentation wasn't updated.
Reimplement this behavior is complicated, because search.pages() only returns HTML pages, Lume consider a page is HTML if the url contains the .html extension (no matter if it's normal URL /foo.html or pretty URL /foo/index.html). But pages with url as false cannot be considered HTML pages, even if they weren't removed from the site.pages array.
Why do you need this?

Ah, that makes sense. Thank you for the explanation!

Why do you need this? Maybe I can help you with a workaround.

I'm building a page with article-like pages that I want to keep updated. For each update, I want to display some information (date of the update, link to the page that was updated, and a short description of the update) in several places:

A "latest updates" list on the home page (already implemented)
An RSS feed (currently working on it)
A changelog on each updated page

Storing these updates as pages works well, as that gives me access via search.pages where I need it (except in the feed; might open another issue about that later :smile:) and allows me to store all relevant information as Markdown + front matter.
However, I don't actually want a page per update, hence url: false. My current workaround is to have a template for these updates that displays a 404-like page instead.
This works well enough, but it's not exactly pretty. And a "page" is the wrong abstraction to use anyway, since I don't actually want a page. I did it because I'm not aware of any better abstractions within Lume. But now that I think about it, I can just store those updates as regular files, load them using Deno APIs, and circumvent Lume completely. That's probably the better solution.

Okay. You can use the filter_pages plugin to filter the pages after rendering, so they are available on rendering but removed before being saved in the dest folder. For example:
// Assuming that all your articles have the `type=article` variable
site.use(filterPages({
  fn: (page) => page.data.type === "article"
}));

Oh, nice, thank you!
So many useful plugins. Hard to keep them all straight :smile:


Upgrade dependencies

[x] delete unused dependencies
node-persist, node-uuid & request where not used
[x] delete yarn.lock file
npm's package-lock.json was already present. using two different lockfiles tech could bring confusion to the devs.
[x] upgrade dependencies
nexmo => 2.4.0
dotenv => 6.1.0

Thanks for contributing to #Nextoberfest this month! Remember, if you want to get your T-Shirt, don't forget to fill the form!
https://www.nexmo.com/blog/2018/10/09/join-nextoberfest-tis-the-season-to-be-hacking-dr/

Already did, thank you @AlexLakatos!


refactor: rework image build and repo structure

Failed broken link check is expected.

Sounds reasonable :D

@wkloucek Thanks! I've changed all reverences to use ctx/config to get the repo name.

@xoxys https://drone.owncloud.com/owncloud-docker/smashbox/110 the starlark file is broken

Already fixed :)


"Slămnești" is listed in the drop-down menu

Description:
"Slămnești" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Slămnești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Slămnești, Argeș (Brăduleț)".


IIS of the application

hi, done installation in IIS of the application, when browsing folder, I get error, can you help?

should be http:  //localhost/SGI/ ICONES

I am thinking this is not an issue with the application but with how you have IIS setup.


feat(base16): allow to only use cterm colors

Make config.palette optional if config.use_cterm is provided as a table with cterm colors.
Resolve #456

[x] I have read CONTRIBUTING.md
[x] I have read CODE_OF_CONDUCT.md

Thanks for the PR!

my solution is simpler and more obvious and would make gui and cterm highlighting symmetrical, which IMO makes more sense than arbitrarily treating cterm highlighting as fallback-only second-class citizen, considering termguicolors is disabled by default

I appreciate the effort, but this is exactly what 'mini.base16' does and will keep doing: "gui highlighting" is the main concern for color scheme while "cterm highlighting" is a fallback. The reason for this is the ever growing number of people who use terminal emulators with "gui highlighting" support. This is now even more reasonable choice on Neovim>=0.10 as there is an automated 'termguicolors' detection depending on terminal emulator capabilities.
Closing as not planned.

The reason for this is the ever growing number of people who use terminal emulators with "gui highlighting" support

the goal is not to support terminal emulators without gui highlighting, but to avoid dublicating base colors for a terminal emulator and neovim and to make neovim's colors consistent with every other terminal application, which is one of the main selling points of base16.

this is not a good design choice to force users to hack around the plugin for no good reason.

Nobody forces anyone to hack anything. 'mini.base16' is a color scheme generator that applies highlight groups based on the supplied hex colors. Support for 0-15 colors is secondary. This is a design choice aimed for an easier long term maintainability.

This is a design choice aimed for an easier long term maintainability

based on the docs I didn't get that supplying hex colors is a core to mini.base16's design and I didn't think that making palette optional would hurt long term maintainability, I wouldn't submit this if I realized that, but I don't feel the full scope of your work of course, and I respect that. thanks for your consideration.


Performance and accessibility of the website

Upon auditing the website with lighthouse (auditing tool in chrome dev tools), I found that the load time can be improved a lot. There are a lot of static elements present on the main page that can be cached to improve load times and accessibility can be improved.
There are vulnerabilities present in the dependencies and many of the assets are served using HTTP/1.1 instead of using HTTP/2
Note: Audit was done in Desktop and Mobile mode with no throttling. Mobile mode performance is worse than Desktop mode.
Mobile Mode:

Desktop Mode:

The PR for this issue has been merged :)


Switch robohash urls to use ssl as robohash now redirects there by default.

VCR tests fails on the redirect that comes with that. It's nicer to their servers to not make two requests anyways.

:+1:

See #417

As a temporary fix, I've put this in a test helper:
module SecureFaker
  def image(*args)
    super(*args).sub('http://', 'https://')
  end
end

Faker::Avatar.singleton_class.prepend(SecureFaker)

@BoboFraggins Please update the tests so that CI will pass, then I'll merge.

@BoboFraggins nevermind, I see this was done in #411


Allow for configuring internal and external ips

Using external ips (cloud) for ansible deployment and use seperate internal ip address for actual host connection information.

internal_interface added to allow for internal ip address to be used

internal_interface added to allow for internal ip address to be used


Please add powershell/CLI option to get/set this setting

How can this be set /viewed via CLI? Powershell or other?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfac0ecf-e5a9-c5ff-f8c2-ce27789708f5
Version Independent ID: 0f5e0cc9-a54f-a5c8-192d-d60a6a4db3ff
Content: Azure Active Directory security defaults
Content Source: articles/active-directory/fundamentals/concept-fundamentals-security-defaults.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@TiloGit Thanks for your feedback! We will investigate and update as appropriate.

@TiloGit Unfortunately today we do not have the option to view the Security Defaults with Powershell/CLI. You can submit your feedback in the Azure Feedback Portal for our engineers to have a look on the same.
We will be closing this thread right now. Please let us know if you need further help on the same.

any news on az cli support?
seem that graph api has this: https://github.com/MicrosoftDocs/azure-docs/issues/76630

also add idea: https://feedback.azure.com/d365community/idea/576c7bc4-673f-ed11-a81b-000d3ae3db6e

duplicate: https://github.com/MicrosoftDocs/azure-docs/issues/55092


(maint) default mode via bitwise ops in file_system_spec

Minor correction of the determination of expected default mode for regular file
via umask in file_system_spec.rb to use bitwise operations - this will be more
familiar (and feels more correct) than previous represention.
Signed-off-by: Moses Mendoza<EMAIL_ADDRESS>

CLA signed by all contributors.


Methods getVideoTracks and getAudioTracks does not work for remote stream

I have found fix that works for me, but I'm not sure that it does not break something else:
--- ie/MediaStreamEvent.cc
+++ ie/MediaStreamEvent.cc
@@ -49,6 +49,7 @@
HRESULT _hr = Utils::CreateInstanceWithRef(&_stream);
CHECK_HR_RETURN(_hr);
_stream->SetStream(m_Event->stream);
+_stream->SetDispatcher(const_cast<_AsyncEventDispatcher*>(GetDispatcher()));
_hr = CComVariant(_stream).Detach(pVal);
SafeRelease(&_stream);
return _hr;

Yes, I can confirm this. I tried webrtc-everwhere localy and run into the same issue. Is the fix working and not breaking something else for now?
Regards RonMen

Hi, same problem here. Are there any plans to fix this?
Thanks


envoy: Bump envoy to v1.24.9

This is to include the fix for the below CVE.
CVE: https://github.com/envoyproxy/envoy/security/advisories/GHSA-jfxv-29pc-x22r
GHA build: https://github.com/cilium/proxy/actions/runs/5544741749/jobs/10122649239

/test-backport-1.13

/test-1.21-4.19

Additional review from proxy team is done, all CIs are passed, marking this ready to merge.


[Feature Request] Lower brightness than the monitor's limit.

Description of the new feature / enhancement
Adjust to a lower brightness than the monitor's limit.
Scenario when this would be used?
In some cases (at night or in a dark room), very low brightness is needed, but the monitor hardware does not allow to do so.
Lower global brightness achieved by software is a solution.
Can we develop a similar feature here to help users easily adjust to a lower brightness?
Supporting information
There are several examples on Mac, such as "Sub-zero Dimming" in Lunar and Quickshade.
Another reference is the overlay in "find-my-mouse" of "Mouse utilities". It reduces the brightness of the background.

no plans for PowerToys to do this.  our ability would be mimic what settings could do today.


Permissions Cleanup

Please describe the changes this PR makes and why it should be merged:
Cleans up permissions in d.js:

Permissions class:

BreakingChange: add and remove no longer return new instances, but instead return the modified instance. (add and remove did not work as advertised before this pr, as member is not a valid param of Permissions anymore) add and remove return new instances if the instance is frozen. Modifies the instance if not.
BugFix: 0 is a valid permission.
Cleanup: several small tweaks for optimization (reverse for loops, order of Permissions.resolve())
Added: Permissions.freeze to return immutable instances of the class. (all returned permissions changed to frozen permissions)
Added: Permissions as a possible PermissionResolveable, cleaned up instances where using the bitfield prop, instead of the permissions instance itself.

PermissionOverwrites class:

BreakingChange: removed this._denied and this._allowed in favor of this.allowed.bitfield and this.denied.bitfield as the data was double stored.

Guild class:

BugFix: overwrite.allow/overwrite.deny aren't a thing since: 1e47cfdd5df1654ac6ed47146e09f34e3e49b0c5. Reverted as this is meant for [{allow:1, deny:1}] to be passed instead.

GuildChannel class:

Cleanup: cleaned up permissionsFor and overwritesPermissions
BugFix: return new Permissions(Permissions.all) if the member has administrator earlier. (fixes if discord says Adminstrator deny as an overwrite)

GuildMember class:

Cleanup: get permissions()
BugFix: missing permissions was trying to use the param permissions, as if it were an instance of Permissions; instead of this.permissions.

Role class:

BreakingChange: role.permisions now returns a frozen instance of Permissions.
Cleanup: permissions usage to use the permissions instance.

Semantic versioning classification:

[ ] This PR changes the library's interface (methods or parameters added)

[x] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

[ ] This PR only includes non-code changes, like changes to documentation, README, etc.

This does not include previously PRed channel.permissionsFor(Role) or role.permissionsIn(channel); however it does include the bugfixes from that PR.

Not a fan of the add/remove changes - the object is supposed to be immutable, just like an Integer or String instance.

Added Permissions.freeze to return immutable instances. All instances returned from the library made frozen.
Likely controversial: fixed add/remove to return a new instance of Permissions if the instance is frozen, rather than having a typeError be thrown because this.bitfield would be readOnly in the frozen instance.

Can we just leave the main perm calculation alone so we can stay visually consistent with the calculation


nvidia-smi comes with NVIDIA drivers, and not CUDA

This is very useful module! Thank you!
I have a small suggestion wrt README.md which is somewhat misleading, as it says:

CUDA GPU with latest CUDA driver installed. GPUtil uses the program nvidia-smi to get the GPU status of all available CUDA GPUs. nvidia-smi should be installed automatically, when you install your CUDA driver.

But according to: https://developer.nvidia.com/nvidia-system-management-interface

NVIDIA-smi ships with NVIDIA GPU display drivers on Linux, and with 64bit Windows Server 2008 R2 and Windows 7.

so I think the correct description needs to replace CUDA to NVIDIA drivers.
The reason I find it's important, is because for example pytorch started shipping its own CUDA libraries and you no longer need to install CUDA-system wide. Yet, the user will still have nvidia-smi if they installed the NVIDIA driver, but not with pytorch. And currently your doc implies that a user must have CUDA installed to have nvidia-smi, which is not so.
I hope my communication was clear.
Thank you.

@stas00 Thank you for pointing that out!
I completely agree, that it is an important distinction.
I'll make an update later today :-)


Drop container/Docker support and update README badges and docs

This PR drops container/Docker support because a new version image has not been uploaded for the past few years. E3SM diags is primarily installed and used in Anaconda environments.

Closes #483
Closes #533

Summary of Changes

Remove directory e3sm_diags/container and related files

Remove references to container in driver files

Remove documentation section covering building and releasing Docker image
Remove ignore_container kwarg and update related logic in get_output_dir()

Remove passing kwarg ignore_container=True in driver and plot files

Hey @forsyth2 @chengzhuzhang, this update should be good for the upcoming release. It isn't urgent, so feel free to review it whenever you get a chance, thanks!


Translations not working as expected on typewrite animation

Hi, I found out that typewrite is currently using
var l = node.text.length()
this leads to getting translation key length instead of the actual translation text leght.
In order to fix the issue I changed that line to
var l = tr(node.text).length()
so it now uses translation resolved text instead of translation key and it is fully compatible with non translated Strings.
I was going to open a PR with the fix but I found out that typewrite sintax changed on your latest version and I don't know how to properly invoke tr function on that case.

Hi, thanks for the report; I've changed the implementation to use tr:
https://github.com/ceceppa/anima/blob/main/addons/anima/utils/node_properties.gd#L150


Allow user to configure repo name

Currently opening a file in sourcegraph attempts to open <url>/<host>/<filepath> (ex: http://localhost:1234/bitbucket.org/foo/bar/myfile).
Repositories in sourcegraph are not necessarily configured with this naming scheme.
In fact in my local instance the repo name is just foo/bar so I must manually remove the bitbucket.org/ segment each time.

Thanks for filing. This is a known issue that we hope to address in our current iteration (planned ship date is the week of June 18, and the fix would be in Sourcegraph 2.9).

Tentatively we plan to address this in November as part of the "More robust repository syncing" project on our roadmap: https://docs.sourcegraph.com/dev/roadmap#november-2018.

Hi! Just wanted to add a datapoint that we currently have the same issue, and I believe it's been reported on #2 as well. We have a hosted Sourcegraph installation and at least 100 engineers using VSCode.

We now have a GraphQL API for resolving clone URLs to repos, so this should be possible without configuration

@felixfbecker Is this a feature that needs to be added to the extension? Couldn't find any references on the code or docs.

This is a feature that needs to be added to the extension. It is not something you can configure yet, unfortunately. Sorry for the delay here.

@sqs thanks for the update! We love sourcegraph at work and this would make our life so much better

Any update on this?

I have a super naive implementation of this here: https://github.com/sourcegraph/sourcegraph-vscode/compare/master...matthewbentley:better_self_hosted_support

@sqs I don't think I'm a good owner for this since I don't use vscode / typescript. Re-assigning to you to triage.


OpenFace: openface_server.lua subprocess has died.

After trying to follow the docker instructions from http://cmusatyalab.github.io/openface/setup/ I get an error on the first demo file being run.
Commands run:
./demos/compare.py images/examples/{lennon*,clapton*}
Output:
Traceback (most recent call last):
File "./demos/compare.py", line 101, in
d = getRep(img1) - getRep(img2)
File "./demos/compare.py", line 92, in getRep
rep = net.forward(alignedFace)
File "/usr/local/lib/python2.7/dist-packages/openface/torch_neural_net.py", line 149, in forward
rep = self.forwardPath(t)
File "/usr/local/lib/python2.7/dist-packages/openface/torch_neural_net.py", line 102, in forwardPath
""".format(self.cmd, self.p.stdout.read(), self.p.stderr.read()))
Exception:
OpenFace: openface_server.lua subprocess has died.
Is the Torch command th on your PATH? Check with which th.
Diagnostic information:
cmd: ['/usr/bin/env', 'th', '/usr/local/lib/python2.7/dist-packages/openface/openface_server.lua', '-model', '/root/src/openface/demos/../models/openface/nn4.small2.v1.t7', '-imgDim', '96']
============
stdout:
============
stderr:

Hi @ZoranPavlovic - are you running this on a non-64-bit machine? If so, this is related to #42. If you are on a 64-bit machine, can you try running util/profile-network.lua to see if it works?

Hi @bamos - This is on a 64bit machine, Ubuntu 15.04.
root@980433e5fc99:/# ./root/src/openface/util/profile-network.lua
Illegal instruction (core dumped)

Hi @ZoranPavlovic - you need to build the Docker container from scratch to resolve this. See this portion of our faq for more details. Can you try this and let me know if it fixes the issue?

I'm getting an illegal instruction error in the pre-built Docker container.

This is unfortunately a result of building the Docker container on one machine that compiles software with non-standard CPU flags and creates illegal instructions on architectures that don't support the additional CPU features. Using the binaries from the pre-built container on a CPU that doesn't support these features results in the illegal instruction error. We try to prevent these as much as possible by building the images inside of a Docker machine. If you are still having these issues, please fall back to building the image from scratch instead of pulling from Docker Hub. You'll need to build the opencv-dlib-torch Dockerfile, change the FROM part of the OpenFace Dockerfile to your version, then build the OpenFace Dockerfile.

hi I also meet the same problem ! I use java to get this python interface. I use Mac book os 10.10!!!!!!!!!!!!Commands run:
./demos/compare.py images/examples/{lennon,clapton}
Output:
Traceback (most recent call last):
File "./demos/compare.py", line 101, in
d = getRep(img1) - getRep(img2)
File "./demos/compare.py", line 92, in getRep
rep = net.forward(alignedFace)
File "/usr/local/lib/python2.7/dist-packages/openface/torch_neural_net.py", line 149, in forward
rep = self.forwardPath(t)
File "/usr/local/lib/python2.7/dist-packages/openface/torch_neural_net.py", line 102, in forwardPath
""".format(self.cmd, self.p.stdout.read(), self.p.stderr.read()))
Exception:
OpenFace: openface_server.lua subprocess has died.
Is the Torch command th on your PATH? Check with which th.
Diagnostic information:
cmd: ['/usr/bin/env', 'th', '/usr/local/lib/python2.7/dist-packages/openface/openface_server.lua', '-model', '/root/src/openface/demos/../models/openface/nn4.small2.v1.t7', '-imgDim', '96']

Hi @anthonyyuan - can you try running util/profile-network.lua to see if it works?
-Brandon.

Hi @bamos, I use my 64-bit machine running "util/profile-network.lua",
and the output is "/usr/bin/env: th: can't find the file or dictionary", Do I missed something?

Hi @pinguo-luhaofang - have you installed Torch and is it on your PATH?
I'm closing this thread since the issue tracker is for development discussions and specific bug tracking. Let's move further setup discussions to our mailing list at https://groups.google.com/forum/#!forum/cmu-openface.
-Brandon.


Recurring Donation Label Refactor into Apex Constants

Remove all uses of legacy Recurring Donation custom labels with hardcoded Apex Constants. This addresses an issue with labels that are not supposed to be translated in our underlying packages, but due to a packaging limitation the translations still exist in the package even though they were remove two years ago.

Critical Changes
Changes

Deprecate legacy custom labels that were previously used by a much older version of Recurring Donations. These labels have not been needed since Salesforce introduced Picklist Api Values in the Spring '17 release, however they have still exist in the package and could cause issues if the values were translated.

Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

@force2b The WI ACs are all tested and pass. Just noticing that the failing Feature Test - Robot errors are all language related. Are they expected? Is it okay for me to merge this PR with those tests failing? Thanks.

Rebuild fixed the language related robot failures. Remaining failures are known. Merging.


Fix Windows Build Warning

Hacks to get windows time working with POSIX APIs, so we can get rid of appveyor build warning.

Current coverage is 75.30% (diff: 100%)

Merging #963 into master will increase coverage by 2.36%

@@             master       #963   diff @@
==========================================
  Files           117        118      +1
  Lines         17606      16579   -1027
  Methods        2448       2323    -125
  Messages          0          0
  Branches       2127       2003    -124
==========================================
- Hits          12841      12484    -357
+ Misses         4075       3457    -618
+ Partials        690        638     -52

Powered by Codecov. Last update 851027d...5708bf0


[SPARK-34039][SQL][3.1] ReplaceTable should invalidate cache

What changes were proposed in this pull request?

This is a backport of #31081 to branch-3.1.
This changes ReplaceTableExec/AtomicReplaceTableExec, and uncaches the target table before it is dropped. In addition, this includes some refactoring by moving the uncacheTable method to DataSourceV2Strategy so that we don't need to pass a Spark session to the v2 exec.
Why are the changes needed?

Similar to SPARK-33492 (#30429). When a table is refreshed, the associated cache should be invalidated to avoid potential incorrect results.
Does this PR introduce any user-facing change?

Yes. Now When a data source v2 is cached (either directly or indirectly), all the relevant caches will be refreshed or invalidated if the table is replaced.
How was this patch tested?

Added a new unit test.

Test build #133865 has started for PR 31100 at commit 5f601bc.

Test build #133865 has started for PR 31100 at commit 5f601bc.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38454/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38454/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38454/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38454/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38454/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38454/

Test build #133865 has finished for PR 31100 at commit 5f601bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #133865 has finished for PR 31100 at commit 5f601bc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133865/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133865/

Merged to branch-3.1.

Merged to branch-3.1.


[Rewrite] Sometimes propics overlap in direct messages

Describe the bug
A clear and concise description of what the bug is.
The title is enough
To Reproduce
Steps to reproduce the behavior:

Go to direct messages;
Open a chat

Expected behavior
Behave normally
Screenshots

Desktop (please complete the following information):

Windows 10 Home 1903

Smartphone (please complete the following information):

Device: [e.g. Lumia 950]
Windows Mobile Version [e.g. 1607]

Additional context
Add any other context about the problem here.

This is a consequence of some embeds not being implemented.


Module archive I/O abstraction

When the ModuleArchive (org.opensha.commons.util.modules.ModuleArchive<E>) interface was originally created, it was designed to store all module data using the Java ZipFile and ZipOutputStream implementations.
Those implementation have some limitations, notably:

No ability to zip to and read from memory (useful for sending data over the network in distributed calculations rather than using a slow filesystem)
Can't copy a zipped entry from one archive to another without decompressing and recompressing

Because of this, various codes use the Apache commons-io zip implementation instead to write large data files (e.g., logic tree hazard maps) and bypass the modules framework.
This PR abstracts the I/O methods of ModuleArchive to instead use new ArchiveInput and ArchiveOutput interfaces. Implementations are also provided using the regular Java classes, Apache commons-IO, and Java NIO. Multiple Apache implementation are provided including in-memory and parallel zipping.
The new ArchiveOutput.ParallelZipFileOutput does all of the zipping in memory and in parallel, which can be very fast if you are more zip-bound than write-bound and have lots of available memory. ArchiveOutput.AsynchronousZipFileOutput does zipping in the current thread but handles writes asynchronously without too much additional memory overhead.
ModuleArchive's can also be read or written directly to directory structures (unzipped), or to tar files.
@voj: if you have any custom ArchivableModule implementations that implement the writeToArchive or initFromArchive methods (rather than deferring to one of the default implementations), you will need to modify them once this is merged.

Note: developers may have to do a "Gradle -> Refresh Gradle Project" in eclipse to fetch the updated dependencies.


Capability to create safely root data stores in attached container mode - rollout support

Anticipating some fallout from retrofitting existing code (create root datastore) to the new model (create + alias). This story tracks the work needed to catalog the migration and deal with any issues rooted in this migration.

Duplicate of the work at https://github.com/microsoft/FluidFramework/issues/9660


move colorcurves, contrast + aperture to camera

add support for contrast and aperture to stdmaterial

Create a default environment texture as well.

Global environment has been added to the scene as well as createDefaultSkybox

This has been moved to the new defaultRenderingPipeline for contrast and aperture.


HW requirements - multiple NIC

Some of oamg tests require guests with multiple network interfaces.
In beaker this can be specified with <key_value key="NR_ETH" value="2"/>
We'd love to be able to run those tests with tmt as well.

This sounds like for certain provision methods, such as beaker for example, there could be an extra key dedicated for providing a free-form key-value information. I don't think we can (or should) provide an extra syntax for each and every use case which users will run into. Provision plugins which would not support there extra values would just ignore the information. Does that make sense?

Summary from today's hacking session: Let's define a new network attribute which would be a list of dictionaries describing the desired network interface(s):
# single interface
network:
  - type: eth

# multiple interfaces
network:
  - type: eth
  - type: eth
    vendor: name

@fernflower, could you possibly provide some more real-life examples of the keys which would be useful to specify the interface?

So sorry for late response. The format @happz suggested in https://github.com/psss/tmt/pull/895 has everything we need.


Init commit create react app with react-app-rewired

What is this?
This adds a new waves folder which is a react app using a rust wasm library combined with webpack.
my-app was creating using create-react-app.
However, this would not let us configure webpack (which is the reason we went for create-react-app in the first place).
Hence we use react-app-rewired and created a config-override.js
The library wasm_lib was created using wasm-pack new.
It showcases a single method to return hello world and a function to initialize a logger.
Issues
So far I like the setup, it has one caveat though: if we want to add native as a dependency in package.toml then a rebuild is not automatically reloaded. File-based import work though.
How to
Go into my-app and type
yarn install

followed by
yarn start

to start in development mode. You can then make changes in the rust library under native and the code should automatically rebuild and reload.
Enjoy :)

superseded by: https://github.com/comit-network/droplet/pull/13

superseded by: #13

Why not just rebase onto latest master instead of closing?


Scratchattach hanging on conn.get_var("hi").

Any Fixes?

and the variable name is correct?

and the variable name correct?

Yes.

Interesting. Maybe try using scratch3.get_var("project_id", "variable_name") instead. This function does the same, but it tries to get the value from the clouddata logos

This doesn't look like a bug. Try using scratch3.get_var("project_id", "variable_name") if conn.get_var isn't working for you

Turned out this may actually be a bug that occurs then getting a turbowarp cloud variable. I'll look into it.

The issue is caused by turbowarp's updated cloud variable guidelines. Will be fixed soon.

Scratchattach is only hanging on conn.get_var if the variable doesn't exist. This issue will be fixed.


Minor change before beta release

made the model forbid extra arguments (it was silently ignoring), and wrote corresponding tests.
updated the classifier to beta.

Removed some unmaintained routines

tests are failing because of the hash problem #95

I merged #95 on this. Please check this PR after #95.


Open TSC Meeting, Thursday 11 February 2021

NOTE: This meeting is on Thursday at 9am - 10am PT
Zoom Meeting link: https://zoom.us/j/975841675. Dial-in passcode: 763054
In order to give some more visibility into the topics we cover in the TSC meetings here is the planned agenda for the next meeting.  Hopefully this will allow people to plan to attend meetings for topics that they have an interest in.  And for folks who cannot attend they can comment on this issue prior to the meeting.  Feel free to suggest other potential agenda topics.
Please submit comments below for topics or proposals that you wish to present in the TSC meeting

Topic
Owner
Decision/NextStep

3.1-final release planning
TSC
@webron to do GitHub magic

Non-spec but impactful deliverables for 3.1 (metaschema, IANA registration)
TSC

Add id for 3.0.x schemaObject backwards compat, or extract (automatically?) to separate metaschema
@MikeRalphson

AOB (see below)
TDC

New issues / PRs labelled review
@OAI/triage

New issues without response yet
@OAI/triage

/cc @OAI/tsc Please suggest items for inclusion

Just a note that there will be no TSC call on 2021/02/18, we'll be back on the 25th.


Bug report: allocating custom abstract types

First of all: cool package and thanks for your work!
While I was working with the package I encountered an error starting with
"Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks."
so here is that bug report.
I wanted to allocate some memory for an array with an abstract eltype. Here is a minimal (not) working example:
using Bumper

abstract type MyType end

struct MyStruct <: MyType
    x::Int
end

Base.sizeof(::Type{MyType}) = sizeof(Int)

@no_escape begin
    foo_arr = @alloc(MyType, 10)
    println(foo_arr)
end

I suppose the answer might be 'you cannot define sizeof for your abstract type and expect things to work', but I wanted to open this bug report anyway as requested.
Here is the full stack trace:
Please submit a bug report with steps to reproduce this fault, and any error messages that follow (in their entirety). Thanks.
Exception: EXCEPTION_ACCESS_VIOLATION at 0x15f21dd2f5e -- _show_default at .\show.jl:465
in expression starting at C:\Users\wolf.nederpel\hive\intsect\scripts\random_julia_test.jl:11
_show_default at .\show.jl:465
show_default at .\show.jl:462 [inlined]
show at .\show.jl:457 [inlined]
show_delim_array at .\show.jl:1346
show_delim_array at .\show.jl:1335 [inlined]
show_vector at .\arrayshow.jl:530
show_vector at .\arrayshow.jl:515 [inlined]
show at .\arrayshow.jl:486 [inlined]
print at .\strings\io.jl:35
print at .\strings\io.jl:46
println at .\strings\io.jl:75
unknown function (ip: 0000015f21dd4f1f)
println at .\coreio.jl:4
unknown function (ip: 0000015f21dd2bcb)
jl_apply at C:/workdir/src\julia.h:1982 [inlined]
do_call at C:/workdir/src\interpreter.c:126
eval_value at C:/workdir/src\interpreter.c:223
eval_body at C:/workdir/src\interpreter.c:489
jl_interpret_toplevel_thunk at C:/workdir/src\interpreter.c:775
jl_toplevel_eval_flex at C:/workdir/src\toplevel.c:934
jl_toplevel_eval_flex at C:/workdir/src\toplevel.c:877
ijl_toplevel_eval at C:/workdir/src\toplevel.c:943 [inlined]
ijl_toplevel_eval_in at C:/workdir/src\toplevel.c:985
eval at .\boot.jl:385 [inlined]
include_string at .\loading.jl:2070
_include at .\loading.jl:2130
include at .\client.jl:489
unknown function (ip: 0000015f21dc916b)
jl_apply at C:/workdir/src\julia.h:1982 [inlined]
do_call at C:/workdir/src\interpreter.c:126
eval_value at C:/workdir/src\interpreter.c:223
eval_stmt_value at C:/workdir/src\interpreter.c:174 [inlined]
eval_body at C:/workdir/src\interpreter.c:635
jl_interpret_toplevel_thunk at C:/workdir/src\interpreter.c:775
jl_toplevel_eval_flex at C:/workdir/src\toplevel.c:934
jl_toplevel_eval_flex at C:/workdir/src\toplevel.c:877
ijl_toplevel_eval at C:/workdir/src\toplevel.c:943 [inlined]
ijl_toplevel_eval_in at C:/workdir/src\toplevel.c:985
eval at .\boot.jl:385 [inlined]
eval_user_input at C:\workdir\usr\share\julia\stdlib\v1.10\REPL\src\REPL.jl:150
repl_backend_loop at C:\workdir\usr\share\julia\stdlib\v1.10\REPL\src\REPL.jl:246
#start_repl_backend#46 at C:\workdir\usr\share\julia\stdlib\v1.10\REPL\src\REPL.jl:231
start_repl_backend at C:\workdir\usr\share\julia\stdlib\v1.10\REPL\src\REPL.jl:228
#run_repl#59 at C:\workdir\usr\share\julia\stdlib\v1.10\REPL\src\REPL.jl:389
run_repl at C:\workdir\usr\share\julia\stdlib\v1.10\REPL\src\REPL.jl:375
jfptr_run_repl_95895.1 at C:\Users\wolf.nederpel\AppData\Local\Programs\Julia-1.10.0\lib\julia\sys.dll (unknown line)
#1013 at .\client.jl:432
jfptr_YY.1013_86694.1 at C:\Users\wolf.nederpel\AppData\Local\Programs\Julia-1.10.0\lib\julia\sys.dll (unknown line)
jl_apply at C:/workdir/src\julia.h:1982 [inlined]
jl_f__call_latest at C:/workdir/src\builtins.c:812
#invokelatest#2 at .\essentials.jl:887 [inlined]
invokelatest at .\essentials.jl:884 [inlined]
run_main_repl at .\client.jl:416
exec_options at .\client.jl:333
_start at .\client.jl:552
jfptr__start_86719.1 at C:\Users\wolf.nederpel\AppData\Local\Programs\Julia-1.10.0\lib\julia\sys.dll (unknown line)
jl_apply at C:/workdir/src\julia.h:1982 [inlined]
true_main at C:/workdir/src\jlapi.c:582
jl_repl_entrypoint at C:/workdir/src\jlapi.c:731
mainCRTStartup at C:/workdir/cli\loader_exe.c:58
BaseThreadInitThunk at C:\windows\System32\KERNEL32.DLL (unknown line)
RtlUserThreadStart at C:\windows\SYSTEM32\ntdll.dll (unknown line)
Allocations: 635700 (Pool: 634725; Big: 975); GC: 1

Hi @wnederpel yeah this is not something that Bumper can support, but it should fail in a more graceful way, I'll try to fix this soon.

@MasonProtter instead, could @alloc just fall back to a normal array allocation?
If I am writing a function for generic input type Vector{T}, right now, I have to write two separate methods:

one for Bumper-compatible types, and
one for everything else.

But the code itself is basically the same. This leads to dangerous “shotgun” edits where I have to update the code in both places whenever I add a feature.
Can Bumper.jl itself just do a regular allocation if the type is not concrete?
You could then have an @alloc(…, strict=true) to disable fallbacks.

Yeah that sounds pretty reasonable to do.


Add install.sh

Description
Adds an install script accessible at https://ocm.software/install.sh
This enables us to install the ocm cli in scenarios where homebrew might not be available.
Signed-off-by: Piaras Hoban<EMAIL_ADDRESS>

Looked okay btw!


Deprecated Generated Mutations/Queries are not picked up by lint

I'm not sure if this is an issue with my lint setup or with Apollo. I have a Mutation which is tagged as @OBSOLETE in the schema. The generated class does tag the Mutation as deprecated, but when I use the GeneratedClass.builder(), lint does not pick up that it is deprecated.
So for example, the Date(year,month,date)  constructor is deprecated in Java and throws a warning.
But the generated GroupRenameMutation.builder().build() class does not throw a warning.
Can  the builder() constructor or build() function also be tagged as deprecated in a deprecated class?

For some clarification: Deprecated parameters in the schema do get the deprecated label in the generated code and I get a lint warning if I attempt to use that parameter.
Queries and Mutations, however, do not.

low priority, pr welcome :-)

In this case, even though the functions are not marked, GroupRenameMutation should have strikethrough on it when you call GroupRenameMutation.builder().build()

looks like out of date.


Subscription level deployment

Is it possible to handle subscription level deployments through this method ?
Anyway, this should be documented.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43bf1e44-5555-8794-3ec0-84b5cc22e83d
Version Independent ID: 27453c17-9c3c-6132-2949-16ffe4da8807
Content: Deploy to Azure button - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/deploy-to-azure-button.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@BzSpi - Thank you for your comment.  This method only supports resource group level deployment.  I will add a note to the article.
#please-close