Directly expose WebRTCPeerConnection::create_data_channel() to GDExtension

Due to godot-cpp bug https://github.com/godotengine/godot-cpp/issues/652, rather than directly exposing WebRTCPeerConnection::create_data_channel(), an alternate version which returned an Object * (instead of Ref<T>) was exposed, with a custom create_data_channel() that called it.
Since that bug is now fixed, we can remove the workaround, and directly expose it!
I think this breaks compatibility, but since we're thoroughly breaking GDExtension compatibility for Godot 4.1 anyway, this seems like a good time to change this. :-)

Here's a corresponding PR for webrtc-native to adjust to these changes: https://github.com/godotengine/webrtc-native/pull/101
I tested webrtc-native and this PR using the webrtc_minimal and webrtc_signaling demos in https://github.com/godotengine/godot-demo-projects - it's working great for me!

Validate extension JSON: Error: Field 'classes/WebRTCPeerConnectionExtension/methods/_create_data_channel/return_value': type changed value in new API, from "Object" to "WebRTCDataChannel". needs to be added to misc/extension_api_validation/4.0-stable.expected

@RedworkDE Thanks! Should be fixed in my latest push

Thanks!


Should allow highlighting the shortcut if it matches the date or date range selected

Hello @esccmdctrl
Thank you very much for this proposal. Your request will be processed very soon.


Set default osd_devices to None

Default value calculation was changed to check for None instead of truthy.
Default value of '' used to return False, but is now considered as True (since it's not None).

(force push is correcting typo in commit message)


[test] Update configuration and tests for the new batch policies

Fixes UES-1247.

Codecov Report

Merging #1633 (3bd8972) into master (1897374) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1633   +/-   ##
=======================================
  Coverage   87.54%   87.54%
=======================================
  Files          44       44
  Lines        7292     7292
=======================================
  Hits         6384     6384
  Misses        908      908

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1897374...3bd8972. Read the comment docs.

@jenkins-cscs retry daint


Fix broken links

Thank you for contributing to openstack/openstack-salt!
openstack/openstack-salt uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Flaky test: Factory_CleanupCycle_DisposesLiveHandler

This test is failing on travis occaisionally https://travis-ci.org/aspnet/HttpClientFactory/jobs/344818297

@rynowak if this is failing only on Travis, should we move this to RC1? And then maybe give up because we'll move to dotnet-ci instead?

This seems like it's actual flakiness, and not a travis-related issue.

Got it. Will we have time this week to investigate? If not, we should move to rc1

Nothing ever exists entirely alone. Everything is in relation to everything else.

My mind is blown.

not sure if it is related, but I have seen a race condition between the scheduled clean up job and tear down.  ActiveHandlerTrackingEntry probably should stop the timer during tear down ?

hmm interesting. I'll take a look at that.
Do you have any more data points about how you figured that out?

Just hit it on a unit test where the assert failed. I am not completely sure what is going on, I didn't spend enough time in it. But definitely smelled like a race condition with the timers still running for the ActiveHandlerTrackingEntry instances and the clean up job depending upon the queue count not shrinking. I haven't seen it since implementing dispose methods, but that doesn't say much for race conditions.

Just hit it on a unit test where the assert failed

What assert was this? were you just building the HttpClientFactory repo or was this your own code?

Looking at this log:
The failure is coming from here: https://travis-ci.org/aspnet/HttpClientFactory/jobs/358248760
https://github.com/aspnet/HttpClientFactory/blob/df30496fd89e6895cde4e9ae9953492ffe893000/test/Microsoft.Extensions.Http.Test/DefaultHttpClientFactoryTest.cs#L350
This means that the entry isn't eligible for GC, which means that the 'dummy' handler is still live. Since we're effectively relying on an implementation detail of the GC, I'm not 100% sure what we can do to improve the resilience of the test other than dumb things like retries.
I also realize that I'm not triggering a GC after waiting for finalizers. If a finalizer caused ressurection of the dummy handler these tests wouldn't handle it. I'm going to tweak things again and see if that makes it more reliable.

@theezak - after looking at this test failure a bit more, I don't think the problem you're seeing is the one I've been looking at. If you can tell me what's going wrong for you, or provide a failing unit test, I can take a look at it.

Hi,
That makes sense. I was looking (right or wrong) for a guarantee that on teardown the handlers are all disposed. handlers being disposed is completely dependent upon timers and GC timing.
For example: the following tests are near identical except for GC timing. One passes, one fails.
`        internal class TypedClient : IDisposable
{
public HttpClient Client { get; private set; }
public TypedClient(HttpClient client) => Client = client;
        public void Dispose()
        {
            Client?.Dispose();
            Client = null;
        }
    }

    internal class Wrapper : HttpClientHandler
    {
        public Wrapper()
        {

        }

        internal Action NotifyDisposal;
        protected override void Dispose(bool disposing)
        {
            NotifyDisposal();
            base.Dispose(disposing);
        }
    }
    [TestMethod]
    public async Task TearDownDisposed()
    {
        var services = new ServiceCollection();
        var disposedHandler = false;
        services.AddHttpClient<TypedClient>().SetHandlerLifetime(new TimeSpan(0, 0, 0, 10)).ConfigurePrimaryHttpMessageHandler(() => new Wrapper
        {
            NotifyDisposal = () => disposedHandler = true
        });
        var provider = services.BuildServiceProvider();
        var factory = provider.GetRequiredService<System.Net.Http.IHttpClientFactory>();
        using (var scope = provider.GetRequiredService<IServiceScopeFactory>().CreateScope())
        {
            scope.ServiceProvider.GetRequiredService<TypedClient>();
        }
        await Task.Delay(15000);
        GC.Collect();
        await Task.Delay(15000);
        provider.Dispose();
        GC.Collect();
        Assert.AreEqual(true, disposedHandler);
    }

    [TestMethod]
    public async Task TearDownNotDisposed()
    {
        var services = new ServiceCollection();
        var disposedHandler = false;
        services.AddHttpClient<TypedClient>().SetHandlerLifetime(new TimeSpan(0, 0, 0, 10)).ConfigurePrimaryHttpMessageHandler(() => new Wrapper
        {
            NotifyDisposal = () => disposedHandler = true
        });
        var provider = services.BuildServiceProvider();
        var factory = provider.GetRequiredService<System.Net.Http.IHttpClientFactory>();
        using (var scope = provider.GetRequiredService<IServiceScopeFactory>().CreateScope())
        {
            scope.ServiceProvider.GetRequiredService<TypedClient>();
        }
        await Task.Delay(30000);
        provider.Dispose();
        GC.Collect();
        Assert.AreEqual(true, disposedHandler);
    }
}`

Moved to RC1.

@rynowak - any further ideas on this flaky test?

The handler isn't being GCed in the test. Dunno why.

So we think it's a test-only issue? Or possibly a product issue?

test issue. We're expecting the GC to have collected something and it hasn't

OK, then MQ it is.

This is done

This is sadly not fixed, fails somewhat consistently still in debug on linux.

I think this is actually fixed by my recent change. I'll wait to see it fixed in the official build before closing.

Closing this because it seems fixed


Motion detection

Do you think it is possible to also perform a motion detection using motion and therefore also add a motion detection accessory to HomeKit?

For the camera view, would it be possible in this scenario to instead direct homebridge to an mjpeg stream created by motion itself?
a typical motion install can also set up an http streaming server at port 8080/8081 in addition to detecting motion. In that case, it could be treated like any other IP cam, so I think a homebridge plugin such as https://github.com/KhaosT/homebridge-camera-ffmpeg would apply for the image streaming view?

That would be possible but the performance would suffer a lot.
This project has the goal to get a decent performance on a Pi (zero).

i tried using motion (the app) - it works as expected (video streaming, motion detection, notification upon motion detection). the performance is terrible. even with a very low resolution things work very bad. it's basically useless on a pi zero. and i don't want to use a pi3 due to physical space constraints.
Given these can you please extend this plugin with a gpio triggered image notification on homebridge - aka. gpio goes low, a picture is "shot" and sent as a notification to the phone (homebridge takes care of this). if you would have such a mechanism i could add a motion detection sensor which toggles a gpio and the issue is solved. even more, the motion sensor, via gpio, can be exposed as a motion sensor in homekit. what do you think?

Plugins like the one mentioned above should do the job just by placing them in the same room in the Home App.


Optimise SQL queries for /user and /assessments

Pull Request Test Coverage Report for Build 2968

15 of 15 (100.0%)  changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 94.165%

Files with Coverage Reduction
New Missed Lines
%

lib/cadet/assessments/query.ex
2
75.0%

Totals

Change from base Build 2967:
-0.2%

Covered Lines:
1049

Relevant Lines:
1114

💛  - Coveralls


filter: Use terms instead of operands.

Operand is a confusing name because this
data structure has an attribute called
operand. This commit renames references to
this structure to "term", short for "search
term".
This PR is a followup from this comment https://github.com/zulip/zulip/pull/28229#discussion_r1427278515 and a conversation with Anders.
This seems like a brittle change, so I'm putting it in its own PR. It seems easy to forget a rename and have it not caught by tests or the linter. Curious if there are ways that would be good for testing this.

Added a bunch more updates

It seems easy to forget a rename and have it not caught by tests or the linter.

Curious if you have thoughts on this?

Curious if you have thoughts on this?

Nothing beyond what I suggested; use git grep. TypeScript will help eventually.

@evykassirer I can review this once the merge conflicts are resolved.

Addressed Anders' comments and resolved merge conflicts

Merged, thanks @evykassirer! It's always very nice to fix two difference concepts with the same name.


Need control on the format of the event logs this library is adding

Is your feature request related to a problem? Please describe.
The event logs in the logger is not customizable for the consumer application.
Describe the solution you'd like
Currently we have the option to pass our own logger instance but it doesn't give me control to pass what should be the source or the even name for same.

Clients need to pass the actual logger implementation. The source and event prefix can be taken care at the client end in the actual logger implementation.
To comply with general telemetry standards the event name (during Store Registration) will be changed.


RFC: Cant enroll in the Calculus 1C: Coordinate Systems & Infinite Series course

The course Calculus 1C: Coordinate Systems & Infinite Series is not available anymore.

The curriculum links to Calculus 1C: Coordinate Systems & Infinite Series
Here is an image capture from that page demonstrating that the course is available on Open Learning Library.


[DEVOPS-302] release.nix: simplify and allow setting the platform

platform is now an attribute suffix
explorer and report server are now built only for linux

https://hydra.iohk.io/jobset/serokell/cardano-pr-1471#tabs-jobs


[BUG]: Correction in the steps to contribute in the main Readme.md file

After the  4th step there should be another step where you ask the contributor to :
Make the changes

Refer

I will make this change @ArslanYM.
and I think there is some changes needed under section "Other points to remember while submitting your work:"
For points 1 & 3 space in folder name is not needed, and will we follow snake case?  in React mostly I see Pascal case for component names and camel case of js files.
For point 2 file extensions .py .c and .cpp. I don't think we will use cpp.
I will change these as part of the this issue.

I will make this change @ArslanYM. and I think there is some changes needed under section "Other points to remember while submitting your work:"
For points 1 & 3 space in folder name is not needed, and will we follow snake case? in React mostly I see Pascal case for component names and camel case of js files.
For point 2 file extensions .py .c and .cpp. I don't think we will use cpp.
I will change these as part of the this issue.

Nadeem im glad that you pointed out these issues. I would rather suggest opening a new issue for each of these problems , that way we can help this project stay structured. You can raise those issues induvidually and I will assign them to you. As for this issue, Making the above mentioned details would be sufficient. Thankyou

@ArslanYM
Can you assign this issue to me?
I will update the README.MD as per requirement.

@nadeem099 you can start working on this.

Completed!


[AzureMonitorExporter] Add perf test for exporting dependency telemetry

Follow up #35223
Sample Output

API change check
API changes are not detected in this pull request.


Android App crashes when receiving notification from Firebase Notifications, iOS works fine.

RN 0.42 fcm 6.1.0
Android 6 genymotion emulator
Android App crashes when receiving remote notification sent from firebase console. local notifications work fine on both platforms.
Remote notifications also work fine on iOS.

You should add
```compile 'com.google.firebase:firebase-messaging:10.0.1'```

to your android/app/build.gradle config

im facing the same issue
is it resolved for u ?


Added support for proxy

Hi guys, I added a small change to the brackets behind the proxy.
If path is not specified, socket.io gets the "root" /socket.io but when under dynamic proxy it must be a dynamic path

are you sure this breaks nothing in all cases?

Yep this don't have break changes i did the same in different proyects of mineflayer ( inventory and state machine).  I did several tests and works fine


Broken link: "Documentation about this package"

The Documentation about this package link on this project's readme is broken. Following that link results in a 404.

linked fixed. BTW version 3.0.0 was released.


[TEST] Add GitHub Actions CI

This PR adds GitHub Actions:

[x] pre-commit
[x] pytest
[x] Build docs
[x] Deploy Netlify
[ ] PYPI publish

[ ] Test if Netlify needs docs/requirements.txt


dockerinfo missing

Hi,
I am trying to migrate a docker repo and noticed that once the migration completed...my docker images dont have "docker-info" tab populated on the UI.
Any suggestions why that would be happening?
Thanks

Reproducing same behaviour, docker info missing, can't pull the image (getting 'unsupported metadata version 2'). Pulling the same image from nexus, retagging and pushing to artifactory works.
Also, xray seems not to scan any images migrated from nexus.

Hmm ... is your Nexus repo using Docker V1? The tool doesn't currently support V1, but it should work fine with V2.
Beyond that, if you could give an example of what your repository looks like in Nexus and in Artifactory (file layout, metadata content, properties, etc) that would probably be helpful.

Huh. The + sign in a URL is often used as shorthand for a space character (which would otherwise be encoded as %20). It appears that since that property value is being sent as a matrix parameter in the URL, something is seeing that .v2+json and changing it to a .v2 json.
This should not be happening. The thing is, the migrator encodes the + to a %2B, which should prevent Artifactory or anything else from seeing it as anything but a literal +. As far as I know, if some service is still seeing it as a space character, there's nothing the migrator can do to change that service's mind.
I doubt Artifactory is doing this, since if it were, this issue would affect everyone. It seems more likely that some sort of proxy or load balancer or other intermediate service is making this translation, before the request reaches Artifactory.

closing this issue due to age


Remove Sasa lib because il2cpp does not work with it.

Build error:
IL2CPP error for method 'System.Collections.Generic.IEnumerable`1<System.Collections.Generic.KeyValuePair`2<TKey,TValue>> Sasa.Collections.Trie`2/Node`1::<Enumerate>b__9(TChild)' in assembly 'C:\work\funkidracing\unity\Temp\StagingArea\Data\Managed\Assembly-CSharp.dll' Additional information: Build a development build for more information. The given key was not present in the dictionary.

G2M

g2m


bundler: Webview2 installation options not respected

Problem

Webview2 offline installer was not bundled in the msi or nsis installation package even if bundle.windows.webview_install_mode was set to OfflineInstaller or FixedVersion.
Steps To Reproduce
The reproducible sample was put in https://github.com/heyrict/dioxus-bundle-sample
The build binaries from github action were only ~3MB each.
Expected behavior
The built binary should include webview2 installer (expected to be ~130MB).
Environment:

Dioxus version: 0.4.0
Rust version: nightly
OS info: Windows
App platform: desktop

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[x] I don't have time to fix this right now, but maybe later

I'm facing the same issue, but in addition I also tried "FixedRuntime" with a path (note: I think this topic could use some improvements in the docs, but that might be more of a topic in #87).
I've tried installing the resulting msi or nsis bundle, but when starting the application afterward, it comes up with the error "Code execution cannot proceed because WebView2Loader.dll was not found. [...]"
Environment:
Dioxus version: 0.4.0
Rust version: 1.71.1 stable-x86_64-pc-windows-gnu
OS info: Windows
App platform: desktop
If I can be of any help in resolving this, I'm happy to do so. Any help would be greatly appreciated.

I think this topic could use some improvements in the docs

Yes, we definitely need to improve the documentation around bundling

Rust version: 1.71.1 stable-x86_64-pc-windows-gnu

We have found in the past that windows-gnu tends to have more issues with tauri than windows msvc.

If I can be of any help in resolving this, I'm happy to do so. Any help would be greatly appreciated.

There are a few different things we can try here:

Bumping tauri-bundle. The latest version is 2.0.0-alpha-7, but we are using an older stable version. I did find several issues in the tauri repo related to offline bundling, but none looked exactly like this.
Comparing a working tauri bundle config with offline installation with a failing Dioxus.toml config. We convert our format to the tauri-bundle struct here. We could be setting some configs differently from what tauri would set.

As per mentioned by @ealmloff , I've tried updating tauri-bundler to the latest and debug printing the converted tauri_bundler::BundleSettings, without any findings.
Correct me if I was wrong, but after a bit dig into the code base of tauri_bundler, it seems that FixedRuntime was not currently implemented even in taori itself.
OfflineInstaller should work anyway. And after a brief search on github, there do exist some tauri applications that use this config to bundle their applications.
When I went through the code of tauri_bundler, I've noticed that the nsis packager will skip the webview2 section if it found that webview2 was installed. I have no knowledge on nsis and am not sure if this is related to the fact the webview installer was not bundled, but probably it is worth some testing.

windows7不支持webview2...


instanceof should error when all constituents of a union are primitives

function foo(x: number | string) {
    if (x instanceof Number) {
        x
    }
}

Expected:
The left-hand side of an 'instanceof' expression must be of type 'any', an object type or a type parameter

Actual:
No error, incorrect narrowing behavior (#14426)
Edit: Corrected the example to actually be a union.

That's not always the expected behavior. When targeting a runtime with Symbol.hasInstance this should be allowed:
class PrimitiveNumber {
    static [Symbol.hasInstance](x) {
        return typeof x === 'number';
    }
}
console.log(123 instanceof PrimitiveNumber); // true

Sure, but

Most people aren't doing that.
We already error for 10 instanceof Number

Wouldn't an appropriate behavior then be to issue an error unless the value on the right hand side has a [Symbol.hasInstance] member taking a parameter of a type to which the type of value on the left hand side is assignable?

Something like #17360?

PR #19063 opend to resolve this issue.


Allow disabling progress bar

Do we have to include this one in this release?

It's a small task and an intern joins our team if I'm not mistaken. Progress bar clutters the output in the CI and print causes the following issue:

I think many CLI tools inspect environment variables to disable interactivity. I guess this env var is named TERM but I may be mistaken.

related task https://github.com/software-mansion/protostar/issues/110
But is interactivity considered any cli output or requesting user inputs @mkaput ? Because this taks is only related to cli output.

IMHO progress bar should only be shown if user input is possible in the terminal.


Add lwmqwer as maintainer of OpenYurt

GitHub Username
@lwmqwer
Organization you are requesting membership in
openyurtio
Sponsors
@rambohe-ch
Requirements

[x]   I have joined in the community [Dingding] and [WeChat]
[x]   I often attend Openyurt Community Week
[x]   I have reviewed the [community membership docs]
[x]   I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
[x]   I have checked my affiliation in [devstats] (if it's not correct, please fix in [cncf/gitdm])
[x]   I am actively contributing to 1 or more OpenYurt subprojects

List of your contributions

Subproject:
Yurt-edgex-controller

Issues:
#521

@lwmqwer Would you be able to reference this example(https://github.com/openyurtio/openyurt/pull/589) to update you apply message?

@lwmqwer Would you be able to reference this example(#589) to update you apply message?

Done

@lwmqwer welcome you to apply maintainer of OpenYurt, agree +1

@Fei-Guo @yixingjia @charleszheng44 @qclc @gnunu @DrmagicE @SataQiu

agree + 1

agree + 1

+1

:+1

/lgtm
/approve


RFC: Change Prereq for Programming Languages Part A

Problem:
The curriculum lists incorrect prerequisites for Programming Languages Part A.
Duration:
May 31, 2020
Background:
Programming Languages Part A currently lists as its pre-reqs: recommended: Java, C
However, this doesn't align with the instructor's recommendations. The course says that students should have some previous background coding and that 1-2 prior university courses should be fine. You can watch a video here where the instructor discusses expectations of prior student experience: https://www.coursera.org/lecture/programming-languages/recommended-background-k1yuh
Proposal:
Make How to Code the prerequisite for Programming Languages Part A.
Alternatives:
Specify 1-2 previous college level courses as the prerequisite.

Also, this is one of the rare courses where the prerequisite could be a link to the professor themselves explaining what students should know and be able to do.

I support this change. I think this is a good place to just link directly.

Putting this into action.
This commit resolves the issue: https://github.com/ossu/computer-science/commit/9edea7f7121428540efb1fd272315146260b6753


[JS] definePrompt returns undefined outputSchema

Describe the bug
definePrompt returns an undefined outputSchema even when a valid outputSchema is provided.
To Reproduce
I'm trying to run the below test code but I keep getting this error: Uncaught (in promise) Error: No JSON object or array found in model output. I tried passing both outputSchema and output to definePrompt to test (just in case).
Code:
export async function runTestFlow({ property }) {
    const inputSchema  = z.object({ property: z.string() });
    const outputSchema = z.object({ type    : z.string() });

    const flow = defineFlow({
        name        : "testFlow",
        inputSchema : inputSchema,
        outputSchema: outputSchema,
    }, async ({ property }) => {
        const prompt = definePrompt({
            name        : "testPrompt",
            inputSchema : inputSchema,
            outputSchema: outputSchema,
            output      : { schema: outputSchema }
        }, async ({ property }) => ({
            messages: [{
                role   : "user",
                content: [{
                    text: `What type is the ${property} property on a color?`
                }]
            }],
            config: { temperature: 0.3 }
        }));
        console.log("PROMPT:", prompt);
        const response = await generate(
            renderPrompt({
                prompt: prompt,
                input : { property },
                model : gemini15Flash,
            })
        );
        return response.output();
    });

    return await runFlow(flow, { property });
}

When I inspect the logged prompt object the outputSchema is undefined:
[Function: actionFn] {
  __action: {
    name: 'testPrompt',
    description: undefined,
    inputSchema: ZodObject {
      spa: [Function: bound safeParseAsync] AsyncFunction,
      _def: [Object],
      parse: [Function: bound parse],
      safeParse: [Function: bound safeParse],
      parseAsync: [Function: bound parseAsync] AsyncFunction,
      safeParseAsync: [Function: bound safeParseAsync] AsyncFunction,
      refine: [Function: bound refine],
      refinement: [Function: bound refinement],
      superRefine: [Function: bound superRefine],
      optional: [Function: bound optional],
      nullable: [Function: bound nullable],
      nullish: [Function: bound nullish],
      array: [Function: bound array],
      promise: [Function: bound promise],
      or: [Function: bound or],
      and: [Function: bound and],
      transform: [Function: bound transform],
      brand: [Function: bound brand],
      default: [Function: bound default],
      catch: [Function: bound catch],
      describe: [Function: bound describe],
      pipe: [Function: bound pipe],
      readonly: [Function: bound readonly],
      isNullable: [Function: bound isNullable],
      isOptional: [Function: bound isOptional],
      _cached: [Object],
      nonstrict: [Function: passthrough],
      augment: [Function: extend]
    },
    inputJsonSchema: undefined,
    outputSchema: undefined,
    outputJsonSchema: undefined,
    metadata: { prompt: {}, type: 'prompt' },
    actionType: 'prompt'
  }
}

Expected behavior
If I run the below code instead, with the property rgb, I get the expected response:
{
    "type": "array"
}

Code:
export async function runTestFlow({ property }) {
    const inputSchema  = z.object({ property: z.string() });
    const outputSchema = z.object({ type    : z.string() });

    const flow = defineFlow({
        name        : "testFlow",
        inputSchema : inputSchema,
        outputSchema: outputSchema,
    }, async ({ property }) => {
        const response = await generate({
            prompt: `What type is the ${property} property on a color?`,
            model : gemini15Flash,
            output: { schema: outputSchema }
        });
        return response.output();
    });

    return await runFlow(flow, { property });
}

Runtime

OS: Windows 11
Home Edition

Node version

20.12.2

Additional context
Note that I tried providing an outputSchema to renderPrompt as well, with the same result. I also tried awaiting renderPrompt and logged the result, but it doesn't look like that's where the outputSchema is designed to be provided. So, I'm presuming it should be provided to definePrompt instead, which does seem more intuitive.
Thanks, and please let me know if I can provide additional context!

This is WAI -- definePrompt doesn't actually allow specifying the output schema: https://github.com/firebase/genkit/blob/main/js/ai/src/prompt.ts#L58-L62
The two options is either using the generate function (as you did) or using dotprompt: https://firebase.google.com/docs/genkit/dotprompt.md#defining_inputoutput_schemas
import { defineDotprompt } from '@genkit-ai/dotprompt';

const prompt = defineDotprompt({
  name        : "testPrompt",
  input : {
    schema: inputSchema
  },
  output: {
    format: 'json',
    schema: outputSchema,
  },
}, `What type is the  {{property}} property on a color?` );

Ah-ha, that defineDotPrompt example is perfect for my use-case, thanks @pavelgj 💯 I didn't notice it in the docs before, but I see it now!
For context: I'm working on an object-oriented wrapper around Genkit to complement an ODM that I already built around Firestore, so I'm trying to avoid forcing developers to write Dotprompt files in case they'd rather keep everything defined in-code. defineDotPrompt looks like it should give me the best of both worlds 👍
Thanks again!

Yes, exactly, defineDotPrompt will register the prompt with Genkit!

Acknowledged! There are some efforts underway to revamp the documentation. I'll check in to make sure this is part of it.


ENH: Implement repeat plan

Description

Quick implementation of the repeat plan previously described in #929, with a refactoring of count to use repeat.
Motivation and Context

There are cases where we want to have a repeatable plan where we can leverage the kind of looping and delaying from count without rewriting the control flow. The logic in that plan isn't just a trivial for loop.
How Has This Been Tested?

count still works after being reimplemented using repeat
Misc Thoughts

I'm not in love with this implementation because I feel like it's cleaner to make a new plan with a simple for loop
This is better for the health of the library than implementing a per_step kwarg in count, and it accomplishes almost the same thing
It is up to the user to define a descriptive metadata dict and provide start and stop documents because the repeat plan doesn't do anything without being handed a plan. Fundamentally, a plan like this is not a count and each case needs to be treated differently.
I haven't pushed any docs updates related to this new stub plan

Codecov Report

Merging #936 into master will decrease coverage by 0.01%.
The diff coverage is 93.47%.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
- Coverage   90.38%   90.37%   -0.02%
==========================================
  Files          46       46
  Lines        7623     7634      +11
==========================================
+ Hits         6890     6899       +9
- Misses        733      735       +2

Impacted Files
Coverage Δ

bluesky/plans.py
85.96% <100%> (-0.56%)
:arrow_down:

bluesky/plan_stubs.py
95.3% <92.5%> (-1.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c38886...580f0d5. Read the comment docs.

@danielballan I plan to implement all your suggestions soon


Fix Issue 18595 & Issue 18596: replace MindstdRand0 w/SplitMix & templatize unpredictableSeed!UIntType

Slicing the elephant into smaller pieces. This PR differs from https://github.com/dlang/phobos/pull/6388 in that it omits entirely system entropy.
The PR's visible change is that one may now write unpredictableSeed!ulong and get a ulong. The PR's under-the-hood change is that instead of thread-local MinstdRand0 unpredictableSeed uses a global SplitMix.
Q: Why prefer global shared (atomic) instance to thread-locals?
A: It gives us an easy guarantee that the same ulong seed will not be produced by more than 1 thread except if unpredictableSeed!ulong is called 2^^64 times during the life of the application. The question should rather be, what advantage would thread-local storage give us here?
Q: What about cryptography?
A: This PR changes nothing about the current situation. unpredictableSeed is not in any sense unpredictable to an adversary willing to use mathematics.
Q: What about speed?
A: This shouldn't be a main consideration, but this implementation happens to be faster. The new unpredictableSeed takes about 1/3 the time with ldc2 -O and about 1/2 the time with dmd -O -inline. The story is even better if you compare the new unpredictableSeed!ulong to calling the old unpredictableSeed twice to produce a 64-bit value.

@n8sh does this need a changelog entry?

@thewilsonator I'll add one.

Thanks!

Added.


[Bug]: Device show non existing value

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Zwavejs2Mqtt version
6.11.0
ZwaveJS version
9.3.0
Describe the bug
I have a lot of that https://devices.zwave-js.io/?jumpTo=0x010f:0x0302:0x1000:25.25
Only one of it shows a sensor value that isn't even in the device.

To Reproduce
no clue
Expected behavior
should not show that value
Additional context
No response

Unfortunately there's nothing to be done about this I'm afraid. The air temperature one is likely from a command that got corrupted on air in a way that the checksum was still valid.
Multilevel Sensor CC V2 doesn't allow checking which sensors a device exposes, so Z-Wave JS has to trust the received commands. Including a device with Security can prevent this, but I don't recommend using S0 and this device doesn't support S2 yet.
If this really bugs you, you can re-interview the device and hope the value doesn't come back.

thank you for explaining it
I did a reinterview and hope its solved


Clear-text http/2 upgrade not working when multiple "connection" headers provided

According to https://tools.ietf.org/html/rfc7230#section-3.2.2, when multiple headers with same field name provided, the values should be concatenated, separated by comma.  However, at https://github.com/netty/netty/blob/eb7f751ba519cbcab47d640cd18757f09d077b55/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java#L287 it's picking up only the value of the first "connection" header.
We ran into this issue then a Proxygen clients tries to connect to a server written in Netty 4.1.  Proxygen is sending multiple "connection" headers, containing "upgrade" and "HTTP2-Settings" respectively.  However, Netty is expecting one single "connection" header containing "upgrade,HTTP2-Settings".

@nmittler @Scottmitch can you have a look please ?

https://tools.ietf.org/html/rfc7230#section-3.2.2

A sender MUST NOT generate multiple header fields with the same field
name in a message unless either the entire field value for that
header field is defined as a comma-separated list [i.e., #(values)]
or the header field is a well-known exception (as noted below).

Strictly speaking Proxygen should not be generating multiple headers with the same name. However the updated HTTP/1.x maybe a bit too late to define this constraint as this can be common in practice, and in fact Netty doesn't always strictly enforce this constraint (although it can via CombinedHttpHeaders). I wouldn't be against accommodating for both csv and duplicate header names here. @nmittler @normanmaurer - WDYT?

SGTM ... @ximyu do you want to throw together a PR?

Sure
On Fri, Nov 18, 2016 at 7:09 AM Nathan Mittler<EMAIL_ADDRESS>wrote:

SGTM ... @ximyu https://github.com/ximyu do you want to throw together
a PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/netty/netty/issues/6019#issuecomment-261552975, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAQ-mFCHZ1O76mWEhrzSub7SRPL6V-ztks5q_b51gaJpZM4Kxq9N
.

@ximyu thanks!

@ximyu ping

Sorry for the delay. We ended up fixing the issue from client side (Proxygen).


Track Active Users in Database

Problem
Currently, the SpeziDataPipelineTemplate lacks functionality to monitor the active users in the database. There is no mechanism to detect when each user last connected or interacted with the system. This limitation makes it challenging to understand user engagement and activity patterns.
Solution
Implement a new feature in the SpeziDataPipelineTemplate to track the last activity date of each user in the database. This feature will work as follows:

The mechanism will scan the database to extract the last interaction date for each user. This can be achieved by identifying the date of the most recent FHIR resource collected for each user.
The feature will export this information into a CSV file. The CSV file can contain two columns: UserId and LastActivityDate.
Ensure that this new feature integrates with the existing pipeline processes and add tests to verify its proper functionality.

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct and Contributing Guidelines

Hi @Vicbi ,
Sounds like an interesting feature. However, I had a few questions, regarding the input FHIR data. Would it be possible to receive access to a sample Firestore DB or more data to understand better and cover edge cases?
I also noticed there is sample_df.csv. From the source code and it seems to be a flattened_fhir_dataframe converted to a csv file. Would it be safe to make this assumption? I think it might be easier to work with the dataframe directly to implement the required functionality.  What do you think?

Hi @ArnavS59, thanks for reaching out! You’re right—there are only few data points in the sample_df. If you're looking for more extensive data access, please contact @PSchmiedmayer to discuss this further and explore additional opportunities.

Hi @Vicbi @PSchmiedmayer ,
I created a PR for it in SpeziDataPipelineTemplate as requested.
To add tests, it seems that the function would need to imported into the main SpeziDataPipeline repo first.


MOAR WINDOZE CLEANUP

Yak shaving at it's best.
CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit-windows/44/
R=@libuv/collaborators

LGTM

Amazing, though, could you add that exact explanation as a comment above the "+1"?

Landed in 4c945f49365ab4d6e1b07bf0ef2893455dc04622, 46d84eae28bbf82eb8e1ace35cead0bd73163a8e and e397caa3a6a139fff2fed06e0223ee92582fa2d2.
@txdv I added a note.


Update aes_gcm.go

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.
Please ensure you adhere to every item in this list.
More info can be found at https://github.com/golang/go/wiki/CommitMessage

The PR title is formatted as follows: net/http: frob the quux before blarfing

The package name goes before the colon
The part after the colon uses the verb tense + phrase that completes the blank in,
"This change modifies Go to ___________"
Lowercase verb after the colon
No trailing period
Keep the title as short as possible. ideally under 76 characters or shorter

No Markdown
The first PR comment (this one) is wrapped at 76 characters, unless it's
really needed (ASCII art, table, or long link)
If there is a corresponding issue, add either Fixes #1234 or Updates #1234
(the latter if this is not a complete fix) to this comment
If referring to a repo other than golang/go you can use the
owner/repo#issue_number syntax: Fixes golang/tools#1234
We do not use Signed-off-by lines in Go. Please don't add them.
Our Gerrit server & GitHub bots enforce CLA compliance instead.
Delete these instructions once you have read and applied them

I dont rlly understand why nonce size is limited.
In the spec it says its not best practice but in theory you should be able to use a longe nonce


[WIP] Pull/Push Script for Program Data

Pull program data and push program data without needing to use the pgadmin UI.
Open a pgadmin instance and connect in way that commands can be run on the database from it using existing database protections. Run push or pull command (or in the future, any command).
Changes:

Add a command to pull program data (pg_dump) to ./bin/run.
Add a command to push program data (pg_restore) to ./bin/run.
Add a command to enter an interactive shell to ./bin/run.
Generalize pgadmin startup code.
Add ecs list-tasks to our aws cli.
Add ecs execute-command to our aws cli.
Add rds describe-db-instances to our aws cli.

I believe it is acceptable to pass the db_password as part of the constructed command rather than using a .pgpass file, since our password and username and generated randomly and not stored. https://stackoverflow.com/q/2893954 is a good reference for options.

Chatted with Elliot and they mentioned:

This PR involves adding some things to the AWS CLI to make that interaction easier
90- 283 can swap out any command -> should be the same for whatever you’re doing -> db interactive shell has those lines so doesn’t need to be in every file
Tested up to line 70 on pg dump
These commands aren't connected to bin/run, but that could be added later

This functionality has mostly been added as part of https://github.com/civiform/cloud-deploy-infra/pull/311 and https://github.com/civiform/cloud-deploy-infra/pull/310.


java 8 patch

please crate a new branc for java 8 and I will add support for java8

Hi @litongjava thanks for your interest! Feel free to fork this repository and create and pull request if you want to contribute.


PowerToys not showing Minecraft Launcher's icon

Microsoft PowerToys version
0.57.2
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce

Alt+Space to trigger PowerToys run
Type in "Minecraft Launcher"

✔ Expected Behavior
Showing Minecraft Launcher's Icon
❌ Actual Behavior
Showing missing icon

Other Software
No response

Turnning down "Run as Admin" still not works

It was somehow solved.


Fixes #109 - Add support for updating to new versions on Windows

Also make package_version do the same thing on Linux and Windows.

I'll get the spec test fixed up and updated tomorrow. I have to take off now...

I'm thinking this should not be a breaking change. Anyone that updates, on Windows, would just get the extra file to indicate installed version.  Do you see anything that would break any existing users?

Now that I look at it... For existing users on Windows, it will stop their service, replace the Filebeat dir, then add the new version file. It will be at the same version they had before, but some may not expect to have any change and any filebeat logs may be lost, if they are in that dir. The registry is in another dir by default, so no interruptions of data sent to the outputs should be caused. The registry tracks where filebeat was on the prospectors...
Nothing breaking should happen here, but its probably worth a note in the CHANGELOG, that things will happen...

For updating, we have concern about filling up the C:/Windows/Temp dir with all the versions of the zip we will be downloading over time.
To correct this I had to switch to archive rather than remote_file, bc it has a creates option and allows me to purge the old zip after extraction and not re-download it.
Anyone have issue with switching to archive? It's also supported module and generally pretty good.

I've used archive for other modules and have no problems with it at all (it just kinda does its thing). Let me know when you're comfortable with me merging this and I'll go ahead and take care of it (I'll fix whatever tests are failing then too - it looks like the issues now have nothing to do with your changes).
Thanks again!

I found the first issue and just made a commit to fix it:
The newest version of the apt module does not support puppet 3 and the tests are running against puppet 3. I have pinned it to the latest apt that supports puppet 3 and 4...

Thanks - are you ready for me to merge? I know you've found a few other issues that I wouldn't have found (like the temp folder filling up), so I don't want to merge when you think you have more to go (not that we can't just merge more later).

@pcfens Tests all fixed up ;)
I'm ready when you are.

Thanks again. I'll try and roll a new release either later tonight or tomorrow morning, with a note in the changelog about the windows agent restarting.

Awesome... Now off to make the same changes here: https://github.com/skynetsolutions/puppet-winlogbeat


There are not enough rules to produce a node with desired properties

Describe the bug
The drill report a exception since a query running,
report msg:There are not enough rules to produce a node with desired properties
To Reproduce
CREATE TABLE ORDERS  ( O_ORDERKEY       INTEGER NOT NULL,
O_CUSTKEY        INTEGER NOT NULL,
O_ORDERSTATUS    CHAR(1) NOT NULL,
O_TOTALPRICE     DECIMAL(15,2) NOT NULL,
O_ORDERDATE      DATE NOT NULL,
O_ORDERPRIORITY  CHAR(15) NOT NULL,
O_CLERK          CHAR(15) NOT NULL,
O_SHIPPRIORITY   INTEGER NOT NULL,
O_COMMENT        VARCHAR(79) NOT NULL);
CREATE TABLE LINEITEM ( L_ORDERKEY    INTEGER NOT NULL,
L_PARTKEY     INTEGER NOT NULL,
L_SUPPKEY     INTEGER NOT NULL,
L_LINENUMBER  INTEGER NOT NULL,
L_QUANTITY    DECIMAL(15,2) NOT NULL,
L_EXTENDEDPRICE  DECIMAL(15,2) NOT NULL,
L_DISCOUNT    DECIMAL(15,2) NOT NULL,
L_TAX         DECIMAL(15,2) NOT NULL,
L_RETURNFLAG  CHAR(1) NOT NULL,
L_LINESTATUS  CHAR(1) NOT NULL,
L_SHIPDATE    DATE NOT NULL,
L_COMMITDATE  DATE NOT NULL,
L_RECEIPTDATE DATE NOT NULL,
L_SHIPINSTRUCT CHAR(25) NOT NULL,
L_SHIPMODE     CHAR(10) NOT NULL,
L_COMMENT      VARCHAR(44) NOT NULL);
select L_ORDERKEY,O_ORDERKEY from lineitem  right join orders on O_ORDERKEY = L_ORDERKEY where L_ORDERKEY = 1 ;
Expected behavior
The query should be running normally
Screenshots
Error: SYSTEM ERROR: CannotPlanException: There are not enough rules to produce a node with desired properties: convention=PHYSICAL, DrillDistributionTraitDef=SINGLETON([]), sort=[].
Missing conversion is VertexDrel[convention: LOGICAL -> PHYSICAL, DrillDistributionTraitDef: ANY([]) -> SINGLETON([])]
There is 1 empty subset: rel#3618:Subset#15.PHYSICAL.SINGLETON([]).[], the relevant part of the original plan is as follows
3579:VertexDrel
3577:DrillProjectRel(subset=[rel#3578:Subset#14.LOGICAL.ANY([]).[]], L_ORDERKEY=[CAST($0):INTEGER], O_ORDERKEY=[$1])
3575:JdbcJoin(subset=[rel#3576:Subset#13.JDBC.mysql.ANY([]).[]], condition=[=($1, $0)], joinType=[inner])
3572:DrillFilterRel(subset=[rel#3573:Subset#11.LOGICAL.ANY([]).[]], condition=[=($0, 1)])
3306:JdbcTableScan(subset=[rel#3571:Subset#10.JDBC.mysql.ANY([]).[]], table=[[mysql, test, lineitem]])
3307:JdbcTableScan(subset=[rel#3574:Subset#12.JDBC.mysql.ANY([]).[]], table=[[mysql, test, orders]])
Root: rel#3583:Subset#16.PHYSICAL.SINGLETON([]).[]
Original rel:
LogicalProject(subset=[rel#3356:Subset#4.LOGICAL.ANY([]).[]], L_ORDERKEY=[$0], O_ORDERKEY=[$1]): rowcount = 225.0, cumulative cost = {225.0 rows, 450.0 cpu, 0.0 io, 0.0 network, 0.0 memory}, id = 3354
LogicalFilter(subset=[rel#3353:Subset#3.NONE.ANY([]).[]], condition=[=($0, 1)]): rowcount = 225.0, cumulative cost = {225.0 rows, 1500.0 cpu, 0.0 io, 0.0 network, 0.0 memory}, id = 3352
LogicalJoin(subset=[rel#3351:Subset#2.NONE.ANY([]).[]], condition=[=($1, $0)], joinType=[right]): rowcount = 1500.0, cumulative cost = {1500.0 rows, 0.0 cpu, 0.0 io, 0.0 network, 0.0 memory}, id = 3350
JdbcTableScan(subset=[rel#3348:Subset#0.JDBC.mysql.ANY([]).[]], table=[[mysql, test, lineitem]]): rowcount = 100.0, cumulative cost = {100.0 rows, 101.0 cpu, 0.0 io, 0.0 network, 0.0 memory}, id = 3306
JdbcTableScan(subset=[rel#3349:Subset#1.JDBC.mysql.ANY([]).[]], table=[[mysql, test, orders]]): rowcount = 100.0, cumulative cost = {100.0 rows, 101.0 cpu, 0.0 io, 0.0 network, 0.0 memory}, id = 3307
Additional context
Add any other context about the problem here.

This looks like an invalid query.  Unless you ran this and selected a default schema first, it is necessary to specify what storage plugin you are creating a table in.   IE:
CREATE TABLE mysql.ORDERS ( O_ORDERKEY INTEGER NOT NULL,
O_CUSTKEY INTEGER NOT NULL,
O_ORDERSTATUS CHAR(1) NOT NULL,
....

Note that this query spells out mysql.ORDERS rather than just ORDERS.
Lastly, what version of Drill are you using?

This looks like an invalid query. Unless you ran this and selected a default schema first, it is necessary to specify what storage plugin you are creating a table in. IE:
CREATE TABLE mysql.ORDERS ( O_ORDERKEY INTEGER NOT NULL,
O_CUSTKEY INTEGER NOT NULL,
O_ORDERSTATUS CHAR(1) NOT NULL,
....

Note that this query spells out mysql.ORDERS rather than just ORDERS.
Lastly, what version of Drill are you using?

I have create table xxx in mysql client terminal directly and just run sql on drill client。 The  same sql run in mysql client and got a correct result set ，but drill not。
It bother me long time, i was try to read source code to find out way to fix it, but i was failure, and you can use newest version to reproduct issue.

I have create table xxx in mysql client terminal directly and just run sql on drill client。 The same sql run in mysql client and got a correct result set ，but drill not。 It bother me long time, i was try to read source code to find out way to fix it, but i was failure, and you can use newest version to reproduct issue.

Can you post your storage config after redacting any sensitive details? Which JDBC driver are you using? Are you able to run select * from mysql.lineitem limit 10 from Drill successfully?

I have create table xxx in mysql client terminal directly and just run sql on drill client。 The same sql run in mysql client and got a correct result set ，but drill not。 It bother me long time, i was try to read source code to find out way to fix it, but i was failure, and you can use newest version to reproduct issue.

Can you post your storage config after redacting any sensitive details? Which JDBC driver are you using? Are you able to run select * from mysql.lineitem limit 10 from Drill successfully?

first of all ，the columns both in the table lineitem and  the table order should be set "not null"
storage config as follows：
{
"type": "jdbc",
"driver": "com.mysql.jdbc.Driver",
"url": "jdbc:mysql://...:3306",
"username": "root",
"password": "********",
"writerBatchSize": 10000,
"enabled": true
}
JDBC driver as follows：
mysql-connector-java-8.0.29.jar
mysql-connector-java-5.1.49.jar
tip: both of jdbc drive can be reproduce issue , whatever use which one;
select * from mysql.lineitem limit 10 could be succeed；
some sql exec phenomenon could help perhaps
1 failure： select L_ORDERKEY,O_ORDERKEY from lineitem right join orders on O_ORDERKEY = L_ORDERKEY where L_ORDERKEY = 1 ;
success：select L_ORDERKEY,O_ORDERKEY from lineitem  right join orders on cast(O_ORDERKEY as int)  = L_ORDERKEY where L_ORDERKEY  = 1 ;
some sql exec phenomenon could help perhaps
2 failure： select L_ORDERKEY,O_ORDERKEY from lineitem right join orders on O_ORDERKEY = L_ORDERKEY where L_ORDERKEY = 1 ;
success： select L_ORDERKEY,O_ORDERKEY from lineitem right join orders on O_ORDERKEY = L_ORDERKEY ;
3 failure： select L_ORDERKEY,O_ORDERKEY from lineitem right join orders on O_ORDERKEY = L_ORDERKEY where L_ORDERKEY = 1 ;
success： select L_ORDERKEY,O_ORDERKEY from lineitem right join orders on O_ORDERKEY = L_ORDERKEY where O_ORDERKEY = 1  ;
i was fouce on calcite program call stack  as follow:
createCastRel:720, RelOptUtil (org.apache.calcite.plan)
convert:2449, RelBuilder (org.apache.calcite.tools)
perform:280, FilterJoinRule (org.apache.calcite.rel.rules)
onMatch:384, FilterJoinRule$FilterIntoJoinRule (org.apache.calcite.rel.rules)
onMatch:208, VolcanoRuleCall (org.apache.calcite.plan.volcano)
findBestExp:633, VolcanoPlanner (org.apache.calcite.plan.volcano)
run:327, Programs$RuleSetProgram (org.apache.calcite.tools)
transform:405, DefaultSqlHandler (org.apache.drill.exec.planner.sql.handlers)
transform:351, DefaultSqlHandler (org.apache.drill.exec.planner.sql.handlers)
convertToRawDrel:245, DefaultSqlHandler (org.apache.drill.exec.planner.sql.handlers)
convertToDrel:308, DefaultSqlHandler (org.apache.drill.exec.planner.sql.handlers)
getPlan:173, DefaultSqlHandler (org.apache.drill.exec.planner.sql.handlers)
getQueryPlan:302, DrillSqlWorker (org.apache.drill.exec.planner.sql)
getPhysicalPlan:178, DrillSqlWorker (org.apache.drill.exec.planner.sql)
convertPlan:143, DrillSqlWorker (org.apache.drill.exec.planner.sql)
getPlan:108, DrillSqlWorker (org.apache.drill.exec.planner.sql)
runSQL:593, Foreman (org.apache.drill.exec.work.foreman)
run:274, Foreman (org.apache.drill.exec.work.foreman)
runWorker:1149, ThreadPoolExecutor (java.util.concurrent)
run:624, ThreadPoolExecutor$Worker (java.util.concurrent)
run:750, Thread (java.lang)
we can track this function ”areRowTypesEqual()“ from progrem call stack as above  ，if comment out code
”  if (!type1.equals(type2)) {
return false;
}“
in function ”areRowTypesEqual“ by RelOptUtil.java  ,the issue was fixed ,  but some unit test in calsite can not passd
it just my option ,maybe it was trouble idea in the beginning

Thanks, you've definitely provided enough high quality information for us to promote this to a Jira issue.

Hi Charles :
I have create table xxx in mysql client terminal directly and just run sql on drill client。
The  same sql run in mysql client got a correct result set ，but drill not。
It bother me long time, i was try to read source code to find out way to fix it, but i was failure, and you can use newest version to reproduct issue.
                                                                                thanks for reply

At 2022-08-15 10:54:52, "Charles S. Givre" @.***> wrote:
This looks like an invalid query. Unless you ran this and selected a default schema first, it is necessary to specify what storage plugin you are creating a table in. IE:
CREATE TABLE mysql.ORDERS ( O_ORDERKEY INTEGER NOT NULL,
O_CUSTKEY INTEGER NOT NULL,
O_ORDERSTATUS CHAR(1) NOT NULL,
....
Note that this query spells out mysql.ORDERS rather than just ORDERS.
Lastly, what version of Drill are you using?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Change internal design of Context

Description
Changes the internal design of Context which removes the linked-list design previously used and replaces it with a more densely packed style. Internal implementations hold 1-4 key-value pairs are added which locate keys and values more closely and an infinite size array-based implementation is added which keeps the context holders more closely together. This should reduce memory misses.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Closing, performance investigation has shown the improvement is negligible or made worse with this change.


adding C++ language

Things added/changed:

Add the C++ language to the list.

@amino19, ping. Nobody is watching this repository. 👀

@amino19, ping. Nobody is watching this repository. eyes

@Panquesito7: Actually we do, but working at back-end, also we consider installation.md in here!
Confused?

Should I start working on this PR again, or is someone working on it? Thanks. 🙂

Should I start working on this PR again, or is someone working on it? Thanks. slightly_smiling_face

Yes, obv! :slightly_smiling_face:
Pl start contributing as it follows here.

@Panquesito7: I hope you're not forgotten about this Open Source Journey, emphasis on you isn't a good step because I believe you are already passionate about Open Source contributions, pl make it done, or assign anyone who completes this for you! :slightly_smiling_face:

Working on this (sorry for the very very long delay).


HHH-10883 - Fix Restore the Maven artifact hibernate-java8 as an empt…

…y placeholder
https://hibernate.atlassian.net/browse/HHH-10883

applied upstream


targeted the working version of the dfx sdk

I updated the dfx sdk version to target the last known working version per #6, as the current targeted version was presenting an unworking app.
I do see that in 5f5dfc4a2dc5a818e3c8d2599e53a0f756a0d997, you made a number of updates to target 0.6.14, but they seem to still work in 0.6.4, while 0.6.4 also does continue to work/run in my testing.

No longer relevant.


Assistance you asked for. Should work now

Basement.cs

Updated to prevent multiple enumeration

Updated various references and patches to target the method and be a bit cleaner.
Removed some ref to an assembly in a random folder.
Update refs to be dynamically grabbed.
Changed some variables, updated for ServerSync and a file watcher.
Updated PieceManager.dll

Thank you so much!


Added support to specifiy custom endpoint

Main purpose of this PR is to enhance the support to provide custom endpoint url which can be used to connect to other S3 compatibly storage services like Minio.
I also want to know if there is any reason preventing from adding the extra condition to create a bucket if it doesn't exist similar to https://github.com/docker/distribution/blob/master/registry/storage/driver/azure/azure.go#L87

Current coverage is 52.73%

Merging #1512 into master will decrease coverage by -7.19% as of 0015902

@@            master   #1512   diff @@
======================================
  Files          128     128
  Stmts        10920   10935    +15
  Branches       884     782   -102
  Methods          0       0
======================================
- Hit           6544    5767   -777
+ Partial        884     782   -102
- Missed        3492    4386   +894

Review entire Coverage Diff as of 0015902

Uncovered Suggestions

+0.21% via registry/registry.go#106...127
+0.21% via .../driver/s3-aws/s3.go#247...268
+0.18% via registry/registry.go#217...235
See 7 more...

Powered by Codecov. Updated on successful CI builds.

cc @BrianBland

@BrianBland i had made the changes mentioned.
Also can you answer the question i asked regarding creation of the bucket if it doesn't exist

@kmala I think the reason for doing this is to minimize the required permissions for running the S3 driver, as listing buckets/creating buckets requires permissions other than operations within a specific bucket in S3. I'm personally not opposed to adding this behavior, but we should either document the permissions required or ignore errors.

@BrianBland Can you review it again and see if something needs to be done

@BrianBland added your review comments

LGTM, thanks for the quick updates

@BrianBland can this be merged

LGTM


Use gpt-3.5-turbo instead of code-davinci-002

Codex is shutting down on Thursday! That's fast!
But ChatGPT 3.5 seems fine as a replacement. For some reason this time I'm using langchain for executing the query, but not for building the prompt. The opposite of how it was used previously.
An example conversation:
[A bunch of examples and details.]
You need to write a function `compute_from_graph(nodes, edges)` for the following task:
- find the violin player with the least enemies

The function should return a DataFrame with columns: name: str, friend_count: int

```python
def compute_from_graph(nodes, edges):
  """find the violin player with the least enemies"""
  violin_players = nodes[nodes['job'] == 'violin player']
  enemies = edges[edges['relationship'] == 'enemies']
  violin_players['enemy_count'] = enemies.groupby('src').size()
  return violin_players.nsmallest(1, 'enemy_count')
```

Make sure the result has these columns: name: str, friend_count: int

I apologize for the mistake in my previous response. Here's the corrected function:

```python
def compute_from_graph(nodes, edges):
  """find the violin player with the least enemies"""
  violin_players = nodes[nodes['job'] == 'violin player']
  friends = edges[edges['relationship'] == 'friends']
  violin_players['friend_count'] = friends.groupby('src').size()
  return violin_players.nsmallest(1, 'friend_count')[['name', 'friend_count']]
```

This function will return a DataFrame with columns `name` and `friend_count`.

It's so funny that in the last message ChatGPT apologizes! 😄 The poor thing. It's just a bad input, I modified the query but forgot to modify the output schema.
I haven't tested this heavily. I'll build another PR on top that allows customizing the examples. I'll test that more thoroughly.

Haha, got another funny generation for the same thing:
  enemyships = edges[edges['relationship'] == 'enemies']

😄


device.Pull return {TypeError}coercing to Unicode: need string or buffer, file found

use python2.7
device.Pull(file_name, dest_file)
return {TypeError}coercing to Unicode: need string or buffer, file found
And I must use follow way to get work around:
    file_bytes = device.Pull(file_name)
    output_file = open(dest_file, "wb")
    output_file.write(file_bytes)
    output_file.close()

linuxmint

Try master as of now? Okay, then 'b' also affects the expected type in write() instead of just the way the file is opened on Windows

Sorry, its my fault. May be lost object bug in my code, can pull picture now. And it doesnt with 'b'.Thanks for your help!

Does it work with 'b' though? I think it's necessary for Windows, so if it works in Linux then I'll leave that change

Yes, bot add 'b' or without 'b' , can work in my linux

How about with that commit? https://github.com/google/python-adb/commit/82bfd5201e8294837e66d0558a48225cdab9ceb1

Tested ok, even if remove
elif isinstance(dest_file, file):
    pass


VRVU-61: Collected data that should be displayed for current visit

Well done @jdolkowski  @druchniewicz


skeleton README needs refresh

Various info are arranged in lack of structure. Looks a mess.

In addition, protobuf-c-compiler 1.2.x provided by ubuntu distro is not working at all. It is required to provide to the explicitly steps to work around this issue.


[Docs] reStructuredText link markup is broken

Describe the bug, including details regarding any error messages, version, and platform.
https://arrow.apache.org/docs/format/Glossary.html#term-record-batch

record batch
In the :ref:`IPC format <format-ipc>`: the primitive unit of data. A record batch consists of an ordered list of buffers corresponding to a schema.

":ref:`IPC format <format-ipc>`" should be linked to https://arrow.apache.org/docs/dev/format/Columnar.html#format-ipc .
Component(s)
Documentation

Hello @kou
I am a beginner in open source.
can you help me with  how can I proceed to solve this issue ?

Welcome!
Could you read our general contribution documents carefully as the first step?
https://arrow.apache.org/docs/dev/developers/contributing.html

In general, most open source projects provide "how to contribute" documentation.
A new contributor reads the documentation as the first step.

take

hi can you please tell me how do i procced with this issue? @kou


No ABC preview sound

All my midis play just fine as the original. However, now when I add instruments and try to listen via ABC preview, there's no sound. There have been several recent updates with Lotro, so maybe that's the issue? Although I don't know how that would affect ABC sound in Maestro. And the ABC files I have already created do still play in game. Does the program need an update or something? Or is this just happening to me?

Nevermind. I figured it out. My AMD audio driver needed updating, apparently. I also reinstalled Java too, but it was likely the driver.


#72 - Pull request

@thysultan
Please review the changes from branch "issue72".
Please let me know if there's something to change or fix.
Remarks:

Some files use tabs instead of spaces (script/build/index.js etc) => I have not change that because it could (depending of the diff tool) cause some diff noise. Maybe you can convert the tabs whenever you like to do in future.

In packages.json the "files" configuration lists all files of the "dist" directory explicitly. I've listed them explicitly as this was also done before. File patterns would also have been worked.

Coverage remained the same at 100.0% when pulling 05c6917a1434870fbdd003c7e74a03a3dde98fe4 on issue72 into f319359381604edae382081c9f333810cd28772c on master.

Thanks. I noticed that coveralls reports on just the production builds, is this the same on your local machine?

@thysultan
Thanks for that bug report regarding coveralls:
"npm test" runs nyc two times ... one for development, one for production ... had to use option "--no-clean" in the second run to prevent nyc from clearing the results from the first run.
=> is fixed ... could you please check again?

@mcjazzyfunky Yes it now reports on both dev and prod builds.


JETAnalyzer: special case MethodErrorReport for [map]reduce_empty

In the :basic mode, downgrade MethodErrorReport on call of reduce_empty or mapreduce_empty to UncaughtExceptionReport so that it can be filtered out in common cases.
xref: https://github.com/JuliaLang/julia/pull/41885/

Codecov Report
Patch coverage: 91.66% and project coverage change: -0.01 :warning:

Comparison is base (739f3a9) 88.83% compared to head (17ba0ef) 88.82%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   88.83%   88.82%   -0.01%
==========================================
  Files          10       10
  Lines        2973     2989      +16
==========================================
+ Hits         2641     2655      +14
- Misses        332      334       +2

Impacted Files
Coverage Δ

src/analyzers/jetanalyzer.jl
88.25% <91.66%> (-0.02%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Ability to hide top bar icon

It would be awesome!

Please try 0.3.1 and defaults write org.p0deje.Maccy showInStatusBar false

Thanks!


x/build/devapp: support R= annotations in commit messages

I see people using R= in commit messages, instead of in comments:
https://go-review.googlesource.com/c/go/+/91435
https://go-review.googlesource.com/c/go/+/63274
Do we want to support R= in commit messages too?
Easy technical change. But do we care about commit message prettiness? One CL was R=go1.11 and we approved it for Go 1.10. Fortunately @tklauser updated the commit message before submitting, but that won't always be the case if we make our tooling support R=go1.N and promote its use.
/cc @andybons @ianlancetaylor

Also, I want this (and others like DNR, etc) is documented in the contribution guideline.

Used R= in the commit message based on other CLs i had seen. e.g.
https://go-review.googlesource.com/c/go/+/86035
My intention is to remove them from my commit messages once the tree is open and before commit but I too see the problem that it is easy to forget.

I suppose we could also make the bot mark them as Do-Not-Submit (or just -2 them) until the R=go1.N tree is open too.

But do we care about commit message prettiness?

I do.
For those who are heavy git mail users, we could add a secret flag (like -trybot) to auto-add an R=go1.N comment.
A similar question exists for RELNOTE=yes. I would prefer to see them in gerrit but not commit messages, personally.
Does gerrit suppose pre-submit hooks? We could have gerrit rewrite away such lines in the commit message. Then out bot would just need to replicate the commit message annotations in gerrit comments.

Used R= in the commit message based on other CLs i had seen. [...]
My intention is to remove them from my commit messages once the tree is open and before commit but I too see the problem that it is easy to forget.

Same for me. Also, my idea was to save reviewer's time (even though https://golang.org/cl/91055 was then approved for go1.10) and for myself to keep track of my branches/CLs locally. Also being a git mail user, it would be nice to have a way to mark a CL targeting a specific R=go1.N locally as well as in gerrit (and have the two in sync).

I actually propose we stop using magic comments and start using CL-level tags in Gerrit. Gerrit calls the feature "hashtags", and it's now supported by the PolyGerrit UI. We're using them in Perkeep and they're great. It means we can search on them, too.
On their silly name: https://groups.google.com/forum/#!topic/repo-discuss/jZ0raMyuiG0
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-hashtags
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-hashtags
Example Gerrit search: https://camlistore-review.googlesource.com/q/is:open+-owner:mathieu+-hashtag:op (we use the "op" tag in Perkeep to mean that it's the CL author's turn to do something).
/cc @andybons

(we use the "op" tag in Perkeep to mean that it's the CL author's turn to do something).

This can also be achieved by setting the “assignee” field, right?

This can also be achieved by setting the “assignee” field, right?

Maybe. It was just an example.

The Gerrit hashtag wait-release has replaced the old R=go1.N syntax (see https://github.com/golang/go/issues/24836#issuecomment-497090827), and so R= isn't used anywhere by now. Issue #24836 tracks its documentation. I don't think there's anything more to do here.


Added rust highlighting for griddycode

Following the py.lua file and js.lua file i created rust.lua file which does the same function of js.lua and python.lua

please reopen pull request with only adding a rust.lua file

see #143

i did the changes required, when can i expect my request to be merged?
On Tue, 11 Jun 2024 at 13:12, Awbert @.***> wrote:

see #143 https://github.com/face-hh/griddycode/pull/143
—
Reply to this email directly, view it on GitHub
https://github.com/face-hh/griddycode/pull/142#issuecomment-2160017572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APCD3ZRP272PZXX4ZE2IZNTZG2S45AVCNFSM6AAAAABJDTZCP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQGAYTONJXGI
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


M3-1435: add tagsPanel story

Add TagsPanel story
Add axios-mock-adapter to mock API calls in stories

Coverage decreased (-0.04%) to 27.825% when pulling d99318e958fedbc09dff2a52d0b7ee364633cbf6 on rulikrulit:feature/M3-1435-storybook into ef920b6863b8fde0e8cf5ba488e5616acd9517bc on linode:feature/M3-1433-to-M3-1437-domain-tags.


Switch back to sdelete 1.61

This is 10X faster
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

PR: https://github.com/boxcutter/windows/pull/123


Add azure tables application demo for python

Add azure tables application demo for python, with reference to repo msdocs-azure-data-tables-sdk-dotnet
@mario-guerra, @lmazuel , @annelo-msft for notification.

@annatisch , @YalinLi0312 I have updated by your comments, please re-review this PR.

@v-xuto please add the following copyright notice to all the source files you created for this project:
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
Also, is it possible to rename the repo to 'msdocs-azure-tables-sdk-python-flask' as per David's suggestion?

@annatisch We have updated by your comments, please re-review this PR.
If there is no problem, please approve this PR. Thanks a lot.

@vcolin7 We have updated by your comments, please re-review this PR.
If there is no problem, please approve this PR. Thanks a lot.

@mario-guerra Two people here have approved this PR, can we merge this PR now?

@v-xuto PR has been merged, thanks for your work on this.


fix(delta): PROJ-428 Convert ValueProperty class fields from mandatory to optional

oh wait but we don't get the actual value of the property (which is the purpose of that function)
can you also add to our model, optional fields that match the real response we saw?
like
"present-value":{"$base":"Real","value":"22.54"},"status-flags":{"$base":"BitString","value":""},"event-state":{"$base":"Enumerated","value":"normal"},"out-of-service":{"$base":"Boolean","value":0},"units":{"$base":"Enumerated","value":"\u00b0C"},"description":{"$base":"String","value":"Temperature"},"reliability":{"$base":"Enumerated","value":"no-fault-detected"}}


observable.take() documentation is circular hence offers no definition

The documentation provided for Bacon at this page could be infinitely improved by specifying the operations performed in javascript terms.
For example, observable.take( ) and it's related function calls observable.takeX() all refer to the same 'take' operation without ever defining what take means, and no javascript-oriented contract is described.
"observable.take(n) takes at most n elements from the stream"

Currently there seems to be an expectation that the developer already knows everything about Bacon and operations are therefore described in Bacon terms, meaning it's impenetrable from the outside . One specific gap which could help people trying to fill in the gaps would be specifying the return type for every operation. In this case...

Does it return an Array containing already-queued Bacon events satisfying the takeX() criterion?
Does it return an Array containing any already-queued Values in the stream satisfying the criterion?
Does it return a Stream which will serve the specified values or events then end as soon as events satisfying the criterion have arrived?
Does it return a thenable or Promise which allows future operations to be scheduled when the criterion is satisfied?
Does it block waiting for the specified collection of events to arrive?

However crazy some of these alternatives might be, as a developer outside the project, (or possibly new to javascript), you still have to eliminate all these possibilities and somehow invent or introspect what the operations do which is extremely hard. I'm certain people with project knowledge would be able to provide this extra precision and I believe it is a requirement for seamless adoption.
Out of interest, what does observable.take(...) do?

I agree that some bits are a bit vaguely described. The way I read you two things stand out: a general description of how Bacon works and API documentation of individual methods. I'm not really in a position to say whether general documentation and tutorials are good enough, but I find that the API documentation is most of the time giving the information I seek. On the top of my head all methods return a stream except subscribe and its derivatives, which is noted, so repeating this wouldn't be useful. But it's good to get concrete suggestions and it's good to hear experiences of the documentation.
As for take, it says "takes at most n elements from the stream.", which more formally means that take takes n elements or all the elements up to the end of the stream, whichever is fewer and then just propagates the end event. Looking at the documentation, it could be useful to add the additional detail and rearrange take to be first before its variants.

Thanks for exploring this documentation improvement. The fact that all methods return a stream is non-obvious I think, and would ideally be recorded against each method, detailing the nature of the returned stream.
The phrase 'takes...elements from the stream' is quite misleading. Although I can see the value of the method itself having a short evocative name, the documentation has to resolve the ambiguity from using this word in an unconventional sense. 'Taking' can only really be interpreted in colloquial english as removing things from the stream, which it does not do. If colloquial english is not intended, then I believe a more precise type of language, suited for a method definition, should be used instead.
In the end, I've learned take() doesn't take any elements from the source stream at all, it...
creates a new stream which _notifies_ at most n future events
generated by the source stream. The stream ends after n events
or when the source stream ends.

...but figuring this out backwards from the implementation is a hard road.

Guys, would you like to submit a PR to improve the docs. I find more value in trying to fix things than in discussing how wrong things are :)

I've created a PR: https://github.com/baconjs/bacon.js/pull/623


Implement from_bytes_be operation inside the felt module for bigint_felt

Is your feature request related to a problem? Please describe.
The transformation from big endian bytes to felt is missing right now.
Describe the solution you'd like
We should have the ability to create a felt from the collection of big endian bytes.

On it

Clarification question:
The function that should be implemented for bigint_felts is the one from the BigInt crate?
https://docs.rs/num-bigint/latest/num_bigint/struct.BigInt.html#method.from_bytes_be

It appears the from_bytes_be operation is already implemented for felts and bigint felts.
felt/src/lib.rs
impl Felt {
// --snip--
    pub fn from_bytes_be(bytes: &[u8]) -> Self {
        Self {
            value: FeltBigInt::from_bytes_be(bytes),
        }
    }

felt/src/bigint_felt.rs
impl FeltOps for FeltBigInt<FIELD_HIGH, FIELD_LOW> {
// --snip--
    fn from_bytes_be(bytes: &[u8]) -> FeltBigInt<FIELD_HIGH, FIELD_LOW> {
        let mut value = BigUint::from_bytes_be(bytes);
        if value >= *CAIRO_PRIME {
            value = value.mod_floor(&CAIRO_PRIME);
        }
        Self::from(value)
    }

Both are also tested.
Is anything else needed?
PS: apparently, the test from_bytes_be in bigint_felt.rs would break in Cairo, as parsing the bytes for b"Hello world!" does not equal b"22405534230753963835153736737"


CORS Configurations: Access Control Allow Methods Not Working Properly

Description
Even though a http method is removed from the Access Control Allowed Methods list for an API from the publisher portal, that method can be successfully invoked from the developer portal.
It was observed Access-Control-Allow-Methods:  header is empty for the following request.
curl 'https://localhost:8244/t/wso2.com/pizzashack/1.0.0/menu' -X OPTIONS -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:124.0) Gecko/20100101 Firefox/124.0' -H 'Accept: */*' -H 'Accept-Language: en-US,en;q=0.5' -H 'Accept-Encoding: gzip, deflate, br' -H 'Access-Control-Request-Method: GET' -H 'Access-Control-Request-Headers: abc,authorization' -H 'Referer: https://localhost:9444/' -H 'Origin: https://localhost:9444' -H 'Connection: keep-alive' -H 'Sec-Fetch-Dest: empty' -H 'Sec-Fetch-Mode: cors' -H 'Sec-Fetch-Site: same-site'

HTTP/1.1 200 OK
Origin: https://localhost:9444
Accept: */*
Access-Control-Allow-Origin: https://localhost:9444
Access-Control-Allow-Methods:
Referer: https://localhost:9444/
Sec-Fetch-Dest: empty
Sec-Fetch-Site: same-site
Host: localhost:8244
Accept-Encoding: gzip, deflate, br
Access-Control-Allow-Headers: authorization,Access-Control-Allow-Origin,Content-Type,SOAPAction,apikey,Internal-Key,abc,Authorization,ApiKey
Sec-Fetch-Mode: cors
activityid: fca119fa-5245-4598-8305-a41d633f6028
Access-Control-Expose-Headers:
Access-Control-Request-Method: GET
Access-Control-Request-Headers: abc,authorization
Accept-Language: en-US,en;q=0.5
Date: Mon, 01 Apr 2024 06:36:36 GMT
Transfer-Encoding: chunked
Connection: keep-alive

Steps to Reproduce

Deploy the sample API from publisher portal
Enable CORS configuration for the API from Runtime Configurations
Remove GET from Access Control Allowed Methods
Save and deploy the API
Login to Developer portal and invoke an API resource with GET method

Affected Component
APIM
Version
4.3.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Please note that this can be reproduced in APIM 4.2.0 pack as well.


feat: revamped dag api

ref: https://github.com/ipfs/interface-ipfs-core/issues/81#issuecomment-277271941

[x] merge get and resolve
[x] localResolve option
[x] put with cid or with hashAlg and format
[x] refactor dag-pb tests
[x] new basic tests
[x] refactor dag-cbor tests
[x] refactor eth-block tests
[x] refactor all-together-now tests

done, ready for review :)

nice!


Release 5.0.0.Beta3

Follows on #3306 with a pom version bump.
I'm basically just using the pull player to test this before doing the release the normal way.

Core - Full Integration Build 7408 outcome was FAILURE using a merge of cc18750a7dfe8c603584fa690e88d07f91e9aeb4
Summary: Exit code 1 (new) Build time: 00:02:21


Ability to create an action item from a thought

Feature Request
As a user of RetroQuest
I need the ability to create an action item from a thought
So that I can take action from a thought without retyping it
Acceptance Criteria
Given I have entered a thought
When I select to create an action item from the thought
Then the action item is automatically created from the thought

This can been completed as of the recent merge into dev


Reference-style Markdown links not working in a Task element [in Reading mode]

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
When writing a checklist item, which gets parsed as a task, I want to use a reference-style link and have it display as a link in Reading Mode.
The Markdown source:
- [obsidian][0]
- [ ] [obsidian2][0]
- [x] [obsidian3][0]

[0]: https://obsidian.md/

The result I'm expecting (screenshot taken in the sandbox vault):

Current behaviour
Currently, when having the plugin enabled, the above does not work (also tried it with a global task filter).
Screenshot with the plugin enabled:

Steps to reproduce

Set the global task filter to empty
Create an empty note with this Markdown source

- [obsidian][0]
- [ ] [obsidian2][0]
- [x] [obsidian3][0]

[0]: https://obsidian.md/

Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[ ] macOS
[X] Windows

Obsidian Version
1.5.11
Tasks Plugin Version
6.2.0
Checks

[X] I have tried it with all other plugins disabled and the error still occurs

Possible solution
No response

It does indeed seem that this hasn't been reported before.
I've searched for 'Reference' in the list of known limitations.
For now, it should be added to the docs as a known limitation.

The list of rendering mode bugs is long.
Likely the facility will need to be rewritten to be less intrusive, which will be a reasonable size project. There are (too) many other things already going on, so unfortunately I can't see this issue being fixed any time soon.

Thanks for logging this @TheCrether.


Added StringResolver

This allows to replace the toString() method that is used in RawFilter
and EscapeFilter with one that has access to the context, ie. to access
the current locale and other things.

I'm relunctant to merge that change. instanceof affects performance a lot and I think it's gonna drop.
Did you take a look at AttributeResolver interface and add it to the registry ? Maybe you can achieve what you need with that
https://pebbletemplates.io/wiki/guide/extending-pebble/

Well, it would be nice if we could actually compare the performance with how it did before, before throwing it away. But if it turns out to be a performance issue, one could still make it optional.
I'd be happy to implement it in another way, I just don't know how. I need to access the context from toString() in order to resolve the current language, mostly. The object I'm using this with is already an AttributeResolver.

I just found this reference concerning the instanceof speed: https://stackoverflow.com/questions/103564/the-performance-impact-of-using-instanceof-in-java
I would not expect using instanceof here would make much of a difference.

@axeld You can run this benchmark https://github.com/PebbleTemplates/pebble-performance-test

Hey, I even implemented a unit test! ;-)
Alright, I've replaced the "raw" and "escape" filters now only in my own template engine, and that works fine, too.
However, there is one thing I missed in my patch: PrintNode also just uses toString() if auto escaping is turned off -- there is currently no way I know of to replace this using an extension. IOW I cannot completely implement my feature without hacking on the core. How should I proceed here?

I don't think it's gonna be easy to replace PrintNode.
But do you really need to turn off auto espaping ? In this PR, you just override EscapingFilter and RawFilter

Can this get closed?


Image of text - headers are not headings

•	Image of text used for the / image

Won't fix. I might be able to make this into styled text, but frankly, I don't think it's enough of an issue to be worth the effort.


Johtaylo/choice lang defaults

sync with c# PR

Pull Request Test Coverage Report for Build 537

4 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 73.655%

Totals

Change from base Build 528:
0.06%

Covered Lines:
1827

Relevant Lines:
2366

💛  - Coveralls


Strawberry Shake generates with warning CS8602: Dereference of a possibly null reference.

Strawberry Shake generates with warning CS8602: Dereference of a possibly null reference.
Strawberry Shake 11.1.0-rc.2
ref: Slack thread
Summary
Strawberry Shake generates code with warnings like:
...\MyClient.StrawberryShake.cs(422,64): warning CS8602: Dereference of a possibly null reference. [C:\tmp\_210325_b0-HCSS\My.GraphQL.Test.csproj]
    1 Warning(s)
    0 Error(s)

Steps to reproduce
Please find attached the sample project.
Change to its directory and run
dotnet build

Actual result
The build produces the mentioned warning CS8602.
Expected result
The build succeeds without warnings.
Notes
Generated code snippet with a warning (see added comments)
private global::System.Collections.Generic.IReadOnlyList<global::My.Client.IWorkspaces_Workspaces> MapNonNullableIWorkspaces_WorkspacesNonNullableArray(
    global::System.Collections.Generic.IReadOnlyList<global::StrawberryShake.EntityId>? list, // <--- `list` may be null
    global::StrawberryShake.IEntityStoreSnapshot snapshot)
{
    var workspaces = new global::System.Collections.Generic.List<global::My.Client.IWorkspaces_Workspaces>();

    foreach (global::StrawberryShake.EntityId child in list) // <--- `list` causes: warning CS8602: Dereference of a possibly null reference.
    {
        workspaces.Add(MapNonNullableIWorkspaces_Workspaces(
            child,
            snapshot));
    }

    return workspaces;
}

Secondary issue
In the Visual Studio output window double click on this warning does not navigate to the source as expected.
Is it something wrong with warning source information formatting?

_210325_b0-HCSS.zip

And another similar but different warning (not included into the zip, found in another project).
Should I submit a separate issue or this description is enough?

warning CS8604: Possible null reference argument for parameter 'snapshot'

    [global::System.CodeDom.Compiler.GeneratedCode("StrawberryShake", "<IP_ADDRESS>")]
    public partial class ProjectById_ProjectById_ProjectFromProjectEntityMapper
        : global::StrawberryShake.IEntityMapper<global::Nexar.Client.State.ProjectEntity, ProjectById_ProjectById_Project>
    {
        public ProjectById_ProjectById_Project Map(
            global::Nexar.Client.State.ProjectEntity entity,
            global::StrawberryShake.IEntityStoreSnapshot? snapshot = null)  // <--- `snapshot` may be null
        {
            return new ProjectById_ProjectById_Project(
                entity.Name,
                entity.ProjectId,
                entity.Description,
                MapIProjectById_ProjectById_Design(
                    entity.Design,
                    snapshot));  // <--- warning CS8604: Possible null reference argument for parameter 'snapshot'
        }

Thanks for reporting!


Fix bug: plugin stops working after sublime restart

In ST3 after sublime start first plugins are loaded, then global user settings are loaded causing override of settings. This results in single line comments not working after sublime start without plugin reloading. Now settings are loaded every time when are needed.

I'm confused.
The User Settings are supposed to override the Default Settings. I can't find any bugs or issues with how it currently works.
I'm testing the following:

You install the plugin
Using the menu, you go to Preferences -> Package Settings -> Fold Comments -> Fold CommentSettings User
Override the defaults configurations

Am I misunderstanding something?

Sorry.
To reproduce bug try:

Open Sublime Text
Install the package
Now the plugin should work (ctrl+shift+c folds single line comments) try code:// foofoofoo
// barbarbar

void Foo(int bar) {
	/*
	foobar
	barfoo
	foobar
	 */
}

int hhh; // hohoho
char buff[1 << 16]; // my awesome buffer

Close Sublime Text and open again
Folding single line comments doesn't work properly (look at last two lines).

My hypothesis is that something strange happened with settings variable. In other packages settings aren't loaded to global variable. Making settings variable local solved the problem.

Alright, was able to reproduce. Since the settings are cached after the first call of ´´load_settings´´ I guess there's no harm done in using it on each toggle. Fixed in latest version. Thanks!


Fix the scope for "provided" dependencies

Fixes an issue where Lombok is transitively imported as a compile-time dependency into projects that use Logbook. For all other dependencies that have scope "provided" in the dependenyManagement section (gag, jsr305, Lombok), mentions this scope explicitly in the dependencies section.
Description
In the Logbook parent project, Lombok is mentioned as a dependency with default scope (i.e., compile time).
The dependenyManagement section uses the scope "provided", which seems to be working with Maven projects. However, Gradle projects do not honor this when there's an overriding dependenyManagement section in the child project that lacks the scope "provided".
Better safe than sorry: Setting the scope to provided in the dependencies section of the parent should fix the issue.
How to check:

Check out this branch and run mvn install -DskipTests -Ddependency-check.skip=true -Djacoco.skip=true.

Follow the steps in issue #1705 to create a Gradle project, with the following two modifications:

Use version 3.8.0-SNAPSHOT for Logbook (i.e., org.zalando:logbook-spring-boot-starter:3.8.0-SNAPSHOT)
Add mavenLocal() to the list of repositories (in addition to mavenCentral())

Running ./gradlew -q dependencyInsight --dependency lombok should not show anything:

Motivation and Context
Addresses https://github.com/zalando/logbook/issues/1705
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

👍

@kasmarian
Thanks for approving.
Is the underlying issue severe enough to warrant a new release?

I can do a patch release, wdyt?


275 matrix file iterator should include properties by reference

The MatrixFileIterator for void-valued nonzero types copied-by-value the matrix properties. It should instead hold a reference to those properties. This manifested as a performance bug in develop after MR #264 that caused our internal CI to take more than 2 hours on a cursory performance test suite, instead of roughly 40 minutes.
MR #264 itself contained no issues-- all it did was include a programming pattern that kept re-creating an end-iterator, which, in turn, kept creating deep copies of the maps in the matrix file property class. Those maps furthermore are only populated when in indirect parsing mode.
This MR fixes the bug and includes code style fixes to the matrix parser files.

Code review OK. Checked that it fixes issue #275 . GitHub CI OK. Smoke tests without LPF OK. Waiting smoke tests with LPF and waiting internal CI before merge.

Smoke tests with LPF OK, waiting internal CI

Internal CI OK, will merge


[10.x] Add assertUrlPathIs to TestResponse

Adds assertUrlPathIs() to allow for something like:
// Route
Route::get('milwad', function () {
    return view('welcome');
})->name('milwad.index');

// Test
$response = $this->get(route('milwad.index'));
$response->assertUrlPathIs('milwad');

If accepted, I will add related tests!

This is just testing the path right and not the full URL? a more fitting name maybe could be assertUrlPathIs
And is this really testing anything about the response? you pull in the request(), I don't think this has anything to do with testing the response, is this not just asserting that route('milwad.index') returns the expected path?

@johanrosenson
Fix

Maybe unify the API with Laravel Dusk: https://laravel.com/docs/10.x/dusk#assert-path-is
Also, we can introduce assertPathIsNot()

@crynobone
Yes, if merged this PR, we can add assertPathIsNot.

@milwad-dev can you change the method to assertPathIs() to follow Dusk API?

@johanrosenson Fix

is it really fixed thought? you are still just pulling in the request from the app, not the request associated with the response.
To give you an example, would the following code work?
$response1 = $this->get(route('milwad.index'));
$response2 = $this->get(route('another-route'));

$response1->assertUrlPathIs('milwad');

@crynobone Sure

@johanrosenson
We have a problem, that is to how to access to url !?

@johanrosenson We have a problem, that is to how to access to url !?

If you can't access the URL where we need it, maybe this test doesn't belong on the TestResponse.

@johanrosenson
It needs to be in TestResponse.
Also if write like this, there is not problem !
// Route
Route::get('milwad', function () {
    return 'milwad-dev';
})->name('milwad.index');

Route::get('laravel/framework', function () {
    return 'laravel';
})->name('laravel.index');

// Test
$response1 = $this->get(route('milwad.index'));
$response1->assertPathIs('milwad');

$response2 = $this->get(route('laravel.index'));
$response2->assertPathIs('laravel/framework');

✅ Pass

$response1 = $this->get(route('milwad.index'));
$response1->assertPathIs('milwad');

$response2 = $this->get(route('laravel.index'));
$response2->assertPathIs('laravel/framework');

// ✅ Pass

// call $response1->assertPathIs() again but with the path of $response2
$response1->assertPathIs('laravel/framework');

// ✅ Also pass

The test method is sadly flawed since we can't get the request from the response, so assertPathIs as written right now will have a high risk of giving false positives if used in the wrong order. IMHO methods like this should not be dependant on call order or global state.
$this->assertSame('milwad', parse_url(route('laravel.index'), \PHP_URL_PATH));

// this test would give you same information about the route and the generated path.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Add new detailed documentation targeting physicist how to write easily analysis in coffea and execute it on coffea-casa AF

@mat-adamec we were talking with @lgray and this task could be re-prioritized since we could use this tutorial on AGC Tools Workshop https://indico.cern.ch/event/1126109/ (cc @kenbloom )
I think I could imagine it could consist of two parts:

[ ] 1-hour tutorial targeting physicist how to write easily analysis in coffea
[ ] Additional tutorial targeting physicist how to execute analysis in coffea-casa (e.g. adding Servicex)

I will hope  that also @nsmith- could help us with ideas what should be included in this tutorial to make it re-usable in other cases (e.g. as a part of training for example)

I suppose it needs to be experiment-agnostic?
One idea that I've been meaning to put together for a while is a tag-and-probe example using the CMS open data.

@mat could you please add your coffea tutorial in  coffea-casa readthedoc?

Good idea! I've added it to my to-do list.
I think you accidentally pinged the wrong Mat. Sorry to whoever that other person is. :)