Clean up unused methods to run and deploy the site

Removes some none-working and seemingly no longer used methods to run the site in development as well as to build and deploy it.
Also adds some instructions to the README on how to get started outside of VS Code.
Closes #480

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM, thanks @02JanDal .


Fix to https://github.com/mozafari/verdictdb/issues/217

Codecov Report

Merging #218 into master will decrease coverage by 0.24%.
The diff coverage is 47.62%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   73.77%   73.54%   -0.23%
==========================================
  Files         149      150       +1
  Lines        8869     8871       +2
  Branches     1387     1385       -2
==========================================
- Hits         6542     6523      -19
- Misses       1972     1994      +22
+ Partials      355      354       -1

Impacted Files
Coverage Δ

...inator/VerdictSingleResultFromDbmsQueryResult.java
48.89% <ø> (ø)
:arrow_up:

...va/org/verdictdb/coordinator/ExecutionContext.java
89.89% <ø> (ø)
:arrow_up:

src/main/java/org/verdictdb/VerdictContext.java
78% <ø> (ø)
:arrow_up:

...va/org/verdictdb/commons/VerdictResultPrinter.java
0% <0%> (ø)

...g/verdictdb/coordinator/ScramblingCoordinator.java
75.91% <100%> (+1.57%)
:arrow_up:

.../java/org/verdictdb/connection/JdbcConnection.java
82.89% <100%> (+0.19%)
:arrow_up:

.../core/scrambling/FastConvergeScramblingMethod.java
89.38% <76.2%> (-3.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a9ba0d...2882e67. Read the comment docs.


HBASE-22903 : Table to RegionStatesCount metrics - Use for broken alter_status command

Jira: https://issues.apache.org/jira/browse/HBASE-22903

Please review @saintstack

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
2m 13s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:yellow_heart:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

:blue_heart:
mvndep
0m 41s
Maven dependency ordering for branch

:green_heart:
mvninstall
7m  7s
master passed

:green_heart:
compile
3m 12s
master passed

:green_heart:
checkstyle
2m 56s
master passed

:green_heart:
shadedjars
5m 57s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
1m 50s
master passed

:blue_heart:
spotbugs
5m 33s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
10m  4s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
6m 28s
the patch passed

:green_heart:
compile
3m 14s
the patch passed

:green_heart:
cc
3m 14s
the patch passed

:green_heart:
javac
3m 15s
the patch passed

:broken_heart:
checkstyle
0m 41s
hbase-client: The patch generated 9 new + 180 unchanged - 0 fixed = 189 total (was 180)

:broken_heart:
rubocop
0m 11s
The patch generated 3 new + 270 unchanged - 1 fixed = 273 total (was 271)

:green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

:green_heart:
shadedjars
6m  5s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
22m 10s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
2m 59s
the patch passed

:green_heart:
javadoc
1m 49s
the patch passed

:green_heart:
findbugs
10m 31s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 53s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
2m 11s
hbase-client in the patch passed.

:broken_heart:
unit
290m 46s
hbase-server in the patch failed.

:green_heart:
unit
11m 25s
hbase-shell in the patch passed.

:green_heart:
asflicense
1m 58s
The patch does not generate ASF License warnings.

406m 47s

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated

hadoop.hbase.client.TestAsyncRegionAdminApi2

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/611

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux d62b8f9b8295 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-611/out/precommit/personality/provided.sh

git revision
master / a58149827b

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/diff-checkstyle-hbase-client.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/diff-patch-rubocop.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/testReport/

Max. process+thread count
4712 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.74.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Please review @Reidddddd @Apache9

Please review @anoopsjohn @Reidddddd

Yes, Jira Id is correct, however, the solution is generic i.e. use new metrics.
Will update the PR title

Good to know, i'm reviewing another big PR.
Will be back.

@Reidddddd Please review if you are available
Thanks

Requesting your review @saintstack

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:yellow_heart:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

:blue_heart:
mvndep
0m 34s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 28s
master passed

:green_heart:
compile
2m 28s
master passed

:green_heart:
checkstyle
2m 25s
master passed

:green_heart:
shadedjars
4m 47s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
1m 29s
master passed

:blue_heart:
spotbugs
4m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
8m 11s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m  7s
the patch passed

:green_heart:
compile
2m 30s
the patch passed

:green_heart:
cc
2m 30s
the patch passed

:green_heart:
javac
2m 30s
the patch passed

:broken_heart:
checkstyle
0m 41s
hbase-client: The patch generated 1 new + 180 unchanged - 0 fixed = 181 total (was 180)

:broken_heart:
rubocop
0m 10s
The patch generated 3 new + 256 unchanged - 1 fixed = 259 total (was 257)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
6m  1s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
20m 17s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
2m 53s
the patch passed

:green_heart:
javadoc
1m 40s
the patch passed

:green_heart:
findbugs
10m  7s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 51s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
2m 10s
hbase-client in the patch passed.

:green_heart:
unit
162m 28s
hbase-server in the patch passed.

:green_heart:
unit
7m 14s
hbase-shell in the patch passed.

:green_heart:
asflicense
2m  8s
The patch does not generate ASF License warnings.

260m 54s

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/611

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 78f96f1a122f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-611/out/precommit/personality/provided.sh

git revision
master / 3250a8021a

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/2/artifact/out/diff-checkstyle-hbase-client.txt

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/2/artifact/out/diff-patch-rubocop.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/2/testReport/

Max. process+thread count
4806 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.74.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 could you please review this PR?

BTW, please also take a look the HBaseQA, seems checkstyles & ruby has some problem now, please update your PR if it's related. @virajjasani

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 33s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 45s
master passed

:green_heart:
compile
2m 43s
master passed

:green_heart:
checkstyle
2m 37s
master passed

:green_heart:
shadedjars
5m  2s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
1m 26s
master passed

:blue_heart:
spotbugs
4m 53s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
8m 45s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
6m 19s
the patch passed

:green_heart:
compile
2m 57s
the patch passed

:green_heart:
cc
2m 57s
the patch passed

:green_heart:
javac
2m 57s
the patch passed

:green_heart:
checkstyle
2m 45s
the patch passed

:broken_heart:
rubocop
0m 16s
The patch generated 4 new + 418 unchanged - 1 fixed = 422 total (was 419)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
5m 38s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
19m 25s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
2m 46s
the patch passed

:green_heart:
javadoc
1m 33s
the patch passed

:green_heart:
findbugs
9m 51s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 47s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
2m  5s
hbase-client in the patch passed.

:green_heart:
unit
174m  8s
hbase-server in the patch passed.

:green_heart:
unit
7m 24s
hbase-shell in the patch passed.

:green_heart:
asflicense
1m 35s
The patch does not generate ASF License warnings.

273m 21s

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/611

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 7dbacadc9a87 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-611/out/precommit/personality/provided.sh

git revision
master / 1170f28122

Default Java
1.8.0_181

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/3/artifact/out/diff-patch-rubocop.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/3/testReport/

Max. process+thread count
4289 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.74.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the review, updated the PR based on comments, please take a look @openinx
Some rubocop warning would be difficult to resolve for any changes in ruby file like Metrics/AbcSize etc, which is usually ignored IMHO.
Thanks

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m 31s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 35s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 44s
master passed

:green_heart:
compile
2m 27s
master passed

:green_heart:
checkstyle
2m 29s
master passed

:green_heart:
shadedjars
4m 54s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
1m 21s
master passed

:blue_heart:
spotbugs
4m 24s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
8m 11s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 14s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 28s
the patch passed

:green_heart:
compile
2m 23s
the patch passed

:green_heart:
cc
2m 23s
the patch passed

:green_heart:
javac
2m 23s
the patch passed

:green_heart:
checkstyle
2m 25s
the patch passed

:broken_heart:
rubocop
0m 12s
The patch generated 1 new + 418 unchanged - 1 fixed = 419 total (was 419)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
5m  1s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m  2s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
2m 19s
the patch passed

:green_heart:
javadoc
1m 20s
the patch passed

:green_heart:
findbugs
8m 41s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 41s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
1m 48s
hbase-client in the patch passed.

:green_heart:
unit
156m 33s
hbase-server in the patch passed.

:green_heart:
unit
7m  8s
hbase-shell in the patch passed.

:green_heart:
asflicense
1m 36s
The patch does not generate ASF License warnings.

247m 29s

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/611

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux dc7f31295b35 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-611/out/precommit/personality/provided.sh

git revision
master / ce0fbc2af9

Default Java
1.8.0_181

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/4/artifact/out/diff-patch-rubocop.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/4/testReport/

Max. process+thread count
4294 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.74.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 35s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 54s
master passed

:green_heart:
compile
2m 36s
master passed

:green_heart:
checkstyle
2m 32s
master passed

:green_heart:
shadedjars
5m  6s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
1m 26s
master passed

:blue_heart:
spotbugs
4m 44s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
8m 43s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 54s
the patch passed

:green_heart:
compile
3m  6s
the patch passed

:green_heart:
cc
3m  5s
the patch passed

:green_heart:
javac
3m  5s
the patch passed

:green_heart:
checkstyle
2m 54s
the patch passed

:broken_heart:
rubocop
0m 15s
The patch generated 1 new + 418 unchanged - 1 fixed = 419 total (was 419)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
6m 25s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
20m 33s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
2m 53s
the patch passed

:green_heart:
javadoc
1m 42s
the patch passed

:green_heart:
findbugs
10m 27s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 48s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
2m  7s
hbase-client in the patch passed.

:broken_heart:
unit
173m 31s
hbase-server in the patch failed.

:green_heart:
unit
7m 16s
hbase-shell in the patch passed.

:green_heart:
asflicense
1m 35s
The patch does not generate ASF License warnings.

275m 33s

Reason
Tests

Failed junit tests
hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/611

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop

uname
Linux 958f7e29d7fd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-611/out/precommit/personality/provided.sh

git revision
master / ca0d9f3cd2

Default Java
1.8.0_181

rubocop
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/5/artifact/out/diff-patch-rubocop.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/5/testReport/

Max. process+thread count
4225 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-client hbase-server hbase-shell U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-611/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 rubocop=0.74.0

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.


Thread does not appear immediately on receiver side  in workspace chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

go to Settings > Workspaces
create a workspace if not created
go to members
add userB
go to workspace and userB chat
send any message
hover on message and click on reply thread option
send any message in thread
check the message on userB side

Expected Result:
thread should be appear immediately
Actual Result:
thread does not appear immediately
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.63-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/38435837/5133f9a3-1c6e-4cde-b087-d1834f538dad
https://github.com/Expensify/App/assets/38435837/800984a7-8158-40ce-abe9-c025ddbde39b
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693291656010449
View all open jobs on GitHub

Hm, yeah I would say that this is more of a performance issue that we will optimize for

Getting to this tomorrw. Maybe we can bundle it into performance improvements

I think that this will be handled by #reliable-updates, let's close it and reopen if it still occurs when that project is closed out


Hide error traceback

TGPy messages with errors look quite like random spam, and full error tracebacks are rarely useful.
I am proposing to show only the last line of the error and save the full error to a variable and/or logs.
Example
Current behavior:
msg.something

TGPy> Error occurred

Traceback (most recent call last):
  File "/home/tmat/.local/pipx/venvs/tgpy/lib/python3.11/site-packages/tgpy/_core/meval.py", line 175, in _meval
    new_locs, ret = await getattr(py_module, 'tmp')(**kwargs)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "tgpy://message/-1001611149679/38326", line 1, in tmp
    msg.something
AttributeError: 'Message' object has no attribute 'something'

Suggested behavior:
msg.something

TGPy> AttributeError: 'Message' object has no attribute 'something'

Implemented in https://github.com/tm-a-t/TGPy/commit/739fbbcdc2f96ed54a10620f87049b0107c14cc6


Expose deployment strategy

The data on the PVC is not ought to be shared between multiple spawned pods; this may lead to race conditions, and is even impossible when the data is on a ReadWriteOnce specced volume.
This patch allows to specify the Deployment's strategy, as to tell Kubernetes not to have a rolling update when these kind of volumes are used.
I have not changed the default value, although it would be advisable to put the strategy on Recreate for the default settings, since the default settings introduce race conditions.
deployment:
  strategy:
    type: Recreate # Default would be RollingUpdate

LGTM. Thanks for your contribution!

I'm going to assume it works (I've tested it myself but wanted to be sure), so I'm going to merge it.


[Feature Request] Support for base64 font src

polished version: "^2.0.3",
styled-components version: "^4.0.2",

Mixin/Helper/Shorthand you were using and how you were using it:
fontFace({
    fileFormats: ['woff'],
    fontFamily: 'My Custom Font',
    fontFilePath: `data:application/font-woff;charset=utf-8;base64,<BASE64_STRING>',
    fontStyle: 'italic',
    fontWeight: 500,
  });

What you are seeing:
.woff applied to end of url() making it invalid.
and no format hint format("woff")
url("<supplied data uri>").woff

What you expected to see:
@font-face {
  font-family: 'My Custom Font';
    url(data:font/truetype;charset=utf-8;base64,BASE64_ENCODED_DATA_HERE)  format("woff")`;

expect to see the base64 of the file inlined in url as base64.
OR
If the consumer supply the data uri ? include it in fontface css
Also need to take into account of encoding and absolute file path if we polish does the base64 of the supplied file.
Reproduction:

@ischyron This as been added to fontFace in 3.1.0.


Replace travis ci?

Hi, Just noticed this<EMAIL_ADDRESS>Maybe old news but maybe some other CI engines should be considered?
regards
/Pelle

I don't think we should overreact, let's wait and see and what happens with Travis. We've looked at numerous alternatives over the years and they all have their pros and (more often than not) cons. For now I'm not convinced there is anything as feature-rich as Travis so I'd suggest we stick with it for now. If for some reason open source Travis is closed down I'm sure there will be a huge number of people in the same boat as us and there will be plenty of migrations going on. From past experience (e.g. Google Code closing down), if you wait a bit the migration becomes even easier as the destination tools start building migration tools you can leverage (with Google Code it ended up so you basically just clicked a button on the project was migrated over to GitHub).
Unless someone really objects or wants to spend time investigating an alternative I'd suggest closing this for now.

Fair points, just wanted to make people aware. You can close it. I guess
there can still be a discussion in the closed issue?
regards
/Pelle
On Tue, Mar 5, 2019 at 10:16 AM Adrian Woodhead<EMAIL_ADDRESS>wrote:

I don't think we should overreact, let's wait and see and what happens
with Travis. We've looked at numerous alternatives over the years and they
all have their pros and (more often than not) cons. For now I'm not
convinced there is anything as feature-rich as Travis so I'd suggest we
stick with it for now. If for some reason open source Travis is closed down
I'm sure there will be a huge number of people in the same boat as us and
there will be plenty of migrations going on. From past experience (e.g.
Google Code closing down), if you wait a bit the migration becomes even
easier as the destination tools start building migration tools you can
leverage (with Google Code it ended up so you basically just clicked a
button on the project was migrated over to GitHub).
Unless someone really objects or wants to spend time investigating an
alternative I'd suggest closing this for now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/klarna/HiveRunner/issues/100#issuecomment-469602205,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtvJ93eiNKUwWTbAAqUo38P6-K0Z67sks5vTjXdgaJpZM4bd3sT
.

For sure, we can also re-open if things really go badly at Travis and we do need to do this.


Allow to output readable format (no AST)

Hi,
I'd like to know if it is possible to extract the queries in a human readable form, instead of minified AST that is supposed to be shared between client and server.
My usecase is that I have graphql fragments everywhere and I use fragments composition, so it would be useful to be able to output the composed version of my queries so that I can play with the queries in a sandbox like Graphiql. Otherwise I have to do this composition manually and maintain it over time.
Here's the kind of output I'd like to have
query ReportEditionSynthesisShowQuery($reportEditionId: ID!) {
    reportEdition: ReportEdition(id: $reportEditionId) {
        id
        startDate
        endDate
        report {
            id
            name
        }
        contributions: answers {
            id
            ...SynthesisItemContribution
        }
        importantTopicContributions: topicAnswers(filter: {important: true}) {
            ...ImportantItemsTopicContribution
        }
        recipients {
            email
        }
    }
}

fragment ImportantItemsTopicContribution on TopicAnswer {
    id
    content
    contribution: answer {
        id
        user {
            id
            firstName
            lastName
            avatar
        }
    }
}

fragment SynthesisItemContribution on Answer {
    answerType
    user {
        ...SynthesisItemHeaderByUser
    }
    topicContributions: topicAnswers {
        ...SynthesisSectionsTopicContribution
    }
}

fragment SynthesisItemHeaderByUser on User {
    ...UserAlt
}

fragment UserAlt on User {
    id
    firstName
    lastName
    pictureUrl: avatar
    job
    color
    email
}

fragment SynthesisSectionsTopicContribution on TopicAnswer {
    topic {
        id,
        name
    }
    content
}

Here is my query defined in HOC (I did not include subcomponents but I can if needed)

const injectSynthesisData = Comp => {
  return graphql(gql`

      query ReportEditionSynthesisShowQuery($reportEditionId: ID!) {
          reportEdition: ReportEdition(id: $reportEditionId) {
              id
              startDate
              endDate
              report {
                  id
                  name
              }
              contributions: answers {
                  id
                  ...SynthesisItemContribution
              }
              importantTopicContributions: topicAnswers(filter: {important: true}) {
                  ...ImportantItemsTopicContribution
              }
              recipients {
                  email
              }
          }
      }

      ${ImportantItems.fragments.topicContribution}
      ${SynthesisItem.fragments.contribution}

  `,{
    options: (props) => ({
      variables: {
        reportEditionId: props.match.params.reportEditionId
      }
    }),
  })(Comp)
};

@slorber Yeah, this should be possible pretty easily. It might be possible to use prettier's support for GraphQL queries in order to pretty print the existing query keys in the JSON map persistgraphql outputs. Could you give this a try and see if it matches your usecase?

Hi,
I'm not sure what you are proposing me to do @Poincare
Anyway I've found a workaroud: the Apollo Chrome extension does allow me to see the "live queries" of a page so I can get my output from there. It may not be "automated" but is good enough for me


[FLINK-3700] [core] Remove Guava as a dependency from "flink-core"

Note: This builds on top of pull request  #1853
Almost all Guava functionality used within flink-core has corresponding utils in Flink's codebase, or the JDK library.
This replaces the Guava code as follows

Preconditions calls by Flink's Preconditions class
Collection utils by simple Java Collection calls
Iterator's by Flink's Union Iterator
Murmur Hasher calls by Flink's MathUtil.murmurHash()
Files by simple util methods around java.nio.Files
InetAddresses IPv6 encoding code has been adapted into Flink's NetUtils (with attribution comments)
Joiner by org.apache.commons.lang3.StringUtils, which we reference anyways, and which is a well-behaved dependency (might even get rid of this in the future).

Some util classes where moved from flink-runtime to flink-core.

+1 to merge

Thanks for the refactoring @StephanEwen!
Will merge this.


Cannot set tatic final java.io.InputStream field java.lang.System

Description
If we mock java.util.Scanner class, we get exceptions in the concrete executor -- cannot set field (see screenshot below)
To Reproduce
Steps to reproduce the behaviour:

Run any project in IntelliJ Idea
Create a method with scanner usage
Use the plugin to generate tests
Open the generated tests

Expected behaviour
Correctly generated tests for the method
Actual behaviour
Tests containing only exceptions
Visual proofs

Environment
You need to add java.util.Scanner into the set of classes to mock always (in the settings of UTBot).
Additional context
There is no additional context.

Reproduced


Implementation of bubble-sort

Implemented bubble-sort algo | first-contribution-in-OS

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


tensorflow-2.12.0 not support GPU

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
binary
Tensorflow Version
v2.12.0-rc1-12-g0db597d0d75 2.12.0
Custom Code
No
OS Platform and Distribution
Windows 10
Mobile device

Python version
3.10.10
Bazel version

GCC/Compiler version

CUDA/cuDNN version
cuda_11.8.0_522.06_windows / cudnn-windows-x86_64-<IP_ADDRESS>_cuda11
GPU model and memory
1050ti 4 GB
Current Behaviour?
Supporting GPU calcs. Ive tried version tf 2.10, all works, but 2.10 have some issues, that 2.12 dont have

Standalone code to reproduce the issue
import tensorflow as tf
from tensorflow.python.client import device_lib
import numpy as np
print(tf.__version__)

print(f"Tensor Flow Version: {tf.__version__}")
print(f"Keras Version: {tf.keras.__version__}")
print()
gpu = len(tf.config.list_physical_devices('GPU'))>0
print("GPU is", "available" if gpu else "NOT AVAILABLE")

Relevant log output
2.12.0
Tensor Flow Version: 2.12.0
Keras Version: 2.12.0

GPU is NOT AVAILABLE

Hi @yatebyaeby, As per the official documentation, TensorFlow 2.10 was the last TensorFlow release that supported GPU on native-Windows. Starting with TensorFlow 2.11, you will need to install TensorFlow in WSL2. Hence, please try installing Tensorflow in WSL2.
Also note that, TensorFlow with GPU access is supported for WSL2 on Windows 10 19044 or higher. This corresponds to Windows 10 version 21H2, the November 2021 update. You can get the latest update from here: Download Windows 10. For instructions, see Install WSL2 and NVIDIA’s setup docs for CUDA in WSL.  Thank you!

Hi @yatebyaeby, As per the official documentation, TensorFlow 2.10 was the last TensorFlow release that supported GPU on native-Windows. Starting with TensorFlow 2.11, you will need to install TensorFlow in WSL2. Hence, please try installing Tensorflow in WSL2.
Also note that, TensorFlow with GPU access is supported for WSL2 on Windows 10 19044 or higher. This corresponds to Windows 10 version 21H2, the November 2021 update. You can get the latest update from here: Download Windows 10. For instructions, see Install WSL2 and NVIDIA’s setup docs for CUDA in WSL. Thank you!

oh, thanks for reply


Update to Angular.JS 1.3.15

thanks for the pull request! for the next time, could you also bump the version in component.json ? i went ahead and fixed this for now

yeah, sure. i guess i missed it. :/

no problems at all. very many thanks for your contribution!


Css function Composer type extends String type require length property is not needed

This problem is almost same as https://github.com/Temzasse/stitches-native/pull/26.
The css function needs same patch.

Merge with https://github.com/Temzasse/stitches-native/pull/33#issuecomment-1296695585.


opsgenie: add missing statds/dogstastd metrics

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
opsgenie: add missing statds/dogstastd metrics
Which issue(s) this PR fixes:

Fixes partially https://github.com/falcosecurity/falcosidekick/issues/144
Special notes for your reviewer:
/assign @Issif

@cpanato: The label(s) area/outputs cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
opsgenie: add missing statds/dogstastd metrics
Which issue(s) this PR fixes:
Fixes partially https://github.com/falcosecurity/falcosidekick/issues/144
Special notes for your reviewer:
/assign @Issif

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign nibalizer after the PR has been reviewed.
You can assign the PR to them by writing /assign @nibalizer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 012661f0b38eaf58f38edc7e9854ea43a7e28325

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Window.size_changed and NOTIFICATION_WM_SIZE_CHANGED are not triggered when "window.content_scale_mode == Window.ContentScaleMode.CONTENT_SCALE_MODE_VIEWPORT"

Godot version
v4.1.stable.official [970459615]
System information
Godot v4.1.stable - Windows 10.0.19044 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1050 Ti (NVIDIA; <IP_ADDRESS>47) - Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 Threads)
Issue description
When using a ContentScaleMode equal to CONTENT_SCALE_MODE_VIEWPORT, the size_changed signal of the root window is not emited regardless of changing the size via code or resizing the window manually. not only the signal is not emited, but the notification is also not triggered. Look at output log:

Steps to reproduce
On a new project, on a new scene, create a script in the scene root, paste this script and run it
extends Node2D
var mold_size:Vector2i
func _ready()->void:
	print('==================== BEGIN')
	var vwindow:Window = get_window()
	print('_ready(): connecting size_changed to on_size_changed')
	vwindow.size_changed.connect(on_size_changed)
	print('\n_ready(): changing scale to CONTENT_SCALE_MODE_DISABLED')
	vwindow.content_scale_mode = Window.ContentScaleMode.CONTENT_SCALE_MODE_DISABLED
	print('_ready(): changing to 1')
	vwindow.size = Vector2i.ONE
	print('_ready(): changing to 128')
	vwindow.size = Vector2i.ONE * 128
	print('\n_ready(): changing scale to CONTENT_SCALE_MODE_CANVAS_ITEMS')
	vwindow.content_scale_mode = Window.ContentScaleMode.CONTENT_SCALE_MODE_CANVAS_ITEMS
	print('_ready(): changing to 1')
	vwindow.size = Vector2i.ONE
	print('_ready(): changing to 128')
	vwindow.size = Vector2i.ONE * 128
	print('\n_ready(): changing scale to CONTENT_SCALE_MODE_VIEWPORT')
	vwindow.content_scale_mode = Window.ContentScaleMode.CONTENT_SCALE_MODE_VIEWPORT
	print('_ready(): changing to 1')
	vwindow.size = Vector2i.ONE
	print('_ready(): changing to 128')
	vwindow.size = Vector2i.ONE * 128
	print('==================== END')
func _notification(pwhat:int)->void:
	if pwhat == Node.NOTIFICATION_WM_SIZE_CHANGED: print('_notification(NOTIFICATION_WM_SIZE_CHANGED)')
func on_size_changed()->void:
	var vnewsize:Vector2i = get_window().size
	print('    on_size_changed(): changed from %s to %s'%[mold_size, vnewsize])
	mold_size = vnewsize
func _physics_process(delta:float)->void:
	if Engine.get_physics_frames() % 60 != 0: return
	print('_physics_process(): window size: %s'%get_window().size)

Minimal reproduction project
N/A

Technically this works as expected, because the signal is only sent, when the size of the viewport changes
https://github.com/godotengine/godot/blob/23318e877890029f35856036b9c4e0bfa09cacc6/scene/main/viewport.cpp#L968
CONTENT_SCALE_MODE_VIEWPORT has in this case the effect, that the size of the viewport stays the same, so the signal is not emitted, even though the size of the Window has changed.
Please try instead to watch for the notification NOTIFICATION_WM_SIZE_CHANGED, if you want to get notified, when the size of the window changes.

The notification is also not triggered, but the window size property does change.

After digging into this deeper, `NOTIFICATION_WM_SIZE_CHANGED´ is only sent to the Window, but not to the nodes inside the window. In your script, you listen for that notification in a node, that is inside the window.
So in order to achieve your goal, you need to listen on the root node for that notification. Here is a demo project, how this can be done: RootSizeChange.zip
Does this solve your problem?

That's clever but what on earth ... is there really no way to simply be told, "Hey, the window was resized"?  That seems like baseline functionality.

Yes there is a way, @Sauermann demoed it for you

Your definition of "simply" differs from mine.  But sure, yeah ...

It's very common in Godot to have to go up/down the node tree for certain things specific to certain node types.

I'm sure you're right, I'll get used to doing things this way.

The current behavior should be documented better.

This is very confusing, please correct me if I didn't get this:
When using Display > Window > Stretch > Mode > viewport, you cannot use signals:

get_window().size_changed
get_viewport().size_changed

The only alternative is to follow the example above which consists of loading another script to the root node by running in some different script the following:
$"/root".set_script(load("res://rw.gd"))
Where rw.gd contains the following:
extends Window

func _notification(what):
	if what == NOTIFICATION_WM_SIZE_CHANGED:
		print("New Root Size detected: ", size)

If I got this right, this should not be considered a documentation issue only. If making the signals respond as most people would expect is for some reason not desired, maybe we should have some other signal to use instead.

why not add a signal to Window (not Viewport) called something like window_resized that it emits when it receives the NOTIFICATION_WM_SIZE_CHANGED notification?
i don't think one can argue that the current solution is elegant or intuitive at all

While this is solved for now by adjusting the documentation, we should continue the discussion about improving the situation in the form of a proposal: https://github.com/godotengine/godot-proposals/issues/8788


<EMAIL_ADDRESS>Fix hash

Closes #98

All changes look good.
Wait for review from human collaborators.
graphviz

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction


Which character is valid in tag values

Do not found any document about the length limitation and which character could be used in the tag value.
And also no doc about limitation of the metric names and tag names.
Found a piece of code for validation https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/render/grammar.py#L89.
What kind of chars validation is applied for metric tag?
Is white space supported in the tag value?
It is good to have a document about it for long term supporting (as a standard), or at least a guideline.
I believe many special characters is well supported, but it is not guaranteed they will be well supported in the future.

After getting feedback from users it seems like we should be a bit more prescriptive as far as what characters are supported.  Things like ' cause problems when trying to query from Grafana, and values that start with ~ are a problem when querying.  The other thing I've been thinking about is support for escaping "special" characters.


Replace linker script ARM sections with something RISC-V specific

The linker script includes sections like:

.ARM.extab
.ARM.exidx

Update them for RISC-V specific sections.

No such sections identified.

Fixed on 2022-07-28.


[L14] Solidity compiler version is not pinned and it is not the same for all contracts

Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues

Fixes https://github.com/celo-org/celo-labs/issues/594

Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.

Note, this appears to break Certora tests. Can they not handle 0.5.13, or is it just that they expected a different version and need to be explicitly told to expect the new one?


header_type attribute of p4_header_stack is a string

After building the HLIR the header_type attribute for p4_header_stack objects is a string. I was expecting it to be a p4_header object.
I had a quick look at the code and it seems like the header_type should be updated when the build() method is called, but I don't see where the build() method is ever called. Should https://github.com/p4lang/p4-hlir/blob/p4v1.1/p4_hlir/hlir/p4.py#L103 include hlir.p4_header_stacks?

Fixed by df1dd0415e238aa3e464ef24e730d49bfb0cbf41


[Bug]: 1.No service dependencies found. 2.Service & Operation：Do not show dependency hierarchy

What happened?
Question one：
Service & Operation：Do not show dependency hierarchy
Question tow：
System Architecture Show:“No service dependencies found.”
Question three：
When an exception occurs in the interface call, it cannot be seen intuitively on the UI interface
Steps to reproduce
1.docker run -d --name jaeger
-e COLLECTOR_ZIPKIN_HOST_PORT=:9411
-e COLLECTOR_OTLP_ENABLED=true
-p 6831:6831/udp
-p 6832:6832/udp
-p 5778:5778
-p 16686:16686
-p 4317:4317
-p 4318:4318
-p 14250:14250
-p 14268:14268
-p 14269:14269
-p 9411:9411
jaegertracing/all-in-one:1.45
2.I want to use it in a c# program, the code is as follows：
private void ConfigJaeger(ServiceConfigurationContext context)
{
context.Services.AddOpenTracing();
context.Services.AddSingleton(serviceProvider =>
{
var serviceName = serviceProvider.GetRequiredService().ApplicationName;
            var loggerFactory = serviceProvider.GetRequiredService<ILoggerFactory>();
            var sampler = new ConstSampler(sample: true);
            var reporter = new RemoteReporter.Builder()
                    .WithLoggerFactory(loggerFactory)
                    .WithSender(new UdpSender("<IP_ADDRESS>", 6831, 0))
                    .Build();

            var tracer = new Tracer.Builder(serviceName)
                .WithLoggerFactory(loggerFactory)
                .WithSampler(sampler)
                .WithReporter(reporter)
                .Build();

            GlobalTracer.Register(tracer);

            return tracer;
        });
    }

Expected behavior
show call dependencies
Relevant log output
No response
Screenshot

Additional context
No response
Jaeger backend version
No response
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response

you only have one service, so there are no dependencies

you only have one service, so there are no dependencies

What should I do if I want to monitor redis requests? At present, there are redis read and write related in the business logic, but it is not reflected in the link tracking

Redis does not generate traces itself, it's only observable from the client side. We have an outstanding issue for that https://github.com/jaegertracing/jaeger/issues/3804


fix: Update citrus-remote to Citrus version 4

This pull request updates citrus-remote to be compatible with Citrus version 4. The update addresses several dependency issues and ensures that our framework leverages the latest features and improvements of Citrus.
Key Changes:

Updated the Citrus dependency to version 4
Modified code and configurations to accommodate breaking changes and new features in Citrus version 4
Ensured all tests pass with the new version

Testing:
The following repositories were used to test these changes:

Citrus: https://github.com/maletic/citrus/tree/fix-test-classes-not-found-in-jar (contains a fix for citrus test class loading)
Citrus-Remote: https://github.com/maletic/citrus-remote/tree/update-citrus-remote-to-newest
Citrus-Playground: https://github.com/maletic/citrus-playground/tree/update-citrus-remote

This PR depends on: https://github.com/citrusframework/citrus/pull/1188

This PR depends on: https://github.com/citrusframework/citrus/pull/1188

has been merged, but requires a "fix" release @christophd

I love how the whole project contains 0 tests 🤣 not the best for a testautomation framework haha
@maletic I've looked it through and cleaned up the code- here's the pr: https://github.com/maletic/citrus-remote/pull/1.
I wonder if we could include https://github.com/maletic/citrus-playground/tree/update-citrus-remote into the pipeline here.
@christophd it would be cool if you could "do that thing with the copyright headers again" (you did it for citrusframework/citrus using intellij idea).

@maletic & @turing85 please see https://github.com/maletic/citrus-remote/pull/2. I've added the sample repository of @maletic to the build - if you're ok with that?
I am no maintainer, so @christophd will have to approve the workflow in this PR afterwards.
with the changes or additions mentioned above: /lgtm

I am against the tests as-is. For one, the quarkus versions are outdated. For another, we could rewrite the tests purely in citrus to not pull-in another framework.
Over all, this is unrelated to the actual change. Just like @christophd 's idea to replace spark/jetty with vert.x, I see this as a separate task that should be handled separately.

Overall, this is unrelated to the actual change.

only partially, I think. I do understand that you want to have the change released, however...

the module is not continuously tested as it is now
I fear that once this PR is merged, nobody is gonna care about tests anymore

(or the move to vert.x for that matter)

note that I've additionally checked and updated all dependencies; there were few breaking changes involved too.
anyway, the changes are there, I've submitted the PR. because of that, I might accept the PR without the sample too. as already said, I've no administrative rights on citrus-remote, so @christophd will have to do the last call on this one.

[x] I've manually tested #6 and confirm that it works

I increased the versions in the poms to the ones in the PR, so it ready for merging 😄

https://github.com/citrusframework/citrus-remote/blob/38d346e40f625d8271099a33ea4af66c8334a263/pom.xml#L19
- <maven.version>3.8.4</maven.version>
+ <maven.version>3.9.8</maven.version>

https://github.com/citrusframework/citrus-remote/blob/38d346e40f625d8271099a33ea4af66c8334a263/pom.xml#L27C12-L27C18
- <maven.antrun.plugin.version>3.0.0</maven.antrun.plugin.version>
+ <maven.antrun.plugin.version>3.1.0</maven.antrun.plugin.version>

https://github.com/citrusframework/citrus-remote/blob/38d346e40f625d8271099a33ea4af66c8334a263/pom.xml#L30
- <maven.clean.plugin.version>3.0.0</maven.clean.plugin.version>
+ <maven.clean.plugin.version>3.3.1</maven.clean.plugin.version>

https://github.com/citrusframework/citrus-remote/blob/38d346e40f625d8271099a33ea4af66c8334a263/pom.xml#L31
- <maven.dependency.plugin.version>3.0.2</maven.dependency.plugin.version>
+ <maven.dependency.plugin.version>3.6.0</maven.dependency.plugin.version>

I think we should sync the plugins versions before merging...

@christophd so... we gonna merge?

thank you so much @maletic and @turing85 for this huge contribution! and all the patience 😉


Updated goimports local-prefixes

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

License
Apache 2.0

What's in this PR?
I "fixed" the local-prefixes setting of the linter goimports.
Why?
Because it's best to also have the project in the path given to the local-prefixes option.
Checklist

[x] Implementation tested
[x] Logging code meets the guideline

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix/gopls 1.1x support

What
Fixes support for Golang versions 1.15 and below.
Note
Gopls only supports the last 2 versions of go and attempts to prevent breaking changes for the last 4 versions

This how now been tested on:
Windows: Golang 1.16
Windows: Golang 1.15
MacOS: Golang 1.16
MacOS: Golang 1.15

Fixes #9

@ofen if you could test before we merge and cut a release that would be awesome. As you are running 1.13 which is the last version gopls will possible support

Traceback (most recent call last):
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/windows.py", line 354, in start_async
    transport = create_transport(transport_config, transport_cwd, session)
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 252, in create_transport
    process = start_subprocess()
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 241, in start_subprocess
    return _start_subprocess(config.command, stdin, stdout, subprocess.PIPE, startupinfo, config.env, cwd)
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 323, in _start_subprocess
    cwd=cwd)
  File "./python3.3/subprocess.py", line 819, in __init__
  File "./python3.3/subprocess.py", line 1110, in _execute_child
FileNotFoundError: [WinError 2] The system can not find the file specified。

SublimeLinter: WARNING: golangcilint output:
level=error msg="Running error: context loading failed: no go files to analyze"

WARNING:SublimeLinter.plugin.golangcilint:golangcilint output:
level=error msg="Running error: context loading failed: no go files to analyze"

subprocess

go version is : go version go1.15 windows/amd64

Traceback (most recent call last):
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/windows.py", line 354, in start_async
    transport = create_transport(transport_config, transport_cwd, session)
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 252, in create_transport
    process = start_subprocess()
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 241, in start_subprocess
    return _start_subprocess(config.command, stdin, stdout, subprocess.PIPE, startupinfo, config.env, cwd)
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 323, in _start_subprocess
    cwd=cwd)
  File "./python3.3/subprocess.py", line 819, in __init__
  File "./python3.3/subprocess.py", line 1110, in _execute_child
FileNotFoundError: [WinError 2] The system can not find the file specified。

SublimeLinter: WARNING: golangcilint output:
level=error msg="Running error: context loading failed: no go files to analyze"

WARNING:SublimeLinter.plugin.golangcilint:golangcilint output:
level=error msg="Running error: context loading failed: no go files to analyze"

go version go1.15 windows/amd64

@TheSecEng Hi! Commit abb9f616f0fab48047d190fda97c1deef46f989a works on Ubuntu 20.04.2 LTS, Sublime Text 4 Build 4113, go1.13.8 (https://github.com/sublimelsp/LSP-gopls/issues/9#issuecomment-955673875). I tested auto-completion, format-on-safe and some minor things like jump-to-definition and LGTM. There is also new exception in console after each plugin reload that could be bug (?).
reloading python 3.3 plugin LSP-gopls.plugin
Traceback (most recent call last):
  File "/home/user/.config/sublime-text-3/Installed Packages/LSP.sublime-package/plugin/core/windows.py", line 540, in _update_panel_main_thread
    panel.run_command("lsp_update_panel", {"characters": characters})
  File "/opt/sublime_text/Lib/python33/sublime.py", line 1312, in run_command
    sublime_api.view_run_command(self.view_id, cmd, args)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 1490, in run_
    self.view.end_edit(edit)
  File "/opt/sublime_text/Lib/python33/sublime.py", line 1273, in end_edit
    sublime_api.view_end_edit(self.view_id, edit.edit_token)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 924, in on_modified
    run_view_callbacks('on_modified', view_id)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 708, in run_view_callbacks
    callback(v, *args)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 152, in profiler
    return event_handler(*args)
  File "/home/user/.config/sublime-text-3/Installed Packages/AutoFileName.sublime-package/autofilename.py", line 162, in on_modified
    sel = view.sel()[0].a
  File "/opt/sublime_text/Lib/python33/sublime.py", line 1020, in __getitem__
    raise IndexError()
IndexError
reloading python 3.3 plugin LSP-gopls.plugin
Traceback (most recent call last):
  File "/home/user/.config/sublime-text-3/Installed Packages/LSP.sublime-package/plugin/core/windows.py", line 540, in _update_panel_main_thread
    panel.run_command("lsp_update_panel", {"characters": characters})
  File "/opt/sublime_text/Lib/python33/sublime.py", line 1312, in run_command
    sublime_api.view_run_command(self.view_id, cmd, args)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 1490, in run_
    self.view.end_edit(edit)
  File "/opt/sublime_text/Lib/python33/sublime.py", line 1273, in end_edit
    sublime_api.view_end_edit(self.view_id, edit.edit_token)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 924, in on_modified
    run_view_callbacks('on_modified', view_id)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 708, in run_view_callbacks
    callback(v, *args)
  File "/opt/sublime_text/Lib/python33/sublime_plugin.py", line 152, in profiler
    return event_handler(*args)
  File "/home/user/.config/sublime-text-3/Installed Packages/AutoFileName.sublime-package/autofilename.py", line 162, in on_modified
    sel = view.sel()[0].a
  File "/opt/sublime_text/Lib/python33/sublime.py", line 1020, in __getitem__
    raise IndexError()
IndexError

@ofen that's a bug in AutoFileName. It should not assume that there is always a selection in the view.

Traceback (most recent call last):
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/windows.py", line 354, in start_async
    transport = create_transport(transport_config, transport_cwd, session)
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 252, in create_transport
    process = start_subprocess()
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 241, in start_subprocess
    return _start_subprocess(config.command, stdin, stdout, subprocess.PIPE, startupinfo, config.env, cwd)
  File "E:\Programming\sublime_text_4100\Data\Installed Packages\LSP.sublime-package\plugin/core/transports.py", line 323, in _start_subprocess
    cwd=cwd)
  File "./python3.3/subprocess.py", line 819, in __init__
  File "./python3.3/subprocess.py", line 1110, in _execute_child
FileNotFoundError: [WinError 2] The system can not find the file specified。

SublimeLinter: WARNING: golangcilint output:
level=error msg="Running error: context loading failed: no go files to analyze"

WARNING:SublimeLinter.plugin.golangcilint:golangcilint output:
level=error msg="Running error: context loading failed: no go files to analyze"

go version go1.15 windows/amd64

This seems line an issue with LSP? IDK there is nothing in this error that I can interpret. But the LSP devs should be able to tell?

FileNotFoundError: [WinError 2] The system can not find the file specified。

This seems line an issue with LSP? IDK there is nothing in this error that I can interpret. But the LSP devs should be able to tell?

It means that the constructed command contains path that doesn't exist.

@jingyuexing can you confirm that the gopls binary was actually installed into the ${storage_path}/LSP-gopls/bin/ folder

@jingyuexing can you confirm that the gopls binary was actually installed into the ${storage_path}/LSP-gopls/bin/ folder

yes,i'm sure,I even installed it manually

yes,i'm sure,I even installed it manually

it looks like it should work better with latest changes?

Haven't tested but it looks good. (just some minor nits)

😂😂

yes,i'm sure,I even installed it manually

it looks like it should work better with latest changes?

i'm haven't test it

yes,i'm sure,I even installed it manually

it looks like it should work better with latest changes?

The same error message as before, "File not found"

yes,i'm sure,I even installed it manually

it looks like it should work better with latest changes?

if using the default config from LSP, working fine, but LSP-gopls will report information:"can't find the file"

LSP: starting ['E:\\Programming\\sublime_text_4100\\Data\\Package Storage/LSP-gopls/gopls'] in I:\Code\go\Study_GO
Unable to start subprocess for gopls
Traceback (most recent call last):
  File "./python3.3/subprocess.py", line 1104, in _execute_child
FileNotFoundError: [WinError 2] The system can not find the file specified。

look like is directory wrong: Package Storage/LSP-gopls/gopls ,but the real path is Package Storage/LSP-gopls/bin/gopls

LSP: starting ['E:\Programming\sublime_text_4100\Data\Package Storage/LSP-gopls/gopls']

LSP: starting ['E:\Programming\sublime_text_4100\Data\Package Storage/LSP-gopls/gopls']

I moved the file to the Package Storage/LSP-gopls directory, everything is normal

LSP: starting ['E:\Programming\sublime_text_4100\Data\Package Storage/LSP-gopls/gopls']

I moved the file to the Package Storage/LSP-gopls directory, everything is normal

What are your LSP-settings?
Zach Schulze
On Nov 1, 2021, 4:17 PM -0700, jingyuexing @.***>, wrote:

LSP: starting ['E:\Programming\sublime_text_4100\Data\Package Storage/LSP-gopls/gopls']
I moved the file to the Package Storage/LSP-gopls directory, everything is normal
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

What are your LSP-settings? Zach Schulze
…
On Nov 1, 2021, 4:17 PM -0700, jingyuexing @.***>, wrote: > LSP: starting ['E:\Programming\sublime_text_4100\Data\Package Storage/LSP-gopls/gopls'] I moved the file to the Package Storage/LSP-gopls directory, everything is normal — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
My custom config is：

"gopls": {
            "enabled": false
 },

The default config is:
"gopls": {
      "command": [
        "gopls"
      ],
      "selector": "source.go",
    },

What are your LSP-settings? Zach Schulze
…
On Nov 1, 2021, 4:17 PM -0700, jingyuexing @.***>, wrote: > LSP: starting ['E:\Programming\sublime_text_4100\Data\Package Storage/LSP-gopls/gopls'] I moved the file to the Package Storage/LSP-gopls directory, everything is normal — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

My custom config is：
"gopls": {
            "enabled": false
 },

The default config is:
"gopls": {
      "command": [
        "gopls"
      ],
      "selector": "source.go",
    },

Your default config is wrong.
It should be
  "command": [
    "${storage_path}/LSP-gopls/bin/gopls"
  ],


Python SDK for Event Grid

Python SDK for Event Grid

@kalyanaj,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #1367 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
+ Coverage   54.82%   54.82%   +<.01%
==========================================
  Files        3012     3014       +2
  Lines       75844    75846       +2
==========================================
+ Hits        41578    41580       +2
  Misses      34266    34266

Impacted Files
Coverage Δ

azure-mgmt-eventgrid/azure/mgmt/__init__.py
100% <100%> (ø)

azure-mgmt-eventgrid/azure/__init__.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608444c...b229d48. Read the comment docs.


Graphviz missing from docs builders

It seems like the Graphviz library/header files is missing from at least one builder. This has been mostly working for years, but failed in this build: https://readthedocs.org/projects/mopidy/builds/3373477/

Yup, looks like the new builder instances missed that dependency. I'll add it in today.

Confirmed the missing pkg-config dependency was the root cause. I'm deploying new images now, try again in a couple hours.

Closing due to inactivity

Docs have been building fine since you deployed new images. Sorry I didn't report back.


how to use Pager as Lazy component.

I want to use this infinity pager as a lazy component like wen view comes into visiable then the screen render

you can use either isActive boolean or listen to the focusAnim reanimated value to gate screen rendering: https://github.com/computerjazz/react-native-infinite-pager/blob/aa5a2d08743798a89a691eb2cd04fbabd781b8c8/src/index.tsx#L307-L308


would it make sense to have a std feature that enables std::error::Error implementations?

Yes! That is exactly why I should have had a std feature flag, but at the time I was setting up the initial flags, I couldn't remember anything from std we'd need.


Adding a first draft of CONTRIBUTING.md

[x] Final edits needed

All that's pending now is a roadmap, but I think we can merge this PR, and add to the roadmap in the docs when we're ready!


Cancellation signals caught by hishel?

In my project I have a method which starts and runs workers in parallel.
Workers are spawned in an asyncio.TaskGroup, having an asyncio.Queue (input_queue) handed to them, from which they pull their work items.
Within the async context of the TaskGroup, I wait for the input_queue to become empty (input_queue.join()). When that happens (meaning that there is no more work to be done) the tasks in the TaskGroup receive a cancellation signal via task.cancel(), after which they stop execution and if all are cancelled, the async context of the TaskGroup is left.
Now, when I use the basic httpx.AsyncHTTPTransport this seems to work fine, but when i use hishel.AsyncCachingTransport, somehow the cancellation of workers never happens, and they keep running, even though the input_queues are already empty.
Is there a possibility, that hishel.AsyncCachingTransport swallows the cancellation signals?
Some code for better understanding:
class WorkerConfig:
    """
    WorkerConfig sets parameters to define worker execution like
    e.g. number of concurrently executing instances of a worker.
    """

    def __init__(self, worker: Worker, num_concurrent: int):
        self.worker = worker
        self.num_concurrent = num_concurrent

    def get_num_concurrent(self) -> int:
        return self.num_concurrent

    def get_worker(self) -> Worker:
        return self.worker

async with asyncio.TaskGroup() as group:
    tasks: set[asyncio.Task] = set()
    for worker_cfg in worker_configs:
        for _ in range(worker_cfg.get_num_concurrent()):
            task = group.create_task(worker_cfg.get_worker().do_work())
            tasks.add(task)
    for worker_cfg in worker_configs:
        await worker_cfg.get_worker().input_queue.join()
    for task in tasks:
        task.cancel()

I was curious about this and tried to reproduce it. So I fleshed out your code more and ended up with the following script:
#!/usr/bin/env python3

import hishel
import httpx

import asyncio

class Worker:
    def __init__(self, input_queue: asyncio.Queue, client: httpx.AsyncClient) -> None:
        self.input_queue = input_queue
        self.client = client

    async def do_work(self) -> None:
        while True:
            url = await self.input_queue.get()
            print(f"Pulled from queue: {url}")
            response = await self.client.get(url)
            if response.is_success:
                print(f"Successful request to {url}")
            else:
                print(f"Unsuccessful request to {url}")
            self.input_queue.task_done()

class WorkerConfig:
    """
    WorkerConfig sets parameters to define worker execution like
    e.g. number of concurrently executing instances of a worker.
    """

    def __init__(self, worker: Worker, num_concurrent: int):
        self.worker = worker
        self.num_concurrent = num_concurrent

    def get_num_concurrent(self) -> int:
        return self.num_concurrent

    def get_worker(self) -> Worker:
        return self.worker

async def work() -> None:
    queue = asyncio.Queue()
    #async with httpx.AsyncClient() as client:
    async with httpx.AsyncClient(
        transport=hishel.AsyncCacheTransport(
            transport=httpx.AsyncHTTPTransport(),
            storage=hishel.AsyncInMemoryStorage()
        )
    ) as client:
        worker_configs = [
            WorkerConfig(
                worker=Worker(input_queue=queue, client=client),
                num_concurrent=2,
            ),
            WorkerConfig(
                worker=Worker(input_queue=queue, client=client),
                num_concurrent=1,
            ),
        ]

        async with asyncio.TaskGroup() as group:
            tasks: set[asyncio.Task] = set()

            for worker_cfg in worker_configs:
                for _ in range(worker_cfg.get_num_concurrent()):
                    task = group.create_task(worker_cfg.get_worker().do_work())
                    tasks.add(task)

            for _ in range(20):
                await queue.put("https://example.com")

            for worker_cfg in worker_configs:
                await worker_cfg.get_worker().input_queue.join()

            for task in tasks:
                task.cancel()

def main() -> None:
    asyncio.run(work())

if __name__ == "__main__":
    main()

For me (Python 3.12 and hishel 0.0.29), it seems to work fine: The workers do their stuff, the tasks are canceled, they exit and the program exits. Can you provide more detail about what exactly you are doing?

Okay, that is interesting. I recently switched from my own worker implementation to ray actors. i currently do not have hishel in use to follow up on this topic right now, which is why i will close the issue. Because it seems like it could have been an implementation issue on my side then.
As soon, as I found time to integrate hishel into the new architecture, i might open the issue again, if it still arises.
Thank you very much for trying it out also!


fix(datastore-v1): mutation event got ignored while executing parallel saving

Issue #

https://github.com/aws-amplify/amplify-swift/issues/2059
Related PR
v2 fix - https://github.com/aws-amplify/amplify-swift/pull/2781
Description

In the MutationEvent saving implementation, we check nextEventPromise at the beginning to detect wether put the MutationEvent to inProgress status. After it's written to database, we change the nextEventPromise to nil. The operation between non-nil check at the beginning and set value nil for nextEventPromise doesn't lock the access of nextEventPromise. It may took over hundred milliseconds for writing to the database. In this duration, if there is any MutationEvent get saved, it will have inProcess = true. But only one of them will be handled back to the MutationEventPublisher.
This change simply getAndSet the nextEventPromise to nil to ensure only one thread has the access to stored nextEventPromise in Atomic container. Thus other parallel calls will have the MutationEvent with inProgress = false.
General Checklist

[X] Added new tests to cover change, if needed
[X] Build succeeds with all target using Swift Package Manager
[X] All unit tests pass
[X] All integration tests pass
[X] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
[ ] ~Documentation update for the change if required~
[X] PR title conforms to conventional commit style
[X] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
[ ] ~If breaking change, documentation/changelog update with migration instructions~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2782 (4aa91f8) into v1 (f659187) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##               v1    #2782      +/-   ##
==========================================
- Coverage   64.40%   64.39%   -0.02%
==========================================
  Files         720      720
  Lines       22836    22838       +2
==========================================
- Hits        14708    14707       -1
- Misses       8128     8131       +3

Flag
Coverage Δ

API_plugin_unit_test
66.62% <ø> (+0.09%)
:arrow_up:

AWSPluginsCore
73.29% <ø> (-0.08%)
:arrow_down:

Amplify
51.27% <ø> (ø)

Analytics_plugin_unit_test
72.58% <ø> (ø)

Auth_plugin_unit_test
83.80% <ø> (ø)

DataStore_plugin_unit_test
82.01% <83.33%> (-0.06%)
:arrow_down:

Geo_plugin_unit_test
57.87% <ø> (ø)

Predictions_plugin_unit_test
33.58% <ø> (ø)

Storage_plugin_unit_test
59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...utationDatabaseAdapter+MutationEventIngester.swift
82.46% <83.33%> (-0.43%)
:arrow_down:

...e/AWSPluginsCore/Auth/AWSAuthServiceBehavior.swift
75.00% <0.00%> (-12.50%)
:arrow_down:

...oreCategoryPlugin/Sync/Support/Model+Compare.swift
82.65% <0.00%> (-2.05%)
:arrow_down:

...gin/Subscribe/DataStoreObserveQueryOperation.swift
79.91% <0.00%> (-0.90%)
:arrow_down:

...gin/Sync/InitialSync/ModelSyncedEventEmitter.swift
95.87% <0.00%> (+1.03%)
:arrow_up:

...CategoryPlugin/Operation/AWSGraphQLOperation.swift
61.62% <0.00%> (+2.32%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Smallest window in a string containing all the characters of another string - POTD | 24-Sep-2024

Smallest window in a string containing all the characters of another string
Link
Difficulty: Hard
Given two strings s and p. Find the smallest window in the string s consisting of all the characters(including duplicates) of the string p.  Return "-1" in case there is no such window present. In case there are multiple such windows of same length, return the one with the least starting index.
Note : All characters are in Lowercase alphabets.
Examples:
Input: s = "timetopractice", p = "toc"
Output: toprac
Explanation: "toprac" is the smallest
substring in which "toc" can be found.
Input: s = "zoomlazapzo", p = "oza"
Output: apzo
Explanation: "apzo" is the smallest
substring in which "oza" can be found.

Expected Time Complexity: O(|s|)
Expected Auxiliary Space: O(n), n = len(p)
Constraints:

1 ≤ |s|, |p| ≤ 105

Solved
class Solution:
    def smallestWindow(self, s, p):
        from collections import Counter
        p_count = Counter(p)
        required = len(p_count)
        left, right = 0, 0
        formed = 0
        window_counts = {}

        min_length = float('inf')
        min_left = 0

        while right < len(s):
            character = s[right]
            window_counts[character] = window_counts.get(character, 0) + 1

            if character in p_count and window_counts[character] == p_count[character]:
                formed += 1
            while left <= right and formed == required:
                character = s[left]

                if right - left + 1 < min_length:
                    min_length = right - left + 1
                    min_left = left

                window_counts[character] -= 1
                if character in p_count and window_counts[character] < p_count[character]:
                    formed -= 1

                left += 1

            right += 1

        return s[min_left:min_left + min_length] if min_length != float('inf') else "-1"


[$250] Fix Workflow defaults for NewDot Workspaces

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: @garrettmknight
Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1726136887331749?thread_ts=1725892977.799399&cid=C06ML6X0W9L
Action Performed:

Sign up with a new account
Select 'Manage my team's expenses'
Enter a first name
Enable Workflows in the workspace
Navigate to the Workflows tab

Alternatively:

Login with any existing account
Create a workspace
Enable Workflows in the workspace
Navigate to the Workflows tab

Expected result:

When you enable Workflows for the first time, none of the sub-features should be enabled. Further, when Workflows are disabled, the sub-features should be disabled, including payments (reimbursement===none).

The current behavior of payments being enabled as a default is actually intended, allowing users to discover payments through a Pay button. Implementing the change in point 1 above would remove this intended result so let's also change the defaults on workspace creation to:

Enable Workflows on the workspace
Leave payments enabled (which should be the case as a result of the workspace on creation being set to reimbursement===indirect by default).

Actual results
When workflows are disabled, payments remain enabled (reimbursement===indirect).
Workaround:
There isn't really a workaround to the confusion.
Platforms:
All
Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021834372537998037589
Upwork Job ID:<PHONE_NUMBER>998037589
Last Price Increase: 2024-09-19

@garrettmknight Is the summary below expected that we want?

When we create a new workspace, the workflow feature and payments should be enabled by default
When we disable the workflow feature, all sub-features should be disabled.

@mkzie2 has it right here

Taking this one over to confirm defaults for all intents.

Have been out sick, I can take a look at this tomorrow. Please reassign if we this needs more urgency, however.

Okay, took a bit, but we're going to keep it simple here and default all manually created workspaces in NewDot to have Workflows and Payments enabled just like they technically are in OldDot.

Taking this off hold.

@rushatgabhane I'm betting this needs backend changes - let's wait till @MariaHCD is back for her to help.

but we're going to keep it simple here and default all manually created workspaces in NewDot to have Workflows and Payments enabled just like they technically are in OldDot.

Are we? 🤔 If your intent is track and you create a workspace after, we wouldn't would we?

Alright, so clarifying the expected behaviour here.
Enable workflows and payments when a workspace is created

when your introSelected value is empty
your introSelected value is newDotManageTeam ("Manage my team's expenses) or newDotLookingAround ("Something else").
If we create a workspace via the Submit > "Pay with business bank account" flow (convertIOUToExpenseReport I believe) regardless of the introSelected onboarding intent.

Do not enable workflows and payments when a workspace is created when

your introSelected value is newDotTrack ("Track and budget expenses"), newDotEmployer ("Get paid back by my employer") or newdotSplitChat ("Chat and split expenses with friends")

Okay, so as a next step we're asking @MariaHCD to confirm that, yes?

Looking through to see what BE changes we will need

@trjExpensify could you clarify what we mean by enabling payments when a workspace is created? Is that to set the workspace reimbursement to any of these specific values?

Yep, that's right. So in NewDot for the "Enable workflows and payments when a workspace is created" cases above, that means:

Enable Workflows so the Workflows page appears in the LHN of the workflow settings (I believe that's achieved by setting areWorkflowsEnabled to true).
On the Workflows page, toggle on Make or track payments. In doing so, that should set the reimbursementChoice to reimburseManual (A.K.A "Indirect"). If they connect a VBBA thereafter, that updates reimbursementChoice to reimburseYes (A.K.A "Direct"). If they toggle "Make or track payments" off on the Workflows page OR disable "Workflows" in More Features, that should set the reimbursementChoice to reimburseNo (A.K.A "None").

Okay, thanks for clarifying. Will list out the BE changes I think we will need shortly.

Here are the changes I think we will need:

In CreateWorkspace, get the introSelected NVP
If it is empty or equal to newDotManageTeam or newDotLookingAround:

set the areWorkflowsEnabled to true for the policy
set the reimbursement to manual for the policy

Ensure these two updated values are sent in Onyx so the FE can handle appropriately

cc: @mountiny @luacmartins for a buddy check on the above 🙏🏼

That sounds good to me. One question, why do we want to enable workflows and reimbursements if introSelected is empty?

Coz' ~@garrettmknight is passionate about it 😛~ the idea is that if we don't know the intent, we lean on the side of minimally showcasing payment capabilities for now.

Thanks for clarifying. Plan sounds good to me then.

Sounds good to me as long as that will make Garrett happy

@parasharrajat I updated proposal

@parasharrajat, what do you think about that proposal for the frontend?
@MariaHCD, did you get anywhere with the backend yet to link a draft?

Got a draft PR here: https://github.com/Expensify/Auth/pull/12649
Working on tests.

@trjExpensify Do we have to disable delay submit as well?

Yeah, when Workflows is disabled it should disabled delayed submission and thus set scheduledSubmit=instantly.

The BE PR is out for review: https://github.com/Expensify/Auth/pull/12649
To clarify, this PR covers this portion of @mkzie2's proposal:

When we create a new workspace (CreateWorkspace API), BE should return areWorkflowsEnabled as true and reimbursementChoice as reimburseManual if introSelected is empty or it's equal to newDotManageTeam or newDotLookingAround

I wanted to clarify the second point:

When we disable the workflow feature (EnablePolicyWorkflows API), BE should return additional data which will update autoReportingFrequency to CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT

@trjExpensify Should auto reporting frequency also be set to instant when the workflows are disabled?

Nice yeah, I believe Carlos M fixed that recently.

Update on the BE side, hit a bit of a blocker - since we're changing the behavior of policy creation, it looks to be causing quite a few integration tests in the API to fail which will each have to be looked into carefully. Plan here: https://github.com/Expensify/Auth/pull/12649#issuecomment-2388593067

Appreciate the update! 👍

Resuming on the BE PR this week.

Haven't been able to make progress on the BE PR just yet. Still need to look carefully into those failing tests.

I'm resuming investigating those integration tests failures so we can push the BE fix.

Excellent, thanks! With #wave-collect closed, I'm moving this into the #convert project to ensure workflows & payments are enabled when the "manage my team's expenses" intent is selected and a workspace is created.

The BE PR is still on my list. Working on updating those failing tests.

Working on fixing the failings tests in https://github.com/Expensify/Web-Expensify/pull/43779 based on the changes in https://github.com/Expensify/Auth/pull/12649

From working through those failing tests, I've seen that the behavior of report next steps as well as the AddWithdrawalAccount inbox task has changed. Looking into this more next week.

Thanks, that would be great. Really keen to get this cleaned up for newbies!

This is on my list for this week

OOO today will get back to this tomorrow

Got a bit swamped with other dailies and chores this week. Going to resume my deep dive into the updated logic for next steps and the AddWithdrawalAccount inbox task  tomorrow.

Currently working on this!

Logic around the report next steps seem to be affected with this change, will look further: https://github.com/Expensify/Auth/pull/12649#issuecomment-2470598436

@trjExpensify @MariaHCD I got assigned this bug. I think it might be fixed in this issue, as I suspect part of the issue now is we're prompting US workspaces to pay before enabling payments, even though we aren't yet enabling workflows + payments at the time of workspace creation (which we're doing here).
Curious if y'all agree?

I'm not sure I'm following how they're related, actually. I can take it that issue though!

As a summary:

The Auth PR that auto-enables workflows and payments is available here: Auth PR #12649.
The failing Web tests in this PR suggest the logic change has side effects on OldDot flows. I've been working on addressing these issues in this Web PR: Web-Expensify PR #43779. However, I haven't fully identified all the side effects on OldDot yet.

I'll be OOO next week, but I can pick this back up when I return. If it's urgent, feel free to reassign the task.

Maria is back next week, Melv.

Back from OOO - resuming this week.

Prioritized other dailies last week - relooking here.

No updates just yet. Getting back to this today.

I believe we might need an App PR to ensure the FE is handling the props correctly: https://github.com/Expensify/App/issues/49127#issuecomment-2374008078

How are we getting on here? This topic has come up a few times recently, it would be great to get this over the line.

Sorry, haven't been able to resume this since I've been prioritizing stability and retain issues. I'll specifically carve out some time for this tomorrow.


Unit tests

Unit tests
Note: some of the functions are premium-only features (by Discord) or utilize a core functions―helper functions; therefore, may not be included in the unit tests.
Closes: #106

Let's move the checklist on here to separate issues for anything not yet completed.

I would also like to see a badge on the readme somewhere about this, we can keep it at the bottom of the readme until we fix this properly for tests to succeeed

Let's move the checklist on here to separate issues for anything not yet completed.

I have removed the checklist from here and posted it as a comment in the main issue.

I would also like to see a badge on the readme somewhere about this, we can keep it at the bottom of the readme until we fix this properly for tests to succeeed

Done :)


What about .Net Standard

Can you add netstandard in this document? You talk a little about PCL, but not at all about .Net Standard!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1482e18-5f1f-3a8a-3321-66af52879ec5
Version Independent ID: d70bd2f5-c04b-9207-62a0-4ecb6e8e5ca6
Content: Multi-targeting for NuGet Packages
Content Source: docs/create-packages/Supporting-Multiple-Target-Frameworks.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

All the supported target frameworks are listed in following link;
https://docs.microsoft.com/en-us/nuget/reference/target-frameworks

Here's a new topic on multitargeting using the project file:
https://docs.microsoft.com/en-us/nuget/create-packages/multiple-target-frameworks-project-file


Add single prompt option

Currently if you use a prompt with more than one lines it will assume you want to use multiple prompts. Instead of doing something more complicated this flag simply tells it that you only are using one and combines all the lines back into one prompt.

Superseded by #6


Gym Website

Is your feature request related to a problem? Please describe.
I Have created a website for gym

@Ayush7614 Please Assign the Task To Me


Undeploy Fails on 404 (Unavailable)

If I try and undeploy a package that isn't present, we get a 404 error and the task fails. On the one hand, that's correct, the task has not taken action. However, the environment state is correct. Should there be an option to "accept not found" as a success? So that if it's not deployed, I don't have to skip/pass the task, but it should just continue to the next step?

That is indeed correct behavior. Would it help if we add for example a task like does ci exist and returns True or False in an output variable?

Something like that would be useful. Even more useful if you could implement it at the start of a deployment task as a precondition.

I think if the output is True or False you could store that into an XLR variable, and reuse that in the next deployment/undeployment task in the precondition.

Released v2.6.0 with an additional task to check if a CI exists.

Closing issue. See v2.6.0


Signalling server at https://webrtc.nirbheek.in/ is currently down

Just getting the message
Status: Too many connection attempts, aborting. Refresh page to try again

This was because of a bug in the websockets library. I've updated it and restarted the server. Thanks for reporting.


Create a private endpoint

After follow your "Deploy ASP.NET", working perfectly.
https://learn.microsoft.com/en-us/azure/app-service/quickstart-dotnetcore?tabs=net70&pivots=development-environment-vs
and continue the lab, stuck in this step. "No supported sub-resources"

Sad!
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d16533ae-5e19-5769-4c29-581152f8c30c
Version Independent ID: 3f1b2b47-0bfe-b65c-ad0a-cca3586f7ba7
Content: Quickstart: Create a private endpoint - Azure portal - Azure Private Link
Content Source: articles/private-link/create-private-endpoint-portal.md
Service: private-link
GitHub Login: @asudbring
Microsoft Alias: allensu

@ReySys
Thanks for your feedback! We will investigate and update as appropriate.

@ReySys , as mentioned in the prerequisites section,
An Azure App Services web app with a Basic, Standard, PremiumV2, PremiumV3, IsolatedV2, Functions Premium (sometimes referred to as the Elastic Premium plan) app service plan, deployed in your Azure subscription.
For more information and an example, see Quickstart: Create an ASP.NET Core web app in Azure.
The subresource is the published web app that you need to connect.
https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-overview#private-endpoint-properties
Make sure you have a supported web app plan and the web app is published.
Only then you will get the option to select the sub-resource as below:

The supported web app plans are: Basic, Standard, PremiumV2, PremiumV3, IsolatedV2, Functions Premium (sometimes referred to as the Elastic Premium plan) app service plan.
NOTE: Free and shared plans will not work.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

Is nre free account with $200 in credit. Same considerations?
Reynaldo Ruiz Flores
[cid:35df3fd7-75dd-448d-9a08-4ad7d3e96205] SpectralByte

From: Gitarani Sharma @.>
Sent: Wednesday, September 6, 2023 4:55 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Reynaldo Ruiz Flores @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Create a private endpoint (Issue #114260)
@ReySyshttps://github.com/ReySys , as mentioned in the prerequisites sectionhttps://learn.microsoft.com/en-us/azure/private-link/create-private-endpoint-portal?tabs=dynamic-ip#prerequisites,
An Azure App Services web app with a Basic, Standard, PremiumV2, PremiumV3, IsolatedV2, Functions Premium (sometimes referred to as the Elastic Premium plan) app service plan, deployed in your Azure subscription.
For more information and an example, see Quickstart: Create an ASP.NET Core web app in Azurehttps://learn.microsoft.com/en-us/azure/app-service/quickstart-dotnetcore.
The subresource is the published web app that you need to connect.
https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-overview#private-endpoint-properties
Make sure you have a supported web app plan and the web app is published.
Only then you will get the option to select the sub-resource as below:
[image]https://user-images.githubusercontent.com/67630903/265983726-bf51084f-ff8d-4604-8014-a9e137e096b7.png
The supported web app plans are: Basic, Standard, PremiumV2, PremiumV3, IsolatedV2, Functions Premium (sometimes referred to as the Elastic Premium plan) app service plan.
NOTE: Free and shared plans will not work.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/114260#issuecomment-1708119233, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATINSIHX4354MFASJ3NJJX3XZBJDLANCNFSM6AAAAAA4I7HJYQ.

Refer: https://learn.microsoft.com/en-us/azure/app-service/networking/private-endpoint


Licensing unclear

I'm interested in forking parsack and porting it to GNU Guile Scheme, but I don't see any licensing information for this project. Would it be possible to make the licensing clearer?
Thanks,
Remy Goldschmidt

@greghendershott @LeifAndersen @neomantic I'm going to add an LGPL license (same as Racket). Is this acceptable?

That works for me.

The frog and markdown packages are MIT, so IIUC they couldn't use parsack if it is LGPL?  Therefore I'd strongly prefer MIT, if that's OK with the rest of you.

The frog and markdown packages are MIT, so IIUC they couldn't use parsack if it is LGPL?

I believe MIT-licensed software can "use" LGPL software (but not GPL), but can't modify. Would you consider the parsack.rkt file in markdown "derivative"?
Anyhow, I don't have a strong opinion so I will go with MIT if everyone else is ok with it.

Although I always lean words the (L)GPL, I didn't contribute that much, so
I'll go with the majority.  It is, though, perfectly acceptable to
dual-license with MIT and LGPL.

@stchang I don't know. IANAL. My concern is that, even if one hired a lawyer to advise, the answer might be a lot of expensive flowery language that amounts to, "maybe; it depends". I'm exaggerating a little but I've seen that happen enough, so....
It seems like the most broadly compatible option is to use MIT, since it permits any usage by any other license. IIUC.

Oh weird timing, I typed that just as you pushed the commit. Thank you!

I really don't care which way we go on this. My natural inclination is (L)GPL, but I don't care.
MIT projects should be able to link to LGPL projects: http://www.gnu.org/licenses/lgpl.html
Unless I'm mistaken, having marcdown be X11/MIT licensed should not be a problem.

Ah, I see you licensed it under MIT, that works too.


Return an empty stats if the container is restarting

- What I did
Send an empty stats if a container is restarting to avoid suspended docker-stats.
Closes #27772
- How I did it
In case stream is 0 and the given container is restarting the daemon returns an empty stats.
- How to verify it
$ docker run --restart always ubuntu true
$ docker stats --no-stream
CONTAINER           CPU %               MEM USAGE / LIMIT   MEM %               NET I/O             BLOCK I/O           PIDS
61d2e2e3fbb3        0.00%               0 B / 0 B           0.00%               0 B / 0 B           0 B / 0 B           0

ping @crosbymichael

LGTM


Fix buffer example

The first commit (3234280) fixes the JsBuffer example.
The other commit (172a013) is an attempt to make the section read better. Hope it helps.

Thanks!

Thanks!