Apps should never reference ConsoleDriver

Originally posted by @dodexahedron in https://github.com/gui-cs/Terminal.Gui/pull/3615#discussion_r1685170103

I have never cared for this method's name, either.

Typically, an instance method on a type that has a simple verb name results in that verb being performed on the instance of the type. In other words, a Move instance method implies that the ConsoleDriver is being moved, which of course is not what's happening.

This repositions ConsoleDriver's equivalent of cursor position without moving the actual cursor, so is really just moving a 2D index for internal operations.

The method seems unnecessary anyway, however. The Row and Col properties are both public auto-properties. Why not make their set accessors public if the consumer can already effectively change them directly?

I semi-agree. My take is ConsoleDriver details should not be exposed to app code, AT ALL.
All of these operations (AddRune, Move, GetAttribute, ...) should be on either View or Application.
This issue is to track this.

I also mostly agree, but perhaps have a different ideal or at least more words (ha - never) about how I think we should go about it.
As is common in even .net itself, it's totally cool and often good to hide the internal exemplar implementation that most people will probably end up using, meaning making ConsoleDriver internal is something I'm 100% in favor of.
However...
It's still a good idea to abstract the concept of the console away, for the same reason it was originally done - there are differences between platforms, and there always will be. And if we don't have an abstraction, what public API surface we do expose ends up coupling consumer code to our implementation anyway, half defeating the purpose of the endeavor.
While the BCL may certainly continue to evolve to make the platform differences less and less apparent, as has been happening, there will always be something that needs to be special-cased. Without an abstraction, even if it's a pretty thin one, that just leads to significantly less-maintainable code, due to scattered workarounds that also end up being bug and regression factories later on.
Instead, I strongly believe we MUST create a public interface.
This is a low-effort thing we can do (and really should do in an SDK in 2024) so that consumers can still implement their own extensions, at most, or that they can have a stable contract for interfacing with TG at a lower level, at minimum.
That just means we need to dogfood any such interface, as well.
Fortunately, ReSharper makes that a fairly simple task, at least on the surface, since you can "extract interface," which will grab all the visible members of the class and make an interface from them. There is a high probability that we would, however, need to make some modifications to things to eliminate assumptions made internally that directly affect the externally visible API surface.
That would also be a boon for testing, both internally and for consumers. Interfaces make things so much easier - especially in that realm.
In fact, I'd even go as far as to say I would support sealing the platform-specific drivers, as well, (but leaving them public), and if necessary, define platform-specific interfaces to be the sole means of extending them, because - as above - we don't want consumer code dependent on implementation of those either, if they're writing code at that level or lower. They'd be free to wrap them, since they'd still be public, and would be able to use and pass them around as either their native types or as the interface, but they'd be required to stick to the interface, otherwise, without ability to directly override the implementations of those drivers.


Allow ballerina internal APIs to pass external non blocking clients

Description:
When we use ballerina internal methods using interop, if the internal logic goes on a non blocking path , then inter op will fail to provide the correct return value. We are trying to externally call the method [1], but which has default access modifier. Would it be possible to make this method public, and also the enum[2] also public.
[1] - https://github.com/ballerina-platform/ballerina-lang/blob/v1.1.3/stdlib/mime/src/main/java/org/ballerinalang/mime/nativeimpl/AbstractGetPayloadHandler.java#L56
[2] - https://github.com/ballerina-platform/ballerina-lang/blob/v1.1.3/stdlib/mime/src/main/java/org/ballerinalang/mime/nativeimpl/AbstractGetPayloadHandler.java#L163
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Fixed via #21240, Hence closing issue


What is technical art behind “Skia Enabled” old app?

I am testing some of my FMX apps with “Skia Enabled” in C++ Builder 12, both runs well. My app is displaying a bitmap that has dynamic 3D drawing into it. When I enable Skia, does this make sense? I mean, if there is a drawing process into a bitmap and displaying bitmap(s), does it make sense when Skia is enabled?
Actually how Skia works? What is technical behind? Based on components? On the Form, or on screen display? CPU/GPU usage?
When it is enabled, what happens to FMX (fmx drawing methods are being changed?) ?
What happens to double buffering and other graphics mechanics?
As I know it is 2D, does it affect to 3D graphics too?

Skia4Delphi is a graphics library that can be seen in 3 main parts: api, controls and fmx renderer. "Enable Skia" will set binaries and configure deployment in your project (as we are still a shared library), and is a fundamental step towards using the library. The fmx renderer is an extra and optional feature, being enabled by adding "::Fmx::Skia::GlobalUseSkia = true:" at program startup (in Delphi, this line is automatically added to the .dpr when clicking "Enable Skia"). After that, skia4delphi will register its own TCanvas for forms, bitmaps and printers. Skia does not support 3D drawings, so it does not replace the rendering of 3D forms (TContext3D), but this is changing in newer versions and perhaps we will have a 3D rendering based on Skia in the future.
In addition, there are some backends of Skia that can be chosen, is special, the Vulkan (that is disabled by default).

Thank you. Just a recommendation, a schematic graphical pipeline presentation (one side old FMX app, other side skia enabled FMX app) would be nice to explain all, thank you. i.e. https://vulkan-tutorial.com/Drawing_a_triangle/Graphics_pipeline_basics/Introduction


Add eslint status checks actions

And testing out the workflow.

@xt0rted thank you for submitting this PR.  If it is ok with you, I will keep this PR open just now to see if we can get an answer about why the checks are showing.

@xt0rted your changes have been merged, thanks for your contribution 👍


Change project name and cli command form ocdev to od

We should change the name of the project form ocdev to od, as it's much lightweight name for the command, follows oc pattern and still reflects the intent of the tool, openshift for developers, od.
cc/ @gshipley @marekjelen

@jorgemoralespou agree od sounds better then ocdev

-1 on od, it is already a thing on MacOSX, Linux...see http://man7.org/linux/man-pages/man1/od.1.html
I propose odev or something else clever and/or just go full into the plugin/addon space as oc dev.

@sspeiche wow, just realized "od" is there on Fedora too, that too a part of coreutils -
$ dnf provides /usr/bin/od
coreutils-8.27-20.fc27.x86_64 : A set of basic GNU tools commonly used in shell scripts
Repo        : @System
Matched from:
Filename    : /usr/bin/od

<redacted output further>
coreutils-8.27-20.fc27.x86_64 : A set of basic GNU tools commonly used in shell scripts
coreutils-single-8.27-20.fc27.x86_64 : coreutils multicall binary
coreutils-8.27-16.fc27.x86_64 : A set of basic GNU tools commonly used in shell scripts
coreutils-single-8.27-16.fc27.x86_64 : coreutils multicall binary

What about ocd?

@cdrage I think a some might find it offensive since it could also mean https://iocdf.org/about-ocd/

As the project is renamed to odo. we should close this.


Solo fails to create node client when using a remote cluster without a LoadBalancer configured

:tada: This issue has been resolved in version 0.21.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix formatting for chained callbacks

fixes #1917, #1888
foo
    .bar(() = {
     })

in cases like this nodes are processed in order: CallExpresson -> PropertyAccess and its child nodes -> ParameterList and its child nodes. Fact that indentation was inserted before the '.' during processing of PropertyAccess should be respected later when we return back to CallExpression and dive into ParameterList however this is something that was missed.
In this PR when token is indented we record line/indentation and later when computing indentation for the node check if current line was already indented and if yes - use actual indentation.

:+1:

@DanielRosenwasser any other notes?

:+1:

:+1:


CRITICAL: [P2P Distance] [$500] Enable immediate slide scrolling without tap

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.62-6
Reproducible in staging?: y
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712975397589869
Action Performed:

Tap green FAB button
Select 'track expense'
Tap distance tab
Touch the screen and pause ever so briefly after touching the screen.
Touch the screen and immediately move

Expected Result:
Able to move the map with fingers when touching the screen
Actual Result:
I need to "tap and then slide" (where my finger needs to hold still for maybe 100ms before moving) rather than just "slide" (ie, where my finger can move immediately after touching the map, like in Google Maps).
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/1793014e-2d15-49d1-b581-b5fe8ef5594e
https://github.com/Expensify/App/assets/38435837/ebcc67b6-c966-4827-b231-4ed349cd39c5

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013a0e30e9fd5243ce
Upwork Job ID:<PHONE_NUMBER>880835072
Last Price Increase: 2024-05-02
Automatic offers:

ikevin127 | Contributor | 0

reviewed, assigining external.

@suneox @shahinyan11 Are you able to reproduce the issue in the emulator iOS and Android?

@mollfpr please can you review the proposals?

What are the next steps?  Are we waiting on @mollfpr to pick a proposal?  What's the ETA on that?

Sorry for the delay. I just got my phone set up to test the issue.
@shahinyan11 Your solution doesn't look good on the web.

@shahinyan11 Your solution doesn't look good on the web.

@mollfpr  Are you about UI or functionality. Are you talking about the user interface or functionality? If you mean the UI, then there is a question of a slight change in styles

@suneox I'm testing your branch but the issue is still there.
https://github.com/Expensify/App/assets/25520267/d2283ff6-e6b2-4c54-ba37-44e28e0441bf
@shahinyan11 Could you please update your proposal to make it work on all platforms?

@shahinyan11 Can you please give an ETA?  Thanks!

@suneox Yes, I'm testing it on SG S23 Ultra. You can see the tap in the video in frames 0.11 and 0.15 is moving but the map is not.

@shahinyan11 Can you please give an ETA? Thanks!

I will give updates today

I have problems with android build. so it can take more time

@mollfpr I have one question. I noticed that my change caused MapView to start capturing navigator gestures. Is it ok ?

bump @mollfpr please get back to @shahinyan11 on their question. Thanks!

@shahinyan11 can you please elaborate on what these "navigation gestures" are?  Do you think it's a good thing?

@quinthar Sometimes navigation between tabs happens when we swipe from left to right on map

Assigning @ikevin127 as C+ from Slack here.

Proposal
Updated

Proposal
Updated.I did complex change to achieve ideal result. I think it works good now

@suneox I tested both your solutions and neither of them work in fixing the issue, even though there might be some small improvement to the capture of the swipe event on the map - if we swipe quick, the issue is still present:
https://github.com/Expensify/App/assets/56457735/8a8c136e-bc6d-41c6-94a6-ac960b792dd6

@shahinyan11 Your solution seems to work and given that it's only changing the index.native.tsx version of the DraggableFlatList it is a good thing because we're not changing logic on other platforms where the issue does not occur.
https://github.com/Expensify/App/assets/56457735/e6adc129-d158-427a-8fa1-dcc476d9a337
There are a few issues with the solution that I need addressed before we can move on:

We need some explanation as to what the solution is doing exactly to fix the issue. I'm asking for this because you simply provided the solution code block, without any explanation as to what the solution is doing.
I noticed that the {...responder.panHandlers} line from your solution is not required for the solution to work. I removed it because your solution did not provide the source of this responder prop. Please also explain this part, whether or not it's actually required and why.
I noticed that you used a setTimeout in your solution, and according to Code patterns to avoid:

Make sure any setTimeouts are absolutely necessary, not just a workaround for a situation that isn’t fully understood (e.g. a race condition).

If you can clear up these things and update your proposal to reflect these clarifications, I'll do a final review to confirm everything works as expected then I'll recommend for assignment.

Based on latest #expensify-open-source Slack 🧵 (conversation): we're currently waiting on @shahinyan11 to clarify their solution and get it to a working state as currently the app crashes when restarting with the solution applied.
Otherwise we're still open to proposals, preferably one that would work as expected based on the above Slack 🧵 conversation. Also, if this is really urgend I'd suggest increasing the bounty! 💰
cc @quinthar @neil-marcellini @zanyrenney

I will have updates untill tomorrow

Proposal
Updated. @ikevin127  I updated my solution because it had a bottleneck and failed in one particular case

@neil-marcellini @ikevin127 Would you mind if I ask for increased compensation here ?

♻ Will review the updated proposals again today!

@ikevin127 Could you please try my alternative solution at this branch? I just sync and test on the latest main it still works well

@suneox I checked out your test branch and as mentioned in my last comment, the capture seems to be improved but the issue is still present if you swipe really fast. The reason why it might look / seem fixed on your side is because you're testing on an emulator using cursor to swipe and because of this you can't replicate really fast swipes as you would on an actual physical device with touch.
I tested this on a physical OnePlus 7T (Android 14) and here's the video of the behaviour (I activated tap visibility), and I tested your branch fix behaviour vs google maps (end of video) and here are the results:

Android: Native (OnePlus 7T - Android 14)
https://github.com/Expensify/App/assets/56457735/fe4d2cd5-0d28-4eb8-83da-cfb0773efe4b

https://github.com/Expensify/App/issues/40211#issuecomment-2059760924. @ikevin127 I updated my solution because it had a bottleneck and destroyed the navigation in one particular case

@shahinyan11 I tested your updated proposal, looks good, it doesn't crash the app anymore upon restart. There are some details related to the solution which I would change but that can be handled during PR.
✅ Here's how the behaviour looks on a physical device compared to google maps:

Android: Native (OnePlus 7T - Android 14)
https://github.com/Expensify/App/assets/56457735/78ba058a-058d-4e13-8ae7-a4ba23b399d1

[!warning]
There's only 1 issue left with your current solution:

It breaks the swipe navigation behaviour the first time you mount the Distance tab page.

What happens exactly is because of your solution, if we try to swipe right to get to the Scan tab, precisely swiping in between the bottom of the map and the Next button -> doesn't work anymore. The user needs to actually tap on the Scan tab, then swipe back to the Distance tab and only then the swipe navigation would work again from the Distance tab. Here's a video to get some visuals in order to better understand the issue:

Note: Pay attention to the tap indicator when I swipe.

Android: Native (Nav Swipe Issue)
https://github.com/Expensify/App/assets/56457735/ce698576-b7fb-4c08-8638-b1787249d2ec

Once this issue is fixed I think we're good for assignment here!

No fully working proposal so far, still looking for a proposal that fixes the issue without creating regressions.

@ikevin127 @suneox After a lot of research and testing many approaches, I came to the conclusion that it is better to leave everything as is or disable the swipe navigation for the distance tab.

Bumped in #expensify-open-source Slack 🧵, hopefully we get more eyes on this!

Could you please help me quick check on your device at the new branch?

I will test and let you know!

@ikevin127 After my research, the PanResponder on MapView sometimes has been terminated by DraggableFlatList and keyboardDissmissPanResponder use onMoveShouldSetPanResponderCapture at ScreenWraper so we have to use onStartShouldSetPanResponderCapture and onMoveShouldSetPanResponderCapture for PanResponder on MapView and separate the custom MapView for android to avoid regression.

It makes sense, I was looking forward to a proposal that would separate logic into index.android.tsx.
Will test and get back with an answer in 1-2 hours!

@suneox Your new test branch tests well 🎉 It fixes our issue as per the expected result (see video below).

Android: Native (OnePlus 7T - Android 14)
https://github.com/Expensify/App/assets/56457735/e00d995b-baff-4fc0-9017-4c1f11167386

Please update your proposal detailing the WHY of the proposed changes so we can clearly understand the root cause and how the solution works in fixing our issue.

Woohoo sounds like we've found a solution?  What's the next step and ETA?

I was asked by @suneox to test the new branch solution from https://github.com/Expensify/App/issues/40211#issuecomment-2091087791 and if working, they mentioned:

I will remove the debugging log and explain in detail after you test it works well

To which I confirmed that the test branch tests well and the new solution seems to work as expected in https://github.com/Expensify/App/issues/40211#issuecomment-2091330144.
@quinthar The next step here would be for @suneox to update their proposal according to the new solution so that we can all understand the WHY of the RCA and how the solution works in fixing the issue.

[!important]
If you think we can skip the detailed proposal update and move forward with the current (not very detailed) updated proposal, then I can move on and assign @suneox.

Please let me know, as I'll be out for the day in about 1 hour!

@suneox's proposal LGTM! The root cause was identified and the proposed solution targets and fixes the issue accordingly.
🎀👀🎀 C+ reviewed

@suneox @ikevin127 There is no need to add a separate component for Android, just add  dragHitSlop prop to the DraggableList component

@suneox @ikevin127 There is no need to add a separate component for Android, just add dragHitSlop prop to the DraggableList component

I think it's safe to split index.native.tsx DraggableList into index.ios.tsx and index.android.ts since on Android we're restructuring the component render by adding a View, which on iOS is not needed because the issue is not present.
This is the recommended way for platform specific changes to be safe and avoid breaking the same, working logic on other platforms.
See https://github.com/Expensify/App/issues/34881#issuecomment-1936178091 issue for reference.

@suneox's proposal LGTM! The root cause was identified and the proposed solution targets and fixes the issue accordingly.
🎀👀🎀 C+ reviewed

I found the proposal to be a bit unclear and hard to follow, but I trust the thorough testing that was already done, so let's create a PR.

Proposal
Updated. I updated proposal as I am sure that the changes in approved proposal does not make sense and not necessary to have that behavior

[x]  [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:

No PR causing this was identified, this was not caused by a recent regression.

[x]  [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need, as this was an edge case issue which happened only on Android: Native due to differences in touch handler.

[x]  [@ikevin127] Determine if we should create a regression test for this bug.

No need for regression test here as as this was an edge case issue which happened only on Android: Native due to differences in touch handler.

[x]  [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

payment summary
paid $500 via upwork to @suneox
paid $500 via upwork to @ikevin127


Move cmake_[windows|linux]_gpu to CUDA-11.3

Also, made a small change to CUDA install script on windows:
echo %errorlevel% would always return 0, and save cuda install log into the home folder rather than in current directory

@malfet I don't think that works and neither passing CU_VERSION. I gave it a try at #4921 and it seems the fix will be more elaborate as it requires installing missing libs, changing the image type etc. I closed it for now and plan to revisit it. If you have pointers let me know. Thanks!

Also, made a small change to CUDA install script on windows: echo %errorlevel% would always return 0, and save cuda install log into the home folder rather than in current directory

@malfet , errorlevel would be non-zero if setup.exe failed.
https://app.circleci.com/pipelines/github/pytorch/pytorch/372302/workflows/8a242e28-ad44-4af6-a53a-a031cb9e92d2/jobs/15706071
C:\w\b\windows\temp_build\cuda>start /wait setup.exe -s thrust_11.3 nvcc_11.3 cuobjdump_11.3 nvprune_11.3 nvprof_11.3 cupti_11.3 cublas_11.3 cublas_dev_11.3 cudart_11.3 cufft_11.3 cufft_dev_11.3 curand_11.3 curand_dev_11.3 cusolver_11.3 cusolver_dev_11.3 cusparse_11.3 cusparse_dev_11.3 npp_11.3 npp_dev_11.3 nvrtc_11.3 nvrtc_dev_11.3 nvml_dev_11.3 -loglevel:6 -log:"C:\w\b\windows\temp_build\cuda/cuda_install_logs"

C:\w\b\windows\temp_build\cuda>echo -469237760
-469237760

in https://circleci.com/api/v1.1/project/github/pytorch/pytorch/15706071/output/104/0?file=true&allocation-id=6129e01c942d271d4e1ef010-0-build%2F7371EF63

@malfet , errorlevel would be non-zero if setup.exe failed.
Yes, but errorlevel is not the same as %errorlevel%, and as far as I understand, general advise for batch scripts is to use if errorlevel, rather than if %errorlevel%, see https://ss64.com/nt/errorlevel.html

Ok, splitting this PR into 3:
https://github.com/pytorch/vision/pull/4944 <- cherry-picks changes from audio back to vision that fixes CMake builds on Linux
https://github.com/pytorch/vision/pull/4945 <- Fix CUDA-11 Windows CMake builds


Ask for updates

Is it possible for you to update to pf4j v.3?

Yes, I will upgrade in my spare time. I'm really busy recently


[zh] Sync Protect Your Mission-Critical Pods From Eviction With PriorityClass blog into Chinese

Translate Protect Your Mission-Critical Pods From Eviction With PriorityClass blog into Chinese:
content/zh-cn/blog/_posts/2023-01-12-protect-mission-critical-pods-priorityclass/index.md

/lgtm

/approve


Couples-ExtendedCouples

Couples-ExtendedCouples

Please resolve conflicts.

Please rename your modules with a suffix of your group ID.


Updated validations.py python scripts.

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
I used isalpha() method for the last conditional command.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

interesting command added


Focused pane marker

Requirements for Adding, Changing, or Removing a Feature

Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
The pull request must contribute a change that has been endorsed by the maintainer team. See details in the template below.
The pull request must update the test suite to exercise the updated functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/atom/tree/master/CONTRIBUTING.md#pull-requests.

Issue or RFC Endorsed by Atom's Maintainers
Closes https://github.com/atom/atom/issues/14283
Description of the Change
This makes the "pane markers" of the One themes have 2 different states:

State
Screenshot

An "active" state -> grey marker

A "active + focused" state -> blue bar

This follows a similar pattern used in the tree-view, where the active file is grey, but turns blue when also focused.

Alternate Designs
Only show the marker when a pane has focus, but it might be nice to see, which of the panes is the active one. For example when opening a new file, you know where it will be opened.
Possible Drawbacks
Some users might prefer to keep the marker blue all the time.
Verification Process

Open a file
Open another file in split mode
Click between tree-view and the files and observe the marker switching between grey and blue

Release Notes
N/A

Ok, let's merge and see how it feels.


#792 Fix loading WPF BitmapImage from a network stream

What kind of change does this PR introduce?
Fixes an issue where BitmapLoader.Current.Load() will throw an InvalidOperationException if a network stream is supplied on Windows platforms.
What is the current behavior?
See #792.
What is the new behavior?
Bitmap is loaded correctly, but the underlying BitmapImage isn't frozen.
What might this PR break?
Shouldn't break anything.
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
Let me know if I missed anything.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: n-ski sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Benchmarks - Add support to allow list of custom config string in cudnn-functions and cublas-functions

Description
Add support to allow list of custom config string in cudnn-functions and cublas-functions.

/azp run


How to start using the package in resource file?

I need to make some tree with data based on datas from 3 db tables
categories - has id, name fields,
user_quiz_requests - has quiz_category_id and user_email fields
users - has id, email fields
I tried to make a container resource with command :
php artisan make:filament-resource UserQuizRequestTree
I have installed "^3.1.18" on  laravel 10.31.0 / filament ^3.0-stable app.
But inserting SelectTree into generated UserQuizRequestTreeResource.php file in “table” block:
<?php

namespace App\Filament\Resources;

use App\Filament\Resources\UserQuizRequestTreeResource\Pages;
use App\Filament\Resources\UserQuizRequestTreeResource\RelationManagers;
use App\Models\QuizCategory;
use Filament\Forms;
use Filament\Forms\Form;
use Filament\Resources\Resource;
use Filament\Tables;
use Filament\Tables\Table;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\SoftDeletingScope;
use CodeWithDennis\FilamentSelectTree\SelectTree;

class UserQuizRequestTreeResource extends Resource
{
    protected static ?string $model = QuizCategory::class;

    protected static ?string $navigationIcon = 'heroicon-o-rectangle-stack';

    public static function form(Form $form): Form
    {
        return $form
            ->schema([
                //
            ]);
    }

    public static function table(Table $table): Table
    {
        return $table
            ->columns([

                \CodeWithDennis\FilamentSelectTree\SelectTree::make('userQuizRequests')
                    ->relationship('userQuizRequests', 'user_name', 'quiz_category_id', function ($query) {
                        return $query;
                    })
            ])
            ->filters([

I got error :
Method CodeWithDennis\FilamentSelectTree\SelectTree::table does not exist.
What must be a container for SelectTree component and how to start using it ?

Why you use it in
public static function table(Table $table): Table
?

This is not how it works, the SelectTree is a field for your form. Besides that it only supports BelongsTo and BelongsToMany.


Bug 1418372 - Essential data missing in the text: where to find the templates

See https://bugzilla.mozilla.org/show_bug.cgi?id=1418372
Acceptance criteria

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Home_page is updated to clarify where to find the templates

This is fixed, but not how you might expect. See my comments in the bug.


Feature: Auto height for items

Sometimes you have a layout where 2 items are in the same column (vertical space) and the first item has a dynamic height. In this case it would be useful to define the height of the first item as "auto". The result would be the item was always just the right height to show the items content, without a scrollbar.

Related https://github.com/deepstreamIO/golden-layout/issues/125


my phone will reboot when app scan files

os: android10
storage: smb(jcifs-ng)
the app: poweramp
and what info should I provide?

thanks in advance

I don't know the cause.
Please tell me the model name for reference.

sorry, late to reply

I don't know the cause. Please tell me the model name for reference.

同様の現象が発生しています
Issue
Androidが再起動する(=AndroidRuntimeが再起動する)
Environment
Pixel 7 Pro
 Android 13
  CIFS Documents Provider 1.70
  PowerAmp build-967
Windows 8

Reproducing

Windows の共有フォルダに1031ファイル(39フォルダ)ほどの音楽データを格納する
CIFS Documents Provider にて上記フォルダに正しく接続できる情報を一つ設定する(安全なデータ転送付き)
# このストレージ接続が正しく動作しているか確認するためにMiXplorerを使用した
PowerAmp の ライブラリ として 上記 CIFS Documents Providerで設定したストレージを追加する
# 自動でフル再スキャンされる。または手動でフル再スキャンを行う
スキャン最中にスキャンが進行しなくなり(固まり)、その後何十秒後かにAndroidが再起動する
# いつ止まるかは不規則(数十～数百ファイルあたり)
この際、logcat -b crash,system を流していると、再起動の瞬間あたりで以下のログが表示される

08-05 02:34:11.115  7798  7821 W Watchdog: *** WATCHDOG KILLING SYSTEM PROCESS: Blocked in monitor com.android.server.StorageManagerService on foreground thread (android.fg)
08-05 02:34:11.116  7798  7821 W Watchdog: android.fg annotated stack trace:
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.BinderProxy.transactNative(Native Method)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.BinderProxy.transact(BinderProxy.java:584)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.IVold$Stub$Proxy.monitor(IVold.java:1470)
08-05 02:34:11.116  7798  7821 W Watchdog:     at com.android.server.StorageManagerService.monitor(StorageManagerService.java:4771)
08-05 02:34:11.116  7798  7821 W Watchdog:     at com.android.server.Watchdog$HandlerChecker.run(Watchdog.java:330)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.Handler.handleCallback(Handler.java:942)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.Handler.dispatchMessage(Handler.java:99)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.Looper.loopOnce(Looper.java:201)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.Looper.loop(Looper.java:288)
08-05 02:34:11.116  7798  7821 W Watchdog:     at android.os.HandlerThread.run(HandlerThread.java:67)
08-05 02:34:11.116  7798  7821 W Watchdog:     at com.android.server.ServiceThread.run(ServiceThread.java:44)
08-05 02:34:11.116  7798  7821 W Watchdog: *** GOODBYE!
08-05 02:34:11.471   415  7455 E vold    : Failed to open AppFuse file for uid: 10589 mountId: 58 fileId: 2 flags: 0: Software caused connection abort
08-05 02:34:11.587  8669  8669 E AndroidRuntime: FATAL EXCEPTION: main
08-05 02:34:11.587  8669  8669 E AndroidRuntime: Process: com.google.android.gms.persistent, PID: 8669
08-05 02:34:11.587  8669  8669 E AndroidRuntime: DeadSystemException: The system died; earlier logs will point to the root cause

jcifs-ng、SMBJ どちらでも発生する
CIFS Documents Provider 1.60 では発生したことがない
PowerAmp のフル再スキャンが再現に手っ取り早いだけで、他アプリを介したストレージアクセスでもAndroid再起動することがある

Result expected

止まらず正しくフルスキャン(1031ファイル)を終える
Androidが再起動しない

I was able to reproduce this event.
We are investigating the cause.

that sounds really great
hope itll be fixed soon! :)

yay thats neat!
but wonder why it didnt occur in v1.60?
just curious.
cant wait next update

It is a lot faster to scan lots of files,. For example, when using PPSSPP emulator, to scan just 42 games it used to take 4-5 minutes. Now It is around 1:20.. still slow, but faster.
I still encounter random reboots when using PPSSPP (it doesn't happen after the initial scan of the games, but if I run PPSSPP again without rebooting the system, Android will crash and reboot during the second time PPSSPP will scan the games directory, a quick reboot). This happens on my Z Fold 3, Android emulator on Win11 and Xperia phone. Strangely, it is the only emulator with this issue.
Also, it seems SMBj, although It is greatly faster than jCIFS when it comes to scanning or reading files, it is not as reliable as jCIFS, I get read errors (corrupted files) when opening files like disc images.. I don't get this when using jCIFS, I would love to use SMBJ since it is faster for me.
Are we not supposed to have multiple connections active at the same time each is using different library SMBJ and JCIFS at the for different folders in the share path? Also, I get issues like mentioned above if I changed the connection from one library to the other after it was used.
After v1.8.0, the Files app sometimes says "Can't load content at the moment".. I have to pull down to refresh few times for the files to show up. It doesn't happen all the time. This seems to be related to the parallel file limitation set to 10, which I believe is the right step to fix this issue, but I also noticed there is a Time Out for each file opened which is set to 10'000?
Can we have options added to the settings of the app to modify these values?
Maybe I should open another issue for my rants.
Thanks @wa2c again.

woo word!
tried v1.8.0 on playstore
PowerAmp full scan completed without any problem 5 times in a row
no more ART rebooting
thanks for the fix :D


Revive struct check lite

The check_struct at runtime was removed because the codegen validates the structs. However, it also checked for unknown fields, thereby catching typos. We should bring that part back.

Fixed (e.g. https://github.com/pygfx/wgpu-py/pull/161)


Error running for first time

I'm getting this error:
just doing the first stepsnpm i -D @peeky/cli => including the scripts in the package and then running the tests as npm run test
> peeky run

...some_path/node_modules/@peeky/cli/dist/bin.js:10863
    const port = options.port ?? process.env.PORT ?? await import_portfinder.default.getPortPromise({
                               ^

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47

What is your node version?

v12.22.1

Could you try with Node 14 and Node 16 please?

It worked thank, unfortunately I cannot change the node version for my project because of some constraints.
Thank you anyways :)

I don't think I'll have enough time to support Node 12. Closing for now.


75 coreui tooltip component

Almost ready for undrafting. The only thing I can't yet figure out is why the MesaTooltips in the Mesa header cells won't show. Any thoughts?


Change the discord link to the #getting-started channel

this is the correct link: https://discord.gg/tczYKDWa

Please assign me to this issue.


installation issue on ubuntu server v14.04

Hi, everyone. I install caffe2 on ubuntu server v14.04 according the guide and the process of compiling is all right. However,something is wrong when i run the command:python -c 'from caffe2.python import core'
_Traceback (most recent call last):
File "/home/benson/anaconda3/lib/python3.5/site-packages/google/protobuf/internal/python_message.py", line 1062, in MergeFromString
if self._InternalParse(serialized, 0, length) != length:
File "/home/benson/anaconda3/lib/python3.5/site-packages/google/protobuf/internal/python_message.py", line 1084, in InternalParse
(tag_bytes, new_pos) = local_ReadTag(buffer, pos)
File "/home/benson/anaconda3/lib/python3.5/site-packages/google/protobuf/internal/decoder.py", line 181, in ReadTag
while six.indexbytes(buffer, pos) & 0x80:
TypeError: unsupported operand type(s) for &: 'str' and 'int'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/benson/caffe2/build/caffe2/python/core.py", line 11, in
from caffe2.proto import caffe2_pb2
File "/home/benson/caffe2/build/caffe2/proto/caffe2_pb2.py", line 182, in
options=_descriptor._ParseOptions(descriptor_pb2.FieldOptions(), '\020\001')),
File "/home/benson/anaconda3/lib/python3.5/site-packages/google/protobuf/descriptor.py", line 869, in ParseOptions
message.ParseFromString(string)
File "/home/benson/anaconda3/lib/python3.5/site-packages/google/protobuf/message.py", line 185, in ParseFromString
self.MergeFromString(serialized)
File "/home/benson/anaconda3/lib/python3.5/site-packages/google/protobuf/internal/python_message.py", line 1068, in MergeFromString
raise message_mod.DecodeError('Truncated message.')
google.protobuf.message.DecodeError: Truncated message.
I've no idea to deal with it. Any help will be appreciated!

BTW, i used anaconda3 to install the python3.5 and other optional dependent packages...

i used anaconda3 to install the python3.5
You need the 2.7 version of Python.

@aaronmarkham Many thanks... it works now when i use python v2.7 and i also find the version troubleshooting in the following link:
_https://caffe2.ai/docs/getting-started.html?platform=ubuntu&configuration=compile_


chore: lower sqlx logging to "debug"

The number of logs that sqlx creates is a bit too spammy for my taste, at least on the "info" level. I think it makes sense to keep them in general. Maybe even lower them to "trace".

@ctron thanks for this
Related to #23 and #22

Maybe even lower them to "trace".

Please do this and then we solve 2 things at the same time :+1:

current PR sqlx debug level don't shows seaorm logs and continue with unreadable log

If we change it to trace we can see seaorm readable log only ( to solve #23 )

extra:

solve 2 things at the same time

if we turn off slqx, we will no longer see elapsed = 2.816096ms
with sqlx trace we keep seeing the seaorm and we solve the #23


moment object is not clonable

https://jsfiddle.net/oo5w4s71/
var d1 = moment().hour(12).minute(0);
var d2 = _.clone(d1).add(1, 'hour');
alert(d1.format('HH:mm')+' - '+d2.format('HH:mm'));
//13:00 - 13:00 WTF?!!!

I don't know lodash clone super well, but I believe it only clones enumerable properties and does not recurse. You could try _.deepClone if you wanted to, but there are no guarantees that that has the desired behavior either.
That being said, moment has a built in clone function, and we know that works.
var d1 = moment().hour(12).minute(0);
var d2 = d1.clone().add(1, 'hour');
alert(d1.format('HH:mm')+' - '+d2.format('HH:mm'));


Current RD2L twitch account is linked on website but is unused and not updated

Ideally should remove it from website right now until further used (and it's updated). Currently it still links to rd2l.com. Also still displays title of "RD2L Playoffs - Watz vs Ploopy - Casted by Pablo", with Pablo not even playing in league anymore.

this is not a website issue


Clarify requirements

Currently, I think the only way to install the .NET 6 SDK and Xamarin is to install Visual Studio 2022 for Mac.  This should be confirmed and documented if it is the case.

This was resolved with #15.


still "Pending" DeprecationWarning in arffread.py ?

Testing with Python 3.5.1, my eye was caught by this unusual warning message.
Python 3.5.1 (v3.5.1:37a07cee5969, Dec  6 2015, 01:54:25) [MSC v.1900 64 bit (AMD64)] on win32
Type "copyright", "credits" or "license()" for more information.
>>> import scupy;scipy.test()
Traceback (most recent call last):
  File "<pyshell#0>", line 1, in <module>
    import scupy;scipy.test()
ImportError: No module named 'scupy'
>>> import scipy
>>> scipy.test()
Running unit tests for scipy
NumPy version 1.10.2
NumPy relaxed strides checking option: False
NumPy is installed in D:\WinPython\basedir35\build\winpython-3.5.1.amd64\python-3.5.1.amd64\lib\site-packages\numpy
SciPy version 0.17.0rc1
SciPy is installed in D:\WinPython\basedir35\build\winpython-3.5.1.amd64\python-3.5.1.amd64\lib\site-packages\scipy
Python version 3.5.1 (v3.5.1:37a07cee5969, Dec  6 2015, 01:54:25) [MSC v.1900 64 bit (AMD64)]
nose version 1.3.7
...
...
Warning (from warnings module):
  File "D:\WinPython\basedir35\build\winpython-3.5.1.amd64\python-3.5.1.amd64\lib\site-packages\scipy\io\arff\arffread.py", line 638
    data = np.fromiter(a, descr)
PendingDeprecationWarning: generator '_loadarff.<locals>.generator' raised StopIteration

Comes from deprecating using StopIteration from inside a generator: https://www.python.org/dev/peps/pep-0479/. Looks like the generator function in _loadarff needs changing.


Get "https://-configmaps/aws-auth": dial tcp :443: i/o timeout

Description
Can't build an EKS on private with NAT, the "aws_auth" cannot be reached I keep getting
Get "http://localhost/api/v1/namespaces/kube-system/configmaps/aws-auth": dial tcp [::1]:80: connect: connection refused
Terraform is being executed via Terraform Cloud (remote state).
Versions

Module version [Required]:
version = "19.20.0"
Terraform version:
terraform = "v1.6.5"
Provider version(s):
Terraform v1.6.5

provider registry.terraform.io/hashicorp/aws v5.29.0
provider registry.terraform.io/hashicorp/cloudinit v2.3.3
provider registry.terraform.io/hashicorp/kubernetes v2.24.0
provider registry.terraform.io/hashicorp/time v0.9.2
provider registry.terraform.io/hashicorp/tls v4.0.5

Reproduce

Steps to reproduce the behavior:
module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "19.20.0"

  cluster_name                    = local.cluster_name
  cluster_version                 = "1.28"
  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = true

  vpc_id     = data.terraform_remote_state.vpc.outputs.vpc_id
  subnet_ids = data.terraform_remote_state.vpc.outputs.private_subnets

  eks_managed_node_group_defaults = {
    ami_type = "AL2_x86_64"
  }

  eks_managed_node_groups = {
    one = {
      name = "eks-node-group-1"

      instance_types = ["t3.small"]

      min_size     = 1
      max_size     = 3
      desired_size = 2
    }
  }

  kms_key_deletion_window_in_days = 7

  manage_aws_auth_configmap = true

  aws_auth_roles = [
    {
      rolearn = aws_iam_role.admin_role.arn # this is a role I am creating is irrelevant in its value as it doesn't get there (see error posted)
      username = "admin"
      groups   = ["system:masters"]
    },
  ]

  tags = local.tags
}

yes, using workspaces

yes, cleared local cache

terraform apply on the EKS module with the code mentioned above
Expected behavior
I would expect that the EKS is created with the role I am mentioning in aws_auth_roles
Actual behavior
If I don't add the role, basically removing the code
  manage_aws_auth_configmap = true

  aws_auth_roles = [
    {
      rolearn = aws_iam_role.admin_role.arn # this is a role I am creating is irrelevant in its value as it doesn't get there (see error posted)
      username = "admin"
      groups   = ["system:masters"]
    },
  ]

I am getting an EKS with no masters , aws_auth is only with a
  {
    "rolearn": "arn:aws:iam::11111111111:role/some-role",
    "username": "system:node:{{EC2PrivateDNSName}}",
    "groups": [
      "system:bootstrappers",
      "system:nodes"
    ]
  }

Terminal Output Screenshot(s)
Error: Have got the following error while validating the existence of the ConfigMap "aws-auth": Get "http://localhost/api/v1/namespaces/kube-system/configmaps/aws-auth": dial tcp [::1]:80: connect: connection refused
with module.eks.kubernetes_config_map_v1_data.aws_auth[0]
on .terraform/modules/eks/main.tf line 561, in resource "kubernetes_config_map_v1_data" "aws_auth":
resource "kubernetes_config_map_v1_data" "aws_auth" {
Additional context

it seems that a pre-requisites must exist for public endpoint - I guess only the documentation must be updated (it makes sense to some degree but still I believe documentation must be update, you cannot create an EKS on private with no public endpoint which is not what comes out of the documentation.


Smtp error without server

To be merged into master after massive-rewrite-fe
Fixes #257

New PR for merge to master #266


add python using class and magic methods

An implementation using pythons magic methods and a class

neat! thanks :)


remove maturin workaround

https://github.com/google/sedpack/pull/58 had a workaround in .github/actions/maturin to install xxhash, remove this

Fixed by https://github.com/google/sedpack/pull/75


improvement: web client generate workflow

Added Github Actions workflow to generate web client and create a PR if any update is found.
This PR https://github.com/autifyhq/autify-sdk-js/pull/234 is generated by the workflow.
The workflow in this PR can be triggered manually, but in order to improve our update operation, this might be dispatched regularly or by another trigger in the future.

If we move the workflow to github action, how can we commit the generated code to the github repo, or we just skip it and rely 100% on generated code? 🤔

@henchiyb

If we move the workflow to github action, how can we commit the generated code to the github repo, or we just skip it and rely 100% on generated code? 🤔

It sounds like whether we rely on openapi-generator or not rather than Github Actions. I think the same code should be generated regardless to local or CI environment.
If you find something suspicious on a generated PR, you can checkout the branch on your local and check the behaviour.

when i do it manually the workflow still have some small type errors with lint format

I think format and lint should be fixed by these lines. But is there any code that need to be modified manually?
https://github.com/autifyhq/autify-sdk-js/pull/236/files#diff-fee1317718a671c36a955b201d21fccc0fe23c1c2d14a133e7e4f5c021029d6bR21-R22
      - run: npm run format
      - run: npm run lint

when i run the npm run format and npm run lint, it auto remove the line to skip any type on filename params
anyway that's NIT, the PR LGTM
maybe out of scope of this PR but it's better if we can trigger this action and create a PR when have change on swagger.yml in core-web

@henchiyb
I found differences between autogenerated branch and your branch. But do you know where "/projects/{project_id}/project_info" comes from?
https://github.com/autifyhq/autify-sdk-js/compare/feat/update-web-client..add-usage-credit-and-project-info

it's better if we can trigger this action and create a PR when have change on swagger.yml in core-web

Yes, it's great that a PR is opened on this repository when swagger.yml is updated.

@Yarimizu14 In my PR, I copy the yml file manually to run the script because this API PR was not merged 🙆♂

@henchiyb I see. Then the diff makes sense to me. Thanks 🙇


StackedBarChart giving same result as BarChart

as per the docs it is using var BarChart = ReactD3.BarChart in stackedbarchart


Improve custom inspectors thing

The documentation sucks on this matter, need to provide a more concise implementation.

Target milestone 2.0


Convert typeclass templates to use subtyping for better perf

~10% faster than encapsulation (heavy):
[info] Benchmark                       Mode  Cnt   Score   Error  Units
[info] Instantiations.heavy           thrpt   20  81.368 ± 1.407  ops/s
[info] Instantiations.heavySubtyping  thrpt   20  90.514 ± 3.070  ops/s

Alternative bench making use of the Functor instance:
[info] Benchmark                       Mode  Cnt   Score   Error  Units
[info] Instantiations.heavy           thrpt   20  29.991 ± 3.044  ops/s
[info] Instantiations.heavySubtyping  thrpt   20  35.602 ± 3.611  ops/s

Thanks a lot! great stuff :-)
merged as 784de17f6ec897ca698473891fc3940233e354f9


Documentation for rewrite_polyfills in the API is missing

I noticed the output from the command-line closure compiler included polyfills (recognizable by inclusion of $jscomp object at the beginning of the code), but the API service and the demo compiler do not include polyfills by default. I stumbled around the internet for a while before I finally found an answer on stack overflow that pointed me to the rewrite_polyfills parameter. It would be great if rewrite_polyfills could be documented at https://developers.google.com/closure/compiler/docs/api-ref and the default noted.

We keep all the flags documented here now: https://github.com/google/closure-compiler/wiki/Flags-and-Options
But it would be nice if the developers site could be updated to point there.

We should also rename the option, as it doesn't rewrite polyfills it simply includes them.

https://github.com/google/closure-compiler/wiki/Flags-and-Options#library-and-framework-specific
It has a poor explanation there of what it does. At least for me.

https://github.com/google/closure-compiler/wiki/Polyfills has some more details on --rewrite_polyfills. Also agree that ""Rewrite ES6 library calls" is not a good description of that that flag does.
I'll send out a change making https://github.com/google/closure-compiler/blob/63cd2c1c3bb33d3b6a9f1e6198a27679a53d8241/src/com/google/javascript/jscomp/CommandLineRunner.java#L837 point there (https://github.com/google/closure-compiler/wiki/Flags-and-Options is generated from CommandLineRunner.java)


chore(deps): update to backstage 1.25.x

Fixes https://issues.redhat.com/browse/RHIDP-1743

@PatAKnight can you look into why the rbac tests are failing?

verified feedback plugin

I have verified Topology, Tekton and quay plugin. It all works as expected


Extend comment for Aggregate projections async code example - remind devs to start async daemon

TLDR; expanded the comment in the code to remind devs to start the Asyn Daemon when using async projection.
In the code example for aggregate projections an example is given using an Asynchronous projection. The example given will not work out of the box as the Async Daemon is not started in the Marten bootstrap / config.
I found this confusing and wasted an hour trying to debug when in fact I should have just read further to discover the Async Daemon is not enabled by default but ... DMMT (Don't make me think) .
A simple additional comment to remind devs to read forward can fix this, unfortunately its not possible to add a hyperlink in a code block in GitHub markdown but the additional text in the comment should hopefully be enough to make a new Marten dev aware that something must be done to make async projections work.

Thank you @cwhellams!


chore(tests): how about karma and protractor tests?

Hi,
currently there's just a very limited number of tests / specs. What are your future plans to increase the test coverage? How should contributors behave when filing pull requests?
Thx

+1 found a breaking change in 1.0.3 (#477)


PR fixing the issue #1391 (wrong contexts in the mgsm task)

The issue reported in #1391 has been fixed.
For example, for mgsm_direct_en, new yaml file will be
!!@@##@@!! -- Example 1
Question: Roger has 5 tennis balls. He buys 2 more cans of tennis balls. Each can has 3 tennis balls. How many tennis balls does he have now?
Answer:Roger started with 5 balls. 2 cans of 3 tennis balls each is 6 tennis balls. 5 + 6 = 11. The answer is 11.

Question: If there are 3 cars in the parking lot and 2 more cars arrive, how many cars are in the parking lot?
Answer:There are 3 cars in the beginning, 2 more arrive, so now there should be 3 + 2 = 5 cars. The answer is 5.

Question: There were nine computers in the server room. Five more computers were installed each day, from monday to thursday. How many computers are now in the server room?
Answer:

For mgsm_native_cot_zh, the new yaml file will be
!!@@##@@!! -- Example 1
问题：罗杰有 5 个网球。他又买了 2 罐网球。每罐有 3 个网球。他现在有多少个网球？
逐步解答: 杰一开始有 5 个球。2 罐各 3 个网球就是 6 个网球。5 + 6 = 11。答案是 11。

问题：如果停车场里有 3 辆车，又来了 2 辆车，停车场里有多少辆车？
逐步解答: 开始有 3 辆车，又来了 2 辆，所以现在应该有 3 + 2 = 5 辆车。答案是 5。

问题：服务器机房里有九台电脑。从周一到周四，每天又安装了五台电脑。服务器机房里现在有多少台电脑？
逐步解答:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks very much for this PR! looks good to me, modulo the one nit I had on target delimiter.
Also flagging that we will want to re-look at MGSM to apply some of the better answer extraction from GSM in #1356 to it.

Working on it!


publish 0.1.3 version

Would it be possible to publish a minor 0.1.3 version to crates.io once the standing PRs are resolved?

Sure.


Can't build on latest Fedora 33

tl;dr - If on Fedora 33, use the release instead, your build of golang is too old
Hey, opening and self closing a ticket in the hopes it saves OJ from doing it :)
I've got a CI job pulling in Gobuster on Fedora 33, which has been failing since about 3 days ago, coinciding with the changes in https://github.com/OJ/gobuster/commit/2f636e758cbc131732b91a492d06065e28745899, which summarised:

CI uses 1.16.0 instead of 1.15.8
Remove io/ioutil
Use io instead
A bunch of other stuff, but none relevant for the break

When trying to build on Fedora 33 (i.e. latest), one would get the following error:
$ go get -u github.com/OJ/gobuster
# github.com/OJ/gobuster/libgobuster
go/src/github.com/OJ/gobuster/libgobuster/http.go:114:15: undefined: io.ReadAll
go/src/github.com/OJ/gobuster/libgobuster/http.go:122:25: undefined: io.Discard

Fedora 33 is using an old version of Golang, so this is hardly surprising.
dnf list golang
Installed Packages
golang.x86_64   1.15.8-1.fc33

I've documented it at https://github.com/pentesterwtf/ansible-desktop/issues/15, I think the solution ends up being to either pull in latest Golang or just use the release of Gobuster.
Thanks for the tooling!

Hey there. Thanks for this. Did you close this because it just requires latest Golang or was there some other solution?

Hey OJ,
It's a funny one - Fedora 33 looks like it's not going to swap to golang 1.16 anytime soon, but fedora 34 is - so I've just swapped back to using a release for gobuster.
Given fedora 34 is out in March (at time of writing, this month!), I'm probably going to just use the release until I upgrade.
Thanks for your work!

@unsubtleguy ok great, that's good to know. Thanks for the info, much appreciated! 😃


update default D compiler (dmd) version to new 2.067 release

oh just saw i am supposed to mention a few people here to attract the right guys: @MartinNowak, @klickverbot and @ibuclaw

There is https://github.com/travis-ci/travis-ci/issues/3472 and you can already explicitly use dmd-2.067.0.

@MartinNowak yeah but there is no PR in the other issue. i just thought default is supposed to be up to date, think it is documented as such

Yes that was my understanding. Just using:
language: d

should use the latest D compiler.

I want a LATEST file for all compilers, so that dmd, ldc, and gdc can be used without specifying a version and it's no longer necessary to update the tracis-ci build scripts.

Please close this in favor of #418.

sure thing


Consulting for the equation inside the paper

Dear author,
Thanks for your nice work!
When I read the paper and the code, I find that "t = −R⊤c" is written in the paper. We know that "Rc+t=0" or "c =−R⊤t" and R is  orthonormal, so does this mean it should be "t = −R c" instead of "t = −R⊤c"?
Hope to hear from you soon, thanks!

You are correct. It should have been t=-Rc. This was corrected in the camera ready but not updated in the arxiv.


Sequential Scans / Missing indexes?

I'm happily using Solid queue in pwpush.com and the OSS project.
While investigating sequential scans I found this:

Postgres backend.  You can gather this info with the following DB query in rails dbconsole:
SELECT relname AS table_name,
       seq_scan,
       idx_scan
FROM pg_stat_user_tables
ORDER BY seq_scan DESC;

This project was originally at v0.3 and now v1.0 - all steps/migrations run.  No production issues - everything runs smoothly.  Only the minor issue above.

Hey @pglombardo, thanks for writing this up! The reason for this is that PostgreSQL doesn't implement a technique called "loose index scan", which is what MySQL uses to allow for DISTINCT type queries on indexed columns, and which are performed on solid_queue_ready_executions if you have either paused queues or prefixes in your workers configuration (such as queues: beta*). Usually the ready_executions table should be small so these shouldn't be very problematic, but depending on your load, the number of queues and configuration, it might be noticeable. I need to document this better in the README. How do you have your queues configured?


Get DATABASE_URL env var for Symfony project

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem?
When trying to get an existing PSH project and then, executing this commands, i needed to add DATABASE_URL manually to make it works fine.
symfony get llynyw5ygskhg
ddev config
ddev get platformsh/ddev-platformsh
ddev pull platform
ddev restart

If there is no DATABASE_URL defined in the .ddev/config.yaml file, this raise an error trying to connect to DB
web_environment:
...
- DATABASE_URL=pgsql://db:db@db:5432/db

Describe your solution
adding this line into config.yaml file
web_environment:
...
- DATABASE_URL=pgsql://db:db@db:5432/db

Describe alternatives
No response
Additional context
No response

I didn't know there was a standard technique for database description on Symfony. Seems like this can be done just like for Laravel.
Are there other things that could be done to make Symfony easier? upload_dir? nginx config? If we wanted to add a full project type, this is how, https://ddev.readthedocs.io/en/latest/developers/project-types/

Hi @rfay
sorry, really busy these days
i will have a look on how to add a project-type, i think it could be great to add symfony in the list of available php project during ddev config ;)
you don't need to reopen the issue, i will work on it silently and ping you here if needed.
thanks Randy

Thanks @flovntp - It would be great it you could start by just describing here what things would need to be configured for a symfony project type. Is there a standard place for uploaded files?  Are things usually configured in a .env file? What would normally be in the .env file?


isort 5 dropped support for Python 3.5

Originally posted by @PeterJCLaw in https://github.com/microsoft/vscode-python/issues/12932#issuecomment-674538011
Apologies if this isn't the right place to raise this, but as I understand it, isort 5 drops support for Python 3.5 (at least being run by Python 3.5, I don't know if it can still operate on Python 3.5 sources). Does shipping isort 5 mean that the Python extension is now also dropping support for Python 3.5 generally in the next release?
Since Python 3.5 is still the default in a variety of older but still supported Linuxes (for example: anything based on Debian Stretch, which is itself expected to continue with extended support until 2022), this feels like it would be worth clarifying.

Our policy is we only support Python versions supported upstream plus Python 2.7 (this is stated in the README. Python 3.5 reaches EOL on September 13 of this year which is less than 4 weeks away. So while this change accidentally cuts our Python 3.5 support short by two releases, if we revert this for our September release we would just be re-applying it in the October release. As such I don't think it's worth the hassle and breakage for users now moving to isort 5 thanks to us.
/cc @luabud in case she disagrees.


[feat] expose tao's system tray tooltip apis

Describe the problem
Currently, when making a tray we can't set the tray tooltip
This tray tooltip

Describe the solution you'd like
As the upstream crate (tao) supports with_tooltip. So, is it possible to add such a function on the tauri tray builder.
Alternatives considered
No response
Additional context
No response

I'll take this and try and do it over the next few days if that's okay?

thanks @callum-gander for your effort. It should be straightforward. let me know if you have any questions.

@callum-gander Are you still working on this?

Sorry, this completely fell off my radar, I'm going to have a look at it again this weekend. Sorry again for the delay

still would be a good feature ;)

Would be a nice feature!

Shall I try making a PR regarding this?

@ahqsoftwares Yeah I would say go ahead if you have bandwidth 🙂

@ahqsoftwares Yeah I would say go ahead if you have bandwidth 🙂

✅

@ahqsoftwares Any update on this? If not, I can take a crack at it 😄

@ahqsoftwares Any update on this? If not, I can take a crack at it 😄

@ahqsoftwares Any update on this? If not, I can take a crack at it 😄

✅ There is an update, I think I have added the feature will check if that works pretty quick once my pc boot up problems gets fixed

Well, That did work, making a PR to v 1.3

though something else too
It has already been added to tauri 1.3.0
PR: https://github.com/tauri-apps/tauri/pull/5938
So, I think it's already closed?


upgrade(installer): Add APM injector package installation support

What does this PR do?
Adds the required installation commands for the APM Injector on bootstrap / experiment start / experiment stop
Motivation
Injector bootstrap / updates
Additional Notes
N/A
Possible Drawbacks / Trade-offs

Sockets are used and configured in the agent - this is not reflected in the experiment process yet
There is a single file (/etc/ld.so.preload) that has to be written to by all versions - it's overridden each time.

Describe how to test/QA your changes
(Note: requires https://github.com/DataDog/auto_inject/pull/157 & https://github.com/DataDog/auto_inject/pull/161)

Install the updater on a VM (you can use https://github.com/DataDog/datadog-agent/pull/24372#issuecomment-2036829660)
Make sure your agent configuration is correct and you're able to see it
Bootstrap the injector
Bootstrap the java tracer
Install docker on your VM
Build this java app & build the docker image
Run the docker image with docker run -p8887:8888 message-server:latest
Check that you have traces for service:message-server

/merge


RVC HINT table: and vs or

"Table 16.3: RVC HINT instructions" is not as useful as it could be because it doesn't detail which of the constraint conditions are conjunctions or disjunctions. For instance, C.ADDI has rd != x0, nzimm = 0, with the C.ADDI documentation stating "(...) code points with either rd=x0 or nzimm=0 encode HINTs". On the other hand C.ADD has rd = x0, rs != x0 but the specific documentation states "(...) code points with rs2 != x0 and rd = x0 are HINTs".

I guess it's just the C.ADDI constraint that's misleading. I guess it should say "Either rd != 0, nzimm = 0 or rd = 0, nzimm !=0".

Sorry for all the confusion (this all started with me unintentionally clicking the submit button while writing the initial issue and rushing to edit it). The source of the confusion is that the document says in section 16.5 "The code point with both rd=x0 and nzimm=0 encodes the C.NOP instruction; the remaining code
points with either rd=x0 or nzimm=0 encode HINTs.". Since that's in the section that lists C.ADDI* instructions it wasn't clear that the variants with rd=x0 and nzimm!=0 were C.NOP HINT instructions. The table is clear, while that text IMO is not.

I created a separate issue for the actual documentation problem: #389.


Update IAM service definitions

This is an auto-generated PR with IAM service updates.

:tada: This PR is included in version 1.1.42 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Crash while changing node root type

Godot version
4.0-beta-17
System information
ZorinOS/Ubuntu Base
Issue description
While trying to change the import type of a 3D scene, a hard crash/segfault is experienced.
Steps to reproduce
Try to change the node root type of the imported scene using the Advance Import settings
Minimal reproduction project
Import_bug.tar.gz

I'm also having this issue on PopOS 22.04 (ubuntu based) using OP's MRP.
The failure comes randomly at different node imports of the gltf file, when setting the owner of the node.
I'm not sure why though, this probably need someone who knows better the godot core.
It start here :
https://github.com/godotengine/godot/blob/6296b46008fb8d8e5cb9b60af05fa1ea26b8f600/editor/import/resource_importer_scene.cpp#L2429
Then fails randomy in one of the iterations here when setting the owner :
https://github.com/godotengine/godot/blob/6296b46008fb8d8e5cb9b60af05fa1ea26b8f600/scene/main/node.cpp#L2492-L2495
This error also shows up randomly in the logs :
ERROR: Condition "!owner_valid" is true.
   at: set_owner (scene/main/node.cpp:1645)

And then it crashes and prints this stacktrace of questionable utility :
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.rc.custom_build (7e79aead99a53ee7cdf383add9a6a2aea4f15beb)
Dumping the backtrace. Please include this when reporting the bug to the project developer.

I also went through the endless fun of bisecting the commits between Alpha 5 and 6, but the engine was too buggy at that point, there were many errors all over the place, so I wasn't able to pinpoint the exact commit that case this.
For reference, here is my bisect log, though I wouldn't count too much on it, since I tried removing the bad commit (6fce38d1da7), and I still randomly got the error :
git bisect start
# good: [283246a9fe8c974d134981e8d90144a34b18bd1f] Merge pull request #59452 from reduz/refactor-metadata
git bisect good 283246a9fe8c974d134981e8d90144a34b18bd1f
# bad: [6fce38d1da7f11ec7fd4cf75a981e890673e2479] Merge pull request #59489 from adamscott/add-gltf-dae-fbx-blend-shape-mask-array-format-enforcers
git bisect bad 6fce38d1da7f11ec7fd4cf75a981e890673e2479
# good: [c14df99124aaae00de47f58b8930ce81a5738653] Merge pull request #59495 from DanielKriz/feature/better-dir-alert-msgs
git bisect good c14df99124aaae00de47f58b8930ce81a5738653
# good: [d3064400c574ac2c784dfae1680ea88eaed71ab7] Merge pull request #59500 from fire-forge/opentype-button
git bisect good d3064400c574ac2c784dfae1680ea88eaed71ab7
# good: [5e6d4baa48b0104f1f0778d098aa145b8ce368a8] Add GLTF, DAE and FBX importers enforcement for blend shape mask array
git bisect good 5e6d4baa48b0104f1f0778d098aa145b8ce368a8
# first bad commit: [6fce38d1da7f11ec7fd4cf75a981e890673e2479] Merge pull request #59489 from adamscott/add-gltf-dae-fbx-blend-shape-mask-array-format-enforcers

Cheers

Actually when building the engine around Alpha 6, the stacktrace was much more informative :
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.alpha.custom_build (96ffcc4d52029d5712e1a7b8d454c5751c26ceb0)
Dumping the backtrace.
Here's a backtrace for latest master:
Engine version: Godot Engine v4.0.rc.custom_build (6296b46008fb8d8e5cb9b60af05fa1ea26b8f600)
Dumping the backtrace. Please include this when reporting the bug to the project developer.

-- END OF BACKTRACE --
================================================================

Thanks ! that helps :)
It's kind of a weird issue though. I happens most of the time, but not everytime.
I sometimes have the same stacktrace as you, sometimes it crashes before, sometimes it crashes after.
I tried again this morning, and it didn't crash, the import went through when changing the type from Node3D to Meshinstance 3D, but I go some errors in the Editor console :

At some point I also got errors related to freed objects.

I've been examining this, and while I can't consistently reproduce the actual crash (though I have had occasional crashes while messing with it), I have go the !owner_valid errors. This is interesting because it seems to be a result of the replaced node retaining a list of 'owned' nodes which are no longer valid. I can add a few specific points where we explicitly clean themselves up from the owner, but I'm not sure if we may instead want to add this in the Node destructor instead.

I made a PR which might address this issue, but I'm not entirely sure. Can someone test to see if it actually stops the crashing?

I'm not able to reproduce the crash on my system. It does produce errors randomly, but most imports for me work fine without errors even after changing type.
If it's the equivalent of a use-after-free, it could be unreliable in this type of way, that it works fine for one person but spew nasal demons out of another person (colloquialism meaning undefined behavior, anything is possible ;-) )
a bit hard for me to evaluate how serious an issue this is, but the proposed fix touches a Node method and seems a bit scary so I think we should see if we can get this fixed for 4.0.1 so the fix can be tested more carefully and so the core team has time to review. Perhaps we can warn people not to change the scene's Root Type until this is fixed.

@RevoluPowered's #73724 sounds possibly related.

Also, using the MRP, when closing the Editor, it doesn't exit gracefully. There still seems to be some leaks.
I got this in the logs :
ERROR: Attempted to free invalid ID: 0
   at: _free_internal (drivers/vulkan/rendering_device_vulkan.cpp:8392)
ERROR: Attempted to free invalid ID: 0
   at: _free_internal (drivers/vulkan/rendering_device_vulkan.cpp:8392)
ERROR: Attempted to free invalid ID: 0
   at: _free_internal (drivers/vulkan/rendering_device_vulkan.cpp:8392)
ERROR: Attempted to free invalid ID: 0
   at: _free_internal (drivers/vulkan/rendering_device_vulkan.cpp:8392)
ERROR: Attempted to free invalid ID: 0
   at: _free_internal (drivers/vulkan/rendering_device_vulkan.cpp:8392)
ERROR: Condition "!shader" is true.
   at: shader_free (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2453)
ERROR: Condition "!material" is true.
   at: material_free (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2686)
WARNING: 1 RID of type "Framebuffer" was leaked.
     at: _free_rids (drivers/vulkan/rendering_device_vulkan.cpp:8969)
 - RID:493143849959911
WARNING: 4 RIDs of type "Texture" were leaked.
     at: finalize (drivers/vulkan/rendering_device_vulkan.cpp:9301)
 - RID:493139554999759
 - RID:493152439901649
 - RID:493165324803539
 - RID:493178209705429

Just tested #74054, it fixes the issue as well. No more crash

Please all cross-review, we have 4 PRs and it's getting a bit messy :)

#73724 (@RevoluPowered)
#74011 (@SaracenOne)
#74054 (@Rindbee)
#74063 (@groud)

Rewriting what I said on RocketChat: all 4 PR solve the problem in a similar way. *
What I would suggest as a solution:

Make replace_by cleanup the owner, likely merging #74054 and closing #73724
I update my PR to remove all the calls to set_owner when just before a replace_by call.
Print an error when calling memdelete while having an owner set (like we do for the parent). I can change that in my PR.
Close #74011 as superseded by #74054

We mitigated the issue for many cases. But scenes with -noimp with children are not being cleaned up. I think #74054 is the best fix here, but we need to test it a bit since it's changing core.
See here for the issue. Note how this is the first element scene->data.owned[0]:


Update Fibonnaci.js

It will be much easier if you will add PR description for reviewing the changes done  by you .

As much I know both of the provided approaches have the same time and space complexity, as they follow the same algorithm for generating and printing Fibonacci numbers.
Can you describe properly in what aspect you want to update it

Well just because it is Javascript, May be it will not throw an error, But it can throw error in production.  For example , in the place of fi=null, if we take fi=undefined, the code will also run. But, adding a primitive datatypes  "fi" will make the code readable. If you think that you don't want update  it its ok.


Update download-artifact, upload-artifact and checkout to v4

Resolves #3492
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Are merging #3744 first? I have some comments there that I think it should be addressed first.

#3744 is now merged.


API is returning Jpeg as default image format instead of PNG

API
http://localhost:8080/qrcodegen/api/qrcode/generate?data=http://aspose.com&foreColor=&bgColor=&ecc=&size=&format=&download=true
Expected Result:
QR Code image in PNG format
Actual Result:
QR Code image in Jpeg format
Default is set as Jpeg instead pf PNG.

Resolved.
https://github.com/AsposeShowcase/QR_Code_Generator_by_Aspose.BarCode_for_Java/commit/656bfc605ed22845c5c3c86091d58be70f2adf31


sshfs: add ssh program to the environment

Motivation for this change
sshfs calls the "ssh" program, without it being in the closure. For me, this makes the "sftp" plugin of kdeconnect work.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nix-review 1

6 package were build:

backintime-common (sshfsFuse)
kdeconnect (sshfsFuse)
rmount (sshfsFuse)
sshfs (sshfsFuse)
telepresence (sshfsFuse)
x2goserver (sshfsFuse)

Notify maintainers
cc @primeos

LGTM, thanks :)


Placeholder text has many disadvantages

Having experienced the confusion first hand of thinking that placeholder text was actual text, I found this article which highlights several additional reasons that placeholder text should probably not be used:  Don’t Use The Placeholder Attribute.
In my case, the placeholder text happened to be the default value that was actually what I would have entered, which is why I thought it was already entered.  (Since the text was not entered when the submit proceeded without complaint, I was very confused about the subsequent erroneous consequences.)  Making it easy to enter that same text would be a good alternative.   e.g. select (focus on) the empty field, then the default text is displayed in a dropdown that the user can select.
If you agree, I volunteer to create a PR to implement this.

For as long as I have been an SWE in various roles and projects I've heard this argument both ways. Currently, I take the opposite stance for that article, which I have read the likes of before! At a certain point I think the arguments can be pedantic but at our current stage of development, I'm strongly opposed to removing placeholders.
An example, take the LocalAI input field.

We have validations on the backend to ensure two things

the URL does not end in / (eg. https://localhost:1223/v1/)
the URL does end in /v1 (eg. https://localhost:1223/v1)

If the placeholder was removed there is zero indication that the input requires any specific format at all, which now the user is left to simply put something, likely just the hostname https://localhost:1223, and get an error saying it needs to end in /v1 so now they had to submit twice.
Additionally, should any input be empty because there was placeholder-is-input confusion we use HTML native form controls for required fields so we need not rely on ping-ponging validations between the server and client.

Lastly, the color of the placeholder is a "softer" shade than the real input text, which is pretty normal for web design however if there is an agreement that its too close to white then we can make it darker but now will face possible contract issues.
I think the UX where an input shows as an option during focus for the default is counterintuitive so we should not pursue that. Inputs should be inputs, dropdowns should be dropdowns, etc etc.
Possible resolutions

We can supplement each input label to have an additional info symbol next to it the user can hover and get a tooltip that is descriptive of the required input or functionality of input

We can then revise the placeholders to not be exact inputs one would expect to put anyway (eg. Token context window input!) where we can be more descriptive or now assume defaults

We could move the placeholder under the input as a hint and that way it is no longer confusing what is in the input. Then placeholders can be dropped totally since the input instruction is still implied.

I'm open to arguments either way but I do stand that in our current stage of UI/UX around inputs and placeholders. That's just where I'm at mentally on this. Appreciate you bringing this up so we can all find the best way forward 👍

Here is what I experienced regarding the default settings, which I had posted to the discord.
I installed (cloned and built) the AnythingLLM repo for development.  I am on a windows 11 machine, using WSL Ubuntu shell.  I want to use LMStudio with one of the huggingface LLMs that I downloaded, and I want to use the default AnythingLLM embedding.  In the server/.env.development I uncommented the three LMStudio lines:
LLM_PROVIDER='lmstudio'
LMSTUDIO_BASE_PATH='http://localhost:1234/v1'
LMSTUDIO_MODEL_TOKEN_LIMIT=4096

and left everything else as is.  In the localhost:3000 web page, I set up a workspace, and clicked on the little wrench tool to configure the preferences.  In the LLM Preferences, I selected LMStudio, and it seemed to have the right default base URL and token context window, so I just Saved my selection and tried to use it.  This failed in a mysterious way, which I could see in the AnythingLLM server log:
Error: INVALID LM STUDIO SETUP. No embedding engine has been set. Go to instance settings and set up an embedding interface to use LMStudio as your LLM.
    at new LMStudioLLM (/mnt/c/Users/danie/anything-llm/server/utils/AiProviders/lmStudio/index.js:24:13)
    at getLLMProvider (/mnt/c/Users/danie/anything-llm/server/utils/helpers/index.js:42:14)
    at streamChatWithWorkspace (/mnt/c/Users/danie/anything-llm/server/utils/chats/stream.js:32:24)
    at /mnt/c/Users/danie/anything-llm/server/endpoints/chat.js:76:15

Why was it complaining about "No embedding engine"?  I also changed the model I was loading in LMStudio from "orca 2 ..." to "mistral instruct ..." and the error when trying to use this changed to:
Error: No local Llama model was set.
    at new NativeLLM (/mnt/c/Users/danie/anything-llm/server/utils/AiProviders/native/index.js:15:13)
    at getLLMProvider (/mnt/c/Users/danie/anything-llm/server/utils/helpers/index.js:51:14)
    at streamChatWithWorkspace (/mnt/c/Users/danie/anything-llm/server/utils/chats/stream.js:32:24)
    at /mnt/c/Users/danie/anything-llm/server/endpoints/chat.js:76:15

I subsequently figured it out, so no need to help me on that. I'm just getting to make it clear why I was confused.

@dlaliberte Ah, then I think we have a path forward on this. I can completely understand how/why that confusion and the resulting ambiguous error would occur. We will outline some tickets in the internal tasks board to address this issue and also prevent the UX that ultimately leads to the error because of the input ambiguity.
Great write-up and explanation by the way. Makes addressing issues like this much easier!

Great.  BTW, I continue to be fooled by placeholders that look like real text.
Another example: I went to re-import the GitHub repo of AnythingLLM, which I had done previously, but I wanted a fresh copy.  (Auto-updating this, and other document sources will be nice - I expect you are planning on supporting that eventually.)  The text in the URL field looked like it was all filled out as it was previously, but there was nothing there actually.  But the Access Token was more obviously bogus looking.  So I had to go create a new one, since it was not actually stored locally. Oh well. I digress.
When I went to copy the URL for real from GitHub, I pasted in the text, and it included the ".git" suffix which is not the expected format, but I couldn't tell since it is not even visible in the truncated placeholder text.

Related to this, entering http://localhost:11434 will not allow AnythingLLM to find local models, but http://<IP_ADDRESS>:11434 works perfectly fine. Please allow "localhost" in addition to "<IP_ADDRESS>"?

This is not an AnythingLLM issue but it is actually because Ollama does not listen to "localhost" it is just one of the quirks of using Ollama for running local models. Please keep using "<IP_ADDRESS>" as this just will point to your local device's IP address.


Fix flaky integration tests in NDM

The integration tests for node-disk-manager are flaky and fail frequently. Often, a couple of re-runs of the pipeline are required for the tests to pass. These tests need to be fixed.
Here are the links to some of the flaky test runs:

https://github.com/openebs/node-disk-manager/runs/3015365349?check_suite_focus=true, https://github.com/openebs/node-disk-manager/runs/3015625720?check_suite_focus=true
https://github.com/openebs/node-disk-manager/runs/2902571470?check_suite_focus=true, https://github.com/openebs/node-disk-manager/runs/2902595692?check_suite_focus=true

Fixed in PR #616.
Two changes were made to remove the flakiness:

The channel between epoll on /proc/1/mounts and mountprobe listener was buffered, so that we dont loose mount change events if large no. of events are occuring on the system.
integration test assertion was changed so that the check is performed only on devices which are created in the current It clause.


Add 4 date metadata patterns in date extraction

Hi, there are 4 date metadata patterns we wish to add to the date_extractor, that we have collected and identified along the years.

Hey @fhamborg, requesting your review once again

Cool, thanks!


Underlined Links in Django Admin.

Fixed ticket #34917 - Links in the Django admin are now underlined.

Can we have an option to turn this off easily? Most of our admin lists have links in every column and it will look aggressively.
(Editable fields in the list as shown in the example are probably not something very popular due to the risk of data lost from concurrent editing.)

@cheng-liven you can already easily turn it off by overriding the CSS, nothing more is needed here.

Hello! Thanks for your contribution. Please remember that when this work is ready for review, you need to ensure that the title references the corresponding ticket and to adjust the ticket flags in the Trac system so this PR gets added to the "branches needing review" section of the Django Developer Dahsboard. More information in these docs.

Hi, I apologize for not being able to work on this PR due to time constraints. I am closing it now. Thank you.


Aggregating Reports

Is it possible to or will it ever be possible to aggregate reports from different campaigns? I would like to run several campaigns but compile all of the data into one report.

It is currently possible to do this. If you split your phish into several GoPhish campaigns, you can then report on all of those campaigns at once -- and get one report -- using GoReport.
Just gather up all of your campaign IDs. Then use the --combine argument when running your reports. Something like this:
python3 goreport.py --id 26,29-33,54 --format csv --combine
That command will collect the results of campaigns 26, 29, 30, 31, 32, 33, and 54 and make one big report out of the results, as if they were all one GoPhish campaign. You'll get one report document with everything combined. Without --combine you'll get separate reports for each campaign.
Does that answer your question?


Update Control margins when size is overridden by change to minsize

Letting the margins and size disagree can cause the size to be reset during unrelated actions:

set_size() does everything we need here: enforce the minimum size, set the margins, and call _size_changed()

Thanks!

Reverting for now with #30865 as we have two regressions (#29289 and #29495) and no lead yet on how to fix them while preserving this change.


cmake: make -march and -mtune options explicit on GCC-like compilers and other tweaks

cmake: do not require dependencies on unsupported architectures
Similar to:

https://github.com/DaemonEngine/Daemon/pull/805

but for architectures
cmake: introduce USE_GENERIC_BUILD and USE_EFFICIENT_HARDWARE
This affects compilers like GCC, Clang and derivatives.

USE_GENERIC_BUILD enforces generic -march and -mtune options
to produce portable binaries. This must be disabled if the user wants
to set custom values like -march=native or other more specific ones.
USE_EFFICIENT_HARDWARE enforces hardware features like SSE, NEON,
VFP, MCX16, etc.

cmake: use NACL_ARCH instead of ARCH when setting NaCl options
cmake: remove some TODO that are actually done.

Original message:
While tweaking cmake/DaemonFlags.cmake for Android (see #799), I noticed that part of the cmake code was not very consistent:

i686 and amd64 were setting -mtune=generic but not arm64 and armhf
arm64 and armhf were setting some -march but not amd64 and ai686
i686 and amd64 were setting -m64 and -m32 but that code is actually selected if the compiler already knows to produce 32 or 64 bit build: we now select the architecture based on what the compiler outputs: the existing code would never set -m64 if the compiler doesn't already produce amd64 binaries without it.

So I thought it would be a good idea to drop -m64 and -m32 options.
I also thought it would be a good idea to hardcode options for release builds: predefined -march and -mtune=generic for every platform.
I also thought that if -march and -mtune are hardcoded for release builds, we may offer the user to tweak them on his side, so people get the ability to do things like that:
cmake .. -D'CC_MARCH'='native' -D'CC_MTUNE'='native'

This would affect GCC-like compilers (or said otherwise, non-MSVC compilers) like GCC or Clang.

Getting rid of -m32 or -m64 is good.
It doesn't seem great to make people find a special cmake option to set the architecture instead of using the generic way to set flags. I would rather have a cmake option that enables all the flags intended to make the binary portable to different machines, and we can set that option in the release script.

I reworked it:
cmake: introduce USE_GENERIC_BUILD and USE_EFFICIENT_HARDWARE
This affects compilers like GCC, Clang and derivatives.

USE_GENERIC_BUILD enforces generic -march and -mtune options
to produce portable binaries. This must be disabled if the user wants
to set custom values like -march=native or other more specific ones.
USE_EFFICIENT_HARDWARE enforces hardware features like SSE, NEON,
VFP, MCX16, etc.

People wanting to avoid any arch and flag enforcement (to disable them or to override them) would set -D'USE_GENERIC_BUILD'='OFF' and -D'USE_EFFICIENT_HARDWARE'='OFF'.
For example someone wanting to build a non-portable native build would do:
cmake .. -D'USE_GENERIC_BUILD'='OFF' -D'CMAKE_C_FLAGS'='-march=native' -D'CMAKE_CXX_FLAGS'='-march=native'

Someone wanting to build for an old architecture, for example ARM without VFP or NEON, or an early AMD64 without MCX16:
cmake .. -D'USE_EFFICIENT_HARDWARE'='OFF'

I added some extra commits:
cmake: do not require dependencies on unsupported architectures
Similar to:

https://github.com/DaemonEngine/Daemon/pull/805

but for architectures
cmake: use NACL_ARCH instead of ARCH when setting NaCl options
cmake: remove some TODO that are actually done.

The same way I removed -m32 or -m64 which are useless since when we run this cmake code we already know if the compiler produces 32-bit or 64-bit binaries, I also removed -mfloat-abi=hard flag since it is expected that when this part of the cmake code is run, the compiler already produces armhf binaries. The architecture is expected to be selected by selecting a compiler.

I also added a commit to detect armel and armhf compilers. I first put it aside, thinking I would include it in the Android PR (#799), but in fact it's welcome to do it now because it is hardening the cmake code. It makes sure every if(ARCH STREQUAL armhf) test in cmake is actually done when using a compiler that produces armhf binaries, and not any other arm ABI.
There is no plan to provide armel binaries in releases, there is no prebuilt nacl_loader anyway.
cmake: add armel architecture for soft float 32-bit ARM ABI
Mainstream 32-bit ARM Linux distributions use "hard" float ABI.
Example: Debian armhf
Some (less used) 32-bit ARM Linux distributions use "soft" float ABI.
Example: Debian armel
Android 32-bit ARM distributions use older "soft" float ABI,
like Debian armel. This is very likely to maintain compatibility
over a very large range of hardware, especially since VFP was still
optional in Armv7-A which is still widely used.
On Linux, armhf is now preferred over armel on recent hardware,
starting with Armv7-A with VFP. Before that, armel was used on
older hardware up to Armv7-A without VFP, it should still works.
Debian Buster provides both armhf and armel distributions.
By building the software with the compatible "softfp" ABI variant it
is allowed to do hardware floats using the VFP while keeping compatibility
with "soft" libraries and then armel systems at the cost of some overhead.
Distributions favorising performance will prefer armhf.
Distributions favorising compatibility will prefer armel.


Error [ERR_REQUIRE_ESM]: Must use import to load ES Module

I'm getting the following error when I try to use this package:
internal/modules/cjs/loader.js:1085
      throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
      ^

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/me/myproj/node_modules/normalize-newline/index.js
require() of ES modules is not supported.
require() of /home/me/myproj/node_modules/normalize-newline/index.js from /home/me/myproj/postal.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/me/mproj/postal-data/node_modules/normalize-newline/package.json.

I think that using "type": "module" in your package.json makes your package incompatible with projects that are using commonjs (which is the default).

Please read the release notes.

https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c


Error cleanup

After reading "Context-preserving error handling" by @nagisa, I realized that we were dropping a lot of the error context when creating errors with ?. Instead, this PR tries to avoid ? and .into() in the lib where a map_err would preserve and encapsulate context. (See code for examples.)
Along the way, the following changes were made:

Remove tautological "Error" suffix from ErrorKind variants.
Avoid generic error kinds in favor of more granular ones to preserve the context of what error occurred exactly.
Remove all boxing of underlying errors.

The fact that we can avoid boxing error altogether was a convenient side-effect of restructuring the error kinds.

I've not reviewed the code yet. But I have some suggestions.

For thiserror, #[from] implies #[source]. So there's no need to change it.
If you want more details in backtracing, you can also add #[backtrace]. If there's a backtrace field, #[from] will also catch it.
For lychee-bin, you can replace thiserror by https://lib.rs/crates/color-eyre

Nice, I'll switch back to #[from] then. Did not know that, thanks!
The current error output is fine, but some color would indeed be nice. Maybe we can add that part without another dependency, even though I generally like color-eyre.

I don't think we need to replace result? by result.map_err(|e| ..)? in most cases covered in this PR.
Note that map_err is useful only if you attach additional information not already included in the original error.
What I see from this PR is that the only changes we introduced in map_err is to give the error a more descriptive name.

Note that map_err is useful only if you attach additional information not already included in the original error.

It's not just about attaching additional information.
In my opinion, even if we just introduce a better name for an error, it would still be a win because it's easier to understand the context just by looking at the code; ? hides a lot of that context. It's not clear what inner error a ? maps to and it's tempting to just add ? everywhere instead of introducing a new variant that would describe the error more precisely, which could later be matched on by a library user.

A side note,
In my crates, there is a bad patter that they define their custom error type that wraps various other errors from upstream libraries. And often time the inner errors are made private. That will make it very hard to extract additional information from the type itself.
We should avoid this.

Yeah. Are we doing that, though? I was of the opinion that using #[from] would be the idiomatic way to "wrap" errors. Please correct me if I'm wrong. In this case I would need some help to change the design.

In many crates, there is a bad patter that they define their custom error type that wraps various other errors from upstream libraries.

Yeah that's quite annoying. I tried to extract information from reqwest and octocrab by doing some matching on the inner types. For the other errors I couldn't find much helpful context yet, but that's probably fine.

we currently don't have that issue.
Since ErrorKind is public and enum variants cannot be private when enum is public, so downstream crates can access the inner error of ErrorKind.
This issue may arise if some of the variants contains a struct/enum that has private fields.
And for future development, we need to avoid that. That is, if we want to hide some details, hide it when constructing the error type, but still expose its fields, instead of making the fields private.


VS 2017 RC ASP.NET Core project "Default namespace" not populated

Follow these steps to reproduce:

git clone https://github.com/scottaddie/DotNetCoreSampleApp
Open solution in VS 2017 RC
Right-click project in Solution Explorer, and choose Properties option from context menu
Click the Application tab, and notice that the Default namespace textbox is empty:

I would've expected this namespace textbox to be populated, as it looked like this in VS 2015 Update 3:

I verified this works fine on a clean install of d15rel.26114.02. This is most likely due to older packages due to https://github.com/dotnet/roslyn-project-system/issues/1187


Fix the wrong return type for sum(Real) in spark sql

The return type of sum(real)  in spark sql should be double, not realhttps://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala#L81.

@mbasmanova Can you help to review? Thanks.

@mbasmanova it's a quick bug fix for window operator. It causes Gluten failure in some users.


Partial thread per core, again

https://github.com/n0-computer/iroh/pull/1088 was not against main, but against x-hp-tpc-2 due to the whole x-hp confusion last week. This is identical.


add DeepL translation

#94
This PR adds

Integration with DeepL
Tests for DeepL which can only be run with a token

We still need methods to easily update AnnData objects with these translations. Might be this PR, might also get a follow up PR.
Signed-off-by: zethson<EMAIL_ADDRESS>

I should ensure that we have 3 ways to translate

translate obs (done)
translate var (missing!)
translate X (WIP)


Explicit Dependency Tracking in Expr

In expr(), the only way to find out all tracked dependencies is to scan the code, which is terrible for long / complicated expressions. Perhaps a method of specifying all dependencies at the beginning of such an expression function would be nice:
expr($ => {
  $.on(x, y, z)

  // ...
})

This would allow treating all further trackings as passive tracking, reducing syntax complexity (instead of having two symbols in the function body, we can work with one).

NOTE
This can kind of be done already by simply calling the active tracking function $ at the beginning:
expr($ => {
  $(x), $(y), $(z)

  // ...
})

So the only real benefit would be handling all trackings with one track function. Perhaps both syntaxes can be supported and each can be used whenever appropriate.

[ ] Add documentation
[ ] Release a minor containing this change