Define coding standards and introduce custom ruleset to apply and check them

Ticket: #1561
Issue
Coding Standards need to be documented and there needs to be an easier way to check and fix violations, maybe even automatically. WordPress just recently applied the WordPress Coding Standards to the whole codebase.
Solution
Define and document the coding standards and provide a way for developers to check for errors in coding style automatically.

Introduce a new phpcs.xml file, which is a custom ruleset for PHP_CodeSniffer that inherits from WPCS. The WPCS (WordPress-Coding-Standards) project provides sniff rules for PHP_CodeSniffer to enforce WordPress coding standards in a project.
Document Coding Standards in CONTRIBUTING.md. Define WordPress Coding Standards as the standard for Timber and list the exceptions where the Timber standard deviates from the WordPress Coding Standards. Document how developers can use the custom ruleset to check for coding style errors.

I hope we can all agree that we’d want to use as few exceptions to the WordPress Coding Standards as possible. However, considering how the Timber code base has grown and how it’s used by theme developers, certain exceptions need to be introduced. Currently I found only two exceptions where the Timber Coding Standards would deviate from the WordPress Coding Standards:

Class and file names are defined in StudlyCaps. We follow the PSR-0 standard, because we use autoloading via Composer.
We use hook names namespaced by / instead of underscores (e.g. timber/context instead of timber_context).

Probably we’ll have to see how this holds up. This is a first version of the Timber Coding Standards, not a definitive one. But I think it would be best if we can stay as close to the WordPress Coding Standards as possible.
To automate the process, PHP_CodeSniffer comes with the PHP Code Beautifier and Fixer tool (phpcbf) to fix code according to sniff rules. This could maybe help. Still, we need to be extra careful to not introduce errors through this.
Maybe fixing the coding style in the whole code base could be something for Timber version 2.0 as well.
Impact
How big are the changes?
When the coding standards are applied to the code base, mostly it will just be formatting changes.
By inspecting the code with the new sniff rules, I saw that one of the biggest changes introduced would be a naming convention for class name variables. Consider the following line:
https://github.com/timber/timber/blob/4d7609edaf04b9d1fc5d8f2c402cf7c0e5bda7ac/lib/Post.php#L59
PHP_CodeSniffer would mark an error here:
WordPress.NamingConventions.ValidVariableName.NotSnakeCase: Variable "PostClass" is not in valid snake_case format.
The variable would need to be changed from $PostClass to $post_class, which shouldn’t be a problem, because from what I saw, they are only used internally. Deactivating that rule is not really an option, because then other variable names wouldn’t be checked either.
Whitelisting code
If it’s not possible to adapt to certain rules, certain code could be whitelisted:

https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Whitelisting-code-which-flags-errors
https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-parts-of-a-file

I think this should be used sparingly.
Required inline documentation
A large amount of sniff warnings will be about missing inline documentation. I think this will be a good incentive to improve this. The Reference will benefit from this as well.
Version history
If applied to the current codebase, the version history will be more difficult to read. However, with Github’s advanced blame feature, it’s easy to go back step by step. WordPress did it all in one patch, so I guess we could do it in one pull request as well.
Usage Changes

None for theme developers.
Usage instructions for how to use PHP_CodeSniffer to apply standards for pull requests can be found in CONTRIBUTING.md.

Considerations

WordPress Coding Standards don’t define a maximum length. Should we define one?
Does it need to be integrated into Travis?
Does it need to be integrated into Scrutinizer? While I don’t know a lot about how Scrutinizer works, it allows you to run PHP_CodeSniffer.

Testing
No. Existing tests need to be run after coding styles are applied to the code base.

@gchtr this is great! I was finally able to a deep-dive today. phpcbf is beautiful but terrifying. Where to go from here?

Travis: Given the amount we'd have to whitelist or ignore, I vote on holding-off for Travis for now
Scrutinzier: I think I updated the config to use the phpcs.xml file
Maximum Length: is this maximum line length? file length? I think I need some more info on this one
phpcbf & Version History I started to have some fun, but then pulled back recognizing what your note about it messing with blames. Let's hold off on mass running for 2.0

I'm going to merge this in on #1614 with a few updates I made. Let me know your thoughts on this other stuff (esp. max length) to see what else we need to do

@jarednova I can’t really comment much on Travis and Scrutinizer, because I don’t know them well enough.

Maximum Length: is this maximum line length? file length? I think I need some more info on this one

I meant maximum line length. The WordPress Coding Standards don’t say anything about this. When looking at PSR-2, they have the convention of staying below 80 characters, but longer lines are allowed. This question goes more into detail.
It also seems to be possible to set this as a rule for PHP_CodeSniffer, but the question remains: is this something to think about, or should we just leave this open?
Maybe for code it’s not as important as for multiline DocBlock comments, where I’d like to have standard to follow. For code itself probably it’s often a case of: «It depends.». But for DocBlocks, I think 80 characters per line would be reasonable for better readability even on smaller screens.

phpcbf & Version History I started to have some fun, but then pulled back recognizing what your note about it messing with blames. Let's hold off on mass running for 2.0

I think version 2.0 would be a great place to do this.

I saw that in https://github.com/timber/timber/pull/1614/commits/c7f6bfcf8c566e90f33d9cd101c29bd80e29d03d you added additional rules for function call spacing. What’s the reasoning behind this? Would we deviate from the WordPress Coding Standards here?

Cool! That's what I thought with line length. I think implementing line length for doc blocks sounds great.
As for c7f6bfc: I've always done this as a no space thing (ie foo($a, $b)) — but that's just a personal preference. I get the feeling that this might be time for me to drop that personal pref in favor of community standards?

Okay then, I’ll see if we could check for comment length only.
And about your personal preferences: Yes, I guess this would be the perfect time to drop those. I did that around 1.5 years ago. First I was struggling, because everything looked ugly in the WordPress Coding Standards. Fast-forward to now and I think everything that’s not WordPress Standard looks ugly and even less readable. So you can definitely get used to it.
It’s really tempting to change and add sniffing rules, but in my opinion, if there’s not a reason like backwards compatibility we shouldn’t deviate from the WordPress Coding Standards. This makes it easier for everybody.


Add "More..." category that allows filtering on all tags,

Adds ability to filter on all tags.
Improved configuration possibilities to set what tags to group things under, as well as what to include in the category, for the various hosts.
Refactor of category creation
Code organization improvements

Skärminspelning 2022-12-22 kl. 00.04.04

Wrong repo again 👀


apiext: add rbac for updating crd statuses

Description
On some locked down clusters, the status update for CRD's will fail due to missing RBAC. This updates the fix-crds tool so that it includes customresourcedefinitions/status in the RBAC permissions when updating CRDs. AFAIK, it seems like it will report an error but still update status in our CI tests which is why we didn't catch this.
This supersedes https://github.com/emissary-ingress/emissary/pull/5449 because the file changed in that PR is generated and would get overridden as soon as make generate was called again. The file is generated via the tools/src/fix-crds using the template defined here: tools/src/fix-crds/apiext.yaml so that has been updated so that make generate is clean now.
Related Issues
Fixes https://github.com/emissary-ingress/emissary/issues/5436
Testing
CI Tests are still passing. Manually testing from user as noted here: https://github.com/emissary-ingress/emissary/pull/5449#issue-2002048514
Checklist

[ ] Does my change need to be backported to a previous release?
[x] I made sure to update CHANGELOG.md.
[x] This is unlikely to impact how Ambassador performs at scale.
[x] My change is adequately tested.
[ ] I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.
[x] The changes in this PR have been reviewed for security concerns and adherence to security best practices.

@AliceProxy Why hasn't this been released?


Is this model able to run on the Caffe without distribution model??

I found that this model is trained by CaffeOnSpark, I was wondering whether I can use this model running in the original caffe without distribution or not.
Thank you very much

@chibai
Yes, you can. I have test nsfw on the official caffe .

Thank you so much!! I can close the issue now


Fix locking

I have noticed that the functions "pthread_mutex_lock" and "pthread_mutex_unlock" are called (for the variable "print_mutex") within the implementation of the function "process_terminal" without accessing another shared resource between these calls.
I suggest to reconsider the corresponding lock scope.

Actually, you know, it doesn't access shared resource while locking. It is waiting for release of the mutex by this pthread_cond_wait
Is it wrong usage?

Thanks that you fixed this pair of lock/unlock calls to do something useful between them.

Will it be needed to synchronise the assignment of the variable "complete_scan_file" by another mutex?


about the classification part

Thanks for the great contribution of this research.
About the visualization part for the dir(data_process),Could you please tell me how could i visualize the .json format 3d data?
by the way,the processed data was classfied into 10 classes for RANGENET++,I would like to know the standard of the classification.
Thanks a lot.

I would like to know the algorism of genrating the semantic graph.
Could i consider the .json format data as the semantic graph?
According to Raw input>semantic segmentation>instance segmentation>semantic graph.
Thanks a lot.

Hi! Thanks for your interest in our work!

For visualizing the 3D semantic graph, you can simply draw the nodes with colour according to their semantic labels and 3D positions, which are stored in the .json files. We created the visualization with ROS Rviz.
For the classification details, you can find here that we map the original semantic KITTI labels to ours.
Yeah, you can consider .json files as semantic graphs. Each .json represents a semantic graph for the scene and the index is the file name.

Hope it helps you. Please let me know if anything unclear. Thank you!


add bundle itself as a classpath element if it does not have Bundle-Classpath

If an OSGi bundle does not have a Bundle-Classpath statement then it'll be simply skipped by the FelixClassLoaderHandler. This simple fix adds the bundle itself as a classpath element for scanning.
Can't say if this is a universal solution, but works for me. May be we should always add the bundle, even if it does have a Bundle-Classpath?

@qalex Thank you for tracking down the cause, and thanks so much for submitting this pull request!
I don't use OSGi, but in general handling non-native classloaders is a long tail of special cases like this, and this patch looks good to me.


Error helm install falcosidekick (chart 0.5.10)

Describe the bug
Error helm install falcosidekick

helm repo add falcosecurity https://falcosecurity.github.io/charts
helm repo update

helm install falcosidekick falcosecurity/falcosidekick --set webui.enabled=true
Error: INSTALLATION FAILED: YAML parse error on falcosidekick/templates/deployment-ui.yaml: error converting YAML to JSON: yaml: line 36: could not find expected ':'

or
helm install falco falcosecurity/falco --set falcosidekick.enabled=true --set falcosidekick.webui.enabled=true -n falco
Error: INSTALLATION FAILED: YAML parse error on falco/charts/falcosidekick/templates/deployment-ui.yaml: error converting YAML to JSON: yaml: line 36: could not find expected ':'

Environment

Falco version:

NAME                                    	CHART VERSION	APP VERSION                       	DESCRIPTION
falcosecurity/falco                     	2.4.5        	0.33.1                            	Falco
falcosecurity/falco-exporter            	0.9.1        	0.8.0                             	Prometheus Metrics Exporter for Falco output ev...
falcosecurity/falcosidekick             	0.5.10       	2.27.0                            	Connect Falco to your ecosystem

System info:

Kubernetes v1.23.6
containerd.io 1.5.11
helm v3.10.3

Cloud provider or hardware configuration:
OS: Ubuntu 20.04 LTS

Kernel:
NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.4 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Linux k8sdemreprod1001 5.4.0-109-generic #123-Ubuntu SMP Fri Apr 8 09:10:54 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Installation method:

From source
Additional context
I have not found the minimum requirements and I know helm in a basic way, additionally I tried with another namespace.

Same here, there is a space missing for the new args from the ui-deployment:

I'm fixing right now

@lepsusx @ckotzbauer if you use directly the falcosidekick chart, it's fixed, if you use the falco one, it will be in few minutes. sorry.

Thanks @Issif!
This fix worked, but I discovered another bug: The 2.1.0 image of falcosidekick was released without the "v" prefix. https://hub.docker.com/r/falcosecurity/falcosidekick-ui/tags

It's not a bug, it's like that since the beginning, I thought it wasn't mandatory in semver method and I started without and I think it's better for the users to no change that.

It's not a bug, it's like that since the beginning, I thought it wasn't mandatory in semver method and I started without and I think it's better for the users to no change that.

But then the "v" has to be removed from this chart. Otherwise the image can't be pulled.

Sorry, I thought we were talking about sidekick and not the ui. Let me check.

@ckotzbauer the image with the v tag is pushed on Dockerhub https://hub.docker.com/layers/falcosecurity/falcosidekick-ui/v2.1.0/images/sha256-8d6c2f8b93e3a38c5d7728c9b6f2c9d3b99264de54e014eb5d5cd271c3e646ad?context=explore
And the healthcheck endpoint is now unauthenticated

Thanks @Issif for your very quick response. I'll appreciate that!

I'm happy you use my projects, your feedback is really valuable to me. Thanks.

@lepsusx is that ok for you? can you close this issue when it is please

it's ok, thanks @Issif !!


Enhance envoy XDS logs to improve debugging

One of the most common scenario to debug is about the XDS connection. Right you now just get that error 13 or 14 message.
Ideally we would get some more info, including when it connected, more user friendly reason for disconnected, and just in general what is going on. Part of this may be tuning our log levels

We have improved this to show what gRPC stream was sent


docker-desktop and docker-desktop-data in File Explorer?

I don't know why I would want to have docker-desktop and docker-desktop-data showing up in Explorer:

cc @craigloewen-msft

Docker implemented their WSL support by using two distros. WSL didn’t make them.

Well I know that. But my ask here is (sorry for not making it clearer) that I don't want those distros popping up in Explorer. I just wanted Explorer to ignore it like how Windows Terminal does not show docker-desktop and docker-desktop-data

That's a good question. I'm going to mark this as a 'feature request' since as of right now we don't have a way of differentiating between the docker desktop distros and perhaps another user installed distro that you might want to run.

Idea: Give users the option to hide any distro in the File Explorer.

This is completely useless, but I think the Linux tab seems kinda cute.

how to get that linux in explorer?

I am using the Insiders Fast build.

I think it should be a good idea to allow developers (like the Docker team) to set a distro as hidden using a flag in registry.
This flag could be read by wsl --list or other program like Windows Terminal to ignore it. This could also be implemented in a new WslListDistributions function of wslapi  #4644 of course a ShowHidden flag could be pass to wsl --list and to  WslListDistributions function


Add custom wrapped errors

What would you like to be added?
Ratify may return a lot of different errors which are not well organized and a bit difficult to debug or understand its meaning. We could add some common custom wrapped errors so that they can be organized and easier for debugging. And those defined errors could be checked on pkgsite which can avoid manual maintaining on error doc.
For example, for the GetReferenceManifest API of referrerStore, we can have an ErrGetReferenceManifest defined.
Anything else you would like to add?
No response
Are you willing to submit PRs to contribute to this feature?

[X] Yes, I am willing to implement it.

Discussed in community, ideally we want start with a small set of Ratify common errors. A set of oras error is defined in the open container spec, we can use these as example. https://github.com/opencontainers/distribution-spec/blob/main/spec.md#error-codes


Invalid emails being allowed in 'add collaborator'

Is your feature request related to a problem? Please describe.
I tried to add invalid email and it showed it was valid.
Email that I added was test@rosy
Describe the solution you'd like
Invalid emails should get removed.
Additional context
Screenshot attached.

Can I please work on this issue?

Can I work on this @tachyons and @sakshi1499 ?

As all the PRs have been closed without merging, you can work on this. Ref the last PR, some comments have been made for improvement. Include those. @Shivansh2407

Ok Cool @sakshi1499


Add navigational note from ref-safe-context to safe-context

(And fix a bit of formatting.)
Fixes #901.
cc @KalleOlaviNiemitalo

I think I'd prefer having the note higher up, visually separating it from the examples.

I've added a second commit which puts it pretty much at the start of the section. I'm not convinced there's a good place for it other than at the start or the end... we'll see what others think.


How to find CAfile accessing URL Of Rancher Server By Https

After runing rancher,I want to get parameter of --token and --ca-checksum by API By Curl,but curl needs CAfile.How can I find the CAfile of rancher.
What kind of request is this (question/bug/enhancement/feature request):
I can not find where Rancher' CAfile is.
Steps to reproduce (least amount of steps as possible):
Result:
Other details that may be helpful:
Rancher version:
rancher/rancher:v2.1.1
Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"8+", GitVersion:"v0.0.0-master+$Format:%h$", GitCommit:"$Format:%H$", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.5", GitCommit:"32ac1c9073b132b8ba18aa830f46b77dcceb0723", GitTreeState:"clean", BuildDate:"2018-06-21T11:34:22Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Docker version (use docker version):
Server Version: 17.03.2-ce
Thanks.

Please read https://rancher.com/docs/rancher/v2.x/en/contributing/#bugs-issues-or-questions and use the forums for questions.
You can see how the agent uses the CA certificate here https://github.com/rancher/rancher/blob/master/package/run.sh#L226


Update gradle metadata spec link

This fixes a link to the gradle metadata spec.
Context
This page shows up in some google searches for gradle metadata, and then I found that this link on the page was broken.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

Thanks for spotting that and proposing a fix. It looks like that documentation page needs more love though. I will cherry-pick this commit and then rework the content there.

Sounds good thanks!

Contribution included in #9172


Multiple Docker version declarations updated to a single one

It seems that dependabot ignores prefixes (maybe also suffixes) when bumping images.
Our repo has 3 files:

Dockerfile.bionic
Dockerfile.trusty
Dockerfile.disco

We just enabled dependabot on it, and at its first PR this is what it did:
# Dockerfile.bionic
- FROM ubuntu:bionic-20190718 AS bionic
+ FROM ubuntu:bionic-20190807 AS bionic

# Dockerfile.disco
- FROM ubuntu:disco-20190718 AS disco
+ FROM ubuntu:bionic-20190807 AS disco

# Dockerfile.trusty
- FROM ubuntu:trusty-20180929
+ FROM ubuntu:bionic-20190807

I would definitely expect it to not update ubuntu releases given the complexity of it!

I think I know what's going on here.

Dependabot is picking up all three of your files
It's scanned for dependencies and finding only one - ubuntu - but with three different versions (bionic-20190718, disco-20190718 and trusty-20180929)
It's then looking for a relevant update, taking into account the prefix from the first requirement to find that bionic-20190807 will do
Finally it's updating all three "versions"  to the new one

The fundamental problem here is that Dependabot is grouping all three "requirements" together, rather than treating them as separate dependencies. I think the right fix would be for Dependabot to treat all three separately, but that would be quite a big refactor.

Duplicate of #2179


merge main to live Friday 10:30

Docs Build status updates of commit a10bab2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/New-RoleGroup.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-RoleGroup.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Test-OAuthConnectivity.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 3668f81:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Enable-Mailbox.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/exchange.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Get-ServicePrincipal.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-ManagementRoleAssignment.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-RoleGroup.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-ServicePrincipal.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Remove-ServicePrincipal.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-ManagementRoleAssignment.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-RoleGroup.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Test-OAuthConnectivity.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/mapping/serviceMapping.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Simplify rustup installer.

This installs rustup directly to the persistent data directory by setting the CARGO_HOME and RUSTUP_HOME environment variables for the process before running the rustup installer.

Neat!


cyclone

went to create wind butt found september 23 save

12:14pm ethereal
10:19am element
10:18am index
9:40am clone

come into me


lose the reparse parse

resolves #114
why are we doing a Datetime parse on a stringified datetime anyways?

@swaroopmurthy this breaks the formatting in the tests and does not send them in proper ISO format


Adding HICSS Presentation

Here's a short blurb and a link to my HICSS paper

@samwalkow can you add the frontmatter at the top, like in the other entries?

Added formatting!

Thanks!


Assertion failure on mingw 32bit builds

https://github.com/arximboldi/immer/pull/76 introduced the use of alignof(std::max_align_t) to determine the offset of the size value inside the allocated memory.
There is however an issue when built with mingw and 32bits. The bug described in https://sourceforge.net/p/mingw-w64/bugs/778/ results in extra_size being different, depending on the order of inclusion of immer headers and standard headers.
In my specific case, this results in allocation happening with extra_size being 16 and deallocation happening with extra_size being 8, which then causes the assertion in debug_size_heap::deallocate to fail.
I was considering creating a PR, but then was not sure how to fix this so that it would be accepted. Possible solution would be to fix extra_size to always be 8 bytes (e.g. 2 * sizeof(void*)) when mingw+32bit is detected. I don't see how this can be fixed through the inclusion order, as inside immer you have no control about what was included before the first immer header.

I am happy to accept a fix that looks like:
#if defined(__MINGW32__) && !defined(__MINGW64__)
// workaround
#else
// normal flow
#endif

Note that the check is needed in that form because mingw32 defines the first macro also for 64 bit builds. I don't have a MING32 system at hand, so I'd thank you if you could make such PR and try it yourself.
Thanks a lot!

Wait a second... I just realized that the default case is also incorrect. I thought I accepted something else in the last PR touching that code, dunno what happened in between...

Ok, I'll create a PR after your latest PR which touches the same line is merged.

Should be fixed now with your PR. Thanks a lot Alex for the bugreport and fix!

Oops, that was my mistake in #76, sorry about that. Arx had suggested the version with std::aligned_storage_t in the first place; I thought (wrongly) they're always equivalent.

@jzrake As I understand the issue, it was not about wether using aligned_storage_t or not. It's the use of std::max_align_t, independent of how you use it, that caused the issue on MinGW 32bit. Nothing you could have expected to happen, so all good :

Don't worry @jzrake, the aligned_storage_t thing only fixes the situation where sizeof(size_t) is smaller than the max alignment, which to be honest I am not sure there is any architecture alive where it's the case.


Kafka example

Fixes #1028
(cherry picked from commit 57e71a50c117d78668618157724343e6c54b7799)

@jamesnetherton Thanks for the comments.
I'm updating this and adding also the MK section.

@jamesnetherton I've just pushed the changes.

@zbendhiba Just one thing missing - please can you add an entry for this example to the README.

@zbendhiba Just one thing missing - please can you add an entry for this example to the README.

Thanks @jamesnetherton. I've just pushed another commit

@zbendhiba Just one thing missing - please can you add an entry for this example to the README.

Thanks @jamesnetherton. I've just pushed another commit

There's a typo. Sorry. I have to push again

It should be okay now


add nni hpo, json.load->yaml.safe.load,codestyle

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Infowindow break word

This PR fixes https://github.com/CartoDB/support/issues/935.
It relays on https://github.com/CartoDB/cartodb.js/pull/1759, this only updates references. Please, once merged, remove DI branch.

This looks way better than it did before, but there is still some odd wrapping behavior, mainly breaking the words in the middle rather than at a white space


CAMs on custom dataset

Hi Jiwoon
I trained the classification model on my own dataset which has binary labels(present or not present). I made the necessary changes to your code.
But while generating CAMs using infer_cls.py. All I get is completely black or white images.
Are there any other modifications that I need to make to generate cams except for the softmax with BCELoss. and changing labels from 20 to 2?

Hi @sinAshish,
Here are my tips for your case: 1) We hypothesize the background confidence scores by setting alphas because there's no such label in PASCAL VOC. If your dataset has background labels, I don't recommend you to do this. Instead, you can threshold CAMs by some value or just take argmax of classes per pixel. 2) Check the classification accuracy of your validation set. (probably you should get over 95% acc)

Thanks for the suggestion. I'll try it out and see if it works.

I have trained the classification model on my own data set, which is similar to your result. How do you solve this problem? @sinAshish

I take argmax of classes per pixel as suggested by @jiwoon-ahn . But I haven't yet run the code so can't say for sure if it would work.

My loss decreases to a very less extent, like from .68 to around .43 or .48. I use log_softmax with NLLLoss. What about you @xiangzhang06 ?

Hello! Has anyone found any success with this? When I try to run infer_cls, every value in the CAM comes up as 0. The only change in train_cls I made was changing the number of labels, and loss only decreases from 0.6929 to  0.606.


ConnectionManager.ConnectedNodes needs protection

Allowing ConnectionManager Behavior to directly modify ConnectionManager.ConnectedNodes has a really bad smell to it to me. Is this a separation of concerns violation?
I don't think anything should be modifying the list of nodes without the knowledge of ConnectionManager, and hooking the Added/Removed event within ConnectionManager seems dirty too.
https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/Stratis.Bitcoin/Connection/ConnectionManagerBehavior.cs#L66
			if(node.State == NodeState.HandShaked)
			{
				this.ConnectionManager.ConnectedNodes.Add(node);
				Logs.ConnectionManager.LogInformation("Node " + node.RemoteSocketEndpoint + " connected (" + (this.Inbound ? "inbound" : "outbound") + "), agent " + node.PeerVersion.UserAgent + ", height " + node.PeerVersion.StartHeight);
				node.SendMessageAsync(new SendHeadersPayload());
			}

Recommend making ConnectionManager.ConnectedNodes return IEnumerable, or creating a new interface in NBitcoin/NStratis which permits a readonly collection.

Alternative solution via NBitcoin
	public interface IReadOnlyNodesCollection : IEnumerable<Node>
    {
		event EventHandler<NodeEventArgs> Added;
		event EventHandler<NodeEventArgs> Removed;

		Node FindByEndpoint(IPEndPoint endpoint);
		Node FindByIp(IPAddress ip);
		Node FindLocal();
	}

	public class NodesCollection : IEnumerable<Node>, IReadOnlyNodesCollection

@NicolasDorier


Add hack script to install multiple clusters at one time.

Which issue this PR addresses:

Fixes N/A
As a part of https://issues.redhat.com/browse/ARO-6198
What this PR does / why we need it:

Once we have the install in prod regions, we need to install some clusters to make sure that there is no increase in installer failure rate.
This hack script can help to test multiple installations at one time in a region.
Test plan for issue:

Ran in local.
Is there any documentation that needs to be updated for this PR?

yes I updated the doc.
How do you know this will function as expected in production?

You can check the output of the script to see the result.

/azp run ci

Good question. To be honest, I didn't think of that.
If I had to say, the installer repo has scripts that are needed when developing the installer, but the process like ARO-6198 is conducted after we deployed a new release in each region (I mean not when we are developing it).
But I don't have the preference. I want to know what others think.

@mociarain Good question. To be honest, I didn't think of that.
If I had to say, the installer repo has scripts that are needed when developing the installer, but the process like ARO-6198 is conducted after we deployed a new release in each region. Also ARO-RP is more accessible because everyone clones it.
But I don't have the preference. I want to know what others think.

I didn't think of it either, but it makes more sense to have the script in the wrapper repo. Probably even the .md file with the instructions too. If we move the content from upstream-difference.md too, we probably should keep the old file just with a link to the new one (since it is linked from other docs, jiras and wikis).

Thank you all!
I will close this PR and will make new ones to here and the installer repo to migrate the upstream-difference.md.


Rotate Certificate for Ingress TLS

Applying the certificate is documented here. https://docs.microsoft.com/en-us/azure/aks/ingress-tls
Its suggested in this doc to use cert-manager but, the github for cert-manager clearly indicates its not production ready. Therefore, this issue should indicate how admins should rotate the certificate for ingress TLS before it expires.

@charleszipp was this ever documented? How do we rotate TLS certificates on ingress controllers in AKS?

@charleszipp was this ever documented? How do we rotate TLS certificates on ingress controllers in AKS?

Would like to know too, is there a document we can use for reference?


Are hyperlinks hard to see?

Color is a subjective thing, especially with the prominence of color blindness in our population. What pops to some may be invisible to others.
So I wanted to ask, does anyone else feel these hyperlinks are difficult to see? On a 1-10 scale of visibility, I would rank these as a 2:

Especially given the visual prominence of our new artifact hyperlinks (green), I fear from my own experience that our hyperlinks are being looked over by readers.

I agree. What would be your suggestion?

I think underlines are clear and impossible to miss, but the look is admittedly pretty retro. Here's an example:

On the page I'm on now,  I see a blue text hyperlink that looks clear to me. I don't know why though. Maybe because it is lighter than on our website?

What do you think?

Yes, I think GitHub link is very nice and it is because it is lighter than ours.
GitHub: #0969da; Ours: #444499. Much darker. I think we could change it with GitHub link color and no one would be upset :)

Ok i'll change it right now

🎉

Fixed in 9dbc3b628b8da583297b93cfc8df828f88deb607


Trouble unzipping Toolsuite-Java-<IP_ADDRESS>.jar

I am having some trouble with running this in
$ ./gradlew build
:compileJava
error: error reading /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar; error in opening zip file
error: error reading /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.kauai/Navx-Java/3.0.331/94160dbe0ab528f71d83ae75c900f1190984377f/Navx-Java-3.0.331.jar; error in opening zip file
error: error reading /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar; error in opening zip file
error: error reading /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.kauai/Navx-Java/3.0.331/94160dbe0ab528f71d83ae75c900f1190984377f/Navx-Java-3.0.331.jar; error in opening zip file
:processResources UP-TO-DATE
:classes
:jar FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jar'.
> Could not expand ZIP '/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1.715 secs

I tried cleaning and removing the files so it would download again, and it happened again.  I tried unzipping the file from the CLI and I got this error:
~/code/robotics/rioTest$ unzip /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar
Archive:  /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar or
        /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar.zip, and cannot find /home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar.ZIP, period.

Not sure what to try now.  They may have gotten corrupted or something.  I am also running this on Linux, which may be part of it.

I'll check tonight, I'm out of the house right now. I'll see if I can find
the issue
On Sat, Sep 16, 2017, 03:20 Adrian Moore<EMAIL_ADDRESS>wrote:

I am having some trouble with running this in
`
$ ./gradlew build
Starting a Gradle Daemon (subsequent builds will be faster)
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:jar FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':jar'.

Could not expand ZIP
'/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/
<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar
'.

Try:
Run with --stacktrace option to get the stack trace. Run with --info
or --debug option to get more log output.

BUILD FAILED
Total time: 5.309 secs
`
I tried cleaning and removing the file so it would download again, and it
happened again. I tried unzipping the file from the CLI and I got this
error:
~/code/robotics/rioTest$ unzip
/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/
<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar
Archive:
/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/
<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar
End-of-central-directory signature not found. Either this file is not a
zipfile, or it constitutes one disk of a multi-part archive. In the latter
case the central directory and zipfile comment will be found on the last
disk(s) of this archive. unzip: cannot find zipfile directory in one of
/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/
<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar
or
/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/
<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar.zip,
and cannot find
/home/bloodred/.gradle/caches/modules-2/files-2.1/thirdparty.frc.ctre/Toolsuite-Java/
<IP_ADDRESS>/94160dbe0ab528f71d83ae75c900f1190984377f/Toolsuite-Java-<IP_ADDRESS>.jar.ZIP,
period.
Can you check to see if you can rm that file and re-download it? It might
have gotten corrupted or something.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Open-RIO/GradleRIO/issues/41, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJyG6KGFED0ua97Q7wKGPnFYaUx7xfs3ks5sis3vgaJpZM4PZZ4T
.

Oddly enough the Zip doesn't appear to be corrupted on my servers' end. I've successfully unzipped it on both linux and windows. Run ./gradlew build --refresh-dependencies. If that still fails, run again with wpi { talonSrxVersion = "<IP_ADDRESS>" } in your build.gradle and report back

Refreshing the dependencies worked.  Closing issue.


Provide a silencer for BlockStateChange NN log entries

This PR provides a way to lessen NN logging due to BlockStateChange messages as discussed in HDFS-4080.

Looks good


Update Rails version compatibility in the README

Looks like the gemspec should be updated to require actionpack >=4.2 as well

Thnaks @donv I'll look into the gemspec. I need to make a new release this month.


Put CI steps in hierarchical order in README

Description
Don't encourage copy-pasters (people) to walk of their heads.
Motivation and context
hardware architecture ▶ OS ▶ services/server software (e.g. PHP) ▶ development tools ▶ dependencies ▶ application
Please see https://github.com/szepeviktor/debian-server-tools/blob/master/webserver/generic-php/gitignore.example

I don't understand the relationship between the PR title, the link in the PR description, and the commit.

the description, the link in the description, and the commit

All three are a hierarchy is like a pyramid.
CI, gitignore files and other things could be ordered by this hierarchy.

first things related to arch
then OS-level stuff
after that system software
then development tools
then dependencies
finally things related to the application

I always go this way so because following rules are easy.

In this case PHP is a system software, it lives much higher than the application's source code.

What’s wrong with alphabetical order, which I find easier to remember? 😁

All right!
I leave it 100% up to you.

I don’t necessarily disagree with you, but I prefer not having to think about what category things fall under, unless there’s a tool that can do it for me.
As for CI, I think checking out the repo is the appropriate first step, in case there’s anything in it that you need to run in order to configure the system.

Okay. I'm not a developer, so I'm not source-code-centric.
Those underlying zeros and ones!


"==" unexpectedly compiles to === instead of caml_equal

I would expect \"==" to compile to Caml_obj.caml_equal, just like == does, but instead it compiles to ===:
type eq<'t> = ('t, 't) => bool

type t
@val external x: t = "x"
@val external y: t = "y"

let comp = eq => eq(x, y)

Js.Console.log2("== normal", comp((a, b) => a == b))
Js.Console.log2("== escaped", comp(\"=="))
Js.Console.log2("=== normal", comp((a, b) => a === b))
// "The value === can't be found":
//Js.Console.log2("=== escaped", comp(\"==="))

// Generated by ReScript, PLEASE EDIT WITH CARE
'use strict';

var Curry = require("./stdlib/curry.js");
var Caml_obj = require("./stdlib/caml_obj.js");

function comp(eq) {
  return Curry._2(eq, x, y);
}

console.log("== normal", Caml_obj.caml_equal(x, y));

console.log("== escaped", x === y);

console.log("=== normal", x === y);

exports.comp = comp;
/*  Not a pure module */

Playground link

This might be related to #335?


Template path resolution concept

README says:

template: Webpack require path to the template. Please see the docs for details.

Maybe that description is not very clear, or even not true.
I mean, you actually can use loaders for the template (as webpack requires), but the current implementation resolves the template path to absolute path just relative to context option.
So when you say “Webpack require path to the template” I suppose it will actually use webpack's resolver and it will support root directories, aliases, extensions etc. from resolve option.

That's true - it was necessary because of backwards compatibility

Moved to #444


Add DotNetAddPackage alias for dotnet add package command

As per @DWIAltonaAnalytics suggestion: https://github.com/orgs/cake-build/discussions/4186#discussioncomment-6353781
Docs: https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-add-package

Please assign it to me


Remove logo and clean up ArduBreakout

Scroll down "Arduboy" logo was removed because the library now provides a similar logo. I removed the two tone sound at the end of the intro, as well, on the assumption that the built-in library logo will eventually make a sound itself.
setup() and loop() moved to the beginning of the code, as recommended in the Arduino style guide:

Put your setup() and your loop() at the beginning of the program. They help beginners to get an overview of the program, since all other functions are called from those two.

Minor changes and cleanup.

Looks good.


build error: could not determine kind of name for C.rados_read_op_omap_get_vals2

Hi there, I'm trying to build this on arm64v8/debian:stretch and then got this error:
vendor/github.com/ceph/go-ceph/rados/ioctx.go:453:2: could not determine kind of name for C.rados_read_op_omap_get_vals2

Any ideas?
Ceph version: luminous

This has been introduced with #80, commit 7884e8a8af2d06baee9c38143a8c236783459e60.
The function that can not be found (rados_read_op_omap_get_vals2) has been introduced with ceph/ceph@fbebd83537b66b19d51c68e2fd51359305e84a3b and is part of Ceph v12.0.0, which would be Luminous.
Automated tests in Travis CI of go-ceph also run against Luminous. It is unclear to me why you get the build error. Can you share a complete log of the installation of development package and the build process?

Sorry, my bad, I plan to install the luminous version, but somehow it was v10.x version in the end. After installing the luminous version correctly, there is no build error anymore.

Hi,
I get this error when i try to perform any rbd level operation through the client library such as getting image names( GetImageNames(ioctx) )....
../../go/pkg/mod/github.com/ceph/go-ceph@v0.3.0/rbd/features_mimic.go:15:26: could not determine kind of name for C.RBD_FEATURE_NAME_OPERATIONS
../../go/pkg/mod/github.com/ceph/go-ceph@v0.3.0/rbd/features_mimic.go:11:29: could not determine kind of name for C.RBD_FEATURE_OPERATIONS

ceph version: Nautilus
Can anyone guide me on how to resolve this?

Both of those constants should be available on ceph versions mimic and later. I would double check that the version of the libraries where you are building is in fact, nautilus. You can also try changing the build tags (-tags nautilus or -tags luminous etc). Currently we have tags for "luminous", "mimic", "nautilus", and "octopus".
PS. In the future please file a new issue rather than commenting on a closed issue unless you are sure its the same. IMO, It's easier to cross-link separate issues that end up being the same than splitting an issue up later.

Thanks,
And okay i will keep that in mind...


优化代码结构,减少不必要的计算,节省计算资源

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[x] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.
In ResponseTimeDistributionSpanListener.java ,I find a unnecessary repetitive computing which could be replaced by single computing to economizes computing resources .

English only on github


Delete a worksheet row

I am not seeing any way to remove a worksheet row. I need to finds and remove rows from a few worksheets and add some new rows and save.

dont believe that is supported.
you would need to read all into array, delete row from array, write back as worksheet
Rows.Append does not appear to work either.


feat: 🎸 SQFormTransferTool

Creates a new component SQFormTransferTool. It is an opinionated, data driven modal to aid in call transfers
loom with some extra explanation: https://www.loom.com/share/58f48fff0e304f789506373aa752fb0b?sid=290e878f-3823-4ff3-976c-bc5a5861d406

I can see the build error and will correct it first thing tomorrow.

Is it possible to remove the footer while loading?

I think I'd like to see a bit more padding between the panels inside the modal

I think I'd like to see a bit more padding between the panels inside the modal

vertical padding? This is what the shared components provide. This would be a change to ssc.

I think I'd like to see a bit more padding between the panels inside the modal

vertical padding? This is what the shared components provide. This would be a change to ssc.

oof


Restore #10096/#8638 and re-fix #15172

This PR restores the vendored and patched dropdown.js from #8638. It
however, abandons the calls to click() using instead the default
dropdown click calls instead. This prevents the issue of the dropdown
grabbing focus permanently however, this may have negative effects on
the effect of focus on the dropdowns.
Of note, the behaviour of the template selector dropdown on the repo
creation page is slightly odd - I don't believe that this odd behaviour
is caused by this PR but rather by the feed source for this. I suspect
that the dropdown should be adding a delete button to its selection.
Fix #15172
References: #7057
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

Merging #16576 (1372bac) into main (3705168) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #16576      +/-   ##
==========================================
- Coverage   45.37%   45.36%   -0.01%
==========================================
  Files         750      750
  Lines       85084    85096      +12
==========================================
- Hits        38608    38606       -2
- Misses      40234    40249      +15
+ Partials     6242     6241       -1

Impacted Files
Coverage Δ

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

models/unit.go
41.09% <0.00%> (-2.74%)
:arrow_down:

modules/git/blame.go
65.71% <0.00%> (-1.43%)
:arrow_down:

models/repo_list.go
76.86% <0.00%> (-0.79%)
:arrow_down:

modules/queue/workerpool.go
53.05% <0.00%> (-0.77%)
:arrow_down:

routers/web/repo/view.go
40.95% <0.00%> (-0.58%)
:arrow_down:

services/auth/source/oauth2/providers.go
5.17% <0.00%> (-0.29%)
:arrow_down:

routers/web/repo/pull.go
30.32% <0.00%> (-0.07%)
:arrow_down:

modules/context/context.go
61.46% <0.00%> (ø)

services/auth/source/oauth2/source_callout.go
0.00% <0.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3705168...1372bac. Read the comment docs.

Can we at least disable original fomantic module (e.g. remove it from web_src/fomantic/semantic.json) so we are not loading 150kB of useless JS again? It probably means you also need to manually insert the dropdown css.
I think a more maintainable way of doing this would be to create a .patch file against web_src/fomantic/build/semantic.js and apply that during the make fomantic step.

I would suggest to copy the patched file to web_src/fomantic/node_modules/src/definitions/modules/dropdown.js during the make fomantic target, before the fomantic build runs, that way, we avoid loading the file twice which surely has unintended side-effects.

Done.

A even better approach would be to create a .patch and instead of a full-file replacement, or finally get this patch accepted by upstream.

That doesn't help us right now. The current patch is here:
Patch

I think we should be able to just use the hooks within fomantic-ui's dropdown.js to add the

Hmm does that patch cleanly apply on the current dropdown.js? If so, I suggest using git apply to patch the file on-the fly. I will make the upgrade to fomantic 2.8.8 easier if we can just apply a patch.

Note that the typo fixes that are reverted in this PR are fine, the files should not have been changed like that as they are essentially build artifacts. I patching fails because of these typo changes, revert the files to original build output before applying the patch.

Can you confirm that click handlers work for elements that supply its own click handler, like the contribution permissions dialogs?

In a lot of places comments are changed to wrong ones

In a lot of places comments are changed to wrong ones

These are autogenerated and vendored files. They are the result of make fomantic
The spelling changes that are occurring are because the spelling in these files should never have been changed.

Did not notice it's in build, looked like just strange changes in comments from correct to wrong wording 😅

Does v1.14 need a backport?

No, v1.14 is unaffected.

@lafriks / @a1012112796 you've both reviewed the backport, could you take a look at this PR?

I waited for it to be deployed to try.gitea.io, and I can confirm that keyboard navigation for dropdowns (e.g. the language selection) is working fine again and that a screen reader reads out the elements (compared to a few minutes before where it didn't), just as with Gitea 1.14.
I have been trying Gitea with a screen reader recently, and I can confirm it's not really optimal. I think I'll open a few issues for stuff I notice, maybe this helps at getting a first idea before asking external auditors, it might also save some money if stuff gets improved before (not sure).

Thank you very much! @zeripath


tests(gitreceive): remove duplicated tests

In the refactor of 67a9adbf9a7f18794106868065a06282c0dda1b6, some things were changed along with these tests, but they were never deduplicated. This should get these out.

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

Nice sleuthing. 🔎

Current coverage is 47.13% (diff: 100%)

Merging #420 into master will not change coverage

@@             master       #420   diff @@
==========================================
  Files            26         26
  Lines          1101       1101
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            519        519
  Misses          551        551
  Partials         31         31

Powered by Codecov. Last update a79f44d...97f0ce4


DSD-520: Small fix to the Icon storybook to update the 'title' prop

Fixes JIRA ticket DSD-520
This PR does the following:

Just forgot to add the right "args" to the Icon component to update the text in the <title> element.

How has this been tested?

Checklist:

[ ] I have updated the Storybook documentation accordingly.
[ ] All new and existing tests passed.

Front End Review:

[ ] View the example in Storybook

Tugboat has finished building the preview for this pull request!
Link:

https://pr753-bnqact8xmjhf8llykn7vwutxk4ee4xl9.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/61855395de49700ca9d94077

Tugboat has finished building the preview for this pull request!
Link:

https://pr753-bnqact8xmjhf8llykn7vwutxk4ee4xl9.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/61855395de49700ca9d94077


[SPARK-33386][SQL] Accessing array elements in ElementAt/Elt/GetArrayItem should failed if index is out of bound

What changes were proposed in this pull request?
Instead of returning NULL, throws runtime ArrayIndexOutOfBoundsException when ansiMode is enable for element_at，elt, GetArrayItem functions.
Why are the changes needed?
For ansiMode.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added UT and existing UT.

Test build #130781 has started for PR 30297 at commit d1e0ae3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35390/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35390/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35390/
Test PASSed.

Test build #130781 has finished for PR 30297 at commit d1e0ae3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class ElementAt(
case class GetArrayItem(
case class Elt(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130781/
Test PASSed.

cc @maropu

I think we need to update the ANSI doc accordingly if we change the behaviours: https://github.com/apache/spark/blame/master/docs/sql-ref-ansi-compliance.md#L110-L114 btw, is this change related to ANSI? The ANSI standard says something about these kinds of behaviours? @gengliangwang

Also, its better to update the doc of the ANSI config (e.g., 3. Spark will change the behavior of some SQL functions, e.g., size, ...), too.
https://github.com/apache/spark/blob/90f6f39e429e0db00e234bdcf679a70dfce3272e/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L2145-L2149

@maropu updated with all your comments, plz have a look when you have time. ^_^
And also FYI, @cloud-fan

Test build #130868 has started for PR 30297 at commit 7dcba56.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35475/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35475/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35475/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130868/
Test FAILed.

updated, @cloud-fan and @maropu

Test build #130909 has started for PR 30297 at commit f8cfa5b.

Test build #130911 has started for PR 30297 at commit 6109838.

Looks fine otherwise.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35515/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35517/

Test build #130917 has started for PR 30297 at commit a9312a0.

Test build #130917 has finished for PR 30297 at commit a9312a0.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130917/
Test FAILed.

Test build #130920 has started for PR 30297 at commit 6729d7b.

Test build #130909 has finished for PR 30297 at commit f8cfa5b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #130911 has finished for PR 30297 at commit 6109838.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130909/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130911/
Test FAILed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35515/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35515/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35517/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35517/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35522/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35522/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35522/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35525/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35525/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35525/
Test FAILed.

Test build #130920 has finished for PR 30297 at commit 6729d7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130920/
Test PASSed.

@leanken could you update the PR description. I think there is user-facing change when ANSI mode is enabled.

@sunchao @dongjoon-hyun @cloud-fan updated, resolved your comments.
1. fix GetArrayItem nullablity issue.
2. move DataFrameSuite code into array.sql and ansi/array.sql
3. add numElements to exception message.
4. other code refine.

@leanken could you update the PR description. I think there is user-facing change when ANSI mode is enabled.

updated.

Test build #130962 has started for PR 30297 at commit 36d235a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35568/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35568/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35568/
Test PASSed.

Test build #130968 has started for PR 30297 at commit 4b161a4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35574/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35574/

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35574/
Test FAILed.

Merged build finished. Test FAILed.

Test build #130968 has finished for PR 30297 at commit 4b161a4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #130962 has finished for PR 30297 at commit 36d235a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130968/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130962/
Test FAILed.

GA passed, merging to master, thanks!


Shell.make_shell returns Face

section = Rot(90)*CenterArc((0,0), 5, 90, 180)
path = Circle(5).wire()
shell = Shell.make_shell(sweep(section, path))
print(shell.shape_type())

Face

Shell creation uses the BRepBuilderAPI_Sewing class/SewedShape method the which has a complex return type of: a Face, a Shell, a Solid or a Compound. In this case make_shell (which is deprecated, use Shell(sweep(section,path))) is being asked to make a Shell out of a closed Compound/Face the result which can only be a single Face.
The Shell class could throw an error in this situation but that wouldn't be very helpful.  Do you have a preferred behaviour?

make_shell was deprecated a couple hours before this issue and Shell() has the same behavior. The issue is Solid(Shell()) is broken here #531

There is nothing that can be done, this is an OCCT limitation.


Prefer to use IPv4

now ipv6 first by default

Yes, please assign IPv6 IP address somewhere else or put it to another port

I don't want remove my IPv6 address, what's "put it to another port" mean? now I connect my vps via IPv4 address, but from vps connect to Telegram IP was via IPv6.

I do not ask you to remove your IPv6 address, I just ask to bind proxy to another port. Let's say, you have 2 open ports, 8000 and 8001. Then bind proxy to ipv4 protocol on the port 8000 and to ipv6 on the port 8001. Please see command-line help to get an idea.

ok, I will try it, thanks.

Hello @9seconds :
Can you fix this? https://github.com/9seconds/mtg/commit/422ed5b0716c07c17952af5273292aa303d53ac8#commitcomment-37315999

Yes, thanks for reopening! I've seen notification but could not find it so had an impression that you've deleted it. I will do in the next week for sure

Thank you, looking forward your new release. :)

Sorry for the delay. Unfortunately, I was too busy with my main work so I could not even start. I would like to tell that I do still remember about that issue and I do plan to fix it.

It's okay, you may finish your work on hand first. XD


ModuleNotFoundError: No module named 'dateparser'

I've pulled the latest update, ran the requirements.txt file.
When I run python3 scrapeScenes.py I'm getting the following error:
Traceback (most recent call last):
  File "/srv/dev-disk-by-label-data/users/alex/git/stash_theporndb_scraper/scrapeScenes.py", line 19, in <module>
    import StashInterface
  File "/srv/dev-disk-by-label-data/users/alex/git/stash_theporndb_scraper/StashInterface.py", line 8, in <module>
    import dateparser
ModuleNotFoundError: No module named 'dateparser'

The readme needs updated to reference:   "pip install requirements.txt -r"

If I run pip install requirements.txt -r I get the following message:
Usage:
  pip install [options] <requirement specifier> [package-index-options] ...
  pip install [options] -r <requirements file> [package-index-options] ...
  pip install [options] [-e] <vcs project url> ...
  pip install [options] [-e] <local project path> ...
  pip install [options] <archive url/path> ...

-r option requires 1 argument

If I try pip install -r requirements.txt I get this output
Requirement already satisfied: Pillow==9.0.0 in /srv/dev-disk-by-label-data/users/alex/.local/lib/python3.9/site-packages (from -r requirements.txt (line 1)) (9.0.0)
Requirement already satisfied: requests==2.27.1 in /srv/dev-disk-by-label-data/users/alex/.local/lib/python3.9/site-packages (from -r requirements.txt (line 2)) (2.27.1)
Requirement already satisfied: charset-normalizer~=2.0.0 in /srv/dev-disk-by-label-data/users/alex/.local/lib/python3.9/site-packages (from requests==2.27.1->-r requirements.txt (line 2)) (2.0.12)
Requirement already satisfied: certifi>=2017.4.17 in /usr/lib/python3/dist-packages (from requests==2.27.1->-r requirements.txt (line 2)) (2020.6.20)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in /usr/lib/python3/dist-packages (from requests==2.27.1->-r requirements.txt (line 2)) (1.26.5)
Requirement already satisfied: idna<4,>=2.5 in /usr/lib/python3/dist-packages (from requests==2.27.1->-r requirements.txt (line 2)) (2.10)

Then if I run python3 scrapeScenes.py I'm getting the same error as my initial post.

pip install dateparser
blame @Darklyter, he forgot update requirements.txt

That's fair


cyber: MockTime mode support

This PR was based on @rongguodong 's request on simulation time support for CyberRT.  Cf. #11808
Env vars and gflags were not used here.  Instead, cyber/conf/cyber.pb.conf  was the sole config file for specifying whether system(cyber)-clock or mock-clock should be used.
A clock node was created In cyber::init for each process.
Also notice there are time.h defs under modules/common/time, should we combine all these to provide a unified time model ?

What is reason to introduce a new class "cyber::Clock"? Why can't we directly add a mock mode in cyber::Time as in PR #11808?


UI object info with presigned support show presigned URL as physical address

Expected behaviour to show the entry physical address and not a presigned URL.

@nopcoder isn't it a duplication of this?

@nopcoder isn't it a duplication of this?

No, this one issue is related to what we disable on object information, while we request for object stat.
The issue #6702 copy presigned - should always request for presigned url or use the presigned information from the object list.


Shorten type hints for std::iter Iterators

Fixes #3750.
This re-exports the hir_expand::name::known module to be able to fetch the Iterator and iter names.
I'm not sure if there is anything to do with Solution::Ambig in normalize_trait_assoc_type or whether discarding those results is always wanted.

cc @SomeoneToIgnore

yup!
On Tue, 6 Oct 2020 at 20:25, Lukas Wirth<EMAIL_ADDRESS>wrote:

@Veykril commented on this pull request.
In crates/ide/src/inlay_hints.rs
https://github.com/rust-analyzer/rust-analyzer/pull/6154#discussion_r500507553
:

let iter_trait = module.scope(db, None).into_iter().find_map(|(name, def)| match def {

   hir::ScopeDef::ModuleDef(ModuleDef::Trait(r#trait)) if name == known::Iterator => {

       Some(r#trait)

   }

   _ => None,

})?;

FamousDefs is crate private, I assume making it pub for this should be
alright?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/pull/6154#discussion_r500507553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3MYLSKY4ELYY4SQN2Y3SJNOHZANCNFSM4SGJX2CQ
.

Is there a better way to check this? https://github.com/rust-analyzer/rust-analyzer/blob/821a55ff2f0c215e78dfbb29838bc0572f72e321/crates/ide/src/inlay_hints.rs#L224-L230

So sorry for the billion force-pushes I keep forgetting to run cargo test -p xtask to check for whitespaces 😅

no worries, force-pushes are OK!
On Tue, 6 Oct 2020 at 21:27, Lukas Wirth<EMAIL_ADDRESS>wrote:

So sorry for the billion force-pushes I keep forgetting to run cargo test
-p xtask to check for whitespaces 😅
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rust-analyzer/rust-analyzer/pull/6154#issuecomment-704503662,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANB3M6U7BS44JU5IJMTS6TSJNVQXANCNFSM4SGJX2CQ
.

Is there a better way to check this?

(I cannot reply to this question directly due to force pushes).
I believe the majority of this method will mutate into a more high-level function, returning the list of all impl Trait possible for the type given.
Yet this might not be feasible to do now before we decide what to do with the fact that we need 2 totally different places in the code to define Iter trait related data.

The iter structs comes from two module definitions, core::iter::sources and core::iter::adapters, so one possibility would be to check the types declaration module for these two, the other option would be to check if core::iter re-exports the type(which I am kinda doing there right now, just not in a nice way in my eyes). Hence my question if there was a better way to do this.

I wonder, if this is caused by some internal limit being too low?
This seems to be chalk failing at that depth, it returns Solution::Ambig with Unknown at that point.

Okay I think everything so far got addressed now 👍

Thanks for the fixes, the same place in RA now looks way nicer:

Interesting that there's a hint with FilterMap in the associated type, yet the Chalk limit is clearly not reached by this time.
Maybe we need to apply the same hint_iterator logic once more to the associated type.
But that can land in a different PR, I think no we have a good set up to iterate from already, thank you.
Chalk limits is also an interesting thing to tackle, the chaining hints loose their new appearance too fast IMO.
But I think we'd better to wait for issues on the topic with good test examples :)
bors r+


Added a subtask: TASK_COMPILE_WARP_GET_HASH

TASK_COMPILE_WARP_GET_HASH
Calculates and stores the hashes of the contracts and checks if they need compilation

I have made the changes and deleted the files, you can have a look.


StopIteration raised in Options ID code

Couldn't put together a simple example because I kept running into Issue #326, but it was essentially a very similar case to the example described there so maybe if that's resolved you'll be able to reproduce this bug. I'll include the full traceback so there's at least something to go on:
/Users/prudiger/topographica/external/holoviews/holoviews/ipython/display_hooks.pyc in pprint_display(obj)
    193     if not ip.display_formatter.formatters['text/plain'].pprint:
    194         return None
--> 195     return display(obj, raw=True)
    196
    197

/Users/prudiger/topographica/external/holoviews/holoviews/ipython/display_hooks.pyc in display(obj, raw, **kwargs)
    180         html = element_display(obj)
    181     elif isinstance(obj, (Layout, NdLayout, AdjointLayout)):
--> 182         html = layout_display(obj)
    183     elif isinstance(obj, (HoloMap, DynamicMap)):
    184         html = map_display(obj)

/Users/prudiger/topographica/external/holoviews/holoviews/ipython/display_hooks.pyc in wrapped(element)
    105             return html
    106         except Exception as e:
--> 107             StoreOptions.state(element, state=optstate)
    108             if ABBREVIATE_TRACEBACKS:
    109                 info = dict(name=type(e).__name__,

/Users/prudiger/topographica/external/holoviews/holoviews/core/options.pyc in state(cls, obj, state)
   1141             for key in current_custom_keys.difference(original_custom_keys):
   1142                 del Store.custom_options()[key]
-> 1143                 cls.restore_ids(obj, ids)
   1144
   1145     @classmethod

/Users/prudiger/topographica/external/holoviews/holoviews/core/options.pyc in restore_ids(cls, obj, ids)
    994         """
    995         ids = iter(ids)
--> 996         obj.traverse(lambda o: setattr(o, 'id', next(ids)))
    997
    998

/Users/prudiger/topographica/external/holoviews/holoviews/core/dimension.pyc in traverse(self, fn, specs, full_breadth)
    356         if self._deep_indexable:
    357             for el in self:
--> 358                 accumulator += el.traverse(fn, specs, full_breadth)
    359                 if not full_breadth: break
    360         return accumulator

/Users/prudiger/topographica/external/holoviews/holoviews/core/dimension.pyc in traverse(self, fn, specs, full_breadth)
    356         if self._deep_indexable:
    357             for el in self:
--> 358                 accumulator += el.traverse(fn, specs, full_breadth)
    359                 if not full_breadth: break
    360         return accumulator

/Users/prudiger/topographica/external/holoviews/holoviews/core/dimension.pyc in traverse(self, fn, specs, full_breadth)
    356         if self._deep_indexable:
    357             for el in self:
--> 358                 accumulator += el.traverse(fn, specs, full_breadth)
    359                 if not full_breadth: break
    360         return accumulator

/Users/prudiger/topographica/external/holoviews/holoviews/core/dimension.pyc in traverse(self, fn, specs, full_breadth)
    351                 if matches: break
    352         if matches:
--> 353             accumulator.append(fn(self))
    354
    355         # Assumes composite objects are iterables

/Users/prudiger/topographica/external/holoviews/holoviews/core/options.pyc in <lambda>(o)
    994         """
    995         ids = iter(ids)
--> 996         obj.traverse(lambda o: setattr(o, 'id', next(ids)))
    997
    998

StopIteration:

Issue #326 is now fixed so please try again! I am hoping this issue is also fixed as a result, but if not, a small example to illustrate the issue would be very helpful.

Seems to be fixed now. Closing.


Fix error with domain "."

Another way

will also fail with ..string

`root@opnsense:~ # grep blackList /usr/local/etc/squid/squid.conf
ACL - Blacklist - User defined (blackList)
acl blackList url_regex xn--tst-qla.de
acl blackList url_regex .xn--tst-qla.de
acl blackList url_regex .
acl blackList url_regex ..xn--tst-qla.de
http_access deny blackList
`

Any idea when this fix will be integrated to opnsense ?

There is a patch in the 18.7 series. You can always install it manually from https://github.com/opnsense/core/commit/9ad0cbc1 via
# opnsense-patch 9ad0cbc1

https://github.com/opnsense/core/commit/2be29a51fffbc9e5b98011d382831fbe9c5c945c should handle the issue with multiple leading dots.

After add "facebook.com" and ".facebook.com", the proxy service wasn't want to start :/ (with or without this fix)
Version : OPNsense 18.1.13-amd64

Jul 26 10:31:30 	root: /usr/local/etc/rc.d/squid: WARNING: failed to start squid
Jul 26 10:31:30 	squid: Bungled /usr/local/etc/squid/squid.conf line 27: acl bump_nobumpsites ssl::server_name "/usr/local/etc/squid/nobumpsites.acl"

@tech62 this specific example has no relation with this fix, probably another configuration issue.

My bad, i've read "Fix error with domain "." and my proxy crashed when i type a domain with a dot at the start of the domain name like ".facebook.com"  in the sslbump field - hense the reaseon for my confusion
It's a fresh install and if i let this field empty, the proxy works.
Thanks for your help !


Custom fetch/XMLHttpRequest when submitting (was: how to implement progress bar for file uploading)

Hello, can we implement a progress bar with superforms?
I didn't find anything on the web.

I need this too - any solutions?

I need this too - any solutions?

You can use xmlhttprequest to do this and use progress event

How do we do this in the context of Superforms? I've scoured over the docs, and there doesn't seem to be any way to intercept the submit handler while still utilizing use:enhance. SvelteKit itself always calls fetch and there doesn't appear to be any way of stopping it.

That's right, as Superforms is utilizing the SvelteKit fetch, it's not possible to do it easily. What you can do is to call cancel in onSubmit, then create the xmlhttprequest yourself and handle the progress.
It's not a bad feature really, so maybe it can be added to the library. There are already two "modifier functions" for the onSubmit event, jsonData and validators. A customRequest function could be added that will replace the default fetch.

Added now with v2.16.0: https://superforms.rocks/concepts/events#customrequest

Damn! That was fast. Thanks!

It works great if it's just one file, but it would be interesting to listen to events coming from the server.
My +page.server.ts sends multiple files to cloudflare's R2, and I have some functions that return the upload progress of each file and the id.
I'm new to Svelte, haven't yet figured out a method to send this information to +page.svelte and update the items on the page.
Is there any way to do this without using websocket?
+page.server.ts
...
const organizedFiles = await organizeFiles(files, (index, percentage) => {
       console.log(`File ${index + 1}: ${percentage}% uploaded`);
});


How to get to the expenses page

Problem
I go to https://opencollective.com/secure-scuttlebutt-consortium and I want to see if there are any invoices to approve, I want to go to the expenses page ... I scroll down and see a bunch of stuff I don't want / need as an admin, then I see a summary of things which have been paid but no clear indication of whether there are any outstanding.
current solution ... remember I need to go to https://opencollective.com/secure-scuttlebutt-consortium/expenses  ):
Possible solutions

if there are no expenses to approve, say that
create a section of "admin/ coordinator" actions which includes:

edit collective
approve expenses

said differently : as an admin, when I land on the page I want the tools I'm going to use immediately visible. I don't want to go scrolling looking for things, and I don't want to have to rely on my memory or bookmarks

As a host admin, I use a whole list of saved URLs in a document, because it's so many clicks to get to the page to manage the expenses approvals and payments. So I agree the current design isn't ideal.

yeah finding people using hacks is usually a really great validation that there's a new feature or different design emerging

cc/ @cuiki Please take this into account when we re-design the page.
A link to the host dashboard is also needed.

Will this be fixed on the new Collective page?

Yes, @alannallama . :)

reopening this as it's still an issue.
@lindatalu please only close issues created by design, not issues tagged design thank you!

This should be resolved in the new collective page where we implemented a View all expenses button.

Sweet, thank you.
Design feedback : I see two sorts of filter active in this design

How much do you want to see? (recent/all)
What sorts of transactions do you want to see (transactions/ expenses)

As a collective admin I always have to pause and think what the
relationship between transactions and expenses is. I want it to be clearer
by e.g.

showing me which filter is currently active (I think by default it's
transactions yeah?)
use different language like "all transactions" and "just expenses"
have 3 options : all / contributions / expenses

Messing with these filters collides with the "show all X" "show all Y"
design. I think that should be replaced with a "Show more" button which
takes you to a full page which has the same filters for exploring the data
(all / contributions / expenses) .
On Fri, Dec 13, 2019, 04:03 Benjamin Piouffle<EMAIL_ADDRESS>wrote:

This should be resolved in the new collective page where we implemented a View
all expenses button.
[image: image]
https://user-images.githubusercontent.com/1556356/70723289-f1a7e200-1cf8-11ea-9eeb-c884e2fd92b7.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opencollective/opencollective/issues/1428?email_source=notifications&email_token=AAUK3HVEKN6VGM7MZVP5JQ3QYJHFDA5CNFSM4GDBWQAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGW6GII#issuecomment-565044001,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUK3HQBCCS4ZYW3BJQKAWTQYJHFDANCNFSM4GDBWQAA
.

The one you're talking about is slightly different than what's discussed in this issue: it's the section displayed on your user profile (ie. https://opencollective.com/betree#section-transactions), not the collective budget (ie. https://opencollective.com/secure-scuttlebutt-consortium#section-budget).

Messing with these filters collides with the "show all X" "show all Y"
design. I think that should be replaced with a "Show more" button which
takes you to a full page which has the same filters for exploring the data
(all / contributions / expenses).

I agree, #2434 was started with this intent. We still need an input from the design team to go ahead with this change but that's something we want to do.

Oh, I've never seen the user profile! (eg
https://opencollective.com/betree#section-transactions).
That's exactly what I want.
On Fri, Dec 13, 2019, 04:42 Benjamin Piouffle<EMAIL_ADDRESS>wrote:

The one you're talking about is slightly different than what's discussed
in this issue: it's the section displayed on your user profile (ie.
https://opencollective.com/betree#section-transactions), not the collective
budget (ie.
https://opencollective.com/secure-scuttlebutt-consortium#section-budget).
Messing with these filters collides with the "show all X" "show all Y"
design. I think that should be replaced with a "Show more" button which
takes you to a full page which has the same filters for exploring the data
(all / contributions / expenses).
I agree, #2434
https://github.com/opencollective/opencollective/issues/2434 was
started with this intent. We still need an input from the design team to go
ahead with this change but that's something we want to do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opencollective/opencollective/issues/1428?email_source=notifications&email_token=AAUK3HQ4FU3OMYLJ62MOBSTQYJLV7A5CNFSM4GDBWQAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGXCMAY#issuecomment-565061123,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUK3HX5R6PA6UUSV27XCJTQYJLV7ANCNFSM4GDBWQAA
.


🌱  Use k8s apimachinery scheme builder instead of controller-runtime scheme builder

This is recommend for the CAPI providers as mentioned the v1.5 to v1.6 migration guide: https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.5-to-v1.6#suggested-changes-for-providers.
The original issue was discussed in https://github.com/kubernetes-sigs/cluster-api/issues/9011. The issue is using controller-runtime based scheme builder causes a lot of unnecessary dependancies added in go modules. Compared to that apimachinery was chosen as a better alternative.

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

/keep-test-ubuntu-integration-main

/keep-test-ubuntu-integration-main

/test-ubuntu-integration-main

/override keep-test-ubuntu-integration-main

I see this did not affect the go modules. Should we update/clean them also, or do we still depend on the controller-runtime scheme builder is some place?

I see this did not affect the go modules. Should we update/clean them also, or do we still depend on the controller-runtime scheme builder is some place?

As it is not affecting the go modules and test with gomod is passing. We can take this in.

I see this did not affect the go modules. Should we update/clean them also, or do we still depend on the controller-runtime scheme builder is some place?

Yes, I wondered the same. My understanding is we didnt directly imported any module named sigs.k8s.io/controller-runtime/pkg/scheme which we removed here, rather we use sigs.k8s.io/controller-runtime  module and that is something which is still used so no change in go module.


Failure during statistics sync [2h]

Problem is with HC that got no family planning measurements, and therefore stats generated for it is NULL.
When we return empty result, the response is not as expected:

So, there're 2 things to fix:

Make sure proper empty result is returned.
When a component of statistics object is calculated, and is an empty array, return that object as empty, and not whole statistics.

@adamhstewart Fix for point 1 (#444) deployed to live.


help

thanks your code. and i have some confusion of this code. in this paper, student(target) and teacher(target) have different augmentation, dropout and noise parameters. but i think there are the same setting both student and teacher in the code.

The critical lines are:

line 431; the call to the map method of the data source. This invokes the augment function on each mini-batch.
line 230; the augment function takes the source and target domain samples, within which on line 232 the code X_tgt_stu, X_tgt_tea = tgt_aug.augment_pair(X_tgt) augments the target sample twice, with different random parameters; once for the student and once for the teacher.


Remove Dependency of JQuery

Is it time to remove dependency of JQuery?

I may be time, but reworking all JS now doesn't make any sense

@hismichael We are currently working on Foundation 7, with a new architecture that would allow you to work rely or not on jQuery (or any other framework).

@ncoden when will that be released? There are some fabulous patterns in Foundation. As a long time advocate of NOT using frameworks, Foundation may be the ONLY one I ever recommend to people, with this MAJOR drawback—it relies on an antiquated, monstrous library which I never want to include in any repository.
So removing jQuery would be a major win. When will Foundation 7 be released?

@arxpoetica  the work on v7 has not yet started but we will start with it very soon.

It's 2 years later now, can you please drop some info about the current status of Foundation 7 ? I'm writing here into this closed ticket as it's the #1 Google hit for "Foundation 7" for me, and I cannot see a v7 branch or so.
Do you need any volunteers, I'm all-in ? :)
Thanks for an great framework, love it!

Hi @panique

It's 2 years later now, can you please drop some info about the current status of Foundation 7 ?

No news so far.

Do you need any volunteers, I'm all-in ? :)

Any help is very welcome.


Detection and Workbook for customers using Eaton Foreseer application

Required items, please complete
Change(s):

Created a new Sentinel Solution - EatonForeseer

Reason for Change(s):

Adding health and security visibility for customers using Eaton Foreseer

Version Updated:

Yes. New Detection.

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Hey @kushaljh, can you please confirm is this pull request  still in progress? Because it is still in draft?

Hey @kushaljh, can you please confirm is this pull request still in progress? Because it is still in draft?

@v-sabiraj Thank you for checking in. This PR is ready for review.

Hey @aprakash13, can you please review Analytic Rules, thanks.

Hey @kushaljh, Workbook looks good, will you just rename the preview images with black and white rather than dark and light, e.g. EatonForeseerHealthAndAccessBlack.png for black (dark) image and EatonForeseerHealthAndAccessWhite.png for white (light) image, thanks.

Hey @aprakash13, will you please review and approve the changes done, thanks.

Hey @kushaljh, Workbook looks good, will you just rename the preview images with black and white rather than dark and light, e.g. EatonForeseerHealthAndAccessBlack.png for black (dark) image and EatonForeseerHealthAndAccessWhite.png for white (light) image, thanks.

Thank you for reviewing the workbook @v-sabiraj
I have updated the names as requested

@v-sabiraj
Can we get an approving reviewer to review this PR?


[FEATURE] Go down btn on chat

Description
Instead of going to the top I think it would be better to have a button that take the user to start of chat or at the bottom of page.
Screenshots

Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Description
Instead of going to the top I think it would be better to have a button that take the user to start of chat or at the bottom of page.
Screenshots

Additional information
No response
Record

[x]  I agree to follow this project's Code of Conduct
[x]  I have checked the existing issues
[x]  I'm a GSSoC'23 contributor
[x]  I want to work on this issue

correct, you can work on this!

Hey, I would like to contribute please assign this issue to me.

Instead of going to the top I think it would be better to have a button that take the user to start of chat or at the bottom of page.

Sure, go ahead!

Hey, I would like to contribute please assign this issue to me

I am extremely sorry I thought we had to use HTML,CSS,JS for this issue but this require react and I don't know React.

Hey, I would like to contribute please assign this issue to me

I am extremely sorry I thought we had to use HTML,CSS,JS for this issue but this require react and I don't know React.

It's alright :)

Hello, @Nupoor10  can you assign me. The top btn is collapseing with profile card I want to use react usestate hooks, when the scroll is top button disappears and appears when in bottom appears


Validating that all the climate laws urls have documents stored in s3.

Description
Please include:

a summary of the changes
links to any related issue/ticket
any additional relevant motivation and context
details of any dependency updates that are required for this change

Type of change
Please select the option(s) below that are most relevant:

[ ] Bug fix
[X] New feature
[ ] Breaking change

How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist

[ ] The PR represents a single feature (small driveby fixes are also ok)
[ ] The PR includes tests that are sufficient for the level of risk
[ ] The code is sufficiently commented, particularly in hard-to-understand areas
[ ] Any required documentation updates have been made
[ ] Any TODOs added are captured in future tickets
[ ] No FIXMEs remain

The checks are already useful though, so maybe we can get this merged as a first pass?


refactor all

1, support pipeline;
2, restructure code.

Coverage increased (+0.9%) to 81.276% when pulling 820213ae866bfc0a80205c8f79a471e755d2b05b on parser into 799fcd93866ca4e3f56dce420d2c07ca64f2386f on master.


Implement basic Lua bindings

closes #158

Test failures expected. Not ready for review yet.

If tests pass on CI, this should be good to land.

Does anyone have a few mins to look over this PR?
It's pretty similar in approach to the Ruby bindings,

Looks good