HARP-9576 Fix styling data-driven example

Change to display of city population (countries do not contain population in new data source).
Fix MapView.disableFadeIn option.
Implement textFadeTime and iconFadeTime.

Signed-off-by: Marcel Pursche<EMAIL_ADDRESS>Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:

contribution guidelines
coding style

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.
Happy contributing!

GPU tests please

Thanks for finding and fixing an error I introduced!

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@541b5c1). Click here to learn what that means.
The diff coverage is 87.50%.

@@            Coverage Diff            @@
##             master    #1449   +/-   ##
=========================================
  Coverage          ?   56.02%
=========================================
  Files             ?      260
  Lines             ?    24076
  Branches          ?     5400
=========================================
  Hits              ?    13488
  Misses            ?    10588
  Partials          ?        0

Impacted Files
Coverage Δ

...e/harp-mapview/lib/geometry/TileGeometryCreator.ts
43.08% <0.00%> (ø)

@here/harp-mapview/lib/text/TextElement.ts
86.84% <ø> (ø)

@here/harp-mapview/lib/text/RenderState.ts
98.66% <100.00%> (ø)

@here/harp-mapview/lib/text/TextElementState.ts
100.00% <100.00%> (ø)

...here/harp-mapview/lib/text/TextElementsRenderer.ts
66.42% <100.00%> (ø)

@here/harp-mapview/lib/poi/PoiRenderer.ts
11.20% <0.00%> (ø)

...-datasource-protocol/lib/operators/MapOperators.ts
28.20% <0.00%> (ø)

...atasource-protocol/lib/operators/ArrayOperators.ts
96.15% <0.00%> (ø)

@here/harp-lrucache/lib/LRUCache.ts
92.21% <0.00%> (ø)

... and 255 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 541b5c1...7409982. Read the comment docs.


Exception has occurred: KeyError in Tensor.py

Hi there!
I wanna run an example from this tutorial
Firstly I've got an error but that was fixed by adding this line:
tf.enable_eager_execution()
I downloaded French - English dataset
Then script was built successfully but at the end I've got another error:
Exception has occurred: KeyError
'desole'
  File "C:\Users\xxx\Python\Tensor.py", line 314, in <listcomp>
    inputs = [inp_lang.word_index[i] for i in sentence.split(' ')]
  File "C:\Users\xxx\Python\Tensor.py", line 314, in evaluate
    inputs = [inp_lang.word_index[i] for i in sentence.split(' ')]
  File "C:\Users\xxx\Python\Tensor.py", line 366, in translate
    result, sentence, attention_plot = evaluate(sentence)
  File "C:\Users\xxx\Python\Tensor.py", line 377, in <module>
    translate(u'Je suis désolé, mais je ne peux pas répondre tout de suite.')

This error occurs on this line:
translate(u'Je suis desole, mais je ne peux pas repondre tout de suite .')
Implementation of this function you can get from tutorial above.
System information
OS: latest Windows 10 build;
TensorFlow: 1.14.0;
Python: 3.7.3;
[MSC v.1916 64 bit (AMD64)];
CPU: AMD Ryzen 7 2700x;
GPU: NVidia GeForce GTX 1050 Ti.
If you need some additional info, I will provide it.
Help me please to solve this issue or tell me where I'm doing something wrong.

Perhaps you can try this tutorial with TF 2.X version as mentioned in the colab.

Perhaps you can try this tutorial with TF 2.X version as mentioned in the colab.

Thanks for reply!
I found that I had some issues with versions of TF. I fixed it but described issue is still appearing.

@iSapGod
Looks like some words are missing in your dataset. Please, include those words and try again.Thanks!

@ravikyram
Thanks for reply.
Yeah, I thought about it too. But then I just used sentences from dataset, and nothing changed.

@jvishnuvardhan
This issue occurs only after model is trained and trying to get some results. All code is provided via link above (actually, code hasn't a lot of lines)

@iSapGod I ran it with T2.0 without any issues. Here is the gist. One modification I made was uploading fra.txt to colab and read it from there. Please check the gist and let me know if you see anything missing.
When you respond or create a new TF issue, Please provide a simple standalone code (the current code (tutorial) is too long and requires lot of efforts to resolve). If you provide simple standalone code, then it is easy for localizing the issue faster. Thanks again.!

Automatically closing this out since I understand it to be resolved, but please let me know if I'm mistaken.Thanks!

please help me i have the same error
def evaluate(sentence):
attention_plot = np.zeros((max_length_targ, max_length_inp))
sentence = preprocess_sentence(sentence)
inputs = [inp_lang.word_index[i] for i in sentence.split(' ')]
inputs = tf.keras.preprocessing.sequence.pad_sequences([inputs],
maxlen=max_length_inp,
padding='post')
inputs = tf.convert_to_tensor(inputs)
result = ''
hidden = [tf.zeros((1, units))]
enc_out, enc_hidden = encoder(inputs, hidden)
dec_hidden = enc_hidden
dec_input = tf.expand_dims([targ_lang.word_index['']], 0)
for t in range(max_length_targ):
predictions, dec_hidden, attention_weights = decoder(dec_input,
dec_hidden,
enc_out)
# storing the attention weights to plot later on
attention_weights = tf.reshape(attention_weights, (-1, ))
attention_plot[t] = attention_weights.numpy()

predicted_id = tf.argmax(predictions[0]).numpy()

result += targ_lang.index_word[predicted_id] + ' '

if targ_lang.index_word[predicted_id] == '<end>':
  return result, sentence, attention_plot

KeyError                                  Traceback (most recent call last)
 in ()
----> 1 translate(u'Trois')
2 frames
 in (.0)
4   sentence = preprocess_sentence(sentence)
5
----> 6   inputs = [inp_lang.word_index[i] for i in sentence.split(' ')]
7   inputs = tf.keras.preprocessing.sequence.pad_sequences([inputs],
8                                                          maxlen=max_length_inp,
KeyError: 'trois'

@laurianekoffi As closed issue was an old issue, can you please open a new issue with a simple standalone code to reproduce the issue? Thanks!


ReadFile Hook not working.

BOOL WINAPI MyReadFile(HANDLE hFile,LPVOID lpBuffer,DWORD nNumberOfBytesToRead,LPDWORD lpNumberOfBytesRead,LPOVERLAPPED lpOverlapped)
{
ReadFile(hFile, lpBuffer, nNumberOfBytesToRead, lpNumberOfBytesRead, lpOverlapped);
MessageBox(NULL,(LPCSTR) lpBuffer,"read file",NULL);
return ReadFile(hFile, lpBuffer, nNumberOfBytesToRead, lpNumberOfBytesRead, lpOverlapped);
}
first read file gives me text written in file and save to lpBuffer and load text in notepad. i wants to load some other text in notepad not that is written in file but it is not working how to do this. if i write this
ReadFile(hFile, "some other text", nNumberOfBytesToRead, lpNumberOfBytesRead, lpOverlapped);
but it not works

You don't need to call the original to change the data returned. The buffer is a pointer, so just fill that buffer with what you want to return (ensuring it doesn't exceed nNumberOfBytesToRead).

void WINAPI MyReadFile(HANDLE hFile,LPVOID lpBuffer,DWORD nNumberOfBytesToRead,LPDWORD lpNumberOfBytesRead,LPOVERLAPPED lpOverlapped)
{
//original content size is 5
LPVOID	newbuffer = "Some";
memcpy(lpBuffer, newbuffer, 4);
*lpNumberOfBytesRead = 4;
}
but it is not working too.it shows original content from file


Scriptable tool

Just finished writing my heart out so this is probably going to be a meh idea.
What this would do is allow the user to use a tool-gun that can have a starfall script uploaded to it.
It would be a starfall implementation of this
Similar to a the way screens currently work it would be able to have client and server code.
Dunno what else to write so here we go.

This would tie in nicely once we've abstracted the Instance away from GM ents, as it would essentially then just be an entity container. Aslong as you expose and interface to the TOOLS functions, should be fine.
Obviously more discussion on what purpose this toolgun would serve, and whether it's something users would want, should be had. Flesh out the idea more etc.

:+1: straight away. Sounds awesome, I'm sold :P


Output seems to be missing/wrong in PHP 7.1

Running on PHP 7.1 results in the subsequent ilammy/msvc-dev-cmd being unhappy, I'm guessing it's the toolset output is not acceptable perhaps?
Example build: https://github.com/scoutapp/scout-apm-php-ext/runs/6881900710?check_suite_focus=true
Run ilammy/msvc-dev-cmd@v1
Found with vswhere: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat
Error: Could not setup Developer Command Prompt: invalid parameters
[ERROR:vcvars140.bat] VC++ 14.0 Toolset Installation was not found. Init did not complete successfully.
[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
[ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
[ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
[ERROR:VsDevCmd.bat] Where [value] is:
[ERROR:VsDevCmd.bat]    1 : basic debug logging
[ERROR:VsDevCmd.bat]    2 : detailed debug logging
[ERROR:VsDevCmd.bat]    3 : trace level logging. Redirection of output to a file when using this level is recommended.
[ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
[ERROR:VsDevCmd.bat]          vsdevcmd.bat > vsdevcmd.trace.txt 2>&1

Example usage:
jobs:
  windows-test:
    name: "Build and test on Windows"
    defaults:
      run:
        shell: cmd
    strategy:
      fail-fast: false
      matrix:
        version: [ "8.1", "8.0", "7.4", "7.3", "7.2", "7.1" ]
        arch: [ x64, x86 ]
        ts: [ ts, nts ]
    runs-on: windows-latest
    steps:
      - uses: actions/checkout@v2
      - name: Setup PHP SDK
        id: setup-php
        uses<EMAIL_ADDRESS>        with:
          version: ${{matrix.version}}
          arch: ${{matrix.arch}}
          ts: ${{matrix.ts}}
      - name: Enable Developer Command Prompt
        uses: ilammy/msvc-dev-cmd@v1
        with:
          arch: ${{matrix.arch}}
          toolset: ${{steps.setup-php.outputs.toolset}}

The problem is that the 14.0 (aka v140) toolset is not available on the hosted windows-2022 images (windows-latest is currently an alias of windows-2022). I don't think there's anything I can do, except to document the issue. If you need builds for PHP < 7.2, use the windows-2019 images (runs-on: windows-2019); that should work for all other PHP versions, too, and don't have any drawbacks for now. Visual Studio 2022 will likely only be required for PHP 8.3, and I assume that windows-2019 will be supported for several years.

Yeah I think docs update is all that's needed there - see #11 for a proposal - thank you!


Should the headers like x-correlator be included in OAS definition?

Problem description
Proble occured in conversation to PR https://github.com/camaraproject/Commonalities/pull/88
Currently the table in API Design Guidelines "Required in OAS Definition" states "No" for both "X-Correlator" and "X-Version"
X-Correlator header is included in some CAMARA API definitions.
In section 3.5 in relation to security related headers guidelines are:

To avoid cluttering the CAMARA OAS (Swagger) definition files, the above headers must not be included explicitly in the API definition files even when supported, as it can be assumed that developers will already be familiar with their use.

Expected action
The column "Required in OAS Definition" should rather be "Included in OAS Definition" and binding for all CAMARA APIs.
Or the whole section 9. Architecture Headers can be integrated within section 3.5.
Additional context
The more common names for header used to correlate HTTP requests between a client and server are X-Correlation-ID or Correlation-ID
https://en.wikipedia.org/wiki/List_of_HTTP_header_fields

Hi @rartych ,
From Telefonica , we are requesting an altenative method to inform to the consumers that the x-orrelator header are available to be used in the OAS3. That's what we are waiting for... we have not received any contingency, then we are still maintaining the definition till we agree an alternative.
I Know that the x-correlator is defined in the column "Required in OAS Definition"  as NO, but not required does not mean "forbidden"
Hope you know what I meaning.

Whatever the solution. We must ensure operability across operators. Developers should not need to change their headers for any API to work on different operators.

Given that X-Correlator is not standard and requires value checking, as it must be a UUID, I think the simplest approach for both API consumers and implementors is to explicitly include this header in the OAS definition. It will not add too much clutter.
Bur X-Version should be deleted or, at least, not mandatory to include or support, as nobody seems to know what this is for.


feat: upstreamProxy config option to deal with proxies

I have a use case where I can only load content via a web proxy that I don't control. This web proxy prepends a directory to the front of URLs which breaks the internal urls inserted by the Karma middleware.
This pull request adds an upstreamProxy option that allows the additional proxy path to be configured and used in URLs. To complete the use cases and implement e2e tests I also added hostname, port and protocol fields to use in launchers to point them at the proxy.
This is my first contribution here so please be gentle ;)

@pghalliday thanks, this looking really good :) some small nitpicks but other than that great work !

Note that I just raised another PR to solve the same problem but differently (#2213). I'm not sure which would be preferred. Personally I'm a little conflicted. The other PR that converts everything to relative URLs seems cleaner but the approach here seems more explicit

I didn't split up the core_steps.js - my initial attempts seemed to open something of a rabbit hole. However I did refactor the proxy stuff after figuring out the World object and After hooks

Sorry for the delay, could you rebase this onto the latest master please?

no problem, rebased

Gah, that travis failure on Node 5 doesn't happen locally :( Also I don't see how it's related to this change

I restarted it, lets see if it gets happier

thx, that fixed it :)

Thank you :octocat:

Cool, thanks :)


Abort connection on error

Problem
If the backend server of twemproxy down, twemproxy sends an error message like -ERR Host is down.
However, some of the client library ( in our case phpredis ) cannot recognize it as an error but ignores it.
Solution
If the error occurred on the backend of twemproxy, twemproxy sends RST packet back to the client,
so that the client can raise an exception correctly.
Result
The client library (phpredis) now throws an exception when redis, which is our backend of twemproxy, is down.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: katsew:x: axotYou have signed the CLA already but the status is still pending? Let us recheck it.

Sorry, wrong repo to send PR.


Colab Problem

I get the following error when I do "start trainig" even though I've given it my hugging face login. Am I doing something wrong?
Namespace(H=800, O=True, O2=False, W=800, albedo_iters=15000, angle_front=30, angle_overhead=30, backbone='grid', bg_radius=1.4, bound=1, ckpt='scratch', cuda_ray=True, density_thresh=10, dir_text=True, dt_gamma=0, eval_interval=10, fovy=60, fovy_range=[40, 70], fp16=True, gui=False, guidance='stable-diffusion', h=64, iters=5000, lambda_entropy=0.0001, lambda_orient=0.01, light_phi=0, light_theta=60, lr=0.001, max_ray_batch=4096, max_spp=1, max_steps=1024, min_near=0.1, num_steps=128, radius=3, radius_range=[1.0, 1.5], save_mesh=True, seed=0, test=False, text='a DSLR photo of a pineapple', update_extra_interval=16, upsample_steps=0, w=64, workspace='trial')
NeRFNetwork(
  (encoder): GridEncoder: input_dim=3 num_levels=16 level_dim=2 resolution=16 -> 2048 per_level_scale=1.3819 params=(6119864, 2) gridtype=tiled align_corners=False
  (sigma_net): MLP(
    (net): ModuleList(
      (0): Linear(in_features=32, out_features=64, bias=True)
      (1): Linear(in_features=64, out_features=64, bias=True)
      (2): Linear(in_features=64, out_features=4, bias=True)
    )
  )
  (encoder_bg): FreqEncoder: input_dim=2 degree=6 output_dim=26
  (bg_net): MLP(
    (net): ModuleList(
      (0): Linear(in_features=26, out_features=64, bias=True)
      (1): Linear(in_features=64, out_features=3, bias=True)
    )
  )
)
[INFO] successfully loaded hugging face user token!
[INFO] loading stable diffusion...
---------------------------------------------------------------------------
HTTPError                                 Traceback (most recent call last)
[/usr/local/lib/python3.7/dist-packages/huggingface_hub/utils/_errors.py](https://localhost:8080/#) in hf_raise_for_status(response, endpoint_name)
    212     try:
--> 213         response.raise_for_status()
    214     except HTTPError as e:

7 frames
HTTPError: 403 Client Error: Forbidden for url: https://huggingface.co/CompVis/stable-diffusion-v1-4/resolve/main/vae/diffusion_pytorch_model.bin

The above exception was the direct cause of the following exception:

HfHubHTTPError                            Traceback (most recent call last)
HfHubHTTPError: <class 'requests.exceptions.HTTPError'> (Request ID: Dk1dugtFYnhavLD2yWsHj)

During handling of the above exception, another exception occurred:

OSError                                   Traceback (most recent call last)
[/usr/local/lib/python3.7/dist-packages/diffusers/modeling_utils.py](https://localhost:8080/#) in from_pretrained(cls, pretrained_model_name_or_path, **kwargs)
    354             except HTTPError as err:
    355                 raise EnvironmentError(
--> 356                     "There was a specific connection error when trying to load"
    357                     f" {pretrained_model_name_or_path}:\n{err}"
    358                 )

OSError: There was a specific connection error when trying to load CompVis/stable-diffusion-v1-4:
<class 'requests.exceptions.HTTPError'> (Request ID: Dk1dugtFYnhavLD2yWsHj)

@Delta-Ark Hi, I think it is related to this,

That fixed it! It could run!


chore: bump metallb to v0.13.5 to support k8s v1.25

This PR bumps the metallb manifest to use v0.13.5 which drops usage of pod security policy (which is unavailable in k8s v1.25+).
Initially I wanted to avoid using the IPAddressPool but on the kind cluster that I performed the testing the services would never get the IPs.
Fixes #364
Probably we should use a different mechanism of deployment, not using kubectl (like mentioned  in the comment in metallb addon's source code).

Codecov Report

Merging #371 (3dfaa4a) into main (3fcbadf) will decrease coverage by 0.48%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #371      +/-   ##
========================================
- Coverage   9.05%   8.57%   -0.49%
========================================
  Files          5       5
  Lines        784     828      +44
========================================
  Hits          71      71
- Misses       708     752      +44
  Partials       5       5

Impacted Files
Coverage Δ

pkg/clusters/addons/metallb/metallb.go
2.03% <0.00%> (-0.59%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Implemented some HashMap operations. Added TODOs

@ruslansennov Could you review the changes, please? E.g. the dropXxx methods. Is it how you would do it?
If @patrox is ok with it, you may implement more methods...

I will pull it. Comments are welcome.

you may implement more methods

OK, I'II implement this

:+1:


Replacing courses for registered users

I want to know if there is a way for registered users to replace some curriculum courses, for example CS50 replaced MIT introductory course and Nand to Tetris, how can a registered user replace such courses?

@AlaaAshraf please, open your issue here. This is the repo for the web app.
Thank you! :pray:


Turn bookmarks back on

refs #567

Coverage remained the same at 100.0% when pulling 39481e0eef9eb65f84d3467cac59b238c0134066 on 567-bookmarks-2 into 60a2f12ae8e34f540d4b5aea75a9aaffe74b9dec on master.

This works, but bookmarks aren't saved in context of their exhibit. Is that a problem we want to look at? Maybe a follow-on ticket?

I'm not sure how important this is — maybe @kelea99 has an opinion on this?  Since the item pages link to the exhibits they are members of, maybe that's enough?

I don’t believe it is that important to know what exhibit the items come from, since they are tagged with the collections they are a part of and it’s viewable in the metadata. At least that’s my two cents.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Esmé Cowles<EMAIL_ADDRESS>Sent: Monday, September 16, 2019 7:04:36 PM
To: pulibrary/pomegranate<EMAIL_ADDRESS>Cc: Kimberly E. Leaman<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [pulibrary/pomegranate] Turn bookmarks back on (#605)
I'm not sure how important this is — maybe @kelea99https://github.com/kelea99 has an opinion on this? Since the item pages link to the exhibits they are members of, maybe that's enough?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/pulibrary/pomegranate/pull/605?email_source=notifications&email_token=AKXU2RQPSALBW6VF4KHKW5TQKAGIJA5CNFSM4IXCJSSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62YV7Q#issuecomment-531991294, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKXU2RXCSPCI7G663GRYVG3QKAGIJANCNFSM4IXCJSSA.

It's more than just what exhibit it came from, though; the metadata customizations are per-exhibit. E.g. The 'curatorial note' would not show, or any other metadata choices that had been made. Probably also the title overrides. It could be sort of confusing to people.
And if they want to get back to the view of the item in the context of the collection, it's probably not clear how they would do that. They would have to go to the collection then search again for the item there.
I understand why things are different depending on the collection context, but I do worry that it's confusing for people.
Just wanted to make sure the concern was entirely clear. If y'all still think it's not important I am on board! If we do want to address it, I would vote for a follow-on ticket.

@hackmastera I'm just seeing this now.  Thanks so much for the clarification/information. @tpendragon, is it too late to chime in again?

@kelea99 It's never too late — we went ahead and merged this, with the idea that we'd create a new issue to figure out which exhibit an item was from if someone asked for that. If you want to ask for it now, go ahead!

@escowles thanks.  I think @hackmastera raises important points. I can envision customized metadata (primarily the curatorial notes) being added to more than just the DPUL exhibits that parallel the physical exhibits in the future.  So, if I may change my mind? Yup. Id like to ask for it now.  The metadata customizations per exhibit should hang out with the bookmarked item.  Sorry, y'all for my flip flop.


[WIP] [P2P] Add contexts to method signatures

Objective

Add context.Context arguments to all method signatures which require a context downstream (at least).
Push context creation up the call stack as high as possible / reasonable (i.e. context.Background()).

Origin Document
There  two main reasons that we would want to do this:

It's conventional / best practice with respect to packages which consume context.Context.
We will likely need fairly ubiquitous access to context objects (everywhere we want to measure) as we get into distributed tracing.

Goals

...

Deliverable

...

Non-goals / Non-deliverables

Refactoring, simplifying or otherwise changing method signatures outside the scope of passing context.Contexts.

General issue deliverables

[ ] Update the appropriate CHANGELOG(s)
[ ] Update any relevant local/global README(s)
[ ] Update relevant source code tree explanations
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] Task specific tests or benchmarks: make ...
[ ] New tests or benchmarks: make ...
[ ] All tests: make test_all
[ ] LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @bryanchriswhite

@bryanchriswhite NIT on how you put together the github description:
Objective: A one line tl;dr for everyone.
For example: Propagate golan'g context.Context through the p2p module
Goals:: Bullet points of what the outcome will be.
For example:

Ability to access, propagate and attach a context to all functions ...
Push context creation up the call stack as high as possible / reasonable (i.e. context.Background()).

Deliverables: The actual work that will be done
For example:

Add context.Context as an argument to all method signatures which require a context downstream (at least).

Assuming that makes sense, are you open to updating the GitHub template to make it more obvious?

@Olshansk thanks for the pointers! :raised_hands:
My main focus at the time of writing was to get an issue number to put in a comment. but of course, I'm more than happy to clean it up.  :sweat_smile: I figured  applying the triage label would make it clear that it needs improvement before it is actionable.


App is still getting rate limited, implement incremental backoff, priority queues, notifications and extra settings

Added in v0.10.0


Ask before opening external links

Introduces an external link confirm popup window that prompts the user to acknowledge that they really want to visit the external link. This is based off the design file
This contains a menu bar with a title, but is missing the close button. It is also missing the "Don't ask again" button. These require some more conversation and can be addressed in a follow-up.
This deviates from the design file in providing a mobile layout that positions the buttons in a column layout instead of a rowlayout. cc @GBKS @mouxdesign

Desktop Layout
Mobile Layout

Updated from 3a3f8c2 to e9b6d4a
Added a navigation bar with a Title, but without a close button within the navigation bar.

ACK e9b6d4a
Verified on Ryzen 9 Ubuntu 22.04.2 and Note 9 Android 10 on fully synced nodes.

Good idea with the column layout for mobile. Small thing, the overlay should have a 1px border around it (neutral 6 color).

@jarolrod pointed out that this should probably be an application-wide setting. So the first time a user opens an external link, we ask them. If they check the "Don't ask again" option, we don't ask anymore. But they can change this behavior again in the settings. Here's a mock-up for that.

Concept ACK, approach NACK.

Please rebase.
https://discord.com/channels/903125802726596648/903126039084015638/1146922061449666602

rebased over main

This issue has been around for a long time. What is needed to wrap it up?


[SPARK-10539][SQL]Project should not be pushed down through Intersect or Except

Intersect and Except are both set operators and they use the all the columns to compare equality between rows. When pushing their Project parent down, the relations they based on would change, therefore not an equivalent transformation.
JIRA: https://issues.apache.org/jira/browse/SPARK-10539

Merged build triggered.

Merged build started.

Test build #42419 has started for   PR 8742 at commit 040b60a.

Test build #42419 has finished for   PR 8742 at commit 040b60a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42419/
Test PASSed.

I need to investigate more about set operator to make sure I'm doing the right thing. Close it for now.

Merged build triggered.

Merged build started.

Test build #42432 has started for   PR 8742 at commit ce6ed80.

Test build #42432 has finished for   PR 8742 at commit ce6ed80.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42432/
Test PASSed.

cc @yhuai for review.

ping :)

@yjshen The fix is good. Can you address comments?

@yjshen I added the comments and create a new PR (https://github.com/apache/spark/pull/8823). Can you close this one?

Thanks @yhuai, I'll close this one.


mina unicorn:start using wrong directory

When running unicorn start, I get the following error:
/html/dev-api/shared/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/configurator.rb:88:in `block in reload': directory for pid=/html/shared/tmp/pids/unicorn.pid not writable (ArgumentError)
	from /html/dev-api/shared/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/configurator.rb:84:in `each'
	from /html/dev-api/shared/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/configurator.rb:84:in `reload'
	from /html/dev-api/shared/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/configurator.rb:65:in `initialize'
	from /html/dev-api/shared/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:76:in `new'
	from /html/dev-api/shared/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:76:in `initialize'
	from /html/dev-api/current/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/bin/unicorn:126:in `new'
	from /html/dev-api/current/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/bin/unicorn:126:in `<top (required)>'
	from /html/dev-api/current/vendor/bundle/ruby/2.3.0/bin/unicorn:23:in `load'
	from /html/dev-api/current/vendor/bundle/ruby/2.3.0/bin/unicorn:23:in `<main>'
master failed to start, check stderr log for details

Mina is clearly getting the path to my PID file wrong:
/html/shared/tmp/pids/unicorn.pid
should be:
/html/dev-api/shared/tmp/pids/unicorn.pid

I just had some time to look into this again and I can see in the restart_unicorn method that the path to run the unicorn script is being built like so: #{deploy_to}/#{current_path}. See this line of code.
Does anyone know for what reason the current_path is being appended to the path at this point?
In my case, a previous mina task must be moving to a different directory and therefore causing  unicorn:restart to choose the wrong path. I have fixed my own script by simply moving the current path to the deploy directory before invoking
    to :launch do
      queue %[cd "#{deploy_to}"]
      invoke :'unicorn:restart'
    end

Another update: The above doesn't work, because at this point the current path has not yet been symlinked! Looking into how I can find the release path...

ANOTHER update 😉
The above for some reason only worked when I moved the code into a seperate task like so:
task :deploy => :environment do
  deploy do
    # all the things!
    to :launch do
      invoke :'restart'
    end
  end
end

task :restart do
  # mina unicorn gem has a bug, must cd to the release path before restarting.
  queue %[echo "-----> Ensuring unicorn will restart from #{deploy_to}/$release_path"]
  queue %[cd "#{deploy_to}/$release_path"]
  invoke :'unicorn:restart'
end

Thanks to the guys over on this issue whom I got the idea from: https://github.com/mina-deploy/mina/issues/432

@cameronbourgeois First of all, thank you for the investigation! 👍
Unfortunately, I can't reproduce the issue with my setup.
I added small debug line into unicorn:start command in https://github.com/scarfacedeb/mina-unicorn/tree/investigate_current_path
Could you install the gem from it and inspect where does current_path points to in your case?
In my case, it points to correct new release path:
-----> Starting Unicorn...
       lrwxrwxrwx 1 * * 11 Oct 22 21:16 ***/apps/unicorn_test/current -> releases/25
-----> Done. Deployed v25


Scrape Open Graph Metadata from URLs

Add the option to retrieve Open graph metadata from URLs as shown in the docs.

Released in https://github.com/GetStream/stream-net/releases/tag/4.2.0


[github-pr-review] zero location for lines does not work

Hello! Thanks a lot for this wonderful project!
I am implementing a reviewdog-based Github Action for https://github.com/wemake-services/wemake-python-styleguide
Original PR: https://github.com/wemake-services/wemake-python-styleguide/pull/1024
The problem is that we have some errors that are logically located on 0 line.
Like these ones:
./wrong__01.py:0:1: WPS114 Found underscored name pattern: wrong__01
./wrong__01.py:1:1: WPS111 Found too short name: a

As you see, we cannot report Found underscored name pattern: wrong__01 on first line. Because it does not make any sense. And reviewdog does not show this error inside the pull request: https://github.com/wemake-services/wemake-python-styleguide/pull/1024#pullrequestreview-322932150
What should I do here?

My PRs:

https://github.com/wemake-services/wemake-python-styleguide/pull/1045
https://github.com/sobolevn/python-pure-evil/pull/1

For github-pr-review, we cannot support reporting errors to arbitrary locations due to GitHub API limitation. We can only post comments to lines inside PR diff.
Alternatively, it can be possible to post comments as a review summary comment, but it's not implemented yet.
As for github-pr-check, Check API supports posting comments outside diff, so it's possible to post a comment to file as line 1, but it's not implemented either.

Now you can use -filter-mode=file or -filter-mode=nofilter to include zero line results. https://github.com/reviewdog/reviewdog#filter-mode


Updated addObserver and removeObserver methods.

Fixed a typo on removeObserver method that shows an error of compilation in xcode. Updated addObserver #selector argument that shows an error of compilation in xcode.

Both fixed in master 👍


✅ Suggest a portfolio to be added to the list

This issue will capture portfolios not available in this project that you would like to see added to the list. If you are reading this and you would like to add any of the portfolios mentioned here, you are free to do so. Just be sure to mention this issue so we tick it as appropriate.
Suggestions
Mention the Author beside a checkbox, then add the portfolio and GitHub links (if available).

[x] Victor Eke

https://victoreke.com

https://github.com/evavic44/eke

[x] Mike Bifulco

https://mikebifulco.com/

https://github.com/mbifulco/blog

[x] Anthony Fu

https://antfu.me/

https://github.com/antfu/antfu.me

[x] Shodipo Ayomide

https://shodipoayomide.com

https://github.com/Developerayo/shodipoayomide.com

[x] Damian Watracz

https://watracz.com/

none

[x] Fajar Siddiq

https://fajarsiddiq.com/

None

[x] Rutik Wankhade

https://rutikwankhade.dev/

None

[x] Daniel Cranney

https://www.danielcranney.com/

https://github.com/danielcranney/portfolio

[x] Abdellatif Laghjaj

https://www.abdellatif-laghjaj.ml/

None

[x] Rajan Kumar

https://krcpr007.vercel.app/

https://github.com/krcpr007/NextJS-Portfolio

@all-contributors please add @israelmitolu for code and doc

Hello,
I have a portfolio and I'd like you guys to add it to the list, here it is:
abdellatif-laghjaj

Hello, I have a portfolio and I'd like you guys to add it to the list, here it is: abdellatif-laghjaj

Awesome. Thanks for sharing. Will be added

@Evavic44  add this portfolio https://krcpr007.vercel.app/

@Evavic44 add this portfolio https://krcpr007.vercel.app/

Noted, thanks

Hello guys, thats mt portfolio, can you add in the list? Thanks!!
Url: http://glaysonvisgueira.vercel.app/
Github: https://github.com/Glaysonvisgueira/glaysonvisgueira_next-js

Hello guys, thats mt portfolio, can you add in the list? Thanks!! Url: http://glaysonvisgueira.vercel.app/ Github: https://github.com/Glaysonvisgueira/glaysonvisgueira_next-js

Sure.

 Will do! 👍🏽

Mukul Chugh
https://mukulchugh.com
Will be releasing this as a public repo, soon.

Andrew Branch
https://blog.andrewbran.ch/
https://github.com/andrewbranch/blog
Gatsby, TypeScript, Emotion, Netlify

Max Böck
https://mxb.dev/about/
https://github.com/maxboeck/mxb
Eleventy, SCSS, Nunjucks

Mukul Chugh
https://mukulchugh.com
Will be releasing this as a public repo, soon.

Hi Mukul, you have an awesome portfolio.
What stack did you use in building?

Mukul Chugh
https://mukulchugh.com
Will be releasing this as a public repo, soon.

Hi @mukulchugh , you have an awesome portfolio. What stack did you use in building?

Thank you @israelmitolu , I've used React & Styled Components for this one and a bunch of libraries.

Jan Baszczok
https://yasio.dev/
https://github.com/YasiOnFire

https://vjy.me/

Jhey Tompkins
https://jhey.dev/
https://github.com/jh3y/jhey.dev
Sanity, Astro, Tailwind CSS, Netlify

Jan Baszczok https://yasio.dev/ NuxtJS, Firebase, CSS

Hey Eke. This is already on the portfolio, although the name added is Yasio

David Heckhoff
https://david-hckh.com/
HTML, CSS, JavaScript, ThreeJS, GSAP, PWA, Howler.js

Ashish
https://asrvd.me/
https://github.com/asrvd/asrvd.me
Next.js, tRPC, Tailwind CSS, TypeScript, NextAuth.js, Prisma

Robb Owen
https://robbowen.digital/
HTML, CSS, JavaScript, Netlify

Josh Comeau
https://www.joshwcomeau.com/
NextJS, Styled Components, MDX, MongoDB, Framer Motion, React Spring, Vercel

Charles Bruyerre
https://itssharl.ee/
NextJS, ThreeJS, PWA, Vercel

Patrick David
https://bepatrickdavid.com/
HTML, Bootstrap, JavaScript, jQuery, Plesk, ThreeJS, GSAP, PWA

Seán Halpin
https://www.seanhalpin.xyz
Svelte, SvelteKit, Vite, PWA, Node.js

Cyd Stumpel
https://cydstumpel.nl/
WordPress, PHP, ThreeJS, MySQL, GSAP, Lenis

Tamal Sen
https://tamalsen.dev/
WordPress, Elementor, PHP, MySQL, Anime.js

Aristide Benoist
https://aristidebenoist.com/
PHP, AWS

Abhishek Jha
https://abhishekjha.me/
HTML, CSS, JavaScript, GSAP, Github Pages

Robin Mastromarino
http://robinmastromarino.com/
GSAP, Google Analytics

Lanre Adelowo
https://lanre.wtf/
NextJS, CSS, GSAP, Vercel

Danny Johnson
https://www.mrdannyjohnson.co.uk/
Astro, Vue, Sanity, Tailwind CSS

Wahid Ali
https://www.wahidali.dev/
https://github.com/Aliwahid17/portfolio
Svelte, Tailwind CSS, TypeScript, Vercel

Brian Lovin
https://brianlovin.com/
https://github.com/brianlovin/briOS
NextJS, TypeScript, Tailwind CSS, Prisma, Planetscale

Pritish Samal
https://pritishsamal.com
https://github.com/CIPHERTron/portfolio-v2
Next.js, TypeScript, emotion, Chakra UI

Hello, @Evavic44
This is my portfolio.
https://multikitty.onrender.com
https://github.com/multikitty/multikitty.github.io
Html, CSS, JavaScript
Can you add my portfolio? Thanks.

Cool portfolio @mukulchugh 👍

Cool portfolio @multikitty 👍

Hey @Evavic44 thanks, mate! 😄

David Angulo
https://www.davidangulo.xyz/
https://github.com/dcangulo/davidangulo.xyz
HTML, Jekyl, Ruby, Boostrap

Shubh Porwal
https://www.shubhporwal.me/
https://github.com/shubh73/devfolio
NextJS, ReactJS, Tailwind CSS, GSAP.

Ross Moody
https://rossmoody.com
https://github.com/rossmoody/rossmoody.com
Next.js, Chakra UI, TypeScript, MDX, Netlify

Rémy Beumier
https://remybeumier.be
https://github.com/beumsk/beumsk.github.io
Next.js, Sass, MDX, AOS

Rafael Santana
https://www.rafaelsantana.dev/
https://github.com/rafalmeida73/portfolio
Next.js, Material UI, TypeScript

Rafael Santana
https://www.rafaelsantana.dev/
https://github.com/rafalmeida73/portfolio
Next.js, Material UI, TypeScript

@Evavic44 as per your suggestion in LinkedIn...
Daniel Coyula
https://portfolio.dctech.dev
https://github.com/monster555
Flutter

Thanks, @monster555. We'll add it

Monica Powell
https://aboutmonica.com
None
Gatsby, Emotion, Netlify

Ismoilbek Ilxomov
https://ismail.uz/
None
Next, Tailwind, Netlify

My Portfolio
Live Site: https://ibrahimraimi.vercel.app
Source Code: https://github.com/ibrahimraimi/folio-v1.1
Tech Stack: Next, sass, gsap, framer-motion

Hey, I am interested in adding my portfolio.
https://the-shivam-gupta.github.io/
https://github.com/the-shivam-gupta/the-shivam-gupta.github.io
HTML, CSS, JS

@the-shivam-gupta raise a PR then. This issue is for those who can't add it themselves.

No issues necessary. Just add it directly. @jahirfiquitiva

Cruip
https://preview.cruip.com/devspace/index.html
None
Alpine.JS, Tailwind CSS, Chartjs

Wisnu Wicaksono
https://wiscaksono.com/
https://github.com/wiscaksono/wiscaksono-site
Nextjs, Tailwind CSS, MDX, Next Auth

My Portfolio
Live Site: https://levinhkhang.org
Source Code: https://github.com/levinhkhangzz/personal-website
Nextjs, Tailwind CSS, React

Live Site: https://aliimam.in/
Nextjs, Tailwind CSS, React

Hello,
I have a portfolio and I'd like you guys to add it to the list, here it is: https://tammura.com
Tech stack: Nextjs, TailwindCSS, Vercel, Cloudflare
Thanks!

Someone added me to this list and I noticed I get quite a bit of traffic from this repository. I'll note that my portfolio has changed since it was put on this list so the one at my domain doesn't match the one. However, I do keep my old portfolios active.
https://mk1.rida.dev/
https://mk2.rida.dev/
https://mk3.rida.dev/ (also available at https://rida.dev/)
MK3 is the current portfolio listed on my website, if someone wants to update that. :)

Nisarg Kavi
https://nisargkavi.in/
Nextjs, Tailwind CSS, Framer Motion, AnimeJS

Malik Naik
https://maliknaik.me/
None
HTML, CSS, Bootstrap, and JavaScript

Babatunde Afreka
https://bafrekauiux.framer.website/
None
Framer, React

Name : James Lee
Portfolio Link : https://techsolutionsx.vercel.app/
Stack : HTML, CSS, Bootstrap and Javascript

Hello! I have a really cool portfolio at lnlenost.netlify.app.

Krishnakumar Valliappan
website link - https://krishnavalliappan.github.io/portfolio-website/
github link - https://github.com/krishnavalliappan
Next.js, Framer, TypeScript, TailwindCSS, shadcn/ui

Dipesh Murmu
website link - https://dipeshmurmu.com.np
Tailwind, Alpine, Laravel, Livewire

I’m Shivam Panchal, a front-end developer focused on crafting engaging and responsive web experiences. Check out my portfolio to see my work, from interactive websites to seamless user interfaces.
Shivam | Portfolio

Mariya Baig
Portfolio -  mariyabaig.vercel.app
Github - mariyabaig
Ketuman
Portfolio - k2maan.vercel.app
Github - k2maan

Adeola Badero
Portfolio - adeolabadero.vercel.app
Github - adex-hub

Adithya Krishnan
Portfolio  - adithyakrishnan.com
Github     - fal3n-4ngel
Nextjs , Framer Motion , Tailwind CSS

Portfolio Link : https://techsolutionsx.vercel.app

Chun-Ho (Hugo) Lin

Portfolio - 1chooo.com
GitHub - 1chooo/1chooo.com

Priyanshu Tiwari
Portfolio - https://priyanshu-tiwari.vercel.app

Hi, please check out my portfolio and add if you like it. It's a completely custom-designed, minimalistic site.
Portfolio - https://yodkwtf.com
GitHub Code -  https://github.com/yodkwtf/yodkwtf.com

Check out my portfolio here: https://mihir-portfolio-main-777.vercel.app
Made with: React, Framer, GSAP, and EmailJS .

Check this one : https://www.adityabansal.tech
Made with : Three js, R3F, React Js, Framer Motion and GSAP

Check this one : https://berkaykrks.netlify.app/
Made with : HTML, CSS, Javascript


Select formatter dynamically without CLI options

It's convenient, but I don't really want it. I wouldn't be too bothered if it wasn't there.


Built-in terminal loses output

Issue Type: Bug
Built-in terminal loses output, replacing the missing text with blank lines.  I can't reproduce this on command, but it happens very often and is quite annoying.  Also affects tsc --watch as it loses the text that watching has begun; I end up thinking it locked up.
This issue has been ongoing through several updates of VSCode.
Compare terminal output in VSCode for a webpack build

To the same output from a direct command prompt

VS Code version: Code 1.35.0 (553cfb2c2205db5f15f3ee8395bbd5cf066d357d, 2019-06-04T01:17:12.481Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 x 3696)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.96GB (11.52GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

overtype
ada
0.2.0

vscode-eslint
dba
1.9.0

csharp
ms-
1.19.1

debugger-for-chrome
msj
4.11.3

LiveServer
rit
5.6.1

shader
sle
1.1.4

This looks like an issue with our old terminal backend "winpty", going forward we are focusing our efforts on the new backend "conpty" which is build by the Console team at Microsoft and should fix many issues with the terminal under Windows. You can read more about getting ConPTY here.
/duplicate https://github.com/Microsoft/vscode/issues/45693

Thanks, I guess my recent update to Win10 May 2019 (18362) enabled ConPTY in VSCode and now the built-in terminal is much less glitchy. :smiley:


Cant even run sbt on cloned repo

I really would like to learn from the repo, but how can I when the first instruction in the tutorial doesnt even work...
/home/kalin/.jdks/openjdk-15.0.1/bin/java -Djline.terminal=jline.UnsupportedTerminal -Dsbt.log.noformat=true -Dfile.encoding=UTF-8 -Didea.managed=true -Dfile.encoding=UTF-8 -jar /home/kalin/.local/share/JetBrains/IntelliJIdea2020.3/Scala/launcher/sbt-launch.jar
[info] Loading project definition from /home/kalin/dev/experiments/scalajs-spa-tutorial/project
[info] Updating {file:/home/kalin/dev/experiments/scalajs-spa-tutorial/project/}scalajs-spa-tutorial-build...

What's your sbt version?


Rspack serve error

1.@rspack/cli": "^1.1.4"，@rspack/core": "^1.1.4  node:v16.15.0
Rspack serve error
Is there an rspack communication group？(WeChat, QQ)

Please create an issue using the corresponding template and include a link to the reproduction. This will help us resolve your issue more quickly.
For this issue, I suspect it might be due to an outdated version of Node.js. The Rspack CLI requires Node.js version >= 18.12.0.

Please create an issue using the corresponding template and include a link to the reproduction. This will help us resolve your issue more quickly.
For this issue, I suspect it might be due to an outdated version of Node.js. The Rspack CLI requires Node.js version >= 18.12.0.
@inottn @chenjiahan
The issue mentioned above is indeed a problem with the node version, and now there is a new problem. Can you help investigate what caused it?
The error message is as follows：

Need a reproduction repo

The issue mentioned above is indeed a problem with the node version, and now there is a new problem. Can you help investigate what caused it?

These are two separate issues. You can open a new issue and include a reproduction demo.


Add new missing Wilayas and Communes

From: https://github.com/moumouh206/Wilaya-Of-Algeria

Very useful thank you


Addressed parameter 'object' not found error

@AdamBCo Thank for submitting the PR. I cannot reproduce the warning / error while building PINCache. Even if I enable all warnings this does not show up. Can you provide a bit more information          when you are hitting that error. Thanks!

@maicki I keep seeing the following warning appear in Xcode.
Screenshot attached below:

@AdamBCo I think you may be on an old version?

@garrettmoon Is that change on a different branch? I forked from master. This small change addresses the warning and updates the documentation, which based on my change is currently incorrect.

          1 Warning

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger

🚫 CI failed with log

@AdamBCo As @garrettmoon said on master the method currently has the right parameter name. Did you sync your master branch from your fork with the master branch of the origin repo?

I'm going to close this out since we haven't heard back. Thanks for your contribution!


consider adding more tags to the Cargo.toml

namely math, and a few subdomains, (such as algebra and probability) where this might be useful.

Agreed, thanks!


duplicate images in newly added items

Describe the bug
Since 1.6.11 aves shows each image of the most recent day two times. It could also be the case for the last two days but so far I can't find a consistent pattern.
System information and logs:
Aves version: 1.6.11-izzy (Build 1077)
Flutter version: 3.3.0-0.0.pre (Channel beta)
Android version: 12 (SDK 32)
Android build: SQ3A.220705.003.A1.2022073100
Device: Google Pixel 6
Mobile services: ready
System locales: en_US
Aves locale: system -> en
Installer: com.machiav3lli.fdroid

Log
--------- beginning of main
08-01 21:33:59.884 29369 29369 I d.t.a.MainActivity: onCreate intent=Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=deckers.thibault.aves/.MainActivity bnds=[340,900][540,1100] }
08-01 21:33:59.976 29369 29369 I d.t.a.MainActivity: onStart
08-01 21:34:00.146 29369  3564 I flutter : Device has Google Play Services=true
08-01 21:34:00.149 29369  3564 I flutter : [sil] 2022-08-01 21:34:00.149448 [fijk] set log level FijkLogLevel{level:500, name:war}
08-01 21:34:00.150 29369  3564 I flutter : Report set keys build_mode=release, has_mobile_services=true, locales=en_US, time_zone=CEST (2:00:00.000000)
08-01 21:34:00.150 29369  3564 I flutter : App setup in 141ms
08-01 21:34:00.151 29369  3564 I flutter : [sil] 2022-08-01 21:34:00.151892 [fijk] native log level 500
08-01 21:34:00.153 29369  3564 I flutter : Apply display refresh rate: highest
08-01 21:34:00.209 29369  3564 I flutter : Access installed app inventory
08-01 21:34:00.209 29369  3564 I flutter : Report set key app_mode=AppMode.main
08-01 21:34:00.209 29369  3564 I flutter : Storage check complete in 47ms
08-01 21:34:00.286 29369  3564 I flutter : MediaStoreSource load essentials complete in 76ms
08-01 21:34:00.286 29369  3564 I flutter : MediaStoreSource refresh start
08-01 21:34:00.287 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.000122 load 36 top entries
08-01 21:34:00.288 29369  3564 I flutter : Report log with message=Nav didPush to /collection
08-01 21:34:00.288 29369  3564 I flutter : Report log with message=Nav didRemove to unnamed null
08-01 21:34:00.295 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.008718 fetch known entries
08-01 21:34:00.481 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.194045 check obsolete entries
08-01 21:34:00.876 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.589084 add known entries
08-01 21:34:00.923 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.636060 load metadata
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/4195, mimeType=image/jpeg, dateModifiedSecs=1623002663, rotationDegrees=0, isFlipped=false
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/4682, mimeType=image/jpeg, dateModifiedSecs=1624802403, rotationDegrees=0, isFlipped=false
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/5049, mimeType=image/jpeg, dateModifiedSecs=1631407320, rotationDegrees=0, isFlipped=false
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/7333, mimeType=image/jpeg, dateModifiedSecs=1626939651, rotationDegrees=0, isFlipped=false
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/7156, mimeType=image/jpeg, dateModifiedSecs=1622313650, rotationDegrees=0, isFlipped=false
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/8825, mimeType=image/jpeg, dateModifiedSecs=1621400992, rotationDegrees=0, isFlipped=false
08-01 21:34:01.000 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/6694, mimeType=image/jpeg, dateModifiedSecs=1621162574, rotationDegrees=0, isFlipped=false
08-01 21:34:01.001 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/12305, mimeType=image/jpeg, dateModifiedSecs=1635268959, rotationDegrees=0, isFlipped=false
08-01 21:34:01.001 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/10850, mimeType=image/jpeg, dateModifiedSecs=1617827501, rotationDegrees=0, isFlipped=false
08-01 21:34:01.001 29369  3564 I flutter : Evict cached images for uri=content://media/external/images/media/13633, mimeType=image/jpeg, dateModifiedSecs=1615968248, rotationDegrees=0, isFlipped=false
08-01 21:34:01.110 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.823122 check obsolete paths
08-01 21:34:01.245 29369  3564 I flutter : MediaStoreSource refresh 0:00:00.958519 fetch new entries
08-01 21:34:01.337 29369  3564 I flutter : MediaStoreSource refresh 0:00:01.050572 analyze
08-01 21:34:01.341 29369  3564 I flutter : Device is connected=true
08-01 21:34:01.348 29369 29369 I d.t.a.AnalysisService: Create analysis service
08-01 21:34:01.369 29369 29369 I t.b     : Analysis service connected
08-01 21:34:01.369 29369  3564 I flutter : MediaStoreSource refresh 0:00:01.082852 done for 7710 known, 0 new, 0 removed
08-01 21:34:01.384 29369  3573 I flutter : Device has Google Play Services=true
08-01 21:34:01.386 29369  3573 I flutter : [sil] 2022-08-01 21:34:01.386247 [fijk] set log level FijkLogLevel{level:500, name:war}
08-01 21:34:01.386 29369  3573 I flutter : Analyzer create
08-01 21:34:01.386 29369 29369 D d.t.a.AnalysisService: background channel is ready
08-01 21:34:01.386 29369  3573 I flutter : Analyzer start for all entries
08-01 21:34:01.386 29369  3573 I flutter : [sil] 2022-08-01 21:34:01.386801 [fijk] native log level 500
08-01 21:34:01.407 29369  3573 I flutter : MediaStoreSource load essentials complete in 20ms
08-01 21:34:01.407 29369  3573 I flutter : MediaStoreSource refresh start
08-01 21:34:01.407 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.000005 fetch known entries
08-01 21:34:01.525 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.118020 check obsolete entries
08-01 21:34:01.585 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.177223 add known entries
08-01 21:34:01.623 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.215494 load metadata
08-01 21:34:01.683 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/4195, mimeType=image/jpeg, dateModifiedSecs=1623002663, rotationDegrees=0, isFlipped=false
08-01 21:34:01.683 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/4682, mimeType=image/jpeg, dateModifiedSecs=1624802403, rotationDegrees=0, isFlipped=false
08-01 21:34:01.683 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/5049, mimeType=image/jpeg, dateModifiedSecs=1631407320, rotationDegrees=0, isFlipped=false
08-01 21:34:01.684 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/7333, mimeType=image/jpeg, dateModifiedSecs=1626939651, rotationDegrees=0, isFlipped=false
08-01 21:34:01.684 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/7156, mimeType=image/jpeg, dateModifiedSecs=1622313650, rotationDegrees=0, isFlipped=false
08-01 21:34:01.684 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/8825, mimeType=image/jpeg, dateModifiedSecs=1621400992, rotationDegrees=0, isFlipped=false
08-01 21:34:01.684 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/6694, mimeType=image/jpeg, dateModifiedSecs=1621162574, rotationDegrees=0, isFlipped=false
08-01 21:34:01.684 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/12305, mimeType=image/jpeg, dateModifiedSecs=1635268959, rotationDegrees=0, isFlipped=false
08-01 21:34:01.685 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/10850, mimeType=image/jpeg, dateModifiedSecs=1617827501, rotationDegrees=0, isFlipped=false
08-01 21:34:01.685 29369  3573 I flutter : Evict cached images for uri=content://media/external/images/media/13633, mimeType=image/jpeg, dateModifiedSecs=1615968248, rotationDegrees=0, isFlipped=false
08-01 21:34:01.760 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.352329 check obsolete paths
08-01 21:34:01.876 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.468781 fetch new entries
08-01 21:34:01.981 29369  3573 I flutter : MediaStoreSource refresh 0:00:00.573335 analyze
08-01 21:34:02.227 29369  3573 I flutter : Device is connected=true
08-01 21:34:02.938 29369  3573 I flutter : MediaStoreSource refresh 0:00:01.531022 done for 7710 known, 0 new, 0 removed
08-01 21:34:02.939 29369  3564 I flutter : Analysis completed
08-01 21:34:02.944 29369 29369 I d.t.a.AnalysisService: Destroy analysis service
08-01 21:34:17.457 29369  3564 I flutter : _AvesAppState lifecycle inactive
08-01 21:34:17.498 29369  3564 I flutter : Saved 36 top entries in 40ms
08-01 21:34:18.142 29369 29369 I d.t.a.MainActivity: onStop
08-01 21:34:18.143 29369  3564 I flutter : _AvesAppState lifecycle paused
08-01 21:34:32.467 29369 29369 I d.t.a.MainActivity: onStart
08-01 21:34:32.474 29369  3564 I flutter : _AvesAppState lifecycle resumed
08-01 21:34:32.538 29369  3586 I OpenGLRenderer: Davey! duration=32345ms; Flags=1, FrameTimelineVsyncId=1557780, IntendedVsync=37057116491753, Vsync=37057116491753, InputEventId=0, HandleInputStart=37057116735785, AnimationStart=37057116737332, PerformTraversalsStart=37057117027574, DrawStart=37057120574286, FrameDeadline=37057133091753, FrameInterval=37057116730740, FrameStartTime=16666667, SyncQueued=37057122571194, SyncStart=37057122627428, IssueDrawCommandsStart=37057123462755, SwapBuffers=37057130139675, FrameCompleted=37089461970583, DequeueBufferDuration=802002, QueueBufferDuration=636067, GpuCompleted=37089461970583, SwapBuffersCompleted=37057130809679, DisplayPresentTime=-2121335188909661553,
08-01 21:34:34.097 29369  3564 I flutter : Report log with message=Nav didPush to unnamed _PopupMenuRoute<EntrySetAction?>
08-01 21:34:35.197 29369  3564 I flutter : Report log with message=Nav didPop to /collection
08-01 21:34:37.019 29369  3564 I flutter : Report log with message=Nav didPush to /about
08-01 21:34:40.499 29369  3564 I flutter : _AvesAppState lifecycle inactive
08-01 21:34:40.550 29369 29369 I d.t.a.MainActivity: onStop
08-01 21:34:40.622 29369  3564 I flutter : Saved 36 top entries in 122ms
08-01 21:34:40.623 29369  3564 I flutter : _AvesAppState lifecycle paused
08-01 21:35:12.522 29369 29369 I d.t.a.MainActivity: onStart
08-01 21:35:12.532 29369  3564 I flutter : _AvesAppState lifecycle resumed
08-01 21:35:12.581 29369 30290 I OpenGLRenderer: Davey! duration=72401ms; Flags=1, FrameTimelineVsyncId=1557780, IntendedVsync=37057116491753, Vsync=37057116491753, InputEventId=0, HandleInputStart=37057116735785, AnimationStart=37057116737332, PerformTraversalsStart=37057117027574, DrawStart=37057120574286, FrameDeadline=37057149758420, FrameInterval=37057116730740, FrameStartTime=16666667, SyncQueued=37057122571194, SyncStart=37057122627428, IssueDrawCommandsStart=37057123462755, SwapBuffers=37057130139675, FrameCompleted=37129518370057, DequeueBufferDuration=802002, QueueBufferDuration=636067, GpuCompleted=37129518370057, SwapBuffersCompleted=37057130809679, DisplayPresentTime=-2121335188909661553,
08-01 21:35:15.031 29369  3564 I flutter : _AvesAppState lifecycle inactive
08-01 21:35:15.089 29369  3564 I flutter : Saved 36 top entries in 58ms
08-01 21:35:15.091 29369 29369 I d.t.a.MainActivity: onStop
08-01 21:35:15.092 29369  3564 I flutter : _AvesAppState lifecycle paused
08-01 21:36:05.135 29369 29369 I d.t.a.MainActivity: onStart
08-01 21:36:05.159 29369  3564 I flutter : _AvesAppState lifecycle resumed
08-01 21:36:05.208 29369  3586 I OpenGLRenderer: Davey! duration=125019ms; Flags=1, FrameTimelineVsyncId=1557780, IntendedVsync=37057116491753, Vsync=37057116491753, InputEventId=0, HandleInputStart=37057116735785, AnimationStart=37057116737332, PerformTraversalsStart=37057117027574, DrawStart=37057120574286, FrameDeadline=37057166425087, FrameInterval=37057116730740, FrameStartTime=16666667, SyncQueued=37057122571194, SyncStart=37057122627428, IssueDrawCommandsStart=37057123462755, SwapBuffers=37057130139675, FrameCompleted=37182136104255, DequeueBufferDuration=802002, QueueBufferDuration=636067, GpuCompleted=37182136104255, SwapBuffersCompleted=37057130809679, DisplayPresentTime=-2121335188909661553,
08-01 21:36:06.583 29369  3564 I flutter : Report log with message=Nav didPop to /collection
08-01 21:36:31.088 29369  3564 I flutter : _AvesAppState lifecycle inactive
08-01 21:36:31.129 29369  3564 I flutter : Saved 36 top entries in 40ms
08-01 21:36:31.133 29369 29369 I d.t.a.MainActivity: onStop
08-01 21:36:31.133 29369  3564 I flutter : _AvesAppState lifecycle paused
08-01 21:37:29.121 29369 29369 I d.t.a.MainActivity: onStart
08-01 21:37:29.140 29369  3564 I flutter : _AvesAppState lifecycle resumed
08-01 21:37:29.186 29369 30290 I OpenGLRenderer: Davey! duration=176688ms; Flags=1, FrameTimelineVsyncId=1559798, IntendedVsync=37089427479969, Vsync=37089427479969, InputEventId=2053655941, HandleInputStart=37089428585817, AnimationStart=37089428586631, PerformTraversalsStart=37089428587079, DrawStart=37089455427574, FrameDeadline=37089460746636, FrameInterval=37089428582969, FrameStartTime=16666667, SyncQueued=37089456106651, SyncStart=37089456128379, IssueDrawCommandsStart=37089456286094, SwapBuffers=37089461989504, FrameCompleted=37266116304939, DequeueBufferDuration=1219238, QueueBufferDuration=908691, GpuCompleted=37266116304939, SwapBuffersCompleted=37089462969525, DisplayPresentTime=-8178287817334288512,
08-01 21:37:31.461 29369  3564 I flutter : Report log with message=Nav didPush to /about
08-01 21:37:43.651 29369  3564 I flutter : _AvesAppState lifecycle inactive
08-01 21:37:43.698 29369 29369 I d.t.a.MainActivity: onStop
08-01 21:37:43.774 29369  3564 I flutter : Saved 36 top entries in 123ms
08-01 21:37:43.775 29369  3564 I flutter : _AvesAppState lifecycle paused
08-01 21:37:52.202 29369 29369 I d.t.a.MainActivity: onStart
08-01 21:37:52.212 29369  3564 I flutter : _AvesAppState lifecycle resumed
08-01 21:37:52.255 29369 31839 I OpenGLRenderer: Davey! duration=159696ms; Flags=1, FrameTimelineVsyncId=1562822, IntendedVsync=37129491949943, Vsync=37129491949943, InputEventId=1172821643, HandleInputStart=37129492213319, AnimationStart=37129492214621, PerformTraversalsStart=37129492215435, DrawStart=37129510935975, FrameDeadline=37129525216610, FrameInterval=37129492209494, FrameStartTime=16666667, SyncQueued=37129512638327, SyncStart=37129512692486, IssueDrawCommandsStart=37129512943584, SwapBuffers=37129518565044, FrameCompleted=37289188650816, DequeueBufferDuration=1799927, QueueBufferDuration=1302246, GpuCompleted=37289188650816, SwapBuffersCompleted=37129519911643, DisplayPresentTime=31244173394051169,

Thanks for the report.
I'm not sure i understand the issue. If you take a screenshot or take a picture with your camera now, you see the new image twice in Aves, and they both refer to the same file on storage? Is it consistent and reproducible with any new image?

Sorry for being not precise enough.
Following image shows my aves gallery from Sunday.

The pictures I took today and yesterday are shown normally. The pictures from Sunday are all duplicates. If I delete one, the other one gets removed after a millisecond as well. They both point to the same file on storage.
So far I could not determine a reproducible pattern. I observed it now since the update but can't find anything. I think today's images are never shown twice.

2022-08-01: single
2022-07-31: single
2022-07-30: -
2022-07-29: four videos 3 times, another one 4 times, another one 2 times. 1 motion photo 3 times. other photos 2 times and 2 photos one time.
2022-07-28: - 2 videos 4 times. 1 photo 3 times. 7 photos 1 time.
2022-07-27: -
2022-07-26: and all before are shown normally. google photos shows all images normally.

This didn't happen in versions below 1.6.11

Probably I should've done it earlier but I didn't think of it. I just cleared storage and reopened aves. Now it's back to normal. Closing the case?

Thanks for the details. I'll keep this issue open. I can't reproduce it, but I should take a look to strengthen the code against this situation.
In the meantime, if it happens again, instead of resetting everything, you could move the duplicated items to another album and this should keep only one item per file.

Guess who's back.
I downloaded an image an hour ago and it appears three times in aves. It's an avif file, until I cleared the storage, I couldn't display avif in aves (reaaally happy that it's possible now!). I downloaded another avif photo and it only appears one time.
I moved one displayed file to another folder and immediately it was shown only once.

I have the same problem in that I get duplicate thumbnails pointing to the same image (same thing as the screenshot above). This started for me around early August when I was on Android 12 and the current version of Aves. The problem still exists on Android 13 on my Pixel 6 Pro. It doesn't always happen and I haven't worked out what is causing it. When I used F-Stop or Google Photos I can see that the photos are not duplicated. Rescanning the folder doesn't fix the problem.

Thanks for the feedback. It randomly happened to me once too, so i understand the symptoms. I tried to reproduce the issue in various ways, to no avail. From my understanding, if Aves gets corrupted like this, the only way to fix it is if the app "rediscovers" the items, so either 1) moving the items to another directory and reopening the app, or 2) wiping the app data and starting from scratch. Needless to say, this is unacceptable and i consider this a serious issue (hence the P3 label). I intend to release a new version as soon as i find and validate a fix.

@basings @petazonk I just released Aves v1.6.13. It includes a fix that prevents duplicate items in a specific situation. I can't be sure it's the same situation in your case, but it's highly probable.
The fix will prevent new duplicates, but it won't clean up existing duplicates.
I'll close this issue for now, but feel free to comment if you experience the issue again with the latest version.

@basings @petazonk since the issue got supposedly fixed, did you find any new duplicate items?
I'm asking because I recently got some similar reports (cf #368), but it's unclear yet whether the duplicates in these reports appeared with the latest version of Aves or an older one.

No duplicates here either. Thanks!


OS.h Defines for min and max break c++ compilation (IDFGH-14017)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.3.1-638-ga0f798cfc4
Operating System used.
macOS
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
None
What is the expected behavior?
C++ build successful when nimble is enabled.
What is the actual behavior?
Cannot build project due to defines for min and max.  Release/5.2 builds OK, Release/5.3 does not. Defines for min and max in os.h in 5.3 are the issue.  5.2 had a commit 155931f to remove them but looks to have been re-introducted in 5.3 commit fd31133.
5.2 - https://github.com/espressif/esp-nimble/blob/e08302d66d77a29e65dffe2c336e4dcda4e80e51/porting/nimble/include/os/os.h
5.3 - https://github.com/espressif/esp-nimble/blob/32b2124f54238e70ecd4c72a753698babdd939f7/porting/nimble/include/os/os.h
Steps to reproduce.
Bulid C++ project with Nimble and compiler error is observed.
Build or installation Logs.
No response
More Information.
Looks to be same issue as in ticket

Hi @kenozz-igs ,
I have removed the header definition from the OS.h file, just like in v5.2. The following is the patch file for changes. Can you please confirm if the patch provided works for you?
remove_min_max_defs.zip

Hi @ESPAbhinav thanks for the quick response.  I can confirm the patch does resolve the build issue.  Is there any plans to merge into the 5.3 release?

Hi @kenozz-igs , already raised the MR to merge this change into release 5.3 .Thanks for identifying the issue.


macOS support

added .idea folder to .gitignore, for support AppCode
created macOS project
fixed building macOS project
fixed the bug: sometimes crashes app after call long async methods on Peripheral class

Deprecated


Feature allows to send diff-File (as File-object) to spyware-server.

@wakr @samutamm

Coverage increased (+0.14%) to 88.77% when pulling 00306be9604f99114c9db52ff6ec1c306d1b29ba on spyware_hook into 2018af02930a313a5fcd3a82dadae4348157babd on master.

Coverage increased (+0.32%) to 86.59% when pulling 4bd54370913a292a7ef144330052ceec6f1df612 on spyware_hook into 4254d8813211ecd669850a32ead4be86d3a524ac on master.

Coverage increased (+0.68%) to 87.54% when pulling c8e13f495f3ef8e695b05fc316e1cf32dc575724 on spyware_hook into 6006f5871392755937c5f104d2705fa001501686 on master.


Can not view localhost:8000

Hi, I am docker-compose up, that i can view localhost:8500 .localhost:8500 is belong   Consul.but i can not curl  locahost:8000. what can i do?

I don't know how you are running Docker, but I would double-check the port forwarding settings.


[Bug] Set Select2 options in select2 backpack fields

Bug report
When i create a select2 field, in this case a relationship field y want to set allowClear in false but its not working. Like in the documentation
https://select2.org/configuration/options-api
Is there a way to set any of those options?
What I did
 $this->crud->addField([
            'label' => trans('crud.order.unit'),
            'type'      => 'relationship',
            'name'      => 'unit_id',
            'attribute' => 'name',
            'entity' => 'unit',
            'ajax' => true,
            'data_source' => backpack_url('order/fetch/unit'),
            'placeholder' => trans('crud.order.selectUnit'),
            'allowClear' => 0,
            'minimum_input_length'    => 0,
            'wrapper' => ['class' => 'form-group col-md-6'],
            'tab' => trans('crud.order.head'),
        ]);

What I expected to happen
The clear option is hidden
What happened
The clear option still showing

Hey @aberaldo ,
This field doesn't pass all PHP attributes to JS, so that wouldn't work, indeed. But if what you want is to not allow clearing, you should be able to use allows_null to the same effect:
 $this->crud->addField([
            'label' => trans('crud.order.unit'),
            'type'      => 'relationship',
            'name'      => 'unit_id',
            'attribute' => 'name',
            'entity' => 'unit',
            'ajax' => true,
            'data_source' => backpack_url('order/fetch/unit'),
            'placeholder' => trans('crud.order.selectUnit'),
-           'allowClear' => 0,
+           'allows_null' => false,
            'minimum_input_length'    => 0,
            'wrapper' => ['class' => 'form-group col-md-6'],
            'tab' => trans('crud.order.head'),
        ]);

Let me know if that works for you.
Cheers!


Unable to set lineLength from nvim lua config

Not sure if I did this correctly but i couldnt set --line-length arg in my neovim config (setting it to 1 just for testing). I am using kickstart vim.
Inside my neovim/nvim-lspconfig

The formatting runs fine on ":Format" command but ignores my line length setting. The only way I could get it work is to run "!ruff format --line-length 1" manually.
Version:
ruff 0.5.7
NVIM v0.10.1

What does the :Format command do? Is it something that you've defined in your own config or is it coming from an external plugin? If the latter, which plugin is it coming from?
The language server settings will only be accounted for when running the formatter via the server aka vim.lsp.buf.format().

I have set a nvim user command triggering the formater. Mostly copied from conform.nvim recipy.
-- Add format command
vim.api.nvim_create_user_command('Format', function(args)
  local range = nil
  if args.count ~= -1 then
    local end_line = vim.api.nvim_buf_get_lines(0, args.line2 - 1, args.line2, true)[1]
    range = {
      start = { args.line1, 0 },
      ['end'] = { args.line2, end_line:len() },
    }
  end
  require('conform').format { async = true, lsp_format = 'fallback', range = range }
end, { range = true })

There's some context here: https://github.com/astral-sh/ruff/issues/12514#issuecomment-2252147682 (and following replies) but the gist is that conform.nvim (specifically the ruff_organize_imports and ruff_format values) uses the ruff binary to perform the actions. The lineLength setting is specific to the server, so it will only work if you run the formatting via the language server (vim.lsp.buf.format()).

Note that conform.nvim is a formatter plugin which can use various ways of running a specific formatter. It could use the executable or the language server although you can configure it to either always use the language server or prefer it first.

You can configure conform.nvim to always use the LSP for formatting:
require('conform').setup {
  formatters_by_ft = {
    python = { lsp_format = 'prefer' },
  }
}

This way the server settings will be considered during formatting via the Ruff language server. You can verify whether conform.nvim is going to use Ruff LSP via :ConformInfo which should show:
Formatters for this buffer:
LSP: ruff

Thanks for the help @dhruvmanila
I have tried using your suggested snipet but it seems the line length setting only works when calling
require('conform').setup {
  formatters_by_ft = {
    python = { lsp_format = 'first' },
  }
}

*without ruff_fix and ruff_organize_imports
I tried to change the sequence but couldnt solve the issue. For now i couldnt find a way getting both "line length" and "ruff_fix + ruff_ogranize_import" to work together.

I have got organize imports working by setting "organizeImports = true" and removing "ruff_organize_import" from the list.
-- in my lspconfig.lua
ruff = {
  init_options = {
    settings = {
      lineLength = 1,
      organizeImports = true,
    }
  }
},

-- in my conform.lua
require('conform').setup {
  formatters_by_ft = {
    python = { lsp_format = 'first' },
  }
}

I still quite new to neovim/lua/ruff and not quite sure what ruff_fix does. Will check on the "fixAll" option in ruff config.

I have got organize imports working by setting "organizeImports = true" and removing "ruff_organize_import" from the list.

Huh, that's interesting. What do you mean by "have got organize imports working"? I'm asking because the default value for that setting is true.
As noted above, the ruff_* values in conform.nvim will use the ruff executable to perform the actions. For example, you can see that ruff_format just calls the ruff format command: https://github.com/stevearc/conform.nvim/blob/667102f26106709cddd2dff1f699610df5b94d7f/lua/conform/formatters/ruff_format.lua#L7-L14. This means that the server settings won't be considered there. Server settings are only considered when running the Ruff language server.
ruff_fix basically calls the ruff check --fix command as seen in https://github.com/stevearc/conform.nvim/blob/667102f26106709cddd2dff1f699610df5b94d7f/lua/conform/formatters/ruff_fix.lua#L7-L17 which is auto-fixing the rules that are fixable.

Sorry my bad. Upon futher inspection, it seems ruff organize imports is not working despite explisitly setting organizeImports = true, lineLength setting works fine though

Got it finally, organize imports, line lenght and formating working as normal
require('conform').setup {
  formatters_by_ft = {
    python = { 'ruff_fix', 'ruff_organize_imports', lsp_format = 'prefer' },
  }
}

The final solution is to set lsp_format to prefer instead of first

I have fixed the issue by falling back to using ruff CLI args as i could not get it working via language server.
-- Add this line to conform.lua
 require('conform').formatters.ruff_format = { append_args = { '--line-length', '120' } }

-- python formaters in conform.lua
python = { 'ruff_fix', 'ruff_organize_imports', 'ruff_format' },

As mentioned before, all these formatter configuration (ruff_fix, ruff_organize_imports, ruff_format) uses the Ruff executable i.e., they basically call the ruff executable to do the job. To use the server settings, you'd need to perform all three actions by asking the language server instead.


Novel modules

Adding support for non-traditional DBMS modules like:

Stochastic Gradient Descent
K-Means
Skyline

In general more compute heavy operations excell on FPGAs so it should be possible to support these as well.

Closing as we won't work on this in the near future.


Added sync-metadata event

This is useful for people to know when it's safe to use readdir and the such.
Currently people use a bunch of weird tricks to get it to work.
This will make the tricks a little bit less arcane and somewhat documented. :P

Closing this for now. Downloading the full metadata is an antipattern.
Instead one should use archive.metadata.update({ifAvailable: true}, whatever)


Newer versions than 0.1.0 breaking webpack build

Hi @qawemlilo ,
I upgraded to 0.2.0 as shown in the Heartbeat videos after you addressed the unreachable remotes.
Though now I am experiencing some issues while using versions newer than 0.1.0, I am not sure if I should do something on my side to prevent the library from being picked up by the webpack tooling and just build the app with your code as is or something 🤔
Here are the outputs I am getting, maybe you have some insight:
0.2.0
✔ ~/Documents/heartbeat [master|✚ 3]
08:45 $ npm run build

><EMAIL_ADDRESS>build /Users/amartinez/Documents/heartbeat
> cross-env NODE_ENV=production webpack --progress --hide-modules

Hash: 13e5392b5269a896cf0c
Version: webpack 2.7.0
Time: 13903ms
       Asset     Size  Chunks                    Chunk Names
    build.js  1.09 MB       0  [emitted]  [big]  main
build.js.map  1.35 MB       0  [emitted]         main

ERROR in build.js from UglifyJs
Unexpected token: punc ()) [./~/ping-monitor/lib/monitor.js:67,0][build.js:26747,29]
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `cross-env NODE_ENV=production webpack --progress --hide-modules`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/amartinez/.npm/_logs/2019-02-15T14_45_34_760Z-debug.log

0.3.0
✔ ~/Documents/heartbeat [master|✚ 4]
08:47 $ npm run build

><EMAIL_ADDRESS>build /Users/amartinez/Documents/heartbeat
> cross-env NODE_ENV=production webpack --progress --hide-modules

Hash: fc2ccfe696f42d5f3341
Version: webpack 2.7.0
Time: 14510ms
       Asset     Size  Chunks                    Chunk Names
    build.js  1.09 MB       0  [emitted]  [big]  main
build.js.map  1.35 MB       0  [emitted]         main

ERROR in ./~/ping-monitor/lib/tcp.js
Module not found: Error: Can't resolve 'net' in '/Users/amartinez/Documents/heartbeat/node_modules/ping-monitor/lib'
 @ ./~/ping-monitor/lib/tcp.js 3:12-26
 @ ./~/ping-monitor/lib/monitor.js
 @ ./~/ping-monitor/app.js
 @ ./src/mixins/pingLogic.js
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./src/components/Remote.vue
 @ ./src/components/Remote.vue
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./src/components/RemotesList.vue
 @ ./src/components/RemotesList.vue
 @ ./src/routes.js
 @ ./src/main.js

ERROR in build.js from UglifyJs
Unexpected token: name (req) [./~/ping-monitor/lib/http.js:24,0][build.js:26698,6]
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `cross-env NODE_ENV=production webpack --progress --hide-modules`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/amartinez/.npm/_logs/2019-02-15T14_47_38_166Z-debug.log

0.3.1
✔ ~/Documents/heartbeat [master|✚ 4]
08:48 $ npm run build

><EMAIL_ADDRESS>build /Users/amartinez/Documents/heartbeat
> cross-env NODE_ENV=production webpack --progress --hide-modules

Hash: 73b8ccde7890bd808b1d
Version: webpack 2.7.0
Time: 13460ms
       Asset     Size  Chunks                    Chunk Names
    build.js  1.09 MB       0  [emitted]  [big]  main
build.js.map  1.35 MB       0  [emitted]         main

ERROR in ./~/ping-monitor/lib/tcp.js
Module not found: Error: Can't resolve 'net' in '/Users/amartinez/Documents/heartbeat/node_modules/ping-monitor/lib'
 @ ./~/ping-monitor/lib/tcp.js 3:12-26
 @ ./~/ping-monitor/lib/monitor.js
 @ ./~/ping-monitor/app.js
 @ ./src/mixins/pingLogic.js
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./src/components/Remote.vue
 @ ./src/components/Remote.vue
 @ ./~/babel-loader/lib!./~/vue-loader/lib/selector.js?type=script&index=0!./src/components/RemotesList.vue
 @ ./src/components/RemotesList.vue
 @ ./src/routes.js
 @ ./src/main.js

ERROR in build.js from UglifyJs
Unexpected token: name (req) [./~/ping-monitor/lib/http.js:24,0][build.js:26698,6]
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `cross-env NODE_ENV=production webpack --progress --hide-modules`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/amartinez/.npm/_logs/2019-02-15T14_48_27_179Z-debug.log

Hi @ackzell , thank you for raising the issue.
There are 2 main changes that I made in the newer versions:

I upgraded the JavaScript to  ES6 as of v0.2.0. The Uglify plugin is catching that as an error.
In v0.3.0 I added support for TCP servers and introduced the net module.

I'm not familiar with webpack but I'm sure you can configure it to fix these issues.  Also upgrading it to v4.x would help.

P.S. I'm also building an electron version of your app with a few other changes, will share when done.

I upgraded the JavaScript to  ES6 as of v0.2.0. The Uglify plugin is catching that as an error.

Okay, good to know. I think I have a quick workaround and will use that in the meantime 😄

P.S. I'm also building an electron version of your app with a few other changes, will share when done.

Sweet! Looking forward to see it 👍

Hi @ackzell, please let me know if you managed to get the module working? I have an upcoming release and would like include fixes for current bugs.

Hi @qawemlilo,
My workaround was to ignore (exclude key in webpack.config.js) this package like I do for the other packages like fs. I was able to build the app for now, but I haven't recorded the video yet, so it would be really awesome if we could get your changes in and avoid the workaround altogether just by pulling in your latest version.

Hi @ackzell, thank you for your feedback, it's really helping me improve the quality of the package.
I have released a new version which should be compatible your old settings: https://www.npmjs.com/package/ping-monitor/v/0.2.1.
My advice is that you lock your app updates on that minor version (v0.2.x). If they're any more fixes required I'll simply bump it up.
I'm expanding the scope of the module and chances are that you'll experience more braking changes with v0.3 or greater.
Kind Regards

Thanks for getting back to me!
So, I am not sure that the issue was resolved in 0.2.1, this is what I get:
✘-1 ~/Documents/heartbeat [master|✚ 5]
09:13 $ npm ls ping-monitor
<EMAIL_ADDRESS>/Users/amartinez/Documents/heartbeat
└──<EMAIL_ADDRESS>
✔ ~/Documents/heartbeat [master|✚ 5]
09:13 $ npm run build

><EMAIL_ADDRESS>build /Users/amartinez/Documents/heartbeat
> cross-env NODE_ENV=production webpack --progress --hide-modules

Hash:<PHONE_NUMBER>affd2d835b
Version: webpack 2.7.0
Time: 14445ms
       Asset     Size  Chunks                    Chunk Names
    build.js  1.09 MB       0  [emitted]  [big]  main
build.js.map  1.35 MB       0  [emitted]         main

ERROR in build.js from UglifyJs
Unexpected token: punc ()) [./~/ping-monitor/lib/monitor.js:67,0][build.js:26738,29]
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `cross-env NODE_ENV=production webpack --progress --hide-modules`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/amartinez/.npm/_logs/2019-02-20T15_14_12_637Z-debug.log

Good advice, I'll stick to 0.2.x at least to finish the video recordings. Thanks again @qawemlilo !

Hey @ackzell , Looks like I missed some fat arrow functions, new patch available: https://www.npmjs.com/package/ping-monitor/v/0.2.2

🎉 That one worked!
On Wed, Feb 20, 2019 at 1:21 PM Qawelesizwe Mlilo<EMAIL_ADDRESS>wrote:

Hey @ackzell https://github.com/ackzell , Looks like I missed some fat
arrow functions, new patch available:
https://www.npmjs.com/package/ping-monitor/v/0.2.2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/qawemlilo/node-monitor/issues/10#issuecomment-465717666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkssvZZJEd7E_aICIqBfCmRXMuXMtS3ks5vPaAcgaJpZM4a91ZW
.

--
Axel Uriel Martínez Castillo

Sweet! Looking forward to see it 👍

Just put up something, still work in progress: https://github.com/qawemlilo/uptime-emitter


chore: Add missing kubebuilder annotation

A kubebuilder RBAC annotation was added to correspond to an addition in PR #130
for "namespaces/finalizers".

/lgtm


remove dependency on controller-runtime fork

depending on controller-runtime fork is awkward, as discussed at https://github.com/kubeflow/kfserving/pull/1144#discussion_r514079339
this is an attempt to remove that dependency - let's see what e2e tests say

/retest

I encountered the same error with this change as the e2e test during make deploy-dev:
The CustomResourceDefinition "inferenceservices.serving.kubeflow.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

I encountered the same error with this change as the e2e test during make deploy-dev:
The CustomResourceDefinition "inferenceservices.serving.kubeflow.org" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

Interesting. There seem to be some threads out there online about that error.

Interesting. There seem to be some threads out there online about that error.

Yes, but maxDescLen is already set to 0 this time and it's still too long.

/lgtm

Think we can close this since PR #1341 fixed this issue.

thanks @pugangxa ! closing this.


Captions shown only when hovered over image?

First off thanks a lot for this great image slider, it has been great so far considering my basic knowledge of HTML and non-existent knowledge of java script.
I've got my fotorama just like I want it, except my captions are too distracting so I only want them shown if the mouse is hovering over the image (much like how just like how the arrows and full screen button show only when hovering over the image).
I've attempted to replicate X4's advice here (https://github.com/artpolikarpov/fotorama/issues/168) without any success. Either I am doing it wrong or the code is now out of date.
Any advice?

This feature can be added easy only in styles.


API Error Reading Resource Subscription (Subaccount) [BUG]

Is there an existing issue for this?

[X] I have searched the existing issues

What version of the Terraform provider are you using?
1.4.0
What version of the Terraform CLI are you using?
1.9.2
What type of issue are you facing
bug report
Describe the bug
Error: API Error Reading Resource Subscription (Subaccount)
received response with unexpected status [Status: 404; Correlation ID: e5027ee5-f39d-a2b2-e198-949c4ed8e73c]
Expected Behavior
Finish apply or import without an error
Steps To Reproduce
terraform {
  required_providers {
    btp = {
      source  = "SAP/btp"
      version = "1.4.0"
    }
  }
}

terraform {
  backend "kubernetes" {
    config_path      = "~/.kube/kyma.yaml"
    secret_suffix    = "state"
    namespace        = "devops-tf-state"
  }
}

resource "btp_subaccount_subscription" "subaccount_subscription" {
  subaccount_id = <subaccount_id>
  app_name      = "feature-flags-dashboard"
  plan_name     = "dashboard"
}

TF_LOG=DEBUG terraform import module.btp_subaccount_subscription.subaccount_subscription "<subscription_id>","feature-flags-dashboard","dashboard" or terraform apply generates error "API Error Reading Resource Subscription (Subaccount)"
Also tested with auditlog-viewer service, plan: free. With the same result
User's Role Collections
Subaccount Administrator
Subaccount Service Administrator
Add screenshots to help explain your problem
module.feature_flags_dashboard_subscription.btp_subaccount_subscription.subaccount_subscription: Importing from ID "subaccount_id,feature-flags-dashboard,dashboard"...
module.feature_flags_dashboard_subscription.btp_subaccount_subscription.subaccount_subscription: Import prepared!
  Prepared btp_subaccount_subscription for import
module.feature_flags_dashboard_subscription.btp_subaccount_subscription.subaccount_subscription: Refreshing state...
2024-07-22T22:38:09.685+0300 [ERROR] provider.terraform-provider-btp_v1.4.0: Response contains error diagnostic: @module=sdk.proto diagnostic_detail="received response with unexpected status [Status: 404; Correlation ID: e5027ee5-f39d-a2b2-e198-949c4ed8e73c]" diagnostic_severity=ERROR tf_req_id=ff4f4b68-e588-a1d7-cc6a-22704340c2eb tf_rpc=ReadResource diagnostic_summary="API Error Reading Resource Subscription (Subaccount)" tf_proto_version=6.6 tf_provider_addr=registry.terraform.io/sap/btp tf_resource_type=btp_subaccount_subscription @caller=github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/internal/diag/diagnostics.go:58 timestamp=2024-07-22T22:38:09.685+0300
2024-07-22T22:38:09.686+0300 [ERROR] vertex "import module.feature_flags_dashboard_subscription.btp_subaccount_subscription.subaccount_subscription result" error: API Error Reading Resource Subscription (Subaccount)
2024-07-22T22:38:09.686+0300 [ERROR] vertex "module.feature_flags_dashboard_subscription.btp_subaccount_subscription.subaccount_subscription (import id \"subaccount_id,feature-flags-dashboard,dashboard\")" error: API Error Reading Resource Subscription (Subaccount)
╷
│ Error: API Error Reading Resource Subscription (Subaccount)
│
│ received response with unexpected status [Status: 404; Correlation ID: e5027ee5-f39d-a2b2-e198-949c4ed8e73c]
╵

Meanwhile, btp list accounts/subscription --subaccount subaccount_id show proper subscription to the application.
Additional context
No response

@akanevskys I cannot reproduce the error you describe. The terraform apply as well as an import work. I assume that the required IDs are not filled/propagated correctly maybe due to your modularized setup.
To narrow down the cause, can you please try the following setup:

Remove the state backend configuration, so that the provider.tf looks like this;

   terraform {

  required_providers {
    btp = {
      source  = "SAP/btp"
      version = "~>1.4.0"
    }
  }
}

provider "btp" {
  globalaccount = <SUBDOMAIN OF YOUR GLOBAL ACCOUNT>
}

Add a new file to your setup, called import.tf with the following content:

import {
  to = btp_subaccount_subscription.subaccount_subscription
  id = "<YOUR SUBACCOUNT ID>,feature-flags-dashboard,dashboard"
}

Add/Adjust the main.tf file with the following content

resource "btp_subaccount_subscription" "subaccount_subscription" {
  subaccount_id = <YOUR SUBACCOUNT ID>
  app_name      = "feature-flags-dashboard"
  plan_name     = "dashboard"
}

Execute a terraform init and a terraform apply and check if this setup works
If this works you should add the state backend and validate that this works too.

@lechnerc77 thank you so much! Your code was refreshing way to figure out proper global account subdomain value.
Global account subdomain should be copy-pasted from BTP Control Center not from BTP Cockpit, where it's wrong. Another way to figure out proper global account subdomain it's btp cli output after btp login --sso

@akanevskys Great that you figured it out. However the subdomain of the global account is correctly displayed in the cockpit (otherwise customers would have a hard time as they have no access to the BTP COntrol Center). Maybe a glitch when copying it as unortunatly there is no "copy" button for this attribute


Dim/blur/grey settings not applying on user change in settings

On my Pixel running 7.1.1, using Beta 7, dragging any of the sliders in advanced settings doesn't seem to take any effect 😕

Clearing data solves the problem for me

Did you try:

Hitting the 'Reset sliders' option?
Changing to a different wallpaper and then back to Muzei?
Restarting your device?

I'm not sure why any of those things would cause the sliders to not work though.

Tried to reset sliders but that didn't fix it. Didn't try the other two, but clearing data fixed it. My guess is a restart would've fixed it. Oh well :-/

Another report on this Google+ post, investigating.


Introduce a feature to associate parameters with a method mentioned in Regex

Introduce a feature to associate parameters with a method mentioned in Regex parameter.

This became possible in 0.10.x's programming model, where each leaf term requires a parameter value method, each of whose parameters requires @From annotation.