Patching fails if either patch text or base text have Windows line endings (CRLF)

This crate seems to fail if either the patch text or the text being patched contain Windows line endings. For example, the following test cases:
let text_lf = "Allomancy\nFeruchemy\n";
let text_crlf = "Allomancy\r\nFeruchemy\r\n";

let patch_lf =
    "\
    --- original\n\
    +++ modified\n\
    @@ -1,2 +1,3 @@\n Allomancy\n Feruchemy\n+Hemalurgy\n";

let patch_crlf =
    "\
    --- original\r\n\
    +++ modified\r\n\
    @@ -1,2 +1,3 @@\r\n Allomancy\r\n Feruchemy\r\n+Hemalurgy\r\n";

let p_lf = Patch::from_str(&patch_lf).unwrap();
let p_crlf = Patch::from_str(&patch_crlf);

assert!(diffy::apply(text_lf, &p_lf).is_ok());   // OK
assert!(p_crlf.is_ok());                         // ParsePatchError("invalid char in unquoted filename")
assert!(diffy::apply(text_crlf, &p_lf).is_ok()); // ApplyError(1)

The latter two asserts fail. Would you be open to supporting Windows line endings in this crate? I'd be happy to PR if one is welcome.

Thanks for the bug report! Yes I do think that diffy should better handle windows line endings although I think that fixing one of those asserts is more straight forward than the other.
let p_crlf = Patch::from_str(&patch_crlf).unwrap()

Parsing a patch with CRLF line endings should succeed. Taking a quick look at this it seems like theres an easy fix for this in the patch header parsing logic.
assert!(diffy::apply(text_crlf, &p_lf).is_ok());

This one is a bit more complicated. Applying a patch which has different line endings from the text that is being patched is something that would require a bit more smarts on the matching of where the patch should be applied. Some other tools seem to either fail to apply (e.g git-apply) while others do some fuzzy-matching to get the patch to apply (e.g. unix `patch) but then leave the patched with with mixed line endings. So I'm not quite sure what the best way to tackle this would be.
Fixing the first issue, though, would let you do the following without issue (patching a crlf file with a crlf patch):
diffy::apply(text_crlf, &p_crlf)

Yeah now that you mention it, it would probably be reasonable to leave the mixed line endings case alone, though I do think that leaving the patched file with mixed line endings is an acceptable outcome with that kind of edge case.
The other two should be pretty simple, though, yes. I can take a look into them.


Storage Drawers Fill Level Indicator Doesn't Appear on Framed Compacting Drawers

Hello! I came across this mod in Vault Hunters, and ran into this small issue.
Storage Drawers added (re-added?) fill level indicators and when the Fill Level Upgrade is placed in any variety of Framed Compacting Drawer, the fill level indicator is not displayed.

Please let me know if there is any useful information or additional testing I can provide.
Thanks!

What game version is this?

Running Minecraft 1.16.5
Vault Hunters modpack 1.13.4
(https://vaulthunters.gg/)


Changing TopBar Color

Hi! Wonderful library to use for the application which I am developing. Just curious if it is possible to change the color of the topbar? If not, how should I be creating my own cusom topbar?

You can hide the topbar and then provide your own, check the sample to learn how to hide it or the wiki.


Can't seem to connect to Archipelago server

Hi,
I'm trying to connect to a game, and so far all that happens is that it spins waiting trying to connect to the server forever (even when run as administrator, and explicitly allowed through the firewall, host url double checked, etc) and I can't really provide more info than that because nothing new ever gets printed to the output console and it seems like the timeout duration is extremely long:

I know the server host URL and port work and they're not inactive, because I'm able to connect (e.g. via bizhawk, etc) for other games that are part of the async.
Is there anything obvious that would prevent this from working that I might be missing?

I believe main website rooms now use the secure WSS protocole instead of WS.
What happens if you put wss://archipelago.gg:64845 as host instead?
This is a user-friendliness issue that will get fixed soon 😉

Ahh, ok that was it. Thanks!


InflateException coming for few android 7.0 devices

InflateException is coming for few android device having version 7.0 on eample code
android:layout_marginTop="@dimen/_45ssp".
Stacktrace:
Caused by: android.view.InflateException: Binary XML file line #33: Binary XML file line #33: Error inflating class TextView
Caused by: android.view.InflateException: Binary XML file line #33: Error inflating class TextView
Caused by: java.lang.UnsupportedOperationException: Can't convert value at index 2 to dimension: type=0x1
at android.content.res.TypedArray.getDimensionPixelSize(TypedArray.java:720)
at android.widget.TextView.(TextView.java:1088)
at android.widget.TextView.(TextView.java:704)
at android.support.v7.widget.bm.(Unknown Source)
at android.support.v7.widget.bm.(Unknown Source)

You can include ,values folders inside your project instead lib.that might help you

Did you add ssp or only sdp?
To add also ssp, please use:
dependencies {
compile 'com.intuit.ssp:ssp-android:1.0.4'
}

Yah. I missed the point of separate lib for non text and text views. Thanks !!

I got one more crash in textview. It is again 7.0 device moto G5 Plus.
Binary XML file line #36: Binary XML file line #36: Error inflating class TextView.
Code:

Already include compile 'com.intuit.ssp:ssp-android:1.0.4' line in code.

Code:
TextView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:gravity="center"
android:textColor="@color/app_text_color"
android:text="@string/verify_phone_number_reason_message"
android:id="@+id/textView4"
android:textSize="@dimen/_12ssp"

I don't think so it was because of ssp !! May be binding error I guess !!

Can you try rebuilding the project? I just tried a similar code on android 7.0 emulator and it worked well.

This is not an always. Crash is happening on few android 7.0 devices ( mainly on moto G). Even I also tested it for nexus and pixal and samsung device, it is working fine. Do you know why it is not working for few devices ?

Is it possible that you will try to fix it and send back a pull request?
I have only few devices and no moto G...
If it's not possible please send the list of devices with the issue and I will buy one.

Yah , i am working on this issue. Today i found that this could be because of memory leak mentioned on this stackoverflow page : http://stackoverflow.com/questions/4512981/android-view-inflateexception-binary-xml-file-line-12-error-inflating-class.
I am also working on fixing memory leak issues and let you if i face this crash again.

Please update your textview xml tag here, this will help to fix the inflate issue. @hmittal1

Seems like it doesn't relate to sdp, please let me know if I'm wrong.

Hi,
I get this issue too on Android 7 when user use split-screen mode
I think you should create new dimens folder for split-screen mode
How do you think about that @elhanan-mishraky ?
Thanks a lot

@vankhoa01 is it possible that you will create a pull request with the required fix?

I just duplicate values-sw300dp and named is values for fixing.
But I think it's not good solution
Could you give me some hint for this case ?

@vankhoa01 I will try to fix it this week.

Great

@vankhoa01 the fix is published, please use 1.0.5 and let me know if it goes well :)


Config UI design a pipeline page that's compliant with the new /pipelines api

Description
When Create an entity to represent a tasks Triggeration · Issue #824 · merico-dev/lake done, POST /task behave differently. config-ui need a new design for task management to work properly
The coming pipeline api design is much more like gitlabs. In gitlab, a pipeline contains a set of job; in devlake, a pipeline contains a set of task, job/task share the same execution manner as following screenshot

And users can manage them both pipeline and task based on what they need:

Describe the solution you'd like
Design our pipeline and task management similar to pipeline and job from gitlab. no need to be as complete as gitlab but share the same idea to fulfill our need at the moment.
And I would like the tasks layout to be arranged accordingly to our json body as following:

Additional context
This depends on issue #824
@e2corporation let me know if you need more context

This should be moved to the next iteration after further discussion around context & needs. We still have an open-ended set of tickets for Triggers/Tasks re-design.

@e2corporation This seems related to revamping the design of the trigger page. Pipelines page will replace Tasks page in the new design. I'm gonna keep it in iter5, but only for the design phase, we don't have to finish the implementation of the new triggers and pipelines page within this iter. cc @klesh @Startrekzky @joncodo

Manage Pipelines
User Stories

[ ] As a Developer, I want to see a list of ALL Pipelines
[ ] As a Developer, I want to see a list of ACTIVE Pipelines
[ ] As a Developer, I want to see a list of COMPLETE Pipelines
[ ] As a Developer, I want to see a list of FAILED Pipelines
[ ] As a Developer, I want to be able to SEARCH Pipelines

[ ] Search by Pipeline Name
[ ] Search by Pipeline Status
[ ] Search by Date?

[ ] As a Developer, I want to see/filter the STATUS of a Pipeline

[ ] Active (Running)
[ ] Complete
[ ] Failed

[ ] As a Developer, I want to see Percentage (%) PROGRESS of a Pipeline (ie 87% )
[ ] As a Developer, I want to be able to STOP a running Pipeline
[ ] As a Developer, I may want the ability to STOP ALL running Pipelines in the event of a race condition or failure.
[ ] As a Developer, I want to be able to DELETE a Stopped Pipeline
[ ] As a Developer, I want to be able to EDIT/CONFIGURE a Pipeline
[ ] As a Developer, I want to be able to RESTART a Running Pipeline
[ ] As a Developer, I want to be able to RESTART a Failed Pipeline
[ ] As a Developer, I want to see overview details for a Pipeline

[ ] Pipeline Name
[ ] Last Run Date
[ ] Status

[ ] As a Developer, I want to be able to click a Pipeline to see Detailed Pipeline Activity
[ ] As an Engineering Manager, I want to see enabled Data Providers for each Pipeline
[ ] As an Engineering Manager, I want to manage ALL Pipelines
[ ] As an Engineering Manager, I may want to be notified  of Pipeline FAILURES (via e-mail)
[ ] As a Developer, I want to access to Pipelines API Documentation
[ ] As a Developer, I want access to Create New Pipeline (Convenience Link)

Pipeline Run Details
User Stories

[ ] As a Developer, I want to see Start Date/Time of a Pipeline Run
[ ] As a Developer, I want to see detailed Pipeline Run Activity
[ ] As a Developer, I want to see the overall Pipeline Status
[ ] As a Developer, I want to see the Stages for a Pipeline
[ ] As a Developer, I want to see the Progress for each Stage
[ ] As a Developer, I want to see the Tasks for each stage
[ ] As a Developer, I want to see the  Pipeline Duration (Execution Time)
[ ] As a Developer, I want to be able to RESTART a Running Pipeline
[ ] As a Developer, I want to be able to RESTART a Failed Pipeline
[ ] As a Developer, I want to be able to Go BACK to Manage Pipelines
[ ] As a Developer, I want to see the Failure/Error Responses for a Stage
[ ] As a Developer, I want to see the Failure/Error Responses for a Task
[ ] As an Engineering Manager, I want to see a pipeline's health and performance.

Create Pipeline (Blueprint)
User Stories

[ ] As a Developer, I want to be able to CREATE a Pipeline
[ ] As a Developer, I want to be able to EDIT a Pipeline
[ ] As a Developer, I want to be able to DELETE a Pipeline
[ ] As a Developer, I want to be able to enable/disable (choose) which Data Providers to configure for a pipeline.
[ ] As a Developer, I want to be able to specify Trigger SETTINGS for a Data Provider
[ ] As a Developer, I want to be able to have access to MANAGE Settings for a Data Provider (convenience link)
[ ] As a Developer I may want to enable SCHEDULING for a Pipeline to trigger at a specified interval
[ ] As a Developer I may want to have the option to RUN the pipeline once automatically after saving/creating a new pipeline.

@joncodo @hezyin @klesh @kevin-kline @Startrekzky

@joncodo @hezyin

Why is a blueprint page here?
Aren't we attack the blueprint feature on another issue?

Why is a blueprint page here?
Aren't we attack the blueprint feature on another issue?

@klesh I was asked to create these 3 concepts with the "blueprint" plan applied. Maybe we'll have to design an alternate concept without blueprint/plan so it matches implementation.

Hi @e2corporation , thanks for the user stories and prototype.
Overall, I think

the information structure is unclear. It looks like the Pipeline Blueprint and Pipeline Run are mixed under the same tabs.
there is too much text, operations and colors on theses pages that I don't know how to get started and finish the tasks.

..., and my feedback is focusing on these aspects.

There isn't a status for 'Pipeline Blueprint' object, as it's only a schedule, not a specific job. Therefore, there shouldn't be a 'status filtering menu' on this page. Same goes for the 'status' and 'duration' columns in the list.

There should be a page for 'Pipeline Runs' to present their status, duration, and running time. Something like this:

These two points above are the most important.
3. Can we remove the 'preview' section from the 'Manage Pipeline'? Since we already have it on the 'pipeline run activity/detail page'.

2.
3. Can the 'New' button be bigger with background color? This button should be one of the most catchy elements on the 'pipeline run list' page, as it's a user's very first action when he/she entered this page.

@Startrekzky As discussed in earlier meetings today, many of the discrepancies are due the fact that we are designing with the Blueprint(Plan) schema in mind however the current implementation isn't ready for the features demonstrated above. With our new direction we are trimming all of this down to support what Backend has designed, which is to primarily support Pipeline Runs for this coming iteration.

There isn't a status for 'Pipeline Blueprint' object, as it's only a schedule, not a specific job. Therefore, there shouldn't be a 'status filtering menu' on this page. Same goes for the 'status' and 'duration' columns in the list.

Since the pipeline runs would have a child relationship to the Blueprint, we could consolidate all this data into one "manage" screen which is what this mockup is providing a glimpse of. So the filtering would be filtering pipelines that have runs matching a specific status. The overall status of the pipeline is a reflection of the last run, so that's a bit of reasoning why this concept can be possible. A fourth "All Jobs" Page can still be design and be useful, it just wasn't requested however for these initial mockups.

There should be a page for 'Pipeline Runs' to present their status, duration, and running time. Something like this:

This is being accomplished by the "Pipelines Activity" screen above, which is a detailed look at the Pipeline (Blueprint) that would show the Run history.

What do users see on 'Pipeline Blueprint' page by default? A blank 'Pipeline blueprint' list? If so, can the 'New' button be bigger with background color? This button should be one of the most catchy elements on the 'pipeline run list' page, as it's a user's very first action when he/she entered this page.

In a no-data/first-time-use scenario a message would be displayed that there are no blueprints defined and that the user should create one to proceed. The "Add" functionality isn't accentuated in these mockups because we already agreed on what the "Create Pipeline" screen should look like, these mockups were more aimed at managing the pipelines. I do agree with you that the "Add New" button should stand out more and it will get a primary color accent during implementation.

What will users see after creating a pipeline. Jump back to the 'Pipeline Blueprint' list? And how does a user trigger a 'Pipeline Run', I'd like to see more pages to reflect a specific use case of 'collect data'.
Point 1&2 are the most important. Point 3&4 are of interaction-level and are also very important. Other minor issues such as aesthetic-level issues can be polished later.

After creating a Pipeline, we could automatically redirect the user to the "Pipeline Activity" page OR the "Manage Pipelines" page. Both can and should be capable of presenting the user with the status of the current active/running pipeline so they can easily see what pipeline is active. As far as the "Job Details" for a particular run/execution, that would consist of the Collection Steps that are now present on the triggers page.

Latest design mockups attached for our next discussion/questions round regarding Pipelines. Overall I think we are headed in the right direction towards supporting a minimal interface that will work with the current BE design. Looking forward to team feedback and next steps.

@Startrekzky @joncodo @hezyin @kevin-kline @klesh

Great job, some minor wording:

Missed pipeline run name, we do have name for pipeline run.
Rename "stop" to "cancel" to algin BE/FE terminology
Logging windows is great, but keep in mind we dont have logging api at the moment.

Pipelines Concepts V1.2
Apply feedback from last review session on 12/13/2021.

Add Support for Pipeline Run Name (Auto-generated default)
Rename "Stop" to "CANCEL"
Optimize Data-table controls for All Pipelines (Manage)
Show Run Settings on Activity/Details page
Text/Copy Updates

Moved to #962


Crash in the onBeforeRequest_cb handler

https://sentry.adguard.com/adg/adguard-mac/issues/12589/?query=is:unresolved

Seems that nil is not allowed as value in collections in Obj-C
https://developer.apple.com/documentation/foundation/nsnull?language=objc

Issue moved to AdguardTeam/AdguardForMac #352 via ZenHub


azservicebus: intermittent CBS authentication failure

Hit during live testing some updated go-amqp bits.  The error is inconsistent, and it's possible this is due to the updated go-amqp bits.  Unable to repro locally.
2022-11-22T18:00:41.8114564Z === RUN   TestNewClientWithAzureIdentity
2022-11-22T18:00:41.8129868Z Env cred works, being added to our chained token credential    client_test.go:61:
2022-11-22T18:00:41.8132122Z         	Error Trace:	client_test.go:61
2022-11-22T18:00:41.8133765Z         	Error:      	Received unexpected error:
2022-11-22T18:00:41.8142253Z         	            	*Error{Condition: amqp:unauthorized-access, Description: Unauthorized access. 'Send' claim(s) are required to perform this operation. Resource: 'sb://***/queue-1729f9d8a51c505e'. TrackingId:63d119632fc045ae9c7391d7f7f671c9_G1, SystemTracker:gateway7, Timestamp:2022-11-22T17:57:27, Info: map[]}
2022-11-22T18:00:41.8144893Z         	Test:       	TestNewClientWithAzureIdentity
2022-11-22T18:00:41.8146827Z --- FAIL: TestNewClientWithAzureIdentity (2.14s)

We've seen this before - it appears there's a propagation delay between the service getting RBAC'd and the credential actually being valid.
We could "fix" this by adding in some retries, perhaps.


create-remix cli run into error when trying to run npx remix init

What version of Remix are you using?
1.6.7
Steps to Reproduce
Run create-remix cli with options below:

Expected Behavior
The cli run remix.init script successfully
Actual Behavior
The remix.init script run into error
🚨 Oops, remix.init failed
Cannot read properties of undefined (reading 'length')

This will be fixed by #138


Errror using custom loss

Hello!
I've tried to use custom loss function like this:
def rmlse(y_true, y_pred):
    return mean_squared_logarithmic_error(y_true, y_pred)**0.5

optimizer = keras.optimizers.Adam(learning_rate=0.05)
model.compile(optimizer=optimizer, loss=rmlse, metrics=['mean_absolute_error'])

The model was built successfully, but when we tried to upload that model with mlem, the provided error rises:
Unexpected error: Unknown loss function: 'rmlse'. Please ensure you are using a keras.utils.custom_object_scope and that this object is included in the scope. See
https://www.tensorflow.org/guide/keras/save_and_serialize#registering_the_custom_object for details.

How can I use the custom loss functions?
Thanks!

I assume this happens when trying to load the model.
Looks like MLEM does not pin down this requirement when recursively going over the model at saving, I guess we need to see if this is fixable as a special case + add some option to make MLEM investigate reqs deeper (get more broad list of reqs, but at the same time pin reqs like this down).


Fixed minor typo

Have you looked at the guidelines for contributing to this codebase?
Have you added tests and run apm test?

Thanks a ton!
Congratulations on the first github contribution! I appreciate it.


Docs: Add chmod to install instructions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Feature suggestion for trillium-websocket: Add access to peer_ip from WebSocketConn

Currently, there is no way to access some methods of trillium::Conn from trillium_websocket::WebSocketConn, with the same issues as to require trillium::Conn's own .inner escape hatch. Alternatively, exposing said hatch of trillium::Conn would also be viable to provide such access to lower-level methods.

Which methods? WebsocketConn does not contain a Conn, but we can move data over to the WebSocketConn. What specific data do you want?

released as<EMAIL_ADDRESS>

Thanks, having it definitely allows us to simplify things that need access to it.


Add more configurations for Identity providers in UAA

Add parameter because of documentation reason
The support in bosh is given already because all sub parameters are taken over from bosh config into uaa.yml

LGTM


Update docker library to resolve URL error tied to requests library

See: https://github.com/docker/docker-py/issues/3256
This is almost impossible to troubleshoot as an end user and effectively breaks the tool. Triage and release ASAP.

Solved with #78


Find-PSResource does not accept pipeline input

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
I should be able to take the output from Get-PSResource and pipe that to `Find-PSResource in order to find out what versions are on the repository.
Get-PSResource operationvalidation | Find-PSResource

This is can be resolved by adding ValueFromPipelineByPropertyName to Name and Repository parameters.
Expected behavior
Get-PSResource operationvalidation | Find-PSResource

Name                Version Prerelease Repository Description
----                ------- ---------- ---------- -----------
OperationValidation <IP_ADDRESS>            PSGallery  A set of tools for executing validation of the operation of a system. It provides a way to organize and ex…

Actual behavior
No resources are returned

Error details
No response
Environment data
ModuleType Version    PreRelease Name                                ExportedCommands
---------- -------    ---------- ----                                ----------------
Binary     3.0.12     beta       PowerShellGet                       {Find-PSResource, Get-PSResource, Get-PSResourceRepository, Install-PSResource…}

Name                           Value
----                           -----
PSVersion                      7.2.4
PSEdition                      Core
GitCommitId                    7.2.4
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Thanks @ThomasNieto for this feedback...for this scenario are you hoping just the name gets passed into the find call (in this case to see all verisions available), or are you hoping that the version of the installed module gets used as well? I'd love to just better understand the purpose of the original get call vs directly piping the name?

In my use case would be to get the list of installed resources and then find the latest version available on the repo. My use case doesn't need the version passed as well.


IMPORT NOT RESOLVED: Delegation on running the verifier inside project's root

I have asdf to manage my versions and hence i run the verifier in the contract's root. The path is added to the zsh config to run the command but I face the error - IMPORT NOT RESOLVED: Delegation error. I also don't use any super imports in the contract which might give this import error.
My Configuration -

scarb 2.6.3
cairo: 2.6.3
sierra: 1.5.0

Error logs -
starknet-contract-verifier
[1/4] 📝 Getting project information...
[2/4] 🔗 Resolving project...
     Running git clone --local --verbose --config core.autocrlf=false --recurse-submodules /Users/ayushtomar/Library/Caches/com.swmansion.scarb/registry/git/db/custom_uri_component-4jc1f38gijv8g.git /Users/ayushtomar/Library/Caches/com.swmansion.scarb/registry/git/checkouts/custom_uri_component-4jc1f38gijv8g/e59d4d0
     Running git reset --hard e59d4d00cfecccb1681fad1862eb835df76184cf
     Running git clone --local --verbose --config core.autocrlf=false --recurse-submodules /Users/ayushtomar/Library/Caches/com.swmansion.scarb/registry/git/db/cairo-contracts-9cboa8jg3jldq.git /Users/ayushtomar/Library/Caches/com.swmansion.scarb/registry/git/checkouts/cairo-contracts-9cboa8jg3jldq/978b4e7
     Running git reset --hard 978b4e75209da355667d8954d2450e32bd71fe49
   Compiling starknet-contract(twitter_nft_contract) twitter_nft_contract v0.1.0 (/Users/ayushtomar/Desktop/work/twitter_nft/contracts/Scarb.toml)
error: IMPORT NOT RESOLVED: Delegation
Error: could not compile `twitter_nft_contract` due to previous error

@liam-nethermind can you point which issue is the original one so i can follow for the fix?

@liam-nethermind can you point which issue is the original one so i can follow for the fix?

@ayushtom You can follow #11.

Hey @ayushtom can you please share the minimal code for reproducing this or share the project in which this was an issue? Thanks a lot!

Hey!
The contract is not open sourced yet but i can share the imports on the main.cairo or the scarb.toml file which can help you.
scarb.toml
[package]
name = "twitter_nft_contract"
version = "0.1.0"

# See more keys and their definitions at https://docs.swmansion.com/scarb/docs/reference/manifest.html

[dependencies]
starknet = ">=2.4.4"
openzeppelin = { git = "https://github.com/OpenZeppelin/cairo-contracts.git", tag = "v0.13.0" }
custom_uri = { git = "https://github.com/starknet-id/custom_uri_component", rev = "e59d4d00cfecccb1681fad1862eb835df76184cf" }

[[target.starknet-contract]]
sierra = true
casm = true
casm-add-pythonic-hints = true

[lib]
sierra = true
casm = true

[tool.voyager]
my_contract = { path = "main.cairo" }

main.cairo
    use openzeppelin::token::erc1155::erc1155::ERC1155Component::InternalTrait;
    use twitter_nft_contract::interface::{
        erc1155::{
            IERC1155_ID, IERC1155_METADATA_URI_ID, IERC1155_RECEIVER_ID
        },
        twitter_nft::ITwitterNft
    };
    use core::debug::PrintTrait;
    use openzeppelin::{
        introspection::{src5::SRC5Component},
        access::ownable::OwnableComponent,
        token::erc1155::{ERC1155Component, ERC1155HooksEmptyImpl,interface::IERC1155MetadataURI},
        upgrades::{UpgradeableComponent, interface::IUpgradeable},
    };
    use starknet::{get_contract_address, get_caller_address};
    use starknet::{ContractAddress, ClassHash};


showing attribute repeatedly in rarity without values

Checklist

[X] I have read COMMON_ISSUES.md
[X] I have searched existing issues

Description
when generate rarity it shows attribute over and over without values. Eg. if have 5 layers, rarity showing with generated values for 1 st  layer and other 4 layers without generated values. it happens to each layer and showing rarity 25 times.

this is my layer configuration.

it shows unnecessary attributes for all traits, after each layer, like highlighted in above image.
if have 5 layers and 5 traits for each layer. (Total 25 layers), rarity show 25 times for each trait types. (5 with values and 20 without values for one trait type, total have 125. unnecessary 100 and 25 with values)
Steps to reproduce
No response
Expected result
No response
Actual result
No response
Environment
OS Version (uname -a on unix, systeminfo on windows):
Node.js version (node -v):

@sadun619 if you generated a collection then added more images, those extra images would show up since that's how the script gets the list of images.
If you don't want them to show up you could change lines ~64-70:
https://github.com/bolshoytoster/hashlips_art_engine/blob/16a9d9c2581ff78f13db064d1e830a0e5d8d2637/utils/rarity.js#L64-L70
to
    if (rarityData[layer][attribute].occurrence == 0) {
        delete rarityData[layer][attribute];
    } else {
      // get chance
      let chance =
        ((rarityData[layer][attribute].occurrence / editionSize) * 100).toFixed(2);

      // show two decimal places in percent
      rarityData[layer][attribute].occurrence =
        `${rarityData[layer][attribute].occurrence} in ${editionSize} editions (${chance} %)`;
    }

@sadun619 if you generated a collection then added more images, those extra images would show up since that's how the script gets the list of images.
If you don't want them to show up you could change lines ~64-70:
https://github.com/bolshoytoster/hashlips_art_engine/blob/16a9d9c2581ff78f13db064d1e830a0e5d8d2637/utils/rarity.js#L64-L70
to
    if (rarityData[layer][attribute].occurrence == 0) {
        delete rarityData[layer][attribute];
    } else {
      // get chance
      let chance =
        ((rarityData[layer][attribute].occurrence / editionSize) * 100).toFixed(2);

      // show two decimal places in percent
      rarityData[layer][attribute].occurrence =
        `${rarityData[layer][attribute].occurrence} in ${editionSize} editions (${chance} %)`;
    }

it's working. thank you.


Implement Pluggable EngineSpec

What
This PR goes part way to implement a pluggable engine specification as outlined in #2542. Below are some decisions we need to make regarding compatibility with previous versions of bacalhau.

[x] Per https://github.com/bacalhau-project/bacalhau/discussions/2605 we will be supporting backwards compatibility so keeping these types, but in a package for previous versions
Keep or Kill Spec.Engine, Spec.JobSpecDocker, and Spec.JobSpecWasm?: This decision will affect engine pluggability moving forward.

Keep:

We remain backwards compatible with previous versions of bacalhau
We take on the extra work of handling both fields
Sub Decisions:

Do compute nodes advertise the Engine enum for engines they support, or do they advertise a string representing their supported engine?

Continue using Enum: Engines aren't pluggable.
Use a string for Engines: Engines are pluggable.

Do we maintain two versions of Spec files here: https://github.com/bacalhau-project/bacalhau/pull/2594/commits/f72f900f96254c484931381d8eb892520d6549d2, one for the old version and one for the new?

Kill:

We break backwards compatibility with previous versions of bacalhau
We have less code to maintain
Engines are truly pluggable

Thoughts: I am leaning towards kill, at some point we'll probably want to break backwards compatibility, and I would prefer to do it while its a simple change to make rather than later when more complexity is introduced.

[ ] Find a more robust solution for decoding EngineSpec.Params from map[string]interface{} to its concrete type (e.g. WasmEngine) than https://github.com/bacalhau-project/bacalhau/pull/2594/commits/d6145ddb38dc152a8cf481b015f5264fe3428a50

The problem here is that StorageSpecType is an int internally but is passed as a string when specifying a job and the reflection based decoding used by mapstrucutre.Decode cannot handle conversion of a string to an int without special handling.

TODO

[ ] Address the TODO(forrest) comments after some review.

Closing in favor of https://github.com/bacalhau-project/bacalhau/pull/2706


Adds options argument to getFilteredDocumentTypeListItems

…able custom views

@vincentboiardt this is now resolved in 0.1.5 as the getDefaultDocumentNode structure is now correctly respected


Update pytorch dependency and fix linter issues

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Update the pytorch dependency per #2 and fix other linter issues.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@mgorny - do you want to add yourself as a maintainer here and ask conda-forge/core to merge? It seems like the feedstock has been unmaintained for a while.

@mgorny - do you want to add yourself as a maintainer here and ask conda-forge/core to merge? It seems like the feedstock has been unmaintained for a while.

No. Just doing janitorial work, no real clue about the package in question.

@conda-forge-admin, please rerender

Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!


Bug – ReferenceError: urls is not defined

Hi! Thank you very much for this awesome module. Sometimes I get the following error:
ReferenceError: urls is not defined
    at done (/home/encoder/node_modules/@microlink/youtube-dl/lib/youtube-dl.js:82:38)
    at ChildProcess.exithandler (child_process.js:301:5)
    at ChildProcess.emit (events.js:189:13)
    at maybeClose (internal/child_process.js:970:16)
    at Socket.stream.socket.on (internal/child_process.js:389:11)
    at Socket.emit (events.js:189:13)
    at Pipe._handle.close (net.js:600:12)

Indeed, line 82, urls is never declared nor passed as a parameter. Seems that it's the last item in the args object, but I'm not sure whether it is always the case. So better not break anything.

Thanks for the PR, maybe with https://github.com/przemyslawpluta/node-youtube-dl/pull/234 is enough?


General Issue: warning - lifecycle:: and elipsis:: vs rlang::

Background Information
I do not know if it is just my environment; I am interested if anyone else has seen these warning:

Definition of Done
Evaluation if this is a general problem.

Perhaps this explains it: https://github.com/abresler/nbastatR/issues/12
'These warnings are usually easy to fix, for example: instead of @import magrittr use @importFrom magrittr %>%, so set_names won't be loaded from magrittr, and the replacing previous import ‘magrittr::set_names’ by ‘purrr::set_names’ when loading warning goes away. It's anyways recommended to import explicitly only the functions you use, not whole packages.'

We ran into this for admiraltemplate too ( @bms63 looks like this exists elsewhere ), I was actually having trouble replicating it locally, it does seem relatively related to R version 4.0, feels renv or CI/CD related

Aynone else seeing this - @pharmaverse/admiral

After playing around, at least on admiraltemplate, with the renv profile stuff set up correctly for 4.1 and 4.2 these warnings do not appear, but they do indeed appear for 4.0

If we adopt the slightly newer versions of ellipsis (0.3.1 -> 0.3.2) and lifecycle (1.0.0 -> 1.0.1) this particular issue goes away at least when I was tinkering with it for the 4.0 renv lockfile. It might be due to the fact rlang is set to 1.0.6, released SEP2022, which isn't actually the proper snapshot for R 4.0.5, release APR2021.


Loading views without embedding to assembly

Couldn't you get this to work so that views need not be embedded to assembly? For example, if my assemblies are copied to a  folder like <module-name><views> it would be great if controllers of that plugin can refer to the \views folder inside that module. The entire layout can be taken from the parent/primary project

You can, you only need to import the .view.dll.
Then you have to rewrite the logic in                           CompiledRazorAssemblyApplicationPartFactory()
For map the references.


How to resend failed request

Hi,
How do we resend a failed web hook request? Eg, we have a service (web) hook that notifies a service when a work item is created. One request failed due to some malconfiguration on our part, but how do we resend this failed request?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 96287641-3e4f-b038-148f-08e8471bd573
Version Independent ID: b0034cd1-4f29-2e2d-c2bb-49004552dae8
Content: Troubleshoot your service hooks integrations
Content Source: docs/service-hooks/troubleshoot.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

Current work around:
Use Postman to create the same request (the request that was being send, can be viewed in the history).
It would be nice though to have the option to resend a request (from the history view).

@steved0x @elbatk Any idea yet how to do a resent of a failed web hook request?


[No QA] Update netinfo to 8.3.0

Related to Offline First – context.
Details
Just a bit of cleanup, implementing the improvement from https://github.com/react-native-netinfo/react-native-netinfo/pull/594
Fixed Issues
$ n/a
Tests
This feature was tested as part of https://github.com/react-native-netinfo/react-native-netinfo/pull/594. To test it in NewDot, simulate a failed network request by updating processRequest to just return Promise.reject().
Then monitor the network tab, and verify that a failed network request causes an internet reachability test.
https://user-images.githubusercontent.com/47436092/164775469-eab13837-d4aa-4283-8433-64d980d9cee8.mov
Also toggle offline mode off and on in the network console and verify that the state change is quickly propagated to the UI.
https://user-images.githubusercontent.com/47436092/164775330-8b46fe6c-01d7-4d52-9bf0-c04acfbfb755.mov

[ ] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps
None.

Looking into the test failures here...

Tests passing, ready for review.

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


chore: migration to swift for ios and add new example app

I started to migrate to swift for the ios version, added a example to be able to test it better locally and adapted some minor adaptions.
I tested it on my app reacttube and it worked well.
Unfortunally I am currently not able to invest much time into this at the moment. Therefore any contribution is welcome.
I just wanted to share what I have. 😅

Thank you for sharing this..it might be a good idea to have this a a beta release or different version and different branch. I can add you as a contributor to the repo if you are keen on maintaining this 😊

Okay, I can keep maintaining this if you want.
I think a beta release is a good idea to verify that everything this works as expected. 😄

Thanks mate, have added you as a contro

Thank you for sharing this..it might be a good idea to have this a a beta release or different version and different branch. I can add you as a contributor to the repo if you are keen on maintaining this 😊

How would you trigger a beta release, via a github actions job or manually. 😁

hey @Duell10111
I did not released beta versions before :).
I have approved the workflow, and fee free to create manual versions

Closing this PR for the new one. 😀
https://github.com/razorRun/react-native-vlc-media-player/pull/179


Upgrade Jackson to 2.12

This PR upgrades all Jackson dependencies from 2.11 to 2.12.
In the newest version, Jackson made a few changes to how XML serialization and deserialization handled inferring types and handling default scenarios. Default handling for empty lists and strings changed from null to being empty, additionally Jackson introduced a new concept of Coercion  which takes precedence over configurations such as FromXmlParser.Feature.EMPTY_ELEMENT_AS_NULL.

/azp run java - storage

/azp run java - storage

/azp run java - eventhubs

/azp run java - eventhubs

@kushagraThapar could you review, or find someone to review, the Cosmos changes?

@kushagraThapar could you review, or find someone to review, the Cosmos changes?

I don't see any cosmos code changes. And since you already ran the cosmos ci, I think you are good from cosmos point of view.

/azp run java - appconfiguration - tests

/azp run java - search - tests

/azp run java - storage - tests

/azp run java - cosmos - tests


Batch mode execution

In scientific computing it is common to run a batch of computations with the same code, but different parameters on each run. It would be useful for Sumatra to support this, perhaps by introducing a new command, smt batch.
It would be helpful here to collect different ways in which such batch computations are currently specified.

a shell script is used to loop over different parameter combinations
the parameters package provides a "parameter space" concept, which enables specifying parameter combinations easily in a JSON-like format.
command-line tools can take multiple values for each parameter, where each combination of parameters represents a new execution (see #208).

Imported from Bitbucket issue 209,  created by apdavison on 05-12-2014 at 08:07, last modified: 05-13-2014 at 11:42

Two random brainstorming comments:

Does Lancet [1] or its underlying Param package [2] have anything to offer in this regard (either for inspiration, or to outsource functionality)? I haven't actually worked with Lancet yet, but it appears to have relatively sophisticated support for exploring parameter spaces. Unfortunately, the documentation seems a bit sparse.

It would be great to have some support in Sumatra for analyzing the outcomes of batch computations. This ties in with filtering records (e.g. based on parameters values) and better pandas integration. I'm currently exploring some workflows for myself, but it might be good to discuss this on the mailing list at some point to get an idea of other people's workflows and what's needed in Sumatra vs. what can be outsourced to other packages.

[1] http://ioam.github.io/lancet/
[2] https://github.com/ioam/param
Trac comment by cilix on 05-13-2014 at 11:42

I have used Lancet successfully for performing parameter sweeps on a compute cluster.  For example, a grid search can be specified as a product of individual parameter ranges, then each simulation is submitted individually to qsub.  When the simulations finish, Lancet has a nice way of specifying the output file range and running a user-defined function to amalgamate the results.  The paper [1] was useful for getting a working example together, although it seems that some of the examples there have now made it through to the documentation.
I'd be extremely interested to see if sumatra and Lancet (or something Lancet-like) could be combined, since in our work, one 'experiment' is usually hundreds of related cluster jobs which are then combined and analysed together.
[1] http://www.ncbi.nlm.nih.gov/pmc/articles/PMC3874632/


Chapter 6 - Pubsub

First draft of the pubsub chapter

It will be great to have some intro content on pub-sub: https://simpleaswater.com/pub-sub

It will be great to have some intro content on pub-sub: https://simpleaswater.com/pub-sub

Are you thinking we need the level of detail you provide in the simpleaswater article?  That feels like it might be more detail than we need for this but I could be persuaded otherwise.


Do not register IR callback if stream disabled

Work around bug in librealsense where the callback for
IR is called even if the stream is disable if IR2 stream
is enabled.
See https://github.com/IntelRealSense/librealsense/issues/393

@mkhansen-intel We did check color, depth, and both IR streams, but the bug appears to just be mistaking calling the IR callback when IR2 is enabled.

Approved 👍


Helm repo doesn't have 1.1.0 chart

Helm repo hyper-mesh doesn't not have 1.1.0 release

NAME                           	CHART VERSION	APP VERSION	DESCRIPTION
hyper-mesh/spark-history-server	1.0.0        	1.0.6      	A Helm chart for deploying Spark History Server...```

We haven't implemented the new tag deployment for each fix. This needs fixing

chart is now 1.2.0 yay!


fix filenames

couldn't find an appropriate tool to check for filename duplicates (case insensitive)
If anyone has a suggestion...

couldn't find an appropriate tool to check for filename duplicates (case insensitive)
If anyone has a suggestion...

maybe we could simply enforce case insensitivity...


Change retrying to tenacity

Retrying is kind of abandoned, as per https://github.com/rholder/retrying/issues/65 and https://github.com/jd/tenacity/issues/73.
A suggestion to move to the more actively maintained fork, while still giving a mention to the parent project.
Thanks for a useful curated list!

Thank you! Since tenacity is under active developing and has many stars, I think it is ok to put it in the list.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v3.6 to before v4.14.256",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ac800140c20e7ae51117e71289065bedd4930fc2",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4e458abbb4a523f1413bfe15c079cf4e24c15b21"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "ac800140c20e7ae51117e71289065bedd4930fc2",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "4e458abbb4a523f1413bfe15c079cf4e24c15b21",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "cfg80211: call cfg80211_stop_ap when switch from P2P_GO type\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.256 by commit 4e458abbb4a523f1413bfe15c079cf4e24c15b21, it was introduced in version v3.6 by commit ac800140c20e7ae51117e71289065bedd4930fc2. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002234


Add DynamicNuclearNet finetuning

@constantinpape GTG from my side! (let me know if you spot something here. The early spotting is in place, the training should be fast in that case)

Looks good, but there is a merge conflicht now @anwai98. Can you resolve this first?

@constantinpape Resolved the conflict. Thanks!


GitHub Pull Request Tree View not visible

Extension version: 0.1.2
VSCode Version: 1.27.1
OS: Windows 10 Enterprise
Steps to Reproduce:

Installed GitHub PullRequests extension
Restarted/reloaded vscode and app
Opened folder in branch and can see GIT is connected

Extension output:
Looking for git repository

git symbolic-ref --short HEAD
git rev-parse master
git rev-parse --symbolic-full-name master@{u}
git rev-list --left-right master...refs/remotes/origin/master
git for-each-ref --format %(refname) %(objectname) --sort -committerdate
git remote --verbose
Git repository found, initializing review manager and pr tree view.
git config --local --get branch.master.github-pr-owner-number
Review> no matching pull request metadata found for current branch master
git config --local --get branch.master.github-pr-owner-number
git config --local --get branch.master.github-pr-owner-number

Is there an internal alias to use to debug? I do not want to post much debug data in a public forum.

Please have a look at https://github.com/Microsoft/vscode-pull-request-github/issues/418 and https://github.com/Microsoft/vscode-pull-request-github/issues/419, which are likely related

I have, and there are no extra colons in the url for in the output for "git remote -v"
git config --get remote.origin.url has the same output

@will-tao could you provide the output of git remote -v, perhaps replacing the actual owner and repository with just owner and repo?

Got remote information from @will-tao, remote was pointing to VSTS instead of GitHub. Closing as this extension only adds support for GitHub Pull Requests

I have to reopen this issue as VSTS uses git in my scenario.

Hi @omatrot, this extension only adds support for GitHub pull requests, not VSTS pull requests. VSTS is a separate backend and has slightly different data models, so we do not intend to add support for it within this extension. Instead, we will create a separate extension for it. Thanks

Again, I am not using VSTS (TFS)  as source control, but git.
Every single git command works fine with these repos I showed you, VSCode git integration works perfectly.
Please at least elaborate on where VSTS comes interfere here.
Thanks in advance.
From: Rachel Macfarlane<EMAIL_ADDRESS>Reply-To: Microsoft/vscode-pull-request-github<EMAIL_ADDRESS>Date: Monday 8 October 2018 at 16:53
To: Microsoft/vscode-pull-request-github<EMAIL_ADDRESS>Cc: Olivier MATROT<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Microsoft/vscode-pull-request-github] GitHub Pull Request Tree View not visible (#437)
Hi @omatrot, this extension only adds support for GitHub pull requests, not VSTS pull requests. VSTS is a separate backend and has slightly different data models, so we do not intend to add support for it within this extension. Instead, we will create a separate extension for it. Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Benchmark Engine job runs only engine, not Enso benchmarks

Engine Benchmark job runs only engine benchmarks, not Enso benchmarks.
Enso benchmarks do not report their output anywhere, and take more than 5 hours to run nowadays.
We might define a new job in the future and probably rename it to "Library benchmarks".
But that is the responsibility of the lib team.

@mwu-tow Is there a (simple) way how to add a declaration for email notification in case of failure of these jobs to the whole engine dev team?

Change @SerialVersionUID to prevent old IR caches to be read.

Change @SerialVersionUID to prevent old IR caches to be read.

Done in https://github.com/enso-org/enso/pull/6534/commits/3c9837e205d30c86842bc5ecd826b530dbed85c0

Needs a rebase against develop. GUI team added some linter that is more strict.

E-mail notifications are always trouble, especially since GitHub actually does not have our teams defined. I'd rather try to target this using some kind of Discord bot & webhooks/gh apps.

OK. No problem. It would be just a convenience. I have created a daily systemd service that checks and uploads benchmarks, so I can add an email notification there as well.


chore(ci): Add CI deployment scripts

This adds deployment step scripts for the prebuilds to
avoid the CIs accidentally exposing secrets through the logs.
Change-Type: patch

I wonder if the scripts should be named something like prebuild_publish or prebuild_and_publish, to make their use more obvious? *shrug*

Hmm, good point – renamed them to prebuild-publish.*


Flambe doesn't batch the textures created using the "subTexture" function.

When I enabled the flambe_debug_renderer, I noticed Flambe draws all animated
sprites individually.
Looks like Flambe doesn't batch the textures created using the "subTexture" function (flambe.swf.BitmapSymbol uses it). It should batch them because subtextures have same parent texture.

Could this gain performance?

OUYA showed 20 FPS when I added 50 different animated sprites from same atlas (texture) to the stage. I temporarily fixed the bug by using this code (ImageSprite class):
    override public function draw (g :Graphics)
    {
        if (texture != null) {
            if (Std.is(texture, SubTexture)) {
                var sub = cast(texture, SubTexture);
                if (sub.parent != null) {
                    g.drawSubTexture(sub.parent, 0, 0, sub.x, sub.y, sub.width, sub.height);
                } else {
                    g.drawTexture(texture, 0, 0);
                }
            } else {
                g.drawTexture(texture, 0, 0);
            }
        }
    }

And now OUYA shows 60 FPS.

Wow that looks quite significant. @aduros should this be put on this spot?

Looks like a possible bug. I think it should be fixed in Stage3DGraphics/Batcher rather than up in ImageSprite.

Does this code give you the same speedup? If you change Stage3DGraphics.hx drawTexture() to this:
    public function drawTexture (texture :Texture, destX :Float, destY :Float)
    {
        var texture = Lib.as(texture, Stage3DTexture);
        if (texture.parent != null) {
            drawSubTexture(texture.parent, destX, destY, texture.x, texture.y, texture.width, texture.height);
        } else {
            drawSubTexture(texture, destX, destY, 0, 0, texture.width, texture.height);
        }
    }

Sorry to spam the topic, but maybe this would work better / instead? In Stage3DBatcher.hx replace prepareDrawTexture with this:
    public function prepareDrawTexture (renderTarget :Stage3DTextureRoot,
        blendMode :BlendMode, scissor :Rectangle, texture :Stage3DTexture) :Int
    {
        if (_lastTexture == null || texture.root != _lastTexture.root) {
            flush();
            _lastTexture = texture;
        }
        return prepareQuad(5, renderTarget, blendMode, scissor, _drawTextureShader);
    }

I'm assuming that we don't need call flush() if we are using the same texture root, which would skip the flush() calls for those subtextures. Or am I wrong?


Plumbing DeleteSite operation casts interface to wrong type, panics

From calling operations.DeleteSite:
panic: interface conversion: interface {} is *operations.DeleteSiteDefault, not *operations.DeleteSiteOK

goroutine 205 [running]:
github.com/netlify/open-api/go/plumbing/operations.(*Client).DeleteSite(0xc42032d7e0, 0xc42039b110, 0x1db43e0, 0xc4203d75d0, 0x30, 0x1894dc0, 0x1930501)
	/Users/mitchellh/code/go/src/github.com/netlify/open-api/go/plumbing/operations/operations_client.go:400 +0x56e

Verified fixed. Thanks.


Adjustment for openfeign 10 suport

This change is important for the logbook be able to get the log when using openfeign 10 and not only version 11.

Description

Motivation and Context

I work in a company. We use springboot with openfeign 10 and we did like to use logbook, but logbook is ready for openfeign 11 only. With this feature, openfeign10 and 11 can work together.
I have tested the flow and the log is working fine. Could please give a look at my feature please?
Obs.: sorry for my english.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[x ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

i cant find the pom about:


dockerize derper and publish to dockerhub

Related https://github.com/n0-computer/iroh/pull/2404
Needs CI & publishing to consider this done.

Closing in favor of #1371


Spaces in path names cause makefile to fail

If there is a space in the path to grumpy, there will be a long chain of errors of the type found here on make:
IOError: [Errno 2] No such file or directory: 'grumpyTest/grumpy/third_party/stdlib:/Users/credford/Dropbox/Years/__2017/__Scripts/Professional/8'
build/src/grumpy/lib/itertools/module.go:4: can't find import: "grumpy/lib/_collections"
make: *** [build/pkg/darwin_amd64/grumpy/lib/itertools.a] Error 1

Specifically, the makefile is transforming the path from
/Users/credford/Dropbox/Years/__2017/__Scripts/Professional/8 grumpyTest/grumpy/third_party/stdlib
(notice the space after the 8) to
grumpyTest/grumpy/third_party/stdlib:/Users/credford/Dropbox/Years/__2017/__Scripts/Professional/8
Changing the name of the offending folder from 8 grumpyTest to 8-grumpyTest relieved the error. You may want to make your makefile more robust for spaces in paths, though.

@drgrib  Can you share the steps to reproduce same issue ?

@vbmade2000 I wish I could. It has been a long time since I used Grumpy and have switched the language of my project to Go.
I can tell you that the only steps required to reproduce that I think are important is that Grumpy is unzipped to a directory that has spaces in the name of one of the folders and then to call make on the primary Grumpy directory.

I see. I'll try to reproduce same.


flit

refactor PyCMDS to be an ACTUAL Python application

139 files changed?! Looks like PyCMDS finally got blackened. :)

@darienmorrow well, and packaged (so all the python files moved paths)
now pycmds can be run from the cli from anywhere as pycmds
Also, in the previous PR, #264, we moved to a single toml for config instead of scattered ini files (and to individual state files for things that are written on change and read on startup, so that we don't write the config file ever)
And moved data and logs and other things to be stored in folders outside of the source tree (finally)
To be clear, we merged the core, but still need to address some of the hardware specific code, though virtual hardware works now.


Take options instead of filename and add "src" option

This allows for better error messages when the source is provided.
I also added basic type checking of the arguments.

Changes Unknown when pulling 0304f0d69225001f89a3d12a91c9e1a7c9f36c27 on one-options into ** on master**.


Update camlistore.net DNS

Is there a way to update the IP address the camlistore.net DNS server is pointing to for a given identity? I have an older instance I deployed using the launcher tool awhile ago and now the IP address as reported using DNS lookup is incorrect for my instance ID in Google Cloud.
My VM should be available at 1015397a.camlistore.net. The IP reported by the camlistore.net lookup seems to be <IP_ADDRESS> which doesn't match my current External IP for the VM running camlistore.

Afair, camlistored should have asked the DNS server to automatically update your IP, so something went wrong there. I'll have to look at the code.
Maybe we should have a command-line tool as well to force the update in case of such a bug.
In the meantime, I'll think about what kind of work-around can be done to fix your case.

After reading the code a little closer it seems just clearing out the camli-hostname instance metadata attribute and restarting the server did the trick. Sorry, I didn't realize that would force it to reconfigure itself.
Nevertheless, thanks for the quick response.

I've just refreshed my memory as well, and as you can see, we indeed update the record on the DNS every hour if needed, so you shouldn't have needed to restart your server.
Unless it's the other way around? maybe your GCE instance name was wrong somehow (you erased your GPG key at some point or something?)?
Are you saying that your VM name is still 1015397a.camlistore.net now?

oh no, I see/remember now. We update the DNS record in case the DNS entries disappear, get corrupted, etc. , but not really to cope with client changes. So if your IP somehow changed, nothing is done about that since we always use the initial GCE instance IP.
I'll fix that.

@angelcabo Can you please confirm this is what happened to you:

you deployed Camlistore on Google Cloud with the launcher
your VM initially had IP X, and name foo.camlistore.net
at some point the IP of your VM changed to Y, even though you did not restart your VM. If yes, do you know why your IP changed?
as a result the record on the DNS server for foo.camlistore.net was wrongly still set to X instead of Y.

Yep, that's exactly what happened. I may have restarted the VM at some point though. I'm not sure when or why the IP changed but I don't have a static IP assigned. My instance has an ephemeral external IP.
I got the idea to clear out camlistore-hostname by looking at pkg/serverinit/env.go:78. It seems if the hostname isn't already there a new challenge is initiated with the DNS server. However, I'm not sure where the actual code to update the name entry is located. Although I notice: pkg/gpgchallenge/server/main.go:51 the OnSuccess handler is planning on adding or updating the name entry at some point.

doh, accidental closing/opening...sorry

What puzzles me is the following:
If the VM had restarted, regardless of whether the IP changes on restart or not, with the code as it is things should have worked.
Which means the IP changed while the VM/server was already running, which seems pretty weird to me. I thought even ephemeral IPs were staying booked as long as they are in use.
Anyway, I'll try to add the code to deal with the case of the IP changing at any time.

this https://camlistore-review.googlesource.com/c/camlistore/+/11446 should help, but i need to test it first


added geocordinate transformtion from GK4 to WGS84

added geocordinate transformtion from GK4 to WGS84
added documentation (return types of coordinates now objects {lat: 51.04373, lng: 13.70320}
pyproj is now a requirement, but can be installed with pip install pyproj

Yes, looks awesome!


UI shutdown issue on Mac OS

I received the following report from Craig for OS X:

I also had an clean exit issue on OS X (actually, the OS X build I played with in November for 0.0.9 had the same problem) - you tell the app to quit, and the UI (but not the window) unloads itself. Then it never quits and must be force quit. It re-opens cleanly (thank god!).

@msgilligan: did you experience this, too?

and the UI (but not the window) unloads itself

Can we get more detail here please - what is meant by "the UI" if not referring to the UI window in the context of unloading?
Also, can we please see omnicore.log and debug.log output for the shutdown?
@dexX7 can you please ping me the OSX binaries?  I'm going to try and get my hands on a Mac to test with.
Thanks :)
Z

Oh, you were able to setup a OS X environment? I'd be interested in learning how.
I haven't heard from @CraigSellars since then. Sent you the links via email.

Thanks bud, replied via email on this topic but long story short, I'm unable to replicate any problems closing Omni Core on OSX.  I'll retry when the blockchain is fully synced but during chain download it seems to exit cleanly.

Thanks @zathras-crypto!
Earlier I grabbed a notebook with OS X 10.9.5 and quickly started Omni Core on mainnet, but without internet connection. It started, and shutdown without any issue.

Prr... I think I could cry haha.. It looks like the deinitialization issue related to Boost path made it back into 0.10.2, which caused the crashes on Windows, when denying the reindex request during startup.
@zathras-crypto: could you please test, if this is also an issue on OS X?

I don't see a crash testing on OSX.  FYI:
2015-06-15 22:56:54 Bitcoin version v<IP_ADDRESS>-7239539 (2015-05-28 21:04:44 +0200)
2015-06-15 22:56:54 Using OpenSSL version OpenSSL 1.0.1k 8 Jan 2015
2015-06-15 22:56:54 Using BerkeleyDB version Berkeley DB 4.8.30: (April  9, 2010)
2015-06-15 22:56:54 Default data directory /Users/zathras/Library/Application Support/Bitcoin
2015-06-15 22:56:54 Using data directory /Users/zathras/Library/Application Support/Bitcoin/testnet3
2015-06-15 22:56:54 Using config file /Users/zathras/Library/Application Support/Bitcoin/bitcoin.conf
2015-06-15 22:56:54 Using at most 125 connections (2560 file descriptors available)
2015-06-15 22:56:54 Using 2 threads for script verification
2015-06-15 22:56:54 Using wallet wallet.dat
2015-06-15 22:56:54 init message: Verifying wallet...
2015-06-15 22:56:54 CDBEnv::Open : LogDir=/Users/zathras/Library/Application Support/Bitcoin/testnet3/database ErrorFile=/Users/zathras/Library/Application Support/Bitcoin/testnet3/db.log
2015-06-15 22:56:54 Bound to [::]:18333
2015-06-15 22:56:54 Bound to <IP_ADDRESS>:18333
2015-06-15 22:56:54 init message: Loading block index...
2015-06-15 22:56:54 Opening LevelDB in /Users/zathras/Library/Application Support/Bitcoin/testnet3/blocks/index
2015-06-15 22:56:54 Opened LevelDB successfully
2015-06-15 22:56:54 Opening LevelDB in /Users/zathras/Library/Application Support/Bitcoin/testnet3/chainstate
2015-06-15 22:56:54 Opened LevelDB successfully
2015-06-15 22:56:54 LoadBlockIndexDB: last block file = 0
2015-06-15 22:56:54 LoadBlockIndexDB: last block file info: CBlockFileInfo(blocks=1, size=293, heights=0...0, time=2011-02-02...2011-02-02)
2015-06-15 22:56:54 Checking all blk files are present...
2015-06-15 22:56:54 LoadBlockIndexDB(): transaction index disabled
2015-06-15 22:56:54 LoadBlockIndexDB(): hashBestChain=000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943 height=0 date=2011-02-02 23:16:42 progress=0.000001
2015-06-15 22:56:56 GUI: QNSView handleTabletEvent: This tablet device is unknown (received no proximity event for it). Discarding event.
2015-06-15 22:56:56 Aborted block database rebuild. Exiting.
2015-06-15 22:56:56 Shutdown: In progress...
2015-06-15 22:56:56 StopNode()
2015-06-15 22:56:56 Shutdown: done
zathrass-Mac:testnet3 zathras$

@zathras-crypto: can you please ping Craig to get some information about this issue?

I'll check in with him at the next meeting sure bud :)  Though I haven't seen the issue you're mentioning when denying the index on startup?

The reindex cancel crash is also caused during the shutdown, due to some pointer deinitialization in the Boost library by another thread than the main thread, and I was wondering, if this issue might be similar. Given that you didn't see an issue, I assume OS X isn't affected.

Not that I doubt @CraigSellars, but since we were not able to confirm this issue, and neither received any more information, I'm going to close this for now. Please reopen, once there is a bit more information.
I tested Omni Core in OS X 10.6, 10.9 and a few minutes ago in 10.10, and did not experience issues, when shutting down the QT client.
As a side note: I also confirmed correct test execution via OmniJ, and everything looks good. :)


settings_users: Show previously selected value in role code dropdown.

Fixes
https://chat.zulip.org/#narrow/stream/9-issues/topic/filters.20are.20not.20working.20properly/near/1923794. This commit also changes the datatype used for the dropdown to number which is more suitable for our case.
Could have made changing the datatype a different commit but didn't think it would be worth a seperate commit for such a small and in our case, a suitable change.

Screenshots and screen captures:
Role:

Search text:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@sahil839 are you up for reviewing this one? I haven't tested.

This addresses part of the problem, but a similar behavior is also present with the filter text.

I've made this change.

Looks good to me.


dante: fix package under Linux

Motivation for this change
Fixes #73697 and this issue.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Anything keeping this from being merged? Building aerc from this branch fixes the socksify: error: dante client not built with preloading support. error I'm getting when opening text/html email.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/83

@GrahamcOfBorg build dante


New Release Checklist - v1.10.0

Description
This issue is tracking steps to complete a release ensuring all artifacts are correctly produced. This covers both automated tasks and manual tasks.
Release
Manual steps are instructions that need to be taken in order to have a full release on all associated repos. Validation steps consist of checklist of items to verify, to ensure all reqiuirements and releases have gone without problems and that the correct assets are created needed for the manual steps.
Intiial Steps

[x] Github Release — create a new release following the semantic versioning guidelines. The next available version should increase either the Major or Minor version, following the semver recommendations. Patch should be set to 0. This allows individual languages to publish hotfixes under the same version with new patch. An example version format is v1.2.0.

[x] Create a new tag with the same name v[MAJOR].[MINOR].0
[x] Ensure code contributions and commits are included in the release description, either by utilizing the GitHub automatic options or entering them manually.
[x] Organize the release notes into the following sections: Language-Specific Changes, SDK-Wide Changes, Documentation/Samples, Protobuf/gRPC Updates, Bugfixes/Minor Improvements, Internal Improvements
[x] Confirm documentation of any breaking changes with @fundthmcalculus @geel9 @michaeldboyd

Validation Steps

[x] Builds complete successfully
[x] Release actions complete successfully
[x] Assets — ensure the following assets have been created by the release actions and are uploaded as assets in the release

[x] Debian Package, named trinsic_X.X.0_amd64.deb
[x] Trinsic CLI tarball (for Homebrew), named trinsic-cli-X.X.0.tar.gz
[x] Trinsic CLI vendored tarball (for Homebrew), named trinsic-cli-vendor-X.X.0.tar.gz
[x] Trinsic CLI Microsoft Installer (msi), name trinsic-cli-X.X.0.msi
[x] Trinsic Java/Kotlin (jar), name trinsic-services-X.X.0.jar

[x] Package Releases — validate if packages have been correctly released

[x] golang tag (go/vX.X.0)
[x] nuget.org
[x] npmjs.com
[x] pypi.org
[x] rubygems.org
[x] pub.dev (Dart) - future work, this is not fully implemented

Post-release Manual Steps

[x] Swift Release — create new release in associated repository for Swift package at trinsic-id/sdk-swift. The release version in this repo follows a pattern that doesn't include leading v. Example release format is 1.2.0.
[ ] External Tools

[ ] Homebrew — to create a new tap, follow the instructions at trinsic-id/homebrew-tap by making a new PR with the required information. This step depends on a release asset package. TODO: Renovate bot can update this automatically
[x] ~Windows Package Manager (winget) — Update PR to the yaml here: https://github.com/microsoft/winget-pkgs/tree/master/manifests/t/trinsic/cli/ This step depends on the Microsoft Installer package.~
[x] ~NixOS — done automatically by nixos bot. Periodically verify that package versions haven't fallen behind at https://search.nixos.org/packages in Unstable channel.~

[x] Samples — if required, code samples at https://github.com/trinsic-id/sdk-examples should be updated to match the version

[x] Renovate bot will produce PRs to update all relevant samples with the latest trinsic packages, so this is mostly automatic
[x] Update Instruqt demo here: https://github.com/trinsic-id/tutorials/

[x] Release announced to Trinsic Team

Did we tap out (🥁) all outstanding items in this issue and can close it?

Did we tap out (🥁) all outstanding items in this issue and can close it?

Good catch. PR here. Once CI pipelines pass, we can close this.


Serve icon from githack CDN

Icons served directly from Github can be blocked from rendering remotely. This switches to Githack CDN

Thanks, looks good. Merging


okcruby food for July 14 Meeting

group: okcruby
food type: ?
guest approximation: 15
meeting date: Thursday, Jul 14 2016 at 11:30 AM
For visibility,
organizers: @jagthedrummer @piisalie @datachomp

ordered y'all a party platter from jimmy johns. they don't deliver 2 liters (the one nice benefit of pizza) so someone will need to pick up drinks. there might still be some soda at prototek from c#/py, but that's not certain.

Oh, thanks @amandaharlin! Did you happen to get some veggie only options in there? If not we can improvise something.

i did, got a veggie sandwich in there :)
On Thu, Jul 14, 2016 at 9:43 AM, Jeremy Green<EMAIL_ADDRESS>wrote:

Oh, thanks @amandaharlin https://github.com/amandaharlin! Did you
happen to get some veggie only options in there? If not we can improvise
something.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/techlahoma/techlahoma/issues/112#issuecomment-232686067,
or mute the thread
https://github.com/notifications/unsubscribe/AArvZHhpBRom_sPkuG4LASnOpPqtXMKhks5qVkr4gaJpZM4JKYTe
.


support TLS1.3 and 0-RTT data

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jlijian3:x: jlijianjlijian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Interesting. Would you like to add some test cases for TLSv1.3 early data?


Air Labyrinth Fixes

Fixes compile errors on gcc12 toolchain (firmware dev branch)
Fixes sprite builder command on windows (based on pending PR to Air Arkanoid)

Thanks for the fixes!


Creat role for whatsapp

Currently it's installed via mas within https://github.com/tboerger/workstation/commit/860b7f1e07ca5da4844d5be322a3ed00f4c7f551.


Get Android NDK builds working on Windows

A set of minor patches put together with some help from @compnerd that fixes Android NDK cross-compilation on Windows.
Note: GitHub Actions to automatically perform this build will be in a subsequent pull request.
Test plan:
Passed existing GHA builds for Windows and Linux, MacOS is failing on the original branch: https://github.com/andrurogerz/ds2/actions/runs/9860105998
Locally built Android NDK with CMAKE_ANDROID_ARCH_ABI=[x86, x86_64, armeabi-v7a, arm64-v8a] on Windows using the following command:
S:\ds2>set ANDROID_NDK_ROOT="C:/Program Files (x86)/Android/AndroidNDK/android-ndk-r23c"
S:\ds2>mkdir build
S:\ds2>cd build
S:\ds2\build>cmake -D CMAKE_SYSTEM_NAME=Android -DCMAKE_ANDROID_ARCH_ABI=arm64-v8a -DCMAKE_ANDROID_NDK=%ANDROID_NDK_ROOT% -G Ninja -S ..\ds2
S:\ds2\build>ninja
The NDK used was installed with Android Studio.

latest GHA build results after updates: https://github.com/andrurogerz/ds2/actions/runs/9864533048


SubmissionSet: Extension sourceId Identifier should have a min 1 cardinality

Section Number
https://profiles.ihe.net/ITI/MHD/4.0.2/StructureDefinition-IHE.MHD.Minimal.SubmissionSet.html
https://profiles.ihe.net/ITI/MHD/4.0.2/StructureDefinition-ihe-sourceId.html
Issue
Minimal Submission Set requires that the sourceId extension is provided. However in the extension sourceId the valueIdentifier has a min cardinality of 0..1. According to the XDS Abstract Metadata Value the sourceId is required.
Proposed Change
Change the minimum cardinality of the value[x] to 1.
Priority:

Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

make the change


add 2.4.1

@ausfeldt : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ausfeldt: I'm sorry - only the author of this article, @SnehaGunda, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


Send confirmation email when we receive notification from webhook

Hello Adyen team ,
The job 'process' check status of order saved in the custom object Adyen notification.
When we place order we save a custom attribute Adyen_CustomerEmail contain the model for the order .
In this file we save the custom attribute for the order model .
int_adyen_SFRA\cartridge\controllers\middlewares\adyen\showConfirmation\order.js
int_adyen_SFRA\cartridge\controllers\middlewares\adyen\showConfirmationPaymentFromComponent\payment.js
var currentLocale = Locale.getLocale(req.locale.id);
var orderModel = new OrderModel(order, {
countryCode: currentLocale.country
});
// Save orderModel to custom object during session
Transaction.wrap(function () {
order.custom.Adyen_CustomerEmail = JSON.stringify(orderModel);
AdyenHelper.savePaymentDetails(adyenPaymentInstrument, order, result);
});
In the case when we place order with 10 items , This attribute can exced a quota for json collection .
The best solution is to use COHelpers.sendConfirmationEmail(order, order.customerLocaleID) instead of sendEMail
\int_adyen_SFRA\cartridge\scripts\adyenService.js
Thanks
Rihab

Hello @zenit2001,
Thanks you for your response.
Thanks
Rihab


Support reading GITHUB_TOKEN from a file

It's beneficial sometimes to pass secrets (like an API token) in via a file, rather than an environment variable.
Also, this enables the use of the new secret management support in Docker Swarm mode in Docker 1.13.0 (https://docs.docker.com/engine/swarm/secrets/).
Signed-off-by: Dave Henderson<EMAIL_ADDRESS>

I've tested this out and it seems to work fine. I've got a (temporary) docker image built at hairyhenderson/github-exporter:support-github-token-from-file.

This is why i love OSS :)
Let me test it out, i'll aim to get it merged today. I've not actually had chance to check out the secrets management in 1.13.0. Does it only work within a swarm cluster? I'll have a read-up now.

Thanks for the image, made testing a bit quicker. Merging!

This is why i love OSS :)

Same 😁
Thanks for merging!


Can't control other people's server as administrator

I'm currently running PufferPanel 1.0.2 on my machine. Basically everything seems to work like it should (I'm kind of hacking pufferpanel and pufferd together since I want to docker the entire infrastructure), however after creating a Server as administrator for a User different than myself, trying to access the Server Control Panel results in an internal Server Error. These are the exception documents created by PufferPanel:
http://static.djgummikuh.de/exceptions/exception--2017-03-07--10-19--a55e36a3ec.html
http://static.djgummikuh.de/exceptions/exception--2017-03-07--10-20--f352443723.html
Unfortunately I'm not firm enough in PHP to efficiently diagnose this topic any further, can you please give me a hint on what might be going on here?
Kind regards,
Johannes Frank

Since I still was running on PHP5, I switched to PHP7, still with the same result, so it appears to have nothing to do with the php version in use.

Ok I sunk another couple of hours into that, built the pufferpanel the desired way, still I have the exact same issues. Nobody else notices these problems? They prevent me from actually going life with 1.0.2 and since my last version was 0.5.8 and I just did a server move I'm stuck inbetween with users breathing down my neck :-/

This is a known issue and I've already pushed code that in theory resolves it, but I have not tested it properly and it still has a migration issue from older versions.

I am working on fixing pufferd and getting the SFTP issues resolved there since it's a more "crippling" issue than this, but this is the next thing on my place to get tested and resolved.

Oh. Is there a way for me to circumvent that problem in the meantime? I'm not migrating but building anew (since my old docker images were WAY hackier than the new ones, thanks a ton for having pufferd now instead of scales, I even get away without running PufferPanel in privileged mode xD)

The issue with admins is that the underlying OAuth2 token usage isn't set up to handle the admin users correctly.
You'd have to insert a new oauth_client record with the admin's user id and the server id they need to access, following the convention set there were the name is .internal__. The client id should be set to be similar, secret doesn't need to change.
This is what the fix does is actually populate that table correctly for admins.

can you give me a rough estimate (no worries, won't hold you accountable for it xD) on when you will be able to tackle that issue?

I've been hoping the SFTP would be quick to solve, but it's proving to be more than that. I am about to release it with the known bug, and just fix it at a later date.
This issue requires me to go into testing, which while I have the server set up, it's not deployed yet. Assuming no issues, probably within a week of the pufferd release.

cool! If I can help you somehow tell me :-)

We keep constant builds of our software on https://dl.pufferpanel.com/pufferpanel/nightly/ which has the theoretical fix, but it's not been tested, and is always going to use the nightly daemon core.
You can attempt to install that version and see how it plays out, reporting any issues that you find. That would help locate issues I may not realize/

It seems you have (among other things) an issue with your build server, the "nightly" build is from february 26th.. :-)

It runs a build every 30 minutes, but only will deploy a new file if the git sha is different.
PufferPanel has not had a commit to that repo for 11 days, so it's not been putting out anything new.
pufferd has had more recent commits, so that project has been building with newer dates on it.
You can look at the version.txt to see what the git sha for the commit that produced that download is.

ah cool! Will do! thanks! Will write more this evening (EST).

Resolved in v1.0.3


Added: Quezon City University

@zyrusinso First stage of verification passed, official domain for Quezon City University is qcu.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@zyrusinso Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


fix: used compiled schema for ajv

Codecov Report

Merging #121 (ee9cc33) into develop (f0a2d8d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

:exclamation: Current head ee9cc33 differs from pull request most recent head d906fb8. Consider uploading reports for the commit d906fb8 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop     #121      +/-   ##
===========================================
- Coverage    96.15%   96.12%   -0.04%
===========================================
  Files           64       63       -1
  Lines         2184     2166      -18
  Branches       398      398
===========================================
- Hits          2100     2082      -18
  Misses          84       84

Flag
Coverage Δ

unittest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...handlers/inputDescriptorFilterEvaluationHandler.ts
100.00% <100.00%> (ø)

lib/utils/VCUtils.ts
89.47% <100.00%> (-0.78%)
:arrow_down:

.../validation/bundlers/presentationDefinitionV1VB.ts
97.91% <100.00%> (-0.11%)
:arrow_down:

.../validation/bundlers/presentationDefinitionV2VB.ts
98.94% <100.00%> (-0.06%)
:arrow_down:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Use metrics APIs for report parsing telemetry

This PR simplifies the telemetry logic in CompatibleHidDevice class by replacing tracing based telemetry with metrics.
This allows us to very quickly check-out the current metrics with dotnet counters for example:
$ dotnet counters monitor -n DS4Windows.Server.Host DS4Windows.Shared.Devices
Press p to pause, r to resume, q to quit.
    Status: Running

[DS4Windows.Shared.Devices]
    reports-processed (Count / 1 sec)                252
    reports-read (Count / 1 sec)                     252

Very cool 👍


Update known issue for Datasets

@rongduan-zhu : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#please-close


Configurable DNS servers

It would be nice to have configurable DNS servers. Unfortunately I'm not a ruby dev but looking at the code it should be fairly easy (famous last words)!
:+1:

We could support passing in your own instance of Resolv::DNS.

Actually, we already support that!
resolver = Resolv::DNS.new(nameserver: '<IP_ADDRESS>')
SPF::Query::Record.query(..., resolver)

Fantastic! Must have missed that, thanks!


Merge hardliner

Missing pieces (that I can think of):

[ ] I think I fixed benchmark.sh but I didn't test that.
[ ] I didn't touch the cargo benchmark as I'm working on stable Rust.
[ ] README, docs

Fixes #63.

Changes Unknown when pulling 61b754e8afe3005fe1eec7b0a6f6741a3718da5c on hardliner into ** on master**.

I think this is fine for the purposes of bringing in hardliner. The missing stuff can be addressed in followup PRs.
We'll probably want to move the addr2line example back to bin. I don't think there's any downside to doing that?

We'll probably want to move the addr2line example back to bin. I don't think there's any downside to doing that?

Doesn't that force a clap dependency even for library users? I really wouldn't like that.

Ah yep, cargo doesn't yet support dependencies that only apply to bin, so ignore that.

@main-- You should have permission to merge this if you think it is ready. I was unsure what your plan with the checkbox items was.


Add Python inference

https://github.com/spacewalk01/depth-anything-tensorrt/issues/15, I also referred to Depth-Anything-ONNX for image preprocessing.

Thank you for your contribution. I will test it and if there is any issue, then I will merge it.

Merged it thank you for your contribution


Leverage the accessibility tree for the Navigation Engine

Someone rightly pointed yesterday that we could use the accessibility tree during the webinar.
Got to say I heard of it but haven't checked.
I think this is something where the community could help.
We will draw the details of implementation with @mbrunel and @HiImMadness and share the steps to implement it here

In the same vein we can use the for attribute to enrich element context even when aria-label is absent.
<label for="abc">Search</label>
<input id="abc" />

input#abc has no information itself, but we can infer a "Search" label.


Defined IShellItemArray in shobjidl.rs

On top of that, I also added the definition of types required by this interface.
Test OK when using code like IFileOpenDialog.GetResults(...).

Merged into dev branch.


Prepare v0.2 release

Once #101 is merged, we should prepare a v0.2 release before disappearing for the holidays!

Closed by a827523


Plone root appears as "red" in the "workflow status" hint on the Toolbar

If the "blue" means "published" and "red" means private on the Toolbar toggle handle, then Plone's shouldn't always be red.

@MAX-786 The problem is a bit complex, at least to my knowledge. When I wrote this ticket, the "Dexterity-based Plone root" wasn't a thing. Plone was using the old CMF-based content classes, rather then the new Dexterity framework. So, at that time, the Plone site couldn't have a workflow state. I don't know if that is still the case. In any case, I think the fallback color could be something more subtle that doesn't "conflict" with one particular, determinate state.

So, at that time, the Plone site couldn't have a workflow state. I don't know if that is still the case.

on Volto i don't see the workflow status indicator either...,if possible can u link any resource so i can understand this issue better. 😊Thanks!

It looks like at some point this got fixed so that content types without a workflow do not show a status.