Windows 10 1903 Update Deleted WSL Installation

Your Windows build number:  Microsoft Windows [Version 10.0.18362.116]
What you're doing and what's happening:  I was trying to launch WSL after updating Windows to 1903 but it fails to start because it says there are no distrubutions. The Debian installation directory is gone as well.
What's wrong / what should be happening instead: WSL fails to start and the Debian installation was deleted/cleared out.

@XerTheSquirrel - Uggh, the store folks assured me this bug was fixed. Did you happen to launch Debian very shortly after the update?

@XerTheSquirrel - Uggh, the store folks assured me this bug was fixed. Did you happen to launch Debian very shortly after the update?

I did yes...

Thanks. The issue is that Windows is doing some work on it's repository of installed packages in the background, and while that is happening WSL queries the package repository and it says Debian is not installed.
I am very sorry about this, I will follow up with the store team to see if they are aware this race still exists.

Thanks. The issue is that Windows is doing some work on it's repository of installed packages in the background, and while that is happening WSL queries the package repository and it says Debian is not installed.
I am very sorry about this, I will follow up with the store team to see if they are aware this race still exists.

It is what it is, just going to be reinstalling Debian now.

I will note that I have an automated task which is set to run when the computer is started, it just runs /etc/rc.local since I need a few services active as soon as possible. Note that this was active before, during, and after the installation of the update. I will note that "All Tasks History" was disabled, so I do not know the exact times when the tasks have started.
This is the exported task:
Linux RCLocal.zip

I also had WSL disappear after installing 1903. I had Ubuntu installed, which was gone after upgrading to 1903.
I did not try to start Ubuntu shortly after the upgrade, it was not there. Not too bad, since it's a new computer and I hadn't installed too much yet, but a bit annoying.

Didn't Windows preserv the old installation in Windows.Old folder (or something similar)?

Yes, the upgrade created a Windows.Old folder, but I did expect Ubuntu to still be installed and available after the upgrade, like the other Microsoft Store apps.

So, it may be possible to recover deleted distribution from that folder in current WSL system.

I had looked in Windows.Old however it seemed to have only kept configuration data. It was really small in size and had no root filesystem in it at all.

The file system is in %LOCALAPPDATA% packages. Shows up in JDiskReport 😅

Just happened to me updating to 18980.1
Has put me right off WSL I'm afraid.

If possible move the WSL distribution to other partition or drive and backup the lxss registry after doing it.

I have met the same issue here. Suddenly I can not use WSL. I thought it was an issue with wsltty I am using.
But it seems that Ubuntu on Windows is erased somehow after a Windows update. I have to reinstall Ubuntu on Windows to start the Ubuntu terminal successfully.

I got my WSL Debian "deleted" in 1809 and not after update from 1709, but just today. This is corpo-managed Windows installation and the only windows update installed between yesterday and today is some Microsoft Office 365 stuff, so completely WSL unrelated.
Some files are still in %user%\AppData\Packages\Debian*\LocalState\rootfs, but ProgramData\Packages\Debian\ is almost empty but Debian store app (it was installed from Store) is shown to be installed.

I didn't get my full distro deleted, but it reverted the distro back to it's pristine "just installed from store" state.
Any of my files or packages I had on the distro that weren't specifically mounted to one of my physical disk drives are gone.

The same thing happened to me. My Ubuntu 18.04 WSL installation just reverted to its "factory" status.

Hi all,
I've faced this problem today. I found my files in C:\Users\<username>\AppData\Local\lxss\. Unfortunately, because is Windows filesystem, all permissions on the files are lost. But at least, not the files itself.

It seems like I'm not so lucky.

WSL installation gone today on 18362.476 while experimenting with getting Task Scheduler to start an ssh server on WSL during Windows start up/log on. Replaced by a new installation. Home directory seemingly lost.

I'm using Windows 10 Pro version 1903 and found WSL to be disabled after installing an update yesterday.

Windows Update applied KB4534132 to my Windows 10 laptop this morning and then prompted me to reboot. After rebooting, my Ubuntu 18.04 distro is no longer available under WSL. It does still shows up under Add/Remove programs but there are no files available under C:\Users<user>\AppData\Local\Packages\CanonicalGroupLimited.UbuntuonWindows_79rhkp1fndgsc\LocalState\rootfs or C:\Users\0017919\AppData\Local\Packages\CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc\LocalState.
This is extremely disappointing as I had everything set up to do development within WSL and now it appears that Windows Update wiped everything out and I'll need to start over. This is completely unacceptable and it's making me consider switching back to Linux as my primary OS.

 This just happened to me. My local development environment depends on having Ubuntu within WSL.

+1 to angry and frustrated people.
I hadn't used my Ubuntu instance for a couple of months, and just started it from the pinned item on my task bar.
It then went through an installation process:

Installing, this may take a few minutes...
Please create a default UNIX user account. The username does not need to match your Windows username.
...
Welcome to Ubuntu 20.04 LTS (GNU/Linux 4.4.0-18362-Microsoft x86_64)

All my files and installed apps have disappeared.
Data Loss has occurred and a lot of time wasted setting up that environment.
This is really unacceptable.
I'll have to go back to a VM as this cannot be trusted.
Windows update history:
Windows 10 1909 installed on 28/12/2019.
Last time I used Ubuntu was likely 8 February, 2020.
KB4528760 - installed 13/2/2020
KB4532938 - installed 13/2/2020
Security Update for Adobe Flash Player: February 11, 2020 - installed 12/3/2020
KB4532693 - installed 15/3/2020
KB4551762 - installed 18/4/2020
KB4537572 - installed 18/4/2020

+1. My wsl Ubuntu has gone missing in wsl --list. And the wsl directory is left only with temp folder and fsserver file, without the rootfs folder.

After viewing all comments here, I found two people have mentioned that they were using Task Scheduler to execute startup tasks in wsl, which I have also being using.

Another probable reason is https://github.com/DDoSolitary/LxRunOffline which I have used to move wsl to other partition. After checking its code, I believe the method LxRunOffline is using to move wsl is just changing Registry value in HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Lxss\${name}\BasePath.

Using a NTFS file recovering tool, I found files in rootfs was deleted at 16:49:02. It was non-immediately after a post-power-loss boot. I'll list a detailed timeline later.

I have checked the whole Event Viewer at the time 16:49, Nothing WSL or unusual.

No system update in Event Viewer. No Ubuntu update happened in Windows Store.

Timeline before deletion:

15:30 an accidental power loss
16:00 power restored, system boot
16:22 - 16:30 two manual reboots
16:49 another manual reboot, the deletion happened during this startup

Given that wsl has survived three system startups after power loss, I think the power loss might be irrelevant.
===
Windows version: 1909 , 18363.836

The same happened to me. After a Windows system update my Ubuntu distro on WSL was deleted. When I re-installed Ubuntu from Microsoft Store the new installation overwrote the old one in:
...\AppData\Local\Packages\CanonicalGroupLimited.Ubuntu18.04onWindows_79rhkp1fndgsc
All my files are lost and no clue on how to recover them.

+1 for losing a WSL install on 1903. Note I can't update to 2004 as it's still "coming" for my PC...
I had a windows update pending this morning, so rebooted. KB4565351 and KB4569751 are showing in my update history.
Happily been working all day, then needed to drop into WSL via VSCode to do some work, only to be informed there's no WSL installations.
I have a CanonicalGroupLimited folder still in my AppData folder, with a few folders inside that, but apart from settings they're all empty.
So I've lost half a day I spend setting up WSL with everything I needed for my dev environment. Fortunately all the work itself is safely pushed up to my repos elsewhere, but had this not been the case I'd be mighty annoyed.
I also run wsl on my laptop for working while travelling, and am now totally paranoid that's going to magically vanish one day.
I see a previous commenter has used LxRunOffline and I'm in that camp too. I had to move my wsl install temporarily to another disk as I was out of space on my root drive, but I have since moved it back to it's original location. I can't see anything obvious in the event logs...
Is the cause of this known, or is it worth a bit of digging on my part?

+1 for losing my WSL installation on 1903.
A windows update updated something and my WSL was gone. The files are still available because I had moved them to a non SSD drive.
Most times I used right click open Linux shell here, which seemed to work until I need the Ubuntu shell, so I ran the Ubuntu entry on my desktop. Then I get a message that the installation will take some time, with that my previous installation was gone.
Now I have to move it again to a non SSD drive! My laptop is not ready for 2004 yet.
I also have a CanonicalGroupLimited  folder in AppData under Local.
What can I do?
CanonicalGroupLimited

I also lost my entire WSL directory after 1903 update. Deleted everything that was in there. Was unable to recover the files, updates, programs etc stored on the subsystem. Reinstalled from ms store. Didn't see anything WSL related in event viewer, just the update. Computer is on UPS power so I know a power outage isn't to blame. Very frustrating.

Perhaps better to add here the info from #6173:
I have 10.0.19042.0 and probably after the installing KB4579311, the vhdx file for my default ubuntu distribution disappeared.

Same problem on version 10.0.19041.1
(Get-ComputerInfo | % OsHardwareAbstractionLayer)
I also noted that all folders in C:\Users\%USER%\AppData\Local\Packages\ were modified at the date the update took place.

I got the exact same behavior on 10.0.19041.488 update
Ubuntu opens but there's no cursor whatsoever

+1 to depressed and frustrated people.
all data on my wsl lost after 19041.1 update

I have WSL Ubuntu installed, I have been working with it for some months now, I worked with it just yesterday.
Today, I launched Windows Terminal and Ubuntu was gone from the launch menu, ran wsl and got "Server execution error":

Tried running Ubuntu from the Start menu:

Tried opening a WSL project from VSCode, it stays in "Opening Remote..."

Guess I lost all my files :(

Did a number of updates on 4/20 (KB4589212, KB4601554, KB5001330). My CentOS 8 WSL install is gone.
I've been too depressed to log into GitHub and look, hopefully I committed my latest changes in all my projects :(

Same problem on version 10.0.19041.1
Did an update yesterday and after 7 months without trouble with my WSL (Ubuntu + zsh in the shell), I seem to have lost everything.
After a closer look, I could see here C:\Users<user>\AppData\Local\Packages\CanonicalGroupLimited.UbuntuonWindows_79rhkp1fndgsc\LocalState that there's a 62gB ext4 (Linux partition) saved.
Hopefully I'll be able to read it and retrieve 6 months of work, of which only about 10% are stored on repos...

I came across it after KB5003173 update. I checked my AppData and my partition with Ubuntu+zsh is still there for me as well. Ubuntu UWP was still installed but was acting like a fresh install and asked if I wanted to proceed with installing. I have a sneaking suspicion that doing so would have created a new partition and it would be harder to access my old files.   It looks like VM Platform and WSL were disabled in Windows Features. I checked the boxes again and rebooted. The first time I opened up my terminal it was a little ornery but the second time around everything was back to normal.

I updated overnight to the 21390.co_release.210521-1658 evaluation build just to find out that I can't start Ubuntu anymore.
Ubuntu is still there:
PS C:\Users\score> wsl -l
Windows-Subsystem für Linux-Distributionen:
Ubuntu (Standard)

and the Packages-folder CanonicalGroupLimited.UbuntuonWindows...  has content in it (~20gb).
It is just that the wsl won't start properly:
PS C:\Users\score> wsl
Beim Vorgang ist eine Zeitüberschreitung aufgetreten, da von dem virtuellen Computer oder Container keine Antwort empfangen wurde.

which translates to The process timed oute because there was no answer from the virtual computer/container.
Do I have to reinstall Ubuntu, or can I make it work another way? Because It looks more like a configuration problem than anything wrong with Ubuntu.

Update:
Luckily, for me running wsl --update updated the kernel and made it run again 💪

Had the same issue, I fixed it running wsl and suddenly it appeared again on the new tab

Same happened here... Docker Desktop fails to start, it turns out that the settings.json was full of NULLs. When I managed to get it up, it turned out that the WSL instance is gone and reinstalling from MS Store apparently overwrote my files because the home directory is empty.
This is unacceptable...

I have had the same problem with a WSL1 installation suddenly disappearing on Server 2019 with all data however still available in the Packages directory of the user profile.
Adding a new distribution under the Lxss registry key did not help. It will show the system in the list but no way to start it. What has helped was to rename the Canonical.... folder. Then install same Linux version again. Stop the Lxss service. Delete (or rename) the new installation and use the same folder name for the installation to be recovered. Start Lxss service. All back working.

This happened to me.  I'm a massive champion of WSL in enterprise and for this to be open after two years is honestly incredible.

Sadly the same for Win 10 21H2 (19044.1503 / KB4023057) still; had a Debian based installation (Pengwin) disappear.
Found a %UserProfile%\AppData\Local\Packages\WhitewaterFoundryLtd.Co.xxx_xxx directory but it only had factory files in it like others have mentioned.

OMG. NO WORDS.

In my case seems like some update remove registry information about installed Ubuntu distribution. Because I have all files related with WSL Ubuntu installation extracted in one directory, I know where is vxhd file created.
Long story short:

I try create export tar file, but I wrongly assume I should pack whole directory with all files, (vxhd, 38Gb big, included).
I import created file as new distribution wsl --import Ubuntu [target_dir] file.tar
command wsl do nothing - but when I look at mounted \\wsl$\Ubuntu,  I see all files which I pack amd I realize, I should use only vxhd file.
I rename created wxhd file from [target_dir], where was created, and copy my old vxhd file.
Voila, I have my all old distribution back.

Final note. When I open wsl, my default user is not used and I was logged as root. This can be fixed by create/or/add file /etc/wsl.conf with:
[user]
default=yourusername

Then shutdown wsl and start distro again. Now seems all works ok.

WslRegisterDistribution failed with error: 0x8007019e


ci: Run server/client tests parallel to cypress in TestBuildPush

Description

This PR runs the Client & Server unit tests in parallel to Cypress for TBP workflow runs
Removes invalid input restore-keys from actions/cache/save@v3, adding cache-hit
Remove yarn cache from /workflows/client-unit-tests.yml
Making ci-test, client-unit-tests, server-unit-tests mandatory for ci-test-result

Type of change

Yml file update (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

TBP workflow run

Checklist:
QA activity:

[ ] Added Test Plan Approved label after workflow run & tests were identified to run parallel to cypress

Summary by CodeRabbit

Refactor

Updated GitHub Actions workflows to use the latest version of actions/checkout.
Improved CI/CD pipeline by adding conditional job definitions for server and client unit tests.
Enhanced workflow logic to differentiate between pull request and branch push triggers for more accurate code checkouts.
Streamlined caching strategy by removing restore-keys configuration for better dependency management during builds.

@sarojsarab - sample runs here - Run1, Run2.

All pass run

@sarojsarab - Run with no warning.


Use bare module specifiers in the P3 conversion

Connected to vaadin/components-team-tasks#332
Also did some cleanup to eliminate the single legacy Polymer.Base usage.

This change is

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Run R check as cran on action. [skip ci]

Close https://github.com/dmlc/xgboost/issues/6068 .

@hcho3 Thanks for carrying out all the installation of system packages.
Let me submit another PT for addressing the warnings.


make module seeder - stub file not found

I have a module with slug test and name Test.
php artisan make:module:seeder test TestSeeder
Gets me the error output:
[Illuminate\Contracts\Filesystem\FileNotFoundException] File does not exist at path (omitted)\vendor\caffeinated\modules\src\ Console\Generators/../../../resources/stubs/5.2/seeder_plus.stub
I already tried composer dump-autoload, artisan optimize and even removed the entire vendor folder and let composer install the packages again.

Thanks I'll take a look~

I found the same problem.

Found the same issue.
On MakeSeederCommand.php, line 55, it's referencing a file called seeder_plus.stub. Looks like this file is moved.

This no longer appears to be a problem in the latest version, @kaidesu

👍


trying out your renderer with Lexical playground elements throws an error

I am trying out your renderer component with the Lexical playground elements like youtube, image, separator. The serialize callback function throws an error
TypeError: Cannot read properties of undefined (reading 'map')

I think the reason behind is, that there are custom elements which do not have node.children set so I would think that the custom block types should be rendered through the blockRenderes but they are rendered as renderElements. This is how a JSON of Youtube for example looks like:
      {
        format: "",
        type: "youtube",
        version: 1,
        id: "kBUAV4YT1fs",
        loop: false,
        controls: true,
        aspectRatio: "4/3",
        autoplay: false,
        provider: "youtube"
      },

@dohomi We did not encounter this issue as the configuration of the editor inside payload does not allow to add these elements (I think). Could you provide me the full editor content state so I can reproduce this issue 🙏

hey @schaschjan this is how my editor JSON looks like:
export const lexicalPreJson = {
  root: {
    children: [
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Hello World",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "heading",
        version: 1,
        tag: "h1"
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Hello World",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "right",
        indent: 0,
        type: "heading",
        version: 1,
        tag: "h2"
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "this is a simple ",
            type: "text",
            version: 1
          },
          {
            detail: 0,
            format: 1,
            mode: "normal",
            style: "",
            text: "hello",
            type: "text",
            version: 1
          },
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: " ",
            type: "text",
            version: 1
          },
          {
            detail: 0,
            format: 10,
            mode: "normal",
            style: "",
            text: "world",
            type: "text",
            version: 1
          },
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: " example!!",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [],
        direction: null,
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Ordered list:",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            children: [
              {
                detail: 0,
                format: 0,
                mode: "normal",
                style: "",
                text: "first",
                type: "text",
                version: 1
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "listitem",
            version: 1,
            value: 1
          },
          {
            children: [
              {
                detail: 0,
                format: 0,
                mode: "normal",
                style: "",
                text: "second",
                type: "text",
                version: 1
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "listitem",
            version: 1,
            value: 2
          },
          {
            children: [
              {
                detail: 0,
                format: 0,
                mode: "normal",
                style: "",
                text: "third",
                type: "text",
                version: 1
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "listitem",
            version: 1,
            value: 3
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "list",
        version: 1,
        listType: "number",
        start: 1,
        tag: "ol"
      },
      {
        children: [],
        direction: null,
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Bullet list:",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            children: [
              {
                detail: 0,
                format: 0,
                mode: "normal",
                style: "",
                text: "first",
                type: "text",
                version: 1
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "listitem",
            version: 1,
            value: 1
          },
          {
            children: [
              {
                detail: 0,
                format: 0,
                mode: "normal",
                style: "",
                text: "second",
                type: "text",
                version: 1
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "listitem",
            version: 1,
            value: 2
          },
          {
            children: [
              {
                detail: 0,
                format: 0,
                mode: "normal",
                style: "",
                text: "third",
                type: "text",
                version: 1
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "listitem",
            version: 1,
            value: 3
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "list",
        version: 1,
        listType: "bullet",
        start: 1,
        tag: "ul"
      },
      {
        children: [],
        direction: null,
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Some blockquote??",
            type: "text",
            version: 1
          },
          {
            type: "linebreak",
            version: 1
          },
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "isnt that great?",
            type: "text",
            version: 1
          },
          {
            type: "linebreak",
            version: 1
          },
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Here comes a blockquote statement",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "quote",
        version: 1
      },
      {
        children: [
          {
            type: "linebreak",
            version: 1
          },
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "Left align",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "center align",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "center",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            detail: 0,
            format: 0,
            mode: "normal",
            style: "",
            text: "right align",
            type: "text",
            version: 1
          }
        ],
        direction: "ltr",
        format: "right",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [],
        direction: null,
        format: "right",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [],
        direction: null,
        format: "left",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        format: "",
        type: "youtube",
        version: 1,
        id: "kBUAV4YT1fs",
        loop: false,
        controls: true,
        aspectRatio: "4/3",
        autoplay: false,
        provider: "youtube"
      },
      {
        children: [
          {
            altText: "",
            caption: {
              editorState: {
                root: {
                  children: [],
                  direction: null,
                  format: "",
                  indent: 0,
                  type: "root",
                  version: 1
                }
              }
            },
            height: 0,
            position: "full",
            showCaption: false,
            src: "https://placehold.co/600x400/png",
            type: "inline-image",
            version: 1,
            width: 0
          }
        ],
        direction: null,
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        type: "horizontalrule",
        version: 1
      },
      {
        children: [],
        direction: null,
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      },
      {
        children: [
          {
            children: [
              {
                children: [
                  {
                    detail: 0,
                    format: 0,
                    mode: "normal",
                    style: "",
                    text: "This is left column",
                    type: "text",
                    version: 1
                  }
                ],
                direction: "ltr",
                format: "",
                indent: 0,
                type: "paragraph",
                version: 1,
                textFormat: 0
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "layout-item",
            version: 1
          },
          {
            children: [
              {
                children: [
                  {
                    detail: 0,
                    format: 0,
                    mode: "normal",
                    style: "",
                    text: "this is right column",
                    type: "text",
                    version: 1
                  }
                ],
                direction: "ltr",
                format: "",
                indent: 0,
                type: "paragraph",
                version: 1,
                textFormat: 0
              }
            ],
            direction: "ltr",
            format: "",
            indent: 0,
            type: "layout-item",
            version: 1
          }
        ],
        direction: "ltr",
        format: "",
        indent: 0,
        type: "layout-container",
        version: 1,
        templateColumns: "1fr 1fr"
      },
      {
        children: [],
        direction: null,
        format: "",
        indent: 0,
        type: "paragraph",
        version: 1,
        textFormat: 0
      }
    ],
    direction: "ltr",
    format: "",
    indent: 0,
    type: "root",
    version: 1
  }
}

Looking at the source code of PayloadLexicalReactRenderer it seems that the custom block from the Lexical playground such as youtube layout-container layout-item are not of type block, so the property blockRenderers is not applying to it. I am not sure if I do anything wrong in my Lexical config but I was just using some custom components from the Lexical playground.
I fixed it now with following lines of code, even though the types are not yet 100% ideal:
  const serialize = React.useCallback(
(...)
        if (node.type === "block") {
          const renderer = blockRenderers[node.fields.blockType] as (
            props: unknown
          ) => React.ReactNode

          if (typeof renderer !== "function") {
            throw new Error(`Missing block renderer for block type '${node.fields.blockType}'`)
          }

          return <React.Fragment key={index}>{renderer(node)}</React.Fragment>
        }
        if (node.type) {
          const renderer = blockRenderers[node.type]
          if (typeof renderer === "function") {
            return (
              <React.Fragment key={index}>
                {(renderer as Function)({
                  ...node,
                  ...("children" in node && { children: serialize(node.children) })
                })}
              </React.Fragment>
            )
          }
        }
(...)

This way all provided blockRenderers are now rendering if the node.type is matching.

I might be wrong, but think this should not be covered by blockRenderers, since these blocks are solely a payload concept and not "native" to Lexical. The ones like "type": "youtube" are still elements, just like "type": "block" is.
That being said, features like a youtube video could aswell be implemented as a payload block and have a custom renderer within the editor so using them could feel the same way.
Perhaps a bit OT: I feel like there might be room for improvement within payload or lexical to align the payload-introduced blocks and adding  custom element renderers to Lexical in a better way.
Using youtube as an example: Maybe implementing the actual youtube renderer as native Lexical component, and then specific to payload, just a small wrapper that would take care of the data layer, so e.g. passing the youtube video url from a payload source. At best, it wouldn't even be necessary to create a specific payload wrapper per element, but a generic way to deduce supported props for custom Lexical element types. Not sure how feasible this is right now since I believe Lexical elements don't export a specific interface to describe input fields they support.

The actual fix here that seems more correct to me would be to allow extending type ElementRenderers and replacing the current if (node.type === "xyz") checks in renderElement with a more dynamic approach that supports arbitrary node types.


[✨] Support remote IP address in request object for loader and server$ functions

Is your feature request related to a problem?
Currently, it is not obvious nor documented how to access the remote IP address of the requestor in a vendor agnostic way (e.g. via remoteIp, etc. This should be made easier, and documented.
Describe the solution you'd like
Make the remote IP more easily accessible within the event object.
Describe alternatives you've considered
This only works on the dev server and will not work in preview as middleware is not supported.
// vite.config.ts

// Pass the remote IP through via a header (NOTE: should be able to mod the request object)
export const remoteIp = {
  configureServer(server) {
    server.middlewares.use((req, res, next) => {
      const remoteIp = req.headers['x-forwarded-for'] || req.connection.remoteAddress;
      req.headers['remoteIp'] = remoteIp;
      next();
    });
  },
};

// Add to plugins
plugins: [
  remoteIp,
  qwikCity({trailingSlash: false}),
  qwikVite(),
  tsconfigPaths(),
]

Usage
event.request.headers.get('remoteIp')
Additional context
No response

Thanks @manucorporat! 🎉
From looking at the merged files, it looks like the remote ip is easily accessible now via the event object:
server$
    const ip = this.clientConn.ip;

routeLoader$
    const ip = event.clientConn.ip;

@manucorporat, The only thing I'm not seeing is the type through for this on server$. Works fine for routerLoader$.


KinematicVelocityBased bodies are updated by Velocity.

Should fix #145 also help with #142 test not passing and replace #146.
Fixed the problem by reusing update_rapier_velocity  for dynamic and made for all bodies that can_have_velocity.
So removed redundant apply_velocity_to_kinematic_bodies in favor of update_rapier_position.
I think this should be a bit urgent since it's a somewhat 'core' functionality and a few people have asked help on why it wasn't working in the bevy discord.

@edgarssilva, are you planning to continue working on it?


Fix for Calculated columns #230

Fix for https://github.com/OfficeDev/PnP-Sites-Core/issues/230
When extracting calculated fields, the formula for in the SchemaXml is using the Internal Field Names which when provisioning a site will throw an error as it needs the Display Names.
This fix gets the Formula from the Field, which contains the Display Names and replaces the Formula in the SchemaXml before it adds the field.

Hi @m-carter1, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Here we should check, if a site with language en, it and de for example has driven a template in german context, so the formula has german dispay names; now we roll out this template to a site with en, it, de and spanish language, but the primary language is italy. So the german formula will not throw an exception?

Hi Matt and Torsten,
I think we should tokenize the fields in the formula, in order to support the proper display name, based on the site language. Let me do that: I will sync with Erwin (who is our tokenizer master) and we will provide a suitable solution that works with any language. The only potential issue that I see, is that probably we will not be able to complete the task before the next master merge (which will occur tomorrow afternoon). Nevertheless, we will start from here. Thus, you will be both credited for your contribution. I will keep this PR open until the solution will be ready. Thanks!

This issue should have been fixed by this PR: https://github.com/OfficeDev/PnP-Sites-Core/pull/466.
Thus, I will close it.

Hi @erwinvanhunen , this issue doesn't seem to have been resolved.
The tokenizer looks great but the generated schemaXml isn't being used
https://github.com/OfficeDev/PnP-Sites-Core/blob/dev/Core/OfficeDevPnP.Core/Framework/Provisioning/ObjectHandlers/ObjectListInstance.cs#L1407
Simple fix for this is to use the generated xml which is fine but there's another issue where the tokens in the field formulas aren't being swapped out so it will fail to create the fields.
It doesn't look like the tokens are being created anywhere for the list fields and I'm not sure how you can create the tokens before you create the field, and you can't create the field with the tokens still in the formula?
thanks, Matt

Hi, I just want to let you know that this implementation introduces a major bug. If applying the provisioning template twice the calculated field will not work anymore.
I guess this is because of some internal SharePoint manipulation when changing the SchemaXML note that the provisioning template contains the field title (display name), but when provisioned to SharePoint, SharePoint translates it into the internal name and adds field references for each field. When applying the template for the second time it appears that SharePoint does not perform the translation of field title to field internal name.
The formula looks like this after second deploy when I edit the field in the browser: =#NAVN?

Fixed using #817


Flakey test: ReactorNettyClientTests.testConcurrentRequests

We are experiencing some flakey tests in the Java build pipeline. The following retained build shows the issue:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=64773&view=logs&j=8d81b87e-4d26-5175-d51a-680d334119d9
The error is:
[ERROR] Failures: |
-- | --
  | [ERROR]   ReactorNettyClientTests.testConcurrentRequests expectation "expectNext(1100000000)" failed (expected: onNext(1100000000); actual: onError(reactor.netty.http.client.HttpClientOperations$PrematureCloseException: Connection prematurely closed BEFORE response))

This can happen on macOS and Linux but I haven't observed it on Windows (but that could just be lucky). It can mappen on either the LTS or Java 8 builds so that doesn't appear to be a factor. It is happening often enough that it is starting to slow down PR times.

This was resolved in #18911


Account not approved after 2 weeks

I have not been approved to create an account and the FAQ says "Account requests are typically approved within 1 to 5 business days." but it has been 2 weeks  and as forementioned, my account has not been approved.
I have also filled the form as previously outlined in some posts by users who were also having the same issue but to no avail as it has also been a week since I filled the form but there was no response.
Please help me out.

yes, we are running a bit behind on approvals. Expect to see it come through in next couple of days.

@RandallB12 is your account still not approved? We are glad if you tell us the status.

I will close this issue. Please feel free to raise a new issue if you still have the trouble.


Fix sampleStore, remove unnecessary watcher

Add tests:

store has the same state as source
store has its own defaultState
store updates if source updates
store updates only if source is changed

Fix:

Remove watch and use getState

Let's discuss sampleStore intended behaviour

Three tests fail for current version, so we need a fix, I believe. I can remove tests from this PR, if you want.


[stable/prometheus-operator] Added anandsinghkunwar as OWNER

Signed-off-by: Anand Singh Kunwar<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @vsliouniaev

I would be comfortable adding you as a reviewer here. Not sure if the process is less strict for that. Adding you as an owner appears to be forbidden by the repo process

@vsliouniaev Didn't really help.

You will need to follow the process for being added as a trusted collaborator here: https://github.com/helm/charts#trusted-collaborator

@vsliouniaev that's good enough for me 😄
@anandsinghkunwar I have added you as a read-only collaborator per https://github.com/helm/charts#owning-and-maintaining-a-chart. You must accept the invite: https://github.com/helm/charts/invitations

/verify-owners

/ok-to-test

@vsliouniaev Can you approve/merge?


How can I change/save order of fields in data grid ?

Hello,
I changed structure of my mysql table ( I changed order of many fields)
but opening this table with dbeaver 21.2 I see that all fields in datagrid are the same order I had before...
Looks like old settings were saved... Where can I reset/change these settings?
Thanks in advance!

@PetroGromovo do you save changes using Save filter settings button?

Not sure, maybe yes. Could you please explain how this functionality work and how can I clear it to default?

sorry for the late response.
You can read about it here


What happened?
[ 88%] Building C object CMakeFiles/xquic-static.dir/src/congestion_control/xqc_cubic.c.o
/root/quic/test/xquic/src/tls/xqc_tls.c: In function ‘xqc_ssl_session_ticket_key_cb’:
/root/quic/test/xquic/src/tls/xqc_tls.c:883:13: error: implicit declaration of function ‘HMAC_Init_ex’; did you mean ‘SHA1_Init’? [-Werror=implicit-function-declaration]
if (HMAC_Init_ex(hmac_ctx, key->hmac_key, size, digest, NULL) != 1) {
^~~~~~~~~~~~
SHA1_Init
cc1: all warnings being treated as errors
make[2]: *** [CMakeFiles/xquic-static.dir/src/tls/xqc_tls.c.o] 错误 1
make[2]: *** 正在等待未完成的任务....
/root/quic/test/xquic/src/tls/xqc_tls.c: In function ‘xqc_ssl_session_ticket_key_cb’:
/root/quic/test/xquic/src/tls/xqc_tls.c:883:13: error: implicit declaration of function ‘HMAC_Init_ex’; did you mean ‘SHA1_Init’? [-Werror=implicit-function-declaration]
if (HMAC_Init_ex(hmac_ctx, key->hmac_key, size, digest, NULL) != 1) {
^~~~~~~~~~~~
SHA1_Init
Steps To Reproduce
按步骤编译报错
Relevant log output
No response

I just came in to post about the same issue.
I managed to resolve it by adding the following line to xqc_tls.c:
#include <openssl/hmac.h>
Unfortunately I cannot propose a PR due to not being able to sign the contributors license until it's cleared with legal in my company.

估计是boringssl的问题，我用旧的boringssl编译通过了。

boringssl建议用什么版本


bignum_divmod

Since bignum_mod already does the division, it might be handy to have a function that gives both a/b and a%b in one call instead of calling both bignum_div and bignum_mod.

Hi @monolifed and thanks for your comment.
I agree. I'll add the divmod interface to the header file and let the div and mod functions wrap divmod.
Are you looking to use the code for RSA?

Nice. I am looking to use it for some type of PRNG for creating passwords.
random = entropy % range; entropy = entropy/range

I am currently using openssl but I want to replace it.

@dudedsy fixed this outstanding issue: https://github.com/kokke/tiny-bignum-c/pull/4


Delete loan record

This functionality requires the loan record(s) of an authenticated user can be deleted.

all done!


Feat: Add dlt command to update the models from a dlt pipeline

As part of the dlt integration, this update introduces the dlt_refresh command to attach to a dlt pipeline and update the SQLMesh models, either by specifying the tables to be generated or updating with all the new tables.
Usage:

Generate all missing tables:

$ sqlmesh dlt_refresh <pipeline-name>

Generate all missing tables and overwrite existing ones (use with --force or -f):

$ sqlmesh dlt_refresh <pipeline-name> --force

Generate specific dlt tables (using --table or -t):

$ sqlmesh dlt_refresh <pipeline-name> --table <dlt-table>

Thank you for the review @izeigerman addressed comments and revised command names


Conda package is not being kept up-to-date

bump-my-version version: 0.12.0
Python version: Python3.11 (Conda)
Operating System: Fedora

Description
The Anaconda (conda-forge) packages for bump-my-version don't appear to have been updated since v0.12.0. These releases should follow at around the same frequency as releases of bump-my-verison on PyPI.
If you would like help maintaining the conda packages, please let me know.
What I Did
$ conda install bump-my-version

Additional Information
See: https://github.com/conda-forge/bump-my-version-feedstock/pulls

Got this fixed.


Jupyter Notebook: weird behaviors when redirecting sys.stdout

Here is the result of running Legate programs with canonical python interpreter on Jupyter Notebook.

All prints are stacked ahead. It is due to the following code
sys.stdout = LegionOutputStream(sys.stdout)

https://gitlab.com/StanfordLegion/legion/-/blob/control_replication/bindings/python/legion_top.py#L116
I have tried to use sys.__stdout__, but it does not solve the problem. Since we are not running jupyter notebook on multi-node executions (at least not for now), one possible solution is to modify the code into:
if multi-node:
    sys.stdout = LegionOutputStream(sys.stdout)

@elliottslaughter @manopapad @lightsighter any thoughts?

I think Manolis has probably nailed this one.

I can confirm that manually making that change fixes the issue for me:

The generic forwarding seems plausible as well but I'd say merge this small change quickly and open an issue for the wider proposal.

I can also confirm that adding the set_parent does not work for me. Thanks everyone! I will create a PR later.

The PR has been merged to the control replication branch, so close it.


Facebook stop working

Facebook feed stop working this day... No idea why...
Does other people have the same problem ?

Same problem

Welcome:
https://github.com/pavelk2/social-feed/issues/330


load user settings for enabled/disabled band on boot

see issue #31

Does this solve the entire problem?

Yes, it does.

Can you make a new 1.6 build with this patch and update it in the git repo?


fix: add generic email to project_email field for IP registration con…

…firmation email
Describe your changes
Add a generic email to use in case a project email is not provided - otherwise notify errors and user does not receive email.
https://pins-ds.atlassian.net.mcas.ms/jira/software/c/projects/APPLICS/boards/242?selectedIssue=APPLICS-796

Useful information to review or test

Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 2.28.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.34.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[5.3] Can we include which guards were attempted when throwing AuthenticationException?

The two guards I have (web and customer) have two different login paths. I could not find a way to determine which guard was being used when AuthenticationException was thrown.
By default, unauthenticated() redirects to guest('login') which is totally fine in most cases. However, I think it would be beneficial to include the $guards from the Authenticate middleware when throwing the Exception.
For instance, I'm doing this...
// App\Exceptions\Handler.php

protected function unauthenticated($request, AuthenticationException $e)
{
    if ($request->expectsJson()) {
        return response()->json(['error' => 'Unauthenticated.'], 401);
    } else {
        // If unauthenticated trying to access admin, redirect to Admin login.
        if(str_contains('admin', $request->path())) {
            return redirect()->to('auth/admin/login');
        }
        // Redirect to Customer login.
        return redirect()->guest('login');
    }
}

...which is pretty ugly considering a guest might want to access a page called "badminton" behind the customer auth guard.
If we're able to see which guards were attempted, we could leave it up to the developer to determine the best way to handle the presence of multiple guards (i.e. which guard gets preference).
Otherwise, we're flying blind when handling AuthenticationExceptions (whereas previously this did not live in the framework/src and could easily be adapted to particular use cases).
OR
How do we access which guard was attempted in the Handler? If there's a more straightforward way, do tell!

More straightforward is to check the request's route and see if it was web or customer

Using request->is() still feels clunky.
For instance, let's say customer/*, account/*, and foo/bar/* all had the customer guard. But account/* has the account guard as well.
Doing this in unauthenticated()...
if($exception->guards->contains('account') {
    // redirect to register page.
}

if($exception->guards->contains('customer') {
    // redirect to login page.
}

...is way more intuitive than...
if ($request->is('customer/*') {
    // redirect to login page.
}
if ($request->is('account/*') {
    // redirect to register page.
}
if ($request->is('foo/bar/*') {
    // redirect to login page.
}

...right?
It reads better, it provides appropriate context for throwing the Exception, and it doesn't require leaking the routing structure.
In other words, I don't really care which room in my house you're trying to get into, I just want to know which outside door you're knocking on so I can point you to the right place.
Anyway, I'm ok with the workaround but I think this could be valuable.

I agree. I feel that with this new AuthenticationException we've lost something.
I don't see it as a big deal to simply add some params to the exception so we know which guard was used during the failed login attempt:
`protected function authenticate(array $guards)
{
if (empty($guards)) {
return $this->auth->authenticate();
}
    foreach ($guards as $guard) {
        if ($this->auth->guard($guard)->check()) {
            return $this->auth->shouldUse($guard);
        }
    }

    throw new AuthenticationException($guards);
}`


Add project setting for max lights and reflections in GLES3

Implemented based on https://github.com/godotengine/godot/pull/14902
Should alleviate https://github.com/godotengine/godot/issues/21957 for GLES3.

Thanks!

Thank you @clayjohn.

Cherry-picked for 3.1.2.


Search may not correctly query all responses

Searching from the main page for either 5.4.1, 550 5.4.1 or smtp;550 5.4.1 doesn't return any results
I would expect it to match responses such as this one in ./data/codes/550.json:
https://github.com/wildbit/smtp-field-manual/blob/c59e44ed3e638a5f707cb9b942ea09bfc126696a/data/codes/550.json#L225-L228

Turns out we weren't uploading any of the responses from spam filter services. Only email providers. It's fixed now. Thanks for catching this!

No prob, and thank you as well 😄


Screenshots Not showing in AppStoreConnect after successful upload

Hello, I am using the latest version of Fastlane. The command I ran was snapshot reset_simulator and then fastlane deliver
Everything is successful and I can see the screenshots in the folder. However when I check AppStore Connect, nothing is there.
Pictures:
https://ibb.co/n3qzKRq
https://ibb.co/Krb4jPv
https://ibb.co/DMnRyRk
https://ibb.co/JxNFmwD
The weird thing is, Fastlane downloaded some screenshots and they even showed up in the folder. Yet I don't know where they came from because they are not on AppStore Connect and this is a separate machine.

Hi Ben, from the last screenshot, I can only see that you are trying to upload screenshots for iPhone X (which is not the XS category you have selected in App Store Connect). Could you please go to the "Media Manager" and check all screenshot sizes/categories if they ended up there.

Hi, sorry for the lack of formatting and late reply, I’ve been super busy.
I am using all default settings.
I have checked the media manager and nothing is there, not even iPads etc

Hi, the issue was that by default I was using english(UK), I didn't notice that you can manually drop down to select english US in the App Store connect panel. Lo and behold there were the screenshots. I have now specified that it should be English UK.


Set highContrast value from AccessibilityFeatures into MediaQueryData

Description
Part of the efforts to fix the issue #48418 split in a new PR as suggested by @Piinks in #48486
The highContrast property is going to be added to the class AccessibilityFeatures in the PR: flutter/engine#15343
Here, I set it to the MediaQueryData class so it can be used by Flutter developers by querying: MediaQuery.of(context).highContrast
Design document: https://flutter.dev/go/cupertino-increase-contrast
Related Issues
Blocked by: https://github.com/flutter/engine/pull/15343
Fixes: #48418
Related to: https://github.com/flutter/flutter/pull/48486
Tests
Tests are covered in https://github.com/flutter/flutter/pull/48486
Checklist
Checklist covered in https://github.com/flutter/flutter/pull/48486
Breaking Change
Change info covered in https://github.com/flutter/flutter/pull/48486

Looks like the blocking engine PR was submitted (flutter/engine#15343). Is this one ready to move forward?
Also, is it possible to add a test for this?

Hi @goderbauer
I looked into the possibility to add tests covering this code change, but I didn't see it done for the other MediaQueryData parameters (like disableAnimations or boldText), maybe you can point me to one, or I can write a new test case on verifying that MediaQueryData is created correctly using window.accessibilityFeatures.

Hey @miquelbeltran, This PR will need to be updated with the latest from master.
Regarding the tests, I made a similar change (#33999) that may be helpful. Tests like
https://github.com/flutter/flutter/blob/1ec2a43672c1d7a5dd9ef3b295b1931956e41782/packages/flutter/test/widgets/media_query_test.dart#L74
should provide the appropriate coverage for this change. Several of the tests in that file make sure the property works as intended with the expected values. Let me know if that is helpful in creating tests for this. :)

Thanks for the hint @Piinks! I added the highContrast field to the existing tests, which was missing.

While you are here, can you re-apply the change to the FakeAccessibilityFeatures class? I removed them so the engine change could land: https://github.com/flutter/flutter/pull/51130/files
This has been a tricky change to land in a non-breaking way, and while you were at it you made it easier for others that will make changes like this in the future. Thanks for this. It's just about ready. :)


json.Rawmessage decodes null as "null"

What version of Go are you using (go version)?

$ go version
go version go1.13.1 linux/amd64

Does this issue reproduce with the latest release?
i can reproduce on go version go1.14 linux/amd64
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/oha/.cache/go-build"
GOENV="/home/oha/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/oha/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/oha/sdk/go1.13.1"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/oha/sdk/go1.13.1/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build838880304=/tmp/go-build -gno-record-gcc-switches"

What did you do?
package main

import (
        "encoding/json"
        "testing"
)

type Frame struct {
        Data json.RawMessage `json:"data"`
}

func TestJson(t *testing.T) {
        f := Frame{Data: nil}
        t.Logf("%#v (%q)", f, f.Data)

        j, _ := json.Marshal(f)
        t.Logf("json: %s", j)

        var f2 Frame
        json.Unmarshal(j, &f2)
        t.Logf("%#v (%q)", f2, f2.Data)
}

What did you expect to see?
f.Data and f2.Data should be the same (nil)
What did you see instead?
=== RUN   TestJson
--- PASS: TestJson (0.00s)
    json_test.go:14: main.Frame{Data:json.RawMessage(nil)} ("")
    json_test.go:17: json: {"data":null}
    json_test.go:21: main.Frame{Data:json.RawMessage{0x6e, 0x75, 0x6c, 0x6c}} ("null")
PASS

json.Unmarshal decode null as "null"

note, if json:"data,omitempty" than everything works as expected

I think you're just seeing the result of using the %q format which quotes things. Maybe you meant to use %s.

i included also the %#v which shows how json.RawMessage(nil) is turned into json.RawMessage{0x6e, 0x75, 0x6c, 0x6c} which are the ascii of null

I believe this is working as intended, json.RawMessage specifically means not to parse the data and store it as is in json

I believe this is working as intended, json.RawMessage specifically means not to parse the data and store it as is in json

oh yes, i see it now. if further Unmarshalled, it returns nil.


Help

hi, I want to do the coding myself, but can you help me find the addresses such as player list, entity list, player life?

There are no static addresses for such things in Minecraft. But you able to use JNI to get access to java field's


[Improvement] Support .dist extension.

Hello,
Thanks for this great tools.
I searched through the documentation, but it seems it is not an available feature.
Purpose of this issue is to hadle the .dist mecanism used on many tools.
It will allow developper to place a local config (excluded from git repo) which will override/replace the dist one.
I hope it makes sense. For us it will be helpfull (we use lint-staged which use cosmiconfig, and we would like developper to be able to set some custom config just on their computer).
Thanks.

I don't understand the feature request, because I'm not sure what particular ".dist mechanism" you're referring to. I don't have experience with one myself, and a Google search comes up with a few different possibilities. It doesn't seem like .dist unanimously represents for the use case you describe (unless I'm just not turning up the right search results).
I'll close this issue because I don't really understand and I left it hanging so it's probably stale. Please open a new issue with more details if you think there's a good case to be made. Keep in mind that lint-staged can implement whatever it was on top of cosmiconfig — no need for cosmiconfig's own behavior to change, if you're just targeting that tool.

@davidtheclark Thanks for your answer.
You are right our needs is for lint-staged, so I posted here thinking if it is added to your repo it will benefits to all packages (like lint staged) of this new feature.
Yes .dist is not a convention, but it is used by some of well-know CI packages.
In fact,, we have not to use such dist mecanisme if needed.
You could just modify the part of the code which is looking for config file:
    a myapp property in package.json
    a .myapprc.local file in JSON or YAML format => this is the new one
    a .myapprc file in JSON or YAML format
    a .myapprc.json file
    a .myapprc.yaml, .myapprc.yml, or .myapprc.js file
    a myapp.config.js file exporting a JS object

Same mecanism can be added if you want for json, yaml and js file, by locking somthing like .myapp.local.yaml, etc.
I opened an issue on lint staged so maybe they can handle it on their side: https://github.com/okonet/lint-staged/issues/894
Best regards.


[WIP] Added chart for firmament-poseidon

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign @dhilipkumars

@nikita15p Thanks for the PR, there is a lot needs to be done to get this PR in a good shape.  Please have a look at best practices.
Once all the work is done we could remove [WIP] from the titile.
Pleae sign the Linux Foundation CLA to start with.

Bump to verify CLA.

@nikita15p You created this as a WIP and did not specify any description. With all due respect but I'm not inclined to review this. We get lots of PRs here which is great and keeps us maintainers busy. But next time, please finish you stuff first and then create a PR. If you have questions on how to implement things, please join Slack and ask there before creating a PR. Thank you.

/ok-to-test

@kubernetes/charts-maintainers PTAL.

@nikita15p Could you please apply all the review comments on this chart?


advi: use ghostscriptX instead of gs discovered at build time

Description of changes
advi hardcodes the path of gs found at build time, thus creating an unwanted dependency on texlive.combined.scheme-medium, moreover on a ghostscript version without X11 support.
This PR ensures that advi relies on ghostscriptX instead.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2346


Why does this library rely on multiple libraries?

when the app uses the httpdns library.  Google Play was rejected by the message.

After one hour work.
all deps which exclude the beacon is unnecessary.

That's the uncertain behavior libs.

2.2.1 should fix the issue google reported.
Other libraries provide basic feature for all aliyun's SDK. They can disable httpdns when something goes wrong.
You can change the code as you wish.


docs: add kep about the status of the federated resources

What this PR does / why we need it:
It proposes a Kep to improve the visibility of the health of the federated resources using the current status field of the federated resources.
Nowadays users have to connect to the kubefed clusters to be aware if the federated
resources (deployments) are healthy or not across all the kubefed clusters.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

/cc @deads2k
Could you please help to take a look at this? I guess you will be interested in this.

For deployment, the available replica number is also important, especially when we use rebalance strategy.
See https://github.com/kubernetes-sigs/kubefed/issues/1240#issuecomment-651514461

@hectorj2f the proposal here seems ok to me. I would however like it more if propagation status and the individual cluster resource status could be segregated in in some way. For example as a user I can see both the propagation status and individual resource status as two separate sub status fields in the status resource. wdyt?
Additionally, I find it a lot more valuable to be able to have an option (for example via the typeconfig) to control what status shows up and what not and probably at some point add  an option to get the raw resource status (for any/all resources) as mentioned in this comment.

@hectorj2f the proposal here seems ok to me. I would however like it more if propagation status and the individual cluster resource status could be segregated in in some way. For example as a user I can see both the propagation status and individual resource status as two separate sub status fields in the status resource. wdyt?

Initially I started following this approach but then I found that logically the goal of a resource is to be ready in a remote cluster. This might differ from a resource to another, for instance:

Secret: ready would mean creation, so the propagation status itself would determine the readiness by the creation of the resource.
Deployment: this special case requires the checking of its status condition, therefore we need the propagation + the ready condition.

With that said, I see the status of a federated resource as a single field where the potential state transitions will go from (as examples): PropagationOK + IsReady (optional).
Therefore I can only envision one field as now.

Additionally, I find it a lot more valuable to be able to have an option (for example via the typeconfig) to control what status shows up and what not and probably at some point add an option to get the raw resource status (for any/all resources) as mentioned in this comment.

I don't disagree but I think that should be tackled in a different kep or iteration. We are just trying to improve the content of the status field focusing on the failed resources (as until now).

As @pmorie raised in one of the meetings, we might need to add to this feature a qps flag to be able to limit the amount of queries and so avoid blowing the control-plane at a high scale.

@hectorj2f Is there something open on this? This looks ok for me in its current shape.
I would be happier if we can capture the gist of having the alternative status representation in a small section in the document itself for future reference (and not having it lost).

@irfanurrehman No. I'll revisit minor details and add the alternative section to the KEP. Other than that, it is completed.

@hectorj2f I have few more comments and questions, after your changes. Overall this looks good!

This is quite fine as provisional for me. It can certainly be refined and updated later.
I will leave it to another set of eyes to check or merge this.

I agree with @irfanurrehman above that this is in a good state as a provisional KEP which we can refine in a few more PRs which I think are already on the way.
/lgtm


[SPARK-15863][SQL][DOC][SPARKR] sql programming guide updates to include sparkSession in R

What changes were proposed in this pull request?
Update doc as per discussion in PR #13592
How was this patch tested?
manual
@shivaram @liancheng

Test build #60904 has started for PR 13799 at commit 1b6ebf5.

Test build #60904 has finished for PR 13799 at commit 1b6ebf5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/60904/
Test PASSed.

Thanks LGTM. Will wait for @liancheng to also take a look

LGTM. Thanks! Merging to master and branch-2.0.


Looks like Deno setup doesn't work

Maybe I'm holding it wrong, but I thought I'd report this
deno run  --allow-env --allow-read --allow-write main.ts
error: Uncaught ReferenceError: require is not defined
    return require('node:path').join(
    ^
    at Object.karabinerConfigFile (https://deno.land/x/karabinerts@1.24.0/output.ts:16:5)
    at writeToProfile (https://deno.land/x/karabinerts@1.24.0/output.ts:61:51)
    at file:///Users/kai/projects/karabiner/main.ts:13:1

looks like the output thing tries to import node:path and barfs. everything else seem working
console.log(rule("stuff").manipulators([...]).build())

this works fine

as a workaround, I did this
console.log(JSON.stringify({
  title: "My rules",
  rules: [
    rule("..."),
    ....
  ]
}, null, 2);

and then build it like so:
deno run main.ts > output.json

and then import it manually in karabiner

Hi @kaievns , thanks for trying out the project. Are you importing from deno.ts like
import { rule, writeToProfile } from<EMAIL_ADDRESS>

yup, exactly that
import {
  ifDevice,
  map,
  rule,
  writeToProfile,
} from<EMAIL_ADDRESS>
import { halmak } from "./halmak.ts";

const ifInternalKeyboard = ifDevice({ vendor_id: 1452, product_id: 834 });
const ifExternalKaiboard = ifDevice({ vendor_id: 7504, product_id: 24926 });

writeToProfile("Default", [
  rule("internal-halmak", ifInternalKeyboard).manipulators([
    halmak,
  ]),
  rule("kaiboard-controls-swap", ifExternalKaiboard).manipulators([
    map("left⌘").to("left⌃"),
    map("left⌃").to("left⌘"),
    map("right⌘").to("right⌃"),
    map("right⌃").to("right⌘"),
  ]),
]);

looks like you are importing from index.ts instead of deno.ts
import {
  ifDevice,
  map,
  rule,
  writeToProfile,
} from<EMAIL_ADDRESS>

ah! thank you!


Writable Round-Stats

Could we make the SMod stats writable?
I'm trying to get rid of all my Assembly references but i cant change stats through the API
https://cdn.discordapp.com/attachments/420579199359909888/950719002253074472/unknown.png

Are there any other parameters than these you are looking for? 72b8cc4

Can't think of any atm.


fix document for hooks execution order

issue found by #5133 in dbt-core, updating the document to reflect the correct order

@runleonarun  Can I get a review of this?


Yara app

A yara app with a set of rules from somewhere that takes an item and reports back the findings

It works with test rules! Just gotta make the rules import-able. Will probably require local rule imports.


Transpilation issue for not initialized member variables?

TypeScript Version:  4.1.2 (I guess it's the same behavior for older versions too)

Search Terms:
constructor member undefined transpilation
Code
class X { a: any }

console.log(Object.keys(new X()))

Expected behavior:
Sholdn't that be transpiled to to following?
"use strict";
class X {
    constructor() {
        this.a = undefined;
    }
}
console.log(Object.keys(new X()));

Shouldn't it print out ["a"] to the console?
Actual behavior:
Actually the code above transpiles to:
"use strict";
class X {
}
console.log(Object.keys(new X()));

and prints out [] to the console.
Playground Link:
» Demo on TypeScript Playground
» JavaScript counterpart (the experimental syntax feature regarding the declaration of member variables is not yet proper ES2020 but should already work in very modern Chrome and Firefox browsers)
Prints out ["a"] to the console (in contrast to its TypeScript counterpart)

This is the intended behavior, since (pre-standardization of this) you might have just been declaring something with the intent to not set it.
Set the useDefineForClassFields setting to get the fully-compliant behavior.


Fix flaky blocks-add-node test

Motivation

Closes #2222

Changes

Fix flaky blocks-add-node test

Test Plan

System tests

TODO

[X] Fix flaky blocks-add-node test
[ ] Finish created todo's
[ ] Document changes

@nkryuchkov I saw you reformatted a few files - I'm generally not against this, but at this point in time it may cause avoidable conflicts with other PRs, so I suggest reverting those changes and possibly making them in a separate PR after we've mostly emptied our PR queue.

@noamnelke Thanks, I agree.

Superseded by https://github.com/spacemeshos/go-spacemesh/pull/2239


docs: Correct tense of sample commit desc

Sample commit desc is in present tense now.
Closes https://github.com/karma-runner/karma/issues/2581

Thanks :octocat:


add tag for 1.2.2

In the Node.js docs (in esm.md), there is a link to https://github.com/guybedford/cjs-module-lexer/tree/1.2.2 but that link 404's because there is no tag/release in GitHub for 1.22. Can you add one?

Done, thanks for noticing. Btw I would still want to transfer this project into the Node.js org / extend permissions on it. If anyone wants to be added as a maintainer just let me know too.

Done, thanks for noticing. Btw I would still want to transfer this project into the Node.js org / extend permissions on it. If anyone wants to be added as a maintainer just let me know too.

I don't want to be added as a maintainer, but I would support moving it into the nodejs org.  There's a checklist somewhere (basic stuff--have a README, have a compatible LICENSE, have a CoC, that sort of thing) but the main thing to do is to open an issue in the admin repo. (Maybe you already did that? In which case I'll happily +1 it and/or do what I can to get it unstuck.)

Documentation is here: https://github.com/nodejs/admin/blob/main/transfer-repo-into-the-org.md

If someone wants to run through the checklist there I will gladly give the necessary access to do the process.


[BrokenLinksH2] Fix path in link

Fixing the link path line 12

Docs Build status updates of commit ec6c10e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/webapi/nested-paths-routing.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tfosmark, Please can you review and merge!

Global effort to fix broken links
@xuzhg
The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This PR includes only link fixes and does not change other content. Please review within five business days and merge, or comment in the PR with any changes you'd like to see. Thanks!


Also log the IOException

SLF4J has special support for the last argument to a logger call being
an instance of Throwable: https://www.slf4j.org/faq.html#string_or_object

Coverage remained the same at 88.959% when pulling eb0c204d158c551fb91c43e622c19a4d22f8f90a on dtrebbien:patch-3 into 68775d375d9b63fa18e2c6833d43ea59cedb963f on Netflix:master.

See #569


Merge to live!

Docs Build status updates of commit adebcbe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

officedocs-dev-outlook-pia/docfx.json
:white_check_mark:Succeeded

officedocs-dev-outlook-pia/xml/Microsoft.Office.Interop.Outlook/_Items.xml
:white_check_mark:Succeeded

officedocs-dev-outlook-pia/xml/Microsoft.Office.Interop.Outlook/_Table.xml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


ToolbarMenu Adjustment & Watch Showcase

Changes proposed in this Pull Request:

In angular 13, we cannot build our component library & then copy the dist folder into the showcase node_modules anymore.  The node_modules are no longer recompiled on changes.
This changes the watch:showcase command to watch & copy changed files from the library src folder to the showcase src/lib folder.  Showcase will recompile the library code.

This introduces a couple new tsconfig files.
tsconfig.lib.json is used when developing new components from the angular-components repo.  It replaces at @brightlayer-ui/angular-components imports with the local src/lib folder.
tsconfig.app.json is used outside of the angular-components repo; default behavior for resolving @brightlayer-ui/angular-components.

This PR also adjusts the icon size in the menutoolbar.

This also updates the toolbarmenu's icon size


registration and login whitelisting

Currently when you run lgtm it will allow anyone to log in and set up hooks with your application. This is not useful for personal services (such as the one I'm running at https://lgtm.cyphar.com/). The way I got around this problem is by adding a regular-expression whitelist of usernames that can log in or register.
From aeed56fb775923e4c1bd4ff8bea1189fc7f3160e Mon Sep 17 00:00:00 2001
From: Aleksa Sarai<EMAIL_ADDRESS>Date: Sat, 17 Dec 2016 13:45:55 +1100
Subject: [PATCH] web: login: add whitelist to usernames

This is a bit of a questionable patch ATM, mainly because it implies
that it is scalable to create a giant regular expression that is only
checked at /login.

Ideally this check should be done at the DB level (or at the API level)
to ensure that no API will work if you're trying to do anything with a
user not in the whitelist. And it should be configurable to be based on
organisation.

But none of that really matters for my usecase, so YOLO.

Signed-off-by: Aleksa Sarai<EMAIL_ADDRESS>---
 web/login.go | 39 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/web/login.go b/web/login.go
index c6088396046d..ff31fbc643da 100644
--- a/web/login.go
+++ b/web/login.go
@@ -2,6 +2,7 @@ package web

 import (
 	"net/http"
+	"regexp"
 	"time"

 	"github.com/lgtmco/lgtm/model"
@@ -12,8 +13,25 @@ import (

 	log "github.com/Sirupsen/logrus"
 	"github.com/gin-gonic/gin"
+	"github.com/ianschenck/envflag"
 )

+var (
+	whitelist      = envflag.String("USER_WHITELIST", "", "")
+	forceWhitelist = envflag.Bool("USER_WHITELIST_FORCE", false, "")
+
+	userWhitelistRegexp *regexp.Regexp
+)
+
+func init() {
+	envflag.Parse()
+
+	if *whitelist == "" {
+		*whitelist = ".*"
+	}
+	userWhitelistRegexp = regexp.MustCompile(*whitelist)
+}
+
 // Login attempts to authorize a user via GitHub oauth2. If the user does not
 // yet exist, and new account is created. Upon successful login the user is
 // redirected to the main screen.
@@ -45,7 +63,6 @@ func Login(c *gin.Context) {
 	// get the user from the database
 	u, err := store.GetUserLogin(c, tmpuser.Login)
 	if err != nil {
-
 		// create the user account
 		u = &model.User{}
 		u.Login = tmpuser.Login
@@ -53,6 +70,13 @@ func Login(c *gin.Context) {
 		u.Avatar = tmpuser.Avatar
 		u.Secret = model.Rand()

+		// If someone has set a whitelist, we need to obey it.
+		if !userWhitelistRegexp.MatchString(u.Login) {
+			log.Errorf("user not in whitelist tried to register: %s", u.Login)
+			c.Redirect(303, "/login?error=not_in_whitelist")
+			return
+		}
+
 		// insert the user into the database
 		if err := store.CreateUser(c, u); err != nil {
 			log.Errorf("cannot insert %s. %s", u.Login, err)
@@ -61,6 +85,13 @@ func Login(c *gin.Context) {
 		}
 	}

+	// If someone has set a whitelist, we need to obey it.
+	if *forceWhitelist && !userWhitelistRegexp.MatchString(u.Login) {
+		log.Errorf("user not in whitelist tried to log in: %s", u.Login)
+		c.Redirect(303, "/login?error=not_in_whitelist")
+		return
+	}
+
 	// update the user meta data and authorization
 	// data and cache in the datastore.
 	u.Token = tmpuser.Token
@@ -99,6 +130,12 @@ func LoginToken(c *gin.Context) {
 		c.String(404, "Unable to authenticate user %s. Not registered.", user.Login)
 		return
 	}
+	// If someone has set a whitelist, we need to obey it.
+	if *forceWhitelist && !userWhitelistRegexp.MatchString(user.Login) {
+		log.Errorf("user not in whitelist tried to log in: %s", user.Login)
+		c.Redirect(303, "/login?error=not_in_whitelist")
+		return
+	}
 	exp := time.Now().Add(time.Hour * 72).Unix()
 	token := token.New(token.UserToken, user.Login)
 	tokenstr, err := token.SignExpires(user.Secret, exp)
--
2.11.0

This was just a quick hack for me to secure my setup, but I'm sure that there's a nicer way of handling it. For example, you could configure it so that there's some organisation that you have to be a member of in order to register or log in.

Thanks for the hint, let's see how we can integrate it properly


RDK-35695: Implement group of thunder APIs for AVoutput plugin

Porting AVOutput changes from 23Q4 branch to 2401 branch

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.praveenraj.gopalakrishnan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.praveenraj.gopalakrishnan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/rdkservices/4783/rdkcentral/rdkservices

Commit: 3f9b3fd789a2679ea80f53535fb35a2f0433ee34

Report detail: gist

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 2 files pending identification.

Protex Server Path: /home/blackduck/github/rdkservices/4783/rdkcentral/rdkservices

Commit: 3f9b3fd789a2679ea80f53535fb35a2f0433ee34

Report detail: gist

WARNING: A Blackduck scan failure has been waived
A prior failure has been upvoted

Upvote reason: OK (sorry for delay)

Commit: 3f9b3fd789a2679ea80f53535fb35a2f0433ee34


genmsg: 0.5.16-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository genmsg to 0.5.16-1:

upstream repository: git@github.com:ros/genmsg.git
release repository: https://github.com/ros-gbp/genmsg-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.3
previous version for package: 0.5.15-1

genmsg
* fix comment handling in service spec string constants (#92 <https://github.com/ros/genmsg/issues/92>)

Waiting for other Melodic releases...


Upload True Coin

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

@bloqum For next PR please update your fork, for now images added here https://github.com/TrustWallet/tokens/commit/a960fb76d16fc8a0c62199277fc3c8beef90ccf1


Az/fix upload anno

resolve #768

@azhavoro , could you please add a test for REST API to check that before the patch it didn't work?


Enable cache sweeping in CI

Addresses part of #212.
I recently merged a feature into Leafwing-Studios/cargo-cache v2.3.0 that automatically deletes unused build artifacts before creating a new cache, to prevent cache sizes from snowballing.
It's disabled by default due to backward compatibility reasons, so this PR enables it. Cache sweeping should keep cache sizes small and workflow runs fast.
(As an side, should a cache be used at all in the release build? Caching prevents builds from being reproducible, and can introduce the occasional issue when building.)

I made a temporary commit (7188e2c623e4b4fc97cd9abad3d55c3ae364544d) that updates some dependencies, which will make some build artifacts stale. After looking at the run, it removed 365 MiB on the Clippy and Docs jobs and removed a whopping 3.68 GiB on the Tests job.
These savings will only occur when a fallback key is used (typically when Cargo.lock or Cargo.toml is changed), but are quite significant. The only downside is an ~2 second overhead in the cache action from downloading cargo-sweep.

That's really impressive :D Good work!


Amount field symbol UI bug

How should we handle symbols that are really long in the new amount field?
Also should handle in asset list.

ARK...SDA?

@markmhx looking into this today to fix, it appears @alter-eggo added a line in the code to catch this and forces a smaller font size (22px)...
https://github.com/hirosystems/wallet/blob/badce0794005276c338959c160e8a375c0e62442/src/app/pages/send/send-crypto-asset-form/components/amount-field.tsx#L60

Is this ok, or do we want to change to the ellipses?

Yep this looks ok to me!


API/Client: Revise JSON cstring conversion code

This patch revises the mechanism that creates ml_option_h typed data from a JSON cstring.
Signed-off-by: Wook Song<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #340. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @wooksong, c/src/ml-api-service-agent-client.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md


Update contributing.md since we are not using the latest branch

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Can one of the admins verify this patch?


Unknow issue

self.socket.listen(self.request_queue_size)
OSError: [Errno 98] Address already in use
$ python3 -m http.server --directory /workspace 8000
Background command started. To stop it, send a kill action with id 3
$ Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/usr/lib/python3.10/http/server.py", line 1307, in
J    test(
File "/usr/lib/python3.10/http/server.py", line 1258, in test
w    with ServerClass(addr, HandlerClass) as httpd:
File "/usr/lib/python3.10/socketserver.py", line 452, in init
^    self.server_bind()
File "/usr/lib/python3.10/http/server.py", line 1301, in server_bind
�    return super().server_bind()
File "/usr/lib/python3.10/http/server.py", line 137, in server_bind
socketserver.TCPServer.server_bind(self)
File "/usr/lib/python3.10/socketserver.py", line 466, in server_bind
U    self.socket.bind(self.server_address)
OSError: [Errno 98] Address already in use
$ Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/usr/lib/python3.10/http/server.py", line 1307, in
�    test(
File "/usr/lib/python3.10/http/server.py", line 1258, in test
with ServerClass(addr, HandlerClass) as httpd:
File "/usr/lib/python3.10/socketserver.py", line 452, in init
^    self.server_bind()
File "/usr/lib/python3.10/http/server.py", line 1301, in server_bind
g    return super().server_bind()
File "/usr/lib/python3.10/http/server.py", line 137, in server_bind
t    socketserver.TCPServer.server_bind(self)
File "/usr/lib/python3.10/socketserver.py", line 466, in server_bind
U    self.socket.bind(self.server_address)
OSError: [Errno 98] Address already in use

hoeew did you get it to work\

This is not a problem with opendevin, this is a problem with you having a conflicting port on your computer.
OSError: [Errno 98] Address already in use
Stop whatever process is taking port 3000 or 30001

lsof -i:[PORT] should help to kill that process in linux

@PierrunoYT please fill out the template when opening issues.


Use iterators in Up and Avg filtering

Consolidate Avg remainder loop to main loop
In addition to removing some bounds checks, this seems to reduce the instruction count and enable more autovectorization.

The repeat(0).take(bpp).chain(...) approach is clever.  A large percentage of total decoding time is spent in this method, so even small optimizations are significant.
I was thinking of trying the Paeth approach of chunks_exact + remainder + final bpp as three separate loops for all the filters. Did you try something like that and see worse results for Up and Avg?
(I'd probably factor out the there loops into a generic method that takes a closure to call per-pixel. Which should produce good results assuming everything gets inlined together.)

Is corpus-bench.rs the recommended way to get a feel for encoding speed? I set it to the encoder types and compared between branches, chunks_exact + remainder + final bpp is faster than the previous commit.
I saw the work you did with the other filters and this seemed like low hanging fruit adjacent to it which could be improved as a stopgap until something better. I've had cases where chunks_exact + residual ended up being the same speed or slower in personal code so I was hesitant without a decent way of measuring.
Another hot function for encoding, I noticed the filter::sum_filter doesn't get vectorized with the saturating_add for some reason. unfilter could probably use some similar love to its filters.

There's certainly tons of room for improvement in the adaptive filtering. Right now it does 9 passes over the input row (5x sum_buffer + 4x filter) which is way more than necessary. I experimented with doing one pass to compute all the sums at once, followed by a filtering pass with whichever one was best. That produced good results but we'd want to do some refactoring at the same time to avoid the growing amount of code duplication.

Also agreed on unfilter. That function is the main bottleneck in decoding, but turns out to be trickier to vectorize because of dependencies between pixels. (Except for the Up filter which only depends on the previous row)


feat: pass arrays by reference to functions

closes #160

This turns out to be more difficult than initially thought. Simply saving the arrays afterwards is difficult to do for array references. It is technically possible, but would require some significant refactoring around how array values are updated. For now, #173 blocks the developer from passing arrays to function without the use of clone, which means that this issue is no longer blocking a stable release.

Closing this since there is no plan to continue work any time soon


AuditedCollection renames indexBy value and then use it. That avoids …

…name collisions between loaded entity identifiers and indexation settings on association.

@hubipe thanks for the contribution!
Did you check, if there is already a test in place to cover this? Also: this would, theoretically, produce a naming collision, if there was a column called __indexBy, correct? Highly unlikely, I know :smile:

@hubipe what exactly does this fix? Can you please submit a testcase to cover this?

This pull request solves problem, when there is collection indexed by one of the primary keys (identifiers). Previous code unset one of the identifiers in keys array, which may problem. With the new implementation, the index by key is renamed to __indexBy and afterwards removed. There might be a name collision only when one of the identifiers is named __indexBy, which as tolry already said, is highly unlikely. Other approach would be to not unset the indexBy key on line 526, if this name collision is detected.
I'm sorry, I can't submit test case, IDK how :(

@hubipe what do your entities look like, which trigger the bug?

Can you please create a test so we can reproduce it?

If the issue still existis, please create an new PR with a test to reproduce it. Thanks!


Why not just use jsdom?

As you duplicate more and more functionality, I was wondering why not just contribute to jsdom? Is it materially slower? (We made it possible to be much faster if you turn off script support, in 4.0.3.)

jsdom tries to do too much, it acts like a browser. Mayeb I need to try 4.0.3. Last time I tried it it didn't work in newer versions of node because contextify failed to compile. I'd rather not depend on modules that are so fragile and bound to specific APIs on V8. All I want on top of parse5 is some utilities to query and modify it's AST. I also need these utilities in the browser.
(mini-rant: I can't believe that npm install is such a huge security hole by allowing local code execution like build scripts! I'm new to npm, but I immediately wanted to globally disable install hooks)

@domenic Maybe i'm missing something, but how do you turn off all script support?
All I see is the ability to turn off external scripts, but I'm worried about inline scripts being executed.
Also, I'm worried by dependence on iojs, when dom5 will work with node 0.10 and 0.12 as well as iojs.
Is that just for contextify support, or are there more fundamental JS features that being used that require iojs?

(To be clear, I don't really expect anyone to abandon this project; I'm more just looking for feedback on why jsdom doesn't meet your needs :)
It turns out that the word "external" in jsdom's options is a bit misleading. It generally means "in-DOM"---as opposed to "in io.js". If you turn off ProcessExternalResources for script, no <script> tags will run, ever. But you can still manipulate the DOM from io.js "scripts." (@Sebmaster can correct me if I'm misreading the code, since he made the recent changes.)
The dependency on io.js is for a bunch of stuff, but it basically breaks down into two categories: the new vm module, and a dependency on a V8 version that is not years old. That's important for a number of language features we rely on, e.g. Set, and likely soon Symbol.toStringTag. I can understand how it might be a deal-breaker for you guys though. The upside is, it no longer needs to compile anything, addressing @justinfagnani's concern :).

Not compiling at install is certainly nicer :)
What would be even better to me is if jsdom were layered into multiple packages. The layer we're interested in would just wrap the parse5 AST in a DOM compatible API, without any resource loading or script execution. Then the more complete browser emulation about be built on top of that.
Keep us in the loop of changes and we'll take another look in the future. I'll close this for now.

I'd just like to add here that its really nice how light dom5 is. I definitely appreciate the small number of dependencies (just 1 in this case).


Parse prepared statements and portals

Objectives

handle messages of type P (Parse) and B (Bind):

store the prepared statement and its parameter OIDs
validate existing statement on bind, and store it in a portal along with parameter values

Changes

created map in session for a stmt name -> stmt store
created new type - portal - to store a portal (statement name and list of parameters)
created a map of portals in session
upon receiving of parse message, parse and store the statement
upon receiving of bind message, store portal only if statement actually exists. no further validation happens here
added handling of describe message for statements only and return parameter description to the client. we'll later need to add row description as well.

It would be also nice to rebase the commits in this PR before merging to avoid duplicated messages (e.g " finished transaction implementation ", " fixes after merge with origin branch ").

As I said before, it would be nice to rebase the commits before merging the PR to remove duplicated messages and rearrange commit history.