Include helm chart option for installing jaeger specific services

The recent PR #5656 switched the backend from using zipkin to use jaeger, but only exposed the zipkin service for use by the internal Istio components.
This PR provides an option zipkin.jaeger.enabled (which will hopefully soon change chart name so tracing.jaeger.enabled) to enable the user to also install the jaeger specific services, which would allow a jaeger tracer (used from within services) to report tracing data in the jaeger native format.
There are three other changes:

Renaming app labels from zipkin to jaeger, as this reflects the use of jaeger and doesn't impact any usage of the zipkin service by Istio components
Use of the istio-tracing name, instead of zipkin - thought it would bring it in line with the other istio components - but am happy to change if not suitable - although think it should be jaeger rather than zipkin (apart from the service).
The service-jaeger.yaml currently contains a tracing service which provides access to the UI. This was just to demonstrate the concept - ideally this could be moved out of the conditional service-jaeger.yaml and used as the way to provide access to the tracing UI - rather than it being exposed as a port on the zipkin service.

Example of trace from two services that use the jaeger native format for reporting:

Example dashboard with the new istio-tracing names:

cc @douglas-reid @rshriram

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
Assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @objectiser. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

If you want to change the name of the chart, please do so now.  Chart name changes have an upgrade impact, and 0.8 is the first version where these addons are available in the helm template in working fashion.

/ok-to-test

@objectiser: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
beff7e758f3fb6b4a7cec9a6b4d0f0b0278f6b5e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
beff7e758f3fb6b4a7cec9a6b4d0f0b0278f6b5e
link
/test istio-unit-tests

prow/istio-presubmit.sh
beff7e758f3fb6b4a7cec9a6b4d0f0b0278f6b5e
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser in general, i'm fine with this approach. I think istio-tracing is a better name. The reason we didn't do this in #5656 was a concern around destabilizing the system.
With this change, do the proxy args need to be updated at all?  Don't we still have args like: --zipkinAddress zipkin.istio-system:9411 being passed to the proxies (and hardcoded in places like: https://github.com/istio/istio/blob/master/pilot/docker/envoy_policy.yaml.tmpl#L182) ?

@douglas-reid I don't think the proxy args need to change. The format being reported is zipkin, so the service endpoint should reflect that. If later other formats are supported, it then makes it more explicit.
Any thoughts on the other two questions: (1) is it ok to move the tracing service out to provide a separate UI service? and (2) how best to enable the additional jaeger specific services, using the current bool tracing.jaeger.enabled, as a value property e.g. tracing.provider = jaeger, or just enable the jaeger services by default?

@objectiser ah, I looked too quickly. I thought you were replacing the zipkin service, but rather we are adding new services and changing the app labels on the zipkin service.
I don't have any objections to making a new service explicitly for UI concerns. We went halfway on that in the previous PR.
First blush, I like the idea of tracing.provider = jaeger options, but I'm fine with using the existing bool for now and fleshing out the approach when the rest of the tracing config story becomes clearer.

@douglas-reid Ok thanks -updates applied, and have left the tracing.jaeger.enabled bool for now.

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
154f9928c34a08de43f34e94b7c86b439459c8e6
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
154f9928c34a08de43f34e94b7c86b439459c8e6
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
154f9928c34a08de43f34e94b7c86b439459c8e6
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-bookInfo

/test istio-pilot-e2e

/assign @costinm

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
154f9928c34a08de43f34e94b7c86b439459c8e6
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

My take: Use jaeger as default. For 0.8 only, add an alias zipkin service that points to the jaeger pod.
Fix the bootstrap.yaml.tmpl to point to istio-tracing instead of zipkin. Ignore the current args —zipkin cluster etc. they will be removed by 0.9.
Also fix the global mesh config api to change the name of zipkinService mesh global variable to istio-tracing.

@rshriram i think in general we are all in agreement. i'm leaning towards only attempting the follow-on mods of the various bootstraps and static envoy configs and mesh configs to immediately post-0.8. it sounds like that is also what you are suggesting? Or are you suggesting we be more aggressive in 0.8?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: objectiser
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests

/test istio-unit-tests

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5d83c10993937d4efad9275d6c0333a943cf4bd1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@douglas-reid @rshriram  Would be good to handle the config changes in a separate PR anyway - whether for inclusion in 0.8 or post 0.8. So I think the PR is ready to go -but let me know if other changes are required?
@sdake Just checking you are now ok with the PR?

@sdake Thanks. Would you be able to give this the /lgtm to trigger the merge?

We could do the config changes in some 0.8.x before final lts release


Replace old DEBUG macro with new LLVM_DEBUG

...using a sed command provided by Vedant:
$ find . -name \*.cpp -print -exec sed -i "" -E "s/ DEBUG\(/ LLVM_DEBUG(/g" {} \;

apple/swift-llvm#104
@swift-ci Please smoke test

DEBUG isn't gone yet, but if we switch to LLVM_DEBUG we'll stop breaking master-next. What do y'all think?

@jrose-apple This is the right approach. We should have done this some time ago to reduce the delta. Can we add something to the database to make sure no more sneak in?

Hm…I can't think of an easy way to do it within the build. Normally I would think of poisoning the identifier somehow, but there might be uses of DEBUG in the LLVM or Clang headers. Still, I tagged the people who use it most frequently, so hopefully that'll help?
…I suppose we could add a test that does a git grep?

@jrose-apple I think that might work. If that becomes too difficult, I imagine we could write a clang plugin or something like that maybe? It would require us to on the bots also check out clang-tools-extra or something like that maybe, but given that cmake always create compilation databases, this is something we could do.

Test turned out to be pretty easy, so I think we're good to go!
@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test macOS


Corrected date comparison for seconds/miliseconds

Comparing dates with different units, monthsStart is taken from a Date object which gives miliseconds, start_date_local_raw is in seconds.
This prevented 2nd (3rd, 4th..) pages of activities from being loaded and meant that monthly stats for users with more than 20 activities ( 1 page of results) or with mixed activity types did not see the full total of distance travelled for the month in the progress bars.

 Prepare Release 5.6.0

 Prepare Release 5.6.0

Thanks for this :)


Why are there EnvironmentVariables in the web.config in project Skoruba.IdentityServer4.Admin?

Question
I have set the ASPNETCORE_ENVIRONMENT variable system-wide on a server. And I was surprised that this was not used.
I found out that this is set to "Development" in the web.config. Is there a reason for that?
The other two environment variables also seem to be unnecessary in the web.config.
Relevant parts of the log file
https://github.com/sgebhardt/IdentityServer4.Admin/commit/566e610aedcd9ec54ee4ca5b62bf7789ae7648db

Hi
I think it's used for local execution during development but not used in production environment.
As application configurations are stored in appsettings...

I created #732 to remove these environment variables.

Not sure, I think it is some old default scaffolded web.config. Let me check it.

PR merged, thanks 👍


Migrate TomlFileConfigStore to @configu/integrations

Suggestion
Migrate the TomlFileConfigStore from its current setup to the new @configu/integrations module as part of the major restructuring. The goal is to move all third-party integrations, including stores, expressions, and libraries, to @configu/integrations.
Motivation
This migration is part of a larger effort to better organize and modularize the product. Moving the TomlFileConfigStore will align with the new structure, making the system cleaner and more maintainable.
Context
You can refer to the already migrated stores for guidance:
Migrated stores in integrations.
Base stores implementations from @configu/ts can be found here:
Base stores in TS.
The old node-based stores were previously in @configu/node:
Node stores.
The old browser-based stores were previously in @configu/browser:
Browser stores.

Hi @rannn505, Can you please assign this issue to me? I have raised a PR for this as well with a probable solution


Aflter upgrading all tabs are disappeared

After upgrading from 6.x to 7.2.4 I miss all tabs with my scripts =(
Linux Mint v19.3

It happened just once? Can you reproduce it again?

Sorry, I can not downgrade/upgrade (experiment with this). I did not do system snapshot before upgrading

still cannot reproduce an issue.
If it reproduces for you again during upgrade - please reopen an issue


Problem in Advance-sorting is solved

Check List (Check all the applicable boxes)

[ ✔] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[✔ ] I have updated the documentation accordingly.
[✔ ] All new and existing tests passed.
[✔ ] This PR does not contain plagiarized content.
[✔ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers
Now After Clicking On advance sorting it will sucsessully redirecting it to the advance-sorting page

#163Closes

@Tanmay-Joshi73 you have to write x in [] like [x] to mark it done.
Also give space after issue number like this close #163


Peer to peer review 4th nov, 2021

Hi Cris, 👋 👋
Great job so far, you accomplished to make responsive the 5 template, which at first glance it looks pretty difficult to render. So you have done it great to this point. 🏆
What I am going to suggest is just my opinion from my point of view, some advice that could come in handy in the future.

Here I suggest you to put all  elements inside an unnumbered list, this will help you to organize your code. Like the example code below:

I would help you in the responsive web design of your page, to avoid using px for constraining your dimension, you could use relative dimensions like vw, vh, %, rem, etc. You could find more about this in this link.
In the following the code, it will help you to speed up the code writing if you use functions like "repeat" to for example in this case, generate the columns:

Continue with your great job Chris 👋 💪

Hi Cris,
I was going to remark this part, that @williamrolando88 have also noticed:

You have to remember using that standard, when you have some elements like that is better use an  tag in order to mantain that guidance, is a good practice.

https://github.com/CRClothier/My-Portfolio-Website/blob/c182008404f4185e82051289b64889b570c793fe/index.html#L28-L33

I think is a better idea, that for your template you use at the end, outside the main tag, you could create a  tag in order to put in use that good web developing practice.

https://github.com/CRClothier/My-Portfolio-Website/blob/c182008404f4185e82051289b64889b570c793fe/index.html#L186-L193
Keep doing the great job that you are doing until now. :)


PushNotification is undefined

Expected Behaviour
PushNotification should be an object.
It used to work fine (last time I used it was ~2 weeks ago)
Actual Behaviour
PushNotification is undefined.
Reproduce Scenario (including but not limited to)
Steps to Reproduce
cordova plugin add phonegap-plugin-push
...
cordova prepare
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
λ cordova plugins
cordova-plugin-compat 1.2.0 "Compat"
cordova-plugin-console 1.0.7 "Console"
cordova-plugin-crosswalk-webview 2.3.0 "Crosswalk WebView Engine"
cordova-plugin-device 1.1.7 "Device"
cordova-plugin-dialogs 1.3.4 "Notification"
cordova-plugin-fcm 2.1.2 "FCMPlugin"
cordova-plugin-inappbrowser 1.7.2 "InAppBrowser"
cordova-plugin-statusbar 1.0.1 "StatusBar"
cordova-plugin-whitelist 1.2.2 "Whitelist"
phonegap-plugin-barcodescanner 6.0.8 "BarcodeScanner"
phonegap-plugin-push 2.1.0 "PushPlugin"

config.xml:
    <platform name="android">
        <preference name="android-minSdkVersion" value="16" />
        ...
        <resource-file src="google-services.json" target="google-services.json" />
    </platform>
    ...
    <plugin name="phonegap-plugin-push" spec="^2.1.0">
        <variable name="FCM_VERSION" value="11.0.1" />
        <variable name="SENDER_ID" value="1:.............:android:............................" />
    </plugin>

I've included a google-services.json file.
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Samsung S7
Cordova CLI version and cordova platform version
λ cordova -v
7.1.0

λ cordova platform version android
Installed platforms:
  android 6.3.0
  browser 5.0.1
Available platforms:
  blackberry10 ~3.8.0 (deprecated)
  ios ~4.5.1
  osx ~4.0.1
  ubuntu ~4.3.4 (deprecated)
  webos ~3.7.0
  windows ~5.0.0
  www ^3.12.0

Plugin version
λ cordova plugin version | FINDSTR phonegap-plugin-push
phonegap-plugin-push 2.1.0 "PushPlugin"

Sample Push Data Payload
n/a
Sample Code that illustrates the problem
document.addEventListener('deviceready', () => {
    alert(typeof PushNotification); // 'undefined'
});

Logs taken while reproducing problem
no logs matching "Push":
λ adb logcat | FINDSTR Push

Same problem here , need solution

@k-yle well without seeing logs it's hard to diagnose but in this case the logs would be when the app is built.
However, you should probably look at removing:
cordova-plugin-crosswalk-webview 2.3.0 "Crosswalk WebView Engine"
cordova-plugin-fcm 2.1.2 "FCMPlugin"

from your app. Crosswalk because it's not needed post Android 5.0 and the FCM one because it might conflict with this one.

@macdonst im not using crosswalk and fcm tok . But pusnotif is undefined :(

@neverflatz yeah, you need to give me more info.

@k-yle
<?xml version='1.0' encoding='utf-8'?>
<widget id="XXXX" version="2.3.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <name>XXXX</name>
    <description>
       XXX
    </description>
    <author<EMAIL_ADDRESS>href="http://cordova.io">
        XXXX
    </author>
    <content src="index.html" />
    <access origin="*" />
    <allow-intent href="http://*/*" />
    <allow-intent href="https://*/*" />
    <allow-intent href="tel:*" />
    <allow-intent href="sms:*" />
    <allow-intent href="mailto:*" />
    <allow-intent href="geo:*" />
    <preference name='phonegap-version' value='cli-7.0.1' />
    <preference name='pgb-builder-version' value='2' />
    <platform name="android">
        <preference name="android-minSdkVersion" value="16" />
        <allow-intent href="market:*" />
        **<resource-file src="google-services.json" target="google-services.json" />**
    </platform>
    <platform name="ios">
        <allow-intent href="itms:*" />
        <allow-intent href="itms-apps:*" />
        <preference name="BackupWebStorage" value="none" />
        **<resource-file src="GoogleService-Info.plist" />**
    </platform>

    <icon src="img/icon2.png" />
    <icon src="img/drawable-ldpi/icon2.png" platform="android" qualifier="ldpi" />
    <icon src="img/drawable-mdpi/icon2.png" platform="android" qualifier="mdpi" />
    <icon src="img/drawable-hdpi/icon2.png" platform="android" qualifier="hdpi" />
    <icon src="img/drawable-xhdpi/icon2.png" platform="android" qualifier="xhdpi" />
    <icon src="img/drawable-xxhdpi/icon2.png" platform="android" qualifier="xxhdpi" />
    <icon src="img/drawable-xxxhdpi/icon2.png" platform="android" qualifier="xxxhdpi" />

    <preference name="DisallowOverscroll" value="true" />
    <plugin name="cordova-plugin-whitelist" spec="~1.2.0" />
    <plugin name="cordova-plugin-console" spec="~1.0.1" />
    <plugin name="cordova-plugin-statusbar" spec="~1.0.1" />
    <plugin name="cordova-plugin-camera" spec="~2.3.1" />
    <plugin name="cordova-sqlite-storage"  spec="~1.2.1"/>
    <plugin name="cordova-plugin-geolocation" spec="~2.4.1" />
    <preference name="android-build-tool" value="gradle" />
    **<plugin name="phonegap-plugin-push" spec="~2.1.0" />**
    <plugin name="cordova-plugin-network-information" spec="~1.3.1" />
    <plugin name="cordova-plugin-file-transfer" spec="~1.6.1" />
    <plugin name="cordova-plugin-inappbrowser" spec="~1.7.1" />
    <plugin name="cordova-plugin-file" spec="~4.3.1" />
    <plugin name="cordova-plugin-mauron85-background-geolocation" source="npm" spec="~2.2.5">
        <variable name="GOOGLE_PLAY_SERVICES_VERSION" value="11.0.1" />
    </plugin>
</widget>

@macdonst  its works like a charm when i remove mauron bacground location ...
its like conflict with google play service version , any solution?

@neverflatz right, so the error must show up when you build the app. What do those logs look like?

@macdonst
`* Where:
Build file '/project/build.gradle' line: 258

What went wrong:
A problem occurred evaluating root project 'project'.

Could not get unknown property 'GOOGLE_PLAY_SERVICES_VERSION' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Total time: 1.459 secs
Error: /project/gradlew: Command failed with exit code 1 Error output:
FAILURE: Build failed with an exception.

Where:
Build file '/project/build.gradle' line: 258

What went wrong:
A problem occurred evaluating root project 'project'.

Could not get unknown property 'GOOGLE_PLAY_SERVICES_VERSION' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.
`

@macdonst I removed cordova-plugin-crosswalk-webview and cordova-plugin-fcm as you suggested, and everything works again.
Thank you very much!

@k-yle  congrats, mine still conflict with mauron-background geoolocation .. :(

@macdonst  whats this push v2.0.0 google play services it is 11.0.1 ??
This is mauron says For compatibility with other plugins you may also set specific google play version. Following example will lock google play services to version 11.0.1 for compatibility with phonegap-plugin-push. Note: Always consult documentation of other plugins to figure out correct GOOGLE_PLAY_SERVICES_VERSION.
i tried it but no luck

@k-yle np, I'm going to close this issue then.
@neverflatz can you open a new issue that specifically calls out the incompatibility between the two plugins? Please fill out the full issue template.


Strange error with eslint

I just installed polished, and ❤  it (just like styled-components)!
There is just one little bug (?) that bothers me..
I use eslint for linting, and it keeps saying me that I have 2 errors for each import polished from 'polished':
/polished-test/src/Component.js
  2:32  error  Unable to resolve path to module 'polished'  import/no-unresolved
  2:32  error  Missing file extension for "polished"        import/extensions

My guess is that in the npm name there is an invisible character..
Here's how to reproduce it:
git clone https://github.com/EnoahNetzach/polished-test
cd polished-test
yarn
yarn eslint

My guess is that in the npm name there is an invisible character..

Hah that would be super smart, but no it's literally just "polished". I have no idea what's going on here! 🤷♂

Marking this as an unconfirmed bug because I suspect the bug lies with eslint-plugin-import but I don't know for sure.

Modifying the eslint resolver, forcing it to console.log the directory it looks in for the package.json (basically here), I get spooky results:
 /polished-test/node_modules/polished/package.json
^ there is a hidden char here

Opened here: https://github.com/benmosher/eslint-plugin-import/issues/782

@mxstbr I found the elephant in the room 😛

As a footnote, copying output from WebStorm's console can append a zwnj char at the beginning, and that was what I was seeing.

I know this is closed, but the comment the ESLint issue 782 was entirely unhelpful and simple says...

It was a trivial error in the polished package.json, nothing to see here.

will this be fixed?


Always calculate auxiliary variables after steps

Update Gauges to use tLast

Shippable noticed the tests failing on this build.  I'm digging in to see what went wrong.

Tests are now passing on my machine.

Passing on OS X.9.5 and Ubuntu 14.04.1 LTS.


Fix bug where images on the cardlink get stretched when using Minimal Theme Settings

As in the title.
This addresses #49.

Thanks for PR!


Have a way to select provision instances based on CPU type (AMD vs. Intel)

Tell us about your request
Some of our workloads perform very poorly on AMD CPUs. We would love a way to exclude all AMD CPU instances from provisioning. Example:
- key: karpenter.k8s.aws/cpu-brand
      operator: NotIn
      values: [amd]

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Today, we have to do something like this and list all the instance families.
- key: karpenter.k8s.aws/instance-family
      operator: NotIn
      values: [c6a, m6a, r6a, c5a, m5a, r5a, c6ad, m6ad, r6ad, m5ad, r5ad, r5ad]

Are you currently working around this issue?
Above.
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

I don't know of a way either 😞 I was just thinking of using the instance type and looking for the a somewhere before the ..

Oh! Got it. I didn't realize there was consistent naming across the instance types which always contained an "a" at the end if it's an AMD cpu type. That's helpful.
For this one, we're in a bit of flux right now due to a lot of other changes that are happening in the project so we're trying to reduce API changes right now until we get past #2964 and #2944. With that in mind, we'll keep tracking this issue but expanding the label selector set isn't something that's going to get added immediately.
It seems like you have a reasonable workaround for the time being.

Makes sense! Yes, I'm able to workaround it. Just wanted to suggest this usability improvement.
I actually think we can generalize this further. Another very similar issue I have is automatically selecting the high-network throughput instances and that can be detected by looking for the n suffix before the dot. A similar thing can be said for d with local storage, z for high frequency CPUs, etc.

It looks like AWS API do have an option to add CPU manufacturer requirement.
Maybe it can implemented like GPU manufacturer requirement?

It would be definitely useful! Otherwise we need to track new ec2 type releases to add them to the list :)

I took a look a this and thought I could perhaps attempt to implement it.

Oh! Got it. I didn't realize there was consistent naming across the instance types which always contained an "a" at the end if it's an AMD cpu type. That's helpful.

I notice that the newer P5 instance types don't have the a at the end but have AMD EPYC CPU's. Would it be enough to look at the ProcessorInfo.SupportedArchitectures and infer the brands that could satisfy the requirement given an instances' supported architecture? Something like
	// CPU Manufacturer
	if info.ProcessorInfo != nil && len(info.ProcessorInfo.SupportedArchitectures) == 1 {
		arch := aws.StringValue(info.ProcessorInfo.SupportedArchitectures[0])
		switch arch {
		case "x86_64":
			requirements.Get(v1alpha1.LabelInstanceCPUManufacturer).Insert(
				fmt.Sprint(v1alpha1.AMDCPUManufacturer),
				fmt.Sprint(v1alpha1.AWSCPUManufacturer),
				fmt.Sprint(v1alpha1.IntelCPUManufacturer),
			)
		case "arm64":
			requirements.Get(v1alpha1.LabelInstanceCPUManufacturer).Insert(
				fmt.Sprint(v1alpha1.AWSCPUManufacturer),
			)
		}
	}

There are however certain instance types that support 32-bit architecture that do not satisfy the above constraint. I'd be happy to give this a go if anyone has any additional ways in which the brand of the CPU can be set.


daemon: Remove unnecessary and unsafe arg append for init.sh

The append was adding Device beyond initArgMax which was not used by init.sh.

This change is

test-me-please

Coverage decreased (-0.005%) to 42.097% when pulling dfcc6bb827f687477f6b3a9b6c25ad303a0b71f8 on pr/brb/r-arg-append-initsh into 79b4eba1b2cf0b471699c1c53712a8e7a982db4c on master.


CSS Renderer

Hi, I was wondering if it's possible to combine HTML and THREE elements, maybe using CSS3DRenderer. What may be the best practice?

You can of course combine the two, Canvas is a dom element and renders next to other dom elements. Other than that threejs has some means to project html onto planes as a texture or something, but haven't done this - but no reason it shouldn't work. Last but not least, if you want to exchange the renderer, that's also possible. https://github.com/drcmda/react-three-fiber/tree/2.0#switching-the-default-renderer


Don't store an HMAC key for longer than we need

The HMAC_CTX structure stores the original key in case the ctx is reused
without changing the key.
However, HMAC_Init_ex() checks its parameters such that the only code path
where the stored key is ever used is in the case where HMAC_Init_ex is
called with a NULL key and an explicit md is provided which is the same as
the md that was provided previously. But in that case we can actually reuse
the pre-digested key that we calculated last time, so we can refactor the
code not to use the stored key at all.
With that refactor done it is no longer necessary to store the key in the
ctx at all. This means that long running ctx's will not keep the key in
memory for any longer than required. Note though that the digested key
is still kept in memory for the duration of the life of the ctx.
Fixes #10743
Note: It is debatable whether this should come under the "bug" rules or not, and therefore be eligible for backport to 1.1.1. Since it provides no user visible features, and is a security hardening measure I have flagged it for 1.1.1.

A very nice fix. Thank you!

Pushed to master. The 1.1.1 version apparently needs a slight adjustment. I'll raise a new PR for that.


Check that l_bfgs_b output doesn't depend on convergence parameters

Here's the test I want:

Choose a handful of typical pixels.
fit with current defaults.
loosen pgtol by a factor of 10 and re-fit.  Do the optimal parameters change by an absolute change of more than 1e-7?  If so, we need to tighten pgtol.
return pgtol to normal and loosen factr by a factor of 10 and re-fit.  Do the optimal parameters change by an absolute change of more than 1e-7?  If so, we need to tighten factr

This PR can be closed when both of these tests pass.
Bonus points:  You can also loosen these parameters; we really want them as loose as possible such that the above tests pass.

wontfix


rate limit for transaction

Is there rate limit for create transaction per minute or IP in mainnet?

It shouldn't be. But there is a limit of 5 on number of connections to the LCD. I'm not sure how that is calculated. Would appreciate if @Vritra4 clarify on that.
Is it 5 requests on any API per second, or 5 APIs requested per second?

@SheydaAshoorian @Aureliano90
yes there's a rate limit for public LCDs. 400 requests per 10seconds i guess. i'm not sure i'm not related with public LCDs.

@SheydaAshoorian @Aureliano90 yes there's a rate limit for public LCDs. 400 requests per 10seconds i guess. i'm not sure i'm not related with public LCDs. if you want more requests, you can run your own node and send requests to that.

Thanks. I often encounter this error.
Status 500 - max_subscriptions_per_client 5 reached

I don't think I ever reach 400 requests per 10 seconds. Also I'm not sure what is counted as one subscription. I only created one LCD instance.

@Aureliano90 oh that's the other problem. :)
400/10 is about load balancing for public nodes and max_subscription_per_client is from our (public) core node.
# Maximum number of unique queries a given client can /subscribe to
# If you're using GRPC (or Local RPC client) and /broadcast_tx_commit, set to
# the estimated # maximum number of broadcast_tx_commit calls per block.


[volk] Enable using vulkan-headers package instead of vulkan package

Currently volk requires the vulkan package, which in turn requires Vulkan SDK to be installed on the development machine. This partly defeats the point of dynamic loaders, which allows building the project without anything except the Vulkan headers. It should be possible to use the vcpkg version of Volk without having to install the Vulkan SDK and instead only require the Vulkan headers.
There are at least two possible solutions:

Replace vulkan with vulkan-headers as a dependency.
Using vcpkg.json "features" field, allow choosing between vulkan and vulkan-headers as a dependency (defaulting in the old behaviour).

With the "features" approach, the headers-only version could then be used in a project with the following vcpkg.json:
{
  "dependencies": [{
    "name": "volk",
    "default-features": false,
    "features": ["vulkan-headers"]
  }]
}

Thanks for posting this issue. For your two suggestions,

Replace vulkan with vulkan-headers as a dependency.

There are information in [VOLK_SOURCE_PATH]/README.md, so If use wat use volk, he need install vulkan. We cannot use vulkan-headers instead of vulkan as a dependency.

## Basic usage

To use volk, you have to include `volk.h` instead of `vulkan/vulkan.h`; this is necessary to use function definitions from volk.

If some files in your application include `vulkan/vulkan.h` and don't include `volk.h`, this can result in symbol conflicts; consider defining `VK_NO_PROTOTYPES` when compiling code that uses Vulkan to make sure this doesn't happen. It's also important to make sure that `vulkan-1` is not linked into the application, as this results in symbol name conflicts as well.

To initialize volk, call this function first:

```c++
VkResult volkInitialize();

This will attempt to load Vulkan loader from the system; if this function returns `VK_SUCCESS` you can proceed to create Vulkan instance.
If this function fails, this means Vulkan loader isn't installed on your system.

Using vcpkg.json "features" field, allow choosing between vulkan and vulkan-headers as a dependency (defaulting in the old behaviour).

If we add vulkan and vulkan-headers as features to volk, and set vulkan to default-features, you cannot only build volk with feature vulkan-headers. Due to vulkan is a default feature, so build volk[vulkan-headers] as your example will install volk[core,vulkan,vulkan-headers]. This is by design. So this way is is not feasible.

There are information in [VOLK_SOURCE_PATH]/README.md, so If use wat use volk, he need install vulkan

Can you point to the exact line/information that says this? Volk simply includes the <vulkan/vulkan.h> header, which is also provided by vulkan-headers. There should be no need for any other component of the Vulkan SDK. In fact, part of the appeal of dynamic loading is that you aren't limited in any ways by the Vulkan support of your build platform, only the target platform.

If we add vulkan and vulkan-headers as features to volk, and set vulkan to default-features, you cannot only build volk with feature vulkan-headers.

At least with manifest mode this is possible by using default-features: false as shown in my example. It also seems that defining volk[core, vulkan-headers] removes all default features. More information here: https://vcpkg.readthedocs.io/en/latest/users/selecting-library-features/

There are the following codes in [VOLK_SOURCE_PATH]/CMakeLists.txt:
if(VOLK_PULL_IN_VULKAN)
  # If CMake has the FindVulkan module and it works, use it.
  # Otherwise try the environment variable.
  find_package(Vulkan QUIET)
  if(TARGET Vulkan::Vulkan)
      message(" Vulkan as target")
    target_link_libraries(volk PUBLIC Vulkan::Vulkan)
    target_link_libraries(volk_headers INTERFACE Vulkan::Vulkan)
  elseif(DEFINED ENV{VULKAN_SDK})
      message(" Vulkan as path")
    target_include_directories(volk PUBLIC "$ENV{VULKAN_SDK}/include")
    target_include_directories(volk_headers INTERFACE "$ENV{VULKAN_SDK}/include")
  endif()
endif()

Now install volk use Vulkan as target. I don't know if using Vulkan as path will affect the function of volk.

It seems that for header-only Volk you would need to set at least VOLK_PULL_IN_VULKAN=OFF and VOLK_HEADERS_ONLY=ON.

Just noting that proposed "feature" -based approach doesn't fit into vcpkg requirements due to a functionality misuse. Unfortunately, features aren't meant to specify alternatives, it's for additive functionality only, so the updated port might not be accepted into public vcpkg repository...

This has been resolved with PR https://github.com/microsoft/vcpkg/pull/27747


Resources references for AMP controller

Is your feature request related to a problem?
Pieces of the AMP controller can have resources that it may need to reference. For example, an AMP Workspace can be referenced in RuleGroupsNamespace
Describe the solution you'd like
Here are a list of refs that can be added in each of the CRD specs:
AlertManagerDefinition

spec.workspaceID from workspace.status.workspaceID

RuleGroupsNamespace

spec.workspaceID from workspace.status.workspaceID

/assign

Resolved in https://github.com/aws-controllers-k8s/prometheusservice-controller/pull/39
/close


Proxy is blocking SSE(Server side events)

Problem Description
Whenever there is a communication between browser and server over SSE it is blocked by mitmproxy
Steps to reproduce the behavior:

Make sure that you have working system with SSE
Include mitmproxy in the connection (just start ./mitmdump and configure your browser to use localhost:8080 proxy )
SSE stops working
error: "::1:48536: ProtocolException("Error in HTTP connection: Http2ZombieException('Connection or stream already dead:<PHONE_NUMBER>.551617, False')")

I tested same scenario with Fiddler and it is working fine
System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 6.0.2 binary
Python:    3.9.1
OpenSSL:   OpenSSL 1.1.1i  8 Dec 2020
Platform:  Linux-4.4.0-148-generic-x86_64-with-glibc2.23
Same problem exists with version 5.5.1

Thanks for reporting!
Can you try with this script?
def responseheaders(flow):
    flow.response.stream = flow.response.headers.get('content-type', '').startswith('text/event-stream');

mitmdump --scripts sse.py

SSE uses chunked response and mitmproxy will buffer it until it's closed. But that defeats the purpose of SSE. I've tested this with http://demo.howopensource.com/sse/
But that should be unrelated to the ProtocolException you're seeing. Does that disappear with the latest master? Builds can be downloaded here  https://mitmproxy.org/downloads/#branches/master/

I'm marking this as a feature request, maybe we should stream text/event-stream by default? @mhils

I would support the suggestion of @Prinzhorn, to stream text/event-stream by default. Is there a reason not to do this? :)

Streamed bodies are currently not captured, that would definitely need to change if we want to enable it by default.

But currently they are blocked AND not captured, right? Therefore in my case I had to spend quite some time debugging why a certain functionality wasn't working with mitmproxy enabled. Wouldn't it be a step forward to have them unblocked until it is possible to capture them?

Unfortunately no, because some folks rely on the fact that mitmproxy captures everything that's going on between client and server (think of forensic use cases). Discovering after the fact that some traffic is missing would be disastrous.
I've opened #5249, which now at least prominently notifies the user.
For now, I recommend @Prinzhorn's workaround in https://github.com/mitmproxy/mitmproxy/issues/4469#issuecomment-786508647.


If the nodes are constantly reconnecting then you MUST have either 2 instances or more than one config node.

If the nodes are constantly reconnecting then you MUST have either 2 instances or more than one config node.
You can check the config nodes by click on the menu in the top right hand corner and selecting "Configuration nodes". You should only have ONE alexa-home-conf instance that should be shared by all device nodes.
Originally posted by @hardillb in https://github.com/hardillb/node-red-contrib-alexa-home-skill/issues/111#issuecomment-826099002

I've closed this already


[TOOLS] Building process for val tools was removed from default build

If you want to build tools, you should add --tools=on for build_mfx.pl

@adydychk could you please add -DENABLE_TOOLS=ON to CI?

Ok, but it needs to make some manual checks with this parameter but without this PR.

@onabiull CI updated. Updated all builders except android and clang builders.


Support for SSO and OAuth2.0

Our service needs to provide endpoints for single sign-on login and OAuth2 token generation and validation.

With the addition of JWT tokens for OAuth2 and opening the check_token and token_key endpoints. I suggest this can be closed.

@dennyverbeeck Where do i see the above end-points? How does this resolve single-sign-on?

Sorry forgot to reference #24. The process for enabling them is described in the spring security oauth2 docs: http://projects.spring.io/spring-security-oauth/docs/oauth2.html. And it resolves SSO since any app now can check the validity of a user-supplied token. The app can check it by validating the signature, but can also check it via the check_token endpoint, which would give it a chance to check if the token was revoked ahead of it's expiry time. The endpoints are still protected by HTTP Basic authentication, where a client supplies its client_id and client_secret.
You can check the endpoints with curl:
$ curl localhost:8080/oauth/token_key -u ManagementPortalapp:my-secret-token-to-change-in-production
{
  "alg" : "HMACSHA256",
  "value" : "123"
}

$ curl localhost:8080/oauth/check_token -u ManagementPortalapp:my-secret-token-to-change-in-production -d "token=$token"   {
  "aud" : [ "res_ManagementPortal" ],
  "devices" : [ "a" ],
  "user_name" : "admin",
  "scope" : [ "read", "write" ],
  "exp" :<PHONE_NUMBER>,
  "authorities" : [ "ROLE_SYS_ADMIN", "ROLE_USER" ],
  "jti" : "9551f640-9cc5-4a3f-9760-48cf9099df82",
  "client_id" : "ManagementPortalapp"
}


[FEATURE]: Added Simple Chinese language (zh-CN).

I have added Simple Chinese language (zh-CN).
It is very nice that you developed this app.

Hello @joytou,
I update the translation file and there are new messages to translate. If possible, could you translate them so that I can publish the app?
Thank you.

Ok, no problem! It is my pleasure.
------ 原始邮件 ------
<EMAIL_ADDRESS>Date:2020年6月15日(星期一) 凌晨0:44
<EMAIL_ADDRESS>Cc:"Joytou"<1540294142<EMAIL_ADDRESS>Subject:Re: [tiagohm/restler] [FEATURE]: Added Simple Chinese language (zh-CN). (#97)
Hello @joytou,
I update the translation file and there are new messages to translate. If possible, could you translate them so that I can publish the app?
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


How can I use this library in windows?

Hi, I want to use this library in Windows. How can I install it?

Hi, we don't provide support for Windows, but maybe you can use WSL to simulate a Linux environment?

I am using a stand alone computer so I can try.
Do you know how can I install the dependencies of ceres-solver and eigen on the stand alone?

If you use WSL, you can simply follow the instructions of both libraries, this should work.

Ok I will try thanks you

can you work the code in windows? use wsl? I don`t know how to use wsl ,so i am trying to use windows

Ok I will try thanks you


Create a page for GitHub repository management in our Terraform IAC

type: new page
status: pending
location: pending
issues

Page GitHub Repositories: in 1.9 we'll need a new page that describes repo management in our terraform IAC

How to do this listed at kubefirst.io/blog/k3d/#add-a-new-repository

New link is https://blog.kubefirst.io/k3d/#add-a-new-repository
Also, add information about the main advantages of managing them with GitOps:

The configurations of those repositories are done within the gitops repository, so you can easily configured access with GitOps.
Group access given to a newly added repository to the gitops repository are automatically given proper access. No need to have everyone asking you to give them access: if there are in a group that you configured, they will automatically have the permissions you want them to have.

You can do both of those within the GitHub or GitLab interface, but it brings the GitOps benefits of history, PRs approval... and no need to duplicate access control from those interface and for everything else kubefirst.

@fharper  Looks like this was long ago resolved 🎉

@konstructcarrie not sure who added this, and I can't find it, where did you see it in the docs?

@konstructcarrie not sure who added this, and I can't find it, where did you see it in the docs?

Ahh it looks like those are all blog links, I guess not


Migrate Comments

Existing Implementation

component inclusion
existing component
disqus instructions to install for jekyll
disqus universal code

Info for utterances:

https://dev.to/antopiras89/add-comments-to-your-static-blog-with-utterances-3jao
https://github.com/apps/utterances
https://utteranc.es/
https://jamstack-comments.netlify.app/about/
https://github.com/philhawksworth/jamstack-comments-engine/tree/master/src/site

Temporarily, comments from disqus have been enabled. Now for the export.


cudnn v9.3.0

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

rerendering is already done locally, and reflected in the changes.

@conda-forge-admin, please rerender

Ready for review.

going back to using zlib version from global pinning (since 1 means 1.* which by default resolves to latest and greatest)
otherwise, routine bump in version and source tarballs


Doc issue with :joins

Hi,
In your example on joins :

(db/q conn '[:select todo/* person/*
:from todo
:joins person/todos])

We get the error

PSQLException ERROR: table name "todo" specified more than once  org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse (QueryExecutorImpl.java:2440)

Don't you think it should be simply

(db/q conn '[:select todo/* person/*
:joins person/todos])

?
In addition, it could be useful to have a way to get the real SQL query generated underneath. Would it be possible?
In the same vein, how do you use multiple joins?
E.g.

(def todos-users [{:db/col :person/name :db/type "text" :db/unique? true :db/nil? false}
{:db/col :item/name :db/type "text" :db/unique? true :db/nil? false}
{:db/rel :item/todos :db/type :many :db/ref :todo/item}
{:db/rel :todo/item :db/type :one :db/ref :item/id}
{:db/rel :person/todos :db/type :many :db/ref :todo/person}
{:db/rel :todo/person :db/type :one :db/ref :person/id}
{:db/col :todo/name :db/type "text"}
{:db/col :todo/done :db/type "boolean" :db/default false :db/nil? false}])

(db/migrate conn todos-users)

(db/q conn '[:select todo/* :joins person/todos item/todos])
PSQLException ERROR: table name "todo" specified more than once  org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse (QueryExecutorImpl.java:2440)

Thanks

To the first question: yes it should be :joins without the :from
(db/q conn '[:select todo/* person/*
             :joins person/todos])

To the second question, yes! I pushed a version 1.2.0 that has a new lighthouse.core/sql fn that takes a connection and a vector and outputs a sql vector like so:
(require '[:lighthouse.core :as db])

(def conn (db/connect "jdbc:sqlite:test.db"))

(db/sql conn [:select todo/id]) ; => ["select todo.id as todo$id from todo"]

To the last question, unfortunately multiple joins to the same table (todo/item and todo/person) don't work currently :(

Great! Thanks for your response.


Coverage first tests

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment
Thanks for integrating Codecov - We've got you covered :open_umbrella:

Merge on main coverage/Codecov


Add within group clause support for aggregate function builder

closes #781

@igalklebanov, I want to consult about the API of the future within group () functionality.
I see the following possible varaints:

Extended - fn.agg('mode').withinGroup(wg => wg.orderBy('field')):
+ : looks like SQL
- : too verbose; need to create separate WithingGroupBuilder
Simplified - fn.agg('mode').withinGroup('field'), because  within group ()  use only order by expression
Also I can try to implement both variants in one method

@igalklebanov, I want to consult about the API of the future within group () functionality. I see the following possible varaints:

Extended - fn.agg('mode').withinGroup(wg => wg.orderBy('field')):
+ : looks like SQL
- : too verbose; need to create separate WithingGroupBuilder
Simplified - fn.agg('mode').withinGroup('field'), because  within group ()  use only order by expression
Also I can try to implement both variants in one method

Hey 👋
We had a similar situation with filter (where ...). All current SQL specs only support where clause there, so we decided, for simplicity to just go with filterWhere(...).
So what I'd go with, for now, is withinGroupOrderBy(...). WDYT?

Hey 👋
We had a similar situation with filter (where ...). All current SQL specs only support where clause there, so we decided, for simplicity, to just go with filterWhere(...).
So I'd go with withinGroupOrderBy(...) for now. WDYT?

OK! We think in the same direction)
https://github.com/kysely-org/kysely/pull/1024/commits/c81d766336bb8bee0d276894621833d3df52b8f6#diff-0e4fd806a08c99c93c0331a3d0e75d4c726e4face483d2e21a9febe03e944593R167


Different escape bases by level.

Self explanatory.

Done. Just export the new layers in the Pieces folder with the shorthand as a prefix.


ResourceGuid addition

Adding resourceguid property as part of network top level resources.

Can one of the admins verify this patch?

Hi @amku, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (amku). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci add to whitelist


Error Importing - dadapt_adamw; 'type' object is not subscriptable

I was trying to import and then came across this error. I'm not sure how to address this and any help would be appreciated.
import os
import numpy as np
import pandas as pd
import scipy
import anndata
import scanpy as sc
import pybiomart
import scvi
import torch
import random
import seaborn as sns

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In[24], line 8
      6 import scanpy as sc
      7 import pybiomart
----> 8 import scvi
      9 import torch
     10 import random

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/__init__.py:10
      7 from ._settings import settings
      9 # this import needs to come after prior imports to prevent circular import
---> 10 from . import autotune, data, model, external, utils
     12 from importlib.metadata import version
     14 package_name = "scvi-tools"

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/autotune/__init__.py:1
----> 1 from ._manager import TuneAnalysis, TunerManager
      2 from ._tuner import ModelTuner
      3 from ._types import Tunable, TunableMixin

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/autotune/_manager.py:22
     20 from scvi._types import AnnOrMuData
     21 from scvi.data._constants import _SETUP_ARGS_KEY, _SETUP_METHOD_NAME
---> 22 from scvi.model.base import BaseModelClass
     23 from scvi.utils import InvalidParameterError
     25 from ._defaults import COLORS, COLUMN_KWARGS, DEFAULTS, TUNABLE_TYPES

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/model/__init__.py:2
      1 from . import utils
----> 2 from ._amortizedlda import AmortizedLDA
      3 from ._autozi import AUTOZI
      4 from ._condscvi import CondSCVI

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/model/_amortizedlda.py:14
     12 from scvi.data import AnnDataManager
     13 from scvi.data.fields import LayerField
---> 14 from scvi.module import AmortizedLDAPyroModule
     15 from scvi.utils import setup_anndata_dsp
     17 from .base import BaseModelClass, PyroSviTrainMixin

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/module/__init__.py:1
----> 1 from ._amortizedlda import AmortizedLDAPyroModule
      2 from ._autozivae import AutoZIVAE
      3 from ._classifier import Classifier

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/module/_amortizedlda.py:14
     12 from scvi._constants import REGISTRY_KEYS
     13 from scvi.autotune._types import Tunable
---> 14 from scvi.module.base import PyroBaseModuleClass, auto_move_data
     15 from scvi.nn import Encoder
     17 _AMORTIZED_LDA_PYRO_MODULE_NAME = "amortized_lda"

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/module/base/__init__.py:1
----> 1 from ._base_module import (
      2     BaseMinifiedModeModuleClass,
      3     BaseModuleClass,
      4     JaxBaseModuleClass,
      5     LossOutput,
      6     PyroBaseModuleClass,
      7     TrainStateWithState,
      8 )
      9 from ._decorators import auto_move_data, flax_configure
     11 __all__ = [
     12     "BaseModuleClass",
     13     "LossOutput",
   (...)
     19     "BaseMinifiedModeModuleClass",
     20 ]

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/scvi/module/base/_base_module.py:15
     13 import torch
     14 from flax.core import FrozenDict
---> 15 from flax.training import train_state
     16 from jax import random
     17 from jaxlib.xla_extension import Device

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/flax/training/train_state.py:19
     17 from flax import core
     18 from flax import struct
---> 19 import optax
     22 class TrainState(struct.PyTreeNode):
     23   """Simple train state for the common case with a single Optax optimizer.
     24
     25   Synopsis::
   (...)
     50     opt_state: The state for `tx`.
     51   """

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/optax/__init__.py:17
      1 # Copyright 2019 DeepMind Technologies Limited. All Rights Reserved.
      2 #
      3 # Licensed under the Apache License, Version 2.0 (the "License");
   (...)
     13 # limitations under the License.
     14 # ==============================================================================
     15 """Optax: composable gradient processing and optimization, in JAX."""
---> 17 from optax import contrib
     18 from optax import losses
     19 from optax import monte_carlo

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/optax/contrib/__init__.py:21
     19 from optax.contrib.complex_valued import split_real_and_imaginary
     20 from optax.contrib.complex_valued import SplitRealAndImaginaryState
---> 21 from optax.contrib.dadapt_adamw import dadapt_adamw
     22 from optax.contrib.dadapt_adamw import DAdaptAdamWState
     23 from optax.contrib.mechanic import MechanicState

File ~/Library/jupyterlab-desktop/jlab_server/lib/python3.8/site-packages/optax/contrib/dadapt_adamw.py:45
     39   numerator_weighted: chex.Array  # shape=(), dtype=jnp.float32.
     40   count: chex.Array  # shape=(), dtype=jnp.int32.
     43 def dadapt_adamw(
     44     learning_rate: base.ScalarOrSchedule = 1.0,
---> 45     betas: tuple[float, float] = (0.9, 0.999),
     46     eps: float = 1e-8,
     47     estim_lr0: float = 1e-6,
     48     weight_decay: float = 0.,
     49 ) -> base.GradientTransformation:
     50   """Learning rate free AdamW by D-Adaptation.
     51
     52   Adapts the baseline learning rate of AdamW automatically by estimating the
   (...)
     69     A `GradientTransformation` object.
     70   """
     72   def init_fn(params: base.Params) -> DAdaptAdamWState:

TypeError: 'type' object is not subscriptable

Hi, looks like you are trying to use scvi-tools with Python 3.8. We don't support that version anymore with our newer releases, and this is likely the source of the issue. I would suggest updating to Python 3.9 - 3.11.

That fixed the issue, thank you!


Power Toys Run not finding "Edit the system environment variables"

Microsoft PowerToys version
0.47.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
If I want to directly find "Edit the system environment variables" like in the classic start menu, PTR won't find it, only if I search for the parent window "Control panel".
✔ Expected Behavior
...to show the searched window...
❌ Actual Behavior
...it's not found...
Other Software
_No response_a

Thank you for reporting that!
Could you please send us a bug report?
Additional the following screenshots eould be helpful:

When you see the results and what result you use.
When you search and don't see the result.

How to generate the report:
1. Right-click on the PowerToys icon in the tray menu and select Report Bug.

2. The report is saved as .zip file on your desktop. Please drag and drop the report into a GitHub comment.

@htcfreek did this get wrapped up in the Oct 11 merge?

@htcfreek did this get wrapped up in the Oct 11 merge?

Yes. It's all working an merged with #13746. Can you please assign the project (0.51). Thanks.

This is fixed in 0.51.  Please head over to our releases and get the update!  https://aka.ms/installpowertoys


WindowPosition.Aligned is occupying screen insets (taskbar)

WindowPosition.Aligned mentions in the docs that the Window will be aligned in the area that is not occupied by the screen insets (taskbar, OS menubar)
However, I'm not seeing such behavior.

With the following code:
 val windowState = rememberWindowState(
      position = WindowPosition.Aligned(Alignment.BottomEnd),
      width = Dp.Unspecified,
      height = Dp.Unspecified,
  )

Window(
    state = windowState,
    undecorated = true,
    resizable = false,
    focusable = true,
    alwaysOnTop = true,
    onCloseRequest = {},
) {
    Box {
        Column {
            Text("test1")
            Text("test2")
            Text("test3")
            Text("test4")
        }
    }
}

Tried messing with all those attributes as well as removing the Box, but nothing seems to change this.

Just saw #1553, but I think this needs a different solution/workaround

I wrote up a quick workaround that might be helpful for you:
@Composable
fun ComposeWindow.subtractInset() {
    LaunchedEffect(Unit) {
        val inset = Toolkit.getDefaultToolkit().getScreenInsets(Frame().graphicsConfiguration)
        val size = Toolkit.getDefaultToolkit().screenSize.apply {
            // Only one side will have an inset at any point in time, all others remain at 0
            // We need to find the one side that has it and apply it to the appropriate dimension
            width -= max(inset.left, inset.right)
            height -= max(inset.top, inset.bottom)
        }
        val rangeX = 0 .. size.width
        val rangeY = 0 .. size.height
        // Works when taskbar is on top or left of screen
        if (x !in rangeX || y !in rangeY)
            setLocation(
                x.coerceIn(rangeX),
                y.coerceIn(rangeY)
            )
        // Works for when taskbar is on right or bottom of screen
        if (x + width !in rangeX || y + height !in rangeY)
            setLocation(
                (x + width).coerceIn(rangeX) - width,
                (y + height).coerceIn(rangeY) - height
            )
    }
}

The function is fairly long but it should fix the problem you're having and also cover alignment for all alternative taskbar layouts as well. Just call window.subtractInset() within your application's FrameWindowScope to use it.

Yea it did solve, thanks!
I had tried that something like that, guess I was missing the LaunchedEffect 😅

Might want to keep the issue open for now since it references a bug that still exists in the library. What I gave you only works as a workaround for the time being. 🙂

Yeah right 😅

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Tracking issue for Q1 2021 small features release.

This meta-issue tracks the Q1 2021 small features release

Implementation plan
Feature specification

This consists of three sub-features, as described in the feature specification:

Type arguments on annotations: https://github.com/dart-lang/language/issues/1297
Generic function types as type arguments https://github.com/dart-lang/language/issues/496
>>> (triple-shift) as an overridable operator https://github.com/dart-lang/language/issues/120)

Implementation issues

[x] Issue for core library implementation: #44912
[x] Issue for implementation in dart2js: #44913
[x] Issue for implementation in the VM: #44914
[x] Issue for implementation in DDC: #44915
[x] Issue for implementation in CFE: #44916
[x] Issue for implementation in Analyzer: #44917
[x] Issue for implementation in IntelliJ: #44918
[x] Issue for external syntax highlighting support: #44919
[x] Issue for internal tooling support: #44920
[x] Issue for implementation in Dartfmt: 44921
[x] Issue for implementation in Dartdoc: #44922
[x] Issue for implementation in build systems and Angular compiler: #44923
[x] Issue for VM Service support: #44924
[x] Issue for web debugging support: #44925
[x] Issue for language tests: #44926
[ ] Issue for documentation: #44927

@sgrekhov please add links to relevant co19 issues here.

Implementation completed


Spring Data JPA tutorial

Related to #6046.
This PR includes:

An end-to-end tutorial on developing a basic Spring Boot application on CRDB with Spring Data JPA for the data access layer.
An additional entry in the "Sample Apps" ToC section, under "roach-data" apps.
Some of the .java files that make up the application project. Those files are included in the tutorial.

The code referenced by this tutorial is located here: https://github.com/cockroachlabs/roach-data/tree/master/roach-data-jpa. I made a couple minor changes to the application that are reflected in the .java files in this PR and in the tutorial (i.e. simplified some annotation/imports). Those changes are reflected in this pull request: https://github.com/cockroachlabs/roach-data/pull/3.

This change is

@kai-niemi
FYI

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/dba2b79ba225ce54a342d02e4f76adfe5ec99510/
Edited pages:

v20.1/build-a-java-app-with-cockroachdb-hibernate.md
v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.1/build-a-spring-app-with-cockroachdb-jpa.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/021a6446db57cee7171c3755433f740eaf34f712/
Edited pages:

v20.1/build-a-java-app-with-cockroachdb-hibernate.md
v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.1/build-a-spring-app-with-cockroachdb-jpa.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b6688205cb238ca3e6fa7c0d16a016336d9f3253/
Edited pages:

v20.1/build-a-java-app-with-cockroachdb-hibernate.md
v20.1/build-a-spring-app-with-cockroachdb-jdbc.md
v20.1/build-a-spring-app-with-cockroachdb-jpa.md
v20.2/build-a-java-app-with-cockroachdb-hibernate.md
v20.2/build-a-spring-app-with-cockroachdb-jdbc.md
v20.2/build-a-spring-app-with-cockroachdb-jpa.md


msvc /analyze warning "C6001: Using uninitialized memory" in user test cases

I'm getting a warning from msvc /analyze about using uninitialized memory in a testcase simplified from my real project:
TEST_CASE("test1") {
  int *x = nullptr;
  REQUIRE(x==nullptr);
  SECTION("section") {
  }
}

I'm not certain what exactly the warning is claiming is uninitialized, but it seems to be one of the internal variables created by the catch macros. It may also be a false positive.
I've produced a self contained cmake project that reproduces the warning:
https://github.com/socantre/catch-repro
This example suppresses warnings in the catch.hpp header itself, but this warning is positioned in user code rather than in the header. Ideally the catch.hpp header can do something to prevent this warning without shutting it off in user code completely, but that may not be possible if this is just a false positive.

This looks like it should be correct. Looking at the preprocessed file, the variable is never used uninitialized. In fact, it's never used at all.

I tested this against current master and didn't get the warning, so I am going to mark this as resolved, unless someone can repro it.


Content cannot be downloaded from channels with a configured ID

When I add a channel that has an ID configured, the download cannot start because it doesn't find the messages in the channel, and if I try to force it with "manual download," it returns an exception.
Channel: https://t.me/gratisparati/

On the contrary, if I add a channel that does not have an ID configured, all the messages in the channel are found and I am able to download content.
Channel: https://t.me/c/2281628260/

TgDownloaderConsole-AnyCPU 0.5.180 Windows 11 Home 23H2 22631.4317, thank you.

In the first case, there are some sort of restrictions by the group admins on adding, although posts can be read without membership.

In the second case, even knowing the group ID, I don't have access to the messages.

I assume it's all about the limitations of the band itself.
Perhaps I should consider developing anonymous access to groups.


ci: use set-safe-directory for gtk-rs/checker checkout

Ref: https://github.com/gtk-rs/gtk-rs-core/pull/688#discussion_r874468595

This PR isn't automatically triggering the CI action for some reason


feat: add foreground deletion and refactor deployer for cluster in bare-metal mode

for bare-metal mode:

refactor deployer

seperate config and validation logic
seperate each cluster componments logic

for create cmd

add the foreground deletion
enable timeout context for deployment

@shawnh2 seems ci failed.

related to #96


AttributeError: 'FilterableStream' object has no attribute 'input'

(
    ffmpeg
    .input(video)
    .input(watermark)
    .output('test.mp4')
)
>>> AttributeError: 'FilterableStream' object has no attribute 'input'

Hi,
I'm just starting to read into using FFMPEG and I can gather that you, possibly like myself, have done little to no research at this point and your issue should be ignored as you have provided no context and have not bothered doing research.
Furthermore, this is a perfect example on how to not write a git issue. I recommend you read and article or two on how to write good ones https://wiredcraft.com/blog/how-we-write-our-github-issues/
Happy coding


install

Sir, can you make a video about the installation?  Although I read the steps, I did not know how to set up, I really liked this system you made, it was a great thing, thank you.

Due to busy work recently, the tutorial video cannot be recorded.  I think you can put the questions you have encountered to me here, and I will help answer them.

Due to busy work recently, the tutorial video cannot be recorded. I think you can put the questions you have encountered to me here, and I will help answer them.

I know how to set up a normal php script but I did not know how to set up your system.  Could it be a centos or ubuntu server?  Can you write step by step how to install this system on the server?  Let's say the server is ready, after this stage, how will I install it, where will I add the codes. Thanks

Sir, if I send you the server information, would you install it?

I think you should read the documentation first. https://docs.chat.hypergo.net/docs/intro


Double opt-in

If I follow the API documentation correctly, there are separate endpoints for creating a contact and creating a contact via double opt-in.
In the plugin I see the normal create a contact endpoint is used.
Any plans to support the double opt-in endpoint?

Hi @WHITE-developer ,
Great suggestion! We've put it on the feature list.

Hi @JodebaDigitalPulse
Any idea when you want to implement it?

Hi @WHITE-developer ,
I made a release for this (1.1.0 in Craft 4; 2.1.0 in Craft 5), so it will add an option in the sources list.
For example if your Opt-In form has the name List, it will show as: 'List (opt-in)'
It might be confusing, because the API of Flexmail also returns the contact source 'opt-in-List', because they create this in the background. If you push contacts to that list, they show up as confirmed contacts.

Hi,
thank you for the feedback. My bad, I didn't test that case.
I made a hotfix for that!
Best regards


test(engine): fix integration error when check job status

What problem does this PR solve?

Issue Number: close #6994
What is changed and how it works?

Add sync_diff_inspector check for engine_integration_test
Add --try-num 100 to all integration tests to avoid easy fail  in local test
Modify .status to .state when check job state

Check List
Tests

Manual test (add detailed scripts or steps below)
make engine_integration_test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
 `None`.

/area engine

/status ptal

/run-engine-integration-test

Codecov Report

Merging #6993 (b9314d9) into master (9398176) will decrease coverage by 5.4205%.
The diff coverage is 69.4300%.

Additional details and impacted files

Flag
Coverage Δ

cdc
?

dm
51.8618% <25.0000%> (-0.0861%)
:arrow_down:

engine
62.5272% <73.4463%> (+0.2650%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6993        +/-   ##
================================================
- Coverage   59.8253%   54.4047%   -5.4206%
================================================
  Files           791        418       -373
  Lines         90221      52012     -38209
================================================
- Hits          53975      28297     -25678
+ Misses        31498      20992     -10506
+ Partials       4748       2723      -2025

/run-engine-integration-test

/merge

/merge


Specify service-cluster-ip-range for apiserver (dualstack)

Hi, the --service-cluster-ip-range option should also be specified for apiserver, otherwise services will be created with wrong IP for ipFamily:
apiVersion: v1
kind: Service
metadata:
  name: nginx6
  namespace: default
spec:
  clusterIP: <IP_ADDRESS>
  ipFamily: IPv6
  ports:
  - port: 80
    protocol: TCP
    targetPort: 80
  selector:
    app: nginx
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

Force specified ClusterIPs also not working:
The Service "nginx6" is invalid: spec.clusterIP: Invalid value: "fd02:cea::1": provided IP is not in the valid range. The range of valid IPs is <IP_ADDRESS>/24

Reviewer note: this flag is working only since kube-apiserver v1.19

/sig network

@kubernetes/sig-node-pr-reviews is this change correct?

/remove-sig node
@kubernetes/sig-network-pr-reviews is this change correct?

Reviewing now

This change is correct. Thanks for the contribution

/approve

/lgtm

/approve
Thanks, @kvaps and reviewers.


Add Spur.us service

Good TI service for VPN/proxy-related lookups:

Paid plan includes different threat feeds and APIs
Free plan can be used for manual IP lookups, check it out:

https://spur.us/app/context?q=<IP_ADDRESS> OR https://spur.us/context/<IP_ADDRESS>

Thank you, @maxvarm 😄


Single character bold sections are handled erratically.

Markdown.gs faithfully handles single (space) characters formatted as bold, but they do very strange things when parsed for Github Pages / Github Flavoured Markdown. They should probably be stripped from the document by the parser to avoid this (as they add no value).

Resolved - will go live on the Add-On Store upon next release.


Fixes "TypeError" for all http 404 responses

Prior to this PR, any 404 response from mailgun would cause a TypeError: exception class/object expected to be thrown from the mailgun gem.
The previous behavior is that 404 should return a nil response instead of throwing an exception. This re-introduces that behavior (with specs), so that only errors that respond to the 'handle' method will be re-raised.

Hey @melcher I just realised I did the same thing you did a while ago in https://github.com/HashNuke/mailgun/pull/58
I can see from this PR that you think the expected behaviour when fetching a missing object is to return nil, how did you decide on that?
Cheers,
Stefan

@hairihan do you have any opinion on the topic? :)


Editor is scrolled down after switching from current tab to another and then returning to the original tab

GitLens Version: 4.4.3
VSCode Version: 1.15.1
OS Version: Windows 10 1703

Steps to Reproduce:

Open two files, A and B. A must be a very large file.
Navigate to some line in the middle of file A, let say line 1390.
Switch to file B tab.
Return to file A tab, and notice that the page has been scrolled down. Now the first line displayed is line 1450, and line 1390 is not visible now. Although the cursor is still in line 1390, it requires an extra scroll or key press to force the screen to display line 1390 again.

The issue does not reproduce right after opening VSCode, but it reproduces after some tab switches. About 10 tab switched.
Is this a known issue?
P.S. Thanks for the great extension!

@kiewic Thanks! I looked into this quickly and it looks like an issue with vscode itself when showing code lens. Here is the open issue: https://github.com/Microsoft/vscode/issues/32397


build: sveltekit breaking changes

Motivation
SvelteKit introduced a new syntax for its routing, as well as for its data loading, in the newest pre-1.0 release.
This PR performs the migration.
Resources

Migration guide: https://github.com/sveltejs/kit/discussions/5774
Tutorial: https://joshcollinsworth.com/blog/sveltekit-breaking-changes

Changes

bump all dependencies
migrate routes
adapt configuration

Blocked. The certified assets canister does not support SvelteKit routing anymore.


docs: add users section to readme

This small change adds a "users" section to the README that can point at open source projects written in Go that support Amazon Ion by using this library. I've added one of my projects as an example with some text to encourage others to do the same.
Why link to these external projects?

They provide a real-world example of using the library that others can learn from
They provide tools that may be useful in testing or adopting Amazon Ion
They can help create community and a useful feedback mechanism for bugs & features

A little background on my tool: it's a CLI for HTTP APIs that has built-in content negotiation features and supports a bunch of content types out of the box, so for example if the API server sends binary Amazon Ion instead of plain JSON then Restish can parse and display the resulting data.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   75.96%   75.96%
=======================================
  Files          22       22
  Lines        4609     4609
=======================================
  Hits         3501     3501
  Misses        682      682
  Partials      426      426

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b9ce5...0158dca. Read the comment docs.

Thanks for the contribution. The description of you tool sounds interesting, I will give it a go :)
You bring forward a very interesting and valuable point--the addition of clients to the library.
I'll keep this PR open for a while (if that is OK with you) mainly because we need to figure out the best way to present this information and where. The repo is one option, there is also the Ion web page(s) rooted at http://amzn.github.io/ion-docs/
My initial reaction here is that we probably want these type of links on both

the web page as a consolidate view helping people decide on language/tools for ion
the repo providing people easy access for tools in the language of the library they are already on

Let me circulate this with the team and upon consensus we can then act.

Minor rewording so I made a new PR #126


Leave team needs next step

When you leave a team, you just sit on that screen and it's up to the user to navigate Back.  Upon confirmation, the user should be navigated somewhere to let them know that the action has taken place.  Back to the Teams Screen could work (might be empty) or back to the Messages page?  Maybe the search screen?

Added nav back to teams screen


Readme rename & small readme changes

@dstockwell @shans ptal :)

I have no idea why this is showing up with 6 commits instead of 2 :-|


JDM specification and lifecycle management

Thanks for this OSS contribution!

Is there some kind of formal specification of this "standard"?
How do you plan to manage lifecycle and evolvement of it?

thanks @stefan-gorules for your quick response! The link is helpful. but it does not seem to cover the required JDM json format.
Example:
When deleting the json-key position from your ./test-data/function.json example, the evaluation fails with a loader error. So the key position seems to be mandatory in the JDM json files.
I think for a json based DSL like JDM needs a specification which lists mandatory/optional fields, document structure, allowed values, etc....
Otherwise it is a bit of guesswork and try-and-error, based on the provided examples, to figure out what can be fed into the BRE.
Using your superb editor https://editor.gorules.io/ is an option, of course. But it brings a very heavy dependency which is not appropriate for some use-cases.

Hi @sysid before closing you mentioned that removing the position causes the format to break, if this is the case I'm happy to open the issue and investigate it further as this should not happen.

Thanks @stefan-gorules, your attentiveness is much appreciated!
My original remark was based on an error on my side. It is working.
Really looking forward to see the jdm-editor!


bug: sft_trainer.py::train() raises exception due to change in transformers 4.38.0

Issue
The __init__() method of the transformers SFTTrainer class raises  an exception when using the latest commit of fms-hf-tuning (f4e8eb4db560fb2968c8c5e2860cf913d03c9676) and transformers>=4.38.0.
Context

Currently, the dependency to transformers in the requirements.txt file is transformers>=4.34.1
The commit that makes fms-hf-tuning incompatible with transformers is https://github.com/huggingface/transformers/commit/5f06053dd821c91f7bd697309109abaa3396b605

this got released at v 4.38.0

Possible solutions

Update fms-hf-tuning source code to be compatible with transformers>=4.38.0
Update requirements.txt so that it uses transformers<4.38.0

Done when

[ ] sft_trainer.py works with the dependencies that get installed when installing fms-hf-tuning

Example:
commit: f4e8eb4db560fb2968c8c5e2860cf913d03c9676
model="hf-tiny-model-private/tiny-random-BloomForCausalLM"
python tuning/sft_trainer.py --output_dir tuned --model_name_or_path ${model} --use_flash_attn=false --num_train_epochs 5 \
        --evaluation_strategy no --response_template "\n### Response" --dataset_text_field output --tokenizer_name_or_path ${model} \
        --torch_dtype float32 --data_path common_en_news_combined_512-preprocessed.jsonl \
         --target_modules all-linear --peft_method lora

Exception:
Traceback (most recent call last):
  File "/projects/fms-hf-tuning/tuning/sft_trainer.py", line 308, in <module>
    fire.Fire(main)
  File "/projects/fms-hf-tuning/venv/lib/python3.10/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/projects/fms-hf-tuning/venv/lib/python3.10/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/projects/fms-hf-tuning/venv/lib/python3.10/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/projects/fms-hf-tuning/tuning/sft_trainer.py", line 304, in main
    train(model_args, data_args, training_args, tune_config)
  File "/projects/fms-hf-tuning/tuning/sft_trainer.py", line 252, in train
    trainer = SFTTrainer(
  File "/projects/fms-hf-tuning/venv/lib/python3.10/site-packages/trl/trainer/sft_trainer.py", line 295, in __init__
    super().__init__(
  File "/projects/fms-hf-tuning/venv/lib/python3.10/site-packages/transformers/trainer.py", line 648, in __init__
    self.is_fsdp_xla_v2_enabled = args.fsdp_config["xla_fsdp_v2"]
KeyError: 'xla_fsdp_v2'

@VassilisVassiliadis this is addressed by #53 . As i had mentioned in that PR, best to avoid these manual adjustments of training args

Thank you, I also prefer that fms-hf-tuning works with the latest version of transformers too!


Tags in File Explorer

Description of the new feature / enhancement
Both MacOS and Files App allow us to add color tags to files and folders, a quick way to organize and search content.

Scenario when this would be used?
In any File Explorer window, with access at the toolbar and right-click menu.
Supporting information
No response

/dup #150


Support to reuse the byte array created by ZstdInputStream/ZstdOutput…

fix #131

@luben @yuzawa-san @ijuma please take a look

Yeah, I suppose it could work. Still seems off, but if it is the only way. Regardless, I suggest holding off on this until I send a PR off for the additional buffering https://github.com/luben/zstd-jni/issues/141

Regardless, I suggest holding off on this until I send a PR off for the additional buffering #141

Thanks for tweaking the memory for both zstd and kafka. Will your next PR change the construction?

Yeah, I suppose it could work. Still seems off, but if it is the only way. Regardless, I suggest holding off on this until I send a PR off for the additional buffering #141

Do we need to block this change? I think they are orthogonal and there will be no conflicts.

I was not adding any constructor arguments, but I was doing additional calls to BufferPool in the constructor and close().

I took https://github.com/luben/zstd-jni/pull/146 instead. Closing as it provides similar capabilities


Give more love to native extensions / dart -> JS (interop) -> native is easier than dart -> native

1 - outdated documentation
2 - old style (sample) code (malloc!!!!???? - really? in times of C++11/14/17?)
3 - no cmake (GH sample seems to use gyp - no word about this in documentation)
4 - only one sample!
The way nodejs handles this: https://nodejs.org/docs/latest/api/addons.html
Two functions, one macro - thats it.
Hello-World in node-js: https://github.com/nodejs/node/tree/master/test/addons/hello-world

I someone else looking for Dart-Native-Extensions - here are some of my experiments: https://github.com/MikeMitterer/cmake-dart-extension-master

I think it would be a very cool strategy to reuse native bindings from JS/Java/Python...
A swig-module could be another option: http://www.swig.org/index.php


POL-424: Cleaning up "deadwood" code.

Description
Fields start_date and end_date added by script js_time, and datasource ds_time were actually never used in the policy, and all can be removed without affecting the functionality of the template.
Issues Resolved
In relation to https://jira.flexera.com/browse/POL-424.
Contribution Check List

[x] All tests pass.
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] New functionality has been documented in CHANGELOG.MD

          1 Warning

:warning:
Should this include readme changes

  Generated by :no_entry_sign: Danger


setuptools_scm 8.1.0

Destination channel: main
Links

PKG-5275
Upstream repository
Releases: https://github.com/pypa/setuptools_scm/releases
Requirements: https://github.com/pypa/setuptools_scm/blob/v8.1.0/pyproject.toml

Explanation of changes:

Fix source/url
Use typing-extensions for py<310 only

Notes:

Updating because broken CI on some settings following git update, see https://github.com/conda/conda/actions/runs/9881920885/job/27293763034?pr=14030

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_75zioh5ceq/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:31: python_build_tool_in_run: output "setuptools-scm": The python build tool setuptools is in run depends
clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: output "setuptools-scm": Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:33: python_build_tool_in_run: output "setuptools-scm": The python build tool setuptools is in run depends

===== ERRORS =====

clone/recipe/meta.yaml:1: missing_python_build_tool: output "setuptools_scm": Python packages require a python build tool such as setuptools.
clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
clone/recipe/meta.yaml:47: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
clone/recipe/meta.yaml:50: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
5 Errors and 3 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_acj1i1lk_2/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:33: python_build_tool_in_run: output "setuptools-scm": The python build tool setuptools is in run depends
clone/recipe/meta.yaml:31: python_build_tool_in_run: output "setuptools-scm": The python build tool setuptools is in run depends
clone/recipe/meta.yaml:27: host_section_needs_exact_pinnings: output "setuptools-scm": Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:47: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
clone/recipe/meta.yaml:1: missing_wheel: For pypi packages, wheel should be present in the host section
clone/recipe/meta.yaml:1: missing_python: For pypi packages, python should be present in the host and run sections. Missing in {}
clone/recipe/meta.yaml:50: missing_pip_check: For pypi packages, pip check should be present in the test commands
clone/recipe/meta.yaml:1: missing_python_build_tool: output "setuptools_scm": Python packages require a python build tool such as setuptools.
===== Final Report: =====
5 Errors and 3 Warnings were found


refactor(esl-core): fix types and documentation

:tada: This PR is included in version 3.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Windows npm install fails after bugfix release

Hi,
After your commit b1ddc451e30be835aec94fb26ecf323da51bec51 and resulting release 2.2.5, NPM install starts to fail with a missing peer dependency 'canvas'.  This canvas module however cannot be just installed using NPM on windows. It requires extra installation steps on our development and build machines, which is really undesirable.
I think this should not have occurred in a bugfix release since it's clearly backwards incompatible. But is this dependency really necessary at all? Can it be removed or replaced with a windows-compatible module? Why is it a peer dependency and not a normal one? I'm confused.

Are you on a version of NPM below v3?  Peer Dependencies are now optional, with a CLI warning only.
Canvas has its own dependencies/requirements which make it impossible to link to as a straight dependency.
Canvas is only a hard dependency if you wish to use Resemble.js in NodeJS.
I need to think about this a little, I'm happy to change the versions just not sure on the implications.

I'm hoping this is resolved now that Resemble has dropped the peer dependency and added a straight dependency on canvas-prebuilt.


Error on comparing response from model function to boolean

Larastan Version: 0.7.6
--level used: 5
Pull request with failing test:

Description
Getting error  Strict comparison using === between Illuminate\Database\Eloquent\Builder<App\Models\Publisher> and false will always evaluate to false. when comparing the response of calling restore() on a model.
Laravel code where the issue was found
$publisher = Publisher::withTrashed()->where('id', $id);
$response = $publisher->restore();

if ($response === false)
{
}

Fixed with e02c9750f82800c05592493efc9c3acb259f753a

🏎


Translated Chapter 8 of Tour of Rust in Romanian  🇷🇴

Duplicate of #17 , please add feedback there.


UI: Leaving Godot on in the background sometimes corrupts the UI text

Godot version
v4.0-mono stable
System information
Windows 11, Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz , GeForce RTX 2060, Nvidia driver version 451.67
Issue description
If left idle for long periods of time(5 days in this case) the UI text gets corrupted for lack of a better word, fixes itself upon reloading
Steps to reproduce
Open a Godot project and tab out for a while(occurred with Windows in this case)
If left and then reopened after a while, text looks like this

Minimal reproduction project
N/A

Your graphics drivers are very old. Try updating to 531.29 or newer.


Cannot see topics in Foxglove but can echo them inside Docker Container

I am running the MCAP files inside the container and can see the topics being published by using ros2 bag play <filename>.mcap. In a separate terminal, I can monitor the topics' frequency with ros2 topic hz <topic_name> and echo them with ros2 topic hz <topic_name> so the messages are being published correctly inside the container.
While the rosbag is running, I am trying to visualize the topics in Foxglove Studio following the steps outlined in the documentation. The topic names appear in the left panel of Foxglove, but no messages are being received (see image below, next to the /livox/lidar topic frecuency and message count appears as "--"), it is the same behaviour with ALL other topics including /rosout and /tf_static.

It seems that my local host is not receiving the topic data from the Docker container.
System details:
Host OS:  Ubuntu 22.04.3 LTS (jammy)
docker: 25.0.1
docker compose: v2.24.2
Any assistance would be greatly appreciated.

Hi, You can open a rosbag directly from foxglove, you don't need to play the rosbag.

Click the foxglove icon

choose a local file.

enjoy!

Hi @garzonwilmer5, thank you.
Yes, I have been doing that. However, in order to test the code for the other tasks I would need to see the new topics that are not present in the recorded bags. For instance, the fail_detection/fail node.
Currently I am testing using the CLI, but this is quite inefficient. I was wondering if someone has faced this issue before and ways to solve it, so I can use Foxglove.

Hi @jhairssteven, there was indeed an issue. In the last commit it was solved. Please pull the fix in your project.
Study what we change and you may obtain some extra points in the presentation :wink:


Data services batch update command

This pull request adds a signal to update web services when a file or folder is moved or renamed.
It also adds a management command that will register all valid content on GeoServer  when web
services are enabled. This is a feature that Dr. Ames and Martin requested, but let me know if there's a better way to accomplish it.
Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Running python manage.py update_data_services should register all valid content on GeoServer, if enabled.

I won't have time to continue working on this PR, so you can probably close it for now. If the web services manager code is eventually integrated into HydroShare, the functionality from this PR should be included in that project.


Handle extended classifications. Issue #445

Hi, thanks for the PR! #336 seems to want to use the extended classification if the normal classification is 0. Do you know if one of these versions is correct or if it doesn't matter?

I searched a bit to determine how exactly you determine whether to use point->extended_classification or to use point->classification to extract the classification as Martin would have intended.  Maybe I missed it.  I came up with the following samples that made me go down the path of using a zero value of point->classification to then go and try to use the point->extended_classification.  The thought was that even if point->classification was zero and point->extended_classification did not exist, point->extended_classification would be 0 anyway so no biggie.  @arknoll, I know you had questioned this in my #336 PR.
https://github.com/LAStools/LAStools/blob/master/LASzip/example/laszipdllexample.cpp#L2328
The following example says for point->classification that it must be set because it "fits" in 5 bits.  Notice that the example also sets the point->extended_classification to the value that is less than 32 so the point->extended_classification ends up getting set anyway.
    point->intensity = 20;
    point->extended_return_number = 1;
    point->extended_number_of_returns = 2;
    point->classification = 5;                // it must be set because it "fits" in 5 bits
    point->extended_classification = 5;
    point->extended_scan_angle = 3700;
    point->extended_scanner_channel = 1;
    point->extended_classification_flags = 0; // no flag is not set
    point->gps_time = 53413162.580200;

The following example says for point->classification that it must be set to zero as the real value is stored in the extended field.  Notice that the example also set the point->extended_classification.
https://github.com/LAStools/LAStools/blob/master/LASzip/example/laszipdllexample.cpp#L2328
    point->intensity = 70;
    point->extended_return_number = 9;
    point->extended_number_of_returns = 9;
    point->classification = 0;                // it must be set to zero as the real value is stored in the extended field
    point->extended_classification = 42;
    point->extended_scan_angle = 3633;
    point->extended_scanner_channel = 1;
    point->extended_classification_flags = 0; // no flag is not set
    point->gps_time = 53413162.566800;

I feel that ideally someone finds a link that documents or gives a code example of exactly how you determine which classification to use.  I did see some places in the codebase that used check for extended_classification > 31.  Is extended_classification gauranteed to have a value?
https://github.com/LAStools/LAStools/blob/150e6c23bb2ced93083b5ba656c5f8e55403b81b/LASlib/src/laswritercompatible.cpp#L352
   if (pointCompatibleDown.extended_classification > 31)
  {
    pointCompatibleDown.set_classification(0);
  }
  else
  {
    pointCompatibleDown.extended_classification = 0;
  }

I am kind of thinking that both ways of doing it would work.  I am just not sure of how Martin intended it to work.

I can confirm that this branch works well.

thanks for the PR


Questions with no content/options can be added

Describe the bug
The examiner can add a question without providing some text and options in the respective question and the test can be created without the questions and the options
Expected behavior
The class room teacher cannot add a question without providing the question and the the options

Hey, I would like to work on this

Hey, I would like to work on this


Add React propTypes removal

I originally started by adding this plugin to react-dates, but it seems
like we are going to want this in a lot of places, so it makes sense to
put it into our preset instead.
https://github.com/airbnb/react-dates/pull/1322
For the default options, I decided to go with "wrap" as the mode, since
we are likely to use this more frequently in packages that are published
and consumed by other packages and apps, which aren't very compatible
with the "remove" option.
In our apps where this is not a concern, we will want to override this
to use the "remove" option in production and likely disable this plugin
entirely in development for better build speeds.

@ljharb I've tested this using npm link in my local copy of react-dates, using the default (disabled), true, and also overriding the mode option and the additionalLibraries option. I think we are good to go!


Fix path for /etc/group control 6.1.5

Fixes #194

Hi @ChandlerSwift
Brilliant catch, that is now merged into devel.
Thanks for you continued feedback to help improve these benchmarks.
uk-bolly