instruction::replace(const shape&) fails when multiple inputs originate from the same instruction

Example code:
migraphx::program p;
auto *mm = p.get_main_module();

migraphx::shape s{migraphx::shape::float_type, {3, 2}};
auto input = mm->add_parameter("x", s);
auto reduce = mm->add_instruction(migraphx::make_op("reduce_sum", {{"axes", {0}}}), input);
auto abs = mm->add_instruction(migraphx::make_op("abs"), reduce);
auto sin = mm->add_instruction(migraphx::make_op("sin"), reduce);
mm->add_instruction(migraphx::make_op("add"), abs, sin);

reduce->replace(migraphx::make_op("reduce_sum", {{"axes", {1}}));

Resulting IR:
x = @param:x -> float_type, {3, 2}, {2, 1}, target_id=0
@1 = reduce_sum[axes={0}](x) -> float_type, {1, 2}, {2, 1}, target_id=0
@2 = abs(@1) -> float_type, {1, 2}, {2, 1}, target_id=0
@3 = sin(@1) -> float_type, {1, 2}, {2, 1}, target_id=0
@4 = add(@2,@3) -> float_type, {1, 2}, {2, 1}, target_id=0

Resulting error:
terminate called after throwing an instance of 'migraphx::version_2_10_0::exception'
  what():  /workspace/halilcevic/AMDMIGraphX/src/include/migraphx/check_shapes.hpp:220: same_dims: add: Dimensions do not match

In https://github.com/ROCm/AMDMIGraphX/blob/fea6dd6f36c90373d3d22f763dbe49bfa3749fe9/src/instruction.cpp#L60 a pre-order traversal is performed, leading to add being processed before one of its inputs, sin,  has been updated causing a shape mismatch.
A breadth-first traversal should be performed for correct behavior.

Hi @music-dino, the fix for this issue https://github.com/ROCm/AMDMIGraphX/pull/3521 is merged now. Thanks!


feat: Enable ASLR and Full RELRO while building binaries

closes #4916

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run the following command to build binaries
make build

And the following command to check Full RELRO and PIE are enabled
checksec --file=./cmd/core-data/core-data
RELRO           STACK CANARY      NX            PIE             RPATH      RUNPATH	Symbols		FORTIFY	Fortified	Fortifiable	FILE
Full RELRO      No canary found   NX enabled    PIE enabled     No RPATH   No RUNPATH   No Symbols	  Yes	2		2		./cmd/core-data/core-data

New Dependency Instructions (If applicable)

@jackchenjc thanks, please make the same changes for other repositories


Detailed debug-info (DWARF) support in new backends (initially x64).

This PR propagates "value labels" all the way from CLIF to DWARF
metadata on the emitted machine code. The key idea is as follows:

Translate value-label metadata on the input into "value_label"
pseudo-instructions when lowering into VCode. These
pseudo-instructions take a register as input, denote a value label,
and semantically are like a "move into value label" -- i.e., they
update the current value (as seen by debugging tools) of the given
local. These pseudo-instructions emit no machine code.

Perform a dataflow analysis at the machine-code level, tracking
value-labels that propagate into registers and into [SP+constant]
stack storage. This is a forward dataflow fixpoint analysis where each
storage location can contain a set of value labels, and each value
label can reside in a set of storage locations. (Meet function is
pairwise intersection by storage location.)
This analysis traces value labels symbolically through loads and
stores and reg-to-reg moves, so it will naturally handle spills and
reloads without knowing anything special about them.

When this analysis converges, we have, at each machine-code offset, a
mapping from value labels to some number of storage locations; for
each offset for each label, we choose the best location (prefer
registers). Note that we can choose any location, as the symbolic
dataflow analysis is sound and guarantees that the value at the
value_label instruction propagates to all of the named locations.

Then we can convert this mapping into a format that the DWARF
generation code (wasmtime's debug crate) can use.

This PR also adds the new-backend variant to the gdb tests on CI.

@yurydelendik, I think I will need your help on this -- it appears that you wrote all of the debug support initially? Two questions:

Is there a reason that the gdb tests are currently marked #[ignore]? Are they known to be broken for other reasons?

If not, would you be able to help me debug this? I believe the analysis is generating correct, or mostly correct, mappings of labels to registers; but the debug crate in wasmtime is generating DWARF that uses the vmctx register outside of its valid range and I don't understand enough about DWARF or the code here to say why.

Any help from anyone who is passionate about debuginfo would be appreciated -- this is one of the last pieces needed to enable the switch to the new backend by default in wasmtime, and I've dumped a bunch of time into this and need to context-switch for a little bit :-)

@yurydelendik, I think I will need your help on this -- it appears that you wrote all of the debug support initially? Two questions:

Is there a reason that the gdb tests are currently marked #[ignore]? Are they known to be broken for other reasons?

If not, would you be able to help me debug this? I believe the analysis is generating correct, or mostly correct, mappings of labels to registers; but the debug crate in wasmtime is generating DWARF that uses the vmctx register outside of its valid range and I don't understand enough about DWARF or the code here to say why.

Any help from anyone who is passionate about debuginfo would be appreciated -- this is one of the last pieces needed to enable the switch to the new backend by default in wasmtime, and I've dumped a bunch of time into this and need to context-switch for a little bit :-)

Is there a reason that the gdb tests are currently marked #[ignore]? Are they known to be broken for other reasons?

They are marked as "ignored" to not run them on developer's computer: the tests require lldb/gdb/llvm-dwarfdump install. These tests are run on the CI. See https://github.com/bytecodealliance/wasmtime/blob/cacebfb19c721b293c947f9bc8c57643c2763b95/.github/workflows/main.yml#L287-L293

If not, would you be able to help me debug this?

I'll try to be useful, yes.

but the debug crate in wasmtime is generating DWARF that uses the vmctx register outside of its valid range

To keep vmctx register/value valid as long as possible is a desired functionality, as well as knowing it during stack unwinding to provide Instance information. We talked with @sunfishcode about having fixed location for vmctx some time back.
If vmctx is not available, there is no way to get a variable value stored in the instances memory and shadow stack. The variables are marked as optimized out in this case. Which is acceptable solution from debugging of optimized code point of view. Of course we have to minimize such cases to make live of developers better.

Is there a reason that the gdb tests are currently marked #[ignore]? Are they known to be broken for other reasons?

They are marked as "ignored" to not run them on developer's computer: the tests require lldb/gdb/llvm-dwarfdump install. These tests are run on the CI. See https://github.com/bytecodealliance/wasmtime/blob/cacebfb19c721b293c947f9bc8c57643c2763b95/.github/workflows/main.yml#L287-L293

If not, would you be able to help me debug this?

I'll try to be useful, yes.

but the debug crate in wasmtime is generating DWARF that uses the vmctx register outside of its valid range

To keep vmctx register/value valid as long as possible is a desired functionality, as well as knowing it during stack unwinding to provide Instance information. We talked with @sunfishcode about having fixed location for vmctx some time back.
If vmctx is not available, there is no way to get a variable value stored in the instances memory and shadow stack. The variables are marked as optimized out in this case. Which is acceptable solution from debugging of optimized code point of view. Of course we have to minimize such cases to make live of developers better.

To keep vmctx register/value valid as long as possible is a desired functionality, as well as knowing it during stack unwinding to provide Instance information. We talked with @sunfishcode about having fixed location for vmctx some time back.
If vmctx is not available, there is no way to get a variable value stored in the instances memory and shadow stack. The variables are marked as optimized out in this case. Which is acceptable solution from debugging of optimized code point of view. Of course we have to minimize such cases to make live of developers better.

Makes sense; I'll think about ways to do this. Perhaps the simplest would be to just add a hack that emits a value_label psuedo-instruction for vmctx at return -- this would keep it alive and ensure it can be accessed at least from a spillslot if not a register.
A question: I was struggling to work out the invariants in the code that converts range-associated data. What do start and end denote for the ValueLabelsRanges? Are these open or closed bounds and do they apply to the start or end of instructions? I had noticed some code that skips any "empty" ranges (start == end) -- if a value is computable only after one instruction, which ends at offset X, should we encode that as start=X, end=X+1?
There's something a little more broken going on in this PR right now, as the vmctx value is dead at a certain point, but DWARF info related to its former register is being generated. So I suspect that I'm misunderstanding some of the invariants related to ranges.
Thanks for the help!

To keep vmctx register/value valid as long as possible is a desired functionality, as well as knowing it during stack unwinding to provide Instance information. We talked with @sunfishcode about having fixed location for vmctx some time back.
If vmctx is not available, there is no way to get a variable value stored in the instances memory and shadow stack. The variables are marked as optimized out in this case. Which is acceptable solution from debugging of optimized code point of view. Of course we have to minimize such cases to make live of developers better.

Makes sense; I'll think about ways to do this. Perhaps the simplest would be to just add a hack that emits a value_label psuedo-instruction for vmctx at return -- this would keep it alive and ensure it can be accessed at least from a spillslot if not a register.
A question: I was struggling to work out the invariants in the code that converts range-associated data. What do start and end denote for the ValueLabelsRanges? Are these open or closed bounds and do they apply to the start or end of instructions? I had noticed some code that skips any "empty" ranges (start == end) -- if a value is computable only after one instruction, which ends at offset X, should we encode that as start=X, end=X+1?
There's something a little more broken going on in this PR right now, as the vmctx value is dead at a certain point, but DWARF info related to its former register is being generated. So I suspect that I'm misunderstanding some of the invariants related to ranges.
Thanks for the help!

@yurydelendik with the vmctx-always-alive hack, this seems to pass the gdb DWARF test locally on the new backend now (and I'm watching CI); thanks!
Question above about ranges still stands; I want to make sure I got the conversions right.
Otherwise, though, I think this is ready for review.

@yurydelendik with the vmctx-always-alive hack, this seems to pass the gdb DWARF test locally on the new backend now (and I'm watching CI); thanks!
Question above about ranges still stands; I want to make sure I got the conversions right.
Otherwise, though, I think this is ready for review.

Perhaps the simplest would be to just add a hack that emits a value_label psuedo-instruction for vmctx at return -- this would keep it alive and ensure it can be accessed at least from a spillslot if not a register.

It would be nice to have a more general way of keeping a value alive somewhere for debuginfo purposes.

Perhaps the simplest would be to just add a hack that emits a value_label psuedo-instruction for vmctx at return -- this would keep it alive and ensure it can be accessed at least from a spillslot if not a register.

It would be nice to have a more general way of keeping a value alive somewhere for debuginfo purposes.

Perhaps the simplest would be to just add a hack that emits a value_label psuedo-instruction for vmctx at return -- this would keep it alive and ensure it can be accessed at least from a spillslot if not a register.

It would be nice to have a more general way of keeping a value alive somewhere for debuginfo purposes.

Yes, I agree. I actually thought of a really simple/ugly (but maybe more robust) way of doing this -- allocate slots on the stack for all ValueLabels, and emit actual stores to these slots every time a labeled value is defined (or the label is associated with a new value). Then the DWARF generation can always use SP-offset expressions.
This would horribly pessimize code performance, though maybe not too much more than non-optimized debug code already is; but it would be much simpler and more likely to be correct in all sorts of edge cases. I see this as sort of in the same spirit as the idea proposed in #2459 for reftypes tracing: in both cases we instrument the CLIF to provide needed functionality so that the core compiler remains simpler and easier to verify. It is a little unconventional, though, so perhaps for another time.

Perhaps the simplest would be to just add a hack that emits a value_label psuedo-instruction for vmctx at return -- this would keep it alive and ensure it can be accessed at least from a spillslot if not a register.

It would be nice to have a more general way of keeping a value alive somewhere for debuginfo purposes.

Yes, I agree. I actually thought of a really simple/ugly (but maybe more robust) way of doing this -- allocate slots on the stack for all ValueLabels, and emit actual stores to these slots every time a labeled value is defined (or the label is associated with a new value). Then the DWARF generation can always use SP-offset expressions.
This would horribly pessimize code performance, though maybe not too much more than non-optimized debug code already is; but it would be much simpler and more likely to be correct in all sorts of edge cases. I see this as sort of in the same spirit as the idea proposed in #2459 for reftypes tracing: in both cases we instrument the CLIF to provide needed functionality so that the core compiler remains simpler and easier to verify. It is a little unconventional, though, so perhaps for another time.

@fitzgen or @bnjbvr, would you be able to spare some time to review this? I don't want it to sit too long as it's starting to become stale (I'll rebase across the conflicts when handling any review comments). Thanks!

@fitzgen or @bnjbvr, would you be able to spare some time to review this? I don't want it to sit too long as it's starting to become stale (I'll rebase across the conflicts when handling any review comments). Thanks!

Sure, I can review.

Sure, I can review.

Thanks! I went over this again quickly and noticed a few typos, and decided to rebase while I was here. Also note there's a ridealong change to remove an outdated doc-comment about the backend pipeline (I can split that out if you'd like).

Thanks! I went over this again quickly and noticed a few typos, and decided to rebase while I was here. Also note there's a ridealong change to remove an outdated doc-comment about the backend pipeline (I can split that out if you'd like).

@fitzgen I addressed your comments, but while double-checking the CI results one last time, realized the debug tests weren't actually running on CI (GitHub Actions config issue). On fixing that, discovered that the tests I was running locally were a subset of all debug tests, and two of the others were failing. These failures were due to (IMHO) not-super-important differences in codegen, so I added directives to ignore; but let me know if this is still r+ or if you'd like me to dig deeper. Thanks!

@fitzgen I addressed your comments, but while double-checking the CI results one last time, realized the debug tests weren't actually running on CI (GitHub Actions config issue). On fixing that, discovered that the tests I was running locally were a subset of all debug tests, and two of the others were failing. These failures were due to (IMHO) not-super-important differences in codegen, so I added directives to ignore; but let me know if this is still r+ or if you'd like me to dig deeper. Thanks!


border-top-size issue

This is driving me nuts :scream:

That's how it looked like on 2.x.x :

Config

(For those of you like me who had to look a whole bunch of times before noticing what the problem is, notice how the border extension is a single pixel short.)
I assume you're running the latest v3.0.3?

Yes, I'm running the latest version.
(it's more like 3 pixels short btw)

@plastilint 9f1d9a1 should fix this, please verify and close if it's solved

Yes, it's fixed now, thank you!


Accessing WebGPU via wit-defined library

I'm curious if it would be possible (as of right now with present technology) to expose the WebGPU interface from a web browser to a program (ie. a WASM instance in a browser) through interface types.
I understand my question relates to this: https://github.com/bytecodealliance/wit-bindgen/issues/149
I would like to provide a runtime which exposes the GPU through a single interface (ie. mylibrary::gpu -- defined by a .wit/bindings) which guest programs can access without concern for the underlying host (ie. a browser or another native platform which implements WebGPU.)

Personally I don't know anything about WebGPU, so I can't really answer any specifics here unfortunately.
Otherwise though the answer to this question is probably along the lines of "maybe?" depending on the exact shape of WebGPU APIs and the support for interface types in JS. It's certainly an aspiration of interface types that it would work for WebIDL-bound APIs like WebGPU, but the devil is always in the details.
I'm going to close this because I'm not sure how actionable this is per se. If there's specific bindings issues with the generated JS code that'd be good to have an issue for here. Otherwise if there's expessivity issues with interface types not meshing well with WebGPU then that'd be good to discuss in the interface types repository.


allow preserve array on flattenjson

can add an option (or maybe keynames) to preserve array when flattenjson is true.. i prefer the format the "flattenjson" option gives on the document for my object, except on array elements.

Thanks for the idea! unfortunately I'm very busy lately so it will take me a little time.
Hope to update soon.

@urielha
I downloaded the source and made some changes on on the JsonFilter.cs.. and it seems to work
 case JTokenType.Array:
	var index = 0;
	bool arrObj = false;
	if (PreservePrimitiveArray)
	{
		foreach (var child in token.Children<JObject>())
		{
			// check if its an array of objects
			if (child.Type == JTokenType.Object)
			{
				ScanToken(logEvent, child.Value<JToken>(), Join(prefix, index.ToString()));
				index++;
				arrObj = true;
				break;
			}
		}
		if (!arrObj)
		{
			logEvent.Add(prefix, token);
		}
	}
	else
	{
		foreach (var child in token.Children())
		{
			ScanToken(logEvent, child, Join(prefix, index.ToString()));
			index++;
		}
	}

	break;

Hi @osckal ,
I will see what I can do.
Meanwhile, one of the things that great in that filters is that you can write one of your own and make log4stash load it for you.
I suggest you to compile the changes you have made to the filter and add it to your configuration.
You can just compile this file (with a reference to log4stash.dll for importing the filter interface) and load it by configuration like that:
     <Filter type="log4stash.Filters.NameOfTheFilter, filename">
          <!-- rest of configuration -->
      </Filter>

Hi @urielha ,
Thanks for the advise! I think i'll try that one out and see how it goes. anyway, it looks like I had more changes than expected.
Thanks!

You are welcome :)
Feel free to reopen this issue or open new one if you have trouble with loading your custom filter


removes problematic last name

About the PR
removed an unfunny, most certainly RP inappropriate last name
Why / Balance
'hujsak' come on
if upstream finds this name bad then rmc14 will most certainly find it bad
https://github.com/space-wizards/space-station-14/pull/32998
Technical details
updated last.yml
Media

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

i mean it's fine to remove the name because players are children but this is a real polish last name :P

Wont that upstream PR just naturally flow downstream next time we pull from them

Wont that upstream PR just naturally flow downstream next time we pull from them

i don't remember the last time we pulled from upstream i thought we were behind on a lot of things
i'll close this if we're pulling from upstream soon


New model on duplicated panel has "output_bucket" = null

Hello @vsergeyev
After duplicated and recreated a new model , the new one seem to send data to a "null" output_bucket.  Could be a bug or perhaps I did something wrong?
Thank you very much again for this work!

The workaround is , remove the fist pannel , stop and restart the job

the output bucket now is ok
> show-model linux_metrics_cpu_mean_usage_system__time_5m
- settings:
    bucket_interval: 5m
    default_bucket: xxxxxxxxxx_linux
    features:
    - default: 0
      field: usage_system
      io: io
      match_all: []
      measurement: cpu
      metric: mean
      name: mean_usage_system
    grace_period: 0
    interval: 60s
    max_evals: 10
    max_threshold: 0
    min_threshold: 0
    name: linux_metrics_cpu_mean_usage_system__time_5m
    offset: 10s
    run:
      flag_abnormal_data: true
      output_bucket: xxxxxxxxxxx_loudml
      save_output_data: true
    seasonality:
      daytime: false
      weekday: false
    span: 100
    type: donut
  training:
    job_id: bc894112-9c26-4d14-83b9-1912ccec4646
    progress:
      eval: 10
      max_evals: 10
    state: done

Hello @toni-moreno
Thank you for detailed bug report!
Yeah, it looks I don't handle this event when duplicating panel.
It is a bug and going to fix it.

Volodymyr

Hope this is fixed in latest commit.
Added information about LoudML server / input bucket / output bucket into tooltip,
so it should display an actual settings used for "Create Baseline" 1-click ML button.


how to make menu control like in the example?

hey i am currently using using your maplace to my last project,
and how can i make the control menu like in http://maplacejs.com/ ?
thank you

Code snippets are in the website and github for every demo examples.


Add CQM.substitute_self_loops method

Also some other misc bug fixes.

Codecov Report

Merging #948 (166be24) into main (7b2c810) will increase coverage by 0.05%.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   83.71%   83.77%   +0.05%
==========================================
  Files          79       79
  Lines        6769     6805      +36
==========================================
+ Hits         5667     5701      +34
- Misses       1102     1104       +2

Impacted Files
Coverage Δ

dimod/binary/binary_quadratic_model.py
91.36% <ø> (ø)

dimod/constrained.py
93.12% <90.90%> (-0.31%)
:arrow_down:

dimod/decorators.py
66.66% <100.00%> (ø)

dimod/quadratic/quadratic_model.py
91.97% <100.00%> (+0.27%)
:arrow_up:

dimod/utilities.py
90.78% <100.00%> (+0.20%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2c810...166be24. Read the comment docs.


Create tsconfig.json to standardise build process

Relates to #18. We have to add a tsconfig.json to standardise the build process.
@fredgalvao has already added one in fredgalvao/pouchdb.d.ts/486bf85. This is just an issue to track and merge that particular task into master.

@fredgalvao - I'm attempting to separate this (hopefully small) task from the larger work in the PR for #18 (mostly to make the commit history easier to follow, and that PR easier to review and merge).
I cherry picked your commits from the PR that deal with tsconfig.json (and therefore .gitignore and package.json. You can see the result in compare dev@34b50edc: i24-tsconfig.json@3726e6bc.
I then noticed two things when using VSCode to build.

Having the js files beside the ts files clutters the project view a lot - it feels like the js files belong elsewhere.
The files in \tests were not building.

To try and address this I added to tsconfig.json to send the js transpiled output to \out, and changed tsconfig to use an exclude instead of files. I know you've already tried this so it feels a little like going backwards.
Do you see an issue with the two changes listed above (i24-tsconfig.json@e9e346d4)?

I see none. Although I was trying something different with my version of tsconfig.json, you achieved the same and something else (the compilation of tests/**/*.ts).
I don't quite remember the small issues I encountered that made me go back to files instead of exclude, but it should come up quicky once I apply your changes on my end.
For now you can consider this closed, I guess.

@fredgalvao

For now you can consider this closed, I guess.

I wish! The change to es6 has resulted in a plague of red wiggly lines and travis failures in the PR.

red lines now fixed. #25 open for comments, review, +1 etc. That also includes #26.


Donation rtsp Yi cam outdoor

Hi @roleoroleo
Here is the thing.
I was able to use the firmware for a Yi-outdoor camera, but I realize that I need to make a donation to access a hash for active the RSTP service.
I try to do that, but the mechanism to make the donation is blocked in my Country, then I try to do that from a USA account, and the donation don't go further.
Is there another way to reach you and make the donation for your work,  so you can give me the hash file for active the RSTP service ?
I'll be waiting for your contact.
Thanks in advance.

Sorry, for the delay to respond. Ok I will try that. Thanks for your time. Certainly I will donate to your project.


Fix the image of the architecture overview in our documentation

If I understand it correctly, the image below doesn't reflect our current structure precisely because the output of FeatureEncoder should be a concatenated tensor. However, the image illustrates that the concatenation is applied outside the FeatureEncoder.

The concatenation is done by the StypeWiseFeatureEncoder after applying each StypeEncoder to each stype. Since we are adding the ColumnWiseFeatureEncoder soon, which means that columns of the same stype might not even be concatenated together, we can defer this task till then.

@yiweny Thanks, I agree that this is not urgent.

Since we are adding the ColumnWiseFeatureEncoder soon, which means that columns of the same stype might not even be concatenated together

Still, it might be better to have a consistent interface to make other parts of PyF models FeatureEncoder-agnostic, which contributes to the modular design of PyF.


Lsanabria/toolchain build deps

Removing unnecessary use of wget, replacing with curl.

!ci-build-me

!ci-build-me


[FR] Add direct link to Colab in https://github.com/GoogleCloudPlatform/dfcx-scrapi/blob/main/examples/nlu_analysis_series/nlu_semantic_similarity_demo.ipynb

Is your proposal related to a problem?

When I click on the Colab link in https://github.com/GoogleCloudPlatform/dfcx-scrapi/blob/main/examples/nlu_analysis_series/nlu_semantic_similarity_demo.ipynb, it opens a generic Google Colab page, and I have to paste a file link there.
Describe the solution you'd like

Could you please add a link that would directly open https://github.com/GoogleCloudPlatform/dfcx-scrapi/blob/main/examples/nlu_analysis_series/nlu_semantic_similarity_demo.ipynb in Colab?
Describe alternatives you've considered

Pasting the link manually.
Additional context

It might be helpful to have it for other files too.

Updated all colabs to have 1-click links to launch directly.
Fixed in #181


[Bug] or [Features] az repos policy approver-count

az repos policy approver-count create and update is missing the settings:

First it prevent us from setting it from AZ CLI and if we try to update an existing policy it will reset missing settings that was set from web site or other tools.
Describe the solution you'd like
https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/repos/policy/approver-count?view=azure-cli-latest#ext_azure_devops_az_repos_policy_approver_count_create
and
https://docs.microsoft.com/en-us/cli/azure/ext/azure-devops/repos/policy/approver-count?view=azure-cli-latest#ext_azure_devops_az_repos_policy_approver_count_update
gets a new Optional Parameters
called blockLastPusherVote
Additional context
It would be an idea to change the update to a PATCH request instead of a PUT.
So it does not override settings az cli dont know about.
Note: It require that https://docs.microsoft.com/en-us/rest/api/azure/devops/policy/configurations/update?view=azure-devops-rest-6.0 will be update to support PATCH request.

Is there any update on this issue?
It would be great when this vital functionality would be available!

any news?

Any update on this?


Intersector.intersectSegmentRectangle()

i couldn't believe this method was missing in the awesome Intersector.

Please run the formatter.

@NathanSweet @Darkyenus done

Do we want to handle the segment being completely inside the rectangle? To do that, as a final check we could check if one end of the segment is inside the rectangle (no need to check both ends).

There's also the special case of the segment being parallel to one of the rectangle edges and sharing at least one point in which case it would return false. I guess most times the Intersector class is used to check collsions/overlaps so in my opinion it should return yes. That would also make it consistent with intersectSegmentCircle (which has an open PR (https://github.com/libgdx/libgdx/pull/5098) that requires a review :P)

@NathanSweet i was thinking about that possibility day after the commit, but didn't get myself to fix it. that is done.

I also removed intersection vector argument since intersection point in this context makes no sense.


fix(runtime): fix IE/Edge rendering with SVG containing 'style' elements

ISSUES CLOSED: #163
What kind of change does this PR introduce? (bugfix, feature, docs update, improvement)
bugfix
What is the current behavior? (You can also link to an open issue here)
#163
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
No
Please check if the PR fulfills contributing guidelines

@ghostd great job, thank you! Published as 3.0.9


No way to halt an asock instance

If you launch an asock instance from within a program -- the expected use case -- there is no way to halt it. Or, at least, there is no way to know WHEN it should be halted, especially if the program has been launched as a daemon.

Option 0: Not an option; this should always be done. Your Msgr handler should always be watching for messages 199 and 599. On 199, bail out of your eventloop (or mark that asock is done, etc.). On 599, call Asock.Quit() and do the same.
Option 1: Tell people to implement os/signal handling (call Asock.Quit() on int/kill). They'll also need to write out a pidfile to make start/stop work as expected.
Option 2: Tell people to implement a REPL (doesn't work for true daemons)
Option 3: Add a method which creates an administrative interface for a given Asock instance. This interface will always be a Unix socket with perms 700.
These admin asock instances take dispatch functions of type func (*Asock, [][]byte) ([]byte, error) and get passed their Asock instance which handles their incoming requests, along with the request.
Exactly what this looks like has not yet been determined. Possibly it can be done elegantly; possibly it cannot.

Signal handling is easy, and has been put into the example server.

A REPL makes sense for things which will not be daemonized, and will be written into the docs.

An administrative interface will be split off into its own ticket, targeted at 0.18.


Do not implicitly collect comments when comment attachment is specified

Fixes #1553

Current coverage is 100% (diff: 100%)

Merging #1560 into master will not change coverage

@@           master   #1560   diff @@
=====================================
  Files           1       1
  Lines        3732    3733     +1
  Methods         0       0
  Messages        0       0
  Branches      628     628
=====================================
+ Hits         3732    3733     +1
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update 8badd1d...acaafc5

:+1:


reconnect behavior

Hi---thanks for this project it's been really helped me :smiling_face_with_three_hearts:
I'm using microhomie on an ESP8266 with microhomie v3.0.2. Sometimes my WiFi goes down. Currently when this happens my device goes offline permanently until I manually reset it. I'm hoping to change this so the device periodically tries to reconnect until it finds WiFi again. As a micropython novice I'm struggling a bit to think about how to best do this.
My first thought would be to use a watchdog that I feed when the connection is good, but I see that you explicitly create a wdt task.
Any advice would be appreciated. Thanks again, I'm really loving homie and micropython.

Hi @untzag,
glad you like Microhomie. In Microhomie the mqtt_as module handle automatic recovery from WiFi and broker outages. This works great for my devices so far.
You can activate debug logging for the mqtt_as module. Import mqtt_as into your main and set DEBUG=True:
import mqtt_as
mqtt_as.MQTT_base.DEBUG = True

Thanks @rroemhild, your debugging techniques helped me. The recovery works actually, but at some point after recovering a few times my device runs out of memory. Doesn't seem to have a memory leak during normal operation. I'll have to follow that path now.


script only copy files without make any changes

after running the script /flexipatch-finalizer.sh -r -d ../dwm-flexipatch -o ../my-dwm the following output appears:
awk: line 5: illegal reference to local variable f
awk: line 12: illegal reference to local variable f
awk: line 19: illegal reference to local variable f
awk: line 21: illegal reference to local variable f
awk: line 22: illegal reference to local variable f

Hmm, what version of awk do you have?

This is output of awk -W version
mawk 1.3.4 20200120
Copyright 2008-2019,2020, Thomas E. Dickey
Copyright 1991-1996,2014, Michael D. Brennan
random-funcs:       srandom/random
regex-funcs:        internal
compiled limits:
sprintf buffer      8192
maximum-integer<PHONE_NUMBER>

Ref. https://stackoverflow.com/questions/16921493/awk-illegal-reference-to-array-a retrieving the length of an array is apparently a GNU extension to awk and is not posix compliant.
I just pushed some proposed changes. Could you try this and let me know if there are any other errors?

I made the changes and this is the result:
awk: line 36: regular expression compile failed (missing operand)

Skip duplicates *
awk: line 53: regular expression compile failed (missing operand)
Read patches.h and store patch settings in the patches associative array *

That was painful to investigate.
The errors you saw was because mawk does not support /* .. */ comments, which was trivial to sort out, but I then found that it didn't produce the right output / results.
Eventually I worked out that it was due to a line like this:
			do_print[++level] = do_print[level]

which had to be written like this instead:
			level++;
			do_print[level] = do_print[level-1]

Thanks the problem solved.


The Node zblight does not appear in Node-red dashboard

Hi master,
I have installed contrib-zbling and required packages node-serialport and xbee-api. However after starting node-red the regarding nodes does not appear in node-red dashboard.  Can ypu please advice what is missing ?
I am using Linux in Raspberry Pi2, Node-red and npm:
node -v
v0.12.6
npm -v
2.11.2
The outcome during installation:
<EMAIL_ADDRESS>node_modules/node-red-contrib-zblight
<EMAIL_ADDRESS>node_modules/xbee-api
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS>node_modules/node-red-node-serialport
└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Regards.-

Did you run the commands in your node-red folder? Did you also restart node-red so it would register the new nodes?

Yes, I did
I have restarted several times node-red, reload the RBPi2 and cannot see the Xbee nodes, zblight neither.
The path where run "npm install" is /home/pi/.node-red
Node-red printout show version v0.14.6,
23 Aug 21:36:37 - [info] Node-RED version: v0.14.6
23 Aug 21:36:37 - [info] Node.js  version: v0.12.6
23 Aug 21:36:37 - [info] Linux 4.4.17-v7+ arm LE
23 Aug 21:36:37 - [info] Loading palette nodes
23 Aug 21:36:49 - [info] Dashboard up and running
23 Aug 21:36:55 - [info] UI started at /ui

You will also need to refresh the browser page to get them to show up, in my experience.
The zblight node should show up in the "function" palette.
The serial output node should show up in the "output" palette.
xbee-api does not have a node in node-red, as it is a node.js library that I use to generate the api frames to be sent to the xbee.
Look around in the /home/pi/.node-red folder and see if you can locate the node-red-contrib-zblight folder. You may have to check the settings.js file, and adjust the nodesDir variable depending on your setup.

Ok thank you for clarifying about xbee-api
The update: "serial output" and "serial input" do exist along of input and output palette.
zblight Node doesn't came up yet in "function" pallete. I refreshed several time the browser.
The folder is located as per below, into node_modules dir where are installed other nodes:
rbpi ~/.node-red/node_modules $ pwd
/home/pi/.node-red/node_modules
Details of new contrib:
rbpi ~/.node-red/node_modules $ ls -l node-red-contrib-zblight/
total 532
-rw-r--r-- 1 pi pi  52126 Aug 21 14:36 config.png
-rw-r--r-- 1 pi pi  53955 Aug 21 14:36 flow.png
-rw-r--r-- 1 pi pi  11357 Aug 21 15:51 LICENSE
-rw-r--r-- 1 pi pi  48492 Aug 21 15:01 mqtt-flow.png
-rw-r--r-- 1 pi pi   2156 Aug 21 15:51 node-red-contrib-zblight.html
-rw-r--r-- 1 pi pi   2390 Aug 21 15:51 node-red-contrib-zblight.js
-rw-r--r-- 1 pi pi   1564 Aug 23 21:11 package.json
-rw-r--r-- 1 pi pi   2796 Aug 21 15:09 README.md
-rw-r--r-- 1 pi pi 354618 Aug 21 14:53 xctu.png
settings.js has default configuration, that is, /home/pi/.node-red is the folder where Node-RED will scan to find nodes.
BR.

I don't have a raspberry pi to test with, but I will test with a completely fresh install and see if I can replicate the behavior.

The issue has been fixed with the above commit. Please test and let me know if it works for you.

Hi master,
Now it works, the node come up in dashboard. I saw the small statement was missing. Thank for your support.
BR

Awesome! Thanks for the feedback!


Feature request: aquatone-gather arbitrary input

I've been using aquatone for a while now and I really like the tool!
One of my workflows involves taking hosts from shodan (usually in the thousands) and performing some kind of enumeration on them. It would be super amazing if the gather component of aquatone could take a textfile, of something like host:port as a tasklist for screenshotting. Perhaps the addition of a '-f or --file' input arg to specify some sort of format of input file for processing?

Hi @Viss, this is definitely a feature I'm planning on implementing. Generally I want the different tools to be a bit more flexible than they are now. Until then, I think you can accomplish screenshotting of arbitrary host:port's with Eyewitness, but I'm sure you know that.


Regarding feature for a/c closure

Hi
I am trying to delete my onetimesecret a/c as I will be closing down my email. Please enable this feature in the current online version so I can do the needful.
Thanks
Chnadra

@delano Please help me find the feature to close onetimesecret.com a/c. Thanks

Your account has been deleted

@delano There was another a/c with uname<EMAIL_ADDRESS>Thanks
Chandra


plot instantaneous firing rate instead of histogram counts?

If we divide the histogram counts by the bin width, we can get instantaneous firing rate:
https://jonescompneurolab.github.io/hnn-core/stable/generated/hnn_core.viz.plot_spikes_hist.html#hnn_core.viz.plot_spikes_hist
To me it seems that would be more interpretable, e.g., if there is pathological firing etc. Wdyt @ntolley @rythorpe @cjayb ?

This sounds great to me. In general I think the plotting functions could do with a some improvement with respect to interfacing with matplotlib.
What would be great to add is an optional kwargs** that are passed directly to the plot call. It may be tricky in terms of maintaining the look of certain plots, but I think this address issues in the past with respect to colors and axis limits.

If we divide the histogram counts by the bin width, we can get instantaneous firing rate:
https://jonescompneurolab.github.io/hnn-core/stable/generated/hnn_core.viz.plot_spikes_hist.html#hnn_core.viz.plot_spikes_hist

I agree with this, however, we'll need to be thoughtful about how we calculate spike rates for drive cells, as the spike rate for an evoked all-to-all drive cell that targets all 270 real cells could either be calculated as 270 spikes/time_bin or 1 spikes/time_bin/target_cell. Conversely, the spike rate for a non-synchronous, cell-specific drive cell that connects 1-to1 with a single real cell can only be calculated as 1 spike/time_bin = 1 spike/time_bin/target_cell.

I agree with this, however, we'll need to be thoughtful about how we calculate spike rates for drive cells, as the spike rate for an evoked all-to-all drive cell that targets all 270 real cells could either be calculated as 270 spikes/time_bin or 1 spikes/time_bin/target_cell. Conversely, the spike rate for a non-synchronous, cell-specific drive cell that connects 1-to1 with a single real cell can only be calculated as 1 spike/time_bin = 1 spike/time_bin/target_cell.

Isn't the firing rate independent of the cells it's connected to? So if we're talking about drive cells it would be 270 spikes / time bin / n_drive_cells. Now if it's non-synchronous, you'd have n_drive_cells = 270 and if it's all-to-all, then you'd have n_drive_cells = 1


Provide the same API for gyroscope as in trikRuntime

Without the fix, code that works in TS is not compatible with execution on controller

Download:
Environment: QT=5.12, ARCH=32, CONFIGURATION=release, QTIFW=C:\Qt\Tools\QtInstallerFramework\3.1


Revert "Fixing Re-renders"

Reverts Mirrorful/mirrorful#423

See thread: https://mirrorful.slack.com/archives/C04RR2D7C65/p1684964263981239


When CodeFolding hint is visible, keys no longer work

If you leave the mouse over a code folding hint area, or a code folding hint area ends up below the mouse during the course of code editing, editor keys are no longer active until you move the mouse outside of the hint area

Fixed.


Added package.json and custom support (closes #3)

@hughsk once you merge/accept this - is it possible to share NPM access and collaborator status on the repo since I did such a big rewrite to support this (cleanly) and with tests?
Thanks! 🎉

Also see the Readme here https://github.com/niftylettuce/remark-contributors#remark-contributors @hughsk as I updated that as well in my commit - and you can skim through it easily there.

Lastly, this is legacy and backwards compatible, so you could do a minor bump probably!

Looks good! Will add you to the project too — thanks :)


SMO assemblies prevents dbatools from loading on machine with no SSMS installed

Is this:
Just place "x" to indicate selection (e.g. "[x]")

[ ] feature
[X] bug:

With the ability to now install the sqlserver module separate from SSMS media this alters how the SMO assemblies can be imported for the module. This line of code in the psm1 file is the culprit that has to be dealt with since the assemblies for SQL Server are no longer loaded into the GAC.
The method to load SMO that I can figure out is to go by the path:
add-type -Path 'C:\Program Files\WindowsPowerShell\Modules\SqlServer\21.0.17099\Microsoft.SqlServer.Smo.dll'

Would have to also include any function that references or tries to load a specific namespace as well. Example of this would be Get-DbaXEventSession.
System Details

Operating system name and version: Window Server 2012 R2
Output from $PSVersionTable: 5.0
Output of dbatools version: 0.8.957
SQL Server version for source/target: SQL Server 2014

Steps to Reproduce

"New" server with no SSMS or any part of SQL Server installed.
Run Install-Module sqlserver
Run 'Install-Module dbatools`
Run Import-Module dbatools
Received following error

ipmo : Can't load SMO assemblies. You must have SQL Server Management Studio installed to proceed.
At line:1 char:1
+ ipmo dbatools
+ ~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Can't load SMO ...led to proceed.:String) [Import-Module], RuntimeExc
   eption
    + FullyQualifiedErrorId : Can't load SMO assemblies. You must have SQL Server Management Studio installed to proce
   ed.,Microsoft.PowerShell.Commands.ImportModuleCommand

Expected Results

"New" server with no SSMS or any part of SQL Server installed.
Run Install-Module sqlserver
Run 'Install-Module dbatools`
Run Import-Module dbatools
Module imports.

Not a bug, total feature ;) It's working as intended.
Adding dynamic support for SqlServer assemblies would be a lil bit tricky - the path would have to be figured out dynamically because (Get-Module sqlserver).ModuleBase won't work without importing the module. The module does load in 0.5 seconds which isn't bad, but it's also 400ms longer than importing the assemblies and right now, we're hurting on import speeds. That should be resolved in not this release but the next.

This works fine for me: (Get-Module sqlserver -ListAvailable).ModuleBase

119ms, not bad!

fixed!


add all-brain user story by @jsiegle

towards: https://github.com/xarray-contrib/xarray.dev/issues/344
cc @jsiegle

@andersy005 - any ideas why this is failing to build?

Here are some edits that address @TomNicholas' suggestions: https://github.com/jsiegle/xarray.dev/commit/b5f5ee0753ecaf19754d8b3adfae1770d5afb301

Thanks again for writing this up @jsiegle! It's live here: https://xarray.dev/blog/xarray-for-neurophysiology


Support kubernetes 1.27 and/or update compatibility matrix

Hi,
1.26 is almost EOL:
https://kubernetes.io/releases/
I think it'd be nice to update code and/or CSI Specification Compability Matrix
We are currently running 1.27.
Thanks for your work!

Now We are supporting k8s 1.30


Include time to load by default

Fixes #3.
@Krastanov could you give a quick review? Thanks!
(Also - I need to modify the unit tests)

Thank you for adding this! It looks good to me! The obvious drawback is that it runs a single sample, but the only way to run more samples is to have launch more temporary julia processes. Not sure how worthwhile that is (maybe it is necessary if in the future there is a benchmark for precompile time?)

What do you think about if we were to include a flag --nsamples-load-time, which is default 1 (to keep the default benchmark quick), but could be increased? That would control the number of times Julia is started, in order to record the evaluation time.

Is that doable without very significant refactor!? If so, yeah, I would be eager to use such an option.

Yeah, should be easy!

Done. For example:
benchpkg AirspeedVelocity -r master --nsamples-load-time=5

Then,
benchpkgtable AirspeedVelocity -r master

the table now has an extra entry:

master

main/random_sleep
0.506 ± 0.22 s

time_to_load
2.18 ± 0.0096 s

What do you think? I'll set the PR as ready for review if you are up for it :)

It's also not as slow as I thought it would be. So perhaps we could set the default to, e.g., 5?

I read through the additions. I am not yet familiar with this code base, but nothing bad popped up at me.

Thanks for implementing this. It would be great to use it when merged

Thanks, merging!


Linker missing pthreads on some systems

Trying to build some example models on Arch Linux (gcc 10.2.0), and found that I require an explicit linker flag for -pthread.
Without it, I see errors like this:
g++ -I/home/eric/CARL/include -L/home/eric/CARL/lib obj/SimpleCA3.o -o SimpleCA3 -lcarlsim
/usr/bin/ld: /home/eric/CARL/lib/libcarlsim.a(snn_manager-cpp.o): in function `SNN::resetSpikeCnt(int) [clone .part.0]':
snn_manager.cpp:(.text+0x334): undefined reference to `pthread_create'
/usr/bin/ld: snn_manager.cpp:(.text+0x372): undefined reference to `pthread_join'
/usr/bin/ld: /home/eric/CARL/lib/libcarlsim.a(snn_manager-cpp.o): in function `SNN::doSTPUpdateAndDecayCond()':
snn_manager.cpp:(.text+0x1ad5): undefined reference to `pthread_create'
/usr/bin/ld: snn_manager.cpp:(.text+0x1b1a): undefined reference to `pthread_join'
/usr/bin/ld: /home/eric/CARL/lib/libcarlsim.a(snn_manager-cpp.o): in function `SNN::findFiring()':
snn_manager.cpp:(.text+0x1ca4): undefined reference to `pthread_create'
/usr/bin/ld: snn_manager.cpp:(.text+0x1ce2): undefined reference to `pthread_join'

Adding -pthread to CARLSIM5_FLG in configure.mk fixes it for my system.  But need to text on macOS to make sure this change doesn't break other systems.

Looks like the tutorial examples add -pthread in their local Makefile.  Maybe I was just expected it to be included in CARLSIM5_FLG, but it was never intended to be?

@SigmaX not sure if this is related but in /path/to/CARLsim/CARL/include/configure.mk I changed “-pthread” to “-Xcompiler -pthread” for a work around to avoid a “nvcc fatal   : Unknown option '-pthread'” error. I learned of this method from this source.


Create parser for https://www.santepubliquefrance.fr/maladies-et-traumatismes/maladies-et-infections-respiratoires/infection-a-coronavirus/documents/bulletin-national/covid-19-point-epidemiologique-du-24-mars-2020

Create a web scraper for url:
https://www.santepubliquefrance.fr/maladies-et-traumatismes/maladies-et-infections-respiratoires/infection-a-coronavirus/documents/bulletin-national/covid-19-point-epidemiologique-du-24-mars-2020
This Issue is to create a parser to run  via Prefect.

Country
Organization
data_type
nid

France

Preliminary data available

age data extracted?
cases
cases subnational?
cases by age?
deaths
deaths subnational?
deaths by age?
hospitalizations
hospitalizations subnational?
ICU
ICU subnational
recovered
recovered subnational

The pdf link is no more available in the latest daily report. But we now have access to part of the data used to build this kind of report. If you are ok, I can write a first grabber for getting various data at national level since mid of March. If there is an interest for  getting more detailed (region, department), then it should be possible to reuse preliminary code for matching expectations.
2 main sources of info to be used:

https://www.data.gouv.fr/fr/datasets/donnees-hospitalieres-relatives-a-lepidemie-de-covid-19/
https://www.data.gouv.fr/fr/datasets/donnees-des-urgences-hospitalieres-et-de-sos-medecins-relatives-a-lepidemie-de-covid-19/

Parser is developed and made available with its own method for unit tests. Output is by now written to a local sqlite db. It is made of all records, including past ones. Old dates vary according to the data source.
sqlite> .schema FRANCE
CREATE TABLE IF NOT EXISTS "FRANCE" (
"COUNTRY" TEXT,
"CODE" TEXT,
"NAME" TEXT,
"DATE" TEXT,
"SEX" INTEGER,
"AGE_GROUP" INTEGER,
"TOTAL_CONFIRMED_CASE" INTEGER,
"TOTAL_HOSPITALIZED" INTEGER,
"TOTAL_CRITICALCARE" INTEGER,
"TOTAL_BACKHOME" INTEGER,
"TOTAL_HOSPITAL_DEATH" INTEGER,
"TOTAL_SME_DEATH" INTEGER,
"SOURCE_TYPE" TEXT,
"SOURCE" TEXT
);
AGE, SEX, TOTAL_SME_DEATH fields depend on the the source type.
According to the source type, the information level is at the department, region or country level.


Add support for web

should not be too hard... then we have one tool to rule them all!

Agree. Actually, I was thinking about doing this nowadays too. patata should be smart enough to run it for web without change a single line of code for the developers.


Document page block duplication

Page block duplication enables you to reuse existing page blocks to simplify dashboard creation and reusability.
The documentation should go here

[x] Document how to enable the feature (if any) and how to use it.
[x] Provide a step-by-step example of using it.
[x] Provide some use cases

Original issue https://github.com/cortezaproject/corteza/issues/447

For today: make a plan and begin working on this.

for today: address comments and submit for review

for today: sync with Tomaž on review comments and address them

lgtm; merge it


ci: add Node@14 to azure-pipelines and remove v13

Node.js v14 was out so we need to add v14 to CI and remove v13.
See https://nodejs.org/en/blog/release/v14.0.0/

What kind of change does this PR introduce?
CI

Did you add tests for your changes?
Nope

Does this PR introduce a breaking change?
Nope

What needs to be documented once your changes are merged?
N/A

Thanks


[docs] Fix spelling error in roadmap.md file

[ ] I have followed (at least) the PR section of the contributing guide.

@Brlaney42

It was my pleasure @oliviertassinari 👍


[HOLD for payment 2022-03-02] [$250] Add the ability to configure the distance tracking rate and unit on the Free Plan

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Deliverables

Update the Reimburse receipts workspace page to be titled Reimburse expenses instead

Add a new sub-section to the reimburse expenses page with the header Track distance and the copy: Set the per mile/km rate and choose a default unit to track.
Add the Rate field to allow for the rate to be changed by calling the command Policy_CustomUnit_Update
Add the Unit dropdown to be able to track distance in Miles (default) or Kilometers and allow for it to be changed by calling the command Policy_CustomUnitRate_Update

Platform:
New feature, to be available on all platforms.
Notes/Photos/Videos: Added in-line above. Here is the SVG asset for the car icon: GPS Track.svg.zip
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/181768
Issue reported by: trjexpensify
Slack conversation: https://expensify.slack.com/archives/C03U7DCU4/p1634665726096500
Upwork URL: https://www.upwork.com/jobs/~01143e8c4bd3284e03
View all open jobs on GitHub

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

moving user from the other GH issue
<EMAIL_ADDRESS>https://www.expensify.com/concierge/#/chat/6457965

I guess I'll stick around for the proposals then, since I'm already here.

Proposal
I get 404 on the car icon, so a rocket will have to do for now :)
Desktop
https://user-images.githubusercontent.com/47689923/140427318-e4dce09d-06d0-4752-83d7-9c0d386dee88.mp4
Mobile
https://user-images.githubusercontent.com/47689923/140427928-c4b57159-e83e-4679-aa4f-2568665fe546.mp4

@parasharrajat ?

@marktoman Thanks for taking interest in this job. But the videos you added earlier are not useful to us at all. They did not tell us how you are going to achieve this.
Simply putting a solution video is never considered a good proposal. Also, showing diff does not tell everything we always suggest proposing an approach here not the complete solution. Could you please add an explanation of how you are going to achieve this? You can also look at old proposals from other contributors to get an idea.
Here are a few things I prefer in a proposal.

Not too much detail.
Straight steps.
References to existing code that is going to be affected or causing the issue, etc.
Optional (a video) , helps in getting a visual understanding of some type of issues.

Straight steps:

Add functions to API.js that will call the requested commands over the network.
Add functions, likely to User.js that will call those APIs, handle errors and potentially merge with Onyx.
Add two components to WorkspaceReimburseNoVBAView for Unit and Rate representation according to the image.
Bind the change methods to call the update functions we added earlier to send changed values over the network
Add the requested strings in en.js with the requested keys. Use translate when reading them.
Style the two view components according to the requested image in styles.js.
Add a new icon to components/Icon/Illustrations

No issues expected given it is an addition (well seen in the diffs).

I'll defer to @deetergp for reviewing the proposed solution. In the meantime Mark, can you apply to the job on Upwork as well? Thanks!

@trjExpensify @deetergp Applied.

We are placing all non-critical issues on hold while we're on a company offsite.  The hold is expected to be lifted on 11/19 (but could go longer).  For any PRs that are submitted during the hold, we will add a $250 bonus payment.

In general, @marktoman's proposal looks good. The one thing I'd say needs to be changed is the second bullet, as those update methods should probably be in Policy.js rather than User.js since they are making Policy_*  API calls on the back end. (Workspaces are essentially Policies)

@deetergp Thank you and understood. Should I proceed with implementation?

@marktoman Let's do it!

Perfect. Hired on Upwork! 👍

@trjExpensify Accepted, thank you!

I am still getting 404 for the SVG file: https://github.com/Expensify/Expensify/files/7413560/GPS.Track.svg.zip
Should I create a PR without the icon in a few days, or do you think it will be available by then?

@michelle-thompson @shawnborton any ideas?

Try downloading here: GPS.Track.svg.zip

@shawnborton That works, thanks!

I struggle a bit to understand how this fits into the existing policy concept. When I call loadFullPolicy for the policyID passed to WorkspaceReimburseNoVBAView.js, it already contains two arrays: customUnits and rates. Are the Policy_CustomUnit_Update and Policy_CustomUnitRate_Update commands related to these values? If so, should I just use the values from the first or last elements for the new text fields?

Another thing is that the icon is created for the 100x100px view, but the WorkspaceSection uses 80x80px. Changing width and height on the svg element pushes the icon to the bottom right corner because each path seems to have an absolute value.

For the svg icon, maybe we need to manually scale down to 80x80 and then re-export from there? cc @michelle-thompson - I took a look at the other product illustrations and looks like they were exported at 80x80

Lemme know if this works!
gps-tracking.svg.zip

@michelle-thompson Perfect.

Should I ignore these values? I seem to be missing some info.

Should I ignore these values? I seem to be missing some info.

Do you mean, should you ignore the default values passed with the policy? If that is what you are asking, then the answer is no.

I was referring to my previous question. There is an customUnits array of where each element has an array of rates. Unless I am missing something, there is nowhere specified which element should be associated with the single Rate text field I have added.

Ahhhh, I understand now, thanks for clarifying. 👍
Yes, just take whichever unit is at index 0 for that array as they will only ever have the one rate available to them on that plan.

I see, thanks!

Heya @marktoman, where are we with this one?

Hi @deetergp, if this is a priority, I will do this over this weekend. I think I have all the info.

Hey Mark! This is definitely one of the most requested enhancements to the free plan at the moment, so it would be great if we could square this away please.

@deetergp Where can I find the Policy_CustomUnit_Update API signature? Calling it with policyID and unit returns the following error:
Argument 3 passed to PolicyAPI::updateCustomUnit() must be of the type array, null given, called in /git/releases/expensify.com/cf6d815/api.php on line 1692

@marktoman I am pretty sure it isn't documented anywhere, but that third parameter is the last modified date. Internally when we call Policy_CustomUnit_Update we usually send it policy.lastModified || null. Give that a shot and see if it works.

@deetergp How should the call look like then? All policy calls pass an object to their API methods. I have tried specifying the lastModified property with various values, also multiple values for other properties that I do not know how should be named (just guesses based on the other calls) and always get the exact same error.

Please provide the missing spec. The command name alone with no payload info is not very useful.
If this is a priority task, note that I cannot interrupt my other work anytime I please, hence these delays may compound.

I see what's going on. You need to be passing a JSON object containing the unit data to the API. That JSON is converted to a PHP array before being sent to the method in the error message. I dropped a log line in that PHP api call and changed the the unit on one of our legacy policies and the individual parameters looked something like:
policyID: '004C88207FA3EA60'
customUnit: '{"customUnitName":"Distance","customUnitID":"61ba4fb51e01e","attributes":{"unit":"km"}}'
lastModified: '1639600234184791'

Hopefully that helps?

@deetergp Thanks a lot, that works. Based on the unit logic, I was able to figure out the unit rate structure as well.

@deetergp Please let me know if it does what is required. I will then fill out the QA steps etc.

Hey @marktoman we generally require the testing/qa steps prior to doing the review. Would you please take a moment to fill them out?

👋 Asked for an update on the PR directly, Melvin. It would be great to get this squared away this week, as it has been 2 months since we opened the issue.

Mark updated the PR with testing instructions, but it did not pass testing. Waiting on fixes.

Hi Scott, I have found the underlying issue (see my response on the PR), which is not necessarily related to the PR. Can you check it out?

👋 Hi Melvin, looks like Mark is waiting for feedback from @deetergp on the PR here and we should be good to go. 👍

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.36-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/6839

If no regressions arise, payment will be issued on 2022-02-14. :confetti_ball:

👋 I just tested this and I think we have a problem, @marktoman & @deetergp. The default IRS rate for newly created policies should be 0.585:

Whereas in NewDot this appears as 58.50:

Also, when I change it to 0.585 we revert it back to two decimals in the UI (0.58):

Then when I create a mileage expense with the rate set at 0.58 in the workspace settings, it appears as though the rate used on the expense is 0.0059:

Removing the Awaiting payment label until a fix is up for this, also moved the issue back to Daily as this is on production and going to cause confusion.
For the PR sent to fix it, I think we should add the CP Staging label. Curious for your thoughts on that too, Scott.

Also, when I change it to 0.585 we revert it back to two decimals in the UI (0.58):

Should I change the correction to 3 decimal places?
The other errors do not seem to be related to this issue. After creating a new workspace, I receive the wrong number prior to touching it in any way:

@marktoman I guess we need to allow for the possibility of three decimal places, but only show two when there isn't an expressly stated third decimal.

In other words if it's fifty-eight and a half cents, show it as 0.585, but if it's fifty cents, show it as 0.50 instead of 0.500.

👍

Should I change the correction to 3 decimal places?

On Expensify.com we allow for 4 decimal places, so I think we should do the same here as there will likely be a reason for that in the history of this feature (IIRC, some international territories set their mileage rate allowances at 4 decimals).

The other errors do not seem to be related to this issue. After creating a new workspace, I receive the wrong number prior to touching it in any way:

As for this, maybe @deetergp has an inclination as to what's up here? Just to clarify as well though, setting 58.50 as the rate in the workspace settings does use the correct 0.585 rate when actually creating the mileage expense:

@trjExpensify Is that on production? In my local, if I set it 0.585 it comes back at 0.58 (Although it is actually 0.585 still, behind the scenes) which is a lot closer to being correct and a far cry from 58.50.

@trjExpensify Is that on production?

Yep, Web on prod! Account if you want it<EMAIL_ADDRESS>
if I set it 0.585 it comes back at 0.58 (Although it is actually 0.585 still, behind the scenes) which is a lot closer to being correct and a far cry from 58.50.

Can you follow this through and create a mileage expense on a free plan policy once you've set the rate to 0.58 in the workspace settings. What result do you get? Pretty sure you're going to get this:

Then when I create a mileage expense with the rate set at 0.58 in the workspace settings, it appears as though the rate used on the expense is 0.0059:

Ahh, you're 100% correct @trjExpensify! I tested it locally and see the same results on the OldDot backend. I've addressed the issue here on the PR.

Nice!

Does that make ~cents~ sense?

Top work 😂 👏

This added a few regressions. See here.
@marktoman can you fix them?
@trjExpensify please hold on payment till the fixes are deployed.

Hey all, back from OoO. Just to confirm, we're still waiting on this PR to hit prod for the regression period to count (and the Awaiting payment label will be added?)

Oh, @marktoman @deetergp. Did we lose the currency symbol (e.g $) along the way somewhere inside the rate field like here in the OP mockup and the video from the proposal here? 🤔

@trjExpensify  It shows the currency when the field is blank. The text field component supports the main label (currently Rate) and the blank field label, but not a prefix label (meaning adding a prefix would interfere with the value itself).

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.39-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/7639

If no regressions arise, payment will be issued on 2022-03-02. :confetti_ball:

@trjExpensify It shows the currency when the field is blank. The text field component supports the main label (currently Rate) and the blank field label, but not a prefix label (meaning adding a prefix would interfere with the value itself).

Oh, hm. That's pretty hidden as there's always a default rate populated. @Julesssss @marcaaron @iwiznia, won't we need to be able to support a prefix label in the text field for N7?

I don't know what a prefix label is.

Oh, I see. I assume we will need it if we want to show the currency like that in an amount input.
Having said that, can we achieve this by adding the $ character to the input's value and then not allowing the user to delete it? (thought that can still be weird for things like selecting the contents of the input)

Hmm yeah, that's a bit tricky to handle but I agree it will be necessary. As the BigNumberPad doesn't use a TextInput we have been able to use an alternate solution up to now (create a Unique Text Component for the currency symbol) -- but applying that solution to regular TextInputs isn't simple.
I wonder if we should create an external issue for creating a pre-fixable TextInput component, which allows users to copy only the numerical value. We need to decide first whether the symbol should be selectable or not via copy/paste, because that will drive the eventual solution.

I wonder if we should create an external issue for creating a pre-fixable TextInput component, which allows users to copy only the numerical value

I think this is a good idea.

We need to decide first whether the symbol should be selectable or not via copy/paste, because that will drive the eventual solution.

What are your thoughts here? I think it might be weird if you can select the entire value to copy/paste but can't backspace to also delete it. So with that, I'd probably lean towards not making it selectable?

I think it might be weird if you can select the entire value to copy/paste but can't backspace to also delete it. So with that, I'd probably lean towards not making it selectable?

Yeah, I agree. Let's start with this. Will create an issue.

Sounds good!

Settled!


Early success event from ->publish

This one took me quite some time to figure out. It appears that the object returned by $channel->publish emits the success event unconditionally here, even before the message frame has been written to the socket.
my $message = $channel->publish(
  exchange    => 'pubsub',
  routing_key => 'anonymous.info',
  body        => 'Hello World!',
);
$message->on(success => sub {

  # This actually prevents the message from even getting written to the socket
  Mojo::IOLoop->stop;
});
$message->on(error => sub { warn pop });
$message->deliver;

Of course i assumed i could stop the event loop once the success event had been emitted, which is not the case. That has to be a bug, right?

Should be fixed in 2f7958c


Update lodash to fix CVE-2020-8203

I'm wondering if you would consider merging this pull request and pushing a new version to npmjs.com.
All lodash versions lower than 4.17.20 have some sort of security vulnerability, for example, CVE-2020-8203. Lodash 4.17.20 fixes these vulnerabilities.

Coverage remained the same at 100.0% when pulling f8b8a45c58cb8def033a8c6a81cacb215eb8cd5b on breglerj:lodashfix into 2f3e9a88441a7084f56aedf32c5ec26b5362389d on zeroturnaround:master.

Thanks!

Thanks!

Finally this fix is now released as version 2.3.4

Finally this fix is now released as version 2.3.4


Update for newer IATI tools

We could consider updating this to do checks on:

DSv2
DSClassic
ValidatorV2
iaticonnect
discuss 'archive'

I’ve made a start on DSv2 (the activity and publisher counts, anyway).

With datastore movements it would be good to get iati.cloud and datastore classic monitored asap. (If someone has time)

Yep, agreed. It is a bit confusing at the moment, but Code for IATI managed products are monitored at:
https://status.codeforiati.org
…and secretariat managed products are monitored at:
https://iati-status.codeforiati.org
I think we at least need a link between the two things (easy), or we need to merge them onto a single subdomain (possibly a bit more involved.)


UX Pattern Sample

The link to the UX pattern sample is not working. It points to a VSTS page and I get a 404 error saying I do not have access. Is this meant to be a public link?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c50f3482-ada7-b54a-392f-73b7524cd9dc
Version Independent ID: 36f8730a-c373-b4da-dbbb-917a7ac54235
Content: Dialog boxes in Office Add-ins
Content Source: docs/design/dialog-boxes.md
Product: office
GitHub Login: @o365devx
Microsoft Alias: o365devx

I've made an update to the topic, which should be reflected in the live document later today/tomorrow. I'll go ahead and close the issue. Thank you!


refactor: use one column to constrain instance to u64

In WasmInputHelperTableConfig, it uses 8 columns to constrain u64. We can optimize it to one column with multiple lines.

hi , can i take on this ?


Can't Import json

Hello,
I am trying to import a JSON file in to Obsidian using the plugin, I am following @Josh Plunkett guide on handlebars, and after pressing import, it says "Import Finished" and nothing changes and nothing is showing up and I'm really lost. I tried to search for a solution but couldn't find anything

I'm also adding a photo of the settings I use and the console for reference (the only 2 options not visible in the import settings are the file that I've chosen and the "Import" button)

Also, are you certain that your "Test.json" is in the correct format for the chosen markdown file?
Since you haven't specified a "Field containing the data", the plugin assumes that the top-level of your json file contains an array (or a single top-level object).

In the console on the right, if you change the logging level from "Default Levels" to "All Levels" (or whatever the "all" selection is labelled), then you might see more information about what is happening.

I am indeed using the same format he used in his video, I just switched to "all levels" in the console and I disabled all of the other plugins and it still gives the same message and doesn't do anything

Is it possible to have a copy of your Test.json, so that I can see what the data looks like.

Test.txt
Hi, sorry for the late delay! I have attached the Test file but as a "txt" because github doesn't let me post a json file. but the original is indeed .json

You need to tell the importer where to find the data in your JSON file.
In your case, you will need to set the field "Field containing the data" to the string "spell".
The importer will then look at the "spell" field of the top-level JSON object that is defined in the file.

yesssssssssss it worked!!! thank you so so much!!!


Fix lint warning on unused methods.

What this PR does / why we need it:
address #1453
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
6a812a48bc1af10113f3d6a16c3dac532341efe4
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

circle ci failed so I updated the branch (which wouldn't be necessary with just prow) to see if it passes with new circleci scripts
/lgtm

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b0b97310d18a4608de0777feb6e5e03a93171990
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jmuk https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1672/istio-presubmit/3244/ fails with gencode check-in checks.

This is weird, I don't see mixer/template/authz things reported in the log. Maybe somethings are out-of-sync?  Please rebase with the master.

I don't see anyone referring to mixer/template/authz things around this PR; so here's the theory: presubmit bot keeps bazel-genfiles among the builds, and ./bin/bazel_to_go.py collects the autogen files from that directory; as the consequences, some unrelated PR can cause this problem on other PRs randomly?  cc: @yutongz
For the meanwhile, I'll create a PR to remove the presubmit failure.

/retest

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b0b97310d18a4608de0777feb6e5e03a93171990
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@xiaolanz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
b0b97310d18a4608de0777feb6e5e03a93171990
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Updating the BUILD file would have been good.

Yeah, I just saw that. I've got a PR to fix that.
On Wed, Nov 15, 2017 at 6:32 PM, Sebastien Vas<EMAIL_ADDRESS>wrote:

Updating the BUILD file would have been good.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/1672#issuecomment-344796417, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVucHSRtS8stSHkklSHGE6Np-3zKBV_3ks5s257DgaJpZM4QaL2f
.

@geeknoid @sebastienvas QQ: without the BUILD file change (which is not fixed by @geeknoid's followup commit) any idea why this was not a build failure and the presubmit logs didn't catch it. . It seems such changes should have been caught easily via some simple gate keepers.

I fixed it in my PR. @guptasu that's a good question. Do we call bazel run //:gazelle at some point in the script? That would have fixed it. I think that presubmit is very complicated, we should be calling bazel build //.. If not I have no clue.

@sebastienvas Let's take this outside this PR, we can investigate this tomorrow. I do see we are running bazel build //..., However I am not sure why we are not failing the build.


Bump Hex package manager to 2.0

Is there an existing issue for this?

[X] I have searched the existing issues

Code improvement description
We had to hold back the Hex package manager to 1.0.1 in https://github.com/dependabot/dependabot-core/pull/6006 due to compiler errors, for example https://github.com/dependabot/dependabot-core/actions/runs/3363786929/jobs/5577382297:
** (CompileError) check_update.exs:77: Hex.Version.InvalidRequirementError.__struct__/0 is undefined

At some point we need to update Hex to 2.0.0 and fix that compiler error.
Going forward, even after the upgrade we should probably continue to pin Hex to avoid these unexpected surprises.
We should also move where it's pinned to a more intuitive location: https://github.com/dependabot/dependabot-core/pull/6006#discussion_r1009986747

You can use Version.InvalidRequirementError directly from elixir instead of Hex.Version.InvalidRequirementError

@jeffwidman Seconding the comment from @tiagoefmoraes, Hex doesn't have a public API, and you should use the official InvalidRequirementError.

Thanks!
Do either of you want to submit a PR? Since it's just the location of a type, should be very straightforward... the bumping Hex version and changing the pinned location can be done as a separate PR.
No worries if not interested.

Related fixes:

https://github.com/dependabot/dependabot-core/pull/6028
https://github.com/dependabot/dependabot-core/pull/6037
https://github.com/dependabot/dependabot-core/pull/6026

I think I have all the current tests passing: https://github.com/dependabot/dependabot-core/pull/7890

Got the last few stragglers


beg for the answer of the code injection exercise!

The code injection is left as an exercise for the reader. 哭

Please see the answer to #4

Here is a ready to use library for injecting FLEX into 3rd party apps:
https://github.com/dtrukr/FLEX_injected


(schinese) better CN ACHIEVEMENT

Complete the remaining untranslated text
According to the English text, part of the misplaced translation text was adjusted
The text symbols of achievements are spaced to improve the visual perception
Characteristic vocabulary more in line with the Chinese context
Unify the text meaning and text format throughout the achievement

nice, Pass the achievement check once.  (╹ڡ╹ )
and Finish translating the rest of the new achievements tomorrow


Logon Token is Empty - Cannot login

for get-platformdetails.ps1, getting
"Logon Token is Empty - Cannot login"

going against version 11.4

Hello @BrogieB ,
This error can result of several things
Please see #26  or #41  that had similar issues
And also make sure you are using a valid SSL certificate and the correct TLS settings
Let me know if that helps,
Assaf

Hello @BrogieB ,
Any update?
I am closing this issue for now, but feel free to re-open if problem was not resolved
Regards,
Assaf

& ./Accounts_Onboard_Utility.ps1 -PVWAURL "<IP_ADDRESS>/PasswordVault" -Delete -CsvPath "./CyberArk Cleanup non-operational - Copy.csv"
Hey all, I have done it until Password Vault but face this issue:
Error Message: Unable to connect to the remote server
Exception Message: Unable to connect to the remote server
Status Code:
Status Description:
Get-LogonHeader: Logon Token is Empty - Cannot login
At C:\path\Accounts_Onboard_Utility.ps1:1198 char:3

    Throw "Get-LogonHeader: Logon Token is Empty - Cannot login"

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : OperationStopped: (Get-LogonHeader... - Cannot login:String) [], RuntimeException
FullyQualifiedErrorId : Get-LogonHeader: Logon Token is Empty - Cannot login

Although I get prompted to sign on and enter my login information.


Allow user to set a gnomad allele freq threshold for filtering

maximum_population_allele_frequency is used to filter variants with GNOMAD allele frequency > than this value.  The default is set in detect_variants to 0.001.  If a variant has gnomad_field_name > this value, it gets filtered out.
https://github.com/wustl-oncology/analysis-wdls/blob/16eb3925223ca4bd47f6a5282c219fa981d187eb/definitions/detect_variants.wdl#L65
https://github.com/wustl-oncology/analysis-wdls/blob/16eb3925223ca4bd47f6a5282c219fa981d187eb/definitions/subworkflows/filter_vcf.wdl#L16
https://github.com/wustl-oncology/analysis-wdls/blob/16eb3925223ca4bd47f6a5282c219fa981d187eb/definitions/tools/filter_vcf_custom_allele_freq.wdl#L6
BUT, this parameter is not exposed up to the pipelines.  We would like to be able to set this in immuno.wdl.
One use case would be to essentially turn off GNOMAD filtering by setting: immuno.maximum_population_allele_frequency: 1.

Closing this issue which has now been resolved by the PR above.


HBASE-23997 Consider JDK11 in our support matrix

Add a section calling out our categorical lack of support for
non-LTS Java versions.
Provide clarification as to the meaning of the 'red x' in our
support matrix.
Transpose the support matrix to have HBase releases along the x-axis
and Java releases along the y-axis, because there are more Java
releases than HBase release categories.
Update the JDK11 status in the matrix.
 U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 49s
master passed

+0 :ok:
refguide
7m  8s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 35s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
7m  5s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

26m 24s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1844

Optional Tests
dupname asflicense refguide

uname
Linux<PHONE_NUMBER>a7 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master /<PHONE_NUMBER>

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
78 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Rebased, and attempted to address all comments.  U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 42s
master passed

+0 :ok:
refguide
4m 48s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
4m 53s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

19m  1s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1844

Optional Tests
dupname asflicense refguide

uname
Linux 22472843d9eb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 61a7468df7

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
78 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@busbey

the intro paragraph explains the warning sign designation but it is not used at all

Oh you're right. Since I pulled out the non-LTS releases, that category is unused. I could drop it entirely, I suppose, or redefine it.

jdk11 has a green check mark, which is explained as an expected deployment type, but then has a note that describes limitations to the readiness that sound a lot like the explanation of the warning sign / yellow designation. why not just list it as warning sign / yellow and keep the same note that explains why?

That would be fine. I think that since the defined meaning of yellow/warning is not used, we can use this indication for this purpose instead.

do we still need to list jdk6 if it is a no everywhere? The intro paragraph could just say "if a version is not listed you should assume it is (x)". e.g. we don't list jdk 1.5 or 1.4 but I don't think anyone is expecting us to.

Existing content mentioned JDK6, so I preserved it's mention.  U: .

 U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m  9s
master passed

+0 :ok:
refguide
5m 28s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 47s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+0 :ok:
refguide
5m 33s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

22m  7s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1844

Optional Tests
dupname asflicense refguide

uname
Linux d253de291117 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 89b7b5a7f9

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
65 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1844/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Latest and final version of smash bros issue (V13.0.2)

The skin selector no longer shows up on the latest version of smash making you unable to manually import skins (or use the mod at all). This mod is sadly permanently dead until/if the mod creator ever comes back. Goated mod while it lasted, GG's.

Use the relase from the fork, works for me https://github.com/TheDrawingCoder-Gamer/smash-minecraft-skins/releases/tag/2.0.0

Use the relase from the fork, works for me https://github.com/TheDrawingCoder-Gamer/smash-minecraft-skins/releases/tag/2.0.0

Does this work with 13.0.3?

Yes


Doesn't produce any output.

The simplest configuration doesn't produce any output when used as is.
Entrypoint is set at lib/index.ts,  dtsPlugin() is being called "as is". There's no way to debug this fuckery around to see why is it not emitting anything.

Lets try and stay positive about this, no need to be angry.
Would you be able to share a reproducable example of this? All of my tests pass fine. I will do some debugging of my own in the meantime to see if I can find the issue.
In reference to your debugging comment - I have wanted to overhaul the logging and commenting for a while. I will add a debug log level throughout the plugin when I get some time outside of uni.

Closing as there is no more info, please reopen when you create a reproducable example


Allow GROUP BY on arrays wrapped in scalar functions

4c754ad666 made the validation a bit too strict and broke GROUP BY on
scalar(array_col)

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4aa49e4). Click here to learn what that means.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##             master    #5893   +/-   ##
=========================================
  Coverage          ?   82.92%
  Complexity        ?    12137
=========================================
  Files             ?     1425
  Lines             ?    46479
  Branches          ?     5730
=========================================
  Hits              ?    38544
  Misses            ?     5255
  Partials          ?     2680

Impacted Files
Coverage Δ
Complexity Δ

...rate/analyze/validator/GroupBySymbolValidator.java
85.71% <81.81%> (ø)
4 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa49e4...d03bbcc. Read the comment docs.


Adding sourrce and homepage(modrinth) links to fabric.mod.json

completely forgot to do this, thanks :)


APIM : Publish updated functionApp

Azure documentation issue guidance
https://docs.microsoft.com/en-us/azure/api-management/import-function-app-as-api
Azure Resource

Azure API Management
Azure Function

Bug details - Technical Issue
When FunctionApp a that is hosted on APIM is either recreated or URL update, the functionApp is not updated therefore returning unauthorized status. Inorder to do the reconnect, APIM does not allow to update backend functionApp but pops up logicapps view (seems like a bug)

For now, we just create it all new.

@mikebudzynski Any inputs in this ?

@koushik984 Since this channel is for driving improvements towards MS Docs. For any product related question/issue, I would recommend you to create a thread on the forums- MSDN / Stackoverflow. Once you post your issue on forums, it will have visibility across the community which is a better suited audience for such types of issues.

@koushik984 For now I will proceed with closure of this . Since this channel is for driving improvements towards MS Docs. For any product related question/issue, I would recommend you to create a thread on the forums- MSDN / Stackoverflow and If there are further questions regarding this doc, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


duplicated 'Proof of Transfer' on side nav

Lets see if I can figure out the routing code to fix this duplicated

Fixed by #1272


Fix the Gallery python test script

References #60
[ ] - Gallery python test script is currently not written to be compatible with Pytest (fixture error)
[ ] - Rewrite the test module in a similar format to test_polybasis2d.py or test_mgm_abstract.py.

adjusted the Gallery Test Script

[t:10]