LitElement prevents event bubble on polyfilled browsers

Description
If an event is dispatched by a LitElement child it cannot be caught by a parent LitElement which is listening for that event.
=> only happen for LitElement on polyfilled browsers
=> HTMLElement works fine also on polyfilled browsers
Live Demo
https://stackblitz.com/edit/lit-element-event-bubble?file=index.html
Steps to Reproduce

Have a LitElement parent that listens for an event
Have LiteElement child that fires an event
Use a polyfilled browser

Pro Tip: use Firefox ESR to test a polyfilled browser: https://www.mozilla.org/en-US/firefox/organizations/
Expected Results
The events can be caught by a parent
(the same as it works when using HTMLElement)
Actual Results
The event never gets caught
Browsers Affected

[x] Firefox 60
[x] Edge
[x] IE 11

Versions

lit-element: v2.1.0
webcomponents: v2.2.9

You have a slightly different sequence of operations between the LitElement and native implementations of components.
In native, you're doing:

Parent connectedCallback
Parent addEventListener
Parent render
Child  connectedCallback
Child dispatchEvent
Child render

In LitElement:

Parent connectedCallback
Parent render (via super.connectedCallback())
Child  connectedCallback
Child render (via super.connectedCallback())
Child dispatchEvent
Parent addEventListener

You can see that the child fires the event before the parent listens for it. There's an easy fix: add the event listener before rendering:
in LitParent:
  connectedCallback() {
    console.log('lit-parent setting up Registration Shop')
    this.addEventListener('foo-register', ev => {
      this.litChildren.push(ev.detail.el);
    });
    super.connectedCallback();
  }

You can also add the event listener in the constructor.
Hope this helps!

I'm afraid that the suggestion is not correct? I tested it before as it was my first idea as well - so without any code changes, you will see this in the console
lit-parent setting up Registration Shop
lit-child wants to register
native-parent setting up Registration Shop
native-child wants to register

=> so the addEventListener is before.
I still tried the suggestions
in the construction
https://stackblitz.com/edit/lit-element-event-bubble-constructor?file=lit-parent.js
=> console log fires in the same order
=> no change... e.g. does not work
in the connectedCallback
https://stackblitz.com/edit/lit-element-event-bubble-connectedcallback?file=lit-parent.js
=> console log fires in the same order
=> no change... e.g. does not work

This doesn't FIX anything, but is important for testing a fix as I couldn't get FFESR to update at all, at boot time or later in the page lifecycle.
Don't forget to use:
  static get properties() {
    return {
      litChildren: {type: Array}
    }
  }

and:
this.litChildren = [...this.litChildren, ev.detail.el];

Not sure how Chrome is triggering a render with this set up? 🤔

This is very confusing. The event appears to not be firing at all. FF doesn't have an event breakpoint either.

@Westbrook as lit rendering is async the event listener and the event dispatch happens before the first render => I added a this.requestUpdate(); just in case
@justinfagnani yes it's suupper strange... it seems like the event is not even bubbling at all 🙈
even if I put the HTMLElement version in the LitElement parent and the other way around it doesn't help ... apparently, neither event listening nor event dispatching works => I'm so confused right now 🙈

ok I think I have a lucky shot.... but I am sooo confused whyyyy?
https://stackblitz.com/edit/lit-element-event-bubble-solution?file=lit-parent.js
putting it like this in lit-child
  connectedCallback() {
    super.connectedCallback();
    requestAnimationFrame(() => {
      console.log('lit-child wants to register');
      this.dispatchEvent(new CustomEvent('foo-register', {
        bubbles: true,
        detail: { el: this }
      }));
    });
  }

and it works... funny thing it does NOT change anything on the order of addEventListener.... so the console log order for lit is still the same
lit-parent setting up Registration Shop
lit-child wants to register

but somehow it now bubbles????
maybe it has something to do with the polyfill? but why is ONLY a problem for LitElement and not HTMLElement?
how can a requestAnimationFrame "enable" bubbling?
anyone got any answers?

@justinfagnani any idea why an animation frame saves the day for lit-element? should not be needed right?

There's definitely an issue here. It's probably related to the ShadyDOM polyfill, but it's unclear why the non-lit-element works correctly. We're investigating.

Here's what's happening. The ShadyDOM polyfill currently does not correctly bubble events fired from nodes that are not selected into a shadowRoot <slot>. These nodes are ejected from the real DOM tree and since ShadyDOM relies on native event dispatching, bubbling does not work as expected. LitElement asynchronously renders content into its shadowRoot; however, it constructs its shadowRoot synchronously when the element is created. So, the lit-child is constructed and connected and fires the event while it is outside the dom tree containing lit-parent and its empty shadowRoot.
There are some options for fixing this, but doing so is a high priority. We're going to look at fixing event propagation for undistributed elements within the polyfill. This may be difficult and we're also considering making LitElement create its shadowRoot when it first renders into it, which should also address the issue.

we're also considering making LitElement create its shadowRoot when it first renders into it

This would break some code that expects renderRoot to be available just after element creation

This would break some code that expects renderRoot to be available just after element creation

Yeah, we wouldn't do that without careful consideration, but we consider this a serious issue that should be fixed. Do you have a use case for using renderRoot after creating but before first update?

Do you have a use case for using renderRoot after creating but before first update?

Yes. In production:
Delegating events:
     constructor() {
      super();
      const events = this.constructor.__events;
      if (events) {
        events.forEach(({ eventName, selector, listener }) => {
          delegate(selector ? this.renderRoot || this : this, eventName, selector, listener, this);
        });
      }
    }

Should be fixed when this ShadyDOM issue is addressed: https://github.com/webcomponents/shadydom/issues/324

I just have been bitten by this again 😭
any progress on it? or anything I can do to help?

this breaks mocha tests unsing chrome headless. I can test the same exact functions manually in chrome and the all of them work, but element.addEventListener is never triggered in mocha/chai.
if I do this.renderRoot.dispatchEvent suddenly everything works

Any update on this? Ive got issue in IE 11, when working with Polyfill and LitElements.
When my child element inside a slot component is dispatching the event, parent element is not getting this CustomEvent at all.
As Workaround I've made doucment.body listener for this case as well as disptaching this event on body, but it should work as in chrome does, I guess.

    _beforeRender() {
        this.dispatchEvent(new CustomEvent('test', {
            bubbles: true,
            detail: {key: 'test'}
        }));
    }
    protected render(): TemplateResult {
        console.log('render child');
        this._beforeRender();

        return html`

Child!

        `;
    }

I am not sure why, but it seems that in IE eventlistener is ready after the parent element (element where eventlistener is registered) is rendered in to the dom. In chrome it does not matter, events are handled even before.
<parent-element>
    <child-element></child-element>
</parent-element>

For such a construction I'm getting output like that after I'm dispatching Event inside render function of child:
constructor parent
connectedCallback parent
constructor child
connectedCallback child
render parent
firstUpdate parent
render child
[event handled here]

Is that expected behavior? Is there a way to delay render of child element somehow?

@justinfagnani @sorvell what's the current priority on this? We want to work on things like dependency injection and context API, but that's not possible due to this issue.

After a lot of tinkering, I was able to find a relatively clean solution by bypassing shady dom and temporarily creating a proxy node to fire the event:
const { appendChild, removeChild } = window.ShadyDOM.nativeMethods;
const event = new Event('foo', { composed: true, bubbles: true });
const proxy = document.createComment('');

appendChild.call(this.parentNode, proxy);
proxy.dispatchEvent(event);
removeChild.call(this.parentNode, proxy);

LitElement's async rendering isn't really the issue here, the issue is that shady dom doesn't append unslotted elements to the DOM. So even if LitElement would render synchronously, it would still not be correct for situations where an element would never render a slot.
Fixing this properly in the polyfill is pretty hard, and for my use case I don't actually need the element itself to be in the DOM I just need to be able to send an event.
See it in action here: https://jsbin.com/zocicoyole/edit?html,output

Hi all, this should be fixed as of<EMAIL_ADDRESS>(https://github.com/webcomponents/polyfills/commit/34a3d9104a8a4a7a2b4db2ce726cc498be6824a1). If you're still experiencing this issue after upgrading, let me know here and I'll reopen.


Add libtock_runtime startup code.

This includes:

rust_start: The first Rust code to run in a process
set_main!: Used to specify main in a process binary
stack_size!: Used to specify the stack size in a process binary
Documentation of the startup sequence, including the 3 above steps.

The documentation refers to a two things that haven't been implemented yet:

Debug syscalls performed by rust_start -- unimplemented because memop is
still unimplemented.
The exit system call.

bors r+


How to show image in chat message view?

I want to share images to partner. I see that ChatMessageView can display the images. But I cannot find the method where I can pass the image to ChatView or MessageView. Please help me!

Please refer to the following document.
https://github.com/bassaer/ChatMessageView/wiki/Picture-Message
Thanks.


Cache missing JDK and Add migration recipes

Related to Issue #120 Discussion #119
Changes made:

Caches JDK by downloading and extracting temurin binaries from GitHub based on OS, if the required JDK is not present in the system. (maybe we can also add options to get JDK paths, if it is present in different location?)
Added migration recipe to upgrade java to 17 to check the viability of new changes (will add more migration recipes later)

Tested the new recipe with some plugins. Not all plugins are successfully migrated, need to cover the edge cases too.
What can we do now?
Now the tool can compile plugins with older JDK versions, if the JDK not present, then it caches it in {user.dir}/.jdks/ (directory used by IntelliJ IDEA to store temurin JDKs), followed by executing the runOpenRewrite() fn with JDK 17.
What else?
Right now I hard coded the java version in the getJdkPath(), need to figure out a way to get opt JDK version to compile each plugin.
Other suggestions and improvements are welcomed
Testing done
Interactive testing only.
Manually tested the caching process in Windows and Linux environment.

Submitter checklist

[X] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[X] Ensure that the pull request title represents the desired changelog entry
[X] Please describe what you did
[X] Link to relevant issues in GitHub or Jira
~- [ ] Link to relevant pull requests, esp. upstream and downstream changes~
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Thanks. Let me know when you are ready to merge this PR

Hey @jonesbusy, I think this PR is ready to merge, we can use enums when resolving #153.
Thanks!


bslizr: 1.2.4 -> 1.2.6

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/BSlizr/versions.
meta.description for bslizr is: "Sequenced audio slicing effect LV2 plugin (step sequencer effect)"
meta.homepage for bslizr is: "https://github.com/sjaehn/BSlizr"
Updates performed:

Version update
Quoted meta.homepage for RFC 45

Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/53dd796c71ebbafeef5f1806cc1b70bd

du listing: https://gist.github.com/a6101c0d5240592d4520d4618d1e0e91

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
bslizr

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bfhjdxfhi4s71qjign7j7aq3s5nwf8mg-BSlizr-1.2.6 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bslizr https://github.com/r-ryantm/nixpkgs/archive/7bd655495181b8dc08eda99eb3ed5d39b99cf87e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bfhjdxfhi4s71qjign7j7aq3s5nwf8mg-BSlizr-1.2.6
ls -la /nix/store/bfhjdxfhi4s71qjign7j7aq3s5nwf8mg-BSlizr-1.2.6/bin

cc @magnetophon for testing.

Result of nixpkgs-review pr 85052 1

1 package built:
- bslizr


Add ES module support to leverage code splitting and tree shaking

The purpose of this PR is to add an option to export the ejs template as an ES6 Module in order to leverage Code Splitting and Tree Shaking. This is pretty important to a lot of people who are still using legacy ejs templates, but want to optimize their bundles.
There were a few things I had to change to get this to working:

Why is variable required: When lodash or underscore templates are instantiated without a variable option, a with statement is used. This violates strict mode and fails compilation.

Why not use a default? What makes using a default difficult in this case is the template needs to know the variables being passed into it. In order to likely do something like this, we would have to change interpolation settings. This seems to be a lot of effort to go through to support a default case. We could set a default and not handle the context, but my fear would be that the template compiles find at build, but fails at runtime, which could be risky.

Not being able to leverage requireFromString. Since requireFromString only supports for module.exports, I had to get creative with parsing export default for ES Modules. Since I could not find a solution that already handles this, I wrote a RegExp that removes the string and creates a new function/

Please see #41 for commit  814bcc5. And please let me know if there is anything you all would like to see improved or changed :smile:

@difelice thanks for taking a look at this! I figured we would likely look at the https://github.com/difelice/ejs-loader/pull/41 first because there is an important commit we need in there that will break the options if none passed that I didn't update this branch to have yet 😅. I will update https://github.com/difelice/ejs-loader/pull/41 to rebase out the first commit and just include https://github.com/difelice/ejs-loader/pull/41/commits/83e79a6a1f49d361115f3db7939f1637d03f2e4a


[hotfix] Removing automount share folder and replacing with manual mount...

This pull request closes #289 issue.
Currently the VirtualBoxGuest Additions automatically mount the shared folder and applies a umask on shared files, it modifies its implementing permissions, eventually modify the files added to the package.
This PR solves this problem by disabling the process of automount and replaces it with a script that is performed after the virtual machine becomes available.

LGTM on OSX


DAAG not on CRAN

When installing the DAAG R package I get the following error:
> install.packages("DAAG")
Installing package into ‘/home/azureuser/R/x86_64-pc-linux-gnu-library/3.6’
(as ‘lib’ is unspecified)
Warning in install.packages :
  package ‘DAAG’ is not available (for R version 3.6.2)

CRAN tells me that this package have been archived on January 11, 2020. Please update the page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f89940a-4eac-f1ff-99a7-8fcc47b70482
Version Independent ID: 52be38c9-5450-42fc-b44f-1189b45b7838
Content: Tutorial: Your first ML model with R - Azure Machine Learning
Content Source: articles/machine-learning/tutorial-1st-r-experiment.md
Service: machine-learning
Sub-service: core
GitHub Login: @revodavid
Microsoft Alias: davidsmi

@beritatscioplus Thanks for the question. We are investigating the issue and will update you shortly.

@beritatscioplus Thanks for the feedback. I could see this package has been archived as shown in the CRAN.

So you can try the following to install DAAG.
url <- "https://cran.r-project.org/src/contrib/Archive/DAAG/DAAG_1.22.tar.gz"
destfile <- "DAAG_1.22.tar.gz"
download.file(url = url, destfile = destfile)
install.packages(pkgs=destfile, type="source", repos=NULL)
unlink(destfile)
library(DAAG)

@beritatscioplus We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Plugin works really slow

Every time I press on a collection, I'm waiting for second or two until information will load.
You can see this lag on the provided image:

Can we hide this table with information and don't load it until it's appeared?

Hi,
Thanks for reporting this performance issue. I will work on it ASAP (background thread probably).


Training domain specific language model from scratch

Hi,
I want to build domain specific language model for NER task. For example, hugging face allows us to create masked language model or sentence prediction language model in unsupervised way for our own corpus.. which can be extended for NER task. Can we do something like it with spacy?

I think I've answered on the other issues you commented on, so ill close this one


\Discord\Parts\User\User::getAvatarAttribute() returns NULL

\Discord\Parts\User\User::getAvatarAttribute() returns NULL
OS: win10

ah my bot doesnt have a Profile picture please add default.


Improve perf summary filtering, add rosenbrock perf job

This PR should decouple our performance summary from individual benchmark jobs by adding a flag for opting into the perf summary, and this is what we use for filtering out which jobs to collect information for. This should make it easier to merge #991, for example.

bors r+

bors r-

bors r+


Fix RPath

Follow up on #38

@stopiccot Could you please have a look at the RPath discussion at the end of #38 and give some input?

Why closing this? I still think that we should not set rpath.

Sorry, I must have mixed up this with something else :-)

PR is welcome :-)

I think the patch by @a-detiste in #38 looks good?

Hi,
I had completely forgotten about this, but with a fresh mind it sill seems the right thing to do.

Thank you @a-detiste !


Add commands to HL Burrow integration

Signed-off-by: Ayush Jalan<EMAIL_ADDRESS>

Description of the Change
'CreateAccount' and 'AddAssetQuantity' commands have been added in HL Burrow integration
Python scripts and contracts to run the commands have also been added

Benefits
It will extend HL Burrow integration into Iroha, which can change and query the iroha state using EVM

Usage Examples or Tests [optional]
Examples are added under example/burrow_integration

About tests - comment from Iroha Core Team: tests are not required in c++ code, but should be coded in Python:

To fix DCO please git rebase main --signof then git push --force-with-lease

To fix DCO please git rebase main --signof then git push --force-with-lease

This PR has been copied because of some git/github problems into new one with all changes:
https://github.com/hyperledger/iroha/pull/1152
@Ayush-Jalan I think You can close the old PR.

This PR is continued in PR#1152


Assembly search path in NSpecRunner

When using f.e. serialization in NSpecRunner, types from own assemblies cannot be resolved. To reproduce: http://pastie.org/3550232

I don't believe this is an assembly resolution issue.
The test failure is: nspec. describe failing deserialization. when serializing objects. that are not in the search path. should deserialize them again. Context Failure: Type 'ErrorTests.describe_failing_deserialization+MyClass' in Assembly 'ErrorTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' is not marked as serializable., Example Failure: End of Stream encountered before parsing was completed.
The key piece being: Type 'ErrorTests.describe_failing_deserialization+MyClass' in Assembly 'ErrorTests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' is not marked as serializable. <---- this is the issue it seems
Marking the class MyClass as serializable resolves the issue (please let me know if this is accurate):

class describe_failing_deserialization : nspec
{
    void when_serializing_objects()
    {
        var stream = new MemoryStream();
        var bf = new BinaryFormatter();

        act = () => bf.Serialize(stream, _object);

        context["that are not in the search path"] = () =>
        {
            before = () => _object = new MyClass();

            it["should deserialize them again"] = () => // fails
            {
                stream.Position = 0;
                bf.Deserialize(stream).should_cast_to();
            };
        };

        context["that are in the search path"] = () =>
        {
            before = () => _object = new object();

            it["should deserialize them again"] = () =>
            {
                stream.Position = 0;
                bf.Deserialize(stream).should_not_be_null();
            };
        };
    }

    object _object;

    [Serializable] //Class is marked as serializable fixes the test
    class MyClass
    {
    }
}


Update advanced-raid-tracker

Fix Performance issues on longer raids by not redrawing unless window open and tab active

Please don't open multiple PRs, keep your changes in one PR.
I see that your previous PR was closed due to deleting your repo, if you are unsure how to resolve these type of conflicts outside of deleting a repo, I would suggest using branches and not making your changes from the master branch, that way the master branch is always clean and you can cleanly create new branches from it, preventing future conflicts.


Check for updates and show version information

Please explain the problem/why you would want to see a change and any workarounds you might have in place.

It shouldn't be right in-your-face but the app should show the current version and update information on run. We'd need to be less trigger-happy with our release schedule so people won't get annoyed, but this gives people the feeling that this application is maintained and modern.

The .blockmap file and electron-builder in general allows automatic updates with deltas. This would be great to implement.

I don't know how many subscribers or viewers this Issue has, but this is unlikely to be implemented until after November. Just a heads up. Development will start again in December.


Conditional transitions/actions

How to ensure that they would eventually be run?

Probably better to just have an if inside the actual action/transition function and return unit if undesired. Still leaves the question of how to get them to run eventually


Enhance range queries performances

Right now, range queries performs linearly with the number of keys in a
bucket: that is, a full scan of all bucket keys is needed.

We may enhance range queries performances without too much complexity
increase by:
1) On requesting for the first time a range query over a bucket, create an
index snapshot of all bucket keys and maintain it on the local node memory.
2) Execute the query over the index.
3) At every subsequent query, execute it on the same snapshot unless a
refresh is requested.

There are obviously a few drawbacks:
1) Indexes only reside on the main memory of the node they have been
created in, so they do not survive node restarts and are recomputed if the
range query hits another node.
2) Indexes are not updated on add/update/delete operations, so you could
get stale data.

However, keeping local, volatile, index snapshots avoids lot of complexity
(and probably lots of performance overhead) while enabling far better
performances on what is IMHO the most common use case for range queries:
read-intensive, stale-data tolerant, applications.

Feedback is highly welcome.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 27 Nov 2009 at 4:55

Original comment by<EMAIL_ADDRESS>on 27 Nov 2009 at 4:55

Added labels: Type-Enhancement, Priority-Medium

Original comment by<EMAIL_ADDRESS>on 30 Nov 2009 at 12:25

Changed state: Started

It is going to work this way:
1) Range queries carry a timeToLive value (in miliseconds) which clients use to
request a query with data not older than the given value.
2) Terrastore computes a new sorted snapshot of current bucket keys if no
snapshot is
found or if the current snapshot is older than the requested one. If a valid
snapshot
is found, it will be used.
3) The snapshot is stored on the local node main memory and the range query is
actually executed.

This way, range queries performances get a big enhancement because executed
over a
sorted snapshot of keys.
The snapshot is backed by a TreeMap.

Original comment by<EMAIL_ADDRESS>on 30 Nov 2009 at 1:11

One thing im not clear on: is it guaranteed that a complete bucket will be in
one
server?  if not then i seems like the snapshot will need to be available to the
cluster, unless you are making an assumption that the caller will have some
type of
routing algorithm so they map back to the same node.  If they dont it might be
more
work then benefit.  I say that because it the cache is only used in frequently
and
the data is relatively volatile then the cache will invalidate at a higher
rate.  but
if the caller returns to the same node then the L1 can be updated and reused.

Why not use a ConcurrentSkipListMap?

Please let me know where my understanding is flawed.

Original comment by<EMAIL_ADDRESS>on 1 Dec 2009 at 6:01

Regarding the first question, the ordered snapshot of all bucket keys is
completely
held in the local memory of the node: clients asking to that given node will
find the
complete snapshot on subsequent queries without having to recompute it; such a
snapshot is not clustered in order to avoid network chatting, and avoid to
potentially pollute all nodes memory with something whose nature is indeed
"volatile".
Moreover, this way nodes can be put behind some kind of load balancer, and a
subset
of the nodes can be "elected" as query nodes: that is, the LB can route all
range
queries to such a subset, without affecting so other nodes.

Regarding the backing data structure, TreeSet has been used because no
concurrency is
needed indeed (snapshots are immutable): do you think the ConcurrentSkipListMap
would
be a better suit?

Original comment by<EMAIL_ADDRESS>on 1 Dec 2009 at 8:22

Original comment by<EMAIL_ADDRESS>on 1 Dec 2009 at 10:01

Added labels: Release-0.2

Original comment by<EMAIL_ADDRESS>on 1 Dec 2009 at 10:02

Removed labels: Release-0.2

Original comment by<EMAIL_ADDRESS>on 1 Dec 2009 at 10:02

Added labels: Milestone-0.2

Original comment by<EMAIL_ADDRESS>on 1 Dec 2009 at 10:01

Added labels: Priority-High
Removed labels: Priority-Medium

I think in this scenario a treeSet would be better because of the immutability.
no
need to incur lock and copy overhead. if it were mutable then I like the skip
list.

Original comment by<EMAIL_ADDRESS>on 2 Dec 2009 at 8:30

Original comment by<EMAIL_ADDRESS>on 2 Dec 2009 at 1:55

Changed state: Fixed


chore: preselect default theme

What changes did you make? (Give an overview)
If theme is present in local storage then take that to highlight the theme change button else highlight the default system theme.
Is there anything you'd like reviewers to focus on?
Check if correct theme is highlighted in theme selector after clearing the local storage

bump for merge :)


The get_pygal_XXX_geoid_list functions for CovidCasesWHO and CovidCasesOWID call a none existing method of the base class

...instead they should call their own methods

Fixed


Upgrade rlimit consts

cc @aidanhs - this should fix the error you are seeing.

@gnzlbg: no appropriate reviewer found, use r? to override

@bors: r+

:pushpin: Commit 5f7600c13726aaaa8487a3fa4ae5a31ce6d37d58 has been approved by gnzlbg

:hourglass: Testing commit 5f7600c13726aaaa8487a3fa4ae5a31ce6d37d58 with merge 0e2549387716c156b44a51882e349ad6ca9611c9...

:sunny: Test successful - checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 0e2549387716c156b44a51882e349ad6ca9611c9 to master...

@aidanhs 0.2.58 has been released with this fix. It would be nice to hear whether this fixes your issue.


POC Kyma operator II - refactor Kyma CR management

AC

[ ] Kyma CR is synchronised from SKR as Single-Source-Of-Truth

[ ] Deleted CRs on SKR gets recreated from KCP CR
[ ] If KCP CR is deleted, Kyma installation gets uninstalled
[ ] Ignore Update on Kyma CR spec from KCP to SKR
[ ] Remove Logic for Configuration Overrides in Kyma CR and passing the Label Selector to Manifest Operator

[ ] Status aggregation works by combining all manifest CR with all module-CR states and writing it into the Kyma status

[x] CRDs are verified to contain status.state-field

Developer Notes

Refactor kyma_synchronization_context.go

Refactor SynchronizeRemoteKyma only keep the logic sync from SKR to KCP

[ ] Write tests to verify if status aggregation works

CRDs verified in https://github.com/kyma-project/kyma-operator/pull/92

I would argue we do not actually remove the synchronization from KCP. My argument for this is that it currently does not hurt and I could not realiably find issues with the Synchronization Context. Instead I would write an automated test for this that confirms the sync wouldn't be an issue in most cases and refactor only the Sync to not call the remote api server in every case for setting annotations and generated timestamps.

Configuration Override Removal in https://github.com/kyma-project/kyma-operator/pull/93


continue on unmet peer dependency

failing where we have an unmet peer dependency, but should still be possible to produce report

@antjkennedy, sorry for the inconvenience, can you rebase this PR against master to kick off a new CI testing cycle?

Work moved to #599


tutorial1: av_read_frame from a concrete stream

As I see there's no notions that it's necessary to distinguish a video stream somehow to read a packet from a right stream.
https://github.com/leandromoreira/ffmpeg-libav-tutorial/blob/e8befe6b5f8a1fbe03c37d79cd312a068ba93a45/0_hello_world.c#L174-L181
Without determine that I was getting such a error.
[h264 @ 0x56240387ff80] Invalid NAL unit size (554341485 > 384).
[h264 @ 0x56240387ff80] Error splitting the input into NAL units.

I am not sure if adding mention it in the script swamps it with specific complications so I just want to pointed this out :)
And Yep I see this :smile:

We'll skip some details, but don't worry: the source code is available at github.

I guess I just didn't work out a good approach here and I am relaying only on the README.md but I might have to consider examples as a part of tutorial :smile:

Yeah, part of hiding the complexity is to try to help to understand :( however it seems that it didn't work for you. but you really need to read from a specific stream.

part of hiding the complexity is to try to help to understand

👍
Agreed I suppose I should just consider examples as a part of the material but not as a cheat following it 😄

I also tend to believe that part of the learning is trying/failing and succeeding

💯


Battery keeps charging if Mac fallen asleep

What is the issue? (required)
Battery will keep charging if Mac fallen asleep in the middle of a charging session, with battery maintain enabled.
Version
I used the CLI-only version v1.0.10
What exactly did you do to produce the issue? (required)
Let's say I set this script to maintain 60% charge. I am now at 50% charge. This sequence of events happened:

I plugged in the charger;
it started charging;
my computer has fallen asleep;
it will keep charging past 60%; (problem here)
my computer wakes;
it finds the actual charge is beyond 60% and stopped charging.

As a result, the final charge is well past 60%.
Expected behavior (required)
I would expect it to stay below 60%.
Error logs
03/31/23-14:14:47 - Charge above 55
03/31/23-14:14:47 - 🔌🪫 Disabling battery charging
03/31/23-18:56:02 - Charge below 55
03/31/23-18:56:02 - 🔌🔋 Enabling battery charging
03/31/23-18:56:02 - 🔼🪫 Disabling battery discharging
# here: charger plugged in, charge below 55, started charging
03/31/23-23:10:04 - Charge above 55 # this is when my mac wakes up, charge at 70%
03/31/23-23:10:04 - 🔌🪫 Disabling battery charging

Possible Solution
My understanding about this problem is (correct me if it is wrong): when asleep, the main logic of the battery script will stop, so it cannot monitor the charge and stop charging, as a result, it will charge past the defined value.
I know this is not a real "bug" so I am here to find some possible solution.

Maybe we can add an option to prohibit computer sleeping when the computer is still charging towards the predefined limit, so we can stop charging once it reaches the limit and enable sleep.
Or we can stop charging just before computer enters sleep, and enable charging once it wakes up. So it will not keep charging when sleeping. (shell script alone, this can be hard to achieve)

A few thoughts on the possible solutions I mentioned:

prohibit computer sleeping when the computer is still charging towards the predefined limit

using caffeinate may achieve this

stop charging just before computer enters sleep, and enable charging once it wakes up

It is probably difficult for a shell script to solve. It requires registering sleep notifications to IOKit. Some third-part app like sleepwatcher may be required.

It seems there is no quick solution to this problem, but this problem happens to me every now and then (maybe due to how I use may computer).
I think some system programming language is required, especially when registering sleep notifications using IOKit. So I spent a weekend giving my ideas a try, and came up with charlie0129/batt, which handles these sleeping situations (quite well).

okay so here's what I've been doing:
$ cat sleep.sh
#!/bin/bash
if [ "$1" == "true" ]; then
  sudo pmset -a disablesleep 0
  echo "sleep set to true"
elif [ "$1" == "false" ]; then
  sudo pmset -a disablesleep 1
  echo "sleep set to false"
else
  echo "wrong argument!"
fi

So I'd go
./sleep.sh false
battery maintain 80

and close the lid (after making the display go to sleep (I have it set as one of my hot corners) because otherwise the screen doesn't turn off after you close the lid.

Glad to see your suggestion! @Paranoid-Dev
It should work well if my mac doesn't need to sleep often. But I use my MacBook outside fairly often, so closing the lid and sleep is a regular thing.
It seems you cannot sleep after you disabled it, unless sleep is enabled manually. So, for my use case, manually running a script every time before I want to sleep, which happens very often, seems a slight mental burden for me...
Hence, in my previous comment, I chose to write a program to do such things automatically through macOS power management using IOKit so that my computer can be used and sleep as usual :p )

@charlie0129 I might switch over to your program if the issue where Battery gets confused with previous values persists :P
I just wanted to share the script for people looking for a quick qnd easy fix for the sleeping problem.

Hey @charlie0129!
Did you test the stability of this? If so can you create a PR for this?

As a simple user of this nice app, I only like to inform that my "solution" to the problem is the following: I set the upper limit of charging to 70%, and so far I haven't seen any overdraft when charging overnight :)

Sorry, overdraft over 80%.


package.json: Unify tabs/spaces convention

package.json uses both tabs and spaces for indentation, which led to confusion when using an editor with a different tab width than yours.  Since most of the file seems to be using tabs, I have switched the spaces over.

Thank You!


Automatically create python wrappers for bash script using docopts

Hi,
I have a set of bash script that are now using docopts. I would like to be able to automatically create python function able to call these bash script.
The idea is the following one. I have a script test.sh with
Usage:
  test.sh (-testdir <testDirPath>) [-v=<VERSION>]
  test.sh -h | --help
Options:
  -h --help         Show this screen.
  -testdir <path>   Dew test directory path.
  -v <version>      Version for XX TOOL [default: Prod].

From which I can extract the Usage part with grep/sed. Now I want to use docopt to automatically write a python script containing:
def test(testdir, v='Prod'):
    subprocess.Popen(['test.sh.sh -testdir %s -v %s' %(testDir, v], shell = True).

It seems to be possible to get the arguments from docopt:
arguments = docopt(__doc__, version='Naval Fate 2.0')
    print(arguments)

but how can I override docopt so it does not try parsing the current python script being executed as what I want is only the arguments dictionnary to buid the function test().
from docopt import docopt

with open ("test.doc", "r") as myfile:
    data=myfile.read()
print(data)
arguments = docopt(data)

Any idea?
Is this thing have been done before?

Very interesting!

Something like this?
>>> from docopt import docopt
>>> data = """Foo v. <IP_ADDRESS>.<IP_ADDRESS>

Usage:
  foo --bar
  foo --baz=Z

Options:
  -b, --bar        Bar switch.
  -z Z, --baz=ZZZ  Baz value.
"""

>>> docopt(data, argv=["--bar"])
{'--bar': True,
 '--baz': None}

>>> docopt(data, argv=["--baz", "42"])
{'--bar': False,
 '--baz': '42'}

Nope, because in your example, the args are provided and hard coded. What I want is being able to get the dictionnary with typed arguments; default values and so on in order to write (generate) a python wrapper file that defines python function with the correct set of arguments that I can use in python only.
I can write all the wrapping function myself, by hand but it will request eacht time a manual modifiction if my bash function changes.

If I understand it correctly: you want to access the internal data that been parsed and matched by docopt.
In short: nuh, docopt does not expose such api. May considering copy/paste and modify code from docopt.
My lib allows to access parsed data tree (and the matched status, errors, etc), but, I wont suggested it, as it's really nested and complex without document/guid of this part

Hi Tyler,
I did try to modifiy docopt to get access to internal data but that was looking to much of an effort for the 15 bash script I have for which I would like a python api.
Not so simple to do. Thanks for your hints

If I understand it correctly: you want to access the internal data that been parsed and matched by docopt.
In short: nuh, docopt does not expose such api. May considering copy/paste and modify code from docopt.
My lib allows to access parsed data tree (and the matched status, errors, etc), but, I wont suggested it, as it's really nested and complex without document/guid of this part


Could we have an Angular 2 version ?

+1 for Angular 2/4.  This looks really nice.

+1 for Angular 4.

+1 for Angular 2/4

See #229, not planning to port this, but happy to link any forks that people create

@marceljuenemann crap :( this is such a solid, flexible library and we've moved to Angular 4 and would love to be able to use it. Thanks for all of the work on this!

Wow. Such a nice library. Way better than anything out there... too bad no Angular 2,4,5,6 support. Even google is dropping support for AngularJS soon. Did anyone here find any other like this one that has Angular x support?


[TEVA-4228] Remove email address from dashboards

Jira ticket URL
https://dfedigital.atlassian.net/browse/TEVA-4228
Screenshots of UI changes:

@cesidio This looks good to me 👍


read 12/24 hour option from locale

Specifying --locale=sv_SE.utf8 outputs 6:00 instead of the default 6:00 pm. I expected 18:00.
A --24-hour option or perhaps parsing the locale to determine 24-hourness would be a nice feature :smile:

FWIW, the option --military outputs with 24 hour time.  I support the idea of adding --24-hour alongside it as an alias because many non-militaristic scenarios call for 24 hour time.
I'm going to update your issue title to emphasize the idea of reading 12/24 hour configuration from locale.

How do I force gcalcli to honor --military option?
> gcalcli remind --military 360
usage: gcalcli [-h] [--client-id CLIENT_ID] [--client-secret CLIENT_SECRET]
               [--config-folder CONFIG_FOLDER] [--noincluderc]
               [--calendar CALENDAR] [--default-calendar DEFAULTCALENDAR]
               [--locale LOCALE] [--refresh] [--nocache] [--conky] [--nocolor]
               [--lineart {fancy,unicode,ascii}]
gcalcli: error: unrecognized arguments: --military

> gcalcli --military remind 360
usage: gcalcli [-h] [--client-id CLIENT_ID] [--client-secret CLIENT_SECRET]
               [--config-folder CONFIG_FOLDER] [--noincluderc]
               [--calendar CALENDAR] [--default-calendar DEFAULTCALENDAR]
               [--locale LOCALE] [--refresh] [--nocache] [--conky] [--nocolor]
               [--lineart {fancy,unicode,ascii}]
gcalcli: error: unrecognized arguments: --military

See #459

Thanks @Tyilo !

The flip-flop is because I realized upon closer reading of your comment that while we've now implemented properly reading the time format (12/24) from the locale, we actually haven't fixed the first part of your issue, which is the bug that --locale STR flag doesn't work as expected.  I'm going to leave this closed and I've opened #460 to address the remaining issues.


[Feature]: Disable Gizmo

Describe the Request
An option to disable the gizmo that replaces the cursor when f3 is enabled
Screenshots
No response
Modloader Type
Fabric
Modloader Version
No response
Additional Context
No response

I just looked into the Minecraft code and I am not sure if there is a way to mixin to disable the f3 crosshair without creating incompatibilities with other mods which modify the crosshair. It might be smarter to use another mod in order to change this setting, but I will keep looking.

https://modrinth.com/mod/nogizmo

Added in #110


Fix -Wsign-compare in Groups.cxx

xref https://github.com/ilwoolyu/GROUPS/issues/3

Fixed in c52ae2645d128972ddf247eb4dc8a3e1a403dcc6


Handle case newaccount in Account Query DB

Change Description

To fix issue #9278, adding code to handle case newaccount so new created accounts can be returned by calling API get_accounts_by_authorizers.
Change Type
Select ONE

[ ] Documentation

[ ] Stability bug fix

[ ] Other

[ ] Other - special case

API Changes

[x] API Changes

This PR should be against develop not master

And if its something we plan to backport, an additional PR should be opened against the release/2.0.x branch

Can we have some tests added to cover this case please.

This PR should be against develop not master

The bug is against 2.0.x so, we should push to develop and backport or commit to 2.0.x and upport eitherway

Can we have some tests added to cover this case please.

It looks like the original author omitted tests in general (hey, that was me).  I agree we should add them

I went ahead and adjusted this PR's base to release/2.0.x

Can we have some tests added to cover this case please.

Okay, I will add some tests.

Please let me know if I need to update #9278 with current status. There is an ETA request in #9278 from a user.

This PR should be against develop not master
Looks like feature "Account Query DB" has not been added to the develop branch yet as per EPE-106.


New Recruit Form does not check against current recuirt nicknames

Describe the bug
The get in use user data method does not check any in use recruit data as recruits are listed in inactive reserves.

GetInUseUserData should check Inactive Reserves though as those are still members of the unit and their names should not be allowed to be selected.

No - recruiters only check against active names (anything not in inactive reserves). Birth numbers are checked unit wide.


Container startup delay

This PR allows a user to specify a time, in seconds, that the container will wait before running the init scripts.  It is configured using the STARTUP_DELAY environment variable like this: STARTUP_DELAY=10 (to delay startup by 10 seconds), and works technically by adding an init script to /etc/my_init.d/00_*.
A real-world application of this is if you have a docker-compose file that starts a mysql container and a python container which expects to find mysql accessible when it starts.  Adding a startup delay to the python would allow you to delay the execution of that container until mysql is up.
Obviously a better solution would be to actually wait for mysql to be usable, not just pause for an arbitrary amount of time, but we have still found this STARTUP_DELAY approach to be quite convenient for development in our environment.

Can we put this into Python as time.sleep() instead? One less file, one less part which can possibly go wrong?

Sure, done!

Thanks, LGTM.

And what if time is not enough? We have made simple connection checker for that. We check mysql and nginx. Sleep is not solution, but lazy workaround.
And when we install mysql, we start it, make some configuration, then shut it down and let default process manager to take over.
mysql.run
#!/bin/bash
exec /usr/sbin/mysqld

init
echo "[SQL] Creating default tables"
    /usr/sbin/mysqld --initialize-insecure

    echo "[SQL] Running in background"
    /usr/sbin/mysqld &

    echo "[SQL] Waiting for startup"
	while [ ! -x /var/run/mysqld/mysqld.sock ]; do
		echo "[SQL] Waiting for database"
		sleep 1
	done

....

Great, if you can just whip up connection state checkers for me for PHP-FPM, MySQL, MongoDB, Redis, Memcached, Kafka, ElasticSearch, Rsyslog, and every other possible service, then we can pull them all into the project and work full-time creating bugfixes :)
I think I made it clear that it was not a good solution for most applications in my original post, and went on to explain what the right solution would be, then I explained why I thought it was still a good idea despite the cons.
Adding logic that checks individual applications like MySQL is way out of scope for a base image like this.

We currently making checkers for all runned services: redis, rabbitmq, php-fpm, nginx, mysql, solr. If company will allow, i'm gonna share it.

It might be a good idea to put those checkers in docs or wiki of some kind. I've written my own for postgresql and it was really far from trivial to get it right.

I think I made it clear that it was not a good solution for most applications in my original post
That's why I personally don't like it. Anyway, I still respect any work somebody (and also kamermans) for making this repo better and better ...

@kamermans one thing which is not clear to me is that in what scenario this is actually useful? I mean the delay is before any runit services are started, so it cannot wait for any service.
Is the delay there to wait for services in other containers, started together via docker compose or something?

@hyperknot - we basically only use it here in development to make one container wait on another.  For example, if I'm going to bring up a brand new mysql container with a php container in the same docker-compose.yml for a quick test, I would delay the php container by 30 seconds to give mysql time to startup, create the users and databases, then restart itself.
@rdxmb thanks for your opinion.
It's not going to hurt my feelings if you don't want to pull it - if you guys don't want this one, just close it and I'll keep the one-off script in my derivative image :)

@kamermans that's what I thought as well, the only meaningful scenario is docker compose for this. Since it only adds an if statement, it looks good to me.

@rdxmb Yes. Now I see how it could be seen very disrespectful. And I'm sorry about that @kamermans .

No problem @bunnyholder
I think I'll just close this PR, as it seems to be more of an internal dev utility than something that should be included in the base image.

Thanks for your contributions @kamermans and everyone else! All code and discussion contributions are greatly appreciated!


make the number of incoming streams configurable

Fixes #523.

Codecov Report

Merging #1197 into master will decrease coverage by 0.02%.
The diff coverage is 97.56%.

@@            Coverage Diff            @@
##           master   #1197      +/-   ##
=========================================
- Coverage   91.12%   91.1%   -0.02%
=========================================
  Files         114     114
  Lines        7735    7750      +15
=========================================
+ Hits         7048    7060      +12
- Misses        461     463       +2
- Partials      226     227       +1

Impacted Files
Coverage Δ

internal/handshake/tls_extension_handler_client.go
89.66% <ø> (-0.18%)
:arrow_down:

server.go
91.74% <100%> (+0.43%)
:arrow_up:

client.go
91.88% <100%> (+0.44%)
:arrow_up:

server_tls.go
79.07% <100%> (ø)
:arrow_up:

streams_map.go
91.91% <100%> (ø)
:arrow_up:

session.go
80.89% <100%> (-0.16%)
:arrow_down:

streams_map_legacy.go
87.84% <75%> (ø)
:arrow_up:

internal/wire/version_negotiation.go
80.65% <0%> (-6.85%)
:arrow_down:

internal/crypto/key_derivation.go
91.3% <0%> (-1.8%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecad36a...245af2c. Read the comment docs.


support for bold and italics customization

Being able to set not just the color but also the italics or bold behavior of certain syntax terms would be great. If this is already possible it would be great if it could be added to the documentation, as I do not currently see any way to do this.

Hello @mbsmith93,
This is in fact easy to implement. But at the moment I'm planning to adopt new semantic highlighting api. After that, extension will highlight tokens according to the current theme. This will automatically allow to decorate tokens whatever one likes, plus many other advantages. Stay tuned.


Every time I run the client I get the "welcome to lbry" message

The Issue
Every time I run the client I get the "welcome to lbry" message
Steps to reproduce

Run the client (current mater branch)
Welcome to LBRY modal window appears

Expected behaviour
Tell us what should happen
It should be shown only once, every other time I open the app it shouldn't be there
Actual behaviour
Tell us what happens instead
System Configuration

LBRY Daemon version: 0.10.3  "lbryum_version": "2.7.22"
LBRY App version: Current Master branch (10.1)
LBRY Installation ID:
Operating system: Linux-4.8.0-52-generic-x86_64-with-Ubuntu-16.04-xenial

Anything Else

Screenshots

This is fixed in latest release.


use thrust scale parameter for vtol pusher support

Probably got lost in translation..

Can you rebase on master and see if that fixes CI?

@LorenzMeier Still fails, I don't understand why. I can successfully run the check commands locally

Something weird on travis-ci? I restarted the job to see if it's consistent.

Rebased again - lets see.


Support Ingresses

Current Behavior
MeshSync doesn't discover this resource type.
Implementation
Add support for discovering this Kubernetes resource type. Do the same thing that was done here - https://github.com/meshery/meshsync/commit/1b640b8cbfd6ffefc0896de8fc1ac2a6bd284822, but for ingresses
Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in Figma (open invite).
Fill-in a Community Member Form and join the Community Slack for access.

@leecalcote  you can assign it to me and I will review this and make changes accordingly
Thanks

Sounds good. Thanks, @Vadiraj-Puranik


add api docs for nerm create permissions

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


setup.py ext_args is not defined when sys.platform == "darwin"

Hello!
I'm encountering a bug in setup.py when trying to build on a Mac where on this line, ext_args is not defined.
Full error message:
  Collecting mrz-scanner-sdk==1.1.0 (from -r requirements-base.in (line 40))
    Using cached mrz-scanner-sdk-1.1.0.tar.gz (21.4 MB)
    Preparing metadata (setup.py) ... error
    error: subprocess-exited-with-error

    × python setup.py egg_info did not run successfully.
    │ exit code: 1
    ╰─> [6 lines of output]
        Traceback (most recent call last):
          File "<string>", line 2, in <module>
          File "<pip-setuptools-caller>", line 34, in <module>
          File "/private/var/folders/gc/46tfyxxn07d24zpxzq1r7cc00000gp/T/pip-resolve-5jtmdgxo/mrz-scanner-sdk_d5cc7f9b19694c0bb175a787cd3b94c6/setup.py", line 36, in <module>
            'mrzscanner', ['src/mrzscanner.cpp'], **ext_args)
        NameError: name 'ext_args' is not defined
        [end of output]

    note: This error originates from a subprocess, and is likely not a problem with pip.

This seems to be because ext_args is only defined for linux/linux2 on this preceding line (not when sys.platform == "darwin")
Could you help resolve? Thanks!

@jaclyn-zhong Thanks for your feedback. Unfortunately, this package does not support macOS. It relies on platform-specific shared libraries.

@jaclyn-zhong The official dynamsoft-capture-vision-bundle with macOS support is now available. If you are still interested in recognizing MRZ on macOS, please try the sample code.


VSCode Extension 4.10.1 & 4.11.0: memory access out of bounds

Bug description
I'm in the process of designing a new schema/db. After editing the schema.prisma file for a couple of hours (with breaks to look up documentation/etc), the Prisma Language Server starts throwing "memory access out of bounds" errors on every attempt to format/lint/autocomplete.
Restarting VSCode so that the Prisma Language Server gets restarted will allow linting/formatting again for another couple of hours before the Prisma Language Service starts throwing the memory access errors again.
I have tested this on both version 4.10.1 and 4.11.0 - both run into the same memory access errors after a few hours.
VSCode Extension version 4.10.1 and 4.11.0
How to reproduce
Steps to reproduce the behavior:

Install the VSCode plugin Prisma
Open a schema.prisma file in VSCode
Continue making changes to the schema.prisma file for a few hours
See error log below

Expected behavior
The Prisma Language Server should not start failing on all access due to memory issues.
Prisma information
This occurs when editing the schema file itself.
Environment & setup

OS: Debian 11
Editor: VSCode 1.75.1
Editor version: 1.75.1
Extension version: 4.10.1 and 4.11.0

Prisma Language Server log from a few lines before the errors started:
running lint() from prisma-fmt
running lint() from prisma-fmt
running lint() from prisma-fmt
running lint() from prisma-fmt
Did not receive any native type suggestions from prisma-fmt call.
running lint() from prisma-fmt
running lint() from prisma-fmt
[Error - 2:23:49 PM] prisma-fmt error'd during linting.

[Error - 2:23:49 PM] [object Object]
[Error - 2:23:49 PM] Request textDocument/completion failed.
  Message: Request textDocument/completion failed with message: memory access out of bounds
  Code: -32603
running lint() from prisma-fmt
[Error - 2:23:51 PM] prisma-fmt error'd during linting.

[Error - 2:23:51 PM] [object Object]
[Error - 2:23:52 PM] Request textDocument/completion failed.
  Message: Request textDocument/completion failed with message: memory access out of bounds
  Code: -32603
running lint() from prisma-fmt
[Error - 2:24:47 PM] prisma-fmt error'd during linting.

[Error - 2:24:47 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:47 PM] prisma-fmt error'd during linting.

[Error - 2:24:47 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:47 PM] prisma-fmt error'd during linting.

[Error - 2:24:47 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:48 PM] prisma-fmt error'd during linting.

[Error - 2:24:48 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:49 PM] prisma-fmt error'd during linting.

[Error - 2:24:49 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:50 PM] prisma-fmt error'd during linting.

[Error - 2:24:50 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:50 PM] prisma-fmt error'd during linting.

[Error - 2:24:50 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:50 PM] prisma-fmt error'd during linting.

[Error - 2:24:50 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:51 PM] prisma-fmt error'd during linting.

[Error - 2:24:51 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:51 PM] prisma-fmt error'd during linting.

[Error - 2:24:51 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:52 PM] prisma-fmt error'd during linting.

[Error - 2:24:52 PM] [object Object]
running lint() from prisma-fmt
[Error - 2:24:59 PM] prisma-fmt error'd during linting.

[Error - 2:24:59 PM] [object Object]
running format() from prisma-fmt

prisma-fmt error'd during formatting. Please report this issue on [Prisma Language Tools](https://github.com/prisma/language-tools/issues).
Linter output:

RuntimeError: memory access out of bounds
    at format (wasm://wasm/00a1175e:wasm-function[35]:0x7c13d)
    at module.exports.format (/home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/@prisma/prisma-fmt-wasm/src/prisma_fmt_build.js:113:14)
    at format (/home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/@prisma/language-server/dist/src/prisma-fmt/format.js:10:42)
    at Object.handleDocumentFormatting (/home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/@prisma/language-server/dist/src/MessageHandler.js:118:44)
    at /home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/@prisma/language-server/dist/src/server.js:182:35
    at /home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/vscode-languageserver/lib/common/server.js:637:20
    at handleRequest (/home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/common/connection.js:459:41)
    at processMessageQueue (/home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/common/connection.js:321:17)
    at Immediate._onImmediate (/home/user/.vscode/extensions/prisma.prisma-4.10.1/node_modules/vscode-languageserver/node_modules/vscode-jsonrpc/lib/common/connection.js:311:13)
    at process.processImmediate (node:internal/timers:466:21)

Hey, @dawnmist, cheers for the report!
Did you see this in 4.9 / previously?
Do you have a schema that you can share - I'm curious as to how big the schema was as well, and can you provide further insight into whether this was when you were doing something specific? it seems like just a regular formatting attempt based on the error

I am new to using Prisma, so I hadn't used it prior to 4.10.
I was setting up an initial schema for a supabase db with auth & storage and learning about prisma as I was doing so, so I was doing a large amount of editing to create that initial schema as I was going along. It was most definitely time/volume of edits related, as it would start to happen after 2-3 hours of continual edits with breaks to read docs/look up information during that time.
Basically, all vscode attempts at linting/formatting/autocomplete would end up becoming blocked, no further interaction with the prisma extension would be possible until vscode were restarted (I don't know of a way to restart an extension without having to restart vscode).
Since getting the bulk of the schema sorted out so that I'm not spending hours editing the schema at once it's ceased happening, further indication that it genuinely is time/number of edits related (potential memory leak).
The final schema is ~960 lines, with at least 1/3 of that being the original supabase auth/storage tables.
I've uploaded an earlier copy of the schema file to https://www.dropbox.com/s/q455kxz08cnsles/schema.prisma?dl=0 - it still has some errors such as forgetting to map names from camel-case to snake case for db names/some of the relationships are not properly thought out, but was one of the versions of the schema where I was seeing this issue crop up while revising it heavily. I'd appreciate it if you could let me know once you've grabbed it so I can take the file down again.

Hey, cheers, got it now! Hm, so then it also sounds like the issue disappeared after re-starting the extension as well. Did you try the CLI at all?

The cli was working fine for doing db pull/migrate tasks - but that was as a separate process rather than within the extension's active process.
Each time the extension started throwing memory access out of bounds errors, restarting VSCode would "fix" the issue for the next 2-3 hours, then the memory errors would begin again completely locking up the extension from working until VSCode was again restarted.
I think I restarted VSCode at least 5 times due to this issue on the day that I originally posted this bug report. That was also the day that version 4.11 was released, so I got to test in both the version I'd had initially and in the newly released version.

Yeah, no worries, just trying to narrow down if this is an issue within the language-tools repo itself or our internal prisma-fmt engine which is what handles the actual formatting :)

It's been a few hours now of random edits here and there and I still can't seem to replicate this. The most I can get is the occasional 3-4 sec delay in the cli which is I think just cold-start as a re-run does not then have the same issue. Not noting any delays when running the formatter through vscode.

OS: MacOS :: darwin-arm64
Editor: VSCode 1.76.1
Extension version: 4.11.0

[Error - 2:24:48 PM] [object Object] is super not helpful here tho, I'll see if I can't improve that the meantime so we can get better logging here 😓

Going through my VSCode settings in case that is a contributing factor, these are the ones most likely to be of relevance (the rest are either generic font/colour/line length, or are specific to particular extensions):
{
  "editor.codeActionsOnSave": {
    "source.organizeImports": false,
    "source.fixAll": true,
    "source.fixAll.eslint": true
  },
  "editor.formatOnSave": true,
  "editor.formatOnType": true,
  "editor.formatOnPaste": true,
  "editor.suggest.showMethods": true,
  "editor.suggest.preview": true,
  "editor.acceptSuggestionOnEnter": "on",
  "editor.tabSize": 2,
  "editor.wordWrapColumn": 100,
  "editor.renderWhitespace": "boundary",
  "editor.snippetSuggestions": "bottom",
  "emmet.excludeLanguages": [
    "markdown",
    "typescript",
    "typescriptreact"
  ],
  "emmet.showExpandedAbbreviation": "inMarkupAndStylesheetFilesOnly",
  "prisma.fileWatcher": true
}

{
  // "editor.codeActionsOnSave": {}, don't have this
  "editor.formatOnSave": true,
  // "editor.formatOnType": true, don't have this
  // "editor.formatOnPaste": true, don't have this
  "editor.suggest.showMethods": true,
  "editor.suggest.preview": true,
  // "editor.acceptSuggestionOnEnter": "on", don't have this
  // "editor.tabSize": 2, I don't have this but I use spaces (2) in .prisma files
  // "editor.wordWrapColumn": 100, don't have this
  // "editor.renderWhitespace": "boundary", don't have this
  // "editor.snippetSuggestions": "bottom", don't have this
  // "emmet.excludeLanguages": [], don't have this
  // "emmet.showExpandedAbbreviation": "inMarkupAndStylesheetFilesOnly", don't have this
  // "prisma.fileWatcher": true, I don't have this, I wonder if this is it
}

I must say that I've found the prisma extension absolutely awesome to work with apart from this memory issue - it certainly helped a lot with learning prisma syntax and how to write relationships/etc. It's definitely been one of the nicest language servers that I've worked with. :)

Really appreciate that! Doing my best to make it even better 😊

The file watcher is quite likely - between it and the format on type/paste the extension is actively working a lot of the time (I'd generally only seen the activity when the extension log window popped up due to it throwing the memory error, and it seemed at that point to be attempting formatting/lookups on every keystroke).

Yeah, I'll see about having another bash with the filewatcher and other format settings enabled :)


Feature/add mbr support

Add limited support for MBR/DOS partition tables.
This adds code to write MBR partitions.  Ideally we only write these in
update cases.
It would be nice to have a 'convert' of some sort that would convert MBR
into GPT.  That would have to take into account the fact that we can't
yet read extended partitions.
Also, if a partition table is messed up then addPartitions will fail
because of the check call.  In that event, you'd need to disk.Wipe()
first.  Kind of annoying.  I think the right way to support writing
a new MBR would look a lot like newProtectiveMBR() that reads the
disk and just wipes the mbr section of the first sector, but leaves
the rest intact.
Also adds Table to Disk to store GPT or MBR or None.

One comment, not necessarily a blocker though. LGTM otherwise


feat(module:datepicker): support month picker

PR Checklist
Please check if your PR fulfills the following requirements:

[X] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #351
What is the new behavior?

Does this PR introduce a breaking change?
[ ] Yes
[X] No

Other information

Coverage decreased (-0.03%) to 40.719% when pulling 4e6f09e54edaba1628078136bb442d4177618748 on HsuanXyz:feat-datepicker-month into cf83c96423f1bcfc8e5b147f8bac9ce3201a74a6 on NG-ZORRO:master.


"encoded acoustics" confusing

Currently in the Corpus view, if you've encoded FAVE-style formants or spectral measures, these will show up under "Currently encoded properties" for Phones, but nothing will show up under "Currently encoded acoustics" for Acoustics.
I see the logic of this (FAVE-style formants are single measures that are properties of phones), but it's potentially confusing because the user originally clicked "Acoustics" to make the enrichment.
I think Acoustics in corpus view currently only shows encoded tracks. maybe it should show point measures as well, even if these are duplicates? not sure..

An easy fix would be to be explicit that it's only encoded tracks that are listed there?
The issue with point measurements showing up there is that there's no difference in the database between F1 and begin.  If we wanted them there then the Enrichment object would have to know what it's encoding, which it currently doesn't.

I think it's fine they show up there.  I was thinking maybe also under Acoustics, but perhaps that's confusing.
Maybe just change "Acoustics" in corpus view to "Acoustic tracks" or something?

Yeah, changed it to acoustic tracks, which are in their own section because the point measures already have a way to view if they're encoded.

Great.
Btw should I have marked this low-priority? I guess I have been assuming that "suggestion" implies low-priority. (This issue didn't need to be addressed ASAP.)


Simplify resource pool handler

This patch merges the resource pool collection and object handler into a single handler that implements both interfaces.

@danielerez please review.

/lgtm

/approve


[parquet] Parquet supports column index filter

Purpose

Use column index filter api in parquet reader.
Add tests.

Tests

API and Format

Documentation

https://issues.apache.org/jira/browse/SPARK-34859

Don't not merge this. It seems we need to have more works to do.

Also should consider row position of returned iterator.


Premium plan ARM template deployment example is using an old schema

The newer schemas have the "sku" property outside of "properties" (same issue as the closed #36839).
Please update to a more recent schema.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1ba8817-3e01-7e84-6c71-b98b131f2927
Version Independent ID: a7703386-9e83-1075-72ef-f9e63f3dc4de
Content: Automate function app resource deployment to Azure
Content Source: articles/azure-functions/functions-infrastructure-as-code.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@MickeJagekrans Thank you for your feedback! We will review and update as appropriate.


Parameterize the Middleware type

Parameterize the returned Middleware type so that this library can be used along with a context-parameterized Koa app.
ref. https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31704

If you're interested, this project is looking for a maintainer 😄
https://github.com/apollo-server-integrations/apollo-server-integration-koa/issues/104

@trevor-scheer Thank you for your quick review!
Thank you again for adding a change description. It looks good to me.
I would appreciate it if you merged the PR and release the new version.

@ryota-ka released in v1.1.0. Thanks for the PR!


Suggestion to use windows raw input api over joystickapi

Hey I got Windows joystickapi.h pulling a single axis from my taranis x5d in ue5. Not doing anything, just reading the values and writing it to unreal’s viewport. I noticed that it has a dead-zone around the center stick. I thought it was originally coming from the taranis but nope it’s happening in software somewhere. I’m not sure if that can be turned off in joystickapi or if it’s baked in. I suspect it’s baked in because I couldn’t find any way to disable it. For my project I’m trying to control a mini quad in Acro mode and the dead-zones are no good for that. I’ve been looking at using the windows raw input api and so far I’ve got it running in a standalone app and it seems to run well for my purposes. No abstract windows layers to get in the way and possibly slow it down.
I’m not sure your intent for this project but it might be worth it to make a switch to that api. A side benefit is you won’t have to hardcode vendor/device ids to get specific joysticks to work. You might have to remap axis as I would assume not every joystick, RC controller would have different orders of axis. BTW I’ve never seen an unreal project rely on so many languages at one time!

Interesting suggestion -- I'd appreciate any code you can share!

As for multiple programming languages: you can actually get away with using just C++ (plus whatever C# required by UE5 for you to configure the build).   However because we teach several different languages in my CS department (Python, Java, Haskell), and I've worked with engineers who use only Matlab, I wanted to support as many languages as possible.  It's been a great exercise having to think about how to implement the same algorithms (PID control) in so many different programming paradigms!

Just adding my two cents. I've found the Microsoft Joystick API to be finicky at best.
I was looking into the best (hopefully multi-platform) library to achieve joystick input within Unreal Engine. I came across a decently old plugin wrapping SDL2 - which works will all sorts of devices. However, it wasn't built for Unreal input systems.
After a while of rewriting the plugin, I now have it fully working (with force feedback support) in all versions of Unreal (4.25+).
Perhaps the plugin will work for you?
See here: https://github.com/JaydenMaalouf/JoystickPlugin


Enable Animation Export with Sketchfab's Fork

Sketchfab's fork of UnityGLTF supports pretty good animation export for nearly two years now, and as far as I know (and from my testing) this repo here still doesn't, which is really unfortunate as it contains many other fixes.
It would be great if the relevant parts that enable animation export are brought over. I messed with it a bit, but are not familiar enough with the details of the file format to get that to work. I might find more time to test but I think it would be much faster to do for someone with more GLTF insight.
Fact is, if you download the unitypackage from https://github.com/sketchfab/UnityGLTF/releases/tag/1.1.0 (you can disable the actual sketchfab upload and log where the GLB is produced), you get properly exported animations in the resulting GLB file.
(for testing, here's sketchfab fork latest with just a simple export button in "Sketchfab/Publish to Sketchfab": https://github.com/prefrontalcortex/UnityGLTF/tree/sketchfab-master)

I opened #533 with what I got over from Sketchfab which seems to work the same as their old fork.

Hi, I have created a pull request for support animations and skeleton export.

Hi, I have created a pull request for support animations and skeleton export.#561 @soraryu

Hey @owilliamailliwo - have you compared in functionality with my PR above? I've also added more features and a ton of stability fixes on my fork - would be great if we can work on getting the best of both!


测试问题

从谷歌云盘下载2倍的超分辨率预训练模型，测试Set5结果PSNR只有30.460
--model
PAEDSR
--data_test
Set5
--save_results
--rgb_range
1
--data_range
801-900
--scale
2
--n_feats
256
--n_resblocks
32
--res_scale
0.1
--pre_train
D:\PANSR\pretrain_model\model_x2.pt
--test_only
--chop

Hi, it seems that your command is correct but I did not observe such effects. It maybe some weights are not correctly loaded. Please use this code base to avoid version problem. You can also double check the results by first inference the outputs and evaluate the results using third party code like (https://github.com/yulunzhang/RNAN/blob/master/SR/experiment/PP_Evaluate_SR.m).
Here is my result:


Keeps losing connection

Issue Type: Bug
The connection keeps being interrupted and we have to liveshare all over again.
Extension version: 1.0.950
VS Code version: Code 1.39.1 (88f15d17dca836346e787762685a40bb5cce75a8, 2019-10-10T23:35:11.314Z)
OS version: Darwin x64 18.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.37GB free)

Process Argv
.

Screen Reader
no

VM
0%

Thanks for reporting this. Could you please share your logs?
Also what error were you seeing when the connection was lost? What type of network were you on?

Closing due to age. Please re-activate if this is still an issue.


Add support for clean shutdown of idle connections

Spent some time over the weekend address a few issues with manners and adding more tests.
This first branch/PR maintains a backwards compatible interface with the existing implementation and also:

Stop server from allowing keep-alive requests after shutdown begins
Remove race conditions from tests
Remove mutex from listener
Improve tests and make deterministic
Maintains interface backwards compatibility

However I did more work in another branch (#22) that goes further at the expense of backwards compatibility.. I'll open a PR for that one separately so you can take a look.

This is superseded by the work you did on the new API. Thanks for the contribution though, and I apologize for taking so long to get back to you.


I can't browse admin section or any section

Laravel Version: 5.3.31
Voyager Version: 0.11.10
PHP Version:
Database Driver & Version:

I did all steps to install voyager , the only thing that I can browse is login page even when I added
Route::group(['prefix' => 'admin'], function () {
Voyager::routes();
});
if I try to browse different page it gives me the welcome page, which is laravel default page ?

Did you add the "admin" role to your user?  You can do so with php artisan voyager:admin [user's email]

You mean in role table ? yes I did but nothing new same story and issue

Me too, same problem it redirects to the welcome page.

Ok seems that if add a migration i have to do again the command php artisan voyager:install after that it works
Before re-installing voyager after model adding, not working:
https://gist.github.com/Neogene/f187cdff248205ea1600e0d4bab2be8e
After (working):
https://gist.github.com/Neogene/07113a7c72575ce838c5f0383099279a

Did you solve the issue  @Neogene ?

The only solution i found after a day is to create a gulp file which refreshes the whole project rollbacking all and starting the migration.

after php artisan voyager:install if you get this error The process "composer dump-autoload" exceeded the timeout of 60 seconds. then your installation is not complete.
i couldn't not also access my dashboard until i run php artisan optimize then php artisan voyager:install now everything work fine. hope it help

Closing for now due to age.  If this is still an issue after the 1.0 release, please open a new issue


Fixes resolving links in a file while it shouldn't

Fixes https://github.com/remy/inliner/issues/70

So, firstly please read the contributing file, no change can come in without a test.
This isn't breaking because of anything special about travis, it's breaking because the test are breaking (a good thing!) - which means there's a bug in your code somewhere.
If you've cloned this repo locally, just run npm install and then npm test and you'll be able to run the tests locally (you can also easily test a single fixture to help you develop faster).

My excuses, was a little to eager to contribute :) I updated the PR.

:)
On Thu, 12 Nov 2015 23:08 Felix Akkermans<EMAIL_ADDRESS>wrote:

My excuses, was a little to eager to contribute :) I updated the PR.
—
Reply to this email directly or view it on GitHub
https://github.com/remy/inliner/pull/71#issuecomment-156265615.


Support ancient git versions in packs.download

Expanded all the ugly git shortcuts, this should fix RHEL6.

Current coverage is 76.66% (diff: 100%)

Merging #3008 into master will increase coverage by 0.14%

@@             master      #3008   diff @@
==========================================
  Files           428        428
  Lines         21877      21877
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          16739      16770    +31
+ Misses         5138       5107    -31
  Partials          0          0

Powered by Codecov. Last update e0adf1f...8ed376f

Merging #3008 into master will increase coverage by 0.14%

Increasing coverage like a pro.

@emedvedev You so pro. :100:


inference DLC

update doc with latest inference DLC

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


build_library: dont do verity and kernel signing on arm64

@mischief The problematic part is putting the hash value into the kernel image.  I think it better to just have that conditional and still run everything else.  sbsign sometimes gets broken for arm64, and we can catch it if it is run.
Maybe the answer is to have a new routine, say install_image_hash, and that then does the right thing for each image type.

If we want to check sbsign continues to work instead of this code we could do something like this in build_image:
if [[ $BOARD != amd64-usr ]]; then
    FLAGS_enable_rootfs_verification=${FLAGS_FALSE}
fi

sgtm.


feat(CI): Add a new task to automatically assign a team label on a dependabot PR

What does this PR do?

Add a new task to automatically assign a team label on a dependabot PR
Add an associated workflow to assign at PR creation

Motivation
Remove manual actions

Additional Notes

Possible Drawbacks / Trade-offs
Assignment is based on the occurrence of dependency found in repository files. This heuristic is basic and prevents the PR from being unassigned. It does not prevent a manual redirection.

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

Wrote a few comments which came to my mind when reading the code, I understand this needs to handle different languages so having a single perfect implementation is impossible, but I'm not sure this is the best way to do it 😄
EDIT: in particular I think this job only makes sense for the root go.mod file, so the code could be way more specialized for that (only Go, only root module)

dependabot updates all version of various dependencies. As a consequence it works also for github actions updates for instance

dependabot updates all version of various dependencies. As a consequence it works also for github actions updates for instance

@chouetz yes but workflows are owned by a specific team, so the PR will already be owned by that team.
The root go mod file is the only source of dependencies which doesn't have an owner and whose scope is broader in terms of teams.

dependabot updates all version of various dependencies. As a consequence it works also for github actions updates for instance

@chouetz yes but workflows are owned by a specific team, so the PR will already be owned by that team. The root go mod file is the only source of dependencies which doesn't have an owner and whose scope is broader in terms of teams.

Yes the objective would also to rely only on CODEOWNERS as ownership definition. You can see in this PR dependabot set team/agent-platform, and my script would rather infer team/serverless.
I think we could be more accurate if we have file ownership on a single place (I'm not confident about our capacity to maintain accurate ownerships on dependabot.yml and in CODEOWNERS ;) )

Oh ok I assumed for this kind of situation we just didn't set a label in the dependabot config and let the real code owner set its own team label, but I think I understand better what the goal of the PR is now


traceroute rpc error

Hello
I am facing an error with traceroute. Ping is OK.
$ gnoic version
version : 0.0.5
 commit : 26c6248
   date : 2021-05-12T10:12:55Z
 gitURL : https://github.com/karimra/gnoic
   docs : https://gnoic.kmrd.dev

There is a warning with ping:
$ gnoic -a <IP_ADDRESS>:6030 -u arista -p arista --insecure  system ping --destination <IP_ADDRESS> --count 2 --do-not-resolve
WARN[0000] "<IP_ADDRESS>:6030" could not lookup hostname: lookup <IP_ADDRESS>.in-addr.arpa. on <IP_ADDRESS>:53: no such host
source: "<IP_ADDRESS>"
time: 4160000
bytes: 64
sequence: 1
ttl: 64
source: "<IP_ADDRESS>"
time: 12100000
bytes: 64
sequence: 2
ttl: 64
source: "<IP_ADDRESS>"
time:<PHONE_NUMBER>
sent: 2
received: 2
min_time: 4168000
avg_time: 8145000
max_time: 12122000
std_dev: 3977000

There is an error with traceroute
$ gnoic -a <IP_ADDRESS>:6030 -u arista -p arista --insecure system traceroute --destination <IP_ADDRESS>  --do-not-resolve
WARN[0000] "<IP_ADDRESS>:6030" could not lookup hostname: lookup <IP_ADDRESS>.in-addr.arpa. on <IP_ADDRESS>:53: no such host
destination_name: "<IP_ADDRESS>"
destination_address: "<IP_ADDRESS>"
hops: 30
packet_size: 60
ERRO[0000] rcv System Traceroute stream failed: rpc error: code = Unknown desc = traceroute error: stderr: "whois.radb.net/nicname: Temporary failure in name resolution", error: exit status 2
ERRO[0000] "<IP_ADDRESS>:6030" System Traceroute failed: rpc error: code = Unknown desc = traceroute error: stderr: "whois.radb.net/nicname: Temporary failure in name resolution", error: exit status 2
Error: there was 1 error(s)

$ gnoic -a <IP_ADDRESS>:6030 -u arista -p arista --insecure system traceroute --destination <IP_ADDRESS>  --do-not-resolve -d
DEBU[0000] cmd=gnoic, flagName=address, changed=true, isSetInFile=true
DEBU[0000] cmd=gnoic, flagName=config, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=debug, changed=true, isSetInFile=true
DEBU[0000] cmd=gnoic, flagName=gzip, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=insecure, changed=true, isSetInFile=true
DEBU[0000] cmd=gnoic, flagName=password, changed=true, isSetInFile=true
DEBU[0000] cmd=gnoic, flagName=port, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=print-request, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=proxy-from-env, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=skip-verify, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=timeout, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=tls-ca, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=tls-cert, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=tls-key, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=tls-max-version, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=tls-min-version, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=tls-version, changed=false, isSetInFile=false
DEBU[0000] cmd=gnoic, flagName=username, changed=true, isSetInFile=true
DEBU[0000] cmd=traceroute, flagName=system-traceroute-destination, changed=true, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-do-not-fragment, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-do-not-resolve, changed=true, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-help, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-initial-ttl, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-interval, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-l3protocol, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-l4protocol, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-max-ttl, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-size, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-source, changed=false, isSetInFile=false
DEBU[0000] cmd=traceroute, flagName=system-traceroute-wait, changed=false, isSetInFile=false
WARN[0000] "<IP_ADDRESS>:6030" could not lookup hostname: lookup <IP_ADDRESS>.in-addr.arpa. on <IP_ADDRESS>:53: no such host
DEBU[0000] "<IP_ADDRESS>:6030" resolved names: []
DEBU[0000] "<IP_ADDRESS>:6030" target-config: {"address":"<IP_ADDRESS>:6030","insecure":true,"skip-verify":false,"username":"arista","password":"arista","timeout":10000000000,"gzip":false,"resolved-ip":"<IP_ADDRESS>"}
INFO[0000] [core] parsed scheme: ""
INFO[0000] [core] scheme "" not registered, fallback to default scheme
INFO[0000] [core] ccResolverWrapper: sending update to cc: {[{<IP_ADDRESS>:6030  <nil> 0 <nil>}] <nil> <nil>}
INFO[0000] [core] ClientConn switching balancer to "pick_first"
INFO[0000] [core] Channel switches to new LB policy "pick_first"
INFO[0000] [core] Subchannel Connectivity change to CONNECTING
INFO[0000] [core] Subchannel picks a new address "<IP_ADDRESS>:6030" to connect
INFO[0000] [core] pickfirstBalancer: UpdateSubConnState: 0xc00017d150, {CONNECTING <nil>}
INFO[0000] [core] Channel Connectivity change to CONNECTING
INFO[0000] [core] Subchannel Connectivity change to READY
INFO[0000] [core] pickfirstBalancer: UpdateSubConnState: 0xc00017d150, {READY <nil>}
INFO[0000] [core] Channel Connectivity change to READY
DEBU[0000] destination: "<IP_ADDRESS>"
do_not_resolve: true
destination_name: "<IP_ADDRESS>"
destination_address: "<IP_ADDRESS>"
hops: 30
packet_size: 60
ERRO[0000] rcv System Traceroute stream failed: rpc error: code = Unknown desc = traceroute error: stderr: "whois.radb.net/nicname: Temporary failure in name resolution", error: exit status 2
ERRO[0000] "<IP_ADDRESS>:6030" System Traceroute failed: rpc error: code = Unknown desc = traceroute error: stderr: "whois.radb.net/nicname: Temporary failure in name resolution", error: exit status 2
DEBU[0000] "<IP_ADDRESS>:6030" System Traceroute failed: rpc error: code = Unknown desc = traceroute error: stderr: "whois.radb.net/nicname: Temporary failure in name resolution", error: exit status 2
Error: there was 1 error(s)
$

Same traceroute directly on the network device:
DC1-LEAF1A(config)#traceroute  <IP_ADDRESS>
traceroute to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  <IP_ADDRESS> (<IP_ADDRESS>)  14.119 ms  9.920 ms  10.830 ms

Hi,
I will fix the warning. It comes from misidentifying the format "ip:port" as a hostname
For the traceroute, I'm not sure why the reception of the second message fails, let me look into it.

Hello,
It was an issue with my device running an old release (4.240F).
I tested it with a more recent EOS release (4.25.0F) and it works now :-)
$ gnoic -a <IP_ADDRESS>:6030 -u arista -p arista --insecure system traceroute --destination <IP_ADDRESS>  --do-not-resolve
WARN[0000] "<IP_ADDRESS>:6030" could not lookup hostname: lookup <IP_ADDRESS>.in-addr.arpa. on <IP_ADDRESS>:53: no such host
destination_name: "<IP_ADDRESS>"
destination_address: "<IP_ADDRESS>"
hops: 30
packet_size: 60
hop: 1
address: "<IP_ADDRESS>"
rtt: 6760000
hop: 1
address: "<IP_ADDRESS>"
rtt: 6133000
hop: 1
address: "<IP_ADDRESS>"
rtt: 10124000

Many thanks for your help


Update Roslyn to v4.8.0

This updates Roslyn to v4.8.0.
C# 12 stuff seems to work fine with no other changes, so this PR is straightforward. I upgraded the EdgeDriver test project target framework because of a security vulnerability that generated an error message.

Thanks for the release 🙂


terminal mouseWheelZoom zooms in increments of 24 points.

Does this issue occur when all extensions are disabled?: Yes/No
Yes.

VS Code Version:
Insiders - 1.86.0

OS Version:
Windows 11 Pro 22H2 build 22621.3007

Steps to Reproduce:
Not sure if it's possible for others but it's consistent here: Open User Settings JSON (or local settings JSON). set mouseWheelZoom to true and add an entry for terminal font size. Launch a terminal, ctrl-scroll, and watch as the font-size abruptly goes from e.g. 10 to 34 to 58 etc. It will also drop below zero if scrolled down a smidge too much and the problems-tab will warn that the font size is indeed too small to be workable. The blue dot on the explorer icon that normally tells you there are unsaved changes will also flicker as the wheel is scrolled. I could be imagining things but the issue seemed to pop up after the latest patch.

@NidusUmbra are you using a trackpad or mouse?

@NidusUmbra are you using a trackpad or mouse?

I am using a mouse.

Strange, I don't see this. It's possible your mouse is trying to be clever and split up the wheel events to stimulate smooth scrolling? Do you see the same behavior in the editor?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Credential with colon in name doesn't work?

I'm adding the ownCloud QR credential below, but it doesn't seem to work. If I remove the ':' from the credential name, it works.  Are the names split on colons somehow?
Yes I have revoked this credential :-)

Well yes, the credential names are split on colons, as the colon is used to identify the "issuer" prefix. See this link.

Neither issuer nor account name may themselves contain a colon.

I take it that this means the QR is not following that spec.  Right now this result in unexpected behaviour: the credential is simply not stored on the YubiKey.  Would it be possible to do something better?  Either just remove the colons or transpose them to some other character.  An error message is also a possibility, but that is usually bad user interface design.

Actually it seems that it's not the colon that's making the credential fail, but the length of the name. The name is 65 bytes long, and the maximum length allowed on YubiKeys is 64 bytes. So deleting a character anywhere in the name adds the credential with "https" as the issuer...
This should be handled better, the user should probably be asked to shorten the name to 64 characters or less.


on_save_checkoint never called

🐛 Bug
I wrote a Callback class and found on_save_checkpoint had never been called
To Reproduce
My callback class:
from pytorch_lightning.callbacks import Callback
from os.path import join
import torch
import os
import pytorch_lightning as pl
from typing import Dict, Any, Optional

class JitSave(Callback):

    def __init__(self):
        self.outputs = None
        self.n_dataloaders = None

    def on_save_checkpoint(
        self, trainer: 'pl.Trainer', pl_module: 'pl.LightningModule', checkpoint: Dict[
                str, Any]
    ) -> dict:
        # Torch.jit.save
        jit_model_dir = join(
            join(os.getcwd(), "checkpoints"), f"jit_{self.logger[0].version}" + "{}.pt"
        )
        torch.jit.save(self.model.cpu().to_torchscript(), jit_model_dir.format("cpu"))
        torch.jit.save(self.model.to_torchscript(), jit_model_dir.format("gpu"))
        print(f"torch.jit.save path :\n{jit_model_dir}")
        # return {"jitsave_path": jit_model_dir}
        return checkpoint

    def setup(self, trainer: 'pl.Trainer', pl_module: 'pl.LightningModule', stage: Optional[str] = None) -> None:
        self.n_dataloaders = len(pl_module.val_dataloader())

    def _reset(self):
        self.outputs = [[] for _ in range(self.n_dataloaders)]

    def on_epoch_start(self, trainer: 'pl.Trainer', pl_module: 'pl.LightningModule') -> None:
        self._reset()

    def on_validation_epoch_end(self, trainer: 'pl.Trainer', pl_module: 'pl.LightningModule') -> None:
        for dataloader_idx, output in enumerate(self.outputs):
            pass

on_validation_epoch_end works but on_save_checkpoint not.
This is my ModelCheckpoint:
model_checkpoint:
  _target_: pytorch_lightning.callbacks.ModelCheckpoint
  monitor: "val/f1" # name of the logged metric which determines when model isimproving
  mode: "max" # can be "max" or "min"
  save_top_k: 1 # save k best models (determined by above metric)
  save_last: False # additionaly always save model from last epoch
  verbose: False
  dirpath: "checkpoints/"
  filename: "epoch_{epoch:03d}"
  auto_insert_metric_name: False
  save_weights_only: True

Callbacks are passed to the trainer:
callbacks: List[Callback] = []
    if "callbacks" in config:
        for _, cb_conf in config.callbacks.items():
            if "_target_" in cb_conf:
                log.info(f"Instantiating callback <{cb_conf._target_}>")
                callbacks.append(hydra.utils.instantiate(cb_conf))

trainer: Trainer = hydra.utils.instantiate(
        config.trainer, callbacks=callbacks, logger=logger, _convert_="partial"
    )

Expected behavior
on_save_checkpoint should be called.
Environment

CUDA:
- GPU:
- GeForce RTX 2080 Ti
- available:         True
- version:           10.2
Packages:
- numpy:             1.19.5
- pyTorch_debug:     False
- pyTorch_version:   1.9.0+cu102
- pytorch-lightning: 1.4.2
- tqdm:              4.62.1
System:
- OS:                Linux
- architecture:
- 64bit
- ELF
- processor:         x86_64
- python:            3.8.10
- version:           #60~20.04.1-Ubuntu SMP Thu May 6 09:52:46 UTC 2021

you're specifying save_weights_only=True so no callback states are added to the checkpoint. this means the callback's on_save_checkpoint is never called

you're specifying save_weights_only=True so no callback states are added to the checkpoint. this means the callback's on_save_checkpoint is never called

Thanks for your reply. My problem is solved.


Version bump to 0.2.0.

No bugs have appeared since version 0.2.0a1, so let's update to 0.2.0 and push to pypi.

+1