[$50] Android - Workspace - The Next button overlaps with the device navigation bar

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5383034
Issue reported by: Applause Internal Team
Device used: Samsung S23FE/ Android 14
App Component: Workspace Settings
Action Performed:
Preconditions:
The user is an admin of a workspace.
The device navigation bar is displayed instead of gestures.
Steps:

Navigate to More features on workspace settings
Enable Company Cards
Navigate to Company Cards
Tap on Add Company Cards
Tap on American Express
Tap on the next button
Select the option for "Corporate Cards"
Tap on the next button

Expected Result:
The "Next" button should be displayed above the device navigation bar.
Actual Result:
The "Next" button is displayed behind the device navigation bar.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021873112388502156931
Upwork Job ID:<PHONE_NUMBER>502156931
Last Price Increase: 2024-12-28

Issue OwnerCurrent Issue Owner: @abdulrahuman5196

Proposal
Please re-state the problem that we are trying to solve in this issue.
while adding company card, on card instruction page, we have next button going under device navigation bar
What is the root cause of that problem?
We are applying safeAreaPaddingBottomStyle to the ScrollView component in CardInstructionsStep.
Thats why it takes full height and as button is at end, it goes behind navigation bar.
What changes do you think we should make in order to solve the problem?
We pass the safeAreaPaddingBottomStyle in contentContainerStyle array to ScrollView like following -
 <ScreenWrapper
            testID={CardInstructionsStep.displayName}
            includeSafeAreaPaddingBottom={false}
            shouldEnablePickerAvoiding={false}
            shouldEnableMaxHeight
        >
            {({ safeAreaPaddingBottomStyle }) => (
                <>
                    ...
                    <ScrollView
                        style={[styles.pt0, styles.trialBannerBackgroundColor]}
                        contentContainerStyle={[safeAreaPaddingBottomStyle, styles.flexGrow1]}
                    >
                     ...
                </>
            )}

        </ScreenWrapper>

We have followed same pattern at multiple places and it works as expected.
Example - https://github.com/Expensify/App/blob/9412d2147b4b44b4371f8bab19c288db5b9bd23a/src/pages/FlagCommentPage.tsx#L133-L146
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The Next button overlaps with the device navigation bar
What is the root cause of that problem?
This occurs because we have disabled includeSafeAreaPaddingBottom by setting it to false here.
https://github.com/Expensify/App/blob/1ab06c4c6f838aac232efc5883cd309efe01fac7/src/pages/workspace/companyCards/addNew/CardInstructionsStep.tsx#L88
What changes do you think we should make in order to solve the problem?

To resolve this issue we just need remove includeSafeAreaPaddingBottom here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I don’t think we need a test here since this is a UI bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

making this external for $50 as its very minor
@abdulrahuman5196 can you please review the proposals

I like the proposal from @huult - this is the current appraoch in the app (i. e. we don't subscribe to context via inline functions and it's something that we actively use).
The only one thing that concerns me is that the button (Next) seems to be very high (at least for me). Just make sure it has the same position as on other screens and we're good to go!

@kirillzyusko Yes, I will test it on other screens to ensure the same position

@mountiny I think we can handle similar issues here https://github.com/Expensify/App/issues/53650 instead of handling it separately.


Do not enable auto mtls when cluster type is Cluster_ORIGINAL_DST (…

…#24319)
fix: #25523

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
31cb0526332296ffacc3f8de250491b5f3a35862
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Thanks


astats plugin memory leak fix for intercept handler continuation mutex.

What does this PR (Pull Request) do?
This PR fixes a memory leak in the astats plugin where a new mutex created by a continuation
that is passed to TSHttpTxnIntercept is never cleaned up.  Solution is to pass a handle to the
source transaction's mutex.  Patch is ported from ATS stats_over_http, inspired by the tls_bridge plugin which uses this technique (and was written by AMC).
Which Traffic Control components are affected by this PR?

Traffic Stats

What is the best way to verify this PR?
Build this astats_over_http.so plugin, deploy to ATS.  Run ATS as normal.  Making a request against the _astats endpoint exercises the fix.  I used valgrind against ATS to verify that a leak existed before and that the leak no longer persists afterwards.
If this is a bug fix, what versions of Traffic Ops are affected?
Currently all current astat plugin versions of Traffic Ops contains this bug.  The bug exists in other plugins in ats 7, 8 and master,
The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Can one of the admins verify this patch?


refactor(content): refactor css vars

fixes https://github.com/patternfly/patternfly-next/issues/988

Deploy preview for pf-next ready!
Built with commit 80fca8f42cd4ddc9c249ed79911513217b327045
https://deploy-preview-1048--pf-next.netlify.com

before
content.scss

263 lines
8896 chars

content.css

177 lines
9094 chars
12k filesize

after
content.scss

208 lines
6611 chars

content.css

143 lines
7215 chars
8k filesize

@christiemolloy does this look good since my last updates or do you see anything else I should update?


Reduce pack size by removing unwanted transitive dependencies

Description
Currently, the MB pack size is around 14MB. It will be better if we can reduce the size by removing unwanted transitive dependencies.

@indikasampath2000 How much were you able to reduce?


Add PublisherSupportURL to Viber.Viber

Add PublisherSupportURL to Viber.Viber <IP_ADDRESS>

Microsoft Reviewers: Open in CodeFlow

Hmm. The link look like it works in my browser. But Invoke-WebRequest keep saying forbidden.

Hello @BrandonWanHuanSheng,
The package manager bot determined there was an issue with some of the URLs included in the manifest file. Please check the pull request for more details and make sure the urls are correct.
Template: msftbot/validationError/urls/smartScreen

URL is work on my browser. But Invoke-WebRequest and Wget keep saying forbidden which is incorrect.

Hello @BrandonWanHuanSheng,
The package manager bot determined there was an issue with some of the URLs included in the manifest file. Please check the pull request for more details and make sure the urls are correct.
Template: msftbot/validationError/urls/smartScreen

URL is work on my browser. But Invoke-WebRequest and Wget keep saying forbidden which is incorrect.

The website blocks automated requests from services like Azure and GitHub. It is something that happens with (almost) all support sites that use Zendesk

Hello @BrandonWanHuanSheng,
The package manager bot determined there was an issue with some of the URLs included in the manifest file. Please check the pull request for more details and make sure the urls are correct.
Template: msftbot/validationError/urls/smartScreen

URL is work on my browser. But Invoke-WebRequest and Wget keep saying forbidden which is incorrect.

The website blocks automated requests from services like Azure and GitHub. It is something that happens with (almost) all support sites that use Zendesk

Why Zendesk want to blocks the support website?

Why Zendesk want to blocks the support website?

Zendesk doesn't block the support website. They block programmatic calls to the website to prevent spam. That's why you can access it from a browser, but the validation pipelines get 403 - Forbidden

Why Zendesk want to blocks the support website?

Zendesk doesn't block the support website. They block programmatic calls to the website to prevent spam. That's why you can access it from a browser, but the validation pipelines get 403 - Forbidden

Oh, I see.

It look like it is too much noise.


Adding Mac address Scalar

Adding MAC Scalar type to HotChocolate.Types.Scalars
Part of #2927

https://github.com/ChilliCream/hotchocolate/tree/dtr/mac-scalar


Support npm package

Hi, will there be support npm package?

Hello @Dinver
Yes, it was in my plans.. but i dont have much time now.


No way to leave bookmarks search

Once you activate bookmarks search on an iOS 10 device (I'm testing on a 5S) there is no way to trigger a resign first responder without killing the app.  (scrolling, tapping, hitting clear all did nothing)
May not be iOS 10 specific, but found on an iOS10 iPhone 5S

Bug Report Dump (Auto-generated)

Version 1.12.0 (1106)
Device: iPhone 5s (iOS 10.3.2)
TestFlight: true

@rizwankce
Sent with GitHawk

@heshamsalman guess it's fixed in latest test flight build 1127. Isn't?
Sent with GitHawk

@rizwankce just pulled latest TestFlight. We're good ✌
Sent with GitHawk


Python (RSOD) Red screen of death, Compilation Issues

PS D:\GitHub\COMPANY> pip install libsql-experimental
Collecting libsql-experimental
Using cached libsql_experimental-0.0.41.tar.gz (28 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: libsql-experimental
Building wheel for libsql-experimental (pyproject.toml) ... error
error: subprocess-exited-with-error
× Building wheel for libsql-experimental (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [125 lines of output]
Running maturin pep517 build-wheel -i C:\Python312\python.exe --compatibility off
📦 Including license file "C:\Users\User\AppData\Local\Temp\pip-install-hurymq80\libsql-experimental_ec7ff98921144b36aca045b4f3c07797\LICENSE.md"
🔗 Found pyo3 bindings
🐍 Found CPython 3.12 at C:\Python312\python.exe
📡 Using build options features from pyproject.toml
Compiling proc-macro2 v1.0.86
Compiling unicode-ident v1.0.12
Compiling windows_x86_64_gnu v0.52.6
Compiling version_check v0.9.5
Compiling cfg-if v1.0.0
Compiling autocfg v1.3.0
Compiling serde v1.0.204
Compiling pin-project-lite v0.2.14
Compiling once_cell v1.19.0
Compiling smallvec v1.13.2
Compiling parking_lot_core v0.9.10
Compiling cc v1.1.6
Compiling futures-core v0.3.30
Compiling scopeguard v1.2.0
Compiling log v0.4.22
Compiling byteorder v1.5.0
Compiling futures-sink v0.3.30
Compiling getrandom v0.2.15
Compiling ahash v0.8.11
Compiling memchr v2.7.4
Compiling futures-channel v0.3.30
Compiling tracing-core v0.1.32
Compiling lock_api v0.4.12
Compiling slab v0.4.9
Compiling pin-utils v0.1.0
Compiling futures-task v0.3.30
Compiling windows-targets v0.52.6
Compiling futures-io v0.3.30
Compiling windows-sys v0.52.0
Compiling either v1.13.0
Compiling allocator-api2 v0.2.18
Compiling itoa v1.0.11
Compiling uncased v0.9.10
Compiling fnv v1.0.7
Compiling target-lexicon v0.12.15
Compiling quote v1.0.36
Compiling glob v0.3.1
Compiling syn v2.0.72
Compiling parking_lot v0.12.3
Compiling rustversion v1.0.17
Compiling anyhow v1.0.86
Compiling prettyplease v0.2.20
Compiling rustls-pki-types v1.7.0
Compiling clang-sys v1.8.1
Compiling rustix v0.38.34
Compiling tower-service v0.3.2
Compiling typenum v1.17.0
Compiling equivalent v1.0.1
Compiling libc v0.2.155
Compiling pyo3-build-config v0.19.2
Compiling ring v0.17.8
Compiling generic-array v0.14.7
Compiling httparse v1.9.4
Compiling minimal-lexical v0.2.1
Compiling regex-syntax v0.8.4
Compiling bitflags v2.6.0
Compiling libloading v0.8.5
Compiling indexmap v1.9.3
Compiling nom v7.1.3
Compiling rand_core v0.6.4
Compiling ppv-lite86 v0.2.17
Compiling spin v0.9.8
Compiling try-lock v0.2.5
Compiling bindgen v0.66.1
Compiling untrusted v0.9.0
Compiling want v0.3.1
The following warnings were emitted during compilation:
  warning<EMAIL_ADDRESS>crypto/curve25519/curve25519.c:1:0: sorry, unimplemented: 64-bit mode not compiled in
  warning<EMAIL_ADDRESS> /* Copyright (c) 2020, Google Inc.
  warning<EMAIL_ADDRESS>
  error: failed to run custom build command for `ring v0.17.8`

  Caused by:
    process didn't exit successfully: `C:\Users\User\AppData\Local\Temp\pip-install-hurymq80\libsql-experimental_ec7ff98921144b36aca045b4f3c07797\target\release\build\ring-96877f784e2de548\build-script-build` (exit code: 1)
    --- stdout
    cargo:rerun-if-env-changed=RING_PREGENERATE_ASM
    cargo:rustc-env=RING_CORE_PREFIX=ring_core_0_17_8_
    OPT_LEVEL = Some(3)
    TARGET = Some(x86_64-pc-windows-gnu)
    OUT_DIR = Some(C:\Users\User\AppData\Local\Temp\pip-install-hurymq80\libsql-experimental_ec7ff98921144b36aca045b4f3c07797\target\release\build\ring-87148fa0e5893b46\out)
    HOST = Some(x86_64-pc-windows-gnu)
    cargo:rerun-if-env-changed=CC_x86_64-pc-windows-gnu
    CC_x86_64-pc-windows-gnu = None
    cargo:rerun-if-env-changed=CC_x86_64_pc_windows_gnu
    CC_x86_64_pc_windows_gnu = None
    cargo:rerun-if-env-changed=HOST_CC
    HOST_CC = None
    cargo:rerun-if-env-changed=CC
    CC = None
    cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
    RUSTC_WRAPPER = None
    cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
    CRATE_CC_NO_DEFAULTS = None
    DEBUG = Some(false)
    CARGO_CFG_TARGET_FEATURE = Some(cmpxchg16b,fxsr,sse,sse2,sse3)
    cargo:rerun-if-env-changed=CFLAGS_x86_64-pc-windows-gnu
    CFLAGS_x86_64-pc-windows-gnu = None
    cargo:rerun-if-env-changed=CFLAGS_x86_64_pc_windows_gnu
    CFLAGS_x86_64_pc_windows_gnu = None
    cargo:rerun-if-env-changed=HOST_CFLAGS
    HOST_CFLAGS = None
    cargo:rerun-if-env-changed=CFLAGS
    CFLAGS = None
    cargo:warning=crypto/curve25519/curve25519.c:1:0: sorry, unimplemented: 64-bit mode not compiled in
    cargo:warning= /* Copyright (c) 2020, Google Inc.
    cargo:warning=

    --- stderr

    error occurred: Command "gcc.exe" "-O3" "-ffunction-sections" "-fdata-sections" "-m64" "-I" "include" "-I" "C:\\Users\\User\\AppData\\Local\\Temp\\pip-install-hurymq80\\libsql-experimental_ec7ff98921144b36aca045b4f3c07797\\target\\release\\build\\ring-87148fa0e5893b46\\out" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-Wall" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-g3" "-DNDEBUG" "-o" "C:\\Users\\User\\AppData\\Local\\Temp\\pip-install-hurymq80\\libsql-experimental_ec7ff98921144b36aca045b4f3c07797\\target\\release\\build\\ring-87148fa0e5893b46\\out\\fad98b632b8ce3cc-curve25519.o" "-c" "crypto/curve25519/curve25519.c" with args gcc.exe did not execute successfully (status code

exit code: 1).
  warning: build failed, waiting for other jobs to finish...
  💥 maturin failed
    Caused by: Failed to build a native library through cargo
    Caused by: Cargo build finished with "exit code: 101": `"cargo" "rustc" "--features" "pyo3/extension-module" "--message-format" "json-render-diagnostics" "--manifest-path" "C:\\Users\\User\\AppData\\Local\\Temp\\pip-install-hurymq80\\libsql-experimental_ec7ff98921144b36aca045b4f3c07797\\Cargo.toml" "--release" "--lib"`
  Error: command ['maturin', 'pep517', 'build-wheel', '-i', 'C:\\Python312\\python.exe', '--compatibility', 'off'] returned non-zero exit status 1
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for libsql-experimental
Failed to build libsql-experimental
ERROR: Could not build wheels for libsql-experimental, which is required to install pyproject.toml-based projects
[notice] A new release of pip is available: 24.0 -> 24.3.1
[notice] To update, run: python.exe -m pip install --upgrade pip

I am also struggling to compile libsql-experimental.


[Impeller] Changes to use depth based clipping have regressed GPU frame times.

Canonical benchmark is probably complex layout: https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_gpu_frame_time%26sub_result%3D99th_percentile_gpu_frame_time%26sub_result%3Daverage_gpu_frame_time%26test%3Dcomplex_layout_scroll_perf_impeller__timeline_summary&selected=commit%3D39677%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Daverage_gpu_frame_time%252Ctest%253Dcomplex_layout_scroll_perf_impeller__timeline_summary%252C
AFAIK this application has few or no non-convex shapes. average GPU frame time regressed about 1.5ms
The new gallery is a similar story, the main page which used to have GPU times around ~2-3ms is now taking ~7-8ms. This is pushing us closer to frame budget on the Pixel 7s.
Before

After

I don't think this is actually related to the StC portion of the change as there are few if any non-convex shapes. Instead, a change in depth testing from the assigned depth values/enabling of the depth test must be responsible

The problem is the depth write portion of the intersect clip. For something like flutter gallery that has 3-4 intersect clips, we end up doing as many fullscreen depth writes. This is apparently super expensive, and constitutes roughly 6ms of the 7ms GPU frame time.

I investigated iOS performance. On the flutter gallery example app, there does not seem to be any performance regression - and the clips themselves comprise a trivial amount of GPU time. While that is only one example, its possible that this is only an Arm/QC vs apple GPU performance difference.

So right now we always draw intersect clips to the whole framebuffer. But we only need to actually need to draw over the max combined coverage of all the entities which the clip affects, which is something we can know by restore time.

On the flutter gallery example app, there does not seem to be any performance regression - and the clips themselves comprise a trivial amount of GPU time. While that is only one example, its possible that this is only an Arm/QC vs apple GPU performance difference.

I would maybe try this against Wondrous on a high DPI iPad. I expect the performance is less than stellar on some screens there because of this.

The actual limiting the size of the draw call is no problem, we just gotta compute the area we need to cover better.

This is exactly the same as the optimization we were going to do for difference clips we talked about at some point, but never got around to it because they're so rare in practice.

My rough idea: set a scissor rect for the render pass sized to the outer coverage of the clip rect, keep the scissor applied until the clip is restored. Avoids having to compute exact coverage. Essentially the depth write covers the non-rectangular and multisampled parts of the clip, the scissor does everything else.

Yeah just using the clip coverage for the limiter is a good idea here. Pushed this to a patch here: https://github.com/flutter/engine/pull/51698.
I think trying to compute a smaller rect by unioning the coverage of all the entities is not worth the squeeze here...

The new gallery regression was fixed by https://github.com/flutter/engine/pull/51731. Doesn't look like this fix had an impact on complex layout, though.
https://github.com/flutter/engine/pull/51736 also just landed and will hopefully have an impact on some benchmarks.

We're doing better than before the regression after https://github.com/flutter/engine/pull/51736 landed. Closing this.

very nice!


collector initialization: move initial regenerateEvents() call to start of event processor loop

What
https://www.pivotaltracker.com/story/show/184071069
See commit messages for more details.
Running regenerateEvents() as part of EventStore.Init() means the collector process can't complete initialization of all its' worker loops until that has finished. This can become a problem if regenerateEvents() takes a very long time or is likely to fail, in which case the collection worker-loops may never get started at all - which is bad because they gather data which we may not get another chance to.
Instead, ensure the asynchronous event processor worker runs regenerateEvents() immediately once it is started, which, as it happens is very (very) shortly after it would have been started in the first place.
How to review
Deploy to a dev env, check the acceptance & integration tests continue to pass.

🚨⚠ Please do not merge this pull request via the GitHub UI ⚠🚨

Closed in favour of  #169


i18n(pl): translate integrations-guide.mdx

Description (required)
Translate integrations-guide.mdx to Polish.
Discord username: HSK (hskdaking)
Related issues & labels (optional)

Suggested label: i18n
Hacktoberfest: hacktoberfest-accepted

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

pl
guides/integrations-guide.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


fix: update citadel locker addr

Summary
Update staked citadel locker addr

:tada: This PR is included in version 1.12.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove the word "cursor" from the signature page since phone signers will be using their finger

This was already/no longer an issue by the time I picked it up to work on it.


Final image shows http instead of https

The final screenshot in the page showing the end result shows http instead of https.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de55a4d6-ea6b-c5b5-ba8a-a5c07ac91270
Version Independent ID: 5963e6fa-bf56-7e6c-7550-a89f62d30638
Content: Configure SSL for a cloud service
Content Source: articles/cloud-services/cloud-services-configure-ssl-certificate-portal.md
Service: cloud-services
GitHub Login: @tgore03
Microsoft Alias: tagore

@georgewallace Looks like @tgore03 is not a member of Azure-docs. I have assigned it to you. Let me know if this should be assigned to someone else.
@ShaneCourtrille Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close


NOACCENT.NOCASE comparison with a special character results in a segmentation fault

Consider the following statements:
SELECT '' COLLATE NOACCENT.NOCASE='Ʇ';

Unexpectedly, the SELECT results in a Segmentation fault when using a release build. In debug builds, it results in an assertion failure:
duckdb_cli: /duckdb/src/common/types/string_type.cpp:14: void duckdb::string_t::Verify(): Assertion `utf_type != UnicodeType::INVALID' failed.

I found this based on commit 1d2e40e01de260c9d3306a48c679bebd9a3f8744.

Very impressive find! This was caused by a bug in the lower function that did not correctly handle the case where the lower-case character had a different number of bytes than the regular-case character. This resulted in an incorrect UTF-8 string being generated. This is fixed now in 77f3151ecfa85dfa894f3a23feb2271a4cac1ddc.


[R] arrow::write_dataset segfaults on partitioning large data.frame

Describe the bug, including details regarding any error messages, version, and platform.
The following code produces a segfault in R (arrow 11.0.3, on Ubuntu Linux):
download.file("https://minio.carlboettiger.info/shared-data/tmp_df1.parquet", "tmp_df1.parquet")
df1 <- arrow::read_parquet("tmp_df1.parquet")
arrow::write_dataset(df1, tempfile(), partitioning="site_id") # segfault

Note that if we omit the partitioning, or if we use only the first 1e6 rows (the data.frame has about 11 million rows, and is nearly a gigabyte in RAM), the code does not segfault.
arrow::write_dataset(head(df1, 1e6), tempfile(), partitioning="site_id") # works fine

Component(s)
Parquet, R

Note that attempting to stream from the parquet to a partitioned version also leads to fatal error (segfault):
arrow::open_dataset("tmp_df1.parquet")  |> write_dataset(tempfile(), partitioning="site_id")

This appears to be a regression in 11.0.3, arrow 10.0.0 does not segfault.

works fine in the nightlies!  :tada: :tada: thanks @PMassicotte


WHEN I TRY TO COMPILE THE GAME I GET STUCK AT : Link: ApplicationMain.exe    Creating library ApplicationMain.lib and object ApplicationMain.exp

Describe your problem here.
Link: ApplicationMain.exe
Creating library ApplicationMain.lib and object ApplicationMain.exp
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No

what time do you wait


needs a way for people who dont want a twitter account to participate in the raffle

I am thinking about different options. When I come up with one that I think feels reasonable I will send a pull request.

Thanks for raising the issue. Happy to kick ideas around here too.
Email is slightly tricky because of the lack of automated way for us to check the<EMAIL_ADDRESS>email group (the current Twitter-based checker is quite well automated: https://github.com/go-london-user-group/raffle/tree/master/checker)
Slack might work?

hmm. I wonder if  we could use the meetup API to do this.
its nice because anyone who attends meetup, a priori, has to have a meetup login?

Great idea. Sent as direct message to the organizers? That would save spamming notifications to everyone


Submodule mbedTLS v2.16.6

Submodule mbedTLS v2.16.6
Description
Removed the previous copy of mbedTLS and replaced it with a submodule pointing to v2.16.6 of the library.
Test Steps
Locally ran the demo projects that can be found in the following directory:
"FreeRTOS-Plus/Demo/FreeRTOS_IoT_Libraries/"
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run checks

/bot run checks

/bot run checks

/cbmc run checks

/bot run checks


Switch to using 'inject: true' and not duplicating upstream functionality

The upstream html-webpack-plugin plugin used to include most logic in the actual template file, however in v2.29.0 switched to injecting the relevant markup into the template using JS (see https://github.com/jantimon/html-webpack-plugin/commit/c8a69255b9fd2f66a41457340629b738f2e18936).
Currently html-webpack-template must be used with that JS injection mode turned off (inject: false), since it instead re-implements much of the upstream functionality in the custom index.ejs.
This results in a few issues:

it breaks the plugin/event functionality of html-webpack-plugin (as noted in #48), which will become increasingly important as more plugins become available.
it means the upstream functionality has to be re-implemented/duplicated here, and this package doesn't automatically benefit from any bug fixes/new features from upstream (which are likely more frequent given the popularity of the upstream package).
it means there's a chance for slight behaviour differences for the features that exist both in upstream and this template, which could cause confusion when people switch between the two.

I would propose:

updating the docs here to say to use inject: true (this will require a major version bump)
removing the parts of index.ejs that are handled upstream, leaving just the custom funcationality

As an added bonus these changes will make it clearer what functionality this custom template adds, and then if in the future any of those features are upstreamed, this package can be simplified even further :-)
Thoughts? (If this sounds like something that would be accepted, I'm happy to open a PR.)

@edmorley thanks for outlining this.  The situation and proposed direction are clear and helpful to me.
I love the idea of slimming this template and no duplicating upstream functionality.  I know little about the fundamentals of what is broken and how changing inject true is going to fix it.  Perhaps you could point me toward some basic education on the subject.
I'm in favor of moving in this direction and would welcome a PR.

Hey @edmorley I still like the idea of this -- not duplicating upstream functionality.  I would welcome your expertise in adjusting it.  Are you still interested?  If not, no problem at all, and we can close this.  What do you think?

Hi! Sorry for the delayed reply. I'll try and take a look at a proof of concept PR this week :-)

Hi @edmorley , did you manage to take a look on this?

Without inject = true this plugin break other plugins. I played some hours with it and realize that I can use it.

Sorry for not having time to look at this. I believe it's something that's definitely worth doing, since in addition to the issues described in the OP, it caused breakage with this package when trying it with the new html-webpack-plugin v4 alpha. Those issues have since been fixed (html-webpack-plugin rolled back the breaking changes for now), however it proved how fragile inject: false is.
The Neutrino project has since switched away from using this package, so I probably won't have a chance to look at this - however happy to look over a PR if someone else does.
A first step to fixing this issue would be if someone could take a look at adding tests to this repository, that verified the output HTML for various combinations of options. Then when fixing this issue, it would be much easier to (a) review, (b) ensure no unexpected breakage.

Right now I'm developing the same with handlebars engine and it will be possible to use it with "inject = true" and it much cleaner solution. All these "<% %>" impossible to read.

A first step to fixing this issue would be if someone could take a look at adding tests to this repository,

I've filed #79 for this


Implement couch_file:format_status to log filepath

Erlang OTP logs the fact when gen_server behavior crashes. However in case of couch_file the filename is not part of the state. So it is quite hard to figure out what happened given the current log entry format. This PR adds information about filepath to the log entry. Keep in mind though that the filepath value is captured on couch_file:start_link. It is not representing the current file name if file is renamed or moved.

+1


BE, FE - Generate third party license file

add endpoint that will return it
it should generate for BE and FE as well

Inspirovat se zde: https://github.com/mojohaus/license-maven-plugin/blob/master/pom.xml


pushState should refresh page when passed the current location

My users want to refresh the page when clicking on a link that technically links to the page they're already on. For example, clicking the logo of a website on the index page would typically reload the index page. With History.js, it has no effect.
I tried a little hack which also didn't work:
var currentLocation = "/" + History.getState().url.replace(History.getRootUrl(), "");
if (currentLocation== url) {
  console.log("Refresh");
  History.replaceState(null,title,url);
} else {
  History.pushState(null,title,url);
}

Am I missing something is is this a bug or oversight? Thanks!

For the record, this works fine in IE, but doesn't in Firefox, Safari and Chrome.
Yeah you read that right. It works in IE, but fails in everything else. How often does that happen!?


Create a short Wiki

Create a short Wiki from the already existing README with some simple examples.

I can tackle this one, @punker76. It's the least I can do so I don't feel like a free loader :laughing:

Three pages up for your review, @punker76 .  I mainly used the same info from the README.md, but added a few small touches and broke it out into a few different pages that made sense.  If you want anything changed, let me know.

@amkuchta Thank you very much! 👍

@punker76 not a problem, my pleasure!  It's the least I can do!


bugfix: GitHub contexts do not work in scripts.

See here for specific details:
https://github.community/t/using-github-action-environment-variables-in-shell-script/18330
We previously moved the scripting to seperate files, and that silently
broke the workflow. This change eliminates all use of contexts in the
scripting, relaying on ENV variables instead.
Jira: HACBS-566
Signed-off-by: Jon Disnard<EMAIL_ADDRESS>

@davidmogar PTAL


doc: Include custom build for DEVELOPMENT.md

The DEVELOPMENT.md does not cover a case where a user wants to build/test a custom operator/payload image. This is to supplement the case. This also covers an update on the incorrect information for s390x e2e test.
This PR should be merged after an e2e test for s390x in #295 runs properly.
Signed-off-by: Hyounggyu Choi<EMAIL_ADDRESS>

The e2e test for s390x runs successfully (https://github.com/confidential-containers/operator/actions/runs/7564405180)

@BbolroC - can you re-based this to pick up the latest CI changes please (though I know it's doc, so not likely to impact them). Thanks


Old versions on Modrinth

The fact is that new versions of the mod have appeared only on CurseForge, but they still do not exist on Modrinth. Please upload them to Modrinth as well.

no I stopped uploading them to modrinth

Pity, may I know why? It is still used in some of my builds, but now, unfortunately, it is not updated. Anyway, thanks for the reply.

Uploading to both curseforge and modrinth is more effort than uploading to just curseforge
Curseforge gives me $500/month and modrinth only gives me like a dollar a month
Also More Red isn't save-compatible across major mc versions so it's a moot point


document new UI for cross-platform testing

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Aio] Unify the logic around Core Callback API for both sides

Fixes https://github.com/grpc/grpc/issues/20669
Let's see if tests are happy first.
This PR needs cherry-pick!

Known failure: https://github.com/grpc/grpc/issues/20436

Sorry for being so late, thanks for the changes!


feat(configuration): added support for unit suffix for maximum database size

Description
Added <numbers><unit suffix> pattern for max-db-size field in configuration file.
You can use a suffix: b, kb, mb, gb. Supports lowercase, uppercase and space between number and suffix.
The value without the suffix is bytes.
e.g.:
max-db-size: 1000 # 1000b
max-db-size: 1000b
max-db-size: 100000kb
max-db-size: 100 mb
max-db-size: 1 GB

Issues

Close #315

lgtm, could you rescan once more for the current usages as some new yaml's have been added since this PR was made. Once example is https://github.com/aquasecurity/postee/blob/main/cfg-docker-actions.yaml#L6

Hello @simar7
Thank you!
I pulled the changes and updated the new yaml.

Hello @simar7
Thank you!
I pulled the changes and updated the new yaml.

awesome thanks!


Add direct dependencies to launch config

For context, see https://clever.atlassian.net/browse/INFRA-1076.
This PR was autogenerated. @kvigen please review that the dependencies listed here are correct.
You were assigned this PR as the most active committer to this repo. Congrats!

lgtm


UnicodeEncodeError when putting a lenny face in to the additional info field.

Wow this is really stupid...

Kinda fixed in A 3.6.1
The issue is that the program is trying to pass unicode characters to the console, but the console can't render them. I will not fix this issue entirely since it doesn't need to be fixed, however I have added handling code into the program so that it can at least continue functioning in the event that this does happen. When the program encounters this error, it will simply display in logs and in console that it occurred, but it will then carry on it's merry way.


Add: Sum of Root To Leaf Binary Numbers

Codecov Report

Merging #475 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #475   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         163    164    +1
  Lines        1614   1625   +11
=====================================
+ Hits         1614   1625   +11

Impacted Files
Coverage Δ

...nary-numbers/sum_of_root_to_leaf_binary_numbers.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c8d1c...f07a053. Read the comment docs.


fix(input,select): set disabled underline color based on theme

Fixes the disabled underline blending in with the background in dark themes.
Increases the opacity of the disabled underline from 26% to 38% to make a bit more visible against the background.

I've rolled these changes into #5155. Closing.


solc: make flatten a loop and non recursive

Hits SO on https://github.com/gakonst/foundry/issues/998

Beleive this can be closed. Original issue was resolved after updating foundry.


[ART-4866] promote-assembly: run build-microshift after promoting a release

Changes look good, maybe worth running a dry-run hack job to see if everything works as expected?
In the jira story I see retry mechanism and slack notification on build failure, curious if we are covering it here?

/lgtm

Changes look good, maybe worth running a dry-run hack job to see if everything works as expected? In the jira story I see retry mechanism and slack notification on build failure, curious if we are covering it here? Edit: I see that they are covered here https://github.com/openshift/aos-cd-jobs/pull/3286/files

@thegreyd , yes, there is a dry-run (with unrelated steps commented out) https://saml.buildvm.hosts.prod.psi.bos.redhat.com:8888/job/hack/job/yuxzhu/job/aos-cd-builds/job/build%252Fpromote-assembly/59/console
Retry is handled by Doozer. Doozer retries 3 times in case of rpm build failure.

Another test run https://saml.buildvm.hosts.prod.psi.bos.redhat.com:8888/job/hack/job/yuxzhu/job/aos-cd-builds/job/build%252Fpromote-assembly/61/console after the second push.

/lgtm


Which Python version to use?

Describe the issue
I tried installing SWE-bench with various python version: 3.8, 3.9, 3.10, 3.11 and 3.12.
The requirements.txt lists this package: config
If you goto the package url you will see it is only supported till python 3.7.
The package config uses a package pysqlite which is not supported in python 3 instead there is an inbuilt package called sqlite3.
So my question is which python version are we supposed to use?
Is it possible to not use the package config as it is not supported in later versions of python?
The error stack I get when I pip install is this:
Collecting pysqlite (from config->sweagent==0.6.1)
Using cached https://pypi.uberinternal.com/packages/packages/42/02/981b6703e3c83c5b25a829c6e77aad059f9481b0bbacb47e6e8ca12bd731/pysqlite-2.8.3.tar.gz (80 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [1 lines of output]
pysqlite is not supported on Python 3. When using Python 3, use the sqlite3 module from the standard library.
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Suggest an improvement to documentation
Mention which python version is supported.

Ok I just removed the environment.yml file, as it is no longer necessary, but it should work for any of the python versions you've mentioned. We use 3.9, 3.10, or 3.11.
Also, we don't use the config library in swebench/ anymore. What code are you referring to? If you're on the latest version of SWE-bench, the config dep shouldn't be needed.

Actually, it looks like this is a SWE-agent bug you're referring to. If this is still a problem, please post an issue in princeton-nlp/SWE-agent instead.


Building from snapshot - error cached-profiles/snapshot.nix

Hi @astro ,
Thank you very much for this project, it's fantastic!
I followed the following steps:
git clone <this> && cd nix-openwrt-imagebuilder
nix run .#generate-hashes snapshot
nix build --override-input openwrt-imagebuilder "git+file://$(pwd)" .....

The .... is a directory with a flake - pretty much just your example with one change:
profiles = openwrt-imagebuilder.lib.profiles { inherit pkgs; release = "snapshot"; };

But I get an error:
error: getting status of '/nix/store/jja09jalv7h719v3f2q0q9y6282qqxd1-source/cached-profiles/snapshot.nix': No such file or directory

I realized that I'm missing a file in cached-profiles and I decided to run:
nix run .#cached-profiles snapshot

which after long run ended up with
error: unable to execute '/nix/store/qfsrqgfd8zz1fch7z6pw9qsapgcvpd5a-openwrt-cached-profiles/bin/openwrt-cached-profiles': No such file or directory

Could you please tell how to build a snapshot?
Thank you.

Thank you for your report!
.#cached-profiles is to be built with plain nix build
Please pull and retry.

It is working! Thank you @astro , amazing tool!


Copy build files to build/desktop instead of desktop/build/outputs

All other platforms copy their build files to build/platform. Hover copies them to desktop/build/outputs.
They should be under build/desktop.

We are considering changing directory named created by hover from desktop to go, #209.
We aren't part of the flutter team, so I don't like to interfere too much with the current directory layout.
That been said, the build directory is ignored in the .gitignore file, copying hover build files to build/go shouldn't cause any issue. It is also better for cleaning because flutter clean will delete the files created by hover

See go-flutter-desktop/hover#14

That sounds great @stuartmorgan!
I agree with @Drakirus about not interfering with the directory layout. Other directories in a flutter project are "owned" by other tools. Inside the go directory (now still desktop) we can do what we want without much chance of conflicts.

Closing this issue, we'll stick with the go folder for now.


Function flip - promise is not allowed

Not resolve and not reject, please fix.

@benbut , can you provide more details

try {     await Plugins.CameraPreview.flip();     console.log('flipped') // never happens } catch (error) {     console.error(error) // never happens }


MSSQL language syntax out of date

https://github.com/microsoft/vscode/blob/master/extensions/sql/syntaxes/sql.tmLanguage.json
There's been updates made to the plist from https://github.com/microsoft/vscode-mssql/blob/main/syntaxes/SQL.plist but it looks like the syntax here hasn't been updated. How often does this happen?
@alexr00

I update the grammars roughly once per month unless some lets me know about something particularly egregious. I'll probably update next week!

It looks like we are already at commit 61ae0eb21ac53883a23e09913a5ae77a59126ff9, which appears to be the most recent commit https://github.com/microsoft/vscode-mssql/commits/main/syntaxes/SQL.plist

@alexr00 Looks like something isn't going right with the conversion process then - in that commit we have the following :
		<dict>
			<key>match</key>
			<string>(?i)\b(ascii|char|charindex|concat|difference|format|left|len|lower|ltrim|nchar|nodes|patindex|quotename|replace|replicate|reverse|right|rtrim|soundex|space|str|string_agg|string_escape|string_split|stuff|substring|translate|trim|unicode|upper)\b</string>
			<key>name</key>
			<string>support.function.string.sql</string>
		</dict>

https://github.com/microsoft/vscode-mssql/commit/61ae0eb21ac53883a23e09913a5ae77a59126ff9#diff-77fe01e5ece1baf6fab2accf8a6c81a998ef5c219e50b225fb6dcaa62efa81bdR396
But if we diff that with the matching entry in https://github.com/microsoft/vscode/blob/master/extensions/sql/syntaxes/sql.tmLanguage.json
		{
			"match": "(?i)\\b(ascii|char|charindex|concat|difference|format|left|len|lower|ltrim|nchar|patindex|quotename|replace|replicate|reverse|rtrim|soundex|space|str|string_agg|string_escape|string_split|stuff|substring|translate|trim|unicode|upper)\\b",
			"name": "support.function.string.sql"
		},

I see that it's missing some of the values, for example right

@Charles-Gagnon thank you for your diligence. It seems that microsoft/vscode-mssql changed the name of their default branch, and out language updating scripts are not very smart and just hardcode the branch. I have updated the script with the correct branch name and updated the grammar!

Awesome, thank you!


Casting to google group

I have multiple google speakers.
When I create a group, I see that the ip address for the group speaker is the same at one of the individual speakers.
Is there a way to cast to the speaker group?  or is this limited to one google speaker?
Pychromecast is able to cast to a group based on the friendly name.

nvm!
I noticed you have the port hardcoded to 8009
I can just adjust that for the google group port.

actually, I just tried it with the host and port of the google group, and I got this error:
File "/lib/pichromecast.py", line 33, in play_url
IndexError: list index out of range

Any thoughts on how I can resolve this to cast to a google cast group?

I think your issue is not specific to groups. Check this out for a solution.


[feature] Kubernetes support in UI

podman generate kube <container | pod | volume> --> Generate Kubernetes YAML based on containers, pods or volumes (doc)
In UI, view YAML from containers, pods or volumes and save/copy YAML buttons
podman play kube <kubernetes yaml filepath> --> Create containers, pods or volumes based on Kubernetes YAML (doc)
In UI, import Kubernetes YAML from text or file and create it
podman pod ps --> Prints out information about pods (doc)
In UI, a section tab to show all Pods

Last point has been addressed in last commit

Features have been added to 4.1.0-rc.9


Eisenhower Matrix Box

Add Eisenhower Matrix, a powerful decision-making tool

Urgent
Not Urgent
Important
Not important

Added


Marker is not exported

Thanks!
https://github.com/beyonk-adventures/svelte-mapbox/commit/7c9412557215a179eff0b154411e9f223ab1f47b

I edited in github, so I couldn't run prepublish, could you make a build?

@kidandcat it's all automated :) you just have to wait a minute or so

Spoke too soon - try version v4.0.2 :)


Update to Fedora 36

Fedora 35 is end of life in less than a week
and might not get all the latest Python updates.

Will you release also a new version of the GH action?

Once this is ready at dockerhub, that is the plan.


[SPARK-37405][PYTHON] Inline type hints for python/pyspark/ml/feature.py

What changes were proposed in this pull request?
Inline type hints for python/pyspark/ml/feature.py
Why are the changes needed?
We can take advantage of static type checking within the functions by inlining the type hints.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests

cc @HyukjinKwon , @zero323

also cc @itholic

cc @zero323

Now there are:
* Unused import of `TypeVar`.

* Import from `pyspark.ml._typing` should be in type checking block.

updated, thanks

Now there are:
* Unused import of `TypeVar`.

* Import from `pyspark.ml._typing` should be in type checking block.

Oh, I don't know why when I push from pyspark.ml._typing import P, JM into TYPE_CHECKING, GitHub action has failed, hope your clarification, thanks

Other than issues listed above, looks OK.

Thanks for your time to review this, @zero323 !

@dchvn Can you address the comments when you find some time ?? Otherwise looks good to me. 👍
Also mind addressing https://github.com/apache/spark/pull/34324 ?? now we have only 2 PRs for completing the PySpark  type hint ticket.
Thanks for your contribution!

Updated, Thanks for your time @zero323 @itholic

GA has failed, so check the tests at my forked repo: https://github.com/dchvn/spark/actions/runs/2165657489
Thanks

Merged into master and branch-3.3.
I am going to handle https://github.com/apache/spark/pull/35530#discussion_r847442480 in a follow-up.

Thanks @zero323


chore(cli): app deploy can get the uri of multiple app types

Once we merge https://github.com/aws/amazon-ecs-cli-v2/pull/876, it should be a single line update to add the constructor for a BackendAppDescriber.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Ginkgo ran 5 suites in 1h46m21.7768809s
Test Suite Passed


access_token.refresh() unauthorized

I have a Python script that I am running to pull Ad and Campaign data from the Pinterest API. I am trying to refresh my access_token in the script but am getting an error. I am able to run the python/scripts/refresh_access_token.py without issue, however when I mimic the steps in my Python script I have an issue. Here is a code snippet and screenshot of the error. Please let me know if I can provide any additional context. Thanks.
api_config = ApiConfig(version=5)
# Setup access token
access_token = AccessToken(api_config, name='access_token_v5')
access_token.read()
access_token.refresh()

Hello! Glad to hear that refresh_access_token is working, because that means that the end-to-end system is working in general. I'll try to find some time to replicate the issue that you're seeing and figure out a fix.

Thanks for the quick response and I appreciate your help. Please let me know if there is anything I can do to help.

Hello! I reproduced a similar looking problem by intentionally corrupting the refresh token in the file where it is stored.
$ ./scripts/refresh_access_token.py -a catest
Using application ID and secret from PINTEREST_APP_ID and PINTEREST_APP_SECRET.
read chaikenacm from /Users/dchaiken/code/api-quickstart/common/scripts/../oauth_tokens/catest.json
refreshing chaikenacm...
POST https://api.pinterest.com/v5/oauth/token
<Response [401]>
request failed with reason: Unauthorized
x-pinterest-rid:<PHONE_NUMBER>818566
{'code': 283, 'message': 'The authorization grant is invalid'}
Traceback (most recent call last):
  File "/Users/dchaiken/code/api-quickstart/python/./scripts/refresh_access_token.py", line 55, in <module>
    main(sys.argv[1:])
  File "/Users/dchaiken/code/api-quickstart/python/./scripts/refresh_access_token.py", line 32, in main
    access_token.refresh()
  File "/Users/dchaiken/code/api-quickstart/python/src/access_token.py", line 189, in refresh
    unpacked = self.unpack(response)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/dchaiken/code/api-quickstart/python/src/api_common.py", line 87, in unpack
    raise RuntimeError(status)
RuntimeError: request failed with reason: Unauthorized

Here are a few thoughts...

It probably won't fix the problem, but it would be helpful to update your fork of this repo to the main branch. (If you would prefer, I could do a formal release of the main branch (which I haven't done in a while).
It would help to be able to see the log that shows the error returned from the API. For example, {'code': 283, 'message': 'The authorization grant is invalid'} in the error above.
I wonder whether the error that you're experiencing has something to do with the way that the access token is originally created and stored along with the refresh token. The default location is at /common/oauth_tokens in this repo. You might want to have a look at the access_token_v5.json file that stores the access token and associated refresh token to make sure that it has all of the expected information.

If none of these thoughts help you, I'd like to figure out how to get more complete logs from your application (which is tricky, because we shouldn't be sending the actual tokens to each other).

Thanks for your help here, I was able to resolve the bug.

Thanks for your help, I was able to resolve.


[v2.8] [Maintenance] Bump embedded system-agent within rancher-wins

For some time now rancher-wins has been embedded system-agent version v0.2.11, which is very outdated at this point (the most recent release is v0.3.6, with 0.3.7 planned for release alongside 2.9.0). Importing this outdated version of the system-agent results in wins also importing outdated indirect dependencies which contain CVEs. In order to resolve a number of CVEs within rancher-wins, we will need to update the embedded system-agent version.

A full regression test will need to be done when this bump in merged into rancher/rancher, to ensure that the updated system-agent version does not introduce any regressions. This includes custom and node driver provisioned clusters, as well as upgrades and workload deployment.

QA TEST PLAN

#
Scenario

1
Run provisioning automated test suite on fresh install of v2.9-head

2
Run nodescaling automated test suite on fresh install of v2.9-head

3
Run snapshot automated test suite on fresh install of v2.9-head

4
Run upgrade automated test suite on fresh install of v2.9-head

5
Run certrotation automated test suite on fresh install of v2.9-head

6
Run provisioning automated test suite upgraded Rancher to v2.9-head

7
Run nodescaling automated test suite upgraded Rancher to v2.9-head

8
Run snapshot automated test suite on upgraded Rancher to v2.9-head

9
Run upgrade automated test suite on upgraded Rancher to v2.9-head

10
Run certrotation automated test suite on upgraded Rancher to v2.9-head

Waiting for latest RC/alpha before testing. The latest head commit is from July 28th.

Performed testing below. See results below:
ENVIRONMENT DETAILS

Rancher install: Docker
Rancher version:

Fresh install: v2.8-head https://github.com/rancher/rancher/commit/d6b82343899fae7c2b4dd19afacccfa275d642ee
Upgrade: v2.8.3 -> v2.8-head https://github.com/rancher/rancher/commit/d6b82343899fae7c2b4dd19afacccfa275d642ee

TEST RESULT

#
Scenario
Result

1
Run provisioning automated test suite on fresh install of v2.8-head
:white_check_mark:

2
Run nodescaling automated test suite on fresh install of v2.8-head
:white_check_mark:

3
Run snapshot automated test suite on fresh install of v2.8-head
:white_check_mark:

4
Run upgrade automated test suite on fresh install of v2.8-head
:white_check_mark:

5
Run provisioning automated test suite upgraded Rancher to v2.8-head
:white_check_mark:

6
Run nodescaling automated test suite upgraded Rancher to v2.8-head
:white_check_mark:

7
Run snapshot automated test suite on upgraded Rancher to v2.8-head
:white_check_mark:

8
Run upgrade automated test suite on upgraded Rancher to v2.8-head
:white_check_mark:

9
Perform encryption key rotation
:white_check_mark:


Update integration README by adding a missing command-line flag and fixing typos

Please provide a description of this PR:
Update integration README by adding a missing command-line flag -istio.test.skip and fixing typos.

Hi @Winbobob. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

I wonder if the flags might be better in a table: Name, type, description.
Looking at the README, some of the descriptive text goes off the right hand side of the page and is lost. A table would allow all the text to be seen.

/ok-to-test


Make logging less noisy

I just played around with the client and the logging would seem scary to someone unfamiliar with the code base (many errors and warnings). We should try to investigate the errors and either fix them if something is broken or try to tone down the logging. E.g. a failed API request that can still be retried isn't really an error.
[nix-shell:~]$ mint-client-cli client2 reissue AQAAAAAAAABAQg8AAAAAAAoAAAAAAAAAIAAAAAAAAAB/bKuHcgzHSChmPt3BLyLbuhpqctoV6rzLddfE7TNDhjAAAAAAAAAAqUHqVivwLD++MMnCgT9lj2yv1+s41HfTHmMpqzXil6pjE5E97psGJUc1QjuBSK2l6/XMWmUQLEmXjoyJzwGt5kYBR23NrA/g+2XuPyq6zAkgAAAAAAAAAH8dBsvMZWa/dMmNKN2SiIBKQntnAQomW5wPlZjJUrprMAAAAAAAAACT5K91cd54Mvndo+td0UlgMlBdMaCJplX2mtIEayls8GwG6A11fi7uR5P3Qf/vBFrL5Klhj+2kwkQ5snhzldoUojx7pl5GkjS0aDQQ6R6mXSAAAAAAAAAAdnT42f3IypipSdHsrQwLuVm8feLWqG1s7k5wSp93SVMwAAAAAAAAALYl+7d8K/538w5bz0W4HZl0buOb+q2L2MAJFKAkxgP32cnIWEsSaT7Vq9Lag72v6nlxB6VKRGpza5sGntMCGGMS9bu3PYWyjUTsUfhstwWuIAAAAAAAAABvDdKzDQ7QG3YQ5IrkNl8dLf66PaNl8j88X49k4XElZjAAAAAAAAAAg4PViMJCfPN3k4HTgKQuvxzQahBCBT2xM7F09Zlnk3VTmpH8KE602BvzrS86lAY/6YqPWYTia3kQUAPP82hvnGAcP/V3XE3QTtbf1Yv3AvYgAAAAAAAAAG5mEYedQiTJcC9b+iu+8rhQssL2cq8yHQIe/BpMRnt9MAAAAAAAAACzVczhexAKSneNwRCzIzWmEUEHjW97cTxAW76IPc/hRNcceA/rHzLWtPBQhHSopiK0D3WVmQTp6eDvDDRqzj5joo9qLl3OeRqxRdIedwRP5CAAAAAAAAAAa/HudczkFExFocDeFCcv8Ip3kXVU4cx+1CH+OFZRpjEwAAAAAAAAAKuRlaLZ+Y7n7xYkrg9Jc7RP1kie/poznNAhM8s9pZl96GPdU1+sqQzzn/Zjsp8wslGfnZlRNHNeNZJo0eoiHg//D60zw03agQJjOKY3Q3xcIAAAAAAAAABob98hBPswiL/rffq37Zbyu7ibebN0qbuPOyNf+WNc2jAAAAAAAAAAij8itbkNeznGux3b2BdSRUNWP+c/SBLvyW/RXJghOcbyGq/LvIAZ9Z/u9T8KkDH+dQ/5FNMRletHAzuNQ6GgoDbcyx3942LgRZSY+9n8rH0gAAAAAAAAAEydemglxFmsIO14MXejLVi0zNlHa+vuIU3CWflQaJg1MAAAAAAAAAC5pIE4YCplnqG5CGhHSstIjs1LGhMsiTBWD2Z1EBkAoZzzkf1gyS7ol6cewkV7Rwk3svEeUw68mzshlMb0+z64rWWHlzWSoIT+Z/33MPoD3CAAAAAAAAAAO2vIWJQOV+w4Ry1vH+MMJh1Hh9c0QEpYfTBj3lopzcowAAAAAAAAAIZbnZh/xiOevtwDPyUJitHChk04vUcrBNqjAKVsKW/LtxzYYYEg4QjDdizbm6j9OCrQBcfu0vUhJ6MLRRV20Kn2Vmc4Ic00fqrIz+pHTT6VIAAAAAAAAAAyPfRI7/9VaDFahe7VuWAo57BCH1eLp5Yc0EOpFVQmLjAAAAAAAAAAj7iDrgpf4RFYAoLfGGp8PgDTjha4xJw1cCWdMUKtR+tVJTaY3+MglV4xTvgaj2QsHnFrSxWGE3ahGz0kQrGzv3iWGq8jo1BfGDKvYF8HZeM=
2022-08-12T08:59:41.039946Z  INFO mint_client_cli: Starting reissuance transaction coins=10000000 msat
2022-08-12T08:59:41.047629Z  WARN request{peer=0}: mint_client::api: web socket not connected, reconnecting
2022-08-12T08:59:41.048604Z  INFO request{peer=0}: jsonrpsee_client_transport::ws: Connection established to target: Target { sockaddrs: [], host: "fm.sirion.io", host_header: "fm.sirion.io:5000", _mode: Plain, path_and_query: "/" }
2022-08-12T08:59:41.087887Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087907Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087910Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087914Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087917Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087921Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087924Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087928Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087931Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.087934Z ERROR minimint_api::db::rocksdb_impl: Database deleted absent element! This should not happen!
2022-08-12T08:59:41.088045Z  INFO mint_client_cli: Started reissuance, please fetch the result later id=9906a5cdc9e78f21849b93407d5d9e0080c2c1eefaf57da0d952796b7807440d:0
2022-08-12T08:59:41.129239Z  WARN jsonrpsee_core::client::async_client: Custom("[backend]: frontend dropped; terminate client")

[nix-shell:~]$ mint-client-cli client2 fetch
2022-08-12T08:59:46.465415Z  WARN request{peer=0}: mint_client::api: web socket not connected, reconnecting
2022-08-12T08:59:46.466482Z  INFO request{peer=0}: jsonrpsee_client_transport::ws: Connection established to target: Target { sockaddrs: [], host: "fm.sirion.io", host_header: "fm.sirion.io:5000", _mode: Plain, path_and_query: "/" }
2022-08-12T08:59:46.508587Z  INFO mint_client_cli: Fetched coins issuance=9906a5cdc9e78f21849b93407d5d9e0080c2c1eefaf57da0d952796b7807440d
2022-08-12T08:59:46.527896Z  WARN jsonrpsee_core::client::async_client: Custom("[backend]: frontend dropped; terminate client")

[nix-shell:~]$ mint-client-cli client2 info
We own 10 coins with a total value of 10000000 msat
We own 10 coins of denomination 1000000 msat

[nix-shell:~]$ mint-client-cli client2 ln-pay lntbs420n1p30v9fqsp5el2676mxjgzsqzrp0qk4xsdx0996ap9ssn6gmxs8ztf5euu9eyyspp5qllxdet5s927h0w0d0rxfeemwez0ck5klqzzh9epzjut90awndsqdrv2pskjepqw3hjqer9d4hjq2z0wfjx2u3qf9zr5grrwfhhwerxw4hxgttpwpc97veng96n242ywdg9wmj4fs65w4j58pcnzkt2dam8wwpnfv5sxqzurcqp29qyysgqlm5xs7c24hdek9m0jjunvnsfzpup3zcz4jldmml27wmeuu52wd45eturyylqhxkjux65jd0utsasd6njct7338kk3awkych3f6qeqaqphzzkdf
2022-08-12T09:00:00.308867Z  WARN request{peer=0}: mint_client::api: web socket not connected, reconnecting
2022-08-12T09:00:00.310195Z  INFO request{peer=0}: jsonrpsee_client_transport::ws: Connection established to target: Target { sockaddrs: [], host: "fm.sirion.io", host_header: "fm.sirion.io:5000", _mode: Plain, path_and_query: "/" }
2022-08-12T09:00:00.356200Z ERROR request{peer=0}: mint_client::api: error=RPC call failed: ErrorObject { code: ServerError(404), message: "transaction not found", data: None }
2022-08-12T09:00:01.371777Z  INFO mint_client_cli: Funded outgoing contract, notifying gateway contract_id=8b5507f8a6bc1a85654b19ce80fe6c8a9919513641a5593d665233615d41b561
2022-08-12T09:00:03.553726Z  WARN jsonrpsee_core::client::async_client: Custom("[backend]: frontend dropped; terminate client")

We should also indicate that the payment succeeded.


Model for prediction of distant relapse

In this issue, we detail the work done to build a model able to predict the occurrence of a distant relapse (meaning non-local).
For each participant, the values were averaged across nodules. We consider to have a distant relapse if any of these relapses occurred:

rechute_homo
rechute_contro
rechute_horspoum
rechute_med
We computed the delay of occurrence of a distant relapse as the average of the delays of occurrence of any of the above mentioned relapses. Here is the distribution of the delays of occurrence of these relapses.

Number of subjects which had a distant relapse: 67
Number of subject for training: 130
Number of subject for testing: 33
Here are the performances of the 3 models trained:

Model without any occurrence deadline:
Model performance:

ROC AUC Score:  0.726923076923077
Brier score: 0.19839296981051371
Average precision: 0.7777777777777778
Average Recall: 0.5384615384615384
Accuracy Score:  0.7575757575757576
AUC-PR score: 0.749028749028749

Model for prediction of distant relapse within 1 year:
Number of subjects that had a distant relapse within 1 year: 23
Number of subjects that had a distant relapse within 1 year (train): 21
Number of subjects that had a distant relapse within 1 year (test): 2
Model performance on the deadline of 1 year

ROC AUC Score: 0.11290322580645162
Brier score: 0.1145299780607971
Average precision: 0.0
Average Recall: 0.0
Accuracy Score: 0.8787878787878788
AUC-PR score: 0.030303030303030304

Model for prediction of distant relapse within 3 years:
Number of subjects that had a distant relapse within 3 year (train): 48
Number of subjects that had a distant relapse within 3 year (test): 13
Model performance on the deadline of 3 year

ROC AUC Score: 0.6269230769230769
Brier score: 0.2566913466094455
Average precision: 0.5454545454545454
Average Recall: 0.46153846153846156
Accuracy Score: 0.6363636363636364
AUC-PR score: 0.6095571095571095

Hyper-parameter wasn't done since it proved to lower performance as explained in this comment.

Same as in this comment, I added train/test splitting across sites, removal of features and hyperparameter finetuning.
Here is the model output:
Feature data shape: (163, 139)
Target data shape: (163, 2)
Number of subjects which had a distant relapse: 67

Number of subject for training: 136
Number of subject for testing: 27

Model performance without any occurence deadline
ROC AUC Score:  0.6172839506172839
Brier score: 0.2704013019646528
Average precision: 0.5
Average Recall: 0.5555555555555556
Accuracy Score:  0.6666666666666666
AUC-PR score: 0.6018518518518519

Number of subjects that had a distant relapse within 1 year: 23
Number of subjects that had a distant relapse within 1 year (train): 18
Number of subjects that had a distant relapse within 1 year (test): 5
Model performance on the deadline of 1 year
ROC AUC Score: 0.42727272727272725
Brier score: 0.18168762483647793
Average precision: 0.0
Average Recall: 0.0
Accuracy Score: 0.7777777777777778
AUC-PR score: 0.09259259259259259

/
Number of subjects that had a distant relapse within 3 year: 61

Number of subjects that had a distant relapse within 3 year (train): 52
Number of subjects that had a distant relapse within 3 year (test): 9
Model performance on the deadline of 3 year
ROC AUC Score: 0.6851851851851851
Brier score: 0.26541833623235794
Average precision: 0.4166666666666667
Average Recall: 0.5555555555555556
Accuracy Score: 0.5925925925925926
AUC-PR score: 0.5601851851851852

Initial number of features: 28
Number of subject for training: 136
Number of subject for testing: 27

Model performance without any occurence deadline
ROC AUC Score:  0.47530864197530864
Brier score: 0.3582369294948105
Average precision: 0.36363636363636365
Average Recall: 0.4444444444444444
Accuracy Score:  0.5555555555555556
AUC-PR score: 0.49663299663299665

Number of features after variance thresholding: 25
Number of features removed by variance thresholding: 3

Model performance after variance thresholding
ROC AUC Score:  0.5802469135802469
Brier score: 0.3231744471903118
Average precision: 0.4
Average Recall: 0.4444444444444444
Accuracy Score:  0.5925925925925926
AUC-PR score: 0.5148148148148148

Number of features after correlation thresholding: 23
Number of features removed by correlation thresholding: 2

Model performance after feature selection based on correlation
ROC AUC Score:  0.617283950617284
Brier score: 0.32686233103625645
Average precision: 0.42857142857142855
Average Recall: 0.6666666666666666
Accuracy Score:  0.5925925925925926
AUC-PR score: 0.6031746031746031

Number of features after correlation with target thresholding: 13
Number of features removed by correlation with target thresholding: 10

Final features of the model:
['age', 'BMI', 'OMS', 'tabac_sevre', 'histo', 'T', 'etalement', 'MORPHOLOGICAL_Compacity', 'INTENSITY-BASED_IntensityInterquartileRange', 'INTENSITY-BASED_AreaUnderCurveCIVH', 'GLCM_ClusterProminence', 'GLRLM_RunLengthNonUniformity', 'NGTDM_Contrast']

Model performance after feature selection based on correlation with target
ROC AUC Score:  0.5802469135802469
Brier score: 0.3452606850303094
Average precision: 0.4
Average Recall: 0.4444444444444444
Accuracy Score:  0.5925925925925926
AUC-PR score: 0.5148148148148148

Model parameters after hyperparameter tuning:
OrderedDict([('colsample_bytree', 1.0), ('gamma', 0.0), ('learning_rate', 0.5), ('max_depth', 4), ('min_child_weight', 3), ('n_estimators', 369), ('reg_alpha', 0.0), ('reg_lambda', 0.0), ('subsample', 0.5)])

Model performance after hyperparameter tuning
ROC AUC Score:  0.691358024691358
Brier score: 0.30101305793088085
Average precision: 0.5
Average Recall: 0.7777777777777778
Accuracy Score:  0.6666666666666666
AUC-PR score: 0.6759259259259259


feat: install shots in albums and select mode

Description
This PR resolves MOPLAT-340
Install shots in albums and select mode
⚠  after this PR is merged and shipped, we will need to reinstall the app, because there was some change in the GlobalStore models, and we don't have migrations yet.
PR Checklist

[ ] I tested my changes on iOS and Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

Looks good. Feel free to merge


make a 3ds port of this

thats literally it

and make a web port too

The framework this game runs on cannot be compiled for 3ds.
The game is already available for web on the following links:
Platinum: https://marbleblast.randomityguy.me
Gold: https://marbleblastgold.randomityguy.me
Ultra: https://marbleblastultra.randomityguy.me


Mag sensor inconsistent error

Using the latest stable release of PX4 and latest stable release of QGroundControl, "Mag sensor inconsistent" errors pop-up as pre-flight checks fail.
When doing the calibration with a 2018 August QGC build, the problem disappears.
Expected Behavior
After a successful Firmware update (PX4 stable), and a successful sensor calibration (for a Deltaquad airframe) the magnetometer inconsistency check has so far been working properly.
Current Behavior
When using the latest QGC stable build, the inconsistency pops up and pre-flight checks fail, causing the arming to fail.
Steps to Reproduce:
The orientation of the board must be 90 degrees roll, 90 degrees yaw.

With the latest stable version of QGC for Ubuntu flash the latest stable firmware.
Calibrate everything from fresh with the latest version of QGC for Android (Or Ubuntu)
Restart the drone
Mag sensor inconsistent and 90 degree heading offset is seen

System Information

Ubuntu 18.04
QGC build which drops error: QGC Development HEAD:1bf12b5b3 2018-11-13
QGC build which fixes error: QGC Development HEAD:9cb4f2ddc 2017-08-07
Flight Controller: Dropix v2.1 from Drotek
Primary Compass: Ublox NEO-M8N GPS + LIS3MDL compass
Autopilot (with version): PX4 1.8.1 stable

Additional related problem
Another issue that pops up is when the measured compass heading is about 90 off true heading. Calibration was done in relatively empty fields. The offset seemed to be consistent
This is either PX4 estimator related or calibration related.
Log Files and Screenshots
Short test where the drone is pointing close to North direction:
https://review.px4.io/plot_app?log=17da1d39-138e-4495-b304-4630c6c58a76
A screenshot of the error when it pops up on on Android tablet:

Thanks for any help!

Hey;
Few more steps you can use to debug it yourself:

Enable SDLOG_PROFILE enable "sensor comparison".
Open the log with FlightPlot (java application)
In that log, you'll have the raw sensor data, plot the data for all XYZ axis and you'll see if they are consistent or if there is a problem (such as wrong orientation).
Double check SENS_BOARD_ROT parameter (currently 18)

@DavidMackie Have you solve the problem, I also have "Mag sensor inconsistent" errors and the controler cannot be started because of the problem.


How do I pull data from GitHub?

Research

How do I have a scheduled process run inside Heroku?
How do I clone a repo from GitHub inside a Heroku process to push to our database?

What libraries should we use?

Scheduling
Interacting with GitHub? (Is that even necessary? Prob not?)

Implementation:

Come up with an example script that runs inside of Heroku

Libraries We Need:

Scheduling
Ruby-Git


argv an argc variables/functions

We have to implement such usual variable/functions in our module 'os', by the way, we probably must rename it to 'sys' as well.

I implemented a temporary solution to this issue. What did you think?

It's great. Thanks.


Process: remove some duplication in RunLoop setup

This was being constructed twice as possibly an accident.  Preserve a
single instance of the constructor.

CC: @phausler @parkera @millenomi @spevans

@swift-ci please test


Papilio 45 delete employee

added deleted employee function

I have added the a delete employee button beside the add employee ( the buttons are visible when the user is Admin)
At the mean time , I comment out "if (employee.role !== 'Admin') { return <></>; }" in order to see the buttons at all cases
The delete form is a checklist form. When clicking on the delete employee  button , user can select the exist employees that needs to be deleted  , and click on the delete button.
In order to have the dynamic checklist on the delete form , I changed the employee data from static to dynamic in the Table file
the features was tested successfully  when re-producing. I was able to open the delete from and the selected employees were deleted from the employee list once clicking the delete button.

I don't see any call to the backend. Not sure how this would work on non-hardcoded scenarios
You should have a feedback before the user actually delete the employee. Like, Are you sure you want to delete?
You shouldn't allow the user to delete themselves from the list.


Adds detection logging messages at info level

Summary
This PR adds additional logging when Detect returns false for this buildpack. This is to provide more information about why the detection failed for this buildpack when verbose/debug logging is enabled.
As of lifecycle v1.16.0, if the detect phase fails as a whole, log messages are printed at info level by default, without the need for the verbose flag.
Use Cases
A pack build command with the --verbose flag set will show these log statement if detection fails. If Detect succeeds, the output is not shown unless --verbose is set.
Checklist

[ ] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Thanks - I added this, it's only useful if there are env-vars as part of the detection but we shouldn't have a config-resolver if there are none.
I added this too for extra info


Run imageupload unit-tests in parallel

What this PR does / why we need it:
Run the tests in 4 seconds instead of 30 seconds.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/retest

/retest

/cc @mhenriks


Add a License to project.

Add a license to the project for easier use and collaboration.

MIT license added to project


Profile Page Completed

The profile page needs to be filled out with relevant data, and must allow users to add their social media details/reset their password/view their points history.

Moving to release target; this is important but basic functionality is fine for now


Fixed copy-paste typo in NotifyRouteChange2

interface => IP route

@alexbereznikov : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Parse ticket API error

If we got error response from ticket API it's better to exit gracefully.

I mean tickeR API :)

Thanks for the patch!


Trickster RIP? 3 years, no releases, no answers

Are you there?

I'm closing this as duplicate since this discussion is already happening here. I've quoted my response today below.
To answer your immediate question, yes, we're here! Dev time has been restricted, but we're finalizing the last couple things for v2. While we work on that, community contributions are encouraged and processed fairly quickly.

Here's where we are on the next v2 beta:

There are some dependencies that need updating
The Clickhouse multi-line query is fixed, but there's an error in testing that I haven't resolved yet
Autodiscovery needs a couple more changes to be merged into v2

I have some time carved out this weekend to power through these items. We're getting the beta out the door as soon as we can, but please understand that we're largely volunteers that are also managing professional and personal lives. Turns out having a full-time job, like being in college, isn't super conducive to open source dev time. I wish someone had explained that to me sooner! :sweat_smile:
Regardless, I am really sorry about the delay, and I know explanations like this don't get you an updated Trickster version. Please keep an eye on pull requests over the next couple of weeks as I wrap up these last action items--that'll be a better metric for progress than any estimate I give here.


Fix existing: Extrude from command bar selects extrude line after

Resolves  #3545
Oh, it resolves #3546 too.

I'll fix the other tests tomorrow. @franknoirot caught it's probably useAbsoluteFilePath changed causing the others to break. I think I might have a workaround but we'll see tomorrow.


general: Update IndexOf Usage to Includes Where Applicable

Update the general usage of indexOf() to instead use includes() where the check isn't looking for an actual index but instead checking if value exists within a collection.

Thank you for the cleanup!!


Interest in table and miscellanous symbols live templates?

I am currently supplementing my use of this plugin with live templates to write tables and include a few mathematical symbols that were missed.
For example, I have a custom live template \tab5 for a table with 5 columns, and \rightarrow for \rightarrow (because the default plugin doesn't suggest \rightarrow in autocomplete)
I can make a PR with these live templates. Do the maintainers of this plugin have any interest in this?

It does depend on the kind of live templates. I'd love to have some by default (besides using live templates for hacking autocompletion :P).
The reason \rightarrow is not showing up in your autocomplete, is because it is listed as a math command. Those are (currently) only available in Math mode. We could add them to the regular autocomplete as well.

@PhilipAxelrod The switching inside frac is interesting, how did you do that? See #266. I didn't know live templates could do that. Although I think it would be better if the code handling that was inside this plugin, it's better than nothing.

Ah yeah, that's nice! But it doesn't work when I have my caret right after a symbol like $ because I think IntelliJ thinks that the $ is like a letter belonging to the word you're typing. It works with brackets, at least.
I like the second one, because with the issue of the first one it's not useful to use shift+tab, so we might as well disable it anyway. Does @RubenSchellekens agree to have this one by default?
@PhilipAxelrod Would be great if you could make a PR for this one! I don't know how adding a default live template would be implemented, but I guess it should be possible.

I will look into this link https://www.jetbrains.com/help/idea/sharing-live-templates.html to figure out how to include this


Adjust position of text input cursor

Not sure how I would adjust the text input cursor position so there is a space between the left-edge of the search bar and the text cursor?

Do you mean adding a left padding to the input:
.react-autosuggest__input {
  padding-left: 20px;
}

or something else?


Getting error: Will not attempt to authenticate using SASL (unknown error)

I followed the steps as given an readme page. I deployed the kafka service broker.
But while creating the service instance it get's failed. When I checked the logs, it's showing following error:
Will not attempt to authenticate using SASL (unknown error)
Please help me to fix this.

Hi cfmagnum. based on similar issues, this might be a firewall/connectivity problem. See here for example: https://github.com/wurstmeister/kafka-docker/issues/47. Have you taken a look to see that your kafka nodes can speak to your zookeeper nodes?


SATA to dSATA Staking Pool

The token allocation to be made:
5,000,000.00 dSATA
The purpose of the allocation, and a justification as to requiring the modification to be made:
24,000,000+ dSATA are expected to remain in circulation after the migration period ends. To provide an opportunity for SATA holders to earn governance tokens, a pool for staking Ethereum SATA to earn dSATA is proposed to be created.
Proposed parameters for the pool:

Pool ends 2022-11-30 (6 months)
7 day minimum staking time
3.8954 dSATA earned per block across all users in the pool
The pool will be established on the OKLG token farming service. Yield is not static. More SATA entering the pool will lower the yield for all stakers (as well as the inverse being true).

The dSATA contract will not collect fees for moving dSATA in or out of any staking pool

I am not against the proposal, but just want to voice my concern that it is possible for a large number of dSata to be accumulated by whales and have a large amount of control over the direction of the DAO.
Hopefully this staking pool allows a larger distribution of governance tokens across our holder base.

I support this proposal, and think that it could be implemented just as Tim has suggested.
SataCenturion is right to a degree, but I'm not sure how we could combat that with the pool parameters. If anything, right now dSATA is already able to be 'manipulated' by whales as there are so few holders. Perhaps this pool will encourage others to get on board and the token's distribution will improve?

I voice a similar concern regarding low participation leading to large accumulation. The current block reward of 3.8954 dSATA will give approximately 25,000 per day to be split by participants. I'm not totally against the pool, but it might need some adjustments to block reward or total allocation.

As much as I support this proposal, I believe it neglects SATA LP providers. If there is a way to include their wallet addresses into this pool, I would back it 100%

What are the suggestions then so that we can go ahead and vote on this?
We need to get this moving.

As much as I support this proposal, I believe it neglects SATA LP providers. If there is a way to include their wallet addresses into this pool, I would back it 100%

That's what the other open proposal is for, for SATA LP providers. The pool can't be a combination of the two as the base staked tokens are entirely different with different price mechanisms.
But a 2nd dSATA yielding pool could be created for SATA LP providers? If you're wanting something like that a proposal can be opened for that too.

I voice a similar concern regarding low participation leading to large accumulation. The current block reward of 3.8954 dSATA will give approximately 25,000 per day to be split by participants. I'm not totally against the pool, but it might need some adjustments to block reward or total allocation.

There's 2 ways to change the distribution. Either extend the pool to a longer timespan, or reduce the pool reward supply.
Would you all prefer a 1 year pool with the same amount? Or the 5,000,000 dSATA reduced to something like 3,000,000? Up to you guys

In favour of changing the parameters to 1 year

In favor of extending to 1 year while keeping the reward at 5,000,000.

I also am in favour. Who's gonna get this proposal on Tally?

1 year it is. I'll open the proposal now

Proposal opened:
https://www.tally.xyz/governance/eip155:1:0x3D3255D21654B9a8325DfE6353ac6B37352Eb80B/proposal/112193124163354052763328533223595436589147810764624453813670041301179215386123

Proposal #2 has been executed. As per community vote, staking to receive governance tokens is now active on OKLG
https://app.oklg.io/#/faas
https://etherscan.io/tx/0xc5c9e5a910a1862a6a73e1a400b9ab630d6c87146d76d374d8273e096510e857


missing import pdfplumber

Hi,
I did not find where to report a missing import: pdfplumber seems to be missing.
Thank you
Regards

I believe this is a error related to your local code base or setup.
If you have the required library installed and have selected the correct python interpreter "Python: Select Interpreter", and still see an issue. please add the output window logs from "Python Language Server".  https://github.com/microsoft/pylance-release/blob/main/TROUBLESHOOTING.md#filing-an-issue


Revert "Fix/smaller improvements"

This PR is purely due to formatting issue due to previous conflict resolution.

@noahonyejese I don't understand why you want to revert the changes in main? It looks like un-doing the PR you did that is already merged 🤔

@noahonyejese I don't understand why you want to revert the changes in main? It looks like un-doing the PR you did that is already merged 🤔

My bad I accidentally clicked this revert button and then I couldn't close it for some reason, however I'll close it now the button has appeared maybe it was loading or something


Add support for Tube Archivist (integration)

Description
As the tiltle says, it would be awesome if could be possible to add integration support for Tube Archivist into Homarr!
Tube Archivist (website)
Tube Archivist (GitHub)
Priority
Low (Nice-to-have)

Hi, thanks for the request.
Can you document, what exact data you want to have displayed?
This will help us figure out how to implement this.
Thank you.

No, you're not mistaken.
We just need some information to know what must be implemented.
Thanks for explaining it.


fix InfiniteLine mode

Need to get my numbers right but the implementation is doing at least something again.
I'm a bit unsure where I'm going wrong with the offset min + max, I understand it's a sliding window but for whatever reason I'm struggling to line it up properly.
Testing with sprite_and_ui_clickable example.
Fixes #109

Okay got it working on CosmicMode::Left fine, but I think in the case of centered text I'm fighting with the padding overrides when moving the cursor left of the offset.
I changed the offset window to have a position and width, helped me conceptualise what's going on with it and simplified the math a little.
Not sure what to do about the centered text, maybe a check for when the line is full to turn centering off? I'll have a play with it

Negative padding was the issue, added a minimum of 5, not sure if that should be user editable or not, as anything lower looks pretty awful. But that's subjective I guess.

nice!


Create 0008-backstage.md (#189)

Create 0008-backstage.md

Added Backstage doc assessment.

Tested documentation build procedure. Updated assessment with findings.

Update Backstage assessment website info

Added information about site mapping based on Docusaurus plugin documentation.

updated the website section with appropriate info

Update accessibility section

Completed website assessment and recommendations.

Updates and edits to complete the website assessment per @thisisobate. Other minor edits.

Responses to Backstage doc assessment comments

Responses to initial review comments on the Backstage documentation assesment (0008-backstage.md).

Create user-roles.md

Add a short document to define user roles (personas) for the purpose of organizing task-based documentation.

Move 0008-backstage.md to assessments/0008-backstage

Move to project-specific subdirectory.

Add survey of existing doc pages

Add CSV file: survey of existing Backstage doc web pages.

Add backstage insights summary doc

Add Backstage Insights summary document describing findings from Spotify's survey about Backstage adoption.

In progress: User roles, recommendations.

In progress - writing implementation suggestions.

In progress. Writing implementation recs.

In progress. Writing Implementation section.

In progress - fixed external references

Update website action items

Update website recommendation breakdown.

Final changes before merging PR.

Separate analysis and implementation.
Clean up references.
Revise intro material.

Changes prior to PR merge

Separate analysis and implementation
Fix references
revise intro

Changes prior to PR merge

Separate analysis and implementation
Fix references
revise intro

adding README to backstage assessment

Pulling back Nate's changes to the merged Backstage PR.


next_release nagging on release day

There's a false positive from the next_release nag:
Subject: [autonag] Next release date is not up-to-date

Hi there,

The next release date (2023-04-11) is not up-to-date:
https://wiki.mozilla.org/Template:NextReleaseDate
and it should be 2023-03-14 (see [release calendar](https://wiki.mozilla.org/Release_Management/Calendar)).

The next release date (2023-04-11) is not up-to-date :
https://wiki.mozilla.org/Release_Management/Release_owners and it should be 2023-03-14 (see [release calendar](https://wiki.mozilla.org/Release_Management/Calendar)).

It looks like utils.get_next_release_date returns today instead of April 11.

https://whattrainisitnow.com/api/release/schedule/?version=beta:
{
  "version": "111.0",
  "nightly_start": "2023-01-16 00:00:00+00:00",
  "soft_code_freeze": "2023-02-09 08:00:00+00:00",
  "string_freeze": "2023-02-10 00:00:00+00:00",
  "merge_day": "2023-02-13 00:00:00+00:00",
  "beta_1": "2023-02-14 00:00:00+00:00",
  "beta_2": "2023-02-16 21:00:00+00:00",
  "sumo_1": "2023-02-17 21:00:00+00:00",
  "beta_3": "2023-02-19 21:00:00+00:00",
  "beta_4": "2023-02-21 21:00:00+00:00",
  "beta_5": "2023-02-23 21:00:00+00:00",
  "beta_6": "2023-02-26 21:00:00+00:00",
  "sumo_2": "2023-02-27 21:00:00+00:00",
  "beta_7": "2023-02-28 21:00:00+00:00",
  "beta_8": "2023-03-02 21:00:00+00:00",
  "rc_gtb": "2023-03-07 21:00:00+00:00",
  "rc": "2023-03-08 00:00:00+00:00",
  "release": "2023-03-14 14:00:00+00:00",
  "planned_dot_release": "2023-03-28 00:00:00+00:00"
}

https://whattrainisitnow.com/api/release/schedule/?version=nightly:
{
  "version": "112.0",
  "nightly_start": "2023-02-13 00:00:00+00:00",
  "soft_code_freeze": "2023-03-09 08:00:00+00:00",
  "string_freeze": "2023-03-10 00:00:00+00:00",
  "merge_day": "2023-03-13 00:00:00+00:00",
  "beta_1": "2023-03-13 00:00:00+00:00",
  "beta_2": "2023-03-14 21:00:00+00:00",
  "beta_3": "2023-03-16 21:00:00+00:00",
  "sumo_1": "2023-03-17 21:00:00+00:00",
  "beta_4": "2023-03-19 21:00:00+00:00",
  "beta_5": "2023-03-21 21:00:00+00:00",
  "beta_6": "2023-03-23 21:00:00+00:00",
  "beta_7": "2023-03-26 21:00:00+00:00",
  "sumo_2": "2023-03-27 21:00:00+00:00",
  "beta_8": "2023-03-28 21:00:00+00:00",
  "beta_9": "2023-03-30 21:00:00+00:00",
  "rc_gtb": "2023-04-03 21:00:00+00:00",
  "rc": "2023-04-04 00:00:00+00:00",
  "release": "2023-04-11 14:00:00+00:00",
  "planned_dot_release": "2023-04-25 00:00:00+00:00"
}


Video Preview Rendering

Filenames with umlauts have problems to render previews on UBUNTU.
e.g.: filename with "füllung" is shortened to "fllung".

Sounds like a encoding issue on the server to me. Also found this comment in the php manual: http://php.net/manual/de/function.escapeshellarg.php#99213

Umlauts will be escaped in the filename now.


regenerate code with latest swaggers

Regenerated code with latest swaggers
Split the swagger file for each of them and updated the command
Updated the versions of API generator and package versions

Resolves #15981


fix(n-split): modified default-size panel not updated issue

close https://github.com/tusen-ai/naive-ui/issues/5526

This part of the API may have to be re-implemented, I will re-open a PR


Draft: Long version & nix flakes

This contains some of my ideas on how to work around the Nix flakes not having a .git directory: using an environment variable which can be automatically set for CI releases.
Note: Users need not set the variable specifically, they can just use the defaults, it will just mean the reported version will be different.

Of course this whole thing is just a suggestion, of how I had it in my mind, I don't feel strongly about it. My main reason is so that if you do a tag/release in github, it should presumably build a proper tagged version for you, hence passing in the git describe in the github workflow.

Thank you for your suggestion. I wanted to push a commit on your branch before merging but I  was not able to, so I merged then applied my commit https://github.com/pimalaya/himalaya/commit/5c4b03474e7bbcf71f4739f11d56c0cbb8c06890. I basically changed few details here and there, and added cargo features to the long help.

Ah interesting, that wasn't intentional, I thought I had clicked "allow edit by maintainers", my bad


Altered handleFileEvent to be able to accept extensions other than .ts and .html

Added support for .jsx, .tsx, and .js file extensions in the handleFileEvent function.
Tests remained the same after changes in addition to not introducing any breaking changes.
This PR fixes issue #363.

It appears that the transform tests were failing before my changes and that is why the Travis CI build failed.

Thanks for submitting.  I'll take a look soon.

Thank you very much!

This is released in grunt-ts v6.0.0-beta.16 on npm.  Thank you!


:lady_beetle: Get "Admission Webhook Warning" message - 'unknown field'

Ref: https://issues.redhat.com/browse/MTV-1233
while creating a migration plan or changing the host 'network for data transfer' field (provider), getting a warning message

addressed by #1255


Automatically switch to ZWLR region on supporting controllers

e.g. there's usually no good reason to use the US region over the USLR region.
We should automatically use the *LR regions instead when possible. Also add a driver option to opt out.

Duplicate of #6619


Rewrite SQL system and add metrics along with general improvements and fixes.

PR to include fixes to backend and add metrics. Will include fixes targeting authorization parts of code.

 This PR will be closed and development will eventually continue, the current state is likely broken but that can be fixed later on.
This PR includes a lot of stuff.

metrics with prometheus / grafana
fixed database pooling
soon to be scope based authentication
fixed auth system partially
rewrote database system away from SQLAlchemy

PR also includes likely broken code and more!


Adding OSX target

That is the PR adding the OSX target to Nocilla, before we find a way to get rid of the whole thing.

Looks like Nocilla may be abandoned and this PR is never going to be merged upstream, but Siesta depends on this fork, so just merging OS X support in here.


[Oxide][TheForest] : After 2.0.3222 TheForest source files build Oxide 2.0.0

Step 3: Describe the problem
Steps to reproduce:

Got v2.0.322 for Oxide

Download : https://github.com/OxideMod/Oxide/releases/download/2.0.3222/Oxide-TheForest.zip
Copy bundles to server
Start server

Got v2.0.0 for Oxide

Download : https://github.com/OxideMod/Oxide/archive/2.0.3222.zip
Generate build with visual studio 2015
Copy bundles/TheForest to server
Start server

Observed results:

Got unexpected version on TheForest server when Build solution on visual studio

Expected results:

Same result with just Bundles and compiled bundles

Step 4: Additional information
Other references:
#1080 #1079

The build number is attached by our build server. Compiling your own build locally is an indication that you do not have or are not actually using an official build.

@lukespragg ... can't help like this then... im compiling YOUR version... im not touching code... just download and build... and DON't works.. but if i download just theforest bundles compiled by you, then works...
How i can test my code on real server if i can't compile successfully... ? :S

The build number has nothing to do with it working or not. The files you need would all be under the Bundles version if you are compiling and testing locally.


Chart package missing config configuration item

Chart package downloaded through helm pull, nebula cluster.yaml template is missing config configuration item

@kinghu88  can you commit a pr to fix it?

I've checked nebula-cluster charts, config filelds exists,  if you have any questions about helm deployment,  please reopen the issue.


Push Mode Squeezes Content

The push mode squeezes all the content. It should shift it without squeezing it therefore distorting it.
Here is an example of how i think it should work: http://codepen.io/brettsmason/pen/GNwpPY

You can use [mode]="'slide'" for that.

I must have missed that. Works great. Thanks

I actually forgot to add it to the README, although it was in the demo. I've added it to the README on GitHub for now. 👍