Interrupt current thread when InterruptException occur

What is the purpose of the change
Interrupt current thread when InterruptException occur
org.apache.dubbo.rpc.protocol.AsyncToSyncInvoker.java
    @Override
    public Result invoke(Invocation invocation) throws RpcException {
        Result asyncResult = invoker.invoke(invocation);
        try {
            if (InvokeMode.SYNC == ((RpcInvocation) invocation).getInvokeMode()) {
                asyncResult.get(Integer.MAX_VALUE, TimeUnit.MILLISECONDS);
            }
        } catch (InterruptedException e) {
            // interrupt thread
            Thread.currentThread().interrupt();
            throw new RpcException("Interrupted unexpectedly while waiting for remote result to return!  method: " +
                    invocation.getMethodName() + ", provider: " + getUrl() + ", cause: " + e.getMessage(), e);
        }
        return asyncResult;
    }

Brief changelog
Interrupt current thread when InterruptException occur
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #10164 (8d6a8c1) into master (9efe21a) will increase coverage by 0.32%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #10164      +/-   ##
============================================
+ Coverage     60.52%   60.84%   +0.32%
- Complexity      412      447      +35
============================================
  Files          1100     1100
  Lines         44569    44524      -45
  Branches       6492     6461      -31
============================================
+ Hits          26976    27092     +116
+ Misses        14624    14466     -158
+ Partials       2969     2966       -3

Impacted Files
Coverage Δ

...bo/rpc/cluster/support/FailoverClusterInvoker.java
85.18% <0.00%> (-3.28%)
:arrow_down:

.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java
62.06% <0.00%> (-10.35%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

...moting/transport/netty4/NettyEventLoopFactory.java
30.00% <0.00%> (-6.37%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
87.85% <0.00%> (-5.85%)
:arrow_down:

.../threadpool/support/limited/LimitedThreadPool.java
83.33% <0.00%> (-5.56%)
:arrow_down:

...on/threadpool/support/cached/CachedThreadPool.java
85.71% <0.00%> (-4.29%)
:arrow_down:

.../org/apache/dubbo/qos/legacy/LogTelnetHandler.java
30.30% <0.00%> (-3.04%)
:arrow_down:

...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
86.66% <0.00%> (-1.91%)
:arrow_down:

...va/org/apache/dubbo/remoting/exchange/Request.java
75.43% <0.00%> (-1.76%)
:arrow_down:

... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efe21a...8d6a8c1. Read the comment docs.

would you please add some test cases to verify this

would you please add some test cases to verify this

it is a bit difficult for me to setup the ut environment with mockito, i can only provide basic code
consumer:
ThreadPoolExecutor threadPoolExecutor = new ThreadPoolExecutor(1, 1, 0, TimeUnit.SECONDS, new LinkedBlockingQueue<>());
String name = "world" + System.currentTimeMillis();
int initialFlag = 0, runningFlag = 1, normalReturn = 2, interruptReturn = 3;
AtomicInteger flag = new AtomicInteger(initialFlag);
Future<?> future = threadPoolExecutor.submit(() -> {
    try {
        flag.set(runningFlag);
        service.sayHello(name);
        flag.set(normalReturn);
    } catch (Exception e) {
        flag.set(interruptReturn);
    }
});
Thread.sleep(100);
future.cancel(true);
while (flag.get() == initialFlag || flag.get() == runningFlag) {
    Thread.yield();
}
Assertions.assertEquals(flag.get(), interruptReturn);

provider：
String lastName = "";

@Override
public String sayHello(String name) {
    if (!lastName.equals(name)) {
        lastName = name;
        try {
            //will be interrupted at first time
            Thread.sleep(200);
        } catch (InterruptedException ignore) {

        }
    }
    return "Hello " + name + ", response from provider: " + RpcContext.getContext().getLocalAddress();
}

important parameter:
retries=3&cluster=failover

flag will return normalReturn if we dont add Thread.currentThread().interrupt()`

@happytimor Please apply this pr to 3.0 branch.

https://github.com/apache/dubbo/pull/10299  @AlbumenJ


Duplicate notices not being tracked

Some of the notices are not being tracked for the fast_htmlcs runner.
The notice
'If this image cannot be fully described in a short text alternative, ensure a long text alternative is also available, such as in the body text or through a link.'

no longer an issue


release: 3.4.12

This upgrade Redmine to 3.4.12
Redmine Changelogs : https://www.redmine.org/projects/redmine/wiki/Changelog_3_4#3412-2019-10-19
Signed-off-by: Pierre Belloy<EMAIL_ADDRESS>

Looks good


Usage with scale other than modular-scale

Hi, I would like to combine vertical-rhythmic with some other modular-scale than the one provided in your docs.
The one I am looking at is https://github.com/nickpfisterer/harmon  Basically it is very similar to the one by Team-Sass, just a little more stripped down and easier to use.
Since I am newbie to Sass, is there a way to use it with vertical-rhythmic, like you did with modular-scale ?

In fact, I think I should update the docs since vertical-rhythmic and modular-scale fulfill the "same" behavior. You should use one or the other but the both together seems useless and especially not really flexible. But you can use vertical-rhythmic on one side, and modular-scale on the other side.
I explain. Vertical-rhythmic is designed to keep a scale across the typography. Modular-scale keeps a scale based on a natural known ratio. So you can use vertical-rhythmic for the fonts, and modular-scale for your blocks.
Anyway! Harmon is the same library as vertical-rhythmic. Pick the one you love ;)

One last note : you can use vertical-rhythmic for typography or blocks, like modular-scale and harmon too. So it's really a matter of taste.

The difference is in the baseline creation. Harmon only set the font-size for the baseline, apparently. Vertical-rhythmic sets the font-size, the line-height, and computes a ratio to apply when vr() is called. It seems more accurate to me. But you don't have a golden ratio or whatsoever.

@pyrsmk Thanks for the explanation!
Although, I musr admit, you got me a bit confused now. You say that Harmon and your library are the same thing, I am no expert, but modular scale and vertical rhythm are two completely different things.
Harmon only helps with choosing different font-sizes from pre-defined values + applying line heights.
I was thinking of using your library for consistent vertical rhythm and Harmon for choosing font sizes from various scales.

They are different but we can use all of them to accomplish the same thing, as far as I can see. Vertical-rhythmic applies values for font-size and line-height, Harmon too, and modular-scale can be used that way to.
But you're right, with vertical-rhythmic it's more consistent because of its baseline and the ratio he's computing from it.
I just encourage you to choose only one library if possible, because it's becoming too complex to me, otherwise.


iOS 13 get networkState error --reachableViaWiFi

[AFNetworkReachabilityManager sharedManager].reachableViaWiFi，this func in iOS 12 is correct，but in iOS 13 is error，but setReachabilityStatusChangeBlock get the result is correct

can you put a picture ?

@sanlunaifen

I have the same problem.

Is there any solution?

Is this problem solved?

I have the same problem.

It is recommended to adapt to iOS13 as soon as possible, and developers should not develop with xcode13 until it is ready

uicollectionview with SdWEbimage，reloadData，twice or more。 App Crash

UICollectionViewCell contains a UIImageView, use SDWebImage set image ,reloadData repeatly without interval .App will crash in bad net condition.----- ios13,xcode11,

If I /***/ the setImageWithURL ，crash won't happen

I get this from SDWebImage Developer
https://github.com/SDWebImage/SDWebImage/issues/2868


Missing Function.JSON File?

Hi,
There doesn't seem to be a function.json file such that the solution can be deployed with vs code. Is that expected?

Not sure, did you successfully make this function work in your environment?

No, not specifically this project. I did find another one that met my needs and was able to get it deployed and working.

I just figured out how to make the API work, you don't need a function.json, and you can put the environmental variables in the  local.settings.json file to make it work. I am working on a blazor webassembly project tonight to make the project fully functional.

Can you share the working repo with me just for reference?

This is what I got going: https://github.com/mikepfeiffer/azure-serverless-contact

Thank you.

My version of the github repo is working properly and here it is for your reference:
https://github.com/Robertblazor/Contact-us-exp
Hope it can help you in the future.


cannot import name '_request_ctx_stack' from 'flask'

I am trying to run my webserver with Flask and Flask-Socket.io I have set up socket.io and flask right but for some reason when running it with Docker. I get the error: cannot import name '_request_ctx_stack' from 'flask'.  Am using Flask version 2.3.3 and the latest Flask-Socket.io
Install both Flask and Flask-Socket.io create a Dockerfile to build the app and add docker-compose to handle the build using docker-compose up.
Here's the code you can use:
from flask import Flask

from flask_socketio import SocketIO
from src.db.init import DbInit
from src.manager.sockets import SocketManager
from src.routes import heath_route as hr
from src.routes import docs_routes as dr
from src.routes import query_route as qr
from decouple import config

app = Flask(__name__)

# Register the blueprints
app.register_blueprint(hr.health_bp, url_prefix='/api')
app.register_blueprint(dr.files_bp, url_prefix='/api')
app.register_blueprint(qr.query_bp, url_prefix='/api')

# SocketIO.app(socketio, app=app, path="/io", cors_allowed_origins="*")
socketio = SocketIO(app, cors_allowed_origins="*")
db = DbInit.get_instance()
manager = SocketManager(socketio, db)

def start_app():
    """Start the application"""
    port = config("PORT", 5050)
    host = config("HOST", "<IP_ADDRESS>")
    env = config("ENVIRONMENT", "development")
    if env == "development":
        socketio.run(host=host, app=app, port=port, debug=True, use_reloader=True)
    else:
        socketio.run(host=host, app=app, port=port, debug=False, use_reloader=False)

Here is the traceback
backend  | Traceback (most recent call last):
backend  |   File "/app/main.py", line 1, in <module>
backend  |     from app import start_app
backend  |   File "/app/app.py", line 6, in <module>
backend  |     from flask_socketio import SocketIO
backend  |   File "/usr/local/lib/python3.10/site-packages/flask_socketio/__init__.py", line 19, in <module>
backend  |     from flask import _request_ctx_stack, has_request_context, json as flask_json
backend  | ImportError: cannot import name '_request_ctx_stack' from 'flask' (/usr/local/lib/python3.10/site-packages/flask/__init__.py)

I would like the app to run on the port 5050 and be able to allow POST, handle file uploads.
Environment:

Python version: 3.10.13
Flask version: 2.3.3

You are not using the latest Flask-SocketIO. The version that you are using is only compatible with older versions of Flask. At some point around Flask 2.2 they have changed some implementation details regarding user sessions in a backwards incompatible way.
Flask-SocketIO 5.3.0 and up have adapted to their new way, so switch to that and hopefully you should be fine.

Thanks @miguelgrinberg let me try that out

Will give feedback here instead of opening a new issue incase something occurs, I had tried adding the allow_wezbierg flag to true and it worked fine but I could not upload files for some reason

I've been in this loop for almost three days now, not sure whether its a combination of the package versions that's wrong or what it is really.

I suggest that you start by closing this issue, since you do not seem to experience the original issue anymore.
The whole point of having the allow_unsafe_werkzeug flag is to prevent you from doing something that is almost always a bad idea. I would consider switching to a production server instead of continuing using Werkzeug. Try Gunicorn, for example.
Finally you seem to have a problem uploading files, which is completely unrelated to the allow_unsafe_werkzeug flag. You suggest that uploads work without this flag set, but that cannot be, since without the flag the web server wouldn't start at all. Once you collect enough information about your file upload issue, you may consider writing a discussions post on the Flask repo of Flask-SocketIO, whichever is the project you need help with.


Tabbing in dialog doesn't wrap properly

If you tab all the way through the settings menu so that it wraps, it goes from 'Categories' "Speech" to "Speech for chemical formulas".
The first time through, it properly goes to "Generate speech for..."

I can replicate this. Ugh. I will need to write event handlers to fix this, shame it doesn't manage this out of the box.


Some outbound calls do not have ring groups

Some outbound calls do not have ring groups, need to check to ensure I'm grabbing the right ajax request.

Tests seems to always work to show outbound call ring groups. Will need to test during peak time rather than by myself at off hours.


"back to results" behavior should be changed

Currently, the intake form has two buttons, which are always active: "back to results" (which returns the user to the search results page that brought them to the intake form) and "save changes" (which saves any changes to the old or new client being worked on).
If the user enters changes into the intake form and then clicks "back to results", the changes might be lost. I don't think "back to results" should even be an option if any unsaved changes to the client's data have been made. Here is my proposal:

When editing an already existing client, the "back to results" button should only exist before the user has typed any changes into the form. Once s/he has entered any changes, "back to results" should be replaced by "revert changes". Now the user must either save their changes or revert back to the original data before they can leave the page (once they revert "back to results" can appear again).

When entering information on a brand-new client, "back to results" should never appear; neither should "revert changes" (because for a new client there is nothing to revert to). In place of these should be "cancel new client", which will drop any changes entered by the user and return them to the search page (maybe with a warning first).

The "save changes" button should always exist regardless of whether the form pertains to a new client or an old one, but it should only be active after the user has made some change to the form. When the user first arrives, or if the user enters self-canceling changes, "save changes" should be deactivated.

@nttaylor made this fix in e944bb0.


Use semver.coerce() to get valid kubernetes version

Summary
Fixes #12525

Occurred changes and/or fixed issues

This uses semver.coerce() to get a valid semantic version for the original Kubernetes version in CruAks.vue. The form could fail to render if the Kubernetes version is not a valid semver and semver.coerce() will correctly evaluate to a semantic version.
Technical notes summary

In the production example, 1.29 is used for the Kubernetes version:
az aks create --resource-group th-rg --no-ssh-key --kubernetes-version 1.29 --name th-az-imported-293 --node-count 1 --location eastus

1.29 is a valid Kubernetes version and will default to the latest release^1 (1.29.10 at the time of writing).
1.29 is stored in aksConfig.kubernetesVersion; this is not a valid semver, so an unhandled exception is thrown and the page fails to render correctly.
It's entirely possible that current-cluster-controllers-version is the incorrect value to use for this case, but it was the only one that I found that evaluates to a valid semver with the expected kubernetes version of 1.29.10.
Areas or cases that should be tested

See reproduction steps in issue

Areas which could experience regressions

We are changing the Kubernetes version used for the AKS form. If this annotation doesn't exist for any reason, we will experience the same behavior that's described in the issue. We can consider adding some sort of failure mode if the original Kubernetes isn't present or a valid semver. We can also consider adding some sort of fallback value in the event that it fails.
Checklist

[x] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[x] The PR has a Milestone
[x] The PR template has been filled out
[x] The PR has been self reviewed
[x] The PR has a reviewer assigned
[x] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[x] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

/backport v2.10.0 release-2.10

/backport v2.9.4 release-2.9


Add a "within" option to "on sprite overlaps tile" block

The semantics of "within" are:
True if and only if all the sprite's pixels are contained within the target tile (or a contiguous set of the target tiles, e.g. halfway between two of the same).
Here are three times when this would have been useful during the Arcade Advanced live stream:

On our latest stream, we wanted to change the player direction once they are standing on an arrow drawn on the floor. See the stream for how hard this was to work around. It took like 20 minutes with lots of confusion (at least on my part).
On the underwater shopping game, overlapping the end checker floor was weird since the game ended as soon as you touched the tile and ideally it should end once you're a ways over the tile
On the frogger game, you died as soon as your character touched water even though visually it looked like you were still on land..

Here are four conditions that would be very easy to express with this block change but are difficult to express right now:
"player is on the pressure plate"
"player is in the end zone"
"player has crossed the finish line"
"player is over the water"
To make this change, we'd likely need to introduce a new block, remove the old one, and run an upgrade rule to move all blocks to the new one. This shouldn't be backwards breaking from a user perspective (minus screenshots).

few things that come to mind for me real quick - I do like the idea, just rough thoughts / possible issues:

I'm not sure I'd get the wording, within and overlaps feel very similar to me / I think I would describe an overlap as 'when your sprite is within a tile' already (if explaining to someone younger, etc)
for lots of sprites within would probably 'feel' wrong; e.g. any time you have a sprite that is close to tile size it would rarely trigger a lot of the time, and I think you would get the opposite of the current problem ("it's all in, why isn't this working" when there's a single pixel off screen) -- maybe 'mostly' in tile too? bit of a slippery slope I guess.
I think it's worth definitely worth considering wall-like 'regions' here as well -- if you have a complicated game, you might want two types of grass to spruce things up, and making this trigger off being in a single tile (or type of tile) would interact poorly with that
as a note, applying the upgrade to ts is probably the harder part; currently those upgrades are mainly just regex based. blocks upgrade is generally easy enough though.

maybe worth noting there were workarounds we just didn't get to for a lot of these; underwater shopping could have just been a wall collision with the wall past the ending tile (then you get to finish your 'victory walk'), frogger probably a lifespan, todays was probably the hardest but we were also trying to make it pretty (just placing on top would have worked fine, but been a bit ugly) - definitely still nice to have something though

Thinking about wording: perhaps there could be three drop down options: “touching” (existing), “on” (x/y center), “enclosed by”.

No plans to address this in the near future


Allow Dashboard to be used standalone

The Dashboard is great, and something that is much needed for local development, that's beyond the Cloud Native part.
I think it would be great if the Dashboard were to be available as a docker image that people could spin up and use. A few things that would make that more useful.

Make TelemetryRepository an interface
Add Http Ingest
Allow removing of dashboard items that aren't configured (like tailed logs etc.)

Making the TelemetryRepository an interface would allow for the container to have something like a sqlite db under the hood so it can live beyond restarts, but obviously wouldn't be great performance wise, so it could be used in production.
If it's something that's of interest, I could definitely PR some of it in.

Duplicate of #846

I don't think this is duplicate of that one.
Adding Aspire to an existing project (as in no extra workload process) is different that running Aspire as a standalone project.
From what I can gather, there is more appetite inside Microsoft to do a standalone instance than make it work as an add on to an existing app.

Agreed @martinjt, re-opening this to track the standalone scenario, e.g. as  dotnet tool.

We have no plans to do this to the existing dashboard. I think if someone is interested, they can come up with a proposal based on the existing work we're doing.

I'm closing this in favor of https://github.com/dotnet/aspire/issues/1003


Scale transform and dragging issue

I am running into an issue where the parent div has a css transform (scale) which is causing the drag functionality to behave strangely. Is there a possible workaround to this issue?
Here is an example of what I am talking about https://codesandbox.io/s/draggable-tabs-antd-5-8-5-forked-nxl43c?file=/demo.tsx

I met the same issue. It seems that dnd-kit cached the origin bounding client size.

I met the same issue as well. And found that efossvold's idea helps a lot: https://github.com/clauderic/dnd-kit/issues/638#issuecomment-1096672529
    const style: React.CSSProperties = {
        transform: `translate3d(${transform.x / scale}px, ${transform.y / scale}px, 0)`,
        // Rest of your styles ...
    };

Apply it on to your dragging elements so it will compensate the scale drifting.

thanks, @k-jiang for the updates! it has saved a lot of time for others!

I am also having this issue and have found partial success with using a scale parameter to fix the dragging position, however it seems dndkit is internally using the original transform to determine the isOver value.

Possibly this could be solved with custom collision detection? Though I haven't looked into it yet, otherwise I would think dndkit needs to be able to take in some prop indicating the zoom/scale so it can compensate to return the right transform & isOver values automatically.


Bump oauth version

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/1307720229

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/1307720229
Status: success


machinst x64: use assert_eq! when possible

This change is a pure refactoring--no change to functionality. It replaces various forms of assertions (e.g. ==, !=) with their macro form (e.g. assert_eq, assert_ne). I don't truly have a preference either way but it makes the IDE I use stop telling me that there is a "possible code improvement."

I think the CI failure is the intermittent issue that @bnjbvr mentioned at the end of last week; let's try kicking the tests to rerun first, but we can temporarily disable it if it becomes much more of an issue.


Add position control (with interpolation) to control board plugin

We want to add a position control mode to the control board plugin, corresponding to the same control mode present in gazebo-yarp-plugins.

CC @traversaro

Looking at the code implementing IPositionControl the main task are carried out by the trajectory generators (TVP, MJT, constant speed, ...), implemented in https://github.com/robotology/gazebo-yarp-plugins/blob/master/plugins/controlboard/src/ControlBoardDriverTrajectory.cpp .
@traversaro do you suggest to port this class as-is (updating only the calls to gazebo APIs) or there is some modification you have in mind?

@traversaro do you suggest to port this class as-is (updating only the calls to gazebo APIs) or there is some modification you have in mind?

Yes, I think we can copy directly the class, we can leave future evolutions in the future.

Note: the default trajectory generation type is minimum jerk. https://github.com/robotology/gazebo-yarp-plugins/blob/cb3521f7543a5a07e2a65a82dedd2eb2ec2cea12/plugins/controlboard/src/ControlBoardDriver.cpp#L131-L155

Note: a single generation type can be specified for all joints: https://github.com/robotology/gazebo-yarp-plugins/blob/cb3521f7543a5a07e2a65a82dedd2eb2ec2cea12/plugins/controlboard/src/ControlBoardDriver.cpp#L136-L144

I needed to modify the initTrajectory() method of the classes implementing TrajectoryGenerator since the way in which the update period of the simulation can be obtained changed in the new version of Gazebo.
Here is an example for the minimum jerk generator: https://github.com/robotology/gazebo-yarp-plugins/blob/cb3521f7543a5a07e2a65a82dedd2eb2ec2cea12/plugins/controlboard/src/ControlBoardDriverTrajectory.cpp#L207-L208
Now the data about simulation time is passed to the system plugin interfaces like the PreUpdate, Update, PostUpdate methods.
I'm thinking about how to arrange the flow of the simulation period to trajectory generators. @traversaro the simulation period in Gazebo can change at each iteration? i.e. there is the possibility to use variable step solvers?

I'm thinking about how to arrange the flow of the simulation period to trajectory generators. @traversaro the simulation period in Gazebo can change at each iteration? i.e. there is the possibility to use variable step solvers?

In theory yes, in practice I guess we can stick to the simple case for now of assuming that the update period is constant. In any case it probably make sense to decouple the trajectory sampling time (that should be coupled to the control period) from the simulation step time. The control period should be fixed and should not depend on from the simulation step time.

The control period should be fixed and should not depend on from the simulation step time.

In particular, I am not sure how I missed this, but what I mean is that the PID should not run at every simulation step (as done in https://github.com/robotology/gz-sim-yarp-plugins/blob/main/plugins/controlboard/src/ControlBoard.cpp#L359), but instead we should have an independent sampling, and check if it needs to run again given the simulation time. Something like:
void ControlBoard::PreUpdate(const UpdateInfo& _info, EntityComponentManager& _ecm)
{

    // The class should have a m_controlUpdatePeriod attribute, parsed from config files
    // and with a reasonable default (like 1ms)
    // There should also be an attribute called m_lastControlUpdateInstant to capture the
    // last time the update have been run (and should be reset)
    if (_info.simTime-m_lastControlUpdateInstant > m_controlUpdatePeriod)
    {
        auto dt = _info.simTime-m_lastControlUpdateInstant;
        if (!updateReferences(_info, _ecm, dt))
        {
            yError() << "Error while updating control references";
        }
        m_lastControlUpdateInstant = _info.simTime;
    }
}

See also https://github.com/robotology/gazebo-yarp-plugins/issues/69 for the related bug on gazebo-yarp-plugins side.

See also robotology/gazebo-yarp-plugins#69 for the related bug on gazebo-yarp-plugins side.

Interestingly, probably it could also make sense to only sample sensors measurements when the control loop is running, effectively subsampling the output of the simulator. By the way, this is similar to what we discussed yesterday with @DavideBarbone and @Gio-DS .

Thank you @traversaro, now it's clear! while porting huge code portions and refactoring them is difficult to which are the specifications that the new plugin should maintain.
I will try to be more verbose when reviewing the gazebo-yarp-plugins to try not to skip this kind of requirements.

I opened:

https://github.com/robotology/gz-sim-yarp-plugins/issues/100 to track the decoupling of control period from simulation one;
https://github.com/robotology/gz-sim-yarp-plugins/issues/101 to track the decoupling of sensor frequency from simulation one.

While porting the `` method I've not understood the role of this line:
https://github.com/robotology/gazebo-yarp-plugins/blob/cb3521f7543a5a07e2a65a82dedd2eb2ec2cea12/plugins/controlboard/src/ControlBoardDriver.cpp#L561-L563
I did not find any reference to the m_oldReferencePositions vector in the code, so I'm assuming it's a legacy variable not used anymore.

Also I've noted that some variables are rest only in the if branch in which the initial configuration is found, but they are not reset when using the actual positions. Is this wanted? It is not done since it is assumed that the trajectory generator reference positions are already equal to the actual joint position?
https://github.com/robotology/gazebo-yarp-plugins/blob/cb3521f7543a5a07e2a65a82dedd2eb2ec2cea12/plugins/controlboard/src/ControlBoardDriver.cpp#L484-L488

Also I've noted that some variables are rest only in the if branch in which the initial configuration is found, but they are not reset when using the actual positions. Is this wanted? It is not done since it is assumed that the trajectory generator reference positions are already equal to the actual joint position?
https://github.com/robotology/gazebo-yarp-plugins/blob/cb3521f7543a5a07e2a65a82dedd2eb2ec2cea12/plugins/controlboard/src/ControlBoardDriver.cpp#L484-L488

I guess this worked just as the initial position of both without configuration file is 0. However, better to explicitly reset them, as this could one of the source of problems that people have in resets, fyi @rob-mau @S-Dafarra .

Udpate: I should have ported the needed functionality to make the position control work with the single pendulum.
Now I'm facing an issue when trying to control the single pendulum model with the yarpmotorgui, since when I launch it and try to change the reference position the yarpmotorgui and gazebo freeze and I have to kill them, most probably a deadlock condition.

Now I'm facing an issue when trying to control the single pendulum model with the yarpmotorgui, since when I launch it and try to change the reference position the yarpmotorgui and gazebo freeze and I have to kill them, most probably a deadlock condition.

Fixed in https://github.com/robotology/gz-sim-yarp-plugins/pull/98/commits/ca3778f96b3f2f47eb4afc75cc80e14880d3314f

This is one of the first working demos:
https://github.com/robotology/gz-sim-yarp-plugins/assets/57228872/1c1b9043-0647-49e7-b50d-8ca77b60d127
I still have to test that the trajectory generation works with every type of generator and test different configurations and defaults.

With 5528c122aaf255d525fc09b95aee8a8562027c9a I've added a simple unit test: I set a reference position and run the simulation (at batches of 1000 steps) until checkMotionDone returns true. At that point I check that the measured joint position is really close to the reference one.
Here's a video of the test running:
https://github.com/robotology/gz-sim-yarp-plugins/assets/57228872/6f7e41ee-014a-4e0d-b8ea-4137ece76a1d
In this case I'm using the default settings for the trajectory generation (min jerk trajectory with reference speed of 10.0 deg/s and a reference acceleration of 10.0 deg/s^2). In future it can be set up a test trying different configurations, by supplying different .ini files and sdf files (maybe generated from a template using cmake or some c++ library).


Goodscents v1

Hi ! this is version 1 of the Goodscents data set. Can you pull it in the upstream repo? Thanks!

@contrebande-labs Hi, do you mind if I accept this PR and then add another set of steps to convert it into molecules.csv, behavior.csv, etc. as all of the other datasets are provided?  These files will be included as well, and indicated as such in the manifest.toml file that I will write.  These changes are just to give end-users a consistent API to data, and make sure broad checks like "which molecules are in which datasets" always work automatically.

Yes, go ahead. We didn't use the name molecules.csv on purpose because we thought you'd want to do that.


Allow to mark a file as "reviewed"

My workflow with pull requests goes typically like this:

download a patch of the change
apply it locally
go to the changes view
review each file
once done with a file, stage it

I am missing the last part and this blocks me from using this extension in my day to day workflow for more complex changes.

@bpasero can you not just review the files in order and keep track of which file you're up to?

@bpasero I like to jump around a lot when reviewing and typically go in order that is not reflected by the alphabetic sort order

I may look into this, as I definitely like to use this sort of workflow when doing PRs.

Cool, that's great inspiration! I will start looking into this.

If anyone wants to take this one, I'm having a bit of trouble as the decoration type UI stuff I'm super unfamiliar with. I will keep looking at it if nobody else does but I'm taking on some easier ones to get more familiar with the project first.

@justinliew this one is probably best to go through our UX people first as it's not clear what the flow will look like.

Sounds good. I'll keep watching this one but leave the design for the people with the know-how/expertise to ensure consistency.

Hello, are there any updates on this? +1, would love to use this feature!

This gets a +1 from me as well.

Coming back to this to point out that there is UI already in the web to do something like this. Details are here:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/reviewing-proposed-changes-in-a-pull-request#marking-a-file-as-viewed

I could easily see this as a checkbox in the tree view.

This issue relates to this issue as well, and for me I have to review PR in two places, one in VSCode because of a nice tree structure and editor, and another in Github to mark file as viewed. Would be great to have it in VSCode.
Can somebody maybe point to the place in source where one might think implementing this?
\cc @RMacfarlane sorry for direct ping, maybe you can help :)

Hey @dentuzhik!
There isn't a way to render a checkbox in the tree, but we could show a checkmark decoration next to files that are marked as viewed. In the below screenshot, the diamond and letter indicating the git status are tree decorations:

These are implemented here and here.
We could have an inline action or an entry in the context menu for marking the file as viewed, there are some examples of that here.
I just tried looking through the GitHub API docs (both v3 and v4) to see what calls we would need to make to get which files are already marked as viewed, and I wasn't able to find anything about it. I'm not sure if the API is not publicly available, or if I just missed it. Let me know if you're able to find it! I'd love to take a PR for this.

Much appreciated help, thank you 🙌
I will look over the code and see if I can make something work :)

I'm glad that this got into the backlog :D
A year has passed, but it seems that there's actually a v4 version of this API available, so 🤞🏼  we'll see this some time soon!
https://docs.github.com/en/graphql/reference/mutations#markfileasviewed

Viewed files are now decorated with a checkmark, and there's an inline action to mark them as viewed/not viewed:

@RMacfarlane. Could you tell me how can I enable that?
I'm using version 0.25.1, but there is no inline actions for me.

This hasn't been released yet, we follow the same shipping schedule as VS Code, so should have a new version two weeks from now.
In the meantime if you want to try it out, you can use the Nightly version of the extension: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github-insiders
(Note that the Nightly and Stable versions of the extension can't be installed side by side since their commands will conflict, so you will have to uninstall the Stable version to use Nightly)

Thank you @RMacfarlane.


fix: some updates to the mapToBillingDetails()

Fix issue https://github.com/stripe/stripe-react-native/issues/739

Make mapToBillingDetails() return null if both billingDetails and cardAddress are both null.

We shouldn't ignore the postalCode and country from cardAddress when constructing the PaymentMethod.BillingDetails

@charliecruzan-stripe Thanks for review! I have fix the code smell, could you please take a look and see if it's good to go now?


Add function to turn parsed options back into an argv array

It might be out of scope, but it would be helpful to have a function that would turn minimist's parsed options back into an argv array.

How would that be different than process.argv?

The options may not have originated in process.argv. Or in my case, I'm thinking of a script that parses its process.argv options, modifies or removes some of them, and then calls another program with the result.
Completely fine if it's out of scope, but as I'm already using minimist I thought it would be worth asking. (And no one had previously asked, though I now see that's because all the old issues were lost when the old repo was deleted.)

Certainly minimist could hold on to the original arg string it's given, and provide it back out somehow - but I think serializing a parsed object into an argument string is a very complex task, and would need to be able to understand all of minimist's options.
Are there any other argument parsing tools that provide this functionality?

Sure thing.
I haven't looked into any alternatives yet. There are a lot of other arg parsers on npm so probably one of them would support it. Thanks!

Oh, I didn't mean "go use those" :-) i meant, is there any prior art to look at.
Please feel free to reopen after you've looked into it!

I am aware of a couple of implementations, the first of which looks like just what you are asking for:

for minimist: https://github.com/sindresorhus/dargs
for yargs: https://github.com/yargs/yargs-unparser

If it's relatively lightweight to bring in dargs' functionality to minimist - especially since dargs is ESM-only now, and thus unusable - that's worth considering.

A link in the readme would probably be enough.

I don't think it'd be a good idea to endorse any package that has moved to ESM-only, even tacitly with a link.

Hah, I'm on-board with ESM, but I wouldn't want to argue it. Do whatever you feel is best! :)


[Version] prepare release ver 1.8.2 @open sesame 15:57

Update version info for tizen release (ver 1.8.2).
Signed-off-by: Jaeyun<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #213. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/213-202209261542260.19785189628601-c2ef5f1a4035bfd44642c987294e896f4d9ad5ec/.


Custom Loading Screen...But More Complicated

I saw there was another suggestion along these lines in the issues, but I had a bit of a different take on it. I'm not exactly sure how the mod works or anything, but say there was a folder where you put in backgrounds. Plural. Then, whenever the loading screen pops up, it randomly chooses one out of the possible options. Perhaps you could also rotate through the list, as an alternative. Or maybe random with no repeats until you've chosen each at least once, whereupon you clear the list of chosen backgrounds and start over with the randomness again. As another alternative, maybe you could remember the last N backgrounds you've chosen, and choose the next from the other backgrounds. Anyway, you can see my idea, right? Basically, it's not just being able to choose a custom background, but actually being able to set a bunch of random backgrounds, as well as adding some configuration options to the mod. The only real problem I see with this is aspect ratio and image size, but I imagine you could either stretch the image or simply require a specific size.

Another possible solution to the aspect ratio and image size problem would be to just fill in the rest with a solid color, possibly configurable. I imagine that may work, too? Either way, this mod is already a must-have Modrinth mod :)


Note CronJob timezone comes from system timezone

The timezone for the kube-controller-manager determines when CronJobs are scheduled. [preview]
Revert commit bad124b857a2927b75be739646244aacc5190580 from #18715 and add some extra details.
/do-not-merge work-in-progress

/sig apps

/approve


Enormous free energy of binding

Hello,
I followed this tutorial to dock my new ligand into another protein. However, in the end, I obtained extremely high affinity values:
mode |   affinity | dist from best mode
     | (kcal/mol) | rmsd l.b.| rmsd u.b.
-----+------------+----------+----------
   1    1.107e+07          0          0
   2    1.115e+07       1.84      3.158
   3    1.155e+07      1.568      6.297
   4    1.833e+07      1.961       2.21
   5    1.987e+07       2.17      3.457
   6    2.265e+07      1.591      2.251
   7    2.525e+07      1.821      2.733
   8    2.624e+07      2.066      3.882
   9     3.51e+07       2.49      4.033

Here are the steps I followed:

I downloaded the 4lxd receptor from the PDB, removed everything except the protein, protonated it using Propka as implemented on the PDB2PQR webpage; then manually converted the resulting PQR format to PDB, and ran:
prepare_receptor -r 4lxd.pdb -o 4lxd.pdbqt

4lxd.pdb
4lxd.pdbqt

Then, I prepared the ligand (H4Fst) using:
mk_prepare_ligand.py -i H4Fst.mol -o H4Fst.pdbqt

H4Fst.mol
H4Fst.pdbqt

I generated affinity maps for the AutoDock force field using:
pythonsh ./prepare_gpf.py -l H4Fst.pdbqt  -r 4lxd.pdbqt -y
and obtained the 4lxd.gpf file, which I modified using Chimera visualization:

I set  npts 22 12 11 and gridcenter 21.3455 31.4093 8.11142 leaving the remaining parameters as they were.
4lxd.gpf

I ran AutoGrid4 using:
autogrid4 -p 4lxd.gpf -l 4lxd.glg
4lxd.glg

and obtained all the maps enclosed in this file:
maps.zip

Finally, I started Vina using the command:
vina --ligand H4Fst.pdbqt --maps 4lxd --scoring ad4 --exhaustiveness 32 --out output.pdbqt
and the output can be found here:
output.pdbqt.txt

Appreciate advice where I made the issue.
Full_Archive.zip

Hi @farmaceut
In PyMOL, the dimension of the box is displayed in Å
npts 22 12 11 will generate a small box of
0.375 * 22 = 8.25 Å
0.375 * 12 = 4.5 Å
0.375 * 11 = 4.125 Å
where 0.375 Å is the spacing of the grid

Hi again @rwxayheee  :)  Thanks for quick response. So the solution would be either shifting spacing to 1 or change enpts following the equations
0.375 * X = 22
0.375 * Y = 12
0.375 * Z = 11

so  npts  60 32 30 in that case?

Hi @farmaceut Yes npts  60 32 30 will give you the defined box in PyMOL without changing the spacing :>

@rwxayheee
Albeit, 4lxd.gpf looks now like that:
npts 60 32 30                        # num.grid points in xyz
gridfld 4lxd.maps.fld                # grid_data_file
spacing 0.375                        # spacing(A)
receptor_types A C NA OA N SA HD     # receptor atom types
ligand_types A HD OA                 # ligand atom types
receptor 4lxd.pdbqt                  # macromolecule
gridcenter 21.3455 31.4093 8.11142   # xyz-coordinates or auto
smooth 0.5                           # store minimum energy w/in rad(A)
map 4lxd.A.map                       # atom-specific affinity map
map 4lxd.HD.map                      # atom-specific affinity map
map 4lxd.OA.map                      # atom-specific affinity map
elecmap 4lxd.e.map                   # electrostatic potential map
dsolvmap 4lxd.d.map              # desolvation potential map
dielectric -0.1465                   # <0, AD4 distance-dep.diel;>0, constant

docking yielded same incorrect values:
mode |   affinity | dist from best mode
     | (kcal/mol) | rmsd l.b.| rmsd u.b.
-----+------------+----------+----------
   1    1.048e+07          0          0
   2    1.055e+07       2.02      3.311
   3    1.073e+07      1.719      6.845
   4    1.097e+07      1.944      2.312
   5      1.1e+07      1.262      6.415
   6    1.112e+07      2.075      6.526
   7    1.123e+07       2.08      6.958
   8    1.203e+07      1.709      2.266
   9    1.208e+07      1.882       2.61

@farmaceut
I got something like
mode |   affinity | dist from best mode
     | (kcal/mol) | rmsd l.b.| rmsd u.b.
-----+------------+----------+----------
   1       -4.222          0          0

Did you run autogrid with the new gpf file?

@rwxayheee
Yes, I used 4lxd.gpf displayed above.
output.pdbqt.txt
Comparing with yours, it seems the issue is in  INTER part... Wondering why
REMARK ITER + INTRA:     10991577.225
REMARK INTER:            10991577.548
REMARK INTRA:                  -0.324
REMARK CONF_INDEPENDENT:        1.492
REMARK UNBOUND:                 0.324

@rwxayheee
My issue! Forgot to run autogrid4 . Now it is more than good. Thank you!
'''
mode |   affinity | dist from best mode
| (kcal/mol) | rmsd l.b.| rmsd u.b.
-----+------------+----------+----------
1       -4.208          0          0
2       -4.072      1.765      6.758
3       -3.961      1.832      2.393
4       -3.942      2.095      2.551
5       -3.857       2.16      6.683
6       -3.636      4.113      7.674
7       -3.548      2.621      3.775
8       -3.291      4.181      6.308
9       -3.019      3.248      7.181
'''


Implemented FormSelect widget and tests

@quarckster should i add support of init by id/name/etc ? Examples in docs have nothing like that so i ended up in support of locators only, but if we have this widget used somewhere with some unique attr to distinquish them i'm more than happy to add support of it.

@abalakh let's keep it as is, for now, a general locator looks fine for me.


Tweak property order in the inspector for AudioStreamRandomizer

This puts non-foldable properties above foldable properties, which matches the usual expectation in the editor inspector.

This closes https://github.com/godotengine/godot-proposals/issues/7799.

Preview

Thanks!


How does image caching mechanism work?

Q
A

Bug?
no

New Feature?
no

Sulu Version
1.5.3

I'm using git to deploy the project to prod server. My .gitignore file has a historical line /web/uploads. After update on the prod server seems like images can't be generated or something.

Ok. I got that var/uploads is also in .gitignore and it shouldn't be there :)

@ilyasavitski ok good that the issue did solve itself the mechanism is that the image formats are generated on the first request:

@ilyasavitski and var/uploads is in the .gitignore because it should. The images you upload in dev should not be in your git repository. They are not referenced in the Production DB and will be garbage there.


Add mesh opt decode support for model viewer

Hi,
Thank you for your great work.
I noticing current model viewer configuration doesn't support optmized mesh with MeshOpt. I usually compress large meshes with gltf-transform to accelerate the mesh loading in the html tables.
To fix this issue, we can simply adding some configurations for the modelviewer. Here is the original model viewer reference example for loading mesh with mesh opt: meshoptSupport.
All the best.

Thanks for your contribution and I am glad you find it useful! The added feature looks good. I wonder if you could also update the documentation as well?

Sure, I've updated the README with more information about the mesh_opt. Let me know if there's anything else you would like me to add.

Thanks!


chore: switch to thread pool for running tasks

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#194  👈
#193
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Raspberry Pi 400 Issue

I'm having trouble with the local installation on my Raspberry Pi 400. I am able to successfully complete the direct install and build a package, but I keep getting an error for the package file installation. I have confirmed that the file is in the correct folder. Any suggestions?
Here is the error:
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Processing ./sparkfun_qwiic-1.1.10.tar.gz
ERROR: Command errored out with exit status 1:
command: /usr/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-9arnukn4/setup.py'"'"'; file='"'"'/tmp/pip-req-build-9arnukn4/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-k4plsrk9
cwd: /tmp/pip-req-build-9arnukn4/
Complete output (5 lines):
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-req-build-9arnukn4/setup.py", line 45, in
with io.open(path.join(here, "DESCRIPTION.rst"), encoding="utf-8") as f:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-req-build-9arnukn4/DESCRIPTION.rst'
----------------------------------------
WARNING: Discarding file:///home/oepuser/Qwiic_Py/dist/sparkfun_qwiic-1.1.10.tar.gz. Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Could you provide more information beyond, just an error message? It would be helpful for our team to know what you did to cause it (i.e. what command/script you ran)
Additionally, why are you trying to build the package?

As mentioned in the README.md and documentation, this package can be installed with pip.
If you are running into issues with the pip installation because you you are utilizing the Bookworm OS, you have a few options:

Use an older distribution of Raspberry Pi OS or Raspbian
Use the --break-system-packages flag to force install the Python packagepython3 -m pip install sparkfun-qwiic --break-system-packages

Since we haven't heard back, I'm going to close this issue for now. However, feel free to re-open it, when you have more information to provide.


python3Packages.sentry-sdk: 1.5.8 -> 1.5.10

Description of changes
https://github.com/getsentry/sentry-python/releases/tag/1.5.10
Also, addresses some of the failures with came up with #169414

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 169929 run on x86_64-linux 1

3 packages marked as broken and skipped:

python39Packages.spacy
python39Packages.spacy-transformers
python39Packages.textacy

1 package failed to build:

octoprint

14 packages built:

alerta-server
cura
gns3-gui
gns3-server
home-assistant-component-tests.sentry
moodle-dl
moz-phab
netbox
openai (python39Packages.openai)
python39Packages.django-rq
python39Packages.sentry-sdk
python39Packages.spacy-loggers
python39Packages.wandb
tribler


to solve "label shock "

the LabelPropagation often suffers "labe shock"， and the result of communities are often non-adjacent.
I think the label of node  is  userful between adjacent supersteps, and the adjacent supersteps are relevant.

Can one of the admins verify this patch?

the LabelPropagation   often suffers "labe shock"， and the result of communities are often non-adjacent.
I think the label of node  is  userful between adjacent supersteps, and the adjacent supersteps are relevant.

This looks like it was opened in error, close it please?


dolt benchmarking

Initial approach is to write a script that will run n benchmarks, collect their results, then serialize those results to later be imported into dolt. Looking for feedback on approach before I head too far down this path, if it is suboptimal.
In it's current state, there are a lot of switch statements and panics and it only accounts for types int and string and only accounts for .csv style test data formats, but I'd like to make my data generation functions robust enough to be able to account for all file formats that dolt supports and all noms types...

Here is what some example output looks like:

id | name | rows | columns | time | bytes | mem_allocs | mem_bytes | mem_string
-- | -- | -- | -- | -- | -- | -- | -- | --
1 | dolt import small | 1000 | 11 | 1.453582345s | 0 | 5611329 | 768600784 | 14233347 B/op          103913 allocs/op
2 | dolt import medium | 100000 | 11 | 1.624804363s | 0 | 10163387 |<PHONE_NUMBER> |<PHONE_NUMBER> B/op	10163387 allocs/op
3 | dolt export small | 1000 | 11 | 1.179067199s | 0 | 7123517 | 482183120 | 3652902 B/op	   53966 allocs/op
4 | dolt export medium | 100000 | 11 | 1.325067822s | 0 | 16034003 |<PHONE_NUMBER> | 376249920 B/op	 5344667 allocs/op
5 | dolt sql select small | 1000 | 11 | 1.177204492s | 0 | 6608042 | 353005368 | 3530053 B/op	   66080 allocs/op
6 | dolt sql select medium | 100000 | 11 | 1.0513617s | 0 | 12317226 | 568577008 | 284288504 B/op	 6158613 allocs/op

Here's the updated output:
id,name,format,rows,columns,iterations,time,bytes,mem_allocs,mem_bytes,alloced_bytes_per_op,allocs_per_op
1,dolt_import_small,.csv,1000,11,55,1.705456824s,0,5692990,784745464,14268099,103508
2,dolt_import_medium,.csv,100000,11,1,1.652146482s,0,10170071,1132460944,1132460944,10170071
3,dolt_export_small,.csv,1000,11,121,1.262386877s,0,6533389,442266096,3655091,53994
4,dolt_export_medium,.csv,100000,11,3,1.344190306s,0,16035012,1128151264,376050421,5345004
5,dolt_sql_select_small,.csv,1000,11,100,1.29980135s,0,6609502,352963464,3529634,66095
6,dolt_sql_select_medium,.csv,100000,11,2,1.075717772s,0,12318907,568552720,284276360,6159453
7,dolt_import_small,.sql,1000,11,2228,1.136287698s,0,2430448,4347960312,1951508,1090
8,dolt_import_medium,.sql,100000,11,1,7.601747233s,0,20736670,1688449240,1688449240,20736670
9,dolt_export_small,.sql,1000,11,120,1.056781272s,0,8569769,604214464,5035120,71414
10,dolt_export_medium,.sql,100000,11,2,5.584825618s,0,14235285,1030080048,515040024,7117642
11,dolt_sql_select_small,.sql,1000,11,55,1.242910945s,0,3320969,185978528,3381427,60381
12,dolt_sql_select_medium,.sql,100000,11,2,1.840086309s,0,11121978,539658128,269829064,5560989
13,dolt_import_small,.json,1000,11,44,1.472986893s,0,5640831,645226680,14664242,128200
14,dolt_import_medium,.json,100000,11,1,3.191727912s,0,12457546,1179472560,1179472560,12457546
15,dolt_export_small,.json,1000,11,90,1.36247915s,0,6851175,526866568,5854072,76124
16,dolt_export_medium,.json,100000,11,1,1.312833362s,0,7592134,534376240,534376240,7592134
17,dolt_sql_select_small,.json,1000,11,81,1.131980815s,0,4894551,274369456,3387277,60426
18,dolt_sql_select_medium,.json,100000,11,1,1.034637505s,0,5588382,271759864,271759864,5588382

Tim says he'd like to run this app against nightly dolt builds on airflow, any tips for how to optimize my design for this, or is this good enough to get us started?


Amplify CI/CD - Branch changes are sometimes not detected

Describe the bug
Sometimes when I merge changes into a branch Amplify does not detect the update on Github. It's happened on multiple branches I am trying to deploy. I have tried Reconnect Repository as well as disabling then re-enabling branch Auto-build but it doesn't do anything. Most of the time my builds work so I know my setup works but this has started to occur with more regularity. The only solution I've found to fix this is deleting the branch and re-adding it when this occurs.
Expected behavior
When I merge a tracked branch Amplify will deploy an update to the statically hosted site.
Screenshots

Can you send a send app id/region to<EMAIL_ADDRESS>and reference this issue?

@behrooziAWS I sent the email but still waiting on a reply...

@behrooziAWS I got an email 2 weeks ago from someone saying they're looking into this. I have followed up multiple times but they never reply.
Can I please get an update. This has become a significant issue for my team.

@Jordan-Eckowitz , I'm looking into this. Does your team run more than 5 concurrent builds at a time?

Re-opening this ticket as the fix has not been fully deployed yet.  I will update this as we verify the fix is complete.

Re-opening this ticket as the fix has not been fully deployed yet.  I will update this as we verify the fix is complete.

Re-opening this ticket as the fix has not been fully deployed yet. I will update this as we verify the fix is complete.

Yeah, just saw its still not working

Re-opening this ticket as the fix has not been fully deployed yet. I will update this as we verify the fix is complete.

Yeah, just saw its still not working

Hi @hsspain - has this fix been deployed yet?

Hi @hsspain - has this fix been deployed yet?

Also experiencing this when pushing changes to a CodeCommit branch. Change not detected in Amplify thus the build never runs.

We have a fix for this issue which will begin rolling out in a week. Stay tuned. I'll update this thread next week.

We have started rolling out a fix for this issue which should be available to all regions next week.

Hi @nimacks , curious if we should expect to see this change yet? Thank you for looking into.

Hey @adambschroeder ,  we pushed a fix to address codecommit pushes not triggering builds. However, there is an edge case scenario when multiple branches are pushed at the same time, and some of them don't exist, it short-circuits instead of skipping. We will be deploying this fix shortly, but the general happy path should work. Let us know if you face any issues.

hey @Jordan-Eckowitz, can you confirm that your issue has been fixed?

I am not seeing the fix for this yet. Will I need to delete a branch connection and redo it?
Our repository is on CodeCommit and we have Amplify connected to our [develop] branch. Whenever we merge into or commit to [develop], Amplify does NOT start the build.

hey @Jordan-Eckowitz, can you confirm that your issue has been fixed?

Hey @nimacks - I haven't had any issues with it this week. I'll post here if I run into any issues but so far it seems fine.

I am not seeing the fix for this yet. Will I need to delete a branch connection and redo it?
Our repository is on CodeCommit and we have Amplify connected to our [develop] branch. Whenever we merge into or commit to [develop], Amplify does NOT start the build.

@adambschroeder as a workaround (recommended via email by @nimacks a while ago) I have branch auto-detection enabled (App Settings -> General). For the branch matching patterns I've added the names of my deployed branches. It seemed to help.
@nimacks do I still need to keep that enabled or can I remove it?

Thank you @Jordan-Eckowitz for that! I will test that out.
Without that set, the branch auto-detection still does not seem to be firing - we currently have a webhook setup to manually deploy that we have run with every update.

@adambschroeder The fix may have still been rolling out depending on the region you are in for CodeCommit.  It completed on March 4.
@Jordan-Eckowitz You are welcome to try removing auto-detection.  If you encounter another case where a commit does not trigger a build for a connected branch, send your commit id to<EMAIL_ADDRESS>and turn back on auto-detection. That will enable us to review the exact webhooks we received from GitHub for that commit and identify what caused it to be ignored.

is this supposed to be fixed in ap-southeast-2 (Sydney) region yet?
still experiencing this problem right now
when creating "branches" in CICD deployments in Amplify Console - they work initially and sometimes 2nd time around (when pushing a change to CodeCommit, but the stop triggering...
also apparently there is no way to manually "kick" a re-deployment, is it ?
if there is please tell how!
thank you!

@OK-Apps It has been deployed to ap-southeast-2.  If you can provide the code commit hash, we can investigate further.  If there is no job associated with the commit, there is currently no way of re-triggering a deployment in the Amplify console.

Hi @behrooziAWS - just ran into the same issue again. Branch change was not detected (auto-detection was still enabled and still didn't catch it...)

@Jordan-Eckowitz can you send the commit hash to<EMAIL_ADDRESS>for that change?
@vineethbhargavan can you send your appid, region and the commit hash of a change that did not build to<EMAIL_ADDRESS>?

Done - @behrooziAWS

@vineethbhargavan Thanks! We've identified and patched an issue with CodeCommit and buildspecs that have an applications section like yours failing to trigger builds.  We'll keep you posted as the fix rolls out.

Thanks for the update. Looking forward to the roll out.
On Fri, 12 Mar 2021 at 6:49 am, David Behroozi @.***>
wrote:

@vineethbhargavan https://github.com/vineethbhargavan Thanks! We've
identified and patched an issue with CodeCommit and buildspecs that have an
applications section like yours failing to trigger builds. We'll keep you
posted as the fix rolls out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-console/issues/1154#issuecomment-797004180,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAWU4C5I6RX4LLA7WSOAEDTDEGFFANCNFSM4SZ6NYLA
.

Any update on this? Can I get a tentative date as to when the fix will get
rolled out?
Thanks
Vineeth.
On Fri, Mar 12, 2021 at 6:52 AM Vineeth Bhargavan @.***>
wrote:

Thanks for the update. Looking forward to the roll out.
On Fri, 12 Mar 2021 at 6:49 am, David Behroozi @.***>
wrote:

@vineethbhargavan https://github.com/vineethbhargavan Thanks! We've
identified and patched an issue with CodeCommit and buildspecs that have an
applications section like yours failing to trigger builds. We'll keep you
posted as the fix rolls out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-console/issues/1154#issuecomment-797004180,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADAWU4C5I6RX4LLA7WSOAEDTDEGFFANCNFSM4SZ6NYLA
.

@vineethbhargavan the fix for your issue is now in ap-southeast-2.  It should be in all regions by EOD today.

This fixed the same issue for me with a CodeCommit repo. @Jordan-Eckowitz my workaround to trigger builds manually when it got stuck was to use a webhook to trigger the build.
On a side note, I've noticed that if another push is made while a build is in progress, it does not trigger a subsequent build to detect the changes. So if a developer pushes a change during a 3-5 minute window it takes for the build to complete, it will never be deployed until the next commit.

I am also experiencing this issue (in eu-west-1)
Also should this be untagged as pending-customer-response as it's still an issue for multiple customers and we're waiting on a fix?

I am also experiencing this issue with code commit repo  (in ap-southeast-2)

After three months been really happy using amplify it stop recognizing branch changes. Now, I have to manually build my app. It's very disappointing. Because now I can't trust on this CD mechanism,  I'm thinking about going back to my python script, cloudfront and S3.

I am running into this same issue. I tried reconnecting the repository and sometimes that helps but it seems to be a temporary fix. I never ran into issues with this until today and I've used amplify CI/CD consistently for months now.

@ViniBjazevich Could you please share your App ID/Region?

d2n3kwnhtn68zj - US-West-1
On Mon, Mar 21, 2022 at 1:13 PM Kaushik Gnanaskandan <
@.***> wrote:

@ViniBjazevich https://github.com/ViniBjazevich Could you please share
your App ID/Region?
—
Reply to this email directly, view it on GitHub
https://github.com/aws-amplify/amplify-hosting/issues/1154#issuecomment-1074248001,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALV6D3467JPITQPKKRQ4BNDVBC323ANCNFSM4SZ6NYLA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have the same issue starting from today.

@ace-d please share your App ID and region

Hi,
Thanks for the reply! The id is d3b8ar5crt5pri and region is us-west-1. The issue happened around 6:00 pm - 8:00 pm PST on 21st Mar.
The CI/CD feature seems working fine this morning.

@ace-d @ViniBjazevich we've been working on resolving this issue. Can you confirm if this behavior is still happening?

Just ran into this issue today on eu-west-2. Merge from dev -> prod doesn't trigger a build on prod

@scottbw  Can you create a new issue and provide more details?


Add support muting warnings for RTSP server

In Home Assistant, we add for all streams the following additional line "ffmpeg:{stream_name}#audio=opus" to have audio on WebRTC as most cameras are only supporting aac.
If you use a no-audio camera with the above ffmpeg config, you will see anytime you start the stream the following log entry: 09:32:51.973 ERR [rtsp] error="streams: codecs not matched: H264 => ANY" stream=camera.x
This PR downgrade the level to debug only when ffmpeg is the source of the RTSP stream

Thanks. I've made some edits to the implementation.

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.7


Make it possible to run one component in isolation

[x] Implement "Run from here"
[x] Teach "Run from here" to recreate historical edge values.
[x] Update edge value machinery to correctly reflect how values are passed over the edges
[ ] Teach VE to run board step by step
[ ] Allow editing values before each step.

A few running notes:

I wonder if we should make the "Debug Board" option do this step-wise work?
When I go to the next step I see the wire value as consumed before I've run the next component:
I know we currently identify the next opportunity, but in the case above there are two "equivalent" opportunities and I wonder if we need to identify those?

Further thoughts having played with it for a while:

I love it.
When I edit the value of a node and run it I really want to see its output in the Board Activity. It feels off that it needs to be consumed by an output first somehow. I think we can get there with edge emit, as per the above.
I find myself knowing it's a run, but then being confused as to why it stopped. So I feel like we need to really telegraph to the user that execution is paused waiting for them to decide what to do next. I think this is a great opportunity in the Board Activity to have "Carry on from here" and "Re-run this component" options.

Declaring victory, let's track new features/bugs separately 🚢


update the build instructions on readme

updated the build instructions to reflect what's required by do.sh

would be great if instructions cover how tests can be run locally too. @diracdeltas , thoughts?

Thanks. To run tests locally, run do.sh testserver and navigate to localhost:8000. That is mentioned in https://github.com/yahoo/end-to-end/blob/master/docs/CONTRIBUTING.md but might be good to have in the README too.


[docs] Update upgrade docs

What does this PR do?
Updates upgrade docs, so that they're at least up-to-date with the fact that Agent 6 is GA now.
Motivation
The upgrade-specific instructions are missing from web app, so let's keep them in the present repo (for now at least, I've updated backlog card to also update in-app instructions).

Waiting for CI but LGTM. 👍


[BUG] Missed todo creation when merging PR

Describe the bug
When merging https://github.com/roblabla42/KFS/pull/157, an issue was not created for the TODO associated with it. I did some tests with the CLI (see PR #187), and it does detect the TODO properly:
roblabla@roblab ~/Dropbox/dev/src/js/todo master $ node bin/todo.js -o roblabla42 -r KFS --pr 157
Item found [Write some AHCI documentation] in [roblabla42/KFS] at [7d7fbcbf3c6409c357e00e30d5c18503203d8896]
Creating issue [Write some AHCI documentation] in [roblabla42/KFS]
---
Title: Write some AHCI documentation
Body:
 https://github.com/roblabla42/KFS/blob/7d7fbcbf3c6409c357e00e30d5c18503203d8896/ahci/src/main.rs#L1-L4

---

###### This issue was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in 7d7fbcbf3c6409c357e00e30d5c18503203d8896 when #157 was merged. cc @roblabla.
---

To Reproduce
Unsure. Maybe I got unlucky and merged the PR while the bot was down?
Expected behavior
An issue should have been created.

We recently installed the todo bot via GitHub Apps and also don't see any issues being created on merge:
https://github.com/cortex-lab/Rigbox/pull/119
Are issues only created when merging into master?  If so this could be added to the documentation.

@k1o0 it appears that that PR's diff is too large: 136635/100000 (your pr / the limit). I instituted a limit to the size of diffs that would be parsed because overly large diffs (like people committing minified files) were causing downtime (see #194). Happy to raise that limit if needed, it was an arbitrary thing (I did some digging to find the average diff size internally). Can you open a new issue about it?


People Also Ask leaking through

What filter does this issue target?
https://letsblock.it/filters/google-search-cleanup
What changes should be made?
"People also ask" is no longer being blocked by the "Google Search: interface cleanups" filter despite "Hide the "People also ask" contextual content" being checked (all filters are checked and updated.
Did you write a uBlock filter solving this?
No, using the existing filter.
Additional notes

Hello @3DWORX-SA and thanks for the detailed report. Could you please try the following rule?
www.google.com###rso div.related-question-pair:upward(div[jscontroller])

I presume you meant filter, not rule.
But it works as a filter. Thanks!
From: Xavier Vello @.>
Sent: Saturday, July 8, 2023 2:05 PM
To: letsblockit/letsblockit @.>
Cc: 3DWORX-SA @.>; Mention @.>
Subject: Re: [letsblockit/letsblockit] People Also Ask leaking through (Issue #500)
Hello @3DWORX-SAhttps://github.com/3DWORX-SA and thanks for the detailed report. Could you please try the following rule?
www.google.com###rsohttp://www.google.com/###rso div.related-question-pair:upward(div[jscontroller])

Reply to this email directly, view it on GitHubhttps://github.com/letsblockit/letsblockit/issues/500#issuecomment-1627187598, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3GLKJB7AE4AYN424FADILXPFEF5ANCNFSM6AAAAAA2CY7OSE.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Heya @3DWORX-SA
The fix has just been deployed! Your browser will get the update in less than 24h, but you can manually refresh your list right now to grab it!

Great, thanks Xavier.
From: Xavier Vello @.>
Sent: Saturday, July 8, 2023 6:34 PM
To: letsblockit/letsblockit @.>
Cc: 3DWORX-SA @.>; Mention @.>
Subject: Re: [letsblockit/letsblockit] People Also Ask leaking through (Issue #500)
Heya @3DWORX-SAhttps://github.com/3DWORX-SA
The fix has just been deployed! Your browser will get the update in less than 24h, but you can manually refresh your listhttps://letsblock.it/help/refresh-list right now to grab it!

Reply to this email directly, view it on GitHubhttps://github.com/letsblockit/letsblockit/issues/500#issuecomment-1627395670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3GLKPKXQ2IRYFPFCNJQGDXPGDYTANCNFSM6AAAAAA2CY7OSE.
You are receiving this because you were mentioned.Message ID: @.***>


update README.md for improved formatting and clarity

Improving the formatting for the README.md file. Based on these rules.

Ah, I see now why you might have decided to show the images with HTML, the screenshots of HomeKit are too big as they are, so you put the at 200px width... I'm gonna resize them to try and fix this


fix typo in doc reference

The powershell link accidently pointed to the az cli documentation, instead of the powershell version.

@DanniJuhl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; merging.


Code Mauve Investigations & Process Changes

This epic tracks Code Mauve related design investigations & process changes that we want to implement. These include things like, test methodology changes, test infrastructure investigations, branch model proposals etc.
We will use Code Mauve/Process label to track the sub-issues.

Do we still need this Epic?


[BUG] Response content-type changed in 2.11 for some endpoints

In 2.11, there was a change to introduce a SecurityResponse wrapper around a BytesRestResponse. In the method to cast the SecurityResponse to a RestResponse, the method creates a BytesRestResponse using the constructor without contentType. (Here's the BytesResponseResponse constructor for context). Even if an instance of SecurityResponse is created with a Content-Type header it is being ignored since the constructor of BytesRestResponse will set it at the time the RestResponse is instantiated.
APIs impacted:

/_plugins/security/api/authtoken
Any Unauthed call now responds with application/json instead of text/plain

The change to the SecurityResponse class causes all of the methods hit with asRestResponse() to be converted.
This means that the impacted APIs can be found by moving up a level to where the asRestResponse() method is called inside of the [SecurityRestFilter](https://github.com/opensearch-project/security/blob/1d46ba6131aa1d8994da6eb13965c5d4d5c698df/src/main/java/org/opensearch/security/filter/SecurityRestFilter.java#L132C25-L132C25). Then we can look at each of the scenarios inside the wrap method to determine which calls are impacted.
Notably, the wrap method is called on all rest requests so it is more about the actual cases and whether they trigger the if-statements that lead to the asRestResponse than anything else.
The first asRestResponse is called when we try to determine whether the response has been cached. This is then based in the SecurityHttpServerTransport logic. Looking at this, it seems that we try to signify early responses for handling of decompression by identifying request attributes which are set in the [Netty4HttpRequestHeaderVerifier](https://github.com/opensearch-project/security/blob/1d46ba6131aa1d8994da6eb13965c5d4d5c698df/src/main/java/org/opensearch/security/ssl/http/netty/Netty4HttpRequestHeaderVerifier.java#L112).
The second asRestResponse happens when we check whether the request is authenticated and skip any that are not. This covers the scenarios that Craig mentioned above with his second bullet about unauthed calls.
The third asRestResponse happens when a request is denied. This is what it sounds like, we check whether a request is not allowlisted (if allowlisting is enabled). We return false if it is not allowlisted and then set this optional which will cause the asRestResponse call.
The final asRestResponse happens when a response is queued for delivery. This occurs when a response is placed in the response queue for a channel based on the SecurityRequestChannel interface. If the channel has a queued response we send a response by grabbing the queued response from the channel and calling asRestResponse on it.


Front Channel and Back Channel Logout Sample Code request

Hi,
Do you have any sample code which exhibits Front Channel and Back Channel Logout scenario in Aspnetcore MVC application?
You quick response is highly appropriated.

Did you check our samples?

I have seen it. But not saw specific sample codes for Front Channel and Back Channel Logout.
Can you please share the exact sample path for this?

See
https://github.com/IdentityServer/IdentityServer4.Samples/blob/master/Clients/src/MvcHybridBackChannel/Startup.cs
and
https://github.com/IdentityServer/IdentityServer4.Samples/blob/master/Clients/src/MvcManual/Controllers/HomeController.cs#L42

Hi,
When I call
HttpContext.Signout() function then cookies has been set like below.
{idsrv=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/; httponly,idsrv.external=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/; httponly}

I don't follow what you're trying to explain./

Sorry Brockallen,
I followed least suggestion, now we can able sign out without any issue using Back Channel Logout Uri.


Projects and bundles initially not visible

Upon logging in to the scenario editor, the "open project" and "select bundle" tabs are completely empty (no text, no buttons) and remain that way for a while. After several minutes they begin working and are populated with all the existing projects and transit data.

I believe this issue is resolved. Please let me know if you come across it again.


Add Windows note for vendored packages

This sounds like a good idea. However, including the source of every single one of our deps sounds sketchy. Look at making it a submodule or similar so we don't need to lug everything around within this repo?

Done in 827709dd995342f2e6449562bfbcdcff2160a10f with vendetta. We should add this to developing.md.
Keep in mind, https://github.com/dpw/vendetta/issues/17

Now documented as of 1b92f9e93fb0e5bd0149c40fe01af36ffec10dbf. We'll add the Windows note in a bit later

Resolved by 27e36e4c6ac212ab30fe1317cac934849fc2c1be


Link broken to mlnx_tuning_scripts.tar.gz script

#download the Mellanox mlnx_tuning_scripts tarball, https://www.mellanox.com/sites/default/files/downloads/tools/mlnx_tuning_scripts.tar.gz and extract it

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc91cc25-7d13-a975-76ee-6d97bdcf9416
Version Independent ID: ae8d2f7e-0c69-1269-a438-d6d36594dd27
Content: Performance best practices for SQL Server on Linux - SQL Server
Content Source: docs/linux/sql-server-linux-performance-best-practices.md
Product: sql
Technology: linux
GitHub Login: @tejasaks
Microsoft Alias: tejasaks

@Pitterling -- Pitt, thank you for catching this.
@tejasaks -- Tejas, please look into this issue.  I can't find anything on the Mellanox site that is comparable.

https://github.com/Mellanox/mlnx-tools/tree/master/ofed_scripts


Get app version name on About this app screen

Kind (Required)

Improvement

Overview (Required)

Related issue #308
Get app version name on About this app screen

🙋

Thanks! Assigned 👍

@tomoya0x00
Thank you, but is a different person assigned?

@t-nonomura Oh, Sorry 🙇 Reassigned 👍


"error":"json: cannot unmarshal object into Go value of type []*server.importStorageObject"

Before you submit an issue we recommend you drop into the Gitter community and ask any questions you have or mention any problems you've had getting started with the server.
Please provide as much information as you can with this issue report. If you believe it may be an issue with one of the client libraries please report it on their own trackers.
Description
Getting 'Failed to upload the file' error when uploading json file to Storage in admin panel.
Logs: {"level":"warn","ts":"2019-05-21T11:03:22.819-0700","msg":"Could not parse JSON file.","error":"json: cannot unmarshal object into Go value of type []*server.importStorageObject"}
$ ./nakama --version
2.5.1+8216d5cc
Json I am trying to upload:
{     "items": [         {             "desc": null,             "id": "3423",             "name": null,             "parameters": null,             "quantity": 0,             "tags": null,             "type": 0         }     ],     "version": "1" }
Steps to Reproduce

Login as admin to
Go to Storage
Select Import Json file
drag and drop json file.
Error appears: Failed to upload the file.

Expected Result
No error is thrown and json file uploaded
Actual Result
The error appears: Failed to upload the file.
Terminal logs: {"level":"warn","ts":"2019-05-21T11:03:22.819-0700","msg":"Could not parse JSON file.","error":"json: cannot unmarshal object into Go value of type []*server.importStorageObject"}
Context

[ ] Unity
[ ] Unreal
[x] Other(web)

Your Environment

Nakama: 2.5.1+8216d5cc
Cockroach: v2.1.6
Environment name and version:
Operating System and version: OSX 10.14.4

The file you are trying to upload doesn’t match the required format by the system.
Where is the origin of the file?

@mofirouz Here is the file I try to upload config.txt
Could you please advice on the format for json file?

I meant what has generated the config.txt file

@mofirouz oh sorry, It was just manually created.

 Ie how did you come up with that structure?

@mofirouz  The end goal is to pull this data from Unity later. The specification for that particular json is coming from internal needs.

This is the format that the JSON importer expects:
[
  {
    "collection": "testcollection",
    "key": "testkey",
    "user_id": "fb912423-82cb-4e3a-8f67-42c37be19a3c",
    "value": "{\"hello\": \"world\"}",
    "permission_read": 2,
    "permission_write": 1
  },
  {
    "collection": "testcollection",
    "key": "testkey2",
    "user_id": "9e997e08-7e81-4d3b-a3d3-3458f7c5e5e1",
    "value": "{\"hello\": \"world\"}",
    "permission_read": 1,
    "permission_write": 1
  }
]

@mofirouz We should make a note to add this advice to the docs for the expected import format with the Developer Console. 📓

Thanks for the help guys! I wanted to mention, great that you have such a quick feedback time!


chore: test on node 14

We should probably test on node 14 since that's our min supported Node version.

Well TIL fs/promises rm was added in 14.14.0 https://nodejs.org/api/fs.html#fspromisesrmpath-options


[Retail/Shadowlands Beta] Latest alpha versions fail to start with nil error

1x GSE\API\Events.lua:116: attempt to call field 'PrintDebugMessage' (a nil value)
Possible Fix:
Change version number in all 3 TOC files from
## Version: 2.6.01_SL_alpha8
to
## Version: 2.6.1
This fixes the error in Retail and Shadowlands beta! Confirmed and tested by myself (Retail) and Lutechi (Beta).

Fixed in https://github.com/TimothyLuke/GnomeSequencer-Enhanced/releases/tag/2.6.01-alpha9-shadowlands


scenarios: miner_std should accept single --tank option

Currently miner_std either tries to mine from ALL nodes or only the 0th node in the network. Since it also naively calls rpc createwallet and some older node versions do not support that command, the scenario fails. I think we can also modify the scenario to be more flexible with older versions but it also makes sense to be able to just pick a single mining node. The signet miner scenario already has this option.

uTACK


Improve performance of queries against SYSTEM.SEGMENT table.

Fixes #11007 .
After hooking up Yourkit against the broker instance running the queries mentioned in the above issue, it turns out that a lot of time is being spent in resizing HashMap and HashSet that have been created with the default constructor. Also, a lot of CPU cycles are wasted unnecessarily looping through and authorizing resources even though the authorizer configured is AllowAllAuthorizer.
After making these changes, on my test cluster, I see that the query times went down from ~12seconds to ~7seconds.
This PR has:

[X] been self-reviewed.

[X] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[X ] been tested in a test Druid cluster.

+1 after CI


Reimplement st2_handler in Ruby

Backgroun
The Handler of st2_handler is wrapped by Ruby but the main processing is implemented in Python because this is ported from the stackstorm-sensu which is a project written by the Python.
Problem
The sensu plugin installer (sensu-install) doesn't install the Python libraries on which the st2 handler depends at the installation. So a runtime error may be occurred because of the failure of importing libraries.
Proposal
If the we could specify the handler which is called after the gem installation (like the postinst script of debian-package) in the gemspec, this problem would be solved easily, I think.
But we can't specify that kind of script as far as I know.
So I would like to reimplement the st2_handler in Ruby.

I have not done it myself but from what I read you can probably accomplish this through a post install hook but this does add the requirement of a c compiler I believe as it needs to be executed as an extension? @eheydrick have you any other insight into that?


CSS updates in Firefox 80

Story
As a web developer, I want to know about the latest updates to CSS, so that I can style my sites and apps using the latest CSS declarations.
Acceptance criteria
The following bugs are dev-doc-complete, BCD is updated, an entry to Firefox 80 release notes is added, experimental features page is updated.

[x] Implement the prefers-contrast media-query Not yet enabled by default. So only needed to be added to experimental features page.

[x] Support standard 'appearance' CSS property unprefixed. Intent to ship: https://groups.google.com/g/mozilla.dev.platform/c/x8njjxKySKY, intent to prototype: https://groups.google.com/g/mozilla.dev.platform/c/nlun5QV63Bo/m/xUXCmySGAgAJ

[ ] [css-pseudo-4] Animations on ::marker?

Item 1:

Updated prefers-contrast article
BCD PR

Item 2:

Updated the appearance reference article, including separating out non-standard and obsolete values.
BCD PR
Interactive examples PR

Item 3:

Updated ::marker article.
BCD PR


make ECDH unpadding more robust

The padding mandated by RFC 6637 may exceed the blocksize of 8 bytes. This caused problems, for example with messages from GOpenPGP, which use AES128 secret keys and contain 21 bytes of padding: the previous implementation failed to decrypt these and returned an Error::UnpadError.

My impression is that, while RFC 6637 references PKCS5 as "the general idea" that the padding in OpenPGP follows, using a PKCS5 unpadding function will fail, because the length of the padding used in OpenPGP can exceed the block size of 8.
So it's really not PKCS5 padding, in a stricter sense, if I understand correctly.
However, it seems innocent enough to implement the RFC 6637 unpadding scheme manually, as outlined in this PR.

We could consider, in a separate PR, to use ECDH padding to conceal key size (as outlined in RFC 6637, for example with AES. this means always padding to 40 bytes). Currently the padding in rpgp only pads to block size. Which is a valid approach, and can save a few bytes of space, but gives eavesdroppers more insight into the key length.
I have no strong feelings about this question, right now, but wanted to raise it while the padding is on my mind. If there is interest, I can open a separate ticket to track this issue.

just want to say hello 👋 - i am following these recent rpgp ongoings and high-level discussions with admiration. super-nice to see such a push here!

can you add a test with one of those padded keys please, and also file an issue to do the obfuscation impl (to 40 bytes..gotta keep some sanity)

The decrypted (and padded) key in this message reads:
[07,   # AES with 128-bit key

# AES 128 session key:
  e1, fc, 84, f9, 2f, 9e, 85, 01,
  11, fb, 12, ee, ba, 1b, e3, e2,

# checksum:
  09, 53,

# padding:
  15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15, 15]

There are 21 bytes of padding in the message, padding it to a total length of 40 bytes.

By contrast, when encrypting to Alice's key with sqop, we get a message that uses AES256 and a padded session key with only 5 bytes of padding:
-----BEGIN PGP MESSAGE-----

wV4D4uDroNMMT4QSAQdAxYnDMbJRKbO9/XbXVr7hxq1TbIZjkMD4no/tF/uLJEsw
/7/4n/oGWofvF7YbqEc7fwIdAt5KY7GRWTLvT4/KOt9280OjITmDvLm4lxsiPj7e
0jcBBFNzsp79iSX+rmLS4sT/Fd1JOPnqBY5FhxPfcZy/xFNuDC7LMYTZVQJRbkCn
UheUc5ALR3Fw
=9v3V
-----END PGP MESSAGE-----

Decrypted and padded key:
 [09,

 01, 36, 4e, 82, c4, be, 22, fb,
 2c, 20, 9f, 25, 6a, 73, cd, e4,
 9b, 2a, 27, d6, f0, 1e, 59, 1f,
 e1, 29, fd, 9e, 02, 28, 94, 79,

 0e, 68,

 05, 05, 05, 05, 05]

In preparation to making progress on this, I'm generating and documenting artifacts.

Don't "document" it, just add test cases with these vectors! This will be a great regression test suite that will be always checked by the CI! 😌

In preparation to making progress on this, I'm generating and documenting artifacts.

Don't "document" it, just add test cases with these vectors! This will be a great regression test suite that will be always checked by the CI! 😌

Hah :) yes, of course! This is my scratchpad, so I can do little bits of work, get interrupted, and resume later (writing up things publicly seems useful, if I have to write them up anyway)

can you add a test with one of those padded keys please, and also file an issue to do the obfuscation impl (to 40 bytes..gotta keep some sanity)

I opened #292 to track extending the padding that rpgp emits,
added two tests that decrypt ECDH messages that use 5 and 21 bytes of padding respectively (I confirmed that the second test fails without this PR), and
added sanity checking after unpadding, to ensure! that the format of the unpadded key meets our expectations.

This currently fails crypto::ecdh::tests::test_encrypt_decrypt, not ready for review yet?

The PR definitely requires input (but I admit I was too optimistic, and thought there would be no more remaining problems/questions :)).
What CI complains about is this test: https://github.com/hko-s/rpgp/blob/ecdh-unpad/src/crypto/ecdh.rs#L318-L324
The test encrypts and decrypts plaintexts of varying length and with arbitrary (random) content.
Here, @dignifiedquire suggested we do more checks on the format of the unpadded data. I implemented checks that make assumptions about format of the decrypted/unpadded data.
However, crypto::ecdh::tests::test_encrypt_decrypt unit test seems to assume that pgp::crypto::ecdh::decrypt can handle arbitrary plaintexts. If that's what we want, then I don't think we can do stricter checks on the unpadded plaintext.
@dignifiedquire can you have a look at my check? I'm not sure if I implemented roughly what you had in mind, or if your idea was entirely different.

was thinking more of length checks, tbh I think it is enough to just keep the "not empty" check, and leave things as they are.


Pass custom parameter to context menu item callback

My context menus are dynamically created and I've been trying to add custom callbacks, passing dynamic data into them in addition to their existing attributes (containerPoint,latlng,layerPoint). Is there any way to do so?

Hi, you could use Function.bind() : https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind, or if not available jQuery.proxy: http://api.jquery.com/jQuery.proxy/
Another alternative is to cache a reference to the marker/path that was clicked as it's available as the relatedTarget property of the contextmenu.show event:  https://github.com/aratcliffe/Leaflet.contextmenu#contextmenushow

Using bind() loses the function context, which will be an issue if you want to do something like change what menu options do based on block input. If you curry the callback instead, then you can add additional inputs without losing the context.
This looks like:
function curriedContextMenu(foo, bar) {
    return function(options) {
        var baz = foo + bar
        var qux = this.getFieldValue('DROPDOWN')
        //actual code goes here
    }
}

Then in your block definition:
customContextMenu: curriedContextMenu(1, 2)


ElasticCache Serverless

We're currently using Cluster mode with Cluster mode ON. And we're using version - 3.24.1
If we want to move to Serverless how the configs will look like for Redisson and which version to use?
We're currently using clusterServersConfig of Redisson.

AWS Serverless mode provides a single hostname resolved to multipe nodes. Use single mode if you want to use a single node of all nodes. Use Proxy mode if you want to use all nodes.


Install Firefox extension from web store

User Story
As a user
I want to be able to view and install the vega browser wallet for Firefox from the Firefox web store
So that I can try out the shiny new Vega browser wallet early and help the team improve it before launch
Acceptance Criteria
I can find the vega wallet browser extension for Firefox in the Firefox web store
I can install the vega wallet browser extension to my Firefox browser
When I have installed the extension I can see a 'Vega' icon in my browsers extension list/bar
Tasks

[ ] Sketch and define content
[ ] Review with stakeholders
[ ] Visual Design
[ ] Implement
[ ] QA Test
[ ] Release

Sketch
Notes
Doesn't require any review
wouldn't be searchable
but could have a page with a button to install
Verification etc.

@dalebennett1992 we believe this is already done so would be great if you can just test and verify and ensure you are happy that there is suitable test coverage for it and it's covered in the specs etc. 🙏


[release-1.18] Fix issue with dual-stack iptables6 rules when using istio-cni plugin

Manual cherrypick required.
#46630 failed to apply on top of branch "release-1.18":
Applying: Dual-stack iptables6 rules based on pod spec redirect
Using index info to reconstruct a base tree...
M	cni/pkg/plugin/iptables_linux.go
M	cni/pkg/plugin/redirect.go
M	tools/istio-iptables/pkg/cmd/root.go
M	tools/istio-iptables/pkg/cmd/root_test.go
M	tools/istio-iptables/pkg/config/config.go
M	tools/istio-iptables/pkg/constants/constants.go
Falling back to patching base and 3-way merge...
Auto-merging tools/istio-iptables/pkg/constants/constants.go
Auto-merging tools/istio-iptables/pkg/config/config.go
Auto-merging tools/istio-iptables/pkg/cmd/root_test.go
CONFLICT (content): Merge conflict in tools/istio-iptables/pkg/cmd/root_test.go
Auto-merging tools/istio-iptables/pkg/cmd/root.go
CONFLICT (content): Merge conflict in tools/istio-iptables/pkg/cmd/root.go
Auto-merging cni/pkg/plugin/redirect.go
Auto-merging cni/pkg/plugin/iptables_linux.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Dual-stack iptables6 rules based on pod spec redirect
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

resolved by https://github.com/istio/istio/pull/47109