Add your first GitHub pull request

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[x] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[x] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[x] My suggested edits are not about an existing topic or collection, or at least not a single one
[x] My suggested edits are not about curating a new topic or collection, or at least not a single one
[x] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

When will this be merged? Why is it pointing at a bot's branch?

Well I’m still conducting how long this get fixed , I’m unable to sign in my Laptop

Pless help me

Format

gh pr checkout 2348

gh pr checkout 2348

Good


feat(frontend): use CoinGecko API to fetch ICRC prices

Motivation
It was suggested to use CoinGecko API for ICRC tokens too. They are not all there, but some are.
Changes

Create derived with enabled ICRC tokens ledger canister IDs.
Create function to fetch ICRC prices from Coingecko (similar to ERC20).
Adjust exchange services and workers to include ICRC tokens.
Adapt derived of exchange store.

Tests
Tested the final returns from the exchange derived by printing the results in console.

Right! I will just wait for PR #1964 to be merged, so that ETH_ADDRESS is EthAddress


[Bug]: Files in submodules cannot be opened on GitHub

Describe the bug
When you setup a submodule in your vault and put a note into it, executing Open file on Github & Open file history on GitHub will fail. Instead of parsing the submodule to get the correct address to built on, the file is assumed to be located in the main repo - which is obviously not the case.
Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)
No response
Steps to reproduce

setup obsidian git with an existing repo and have a full sync cycle done
create a submodule & push it to GH
add a note in said submodule and push it to GH
open the note in obsidian
attempt to execute either Open file on Github or Open file history on GitHub.
Notice that the run URL is pointing at nothing.

Expected Behavior
The plugin should notice if a note is in a submodule, figure out what repository the file is actually located in, get its base path and then assemble the path up to the file from there.
Addition context
No response
Operating system
Windows
Installation Method
None
Plugin version
2.22.0

Unfortunately, I can still reproduce this issue, using version 2.24.3.
Having a submodule data at <root>/assets/data/, containing <root>/assets/data/README.md, and attempting to execute Open file on Github will still run the URL https://github.com/%user-redacted%/%main_repo%/blob/master/assets/data/README.md, instead of https://github.com/%user-redacted%/%submodule_repo%/blob/master/README.md.

The fix is not released yet, but will do so soon.


Removed product_name setting from page_params and repalced with zulip

Fixes #1602
The page_params.product_name have been replaced with "Zulip"

Automated message from Dropbox CLA bot
@jajodiaraghav, it looks like you've already signed the Dropbox CLA. Thanks!

Cool, thanks for working on this @jajodiaraghav!  In general, you don't need to patch the translation files; they're updated automatically by tools anyway.

Can you fix the lint error?

@timabbott I am facing some issue while fixing the lint error. It would be nice if you could help.

That's actually a test failure; you can see it by running test-backend.  The proximal issue is that HomeTest checks the list of things in page_params, and is failing because you changed that list.

@timabbott Is the fix made correct, or is something else required?

@timabbott Can this be merged now?

@jajodiaraghav this fails tests; is that from the S3 outage?
The code looks reasonable, so if it passes tests we can merge.

@timabbott The last check failed due to S3 outage. But on running test-backend, this is what i got:

Rebase your branch -- I think that test was failing on master for about an hour a few weeks ago, and I bet you last rebased onto master then :)

@timabbott Can you help with the Travis error here?

Oops, that's failing on master; just fixed it.  Sorry!

Looking at your change briefly, it doesn't look complete; git grep product_name shows a bunch of stuff (you can ignore the translation stuff, but there's a lot more).

Updated the PR!
Should i remove this as well:
https://github.com/zulip/zulip/blob/master/zerver/views/home.py#L350
I am not very sure about this one.

Nope, that one is needed for a rarely used feature.

I have removed the remaining stuff, except the translation and django.po stuff. Is this complete?

When refactoring, you always need to check your work using git grep; it looks like you missed a few:
(zulip-venv) tabbott@zaset:~/zulip$ git grep product_name | grep -v static/locale
zerver/tests/test_templates.py:            product_name='testing',
zerver/views/home.py:    product_name = "Zulip"
zerver/views/home.py:                                   'product_name': product_name

We already had a discussion regarding zerver/views/home.py. You said

Nope, that one is needed for a rarely used feature.

@jajodiaraghav it looks like you made a mistake rebasing; tests.py was removed a few days ago (split into other files).  Can you fix your branch?

Done

Merged as c17e57421140ca2672dfe8ebe0ec587cf984fb2c, thanks @jajodiaraghav!   Note that I tweaked the commit message to use the imperative case ("Remove", not "Removed").
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/version-control.html#commit-messages


How to dismiss note: you may be able to install openssl using your system-packager?

# swift build
note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

note: you may be able to install openssl using your system-packager:

    apt-get install openssl libssl-dev

Compile Swift Module 'mustuserver' (4 sources)
Linking ./.build/debug/mustuserver

I have already installed openssl and libssl-dev
# sudo apt-get install openssl libssl-dev
Reading package lists... Done
Building dependency tree
Reading state information... Done
libssl-dev is already the newest version (1.0.2g-1ubuntu4.8).
openssl is already the newest version (1.0.2g-1ubuntu4.8).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

It's coming from here: https://github.com/IBM-Swift/OpenSSL/blob/master/Package%40swift-4.swift#L25
Not sure if Swift Package Manager has a way to conditionally display the message.


Set the 'external_log_file' or 'log_dir'  for mesos slaves containers

Set the 'external_log_file' or 'log_dir'  for mesos slaves containers and pass it as a volume.

would prefer to pass USE_SYSLOG so logs can be passed to logstash later


OperationException - 'Internal Server Error', rpc error: No cluster leader

We are using Spring Cloud (Consul) for service discovery and the consul agent service (3 Node deployment) is deployed with other application service (10 Micro Services) on a AWS Stack.
Recently, we have started noticing intermittent RPC Error, which leads to Re-election of leader and following ERROR is raised from Spring Cloud library, and on monitoring we notice that the service discovery is working as expected and new leader is immeditely elected.
So basically, this ERROR is causing noise in our system.
We were thinking on following lines -

Is there a way to only raise this ERROR if the cluster leader is not found by enabling some retry mechanism based on number of tries/ duration ?
Any other ERROR which spring consul library would generate if the consul leader is actually not available ? so that we can suppress this ERROR/ raise it as a WARN.

Please suggest.
ERROR ip-XX-XX-XX-XXX | [pool-3-thread-1] org.springframework.cloud.consul.discovery.ConsulCatalogWatch         Error watching Consu
l CatalogServices
"com.ecwid.consul.v1.OperationException: OperationException(statusCode=500, statusMessage='Internal Server Error', statusContent='rpc error: rpc error: No cl
uster leader')
        at com.ecwid.consul.v1.catalog.CatalogConsulClient.getCatalogServices(CatalogConsulClient.java:122)
        at com.ecwid.consul.v1.catalog.CatalogConsulClient.getCatalogServices(CatalogConsulClient.java:108)
        at com.ecwid.consul.v1.ConsulClient.getCatalogServices(ConsulClient.java:320)
        at org.springframework.cloud.consul.discovery.ConsulCatalogWatch.catalogServicesWatch(ConsulCatalogWatch.java:65)
        at sun.reflect.GeneratedMethodAccessor121.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.scheduling.support.ScheduledMethodRunnable.run(ScheduledMethodRunnable.java:65)
        at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

@gamefundas it's our recommendation to not point consul clients at the server cluster but at a local agent. There is an open issue to reregister if the agent restarts.


[Bug] New messages sometimes not retrieved while idle

Sometimes e-mail delivery is not happening until I manually refresh (pressing L); it happens in idle state only. Yet mails are mostly received in a timely fashion, I cannot make a correlation when nmail doesn't get the signal (of some kind, don't know the details) that new mail has arrived.
Yet I cannot speak of a bug, haven't got any hard evidence. I have this setting on, idle_fetch_flags=1 in case it's related. I'm thinking of changing server_timestamps=0 to 1 to see if it makes any difference.
It seems to happen mostly on my work (Microsoft 365) account. But since I constantly use it, it's not easy to be certain about it; I'll try to leave it idling in the weekend and send test e-mails to check.

Like you, I couldn't really correlate it to anything and so never reported the issue, but my impression is it's a valid one because I do experience it as well, on a work Exchange account and other non-Exchange accounts.
I don't know if it is related or not, but sometimes L cannot fetch anything new, while quitting nmail and relaunching it does, as if this would trigger a "deeper" fetching. Or would put nmail out of idle?
On 2022-10-07 16:12 krackout @.***> wrote:

Sometimes e-mail delivery is not happening until I manually refresh
(pressing L); it happens in idle state only. Yet mails are mostly
received in a timely fashion, I cannot make a correlation when nmail
doesn't get the signal (of some kind, don't know the details) that
new mail has arrived.
Yet I cannot speak of a bug, haven't got any hard evidence. I have
this setting on, idle_fetch_flags=1 in case it's related. I'm
thinking of changing server_timestamps=0 to 1 to see if it makes
any difference.
It seems to happen mostly on my work (Microsoft 365) account. But
since I constantly use it, it's not easy to be certain about it; I'll
try to leave it idling in the weekend and send test e-mails to check.
--
Reply to this email directly or view it on GitHub:
https://github.com/d99kris/nmail/issues/112
You are receiving this because you are subscribed to this thread.
Message ID: @.***>

Yes, nmail supports IMAP IDLE. After no IMAP activity for 15 seconds, nmail fetches message uids and then enters idle. Upon idle notification, nmail fetches message uids and exits idle. After 29 mins in idle state, nmail stops and restarts idle.
I have not encountered any issues relating to this myself, but reviewing the implementation I believe I've found some possible improvements. For example we could fetch message uids at every 29 min idle timeout.
However, I'll need to do some more checking and testing on this before I can prepare a fix.

Plus to the other possible improvements, how about reducing time in idle state to 15-20 minutes?
Or perhaps leave everything as is and implement a refresh at a time interval option, set by configuration.
Στις 8 Οκτωβρίου 2022 12:09:14 μ.μ. EEST, ο/η Kristofer Berggren @.***> έγραψε:

Yes, nmail supports IMAP IDLE. After no IMAP activity for 15 seconds, nmail fetches message uids and then enters idle. Upon idle notification, nmail fetches message uids and exits idle. After 29 mins in idle state, nmail stops and restarts idle.
I have not encountered any issues relating to this myself, but reviewing the implementation I believe I've found some possible improvements. For example we could fetch message uids at every 29 min idle timeout.
However, I'll need to do some more checking and testing on this before I can prepare a fix.

Yep, we can certainly make the timeout configurable.

The above commit adds support for configuring idle timeout with idle_timeout in ~/.nmail/main.conf.
Will keep this issue open until other fixes have been committed.

The above commit implementes more robust detection of new emails while in idle.
Will keep this issue open until a few more related fixes have been committed.

The above commit adds better status reporting during idle.
Will keep this issue open until one more related fix has been committed.

The above fix detects when device is returning from sleep mode, and if in idle mode, ensures we exit idle mode (and indirectly try fetch messages again before re-entering idle).
This is the last idle-related fix for this Github issue.

Just like to add on - while the latest nmail idle functionality has been tested OK with several email service providers, there is one with problems: outlook.com
However, it seems to be a server-side problem according to
https://techcommunity.microsoft.com/t5/outlook/outlook-office-365-imap-idle-is-broken/m-p/3616242
Hopefully Microsoft fixes this soon. As a temporary workaround one can now set idle timeout to some lower value, effectively polling the server for new messages.


Build an LLM caching layer

We need a mechanism to cache identical and similar requests to the LLM. The Python de-facto solution is https://github.com/zilliztech/GPTCache.

Shouldn't the cache layer be as simple as hashing the inputs to the api calls and caching the results that way? GPTCache looks like it's solving for a semantic cache which wouldn't be generally useful for all use cases (i.e. text extraction workflows that might be very semantically similar across queries).

@weilandia Yes, I think that would be a good order to build this out: 1) exact inputs (hashed) as the key and then 2) "fuzzier" cache based on semantic similarity.

Closing this for now as it seems that the LLM providers themselves will be supporting this out of the box.


[sw/silicon_creator] Increase number of RSA keys to 7

This PR adds 4 more fake and fake real RSA keys to match the number of keys we plan to include in the production ROM.
This PR also

replaces the info_page_details() function in the flash_ctrl driver with flash_ctrl_info_page_t structs, saving 498 bytes,
reverts an earlier change in rom.ld and puts ROM text out of the region unlocked at reset, and
updates default values of OTP items that determine key validity.

The change does not affect RTL.
CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl_img_creator_sw_cfg.hjson

CHANGE AUTHORIZED: hw/ip/otp_ctrl/data/otp_ctrl_img_creator_sw_cfg.hjson


Double quotes in strings are not escaped

If a nix string contains double quotes, they are not being escaped in the generated nix expressions; this is an error. It's likely a problem with hnix.

Fixed in current master of hnix


About Model Testing

Hello, could you release the pretrained weights of the coco and visdrone datasets for testing?
I trained and tested the model on the visdrone dataset according to the test process of the coco dataset written in the readme. But i got bad results as shown in the image below.

Hi, is this the result of dense inference or CSQ?


Container availability : '2017-rtm-CZ'

Just tried to pull in the '2017-rtm-CZ' image without success. Seems like the image is not available (yet?), whereas '2017-CZ' (latest = CU13), '2017-cu12-CZ' can be download without any problems?

You are right, the Czech 2017 RTM image is not there. I`ve listed the versions via API, the rest of the images (2017-rtm-??) was generated yesterday.

CZ wasn't included in 2017 RTM as far as i recall.
I think CZ was included a few months after.

Note, btw. that tags are lower case - if the image was there it would be:
docker pull microsoft/dynamics-nav:2017-rtm-cz

Of course, I was trying it using lowercase. So this means that Czech release doesn't have its own RTM?

it would be strange to have the Czech version to be at cu10, based on w1 cu13.
Yes, I could have tagged a specific version of the Czech localization with RTM as well, but my assumption is that people will go for slightly newer versions than RTM at this time.
So the versioning of all images are based on the W1 version and the country localizations will follow.

@freddydk Still not clear why the 2017-cz-rtm docker image is not available.
Checking https://mbs.microsoft.com/customersource/Global/NAV/downloads/product-releases/msdnav2017download, it seems like 2017 CZ is available for download (check the exe version ,the build states 13682 = RTM). The DVD is named 'Dynamics.100.CZ.2087101.DVD'.
Checking https://support.microsoft.com/en-us/help/3210255/released-cumulative-updates-for-microsoft-dynamics-nav-2017 and https://support.microsoft.com/en-us/help/3209071, it seems like NAV 2017 CZ was shipped with CU1 as well (although it is not available as docker image)
Reason why I'm looking for the 2017 CZ RTM version is that we need to upgrade a database to 2017 CZ CU15 and I'm using the docker images to download and extract the init/target text files to compare and upgrade (it's much faster than downloading and installing the DVD).

In 2017 CZ shipped a few months later and the naming might be wrong on the docker image – but the first CZ image was:
microsoft/dynamics-nav:2017-cu2-cz
try to compare that with what you have on the DVD.
/Freddy
Fra: Frédéric Vercaemst<EMAIL_ADDRESS>Sendt: 7. februar 2018 14:51
Til: Microsoft/nav-docker<EMAIL_ADDRESS>Cc: Freddy Kristiansen<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Emne: Re: [Microsoft/nav-docker] Container availability : '2017-rtm-CZ' (#123)
@freddydkhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffreddydk&data=04|01|freddy.kristiansen%40microsoft.com|c5b0193b8d234443093608d56e31cf77|ee3303d7fb734b0c8589bcd847f1c277|1|0|636536082567573127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=CtZMy1yjpaB4k9m727YaxzYs28AxSX2DSB9wn4OCzCc%3D&reserved=0 Still not clear why the 2017-cz-rtm docker image is not available.
Checking https://mbs.microsoft.com/customersource/Global/NAV/downloads/product-releases/msdnav2017downloadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmbs.microsoft.com%2Fcustomersource%2FGlobal%2FNAV%2Fdownloads%2Fproduct-releases%2Fmsdnav2017download&data=04|01|freddy.kristiansen%40microsoft.com|c5b0193b8d234443093608d56e31cf77|ee3303d7fb734b0c8589bcd847f1c277|1|0|636536082567573127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=EREVbySee3oaLe8lhPViQFkKdmXE6%2FULvia66%2F1kFjU%3D&reserved=0, it seems like 2017 CZ is available for download (check the exe version ,the build states 13682 = RTM). The DVD is named 'Dynamics.100.CZ.2087101.DVD'.
Checking https://support.microsoft.com/en-us/help/3210255/released-cumulative-updates-for-microsoft-dynamics-nav-2017https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsupport.microsoft.com%2Fen-us%2Fhelp%2F3210255%2Freleased-cumulative-updates-for-microsoft-dynamics-nav-2017&data=04|01|freddy.kristiansen%40microsoft.com|c5b0193b8d234443093608d56e31cf77|ee3303d7fb734b0c8589bcd847f1c277|1|0|636536082567573127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=mNKYylTl3MjNh8tizIjJDDJyCBbuiQfqrYN56uc0s%2FU%3D&reserved=0 and https://support.microsoft.com/en-us/help/3209071https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsupport.microsoft.com%2Fen-us%2Fhelp%2F3209071&data=04|01|freddy.kristiansen%40microsoft.com|c5b0193b8d234443093608d56e31cf77|ee3303d7fb734b0c8589bcd847f1c277|1|0|636536082567573127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=%2Fp58Wo51KcR%2Fcfz1YYbwIQMwEnl%2FXws13vt6WDGwTnE%3D&reserved=0, it seems like NAV 2017 CZ was shipped with CU1 as well (although it is not available as docker image)
Reason why I'm looking for the 2017 CZ RTM version is that we need to upgrade a database to 2017 CZ CU15 and I'm using the docker images to download and extract the init/target text files to compare and upgrade (it's much faster than downloading and installing the DVD).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fnav-docker%2Fissues%2F123%23issuecomment-363774472&data=04|01|freddy.kristiansen%40microsoft.com|c5b0193b8d234443093608d56e31cf77|ee3303d7fb734b0c8589bcd847f1c277|1|0|636536082567573127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=Dl08P8G18Jy%2FGgt0DC96wJ%2FZIoJo2MZ2H378VGu7xj4%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKRqA1sW22ZqKorwH8nL4kfMZhwASMN_ks5tSaojgaJpZM4Q0dSb&data=04|01|freddy.kristiansen%40microsoft.com|c5b0193b8d234443093608d56e31cf77|ee3303d7fb734b0c8589bcd847f1c277|1|0|636536082567573127|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D|-1&sdata=0ReuEKtkxOQvMxeFDyTVpnY0wl1lBJmFyKw6uSUjQpw%3D&reserved=0.

Table 18 - 2017_CU0_CZ (DVD) extract
OBJECT Table 18 Customer
{
OBJECT-PROPERTIES
{
Date=25/10/16;
Time=12:00:00;
Version List=NAVW110.00,NAVCZ10.00;
}
Table 18 - 2017_CU2_CZ (Docker) extract
OBJECT Table 18 Customer
{
OBJECT-PROPERTIES
{
Date=23/01/17;
Time=12:00:00;
Version List=NAVW<IP_ADDRESS>52,NAVCZ<IP_ADDRESS>52;
}
Both versions contain code differences, translation differences, ... as well.


fix malformed JSON

Please, next time add a way to lint your JSON file (such as https://github.com/zaach/jsonlint) before commit it!

Thanks!


Fix assigning an email address that does not belong to an existing user to draft order

I want to merge this change because it fixes bug that does not allow assigning not existing email addresses to draft orders.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-7832 Cannot unassign a user from an order


Dockerfile shouldn't be run with ROOT permissions

When using the default Dockerfile, we get errors when using bower package manager:

ERROR org.ossreviewtoolkit.analyzer.PackageManager - Resolving dependencies for 'bower.json' failed with: IOException: Running 'bower install' in '/input/project/...' failed with exit code 1:
bower ESUDO         Cannot be run with sudo
Additional error details:
Since bower is a user command, there is no need to execute it with superuser permissions.
If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs.
http://www.joyent.com/blog/installing-node-and-npm
https://gist.github.com/isaacs/579814
You can however run a command with sudo using "--allow-root" option

This issue will also appear in the reports later on, so it's a problem.
We could either add an option to run bower commands with --allow-root as suggested in the error message or add a user to the official Dockerfile and run without root permissions. This would be the cleaner solution in my opinion.
So the real question is whether there is something in the Dockerfile which inherently requires sudo permissions while running.

So the real question is whether there is something in the Dockerfile which inherently requires sudo permissions while running.

I'm not aware of anything. We just run as root as that's Docker's default.

Maybe we should run https://github.com/hadolint/hadolint - which is a Docker best practices linter -  over our DockerFile using the https://github.com/marketplace/actions/hadolint-action.
We could also look at implementing the recommendations in https://cheatsheetseries.owasp.org/cheatsheets/Docker_Security_Cheat_Sheet.html - include steps how to use an unprivileged user

Also see my comment here: https://github.com/oss-review-toolkit/ort/pull/4103#issuecomment-854137392

Maybe we should run https://github.com/hadolint/hadolint - which is a Docker best practices linter - over our DockerFile using the https://github.com/marketplace/actions/hadolint-action.

I gave hadolint a try, and I'm not convinced of the tool. I was immediately running into multiple issues [1] [2] [3].

add a user to the official Dockerfile and run without root permissions. This would be the cleaner solution in my opinion.

As of https://github.com/oss-review-toolkit/ort/pull/5031 funTests are run as non-root in Docker to ensure everything works without being root.


Remove CodeNinjas section

I would remove this section until we have something from Code Ninjas to put here.  Also, I would move it to the bottom of the page, so we're putting our own Microsoft activities first (or alternately make it seem like more part of the Educator section)

@kiki-lee I made the above changes, but adding you here so you could keep track of delivering these assets. Once we have those I will add them in.

Great. We can close for now and I'll do a new ticket if we need one when the activation goes live.


Profile name conflicts with concept of passing addition oc cluster up options.

In function up() have:
function up {
  local _profile="$1"
  echo "$_profile"

  if [ "$_profile" == "" ]
  then
     echo "Using default profile"
     _profile="default"
  fi

  ...

  shift # Remove profile name

This is going to conflict with idea that one can pass additional options through to oc cluster up. That is $@ in:
  oc cluster up --public-hostname <IP_ADDRESS> \
                --host-data-dir $OPENSHIFT_HOST_DATA_DIR \
                --host-config-dir $OPENSHIFT_HOST_CONFIG_DIR \
                --use-existing-config \
                "$@"

The usage actually says:
oc-cluster up [profile] [OPTIONS]

which generally indicates that profile is optional.
If some were to say:
oc-cluster up --loglevel 9

then the profile name will be taken to be --loglevel and 9 passed through as sole argument to oc cluster up after default options.
So bit more sophisticated process required for options if going to allow additional options to be passed through.
Maybe that if supplied first argument starts with - that don't interpret as profile name, use default and not shift arguments.

True. Yes I'll check that if not starts with dash is a profile. As I said
this was a fast a dirty script. To be honest nor site that I'll ever pass
arguments. But good point.
El 23 sept. 2016 3:35, "Graham Dumpleton"<EMAIL_ADDRESS>escribió:

In function up() have:
function up {
local _profile="$1"
echo "$_profile"
if [ "$_profile" == "" ]
then
echo "Using default profile"
_profile="default"
fi
...
shift # Remove profile name
This is going to conflict with idea that one can pass additional options
through to oc cluster up. That is $@ in:
oc cluster up --public-hostname <IP_ADDRESS>
--host-data-dir $OPENSHIFT_HOST_DATA_DIR
--host-config-dir $OPENSHIFT_HOST_CONFIG_DIR
--use-existing-config
"$@"
The usage actually says:
oc-cluster up [profile] [OPTIONS]
which generally indicates that profile is optional.
If some were to say:
oc-cluster up --loglevel 9
then the profile name will be taken to be --loglevel and 9 passed through
as sole argument to oc cluster up after default options.
So bit more sophisticated process required for options if going to allow
additional options to be passed through.
Maybe that if supplied first argument starts with - that don't interpret
as profile name, use default and not shift arguments.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jorgemoralespou/oc-cluster-wrapper/issues/1, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEyDoYIit5wXx3sy4TYyIV0_UjYs2guks5qsyzDgaJpZM4KEhoX
.


Xeno (and maybe marine) Tackle Prediction failing when dragging

Description
As a Runner, was dragging multiple targets and even after the prompt and image plays of you tackling the target, they can still sometimes get up like you weren't tackling. This only seemed to occur when I was a runner, and both recordings show this happening twice in a single life. I have noticed that the amount of tackles I have to perform are incredibly inconsistent at times.
My only guess is that I am running the server at 9/15 predicted ticks. The client sees that I tackle and that I was supposed to be in range since I was grabbing a target so all is good. But the server does not agree and makes the target not be tackled while being dragged at fast speeds.
Reproduction
Be a Runner (Usually, details in Discord Bug Report shows this as well as a Queen with a slower speed)
Drag a target
Move the victim in a (usually) single direction at fastest speed
Tackle a target multiple times
Watch as the target is able to stand up and other clients hear tackle sounds, but no animation image or text appears.
Screenshots
LINK TO BUG POST IN DISCORD, NO NEED TO DOWNLOAD THE MP4s
https://discord.com/channels/1168210010233376858/1290998095647342632/1290998095647342632
https://cdn.discordapp.com/attachments/1290998095647342632/1290998099791052860/Rouny_Not_Tackle_1.mp4?ex=66ff27ec&is=66fdd66c&hm=0784f59a618362f184d6a25c70116030a498dd993a169aed980f26b9ae6cdcf4&

Video shows first instance of a failed grabbing after downing and tackling a downed marine multiple times.

https://cdn.discordapp.com/attachments/1290998095647342632/1290998102638985216/Rouny_Not_Tackle_2.mp4?ex=66ff27ed&is=66fdd66d&hm=4b3b96d11e726d57df922c4985cad8c032c45e41740fc9372ccecf3fdddf7f2b&

Video shows a second instance, tackling a marine multiple times which they were able to stand up on. Also shows a weird prediction tackle with the client stopping, then teleporting past a marine due to a failed pounce.

https://github.com/user-attachments/assets/ca879f9c-498f-480b-ad5c-634c1a6d0a92

Video of the first instance, but shown on the replay side. It can be heard that the first tackle failed to connect, but 4 other ones did, after a successful downing after a second pounce, the marine was then dragged away. While tackling, the marine was able to get back up as if they were not being tackled, while tackling sounds were heard, but no message or animation image.

Additional context
I run my client at 9 predicted ticks. I have an image of my client info below as this could be useful.

This is just when moving in general, not specifically dragging

more cases
https://github.com/user-attachments/assets/ce6c6a73-05db-49cd-9b7e-0fa017ba4a2b
https://github.com/user-attachments/assets/92e390bc-2b66-45d4-ac26-f5b58996c73b


remove multiple instances of the same resource type

Reference file can only have 1 resource type of each kind

Hey @hiltol, did you get an error about this?

Hey @hiltol, did you get an error about this?

Yes, it's the cause of the warnings in https://github.ibm.com/cloud-finops/issues/issues/235


Error when compiling VueJs application with Webpack and UglifyJs 1.10.2

hello, I am building my VueJs based app with webpack. It uses underscorejs too
I am experiencing this error

can someone help me, please?
underscorejs version is 1.10.2

It's impossible to tell from just the screenshot. "chunk" is read-only seems to suggest that something is trying to overwrite the chunk function.
I'm willing to take a look. Could you share your code, or otherwise create a reduced testcase and share that?

Closing this as 30 days passed without a response. @matteocacciola please feel free to reopen or comment if you want to take up on this again.


op::Dot behaviour similar to numpy.matmul

Hi All,
We have to implement MatMul operator in ONNX according to its standard which states that MatMul should behave similar to numpy.matmul.
In order to achieve this we have tried to use op::Dot, however currently it seems to be not possible straightforward. Please let us know whether and when would you be able to add such functionality to op::Dot operator, since lack of this feature is blocking us from further development.
Let me know describe for you the numpy.matmul behavior with some examples:
a
>>> array([[[ 0,  1,  2,  3],
            [ 4,  5,  6,  7]],

           [[ 8,  9, 10, 11],
            [12, 13, 14, 15]]])

a.shape
>>> (2, 2, 4)

b
>>> array([[[ 0,  1],
            [ 2,  3],
            [ 4,  5],
            [ 6,  7]],

           [[ 8,  9],
            [10, 11],
            [12, 13],
            [14, 15]]])

b.shape
>>> (2, 4, 2)

According to numpy.matmul documentation, there are two important statements:

If either argument is N-D, N > 2, it is treated as a stack of matrices residing in the last two indexes and broadcast accordingly.

and:

Stacks of matrices are broadcast together as if the matrices were elements.

Thus considering we have tensors a and b previously defined numpy.matmul generates following output:
c = np.matmul(a,b)
c
>>> array([[[ 28,  34],
            [ 76,  98]],

           [[428, 466],
            [604, 658]]])

c.shape
>>> (2, 2, 2)

Now if we dive into details of how it works we see that, each element is a dot product of specified axes:
c[0,1,1]
>>> 98
np.dot(a[0, 1, :], b[0, :, 1])
>>> 98

So the last two dimensions are treated as a conventional 2D matrices and multiplied together. This of course enforces that the last two dimensions of each tensor have to have compatible dimensions enabling matrix multiplications.
The remaining dimensions define stack of matrices which tell us, how many times we have to repeat the 2D matrix multiplication.  Now numpy enables broadcasting of that remaining dimensions if they are compatible. The best description I could found is:

To determine if two shapes are compatible, Numpy compares their dimensions, starting with the trailing ones and working its way backwards (For the shape (4, 3, 2) the trailing dimension is 2, and working from 2 "backwards" produces: 2, then 3, then 4.). If two dimensions are equal, or if one of them equals 1, the comparison continues. Otherwise, you'll see a ValueError raised (saying something like "operands could not be broadcast together with shapes ...").
When one of the shapes runs out of dimensions (because it has less dimensions than the other shape), Numpy will use 1 in the comparison process until the other shape's dimensions run out as well.
Once Numpy determines that two shapes are compatible, the shape of the result is simply the maximum of the two shapes' sizes in each dimension.

Consider following examples:
a = np.array(...) # a 3D array
a.shape
>>> (2, 2, 4)
d = np.array(...) # a 4D array
d.shape
>>> (1, 2, 4, 2)
e =  np.matmul(a,d)
e.shape
>>> (1, 2, 2, 2)

In above example numpy broadcasted a matrix along the 1-st dimension of  d matrix.
k  = np.array(...) # a 4D array
k.shape
>>> (2, 3, 2, 2)
m = np.array(...) # a 4D array
m.shape
>>> (2, 1, 2, 4)

n = np.matmul(k,m)
n.shape
>>> (2, 3, 2, 4)

Resolved.


Add Linux support

The current project is a Visual Studio windows project. This is not friendly for Linux users.

Good Job Ben

k thx


Programmatically selecting countries with geo and map series

What problem does this feature solve?
Possibility to have preselected countries when user has different series and need a geo coord system
e.g.
setOption{
geo: {...},
Series: [ {
name: 'UD',
geoIndex: 0,
data: [ { name : 'Spain', selected : true}] ...
}...]
What does the proposed API look like?
Simple allow "selected" on series
data[n] =  {...values, selected : true}

Do you mean that we provide the preselected countries geodata?

I will try to explain.
The functionality would be to allow to select and deselect countries modifying the underlaying data.
In the case you have a "normal" map series e.g
Series: [ {
name: 'UD',
type: 'map',
map: 'world',
data: [ { name : 'Spain', selected : true}]
}]
The map would load with a country selected, in this case, Spain.
But, if we have a series that references a geoIndex, echarts does not use the selected parameters and does not "pre-select" Spain
geo: {
map: 'world',
roam: true,
...},
Series: [
{
geoIndex: 0,
data: [ { name : 'Spain', selected : true}]
}
Btw if geoIndex is used there isn't any way of selecting a country programmatically, "mapSelect" action doesn't work and "highlight" action works but "deselects" once resize() is called (kind of useless imo)
So at least this would allow to re-merge the data with selected so the map can be controlled apart from the end user "clicking" on the map.
Hope that I have explained myself.
Thank you.


Cannot open an item in Zotero properly

Hello, I don't know what happened with the workflow after I switched to Alfred 5. Every time I try to type enter or fn + enter after searching in Zothero, it just fails to open the item selected in Zotero. And something quite strange would happen, when I try to switch to another app at this time, the Zotero would always jumps to the front. (As you can see in the video)

And here is the debug info:
Debug info of ZotHero.txt
Thank you so much!

consolidating with the other issue


⚠ ClamAV has degraded performance

In 0c6e0be, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in f0e807e after 5 minutes.


Ignoring Regions with {% # @prettify-ignore-start %} not working

In my testings {% # @prettify-ignore-start %} / {% # @prettify-ignore-end %} did not work, whereas <!-- @prettify-ignore-start --> / <!-- @prettify-ignore-end --> and other available methods seem to work properly.
That being said, I'm also not able to comment anything else on separate lines ; because snippets of code to exclude usually have somethings to be said about, or some kind of explanation about why it's excluded:
{% comment %}
   @prettify-ignore-start
   Bla bla bla...
{% endcomment %}

Making some noise of this one @MaxDesignFR will you be available sometime soon? Need some help in test cases and the groundwork you've done so far has been a tremendous help.
I will be patching this this evening and can shoot you over a build.


:bug: readthedocs build is failing

readthedocs log:
        × Building wheel for mpi4py (pyproject.toml) did not run successfully.
        │ exit code: 1
        ╰─> [228 lines of output]

        ...

            --------------------------------------------------------------------------
            The Open MPI wrapper compiler was unable to find the specified compiler
            x86_64-conda-linux-gnu-cc in your PATH.

            Note that this compiler was either specified at configure time or in
            one of several possible environment variables.
            --------------------------------------------------------------------------
            failure.

        ...

The same issue happens for pyiron_module_template, which only has the dependency pyiron_base, so the problem is not with the actual source code. The pyiron_base docs themselves, however, are passing, so there must still be a repo-specific problem here. I suspect I can config my way out of this problem.

pyiron_base uses:
pip install versioneer[toml]==0.29
pip install . --no-deps --no-build-isolation

the --no-build-isolation part is important to prevent pip from building all dependencies.

I am failing before the pip install

The versioneer[toml] and build dependency made it into the docs check as a part of the pyiron/actions upgrades, but I failed to propagate it to .readthedocs.yml throughout.

It is still running python -m pip install --upgrade --upgrade-strategy only-if-needed --no-cache-dir . instead of pip install versioneer[toml]==0.29; pip install . --no-deps --no-build-isolation, my guess is that the trailing python: install: section of my yml is overriding the pre-build job.


[core] Add pigment and base ui scopes to envinfo

See https://github.com/mui/material-ui/pull/41942#discussion_r1684519580. This will help support ticket for Base UI, Pigment CSS and downstream dependents.
Aside: Any reason why @base_ui scope is with an underscore? Feels a bit unusual for npm package naming and different to what we've been doing before with no obvious benefit. I personally find it to work particularly badly with underlines in urls (github, npm, docs,...)

Any reason why @base_ui scope is with an underscore?

We couldn't get the organization name yet. Used by https://www.npmjs.com/~base-ui?activeTab=packages right now. We haven't heard form GitHub yet.
Marija had a contact at GitHub who told us

If they have a trademark for the name they will be able to get a much faster response and higher likelihood of a positive outcome. They can fill out our trademark form to start the process.

@colmtuite If a trademark application cost $250 and it means that we won't need to change npm package name down the line. This seems like a no brainer. Now, we need a final logo to do this.

@oliviertassinari I'll send a logo internally today so we can begin a trademark process.

@colmtuite A new task to track/coordinate this: https://www.notion.so/mui-org/label-Trademark-Base-UI-88f653d8a8b64cac96fa7546638ecc3d.


Modal Directive uses unsafe-eval in showBackdrop function

Versions:

ng2-boostrap 1.1.16
angular 2.0.2

I am doing AOT compilation using ngc & rollup to create bundle.
My application is running in a CSP environment that does not allow using eval (or new Function() for that matter)
Builds fine, but I get a runtime error when I try to show modal:

offending line of code can be found here: https://github.com/valor-software/ng2-bootstrap/blob/development/components/utils/utils.class.ts#L5

Perhaps I am misunderstanding but the function (reflow) appears to be doing nothing.


[BUG] Godwoken incorrectly estimates gas limit

Version

Godwoken mainnet v1.1

Describe the bug
Sending transaction without manually set gas limit may fail due to gas limit. This mostly happens when transaction takes more than around 1 million gas limit.
While locally testing contract I noticed that sometimes sending transaction using ethers returns transaction hash (which means ethers has validated transaction and has estimated gas limit) but node returns error with message that transaction failed.
Expected behavior
After ethers locally validates transaction it should also be valid when it's sent to node. Manually changing gas limit shouldn't be required.
Logs
Failed transaction: https://gwscan.com/tx/0x86a575206f2ee718aa2614dee59f9fd2c5250016465ea6c2c81cb6443750bb19
Succeed transaction with same data but manually set gas limit to 2 million: https://gwscan.com/tx/0x5cb4432fe3ca63eb3ce3d2485b1162a449df24d0a4f5db554eabe5ee5079a626

While locally testing contract I noticed that sometimes sending transaction using ethers returns transaction hash (which means ethers has validated transaction and has estimated gas limit) but node returns error with message that transaction failed.

did you mean testing the contract locally on hardhat network? or on godwoken-kicker network? just want to confirm this. if it is on hardhat network, this might be related to our evm model to estimate gas

By locally I meant I ran scripts on local machine to mainnet

@maciej-kozuszek Hi, I'm still looking into this issue. I may need your help.
I found something interesting. For the failed tx, the out of gas error happened when calling the contract from 0x8f7d6428252a9efeb466780ca6c3a368ca1aef0a. I cannot access the source code. But I can read the bytecode of the contract. There are some GASs used in this contract. Looks like the contract routes to different parts based on the current gas left. What I'm trying to say is that the code paths of two transactions(failed and succeed) could be different. Can you please help me check the code? Especially for the last time when calling the contract of 0x8f7d6428252a9efeb466780ca6c3a368ca1aef0a. This should be related to gasleft() or msg.gas.

My contract doesn't have any conditional branching based on gas left but it's calling aave ledning pool flash loan at address you listed: 0x8f7d6428252a9efeb466780ca6c3a368ca1aef0a
This contract (here is ethereum mainnet: https://github.com/aave/protocol-v2/blob/master/contracts/protocol/lendingpool/LendingPool.sol) deployed on godwoken at address: https://gwscan.com/account/0x8f7d6428252a9efeb466780ca6c3a368ca1aef0a?search=0x8f7d6428252a9efeb466780ca6c3a368ca1aef0a
I was looking through contract but couldn't find any calls to gasleft() or msg.gas.

OK. I can confirm this is a bug. I'm sorry I led you in the wrong way. :cry:  The current implementation of opcode GAS doesn't use gas left. Somehow it uses slightly less than the gas left.
For example, suppose we are going to make a call to some contract, and the gas left is 10000. This call should use 10000 as the gas limit. But it turns out the gas limit is ~9000.
In your case, the estimated gas was right. The last call needed ~1300 gas, I guess only ~300 was set as the gas limit for the call, which is not enough for sure. Then we got a failed tx.
I guess a quick fix is adding more extra gas in the web3 layer. 2000 more should be good. @Flouse

ok.
@Simon-Tl
Please tune EXTRA_ESTIMATE_GAS env variable of Godwoken testnet_v1 and mainnet_v1 when you have a moment.

https://github.com/godwokenrises/godwoken-info/blob/main/mainnet_v1/web3.env#L22-L23

Memo
https://v1.testnet.gwscan.com/tx/0x9e3808a0c63907803ae1587fd6cac882e882d80cdcb1514b4ebfc6ac01fde7d4
Similar situation reported by a community developer.
cc @magicalne @jjyr


Generate vanity public keys with rage-keygen

This adds a --vanity command line flag to rage-keygen which takes a regex to filter for matches in a brute-force parallelized search of the space of public keys. This is only enabled if the vanity feature is enabled when building the package.
I don't know whether this functionality should actually be merged into upstream rage-keygen and I don't feel strongly about it, but I've made a PR tracking the work so that it doesn't get lost, in case it's of interest.

I agree that this is better suited to a standalone tool. It's not something I want to expose as an option in the main tool, because users should not be relying on the existence of vanity prefixes for checking recipient validity, or expecting others to do so.


GPL-597 Which of Ubuntu 10.04(physical) 12.04 VMs) can be decomissioned (& upgrade the rest)

Description
GPL-597  Decommission a sub set of the following servers so only the ones that are required get upgraded to avoid wasting cognitive effort and power.
 Needs to be decision from team based on current state of the FCE for production

[ ] Once agreed what can be turned off please update Incident Service Request 272892  (Pete Juhas {CMI: MCID1164370} )

Additional context or information
See GPL-592 [Research] Move pmb into psd-deployment and FCE #53
We should aim to turn off the physical machines  in line with strategy for 2020 (accepting heron): https://ssg-confluence.internal.sanger.ac.uk/x/hoEKBg 3.4 section 'Services marked for deprecation' (note only a & b mentioned)

Results of research can be found at [(https://ssg-confluence.internal.sanger.ac.uk/display/PSD/GPL-597+-+decomissioning+old+servers)]


Develop

Changed

Moved named_parameters and parameters from class methods to independent functions.

Added

torch-pruning pruners for SPLoRA.
SPLoRAMultiheadAttention.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1f691ca). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage        ?   83.21%
=======================================
  Files           ?        7
  Lines           ?      542
  Branches        ?        0
=======================================
  Hits            ?      451
  Misses          ?       91
  Partials        ?        0

Flag
Coverage Δ

unittests
83.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


initctl

initctl restart UserIdentityBackend
initctl: Rejected send message, 1 matched rules; type="method_call", sender=":1.4" (uid=501 pid=29969 comm="initctl restart UserIdentityBackend ") interface="com.ubuntu.Upstart0_6.Job" member="Restart" error name="(unset)" requested_reply="0" destination="com.ubuntu.Upstart" (uid=0 pid=1 comm="/sbin/init ")

The provisioning should handle such situations :)

Doesn't this happen because the app was started manually by someone not using the restart script on the ec2-user?

It probably happens because it find wrong PID or PID/user combinantion

correct. Initctl can't control UserIdentityBackend if it didn't start it and has the PID

pids=$(pgrep )
will get you the pids of all processes with the given name.


Bei's initial timing improvements

Validation: https://www.classe.cornell.edu/~mgr85/www/SegmentLinking_keep/baselinePlots/PU200_bei/
Bei's timing improvements include inline funcitons and using fastmath


subscribed returns true after subscription trail expiration

The subscribed method checks if the subscription is valid
https://github.com/laravel/cashier/blob/7.0/src/Billable.php#L187,
but the valid method returns true even after the trail expiration, because the active method returns true because we don't set ends_at on the subscription for trails.
https://github.com/laravel/cashier/blob/7.0/src/Subscription.php#L70-L83
one possible solution I can think of is to set ends_at along with trial_ends_at, or add another check for expired trails.

So the way this works is that the ends_at is meant to denounce at which point the subscription is cancelled. As long as it's null it's a subscription that's active and ongoing. The subscribed method just checks if a user has an active subscription which still will return true even after the trial has expired. If you want to check wether the user is past their trial period you should use $user->subscription('main')->onTrial().
So basically this is intended behavior.
https://laravel.com/docs/5.7/billing#subscription-trials


chore(ci): always build docs

Description
Problem*
Resolves
Summary*
This PR splits building and deploying a preview of the docs. This should enforce that docs are always ready to be published without generating a large number of unnecessary deploys.
Additional Context
Documentation*
Check one:

[x] No documentation needed.
[ ] Documentation included in this PR.
[ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray Could you add this new build step as a required check? We should ensure that the docs always build.


Consider better use of ProjectedVolumes

Feature request
ProjectedVolumes is very useful, both for Secrets, ConfigMaps and modern ServiceAccounts. The way Tekton currently supports ServiceAccounts should be considered outdated - since the tokens are not rotated and less secure than the new solution, Service Account Token Volume Projection using ProjectedVolumes.
Use case
At least ServiceAccounts should preferrably be used from a ProjectedVolume. Currently this is a bit clumsy - through the taskRunSpecs. We could consider a better API - potentially via Workspaces?
Also see No More Forever Tokens: Changes in Identity Management for Kubernetes.
Some of these APIs will be upgraded (possibly to GA?) in v1.20

/remove-lifecycle stale

/remove-lifecycle rotten
in v1 planning - https://github.com/tektoncd/pipeline/issues/3548

/lifecycle frozen
(as it's part of v1 planning)


Ability to Configure Editor without compiling everything

Motivation
Currently in order to modify the rich text editor, you need to have the entire solution and build it, and it compiles into a minified .js file.  It's near impossible to do small adjustments for clients with this, and very hard to also package this into a nuget package.
Proposed solution
Move configuration into a .js that isn't compiled and can be added to solutions and modified without requiring rebuilding.

Thank you for the suggestion, I agree that it's painful to proceed the whole process because of the small adjustment. We plan to introduce a model of Froala rich text editor customization as well as introducing components as NuGet packages which could help a bit. @KenticoDevTrev, could you please name kinds of the adjustments you typically do?

Biggest adjustment is the tools available on the toolbar, portal had the different profiles that we could set for the user, that covered the majority of what we did (usually using full or basic most times).
Making an API or method that generates the froala initialization options json would probably do the trick, then allow us to modify those profiles (even just modifying the json itself would work).

I've got good news for you. In the current iteration we're implementing a support for adjustments of the Rich text editor. Once done, you'll be able to define custom toolbar and customize other Froala's options.

Awesome!!! I'll tell the team, they will be super excited!
On Wed, Nov 20, 2019, 7:29 AM Ondřej Machala<EMAIL_ADDRESS>wrote:

I've got good news for you. In the current iteration we're implementing a
support for adjustments of the Rich text editor. Once done, you'll be able
to define custom toolbar and customize other Froala's options.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Kentico/ems-mvc-components/issues/38?email_source=notifications&email_token=ALIDDU4TRPX2KAPCZRHBIDDQUU3SPA5CNFSM4I6XH4JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEER7BSA#issuecomment-556003528,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALIDDU45KHPS6XRZRRQ4XJTQUU3SPANCNFSM4I6XH4JA
.

@petrinecp  I saw it was merged in, is there any documentation on how to leverage the new adjustments? :)

Hi @KenticoDevTrev, the documentation will soon be available on the repo's wiki page, however we're also finishing the support for custom plugins and there will be a minor change in the current location of the configurations so bear with us. :)

Hi @KenticoDevTrev, the implementation of the Editor customization is finished. You can find the documentation here.
Could you please check that it covered all your needs?
P.S.: We are just finishing a release of the Rich Text Editor via a NuGet package :)

Perfect, this will do nicely and cover the vast majority of used, please
get this into a nuget package as soon as you can and we will start
incorporating it!!
On Mon, Dec 16, 2019, 3:54 AM Radek Pribyl<EMAIL_ADDRESS>wrote:

Hi @KenticoDevTrev https://github.com/KenticoDevTrev, the
implementation of the Editor customization is finished. You can find the
documentation here
https://github.com/Kentico/ems-mvc-components/wiki/Customizing-the-Rich-text-editor-toolbar
.
Could you please check that it covered all your needs?
P.S.: We are just finishing a release of the Rich Text Editor via a NuGet
package :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Kentico/ems-mvc-components/issues/38?email_source=notifications&email_token=ALIDDU4AVP34GOD5QZKROLDQY5F6LA5CNFSM4I6XH4JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG6EQSI#issuecomment-565987401,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALIDDU2APPM3LV5ZBGHZLALQY5F6LANCNFSM4I6XH4JA
.

Could you add a link to the documentation on the readme (in case people don't realize the wiki is there) and also add the missing @using statement for the instructions on adding as a inline editor for your widgets?
@using Kentico.PageBuilder.Web.Mvc
@using Kentico.Components.Web.Mvc.InlineEditors

@{Html.Kentico().RichTextEditor("Content", "simple");}

Thank you for the suggestions, all done now :)


RuntimeError: cannot schedule new futures after interpreter shutdown

Reverting to boto3 1.17.53, which is the last version using s3transfer<0.4 solves the issue.
The calls to upload_fileobj and download_fileobj are performed within a thread via asyncio's run_in_executor.
Traceback (most recent call last):
...
    s3.download_fileobj(self.bucket_name, key, fp)
  File "/venv/lib/python3.8/site-packages/boto3/s3/inject.py", line 678, in download_fileobj
    return future.result()
  File "/venv/lib/python3.8/site-packages/s3transfer/futures.py", line 106, in result
    return self._coordinator.result()
  File "/venv/lib/python3.8/site-packages/s3transfer/futures.py", line 265, in result
    raise self._exception
  File "/venv/lib/python3.8/site-packages/s3transfer/tasks.py", line 255, in _main
    self._submit(transfer_future=transfer_future, **kwargs)
  File "/venv/lib/python3.8/site-packages/s3transfer/download.py", line 355, in _submit
    self._submit_download_request(
  File "/venv/lib/python3.8/site-packages/s3transfer/download.py", line 384, in _submit_download_request
    self._transfer_coordinator.submit(
  File "/venv/lib/python3.8/site-packages/s3transfer/futures.py", line 320, in submit
    future = executor.submit(task, tag=tag)
  File "/venv/lib/python3.8/site-packages/s3transfer/futures.py", line 467, in submit
    future = ExecutorFuture(self._executor.submit(task))
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 181, in submit
    raise RuntimeError('cannot schedule new futures after '
RuntimeError: cannot schedule new futures after interpreter shutdown

Traceback (most recent call last):
...
    s3.upload_fileobj(io.BytesIO(data), self.bucket_name, key)
  File "/venv/lib/python3.8/site-packages/boto3/s3/inject.py", line 536, in upload_fileobj
    future = manager.upload(
  File "/venv/lib/python3.8/site-packages/s3transfer/manager.py", line 326, in upload
    return self._submit_transfer(
  File "/venv/lib/python3.8/site-packages/s3transfer/manager.py", line 500, in _submit_transfer
    self._submission_executor.submit(
  File "/venv/lib/python3.8/site-packages/s3transfer/futures.py", line 467, in submit
    future = ExecutorFuture(self._executor.submit(task))
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 181, in submit
    raise RuntimeError('cannot schedule new futures after '
RuntimeError: cannot schedule new futures after interpreter shutdown

Actually, reverting to an earlier Boto3 version didn't solve the problem. (It was verified using pip freeze that s3transfer was in the 3.x version range.) It did start working when I disabled threading on the s3 operations using TransferConfig().


New version: ConstrainedSystems v0.3.5

Registering package: ConstrainedSystems
Repository: https://github.com/JuliaIBPM/ConstrainedSystems.jl
Created by: @jdeldre
Version: v0.3.5
Commit: c1697ba95aaf5dfc9c8fe8e146e7a09f593c6ec9
Reviewed by: @jdeldre
Reference: https://github.com/JuliaIBPM/ConstrainedSystems.jl/commit/c1697ba95aaf5dfc9c8fe8e146e7a09f593c6ec9#commitcomment-127897863
Description: Tools for solving constrained dynamical systems

pause for now


fix(notification/windows): Grant permission without invoking backend

fixes #1254 until we use webview2's permission apis which i'd wait for until we dropped win 7 support so we don't have to worry about 2 implementations.

I'm excited for this fix


Present A0WebViewAuthenticator from selected parent view controller

Instead of relying on A0ModalPresenter to provide top view controller as parent when call to authenticate, it would be nice if is able to provide a custom parent view controller. This will give additional flexibility and will provide more customization options.

We are considering this for v2


how to make changes to the EDI Hackathon code

Please follow these steps when making changes to the EDI Hackathon code moving forward:
(1) Make sure your master is up-to-date by using "git pull master".
(2) Check that you have the development branch using "git branch", which will list all the branches you can modify (the current branch you are working on will have a little star in front of it). If you don't see the development branch listed run "git fetch" (this allows you to see the current state of the project without merging your version and the latest version, if they are different) and then "git branch" again. If you already have a the development branch, go to step 3.
(3) Switch to the development branch by running "git checkout development". You can check that you switched to it by running "git branch" again and you're development branch should be starred (rather than the master).
(4) Once switching to the development branch, make sure it's up-to-date by running "git pull".
(5) Create and switch to your new personal development branch so you can start working on the issues assigned to you. To do this.  run "git checkout -b sheila-development". Please change "sheila" to your name. ;) Alternatively, if you are working on a specific issue, you can also use that issue as the name, which has the added benefit of highlighting to others that you are working on that problem.
(6) Make your additions and commits as you normally would (just now you're on your personal branch).
(7) Push your new branch to GitHub using "git push -u origin sheila-development". Again, please change "sheila" to your name or whatever you named the new branch in step 5.
Once you're ready to merge your personal development branch with the team's development branch follow these steps:
(8) Navigate to the development branch by running "git checkout development". Check you're there using "git branch".
(9) Make sure you're development branch is up-to-date by running "git pull”.
(10) Switch to your personal development branch by running "git checkout sheila-development" or whatever you named the branch in step 5  and check you’re on the branch by running "git branch". Then, merge your personal branch with the development branch by running "git merge development".
Jason also made a little diagram for those of you that are visual learners. Thanks, Jason!

see #52 for sample code on how to run the app

use "git fetch --track origin/" to download a remote branch on your local computer

Hi all,
A reminder that when developing/testing/using datapie make sure you're loading the package with devtools::load_all(".") from your datapie.Rproj RStudio Console. This produces the common workspace in which we are all developing and the common environment in which package users will operate. Failing to do this can create inconsistencies in the package code we are all working and makes convergence on a coherent code base very difficult.
@sheilasaia and I just found inconsistencies in the usage of dependency libraries that is leading to different results across branches. Do not customize the loading of libraries to make datapie run. If you have a dependency that is apart of datapie add it to the DESCRIPTION file, or tell me and I'll add it.

Until automated testing is implemented with sufficient coverage, we are opting for a manual test of datapie UI functionality. So, before merging your work into master, please contact me and @atn38 for approval. One of us will perform the tests and let you know if it's OK to merge.

Manual testing protocol:

Use sample data and quickly check that each tab is populated with expected content. In depth testing of UI functionality is done in the next step.
Load data from DOI (doi:10.6073/pasta/b66da575549dcfe19dc404949613049b)

Exercise all functionality available in each tab of the UI and evaluate whether it's responding as expected.


Don't format collection expressions, because Roslyn doesn't either

Fixes https://github.com/dotnet/razor/issues/11325

Out of curiosity, are there tests to ensure that formatting works correctly for single-line collections expressions? C# still formats those.
So, this...
List<string> entries = [  ..     strings,    "a",      "b",         "c"    ];

Formats as...
List<string> entries = [.. strings,, "a", "b", "c"];


Scaling UI through Thunderstore Mod App

How do I scale UI and edit background color to none if I installed Mod through Thunderstore App?

https://thunderstore.io/c/valheim/p/Azumatt/Official_BepInEx_ConfigurationManager/
Or open up the config files and edit WackyEpicMMO config yourself.


fix: FIles which are not part of the smart contract are not excluded

fixes #49
It's a quick fix worth of refactoring
https://github.com/aeternity/smart-contract-verifier/assets/15363559/0957cec3-d0d8-4a40-aab3-ff6d21e5379f

I would also suggest to cover this by tests.

Good catch! Will this work also for files with several nesting levels? e.g. entry.aes includes: utils/lib1.aes which includes utils/date/foo.aes
Asking because utils/lib1.aes will likely reference utils/date/foo.aes by including date/foo.aes rather than absolute path

Good question. I haven't try this scenario at all.
Now when I want to produce such an example smart contract and compile it, I am getting following result
Include of lib/hamster_utils_nested.aesis not allowed, include only allowed at top level.
So I guess it's not even possible therefore solved .)


DELTASPIKE-1426: Improve ProxyFactory performance on start

Class.getMethond(name, args) is expensive operation, that is used
intensively on start, when DeltaspikeProxyFactory generates new proxies.
It was used even for checks of public abstract
methods of proxy's base class, but this methods cannot be overridden.
This patch collects all leave methods and skips them in the check.

can you add some unittests, to verify that collectAllMethods still collects all methods from all inhertiance levels?

I'll do that, give me some time for it .

Its not clear for me , what should be correct output in this case:
    public class Class_NonAbstract
    {
        public void test()
        {
        }
    }

    public abstract class Class_NonAbstractToAbstract extends Class_NonAbstract
    {
        public abstract void test();
    }

DS currently removes test() method from set of collected method, sou that output collection does not have neither Class_NonAbstract.test and neither Class_NonAbstractToAbstract.test


Add configuration for actor reentrancy

Description
This adds the necessary fields to enable reentrancy for actors
but does not actually implement any of the reentrant behavior.
Issue reference
Please reference the issue this PR will close: #3049
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[x] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@halspang Why does this PR have zero changes?


Upgrade to React 16

In #1161 we were contemplating some larger architectural changes. One piece we'll eventually need to do is migrate to React 16. So I've created this issue to track that effort.
Details of the migrations required are in this blog post from React.
Essentially, two gating items:

PropTypes - we need to move our PropTypes from the core react library to the new prop-types library.
Component creation - we need to move from React.createClass to classes that extend React.Component. This also changes lifecycle methods and bind of this.

I took a quick look at react-codemod but it seemed that it had trouble picking up our classes. Perhaps I was missing something or perhaps it was confused by our use of window.shared.

I'd like to close this since we're already doing a major Javascript refactor with @Jngai's ES6 work and there's no immediate need to upgrade to React 16. We can re-open when this becomes a higher priority.


Hamlib 4 compatibility

goHamlib is working well with the computers on which I have hamlib 3.3, but when attempting to compile against hamlib 4.1 (on Mac via homebrew) I get errors:
# github.com/dh1tw/goHamlib
rig.c:70:31: warning: passing 'int *' to parameter of type 'vfo_t *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Wpointer-sign]
/usr/local/Cellar/hamlib/4.1/include/hamlib/rig.h:2308:35: note: passing argument to parameter 'vfo' here
rig.c:333:46: warning: passing 'int *' to parameter of type 'vfo_t *' (aka 'unsigned int *') converts between pointers to integer types with different sign [-Wpointer-sign]
/usr/local/Cellar/hamlib/4.1/include/hamlib/rig.h:2423:41: note: passing argument to parameter 'tx_vfo' here
rig.c:408:39: error: too few arguments to function call, expected 4, have 3
/usr/local/Cellar/hamlib/4.1/include/hamlib/rig.h:2595:1: note: 'rig_set_ant' declared here
rig.c:423:39: error: too few arguments to function call, expected 7, have 3
/usr/local/Cellar/hamlib/4.1/include/hamlib/rig.h:2600:1: note: 'rig_get_ant' declared here
rig.c:583:8: error: use of undeclared identifier 'RIG_LEVEL_VOX'
rig.c:652:8: error: use of undeclared identifier 'RIG_LEVEL_VOX'
rig.c:702:8: error: use of undeclared identifier 'RIG_LEVEL_VOX'

Hi @xylo04,
with each major version (3.x.x, 4.x.x, ...) , the Hamlib team allows breaking changes in the API. So the errors you describe are actually expected, since goHamlib doesn't support hamlib version 4 (yet).
I think we could cover these changes by introducing conditional checks in goHamlib for the known API changes between Hamlib3 and Hamlib4. Probably making hamlib 4 the default and covering hamlib 3 compatibility with conditional checks.
Hamlib actually provides the library's semantic version in the const char hamlib_version [] string located in hamlib/rig.h. As far as I remember, this constant was introduced with version 3.x.
Since it wasn't available with version 1.x, I had to do some hacky conditional testing.
Maybe it's also time to deprecate the support for version 1.x and focus on supporting version 3 and version 4.
So, I guess we have to

export the version constant in a go variable / constant.
identify the breaking changes between hamlib 3 and 4 and handle them in conditional checks within the particular functions.
adopt the tests for using the hamlib version

hw?
Tobias

Hi @dh1tw, circling back on this (was this really a year ago?), I think introducing a new major module version would be appropriate. We could even call it v4 to align with the Hamlib version. That blog post recommends using a subdirectory per major version, but I've actually seen it more often done as branches. For example, that's what I've done with my wsjtx-go repo; the default branch is now v4 instead of main.
With this strategy, any development needed for hamlib v3 (and v1) can continue on the master branch, and the v4 branch can be pristine and not have to make any hacky conditional testing.
What do you think?

Oh yeah, and I forgot that https://github.com/dh1tw/goHamlib/pull/14 was still hanging out there.


fix(api): correct logic for simming partial tips

When we simulate partial tip pickup we do it by emulating the hardware control logic in the virtual pipette data provider and then passing the result to a nozzle manager the way the hardware controller does. Unfortunately, the logic in the pipette virtual data handler did not match the hardware controller.
Until we get to a place where we can have an actual simualting hardware controller or something, we just have to keep these in sync.
Testing
This is an analysis-only change, and has no effect on execution. The best way to test it is to test https://github.com/Opentrons/opentrons/pull/13972 since that's where I noticed the issue (we'll rebase that PR on this).

Oh awesome! This was giving me trouble in deck conflict check testing too. Thanks!


ApiPort roadmap

We use this issue to track the new features and improvement plan. The work items on the list are identified and prioritized by customer feedbacks. If you like to propose new items to be addd or increase the priority of the existing item, please open issue or vote on existing issue.

[ ] Improve recommended changes for missing APIs https://github.com/microsoft/dotnet-apiport/issues/773
[ ] Improve migration documentations for not supported technical areas in .NET Core https://github.com/microsoft/dotnet-apiport/issues/912
[x] Report .NET Core APIs throwing PlatformNotsupportedException and NotImplementedException https://github.com/microsoft/dotnet-apiport/pull/897
[x] Suggest components porting order based on entrypoint assembly https://github.com/microsoft/dotnet-apiport/pull/906
[ ] Show the absolute count of missing APIs instead of percentages on the summary page to make the summary page more useful https://github.com/microsoft/dotnet-apiport/issues/913
[ ] Identify commonly used nuget packages that are used and provide links to portable version if available  https://github.com/microsoft/dotnet-apiport/issues/892
[ ] Report number of calls to missing .NET APIs to help estimate porting cost https://github.com/microsoft/dotnet-apiport/issues/858

#897 #906

One thing that I've seen experienced users do with ApiPort that would be great to somehow captured for people newer to the tool is to quickly scan missing NetFx APIs to look for 'red flag' APIs that may make porting more difficult.
For example, if I see WebForms or WCF server APIs in a customer's report, I know they have a more difficult port ahead compared to a different customer that is only missing APIs with easy replacements (even if that second report is missing a larger number of APIs).
Could we expand #913 to also give some sense of whether the missing APIs are 'easy' or 'hard' to replace? @twsouthwick and I along with the product teams could probably help to bucketize APIs in the catalog for this purpose. I think that sort of view would be the most useful summary page (count of APIs is better than %, but still could be misleading).

@mjrousos Thanks for your suggestion. It makes sense. I will definitly leverage yours and @twsouthwick's help to bucketize the APIs.

Closing as API Port was deprecated in favor of binary analysis in .NET Upgrade Assistant.


[MODCLUSTER-410] registered MCMP methods with httpd

fixed OPTIONS method so now Allow header is returning all of the MCMP methods.
sample OPTIONS output:
$ curl -X OPTIONS http://<IP_ADDRESS>:6666

* About to connect() to <IP_ADDRESS> port 6666 (#0)
*   Trying <IP_ADDRESS>...
* Adding handle: conn: 0x7f8353003a00
* Adding handle: send: 0
* Adding handle: recv: 0
* Curl_addHandleToPipeline: length: 1
* - Conn 0 (0x7f8353003a00) send_pipe: 1, recv_pipe: 0
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 6666 (#0)
> OPTIONS / HTTP/1.1
> User-Agent: curl/7.30.0
> Host: <IP_ADDRESS>:6666
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Thu, 05 Jun 2014 03:51:31 GMT
* Server Apache/2.2.26 (Unix) mod_ssl/2.2.26 OpenSSL/0.9.8y mod_cluster/1.3.1.dev DAV/2 is not blacklisted
< Server: Apache/2.2.26 (Unix) mod_ssl/2.2.26 OpenSSL/0.9.8y mod_cluster/1.3.1.dev DAV/2
< Allow: GET,HEAD,STATUS,INFO,OPTIONS,ENABLE-APP,DUMP,REMOVEID,REMOVE-APP,DISABLE-APP,POST,ERROR,PING,STOP-APP,ADDID,CONFIG
< Content-Length: 0
< Content-Type: httpd/unix-directory
<
* Connection #0 to host <IP_ADDRESS> left intact

by registering methods with apache, methods could be compared now more efficiently, by switching to method_number() compare instead of strcmp() on a method string.

@jfclere @winfinit Hi guys, what became of this PR? It has never made it to the master if I'm not mistaken.

It was closed before I had time to retest it.


Couldn't start global hook

How do I make short paths enabled?
RenderDoc version: 1.33
Operating System: windows11

Hi there, your issue has been closed due to not correctly following the issue template. Please read the documentation about filing issues and open a new issue which does follow the issue template. Do not reply to this issue with more information or with a correctly formatted issue, as that will only lead to confusion.
I try to address all github issues and fix bugs quickly, but badly formatted issues or poorly described bug reports especially are a significant drain on project resources. Taking a few minutes to file a good issue makes a huge difference and will get it addressed faster - everybody wins!
In github when you first create a new issue the form is pre-populated with a template which you should read over and follow. As linked above there is documentation going into more detail about what makes a good issue.

use this cmd command can fix the problem
fsutil file setshortname "D:\Program Files\RenderDoc" RENDER~1

Please do not comment on old issues that have been closed.
If you are encountering a bug or are requesting a feature please open a new issue. You can reference this issue if you wish, but opening a new issue prevents any confusion of accidentally linking two unrelated issues and means that each issue can be handled in a clean process.


Trinary - Update to Scala 2.12.1 - refs #235.

Update to Scala 2.12.1 - refs #235.
Note that Trinary is actually deprecated.. So, there probably wasn't much reason to update the build.sbt. But it was easy to do...

thanks @ricemery


Add Contravariant and Category instances to the Case newtype.

Much like Op from Data.Functor.Contravariant.

It seems that the Category instance would require the functor parameter of Case to be both Applicative and Comonad:
newtype Case f a b = Case (f b -> a)

instance Functor f => Contravariant (Case f a) where
    contramap g (Case c) = Case (c . fmap g)

instance (Applicative f,Comonad f) => Category (Case f) where
    id = Case $ extract
    (Case f) . (Case g) = Case $ g . pure . f

(Is the instance lawful?)
Anyway, I don't want to depend on the comonad package just for that instance.

I wonder what's the relationship, if any, with Cokleisli arrows.


Implement Fuzzy Search

Allow fuzzy matching so that the input only has to approximately match the favorited commands.

Fixed in #6


Fix clearing Rendertarget multiple times

This fixes a bug Renderer clearing a render target multiple times when the first time and back again.
Usually the default RenderTarget is unintentionally cleared/discarded in the current behavior.

Renderer renders a view without custom RenderTarget having full-screen viewport,
Renderer renders a view with custom RenderTarget
And Renderer renders an another view without custom RenderTarget having different viewport from 1)
You may see junk or empty pixels in outside of the viewport of the view 3), depending on ClearOptions and the backend.

This fix make Renderer put RenderTargets into a set and check them to be cleared only for the first time, instead of comparing the previous RenderTarget to the current RenderTarget.

@googlebot I fixed it..


添加MoveCell的方法约束错误

给Demo工程添加Cell置顶的功能后，所有的cell高度出错。
- (void)moveWithIndexPath:(NSIndexPath *)indexPath {
    if (!indexPath) return;

    FDFeedEntity *feedEntity = self.feedEntitySections[indexPath.section][indexPath.row];
    [self.feedEntitySections[indexPath.section] removeObjectAtIndex:indexPath.row];
    [self.feedEntitySections[0] insertObject:feedEntity atIndex:0];

    [self.tableView moveRowAtIndexPath:[NSIndexPath indexPathForRow:indexPath.row inSection:indexPath.section] toIndexPath:[NSIndexPath indexPathForRow:0 inSection:0]];

}

but when I use methed
[self.table reloadData]
 to replace this methed
[self.tableView moveRowAtIndexPath:[NSIndexPath indexPathForRow:indexPath.row inSection:indexPath.section] toIndexPath:[NSIndexPath indexPathForRow:0 inSection:0]],
the rowHeight is ok;

@giveMeHug

You can combine row-move operations with row-insertion and row-deletion operations within a beginUpdates–endUpdates block to have all changes occur together as a single animation.
Unlike the row-insertion and row-deletion methods, this method does not take an animation parameter. For rows that are moved, the moved row animates straight from the starting position to the ending position. Also unlike the other methods, this method allows only one row to be moved per call. If you want multiple rows moved, you can call this method repeatedly within a beginUpdates–endUpdates block.

let me know if still now working


features/42-add unit test

Resolve #42

We do not export this function at least for now as it is not reliable yet. The function was used in vignettes for demonstrational purposes only.


Fix Google Scholar link on publications page

Copying the author assignment lines from _includes/author_profile.html is a simple way to solve the variable scope issue that (I believe) seems to be why the link isn't showing.
I suggest this is a slightly better solution than #474 and #545 as it doesn't break multi-author support on the default version of the publications page.

I agree with you, this is indeed better. I would keep out the last commit from the PR though.


[Vue]: skipToken example is misleading

Describe the bug
The skipToken documentation suggests to me that skipToken can be used similarly to enabled, but enabled can actually be reactive, so if something changes there, the query can actually be turned on/off, but in the case of skipToken, the value is evaluated on creation, and that doesn't change anymore, even if the ternary operator uses reactive values in there.
The example also has an unused isEnabled computed, and it relies on the filter, instead of filter.value in the ternary operator, which will always evaluate to true, thanks to it being a Ref object.
The skipToken solution in its current shape is not usable for use-cases where on component mounting one of the params is empty for example (like on a search page), and the moment somebody enters a search term, the query should be enabled.
Your minimal, reproducible example
https://tanstack.com/query/v5/docs/framework/vue/guides/disabling-queries
Steps to reproduce

Use the example code

See that the fetchTodos is called even if the filter has no actual value

Use the example code

Change the ternary operator to rely on the value of the filter

Set the filter value after mounting happened

See that the fetchTodos is not called

Expected behavior
I'd expect the documentation to make these caveats clearer, or preferably make the skipToken solution reactive somehow.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Probably all of them
Tanstack Query adapter
vue-query
TanStack Query version
5.29.0
TypeScript version
5.4.5
Additional context
No response

Fixed in docs

Sorry to necro this @DamianOsipiuk, only now I had the opportunity to check the improved docs out. While the proposed solution does seem to work, it causes TypeScript issues. queryFn does not accept ComputedRef as a possible value. Should I create a new issue for this?

I'm also having some issues with skipToken and cannot seem to get it to work and satisfy typescript.

Sorry to necro this @DamianOsipiuk, only now I had the opportunity to check the improved docs out. While the proposed solution does seem to work, it causes TypeScript issues. queryFn does not accept ComputedRef as a possible value. Should I create a new issue for this?

Seems to work fine for me, make sure computed returns a function or skipToken.
Also make sure you are on a latest version.
If it's still a problem, open a new issue with reproduction is TS playground.
const filter = ref('')
const queryFn = computed(() =>
  filter.value ? () => Promise.resolve(1) : skipToken,
)

Thanks for the reply @DamianOsipiuk!
It looks like the issue isn't with tanstack query itself but with https://github.com/lukemorales/query-key-factory. It seems that when a queryFn is a computed in createQueryKeys then the data is infered as Ref<unknown>.
// data is inferred as `Ref<unknown>`
const { data } = useQuery(queries.user.single(userId))

If i dont use a computed with skipToken in createQueryKeys, but wrap it like this it works fine:
// data is inferred as `Ref<User>`
const { data } = useQuery({
  ...queries.user.single(userId),
  queryFn: computed(() => (userId.value ? queries.units.single(userId).queryFn : skipToken)),
})

Sorry for the confusion. I will see if i can work out a way to describe it as an issue on the query-key-factory repository

Seems like it's not a problem on the latest version anymore, thanks!

This looks like the issue on the query key factory in case anyone lands here in the future: https://github.com/lukemorales/query-key-factory/issues/100


Please add to jsdelivr for cdn hosting

Adding to jsdelivr will provide the community with free cdn for ui-router-extras.
https://github.com/jsdelivr/jsdelivr/blob/master/CONTRIBUTING.md

https://github.com/jsdelivr/jsdelivr/pull/7201

done.


[Feature Request]: Agent framework to integrate third party features.

Is your feature request related to a problem? Please describe.
One kind of issues we have is that the third party usually create stand alone agent and we need to integrate those if we would like to support the those.
e.g. LlamaindexAgent
FalkorDB Agent https://github.com/FalkorDB/GraphRAG-SDK/tree/main/graphrag_sdk/agents
Instead of integration of third party ourself, we could promote AutoGen by providing an agent library/framework for the third party to easily create AutoGen agent.
Describe the solution you'd like
An agent library/framework that third parties could easily use to create an AG2 agent
Additional context
No response

Another great point!