Update year to 2020 in scripts and readme

Would it make sense to change the date in CITATION.cff as well?

Would it make sense to change the date in CITATION.cff as well?

I thought about that, but considering that the Zenodo citation we use in the cff file is the overarching umbrella one that we made in 2019, I think it should remain this way.
The other question was section seven in the license, which reads:

7 Copyright Notices.  All copies of the Software or derivative works
shall include the following copyright notice: "Copyright 2019 The
Board of Trustees of the University of Illinois. All rights
reserved."

I assume that year shouldn't be updated, because then anything that includes the notice would have to be updated every year to avoid being in violation, I'd think. However, I'd be interested to hear other opinions on this.

Would it make sense to change the date in CITATION.cff as well?

I thought about that, but considering that the Zenodo citation we use in the cff file is the overarching umbrella one that we made in 2019, I think it should remain this way.

Ok, makes sense.

The other question was section seven in the license, which reads:

7 Copyright Notices.  All copies of the Software or derivative works
shall include the following copyright notice: "Copyright 2019 The
Board of Trustees of the University of Illinois. All rights
reserved."

I assume that year shouldn't be updated, because then anything that includes the notice would have to be updated every year to avoid being in violation, I'd think. However, I'd be interested to hear other opinions on this.

In any case, we could change that in a separate patch as well.

@ericjbohm can you review this point?

The other question was section seven in the license, which reads:
7 Copyright Notices. All copies of the Software or derivative works
shall include the following copyright notice: "Copyright 2019 The
Board of Trustees of the University of Illinois. All rights
reserved."
I assume that year shouldn't be updated, because then anything that includes the notice would have to be updated every year to avoid being in violation, I'd think. However, I'd be interested to hear other opinions on this.


High RAM consumption during custom export

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Steps to Reproduce (for bugs)

Create a task with annotations amount, approx. resulting in 380Mb in Cvat for Video
Use task_data.group_by_frame() method
Monitor cvat_worker_export docker container RAM usage

The thing is that this method - group_by_frame() reads all annotations for task in RAM
Expected Behaviour
Maybe it's better to create a method, that will return Frame for exact frame number, so user could iterate over each separate frame in the task, (so method will fetch data from db and create an individual Frame) without loading all Frames in ram
Current Behaviour
Here is a RAM consumption plot for 75 000 frames. CVAT for video annotation file size is 380Mb

Context
I got this approach from here: https://opencv.github.io/cvat/docs/contributing/new-annotation-format/
Your Environment

CVAT 2.4.5

Hi @PMazarovich
Thank you for the report. It is a known issue.

It was slightly improved in #6204, which was included in v2.4.7.


GH-1455: AdviceChain on Stream Listener Container

Resolves https://github.com/spring-projects/spring-amqp/issues/1455
Add an advice chain to the stream listener container and its factory.
Add a StreamMessageRecoverer for native stream messages.
Add a retry interceptor to work with native stream messages.
cherry-pick to 2.4.x
(What's New? will conflict so I left it out - will polish it in both branches after merge).

... and cherry-picked to 2.4.x


add pragma entry point

added entry point to resolve 3.3.0 lookup issue
#1061

thanks @giorgionegro ! I have updated the version code and the changelog, once GitHub actions finish I will merge and release.


Configuration::setLoggerCallable removed without mentioning in UPGRADE notes.

I consulted these materials before posting this:
https://github.com/doctrine/mongodb-odm/blob/master/UPGRADE-2.0.md
https://github.com/doctrine/mongodb-odm/blob/master/CHANGELOG-2.0.md
https://www.doctrine-project.org/projects/doctrine-mongodb-odm/en/2.0/reference/logging.html
BC Break Report

Q
A

BC Break
yes

Version
2.0.0-beta1

Summary
Doctrine\ODM\MongoDB\Configuration::setLoggerCallable is no longer available and it is not clear how to replace it. There is no mention in UPGRADE notes or CHANGELOG and documentation does not exist.

Thanks for reporting this! We've noticed a couple of other BC breaks as well, which means that we'll need to do another pass to make sure we document all deprecations and removals.
I played around with roave/backward-compatibility-check this morning and will try to use that to figure out what else we missed.

Closing in favour of #2009 where I finally got to running roave/backward-compatibility-check.

@alcaeus
was wondering what is a good approach to add a somehow simliar logging functionality in 2.x .
any hints?
thank you

whats the preferred approach now for logging?

The APM features of the MongoDB driver should be used to log commands that are run. The Symfony bundle for MongoDB ODM already incorporates this into the Symfony profiler. If not using Symfony, you can use the Doctrine\ODM\MongoDB\APM\CommandLogger class and base your logic on that.


Terminal overview ruler width doesn't change when zooming

Repro:

Open shell integration enabled terminal
Run some commands
Zoom in, the overview ruler should be the same width as the scroll bar

This also seems to apply on new terminals (is 10px hardcoded?), I also notice the overview ruler is 1 pixel too left at this particular zoom level (4):

Decorations are tiny because of this on a macbook (dpr=2):

should this be up to the embedders or xterm.js to handle when dpr changes (when zooming etc)?

I see the renderers handle this themselves
https://github.com/xtermjs/xterm.js/blob/fea1079b1ec91b2406ea73a3cbda0e940436bf73/addons/xterm-addon-webgl/src/WebglRenderer.ts#L136-L143

Yep xterm.js should handle dpr changes

It does already. Looking at where overviewRulerWidth is set at the moment

https://github.com/xtermjs/xterm.js/blob/e293d29fd3306fc04b9a0b6fa5308eb16bb4f4d7/src/browser/Decorations/OverviewRulerRenderer.ts#L54

the problem
https://github.com/microsoft/vscode/blob/d2433fba88b7b4699586c4bcf8f4c86b55144366/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts#L134

should be 15

That's fine (it should be CSS pixels), where ever it's used inside xterm.js should be multiplied by dpr though

it is

https://github.com/xtermjs/xterm.js/blob/e293d29fd3306fc04b9a0b6fa5308eb16bb4f4d7/src/browser/Decorations/OverviewRulerRenderer.ts#L109

reopening until the canvas width (which factors in dpr) is used for the decoration width

Looks like this is fixed now


Closing the maya session and reopening causes issues

Hello!
I am able to import the facial animation from unreal to maya perfectly using this script. The issue I'm seeing is that if I save that file or save as in a new location, close the current maya session and reopen; there are some problems. If I select a metahuman control and try to set the current metahuman I now get an error "Missing critical node, embeddedNodeRL4, used for rig logic!". Also as I scrub through the timeline, the facial controls move, but have no influence on the mesh. Just wanted to check if you are seeing this behavior. I can also provide more detailed repo steps if necessary.
Thank you for providing this script and updating it, it's honestly quite amazing.

Hi,
I've not experienced this.
Possibly the DNA file path is invalid or missing?
In your python script editor, to find the node, run this and it should select the node
import pymel.core as pm
embedded_node = pm.ls(type=pm.nt.EmbeddedNodeRL4)
pm.select(embedded_node, r=True)

In the attribute editor, make sure it points to the correct DNA path.
Btw, if you move this file, it won't update in the maya scene.

Thank you! It was definitely an issue with the DNA path. I was able to fix the issue by first opening maya and then opening the maya scene; instead of double clicking to open the file directly.
Thanks for the tip and thanks again for all your work on this script!


Ability to exclude namespaces from mutation

When running the metrics:mutant task against axiom, mutant will also include Axiom::Types, which obviously causes lots of mutation failures.
Ideally I would be able to specify the (one or more) namespaces to exclude in the config/mutant.yml file.

This is supported already. By mutant itself and in the configuration file devtools ships.


Code & UI/UX Enhancements

Here's a packed up PR.
What it changes
:recycle: Data structure & components refactoring
Now all data is in one file in src/data/data.js structured by project category
The same component was re-written for every category, now there is one unique re-usable component for each case: the list and the card. Respective components are: ProjectsList.js and ProjectCard.js.
A main perk of using component is re-usability. We pass from more than 10 files to 2.
:lipstick: Scrollbar
Styled a bit the scroll bar to make it fancier.

:green_apple: Code clean
Cleaning unused props, proptypes and imports.
:1234: Category Filter
Introducing logic into the categories filtering.
:mag: Searchbar
Introducing a searchbar to look out for projects by name.

:satellite: Networks Filter and Pills
Introducing network pills into cards and a networks filter

Hope you like it :smiley:
Don't hesitate to comment if anything is not clear.
You can also reach out to me here if you want to discuss :)
Twitter: 0xethercake
Telegram: wassim_0X

Wow this is amazing! Merged at once!
Super stoked about this.
🍻


Failed to load the open package

[Enter steps to reproduce:]

...
...

Atom: 1.46.0 x64
Electron: 4.2.7
OS: Microsoft Windows 10 Home
Thrown From: open package 2.0.4
Stack Trace
Failed to load the open package
At There is already a URI host handler for the host open

Error: There is already a URI host handler for the host open
    at URIHandlerRegistry.registerHostHandler (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:351037)
    at PackageManager.registerURIHandlerForPackage (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:382126)
    at Package.registerURIHandler (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:3290854)
    at measure (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:3285306)
    at Package.measure (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:3284372)
    at Package.load (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:3285113)
    at PackageManager.loadAvailablePackage (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:381274)
    at PackageManager.loadPackage (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:380002)
    at PackageManager.activatePackage (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:382574)
    at ~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:943557
    at r (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:11:938163)
    at o (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:14:1122275)
    at ChildProcess.n.process.on.e (~/AppData/Local/atom/app-1.46.0/resources/app/static/<embedded>:14:1122481)
    at ChildProcess.emit (events.js:182:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

Commands
     -7:36.5.0 linkist:link (span.syntax--text.syntax--plain.syntax--null-grammar)
 21x -6:32 core:backspace (input.hidden-input)

Non-Core Packages
click-link 1.0.11
markdown-to-html 0.5.0
open 2.0.4
open-file 2.1.0

It looks like you have multiple packages that use the open host.
Your error:
At There is already a URI host handler for the host open
Remove the other one and open will work


Market.sell_limit() returns APISIGN_NOT_PROVIDED exception

Hi,
Thanks for sharing your great wrapper, I have been playing with this library which has been successful in reading market information but I'm getting an error if I try calling sell/buy methods. here is my example code
#include <iostream>
#include <bittrex-cpp/client.h>

int main(){
    std::string key="******";
    std::string secret="******";
    bittrex::Client cl(key,secret);
    bittrex::api::Market m = cl.get_market();
    auto ret = m.sell_limit("USDT-ADA",1.0,0.5);
    std::cout << "Done!" << std::endl;
}

and here is the error I get
terminate called after throwing an instance of 'fail'
  what():  APISIGN_NOT_PROVIDED
Aborted (core dumped)

I would appreciate any feedback.

Hi,
Thank you for your feedback.
The problem is that struct curl_slist had been freed before calling perform. I fixed the bug.You should be using account/market api without problem.


Pass other command-line openvpn args possible?

Is it possible to pass other command-line openvpn args with the namespaced-openvpn script?
I see namespaced-openvpn takes these argument --config.
Is it possible to pass other openvpn arguments from the client.ovpn file directly to namespaced-openvpn?
Like this: namespaced-openvpn --config vpn.ovpn --(other openvpn argument like –proto udp)
So i don`t have to edit each .ovpn file and change these values.

Yep! You can pass arbitrary openvpn args on the command line, nost just --config. (--route-up has some edge cases; see the "TODO" section of the readme.)


Install via pip

Do we want to support installation via pip? If so, then we need to fix the list in the configuration.

This is working fine now, not sure if due to a change or what.


pythonPackages.pyotp: fix tests

Motivation for this change
This disables tests for python27, as they import urllib in an unsupported way.
ZHF: #97479
Result of nixpkgs-review pr 100023 1

4 packages built:

home-assistant
python27Packages.pyotp
python37Packages.pyotp
python38Packages.pyotp

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Could you add a pythonImportsCheck then please?

Could you add a pythonImportsCheck then please?

Quite new to python packaging, was not aware of this being a thing. Thanks. This showed me the application does not work at all with python 2.7, so I've adjusted the PR accordingly. I've still added an pythonImportsCheck, as it can't hurt to check.
Check whether the following modules can be imported: pyotp
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/5r503z502ign3045p957svdajs574fny-python-2.7.18/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/nix/store/6mj608cz3749m4vz0b36bzvmbnddhma1-python2.7-pyotp-2.4.0/lib/python2.7/site-packages/pyotp/__init__.py", line 14
    length: int = 16,
          ^
SyntaxError: invalid syntax
builder for '/nix/store/f0nd7gwg3ymrlmd4hfcdpb2x94cgki5a-python2.7-pyotp-2.4.0.drv' failed with exit code 1
error: build of '/nix/store/f0nd7gwg3ymrlmd4hfcdpb2x94cgki5a-python2.7-pyotp-2.4.0.drv' failed

Result of nixpkgs-review pr 100023 1

3 packages built:

home-assistant
python37Packages.pyotp
python38Packages.pyotp

Wondering about the urllib3 dependency.

Oops, looks like i accidentally left that in. Removed :+1:


Add support for readOnly and writeOnly properties

Summary
Apisprout does not support readOnly and writeOnly attributes of properties.
Steps to reproduce
Mock this schema:
paths:
  /foo:
    get:
      operationId: getFoo
      responses:
        '200':
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/fooSchema"
    post:
      operationId: postFoo
      requestBody:
        description: The state to set to the alarm
        required: true
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/fooSchema"

components:
  schemas:
    fooSchema:
      type: object
      properties:
        normalProp:
          type: string
        readOnlyProp:
          readOnly: true
        writeOnlyProp:
          writeOnly: true
      required:
        - normalProp
        - readOnlyProp
        - writeOnlyProp

Actual result
In GET operation, the example includes writeOnlyProp. In POST operation it requires readOnlyProp.
Expected result

It shouldn't include writeOnly properties in auto-generated examples. The response should be:

{
  "normalProp": "string",
  "readOnlyProp": "string"
}

It shouldn't require readOnly properties in the request body. This request body should be valid:

{
  "normalProp": "foo",
  "writeOnlyProp": "bar"
}

Link to specification

@jormaechea for the two parts:

I will update the example generator to take these into account.

This is actually an upstream issue, and I have opened getkin/kin-openapi#71 so that it can be handled in the correct repo.

Thanks for these awesome bug reports!

Great!
Just subscribed to the upstream issue.

Glad to help with issue reporting! I'd algo contribute, but I'm not familiar with go.. :disappointed:

@danielgtaylor you had no news about the upstream issue yet? :disappointed:

FYI https://github.com/getkin/kin-openapi/issues/71 is closed and a new release pushed, please take a look :)


Update manifest.yml

Codecov Report

Merging #147 (1b2dc52) into main (fc0e78c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   95.18%   95.18%
=======================================
  Files           5        5
  Lines         436      436
=======================================
  Hits          415      415
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0e78c...1b2dc52. Read the comment docs.


expander expands builtin Intl types to any

Builtin Intl doesn't register as a built-in type properly.
Reproduction
Run
new Intl.Locale();

Then you can see the log like this though the type BCP47LanguageTag is string.
  DEBUG Analyzer.find_type('BCP47LanguageTag#0')
    at crates/stc_ts_file_analyzer/src/analyzer/scope/mod.rs:1831
    in Scope::find_type with name: BCP47LanguageTag#0
    in find_local_type
    in find_type with name: BCP47LanguageTag#0
    in Expander.expand_ref
    in Expander.expand_type
    in expand
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: (BCP47LanguageTag | Locale);
    in assign with lhs: "(BCP47LanguageTag | Locale);", rhs: "void;"
    in check_call_args
    in select_and_invoke
    in call_property
    in extract_call_new_expr_member
    in Stmt with line_col: "(1:1-1:19)"

  DEBUG Analyzer.find_type('BCP47LanguageTag#0')
    at crates/stc_ts_file_analyzer/src/analyzer/scope/mod.rs:1831
    in Scope::find_type with name: BCP47LanguageTag#0
    in Scope::find_type with name: BCP47LanguageTag#0
    in find_local_type
    in find_type with name: BCP47LanguageTag#0
    in Expander.expand_ref
    in Expander.expand_type
    in expand
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: (BCP47LanguageTag | Locale);
    in assign with lhs: "(BCP47LanguageTag | Locale);", rhs: "void;"
    in check_call_args
    in select_and_invoke
    in call_property
    in extract_call_new_expr_member
    in Stmt with line_col: "(1:1-1:19)"

  DEBUG Scope.find_type: failed to find type 'BCP47LanguageTag#0'
    at crates/stc_ts_file_analyzer/src/analyzer/scope/mod.rs:1205
    in find_local_type
    in find_type with name: BCP47LanguageTag#0
    in Expander.expand_ref
    in Expander.expand_type
    in expand
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: (BCP47LanguageTag | Locale);
    in assign with lhs: "(BCP47LanguageTag | Locale);", rhs: "void;"
    in check_call_args
    in select_and_invoke
    in call_property
    in extract_call_new_expr_member
    in Stmt with line_col: "(1:1-1:19)"

  ERROR (1) Failed to find type: BCP47LanguageTag#0
    at crates/stc_ts_file_analyzer/src/analyzer/scope/mod.rs:2174
    in Expander.expand_ref
    in Expander.expand_type
    in expand
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: (BCP47LanguageTag | Locale);
    in assign with lhs: "(BCP47LanguageTag | Locale);", rhs: "void;"
    in check_call_args
    in select_and_invoke
    in call_property
    in extract_call_new_expr_member
    in Stmt with line_col: "(1:1-1:19)"

  DEBUG [expander (time = 737.708µs)]: BCP47LanguageTag; => any;
    at crates/stc_ts_file_analyzer/src/analyzer/scope/mod.rs:2631
    in expand
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: (BCP47LanguageTag | Locale);
    in assign with lhs: "(BCP47LanguageTag | Locale);", rhs: "void;"
    in check_call_args
    in select_and_invoke
    in call_property
    in extract_call_new_expr_member
    in Stmt with line_col: "(1:1-1:19)"

  DEBUG [expander] expand: BCP47LanguageTag; => any;
    at crates/stc_ts_file_analyzer/src/analyzer/scope/mod.rs:738
    in expand
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: BCP47LanguageTag;
    in normalize with ty: (BCP47LanguageTag | Locale);
    in assign with lhs: "(BCP47LanguageTag | Locale);", rhs: "void;"
    in check_call_args
    in select_and_invoke
    in call_property
    in extract_call_new_expr_member
    in Stmt with line_col: "(1:1-1:19)"

https://github.com/dudykr/stc/blob/08289e740d33f99e71624f8a10bdfed9194bc45f/crates/stc_ts_builtin_types/lib/es2020.intl.d.ts#L79
I guess it is due to the fact that builtin Intl is the only builtin type declared in namespace.
https://github.com/dudykr/stc/blob/08289e740d33f99e71624f8a10bdfed9194bc45f/crates/stc_ts_builtin_types/lib/es2020.intl.d.ts#L2

Did you try using dbg!? There's a footgun in dump_type_as_string....
https://github.com/dudykr/stc/blob/23dcadee07bcf1bc1d406bf9f6d141e8d079da2e/crates/stc_ts_errors/src/debug/mod.rs#L286

I filed https://github.com/dudykr/stc/issues/650 because I think it's a footgun

Are you talking about logs? The actual type was also analyzed as any.

I see, thank you for the investigation


Vertex attributes removed from pipeline when shader modules are shared

When a single fragment shader module is shared between multiple pipelines, it appears that the vertex attributes for the second pipeline will be culled based on the unused vertex attributes in the first pipeline. This leads to an error when the Metal pipeline is created, as there is an attribute used in the shader which is not specified in the pipeline descriptor.
For this to occur, the vertex shader must precede the fragment shader in the pipeline stages. I've managed to narrow it down to the following steps:

Vertex shader V1 is created, does not use the attribute.
Fragment shader F is created.
Pipeline is created from V1 and F. This causes the shaders to be compiled, and the "used vertex attributes" are stored in both V1 and F's converter context.
Vertex shader V2 is created, which does use the attribute.
Pipeline is created from V2 and F. V1 is compiled. V1 is compiled, and the existing library from F is used. However, because the fragment shader is looked up after the vertex shader, the attributes from F are copied to the compile context in MVKGraphicsPipeline::getMTLRenderPipelineDescriptor.
Vertex attributes are removed from the pipeline descriptor.
Metal pipeline fails to create.

To easily reproduce the bug, see the modified version of 15_draw_cube here: https://gist.github.com/stenzek/1c44266c910a830c52f841526c469a0f
We can work around this bug by always specifying the vertex shader as the last stage in the pipeline, but this is not ideal. My "fix" was only to copy the vertex attribute usage in SPIRVToMSLConverterContext::alignUsageWith when the model was vertex, however, I'm not sure this is the cleanest solution.

Confirming this issue is no longer occurring, thank you for the fix.


Documentation updated

Purpose of this PR
Small update of the documentation.

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   89.91%   89.91%
=======================================
  Files           8        8
  Lines         347      347
  Branches       25       25
=======================================
  Hits          312      312
  Misses         33       33
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd63ea...3dbfd4e. Read the comment docs.


MINOR: Add Kafka Streams API / upgrade notes

One small comment regarding consistent terminology, otherwise LGTM.

@ijuma Could you take a look?

LGTM


Add ui for filtering by path and org to feedex

For: https://trello.com/c/8wwFr5y0/196-improvements-to-feedex-ui
It's possible to filter feedex by both path and organisation if you manipulate the URL, but there's no UI so it's not obvious.  This PR adds UI elements to make it more obvious and easier to do.
Screenshots
We choose to browse by org, and then decide we want to also filter by a specific path, and finally remove the org constraint.
Before

There's no UI for adding path or removing organisation filters, but we can do it by manually hacking the URL.  The page doesn't tell us we've filtered by multiple things, but the data has been updated accordingly.
After

UI for path and org filtering is always present on the page, and we've tweaked the help text to make it clear you can use a partial path to filter results.
Discarded alternates
V1 - icon button in header

V2 - text button in form

Would particularly appreciate thoughts on the UI choices I've made as I'm not 100% sure they're the best.

Can we avoid magic icons and have a link with text? eg "Filter by path", "Edit filters", or something?

@fofr - how does the v2 gif look (I've updated the description above).

@fofr / other interested parties: I reviewed this with Liz and we decided that hiding the UI was counter-intuitive even though having it there all the time pushes the results further down the page.  We also clarified the help text for URL filters to make it clearer that you can use a partial path while searching to find feedback on entire classes of documents (like guidance or done pages).


Comments are assigned to whoever runs the import tool

Describe the bug
When I run the import command all the imported comments in DevOps shows me as author or whoever runs the import tool.
I am using Jira Cloud and mapping the users by email since when I tried to use JiraID I get the error "Could not find user identity in user map". I read the comments in this issue #194  but I could not solve my problem.

Can you share your configuration and check it against the example configuration here? https://github.com/solidify/jira-azuredevops-migrator/blob/master/docs/config.md
Spcifically for comments it should be this mapper:
{
  "source": "comment",
  "target": "System.History",
  "mapper":"MapRendered"
},

@MOlausson , @madkoo , is this behavior expected?

Bellow is my configuration file, and yes, it is using the right mapper.
{   "source-project": "WFMKYNRPTS",   "target-project": "CIO IT - WFM Reports",   "query": "project = WFMKYNRPTS ORDER BY Rank ASC",   "using-jira-cloud": true,   "workspace": "C:\\Temp\\JiraExport-Hub-Reports\\",   "epic-link-field": "Epic Link",   "sprint-field": "Sprint",   "download-options": 7,   "batch-size": 20,   "log-level": "Info",   "attachment-folder": "Attachments",   "user-mapping-file": "users.txt",   "base-area-path": "Migrated",   "base-iteration-path": "Migrated",   "ignore-failed-links": true,   "process-template": "Scrum",   "link-map": {     "link": [       {         "source": "Epic",         "target": "System.LinkTypes.Hierarchy-Reverse"       },       {         "source": "Parent",         "target": "System.LinkTypes.Hierarchy-Reverse"       },       {         "source": "Relates",         "target": "System.LinkTypes.Related"       },       {         "source": "Duplicate",         "target": "System.LinkTypes.Duplicate-Forward"       },       {          "source": "Child",          "target": "System.LinkTypes.Hierarchy-Forward"        }     ]   },   "type-map": {     "type": [       {         "source": "Feature",         "target": "Feature"       },       {         "source": "Epic",         "target": "Epic"       },       {         "source": "Story",         "target": "User Story"       },       {         "source": "Bug",         "target": "Bug"       },       {         "source": "Task",         "target": "Task"       },       {         "source": "Sub-task",         "target": "Task"       },       {         "source": "Change Request",         "target": "Issue"       },       {         "source": "Incident",         "target": "Issue"       },       {         "source": "Maintenance",         "target": "Issue"       }     ]   },   "field-map": {     "field": [       {         "source": "summary",         "target": "System.Title",         "mapper": "MapTitle"       },       {         "source": "assignee",         "target": "System.AssignedTo",         "mapper": "MapUser"       },       {         "source": "description",         "target": "System.Description",         "mapper": "MapRendered"       },       {         "source": "priority",         "target": "Microsoft.VSTS.Common.Priority",         "mapping": {           "values": [             {               "source": "Blocker",               "target": "1"             },             {               "source": "Critical",               "target": "1"             },             {               "source": "Highest",               "target": "1"             },             {               "source": "Major",               "target": "2"             },             {               "source": "High",               "target": "2"             },             {               "source": "Medium",               "target": "3"             },             {               "source": "Low",               "target": "3"             },             {               "source": "Lowest",               "target": "4"             },             {               "source": "Minor",               "target": "4"             },             {               "source": "Trivial",               "target": "4"             }           ]         }       },       {         "source": "Sprint",         "source-type": "name",         "target": "System.IterationPath",         "mapper": "MapSprint"       },       {         "source": "labels",         "target": "System.Tags",         "mapper": "MapTags"       },       {         "source": "comment",         "target": "System.History",         "mapper": "MapRendered"       },       {         "source": "status",         "target": "System.State",         "for": "Task",         "mapping": {           "values": [             {               "source": "Ready",               "target": "Ready"             },             {               "source": "Researching",               "target": "Researching"             },             {               "source": "To Do",               "target": "New"             },             {               "source": "Awaiting Feedback",               "target": "Awaiting Feedback"             },             {               "source": "Blocked",               "target": "Blocked"             },             {               "source": "In Progress",               "target": "Active"             },             {               "source": "Reviewing",               "target": "Reviewing"             },             {               "source": "Testing",               "target": "Testing"             },             {               "source": "Cancelled",               "target": "Removed"             },             {               "source": "Done",               "target": "Closed"             }           ]         }       },       {         "source": "status",         "target": "System.State",         "for": "Bug,Epic,Feature,User Story",         "mapping": {           "values": [             {               "source": "Ready",               "target": "Ready"             },             {               "source": "Researching",               "target": "Researching"             },             {               "source": "To Do",               "target": "New"             },             {               "source": "Awaiting Feedback",               "target": "Awaiting Feedback"             },             {               "source": "Blocked",               "target": "Blocked"             },             {               "source": "In Progress",               "target": "Active"             },             {               "source": "Reviewing",               "target": "Reviewing"             },             {               "source": "Testing",               "target": "Testing"             },             {               "source": "Cancelled",               "target": "Removed"             },             {               "source": "Done",               "target": "Resolved"             }           ]         }       },       {         "source": "status",         "target": "System.State",         "for": "Issue",         "mapping": {           "values": [             {               "source": "Ready",               "target": "Closed"             },             {               "source": "Researching",               "target": "Active"             },             {               "source": "To Do",               "target": "Active"             },             {               "source": "Awaiting Feedback",               "target": "Active"             },             {               "source": "Blocked",               "target": "Active"             },             {               "source": "In Progress",               "target": "Active"             },             {               "source": "Reviewing",               "target": "Active"             },             {               "source": "Testing",               "target": "Active"             },             {               "source": "Cancelled",               "target": "Closed"             },             {               "source": "Done",               "target": "Closed"             }           ]         }       },       {         "source": "Story Points",         "source-type": "name",         "target": "Microsoft.VSTS.Scheduling.Effort",         "not-for": "Task"       },       {         "source": "timeestimate",         "target": "Microsoft.VSTS.Scheduling.RemainingWork",         "mapper": "MapRemainingWork",         "for": "Bug,Task"       },       {         "source": "description",         "target": "Microsoft.VSTS.TCM.ReproSteps",         "for": "Bug"       }     ]   } }

Which version of the jira migrator are you running? Latest?

Yes!

It seems that you got the same problem like mine here: https://github.com/solidify/jira-azuredevops-migrator/discussions/415
I only got the problem on 1 AzureDevOps org and I finished all the work a couple of months ago, so I did not dig in further to understand why.

It seems that you got the same problem like mine here: #415 I only got the problem on 1 AzureDevOps org and I finished all the work a couple of months ago, so I did not dig in further to understand why.

So you are saying that it can be something related with the MS account?

Hey guys, I just notice that in the history tab the comments are assigned to the right author, however, in the "Details" tab under the "Discussion" section it shows me as the author. Any thoughts on that?

@emanuellimabr For your question, you can read the details in https://github.com/solidify/jira-azuredevops-migrator/discussions/415
It was not MS account in my case, it happened on a specific Azure DevOps org.

I have the same issue.  All comments are under my name and the date of the comment is the date I ran the import.

I have this in my configuration:
{
"source": "comment",
"target": "System.History",
"mapper": "MapRendered"
},
in ADO the history looks better, has the right user making the comment, but the date is wrong, it is today
the comment can be seen in the Discussion section and has me as the user and today as date (both wrong)

I have this in my configuration: { "source": "comment", "target": "System.History", "mapper": "MapRendered" }, in ADO the history looks better, has the right user making the comment, but the date is wrong, it is today the comment can be seen in the Discussion section and has me as the user and today as date (both wrong)

You have the same problem as me. Probably is something related to ADO, I tried using the ADO REST API and the behavior was the same.

Interestly this is working now.  So something has changed in Jira or ADO.

Interestly this is working now. So something has changed in Jira or ADO.

Yes! Somehow it got fixed!

I am also having this problem.  I am trying to export from Jira Server to Azure DevOps Cloud.  I've confirmed that the correct user and date are getting exported from Jira into the .json file, but they are all getting attributed to me in ADO, with current timestamp, when I run the tool.
I do have the comment mapper section as detailed above.  My project is setup as Agile in ADO and Agile in the config file, with the default Agile column mappings.  Also, I checked and unlike the users above, my History tab is showing the same thing as the comments under the Discussion section of the Details tab.  In both tabs, the comments are attributed to me and the date of the comment is the date I ran the import.
The comments I am trying to add are attributed to a mixture of named users in ADO from within our Active Directory and some that are without an AD login.  In all cases, I've mapped the users in the user mapping file, but neither type will get attributed.  In testing, I have created a comment using the rest api, and that does successfully attribute a comment to whatever email address I specify.
I am using the most recent version of code, I branched it a couple of months ago and just re-branched it today.  Both versions had the same problem.  But one other oddity is that it tells me that it is version 0.0.1 when it starts.  But I assume that is nothing to do with the comments problem, but just thought I should mention.  I've also tried disabling the "New Boards Hubs" setting as mentioned in this post, but it didn't change anything.
jira.config.json.txt

@Alexander-Hjelm Any news on the topic?
I have recently checked-out the latest code from master.
Exporter seems to produce the correct results as per the JSON files generated.
Importer however creates all related history and attachments with the same account the application runner uses (token owner in my case)
I am not sure if this is caused by a change on ADO API or it is somewhat a side effect of having some preview features on/off and/or used access token for importer execution not having certain rights.
It would be great to have it resolved as my migration is quite dependent on this at this stage.
I would like to know if this is a limitation as per ADO API or something else.

I am getting this issue now.  It was working sometime last year.  Not sure if it is an ADO issue or migration issue. json file looks ok though.


Add client API to dynamically change the node setup

Usecase example :
>>> subproc = pyros.PyrosROS("pyrosnode")
>>> client_conn = subproc.start()
[pyrosnode] Node started as [16657 <= ipc:///tmp/zmp-pyrosnode-IyZXtp/services.pipe]
[INFO] [WallTime:<PHONE_NUMBER>.865000] RosInterface pyrosnode node started with args : []
[INFO] [WallTime:<PHONE_NUMBER>.872728] [pyros.rosinterface.ros_interface] ROS Interface initialized with:
        -    services : []
        -    publishers : []
        -    subscribers : []
        -    params : []
        -    enable_cache : False

>>>
>>> client = pyros.PyrosClient(client_conn)
>>> client.topics()
{}
>>> client.services()
{}
>>> client.params()
{}
>>> client.setup(topics=['*'])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'PyrosClient' object has no attribute 'setup'
>>> vars(client)
{'msg_build_svc': <pyzmp.service.Service object at 0x7f5d951fb110>, 'service_svc': <pyzmp.service.Service object at 0x7f5d951fb190>, 'params_svc': <pyzmp.service.Service object at 0x7f5d951fb290>, 'topic_svc': <pyzmp.service.Service object at 0x7f5d951fb150>, 'services_svc': <pyzmp.service.Service object at 0x7f5d951fb250>, 'param_svc': <pyzmp.service.Service object at 0x7f5d951fb1d0>, 'node_name': 'pyrosnode', 'topics_svc': <pyzmp.service.Service object at 0x7f5d951fb210>}

It would be nice to be able to modify the setup of the node via the client.
We should probably do it in a way that is compatible with dynamic_configure, so that ROS user can modify this the ROS way. Check https://github.com/asmodehn/pyros-rosinterface/issues/4

Note : Currently the only way is to restart the node.
Although not ideal, it is a robust way to achieve dynamic reconfiguration.
This issue is about being able to have the same effect, without needing to restart the node.

This has been addressed here : https://github.com/asmodehn/pyros/commit/5bbc47be0526bebb7f6474a7160ce45f29b9b462 and seems to work (local manual tests)


tagged release for the latest revision doesn't exist

Hello, I saw that commit c3ee974b54f28e4044926cf1b551d103099df905 fixes ultrawide support on 1.05 (and 1.06 from my testing), but there currently isn't a tagged release including that revision.
I'm asking because i maintain the er-patcher package in nixpkgs, where we prefer to use releases rather than git revisions. Our package currently doesn't have ultrawide support on the latest version of the game.

Thanks for the reminder, somehow I never got around to it. Anyway, I published a new release which includes the most recent compatibility updates :)

Thanks, our packaged has been updated with https://github.com/NixOS/nixpkgs/pull/189249 :)


e2e for runtime version 1.4.0

Description
Check upgrade path for runtime RC versions.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

@artursouza @wcs1only @yaron2 This needs to be merged to fix failing e2e tests ... since the latest dashboard version is 0.8.0 and the e2e self hosted ones are checking for 0.7.0.


feat(tag): support custom colors

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[x] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue
close #1387
💡 需求背景和解决方案
Tag 支持自定义颜色
样式更新： https://github.com/Tencent/tdesign-common/pull/875
📝 更新日志
feat(Tag): 支持自定义颜色

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #1559 (91a2583) into develop (492d477) will increase coverage by 4.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1559      +/-   ##
===========================================
+ Coverage    57.94%   62.01%   +4.07%
===========================================
  Files          407      677     +270
  Lines        15371    16163     +792
  Branches      2931     2811     -120
===========================================
+ Hits          8907    10024    +1117
+ Misses        6187     5845     -342
- Partials       277      294      +17

Impacted Files
Coverage Δ

src/range-input/range-input-popup-props.ts
25.00% <0.00%> (-75.00%)
:arrow_down:

src/grid/row-props.ts
71.42% <0.00%> (-28.58%)
:arrow_down:

src/select/util.ts
65.00% <0.00%> (-26.67%)
:arrow_down:

src/select/props.ts
54.54% <0.00%> (-20.46%)
:arrow_down:

src/affix/affix.tsx
22.72% <0.00%> (-16.34%)
:arrow_down:

src/date-picker/props.ts
53.84% <0.00%> (-16.16%)
:arrow_down:

src/upload/props.ts
58.33% <0.00%> (-13.10%)
:arrow_down:

src/date-picker/date-range-picker-props.ts
42.85% <0.00%> (-11.69%)
:arrow_down:

src/select/optionGroup.tsx
31.57% <0.00%> (-9.60%)
:arrow_down:

src/cascader/props.ts
55.55% <0.00%> (-8.74%)
:arrow_down:

... and 474 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

关联 PR： https://github.com/Tencent/tdesign-common/pull/883


@null attribute value results in ambiguity

In a .razor component:

x

x

error CS0121: The call is ambiguous between the following methods or properties: 'RenderTreeBuilder.AddAttribute(int, string, string?)' and 'RenderTreeBuilder.AddAttribute(int, string, MulticastDelegate?)'

Note that passing null to an attribute is a supported scenario: https://learn.microsoft.com/en-us/aspnet/core/mvc/views/razor?view=aspnetcore-7.0#conditional-attribute-rendering. Although perhaps it doesn't make much sense to pass a literal @null but rather via some variable.
It also works fine in .cshtml.
Related:

https://stackoverflow.com/questions/71415039/blazor-error-the-call-is-ambiguous-between-the-following-methods-or-properties
https://github.com/dotnet/razor/issues/8731 (mentions the same error but it's otherwise unrelated to that issue)

I think compiler cannot do much here, we don't analyze the user-written C# code. At most we could offer an analyzer to fix this by casting.

@jjonescz Does this still occur when using AddComponentParameter instead of AddAttribute?

@chsienki It's not possible to use AddComponentParameter, that's only for components, this is about normal HTML elements.

@jjonescz Gotcha, thanks for the clarification.


message-model: Add zulipterminal to sent_by_human clients.

@timabbott this make server respond to messages send via zt with 'read' flag as discussed.

Merged as 2d5ef278741100461b43acd887e160ed99de450e, after tweaking it to put zulipterminal near the other Zulip clients in the list, and also document in more detail what this does.


Initialising FluentDOM query changes the underlying html

If I compare the output of
   $fd = FluentDOM::QueryCss($output, 'text/html');
   die($fd);

and
   die($output);
I notice that the the output differs. Now, I have not done a single selection or change, only loaded the html and echoed it. What it seems to do is try to close tags but the problem is that it does so incorrectly.
In the middle of a bit of javascript it breaks the document.
This is what the original looks like if I don't run it through FluentDOM at all
   ...

   }).on('error', function (event, id, name, errorReason, xhrOrXdr) {
                            $('#restricted-fine-uploader .flashmessage-error').remove();
                            $('#restricted-fine-uploader').append('
' + errorReason + 'X
');

   ...

But if it is loaded into FluentDOM and echoed right away this changes to this
   ...

   }).on('error', function (event, id, name, errorReason, xhrOrXdr) {
                            $('#restricted-fine-uploader .flashmessage-error').remove();
                            $('#restricted-fine-uploader').append('
' + errorReason + 'X</script>
</fieldset>
</form>

');

   ...

The closing of the a tag is removed and a closing script tag is instead inserted and several other tags to. My gut feeling makes me think it has something to do with issues handling scripts and text strings within scripts that contain html.

That is not specific to FluentDOM. FluentDOM load the HTML into a DOMDocument using DOMDocument::loadHtml(). It uses PHPs DOM implementation, that is based on LibXML. The method will parse and "repair" the HTML.
I am not sure why the JS breaks the LibXML parser, it think the HTML is not valid.
HTMLTidy might be able to repair it in a way that keeps the structure.

I actually did test HTMLTidy and it fixed some of these issues. But it also contained behavior that I could not configure it not to do, such as removing empty tags etc. Since the provided document does contain that (and some of them are later filled via JS) this was impossible to use. HTMTidy also seems to not have been worked on for some time. A "new" version exists that seems to be HTML5 compatible and add a lot of new features and configuration options, but it's not the version shipped with PHP. Requiring people to manually build that and recompile PHP with the correct HTMLTidy files is a dependency I would like to avoid.

Here is a HTML 5 loader/serializer for FluentDOM as well. The library converts the HTML5 into XHTML for the DOM. Maybe this can help. If you can find another library it would be possible to add a loader/serializer as well.


Feature/benchmarking scripts

Relates to #12
Wishlist:

[x] Explicit seeds
[x] Explicit wandb entity
[ ]  Shell script: algo-name, env-id, gamma, wandb entity, timesteps

@LucasAlegre very much a WIP but I think it might look like this in the end if we stick to the default hyperparameters. What do you think?


Caused by: java.lang.ClassNotFoundException: com.theokanning.openai.OpenAiHttpException

today run error

udpate api to 0.10.0 solved


Create $TMPDIR etc

@blsaws are these changes still needed?

no comments from op. closing pr as it's out of date at this point.


CORS issue with having Pusher + Ember

I am having a strange issue, when I start typing the address it throws this error,
XMLHttpRequest cannot load https://maps.googleapis.com/maps/api/geocode/json?address=Florida&region=&components=country%3AUS. Request header field X-Pusher-Socket is not allowed by Access-Control-Allow-Headers in preflight response.
The addresspicker just works fine on everyother page, but having issues with the page that has ember app on it, the ember app does have the pusher as well.

It looks like you ember app adds X-Pusher-Socket  header in XHR http request.
preflight request to google maps doesn't want to support X-Pusher-Socket. The only way I think for you to solve that is to remove the X-Pusher-Socket header.
I'm not an ember guy. I know angular. Angular has XHR interceptor. I guess ember has something similar. HTH

Yes, you are right, just found out that.
I am looking for someway in jQuery to exclude this header from addresspicker request, but no luck yet.


vqvae finetuning procedures

Hi, I'm attempting to finetune the pretrained ucf vqvae to another data set. But the reconstruction immediately deteriorate into something blurry with watery motion very quickly (~400 training steps; batch size=32).
I was wondering if there are any procedures that I need to do to for fintuneing to work (eg. setting codebook._need_init = False)?
Thanks in advance!
(sorry to bother you with such minute details :'(  )

Do reconstructions go blurry immediately? i.e. after 1 training step? If that's the case, then it should be enough to set codebook._need_init = False. Otherwise I might need to think about what else might be affecting it

Hi, how did you done the fine-tuning of a pre-trained vqvae model?
I want to load a pre-trained UCF101 model and fine tune it with my data.
am I doing it correctly?
first I load a pre-trained model using the provided function:
model = load_vqvae('ucf101_stride4x4x4')

and then I ask the trainer to continue from the checkpoint (by setting resume_from_checkpoint flag and providing the address of the model).
trainer = pl.Trainer.from_argparse_args(args, callbacks=callbacks,
                                        max_steps=200000, resume_from_checkpoint="path/to/model//ucf101_stride4x4x4", **kwargs)

trainer.fit(model, data)

is this right?
is the first part necessary? (load_vqvae) or only setting resume_from_checkpoint is enough?
thanks in advance

You should have it in the first part, because there is a strange phenomenon where the model isn't getting updated purely with:
resume_from_checkpoint="path/to/model//ucf101_stride4x4x4"
Just a heads up is that, it appears the model is stuck in some local optima, fine tuning didn't  really help for me. Love to hear if you see something similar or different.

Thank you for your reply. Yeah, to make sure, I kept them both!
I am going to use the dictionary for other purposes, I am not generating images. So, I cannot tell how it gets affected by fine-tuning. thanks again for your response


Add finally to example code for pyrealsense

I tried to run example code on readme but it failed because of SyntaxError: unexpected EOF while parsing.
I add finally to avoid the error.
Thank you.

Hi @asukiaaa
Thank you for the patch

Thank you for checking and merging.


Add println to client.execute for debug purposes

As per NCDNTS-3452 this attempts to add some "telemetry" to the client.execute method so that the consuming service can report on and use it for reproducing the issue.

This


Add year, month, day to photo indexing

@aboodman PTAL, wasn't exactly sure if you just wanted byYear then the photo set ordered by date, or if given UI needs we might want to be able to dig as needed into year, then month, and then day.

We shouldn't need this because the existing byDate index is sorted. So it
seems like it can already answer all three of these questions, right?
On Wed, Nov 2, 2016 at 7:41 PM Mike Gray<EMAIL_ADDRESS>wrote:

@aboodman https://github.com/aboodman PTAL, wasn't exactly sure if you
just wanted byYear then the photo set ordered by date, or if given UI needs
we might want to be able to dig as needed into year, then month, and then
day.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/attic-labs/noms/pull/2798#issuecomment-258053543, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE6BCi9CTJUh98LBLhOjPq_FBcsKhKXks5q6UnFgaJpZM4Kn9J-
.

What 3 questions are these? So you think we should walk or scan across the byDate index to find how many items we have for a given year? and for a given year-month combination?

Diff Coverage
File Path

•••••••••• 100%
samples/go/photo-index/main.go

Powered by Codecov. Last update 11cc65c...2852cb2

The existing byDate index can answer the questions:

what are all the items for a given year
what are all the items for a given year/month
what are all the items for a given year/month/day

In exact same number of seeks as an index from year->set<photo>. Because the index is sorted, you can seek directly to the start of a particular year (or year/month, or year/month/day). Then scanning over that is same cost as scanning a specialized index. Yay noms.

It can also answer the questions:

how many items are there for a given year?
how many items are there for a given year/month?
how many items are there for a given year/month/day?

... in not quite same efficiency as a specialized index, but still really good (logarithmic in size of byDate index).

If what you want is the answer to the latter set of questions (how many items, vs actually fetching the items), you should talk to @kalman about how best to do that. I don't know if the right API is exposed anywhere, but the index definitely contains the info you want.

I believe the efficiency of "how many items" will not be good enough for UI responsiveness. No reason to optimize this prematurely though so I have closed this PR and we can easily recreate it if needed somewhere down the line.

I can comment on an issue about this when it comes up again.
We might have to do a bit of work to expose more innards of the sequence API to figure this out.
For example, like @aboodman says, you can figure out how many items there are in a given year by getting the index at year-in-nanoseconds, the index at (year+1)-in-nanoseconds, then comparing the offsets. However I don't believe we actually expose the offsets as part of the public API. @rafael-atticlabs


Build failure on RHEL-10.0-beta with GCC 14

gcc -DHAVE_CONFIG_H -I.  -DNDEBUG -Ivendor/lua/src -Ivendor/liburing/src/include   -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64-v3 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2    -pthread -pthread  -Wall -pedantic -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -c -o memcached-proxy_lua.o `test -f 'proxy_lua.c' || echo './'`proxy_lua.c
In file included from /usr/lib/gcc/x86_64-redhat-linux/14/include/x86gprintrin.h:33,
                 from /usr/lib/gcc/x86_64-redhat-linux/14/include/immintrin.h:27,
                 from xxhash.h:2585,
                 from proxy.h:33,
                 from proxy_lua.c:3:
proxy_lua.c:1398:24: error: expected declaration specifiers or ‘...’ before ‘(’ token
 1398 | static inline uint32_t _rotl(const uint32_t x, int k) {
      |                        ^~~~~
proxy_lua.c:1398:24: error: expected declaration specifiers or ‘...’ before ‘(’ token
 1398 | static inline uint32_t _rotl(const uint32_t x, int k) {
      |                        ^~~~~

thanks for the report! I've made that dumb mistake a few times with short function names. That error however, makes no sense to me.
I've renamed a few of those functions and pushed the fix to next. can you confirm it's fixed? I'd love to know why but don't have the time to research it right now :(

I'd love to know why but don't have the time to research it right now :(

Additional information
This only happen in RHEL-10 which use -march=x86-64-v3
Switching back to -march=x86-64-v2 like in RHEL-9 also fixes the issue.

can you confirm it's fixed?

I confirm 1.6.32 + 08b00579fd9d2abd5d5116bbda27f8eceaba6038 fixes this issue
Thanks

Thanks for confirming!
A new release should be within a week.

Also, found in /usr/lib/gcc/x86_64-redhat-linux/14/include/ia32intrin.h
/* 32bit rol */
extern __inline unsigned int
__attribute__((__gnu_inline__, __always_inline__, __artificial__))
__rold (unsigned int __X, int __C)
{
  __C &= 31;
  return (__X << __C) | (__X >> (-__C & 31));
}

#define _rotl(a,b)		__rold((a), (b))


APIView - New restructure change is taking long time to load

APIView is taking too long to load revisions.

Lowered the priority because users are not asking for this.
We will bring proposals to the architects so they can help us make the best decision on how to handle this scenario

Bringing priority up as architects started facing this issue in big APIs like for example the python ml team


Meta short description

Changed short_description to be pulled from the item instead of making up a value

Coverage decreased (-0.02%) to 95.735% when pulling 8a6f3368a0916654b85f5180b7c556a01af51572 on DEC-1342-Meta-short-description into<PHONE_NUMBER>9327c9c7594a9843a6a1184318cf71 on master.


Add vector agent config to stargate

What this PR does:
Adds ability to configure Vector as a sidecar for Stargate and Reaper
Which issue(s) this PR fixes:
Fixes #790
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[ ] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

Codecov Report

Merging #819 (07ccb28) into main (5040b3f) will decrease coverage by 0.42%.
The diff coverage is 44.79%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   56.78%   56.36%   -0.42%
==========================================
  Files          91       94       +3
  Lines        9152     9346     +194
==========================================
+ Hits         5197     5268      +71
- Misses       3488     3602     +114
- Partials      467      476       +9

Impacted Files
Coverage Δ

pkg/stargate/config.go
0.00% <ø> (ø)

pkg/telemetry/cassandra_metrics_filters.go
100.00% <ø> (ø)

pkg/utils/deployment.go
0.00% <0.00%> (ø)

controllers/stargate/vector.go
43.36% <43.36%> (ø)

controllers/stargate/stargate_controller.go
45.87% <44.44%> (-1.61%)
:arrow_down:

pkg/stargate/vector.go
62.50% <62.50%> (ø)

pkg/cassandra/datacenter.go
68.71% <100.00%> (ø)

pkg/nodeconfig/mount.go
100.00% <100.00%> (ø)

pkg/stargate/deployments.go
92.83% <100.00%> (+0.01%)
:arrow_up:

pkg/telemetry/vector.go
86.40% <100.00%> (+0.78%)
:arrow_up:

... and 1 more


Fix error handling in LocalFileWriteHandler#createBasePath()

What changes were proposed in this pull request?
Fix error handling in LocalFileWriteHandler#createBasePath().
Throw an RuntimeException in case of failure.
Note: raw use of RuntimeException is not a good practice.
But in this case, it will be propagated to a lambda.
Why are the changes needed?
The return value of baseFolder.mkdirs() was ignored.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.

Codecov Report

Merging #537 (663001f) into master (721b22c) will increase coverage by 4.08%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master     #537      +/-   ##
============================================
+ Coverage     60.23%   64.31%   +4.08%
+ Complexity     1785     1652     -133
============================================
  Files           205      186      -19
  Lines         11557     9114    -2443
  Branches       1042      918     -124
============================================
- Hits           6961     5862    -1099
+ Misses         4189     2936    -1253
+ Partials        407      316      -91

Impacted Files
Coverage Δ

...le/storage/handler/impl/LocalFileWriteHandler.java
80.00% <33.33%> (+4.48%)
:arrow_up:

...ategy/storage/AppBalanceSelectStorageStrategy.java
72.00% <0.00%> (-4.00%)
:arrow_down:

.../hadoop/mapreduce/task/reduce/RssBypassWriter.java

.../hadoop/mapreduce/task/reduce/RssEventFetcher.java

...oy/kubernetes/operator/pkg/controller/util/util.go

...n/java/org/apache/hadoop/mapreduce/RssMRUtils.java

...rg/apache/hadoop/mapred/RssMapOutputCollector.java

...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java

...java/org/apache/hadoop/mapred/SortWriteBuffer.java

...y/kubernetes/operator/pkg/webhook/inspector/rss.go

... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks @advancedxy and @zuston for the review.


Implement new user onboarding flow season

Rabbit season

Flaky Test
Failure Summary
Logs

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

[chromium] should return list of users correctly.
The API call to get the list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

Test_InternalServerError
failure_message: Failedfailure_text: === RUN   Test_InternalServerError    api_test.go:39: Internal server error occurred--- FAIL: Test_Intern...
Logs ↗

View Full Report ↗ ⋅ Docs


Looting / Selling problem

Regardless of lotting or converting the items to coin. The chat message shows up but I do not see the item removed from the NPC and added to my character sheet.

Ahh.. Nevermind it was because when the item is broken it doesn't get added to the character sheet.


Usage with PagedListEpoxyController?

Any good source code example how to use MvRx together with PagedListEpoxyController and state/error handling?

Duplicate of #216


cmd/go: replace directive mutated when run go mod tidy

What version of Go are you using (go version)?

$ go version
go version go1.14.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/slinkydeveloper/.cache/go-build"
GOENV="/home/slinkydeveloper/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/slinkydeveloper/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/usr/lib/golang"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build499797199=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I'm trying to test a personal fork of a dependency in a project, and i'm using the replace directive as follows:
knative.dev/pkg => github.com/slinkydeveloper/pkg serious_port_forwarding

For some reason, when i run go mod tidy to update the deps, the replace directive is mutated replacing it with the actual commit hash
knative.dev/pkg => github.com/slinkydeveloper/pkg v0.0.0-20200724072217-fc14798189e0

which means that every time i update my fork, i need to update the directive and retrigger the update with go mod tidy
What did you expect to see?
replace directive should not mutate. To be precise, I expect them to be immutable in all situations because they're hand made directives to instruct to tool where and which versions of the code to pick
What did you see instead?
replace directive mutates.

The go.mod file is intended to provide reproducible builds. A branch that may move is (by definition) not reproducible, so this is working as designed.

I think #32721 and #26964 would suffice to allow a replace directive to be upgraded following a branch.

Duplicate of #32721


DT Change and improve text for HELP page

Improve text  MVP quality text on Help page. May take a couple of iterations!

[ ] add header, side bar, etc. for CSS.
[ ] needs to refer to the screens and processes on FreeBMD2, not FreeBMD1
[ ] accessibility

Addigning @ComfE-2662 as now being undertaken by Philip and others on the development team

Hi @PhilipClarke712 could you switch the first two sections of 'Help' please - I think that people will want to see information about searching before information about accuracy.

Hi @PhilipClarke712 could you switch the first two sections of 'Help' please - I think that people will want to see information about searching before information about accuracy.

@PatReynolds
Yes, I will do that today on test3 on a Draft page. That is less than five minutes work (unless I break something).
I will get into trouble if I change the Help page since that is not a Draft page (so changes have to be signed off).

@PatReynolds
Yes, I will do that today on test3 on a Draft page. That is less than five minutes work (unless I break something).
I will get into trouble if I change the Help page since that is not a Draft page (so changes have to be signed off).

Hi @AlOneill,
As discussed elsewhere, could you review https://test3.freebmd.org.uk/cms/help/draft-help-1st-interim-version .
It is a reworking of a copy of the current Help page: no new content has been added other than adding on-page-hyperlinks and outline-hyperlinks to other pages, some of which are interim versions.
I've removed content relating to facilities (on FreeBMD1) that test3 does not currently offer - so at some time in the future it will need to be revised and resubmitted (normal maintence).
It has outline-hyperlinks to other five or six pages (perhaps more), so I will be send them along quite soon. It also has a working hyperlink to the About page.

@PhilipClarke712 review underway.
I was a little disappointed to see the non-alignment of the leading paragraph in the browser — that sort of thing should be jumping out at you! Also, you did not validate the HTML — the use of a validator to find errors is a great way to learn as well as a useful tool for assessing a page.

I've reviewed and returned this draft Help page to Refinery. It cannot be signed off as it stands — see the comments at the top and throughout the page.
I've reviewed the markup, commented on the structure, fixed some typos and made some general suggestions. There are a couple of places where I do not understand what is being said or the thought appears incomplete.
I've put the Soundex info box in its proper place — please be careful if you need to edit around it!

Hi @AlOneill,
Thanks for your review, comments, and for fixing the Soundex side panel.
I was only expecting this to be an interim version of the Help page: we have a common side navigation panel for all three FreeGen sites, and not all sites appear to make use each heading on their navigation-panels. This page does use all the links, but two sections are not being "populated" in this version of the page - and are marked as such.  Furthermore, some its intended sub-pages will be implemented in post-MVP version(s).
We are both in agreement there should be no pseudo-links. I thought that I had taken them all out. Sorry about that.
Note: the original version of this page did not use mark-down hyperlinks, so in some cases I had to go back to FreeBMD(1) to see what the link should be. Some such links are to pages that have been partially merged or will not be implemented for MVP. I intend to leave the pseudo-links in on a copy of this page to remind myself when working on updates to this Help page.
I will work on your comments.
Note: this page has five mark-down-style hyperlinks and some of these have their own mark-down-style hyperlinks, so you will be get more pages to look at. I had hope to do some work on these while you were reviewing this page, but I switched to the About page, and then ran out of time.

Hi @AlOneill
I'm sending https://test3.freebmd.org.uk/cms/help/draft-help-1st-interim-version back to you for re-review.
I beleive all the issues raised have been addressed either by reworking and/or adding new material, or by removal of text relating to functions not yet impliemented on test3. Sorry - that may involve a full review.
I'm also send https://test3.freebmd.org.uk/cms/help/draft-help-1st-interim-version which is a cut-down version of a page previously reviewed under its own story. It is one of about five or six pages referenced from Help via mark-up hyperlinks. It contains some amedments arising from issues raised in its review. This is the only page called up by mark-up hyperlinks that is "ready for review" in my oppinion.
Hi @PatReynolds
Having forwarded these two page to Alsion for re-review. I am now unavailable in respect of FreeBMD documentation unitil my return on 5th July.

@PhilipClarke712 You have passed me the same page twice, rather than two different pages. Please clarify what the second page is. Thanks.

Hi @AlOneill
Sorry, the second one should have been:  https://test3.freebmd.org.uk/cms/help/draft-civil-registration-through-the-gro-w-in-p/draft-districts-volumes-and-pages-interim-version
The directory path is somewhat convoluted as I originally had its parent page within Transcriptions, Coverage, or Records (that name has been subject to change over the last 14 months). The directory path can be shortened if you like.

With testing due to begin soon, Pat and I have worked on restructuring the "draft Help (1st interim version)" page, re-writing it as 3 pages so that the:

language is more friendly and the pages are more inviting to read

information is accurate for the current  layout of the form and capability of the BMD2 search (rather than for BMD1 or REG!)

pages are not cluttered with multiple promises of help and information that is not yet ready to be published

We have spent considerable time testing various aspects and features of the search, but certainly could've got something wrong. If you believe that something has been cut in error or that something important has been missed out, please report it here — rather than edit one of the pages.
The pages to be reviewed are:
https://test3.freebmd.org.uk/cms/draft-help-for-mvp
https://test3.freebmd.org.uk/cms/draft-help-for-mvp/draft-more-about-searching
https://test3.freebmd.org.uk/cms/draft-help-for-mvp/draft-more-about-names
I'm working on inserting the images, updating the "Detail Information" images now that the name casing has been fixed :-)

Hi @AlOneill
You have hit the nail on the head. The page is more user friendly, I agree with that, but it started off as a straight copy and paste of the REG Help Page - including its header colours (light brown font colour ) and I suspect that page might have come from an amalgamation of several BMD1 pages.  My task was not to do a wholesale rewrite and not really to add new material (but I have added new material), it was more about putting hyperlinks to BMD2 pages that did not even have markup-style hyperlinking and improving the grammar, etc.
The goal posts got moved during review: however, users will get better page(s). I don't recognise this as a REG help page: so commonality has gone, well unless REG now copy and paste these Help page(s)
I believe it was you that indicated that some people work across all three sites so commonality was a good thing: that is where the promises come from, the side navigate panels are also identical across the three sites and some links were blind links.
I don't  accept that is a BMD1 help page, I spent several weeks running searches on test3, and that is what I've raised several stories on GitHub - information that is in the GRO Index was not being provided on test3.  Some of which has fixed, but not all. The page  I sent you describes how you might use test3 for searching and what it provides; not the way BMD1 does it.
I was intending to send more of the pages to review, these were sub- pages called up in outline mark-up, but they don't appear to be needed any more.
The one thing that I would note is that there is a story to remove the word Postem and replace it with a friendly version. BMD 2 still uses Postem, as does this page.  My Postem help page, which is unfinished because there was almost nothing to search for on test3, was originally called Add a Note , but every instance was changed back to Postem, because test3 used Postem. I don't know if Add a Note is *still) the intended replacement - the story does not state what Postem is to be replaced by.

@PhilipClarke712 Yes, the pages are more user-friendly — an essential improvement now that we have the opportunity to work directly on pages such as 'Help'. A style of writing that is in line with a magazine article rather than a technical manual is what I've been trying to encourage.
Thank you for the testing that you have done. Let's not quibble about which bits of inaccurate (for BMD2 as it is currently) information are left over from where or what. The point is that, for testing and the MVP, we need accurate, current information. For instance, the description of the options in the 'Age at death' drop-down was wrong in part; and I could find no evidence that selecting 'Phonetic search on surnames' applies currently to 'Spouse surname'.
Some, if not all of the sub-pages you mention will be needed in due course. Let's see what feedback we get from testing and then adjust the timing of what we release and when.
The story about 'Postems' is still at an early stage — there will be more discussion before a decision is made. We will have to update the relevant terminology if and when that becomes necessary.

@AlOneill ,
Thank you for your comments. It is interesting that we have very different view points on quite a small number of topics.
I did no testing of Age at death searches and I did no testing of Phonetic searches. I've never used phonetic searching on BMD1 (and I have been using it for research for about 16 years) neither have I attempted to do so in test3. It is good that you found and corrected errors.
Yes I agree that the latest  #352 Postem story may be at an early stage. Last year the requirement was to call the dedicated "Postem" Help page "Add a Note". That was discussed in #133 last November when #165 was opened. #352 is a reminder that  Postem should be replaced with something friendlier. Perhaps that change is not needed for Beta testing.
Work allocation on documentation was governed by what was specified at that time as MPV and what was not MPV. That was covered by #247, which was closed last December.  I am content to slow down or stop. Apart from the need to have both the Help and the About pages ready for Beta testing  (a date that is unknown to me), your comment above is the first I've heard about moderating how and when I send MVP pages to you, if that is a correct paraphrasing of your statement above.

@AlOneill
Sorry, I need to correct one statement, above that on reflect was wrong.
I have a family tree stored my my computer so I have relatives for which I know their dates of birth and dates of death. I did some testing using them as examples.
The GRO index did not have age at death before 1st Jan. 1866, so I tested either side of that that year, I also tried, for those limited samples, doing searches using the Match only recorded dates. I believe that the draft Help page I sent did describe what test3 could do.
I can only assume that your comments apply to the paragraph:
........ comprehensible (for example, 31JE1910) unless Match only recorded ages/DoB is specified. The search results will include the approximate dates of birth, for example if you search for 23/7/1910 you would get entries that had -JY1910 or about 1909 as the Date of Birth
I did not try and test any of those claims. Its a rather small paragraph on very large page - I would not like to view that on a smart phone, but page size was never raised during your first review of Help  one month ago, as of now.

Images added to pages (edited name-casing and font of 'Page' in browser for screen-shots neither issue fixed yet).

Hi @AlOneill
You may wish to re-review the  section Middle names and initials within  the draft Help Page More about names.
The first FIXME link is to a page Summary - use of  initials in Forenames which exists in draft form and is complete in what it intends to do, but it does have a non-data data-table in it. That page has not be sent for review: it might perhaps be acceptable if the table was made say into a definition list,  That would not take particularly long to do if that is the way forward.
The second FIXME should go to the, same, summary page. On BMD1 it went to the long-version of that page. This page does exist as a full width page (not 3/5 +2/5 ths), work-in-progress, and three subpages of data tables, but they are not suitable for use. I suspect from the data in the data-tables it was produced on BMD1 about 18 months ago as it starts to run out of date after 1989

@PhilipClarke712
The immediate solution for those FIXME links is either to promise that information will be available soon or to remove all mention of such information for now — it all depends on how quickly the "Summary — …" can be made ready for publication and how important it is for successful searching.
My feeling is that the Summary is highly unlikely to be ready for testing and MVP as there is a lot of work to do: the language of the page is not accessible to the general reader, the table is inappropriate (as you rightly say) and the best way to present the information is not obvious — changing the markup alone might not be enough.
Deciding between a promise for soon and removing all mention is less obvious — it boils down to the importance of the details in it to a Researcher. How often do you consult those details? Or, do you decide on how to search using forenames and initials in a different way, one determined by your experience and that could be tricky to describe? (Do treat those questions as rhetorical — only there to provoke thought!!)
So, is the Summary important enough to be a priority (the soon option) or is the advice offered on 'More about names' enough for a good while?

@AlOneill
The proof is the numbers in https://www.freebmd.org.uk/givenname-initials.html but not one is going to look at that and take it all in.
Much of the text in the summary part of that page is already in Refinery in various drafts of Help, so its sort of "padding" on top of a table in a separate a summary page.
My inclination would be to drop just that summary "table" wholesale into the Middle names and initials section, say as an set of paragraphs or list; or into  More about names as an annex / appendix. But, not as a table.
So this in words, possibly as a ordered list, is:
e.g Between 1837 qtr 3 and 1865 qtr the GRO index showed the forenames in full with very few truncated as  (minimised to)
the first initial of each name ..... but there are two anomolous quarters of ....
1910 to 1965 it's just the first full name and any initials .........
What follows in a partial capture of the table that gets converted into formatted text.

If our simple advice to search on forenames, to use the first forename plus the next initial, works in pretty much all situations, then why complicate that with the Summary information on the same page?
My testing indicates that a search on say 'john f' would also find 'John Frederick', 'John Francis' and so on. Is that not sufficient here?
My feeling is that the Summary would be of interest to only some users and is not essential for a successful search. Let the Scrum decide?

The quickest and least effort option is to remove those two FIXME and some text in brackets.
I don't personally read the how to search page(s), now, on BMD1 before I search.
I did at one time if, say, I found only one half of a marriage pair. Soon, I knew how to look at Coverage charts - so my first check would be "how much" of that data-set had been transcribed; and than I would be looking at UCF entries / mis-indexing / mis-transcriptions of that page number and volume number.

@PhilipClarke712 Once you have completed your checks and corrections to the Summary, let's have another look at how to present the information — I'm thinking that a diagram, a 3-stranded timeline perhaps, might be a good idea to explore (as an adjunct to any text, for users who can see).
The other topics that you mention — UCF entries, miss-indexing (or miss-transcription) of page and volume numbers — could also be candidates for updating soon. Keep thinking about what would be most useful for a Researcher.

@PatReynolds @DeniseColbert @PhilipClarke712
I'll be promoting the three DRAFT pages to 'Help', 'More about names' and 'More about searching' tomorrow, Wednesday. I'll do my best to avoid broken links and other awkwardness during the process.
The remaining three versions of the Help page (!) will remain in place temporarily (as re-named pages), pending deletion on Friday.
@PhilipClarke712 if there is text on any of those pages that you need to get a copy of, please do so before Friday.
Any future changes to 'Help' must be based on the new, plain 'Help'.

@AlOneill ,
1. As of yesterday's threads, I was working the basis that we would not be using the summary page as-is for beta, so it has not changed - it still has a non-compliant table.
What I did was to take a copy of the non-data table and convert it into a definition list and put it on to html page that only has a level four header (it is not a proper or full page). That is  now to be found at https://test3.freebmd.org.uk/cms/help/draft-summary-use-of-initials-in-forenames/draft-replacement-text-for-non-data-table . I started making changes to the words, but I have not worked my way down the whole page, so inconsistent coverage - which you are likely to notice. It would help to know if the information in the page is to be used (see below) as I will need to finish it.
Potentially there are three or four ways forward. (1) don't make any use of the summary, in any way, for beta; (2) use the replacement text for non-data table and copy and paste it into more about searching  as a level four section ; (3) make the replacement page into a proper page and use it as a sub-page of   more about searching  ; (4) over-write the table in the summary page with the  replacement text and use that page as a sub-page of presumably  more about searching . I'm tending to discount option four as there is a lot of duplication between more about searching and the summary page.
So, I need to know what the decision is, because I might need to finish it and to either copy it or possibly make a full page.
2.  I will take an off-line copy of the Help (1st interim version) because that will have the scope of what I anticipated would be in the Help page, together with a the mark-up hyperlinks. Obviously the means by which the information is communicated has changed.
3. This is going a bit off topic, but there is another story for https://test3.freebmd.org.uk/cms/help/draft-reporting-errors-in-transcriptions and that has two mark up hyperlinks that are not ready (reviewed). One to a Postem page that is not ready (so I might just remove the reference) and to Help with Marriages. That page was not ready for signing off earlier this year because pages hyperlinked to it were not ready. It does not look anything like the new Help page - but we could copy sections out of it. There is now a lot of common ground between Help and Help with Marriages. If we use Help with Marriages it will need to be decluttered.

Should now be pushed into test3. User testing can then dictate what changes come next.


Issue 3541 - Add -oq to dmd (use fully qualified module name as object filename)

Issue 3541 - Add -oq to dmd (use fully qualified module name as object filename).
Trying this again, I've just updated my fork. I have tested this on Mac OS X by running the Phobos unit tests and they all DO PASS. The command line I used to run the unit tests was "make unittest".
http://d.puremagic.com/issues/show_bug.cgi?id=3541

It would be nice to also include a pull request for the documentation to add documentation for -oq

Sigh. Windows still fails to build the phobos unittests with this patch. I'm going to have to revert it again. I want to emphasize that existing behavior must not change if -oq is not used - we cannot break peoples' existing build processes.

..\dmd -O -nofloat -w -d -property -L/co -unittest unittest.d std\variant.d  std
\stream.d std\socket.d std\socketstream.d  std\perf.d std\container.d std\conv.d
std\zip.d std\cstream.d std\loader.d  std__fileinit.d  std\datebase.d  std\re
gex.d  std\stdarg.d  std\stdint.d  std\json.d  std\parallelism.d  std\gregorian.
d  std\mathspecial.d  std\internal\math\biguintcore.d  std\internal\math\biguint
noasm.d std\internal\math\biguintx86.d  std\internal\math\gammafunction.d std\in
ternal\math\errorfunction.d  std\internal\windows\advapi32.d  crc32.d  std\c\pro
cess.d  std\c\stdarg.d  std\c\stddef.d  std\c\stdlib.d  std\c\string.d  std\c\ti
me.d  std\c\math.d  std\c\windows\com.d  std\c\windows\stat.d  std\c\windows\win
dows.d  std\c\windows\winsock.d  std\windows\charset.d  std\windows\iunknown.d
std\windows\registry.d  std\windows\syserror.d unittest11.obj unittest12.obj uni
ttest2.obj  etc\c\zlib\zlib.lib ..\druntime\lib\druntime.lib
std.contracts has been scheduled for deprecation. Please use std.exception inste
ad.
Notice: As of Phobos 2.055, std.date and std.dateparse have been deprecated. The
y will be removed in February 2012. Please use std.datetime instead.
std.perf has been scheduled for deprecation. Please use std.datetime instead.
Notice: As of Phobos 2.055, std.regexp has been deprecated. It will be removed i
n February 2012. Please use std.regex instead.
std.stdarg is deprecated.  You should import core.vararg instead.
Notice: As of Phobos 2.055, std.gregorian has been deprecated. It will be remove
d in February 2012. Please use std.datetime instead.
unittest
Error: 'unittest' not found
--- errorlevel 1

Also, please do not use tabs in source files.

I guess I have to try and test this on Windows. I apologize for the problems this has caused. I'll fix the tabs and documentation in a, hopefully, upcoming pull request.


title of window changes fail when WindowState's height and width are unspecified

can change title
fun main() = application {
    var title by remember { mutableStateOf("") }

    Window(
        onCloseRequest = ::exitApplication,
        title = title,
        state = WindowState()
    ) {

        OutlinedTextField(
            value = title,
            onValueChange = {
                title = it
            })
    }
}

can't change title
fun main() = application {
    var title by remember { mutableStateOf("") }

    Window(
        onCloseRequest = ::exitApplication,
        title = title,
        state = WindowState(width = Dp.Unspecified, height = Dp.Unspecified)
    ) {

        OutlinedTextField(
            value = title,
            onValueChange = {
                title = it
            })
    }
}

Will rememberWindowState fix the issue?
fun main() = application {
    var title by remember { mutableStateOf("") }

    Window(
        onCloseRequest = ::exitApplication,
        title = title,
        state = rememberWindowState(width = Dp.Unspecified, height = Dp.Unspecified)
    ) {

        OutlinedTextField(
            value = title,
            onValueChange = {
                title = it
            })
    }
}

WindowState isn't right thing to use in Composable functions.

In fact, this is a simplification of the official example Noetpad. In this program, rememberWindowState is used, but it doesn't fix the issue

Is the issue still exist, if you change the version of Compose to 1.0.0-alpha4-build328?
I can't reproduce it on this version

Yes, I see. This seems to be a bug that only occurs in the alpha3 version, and does not appear in the alpha4

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Added new recursion control per type

I've added a recursion control per type (addUpdatedIdsForType). This allows to implement a recursion control on multiple trigger handlers of the same trigger which does not affect each other. This follows the idea that the trigger handlers are independent and don't need to know about each other.
Let me know if this works for you. It should not affect any current implementations as I didn't change the signature of any global methods.
Also works with namespaced classes as Type.getName() returns the fully qualified name.

Thanks for the review!
Can you elaborate a bit on what you mean by "have the dirty ids always tracked as simple set as well as sorted by type"
Are you thinking on something else than the following newly introduced variable:
static Map<string, Set> alreadyUpdatedIdsForType = new Map<string, Set>();
Would you want to have another set as a union of all the sets of the map? What would be the purpose of this set?

What do you mean by that:
MyTriggers.getRecordsNotYetProcessed(); should have MyTriggers.getRecordsNotYetProcessedForType();

Should I basically have 2 methods: 1 method with the old logic (named MyTriggers.getRecordsNotYetProcessed()) and 1 method containing the new logic (named: MyTriggers.getRecordsNotYetProcessedForType();)?
I don't see the purpose of having two methods. If you want to use it per type, use this.addUpdatedIdsForType() to add Ids per Type. If not, don't set ids any ids there. But I can also change that.

Here's my question, @rolandfuchsberger
Would the following amount to similar results?

Create a (long) Text field on sObject. Call it HasSeenMyTrigger__c
have myTrigger implementation write/read this field accordingly

Would it not also provide the benefit for those in need such a functionality to have a sort of execution log for debugging purposes? Otherwise it could be nullified before DML.

Might be considered at a later time.


Provide direct access to all tokens: id_token, access_token and refresh_token

The OpenID Connect middleware can be configured with any OpenIdConnectResponseType, i.e.:
options.ResponseType = OpenIdConnectResponseType.IdTokenToken
However, using the above setting, the middleware doesn't appear give any way to get the access_token.  For the hyrid auth code flow, all the docs show adding a handler to manually exchange the auth code for the access_token (using ADAL or MSAL):
     OnAuthorizationCodeReceived = async (context) =>
                    {
                        var code = context.ProtocolMessage.Code;
                        var identifier = context.Principal.FindFirst(Startup.ObjectIdentifierType).Value;
                        var memoryCache = context.HttpContext.RequestServices.GetRequiredService<IMemoryCache>();
                        var graphScopes = _azureOptions.GraphScopes.Split(new[] { ' ' }, StringSplitOptions.RemoveEmptyEntries);

                        var cca = new ConfidentialClientApplication(
                            _azureOptions.Aadv2ClientId,
                            _azureOptions.BaseUrl + _azureOptions.CallbackPath,
                            new ClientCredential(_azureOptions.Aadv2ClientSecret),
                            new AzureAd2SessionTokenCache(identifier, memoryCache).GetCacheInstance(),
                            null);
                        var result = await cca.AcquireTokenByAuthorizationCodeAsync(code, graphScopes);

                        context.HandleCodeRedemption(result.AccessToken, result.IdToken);
                    },

I'd like to be able to let the OpenID connect middleware complete the hybrid implicit or auth code flow and get access to the access_token, refresh_token (for auth code).
I don't understand why allow the middleware is able to complete the implicit or auth code flows automatically, but doesn't provide access to the tokens.
This doesn't make any sense to me.  Having to write code to manually exchange the auth code for the access_token seems messy and error prone.  I see this provides access to a token cache, but the middleware could do this as well.

Provide access to them where? SaveTokens?

The purpose SaveTokens isn't clear.  The comment is "Defines whether access and refresh tokens should be stored in the Microsoft.AspNetCore.Http.Authentication.AuthenticationProperties after a successful authorization."  How can I get access to AuthenticationProperties in order to get access to the saved tokens?  As to where in the code I would like to access the tokens, I would like to access them in the appropriate event handler.  OnTicketReceived seems to be the last one called.

In OnTicketReceived, the context object has the AuthenticationProperties on it. You can get tokens from there by calling GetToken(name).
This sample does something similar:
https://github.com/aspnet/AuthSamples/blob/404105bd191f2e973d4befb668f1310d2fd82701/samples/Identity.ExternalClaims/Startup.cs#L48

Thanks! This is really obscure :-), but exactly what I was looking for.  There are situations where letting the OpenID Connect middleware complete the OAuth flow makes more sense than including ADAL and MSAL and splitting the flow between 2 libraries.  I just needed to know how to get to the tokens!

Is there also a way to access AuthenticationProperties from a Controller?  If not, what is the recommended way to pass state from middelware (OnTicketReceived) to the Controller?

Yes, you call HttpContext.AuthenticateAsync().

Cool. Again, very useful but needs documentation. By the name it sounds like its possibly doing another authentication (if necessary).  Does this work like ADAL/MSAL and refresh the access token in the background?

No, it's returning cached results from prior calls to AuthenticateAsync on that request.

I would suggest a different name for the method then, perhaps GetAuthenticationProperties with or without the Async suffix.


fix-stuck-blog

Removes publishDate metadata that was supposed to prevent the blog from appearing on the site too early, but which didn't seem to let it appear once that time has passsed.

@patrick-stephens @edsiper for review


machocopy example

Hi, we're trying to reimplement patchelf and install_name_tool with object and at least for patchelf it seems quite straightforward with the elfcopy example :)
For install_name_tool I seem to miss a way to add load_commands to the writer. Reading the MachO file works well (we're mostly interested in patching / changing the rpath to something relative), and I can read the rpath nicely.
I was wondering if you have a quick tip on how to achieve this.

There isn't a way to write MachO executables yet, so there's no machocopy. We need to add the equivalent of write::elf::Writer for MachO. This isn't a small task.

Thanks for the hint!
Do you think there is a shortcut if all we want is to rewrite an rpath in the MachO file? We're happy to contribute.
Also if you can give me any hints on how to start this endeavor, that would be cool.

If I understand correctly, rewriting the rpath is conceptually simple: you just want to change the string in the load command for LC_RPATH. The catch is that doing so may change the file offsets of other data, so you still need to parse some of the other load  commands and fix the file offsets if needed.
src/write/macho.rs already has code for writing some parts of a Mach-O file. Ideally some of that code would be moved into a write::macho::Writer that can be used by both write::Object and your utility. However, starting with something that only meets your needs would be fine, and write::Object can be migrated later.
I would start by implementing something that treats all of the load commands as opaque blocks, and then progressively add support for the load commands that need further parsing.


[addition]Readme.md file (Documentation)

Hi @noelty ,
I kindly suggest creating a Readme.md file for the project and subsequently adding comprehensive documentation. This will greatly enhance the project's accessibility and user-friendliness. I'm enthusiastic about contributing to this effort and would like to inquire if I could work on it.
Thank You!

Ok you can work on it