to add progress bar at all the required pages ...

please assign me this issue under gssoc extd 24,
please make it level 2
@mdazfar2

Hey @2004pra, I don't exactly understand what you're trying to say. You described it in just two sentences, which doesn't clearly explain what you want to work on. Please don't do that.
You raised a blank issue. You should choose the appropriate issue template and describe it accordingly, as the chosen template will clarify what you want to work on. I will be happy to assign issues that are clearly understandable. Please keep this in mind—I'm not instructing you, just trying to show the correct roadmap for working on open source. Please don't be discouraged; I am closing this issue for now.

There is a feature called progress bar which goes to the end of website top
horizontally it’s a thin line which gets completed as you scroll  down and
gets unfilled if you scroll up again ! Simple
On Fri, 8 Nov 2024 at 10:38 PM, github-actions[bot] <
@.***> wrote:

Hello 2004pra! Thanks for opening an issue in Ezyshop! 🚀

We'll get back to you as soon as possible.
Hope you star our Repo https://github.com/mdazfar2/Ezyshop.
Join our Discord Server https://discord.gg/YnABU7tdU3 to collaborate
and discuss further.
—
Reply to this email directly, view it on GitHub
https://github.com/mdazfar2/Ezyshop/issues/1104#issuecomment-2465300678,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYRCFRM7NPFPY5N2RCYQQNDZ7TVZFAVCNFSM6AAAAABRN5EACOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGMYDANRXHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

see this red bar as a sample -->

@mdazfar2

@2004pra, this is a very good feature, but it does not look good on our website. According to our website's design, a simpler effect and feature will look more attractive. So, as of now, I don’t think this issue is necessary for our website. Please work on any other issue that is needed and raise issues accordingly. Thank you!

@2004pra, this is a very good feature, but it does not look good on our website. According to our website's design, a simpler effect and feature will look more attractive. So, as of now, I don’t think this issue is necessary for our website. Please work on any other issue that is needed and raise issues accordingly. Thank you!

it will be slim and will match the theme of the website  too
you dont have to worry it will surely look attractive sir .. not too flashy decent

Please assign me this issue, I will work on it


3.5 beta release branching

3.5 beta branch info

Repo
Branch
Commit
g3 CL

flutter/flutter
flutter-3.4-candidate.34
https://github.com/flutter/flutter/commit/fb8dcb8e279ff491b2c5eff876271cce75880019
cl/477991292

flutter/engine
flutter-3.4-candidate.34
https://github.com/flutter/engine/commit/39f77208c76d43cd7d7c2c0c98ce6c5d57f4914f
N/A

dart-lang/sdk
2.19.0-255.0.dev
https://github.com/dart-lang/sdk/commit/8c19c7bd38b44af872de3a7cb97713bb83ca4fb8
cl/477996642

google/skia
as needed
https://github.com/google/skia/commit/23d7b1c4369ce70efb9906443f618483b06087f8
N/A

@itsjustkevin @godofredoc @athomas

@itsjustkevin I believe we can close this bug, am I correct?


Fix multiline ProgressBar erasing previous output line

Previously, if your progress bar was multiline, its initial display would erase the line above it in the console output. This PR fixes that.

Thanks for contributing this pull request. However, the repositories of individual Symfony Components are read-only, so pull requests are ignored. Please, submit this pull request to the main Symfony repository at https://github.com/symfony/symfony/pulls
Thank you!

Thanks for this PR. Yet I invite you to submit it on the main symfony/symfony repository: this is where merges happen. Note that you should add test cases while doing so. Cheers.


Feature Request: Migration dependencies

A constant headache, particularly with testing, is running a migration that modifies a table from another migration but that table isn't created yet because the other migration did not run. I would like to see either a "dependency" or "preliminary" migration feature: the former skipping the migration if its parent has not run, the latter running the parent on-demand if it has not yet.

@MGatner Do you really need this?

A constant headache, particularly with testing, is running a migration that modifies a table from another migration but that table isn't created yet because the other migration did not run.

I don't understand why this happens.

All migrations have an ordinal number. How can I skip the creation if you are updating?

It's been a while since I wrote this but I believe the issue is cross-library. For example, if I want to add a firstname column to my Shield users then in app/Database/Migrations/ I will create a new migration with UPDATE TABLE ADD COLUMN. This will fail, though, if the Shield migrations have not been run - e.g. under testing if I set $namespace = 'App'. This requires the developer either to run all migrations for every test, or keep track of which migrations have these "dependencies".
At this point I think effort would probably be better spent on adding a database state snapshot to our testing workflow. I started work towards this in my Schemas library in the form of "database-structure-to-migration" but never finished. I think it would be a very helpful feature generally, and a huge performance and ease-of-use improvement for testing.


SdpPendingOffer merging

Related to #364
Synopsis
Sometimes, when using str0m, users may need to run a a second negotiation while first one is still in progress.
Implementation
To make this possible, I suggest adding an API that lets us combine a SdpPendingOffer with new changes from SdpApi. This combination will produce a new SdpOffer and a fresh SdpPendingOffer. These new offer will include changes from the previous SdpPendingOffer as well as new changes from SdpApi. The original SdpPendingOffer will still be available for users, allowing them to cancel any SdpAnswer related to the previous SdpOffers. This can be done using the ChangeId stored in the original SdpPendingOffer.
It's important to note that these older SdpPendingOffers will be empty and won't make any changes. Only the latest SdpPendingOffer generated by the SdpApi::merge_and_apply method can be used to update the str0m state and will be accepted in the SdpApi::accept_answer process.
The ordering of m-lines in the SDP offer will also be accurate.
Example of usage of this new API can be found in the SdpApi::merge_and_apply doc.

I like the direction in which this is going. This idea replaces #370. I think the signature we want is one of:

SdpApi::add_pending(&mut self, pending: SdpPendingOffer)
SdpApi::merge(&mut self, pending: SdpPendingOffer)
SdpApi::append(&mut self, pending: SdpPendingOffer)

Crucially I think the function should not automatically apply, but just extend. I also think it should take SdpPendingOffer by value, not reference to not allow the same to be applied multiple times.

@algesten ,

Crucially I think the function should not automatically apply, but just extend.

I also wanted this function to extend SdpApi instead of applying, and I've done it at first, but then I realized that we need to take into account m-lines ordering after extend, so if we will allow to add more m-lines to SDP (e.g. by SdpApi::add_media call) after extending, then we can't guarantee that m-lines ordering will be correct at the end.

I also think it should take SdpPendingOffer by value, not reference to not allow the same to be applied multiple times.

Yep, this is also was my first taught but then user will not have any mechanism to discard SdpAnswers for the old values. Those SdpPendingOffers is empty by design, so they can't make any changes. Also they can't make any chages because they will have outdated ChangeIds, and accept_answer for example will return error (and this is useful for filtering SDP answers for the old SDP offers). I know that this is not the best approach, but I can't come up with a better idea for filtering old SDP answers. I appreciate any ideas.
Also you can see my example use case in the docs of SdpApi::merge_and_apply function for more details. Maybe it will clarify some things for you.

I also wanted this function to extend SdpApi instead of applying, and I've done it at first, but then I realized that we need to take into account m-lines ordering after extend, so if we will allow to add more m-lines to SDP (e.g. by SdpApi::add_media call) after extending, then we can't guarantee that m-lines ordering will be correct at the end.

The changes in SdpApi are not yet applied. The order of m-lines is only relevant for already negotiated. Hence the order of these "floating changes" doesn't matter.

Yep, this is also was my first taught but then user will not have any mechanism to discard SdpAnswers for the old values.

Not sure I follow. What do you mean?

@algesten ,

The changes in SdpApi are not yet applied

Changes from SdpPendingChanges can be already applied on client side because of SDP offer. So if we will not honor m-lines ordering then client can crash on the newly generated SdpOffer.

Not sure I follow. What do you mean?

SdpOffers may be already sent to the client side, so client side will apply them before str0m does. So when str0m will generate new SdpOffer with the same changes, m-lines ordering should be the same as it was in the first SdpOffer.
Here is example implementation of this case:
impl MediaController {
    pub fn new() -> Self {
        Self {
            rtc: Rtc::new(),
            pending_offers: VecDeque::new(),
        }
    }

    pub fn add_media(&mut self) -> SdpOffer {
        let mut changes = self.rtc.sdp_api();
        changes.add_media(MediaKind::Audio, Direction::SendOnly, None, None);
        if self.pending_offers.is_empty() {
            let (offer, pending) = changes.apply().unwrap();
            self.pending_offers.push_front(pending);
            offer
        } else {
            let last_pending_offer = self.pending_offers.back_mut().unwrap();
            let (offer, pending) = changes.merge_and_apply(last_pending_offer).unwrap();
            self.pending_offers.push_back(pending);
            offer
        }
    }

    pub fn accept_answer(&mut self, answer: SdpAnswer) -> Result<(), RtcError> {
        let pending = self.pending_offers.pop_front().unwrap();
        self.rtc.sdp_api().accept_answer(pending, answer)
    }
}

let mut media_controller = MediaController::new();

let first_offer = media_controller.add_media();
let first_answer = SdpAnswer::from((*first_offer).clone());
let second_offer = media_controller.add_media();
let second_answer = SdpAnswer::from((*second_offer).clone());
let third_offer = media_controller.add_media();
let third_answer = SdpAnswer::from((*third_offer).clone());

media_controller.accept_answer(first_answer).unwrap_err();
media_controller.accept_answer(second_answer).unwrap_err();
media_controller.accept_answer(third_answer).unwrap();

This isn't how the API is supposed to be used. You can't have multiple pending offers. You must wait for the answer to the first offer before making the next change. The sequence is:

change
offer
answer

or

change
offer
reject/abort

I.e. the API is not meant to support:

change -> offer
change -> offer
change -> offer
answer
answer
answer

@algesten ,

You can't have multiple pending offers.

I understand it, but it causes too many problems while working with this API. We don't want to lock Media changes, because this lock will depend on the client and this is not a good thing. I can provide you more real life example:

Member Carol connects to the call
1.1 Server creates SendOnly Medias for the Carol
1.2 Server starts negotiation of Carol
Member Carlos connects to the call
3.1 Server creates SendOnly Medias for the Carlos
3.2 Server creates RecvOnly Medias for the Carol
3.3 Server waits for Carol negotiation because offer is already sent
3.4 Server starts REnegotation of Carol
3.5 Server starts negotiation of Carlos
Member Charlie connects to the call
4.1 Server creates SendOnly Medias for the Carol and Carlos
4.2 But offers are already sent to this Members
4.3 Everything the same as for member Carlos, but in this case we will also need to REnegotiate Carlos and wait for every negotiation which Carlos waits

All this members connects to the server simultaneously, so in this example Charlie will also wait for negotiation of Carol, then for REnegotiation for Carol and for negotiation of Carlos. And then multiply it on number of Member. Waiting time of the last connected member will grow exponentially.
Also it can cause vulnerabilities. If, for example Carol will be attacker then she can just not send SdpAnswer and then Charlie will not connect at all.
Also long awaiting on the adding media action can cause many problems on server because of "locking" some important loops.

We are running one of these style WebRTC implementations on str0m, in production, and we don't have problems with large meetings. We have a different way we do the negotiations than you outline above. It's pretty much exactly like in this example: https://github.com/algesten/str0m/blob/main/examples/chat.rs#L423-L440

Keep track of outgoing tracks needing negotiation.
If there are tracks needing negotiation, make OFFER.

3a. If peer sends OFFER before we get ANSWER, abort negotiation and retry from 1.
3b If peer sends ANSWER, apply it and mark negotiated tracks as ready to use.
We do not await any changes or stall the clients while this is going on.

@algesten ,

3a. If peer sends OFFER before we get ANSWER, abort negotiation and retry from 1.

Server sends OFFER to the client
Client receives OFFER and generates ANSWER
Server wants to make renegotiation before receiving ANSWER

What will happen in this case?

@algesten ,
We just can't use this approach. It's good, but we already have too many layers of code which requires SDP offer at the time when we add some new medias. If we're writing all this from scratch then there will be no problems, but we already have P2P and SFU, we just migrating to str0m and don't want to break it all.
I've thought about this approach many times, but with this approach we have only options to await on add_medias calls until negotiation finishes. But this will definitely cause many bugs and performance issues. Or we can make crutches to somehow bypass your safe SDP API. But this will cause many issues in the future when str0m will make changes in how things works in SDP API.

@algesten ,
I've reworked this PR as you proposed. You can check it out.

@algesten ,
Also what you think about adding ability to set mid and ssrc of Media when adding it with add_media? So signature of SdpApi::add_media function will be:
    pub fn add_media(
        &mut self,
        kind: MediaKind,
        dir: Direction,
        stream_id: Option<String>,
        track_id: Option<String>,
        mid: Option<Mid>,
        ssrc: Option<Ssrc>,
    ) -> Mid

Or we can do it even better with builder pattern for creating Media. Something like this:
struct MediaBuilder {
  // ...
}

impl MediaBuilder {
  pub fn new(kind: MediaKind, direction: Direction) -> Self { /* ... */ }
  pub fn ssrc(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
  pub fn stream_id(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
  pub fn ssrc(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
  pub fn track_id(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
}

impl SdpApi {
  pub fn add_media_with_builder(&mut self, media_builder: MediaBuilder) -> Mid;
}

Or maybe like this:
struct MediaBuilder {
  // ...
}

impl MediaBuilder {
  pub fn new() -> Self { /* ... */ }
  pub fn ssrc(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
  pub fn stream_id(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
  pub fn ssrc(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
  pub fn track_id(self, ssrc: Ssrc) -> MediaBuilder { /* ... */ }
}

impl SdpApi {
  pub fn add_media_with_builder(
    &mut self,
    kind: MediaKind,
    direction: Direction,
    media_builder: MediaBuilder
  ) -> Mid { /* ... */ }
}

@evdokimovs Thanks! I'll check the PR.
As for your question, I think we should have that discussion elsehwere. Either raise a new issue or join us on Zulip https://str0m.zulipchat.com


chore: correct gibibyte spelling

What's change intention?
correct the typo Gigibyte → Gibibyte
Refer to a related PR or issue link
https://github.com/metrics-rs/metrics/issues/497

Released as part of<EMAIL_ADDRESS>Thanks again for your contribution!


changed over to id

#203 please review this commit very carefully it makes some sweeping changes

because its _id in the db so thats what i get in the request objec

You should also get id. _id is usually used for internal backend use only.

what i get is _id

So if you look at the route to the submission page it's something like:
'http://localhost:8000/courses/testcourse-f17/assignments/null'
So I'm not sure what value is used for the route (I think it was assignment_num), but now it is null which messes up the routes.
Then I'm getting this error as well

since multiple assignments have the same value for their route.

i didnt notice this i will look more into it ill keep you posted.

Sounds good, was looking into it and it looks like the id value is null on all assignments

Submissions don't show up in the uploads of BE

Still getting same error

Submissions show up now but the directory creation on backend isn't right:

i made a comment on a line that should be changed back


[7.x] Add support for Arr::flatMap

Adds support for Arr::flatMap, uses existing collection flatMap.

I suggest just using a collection and converting it back into an array.

@taylorotwell I am still using this macro in basically every project. Has your stance changed since #32432 -> #42398?


Add import Text to fix runtime error.

Fixes #93.
I threw in a comment in hopes of guarding against a regression.

Does it fix things to import Native.Text as well? I don't think it's a huge deal, but might be something to consider.

That also works. Updated. Native communicates that it's internal without a comment, so that sounds good to me.

Cool, thank you!


#359 - Verify repomd.xml

Part of #359
Implemented StorageHasRepoMd to verify repomd.xml is present and has records about metadata xmls.

Job gh:artipie/rpm-adapter#370 is not assigned, can't get performer


https://www.npmjs.com/package/cors

This seems better than doing it on our own

The defaults are
{
  "origin": "*",
  "methods": "GET,HEAD,PUT,PATCH,POST,DELETE",
  "preflightContinue": false,
  "optionsSuccessStatus": 204
}

which is different than what you had before
res.set('Access-Control-Allow-Origin', '*');
res.set('Access-Control-Allow-Methods', 'GET');


Use GitHub actions to automatically create & publish to PyPI

https://github.com/PyO3/maturin-action

I'm turning this into a subtask of #39

I'm re-opening this because, even though the io_uring part of the code probably won't have a Python API, I do plan to have internal crates which definitely do have Python APIs.
Related

#39
#94


Indicate in error msg which function is not found

add the tag name to the error message to make live easier when searching for a not implemented function.
fix some typos.

added the tag name to the error message to make life easier when searching for a non implemented function.
fixed some typos.
Typos are fun! Thanks for the pr.

Nice catch! so funny! thanks man!


Concern about Code Release

Thanks for your good work. I have a few concerns.

When will you release inference/training code?
Why not train a SDXL version?
Is there a plan to release your dataset?

Thanks for your good work. I have a few concerns.

When will you release inference/training code?
Why not train a SDXL version?
Is there a plan to release your dataset?

Thanks for your interest in our work. We've included our replies to your concerns:

We'll release our inference code within this month.
DEADiff adapted to SDXL is in progress and will also be released.
We will release the detailed procedure of the dataset construction and are considering the form of releasing our dataset.

Another question, how much vram ram do you need?

Another question, how much vram ram do you need?

You can refer to Table 5 in our paper:

@Tianhao-Qi  April is here, when will you release the code?


oci-image-tool: Drop http.FileSystem?

From @wking on June 16, 2016 14:36
While reading #148, the http.FileSystem section struck me as the wrong approach.  “I'd like to validate this content against this JSON Schema” is easy to support generically, and keeping the schemas themselves outside of that tool allows you to use an existing version of the tool to validate new content against new schemas.  If you compile the schemas in, you have to rebuild the tool to get access to the new schemas.
For an alternative approach, see the in-flight opencontainers/runtime-spec#490.  This approach allows a generic JSON-Schema validator to use whichever schema you point it at.  It would be nice to put the schemas up on www.opencontainers.org/schema/…, but even without that you can use the raw GitHub URLs.  For oci-image-tool, you'd need a method to convert the detected/configured media type / version to a schema URL, but you already do that for http.FileSystem.  The URLs would just get a bit longer, and if we start removing schemas you'd have to add logic to pin to the last image-spec version which carried a schema for your media type.
If this sounds like a reasonable approach, I can work up a PR.
Copied from original issue: opencontainers/image-spec#150

I would be fine with making this an optional feature. Requiring network traffic by default doesn't seem like the best default however.

From @s-urbaniak on June 17, 2016 13:48
Agreeing to all @philips said. I can work on a possibility to look up schema via http/s, or if you @wking would like to do a PR, that'd be fine too.

From @wking on June 16, 2016 22:10
On Thu, Jun 16, 2016 at 03:01:46PM -0700, Brandon Philips wrote:

I would be fine with making this an optional feature. Requiring
network traffic by default doesn't seem like the best default
however.

Does Go have defaults for storing associated data (like Python's 1)?
Baking it into the binary seems like “here's my spell checker with a
compiled in snapshot of today's dictionary” (and I hope nobody does
that ;).

From @wking on June 17, 2016 16:12
On Fri, Jun 17, 2016 at 06:48:30AM -0700, Sergiusz Urbaniak wrote:

I can work on a possibility to look up schema via http/s…

I'm happy to let you do the work ;).

@wking no, this is the "right" way os doing this for Go. Compiling in the data in a section via a const is the common practice. Not great but that is how it is.

I am going to make this post-v1.0.0 as it feels like a nice to have. Also, labeling as help wanted as it is a fun Go project for someone :)

On Tue, Sep 20, 2016 at 07:48:54PM -0700, Brandon Philips wrote:

Copied from original issue: opencontainers/image-spec#150

With opencontainers/image-spec#337 having landed, I think this is
clearly not an image-tools issue.  Can we close this one?


Change the rabbitmqctl 'cluster' command to 'join_cluster'

@tmarballi please add the link to the build here.

https://ocd.appscale.com:8080/job/Daily Build/1608/

https://ocd.appscale.com:8080/job/Daily Build/1610/


Ego Vehicle Behavior Not Responding to Varied Inputs in ScenarioNet Simulator

Issue Summary:
When conducting experiments with the ScenarioNet simulator, I encountered an issue where the ego vehicle's movement does not change in response to different input commands. This behavior is inconsistent with my experiences using MetaDriveEnv and SafeMetaDriveEnv, where the ego vehicle appropriately reacts to varied inputs.
Environment:
Followed the official guide to install
My code:
from metadrive.engine.engine_utils import close_engine
close_engine()
from metadrive.pull_asset import pull_asset
pull_asset(False)
from metadrive.engine.asset_loader import AssetLoader
from metadrive.policy.replay_policy import ReplayEgoCarPolicy
from metadrive.envs.scenario_env import ScenarioEnv
import os
import sys
sys.path.append(r'~/LGM/scnet/scenarionet')
from metadrive import SafeMetaDriveEnv
from IPython.display import Image as IImage
import pygame
import numpy as np
from PIL import Image
nuplan_data = "/home/hermes/nuplan/database"
from scenarionet import read_dataset_summary, read_scenario
dataset_summary, scenario_ids, mapping = read_dataset_summary(dataset_path=nuplan_data)
scenario_file_name = scenario_ids[0]
scenario = read_scenario(dataset_path=nuplan_data, mapping=mapping, scenario_file_name=scenario_file_name)
print(scenario.keys())
scenario.sanity_check(scenario)
scenario.to_dict()
threeD_render=True
#=============================================================env setting start====================================================================#
env = ScenarioEnv(
{
"manual_control": False,
"reactive_traffic": False,
"use_render": threeD_render,
"agent_policy": ReplayEgoCarPolicy,
"data_directory": nuplan_data,
"num_scenarios": 10
}
)
#env = SafeMetaDriveEnv(dict(use_render=True))#, environment_num=50, start_seed=1000, horizon=1000))
#=============================================================env setting start====================================================================#
from stable_baselines3 import PPO
from stable_baselines3.common.env_util import make_vec_env
#model = PPO('MlpPolicy', env, verbose=1)
#model.learn(total_timesteps=(1e+6))
#model.save("scenarioenv")
#model.load('')
o, _ = env.reset(seed=0)
frames = []
for i in range(1, 1000):
a = env.action_space.sample()
#print(a)
o, r, tm, tc, info = env.step([0, 1])
env.render()
#frames.append(env.render(mode="top_down",film_size=(1200, 1200)))
if tm or tc:
break
print(info)
env.close()
Expected Behavior:
The ego vehicle should modify its movement based on the inputs provided, similar to how it functions within MetaDriveEnv and SafeMetaDriveEnv.
Actual Behavior:
Regardless of the input variations provided, the ego vehicle continues to move in the same manner without any noticeable adjustments.
It seems like there is a problem in the ScenarioNet env. I would greatly appreciate any insights or guidance on resolving this issue to ensure the ego vehicle responds dynamically to different inputs as expected. Thank you in advance for your support.

My bad. Setting "agent_policy": ReplayEgoCarPolicy was the problem. I shouldn't have set it or set to EnvInputPolicy(default).


feat: support reading configurations from environment variables in do…

…cker container

Description
This PR is mainly used to solve the problem that in the container deployment scheme, the .env file has been used during the build process, resulting in the configuration being unable to be read by the application.
This solution dynamically modifies the files in the dist according to the environment variables before the container starts, so as to achieve the desired effect. Compared with the old solution, the process.env error will not be triggered during the astro build process.
Linked Issues
invalid_api_key Incorrect API key provided: undefined. #297
Additional context

I wonder why the deploy log of netlify shows completion, but the status of deploy is failed.


Deque implementation

What is interesting here - to have O(1) access at random possition

Features to support:

O(1) random access
push_back/push_front O(1)*
pop also
random access iterator (maybe)

Notes:

should be in dsa:: namespace
should follow the code convention
put it into FMI-DSA/data_structures/deque
embed it to tests into FMI-DSA/data_structures/stack/template_stack and FMI-DSA/data_structures/queue/template_queue

Implemented by Minev in706fd8d95aba11bf42e65e3318734356dcad9208 and c86dfcbf0b34917f33a3af1fd684a6c293ae0c27, slightly modified by me in 8bd688fe5d652c0a6b191697d1b13e87481d855f (also added to template test of adaptors). Everything seems to be fine, closing.


Classes using 'extend Module' appearing in Module.includers list

Hello, is this a bug?
module M
end

class X
  extend M
end

{% for e in M.includers %}
  {% puts e %}     #  ==>  prints "X.class"
{% end %}

https://carc.in/#/r/a69r
(If so, the fix should probably include adding a new directive to macros which would purposely list the ones using extend.)

(Just a note that the issue is still present in 1.2.0)

(If so, the fix should probably include adding a new directive to macros which would purposely list the ones using extend.)

M.extenders is what we need it seems :)

For reference, the issue is still present on 1.13.1.
crystal  test3.cr
X.class


[management] support the remainder of governance tasks

The purpose was to stress test the code and identify any missing pieces.
Features added:

set-validator-operator
create-validator
create-validator-operator

Issues:

set-validator-config fails if the validator is out of the set -- fixed by checking to see if they are in the set

Verified via some ugliness in libra-swarm:

start
grab one of the storage files
make a config (see bottom, make sure it points to json server and proper storage)
hack code to print out public keys for owner and operator keys in current namespace
create a validator account and manually set libra_root/owner in local storage
create an operator account and manually set libra_root/operator in local storage
run set-validator-operator
run set-validator-config
run add-validator
confirm validator-set (note this also kills libra since there are 2 validators but only 1 present)

chain_id: 4
json_server: "http://<IP_ADDRESS>:51928"
shared_backend:
    type: "on_disk_storage"
    path: "/Users/davidiw/libra/config/management/operational/storage"
    namespace: "libra_root"
validator_backend:
    type: "on_disk_storage"
    path: "/Users/davidiw/libra/config/management/operational/storage"
    namespace: "libra_root"

@mgorven, we'll be using this along with the genesis tooling to get things setup...

/land


guide: show exporting create_exception! exceptions in a module

This was asked about in Gitter; #805 seemed to suggest to them that it is not possible.

Thank you for adding this!

Can we use these exceptions for catching error?
In #805, somehow an exception raised in #[pyfunction] and imported one are treated as different errors.

This worked when I tried it:
try:
    rustmod.func()
except rustmod.CustomError:
    ...

where rustmod.func() raises the exception.


Use what has updated hook added

Who is this for?
Developers who would like better debugging for their useEffect type calls, especially for those who would like to know what value caused the effect to run again
What is it doing for them?
A nice debugging tool/helper util that will log exactly what has changed and when!
do this 👇🏾

and get this! 👇🏾

🥳  wow 👀

This has gotten a bit stale; closing for now – we can reopen if we want to revisit it.


TOR appears as "Online", but you cannot stop it, only "Start" is visible.

When you click start is says "TOR is already running".
See image:

Expected Behavior: should show as "Stop" while running and "Start" when not running.

Fixed in latest build.


Disable Cache for objects: documentation updated

Signed-off-by: Rahilsiddique<EMAIL_ADDRESS>
Description of the change:
Documentation changed, example provided updated
Motivation for the change:
adding modified example
changes in the reference to this issue #6052
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

@Rahilsiddique would you like follow up this PR? If not @everettraven can follow up to get this done.


Interactive pop back gesture

Is there a way to implement gesture swipe to pop back?

It should be really straightforward to implement UIViewControllerInteractiveTransitioning to make that work, but I don't have the time to do it myself right now. Feel free to send a pull request if you implement it yourself.

Let the issue open with enhancement and help-needed tag!


os/mac: don't use Sonoma bottles under Rosetta 2.

Rosetta 2 is (much) less needed than it used to be so this seems like a nice middle-ground to allow our Intel bottles to be better optimized on Sonoma.
Given Sonoma drops some Intel hardware support: this can perhaps be even newer than ivybridge e.g. skylake (which we don't have any optimization_flags for yet)?
A considered alternative that seems more annoying but perhaps is better is to refuse to install at all under Rosetta 2 on Sonoma.

Rosetta probably got a spike in usage really with the Gaming Porting Toolkit that came out. If I'm reading analytics correctly, Rosetta looks like it might cover about 800,000, or about 10% of arm64 installs, which is relatively high.
This feels problematic given some formulae (e.g. pkg-config, compilers) need per-OS bottles and we will not be offering them anymore with this change, and we'll also be stuck if Rosetta is still used 3 years from now when we drop Ventura.

I tend to agree with @Bo98: this will break some formulas, while we know there is still significant Rosetta 2 usage. On the other hand, the AVX optimisation is, well, probably negligible for most formulas anyway. And I hope people who have CPU-bound apps or heavily computational needs compile from source rather than use a distro, anyway.

@Bo98 @fxcoudert good points, I agree. As a result, I've rescoped this PR to remove the TODO instead as we can never really implement it.


[Bug] Case sensitive in FE hostname

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
Version : doris-2.1.5-rc02
BuildInfo : iZ2ze9pz2eap5besutxc7oZ
BuildTime : Sat, 20 Jul 2024 22:29:36 CST
What's Wrong?
When adding the FE, I used a lowercase hostname (e.g., server02:9010), but the actual hostname is uppercase Server02. This caused the main FE to report the following error:
WARN (qtp1694355353-190|190) [MetaService.isFromValidFe():71] request is not from valid FE. client: Server02, 9010.
However, the same setup in the BE does not result in an error.
(I know the best way to avoid this is using ip address instead.)
What You Expected?
Fix it.
How to Reproduce?
If you are running a host with hostname in lower case, try to ALTER SYSTEM ADD FRONTEND "Uppercase:port", then check the connection, vice versa.
You can try the same procedure in adding BE nodes to reproduce this situation.
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

is this issue taken?


Unable to install grpc gem with JRuby

The glcoud-ruby project has an issue opened by a user (GoogleCloudPlatform/gcloud-ruby#712) that is unable to install the latest version due to the dependencies on the grpc and google-protobuf gems not installing on jruby. I am not able to get the grpc gem to install on my mac using versions <IP_ADDRESS> or <IP_ADDRESS>. I have the latest libgrpc installed, using both homebrew and built from source.
Here is the install on mac:
$ ruby -v
jruby <IP_ADDRESS> (2.3.0) 2016-05-19 fe84e89 Java HotSpot(TM) 64-Bit Server VM 25.91-b14 on 1.8.0_91-b14 +jit [darwin-x86_64]

$ gem install --ignore-dependencies grpc
Fetching: grpc-0.14.1.gem (100%)
Building native extensions.  This could take a while...
ERROR:  Error installing grpc:
    ERROR: Failed to build gem native extension.

    current directory: /Users/blowmage/.gem/repos/jruby-<IP_ADDRESS>-grpc/gems/grpc-0.14.1/src/ruby/ext/grpc
/Users/blowmage/.rubies/jruby-<IP_ADDRESS>/bin/jruby -r ./siteconf20160524-43017-endf8.rb extconf.rb
NotImplementedError: C extensions are not supported
    <top> at /Users/blowmage/.rubies/jruby-<IP_ADDRESS>/lib/ruby/stdlib/mkmf.rb:1
  require at org/jruby/RubyKernel.java:944
   (root) at /Users/blowmage/.rubies/jruby-<IP_ADDRESS>/lib/ruby/stdlib/rubygems/core_ext/kernel_require.rb:1
    <top> at extconf.rb:30

extconf failed, exit code 1

Gem files will remain installed in /Users/blowmage/.gem/repos/jruby-<IP_ADDRESS>-grpc/gems/grpc-0.14.1 for inspection.
Results logged to /Users/blowmage/.gem/repos/jruby-<IP_ADDRESS>-grpc/extensions/universal-java-1.8/2.3.0/grpc-0.14.1/gem_make.out

Strangly enough, it does install on linux! Here is that install:
$ ./bin/jruby -v
jruby <IP_ADDRESS> (2.3.0) 2016-05-19 fe84e89 OpenJDK 64-Bit Server VM 24.95-b01 on 1.7.0_95-b00 +jit [linux-x86_64]

$ gem install --ignore-dependencies grpc
Building native extensions.  This could take a while...

As far as I know, we haven't done any work to get the gem working on jruby, and frankly, I'm surprised that it work at all.

Well, I said it installed, not worked. :wink: We are also blocked by the fact that google-protobuf fails to install.

The primary issue here is that the library is built on a C extension which uses a variety of Ruby C APIs. I don't think that is supposed to work with jruby.

I believe that sufficiently modern jruby supports C extensions with sufficiently modern versions of OpenJDK

Ahh, well that explains that!

@raggi looking into this, but as far as I can see jruby support for the mri-c extensions was tried earlier on but deprecated in jruby 1.7.0

My understanding is that support for native C extensions are back in JRuby 9000, which is probably all anyone needs to worry about any more as the 1.7.x series is being end-of-lifed at the end of this year.

Hi,
Any update on this issue ?

Is the C extensions issue still blocking progress on this? Has a ruby wrapper around the Java client jar been considered?

@JasonLunn at least in the near-future I unfortunately it's not currently on the road map. With the large amount of c-extension code in the gem, wrapping the java client should be pretty involved - basically a reimplementation.
The truffle solution interpreted-C-extension might be an option but I'm not sure about the consequences - the core functionality of the grpc-ruby is pretty much all a C-library.

@apolcyn: Assume for the purposes of argument that I was willing to try to create such a wrapper around grpc-java, since I'm not able to switch to truffle in production any time soon. Would you want the PR to be submitted here, since this repository seems to own the Ruby gem, or would you want the PR submitted to the grpc-java? The goal in either case being not to create a new grpc-java gem that only works on JRuby, but to create a version of the grpc gem that has a platform of java?

I think this depends mostly on:

Are you looking for a drop-in replacement of the current grpc-ruby that can be used on the java ruby platform? E.g., API-compatible with grpc-ruby, don't have to regenerate grpc-related .proto files?

In this case this should probably go into grpc-ruby repo, as an addition to the grpc-ruby project. But this would also have to fit in to the same testing setup as grpc.

Is a grpc implementation that just works on jruby good enough? Has wrapping the grpc-java client from within jruby "app-level" code been considered?
The main work that the grpc-ruby C extensions do is wrap the grpc C-core library. This could potentially also be wrapped with JNI, and then possibly a lot of the grpc-ruby "pure-ruby" code could be reused in that way.

For 1) and 2), these should be introducing fairly big changes to the grpc-ruby project. Just to save going down the wrong direction, could you please provide a proposal before the PR?

note though that an addition to grpc-ruby like this might be difficult to bring in, just because of the overall complexity it might add.

Or you can use extract the C extension + some light wrapper code into a grpc-ruby-ext gem which grpc gem depends on only for CRuby platform. For java platform it can depend on grpc-java-ext which implements the same API wrapper and can live in the grpc-java codebase.
I'm working on a project which uses Google Cloud APIs and I would like to use run on JRuby, too. It would be nice if the JRuby version would support the same grpc API without any code change.

also @JasonLunn if a plan was created it would probably fit into grpc project-wide proposals. see https://github.com/grpc/proposal

@apolcyn - what I'm looking for is the ability for Ruby dependency management tools like bundler to Do the Right Thing™ when higher level gems (like google-cloud-datastore for example) express a dependency on the grpc gem under a JRuby interpreter. From the perspective of the Gemspec, the approach that the Google Protobuf took is near ideal for my purposes: when executed on the JRuby interpreter, include the jar file rather than the C implementation files. In Protobuf's case, the job of getting your hands on the jar is a little bit more straightforward as it is built from the same repo as ruby gem, but there already exist tools to leverage Maven dependencies from JRuby rather than store the jar binary alongside the ruby source. From there it is about building a shim over the Java implementation (to the extent necessary) to provide Ruby API compatibility.

I took a stab at writing a proposal, @apolcyn - see the PR
Any feedback would be appreciated.
CC: @teodor-pripoae @blowmage

@apolcyn what is the status of this issue?

I'll close this since I don't think there will be any action on this from grpc team. If there's progress on this, I suspect it would come as an open source contribution; (I believe @JasonLunn has made some progress here).


add eq param to length

add eq param to length

Thanks for the PR. This is basically just syntactic sugar instead of using length(..., max=x, min=x). I don't think this brings enough value in order to add this. I'm closing this for now.


Remove the docs GitHub Actions.

PlantUML relies on system fonts which are different from one machine to the other. This is tricky to troubleshoot and blocks all PRs currently.
We will discuss in the community if we want to keep PlantUML or move to something more popular such as Mermaid.
/cc @yevgeny-shnaidman

/lgtm


uninitialized constant Chef::Resource::IisPool

Cookbook version
6.2
Chef-client version
13.0.118
Platform Details
Windows 2008 R2
Scenario:
Just trying to create an IIS app pool.
Steps to Reproduce:
iis_pool 'TEST' do
runtime_version '4.0'
pipeline_mode :Integrated
action [:add, :start]
end
Expected Result:
App Pool working like with chef-client 12.
Actual Result:
NameError
uninitialized constant Chef::Resource::IisPool
Resource Declaration:
In C:/chef/cache/cookbooks/webserver_dmz/recipes/default.rb
112: iis_pool 'TEST' do
113:   runtime_version '4.0'
114:   pipeline_mode :Integrated
115:   action [:add, :start]
116: end

@thpert this is because iis_pool hasn't been updated to a custom resource.  This is in the process of completion now.

@thpert resolved by #331


KeyError: 'String' when running the code on different meshes

Hello there,
I am running the following command in Ubuntu:
meshio-convert test.vtu out.vtk
Then, I get the following error:

Traceback (most recent call last):
File "/home/ahama/.local/bin/meshio-convert", line 11, in
sys.exit(convert())
File "/home/ahama/.local/lib/python3.6/site-packages/meshio/_cli/_convert.py", line 15, in convert
mesh = read(args.infile, file_format=args.input_format)
File "/home/ahama/.local/lib/python3.6/site-packages/meshio/_helpers.py", line 68, in read
return reader_mapfile_format
File "/home/ahama/.local/lib/python3.6/site-packages/meshio/vtu/_vtu.py", line 505, in read
reader = VtuReader(filename)
File "/home/ahama/.local/lib/python3.6/site-packages/meshio/vtu/_vtu.py", line 296, in init
field_data[data_array.attrib["Name"]] = self.read_data(data_array)
File "/home/ahama/.local/lib/python3.6/site-packages/meshio/vtu/_vtu.py", line 487, in read_data
data = reader(c.text.strip(), c.attrib["type"])
File "/home/ahama/.local/lib/python3.6/site-packages/meshio/vtu/_vtu.py", line 445, in read_compressed_binary
dtype = vtu_to_numpy_type[data_type]
KeyError: 'String'

The test.vtu mesh file is attached (you might want to unzip the file first). I have experimented with other mesh files as well and still got errors. I have both Python 2 and 3 on my system if that's something relevant. Any help is appreciated.
Thanks and best wishes.
test.zip

The VTK/VTU specification says:

type — The data type of a single component of the array. This is one of Int8, UInt8, Int16, UInt16, Int32,
UInt32, Int64, UInt64, Float32, Float64

Hence, String is an illegal type. I made the error message clearer.


⚠ Spryr has degraded performance

In 37de4bd, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5583 ms

Resolved: Spryr performance has improved in fdae528 after 24 minutes.


verapdf-bin: init at 1.26.2

Description of changes
This pull request introduces verapdf, an open-source, industry-supported PDF/A validation tool, maintained by the Open Preservation Foundation. Initially, I attempted to build the package from source but encountered difficulties. After seeking assistance on Discourse, it was suggested to package verapdf using the prebuilt binaries, even though building from source is not yet possible.
The upstream distribution provides a graphical installer, which can be automated in a headless environment by configuring options in an XML file. This method has been used to package verapdf for nixpkgs.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@kilianar Thank you for quickly responding to my discourse comment. I think I actually managed to package this from source, see https://github.com/NixOS/nixpkgs/pull/342508

I'm closing this pull request because @mohe2015 successfully built verapdf from source, eliminating the need for the cumbersome binary packaging.


Questions about VideoChat2_HD

Hi, thanks for your update of VideoChat2_HD! When trying the newly-released code, I got some questions:

The MetaLoader_rs class in "train_it_ds.py" seems to be missing.
So I still used "train_it.py", but got the following error. I'm not sure whether it could be solved by using MetaLoader_rs.

RuntimeError: stack expects each tensor to be equal size, but got [8, 3, 224, 448] at entry 0 and [8, 3, 448, 672] at entry 1

Then I changed the batch_size to 1 and solved the previous error. But it seems the load_and_transform_media_data_image function does not have dynamic_config setting, which is passed to it in "it_dataset_mistral.py". I created a pull request to modify this part.
Is there any place to find the newly added dataset for VideoChat2_HD? I suppose the datasets are important to improve model performances.

Thanks for your try! I will fix it later~

@LiJiaqi96 Please have a try. have updated the code. The train_it_ds is add with deepspeed and need some change.

Thanks! I tried "train_it_ds.py" without using deepspeed, but it doesn't work. Is it possible to train without using deepspeed? Temporally I prefer not to use deepspeed.

Yes! You can run it without deepspeed. BTW, show me you log so that I can fix the bug ~

Sorry for the late reply. The log is here
train_log.txt
in "config_7b_hd_stage4.py", I set enable=False in deepspeed settings.
and run the code with:
torchrun    --nnodes=${NNODE} --nproc_per_node=${NUM_GPUS} \
    --rdzv_endpoint=${MASTER_NODE}:10068 \
    --rdzv_backend=c10d \
    tasks/train_it_ds.py \
    $(dirname $0)/config_7b_hd_stage4.py \
    output_dir ${OUTPUT_DIR}

I'm not sure whether it is cause by the deepspeed or pytorch verisons.
Here are my versions of different packages:
torch                     1.13.1+cu117
torchaudio                0.13.1+cu117
torchnet                  0.0.4
torchvision               0.14.1+cu117
deepspeed                 0.14.2
transformers              4.40.1

BTW, sometimes ypu can fix the bug by change find_unused_parameters to True or Fasle.

Thanks, I will create an environment with exactly the same packages and have a try.

Hi, I found shared_utils_ds.py has a bug in line 58.
optimizer_params = create_optimizer(config.optimizer, model, return_group=True)
the optimizer.py may need to be updated.

Thanks for your feedback. I have updated the code.

I used the new environment except flash-attn, as I used CUDA 12.1 and can only use flash-attn==2.1.0. I ran the code "scripts/videochat_mistral/run_7b_stage4_hd.sh", with "tasks/train_it.py" and deepspeed enable=False, then got error train_log0618.txt. The error seems to be caused by flash-attn.
Is it possible to run videochat2_hd using the same environment as videochat2_mistral, withou using deepspeed?

BTW I test to run the code on single GPU (like python train_it.py) and it iterates normally

Yes, it's okay to use it without deepspeed. I use deepspeed ZERO to decrease the GPU memory~

I see. Is it ok for you to run on multiple GPUs without deepspeed, just as the model runs in videochat2_mistral?

Update: I managed to solve the previous issue by upgrading the flash-attn to 2.5.9. When I use "train_it_ds.py" and with deepspeed enable=True, I met new issue about deepspeed config:
trainlog_0621.txt
Could you please help me solve that?

Hi! Please try again with the newly commit.

Thanks for your update! Now the code could run with deepspeed enabled.
BTW, Is there any place to find the newly added dataset for VideoChat2_HD? I suppose the datasets are important to improve model performances.

Almost all the datasets can be directly downloaded from their repos or homepages~
Give me feedback if you don't find them.

In "instruction_data.py", there are some newly added image datasets in M3IT, and some newly added videos datasets. Is there any place to find those video datasets? Thanks!

These datasets are generated from ShareGPTVideo, VidLN, FAVD and TimeIT_didemo.

Thanks for your sharing!

Another question, how could I obtain the checkpoint after VideoChat2_HD training?  in "demo_mistral_hd.ipynb".
state_dict = torch.load("your_model_path/videochat2/videochat2_hd_mistral_stage4.pth", "cpu")
I noticed that there are several files in the "ckpt_latest.pth" folder, should I choose one of them?
Thanks!

These datasets are generated from ShareGPTVideo, VidLN, FAVD and TimeIT_didemo.

Hi, could you please help me find the instruction json files such as f"{anno_root_it}/video/caption/sharegptvideo/train_300k.json", I did not find the json files in the HF VideoChat2-IT repo.

Sorry for the late reply. For the checkpoint, you need to use the file named mp_xxx which saves weights. For the instruction data, I will upload it today.

@LiJiaqi96 Please check the data in HuggingFace~

Thanks for your reply! I will try it~

Update: I managed to solve the previous issue by upgrading the flash-attn to 2.5.9. When I use "train_it_ds.py" and with deepspeed enable=True, I met new issue about deepspeed config: trainlog_0621.txt Could you please help me solve that?

@LiJiaqi96 Hello, I encountered the same problem, how did you solve it?

BTW, did you evaluate the effectiveness of the VideoChat2_HD and the newly added datasets, respectively? I'm curious about whether the training scheme or the dataset matters more for the improvement. Thanks!

We do not conduct serious comparisons since we want to make good use of pretrained models.
And I think both are important based on some experiments:

Stage4: Directly fine-tuning VideoChat2-Stage3 with HD on the original Stage3-dataset improved marginally.
Stage3: Fine-tuning VideoChat2-Stage2 with Stage4-dataset leads to performance drop by ~3%.

My experiment is consistent with your findings. I directly fine-tuning VideoChat2-Stage3 (trained by myself from Stage2, 3 epochs) with HD on the original Stage3-dataset (1 epoch), and the score on the MVBench drops from 56 to 43 ...

Interesting! I think HD needs more high-resolution and high-quality data.

These datasets are generated from ShareGPTVideo, VidLN, FAVD and TimeIT_didemo.

Hi, while downloading the datasets, I could not find the "infovqa". Could you please help me find the dataset?

Hi, I noticed that the number of DiDeMo videos provided in the json file cannot match with the google drive version. Is there any way to download the full set of DiDeMo videos? Thanks !
https://drive.google.com/drive/u/0/folders/1huOL37wNOyMdCzbl8CIvJHDwCu5HLQ5o

Hi! I do not know the way to download DeDeMo, since it was downloaded in our cluster~

Thanks for your reply

These datasets are generated from ShareGPTVideo, VidLN, FAVD and TimeIT_didemo.

Hi, I downloaded the videos from ShareGPTVideo as the link provided above. When I ran the code, there are errors that many files could not be found, such as: v_qx1FNJxiUuE-Scene-001,<PHONE_NUMBER>, v_kuJO1VapxuQ-Scene-027. Did you use the "train_300k" subset of ShareGPTVideo? Thanks!


Continue work on split of test_messages.py.

PR contains work mentioned in https://github.com/zulip/zulip/pull/15661#issuecomment-654518160
Testing Plan:
GIFs or Screenshots:

These changes all look great, merged, thanks @thedeveloperr!

@timabbott I should have added WIP, I was still pushing some more commits. I will open a new PR i guess now

I don't think it's an issue -- it's better to do these in smaller chunks so that I can verify your work in manageable pieces.  Better to just do a next PR with the next phase (or I could have left this open by merging via the command line so you can add more).


"Stop Sharing" button on Windows corrupts webm file

Hi,
I think I have come across an issue with RecordRTC. I am developing a way to record the screen on chrome in javascript, starting and stopping it based on some DOM events and then upload the recording to aws s3 on completion. I've tested the functionality on Windows and on Mac and when the recordings are started and stopped via the DOM events, everything works as expected and the recordings are good. However, when I use the Stop sharing button to stop the recording on windows, the webm file gets corrupted and is unplayable. I am not sure if the issue comes from the handling of the stop sharing event, the aws s3 multipart upload, or the way I handle blobs. On Mac, there doesn't seem to be an issue. Here is the relevant code:
I have the oninactive handler for detecting this event as follows:
(stream.oninactive = () => endRecording());
In the endRecording function, I stop the recorder like so:
recorder.stopRecording((blobUrl) => { });
and then upload to s3.
This is how I create the recorder:
const finalStream = new MediaStream();
RecordRtc.getTracks(stream, "video").forEach((track) => finalStream.addTrack(track));

const recorder = new RecordRtc(finalStream, {
  mimeType: "video/webm;codecs=h264",
  timeSlice: 1000,
  ondataavailable: getBlobHandler(fileName, recordingId), // fileName and recordingId are strings
});

Relevant functions:
function getBlobHandler(fileName, recordingId) {
  return () => {
    const recorder = recorderByFilename[fileName];
    const internal = recorder.getInternalRecorder();

    if (recorder.getState() !== "recording") return;
    if (!internal || !internal.getArrayOfBlobs) return;

    const arrayOfBlobs = internal.getArrayOfBlobs();

    const blob = new Blob(arrayOfBlobs, { type: "video/webm" });
    if (blob.size < maxChunkSize) return;
    clearCurrentRecorder(recorder, arrayOfBlobs);
  };
}

function clearCurrentRecorder(recorder, arrayOfBlobs) {
  recorder.pauseRecording();
  clearInternalRecorderBlobs(arrayOfBlobs);
  recorder.resumeRecording();
}

filesToUpload = {};

async function getBlobFromObjectUrl(blobUrl) {
  const res = await fetch(blobUrl);
  return res.blob();
}

async function handleBlobAndUploadPart(fileName, blobUrl, currentTabId) {
  if (!blobUrl) return;
  const blob = await getBlobFromObjectUrl(blobUrl);
  const currentFileInfo = filesToUpload[fileName];
  console.log("current file info in handle blob upload part is", currentFileInfo);
  const previousPartNumber = currentFileInfo["partNumberCursor"];
  currentFileInfo["partNumberCursor"]++;
  const { partNumberCursor } = currentFileInfo;

  if (_.isEmpty(currentFileInfo.multiPartInitialInfo)) {
    if (partNumberCursor > 1) {
      await currentFileInfo.createMultipartUploadPromise;
    } else {
      await initMultiPartUpload(fileName);
    }
  }
  const { multiPartInitialInfo } = currentFileInfo;

  const awsUploadPart = uploadPart(blob, multiPartInitialInfo, partNumberCursor);

  currentFileInfo["uploadedAwsRequests"][previousPartNumber] = awsUploadPart;
  currentFileInfo["uploadedPartPromises"][previousPartNumber] = awsUploadPart.promise().catch((error) => {
    // Fail silently if we abort the request to cancel the recording
    if (error.code !== "RequestAbortedError") throw error;
  });

  removeBlobFromTab(blobUrl, currentTabId);
}

function uploadPart(blob, multiPartUploadInfo, partNumberCursor) {
  const params = {
    Body: blob,
    PartNumber: partNumberCursor,
    ...multiPartUploadInfo,
  };
  printInfoMessage(`start upload part - ${partNumberCursor}, blobSize - ${blob.size}`, "");

  return s3.uploadPart(params);
}

async function initMultiPartUpload(fileName) {
  console.log("init multi part upload", fileName);
  filesToUpload[fileName].createMultipartUploadPromise = createMultipartUpload(fileName, s3);
  filesToUpload[fileName].multiPartInitialInfo = await filesToUpload[fileName].createMultipartUploadPromise;
}

async function createMultipartUpload(fileName, s3) {
  const params = {
    Bucket: bucketName,
    Key: fileName,
    ContentType: "video/webm",
  };

  return s3.createMultipartUpload(params).promise();
}

Fixed this by using the following version:
"recordrtc": "https://github.com/stijnvanderpol/RecordRTC#bafda82"


Wrong operand size

FF 1D 00 10 00 00      The correct disassembly is :  CALL FAR FWORD PTR DS:[0x1000]
But now we have this:   call far dword [0x1000]

there is no segment override, DS is default register designed for this option. The instruction must be preceded by segment override prefix opcode.


refactor(react-i18n): have the same signature for useTranslate and translate HOC

Since #46 the translation method signature between the hook and the HOC isn't the same (I guess we didn't see that coming). This PR aims for the translation function to have the same signature when coming from different places (hook or HOC).
⚠ Breaking change ⚠

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 61.538%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
96

Relevant Lines:
136

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 61.538%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
96

Relevant Lines:
136

💛  - Coveralls


Docker compose: Error: role "hleb" does not exist. [QUESTION]

Hi there.
Kindly ask you to help with docker and Postgres.

I have a local Postgres database and a project on NestJS.

I killed 5432 port.

My Dockerfile

FROM node:16.13.1

WORKDIR /app

COPY package.json ./
COPY yarn.lock ./

RUN yarn install

COPY . .

COPY ./dist ./dist
CMD ["yarn", "start:dev"]

My docker-compose.yml

version: '3.0'

services:
  main:
    container_name: main
    build:
      context: .
    env_file:
      - .env
    volumes:
      - .:/app
      - /app/node_modules
    ports:
      - 4000:4000
      - 9229:9229
    command: yarn start:dev
    depends_on:
      - postgres
    restart: always

  postgres:
    container_name: postgres
    image: postgres:12
    env_file:
      - .env
    environment:
      PG_DATA: /var/lib/postgresql/data
      POSTGRES_HOST_AUTH_METHOD: 'trust'
    ports:
      - 5432:5432
    volumes:
      - pgdata:/var/lib/postgresql/data
    restart: always

volumes:
  pgdata:

.env

DB_TYPE=postgres
DB_HOST=postgres
DB_PORT=5432
DB_USERNAME=hleb
DB_NAME=artwine
DB_PASSWORD=Mypassword

running sudo docker-compose build - NO ERRORS

running sudo docker-compose up --force-recreate - ERROR

ERROR [ExceptionHandler] role "hleb" does not exist.
I've tried multiple suggestions from existing issues but nothing helped.
What am I doing wrong?
Thanks!

These are the environment variables the image uses https://github.com/docker-library/docs/tree/master/postgres#environment-variables

In the future, these sorts of questions/requests would be more appropriately posted to a dedicated support forum, such as the Docker Community Forums, the Docker Community Slack, or Stack Overflow.


Add dry-run test for operator init

Please provide a description of this PR:
Made the kube client creation function overridable to perform unit tests. Also, I've noticed TODO here:
https://github.com/istio/istio/blob/e0207105bb09baf1299a5752b98d83240ba981af/operator/cmd/mesh/operator_test.go#L30
I'll look into this one since the client creation is overridable now.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
6922133b773af73e40eaff145570fab4a78802bd
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
6922133b773af73e40eaff145570fab4a78802bd
link
true
/test lint_istio

gencheck_istio
6922133b773af73e40eaff145570fab4a78802bd
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Cmorize era interim in Python with extra vars

For the Lisflood hydrology model in the eWaterCycle project we want to prepare the forcings of the model by using era-interim data.
The following daily variables are needed by the model, but are not processed by the cmorize_obs_era_interim.ncl  script:

u
v
d2
ssrd

As I don't know ncl, I started working on cmorize_obs_era_interim.py, to which the new variables will be added.
Started from era5 branch so merge after https://github.com/ESMValGroup/ESMValTool/pull/1167 has been completed.

Once this is done, we can think about extending it with all variables from the NCL script and then get rid of it (@bouweandela will be very pleased :smile: )

Compared netcdf produced by ncl script vs current python script:

[ ] python has 12 hour offset
[ ] time unit of ncl is since 1950 while python since 1990
[ ] nlc has 'conventions = "CF/CMOR"' while python has 'Conventions = "CF-1.5"' and input file is 'Conventions = "CF-1.6"'
[ ] time dimension is unlimited in ncl, but python is 31
[ ] host is known in ncl but unknown in python
[ ] order of variables for ncl it is time, lat, lon, tas, height while for tas, time, lat, lon, height
[ ] python height does not have axis Z

If this is going to replace the NCL script completely, it would also close #1147.

@mattiarighi is is unclear to me which times and steps where used to download era-interim data files. In the ncl script it says to make sure to use the right steps, but what are they?
For now I am downloading era interim with my era-interim-esmvaltool-download.py script, but I could be fetching too much or too little.

These are the settings I used for downloading the data, based on the example given on the page you have linked:
INVARIANT = {
    "lsm": {"param": "172.128",
            "levtype": "sfc",
            "step": "0",
            "stream": "oper",
            "type": "an"}
    }

DAILY = {
    "z": {"param": "129.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "oper",
          "type": "an",
          "time": "00:00:00/06:00:00/12:00:00/18:00:00",
          "step": "0"},
    "mn2t": {"param": "202.128",
             "levtype": "sfc",
             "stream": "oper",
             "type": "fc",
             "time": "00:00:00/12:00:00",
             "step": "3/6/9/12"},
    "msl": {"param": "151.128",
            "levtype": "sfc",
            "stream": "oper",
            "type": "an",
            "time": "00:00:00/06:00:00/12:00:00/18:00:00",
            "step": "0"},
    "mx2t": {"param": "201.128",
             "levtype": "sfc",
             "stream": "oper",
             "type": "fc",
             "time": "00:00:00/12:00:00",
             "step": "3/6/9/12"},
    "tp": {"param": "228.128",
           "levtype": "sfc",
           "stream": "oper",
           "type": "fc",
           "time": "00:00:00/12:00:00",
           "step": "12"}
    }

MONTHLY = {
    "t": {"param": "130.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "u": {"param": "131.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "v": {"param": "132.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "w": {"param": "135.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "z": {"param": "129.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "q": {"param": "133.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "r": {"param": "157.128",
          "levelist": LEVELS,
          "levtype": "pl",
          "stream": "moda",
          "type": "an"},
    "iews": {"param": "229.128",
             "levtype": "sfc",
             "stream": "moda",
             "type": "fc"},
    "inss": {"param": "230.128",
             "levtype": "sfc",
             "stream": "moda",
             "type": "fc"},
    "msl": {"param": "151.128",
            "levtype": "sfc",
            "stream": "moda",
            "type": "an"},
    "p56.162": {"param": "56.162",
                "levtype": "sfc",
                "stream": "moda",
                "type": "an"},
    "p57.162": {"param": "57.162",
                "levtype": "sfc",
                "stream": "moda",
                "type": "an"},
    "skt": {"param": "235.128",
            "levtype": "sfc",
            "stream": "moda",
            "type": "an"},
    "sp": {"param": "134.128",
           "levtype": "sfc",
           "stream": "moda",
           "type": "an"},
    "sst": {"param": "34.128",
            "levtype": "sfc",
            "stream": "moda",
            "type": "an"},
    "t2m": {"param": "167.128",
            "levtype": "sfc",
            "stream": "moda",
            "type": "an"},
    "tcc": {"param": "164.128",
            "levtype": "sfc",
            "stream": "moda",
            "type": "an"},
    "tcwv": {"param": "137.128",
             "levtype": "sfc",
             "stream": "moda",
             "type": "an"},
    "tp": {"param": "228.128",
           "levtype": "sfc",
           "stream": "mdfa",
           "type": "fc",
           "step": "0-12"}
    }

@bouweandela The solution of ignoring download scripts here might not be the most elegant way. We should consider putting the download scripts somewhere else (maybe even in the docs) since they are not meant to be executed from within esmvaltool.

Adding ecmwf-api as a dependency will break the code as there is no conda build available for python 3.7 and hence the environment cannot be set up.
I made an issue at conda-forge to address this: https://github.com/conda-forge/ecmwf-api-client-feedstock/issues/5

@mattiarighi Could you please have another look to see if all required functionality is now supported and the values make sense?

I will.
Please update the table in doc/sphinx/source/getting_started/inputdata.rst, by adding the new variables and changing NCL to Python.

I will try to run the script once, to make sure that the results are consistent with the current, NCL-generated data.
And maybe the download script as well, since the download of some accumulated variables in quite error prone.
Are you still fixing bugs or can I start?

Are you still fixing bugs or can I start?

If you could start would be great. We found some issues when trying to run the CMORization in parallel (it didn't work), but no changes to the CMORizer functionality itself so far.

Ok, let me start with the download script and the raw data.

Note that sftlf is affected by the issue reported here https://github.com/ESMValGroup/ESMValCore/issues/329#issuecomment-545005922

Note that for monthly pr and hfds we are not dividing by the number of days in the month, while the ncl script does. From the documentation here https://confluence.ecmwf.int/display/CKB/ERA-Interim%3A+monthly+means it looks like this is the correct approach, since the downloaded data is already a monthly mean of daily accumulations.

I cannot open the link (page not found) unfortunately.
The division by the number of month is not done to calculate a monthly mean, but to convert the units from m to kg/m2/s.
The original input is in m, which I would interpret as 1 m of water precipitated over 1 month (i.e, accumulated). This means 1 cubic meter of water over an area of a square meter in 1 month, i.e.
1 m/month = 1 m3/m2/month = 1000 kg/m2/month

now, 1 month = ndays * 24 * 3600, which in the end is the conversion given in the NCL script:
1 m/month = 1 m3/m2/month = 1000 kg/m2/month = 1000/(24*3600*ndays) kg/m2/s

@hb326 I think we had a similar discussion for another dataset and we concluded that this was the correct way

Wait!
I just found this document, which states: The monthly means of daily forecast accumulations include all relevant forecasts that have an accumulation period in the month and so represent accumulations for the entire month at the particular forecast range. Since the hydrological parameters are in units of “m of water per day”, they should be multiplied by 1000 to convert to kgm-2day-1 or to mmday-1.
So the input units are m/day, not per month and no division by ndays is required, you are right.
Thanks for spotting.

Note that sftlf is affected by the issue reported here ESMValGroup/ESMValCore#329 (comment)

Can't we just use OBS instead of OBS6?

Note that sftlf is affected by the issue reported here ESMValGroup/ESMValCore#329 (comment)

Can't we just use OBS instead of OBS6?

If I understood correctly CIMP5 tables are used for OBS whereas CMIP6 tables for OBS6. Currently, CMIP6 tables support more variables than those in CMIP5 tbales, variables such as ts_day and evspsbl_day are in mip Eday, and tdps_month and rss_month are in mip=Emon. Those mip are only available in CMIP6 tables.

I'm testing the download script and will then proceed to testing the cmorizer.

Both the download script and the cmorizer work fine!
I've compared the data generated with the old NCL script to the ones from the Python script, using the same input raw data. Here is the list:

[x] Amon-clivi
[x] Amon-clt
[x] Amon-clwvi
[ ] Amon-hur: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[ ] Amon-hus: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[x] Amon-pr: there is a factor of ~ndays difference as expected and dicussed above.
[x] Amon-prw
[x] Amon-ps
[x] Amon-psl
[ ] Amon-ta: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[x] Amon-tas
[x] Amon-tauu
[x] Amon-tauv
[x] Amon-ts
[ ] Amon-ua: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[ ] Amon-va: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[ ] Amon-wap: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[ ] Amon-zg: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[x] day-pr
[x] day-psl
[x] day-tas
[x] day-tasmax
[x] day-tasmin
[ ] day-zg: the vertical levels are sorted differently, decreasing (NCL) vs. increasing (Python), otherwise ok
[x] fx-sftlf.nc
[x] Omon-hfds
[x] Omon-tos: there is a difference of 273.15, as expected since the units changed from K in CMIP5 to degC in CMIP6.

The only issue is the sorting of the plev coordinate in 4D variables.
I think it should be decreasing as it was before, as also given in the cmor tables, e.g. for `plev27':
https://github.com/ESMValGroup/ESMValCore/blob/bcb384b4417a670d0b7e40c78be8bae05389df7d/esmvalcore/cmor/tables/cmip6/Tables/CMIP6_coordinate.json#L1436-L1486

Once the above list is complete we should also adjust and test all the recipes using ERA-Interim.
According to quick grep there are the following:

[ ] recipe_autoassess_stratosphere.yml
[ ] recipe_clouds_bias.yml
[ ] recipe_extreme_events.yml
[ ] recipe_flato13ipcc.yml
[ ] recipe_miles_block.yml
[ ] recipe_miles_eof.yml
[ ] recipe_miles_regimes.yml
[ ] recipe_perfmetrics_CMIP5_4cds.yml
[ ] recipe_perfmetrics_CMIP5.yml
[ ] recipe_smpi_4cds.yml
[ ] recipe_smpi.yml
[ ] recipe_spei.yml
[ ] recipe_validation_CMIP6.yml

Once the above list is complete we should also adjust and test all the recipes using ERA-Interim.

I created a new issue (#1412) started a draft PR (#1411) to work on this.

Thanks for fixing the issues.
I'm running the check recipe and will then merge.

Tested successfully, except sftlf (for the reasons mentioned above).


Clang tidy header filter

Correctly excludes non-project headers (from dependencies), thus eliminating false-negatives.

Include ClangTidy-vc in Clang-Tidy tests


[admin] Extract AdminFilter class to separate file

Description: 1st iteration in decomp of admin.h/admin.cc work (see https://github.com/envoyproxy/envoy/issues/5505). In this particular PR I have extracted the AdminFilter class to a separate file. I also refactored some util code that is shared across Admin and AdminFilter.
Risk Level: low
Testing: pre-existing tests
Docs Changes: N/A
Release Notes: N/A

/wait

/retest

/azp run

@jmarantz could you please re-trigger the azure pipelines when you get a chance? There are a couple of tests failing, but I don't think they are related to my code changes. Thanks!

/azp run envoy-linux

/retest

Apologies can you merge master?
/wait

@mattklein123 merged master, ready for you to review.


Ran cargo clippy --fix.

Lots of minor changes
Only one thing worth talking about is the removal of a .clone() call.
As with the recent release of  rust 1.7 : cargo clippy has added a few new rules.

Looks good thanks! (The .clone() removal is fine, the global suspense moved from implementing only Clone to also Copy and it was left over)


Value lost when changing groups

Just like to report that value not showing if you change to an other dashboard group and back again,
the value come back after a page reload.
Hope its something you can look in to
PT

Hi,
I just corrected the behaviour when changing tabs on the dashboard and released a new version of the display (v1.0.3). Should be already available.
Maybe you can give me a short feedback?
Have fun with it and best regards
Patrick

Did run the update, and all works good now.
Thanks for the update, I use it to display the hourly price of electricity up on a screen.
PT

I'm glad to hear it! May I possibly make the request for a screenshot? Of course, only if no confidential information is revealed in the process. I would like to have more feedback about the applications in which the display is used, in order to get impulses for further development. But please really only if it's okay with you!
Best regards
Patrick

Its used to show the price on electricity, now, and hour next and before

Thank you so much!

One more thing, If you change to Angular Theme it look like this:

Not a good color combination..... Its nothing im using, but some might :)
PT

I had a lot of questions for individual colors. I think during the next months I will add settings for color adjustment.


Test PhantomJS 2.0

PhanomJS 2.0 has been released! Let's make sure everything still works.

We can do this in travis-ci with this approach.
# .travis.yml

before_install:
  - wget https://s3.amazonaws.com/travis-phantomjs/phantomjs-2.0.0-ubuntu-12.04.tar.bz2
  - tar -xjf phantomjs-2.0.0-ubuntu-12.04.tar.bz2
  - sudo rm -rf /usr/local/phantomjs/bin/phantomjs
  - sudo mv phantomjs /usr/local/phantomjs/bin/phantomjs

Teams have tested phantomjs 2.0 and it seems to work fine.


IndexError when plot dynamic patterns

Hi,
I am impressed by the dynamic patterns parts in fluff.
I can get the dynamic plot from the example, but this error came up when I use own date:
##CMD
$ fluff heatmap -f tsses_2kb_new.bed -d WT_H2A_Z.sort.bam WT_H3K4me3.sort.bam WT_H3K27me3.sort.bam WT_pol.sort.bam -C k -k 5 -g -M Pearson -o kmeans5_dynamics
Pearson distance method
Loading data
K-means clustering
Loading data
Traceback (most recent call last):
File "/root/anaconda2/bin/fluff", line 4, in
import('pkg_resources').run_script('biofluff==2.0.1', 'fluff')
File "/root/anaconda2/lib/python2.7/site-packages/setuptools-20.3-py2.7.egg/pkg_resources/init.py", line 726, in run_script
File "/root/anaconda2/lib/python2.7/site-packages/setuptools-20.3-py2.7.egg/pkg_resources/init.py", line 1484, in run_script
File "/root/anaconda2/lib/python2.7/site-packages/biofluff-2.0.1-py2.7.egg-info/scripts/fluff", line 327, in
args.func(args)
File "/root/anaconda2/lib/python2.7/site-packages/fluff/commands/heatmap.py", line 181, in heatmap
for (chrom, start, end, gene, strand), cluster in zip(array(regions, dtype="object")[ind], array(labels)[ind]):
IndexError: index 27201 is out of bounds for axis 0 with size 27200
##Bed file attached here
tsses_2kb_new.bed.txt
Please help me!
Youhuang Bai

Hi Youhang, we'll have a look and see if we can find the issue.

Hello Youhuang,
The issue has been fixed.. I submitted a pull request to bioconda and i expect it to be merged soon.
George

Great thanks to you, George!


Remove TokenRateController setters

Explanation
The TokenRateController setters for chainId and tokens have been removed. These were confusing, unnecessary, and presented obstacles to testing asynchronous events triggered by these setters.
References
This is tangentially related to https://github.com/MetaMask/core/issues/1466
Changelog
@metamask/assets-controllers

BREAKING: Remove TokenRatecontroller setter for chainId and tokens properties

Checklist

[x] I've updated the test suite for new or updated code as appropriate
[x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[x] I've highlighted breaking changes using the "BREAKING" category above as appropriate

This depends upon #1501


Fix height update if grid is not attached

Missing the update to release notes

Comments from the review on Reviewable.io

...and a test case

Comments from the review on Reviewable.io

Fixes https://github.com/vaadin/components/issues/23

Reviewed 3 of 3 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from the review on Reviewable.io


Update base image version to 0.11.0-beta5

Release notes: https://github.com/blakeblackshear/frigate/releases/tag/v0.11.0-beta5
Docs for the beta: https://deploy-preview-2829--frigate-docs.netlify.app/
Built and tested to make sure the image works.

@deviant77, thanks once again. I created a matching release. Looking forward to the full 0.11.0 release.


Update config schema to latest spec

@FlorianRappl any idea why I'm getting the TypeError? I've updated all core dependencies locally but I still get that error.

I'm not sure what error you get. Sometimes removing the package-lock and node_modules and reinstalling helps.

I'm not sure what error you get. Sometimes removing the package-lock and node_modules and reinstalling helps.

If you look at the build failure, you'll see that it complains that TypeError: Cannot read property 'Array' of undefined when i do Type.Array but on the UI this works fine though. The error is only within the tests.

Thanks for clarifying @ivange94 . The error comes because of:
import { Type } from '@openmrs/esm-config';

remember that for the tests @openmrs/esm-config is mocked. The mock does not expose a Type. Thus this is undefined.
Here is the mock used:
https://github.com/openmrs/openmrs-esm-patient-registration/blob/master/__mocks__/openmrs-esm-module-config.mock.tsx

@ivange94 I merged the changes so now it's easier to tell what's going on by reading the code. Is it clear?

Thanks @FlorianRappl, @brandones I've fixed the merge conflicts and also the broken tests.

Excellent! Thanks @ivange94 !


Fixes clipboard not respecting parent restrictions

Cleanup toolbar code (reducing queries).
Reduces queries in clipboard rendering.
Fixes #4913

Changelog?

@vxsx because not everything has been updated in changelog, I decided to just go through my prs and update changelog individually prior to release.

hmm although when I forward port this to 3.3.x would be good to have it there.. ok you win :)

As explained by @vxsx here, frontend tests are not possible before 3.4.

LGTM, does this pass manual testing?

@mkoistinen yup. will also get @genti94 to test after merge.


Merging FilterContext and BlendContext

Now it is fully ready to do merge FilterContext and BlendContext.
The only difference between them is that BlendContext owns Row and FilterContext borrows Row.
Using Cow, both can be unified.

Please note! If you want to and up merging the big changes I've made to the way we SELECT this will be a waste of time as I have gotten rid of both of these things.

@KyGost Oh, isn't that for the fork you made (https://github.com/SyRis-Consulting/gluesql)?
I didn't know that you are considering to merge to here.

@KyGost Oh, isn't that for the fork you made (https://github.com/SyRis-Consulting/gluesql)?
I didn't know that you are considering to merge to here.

If it provides notably better performance I would suggest merging it here (to main) as it would be beneficial to all.
Note that any future development I do with/for GlueSQL (assuming that the performance is better) will likely be on top of that branch.

@KyGost Ok, as we discussed before, the reason which cannot be merged is not simply the matter of performance.
At least, I don't have any plan to give up no-mut policy and iterator laziness in here.
This is the point.

Note that any future development I do with/for GlueSQL (assuming that the performance is better) will likely be on top of that branch.

Your current work is already made on top of that branch and the reason you forked was disagreement about strict policies, auto increment, etc between us. It means that any further work on that branch cannot be merged to here.
It's fully ok to have different ideas between us and I really appreciate to your participation and the fork you are doing.
However, branches cannot be merged because neither of us will not change the mind.


Source Code!

When to open access the source code!

Still in the process of organizing, will be launched soon.

Still in the process of organizing, will be launched soon.

Thank you very much!
Can you share the paper, I am very interested in your paper and work!

Camera-ready version will be uploaded shortly, and later I will consider uploading it to GitHub as well.

Camera-ready version will be uploaded shortly, and later I will consider uploading it to GitHub as well.

Can you share the paper, I am very interested in your paper and work! Thanks again!

Camera-ready version will be uploaded shortly, and later I will consider uploading it to GitHub as well.

Can you share the paper, I am very interested in your paper and work! Thanks again!

Already uploaded:
https://github.com/JPWang-CS/FreqFormer/tree/main/article

Camera-ready version will be uploaded shortly, and later I will consider uploading it to GitHub as well.

Can you share the paper, I am very interested in your paper and work! Thanks again!

Already uploaded: https://github.com/JPWang-CS/FreqFormer/tree/main/article

Thank you very much!


feat(ingestion/sqlglot): add optional default_dialect parameter to sqlglot lineage

Problem Statement:
Currently, it is not possible to parse a query using trino as a dialect while specifying iceberg as a platform in Datahub.
Proposed Solution:
To address this, introduce a new optional parameter named default_dialect. This parameter will override the platform parameter when it is set.
Rationale:
Since iceberg is neither a query engine nor a database, it is commonly used in conjunction with trino as the query engine. When ingesting data into Datahub, the platform specified is iceberg, but sqlglot does not support iceberg as a dialect, which is the expected behavior.
By adding the default_dialect parameter, users can explicitly specify trino as the query dialect while using iceberg as the platform, ensuring proper query parsing and ingestion.
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

New Features

Introduced a default_dialect parameter to improve SQL lineage parsing. This allows users to specify a default SQL dialect where necessary, enhancing flexibility and accuracy.

Enhancements

Updated SQL parsing logic to utilize the default_dialect parameter when provided, ensuring better dialect selection for SQL lineage.

@hsheth2 reformatted the file according to the checks


Available code

Great work! When will the code be available?

Thank you all for your interest in our work. Our paper is currently under peer review, and we are cleaning the code. We will release it once the paper is accepted. We sincerely apologize for not responding to everyone's emails. Please stay tuned!
非常感谢大家对我们工作的关注。我们的论文目前正在审稿中，我们也正在对代码进行整理。论文一旦被接收，我们会立即发布。非常抱歉未能回复每个人的邮件，敬请期待！


Bug: DECIDE condition where special MOVE EDITED is used

The MOVE EDITED seems to mess with the condition.

DEFINE DATA
PARAMETER
1    PARM
2  GÆLDER-FRA-DATO           (D)
2  GÆLDER-FRA-DATO-FJL       (L)
2  GÆLDER-FRA-DATO-GL        (D)
2  VALG-KODE (A01)
LOCAL
1 W-FGR (N3)
1 SDTRANSA
2 POLI-FINDES (L)
END-DEFINE
DECIDE FOR FIRST CONDITION
WHEN W-FGR = 655 OR = 653
MOVE EDITED PARM.GÆLDER-FRA-DATO-GL (EM=DD-MM-YYYY').') TO ZX-TEKST
WHEN (W-GL-STATUS = 'POLI' OR = 'TILB') AND PARM.VALG-KODE = 'P'
ASSIGN POLI-FINDES = TRUE
WHEN NONE
IGNORE
END-DECIDE
END

Getting same diagnostic for same MOVE EDITED construction in these statements:
MOVE EDITED W-WORK-DATO-D (EM=DD-MM-YYYY').') TO ZX-TEKST
IF SZVAH2AA.POLICE-VARIANT-STATUS (W-IX) = 'XXXX'

The EM= doesn't terminate correctly on its RPAREN so it stops at the RPAREN of (W-IX) in the if condition. Hence everything before was consumed in EM and TO/INTO is expected

I guess the ‘).’ is just a string to be printed after the date. But I can see the trouble

You can test #376 if you want, should resolve the issue :)

Cool, first thing Monday. :) Have a nice weekend.


Fine tune first stage models on my own data set

Hello, the GLDM project is indeed inspiring. However, when I attempt to fine-tune the first-stage models on my own dataset using settings ldm_con+wae_uncon.yml, I encounter the following issues:
       size mismatch for _full_graph_encoder._embed.weight: copying a param with shape torch.Size([166, 64]) from checkpoint, the shape in current model is torch.Size([147, 64]).
        size mismatch for _full_graph_encoder._model._first_layer.lins.0.weight: copying a param with shape torch.Size([64, 123]) from checkpoint, the shape in current model is torch.Size([64, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.lins.1.weight: copying a param with shape torch.Size([64, 123]) from checkpoint, the shape in current model is torch.Size([64, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.lins.2.weight: copying a param with shape torch.Size([64, 123]) from checkpoint, the shape in current model is torch.Size([64, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.films.0.weight: copying a param with shape torch.Size([128, 123]) from checkpoint, the shape in current model is torch.Size([128, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.films.1.weight: copying a param with shape torch.Size([128, 123]) from checkpoint, the shape in current model is torch.Size([128, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.films.2.weight: copying a param with shape torch.Size([128, 123]) from checkpoint, the shape in current model is torch.Size([128, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.lin_skip.weight: copying a param with shape torch.Size([64, 123]) from checkpoint, the shape in current model is torch.Size([64, 104]).
        size mismatch for _full_graph_encoder._model._first_layer.film_skip.weight: copying a param with shape torch.Size([128, 123]) from checkpoint, the shape in current model is torch.Size([128, 104]).
        size mismatch for _partial_graph_encoder._embed.weight: copying a param with shape torch.Size([166, 64]) from checkpoint, the shape in current model is torch.Size([147, 64]).
        size mismatch for _partial_graph_encoder._model._first_layer.lins.0.weight: copying a param with shape torch.Size([64, 124]) from checkpoint, the shape in current model is torch.Size([64, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.lins.1.weight: copying a param with shape torch.Size([64, 124]) from checkpoint, the shape in current model is torch.Size([64, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.lins.2.weight: copying a param with shape torch.Size([64, 124]) from checkpoint, the shape in current model is torch.Size([64, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.films.0.weight: copying a param with shape torch.Size([128, 124]) from checkpoint, the shape in current model is torch.Size([128, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.films.1.weight: copying a param with shape torch.Size([128, 124]) from checkpoint, the shape in current model is torch.Size([128, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.films.2.weight: copying a param with shape torch.Size([128, 124]) from checkpoint, the shape in current model is torch.Size([128, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.lin_skip.weight: copying a param with shape torch.Size([64, 124]) from checkpoint, the shape in current model is torch.Size([64, 105]).
        size mismatch for _partial_graph_encoder._model._first_layer.film_skip.weight: copying a param with shape torch.Size([128, 124]) from checkpoint, the shape in current model is torch.Size([128, 105]).
        size mismatch for _decoder._first_node_type_selector._final_layer.weight: copying a param with shape torch.Size([166, 256]) from checkpoint, the shape in current model is torch.Size([147, 256]).
        size mismatch for _decoder._first_node_type_selector._final_layer.bias: copying a param with shape torch.Size([166]) from checkpoint, the shape in current model is torch.Size([147]).
        size mismatch for _decoder._node_type_selector._final_layer.weight: copying a param with shape torch.Size([167, 256]) from checkpoint, the shape in current model is torch.Size([148, 256]).
        size mismatch for _decoder._node_type_selector._final_layer.bias: copying a param with shape torch.Size([167]) from checkpoint, the shape in current model is torch.Size([148]).

The _node_type_index_to_string in your project has a value of 166, whereas for my preprocessed data, it's 147. How can I modify it for my own fine-tuning?

Hello Zhichao,
The length of the _node_type_index_to_string variable basically refers to the kinds of motifs/atoms in the dataset. If you want to use GLDM on your own dataset, I suggest you train the model from scratch since the type of motifs/atoms in your dataset differs from ours.
Otherwise you can consider appending zeros to your node feature matrix along the feature dim to increase it from 147 to 166. But that means there are chances the model will predict the node type to be something that never exists in your dataset, so you will have to mask the appended features in the end.
Hope this helps!
Cheers,
Conghao

Thanks for your valuable advice.
But I still think the pretraining stage is of great importance due to data scarcity. Currently, I'm addressing this issue by preprocessing my own dataset following the MoLeR procedures. Notably, during preprocessing, I included the same metadata containing motifs/atoms information from GuacaMol to guarantee the same model architecture.
Another thing I want to ask is that the model in your article is also pretrained on GuccaMol and subsequently fine tuned on the L1000 dataset. In fact, these two datasets may also possess different motifs/atoms information, so does this effect the generation process and how do you deal with this issue?

I use the motifs/atoms extracted from the GuacaMol dataset when finetuing on the L1000 dataset. L1000 dataset is too small. It only contains around 7 thousand molecules, which covers a very limited chemical space for the model to learn. I think the motifs or atoms emerged in the L1000 dataset are also not representative enough.
If your dataset is also small like L1000, it might be good to pretrain the model on a large dataset such as GuacaMol first and use the same motifs/atoms to finetune on the target dataset.
Cheers,
Conghao

Thanks for your answer. I've learned a lot from your work.


Backporting required changes to the release branch

The changes required to be backported to the current release (#15609)

/azp run

/azp run


Consistent use of terminology such as Internet-Draft and I-D

Describe the issue
Datatracker ought to be consistent with established style in using terms like “Internet-Draft” and “I-D”. This is pretty widely used but there are some places where it is not yet. A few examples:
a)  on the Important Dates page:
s/Internet Draft/Internet-Draft
s/for all drafts/for all I-Ds
b) In the Documents menu (screenshot attached):
s/Drafts/I-Ds
c) In the meeting proceedings page (e.g. https://datatracker.ietf.org/meeting/115/proceedings):
s/Drafts/I-Ds
(screenshot attached)

Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

@larseggert What's your reaction to removing the bare "Draft" word from the UI?

Fine by me

Note that important dates is just an example - the issue is intended to cover the entire datatracker.


Can this be used for rgbd data from other devices?

Thank you @rmbashirov for open sourcing this piece of art. Can we use this for RGB-D data from other sources like iPhone TrueDepth or other sources?
If this can be done, where shall we provide the camera intrinsic?

No


[Tooltip] Add missing classes type definitions

[x] I have followed (at least) the PR section of the contributing guide.

Closes #18600

@dufia It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


Does this plugin support multiple user roles?

Like

admin

Manager

User

etc?
With different access permissions?

No it does not. Please read the documentation and a simply look at the source code reveals that it doesn't, there is no "Auth" folder.
You can use this pluing https://github.com/burzum/cakephp-simple-rbac it allows you to define multiple roles, they have to be returned as an array by the users table roles field per default but this is configurable. It's called simple for a reason, if you want a role hierarchy with in heritage you might need to look for something else.


fix 'Open PearAI' button

(My first PR)
Description
This PR changes the target attribute from a default _self to _parent, which changes the frame in which the link is opened.
Related Issue
#263
Changes Made
This PR changes the target attribute from a default _self to _parent, which changes the frame in which the link is opened.
Video
That's how it works after fixing
https://github.com/user-attachments/assets/00192250-b8c6-4ccd-95f4-dd9a2b5abdc8
Checklist

[x] I have tagged the issue in this PR.
[x] I have attached necessary screenshots.
[x] I have provided a short description of the PR.
[x] I ran yarn build and build is successful
[x] My code follows the style guidelines of this project.
[x] I have added necessary documentation (if applicable)

Nice ty! did not know about this one