banner responds to every click, even overlaid showModalBottomSheet

I use a banner.
In certain cases, a bottom sheet opens and overlays the banner.
In the Bottom Sheet there is a button at the bottom, which is at the same position as the banner. When I click on the button, the link of the banner opens safari instead of the button responding.
How can I stop this behavior? I tried useRootNavigator: true, within showModalBottomSheet but it is not working.
 Future<void> future = showModalBottomSheet(
        //clipBehavior: Clip.none,
        isScrollControlled: true,
        context: context,
        backgroundColor: Colors.transparent,
        builder: (BuildContext context) {
          return StatefulBuilder(
              builder: (BuildContext context, StateSetter mystate) {
            return Material(
              child: Container(
...

ElevatedButton(
                        onPressed: () async {

google_mobile_ads: 1.2.0

Hi @desmeit, please provide a completed and minimal reproducible code sample so that we may verify this. Also, please provide the output of flutter doctor -v as well.
Thank you!

import 'dart:io';

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:google_mobile_ads/google_mobile_ads.dart';

class AdaptiveBannerAd extends StatefulWidget {
  const AdaptiveBannerAd({Key key}) : super(key: key);

  @override
  State<AdaptiveBannerAd> createState() => _AdaptiveBannerAdState();
}

class _AdaptiveBannerAdState extends State<AdaptiveBannerAd> {
  String get bannerAdUnitId {
    /// Always test with test ads

    if (kDebugMode) {
      //return MobileAds.bannerAdTestUnitId;
      return 'ca-app-pub-3940256099942544/6300978111';
    } else {
      if (Platform.isIOS) {
        return 'ca-app-pub-5218666471883335/9223358793';
      } else if (Platform.isAndroid) {
        return 'ca-app-pub-5218666471883335/5970455590';
      }
    }
  }

  BannerAd _bannerAd;
  bool _isBannerLoaded = false;
  AnchoredAdaptiveBannerAdSize size;

  @override
  void initState() {
    // TODO: implement initState
    super.initState();
  }

  @override
  void didChangeDependencies() {
    super.didChangeDependencies();
    _initBannerAd();
  }

  Future<AnchoredAdaptiveBannerAdSize> anchoredAdaptiveBannerAdSize(
      BuildContext context) async {
    // Used to set size of adaptive banner ad according to device width and orientation.
    return await AdSize.getCurrentOrientationAnchoredAdaptiveBannerAdSize(
        MediaQuery.of(context).size.width.toInt());
  }

  _initBannerAd() async {
    size = await anchoredAdaptiveBannerAdSize(context);
    print("anchoredAdaptiveBannerAdSize size: " + size.toString());

    _bannerAd = BannerAd(
      size: size,
      adUnitId: bannerAdUnitId,
      listener: BannerAdListener(
        onAdLoaded: (ad) {
          setState(() {
            _isBannerLoaded = true;
          });
        },
        onAdFailedToLoad: (ad, error) {},
      ),
      request: AdRequest(),
    );
    _bannerAd.load();
  }

  @override
  Widget build(BuildContext context) {
    return _isBannerLoaded
        ? Container(
            height: size.height.toDouble(),
            width: size.width.toDouble(),
            child: AdWidget(ad: _bannerAd))
        : SizedBox();
  }
}

Hi @desmeit
For the issue to be workable, it needs to be reproducible with a completed and minimal reproducible code sample. Please provide such a sample.
Thank you!

Thanks but this is not helping me. I cannot share my app and also its not possible to create a new one for this test.
So I have to remove Admob from my app.

I have created a minimal app.
Please change GADApplicationIdentifier to show the ads.
When I open the bottom sheet and click on the ElevatedButton on the bottom, it should actually output "enter value". It does but it additionally triggers the ad and opens the Safari browser. this should only happen if I click directly on the ad, not on the overlaid bottom sheet. I tested only IOS so far.
Some ads show the problem, some don't. Unfortunately, the test ad cannot reproduce it:
I used the test ad ca-app-pub-3940256099942544/6300978111 in the example. Here the issue does not occur. The issueoccurs only in Production Mode, when an animated ad comes. An example was an ad from Consors Bank with the link "https://aktionen.consorsbank.de/ev/tagesgeld/?partnerId=DI5adl&aid=di000085&cid=DIS-234".
Does this answer your questions?
If there are further questions, please write.
Here you find the app: https://we.tl/t-Nl3d9VrdLb

Hi @desmeit, thanks for providing the sample code.
But I can not reproduce the issue on the latest stable and master channels with test ad IDs (same as you). I also tried with the latest ads version: google_mobile_ads: ^2.0.1 but the result is still the same.
When clicking on the button, the banner ad does not respond.

Demo
https://user-images.githubusercontent.com/104349824/185626960-28122f45-78bd-44d8-8cce-2b2c24aef73e.mp4

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.2.1 21D62 darwin-x64, locale en-VN)
    • Flutter version 3.0.5 at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (9 hours ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.69.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.2362, on macOS 12.5 21G72 darwin-x64, locale en-EE)
    • Flutter version 3.1.0-0.0.pre.2362 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 75ee440329 (9 hours ago), 2022-08-19 05:59:26 +0200
    • Engine revision 5c30ead197
    • Dart version 2.19.0 (build 2.19.0-112.0.dev)
    • DevTools version 2.16.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (3 available)
    • iPhone 13 (mobile) • 2526BC1A-435D-4B08-B99C-44B928F2517B • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)
    • macOS (desktop)    • macos                                • darwin-x64     • macOS 12.5 21G72 darwin-x64
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 104.0.5112.101

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

As I can see from the sample code, you're using the old plugin version: google_mobile_ads: ^1.2.0. Could you please try upgrading to the latest version (2.0.1) and try reproducing the issue again in Production Mode?

Hi @huycozy
I cannot switch to 2.0.1 because I'm using 2.10.5 flutter version.
As I said the issue occurs only with some specific ads, for example the consorsbank ad.
please see the screencast in addition. here you can see whats happen if I click on my button on the bottom:
https://we.tl/t-IzivvIS9Wg
it triggers the ad.

@desmeit thank you so much for providing the demo video in production mode. Labeling this issue for further investigation from the team!

I'm having the same issue.
The banner ad behind the bottomsheet, responds the click action.
This issue does not comply with admob policies and is very bad in terms of user experience.
The issue occurs in ios production mode.
I am using the latest version: google_mobile_ads: ^2.2.0

@huycozy - do we have a reproducible sample or just a video for this issue?

@timothyhoang-google:
@desmeit and I also couldn't reproduce this issue with test ads. Per https://github.com/googleads/googleads-mobile-flutter/issues/629#issuecomment-1216810081 and https://github.com/googleads/googleads-mobile-flutter/issues/629#issuecomment-1220728294, the bug only occurs with production and specific ad content.
@desmeit Your demo video in link above is expired, can you please share it here again? (attaching raw video to GitHub comment, to make sure it will not be expired)

Can anyone please have a look on this issue? I'm having it with my app when displaying production ads. Cannot provide reproducible code sample as the code for ads config is strictly confidential. But here's a recording, the ad is opened even when I tapped on pink area (which is a modal bottom sheet)

Isn't showing an overlay like (bottom sheet navigator) over an ad content against Google Ads / Admob policies?

@desmeit Did you resolve this issue? Please guide us!


Handle all dree options

Hello, I've noticed this action and I think it's similar (but with different purpose) with this other action: ga-dree.
I would invite you to look at the possible options and see if you could add something to your options.

@euberdeveloper  We used a different tree package that offers more extensive features. Our usage is focused on outputting tree logs, which need to be written into the README.md file. We might need an additional action like github-action-modify-file-content.

@euberdeveloper I think you are promoting your dree, and I think I can switch to it.

I'm already using dree. 😄

Yes, I was saying that there can could be further configurations for the action, that could reflect dree's config


Steam login not working

Not working steam login after EAC update

Steam login requires DLL injection to work so it's permanently broken now.


Install on OSX error

$ docker-compose up
WARNING: The OPEN_OCR_INSTANCE variable is not set. Defaulting to a blank string.
Pulling openocrworker (tleyden5iwx/:latest)...
ERROR: Error parsing reference: "tleyden5iwx/" is not a valid repository/tag

My fault. Need setting up the env first.
$ export OPEN_OCR_INSTANCE=open-ocr-2

Thanks for reporting how you fixed it!


Multiple same tags in blog

When creating a new blog, the system should prevent the addition of the same tag multiple times as it is redundant and does not add any meaningful information.

Resolved!


Debugger fails with SyntaxError when using an external directory for TypeScript (outDir)

Does this issue occur when all extensions are disabled?: Yes

Commit: 379476f0e13988d90fab105c5c19e7abc8b1dea8
Date: 2021-08-04T23:13:12.822Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Windows_NT x64 10.0.19042
TypeScript: 4.3.5
Steps to Reproduce:

Follow the TypeScript tutorial here: https://code.visualstudio.com/docs/typescript/typescript-tutorial
Then follow this one: https://code.visualstudio.com/docs/typescript/typescript-compiling
Then follow this one: https://code.visualstudio.com/docs/typescript/typescript-debugging
Debugging should now work as expected
Change tsconfig.json outDir to an absolute directory that is still within the workspace (e.g. D:\\OneDrive\\Programming\\Personal\\TypeScript\\Sandbox\\out where D:\\OneDrive\\Programming\\Personal\\TypeScript\\Sandbox is the workspace root)
Change launch.json outFiles to an absolute directory that matches that new output directory (e.g. D:\\OneDrive\\Programming\\Personal\\TypeScript\\Sandbox\\out\\**\\*.js)
Debugging should still work as expected
Now change outDir and outFiles to a totally different directory that is outside the workspace (e.g. D:\someNewDirectory)
Expect: Debugging still works as expected
Actual: SyntaxError: Unexpected token ':'

I appreciate I must be doing something dumb here. I'm new to TypeScript and Node and finding it difficult to narrow down where the issue is coming from (VS itself, some TypeScript setting, some node setting, etc.). I have tried various search engine attempts to narrow it down but have failed to find any obvious issues and it's hard for me to work out what VS Code is doing. I apologise in advance if this is a dumb issue, but a section in the tutorial about using an external directory would be super helpful at the very least to understand how it's working.
I have attached the project and commented the 2 directories where one works and the other does not (launch.json and tsconfig.json). Hopefully this is something trivial and this issue will at least help other people find the issue :). I installed TypeScript globally and additionally tried to use settings.json to tell VSCode to use my global version rather than the one installed with VSCode to see if that would make any difference (and tell VSCode to use that version by doing the version switching command) but I get the same issue.
Full error in debug console:
Debugger attached.
Waiting for the debugger to disconnect...
d:\OneDrive\Programming\Personal\TypeScript\Sandbox\src\sandbox.ts:1
let message: string = 'Hello Newwwwwwwer World';
^
SyntaxError: Unexpected token ':'
at Object.compileFunction (node:vm:355:18)
at wrapSafe (node:internal/modules/cjs/loader:1022:15)
at Module._compile (node:internal/modules/cjs/loader:1056:27)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
at Module.load (node:internal/modules/cjs/loader:972:32)
at Function.Module._load (node:internal/modules/cjs/loader:813:14)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
at node:internal/main/run_main_module:17:47
Sandbox.zip

@roblourens this looks like a bug in findTextInFiles, searching for source mapping URLs using options

no matches are found

Taking a closer look at https://github.com/microsoft/vscode/blob/6d0d2dc6b3f28386ce7cd4a8b5d54d4777380cba/src/vs/base/common/glob.ts#L29
I believe that the pattern part of RelativePattern shouldn't be something like "../" that doesn't directly match on the base. Rather, this should be normalized into base before getting passed in. It also seems that the vscode filewatcher API doesn't handle RelativePatterns with a "../" pattern by watching the parent dir, so I'd expect that the findTextInFiles API also doesn't resolve the parent like that.


Unicode decode error

The pymongo driver is very strict and if it can't decode a mongo document it raises an exception.
This is turning up in export where apparently (after 12 minutes or so) a Post with an encoding error turns up and crashes the entire export process. Which is bad.

https://github.com/mongodb-labs/mongo-connector/issues/101

To fix this, I wrote a white list of Post IDs:
Wrote 566142 Posts IDs in 644.759 seconds

Post.objects.count() == 566142

Wrote a script called blaze.py - which goes through and attempts to find any bad decoding errors in posts:
100%|███████████████████████████████████████████████████████████████████████████████| 566142/566142 [02:09<00:00, 4365.45id/s]
Phase One: wrote 566142 Posts IDs in 2 minutes 9 seconds
100%|█████████████████████████████████████████████████████████████████████████████| 566142/566142 [37:09<00:00, 267.01posts/s]
Phase Two: wrote 2 Post errors in 37 minutes 9 seconds

It only came up with 2 errors:
"571a333ac1808103a0d6067c",'utf-8' codec can't decode byte 0xed in position 48824: invalid continuation byte
"57726c2ac1808103a5ed63d6",'utf-8' codec can't decode byte 0xed in position 21004: invalid continuation byte


remove the indirect dependency on arrayvec

I ran cargo test after turning off default-features and everything continued to work as expected.
This will result in projects depending on this crate no longer pulling in an old arrayvec.

Is a release of version = "0.1.2" planned for the at some time in the near future?

Is a release of version = "0.1.2" planned at some time in the near future?

No, this crate has been feature-complete for a while so I don't plan work for it. I'm amenable to releasing new versions if changes get merged.

Is the removal of the dependency on arrayvec considered a worthwhile change?

Thanks for the change! Sorry for not merging this sooner, I lost track of it. There are a few other small PRs and issues outstanding right now. When those get resolved I will probably push a new release.


Controller: syntax error, unexpected tASSOC, expecting '}'

Hi,
I tried the example given at the bottom of https://github.com/apneadiving/Google-Maps-for-Rails/wiki/Controller but I get a double "syntax error, unexpected tASSOC, expecting ..." on the "marker.json" line.
Do you see any reason why this would happen ?
Thanks

sorry, brackets are necessary, updated my example

Thanks, should have thought about it.


New version: ApproximateVI v0.1.8

Registering package: ApproximateVI
Repository: https://github.com/ngiann/ApproximateVI.jl
Created by: @ngiann
Version: v0.1.8
Commit: 0fea4ce069203fd3b89e2dbc8c936d157c722507
Git reference: HEAD
Description: Approximate variational inference in Julia

@JuliaRegistrator register


Frees[F, ?] to M program interpretation implicit def

I am not sure if this is an implicit I would put in the default implicits object.
In the end this is just an implicit conversion and while that may be convenient in some cases, I am not sure if implicit interpretation is a good idea and adding it to the commonly used frees.implicits._ import might catch people by surprise.
We provide some implicit conversions in the frees-http extensions but there they are at least a little constrained (you need a Marshaller, EntityEncoder, ...).

It makes sense to me. Let me think about where that might fit better, any suggestions are welcome :)


Cannot find java

When using this image as part of a github action it cannot find java

I'm going to investigate this.

We've found the issue.
When using this image together with the github setup-java the JAVA_HOME path is set differently from the path in the container. This causes the problem.
      - name: Set up Java 17
        uses: actions/setup-java@1df8dbefe2a8cbc99770194893dd902763bee34b # v3.9.0
        with:
          java-version: '17'
          distribution: 'microsoft'


Stuck on Beta 0.2.0-B2

Hi there :-)
Somehow I'm stuck on 0.2.0-B2, HACS is promoting an update to 0.2.3, but it does nothing when I click it. When I try to open the Integration Page there is a "Unknown Error".
Tried a few things, including deleting the deps folder and poking around in .storage. Whilst doing that I recognized that
.storage/hacs/repository/396083412.hacs
is missing.
Can someone send me that file, maybe that solves my problem?
Best regards
Michael

Following Logs come alog with that:
Logger: homeassistant.components.websocket_api.http.connection
Source: custom_components/hacs/repositories/integration.py:157
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 27. Juli 2022 um 15:21:43 (8 occurrences)
Last logged: 14:23:06
[139737589302128] Error handling message: Unknown error (unknown_error)
[139737475063600] Error handling message: Unknown error (unknown_error)
[139736987031664] Error handling message: Unknown error (unknown_error)
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/decorators.py", line 27, in _handle_async_response
await func(hass, connection, msg)
File "/config/custom_components/hacs/websocket/repository.py", line 40, in hacs_repository_info
await repository.update_repository(ignore_issues=True, force=True)
File "/config/custom_components/hacs/utils/decorator.py", line 28, in wrapper
result = await function(*args, **kwargs)
File "/config/custom_components/hacs/repositories/integration.py", line 110, in update_repository
if manifest := await self.async_get_integration_manifest():
File "/config/custom_components/hacs/repositories/integration.py", line 157, in async_get_integration_manifest
raise HacsException(f"No {RepositoryFile.MAINIFEST_JSON} file found '{manifest_path}'")
custom_components.hacs.exceptions.HacsException: No manifest.json file found 'custom_components/None/manifest.json'

Hi there :-)
Somehow I'm stuck on 0.2.0-B2, HACS is promoting an update to 0.2.3, but it does nothing when I click it. When I try to open the Integration Page there is a "Unknown Error".
Tried a few things, including deleting the deps folder and poking around in .storage. Whilst doing that I recognized that
.storage/hacs/repository/396083412.hacs
is missing.
Can someone send me that file, maybe that solves my problem?
Best regards
Michael

The file .storage/hacs/repository/396083412.hacs  does not exist in my HomeAssistant.
Sounds like some files is bad or missing.
Try download this repository and put midea_ac_lan into custom_components folder manually?

Yes, already tried that, no change

The file .storage/hacs/repository/396083412.hacs does not exist in my HomeAssistant.
Sounds like some files is bad or missing.
Try download this repository and put midea_ac_lan into custom_components folder manually?

Yes, already tried that, no change

The file .storage/hacs/repository/396083412.hacs does not exist in my HomeAssistant.
Sounds like some files is bad or missing.
Try download this repository and put midea_ac_lan into custom_components folder manually?

How about now? It was solved?

No, not solved yet.
But I again copied the repository manually into the custom folder and that changed the version, there are differences in the menu for example. Manually upgrading works, so far so good.
The empty hacs update notification stays.
Could you please send me this file:
.storage/hacs/repository/396083412.hacs
Maybe it helps :/


Fix link in README.md

Hi @mtausig thank you so much for your first contribution.
Although your changes looks good I must close this PR as your are targeting our main branch, unfortunately is mandatory by our Contributing Guideline to point dev branch as destiny of PR.
Please take a look to Contributing and make a new PR, it will be very welcome.
If you need some help feel free to contact me by email.
Kind regards.


csvw: common property names can be URLs

@JeniT Is this kosher?

I imagine so given the tests pass :)

Righto 👍


refactor!: Delete MLAPI Installer

Removes the old MLAPI installer in favor of the Unity Package Manager.

This also helps remove a lot of XMLDoc warnings since the MLAPI Installer was not XMLDoced.

Nice, also means we don't need to document the 3rd party "ZipStorer" thing now, one less thing on my list.
But we're saying that there's nothing but the MLAPI installer in that whole file?   Somehow I thought it would also include things like the bit that helps you pick a transport in the NetworkManager.


Changing access modifiers in UseCaseThreadPoolScheduler to private

These access modifiers can be private. Not sure why these would need to be public.

@googlebot I signed it!


Show more complete information under kubectl explain for Templates

Description of problem
I am finding that using kubectl explain is incredibly helpful in understanding and composing templates and supply chains. However, the information yielded by kubectl explain seems incomplete, making it difficult to grasp how to configure or troubleshoot certain things.
For example, in ClusterSourceTemplate, the urlPath and revisionPath tell the template where to get the values it will map to some output fields but kubectl explain clustersourcetemplate… does not show the output fields.
Proposed solution
Given there are fields in a spec
When a user explores the spec using `kubectl explain`
Then all fields appear in the output

One frustration I've discovered is that explain just smashes the whole description together.
Below is k8s own podspec showing a table, but explain smooshing it to pieces


Half-day holidays

In Germany, Christmas Eve and New Years Eve are special days where businesses close around noon. They are not offical holidays but "half-day holidays" by law. This applies to all federal states.
There are also "silent days" where things like dancing are prohibited. Those days vary between federal states.
Is there a way to represent those dates in Yasumi?

Yasumi is designed with no particular restriction on how holidays defined. It is possible to represent those holidays in Yasumi just as any other full holiday. What matters more is how you like to use that information in your application or project, i.e. your business case.

Christmas Eve and New Years Eve are both days where businesses have to close earlier by law in Germany (the time varies by federal state). So I've expected them to be included in the list of holidays, tagged in a way that I could filter those dates out. Still, both days are no official holidays and none of the available types really fits (well, "others" always works).
So I actually have two requests or questions:

Would you be open to include another type in the library, like "partly", that represent those days? With that kind of type, both days could be added to the German holidays while still keeping things filterable.

Additionally, would it be possible to to have an additional property defining if a holiday is silent or not (where silent means that there might a dancing ban or other restrictions for public events)? That's something different than the type because e. g. Good Friday is an official and silent holiday at the same time.

@nilshoerrmann My apologies for the prolonged response. As there are a few more such cases, I am in the process of redesigning how the holidays can get classified. Your examples of half days and 'silent' days could be supported as well.

I am using yasumi now for the first time (from germany) and we have the same problem with new years eve.
If we have to decide, in my opinion, its more a working day then a holiday.

@heikoter Yes it is not straightforward as it seems. In the end it may be only relevant how you want it to be in your own application, ie. your business rules/logic. Personally I tend to follow the official, legal definition of each country.
Perhaps the best way to look at this is how you in Germany distinguish Werktage and Arbeitstage (https://en.wikipedia.org/wiki/Business_day)

Look right under: "Public Life"
https://www.timeanddate.com/holidays/germany/new-year-eve

I like the definition from the link: "New Year's Eve is traditionally a partial non-working day". So, is the glass half full or half empty, is it a holiday or not? That certainly depends on the perspective or the context but it's definetly a special day.
Personally, I think the German words "Werktag" and "Arbeitstag" are not helpful in this context: "Werktag" is everything Yasumi is not about and "Arbeitstag" always depends on the context of a person, it's not universal. And looking at New Years Eve: it's definetly a "Werktag" but not a full one because it preludes a public holiday and has reduced business hours.
So currently, Yasumi offers official, observance, season, bank and other as types. My initial request was to have two additional types: partly for those half business days, half closed days. And silent for public holidays where the law forbids parties ("stille Feiertage"). I don't mind the actual names but it would be great if those day could be classified in and thus filtered by the library.

In the end it may be only relevant how you want it to be in your own application, ie. your business rules/logic.

As a developer, I do not have intimate knowledge of holiday rules and conventions in other countries than my own. I would prefer if I could delegate this kind of business logic to an external library like Yasumi.
If my application needs to show e.g. work-free days or days when banks are closed, I would like to get this information from the library rather than having to investigate the specific rules for each country supported by my application.
Obviously a library cannot support all possible use-cases, but I suspect that just a few more holiday categories could satisfy the need for the majority of applications. I previously submitted a loose proposal on holiday classification in https://github.com/azuyalabs/yasumi/issues/99.

delegate this kind of business logic to an external library like Yasumi.
That's what Yasumi is designed to do. :)


Schedule refresh not working

You can't schedule refresh for this dataset because the following data sources currently don't support refresh:
Data source for "Network Interfaces"
Data source for "Resource Groups"
Data source for Resources
Data source for "Public IPs"
Data source for "Virtual Machines"
Data source for "Get Recommendations"
Data source for "Get Security Center Alerts"
Data source for "Azure Regions"
Data source for "RBAC Role Definitions"
Data source for "RBAC Role Users"
Data source for TaggedResourceGroups
Data source for TaggedResources
Data source for "RBAC Role groups"
Data source for "RBAC Role Users and Groups"
Data source for "Service Principals"
Data source for NSGs
Data source for "Security Tasks"
Data source for "Security Tasks Final"
Data source for "VNET Peerings"
Data source for "Virtual Networks"
Data source for Subnets
Data source for Disks
Data source for ComputeResourcesUsage
Data source for NetworkResourcesUsage
Data source for StorageResourcesUsage
Data source for "Security Recommendations"
Discover Data Sources
Query contains unsupported function. Function name: Web.Contents

Hi @Sandaal
The CCO dashboard is a discovery tool (not a real time monitoring tool). Schedule refresh is currently not supported by the current data model. You'll need to refresh manually the dashboard everytime you want to see updated data.
Alternatively you can try to configure scheduled refresh following this procedure: https://medium.com/@martijnlentink/use-missing-skip-test-connection-in-scheduled-refresh-in-power-bi-5b3fa9a30daf


docker部署，扫码登录后报503错误

WECHATY Environment Variables: 5
WECHATY_TOKEN=“MY_TOCKEN”
WECHATY_DOCKER=1
WECHATY_PUPPET_SERVER_PORT=8080
WECHATY_LOG=verbose
WECHATY_PUPPET=wechaty-puppet-wechat
tarting Docker Container for Wechaty v1.20.2 with Node.js v16.15.0
报错日志：
09:00:33 INFO IoClient [4] https://login.weixin.qq.com/l/wZ2a6cNrjA==
Online QR Code Image: https://wechaty.js.org/qrcode/https%3A%2F%2Flogin.weixin.qq.com%2Fl%2FwZ2a6cNrjA%3D%3D
09:00:34 VERB PuppetWeChatBridge onLoad() page.url=https://wx.qq.com/cgi-bin/mmwebwx-bin/webwxnewloginpage?ticket=AS8SYJEE1ut7ltDHUltpn81k@qrticket_0&uuid=wZ2a6cNrjA==&lang=en_US&scan=1667898024
09:00:34 VERB PuppetWeChatBridge readyAngular()
09:00:34 VERB PuppetWeChatBridge inject()
09:00:34 VERB PuppetWeChatBridge inject() exception: execute proxyWechaty(init) error: 503, init() without a ready angular env. stack: Error: execute proxyWechaty(init) error: 503, init() without a ready angular env
at Bridge.inject (file:///wechaty/node_modules/wechaty-puppet-wechat/src/bridge.ts:363:15)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Bridge.onLoad (file:///wechaty/node_modules/wechaty-puppet-wechat/src/bridge.ts:214:7)
09:00:34 ERR PuppetWeChatBridge onLoad() exception: Error: execute proxyWechaty(init) error: 503, init() without a ready angular env
端口是打开的，docker是没问题的，请问是怎么回事？

你需要自己编译更新使用新版的wechaty-puppet-wechat，官方docker未包含支持uos的puppet。

A PR request to upgrade the UOS support is welcome!

你需要自己编译更新使用新版的wechaty-puppet-wechat，官方docker未包含支持uos的puppet。

请问有具体的方法吗？（虚心求教）

建议你搜索一下docker build 教程，clone仓库本地自己编译镜像。

最新Wechaty镜像，2023.7.1

@huan You may want to check this Fix Build In Workflow

Can you explain what you have done? Thanks.

Can you explain what you have done? Thanks.

I found that the publish step of the workflow did not execute correctly, I used a publish action from the marketplace instead (network Socket timeout in current publish action step).

Could you please help us to send a PR to fix the main repo?
Thanks!


Callbacks called in same tick of event loop

An important concept about functions that accept callbacks is they should never call the callback in the same tick of the event loop.
See Izaac's blog post for the full reasoning.
I've seen this in a few places in the code, but only had time to note down one.

yeah a callback there is pointless.

There are other examples in the codebase of the form which are more dangerous still, as they're non-deterministically async:
function foo(x, cb) {
  if(someTest(x)) {
    // called in same tick of event loop as call to foo()
    return cb();
  } else {
    somethingAsync(cb);
  }
}

which is non-deterministically async. AKA 'releasing Zalgo' 😱
Instead it should be:
function foo(x, cb) {
  if(someTest(x)) {
    // called in same tick of event loop as call to foo()
    process.nextTick(cb)
  } else {
    // not called in same tick - async
    somethingAsync(cb);
  }
}

The node docs on process.nextTick also have an explanation of the danger and why this prevents them.


[main] Update community files (#253)

Update community files
Signed-off-by: Knative Automation<EMAIL_ADDRESS>

OCF Webhook is merging this PR


Update BluePic-Server to Swift 3

Does this have a corresponding PR?

What's the plan regarding using both Facebook Credentials and MCA Credentials when this project is merged into develop?

#314

Here's my plan for BluePic-web:

Upgrade BluePic-Server, Watson SDK and iOS app and test functionality
Merge in the web project with facebook login disabled.  Authentication will basically be disabled at this point and the BluePic-web profile page will not be available.
Address the MCA issue of supporting JS clients in order to enable MCA/ FB auth in the web project.

Let me know your thoughts, @rfdickerson

Yeah, I think leave that line(s) of code in the project around FacebookCredentials but inside of an if-else block. At the top of the project, have a boolean variable that can be set that would toggle between MCA or Facebook Auth. We can document how to enable Facebook login by changing that variable's value in the README or something.

Another short-term fix may be to simply try to register the FB plugin first.  I believe Schmuel said that if FB creds aren't found, a 'Pass' is returned and then the next plugin (MCA) would be tried.  We tested registering MCA first, but apparently it doesn't return a 'Pass' when it fails.  Did I misunderstand?  If that's the case, it is a hacky fix, but would work until we've fixed the credentials system.

Worth a shot, let me know if that works for you.


[WIP] Update utility-apis.md

Please check : https://hackerone.com/reports/2280914

Thank you for reporting!
I reach the same conclusion as the people from HackerOne, there's no obvious vulnerability here. The token that you are exfiltrating from this PR should be a workflow token for a fork, which only has read access to backstage/backstage, or it's just a token for your own fork, bit foggy on the details there tbh. There's a mention of this security model here. Of course if we merged this PR it would be a different story, but we're not going to do that x). Will also mention that we have an org-level lock on the option to hand over write tokens to forks, so it's not possible to enable that option in any repo in the Backstage GitHub org.
To expand a bit, if this type of exploit was possible then you'd trivially be able to exfiltrate tokens from a large number of GitHub repos. You wouldn't even need to modify an existing workflow file, you could just create a new one. If this was in fact exploitable, you should report it to GitHub.

Never mind, I have the disabled the workflow for now as I believe we indeed have an issue here.

I've opened PR 21930 to add input sanitation around this PoC.
I do not have access to the report so let me know what else should be mitigated.

I guess that will work. But it's always good idea, not to write untrusted input GITHUB_ENV, Consider using GITHUB_OUTPUT For example see this PR

Thank you for the feedback; I've updated the PR to use GITHUB_OUTPUT instead of GITHUB_ENV.
@Rugvip I think PR 21930 is ready to merge and fix this.


Accordion example is broken

Seems that the accordion example is broken, it does not change.
https://ui.nuxt.com/elements/accordion#style

Version
Docs

Also, when I switch the variant from solid to link, for example, because the link button is above the Components accordion button, it still opens the Components Panel.
Should we stop the click propagation in the menu buttons?

Duplicate #631

@madebyfabian Not really a duplicate, there was an issue with the reactivity of the components for this use-case. The You should use slots with <ContentRenderer> error when changing prop is related to @nuxtjs/mdc, we're still investigating.


Add a title to a sticky note

The top left of the note when closed fells a little empty.
I would suggest adding the possibility to add a title to every note. Maybe with a dedicated text box when a note is opened or using markdown, like if there is a # in the first line the text after it becomes the title

This above is a concept

Maybe like this? I don't know how the title feature could work tho.
For sure I you put the edit button on the left it would feel less empty.

I think this is a good idea and could help make the header bars in the note window look less empty. Especially when unfocused.

Not sure the best way to implement this intuitively, though. I don't love the idea of the title bar being clicked on to edit, like in gnome-notes. I found it kind of annoying seeing a text box with "Untitled" on every new note. What I like about Sticky Notes is how clean it looks and how easy it is to quickly make new notes.

If you choose to implement something like this, I think it should be optional and non-intrusive. A few possible ideas:

If the first line is bold or has a "#" before it, it becomes the title as mentioned above
In the note window there's a "✏" button on the header bar, or an "edit title" button in the hamburger menu
Title can be edited in the main window
(Something like this?)

Although this does kind of conflict with the previous comment. I personally think a single or double-click on the main text is intuitive enough that an "edit note" button is unnecessary, but that's just me.
Anyway, sorry for the long comment, lol. LMK your thoughts!

hey there James. here's my notes:

in the first mockup, note that the title will be CENTERED, not aligned to the left. hence the title will be truncated much more often (long titles are a no-go)
if I make it so that the first text that starts with a "#" is a title, does that mean that it is automatically removed from the body of the note, then put into the title? Or does it stay there?
The "edit" button in the all notes window is kinda ambigous because at first look it seems that it's to open the NOTE, and not the TITLE

conveniently enough, there is a Gtk.EditableLabel widget that can handle this for us quite gracefully...
however, there are some caveats right now:
1.when the title content is too long, the note window expands (can be solved either by allowing this if it's the desired behavior, or ellipsing the text)
2. the app won't be draggable using the headerbar, since the editablelabel will handle the drag events (can be solved by requiring a double tap to edit the label, but this is not something easy to do, and might break mobile support)
3. this still doesn't solve how it might appear in the "all notes" view
also note that the note will STILL be ellipsised even when it's not focus (i.e when the window decorations (close, menu, new note) are not visible)
here's a video of how it would look like if implemented
Screencast from 2023-03-24 22-47-28.webm

also forgot to note that for users with multiple window decorations (close, minimise, maximise) the label will have very little space (don't know if it's really a problem though)

Yeah, dragging the app should definitely be a priority.
To me, an "Edit Note Title" option in the main menu button for individual notes, and regular text boxes for notes in the main window seem like the next best solutions.

to be honest I'm not really sure right now if we really need to have a title for notes.
this is because 1. there's no intuitive way to do it and 2. the size constraints
for example, in the all notes view, there will be an edit note button (see #34 ) and in the notes window there could be a pin button (see #39 )
and you can have functioning titles by effectively boldening your first line and it will appear in the all notes window, so I think this is pretty unnecessary and hard to implement

I came across this feature request while migrating from xpad to this app. xpad handles this very similar to this suggestion:

If the first line is bold or has a "#" before it, it becomes the title as mentioned above

(it doesn't require any special formatting though). The first line then simply becomes the gnome window title. And yes, if window decorations are used, the text appears both in the window title and as part of the body:

But I don't think that's an issue. It makes finding notes via the window list much easier though as you can see in the following screenshot comparison (xpad also doesn't have a main overview window):
|  |  |
Maybe this minimal option that doesn't require any new UI elements could still be considered.

@fwinkl I like your proposal. I'll definitely start looking into the implementation

I actually came here to propose this feature... So glad to see it's already planned!

to be honest I'm not really sure right now if we really need to have a title for notes.
this is because 1. there's no intuitive way to do it and 2. the size constraints
for example, in the all notes view, there will be an edit note button (see #34 ) and in the notes window there could be a pin button (see #39 )
and you can have functioning titles by effectively boldening your first line and it will appear in the all notes window, so I think this is pretty unnecessary and hard to implement

What about instead of a label that can be renamed with an icon, or by clicking the text, new notes could have a basic, centered button with some text like "Name note", which can popup a little modal to set the name. Once created, the button goes away, and the standard LibAdwaita window title is used? There could be a "Rename" button in the "Main Menu" of the note, and something like this context menu I mocked up could be used to rename it in the main app: #115?

The title is now the first few words of the note after #143


Preventing pick lock and break lock issue

Even if I leave the dc for pick lock and break lock at -1, players can still roll the check, which has caused some problems, such as critical failures that leave the door jammed. I'm currently using it with the pf2e rules.

I will add an option so that actions with impossible DCs can not even be attempted


[leptonica] build failure

Host Environment
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.6 LTS"
To Reproduce
Steps to reproduce the behavior:
./vcpkg integrate install
./vcpkg install leptonica
Failure logs

Additional context
Add any other context about the problem here, such as what you have already tried to resolve the issue.

i don't know what the problem is.

I want to install  leptonica with the following code,
    git clone https://github.com/Microsoft/vcpkg.git
    cd vcpkg
    ./bootstrap-vcpkg.sh # "./bootstrap-vcpkg.bat" for powershell
    ./vcpkg integrate install
    ./vcpkg install leptonica

but when I run ./vcpkg integrate install,  the console output：

Could you give me some suggestions? Thanks very much

According to yourself you are on Ubuntu.
Why are you running:
./vcpkg integrate install ?

Yes, Ubuntu16.04.
I refer to this installation tutorial

And when I running ./vcpkg install leptonica, the console output：

Without logs hard to tell why it is failing. It could very well be that gcc in Ubuntu16.04 is too old or some system library is missing.

@an1018 Could you please provide your error log?

@FrankXie05 Hi, this is my error log, letonica_error.log, thanks

connect https from curl to recive data however , it appears that you to recieve the giflib-5.2.1.tar.gz file due to a curl certificate error. I think it would be better to update the curl.

@an1018 Have you tried this? Update your local curl tool. :)

Thanks for posting this issue. Please reopen this issue if this is still a problem for you.


Killing girls/women

TypeScript Version:  3.7.x-dev.201xxxxx

Search Terms:
Code
// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.

Expected behavior:
Actual behavior:
Playground Link:
Related Issues:

WTF, dude?

Please don't. Thank you.

Good thing nobody knows your real name. You're gonna get embarrassed.
Every crisis has a revelation. It would be smart to see it instead of being it. The pain remains, but the realization increases, hopefully.
Somebody give this guy some good weed!
I wish the best for you, bro. Please stay supple, if that is possible :-)


chore(main): release 0.8.1

:robot: I have created a release beep boop
0.8.1 (2023-12-08)
Bug Fixes

Remove typo for two releases (9659fd1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/kevinah95/hacienda/releases/tag/v0.8.1 :sunflower:


Download Logs in 2.6.1 adds extra carriage returns

After the change from 2.6.0 to 2.6.1 where the [object Object] issue was fixed,  the file download adds additional carriage returns between every log line.
Expected output:
Something the same as or similar to the command:
docker logs portainer
Technical details:
Portainer version: 2.6.1
Target Docker version (the host/cluster you manage): Docker version 20.10.5, build 55c4c88 on Debian Buster
Platform (windows/linux): Linux
Command used to start Portainer:
docker run -d -p 8000:8000 -p 9000:9000 --name=portainer --restart=always -v /var/run/docker.sock:/var/run/docker.sock -v portainer_data:/data portainer/portainer-ce
Browser: Chrome 91.0.4472.124 (Official Build) (64-bit) (cohort: stable_gradual_rollout)

See #5241 for recent fix to log download button

As far as I can tell, the downloaded files on Windows contain CR LF characters for the newlines.

Which gives the impression of extra carriage returns when for instance Notepad thinks it's Unix (LF).

In my file, I see 0D 0A 0D 0A  (twice per line of logs)

its interesting that both of you are seeing notepad showing the wrong thing (double line feeds), but the hex dump is different.
Either way, it doesn't give the right impression :)

problem persists on latest version 2.6.3


Join the Spring Cloud release train

Finchley is due to GA in March
If that is too early, we can shoot for the next train, Greenwich.

Thanks for the heads up! March might be too early for us, but we'll discuss it.

Not a problem

Related: #951.
Currently targeting Spring Cloud Greenwich release train.

We're in master of Spring Cloud Release now!
https://github.com/spring-cloud/spring-cloud-release/pull/102


Getting legal moves from the opponent

How would i get the opponents legal moves? E.g. human vs bot the bot would get the humans legal moves

From what I can tell so far, if you use board.MakeMove() it will move it to the next player's turn, and from there you can use board.GetLegalMoves() to get the legal moves.

Thank you!


Rust experimental

I have addressed the issue and added the experimental flag where necessary in the class-based tests


Exploring a CBOR representation of DID DHT Documents

Hopefully more efficient than DNS

initial tests show up to a 50% size reduction compared to DNS packets
more optimization needed

Codecov Report
Attention: Patch coverage is 67.05882% with 84 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (500b66d) to head (e0a8381).

Files
Patch %
Lines

impl/internal/did/cbor.go
67.05%
65 Missing and 19 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   51.14%   52.51%   +1.36%
==========================================
  Files          31       32       +1
  Lines        2710     2965     +255
==========================================
+ Hits         1386     1557     +171
- Misses       1183     1248      +65
- Partials      141      160      +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add cilium-health status to cilium-bugtool

It'd be nice to get a snapshot of the cilium-health status output when running cilium-bugtool.

Fixed by #3500.


unable to extract html5 player - html5 player None

Checklist

[X] I'm reporting a broken site support issue
[X] I've verified that I'm running youtube-dl version 2020.05.03
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar bug reports including closed ones
[X] I've read bugs section in FAQ

Verbose log
E:\>youtube-dl.exe -v -f bestvideo[ext=mp4]+bestaudio[ext=m4a] --geo-bypass https://www.youtube.com/watch?v=3A9JsnuLnTA
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-f', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]', '--geo-bypass', 'https://www.youtube.com/watch?v=3A9JsnuLnTA']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.11.05
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-93755-ga5387f983d, ffprobe N-93755-ga5387f983d
[debug] Proxy map: {}
[youtube] 3A9JsnuLnTA: Downloading webpage
[youtube] 3A9JsnuLnTA: Downloading video info webpage
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {18} signature length 105, html5 player None

ERROR: Signature extraction failed: Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1380, in _decrypt_signature
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1258, in _extract_signature_function
youtube_dl.utils.ExtractorError: Cannot identify player 'https://www.youtube.com/s/player/52b1e972/player_ias.vflset/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --v
erbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://www.youtube.com/s/player/52b1e972/player_ias.vflset/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbos
e flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1380, in _decrypt_signature
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1258, in _extract_signature_function
youtube_dl.utils.ExtractorError: Cannot identify player 'https://www.youtube.com/s/player/52b1e972/player_ias.vflset/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --v
erbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1380, in _decrypt_signature
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1258, in _extract_signature_function
youtube_dl.utils.ExtractorError: Cannot identify player 'https://www.youtube.com/s/player/52b1e972/player_ias.vflset/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --v
erbose flag and include its complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 2043, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1390, in _decrypt_signature
youtube_dl.utils.ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1380, in _decrypt_signature
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp7hc5a09v\build\youtube_dl\extractor\youtube.py", line 1258, in _extract_signature_function
youtube_dl.utils.ExtractorError: Cannot identify player 'https://www.youtube.com/s/player/52b1e972/player_ias.vflset/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --v
erbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://www.youtube.com/s/player/52b1e972/player_ias.vflset/en_US/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbos
e flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description
Just trying download:
youtube-dl.exe -v -f bestvideo[ext=mp4]+bestaudio[ext=m4a] --geo-bypass https://www.youtube.com/watch?v=3A9JsnuLnTA

I got the same issue.

So, youtube-dl -u failed to update under win7 WTF??


Localized routes

I'm curious about switching to nuxt-i18n-micro as nuxt-i18n is a bit clunky. I am almost sold, but I am hesitating because of some features I'm unsure:
Localized routes
Is it possible, or will it be possible at some point to have localized route paths? Like products/apple and produkt/apfel
Disable page-based translations
I like the straight-forward approach, but in our case, we have many similiar pages that use shared components. As you already support layers, it is sufficient for us to have translations separated per layer. Can i disable page-based translations?
Localize dates/numbers etc.
When I understand correctly, you're not using vue-i18n right? I was used to fallback to $n() etc. for localized number formats. What would a good approach be with nuxt-18n-micro? Should I use Intl.NumberFormat with separate own helper utilities or so?

Hello

Localized routes

I haven't implemented this functionality yet, and in our case, it doesn't make much sense. We use slugs for this and fetch content from the backend. We need to see how this can be done more easily. However, since this is quite a complex functionality, I will need some time for implementation and testing.

Disable page-based translations

There's no such feature available either, but it's easy to add. I'll try to add it soon. In principle, you can already use just one file and ignore the others, but this would lead to longer loading times and more complex page rendering.

Localize dates/numbers, etc.

I intentionally didn't implement such functionality because dates generally don't fall under i18n and localization. For this purpose, there are excellent libraries such as Luxon. Luxon is, in any case, far superior to anything you can do with i18n.

Added the ability to disable per-page localization: docs
Added localized routes: docs

wow awesome and fast work! I hope you even got some sleep :-)
I am testing it right away and will give you feedback. looks very promising. I found a little issue, probably unrelated. I'll open a separate issue for that.

I have tried to setup nuxt-micro-i18n and run into some issues. It seems I may have some basic config issue, as translations do not work and I have some trouble with routing. I am not sure If this is related to the latest 1.11 release, but I also seem to can't get it to work on older versions. Maybe I have one tiny config issue that cause all the other problems.
I have a reproduction here to check out: https://stackblitz.com/edit/nuxt-starter-xfjjgc?file=app.vue
Issue 1: No translations
{{ $t('generic.welcome') }} does not output translated strings. It seems to somehow have to to with "defaultLocale" as when I disable it, it sometimes work and show translations, but only after reload. It also does not translate after vue router navigation or locale switch. Maybe something with my basic setup is faulty, but I can't figure it out? It seems that the translation files loaded (network tab) are empty. I would need it to work also without SSR.
Issue 2: Nested routes cause trouble
I use nested routes in our app like this:
- activity.vue
- activity/
  - skiing.vue

Trying to create links to those subpages like <i18n-link :to="{ name: 'activity-skiing'}">Link</i18n-link> cause Err 500. (Same for $localeRoute()). This seems not to be the case on other, non-nested routes.
Issue 3: <i18n-switcher> Bug on routes with custom path
This is probably all related to the same routing issues I have, but when using the switcher on a page with custom routes (see example "subpage"), the switcher does not work and break when trying to open the dropdown.
Issue 4: $defineI18nRoute() validation
When using this method to define localeRoutes, it throws an error when locales is not defined.
$defineI18nRoute({
  localeRoutes: {
    ru: '/localesubpage', // Custom route path for the Russian locale
    de: '/lokaleseite',   // Custom route path for the German locale
  },
})

--> not possible!
Suggestions
This is just my personal optionion, but I have a suggestion for two adjustments

Maybe you can add a config to disable the file watcher on dev alltogether, so it does not create missing locale files
I would prefer an <i18n-switcher> that is completely unstyled by default and allows adding styles (or classes) when desired. Even with passing custom styles, it is not possible to remove all styles.

I've built my own switcher (which is super easy, fair enough)
<button
    v-for="locale in $getLocales()"
    :key="locale.code"
    :disabled="locale.code === $getLocale()"
    @click="$switchLocale(locale.code)"
>
    {{ locale.code }}
</button>

Once again, thank you very much for your effort and your very fast reply to my requests yesterday :) I appreciate it.

I just completely forgot how the router works in Nuxt and that it can create child routes. I think I’ve finished everything, and also fixed a few other bugs.
I've also added what you requested.
Everything you wrote should work now, but I might have missed something. It would be best to double-check it again.
Regarding the i18n-switcher, it's primarily intended as an example for testing purposes, and if we remove the styles completely, it almost loses its purpose. The best approach would be to either create a custom wrapper in the project for styling or simply write your own. The i18n-switcher can then be used as an example.

Awesome work!
As far as I checked in my example repo, everything works flawlessly now. I will now start adopting it in our main project and see if I find something else.
Thank you for your effort.

Sorry to bother you again, but I still have an issue with custom routes for nested routes.
I've created an updated example: https://stackblitz.com/edit/nuxt-starter-vqutwr?file=app.vue
Custom routes work well for normal pages. In case of parent/child routes. I would like to fully translate the whole route. For example:
- activities
  - skiing-page
  - hiking-page

should become:
EN: book-activity/skiing
DE: aktivitaet-buchen/ski-fahren
Parent:
$defineI18nRoute({
  localeRoutes: {
    en: '/book-activity',
    de: '/aktivitaet-buchen',
  },
});

Child
$defineI18nRoute({
  localeRoutes: {
    en: '/skiing',
    de: '/ski-fahren',
  },
});

I've tried various combinations of specifying $defineI18nRoute() in both parent/child. I also tried to include parent segmment in child too etc. I've end up that either the parent or the child path is not translated (they exist both), e.g.
activity/aktivitaet-buchen/skifahren (only child part translated)
aktivitaet-buchen/skiing-page (only parent part translated)
but no "fully" translated route is created. I've studied the code and see you're incoporating parent/child relations. Maybe my config are wrong? see the example.
Another tiny issue I found with $defineI18nRoute() is that the regex extraction also happens when commented.
So
// $defineI18nRoute({
//     localeRoutes: {
//         en: '/ignore...',
//         de: '/ignore...',
//     },
// })

is still matched and the extractor code then breaks

Try the New Version
Nuxt-i18n-micro v1.12.2
Working with custom routes turned out to be quite complex. I had to write numerous tests to cover all possible link formation scenarios. While I believe I've tested everything, there might still be edge cases where things could break. It's essential to check how it performs now.
Honestly, I was reluctant to implement these custom routes for a reason—there's just too much unnecessary logic involved. Working with slugs is much simpler and more intuitive. 😅
Additionally, I’ve reworked the defineI18nRoute search. Now, it will skip commented lines.

I rewrote the entire logic for generating links; it's now encapsulated in a separate class, and I added tests for it. Everything seems to be working correctly.

I have the following issue:
{{ $localeRoute({ name: 'checkout-step-2-booking', params: { bookingId: '123' } }) }}

throws an error: Error: Missing required param "bookingId"
Folders:
-checkout/
  - step-2-booking.vue

so normal route name is: checkout-step-2-booking.
without i18n I define
definePageMeta({
    path: '/checkout/booking/:bookingId',
 });

but even if I use nuxt defaults and name the page: step-2-booking-[bookingId]
it seems to be an issue with the $localeRoute() composable not handling params correctly?
Everything else works fine! 👍
Some more suggestions:

I've created a manual helper function useBaseRouteName() that returns route name without i18n stuff. I see you also have a helper for this and use it frequently. You should expose it as well? I use a lot of navigateTo($localeRoute({ name: 'route-name' })) and I constantly have to normalize route names everywhere. For example useRoute().name of the current route returns the localized version. Working with Routes, I assume almost everyone usually just wants to navigate to a specific page and not a specific locale. So using your helper instead of creating a custom one.

The return type of $t() is not string, but string | number | boolean | Translations | PluralTranslations | unknown[] | unknown | null. Maybe I dont understand the implications, but doesnt $t() always return a string, even if it doesnt find the key? Because now I have to explitly say const label = $t('key') as string everywhere to prevent type errors (when i expect string). maybe i'm doing it wrong, I dont have that much TS experience. But having to add as string everywhere seems annoying.

I've created a manual helper function useBaseRouteName() that returns route name without i18n stuff. I see you also have a helper for this and use it frequently. You should expose it as well? I use a lot of navigateTo($localeRoute({ name: 'route-name' })) and I constantly have to normalize route names everywhere. For example useRoute().name of the current route returns the localized version. Working with Routes, I assume almost everyone usually just wants to navigate to a specific page and not a specific locale. So using your helper instead of creating a custom one.

I added a public method: getRouteName.

The return type of $t() is not string, but string | number | boolean | Translations | PluralTranslations | unknown[] | unknown | null. Maybe I dont understand the implications, but doesnt $t() always return a string, even if it doesnt find the key? Because now I have to explitly say const label = $t('key') as string everywhere to prevent type errors (when i expect string). maybe i'm doing it wrong, I dont have that much TS experience. But having to add as string everywhere seems annoying.

No, the issue you're experiencing is actually one of the main problems with traditional i18n libraries, which is why I chose not to use them. In my implementation, you can comfortably receive an object, array, integer, or almost any data type, which greatly simplifies working with different types of data, such as displaying a list. If you provide an example, I can try to adjust the typing to address this problem.
For the first part, it's hard for me to say anything specific. I need an example to understand your logic. It's better to create a separate issue.

Thank you for your explanation. I see your point with the types. And thanks for adding getRouteName
I create a second issue for the params.


Someone joins a finished game: Error for players in game (TypeError: Cannot read properties of undefined (reading 'rank'))

fixed


add menu

Thank you very much!
I haven't checked the stuff against my local changes but I'll rebase on your work!

Thank you again for implementing so many of the open UI improvements!

It was fun for me, I don't get too much code these days I work on with interest, so thank you too for this nice project :)


remove duplicate imageData key

Signed-off-by: chipzoller<EMAIL_ADDRESS>Related Issue(s)

Description
Removes a duplicate key in a variable values file to unblock development in kyverno/kyverno for a feature which impacts the test manifest layout.

Checklist

[x] I have read the policy contribution guidelines.
[] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
[] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

was about to open the same pr 😂

Hopefully CLI tests still pass. I was waiting for that to occur.


Update to swift 2 syntax

Thanks for your pull request and for using the library @tongoclinh!
I think you should rebase your PR on the current develop branch, that branch has Swift 2 support since yesterday. So I think a lot of the changes will also be in your commit, if there are more improvements you've made that are not yet in develop I'm happy to merge them in, but currently they are a bit hard to spot!
Please also take @tomlokhorst comment into consideration. Thanks for reviewing btw @tomlokhorst!

I'll close this one for now, feel free to open a new PR is you have additional improvements against the current develop branch! Thanks again for your time. :)


Use rfdc for cloning pure JSON values

This PR was originally proposed by @anshumanr in #4607.
I've picked up the work done there and applied it cleanly to where we know we're handling clean JSON data.
This PR replaces #4607

Awesome! Thank you very much!


Fix that SofaBootComponentHealthCheckInfo health status is influenced by HealthIndicator.

fix #190

Pull Request Test Coverage Report for Build 457

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
65 unchanged lines in 16 files lost coverage.
Overall coverage remained the same at 65.32%

Files with Coverage Reduction
New Missed Lines
%

infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/endpoint/SofaBootVersionEndpoint.java
1
81.94%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/core/HealthIndicatorCheckProcessor.java
1
70.45%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/startup/ReadinessCheckProcessor.java
1
75.86%

isle-sofa-boot-starter/src/main/java/com/alipay/sofa/isle/spring/listener/SofaModuleContextRefreshedListener.java
1
72.41%

runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/service/helper/ReferenceRegisterHelper.java
2
76.19%

runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/ServiceFactoryBean.java
2
69.44%

test-sofa-boot-starter/src/main/java/com/alipay/sofa/test/runner/SofaJUnit4Runner.java
3
56.67%

infra-sofa-boot-starter/src/main/java/com/alipay/sofa/infra/config/spring/namespace/handler/SofaBootNamespaceHandler.java
3
0.0%

runtime-sofa-boot-starter/src/main/java/com/alipay/sofa/runtime/spring/factory/AbstractContractFactoryBean.java
4
52.38%

healthcheck-sofa-boot-starter/src/main/java/com/alipay/sofa/healthcheck/configuration/HealthCheckConfiguration.java
4
40.0%

Totals

Change from base Build 456:
0.0%

Covered Lines:
1471

Relevant Lines:
2252

💛  - Coveralls


Issues With Slots

Does this technique work with slotted content as well?
I am having an issue getting my slots to show up with a basic example and was not able to find a workaround.  Everything else seems to work properly --  props, events, etc.
It seems like a strange quirk so it makes me feel like I am doing something incorrectly?
Any insights appreciated.
Thanks for releasing this little package!

Slots should work fine.
There is a test here checking that.
https://github.com/crisward/svelte-tag/blob/master/tests/tag.test.js#L34
Perhaps share an example?

Ahh my mistake, I came to the wrong codebase!
I am actually using this snippet: https://github.com/sveltejs/svelte/issues/1748#issuecomment-583880664
I saw your comment underneath and kept the tab open to your project here.
But now that slots do not appear to be working, I may just try out svelte-tag.
Thanks!


Fixing typo and example on error

Found a couple of typos on the error message when running milo without specifying the file or folder.

Thanks @dmuriel !


Added a library with all constants used by the espresso systems company

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.586%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
135

Relevant Lines:
181

💛  - Coveralls


Recover deleted Channel

Hi!
Working on Version 3.8.7 and accidentally deleted a channel. Anyway to recover it?
Thank you!

My Setup

Operating System:
App Version:
Installation type:

[ ] I have tested with the latest version
[ ] I can simulate the issue easily

Description

Current Behavior

Expected Behavior

@TesterKAY hello, you will need to talk with the server administrator. Here we cant help you about this.


Certificate Expired

The cert of https://vuepeople.org/ has expired on 2020/3/13, similar to #131.

Yeah, please update the cert or create a automatic process for that, to avoid the expiration :) BTW the site is very cool @DonNicoJs @nullcode :)

I am on it :) also we will have to fix the github API soon too :D

Expired on 2020/7/9 again :(

@Alan-Liang Apologies :( refreshed!

I guess you use LetsEncrypt, right? So it would be good to have an automatism for that. Unfortunately I don't know your infrastructure to help here.

@Chris2011 I need to setup a chron job to deal with it :)

Oki, sounds legit :)

It is still invalid, it gets a running gag :D. Just joking :). Maybe we can have a chat and talk about what needs to be done or how the infrastracture is. That I can help here if you want.

@Chris2011 🤦  I finally gave in!
people@vue-people-1:~/vue-people$ sudo crontab -l
# Edit this file to introduce tasks to be run by cron.
#
# Each task to run has to be defined through a single line
# indicating with different fields when the task will be run
# and what command to run for the task
#
# To define the time you can provide concrete values for
# minute (m), hour (h), day of month (dom), month (mon),
# and day of week (dow) or use '*' in these fields (for 'any').#
# Notice that tasks will be started based on the cron's system
# daemon's notion of time and timezones.
#
# Output of the crontab jobs (including errors) is sent through
# email to the user the crontab file belongs to (unless redirected).
#
# For example, you can run a backup of all your user accounts
# at 5 a.m every week with:
# 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/
#
# For more information see the manual pages of crontab(5) and cron(8)
#
# m h  dom mon dow   command

0 3 * * * /home/people/vue-people/refresh-cert.sh


backendError when updating groups

When running 'python gam.py update group<EMAIL_ADDRESS>name newgroupname' I receive the following error.
Temp error backendError. Backing off 16 seconds...attempt 5/10
Temp error backendError. Backing off 32 seconds...attempt 6/10
Temp error backendError. Backing off 60 seconds...attempt 7/10
Temp error backendError. Backing off 60 seconds...attempt 8/10
Temp error backendError. Backing off 60 seconds...attempt 9/10
Temp error backendError. Backing off 60 seconds...attempt 10/10
ERROR: 503: A system error has occurred - backendError
I had my Google reseller try the same with identical results.

We are having the exactly same issue.
Using GAM, Apps Script, Python library, etc.
Our scripts were working with no issues and suddenly, everything stopped working (update groups info).
Can you please open a ticket here?
https://code.google.com/a/google.com/p/apps-api-issues/issues/list
Thanks,
Jose

Please star this issue: https://code.google.com/a/google.com/p/apps-api-issues/issues/detail?id=4553

I opened 4553. The response was:
Updates:
Status: WontFix
Owner<EMAIL_ADDRESS>Labels: API-Admin
Comment #2 on issue 4553 by<EMAIL_ADDRESS>Temp error backendError when trying to update a Google group
https://code.google.com/a/google.com/p/apps-api-issues/issues/detail?id=4553
GAM is not software maintained by Google. It is a third-party application, and as such you should be reporting issues with it to its developer here:
https://github.com/jay0lee/GAM/issues
Should the developer determine that the issue is with one of the Google APIs the app uses, they should report the issue on this tracker, along with the API details we need to diagnose the problem. As it stands, we do not have enough information here to investigate.

Same issue here.  Got the same response.  I was able to set the attributes via:
https://developers.google.com/admin-sdk/groups-settings/v1/reference/groups/update
I get the same issue when creating a group.  The group gets created, but with the default attributes.  None of the Attributes I specify get set.

Same issue with me. I can set th attributes via sdk but I use GAM to do large changes in one copy paste (the last as 200 lines)

Same issue with me. I can set th attributes via sdk but I use GAM to do large changes in one copy paste (the last as 200 lines)

Same issue with me. I can set th attributes via sdk but I use GAM to do large changes in one copy paste (the last as 200 lines)

Hello,
It's working now for me.

Working for me now as well.

This was a problem for me for two weeks, but started working again today with no action taken.

Closing. This was likely an issue on Google's end.


Fix Multi-part Upload

The end of stream is not always --\r\n in forms, but the boundary is always followed by --

Looks good to me now! Merging in.


refactor: updates naming convention to reflect repo rename of era-test-node to anvil-zksync

Changes introduced:

Updates naming convention to anvil-zksync from era-test-node

Should be merged after: https://github.com/matter-labs/era-test-node/pull/444 is merged / released. Tests are expected to fail until then.

@dutterbutter can be merged now?


CS0649 due to _baseUrl instead of BaseUrl from 14.0.2 => 14.0.[3-7]

I have a working setup with 14.0.2 with the following settings:
"codeGenerators": {
    "openApiToCSharpClient": {
      "clientBaseClass": "ApiClientBase",
      "configurationClass": "IApiClientConfiguration",
      "useBaseUrl": true,
      "generateBaseUrlProperty": false,
      ...
      }
   }

The ApiClientBase class contains a protected string BaseUrl { get; } property which is set in the constructor with a value obtained from the IApiClientConfiguration passed in the constructor.
However, when upgrading to 14.0.3 (or any thing else up to latest 14.0.7), the generated code now contains a private readonly string _baseUrl field (which is used instead of the BaseUrl property in the base class) which is never initialized so I get a CS0649 error when building it - and if I disabled that somehow, the code would still not work as the base url would not be set.
I see no documentation about this breaking change and have been unable to find reasonable way to mitigate this.
I could probably add an abstract method in ApiClientBase that I would invoke from the constructor in the same class (if I disable warnings about virtual methods called from constructor is unsafe) and implement that method to set _baseUrl field from BaseUrl property in a partial hand-coded class alongside the generated code. But that sounds wrong in multiple ways.
What is the intensions with this changed behavior? Or is this a bug?

Just noticed that this is probably a duplicate of #4764.

@martindamgaardlorensen it is a duplicate indeed. Maybe close this and add a comment on that bug instead?

Duplicate of #4764.


Getting started overrides previous project

Getting started creates a temporary project for the tutorial. Once you exit the tutorial or finish it, it should switch back to the previously opened project.
Getting started is currently overriding that previous project with its contents.

Still repros in latest beta


Where is the best place to extend my own remote logging? In logging dispatcher virtual function?

not really helpful Helpers::installLogDispatchCallback(const std::string&)  is there some simple sample?

I need filter log messages and decide where to log remotely. does LogDispatchData* have log infos?

I want to en-queue the logmsg into the network sending queue to let it be sent in network update thread at next frame. So, I guess the most possible place could be in log dispatch. I have changed the logdata class to struct so that I can get logmsg type and so on to decide where it should be sent.
Thanks.


Added BFS code snippet in C++

Fixes:#52
Added BFS card on the main page as below

also added corresponding router

use multiple languages

Give star, share and follow me on linkdin


Fix environment script

When using 'source ...' the parameter $0 is not working.
We use $BASH_SOURCE to get the file location instead.

Although I must admit I always doubt what to use. It's a change in documentation so it's logical to use docs(README), but it's also a fix of existing documentation (and in this case of a code example inside the docs) so fix(README) seems correct as well. 😄

Perfect! Thanks @ia3andy


WIP: Using Gatsby.js

Replaced Jekyll with Gatsby
Moved index.md to documents/
Using official TC39 logo
Changed theme colour to match TC39 logo
With Gatsby the site is a statically generated PWA if you're wondering why it uses JS at all:

Why remove JavaScript? That disables your React components on the client, slows down page transitions, prevents service workers from preloading page data, etc.
In 0.x there's an command line flag to prevent the JavaScript from being written but I'm not inclined to support that in v1 as with code splitting, the amount of JS being loaded is quite small.
There's always the option though of just not putting the script tags in the HTML.

https://github.com/gatsbyjs/gatsby/issues/962#issuecomment-301392995
TBD

[x] Define deployment

npm run deploy
# or
yarn run deploy

[ ] Silence Autoprefixer grid error: it's mad because IE doesn't support grid-row well

Another note here. You did lots of great work outside of gatsby. it would be great to have these as separate prs so that the issue with gatsby doesn't stop the other work from getting in! thanks a lot for jumping on this!

Also, really sorry about not looking at gatsby in more detail before :( that was my bad

Also FYI waiting for my flight I made https://github.com/xtuc/link-to-babel-repl-generator

React is only used for declaring components and composing them the final output is a static HTML site so I don't see any problem with this. I don't see why using one library or another is problematic. Jekyll is a ruby library - why is it okay to be used but React not?

Another note here. You did lots of great work outside of Gatsby. it would be great to have these as separate PRs so that the issue with Gatsby doesn't stop the other work from getting in! thanks a lot for jumping on this!
Actually except for porting everything to Gatsby and removing Jekyll specific files I only replaced the logo and theme colour.

If we're going to have interactivity in the site later Gatsby provides excellent rehydration mechanism but as for now the <script /> tags can just be stripped out and you have a perfectly static site.
The advantages of using React + Gatsby + GraphQL is that resources are bound to view *explicitly and common components can be shared easily (unlike in Jekyll for instance).
Also as I pointed out earlier deploying a static site that it's scripts making it a PWA boosts performance so I don't see why not using this mechanism if it benefits the users.

We discussed a static site generator that would use MD files and be shipped as an MVP.
At no point did we discuss using react, jsx, node, or graphql. At no point did we discuss PWAs. And yet, this PR is making all of those decisions for us. With Jekyll, ruby is an implementation detail. The focus is on the site organization and the content. Not the technology. Introducing Gatsby is unnecessary and causes more issues than it solves.
I spoke with a few framework authors today. While the content is more important than the technology decision, this technology decision would limit our contributors to React developers. The JavaScript ecosystem is more than only React developers, and I feel that it is problematic to make a site that doesn't need any JavaScript rely on react.
I would also like to have clearer communication in the future. In our discussions you mentioned gatsby as replacement for Jekyll, and I expected it to be that, then I saw this. This is doing much more than Jekyll. With Gatsby, React becomes the default framework, rather than javascript becoming an implementation detail like ruby does for Jekyll. This was not communicated. Had I known this, I would have raised the issue earlier.
Again, we never discussed using react, jsx, graphql, or node. What we discussed was a simple static site generator as part of an MVP, the primary goal of which is to show text. That is not to say that we will not -- in the future -- consider these. There may very well be benefits. However we are not doing this now. I expect this to be something we discuss when that time comes, not something a person makes an executive decision about. I hope this is clear.
Please split out the other changes from this pr, because those would be good to have. As a best practice, we shouldn't mix different types of fixes in the same pr anyway.

I think this discussion gets a little bit to heated for my taste. This is why I'd like the both (@iddan and @codehag ) of you to step away from it for a bit as this is violating the code of conduct regarding constructive communication.
Thank you. I will lock the issue until tomorrow.

I'm confused, it was a healthy discussion IMO. I was just trying to poke around to understand the requirements and restrictions Gatsby used as a test case. But maybe it was too intense for others IDK.

Interesting. it is quite light weight which is great, and open to other technologies which is a plus. It doesn't tie us down very much which i think is important at this stage.
i am cautious about using something hand-rolled, but since this is an interim solution i think it should be ok for now. What do others think?
thanks for the work you put into this @iddan!

I'm fine to defer to @iddan here about any of the three choices. This is a small site and it won't be the end of the world if we have to move to a different system later.

Personally I prefer Gatsby than investing in a new system (though developing something new is always fun). Jekyll is a non-option IMO because:

It's not safe enough
It's hard to config and learn
It's written in Ruby 4COL

adding normalize has been broken out into this pr: https://github.com/tc39/tc39-web-draft/pull/23

color and logo have been broken out into a separate pr: https://github.com/tc39/tc39-web-draft/pull/24

Since we are deferring any changes until later, and this is a bit out of date, I am closing this for now


Media keys don't work on Mac

I'm running the same code on both my Windows Desktop and my Mac. Nothing wrong when running it on Windows.
On Mac I'm getting the following error:
/Users/galenhan/GitHub/RPlayr/server/server.js:13
robot.keyTap("audio_pause");
      ^

Error: Invalid key code specified.
    at Error (native)
    at Object.<anonymous> (/Users/galenhan/GitHub/RPlayr/server/server.js:13:7)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:475:10)
    at startup (node.js:117:18)
    at node.js:951:3

The code for server.js are just these 2 lines:
var robot = require("robotjs");

robot.keyTap("audio_pause");

Tried it with other keys such as audio_next and audio_mute.

Oddly enough
robot.keyTap("audio_mute");

doesn't crash the program, but doesn't actually mute any sound my Mac.

The keyboard demo
//Type "Hello World" then press enter.
var robot = require("robotjs");

//Type "Hello World".
robot.typeString("Hello World");

//Press enter.
robot.keyTap("enter");

works without problems on Mac by the way.
Running OSX El Capitan 10.11.3.

Hey @Mastergalen! Currently the media keys don't work on Mac, you can follow this issue for updates:
https://github.com/octalmage/robotjs/issues/148


Option to use Instance Private IPs

This isn't necessarily an issue but adding a flag or environment variable to choose if the script will collect gru and the minion's private IPs vs public would be useful.
For example, my environment is entirely in Amazon including where lucy would run from.  Having the instances within a vpc and security group that is locked down so the systems can only talk to each other and reach the internet allows for better overall security versus opening up port 22 to the entire world, along with the other necessary ports.
I modified the script and rebuilt lucy to give this a try and it worked just fine:
# Step 7 - Get private IP addresses from Gru and Minions
GRU_HOST=$(aws ec2 describe-instances --instance-ids $GRU_INSTANCE_ID \
      --query 'Reservations[*].Instances[*].[PrivateIpAddress]' --output text | tr -d '\n')
echo "Gru at $GRU_HOST"

MINION_HOSTS=$(aws ec2 describe-instances --instance-ids $MINION_INSTANCE_IDS \
      --query 'Reservations[*].Instances[*].[PrivateIpAddress]' --output text | tr '\n' ',')
echo "Minions at at $MINION_HOSTS"

Again not necessarily an issue as the package currently works as is, but would be a nice feature.

Great suggestion.  I am wondering if there is a way that Lucy could be smart enough to auto-detect if it was running in the VPC?  I remember seeing an AWS whitepaper showing how an instance can discover its environment within AWS, but I am not sure how it world work if Lucy would run outside the VPC.

Possibly use the AWS API like the entrypoint.sh script for the jmeter container does?
  # AWS Public HOSTNAME API
  echo "Detecting an AWS Environment"
  PUBLIC_HOSTNAME=$(curl -s --max-time 5 http://<IP_ADDRESS>/latest/meta-data/public-hostname)

  if [ "$PUBLIC_HOSTNAME" = '' ]; then
    echo "Not running in AWS.  Using Gru HOSTNAME $HOSTNAME"
  else
    HOSTNAME=$PUBLIC_HOSTNAME
    echo "Using Gru AWS Public HOSTNAME $HOSTNAME"
  fi

http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-metadata.html
Have possibly have lucy check what her ami-id is
curl -s --max-time 5 http://<IP_ADDRESS>/latest/meta-data/public-hostname
Assuming  a value is returned she is in AWS if nothing is returned she is not.

That should work.


carla_msgs: 1.1.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository carla_msgs to 1.1.0-1:

upstream repository: https://github.com/carla-simulator/ros-carla-msgs.git
release repository: https://github.com/carla-simulator/ros-carla-msgs-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.7
previous version for package: 1.0.1-1

Holding for sync.


add unsafe to every vendor intrinsic

... and also add missing assert_instr tests.
I'm somewhat expecting CI for i686 to fail. I think a few of the vendor intrinsics lower to different instructions on i686 vs x86_64.

lgtm, but looks like three failures?
osx
---- x86::sse2::assert_instr__mm_set1_epi8 stdout ----

	disassembly for stdsimd::x86::sse2::_mm_set1_epi8:

	 0: pushq %rbp

	 1: movq %rsp, %rbp

	 2: movd %edi, %xmm0

	 3: pxor %xmm1, %xmm1

	 4: pshufb %xmm1, %xmm0

	 5: popq %rbp

	 6: retq

	 7: nopw %cs:(%rax,%rax)

thread 'x86::sse2::assert_instr__mm_set1_epi8' panicked at 'failed to find instruction `pshufd` in the disassembly', stdsimd-test/src/lib.rs:292:8

note: Run with `RUST_BACKTRACE=1` for a backtrace.

windows
---- x86::sse2::assert_instr__mm_cvtsi128_si32 stdout ----
	disassembly for stdsimd::x86::sse2::_mm_cvtsi128_si32:
	 0: push rbp
	 1: mov rbp,rsp
	 2: mov eax,dword ptr [rcx]
	 3: pop rbp
	 4: ret
	 5: ��������
thread 'x86::sse2::assert_instr__mm_cvtsi128_si32' panicked at 'failed to find instruction `movd` in the disassembly', stdsimd-test\src\lib.rs:292:8
stack backtrace:
---- x86::sse2::assert_instr__mm_cvtsi128_si64 stdout ----
	disassembly for stdsimd::x86::sse2::_mm_cvtsi128_si64:
	 0: push rbp
	 1: mov rbp,rsp
	 2: mov rax,qword ptr [rcx]
	 3: pop rbp
	 4: ret
	 5: �������
thread 'x86::sse2::assert_instr__mm_cvtsi128_si64' panicked at 'failed to find instruction `movq` in the disassembly', stdsimd-test\src\lib.rs:292:8

Oh one thing is that I think we'll have to make the #[test] functions unsafe eventually as well (due to their usage of #[target_feature], I'm fine if you want to do that here or not.

All right, I've made all the tests unsafe as well, and I've fixed up the codegen tests mostly by just removing them. Some of the sse2 intrinsics are just normal loads/stores, and it seems like expecting a particular variant of mov is folly. Even if you look at Intel's vendor API, they don't seem to list any specific CPU instruction for them, and most of them probably only exist for completeness (users will likely want to use the platform independent vector API for manipulating vectors instead).


Bump gren-lang/node dependency

Current version of gren-lang/node is 3.0.1

Fixing this required a few code changes as well. Fixed on the main branch.

Thanks!


Should prometheus_jmx_exporter_role use the default JMX Exporter Port (9404)?

JMX has the port 9404 defined as default in the "Default port allocations" wiki.
Should prometheus_jmx_exporter_role use the default JMX Exporter Port (9404 instead of 9110)?
@jmonterrubio, @jnogol, @sorobon

I think it will be messy to change every service using this exporter to use the new port or force to configure the port variable :(

agree, but probably would be easier for newcomers :)


Wrap exported cell as REST service

Wrap exported cell as REST service.
Possible solutions:

Use the code from FAIR-Cell https://github.com/QCDIS/FAIRCells/ to warp
Use clamp
Use python Flask

Timeout