hack.package.rpm.centos-7.Dockerfile.x86_64: fix fpm version dependency

The latest fpm requires Ruby version >= 2.3.0, and the current centos:7.2.1511
only can provide ruby-<IP_ADDRESS>8-33.el7_4, so the result is failed to build RPM.
This patch can solve the issue well. If it's failed to install latest fpm then
install fpm 1.4.0 instead.
Signed-off-by: Alex Jia<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
The latest fpm requires Ruby version >= 2.3.0, and the current centos:7.2.1511
only can provide ruby-<IP_ADDRESS>8-33.el7_4, so the result is failed to build RPM.
This PR is used for solving the issue.
Ⅱ. Does this pull request fix one issue?

fixes #1369
Ⅲ. Describe how you did it
If it's failed to install latest fpm then install fpm 1.4.0 instead.
Ⅳ. Describe how to verify it
$ sudo docker build https://raw.githubusercontent.com/alibaba/pouch/master/hack/package/rpm/centos-7/Dockerfile.x86_64
Ⅴ. Special notes for reviews

Codecov Report

Merging #1370 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
- Coverage   17.29%   17.26%   -0.03%
==========================================
  Files         190      189       -1
  Lines       11913    11886      -27
==========================================
- Hits         2060     2052       -8
+ Misses       9706     9686      -20
- Partials      147      148       +1

Impacted Files
Coverage Δ

daemon/mgr/container.go
0% <0%> (ø)
:arrow_up:

daemon/logger/jsonfile/utils.go
70% <0%> (ø)
:arrow_up:

apis/opts/env.go

LGTM

Could you change the commit info with a prefix like [bug]: and adjust the title by the way.

@Letty5411 Done.


fix typo in readme

(CI is green, but that fact seems not to have been communicated from Travis-CI to GitHub)

Awesome, thank you!


[BUG] - Minimap

When trying to add a walk point it says the minimap should be visible, but it is

Desktop (please complete the following information):

OS: Windows
Tibia Version 13.12

Got same error.

You should avoid "marks", please, remove it and try again. I will add it in README.

News?

Hello Lucas,
I've got the same issue. Client is startup sucesfully, character is detected in GUI window, but when i try to click on "walk" button from cavebot tab i have got the same error. Firstly also had marks on map but after deleting all of them the problem still exists.
Anyway great job with this bot, really want to test it :)

olá, obtive o mesmo erro, tem alguma forma de resolver?

I have the same error, and no marks on the minimap.

I have the same problem, any solution? @lucasmonstrox


[Sign in] Load Terms of Service from remote data store

This branch is a part of Terms & Service Features that would be shown to user after SignIn. In this Branch the terms are getting fetched from the firestore db itself.

Fixes #746

@atalekar @gino-m  PTAL?

If there are no terms in the db I'd expect the value of termsAccepted to not matter. Do we need to set this at all?

then instead of setting true and false for terms. we can setup 3 states defining ACCEPTED, NOT_ACCEPTED, NO_TERMS

Please check failing checks on GCB.

/gcbrun

/gcbrun

/gcbrun


Issue #775 Pass eloquent model to column "output" renderer.

When rendering a column in the "columns" listing, the "output" closure it given a raw value, but nothing else. This change passes the eloquent model also to the closure, so other fields can be referenced.
Other fields may include, for example, the ID of the row, or the ID of a parent record, which will come in very handy to create links direct to parent records in the column listing.

I've removed change https://github.com/judgej/Laravel-Administrator/commit/1e3df606f05fde28205aab2b9dcfe379fa0b8878 as it was failing the tests.
For some reason the tests are passing stdClass into the second parameter and not an eloquent model. I have no clue why, and can make no sense of the tests without a massive diversion, for which I have no time at the moment.

+1

Could this be merged please @davemathews?

@judgej thanks for the pr could you make it to dev ranther than master and I will get this in tonight.

Thanks, I've not got around to this yet. Do I need to rebase up the tree then walk down the dev branch to do this?

@judgej you can do it a couple ways, you can reclone the latest Laravel since yours is 20 commits behind, then make the changes on your cloned dev branch and submit the pr from your dev branch to Frozennodes.
Or you can pull from upstream to get the latest dev and master branches from Frozennode, then merge your cloned master into your cloned dev and submit the pr from that dev branch to Frozennode.

I'm going to close this one in hope you get me the dev one soon.  Thanks.


Allow usage without extending String

I was looking into using this in combination with Scylla, but both libraries extend the core String with the method #language. I suggest you make the core extension optional. (I will try to make the same suggestion to the author of Scylla.)
I changed the require statements in the examples and the tests to still include the core extension, but haven't explained how to use the library without it. I guess your english would be preferable ...

I'm accepting this to get it into the system but it'll be on a separate point release as it'll break the API. Thanks!


Bump release version in README.md

Bump release version from 1.2.1 to 1.2.2 in README.md

I've fixed this issue.


Init Accessors with nonmutating modify fails to compile

Description
This is a follow up to the following issue: https://github.com/swiftlang/swift/issues/67827
Reproduction

struct Test {
  let id: UUID
  private var _count: Int

  var count: Int
  {
    @storageRestrictions(initializes: _count)
    init {
      _count = newValue
    }
    _read {
      yield _count
    }
    nonmutating _modify {
      var val = _count
      yield &val
    }
  }

  init(id: UUID, count: Int) {
    self.id = id
    self.count = count // << Variable 'self._count' used before being initialized
  } // << Return from initializer without initializing all stored properties
}

Expected behavior
The above code should compile without errors.
Environment
The initial Xcode beta
Additional information
No response

@xedin I created a new issue.

Thanks, I must have missed our reply. I seems like a whack-a-mole here because SIL patterns are not the same and property wrappers don't support this?

Currently we don't emit assign_or_init for a modify accessor. I think fixing this is going to mean extending init accessors feature because it currently only supports setters.

I'm curious to understand what differs between the implicitly generated init in comparison to my attempts to write explicit inits? With implicit inits everything seems to work fine, and the compiler is happy, but as soon as I try to make an explicit init (e.g. when I need it to be public), I run into this different issues.

We might not be running DI on implicitly generated initializers because they are compiler synthesized.


Successful Login, Yet isAuthenticated remains false

Describe the problem
I followed the guide described here, and my set-up is functionally the same as the code sample here: https://developer.auth0.com/resources/guides/spa/react/basic-authentication#quick-react-setup
I am logging in successfully via the new Universal login page, and redirecting to the correct URL. There are no errors, and the Auth0 log output indicates a successful login. I redirect with a URL that looks like http://localhost:3001/?code={random_code}.
However, when I use the useAuth0 hook in my application, isAuthenticated always remains false, even after a successful login. This is very strange. The component using the hook is nested within the Auth0Provider
What was the expected behavior?
The expected behavior is for redirectCallback to be triggered, and for the authentication status and user information to be accessible via the useAuth0 hook.
Currently, nothing happens.

Tell us about the behavior you expected to see

Reproduction

Detail the steps taken to reproduce this error, and whether this issue can be reproduced consistently or if it is intermittent.
Note: If clear, reproducable steps or the smallest sample app demonstrating misbehavior cannot be provided, we may not be able to follow up on this bug report.

Step 1..
Step 2..
...

Can the behavior be reproduced using the React SDK Playground?
If so, provide steps:

Where applicable, please include:

The smallest possible sample app that reproduces the undesirable behavior
Log files (redact/remove sensitive information)
Application settings (redact/remove sensitive information)
clientId and domain (these are publicly available)
Screenshots

Environment

Please provide the following:

Version of auth0-react used: ^1.12.0
**Which browsers have you tested in? **
**Which framework are you using, if applicable (Angular, React, etc):React
Other modules/plugins/libraries that might be involved:

Hi @BG687 - thanks for raising this
Can you share a har file (with any secrets redacted) - than I can take a look for you

Closing due to inactivity - feel free to reopen if you want to provide a HAR file


COVID Test Kits Vending Machine Search

ITS-Pro time category: https://its-pro.ucsd.edu/browse/MA-99
This is complete when:

[ ] The maps search has an icon shortcut for COVID test kits vending machines. Perhaps replacing "Mail" icon.

Does the data already exist for this filter?

Does the data already exist for this filter?

@woznaut  Yes

@woznaut  Yes


Fix grammar

https://dart-review.googlesource.com/c/sdk/+/270740

@asashour - do you have more details for this bug report?

Sorry for not doing so earlier, now more details are added.


chore(package): update npm-pkgbuild to version 6.0.9

:tada: This PR is included in version 5.0.51 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New package: Nefertari v0.1.0

Registering package: Nefertari
Repository: https://github.com/MKAbdElrahman/Nefertari.jl
Created by: @MKAbdElrahman
Version: v0.1.0
Commit: e326cabc759a0824f548b8e38c44144d2426d2a1
Git reference: HEAD

This is an empty package

Please read the guidelines/FAQ before you register your packages:
https://github.com/JuliaRegistries/General#should-i-register-my-package

Repo deleted.


Update to Alpakka S3 Connector v1.0 release

Updates the Alpakka S3 connector to v1.0 from 0.19 release
Description
Updates the Alpakka S3 connector to stable release. It brings in support for retries and other changes. With 1.0 there is now no S3Client and instead custom config is to be provided via stream attributes
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[x] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[x] I updated the documentation where necessary.

Build passed on fork where AWS integration [tests are enabled][2]

Codecov Report

Merging #4479 into master will increase coverage by 36.73%.
The diff coverage is 72.41%.

@@             Coverage Diff             @@
##           master    #4479       +/-   ##
===========================================
+ Coverage   44.04%   80.78%   +36.73%
===========================================
  Files         170      170
  Lines        7937     7941        +4
  Branches      541      541
===========================================
+ Hits         3496     6415     +2919
+ Misses       4441     1526     -2915

Impacted Files
Coverage Δ

...nwhisk/core/database/cosmosdb/IndexingPolicy.scala
84% <0%> (+84%)
:arrow_up:

...openwhisk/core/database/s3/S3AttachmentStore.scala
79.26% <77.77%> (+79.26%)
:arrow_up:

...openwhisk/common/tracing/OpenTracingProvider.scala
21.15% <0%> (+1.92%)
:arrow_up:

...re/database/MultipleReadersSingleWriterCache.scala
98% <0%> (+2%)
:arrow_up:

...apache/openwhisk/core/entitlement/Collection.scala
87.5% <0%> (+2.5%)
:arrow_up:

.../org/apache/openwhisk/http/PoolingRestClient.scala
91.17% <0%> (+2.94%)
:arrow_up:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (+4%)
:arrow_up:

...whisk/connector/kafka/KafkaConsumerConnector.scala
59.7% <0%> (+4.47%)
:arrow_up:

...enwhisk/core/loadBalancer/InvokerSupervision.scala
95.86% <0%> (+4.82%)
:arrow_up:

...pache/openwhisk/core/entity/ConcurrencyLimit.scala
93.75% <0%> (+6.25%)
:arrow_up:

... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed08ed1...4e0ad83. Read the comment docs.


Add redshiftdata clustername resource mapping

As seen in iam_definition.json, the 5 affected resources need the cluster* resource. However, it is defined with a ClusterName, and not with ClusterIdentifier (as in the SDK request).
This PR adds the appropriate resource mappings to map.json.
The request layout can be seen here: https://docs.aws.amazon.com/redshift-data/latest/APIReference/API_DescribeTable.html
I hope directly modifying this file is fine, I did not find any automation affecting this.
If there is anything still needed for this to go through, please let me know.

LGTM, thanks!
The map.json is indeed the source of truth, everything downstream consumes from here.


Click to open file

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: macOS High Sierra, Version 10.13.4 (17E199)
Hyper.app version: Hyper 2.0.0 (stable)
Link of a Gist with the contents of your .hyper.js: https://gist.github.com/architectcodes/f61264a6319d0710e64b84e4f8993a9e
Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A
The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue
One of the things which made me super productive with iTerm was being able to Cmd+click a filename and having it open in the default program. It even worked with line and column numbers – i.e. Cmd+clicking something like src/that.test.js:302:57 would run atom src/that.test.js:302:57 and therefore open src/that.test.js at line 302, column 57.
I’d love that in hyper! There used to be a plugin for that (https://github.com/capaj/hyperterm-clicky), but now that hyperlinks are built right into Hyper.app, I figured this is the right place to ask for the thing.

Also, clicky is not working (at least for me and some other users). This feature would be really useful.

Clicky is not working since the terminal library changed in hyper 2.0 to xterm.js, I think this needs to be implemented as an xterm.js plugin 🤔 Maybe there's already one.


Can't change hue when node selection is leftmost

Can't change hue when node selection is leftmost.

Interesting, will look into this.

Interesting, will look into this.
At the bottom, there is also a problem with the hue sliding, and only six can be selected.

https://user-images.githubusercontent.com/33448924/172320785-f97ef42d-d1ab-46d3-a60e-50774f3a9041.mp4

I am aware of the second issue and believe the two to be related.
Testing a solution that I am hopeful will solve both and increase responsiveness of the hue slider which I've always found a bit jumpy.

@BabyFriedCake please see version 2.0.6
I believe this issue to be fixed and am closing this issue but please comment if I am incorrect or you find anything else.


Relations of the class Identity in uml are missing

Identity should be linked to User and Group.

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


OOBEEULA error after debloat

So I'm building a debloated Windows Image for my WDS server, but after a debloat and making the image ready with sysprep, I uploaded it to de WDS server.
After that I did a install of the image., but the installation hangs on a OOBEEULA error.
So I was thinking if someone had dealth with this before? Or has a solution for this issue.
In the mean time I will search further for an other solution.

Did you use the Windows10SysPrepDebloater.ps1? I'm not aware of it affect the OOBEEULA but perhaps there is something that is killing it. Do you have a picture of the error that I can look at?

No I used the "Windows10GuiDebloater.ps1" https://imgur.com/a/pDezEsZ but I added a regkey that would dissable that.
But I used the "bloatware remove with blacklist" and "without blacklist", so that I could boot and didn't get the error that the windows installations is broken, but now I get this error.
Hopefully you have a solution for me?

What registry key did you add? Is it one that touches OOBE? My scripts don’t touch OOBE since it can leave windows being non functional.
Sent from my iPhone

On Feb 18, 2019, at 3:11 AM, Jim<EMAIL_ADDRESS>wrote:
No I used the "Windows10GuiDebloater.ps1" https://imgur.com/a/pDezEsZ but I added a regkey that would dissable that.
But I used the "bloatware remove with blacklist" and "without blacklist", so that I could boot and didn't get the error that the windows installations is broken, but now I get this error.
Hopefully you have a solution for me?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Yeah that registry key does something with oobe, it was a fix on the microsoft forum where it would let me get pass that point where im stuck now.
This is wat he said about the reg key: "I find this workaround:
After image deployment, at the OOBE wizard, I import this registry  key to skip user OOBE:
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Setup\OOBE]
"UnattendCreatedUser"=dword:00000001
So only computer OOBE run"
Here is the link
But it didn't fix it for me, so I hope you may know a solution?

Interesting. I can comment out the sysprep code so that we can check to see if it happens on any other machines that you deploy it with?
Try giving this a shot: https://www.tenforums.com/windows-insider/118225-insider-isos-cant-get-past-oobe-stage.html

Yes it's indeed interesting, maybe because I delete the store or some other build in app that has caused this issue, I found a workaround for it at the moment and that's a answer file that I builded that accepts/skips the EULA and creates a user, so when deploying the image it's usable.
I would like to try it on a other system but I'm building it in a virtualized environment :sweat_smile:
Sure I'll look at that forum post maybe that can be of some help.

Okay let me know!

Hi,
I think this can help people who are looking for a solution regarding this problem…
When the error “OOBEEULA” is displayed, do the following:
– Open a command prompt with Shift+F10
– Open registry editor: regedit
– Go to HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Setup\OOBE
– Add a DWORD value named “SetupDisplayedEula” with the data “1”
– Press “retry” on the OOBE screen… and the EULA step is passed. 😉

Hi @JVerhulst - Is this still an issue that is happening? I am following up on old issues.

hi @Sycnex I'm sorry to inform you a bit late but I stopped working on the project. So unless someone else has this issue, you can close it.

This may help you - Fix OOBEEULA Error Something went wrong in Windows 10 or 11


Integrate OVS in ZOS

We use OVS since a while already for advanced networking, but always works as a plugin for zos and is started from a container.
We had sevral problems with networking on ZOS that requires a very advanced capabilites and it was found easier to integrate OVS in ZOS and just use it as replacement for the current networking infrastructure in ZOS:
Fixes #56 #54 #10 #53
What need to be done is:

bridge manager
port forwarding
import ovs functionality from the current ovs plugin to zos

abandoned


Docker images to support Arm architecture

Is your feature request related to a problem? Please describe.
As more and more users are using arm architecture (e.g. Apple M1 users), we need to also publish Docker images for Arm architecture.
Describe the solution you'd like
Publish Docker images for Arm architecture to docker hub and add documentations if necessary.
Additional context
Related issues: #4238, https://github.com/apolloconfig/apollo-quick-start/issues/92

Looks like the fabric8io/docker-maven-plugin supports the feature to build multi-arch images, we may consider using this maven plugin.


fix: fix typos in PR template

Pull Request
Description
Fixes a couple typos in the Checklist section in the PR template...
Checklist

[X] I have added/updated relevant documentation
[X] I have tested these changes locally.
[X] I have followed the code style and guidelines.
[X] I have updated CHANGELOG.md with my changes in the next section
[X] I have run `dart format .`` on the project  There was an extra back-tick here.
[X] I have run dart fix --apply on the project
[X] I have run flutter test and flutter analyze and it passed successfully
[X] I have run ./before-push.sh and everything is fine  The path to the script is incorrect

@singerdmx The newly created workingflow is falling and it said incorrect credentials

I will give you my GitHub login credentials later so you can login

I will give you my GitHub login credentials later so you can login

Don't do that please, it's not safe for you


JsonObject.Count fix & RectInt.Between (similar to Rect constructor)

JsonValue's description of Count suggests that it would also return the Count of KeyValue pairs, but it didn't seem to do that on JsonObject.

(didn't realize this would be automatically added to this pull request, will do on seperate branch next time, sorry)
RectInt.Between(Point2 a, Point2 b) behaves kind of like Rect(Vector2 a, Vector2 b). I'm not sure it's the best implementation since that is now the only static function of RectInt and might be confusing, but I needed something like this since I mostly have all my values as Point2 or int.

Yeah, both of these make sense! I actually like the static call more than the constructor, since I think its more explicit and explains what it does. Rect(Vector2 a, Vector2 b) has messed me up before because it doesn't do what I expect (ex. is it between the points? or is it Pos/Size?)


Store cache in a temporary directory to be cleared on reboot

So in case the user is experiencing a caching related issue and doesn't know how cache works, a simple reboot may magically make it work for them

Fixed by https://github.com/steelbrain/pundle/commit/9bf5023e3db76af711ba9dbbf9c69a331ffadaab


Document Docker usage

Add local development Docker usage.
Also, add todo item related to conversation started on #4, since it's closed. Making it visible in case me or somebody else can pick it up.

@hgoebl ping

@pataquets please maintain your own project and if you want I can place a link in the README to your project. I don't have any time.


HBASE-28354 RegionSizeCalculator throws NPE when regions are in transition

Fixes HBASE-28354.
This PR filters out the regions with null ServerName instances from the regions size calculations.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 43s
Docker mode activated.

I think the problem with that is it just introduces more code. I think there are 2-3 callers of this method and they all pass the result into an InputSplit which takes an int. So if we changed to optional we'd just end up having to update 3 places to do orElse(0)

Per https://issues.apache.org/jira/browse/HBASE-28399 we might want to return something other than 0. Maybe even just 1, or maybe the average region size from the other regions.

@frostruan what do you think?

Thanks for the noticing @bbeaudreault
I think we can introduce a constant UNKNOWN_SIZE with type of Size and value of 1 byte to distinguish between having no data and not knowing the specific size. Another important reason for greater than 0 is as I mentioned in HBASE-28399, some computing engines will automatically prune empty partitions, if 0 is returned for in-transition regions, data may be lost.

Thanks for the noticing @bbeaudreault
I think we can introduce a constant UNKNOWN_SIZE with type of Size and value of 1 byte to distinguish between having no data and not knowing the specific size. Another important reason for greater than 0 is as I mentioned in HBASE-28399, some computing engines will automatically prune empty partitions, if 0 is returned for in-transition regions, data may be lost.

Per https://issues.apache.org/jira/browse/HBASE-28399 we might want to return something other than 0. Maybe even just 1, or maybe the average region size from the other regions.

agree. I think 1 byte is enough. The size of any region with data cannot be 1 byte. In addition, I think we'd better add some more comments to tell users and developers the reasons for the context.

@frostruan, which part of the code would handle that byte? Also, should that be added to this PR or yours (https://github.com/apache/hbase/pull/5700)?

Also ping Duo~ @Apache9
This problem is related to my PR you reviewed yesterday, would you mind taking a look at this too ?

I'm wondering what the byte constant would hold, other than 0:

If it held 1, it would mean that regions that no longer exist would still get reported with size (maybe?)

I'm having trouble understanding tests about inexistent regions and how HBase reacts to them eventually

If it held -1, we'd need to refactor the callers to handle the < 0 case, which will make "UNKNOWN REGIONS" more explicit with comments

Alternatively, if we return the average size of all other regions might be good but it will push the idea of a region in transition too deep into the RegionSizeCalculator and other areas won't know about it, maybe they should? What if there are currently no regions available? What if there is one (or more) region in transition and the size map is empty? What if the size map only contains a region that's empty? I am not sure if these cases are realistic, I'm still new to the codebase.

I prefer to use 1 byte to represent unknown region size for two reasons:

it cannot be a valid region size because even a minimal keyvalue is bigger than that.
some computing engines, like spark, will filter out splits with size less than 0. You can see this for details.
https://github.com/apache/spark/blob/v3.5.1-rc2/core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala#L138

I'll try to answer your questions later, sorry have to catch the shuttle bus.
Thanks. @aalhour

If it held 1, it would mean that regions that no longer exist would still get reported with size (maybe?)

I don't think regions in state transition and regions no longer exist are same thing. When we call regionLocator.getAllRegionLocations(), we will exlcude offlined split parent regions. You can see https://github.com/apache/hbase/blob/rel/3.0.0-beta-1/hbase-client/src/main/java/org/apache/hadoop/hbase/ClientMetaTableAccessor.java#L172 for details.

I don't think it is appropriate to return the average size of other regions, we should not make any decisions for the user.

What if there are currently no regions available?

I don't think this is a big deal. As @ndimiduk mentioned, it's just a hint for MapReduce scheduler.
Thanks. @aalhour

Cases where the region's size can be returned as -1:

MultiTableInputFormatBase.java#L216
mapreduce/TableInputFormatBase.java#L301
mapreduce/TableInputFormatBase.java#L345

Not sure if we should do anything in the TableSplit.java class which is used by the above.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 56s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
0m 47s
master passed

+1 :green_heart:
checkstyle
0m 17s
master passed

+1 :green_heart:
spotless
0m 56s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
0m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

+1 :green_heart:
compile
0m 35s
the patch passed

+1 :green_heart:
javac
0m 35s
the patch passed

+1 :green_heart:
checkstyle
0m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
6m 31s
Patch does not cause any errors with Hadoop 3.3.6.

+1 :green_heart:
spotless
1m 17s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

29m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5699

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 017523f1539d 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b552434db

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
77 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for your quick address. @aalhour  Sorry that maybe I didn't express my thoughts clearly and caused you some confusion. In fact, we share some of the same views.
About the constant UNKNOWN_SIZE, I think maybe it should be defined as following:
private static final Size UNKNOWN_SIZE = new Size(1, Size.Unit.BYTE);
or
private static final long UNKNOWN_SIZE = 1;
The byte size of UNKNOWN_SIZE must be greater than 0 so that this input split will not be filtered out because we will use region byte size as the input split length. :)

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 25s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 41s
master passed

+1 :green_heart:
compile
0m 16s
master passed

+1 :green_heart:
shadedjars
5m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 24s
the patch passed

+1 :green_heart:
compile
0m 17s
the patch passed

+1 :green_heart:
javac
0m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
13m 53s
hbase-mapreduce in the patch passed.

32m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5699

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f4fc2944392e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b552434db

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/testReport/

Max. process+thread count
2886 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
shadedjars
7m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 21s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 42s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
6m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
17m 24s
hbase-mapreduce in the patch passed.

41m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5699

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 10aba391ed21 5.4.0-163-generic #180-Ubuntu SMP Tue Sep 5 13:21:23 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 4b552434db

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/testReport/

Max. process+thread count
2865 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5699/3/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Hello @frostruan, thanks for clarifying, yeah that's in line with my previous thoughts, I was confused as to why we want to specify a byte and return it from a method that returns longs. Now it's clear. I have just pushed some changes, can you please take one final look and tell me if it's good to be merged?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

I think this PR is good enough to solve the problem it intends to solve.
+1 !
I think there is still some room for optimization here, but this is another problem. We can file another issue to follow up.
Thanks.

Awesome, thanks a lot @frostruan. I just pinged @ndimiduk to help me merge it.
Out of curiosity, what remaining problems do you see that need attention? Can we write a quick ticket describing them? I'll see if there's appetite in the team (@HubSpot) to work on them.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

Out of curiosity, what remaining problems do you see that need attention? Can we write a quick ticket describing them? I'll see if there's appetite in the team (https://github.com/HubSpot) to work on them.

Thanks a lot ! @aalhour
I used to think that we did not fully consider the situation of region merge/split. Once a region is split or merged, it may cause some overlap or loss of the data we read. However, after thinking about it again, I think it seems unlikely. , so please ignore me. :)

Thanks @ndimiduk, @frostruan and @bbeaudreault for the feedback.
I have just reverted the changes back to "returning 0 for unknown regions".

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

Thanks for the thoughtful reviews everyone!


add values property and refactor other properties

This exposes the read_data() to users so it can operate like most of the Arduino versions of this library (e.g. WiiChuck). They can call the read_data() function at the top of their loop to pull the data and then use the properties throughout to retrieve the data. The properties themselves no longer call read_data(). Likewise, this offers a new property values that reads the data once and passes back a named tuple of all of the other properties (#21). The named tuple uses the naming conventions of the data diagram from WiiBrew. I am open to other suggestions, though I would like to be consistent because there are several other extension controllers I want to base off of this library.

We can effectively do the same thing via a values property. Instead of exposing _read_data, it would get called in values.
Simple code that doesn't need super fast speed can be written like the current examples:
if nc.button_C or nc.button_Z:
    print("button")

No need to make any special calls to read the data. Yes, this would take two I2C transactions for each button read. But for most use cases, hopefully that doesn't matter. (esp. with recent I2C improvements)
For use cases where the additional reads slow things down, can do:
values = nc.values
if values.buttons.C or values.buttons.Z:
    print("button")

That would be a single I2C transaction. This approach also helps makes it a little clearer that in this second case buffered values are being used, not the actual current values from the Nunchuk.
I've played around with this approach and have pushed some code here:
https://github.com/caternuson/Adafruit_CircuitPython_Nunchuk/blob/iss21/adafruit_nunchuk.py

We can effectively do the same thing via a values property. Instead of exposing _read_data, it would get called in values.
Simple code that doesn't need super fast speed can be written like the current examples:
if nc.button_C or nc.button_Z:
    print("button")

No need to make any special calls to read the data. Yes, this would take two I2C transactions for each button read. But for most use cases, hopefully that doesn't matter. (esp. with recent I2C improvements)
For use cases where the additional reads slow things down, can do:
values = nc.values
if values.buttons.C or values.buttons.Z:
    print("button")

That would be a single I2C transaction. This approach also helps makes it a little clearer that in this second case buffered values are being used, not the actual current values from the Nunchuk.
I've played around with this approach and have pushed some code here:
https://github.com/caternuson/Adafruit_CircuitPython_Nunchuk/blob/iss21/adafruit_nunchuk.py

I like this approach. The values is even clearer with the nested named tuples. I think it will translate well to the other extension controllers.

I like this approach. The values is even clearer with the nested named tuples. I think it will translate well to the other extension controllers.

I tested your above approach and it is a lot slower when you use this it on the classic controller that has 20 inputs. If you are reading from one joystick not only are you doing an ic2 read that input, but you are parsing the entire data packet for all the other inputs even though you are not using them. Also, I had to convert my file to an .mpy in order to run because of memory issues.

I tested your above approach and it is a lot slower when you use this it on the classic controller that has 20 inputs. If you are reading from one joystick not only are you doing an ic2 read that input, but you are parsing the entire data packet for all the other inputs even though you are not using them. Also, I had to convert my file to an .mpy in order to run because of memory issues.

Hmmm. Yah, I was assuming / hoping the data unpacking was fast enough it didn't need to be optimized. But can look at refactoring that better.

Hmmm. Yah, I was assuming / hoping the data unpacking was fast enough it didn't need to be optimized. But can look at refactoring that better.

Can you take a look at commit 97aad9e? It allows for three options.

Use the values property.
Use the slower code like the examples
Or a combination of the read_data method and the property values.

nc = adafruit_nunchuk.Nunchuk(board.I2C())

values = nc.values
if values.buttons.C or values.buttons.Z:
    print("button")

nc = adafruit_nunchuk.Nunchuk(board.I2C())

# each one will do a separate I2C transaction
if nc.button_C or nc.button_Z:
    print("button")

The new force_read argument helps handle this. This would also allow for individuals to easily port Arduino projects.
nc = adafruit_nunchuk.Nunchuk(board.I2C(),force_read=False)

# completes the I2C transaction
nc.read_data()

# parses the button states from the last call to nc.read_data()
if nc.button_C or nc.button_Z:
    print("button")

Can you take a look at commit 97aad9e? It allows for three options.

Use the values property.
Use the slower code like the examples
Or a combination of the read_data method and the property values.

nc = adafruit_nunchuk.Nunchuk(board.I2C())

values = nc.values
if values.buttons.C or values.buttons.Z:
    print("button")

nc = adafruit_nunchuk.Nunchuk(board.I2C())

# each one will do a separate I2C transaction
if nc.button_C or nc.button_Z:
    print("button")

The new force_read argument helps handle this. This would also allow for individuals to easily port Arduino projects.
nc = adafruit_nunchuk.Nunchuk(board.I2C(),force_read=False)

# completes the I2C transaction
nc.read_data()

# parses the button states from the last call to nc.read_data()
if nc.button_C or nc.button_Z:
    print("button")

I think for porting Arduino projects, they can just use the values approach, which is effectively the same thing. If that means more lines of code need changing, that's OK. So no need to support scenario 3 above.
For optimizing the reads, I think this same general flag for doing the read and updating the buffer is good. Sort of like what you have in place with force_read. But we can manage it automatically behind the scenes.  I've pushed some changes here as an example (but also I'm still thinking about all this):
https://github.com/caternuson/Adafruit_CircuitPython_Nunchuk/blob/iss21/adafruit_nunchuk.py
Hopefully this refactoring of the byte processing helps with the issue for when there are a ton of parameters? With the Nunchuk, it's hard to tell.
Just to be clear on the .mpy file creation - was that for the Classic Controller code you wrote? Or was it for this Nunchuk code? In the long wrong, everything becomes an .mpy. For the bundle, all libraries are converted to .mpy automatically as part of the bundle creation.

I think for porting Arduino projects, they can just use the values approach, which is effectively the same thing. If that means more lines of code need changing, that's OK. So no need to support scenario 3 above.
For optimizing the reads, I think this same general flag for doing the read and updating the buffer is good. Sort of like what you have in place with force_read. But we can manage it automatically behind the scenes.  I've pushed some changes here as an example (but also I'm still thinking about all this):
https://github.com/caternuson/Adafruit_CircuitPython_Nunchuk/blob/iss21/adafruit_nunchuk.py
Hopefully this refactoring of the byte processing helps with the issue for when there are a ton of parameters? With the Nunchuk, it's hard to tell.
Just to be clear on the .mpy file creation - was that for the Classic Controller code you wrote? Or was it for this Nunchuk code? In the long wrong, everything becomes an .mpy. For the bundle, all libraries are converted to .mpy automatically as part of the bundle creation.

I am OK with the processing of the do_read and removing support for scenario 3. What is the benefit of doing the byte processing for all the buttons in one function instead of in the individual ones? It isn't a big deal for this particular library, but it is really hard to understand what exactly is going on. Where the original with the byte processing in each individual property is much easier to understand what is going on. I will push another update with using your do_read approach with how I think the byte processing should happen.
The .mpy comment was just an observation and it was for the Classic Controller code which has many more properties.

I am OK with the processing of the do_read and removing support for scenario 3. What is the benefit of doing the byte processing for all the buttons in one function instead of in the individual ones? It isn't a big deal for this particular library, but it is really hard to understand what exactly is going on. Where the original with the byte processing in each individual property is much easier to understand what is going on. I will push another update with using your do_read approach with how I think the byte processing should happen.
The .mpy comment was just an observation and it was for the Classic Controller code which has many more properties.

I did some playing around with your approach on the Classic Controller and it looks like it will work. Do you want to me to close this pull request?

I did some playing around with your approach on the Classic Controller and it looks like it will work. Do you want to me to close this pull request?

What is the benefit of doing the byte processing for all the buttons in one function instead of in the individual ones?

None really. Just didn't want to have a guzzilion _foo() functions for each property, each with its related byte processing code. That was my one attempt at trying to be clever and consolidate things a little.
I'm wondering if we could consolidate all those into a single private function, something like a _process_bytes(), instead of _joystick, _buttons, etc. And pass in some parameter(s) to control logic in there that only parses what's needed.

I will push another update with using your do_read approach with how I think the byte processing should happen.

Sure, if you want to. But if this is holding you up and you want to move on, I can PR (eventually) what I've been hacking on.

What is the benefit of doing the byte processing for all the buttons in one function instead of in the individual ones?

None really. Just didn't want to have a guzzilion _foo() functions for each property, each with its related byte processing code. That was my one attempt at trying to be clever and consolidate things a little.
I'm wondering if we could consolidate all those into a single private function, something like a _process_bytes(), instead of _joystick, _buttons, etc. And pass in some parameter(s) to control logic in there that only parses what's needed.

I will push another update with using your do_read approach with how I think the byte processing should happen.

Sure, if you want to. But if this is holding you up and you want to move on, I can PR (eventually) what I've been hacking on.

After looking it over, I am okay with the _buttons, _joystick, _accelleration. I think there needs to be comments to identify what is being parsed out though. This is what I have for the Classic Controller:
    def _buttons(self, do_read=True):
        if do_read:
            self._read_data()
        return self._Buttons(
            not bool(self._read_data()[5] & 0x10),  # A
            not bool(self._read_data()[5] & 0x40),  # B
            not bool(self._read_data()[5] & 0x8),   # X
            not bool(self._read_data()[5] & 0x20),  # Y
            not bool(self._read_data()[4] & 0x2),   # R
            not bool(self._read_data()[4] & 0x20),  # L
            not bool(self._read_data()[5] & 0x4),   # ZR
            not bool(self._read_data()[5] & 0x80),  # ZL
            not bool(self._read_data()[4] & 0x4),   # start
            not bool(self._read_data()[4] & 0x10),  # select
            not bool(self._read_data()[4] & 0x10),  # home
            )

After looking it over, I am okay with the _buttons, _joystick, _accelleration. I think there needs to be comments to identify what is being parsed out though. This is what I have for the Classic Controller:
    def _buttons(self, do_read=True):
        if do_read:
            self._read_data()
        return self._Buttons(
            not bool(self._read_data()[5] & 0x10),  # A
            not bool(self._read_data()[5] & 0x40),  # B
            not bool(self._read_data()[5] & 0x8),   # X
            not bool(self._read_data()[5] & 0x20),  # Y
            not bool(self._read_data()[4] & 0x2),   # R
            not bool(self._read_data()[4] & 0x20),  # L
            not bool(self._read_data()[5] & 0x4),   # ZR
            not bool(self._read_data()[5] & 0x80),  # ZL
            not bool(self._read_data()[4] & 0x4),   # start
            not bool(self._read_data()[4] & 0x10),  # select
            not bool(self._read_data()[4] & 0x10),  # home
            )

Do you also have individual properties for each button? Something equivalent to button_Z and button_C in this Nunchuk controller?

Do you also have individual properties for each button? Something equivalent to button_Z and button_C in this Nunchuk controller?

I do currently, but I think I am going to remove them. I just made a push to this one with your changes and removing the individual properties. What do you think about this one?

I do currently, but I think I am going to remove them. I just made a push to this one with your changes and removing the individual properties. What do you think about this one?

That'd work. I actually did that also at one point. Only issue is that it breaks the current API, since button_Z and button_C go away. Code would need to be changed to buttons.Z and buttons.C. We could break the API if we wanted though. I guess I was trying to keep backwards compatibility, but without any huge justification for it.
Are you finding that with the Classic Controller all that parsing is slowing things down if you just want to read an individual button?

That'd work. I actually did that also at one point. Only issue is that it breaks the current API, since button_Z and button_C go away. Code would need to be changed to buttons.Z and buttons.C. We could break the API if we wanted though. I guess I was trying to keep backwards compatibility, but without any huge justification for it.
Are you finding that with the Classic Controller all that parsing is slowing things down if you just want to read an individual button?

You could keep those two properties for the adafruit_nunchuck if you didn't want to break backwards compatibility, but I don't think I would want to implement individual properties in the other extension controllers. Maybe remove the individual properties from the examples and push people to either use values, buttons, joystick, etc. I am not experiencing issues with the Classic Controller if I don't use the individual properties.

You could keep those two properties for the adafruit_nunchuck if you didn't want to break backwards compatibility, but I don't think I would want to implement individual properties in the other extension controllers. Maybe remove the individual properties from the examples and push people to either use values, buttons, joystick, etc. I am not experiencing issues with the Classic Controller if I don't use the individual properties.

Thanks for continuing to work this. I think it's getting very close to being merged. See the few comments I've added.
Also - it looks like the nunchuk_mouse.py example got removed?

Thanks for continuing to work this. I think it's getting very close to being merged. See the few comments I've added.
Also - it looks like the nunchuk_mouse.py example got removed?

I removed the nunchuk_mouse.py because it didn't properly handle button presses. It may have worked previously because of the slow i2c transactions. I didn't see what the benefit of having it included while there was the nunchuk_analog_mouse.py example, but I can fix the issues and add it back.

I removed the nunchuk_mouse.py because it didn't properly handle button presses. It may have worked previously because of the slow i2c transactions. I didn't see what the benefit of having it included while there was the nunchuk_analog_mouse.py example, but I can fix the issues and add it back.

OK, that makes sense. Yah, it seemed like nunchuk_analog_mouse.py was sort of an updated version of nunchuk_mouse.py anyway. I'm OK with that then. I like having it be just two examples - one for joystick and one for accelo.

OK, that makes sense. Yah, it seemed like nunchuk_analog_mouse.py was sort of an updated version of nunchuk_mouse.py anyway. I'm OK with that then. I like having it be just two examples - one for joystick and one for accelo.


Hub-Refinement: Structural Changes

[x] Move the "portal buttons" of each subpage (= Resources, Networking, 'Content') to a dropdown menu (named Portals (??) or Area (??) next to the search
[x] Social media Buttons, search Button and CMS access button next to the "Portal Buttons" can also go (away mainly :D, i think it is enough having those in the footer)
[x] The Breadcrumb in the About section works kinda funky -> either not continuing or not working at all
[x] Imprint and Data protection in About section to organize in cards
[x] "Coming soon" pages need a working breadcrumb :)
[x] #248
[x] In  https://reinherit-hub.eu/cms/ the "detailed manual" link needs the right link --> https://reinherit-hub.eu/doc/howto
[x] Add Download Button to e-shop Items

implemented


Wrong default value of rabbitmq_vhost

Hi,
It seems like a slash has dropped off the default value in https://github.com/sensu/sensu-puppet/blob/master/manifests/init.pp#L304 -- it should probably be /sensu not sensu.
Setting the value explicitly when calling class { 'sensu': ... } solved my keepalive problems :)
~llaurén

Yes, this bit me as well...

@llauren I think I am having the same issue. My host are not connecting to RabbitMQ. How did you explicitly set the value?

specify
               rabbitmq_vhost          => '/sensu',
in the class definition

Yeah i got it, thanks!

So it looks like this was changed in this [commit|https://github.com/sensu/sensu-puppet/commit/4d00cc8cb7a8f4d9f74eb7d9ac4b5da5744122d0] way back in 2014. I'm happy to switch it back as we seem to have better support now for this.


Add support for .NET Framwork 4.7.1 with Unity 2021.2 or newer

Closes #165

@microsoft-github-policy-service agree

I think the build pipeline was not triggered yet.
The latest version (0.9.2-223520) seems to be from November 2021.
Could someone update this?

The pipeline is manual right now, I've ran it and a new version is now up with latest from 'master'.


config for serving assets in project-stub

Add configs in project-stub for serving assets (js, css, images)

I'm not sure that I understand you right. Did you see project-stub with express-bem: https://github.com/express-bem/project-stub/ ?


Fuck

so for some reason now every time i try and put any file into utinyripper it comes up with this Game name: (please, specify the game name)
Engine version: (specify engine version, if known)
Platform: (specify platform, if known)
Error message: Some data left
Stack trace:    at uTinyRipper.Lz4.Lz4DecodeStream.ReadBuffer(Stream stream, Int64 count)
at uTinyRipper.BundleFileScheme.ReadFileStreamMetadata(Stream stream, Int64 basePosition)
at uTinyRipper.BundleFileScheme.ReadScheme(Stream stream)
at uTinyRipper.GameCollection.ReadScheme(SmartStream stream, String filePath, String fileName)
at uTinyRipper.GameCollection.LoadScheme(String filePath, String fileName)
at uTinyRipper.GameStructure.ProcessPlatformStructure(GameStructureProcessor processor, PlatformGameStructure structure)
at uTinyRipper.GameStructure.Load(List1 pathes, LayoutInfo layinfo)    at uTinyRipper.GameStructure.Load(IEnumerable1 pathes, LayoutInfo layinfo)
at uTinyRipperGUI.MainWindow.LoadFiles(Object data)
any ideas on how to fix this ?

Great vid my man. I’m sure u won’t be a hidden gem channel for much longer

But can u plz watch dog eating china


multiple dynamic parameters

I'm using the bread-curmb component in a slightly modified version as I'm still on Ember 1.8.0 without ember-cli. The only change made is in the template where the #each helper you're using is not availble yet in 1.8. Everything works fine (properly generated etc) except having multiple clickable routes in one controller. It is showing the crumbs correctly, but when clicked the model hook in the corresponding route is not firing. Do you have any idea what this could be?
my template:
<ul class="bcrumbs">
  {{#each crumb in breadCrumbs}}
    <li {{bind-attr class="crumb.isCurrent:current:"}}>
      {{#if crumb.linkable}}
        {{#if crumb.model}}{{! to avoid null/undefined model in link-to }}
          {{#link-to crumb.path crumb.model}}
            {{crumb.label}}
          {{/link-to}}
        {{else}}
          {{#link-to crumb.path}}
            {{crumb.label}}
          {{/link-to}}
        {{/if}}
      {{else}}
        {{crumb.label}}
      {{/if}}
    </li>
  {{/each}}
</ul>

route:
  this.resource('search', function(){
    this.route('index', { path: ':destination/pagina/:page'});
  });

Code I have:
breadCrumbs: function() {
'use strict';

var crumbArray = [];

// add country
if (this.get('model.country') !== '') {
  crumbArray.push({
    label: this.get('model.country'),
    path: 'search.index',
    model: {destination: this.get('model.country'), page: 1}
  });
}

// add region
if (this.get('model.region') !== '') {
  crumbArray.push({
    label: this.get('model.region'),
    path: 'search.index',
    model: {destination: this.get('model.region'), page: 1}
  });
}

// add city
if (this.get('model.city') !== '') {
  crumbArray.push({
    label: this.get('model.city'),
    path: 'search.index',
    model: {destination: this.get('model.city'), page: 1}
  });
}

// add name
if (this.get('model.name') !== '') {
  crumbArray.push({
    label: this.get('model.name')
  });
}

return crumbArray;
}.property()

I think that it is normal behavior to bypass the model hook when you provide the model via {{link-to}}.

I'm I using the path wrongly then? The crumbs are being shown on route A, and when clicked I want to transition to route B with the 2 dynamic parameters.
Also on the same page I have a hard coded link that at least looks the same in the chrome inspector but works, while the one I'm generating in the breadCrumbs is not.

Has solution been found for this issue?

It seems that this problem occurs only when the breadcrumb path isn't pointing to the active route (or its parent routes).
Here's my solution:
Add a linkParams property for each breadcrumb. This property holds all positional params sent to link-to helper. Now the breadcrumb model can also be an array that will be concatenated to linkParams.
// components/bread-crumbs.js
import Ember from "ember";
import BreadCrumbs from "ember-breadcrumbs/components/bread-crumbs";

export default BreadCrumbs.extend({
  breadCrumbs<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>    "pathNames.[]", function() {
    return this._super(...arguments).map((breadcrumb) => {
      var models = breadcrumb.model;
      if (!Ember.isArray(models)) {
        models = [models];
      }
      breadcrumb.linkParams = [breadcrumb.path].concat(models.compact());
      return breadcrumb;
    });
  })
});

Then in bread-crumbs component template pass the linkParams to the link-to helper. Here implementation varies depending on Ember version (more info on StackOverflow):
<!-- Ember 1.13.* -->
{{#-link-to params=(unbound crumb.linkParams) hasBlock=true}}
   {{crumb.label}}
{{/-link-to}}

<!-- Ember 2.* -->
{{#link-to params=crumb.linkParams}}
  {{crumb.label}}
{{/link-to}}

Usage
This breadcrumb model definition
breadCrumbModel: Ember.computed("country", function() {
  return [this.get("country"), 1];
})

will have the same effect as this handlebars code
{{#link-to 'search.index' country 1}}...{{/link-to}}

@jembezmamy +1. Thank you very much. Your solution works perfectly for me. Now through the model property I can send array of parameters and link properly through breadcrumbs.


The "Start Streaming Logs" behavior are inconsistent between clean web app and the web app which has the project deployed

OS: Win 10
Build Version: 20200425.1
Repro Steps:

Create 2 web apps.
Deploy a project to a web app but not for another one..
Stop these 2 web apps.
Execute the "Start Streaming Logs" action for these 2 web apps.
Check the output for these 2 web apps.

Expect:
The behavior for the clean web app and the web app which has the project deployed are consistent.
Actual:
The behavior are inconsistent for clean web app and the web app which has the project deployed. Auto stop streaming logs for the clean web app but not for the web app which has the project deployed.
Web app which has the project deployed:

Clean web app:

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


GEOMESA-2109 ObjectType matching for specific geometry bindings

Removes some unused filter methods

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

This is good to go after the bits about CURRENT_SCHEMA_VERSION are discussed/sorted out.


(autohotkey.install) install failing in verifier and in test environment

Checklist

[X] I have verified that this is the correct repository, and the package is maintained by the chocolatey-community user.
[X] I have verified that this is happening in the latest available version of the package.

Chocolatey Version
2.2.2
Chocolatey License
None
Package Version
2.0.15-2.0.17
Current Behaviour
The verifier is failing via the sofware installer hanging. When I try it in the test environment, it hangs also with an error of Error: This value of type "Installation" has no property named "Hashes". This error happens on line 51 of the installation script, at the Start-ChocolateyProcessAsAdmin call.

Expected Behaviour
That the package works in the verifier and in the test environment.
Steps To Reproduce

Add autohotkey.install version 2.0.15 to the test env vagrantfile
Run vagrant up --provision

Environment
- Operating System: Server 2019
- PowerShell Version: 5.1.17763.5576
- Shell: Powershell

Chocolatey Log
2024-05-17 16:13:41,481 6420 [DEBUG] - ---------------------------Script Execution---------------------------
2024-05-17 16:13:41,481 6420 [DEBUG] - Running 'ChocolateyScriptRunner' for autohotkey.install v2.0.15 with packageScript 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools\chocolateyInstall.ps1', packageFolder:'C:\ProgramData\chocolatey\lib\autohotkey.install', installArguments: '', packageParameters: '', preRunHookScripts: '', postRunHookScripts: '',
2024-05-17 16:13:41,496 6420 [DEBUG] - Running package script 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools\chocolateyInstall.ps1'
2024-05-17 16:13:41,559 6420 [DEBUG] - Running Get-PackageParameters
2024-05-17 16:13:41,574 6420 [DEBUG] - Parsing $env:ChocolateyPackageParameters and $env:ChocolateyPackageParametersSensitive for parameters
2024-05-17 16:13:41,590 6420 [DEBUG] - Running Get-OSArchitectureWidth -compare '64'
2024-05-17 16:13:41,637 6420 [DEBUG] - Running Install-ChocolateyInstallPackage -silentArgs '/silent' -file 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_2.0.15_setup.exe' -fileType 'exe' -validExitCodes '0 1223' -packageName 'autohotkey.install'
2024-05-17 16:13:41,637 6420 [DEBUG] - Running Get-OSArchitectureWidth -compare '32'
2024-05-17 16:13:41,652 6420 [INFO ] - Installing autohotkey.install...
2024-05-17 16:13:41,856 6420 [DEBUG] - Running Start-ChocolateyProcessAsAdmin -validExitCodes '0 1223' -workingDirectory 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools' -statements '/silent ' -exeToRun 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_2.0.15_setup.exe'
2024-05-17 16:13:41,902 6420 [DEBUG] - Test-ProcessAdminRights: returning True
2024-05-17 16:13:41,918 6420 [DEBUG] - Elevating permissions and running ["C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_2.0.15_setup.exe" /silent ]. This may take a while, depending on the statements.
2024-05-17 16:13:43,965 6420 [DEBUG] - Command ["C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_2.0.15_setup.exe" /silent ] exited with '0'.
2024-05-17 16:13:43,981 6420 [DEBUG] - Finishing 'Start-ChocolateyProcessAsAdmin'
2024-05-17 16:13:43,981 6420 [INFO ] - autohotkey.install has been installed.
2024-05-17 16:13:44,012 6420 [INFO ] - VERBOSE: Trying local and machine (x32 & x64) Uninstall keys
2024-05-17 16:13:44,043 6420 [DEBUG] - Running Get-UninstallRegistryKey -softwareName 'AutoHotkey*'
2024-05-17 16:13:44,043 6420 [INFO ] - VERBOSE: Retrieving all uninstall registry keys
2024-05-17 16:13:44,106 6420 [DEBUG] - Registry uninstall keys on system: 28
2024-05-17 16:13:44,106 6420 [DEBUG] - Error handling check: 'Get-ItemProperty' fails if a registry key is encoded incorrectly.
2024-05-17 16:13:44,152 6420 [DEBUG] - Found 1 uninstall registry key(s) with SoftwareName:'AutoHotkey*'
2024-05-17 16:13:44,152 6420 [INFO ] - VERBOSE: Trying Uninstall key property 'InstallLocation'
2024-05-17 16:13:44,168 6420 [INFO ] - AutoHotkey* installed to 'C:\Program Files\AutoHotkey'
2024-05-17 16:13:44,293 6420 [INFO ] - AutoHotkey* registered as AutoHotkey
2024-05-17 16:13:44,293 6420 [DEBUG] - Running Install-ChocolateyInstallPackage -silentArgs '/S /U64 /install' -file 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_<IP_ADDRESS>_setup.exe' -fileType 'exe' -validExitCodes '0 1223' -packageName 'autohotkey.install'
2024-05-17 16:13:44,293 6420 [DEBUG] - Running Get-OSArchitectureWidth -compare '32'
2024-05-17 16:13:44,293 6420 [INFO ] - Installing autohotkey.install...
2024-05-17 16:13:44,309 6420 [DEBUG] - Running Start-ChocolateyProcessAsAdmin -validExitCodes '0 1223' -workingDirectory 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools' -statements '/S /U64 /install ' -exeToRun 'C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_<IP_ADDRESS>_setup.exe'
2024-05-17 16:13:44,309 6420 [DEBUG] - Test-ProcessAdminRights: returning True
2024-05-17 16:13:44,309 6420 [DEBUG] - Elevating permissions and running ["C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_<IP_ADDRESS>_setup.exe" /S /U64 /install ]. This may take a while, depending on the statements.
2024-05-17 16:13:45,012 6420 [DEBUG] - Command ["C:\ProgramData\chocolatey\lib\autohotkey.install\tools\AutoHotkey_<IP_ADDRESS>_setup.exe" /S /U64 /install ] exited with '0'.
2024-05-17 16:13:45,012 6420 [DEBUG] - Finishing 'Start-ChocolateyProcessAsAdmin'
2024-05-17 16:13:45,027 6420 [INFO ] - autohotkey.install has been installed.
2024-05-17 16:13:45,027 6420 [DEBUG] - Running Start-ChocolateyProcessAsAdmin -exeToRun 'C:\Program Files\AutoHotkey\v2\AutoHotkey.exe' -statements '"C:\Program Files\AutoHotkey\ux\install.ahk" /silent'
2024-05-17 16:13:45,027 6420 [DEBUG] - Test-ProcessAdminRights: returning True
2024-05-17 16:13:45,027 6420 [DEBUG] - Elevating permissions and running ["C:\Program Files\AutoHotkey\v2\AutoHotkey.exe" "C:\Program Files\AutoHotkey\ux\install.ahk" /silent]. This may take a while, depending on the statements.

Anything else?
No response

There is some commentary around this here, though I'm unsure that applies to our verifier environment. I'll try and find out.

Also failing with version 2.0.16 and 2.0.17. I've updated the description.

From autohotkey and autohotkey (install) #2503 :

Just as an update - I forced both upgrades (V2.0.18) on my computer and they worked with no other intervention on my part.

The .install package has a high virustotal count, so the description needs to be updated with a similar note to the .portable package so it can be exempted from the scanner.

This bug does appear to be fixed upstream, closing issue.


Inherit variables from main Dockerfile to agent's Dockerfile

Is your feature request related to a problem? Please describe.
Related to https://github.com/rancher/rancher/issues/41730, which is a short-term solution to the problem of having to specify the pinned webhook version upstream (package/Dockerfile) and downstream (package/Dockerfile.agent).
The goal is to minimize the number of steps release captains need to take to prepare a release. The more things are automated, the better.
Describe the solution you'd like
Describe alternatives you've considered
Additional context
SURE-6429

QA to validate:

#
Scenario
Steps
Status

1
Fresh install checks

Create rancher server by setting the webhook version env as CATTLE_RANCHER_WEBHOOK_VERSION=2.0.4+up0.3.5
Verify local cluster webhook version is on the version specified above
Create a downstream cluster and verify the version on the downstream clusters is 2.0.4+up0.3.5
Verify the downstream cluster’s webhook has newer versions.
Upgrade the downstream clusters webhook version
Verify the webhook version is changed back to the version 2.0.4+up0.3.5

2
Fresh install checks

Create rancher server by setting the webhook version - do not set the CATTLE_RANCHER_WEBHOOK_VERSION env var
Verify local cluster webhook version is the latest version.
Create a downstream cluster and verify the version on the downstream clusters is same as that of the local cluster.
Edit the cluster-agent and set the env var CATTLE_RANCHER_WEBHOOK_VERSION=2.0.4+up0.3.5
Verify the downstrem clusters webhook is not changed and stays at the latest rc version.
Verify the downstream cluster’s webhook has newer versions.
Upgrade the downstream clusters webhook version
Verify the webhook version is changed back to the version on the local cluster.

3
Upgrade checks

Create a rancher server on v2.7.5
Create a downstream cluster and verify the version on the downstream clusters
Upgrade rancher server and set the webhook version to CATTLE_RANCHER_WEBHOOK_VERSION=2.0.4+up0.3.5
Verify the version on the downstream clusters is 2.0.4+up0.3.5
Create a new downstream cluster and verify the version on the downstream is also 2.0.4+up0.3.5

4
Hosted rancher checks - Fresh install checks

Create a hosted rancher on v2.7-head
Create 2 downstream clusters on the server
verify the version of webhook on both the clusters
Install rancher on one of the clusters
Create a downstream cluster on the tenant server
Verify the webhook versions on both the clusters match the host webhook version.

5
Hosted rancher checks - Upgrade checks

Create a hosted rancher on v2.7.5
Create 2 downstream clusters on the server
verify the version of webhook on both the clusters
Install rancher on one of the clusters
Create a downstream cluster on the tenant server
Verify the webhook versions on both the clusters.
Upgrade the host and verify the version on the downstream and the tenant
Tenant and the downstream on tenant should stay at 2.0.4+up0.3.5
Downstream cluster should have upgraded rancher version
Upgrade the tenant and verify the webhook version
Tenant and the downstream on tenant should have upgraded versions.

6
Backup restore rollback via migration

QA Testing
Use the default config
Build Rancher for linux amd64
Build and package Rancher (and the agent) using our scripts.
Currently, the scripts assume the desired OS and architecture are those of the current system.
Thus, you'd need to adjust the scripts for linux amd64.
Prepend GOOS=linux GOARCH=amd64 to the commands that build the agent and server binaries:
https://github.com/rancher/rancher/blob/befc0c8e912fd4287488d0db899156d54c6b9a76/scripts/build-agent#L21
https://github.com/rancher/rancher/blob/befc0c8e912fd4287488d0db899156d54c6b9a76/scripts/build-server#L27
Modify the docker build command invocations, so that they start as
docker buildx build --platform linux/amd64 rather than docker build:
https://github.com/rancher/rancher/blob/befc0c8e912fd4287488d0db899156d54c6b9a76/scripts/package#L24
https://github.com/rancher/rancher/blob/befc0c8e912fd4287488d0db899156d54c6b9a76/scripts/package#L36
Run scripts
Run build and package. Tag the resulting two images however you want and push them.
Run your custom Rancher build with your custom agent
For Docker, run:
docker run -d -p 80:80 -p 443:443 -e CATTLE_AGENT_IMAGE={your-agent-image} --privileged --name rancher {your-main-image}
For an HA setup with Helm, specify the agent and main image as needed.
Check component versions in a running Rancher instance
Ensure the version of the webhook deployed in the local cluster is one you find in the build.yaml. Same for the
fleet agent.
Change the configuration
Change some configuration value in the build.yaml file. For example, change the version of webhookVersion to be
2.0.4+up0.3.4. Then run go generate. This causes all codegen programs to run, which is wasteful. Instead, you can
run just the program in pkg/codegen/buildconfig/main.go. As a result, your Git working area has two changed files:
the build.yaml file itself and pkg/buildconfig/constants.go.
Run the scripts again, tag and push the images. Repeat the previous test and ensure that the webhook deployed in the
local cluster is the one you specified in your configuration update.

As it is closed as completed should it still be in review ?

Moved to Done, thanks for catching this.


prayer_date.py:23: Перенести классы в отдельные файлы 35

The puzzle 899-1fd93ce2 from #899 has to be resolved:
https://github.com/blablatdinov/tg-quranbot/blob/48f45ff9a372007c2e26d4a3545ae82df7f5f392/src/srv/prayers/prayer_date.py#L23-L23
The puzzle was created by Ilaletdinov Almaz on 20-Jun-24.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 899-1fd93ce2 has disappeared from the source code, that's why I closed this issue.


links instead of copies?

Just trying out pyenv.  Looks nice, but it appears to install packages into virtualenv using copies, even though I already have the same packages installed in ~/.local/lib/python3.6/site-packages. I'd prefer links, which I believe is what anaconda does.
Tested on Linux Fedora 27 python 3.6

Pipenv uses virtualenv, and this is what it does. Please file this to pypa/virtualenv instead.


Take rellu into use to ease creating releases

https://github.com/robotframework/rellu

Done in several commits for release 1.5.0


Sprint6 404 error

Nice observation guys. I will be merging this PR since Cedrik updated the code.


Setup component testing (with code coverage)

@henriquehbr -- I was thinking we could use the demo app inside src for cypress testing.
this way, we wouldn't have to mount any components, we could just visit a path in the app (cy.visit(/my-component)) and run the test.
does that make sense?

Yeah, good idea, that would make the code a lot cleaner, i'll work on it

@kindoflew The tests are now being instrumented on the fly, without affecting the hot reloading


Retrieving information from slang module

Hi,
I had a question regarding if it was possible to partially parse a .slang module and get some reflection data, specifically user attributes from some declared types ?
My end goal is to write a rasterizer shader module that can, for example, load vertex data either from an SSBO or from bindful vertex specification. I would like to use specialization constants in conjugation with an abstract interface for the vertex data to resolve the final vertex data. The idea is given a mesh + shader combination, when loading from an StructuredBuffer, the mesh's vertex declaration (vertex buffer slot, stride, data offset, etc) are passed through specialization constant. This makes my engine pipeline very easy to manage.
I can imagine a struct defining vertex data like so:
struct VertexData
{
  [binding("position")
  float3 position;
  [binding("normal")]
  uint normal;
};

[VertexShader]
void processVertex(VertexData data)
{
  // .. transform and write to SV_Position, etc.
}

Given that I want to have one shader for both the bindless and bindful case, I need to generate some code that, depending upon the current engine runtime, will fill the geometry structure.
My idea was to generate the entry point for vertex processing and read the bindings from VertexData struct, generate code inside this entry point to populate the struct and pass it to processVertex, but since this means parsing an incomplete shader, is this possible ? The alternative I have in mind is to do manual parsing of the file for all declarations, but that sort of defeats the purpose of user attributes, and increases the shader parsing cost. Another possibility, that I am currently using with glsl, is to have all declarations defined in a meta-language which I then parse.
Lastly, the idea applies not just to vertex data, but for material data too, I would like to have a way to compile both bindless and bindful path from the same shader.
Thanks for any advice.

The short answer is yes, Slang provides reflection API to query functions, types and attributes declared on these decls.
Unfortuantely we haven't write up documentation on these APIs, but you can take a look at the slang.h header to find the related functions.

Thanks, I will have a look.

Closing this issue assuming the question is answered. If you have any further questions, feel free to open new issues.

Yes, I am able to traverse the tree for a module that I parsed and retrieve all information.


Condition based on context value

Is your feature request related to a problem? Please describe.
There are cases where we need to enable/disable properties based on external information depending on the environment.
One for example doesnt want to create separate element-templates based on the environment where a template should be used but rather provide the element template engine a context that can be used to conditionally enable/disable certain properties and features in a single element-template.
Example: A property that should only be shown if the element-template is applied in a Self-Managed Web-Modeler instance and not in the SaaS environment.
These cases are currently handled using the labels by indicating whether an option is available or not.

Describe the solution you'd like
It would be really handy to be able to pass a context variable into the element-template engine and use this context inside a condition.

Describe alternatives you've considered
The alternative is using a single template and label options and properties that should not be considered in certain cases or to use different element templates for each environment (which leads to a lot of duplication)
Additional context
This feature could also be useful in case of when dealing with sub-processes where the engine requires context whether a single element is part of a subprocess or not.

This could be an interesting addition to element template conditional bindings!

@nikku Another use-case for conditions based on context value is versioning. By having the execution platform version information available in the context, we would be able to enable/disable certain functionality depending on it.

By having the execution platform version information available in the context, we would be able to enable/disable certain functionality depending on it.

What specific feature do you think about, and what would happen during an upgrade from one engine version to another?
The usual way we handle "version conflicts" is through validation / linting.

@nikku The idea was to only offer/support certain properties based on the execution platform.

@nikku The idea was to only offer/support certain properties based on the execution platform.

And what would happen if the platform changed? Would elements magically upgrade? That is a general question we need to ask ourselves if we consider context for the applicability of an element template.

@sbuettner Could you link a connector that ships with the UI presented above?

The AWS Connectors come with the self-managed only property: https://github.com/camunda/connectors/blob/main/connectors/aws/aws-sqs/element-templates/aws-sqs-outbound-connector.json#L54
Regarding the execution platform: We have the case where a newer Slack Connector supports some features that are not present in an older runtime but we have to support both in the web-modeler. Thats where the idea of having access to execution platform information comes from.

Regarding the execution platform: We have the case where a newer Slack Connector supports some features that are not present in an older runtime but we have to support both in the web-modeler. Thats where the idea of having access to execution platform information comes from.

Why not solve the issue using our on board facilities, cf. screenshot below:

Because we want to offer a tailored experience and hide operations that are not supported instead of showing them and requiring the user to (and us) to leverage the problems panel. It can be a single property that is just not available in an older version for example.

Thanks! I think I understood now.
Building your own solution for "version compatibility" of course (rather than plugging into the existing capability). That however will mean that you'll also need to solve everything including upgrading (what happens when the "context" changes) yourself. Also, it will contradict our way of guiding the user, as the UX will be inconsistent.
Moving to backlog for now. Let's see if there is further evidence for contextual application of element templates in the future.

solve everything including upgrading (what happens when the "context" changes)

When a user changes the execution platform in the modeler the context would change and the conditions in the element template would be re-evaluated.

solve everything including upgrading (what happens when the "context" changes)

When a user changes the execution platform in the modeler the context would change and the conditions in the element template would be re-evaluated.

Magically, for all elements I presume, or giving folks a heads-up that updates are being applied to the diagram, with a list of the changes? What happens with existing configuration if I downgrade? The existing flow offers answers for all these questions, whatever we build "our own" in connectors needs to check the boxes, too.
Exactly because we encourage no surprises we go for validation for execution platform compatibility over showing and hiding things (and binding and un-binding of technical properties in the element template case).

In general the changes should be forward compatible and I dont see many use-cases for people downgrading.
In case you downgrade and functionality is not available you would not be able to use the data anyway for options not available.
Beside that a context could be used to provide validations as well in case one doesnt want to use it for hiding/diplay purposes.


[Bug] Do not mark field as an error if a widget property field is empty

Currently the property pane fields are shown as having an error when it is empty.
Expected: Not show empty fields in an error state.

@akash-codemonk in the below-mentioned widgets i am seeing an error when the widget property pane is kept empty:

file picker has an error in the max file size input box when it is kept empty
rating widget has an error in the default rate
chart widget has an error in chart type
In Image widget has an error in object-fit
The rich text editor has an error in the default text
The tab widget has a problem with the default tab

The rich text editor has an error in the default text
Empty field does not seem to show any error for default text

In the image widget when the user keeps "Initial location" empty the error is displayed


[stable/graylog] deprecate graylog chart

Signed-off-by: KongZ<EMAIL_ADDRESS>Is this a new chart
No
What this PR does / why we need it:
This deprecates the Graylog chart and references the new home.
Special notes for your reviewer:
@scottrigby please link this PR to #21103 ?
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @scottrigby

Hi @KongZ, are you interested in preserving the commit history from here to there? Here is a good writeup on how to do that https://torstenwalter.de/helm-chart-hosting/

@scottfrederick thanks for pointing out how to do it. I already preserve the history to my new repo :)

Great 👏 Added an issue I saw https://github.com/KongZ/charts/issues/3 but in general looks good!


Diagnostic and Diagnostics are very similar names

This is breaking change that we should either make before 1.0 leaves beta, or decide not to make.
apollo-compiler 1.0.0-beta.4 exports two types named Diagnostics (plural) and Diagnostic (singular). The former is a collection of any number of the latter, and has a corresponding .iter() method. This is all self-consistent, but because the two names are so close it’s easy to confuse one for the other.
Should one or both of them be renamed to avoid this confusion? To what?

From today’s discussion:

The same pattern exists with Directive v.s. Directives
A List suffix may be a way to fix this: DiagnosticList, DirectiveList


What about deletes?

This document details how to identify adds and updates.  Can you please specify in this document how to learn what rows have been deleted?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6013c7c2-de36-b1e2-b440-c665642b528c
Version Independent ID: b097f7f8-fb1c-3356-998b-373e422ee4af
Content: Read the incremental updates of Dataverse data - Power Apps
Content Source: powerapps-docs/maker/data-platform/azure-synapse-link-incremental.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @sama-zaki
Microsoft Alias: matp

Hi @markgar, let me investigate and see if we can add it. Thanks for the suggestion.


Non-maintainers can't assign reviewers to their PRs

With the recent governance change non-maintainers have lost the ability to assign reviewers to their PRs. I've found this to be unergonomic because now I have to revert to pinging people in comments to get them to review my code.

Would it be helpful to automatically assign reviewers to PRs to resolve this issue? or do you want to be able to assign specific reviewers?

I think auto assigned reviewers is helpful sometimes. But, I can also think of a lot of scenarios where I have a specific person or two in mind and would just want to be able to assign them.
Two questions I think we should ask ourselves:

Is auto assigned reviewers actually going to be helpful or is it just going to be spammy?

Personally I lean towards feeling it is spammy.

What is the risk vector of letting anyone assign reviewers?

The obvious one is people getting spammed with review requests — but, I would posit that Spin isn't a big enough project for that to be a problem. We can always remove this permission in the future.

Perhaps we could have a "contributors" group with triage permissions and add anyone who has made "signficant contributions" to the project? Triage is pretty limited and would only be a problem if applied to someone malicious or spammy.

It appears that you cannot have teams contain members that aren't also org members but we could still maintain a flat list of triagers in the repo.


Add a government schema

In preparation for Whitehall publishing governments to the Publishing API.

This depends on https://github.com/alphagov/content-data-api/pull/1367