Unable to commit anything in the repo due to husky failure

Describe the bug
I cloned the repository and made a few changes in the code. I've installed all the dependencies.
I'm able to stage code changes in git but when I execute git commit, I get the following output:
↓ Skipped because of errors from tasks. [SKIPPED]

other:eslint:write failed without output (ENOENT).
husky > pre-commit hook failed (add --no-verify to bypass)

It seems like lint-staged is unable to find the task other:eslint:write.
To Reproduce
Steps to reproduce the behavior:

Clone the repo.
Install dependencies using npm i
Edit code.
Git Add .
Git commit -m "Some commit message"

Expected behavior
lint-stage is already setup in the project so it should be able to find the tasks mentioned in the config file.

I am able to fix the issue by changing the tasks in lint-stage from
module.exports = {
  'src/**/*.ts': ['other:eslint:write', 'other:prettier:write', 'npx scriptlint', 'git add'],
};

to
module.exports = {
  'src/**/*.ts': ['npm run other:eslint:write', 'npm run other:prettier:write', 'npx scriptlint', 'git add'],
};

I'm working on adding a new feature to the repository, I am unsure if I should commit this change as well.

I am able to fix the issue by changing the tasks in lint-stage from
module.exports = {
  'src/**/*.ts': ['other:eslint:write', 'other:prettier:write', 'npx scriptlint', 'git add'],
};

to
module.exports = {
  'src/**/*.ts': ['npm run other:eslint:write', 'npm run other:prettier:write', 'npx scriptlint', 'git add'],
};

yusufkhan07@f6cacce
I'm working on adding a new feature to the repository, I am unsure if I should commit this change as well.

I saw you commit it. It's fine. Thanks😊


db: Add query review tables and update QueryExecutionStatus enum

Changes

QueryReview table for reviews
QueryExecutionReviewer association table
New QueryExecution enums "PENDING_REVIEW", "REJECTED", for executions in review process
Alembic migration file

Changes:

Removed queryreviewstatus enum
Removed query_author_id from QueryReview table since info already exists within related query execution
Regenerated alembic file


Support for scalar-valued ODE problems

Codecov Report

Merging #57 (e9370f0) into main (2c899b1) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   87.06%   87.22%   +0.15%
==========================================
  Files          21       21
  Lines         866      869       +3
==========================================
+ Hits          754      758       +4
+ Misses        112      111       -1

Impacted Files
Coverage Δ

src/caches.jl
100.00% <100.00%> (ø)

src/integrator_utils.jl
100.00% <100.00%> (ø)

src/perform_step.jl
96.09% <100.00%> (+0.85%)
:arrow_up:

src/state_initialization.jl
97.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c899b1...e9370f0. Read the comment docs.


Question about forwardRef

Hi, I just wanted to know why some components are built with forwardRef? For example, in the button component, I'm having trouble understanding why it's used. Does it have anything to do with the "asChild" props? Or perhaps to do with the use of Slot radix?
I'm going to find out more about this, as I've rarely needed to use the forwardRef.
Thanks.

As I know you can't pass a regular ref instance to custom components as you do to html tags that's why you need to pass forward ref through props as react recommending
Docs https://react.dev/reference/react/forwardRef#forwarding-a-ref-through-multiple-components

Thanks !


Remove deprecated keys in cluster.yaml

Finally remove keys deprecated via #372 #545
More concretely, remove:

externalDNSName in favor of apiEndpoints[].dnsName
createRecordSet in favor of apiEndpoints[].loadBalancer.createRecordSet
recordSetTTL in favor of apiEndpoints[].loadBalancer.recordSetTTL
hostedZoneId in favor of apiEndpoints[].loadBalancer.hostedZone.id
controllerCount in favor of controller.count
controller.loadBalancer in favor of apiEndpoints[].loadBalancer
controllerCreateTimeout in favor of controller.createTimeout
controllerInstanceType in favor of controller.instanceType
controllerRootVolumeSize in favor of controller.rootVolume.size
controllerRootVolumeType in favor of controller.rootVolume.type
controllerRootVolumeIOPS in favor of controller.rootVolume.iops
etcdCount in favor of etcd.count
etcdInstanceType in favor of etcd.instanceType
etcdRootVolumeSize in favor of etcd.rootVolume.size
etcdRootVolumeType in favor of etcd.rootVolume.type
etcdRootVolumeIOPS in favor of etcd.rootVolume.iops
etcdDataVolumeEphemeral in favor of etcd.dataVolume.ephemeral
etcdDataVolumeSize in favor of etcd.dataVolume.size
etcdDataVolumeType in favor of etcd.dataVolume.type
etcdDataVolumeIOPS in favor of etcd.dataVolume.iops
etcdDataVolumeEncrypted in favor of etcd.dataVolume.encrypted
etcdTenancy in favor of etcd.tenancy

cc @redbaron @danielfm @c-knowles @camilb

Although we definitely have been noted about deprecations/removals of externalDNSName, createRecordSet, recordSetTTL, hostedZoneId, controller.loadBalancer in cluster.yaml, I just realized that we had been missing warning messages emitted when they were used.
So, my question is: is everyone aware of deprecations and removals of those 5 keys?

Is the init command linked up correctly to the new host/record set entries? I only ask as I've not tried init in a very long time.

@c-knowles Thanks for the confirmation 👍
Yes, they have been emptied by default since long time ago:
https://github.com/kubernetes-incubator/kube-aws/blob/master/core/controlplane/config/templates/cluster.yaml#L6-L28
and new keys are explicitly filled with values passed via init flags:
https://github.com/kubernetes-incubator/kube-aws/blob/master/core/controlplane/config/templates/cluster.yaml#L43-L70

@mumoshu I'm currently not using any of the deprecated keys.

FYI, just hit this.
kube-aws version: 0.9.9
The docs for kube2iam support reference the deprecated key managedIamRoleName instead of pointing to the new keys for both the controller and workers.

Referencing #698 and the docs inside of cluster.yaml, it's a little unclear what the correct key for changing the IAM role name of a worker node pool is. Here are all the options I see in the docs and in PRs/Issues:

worker.nodePools[].managedIamRoleName (removed in v0.9.9 and now should be removed from the docs)
worker.nodePools[].iam.managedRoleName (mentioned by @c-knowles but no docs given in v0.9.9)
worker.nodePools[].iam.role.name (listed in docs and works)

Thx for catching these all up! iam.role.name shfud be the correct one as
far as I remember, and also as confirmed by you.
Would you mind sending a PR for fixing doc?
2018年3月14日(水) 0:24 Bernhard (Sonny) Köhler<EMAIL_ADDRESS>
Referencing #698
https://github.com/kubernetes-incubator/kube-aws/issues/698 and the
docs inside of cluster.yaml, it's a little unclear what the correct key
for changing the IAM role name of a worker node pool is. Here are all the
options I see in the docs and in PRs/Issues:

worker.nodePools[].managedIamRoleName (removed in v0.9.9 and now
should be removed from the docs)
worker.nodePools[].iam.managedRoleName (mentioned by @c-knowles
https://github.com/c-knowles but no docs given in v0.9.9)
worker.nodePools[].iam.role.name (listed in docs and works)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/kube-aws/issues/753#issuecomment-372704508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABV-RvY5UUy5B61-ePMnu1LNm1DM9XNks5td-SmgaJpZM4OTlu1
.

Sure thing, I'll submit that today.

Just submitted an update for the docs as part of https://github.com/kubernetes-incubator/kube-aws/pull/1285.

We should probably still do this for things that still are, or have been deprecated since this.
/reopen


test: test vite PR 18092

#111  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite


Fix loading of store items

When visiting any store, it would show 0 items because of accessing the wrong model.

You caught a copy-paste error I missed! Good work.


Documentation has never mentioned prettyDuration method

Thank you for this awesome plugin! I am surprised that the documentation has not mentioned the most important method of the plugin!
prettyDuration()
I almost skipped this plugin because of the documentation. Good thing I took a look at the source.

Thanks for the tip. The README is not updated with a note.


renamed NamedQueryRepository to NamedObjectRepository

As per subject

Decided on a PR just to gauge the impact of changing this name in consumers

Thanks guys!

If someone is worried about backward compatibility, you can just leave the NamedQueryRepository interface around, and have NamedObjectRepository extend it. As long as users don't implement NamedQueryRepository (and I don't think they are supposed to?), upgrades will go smoothly.

Yep I have used this frequently in the past.  As you said though, this is an incubating contract - in fact this whole network of objects starting from QueryEngine is new.  So if it won't negatively affect Search or Quarkus then I think its not worth it and I should just do the change as proposed in the PR


iOS alert message globalization

Changed NFCNDEFReaderSession new to NFCNDEFReaderSession alloc
Added globalization for iOS alert message
Updated Readme.md
Fixes #452 #450 #422

@don can we get this merged?

@don is this going to be accepted/merged?


fix misaligned line-break after last pinning upgrade

when calling a basic command such as ./plex -app equibind -input-dir testdata/binding/abl

is:
added QmWmSf3hu78iVaWmDt1EVMGzxMfD6uPq9iPTbca7NVz4T6## Creating Bacalhau Job ##
Bacalhau Job Id: d2c176f6-e854-4ca4-806c-98ea2b5b036a

want
added QmWmSf3hu78iVaWmDt1EVMGzxMfD6uPq9iPTbca7NVz4T6
## Creating Bacalhau Job ##
Bacalhau Job Id: d2c176f6-e854-4ca4-806c-98ea2b5b036a

can be part of #152

done


Update print

Fixes #803
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
Attention: Patch coverage is 41.40625% with 75 lines in your changes missing coverage. Please review.

Project coverage is 87.88%. Comparing base (6fb1fec) to head (e4a4ba7).

Files with missing lines
Patch %
Lines

runtime/src/lib.rs
41.40%
75 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   88.05%   87.88%   -0.18%
==========================================
  Files         122      122
  Lines       34169    34274     +105
==========================================
+ Hits        30087    30120      +33
- Misses       4082     4154      +72

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Download mechanism

How will we handle the downloads? Is it easy to download from the server that is running the application, but the other two?

I think we may let this issue open until the feature be satisfied and close it with a PR or multiples PR. If the feature is already satisfied, plese close again.

I think we may let this issue open until the feature be satisfied and close it with a PR or multiples PR. If the feature is already satisfied, plese close again.


Flaky static analysis

Which jobs are failing:
There is an issue with the quality/static-analysis CI pass.
This pass is an experimental one that we added to infer new information to make our code better via static analysis with cppcheck.
Unfortunately
Which test(s) are failing:
Since when has it been failing:
This seems a flaky one, a re-run and it works usually.
Test link:
https://app.circleci.com/pipelines/github/falcosecurity/falco/1240/workflows/2d5427ce-91fc-4033-85ff-f785db9e0015/jobs/9593
Reason for failure:
I didn't explore further.
Anything else we need to know:
I commented it out in PR #1525 since it's blocking a release and other PRs to get in.
We need to make sure this is not flaky and works as expected before reinstating it.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


ie8 issue SCRIPT445: Object doesn't support this action

Please check this demo
http://thednp.github.io/bootstrap.native/
There seems to be an issue with the event polyfill at this line
eventElement.call(element, event);

I believe this is because there have been some changes to the default IE8 polyfills structure that's causing this issue, because some months ago I didn't have this issue.
Can you please investigate and fix the issue?

Often, these issues turn out to be problems in host site code.  To help us debug this problem, it would be appreciated if you could add a test to our test suite for this polyfill that fails under the conditions you describe.
Failing that, create a page that includes the polyfill service and just enough additional code to demonstrate the problem (ideally not more than a dozen lines of markup and JS)

Well, simple open IE10+, switch to IE8 view and refresh page. But the strange/crazy thing is, that demo works flawless today. Do you have any idea what is causing this (sometimes it works sometimes gets some error)?

Now it's not working again.. very strange!
Here's a page I made for you to play around.
http://thednp.github.io/bootstrap.native/test.html

Most code bins/pens have an output mode that doesn't load the editor UI so that avoids any browser support problems of the app itself.  I'm afraid we aren't going to dig through the minified version of your library but if you can extract the code that triggers the issue I'd be glad to take a look.

Updated the test page, please check again.

I'm afraid I can't reproduce the issue.
Again, I'd suggest reducing the problem.  You have thousands of lines of code in this page that is not coming from the polyfill service, and you're also loading multiple polyfills.  If you can find a problem state that requires only a few lines of code and a single polyfill, we'd be happy to look into that.
Alternatively, others may be willing to offer commercial support if you'd like someone else to do the debugging for you.

After some time to work with, I figured the code, here is the fix:

in the while (++index < length && !event.cancelImmediate) {} loop locate

if (indexOf(list, eventElement) !== -1) {
	console.log(element + '\n' +eventElement + '\n' + (eventElement in element))
	eventElement.call(element, event);
}

replace with

if (indexOf(list, eventElement) !== -1 && typeof eventElement === 'function') {
	console.log(element + '\n' +eventElement + '\n' + (eventElement in element))
	eventElement.call(element, event);
}

This makes sure that's a function, so it doesn't call something that's not a function or not supported.


[fix][broker] Copy proto command fields into final variables in ServerCnx

Motivation
In the PulsarDecoder, we use a single BaseCommand object and overwrite it for each incoming protocol message. As a result, it is not safe to publish any references to a proto command to other threads.
Here is the single BaseCommand:
https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarDecoder.java#L99
Here is the method call that resets the object:
https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-common/src/main/java/org/apache/pulsar/common/protocol/PulsarDecoder.java#L114
Note that the call to parseFrom first calls clear(), which resets all values on the object.
This PR copies relevant values or objects into other variables.
Modifications

Replace command with tcId since the latter is a final variable meant to be published to another thread.
Move logic to copy certain command fields to earlier in method for handleSubscribe
Copy ack object to new CommandAck when there is a broker interceptor. Note that copying this command is likely somewhat costly, so we only do it when there is an interceptor configured.

Verifying this change
This is a trivial change that is already covered by tests.
Documentation

[x] doc-not-needed

This is an internal change.
Matching PR in forked repository
PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/8

Codecov Report

Merging #18987 (886796a) into master (feb3cb4) will decrease coverage by 18.91%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             master   #18987       +/-   ##
=============================================
- Coverage     46.35%   27.43%   -18.92%
+ Complexity     8939     5130     -3809
=============================================
  Files           597      597
  Lines         56858    56856        -2
  Branches       5905     5906        +1
=============================================
- Hits          26357    15599    -10758
- Misses        27616    38965    +11349
+ Partials       2885     2292      -593

Flag
Coverage Δ

unittests
27.43% <50.00%> (-18.92%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Please review

When attempting to cherry-pick this to branch-2.11, I ran into conflicts with https://github.com/apache/pulsar/pull/18193. Looking to see if we need to cherry pick that one first.


update gitignore

Thanks @joprice ! Looks great! Build failures are unrelated to this change, so I'll bring it in now -


Add sudo to Kind base image

When running EKS-A with registry mirror configuration, a couple of systemctl commands need to be run with root permissions, but the Kind node image which act as the node image for the Docker provider doesn't have sudo in it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


numpy.NAN/ INF now converted to '-' in dataframe columns in ExcelPai…

…nter

This PR resolves #468.


JobOptions.LeaveSourceStreamOpen has no effect.

JobOptions.LeaveSourceStreamOpen does not do what it promises. Even when this option is passed to the ResizeJob.Build method, the source stream will be disposed. The following (abbreviated) program demonstrates this:
// using Imazen.LightResize;
// using System.Diagnostics;
// using System.Drawing;
// using System.Drawing.Imaging;
// using System.IO;

using (var sourceStream = new MemoryStream())
{
    using (var bitmap = new Bitmap(10, 10))
    {
        bitmap.Save(sourceStream, ImageFormat.Png);
    }
    var resize = new ResizeJob { Width = 5, Height = 5 };
    var targetStream = new MemoryStream();
    Debug.Assert(sourceStream.CanSeek && sourceStream.CanRead); // this is fine.
    resize.Build(sourceStream, targetStream, JobOptions.LeaveSourceStreamOpen);
    Debug.Assert(sourceStream.CanSeek && sourceStream.CanRead); // this fails!
}

The first assertion (immediately preceding the call to ResizeJob.Build) will succeed. The exact same assertion after the resize fails; it should not.

Thanks for the fix!

I'm glad to help. Thanks for this small but immensely useful library!


Minor problem with convert_to_coco_api in coco_utils.py (ann_id initialization)

Hi,
I think ann_id should be initialized to 1, not 0, in convert_to_coco_api:
https://github.com/pytorch/vision/blob/f052c53f512d7076f5415faa0ae65981d355eb90/references/detection/coco_utils.py#L148
That's because pycocotools assumes IDs are greater than 1 when evaluating. More precisely it creates a list of matches per detection box, and uses IDs as entries in that list:
https://github.com/cocodataset/cocoapi/blob/636becdc73d54283b3aac6d4ec363cffbb6f9b20/PythonAPI/pycocotools/cocoeval.py#L295
It then uses that list as boolean values, hence ID '0' is interpreted as a negative.
https://github.com/cocodataset/cocoapi/blob/636becdc73d54283b3aac6d4ec363cffbb6f9b20/PythonAPI/pycocotools/cocoeval.py#L375
Also, as a separate argument, all ann['id'] values are initialized starting from 1 in their initialization code, e.g.
https://github.com/cocodataset/cocoapi/blob/636becdc73d54283b3aac6d4ec363cffbb6f9b20/PythonAPI/pycocotools/coco.py#L322
The consequence is almost negligible for a large dataset (you may have one more false negative) but for unit tests or for very small datasets (as our own use case) it can matter.

Looking into this a bit more, I realized loadRes() is later called and changes those IDs. I'm not quite sure how it turned out the IDs still started at 0 in our case (since we also were calling loadRes through update), but I'll close the issue for now and reopen it / open another one if I can produce a piece of code that gives an actual error (without our full codebase).
Sorry for the false alert.

Here's a very minimal script that illustrates the behavior on a one-image one-box mock dataset, mimicking what happens in detection/engine.py:
import torch
from torchvision_references.detection.coco_utils import convert_to_coco_api
from torchvision_references.detection.coco_eval import CocoEvaluator

# create dataset with a single image
im1 = torch.rand(3,600,600)
boxes1 = torch.tensor([[5.,5.,100.,100.]])
labels1 = torch.tensor([1234])
img_id1 = 987

# mock ground truth bbox
gt1 = {"boxes": boxes1.clone(),
       "labels": labels1.clone(),
       "area": torch.tensor([(100.-5.)*(100.-5.)]),
       "image_id": torch.tensor(img_id1),
       "iscrowd": torch.tensor([0])}

# mock model output with exact same box
detections1 = {"boxes": boxes1.clone(),
              "labels": labels1.clone(),
              "scores": torch.tensor([0.99])}

detections = {img_id1: detections1}

ground_truth_dataset = [(im1, gt1)]
coco_gt = convert_to_coco_api(ground_truth_dataset)

coco_eval = CocoEvaluator(coco_gt, iou_types=["bbox"])

coco_eval.update(detections)

coco_eval.synchronize_between_processes()

coco_eval.accumulate()
coco_eval.summarize()

I ran this with torchvision 0.4.0. The torchvision reference scripts are made importable by adding __init__.py files in the relevant directories.
If I run this with initialization ann_id = 0 in convert_to_coco_api, I get the following output:
creating index...
index created!
Accumulating evaluation results...
DONE (t=0.00s).
IoU metric: bbox
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 0.000
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = -1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 0.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = -1.000

And if I run it with other initializations, e.g. ann_id = 1 or ann_id = 123, I get this:
creating index...
index created!
Accumulating evaluation results...
DONE (t=0.01s).
IoU metric: bbox
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 1.000
 Average Precision  (AP) @[ IoU=0.50      | area=   all | maxDets=100 ] = 1.000
 Average Precision  (AP) @[ IoU=0.75      | area=   all | maxDets=100 ] = 1.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 1.000
 Average Precision  (AP) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = -1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=  1 ] = 1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets= 10 ] = 1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=   all | maxDets=100 ] = 1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= small | maxDets=100 ] = -1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area=medium | maxDets=100 ] = 1.000
 Average Recall     (AR) @[ IoU=0.50:0.95 | area= large | maxDets=100 ] = -1.000

If I put a breakpoint after line 295 in cocoeval.py of pycocoutils (tps = np.logical_and(               dtm,  np.logical_not(dtIg) )) the I get the following matrix with initialization ann_id = 123:
(Pdb) tps
array([[ True],
       [ True],
       [ True],
       [ True],
       [ True],
       [ True],
       [ True],
       [ True],
       [ True],
       [ True]])

but I get this with initialization ann_id = 0:
(Pdb) tps
array([[False],
       [False],
       [False],
       [False],
       [False],
       [False],
       [False],
       [False],
       [False],
       [False]])

About my second message: I think ID assignemtn in loadRes is applied to detections, not ground truth, so it's not relevant after all.
I believe the problem only concerns the very first box, so it's very minor for most use cases, as I said. Still, the fix is simple.

Hi,
Thanks for the bug report and nice catch!
There has recently been a discussion about this in https://github.com/cocodataset/cocoapi/pull/332. I think we should fix it in torchvision by making ann_id start with 1 as you proposed, but we should keep in mind that this behavior might be changed in a future version of pycocotools.
Can you send a PR fixing it?

Sure, here you go:
https://github.com/pytorch/vision/pull/1531
I haven't run the test suite myself but I think it's being done automatically through circleci.
The issue you linked to concerns cocoapi itself. For sure it would be best if they avoided interpreting IDs as booleans, but until they do I think the fix is simple enough.
Thanks for the prompt follow-up!

Fixed via https://github.com/pytorch/vision/pull/1531


DO NOT MERGE - Add CL_0009049 'B cell of anorectum'

Addresses #1116

CL editors:
Similar to what @lubianat observed recently, there's a huge number of "^^xsd:string" added that make reviewing a pull request a daunting prospect. What happened that made the number of those additions explode, and how can we fix it please? (Mock-editing cl-base works, but only temporarily.)
Thanks,
Paola

It seems to be an OWL-API bug and it happens randomly, usually hitting just a few terms, but occasionally blowing up to the point where there are hundreds and the PR becomes very hard to review.
There's a ticket on this, but I'm not sure there's any progress.  @matentzn - maybe we should push on this again?

Found the Protege ticket I submitted on this: https://github.com/protegeproject/protege/issues/993.
All discussion seems to be on Slack:
https://obo-communitygroup.slack.com/archives/C01BFAZPQ86/p1603183433006700 (fortunately not lost down the memory hole yet) - the idea that this might be an OWL-API bug is discussed in this thread.  @matentzn - any idea how best to proceed?

I have reached out to Ignazio and Matthew to see whether they have an idea. It's so annoying we can't replicate it this reliably.. in any case, solving this will take ages, because even if solved in OWLAPI, it needs new robot and protege release to permeate through. One idea: can you check wether an import adds a range constraints on the ap that is blowing up? I am on lunch  break now but will investigate more later.
If nothing works, we will start having ontobot post diffs on new pull request; or revert to obo as the base serialisation - ahhhhhhh!

Thanks @dosumis . I'm concerned that the "occasional" explosive occurrence seems to have become the norm in the last week or so.
If the bug is with Protege, it may not be fixed and released quickly enough. Should we think of a workaround based on Tiago's diagnosis that
"Protege seems to have added automatically ^^xsd:string to all existing oboInOwl:hasDbXref "GOC:tfm""
maybe replace GOC:tfm with Terry's ORCID?
As you say the bug seems random and as far as I know we've never seen it co-occur with anything other than GOC:tfm...

If it's any help: searching for "GOC:" in CL in Protege,
a) GOC:tfm is not the only GOC dbxref
b) the xsd:string thing is appended to many, but not all, terms that have a GOC: dbxref, and this is irregardless of ontology space (GO, CL, ...).
Can't find a pattern as to why only some of Terry's terms are affected.

This happens sometimes in other ontologies too (e.g. in EFO).
It happens at some level in almost every PR - so shouldn't be too hard to replicate.
I've only ever seen it happen to database_cross_reference axioms when used to annotate an annotation axioms (e.g. a definition), but I suspect it is a general bug hitting annotations on annotation axioms (or maybe annotations on any axiom) and we're just seeing it hit these because they are by far the most common.  There seem to be some serious issues with the spec for this (see Ignazio's rant here: https://github.com/owlcs/owlapi/issues/874#issuecomment-525905187).
There is no sign of range constraints on database_cross_reference in CL, so I think that's a red herring.

If nothing works, we will start having ontobot post diffs on new pull request

I like this idea

Ready for review. There were indeed spurious diffs on master, chasing down the culprit now.

[ ] @dosumis to review

@matentzn I'll close and re-do, this was mostly just a test for the xsd:string issue, hence the "do not merge". Thanks again.


[XPU][GEN] Drop barrier operation

Drop TritonGEN barrier operation replacing its uses with equivalent spirv.OpControlBarrier operations. Note the GLOBAL memory semantics specified by the original operation correspond to
SequentiallyConsistent | CrossWorkgroupMemory in SPIR-V, as SequentiallyConsistent is implied.
Closes #2431

Are there performance degradations in Triton microbenchmarks ? Can you do a performance run to make sure ?

Are there performance degradations in Triton microbenchmarks ? Can you do a performance run to make sure ?

Checking just in case, but codegen should be exactly the same regardless of the SPIR-V builtin or OCL function format.

Checking just in case, but codegen should be exactly the same regardless of the SPIR-V builtin or OCL function format. https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11800902213

No performance diff


Accessing Screenshots album

I am trying to access system 'Screenshot' album (ios 10.3.3.) with the the RNPhotosFramework.getAlbumsByTitle(). It seams I can only acess albums under 'My Albums' heading. How can I acess 'Screenshots'?

Sorry its all in the docs.


Flutter 3.27.0 issue with Android Impeller in release mode on MI 9 with Adreno (TM) 640

Steps to reproduce
Run any Flutter app on Xiaomi MI 9 with Adreno (TM) 640, Android 10 and you will see performance issues and stuttering.
I believe that this is the same issue like here:
https://github.com/flutter/engine/pull/57069
https://github.com/flutter/flutter/issues/155185
https://github.com/flutter/flutter/issues/159834
Expected results
Any app to work correctly with Flutter 3.27.0 on this device
Actual results
Application has performance issues and stuttering
Code sample
Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
I/flutter (20615): [IMPORTANT:flutter/shell/platform/android/android_context_vk_impeller.cc(57)] Using the Impeller rendering backend (Vulkan with Validation Layers).
E/flutter (20615): [ERROR:flutter/impeller/renderer/backend/vulkan/pipeline_cache_vk.cc(88)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create graphics pipeline: Incomplete
E/flutter (20615): [ERROR:flutter/impeller/renderer/backend/vulkan/pipeline_vk.cc(433)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create graphics pipeline: PorterDuffBlend Pipeline

I/AdrenoVK(20615): QUALCOMM build          : e0436c5, Ib165d46056
I/AdrenoVK(20615): Build Date              : 09/10/19
I/AdrenoVK(20615): Shader Compiler Version : EV<IP_ADDRESS>
I/AdrenoVK(20615): Local Branch            :
I/AdrenoVK(20615): Remote Branch           : quic/gfx-adreno.lnx.1.0.r74-rel
I/AdrenoVK(20615): Remote Branch           : NONE
I/AdrenoVK(20615): Reconstruct Branch      : NOTHING
I/AdrenoVK(20615): Build Config            : S P 8.0.11 AArch64
I/FLTFireBGExecutor(20615): Creating background FlutterEngine instance, with args: [--start-paused, --enable-vulkan-validation, --enable-dart-profiling]
I/AdrenoVK(20615): QUALCOMM build          : e0436c5, Ib165d46056
I/AdrenoVK(20615): Build Date              : 09/10/19
I/AdrenoVK(20615): Shader Compiler Version : EV<IP_ADDRESS>
I/AdrenoVK(20615): Local Branch            :
I/AdrenoVK(20615): Remote Branch           : quic/gfx-adreno.lnx.1.0.r74-rel
I/AdrenoVK(20615): Remote Branch           : NONE
I/AdrenoVK(20615): Reconstruct Branch      : NOTHING
I/AdrenoVK(20615): Build Config            : S P 8.0.11 AArch64
I/flutter (20615): [IMPORTANT:flutter/shell/platform/android/android_context_vk_impeller.cc(60)] Using the Impeller rendering backend (Vulkan).
I/AdrenoVK(20615): Failed to link shaders.
E/flutter (20615): [ERROR:flutter/impeller/renderer/backend/vulkan/pipeline_cache_vk.cc(88)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create graphics pipeline: Incomplete
E/flutter (20615): [ERROR:flutter/impeller/renderer/backend/vulkan/pipeline_vk.cc(433)] Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create graphics pipeline: PorterDuffBlend Pipeline

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.27.0, on macOS 14.6 23G80 darwin-arm64, locale en-GB)
    ! Warning: `flutter` on your path resolves to /Users/kduvnjak/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/kduvnjak/fvm/versions/3.27.0. Consider adding
      /Users/kduvnjak/fvm/versions/3.27.0/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/3.3.4/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/kduvnjak/fvm/versions/3.27.0. Consider
      adding /Users/kduvnjak/fvm/versions/3.27.0/bin to the front of your path.
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2024.2.3)
[✓] Connected device (5 available)
[✓] Network resources```

</details>

We'd previously disabled some older adrenos because of this problem:

Break on 'ImpellerValidationBreak' to inspect point of failure: Could not create graphics pipeline: Incomplete

This is not a valid error according to the vulkan specification. Having said that, I don't want to keep disabling these phones so next week I'll plan on seeing if I can get it to successfully compile on one of these devices.


oninput event

Please add oninput event for data-life-search input field, or add id to input field

Please 👍 and follow #1305.


Revert "Merge release/dev17.5 to release/dev17.6"

Reverts dotnet/razor#8437
Necessary changes are already in release/17.6, and this also fails the compile because there are now duplicate instances of methods.

How on earth did the merge PR build???

The answer is, of course, it didn't. https://github.com/dotnet/razor/runs/12059961040
Must be a timing bug with the auto-merge bot I guess? Will start a thread on the InfraSwat channel


Create Plugin: Update scenes to latest version

This updates scenes template to use latest API.

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

One thing I wondered about is there's no changes here to the height css declarations in Home.tsx as per examples PR . Anything to worry about? Does latest scenes cater for them?

That's a small difference between the template here and in the examples repo - good catch!. I'll update soon.


Update tax rates and om pt 1

Description

Sets insurance rates to 0 for wind plants
Updates tax rates that were 0
Sets federal tax rate for all residential systems to 15%

@cpaulgilman I just noticed a number of configurations (mostly behind the meter battery configs) have a 0% sales tax rate based on a commit you did in Feb 2020 (https://github.com/NREL/SAM/commit/6e7c3ae42da814873f51e2cf08968d977bcc1cab) was that intentional? Most of the cost models list a sales tax term.

Looks good to me now.


Moving encrypted PGP/MIME messages to different IMAP folder in Outlook corrupts message

When moving an encrypted or encrypted and signed PGP/MIME  message to a different IMAP folders, the message is corrupted afterward and other mail applications fail to open the encrypted message:
Outlook 2013 + Plugin Build 5627
Original message content: loret ipsum
Thunderbird 31.7.0 on GNU/Linux:
Can decrypt but additional text is shown:
Content-Type: multipart/mixed; boundary="hXk1bveRgEMgMlBMrskGTqh8OwmnlAF72"
--hXk1bveRgEMgMlBMrskGTqh8OwmnlAF72
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
loret ipsum
--hXk1bveRgEMgMlBMrskGTqh8OwmnlAF72--
Thunderbird 38.0.1 on Windows
No text shown, only attachments provided:

PGP_MIME version identification.dat
encrypted.asc

Evolution 3.16 on GNU/Linux
No text shown, only attachments provided:

unknown attachment (PGP_MIME version identification.dat)
PGP/MIME-encrypted message header attachment (encrypted.asc)

Claws 3.11.1
Show following message content:
X-Mailer: Microsoft Outlook 15.0
[PGP_MIME version identification.dat  application/pgp-encrypted (11 bytes)]
[encrypted.asc  application/octet-stream (1119 bytes)]

This seems like a duplicate of #88.  Again, I don't think this is related at all to this plugin, I'm guessing this is an outlook issue. Could you please try it with OPP disabled to verify?

I've reproduced this in my test environment with OPP disabled. This appears to be an outlook related issue and not something occurring due to OPP.

THX for your efforts!


Adjust roles according to the official docs

According to the official documentation (https://www.iobroker.net/#en/documentation/dev/stateroles.md) some roles needs to be changed.

Thanks!


freshness review

Learn Build status updates of commit dd9d90a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed]

Cannot sync git repo to specified commit because ref +refs/pull/100962/merge has been deleted or has been force pushed.
 If this is pull request, please ensure it is mergeable (no merge conflict) and open (not closed).

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Adding S gate to built in gates

As a user-experience note, it seems a bit confusing how to add the gate definition to the conversion packages. It took me awhile to figure out how it was working in pyquil since there's no explicit mapping.
I also noticed that after I added the definition, but before I modified the conversions nothing failed. I'm wondering if that's because the conversions were "smart" enough to handle it (or perhaps create a custom gate) or if it just wasn't being tested? It would be good to have clarification on this @dexter2206 @alexjuda

As a user-experience note, it seems a bit confusing how to add the gate definition to the conversion packages. It took me awhile to figure out how it was working in pyquil since there's no explicit mapping.

Do you have any ideas besides including a chapter this topic in the documentation? At the moment we don't have separate docs, so my idea was to include it as a module docstring. Do you think that would be helpful?

I also noticed that after I added the definition, but before I modified the conversions nothing failed. I'm wondering if that's because the conversions were "smart" enough to handle it (or perhaps create a custom gate) or if it just wasn't being tested? It would be good to have clarification on this @dexter2206 @alexjuda

This probably should be stated more explicitly somewhere, but I think this is exactly what happened – pyquil_conversions module is smart enough to assume that ZQuantum and PyQuil have very similar set of built-in gates, so it defaults to get the correspoding gate just by the input one's name.

Do you have any ideas besides including a chapter this topic in the documentation? At the moment we don't have separate docs, so my idea was to include it as a module docstring. Do you think that would be helpful?

I think a module docstring would be appropriate that way for each conversion library, it's clear what to do to make it accessible.

This probably should be stated more explicitly somewhere, but I think this is exactly what happened – pyquil_conversions module is smart enough to assume that ZQuantum and PyQuil have very similar set of built-in gates, so it defaults to get the correspoding gate just by the input one's name.

That was my hunch, but it was also the case for cirq and qiskit too as I hadn't modified them either. I think it would also be good to clarify (for each module, probably in the module docstring again) whether the converter is smart enough to assign the gate to the proper native-gate without explicitly declaring it (ie. zquantum S gate would be converted to qiskit S gate) or whether it's building a custom gate if it isn't defined (ie. zquantum S gate gets converted to custom qiskit gate).

Added as a comment under the story for new circuits API docs.


[AVCe] VA may return multiple values in VAConfigAttribEncSliceStructure

Previously combined values were mapped to 0.
Issue: MDP-61999

Multiple values are set by the driver since media_libva_caps: add VAConfigAttribEncSliceStructure caps for VAEntrypointEncSliceLP.

@Alexandr-Konovalov , can you please check what slice_structure value UMD previously returned in caps?

can you please check what slice_structure value UMD previously returned in caps?

@dmitryermilov , Do you mean VAConfigAttribEncSliceStructure value? It was  VA_ENC_SLICE_STRUCTURE_EQUAL_ROWS | VA_ENC_SLICE_STRUCTURE_MAX_SLICE_SIZE, and VA_ENC_SLICE_STRUCTURE_MAX_SLICE_SIZE is masked out my MediaSDK. See media_libva_caps: add VAConfigAttribEncSliceStructure caps for VAEntrypointEncSliceLP.

and VA_ENC_SLICE_STRUCTURE_MAX_SLICE_SIZE is masked out my MediaSDK

Here https://github.com/Intel-Media-SDK/MediaSDK/blob/ce37d6c41f763b9a913ef3d83528c3e9cd774b51/_studio/mfx_lib/shared/src/mfx_h264_encode_vaapi.cpp#L1573

Close, as the issue was resolved via Revert "media_libva_caps: add VAConfigAttribEncSliceStructure caps for.


WIP Backport: Upgrade system charts

Backport: https://github.com/rancher/rancher/pull/20181
Backport Issue: https://github.com/rancher/rancher/issues/20270

@rmweir please add the drone fixes to this pr as well

LGTM


Please be aware travis-ci.org will be shutting down in several weeks

Please be aware travis-ci.org will be shutting down in several weeks, with all accounts migrating to travis-ci.com. Please stay tuned here for more information.

Other projects on GitHub are migrating to Docker.
See for example: https://github.com/pandoc/lua-filters/blob/master/.tools/Dockerfile

Thanks for the comment; because of it, I have been investigating our options.  We are already migrating to travis-ci.com, and the imminent 3.1.3 release will be a test of whether that has worked for us.


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

onfigure Azure Pipelines
This pipeline configuration builds the application and produces a build for the Release configuration.


Menu inside Overlay closes overlay on menu item hover

🐛 Bug Report
If useInteractionModality() is used and current pointerType is pointer then MenuItem automatically receives a focus on hover which closes the Popover.
🤔 Expected Behavior
Popover should stay open.
😯 Current Behavior
If useInteractionModality() is used the menu item automatically receives a focus on hover on which popover and menu closes. If useInteractionModality() is not used, then everything works as expected. (useInteractionModality() is necessary for Tooltips to work)
https://codesandbox.io/s/hopeful-herschel-0shii?file=/src/App.js
💁 Possible Solution
MenuItem should not receive a focus on hover.
🔦 Context
We have a menu inside a dialog that is used to choose a value. With this bug we are not able to select anything inside the menu, because it causes the dialog to close (shouldCloseOnInteractOutside() is called but there should not be any interaction on hover). This happens only if useInteractionModality() is called. But we can't remove useInteractionModality() otherwise our tooltips don't work.
💻 Code Sample
https://codesandbox.io/s/hopeful-herschel-0shii?file=/src/App.js
🌍 Your Environment

Software
Version(s)

react-spectrum
see codesandbox

Browser
Safari 14.0.3

Operating System
macOS Big Sur

I don't think there's an issue with useInteractionModality, I think you just are missing a couple things in your code.
I've edited your codesandbox to match our documentation a bit more https://codesandbox.io/s/thirsty-snow-oikxf?file=/src/App.js and I don't see the issue anymore.
For reference, this was the example from our documentation that I referenced https://react-spectrum.adobe.com/react-aria/useOverlayTrigger.html#example
Note, there's still more missing because if you try to select a Menu item, it'll blow up. You can find Menu docs here https://react-spectrum.adobe.com/react-aria/useMenu.html

Yes you are right, I had shouldCloseOnBlur: true set on our Popover component.


Directly use miniz_oxide

In Debian we're patching away usage of miniz and miniz_oxide because it's simpler to just use the system zlib. The "rust_backend" feature actually just points to zlib.
If flate2/rust_backend uses miniz_oxide directly (rather than through miniz_oxide_c_api) then it would be easier to have a "real" rust_backend actually in Debian.

Yeah that would be preferable. Using it via the c api wrapper was mainly to make it easy to add support for it while keeping support for the c backends. Using it directly required some larger changes to flate2. The C Api is a bit iffy and has a fair bit of unsafe in it due it being a C API

I've started working on this now, after removing all unsafe usage in the miniz_oxide core crate.


Liquidator fee is not sent

Description:
The execute_liquidation function from liquidation_queue contract sends the liquidator_fee when its value is zero, instead of sending it when its value is different to zero.
Code Location:
krp-market-contracts/liquidation_queue/src/bid.rs#L412-L423

fixed in commits id:
https://github.com/KryptoniteDAO/krp-market-contracts/pull/13/commits/d00ba8d6e35a43d175f892fa8b825355ac2e9d6b


Improvements to viewer

Per the 1/7/22 meeting:

Add banner with legend for realization column (and others if needed)
Make table column headers sticky

This issue involves looking into the viewer code and seeing what CSS framework is used (if any), and how the HTML is structured. If it is simple, might be able to add a CSS attribute to make the table column headers stick as the user scrolls.

Hey Tom, thanks for creating this issue. The viewer to show all CMIP results was generated by a separate script Chris developed. It is currently not included in e3sm_diags code base. I will include those scripts so that you could help enhance.

Hey @tomvothecoder, the steps to generate the viewer is as follows (note you would need jinja2 in your Python env):
cd /var/www/acme/acme-diags/e3sm_diags_for_cmip
python generate_page.py

Let me know if there is permission issue with the data. Thanks!

Closing this issue since we're moving away from CDP Output Viewer (#628).


DefaultTo* structs derive Clone, Debug, etc.

When using either DefaultToHost or DefaultToUnknown structs (which are named tuples with Default implementations), the developer loses the benefits of being able to use them in Clone, Debug, PartialEq, Eq, and Hash contexts.
This commit adds the #[derive] macros to these structs to retain these traits from Triple.

Thanks!


Searchbar overlapping  with Navbar in mobile screen with width <= 375px

Describe the bug
Searchbar is getting overlapped with Navbar. So because of this mobile navigation became unavailable
Expected Behaviour:
To have Navbar and Searchbar separately

Actual Behaviour:
Navbar is overlapped by Searchbar

Reproduction
https://arclix.github.io/arclix-docs
Steps to reproduce

Go the responsive view of the website and set the width as 375px in desktop
Or view in mobile screen

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Arclix issue and not a React specific issue.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] Please follow minimal reproducible example of the bug.

[ Triaged ] Good to start developing


Can not get it working

Work on implementing this last couple of hours. Trying to get it to work with latest version of typehead.js. When I start typing nothing happens. No error..
http://jsfiddle.net/sisir/r9mv4et3/1/

It doesn't work. I have the same conditions.


PR Test2

test

[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

:memo: Version: 1.20180820. Thank you for submitting PR #352. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://invain.mooo.com/.

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://invain.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/201810251433580.76376509666443-352-2db0b710843e65eeb801ab8bef38eb6e39ff4735/report/misspelling_result.txt.

:octocat: cibot: @joonhee-jang, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnsuite/TAOS-CI/wiki/.


Missing import for Time types when query_parameter_limit > 0 and wrong null Time type for pgx/v5

Version
1.21.0
What happened?
When query_parameter_limit > 0 and emit_pointers_for_null_types is set to true sqlc generates parameter type of DB engine specific time type instead of *time.Time:
pgx/v5: func (q *Queries) UpdateLoginTime(ctx context.Context, uid uuid.UUID, lastLogin pgtype.Timestamptz) (User, error) {
I expect type for lastLogin to be *time.Time.
Database schema
CREATE TABLE IF NOT EXISTS users
(
    id SERIAL PRIMARY KEY,
    first_login timestamp with time zone,
    last_login timestamp with time zone
);

SQL queries
-- name: UpdateLoginTime :one
UPDATE users
  SET first_login = CASE WHEN first_login IS NULL THEN $2 END,
  last_login = $2
WHERE uid = $1
RETURNING *;

Configuration
version: "2"
sql:
- engine: "postgresql"
  queries: "storage"
  schema: "storage/migrations"
  gen:
    go:
      sql_package: "pgx/v5"
      package: "db"
      out: "db"
      emit_json_tags: true
      emit_pointers_for_null_types: true
      json_tags_case_style: camel
      query_parameter_limit: 5
      overrides:
      - db_type: "uuid"
        go_type: "github.com/gofrs/uuid.UUID"
      - go_struct_tag: "json:\"-\""
        column: "*.password"

Playground URL
No response
What operating system are you using?
macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

Same as https://github.com/sqlc-dev/sqlc/issues/2459
This issue will be resolved at https://github.com/sqlc-dev/sqlc/pull/2597.

Oh, I'm sorry, I've tried to find existing issue for that but I couldn't. Is it also going to address problem with incorrect pgtype.Timestamptz instead of *time.Time for emit_pointers_for_null_types: true?

Same as #2459
This issue will be resolved at #2597.

I've edited the description to remove issue fixed in the 1.21.0 release and kept the one that still exists.

I don't think query_parameter_limit is related, as I see the same behavior with it set to 0.
I also don't think the value of emit_pointers_for_null_types has any effect on how sqlc determines input parameter types, but I might be wrong about that. And arguably it should I suppose. That could be raised as a new enhancement issue.
I think you can get the behavior you want with an override though. See the playground link below. Note that for the example to work I had to define column types as timestamptz because sqlc apparently doesn't recognize timestamp with time zone as type timestamptz when considering overrides.
https://play.sqlc.dev/p/46304e09afdea98104a6b7c2e4ec0aae63cfb17104714e3fceda8a4fa1e0c457

Just for reference, here is all types that has SQLDriverPGXV5 logic preceding (thus overriding) emit_pointers_for_null_types one:

date
pg_catalog.time
pg_catalog.timestamp
pg_catalog.timestamptz
timestamptz
uuid
interval
pg_catalog.interval


Update servers docs from RC1 to RTM

@Tratcher @rachelappel

This should also address #1348

@halter73
c# 6 won't lex, use none in lieu of c#
154/home/travis/build/aspnet/Docs/aspnet/fundamentals/servers.rst:110: WARNING: Could not lex literal_block as "c#". Highlighting skipped.

@halter73 let me know if you need any help with this.

:shipit:

@halter73  can I merge this now?

@halter73 do you want to put your name on this as co-author?

@Rick-Anderson I squashed/rebased and updated the authors. I think it's good to go. I can push to dev if you want.


Create bulk download page

Create a page for bulk download: to be able to download individually each graph in any format (with content negotiation)
HTML href cannot provide request header for content negociation, so we will need to use FileSaver if we want to provide download in format other than rdf/xml
Get the whole ncats-red-kg in nquads:
wget "http://graphdb.dumontierlab.com/repositories/ncats-red-kg/statements" --header  "Accept: text/x-nquads"

# Download just a specified graph
wget "http://graphdb.dumontierlab.com/repositories/ncats-red-kg/statements?context=<https://w3id.org/data2services/graph/biolink/huri>" --header  "Accept: text/x-nquads"

Download links are available for all pages (to download each graph on the datasets overview page, on each details datasets pages, and for describe pages)
All links link to RDF/XML format as we cannot provide request headers (Accept) through HTML href
To download the whole triplestore in nquads a wget command to execute is proposed
Proposing download button with format choice requires additional developments (using saveAs and Blob, but then the download go through the JS application, which is not what we want)


Adding @Inject to a resource method parameter causes the method to be invoked even if it does not match the request path or HTTP method

Environment Details

Helidon Version: 4.0.1
Helidon SE or Helidon MP MP
JDK version:
OS:
Docker version (if applicable):

Problem Description
Using @Inject on a resource class method causes that method to be invoked at least once on every request routed to the resource class, whether or not the method's @Path setting or  HTTP method annotation (@GET, @HEAD, etc.) matches the incoming request.
If the @Injected method declares a@ConfigProperty parameter then the method is invoked one extra time, but if it has no parameters at all the method is invoked two extra times.
I found this when trying to @Inject a config property into a resource method as a parameter. I do not have results for trying to inject other sorts of things.
Workaround: Inject into the constructor of the resource class instead of the individual methods and save the values as instance fields which the methods can refer to.
Steps to reproduce

helidon init for an MP QuickStart app. Take all the other defaults.

Add the code below to the GreetResource class.

Build the app normally (mvn clean package) then run it using app_note="My Note" java -jar target/quickstart-mp.jar

curl http://localhost:8080/greet.
The server output shows incorrect invocations of the @Injected methods with head() invoked twice.
Invoked head with no injected parameter
Invoked other with value My Note
Invoked note with value My Note
Invoked head with no injected parameter

curl http://localhost:8080/greet/note which should respond with the value of the app.note config property. Instead the response is empty. The server output this time shows the same incorrect method calls as before except this time there are two invocations of note. The second one does not see the injected config property value and so prints an empty string and puts an empty string in the response:
Invoked head with no injected parameter
Invoked other with value My Note
Invoked note with value My Note
Invoked head with no injected parameter
Invoked note with value

Here is the Java code to add to GreetResource to illustrate this problem:
    @GET
    @Path("/note")
    @Produces(MediaType.TEXT_PLAIN)
    @Inject
    public String note(@ConfigProperty(name = "app.note", defaultValue = "noNote") String note) {
        System.err.println("Invoked note with value " + note);
        return note;
    }

    @GET
    @Path("/other")
    @Produces(MediaType.TEXT_PLAIN)
    @Inject
    public String other(@ConfigProperty(name = "app.note", defaultValue = "noNote") String note) {
        System.err.println("Invoked other with value " + note);
        return note;
    }

    @HEAD
    @Path("/head")
    @Inject
    public String head() {
        System.err.println("Invoked head that does not declare a parameter");
        return "Done";
    }

(Not up to speed on any of the root causes, context, deeper issues, etc. but wanted to add this in case it is helpful.)
In any CDI application, if you put @Inject on a method, it becomes an initializer method with corresponding rules about its invocation by the CDI container. When you mix this with JAX-RS, it can be surprising for sure.

That could well explain what I'm seeing.
So maybe this is simply pilot error on my part in misusing/not understanding the implications of @Inject on methods. (I guess I'm used to seeing other annotations explicitly flagging init methods, like @PostConstruct).
I'll go back to my example and make sure that doing the @Inject on the constructor instead (and only there) works and, if so, I'll probably close this as PEBCAK.

This was definitely due to me misusing @Inject on the resource methods.
The GreetService constructor already has @Inject. I added a @ConfigProperty parameter to the constructor, saved the value in an instance field, and then changed the resource methods to use that and all is well.

Right; I mean the flow will be:

{waves hands vaguely} a request comes into the JAX-RS implementation
Jersey realizes a given resource has to be instantiated and delegates to the DI system in effect for that instantiation (the DI system is CDI in this case, not, say, HK2)
CDI takes over the instantiation and follows its rules. One of those rules is to run initializer methods immediately after invoking the constructor.
The resource class is now instantiated and Jersey resumes control and figures out what resource method to invoke, etc. etc.

Yes, that's all consistent with what I saw. The initial invocations of the methods with @Inject--as part of constructing the object--did see the correctly-injected config property. The later calls, responding to a request, did not. That matches up with your description, as does why it works to do the injection in the annotated constructor and store the values in instance fields.


BUG: GH11616 fixes timezone selection error

closes #11616
closes #11682

pls add a note in 0.18.0 bug fixes as well.

pls add a test for #11682 which I believe this should fix as well

These errors are occurring for different reasons. First error #11616 is in _possibly_downcast_to_dtype. It is not able to retrieve correct date from int64 object. hence throwing an exception that I have fixed by checking for timezone info and then converting to correct timezone.
#11682 is in _infer_dtype_from_scalar function as correctly pointed out by ajenkins-cargometrics . We are checking for 'tz' attribute . I have fixed that by replacing 'tzinfo' and added test case for that.
Please review.

looks good. pls add 2 entries in bug fixes in whatsnew for 0.18.0

Done. Please review.

@jreback  One of the five Build job is failing . I am not able to figure out the reason . Please help.

merged via https://github.com/pydata/pandas/commit/e8382665d12dcf270f587cf76cd0e6d5a1dac184
thanks!


Geocode should not return a nil location and a nil error

I just checked the openstreetmap response parser, and when the returned longitude and latitude are empty, it returns nil for both location and error.
Returning nil as a valid value when there is no error is undesirable. It means that we have to check the return value, regardless of whether we have a return error or not.
Instead, it would probably be good to return a sentinel error, such as ErrNoCoordsFound.

i get the point of getting (nil, nil) from a function that returns (*geo.Location, error). however as a convention, we always check if err is nil first. in this case, err is nil, which means there's no error, please go ahead to check the value of *geo.Location type.
the pointer here is designed for a reason. if it's not a pointer, we may have to introduce an error to differentiate zero-ed location from got nothing. a nil pointer is enough for client to know what happened.


Docs refer to istio-citadel-plugin-certs.yaml but it doesn't exist

https://preliminary.istio.io/docs/tasks/security/plugin-ca-cert.html says to run the following command
kubectl apply -f install/kubernetes/istio-citadel-plugin-certs.yaml

but the file does not exist in the release zip, nor does it appear in the istio.io/istio source tree, nor is it created by updateVersion.sh.  I'm not sure how to get this file!

/cc lei-tang

/cc @lei-tang

According to @lei-tang, this was due to PR https://github.com/istio/istio/pull/6585, where all the templates are removed, but the corresponding helm charts are not created.
A similar problem happened for health check (https://github.com/istio/istio/issues/6922).
Two options:

Revert PR https://github.com/istio/istio/pull/6585. We should remove templates only after all the helm charts are created to completely replace the templates.
Identify the missing files one by one, and fix them accordingly. I have no idea how many missing files are there due to this.

/cc @ymesika @wenchenglu @wattli @myidpt

I plan to revert this PR istio/istio#6585, because it caused several issues of missing yaml files. @ymesika, let me know if you have any concern.

Don't revert https://github.com/istio/istio/pull/6585. Fix the problems one by one. The instructions need to be changed to use helm.
There is already a PR that fixes this specific issue: https://github.com/istio/istio.github.io/pull/1757

@frankbu , i don't think it is a good idea to simply remove all files that are still actively listed in our web page, and wait for people to find them out one by one, and fix them one by one. For this issue it's one file, but that PR deleted 20+ of them, which should not happen.
I suggest to revert #6585 and update the reference to every single of them before we actually delete it.
@rshriram @geeknoid @louiscryan @smawson

@wattli What 20+ files? The output of the old updateVersion.sh generated 13 yamls (+ addons)
Not generated Citadel stuff by the new one are:

istio-citadel-plugin-certs.yaml
istio-citadel-standalone.yaml
istio-citadel-with-health-check.yaml

The last one has been covered by https://github.com/istio/istio/pull/6961 which raise a question of @rshriram, which I tend to agree with, of why we are not always enabling it and getting rid of the flag + doc. It's still waiting for your comment.
So all in all we are left with a couple of Citadel files not generated. So @frankbu one by one approach makes sense.
To be honest those YAMLs can be embedded into the doc for a copy-paste instructions rather than pretty static templates.

I think the easiest solution is to just add back those 3 missing files to the release: https://github.com/istio/istio/pull/7178

@wattli I'm not suggesting we wait around for users to find them one by one, I'm suggesting that whoever is responsible for these tasks (who wrote them?) should fix them one by one asap.

Re the citadel standalone helm PR here: https://github.com/istio/istio/pull/5292
This needs significant work and will not be ready for 1.0 - so suggest following @frankbu 's guidance.
Cheers
-steve

fixed by #1757

@frankbu, my point is we should not make breaking change especially at this pre-1.0 moment.


Migrate CircleCI config to 2.0 format

💁 These changes migrate the existing CircleCI configuration to 2.0 format.

👋 @boggsboggs Would you please review these changes. The CI build is failing because my fork does not have access to the main environment variables.

🙋 @dfuentes @nickatsegment @systemizer: Are you able to review these changes?

@sgerrand thanks for your contribution! I'll take a look today.

Bugger, you're right. Apologies. I'll add that back in.

the deployment step that we used to have

♻ I've reinstated it in 5a2d75cfacea8122f59477809787b2dcfb5d1090.

@sgerrand I've incorporated your work into https://github.com/segmentio/aws-okta/pull/75 and intend to get it merged today. After fiddling with it a bit, I realized there were lots of problems with the old build process and basically rewrote it from scratch. So I'm going to close this PR and prefer that one. Thanks so much for getting this started; it's a lot easier to fix a bug if there's a PR attached :)


Prioritize TURN servers according to they relay protocol

Description
Today, all relay candidates from Pion have the same priority. This PR attempts to reproduce libwebrtc's behavior, where the TURN servers candidates priority is based on the underlying relay protocol. UDP are preferred over TCP, which are preferred over the TLS options.
We reuse the same factors as libwebrtc:
https://github.com/mozilla/libwebrtc/blob/1389c76d9c79839a2ca069df1db48aa3f2e6a1ac/p2p/base/turn_port.cc#L61

Thank you so much @karaziox I am merging this now!
This is a pretty deep change! Anything else with Pion you would like to see improved? What else do you think could be better? Would love to hear what else you are looking at :)


rel: Prepare v0.4.1 release

Which problem is this PR solving?
Prepares the v0.4.1 release.
Short description of the changes

Updates version to 0.4.1
Adds changelog entry

Waiting on updating to use new launcher repo


Fails if not using a covid genome

I think this has to do with the custom check for the swift protocol.
 -- Check script '/home/eam150030/.nextflow/assets/nf-core/viralrecon/./workflows/illumina.nf' at line: 197 or see '.nextflow.log' file for more details
WARN: Process 'NFCORE_VIRALRECON:ILLUMINA:MULTIQC_CUSTOM_CSV_IVAR_PANGOLIN' cannot be executed by 'slurm' executor -- Using 'local' executor instead
-[nf-core/viralrecon] Pipeline completed with errors-

Description of the bug
Fails if you're not using a covid genome
Steps to reproduce
Steps to reproduce the behaviour:
Relavent nf-params.json
    "fasta": "https://gist.githubusercontent.com/Emiller88/addd82ca68766c56d45248f546ff9c7c/raw/90541486f8d4f8302dab8bb79e0e0ec9b85ed042/NC_001802.1.fa",
    "gff": "https://gist.githubusercontent.com/Emiller88/addd82ca68766c56d45248f546ff9c7c/raw/90541486f8d4f8302dab8bb79e0e0ec9b85ed042/NC_001802.1.gff",
    "primer_bed": "https://gist.githubusercontent.com/Emiller88/addd82ca68766c56d45248f546ff9c7c/raw/471f9d2a1e72ddd769d995fbc16dcc71a9d9dec2/NC_001802.1_primers.bed"

Expected behaviour
Log files
Have you provided the following extra information/files:
./nextflow run nf-core/viralrecon -r 2.1 -params-file nf-params.json -profile utd_sysbio

System

Hardware: HPC
Executor: slurm
OS: CentOS?
Version ?

Nextflow Installation

Version: 21.04.2

Container engine

Engine: Singularity
.nextflow.log

Scratch that it's failing here
PREPARE_GENOME
            .out
            .primer_bed
            .map { WorkflowCommons.checkPrimerSuffixes(it, params.primer_left_suffix, params.primer_right_suffix, log) }

primer.bed
MN908947.3  3006    3029    Ph_LTR_RIGHT    1   -
MN908947.3  2215    2233    B_LEFT     2   +
MN908947.3  4755    4778    B_RIGHT    2   -
MN908947.3  3991    4017    C_LEFT     3   +
MN908947.3  6082    6110    C_RIGHT    3   -
MN908947.3  5783    5804    D_LEFT     4   +
MN908947.3  8362    8384    D_RIGHT    4   -
MN908947.3  7323    7344    E_LEFT     5   +
MN908947.3  9618    9635    E_RIGHT    5   -```

Commenting out those lines allowed me to kick it off.

I am unable to reproduce this 😏 I copied the BED file above and had to change spaces to tabs but otherwise the pipeline starts off fine. Please re-open if the error persists.


changes to litmus

What this PR does / why we need it:
This PR simplifies the tasks of provisioning and deprovisioning of openebs.
Signed-off-by: Somesh Kumar<EMAIL_ADDRESS>

@somesh2905 looks like your fork doesn't exist. please create new PR .


[Question] where would i use this ?

I am trying to impliment a better EQ but where would i call this mEqualizer = new Equalizer(MediaPlayer.getAudioSessionId)
I got confused with the new Media Player you implimented
Please tell me where would i need to call it  sir ?
Example.. class name ,, line number thanks :)

Jockey already has code similar to that in EqualizerFragment and MusicPlayer. You can see what each does by running "Find usages" in Android Studio on equalizer and mEqualizer respectively.
If by "the new media player" you mean the new implementation with ExoPlayer in m/exoplayer, there's much more of an implementation hurdle. In Exoplayer, an individual instance does not have a guaranteed audioSessionId like a MediaPlayer does. Because of this, every time you start a new track, you get a new Audio Session ID (which you can't set yourself with the out-of-the-box API to my knowledge). Instead, you have to add a callback to the TrackRenderer to receive updates about the audio session ID changing and set up new Equalizer objects all the time. This detail is why m/exoplayer hasn't been merged into master yet – because some devices don't gracefully handle audio effects being enabled, which happens all the time in the new implementation.

Okay :) thanks will have a look
On Sep 11, 2016 22:49, "Andrew Bailey"<EMAIL_ADDRESS>wrote:

Jockey already has code similar to that in EqualizerFragment and
MusicPlayer. You can see what each does by running "Find usages" in
Android Studio on equalizer and mEqualizer respectively.
If by "the new media player" you mean the new implementation with
ExoPlayer https://github.com/google/ExoPlayer in m/exoplayer
https://github.com/marverenic/Jockey/tree/m/exoplayer, there's much
more of an implementation hurdle. In Exoplayer, an individual instance does
not have a guaranteed audioSessionId like a MediaPlayer does. Because of
this, every time you start a new track, you get a new Audio Session ID
(which you can't set yourself with the out-of-the-box API to my knowledge).
Instead, you have to add a callback to the TrackRenderer to receive updates
about the audio session ID changing and set up new Equalizer objects all
the time. This detail is why m/exoplayer hasn't been merged into master
yet – because some devices don't gracefully handle audio effects being
enabled, which happens all the time in the new implementation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/marverenic/Jockey/issues/127#issuecomment-246203672,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARrlv9Wl2vfwt1AZYltRGSWSjKKznQQJks5qpGlNgaJpZM4J6GMi
.

Wouldn't it be better to leave the ExoPlayer out and stick to the original Media Player ?

It depends. The MediaPlayer class provided by the Android framework is very basic, which means that it's relatively simple to implement, but it's difficult to do more advanced things with it. It also has very bizarre implementation details including the fact that it's a very stateful object, but you can't actually tell what state it's in. This is a problem that Jockey has struggled to account for for quite a while – because whenever you try to do something in an invalid state, the player will reset completely. There are also a bunch of undocumented error codes (like -38) that just happen for seemingly no reason (and are made very difficult to debug because of the stateful and asynchronous nature of the class).
ExoPlayer is an alternative library to MediaPlayer. It exposes a very different API, and has more of an implementation cost, but it doesn't have the same problems as MediaPlayer. It's also very powerful for playing video and streaming live or static content from the internet should Jockey need to in the future.
Exoplayer 2 was recently released which has a different API that isn't backwards compatible with version 1. I haven't looked into the new API or differences between 1.0 and 2.0, but it may make it easier to implement equalizers or other audio effects.

Okay thanks looking forward to all the new coming updates keep up the great work what about some visualisation ?


Issue with service type of kubernetes-containerservice template

Describe the bug

Steps to reproduce

Create a service using kubernetes-containerservice template without configuring an external port.
Go to the service details page and check the template configuration.
Check deployed resources on the Kubernetes cluster.

Result

The service type is NodePort.

The actual service type is ClusterIP.

Expected behavior

Environment

Walrus version: main fcec81df221b37754b6be6b5657bbbfab845fabf
UI version: dev-33d2ecd

Additional context
Add any other context about the problem here.

clarify the usage of this field in the description, https://github.com/walrus-catalog/terraform-kubernetes-containerservice/pull/16/commits/1d23e59c75c9b33f92061d9126dc543f0be2fb29.

Environment

Walrus version: main 66f1bd1681cc926d6b35a6caed7ec5f793ae103a
UI version: dev-21d34af

Test Result: kubernetes-containerservice v0.2.5 pass


Robust conversion of weights from floating point to integer

For Metis and Scotch, related to #219.
Cast from floating point to integer can cause the following problems:

overflow if weights are highs. Ideally the sums of all the weights should fit weight type
zero weight are not properly supported when doing mono-criteria partitioning.

Arcane already has these kind of "smart" conversion:
    m_zoomfactor[0] = (m_maxAllowed-m_sum[ncon])/(m_sum[0]+1);

https://github.com/arcaneframework/framework/blob/fd8a069bc6253a52d86019c75c78085f48ffea2f/arcane/src/arcane/std/PartitionConverter.h#L108

Indeed, metis segfaults on zeroes, and scotch seems to spin eternally. :(


Rule suggestion: lint against the use of in with compound comparisons

The use of in with compound comparisons often leads to unintended/surprising behaviour.
False == False in [False]  # True

A solution would be to use parentheses.
(False == False) in [False]  # False
False == (False in [False])  # False

Similar to #8721, but the AST produced by False or False and False is quite different, so might be a different rule.

Agree this would be useful to lint against. There are a few more variations of compound Compare that probably don't make sense either: a < b is c, a is b is not c.
Arguably we should lint against all compound Compares except the following:

Both compares are is: a is b is c
Both compares are ==: a == b ==c
Both compares are one of <, <=: a <= b < c (probably the most common use  of compound Compare)
Both compares are one of >, >=: a >= b > c

Maybe there are other uses of compound Compare that also make sense and that I didn't think of, though.

I'll submit a PR implementing this rule this weekend


Alias/IndexManaged : Last column is right aligned

In Admin/Alias/IndexManaged , the last column contains text and is aligned right because of the default css :
 .table td:last-child { text-align: right; }

I agree that we should'nt do that. It's a too large scope.

This one is fixed. We need to look if we need to apply text-right in some places now.

Confirm it is fixed.


[selectAllRowsOnPage] is broken.

I'm submitting a ...  (check one with "x")
[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior

When a table with checkbox selection has [selectAllRowsOnPage] set to true, it does not show up. The following error appears in the Chrome console:
DatatableComponent.html:5 ERROR TypeError: Cannot read property 'indexes' of undefined     at DatatableComponent.get [as allRowsSelected] (datatable.component.ts:684)     at Object.eval [as updateDirectives] (DatatableComponent.html:19)     at Object.debugUpdateDirectives [as updateDirectives] (core.js:28133)     at checkAndUpdateView (core.js:27529)     at callViewAction (core.js:27770)     at execEmbeddedViewsAction (core.js:27733)     at checkAndUpdateView (core.js:27530)     at callViewAction (core.js:27770)     at execComponentViewsAction (core.js:27712)     at checkAndUpdateView (core.js:27535)
Expected behavior

The expected behavior would be that the table appears as normal and clicking the master checkbox would only select the rows visible on the current page instead of every row.
Reproduction of the problem

This problem can be reproduced by getting the latest version of this repository, going to the demos, finding selection-chkbox.component.ts, and changing the line
[selectAllRowsOnPage]="false"
to
[selectAllRowsOnPage]="true" .
What is the motivation / use case for changing the behavior?

The motivation for changing this is to allow users to configure their tables with checkboxes so that  clicking the master checkbox would only select the rows visible on the current page instead of every row.
Please tell us about your environment:

Windows 10, Webstorm, NPM, Node and angular-cli on WSL Ubuntu

Table version: 15.0.2

Angular version: 8.1.0

This is  an issue on Angular 8.1.0 and version 15.0.2 of this table. This was not an issue on Angular 7 and version 14 of this library. Looking through the changelog, I do not see anything that explains why [selectAllRowsOnPage] would work fine in version 14 and not version 15.0.2.

Browser:  Chrome 75 | Pale Moon | Microsoft Edge 42

This bug existed in Chrome 75, Pale Moon 28, and Microsoft Edge 42. I have not tested any other browsers.

Language: [all | TypeScript X.X | ES6/7 | ES5]
I am working in TypeScript.

I can reproduce this issue on our web application. It seems to be related to the changes in Angular  v8 regarding @ViewChild() and the introduced static-flag.
In our case, the directive that binds allRowsSelected to the datatable throws the same error when navigating away from a page with code like
<ng-template ngx-datatable-header-template let-allRowsSelected="allRowsSelected" let-selectFn="selectFn">
  <span [ngClass]="allRowsSelected ? 'fa-check-square-o' : 'fa-square-o'" (click)="selectFn.apply(!allRowsSelected)" class="fa fa-lg cursor-pointer"></span>
</ng-template>

If I remove the binding for allRowsSelected, it works fine (sans the functionality, ofc).

Managed to fix this by removing [selectAllRowsOnPage] input. It may not be necessary as the checkbox behavior is the same as before.

Any update on this? Would it be worth setting the bodyComponent static flag to false for now?

@swimlanes,
Can you please review this pull request?


Nested routers middleware order?

I got the following code:
var app = koa();

var router = require('koa-router')();
router.use(function* (next) {
    console.log('Router middleware');
    yield next;
});

var subRouter = require('koa-router')();
subRouter.use(function* (next) {
    console.log('Subrouter middleware');
    yield next;
});

subRouter.get('/', function*() {
    this.body = 'Hello world!';
});

router.use('', subRouter.middleware());

app
    .use(router.routes())
    .use(router.allowedMethods());

When I go on / route, I got the following debug messages:

Subrouter middleware
Router middleware

I would expect the opposite order, as I registered the router middleware first. Is it the expected behavior? If so, have you any clue to reverse this order?
My use case is quite standard: I got a main router in which I initialize a database connection through a middleware (setting it in a this.dbClient property). Then, my subrouters (one per API) initialize its model repository via another middleware, passing it the dbClient service. The repository is then in an attribute to factorize code between all CRUD methods.

Problem is here
https://github.com/alexmingoia/koa-router/blob/master/lib/router.js#L256
normal use is using unshift, but when used with nested router, it uses push. Replacing push with unshift fixes this.
However, there is bigger problem than this. when you use multiple subrouters, each with different middleware, this sentence from docs: Only runs if any route is matched is no longer true. When one subrouter matches, middlewares from all subrouter are run.


CommandBar bug... error if one of the collections is null

Fixed with
https://github.com/limefrogyank/BlazorFabric/commit/c415a84fa1c85a0f1fe261e1f83b80a515ef5ab4


Fix typo in readme for docker exec detach/detached

@alex-raoul thanks for spotting that. If you could align the arrows in the code sample to match the Puppet style guide I'll get this merged. Cheers

Done :)


Support "try ... exception"

https://github.com/pikasTech/pikascript/commit/b20b5f1bb57133bd90197490e1a6cf8db4c86926


-4 on attack with touch and ranged touch

Im playing with both temple+ and Co8 expansion and when i attack with spells im getting a -4 Option: Dealing Nonlethal Damage

g

I couldn't reproduce this immediately and in the code it looks like the penalty should only be applied when a weapon is used. Please give some more details.  Was the non lethal damage option selected?  What spells did you use?  What weapon was equipped?

Is the "deal normal damage" option ticked in the radial menu? What spell is this?

This is my stat block in case you need it, the weapon i have equipped is a rapier but it doesn't matter if im doing it with another weapon or barehanded. Spells both ranged and touch always have this -4, and i dont have non lethal damage on. Any way to share the save file? I can post it on the Circle of 8 discord just PM me zecond#0428

Just found out why its doing it, when i have "cast defensively turned" on, there is no mention of this -4 malus in the Help menu.

Cast defensively doesn't seem to make a difference for me.  I wonder if this has something to do with the ranged sneak attack option since you have Arcane Trickster levels.  Please send a save file to<EMAIL_ADDRESS>

Never mind... I just reproduced it.  Unarmed and deal normal damage on were the key.  Arcane trickster levels were not necessary and cast defensive didn't seem to make a difference for me.

Looks like a bug in vanilla TOEE in function 100F9040.  I don't see anything checking if it was a ranged attack or touch attack.  I should be able to fix if pretty soon.


[Bug] No preview image

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Self-Hosted
Current Behavior
Preview is not visible.

Expected Behavior
Preview should be visible.
Steps To Reproduce
It is self hosted using docker compose. Preview in editor works fine, as well as PDF download. It just doesn't show on main page. I don't see any errors in console logs or docker logs, so it's hard to troubleshoot. What and where I can check to resolve this issue?
What browsers are you seeing the problem on?
Firefox, Chrome
What template are you using?
None
Anything else?
No response

Noticing the same thing

I see that the resume preview feature was removed 👇

commit: https://github.com/AmruthPillai/Reactive-Resume/commit/767573ce6d520ee5e484859d390ced9646dd3e17
issue: https://github.com/AmruthPillai/Reactive-Resume/issues/1954

The reason was to reduce the load time. ⌛
cc. @AmruthPillai

What about extracting the preview part into a common library (eg. @reactive-resume/ui)?
So, we can use it in the artboard and in the client dashboard page 🤔

💡 For now as a "quick fix", we could use the template image itself.

Adventages
Disadventages

We won't have black images on the dashboard
The image won't show the actual state of the CV

There is no load time
It'll be a little annoying to have the same image if the templates are the same for multiple CVs

Preview

I think I found a way to implement the preview easily 😄

using iframe to render it and set resume in the useEffect((), [frameRef])
references:

set resume: https://github.com/AmruthPillai/Reactive-Resume/blob/main/apps/client/src/pages/public/page.tsx#L28-L40
render preview: https://github.com/AmruthPillai/Reactive-Resume/blob/main/apps/client/src/pages/public/page.tsx#L81-L86

I'd like to create a branch and PR if possible @AmruthPillai
Thank you!
Demo

@AmruthPillai Can you provide access to me to create branches/PRs, please? Thank you!

@AmruthPillai Can you provide access to me to create branches/PRs, please? Thank you!

Okay, I see it works with forking the repo. Will do. Thanks!

This is the PR: https://github.com/AmruthPillai/Reactive-Resume/pull/2032
Thank you!
cc. @AmruthPillai


Fix parallel loading of files

Describe the bug
Fix loading of files in parallel.
At the moment it can happen that loading a file triggers a 'Not found' message even if the file exists and is loaded into LogoRRR.
To Reproduce

load "SimpleLog.txt" from test resources folder in an empty LogoRRR instance
inspect Log - you'll find a message which complains about the file missing ("Not found: 'SimpleLog.txt'")

Expected behavior
Message does not occur, files are loaded in order of appearance of logorrr.conf, the correct file is selected.
Additional context
This happens since several log files are loaded in parallel in different threads, and this thread handling is not implemented correctly. The ordering of the files is also determined on how long those files need to load rather than original ordering which is defined in logorrr.conf.

fixed with #155


cd MyApp is not working

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/create
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

Can you show the result of the dir command? What is the path you're currently on?


Problem relative to heavy use of b.run()

As the build script currently works, it calls b.run("llvm-config" , ...) a bunch of times as part of the build setup process.
Unfortunately this means that any project that depends on this build script, even indirectly, will fail to build if llvm-config is not found. This will happen even if the build step selected has nothing to do with fuzzing because b.run is not b.addSystemCommand.
See my CI for example, where zig build test fails even though I don't try to build any instrumented executable:
https://github.com/kristoff-it/superhtml/actions/runs/10063015979/job/27816833324
One solution would be to turn all usage of b.run into usage of addSystemCommand.
It's a bit of work, but unfortunately I can't think of a better option.
Pinging @marler8997 in case he has ideas to share.

I agree, but don't know how to get the string output of b.addSystemCommand to operate on, parse and b.fmt into some other string. There's captureStdOut, but that returns a LazyPath.

Is there a way to get which build step the user specifies? We could just branch out of doing any LLVM stuff when the user specifies some non-llvm step.

I'm chatting with the core team they're recommending a better approach, I'll be able to PR this myself

@tensorush if you look at my commit from today you will see that I implemented a fix to this problem by conditionally wiring a fail step to replace a bunch of logic that depends on llvm-config. Fail step was introduced in 0.14 and I backported it so that we can use this script also from 0.13.0


Sync: CharacterObject Collections

Description

Sync the values in the Synced list below.
Create an end to end (E2E) tests for all collections (1 for server changing the value and 1 for client changing the value if applicable)
Create a command to test updating the collection in game see similar command

Also see additional information at the bottom for more information and templates

Key
Server side only (only allow the running of the function on the server side)
Client side only (only allow the running of the function on the client side)
Client side sync (request the server to change the value, server then changes the value and replies to the client allowing the change)
Server side sync (only server allows running of the function and send to all clients the value changed and clients update the value/call original function)
Synced

None
Deferred

None
Externally Deferred

None
Non-Synced

None
Intended Design

For the patch itself please refer to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/wiki/Patching-Basics#collection-patching
Collection Sync Dataflow

Integration Testing

Location

Create a branch based from development
Related Issues

Blocked by:

#845

Requirements

N/A
Additional information

Using the GameInterface Service Tempale create commands to test the synced values.
Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit E2E tests exist for every synced collection on the server (and client if applicable)
[ ] Each collection has a command for each type of synced update

No sync able collections exist


Create a bundle

Need to create a bundle which includes the popular / recommended modlets into a single downloadable.

Completed. donovan-aio now exists in the A18 branch.


Cursor Shifts to left side of editor automatically

VS Code Version:
OS Version: MacOS Big Sur 11.2.3

Steps to Reproduce:

Run VSCode with multiple files.
When I change files and move from one to another.
I see that the cursor is back to the leftmost side of the editor on that specific line it was.
Disabling extensions did not help.

Please assist its pretty annoying.

Does this issue occur when all extensions are disabled?: Yes/No

VS code version: 1.54.3

@iaxat Can you please provide more clear steps, like e.g. "open file1.txt", "open file2.txt", etc. I think perhaps you are doing a certain pattern that might trigger an issue. I tried switching files, but the cursor remains at its correct stop for me.

Sure, the thing is that the files are under the network drives attached to the computer using Rclone.

@iaxat I have modified our FS provider sample from https://github.com/microsoft/vscode-extension-samples/tree/main/fsprovider-sample to make the file reading really slow (always takes >5s). However, I could not reproduce any problem with the cursor position. The cursor position is restored to where it was when the file was closed:
https://user-images.githubusercontent.com/5047891/120894469-cb76b000-c618-11eb-8abb-f775209c765a.mp4


Multi-module error

I have a multi-module project where we are using detekt for some modules but not for all. When tried to push changes the plugin gave check-warnings but since we treat them as errors it fails the CI/CD. I'm planning to change in the meanwhile to use the gradle detekt task to not block the team/project pace but was this considered on your plugin?

Hello!
I've never tried to disable detekt checks in modules. We always check all the modules we own.

Would this be a nice feature to have? At least when you have a legacy project or modules on a different state it would be interesting to apply only detekt on those

I will try to use the flag detekt_excludes but it would be interesting one day to understand in which modules detekt is being applied to run the action only on those

It would be difficult to implement because the current implementation knows nothing about the Gradle and modules. It just runs from the project's root folder and scans everything except excluded files.
I suggest you to use gradle detekt plugin as you mentioned before or detekt_excludes to exclude specific folders.

Appreciate, thanks for the feedback will do it! 🚀


[VL] Fix consolidate config in velox

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

CI failed 0811 not happen again
- Test sample op
24/08/10 22:47:09 WARN GlutenFallbackReporter: Validation failed for plan: Execute InsertIntoHadoopFsRelationCommand[QueryId=2639], due to: at least one of its children has empty output; at least one of its children has empty output.
E20240810 22:47:09.964604  8411 Exceptions.h:67] Line: /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/Task.cpp:1864, Function:terminate, Expression:  Cancelled, Source: RUNTIME, ErrorCode: INVALID_STATE
24/08/10 22:47:09 WARN GlutenFallbackReporter: Validation failed for plan: Execute InsertIntoHadoopFsRelationCommand[QueryId=2641], due to: at least one of its children has empty output; at least one of its children has empty output.
E20240810 22:47:10.035218  8411 Exceptions.h:67] Line: /__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/exec/Task.cpp:1864, Function:terminate, Expression:  Cancelled, Source: RUNTIME, ErrorCode: INVALID_STATE
#
# Java VM: OpenJDK 64-Bit Server VM (25.362-b08 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libc.so.6+0xa7866]  __memmove_avx_unaligned_erms+0x66
#
# Core dump written. Default location: /__w/incubator-gluten/incubator-gluten/backends-velox/core or core.1416
#
# An error report file with more information is saved as:
# /__w/incubator-gluten/incubator-gluten/backends-velox/hs_err_pid1416.log
#
# If you would like to submit a bug report, please visit:
#   https://bugzilla.redhat.com/enter_bug.cgi?product=Red%20Hat%20Enterprise%20Linux%208&component=java-1.8.0-openjdk
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.


Update environment.yml

Update to unconflict packages

This is being blocked by #62 and will be resolved after it.


music tracker for bandjs

It would be just awesome if someone would create an online [music tracker](http://en.wikipedia.org/wiki/Tracker_(music_software) using band.js for playback and load/save.

Hello all. When I looked for a music tracker or composer that used Band.js, I could not find one (please let me know of any I missed), so I made one.
Getting Started with Maize Composer
Run Maize Composer online
The GitHub repo