Allow declaration/implementation of Type for non-trivial types implmenting Decode for Sqlite with query_as! macro

Is your feature request related to a problem? Please describe.
I am attempting to implement a custom key type that is not just a simple string, but has a string representation - namely, the Ulid crate. Internally, it stores a u128, however, it has a string representation - and that is what I'm trying to store. I want to implement this manually with its from_string() method (not part of std's FromStr trait), however I have no way to declare compatability despite being able to implement the Decode trait.
Describe the solution you'd like
Some way to tell Sqlite that I would like to implement a custom type that maps to an internal type (in this case, TEXT)
Describe alternatives you've considered
Unable to find any - I cannot implement Type, and I want proper compile-time type checking here. I cannot implement Type myself, as the inner value of SqliteTypeInfo is not pub, and there is no way to otherwise construct it that I have found.
Additional context
Sample implementation of Decode for the type given as an example:
#[repr(transparent)]
pub struct Ulid(ulid::Ulid);

impl Decode<'_, Sqlite> for Ulid {
    fn decode(value: SqliteValueRef) -> Result<Self, BoxDynError> {
        let value = <&str as Decode<Sqlite>>::decode(value)?;

        Ok(Ulid::from_string(value)?)
    }
}

Note that internally Ulid is not repr transparent, only my newtype is.
This also applies to Encode, but right now my code is only trying to work against Decode

Possibly related to #148, however that one has been closed without supporting less trivial types such as the above.

Just ran into the exact same issue — incidentally, with the exact same use-case: a custom ID type that's not UUID. In my case, I'm using a Postgres extension that provides a native BSON ObjectId type.
Looks like the hangup is in sqlx-macros (sqlx-macros-core in 0.7-alpha). Since type inference is dependent on sqlx_macros::database::DatabaseExt::param_type_for_id and return_type_for_id, which are defined via this hard-coded list, there's no way for sqlx to get the Rust type from the SQL type.
https://github.com/launchbadge/sqlx/blob/bb064e3789d68ad4e9affe7cba34944abb000f72/sqlx-macros/src/database/postgres.rs#L3-L12
It'd be great if there was a way for consumers to add to this list somehow!
Thinking out loud: Maybe via trait? Or maybe if sqlx-macros maintained a global mutable variable that could be added to via macro? Or maybe a config file that mapped user-defined SQL type names to paths in the current crate?

My workaround for now is to disable inference:
let user = sqlx::query_as!(
    User,
    r#"
        INSERT INTO users (username)
        VALUES ('example')
        RETURNING *, id AS "id: Id"; -- error if not specified
    "#
);

let user_session = sqlx::query_as!(
    UserSession,
    r#"
        INSERT INTO user_sessions (user_id)
        VALUES ($1)
        RETURNING *, id AS "id: Id"; -- error if not specified
    "#,
    user.id as Id // error if not specified
);

(using these SQL tables)
CREATE TABLE users (
    id object_id PRIMARY KEY DEFAULT gen_object_id(),
    username text NOT NULL
);

CREATE TABLE user_sessions (
    id object_id PRIMARY KEY DEFAULT gen_object_id(),
    user_id object_id NOT NULL REFERENCES users (id)
);


How to add an existing applet?

Hey!
Thank you for your plugin to Elgato Stream Deck!
I wonder how I could link an applet that I've already created.
Because through the plugin I can create a new only.
Could you, please, add the required functionality to your plugin?
That would be awesome!
Thank you.

Hi,
this is not possible, because IFTTT only allows one trigger per applet.

Okay, thank you.


Any chance you could add a method to clear all arrows easily?

I had a look at your Arrows extension and I can't seem to figure out an easy way of clearing all arrows. It would be nice if there was a simple clearArrows method. Or at the very least if the getArrows method returned an array including all existing arrows. At the moment the getArrows method seems counter intuitive as it requires that you pass it a type, to and from.
The arrows array is not exposed currently so there's no easy way to retrieve all existing arrows after which I could iterate over each and remove each arrow.
I know I can extend this extension but.. it would be nice if these basic features were included for all to use.
Apologies if I'm just completely missing something obvious and there's already a way to clear arrows easily.
Many thanks

Anyway this was super easy to add.. maybe you'll consider adding it to the core extension

  clearArrows() {
    this.arrows.forEach((arrow) => {
      this.removeArrows(arrow.type, arrow.from, arrow.to);
    });
  }

Hi, to remove all arrows, just call chessboard.removeArrows() without parameters.

Wrote more documentation for the arrows extension, see: https://github.com/shaack/cm-chessboard#arrows-extension

Thanks @shaack
It's weird, I thought for sure I had tried calling removeArrows and getArrows with no parameters and I thought I got errors from doing this about a missing type parameter.. maybe it's because of the new warning you added after changing the parameter order in 5.1... I'll try again... did you test this with the latest version too?

Yes it works with the latest version.

@shaack Thank you I can confirm that the removeArrows works fine.. I don't know why I was having issues with it before.
On a side note, it would be fantastic if you could allow us to set the colour of arrows easily without having to fork the whole Arrows extension just to add a few more arrow types.
It would be nice if we could pass the arrow colour as a parameter to the drawArrow method, or if that's not easy, then let us pass a custom class and when can define the colour inside the class since this is how colours are currently defined.

Hi, to create new arrows, you don't have to fork the arrows extension, just create new types. Like this.
const MY_ARROW_TYPE = {
    info: {class: "arrow-info", slice: "arrowDefault", headSize: 7},
   warning: {class: "arrow-warning", slice: "arrowDefault", headSize: 7},
   whatever: {class: "arrow-whatever", slice: "arrowDefault", headSize: 7},
}

then add the classes .arrow-info and .arrow-warning to your css. Done.


Misuse of span.record in tracing middleware

Hello,
I was looking through the poem source code and noticed an issue in the tracing middleware.
The tracing docs say:

Note: The fields associated with a span are part of its Metadata. The Metadata describing a particular span is constructed statically when the span is created and cannot be extended later to add new fields. Therefore, you cannot record a value for a field that was not specified when the span was created:

Source
It appears that poem violates that rule in the tracing middleware.
I've not actually validated this is an issue; just something I ran into on another project.
I'm fairly new to Rust and the Tracing crate so I might be mistaken. I'm happy to raise a pull request for the fix.

Just had a chance to take a look and I don't think the PathPattern extraction for the tracing middleware works at all.
Using with(Tracing) creates a TracingEndpoint<Route> where TracingEndpoint::call is called first and then it passes the request onto Route::call. PathPattern is added to the request by Route::call so it doesn't exist when TracingEndpoint::call is called.
Does anyone have ideas of how we could fix this?
The only solution I can think of is to change the signature of Endpoint::call from fn call(&self, mut req: Request) to fn call(&self, &mut req: Request) so that we can read from the request after calling Route::call although I dread to think what other issues this change would call.

'PathPattern' exists only with 'Route'.

https://github.com/poem-web/poem/blob/0481e2e167c5e312204c486eb17f7039d4624c4f/poem/src/route/router.rs#L339

It just prepared span before, but actually use it here.

https://github.com/poem-web/poem/blob/0481e2e167c5e312204c486eb17f7039d4624c4f/poem/src/middleware/tracing_mw.rs#L109


UI Issue

Flight View Controller's button has font Issue.

hotel has button font something like this

hotel has button font something like this


Add Server::listen_with

Implements Server::listen_with which takes an async closure that can be used to report information about the connection. Closes #712.
The way this works is by introducing a new trait tide::connection::Report which is called once per listener and is passed an instance of tide::connection::ListenInfo. By default tide::listen invokes a default log-based reporter (tide::log::Reporter), but by using tide::listen_with this can be overwritten.
This can also serve as a foundation to gradually expand our logging capabilities. For now ListenInfo only logs the string passed, but it'd be nice if we could eventually also include things like a vec of HTTP protocol version supported, TLS settings, and perhaps even routes registered. Also since the callback returns a future, it can be used to delay accepting connections until some signal is passed -- setting us up to experiment with something like Swift's service lifecycles. We can gradually expand on this over time, and enable other people to experiment with this just by exposing this hook. Thanks!
Examples
use tide::listener::ListenInfo;

let mut app = tide::new();
app.at("/").get(|_| async { Ok("Hello, world!") });
app.listen_with("<IP_ADDRESS>:8080", |info: ListenInfo| async move {
    println!("started listening on {}!", info.connection());
    Ok(())
}).await?;

I am curious, would something like this work?
let conn: ListenerConnection = server.listen_conn(addr).await?;

println!("{}", conn.addr());

// What actually keeps calling poll for new connections
let conn.await?;

Or does that not really work because it isn't really "listening" without being polled through the await?

I really like the thing that @Fishrock123 suggested and plan on experimenting with some variants like that before commenting more substantially. Could I ask that we hold off on merging this for a bit while I try some variations? I see the problem space and am not thrilled with the solution offered by this PR, but would like to see if I can come up with an alternative for discussion. Callbacks like this don't feel particularly rusty to me, and they don't seem particularly like the swift example either. I like the idea of registering hooks on the server, but think that we should tackle that more generic problem instead of changing the listen signature.  I also had a solution to this in the initial version of Listeners, and want to revisit that. A callback should be attached to the listener itself, which shouldn't change the signature for Server::listen

If we are considering something like "events" I think we would benefit from taking a look at how Node.js has integrated Promises into events with awaitable helpers:

events.once() -> Promise
events.on() -> AsyncIterator

We could map those to Future and Stream, the question becomes around executing a second context (like an async_std::task) in order to poll the listener.

@jbr I think you have the right idea with bind returning a listener; in particular:
let listener = server.bind("localhost:8000").await?;
println!("started listening on {}!", &listener);
listener.await?;

Seems like a good idea. This seems like the right place to start experimenting with.

@Fishrock123 that's an interesting idea. We should probably scope out what it is that we want from the service in order to see if if it would make sense to fit that in, but I think the API mapping makes sense.

Sorry for jumping on this so late. I like the feature but I'm not so fond of the api. listen_with is not very clear to me, especially since we already use with for adding middleware.
Maybe we could split adding the callback and starting the server into separate methods. I think this will make for a better api? Have an on_start_listening method to add the callback and not touch the listen method keeps things nice and focused. It also makes it easier if we want to add other server lifecycle callbacks later.

Sorry for jumping on this so late in the review process.
I like the feature but I think the API can be better.
The name listen_with is very unclear to me. With is already used for adding middleware so it's becoming an overloaded term. Also it conflates two actions, starting the server and adding the callback.
I would prefer to have a separate method. Something like on_listener_started on the server where you can add a callback. And then leave the listen method as-is.

Maybe a silly question, but would this bind function allow multiple listeners on a Server?
The only way I could figure out to get both a tide-rustls, and a http listener, was to create 2 servers, and join as below.
let app = route(tide::with_state(state.clone()));
let app_tls = route(tide::with_state(state));
let ((), ()) = try_join!(
              app_tls.listen(
                    TlsListener::build()
                        .addrs("localhost:4433")
                        .cert(std::env::var("TIDE_CERT_PATH").unwrap())
                        .key(std::env::var("TIDE_KEY_PATH").unwrap()),
                ),
              app.listen("localhost:8080"),
)?;

I didn't see any cases above of which involved multiple listeners (So i'm not sure if it would work), but it at least seems plausible to me, that people might assume by the name bind, that you can server.bind multiple listeners.

@ratmice it sounds like you may be looking for tide::Listener::ConcurrentListener. Using this will enable you to listen on both http and https with the same application.

Awesome, disregard that comment above then!

@yoshuawuyts Let's chat about this in Zulip at some point?

Worked on this today; Server::bind now works though it requires a fair bit of cleanup. The patch is not done, but I'm rounding out for the day so I wanted to share the status update.
I attempted do a clean-slate impl of Server::bind, but got really deep into the weeds of separating "connect the tcp stream" from "accept connections" at the trait level, and realized that would become a nightmare to maintain. I wasn't even sure if we could get past the coherence issues. And finally, we'd lack a uniform interface to access information about the listener.
So I've opted to keep "connect the tcp stream" and "accept connections" together in the same trait impl, but require implementers to send information data through a channel in between. This is currently implemented on top of the generic callback interface we had before ("Reporter" etc), but we can get rid of all the extra type params in favor of just using a dedicated type.
Next steps for this PR are:

[ ] pass tests
[ ] remove the callback interface
[ ] rename types so that they actually make sense
[ ] add docs & examples

Talked with @jbr, and wrote #740 which modifies the underlying trait to enable binding. This feels like a much more solid design overall.


Update on Power Platform Requests reporting

Hi,
Looking for clarification on the verbiage currently included in the documentation. I reviewed the 2022 Release Wave 1 notes and did not see this feature included. If not planned for first quarter can we adjust the documentation to reflect this?
"Generally available reporting for Power Platform Requests is expected in the first quarter of calendar 2022. Any potential high usage enforcement wouldn't start until six months after reports have been made available. Assignment of add-on capacity packs should be aligned to high usage enforcement."
Thanks!
alyousse

Link to documentation: https://docs.microsoft.com/en-us/power-platform/admin/api-request-limits-allocations#what-happens-if-a-licensed-or-non-licensed-user-exceeds-limits

@aliyoussefi
Taking to internal thread.


[AutoPR web/resource-manager] [App Service] Update swagger spec for ANT80

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5111

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/546


Update dependencies to fix issue with markupsafe breaking change

Description
Fix https://github.com/pallets/markupsafe/issues/284
Test Coverage

[x]  This change is covered by existing or additional automated tests.
[ ]  Manual testing has been performed (and evidence provided) as automated testing was not feasible.
[ ]  Additional tests are not required for this change (e.g. documentation update).

Codecov Report

Merging #35 (05e658f) into main (7171ed6) will increase coverage by 0.11%.
The diff coverage is 100.00%.

:exclamation: Current head 05e658f differs from pull request most recent head 01045d0. Consider uploading reports for the commit 01045d0 to get more accurate results

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   68.48%   68.60%   +0.11%
==========================================
  Files          44       44
  Lines        2345     2309      -36
==========================================
- Hits         1606     1584      -22
+ Misses        739      725      -14

Impacted Files
Coverage Δ

continuous_delivery_scripts/_version.py
100.00% <100.00%> (ø)

continuous_delivery_scripts/utils/configuration.py
84.84% <0.00%> (-2.47%)
:arrow_down:

...ontinuous_delivery_scripts/utils/string_helpers.py
89.28% <0.00%> (-0.37%)
:arrow_down:

...nuous_delivery_scripts/spdx_report/spdx_package.py
71.15% <0.00%> (-0.28%)
:arrow_down:

...ous_delivery_scripts/utils/third_party_licences.py
97.72% <0.00%> (-0.02%)
:arrow_down:

continuous_delivery_scripts/plugins/noop.py
70.83% <0.00%> (+2.83%)
:arrow_up:

continuous_delivery_scripts/utils/git_helpers.py
80.92% <0.00%> (+4.00%)
:arrow_up:


Cant Add Account 1.41.1 and 1.41.2

I was having issues this morning with my Active Directory Universal MFA so i "removed the account."  It now wont let me add it back.  I've tried newer versions of ADS, I've restarted, i've cleared out he Library/Application Support/azuredatastudio directory.  Nothing seems to work.

This looks related to the recent bug we fixed here: https://github.com/microsoft/azuredatastudio/pull/22140
@ncapito
Can you add this setting in settings.json and try again?
    "azure.authenticationLibrary": "MSAL"

@cheenamalhotra  It's currently set to MSAL (when i try with this setting i get the error above). When i toggled to ADAP it opened chrome and then locked up waiting https://login.microsoftonline.com/common/oauth2/authorize?response_type=code&response_mode=query&client_id=removed&redirect_uri=http%3A%2F%2Flocalhost%3A49783%2Fredirect&state=49783%2CcGt742e0w%252BjfKr2Owo619Q%253D%253D&prompt=select_account&code_challenge_method=S256&code_challenge=removed&resource=https%3A%2F%2Fmanagement.core.windows.net%2F

It may not be set in the settings.json as it's default. Please try adding explicitly by opening settings.json:

Open command pallete (Ctrl+Shift+P)
Run command: Preferences: Open Default Settings (JSON) (workbench.action.openRawDefaultSettings)

When i toggled to ADAP it opened chrome and then locked up waiting...

Are you in proxy enabled env by any chance? If yes, you may want to configure proxy in http.proxy setting:
"http.proxy": "https://userName@fqdn:yourPassword@yourProxyURL.com:8080"

@cheenamalhotra  I'm not in a proxy enabled environment.
I edited

settings.json and added   "azure.authenticationLibrary": "MSAL"
restarted ADS
tried to connect account and got an error but the message was different.

I did check with my colleagues.  They are all on 141.2 but dont have an issue because they did not remove the account.

@cheenamalhotra  I have an update on this one.  I was able to get ADAL returning and throwing the same error now.  My firewall was blocking access to Azure Data Studio (since i removed the app and reinstalled it).  Once I allowed connections i now get the same error:

the console had this in it:

I have the same problem. Went as far as remove all traces of Azure Data Studio and reinstalled clean. Nothing works. MSAL or ADAL both end up in the same 2 errors:
"TypeError: Cannot read properties of undefined (reading 'authLibrary')"
"Error: Adding account failed, check Azure Accounts log for more info."

@ncapito
Can you please fetch Azure account logs as per above comment?
@cpirtea-bun
Please verify if you've added this in settings.json (as I mentioned above: https://github.com/microsoft/azuredatastudio/issues/22227#issuecomment-1460715233, https://github.com/microsoft/azuredatastudio/issues/22227#issuecomment-1460610800
If that's done and issue persists, please enable detailed logs and upload logs here.

@cheenamalhotra will upload logs.
Just wanted to mention I installed the insider build and same outcome, however if I switch back to ADAL I get: Error: certificate has expired

Hi Everyone!
Same problem here!

[Error]: MSAL: Error requesting auth code - [{"errorCode":"endpoints_resolution_error","errorMessage":"Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration","subError":"","name":"ClientAuthError"}]

css/common.css:1          Failed to load resource: net::ERR_FILE_NOT_FOUND
log.ts:313   ERR [Microsoft.mssql]: Menu item references a command mssql.newServerRole which is not defined in the 'commands' section.
log.ts:313   ERR [Microsoft.mssql]: Menu item references a command mssql.newDatabaseRole which is not defined in the 'commands' section.
log.ts:313   ERR [Microsoft.mssql]: Menu item references a command mssql.newApplicationRole which is not defined in the 'commands' section.
console.ts:137 [Extension Host] Initialized Azure account extension storage. (at c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\dist\extension.js:2:904820)
console.ts:137 [Extension Host] logFile for MicrosoftSqlToolsServiceLayer.exe is c:\Users\cpirtea\AppData\Roaming\azuredatastudio\logs\20230309T091345\exthost1\Microsoft.mssql\sqltools.log (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072336))
console.ts:137 [Extension Host] This process (ui Extension Host) is pid: 5792 (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072388))
console.ts:137 [Extension Host] Old log files deletion report: {} (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072477))
console.ts:137 [Extension Host] logFile for MicrosoftSqlToolsCredentials.exe is c:\Users\cpirtea\AppData\Roaming\azuredatastudio\logs\20230309T091345\exthost1\Microsoft.mssql\credentialstore.log (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072336))
console.ts:137 [Extension Host] This process (ui Extension Host) is pid: 5792 (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072388))
console.ts:137 [Extension Host] Old log files deletion report: {} (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072477))
console.ts:137 [Extension Host] logFile for SqlToolsResourceProviderService.exe is c:\Users\cpirtea\AppData\Roaming\azuredatastudio\logs\20230309T091345\exthost1\Microsoft.mssql\resourceprovider.log (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072336))
console.ts:137 [Extension Host] This process (ui Extension Host) is pid: 5792 (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072388))
console.ts:137 [Extension Host] Old log files deletion report: {} (at t.getCommonLaunchArgsAndCleanupOldLogFiles (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\mssql\dist\main.js:2:1072477))
console.ts:137 [Extension Host] Initializing stored accounts [] (at t.AzureAccountProvider._initialize (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\dist\extension.js:2:524730))
mainThreadExtensionService.ts:79 [[object Object]]Unexpected token < in JSON at position 0
$onExtensionRuntimeError @ mainThreadExtensionService.ts:79
mainThreadExtensionService.ts:80 SyntaxError: Unexpected token < in JSON at position 0
at JSON.parse ()
at IncomingMessage. (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\node_modules@azure\msal-node\dist\msal-node.cjs.development.js:321:22)
at IncomingMessage.emit (node:events:538:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:80
mainThreadExtensionService.ts:79 [[object Object]]Unexpected token < in JSON at position 0
$onExtensionRuntimeError @ mainThreadExtensionService.ts:79
_doInvokeHandler @ rpcProtocol.ts:475
_invokeHandler @ rpcProtocol.ts:460
_receiveRequest @ rpcProtocol.ts:374
_receiveOneMessage @ rpcProtocol.ts:296
(anonymous) @ rpcProtocol.ts:161
invoke @ event.ts:575
deliver @ event.ts:779
fire @ event.ts:740
fire @ ipc.net.ts:638
_receiveMessage @ ipc.net.ts:958
(anonymous) @ ipc.net.ts:831
invoke @ event.ts:575
deliver @ event.ts:779
fire @ event.ts:740
acceptChunk @ ipc.net.ts:382
(anonymous) @ ipc.net.ts:338
L @ ipc.net.ts:60
emit @ node:events:526
addChunk @ node:internal/streams/readable:315
readableAddChunk @ node:internal/streams/readable:289
Readable.push @ node:internal/streams/readable:228
onStreamRead @ node:internal/stream_base_commons:190
mainThreadExtensionService.ts:80 SyntaxError: Unexpected token < in JSON at position 0
at JSON.parse ()
at IncomingMessage. (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\node_modules@azure\msal-node\dist\msal-node.cjs.development.js:321:22)
at IncomingMessage.emit (node:events:538:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
$onExtensionRuntimeError @ mainThreadExtensionService.ts:80
_doInvokeHandler @ rpcProtocol.ts:475
_invokeHandler @ rpcProtocol.ts:460
_receiveRequest @ rpcProtocol.ts:374
_receiveOneMessage @ rpcProtocol.ts:296
(anonymous) @ rpcProtocol.ts:161
invoke @ event.ts:575
deliver @ event.ts:779
fire @ event.ts:740
fire @ ipc.net.ts:638
_receiveMessage @ ipc.net.ts:958
(anonymous) @ ipc.net.ts:831
invoke @ event.ts:575
deliver @ event.ts:779
fire @ event.ts:740
acceptChunk @ ipc.net.ts:382
(anonymous) @ ipc.net.ts:338
L @ ipc.net.ts:60
emit @ node:events:526
addChunk @ node:internal/streams/readable:315
readableAddChunk @ node:internal/streams/readable:289
Readable.push @ node:internal/streams/readable:228
onStreamRead @ node:internal/stream_base_commons:190

Thank you for the logs.
[Error]: MSAL: Error requesting auth code -
[{
    "errorCode":"endpoints_resolution_error",
    "errorMessage":"Error: could not resolve endpoints. Please check network and try again.
        Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints.
        Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration",
    "subError":"",
    "name":"ClientAuthError"
}]

About this error, I recall seeing that when I was implementing MSAL support in vscode-mssql extension, that I also reported here: https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/4879 but hadn't seen that in ADS yet. Now it makes me think if it's related to some other factors too. I'm going to try updating to latest MSAL.js v1.16.0 if that helps resolve this issue, as it seems to contain a proper fix.
onExtensionRuntimeError @ mainThreadExtensionService.ts:79
mainThreadExtensionService.ts:80 SyntaxError: Unexpected token < in JSON at position 0
  at JSON.parse ()
  at IncomingMessage. (c:\Users\cpirtea\AppData\Local\Programs\Azure Data Studio - Insiders\resources\app\extensions\azurecore\node_modules@azure\msal-node\dist\msal-node.cjs.development.js:321:22)
  at IncomingMessage.emit (node:events:538:35)
  at endReadableNT (node:internal/streams/readable:1345:12)
  at process.processTicksAndRejections (node:internal/process/task_queues:83:21)
  $onExtensionRuntimeError @ mainThreadExtensionService.ts:80

This seems related to a corrupted cache file leading to runtime error in MSAL, can you please try deleting cache file:
C:\Users\~\AppData\Roaming\azuredatastudio\Azure Accounts\azureTokenCacheMsal-azure_publicCloud (Windows)
or /Users/~/Library/Application Support/azuredatastudio/Azure Accounts/azureTokenCacheMsal-azure_publicCloud (Mac OS)

I deleted the cache and same error appeared

Just looking at the code the error comes from parsing the response so it should have anything to do with the cache.

After you update to latest MSAL do I wait for next insider build?

Yes, it'll be available in the next update.

We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.

In case this is still needed.
Here was the first log from adding account using ADAL.
2-Azure Accounts.log
Here is the log from the MSAL
2-Azure Accounts.log

I am also seeing this behaviour using Azure Data Studio v1.41.2.

Yes, it'll be available in the next update.

Just FYI, MSAL-Node update needs more work in insiders and has been postponed, but we're actively investigating on issues with the stable release.

Yes, it'll be available in the next update.

Hotfix or May release?

Hi everyone,
MSAL should be working now, however, we're investigating ADAL related issues.
Would request you to please try adding accounts using the MSAL library and let us know if you're still blocked due to any reason. Please upload logs if you're still blocked, and we can take a look. We don't anticipate a hotfix for this issue, as this was related with the AAD backend.

Hi everyone,
MSAL should be working now, however, we're investigating ADAL related issues.
Would request you to please try adding accounts using the MSAL library and let us know if you're still blocked due to any reason. Please upload logs if you're still blocked, and we can take a look. We don't anticipate a hotfix for this issue, as this was related with the AAD backend.

Still blocked. Error output:
[Error]: MSAL: Error requesting auth code - [{"errorCode":"endpoints_resolution_error","errorMessage":"Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration","subError":"","name":"ClientAuthError"}]
[Error]: Login failed: Error: error - []
[Error]: {
  "originalMessage": "Error requesting auth code",
  "originalException": {
    "errorCode": "endpoints_resolution_error",
    "errorMessage": "Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration",
    "subError": "",
    "name": "ClientAuthError"
  }
} - []

1-Azure Accounts.log

Could you try adding account with Device Code authentication method?
Since this is an MSAL issue https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/4879 I'll resume on updating MSAL library.

Could you try adding account with Device Code authentication method? Since this is an MSAL issue AzureAD/microsoft-authentication-library-for-js#4879 I'll resume on updating MSAL library.

Still erroring:
[Error]: Login failed: ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration - []
[Error]: ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration - []

I am having the exact same issue. I tried all the above steps and nothing has worked.

Here is the azure accounts log:
1-Azure Accounts.log
I am on a Mac and by accident removed the credentials and not I cannot re-add. On my Windows side, I did not remove the credentials and I can access the database just fine.

Hi @StacyCMay @jonmarkp @cpirtea-bun
The latest insiders build now contains the latest version of msal-node npm package. Could you please give it a try?
https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main-branch

Hi @StacyCMay @jonmarkp @cpirtea-bun
The latest insiders build now contains the latest version of msal-node npm package. Could you please give it a try? https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main-branch

Same issue:

Hi @StacyCMay @jonmarkp @cpirtea-bun
The latest insiders build now contains the latest version of msal-node npm package. Could you please give it a try? https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main-branch

Same issue:  [Error]: Login failed: ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/organizations/v2.0/.well-known/openid-configuration - []

Version I am using :
Version: 1.43.0-insider
Commit: c163830bc4611af6c01458e7f5bd8f2546c4f523
Date: 2023-03-10T06:30:09.688Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.3.0

Can you upload the complete verbose Azure Account log with latest version?

Can you upload the complete verbose Azure Account log with latest version - starting with [Verbose]: Starting login - []

1-Azure.Accounts.log

It appears this is also related with the error reported above with ADAL:
[Error]: [Fri, 10 Mar 2023 17:26:49 GMT]<EMAIL_ADDRESS>: Error - A non-MSALJS error was thrown while attempting to get the cloud instance discovery metadata.
Error: Error
Error Description: Error: certificate has expired - []

I see similar issues reported here:
https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/5779
https://github.com/OfficeDev/TeamsFx/issues/7995
They look beyond the scope of Azure Data Studio and are possibly related with Azure configurations.
I would recommend opening an Azure support ticket for the same with your account, as we cannot diagnose further on Azure account configurations from GitHub. It seems to be affecting a subset of customers, and not everyone. You may link this issue and other similar issues in the ticket for context.

If anyone who is impacted by this issue is able to open an Azure support ticket please reference this issue and Azure Data Studio.  This will route the incident to us and allow us to look at backend service telemetry for the auth requests and engage with the AAD team.  Thanks!

I would recommend opening an Azure support ticket for the same with your account, as we cannot diagnose further on Azure account configurations from GitHub. It seems to be affecting a subset of customers, and not everyone. You may link this issue and other similar issues in the ticket for context.

I just re-ran the test with the new build and i can confirm i got a similar error.  Just to make sure I'm tracking you all want us to file a ticket in Azure Support about this issue.
My Error was:
[Verbose]: MsalCachePluginProvider: Using cache path /Users/ncapito/Library/Application Support/azuredatastudio/Azure Accounts and serviceName azureTokenCacheMsal-azure_publicCloud - []
[Verbose]: Starting login - []
[Verbose]: Fetching token for tenant {0} - ["common"]
[Error]: Login failed: Error: certificate has expired - []
[Error]: Error: certificate has expired - []

@ncapito Hi yes that's correct, please open an Azure Support ticket - our team (Azure Data Studio) is under Azure SQL DB.

@ncapito if possible, it would be helpful to have an Azure Support case for this, so we can get details on the user identities and times of the auth attempts (to try to correlate with errors in the service telemetry).  And to be able to request more detailed logs that we can't collect over GitHub due to potential for PII data.

Hi everyone,
I've learned from an internal thread, v1.39.1 of ADS seems to work in this use-case, can someone who's affected confirm the same? If it does, you may use the same to stay unblocked, while we continue with investigations.

Hi everyone,
I've learned from an internal thread, v1.39.1 of ADS seems to work in this use-case, can someone who's affected confirm the same? Also please try with v1.40.2 as that would be useful for us to diagnose the problem. If it does, you may use the same to stay unblocked, while we continue with investigations.

1.39.1 works, but 1.40.2 does not. The error logs from 1.40.2 are:
[Verbose]: Starting login - []
[Error]: Login failed - []
[Error]: Error: certificate has expired - []

Hi everyone,
Would request you to try out the VSCode-MSSQL extension: v1.18.0 Release Candidate to help us validate if Azure MFA authentication works here in your environment.
The extension supports MSAL (default) and ADAL library switching with configuration:
    "mssql.azureAuthenticationLibrary": "MSAL"

To connect, you can run command: mssql.connect or open a new Connection in 'Connections' view.

I'm assuming you would like me to try this out with version 1.42.2 of ADS?

Works like a charm!

Quick update.  I did file a ticket with Azure Support.  I will let you know once i hear back from them.
I'm using visual studio code versions are below but both failed for me (MSAL and ADAL).  It looks like the same error.

=
VS Code Version:
Version: 1.76.1
Commit: 5e805b79fcb6ba4c2d23712967df89a089da575b
Date: 2023-03-08T16:32:09.831Z (2 days ago)
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.3.0
Sandboxed: No

Hi everyone,
I've learned from an internal thread, v1.39.1 of ADS seems to work in this use-case, can someone who's affected confirm the same? Also please try with v1.40.2 as that would be useful for us to diagnose the problem. If it does, you may use the same to stay unblocked, while we continue with investigations.

1.39.1 works, but 1.40.2 does not. The error logs from 1.40.2 are:

Same thing here. 1.39.1 works, 1.40.2 does not.

@cheenamalhotra  i found another work around.  I disabled this setting "System Certificates".

Once i did that i was able to authorize using ADAL and MSL

Interesting! Could you also test with the latest insiders build and let us know if that helps in this case?

Good morning, I can confirm that unticking the system certificates solved the issue in both Production and the latest Insider build. Reticking the box causes the issue to come back.
Version: 1.43.0-insider
Commit: ef99e67cfe16ba993ccec2de266c5f973492e5de
Date: 2023-03-14T05:34:10.238Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.3.0
and
Version: 1.41.2
Commit: 0f0960d0e774e1ce903b79378addff96117c27a6
Date: 2023-02-08T20:15:24.215Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.3.0

Confirmed here as well. Unchecking System Certificates setting works in 1.41.2

@ncapito if possible, it would be helpful to have an Azure Support case for this, so we can get details on the user identities and times of the auth attempts (to try to correlate with errors in the service telemetry). And to be able to request more detailed logs that we can't collect over GitHub due to potential for PII data.

What would you like me to ask Azure to do?  They are asking me to do some random stuff, i would like to help guide the convo.

Hi @ncapito
It does seem like a certificate is involved when this error occurs, if you could investigate which certificate is contributing to this error with Azure support that would be helpful.

Unchecking Http: System Certs and switching to ADAL default connection works for me.

It's strange, since others were able to unblock with MSAL too..
Could you also test adding account with VSCode-MSSQL extension in VS Code as well? You can find Azure related logs in the bottom Output pane: Azure Logs when using extension.

Please attach any errors that you notice when adding account.

Hi Everyone,
We were able to find the expired Trusted Root Certificate Authority that caused this issue with one of the affected customers.

You can navigate to: "Manage Computer Certificates" > Trusted Root Certification Authorities > Certificates
Find the DigiCert certificate expired on March 8, 2023, e.g. "DigiCert SHA2 Secure Server CA"

It's likely that due to organization policies this certificate wasn't updated in your case. You can find more info in the article from DigiCert: https://knowledge.digicert.com/generalinformation/digicert-root-and-intermediate-ca-certificate-updates-2023.html (March 8, 2023, ICA/Root Replacements) - that explains how the issue started on March 8, 2023.
You would likely need to install the updated DigiCert Trusted Root CA Certificates. Please contact your organization or DigiCert support for official guidance on the same.

I will proceed to close the issue as external.

@cheenamalhotra  I work somewhere where we have relatively loose controls around this.  I've experience this in Azure Data Studio and VS code (today).  I'm not understanding how this is an organizational issue.  Do you have instructions or guidance on how i can check this on a mac?


Missing data type combinations on Intersection analysis

[ ] Polygons and Polygons
[ ] Lines and Polygons
[ ] Lines and Lines.

Actually we support any kind of geometry for this analysis. Please, could you explain a little bit that?

Not on the UI


decimal precision

2000000000d100 roundtrips as 2.000000000d+109 within the event suite.
This is destructive.

http://amzn.github.io/ion-docs/docs/decimal.html
Before converting to the decimal data model tuple (which is used to determine equivalence), the decimals are normalized according to the following:

If the decimal-part included a decimal point the exponent is then reduced by the count of digits following the decimal point (which may be zero) and the decimal point is removed.

So, nothing happens to<PHONE_NUMBER>d100, but 2.000000000d+109 is converted to<PHONE_NUMBER>d100. Therefore, they are equivalent representations.


Object inherit list

solving #19
and maybe solving #20
and #16
this includes the explicit type parsing from #18 as well.

I think this is just taste, but I really don't like these make_Class functions. It looks really unpythonic. And the monkeypatching of a namedtuple.
If I find time tomorrow, I will open a pull request to this branch with an Idea how it could look.
One thing I don't get after briefly looking into the code: Object inherits from list, but how do the subobjects end up in the list?
Should't an object fill its own items at creation?

One thing I don't get after briefly looking into the code: Object inherits from list, but how do the subobjects end up in the list?
Should't an object fill its own items at creation?

I had similar thoughts yesterday and played with it a little bit. The problem I wasn't able to overcome is a duplication of the while loop, have a look.


fix #2343: Fix crash, show invalid track message instead

Fixes #2343
Changes: Added null check for track. If null, showed "Invalid Track" in Snackbar

@iamareebjamal Can you check the latest commit now? Let me know if any further changes are needed. I'm new to using github in collaboration so any help would be appreciated!


[Tutorial] Add a new monster

how to add new monster

I tried it But it couldn't find the monster.
Can it be used on  Server Flyff universe on Web browser ?

Hello, you're probably talking about the Foreground Vision Bot, right?

Navigate to "foreground_vision_bot/assets/names"
Now you need to add an image with the name of the new monster, I recommend you to take a look at the images inside this folder to see how to make the screenshot, it needs to be accurate.
Go back to "foreground_vision_bot/assets" and you will see a file called Assets.py, I suggest you to read the file and add your new monster there, following the other monsters already added.

I tried it But it couldn't find the monster.
Can it be used on Server Flyff universe on Web browser ?

Wow, I didn't know this exists. Probably doesn't work without some adjusts.

Wow, I didn't know this exists. Probably doesn't work without some adjusts.

Can you go in and test it out?


Feedback for “Variables”

I'm missing information about "Collection Environment Variables", to be more precise: The variables that one can set on the Collection Environment screen

I wonder: how to use those variables
especially: what is their relation to the Collection Settings? For example, can I use an environment variable in any of the Collection settings as input? Like

The goal of this example would be to use the apikey for the selected environment for authentication in the whole collection.
Though currently his does not seem work?

Ok, this actually works when using the variable properly like{{apikey}}in that field
Some example in the docs would be helpful


feat: The Kruskal-Katona theorem

Prove the Kruskal-Katona and Erdős–Ko–Rado theorems.
From LeanCamCombi
Co-authored-by: Bhavik Mehta<EMAIL_ADDRESS>

Annoying. Let's at least make sure this issue is logged somewhere else -
even if only on zulip - and not just in this file
On Sun, 11 Aug 2024, 23:06 Yaël Dillies, @.***> wrote:

@.**** commented on this pull request.
In Mathlib/Combinatorics/SetFamily/KruskalKatona.lean
https://github.com/leanprover-community/mathlib4/pull/15000#discussion_r1713066836
:

sdiff_nonempty.2 fun h ↦ hAB.symm $ eq_of_subset_of_card_le h hAB'.le

have disj : Disjoint (B \ A) (A \ B) := disjoint_sdiff.mono_left sdiff_subset
have smaller : max' _ hV < max' _ hU := by
obtain hlt | heq | hgt := lt_trichotomy (max' _ hU) (max' _ hV)
· rw [← compress_sdiff_sdiff A B] at hAB hBA

 cases hBA.not_lt $ toColex_compress_lt_toColex hlt hAB

· exact (disjoint_right.1 disj (max'_mem _ hU) $ heq.symm ▸ max'_mem _ _).elim
· assumption
refine hB ?_
rw [← (h₂ _ _ ⟨disj, card_sdiff_comm hAB'.symm, hV, hU, smaller⟩).eq]
exact mem_compression.2 (Or.inr ⟨hB, A, hA, compress_sdiff_sdiff _ _⟩)

+attribute [-instance] Fintype.decidableForallFintype
+
+-- TODO: There's currently a diamond
+-- import Mathlib.Data.Fin.Basic
It's a bit of a mix since it goes through LinearOrder.liftWithOrd which
is in mathlib, but the original sin is that instDecidableEqFin does not
agree with decidable_of_iff, and both of these are in core
—
Reply to this email directly, view it on GitHub
https://github.com/leanprover-community/mathlib4/pull/15000#discussion_r1713066836,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHESIOUVABVCSC3UDCFI4VLZQ7N6PAVCNFSM6AAAAABLHQ6LVOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMZRHA4TQNZYGM
.
You are receiving this because you commented.Message ID:
@.***>

bors r+
Just in case,
bors d+


Dropping empty map takes time proportional to capacity

We currently iterate over the map on drop:
https://github.com/rust-lang/hashbrown/blob/efbd03661fc9df0e594ecc89784107353cc71060/src/raw/mod.rs#L1194-L1195
And the iterator iterates over all the buckets, even if it knows there are no more items (RawIter::items == 0):
https://github.com/rust-lang/hashbrown/blob/efbd03661fc9df0e594ecc89784107353cc71060/src/raw/mod.rs#L1401-L1402
This means that code like this will unnecessarily take fairly long:
let map: HashMap<String, String> = HashMap::with_capacity(1024 * 1024);
drop(map);

The above is a little contrived, but the same occurs if the caller calls drain or clear, and then drops the map. Not sure if this is something we want to optimize for, but the fix is fairly straightforward.

I suppose this is mitigated by the fact that we iterate over the control bytes, not the actual buckets, so we're iterating through many buckets at once. Even so, it seems like it'd be nice to avoid this iteration altogether when we can?

I guess the places that check needs_drop could easily check if it's already empty too.

Yup: https://github.com/jonhoo/hashbrown/commit/8dd041276bb58508f11de218b4187e393aff8e4c

@jonhoo Are you going to submit that commit in a new pull request? I see that it was an incidental part of the closed PR #167, but that was not included in the replacement PR #175.

@cuviper Ah, good call! Submitted as #182.


[Dubbo-4323]fix use AtomicInteger instead of volatile to inc

Signed-off-by: slievrly<EMAIL_ADDRESS>What is the purpose of the change
[Dubbo-4323] fix use AtomicInteger instead of volatile to inc
fix #4323
Brief changelog
use AtomicInteger instead of volatile to inc
Verifying this change
ci
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4324 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #4324      +/-   ##
============================================
- Coverage     62.93%   62.89%   -0.04%
+ Complexity      506      504       -2
============================================
  Files           769      769
  Lines         32995    32995
  Branches       5215     5215
============================================
- Hits          20765    20753      -12
- Misses         9831     9838       +7
- Partials       2399     2404       +5

Impacted Files
Coverage Δ
Complexity Δ

...ache/dubbo/cache/support/expiring/ExpiringMap.java
40.35% <100%> (ø)
0 <0> (ø)
:arrow_down:

.../remoting/transport/netty4/NettyServerHandler.java
61.9% <0%> (-9.53%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
0% <0%> (ø)

...exchange/support/header/HeaderExchangeHandler.java
64.75% <0%> (-2.46%)
0% <0%> (ø)

...ache/dubbo/registry/multiple/MultipleRegistry.java
62.67% <0%> (-1.41%)
20% <0%> (-2%)

...pache/dubbo/registry/support/AbstractRegistry.java
80.07% <0%> (-1.15%)
0% <0%> (ø)

.../exchange/support/header/HeaderExchangeServer.java
66.98% <0%> (-0.95%)
0% <0%> (ø)

...g/apache/dubbo/registry/consul/ConsulRegistry.java
59.6% <0%> (-0.67%)
27% <0%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3a05c...24c7038. Read the comment docs.

@lixiaojiee


chore(build): upgrade Go to 1.20.10

https://github.com/influxdata/edge/issues/520

Approving, but can you also address HTTP/2 rapid reset can cause excessive work in net/http for golang.org/x/net which is for the same issue?
$ go mod why -m golang.org/x/net
# golang.org/x/net
github.com/influxdata/kapacitor/services/azure
github.com/prometheus/common/config
golang.org/x/net/http2

I actually approved https://github.com/influxdata/kapacitor/security/dependabot/29 and merged it.


gshell code - throwing error message

Hello.
Every time I try to execute the init command switch for gshell, I get the following error:
cleitols@os:~$ gshell init
Traceback (most recent call last):
File "/usr/local/bin/gshell", line 8, in
sys.exit(main())
File "/home/cleitols/.local/lib/python3.9/site-packages/gshell/init.py", line 443, in main
cli()
File "/usr/lib/python3/dist-packages/click/core.py", line 829, in call
return self.main(*args, **kwargs)
File "/usr/lib/python3/dist-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/usr/lib/python3/dist-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python3/dist-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3/dist-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/home/cleitols/.local/lib/python3.9/site-packages/gshell/init.py", line 125, in cmd_init
config_dir = init(name)
File "/home/cleitols/.local/lib/python3.9/site-packages/gshell/init.py", line 54, in init
init_config()
File "/home/cleitols/.local/lib/python3.9/site-packages/gshell/init.py", line 92, in init_config
home_id = _get_home_id()
File "/home/cleitols/.local/lib/python3.9/site-packages/gshell/init.py", line 84, in _get_home_id
parent_id = lines[1][start:end].strip()
IndexError: list index out of range

Probably it is due to a broken ~/.gshell file. The solution would be rm -f ~/.gshell

rm -f ~/.gshell

Tried to delete the file, but doesn't seem to be the reason yet.
I also tried to run the command as sudo and it went a little better, but the same error above is shown:
cleitols@os:~$ sudo gshell init
[sudo] password for cleitols:
Initializing system (/root/.gdrive)
Authentication needed
Go to the following url in your browser:
https://accounts.google.com/o/oauth2/auth?access_type=offline&client_id=367116221053-7n0vf5akeru7on6o2fjinrecpdoe99eg.apps.googleusercontent.com&redirect_uri=urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob&response_type=code&scope=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdrive&state=state
Enter verification code: ****
User: ****
Used: 300.5 MB
Free: 15.8 GB
Total: 16.1 GB
Max upload size: 5.2 TB
Traceback (most recent call last):
File "/usr/local/bin/gshell", line 8, in
sys.exit(main())
File "/usr/local/lib/python3.9/dist-packages/gshell/init.py", line 443, in main
cli()
File "/usr/lib/python3/dist-packages/click/core.py", line 829, in call
return self.main(*args, **kwargs)
File "/usr/lib/python3/dist-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/usr/lib/python3/dist-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/lib/python3/dist-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3/dist-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/gshell/init.py", line 125, in cmd_init
config_dir = init(name)
File "/usr/local/lib/python3.9/dist-packages/gshell/init.py", line 54, in init
init_config()
File "/usr/local/lib/python3.9/dist-packages/gshell/init.py", line 92, in init_config
home_id = _get_home_id()
File "/usr/local/lib/python3.9/dist-packages/gshell/init.py", line 84, in _get_home_id
parent_id = lines[1][start:end].strip()
IndexError: list index out of range

Potentially this is because you don't have anything under your gdrive folder.
You can try to print the cmd and stdout in /usr/local/lib/python3.9/dist-packages/gshell/init.py to debug it.


Ability to sort and/or group shelves

Describe the feature you'd like
I would like to see some control over how shelves are sorted, other than the existing alphabetical or creation date.
Describe the benefits this would bring to existing BookStack users
For many of us, shelves are not quite broad enough for categorization. Reasonable people could disagree about how effective it is to broaden the shelf concept (i.e. as with school libraries- where you may have a Bio/Sci library, a Poly Sci library etc) to limit shelves, vs having more broad Shelf content (where a Shelf might end up with books that arent all that closely related in some cases). But for many of us, we are using Bookstack for research data compilation, or business info etc, where it would be convenient to display certain shelves first (where they represent a major project, or something less generic than other shelves (which may contain archive/reference info etc).
It seems to me that since there is already a method which permits sort based on creation date, the idea of forcing the sort as alphabetical is permitted an exception. And while I see less upside in sorting by creation date, its just an option available to users who may need it. Im thinking it wouldnt be so difficult to add, say, a list order value to the Chapter properties. Or perhaps a Group order would be even better, where if you want to be sure that, say, a parent entity is always shown first, it is Group A. If there are multiple other shelves that are higher priority/use, they could be group B (say, 5 of those, where the sort option would be by group, and within that, alphabetical). It adds a single 'order by' term to the query, and if there is no entry used for Group, it is simply ignored since all shelves would have equal group value...
Can the goal of this request already be achieved via other means?
I have not been able to find a way to manage this via the native capabilities of Bookstack. There isnt a provision as there is with books/chapters to set priority, and there isnt a top-level Sort option that supports anything but title (Alphabetical) or creation date. Absent an option to sort by tag or group ID, or something more native (as with books/chapters), about the only option is to use group letters as part of the title as (A) Suppliers, (B) Corporate etc. But that is an ugly workaround (not attractive, doesnt scale, where the addition of a shelf you want between A and B requires a manual cascade of changes etc.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
1 to 5 years
Additional context
No response

Thanks for the request @Extrapilot1. This is closely related to issue #180.
I'm going to update the request title to be specific to allowing manual shelf ordering since some general ordering options already exist.


Current date FG issue

I know Gradience is not supported, but is there any chance, this could be patched? I am guessing you are using a color name rather han a variable name.

I will look what CSS class to add so you can fix this using CSS overriding.

Awesome, thank you!

https://github.com/nlogozzo/NickvisionMoney/releases/tag/2023.1.0-beta3


Use palette wisely, make sure high contrast colors are presented

The palette code is sloppy, needs more precision to prevent poorly legible quotes.

This was closed by #3


refactor(styles.less): center resource switch dropdown items properly

Remove the hacky method of centering for something proper :)

Testing

Check resource switch dropdown items are centered

:tada: This PR is included in version 2.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Integrate Travis CI, add build status to README

This change introduces Travis configuration that runs go test on each new PR. The latest build status for go test on the master branch should appear in the README once Travis is activated for this repo within kubernetes-sigs.
Include the Go Report Card status in the README as well.

@Monkeyanator what are the steps required to finish this work?  Let me know if I can help push this along

/remove-lifecycle stale


Upgrade ADIOS2 to 2.10.0-rc1

Description
Resolves #19176

Updated the ADIOS2 library version to 2.10.0-rc1
Removed the dependency on C-Blosc1
Added a new dependency on C-Blosc2
Added tests and testdata for BP5 files
Added logic to determine if files are BP5 or BP4
Removed debugging options that are no longer present in the latest version of ADIOS2

Type of change

[ ] Bug fix
[x] New feature~~
[ ] Documentation update
[ ] Other

How Has This Been Tested?

Built and ran on rztopaz. The new and old tests pass.
Reminders:

Please follow the style guidelines of this project.
Please perform a self-review of your code before submitting a PR and asking others to review it.
Please assign reviewers (see VisIt's PR procedures for more information).

Checklist:

[x] I have commented my code where applicable.~~
[x] I have updated the release notes.~~
[ ] I have made corresponding changes to the documentation.
[ ] I have added debugging support to my changes.
[x] I have added tests that prove my fix is effective or that my feature works.~~
[x] I have confirmed new and existing unit tests pass locally with my changes.~~
[x] I have added new baselines for any new tests to the repo.~~
[x] I have NOT made any changes to protocol or public interfaces in an RC branch.~~

I think this will fail CI while the ADIOS2 version in our container is out of date: /masonry/build-mb-develop-ci-smoke/thirdparty_shared/third_party/adios2-ser/2.7.1/ci/lib

Thanks Justin!

Thanks for your quick review and good feedback!

Merge w/ develop in #19251


Add new field type to influx_stress

I needed a simple way to create two series at differing orders of magnitude so I added a new ranged field type to influx_stress.

@mjdesa is about to overhaul this tool completely, so you may need to wait.

OK, that's fine, I am using it locally and that is good enough for now.

Closing will use new version


Support go1.19

Have some runtime failure with go1.19
==> Testing v2ray-plugin
panic: panic: qtls.CertificateRequestInfo doesn't matchqtls.CertificateRequestInfo doesn't match

goroutine
1 [running]:

goroutine 1 [running]:
github.com/marten-seemann/qtls-go1-16.init.0()
	github.com/marten-seemann/qtls-go1-16@v0.1.3/unsafe.go:17github.com/marten-seemann/qtls-go1-16.init.0 +(0x190)

	github.com/marten-seemann/qtls-go1-16@v0.1.3/unsafe.go:17 +0x190

Same with go1.18
relates to https://github.com/Homebrew/homebrew-core/pull/110036

needs quic-go upgrade.

Yes, it's a good idea to upgrade to go1.19 since the current stable versions are only go 1.19.1 & 1.18.6, others (including go1.16) are archived (AKA not stable).
Golang archived versions are not maintained versions especially secure updates.


Deleted use of non-existing RESET register. Only present in nRF51 dev…

As can be seen in the nRF52 specifications (can be found at http://infocenter.nordicsemi.com/index.jsp) POWER.RESET register does not exist in nRF52.

Reason for closing?

Even though the pull is correct, pin reset in nRF52 and nRF51 is not working properly. I will provide a new pull today with more changes.


ci: Test against 3.9,  3.10 and 3.11

I wanted to know if this library supports 3.10 as the setup.py says no but some issues indicated that it does work. Thought it would be good to have tests for this.
Also updated the test workflow with concurrency control, i.e. cancel previous workflows for a branch if there's a new commit, update the action versions, prevent test duplications and finally enable manual action dispatch Actions -> Workflow -> Manual Dispatch.
I also added tests to see if it works on windows and mac, normally something will go wrong when trying other systems so we can remove them if they fail, just wanted to see...
Update: Windows and Mac both fail due to trying to compile pyrfr and swig. Also fails for linux 3.11, I've removed these so the only versions tested are linux 3.9/3.10.

Rebased to current development and updated the 3.9/3.10 stuff


[LightGBM] [Fatal] Check failed: num_leaves >1 at c:\users\public\documents\estsoft\creatortemp\rtmpiznjuy\lightgbm\lightgbm_r\src\src\io\config_auto.cpp, line 281 .

Environment info
Operating System: Windows 10
CPU/GPU model: Ryzen 3 2200g
C++/Python/R version: R 3.5.1
Error message
[LightGBM] [Fatal] Check failed: num_leaves >1 at c:\users\public\documents\estsoft\creatortemp\rtmpiznjuy\lightgbm\lightgbm_r\src\src\io\config_auto.cpp, line 281 .
Reproducible examples
num_sam <- round(length(dt_label) * .7)
train_dt <- dt[1:num_sam,]
train_label <- dt_label[1:num_sam]
test_data <- dt[-(1:num_sam),]
test_labels <- dt_label[-(1:num_sam),]
grid_search <- expand.grid(Depth = 2:3,
L2 = 0:3)
model <- list()
perf <- numeric(nrow(grid_search))
dtrain <- lgb.Dataset(train_dt, label = train_label, free_raw_data = FALSE)
dtest <- lgb.Dataset.create.valid(dtrain, test_data, label = test_labels)
valids <- list(test = dtest)
for (i in 1:nrow(grid_search)) {
model[[i]] <- lgb.train(list(objective = "tweedie",
metric = "l2",
lambda_l2 = grid_search[i, "L2"],
max_depth = grid_search[i, "Depth"]),
dtrain,
2,
valids,
min_data = 1,
learning_rate = 1,
early_stopping_rounds = 5)
perf[i] <- min(rbindlist(model[[i]]$record_evals$test$l2))
}
Steps to reproduce
The features of test_set and train_set are totally equal. How can I deal with this issue?
@Laurae2
@BruceZhaoR
@guolinke

I solved this issue by changing values.


A little optimization in a function if the client is closing.

@Anubisss, mind rebasing with master so I can see the results of the test run on this branch.

thanks for the contribution.


brigade runs on github pushes

On pushes to Github, tests run in CI (brigade)

ng lint
ng test
ng e2e

@technosophos would be awesome to get an assist setting brigade up for kashti. cc @flynnduism @radu-matei


Additional DIV over the SVG

Hello,
i have code in project like this
<ReactSVG path={imagePath} className="mobile-service-box__contact-icon"/>;
but the result is wrapped in two DIVs why is that ? i dont want these DIVs

<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="Capa_1" x="0px" y="0px" width="216px" height="146px" viewBox="0 0 216 146" enable-background="new 0 0 216 146" xml:space="preserve" class="injected-svg mobile-service-box__contact-icon" data-src="/content/dam/svg/microphone28.svg"> <g> 	<path d="M108,99.07c7.17,0,13.307-2.553,18.412-7.657S134.07,80.17,134.07,73V31.286c0-7.17-2.551-13.307-7.658-18.413   C121.307,7.768,115.17,5.214,108,5.214s-13.307,2.554-18.413,7.659s-7.659,11.243-7.659,18.413V73   c0,7.17,2.554,13.309,7.659,18.413S100.83,99.07,108,99.07z"></path> 	<path d="M153.38,58.905c-1.03-1.032-2.254-1.548-3.666-1.548s-2.634,0.516-3.666,1.548c-1.032,1.032-1.548,2.254-1.548,3.666V73   c0,10.049-3.572,18.643-10.714,25.786C126.645,105.929,118.049,109.5,108,109.5s-18.644-3.571-25.787-10.714   C75.071,91.645,71.5,83.049,71.5,73V62.571c0-1.412-0.516-2.634-1.548-3.666c-1.032-1.032-2.253-1.548-3.666-1.548   s-2.635,0.516-3.667,1.548c-1.032,1.032-1.548,2.254-1.548,3.666V73c0,12.004,4.006,22.446,12.017,31.326   c8.011,8.88,17.91,13.972,29.697,15.275v10.756H81.928c-1.412,0-2.634,0.516-3.666,1.548c-1.032,1.032-1.548,2.254-1.548,3.666   c0,1.411,0.516,2.635,1.548,3.666c1.032,1.032,2.254,1.549,3.666,1.549h52.142c1.412,0,2.636-0.517,3.666-1.549   c1.033-1.031,1.55-2.255,1.55-3.666c0-1.412-0.517-2.634-1.55-3.666c-1.03-1.032-2.254-1.548-3.666-1.548h-20.855v-10.756   c11.785-1.303,21.684-6.395,29.696-15.275c8.012-8.88,12.019-19.322,12.019-31.326V62.571   C154.93,61.159,154.413,59.938,153.38,58.905z"></path> </g> </svg>

Hi @JurajLigo this has been answered a few times already, see here.


[#14885] World Switcher - Pin favourite worlds to the top of the panel

This change resolves  #14885 by splitting the World Switcher panel into 2 JScrollPanes - a pane for favourite worlds and a pane for the rest.
The favourite world pane will grow to fit 10 worlds, then a scroll bar appears after that.
The other pane fills the rest of the panel space.
There's a 12 px gap under the favourite worlds pane, so that they're seperated from the rest of the worlds.

I won't comment on whether this is a user interface we should change, but...
The two sections in your screenshot don't really look visually distinct enough, I'm sure this would confuse some users who don't notice the gap. I think it would help to include the sorting headers in both panels so they visually appear as separate tables.

I won't comment on whether this is a user interface we should change, but...
The two sections in your screenshot don't really look visually distinct enough, I'm sure this would confuse some users who don't notice the gap. I think it would help to include the sorting headers in both panels so they visually appear as separate tables.

Should the 2 sections be individually sortable or should each header sort both sections?

Here's a new screenshot of how it looks with 2 headers:

I feel like a search bar could be useful but probably wants to be implemented in a seperate PR, maybe make an issue for it?

The panel just looks too busy with two headers there.
Would it be worth making the header stick to the top of the pane and not move when you scroll down, along with the worlds you've set as favs.
Might mean the whole panel needs some reworking though

The panel just looks too busy with two headers there.
Would it be worth making the header stick to the top of the pane and not move when you scroll down, along with the worlds you've set as favs.
Might mean the whole panel needs some reworking though

That’s how I had it initially 😆

The panel just looks too busy with two headers there.
Would it be worth making the header stick to the top of the pane and not move when you scroll down, along with the worlds you've set as favs.
Might mean the whole panel needs some reworking though

That’s how I had it initially 😆

I've had a quick play around with the plugin layout and came up with this so far
(New on the left, old on the right)

The header up the top is 'sticky' so when a user scrolls down the header stays visible, there are a two ways that I think we could go from here, have the world favourites also be 'sticky' below the header so that they are always visible to the user, or not be sticky and just stay up the top like the currentl behaviour.
I think regardless if they are sticky or not they need to have something to differentiate them from non-favourited worlds. Thoughts?

The panel just looks too busy with two headers there.
Would it be worth making the header stick to the top of the pane and not move when you scroll down, along with the worlds you've set as favs.
Might mean the whole panel needs some reworking though

That’s how I had it initially 😆

I've had a quick play around with the plugin layout and came up with this so far
(New on the left, old on the right)
The header up the top is 'sticky' so when a user scrolls down the header stays visible, there are a two ways that I think we could go from here, have the world favourites also be 'sticky' below the header so that they are always visible to the user, or not be sticky and just stay up the top like the currentl behaviour.
I think regardless if they are sticky or not they need to have something to differentiate them from non-favourited worlds. Thoughts?

The ticket that this relates to (#14885) specifies pinning both the header and favourite worlds to the top of the panel.
@drawkel what do you think?

Yeah that looks like what I was thinking! I do agree that having both headers being 'sticky' at the top would be a bit bulky. Maybe having the favourited worlds 'stick' on the bottom instead (similar to how the in-game UI's World Switcher looks) with the option to toggle in the settings!
Just a thought, if not, the revised way with the top header sticking already looks awesome :)

A few bugs to iron out, but I think something like this would be a good improvement.

Wow, that looks amazing! :)

I’ve started playing around with sticky world favs.
Will post some screenshots later
On Sun, 19 Jun 2022 at 8:56 am, Carlisle Shaw @.***>
wrote:

Yeah that looks like what I was thinking! I do agree that having both
headers being 'sticky' at the top would be a bit bulky. Maybe having the
favourited worlds 'stick' on the bottom instead (similar to how the in-game
UI's World Switcher looks) with the option to toggle in the settings!
Just a thought, if not, the revised way with the top header sticking
already looks awesome :)
—
Reply to this email directly, view it on GitHub
https://github.com/runelite/runelite/pull/15115#issuecomment-1159578358,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGQNBA26MHT5FHYRM5YEBDVPZH25ANCNFSM5Y43MJWA
.
You are receiving this because you commented.Message ID:
@.***>


dirgy, becalm

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 100
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,d]

/trunk merge


Update cpuConstraints for scheduler and apiserver

Now, the https://github.com/kubernetes/perf-tests/pull/697 has merged, the CPU usage is much less flaky. On the other hand it went up which is expected as now we more accurately measure the actual 99th percentile (see https://github.com/kubernetes/kubernetes/issues/80212#issuecomment-515010726 as an example of how bad we used to did it).
Given that we should increase some constraints and remove the old TODOs.
Justification for the values of cpuConstraints used in this PR:

scheduler - since https://github.com/kubernetes/perf-tests/pull/697 the max observed value was 0.61 CPU, setting the limit to ~20% more which is ~0.75

api-server - since https://github.com/kubernetes/perf-tests/pull/697 the max observed value was 2.3 CPU, setting the limit to ~20% more which is ~2.8

Fixes https://github.com/kubernetes/perf-tests/issues/694

/lgtm

/lgtm


Task jobs cleaning strategy

Hi ! First of all, thanks for your amazing work on implementing the TES API with a Kubernetes-based solution ! We would like to use your project and even contribute if the project is still active and if contributions are allowed and welcomed.
We were wondering what is your task jobs cleaning strategy. Do you use a custom cronjob to clean them once completed or do you have another mechanism ?
We plan to use the Kubernetes TTL Controller with the ttlSecondsAfterFinished spec property of a Job. For that, the Kubernetes Java client needs to be upgraded to the latest version. Is it something that you could be interested of ? We are ready to do a PR with that update.
Cheers !

Hi! TESK project is still active, although the code itself might move to a different place in the near future (should be fairly transparent to users/contributors). We do accept contributions. Updating the K8s client is sth I was about to do myself soon. I believe the client is not exactly backwards compatible, so some changes in the code apart from bumping the version are likely going to be necessary. You can wait for me (should be a couple of days), but I will be more than happy to accept a PR with the client update as well, if you are ready.
Jobs deletion strategy is not there at the moment. Keeping the jobs forever as K8s objects is not a long term viable option, so one solution is deleting them after some time. CronJob was considered at one point, but never made it as an official part of TESK. Adding an optional TTL for TESK Jobs is a nice solution and I would welcome a PR around it as well.
Other options that were considered is additionally adding a task delete endpoint for use cases where tasks are no longer needed after their state was retrieved and to let the clients decide.
Finally, the lack of external storage for task metadata is one of TESK features (almost no dependencies apart from K8s), which is cool for prototyping, demo installations, but adding a regular DB for task metadata to be able to store finished tasks forever/long term without impairing performance  has also been considered, but never implemented.

Hi ! We can update the K8s client. We'll push a PR for that. Regarding the TTL for jobs, we could do it once the K8s client update is merged. Is it okey for you ?
Cheers !


Add upload_csv route

This PR adds CSV upload functionality to the API client.
Unfortunately, it appears, I have the ability to completely overwrite other users tables... Not sure if this was intended. cc @msf
Tests are failing, because I assumed I would get a False success response when trying to overwrite someone else's table.
Closes #67
Remaining Question: Do we also was to update the async client? If so, it would probably need more work since it has not been kept updated like the other.

This PR adds CSV upload functionality to the API client.
Unfortunately, it appears, I have the ability to completely overwrite other users tables... Not sure if this was intended. cc @msf
Tests are failing, because I assumed I would get a False success response when trying to overwrite someone else's table.
Closes #67
Remaining Question: Do we also was to update the async client? If so, it would probably need more work since it has not been kept updated like the other.

The ability to overwrite other people's tables under dune_upload is the intended behavior. Tables cannot be overwritten if they are under users' personal namespaces (e.g. dune.bh2smith.dataset_{table_name}). We introduced personal namespaces last week. I am not sure that would be helpful in your tests

So far, it looks like just commentary on intended functionality. At the moment the implementation and tests are aligned with the intended functionality. If its not blocking, I'd think we can merge as is and adjust later as necessary.
Please let me know if there is anything that should be changed here and feel free to approve if all is good.


cross validation classification meta example

#3000 making meta for undocumented cross validation classification example. if this is okay how about we write a cookbook page?

@karlnapf does this look okay?

It does :)


WordCount modification

I've updated WordCount sample and created a bar chart to display count per partition. Fixed two bugs in the sample code, where AddCount function of stateful service was not getting fully invoked by the stateless service. Also updated stats count when a word is added to reliable queue.

Thanks Ali, looks really good! Working on merging.
@danielnord, agreed this update stats in the controller appears to be redundant, as there is a separate task that pulls operations out of the queue and updates the stats. It won't try to update on secondary replicas because secondary replicas don't listen for requests, so that should be fine.


refactor(vault): transfer worker port to app

copilot:all

Current dependencies on/for this PR:

main

PR #3024

PR #3059   👈

This comment was auto-generated by Graphite.

@wittjosiah queued this pull request to merge with Graphite.

@wittjosiah queued this pull request to merge with Graphite.


Enable NodeLocalDNSCache by default

What this PR does / why we need it:
This PR enables NodeLocalDNSCache by default.
Release note:
Enable NodeLocalDNSCache feature by default

/assign @kron4eg @alvaroaleman

/hold
until we don't test this and make the final decision

@kron4eg Done, PTAL

After a very long discussion on the KubeOne internal channel and on the planning meeting, we've decided to not continue with this. There are some problems involved with NodeLocalDNSCache, user experience, as well as that we had no chance to test this for some time before the release.
We may reconsider how we want to work with NodeLocalDNSCache in the future or for the v0.10 release cycle.
/close

Currently it's not possible to automate disabling this at later stage of cluster life. As feature is regulated by the flag, which will be changed in the future and all kubelet specific configs will use https://godoc.org/k8s.io/kubelet/config/v1beta1 API instead of flags.


Pachyderm Dashboard

We've discussed this a lot internally, but I'm making an issue so that we don't lose track of some features we want to add. If we have a concrete use case we'd like the dashboard to address, let's record those details in this issue. This will help inform the design once we tackle it.

The dashboard will be deployed alongside a cluster, and will report on cluster usage / stats, and will be a debugging tool.

One thing that came up recently was looking at the # of client connections to the cluster. (Specifically when doing a ton of PutFile()s and perhaps not closing the connections)
As one of the metrics on the dashboard, we can report on the number of client connections.

Similarly, we might want to expose the number of current connections per pod. (So increment/decrement an atomic number when we start serving a request)

Once the block groupcache lands, we should have metrics reporting on:

cache hits
cache misses
cache utilization (hit/miss ratio)
per pod
also mem consumption per pod?

There are actually some great ideas in here. Some of this seems like it's probably no longer relevant, but we should be giving this kind of feedback to help figure out how some of the more detailed tuning fields of a pipeline spec should be used. Specifically talking about resource_spec requests (and, soon, limits), parallelism_spec, scale_down_threshold, and cache_size
In general, we do an alright job of describing what these are in the pipline spec docs, but give basically zero guidance as to how/why to use them
@sjezewski I'm not sure which of the specific items listed in this issue are still relevant today. could you please create a meta-issue on the dash repo that migrates over the useful info (and link it back here for posterity)


Compilation failed

Hi, there are two errors occurred when I tried to build epic.

Is there any possible way that I can fix it?

Could you post it as string instead of image? For copy/pasting.

[error] /Users/edward/Downloads/epic-master-2/target/scala-2.11/src_managed/main/TreebankTokenizerImpl.java:7327: unclosed character literal
[error]     return currentToken(new String(zzBuffer, zzStartRead, zzMarkedPos-zzStartRead).replace('???', ''').replace('??','\u0308').replaceAll("-[\n\r]+",""));
[error]                                                                                ^
[error] /Users/edward/Downloads/epic-master-2/target/scala-2.11/src_managed/main/TreebankTokenizerImpl.java:7327: unclosed character literal
[error]     return currentToken(new String(zzBuffer, zzStartRead, zzMarkedPos-zzStartRead).replace('???', ''').replace('??','\u0308').replaceAll("-[\n\r]+",""));
[error]                                                                                ^
[error] two errors found
[error] (compile:compileIncremental) Compilation failed

the file encoding for compiling the java code is wrong. It's a UTF-8 file,
and I guess that needs to be set. You could either change your terminal's
default encoding, or do something like
javacOptions ++= Seq("-encoding", "UTF-8")
in build.sbt
-- David
On Tue, Sep 29, 2015 at 4:14 AM, freeze5272<EMAIL_ADDRESS>wrote:

[error]
/Users/edward/Downloads/epic-master-2/target/scala-2.11/src_managed/main/TreebankTokenizerImpl.java:7327:
unclosed character literal
[error] return currentToken(new String(zzBuffer, zzStartRead,
zzMarkedPos-zzStartRead).replace('???',
''').replace('??','\u0308').replaceAll("-[\n\r]+",""));
[error] ^
[error]
/Users/edward/Downloads/epic-master-2/target/scala-2.11/src_managed/main/TreebankTokenizerImpl.java:7327:
unclosed character literal
[error] return currentToken(new String(zzBuffer, zzStartRead,
zzMarkedPos-zzStartRead).replace('???',
''').replace('??','\u0308').replaceAll("-[\n\r]+",""));
[error] ^
[error] two errors found
error Compilation failed
—
Reply to this email directly or view it on GitHub
https://github.com/dlwh/epic/issues/42#issuecomment-144029307.


Timezone converting to UTC is wrong

By creating a date object using hour:20 in timezone Africa/Casablanca I expect the UTC  hour to be 19, but it's showing 20.
Demo: https://jsfiddle.net/pojt2r99/
moment.tz.add("Africa/Casablanca|LMT WET WEST CET|u.k 0 -10 -10|0121212121212121213121212121212121212121212121212121212121212121212121212121212121212121212121212121|-2gMnt.E 130Lt.E rb0 Dd0 dVb0 b6p0 TX0 EoB0 LL0 gnd0 rz0 43d0 AL0 1Nd0 XX0 1Cp0 pz0 dEp0 4mn0 SyN0 AL0 1Nd0 wn0 1FB0 Db0 1zd0 Lz0 1Nf0 wM0 co0 go0 1o00 s00 dA0 vc0 11A0 A00 e00 y00 11A0 uM0 e00 Dc0 11A0 s00 e00 IM0 WM0 mo0 gM0 LA0 WM0 jA0 e00 Rc0 11A0 e00 e00 U00 11A0 8o0 e00 11A0 11A0 5A0 e00 17c0 1fA0 1a00 1a00 1fA0 17c0 1io0 14o0 1lc0 11A0 1o00 11A0 1qM0 WM0 1qM0 WM0 1qM0 11A0 1o00 11A0 1o00 11A0 1qM0 WM0 1qM0 WM0 1qM0 WM0 1qM0 11A0 1lc0 14o0 1fA0|32e5");

    alert(moment.tz({ year: 2016, month: 6, date: 13, hour: 20 }, "Africa/Casablanca")._d.toUTCString());

By using the toDate method, that will work:
alert(moment.tz({ year: 2016, month: 6, date: 13, hour: 20 }, "Africa/Casablanca").toDate().toUTCString());

JSFiddle

@IonicaBizau we do not recommend using the JS date object with moment. Moment is a complete API and date should not be required unless you need to pass a date to a third party that expects one.
@HamzaLJ the _d variable is internal, and it will not be accurate - see documentation here: http://momentjs.com/guides/#/lib-concepts/internal-properties/
To display the date in UTC, do the following:
moment.tz({ year: 2016, month: 6, date: 13, hour: 20 }, "Africa/Casablanca").utc().format()
"2016-07-13T19:00:00Z"

For more information on this see: http://momentjs.com/docs/#/parsing/utc/
This blog post may also be helpful: https://maggiepint.com/2016/05/14/moment-js-shows-the-wrong-date/

unless you need to pass a date to a third party that expects one.

Exactly 👍
Sent from my iPhone

On 13 Jul 2016, at 23:12, Maggie Pint<EMAIL_ADDRESS>wrote:
@IonicaBizau we do not recommend using the JS date object with moment. Moment is a complete API and date should not be required unless you need to pass a date to a third party that expects one.
@HamzaLJ the _d variable is internal, and it will not be accurate - see documentation here: http://momentjs.com/guides/#/lib-concepts/internal-properties/
To display the date in UTC, do the following:
moment.tz({ year: 2016, month: 6, date: 13, hour: 20 }, "Africa/Casablanca").utc().format()
"2016-07-13T19:00:00Z"
For more information on this see: http://momentjs.com/docs/#/parsing/utc/
This blog post may also be helpful: https://maggiepint.com/2016/05/14/moment-js-shows-the-wrong-date/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Profanity list is requested every message

Have it saved once and referred to

Nah, its the best I can get it

Thanks Frank

Np Frank


bug(DragDropModule): Dropping an item triggers click event in document in Firefox only.

Reproduction
Use StackBlitz to reproduce your issue:

Components: https://stackblitz.com/edit/angular-dnd-firefox-click-ubxh75?file=src/app/cdk-drag-drop-sorting-example.ts

Steps to reproduce:

Use Firefox (latest).
Drag and drop items in the list.

Expected Behavior
What behavior were you expecting to see?
No logs should be written to console, the listener is setup for document click events.
This is working as expected in MS Edge (chromium, latest) and Google Chrome (latest)
Actual Behavior
What behavior did you actually see?
Document click events are triggered, logs are written to console.
Environment

Angular: 11.0 (11.1 still broken)
CDK/Material: 11.0 (11.1 still broken)
Browser(s): Firefox
Operating System Windows 10

The drag-drop module is set up not to mess with click events at all so this is likely a browser-level issue. If you want to prevent the event consistently across all browsers, you can add (mousedown)="$event.preventDefault()".

The drag-drop module is set up not to mess with click events at all so this is likely a browser-level issue. If you want to prevent the event consistently across all browsers, you can add (mousedown)="$event.preventDefault()".

Thanks for the swift reply. Unfortunately I can't even mend the StackBlitz reproduction example with the mousedown fix, no matter what dom level I apply it on. Resorted to pausing the click listener on body during dragging instead. 🤷♂

Thanks for the swift reply. Unfortunately I can't even mend the StackBlitz reproduction example with the mousedown fix, no matter what dom level I apply it on. Resorted to pausing the click listener on body during dragging instead. 🤷♂


TS1192: Module '"project/node_modules/numbro/numbro"' has no default export.

Hello, I'm trying to use this wonderful library with typescript but when imported it does not compile and gives me this error
TS1192: Module '"path/project/node_modules/numbro/numbro"' has no default export.
After changing the last line of the file numbro.d.ts from export = numbro into export default it compiles successfully.
After a litle bit of investigation i found that if we/you want to use es6 syntax you should explicit export default or use require('module') if you have export = module witch is our case and this breaks es6 style syntax
See https://github.com/Microsoft/TypeScript/issues/2242#issuecomment-83694181

I'm experiencing the same issue and went ahead and created a PR for this change.


0.3.0 failing when sending lcov data

Get this in 0.3.0 when sending lcov data.  Works in 0.2.1.
/home/rof/.nvm/versions/node/v0.12.0/lib/node_modules/codeclimate-test-reporter/formatter.js:64
data.forEach(function(elem, index) {
^
TypeError: Cannot read property 'forEach' of null
at Formatter.sourceFiles (/home/rof/.nvm/versions/node/v0.12.0/lib/node_modules/codeclimate-test-reporter/formatter.js:64:7)
at /home/rof/.nvm/versions/node/v0.12.0/lib/node_modules/codeclimate-test-reporter/formatter.js:33:26
at Formatter.parse (/home/rof/.nvm/versions/node/v0.12.0/lib/node_modules/codeclimate-test-reporter/formatter.js:24:9)
at Formatter.format (/home/rof/.nvm/versions/node/v0.12.0/lib/node_modules/codeclimate-test-reporter/formatter.js:31:8)
at ReadStream.<anonymous> (/home/rof/.nvm/versions/node/v0.12.0/lib/node_modules/codeclimate-test-reporter/bin/codeclimate.js:25:13)
at ReadStream.emit (events.js:129:20)
at _stream_readable.js:908:16
at process._tickCallback (node.js:355:11)

Don't think it's related to https://github.com/codeclimate/javascript-test-reporter/issues/16, my lcov file is populated.

I'm having the same issue. Downgraded to 0.2.1 and it works again.

Same issue.

@devinus @oniofchaos @laynegt Sorry about that! #34 should fix it. I just released version 0.3.1 to npm


Reminder to update for 3.3 recipes.

Basically what's in the title. Katrisa in our FC mentioned something the other day about one of the two star recipes having changed in difficulty.

  The change is in the new three star recipes at the least which have a higher difficulty level and requirements.

The Lodestone web page structure has changed, so I need to update the scraper tool first.

Can you give me an example of a recipe that has changed so I can double-check the data?

I've uploaded the latest recipes to the beta site. Let me know if there's still stuff missing.


After updating to 1.16.2 - all portals unlinked

We have just updated to 1.16.2 on our server and all portals appear unlinked now. We have quite a few portals so restoring them all is a massive undertaking.
Is this normal and is there anything we can do?

Type command /execute in  Do you see the nether and the end? If the nether and the end is missing, then the issue is probably caused by other dimension mods

I think it happened because the mods were not loaded correctly upon first launch (all mods). I have restored the old server save and all portals have returned to normal! :D
Sorry to waste your time :)


Use Cases

Here the example for the use cases
http://wiki.spdx.org/view/Technical_Team/Use_Cases/2.0

Got it.


Add windows-strings crate

This update pulls out the Windows string types from the windows-core crate and makes them available directly without a dependency on the windows or windows-core crates. This will help to make these string types more accessible to library crates such as windows-registry (#3121).
These types are still included in the windows-core and windows crates as a dependency so it should not affect existing code too much.

Looks like the readme tests were accidentally disabled - https://github.com/microsoft/windows-rs/pull/3125/commits/cf9b35bb35566244fbef6bd786fa7e4f3a0df75f turns them back on.

This whole non-Windows appeasement thing is getting old. It's making it too difficult to support Windows, which is the whole point of this project. 🤪 Anyway, the latest version retains basic Linux compatibility for windows-core only to support COM. For now, I needed to keep windows-strings at least building on non-Windows but I plan to limit non-Windows support to COM and nothing more.


Error with docker-compose.yml: no declaration was found in the volumes section

$ docker-compose build --no-cache matter-server
ERROR: Named volume "$HOME/docker/matter-server/data:/data:rw" is used in service "matter-server" but no declaration was found in the volumes section.

Fixed with
diff --git a/docker-compose.yml b/docker-compose.yml
index 167b711..aa6c9f1 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -17,5 +17,5 @@ services:
       - "5580:5580"
     volumes:
       # Create an .env file that sets the USERDIR environment variable.
-      - ${USERDIR:-$HOME}/docker/matter-server/data:/data/
+      - /home/rpi/docker/matter-server/data:/data/
       - /run/dbus:/run/dbus:ro

Also getting this error:
sudo docker-compose up -d matter-server
Creating matter-server ...

ERROR: for matter-server  "host" network_mode is incompatible with port_bindings

Fixed by commenting out port section in docker-compose.yml.

I encountered the same error, but I created a .env file setting USERDIR to the folder containing my copy of the repo, as suggested by the Docker-Compose comment.


Error: (803.7) [makeblastdb] Blast-def-line-set.E.title

Dear developer:
RoseTTAFold2NA is a wonderful tool for predicting protein and nuclear interaction, but I have a problem when I running the code, like this:
Error: (803.7) [makeblastdb] Blast-def-line-set.E.title
Bad char [0x81] in string at byte 44
Oculatella neakameniensis str. KOVÁČIK 1990/54 bacterial LSU rRNA
Error: (803.7) [makeblastdb] Blast-def-line-set.E.title
Bad char [0xCC] in string at byte 46
Oculatella neakameniensis str. KOVÁČIK 1990/54 bacterial LSU rRNA
Error: (803.7) [makeblastdb] Blast-def-line-set.E.title
Bad char [0x8C] in string at byte 47
Oculatella neakameniensis str. KOVÁČIK 1990/54 bacterial LSU rRNA
FASTA-Reader: Ignoring invalid residues at position(s): On line 105003909: 10
FASTA-Reader: Ignoring invalid residues at position(s): On line 105004664: 1
FASTA-Reader: Ignoring invalid residues at position(s): On line 105005148: 1
FASTA-Reader: Ignoring invalid residues at position(s): On line 105005321: 6
FASTA-Reader: Ignoring invalid residues at position(s): On line 105005559: 8, 13
FASTA-Reader: Ignoring invalid residues at position(s): On line 105005654: 17
FASTA-Reader: Ignoring invalid residues at position(s): On line 105006513: 24
And how can I solve the problem? Could you help me?
Best wishes

Does this occur when you are downloading the RNACentral database?

Same issue here ...

Hi! Same issue now, have you been able to solve it?

Hello,
I've managed to solve this.
Download the db file
wget ftp://ftp.ebi.ac.uk/pub/databases/RNAcentral/current_release/sequences/rnacentral_species_specific_ids.fasta.gz
gunzip and save it to fasta
gunzip -c rnacentral_species_specific_ids.fasta.gz > rnacentral_species_specific_ids.fasta
modify the file to get rid of bad characters
cat rnacentral_species_specific_ids.fasta | perl -ne 's/[^\x00-\x7F]+/ /g; print;' > rnacentral_species_specific_ids_cleaned.fasta
make a db
makeblastdb -in rnacentral_species_specific_ids_cleaned.fasta  -dbtype nucl  -parse_seqids -out rnacentral.fasta -title "RNACentral"
Bad-char error is solved, but FASTA-Reader will still give this warning. However, I managed to run the RNA-prot example w/ any issues.
Best,
M


Implement Enumerator::Lazy#grep and #grep_v

This also fixes a critical bug in Enumerator::Lazy which I described in the commit message and added a test for. Basically the following example failed:
enum = [1,2].lazy
select = enum.select { true }
select.to_a
# => [1,2]
enum.to_a
# => []

In MRI Ruby both calls to #to_a returned [1, 2]. This happened because we consumed Enumerator objects when passed to Enumerator::Lazy. Now we rewind them before looping which makes this work.

Enumerator::Lazy is pretty cool!


mode switch issue fix & css fix in catagory path

v-app Adds Vuetify. Without it vuetify won't work. Is there any other way??