Finalise Assignments Page | Add Project submission description

Screenshots
1.

2.

3.

4.

5.

6.

7.

Coverage decreased (-3.4%) to 82.449% when pulling 5ef692e894d1dc578ad4e0b78ce503b1a46e6087 on aayush-05:finaliseAssignmentsPage into e8bd8cf2795c86581c46b5961fb2b230d312692b on CircuitVerse:master.

@nitin10s please have a look at this. @satu0king I have added the assignment submission additional description box here (it is the same content as project description, so no new database column required)

Done @nitin10s

What does Export do? We can maybe use a better text for that button - Export Results

Fixed @nitin10s


Draggable item loses mouse position when container scrolls

Dragging to scroll in div loses cursor position.
Opened a codesandbox with dnd-kit and beautficul dnd comparison.
Demo: https://codesandbox.io/s/loving-boyd-pu9fe?file=/src/dnd-kit.js
The red div is the active dragging.

Please read the documentation carefully around when to use DragOverlay:

If your draggable item is within a scrollable container, we also recommend you use a , otherwise you'll need to set the draggable element to position: fixed yourself so the item isn't restricted to the overflow and stacking context of its scroll container, and can move without being affected by the scroll position of its container.

https://docs.dndkit.com/api-documentation/draggable/drag-overlay#when-should-i-use-a-drag-overlay


Correct community links

In the future, I will add more community links from different places as soon as possible. But I need more time. @bobycloud


[WIP] [SR-15353] tweak testSerialConcurrentPerform

Bug/issue #, if applicable: SR-15353
Summary
This PR is meant to help debug SR-15353 in CI, to figure out why the testSerialConcurrentPerform test is periodically failing on one of the Linux builders. Right now, it just tweaks the assertion logging, but i have a hunch as to what's going on (resolution/precision issues in the systemUptime clock) that i'll implement when i have a better picture of what's going wrong on the CI machine. (I couldn't reproduce it locally, whether in macOS or in a Linux Docker container.)
Dependencies
N/A
Testing
This PR updates an existing test and doesn't touch any library code; behavior should not change.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[ n/a ] Added tests
[x] Ran the ./bin/test script and it succeeded
[ n/a ] Updated documentation if necessary

@swift-ci Please test Linux


Update scripting docs for crafting post requests

When sending post data via JSON, not all servers will properly parse this by default. Explicitly providing the Content-Type header is more robust.

:+1:

@michaelansel Thanks for the approval! Is there anybody else I should be pinging as well to finalize this PR?

@technicalpickles is the one to ping for merging


Separate bower.json files for different environments under Git version control

I have a multi-environment setup, for this example let's say it's just Dev and Prod (both hosted on remote servers, accessible by all developers). All of the files, including bower.json, are under version control so front-end developers can update dependencies at will and those updates will be shared amongst all developers. That said, we need the ability to test unstable versions of a specific package in Dev (using #) while Prod continues using the latest stable version. Currently our Jenkins build job for both environments runs the 'bower update' command so that any new changes are taken into account and the bower_components files are adjusted accordingly ... therein lies the problem. Any of the following solutions (or others I haven't thought of) may mitigate the issue allowing for a setup that fulfills my requirements:

Adding the -d/--development flag to ONLY install devDependencies
Allowing the user to specify the name of the bower.json file that's used in .bowerrc so that ${ENV} may be used, e.g. {json:'bower-${ENV}.json'}

That's a pretty special scenario to be honest.
Just from a workflow perspective I'd say test the unstable versions locally. You probably don't want to deploy them to production anyway, but that's not always true I guess.
One quick solution might be to add ignoredDependencies to your .bowerrc and ignore everything but your devDependencies as you described in 1). Alternatively you might be able to utilize Hooks to build your own workflow. There is also an override plugin for Gulp here if that's an option for you.
I personally think 2) might be a cool enhancement that you can set if needed (disabled by default).

Bower is deprecated and we won't implement new features like this one. We recommend switching to yarn and migrating projects to it with https://github.com/sheerun/bower-away


Table.GenerateByPage doesn't handle pages with different column names

Issue
The function Table.GenerateByPage assumes every page has the same column names as the first page. It will:

Ignore any columns not present in the first page, but present in subsequent ones.

Solution
Table.GenerateByPage needs updated to add the allColumnNames line (and update the Value.ReplaceType line accordingly) as below.

Replace the Value.ReplaceType line with a let-in block.
The Value.ReplaceType line goes in the 'in' section.
The 'let' section contains the allColumnNames line below.

allColumnNames = List.Distinct(List.Combine(List.Transform(firstRow[Column1], Table.ColumnNames)))

Within Value.ReplaceType, update the Table.ExpandTableColumn line as below.

~Table.ExpandTableColumn(tableOfPages, "Column1", Table.ColumnNames(firstRow[Column1])),~
Table.ExpandTableColumn(tableOfPages, "Column1", allColumnNames),
Result:
// The getNextPage function takes a single argument and is expected to return a nullable table
Table.GenerateByPage = (getNextPage as function) as table =>
    let
        listOfPages = List.Generate(
            () => getNextPage(null),            // get the first page of data
            (lastPage) => lastPage <> null,     // stop when the function returns null
            (lastPage) => getNextPage(lastPage) // pass the previous page to the next function call
        ),
        // concatenate the pages together
        tableOfPages = Table.FromList(listOfPages, Splitter.SplitByNothing(), {"Column1"}),
        firstRow = tableOfPages{0}?
    in
        // if we didn't get back any pages of data, return an empty table
        // otherwise set the table type based on the columns of the first page
        if (firstRow = null) then
            Table.FromRows({})
    // check for empty first table
        else if (Table.IsEmpty(firstRow[Column1])) then
            firstRow[Column1]
        else
            let
                allColumnNames = List.Distinct(List.Combine(List.Transform(firstRow[Column1], Table.ColumnNames)))
            in
                Value.ReplaceType(
                    Table.ExpandTableColumn(tableOfPages, "Column1", allColumnNames),
                    Value.Type(firstRow[Column1])
                );

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 63706099-f414-4f48-165d-a3609437a37e
Version Independent ID: 1807dacc-1bf2-79aa-70b1-bebd2f2c6331
Content: Helper functions for M extensions for Power Query connectors - Power Query
Content Source: powerquery-docs/helper-functions.md
Service: powerquery
GitHub Login: @ptyx507x
Microsoft Alias: miescobar

Hey @bgribaudo / @DougKlopfenstein, I just saw your messages. Heh, it has been a while and I had to think for a while to recall what I was pointing out. I no longer have access to the project I was working on when I discovered the issue, but reading over my message I can tell what I was trying to say, though I see with fresh eyes that I wasn't very clear.
I was making use of the custom / non-built-in function Table.GenerateByPage defined here:
https://learn.microsoft.com/en-us/power-query/helper-functions#tablegeneratebypage
While using it, I encountered an issue where expected columns were missing from my final table. I tracked down the issue to the fact that, those columns weren't in the first page of data (the oldest data), but were present in later pages (newer data tracked more than the older data). I fixed the issue and to save other users who copy the function from that page, from having to do the debugging I did, I propose my fix be incorporated into the definition/example on that page.
I've enclosed a screenshot of a comparison between the original and my update. You can see in line 22 of the original, that it just gets the column names by Table.ColumnNames(firstRow[Column1]), which only extracts the column names from the first page. We need allColumnNames for Table.ExpandTableColumn. Prior to that line, I added this one:
allColumnNames = List.Distinct(List.Combine(List.Transform(firstRow[Column1], Table.ColumnNames)))
If I'm reading it correctly, it takes Column1 as a list (of pages) and iterates down the pages applying Table.ColumnNames to each page, then it combines all the results, and trims it down to distinct names. The resulting allColumnNames is then passed into Table.ExpandTableColumn.
Reviewing this now, I'm unsure if I missed something. The final parameter passed into Table.ExpandTableColumn is Value.Type(firstRow[Column1]) (line 23 originally, line 26 in my update). Without access to that project, just reading that it's not immediately clear to me whether Value.Type is getting type metadata about Column1 itself or whether it would just get the type metadata from the first page in Column1 like Table.ColumnNames does. If it's the later, the column types from each page should be aggregated while allColumnNames is being built (each type sticking with its column name so we don't have any working out to do after List.Distinct gets rid of duplicates.

Thanks for the follow-up, @TBemrose!
If I'm understanding your solution correctly, it's reading all API pages before returning the first page's worth of rows in order to get the full column list (full as in across all pages).
However, there's a catch. :-) This approach can add quite a bit of cost to using the connector. Say the user does a Table.TopN(Source, 1) on the connector's output. To keep with Power Query's "only do as much work as needed" philosophy, it would be desirable that only the first results page be fetched from the API to satisfy this request. If all pages have to be read to output 1 row, quite a bit of "over reading" could occur.
If the only way you can come up with the expected column list is by reading all pages from the API, you might just have to do that—but this approach wouldn't be generally applicable to all custom connectors.
If you know the expected column list in advance, maybe you could adapt the version of this function that you are using so that it takes that list as an optional argument. That way, you avoid this possible cause of over reading pages!


fix: fix init data not saved to database (#2885)

I think the Properties of AccountItem is defined for using, so I change the default value of visible to true. The change of initDefinedUser is compatible with old code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


docs: fix typo in Client#persist

Can close #4

I actually fixed this with<EMAIL_ADDRESS>but thanks for the PR! :D


Update changelog.

Hey, can you follow the outline in:
https://github.com/uber/jaeger-client-python/commit/3c74cc80fb25de72488c68f02d62b3aa79168499
We need to bump the config version

I pushed manually, but the publish step failed
Writing jaeger-client-3.6.0/setup.cfg
Creating tar archive
removing 'jaeger-client-3.6.0' (and everything under it)
running upload
Submitting dist/jaeger-client-3.6.0.tar.gz to https://pypi.python.org/pypi
Upload failed (410): Gone (This API has been deprecated and removed from legacy PyPI in favor of using the APIs available in the new PyPI.org implementation of PyPI (located at https://pypi.org/). For more information about migrating your use of this API to PyPI.org, please see https://packaging.python.org/guides/migrating-to-pypi-org/#uploading. For more information about the sunsetting of this API, please see https://mail.python.org/pipermail/distutils-sig/2017-June/030766.html)
error: Upload failed (410): Gone (This API has been deprecated and removed from legacy PyPI in favor of using the APIs available in the new PyPI.org implementation of PyPI (located at https://pypi.org/). For more information about migrating your use of this API to PyPI.org, please see https://packaging.python.org/guides/migrating-to-pypi-org/#uploading. For more information about the sunsetting of this API, please see https://mail.python.org/pipermail/distutils-sig/2017-June/030766.html)

Coverage remained the same at 94.679% when pulling 4b7dc68c0579cd5b022c4ef27f5f321b7b5543a5 on isaachier:master into 53a97fea6b07e67aa8d79ae8c861b809f944d414 on uber:master.


problem

hello,I have a probelm, in the 'exploader.py' , the 168 line shows us that change_size[:,:,1:4]=d1,d2,d2 and change_size[:,:,4:6]=flow3d, then we get the rectified 3D flow named 'p3d' from the 202 line, but the 203 line shows that we replace the 'd1,d2,d2' with the rectified 3D flow named 'p3d', I have the problem why we do not replace the old  flow3d which is change_size[:,:,4:6] with 'p3d'?

Hi, I may not follow your question. 3d flows are not replaced because they will be used at training time.
I updated exploader.py to make it clearer. The code is not cleaned up yet and sorry for any confusion due to variable names.

Thank you very much. I understand what you mean.


gentlejack

https://github.com/gentlejack/api/pull/1/commits/2cb276ff0507fcefa892bec99285d392e8da2755

I'm not sure that this is the right place for this.


Add num_participants field to Room

tagged as v0.9.5.

I just saw that I forgot to regenerate protocol files. Can you quickly do it or I made a PR ?

done! retagged


Karpenter is nominating pods to machine that does not match its requirements

Description
Observed Behavior:
launching a pod with
      nodeSelector:
        karpenter.k8s.aws/instance-local-nvme: "50"

I read in the events:

kube_scheduler failed to schedule the pod

0/9 nodes are available: 1 node(s) had untolerated taint {dedicated: skipper-ingress-redis}, 1 node(s) had untolerated taint {node.kubernetes.io/role: master}, 2 node(s) had untolerated taint {dedicated: skipper-ingress}, 5 node(s) didn't match Pod's node affinity/selector. preemption: 0/9 nodes are available: 9 Preemption is not helpful for scheduling.

karpenter nominated the pod to an existing machine/node

Pod should schedule on: machine/default-karpenter-f72cc, node/ip-10-149-71-113.eu-central-1.compute.internal

this node does not have the right label
NAME                                             STATUS   ROLES    AGE   VERSION    LABELS
ip-10-149-71-113.eu-central-1.compute.internal   Ready    worker   16h   v1.24.16   aws.amazon.com/spot=true,beta.kubernetes.io/arch=amd64,beta.kubernetes.io/instance-type=r5n.xlarge,beta.kubernetes.io/os=linux,cluster-lifecycle-controller.zalan.do/replacement-strategy=none,failure-domain.beta.kubernetes.io/region=eu-central-1,failure-domain.beta.kubernetes.io/zone=eu-central-1a,karpenter.k8s.aws/instance-category=r,karpenter.k8s.aws/instance-cpu=4,karpenter.k8s.aws/instance-encryption-in-transit-supported=true,karpenter.k8s.aws/instance-family=r5n,karpenter.k8s.aws/instance-generation=5,karpenter.k8s.aws/instance-hypervisor=nitro,karpenter.k8s.aws/instance-memory=32768,karpenter.k8s.aws/instance-network-bandwidth=4100,karpenter.k8s.aws/instance-pods=58,karpenter.k8s.aws/instance-size=xlarge,karpenter.sh/capacity-type=spot,karpenter.sh/initialized=true,karpenter.sh/provisioner-name=default-karpenter,karpenter.sh/registered=true,kubernetes.io/arch=amd64,kubernetes.io/hostname=ip-10-149-71-113,kubernetes.io/os=linux,kubernetes.io/role=worker,lifecycle-status=ready,node.kubernetes.io/distro=ubuntu,node.kubernetes.io/instance-type=r5n.xlarge,node.kubernetes.io/node-pool=default-karpenter,node.kubernetes.io/profile=worker-karpenter,node.kubernetes.io/role=worker,topology.ebs.csi.aws.com/zone=eu-central-1a,topology.kubernetes.io/region=eu-central-1,topology.kubernetes.io/zone=eu-central-1a

> zkubectl describe machine default-karpenter-f72cc
...
Labels:       cluster-lifecycle-controller.zalan.do/replacement-strategy=none
              karpenter.k8s.aws/instance-category=r
              karpenter.k8s.aws/instance-cpu=4
              karpenter.k8s.aws/instance-encryption-in-transit-supported=true
              karpenter.k8s.aws/instance-family=r5n
              karpenter.k8s.aws/instance-generation=5
              karpenter.k8s.aws/instance-hypervisor=nitro
              karpenter.k8s.aws/instance-memory=32768
              karpenter.k8s.aws/instance-network-bandwidth=4100
              karpenter.k8s.aws/instance-pods=58
              karpenter.k8s.aws/instance-size=xlarge
              karpenter.sh/capacity-type=spot
              karpenter.sh/provisioner-name=default-karpenter
              kubernetes.io/arch=amd64
              kubernetes.io/os=linux
              lifecycle-status=ready
              node.kubernetes.io/instance-type=r5n.xlarge
              node.kubernetes.io/node-pool=default-karpenter
              node.kubernetes.io/profile=worker-karpenter
              node.kubernetes.io/role=worker
              topology.kubernetes.io/region=eu-central-1
              topology.kubernetes.io/zone=eu-central-1a
...
Events:
  Type    Reason                 Age                 From       Message
  ----    ------                 ----                ----       -------
  Normal  Unconsolidatable       51m                 karpenter  not all pods would schedule, visibility/zmon-appliance-worker-7bbb86d9dc-wzw67 => would schedule against a non-initialized node default-karpenter-scs5j visibility/zmon-appliance-worker-7bbb86d9dc-k52g7 => would schedule against a non-initialized node default-karpenter-scs5j visibility/zmon-appliance-worker-7bbb86d9dc-58z65 => would schedule against a non-initialized node default-karpenter-scs5j default/testing-nginx-665669cfc5-8wqrp => would schedule against a non-initialized node default-karpenter-scs5j
  Normal  DeprovisioningBlocked  30m (x8 over 53m)   karpenter  Cannot deprovision machine due to pdb visibility/zmon-appliance-worker prevents pod evictions
  Normal  Unconsolidatable       14m (x2 over 29m)   karpenter  can't remove without creating 2 candidates
  Normal  DeprovisioningBlocked  14s (x27 over 92m)  karpenter  Cannot deprovision machine due to machine is nominated

karpenter logs were silent about it, even with the debug level
Expected Behavior:
expect karpenter to nominate the pod to a valid node, if it can not schedule the pod, it should be visible in the pod events and/or karpenter logs
Reproduction Steps (Please include YAML):
deployment:
apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: testing-nginx
  name: testing-nginx
spec:
  replicas: 1
  selector:
    matchLabels:
      app: testing-nginx
  template:
    metadata:
      labels:
        app: testing-nginx
    spec:
      nodeSelector:
        karpenter.k8s.aws/instance-local-nvme: "50"
      containers:
      - image: nginx
        name: nginx
        resources:
          limits:
            cpu: 200m
            memory: 50Mi
          requests:
            cpu: 200m
            memory: 50Mi

provisioner
- apiVersion: karpenter.sh/v1alpha5
  kind: Provisioner
  metadata:
    name: default-karpenter
  spec:
    consolidation:
      enabled: true
    labels:
      cluster-lifecycle-controller.zalan.do/replacement-strategy: none
      lifecycle-status: ready
      node.kubernetes.io/node-pool: default-karpenter
      node.kubernetes.io/profile: worker-karpenter
      node.kubernetes.io/role: worker
    providerRef:
      name: default-karpenter
    requirements:
    - key: karpenter.k8s.aws/instance-family
      operator: In
      values:
      - c5
      - m5
      - r5
      - c5d
      - m5d
      - r5d
      - c5n
      - m5n
      - r5n
      - c6i
      - m6i
      - r6i
      - c6id
      - m6id
      - r6id
      - c6in
      - m6in
      - r6in
    - key: karpenter.k8s.aws/instance-size
      operator: NotIn
      values:
      - metal
    - key: karpenter.sh/capacity-type
      operator: In
      values:
      - spot
      - on-demand
    - key: topology.kubernetes.io/zone
      operator: In
      values:
      - eu-central-1a
      - eu-central-1b
      - eu-central-1c
    - key: kubernetes.io/os
      operator: In
      values:
      - linux
    startupTaints:
    - effect: NoSchedule
      key: zalando.org/node-not-ready

Versions:

Chart Version:
Not using Helm, karpenter version is v0.29.2
Kubernetes Version (kubectl version):
Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.16", GitCommit:"51e33fadff13065ae5518db94e84598293965939", GitTreeState:"clean", BuildDate:"2023-07-19T12:19:24Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"linux/arm64"}

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments; they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

I haven't been able to reproduce this.
I did a test by starting up a c6i.8xlarge (so plenty of space) and then applying your test-nginx deployment. Karpenter correctly spins up a new node with local nvme to match the node selector.

Oh actually I can reproduce this. I was using HEAD rather than v0.29.2. It appears this is fixed at HEAD.  More updates to come on what happened.

So looks like this was resolved in this PR: https://github.com/aws/karpenter-core/pull/432 and will be released next week with v0.30.0


Issue 1197 - Use Eigen's plugin system to views for autodiff types

Summary
As discussed in more depth in #1197, this PR adds methods to Eigen for returning vals/adjoints/tangents/varis from matrices of autodiff types.
The following methods have been added:
Matrix<var, R, C>:

.adj()
.val()
.vi()

Matrix<vari*, R, C>:

.adj()
.val()

Matrix<fvar<T>, R, C>:

.d()
.val()

Tests
No new tests have been added, as the methods maintain existing functionality but with less code
Side Effects
Requires that prim/mat/fun/Eigen.hpp be included before any other Eigen header, otherwise the new methods won't be available
Checklist

[x] Math issue #1197

[x] Copyright holder: Andrew Johnson
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

@seantalts looks like jenkins is having some trouble with the distribution tests:
fatal error: error in backend: IO failure on output stream: No space left on device
<builtin>: recipe for target 'test/prob/exp_mod_normal/exp_mod_normal_ccdf_log_00004_generated_v_test.o' failed

Oh, I replied to this in an email but it isn't showing up, weird. anyway, tagging @serban-nicusor-toptal re: Jenkins

Yeah... an email I sent yesterday just bounced back to me. I wrote this immediately I saw the PR yesterday.

Thanks. There should be unit tests for all the new methods were added. We want to make sure we can instantiate these class methods properly and they function properly.

You're right, I'll get those tests written and added in

The order of includes is now causing trouble in the upstream tests. It looks like several Stan headers are including Eigen/Dense before any of the Math headers get included, which stops the added methods from being loaded and causes compile errors.
A simple workaround would be to replace #include <Eigen/Dense> with #include <stan/math/prim/mat/fun/Eigen.hpp>
@bob-carpenter would this cause any issues on the Stan side? Or is there a better way?

I'm pretty sure <stan/math/prim/mat/fun/Eigen.hpp> must be included before any other Eigen include for Stan.

That doesn't seem to be the case for the header tests though. For example, the headers test for src/stan/mcmc/hmc/nuts/softabs_nuts.hpp fails, because src/stan/mcmc/sample.hpp includes Eigen/Dense

Bob's right. The way we have our traits set up, we need to include
stan/math/prim/mat/fun/Eigen.hpp first. This also simplifies the plugin
architecture: there's no need to worry that you called Eigen before
defining that preprocessor variable.
It seems like we need to update the includes of src/stan/mcmc/sample.hpp.
For the Stan library, for a lot of operations we don't need to include Math
traits defined for Eigen first, but if we do use the plugin, we will have
to.
On Thu, May 2, 2019 at 12:05 PM Andrew Johnson<EMAIL_ADDRESS>wrote:

That doesn't seem to be the case for the header tests though. For example,
the headers test for src/stan/mcmc/hmc/nuts/softabs_nuts.hpp fails,
because src/stan/mcmc/sample.hpp includes Eigen/Dense
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1216#issuecomment-488732526, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADH6F5LEPLEVMEC5S4YM7TPTMGLJANCNFSM4HIFXAVQ
.

Right, if we only need to change the headers that are causing the header tests to fail, and not all of the headers, then only these two need to be changed:

stan/mcmc/sample.hpp
stan/model/model_functional.hpp

Then everything passes fine

If you don’t mind, please create an issue to fix those includes. Those
should be fixed regardless. I think we should provide more guidance to
clients that also use the Eigen library.
With that in mind, this limits a client from defining a second set of Eigen
plugins?
On Fri, May 3, 2019 at 10:32 AM Andrew Johnson<EMAIL_ADDRESS>wrote:

Right, if we only need to change the headers that are causing the header
tests to fail, and not all of the headers, then only these two need to be
changed:

stan/mcmc/sample.hpp
stan/model/model_functional.hpp

Then everything passes fine
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1216#issuecomment-489116095, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADH6F5DEG5MG7VONLBY6GTPTREHZANCNFSM4HIFXAVQ
.

With that in mind, this limits a client from defining a second set of Eigen plugins?

Good question! They couldn't define a second file containing plugin methods (otherwise the preprocessor token EIGEN_MATRIXBASE_PLUGIN would have multiple definitions), but they could add them to the existing matrix_addons.h file

You could always #undef EIGEN_MATRIXBASE_PLUGIN before redefining it to point to a custom plugins file which includes our matrix_addons.h file.

You could always #undef EIGEN_MATRIXBASE_PLUGIN before redefining it to point to a custom plugins file which includes our matrix_addons.h file.

As in:
#define EIGEN_MATRIXBASE_PLUGIN "stan/math/prim/mat/matrix_addons.h"
#undef EIGEN_MATRIXBASE_PLUGIN
#define EIGEN_MATRIXBASE_PLUGIN "stan/math/prim/mat/matrix_addons_2.h"

That also doesn't work, since the methods in the second file simply overwrite the methods in the first.
A good approach could be to create a folder, something like prim/mat/plugins, which would contain the files with plugin methods and have a single header that includes them.
For example, creating a file: prim/mat/eigen_plugins.h, which contains:
#include <stan/math/prim/mat/plugins/matrix_addons.h>
#include <stan/math/prim/mat/plugins/matrix_addons_2.h>

Then we can just use #define EIGEN_MATRIXBASE_PLUGIN "stan/math/prim/mat/eigen_plugins.h"

To clarify, what I was saying was that "stan/math/prim/mat/matrix_addons_2.h" would include "stan/math/prim/mat/matrix_addons.h". I think Daniel is asking here about 3rd party clients who want to use the Math library without editing it. The trick might be seeing if they can figure out which headers to use such that they can basically
#include <lots of stan stuff including setting EIGEN_MATRIXBASE_PLUGIN but not Eigen>
#undef EIGEN_MATRIXBASE_PLUGIN
#define EIGEN_MATRIXBASE_PLUGIN "my_addons.h" // which includes stan/math/prim/mat/plugins/matrix_addons.h
#include <the rest of Stan stuff including Eigen>

That makes sense, sorry for the misunderstanding.
I think it might be a good idea to just get the methods in with this pull and open a separate issue for the implementation of other plugins to be honest

That's right. It's ok that we limit the ability to customize Eigen when
using Math, but we should clearly doc it so clients know that they won't be
able to use plugins easily.
I don't think this has any negative impact on Stan, so it should be fine.
On Tue, May 7, 2019 at 11:33 AM seantalts<EMAIL_ADDRESS>wrote:

Right, I don't think Daniel was suggesting we handle that with this PR,
just double checking that we aren't eliminating any client abilities in the
PR (please correct me if that's wrong).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1216#issuecomment-490131020, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADH6FZ7AV5IXJKBV2TOFSDPUGOLXANCNFSM4HIFXAVQ
.

Is this still waiting on the headers issue?

No, @syclik reviewed the Stan repo today.

Now that this is passing the upstream tests, it's ready for a final review

@andrjohns, it looks like you've mentioned the side-effect of requiring prim/mat/fun/Eigen.hpp to be included prior to Eigen being included. That makes sense. Are there any other side-effects that we should know about? Does this behave properly with all our template traits if included in this manner?
Part of me thinks that this is the complicated way of implementing this functionality. Writing views would simplify the order dependency of includes. That said, I'm not opposed to this if it's easily maintained and is actually easy to use.

Andrew when you get a chance could you try this on a the Cholesky rev code? I tried that tonight but was having a lot of difficulty. I think it's nice and pretty non-trivial to sort out. Will probs help us verify this works for more complicated examples.
When I tried it tonight I was getting a lot of errors where it was trying to use the const accessor for types that were non-const. It was also throwing the error THIS_COEFFICIENT_ACCESSOR_TAKING_ONE_ACCESS_IS_ONLY_FOR_EXPRESSIONS_ALLOWING_LINEAR_ACCESS
for things like L.val().triangularView<Upper>().solveInPlace(L.adj().transpose());

Yep, can do! I'm working through my dev backlog this week, so I'll do some testing on this at the same time.

From: Steve Bronder<EMAIL_ADDRESS>Sent: Monday, June 10, 2019 12:10:10 PM
To: stan-dev/math
Cc: Andrew Johnson; Mention
Subject: Re: [stan-dev/math] Issue 1197 - Use Eigen's plugin system to views for autodiff types (#1216)
Andrew when you get a chance could you try this on a the Cholesky rev code? I tried that tonight but was having a lot of difficulty. I think it's nice and pretty non-trivial to sort out. Will probs help us verify this works for more complicated examples.
When I tried it tonight I was getting a lot of errors where it was trying to use the const accessor for types that were non-const. It was also throwing the error THIS_COEFFICIENT_ACCESSOR_TAKING_ONE_ACCESS_IS_ONLY_FOR_EXPRESSIONS_ALLOWING_LINEAR_ACCESS
for things like L.val().triangularView().solveInPlace(L.adj().transpose());
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/stan-dev/math/pull/1216?email_source=notifications&email_token=AGTPCCDPTZX2DJRYVQXCEKTPZXH2FA5CNFSM4HIFXAV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXI4ALQ#issuecomment-500285486, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGTPCCAJPL2U2KGAM72O6ELPZXH2FANCNFSM4HIFXAVQ.

@roualdes, please take a look.

note to self: if I can come up with a view implementation quickly, do it and let @rok-cesnovar  try it out. This message times out July 4, 2019. If I don't do anything by then, there are no technical objections from me.

things like L.val().triangularView().solveInPlace(L.adj().transpose());

@SteveBronder This one sent me down a bit of a rabbit hole! The code only works with const inputs, e.g.:
const matrix_v const_mat_in = matrix_v::Random(100,100);

MatrixXd tri_out = const_mat_in.val().triangularView<Eigen::Upper>().solve(const_mat_in.adj().transpose());

This was because non-const inputs call CWiseUnaryView and const inputs call CWiseUnaryOp. After some digging, this turned out to be a bug in CWiseUnaryView which was causing a compilation error when multiplying two views returning doubles (more background here if interested)
I'll keep an eye on the bug report for a fix

Is there an alternative for these cases except waiting for them to fix the bug.

lol thanks for checking it out! I'm not sure whether this is blocking or non-blocking. Sure it means we can't use this for everything, but Eigen folks seem to be checking it out and as long as we keep an eye on it I'm pretty sure there's a good few other places in our code where the above is not an issue.
I looked over their bugzilla and don't see it over there yet

If there is only a few cases where we cant use it, I definitely dont see this as being blocking.

I'd view this as non-blocking, since the autodiff matrix functions generally pass by constant reference. It does block the usage of SolveInPlace() however

I looked over their bugzilla and don't see it over there yet

I'm waiting on the devs to register a bugzilla account for me (they don't allow self-registration) so that I can properly report it

@SteveBronder (or anyone else) this is ready to have another look over, thanks!

Re https://github.com/stan-dev/stan/pull/2754: Since this PR necessitates #define EIGEN_MATRIXBASE_PLUGIN before any Eigen headers are included, should we clean up any stan-dev/math files that include Eigen headers without including stan/math/prim/mat/fun/Eigen.hpp?  For instance, see stan/math/prim/mat/err/is_lower_triangular.hpp.
Otherwise, I don't see any immediate nor potential problems between this and the flattening efforts.

I think it'd be great to clean up the includes.  That could be done in a separate PR.  I'd be OK combining with this PR, but it's not my call.

On Jul 1, 2019, at 12:25 PM, Edward A. Roualdes<EMAIL_ADDRESS>wrote:
Re stan-dev/stan#2754: Since this PR necessitates #define EIGEN_MATRIXBASE_PLUGIN before any Eigen headers are included, should we clean up any stan-dev/math files that include Eigen headers without including stan/math/prim/mat/fun/Eigen.hpp? For instance, see stan/math/prim/mat/err/is_lower_triangular.hpp.
Otherwise, I don't see any immediate nor potential problems between this and the flattening efforts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry for my delay I'll check this out during the week or this weekend.
I wonder if there's someway we can still let users use the Eigen plugin themselves but with some reasonable catch.

All good Steve, happy for the help.

I wonder if there's someway we can still let users use the Eigen plugin themselves but with some reasonable catch.

As in allow users to add other methods with #define EIGEN_MATRIXBASE_PLUGIN on top of these ones? I was thinking of having a 'meta-header' that includes each 'addon' file, for example:
prim/mat/fun/Eigen.hpp:
...

#define EIGEN_MATRIXBASE_PLUGIN "stan/math/prim/mat/addons_meta.hpp"

...

prim/mat/addons_meta.hpp:
#include <stan/math/prim/mat/matrix_addons.h>

Word! I'm about halfway through the review, all looks good! Mostly need to read over the unit tests.
As per the Jenkins error maybe try merging with master? Some stuff for windows threading was merged recently-ish

Nice ty! As per the
#include <stan/math/prim/mat/matrix_addons.h>

Would we just have a note telling people to include the matrix_addons.h file in their add-on? If so that seems like a nice solution. @seantalts @syclik does that make sense to yinz? If we are not concerned about that then I'm cool with approving this now

Also neat article came across me the other day related to this PR
https://www.fluentcpp.com/2017/06/02/write-template-metaprogramming-expressively/

That's a great blog as a whole, thanks!

@serban-nicusor-toptal Got that odd windows threading failure here as well

develop is also broken on it. The runTests.py -f filtering doesn't work currently on Windows, it seems.

😅 srry for the time bomb
Did the python version change or something? That's kind of surprising. If you can get me access to the windows machine I'll look into it

I looked into it further - it seems to work on the Windows machine we have,
but isn't working on the AMI (but that could be for a variety of reasons).
I'll take the EC2 Windows machines offline and let @serban-nicusor-toptal
look into it and test it before adding them back.
On Sat, Jul 6, 2019 at 3:52 PM Steve Bronder<EMAIL_ADDRESS>wrote:

😅 srry for the time bomb
Did the python version change or something? That's kind of surprising. If
you can get me access to the windows machine I'll look into it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/1216?email_source=notifications&email_token=AAGET3CIJIX625C762NNSQDP6DZY5A5CNFSM4HIFXAV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZK7LGQ#issuecomment-508949914,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGET3D27SRY7M4F6G4GAEDP6DZY5ANCNFSM4HIFXAVQ
.

Serb and I chatted he is going to set me up with an instance tmrw so I can take a look

@SteveBronder looks like the windows testing issues are resolved, can you have a final look over things?

Nice ty! As per the
#include <stan/math/prim/mat/matrix_addons.h>

Would we just have a note telling people to include the matrix_addons.h file in their add-on? If so that seems like a nice solution. @seantalts @syclik does that make sense to yinz? If we are not concerned about that then I'm cool with approving this now

Will that work? I guess it matters when the #define EIGEN_MATRIXBASE_PLUGIN is defined.

If someone else defines EIGEN_MATRIXBASE_PLUGIN and Eigen's includes are called, then ours won't get included unless they add our include to their includes. So... what you suggest works.
if someone else defines EIGEN_MATRIXBASE_PLUGIN and our header is called, then theirs won't get included at all. And what you suggest doesn't work. (I think.)

Btw, that has no impact on the review. I wasn't able to get a few hours to check to see if we could do it with views, so my potential technical evaluation (in a previous comment) has timed out.
@andrjohns: THANK YOU!
@SteveBronder: action is on you to approve.

Yep! @andrjohns can you on do what you are suggesting above with prim/mat/addons_meta.hpp. I think that's a nice solution! A gotcha but one that is pretty explicit and solvable as long as we doc it somewhere (and should probs include it in the release notes)

Alrighty, I've made a new folder prim/mat/eigen_plugins for the plugin files, with the meta-header prim/mat/eigen_plugins.h used to include the new plugin methods.
@SteveBronder can you check the doc on the prim/mat/eigen_plugins.h header and let me know if it's clear enough?
@syclik this approach adds another folder to the prim hierarchy, is that alright with you? Also let me know if you want any of the names changed

This may be a stupid question - feel free to ignore me:
I was just wondering if it is possible to also add .val() to Matrix<double>? It can be a solution that gets compiled away like our current value_of_rec(Matrix<double>) solution.
I was wondering this for cases where we would want to do x.val() and x could be Matrix<double> or Matrix<var>. This might potentially simply some of the codebase if it is possible to do.

I was just wondering if it is possible to also add .val() to Matrix? It can be a solution that gets compiled away like our current value_of_rec(Matrix) solution.

I don't see why it wouldn't be possible.  Also approving this PR!

I was wondering this for cases where we would want to do x.val() and x could be Matrix or Matrix. This might potentially simply some of the codebase if it is possible to do.

Is there somewhere in particular this stood out to you in the library?

This definitely wasnt a question for this PR to address, it just kind of fits in the discussion. I think it comes up in the GLMs at least.
Lets get this merged first. Thanks @andrjohns for this!

if it is possible to also add .val() to Matrix?

Yep that's very simple to add, just pushed it through

Thanks again!

I'd rather not duplicate existing functions as methods.
Is the suffix on value_of_rec () because it goes from fvar to var to double and the basic value_of() just goes from fvar to var?

@bob-carpenter the .val() method was always (essentially) a re-implementation of value_of() as a method, so what Rok suggested just made the functionality of both identical - .val() only worked with autodiff types, whereas value_of() works with both autodiff types and doubles

@andrsjohn, thank you for asking. Let's not add a top-level directory if we can avoid it. We should add things there very, very sparingly. If you think it really needs to go there (which might be the right thing), can you write up what you're proposing, the motivation, and the solution as a stand-alone post / doc so we can review it?

@syclik as per Steve's comment here, it won't be necessary to add another directory

Tests have passed, it's finally done! Can someone merge this?

Oh whoops! Sorry I was going to let you press the button!

imo there's something satisfying about pressing the button and I didn't want to take that from you

Haha you're all good, just as satisfying to have this off the to-do list


Additional problems handling errors when loading scripture content via user supplied URL

v0.2.0 build cbad9c9

I think we should be more consistent in our terminology. The app is referring to scripture resources as "versions", but the error messages refer to them as "projects". In non-scripture resources they are referred to as a "resource".

In this case the url points to a valid project (which is loadable in tC), but the error message indicates that it is not found.
https://git.door43.org/tc01/ar_mat_text_ulb

Here is an instance where the error is not returned to the settings dialog, but instead the error is displayed in the scripture card. (Only some books reside in the URL repo. The active book was Ruth, which is not in the repo)

@cckozie what terminology did tC choose? Are there different terms for scripture vs. translation helps?

Scriptures are referred to as "resources" when adding to scripture pane (although "Select language" also seems out of place):


chore: switch to cibuildwheel

Codecov Report

Merging #80 (934121c) into master (8fa3313) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           18        18
=========================================
  Hits            18        18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa3313...934121c. Read the comment docs.


[Improvement] adding intent confirmation to post long message

This PR adds intent confirmation to the post long message intent.
This is achieved using a session attribute which is used to determine is the yes/no intent was called during intent confirmation.
If yes/no intent were called during intent confirmation, then message sent/message denied response is given respectively.

LGTM


Difference between NSG Diagnostic Settings and NSG Flow Logs

Hi, I am trying to understand the difference between NSG Diagnostic Settings and NSG Flow Logs. Seems both are used to inspect traffic evaluated by NSG rules. Are they for similar purpose?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 80ca129e-6ffc-767b-3f1b-3c56cb822e76
Version Independent ID: 6383735e-1be0-ee09-e381-af054f6448dd
Content: Azure Networking Analytics solution in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/insights/azure-networking-analytics.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

Thanks for your comment. We are actively investigating and will get back to you shortly. Thanks for your patience.

Hello @CharmanderJieniJieni ,
NSG Diagnostic Settings: are the list of Resource logging settings available to be configured on a Network Security group Resource. Resource logging is enabled separately for each NSG you want to collect diagnostic data for.
When you enable logging for an NSG, you can gather the following types of resource log information:
1.) Event: Entries are logged for which NSG rules are applied to VMs, based on MAC address.
2.) Rule counter: Contains entries for how many times each NSG rule is applied to deny or allow traffic. The status for these rules is collected every 60 seconds.
Resource logs are only available for NSGs deployed through the Azure Resource Manager deployment model. You cannot enable resource logging for NSGs deployed through the classic deployment model.
Reference: https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-nsg-manage-log
NSG Flow logs: Network security group (NSG) flow logs is a feature of Azure Network Watcher that allows you to log information about IP traffic flowing through an NSG. NSG Flow Logs enable you to log 5-tuple flow information about all traffic through your NSGs (i.e. source, source port, destination, destination port, protocol).
The raw flow logs are written to an Azure Storage account from where they can be further processed, analyzed, queried, or exported as needed.
Reference: https://docs.microsoft.com/en-us/azure/network-watcher/network-watcher-nsg-flow-logging-overview

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.

@femsulu Where is one able to find an example of each (screenshot, table, schema) to compare information contained?


Task/373 market cache refactor

Coverage increased (+0.05%) to 95.203% when pulling 52e439d3b6ee6bd3ca585bd7bd4cacf1ac40168e on task/373-market-cache-refactor into 7accae32e0fae18dee471dd5f3176aa032f399a8 on release/2.12.0.

Coverage increased (+0.05%) to 95.203% when pulling 52e439d3b6ee6bd3ca585bd7bd4cacf1ac40168e on task/373-market-cache-refactor into 7accae32e0fae18dee471dd5f3176aa032f399a8 on release/2.12.0.


Uri, scheme, method, authority are not ignored in HTTPMatchRequest header keys

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
Hello, in Istio official documentation, it says that the keys uri, scheme, method and authority will be ignored in HTTPMatchRequest headers to avoid conflicts. https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPMatchRequest
However, in my practice, these keys are not ignored. Here is my configuration:
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: bookinfo
spec:
  hosts:
  - '*.bookinfo.com'
  http:
  - match:
    - uri:
        prefix: /productpage
      method:
        exact: GET
      headers:
        method:
          exact: GET
    route:
    - destination:
        host: productpage.default.svc.cluster.local

I tried curl -H"Host:www.bookinfo.com" http://<IP_ADDRESS>:10090/productpage -vv, but it failed. Only using curl -H"Host:www.bookinfo.com" -H"method:GET" http://<IP_ADDRESS>:10090/productpage -vv, packet can reach the target pod.
The same thing happens in uri, scheme and authority, which is not consistent with the official documentation.
Version
$ istioctl version
client version: 1.20.1
control plane version: 1.20.1
data plane version: 1.20.1
$ kubectl version --short
Client Version: v1.27.2
Kustomize Version: v5.0.1
Server Version: v1.27.3

Additional Information
This configuration doesn't cause warn in kubectl logs -l app=istiod -n istio-system --tail=300

cc @hzxuzhonghu , regression?

Not sure, i donot remember there is update

Donot you also specify method
      method:
        exact: GET

These are special headers in envoy, can you try using :method
HeaderMethod    = ":method"
HeaderAuthority = ":authority"
HeaderScheme    = ":scheme"
)

In official documentation, it says that the key method will be ignored in HTTPMatchRequest headers. In my understanding, either this configuration causes an error or warn when applying it, or the method key in headers is ignored so that curl -H"Host:www.bookinfo.com" http://<IP_ADDRESS>:10090/productpage -vv can match this route.

It is not quite correct, need to remove it

I think what @qts0312 means is that istiod should report an error after validation, or remove matching rules of header uri/scheme/method/authority from XDS. Although this behavior is prohibited in the document, I think we need to raise stronger hints in validation because silent violations are prone to errors.

We cannot do such way, because it may break some users. Add a Warning is accpetable

I know. Thanks for your answer.


Disable chrome styled input elements

This reverts the UI changes from #301 (explanation) without reverting the disabling of spellCheck.

Makes sense, thanks!


Reconfigure/disable renovate

I don't know what the config options are, but it's extremely spammy in the current form. It would be better if it sent a single PR with all updates periodically or something like that.

Yeah, I'm sorry about that, it shouldn't be that way. It was correctly updating dependencies in the background and grouping them into one PR. Then I disabled CircleCI, and it opened the floodgates.
The Renovate setup wasn't the one I anticipated so I didn't see that coming. I assumed it was doing silent updates on branches based on master, while it is actually doing PR updates on chore/renovateBaseBranch.
I can't really disable Renovate completely as I kinda need it running to configure/debug it. All I can suggest is muting the notifications for this repo while I work on the fix :pray:

Renovate should be going more smoothly now. It should be back on its initial configuration of creating PRs to merge on chore/renovateBaseBranch, and we decide to merge this branch on master when we need it (I just did it).
But I'd like to discuss more broadly about how you (@Haroenv and @MartinKolarik, and even @bodinsamuel if you'd like to chime in) think we should handle dependency updates.
I'm coming from a background where I try to automate dependency updates as much as I can. If it does not break the lint/test/build process, then I usually let Renovate auto-merge any minor or patch upgrade (I keep any major update under manual review). The rationale is that when I need to upgrade a package (and it's a when, not an if IMO), I don't have a very hard migration from 5 major versions ago where it's hard to pinpoint exactly what fails (because everything fails at the same time).
On this project though, I've come to realize we have taken a more "if it ain't broken, don't fix it" approach with some packages (as we've seen with the git-hosted-info or got packages that work fine and whose upgrade require some work that might not be worth it), and I totally understand the rationale behind it. A regression not caught by our tests might impact thousands of packages in the index.
Whatever we decide to do, I think we should be a bit more explicit about our thought process, and write it down. At least discuss it here between us, maybe write some guidelines in the documentation and configure renovate accordingly.
To ground the discussion a little bit more, what are your thoughts on the two following packages:

got. Upgrading means apparently moving the whole project to ESM. I've never done that before, and it seems like a lot of work, but also something we'll eventually have to do to keep up with the JS ecosystem. Is today too soon? When will it be the right time?

hosted-git-info. We're on v2.7. v2.8 broke our script, and now v7 is out. We currently use it to extract repository metadata from a URL, and if it fails (because it does not handle tree URLs, only root URLs) we fallback to our own implementation. I did a quick POC and swapping the order (first testing our own implementation, and if it fails use hosted-git-info) seem to work (all tests are green). Should we upgrade with this change? Are there unforeseen consequences? Should we pin this dep to 2.7 forever instead?

You have much more experience with the code here than I have, so I highly respect your opinions on the matter and am looking forward to them

I will summarise our approach regarding renovate strategy since it might not be clear from the outside world.
Upgrading dependencies is slow and painful, especially when you are maintaining hundreds of repo. In my previous team we were managing dozens and it was really impossible to test everything.
To "help" we decided to introduce the system of weekly branch merge:

Every friday a branch and PR is created
Renovate runs on the weekend to avoid slowing down business critical CI (shared runners)
On monday you review and merge

Why not merging directly?
Because, and especially in this repo, some part are not tested or hardly testable. So a broken update can enter the main and it's even more painful to test, make a PR to revert, etc. For something this is not always urgent.
It creates only one commit in main which limits noise and is easy to revert, test and add to the changelog.
The downsides
It requires at least one human intervention (can be weekly or less often though)
If nobody merge the branch, it will be updated indefinitely and main will still be outdated.

Keeping this strategy is up to you, I don't have strong opinion it just served us very well during the years.

Regarding the broken updates,  I think it's fair to say we (you) need to do something:

I had left hosted-git-info on the side for 2 years but it's problematic because everything runs in a live production. If somebody find a security hole and publish a package that exploits it, it could be a real issue (could already be the case). Most people disregard upgrading because they are only managing libraries / local env, but it's a different topic with live environment.

got could be replaced by the native fetch imo

ESM migration, while I don't enjoy the way it was pushed onto the Node env and really struggled to use it for years, it has become easier with Typescript. It would still needs a few hours to migrate I think. And could help for other packages upgrade.

I think Dependabot is forced at the Org level, you can't disable it.

I'm not overly eager to update everything here (especially in an automated way) because the test coverage isn't too great, and if something breaks, the likely solution is a full reindex, which is still slow.
Specifically with hosted-git-info, I did try to update it because the current version throws exceptions for some invalid URLs, but then as I ran into more issues, I decided to just add a try/catch instead. Swapping the order actually might work, but I wasn't 100% confident it won't break some other cases that we don't test.
As for ESM, it's theoretically just an option in the TypeScript config, but realistically, it also impacts production monitoring (APM instrumentation support), running tests/coverage, and some more advanced mocking scenarios. The ecosystem support is fairly good at this point, and I think on this project, the impact should be low, but so is the motivation to do it - all of the Sindre's projects work fine in their older CJS versions, and there is close to zero advantage in running this as ESM at this point.

got could be replaced by the native fetch imo

While I'm in general a fan of using built-in staff, the fetch is very limited compared to got, and its API is a little awkward. For purely backend projects, I see no good reason to use it.

Summarizing the points above, what I think we can do is:
[ ] Document the current semi-manual update strategy in CONTRIBUTING.md.
We seem to all agree that full automated update is too dangerous here, and this strategy has worked well for years, so we can probably keep it.
[ ] Carefully update hosted-git-info to the latest version.
As mentioned, there is a security risk in staying on the old version forever. But also a production risk upgrading because of the low coverage. I have a branch where I updated the version, adapted the code, and have all tests green. As an added precaution, I will also compare this rewrite against what is in the currently index and see if it would have diverged. I will add any difference as new test cases, so we should be covered.
[ ] Keep got and pin it to the pre-ESM version in renovate config
We'll eventually have to move to ESM, but let's wait until we have the whole run stack back in good shape (pending GCP / Datadog integrations). In the meantime we can tell renovate to ignore those packages, to limit the noise, and we'll upgrade them all once the time is right.
Did I miss anything?

(Oh also, I could disable Dependabot. Maybe it will be automatically re-enabled again, we'll see.)

As mentioned, there is a security risk in staying on the old version forever

The security risk is just a ReDos, not applicable in our case. If we'd do anything I'd migrate to what npm uses (a different package if I remember it correctly) or vendor the code

@Haroenv The hosted-git-info is hosted under npm/hosted-git-info, and last commit is September 18th, 2023, so it seems to be active and what npm is using. (https://github.com/npm/hosted-git-info)
Would you had another in mind they could be actually using?


Remove mentions to SciPy and other Python libraries unless in appropriate context

I found scipy in the following
I think all of these are just artifacts of a porting of python to julia code

[ ] jv.rst
[ ] multiplicative_functionals.rst
[ ] odu.rst
[ ] stationary_densitives.rst

I did not find numpy, and the reference to "Pandas" and "python" were all appropriate.    Any others to check?

On this note, we also need to eliminate references to types/structs we created when we moved over to a NamedTuple.


app/uninstalled webhook is not dispatched when the app uninstalled

I have enabled the webhooks  in config as below and its not working as expected AppUninstalledJob  is not dispatched.
'webhooks' => [
[
'topic' => env('SHOPIFY_WEBHOOK_1_TOPIC', 'app/uninstalled'),
'address' => env('APP_URL') . '/webhook/app-uninstalled')
],
],
Expected Behavior
When the app is uninstalled expected to dispatch AppUninstalledJob and the should softdelete the shop in the User table
Current Behavior
When the app is installed WebhookInstaller job is dispatched with the payload as below and registered the app/uninstalled webhook successfully, however upon uninstalling the app from the store the AppUninstalledJob  is not dispatched.
Payload:
{"uuid":"f6142955-a188-4b78-9026-bf8c2c125f84","displayName":"Osiset\ShopifyApp\Messaging\Jobs\WebhookInstaller","job":"Illuminate\Queue\CallQueuedHandler@call","maxTries":null,"maxExceptions":null,"delay":null,"timeout":null,"timeoutAt":null,"data":{"commandName":"Osiset\ShopifyApp\Messaging\Jobs\WebhookInstaller","command":"O:49:"Osiset\ShopifyApp\Messaging\Jobs\WebhookInstaller":11:{s:9:"\u0000*\u0000shopId";O:39:"Osiset\ShopifyApp\Objects\Values\ShopId":1:{s:6:"\u0000*\u0000int";i:1;}s:23:"\u0000*\u0000createWebhooksAction";O:40:"Osiset\ShopifyApp\Actions\CreateWebhooks":1:{s:12:"\u0000*\u0000shopQuery";O:38:"Osiset\ShopifyApp\Storage\Queries\Shop":2:{s:8:"\u0000*\u0000model";s:15:"App\Models\User";s:6:"config";a:27:{s:5:"debug";b:0;s:17:"manual_migrations";b:0;s:9:"namespace";N;s:13:"job_namespace";s:10:"\App\Jobs\";s:6:"prefix";s:0:"";s:17:"appbridge_enabled";b:1;s:17:"appbridge_version";s:1:"1";s:8:"app_name";s:18:"Cogent Shopify App";s:11:"api_version";s:7:"2020-01....................
Failure Information
AppUninstalledJob is not dispatched on uninstalling the app.
Steps to Reproduce

Install app to Shopify store
Uninstall app from Shopify store

User table deleted_at not set
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Package Version: v12.0
Laravel Version: v7.0
PHP Version: v7.3.8
Using a toolset: Laravel Homestead on windows

Failure Logs
Please include any relevant log snippets or files here.

@hameed-kurla Did you wait for several minutes? Here is my log:
webserver    | <IP_ADDRESS> - - [19/Aug/2020:08:07:36 +0000] "GET /scripttags/dummy.js?shop=sanas-test-store.myshopify.com HTTP/1.1" 304 0 "https://sanas-test-store.myshopify.com/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36"
app          | <IP_ADDRESS> -  19/Aug/2020:08:13:15 +0000 "POST /index.php" 201
webserver    | <IP_ADDRESS> - - [19/Aug/2020:08:13:19 +0000] "POST /webhook/app-uninstalled HTTP/1.1" 201 5 "-" "Shopify-Captain-Hook"

2020:08:07:36 is the last request time, i.e. almost the time I have uninstalled the app.
Uninstall hook is called approx. 6 minutes later. This is not related to this repository, that's the way shopify works.

Also, are you testing the webhooks via ngrok or some sort of proxy? They can be very temperamental when trying to use them in this setup.

Closing.


Support MYSQL_TYPE_BIT in MySQL

What language are you using?
Python
What version are you using?
0.3.0
What database are you using?
MySQL
What dataframe are you using?
Pandas
Can you describe your bug?
When the queried database field was bit, an error was reported.
Example query / code
I create a table and the data looks like bellow.

When I queried this table, error occuried.
df = cx.read_sql(conn, "SELECT * FROM test;")

What is the error?
PanicException                            Traceback (most recent call last)
 in
----> 1 df = cx.read_sql(conn, sql_list)
C:\ProgramData\Anaconda3\lib\site-packages\connectorx_init_.py in read_sql(conn, query, return_type, protocol, partition_on, partition_range, partition_num, index_col)
222             raise ValueError("You need to install pandas first")
223
--> 224         result = _read_sql(
225             conn,
226             "pandas",
PanicException: not implemented: MYSQL_TYPE_BIT

BIT type is not supported in mysql yet: https://sfu-db.github.io/connector-x/databases/mysql.html

I would also appreciate this being suported.


test: migrate config unit tests to vitest

Motivation
Consolidate the testing frameworks and migrate to vitest.
Description
Migrate config unit tests to vitest.
Closes #issue_number

Run all tests

:tada: This PR is included in v1.14.0 :tada:


Porting to python3

Hi, is this project still active? I am willing to help you with the porting to python3 as I have good experience doing this from other projects.
We should first make the code work in both python2 and 3 before making the full switch to python3. It would be good to get this done along with the addition of some new features before soccer returns!
Let me know if you are interested and I can get working on this asap!

Yes, it would be good if this worked in Python 3. I can't imagine it being too much work. Maybe some of the messy code will cause some pain.
Back when I was working with this I was always using Python 2.7 just out of habit.
Of course, this used to be more active back when it was just started but now it has stagnated. But new features are welcome along with any refactoring that could make the code tidier etc.
Thanks,

Just setting up this now and some of the unit tests are failing. I am sure it is because of the fact there are currently no live games or fixtures and these exceptions are uncaught. Would you be able to quickly confirm they are not passing for you also before I go any further? Everything else is working just fine.
Thanks

I think a lot (all) are failing and erroring because the code has changed without care of updating the unit tests to accompany the code change.
At least it shouldn't matter that there are no live games. Ideally.
I'll continue to have a look at it anyway.

I think a lot (all) are failing and erroring because the code has changed without care of updating the unit tests to accompany the code change.
At least it shouldn't matter that there are no live games. Ideally.
I'll continue to have a look at it anyway.

Hello, so I have been trying to set this up and work. A peculiar thing i noticed was that i could not get any standings for UEFA Champions League. All other leagues work, and other options like fixtures, work for CL as well. Would you be able to confirm if you have this issue as well? Also, might this be because of the Champions League being divided into multiple groups?
Thanks in advance.

Hmm, CL standings does not work for me.
I can't rememeber if it did work in the past. It may not have ever had the CL standings, but just the fixtures.


SR-IOV Network Operator Helm Chart doesn't work in tag v1.0.0

Using helm chart with above tag I get an issue with wrong path to kubeconfig:
# kubectl logs -n sriov-network-operator sriov-network-config-daemon-7sxf7 E0616 09:26:35.596851  105914 start.go:95] failed to load kubelet kubeconfig: open /host/etc/kubernetes/kubeconfig: no such file or directory panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x1d8c86f] .
However when using master it looks like this problem is solved. I want to use this operator in our product but I need point to some stable commit or tag.
It will be great to specify such a commit with helm chart working on kubernetes.

@mrafalx  could you please specify more details how do you install
sriov-network-operator and what specific versions of operator and chart do you use?

@e0ne
We use this helm version:
$ helm version version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}
And operator is used from tag v1.0.0.
Operator deployment:
kubectl create namesapce sriov-network-operator # --create-namespace flag in helm didn't work
helm install -n sriov-network-operator --create-namespace --wait sriov-network-operator ./ --set operator.resourcePrefix=intel.com --set operator.enableAdmissionController=false.

@e0ne
We use this helm version:
$ helm version version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}
And operator is used from tag v1.0.0.
Operator deployment:
kubectl create namesapce sriov-network-operator # --create-namespace flag in helm didn't work
helm install -n sriov-network-operator --create-namespace --wait sriov-network-operator ./ --set operator.resourcePrefix=intel.com --set operator.enableAdmissionController=false.


Portainer Hangs when leaving a swarm and ingresses in a new one

Bug description
Portainer Hangs if I dinamically leave a managed docker machine from swarm and ingress it in another one.
Expected behavior
Portainer should detect the config change and reflect the changesm instead just hangs.
Briefly describe what you were expecting.
Steps to reproduce the issue:
Steps to reproduce the behavior:

Open portainer normally
Leave the swarm from docker console (docker swarm leave --force)
Create a new swarm (docker swarm init)
Restart the machine (I'd changed the ip and some rules that broke the Docker table)
Docker portainer print logs that service is listening on port 9000 and is started, but docker ps show no port mappings for the container, telnet to port 9000 on container ip doesn't work and docker restart containername also doesn't work.

2018/10/09 22:47:02 Templates already registered inside the database. Skipping template import.
2018/10/09 22:47:02 Instance already has defined endpoints. Skipping the endpoint defined via CLI.
2018/10/09 22:47:02 Starting Portainer 1.19.1 on :9000

If I remove the current portainer container with docker rm containername and recreate another one with the previous volumes, the portainer will login and operate normally.

Technical details:

Portainer version: 1.19.1
Docker version (managed by Portainer): 18.06
Platform (windows/linux): linux x64
Command used to start Portainer (docker compose):
Browser: firefox

Additional context
Add any other context about the problem here.

I am unable to reproduce this on 1.23.2. @jeysibel can you reproduce this on 1.23.2?


normal sealing mode

Currently it only supports "instant sealing" mode, where block production stops if there is no new tx. This works perfectly for most scenarios where we only care about state changes.
However this has some small issues when running chopsticks as a long-running fork testnet, for example:

if I want to test a contract that changes state every block, such as count down
if I want to test a behavior where there are more than 1 tx in a block
some toolings might not be compatible, such as subquery, it might think the chain has stopped

A "normal sealing" mode would be nice a have for the fork testnet, where the behavior is more consistent with the original chain. i.e produce block every configurable X seconds no matter if there is new transaction.

there's also the option to call RPC dev_newBlock every x seconds

duplicates of #101


resourceId description incorrect

In the ARM template, the description of the "resourceId" parameter is incorrect.
The description currently is: "Full Resource ID of the resource emitting the metric that will be used for the comparison. For example /subscriptions/00000000-0000-0000-0000-0000-00000000/resourceGroups/ResourceGroupName/providers/Microsoft.compute/virtualMachines/VM_xyz"
However, the actual template is expecting the full Resource ID of the Log Analytics Workspace for which the alert will be created.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb45c876-8b2a-5e69-3745-5ee47f2bb27d
Version Independent ID: 4ace419b-24da-a3ef-0839-78a2d815cfb8
Content: Creating Metric Alerts for Logs in Azure Monitor - Azure Monitor
Content Source: articles/azure-monitor/platform/alerts-metric-logs.md
Service: azure-monitor
Sub-service: alerts
GitHub Login: @yanivlavi
Microsoft Alias: yalavi

@andrewatfornax  Thanks again for bringing this to our notice , our team will further look into it and get back to you at the earliest.

Adding @harelbr to assist.

Thanks @andrewatfornax!
I fixed the article and this should be reflected soon.

We will now close this issue. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.
#please-close


Update Flexoki Dark.toml to Hex

While putting the webpage up against the terminal I noticed the colors were off. The colors matched the hex but not the rgb (which is confusing).

 That is way more readable on the background.


requirements: Use PyPI fork of line_profiler supporting Python 3.7

Also move it to dev.in.
Other notes for posterity: this should have been installed with a pinned commit hash, and could have been installed directly from the upstream Git repository, even on Python 3.7, as long as Cython was installed as well.

Let's move it to dev.txt with a hash added instead.  I expect we'll want to add some library code using it to make it easy to profile in development (we've used it a number of times and had several more times we wished it were convenient to use).

Done. Also I switched it to a fork on PyPI supporting Python 3.7 so we don’t need to install Cython and don’t need our own fork.

We should probably add a linter parsing requirements.in and complaining about any unhashed installation from Git (or maybe just a check in tools/update-locked-requirements.


[ENH] Classifier _get_train_probs method

Describe the feature or idea you want to propose
_get_train_probs is implemented in some classifiers and used in meta ensembles such as hive cote. There is a fair amount of repeated code and a class to an out of date converter. It should be standardised
Describe your proposed solution
I think a base class get_train_probs with conversions and checks, then a default _get_train_probs that does a 10x CV on the train data, which can be overridden by alternatives such as internal bagging
Describe alternatives you've considered, if relevant
No response
Additional context
No response

Resolved in #1107 and subsequent PRs


Only show messenger inbox to certain types of users

I have several types of user accessing my app: Teacher, Student, Parent, etc. I want to observe all types but only show the messenger inbox to Teacher types.
Is there a way to achieve this without having to code a custom intercom_script_tag?
I hoped there might be a config option for it, something like:
config.show_inbox = Proc.new { |user| user.type == 'Teacher' ? true : false }
I tried passing a similar Proc into config.inbox.style to switch to custom style (ie hide the icon) but it didn't work.

My workaround is to allow config.inbox.style to have nil value. When inbox.style is set to nil, no widget options will be attached to the intercomSettings script. This is already supported in the ScriptTag class, so no other changes are required.
And then in my ApplicationController, I created this before_filter to set the inbox.style:
before_filter :set_intercom_widget_inbox_style

def set_intercom_widget_inbox_style
  if current_user.is_a?(Teacher)
    IntercomRails.config.inbox.style = :default
  else
    IntercomRails.config.inbox.style = nil
  end
end

Here's my fork:
https://github.com/krismartin/intercom-rails/commit/accd9afb5f998467f2911f65d0ec57d44a6aeb16
Note: You also need to disable the in-app messenger option in your Intercom settings as described here:
http://docs.intercom.io/configuring-Intercom/in-app-messenger#can-i-make-the-in-app-messenger-only-available-to-selected-users
What do you guys think? I'll create a pull request and update the test spec if you guys think this is acceptable.

This fork is working well for me, thanks.
There's probably a better way to implement this though. Setting inbox.style to nil doesn't feel right - seems like it should be :none. Or maybe setting inbox to :false might be more semantic?

@weavermedia good idea! I like :false.

Ok, looks like the workaround worked.
At the moment I dont think we have a plan to include this in the plugin.


Testimonial page

Description
All testimonial is of different sizes and I can fix the size of testimonial.
Screenshots

@GAURAV1-ui  go ahead update the ui of the testimonials page and testimonial also


Substitute from "Flutter is an alpha..." to "Flutter is a beta..." in README

I heard from a friend of a friend of a friend that someone said Flutter entered beta a couple weeks ago. :)

It's already been changed. Thanks for your submission.

Cool cool :)

Cool :cool:


v2v: use datavolume instead of PVC

Hot fix only.
The PVC should be enough but recent validation within UI expects the PVC to be already
created if used in the StorageTab of the Create VM Wizard.
The v2v flow will create the PVC during final step of the wizard, right before
creating the Conversion POD.

Pull Request Test Coverage Report for Build 1000

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 86.31%

Totals

Change from base Build 800:
-0.02%

Covered Lines:
2659

Relevant Lines:
2944

💛  - Coveralls

Pull Request Test Coverage Report for Build 801

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 86.31%

Totals

Change from base Build 800:
-0.02%

Covered Lines:
2659

Relevant Lines:
2944

💛  - Coveralls

The v2v flow will create the PVC during final step of the wizard, right before
creating the Conversion POD.

aren't the PVCs created with the vm's TemplateModel ? How does the Conversion pod get started? link to the documentation (if there is one) should be enough..


Unable to get digest auth to work like in example

I am trying to use http-auth to get custom (non-file based) digest auth to work between chrome/firefox and hapi+http-auth. I have modelled my code after the digest_nofile.js example but I can't get it to work with a browser client (firefox or chome). My custom function get's called but the hash I compute (like in the example) gets rejected. Both if I specify  qop: 'none' and  qop: 'auth' in the settings object.
Also, I don't understand the claim of the example that the hash should be simply be computed as md5(username:realm:password) to be passed to the callback - what about the nonce and cnonce etc mentioned in the wiki about digest auth (https://en.wikipedia.org/wiki/Digest_access_authentication)?

md5(username:realm:password) is just part of Digest authentication standard https://tools.ietf.org/html/rfc2617, you can change it anyhow, however the result will be your custom standard and you cannot call it Digest anymore.


{Iot Hub} Removed remaining PnP parts

Description
Removing the remaining legacy parts of the PnP as this is unused and the commands has already been moved to the extension.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

Iot Hub

@anusapan May I ask will these deletions cause breaking changes to customers?

@anusapan May I ask will these deletions cause breaking changes to customers?

No, these are the files which aren't in use anymore

@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before?

@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before?

@zhoxing-ms Adding SDK here, was a long time back, but now we are doing some data-plane operations, So we have planned to move this out to iot-extension. Everything already moved to the extension and this PR is for removing the remaining files which are no longer in use

@anusapan This code looks like SDK code, just be curious, may I ask why was it put in CLI before?
@zhoxing-ms Adding SDK here, was a long time back, but now we are doing some data-plane operations, So we have planned to move this out to iot-extension. Everything already moved to the extension and this PR is for removing the remaining files which are no longer in use

Got it~ Thanks

Because there is no code owner, nobody could merge the PR now @yonzhan

@digimaun Could you please help to review and merge this PR?


Create new resource page for "similar organizations"

Request
Let's add a page under resources located at https://techqueria.org/resources/similar-orgs with the title "Similar Organizations 👀"
Why did you make this request?
Let's showcase other friendly organizations dedicated to supporting Latinx in Tech.
Any additional context?
Yes, here are a few organizations we would like to initially add:

Latinas in Tech - https://www.latinasintech.org/
SHPE - https://www.shpeconnect.org
LOFT Coder Summit - https://www.loftcsl.org/programs/loft-coder-summit/
TECHNOLOchicas - https://technolochicas.org/

See #294 for a similar request

Hi, fvcproduction
I would like to contribute to the project.

@phurbalama You're more than welcome to! Let me know if you have any questions.


Guidance to contribute

Hey, thank you for the initiative to pick up the newspaper development!
I'd like to contribute. Could you provide guidance on which issues I could work and anything else relevant (code style, tests, etc)?

Hi Renato!
Thanks for your proposal. Sure any help would be great.
If it's ok with you, I will be back after the new year with some proposals.
Let me know if it works for you!
happy new year!

Hey, sorry for the delayed response. That works great, no worries. Happy new year!

Hello @byrro !
I wrote a small how-to guide for contributing https://github.com/AndyTheFactory/newspaper4k/blob/master/CONTRIBUTING.md
Additionally, i started here a new section of discussions where I post some ideas that would help the project.
https://github.com/AndyTheFactory/newspaper4k/discussions/categories/areas-in-need-for-your-contribution
Of course, any suggestions you have are welcome

Awesome, thanks for the guidance!
I'll start trying to replicate the list of issues in the current minor version.


ClientConnectionEvent.Join fired twice

The ClientConnectionEvent.Join event is fired twice upon a player joining the server.

Only does it once in my test (SpongeForge)
Maybe you've registered your listener twice?

My bad, yup.


There is no specific functionality just to check the objects that are deployed as part of helm #12722

There is no specific functionality just to check the objects that are deployed as part of helm, 'helm get all' command provides manifest file. which is hard to filter.
Can we get a simple helm command that displays all the objects that were deployed as part of the release.

Duplicate of https://github.com/helm/helm/issues/12722
CC: @VinayakRaoB

/assign

(reopened other issue)


fixed keyboard issue

Fixed keyboard issue #16 by adding an event listener to it, Now, users can use their keyboard to input numbers, operators, and perform calculations just like they can by clicking the buttons(td) on the calculator interface.

Thank you @ify47,
I have a question. Would you be able to assist with fixing issue #19? It would be greatly appreciated, but please don't feel obligated to do so if you are not interested.
Thank you kindly 🙏
Best regards
NH

Sure thing! @N3v1

Thank you very much @ify47


#3398 #3399 #3400

#3399 edit(file = '') is broken on VS 2017

not specific to 2017.
Fixed incorrect calculation of ~/
Made reliable opening of files since some 'traditional' methods fail on CPS
If file is already opened, just activate

#3398 Get tooltip for nested function call

Use AST rather than signature help utilities

#3400 Update package installed in Program Files crashed RTVS

Hide button as we do with uninstall. Packages in Program Files location cannot be uninstalled or updated
Added exception handling just in case

Wrong branch


Fixed formatting of the English installation documentation

There is a code block in the English Installation from source documentation, which is not properly closed. This pull request adds the missing backtick ` to close this codeblock.

Codecov Report

Merging #10485 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10485   +/-   ##
=======================================
  Coverage   43.69%   43.69%
=======================================
  Files         586      586
  Lines       81410    81410
=======================================
  Hits        35569    35569
  Misses      41432    41432
  Partials     4409     4409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea77939...f19b373. Read the comment docs.


pre_training with extra data

Hello, you said that the model pre-training effect means training on the basis of the Chinese pre-training model provided by Google, adding the data on hand, and then training the model?

Hello, you said that the model pre-training effect means training on the basis of the Chinese pre-training model provided by Google, adding the data on hand, and then training the model?

@charlesfufu
If I want to continue to do pre-training on Google's checkpoint with my own corpus, then do I need to do my own participles, clauses, and then form my own vocabulary?I use the Chinese corpus。


:root break the layout of my entire app

Hello,
This code:
:root {
  font-size: 16px;
}

Will break every project using em/rem units. When using thoses, the font-size is most of the time set to font-size: 62.5% to be able to have 1em = 10px, but because of this line all the layout is broken.
Why imposing a font-size to all the application (:root = <html>), why not only :host ?

Will fix this in the next release


Create a downloaded example directory after install

There are a lot of downloadable examples in vtki that I often use for demos and examples in the docs:
import vtki
from vtki import examples
mesh = examples.download_topo_global()
mesh.compute_normals()
mesh.GetPointData().SetActiveNormals('Normals')
warp = mesh.warp_by_scalar(scale_factor=0.5e-5)
warp.plot(cmap='gist_earth', show_grid=True)

I'm wondering if there is a safe way for those example data files to get saved in the examples directory  under a new directory we could add to the .gitignore within the vtki package?
I could easily implement a check to see if the example dataset has been downloaded before and if not, download it - reducing download time so datasets aren't redownloaded on every call to examples.download_*. However, I am nervous to implement this as some users install vtki to their system python distributions...
I've always used Anaconda to manage my Python envs so permissions aren't an issue but I know a lot of vtki's users harness a system Python which might not give vtki permission to save/alter files in the site-packages folder because it's in some system level directory.
What do you think, @akaszynski?

It might be best not to save in the site-packages folder, but instead create a new folder in the user data directory.  The module appdirs is great for this as it's cross platform.
import appdirs
vtki_path = appdirs.user_data_dir('vtki')
examples_path = os.path.join(vtki_path, 'examples')

On pip uninstall vtki we might run into issues where the user data isn't removed on uninstall.  I can't seem to think of an approach or a hook that removes the example directory on uninstall.

Another alternative would be to create another package vtki-examples that you could optionally download.  This would solve both issues, but the user would have to download the entire package.


Heap limit Allocation failed/JavascriptHeap out of memory

When using hardhat to compile contracts/generate typescript, after the compilation finishes successfully typechain hangs for several seconds before running out of memory.
The most recent addition to the code were some nested Structs (no more than 2 levels), though I've never run into any issues like this before, and definitely no recursive structs.
reinstalling (purging node_modules) did not change the result.
Compilation finished successfully
Creating Typechain artifacts in directory typechain for target ethers-v5

<--- Last few GCs --->

[3314:0x7fe0d0008000]    43338 ms: Mark-sweep 4056.1 (4134.2) -> 4052.1 (4134.2) MB, 3081.8 / 0.0 ms  (average mu = 0.184, current mu = 0.041) allocation failure scavenge might not succeed
[3314:0x7fe0d0008000]    47172 ms: Mark-sweep 4068.0 (4134.4) -> 4063.9 (4159.1) MB, 3795.3 / 0.0 ms  (average mu = 0.092, current mu = 0.010) allocation failure scavenge might not succeed

<--- JS stacktrace --->

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
 1: 0x1100c4515 node::Abort() (.cold.1) [/usr/local/bin/node]
 2: 0x10edc5989 node::Abort() [/usr/local/bin/node]
 3: 0x10edc5aff node::OnFatalError(char const*, char const*) [/usr/local/bin/node]
 4: 0x10ef452c7 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 5: 0x10ef45263 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/local/bin/node]
 6: 0x10f0e6975 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/usr/local/bin/node]
 7: 0x10f0e52fc v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/local/bin/node]
 8: 0x10f0f1af0 v8::internal::Heap::AllocateRawWithLightRetrySlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
 9: 0x10f0f1b71 v8::internal::Heap::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [/usr/local/bin/node]
10: 0x10f0becc7 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationType, v8::internal::AllocationOrigin) [/usr/local/bin/node]
11: 0x10f47449e v8::internal::Runtime_AllocateInYoungGeneration(int, unsigned long*, v8::internal::Isolate*) [/usr/local/bin/node]
12: 0x10f81ddd9 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_NoBuiltinExit [/usr/local/bin/node]
error Command failed with signal "SIGABRT".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@DominicRomanowski this looks interesting. Could you perhaps try to isolate the issue or at least provide a link to the repo?

I will try to reproduce in something I can share publicly, or try isolate over the weekend :+1:
Happened between two updates to contracts that involved adding nested structs (multiple different structs in one struct)

pragma solidity 0.7.6;
pragma experimental ABIEncoderV2;

library Observer {

  struct Observation {
    int val;
    uint blockTimestamp;
  }

  function write(
    Observation[65535] storage self,
    uint16 index,
    uint newVal,
    uint blockTimestamp
  ) internal returns (uint16 indexUpdated) { }
}

contract TestTypechain {
  using Observer for Observer.Observation[65535];

  struct ObservationParams {
    Observer.Observation[65535] observations;
    uint16 index;
  }

  struct Bar {
    ObservationParams fooObservations;
  }

  mapping(uint => Bar) public bars;

  function makeObservation(uint barId, uint newVal) external {
    Bar storage bar = bars[barId];
    bar.fooObservations.index = bar.fooObservations.observations.write(bar.fooObservations.index, newVal, block.timestamp);
  }
}

Heya, I was able to isolate the issue; Removing the size limit (65535) on the array allowed the typechain to compile

@DominicRomanowski thank you! This is a great repro. It will be fixed this week :)

Released as: https://github.com/dethcrypto/TypeChain/releases/tag/%40typechain/ethers-v5%408.0.5

Fix worked perfectly, thank you all for the prompt responses/fixes 🙏


newline char(\n) in stop param leads to 500 error in gpt-3.5-turbo

Describe the bug
unlike text-davinci-003 model, gpt-3.5-turbo model fails when using stop='\n'.
maybe it would be backend problem but it would be good to have front-end translates '\n' into some form that backend server can deal with.
To Reproduce
with openai(0.27.1) package
running this line of code would result in 500 error.
Code snippets
completion = openai.ChatCompletion.create(
  model="gpt-3.5-turbo",
  messages=[{"role": "user", "content":"hello"}],
  stop=['\n']
)

### OS

Ubuntu 18.04

### Python version

Python3.7.15

### Library version

v0.27.1

Verified this locally, passed onto the team to investigate.

Any updates on this?

Give this a try:
completion = openai.ChatCompletion.create(
model="gpt-3.5-turbo",
messages=[{"role": "user", "content":"hello"}],
stop=[r"\n"]
)
https://community.openai.com/t/stop-n-in-gpt-3-5-turbo-leads-to-500-error/87815/12
This worked for me.

it does not result in 500 error but it does not stop model generating multiple-lines of text.

This was fixed a week or so ago, apologies for the issue. Please reopen if you see this again!


The status of graylog_graylog_1 is unhealthy

In docker logs graylog_graylog_1 I see the follow messages:
2023-02-06 07:05:28,363 INFO : org.mongodb.driver.cluster - Cluster description not yet available. Waiting for 30000 ms before timing out
2023-02-06 07:05:38,358 INFO : org.mongodb.driver.cluster - Exception in monitor thread while connecting to server mongodb:27017
com.mongodb.MongoSocketOpenException: Exception opening socket
        at com.mongodb.internal.connection.SocketStream.open(SocketStream.java:70) ~[graylog.jar:?]
        at com.mongodb.internal.connection.InternalStreamConnection.open(InternalStreamConnection.java:180) ~[graylog.jar:?]
        at com.mongodb.internal.connection.DefaultServerMonitor$ServerMonitorRunnable.lookupServerDescription(DefaultServerMonitor.java:193) [graylog.jar:?]
        at com.mongodb.internal.connection.DefaultServerMonitor$ServerMonitorRunnable.run(DefaultServerMonitor.java:157) [graylog.jar:?]
        at java.lang.Thread.run(Unknown Source) [?:?]
Caused by: java.net.SocketTimeoutException: Connect timed out
        at sun.nio.ch.NioSocketImpl.timedFinishConnect(Unknown Source) ~[?:?]
        at sun.nio.ch.NioSocketImpl.connect(Unknown Source) ~[?:?]
        at java.net.SocksSocketImpl.connect(Unknown Source) ~[?:?]
        at java.net.Socket.connect(Unknown Source) ~[?:?]
        at com.mongodb.internal.connection.SocketStreamHelper.initialize(SocketStreamHelper.java:107) ~[graylog.jar:?]
        at com.mongodb.internal.connection.SocketStream.initializeSocket(SocketStream.java:79) ~[graylog.jar:?]
        at com.mongodb.internal.connection.SocketStream.open(SocketStream.java:65) ~[graylog.jar:?]
        ... 4 more
2023-02-06 07:05:58,363 INFO : org.graylog2.bootstrap.preflight.MongoDBPreflightCheck - MongoDB is not available. Retry #1
2023-02-06 07:06:00,364 INFO : org.mongodb.driver.cluster - Cluster description not yet available. Waiting for 30000 ms before timing out
2023-02-06 07:06:30,364 INFO : org.graylog2.bootstrap.preflight.MongoDBPreflightCheck - MongoDB is not available. Retry #2
2023-02-06 07:06:32,365 INFO : org.mongodb.driver.cluster - Cluster description not yet available. Waiting for 30000 ms before timing out

I use docker-compose.yml from enterprise directory without editing. I just created .env file and added values for GRAYLOG_PASSWORD_SECRET and GRAYLOG_ROOT_PASSWORD_SHA2. That's all.
What I do wrong?

@CherMet90 Can you please include the full docker compose logs? Thank you!

Sure!
docker-compose.log

@CherMet90 Thanks for the logs. Apart from Graylog logging the MongoDB error, I can't find anything that explains your problem.

I use docker-compose.yml from enterprise directory without editing. I just created .env file and added values for GRAYLOG_PASSWORD_SECRET and GRAYLOG_ROOT_PASSWORD_SHA2. That's all.
What I do wrong?

I just tried to reproduce it in a clean environment but I can't reproduce your problem, unfortunately. The Graylog setup in the enterprise directory starts cleanly when running docker compose up.
You could try cleaning your environment with docker compose down -v, pull the latest images with docker compose pull, and then try again.
Since this doesn't look like a bug in the Docker Compose files, I am closing this issue.
Thank you!