Lithuanian keyboard pack

(This is a clone of #16)
This is based on the original Lithuanian pack still available on Google Play, but vastly expanded.
In addition to the original three-row QWERTY layout, this pack now also ships:

four-row QWERTY-based layout (similar to the default layout on all PCs) – I chose this to be the default Lithuanian layout (first one in the list and having no qualifiers in its name)
three-row ĄŽERTY-based layout (similar to the official Lithuanian standard keyboard)
16-key vertical layout (which switches to the the aforementioned four-row layout in landscape mode)

I have also cleaned up some files which are generated at compile time and added them to .gitignore.
On top of all that, I am adding a crowd-sourced autocorrection dictionary. That one needs some reviewing, but I think it should be a good start.
The screenshots under StoreStuff were taken on my Samsung Galaxy S2 phone. I couldn't find the theme that was used for the original screenshots, so the ones I made are quite dark and might need to be re-taken.

@menny, @herrlado: Once this is merged, I would love if you could release a new version of this pack on Google Play.

it is now merged.
I can release this, but it will not overwrite @herrlado's language pack.
@herrlado can you clone and release this?

Is it not possible to transfer ownership of a package on Play?

It is possible. Do you want to take ownership from @herrlado?
I can take it, if you can't and Lado is retiring 😃

I guess I'd rather you take it over. :)

It is possible, @rimas-kudelis  would you like to?

I could become the maintainer of this, but I'm not really using ASK, since I bought myself a Swype license a couple years ago and got reaaaaally used to swiping all the things. :)
Plus I have no idea how to sign a package (yet).

Either way, please pull in #18 as well before releasing. Thanks!

ok, no problem, I can release it on play store!

Hm, is it perhaps possible to share ownership of the package? I'd be fine with being its "backup owner". 🙂

I think it is possible to let you admin the play store entry, so change text, images etc. I will check this

what is your google email?

it's rimmas

so<EMAIL_ADDRESS>?

yes :)

please check if you can see the store entry.

Wow, do I really have to pay $25 just to register myself as a developer on Play Store?

:( yes. But once you have done it, it's life time. On app store people pay 100$/year

Right. Well I'll pass for now, but will keep that in mind.

@herrlado so could you release an update?

Does it have a dictionary? I can not build the package,
Error:Execution failed for task ':makeDictionary'.
> java.io.FileNotFoundException: /home/lado/development/android/ask/LanguagePack/src/main/res/raw/words_1.dict (No such file or directory)

We need to publish it also
Screenshots, how it looks like on a 7'' and 10'' tablet.
Also a graphic 512 x 512 and  1024 x 500

I added /src/main/res/raw/  to .gitignore, but that directory is required for the build to be successful. I actually wanted to commit it with an empty .gitkeep file, but I must have missed the fact that the file wasn't added to git. If you create that dir, the build will succeed.
Regarding screenshots: I only have Android smartphones at home, no tablets. Are these screenshots required? Also, what kind of graphics do you need for 512x512 and 1024x500? These images don't seem to exist in master.

@herrlado  ↑

So, do we have new dictionary? I can not build the application. I can organize screenshots or fake them, if it you can not provide them, but how can I build the app?

@herrlado The dictionary is being built during compile time. The real issue is that the directory into which it should be built did not exist in my branch due to my oversight. I've addressed that in my previous comment and in #19.
Regarding the screenshots, kindly please create them if you can.

...or at least that is my understanding (re dictionaries).

ok, let's try.

I've send you the release apk. Please test it.

Yep, seems to work fine.
I had also tested my own debug builds before, and they worked as well.

@herrlado are you still waiting for something?

Will be there in a couple of hour. I have just deployed it there. If you have a translation for the description or another description i can put it also there.

Thanks! Here's a description:

Lietuviški išdėstymai ir žodynai „AnySoftKeyboard“ klaviatūrai.
Tai – „AnySoftKeyboard“ klaviatūrai skirtas plėtinys.
Prieš jį diegdami, įdiekite „AnySoftKeyboard“ klaviatūrą. Tai atlikę, galėsite pasirinkti norimus išdėstymus „AnySoftKeyboard“ nustatymuose pasirinkdami meniu punktą „Klaviatūros“.

I also would suggest to slightly change the English description as follows (this basically swaps singular and plural occurences of the word "layout"):

Lithuanian layouts and wordlist for AnySoftKeyboard.
This is an expansion layout pack for AnySoftKeyboard.
Install AnySoftKeyboard first, and then select the desired layout from AnySoftKeyboard's Settings->Keyboards menu.

I Need also title 30 Chars

AnySoftKeyboard – lietuvių kalbos paketas

It has length 41, we need as title only 30

ouch, sorry. Let's make it as follows then:
AnySoftKeyboard – lietuvių k.

yes, thanks. Done!

Awww, you've changed the title, and now it looks like machine translated. :) The 30-char requirement certainly doesn't make it easy to write a good one, but I believe mine was better.
Also, what about other screenshots? I'd really like the users to know right away that this pack contains multiple layouts. Would you please upload other images as well?

And you somehow deleted the first line of the description. Since the title isn't long enough to be descriptive, that first line should stay in the description.

Done :)

Can you also replace the word "plėtinys" with "priedas"? I think this will sound more natural. Sorry for nagging you like this by the way. :)

It's fine!

thank you once again! :)

@herrlado care to change the title to my version(AnySoftKeyboard – lietuvių k.)  as well? :) I really think that one was better.

But title in english should be english, or not? For Lithuanian language I have the title in Lithuanian.

I meant the Lithuanian title. The one I currently see says "AnySoftKeyboard - Lietuviški", which is suboptimal.

a ok, missed that. Ok changed.

Thanks!

I guess this is gone from Google Play now?

@ziedas It is, for now at least. You can still find the APK on some other sites though.
I've pinged https://gitter.im/AnySoftKeyboard/localization about this again, but it's not the first time that I have, and it's possible the ping will again end up unnoticed and not acted upon.
The sources are still on git however, so all it takes is for someone with a Play developer account and enough motivation to actually build the package and upload it.

I never owned this package. I'm sorry. I'm willing to take ownership on it, and move all its code to ASK official repo.

Wait. I do have the code at https://github.com/AnySoftKeyboard/LanguagePack/tree/Lithuanian

But I do not own the app in the Play-Store (id org.herrlado.ask.languagepack.lithuanian)

Yeah. I wonder what we could do about it. Looking at the discussion above, it seems @herrlado actually made me a co-owner, or at least tried to, but I didn't have a GPC account, and still don't. I could pay the $25 fee, but I wonder if that invitation will still be there. Any idea if they expire?

I don't know if it expires.
Another option - since I have the source code - is to publish the pack under a different app-id. This means that if you already have the pack installed you will not be updated, but new installs will work just fine.

Well, my curiosity got the best of me and I registered. But I don't see Lado's app either. :(

So unless we can still reach him, I guess the app is lost?

@menny I'll try shooting Lado an email and see if he answers. If not, let's go with your option then. Is that okay?

yes. np. I can also take ownership of the pack, if @herrlado wants.

The package is back!
I guess it would be best if we both had the rights to maintain it. Do you know if that is possible?

Can you paste the link to the pack?

It's https://play.google.com/store/apps/details?id=org.herrlado.ask.languagepack.lithuanian, just like it used to be.

@menny is there a separate issue about merging language pack branches to the main branch? It seems your current plan is to merge all packs into a single branch, and I applaud that, but I wonder why it hasn't been fully done yet.

Thanks for looking into this!
This is my first Android so I am not sure what keyboard I will choose in the end (trying out a few now, and I don't like height of the LT buttons currently :) ), but you could add me as a developer as well (I have an account and am quite experienced, tho more with game development than native): zilvinas (dot) ledas (at) dict (dot) lt

@ziedas just FYI: there are themes with somewhat different button heights, and you can disable some bits of the top/bottom rows in ASK settings.

@zledas you can also override the height of keys. In the Themes->Tweaks section you can specify a height factor.

Thanks, looks like I missed some options!

@zledas

(trying out a few now, and I don't like height of the LT buttons currently :) )

I've released a new beta update on Google Play, which increases key height in the default lt layout (https://github.com/AnySoftKeyboard/LanguagePack/pull/256). Feel free to test it if you don't mind. ;)


WIP: Resource requirements tests

Jenkins skip this please.
BOSC2017 work together with @mr-c regarding dynamic resource requirements (runtime cores/walltime/memory/disk estimation/prediction), related with issues:
https://github.com/common-workflow-language/cwltool/issues/483
https://github.com/BD2KGenomics/toil/issues/1647

[x] Fix underlying error in cwltool https://github.com/common-workflow-language/cwltool/issues/483 https://github.com/common-workflow-language/cwltool/pull/488
[ ] release new cwltool and integrate with toil. See also https://github.com/BD2KGenomics/toil/pull/1759

Jenkins, add to white list

Jenkins, test this please

Jenkins, test this please

Closing in favor of https://github.com/BD2KGenomics/toil/pull/1810 -- thanks @brainstorm !


More fixes for release 0.17.0

Fix up multi-node docker instructions
Correct a manifest file that I missed.

LGTM

Shippable is green. Travis hit #8397 for one build. Merging.


replace glide with dep in the developer guide

Since we have changed from glide to dep, we should update the developer guide.
Thanks!

This change is

/assign @gaocegege
Could you please help me to have a look
thanks.

Coverage increased (+0.08%) to 49.861% when pulling bb6005b63e5888ef935fd3f0ded8c6a6013b129a on ChanYiLin:master into e69e88d1cb3e607ce5ea3e5af331e1dbc59403fd on kubeflow:master.

/ok-to-test

/retest

/retest

/ok-to-test

/retest


Responsive events

Made changes to "Events" section to match responsive designs.

Font size issue taken care of, conflict resolved.


lode_linear example does not build

See build log here: https://github.com/lab-cosmo/software-cookbook/actions/runs/7654053666/job/20857231817?pr=31
This seems to be hitting an issue we fixed on metatensor/rascaline.
Ping @PicoCentauri and @agoscinski, since you wrote the example could you try to fix it?

As a side note, we should have a cron build job on this repo, checking the build every week.

Sure, I give it a look. Maybe I cannot make it today, then I do it next week.

Yes after the retreat I can also check it.


Update documentation to run the scans locally

Hi,
I'm trying to run the scans locally but currently facing a bunch of dead references and thus a bit blocked on this:

In https://github.com/flopezag/fiware-security/tree/develop#configuration, it is mentioned a scan.py file but the pointed file does not exist and there is no such file in the source
In https://github.com/flopezag/fiware-security/tree/develop#execution, it is then mentioned a container-scan.py (guess it is same as the scan.py above?) which also does not exist

Hi,
Do you have any news on this?

Thanks for the issue.
You are right, I need to modify a little bit the content of the README file. The final version that I am executing is based on a shell scripts container-scan.sh.j2.
Keep in mind that I create a instance in the FIWARE Lab and automatically deploy all the components using Ansible and after that I execute the corresponding script.
You can take this file and rename to container-scan.sh. Additionally, comment the lines 440-442 and 456-458. Besides, the lines 98, 142, and 190 are related to the communication with the Nexus instance to keep the historical status of the analysis, therefore comment it.
Let me know if you could execute it.
This is a workaround the final version of develop include a go program to execute the tests that will be the base scan procedure on the future and the project will be adapted accordingly to this new program.


Adds client-pkg to the release train

Signed-off-by: Paul S. Schweigert<EMAIL_ADDRESS>Fixes: #184
Adds client-pkg to the list of repos to be cut on release day.
Even though it is a library, because it has dependencies on serving and eventing, it should not be cut until both of those are out. So I've added it to just before client in the list and added a note that, because it's a library, there's no release job in Prow for client-pkg.
/assign @rhuss @dsimansk @dprotaso

/cancel approve

/remove-approve

/lgtm

@dsimansk & @rhuss for final approval

/approve


Don't enable save actions by epf-file settings.

In some cases I like to disable the save actions, but with the previous version I had to delete the epf-file-configuration to disable the plugin. The plugin has enabled itself by the configuration of the epf-file. I could not disable the save action temporarily by unchecking the first checkbox.
I also fixed a typo of a private method.

Thanks @markiewb


Add New API's to Awesome-Transit

Hi there,
I have identified a set of APIs that should be added to Awesome transit:
https://github.com/Simha-Kalimipalli/Urbanism-Links/blob/main/Github/Github_Urbanism_Links.md
Thanks

@Simha-Kalimipalli awesome! This looks like a more general list of links related to urban planning and tranportation. Are there specific APIs you suggest we add?

I've added several visualization related APIs to awesome-transit in prior commits ( see https://github.com/MobilityData/awesome-transit/pull/239) but I'm still figuring out the best place to add several of the tools (see  https://github.com/MobilityData/awesome-transit/issues/238)

Excellent. Closing this issue as it seems like the remaining improvements are captured in #238


Documentation: Github pages website not tracking this repo?

Describe the bug
I was following the greenfield install example at https://azure.github.io/application-gateway-kubernetes-ingress/setup/install-new/, and it failed at the line which installs pod identity.  This line shows as:
kubectl apply -f https://raw.githubusercontent.com/Azure/aad-pod-identity/v1.6.0/deploy/infra/deployment-rbac.yaml

However, when I checked this source repo, I found a different version of the example:
https://github.com/Azure/application-gateway-kubernetes-ingress/blob/8242b5613caa1e8232f1df69a968ec31f359f3b5/docs/setup/install-new.md?plain=1#L170
Seems like github pages website is not being updated?

Checked again and saw that the github pages website is now showing 1.8.6, so it looks like the latest content has been pushed.  closing issue.


is it possible to get auto_id's from list?

hi,
Is it possible to get auto_id's from list? Code below:
app = pywinauto.Application(backend='uia')
app_connect = app.connect(path='testApp.exe')
window = app_connect.window()
panel= window.child_window(auto_id="buttonPanel", control_type="Pane")
wrapper = panel.wrapper_object()
buttons = wrapper.descendants(control_type='Button')

Example so that i will use for loop to print all the auto_id's in that list
for i in buttons:
	print i.print_auto_id()

Hi @nimuston it's possible this way:
for btn in buttons:
	print btn.element_info.automation_id

Thanks

now that i have list of buttons and i know auto_id's of these buttons, how can i click on specific button? example print btn.element_info.automation_id gives me following results:
button1
button2
button3
button4

and i want to click button3

i found a way, i need to create new list and then i'm using that.


Removed unused pragma, some grammar fixes

Just some grammar/typo fixes in the docs + removal of the unused language pragma

I thought I had done it in two separate commits, but somehow my join -> vjoin PR got combined with this one, I'll separate it into two


fix: issue causing entire plugin to no longer function [APE-1207]

What I did
im not sure how this never raised before, but it is now...
plugin is unusable because the auto-generated config causes configuration errors in hardhat and the node never launches.
they must have added more validation recently or something, because really not sure how this went unnoticed, the tests wouldnt even pass. no node would start.
additionally, fixed other things we found in foundry related to remote host connections
How I did it
put config in right spot
How to verify it
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

@charlescooper

@charles-cooper


Show Apache 2.0 license at top of GitHub repo

Fixes #4322
Based on https://choosealicense.com/ and the additions https://github.com/apple/swift/blob/master/LICENSE.txt and https://github.com/tensorflow/tensorflow/blob/master/LICENSE were able to make to the LICENSE file and still have GitHub report "Apache 2.0"
We are able to keep the third-party libraries at the bottom of the file.
I tested this in a temp repo: https://github.com/pjcozzi/temp
I'm going to insta-merge to verify that it works since it looks like the change needs to be in master.
If this works out, I'll make this change to our other repos.
This does not at all change the license terms of Cesium.

Success!!!


Binding in Component Router (1.5) not working

I went through the docs of Component and Component Router and found out that:
bindings in router - not working:
http://codepen.io/srokatonie/pen/wGjRRm
If you try to workaround Require doesn't work neither:
http://codepen.io/srokatonie/pen/jqxXgX
(Stackoverflow topic: http://stackoverflow.com/questions/36426789/binding-in-component-router-angular-1-5 )

Bindings has no effect for a routing component. I answered your question on SE.


move startOnHeadless to NetworkManager

everyone will need this setting in all their projects anyway.
and not everyone wants to use the ugly NetworkManagerHUD.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Upgrade to Flatcar v3033.2.4 in AWS v17.2.0

Upgrade to Flatcar v3033.2.4 in AWS v17.2.0 .

Nick did this already


Broken Link for .NET SDK quick start examples

Expected Behavior
Following links are broken :
-Getting Started with ASP.NET Core
-Getting Started with .NET Actors
-actor samples
Actual Behavior
Links should redirect to correct working urls
Steps to Reproduce the Problem

Open https://github.com/dapr/quickstarts
Go to README.md>SDKS >.NET SDK
Following links are not working :
-Getting Started with ASP.NET Core
-Getting Started with .NET Actors
-actor samples

Merged your fix with #390 and #395. Thanks!


General/ Improve README

We need to improve README file about the project.
Need to include this information:
Which problem this project solves,
Why this problem was not solved by other people/repos,
How it works.
I'm sure that these details will improve this repository, and the whole project itself.
What do you think? @l3r8yJ

@h1alexbel good idea

@h1alexbel I' ve made some improvements, please take a look at README, what do you think?

@h1alexbel I' ve made some improvements, please take a look at README, what do you think?

So far, so good.


Add https://dillo-browser.github.io/

Add the Dillo browser website: https://dillo-browser.github.io/
It is hand written HTML that weights around 115 kB when loading the thumbails.

Welcome Dillo! Happy to have this marvellous little browser here.


Cometindex performance improvements

Describe your changes
This improves the performance of cometindex significantly, especially when many events need to be indexed.
Two accidental problems:

we forgot to add an index between attributes and events, to efficiently get the attributes associated with an event

This alone caused quadratic query performance, which is really bad.

Postgres was doing sorting and hashing to join each attribute + event with the blocks and transactions, before grouping attributes.

First of all, we only want to join the blocks and transactions after already having grouped the attributes together, to avoid adding a constant factor overhead, since some events may have a handful of attributes.
Second of all, we shouldn't be sorting or hash merging at all.
The query should be linear and streaming in complexity, and operate by scanning the events table in order, and then selectively plucking other tables columns using their indices references the event id.
This PR amends the query to make Postgres actually do this, mainly by informing it that only a single block or transaction will get joined with a transaction.
Some performance evidence
Previously, when starting up pindexer from scratch, it would take 200 seconds before being able to start processing events.
Now it takes milliseconds.
old query:
penumbra_raw=# EXPLAIN SELECT
    events.rowid,
    events.type,
    blocks.height AS block_height,
    tx_results.tx_hash,
    jsonb_object_agg(attributes.key, attributes.value) AS attrs
FROM
    events
LEFT JOIN
    attributes ON events.rowid = attributes.event_id
JOIN
    blocks ON events.block_id = blocks.rowid
LEFT JOIN
    tx_results ON events.tx_id = tx_results.rowid
WHERE
    events.rowid > 1000
GROUP BY
    events.rowid,
    events.type,
    blocks.height,
    tx_results.tx_hash
ORDER BY
    events.rowid ASC;
                                                     QUERY PLAN
--------------------------------------------------------------------------------------------------------------------
 GroupAggregate  (cost=1444517.14..4825338.21 rows=27193816 width=162)
   Group Key: events.rowid, blocks.height, tx_results.tx_hash
   ->  Merge Left Join  (cost=1444517.14..4213477.35 rows=27193816 width=187)
         Merge Cond: (events.rowid = attributes.event_id)
         ->  Gather Merge  (cost=1444516.70..2690182.07 rows=10695484 width=130)
               Workers Planned: 2
               ->  Sort  (cost=1443516.68..1454657.81 rows=4456452 width=130)
                     Sort Key: events.rowid, blocks.height, tx_results.tx_hash
                     ->  Parallel Hash Left Join  (cost=28256.44..342071.06 rows=4456452 width=130)
                           Hash Cond: (events.tx_id = tx_results.rowid)
                           ->  Parallel Hash Join  (cost=19944.07..322060.42 rows=4456452 width=72)
                                 Hash Cond: (events.block_id = blocks.rowid)
                                 ->  Parallel Seq Scan on events  (cost=0.00..183912.12 rows=4456452 width=72)
                                       Filter: (rowid > 1000)
                                 ->  Parallel Hash  (cost=12626.92..12626.92 rows=420892 width=16)
                                       ->  Parallel Seq Scan on blocks  (cost=0.00..12626.92 rows=420892 width=16)
                           ->  Parallel Hash  (cost=7950.50..7950.50 rows=28950 width=74)
                                 ->  Parallel Seq Scan on tx_results  (cost=0.00..7950.50 rows=28950 width=74)
         ->  Index Scan using attributes_event_id_idx on attributes  (cost=0.44..1156627.19 rows=27196491 width=65)
 JIT:
   Functions: 28
   Options: Inlining true, Optimization true, Expressions true, Deforming true

new query:
penumbra_raw=# EXPLAIN SELECT
    events.rowid,
    events.type,
    blocks.height AS block_height,
    tx_results.tx_hash,
    events.attrs
FROM (
    SELECT
        rowid,
        type,
        block_id,
        tx_id,
        jsonb_object_agg(attributes.key, attributes.value) AS attrs
    FROM
        events
    LEFT JOIN
        attributes ON rowid = attributes.event_id
    WHERE
        rowid > 1000
    GROUP BY
        rowid,
        type,
        block_id,
        tx_id
) events
LEFT JOIN LATERAL (
    SELECT * FROM blocks WHERE blocks.rowid = events.block_id LIMIT 1
) blocks
ON TRUE
LEFT JOIN LATERAL (
    SELECT * FROM tx_results WHERE tx_results.rowid = events.tx_id LIMIT 1
) tx_results
ON TRUE
ORDER BY
    events.rowid ASC;
                                                           QUERY PLAN
--------------------------------------------------------------------------------------------------------------------------------
 Nested Loop Left Join  (cost=1.59..181924467.06 rows=10694733 width=162)
   ->  Nested Loop Left Join  (cost=1.30..92837341.17 rows=10694733 width=104)
         ->  GroupAggregate  (cost=0.87..2226215.83 rows=10694733 width=104)
               Group Key: events.rowid
               ->  Merge Left Join  (cost=0.87..1956570.52 rows=27192229 width=129)
                     Merge Cond: (events.rowid = attributes.event_id)
                     ->  Index Scan using events_pkey on events  (cost=0.43..433368.16 rows=10694733 width=72)
                           Index Cond: (rowid > 1000)
                     ->  Index Scan using attributes_event_id_idx on attributes  (cost=0.44..1156555.97 rows=27194904 width=65)
         ->  Limit  (cost=0.42..8.44 rows=1 width=56)
               ->  Index Scan using blocks_pkey on blocks  (cost=0.42..8.44 rows=1 width=56)
                     Index Cond: (rowid = events.block_id)
   ->  Limit  (cost=0.29..8.31 rows=1 width=126)
         ->  Index Scan using tx_results_pkey on tx_results  (cost=0.29..8.31 rows=1 width=126)
               Index Cond: (rowid = events.tx_id)
 JIT:
   Functions: 24
   Options: Inlining true, Optimization true, Expressions true, Deforming true

Checklist before requesting a review

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: indexing only.

REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF)

(the perils of using AI generated code 8^))

I've just pushed another commit which further improves startup time for pindexer by using a faster method for logging the count of events to be processed.
Useful when debugging pindexer changes, so that you see results faster.


trace data delay by about  10m

jaeger-all-in-one
version 1.24
storage  badger.
after a service processed some  requests , the service and opertion can be see on the ui, but trace data can not show in the first 10 min .  the data did write to disk, and the file size changed.   why this happen, can some give me a clue ? dose it need some more time to process ? thanks!

Hi Team,
I am also facing the issue with S3 storage. trace data delay around 10m.
Any luck here ?

this problem  cased by time, the span reporter time not the same as the query timestamp...   @devendrapal-ag  check to see if you reporter time  fall  behind .


Add PrivateLink

@didourebai : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Adding PrivateLink recently released in Azure

#sign-off

@doodlemania2: I'm sorry - only the author of this article, @JasRobe, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Object destructuring: inconsistent go to definition behavior for two parameters in the same location

Reproduction: https://sourcegraph.com/github.com/sourcegraph/sourcegraph@8a4f941863621f03e7d2a63d831e2a573b8e2f36/-/blob/client/wildcard/src/components/Form/Select/Select.tsx?L42-43

selectSize navigates to SelectProps.selectSize
isCustomStyle has no further definition

Recording to elaborate on what I mean


add "predict" button to UI when no predictions have been made

Allow scrubbing existing predictions/headstamps and re-running if necessary.


Blocked-Resources creating problems

Prerender returning 504 for urls containing 'TTF' or 'EOT'.
http://mydomain.com/?_escaped_fragment_=/user/activity/5E7D8TTFO23L43

Ah, sorry. I'll escape the . in those regexes. Thanks for letting me know!


RET504 false-positive when nested functions reference the variable

I've searched for RET504 before opening the issue.
def outer() -> list[object]:
    @register
    async def inner() -> None:
        print(layout)

    layout = [...]
    return layout  # noqa: RET504

The rule reports the assignment to layout as unnecessary, and provides a fix by rewriting it as return [...], which will break the inner function.
The rule doesn't trigger when layout is assigned to above the definition of the inner function, however in my use-case a decorator replaces the function with an object, which is then used to define layout, mandating the assignment to layout happens below the function definition.

[tool.ruff.lint]
preview = true
explicit-preview-rules = true
select = [ "ALL" ]

VSCode extension (v2024.54.0), ruff==0.7.1

Sure. Here, note how the function my_button is replaced with the component passed to the decorator:
from collections import abc
from dataclasses import dataclass, field
from typing import TypeAlias

# --------- library code ---------

@dataclass
class Component:
    custom_id: str
    disabled: bool = False

Layout: TypeAlias = abc.Sequence[abc.Sequence[Component]]

class Interaction:
    async def respond(self, content: str | None = None, *, components: Layout = ()) -> None: ...

Callback: TypeAlias = abc.Callable[[Interaction], abc.Awaitable[None]]

@dataclass
class Store:
    ids_to_callbacks: dict[str, Callback] = field(default_factory=dict)

    def register(self, component: Component, /) -> abc.Callable[[Callback], Component]:
        def wraps(callback: Callback) -> Component:
            self.ids_to_callbacks[component.custom_id] = callback
            return component
        return wraps

    def make_id(self) -> str: ...
    async def listen(self) -> None: ...

# --------- user code ---------

def create_layout(store: Store) -> Layout:
    @store.register(Component(custom_id=store.make_id()))
    async def my_button(inter: Interaction) -> None:
        my_button.disabled = True
        await inter.respond("Hello World", components=layout)

    layout = [[my_button]]
    return layout

async def command(inter: Interaction) -> None:
    store = Store()
    layout = create_layout(store)
    await inter.respond(components=layout)
    await store.listen()

And here are a few examples from my library relying on this setup.


Fix memory leak

In EpisodeRunner, the actions should either be detached from the computation graph or be converted into a numpy array before being stored into the replay buffer. In the original code, the entire computation graph for generating the action isn't released and consume unnecessary amount of memory. And may cause OOM if the program has been ran for a long time.
In Logger, the stats should be cleared periodically to avoid accumulating unnecessary logs in the memory.

@j3soon Hi, this is an interesting issue. How many steps should be run to reproduce the OOM issue? Does it exist?

For the memory leak in EpisodeRunner:
Running EpisodicRunner using QMIX with 8M steps using hidden layer with 512 neurons should reproduce the issue.
python3 src/main.py --config=qmix --env-config=sc2 with env_args.map_name=27m_vs_30m runner=episode rnn_hidden_dim=512 test_interval=40000 log_interval=40000 runner_log_interval=40000 learner_log_interval=40000 t_max=8200000 save_model_interval=400000

The CPU memory will grow linearly through time.

For the memory in Logger
python3 src/main.py --config=iql --env-config=sc2 with env_args.map_name=3m runner=episode test_interval=40000 log_interval=1 runner_log_interval=1 learner_log_interval=1 t_max=8200000 save_model_interval=400000

Try logging more data (Maybe 100KB-1MB data per 1 timestep), the CPU memory will also grow linearly through time.

For the memory leak in EpisodeRunner:
Running EpisodicRunner using QMIX with 8M steps using hidden layer with 512 neurons should reproduce the issue.
python3 src/main.py --config=qmix --env-config=sc2 with env_args.map_name=27m_vs_30m runner=episode rnn_hidden_dim=512 test_interval=40000 log_interval=40000 runner_log_interval=40000 learner_log_interval=40000 t_max=8200000 save_model_interval=400000

The CPU memory will grow linearly through time.

For the memory in Logger
python3 src/main.py --config=iql --env-config=sc2 with env_args.map_name=3m runner=episode test_interval=40000 log_interval=1 runner_log_interval=1 learner_log_interval=1 t_max=8200000 save_model_interval=400000

Try logging more data (Maybe 100KB-1MB data per 1 timestep), the CPU memory will also grow linearly through time.
This issue is not as severe as EpisodicRunner, since the size of the log is small in default. The issue only arises when we modify the Logger to log more data that consumes more memory.

Great finding. Cool, do you think the issue is from the actions that are not detached from the graph?

Yes. PyTorch maintains a computation graph during the forward pass to record the tensor operations. When the loss is defined and we perform tensor.backward, the computation graph is back-traced for backpropagation and released along the way.
During training, the computation graph is released since we do perform tensor.backward. While during collecting episode experiences (interacting with the environment), the action is calculated through forward passes and the action tensor is stored directly into the replay buffer. Since tensor.backward isn't called anywhere, the computation graph isn't released, making the memory consumption of the action tensor unreasonably large. Thus we should call either action = action.detach() or action = action.cpu().numpy(). Both of them releases the computation graph.

@j3soon Fantastic finding. I will try it. Very good.

@j3soon  Hi, Bro, I tried to run the code on corridor, but it cannot run, I posted an issue: https://github.com/AnujMahajanOxf/MAVEN/issues/6
Could you please help me?


[Bug]: Metadata block icon and sidebar headers don't appear on Windows

Bug Description
On Windows, with default settings, the metadata block icons and the sidebar headers don't appear, even on hover.
Relevant Screenshot

To Reproduce
N/A
Obsidian Version
1.1.9
Installer Version
0.15.9
In which mode(s) does the problem occur? (if applicable)

[X] Source (Edit)
[X] Reading (Preview)
[X] Live Preview

Which operating system?

[ ] macOS
[ ] Linux
[X] Windows
[ ] iOS
[ ] Android

Checklist

[X] I updated to the latest version of the theme (Settings → Appearance → Check for updates).
[X] When using the Obsidian Insider release, I have already checked out the insider-branch and the issue still occurs there.
[X] If the bug occurred after updating the theme, I read the last couple of entries in the changelog to make sure the bug is not an intentional change. (In that case, there will most likely be a style setting to turn it off again.)
[X] I made sure that the issue is related to this theme by checking that the problem does not occur with the default theme.
[X] In case I am missing an UI element, I have checked that it cannot be re-enabled with the Style Settings plugin.
[X] My issue concerns Obsidian version 1.0+ and I am not using the Legacy Editor (CM5). (Older Obsidian versions and the Lecacy Editor are not supported by this theme anymore.)

Can you try updating to the newest installer version? (Manually re-download obsidian from the website)

Just did so, still having this problem. Also, I realize the screenshot doesn't show the metadata issue, so here's another

Hmm, I cannot reproduce it in Mac, and I don't have a windows device.
You could try whether using restricted mode fixes it, otherwise I don't really know what could cause that issue.

Unfortunately these screenshots are from the debug vault, so they are in restricted mode and with no other addons, themes, or tweaks. I might see if I can debug it myself one of these days just using the inspector -- what sort of div am I looking for?

well, if you want to have a look, here is the css for the hidden sidebar tab headers: https://github.com/chrisgrieser/shimmering-focus/blob/main/source.css#L3011-L3037
and here for the metadata button: https://github.com/chrisgrieser/shimmering-focus/blob/main/source.css#L2470-L2543

a few extra notes I've realized from experimenting:

if I switch to obsidian window frame (instead of Hidden) then the hidden sidebar tab headers start working, although the metadata buttons don't.
when "permanently show metadata block in reading mode" is enabled with style settings, the breadcrumb section ends up higher (to the point where in source or live preview mode it intersects with the three dots):

My guess is that it's something to do with the different ways that Windows and Mac handle the window control buttons (maximize, minimize, close) and maybe Windows users just don't realize that the metadata block should be there? Or maybe its a Windows 11-specific thing and that userbase is small enough no one's reported it yet?

I found a rule in app.css which seems not to be from Shimmering Focus that seems to be the culprit of the "M" frontmatter button not showing up:
.markdown-preview-view:not(.show-frontmatter) .frontmatter-container {
  display: none;
}

Lines 5619-5621 of app.css. Disabling it makes the "M" button show up in reading view by default and the metadata block show up when the style setting asks it to.
Not sure why the "Y" button isn't showing up, though, or even what it's supposed to do.

After playing with it a little more I've realized that the frontmatter stuff is because I had "Editor > Display > Show Frontmatter" turned off, so this might just be intended behavior. I'd checked all my appearance settings but didn't think to check the editor section for something occurring in reading view.
The missing sidebar headers is trickier: after prodding a bit it seems like no mouse events are being registered in that corner of the screen at all. This seems to be because of an app.css rule:
body:not(.is-grabbing):not(.is-fullscreen).is-hidden-frameless .mod-top .workspace-tab-header-container {
  -webkit-app-region: drag;
}

Electron apps don't register any mouse events in drag regions, because the OS is hijacking them so that you can drag the window: https://github.com/electron/electron/issues/1354, https://github.com/electron/electron/issues/7107
This seems to behave differently on Windows than on Mac, for whatever reason. Commenting this rule out makes the hover work, at the expensive of not allowing windows to be dragged using that corner anymore.

Sorry for the spam! After all that, here's what I have as my css snippet to fix this on my side:
body.is-frameless.is-hidden-frameless .titlebar {
	height: 35px;
}
body:not(.is-grabbing):not(.is-fullscreen).is-hidden-frameless .mod-top .workspace-tab-header-container {
 -webkit-app-region: no-drag;
}

I won't put in a pull request for this as I'm not completely sure how the Obsidian theme packaging scheme works or whether this will work on Mac, but if you want to incorporate this then for technicalities' sake I'm releasing this snippet under a CC0 1.0 license.

Not sure why the "Y" button isn't showing up, though, or even what it's supposed to do.

oh that's because that Obsidian feature has been deprecated, therefore there is no raw-yaml-frontmatter anymore, and therefore no "Y" button. Did not have the time to update the screenshot yet. (I mean, Obsidian is adding new features too quickly, so those screenshots get outdated fast 😅 )

After playing with it a little more I've realized that the frontmatter stuff is because I had "Editor > Display > Show Frontmatter" turned off, so this might just be intended behavior. I'd checked all my appearance settings but didn't think to check the editor section for something occurring in reading view.

Ah yes, that is indeed the intended behavior. Glad this part is solved then.

I won't put in a pull request for this as I'm not completely sure how the Obsidian theme packaging scheme works or whether this will work on Mac, but if you want to incorporate this then for technicalities' sake I'm releasing this snippet under a CC0 1.0 license.

haha, not even sure if so few lines of code even count as sufficiently high level to be licensed 😝
No but jokes aside, thanks for putting the time in to investigate the issue, this seems indeed to be a windows-only issue. You can make a PR to the source.css file if you want, then I'll run the build-and-deploy workflow on my end. Or I can just take the snippet and add it to the theme, whichever you prefer. Interference with macos can be avoided by using body:not(.mod-macos) in the selector (only mac devices get .mod-macos as a class on body)

okay, I added it to the theme myself, and credited you for the snippet in the source & README. let me know in case there are still issues with it :)

Thanks! Sorry for going radio silent, school got really busy over the past week or so. Also yeah don't worry about the licensing thing, just know some people are really particular about that kind of stuff and wanted to make sure there weren't any issues.
I'm not sure what's going wrong though, because I'm still finding that this bug occurs when I turn my snippet off, even after uninstalling and reinstalling the theme. Unfortunately don't have any time to debug right now, might check later if possible.

weird. Your snippet is included at line 3040, if you wanna take a look later


Image linking issue

Gogs version (or commit ref): <IP_ADDRESS>0 / 0.11 RC
Git version:  N/A
Operating system: N/A
Database (use [x]): N/A

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (provide example URL): https://try.gogs.io/Fastidious/Ideas
[ ] No
[ ] Not relevant

Log gist (usually found in log/gogs.log):

Description
Image on first README (https://try.gogs.io/Fastidious/Ideas/src/master/README.md), image shows fine. Click "Documentation" (https://try.gogs.io/Fastidious/Ideas/src/master/documentation). Image is broken. Edit document with broken image, preview it, image shows fine. On preview, image path is absolute (as it should be, I think):
/Fastidious/Ideas/raw/master/images/img-02.png
Upon saving, image path changes to relative where document is (not desirable):
/Fastidious/Ideas/raw/master/documentation/images/img-02.png

I think it's your syntax problem, I've fixed for you.

That fixed it, but as it was before it would look fine on preview, but not on regular view. It seems there is an inconsistency between editing preview and saved document.

but as it was before it would look fine on preview, but not on regular view.

Define "preview" and "regular view".

When exiting a document, there is a "preview" tab. That is preview. Regular view is what you see after saving.

This is not regular view?

Yes. But change it to how I had it, and see preview. It will work fine. Save it, and the image will show broken.

I think it's preview's side problem.

@Unknwon could it be made, so absolute paths were used (or make it a setting, if you want)? That way a user wouldn’t need to worry on how many dots and slashes are needed (../../../), it would simply use the absolute path, from repository root (/images/, /documents/images/, etc.).

OK, sounds good to me.

Finally I realize it is impossible to use absolute path because it is no way (too expansive) to determine what branch it is in because branch can have slashes feature/2fa/a/b/c etc. So I fixed relative path for preview:
![](../images/xxx)

You can test on https://try.gogs.io.

@Unknwon I can settle with that, and it works as advertised. 😄 Thanks!


Deleting the value of an input field does not update the model/form value

When selecting some or all content of an input field, either by control + a or dragging the mouse,  and deleting the selection doesn't reflect it's changes to the underlying model or (reactive) form value.
Minimal setup in plunker:
https://plnkr.co/edit/7bTcKwD6R2LwlyVP7eV6
Steps required:

Press the "click me" button
Delete all contents from the input field
Press the "click me" button again
Delete all contents from the input field

=> Result: Input field is empty but the underlying value of the form control is still the old value.
Seems like a bug to me?

Expecting the same with angular. My case is different one, but seems been affected by issue above.

Some input with mask attached, and value = "12345", copy the value.
Delete value programmatically, myControl.setValue("");
Past the copied value again
You won't receive an update event.

More people are suffering from this issue after closer inspection: #696 #713
I got it working by using a combination of the answers in those issues.
First get the elementRef to the input control and then after you have set your value programmatically,
manually call 'dispatchEvent' on the native element.
Since new Event('input') isn't supported yet by all browsers, read IE11, I use a type check to be fully compatible with IE11.
@ViewChild('maskedNatNumber')
elementRef;

if(typeof(Event) === 'function') {
    var event = new Event('input');
}else{
    var event =document.createEvent('Event');
    event.initEvent('input', true, true);
}
this.elementRef.nativeElement.dispatchEvent(event);

An official fix would be nice

The provided plunkr does not work and seems to be changed to your fix.
However, the described functionality should be resolved with the latest version 8.0.5.
Please check and reopen (with plunkr) if needed.


Use 'i915' instead of 'drm' kernel mod as requirement for gpu label

6.0.0 kernel doesn't seem to have 'drm' module anymore and it makes more sense to depend on the i915 module.
Signed-off-by: Tuomas Katila<EMAIL_ADDRESS>

Codecov Report

Merging #1164 (666d516) into main (63481a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1164   +/-   ##
=======================================
  Coverage   52.99%   52.99%
=======================================
  Files          40       40
  Lines        4374     4374
=======================================
  Hits         2318     2318
  Misses       1927     1927
  Partials      129      129

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

While "i915" is the correct module to check, I'm not sure whether checking presence of modules in general is the right thing to do as:

There's nothing telling whether that version of the module supports the given HW
Modules could also be built statically to the kernel, and it would be silly not to provide label although functionality is there, just not as separate kernel module


Procedure body is stored in incorrect syntax in information_schema.routines after ALTER PROC

Description
Currently when procedures are modified using alter procedure in Babelfish, the information_schema.routines catalog updates the definition to be alter procedure ... which is incorrect behavior. This commit fixes the information_schema entry to store the alter procedure as create procedure ...
Issues Resolved
BABEL-4971
Test Scenarios Covered

Use case based -

ALTER PROCEDURE alter_proc_p1
AS
    select * from alter_proc_orders
GO

select ROUTINE_NAME, ROUTINE_BODY, ROUTINE_DEFINITION from information_schema.routines where SPECIFIC_NAME LIKE 'alter_proc_p1';
go
~~START~~
nvarchar#!#nvarchar#!#nvarchar
alter_proc_p1#!#SQL#!#CREATE PROCEDURE alter_proc_p1<newline>AS<newline>    select * from alter_proc_orders
~~END~~

Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
630 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.04%) to 73.572%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tsql/src/tsqlUnsupportedFeatureHandler.cpp
11
86.1%

contrib/babelfishpg_tsql/src/pltsql_utils.c
70
91.82%

contrib/babelfishpg_tsql/runtime/functions.c
218
83.39%

contrib/babelfishpg_tsql/src/tsqlIface.cpp
331
89.74%

Totals

Change from base Build<PHONE_NUMBER>6:
0.04%

Covered Lines:
43896

Relevant Lines:
59664

💛  - Coveralls

The last concern we had is: is it always reliable that replacing the alter with create will be a legal sql ?


fix: Breaking change in MachineAuthProvider constructor

SUMMARY
A change introduced in https://github.com/apache/superset/pull/25247 in MachineAuthProvider caused some custom auth providers to be broken, because of unexpected second argument passed to the constructor. This PR reverts that behaviour and .allows only passing either Selenium or Playwright override auth function, not both at the same time.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@kgabryje would you mind adding your testing instructions?

Thanks for reviews!
@john-bodley Added test instructions. I had skipped this step as this PR is basically a revert to previous behaviour of the auth provider in order not to introduce a breaking change with the Playwright PR


use ~/Library/Logs for service logs

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
Services that use the log_path and error_log_path variables typically use var/"log/...", so they are writable only by the user that installs homebrew. The services are installed as ~/Library/LaunchAgents and run as per-user agents. Would you consider writing logs to ~/Library/Logs/ so any user can run the service without permission errors?
What is the motivation for the feature?
The jupyterlab formula defines a service that includes log_path var/"log/jupyterlab.log". I'm unable to get this service to work in a multi-user setup using the suggested (maybe supported? unclear) installation with a user dedicated for Homebrew.
User "homebrew" (the only user that can brew install anything) installs the package and can use the service. Any other user can brew services start jupyterlab but the service has an error. The error arises because permission is denied for logging. If brew services start .... could set the log_path to ~/Library/Logs/jupyterlab.log then the service ought to work for all users.
How will the feature be relevant to at least 90% of Homebrew users?
Maybe to 90% of brew services users (this is probably a small percentage of Homebrew users) would benefit, because ~/Library/Logs/ is the typical place to expect logs from per-user agents.
What alternatives to the feature have been considered?
I have tried to understand if there is a way to use the HOME environment variable in the plist file, but there does not seem to be any support for this at the launchd level. I think the ~ would have to be expanded when the service file is created by Homebrew.
Redirected to request here in Homebrew/homebrew-services#759.

Would you consider writing logs to ~/Library/Logs/ so any user can run the service without permission errors?

No, sorry, this is long-running, expected behaviour for Homebrew at this point.

suggested (maybe supported? unclear) installation with a user dedicated for Homebrew

This is not a supported Homebrew configuration, unfortunately.

If brew services start .... could set the log_path to ~/Library/Logs/jupyterlab.log then the service ought to work for all users.

Many other services store their data in var and would need read/write permission in there so the log_path is just the tip of the iceberg here.

Redirected to request here in Homebrew/homebrew-services#759.

Apologies for the confusion here but: I didn't request an issue here but that you attempt a pull request for your specific request i.e. making this something that might be possible in a formula's service block.


Now-romantic-gateway-page-added-successfully

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #1334
Description
The "Romantic Getaway" web application is designed to provide users with a curated selection of serene and romantic destinations, perfect for planning memorable trips with their loved ones. The application offers a simple, visually appealing interface where users can explore various romantic locations, read brief descriptions, and visualize their ideal vacation.

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
After
https://github.com/user-attachments/assets/e433f48f-b387-416b-85a0-2e513f805a9e
Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

@pc-daukiya Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉


cleanRomaji breaks valid double N notation

Hi there,
This might be an unresolvable issue, but here goes.
Cleaning valid romaji breaks it.
E.g.:
toHiragana(cleanRomaji("DANNA"))
// DAN'A
// だんあ wrong
toHiragana("DANNA")
// DANNA
// だんな correct

I understand that the rationale behind the following code is to correct outdated writing of romaji
// Convert the NN form into the more common N'
str = str.replace(/NN/g, "N'");

but then, how was 旦那 (husband) written? DANNNA?
WDYT?

/cc @jeresig who originally contributed this useful feature and may have suggestions.


Project.getRepo is deprecated.

Deprication Cop warning:
Use ::getRepositories instead
Project.getRepo (C:\Users\Simon\AppData\Local\atom\app-0.179.0\resources\app\src\project.js:173:12)
Object.isGitHubRepo (C:\Users\Simon\.atom\packages\travis-ci-status\lib\travis-ci-status.coffee:52:24)

Thank you for reporting. Feel free to create a PR if you're willing to, else I'll pick this up when I find some time.


chore: add CODEOWNERS file

What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
This PR add CODEOWNERS file, listing codeowners from Che teams
Which issue(s) this PR fixes:
Link to github issue(s)
https://github.com/eclipse/che/issues/22188
PR acceptance criteria:

[ ] Contributing guide
Have you read the devfile registry contributing guide and followed its instructions?
[ ] Test automation
Does this repository's tests pass with your changes?
[ ] Documentation
Does any documentation need to be updated with your changes?
[ ] Check Tools Provider
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@l0rd can you please add permissions to @svor and @ibuziuk (what CODEOWNERS check complains about)?

@l0rd can you please add permissions to @svor and @ibuziuk (what CODEOWNERS check complains about)?

done


blas/gonum internal/asm/f64: add Dgemv assembly kernels

Two kernels for calculating Dgemv, depending upon the matrix tranpose:
GemvN - No transpose of matrix A  y = alpha * A * x + beta * y
GemvT - Transpose matrix A        y = alpha * A^T * x + beta * y

I promise to have a look at this before the end of the day here.

No worries. Whichever way works for you. I'd like to keep the structure you had by the end since it makes it much easier to follow.
I'll try to get another read in of the ASM code tonight.
@vladimir-ch Do you have some time to look at this too?

I canceled the latest build, since 619d242 is whitespace and comment changes.

That's very responsible of you :).

It's probably worth rebasing this onto master since I have introduced a conflict recently (sorry).

Rebased with fixes from @vladimir-ch comments.

@vladimir-ch's nits fixed and fix commits squashed.

Rebased on master and tested against real-world tasks, so I think it's ready to merge.


Rotation, Dynamic Z-Index and a bugfix

Rotation has the side effect of shifting all sprites so the colliders won't line up correctly. Will wait until Juyas's collision system gets merged to implement a fix for the colliders


Update network-watcher-troubleshoot-overview.md

Some minor edits to the wordings

@halkazwini
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Powertoys run can't find files.

Microsoft PowerToys version
0.80.1
Installation method
PowerToys auto-update
Running as admin
Yes, win11.
Area(s) with issue?
PowerToys Run
Steps to reproduce
My games directory is located on my D:.
If i type "lop" or "lies of p". The app is listed as "lies of p" in installed apps, but the actual file is named LOP.exe. It does not find it. If i type "lop.exe" it still does not find it.
Does not work with "rdr" (red dead redemption)
However, it is working with Horizon forbidden west, Helldivers 2 and others.
I do not understand why this is, why can it find one but not another?
Since the files and or application obviously is located on my pc, i am assuming there is something wrong with powertoys run as it can't find the application. Even tho, it is installed and on the app list.
✔ Expected Behavior
I type "lop" or "lies of p" and it finds "Lies Of P"
❌ Actual Behavior
Asks to search the web for lop.
Other Software
No response

I had a similar issue, it was fixed on my end by re-enabling the Enhanced search in the windows settings. A recent Windows 10 update must've disabled that setting, which basically hamstrung power toys run.
To change that option, you need to navigate to your settings panel, select the Search menu and then switch to the Searching Windows tab. Under the title "Find My Files" check if Classic is enabled instead of Enhanced (or at least use Customize Search locations if you wish to keep Classic)

Just wanted to update that it still has issues finding files. It does a worse job than regular start menu search. As there's instances where start menu search can find installed apps that run can't find.

Can you please look into Windows searh settings -> Advanced indexing options:

And look if the folder containing the executable is being excluded.
/needinfo

Can you please look into Windows searh settings -> Advanced indexing options:
And look if the folder containing the executable is being excluded.

It is not. I also tried resetting that, by removing every folder, after a reboot it had auto populated with the standard excluded folders. Also, if you press "advanced" at the bottom, you'll get a box, which is another place you can also set places to index. My D: where game executables are located is added manually on that list. Everything is indexed.
Just for ultra clarification, let's post some pictures.

I do not know which folders and drives are standard in this box, but i added my d: manually. This has changed nothing.

cc: @htcfreek

@fusk-l
Can you please post a screenshot of the settings for Windows Search plugin in PT Run settings? Is the windows search plugin marked for "global search results"?
The indexing settings in Windows are only take affect for the Windows Search plugin and not for the program plugin. And by default the Windows Search plugin require searching with activation key.
If you like to find your apps and games using the Program plugin you need a shortcut in the start menu or on your desktop.

@fusk-l Can you please post a screenshot of the settings for Windows Search plugin in PT Run settings?

I think this is what you're asking for.


Better error, loading and not found messages on mobile booking header

See:

https://github.com/kiwicom/smart-faq/pull/261/files/727d839bbd3891e0a5de114e0b301137ea73aaa1#diff-0623a081852e113047c6de403c90b336
https://github.com/kiwicom/smart-faq/pull/261/files/727d839bbd3891e0a5de114e0b301137ea73aaa1#diff-0623a081852e113047c6de403c90b336

We need designs for that @mjancik

I will prepare designs, but I am struggling with understanding of what exactly? 😄

@mjancik

Here you could say it could just be hidden, however sometimes the booking header loads faster than the FAQs.

Closed due to obsoleteness  https://github.com/kiwicom/smart-faq/issues/416#issuecomment-397576150


Use EFTlab fork for fixes and features

EFTlab forked and improved PANhunt, including pregoc matching. Compare the code and include the improvements if needed.

There is only prefix based exclusion feature to be considered.
First, the excluded_pans configuration accepts asterisk (*) character, then it excludes the character and save it to another list.
 if len(excluded_pans_string) > 0:
        excluded_pans_tmp = excluded_pans_string.split(',')
        for excluded_pan in excluded_pans_tmp:
            if excluded_pan.endswith('*'):
                excluded_pans_sub.append(excluded_pan[0:-1])
            else:
                excluded_pans.append(excluded_pan)

After separating the input list of PANs to exclude, the application can work with those values with different matching logic: excluded_pans list requires full matches to exclude while excluded_pans_sub needs a partial match.
    @staticmethod
    def is_excluded(pan):
        global excluded_pans, excluded_pans_sub

        pan = re.sub('[^\d]','', pan)

        for excluded_pan in excluded_pans:
            if pan == excluded_pan:
                return True
        for excluded_pan in excluded_pans_sub:
            if pan.startswith(excluded_pan):
                return True
        return False

It needs to be considered but not a priority.


MalformedDocumentException: Missing document expires

When trying to send a ID transaction to the simulated ID chain, the received DID Document payload is invalid.
The SDK doesn't serialize "expires" in the document.

Needed to force to NON_NULL on the expires field because it inherits from class NON_EMPTY (DIDDocument) and jackson seems to consider Date objects as "empty" in utils_1.isEmptyValue()...


RepeatCall shouldn't implement DoubleEndedIterator

For example, the following iterator is definitely not reservable:
RepeatCall::new({
    let mut counter = 0;
    move || {
        counter += 1;
        counter
    }
});

I guess you're right about that, most implementations do not make sense as double ended. You can of course run into this problem in other places, like in a regular .iter().map() too.

That's... odd. I've submitted a bug to discuss it (https://github.com/rust-lang/rust/issues/30632). It kind of makes sense because map (and filter) are generally pure functions but should, at least, be noted.
However, this case is pretty clear; RepeatCall always produces an infinite sequence and infinite sequences only have one end.

I disagree actually, infinite sequences can have two ends (For example .cycle()). Maybe cycle is a bad argument, since I wrote it :smile:

Oh no, cycle is not double ended! My evil plans,... Ok I guess I managed to scare you there by mistake.

On the whole, side effectful iterators can always cause trouble like this. I'm leaning towards wontfixing this bug for this reason, it has use cases where double endedness is useful.

Infinite sequences have one end.

-- ZFC
Yes, some sequences can go backwards from the starting point but that's not double ended, it's no-ended (doubly infinite).

I thought this issue could stay open until we make a decision (0.5 is next breaking change opportunity).
Currently I lean WONTFIX.

In a crazy turn of events, I'm removing the DEI implementation in 0.5


Konnofuente/feat/#7 dashbaord atoms component

In this PR i completed all the atoms that needed to be done that is
Button✅
Switch✅
Checkbox✅
Select ✅
I also wront this documentation at the top of all thier files

There is a problem: you didn't use shadcn to create your components. You made it from scratch


More presize left position on fixed state

More presize left position on fixed state

Thank you for the PR. :) I'm wondering - couldn't this be simplified by using parseFloat? I can't think of an example in which parseFloat gives the wrong value.

May be :)
I'm just a beginner, and it worked for me.


data updating wrappers

Supporting C/C++ interface changes in response to https://github.com/oxfordcontrol/Clarabel.rs/issues/59 and the corresponding update at https://github.com/oxfordcontrol/Clarabel.rs/issues/63

Is there anything preventing this from being merged, and making a release?

by the way thank you again!


[Feature Request] Release gpu memory by API.

Description
When it is required to do a forward propagation at first, and then do another one in the same process,
if gpu memory malloced by the first propagation can not be released, the second one will not have enough memory to use.

@DuCheng2018 Thank you for the feature, request.

@mxnet-label-bot add [Feature]

I am getting multiple request similar to this one, I think we need a formal C API as well as python API so user can explicitly release gpu memory pool without waiting for program to exit.

+1, for some application it is necessary to release gpu memory.

+1, yes, this is a function needed badly

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Hi, there.
Thank @vladoovtcharov for adding this API for GPU memory release.
The API is mx.gpu(0).empty_cache().
Firstly, we should set the environment variable MXNET_GPU_MEM_POOL_TYPE to use GPU memory pool.
Here is an example:
# MXNET_GPU_MEM_POOL_TYPE=Round python
Python 3.6.9 |Anaconda, Inc.| (default, Jul 30 2019, 19:07:31)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import mxnet as mx
>>> a = mx.nd.zeros((1000, 1000), ctx=mx.gpu(0)) + 1
[14:56:53] src/storage/storage.cc:110: Using GPUPooledRoundedStorageManager.
>>> a = mx.nd.zeros((10000, 30000), ctx=mx.gpu(0)) + 1
>>> del a
>>> mx.gpu(0).empty_cache()

In my test, the most GPU memory will be released after calling this API, although there is still around 600Mib memory cache.

This API only releases the cache in the GPU memory pool. It doesn't release the NDArray cache held by CachedOp

+1

Closing this issue as #14252 is merged, please feel to ping me if you have other thoughts.


gdpr-cookie-consent-banner with SvelteKit

Does the consent banner work with Sveltekit? I tried to implement it but I get this error:
SyntaxError: The requested module<EMAIL_ADDRESS>does not provide an export named 'validate'

OK @antony  I'll see what I can do. thx.

I'm also trying to get this working on SvelteKit. Would you be interested in a PR if we could get it to play nice @antony?

Hey @jcamilleri13 - We'd absolutely love a PR!

Ok, I think I've got it working - #28.
I've tested it on my own SvelteKit project and it works nicely. There's been a minor change to the exported bundles, but I think it might be because I compiled them with a different minor Svelte version. Nothing seems drastic enough to affect functionality.
The cookie-universal dependency isn't ESM-compatible yet, so that will also need to be updated, but I've included information on a workaround in the README.

Resolved by https://github.com/beyonk-adventures/gdpr-cookie-consent-banner/pull/28
thanks! :partying_face:


[Feature Request] Reposition app tour if element moves

It would be nice to have the app tour move with the element if the page shifts (due to something loading) or is resized.

It would be complicated to track that in the plugin. You can however achieve it using:
driverObj.overlay.refresh();


Feature Request: Disable vertical scroll

First of all thank you very much for your work.
One more thing.
Could you maybe add an option that disables vertical scrolling?
Greetings Christian

PRs are welcome 😁👍


possible rendundant vendor

Hi, I ' ve noticed that shutilwhich is for importing which function. At description at pypi is said that it is not needed in pythons 3.3 and above. From setup.py I asume you don't support versions below 3.3. https://github.com/pypa/pipenv/blob/d5e446ee7bd0e769c385331714c8616c6b6738b8/setup.py#L130
And it seems you dont import this vendor in your project.
https://github.com/pypa/pipenv/search?q=shutilwhich&unscoped_q=shutilwhich
Hope that the issue is meaningful

@PatrikKopkan Thanks for reporting.

I asume you don't support versions below 3.3.

But we need to support Python 2.7, don't we? I think it is there for Python 2.7.

Thank you for your response.
From reading your code I still have feeling that it is not actually used. Could you point me to where it is needed?

No, it isnt needed for Python 2.7.
It is unused.  It was vendored due to pew, but that has been removed/unvendored by @uranusjr  in a5a9583 .  It was used by pipenv/patched/pew/_utils.py .
c.f. also https://github.com/pypa/pipenv/issues/3640

I believe Pipenv still has a few places relying on the system which command (or where on Windows). We should convert those to shutil.which instead. cc @techalchemy

There are a lot of which ... system_which should like the one you are referring to.  It falls back to pythonfinder.Finder , which appears to do the job of shutil.which
grep -r def.*which pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/*.py
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/core.py:def which(command, location=None, allow_global=False):
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/core.py:def which_pip(allow_global=False):
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/core.py:def system_which(command, mult=False):
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/environment.py:    def which(self, search, as_path=True):
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/project.py:    def __init__(self, which=None, python_version=None, chdir=True):
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/project.py:    def which(self, search, as_path=True):
pipenv-2<IP_ADDRESS>3215385.742ae1b9/pipenv/resolver.py:def which(*args, **kwargs):

If this packport is going to be used again , please also provide some consistency/direction on whether all backports should be in pipenv/vendor/backports/ , because it is quite confusing to have enum in there, but scandir not in there, etc.

backports.* is the namespace used by a series of libraries. Whether a vendor ed package live inside it depends on how the upstream package does it, not how Pipenv organises it’s vendoring process.

@uranusjr , pipenv/vendor/backports/enum is enum34, and is not in the backports namespace.

https://github.com/pypa/pipenv/pull/3676 opened to check if this really is unused.
I note that shutilwhich monkey patches the real stdlib shutil.which, and so should only be used if that really is necessary.  It should be removed if possible.
The less intrusive backports.shutil_which should be used, as it doesnt modify the stdlib, and it has a much better test suite.  shutilwhich tests only test that its monkey patching works, while backports.shutil_which verifies its function works correctly.

Thank you all for hearing me out.


Investigate relevance of JupyterServerProvider API

https://github.com/microsoft/vscode-jupyter/issues/13894

Thanks @gjsjohnmurray
I was planning on creating an issue in here, but you beat me to it, thanks
I'm one of the engineers working on VS Code, and the above API should in theory make it unnecessary for users to have to manually enter the server information.
Your extension could utilize the API and contribute a server named InterSystems IRIS or the like .
Here are some samples for the usage of this API

https://github.com/microsoft/vscode-extension-samples/tree/main/jupyter-server-provider-sample
https://github.com/microsoft/vscode-jupyter-hub

Basically all of this would be unnecessary:
* In the quickpick titled "Select Kernel" choose Existing Jupyter Server....
* In the next quickpick ("Select a Jupyter Server") choose Enter the URL of the running Jupyter server.
* Enter http://localhost:50773/servername:namespace?token=1 when prompted. Replace servername with the name of the ( Server Manager definition you previously created. Replace namespace with the target namespace on that server. Do not omit the colon between these two elements. For example http://localhost:50773/iris231:USER?token=1
* On the next prompt ("Change Server Display Name") enter a suitable name, for example IRIS231 USER. Don't leave this blank, else the display name will default to localhost, meaning you won't be able to distinguish between entries you create for different servername:namespace combinations.

@gjsjohnmurray wanted to reach out to you about a proposed API that will make it unnecessary to create a fake jupyter server.
Today I can see that you have a fake server that handles http requests and the like,
Its possible (via a proposed API) to contribute a jupyter server that doesn't listen to any HTTP endpoints.
I.e. you can intercept all of the messages (http calls are made using a fetch implementation that can be provided by 3rd party and similarly websocket class implementation too can be provided by 3rd party, which means http requests completely unecessary.
Let me know if this is something you'd like to implement and I can led a hand.
Here's the proposed API that makes all of this possible https://github.com/microsoft/vscode-jupyter/blob/main/src/api.proposed.jupyterSettings.d.ts


Create support for Beta Program or Alpha Program

Is your feature request related to a problem? Please describe.
Allow users to join FlutterMatic beta program if they are interested in early testing. This means that the default channel is stable, but they can switch between beta and alpha too.
Describe the solution you'd like
An option in settings to join the beta or alpha program.
Describe alternatives you've considered
Alternative is to download manually, build manually, and then start using. Totally inconvenient.

Need more ideas about it. Beta and Alpha stages cannot be given directly even this is an open source project. Need to rethink twice before working on this issue.


Fix OneDrive Policy

Apply the "Prevent the usage of OneDrive for file storage" policy correctly. Previously, it created HKLM:Software\Policies\Microsoft\Windows\OneDrive\OneDrive="DisableFileSyncNGSC". However, the value should be HKLM:Software\Policies\Microsoft\Windows\OneDrive\DisableFileSyncNGSC=1

See: https://admx.help/?Category=Windows_10_2016&Policy=Microsoft.Policies.OneDrive::PreventOnedriveFileSync

I just tested it, and I'd recommend for merge.


A rough tool for detecting and cleaning up after Google API resource …

…leaks.
This is only tested informally. Be careful if actually deleting stuff.
With great power comes great responsibility.
@lwander Please review
The idea is we can run this before a test suite then again after a test suite and report the differences to catch the leaks we had last week. In addition you could have it delete the differences if you trust it. I imagine we could use this to manually clean up after test failures that leave resources around to investigate, for example. You can scope exactly which resources (but not which instances) to operate on. Note that this is API-generic though I only tested it with Compute and Storage. There's a chance that other APIs are specified using different patterns or would stumble into a huge result set.
@duftler FYI, this is in response to the offhand exchange we had Friday.
Its rough, but it works and provides the baseline to do something more interesting with later.
The core is actually pretty small, but there's a bunch extra functionality around it.
It's built on citest agent because it already provided most of the introspection to make this completely generic (as far as I know) and could be useful for citest. But the class within citest isnt that big so I could break it out.

LGTM


min and max function

Linked to #1015
closes #1014
Changed the name of the method from max_and_min_ground_range to min_and_max_ground_range in all relevant files.
Changed the order of the parameters in the return statement.

Investigating the failing tests

They are network failures, unrelated to this pull request. Merging!
Also @nzare, for future pull requests, if you push to the same branch, the pull request gets updated. Therefore, you don't need to open a new one :)
Congratulations on your first contribution! :rocket:

Thanks  @astrojuanlu will keep that in mind


global: Talisman 0.5.1 incompatibility

The new patch version of Flask-Talisman removes the local_options member for the Talisman class, rendering the CSP override "hack"  ineffective.
Since the patch is an "experimental" fix by the author of Flask-Talisman to address some race condition issues. it might be better to pin to <0.5.1 and wait to see if the issue is actually mitigated. In case it is, to upgrade to 0.5.1 we should attempt to override the flask_admin.base.BaseView._run_view method instead of _handle_view and set the talisman_view_options attribute appropriately.

Seems like flask-talisman v0.6.0 has been out recently. Probably worth giving it a try to upgrade...

With invenio-app==1.1.0 and flask-talisman==0.5.0 I get
AttributeError: 'NoneType' object has no attribute 'local_options'

In
setattr(invenio_app.talisman.local_options,

What specific tests need to be carried out to check compatibility with flask-talisman==0.6.0? Just the travis pipelines?

Please verify if there's anything needed for this issue still, or if it has been solved and can be closed.

Plz fix https://github.com/inveniosoftware/invenio-app/issues/78
Its 3 years since it was fixed by talisman.


iOS build issues

If i include blue falcon in my multiplatform project in section iosMain, adding
implementation("dev.bluefalcon:library-iosx64:0.5.4")
implementation("dev.bluefalcon:library-iosarm64:0.5.4")

Results in (while building from Xcode) error
* What went wrong:
Could not determine the dependencies of task ':knlib:linkDebugFrameworkIos'.
> Could not resolve all task dependencies for configuration ':knlib:iosCompileKlibraries'.
   > Could not resolve dev.bluefalcon:library-iosarm64:0.5.4.
     Required by:
         project :knlib
      > Unable to find a matching variant of dev.bluefalcon:library-iosarm64:0.5.4:
          - Variant 'iosArm64-api' capability dev.bluefalcon:library-iosarm64:0.5.4:
              - Incompatible attribute:
                  - Required org.jetbrains.kotlin.native.target 'ios_x64' and found incompatible value 'ios_arm64'.
              - Other attributes:
                  - Found org.gradle.status 'release' but wasn't required.
                  - Required org.gradle.usage 'kotlin-api' and found compatible value 'kotlin-api'.
                  - Required org.jetbrains.kotlin.platform.type 'native' and found compatible value 'native'.
          - Variant 'metadata-api' capability dev.bluefalcon:library-iosarm64:0.5.4:
              - Incompatible attribute:
                  - Required org.jetbrains.kotlin.platform.type 'native' and found incompatible value 'common'.
              - Other attributes:
                  - Found org.gradle.status 'release' but wasn't required.
                  - Required org.gradle.usage 'kotlin-api' and found compatible value 'kotlin-api'.
                  - Required org.jetbrains.kotlin.native.target 'ios_x64' but no value provided.

Providing just
implementation("dev.bluefalcon:library-iosx64:0.5.4") or implementation("dev.bluefalcon:library-ios:0.5.1”)

Results with:
> Task :knlib:cinteropFirebaseCoreIos FAILED
w: skipping /Users/lynx/.gradle/caches/modules-2/files-2.1/dev.bluefalcon/library-iosx64/0.5.4/b8e445b4bb7b3fa076afa9d68c3619fbb226f7fa/library.klib. The abi versions don't match. Expected '[17]', found '14'
w: The compiler versions don't match either. Expected '[]', found '1.3.50-release-11850'
e: Could not find "/Users/lynx/.gradle/caches/modules-2/files-2.1/dev.bluefalcon/library-iosx64/0.5.4/b8e445b4bb7b3fa076afa9d68c3619fbb226f7fa/library.klib" in [/Users/lynx/Workspaces/ios/KNProject/Pods, /Users/lynx/.konan/klib, /Users/lynx/.konan/kotlin-native-macos-1.3.61/klib/common, /Users/lynx/.konan/kotlin-native-macos-1.3.61/klib/platform/ios_x64].

FAILURE: Build failed with an exception.

Also there is no "library-ios:0.5.4" when building with jcenter, only 0.5.1 version.
My architecture is

Android app which contains k/n library which have dependencies on blue falcon for Android/iOS
iOS app which is pointing to my k/n library via cocoapods plugin

I'm using latest Xcode and latest Android Studio (stable). My kotlin version is 1.3.61

Hi @felislynx-silae - i think the issue you are getting is because the library was compiled kotlin 1.3.50 and not your version 1.3.61.
I will need to re-compile and upload a new version for you, for now, you could pull the repo locally, update the kotlin version and then publish locally and you should be able to fetch it then.
Jcenter:
The old version of the bluefalcon library was using library-ios, the new version is using the names with their architecture - library-iosx64, library-iosarm64

Ok, thank you for response.
Is this possible for you, to publish 1.3.61 compiled this week? If no, then i'll pull the repo locally (usually i try to avoid pulling too much libs as local repos :) ) and update to jcenter when you upload new version.

i will try to do it this week.

I have just released version 0.5.5, please give this a few hours to display in maven central.
This will support 1.3.61. Re-open this issue if you still have the same problem.


Unable to copy connection string in remote environments

Repro steps:

Connect to a remote environment and install the extension in the remote
Right-click an account and choose "Copy connection string"

Action: cosmosDB.copyConnectionString
Error type: Error
Error Message: Couldn't find the required xsel binary. On Debian/Ubuntu you can install it with: sudo apt install xsel
Version: 0.10.2
OS: linux
Product: Visual Studio Code
Product Version: 1.35.0
Language: en

Call Stack
handler clipboardy/linux.js:7:9
process._tickCallback next_tick.js:68:7

Installing xsel on the remote machine results in a different error.
Action: cosmosDB.copyConnectionString
Error type: 1
Error Message: Command failed: xsel --clipboard --input
xsel: Can't open display: (null)
: Inappropriate ioctl for device
Version: 0.10.2
OS: linux
Product: Visual Studio Code
Product Version: 1.35.0
Language: en

Call Stack
Promise.all.then.arr execa/index.js:236:11
process._tickCallback next_tick.js:68:7

It looks like the release uses clipboardy : https://github.com/microsoft/vscode-cosmosdb/blob/v0.10.2/src/extension.ts#L161,
while master has the fix:  https://github.com/microsoft/vscode-cosmosdb/blob/master/src/extension.ts#L159


give tooltip pcts dd.d formatting

closed by https://github.com/BostonGlobe/elections-2016/commit/f7949b056b94331bcd12e0b85d5692ee93f29ccc


Try using bSelectGlobalsForUpdate to fix deadlock issues in production

It should go at the end of function __construct().


Panic when exchanging gossip with c-lightning

While integration testing I noticed a fun panic:
panic: runtime error: index out of range

goroutine 229 [running]:
github.com/lightningnetwork/lnd/lnwire.newAlias(0xc4201d40c0, 0x20, 0x20, 0x0, 0x0, 0x0, 0x0, 0x0)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/lnwire/node_announcement.go:48 +0xdf
github.com/lightningnetwork/lnd/lnwire.readElement(0x1276820, 0xc4205259e0, 0xc27460, 0xc420125f30, 0x0, 0x0)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/lnwire/lnwire.go:565 +0xb93
github.com/lightningnetwork/lnd/lnwire.readElements(0x1276820, 0xc4205259e0, 0xc42072f9c0, 0x7, 0x7, 0x70, 0xcc8ea0)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/lnwire/lnwire.go:590 +0x65
github.com/lightningnetwork/lnd/lnwire.(*NodeAnnouncement).Decode(0xc420125f10, 0x1276820, 0xc4205259e0, 0x0, 0x0, 0x2)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/lnwire/node_announcement.go:125 +0x130
github.com/lightningnetwork/lnd/lnwire.ReadMessage(0x1276820, 0xc4205259e0, 0x0, 0x8e, 0x0, 0x0, 0x0)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/lnwire/message.go:256 +0xe4
main.(*peer).readNextMessage(0xc4202f4f20, 0x1281da0, 0xc420525980, 0xc4204ebee0, 0xc4202630e0)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/peer.go:391 +0x100
main.(*peer).readHandler(0xc4202f4f20)
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/peer.go:543 +0x105
created by main.(*peer).Start
        /home/cdecker/dev/lightning-integration/src/lnd/src/github.com/lightningnetwork/lnd/peer.go:271 +0x83f

It appears to crash lnd completely, instead of dropping the announcement and continuing. No idea yet what causes this, just wanted to give a heads up :wink:

Thanks for the report!
Dug into it a bit, and found the culprit: we never updated our NodeAnnouncement encoding/decoding order after we moved around the features (a257554456cda98afd1532c302c0e5e84de0455e). Will get this fixed very soon!

This should be fixed in the latest version of master. Leaving open for now as to wait for verification before closing.

No longer panics :+1:, though parsing fails and kills the connection. The following gossip messages are created by c-lightning and parse correctly in Eclair, but fail in lnd:
01000e3a2a9376c229a1431e87d8afba0be2d151ffe46ec5aba846efd61159925dde47f277e7bf124807ef2dda4632912de3c9c6bd9f367be588b7be541e4e2ae82cce438995e84341bcc99674bec1540a857c20f1efbc218bf732e5e5cbfb4d1f0a547a2b1688cb111cfdfd5bebb95dbb6d97759e5924223bb61f95f56ced626a0fe600d1cff35e5b16a078e0973679139798652e5dc2ae64c3fbb925022c429b6e5d92bf3f2db75990e5ca4979232d228a6fbab9af9ac84f46f2cdb7425e139605db2db75804b7f0d7f35859a174a22abfd0fdb4baa603da0ed6c02a19a282db8d28e975b208f86081c17910f8a6ed9f4d893eaa6c95333dccd0e8349d732ff85900000008b60000040001021ef55b7ecbe25de36dbf30ccefaa57af66d527055b571a27ab182486ab46a87502f199e30895012b3d47ec578b526b8d22801682f5f52416b568bfb92f897b1cc003555e9121423a340cb4e272fa937d675463dd0efe252680bc315c4e5678223c110279bc983ebf50c6475275acdf8763e375a756ab21e84363dd86fec0a292b2d603

Closing as we located the issue: c-lightning wasn't populating the chain_hash field in the ChannelAnnouncement message.


LCP Loses Entry Element After SPA Route Change

When using the web-vitals library to track the Largest Contentful Paint (LCP) metric in a Single Page Application (SPA), we encounter an issue where the LCP entry element is lost upon changing routes. This problem arises because the web-vitals library captures the LCP metric based on the elements rendered on the page at the time of measurement.
In SPAs, content is often loaded dynamically, and when navigating to a new route, the relevant content may not be fully rendered or may change, causing the library to lose track of the largest contentful element. As a result, the reported LCP value may not accurately reflect the user experience, leading to misleading performance metrics.
How to reproduce

Create any default SPA (Vite etc)
Start listerning onLCP (web-vitals or web-vitals/attribution)
Change route before the scroll on any other interaciton

This problem is at least partially fundamental to the Performance Timeline.  The element references are not held strongly by the performance entry, and so if the page is dynamically updated then the reference may be GC-ed.
However, if you are saying that the web-vitals.js library is buffering the entry and not calling onLCP eagerly enough, I think there is an optional flag value { reportAllChanges: true } where you would be notified eagerly of each (useful) new LCP entry.
Would that help?

Change route before the scroll on any other interaciton

How can you change route without an interaction? Normally you'd have to click or take some kind of interaction to change the root (which would finalise the LCP for that first page). Without that, the LCP can continue to update (as it would for a non-SPA page for late-loaded content that is larger).
Currently there is a proposal to allow multiple LCP measure measurements for SPAs but even that assumes a route change is the result of an interaction.

How can you change route without an interaction? Normally you'd have to click or take some kind of interaction to change the root (which would finalise the LCP for that first page). Without that, the LCP can continue to update (as it would for a non-SPA page for late-loaded content that is larger).

You re right. And its related to the explanation above

This problem is at least partially fundamental to the Performance Timeline. The element references are not held strongly by the performance entry, and so if the page is dynamically updated then the reference may be GC-ed.

But when you try to handle the LCP metric in a callback or even early when Web-Vitals onLCP start observation (or LCPattribution)

This problem is at least partially fundamental to the Performance Timeline. The element references are not held strongly by the performance entry, and so if the page is dynamically updated then the reference may be GC-ed.
And yes again. I described that in the issue

I described the way to reproduce the problem. Just try.
The library returns invalid metric I think, coz of it does not contain the target element

However, if you are saying that the web-vitals.js library is buffering the entry and not calling onLCP eagerly enough, I think there is an optional flag value { reportAllChanges: true } where you would be notified eagerly of each (useful) new LCP entry.

value { reportAllChanges: true } where you would be notified eagerly of each (useful) new LCP entry.

there is the same problem

OK I think we were confused about "As a result, the reported LCP value may not accurately reflect the user experience". Rhe LCP TIME is correct (and so does accurately reflect the user experience), but the LCP target element may be empty if it has been garbage collected (which makes it more difficult for RUM data to help pinpoint the error). Which is more likely to happen for SPAs. Is that correct?
In #477 we worked around this for INP by saving the target element selector details at the time of the interaction (rather than when we reported the INP later in the page). We could also do this for LCP. However, this does have some cost as we're no need to run the selector code for every LCP candidate. We felt that was worthwhile for INP elements since it was fairly common there, but for LCP I'm not so sure. As I say, the SPA case (which this library specifically does not handle at present for LCP) is probably the most common reason.
Anyway, if you can confirm this is the issue, and that workaround would help (note you still wouldn't get the Target Element, but at least would get the Target selector), then we can consider whether to add that or not.

OK I think we were confused about "As a result, the reported LCP value may not accurately reflect the user experience". Rhe LCP TIME is correct (and so does accurately reflect the user experience), but the LCP target element may be empty if it has been garbage collected (which makes it more difficult for RUM data to help pinpoint the error). Which is more likely to happen for SPAs. Is that correct?

At least SPA) I met that in SPA. I'm not sure about the suggested solution for my purposes.

(which makes it more difficult for RUM data to help pinpoint the error)
This is a reason why I've created an issue. Such metric is almost useless as for me.

Anyway, if you can confirm this is the issue, and that workaround would help (note you still wouldn't get the Target Element, but at least would get the Target selector), then we can consider whether to add that or not.

And I'm afraid you cannot prepare selector coz of context (DOM node) is lost at the moment when handleEntries gets an entry but if somehow its possible and the cost is not too high, I think it would be useful for other depelopers

Barry: the same interaction that stops the LCP algorithm might also synchronously trigger the page change.  It looks like web-vitals.js will only look specifically at keydown and click, not other interactions or scroll, and then will also wait until whenIdle.  That means the page might be updated by the time callback is invoked.
I wonder if you could at least change to capture the query selector of the element synchronously in the event handler, before waiting for whenIdle to fire?

And I'm afraid you cannot prepare selector coz of context (DOM node) is lost at the moment when handleEntries gets an entry but if somehow its possible and the cost is not too high, I think it would be useful for other depelopers

handleEntries is called when the largest-contentful-paint performance entry is emitted. But that is then not emitted by web-vitals library (unless it's called with reportAllChanges: true) until the page is either hidden or an interaction happens, at which point the attribution happens.
It's still possible for the LCP node to be empty if there's only a short period between handleEntries and onReport, but it's less likely.
However, in that has using it with reportAllChanges: true should be a good test of that. And you're saying you tried this, and it did not help? Because in that case, the workaround would also not help.

I wonder if you could at least change to capture the query selector of the element synchronously in the event handler, before waiting for whenIdle to fire?

Ah yes the whenIdle won't help things. Capturing it synchronously is what onINP does now.

@tunetheweb yes. Seems it works well. I wanted to suggest such approach, but honestly I didn't catch the lcp element inside the handler. Thank you

Good to hear. I’ll try to get another v5 release candidate with this fix out soon.
Btw this is a work around due to some limitations of these web APIs. So it won’t fix all issues - see https://github.com/GoogleChrome/web-vitals/issues/563#issuecomment-2460997284 for another example it won’t fix. But should make it better anyway.

Can you add the same logic for lcp -> metric.lcpEntry.element?


7.0.0 Breaking Change Documentation Unclear

Is there an existing issue for this?

[X] I have searched the existing issues

Description of the bug
In the 7.0.0 changelog, under "BREAKING CHANGES" simply lists the item: "Extension changed". What does this mean? How do I upgrade?  Is this the module name extension? From the documentation, it looks like it's still imported as fuse.js.
The Fuse.js version where this bug is happening.
Other (please specify in description)
Is this a regression?

[ ] This is a regression bug

Which version did this behavior use to work in?
None
Steps To Reproduce

View the changelog
Read the log for version 7.0.0
Ponder what "Extension changed" means and how a project should upgrade. 🤔

Expected behavior
The Breaking Changes section should explain how to upgrade to this version.
Screenshots
No response
Additional context
No response

This comment clarifies things a bit: https://github.com/krisk/Fuse/issues/746#issuecomment-1895603227


How to find the prior images of the current image？

Hi! Thanks for your contribution. It is an excellent piece of work!
I would like to know how the prior images of the current image are identified in this paper.
Upon careful examination of the MIMIC-CXR-v2 dataset, I have observed that its documentation states, "These study identifiers are completely random, and their order has no implications for the chronological order of the actual studies. " Additionally, the time information in the reports is masked (e.g., "In comparison with the study of ___"). Therefore, I am uncertain about how to identify the prior images corresponding to a given current image.
Thank you very much for your time and consideration. I eagerly look forward to your response.

Hi!
I have the same question, do you know the answer now?