Add the master url config to global Jenkins configs

OpenShift mater url should be configurable in global Jenkins configs and one chosen as "default". Buildsteps should be set to the one chosen as "default" and show a dropdown list for picking the master url. Text field in each buildstep means a change in the url requires every buildstep to be manually updated by the user.

@siamaksade - I couldn't tell for sure if you were aware of this, so just in case, I'll mention that with the existing code you can create a global property today, put the name of that property as the setting for any of the configurable text fields of any of the build steps, and the plugin will substitute the value of the global property for the build step text field when running the job.
That said, I'll look into the jenkins jelly taglibs for drop downs (a quick skim turned up at least 3 of them) and see if there is one that works good for this scenario.

An update:  after some investigation of the jenkins jelly taglibs, I wasn't enamored with the usability of the non-deprecated options out there (most notably the combobox and select).  Got a second opinion from @bparees and he agreed.
We decided on a slightly different approach, but one which we think captures the desire of this item.  Also, this new approach dovetails with a separate discussion we had today with @mfojtik regarding picking up of the namespace / project name setting.
I've got a commit in hand for the plugin ready to push (the changes hence are technically for the jenkins-plugin repo, not the jenkins repo ... @bparees - at least with my level of authority, but perhaps even in general, I don't see how to move this issue over to that repo).
However, aside from giving @siamaksade a chance to comment, there is one detail (a potential change to the jenkins repo) I still want to confirm with @mfojtik (if he consented on IRC, I missed it).
Preamble over.  Details:

API URL and namespace params are still text fields, but no longer have default values (several other fields in fact will be losing defaults)
if not set, the plugin will pull the values for the namespace from the PROJECT_NAME env var now set by the jenkins image (@mfojtik - perhaps we should change this to OPENSHIFT_PROJECT_NAME), and for the api url from the KUBERNETES_SERVICE_HOST env var now set by the jenkins image.
the customer can still use the jenkins global key/value params, or the job level build parameter key/value params, as I mentioned in my last comment
or they can override with the actual value

Sounds good to me, with one minor note:
KUBERNETES_SERVICE_HOST is actually set by openshift/k8s (which is good, it means that variable won't be set when the image is running outside of openshift/k8s).
@siamaksade please let us know if you think this will address your issue.

@gabemontero yeah not aware of any way to move an issue between repos, but you can still reference this issue from your pull in that repo and vice versa.

fixed by https://github.com/openshift/jenkins-plugin/pull/22


devicetree: child nodes remain enabled when parent node is disabled

Description
I am not sure whether this is a bug or expected behavior. We are using an nrf52840dk/nrf52840 board, and want to use "normal" SPI driver (CONFIG_SPI_NOR) instead of the QSPI driver (CONFIG_NRFX_QSPI, CONFIG_NORDIC_QSPI_NOR, etc.) for the external flash. For this purpose, we disable the parent qspi node, but the child node (qspi -> mx25r64) remains enabled.
Describe the bug
The nrf52840dk/nrf5280 board has the following node defined in zephyr/boards/nordic/nrf52840dk/nrf52840dk_nrf52840.dts:
&qspi {
	status = "okay";
	pinctrl-0 = <&qspi_default>;
	pinctrl-1 = <&qspi_sleep>;
	pinctrl-names = "default", "sleep";
	mx25r64: mx25r6435f@0 {
		compatible = "nordic,qspi-nor";
		reg = <0>;
		/* MX25R64 supports only pp and pp4io */
		writeoc = "pp4io";
		/* MX25R64 supports all readoc options */
		readoc = "read4io";
		sck-frequency = <8000000>;
		jedec-id = [c2 28 17];
		sfdp-bfp = [
			e5 20 f1 ff  ff ff ff 03  44 eb 08 6b  08 3b 04 bb
			ee ff ff ff  ff ff 00 ff  ff ff 00 ff  0c 20 0f 52
			10 d8 00 ff  23 72 f5 00  82 ed 04 cc  44 83 68 44
			30 b0 30 b0  f7 c4 d5 5c  00 be 29 ff  f0 d0 ff ff
		];
		size = <67108864>;
		has-dpd;
		t-enter-dpd = <10000>;
		t-exit-dpd = <35000>;
	};
};

... and we are using a dtsi file with the following entry to disable the qspi node:
&qspi {
    status = "disabled";
};

... which results in a build/zephyr/zephyr.dts.pre file with the following (relevant) entries:
&qspi {
 status = "okay";
 pinctrl-0 = <&qspi_default>;
 pinctrl-1 = <&qspi_sleep>;
 pinctrl-names = "default", "sleep";
 mx25r64: mx25r6435f@0 {
  compatible = "nordic,qspi-nor";
  reg = <0>;

  writeoc = "pp4io";

  readoc = "read4io";
  sck-frequency = <8000000>;
  jedec-id = [c2 28 17];
  sfdp-bfp = [
   e5 20 f1 ff ff ff ff 03 44 eb 08 6b 08 3b 04 bb
   ee ff ff ff ff ff 00 ff ff ff 00 ff 0c 20 0f 52
   10 d8 00 ff 23 72 f5 00 82 ed 04 cc 44 83 68 44
   30 b0 30 b0 f7 c4 d5 5c 00 be 29 ff f0 d0 ff ff
  ];
  size = <67108864>;
  has-dpd;
  t-enter-dpd = <10000>;
  t-exit-dpd = <35000>;
 };
};

...

&qspi {
 status = "disabled";
};

In my understanding, this should disable the qspi node as well as its children.
However, when inspecting the resulting Kconfig file in build/zephyr/.config, we can see that QSPI is still enabled (especially CONFIG_DT_HAS_NORDIC_QSPI_NOR_ENABLED=y from qspi -> mx25r64 -> compatible = "nordic,qspi-nor", which then enables CONFIG_NORDIC_QSPI_NOR=y):
CONFIG_DT_HAS_NORDIC_QSPI_NOR_ENABLED=y
CONFIG_NORDIC_QSPI_NOR=y
...

Expected behavior
I would expect the child nodes (qspi -> mx25r64 in this case) to also assume status = "disabled" when the parent/root node (qspi in this case) has status = "disabled".
Environment (please complete the following information):

OS: Linux
Toolchain: zephyr-sdk-0.16.8
Commit SHA or Version used: tag v4.0.0 (8469084dfae85f854555f0607f2c838dad097235)

Additional context
One can work around this issue by deleting the parent node entirely
/delete-node/ &qspi;

... or by explicitly disabling the child node:
&qspi {
    status = "disabled";
    mx25r64: mx25r6435f@0 {
        status = "disabled";
    };
};

Is deleting the node or explicitly disabling the child nodes the proposed way to do this?
Is it intended behaviour that child nodes remain active when the parent node is disabled?

It's expected behavior


Update nf-dbghelp-symgetmoduleinfow64.md

Fix typos regarding IMAGEHLP_MODULEW64 structure.

@k15tfu : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Range Sliders in the Inspector do not Assign Input Focus to their Associated Edit Control

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Compatibility) - NVIDIA GeForce GTX 1060 (NVIDIA; <IP_ADDRESS>11) - Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 Threads)
Issue description
(Similar issues with the sliders are mentioned here).
If you are in the Inspector and are tweaking values for something, as you navigate between controls and change values, if you decide to use a control's associated slider control to adjust a value, the intended value is changed correctly (the correct edit control is updated), but if you are having trouble getting the exact value you want and decide to just type it in, whatever you type will be treated as input to the previously-focused input-capable control.
Similar to the behavior of spin button controls in Windows, when you activate a control's "buddy control," (e.g. spin buttons, or the range slider in Godot) focus should shift to associated parent control.  This is what the user would normally expect as they are effectively clicking in the client area of a control of interest. This behavior can also be confirmed with with comboboxes - when you click the drop-down arrow, focus changes to the combobox.
Steps to reproduce

With any project open, add and/or select a Node2D node.
Navigate to the Inspector and drop open the Transform pane.
Click into the Position x control and enter a value.
Click on the slider for Rotation and use it to change the rotation.  Now type 45 as if you were trying to change the rotation to 45 degrees.

Instead of Rotation changing, the value for Position x will be changed instead.  This is not the expected behavior.  (Also, if the previous control was a button, <SPACE> or <ENTER> would activate the button as well.)
This problem can be replicated with other slider controls as well, for different kinds of Nodes/objects.
Minimal reproduction project
N/A

I could not reproduce the problem. Could you also make a video of exactly how you do it?
Godot v4.1.1.stable - macOS 13.5.1 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)
https://github.com/godotengine/godot/assets/41921395/26f334ba-8c8b-4e14-a2e7-6975f54f0028

I could not reproduce the problem. Could you also make a video of exactly how you do it?

I think OP meant that using the SpinBox's slider does not automatically focus the SpinBox itself (which can be seen in the video). The user still has to click it to type the value manually, even after using the slider.

I could not reproduce the problem. Could you also make a video of exactly how you do it?

I think OP meant that using the SpinBox's slider does not automatically focus the SpinBox itself (which can be seen in the video). The user still has to click it to type the value manually, even after using the slider.

Correct.  If you look at the latter part of the video, I focus a control above the spin/slider control and then I click on and drag the slider, but focus remains on the earlier control - it does not move to the control "attached" to the slider.
The slider and its "buddy" control (to use Windows parlance) should be treated as a single control: focusing one allows both to accept input, so you should be able to type a value in after dropping the slider if you cannot get the exact value your want.  Likewise, if you have clicked in the associated edit control, you should be able to move the slider in steps (preconfigured increments)using the arrow keys.


Coverlet doesn't work when the test assembly is invoked directly

The Coverlet.collector data collector is resolved based on the VSTestTestAdapterPath property: https://github.com/microsoft/vstest/blob/d8bc445c7e127598a3b004253c68d266df01544f/src/vstest.console/Processors/CollectArgumentProcessor.cs#L128-L144.
That property is set before VSTest executes: https://github.com/coverlet-coverage/coverlet/blob/3c55332ccee37d3c9cfbbf28a33e219fe7eaa40d/src/coverlet.collector/build/netstandard1.0/coverlet.collector.targets#L21.
The problem with relying on an msbuild property being set is that the data in-proc collector can't be resolved when an assembly is invoked via dotnet test or dotnet vstest:
PS C:\git\runtime3\artifacts\bin\System.Text.RegularExpressions.Tests\net5.0-Debug> dotnet test System.Text.RegularExpressions.Tests.dll

Microsoft (R) Test Execution Command Line Tool Version 16.7.0-dev
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...

A total of 1 test files matched the specified pattern.
Data collection : Unable to find a datacollector with friendly name 'XPlat code coverage'.
Data collection : Could not find data collector 'XPlat code coverage'

This works well in a dotnet publish scenario as the required assemblies are copied into the publish directory: https://github.com/coverlet-coverage/coverlet/blob/3c55332ccee37d3c9cfbbf28a33e219fe7eaa40d/src/coverlet.collector/build/netstandard1.0/coverlet.collector.targets#L12-L18
There are two ways to solve that:

Copy the coverlet.collector binaries not just during publish but also during the build into the app's output directory. The obvious major downside of that approach is that it bloats the output directory, especially as coverlet.collector relies on many other helper assemblies which would need to be copied over as well.
Read the test app's deps.json file to determine the path to coverlet.colletor's data collector if the coverlet.collector.dll isn't present in the output directory. Other components in VSTest are already doing that (I believe the testhost?).

cc @MarcoRossignoli @nohwnd

Read the test app's deps.json

You mean something like https://github.com/coverlet-coverage/coverlet/blob/master/src/coverlet.core/Instrumentation/CecilAssemblyResolver.cs#L173

Exactly

Need to check better(busy at the moment) but I think it works if build with <PreserveCompilationContext>

I assumed this works without PreserveCompilationContext being set. If it requires that switch, that would be a stopper.

Maybe it works I had issue with shared framework references, I don't know if there are issue with nuget ref https://github.com/dotnet/sdk/blob/master/toolset/Documentation/specs/runtime-configuration-file.md#opt-in-compilation-data

@MarcoRossignoli  is this something that needs to be solved, or it can be closed?

I don't think it's solved but it's really old I wonder if it's still an issue. The chance looks not super quick(read the deps to find out coverlet extension).

Yes, this is still an issue.


python3Packages.apsw: <IP_ADDRESS> -> <IP_ADDRESS>

Description of changes
https://rogerbinns.github.io/apsw/changes.html
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 198654 run on x86_64-linux 1

3 packages marked as broken and skipped:

pgadmin
python310Packages.pytest-ansible
python39Packages.pytest-ansible

1 package failed to build and already failed to build on hydra master:

etesync-dav: log was empty

86 packages built:

ansible
ansible-later (python310Packages.ansible-later)
ansible-lint (python310Packages.ansible-lint)
ansible_2_13 (python310Packages.ansible-core)
calibre
cozy
dyndnsc
etebase-server (python310Packages.etebase-server)
gkraken
gwe
home-assistant-component-tests.bmw_connected_drive
kargo
matrix-commander
mirage-im
opsdroid
pantalaimon
pantalaimon-headless
parsedmarc (python310Packages.parsedmarc)
pgadmin4
python310Packages.aiofile
python310Packages.aiomisc
python310Packages.ansible
python310Packages.ansible-compat
python310Packages.ansible-kernel
python310Packages.ansible-runner
python310Packages.apsw
python310Packages.bimmer-connected
python310Packages.caio
python310Packages.dependency-injector
python310Packages.etesync
python310Packages.fastapi
python310Packages.fastapi-mail
python310Packages.flask-admin
python310Packages.flask-security-too
python310Packages.geoip2
python310Packages.json-logging
python310Packages.matrix-nio
python310Packages.mocket
python310Packages.nplusone
python310Packages.ormar
python310Packages.peewee
python310Packages.slowapi
python310Packages.sopel
python310Packages.strawberry-graphql
ttp (python310Packages.ttp)
python310Packages.wtf-peewee
python39Packages.aiofile
python39Packages.aiomisc
python39Packages.ansible
python39Packages.ansible-compat
python39Packages.ansible-core
python39Packages.ansible-kernel
python39Packages.ansible-later
python39Packages.ansible-lint
python39Packages.ansible-runner
python39Packages.apsw
python39Packages.bimmer-connected
python39Packages.caio
python39Packages.dependency-injector
python39Packages.etebase-server
python39Packages.etesync
python39Packages.fastapi
python39Packages.fastapi-mail
python39Packages.flask-admin
python39Packages.flask-security-too
python39Packages.geoip2
python39Packages.json-logging
python39Packages.matrix-nio
python39Packages.mocket
python39Packages.nplusone
python39Packages.ormar
python39Packages.parsedmarc
python39Packages.peewee
python39Packages.slowapi
python39Packages.sopel
python39Packages.strawberry-graphql
python39Packages.ttp
python39Packages.wtf-peewee
s3ql
semgrep
soco-cli
sqlite-web
sublime-music
theharvester
vorta
weechatScripts.weechat-matrix

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

ansible_2_13:

got build log for '/nix/store/sa2kmpisbpzyxyxzjsk19q9k2fqml05d-python3.10-ansible-core-2.13.5' from 'daemon'
When evaluating attribute ‘ansible_2_13’:
warning: unused-argument
Unused argument: callPackage.
Near pkgs/development/python-modules/ansible/core.nix:2:3:
  |
2 | , callPackage
  |   ^

ansible-later:

got build log for '/nix/store/h0xl8l8387dp9lizskmf9da0yc83s9v9-python3.10-ansible-later-2.0.22' from 'daemon'
When evaluating attribute ‘ansible-later’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'unidiff = "0.7.3"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/ansible-later/default.nix:85:
   |
85 |     description = "Best practice scanner for Ansible roles and playbooks";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'toolz = "0.11.2' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/ansible-later/default.nix:85:
   |
85 |     description = "Best practice scanner for Ansible roles and playbooks";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

ansible:

Package is missing a meta section.
If the package is using runCommand please make sure to inherit or create a meta section.
Using CC=cc, CXX=c++, AR=ar or LD=cc prevents cross compiling.
Please use CC=${stdenv.cc.targetPrefix}cc, CXX=${stdenv.cc.targetPrefix}c++, AR=${stdenv.cc.targetPrefix}ar or LD=${stdenv.cc.targetPrefix}cc.
got build log for '/nix/store/b8y79arwyqgs4j8b7b0q3kbald3id977-python3.10-ansible-core-2.12.6' from 'daemon'
When evaluating attribute ‘ansible’:
warning: unused-argument
Unused argument: lib.
Near pkgs/top-level/all-packages.nix:36653:18:
      |
36653 |   pkgsModule = { lib, options, ... }: {
      |                  ^

gwe:

got build log for '/nix/store/w2pia1d6y0p4zb52fz3mb17ssb5yp3an-gwe-0.15.5' from 'daemon'
When evaluating attribute ‘gwe’:
warning: meson-cmake
Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.
Near pkgs/tools/misc/gwe/default.nix:53:3:
   |
53 |   nativeBuildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/meson-cmake.md
warning: unused-argument
Unused argument: makeWrapper.
Near pkgs/tools/misc/gwe/default.nix:5:3:
  |
5 | , makeWrapper
  |   ^

home-assistant-component-tests.bmw_connected_drive:

got build log for '/nix/store/bxzzc0nl0jq2b8k5as0sgl450vabgvb6-homeassistant-test-bmw_connected_drive-2022.10.5' from 'daemon'
When evaluating attribute ‘home-assistant-component-tests.bmw_connected_drive’:
warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/servers/home-assistant/default.nix:5:3:
  |
5 | , fetchpatch
  |   ^

opsdroid:

got build log for '/nix/store/19hl8k5b9xh451mhidd0k0zbm20blalr-python3.10-opsdroid-0.25.0' from 'daemon'
When evaluating attribute ‘opsdroid’:
warning: python-include-tests
Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.
Near pkgs/applications/networking/opsdroid/default.nix:30:
   |
30 |     description = "An open source chat-ops bot framework";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

parsedmarc:

got build log for '/nix/store/zlfdpg3i72zma887sk977lh2amrvzgpi-python3.10-parsedmarc-8.2.0' from 'daemon'
When evaluating attribute ‘parsedmarc’:
warning: unused-argument
Unused argument: python.
Near pkgs/development/python-modules/parsedmarc/default.nix:6:3:
  |
6 | , python
  |   ^

python310Packages.dependency-injector:

got build log for '/nix/store/9kzlnd0pii4x7qncrq5dlxrbbz8qvd5w-python3.10-dependency-injector-4.35.3' from 'daemon'
When evaluating attribute ‘python310Packages.dependency-injector’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'six>=1.7.0,<=1.15.0' doesn't match anything in file 'requirements.txt'
Near pkgs/development/python-modules/dependency-injector/default.nix:58:
   |
58 |     description = "Dependency injection microframework for Python";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python310Packages.fastapi-mail:

got build log for '/nix/store/a1vq5ffbjzli43cfdh95pp0292rb4wkh-python3.10-fastapi-mail-1.2.0' from 'daemon'
When evaluating attribute ‘python310Packages.fastapi-mail’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'fastapi = "^0.75.0"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/fastapi-mail/default.nix:73:
   |
73 |     description = "Module for sending emails and attachments";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'httpx = "^0.22.0"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/fastapi-mail/default.nix:73:
   |
73 |     description = "Module for sending emails and attachments";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python310Packages.flask-admin:

got build log for '/nix/store/yc39nhxsn20vhvmg368qksypbm7pzbnl-python3.10-flask-admin-1.6.0' from 'daemon'
When evaluating attribute ‘python310Packages.flask-admin’:
warning: unused-argument
Unused argument: enum34.
Near pkgs/development/python-modules/flask-admin/default.nix:8:3:
  |
8 | , enum34
  |   ^

python310Packages.matrix-nio:

got build log for '/nix/store/vyh5wpi4hi7vl93xjjn3zby0qffh2y6g-python3.10-matrix-nio-0.20.0' from 'daemon'
When evaluating attribute ‘python310Packages.matrix-nio’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'jsonschema = "^3.2.0"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/matrix-nio/default.nix:95:
   |
95 |     description = "A Python Matrix client library, designed according to sans I/O principles";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python310Packages.slowapi:

got build log for '/nix/store/z98pb9dq2jw7as8bcb3sh2zk0igl0730-python3.10-slowapi-0.1.6' from 'daemon'
When evaluating attribute ‘python310Packages.slowapi’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'redis = "^3.4.1"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/slowapi/default.nix:66:
   |
66 |     description = "Python library for API rate limiting";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python39Packages.ansible-core:

got build log for '/nix/store/hk7cvq704jikyv64j7xmkqmg3m61xrp2-python3.9-ansible-core-2.13.5' from 'daemon'
When evaluating attribute ‘python39Packages.ansible-core’:
warning: unused-argument
Unused argument: callPackage.
Near pkgs/development/python-modules/ansible/core.nix:2:3:
  |
2 | , callPackage
  |   ^

python39Packages.ansible-later:

got build log for '/nix/store/cr0g3zz72hpcp4hmk3z8b22yzkcvn299-python3.9-ansible-later-2.0.22' from 'daemon'
When evaluating attribute ‘python39Packages.ansible-later’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'unidiff = "0.7.3"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/ansible-later/default.nix:85:
   |
85 |     description = "Best practice scanner for Ansible roles and playbooks";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'toolz = "0.11.2' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/ansible-later/default.nix:85:
   |
85 |     description = "Best practice scanner for Ansible roles and playbooks";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python39Packages.dependency-injector:

got build log for '/nix/store/38c5nmd300hi0w4gh1zn5iry60pv36fh-python3.9-dependency-injector-4.35.3' from 'daemon'
When evaluating attribute ‘python39Packages.dependency-injector’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'six>=1.7.0,<=1.15.0' doesn't match anything in file 'requirements.txt'
Near pkgs/development/python-modules/dependency-injector/default.nix:58:
   |
58 |     description = "Dependency injection microframework for Python";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python39Packages.fastapi-mail:

got build log for '/nix/store/jr25si0g3f6b5rpmk0vhci2l5y96gwq8-python3.9-fastapi-mail-1.2.0' from 'daemon'
When evaluating attribute ‘python39Packages.fastapi-mail’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'fastapi = "^0.75.0"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/fastapi-mail/default.nix:73:
   |
73 |     description = "Module for sending emails and attachments";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'httpx = "^0.22.0"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/fastapi-mail/default.nix:73:
   |
73 |     description = "Module for sending emails and attachments";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python39Packages.flask-admin:

got build log for '/nix/store/zd9177s60bhxvrfxx9fpcwnc9h3zpcdm-python3.9-flask-admin-1.6.0' from 'daemon'
When evaluating attribute ‘python39Packages.flask-admin’:
warning: unused-argument
Unused argument: enum34.
Near pkgs/development/python-modules/flask-admin/default.nix:8:3:
  |
8 | , enum34
  |   ^

python39Packages.matrix-nio:

got build log for '/nix/store/88qkvgz88rmhc6v6ycs2sjrbadmj5v3w-python3.9-matrix-nio-0.20.0' from 'daemon'
When evaluating attribute ‘python39Packages.matrix-nio’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'jsonschema = "^3.2.0"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/matrix-nio/default.nix:95:
   |
95 |     description = "A Python Matrix client library, designed according to sans I/O principles";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

python39Packages.parsedmarc:

got build log for '/nix/store/sjsw67scmjwv5s34r5ajmf4511qdprwn-python3.9-parsedmarc-8.2.0' from 'daemon'
When evaluating attribute ‘python39Packages.parsedmarc’:
warning: unused-argument
Unused argument: python.
Near pkgs/development/python-modules/parsedmarc/default.nix:6:3:
  |
6 | , python
  |   ^

python39Packages.slowapi:

got build log for '/nix/store/w9h7zna1i43j4svk3lknfp68sxm8qvy9-python3.9-slowapi-0.1.6' from 'daemon'
When evaluating attribute ‘python39Packages.slowapi’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'redis = "^3.4.1"' doesn't match anything in file 'pyproject.toml'
Near pkgs/development/python-modules/slowapi/default.nix:66:
   |
66 |     description = "Python library for API rate limiting";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

semgrep:

got build log for '/nix/store/z4vn7dlrj5ph0nz8s58z7bcc5dhcnndy-semgrep-0.112.1' from 'daemon'
When evaluating attribute ‘semgrep’:
warning: unused-argument
Unused argument: lib.
Near pkgs/tools/security/semgrep/default.nix:1:3:
  |
1 | { lib
  |   ^

warning: unused-argument
Unused argument: fetchFromGitHub.
Near pkgs/tools/security/semgrep/default.nix:2:3:
  |
2 | , fetchFromGitHub
  |   ^

vorta:

got build log for '/nix/store/zfcz8677kgq6c5nyxmnw5l066rnmknpk-vorta-0.8.7' from 'daemon'
When evaluating attribute ‘vorta’:
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'setuptools_git' doesn't match anything in file 'setup.cfg'
Near pkgs/applications/backup/vorta/default.nix:90:
   |
90 |     description = "Desktop Backup Client for Borg";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern 'pytest-runner' doesn't match anything in file 'setup.cfg'
Near pkgs/applications/backup/vorta/default.nix:90:
   |
90 |     description = "Desktop Backup Client for Borg";
   | ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/stale-substitute.md

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1425

@ofborg build python3Packages.apsw


Team management improvements.

Base team logic should be implemented:

[x] Team member basic invitation system.
[x] More clever member search system.
[x] Deassigning a member logic.
[ ] Creator should at least be able to give full/partial project access to a member.

Started working on team member ability management system on branch members-base-roles-feature. Got some basic and raw working prototype. Now thinking on a correct frontend/backend implementation.


Provide access to the Settings instance to projects

Expected Behavior
Project plugins need to be able to reason about some settings. In this example, it needs to be able to be configured differently if the settings are using central repositories or not: https://github.com/micronaut-projects/micronaut-build/pull/210
Current Behavior
I tried to avoid the use of an internal API but failed. In particular, this doesn't work in a project plugin:
project.gradle.settingsEvaluated { Settings settings ->
   // this is never called
}

If not giving access to full settings, it should minimally provide a read-only view of what can be configured in settings.
Context
The micronaut-build plugin used to add repositories automatically to all subprojects. However, to be able to use imported version catalogs, a project needs to be able to use repositories declared in settings. If we do so we have a conflict between repositories declared in settings and repositories declared in projects. As a migration step, we need a way to avoid adding a repository IF settings repositories are declared.

Need to investigate general query access to Settings but there needs to be changes for sure around central repository declarations.

Another use case: https://gradle-community.slack.com/archives/CAHSN3LDN/p1635187532086900


Priam is writing lots of debug logs to catalina.out

We are trying to set up Priam using the 3.11 branch in Tomcat. It's all working fine, but we are having issues with logs. We're struggling to get Priam to pick up the log4j properties, and it's just logging huge amounts of debug info to catalina.out.
Our log4j config is the following (priam_log_file is injected via ansible). We are putting it in priam/src/main/resources/log4j.properties, then building with the provided gradle script. We also tried to put it into priam-web/src/main/resources/log4j.properties and had the same issue. I'm sure we're missing something obvious, but we're struggling to see it.
log4j.rootLogger=ERROR, FILE, stdout
log4j.appender.FILE=org.apache.log4j.RollingFileAppender
log4j.appender.FILE.File={{priam_log_file}}
log4j.appender.FILE.MaxFileSize=5MB
log4j.appender.FILE.MaxBackupIndex=5
log4j.appender.FILE.layout=org.apache.log4j.PatternLayout
log4j.appender.FILE.layout.ConversionPattern=%d{yyyy-MM-dd HH:mm:ss.SSSS} %p %t %c %m%n
log4j.appender.stdout=org.apache.log4j.ConsoleAppender
log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
log4j.appender.stdout.layout.ConversionPattern=%5p %d{HH:mm:ss,SSS} %m%n

@NickBlow dunno if you figured out what was causing this, but I think it was multiple slf4j bindings on the classpath. I believe https://github.com/Netflix/Priam/pull/631 and https://github.com/Netflix/Priam/pull/632 fix this.

@zmarois we ended up using filebeat to work around it rather than actually trying to dig deep into what was causing it. that sounds plausible. will close now and reopen should it not be fixed by those.


Add script to run tests locally

I've integrated/merged the changes into my PR for gradle/Tilt support in tanzu-java-web-app.

Included as part of f79fc00f08e505f6966032b4f4aba54fafbd054c


[release-0.7] Allow skipping restore-specific checks during backup

What this PR does / why we need it:
Manual backport of https://github.com/kubevirt/kubevirt-velero-plugin/pull/285. Had to address some conflicts with the VM object graph, no major issues during backport.
This is part of the features we want to get into oadp 1.4.2 as discussed offline (related to https://github.com/kubevirt/kubevirt-velero-plugin/issues/199#issuecomment-2518208250).
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Allow skipping restore-specific checks during backup

/lgtm
/approve


manifest: update hal_nxp

repro: west build -p -b mimx8mp_evk_a53 -T tests/kernel/common/kernel.common
https://github.com/zephyrproject-rtos/hal_nxp/pull/280

Update hal_nxp to include a build warning fix for redefinition of MPIDR_AFFLVL_MASK.

@fabiobaltieri , thank you. HAL PR has been merged.
Would you need a similar wrapper on the Zephyr side header files as well?

Updated with the final sha.

@fabiobaltieri , thank you. HAL PR has been merged. Would you need a similar wrapper on the Zephyr side header files as well?

No I think we decided to keep the guards in the modules and plain defines in the upstream code.

@mmahadevan108 well, your point about include order was pretty good :-) had to add an explicit include in the CCM file to make that work, would not be surprised if we hit some other one right now. Maybe let's keep this to have the CI running again and then you NXP folks may revisit the situation if this becomes more of a problem?

Tested this locally with ./scripts/twister -p mimx8mn_evk_a53, seems to work but that surprised me a bit considering how many references of fsl_clock.h are in the code.

ok I think that that one is due to https://github.com/zephyrproject-rtos/hal_nxp/pull/276, which was merged in the HAL but not included in the last west.yaml update, my fix for the macro collision is on top of that though so the HAL update is fixing the collision but including those changes which are breaking s32z

ok this may need https://github.com/zephyrproject-rtos/zephyr/pull/62685, let me try to cherry pick it

@manuargue FYI I cherry picked https://github.com/zephyrproject-rtos/zephyr/pull/62685 (withouht the manifest hash) on top of this.

@manuargue FYI I cherry picked https://github.com/zephyrproject-rtos/zephyr/pull/62685 (without the manifest hash) on top of this.

@fabiobaltieri I'm okay with it from changes pov. Also @mmahadevan108 is suggesting to revert the pr in the HAL for the s32z to get your fixes in first.

@fabiobaltieri I'm okay with it from changes pov. Also @mmahadevan108 is suggesting to revert the pr in the HAL for the s32z to get your fixes in first.

Thanks, unless the new files add some test that reveals new breakages this should pass, at least I've rerun all targets that broke on the last run so I say there's hope. :-)
If you folks want to prepare a rollback PR, we can run those in parallel and decide after the end of this run.

alright, all pass, let's give this a shot and see how it does on the push run

@mmahadevan108 @dleach02 there's load more drivers using fsl_clock.h, I did some test build and seems like none of those are used in the nxp cortex-a53 right now, but they would all trigger again the macro collision if they end up being used with that platform. You may want to review that separately see if you can come up with a solution that avoids the potential collision entirely.

Many apologies folks. @fabiobaltieri, next time I see you dinner is on me.

cc @JiafeiPan. Need your help to investigate this.

Many apologies folks. @fabiobaltieri, next time I see you dinner is on me.

Hey no prob, thanks for the quick reviews :-)


webpack --watch does not run loaders when a semicolon is added/removed

Subject:
let foo

console.log('abc', foo);

I am using:

webpack
eslint-loader

I am running webpack using webpack --watch --progress.
The following output is generated:
ERROR in ./foo.js

/foo.js
  1:7  error  Missing semicolon  semi

✖ 1 problem (1 error, 0 warnings)

So far so good.
I edit the subject file:
let foo;

console.log('abc', foo);

webpack CLI --progress indicates that package is re-built. However, error output remains.
I edit the subject file (edit the string):
let foo;

console.log('def', foo);

webpack CLI --progress indicates that package is re-built. The error disappears.
Therefore, it appears that adding/removing a semicolon does not trigger loaders.

Same here, with nearly the same setup, only with babel-loader. There is no reaction on any change webpack deems insignificant. removal of ; (even if that would've failed eslint, removal or addition of spaces.

For reference, here is the config file:
module.exports = {
    entry: {
        app: PATH.resolve(root, 'src/bundle.js'),
    },
    output: {
        path: PATH.resolve(root, 'public/js'),
        filename: 'bundle.js'
    },
    module: {
        loaders: [
            {
                test: /\.js$/,
                exclude: /(node_modules|bower_components)/,
                loader: 'babel'
            },
            {
                test: /\.js$/,
                exclude: /(node_modules|bower_components)/,
                loader: 'eslint-loader'
            }
        ]
    }
};

I believe I am experiencing this issue as well (the issue that webpack doesn't respect file timestamps, or even simple content-hashing, when detecting changes).  At first I thought I was just changing the file too quickly after the previous change was detected (and that may actually be an issue too, it's hard to tell), but the commentors above pointed me in the right direction: I'm usually modifying superfluous whitespace, as our linter (eslint) is setup to error on these issues and that will cause webpack to fail.
What's the change detection algorithm/heuristic, and why doesn't it seem to be anything sane?

I have not figured out whats the problem with webpack.NewWatchingPlugin (the default watching plugin), but you can force webpack to use the old file watching logic if you add new webpack.OldWatchingPlugin() plugin. The OldWatchingPlugin does not suffer from the same issue.

https://github.com/webpack/watchpack/issues/16

Would it be possible to re-open this issue?
I'm still facing this issue on webpack 2.3.3 / Ubuntu, and the corresponding issue (#16 on watchpack)[https://github.com/webpack/watchpack/issues/16] has been closed as well, pointing out that it is a webpack issue.
In can confirm that it is not an inotify issue (/proc/sys/fs/inotify/max_user_watches set to 524288), because I can see a very short progress indication. However, webpack seems to decide not to recompile the file for some reason.

Apparently eslint will not run against your files if change has no effect on output AST. Perhaps a way to extempt loader from this check could be added, like always: true?
I've also ran into this issue few days back as I was experimenting with the Webpack 2 for first time, and then I've resorted to running separate watching process. Still, its just a workaround untill this gets resolved in better way.

+1

bump.

@nmschulte note that this issue was fixed in Webpack 3.5.4:

Warnings and errors contribute to hash, which shows stats on warning-only change

still seeing this issue on ^3.10.0


hcsshim::ImportLayer Error

Describe the bug
Docker build does not work
To Reproduce
Dockerfile:
# escape=`

FROM mcr.microsoft.com/windows/servercore:ltsc2019

RUN mkdir C:\temp

Steps to reproduce the behavior:
docker build -t debugimage .
Sending build context to Docker daemon  2.048kB
Step 1/2 : FROM mcr.microsoft.com/windows/servercore:ltsc2019
 ---> 86eddd4761f5
Step 2/2 : RUN mkdir C:\temp
 ---> Running in 237a8d94102a
re-exec error: exit status 1: output: hcsshim::ImportLayer - failed failed in Win32: The system cannot find the path specified. (0x3)

Expected behavior
An image to be created with a C:\temp directory
Configuration:

Edition: Windows 10.0.19043
Base Image being used:  Windows Server Core ltsc2019
Container engine: docker
Container Engine version 4.9.0

Virtualization is enabled; this is on a brand new laptop with docker installed
Additional context
Not sure if any more detailed logging would be produced that might be of assistance in debugging this; if there's a way to get more information out of docker please let me know!

I tried to reproduce this issue last week with no success. Just to confirm, are you able to start a normal docker container (and it's only building an image locally that fails)?

Well, figured it out - I was getting burned by this:
https://social.technet.microsoft.com/Forums/en-US/01db4c1d-547c-460e-bbbb-32626436b881/sysmon-preventing-docker-build?forum=windowstroubleshooting
I guess my organization pushes sysmon to our machines automatically.
Not sure why this is an issue, but it might be something worth making a ticket for


README and Website should have list of adaptors in the first page

I cannot seem to find a list of adaptors on the xenon website or readme. We should consider adding one.

Agree, the only user facing documentation I could find was at http://nlesc.github.io/Xenon/versions/1.1.0/javadoc/

Fixed in 1.2.0 release.


setup.py still ok?

Before this commit: https://github.com/p4lang/ptf/commit/ff79b8c041c70136cb64bc2864d7cc00e20439fd
I had a bash script that was installing ptf this way on an Ubuntu 20.04 system:
git clone https://github.com/p4lang/ptf
cd ptf
sudo python3 setup.py install

After that commit, there is an exception thrown when I attempt that setup.py install command.
Should that command still work?
Is it anti-recommended to install ptf that way from source code?
Perhaps I should be using sudo pip install . instead?

@jafingerhut there is a PR open to address this: https://github.com/p4lang/ptf/pull/193
The issue is caused by this line: https://github.com/p4lang/ptf/blob/bb28a88187ca9195884dae319e8a660838de948b/setup.cfg#L25
While the syntax is correct, support for the file: attribute in install_requires was added recently to setuptools. It requires a toolchain more recent than what you'd get by default in Ubuntu 20.04 or even Ubuntu 22.04.
I am waiting for the contributor to address my comment about updating the README before merging the PR.
I would still recommend using pip install . to install ptf, but it will not help in this case, unless you install a recent-enough version of pip (more recent than what you would get by installing python3-pip):
https://github.com/p4lang/ptf/blob/bb28a88187ca9195884dae319e8a660838de948b/.github/workflows/build.yml#L36-L39

Lots of more details here: https://docs.google.com/spreadsheets/d/12qip0oKFVK1vPXdC7-VtnRYit-BxKdfsZJPJrDB_usI/edit#gid=0
As of the 2023-Jun-19 version of this ptf repo, sudo pip install . installs successfully on several versions of Ubuntu and Fedora, but strangely it fails on Ubuntu 22.04 (but succeeds on Ubuntu 20.04 and 23.04).  Ubuntu 22.04 seems to be the odd one out for some reason.

@jafingerhut your doc is not public
We are still waiting on https://github.com/p4lang/ptf/pull/197 in order to fix this issue

Sorry about that.   Should be public to anyone with the link now, and I've updated the link in the comment above in case it changed as a result.


Add global enable switches for nixos and home-manager

In #138 and #167, requests for some global enable option were made.
I've also found some use-cases where I'd like to disable all side-effects of the impermanence modules for specific configurations while globally importing the modules. Though setting environment.persistence to {} generally works, it has two drawbacks:

You can't declare environment.persistence and then easily globally disable them somewhere else, without forcing it to {} (see #138).
Some side-effects always remain on the system (such as empty activation scripts).

This PR adds two additional options to impermanence:

boot.impermanence.enable: This switch is enabled by default and, if disabled, deactivates the entire module.
home.impermanence.enable: This switch does the same for home-manager.nix

I'd rather have this module be disabled by default (as most nixos modules are) but this would break every current install when updating which would be very bad. Instead, these new options are enabled by default, which means current installs would not be affected at all by these changes.
I put the nixos switch into boot because I felt that this module mostly affects the boot process (though some systemd services are started as well). I'm open to any suggestions for better placement.

I'd rather have this module be disabled by default (as most nixos modules are) but this would break every current install when updating which would be very bad. Instead, these new options are enabled by default, which means current installs would not be affected at all by these changes. -- @0xf09f95b4 (https://github.com/nix-community/impermanence/pull/171#issue-2150772607)

I would argue for these to be set to false by default as in the worst case the user will have to reboot and change configuration and in the present usecase it seems that it would make a permanent breaking changes to all my systems that don't have impermenance integrated in a reliable way yet https://github.com/Kreyren/nixos-config/tree/aaf809b0212d63ad694054139a74dc97c32ff497

https://github.com/Kreyren/nixos-config/blob/aaf809b0212d63ad694054139a74dc97c32ff497/machines/pelagus/default.nix#L22
https://github.com/Kreyren/nixos-config/blob/aaf809b0212d63ad694054139a74dc97c32ff497/nixos/modules/services/vikunja/vikunja.nix#L18

ping @0xf09f95b4 @talyz could this be merged or brainstormed? This feature is a major roadblock for my nixos configuration atm

For the NixOS module, there's already an enable option that can be set for each declared persistent storage path, i.e. environment.persistence."/persistent".enable. It seems to be undocumented, though. It should be added to the home-manager module as well.

It might seem a bit nitpicky, but disabling all storage paths is not completely side-effect free, even environment.persistence = {} still leads to a few empty activation script files added to the system.
I'd still really love a global enable/disable switch for impermanence.
Adding individual enable options to the home-manager module would be a good idea regardless.

It shouldn't be a problem to make it side-effect free, and if we do, I don't see the need for global switches.

environment.persistence."/persistent".enable

It shouldn't be a problem to make it side-effect free, and if we do, I don't see the need for global switches.

On a more complicated setup that is using various directories it's really pain to manage and i want to implement a logic that would on demand enable/disable impermanence per system.

It shouldn't be a problem to make it side-effect free, and if we do, I don't see the need for global switches.

Well, it's not uncommon one module to set options for another module in case the other module is enabled. In order to do this, you really need an enable switch to check in a mkIf, or you need it to be that the options you set will have no effect if the user has chosen to disable the other module.
Neither method is possible with impermanence right now, short of environment.persistence = lib.mkForce {};

But we already have enable switches, they're just on a submodule level instead of a module one. Why would this not be enough?
Usage example:
{
  config = lib.mkIf config.environment.persistence.main.enable {
    ...
  }
}

or with more than one persistent storage path
{
  config = lib.mkIf (config.environment.persistence.main.enable && config.environment.persistence.backup.enable) {
    ...
  }
}

It might seem a bit nitpicky, but disabling all storage paths is not completely side-effect free, even environment.persistence = {} still leads to a few empty activation script files added to the system.

Should be solved by #189. Please check it out.

For the NixOS module, there's already an enable option that can be set for each declared persistent storage path, i.e. environment.persistence."/persistent".enable. It seems to be undocumented, though. It should be added to the home-manager module as well.

To follow up on this, is there a specific reason this isn't implemented in home-manager or has it just not been developed yet?

To follow up on this, is there a specific reason this isn't implemented in home-manager or has it just not been developed yet?

No reason, it just hasn't been developed yet.

But we already have enable switches, they're just on a submodule level instead of a module one. Why would this not be enough?

I'm not following. The point I made was that a module would like to set environment.persistence."/foo" so that it only takes effect if the config is using impermanence at all. Right now it's not possible to mkIf that kind of condition. So a module either configures /foo to be an impermanence directory or it doesn't, and it cannot decide whether or not to do that based on whether impermanence is in use.

There's no need for mkIf in that case: the module can just go ahead and always set the options in environment.persistence."/foo"; whether that configuration will be active can be decided by other modules through environment.persistence."/foo".enable.

I think that's missing the point. If an external module X creates several environment.persistent entries, then I the user of X have to be aware of exactly which entries X made and include the appropriate enable = false lines for each of them in any config that I don't want persistence for. That is extremely error prone and un-ergonomic. As is, the best way to accomplish this is for X to have its own usePersistence module option, which is just a global enable switch made by someone else instead.

I forked the repo and implemented this commit, referencing the real life usecase: https://github.com/search?q=repo%3ANiXium-org%2FNiXium+boot.impermanence.enable&type=code

@ElvishJerricco In what scenario would an external module create persistentStoragePaths? If it would, you would have bigger issues anyway, such as providing backing storage for them. Disregarding that, it would also be pretty strange for an external module to create many different persistentStoragePaths as most people only need one or maybe two of them and the reason you would need more would certainly be outside the scope of the module anyway.
@Kreyren For your use, you could just use environment.persistence."/nix/persist/system".enable instead - just set it to false for your non-impermanence systems.

@Kreyren For your use, you could just use environment.persistence."/nix/persist/system".enable instead - just set it to false for your non-impermanence systems. -- @talyz (https://github.com/nix-community/impermanence/pull/171#issuecomment-2184038544)

The problem is that environment.persistent.<path> has a variable so automating that is a problem as in real-life usage you standardize /persistence for non-disko, but for disko setup it's more convinient to use /nix/persist to be able to just declare the whole /nix as BTRFS with @persist sub-volume.
Then for users i am providing /nix/persist/users through system and for invidual users using /nix/persist/users/<user> which gets enabled per user so the check for mkIf config.environment.persistent.<path>.enable becomes unusable with complexity as i would have to do add checks for each user to the condition.
Additionally I expect the setup on system-level to get significantly more complicated with integrating https://github.com/NiXium-org/NiXium/issues/16

@talyz I'm pretty tired of explaining the use case, and it's frustrating that your answer continues to be "I wouldn't be in that scenario".
It's standard practice for a module to have a global enable flag. The amount of discussion on this PR is ridiculous. I'm out.

@ElvishJerricco I was hoping that informing about the current enable options and how to use them would be enough to keep this discussion short, but obviously not. Instead, I'll do what I was hoping to avoid spending time on and explain my current stance on this and how to use the module in different scenarios at length.
My current stance

Having a global enable switch doesn't fit into the current design. This is made pretty obvious by this PR putting the option in boot.impermanence when the other config is in environment.persistence. As the top level is a submodule where you declare new and unrelated storage contexts, that's where it makes sense to enable/disable them as well.
It has been claimed multiple times here that it's standard practice for modules to have global enable switches and that false would be the correct default for them, but this mostly applies to services and not even all services have them. The modules aren't services and shouldn't be thought of as such either. Think of them more as part of the environment configuration, closer to environment.etc.
Tying into both of the above, it would be confusing to have a global switch (especially one that is false by default), since that's not what you would expect from similar modules. There's no environment.useEtc, systemd.tmpfiles.enable or fileSystems.enable.
There's nothing wrong with using lib.mkForce {} when you want to force disable all persistence settings! In fact, I think it conveys the intention better and feels less hacky than a detached boot.impermanence setting.

Usage in different, progressively more niche, scenarios

In the standard use case

You would need one or possibly two entries under environment.persistence - one for backed-up data and one for cache / data you're okay with losing.
Just set the enable switches directly.

For a multi-user system where every user should have their data stored separately, but configuration should be shared

Generate one environment.persistence.<user> entry per user.
Condition environment.persistence.<user>.enable = lib.mkDefault on the deciding factor for why a system should use persistence
or add your own option for it, if you're making your own internal module / the deciding factor is random.
This way, you can even decide to turn on or off persistence for individual users per system
or have instances of the system that only persist system files, but not user files.

You're making an external module that sets up partitions and storage + optionally wraps the persistence module

Expose your own option to enable / disable persistence! Yes, this is the right thing to do:

Well designed modules offer options to turn on/off usage of optional external services - the user shouldn't have to read the source and set these themselves.
What if the user just wants to disable the persistence offered by the module, but persist things outside of it?

You have declared 20 different entries under environment.persistence, but most systems will only use 3

Set environment.persistence.<whatever>.enable = lib.mkDefault false for each entry when declaring it.
Enable only the ones you need for each system.

This is exactly what I'm talking about. This is a real "you're holding it wrong" moment.

I've presented my take on this and shown how the current option can be used. I don't think there's much more I can do or add here, and my patience for your demands is running out.


wip: New endpoint auth type to create http message signatures for outbound requests according to RFC 9421

Related issue(s)
closes #1493
Checklist

[x] I agree to follow this project's Code of Conduct.
[x] I have read, and I am following this repository's Contributing Guidelines.
[x] I have read the Security Policy.
[x] I have referenced an issue describing the bug/feature request.
[ ] I have added tests that prove the correctness of my implementation.
[ ] I have updated the documentation.

Description
TODO

Work on this PR will continue as soon as #1534 is merged


Fix HTTPS downloads using curl

Resolves https://github.com/mavlink/MAVSDK-Java/issues/192.
In a previous PR, we have built curl with ssl support. But that is not enough for Android. First, curl does not auto-detect the system certificates on Android (at least not on all versions of Android). Second, OpenSSL3 cannot parse the Android system certificates (again at least on the versions of Android we tested) and it does not seem like this will change. BoringSSL, on the other hand, works with the Android system certificates.
I don't think that we should move MAVSDK entirely to BoringSSL for different reasons, one of them being that the default ssl library on many systems is OpenSSL. However, if OpenSSL3 does not really support Android, it seems like it makes sense to move to BoringSSL. Just for Android.
@julianoes: In order for boringssl to build, I had to update grpc, which in turn forced me to update protobuf, and hence to regenerate the code :see_no_evil:
@rayw-dronesense: would you mind testing this on your setup? :pray:

@JonasVautherin  It works!

Awesome! I just need to fix the iOS/macOS build with the updated gRPC now!

Hmm with the latest version of gRPC I had to update protobuf, which means that I need to re-generate the code... I don't know how I feel about that. Trying with an older version of gRPC, see if that works.
The PR for v3 does update protobuf, though: https://github.com/mavlink/MAVSDK/pull/2460

Closing this as I opted for simple hack for v2: https://github.com/mavlink/MAVSDK/pull/2471


ci: ACN PR Pipeline Security Feature Branch

Reason for Change:
Merges change for a PR branch for a OneBranch based pipeline build for Azure Container Networking PR pull request builds. This pipeline will live on the feature branch until the changes have been verified as in-parity, and secure.
Issue Fixed:
Fixes Component Governance alerts for migrating our github repos to use organization compliant builds.
 Currently there are multiple workstreams touching these files and we cannot block the higher priority work. Eventually the old files will be deleted after we have confirmed that we have parity across the two versions and we have switched over to using the new pipeline for PR validation.

Seeing as we are creating new files entirely now, maybe we should move them to .pipelines/devops/* That way we know there is a clear separation between OB and standard yaml pipelines.

@jpayne3506 The old files will eventually be deleted after the whole cycle has complete (merge this change -> validation/attain master parity -> merge changes -> add PR check to repo -> run checks side by side for a week -> deprecate old ACN PR Pipeline -> delete replaced files -> merge). It is much better if people have the visibility on these files.

/azp run Azure Container Networking PR

/azp run Azure Container Networking PR

/azp run Azure Container Networking PR


useNotification hook positioning

im having issue on using useNotification() hook  for position
const dispatch = useNotification();

  const handleNotifications = (type, message, title) => {
    dispatch({
      type: type,
![IMG_0966](https://user-images.githubusercontent.com/31248378/161874610-33b4e26b-a0a2-42c5-adb5-7d4e5c2fcb55.JPG)

      message: message,
      title: title,
      position: 'bottomL',
    });
  }

As you can see I've already added bottomL but it still showing on top left + pushes all my components downwards. Im using nextjs by the way

thanks @ass77
FYI @SmithVyne they posed this on Discord to help

thanks @ass77
FYI @SmithVyne they posed this on Discord to help

Hi @ass77 I will be taking on this issue. I will tag you here If I have any questions about your current code setup.

Hey guys I managed to solved it by simply upgrade its version from 0.1.112 to 0.1.113` . It seems to be working as expected now.

Great @ass77 , again, you can reach out next time you run into something similar.

@ass77 we will close this for now. TY keep in contact =]


adding MDS support for ISM Pages: Indices, Aliases, DataStreams, Templates & Component Templates

Description
This change adds multi data source selector (described in https://github.com/opensearch-project/OpenSearch-Dashboards/issues/6035). This change adds MDS support to Indices, Aliases, Data streams, Templates & Component template pages. There will be a follow-up PR raised for the remaining pages.
Issues Resolved
https://github.com/opensearch-project/index-management-dashboards-plugin/issues/982 This issue will be solved partially through this PR.
Check List

[✅] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Concerns left:

Is it doable that we compute dataSourceLabel by using dataSourceList and dataSourceId?

I will confirm on this by syncing up with opensearch-core team once by the end of this week, as new features are being rolled out in the data source picker this week.

Can we keep one convention to pass dataSourceId across ISM?

I will work on this and try to come up with a convention for passing data source id across ISM..

@SuZhou-Joe, if we use data source id to compute data source label, it will involve a database read call. Therefore, in my opinion, we should avoid computing this in the plugin if possible and abstract this functionality away to DataSourceMenu component in the core. I believe with the current implementation of DataSourceMenu in the core's main branch, we can avoid storing DataSourceLabel in our plugin's state. Pasting the GitHub issue where this is being discussed https://github.com/opensearch-project/OpenSearch-Dashboards/issues/6035#issuecomment-2011260026.

@RamakrishnaChilaka would you mind resolve the conflicts?
Conflicting files
yarn.lock


Update pt_BR translation

@ericof Hey, you merged this with a broken i18n check and now it's broken on the master branch.

@ericof Fixed on master: https://github.com/plone/volto/commit/215f1b4a93d5dc2f8ac4a7442aa7e9c82c3bb027


Exporter NOT ignoring damaged items

I am playing in ATM8 8-1.0.25. I am trying to clean out my storage by exporting enchanted items such as weapons, armor, etc into an Industrial Foregoing  Enchantment Extractor the enchanted books get piped into the Apotheosis Enchantment Library (via a hopper) then the unenchanted items go into a Silent Gear Salvager. Finally, the raw materials get imported back into storage. Everything works just fine with one exception. The Creative Exporter is NOT ignoring NBT/damaged info. so every item with different tags/damage has to manually be placed into the Exporter filter to work. The "Exact Mode" on the exporter looks as if its default is "Off" but it cannot be toggled to verify.

Caused by #34


Add dark mode bookmarklet to readme.md

Adds the bookmarklet for the dark mode version of Compact Cow's UI

Maybe, although we already have a darkmode ltbeef, it's in gui.js, if I recall correctly.

Maybe, although we already have a darkmode ltbeef, it's in gui.js, if I recall correctly.

Yes, this just adds it to the LTBEEF tab of the readme, so its easier to copy / paste


i18n(ko-KR): update nav.ts and ui.ts

Description (required)

update nav.ts
update ui.ts
I am participating in Hacktoberfest, please label it (hacktoberfest-accepted)

Related issues & labels (optional)
N/A

We have a few merge conflicts here, could you take a look? Thank you for taking your time to translate this 🙌


Formatting seems to mangle JSON/JS literals inside script tags

Package information:

leptosfmt 0.1.5
cargo 1.72.0-nightly (f7b95e316 2023-05-30)
rustc 1.72.0-nightly (871b59520 2023-05-31)

leptos = { version = "0.3", default-features = false, features = ["serde"] }
leptos_meta = { version = "0.3", default-features = false }
leptos_actix = { version = "0.3", optional = true }
leptos_router = { version = "0.3", default-features = false }

Story:
When a user has a view! macro which contains JSON/JS inside of a string literal enclosed by a script tag,
Indentation should be:

Untouched
Correctly formatted

What was tried:
Setting attr_value_brace_style = "AlwaysUnlessLit" in leptosfmt.toml but it doesn't seem to affect it (not sure if it's supposed to, it's not really documented on what they do)
What happened:
view! { cx,

                    <canvas id="chart" style="width: 100%; height: 100%; padding-bottom: 25px;" />

What was expected:
    view! { cx,

                    <canvas id="chart" style="width: 100%; height: 100%; padding-bottom: 25px;" />

related #7

for now I recommend that you keep the raw json string outside the view! macro.
Albeit off-topic, I reckon that eventually you would like to use something like the json! macro from: https://github.com/serde-rs/json ?

Just merged #32  to main, which will keep original indentation with multiline quoted strings. (so 1. untouched).
It does not format it's contents, I am not sure if I want to deal with external javascript formatters within this lib.
I honestly think you would be better of writing the script contents to a dedicated JS file so that you get proper editor tooling, thoughts?


[Devtools] Rework communication & organizational structure

📦 Published PR as canary version: 0.2.2--canary.17.444

Try this version out locally by upgrading relevant packages to 0.2.2--canary.17.444

/canary

/canary

/canary

/canary

/canary

This is no longer needed with the full rewrite introduced by #90 so I think we can close this?


New notebook without answers.

Created a separate notebook file and removed the answers in the code fields

Many thanks for the contribution! Having a 'no answers' version of the notebook is certainly worthwhile.


Lab5 - Stringer

Fixes #411
Review of colleague's PR #404
Changes proposed in this PR:
-Implements fmt.Stringer interface for IPAddr type

Adds tests

Squashed commits down to 2


T.H - Reconnection to ZCC

Logger: ControlPoint
Source: custom_components/zimi/cover.py:84
Integration: zimi
First occurred: 3:07:05 PM (38 occurrences)
Last logged: 3:33:29 PM
Controller not ready to accept commands - attempting to re-connect
Existing socket closed
Socket error when connecting to ZCC <IP_ADDRESS>:5003
Re-connection to ZCC failed with ControlPointError: Socket error when connecting to ZCC <IP_ADDRESS>:5003 - will retry in 90

Please try version 1.3rc8 of integration.   (Need to tick allow pre-release in HACS)


ring mode: mget and mset have no support for sharding on each individual key

In ring mode, the mget and mset operation's sharding is based on first key only. This makes mget does not work on keys set by individual set() operation.

It is not a bug - it is never meant to work. https://github.com/go-redis/redis/pull/493 is related.


fix horizontal scroll overflow on deposit liquidity page

@grandicrypto what is this issue exactly? I dont see an issue with the overflow on mobile or desktop

I don't see it either anymore, must have been fixed already


[KOGITO-3323] Tests: Update scenario description to be unique for eve…

…ry run
Signed-off-by: Karel Suta<EMAIL_ADDRESS>https://issues.redhat.com/browse/KOGITO-3323
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors' guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

/jenkins-test


Feature Request: Abillity to save from fullscreen / splitview editing.

I guess the subject says it all.
Having the abillity to save a page from within the fullscreen / splitview editing would save a couple of clicks :-)

Did you try cmd + s? Should work if the cursor is in the editor field

Ahh. I've missed that. Works. Thanks!


Asked for a Matrix account

After the last update, when I start the server I get the following message:
You haven't configured a Matrix account yet. You need a Matrix account to let me talk to other Almonds. Loaded manifest for org.thingpedia.builtin.matrix, module type: org.thingpedia.builtin, version: 1

Yeah, it should ask for your email and let you say it in voice or type it from the web interface (which is available at <IP_ADDRESS>:3000/conversation ).
You can register the account at https://riot.im

But what is this for?

Okay, thanks!


Ready spark-hyperloglog for publishing on Sonatype

Why the switch from spark-packages to sonatype?

@mreid-moz because spark-packages wouldn't allow us to have multiple users access the same repo, unfortunately

Ok, that's an interesting limitation :)


password and confirm password match validation

How can i compare two fields to have same data? like email and confirm email? password and confirm password

Hello samkazmi,
there's a validator for that : https://github.com/vekexasia/android-edittext-validator/blob/master/library/src/com/andreabaccega/formedittextvalidator/SameValueValidator.java
You'll need to add it at runtime

thanks man.....

No problem, closing

thanks


Use import rather than require before Vitepress CJS support is dropped

Thanks @benmccann for the update. Looks good!


readable-stream version

Hi, just curious if you'd be open to changing dependency to any version of readable-stream and bump to 1.0? This library does a fantastic job of fixing an issue in vinyl-fs and would definitely like to incorporate it.
Cheers!
-Mark

To clarify, this module attempts to use the built in stream module before attempting to use readable-stream but I think it would be a better idea to always you readable-stream directly (not any version, just latest).  See https://r.va.gg/2014/06/why-i-dont-use-nodes-core-stream-module.html

The above issues are being brought up because we'd like to use this module in the next version of gulp.

Sounds like a pretty good idea. I noticed the ancient version a few weeks ago but didn't bother to do anything about it ("If it ain't broke…").
Oh, and sorry about the delay. Family time ;)

@Klowner can you try<EMAIL_ADDRESS>and tell me if that'll do?

@jpommerening works perfectly here! Everything look good to you, @phated ?

Yep. LGTM

Ok, published as 1.0.0. Thanks, guys!

Thank you! :+1:


Update for ceci version 2

This PR updates the constructors of all stage subclasses to work with ceci version 2, in which aliases are specified in the constructor. A similar PR has been opened for each RAIL repo.
The main change is to the the constructors to accept any keywords with **kwargs and pass them to the parent class.
I have also removed any constructors which did not do anything except call the parent class constructor. Since this happens automatically if you omit the constructor, these were redundant.
Finally, in constructors I have changed I have removed hard-coded parent classes in favour of the python3 recommended super() function. If the parent class are changed in the future the constructor will still work.

Hi all - this is ready to review now - see my note on slack #desc-pz-rail for a plan, should not merge it yet.

Changes look fine. I will make some tests with the new code to check it all runs through our examples...

Am I allowed to merge this or should one of the owners do it?

Am I allowed to merge this or should one of the owners do it?
I didn't merge as I saw @raphaelshirley's comment on testing this with the new code. @raphaelshirley are you happy with this to be merged?


Version 1.1.3

Hi, with V1.1.3 from today follow fault comes up:
`

nuki.0
2020-03-06 16:13:17.959
info
(25565) Callback successfully set: http://<IP_ADDRESS>:11111/api/nuki.0

nuki.0
2020-03-06 16:13:15.454
info
(25565) Bridge Info requested: http://<IP_ADDRESS>:8080/info?token=geheim

nuki.0
2020-03-06 16:13:14.224
info
(25565) Server listening to http://<IP_ADDRESS>:11111

nuki.0
2020-03-06 16:13:12.065
info
(25565) Lock list requested: http://<IP_ADDRESS>:8080/list?token=geheim

nuki.0
2020-03-06 16:13:11.092
info
(25565) found hardware bridge: 164400993 (IP: <IP_ADDRESS>; Port: 8080)

nuki.0
2020-03-06 16:13:04.962
info
(25565) starting. Version 1.1.3 in /opt/iobroker/node_modules/iobroker.nuki, node: v10.19.0

nuki.0
2020-03-06 16:12:32.776
info
(25388) Callback-ID successfully removed: 0

nuki.0
2020-03-06 16:12:32.691
info
(25388) Terminated (NO_ERROR): Without reason

nuki.0
2020-03-06 16:12:32.674
info
(25388) terminating

nuki.0
2020-03-06 16:12:32.655
info
(25388) cleaned everything up...

nuki.0
2020-03-06 16:12:32.651
error
at IncomingMessage.emit (events.js:203:15)

nuki.0
2020-03-06 16:12:32.651
error
at Object.onceWrapper (events.js:286:20)

nuki.0
2020-03-06 16:12:32.651
error
at IncomingMessage. (/opt/iobroker/node_modules/request/request.js:1083:12)

nuki.0
2020-03-06 16:12:32.651
error
at Request.emit (events.js:198:13)

nuki.0
2020-03-06 16:12:32.651
error
at Request. (/opt/iobroker/node_modules/request/request.js:1161:10)

nuki.0
2020-03-06 16:12:32.651
error
at Request.emit (events.js:198:13)

nuki.0
2020-03-06 16:12:32.651
error
at Request.self.callback (/opt/iobroker/node_modules/request/request.js:185:22)

nuki.0
2020-03-06 16:12:32.651
error
at Request._callback (/opt/iobroker/node_modules/iobroker.nuki/main.js:1036:21)

nuki.0
2020-03-06 16:12:32.651
error
at updateAllLockStates (/opt/iobroker/node_modules/iobroker.nuki/main.js:791:13)

nuki.0
2020-03-06 16:12:32.651
error
at setLockState (/opt/iobroker/node_modules/iobroker.nuki/main.js:757:26)

nuki.0
2020-03-06 16:12:32.651
error
(25388) ReferenceError: _obj is not defined

nuki.0
2020-03-06 16:12:32.651
error
(25388) uncaught exception: _obj is not defined

nuki.0
2020-03-06 16:12:32.644
info
(25388) Lock list requested: http://<IP_ADDRESS>:8080/list?token=geheim

nuki.0
2020-03-06 16:11:39.625
info
(25388) Bridge Info requested: http://<IP_ADDRESS>:8080/info?token=geheim

nuki.0
2020-03-06 16:11:38.690
info
(25388) Server listening to http://<IP_ADDRESS>:11111

nuki.0
2020-03-06 16:11:38.685
info
(25388) Callback allready set: http://<IP_ADDRESS>:11111/api/nuki.0

nuki.0
2020-03-06 16:11:36.414
info
(25388) Lock list requested: http://<IP_ADDRESS>:8080/list?token=geheim

nuki.0
2020-03-06 16:11:35.601
info
(25388) found hardware bridge: 164400993 (IP: <IP_ADDRESS>; Port: 8080)

nuki.0
2020-03-06 16:11:29.479
info
(25388) starting. Version 1.1.3 in /opt/iobroker/node_modules/iobroker.nuki, node: v10.19.0

nuki.0
2020-03-06 16:10:57.567
error
(25087) null

nuki.0
2020-03-06 16:10:57.160
info
(25087) Terminated (NO_ERROR): Without reason

`

I can confirm. Same thing for me.

Hi,
thanks for reporting.
I've fixed it in Version 1.1.4. Please install from GitHub and test.
Regards
Sven

Hi,
thanks for reporting.
I've fixed it in Version 1.1.4. Please install from GitHub and test.
Regards
Sven

Thank you very much for the quick fix! Works great for me.

verified, fixed in 1.1.4. thank you very much!


Fix DataTable's Location to be aware of all of its lines

Hi folks! I'm back with another DataTable-related bugfix. When being built, DataTables would build their Ast::Location with only the first line. In the following example feature, this led to commands like cucumber features/test.feature:5 working, but cucumber features/test.feature:6 not running any tests, because no Test::Case reported containing that line.
Scenario: Run scenario with a data table
  Given a file named "features/test.feature" with:
    """
    Feature:

      Scenario: DataTable
        Given this step is a table step
          | a | b |
          | c | d |
    """
  When I run `cucumber features/test.feature:6 --format pretty --quiet`
  Then it should pass with exactly:
    """
    Feature:

      Scenario: DataTable
        Given this step is a table step
          | a | b |
          | c | d |

    1 scenario (1 passed)
    1 step (1 passed)

    """

How Has This Been Tested?
I'm not quite sure how best to test this. My first inclination is to add a unit test, but there appear to be no unit tests in this project for Cucumber::Core::Gherkin::AstBuilder or any of its internals. The cucumber acceptance test above could be added to the parent cucumber/cucumber-ruby project, but it seems a bit too edge-casey for a full acceptance test, IMO. Thoughts?
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I've added tests for my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Hello @botandrose!
It looks like the rest of the specs for location matching are here: https://github.com/cucumber/cucumber-ruby-core/blob/master/spec/cucumber/core/test/filters/locations_filter_spec.rb
It looks like we're just missing a another case around here.

@mattwynne Thanks for the pointer! Indeed, that appears to be exactly the right place to add tests for this. I just rebased, squashed, and force-pushed.
As an aside, I've only recently gotten the commit-bit. What's the etiquette for merging PRs? Can I merge my own PRs in clear-cut situations like this?

Roger that! Thanks for the review!

Hi @botandrose,
Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾
In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@botandrose - one more thing. Please update the changelog - you can do it on master. Add an entry to the top.
Thanks
Aslak

Sorry for the delay... just got back into town from the eclipse 🌑! HISTORY.md is updated.


Option for persistent Control bounds

Godot version:
3.1 beta8
Issue description:
When designing interfaces, it is sometimes useful to show bounding rectangles of all Control nodes, including not selected ones. Godot doesn't seem to allow this right now. To distinguish simple bounds from selected nodes, they could use another color, e.g. gray for not selected ones and orange for selected.
How it looks right now:

How it could look with this option enabled:

After using GUI for a bit more, I noticed that you use containers most of the time, which makes bounds  rather irrelevant. Closing this for now.


Adding pre & post to Model

Goals :soccer:
This makes a Model more block-like by adding pre & post. This is a flexible way for a user to add transformations to the model in an easy way. Some of the use-cases would be negative-sampling (for ranking), swap noise & simple masking for youtube dnn.
Implementation Details :construction:
Example of
model = ml.Model(
        ml.InputBlock(schema),
        ml.MLPBlock([64]),
        ml.BinaryClassificationTask("click"),
        pre=ml.StochasticSwapNoise(schema),
)

Is the use of pre/post currently functionally equivalent to passing the block in along with the others in the right order (the first/last block/layer)?
model = mm.Model(
    mm.InputBlock(schema), mm.MLPBlock([64]), mm.BinaryClassificationTask("click"), pre=mm.StochasticSwapNoise(schema)
)

# vs

model = mm.Model(
   mm.StochasticSwapNoise(schema), mm.InputBlock(schema), mm.MLPBlock([64]), mm.BinaryClassificationTask("click")
)

I'm trying to think of an example where the use of pre/post would make things possible or easier that are not currently, (If the above is not equivalent).
Is this motivated by the ability to run some parts of the model during training only, e.g.  StochasticSwapNoise seems like a concept that you might only want to apply during training and not inference. Or is that functionality enabled with a different mechanism?


Bug: API Gateway - invalid escape sequence '['

Expected Behaviour
When importing from aws_lambda_powertools.event_handler.api_gateway there should be no warning raised.
Current Behaviour
Deprecation warning is raised on import on api_gateway.pyL46:
DeprecationWarning: invalid escape sequence '\['
_UNSAFE_URI = "%<> \[\]{}|^"  # noqa: W605

If pytest is run with warnings as errors, Syntax error is raised instead and module loading is terminated.
Code snippet
import warnings

def test_api_gateway_import():
    with warnings.catch_warnings():
        warnings.simplefilter("error")
        from aws_lambda_powertools.event_handler.api_gateway import APIGatewayRestResolver

Possible Solution
Remove # noqa: W605 and prefix pattern with raw string modifier. I haven't checked if this is an issue elsewhere in the codebase.
Steps to Reproduce

Remove __pycache__ from aws_lambda_powertools/event_handler (once code is bytecompiled error is no longer triggered)
Run above code snippet as pytest test

Powertools for AWS Lambda (Python) version
latest
AWS Lambda function runtime
3.10
Packaging format used
PyPi
Debugging logs
No response

Looking at this now

@nejcskofic I've opened a PR to fix this, can you take a look to see if it makes sense?

@rubenfonseca Looks good, thank you for the quick response!


unable to evaluate histogram: Evaluation Exception

When I try to evaluate something like below I'm getting an exception. Could someone help me solve this problem.
hist(c(1,2,1,3,4,2,3,1,2,3,4,1,2,3,4,2,5,3,2,1,2,4,5,2,3,4,5,1,2,3,1,2,4,2,1,2))
I am getting the below error
Error in inDL(x, as.logical(local), as.logical(now), ...) :
unable to load shared object 'C:/Program Files/R/R-3.2.2/library/stats/libs/i386/stats.dll':
LoadLibrary failure:  The specified module could not be found.

How are you running this? That error usually happens if you are running under IIS in an ASP.Net application. The workaround is to make sure the R appropriate bin folder is on your path (and restart IIS so that it picks up the path change) so that dll resolution can find the appropriate dlls.

Yes, I'm running under IIS in an ASP.NET application. There are other things working but I see only problem with hist. My path already contains bin of R. So it must be something else that's wrong in it.
When I just evaluate hist(c(1:4)) it works. But for some hist data it's not working. It's so annoying I'm not able to figure out what's going wrong.

You haven't provided any sort of evidence that you have a unique problem. Before dismissing my suggestion, I suggest you look at this issue thread (https://rdotnet.codeplex.com/workitem/117), make sure that the appropriate bin folder is on your path, restart IIS, and try again.

Oh sorry, I'll cross check again tomorrow. I can't access the work now. I was sure I added R bin to path because I was executing R script from command prompt. Thanks for your response.
-----Original Message-----
From: "Ritch Melton"<EMAIL_ADDRESS>Sent: 4/12/2015 11:08 a.m.
To: "jmp75/rdotnet"<EMAIL_ADDRESS>Cc: "Sunil Kumar Reddy Buddala"<EMAIL_ADDRESS>Subject: Re: [rdotnet] unable to evaluate histogram: Evaluation Exception(#23)
You haven't provided any sort of evidence that you have a unique problem. Before dismissing my suggestion, I suggest you look at this issue thread (https://rdotnet.codeplex.com/workitem/117), make sure that the appropriate bin folder is on your path, restart IIS, and try again.
—
Reply to this email directly or view it on GitHub.

No worries. Let me know what you find out.

It's working

Outstanding. Glad its working now.


New version: TheBrowserCompany.Arc version <IP_ADDRESS>112

Created by 🥟 Dumplings in workflow run #6957.

Log
Updated: <IP_ADDRESS>629 → <IP_ADDRESS>112
Submitting WinGet manifests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run

Automatic Validation ended with:

Installation failed with exit code -1978334972
2024-07-31 02:07:24.252 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFFDD89C11F: (caller: 00007FFFDD628D6F) LogHr(1) tid(5f4) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFFDD7A2B08: (caller: 00007FFFDD84BC20) Exception(1) tid(5f4) 8A15005E ]
2024-07-31 02:07:27.536 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFFC323C11F: (caller: 00007FFFC2FC8D6F) LogHr(1) tid(464) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFFC3142B08: (caller: 00007FFFC31EBC20) Exception(1) tid(464) 8A15005E ]
2024-07-31 02:07:39.739 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFFBF33C11F: (caller: 00007FFFBF0C8D6F) LogHr(1) tid(1cf4) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFFBF242B08: (caller: 00007FFFBF2EBC20) Exception(1) tid(1cf4) 8A15005E ]
2024-07-31 02:08:30.958 [CORE] Deployment operation #2: Windows cannot install package TheBrowserCompany.Arc_<IP_ADDRESS>112_x64__ttt1ap7aakyb4 because this package depends on a framework that could not be found. Provide the framework "Microsoft.VCLibs.140.00.UWPDesktop" published by "CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or x64 processor architecture and minimum version 14.0.33728.0, along with this package to install. The frameworks with name "Microsoft.VCLibs.140.00.UWPDesktop" currently installed are: {Microsoft.VCLibs.140.00.UWPDesktop_14.0.29231.0_x86__8wekyb3d8bbwe Microsoft.VCLibs.140.00.UWPDesktop_14.0.30035.0_x64__8wekyb3d8bbwe Microsoft.VCLibs.140.00.UWPDesktop_14.0.30704.0_x64__8wekyb3d8bbwe Microsoft.VCLibs.140.00.UWPDesktop_14.0.33321.0_x64__8wekyb3d8bbwe}
2024-07-31 02:08:30.958 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(161)\WindowsPackageManager.dll!00007FFFBF1C3F75: (caller: 00007FFFBF11A720) Exception(2) tid(1cf4) 80073CF3 Package failed updates, dependency or conflict validation.
2024-07-31 02:08:31.095 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFFBF1C2D2F: (caller: 00007FFFBF1C432C) Exception(3) tid(1cf4) 80073CF1 Package was not found.
2024-07-31 02:08:31.095 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(126)\WindowsPackageManager.dll!00007FFFBF338931: (caller: 00007FFFBF1C5853) LogHr(2) tid(1cf4) 80073CF1 Package was not found.
Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Deployment.cpp(54)\WindowsPackageManager.dll!00007FFFBF1C2D2F: (caller: 00007FFFBF1C432C) Exception(3) tid(1cf4) 80073CF1 Package was not found.
2024-07-31 02:08:31.159 [CLI ] MSIX installer failed:<PHONE_NUMBER>

Automated error analysis suggests -1978334972 may mean This package has a dependency missing from your system.
Automated error analysis suggests 8A15005E may mean APPINSTALLER_CLI_ERROR_PINNED_CERTIFICATE_MISMATCH - The server certificate did not match any of the expected values.
Automated error analysis suggests<PHONE_NUMBER> may mean Error Installing Dependency - Windows cannot install this package because it depends on a framework (version) that could not be found.
(Automated response - build 887.)

https://github.com/microsoft/winget-pkgs/issues/161022

@wingetbot run

[Policy] Dependencies

[Policy] Dependencies
[Policy] Blocking-Issue

This package installs and launches normally in a Windows 10 VM.
(Automated response - build 923.)


on_failed_registration and Sinatra

How would one go about doing this? I'm no ruby-master, but i couldn't find an answer for this.

Thanks for the great answers!


Git repository analysis tool - question

I am wondering how to approach the task of making a custom agent/tool that would analyze a Git repository, so a chatbot powered by the agent would be able to retrieve documentation that's inside this repository, provide code samples etc.
I'm planning on developing one, so far my main concern is how would the agent first learn so then it would be able to retrieve information using, let's say, GitHub API.
Do you know if there a way for the agent to first learn, so then it can sit on the server and answer questions about a certain GIt repo?

Here is the doc link about Tools  that's probably answers your concern.
Provide a natural language description of what the tool does:

❗Important: the agent uses this description to determine when the tool should be used. It’s probably the most important aspect of your tool and you should experiment with different natural language descriptions to ensure the tool is used in the correct circumstances. You can also include usage tips and guidance for the agent in the description, but its advisable to keep the description succinct in order to reduce the probability of conflicting with other tools, or adversely affecting agent behavior.

description = "Takes X action when given Y input resulting in Z output";

Declare an input schema:

This is used to define the format of the input to your tool. The agent will formalise the natural language input(s) it has received and structure them into the fields described in the tool’s input. The input schema can be specified using Zod (recommended) or JSONSchema. It must be a function (either sync or async). Zod effects (e.g. z.object().transform(...)) are not supported. The return value of inputSchema must always be an object and pass validation by the validateSchema() function defined in schema.ts. Keep your tool input schema simple and provide schema descriptions to help the agent to interpret fields.

Here is the one example of description and input schema of the tools


What about constraints for type parameters?

How do you (can you) specify type parameter constraints?  In particular, specify that the type must implement an interface or derive from a base class?  For example, suppose you wanted to use functionality in the constraint (i.e. modify the table template in the example to include autogenerated cells in each row, displaying values provided by a constraint base class or interface the type parameter must implement?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7e918d36-59d2-2264-e6b3-27071cda549c
Version Independent ID: c7e7e5bc-4686-d641-4f1e-da2de7491758
Content: ASP.NET Core Blazor templated components
Content Source: aspnetcore/blazor/templated-components.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @ClaudioFriederich ... Open an issue for the product unit. Cross-link this topic ...
[Templated components topic](https://docs.microsoft.com/aspnet/core/blazor/templated-components)

Add a "cc: @guardrex" to your opening issue comment so that I can follow the discussion.
Open it at: https://github.com/dotnet/aspnetcore/issues
I'll re-open this if we can add something to the doc to cover it.

I searched and found that an issue already exists in the product unit: https://github.com/dotnet/aspnetcore/issues/8433
As I understand the discussion there, constraints are possible by creating a partial class for the component, and declaring the constraints in the partial class.  I have not had a chance to try this, but several people reportedly got it to work.
Thank you for the information and quick reply.
From: Luke Latham<EMAIL_ADDRESS>Sent: Tuesday, March 17, 2020 6:48 PM
To: dotnet/AspNetCore.Docs<EMAIL_ADDRESS>Cc: ClaudioFriederich<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/AspNetCore.Docs] What about constraints for type parameters? (#17348)
Hello @ClaudioFriederich https://github.com/ClaudioFriederich  ... Open an issue for the product unit. Cross-link this topic ...
Templated components topic
Add a "cc: @guardrex https://github.com/guardrex " to your opening issue comment so that I can follow the discussion.
Open it at: https://github.com/dotnet/aspnetcore/issues
I'll re-open this if we can add something to the doc to cover it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dotnet/AspNetCore.Docs/issues/17348#issuecomment-600423014 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ANYS6WORALPGYARP7GSHXGDRIBHBTANCNFSM4LOE2FDQ .  https://github.com/notifications/beacon/ANYS6WKSBKNGXNLH3657G4DRIBHBTA5CNFSM4LOE2FD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEPE3UZQ.gif

@ClaudioFriederich ... Cool. I'll see if I can craft something temporarily for that in the doc. We don't usually document workarounds while they work on a new feature. However, I see a lot of :+1: on that issue. I'll ping you on the PR.


Resolves #23 (Class level is-accessible doesn't work)

Resolves issue #23 (Class level is-accessible doesn't work). Logic:
Both class A and B declared accessible: Map from matching fields in A to fields in B
Only class A declared accessible: Map from matching fields in A to matching properties in B
Explicit mappings (via @Mapping or XML) override these default is-accessible="true" mappings

I've run into this issue today, unfortunately - is there any updated planning for the 5.5.2 release?

@lauriharpf  is 5.5.2 out yet?   Latest I found is 5.5.1
Really need the class level is-accessible to be fixed.

@logysis ; the current version is 6.1. please see the migration docs: https://github.com/DozerMapper/dozer/tree/master/docs/asciidoc/migration

Thank you
Get Outlook for iOShttps://aka.ms/o0ukef

From: Gareth Healy<EMAIL_ADDRESS>Sent: Wednesday, October 18, 2017 2:47:04 AM
To: DozerMapper/dozer
Cc: logysis; Mention
Subject: Re: [DozerMapper/dozer] Resolves #23 (Class level is-accessible doesn't work) (#178)
@logysishttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flogysis&data=02|01|logysis%40hotmail.com|72f4efafc68a49bd508d08d5160d30b5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636439168252794724&sdata=ExoQl6uTo0qKxpYVg5RsgdUjdMVwnsvifG6jDK1nauY%3D&reserved=0 ; the current version is 6.1. please see the migration docs: https://github.com/DozerMapper/dozer/tree/master/docs/asciidoc/migrationhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDozerMapper%2Fdozer%2Ftree%2Fmaster%2Fdocs%2Fasciidoc%2Fmigration&data=02|01|logysis%40hotmail.com|72f4efafc68a49bd508d08d5160d30b5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636439168252794724&sdata=%2BaWK7%2FSbvuyJF9Afm1euRzouKdUEp8gsEzsNyjnKIEU%3D&reserved=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDozerMapper%2Fdozer%2Fpull%2F178%23issuecomment-337529462&data=02|01|logysis%40hotmail.com|72f4efafc68a49bd508d08d5160d30b5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636439168252794724&sdata=Dfau5Kacz506GPfDQzIxluW8X5srHcxMc6yJjXgapUM%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEPrJuPn44GEQkasc4wWBCOmffZfJO4jks5stckXgaJpZM4CQ-BT&data=02|01|logysis%40hotmail.com|72f4efafc68a49bd508d08d5160d30b5|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636439168252794724&sdata=4QaP6L9JvuztQe5%2FtrK%2Bbrn90N4KCjdTUbMVzIva1JU%3D&reserved=0.

@garethahealy
I tried the upgrade, all seems fine and compiles correctly.  Except at runtime it complains on below.  Have you ever encountered the same thing after upgrade?
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory

@logysis ; no, not seen this. if it persists. please raise an issue.