Editor ray-casts fail when using many bodies

Using Godot 4.2.2
I was getting inaccurate results with some of my raycasts, some of them not colliding even though I had similar raycasts correctly colliding the same object (in different positions).
So I made a little test project to figure out why, with a plugin that creates a grid of collision boxes and then paints those boxes when you hold space. This was the result:

A half circle in the +X position (may not be perfect due to my code). When disabling godot jolt, I can paint the entire area.
This also occurs when casting the rays programmatically, straight down.
To test the project I made: open the tester_node, turn the toolbar Edit toggle on, then hold space and paint with cursor.

I was wondering when this was gonna come back to haunt me.
The problem seems to be related to the fact that I never call Jolt's JPH::PhysicsSystem::OptimizeBroadPhase() method, which means that physics queries within the editor end up traversing an incredibly inefficient broadphase (quadtree) and subsequently blows out its fixed-size stack of 128, resulting in largely arbitrarily broken results.
I had left this out somewhat deliberately, since at runtime the broadphase gets rebuilt/optimized at the first physics tick anyway, which seemed as good of a time as any to do it, and that it wouldn't matter a whole lot if the editor queries were a bit slower than they should be. Obviously this ends up actually breaking things rather than just being slow though, so I'll need to do something about this.
Perhaps I can start/reset some quick timer whenever a new body is added to the scene and run OptimizeBroadPhase() when it finishes.
I'd love to hear your thoughts on this @jrouwe.

I cooked up a tentative solution in #834, which seems to resolve the issue, by queueing up an OptimizeBroadPhase() call for the next frame (call_deferred) for any simulation that has bodies added/removed, but only if that simulation is inactive (i.e. editor stuff typically).
It's a fairly scary change, but I don't really see any other way out of this.

I'd love to hear your thoughts on this @jrouwe.

As an alternative to your current solution, you could also keep a simple counter that counts the number of bodies that got added since the last physics update and if it gets close to the danger zone (128 * 3) you could trigger the optimize call.

I'm a bit hesitant to make assumptions about the particular broad-phase structure Jolt uses, but that is undoubtedly a less scary (and probably more robust) solution.
I figured since this is (and correct me if I'm wrong) theoretically also an issue at runtime if someone decides to add a few hundred bodies, and then immediately perform a physics query on them, I would instead check the counter at the start of every physics query. I then reset the counter if we've already run OptimizeBroadPhase or PhysicsSystem::Update.
That way you shouldn't have any OptimizeBroadPhase calls during normal runtime use unless absolutely necessary, but it will always run in the editor viewport if you're dealing with a few hundred bodies.

I would instead check the counter at the start of every physics query, as opposed to when bodies are added. I then reset the counter whenever OptimizeBroadPhase or PhysicsSystem::Update is run.

That sounds like it will work (and apparently it did, given you just submitted the change 😄).
Another thing I just thought of is that you could delay the adding of bodies. Basically you would batch up BodyIDs in an array and you would call AddBodiesPrepare / AddBodiesFinalize on the batch just before doing a collision check, before removing a body (it could be in the 'to add' list) or before stepping the simulation (and maybe a few other places). For the most part, the Jolt interface doesn't care if a body has been added or not (search for IsInBroadPhase), the biggest thing is you can't activate a body before it has been added. Obviously this change is a bit bigger and riskier than the one you just did, but it is more efficient.

Another thing I just thought of is that you could delay the adding of bodies. Basically you would batch up BodyIDs in an array and you would call AddBodiesPrepare / AddBodiesFinalize on the batch just before doing a collision check, before removing a body (it could be in the 'to add' list) or before stepping the simulation (and maybe a few other places). For the most part, the Jolt interface doesn't care if a body has been added or not (search for IsInBroadPhase), the biggest thing is you can't activate a body before it has been added. Obviously this change is a bit bigger and riskier than the one you just did, but it is more efficient.

I did contemplate deferring/batching the creation of the bodies, but I failed to realize that I could just defer/batch the adding of them instead. I do however suspect that it would complicate the logic surrounding the association between a body and its physics space/world/system, given that it could then be in three states (none/created/added) rather than two (none/added), but maybe not by much.
But yeah, deferring stuff in general is scary, and tends to be where bugs show up in my experience, hence why I also chose not to go with the previous call_deferred solution.
I think this counter thing should be fine, even if it warrants some explanation in the code.
Thanks for the help!

The fix for this can now be found in the latest pre-release, 0.13.0-beta1, which you'll find here.
Note that this version targets the just recently released Godot 4.3-beta1, so won't work with Godot 4.2. Also note that this version is not available through the Godot Asset Library, so you'll need to download it through GitHub.
A proper release will be out some time around Godot 4.3-stable.

I figured I'd give a minor update here, as 0.13.0-stable has just been released, so if you've been relying on 0.13.0-beta1 for this functionality until now I would highly recommend updating, as this most recent release includes some important bug fixes.
Note that the release on the Godot Asset Library is still pending approval as of typing this, so you might need to download it from the link above.


Unexpected Websocket Error

For the past month or so I have been receiving the following error in my logs, 71 of them in the last 12 hours:
It has persisted through the last few core updates. An uninstall/reinstall of alarmdotcom does not help.
Logger: pyalarmdotcomajax.websockets.client
Source: /usr/local/lib/python3.12/site-packages/pyalarmdotcomajax/websockets/client.py:150
First occurred: 7:33:59 AM (71 occurrences)
Last logged: 7:20:03 PM
Unexpected WebSocket error
Traceback (most recent call last):
File "/usr/local/lib/python3.12/asyncio/selector_events.py", line 978, in _read_ready__get_buffer
nbytes = self._sock.recv_into(buf)
^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 104] Connection reset by peer
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/pyalarmdotcomajax/websockets/client.py", line 114, in _connect
async with self._websession.ws_connect(
File "/usr/local/lib/python3.12/site-packages/aiohttp/client.py", line 1197, in aenter
self._resp = await self._coro
^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/client.py", line 835, in _ws_connect
resp = await self.request(
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/client.py", line 608, in _request
await resp.start(conn)
File "/usr/local/lib/python3.12/site-packages/aiohttp/client_reqrep.py", line 976, in start
message, payload = await protocol.read()  # type: ignore[union-attr]
^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/site-packages/aiohttp/streams.py", line 640, in read
await self._waiter
aiohttp.client_exceptions.ClientOSError: [Errno 104] Connection reset by peer

This issue eventually went away.


Contexual Support

The native 3.0 action bar supports a contexual action bar which is wholly different from the activity action bar and is tied to a specific piece of content. This needs its own abstraction though a HasXxx interface.

See #23.


Add Symbol navigation for PHP

would you please add support for PHP symbol navigation ?
I like the symbol navigation for js, just press CTRL+SHIFT+O
The symbol list will show to us
that's amazing

PHP symbol navigation is working on previous builds after today's build is now broken.
Please help us, I'm using vscode in mac.

I need this, too!

+1

+1 too.
This used to work before 0.10.x :(

This used to work before 0.10.x :(

Sorry about that, but it was based on an hand written PHP parser that could not keep up with the PHP language.

that's still better than nothing, i guess :)

Is there any extension to make it work again? I just have to stay on the lower version, for the vs code is the best ide for php I have ever seen.

I'm working on an extension

@felixfbecker That's great! Do you have a link to the extension?

@thuey Currently trying to extend PHPParser so it can parse incomplete PHP documents so I can get AST nodes all the way up to the cursor position, even if it is not terminated by a semicolon yet:
https://github.com/nikic/PHP-Parser/issues/262

This is still an issue, and would be nice if it were resolved.

PHP IntelliSense supports both file and workspace symbol search
https://marketplace.visualstudio.com/items?itemName=felixfbecker.php-intellisense

May be this issue can be closed now.

ok. close it now . thanks.

Those who can't use @felixfbecker 's extension because of it's PHP7 requirement, can use Lin Yang's PHP symbols extension:
https://marketplace.visualstudio.com/items?itemName=linyang95.php-symbols

Just to avoid confusion, my extension works with PHP code of any version. You just need to install PHP 7 locally because the extension is written in PHP 7 itself and needs PHP 7 to run.

@felixfbecker Thanks for the clarification, you might want to add it explicitly in the plugin description, I misunderstood too.


Add E2E test for "Aggregate section no-trigger elements"

### Tasks
- [ ] Add E2E automation script

Given a logged-in user
And no-trigger scenario is loaded
When navigating to {country} floods
Then chat-section shows 'no events' message
And header should show {country} floods non-triggered
And all the “Aggregate” elements should be present:
Aggregate:

header

area title (National View)
number of events / triggered areas (0 predicted floods)
info icon

see 5 rows for 5 layers
per row

icon
layer name
number (0 in this case)
info icon

action summary

N/A in no-trigger

Test case available also in: https://dev.azure.com/redcrossnl/121 Platform/_testPlans/define?planId=30494&suiteId=30583


Publish oonidata on pypi

This issue is about uploading a beta version of oonidata to pypi

Duplicate of: https://github.com/ooni/backend/issues/581


Add Virtual Site screenshot needs updating - Deploy the “Recommendations” Service Lab

Environment

Application Lab

Describe the bug
Add Virtual Site screenshot needs updating - Deploy the “Recommendations” Service Lab
To Reproduce
Steps to reproduce the behavior:

Go to 'Exercise 1: Create a Virtual Site with our target REs'
Locate 'Step 3. Fill out the form.'
Replace Add Virtual Site screenshot with the attached.

Screenshots

Additional context
Love the labs!

updated in 1c8a336ccfd2c54d8ae74f80e08db17ab033956c.
Thank You @honghuac!


Various issues integrating OpenEXR as a CMake subproject

This is a (unsorted) list of problems I ran into when trying to use OpenEXR as a submodule within a bigger project. It would be great if those get addressed, as it would make consuming OpenEXR much easier.

Please don't write messages unless it's an error. By default, I'm seeing: Configure ILMBASE Version: 2.5.3 Lib API: 25.0.2
 -- WARNING pkg-config generation disabled
 Configure OpenEXR Version: 2.5.3 Lib API: 25.0.2

This happens on every single configuration. That quickly adds up when every project does it.
Please don't set BUILD_SHARED_LIBS if you're not the top-level project. An easy check is to compare the CMAKE_CURRENT_SOURCE_DIR with CMAKE_SOURCE_DIR and not turn on global options if it's a submodule. Instead, please add a prefixed option like OPENEXR_BUILD_SHARED or similar. That should be fairly easy to use given ILMBASE_DEFINE_LIBRARY is the entry point for library definitions, and you can simply select the library type there:  if(OPENEXR_BUILD_SHARED_LIBS)
    set(OPENEXR_LIB_TYPE SHARED)
  else()
    set(OPENEXR_LIB_TYPE STATIC)
  endif()
  add_library(${objlib} ${OPENEXR_LIB_TYPE}
    ${ILMBASE_CURLIB_HEADERS}
    ${ILMBASE_CURLIB_SOURCES})

I think that requires getting rid of the dual shared/static build as well.
It would be nice if PyIlmBase was disabled by default, or at least fail silently, at the moment it produces a lot of debug output (i.e. could not find Python2, but did find Python3, and fail eventually because Boost.Python is missing ...). Not a dealbreaker, as there is an option to disable it, but it would be nice if it got disabled automatically if the dependencies can't be satisfied.
It would be great if all options are prefixed OPENEXR_ consistently -- there are various prefixes used here (PYILMBASE_ for example).
Don't add CDashBoard targets unconditionally when built as a submodule (this can be worked around by setting BUILD_TESTING to off -- would be nice to have it off by default for submodules though.)
Don't install by default -- this requires all dependencies to be export-able, so for instance if I statically compile ZLIB and IlmImf in my "superproject", then my ZLIB needs to be exportable to satisfy IlmImf's export statement, even though I don't want to install ZLIB or IlmImf. Would be great if this was an option.

Thanks for these detailed notes. They touch on a number of other open issues. I broke down individual issues to track the problems raised, and to relate the individual issues to pre-existing issues. The individual sub-issues should make it easier to discuss and make progress incrementally.
I didn't reference the PyIlmbase issue in the sub-issues, it's resolved in the Imath project.

zlib referencing is controlled by OPENEXR_FORCE_INTERNAL_ZLIB
We no longer build static and shared together
a pass has been done on conforming on OPENEXR_*
NOTICE has been changed to STATUS, WARNING, FATAL_ERROR as appropriate.
If any of these could use more work, please let us know in this issue, or a new one! Thanks again for the feedback.

Thanks, this is looking good! Minor nitpicks only:

If you could use if(NOT TARGET ZLIB::ZLIB) to check if ZLIB is present before calling find_library(zlib), that would make integration a bit easier. I made this change locally:
if (NOT OPENEXR_FORCE_INTERNAL_ZLIB)
  if(NOT TARGET ZLIB::ZLIB)
    find_package(ZLIB QUIET)
  endif()
endif()
if(OPENEXR_FORCE_INTERNAL_ZLIB OR NOT TARGET ZLIB::ZLIB)

in OpenEXRSetup.cmake.

It still tries to install by default, which causes failures if my own copy of ZLIB is not exported. Removing the last INSTALL statement from openxr/cmake/CMakeLists.txt fixes it

I see a bit of debug spew on each configure:
Configure Imath Version: 3.0.0 Lib API: 26.0.0
Imath is configuring as a cmake sub project
pkg-config generation disabled
Configure OpenEXR Version: 2.5.99 Lib API: 26.0.1
OpenEXR is configuring as a cmake subproject
-- pkg-config generation disabled

With those changes applied I got OpenEXR to work locally, without any of the previous pain :) Thanks a lot for that!
Is this ok keeping here or do you want me to file a new issue?

I submitted #954 to address these.  I'm not following the logic behind removing last install statement, does #954 do what you recommend?
I kept the spewage in place for now, but at least made the pkg-config status messages consistently formatted.

Yes, that works for me, thanks :) That said: I'm don't think that's what you want, as in unconditionally disable all install support. I think the optimal solution here would be to put that behind an option. As I see it right now you can't install OpenEXR standalone with #954 applied.


How do I determine the GitHub username?

I would like to know the GitHub username to determine the name of the remote created by fork. Something like hub config hub.user would be helpful. Here's a workaround:
sed -ne 's/^- user: //p' ~/.config/hub

Yes, I've experienced this problem too when automating a process using hub fork. Here's how I solved it, but it's definitely not pretty.
I'm aware of various hub fork usability problems which are being tracked in different open issues such as https://github.com/github/hub/issues/762. I'm closing this one for duplicate for now. Thanks for reporting!

Yes, this issue results in a usability issue with fork. Still I think a command (regardless of the use case) to return the user's GitHub username would be useful.

Thanks for sharing your workaround.

A command (regardless of the use case) to return the user's GitHub username would be useful.

Yes, the idea for that is tracked in #225

Ah, thanks!


Update view and update command in UserGuide.md

Update the UserGuide with the View and Update command. To be merged and integrated with the rest of the commands done by other teammates.

Codecov Report

Merging #35 (ef59e95) into master (2172777) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2172777...ef59e95. Read the comment docs.

fixes #36

fixes #22


Statements like “If Variable False” will not show up in the Variable Uses page

Describe the bug
When placing an event like “If Variable Is True”, the chosen variable will show up in the project’s “Variable Uses” page. This is a relatively new feature that I love, however I found one big issue: statements like “If Variable False” will not show in that menu. Same goes with If Variable Compare with Value events, like “If (ShakeOFF ==3”.
To Reproduce
Steps to reproduce the behavior:

Place a “If Variable is False” event anywhere (For example, let’s use “ShakeOFF”)
On the left tabs go to the Variable page and find the aforementioned variable (find “ShakeOff”)
On Variable Uses, there should be no mention of it being used by the “If Variable is False” event.

It’s possible to repeat this with another event like “If Variable Compare with Value”, and it will also not show up (at least in my testing).
Expected behavior
I believe it is an oversight or bug that the “If Variable Is False” events do not show up in the variable uses. Using a “If Variable is True” event will show up just fine.
Screenshots

Platform (please complete the following information):

OS: Windows 11
GB Studio 4.0.2 (latest as of now)

Additional context
The images above are from my game. “If ShakeOFF is False” events are used all over my game, like this custom script named “Knockback (Hurt Less X)”, but it only shows that it’s used in the scene “Options”.

Hi @KirbyKing186 yeah we noticed this a few weeks back, a fix is in place in the develop branch which I'm hoping to release soon as part of 4.1.0 :-) I've just run through the steps you listed in my local version and can confirm the variable appears in the Variable Uses list now

Great!


Adding notebook that I used to make the VectorStoreIndex

It is ~250MB in size, so I will share it with you on google drive

Looks great Ed. Looking forward to using the data.

I noticed that jake closed this heat PR, that is tragic @jakeflynn56

RIP


Why do I need to update to nightly to request a new site?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
The checklist here even asks me to get nightly, just to ask a question and a warning that I'll be shot if not.
You don't find this a little misplaced?
You also have a supported site file, which the site I'm requesting, filmarkivet.no is not in. I need to still download nightly?
This procedure to follow is unclear, I mean, are the other files which tracks sites in development? If not, then there should be no reason to download nightly. There should also be no reason, whatsoever, to download nightly, to just ask a question.
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

This was just closed, without answering the question?

The reason is that often times issues are already fixed or sites already added in newer builds, but people are running old to very old versions and complain that stuff isn't working. Due to the nature of yt-dlp we recommend everyone to use the nightly builds.
If you want to participate in the issue tracker you should install the latest nightly version. And no the suppoerted sites list is not a suplement as it only gets updated on released, and not all sites are listed there (for example due to being handled by the generic extractor).

False positive in virus total. Calling yt-dlp without any arguments makes no web requests.


Can I join and contribute? I can help with code review and wiki editting.

Sure thing, closed with #201 checked-in


Remove Left side title section or adjust size

Is your feature request related to a problem? Please describe.
Requested feature
Describe the solution you'd like
Be able to remove title section all together or adjust width.  Card ends up too wide due to title area to be able to use on phone interface.
Describe alternatives you've considered
Remove title area all together or move title area to top or bottom instead
Additional context
Add any other context or screenshots about the feature request here.

Done. Please see new titleSize and showSidebar options.
Stack looks not good not mobile. I need more times, which I barely have, to work on it.
Thanks for your feedback! 🤠


Handle annotation unpacking in BlockwiseIO

[x] Tests added / passed
[x] Passes black dask / flake8 dask

/cc @rjzamora

Is there a test that we could write that would have picked this up?

Is there a test that we could write that would have picked this up?

I'll try think of something by EOD (UTC + 02h00) today.

This test ensures that each subclass adheres to the packing and unpacking interface, but does not test packing/unpacking individually.

Test failures seem unrelated.

I've added a BlockwiseIO annotation test.

Just merged master (hope that's okay @sjperkins) which should resolve the unrelated CI errors

Just merged master (hope that's okay @sjperkins) which should resolve the unrelated CI errors

Absolutely OK, Thanks for assisting!


The LSS NB with my extension for 3D plotting

I added the extension for 3D plotting and interactive visualization in the LSS NB to the science examples NBs
There is a local file needed which is a lite version of an extended virgo cluster catalog (EVC_coords_cz.csv)

@kareninysimba @jacquesalice @stephjuneau
Could you please briefly review the new 3D plotting section in this NB? We'd like to merge it in time for the DL newsletter.
I made some edits to David's version from yesterday (described in the commit log).
Thank you!

Planck2018 cosmology reference: https://ui.adsabs.harvard.edu/abs/2020A%26A...641A...6P/abstract

Alright, I got a new query to work (though it takes ~20 sec now instead of ~1 sec):
# ls_dr10.tractor                            # LS DR10 tractor photometry
# ls_dr10.x1p5__tractor__sdss_dr17__specobj  # LS DR10 pre-crossmatched to SDSS DR17 specobj
# sdss_dr17.specobj                          # SDSS DR17 specobj

# Write query statement (sql)
query = ("""
  SELECT L.ra, L.dec, L.type, L.sersic, L.g_r, L.r_z,
         S.z, S.ra as plug_ra, S.dec as plug_dec, S.class, S.veldisp, S.veldisperr
  FROM ls_dr10.tractor AS L
  JOIN ls_dr10.x1p5__tractor__sdss_dr17__specobj AS X ON L.ls_id=X.id1
  JOIN sdss_dr17.specobj AS S ON X.id2 = S.specobjid
  WHERE L.ra BETWEEN %s AND %s AND L.dec BETWEEN %s AND %s AND (L.ra_ivar > 0)
  LIMIT 100000
  """) % (126,131,7.,12.)  # small region

# L.ra, L.dec        = RA, Dec from Legacy Survey (LS) table
# L.type             = object type (PSF, SIMP, EXP, DEV, COMP)
# L.g_r, L.r_z       = pre-computed g-r and r-z colors from photometry
# S.z                = redshift (z) from SDSS specObj table
# S.plug_ra, dec     = RA, Dec of SDSS fiber from specObj table
# S.class            = Source class (Star, Galaxy, QSO) from SDSS
# S.veldisp, veldisp = velocity dispersion (and error) from SDSS specObj table
#
# WHERE: requirement that RA & Dec coordinates are within a rectangular region

print(query)

Because of the new "type" in LS DR10, the code needs to be changed for the plotting with the morphological types. This works well:
# Select redshift slice and per type

# DEV or early type Sersic with steep index Sersic>=3
rdev = np.where(((result['type']=='DEV')|((result['type']=='SER')&(result['sersic']>=3))) & (result['z'] >0.105) & (result['z']<0.125))
# EXP or late type Sersic with index Sersic<2
rexp = np.where(((result['type']=='EXP')|((result['type']=='SER')&(result['sersic']<2))) & (result['z'] >0.105) & (result['z']<0.125))
# Intermediate with 2<= Sersic < 3
rint = np.where(((result['type']=='SER')&(result['sersic']>=2)&(result['sersic']<3)) & (result['z'] >0.105) & (result['z']<0.125))

# plot all points in red (all redshifts)
ax2.scatter(result['plug_ra'],result['plug_dec'],s=3,color='gray',marker='o',alpha=0.25)

# overplot in objects in narrow redshift slice color-coded blue (EXP or Late type) or red (DEV or Early type)
ax2.scatter(result['plug_ra'][rexp],result['plug_dec'][rexp],s=15,color='b')         # blue = EXP or late-type Sersic
ax2.scatter(result['plug_ra'][rcomp],result['plug_dec'][rcomp],s=15,color='orange')  # orange = Intermediate
ax2.scatter(result['plug_ra'][rdev],result['plug_dec'][rdev],s=15,color='r')         # red = DEV or early-type Sersic

I tested this and it worked but let me know if you run into problems!

@stephjuneau could you please make a commit with your changes, on this branch? Easier than to have me or David add those changes.

@rnikutta & @kareninysimba : I believe I made all the changes to take care of @jacquesalice 's comments and my comments. I also updated the html version. Ready for final approval and merging!

Thank you @stephjuneau . Since we are updating this NB, I want to propose a few more (minor) edits:

Remove "finger of God effect", simply stay with "possible distortion effects" and "redshift-space distortions". Both in Summary and in the very last paragraph of the NB.
In Intro, change the wording about the 3d plot; it's not a "flat cube" based on RA, Dec, and z but we actually computed the distances, and then Cartesian coordinates X,Y,Z so that we can plot a proper cone / stencil.
"The column names and descriptions can be found from the Data Lab Query Interface or using the Table Access Protocol (TAP) service with, e.g., TOPCAT." --> We should add "and with qc.schema(), which works right here in the notebook."
In-line comment line "# number of rows from LS DR3 tractor" --> "DR10"
In-line comment line "# number of rows from SDSS specObj DR13:" --> DR17; and change code line below to use DR17 (it currently uses DR16; but tbl_stats isn't updated, so it returns 0. Propose to replace this call with print(qc.query("select count(*) from sdss_dr17.specobj")) which runs instantaneously for the small SDSS table (and it would show another way to get the row count).
The section "Sanity check: RA, Dec positions from both tables" could use a sentence or two if motivation; what is being done here?
In the text "Above, the left-hand panel shows a thin redshift slice (0.105 < z < 0.125, black symbols) among objects with redshifts from the spectroscopic SDSS DR13 sample (red symbols). " --> "SDSS DR17"
Add year (2016) to "Lang, Hogg & Mykytyn"
It seems that the cell right under the 3-panel figure that shows Elliptical, Spiral, Quasar images is hidden by default. Expand it?
Thank you!

Hi @rnikutta I just made all the new changes except that I don't see a hidden cell re: "It seems that the cell right under the 3-panel figure that shows Elliptical, Spiral, Quasar images is hidden by default. Expand it?". I just made a new HTML as well. Will push these new commits now.

Done! By the way, I saved the HTML without the 3D plot to make it smaller but saving it with the rendered 3D plot is actually interactive as HTML. Maybe in the future we could create a version of the interactive 3D plot for the website for extra funsies :-)

Many thanks @stephjuneau ! Yep I don't see the hidden cell anymore either, must have been my butterfingers or something. Merging!


'flutter create [appname]' default template creating outdated dev dependencies, flutter_lints 3.0.1 instead of 2.0.3

Steps to reproduce
The solution is
'flutter create fooapp'   'cd fooapp'
'flutter pub outdated'
'flutter pub upgrade --major-versions'
I'm not sure this is a versioning bug or nothing of importance and deliberately left with a lower flutter_lints.
Where is there a current list of exactly what whould be created with a new app using 'flutter create'?
The current release notes indicate lints should be ^3.0
packages/flutter_tools/templates/app/pubspec.yaml.tmpl
https://github.com/flutter/flutter/blob/2216a78095fcd6f9914dcbf895b6ca891cbb83a4/packages/flutter_tools/templates/app/pubspec.yaml.tmpl#L17
packages/flutter_tools/templates/app/pubspec.yaml.tmpl
[release notes]
flutter create [app name] has to be followed by 'flutter pub upgrade --major-versions' in order to update THE template dependencies.

flutter_lints 3.0.1 (was 2.0.3)
lints 3.0.0 (was 2.1.1)

Expected results
Expectd no need for any dev dependencies when creating a new app.
Actual results
PS C:\Users\Documents\flutterpad\bumblebee> flutter pub get
Resolving dependencies...
flutter_lints 2.0.3 (3.0.1 available)
lints 2.1.1 (3.0.0 available)
matcher 0.12.16 (0.12.16+1 available)
material_color_utilities 0.5.0 (0.8.0 available)
meta 1.10.0 (1.11.0 available)
path 1.8.3 (1.9.0 available)
test_api 0.6.1 (0.7.0 available)
web 0.3.0 (0.4.0 available)
Got dependencies!
8 packages have newer versions incompatible with dependency constraints.
Try flutter pub outdated for more information.
PS C:\Users\Documents\flutterpad\bumblebee> flutter pub outdated
Showing outdated packages.
[*] indicates versions that are not the latest available.
Package Name   Current  Upgradable  Resolvable  Latest
direct dependencies: all up-to-date.
dev_dependencies:
flutter_lints  *2.0.3   *2.0.3      3.0.1       3.0.1
1 dependency is constrained to a version that is older than a resolvable version.
To update it, edit pubspec.yaml, or run flutter pub upgrade --major-versions.
PS C:\Users\Documents\flutterpad\bumblebee> flutter pub upgrade --major-versions
Resolving dependencies...

flutter_lints 3.0.1 (was 2.0.3)
lints 3.0.0 (was 2.1.1)
matcher 0.12.16 (0.12.16+1 available)
material_color_utilities 0.5.0 (0.8.0 available)
meta 1.10.0 (1.11.0 available)
path 1.8.3 (1.9.0 available)
test_api 0.6.1 (0.7.0 available)
web 0.3.0 (0.4.0 available)
Changed 2 dependencies!
6 packages have newer versions incompatible with dependency constraints.
Try flutter pub outdated for more information.

Changed 1 constraint in pubspec.yaml:
flutter_lints: ^2.0.0 -> ^3.0.1
Code sample
Code sample
[flutter create fooapp   cd fooapp
flutter pub outdated
flutter pub upgrade --major-versions]

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[
PS C:\Users\\Documents\flutterpad\bumblebee> flutter pub get
Resolving dependencies...
  flutter_lints 2.0.3 (3.0.1 available)
  lints 2.1.1 (3.0.0 available)
  matcher 0.12.16 (0.12.16+1 available)
  material_color_utilities 0.5.0 (0.8.0 available)
  meta 1.10.0 (1.11.0 available)
  path 1.8.3 (1.9.0 available)
  test_api 0.6.1 (0.7.0 available)
  web 0.3.0 (0.4.0 available)
Got dependencies!
8 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
PS C:\Users\\Documents\flutterpad\bumblebee> flutter pub outdated
Showing outdated packages.
[*] indicates versions that are not the latest available.

Package Name   Current  Upgradable  Resolvable  Latest

direct dependencies: all up-to-date.

dev_dependencies:
flutter_lints  *2.0.3   *2.0.3      3.0.1       3.0.1

1 dependency is constrained to a version that is older than a resolvable version.
To update it, edit pubspec.yaml, or run `flutter pub upgrade --major-versions`.
PS C:\Users\\Documents\flutterpad\bumblebee> flutter pub upgrade --major-versions
Resolving dependencies...
> flutter_lints 3.0.1 (was 2.0.3)
> lints 3.0.0 (was 2.1.1)
  matcher 0.12.16 (0.12.16+1 available)
  material_color_utilities 0.5.0 (0.8.0 available)
  meta 1.10.0 (1.11.0 available)
  path 1.8.3 (1.9.0 available)
  test_api 0.6.1 (0.7.0 available)
  web 0.3.0 (0.4.0 available)
Changed 2 dependencies!
6 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.

Changed 1 constraint in pubspec.yaml:
  flutter_lints: ^2.0.0 -> ^3.0.1

]

Flutter Doctor output
Doctor output
[ flutter doctor -v
[√] Flutter (Channel stable, 3.16.6, on Microsoft Windows [Version 10.0.22621.3007], locale en-IE)
    • Flutter version 3.16.6 on channel stable at C:\Users\\Documents\GitHub\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 46787ee49c (2 days ago), 2024-01-09 14:36:07 -0800
    • Engine revision 3f3e560236
    • Dart version 3.2.3
    • DevTools version 2.28.4

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\adam\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.2)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.8.34322.80
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.85.1)
    • VS Code at C:\Users\adam\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.80.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.3007]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 120.0.6099.217
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 119.0.2151.97

[√] Network resources
    • All expected network resources are available.

• No issues found!
PS C:\Users\\Documents\GitHub\gosync>]

Thanks for the report @lubi888
I observed that the reported behavior occurs on stable as below:
dev_dependencies:
  flutter_test:
    sdk: flutter

  # The "flutter_lints" package below contains a set of recommended lints to
  # encourage good coding practices. The lint set provided by the package is
  # activated in the `analysis_options.yaml` file located at the root of your
  # package. See that file for information about deactivating specific lint
  # rules and activating additional ones.
  flutter_lints: ^2.0.0

But on latest master, it works as expected, as shown below:
dev_dependencies:
  flutter_test:
    sdk: flutter

  # The "flutter_lints" package below contains a set of recommended lints to
  # encourage good coding practices. The lint set provided by the package is
  # activated in the `analysis_options.yaml` file located at the root of your
  # package. See that file for information about deactivating specific lint
  # rules and activating additional ones.
  flutter_lints: ^3.0.0

Since it works as expected on master, per our triage policy, will close this as fixed. The fix should be available in next stable release.


Check daily build

daily build is not creating android and debian. please check

This is resolved in ci.


Reference Area

Hi
I am trying to do some reference area on graph (bar and scatter)
I want to know if its possible to do it or if it's something easy to do with a fork of the lib.

Could you clarify on:

do some reference area

I'm not sure what you mean by that, do you mean highlight or emphasize a portion of the chart?

Yeah I want to highlight a portion of the chart with a rectangle for example.

An example of what i am trying to do

This is something that is more related to chart.js itself, and has been probably done with plugins.
I found potentially something for you here: chartjs-plugin-annotation

Thanks, that's was what i was looking for.


Set http.NoBody if contentLength is 0

We've experienced a production bug using minio-go with minio:latest server and go version go1.8.3 linux/amd64.
A valid call to PutObject with a zero-length reader argument...
reader := bytes.NewReader(make([]byte, 0))
contentType := "application/octet-stream"
_, err = minioClient.PutObject(bucketName, objectName, reader, contentType)

...caused a server error:
You must provide the Content-Length HTTP header

We managed to pinpoint the problem to a go update (1.7 -> 1.8.3) we've done recently - it seems that an empty body is now treated differently by net/http. Check this issue: https://github.com/golang/go/issues/20257.
This is a fix that works for our use case, but I am not sure about backwards compatibility with older Go versions. I'd also be happy to add unit tests for it, but I might need some guidance on that.

Thanks @grodowski for this PR.

I am not sure about backwards compatibility with older Go versions
Yeah, this change will break support of go 1.7.x. http.NoBody is known only in go 1.8

I'd also be happy to add unit tests for it, but I might need some guidance on that.
We already test putting zero size objects. We don't have to add any new tests.

Overall, I think that we need to see if we are obliged to move go 1.8 from. We can require 1.8 starting from the next release.

It seems that http.NoBody which is not present in go < 1.8 could be replaced with nil. That should solve backwards compatibility 🎉
From net/http GoDoc

NoBody is an io.ReadCloser with no bytes. Read always returns EOF and Close always returns nil. It can be used in an outgoing client request to explicitly signal that a request has zero bytes. An alternative, however, is to simply set Request.Body to nil.

@harshavardhana, using >= as suggested in the comment still breaks my test case (https://gist.github.com/grodowski/41a0c4f4db6ad18718e5725f655389b6), because contentLength is actually 0 and contentBody is an empty tmpfile rather than nil. What do you think?

This fix is good. Will test it with GCS.

@harshavardhana I have applied your patch and unfortunately my test program still fails.
if metadata.contentLength == 0 {
	req.Body = noBody{} // it works if only I changed `noBody{}` back to `http.NoBody` 🤔
} else {
	req.Body = ioutil.NopCloser(metadata.contentBody)
}

The problem could be that net/http performs explicit comparisons with == http.NoBody (a var) somewhere under the hood, maybe.
Meanwhile I've discovered how to run functional tests against a local minio instance, which is great.
SERVER_ENDPOINT="localhost:9000" ACCESS_KEY="bacon" SECRET_KEY="bacon123" ENABLE_HTTPS=false go test -race ./...

And I can see that the problem can in fact be reproduced using these tests. This run used go1.8.3 and minio:latest after applying the patch.
...
...
	api_functional_v4_test.go:728: Error: PutObject shouldn't fail. You must provide the Content-Length HTTP header.
	api_functional_v4_test.go:728: Error: PutObject shouldn't fail. You must provide the Content-Length HTTP header.
	api_functional_v4_test.go:728: Error: PutObject shouldn't fail. You must provide the Content-Length HTTP header.
--- FAIL: TestPutObjectUploadSeekedObject (0.04s)
	api_functional_v4_test.go:2372: Error: You must provide the Content-Length HTTP header.

If I change api.go to my previous version:
if metadata.contentLength == 0 {
		req.Body = nil // or http.NoBody
} else {
	req.Body = ioutil.NopCloser(metadata.contentBody)
}

There's a nil pointer panic in pkg/s3signer/request-signature-streaming.go:251, which is probably the error you meant earlier.

if metadata.contentLength == 0 {
req.Body = nil // or http.NoBody
} else {
req.Body = ioutil.NopCloser(metadata.contentBody)
}

What if you do
req.Body = ioutil.NopCloser(bytes.NewReader(""))

Then we're back to api_functional_v4_test.go:728: Error: PutObject shouldn't fail. You must provide the Content-Length HTTP header.

Then we're back to api_functional_v4_test.go:728: Error: PutObject shouldn't fail. You must provide the Content-Length HTTP header.

There is a fix but its not clean. @grodowski testing right now.

Try this
$ git diff
diff --git a/api.go b/api.go
index f68a2aa..67b8b51 100644
--- a/api.go
+++ b/api.go
@@ -616,17 +616,8 @@ func (c Client) newRequest(method string, metadata requestMetadata) (req *http.R
                return nil, err
        }

-       // Go net/http notoriously closes the request body.
-       // - The request Body, if non-nil, will be closed by the underlying Transport, even on errors.
-       // This can cause underlying *os.File seekers to fail, avoid that
-       // by making sure to wrap the closer as a nop.
-       var body io.ReadCloser
-       if metadata.contentBody != nil && metadata.contentLength > 0 {
-               body = ioutil.NopCloser(metadata.contentBody)
-       }
-
        // Initialize a new HTTP request for the method.
-       req, err = http.NewRequest(method, targetURL.String(), body)
+       req, err = http.NewRequest(method, targetURL.String(), nil)
        if err != nil {
                return nil, err
        }
@@ -678,6 +669,16 @@ func (c Client) newRequest(method string, metadata requestMetadata) (req *http.R
                req.Header.Set(k, v[0])
        }

+       // Go net/http notoriously closes the request body.
+       // - The request Body, if non-nil, will be closed by the underlying Transport, even on errors.
+       // This can cause underlying *os.File seekers to fail, avoid that
+       // by making sure to wrap the closer as a nop.
+       if metadata.contentLength == 0 {
+               req.Body = nil
+       } else {
+               req.Body = ioutil.NopCloser(metadata.contentBody)
+       }
+
        // Set incoming content-length.
        req.ContentLength = metadata.contentLength
        if req.ContentLength <= -1 {
diff --git a/pkg/s3signer/request-signature-streaming.go b/pkg/s3signer/request-signature-streaming.go
index c2f0bae..04b29a8 100644
--- a/pkg/s3signer/request-signature-streaming.go
+++ b/pkg/s3signer/request-signature-streaming.go
@@ -205,6 +205,10 @@ func StreamingSignV4(req *http.Request, accessKeyID, secretAccessKey, sessionTok
        // Set headers needed for streaming signature.
        prepareStreamingRequest(req, sessionToken, dataLen, reqTime)

+       if req.Body == nil {
+               req.Body = ioutil.NopCloser(bytes.NewReader([]byte("")))
+       }
+
        stReader := &StreamingReader{
                baseReadCloser:  req.Body,
                accessKeyID:     accessKeyID,

That fixes the panic indeed, but all req.Body lengths still fail with a signature mismatch. I can look into it soon.

@grodowski that is not because of this fix. There was bug in previous release and Minio master is already  fixed.
Remove the TODO.


Create test workspace with ember app

yarn init a new package with workspaces
ember new a project into the base package workspace dir
create test scenario

Thanks for adding this, @ckundo. Does this include the actual changes necessary to make the workspaces configurations work? Or was this just adding the apps, and we'll add the implementation after?

@scalvert sure thing, this only adds tests for additional workspaces coverage. no implementation yet.


Need advice, Immutable toJS() performa with Redux + Reselect + Saga

what I do is create a custom intregation nextjs with immutable, redux, saga, and reselect.
all I need is advice how to use immutableJS properly.
because after I find out, maybe immutable toJS requires 'enormous energy' to render.
but anyway, toJS I really need on selector files, because this is very easy for me in splitting data
I'm also looking into how to make toJS work inside the HOC groove
https://github.com/zalabinc/nextjs-boilerpate/blob/master/app/containers/HomePage/selectors.js
https://github.com/zalabinc/nextjs-boilerpate/blob/master/app/utils/configureStore.js
https://redux.js.org/docs/recipes/UsingImmutableJS.html

That is redux/immutableJs issue/question, it's not related to next.js anyhow. Not trying to be a dick, just want to help maintain issues related to next.js ;). gl


Move compositions under experiments folder and add github actions

Move compositions under experiments folder and add github actions.
The naming stutters a bit, but lets revisit it later on.
Also Fixes:

#13
#15

Follow up Issues:

https://github.com/cloud-native-compositions/compositions/issues/11
https://github.com/cloud-native-compositions/compositions/issues/12

Good suggestion. I would probably stick with experiments while we hash things out some more. At some time in the future (may be Q1 next year) we can create a proposal folder and decide what all we want to move under there.


Machines stuck in provisioning/pending - "failed to patch byohost"

What steps did you take and what happened:
When trying to provision a cluster the machines are stuck on pending/provisioning:
Machines stuck in provisioning/pending:
NAME                                CLUSTER        NODENAME   PROVIDERID   PHASE          AGE   VERSION
byoh-cluster-md-0-95bc9d7b8-vmwtq   byoh-cluster                           Pending        38s   v1.24.2
byoh-cluster-control-plane-cjkfl    byoh-cluster                           Provisioning   8s    v1.24.2

Logs from the capi-controller-manager:
capi-controller-manager-6dd97f9f7f-t5q8x manager I1122 08:45:36.011108       1 machine_controller_phases.go:286] "Infrastructure provider is not ready, requeuing" controller="machine" controllerGroup="cluster.x-k8s.io" controllerKind="Machine" machine="capi-byoh/byoh-cluster-control-plane-94xvl" namespace="capi-byoh" name="byoh-cluster-control-plane-94xvl" reconcileID=89b42a50-169b-4c95-a740-f303cb40044d cluster="byoh-cluster"
capi-controller-manager-6dd97f9f7f-t5q8x manager I1122 08:45:36.011138       1 machine_controller_noderef.go:49] "Cannot reconcile Machine's Node, no valid ProviderID yet" controller="machine" controllerGroup="cluster.x-k8s.io" controllerKind="Machine" name="byoh-cluster-control-plane-94xvl" reconcileID=89b42a50-169b-4c95-a740-f303cb40044d machine="byoh-cluster-control-plane-94xvl" namespace="capi-byoh" cluster="byoh-cluster"```

Logs from the byoh-controller-manager:

```byoh-controller-manager-6774fcb76d-2jpcm manager I1122 08:25:41.286814       1 byomachine_controller.go:270] controller/byomachine "msg"="Attempting host reservation" "cluster"="byoh-cluster" "name"="byoh-cluster-control-plane-lh8p4" "namespace"="capi-byoh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="ByoMachine"
byoh-controller-manager-6774fcb76d-2jpcm manager E1122 08:25:41.296151       1 byomachine_controller.go:562] controller/byomachine "msg"="failed to patch byohost" "error"="admission webhook \"vbyohost.kb.io\" denied the request: system:serviceaccount:capi-byoh:byoh-controller-manager cannot create/update resource <BYOH HOSTNAME>" "cluster"="byoh-cluster" "name"="byoh-cluster-control-plane-lh8p4" "namespace"="capi-byoh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="ByoMachine"
byoh-controller-manager-6774fcb76d-2jpcm manager E1122 08:25:41.296505       1 controller.go:317] controller/byomachine "msg"="Reconciler error" "error"="admission webhook \"vbyohost.kb.io\" denied the request: system:serviceaccount:capi-byoh:byoh-controller-manager cannot create/update resource <BYOH HOSTNAME>" "name"="byoh-cluster-control-plane-lh8p4" "namespace"="capi-byoh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="ByoMachine"

Status from the byohost:
Status:
  Conditions:
    Last Transition Time:  2022-11-22T08:25:35Z
    Reason:                BootstrapDataSecretUnavailable
    Severity:              Info
    Status:                False
    Type:                  K8sNodeBootstrapSucceeded

Some matching logs from the host agent:
I1122 09:25:36.011108   18382 host_reconciler.go:50] controller/byohost "msg"="Reconcile request received" "name"="compute3.kaas.aknostic.net" "namespace"="capi-byoh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="ByoHost"
I1122 09:25:36.014552   18382 host_reconciler.go:89] controller/byohost "msg"="reconcile normal" "ByoHost"="compute3.kaas.aknostic.net" "name"="compute3.kaas.aknostic.net" "namespace"="capi-byoh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="ByoHost"
I1122 09:25:36.014592   18382 host_reconciler.go:97] controller/byohost "msg"="BootstrapDataSecret not ready" "ByoHost"="compute3.kaas.aknostic.net" "name"="compute3.kaas.aknostic.net" "namespace"="capi-byoh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="ByoHost"

A diff between the yaml output of the clusterrole for byoh-manager sa and the role.yaml does not turn up anything, so that seems to be in order
All other byo hosts display identical behaviour.
What did you expect to happen:
Machines should finish provisioning
Environment:

Cluster-api: 1.2.6
Cluster-api-provider-bringyourownhost version: 0.3.1
Kubernetes version: v1.24.3+k3s1
OS (e.g. from /etc/os-release): Ubuntu 20.04.5 LTS

Any help or hints would be appreciated :)
Thanks!

Hi @maartenkamoen, Thanks for the detailed info added to the issue.

denied the request: system:serviceaccount:capi-byoh:byoh-controller-manager

The controller deployment should be in byoh-system, but from the above log statement it seems like its in another namespace i.e. capi-byoh. Have you updated the namespace for infra components?

Hi @dharmjit,
After moving the deployment to the byoh-system namespace everything works as expected.
Thanks for the help!
Kind regards,
Maarten


flight plan revision reset causes implausible report association on prefilings

Flight plan revisions can roll back while maintaining airport pair, member and callsign.
Prefilings are currently not checked for revision rollbacks. This leads to implausible situations after graph import where a lower revision has been seen in a later report than a higher revision. Ocassionally importer-status-postgis will fail to load data back from database as this violates constraints required for internal graph reconstruction. As the data is generally implausible and should never have been imported like that, this is a bug in graph import.
Flights are already checking such rollbacks which resulted in sometimes unnecessary splits (see #1). An attempt to add a simple check failed due to spurious splits of connected flights into tracking data and prefiled flight plans or duplicate prefilings showing up in datafiles leading to multiple recordings of identical flights (d44cf6229d398de982a9b984881806dced733cb3).
An example for implausible data is UAE858 on 3 Aug 2020: While connected, a prefiling appeared as revision 1 at 1725z and got reset to revision 0 at 1759z. Because there was no prior revision 0 seen in datafiles (might have been too short-lived or some VATSIM-side data export error), the later revision 0 was added to the same flight in front of revision 1. If that graph data is saved to DB and then reloaded, graph reconstruction fails as revisions are supposed to be strictly ascending in revision and report record time.
Introducing generations to flight plan revisions as described in #1 could solve this issue.

Flight plan revision numbers have been removed from JSON v3 format and graph import needs to be adapted to work without that information in the future (#13). That change in processing may result in this issue being solved for legacy files as well. #13 will check compatibility for old and new data files.


fix incorrect namespace for libs

@ivamax9 : Thanks for your contribution to the Azure documentation! The author, @dkkapur, has been notified to review your proposed change.

@ivamax9 : Thanks for your contribution to the Azure documentation! The author, @dkkapur, has been notified to review your proposed change.

This looks right to me - good catch! Thanks @ivamax9!
#sign-off


KAFKA-5435: Improve producer state loading after failure

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5427/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5412/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5429/
Test FAILed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5414/
Test FAILed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5417/
Test PASSed (JDK 8 and Scala 2.12).

By the way, I ran the transaction system tests here: https://jenkins.confluent.io/view/All/job/system-test-kafka-branch-builder/917/console. I'll run a few more times.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5432/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5434/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5419/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/5443/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/5428/
Test PASSed (JDK 8 and Scala 2.12).

@hachikuji : Thanks for the updated patch. LGTM. I will let you merge it.

I ran the transactions system tests last night and we're looking good: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2017-06-17--001.1497703753--hachikuji--KAFKA-5435-ALT--49205c7/report.txt. I will go ahead and merge this to trunk and  0.11.0.


transitionEnd on touchEnd not emitted

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 5.0.x

Platform/Target and Browser Versions: All

Expected Behavior
Emit transitionEnd after touchEnd event.
Actual Behavior
transitionEnd is not emitted after touchEnd event. I have some sliders with and after I stop dragging and the element slide to the correct index, no events of transition end is emitted as expected. I also tried to set preventInteractionOnTransition to check what happens and the results was that, on touchEnd, my sliders couldn't slide anymore (with keyboard, swipe, drag, mousewheel, click, etc). This because, I think, the transition event was never ended.
Before you ask, freemode is set to false.
My settings are:

fade effect in crossFade,
parallax set to true,
mousewheel true
keyboard true
speed 100 (changing the speed makes no difference)

Any help?

The issue is presenting only in fade effect

@tedc can you provide a JSFiddle or CodePen that replicates this issue?

Closing due to inactivity and/or no responses from issue author


Users/rbatra/convert subscription to lower id master

@rajatagrawal-dev to take a quick look as it impacts his APIs as well


Declaration parsing fails with single quotes

I'm running version 0.9.7. This works:
> var convert = require('xml-js');
> convert.xml2js('<?xml version="1.0" encoding="utf-8"?>')
{ declaration: { attributes: { version: '1.0', encoding: 'utf-8' } } }

But the same fails with single quotes for the attributes:
> convert.xml2js("<?xml version='1.0' encoding='utf-8'?>")
{ declaration: { attributes: { undefined: undefined } } }

I haven't found a formal reference, but from forum posts it sounds like both single or double quotes should be valid for declarations.
Thanks!

@jcushman Sorry about this limitation. This is actually coming from the underlying parser engine that I am using for this converter tool.
However, for very simple cases, you can use following code to prepare the xml input before applying this parser.
xml = xml.replace(/"/g, '\'').replace(/'/g, '"')

I think that you should put this in the "README.MD".  The only 4 little ' in my file cause the convert failure, it blocked my work for about one day...

@Stark-X it turned out that this was a problem with my library not the underlying parser. Today, another user faced the same issue and he managed to identify the reason and solved it.
The fix is now released under v1.5.2 of this library.
I am extremely sorry for overlooking this issue.

My apologies to @jcushman as well.


How would we define STDIN?

I'm poking around the kernel code, and wanted to try reading from stdin. Obviously I'm new to kernel programming, so excuse my lack of knowledge in this area. I think the next really useful piece of code would be to add some kind of STDIN and STDOUT that we could use to read and write. How would we go about creating an STDIN? Is there a way to pull keystrokes yet? Perhaps some C code we could utilize?

Hey,
thanks for your interest in our project!
What version of the kernel were you looking at?
There is the master branch and the rewrite branch.
The master branch is more advanced and comes with a simple keyboard driver.
The rewrite branch is the default one, but it's new and not very usable at the moment.
You can find the keyboard driver in the master branch here: Keyboard Driver.
The keyboard driver is pretty easy to use, and you can see it in action here: Nuumshell
However, NuummiteOS isn't really being maintained at the moment.
I started a new project called Fluorite, it's got a more stable core,
but it's still in early stages and I don't have much time to work on it.

tried the master branch. Looks like there's currently an error: Invalid memory access (signal 11) at address 0x28 when building with scons. Definitely looks promising and much more complete than what I was looking at yesterday though. Very nice!

@Silvertale uh oh, that shouldn't happen.
Maybe it breaks with one of the latest Crystal versions.
I don't remember what version we used for building, but it was probably a lot older.
Since this is happening at compilation stage, it looks like a bug with the crystal compiler, rather than a bug with our source. I have no idea what could be causing this though..


PiHole-plugin in Organizr has partially missing background due to inheritance of "bg-inverse" lately

Describe the bug
Some weeks ago, my PiHole indicator in organizr started missing the background-color for Queries Blocked, Percent Blocked and Domains on Blocklist but not for Total queries.
I might have traced it back to around this commit, where the CSS class bg-inverse has been modified: https://github.com/GilbN/theme.park/commit/fe739621da96e0b8aa21e0ecda26c7a073398c41#diff-57cd7f84a310a63392db1f3014f1fd5423e97478b3d75d62a536bc9f5b0b6277
It looks like, that the three panels in question derive their style also from bg-inverse (which sets background: transparent !important;) while the Total queries does not and thus is unaffected.
Theme Install Method

CSS include directly in Organizr, pointing to this very git-repo, locally hosted on my webserver on latest commit@master.

@import url("https://MY.TLD/themepark/css/base/organizr/organizr-base.css");
@import url("https://MY.TLD/themepark/css/theme-options/nord.css");

Application Info

Application: Organizr
Version: Latest git commit
Branch: v2-develop
Container: organizr/organizr

To Reproduce
Steps to reproduce the behavior:

Go to Settings/Tab Editor/Homepage-Elements
Click on PI-HOLE/connection
Point it to your http://<Piholeip>/admin/ page
Watch the "Homepage" of Organizr missing the panel-backgrounds

Expected behavior
Panel-Backgrounds all show properly
Screenshots
What I expect to see

What I actually see

Desktop:

OS: Manjaro Linux
Browser: Chrome, Firefox
Version: Most recent

Pushed a fix to dev. Please test develop.theme-park.dev

I can confirm, that this fixed it.


Tools: Better support for .NET Standard projects

Since .NET Standard 2.0 projects are broken (#8344), we can take this opportunity to rework how we handle .NET Standard class library projects in the tools when you don't specify a startup project.
The heart of the issue is that .NET Standard is an abstract framework and doesn't contain all of the assets necessary to execute assemblies.
One way to fix this is to, behind the scenes, make the project target .NET Core. Then after we restore and build, all of the assets we need to execute will be present.

We may be able to leverage GenerateDeps.proj which is part of the .NET Core SDK.

What is missing from a netstandard class library project that is required for EF Core?

Primarily the native libraries like sni.dll for SqlClient and sqlite3.dll for SQLite. But it's anything in the NuGet package graph that uses the bait-and-switch pattern (i.e. referencing a stub--the bait--on netstandard, but switching to a framework-specific implementation when installed into an app).

Closing this in favor of #8452.


Question: what should I use as the SEED param when running in Kubernetes?

I am working on adding Stargate to the k8ssandra project.
I have a Kubernetes service defined that proxies and load balances requests to all C* nodes. If I provide the DNS name of that service in the SEED envvar, the Stargate node does not show up in nodetool status, and I get this in the log:
21:04:51.081 [OptionalTasks:1] DEBUG org.apache.cassandra.db.SizeEstimatesRecorder - Node is not part of the ring; not recording size estimates

If I instead deploy C_, manually determine the IP address of one of my C_ pods, and then deploy Stargate using that IP for the seed, I then get:
21:29:11.853 [GossipStage:1] INFO org.apache.cassandra.gms.Gossiper - Node /<IP_ADDRESS> is now part of the cluster

But the node still doesn't appear in nodetool status, so I'm not sure if that was really the problem.
What should I do? I didn't find anything helpful in the docs.

Hi @jakerobb!
First off, stargate will not show up in nodetool status since that command is pulling members of the ring which stargate is not. Since no data is actually stored on stargate nodes themselves they do not take a portion of the token ring.
As for the SEED value, the name of the k8s service attached to C* should work, can you please provide the yaml for your service? Also, is C* already running at the time stargate is deployed?

We figured out the SEED thing -- I was providing only the namespace-local name, rather than the FQDN, for the service. With the FQDN, it works fine. Thanks!


Update pip-tools version in the README's pre-commit examples

The version mentioned there causes an error on the pre-commit, which is fixed on the current version. 👀
Contributor checklist

[ ] Provided the tests for the changes.
[ ] Assure PR title is short, clear, and good to be included in the user-oriented changelog

Maintainer checklist

[ ] Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
[ ] Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

I wonder is there any GitHub Action to update those versions after a release is published? Would be nice to keep them up-to-date.

It's not hard to build such a workflow — the GHA token let's you git push from CI


Cumulative settings in config(htmlAttributes|bodyAttributes) should merge what is set in +config with what is set using useConfig?

Now if we defined bodyAttributes: { class: 'dark' } in +config
and defined bodyAttributer: { 'data-test': 'test' } using useConfig
only the value from _configFromHook will be used.
Is this what is expected?
And if they are cumulative maybe content merge should be implemented at least for class.

:+1: Indeed getHeadSettings() should cumulate the values instead of overwriting.

What about class?

What about class?

https://github.com/vikejs/vike-vue/issues/175#issuecomment-2293516677


Display timepicker above datepicker

Maybe this isn't an issue and i just haven't figured it out:
Is it possible to, when using 'sideBySide: false,' have the picker display the time picker first, with the calendar for the date picker below it?
Thanks for this!

the date will always display first, if it's enabled. you can also use collapse: false which will display them vertically.

Thanks, and is there any way to toggle it via javascript, so that, even if the date is above the time, one could force the transition to the timepicker on loading?

I guess you could try something like .find('.picker-switch a[data-action="togglePicker"]').click() on the show event?

That worked beautifully, thanks!


[Python] ChunkedArray should fail gracefully on non-cpu devices

Describe the enhancement requested
ChunkedArray should throw Python exceptions instead of segfaults when trying to access non-cpu data from the cpu.
Component(s)
Python

Issue resolved by pull request 43795
https://github.com/apache/arrow/pull/43795


Having BatchNorm2D raises in-place operation error

I am working on a project which requires me to calculate the trace of the Hessian of standard ResNet architectures. To this end I am using the Hutchinson method, which requires me to form the Hessian vector product. I am currently using ResNet18 as implemented in torchvision. This entails BatchNorm2D operations with track_running_stats=True. If I set track_running_stats=False I can execute the following code without any problems:
import torch
from functorch import make_functional_with_buffers
from functorch import grad, jvp, vjp

criterion = torch.nn.CrossEntropyLoss()

def rademacher(shape, dtype=torch.float32, device='cuda'):
    rand = ((torch.rand(shape) < 0.5)) * 2 - 1
    return rand.to(dtype).to(device)

def loss(params, batch, fn, buffers):
    x,y = batch
    out = fn(params, buffers, x)
    loss = criterion(out,y)
    return loss

def hvp(params, batch, v, fn, buffers):
    loss_fn = lambda x: loss(x, batch, fn, buffers)
    _, vjp_fn = vjp(grad(loss_fn), params)
    return  vjp_fn(v)[0]

def hutchinson(net, x, y, iterations, device='cuda'):

    fn , params, buffers = make_functional_with_buffers(net)
    params = [p.data for p in params]

    trace = 0
    V = iterations
    for _ in range(V):
        v = [rademacher(p.shape, device=device) for p in params]
        Hv = hvp(params, (x,y), v, fn, buffers)

        for v, Hv in zip(v, Hv):
            vHv = torch.einsum("i,i->", v.flatten(), Hv.flatten())
            trace += vHv / V
    return trace

where net is my ResNet18 and  x and y are my images and labels respectively. However, if I set ```track_running_stats=True`` I get the following error:
RuntimeError: During a grad (vjp, jvp, grad, etc) transform, the function provided attempted to call in-place operation (aten::add_.Tensor) that would mutate a captured Tensor. This is not supported; please rewrite the function being transformed to explicitly accept the mutated Tensor(s) as inputs.
I have encountered the same problem when computing the NTK using the example given in the functorch documentation. Is there a quick work around to this problem?
Thanks in advance.

I can across this which explains the issue, and gives some solutions to it! https://pytorch.org/functorch/stable/batch_norm.html

Hey @AlphaBetaGamma96,  thanks for your response. Unfortunately I do need running statistics as I am using stochastic weight averaging. When using the pytorch lightning module for SWA, for example, I get an error at evaluation. If I understand correctly, the site you linked suggests to open an issue if I have a use case which requires running stats.

Thanks @AlphaBetaGamma96 for linking to that, that's the right link for this. I wanted the error message to link to be more insightful and link to that so I'll investigate why it's not coming up
@MaxH1996 thanks for this issue and for clarifying that you do need running states. I'm not very familiar with the Hutchinson method, so would you mind helping me clarify: Do you need the running stats to update while you're computing the hvp? Or if the intention that you would train the model and then use the stats computed during that to compute the hvp?

@samdow  Essentially what @AlphaBetaGamma96 has posted about the Hutchinson method is what I am using. During training  I compute the trace of the Hessian every n-th step and then do some further calculations. At the same time I am also using stochastic weight averaging (SWA) which (at least in the PyTorch-Lightning implementation) requires running stats. So really this is where my issue comes from.
@AlphaBetaGamma96 I am not all too familiar with the source code of BatchNorm2D, I could do that, but I was maybe hoping for something I could change on the functorch-side of the implementation. But this could work if nothing else does.

@MaxH1996 Neither am I, although I did have a quick look ( source here ) at it and there are indeed some in-place operations (I'm not sure if that's need by design) but perhaps an out-of-place equivalent might be easy to make?

Hi @MaxH1996. Not sure if you still need a solution for it, but the only in-place operation that you need to change for BatchNorm2D (in torch/nn/modules/batchnorm.py) is self.num_batches_tracked.add_(1) . Simply replacing it with self.num_batches_tracked = self.num_batches_tracked + 1 fixed the issue in ResNets for me.


[Bug] Unable to start workspace: incorrect launch contraint specified

Describe the bug
When I start a RStudio workplace, I got an error message "The portfolio port-nvfd7zqe2losg has incorrect launch constraint specified. Make sure a local role name is specified as launch constraint for the portfolio."
To Reproduce
Steps to reproduce the behavior:

Subscribe to RStudio
Add Rstudio to service portfolio
Create a constraint for EC2-Rstudio-Server using the default dev-va-sw-LaunchConstraint
Import workspace type,  create a configuration
create a workspace

Expected behavior
The workspace should be created
Screenshots

Versions (please complete the following information):

Release Version installed : beta (5.2.7)
Is the deployment from a forked version of the repository? no

Additional context

I created another role following the instruction here but the problem persisted.
I am not sure what is a "local role". However, the description of the constraints for other products are "Launch as local role ....", but is "Lauch as arn::" for Rstudio (see the screenshot above). There is however no option to choose a "locel" role during the creation of the constraint.
The "SubnetID", "SecurityGroup" and "Architectures" might be incorrect for the Rstudio configuration.

What worked for me was selecting "enter role name" when creating the constraint and writing the name of the role

This is beyond weird but the error message disappeares after I remove and reenter the constraint!
Now I am getting another error:

It looks like my configuration is problematic but the error message is not helpful in telling me which one was wrong. I did have all fields filled so none of the fields should be undefined.

@BoPeng hey, sorry you're having issues with this. Do you have more information about your configuration that you could share with us so we can try to reproduce?

Thanks @aws-tyler , here is my configuration:

I do not know what subnet id I should specify,

so I used the one for initial-stack

I saw a number of security groups associated with vpc-00a6f1abaaf2f3684 and do not know which one to supply either.
Anyway, the error message does not point to which part of the configuration is wrong, or if it is a problem with the configuration.

Close because the original issue has been fixed.


feat: introduce convinient commands for GpChatNewVertical, GpChatNewHorizontal, GpChatNewTab

my main workflow currently is, that i select some code, and then run <c-g>c for GpChatNew.
after that i often go back to the original code with buffer last for having the information to explain chatgpt what i want to do.
it would be nice to have GpNewVertical, GpNewTab, GpNewHorizontal commands to be able to map <c-g>v, <c-g>x, <c-g>t in visual mode, so that i could open the original code buffer and the chat side by side to avoid switching back and forth between the two buffers.
i know, that i could do it somehow by myself, i did it it normal and insert mode like this
vim.keymap.set({"n", "i"}, "<C-g>x", "<cmd>split|GpChatNew<cr>",            keymapOptions("create x"))
vim.keymap.set({"n", "i"}, "<C-g>n", "<cmd>GpChatNew<cr>",                  keymapOptions("create"))
vim.keymap.set({"n", "i"}, "<C-g>t", "<cmd>tabnew|GpChatNew<cr>",           keymapOptions("create t"))
vim.keymap.set({"n", "i"}, "<C-g>v", "<cmd>vsplit|GpChatNew<cr>",           keymapOptions("create v"))

but i think in visual mode it is a little more complicated because i need to keep the selection?
these would be convinient commands to be able to get up and running faster for me and save a lot of time in my daily workflow.
thx again, i am so happy with that plugin!

@divramod thats already implemented as part of solution for #46 =>
vim.keymap.set({"n", "i"}, "<C-g><C-x>", "<cmd>GpChatNew split<cr>", keymapOptions("New Chat split"))
vim.keymap.set("v", "<C-g><C-x>", ":<C-u>'<,'>GpChatNew split<cr>", keymapOptions("Visual Chat New split"))

supported sub commands are:

I just have to update the documentation and tag new release (once I also do #48)

:heavy_check_mark: in the latest version

you are awesome! i think i might go on 🤣

i think i might go on 🤣

@divramod feat/fix ideas are always welcome :slightly_smiling_face:


replace environment vars with config file

I need to add logging here and do a bit more testing, but I think this isn't too bad. Any early feedback would be appreciated.

I believe the latest round of comments have been addressed.


Lazy InstanceWrapper  can't provide thread safety

Yesterday I faced some crash in 302:Container.swift:
        guard let currentObjectGraph = currentObjectGraph else {
            fatalError("If accessing container from multiple threads, make sure to use a synchronized resolver.")
        }

In my case, I lazily resolve dependencies, and judging by the stack trace, Lazy<Service> appeared in all the crashes.
After a while, I seem to have found the problem.
Problem
Imagine we register some dependency with a Lazy<Service> argument in init:
container.register(Person.self) { r in PetOwner(pet: r.resolve(Lazy<Animal>.self)!) }
Sometime later we resolve Person instance by using SynchronizedResolver under the hood which is looks absolutely thread safe:
let person = container.synchronize().resolve(Person.self)!
After a while, we decide to use the instance:
let name = pet.instance.name
The stacktrace shows that the next step is to fall into the resolveAsWrapper method's closure factory:
if let entry = getEntry(for: key) {
       let factory = { [weak self] in self?.resolve(entry: entry, invoker: invoker) as Any? }
       return wrapper.init(inContainer: self, withInstanceFactory: factory) as? Wrapper
} else { /**/ }

The problem is that
self?.resolve(entry: entry, invoker: invoker) as Any?
Never executed in a thread-safety way (self.resolve is not SynchronizedResolver method)
It seems to me that because of this, we can get a crash when trying to resolve a dependency from different threads at the same time (And this is probably the reason for my series of crashes).
Please correct me if my thoughts are not correct.
Possible solution
Rewrite a part of resolveAsWrapper method:
        if let entry = getEntry(for: key) {
            let factory = { [weak self] in
                self?.lock.sync { // provide thread-safety
                    self?.resolve(entry: entry, invoker: invoker) as Any?
                }
            }

            return wrapper.init(inContainer: self, withInstanceFactory: factory) as? Wrapper
        } else {
            return wrapper.init(inContainer: self, withInstanceFactory: nil) as? Wrapper
        }

I don't know how correct this is within such a large library, and how much it will affect the overall performance, but it should fix the multithreaded environment issue.

This is still an issue. Our workaround currently is to resolve everything on the same thread, which is less than ideal.
Would it be possible to change the SynchronizedResolver from a wrapper class to a property of the Container ? Then one could instantiate or set that property, so that when the Wrapper resolves it could still enforce using the locks.

I think this is fixed in the latest release if you want to try @danya61 @chosa91

Then is this issue resolved?


fix(create-frames): move eslint config to cjs, fix eslint errors, use minor versions of nextjs

Change Summary
This PR:

fixes eslint configurations by moving them to cjs
fixes eslint errors
changes allowed next version to accept minor upgrades (templates now work again since<EMAIL_ADDRESS>has been released)

Merge Checklist

[x] PR has a Changeset
[x] PR includes documentation if necessary
[x] PR updates the boilerplates if necessary

@stephancill I was also thinking of upgrading next in debugger to 14.2.3 but in case of debugger the build fails on metadata collection from /hub/v1/validateMessage not sure why this happens, so I decided to keep the debugger untouched for now.


Upgrade Shibboleth to version 4.1.5

The Shibboleth Project has released V4.1.5 of the Identity Provider software [1], a patch release to address some outstanding library vulnerabilities of no particular impact to the project and to update the logging libraries to pull in a somewhat hardened version released by the logback developer.
The release notes [2] provide some additional detail. Notably, a couple of more advanced features were removed from the logging library in the interest of limiting future vulnerabilities, and while we don't ship any examples of their use or expect most have used them, it is a change.

Thanks @trsau. We'll start upgrading to ShibV4.1.5 soon.

Also upgrade Jetty to version 9.4.44.v20210927

And upgrade the following libraries to latest stable...

@trsau Jetty 9.4.45 is now available  https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-distribution/9.4.45.v20220203


No feed is displaying

Great idea, unfortunately when I add the widget to my dashboard nothing is displayed. I just see a large blank white tile.
There's no ability to configure, so I'm assuming I can't be doing anything wrong?

Hi Pat - you are right, there's no configuration, so you're not doing anything wrong. I've not had any similar issues raised, so it's possible your browser or network may be preventing the widget content (which is actually loaded in an iframe) loading properly.  I'd suggest trying in a different browser, trying on a different machine and checking your browser dev tools if that reveals anything. There's also other VSTS extensions that do similar things (search for the keyword "iframe" in the market place) so it would be worth seeing if they suffer the same issue.
Will leave issue open for now pending any feedback you can supply, as I can potentially supply a stand-alone version of the app to see if that works / fails if the above suggestions don't cure the problem.

Hi Greg, I encounter the same problem. I'm using on premise TFS over HTTP. Can this be the problem?

Hi Gabor, that might be the cause. Can you load the widget with the F12 developer tools open in your browser and see if there are any errors in the console tab or network errors in the network tab? Thanks, Greg

Hi Greg, I don't see any errors in the dev console.

Hi Gabor, are there any failures in the browser network tab? Also, can you reach twitter directly in your browser independently of the widget?
Greg


Animation bug

Person's animation doesn't take into account any objects, that are in front of him, and they just walk over them. They must know where an object is and try to avoid it.

used PathFinding.js Library


Course ECP Command

Sick of closing Discord for 30 seconds to search for the course code? Great news that is no more! With the new /courseecp command, you can request the ECPs for up to four courses for a semester, year, mode, and campus. It assumes the courses are offered in the same semester and that they all are the same mode of delivery and campus. If semester, year, mode and campus are not provided, it defaults to the current semester and year.
Further development of this command could be removing those assumptions and making it more complex for what it takes as inputs.

Changes as requested made, no clue what to do with Black though

@andrewj-brown or @49Indium Black has been sorted, thank ya'll


Problem in API users getting started

There is something wrong in the API users getting started guide, see screenshot:

Please fix

This should be implemented.

looks good thanks


:bug: Fix: eth_estimateGas

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

#1430  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @roninjin10 and the rest of your teammates on  Graphite


404 on GitHub link

this link returns a 404: https://github.com/azure-ad-b2c/apps/tree/master/spa/javascript-hellojs-singlepageapp-popup

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fa063fd-3b2d-e00d-c382-9ca749254616
Version Independent ID: 217e50e6-f9ed-d4ad-1d6a-04fbc87aaa4b
Content: Single-page sign in using implicit flow - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-reference-spa.md
Service: active-directory
Sub-service: b2c
GitHub Login: @mmacy
Microsoft Alias: marsma

@dhdiez Thank you for your feedback! We will review and update as appropriate.

@dhdiez Thank you for pointing it out and we apologize for the minor error.   We have made the changes and pointed to the correct code path on GitHub . the changes will be piublished in teh next release cycle within the next 24-48 hours. Here is the link for your consumption in case you needed it earlier than the page update. https://github.com/Azure-Samples/active-directory-b2c-javascript-hellojs-singlepageapp
We will be closing this issue now . In case you have any further query , feel free to tag me or the doc author @mmacy to your reply and we will be happy to help.
Thank you.


Message #32 - Plotting

The application of the square symbol to an arrow-enclosed sequence of plot commands results in an image being displayed.
Line 1: do nothing (plot command list is empty)
Line 2: the plot command takes two arguments. When these arguments are both 1, display a single dot one pixel in (in both directions) from the top left of the screen.
Line 3: the last argument describes vertical displacement. When the first argument is 1, and the second argument is 2, display a single dot two pixels down and one across from the top left of the screen.
Line 4: demonstrates a pixel at (2 across, 5 down)
Line 5: multiple plotting commands are separated by a bar. This puts one pixel at (1, 2) and one at (3, 1)
Line 6: this is a plotting command sequence that displays five pixels in a shape representing the grid number 2.

That's not exactly multiple commands separated by a bar. It's just a list of points. But I get the general idea, thanks!


Feat/crud collections

#90 No server actions yet and media datalib and route seems redundant

For the future, split up your work. If you made one PR for just the _datalib/.../createMediaItem.ts file only, it's fine. Don't put it all into one huge PR cuz it's more work to change for you and if you mess up once, you won't be corrected until you've already propagated the error to the rest of the code.
Also, you did media and collection datalib in the same PR. This easily could've been split up. Also make sure to test your code before you put up a PR. From my quick look through the code, I know it won't work.


Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

Im getting the following error when trying to lazy load a module

Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

I was trying to import angular2-json-schema-form on a sub module

Blocker for me as well. Let me know how I can help.

This was fixed for me by #58 , what version are you using


Deny information outside of its knowledge base

Hello! Please help me, how can I restrict the bot from using information outside of its knowledge base? For example, I have information on the topic of computers, but I don’t want the bot to be asked for a recipe for lasagna, so that it won’t answer these questions.

Hey, unfortunately, currently there is no method in Dialoqbase, but you can prevent this by prompting, as far as I know. Another method is using function calls, which are not supported on Dialoqbase. Many applications face this issue, as far as I know. :(

What do you think about add this to system promt? Its not working to me...
What am I doing wrong?
 Use the following pieces of context to answer the question at the end. If you don't know the answer, just say you don't know. DO NOT try to make up an answer. use only information from local sources. If the question is not related to the context, politely respond that you are tuned to only answer questions that are related to the context.

Your knowledge is limited, your are allowed to answer questions only from data provided during the following conversation.
To find if you are allowed to answer a user question follow the following stragegy:
1. If the information is contained in the conversation, answer it.
2. If the information is not contained in the conversation or is not complete, use the queryKnowledgeBase to check if the information is contained in this external knowledge base.
3. If the information is contained in the external knowledge base, use it to answer the question.
4. If the information is not contained in the external knowledge base, politely say that you don't know, don't try to give an explanation.
5. Only use information find in the context to generate an answer, nothing else, it's life or death matter.

{context}  Question: {question} Helpful answer in markdown:

Try this prompt; it may be helpful
You are a helpful AI assistant. Use the following pieces of context to answer the question at the end. If you don't know the answer, just say you don't know. DO NOT try to make up an answer. use only information from local sources. If the question is not related to the context, politely respond that you are tuned to only answer questions that are related to the context.

Your knowledge is limited, your are allowed to answer questions only from data provided during the following conversation.
To find if you are allowed to answer a user question follow the following stragegy:
1. If the information is contained in the conversation, answer it.
2. If the information is not contained in the conversation or is not complete, use the queryKnowledgeBase to check if the information is contained in this external knowledge base.
3. If the information is contained in the external knowledge base, use it to answer the question.
4. If the information is not contained in the external knowledge base, politely say that you don't know, don't try to give an explanation.
5. Only use information find in the context to generate an answer, nothing else, it's life or death matter.
6. Remember not to break character and only reply from context
7. Don't reply out of character

{context}  Question: {question} Helpful answer in markdown:

You are a genius! Thank you! This really helped!

Closing this issue. If you have any doubts or issues, feel free to reopen or create a new one. :)


tsscan: Display modulation parameters for ISDB-T broadcasts.

Related issue (if any):
The issue related with incorrect transmission parameters with some ISDB-T tuners (last posts on #24)
Affected components:
tsscan and libtsduck/dtv/tsModulationArgs.cpp
Brief description of the proposed changes:
This series of commits provide a fix for the invalid modulation parameters with some ISDB-T tuners.
Basically this solution:

Uses TSScanner to retrieve the modulation parameters that should be displayed.
Inside TSScanner, do the tuning parameters query as late as possible to give the device some time to update its internal status.
Corrects the enumeration used for displaying per-layer constellation types.
Checks the validity of some parameters before showing them.
Fixes some typos with the displayed data.

Hi @nicst35,
Thanks for your contribution on ISDB-T (including fixing a couple of silly mistakes of mine).
I have added a more formal check of the parameters. I was especially doubtful about the check != 255 on time interleaving values. The value 255 looked too specific to a given driver to be individually checked. It replaced this with a check of all possible documented values.
Could you please check that I didn't accidentally break something?
Could you also post an output of tsscan with the modified version, just like the one you posted in issue #24 ?

The value 255 looked too specific to a given driver to be individually checked.

When I patched the driver, I noticed the following
struct sms_isdbt_layer_stats {
	/* Per-layer information */
	u32 code_rate; /* Code Rate from SMSHOSTLIB_CODE_RATE_ET, 255 means layer does not exist */
	u32 constellation; /* constellation from SMSHOSTLIB_CONSTELLATION_ET, 255 means layer does not exist */
	u32 ber; /* Post Viterbi ber [1E-5], 0xFFFFFFFF indicate N/A */
	u32 ber_error_count; /* Post Viterbi Error Bits Count */
	u32 ber_bit_count; /* Post Viterbi Total Bits Count */
	u32 pre_ber; /* Pre Viterbi ber [1E-5], 0xFFFFFFFF indicate N/A */
	u32 ts_per; /* Transport stream PER [%], 0xFFFFFFFF indicate N/A */
	u32 error_ts_packets; /* Number of erroneous transport-stream packets */
	u32 total_ts_packets; /* Total number of transport-stream packets */
	u32 ti_ldepth_i; /* Time interleaver depth I parameter, 255 means layer does not exist */
	u32 number_of_segments; /* Number of segments in layer A, 255 means layer does not exist */
	u32 tmcc_errors; /* TMCC errors */
};

And comparing to dvb_frontend.h (at kernel) we can see that the interleaving value is a unsigned 8-bit value.
struct dtv_frontend_properties {
        ...
	/* ISDB-T specifics */
	u8			isdbt_partial_reception;
	u8			isdbt_sb_mode;
	u8			isdbt_sb_subchannel;
	u32			isdbt_sb_segment_idx;
	u32			isdbt_sb_segment_count;
	u8			isdbt_layer_enabled;
	struct {
	    u8			segment_count;
	    enum fe_code_rate	fec;
	    enum fe_modulation	modulation;
	    u8			interleaving;
	} layer[3];
        ...
}

So yes, 255 is driver-specific. I simply casted ti_ldepth_i from u32 to u8 without any further modification or checking.
By the way, that value should map to a table defined at kernel documentation. Setting it to 0 within the driver would be misreporting the value. Note that documentation says -1 can be a valid value but that seems to be a contradiction given the data types involved (i think).

Could you also post an output of tsscan with the modified version, just like the one you posted in issue #24 ?

Sure, see scan.txt
Finally, due to all broadcasters in my area chose to use mode 3 according to the regulatory documents, I couldn't check what would the device return as ti_ldepth_i in other modes.

So yes, 255 is driver-specific. I simply casted ti_ldepth_i from u32 to u8 without any further modification or checking.
By the way, that value should map to a table defined at kernel documentation.

Yes, definitely. This is why I introduced the function IsValidISDBTTimeInterleaving() here and here to eliminate invalid values instead of checking != 255 just in case the kernel internals are changed in the future.

Note that documentation says -1 can be a valid value but that seems to be a contradiction given the data types involved (i think).

Definitely. Since 0xFF is stored in a u8 and ioctl(FE_GET_PROPERTY) returns a list of u32, casting u8(-1) = 0xFF into u32 still holds 255, not -1. So, if the kernel comments say 0xFF means non-existent and the user API says -1 means auto, there is some inconsistency.
Do you plan to submit your patch of the Siano driver to the kernel? I think that would be very beneficial. I have noted that while long ago all Linux drivers could report current tuning parameters, recent drivers usually don't. This is a major regression and you patch definitely fights this global tendency to regression. No later than yesterday, when I tried tsscan on my local DVB-T network to check I did not break anything, I noticed that my old Hauppauge Nova-T correctly reported tuning parameters while my recent Avermedia TD310 didn't.

Do you plan to submit your patch of the Siano driver to the kernel? I think that would be very beneficial

I sent it to the linux-media mailing list for review last week.


Remove v4 documentation 3

Let's do this in a single PR since they all have a common goal. I'll show you how to create a new branch, then add all the commits you want then open the PR.
I'll send you the instructions over Slack.

I'm going to close this one. Let's commit these changes to the original branch you made:
https://github.com/airbrake/airbrake-docs/tree/v4-remove

Continued here:
https://github.com/airbrake/airbrake-docs/pull/87


Broken pipe error

I have checked and i think i am doing everything right but I keep getting a broken pipe error.

Context please? Is it displaying any other information. What options are you using.

Sorry for the vague comment and lack of context I was just in a hurry,
I am using frame margin and that's it

I have very little experience in coding and have close to no clue what I am doing.

I think you're using an old version of auto-editor that had a mistake.
Try upgrading auto-editor
pip3 install auto-editor -U


:four_leaf_clover: Proposal: Plugin helm-generic Enhancement (sub-task of #513)

What would you like to add? Why is this needed?
See #513 for the details

Hi @rxhuster, are you still working in this issue? Please leave your feedback if you are experiencing difficulties

Hello, I want to try to make this, can you assign it to me?


Revert "Add sampling rate to internal metrics"

Reverts DataDog/dd-sdk-android#2108

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.56%. Comparing base (d2a5741) to head (d8d0838).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2112      +/-   ##
===========================================
- Coverage    69.84%   69.56%   -0.28%
===========================================
  Files          715      715
  Lines        26577    26553      -24
  Branches      4457     4452       -5
===========================================
- Hits         18561    18469      -92
- Misses        6821     6871      +50
- Partials      1195     1213      +18

Files
Coverage Δ

...n/kotlin/com/datadog/android/api/InternalLogger.kt
100.00% <ø> (ø)

.../android/core/internal/logger/SdkInternalLogger.kt
86.73% <ø> (-7.20%)
:arrow_down:

...id/core/internal/metrics/BatchMetricsDispatcher.kt
98.61% <100.00%> (-0.04%)
:arrow_down:

...oid/core/internal/metrics/MethodCalledTelemetry.kt
100.00% <100.00%> (ø)

...dog/android/core/metrics/MethodCallSamplingRate.kt
0.00% <ø> (-100.00%)
:arrow_down:

...d/rum/internal/domain/scope/RumViewManagerScope.kt
94.41% <100.00%> (+0.61%)
:arrow_up:

...um/internal/metric/SessionEndedMetricDispatcher.kt
66.67% <100.00%> (-1.08%)
:arrow_down:

... and 29 files with indirect coverage changes


[Aio] Compatibility test with ASGI applications

Try to see if gRPC AsyncIO stack works with ASGI servers. Originated from https://github.com/public/sonora/pull/32

We still want this.

@lidizheng I just wanted to confirm if this is still a priority. Using GRPC with ASGI will allow us to run frameworks like Fastapi with grpc.
Thanks a lot!


Add japanese support.

:smile:

Thank you! I'll make a new pod version ASAP (probably this weekend).

Published at the version 1.1.4