MacOS : The application “Insomnia” can’t be opened. 9.

Describe the bug
New Mac update unable to open insomina.
image
MacOS: 11.5.2 (20G95)
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. macOS 10.15.1]
Installation Method: [e.g. homebrew]
App Version [e.g. v7.0.3]

Additional context
Add any other context about the problem here.

Hi @dimpu -- Can you provide the following information:

What version of insomnia are you using?
Was it a fresh install?
How did you install it initially?

My first recommendation would be to make usre you are using the most up to date version of Insomnia.

Hi @dimpu, thanks for reporting! I just checked with our current stable release of 2021.4.1 on MacOS 11.5.2 and it seems to be working okay

Closing this issue. Since it's issue with my internal firewall. Now resolved.


[Bug] Media pack preview doesn't finish

Describe the bug
media pack preview doesn't finish -- spinner on generating previews
To Reproduce
I added this table and added the media pack:
https://vpuniverse.com/files/file/22258-gorillaz/
I got a spinner that never finished:

18-11 20:46:48.984 INFO  [JavaFX Application Thread] d.m.v.u.t.BaseDragDropHandler - Dropped file /Users/dkoski/Downloads/MediaPack.zip
18-11 20:46:49.458 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.d.MediaUploadController - Media Uploader is analyzing 6 file entries.
18-11 20:46:49.458 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.d.MediaUploadController - Media Uploader is analyzing 1 folder entries.
18-11 20:46:49.458 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.d.MediaUploadController - Media Uploader is analyzing 7 archive entries.
18-11 20:46:49.459 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack/full dmd.png
18-11 20:46:49.459 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - MediaPack/full dmd.png: FRONTEND_MEDIA
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack/Gorillaz_Backglass.mp4
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - MediaPack/Gorillaz_Backglass.mp4: FRONTEND_MEDIA
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack/Gorillaz_Loading.mp4
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - MediaPack/Gorillaz_Loading.mp4: FRONTEND_MEDIA
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack/GORILLAZ_RULECARD.png
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - MediaPack/GORILLAZ_RULECARD.png: FRONTEND_MEDIA
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack/Gorillaz_Wheel.png
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - MediaPack/Gorillaz_Wheel.png: FRONTEND_MEDIA
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack/LoadingAudio.mp3
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - MediaPack/LoadingAudio.mp3: FRONTEND_MEDIA
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Loading MediaPack
18-11 20:46:49.460 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Generating preview for file MediaPack/full dmd.png
18-11 20:46:49.488 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Generating preview for file MediaPack/GORILLAZ_RULECARD.png
18-11 20:46:49.886 INFO  [ForkJoinPool.commonPool-worker-31] d.m.v.u.t.m.MediaUploadArchiveItem - Generating preview for file MediaPack/Gorillaz_Wheel.png

vpin-studio-logs.zip
I clicked "Upload" and it seemed to upload without a problem -- it was just the spinner for the previews.

Fixed with 3.10.2


Create unir.txt

@jlsantoso I am sorry, JetBrains does not grant free educational licenses to online educational institutions. You may wish to check this repository rules located at the bottom of this page. I have to close the request without merging. Thank you for the understanding!


New features are not documented

I just realized that I didn't document any of the new features I added, i.e.:
  unbound::record { 'foo.example.com-ipv4':
    content => '<IP_ADDRESS>',
    entry => 'foo.example.com',
  }
  unbound::record { 'foo.example.com-ipv4':
    content => 'ffa3:45:34cd::13',
    type => 'AAAA',
    entry => 'foo.example.com',
  }

This looks to have been resolved.


Publish 03/16/2022 3:30 PM PT

Docs Build status updates of commit 540fb55:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

README.md
:white_check_mark:Succeeded

exchange/docs-conceptual/app-only-auth-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/cmdlet-property-sets.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/connect-to-exchange-online-protection-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/connect-to-scc-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/exchange-cmdlet-syntax.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/exchange-management-shell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/exchange-online-powershell-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/filter-properties.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/filters-v2.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/recipient-filters.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/recipientfilter-properties.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/toc.yml
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/values-for-custompropertynames-parameter.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/Export-CsAutoAttendantHolidays.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineDialInConferencingUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsOnlineVoiceUser.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTeamsAppPermissionPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTeamsAppSetupPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTeamsUpgradeStatus.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsTenant.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsUserSession.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsBroadcastMeetingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsTeamsAppPermissionPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Grant-CsTeamsAppSetupPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Import-CsAutoAttendantHolidays.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsAutoAttendant.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsAutoAttendantCallableEntity.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsAutoAttendantDialScope.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsCallQueue.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsGroupPickupUserOrbit.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsOnlineSchedule.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsOnlineTimeRange.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsAppPermissionPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsAppSetupPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsPinnedApp.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTenantDialPlan.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsAppPermissionPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsAppSetupPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsTeamsPinnedApp.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsGroupPickupUserOrbit.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsAppPermissionPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsAppSetupPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsPinnedApp.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTeamsUpgradePolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTenantDialPlan.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsWebServiceConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/New-CsOnlineTelephoneNumberOrder.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[WIP] Frontend support for creation of snapshots - Part 2

As mentioned in #221, this PR will add changes to watch for creation of a VolumeSnapshot CR and trigger the creation of snapshot. Once a snapshot is created, the VolumeSnapshotStatus is updated with relevant information.
A follow up PR would have changes to watch for PVC creation with the above created snapshot as the source.

@clintonk Here are the details
Test Setup

Kubernetes cluster on AWS
Trident deployed with AWS-CVS as backend
CSI hostpath driver along with csi-provisioner and csi-snapshotter

Snapshot Flow
User

Create a custom VolumeSnapshotClass with snapshotter as Trident. This is not registered with any driver and can be considered as a dummy class.

apiVersion: snapshot.storage.k8s.io/v1alpha1
kind: VolumeSnapshotClass
metadata:
  name: trident-snapclass
  annotations:
    snapshot.storage.kubernetes.io/is-default-class: "true"
snapshotter: netapp.io/trident

Create a trident PVC.

kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: podpvc
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: basic

Create a VolumeSnapshot for the trident PVC with the dummy snapshot class.

apiVersion: snapshot.storage.k8s.io/v1alpha1
kind: VolumeSnapshot
metadata:
  name: snapshot-test
spec:
  snapshotClassName: trident-snapclass
  source:
    name: podpvc
    kind: PersistentVolumeClaim

This VolumeSnapshot is ignored by the csi-snapshotter since the class is not associated with the registered driver. (Currently, each external-snapshotter can be configured with only a single driver)
Trident K8s Frontend

Watch for VolumeSnapshot created for trident PVCs.
Trigger a backend storage snapshot.
On successful creation of a snapshot, create a VolumeSnapshotContent and bind it to the VolumeSnapshot. For example:

apiVersion: snapshot.storage.k8s.io/v1alpha1
kind: VolumeSnapshotContent
metadata:
  name: content-<snapshot-test-uid>
spec:
  csiVolumeSnapshotSource:
    driver: netapp.io/trident
    snapshotHandle: <backend-snapshot-id>
  volumeSnapshotRef:
    kind: VolumeSnapshot
    name: snapshot-test
    namespace: <snapshot-namespace>
    uid: <snapshot-test-UID>
  persistentVolumeRef:
    kind: "PersistentVolume"
    name: <pv-name>
    namespace: <pv-namespace>
    uid: <pv-UID>

This again is ignored by the csi-snapshotter.

Update the VolumeSnapshotStatus with relevant information and VolumeSnapshotSpec with snapshotContentName.

Trident Orchestrator

Create a snapshot on the corresponding backend storage.
Store the state of the snapshot in the persistent store with SnapshotID as the key.

CreateVolumeFromSnapshot flow
User

Create a trident PVC with dataSource as the VolumeSnapshot

kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: podpvc-from-snapshot
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: basic
  dataSource:
    kind: VolumeSnapshot
    name: snapshot-test
    apiGroup: snapshot.storage.k8s.io

Trident K8s frontend

In processPendingClaim, similar to checking if a clone is required, check if a dataSource is present.
Extract the VolumeSnapshotContent information from the VolumeSnapshot and then get the snapshotHandle.
Pass on the snapshotHandle to create a volume from snapshot.

Trident Orchestrator

Fetch the snapshot object from the persistent store using the snapshotHandle (ID) as the key.
Create a volume using the snapshot as the source.
The function signature would look like CreateVolumeFromSnapshot(snapshotID string, volConfig *storage.VolumeConfig) (externalVol *storage.VolumeExternal, error)

Some questions

There are multiple ways to create the dummy VolumeSnapshotClass.

We can document it as a prerequisite for using the VolumeSnapshot feature and provide an example class for the user to create it manually.
We can also deploy a default class during the installation controlled by a flag.
What would you prefer?

I was thinking of adding the code to install the CRDs during the Trident installation, probably with the install command.
Should there be some flag to control this or is it okay to do it always?

Do let me know your thoughts on this.

Will reopen a fresh PR for this.


[Refactor] refactor the Options page with antd

Description

Hypercrx will introduce antd as the UI library. Now in the codebase only the Options page depends fluentUI, which should be refactored with antd.

Recalling that when I started OSPP, I wanted to use fluentUI because I saw that fluentUI was used. But in the end, I chose antd and supported domestic production! !

Recalling that when I started OSPP, I wanted to use fluentUI because I saw that fluentUI was used. But in the end, I chose antd and supported domestic production! !

You made a good choice. We are planning to use antdesign in our project. We will need your help later!


Fix ClickHouse crashing after ZooKeeper lost data

There is a problem reported by a user when deployment ClickHouse with PV and default ZooKeeper.
How to reproduce the problem
After deploy the ClickHouse with PV and default ZooKeeper, if the ZooKeeper pod crashes first and followed by the crashes of the ClickHouse pod, the bug will show up. e.g., if we run the following commands, the ClickHouse pod will keep crashing.
kubectl delete pod zookeeper-0 -n flow-visibility
kubectl delete pod chi-clickhouse-clickhouse-0-0-0 -n flow-visibility

We will be able to see from the ClickHouse pod log
...
2023.07.20 23:05:30.492951 [ 106 ] {} <Warning> default.flows_local (b0182a24-d467-4e9e-8f4a-908322270b64): No metadata in ZooKeeper for /clickhouse/tables/0/default/flows_local: table will be in readonly mode.
...
2023.07.20 23:05:31.086664 [ 52 ] {93600396-a3b1-42ca-acbb-5545f10eca29} <Error> TCPHandler: Code: 242. DB::Exception: Table is in readonly mode (replica path: /clickhouse/tables/0/default/flows_local/replicas/chi-clickhouse-clickhouse-0-0). (TABLE_IS_READ_ONLY), Stack trace (when copying this message, always include the lines below):

0. DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0xb8a4c1a in /usr/bin/clickhouse
1. DB::Exception::Exception<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>(int, fmt::v8::basic_format_string<char, fmt::v8::type_identity<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&>::type>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) @ 0xb90e6d8 in /usr/bin/clickhouse
2. DB::StorageReplicatedMergeTree::alter(DB::AlterCommands const&, std::__1::shared_ptr<DB::Context const>, std::__1::unique_lock<std::__1::timed_mutex>&) @ 0x16904fac in /usr/bin/clickhouse
3. DB::InterpreterAlterQuery::executeToTable(DB::ASTAlterQuery const&) @ 0x161a1fe8 in /usr/bin/clickhouse
4. DB::InterpreterAlterQuery::execute() @ 0x1619ff72 in /usr/bin/clickhouse
5. ? @ 0x1656ce56 in /usr/bin/clickhouse
6. DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) @ 0x1656a675 in /usr/bin/clickhouse
7. DB::TCPHandler::runImpl() @ 0x1714c8ea in /usr/bin/clickhouse
8. DB::TCPHandler::run() @ 0x1715f1d9 in /usr/bin/clickhouse
9. Poco::Net::TCPServerConnection::start() @ 0x19dc77f3 in /usr/bin/clickhouse
10. Poco::Net::TCPServerDispatcher::run() @ 0x19dc8b71 in /usr/bin/clickhouse
11. Poco::PooledThread::run() @ 0x19f79e3b in /usr/bin/clickhouse
12. Poco::ThreadImpl::runnableEntry(void*) @ 0x19f77540 in /usr/bin/clickhouse
13. ? @ 0x7fe5224f7609 in ?
14. __clone @ 0x7fe52241c133 in ?

Received exception from server (version 22.6.9):
Code: 242. DB::Exception: Received from <IP_ADDRESS>:9000. DB::Exception: Table is in readonly mode (replica path: /clickhouse/tables/0/default/flows_local/replicas/chi-clickhouse-clickhouse-0-0). (TABLE_IS_READ_ONLY)
(query: ALTER TABLE flows_local MODIFY TTL timeInserted + INTERVAL 12 HOUR;)

What we want to do
It turns out the root cause is as the ZooKeeper does not support PV, the data in ZooKeeper will completely lost if it crashes. ClickHouse will convert the table to READONLY in this case.
Here we have several strategies we can consider:

ClickHouse provides some strategies to recover from this condition:

https://clickhouse.com/docs/en/sql-reference/statements/system#restore-replica

https://kb.altinity.com/altinity-kb-setup-and-maintenance/altinity-kb-zookeeper/altinity-kb-recovering-from-complete-metadata-loss-in-zookeeper/
If we need to use this strategy, we will need to investigate how to use them during the pod initialization.

Add PV option for ZooKeeper. This can be done refer to the way we add PV for ClickHouse and this example:https://github.com/Altinity/clickhouse-operator/blob/master/deploy/zookeeper/quick-start-persistent-volume/zookeeper-1-node.yaml

There might be a risk here if the data in ZooKeeper PV lost.
IMO, it would be good to add the ZooKeeper PV first. And we may also would like to investigate how to avoid the crashing if the data lost from ZooKeeper side so that users can still recover through ClickHouse strategies. Basically, this error may not appear if we remove the alter table clause for the TTL. We may need to investigate a better way to update the TTL.

Hi @yanjunz97 - do you know if this will be fixed in an upcoming release? :)

Hi @robbo10, @yuntanghsu opened a PR to fix this at #470. We should be able to merge it in the upcoming release.


rviz start causes errors due to missing dll and plugin classes

Describe the bug
After following the installation instructions on http://wiki.ros.org/Installation/Windows (LKG with --pre) launching roscore works but launching rviz causes multiple errors.
First an error box with white X on red circle pops up with the text (translated): the execution of code cannot be continued because image_transport.dll cannot be found. A reinstallation might fix this problem". When clicking ok, the same message pops up for resource_retriever.dll".
I then added C:\opt\ros\noetic\x64\lib to the system path environment variable manually. Now rviz launches but gives the following errors:
c:\ws>rviz
[ INFO] [1593788256.216587500]: rviz version 1.14.0
[ INFO] [1593788256.216732000]: compiled against Qt version 5.10.1
[ INFO] [1593788256.216825700]: compiled against OGRE version 1.10.11 (Xalafu)
[ INFO] [1593788256.223010400]: Forcing OpenGl version 0.
[ INFO] [1593788256.886505600]: Stereo is NOT SUPPORTED
[ INFO] [1593788256.886633200]: OpenGl version: 4.6 (GLSL 4.6).
[ERROR] [1593788256.935177700]: PluginlibFactory: The plugin for class 'rviz/Orbit' failed to load.  Error: Could not find library corresponding to plugin rviz/Orbit. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.851570400]: PluginlibFactory: The plugin for class 'rviz/MoveCamera' failed to load.  Error: Could not find library corresponding to plugin rviz/MoveCamera. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.858282700]: PluginlibFactory: The plugin for class 'rviz/Interact' failed to load.  Error: Could not find library corresponding to plugin rviz/Interact. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.862627800]: PluginlibFactory: The plugin for class 'rviz/Select' failed to load.  Error: Could not find library corresponding to plugin rviz/Select. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.866919900]: PluginlibFactory: The plugin for class 'rviz/SetInitialPose' failed to load.  Error: Could not find library corresponding to plugin rviz/SetInitialPose. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.870725300]: PluginlibFactory: The plugin for class 'rviz/SetGoal' failed to load.  Error: Could not find library corresponding to plugin rviz/SetGoal. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.875336100]: PluginlibFactory: The plugin for class 'rviz/Grid' failed to load.  Error: Could not find library corresponding to plugin rviz/Grid. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.879136700]: PluginlibFactory: The plugin for class 'rviz/Interact' failed to load.  Error: Could not find library corresponding to plugin rviz/Interact. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.882986300]: PluginlibFactory: The plugin for class 'rviz/MoveCamera' failed to load.  Error: Could not find library corresponding to plugin rviz/MoveCamera. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.888278800]: PluginlibFactory: The plugin for class 'rviz/Select' failed to load.  Error: Could not find library corresponding to plugin rviz/Select. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.892044000]: PluginlibFactory: The plugin for class 'rviz/FocusCamera' failed to load.  Error: Could not find library corresponding to plugin rviz/FocusCamera. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.896296400]: PluginlibFactory: The plugin for class 'rviz/Measure' failed to load.  Error: Could not find library corresponding to plugin rviz/Measure. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.900515500]: PluginlibFactory: The plugin for class 'rviz/SetInitialPose' failed to load.  Error: Could not find library corresponding to plugin rviz/SetInitialPose. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.904058800]: PluginlibFactory: The plugin for class 'rviz/SetGoal' failed to load.  Error: Could not find library corresponding to plugin rviz/SetGoal. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.907484000]: PluginlibFactory: The plugin for class 'rviz/PublishPoint' failed to load.  Error: Could not find library corresponding to plugin rviz/PublishPoint. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.
[ERROR] [1593788273.911491000]: PluginlibFactory: The plugin for class 'rviz/Orbit' failed to load.  Error: Could not find library corresponding to plugin rviz/Orbit. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.

These could be follow up errors of me adding the dll files to the search path manually, not sure what the canonical way would be. I would have assumed setup.bat does this somehow.
The same error seems to affect another user as well who posted it into a closed issue: https://github.com/ros-visualization/rviz/issues/1384#issuecomment-629671290
Any help would be greatly appreciated.
To Reproduce
Steps to reproduce the behavior:

Install according to http://wiki.ros.org/Installation/Windows (LKG with --pre)
Launch roscore
Launch rviz
Error messages pop up for missing dlls (image_transport.dll, resource_retriever.dll)
Add C:\opt\ros\noetic\x64\lib to the system path environment variable
Launch rviz again (Now the dll is found but you get 16 errors on rviz launch)

Expected behavior
The dll files should be found directly after following the tutorial.
rviz should launch without error messages for missing classes
Environment information:

OS version: Microsoft Windows [Version 10.0.18363.900]
Not sure if relevant but the machine already had a Qt 5.10.0 installation previously
Chocolatey Versions: choco list --local-only

Chocolatey v0.10.15
assimp <IP_ADDRESS>9242322
boost <IP_ADDRESS>4102339
bzip2 <IP_ADDRESS>1242108
chocolatey 0.10.15
chocolatey-core.extension <IP_ADDRESS>
chocolatey-windowsupdate.extension 1.0.4
chocolateygui 0.17.1
console_bridge <IP_ADDRESS>9242322
cppzmq <IP_ADDRESS>1162207
dlfcn-win32 <IP_ADDRESS>1162226
DotNet4.5.2 <IP_ADDRESS>40902
eigen <IP_ADDRESS>9242322
freeimage <IP_ADDRESS>1160037
gazebo9 <IP_ADDRESS>
google-mock <IP_ADDRESS>9242326
google-test <IP_ADDRESS>9242322
gtk3 <IP_ADDRESS>9242322
ilmbase <IP_ADDRESS>1210800
jasper <IP_ADDRESS>1210919
jxrlib <IP_ADDRESS>1210809
KB2919355 1.0.20160915
KB2919442 1.0.20160915
KB2999226 1.0.20181019
KB3033929 1.0.5
KB3035131 1.0.3
lcms <IP_ADDRESS>1210903
libcurl <IP_ADDRESS>9242322
libflann <IP_ADDRESS>9090720
libgraphviz <IP_ADDRESS>0022039
libjpeg-turbo <IP_ADDRESS>9242322
liblzma <IP_ADDRESS>1210837
libogg <IP_ADDRESS>9090720
libopencv <IP_ADDRESS>9242322
libpcl <IP_ADDRESS>9090720
libpng <IP_ADDRESS>9242322
libraw <IP_ADDRESS>1210804
libtbb-dev 2<IP_ADDRESS>2011750
libtheora <IP_ADDRESS>9090720
libwebp <IP_ADDRESS>1210731
log4cxx <IP_ADDRESS>9242322
lz4 <IP_ADDRESS>9242322
ogre <IP_ADDRESS>1312214
openexr <IP_ADDRESS>1210832
openjpeg <IP_ADDRESS>1210736
openssl <IP_ADDRESS>9242322
orocos_kdl <IP_ADDRESS>9242322
pkg-config <IP_ADDRESS>9242322
poco <IP_ADDRESS>9242322
protobuf <IP_ADDRESS>1130545
python3-pyqt5 <IP_ADDRESS>4112255
python3-sip <IP_ADDRESS>4120807
qt5-sdk <IP_ADDRESS>3182340
qwt <IP_ADDRESS>1212304
ros-colcon-tools <IP_ADDRESS>5240527
ros-noetic-desktop_full 20200703.1-pre
ros-python37 <IP_ADDRESS>3082244
sbcl <IP_ADDRESS>9242326
tiff <IP_ADDRESS>1210742
tinyxml <IP_ADDRESS>9242322
tinyxml2 <IP_ADDRESS>9242322
urdfdom <IP_ADDRESS>9242322
urdfdom_headers <IP_ADDRESS>9242322
vcredist140 14.26.28720.3
vcredist2010 10.0.40219.2
yaml-cpp <IP_ADDRESS>1170034
zeromq <IP_ADDRESS>1162203
zlib <IP_ADDRESS>9242322
67 packages installed.

Thank you for the bug, we'll look into it asap.

Hey there, can you give me any info about the problem? I had this ".dll" error with both Gazebo and Rviz. Adding the lib folder to path cleared the problem with Gazebo but I still have the same ".dll" error with Rviz.

This should be addressed in this Noetic 202008<IP_ADDRESS>9101215 release. I am closing it now and feel free to reopen if you still have this DLL loading issue. Thanks!


[sp] add data source transformer templates

Summary

refactor data source menu items into builder util function
add data source menu items to "add transformer block" dropdown

Tests

(Waiting on backend bugfix from Sachchit, will update w/ live test then)
cc: @johnson-mage @skunichetty @wangxiaoyou1993

Let's move "Generic (no template)" above the "Data sources"

@shrey-mage Add some padding between the text and right arrow:


Json return erro

JSONDecodeError('Expecting value: line 1 column 1 (char 0)')

normal, ratelimit or dead devices

@xtekky How to get our own devices ?

its a difficult process, I can't explain in debth


Improved documentation for Model.fitresult

Currently documentation is lacking for Model.fitresult.  This should be documented in the Model object definition, as well as in the quickstart guide, and in the section of the cookbook devoted to loss functions.

Improved in 8ecda24


Only run ELK stack when the job 'action' = 'elk'

Rather than always gate everything together, we split out
the ELK stack execution into its own action so that it can
be tested using MNAIO images. This also keeps the images
smaller.
JIRA: RI-263
(cherry picked from commit a5849b19fdd0d4ae7148d7a07394a122c52274d5)
Issue: RI-263

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.


Implement tax related measures in tax calculation

The tax increase (or reduction) as a result of a measure needs to be implemented in the  tax calculation in the facilitator app.

Calculation has been included. See snippet below:
var cumulativeNewsEffects = CumulativeNewsEffects.readCumulativeNewsEffects(data.getDataSource(),
        data.getScenario(), data.getCurrentRoundNumber());

for (var community : communityMap.keySet())
{
    List<TaxRecord> taxList =
            dslContext.selectFrom(Tables.TAX).where(Tables.TAX.COMMUNITY_ID.eq(community.getId())).fetch();
    taxMap.put(community, 1000);

    // tax change based on measures
    int txc = (int) cumulativeNewsEffects.get(community.getId()).getTaxChange();

    for (TaxRecord tax : taxList)
    {
        int nr = communityMap.get(community);
        if (nr >= tax.getMinimumInhabitants() && nr <= tax.getMaximumInhabitants())
        {
            taxMap.put(community, tax.getTaxCost().intValue() + txc);
            break;
        }
    }
}

Note that the database needs to change the round 4 tax effects to:

The 5000 value instead of 5 has been changed in the database for all scenarios.

This is now correctly applied:


Maven plugin does not properly create target directory

The Maven plugin often fails with a FileNotFoundException because the target directory for XML or MOSDL generation is not created properly.

Fixed. A new release v0.1.1 is necessary because this bug is a blocker for the use of the Maven plugin.


ActionSheetCustom Create Problem

Hello Team,
When I am using ActionSheetCustom with any Image picker then it not working properly in iOS.
When I choose to pick an image from the gallery after first-time selection when user open gallery (Picker) then it auto-dismissed.
The same works fine in Android.
Can you please provide any solution regarding it.

+1

+1

This issue is a blocker in my app.
Anyone knows any alternate ActionSheet api that works the same on both iOS and Android?

。。。

kumarryogeshh

Try it as a temporary solution
 onPress={(i) => {                   setTimeout(() => {                     this.avatarRemove();                   },1);                }  }


Improved window.map debugging

For debugging I might like let map = window.map = new …. The downside of modules is you don't implicitly get global variables, naturally.
(Technically this can be accomplished by making it an export but you'd need to write the correct import at the console.)
Originally posted by @jleedev in https://github.com/ZeLonewolf/openstreetmap-americana/pull/57#discussion_r762564664

Fixed in 9ccc0502bd29f0a94aaf93834eabf6b8e081caac for #72.


fix a few bugs with respect to refreshes and mode set via session sto…

…rage
Signed-off-by: Derek Ho<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho are we still pushing this to 2.5?

@derek-ho are we still pushing this to 2.5?

@ps48 I was thinking to push it in here and backport to 2.x and main in case we need to release 2.5.1, etc.


[CARBONDATA-3911]Fix NullPointerException in case of multiple updates and clean files

Why is this PR needed?
when multiple load and multiple updates are performed, the segment files will be created for each update, when clean files performed, if two segments are there, first segment will clean other segments's segment file also which leads to nullpointer.
What changes were proposed in this PR?
Once all the segments stale segment files are collected, then delete the stale files at once.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3390/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1649/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3412/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1670/

retest this please

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3462/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1720/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/3466/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1724/

LGTM


Move snippets to code files

Fixes #39380

Internal previews

📄 File
🔗 Preview link

docs/core/whats-new/dotnet-8.md
What's new in .NET 8

Thanks @BillWagner


Possible Linter Integration?

This seems like a great package, I'd like to see it integrate with Linter is some way.
I'm thinking that if error range points to a file, it could tell Linter of the error so that it will be displayed inline (like other IDEs.)
If this can be integrated cleanly I'd love to feature the build providers on the AtomLinter homepage.
/cc @steelbrain @joefitzgerald

That's a decent idea. I know this has been discussed before, but never really amounted to anything. I'm happy to accept pull requests for this.

If someone wants to do it, here's a pointer. Use the self-api exported by the linter package. Create an object of the linter shape and set messages with it. Use atom-package-deps to automatically install dependencies.

If anyone takes a stab at this, post something here to avoid duplicated work. I'll look into it as soon as I have some time unless someone beats me to it.

I will give it a shot tonight. Please do not take it to be a commitment though, if someone else wants to do this please do.

Why not just add your favorite linter to your build process? I prefer eslint with these global rules (in .eslint):
/**
 * See default rules here:
 * http://eslint.org/docs/rules/
*/
{
	"rules": {
		"camelcase": 0,
		"no-use-before-define": 0,
		"no-spaced-func": 0,
		"no-underscore-dangle": 0,
		"new-cap": 0,
		"no-console": 0,
		// warn on unused variables
		"no-unused-vars": 1
	}
}

Then in my Gruntfile, I use gruntify-eslint:
eslint: {
	src_js: {
		src: [
			"Gruntfile.js",
			"<%= dirs.source_js %>/**/*.js"
		]
	}
}

Also, within Atom I use the plugin linter-eslint which uses the rules above to validate JavaScript as it is edited.

@cbetancourt I think you may have misunderstood. The intent of this issue is to take any Error Matching Result that maps to a file and send it to linter so that it may be displayed inline. This would be incredibly helpful for packages like build-sbt or build-gradle where creating an effcient package for linter is almost impossible, especially since linter was never intended to handle issues of that size.
It would be very helpful for creating a modular IDE of Atom.

Closing as this is now supported.


Add breadcrums to app sections

Overview
When changing to show subtabs on sidebar I lost track of the design and didn't add the breadcrum element that was proposed in both sections, Assets and Settings
Goals
Implement the breadcrum design, that was really close to the previous link mechanism we had
Requirements
Screens

https://github.com/gnosis/safe-react-components/pull/79


sfdx cli ignores NO_PROXY environment variable

Summary
I am behind a corporate proxy and as such have my HTTP_PROXY and HTTPS_PROXY environment variables set. We have Salesforce addresses bypassed in the proxy due to IP restrictions, so I have set NO_PROXY=salesforce.com,force.com however sfdx cli appears to be ignoring NO_PROXY as I receive an IP Restricted error when logging in. I don't want to have to unset HTTP_PROXY and HTTPS_PROXY every time I need to use sfdx cli as all of my other tools require the proxy settings.
Steps To Reproduce:

Set HTTP_PROXY and HTTPS_PROXY to corporate proxy.
Set NO_PROXY=salesforce.com,force.com
sfdx auth:web:login -r https://org--sandbox.my.salesforce.com
Login to the Sandbox in opened browser page

Expected result
Successfully authorized<EMAIL_ADDRESS>with org ID xxxxxxxxxxxxxxxx
Actual result
{   "status": 1,   "name": "SfError",   "message": "Invalid client credentials. Verify the OAuth client secret and ID. Error authenticating with auth code due to: ip restricted",   "exitCode": 1,   "context": "Login",   "stack": "SfError: Invalid client credentials. Verify the OAuth client secret and ID. Error authenticating with auth code due to: ip restricted\n    at Login.run (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@salesforce/plugin-auth/lib/commands/auth/web/login.js:51:23)\n    at processTicksAndRejections (node:internal/process/task_queues:96:5)\n    at async Login._run (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@salesforce/command/lib/sfdxCommand.js:102:40)\n    at async Config.runCommand (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@oclif/core/lib/config/config.js:272:25)\n    at async run (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@oclif/core/lib/main.js:76:5)",   "warnings": [],   "commandName": "Login" }
System Information

Which shell/terminal are you using? (e.g. bash, zsh, powershell 5, powershell 7, cmd.exe, etc.)
zsh
If you are using sfdx

Run sfdx version --verbose --json

If you are using sf

Run sf version --verbose --json

sfdx version --verbose --json
{
"cliVersion": "sfdx-cli/7.170.0",
"architecture": "darwin-arm64",
"nodeVersion": "node-v16.18.0",
"pluginVersions": [
"@oclif/plugin-autocomplete 1.3.0 (core)",
"@oclif/plugin-commands 2.2.0 (core)",
"@oclif/plugin-help 5.1.12 (core)",
"@oclif/plugin-not-found 2.3.1 (core)",
"@oclif/plugin-plugins 2.1.0 (core)",
"@oclif/plugin-update 3.0.0 (core)",
"@oclif/plugin-version 1.1.2 (core)",
"@oclif/plugin-warn-if-update-available 2.0.4 (core)",
"@oclif/plugin-which 2.1.0 (core)",
"alias 2.1.0 (core)",
"apex 1.2.0 (core)",
"auth 2.2.8 (core)",
"community 2.0.1 (core)",
"config 1.4.20 (core)",
"custom-metadata 2.0.0 (core)",
"data 2.1.2 (core)",
"generator 2.0.2 (core)",
"info 2.1.3 (core)",
"limits 2.0.1 (core)",
"org 2.2.3 (core)",
"packaging 1.9.1 (core)",
"schema 2.1.6 (core)",
"signups 1.2.2 (core)",
"source 2.0.15 (core)",
"telemetry 2.0.0 (core)",
"templates 55.1.0 (core)",
"trust 2.0.4 (core)",
"user 2.1.4 (core)",
"@salesforce/sfdx-plugin-lwc-test 1.0.1 (core)",
"salesforce-alm 54.8.1 (core)",
"sfpowerkit 6.0.0 (user)"
],
"osVersion": "Darwin 22.1.0",
"shell": "zsh",
"rootPath": "/opt/homebrew/lib/node_modules/sfdx-cli"
}
Additional information

Yeah, jsforce has no support for NO_PROXY, so we've inherited that lack of support.
If you'd like to move it along sooner, I'd recommend trying some changes to https://github.com/jsforce/jsforce/blob/2.0/src/transport.ts and sending a PR.

Check out this discussion, closing as duplicate
https://github.com/forcedotcom/cli/discussions/2375


Change raft-ann-bench package name to raft_ann_bench

@divyegala This PR requires https://github.com/rapidsai/raft/pull/2333  to be merged first, right?

@dantegd yes I'll link the description


Fix: “Add TextBox” dialog not opening

What type of PR is this?

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] New Query Runner (Data Source)
[ ] New Alert Destination
[ ] Other

Description

How is this tested?

[ ] Unit tests (pytest, jest)
[ ] E2E Tests (Cypress)
[ ] Manually
[ ] N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

asdgasdg


Evaluator Review: EVMNS_Milestone_4&5

Review, approve, or deny https://github.com/eosnetworkfoundation/grant-milestones/pull/121

Closed per @wanderingbort approval for https://github.com/eosnetworkfoundation/grant-milestones/pull/121.


Update Tika dependencies

The Tika libraries included in this gem are several years old now. Could we update them? I may be able to do this in a PR.

I thinks it's a good idea to transfer the ownership of this repository to you so you can continue to maintain it. However, when I tried to transfer it to you I got an error message because you already have a fork called keithrbennett/rika. Can you delete it first so I can transfer it?

I have updated the included jar files to include only the single tika-app-1.24.1.jar file in the new release, v 1.11.1. See the Release Notes for more information about the release.


Little typo in access example

https://github.com/clemos/try-haxe/blob/26900e05324daca61ed88aea475bc66c6cc144a6/examples/Example-13.hx#L21

can you please make a PR :p ?

Yep. And done.
By the way for little fixes like this one you can edit the file directly from github web interface.


Seems to be very slow

Querying a table with few entries is also taking much time?.

Can you please provide more details? I haven't faced this issue so far. The query generated is straight forward. Can you check your database and table?


Add hashtag capabilities to friends

So a friend could be a #work friend or a #family friend, and they could be combined like:
friends.md

### Friends:
- Grace Hopper (a.k.a. The Admiral) #work #school
- Marie Curie #school

@andypearson is this what you were thinking?

Yup, this is exactly what I was imagining!

Super excited for this feature! Thanks for adding it :D

I'd love to hear how it works for you!


Need to hit Enter to change a keyboard shortcut (unintuitive)

From<EMAIL_ADDRESS>on 2010-12-10T04:52:50Z
What steps will reproduce the problem?

In keyboard shortcut preferences pane change a modifier or key field.
Don't move the focus to a different field
Hit OK button What is the expected output? What do you see instead? Expected that change gets applied. Instead the change is lost. It is also observed that the Apply button remains grayed out until the focus moves to a different field in the grid. What version of the product are you using? On what operating system? spyder-2.0.3, OS X 10.6.4

Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=494

From ccordoba12 on 2014-08-23T13:14:20Z
Summary: Need to hit Enter to change a keyboard shortcut (unintuitive)  <span class="oldvalue"> (was: Keyboard Shortcut pref pane interface problem) </span>
Status: Accepted
Labels: MS-v2.4

From ccordoba12 on 2014-09-21T11:47:28Z
We should automatically call whatever pressing Enter does to solve this one.
Labels: Easy

From pierre.raybaut on 2011-05-16T01:21:02Z
Labels: Cat-Settings


Possible bug in Example vignette code for applying inclusion criteria

We (https://github.com/nimirea) and I suspect that the examples in https://github.com/OHDSI/Capr/blob/main/vignettes/Examples.Rmd may be out of date with the latest version of the package (2.0.5).
Namely, when we executed the example code on a CDM, we found that without wrapping the arguments to attrition() with withAll() calls, the attrition information was not properly applied in the generated cohort.
For example, in the following lines, we suspect the lines need to be wrapped with withAll() for the inclusion criteria to be correctly applied.
https://github.com/OHDSI/Capr/blob/fa03ba051993380a3c69a3b5a6c23273a2cdc390/vignettes/Examples.Rmd#L56-L59
I'm curious if the developers agree these examples are out of sync with the latest version or not. Maybe we're missing something else.
I can include the actual JSON comparison if it's helpful.

Yes that is out dated...will correct in next release. Apologies

All good! Glad it will be corrected, thank you!


CognitoIDP - allow respond_to_auth_challenge without Auth-header

See #5008

Codecov Report

Merging #5133 (9d68f6f) into master (32b662c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5133      +/-   ##
==========================================
- Coverage   95.88%   95.86%   -0.02%
==========================================
  Files         680      680
  Lines       67265    67268       +3
==========================================
- Hits        64495    64489       -6
- Misses       2770     2779       +9

Flag
Coverage Δ

servertests
36.90% <100.00%> (+0.06%)
:arrow_up:

unittests
95.81% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/cognitoidp/models.py
95.58% <100.00%> (+0.01%)
:arrow_up:

moto/cognitoidp/responses.py
98.67% <100.00%> (ø)

moto/resourcegroupstaggingapi/models.py
83.18% <0.00%> (-0.59%)
:arrow_down:

moto/route53/responses.py
96.69% <0.00%> (-0.42%)
:arrow_down:

moto/sns/models.py
96.83% <0.00%> (-0.40%)
:arrow_down:

moto/efs/models.py
91.20% <0.00%> (-0.30%)
:arrow_down:

moto/sqs/models.py
96.76% <0.00%> (-0.18%)
:arrow_down:

moto/config/models.py
99.22% <0.00%> (-0.13%)
:arrow_down:

moto/ssm/models.py
94.53% <0.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b662c...9d68f6f. Read the comment docs.


Calling for cooperation and collaboration

Hi!
My name is Okhlopkov Daniil and I am the creator of Instabot: instagrambot.github.io.
My project does almost the same thing as yours. May be we can combine our forces and create the best Instagram API/Bot ever built?
If you want to join - just contact me: https://telegram.me/okhlopkov

You misunderstood. I do not support botting.


compatibility of benchmark script and apisix reload command on OSX

Summary
fix osx compatibility when run benchmark/run.sh and apisix reload
Full changelog

change benchmark script sed from set workers worker_processes \d+ to worker_processes .*  to fit worker_processes auto
change sed command to fit OSX in benchmark/run.sh
fix apisix reload on OSX.

Issues resolved
Fix #1649

more: tested on centos7 and osx.


Embeds on Telegram

Can I embed tweets on Telegram without “Instant View” button under my post with alternate Fxtwitter link? This is not a critical issue, just asking

Currently, Instant View is only enabled by default if certain conditions are met or you force enable it (i.fxtwitter.com). If I may ask, what purpose do you have disablng Instant View?

Sometimes I share tweets with a very short message, and the “Instant View” button looks unnecessary and strange. Although when sharing large posts with more than one picture or thread that won't fit in the preview, “Instant View” can be useful. Unfortunately, Telegram does not yet allow you to disable this yourself at will.


Fate/Extella: The Umbral Star [PCSE00928]

Game summary

Game name: Fate/Extella: The Umbral Star
Game serial: PCSE00928

Vita3K summary

Version: 0.01
Build number: 408
Commit hash: https://github.com/vita3k/vita3k/commit/8b50c0b

Test environment summary

Tested by: waterflame
OS: Windows 7
CPU: Intel i7-2600
GPU: AMD Radeon HD 6700 Series
RAM: 8 GB

Issues
Okay... so since I already had them... I have logs for all 6 modes of Mai. I also have with and without putting the dumped shaders in the shader folder(which causes 3 of the modes to load further or less). Only mode 4 dumped any shaders(and it dumped a lot of them). "ws" stands for "with shaders"(from mode 4 dump). I'll only be including ws logs that their was a difference between the two... don't expect this from now on :p Another mention to addcont0: so take this as me reporting it to the devs :p(like with DRv3).
Crash: 2 2ws 3 3ws 4(? It just closes, no log output or crash popup) 4ws(same)
Softlock: 0 1 5 6
So what does each mode mean... here is a list taken from the maidump app. I assume 6 is support for an older version of 5. "p.support" is most likely referencing "plugin support".
0. Load dual libfios2 (p.support) (recommended)
1. Only load libfios2_m (p.support)
2. Load dual libfios2 and dual libc (p.support)
3. Only load libfios2_m and libc_m (p.support)
4. Use original eboot (no p.support)
5. Load mode 0+ IO hook (supports plugin and DLC)
6. 2z2 Mode 5 loading

Screenshots(mode0)

Screenshots(mode1)

Screenshots(mode2)

Screenshots(mode2ws)

Screenshots(mode3)

Screenshots(mode3ws)

Screenshots(mode4)

Screenshots(mode4ws)

Screenshots(mode5)

Screenshots(mode6)

Log
vita3k_0.log
vita3k_1.log
vita3k_2.log
vita3k_2ws.log
vita3k_3.log
vita3k_3ws.log
vita3k_4.log
vita3k_4ws.log
vita3k_5.log
vita3k_6.log
Recommended labels

crash
softlock

Vita3K summary

Version: v0.1
Build number: 571-70599d3
Commit hash:  https://github.com/Vita3K/Vita3K/commit/70599d3

Will carry on with Mode 0 as it's the default dump mode. Softlock on loading archive.pkh
FateExtella.log

Why don't you use FAGDec instead of mai dump tool ?

@CelesteBlue-dev This isn't the place to talk about this, please ask him on Discord in #testing or something.

Vita3K summary

Version: v0.1
Build number: 984
Commit hash: fb0798e of pull/456 (I don't want to append every issue to the PR)

Fate Extella - [PCSE00928].log
Issue
stat file error

Vita3K summary

Version: v0.1
Build number: 1315
Commit hash: https://github.com/vita3k/vita3k/commit/5b070aac

Softlocks stating archive; Also sceKernalSignalLwCondAll: SCE_KERNEL_ERROR_LW_MUTEX_RECURSIVE

Vita3K v0.1.5 2603-8daf6c6f
crashes out the emulator nearly straight away
vita3k.log

Vita3K summary

Version: v0.1.5
Build number: 2630
Commit hash: https://github.com/vita3k/vita3k/commit/18dacae2
CPU backend: Dynamic

Test environment summary

Tested by: othmanead
OS: Windows 11
CPU: Intel i5-10300H
GPU: RTX 3060 mobile
RAM: 16 GB

Issue:

Game goes ingame but it crashes after a while (see second screenshot)

Screenshots:

Log
vita3k.log
Recommended labels

Ingame -
Crash

as of https://github.com/Vita3K/Vita3K/commit/b39d9bc427ceaa9d3f68eeb6f58fcaea0049512b, the game doesn't crash anymore and its now playable.
Screenshots

Log
vita3k.log
Recommended Labels

Playable

I'm trying to play this game on the V8 android release of Vita3k, and all works well up until the tutorial (as in the menus work), where I get a white screen although the interface works

White screen problem persists on Android, the game is unplayable, performance is horrible


Missing Image in Order Summary Component  and Page Navigation Failure

What does this PR do?
In the project section, the image intended to appear in the order summary container was not displaying. Additionally, unlike other sections, clicking on the order summary did not navigate to a separate page. This inconsistency disrupted the user experience, as other sections opened their respective pages, while the order summary remained non-functional.

Fixes #236
Images/Videos:
Before:
before.webm
After:
after.webm
Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this be tested?

Open index.html using a live server or browser.
On the homepage, scroll down to order summary component project.
Observe the existing no image container, which does not navigate to a separate page too.

Mandatory Tasks:

[X] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@beRajeevKumar Please review this PR once and add appropriate level and labels under gssoc and hacktoberfest.
Thankyou for assigning it to me

Nice done!

can u add level and gssic label too


rancher shows pod is "Terminating", but i did not find any pod infomation with using "kubectl describe"

Rancher Server Setup

Rancher version: 2.6.3
Installation option (Docker install/Helm Chart): Docker install

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): k3s

Proxy/Cert Details: self-signed-ssl

Information about the Cluster

Kubernetes version: v1.21.7+k3s1
Cluster Type (Local/Downstream):  Imported or specify provider for Hosted

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions: Admin

Describe the bug

rancher shows pod is "Terminating", but i did not find any pod infomation with using "kubectl describe"

[root@release-master ~]# kubectl describe pod u-sopei-cn-6cf74d5ddc-n5glp -n sopei-biz
Error from server (NotFound): pods "u-sopei-cn-6cf74d5ddc-n5glp" not found
[root@release-master ~]# kubectl get pods -n sopei-biz -l app=u-sopei-cn
NAME                         READY   STATUS    RESTARTS   AGE
u-sopei-cn-674d8ff69-tr7b8   1/1     Running   0          89m
u-sopei-cn-674d8ff69-7tsrt   1/1     Running   0          89m
[root@release-master ~]#

To Reproduce

Result
Expected Result

Screenshots

Additional context

See the same issue

See also the same issue with Rancher 2.6.5 and Kubernetes 1.23.6

same issue

Same issue with Rancher 2.6.6.
The UI shows a pod in Terminating state:

But this pod does not exist:
$ kubectl get pod ssave-entity-operator-6c7d58ffb7-w9hp8
Error from server (NotFound): pods "ssave-entity-operator-6c7d58ffb7-w9hp8" not found

How can we get rid of these "ghost" pods in rancher?

I think this is still relevant


Allow contributor to leave a comment to the task provider

Sometimes, it is really useful to get some feedback from the mapper. E.g. you leave them a task to fix, but they notice something related to the challenge is pretty weird. It would be nice if there was a free text field where the mapper can leave a message like this. That way, a task manager can more easily have a closer look at fixed-but-special tasks.

I like the idea but it would be a fair amount of work. I wonder if there is a simpler way to accomplish this, for example each task could have a link to send a message to the challenge author?

Hmm, that workaround doesn't seem worth the effort: one could simply ask to do so in the instructions. The idea behind this feature request is to create some useful metadata about the individual situations themselves. Given the size of the tasks I have in mind, doing this by individual message would be quite cumbersome.
I wouldn't mind to keep this issue open as a long term goal instead of a quick half-solution.

It would amount to a comment function on tasks (because if you let one mapper comment, the next mapper coming along may want to weigh in as well). I like the idea of it being public but it would also mean some design & implementation work. Let's keep it open for now.
Another 'hacky' solution in the mean time could be to have a link to a github repository you set up for the challenge and pre-fill the title or body with the task ID or a link to the task, like https://github.com/user/repo/issues/new?title=your+title&body=your+body. Obviously this would still not show up with the task but perhaps it's something to work with for now?

Yes, that sounds like an interesting solution. It would be good enough to help evaluate if it makes sense to fully implement this.

This is now functional and looking BEAUTIFUL.
I'm not clear on how it is possible to extract the data though?

For now you'll have to ask me :) -- in the future we should make it
possible to download challenge data as CSV or something.
On Mon, Oct 2, 2017 at 12:42 PM, Joost<EMAIL_ADDRESS>wrote:

This is now functional and looking BEAUTIFUL.
I'm not clear on how it is possible to extract the data though?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/maproulette/maproulette2/issues/314#issuecomment-333626684,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHWhEYyexu8u_Rho-gOrUx6pmi18GOmks5soS6LgaJpZM4MzPC1
.

Does that mean that the API documentation is ahead of implementation? (because I see this there:http://maproulette.org/api/v2/task/[task number]/comments

You are right, retrieving via the API is already possible, just not in bulk
for all tasks in a challenge, as far as I remember.
On Mon, Oct 2, 2017 at 1:35 PM, Joost<EMAIL_ADDRESS>wrote:

Does that mean that the API documentation is ahead of implementation?
(because I see this there:http://maproulette.org/api/v2/task/[task
number]/comments
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/maproulette/maproulette2/issues/314#issuecomment-333640944,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHWhH1Tkk8pXyQF85StD30mDgyXevCgks5soTrpgaJpZM4MzPC1
.


Use php:{version}-cli-alpine instead of bookworm for Swoole and RR

I'm preemptively creating this issue to address the "Add Alpine-based images" task on the ToDo section of the readme.
I believe I have done it, I will go ahead and create a PR and link it here when it's up.
I don't use FrankenPHP so unfortunately I won't be able to port that one over if need be.

PR created https://github.com/exaco/laravel-octane-dockerfile/pull/77

Resolved! Closing this issue. Thank you @smortexa for taking the time to integrate the changes + add the FrankenPHP image.
https://github.com/exaco/laravel-octane-dockerfile/pull/77


Fallback to TCP Proxying on non-standard HTTP traffic

Hi,
Perhaps this is more of a feature enhancement - but say that I have mitmproxy running on port 80/443 in transparent mode (HTTP proxy mode), and suddenly I get a non-HTTP connection over that port (This can happen with various applications that use proprietary TCP-based protocol over 443/80)
It'd be absolutely neat if it'd be possible to fallback to TCP-proxying on a specific problematic connection - this way the client won't feel any problems whatsoever.
I don't mind giving it a look myself - do you have a recommendation of how to elegantly achieve this behavior in the code?
Thanks a bunch,
Yoav

Hey Yoav,
how would you define problematic connection? You can already filter by destination address using --ignore or --tcp (see docs). Falling back to TCP if we can't parse it as HTTP is probably a bit tricker - we'd need to push the bytes we read back on the buffer somehow. Relevant parts:

mitmproxy architecture
ConnectionHandler (the generic part before HTTP comes into play)
HTTPHandler.handle_flow

Cheers,
Max

Thanks for the blazing fast reply.
Best example I can think of is Skype, that is using non-HTTP over an SSL connection on port 443.
The reasoning behind my question is that if I want to setup mitmproxy for a user in a totally transparent manner - then yes, I can predefine a specific subnet for example for, say, Skype connection and set them to use TCP proxying.
But let's say that some time later the user decides to install another such app, say, a Usenet client that connects on NNTP(s) over port 80(443) - a non-HTTP protocol. Again i'll have to define his Usenet server host in the exclusion list for TCP proxying.
Therefore what I'd like to do is, as I said - fallback to TCP proxying whenever HTTP proxying fails.
I'll give the a look over the code parts you mentioned and see if I can work something out.
Thanks again,
Yoav

Have fun! If there are any questions, feel free to ping me here or on IRC.
I probably forgot the most interesting portion of code - netlib's FileLike, Reader and Writer (interfaced as client_conn.rfile, .wfile etc. in mitmproxy). You may be able to add some functionality to read ahead of the cursor of the rfile.
rfile.read_ahead_start()
try:
    req = HTTPRequest.from_stream(rfile, ...)
    rfile.read_ahead_ok()
except HTTPError:
    rfile.read_ahead_reset()
    TCPHandler(self.c, log=False).handle_messages()
    return False

Implementing this is not trivial (you actually need to read from the underlying socket for the "read ahead", but then keep the results in a temporary buffer, and check on any normal read if there's still something in the buffer), but would be useful for a bunch of other usecases as well (i.e. dynamically detecting SSL traffic, which is currently based on a port heuristic).

My last comment was possibly complicating things: If you pass the connection to _FileLike, you can use socket.recv(n, socket.MSG_PEEK) to peek into the socket.

Hey Yoav,
just curious - did you end up anywhere? :-)
Cheers,
Max

Hi Max,
Unfortunately I didn't have lots of time to give it a look, but a quick test showed me that MSG_PEEK didn't really work at all on PyOpenSSL sockets (on a Debian distro Linux with the newest OpenSSL version) - have you had any experience with that before?
Another weird phenomenon I found when playing with that is that calling select()->(partially) read from socket-> select() yields the result that the second "select()" call "waits" instead of returning immediately on PyOpenSSL sockets, while it does return immediately on a regular socket (which makes sense, as there is still data to read in the socket) - so this somewhat ugly (or maybe I'm missing something out) phenomenon also gets in the way.
Anyhow - I have a feeling that Wrapper "buffering" sockets are the way to go in that case, but the refactoring may a be bit "delicate" - upon an HTTPError exception, for example - we want to fallback to TCP - but also to send out to the client/server all the data we have buffered up to now.
I'll really do my best to give it a more thorough look when I get the time :)
Yoav

Ok, thanks! I think we have two distinct problems here:
Peek into a non-SSL socket.
If we want to peek into a tcp socket (possibly to check if we receive a SSL handshake there), we must use socket.MSG_PEEK. To my knowledge, pyOpenSSL only operates on raw sockets. We cannot buffer on a higher level, because pyOpenSSL would then miss the bytes we would have read from the raw socket previously.
Peek into a pyOpenSSL socket.
If we already have a pyOpenSSL socket, we need to manage our own buffer in Reader. pyOpenSSL does not support peeking (see SSL.py#L1022.

+1

I just submitted a PR to pyOpenSSL to support peeking into connections: https://github.com/pyca/pyopenssl/pull/294

We have peek support now. Whats the status here?

This works now, although we fall back to HTTP by default at the moment as there's no proper TCP UI. We should expose next_layer to inline scripts, once that's in I consider this issue done.

@mhils: does https://github.com/mitmproxy/mitmproxy/commit/d1bc966e5b7e2ef822443f3ad28a5f3d40965e75 fix this?

Yep, thanks!

I have installed laterst (0.13) mitmproxy and see the following error messages from mitmdump when skype is active and file transfer through skype is attempted:
<IP_ADDRESS>:57740: HttpError("Bad HTTP request line: '\x7f-\xee\xa0TnA9\x92?\xd1\xd2\xfcCe\xfcf\x95\xbfD\xf2\xaaufW\xbe)\xd8\xef\xf8\xf8\x94q{\x81\xf9\x13\xfdx\x08\\'",)
And so on.
Proxy is working in transparent mode and only http proxying is enabled.  Config:
Use the Host header to construct URLs for display (in the logs)
host = true
Set transparent proxy mode
transparent = true
Set streaming mode
stream = 1k
Does this problem related to the issue discussed in this ticket? Why mitmproxy does not fall back?  Or does it fall back but I just do not see this in the logs?


Standardize README shield badges

We want to update the README for all Dapr repos so they all include shield badges for YouTube, Discord, X/Twitter and ensure they are all in the same style. See: https://github.com/dapr/community/issues/355
These are the shield badges for the dapr repo.

Snippet to include in the README just below the <div> with the image:
[![Go Report][go-report-badge]][go-report-url] [![OpenSSF][openssf-badge]][openssf-url] [![Docker Pulls][docker-badge]][docker-url] [![Build Status][actions-badge]][actions-url] [![Test Status][e2e-badge]][e2e-url] [![Code Coverage][codecov-badge]][codecov-url] [![License: Apache 2.0][apache-badge]][apache-url] [![FOSSA Status][fossa-badge]][fossa-url] [![Good First Issues][gfi-badge]][gfi-url] [![discord][discord-badge]][discord-url] [![YouTube][youtube-badge]][youtube-link] [![X/Twitter][x-badge]][x-link]

[go-report-badge]: https://goreportcard.com/badge/github.com/dapr/dapr
[go-report-url]: https://goreportcard.com/report/github.com/dapr/dapr
[openssf-badge]: https://www.bestpractices.dev/projects/5044/badge
[openssf-url]: https://www.bestpractices.dev/projects/5044
[docker-badge]: https://img.shields.io/docker/pulls/daprio/daprd?style=flat&logo=docker
[docker-url]: https://hub.docker.com/r/daprio/dapr
[apache-badge]: https://img.shields.io/github/license/dapr/dapr?style=flat&label=License&logo=github
[apache-url]: https://github.com/dapr/dapr/blob/master/LICENSE
[actions-badge]: https://github.com/dapr/dapr/workflows/dapr/badge.svg?event=push&branch=master
[actions-url]: https://github.com/dapr/dapr/actions?workflow=dapr
[e2e-badge]: https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/dapr-bot/14e974e8fd6c6eab03a2475beb1d547a/raw/dapr-test-badge.json
[e2e-url]: https://github.com/dapr/dapr/actions?workflow=dapr-test&event=schedule
[codecov-badge]: https://codecov.io/gh/dapr/dapr/branch/master/graph/badge.svg
[codecov-url]: https://codecov.io/gh/dapr/dapr
[fossa-badge]: https://app.fossa.com/api/projects/custom%2B162%2Fgithub.com%2Fdapr%2Fdapr.svg?type=shield
[fossa-url]: https://app.fossa.com/projects/custom%2B162%2Fgithub.com%2Fdapr%2Fdapr?ref=badge_shield
[gfi-badge]:https://img.shields.io/github/issues-search/dapr/dapr?query=type%3Aissue%20is%3Aopen%20label%3A%22good%20first%20issue%22&label=Good%20first%20issues&style=flat&logo=github
[gfi-url]:https://github.com/dapr/dapr/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
[discord-badge]: https://img.shields.io/discord/778680217417809931?label=Discord&style=flat&logo=discord
[discord-url]: http://bit.ly/dapr-discord
[youtube-badge]:https://img.shields.io/youtube/channel/views/UCtpSQ9BLB_3EXdWAUQYwnRA?style=flat&label=YouTube%20views&logo=youtube
[youtube-link]:https://youtube.com/@daprdev
[x-badge]:https://img.shields.io/twitter/follow/daprdev?logo=x&style=flat
[x-link]:https://twitter.com/daprdev

Contributing

Comment /assign on this issue if you want to self-assign this issue and update the README.
Don't forget to sign off your commit, for more details see Developer Certificate of Origin (DCO) in the docs.

@ maintainers: Please label this as good first issue.

/assign


HW_4 conda install bamnostic not working as expected

There are environment resolution issues with the current release of Anaconda (circa  4.6.11)(SEE THIS ISSUE), which makes installing bamnostic annoying using the following command:
conda install bamnostic

Suggestions for solving:

Create a virtual environment. This makes resolution easier. See THIS for info.
Downgrade conda. See this StackOverflow post.
Use pip. You can install bamnostic using this command. NOTE: This does not resolve package dependencies and might create headaches later, but it will work.

python3 -m pip install bamnostic

@betteridiot @mitreac
I think this can be marked as resolved. Thoughts?

I think it can.
Thank you Cooper for posting this.


MongoDB Driver Exception in Preview 4

I installed .NET Core Preview 4, startup my app, and received this exception. This is a .NET Core Console Application that is referencing an object in a .NET Standard Library. The types all appear appear in the debugger however the mongo driver throws this exception.
I moved back to .NET Core Preview 3, recompiled, and there is no issue.
System.TypeInitializationException
  HResult=0x80131534
  Message=The type initializer for 'MongoDB.Bson.Serialization.BsonClassMap' threw an exception.
  Source=MongoDB.Bson
  StackTrace:
   at MongoDB.Bson.Serialization.BsonClassMap.LookupClassMap(Type classType)
   at MongoDB.Bson.Serialization.BsonClassMapSerializationProvider.GetSerializer(Type type, IBsonSerializerRegistry serializerRegistry)
   at MongoDB.Bson.Serialization.BsonSerializerRegistry.CreateSerializer(Type type)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at MongoDB.Bson.Serialization.BsonSerializerRegistry.GetSerializer[T]()
   at MongoDB.Driver.MongoCollectionImpl`1..ctor(IMongoDatabase database, CollectionNamespace collectionNamespace, MongoCollectionSettings settings, ICluster cluster, IOperationExecutor operationExecutor)
   at MongoDB.Driver.MongoDatabaseImpl.GetCollection[TDocument](String name, MongoCollectionSettings settings)
   ...

Inner Exception 1:
ArgumentNullException: Value cannot be null.
Parameter name: type

Are you able to compare working and non-working repro side by side to figure out what changed between those 2?
We need to narrow down which API behavior change in .NET Core caused the misbehaior. It is also possibility (albeit small) that it is a bug in the library, or elsewhere ...

I think this be the problem.

MongoDB driver needs a reference to System.Runtime.Serialization.Formatters.

Are you able to compare working and non-working repro side by side to figure out what changed between those 2?
We need to narrow down which API behavior change in .NET Core caused the misbehaior. It is also possibility (albeit small) that it is a bug in the library, or elsewhere ...

I installed .NET Core Preview 4, startup my app, and received this exception. This is a .NET Core Console Application that is referencing an object in a .NET Standard Library. The types all appear appear in the debugger however the mongo driver throws this exception.
I moved back to .NET Core Preview 3, recompiled, and there is no issue.
System.TypeInitializationException
  HResult=0x80131534
  Message=The type initializer for 'MongoDB.Bson.Serialization.BsonClassMap' threw an exception.
  Source=MongoDB.Bson
  StackTrace:
   at MongoDB.Bson.Serialization.BsonClassMap.LookupClassMap(Type classType)
   at MongoDB.Bson.Serialization.BsonClassMapSerializationProvider.GetSerializer(Type type, IBsonSerializerRegistry serializerRegistry)
   at MongoDB.Bson.Serialization.BsonSerializerRegistry.CreateSerializer(Type type)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at MongoDB.Bson.Serialization.BsonSerializerRegistry.GetSerializer[T]()
   at MongoDB.Driver.MongoCollectionImpl`1..ctor(IMongoDatabase database, CollectionNamespace collectionNamespace, MongoCollectionSettings settings, ICluster cluster, IOperationExecutor operationExecutor)
   at MongoDB.Driver.MongoDatabaseImpl.GetCollection[TDocument](String name, MongoCollectionSettings settings)
   ...

Inner Exception 1:
ArgumentNullException: Value cannot be null.
Parameter name: type

I faced the same exception after upgrading to .net 3.0 preview 4 , it was working fine with preview 3

I've the same issue on 3.0 preview 4. Is there any solution?

a fix was done but not yet merged to the master branch nor branch 2.8
https://github.com/mongodb/mongo-csharp-driver/pull/372

Looks like external problem, with solution. Closing.

@mostafa-tag  will the PR be merged in the future?
@ebekker  what did you do to fix the problem?

I believe it should be merged because the fix was made by @KonHhttps://github.com/KonH via a pull request on the master branch .
Mostafa Tag-
From: Malavos<EMAIL_ADDRESS>Sent: Monday, April 29, 2019 6:01 PM
To: dotnet/core<EMAIL_ADDRESS>Cc: Mostafa Tag<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/core] MongoDB Driver Exception in Preview 4 (#2611)
@mostafa-taghttps://github.com/mostafa-tag will the PR be merged in the future?
@ebekkerhttps://github.com/ebekker what did you do to fix the problem?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/core/issues/2611#issuecomment-487638597, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACTHMZJ6EA7FM3WZZW45YFLPS4LULANCNFSM4HHIBL4Q.

@mostafa-tag  thank you. I have also made contact with one of the maintainers of the mongo driver. Let's wait for their input now.

The fix in the PR looks like it will address the issue by referencing the missing Serialization.Formatters package.  For the time being I've reverted back to the preview 3 until the change is officially released in the MongoDB driver -- don't want to mess around with building my version, it would be overkill for my current needs.

I am facing same problem in version 2.8 even i have downgrade project to 2.7.3 problem same but no problem with 2.7.2
What has been there :)


Alert: KubeClientCertificateExpiration in kube-system

Alert KubeClientCertificateExpiration firing in kube-system namespace
This is an automated issue created by the monitoring system. Please do not edit this message.
Alertmanager URL: https://alertmanager.ankhmorpork.thaum.xyz
Issue was last updated at 2023-03-07 16:55:10.046551833 +0000 UTC m=+10061.882513654.
Common Labels

alertname
KubeClientCertificateExpiration

cluster
ankhmorpork

endpoint
https-metrics

job
kubelet

metrics_path
/metrics

namespace
kube-system

prometheus
monitoring/k8s

service
kubelet

severity
warning

Common Annotations

description
A client certificate used to authenticate to kubernetes apiserver is expiring in less than 7.0 days.

runbook_url
https://runbooks.thaum.xyz/runbooks/kubernetes/kubeclientcertificateexpiration

summary
Client certificate is about to expire.

Alerts

instance
node
StartsAt
Links

<IP_ADDRESS>:10250
master01
2023-03-07 16:54:39.211 +0000 UTC
GeneratorURL

<IP_ADDRESS>:10250
node01
2023-03-07 16:54:39.211 +0000 UTC
GeneratorURL

(DO NOT MODIFY: 6bbcd4fca73e868d123f8d6ffef1c184bb9ac96b8c80dfcd5e2aff3e90585d08 )

Fixed in https://github.com/thaum-xyz/ankhmorpork/commit/a5c4f67ca09378da19613718cb38700503f950ab and with rotation of kubeconfig


config: support changed adjust max-background-compactions dynamically

What is changed and how it works?

Issue Number: Close #15424
What's Changed:

Adjust background compaction count when max-background-jobs or max-background-flushes changed

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test

Side effects
Release note
None

/test

/merge


Update num-derive to 0.3

@shravanrn ping? (for this and the other PR)

Ah sorry I missed this. I gather this is to keep things consistent with upstream versions?

Yeah, mostly to get rid of old duplicated dependencies in Firefox.

Thanks!


Code workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: basneta2 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Weird colors with ggpush Git alias command.

Hi, I have a strange issue with ggpush Git alias command. Can someone help me to fix this?

What are the value of $ZSH_HIGHLIGHT_PATCHLEVEL and the definition of the alias?

The alias is defined with:
ggpush='git push origin "$(git_current_branch)"'

How can I get the value of $ZSH_HIGHLIGHT_PATCHLEVEL? Sorry, I don't know much about it.

Just print/echo it.
Could you provide minimal reproduction instructions under zsh -f without external dependencies?  If not: what file is the alias defined in?


Error "Account used is not a delegated administrator" deploying from Root SSO account with Admin permissions

I'm trying to deploy a new StackSet to update the IAM Password Policy for all accounts in an OU.
To do this in CDK I'm using AwsCustomResource. This is working fine.
I'm deploying from my root SSO Organization account with AdministratorAccess permissions.
The error I'm receiving is:
iamPasswordPolicy: creating CloudFormation changeset...
4:40:08 PM | CREATE_FAILED        | AWS::CloudFormation::StackSet | stackSetDeployment1DF54B12
Resource handler returned message: "Account used is not a delegated administrator (Service: CloudFormation, Status Code: 400, Request ID: 57ae54e8-3979-40eb-af62-50c7f9d3d757)" (RequestToken: 1
baaf93e-54e8-ad5d-e589-4ec6221d27ee, HandlerErrorCode: InvalidRequest)

My fully code is here:
import {
  Stack,
  StackProps,
  custom_resources as cr,
  aws_iam as iam,
} from 'aws-cdk-lib';
import * as cf from 'cdk-stacksets';
import { Construct } from 'constructs';

export class IamPasswordPolicyStack extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    const stackSet = new cf.StackSetStack(this, 'stackSet', {});

    const lambdaRole = new iam.Role(this, 'lambdaRole', {
      assumedBy: new iam.ServicePrincipal('lambda.amazonaws.com'),
      managedPolicies: [
        iam.ManagedPolicy.fromAwsManagedPolicyName('IAMFullAccess'),
      ],
    });

    new cr.AwsCustomResource(this, 'updateIamPasswordPolicy', {
      role: lambdaRole,
      onUpdate: {
        service: 'IAM',
        action: 'updateAccountPasswordPolicy',
        parameters: {
          AllowUsersToChangePassword: true,
          HardExpiry: false,
          MaxPasswordAge: 90,
          MinimumPasswordLength: 18,
          PasswordReusePrevention: 24,
          RequireLowercaseCharacters: true,
          RequireNumbers: true,
          RequireSymbols: true,
          RequireUppercaseCharacters: true,
        },
        physicalResourceId: cr.PhysicalResourceId.of('AccountPasswordPolicy'),
      },
    });

    new cf.StackSet(this, 'stackSetDeployment', {
      target: cf.StackSetTarget.fromOrganizationalUnits({
        regions: [this.region],
        organizationalUnits: ['ou-9124-XXXXXXXXX'],
      }),
      capabilities: [cf.Capability.NAMED_IAM],
      deploymentType: cf.DeploymentType.serviceManaged(),
      template: cf.StackSetTemplate.fromStackSetStack(stackSet),
    });
  }
}

I found a solution for this.
Change:
deploymentType: cf.DeploymentType.serviceManaged(),
to:
deploymentType: cf.DeploymentType.serviceManaged({ delegatedAdmin: false }),
Without delegatedAdmin: false, it will generate CF with CallAs set to SELF.
More information:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-stackset.html#cfn-cloudformation-stackset-callas
https://github.com/cdklabs/cdk-stacksets/blob/7c1a774aa05a09294d5f53c2368176b193da25d5/src/stackset.ts#L300

I found a solution for this. Change: deploymentType: cf.DeploymentType.serviceManaged(), to: deploymentType: cf.DeploymentType.serviceManaged({ delegatedAdmin: false }),
By default delegatedAdmin is true and it will generate CF with CallAs set to DELEGATED_ADMIN. With false CallAs will be SELF.
More information: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudformation-stackset.html#cfn-cloudformation-stackset-callas
https://github.com/cdklabs/cdk-stacksets/blob/7c1a774aa05a09294d5f53c2368176b193da25d5/src/stackset.ts#L300

That was the issue!
Thank you so much @siipimutteri!
I will close the Issue!


Caching downloaded charts

Caching downloaded charts
Introduces a caching mechanism for chart downloads (#4618).
Current design
Charts are mainly downloaded via downloader.ChartDownloader.DownloadTo() which:

Resolve a chart URL from a "chart reference" - either a repo ref. (i.e. repo/chart) or a URL ref (i.e. https://charts.io/chart-0.0.1.tgz)
Downloads the chart archive and its provenance file (if needed)
Stores the downloaded files at a specific path
Depending on the "verification strategy", verify the chart provenance

This feature is used in:

helm install (locate chart & download dependencies)
helm pull (download chart)
helm dependency build (download dependencies)
helm dependency update (download dependencies)
helm package (download dependnecies)
helm show (locate chart)
helm upgrade (locate chart)

Some of these usages already use the concept of a charts cache by storing the chart files either in the repository cache dir or a temporary directory.
The reason is either the (a) need of an intermediate validation step between fetching and storing the chart archive on the destination or (b) the convenience of passing around a file path between parts of the process.
Proposed design
The proposed design introduces a HELM_CHART_CACHE which (a) serves as permanent workinig directory for working with downloaded chart files during a single operation, and (b) can be safely persisted and reused among subsequent operations.
The API downloader.ChartDownloader.Fetch() is introduced. This API is responsible for iimplementing caching semantics for chart downloads, and works as follow:

Resolves a chart URL.
Downloads chart archive and provenance file (if needed) - only if they are not cached.
Stores the downloaded files at HELM_CHART_CACHE.
Depending on the "verification strategy", verify the chart provenance.

Chart caching is enabled by default and required (i.e. can't be disabled). Cache invalidation is out of scope.
Implementation details
Downloaded chart archives and provenance files are stored in HELM_CHART_CACHE under a path that is intended to be human readable and uniquely identify a chart URL in a given repo.
Charts from the same repo have a parent dir in commmon, and so do charts from the same base URL. Consequently, cache is automatically invalidated when the repo name or the chart URL change. Preserving the cache in those cases breaks the user's expectation of using charts from the repo's configured base URL - and even represent a security vulnerability.
As an example, consider a repo named foo is added with a base URL https://charts.io/.

https://charts.io/chart-0.0.1.tgz is cached at HELM_CHART_CACHE/foo/4bb376a04a641ae55541c36d073705c6d2bb7e35/chart-0.0.1.tgz
https://charts.io/chart-0.1.0.tgz is cached at HELM_CHART_CACHE/foo/4bb376a04a641ae55541c36d073705c6d2bb7e35/chart-0.1.0.tgz
https://charts.io/another-0.1.0.tgz is cached at HELM_CHART_CACHE/foo/4bb376a04a641ae55541c36d073705c6d2bb7e35/another-0.1.0.tgz

Charts from an unknown repo are stored under HELM_CHART_CACHE/-/.
If the user changes that repo name to bar, preserving the base URL https://charts.io/, the cache path changes:

https://charts.io/chart-0.0.1.tgz is cached at HELM_CHART_CACHE/bar/4bb376a04a641ae55541c36d073705c6d2bb7e35/chart-0.0.1.tgz
https://charts.io/chart-0.1.0.tgz is cached at HELM_CHART_CACHE/bar/4bb376a04a641ae55541c36d073705c6d2bb7e35/chart-0.1.0.tgz
https://charts.io/another-0.1.0.tgz is cached at HELM_CHART_CACHE/bar/4bb376a04a641ae55541c36d073705c6d2bb7e35/another-0.1.0.tgz

If the bar repo later changes its base URL to https://new.charts.io/, the cache path changes:

https://charts.io/chart-0.0.1.tgz is cached at HELM_CHART_CACHE/bar/3262d0eae5c54b51ee1d5389d4d7567afd385ed3/chart-0.0.1.tgz
https://charts.io/chart-0.1.0.tgz is cached at HELM_CHART_CACHE/bar/3262d0eae5c54b51ee1d5389d4d7567afd385ed3/chart-0.1.0.tgz
https://charts.io/another-0.1.0.tgz is cached at HELM_CHART_CACHE/bar/3262d0eae5c54b51ee1d5389d4d7567afd385ed3/another-0.1.0.tgz

Future improvements

Concurrently fetch charts from a lockfile.
Implement a --no-cache feature to disable chart caching for an operation.

Open questions

Does the current proposal breaks any of the user's expectations?

For example, is helm pull semantics to always download a chart? Does the user expect it to fail if there's no connectivity but the chart is already cached?

cc/ @bacongobbler

Unsure why the naked return is now a problem, as it was already there.

I have a couple of questions about the design.
Is this concurrency safe, either from the CLI or API?  What happens if two processes or go routines fetch the same chart at the same time?
What happens if a chart in a museum is overwritten with a new version?  The chart museum options explicitly allow this behavior, and I don't see how this proposal would support that.  Is there a mechanism where helm requests the digest before assuming that its cached version is still valid?
Is there a cache purging mechanism?  While it's true that charts are generally small, my particular use-case works with umbrella charts, which compose many charts into one.  These are currently around 250kb compressed, and we generate several a day (3-4).  I don't want to pretend that over the course of a year, 250MB is a lot of used space in a CI/CD system, but it also appears that it's unrecoverable space.
You state that the cache path should be human-readable, but also share example paths that have GUIDs.  What is that GUID, and how do I understand what I'm looking at if I'm manually going through the directory structure?
I like caching (enough that I've implemented a similar mechanism for chart tarballs in a personal project), but along with off-by-one errors, it's one of the three most difficult CS problems.  I don't want to dissuade you from this effort (especially as someone who's not a part of the helm team), it's just tricky.

Hi @object88, thanks for bringing up these points. I'll answer them inline.

Is this concurrency safe, either from the CLI or API? What happens if two processes or go routines fetch the same chart at the same time?

The caching mechanism does not provide fewer guarantees than helm currently does for concurrent writes: files are atomically stored on disk via fileutil.AtomicWriteFile and last writer wins.
Note that this guarantee is not even consistently provided across all file downloads in helm - AFAICT the repos index files are not safe for concurrent write: https://github.com/helm/helm/blob/82f739072cb3c94f26e3103e4524a1f74526342d/pkg/repo/chartrepo.go#L152
If your concern is regarding concurrent reads and writes, this does not seem to be a guarantee currently provided by helm either. helm install for example, does not seem to be safe in those cases since concurrent routines share the same temporary destination of archives: https://github.com/helm/helm/blob/82f739072cb3c94f26e3103e4524a1f74526342d/pkg/action/install.go#L669
The same seems to be true for concurrently running helm update and any other operation that makes use of the cached repo index.
For this reason, I believe this concern is out of scope for an initial take on chart caching.

What happens if a chart in a museum is overwritten with a new version?

That's is a good point. This is not supported in the current implementation because it seems to be the exception, not the rule: overwriting the content of a versioned artifact without changing its version is usually not a good practice. For simplicity, I would be more inclined to solve this by having some mechanism to disallow caching for these repos over relying on using response headers and additional roundtrips to determine freshness.

What is that GUID, and how do I understand what I'm looking at if I'm manually going through the directory structure?

That is a digest of the archive base URL and is used as the cache key. See the examples I provided for cases of why it is useful. Regarding your concern with storage, something similar already happens with helm install: chart archives are already stored in the repository cache dir and there is no cache eviction strategy AFAICT.
I acknowledge that caching is hard, and having a comprehensive complex implementation makes it even harder. For this reason, my goal was to come with a minimal implementation that might work under the 80/20 rule.
Hopefully, we can land on an initial implementation that is simple enough and can reach beta status (disabled by default) to solve 80% of the use cases.

Any news on this PR ?

Any news on this PR ?

Most likely the submitter doesn't want to spend even more time going through all sorts of discussions/design-doc-phases before a PR can be reviewed.

https://github.com/helm/community/pull/185

Closing this; there’s an open improvement proposal where the design is being reviewed closely before looking at physical implementations. I’d suggest taking a look at helm/community#185 and provide feedback there before we look at implementations. We’re trying to solve this for more than just the chart cache.


cargo config list/set/get command

hello, I want the feature  get config, set, list all config with cargo.
The idea come from golang ,  git cli
for example
> git config --list
diff.astextplain.textconv=astextplain
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
filter.lfs.process=git-lfs filter-process
filter.lfs.required=true
http.sslbackend=openssl
http.sslcainfo=C:/Program Files/Git/mingw64/ssl/certs/ca-bundle.crt
core.autocrlf=false
core.fscache=true
core.symlinks=false
core.longpaths=true
pull.rebase=true
credential.helper=manager-core
credential.https://dev.azure.com.usehttppath=true
init.defaultbranch=master
user.name=david
<EMAIL_ADDRESS>gc.autodetach=false
http.https://github.com.proxy=http://localhost:8123
http.https://github.com.sslverify=false
http.https://fuchsia.googlesource.com.proxy=http://localhost:8123
http.https://fuchsia.googlesource.com.sslverify=false
difftool.sourcetree.cmd='' "$LOCAL" "$REMOTE"
mergetool.sourcetree.cmd=''
mergetool.sourcetree.trustexitcode=true
core.longpaths=true
PS C:\WINDOWS\system32> git config --global user.name "xxx"

The cargo has it's configure also, but where is it ?
can we easy to know what's current configure, I f we changed some configure, how do we know it works.
The git command will show exactly result, yes , we change our configure , then git config --list
I hope cargo has the same ability.
tell me more about the configuration.

A cargo config command was added in #9302, all though I am not seeing the stabilization plan at the moment.

Yes, this command should be available in the latest nightly.  I updated the tracking issue #9301 with some details, and closing in favor of that.


Not able to set a locale or redirect to specific locale from the server in a middleware or plugin.

Environment

Operating System: Linux
Node Version:     v18.15.0
Nuxt Version:     3.7.4
CLI Version:      3.9.1
Nitro Version:    2.7.0
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools, app, modules, i18n, runtimeConfig
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
Install Nuxt i18n, try to call setLocale in Nuxt plugin our middleware.
Describe the bug
It seems like I cannot set a locale or redirect to specific locale from the server in a middleware or plugin.
$i18n.switchLocalePath()
$i18n.setLocale( localeCookie.value )
Nitro error:
[nitro] [unhandledRejection] Error: [nuxt] A composable that requires access to the Nuxt instance was called outside of a plugin.
Tested in both middleware and plugin.
Additional context
No response
Logs
No response

I am unable to proceed with testing my actual bug due to the apparent malfunction of the basic language switcher.
Please refer to my attempted reproduction steps.
https://stackblitz.com/edit/github-m2j2vu?file=nuxt.config.ts

Your reproduction doesn't have any pages, so there's no page for switchLocalePath to return. I modified your reproduction here to demonstrate, if there are no pages vue-router won't be included as a dependency by Nuxt (see docs).

Same happens for me when calling setLocale in middleware like this:
export default defineNuxtRouteMiddleware(async (to) => {
    const {$i18n} = useNuxtApp();
    const userLocaleFromBackend = 'en';

    await $i18n.setLocale(userLocaleFromBackend);
});

Using Nuxt 3.9.0.
8.0.0-rc.7 ✅ (Works fine for me)
8.0.0-rc.8 ✅ (Works fine for me)
8.0.0-rc.9 ❌ (Starts to fail)
8.0.0-rc.10 ❌
8.0.0-rc.11 ❌
8.0.0 ❌

setting experimental: {asyncContext: true} is a possible solution

I took some time to investigate the issue.
The problem is that setLocale asynchronously calls detectRedirect which uses the useNuxtApp hook.  So calling it in anything on server that triggers the async code can cause problems (e.g. waiting for an API call and then setting the locale based on the result of that call).

It's still unclear what the expected behaviour is, and without a minimal reproduction I can only guess what's going on.
If you're trying to change the locale in a route middleware, you're best off using a redirect from the middleware using switchLocalePath.

https://stackblitz.com/edit/nuxt-starter-i64ji9?file=plugins%2Fi18n.ts reproduction from my use-case

@ucw
Thanks for the reproduction, I think I know what's causing this issue and how to fix it (#2777 didn't fully resolve this). Will likely have a fix ready this week.

@ucw
The issue in your reproduction should be resolved in the latest edge release, I modified your reproduction to demonstrate here.
Can you try installing the edge version in your project and confirm if this resolves the issue for you?

@BobbieGoede I checked my project with edge version, everything works fine. Thank you for your work!

@ucw that's great to hear! I just published v8.1.1 which includes these changes.
I'll close this issue now, if anyone else is still experiencing this or a similar problem, please open a new issue with a (minimal) reproduction.


Adding Outlook Notifications REST API with ASP.NET Web API sample

This is a sample of an ASP.NET Web API project validating and responding to Outlook Notifications - created with the Outlook Notifications REST API.

Hi @simonjaeger, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thx Simon, we'll have a look on this during upcoming days. Looks good as a first glance.

Hi Simon,
Thanks for your submission! I've inspected the code and things are fine if you only focus on the webAPI part. However if someone wants to try this they'll already need to fully understand the notifications model: would it be possible to add a simple UI that the user can use to register the notification. Once this is there the sample can be 'tested' by simply registering the app in Azure AD.
I'm happy to add these changes if you don't have time, but would be great if you could do this as well :-)
Regards,
Bert

Bert,
Thank you for your inspection! I'll get to it and add the UI part once I find some spare time.
Cheers,
-Simon

Excellent! Let me know if you need my help.

I've added UI now for registering notification subscriptions to the sample! Thanks for the feedback!

Super :) I'll have a look at this PR in the coming days.

Thx Simon, looks really valuable and helps people to understand how this can be done in practice. Looks absolutely potential candidate as a demo in the February monthly community call.

Nice sample Simon!
There is one key concept that is missing, IMO. The notification payload has only the Id of the item causing the notification. Typically, the consumer of the notification would need to inspect the item, which requires a call back to the graph, which requires a token.
I would be happy to extend the sample to include the token acquisition based on a persisted refresh token. Is that already in progress? Or already in a different part of PnP? (That last one may be a question for @jansenbe or @VesaJuvonen ...)

Thanks Paul! I took the time to implement this... phew. I appreciate the feedback.

Thanks guys. I'll get the sample included in PnP in the coming days! Keep up the good work :-)

Merged. Not sure why it's not automatically listed as merged...so I'll close the PR manually.
Great work Simon!

Thanks guys!