notifying of build result

When Bamboo finished a build and deploy it would be nice to receive a mention when it is complete as having channel notification on can lead to notification spam due to other people using the tool.
I did a quick proof of concept and in my testing environment and changing the notifications to adaptive cards should do the trick using code something like this:
{     type: "message",     attachments: [       {         contentType: "application/vnd.microsoft.card.adaptive",         content: {           type: "AdaptiveCard",           body: [             {               type: "ColumnSet",               columns: [                 {                   type: "Column",                   width: 0.5,                   items: [                     {                       type: "Image",                       url: "https://static.thenounproject.com/png/2714806-200.png",                       size: "Medium",                     },                   ],                 },                 {                   type: "Column",                   width: 3,                   items: [                     {                       type: "TextBlock",                       text: "Bamboo build and deploy job finished",                       wrap: true,                       fontType: "Default",                       size: "Medium",                     },                     {                       type: "TextBlock",                       text: triggered by ${input.triggeredBy.name},                       wrap: true,                     },                     {                       type: "TextBlock",                       text: ${input.triggeredBy.name},                       wrap: true,                     },                   ],                 },               ],             },           ],           $schema: "http://adaptivecards.io/schemas/adaptive-card.json",           version: "1.0",           msteams: {             entities: [               {                 type: "mention",                 text:  ${input.triggeredBy.name},                 mentioned: {                   id: input.triggeredBy.id,                   name: input.triggeredBy.name,                 },               },             ],           },         },       },     ],   }
Let me know what you think of the idea as I am happy to assist with implementation :)

That's right @RussellMaggs , AdaptiveCard will be the one if we want to notify a user. But the thing is to be able to mention someone in an AdaptiveCard message, we have to provide the raw user id which is the staff email address in our case, but the one we have in the outgoing webhook request is the hashed one. I'll do more research to see how we can get around this issue, but feel free to ping me if you find something, thanks.

@GaaraZhu I did a quick check on my lunch break and your right the id we get from the outgoing webhook is not the id we would need to tag somebody.
I did find this thread where you can potentially do some API calls here to get the user id and then have a id like 8:orgid:{org-ID-of-the-user} but I think this solution would add significant complexity for such a small feature.
If you can't find any superior solution I am happy for you to close this issue and I will just create a private instance to side step the issue completely

@RussellMaggs all supported mention approaches can be found here: https://learn.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/cards/cards-format?tabs=adaptive-md%2Cconnector-html#mention-support-within-adaptive-cards-v12. I think by design outgoing webhook is limited only to receive and send messages which is not as complicated/powerful as bots, hence from the outgoing messages we won't be able to get any identity information like ID or UPN which we can use in a mention. Anyway I think I'll just close this issue for now, but thanks for the investigation:)


Error when trying to sell

Describe the bug
Error contract.counter_in_the_past.
To Reproduce
Cannot reproduce reliably but this is what I did before getting the error.
Steps to reproduce the behavior:

Open one of the markets in https://f1-prediction-market.vercel.app/.
Buy a few tokens and wait for transaction to be processed.
Buy some tokens again.
Quickly try sell some tokens from your existing balance.
See error

Expected behavior
Transaction for sell to succeed of show more meaningful error.
Screenshots

Desktop (please complete the following information):

OS: macOS 11.5.2
Browser: Chrome 93
Version: not sure where it's displayed, error happened around 2021-09-16 13:28 BST

Additional context
Add any other context about the problem here.
Perhaps depends on activity of other users buying/selling concurrently around the same time?

this is an issue with how tezos handles transactions. If previous transactions have not yet been posted to a block you are unable to send a new transaction.


What version of Nao-meshes for indigo should be used?

Hi,
Thanks for this project as it has been extremely helpful to me? I have managed to get it working for the most part but I am getting an error with the NAO meshes package with gazebo and I think it is because the meshes package for indigo has been updated more recently than this project, I was wondering if you could confirm for me what version of the NAO meshes package does this simulation work with?
Cheers.

hi,
If I remember correctly we were including our own copy of the meshes in the robocup3ds package. The ros-*-nao-meshes package is not used. This solution is far from optimal but it was an easy way to have blue and red meshes for the players. What is the error that you're getting?

ah ok, that makes sense, the error I'm encountering must be being caused by something else then. I use the quick install script and install ros desktop as the roscore option is missing from the quick script installation. Everything else is there though. Once installed and I have gazebo running I attempt to run spawnTeams and the following error appears in the gazebo terminal and the players in gazebo, while created, do not work optimally when proceeding with other commands

, it has something to do with the soccer sdf file i think, any input would be appreciated.
Thanks

By the way, we moved this project to bitbucket and made a lot of improvements there. Could you give it a try? It should work much better.


Add rrtop sample

An example of a UI like the rrtop program with fake data.
I don't think this is an ideal example from an architectural point of view, but from the point of view of the different capabilities of mosaic at the moment it seems good.
An idea from https://github.com/JakeWharton/mosaic/issues/316

A few screenshots (but it's better to try it yourself)

This is absolutely amazing. I have done a cursory review and it looks great. Going to merge as-is!


Failure when running YCSB with VALUE_PARAMETER supported

This is trying to resolve #1382, which turns out to be a just a broken test.
Overview:

Trying to run oltpbench (specifically YCSB), with codegen.
Enabled VALUE_PARAMETER, so we can get codegen to handle preparated statements
Experimental code to support JDBC marshaling of binary types

What works:

YCSB with 100% read workload, runs. Have not tried long runs. Short runs are fine.

Unit test to trivially exercise binary marshaling of SELECT statements, runs (fails without above changes).

YCSB with normal mix, fails, when trying to compile an UPDATE plan.
Master (as of approx. 7 June 2018)
With modified query_compiler.cpp

--- a/src/codegen/query_compiler.cpp
+++ b/src/codegen/query_compiler.cpp
@@ -124,7 +124,6 @@ bool QueryCompiler::IsExpressionSupported(
const expression::AbstractExpression &expr) {
switch (expr.GetExpressionType()) {
case ExpressionType::STAR:

case ExpressionType::VALUE_PARAMETER:
return false;

Peloton fails with:
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/executor/plan_executor.cpp:60:CompileAndExecutePlan] INFO  - query not in cache - compiling
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/executor/plan_executor.cpp:61:CompileAndExecutePlan] INFO  - UpdatePlan
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/codegen/lang/vectorized_loop.cpp:37:~VectorizedLoop] ERROR - You didn't call lang::VectorizedLoop::LoopEnd()!
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/codegen/function_builder.cpp:139:~FunctionBuilder] ERROR - Missing call to FunctionBuilder::ReturnAndFinish() for function '_18_pipeline_0_serialWork_seqscan_update_output'
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/codegen/function_builder.cpp:139:~FunctionBuilder] ERROR - Missing call to FunctionBuilder::ReturnAndFinish() for function '_18_plan'
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/executor/plan_executor.cpp:210:ExecutePlan] ERROR - Error thrown during execution: Attribute '' is not an available attribute
2018-06-07 14:05:17 [/home/proj/pa_ss/peloton/src/network/postgres_protocol_handler.cpp:824:ExecExecuteMessageGetResult] ERROR - Failed to execute: Attribute '' is not an available attribute

It continues, but eventually segfaults.
I make no claim that the marshaling code is bug free. It has not been reviewed or systematically tested. IMO it should ideally be up in the network layer, but this was just an attempt to get codegen, sequential scans and prepared statements to co-exist.

Code may be found in my  prepstmt_seq_scan from
https://github.com/pervazea/peloton.git

To recap:

running YCSB
using a branch with a quick and ugly fix for binary marshaling. The JDBC driver switches from text marshalling to binary marshalling after 5 invocations of a particular prepared statement.
problem appears to be in an update statement.  Fails with

2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/codegen/lang/vectorized_loop.cpp:37:~VectorizedLoop] ERROR - You didn't call lang::VectorizedLoop::LoopEnd()!

Prior to this.. the log looked like:
2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/network/postgres_protocol_handler.cpp:372:ExecParseMessage] INFO  - PrepareStatement[S_6] => SELECT * FROM USERTABLE where YCSB_KEY=$1 FOR UPDATE^M
2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/executor/plan_executor.cpp:73:CompileAndExecutePlan] INFO  - query found in cache^M
2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/executor/plan_executor.cpp:77:CompileAndExecutePlan] INFO  - execute query^M
2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/executor/plan_executor.cpp:85:CompileAndExecutePlan] INFO  - process query results^M

** this is probably the culprit
S_7 is the first "named" update statement  (5th one)

2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/network/postgres_protocol_handler.cpp:325:ExecParseMessage] INFO  - S_7, UPDATE USERTABLE SET FIELD1=$1,FIELD2=$2,FIELD3=$3,FIELD4=$4,FIELD5=$5,FIELD6=$6,FIELD7=$7,FIELD8=$8,FIELD9=$9,FIELD10=$10 WHERE YCSB_KEY=$11
2018-06-11 10:18:24 [/home/proj/pa_ss/peloton/src/network/postgres_protocol_handler.cpp:372:ExecParseMessage] INFO  - PrepareStatement[S_7] => UPDATE USERTABLE SET FIELD1=$1,FIELD2=$2,FIELD3=$3,FIELD4=$4,FIELD5=$5,FIELD6=$6,FIELD7=$7,FIELD8=$8,FIELD9=$9,FIELD10=$10 WHERE YCSB_KEY=$11

In UpdatePlan::Performbinding:
  auto *scan = static_cast<planner::AbstractScan *>(children[0].get());
  auto &col_ids = scan->GetColumnIds();
  for (oid_t col_id = 0; col_id < col_ids.size(); col_id++) {
    ais_.push_back(input_context.Find(col_id));
  }

We set ais_  with column attribute information. In the case in question, i.e. when JDBC switches to binary mode and tries to be smart about prepared statements, we get the follow behaviour:

We go through and set attribute information in ais_
When we switch to binary mode, we find that ais_ is already set. However, we go through this path again, and set more attributes.

In a test run with YCSB, the table has 11 columns. First time through:
  update_primary_key_ = false,
  ais_ = std::vector of length 11, capacity 16 = {0x6180000cbc80,
    0x6180000cbcb8, 0x6180000cbcf0, 0x6180000cbd28, 0x6180000cbd60,
    0x6180000cbd98, 0x6180000cbdd0, 0x6180000cbe08, 0x6180000cbe40,
    0x6180000cbe78, 0x6180000cbeb0}

Second time... table has ais_ already set, we set another 11 attributes, to produce:
  ais_ = std::vector of length 22, capacity 32 = {0x618000095c80,
    0x618000095cb8, 0x618000095cf0, 0x618000095d28, 0x618000095d60,
    0x618000095d98, 0x618000095dd0, 0x618000095e08, 0x618000095e40,
    0x618000095e78, 0x618000095eb0, 0x61c00008d880, 0x61c00008d8b8,
    0x61c00008d8f0, 0x61c00008d928, 0x61c00008d960, 0x61c00008d998,
    0x61c00008d9d0, 0x61c00008da08, 0x61c00008da40, 0x61c00008da78,
    0x61c00008dab0}

At this point things break.
In postgres_protocol_handler.cpp, approx. line 808, the function ExecExecuteMessage appears to do some statement caching for JDBC.  (getting and setting the statement from portal_).
Unsure of the right behavior, but a couple of thoughts:

If we are keeping the plan around, with ais_ having been correctly set, we should not add to the attribute information.
A much less desirable approach would be to clear ais_ and allow it to be re-initialized.

PLTestBase.java.txt
UpdateTest.java.txt

In today's Peloton meeting, Prashanth's assertion was that re-binding on the cached plan was not required.


Adding AWS Chatbot to stack and added GRAPHQL_ENDPOINT environment variable

This is my stab at adding AWS Chatbot to the Cloudformation template, as well as adding an environment variable, GRAPHQL_ENDPOINT, for the frontend.

ChatbotSnsTopic

Thanks @briri. I changed the ConfigurationName to be dynamic.
One thing that I still have to figure out is that the GRAPHQL_ENDPOINT value is not being found. Will have to research how I can add the correct value so that it can be found by process.env

Actually, I just updated the Dockerfile in my frontend app to include the env variable instead of trying to set it in the Cloudformation template, and that worked.
@briri I noticed that even though the Cloudformation template is adding a chatbot client, it appears to be adding several SNS topics, but I think we just need one:

Interesting. Those might be leftover from the one you created via the console.
One way to find out would be to delete the cloud formation stack which will delete all of the associated resources. Once you've done that, we can then clean out any chatbot SNS topics, IAM Roles/Polices,  and the chatbot itself that were created via the console.

Interesting. Those might be leftover from the one you created via the console.
One way to find out would be to delete the cloud formation stack which will delete all of the associated resources. Once you've done that, we can then clean out any chatbot SNS topics, IAM Roles/Polices, and the chatbot itself that were created via the console.

Actually the AWS Chatbot guidelines say that we first have to do some configuration in the AWS Console, which I did. But I can remove the chatbot Cloudformation stack and the SNS topics and IAM Roles/Policies and run the sceptre commands again to see what I get.

@briri  - Ok, I deleted all the chatbot configurations, and ran the sceptre create command for chatbot again, and I get two SNS topics:

The reason this is happening is because of this code in chatbot.yaml:

I believe we only need the "!GetAtt ChatbotSnsTopic.TopicArn" topic. What do you think?

Ok. Did you have to create a CodeStar connection so that slack could communicate with Slack? CodeStar connections have to be created manually in the console. I didn't notice initially that one mentioned CodeStar

Ok. Did you have to create a CodeStar connection so that slack could communicate with Slack? CodeStar connections have to be created manually in the console. I didn't notice initially that one mentioned CodeStar

I didn't have to create a CodeStar connection when I created the channel in the Slack workspace in the AWS Console. So maybe we don't need it?


enable to fetch thumbnailer preview

These codes are my attempts, and the previews can be obtained and used most of the time, especially when the network conditions are good. However, sometimes they cannot be obtained. I'm not sure if it's an issue with vlckit. I've already applied these codes to my product. You can take these codes as a reference. Once again, thank you for your generous and selfless open sourcing of VLCUI!

The key to the code is that a new instance of VLCMediaThumbnailer needs to be created each time a preview is fetched. If you only create one instance and then call fetchThumbnail(), it will work the first time but will timeout on subsequent calls.


Looking to add a quick image command! :D

Hey friendos,
My buds and I on our server were hoping to have a command to end arguments, something like !endall linking to the attached image. Think we could get that?
Much love!

You can now safely end all arguments with Gravebot, enjoy. :smiley:
!endall


full set boosts

🚀 Feature Proposal
Describe the feature you're suggesting here, give lots of information and describe it as best you can. Please check that the feature hasn't already been suggested first, by searching the issues in this repository.
making it so that by adding a arma helm if your waring a arma chest and legs it gives you a boost so you can either kill more in the same time or reduce the time it takes to kill the bosses.
because i just feel at this point in time there is no use for a range helm unless doing fight caves

Full set boosts for something like arma doesn't make a whole lot of sense, but - a point for wearing stuff like this is coming very soon with food requirements and speed increases from gear.


Flag is no updated after changing phone with set(phoneNumber: String)

By default I have American flag set, but when I change phone to my Belarussian phone with set(phoneNumber: String), flag doesn't changes (though phone changes properly and code accepted fine):

Fortunately, it is easy to fix - seems like all one need to do is to add setFlag(with: phoneUtil.getRegionCode(for: parsedPhoneNumber)) to CTKFlagPhoneNumberTextField.swift around 142 line. If required, I can make a fork and submit possible fixes via pull requests.

So I'm waiting your pull requests :)


Plugin with id 'com.suparnatural.kotlin.graphql' not found.

Describe the bug
I migrated to maven central but throw plugin not found
Stacktrace
org.gradle.internal.exceptions.LocationAwareException:
Plugin with id 'com.suparnatural.kotlin.graphql' not found.
Version
1.0.12
Platforms affected:

iOS [ ]
Android [ ]
JVM [ ]
JS [ ]

Additional context
Add any other context about the problem here.

Looking at it.

The plugin is published on the repository under artifact id graphql-plugin. Not sure if the plugin id needs to match with it somehow or if it requires some handling in the settings.gradle.

@suparngp I imported classpath as jar file but it has issue yet.

Just got the email that the plugin is approved.
https://plugins.gradle.org/plugin/com.suparnatural.kotlin.plugins.graphql

Just got the email that the plugin is approved.
https://plugins.gradle.org/plugin/com.suparnatural.kotlin.plugins.graphql

Please change the documentation that it's not "com.suparnatural.plugins.graphql" but "com.suparnatural.kotlin.plugins.graphql"
And (for me) it's only working with "com.suparnatural.kotlin:graphql-plugin:1.0.13" not with 1.0.12


Please support watch.angelstudios.com (Angel Studios)

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running youtube-dl version 2021.06.06
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that none of provided URLs violate any copyrights
[X] I've searched the bugtracker for similar site support requests including closed ones

Example URLs

Single video: https://watch.angelstudios.com/thechosen/watch?vid=S1:E1
Single video: https://watch.angelstudios.com/thechosen/watch?vid=S1:E2

Description
Videos are freely available from the studio creator of those videos (Angel Studios).  Also available are captions in dozens of languages.

I am confused also as it looks like @zaitseff  followed the template (even better than many others). I just added the current output error message.

This was added to yt-dlp ... i know some code is ported over.....
Main item:
https://github.com/yt-dlp/yt-dlp/pull/4410
https://github.com/yt-dlp/yt-dlp/issues/1243


Create and deploy new prompt format

See https://github.com/dust-tt/decisions/issues/177

The idea is to move to the new format right away


Publish status update early July

We've been having conference calls to communicate status and request feedback. We are due to update our status this week. Instead of a conference call, let's record a video.

I think that we should produce videos on the following topics:

[ ] Long Term Storage (Blob) using .NET EventProcessor, validated with Hive query
[ ] Long Term Storage (Blob) using Azure Stream Analytics, validated with Hive query
[ ] Warm Data Aggregation using Azure Stream Analytics and Azure SQL DB
[ ] Warm Data Adhoc Exploration using .NET EventProcessor and Elasticsearch/Kibana
[ ] Example Elasticsearch cluster in Azure

This looks good.

I will do 1,2,4, and 5 easily. Someone else could record #3, as I'm less familiar with that codebase. Otherwise, it will be a forcing function for me to get familiar.

This sound reasonable.

Once the first videos are posted, we should like to https://channel9.msdn.com/Blogs/mspnp on the project readme.

First Video: https://channel9.msdn.com/Blogs/mspnp/IoT-Journey-Long-Term-Storage-using-Azure-Stream-Analytics

Second Video:  https://channel9.msdn.com/Blogs/mspnp/IoT-Journey-Long-Term-Storage-using-a-Custom-Event-Processor

:+1:

Third Video: https://channel9.msdn.com/Blogs/mspnp/IoT-Journey-Warm-Data-Ad-Hoc-Exploration-with-Elasticsearch-and-Kibana

Fourth Video: https://channel9.msdn.com/Blogs/mspnp/IoT-Journey-Example-Elasticsearch-Cluster-in-Azure

@lbrader mentioned he was interested in recording:  "Warm Data Aggregation using Azure Stream Analytics and Azure SQL DB"
Assigning to Larry.

@lbrader please follow the format and approached established by Francis. Can you provide an ETA?

@bennage, definitely interested.  I'll start working on this tomorrow, when i'm back in.

Fifth Video: https://channel9.msdn.com/Blogs/mspnp/IoT-Journey-Warm-Data-Aggregation-using-Azure-Stream-Analytics-and-SQL-DB


dragging columns into gutter causes issues with horizontal scroll

You can get stuck when scrolling to the right to columns off the screen.
When dragging a column,
1- drop said column into the column for row numbers (accidentally I guess, one too far to the left),
2- scroll all the way to the right
3- attempt to scroll back to the left will fail with the error below.
Uncaught TypeError: Cannot read property 'title' of undefined
    at drawHeaderRow (canvas-datagrid.js:1602)
    at draw (canvas-datagrid.js:1882)
    at scroll (canvas-datagrid.js:2145)
    at Object.set (canvas-datagrid.js:3771)
    at HTMLCanvasElement.scrollWheel (canvas-datagrid.js:3530)

discovered with Chrome 58.0.3029.110 (64-bit)

Work around for now is to right click "clear saved settings".  Will fix as soon as possible.


[Firebase Web Codelab] Step 4 > missing dot

Make sure the version of the Firebase CLI is above 3.3.0
should be
Make sure the version of the Firebase CLI is above 3.3.0.

fixed!


Unique item list limit issue.

There's a limit of 36 items thrown in the unique item lists to for example blacklisting stacked items.
Any way to add a page 2, 3 etcetra? I find stacking tools and armor to be quite pointless regarding how stacking 5 pickaxes and mining with them uses up the durability of all 5 pickaxes at the same time, you are using 1 for the cost of 5.

And I need more pages to fit all the items.

Thanks for the bug report, seems like this is an issue that was introduced in version 1.3.7. I've fixed this for the next update.

I forgot to mention that from my testing, stacked tools only visually look like their durability is going down for the entire stack. When a tool is broken, the stack is decreased by one and the tool is replenished to full durability. This might be different if you have plugins that prevent this functionality but on my Paper server, it works as intended.


No module named 'sparse_dot_topn

Hello all, trying to install the "sparse_dot_topn" package in python using pip install sparse_dot_topn in my mac terminal but failing.How else can i go about this?

Try building it. https://github.com/ing-bank/sparse_dot_topn

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!

Within Mac anvironment you can download the wheel for:
https://pypi.org/project/sparse-dot-topn/


Maintenance: versions-api

Extract api to a separate module

We should think what should be versions-api.
For me versions-api should have only interfaces for component which can be extended / implemented as extension for versions-maven-plugin, like VersionComparator.
I would like to have a project structure like:

versions-api - public api for external extending plugin
versions-maven-plugin - core plugin
versions-report-maven-plugin - dedicated plugin for Maven site reports
versions-common/internal - shared implementation used in plugin, report-plugin  - should be used only by versions project

plus versions-enforcer
But I'd like to follow a more gradual approach for the time being, otherwise this will become a far too big of a PR

plus versions-enforcer
But I'd like to follow a more gradual approach for the time being, otherwise this will become a far too big of a PR

Yes, yes ... small steps.

Currently there's no clear separation of the API and service implementation. I'd like to separate the API to a separate module as a next stage.


Update functionality

I add some other check from robots and platforms what use social networks.

Nice one..

It looks like the lib/Browser.php has conflicts.
@CreativForm, could you update this PR from master branch?


wip: Only show non-zero rates in Grafana

What type of PR is this?
/kind bug
/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-exporter-chart
What this PR does / why we need it:
Adjust Grafana dashboard to only show events with non-zero rate.
Special notes for your reviewer:
Checklist

[x] Chart Version bumped
[x] CHANGELOG.md updated

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign cpanato after the PR has been reviewed.
You can assign the PR to them by writing /assign @cpanato in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @ball-hayden! It looks like this is your first PR to falcosecurity/charts 🎉

LGTM label has been added.  Git tree hash: 6c96cc8b0be9a9da6f554320de0ed9005c7ddfd3

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

I'll add it to my list to port it over @leodido 🙂


Add http.user_agent attribute before startSpan so it's available for sampling

We had an Application Insights user try to configure sampling based on http.user_agent but was unsuccessful since that attribute is not added prior to starting the span (https://github.com/microsoft/ApplicationInsights-Java/issues/2083#issuecomment-1034348844)
https://github.com/Azure/azure-sdk-for-java/blob/31b837387e2f9db000344494dd6100d15fa997dc/sdk/core/azure-core-tracing-opentelemetry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryHttpPolicy.java#L124-L127

@trask should we mark user-agent as sampling-relevant in the HTTP semconv?

Closing this since user_agent.original became opt-in and Azure SDKs no longer report it


Using Oracle 12.1 on Linux

Hey @aam,
Just quickly I was wondering if it is possible to use this package on Linux with Oracle 12.1?
Thanks!

Hi,
I don't remember whether I tried with Oracle 12.1 on Linux or not. I think I gave it a try with 11.2 and it worked so I didn't explore it further.
I can't think of any reasons why it should not.
Alex.

Here's what ldd shows when I use Oracle 11.1
austin@psyche ~/dev/webquery/DR-489/src/packages/oracledart/src $ ldd liboracledart_native_extension.so
        linux-gate.so.1 =>  (0x009a0000)
        libocci.so.11.1 => /usr/lib/oracle/11.2/client/lib/libocci.so.11.1 (0x00eab000)
        libclntsh.so.11.1 => /usr/lib/oracle/11.2/client/lib/libclntsh.so.11.1 (0xf5730000)
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00da1000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x00cd3000)
        libc.so.6 => /lib/libc.so.6 (0x00352000)
        libm.so.6 => /lib/libm.so.6 (0x001d9000)
        libnnz11.so => /usr/lib/oracle/11.2/client/lib/libnnz11.so (0x004e9000)
        libdl.so.2 => /lib/libdl.so.2 (0x00203000)
        libpthread.so.0 => /lib/libpthread.so.0 (0x00208000)
        libnsl.so.1 => /lib/libnsl.so.1 (0x00ae8000)
        libaio.so.1 => /lib/libaio.so.1 (0x00879000)
        /lib/ld-linux.so.2 (0x00b32000)

And here's what it says when I use Oracle 12.
austin@psyche ~/dev/webquery/DR-489/src/packages/oracledart/src $ ldd liboracledart_native_extension.so
        linux-gate.so.1 =>  (0x0072d000)
        libocci.so.11.1 => not found
        libclntsh.so.11.1 => not found
        libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x002dd000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x00d96000)
        libc.so.6 => /lib/libc.so.6 (0x003c8000)
        libm.so.6 => /lib/libm.so.6 (0x00976000)
        /lib/ld-linux.so.2 (0x00b32000)

It appears that the .so is only compatible with Oracle instantclient 11.1.
Is there any way I could get a build that works with 12?

Yes, right. I will clone existing linux build to use Oracle 12 instead of Oracle 11.

You certainly can build oracledart yourself - the scripts are in tools/ folder, the first step is in "To Build" section in README.md.
If you look at the Linux(and Mac) sections you see that version of instant client is hardcoded to be 11.2. You might want to start with that first, make sure that it works for you and then change it 12.1.

Can you give https://github.com/aam/oracledart_dist/blob/master/lib/src/liboracledart_native_extension_12_1.so try to see if it works for you?

I'm building and packaging 12.1 binary, so this should be addressed.


Base Motion Class

Summary
Abstract motion classes
Motivation
Enables for custom motions, easy to maintain motions, and ability for users to use custom motions without recompiling LemLib. Same goes for the chassis class.
Test Plan

[ ] Compiles

Download the template for this pull request:

[!NOTE]
This is auto generated from Add Template to Pull Request

via manual download<EMAIL_ADDRESS>via PROS Integrated Terminal:

curl -o<EMAIL_ADDRESS>https://nightly.link/LemLib/LemLib/actions/artifacts/1545426374.zip;
pros c fetch<EMAIL_ADDRESS>pros c apply<EMAIL_ADDRESS>rm<EMAIL_ADDRESS>

Converted to draft, missing critical feature:
A motion should be able to prioritize turning over moving or vice versa


Update sql-data-warehouse-overview-load.md

Replacing the old article with a new one giving some baseline prescriptive guidance, this will be expanded over the next few days.

Contributor is MSFT employee - remove CLA required

@barbkess
Please review and approve, thanks.

Hi, Jennie. Can you please review and let me know if I should merge this PR? Barb is apparently OOF. Thanks.

Approved!


Public API to query by name, CID or formula

I wanted a way to just query PubChem.
Attaching it to metadata and then using it to do stuff is cool and all.
But I have few thousand equations in SBML, and the metadata there gives me CIDs,
but I need other things to compute some other things I need to solve my systems.
(Namely reaction rates :sob: but I can pull those from other databases and systems, if I can resolve various other metadata using PubChem)
I think its reasonably idiomatic to just overload these things to query pubmed if we are given anything other than a symbolic variable
Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] All documentation related to code changes were updated
[x] The new code follows the
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
[x] Any new documentation only uses public API

Additional context
Add any other context about the problem here.

I sent you an invite to join the SciML org -- after you accept I can give you permissions here so you can avoid the CI block and merge PRs that pass tests.

Actually, I just gave you write access here so you can merge (though this PR looks like it has CI issues).


feat: display current version on swagger and in the side panel

Description
Closes no issue;

Add project version (from pom.xml) on Swagger Postgres backend;
Add project version (from pom.xml) on Swagger Oracle backend;
Add project versio (from package.json) on the web app Side panel;

Changelog
New

None;

Changed

application.properties files from both oracle and postgres;
Swagger config file from both oracle and postgres;
constant definition of the current version on frontend;

Removed

None;

How was this tested?

[ ] 🧠 Not needed
[x] 👀 Eyeball
[ ] 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!
Deployments, as required, will be available below:

Frontend
Backend
Oracle-API

Please create PRs in draft mode.  Mark as ready to enable:

Analysis Workflow

After merge, new images are deployed in:

Merge Workflow

This is how it looks like:
On the web app:

On postgres backend:

After discussions and improvements, this is how it'll look like:
frontend:

Postgres api

Oracle api


Getting Cost of An Azure resource using Azure Rest Api

Hi,
Here I'm looking for an Azure rest API where I can pass the location, type, and pricing tier of an azure resource and get the Monthly cost of that particular azure service as a Response. Actually I tried for different rest API's but there I need to pass billing account, billing id, etc.. in order to get the cost. But I'm not looking for that scenario. I want to pass Location, Tier, Type of service, and expected cost as a response. And I also tried Azure rate card api but it is taking the effective time as creation time and can not able to get resource-specific data.
Can you please suggest if this can be possible or not. If possible please guide me.

Hi @rajeshyalamarthi
This repo is for reporting bugs or features for the Bot Framework samples. The Bot Framework team prefers that How-To questions be asked on Stack Overflow and tagged with the 'botframework' tag. I'm going to close this issue, as it does not pertain to the above.
That  being said, you might be able to use https://docs.microsoft.com/en-us/rest/api/cost-management/


(feat) Add Transcoder samples.

b:184919153
Need access to test project
Need to add PROJECT_NUMBER env var (if it does not exist)

Test failed - Transcoder API has not been used in project<PHONE_NUMBER>775 before or it is disabled.

I've enabled the API, rerunning tests... and reviewing.

Test failures here are unrelated, Spanner tests got stuck and the process timed out. I'll rerun.

Yes, please merge. Thanks for all the help!!!


[IMPROVEMENT] Improve upgrade path and make it more solid

Is your improvement request related to a feature? Please describe (👍 if you like this request)
A few users have reported successful upgrades of Longhorn systems, but the resources are not being updated as expected. At present, we do not have a set of reproducible steps. Nonetheless, it appears that the upgrade path lacks sufficient resilience.
The objective of the ticket is to reassess the upgrade path and enhance its solidity.
Related issues:
https://github.com/longhorn/longhorn/issues/6259
https://github.com/longhorn/longhorn/issues/6582
https://github.com/longhorn/longhorn/issues/6688
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
https://github.com/longhorn/longhorn/issues/6259

Reproduce steps:

To simulate a slow cluster, I Introduce some delay when longhorn-manager pods and webhook pods are being terminated to longhorn-manager v1.4.3 (see the code here). In a 3-node cluster, this modification will make:

longhorn manager pod on the node with smallest name take 0 second to
be terminated
longhorn manager pod on the node with 2nd smallest name take 10 second to
be terminated
longhorn manager pod on the node with biggest name take 20 second to
be terminated
all webhook pods take 26 seconds to be terminated

On a 3-node cluster, deploy Longhorn v1.4.3 with this customized longhorn-manager image phanle1010/longhorn-manager:v1-4-3-added-slow-termination. You can use this yaml for your convenience https://github.com/PhanLe1010/longhorn/commit/78d8b540c605de31589f80b02d48222c12348d45.
Create about 12 Longhorn volume of 4 replicas and attach 4 volumes to each nodes
Upgrade Longhorn to v1.5.1 by kubectl apply -f https://raw.githubusercontent.com/longhorn/longhorn/v1.5.1/deploy/longhorn.yaml
Get all volume yaml by kubectl get volumes -n longhorn-system -oyaml > temp
Verify that some volume doesn't have the field status.offlineReplicaRebuildingRequired which indicate that the upgrade path is broken due to old Longhorn manager took a long time to be terminated thus it was running while the new Longhorn manager on a new node has been started upgrading.

Test steps:
Case 1: Test the reproducing steps

Repeat the reproducing steps above with the modification that instead of upgrading to v1.5.1 we upgrade to v1.5.x version
Make sure that in the temp_output, once  current-longhorn-version is set to v1.5.1, there is NOT old Longhorn manager.
Repeat this test 3 times

Case 1: Test upgrade paths
Make sure that the following upgrade path is ok. Each upgrade should have some basic volume operations in the between:

v1.3.3 to v1.4.x-head
v1.4.3 to v1.5.x-head
v1.4.x-head to v1.5.x-head
v1.5.1 to v1.5.x-head
v1.5.x to master-head

Need @PhanLe1010  to provide the commit on v1.5.x, similar to what he did previously for v1.4.3.
After building these customized v1.5.x Longhorn Manager images, I will test the following upgrade scenarios:
For milestone 1.6.0:
v1.5.x-head-added-slow-termination upgrade to master-head
v1.5.1-added-slow-termination           upgrade to master-head

Provided https://github.com/PhanLe1010/longhorn-manager/commit/8b5e39f7e82036176bb3846b2f9286418ead513d

Verified on master-head 20231116

longhorn master-head https://github.com/longhorn/longhorn/commit/74d829d6e81c937baa25a6bc78041f27b361b5e5
longhorn-manager master-head https://github.com/longhorn/longhorn-manager/commit/483ef28241deeae04cb193d1fd22d1b213915835

The test steps
https://github.com/longhorn/longhorn/issues/6294#issuecomment-1724914808
Result Passed

[x] 1. v1.5.x-head-added-slow-termination upgrade to master-head
[x] 2. v1.5.1-head-added-slow-termination upgrade to master-head


Refactor Teaser link to reuse in text teaser, key numbers components and anywhere else if any.

@NickHaggerty1 @meols test that the links in these components works and looks as before:

Teasertext
fiftyfiftyhero
form
call to action

@millianapia Think it looks fine, couple of comments though:
Not sure what you mean by call to action component. Assume text component link?
We also tested on Key numbers component and Link displays as a hyperlink. Should as per all other components (that are not buttons)


Update syntax

We need to update EO syntax in 2.8 section

@c71n93 the puzzle #14 is still not solved.


What about 6 retries and not 3?

#524 There are some failures from ClearML erroring out.

This change is

Codecov Report
Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (2c0dd11) to head (3c140c3).

Files with missing lines
Patch %
Lines

....Shared/Configuration/IMachineBuilderExtensions.cs
0.00%
20 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
- Coverage   56.86%   56.80%   -0.07%
==========================================
  Files         299      299
  Lines       15686    15705      +19
  Branches     2165     2168       +3
==========================================
+ Hits         8920     8921       +1
- Misses       6114     6132      +18
  Partials      652      652

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

src/Machine/src/Serval.Machine.Shared/Configuration/IMachineBuilderExtensions.cs line 165 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I agree with Eli. If we are still encountering this issue occasionally, we probably want to tweak the polling timeout.

I have seen errors on E2E tests - It caused 10 "TooManyRequests" errors on QA in the past day.
I reverted to the first few having the same timing and upped the overall timing to 56 seconds.

src/Serval/src/Serval.Webhooks/Configuration/IServalBuilderExtensions.cs line 9 at r2 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Is this meant to be here?

Should have been removed before.

src/Machine/src/Serval.Machine.Shared/Configuration/IMachineBuilderExtensions.cs line 165 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
@johnml1135, I was think more like increasing the rate of backoff. What about 3, 9, 27  (sum 39)? Or 2.25^1, 2.25^2, 2.25^3, 2.25^4 (still under 1 minute)?

For high workload, a linear back off is often recommended.  Updated to linear back off.

src/Machine/src/Serval.Machine.Shared/Configuration/IMachineBuilderExtensions.cs line 165 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Ok

Done.


Handle %26 and %3D in a query string correctly

Motivation:
The following query string:
a=1%26a=2

should be interpreted as a single query entry whose key is a and value
is 1&a=2. However, PathAndQuery currently handles it as two query
entries: a=1 and a=2.
It is because PathAndQuery decodes %26 into & internally, making %26
indistinguishable from &.
Also, %3D in a query string should be similarly due to the case where
a query string key contains =: a%3Db=1
Modifications:

Decode %26 and %3D into a special marker character so that it is encoded
back into %26 and %3D in PathAndQuery
Update test cases

ArmeriaCallFactory has been updated by @kojilin.

Result:

A query parameter that contains an ampersand or an equal sign is interpreted correctly.

Will merge once CI passes. @kojilin, thanks again for reporting this issue.


Tasks for new spring-boot versions: 2.5.7 and 2.4.13

Copied from here: https://github.com/Azure/azure-sdk-for-java/wiki/Spring-Cloud-Azure-tasks-for-a-new-Spring-Boot-release
Spring boot released spring-boot v2.5.7 and spring-boot v2.4.13. we need do the following tasks.
Task list

Before azure-sdk-for-java in band release

[ ] Upgrade spring-boot and test compatibility. Sample issue: azure-sdk-for-java#24291.

After azure-sdk-for-java in band release.

[ ] Update version and screenshot in MS docs. MS docs about spring framework
[ ] Update version in azure-spring-boot-samples. Sample PR: azure-spring-boot-samples#62.
[ ] Update related wiki pages: Spring-Support-Multiple-Versions.md, Spring-Versions-Mapping.md.

Since we can't finish these tasks in this month, so I assign this issue to @saragluna instead of @backwind1233 .

Close this issue now due to this issue https://github.com/Azure/azure-sdk-for-java/issues/25581.


dev: refacto bytes_i_to_uint256

doesn't follow the projet naming convention

arr_len before arr
bytes instead of bytes_i (bytes in solidity is an array of variable lenght)

can most probably be optimized (use unit tests with --profile-cairo for this)

Action items:

rename the input parameters to follow the codebase and CairoZero conventions
rename the function to make it understandable what the input should be. Are the bytes big endian? little endian?
Apply the same principles to the internal compute_half_uint256
use the pow256_rev with a dw table instead of the pow function
Make sure that all tests pass.


add ext. help file metadata

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/office-docs-powershell, working directory: W:\kjww-s, target branch: master, target branch commit: dd14d1a345c3d89b2ee7e548efd017c65538f873, source branch: KirksPowerShell_Working, source branch commit: .
Learn more: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Error boundary & hook

Coverage remained the same at 100.0% when pulling 8690432cbf7163a156cb06ee17cdcb8267484663 on error-boundary into f2a8f5290c72a2e285d5d4da533b0bebb32b58fe on master.

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         8    +2
  Lines          105       121   +16
  Branches        32        34    +2
=========================================
+ Hits           105       121   +16

Impacted Files
Coverage Δ

src/lib/ErrorsBoundary.tsx
100.00% <100.00%> (ø)

src/lib/hooks/useErrorHandler.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2a8f52...8690432. Read the comment docs.

Perhaps the error boundary should actually be a context provider. Error boundary remounts the child component tree when an error occurs.
Look in to the react implementation of componentDidCatch. It appears to behave like a try-catch around the rendered method. If that is the case then a context provider can allow for better control over error handling of its child component tree.

NEW APPROACH:
Error boundaries & re-mounting the component-tree is the proper handler for synchronous errors during render. It is not the proper way to handle async errors.
Async errors happen after the app last successfully rendered. Async errors causes a new state progression that renders error-information instead of the originally intended state progression at the end of the async-flow.
The hook should handle this error-state-progression. Errors shall be grouped & updated by message and can be closed declaratively.

Need to start documenting the new hook in readme.md

[ ] Test-drive an implementation of the hook

[ ] Integrate the hook into the example app

[ ] Package export the hook

[ ] Add documentation into the readme.md


Unable to log on

I use chat all the time on different platforms. This is convoluted and confusing.
I am a research provider on Seeking Alpha Marketplace. Brand new service. Just received my first chat message.
No clear way to log on and respond to the message. When I try, I'm greeted by a message:
New user registration is currently disabled
I wonder if this is designed by someone who is thinking, "I'm a really smart guy. Let's see if we can make this as complicated as possible to prove to everyone else that I'm smarter than them."

This is possibly the worst ticket I've ever seen

Answer the question. Why, when I try to log on do I get the response that
my account has been temporarily suspended? or that Rocket is no longer
accepting new accounts? Those are the two responses I get when I try to log
on.
That's perhaps too simple. Not complicated enough.
On Wed, Jul 1, 2020 at 2:32 AM sandreddu<EMAIL_ADDRESS>wrote:

This is possibly the worst ticket I've ever seen
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/Rocket.Chat.Electron/issues/1637#issuecomment-652220817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKJUBFNWM6V7A6D2JIFULTDRZLJ6TANCNFSM4OFA7VLA
.

--
Roderick MacIver
802-234-3120

I'm not a developer, I'm a simple user. It's not "my" system. I'm just pointing out how poorly written this "issue" is. And how rude you are in posing it.

Sorry about that. It is in keeping with their general set up that when you
click the button for tech support they route the request to you, who has
nothing to do with tech support.
On Wed, Jul 1, 2020 at 9:40 AM sandreddu<EMAIL_ADDRESS>wrote:

I'm not a developer, I'm a simple user. It's not "my" system. I'm just
pointing out how poorly written this "issue" is. And how rude you are in
posing it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/Rocket.Chat.Electron/issues/1637#issuecomment-652424778,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKJUBFLLR26EHSFIEKZWPBLRZM4EBANCNFSM4OFA7VLA
.

--
Roderick MacIver
802-234-3120

Sorry but I didn't understood the issue with Rocket.Chat Desktop App.
Please reopen the issue if the problem persists and explain what happened.
Thank you.


GDExtension: Fixed error on loading extensions

Previously, before loading an extension, the editor just tried to retrieve the extension by path to test if it's been loaded already.
While this is handled gracefully, it ignored an error thrown inside GDExtensionManager::get_extension(), that would essentially still report a not yet loaded extension to the engine's log:
ERROR: Condition "!E" is true. Returning: Ref<GDExtension>()
   at: GDExtensionManager::get_extension (core\extension\gdextension_manager.cpp:165)

This change actively checks whether the extension path is known and only then proceeds to actually return the already loaded extension or loads and returns the new one otherwise.

Thanks!


Power from Beyond (again!)

Quest objectives aren't pointing to the correct planet (or anything)
Details

This did not resolve my "Power From Beyond" Issue.  I have 3 versions of the quest, and I still have no marker anywhere for them.  No matter how long I explore a planet, I can never find the temples.
Edit: Actually, I take it back.  I actually have 4 versions of the quest, and this DID solve the problem for 3 of them.  The 1 that it still doesn't show up for is on Altair 4-C (not sure if that matters).
Edit 2: Now it happened again, this time on Piazzi 4-C.  So, my two "problem quests" are on Altair 4-C and Piazzi 4-C.  Something about "4-C" causing this leftover issue?

Reported by [kalkano27
Game Version
1.8.86
Language
English (EN)
Have you recreated this issue on a new game?
Yes, I can recreate this issue.
Reproduction Steps
I have one right here, saved right before going into the Unity. I used console commands to give myself the last two remaining powers (Supernova and Alien Reanimation) because if you talk to Vlad, he will ask you to go to Altair IV-C and it's bugged.
In fact, I had 9 powers when he asked me to go to Altair IV-C. So, I avoided talking to him completely and just visited all 119 star systems and collected 22/24 powers (so an additional 13 powers). I then talked to him, and he still asked me to go to Altair IV-C. This is when I gave up and just used console commands for the last two remaining powers.
In that save file, just go to the Lodge and ask Vlad for a temple location, and he'll tell you to go to Altair IV-C. Enjoy figuring this one out.
Save4_B722A895_53686570617264_062213_20231123143102_107_0_4.zip
A somewhat earlier save with the same bugs, if this helps. I hadn't given myself the last two powers yet via console commands in this one. (edited)
Quicksave0_B722A895_53686570617264_062142_20231123010549_107_0_4.zip

On checking the savegame provided it appears that the PFB Quest [000854E8] aliases failed to fill for AnomalyLocation and AnomalyMapMarker

Those Aliases do appear to be completely optional - which they probably shouldn't be!

Further testing Altair IV-C is not a planet that has a temple on it.

I have the same issue too - 2 "power from beyond" quests that do not point to any markers.
Game version 1.8.86 and latest community patch.

Try this https://www.nexusmods.com/starfield/mods/7240/

Try this https://www.nexusmods.com/starfield/mods/7240/

I have two bugged "Power from Beyond" quests that don't point to any location on planets: Guniibuu II and Oborum I.
They both have Anomalies but there is no Temple markers on them.
I've been fully surveyed these planets for quite some time so that may be the cause of the problem.
I've used your patch, but got "Fix failed for quest at index 0" (and index 1) messages and then "Power from beyond fix has finished running".
I've added required options to \Documents\My Games\Starfield\StarfieldCustom.ini but no logs were created in \Documents\My Games\Starfield\Logs\Script\User. just like the folder was not created too (also I've tried to create a folder but it didn't help).
I can't upload my save game here due to file size limit, so I've uploaded it to Google Drive: https://drive.google.com/file/d/1H1aN5RSLhz_Z4njy7_gcuulNYkN-B8tg

Powers From Beyond issues have been fixed as of v1.10.31


ElasticSearch attribute

Product
Hot Chocolate
Is your feature request related to a problem?
The current implementation of the ElasticSearch attribute and ConfigureElastic method in our codebase is not sufficiently flexible to handle various use cases. It does not allow for the configuration of multiple parameters like "Field", "Boost", and "Keyword" in a unified and structured way.
Currently, we would have separate attributes and methods for different configurations. This approach is a bit cluttered. Given [ElasticSearchFieldName] [ElasticSearchBoost] etc.
For instance, we have the ElasticSearch attribute for defining the "Field" and potentially "Boost" and we have the ConfigureElastic method for code-first configuration. The lack of alignment between these two configuration methods might lead to confusion and misuse.
The solution you'd like
A unified attribute structure for ElasticSearch would make more sense, allowing us to define all the necessary configurations in one place.
For example:
[ElasticSearch(Field = "foo", Boost = 12, Keyword = ...)]
This approach would not only make our code cleaner but also enhance its usability by providing a consistent way of defining configurations.
The new ElasticSearch attribute should accept parameters for "Field", "Boost", and "Keyword". The attribute should be designed in a way that it uses the ConfigureElastic method and handles the underlying configurations appropriately.
See https://github.com/ChilliCream/graphql-platform/pull/5639#discussion_r1186913714
Related: https://github.com/ChilliCream/graphql-platform/pull/4998, https://github.com/ChilliCream/graphql-platform/discussions/4883
CC: @A360JMaxxgamer

I will start to work on this issue today.

I managed to get the boost field interpreted and forwarded to the search request. I guess we don't need a keyword property.  Using the keyword field can also be achieved by setting the attrbiute field to it like;
[ElasticSearch(Field: "somefield.keyword")]
public string SomeProperty { get; set; }

But now I am stuck.
I would like to use the the custom ElasticField attribute to setup the serializer mappings on the elastic client. At the moment it only works by using the PropertyName attribute. That seems a bit wrong because both attributes basically describe the same desired behaviour.
[ElasticSearch("special")]
[PropertyName("special")]
public string Value { get; set; } = string.Empty;

The friendly ai of the neigbourhood told me, that setting up the mapping can also be done via the ConnectionStrings class of the nest client. But that would mean, we might need some kind of client factory which we can tell the mapping somehow.
Basically we would change the IExecutable approach to something else.
Or we could create a source generator which annotates the model class with the PropertyNameAttribute based on the ElasticSearch attribute.
@PascalSenn what are your thoughts? Is there some kind of solution in other integrations? Changing IExecutable would also impact #6159 I guess.


Handle github hook authentication

This PR handles github authentication for webhooks.
See developer doc https://developer.github.com/webhooks/

Nice work !
A couple of remarks:

Why overload the authentication middleware to handle Github specific authentication ? why not just create a Github authenticator middleware and apply it to the github route only (which should let you use mux.Vars to extract the project id) ?
Due to the previous remark, I think we should split the server endpoints into 3 sub-routers: bazooka, github and bitbucket, each with a specific authenticator. I'm not sure about this one mind you.
What's the purpose of making GithubAuthenticator validation logic configurable (a field in a struct) and implementing it in context.go ? shouldn't the Github specific logic be fully contained in github.go ?

LGTM


Incoming payment timeout caused close: Offered HTLC 1 SENT_ADD_ACK_REVOCATION cltv hit deadline

Stripped logs below. User tried to receive, opened the app the next day, the CLN node sent the error.
2023-06-23 02:52:00.088 INFO  [mutiny_core::node:733] SUCCESS: generated invoice:
2023-06-23 02:52:00.298 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:01.206 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:02.203 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:03.226 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:04.398 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:05.262 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:06.243 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:07.257 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:08.273 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:09.266 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:10.244 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:11.219 TRACE [mutiny_core::background:575] Calling PeerManager's timer_tick_occurred
2023-06-23 02:52:11.220 TRACE [lightning::ln::peer_handler:1071] Enqueueing message Ping { ponglen: 0, byteslen: 64 } to XXX
2023-06-23 02:52:11.220 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 02:52:11.232 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 02:52:11.486 TRACE [mutiny_core::networking::socket:77] received binary data from websocket
2023-06-23 02:52:11.486 TRACE [lightning::ln::peer_handler:1381] Received message Pong(Pong { byteslen: 0 }) from XXX
2023-06-23 02:52:11.674 TRACE [mutiny_core::networking::socket:77] received binary data from websocket
2023-06-23 02:52:11.682 TRACE [lightning::ln::peer_handler:1381] Received message UpdateAddHTLC(UpdateAddHTLC { channel_id: XXX, htlc_id: 1, amount_msat: 19034000, payment_hash: PaymentHash(XXX), cltv_expiry: 795572, onion_routing_packet: OnionPacket version 0 with hmac XXX }) from XXX
2023-06-23 02:52:11.706 TRACE [mutiny_core::background:575] Persisting ChannelManager...
2023-06-23 02:52:11.719 TRACE [mutiny_core::background:575] Done persisting ChannelManager.
2023-06-23 02:52:11.910 TRACE [mutiny_core::networking::socket:77] received binary data from websocket
2023-06-23 02:52:11.912 TRACE [lightning::ln::peer_handler:1381] Received message CommitmentSigned(CommitmentSigned { channel_id: XXX, signature: XXX, htlc_signatures: [XXX] }) from XXX
2023-06-23 02:52:11.927 TRACE [lightning::ln::channel:1519] Building commitment transaction number<PHONE_NUMBER>10640 (really 15 xor<PHONE_NUMBER>601) for channel XXX for us, generated by remote with fee 3988...
2023-06-23 02:52:11.927 TRACE [lightning::ln::channel:1580]    ...including inbound RemoteAnnounced HTLC 1 (hash XXX) with value 19034000
2023-06-23 02:52:11.928 TRACE [lightning::ln::channel:1679]    ...including to_local output with value 40000
2023-06-23 02:52:11.928 TRACE [lightning::ln::channel:1685]    ...including to_remote output with value 77393
2023-06-23 02:52:11.931 TRACE [lightning::ln::channel:3094] Checking commitment tx signature XXX by key XXX against tx XXX (sighash XXX) with redeemscript XXX in channel XXX
2023-06-23 02:52:11.942 TRACE [lightning::ln::channel:3165] Checking HTLC tx signature XXX by key XXX against tx XXX (sighash XXX) with redeemscript XXX in channel XXX.
2023-06-23 02:52:11.946 TRACE [lightning::ln::channel:3210] Updating HTLC XXX to AwaitingRemoteRevokeToAnnounce due to commitment_signed in channel XXX.
2023-06-23 02:52:11.947 TRACE [lightning::ln::channel:5865] Updating HTLC state for a newly-sent commitment_signed...
2023-06-23 02:52:11.947 TRACE [lightning::ln::channel:5874]  ...promoting inbound AwaitingRemoteRevokeToAnnounce XXX to AwaitingAnnouncedRemoteRevoke
2023-06-23 02:52:11.954 TRACE [lightning::ln::channel:1519] Building commitment transaction number<PHONE_NUMBER>10640 (really 15 xor<PHONE_NUMBER>601) for channel XXX for remote, generated by us with fee 3988...
2023-06-23 02:52:11.955 TRACE [lightning::ln::channel:1580]    ...including inbound AwaitingAnnouncedRemoteRevoke HTLC 1 (hash XXX) with value 19034000
2023-06-23 02:52:11.955 TRACE [lightning::ln::channel:1679]    ...including to_remote output with value 77393
2023-06-23 02:52:11.955 TRACE [lightning::ln::channel:1685]    ...including to_local output with value 40000
2023-06-23 02:52:11.955 DEBUG [lightning::ln::channel:3287] Received valid commitment_signed from peer in channel XXX, updating HTLC state and responding with our own commitment_signed and a revoke_and_ack.
2023-06-23 02:52:11.956 TRACE [lightning::chain::chainmonitor:706] Updating ChannelMonitor for channel XXX
2023-06-23 02:52:11.956 INFO  [lightning::chain::channelmonitor:2328] Applying update to monitor XXX, bringing update_id from 29 to 30 with 2 changes.
2023-06-23 02:52:11.957 TRACE [lightning::chain::channelmonitor:2359] Updating ChannelMonitor with latest holder commitment transaction info
2023-06-23 02:52:11.957 TRACE [lightning::chain::channelmonitor:2368] Updating ChannelMonitor with latest counterparty commitment transaction info
2023-06-23 02:52:11.958 TRACE [lightning::chain::channelmonitor:2142] Tracking new counterparty commitment transaction with txid XXX at commitment number<PHONE_NUMBER>10640 with 1 HTLC outputs
2023-06-23 02:52:11.969 DEBUG [lightning::chain::chainmonitor:726] Persistence of ChannelMonitorUpdate for channel XXX completed
2023-06-23 02:52:11.971 TRACE [lightning::ln::channel:5534] Creating an announcement_signatures message for channel XXX
2023-06-23 02:52:11.971 TRACE [lightning::ln::channel:5538] Ignore : Channel is not available for public announcements
2023-06-23 02:52:11.972 TRACE [lightning::ln::channel:4009] Regenerated latest commitment update in channel XXX with 0 update_adds, 0 update_fulfills, 0 update_fails, and 0 update_fail_malformeds
2023-06-23 02:52:11.980 TRACE [lightning::ln::channel:1519] Building commitment transaction number<PHONE_NUMBER>10640 (really 15 xor<PHONE_NUMBER>601) for channel XXX for remote, generated by us with fee 3988...
2023-06-23 02:52:11.980 TRACE [lightning::ln::channel:1580]    ...including inbound AwaitingAnnouncedRemoteRevoke HTLC 1 (hash XXX) with value 19034000
2023-06-23 02:52:11.980 TRACE [lightning::ln::channel:1679]    ...including to_remote output with value 77393
2023-06-23 02:52:11.980 TRACE [lightning::ln::channel:1685]    ...including to_local output with value 40000
2023-06-23 02:52:11.986 TRACE [lightning::ln::channel:5968] Signed remote commitment tx XXX (txid XXX) with redeemscript XXX -> XXX in channel XXX
2023-06-23 02:52:11.986 TRACE [lightning::ln::channel:5974] Signed remote HTLC tx XXX with redeemscript XXX with pubkey XXX -> XXX in channel XXX
2023-06-23 02:52:11.987 DEBUG [lightning::ln::channel:3899] Restored monitor updating in channel XXX resulting in a commitment update and an RAA, with RAA first
2023-06-23 02:52:11.987 TRACE [lightning::ln::channelmanager:4408] Handling channel resumption for channel XXX with an RAA, a commitment update, 0 pending forwards, not broadcasting funding, without channel ready, without announcement
2023-06-23 02:52:11.988 DEBUG [lightning::ln::peer_handler:1783] Handling SendRevokeAndACK event in peer_handler for node XXX for channel XXX
2023-06-23 02:52:11.988 TRACE [lightning::ln::peer_handler:1071] Enqueueing message RevokeAndACK { channel_id: XXX, per_commitment_secret: XXX, next_per_commitment_point: PublicKey(XXX) } to XXX
2023-06-23 02:52:11.988 DEBUG [lightning::ln::peer_handler:1758] Handling UpdateHTLCs event in peer_handler for node XXX with 0 adds, 0 fulfills, 0 fails for channel XXX
2023-06-23 02:52:11.989 TRACE [lightning::ln::peer_handler:1071] Enqueueing message CommitmentSigned { channel_id: XXX, signature: XXX, htlc_signatures: [XXX] } to XXX
2023-06-23 02:52:11.995 TRACE [mutiny_core::background:575] Persisting ChannelManager...
2023-06-23 02:52:12.005 TRACE [mutiny_core::background:575] Done persisting ChannelManager.
2023-06-23 02:52:12.006 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 02:52:12.006 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 02:52:12.263 TRACE [mutiny_core::ldkstorage:263] Trace: checking payment key: payment_inbound/XXX_f60bc404-234e-4007-b11c-3d6625c38fc5

2023-06-23 17:01:17.314 DEBUG [mutiny_core::gossip:63] Got network graph, getting scorer...
2023-06-23 17:01:17.323 DEBUG [mutiny_core::gossip:133] Previous gossip sync timestamp:<PHONE_NUMBER>
2023-06-23 17:01:17.323 INFO  [mutiny_core::gossip:152] RGS URL: https://rapidsync.lightningdevkit.org/snapshot/1687305600
2023-06-23 17:01:17.885 TRACE [lightning_rapid_gossip_sync::processing:62] Processing RGS data...
2023-06-23 17:01:17.934 DEBUG [lightning_rapid_gossip_sync::processing:138] Processing RGS update from<PHONE_NUMBER> with 228 nodes, 217 channel announcements and 29566 channel updates.
2023-06-23 17:01:18.731 TRACE [lightning_rapid_gossip_sync::processing:247] Done processing RGS data from<PHONE_NUMBER>
2023-06-23 17:01:18.732 INFO  [mutiny_core::gossip:202] RGS sync result:<PHONE_NUMBER>
2023-06-23 17:01:22.134 INFO  [mutiny_core::node:172] initializing a new node: f60bc404-234e-4007-b11c-3d6625c38fc5
2023-06-23 17:01:22.696 INFO  [lightning::ln::channelmanager:7548] Successfully loaded channel XXX
2023-06-23 17:01:22.702 INFO  [mutiny_core::node:278] creating lsp client
2023-06-23 17:01:22.708 TRACE [lightning::chain::chainmonitor:658] Got new ChannelMonitor for channel XXX
2023-06-23 17:01:22.732 INFO  [lightning::chain::chainmonitor:672] Persistence of new ChannelMonitor for channel XXX completed
2023-06-23 17:01:22.741 INFO  [mutiny_core::nodemanager:584] inserting updated nodes
2023-06-23 17:01:22.742 INFO  [mutiny_core::nodemanager:590] inserted updated nodes
2023-06-23 17:01:22.785 TRACE [mutiny_core::background:575] Calling ChannelManager's timer_tick_occurred on startup
2023-06-23 17:01:22.786 TRACE [mutiny_core::fees:160] Got fee rate from saved cache!
2023-06-23 17:01:22.788 TRACE [mutiny_core::background:575] Rebroadcasting monitor's pending claims on startup
2023-06-23 17:01:22.804 DEBUG [mutiny_core::event:429] EVENT: PendingHTLCsForwardable: 2s, processing...
2023-06-23 17:01:23.283 TRACE [mutiny_core::fees:126] Retrieved fees from mempool
2023-06-23 17:01:23.331 TRACE [mutiny_core::fees:126] Retrieved fees from mempool
2023-06-23 17:01:23.331 INFO  [mutiny_core::nodemanager:762] Updated fee estimates!
2023-06-23 17:01:23.333 INFO  [mutiny_core::esplora:220] Starting transaction sync.
2023-06-23 17:01:23.633 TRACE [lightning::ln::channelmanager:6076] New best block: XXX at height 795600
2023-06-23 17:01:23.633 TRACE [lightning::ln::channel:5526] Cannot create an announcement_signatures as our peer is disconnected
2023-06-23 17:01:23.634 DEBUG [lightning::chain::chainmonitor:612] New best block XXX at height 795600 provided via best_block_updated
2023-06-23 17:01:23.637 TRACE [lightning::chain::channelmonitor:3157] Processing 0 matched transactions for block at height 795600.
2023-06-23 17:01:23.637 DEBUG [lightning::chain::onchaintx:707] Updating claims view at height 795600 with 0 claim requests
2023-06-23 17:01:23.638 DEBUG [lightning::chain::onchaintx:820] Updating claims view at height 795600 with 0 matched transactions in block 795600
2023-06-23 17:01:23.639 TRACE [lightning::chain::onchaintx:955] Bumping 0 candidates
2023-06-23 17:01:23.639 TRACE [lightning::chain::chainmonitor:306] Syncing Channel Monitor for channel XXX
2023-06-23 17:01:23.641 TRACE [lightning::chain::chainmonitor:309] Finished syncing Channel Monitor for channel XXX
2023-06-23 17:01:23.965 TRACE [lightning::ln::channelmanager:6057] 1 transactions included in block XXX at height 795241 provided
2023-06-23 17:01:23.965 TRACE [lightning::ln::channel:5526] Cannot create an announcement_signatures as our peer is disconnected
2023-06-23 17:01:23.972 DEBUG [lightning::chain::chainmonitor:596] 1 provided transactions confirmed at height 795241 in block XXX
2023-06-23 17:01:23.973 TRACE [lightning::chain::channelmonitor:3157] Processing 0 matched transactions for block at height 795241.
2023-06-23 17:01:23.973 DEBUG [lightning::chain::onchaintx:707] Updating claims view at height 795600 with 0 claim requests
2023-06-23 17:01:23.973 DEBUG [lightning::chain::onchaintx:820] Updating claims view at height 795600 with 0 matched transactions in block 795241
2023-06-23 17:01:23.973 TRACE [lightning::chain::onchaintx:955] Bumping 0 candidates
2023-06-23 17:01:23.973 TRACE [lightning::chain::chainmonitor:306] Syncing Channel Monitor for channel XXX
2023-06-23 17:01:23.976 TRACE [lightning::chain::chainmonitor:309] Finished syncing Channel Monitor for channel XXX
2023-06-23 17:01:23.977 INFO  [mutiny_core::esplora:316] Finished transaction sync.
2023-06-23 17:01:24.297 DEBUG [mutiny_core::networking::proxy:69] connected to ws: wss://p.mutinywallet.com
2023-06-23 17:01:24.312 DEBUG [mutiny_core::peermanager:394] connected to peer: PubkeyConnectionInfo { pubkey: PublicKey(XXX), connection_type: Tcp("<IP_ADDRESS>:9735"), original_connection_string: "XXX@<IP_ADDRESS>:9735" }
2023-06-23 17:01:24.313 TRACE [mutiny_core::peermanager:397] sent 50 to node: XXX
2023-06-23 17:01:24.313 TRACE [mutiny_core::networking::socket:65] scheduling descriptor reader
2023-06-23 17:01:24.313 TRACE [mutiny_core::node:1398] auto connected lsp: XXX
2023-06-23 17:01:24.318 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 17:01:24.362 TRACE [mutiny_core::networking::socket:77] received binary data from websocket
2023-06-23 17:01:24.399 DEBUG [lightning::ln::peer_handler:1192] Finished noise handshake for connection with XXX
2023-06-23 17:01:24.401 TRACE [lightning::ln::peer_handler:1071] Enqueueing message Init { features: XXX, remote_network_address: Some(IPv4 { addr: XXX, port: 9735 }) } to XXX
2023-06-23 17:01:24.410 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 17:01:24.410 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 17:01:24.445 TRACE [mutiny_core::networking::socket:77] received binary data from websocket
2023-06-23 17:01:24.463 INFO  [lightning::ln::peer_handler:1334] Received peer Init message from XXX: DataLossProtect: supported, InitialRoutingSync: not supported, UpfrontShutdownScript: supported, GossipQueries: supported, VariableLengthOnion: required, StaticRemoteKey: supported, PaymentSecret: required, BasicMPP: supported, Wumbo: not supported, AnchorsZeroFeeHtlcTx: not supported, ShutdownAnySegwit: supported, OnionMessages: not supported, ChannelType: supported, SCIDPrivacy: supported, ZeroConf: supported, unknown flags: supported
2023-06-23 17:01:24.467 DEBUG [lightning::ln::channelmanager:6563] Generating channel_reestablish events for XXX
2023-06-23 17:01:24.470 TRACE [lightning::ln::channel:5656] Enough info to generate a Data Loss Protect with per_commitment_secret XXX for channel XXX
2023-06-23 17:01:24.470 DEBUG [lightning::ln::peer_handler:1801] Handling SendChannelReestablish event in peer_handler for node XXX for channel XXX
2023-06-23 17:01:24.471 TRACE [lightning::ln::peer_handler:1071] Enqueueing message ChannelReestablish { channel_id: XXX, next_local_commitment_number: 16, next_remote_commitment_number: 15, data_loss_protect: Present(DataLossProtect { your_last_per_commitment_secret: XXX, my_current_per_commitment_point: PublicKey(XXX) }) } to XXX
2023-06-23 17:01:24.472 TRACE [mutiny_core::networking::proxy:92] sent data down websocket
2023-06-23 17:01:24.513 TRACE [mutiny_core::networking::socket:77] received binary data from websocket
2023-06-23 17:01:24.514 TRACE [lightning::ln::peer_handler:1381] Received message Error(ErrorMessage { channel_id: XXX, data: "Offered HTLC 1 SENT_ADD_ACK_REVOCATION cltv 795572 hit deadline" }) from XXX
2023-06-23 17:01:24.514 DEBUG [lightning::ln::peer_handler:1404] Got Err message from XXX: Offered HTLC 1 SENT_ADD_ACK_REVOCATION cltv 795572 hit deadline
2023-06-23 17:01:24.515 ERROR [lightning::ln::channelmanager:2173] Force-closing channel XXX
2023-06-23 17:01:24.516 DEBUG [lightning::ln::channelmanager:2136] Finishing force-closure of channel with 0 HTLCs to fail
2023-06-23 17:01:24.518 TRACE [lightning::chain::chainmonitor:706] Updating ChannelMonitor for channel XXX
2023-06-23 17:01:24.519 INFO  [lightning::chain::channelmonitor:2328] Applying update to monitor XXX, bringing update_id from 31 to<PHONE_NUMBER>3709551615 with 1 changes.
2023-06-23 17:01:24.520 TRACE [lightning::chain::channelmonitor:2384] Updating ChannelMonitor: channel force closed, should broadcast: true
2023-06-23 17:01:24.520 DEBUG [lightning::chain::channelmonitor:2893] Getting signed latest holder commitment transaction!
2023-06-23 17:01:24.529 INFO  [lightning::chain::channelmonitor:2317] Broadcasting local commitment tx with txid XXX
2023-06-23 17:01:24.533 DEBUG [lightning::chain::chainmonitor:726] Persistence of ChannelMonitorUpdate for channel XXX completed
2023-06-23 17:01:24.747 ERROR [mutiny_core::onchain:76] Failed to broadcast transaction (XXX): Reqwest(reqwest::Error { kind: Status(400), url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("mempool.space")), port: None, path: "/api/tx", query: None, fragment: None } })
2023-06-23 17:01:24.748 WARN  [mutiny_core::chain:52] Error broadcasting transaction: Failed to broadcast transaction (XXX): Reqwest(reqwest::Error { kind: Status(400), url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("mempool.space")), port: None, path: "/api/tx", query: None, fragment: None } })
2023-06-23 17:01:24.763 DEBUG [mutiny_core::nodemanager:1950] fetching new bitcoin price
2023-06-23 17:01:24.810 TRACE [lightning::ln::inbound_payment:380] Failing HTLC with payment_hash XXX: expired payment
2023-06-23 17:01:24.810 TRACE [lightning::ln::channelmanager:3604] Failing new HTLC with payment_hash XXX as payment verification failed
2023-06-23 17:01:24.813 TRACE [lightning::ln::channelmanager:4103] Failing HTLC with payment_hash XXX backwards from us with HTLC error code 16399
2023-06-23 17:01:24.815 DEBUG [mutiny_core::event:456] EVENT: Channel XXX closed due to: CounterpartyForceClosed { peer_msg: UntrustedString("Offered HTLC 1 SENT_ADD_ACK_REVOCATION cltv 795572 hit deadline") }
2023-06-23 17:01:24.816 DEBUG [mutiny_core::event:426] EVENT: HTLCHandlingFailed, ignored
2023-06-23 17:01:24.816 TRACE [mutiny_core::background:575] Persisting ChannelManager...
2023-06-23 17:01:24.826 TRACE [mutiny_core::background:575] Done persisting ChannelManager.
2023-06-23 17:01:30.472 INFO  [mutiny_core::nodemanager:1218] We are synced!
2023-06-23 17:01:34.839 TRACE [mutiny_core::background:575] Calling PeerManager's timer_tick_occurred
2023-06-23 17:01:34.845 TRACE [lightning::ln::peer_handler:1071] Enqueueing message Ping { ponglen: 0, byteslen: 64 } to XXX
2023-06-23 17:01:34.850 TRACE [mutiny_core::networking::proxy:92] sent data down websocket

It's weird because CommitmentSigned was sent. I wonder if there's more messages that were supposed to be sent.

I don't think this can be fixed technically. I think we can only educate users to keep their app opened.


[IGNORE]

Just testing some stuff

Codecov Report

Merging #135 into master will increase coverage by 0.14%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #135      +/-   ##
===========================================
+ Coverage     35.96%   36.1%   +0.14%
- Complexity      587     589       +2
===========================================
  Files            87      87
  Lines          6298    6298
  Branches       1046    1046
===========================================
+ Hits           2265    2274       +9
+ Misses         3852    3845       -7
+ Partials        181     179       -2

Impacted Files
Coverage Δ
Complexity Δ

...r/jaeger/samplers/GuaranteedThroughputSampler.java
88.88% <100%> (ø)
7 <0> (ø)
:arrow_down:

...java/com/uber/jaeger/reporters/RemoteReporter.java
84.12% <0%> (+3.17%)
5% <0%> (ø)
:arrow_down:

...c/main/java/com/uber/jaeger/senders/UDPSender.java
71.42% <0%> (+4.08%)
10% <0%> (ø)
:arrow_down:

...uber/jaeger/reporters/protocols/TUDPTransport.java
86.44% <0%> (+8.47%)
16% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54852c1...440fa3f. Read the comment docs.

should this be closed?

One of my drunk escapades


Fix colorful avatars not updating after toggled

Fixes #1108

We may have to do the same for the colorful bubbles option

Nah that works fine because the colorful bubbles state will never be modified while that screen is open. Colorful avatars will be since the conversation list is active while in settings.

Nah that works fine because the colorful bubbles state will never be modified while that screen is open. Colorful avatars will be since the conversation list is active while in settings.

There is a super old bug that Monica originally ran into where if you turn on colorful bubbles, then go into a chat, the colors of the bubbles changed, but any new messages that come in will be the old color.
Maybe this has been fixed throughout time and all the changes 🤷🏽♂

Ah okay I haven't seen this personally but it might be a thing 🤷♂


2 fingers draw interferes with navigation

Hello @ someone amazing on the team Excalidraw  !
If I use a touch screen while I'm drawing this is very interferes with navigation, no matter what instrument it is.

[ ] Please Please Add an on/off function 2-finger drawing for freedraw, after for lines, arrows, figures.

Thanks for the attention!

Is there any plan on giving the option to disable 2-finger drawing?  In mobile mode, 2 finger drawing has serious interference with zooming.  See also this issue:
https://github.com/excalidraw/excalidraw/issues/5176


Too many cpu usage for loop restoration filters.

Just finish a profile on rav1e. I use following command: "rav1e 1080p.y4m -o test.ivf -l 10".

Seems cpu usage for deblocking is very high.  sgrproj_stripe_filter used 24.92% cpu on my desktop. And the entire function is not SIMD optimized.
Consider the current development phase, is it worth using some SIMD to speed up it?
thanks

From a cursory look it seems that there are few tweaks that can be done on the inner functions, surely it looks like a target worth of optimization.

FYI,  sgrproj_stripe_filter() is one of LR (Loop Restoration) filter and not from deblocking filter. Another one is Wiener filter.

Yeah, it's pretty bad. There are two things we can do to massively improve this:

Take SIMD from dav1d. This will improve it by a factor of 4-8x. @xiphmont is already working on this.
Parallelize it using the same infrastructure used for tiling. This doesn't reduce CPU usage, but will increase the FPS a lot (especially with tiling) as new frames can't be started until the previous frame has the loop filters applied.

FYI, sgrproj_stripe_filter() is one of LR (Loop Restoration) filter and not from deblocking filter. Another one is Wiener filter.

Thanks for the correction.

From a cursory look it seems that there are few tweaks that can be done on the inner functions, surely it looks like a target worth of optimization.

Yes, this function is the hotest function.
https://github.com/xiph/rav1e/blob/e09612002b3247c2c53c81b9aa94b1ee6d61c989/src/lrf.rs#L185-L199
It will do a square sum on 3x3 block on a pixel (x,y). It's totally 9 multiples. If we can save the last 2 rows at somewhere. It will save 6 multiple for next pixel (x, y+1).  I did not check details, but I think the same trick can use in the column too.

Yeah, it's pretty bad. There are two things we can do to massively improve this:

Take SIMD from dav1d. This will improve it by a factor of 4-8x. @xiphmont is already working on this.

Great! Waiting for the good news.

Parallelize it using the same infrastructure used for tiling. This doesn't reduce CPU usage, but will increase the FPS a lot (especially with tiling) as new frames can't be started until the previous frame has the loop filters applied.

Parallelize is a good area to improve. I did some comparison on Xeon E5 before.
Seems rav1e's cpu usage is very low. This mean, we did not use too much thread in default mode.

codec
fps
cores (cpu usage/100)
fps / cores

rav1e
0.216
1.3
0.1661538462

x265-veryslow
2.4
8.02
0.2992518703

x265-medium
17.74
9.37
1.893276414

x265-ultrafast
110
24.69
4.455245038

x264-veryslow
23
18
1.277777778

x264-medium
76
12
6.333333333

x264-ultrafast
486
10
48.6

thanks

The loop restoration is, indeed, dog slow.  The solving algorithm is simplistic, brute-force, and probably needlessly wasteful.
I don't want to spend much time optimizing the implementation when the implementation is likely to be replaced (that is, the solution I want is not just to do the math faster, but to do far less math to begin with).

The loop restoration is, indeed, dog slow. The solving algorithm is simplistic, brute-force, and probably needlessly wasteful.
I don't want to spend much time optimizing the implementation when the implementation is likely to be replaced (that is, the solution I want is not just to do the math faster, but to do far less math to begin with).

Yes, I agree on @xiphmont 's view. Given research level code, we'd want to save efforts on writing speed optimizing code but rather invest that time on better algorithms for longer term uses.

It will do a square sum on 3x3 block on a pixel (x,y). It's totally 9 multiples. If we can save the last 2 rows at somewhere. It will save 6 multiple for next pixel (x, y+1). I did not check details, but I think the same trick can use in the column too.

In fact, box filters (i.e. 3x3 or 5x5 sum and square sum) are obtained by using the technique called 'Integral Image'. That enables not only reusing of intermediate row sum and square sums but also column wise as well.

@xiphmont, @ycho . thanks for explaining.
I want to spend some time to do local optimization. Except for the loop restoration, any area worth to look at?
thanks

Integral imaging: https://en.wikipedia.org/wiki/Summed-area_table#/media/File:Summed_area_table.png
Where to use integral imaging for box filtering in AV1 Loop Restoration filter :
Sec 2.2, around eq (2), https://people.xiph.org/~yushin/tmp__/A switchable loop-restoration with side-information framework for the emerging AV1 video codec 2017 ICIP.pdf

Hi @ycho ,
Thanks for the information.
Since @xiphmont already working on loop restoration optimization. Any other areas I can help with?
I am still ramp up the AV1, so it's better if the optimization can localize in one or two files or functions.
thanks


I make a new framework ‘Alight’, can anyone try it and give me some feedback?

Hello everyone, I have been using ‘Flight’ for many years, perhaps as early as 2016. I would like to thank ‘Flight’ for helping me complete many project developments and learn a lot of solutions from the source code.
Since the version updates of ‘Flight’ have gradually decreased in recent years, and I also have some new ideas about the framework, I tried to create a new light-weight php framework Alight myself.
After more than a year of use and optimization in production projects, 'Alight' has become more and more stable, so version 2.0 was recently released. I hope more people can try it or give me suggestions.
Hi @mikecao, I don’t know if it’s right to post it here. If it offends you, please tell me and I will delete it immediately.

I think it's a cool little project, but not sure why you posted in the Flight repo for it since it doesn't use Flight? You could start a discussion on this if you'd like some feedback on it, I'm just trying to groom some old issues for the time being.
Thanks!


Remove osmo-bts sources

We're now tracking osmo-bts from git.osmocom.org using source revision 2910b783051aa5059aeb370b164a1ee82ac3095c that includes OC-2G PHY

To sign the commit and be able to merge, follow this for GPG key and then do this command git commit --amend --no-edit -S followed by a force push git push origin osmocom-upstream -f