feat: add ability to set custom headers for client requests.

For #1583 in order to add a custom header.

Sorry I know the tests for these are a bit messy. I will clean them up a bit. I wasn't sure if it would be better to set a single Header or be able to pass a map  to create multiple at once so I made both methods just in case as a proof-of-concept.


fix: rethrow action error on client

closes https://github.com/hi-ogawa/vite-plugins/issues/387

todo

[ ] js (stream)

[x] rethrow in browser callServer
[x] skip "known errors" (redirect error and not found error) from our general ErrorBoundary
[ ] fix broken isPending and isActionPending

[ ] nojs (ssr)

redirect is already handled as direct redirect response
nothing to handle for other errors, so actually we don't need to do anything? for now, let's just add a test case to demonstrate current behavior.

[ ] test

~So, another more canonical approach is that to inject <RethrowActionError /> somewhere in server route tree and let it replay the error on client.~ Well, we would wish to do that, but then that won't make it possible to try/catch action error on userland...
But, we should double check what Next.js really does since try/catch isn't probably advocated method to handle server error anyways. https://nextjs.org/docs/app/building-your-application/routing/error-handling#handling-server-errors
It feels this is a shaky area, so let's postpone dealing with this for now.

It looks like Next.js handles redirection with a different mechanism than just "server error" https://github.com/vercel/next.js/blob/8f93430080f1c18b3f25a0b9c842063f6dc9c9e8/packages/next/src/client/components/router-reducer/reducers/server-action-reducer.ts#L82 and probably this is an easier and concise way to do it.
Probably relevant PRs

https://github.com/vercel/next.js/pull/61588

#529  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on  Graphite

superseded by https://github.com/hi-ogawa/vite-plugins/pull/531


Version Number in Metadata

It seems that issue #307 is affecting a lot of people and there is something I've noticed. I typically test everything in a Vagrant VM locally and then, since we use AWS, I push all of my Chef work up to an AWS node where I run Packer to build AMIs.
Everything is working great on my Vagrant VM, but when I pushed my code up and tried to build the AMI, I also ran into issue #307.
It seems that a number of changes were merged into the cookbook, but the cookbook version was not updated. If the version number had been updated, I could just update the Berkshelf file on my AWS node to match the (working for me) version on my Vagrant node and (most likely) everything would be fine.
When merging changes into the cookbook, I would like to ask that the version number in the metadata.rb file be updated so that we can easily bounce around the versions to stick with the one that works for the end users.

@jlspies1 Apologies for this. We are trying to revamp this cookbook to be more stable.

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Does device_map no longer support CUDA_VISIBLE_DEVICES?

I have some 8-gpus server, but only need 2-gpus per evaluation, so I want to be able to simply set up the specified gpu ids (such as 6,7) and device_map="auto" automatically assign the model to those gpus in a balanced way.
With older version, I achieved this nicely with the setup of CUDA_VISIBLE_DEVICES=6,7. But after I updated to a new version, it no longer worked and it would assign the model across all gpus.
I don't want to specify max_memory because I have servers with different graphics cards that have different gpu memory.
Of course I could write a function to automatically determine the size of the gpu memory to generate max_memory, but I wonder if there is an easier way to achieve what I want, just as I setting CUDA_VISIBLE_DEVICES in older version. And is it a bug that CUDA_VISIBLE_DEVICES is no longer supported?

cc @SunMarc

Hi @nomadlx, thanks for reporting! This is indeed strange and CUDA_VISIBLE_DEVICES should still be supported. I'll look into that. Can you give me a minimal reproductible script + the env that you are using ?

I'm using accelerate==0.22 and transformers==4.33 and it works fine with the following script:
from transformers import LlamaForCausalLM

model = LlamaForCausalLM.from_pretrained(
    "meta-llama/Llama-2-7b-hf", device_map="auto"
)
print(model.hf_device_map)

reproductible script:
import os
import torch
from transformers import AutoModelForCausalLM

os.environ["CUDA_VISIBLE_DEVICES"] = "6,7"
model = AutoModelForCausalLM.from_pretrained("Qwen/Qwen-7B-Chat", device_map="auto", trust_remote_code=True)
print(model.hf_device_map)

version info:
accelerate==0.22.0
transformers==4.31.0
torch==1.12.0+cu113

I have observed a strange phenomenon that when I comment out import torch or upgrade torch, it works well.

@nomadlx what do you upgrade torch to where you see that work? If it works when upgrading torch, that would be our recommendation I imagine

As @muellerzr said, you should then upgrade torch. I tried with the env that you have but it worked on my side 😅

I'm trying to run pretrain stable diffusion model v1.5 but it is throwing me this error "    torch._C._cuda_setDevice(device)
RuntimeError: CUDA error: invalid device ordinal
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
"
this is the cuda visible devices "os.environ['CUDA_VISIBLE_DEVICES'] = '2,3,4'" I have 8 gpus but still it is not giving the same error.

Hi @maheshmouli, this error shows that CUDA is getting an invalid decide ordinal. It's not linked to this issue.


Dont skip tests for CockroachDB

Fix https://github.com/knex/knex/pull/4730/files#r791157891
And I think we are good for an 1.0.2 (doc here : https://github.com/knex/documentation/pull/385)

@intech do you think I can do something for cockroachdb test ? Or I need to revert for now ?

@intech do you think I can do something for cockroachdb test ? Or I need to revert for now ?

Quickly studied the error and can not say how to get around it. I'll ask the cockroachdb engineers for advice and get back.

@OlivierCavadenti This column change is not yet supported https://github.com/cockroachdb/cockroach/issues/47636
And https://github.com/cockroachdb/cockroach/issues/49329#issuecomment-1022120446 for other test case

wait, wasn't the whole idea of the change to avoid altering nullability? or crdb doesn't support such change even without toucing nullability?

@kibertoad I don't really understand the real application of this functionality, which I wrote about in the original issue on another project using knex.
Now the error occurs on this request:
alter table "primary_table_null" alter column "id_not_nullable_primary" type integer using ("id_not_nullable_primary"::integer);

Why do we need to change the column type to int if we already have int when creating the table?
create table "primary_table_null" ("id_not_nullable_primary" integer not null);

@OlivierCavadenti @kibertoad Could you please explain to me the application of these queries?

@intech I think what happens there is that since knex does not know what is the current type of the column, it uses the one specified in alter command. To address that we probably need additional parameter alterType, which omits type change if set.


cli: rewrite

Feel free to paste into your desc:
seemingly done:
fixes: #1349
fixes: #1357
fixes: #1388
fixes: #1552
fixes: #1553

not done yet:
fixes: #878


Fix handling of color for labels

According to the description, the color for origin and axis labels should default to color. However,

if origin color is defined without a frame label, then origin color is ignored
if a frame label is given, then the color is set to blue for origin and axis labels

X = SE3.Rand()
X.plot(color=["r","g","b"], textcolor="k", origincolor="k", style="line")

X.plot(frame="A", color=["r","g","b"], textcolor="k", origincolor="k", style="line")

There was some "code duplication".

Note, this fix is slightly different from #67 It considers color of origin as well.

will this resolve the issues with #67 and #69 as well?  This might as well all go out in 1.1.6 soon, am keen to push the r2q fix.

Yes, this will fix #67 but not #69. #69 is a different issue.


Add bio section

It would be great to have a bio section in the portfolio, where you all can talk more about who you are, and your programming story.

I would like to work on it, as discussed with the pod

Why this PR
Added a About me/Bio section in the existing index page, right below the profile section.
Files added

about.html
about.scss
about.yml

It is responsive to smaller viewports as well.

The section is divided into two sections; the info and the bio which are two separate div child inside one about-section div
The responsiveness is defined in about.scss , using grid they have been stacked side-by-side and one top of another according to the screen size.

Issue resolved
Issue #6

Closed by #11.
@MsMore You generally don't need to include the Pull Request contents on the Issue. Just linking to the Issue in the PR will automatically add a link to the PR on the Issue! :)


Missing OpenJDK 8 Release Notes

Platform and architecture (e.g. Linux/x64:
All
Java version (from "java --version") e.g. 1.8.0_181, 11.0.4+11 etc.:
8u242
Variant e.g. HotSpot or OpenJ9:

Have you tested it with other vendors' java:

Steps to reproduce:

Error messsage and/or description of what is not working as expected:
Hey there,
https://adoptopenjdk.net/release_notes.html does not list the release notes for the available version 8u242.

I would like to verify that the recently published Oracle Java CPU issues are fixed in this release.
Cheers
Dennis

Duplicate of https://github.com/AdoptOpenJDK/openjdk-website/issues/673


HELP

set target
File "", line 1
set target
^
?? am i doing something wrong?

What exactly is your problem?


Add multi sample capability.

Adds preliminary multi-sample capability.

@jmtsuji Hey, could you review this visually / on your server and see if you can find any bugs. I assume there will be when I finally run it, I'm updating my test server environment tomorrow but I wanted you to give a heads up for review to pick out any big errors.
--dry-run works and makes the right copies of rules to run.

So at the top of the snakemake file I create a dictionary of sample objects, keyed by identifiers, representing each sample.
I also assigned a list at the top called SAMPLE_NAMES that contains the sample identifier list.
I added a rule called set_up_sample_directories that takes this dictionary and uses it to create all the sample output directories and symlink the input fastq files to directories (if they aren't gzipped I gzip them here).
for this rule and each of the checkpoint rules I used expand to get the list of output files based on the sample identifiers.
expand("{sample}/{sample}_long.fastq.gz", sample=SAMPLE_NAMES) # This expands out to a list of long fastq files paths for each sample.

I added {sample}/ wild cards to all the paths.
for some of your existing expand() I added {{sample}}/. the second braces tells the expand not to fill in sample. So you get an expansion but each expanded path starts with {sample}/which is later interpreted as a wildcard.
In rules params: cannot access wildcards directly so I either moved them into input or output or manually accessed the wild card with a lambda function.
strain=lambda wildcards: wildcards.sample # Get sample name from wildcards.

I not sure if this is the proper way to access them but we will see at runtime.

I also moved some of your checks whether or not to use short read polishing to its own variable, POLISH_WITH_SHORT_READS, at the top of the the file. I think we could add this as a config variable down the road.
I estimate that it might be trick to figure out the logic of short read polish or not on a per sample basis would be tricky and might need a significant rewrite of the switching logic.

As one other note, I haven't been able to commit new rules yet for short read QC, although I have some draft code started. Sorry for the delay here! Might it work well for me to commit the short read QC rules directly to the multi-sample version of the workflow, given that the multi-sample version is already in reasonable shape? For example, next week I could make a fork of this branch and use it to add the short read QC rules. Thanks!

As one other note, I haven't been able to commit new rules yet for short read QC, although I have some draft code started. Sorry for the delay here! Might it work well for me to commit the short read QC rules directly to the multi-sample version of the workflow, given that the multi-sample version is already in reasonable shape? For example, next week I could make a fork of this branch and use it to add the short read QC rules. Thanks!

@jmtsuji This sounds good to me. Feel free to branch and merge into this branch.

TODO: I also think we should add more {sample} wild cards to the output file names so you can differentiate files from each other. For example, name the different assembly.fasta files in different sample folders with their sample names (e.g. bs4_assembly.fasta).

@jmtsuji New updates to this branch to fix some preliminary bug fixes I encountered.

TODO: I also think we should add more {sample} wild cards to the output file names so you can differentiate files from each other. For example, name the different assembly.fasta files in different sample folders with their sample names (e.g. bs4_assembly.fasta).

Agreed -- this sounds like a nice idea. For now, I will focus on end-to-end testing, but let's keep this in mind when doing edits to the snakefile down the road.


Import wasm mime type on start script

An imported wasm module has the wrong mime type when using the start script.
Needs to be application/wasm mime type.

I switched to rollup starter template and all was good. Closing.


Use WHERE EXISTS instead of INNER JOIN for collection navigation Include

when there is no ORDER BY Clause or ORDER BY is on principal key properties
resolves #4903

:shipit:


Add button to refresh the page on updates

When new updates are marketed, it can be confusing for users who refresh the page and see nothing. When the service worker fetches files that are different to those shown, there could be a small notification telling to refresh the page.
Additionally, the web app could periodically check for updates (let’s say once per minute), and show that notification even without having ro refresh the page first. If that’s the case, there should also be a cross icon to hide the nitification in case the user doesn’t want to interrupt their conversation at that moment. Also the user should get the new version by refreshing the page just once.

?offline=false


Outline renders only for one of the same skinned meshes

If there are multiple skinned meshes with animation (sharing the same Handle<Mesh>), and I put OutlineBundle on them, only one will have its outline rendered. I assume https://github.com/komadori/bevy_mod_outline/commit/8e7bbdb0807e1b63ffe1961600707d72a7535946 doesn't count for skinned meshes somehow, because I tested it both on shapes and animation_fox examples, and only the latest reproduced this issue.

Repro
For reproduction, please use this patch for examples/animated_fox.rs
--- a/examples/animated_fox.rs
+++ b/examples/animated_fox.rs
@@ -64,6 +64,8 @@ fn setup(
     commands
         .spawn(SceneBundle {
             scene: asset_server.load("Fox.glb#Scene0"),
+            transform: Transform::from_translation(Vec3::new(-5.0, 0.0, 0.0))
+                .with_scale(Vec3::splat(0.1)),
             ..default()
         })
         .insert(OutlineBundle {
@@ -75,6 +77,22 @@ fn setup(
             ..default()
         })
         .insert(AsyncSceneInheritOutline);
+    commands
+        .spawn(SceneBundle {
+            scene: asset_server.load("Fox.glb#Scene0"),
+            transform: Transform::from_translation(Vec3::new(5.0, 0.0, 0.0))
+                .with_scale(Vec3::splat(0.1)),
+            ..default()
+        })
+        .insert(OutlineBundle {
+            outline: OutlineVolume {
+                visible: true,
+                width: 3.0,
+                colour: Color::srgb(0.0, 1.0, 0.0),
+            },
+            ..default()
+        })
+        .insert(AsyncSceneInheritOutline);
 }

 // Once the scene is loaded, start the animation

Bevy doesn't support automatically batching skinned and morphed meshes. Hence, there is system inside Bevy which adds the NoAutomaticBatching component to entities with such meshes. Otherwise, each element in the batch would use the data from the first element and, in the case of skinning at least, render on top of each other. The bug here is that bevy_mod_outline didn't respect the NoAutomaticBatching component.
Fixed in 185c50d0731911d5c5288acae2230e6530a243f4. I'll make a new minor release shortly.

Fix released in 0.8.1.


Allow requirement of optional variable

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[x] Tests for the changes have been added (for bug fixes / features)
[x] Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)
[ ] bumpversion (major / minor / patch) has been called on this branch
[ ] Tags have been pushed (git push --tags)

What kind of change does this PR introduce?

Fixes a bug in core.utils.infer_kind_from_parameter and  in Indicator._assign_named_args that was forbidding the requirement of optional variables (i.e. : change an indicator through yaml so that an optional variable is not optional anymore.)

Does this PR introduce a breaking change?
No
Other information:
The way to make a variable non-optional in a yaml def, is the following:
WATER_BUDGET:
  base: water_budget
  input:
    tasmin: tasmin
    tasmax: tasmax
  index_function:
    parameters:
      method: BR64

In this example, the variables tasmin and tasmax, which are optional in atmos.water_budget are now semi-optional. There is still a "bug" that makes the annotation unchanged (i.e.: WATER_BUDGET.parameters['tasmin']['kind'] == OPTIONAL_VARIABLE), but the default value has passed from None to "tasmin". Thus a call with WATER_BUDGET(ds=ds) will be successful (it would fail earlier). And a call like WATER_BUDGET(pr=ds.pr) will fail because tasmin wasn't None, it was "tasmin". However, the error raised will be unclear. I'll fix this in a further PR.

Well, there was a mighty bug in there!  wrapped_partial stores injected arguments in a _injected dictionary, attribute to the new function. Well, we were not copying it, so wrapping a wrapped function would update the same dictionary. That's why atmos.liquid_precip_ratio was getting the injected thresh of example.LPRatio. Woups.
While fixing this, I realized there was a way to simply update the "kind" field in Indicator.parameters and to change an annotation when an optional variable is being made non-optional. So this fixes the error I discussed in the header comment!


CoreMLTools Installation under Python3 in Windows Anaconda

Note that CoreMLTools doesn't support "pip install coremltools" under Python3 with Windows. Users need to use $ pip install git+https://github.com/apple/coremltools to install CoreMLTools from the source from GitHub.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c28f709-f39f-51e1-dbd6-049496ec9b8d
Version Independent ID: b2a668cf-c3b8-2236-2f6c-0e876f4393a0
Content: Convert existing ML models to ONNX - UWP app developer
Content Source: windows-apps-src/machine-learning/conversion-samples.md
Service: unspecified
GitHub Login: @wschin
Microsoft Alias: wechi

I tried to install kraken on a python environment and got this error below:
ERROR: Could not find a version that satisfies the requirement coremltools (from kraken) (from versions: none)
ERROR: No matching distribution found for coremltools (from kraken)
As I use windows, I used the command suggested in the above post and could not complete the download of CoreMLTools with a longer error message. Has anyone had this issue before?
ERROR: Command errored out with exit status 1:
 command: 'C:\Users\reyno\Envs\p3env-wk2\Scripts\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\reyno\\AppData\\Local\\Temp\\pip-req-build-c80vbasj\\setup.py'"'"'; __file__='"'"'C:\\Users\\reyno\\AppData\\Local\\Temp\\pip-req-build-c80vbasj\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\pip-egg-info'
     cwd: C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\
Complete output (21 lines):
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\setup.py", line 11, in <module>
    from coremltools import __version__
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\__init__.py", line 50, in <module>
    from . import converters
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\converters\__init__.py", line 9, in <module>
    from . import xgboost
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\converters\xgboost\__init__.py", line 6, in <module>
    from ._tree import convert
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\converters\xgboost\_tree.py", line 6, in <module>
    from ._tree_ensemble import convert_tree_ensemble as _convert_tree_ensemble
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\converters\xgboost\_tree_ensemble.py", line 6, in <module>
    from ...models.tree_ensemble import TreeEnsembleRegressor as _TreeEnsembleRegressor, TreeEnsembleClassifier
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\models\__init__.py", line 6, in <module>
    from . import datatypes
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\models\datatypes.py", line 12, in <module>
    from ..proto import FeatureTypes_pb2 as _FeatureTypes_pb2
  File "C:\Users\reyno\AppData\Local\Temp\pip-req-build-c80vbasj\coremltools\proto\FeatureTypes_pb2.py", line 6, in <module>
    from google.protobuf import descriptor as _descriptor
ModuleNotFoundError: No module named 'google'
----------------------------------------

ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

I did the installed the following 3 to make it work. (I installed it on Windows 10, 64 bit)
pip install google
pip install google.cloud.bigquery
pip install google.cloud.bigquery

Apologies for the delay in this response.
I've been discussing this matter with the ML engineering team, as we work to make larger updates across the docset. This page will be updated soon with a slew of new information, including updated instructions to CoreMLTools installation.
Thank you for your patience, and for the good suggestions in this thread.


add comments for the secp256k1 package

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.255%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7065

Relevant Lines:
9265

💛  - Coveralls


qsub jobs submission error

I have another problem with job submission.the job submission section is as follows:
and my submit command is：
qsub -S /bin/bash -sync y -V
-q all.q
-N Assemble
-o Assembleoutput
-e AssembleSTDERR
-pe smp 10
-l h_vmem=1000M
/home/wuxiaopei/miniconda2/bin/fc_run.py /data/wuxiaopei/fc_run.cfg
Immediately，the  error occurs :

I don't know how to do with it.Can you tell me ?Thank you very much``

You might need to submit "python" as the executable and fc_run.py fc_run.cfg as the arguments. It seems to be trying to execute fc_run.py as a bash program.


python train.py --config ./configs/transformer.yaml

Loading embeddings: 400000it [00:55, 7234.47it/s]
Saving vectors to /home/a/Text-Classification/data/outputs/ag_news/sents/glove.6B.300d.txt.pth.tar
Traceback (most recent call last):
File "train.py", line 73, in
trainer = set_trainer(config)
File "train.py", line 28, in set_trainer
model = models.setup(
File "/home/a/Text-Classification/models/init.py", line 83, in setup
model = Transformer(
File "/home/a/Text-Classification/models/Transformer/transformer.py", line 53, in init
self.encoder = EncoderLayer(d_model, n_heads, hidden_size, dropout)
File "/home/a/Text-Classification/models/Transformer/encoder_layer.py", line 22, in init
self.attention = MultiHeadAttention(d_model, n_heads, dropout)
File "/home/a/Text-Classification/models/Transformer/attention.py", line 56, in init
assert d_model % n_heads == 0
AssertionError

Had class labels encoded from 0, actually in this code is expecting class labels from "1"  Not sure If the error is related to class labels starting from 0, it should start from "1"

Sorry for the late reply. This error occured because emb_size % n_heads was not 0 in configs/ag_news/transformer.yaml, and has been fixed in https://github.com/Renovamen/Text-Classification/commit/0ab407beca8271f7bda98585a8b5b0e0f2de87f7. Thanks!
Also, it seems that the way to encode the labels (start from 0) in this code is ok. Label ids in the dataset are start from 1, however, when preprocessing the dataset, this code maps the original label_id to label_id - 1:
https://github.com/Renovamen/Text-Classification/blob/0ab407beca8271f7bda98585a8b5b0e0f2de87f7/datasets/preprocess/sentence.py#L66
So in the preprocessed data, label ids are start from 0.


Add metadata to Persistent Volume example so we can use in web console.

Can one of the admins verify this patch?


Optional Arguments

Hi,
Thanks for the awesome tool.  I need to schedule very specific periods, day, month, & times, however the  "scheduler-cli create-period" does NOT support --months, like the documentation states:  https://docs.aws.amazon.com/solutions/latest/instance-scheduler/components.html
I receive the following error:  scheduler-cli: error: unrecognized arguments: --months 4
Performing a "help" -h on the command indeed does not list --months.
Will this option become available, as it would be most helpful?
optional arguments:
-h, --help            show this help message and exit
--begintime BEGINTIME
Begin time of the period in hotmat hh:mm
--description DESCRIPTION
Description for the period
--endtime ENDTIME     End time of the period in format hh:mm
--monthdays MONTHDAYS
Calendar monthdays of the period
--name NAME           Name of the period
--weekdays WEEKDAYS   Weekdays of the period
--query QUERY         JMESPath query to transform or filter the result
--region REGION       Region in which the Instance Scheduler stack is
deployed
--stack STACK, -s STACK
Name of the Instance Scheduler stack
Thanks
Darren

Hi Darren,
I'll put these on out  list for a next updatr, In the meantime if you want to add them yourself by just inserting 3 lines of code to pass the parameter to the cli handler of the scheduler that runs as part of the Instance Scheduler Lambda function.

Download the scheduler-cli.zip and extract it
Open the file scheduler_cli.py
Locate line HELP_PERIOD_MONTH_DAYS = "Calendar monthdays of the period" and insert line
HELP_PERIOD_MONTHS = "Months" of the period" below it

HELP_PERIOD_MONTH_DAYS = "Calendar monthdays of the period"
HELP_PERIOD_MONTHS = "Months of the period"

Locate PARAM_MONTHDAYS = "--monthdays" and insert the line PARAM_MONTHS = "--months"  below it

PARAM_MONTHDAYS = "--monthdays"
PARAM_MONTHS = "--months"

Locate period_parser.add_argument(PARAM_MONTHDAYS, help=HELP_PERIOD_MONTH_DAYS) and insert period_parser.add_argument(PARAM_MONTHS,help=HELP_PERIOD_MONTHS) below it

    period_parser.add_argument(PARAM_MONTHDAYS, help=HELP_PERIOD_MONTH_DAYS)
    period_parser.add_argument(PARAM_MONTHS,help=HELP_PERIOD_MONTHS)

Please let me know if you have any issues
Arie

I can confirm that worked well, except I needed to add a space in the number 5 insert.  Posted here just in case anyone else just blindly copies and pastes :-)
period_parser.add_argument(PARAM_MONTHS, help=HELP_PERIOD_MONTHS)
Added a space  ^
Cheers,
Darren

Fixed in v1.2.0


Changing Gradle cve scanning to work with dependency check

Changing Gradle CVE Scanning action to work with dependency check and changing cron job to work manually

The Gradle check passes, well done @josspo  and @TheJuanAndOnly99 !
I see that you removed the on: content, I think that was a mistake right? Could you please restore it?
on:
  schedule:
    - cron: '0 8,18 * * 1-5'
  push:
    paths:
      - 'gradle/build.gradle'
      - 'allow-list.xml'
      - '.github/workflows/cve-scanning-gradle.yml'


Option to define --features when using the rust cargo backend

If I read the rust cargo backend source  correctly, there is currently no way to define the --features flag (or any install flags) when installing a cargo lib right? Just making sure, i would be open to create a PR.
A use case is installing spotifyd with some specified features.

not currently, no. It's probably a use-case for tool options.


Accepted aspect ratios not editable

Settings is not retaining changes to "Accepted aspect ratios" field and reverts to defaults after saving.
It does save the other setting changes, but not the "Accepted aspect ratios".

Thank you for the report, I believe I found the issue.  It should be corrected in release v1.0.2.  Please give it a try and let me know.

It's fixed now - but how do we launch the scan of movies? I don't see any scheduled task for it.
BTW, the latest version that you published was flagged as containing a virus.

Glad it is fixed.  The process runs as part of metadata retrieval.  If you want to run everything you should be able to kick it off using "Scan All Libraries" on the dashboard.  Depending on your hardware it can take a good bit of time to analyze each movie.  You can tell the process is working from log messages like...
Jellyfin.Plugin.OriginalAspectRatio.Providers.OriginalAspectRatioMetadataProvider: Performing ffmpeg cropdetect on "<file>" to determine original aspect ratio.
Jellyfin.Plugin.OriginalAspectRatio.Providers.OriginalAspectRatioMetadataProvider: Cropdetect found width of 3840 and height of 1600 for "<file>".
Jellyfin.Plugin.OriginalAspectRatio.Providers.OriginalAspectRatioMetadataProvider: Discovered original aspect ratio value of 2.4 for "<title>"
Jellyfin.Plugin.OriginalAspectRatio.Providers.OriginalAspectRatioMetadataProvider: Matched discovered original aspect ratio of 2.4 to accepted original aspect ratios value of "2.40" for "<title>".
Jellyfin.Plugin.OriginalAspectRatio.Providers.OriginalAspectRatioMetadataProvider: Accepted original aspect ratio of 2.40 for "<title>" matches video stream aspect ratio of 2.40, skipping.

I'll double-check the virus flag but the only things in the .zip should be the plugin .dll and metadata.json and the only change was the one documented in the changelog.


Add application menu sample

Nice sample apps :)
But, There is not application menu sample. So added.

:+1 Thanks for your contributions!


fix(sample): fix the sc beta annotation example yaml

Signed-off-by: prateekpandey14<EMAIL_ADDRESS>

Already pushed this change via this commit: https://github.com/openebs/openebs/commit/ccae860af9595b45be76e41740869e1c7f7059d2


All of these have been deprecated for over a year now (since December 2021) and this integration is still using it.
Additionally removed a couple of class attributes that have been set to their defaults.
Please note: All unit constants are currently being replaced as well. Please check out the Home Assistant developer blogs to keep up with upstream changes.
Happy New Year 🥂
../Frenck

Hello @frenck
Thanks for your contribution, this LGTM. I'll just test it and merge it shortly.
I'm not the most rigorous developer around so I'm glad you went through this.
Happy new year to you too, cheers 🥂
DVD


Examples of HTML tables replacing an image

Do not merge!!!
This is just a demonstration.

I think it is generally a good idea to move the data from the table in an image form to a table.
It is unfortunate, that the look of the table in a form of an image looks better than a markup table...


operator [N] tempo-operator (0.1.0)

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

/merge possible

/merge possible

@rubenvp8510 thanks for the contribution. A few comments on the CSV:

you probably want metadata.annotations.containerImage to match the pullspec used for the image in the deployment: you should add the tag to containerImage as well
the link to the site is invalid: please use a valid url
please add a couple of sentences to the description fields: you can check how it displays in the preview.

@rubenvp8510 thanks for the contribution. A few comments on the CSV:
1. you probably want `metadata.annotations.containerImage` to match the pullspec used for the image in the deployment: you should add the tag to containerImage as well

2. the link to the site is invalid: please use a valid url

3. please add a couple of sentences to the description fields: you can check how it displays in the [preview](https://operatorhub.io/preview).

Thanks for the review! I've already addressed the comments!

/merge possible

/merge possible

/merge possible

/merge possible

/merge possible

/merge possible

/merge possible

/merge possible

/merge possible


fix for Huobi withdraw fee (SOLO currency)

Is it really zero fee if it's returned null?

Yeah, it's more like "not available". This is the currency in question:
{ 	"currency": "solo", 	"assetType": 1, 	"chains": [ 		{ 			"chain": "solo", 			"displayName": "SOLO", 			"fullName": "XRP", 			"baseChain": "XRP", 			"baseChainProtocol": "XRPTOKEN", 			"numOfConfirmations": 1, 			"numOfFastConfirmations": 1, 			"depositStatus": "allowed", 			"minDepositAmt": "5", 			**"withdrawStatus": "prohibited",** 			"minWithdrawAmt": "5", 			"withdrawPrecision": 7, 			"maxWithdrawAmt": "9911613.000000000000000000", 			"withdrawQuotaPerDay": "9911613.000000000000000000", 			"withdrawQuotaPerYear": null, 			"withdrawQuotaTotal": null, 			"withdrawFeeType": "ratio", 			**"transactFeeRateWithdraw": "0.0002",** 			"addrWithTag": true, 			"addrDepositTag": true 		} 	], 	"instStatus": "normal" }
Without this fix, service using the lib crashes at init, so this is a quick patch for the problem. I didn't want to set null, to avoid problems in other parts of code.
If anybody wants to use SOLO and requires info about withdraw fee, there are bigger changes needed in xchange-core - withdraw fee ratio (percent) would need to be added to meta data and possibly other places (note that currently SOLO is disabled for withdraw).

I think  BigDecimal transactFeeWithdraw = huobiCurrency.getTransactFeeWithdraw() != null ? new BigDecimal(huobiCurrency.getTransactFeeWithdraw()) : null; would be a better solution as we use null to indicate unknown values
if you could change it to that that resolve the above conflict then I'll merge it this week


Bug Report: Cannot Use Standard Array/Point Buy

After updating to the latest version, I no longer have the option to control stat allocation using Standard Array or Point Buy:

I can enter stats manually or roll but I can't use the default Standard Array or Point Buy fields.

I’m looking at the screenshots and not seeing any issues. Can you please be more specific? What do you mean by “can’t use”? As it seems to me you’ve shown screenshots of it being used.

On Standard Array and Point Buy, the number-adjustment section cannot be interacted with in any way. It appears in the drop-down bar, and will carry over the numerical settings. If I manually type numbers in the manual entry box, they will appear on the display
On the Manual Entry page, I can type in the number field:

That works like it's supposed to.
If I type in manual numbers and then switch to Standard Array it gives me the option to reset Standard Array:

However once I do so, I can no longer move the standard array numbers. The numbers cannot be further interacted with:

If I want to move the 15 down to Charisma, I can't do it. There used to be up/down arrows next to each number, allowing the numbers to be moved. That is no longer possible.
The same situation occurs with Point Buy. If I manually enter numbers, it will let me "reset scores"

However, once I do so, I can't further adjust the scores. There are no up or down arrows allowing me to adjust what the scores are. There is no way to adjust these numbers up or down on this page. If I disable manual entry and dice rolling (which is what I usually do!) then there is no way to adjust the numbers at all.

If I switch back to version 1.4.1 it works correctly and the up/down arrows are there to be interacted with:

fixed in https://github.com/geoidesic/foundryvtt-actor-studio/releases/tag/1.4.5


Document the gesture arena

 Issue by krisgiesing
Wednesday Sep 16, 2015 at 23:21 GMT
Originally opened as https://github.com/flutter/engine/issues/1201

The principles involved in how gestures interact with each other is novel enough that it probably merits some extra developer documentation.

@krisgiesing  Is http://flutter.io/gestures/ sufficient?

I think it's a good introduction to the topic.  We probably also need more detailed API documentation to go with it; for example, you mentioned wanting to document how gestures join the arena, and the sweep semantics. That's only relevant for gesture authors though so it doesn't need to go in the general docs.


Add 3D movement commands to discrete movement

As #219 alludes to, the "jump" command isn't particularly useful at the moment.
We need commands for moving up/forward, up/back, etc.
(The difficulty will be coming back down again - in order to have a chance at keeping state/action pairs relevant, we need the agent to descend immediately, not at the speed of Minecraft's own gravity.)
See also #321.

I seem to recall the original conversation only being about jump, but you need to give full single movement steps to all points of the 3x3 cube so that the step reward is consistent


variable names read incorrectly for some files

When reading some .sav files, variable names such as "Q1", "Q2", "Q3 are coming in as "A_1\0\0\0\0\0", "A_2\0\0\0\0\0", "A_3\0\0\0\0\0". If I open the same file in SPSS the variable names are correct "Q1", "Q2", "Q3" and if I re-save this file in SPSS, the file size shrinks slightly and the library reads the new saved file's variable names correctly. Any idea?

Replacing "\0" character in private static string GetLongName(MetaData metaData, VariableRecord variableRecord):
metaData.LongVariableNames.Dictionary.TryGetValue(variableRecord.Name.Replace("\0", ""), out longName))


Champion select doesn't load

Champion select doesn't load for some reason
xadamxk - Today at 3:20 AM
no champ select
I had everything enabled except for: Practice tool extra bots, and insta-lock

Unknown why at this point, needs further research.

3712a7cbe36aaffc7a5605ad9562e145fd7c1b48 should fix this, included in release 2.0.2. Closing this for now. Re-open if it still occurs

Opening for clarity, still occuring. Still not sure whats causing it, previous fix seemed to just fix one of several symptoms of the actual issue.

This project is useless if you cannot join champion select

I had the issue as well, I'm certain that the fancy-select plugin has something to do with it, since disabling it seems to have fixed the issue.


Replace golang.org/x/text version

Refs:

https://github.com/stolostron/backlog/issues/26349

Signed-off-by: Justin Kulikauskas<EMAIL_ADDRESS>Closes: #257

/cherrypick release-2.6


Bump Storybook from 6.5.16 to 7.0.2 in /frontend-react

This PR updates Storybook 6.5.16 to 7.0.2 remediating three "High" dependency vulnerabilities.
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:

Include steps to test these changes

Changes

Storybook 7.0 Migration Guide
Storybook 7.0 full migration notes

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Linked Issues

Fixes #issue

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

I'm not comfortable with this bump since it's a major version increase. I've made a PR to address the actual packages with the vulnerabilities without bumping storybook here: https://github.com/CDCgov/prime-reportstream/pulls#:~:text=Pull requests list-,Address storybook npm audit vulnerabilities,-experience .

I'm not comfortable with this bump since it's a major version increase. I've made a PR to address the actual packages with the vulnerabilities without bumping storybook here: #9024 .

I agree with Joseph about this -- let's take a look at his linked dependencies pull request, and we can bump up Storybook proper separately in the future if needed.

Postponed in favor of https://github.com/CDCgov/prime-reportstream/pull/9024


Adds docs for assistant_id

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[X] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

@m-vdb I asked for your review because you haven't been involved in the implementation so far, and I wanted to check if this docs update is comprehensive enough.


Add Wizard Step Validation

Hi there,
Is it possible to add "Wizard Step Form Validation"?  Simply disable "Next" button until all required form fields filled?
Thanks,

What do you mean with "Wizard Step Form Validation"?
If you want to add a form to one of your wizard steps and want to allow a user to go to the next step only if the content of the form is valid, this is possible.
In my opinion you have two options to do this. First you could use:
...
<button type="submit" [disabled]="!heroForm.form.valid" nextStep>Next Step</button>
...

This disables the button, until the form is valid.
The second approach you could use would be to use the [canExit] input of the wizard step:
<wizard-step [canExit]="heroForm.form.valid">
...
<button type="submit" nextStep>Next Step</button>
...
</wizard-step>

Thank you

In my case, I want the form to be validated to go to next step. So, I am passing validateForm() inside [canExit] attribute. It seems this is being called multiple times which is also triggering the error messages. Hence, on init, when the fields are empty, the fields are showing errors.
How to fix this case?

@kamlekar I think your problem is similar to #33. If the solution for #33 doesn't work for you, please post a working example, which illustrates your problem

Solutions looks good but i am facing problem at back button
What i should have to do if i want to keep canexit event on next button only not on back button
Right now i am sending data on third step of my form, if i am on third step and click on back button , it still calls my function written on canexit

@janakprajapati2112 [canExit] also accepts a function, taking a MovingDirection enum value, as a parameter.
If the user navigates backwards, i.e. from the third step to the second step, the function is called with MovingDirection.Backwards.
On the other hand, if the user navigates forwards, i.e. from the third step to the fourth step, the function is called with MovingDirection.Forwards.
An example, how such a function can be written, and be passed to the [canExit] input, can be found here.


Fixes issue with unknown positions

Fixes https://github.com/mark1foley/ha-gtfs-rt-v2/issues/20

Hi,
I believe #20 has already been fixed.  Not sure if we need this additional change.  Can you provide a brief description of the logic.
Mark

https://github.com/mark1foley/ha-gtfs-rt-v2/issues/20 has incorrect python formatting. It should be.
        positions = (
            self._get_vehicle_positions()
            if self._vehicle_position_url:

            else: {}
        )


[1.x] Allow configurable trimming

If the pulse:work command fails the Ingest will continue to build up in size.
With Redis this is problematic as it is keeping itself in memory. When the pulse:work command fails we already trim the ingest on a lottery whenever we put data into the ingest, but it will always retain 7 days worth of data.
That could be problematic for some application depending on their traffic size.
This PR allows the maximum retention for the ingest to be configured.
This value is respected whenever the ingest is trimmed, so it is not guaranteed that the ingest will only contain the configured value until trimming occurs, which again, may happen on a lottery basis.

replaced by https://github.com/laravel/pulse/pull/184


Image embedding and text embedding

How to generate image embeddings and text embeddings using CogVLM?
I need to compare an image and the text description to find how well the text describes the image. If I have embedding for text and image, I can calculate the distance or similarity score.

similar here #300 may be can discuss there


Test Resources breaks gradle build caching

Expected Behavior
If I use Gradle's build cache to build a multi-module project, I'd expect that already-built, unchanged modules with no other module dependencies will be skipped over.
Actual Behaviour
However, if using test resources, the startTestResources task always runs, causing the tests to then run again.
The only workaround is to start a test resource server yourself. If you do that, the task is skipped and the tests don't rerun.
Steps To Reproduce
No response
Environment Information
No response
Example Application
No response
Version
3.6.1

This is an interesting issue. The problem is as follows: when the test resources service starts, it will be spawned on a particular port and will use a particular access key (in order to prevent random connections). Those port and access key are written in a properties file, which then needs to be on the test classpath. Obviously, the contents of the file doesn't really matter for the build cache, but it would change for every execution...
I suspect we can use the RuntimeClasspathNormalization strategy to ignore those.

I haven't forgotten about this issue, I just don't have a solution for it yet.

It would also be good to avoid spinning up the test resources if the underlying tests are up to date.

It would also be good to avoid spinning up the test resources if the underlying tests are up to date.

This isn't possible, unfortunately: there are multiple limitations (Gradle API, the fact you can run the tasks separately, keepalive, ...).


Golden image multiple k8s versions

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

Running https://jenkins.azure-containers.io/view/acs-engine/job/k8s-deploy-linux-default-CSE-PR/ on this branch since 8/16 at 10:20am PST

/lgtm


Error: Could not locate the bindings file.

Building with webpack it seems that the bindings don't get copied to the output directory of the build correctly. I added CopyWebpackPlugin to copy the files from node_modules/@google-cloud/profiler/build/Release to my build directory. Even after doing this and verifying the the file is present the app fails to start saying it can't locate the bindings file. It gives output saying it tried various files, one of which is the exact full path to the copied binding.
error given was: Error: Could not locate the bindings file. Tried:
##Note: the first line here is the correct and full path to the binding....
 → /Users/imagio/dev/arpeegee/build/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/build/Debug/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/build/Release/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/out/Debug/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/Debug/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/out/Release/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/Release/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/build/default/sampling_heap_profiler.node
 → /Users/imagio/dev/arpeegee/compiled/8.11.3/darwin/x64/sampling_heap_profiler.node

Turns out this was due to webpack. I was bundling node_modules in my server bundle but there are a lot of node things, cloud-profiler-nodejs included, which webpack cannot compile for node yet. I marked my node_modules as externals using webpack-node-externals and everything works properly now.


Need to choose a PRO framework about RPC benchmark

It can help us run benchmark with one click

JMH introduced!


Ticket iterations

[ ] Requires #10 to be completed

Each iteration will be registered with the username, the date and time, and a comment.
It can be a status change or a ticket modification. This will provide detailed ticket
information as well as an audit trail.

An additional field should be added to Tickets. This field should basically be the audit trail for a ticket.
An iteration should:

[ ] Be registered by a username
[ ] Have a Date and time
[ ] Have a comment
[ ] Change the status or log the change of status
[ ] Log if the ticket was modified (Could be tied into the Update operation)

The way I'm thinking is of two ways:

add a field to tickets that will be an array of objects. Each object is an iteration containing all the information of said iteration.
Make a new collection / model being a ticket iteration, and have a new field in ticket with an array that references an iteration

Though I think 1st option might be better


Missing check for cb causes fatal error

At https://github.com/substack/module-deps/blob/master/index.js#L258 the cb is not checked for validity. All other occurrences (as of today) in the function are checked except this one.

I'm having the same issue at https://github.com/substack/module-deps/blob/master/index.js#L315, there is no null/undefined check on cb in the walk function at this line and the function is called from several locations internally in this file with no callback. This is causing a "fatal error: undefined is not a function" exception to be thrown for me with browserify when trying to use externals. Other places in the same function body are doing null/undefined checks on cb before execution.


[BEAM-12908] Add a 10 second sleep to the IT after topic creation to wait for propagation

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

 Is that okay with you?

hm frankly I don't know of a different way of achieving this, and it should hopefully work fine. I'll merge this for now, as it would help fix the flakiness of the test. I hope we don''t have to refactor later : /


BLEClient heap memory exhausted after some disconnect/connect ricycle

Hi all,
I'm actually using official Arduino ESP32 library available from inside the Arduino IDE.
I need to connect via BT from an ESP32 to a peripheral made with an HC-08 connected to an arduino micro, all configured to sleep as much as possible to save energy (about 300uA in sleep), than read/write some info from there and close connection to get peripheral back in sleep mode, than reconnect only once needed and cycle this way over and over.
I'have started with BLE Client examples in the lib distribution but after some cycles everything crashes. After some debugging find out a problem with a heap memory exhaustion.
Just tried to do some research and some debugging but I would appreciate if someone would be so kind to get me some tips to find a way out from here.
this is the output from very first cycles where you can see rapid memory exhaustion:
rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:1
load:0x3fff0018,len:4
load:0x3fff001c,len:1100
load:0x40078000,len:10088
load:0x40080400,len:6380
entry 0x400806a4
BLE FreeHeap: 274408
Starting Arduino BLE Client application...
BLE Advertised Device found: Name: HC-08, Address: 88:4a:ea:8e:38:5d, manufacturer data: 48432d30380000000000000000000000000000000000, serviceUUID: 0000fff0-0000-1000-8000-00805f9b34fb, txPower: -6
BLE RSSI: -65
Forming a connection to 88:4a:ea:8e:38:5d
1-BLE FreeHeap: 181876
 - Created client
2-BLE FreeHeap: 181148
 - Connected to server
3-BLE FreeHeap: 177004
 - Found our service
4-BLE FreeHeap: 172504
 - Found our characteristic
5-BLE FreeHeap: 171076
We are now connected to the BLE Server.
Setting new characteristic value to "Time since boot: 2"
BLE FreeHeap: 171024
onDisconnect
BLE Advertised Device found: Name: HC-08, Address: 88:4a:ea:8e:38:5d, manufacturer data: 48432d30380000000000000000000000000000000000, serviceUUID: 0000fff0-0000-1000-8000-00805f9b34fb, txPower: -6
BLE RSSI: -66
Forming a connection to 88:4a:ea:8e:38:5d
1-BLE FreeHeap: 177236
 - Created client
2-BLE FreeHeap: 176508
 - Connected to server
3-BLE FreeHeap: 172360
 - Found our service
4-BLE FreeHeap: 167972
 - Found our characteristic
5-BLE FreeHeap: 166544
We are now connected to the BLE Server.
Setting new characteristic value to "Time since boot: 10"
BLE FreeHeap: 166492
....

and here the modified BLEClient.ino code:
/**
 * A BLE client example that is rich in capabilities.
 * There is a lot new capabilities implemented.
 * author unknown
 * updated by chegewara
 */

#include "BLEDevice.h"
//#include "BLEScan.h"

// The remote service we wish to connect to.
static BLEUUID serviceUUID("0000fff0-0000-1000-8000-00805f9b34fb");
static BLEUUID serviceIn_UUID("0000ffe0-0000-1000-8000-00805f9b34fb");
// The characteristic of the remote service we are interested in.
static BLEUUID    charUUID("0000ffe1-0000-1000-8000-00805f9b34fb");

static boolean doConnect = false;
static boolean connected = false;
static boolean doScan = false;
static BLERemoteCharacteristic* pRemoteCharacteristic;
static BLEAdvertisedDevice* myDevice;
static BLEClient*  pClient;
static BLERemoteService* pRemoteService;

static void notifyCallback(
  BLERemoteCharacteristic* pBLERemoteCharacteristic,
  uint8_t* pData,
  size_t length,
  bool isNotify) {
    Serial.print("Notify callback for characteristic ");
    Serial.print(pBLERemoteCharacteristic->getUUID().toString().c_str());
    Serial.print(" of data length ");
    Serial.println(length);
    Serial.print("data: ");
    Serial.println((char*)pData);
}

class MyClientCallback : public BLEClientCallbacks {
  void onConnect(BLEClient* pclient) {
  }

  void onDisconnect(BLEClient* pclient) {
    connected = false;
    Serial.println("onDisconnect");
//    free(pClient);
//    free(pRemoteService);
//    free(pRemoteCharacteristic);
//    delete(myDevice);
//    delete pClient; //crash
  }
};

bool connectToServer() {
    Serial.print("Forming a connection to ");
    Serial.println(myDevice->getAddress().toString().c_str());

    Serial.print("1-BLE FreeHeap: ");
    Serial.println(ESP.getFreeHeap());
    //BLEClient*  pClient  = BLEDevice::createClient();
    pClient  = BLEDevice::createClient();
    Serial.println(" - Created client");

    Serial.print("2-BLE FreeHeap: ");
    Serial.println(ESP.getFreeHeap());
    pClient->setClientCallbacks(new MyClientCallback());

    // Connect to the remove BLE Server.
    pClient->connect(myDevice);  // if you pass BLEAdvertisedDevice instead of address, it will be recognized type of peer device address (public or private)
    Serial.println(" - Connected to server");

    Serial.print("3-BLE FreeHeap: ");
    Serial.println(ESP.getFreeHeap());
    // Obtain a reference to the service we are after in the remote BLE server.
    //BLERemoteService* pRemoteService = pClient->getService(serviceIn_UUID);

    pRemoteService = pClient->getService(serviceIn_UUID);
    if (pRemoteService == nullptr) {
      Serial.print("Failed to find our service UUID: ");
      Serial.println(serviceUUID.toString().c_str());
      pClient->disconnect();
      return false;
    }
    Serial.println(" - Found our service");

    Serial.print("4-BLE FreeHeap: ");
    Serial.println(ESP.getFreeHeap());
    // Obtain a reference to the characteristic in the service of the remote BLE server.
    pRemoteCharacteristic = pRemoteService->getCharacteristic(charUUID);
    if (pRemoteCharacteristic == nullptr) {
      Serial.print("Failed to find our characteristic UUID: ");
      Serial.println(charUUID.toString().c_str());
      pClient->disconnect();
      return false;
    }
    Serial.println(" - Found our characteristic");

    Serial.print("5-BLE FreeHeap: ");
    Serial.println(ESP.getFreeHeap());
//    // BIG CRASH HERE - Read the value of the characteristic.
//    if(pRemoteCharacteristic->canRead()) {
//      std::string value = pRemoteCharacteristic->readValue();
//      Serial.print("The characteristic value was: ");
//      Serial.println(value.c_str());
//    }
//    if(pRemoteCharacteristic->canNotify())
//      pRemoteCharacteristic->registerForNotify(notifyCallback);

    connected = true;
    return true;
}
/**
 * Scan for BLE servers and find the first one that advertises the service we are looking for.
 */
class MyAdvertisedDeviceCallbacks: public BLEAdvertisedDeviceCallbacks {
 /**
   * Called for each advertising BLE server.
   */
  void onResult(BLEAdvertisedDevice advertisedDevice) {
    Serial.print("BLE Advertised Device found: ");
    Serial.println(advertisedDevice.toString().c_str());
    Serial.print("BLE RSSI: ");
    Serial.println(advertisedDevice.getRSSI() );

    // We have found a device, let us now see if it contains the service we are looking for.
    if (advertisedDevice.haveServiceUUID() && advertisedDevice.isAdvertisingService(serviceUUID)) {

      BLEDevice::getScan()->stop();
      myDevice = new BLEAdvertisedDevice(advertisedDevice);
      doConnect = true;
      doScan = true;

    } // Found our server
  } // onResult
}; // MyAdvertisedDeviceCallbacks

void setup() {
  Serial.begin(115200);
  Serial.print("BLE FreeHeap: ");
  Serial.println(ESP.getFreeHeap());
  Serial.println("Starting Arduino BLE Client application...");
  BLEDevice::init("");

  // Retrieve a Scanner and set the callback we want to use to be informed when we
  // have detected a new device.  Specify that we want active scanning and start the
  // scan to run for 5 seconds.
  BLEScan* pBLEScan = BLEDevice::getScan();
  pBLEScan->setAdvertisedDeviceCallbacks(new MyAdvertisedDeviceCallbacks());
  pBLEScan->setInterval(1349);
  pBLEScan->setWindow(449);
  pBLEScan->setActiveScan(true);
  pBLEScan->start(5, false);
} // End of setup.

// This is the Arduino main loop function.
void loop() {

  // If the flag "doConnect" is true then we have scanned for and found the desired
  // BLE Server with which we wish to connect.  Now we connect to it.  Once we are
  // connected we set the connected flag to be true.
  if (doConnect == true) {
    if (connectToServer()) {
      Serial.println("We are now connected to the BLE Server.");
    } else {
      Serial.println("We have failed to connect to the server; there is nothin more we will do.");
    }
    doConnect = false;
  }

  // If we are connected to a peer BLE Server, update the characteristic each time we are reached
  // with the current time since boot.
  if (connected) {
    String newValue = "Time since boot: " + String(millis()/1000);
    Serial.println("Setting new characteristic value to \"" + newValue + "\"");
    Serial.print("BLE FreeHeap: ");
    Serial.println(ESP.getFreeHeap());

    // Set the characteristic's value to be the array of bytes that is actually a string.
    //pRemoteCharacteristic->writeValue(newValue.c_str(), newValue.length());
    pRemoteCharacteristic->writeValue("LedOn", 5);
    delay(1000);
    pRemoteCharacteristic->writeValue("LedOn", 5);
    delay(2000);
    pRemoteCharacteristic->writeValue("LedOff", 6);
    delay(2000);
    pClient->disconnect();
    doConnect = false;

  }else if(doScan){
    BLEDevice::getScan()->start(0);  // this is just example to start scan after disconnect, most likely there is better way to do it in arduino
  }

  delay(1000); // Delay a second between loops.
} // End of loop

Any chance this will find it's way into the arduino version any time soon? I am having memory leak issues as well.

All changes has been already merged.

But not into the arduino-esp32 core, right? E.g. https://github.com/espressif/arduino-esp32/blob/master/libraries/BLE/src/BLEClient.cpp is still "broken"

Yes, in arduino too.
What is still broken?

delete on the client fails because of "CORRUPT HEAP", the onDisconnect callback is called before the disconnect is processed properly and the destructor doesn't seem to cleanup as thoroughly as the one in your implementation (e.g. no delete of the callbacks)

The corrupt heap seems to occur because BLERemoteService::removeCharacteristics is still deleting the characteristics twice, something you also have fixed in your files.

Well, yes, it is possible.
BTW, there is no need to delete callbacks, its just a pointer(address) to function

Hey guys,

I hope I'm not hijacking this thread but I think I have a similar issue and I'm hoping you can help.

I'm seeing an intermittent crash at this point of the onDisconnect():

    if (isScanContinue) {         BLEDevice::getScan()->erase(pclient->getPeerAddress());       }

I can usually go through 4/5 cycles of connecting but then it crashes. This is the output on the serial monitor:

``
BLE Advertised Device found: Name: BlueTooth Printer, Address: 66:12:0d:a9:03:34, serviceUUID: 000018f0-0000-1000-8000-00805f9b34fb, txPower: 4
BLE RSSI: -86
In Settings Menu
connectBLE...
Forming a connection to 66:12:0d:a9:03:34
1 BLE FreeHeap: 121508
Created client
2 BLE FreeHeap: 120780
pClient->setClientCallbacks(new MyClientCallback(), true);
onConnect:  - Connected to server
3 BLE FreeHeap: 115860
Found our service
4 BLE FreeHeap: 112984
Found our characteristic
5 BLE FreeHeap: 111904
The characteristic value was:
We are now connected to the BLE Server.
Setting new characteristic value to "Time since boot: 18"
BLE FreeHeap: 110564
onDisconnect: 1
66:12:0d:a9:03:34
1
device and client deleted
Client deleted
Initialising scan...
BLE Advertised Device found: Name: , Address: 1a:8d:4c:69:6b:b0, manufacturer data:<PHONE_NUMBER>02b8ced8efa5940c756358b9cbd4a9bdea708a53da804aca
BLE RSSI: -78
BLE Advertised Device found: Name: , Address: 66:12:0d:a9:03:34, serviceUUID: 000018f0-0000-1000-8000-00805f9b34fb, txPower: 4
BLE RSSI: -80
connectBLE...
1
0
Forming a connection to 66:12:0d:a9:03:34
1 BLE FreeHeap: 121216
Created client
2 BLE FreeHeap: 120488
pClient->setClientCallbacks(new MyClientCallback(), true);
onConnect:  - Connected to server
3 BLE FreeHeap: 115564
Found our service
4 BLE FreeHeap: 112696
Found our characteristic
5 BLE FreeHeap: 111612
The characteristic value was:
We are now connected to the BLE Server.
Setting new characteristic value to "Time since boot: 28"
BLE FreeHeap: 110276
onDisconnect: 2
66:12:0d:a9:03:34
1
device and client deleted
Client deleted
Initialising scan...
BLE Advertised Device found: Name: , Address: 66:12:0d:a9:03:34, serviceUUID: 000018f0-0000-1000-8000-00805f9b34fb, txPower: 4
BLE RSSI: -78
In Settings Menu
connectBLE...
1
0
Forming a connection to 66:12:0d:a9:03:34
1 BLE FreeHeap: 121512
Created client
2 BLE FreeHeap: 120784
pClient->setClientCallbacks(new MyClientCallback(), true);
onDisconnect: 3
66:12:0d:a9:03:34
0
Client deleted
We have failed to connect to the server;
We should reconnect!
Forming a connection to 66:12:0d:a9:03:34
1 BLE FreeHeap: 121832
Created client
2 BLE FreeHeap: 121108
pClient->setClientCallbacks(new MyClientCallback(), true);
onConnect:  - Connected to server
3 BLE FreeHeap: 116172
Found our service
4 BLE FreeHeap: 113312
Found our characteristic
5 BLE FreeHeap: 112228
The characteristic value was:
We are now connected to the BLE Server.
Setting new characteristic value to "Time since boot: 35"
BLE FreeHeap: 110884
onDisconnect: 4
Guru Meditation Error: Core  0 panic'ed (LoadProhibited). Exception was unhandled.
Core 0 register dump:
PC      : 0x401857d7  PS      : 0x00060830  A0      : 0x800e99b8  A1      : 0x3ffdd5c0
A2      : 0x0000007c  A3      : 0x00000000  A4      : 0x3ffdd624  A5      : 0x3ffdd554
A6      : 0x3ffdd518  A7      : 0x3f418450  A8      : 0x80182134  A9      : 0x3ffdd5a0
A10     : 0x3ffef2d4  A11     : 0x4008b9e4  A12     : 0x00000004  A13     : 0x00000011
A14     : 0x00000011  A15     : 0xff000000  SAR     : 0x00000018  EXCCAUSE: 0x0000001c
EXCVADDR: 0x0000007c  LBEG    : 0x4000c2e0  LEND    : 0x4000c2f6  LCOUNT  : 0x00000000
``

Backtrace:

Backtrace: 0x401857d7:0x3ffdd5c0 0x400e99b5:0x3ffdd5e0 0x400e9d50:0x3ffdd600 0x400d2216:0x3ffdd660 0x400e7a21:0x3ffdd6b0 0x400e855d:0x3ffdd760 0x40100c36:0x3ffdd7b0 0x400fc7e6:0x3ffdd800 0x4008e295:0x3ffdd830
Backtrace: 0x401857d7:0x3ffdd5c0 0x400e99b5:0x3ffdd5e0 0x400e9d50:0x3ffdd600 0x400d2216:0x3ffdd660 0x400e7a21:0x3ffdd6b0 0x400e855d:0x3ffdd760 0x40100c36:0x3ffdd7b0 0x400fc7e6:0x3ffdd800 0x4008e295:0x3ffdd830
0x401857d7: std::__cxx11::basic_string  , std::allocator  >::_M_dispose() at /builds/idf/crosstool-NG/.build/xtensa-esp32-elf/build/build-cc-gcc-final/xtensa-esp32-elf/libstdc++-v3/include/bits/basic_string.h line 135
0x400e99b5: BLEAdvertisedDevice::~BLEAdvertisedDevice() at c:\users\alank\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-80-g6c4433a-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits/basic_string.h line 544
0x400e9d50: BLEScan::erase(BLEAddress) at C:\Users\alank\Documents\Arduino\libraries\BLE\src\BLEScan.cpp line 276
0x400d2216: MyClientCallback::onDisconnect(BLEClient*) at C:\WINDOWS\TEMP\arduino_build_209878\sketch/BLE_Client.h line 53
0x400e7a21: BLEClient::gattClientEventHandler(esp_gattc_cb_event_t, unsigned char, esp_ble_gattc_cb_param_t*) at C:\Users\alank\Documents\Arduino\libraries\BLE\src\BLEClient.cpp line 191
0x400e855d: BLEDevice::gattClientEventHandler(esp_gattc_cb_event_t, unsigned char, esp_ble_gattc_cb_param_t*) at C:\Users\alank\Documents\Arduino\libraries\BLE\src\BLEDevice.cpp line 173
0x40100c36: btc_gattc_cb_handler at /Users/ficeto/Desktop/ESP32/ESP32/esp-idf-public/components/bt/bluedroid/btc/profile/std/gatt/btc_gattc.c line 31
0x400fc7e6: btc_task at /Users/ficeto/Desktop/ESP32/ESP32/esp-idf-public/components/bt/bluedroid/btc/core/btc_task.c line 110
0x4008e295: vPortTaskWrapper at /Users/ficeto/Desktop/ESP32/ESP32/esp-idf-public/components/freertos/port.c line 143

Hi,
This is not the same issue. I think this may be the problem, because IIRC client is deleted by stack after disconnecting:
BLEDevice::getScan()->erase(pclient->getPeerAddress());
Its strange it does not crash on every call thou.
When you try to get address from deleted object it should crash, but sometimes it may works because memory is still not rewritten.
Maybe try to call it in onDisconnect, when pclient still has not been deleted.

This is how I'm calling the onDisconnect function and I think its being called before the delete.:
void onDisconnect(BLEClient* pclient) {
Serial.print("onDisconnect: "); Serial.println(++count);
if (isScanContinue) {
Serial.print("Trying to erase address "); Serial.println(pclient->getPeerAddress().toString().c_str());
BLEDevice::getScan()->erase(pclient->getPeerAddress());
Serial.println("Erased!");
}
connected = false;
Serial.println(myDevicePresent);
if (myDevicePresent == true) {
delete myDevice; //deallocating a memory cell using delete
//myDevice = NULL;
Serial.println("----device and client deleted----");
myDevicePresent = false;
}
delete pclient; //crash
//myDevice = NULL;
delay(100);
Serial.println("----Client deleted----");
connected = false;
doConnect = true;
}
If I look at the verbose debugging log I can see that in void BLEScan::erase(BLEAddress address) the crash occurs on the
delete(advertisedDevice);
Could timing be causing an issue? I have implemented code you guys have shared above in a bigger project. If I run just the core BLEClient connect/disconnect functionaloty which is similar to your shared code I can cycle it hundreds of times.

Hi @chegewara ,
I have a problem in BLE Client example, that every time I do pClient->disconnect(); command to disconnect the client when I connect my heap memory getting smaller. after several cycles, heap memory is getting to low and esp get restart. is there any proper way to disconnect server form ble client? .


Unable to understand random threat generation

My team is working on creating some complicated threat models.  We are finding some strange issues with Threat Analysis.  Here is just one scenario:

Build out a rather complicated model.
Around 50 threats are detected
Select all and cut
Paste right back to same diagram
We now have 110 threats
Now paste the same clipboard contents into a new empty template
We now have 175 threats

The problem here is that we put a lot of effort into creating the diagram and marking up all of the threats that were found.  Then after some editing, we suddenly have a bunch of new ones (even if we didn't change the diagram).
We thought it might be Enable/Disable Threat Generation, but we have verified that we are not touching that when this happens. Is there some other process that toggles this setting?
Thanks,
~john

@jthoni-MSFT Thanks for reaching out!! Can you please share the documentation link that you are following so that I will be able to assign the issue to respective team?

@jthoni-MSFT  Just checking if you had chance to check my previous comment.

Not sure what you are looking for, but we are following the internal https://microsoft.sharepoint.com/teams/M365Security/SitePages/Threat-Modeling.aspx

This azure-docs repository deals about feedback related to particular Azure document page (like correcting doc bugs, doc enhancements, product issues related to wrong doc instructions, etc).
Please reach out to internal teams for internal sites. As there are no further documentation changes,
we will close the issue for now.


STORM-2326 Upgrade log4j and slf4j for branch 2.x

See #1946 for 1.0.x equivalent
 mvn clean install -DskipTests=true ran without problems

+1


strong mode issues with this package

Viewable here: http://dart-atom.github.io/dartlang/entry_dart_results.html#package_vm_service_lib.

(@vsmenon fyi)


Fixing -PerMinute abbreviations

Replaced */m by */min for units :

NewtonPerMinute
DegreeCelsiusPerMinute

Ah, thanks!

Nuget 3.72 is out.


Field: Field.data.clear() unlink the dataset in hdf5 file, but does not unlink the dataset in FieldArray #92

Closing #92, reset the dataset when field.data.clear() called;
Add unit test for field.data.write and field.data.clear;
Create the dataframe file for exetera data represenatation.

Looks good to me. All understood


Automate Pyrsia node release procedure

not for 0.2 but for future releases
placeholder issue for release automation, let's try to record all steps we did manually for 0.2
I'm keeping an up-to-date list to tasks here because comments don't make it easy to see all at once:

BEFORE TAGGING: make sure to update the version in the Cargo.toml before tagging the release
BEFORE TAGGING: run integration tests and manualy sanity checks (see #1339)
make sure rust toolchain version is set to what we want
upload windows MSI to github release
update documentation to include latest released version
make sure apt repo and brew repo contain the correct latest release
make sure the authorized nodes are updated
run installer tests connecting to nightly
run installer tests connecting to production

post-release, in main branch:

commit new version
if new rust version is available, upgrade to latest stable

upload windows MSI to github release
update documentation to include latest released version
make sure apt repo and brew repo contain the correct latest release
make sure the authorized nodes are updated

Subtask
First document the test plan as described in #1339

make sure to update the version in the Cargo.toml before tagging the release

The release procedure is now tracked in https://github.com/pyrsia/pyrsia/blob/main/docs/developers/release_process.md (more improvements in #1431)
Quick wins to improve this process are:

Upload windows MSI to the GH release from within the action
Use a variable for the version in rust.yml so it can be changed more easily
Create a script to update and commit the new version number


Add open liberty under thirdparty container tests

Evaluate and include open liberty tests under third party container tests
https://github.com/OpenLiberty/open-liberty
https://github.com/AdoptOpenJDK/openjdk-tests/issues/172

Installed ant version  1.10.3 and the ran the below FAT test, it worked fine now. Need to figure out how to run all FAT tests
./gradlew build.example_fat:buildandrun
generateReports:
[startAnt] Buildfile: /home/chandrams/AdoptOpenJDK/git/open-liberty/dev/build.example_fat/build/libs/autoFVT/src/ant/launch.xml
[startAnt]
[startAnt] reallyGenerateReports:
[startAnt]      [echo] Generating an HTML report based on the existing XML report
[startAnt]     [mkdir] Created dir: /home/chandrams/AdoptOpenJDK/git/open-liberty/dev/build.example_fat/build/libs/autoFVT/results/junit.html
[startAnt] [junitreport] Processing /home/chandrams/AdoptOpenJDK/git/open-liberty/dev/build.example_fat/build/libs/autoFVT/results/junit/TESTS-TestSuites.xml to /tmp/null128732985
[startAnt] [junitreport] Loading stylesheet jar:file:/home/chandrams/apache-ant-1.10.3/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[startAnt] [junitreport] Transform time: 574ms
[startAnt] [junitreport] Deleting: /tmp/null128732985
[startAnt]      [echo] HTML report is available at /home/chandrams/AdoptOpenJDK/git/open-liberty/dev/build.example_fat/build/libs/autoFVT/results/junit.html/index.html
[startAnt]
[startAnt] BUILD SUCCESSFUL
[startAnt] Total time: 1 second
archiveReports:
execute:
BUILD SUCCESSFUL
Total time: 13 seconds
BUILD SUCCESSFUL in 24s
63 actionable tasks: 33 executed, 30 up-to-date

Got a list of FAT testsuites using ls command, there were 75 tests out of which 42 tests passed and rest failed.  The tests take a long time to run around 20 hrs or so.
Checked with Andrew Guibert from the WAS team, he suggested that we could just run only the unit tests as the WAS org has extensive infra to run all 90k+ FAT tests for OpenLiberty and WAS Liberty on hundreds of combinations of OSes and JDKs on a weekly basis, and they would report issues on Openj9 if any.

Found few intermittent issues while initializing and building the liberty test material. Fetching some of the artifacts fail:
./gradlew cnf:initialize
error  : dev :Exception: java.io.IOException: Could not fetch com.ibm.ws.org.eclipse.equinox:coordinator:1.3.200.v20160325-1323
at aQute.maven.provider.MavenRepository.getFile(MavenRepository.java:173)
at aQute.maven.provider.MavenRepository.lambda$get$0(MavenRepository.java:130)
at aQute.maven.provider.MavenRepository$$Lambda$60.000000006D079580.call(Unknown Source)
at org.osgi.util.promise.DeferredPromiseImpl$Submit.run(DeferredPromiseImpl.java:658)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:812)error  : dev :Failed to sync com.ibm.ws.org.eclipse.equinox:coordinator:1.3.200.v20160325-1323

./gradlew assemble :com.ibm.websphere.appserver.features:releaseNeeded
Fails with the above issue and the artifacts it tries to sync aren't same, I see the same issue with the below as well:
error  : dev :Failed to sync net.sf.jtidy:jtidy:9.3.8
error  : dev :Failed to sync com.ibm.ws.org.eclipse.equinox:region:1.3.2.v20170118-1930

When the initialization and build is successful, unit tests failed with the below issue:
./gradlew test
com.ibm.ws.logging.internal.hpel.HpelLogProviderImplTest > testWritingMessages FAILED
    org.junit.ComparisonFailure at HpelLogProviderImplTest.java:112

com.ibm.ws.logging.internal.hpel.HpelBaseTraceServiceTest > testWritingMessages FAILED
    org.junit.ComparisonFailure at HpelBaseTraceServiceTest.java:143

19 tests completed, 2 failed, 1 skipped
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':com.ibm.ws.logging.hpel:test'.
> There were failing tests. See the report at: file:///home/muchandr/git/open-liberty/dev/com.ibm.ws.logging.hpel/build/libs/reports/tests/test/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 6m 33s
1037 actionable tasks: 211 executed, 826 up-to-date

Exception details from the logs:

testWritingMessages

org.junit.ComparisonFailure: Record has incorrect formatted message expected:<[debug message]> but was:<[TRAS3004E: Failed to write messages to the <user home>/git/open-liberty/dev/com.ibm.ws.logging.hpel/../com.ibm.ws.logging.hpel/build/unittest-logs/messages.log file.]>
        at org.junit.Assert.assertEquals(Assert.java:125)
        at com.ibm.ws.logging.internal.hpel.HpelBaseTraceServiceTest.testWritingMessages(HpelBaseTraceServiceTest.java:143)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:90)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55)
        at java.lang.reflect.Method.invoke(Method.java:508)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
        at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
        at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
        at test.common.SharedOutputManager$1.evaluate(SharedOutputManager.java:614)
        at org.junit.rules.RunRules.evaluate(RunRules.java:18)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:300)

Will submit multiple runs to check if they are intermittent or machine specific.

Link to the run - https://ci.adoptopenjdk.net/view/work in progress/job/test_personal/581/console

Close it in favor of #552


adding usmp

Im adding here my university USMP from Perú

@PieroDev23 I am sorry, the domain usmp.pe is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Journal and institution application validation

Application forms for both journals and institutions need proper validation. None exists currently.
Related URLs:

[ ] http://ojs.dev/apply/journal
[x] http://ojs.dev/apply/institution

c6080d34e1699c54f530675e5c40b44af87e855b

https://github.com/okulbilisim/ojs/commit/7c83cdd


Massive amount of JEI errors

You know a couple of errors are fine but at multiple thousand lines, it becomes a problem.
Example log: https://gist.githubusercontent.com/Nyanmaster/8f8d67d098ef603b5a7073c8bbd7cbb8/raw/fda586f1b5878a619d766425db753ccd3ac072b8/Latest.log

What version are you using? I think this is already fixed in 1.15.2-<IP_ADDRESS>

The one time I forget to double check for updates...
Yep already fixed. Ty.


Do not let user hook utternaces comment on their blog to Elegant repo

See this issue https://github.com/Pelican-Elegant/elegant/issues/602
This user setup the blog and set the comment repository to Elegant. We ended up receiving his comments.
This means anyone can point his utterances script to Elegant for comments. This should not happen.
I am not sure how to fix this.

Hi,
This was a misconfiguration on my side,  I apologize for the trouble.  Some kind of an authentication token from the utterance side can prevent such a mishap. Passing a plain text repo URL is a bad idea.

Thank you @ashwinschronicles

To prevent unauthorized comments in your repo, add an utterances.json file to the master branch with the list of origins permitted to post in this repo.
utterances.json
{
  "origins": ["https://elegant.oncrashreboot.com"]
}

Thank you so much @jdanyow

:tada: This issue has been resolved in version 5.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add Ceph FS volume plugin

@vishh @thockin
this is functionally ready. I understand Endpoints is still under discussion.

Thanks for all the awesome work @rootfs. Just a few nits. I would really like to have end to end tests for these plugins. I opened a separate issue to discuss that.

ok to test

I'm concerned that the 'secrets' issues in here are just not resolved - this needs to resolved ASAP or miss 1.0

I thought I've missed the train. I'll shape it up soon.

@vishh @thockin @smarterclayton @markturansky @pmorie
ready for your comments. Thanks

@smarterclayton

@smarterclayton review feedback addressed, rebased to latest.

+1

+1

I don't have any other comments but this is now on v1.0-post.

Yeah, this missed the train, sorry. I could not make time for it last week,
and a few of us (myself included) are out this week.
On Jun 8, 2015 7:09 AM, "Clayton Coleman"<EMAIL_ADDRESS>wrote:

I don't have any other comments but this is now on v1.0-post.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/6649#issuecomment-110007539
.

@rootfs can you create this as an UPSTREAM pull against OpenShift and we can carry until after 1.0?
----- Original Message -----

Yeah, this missed the train, sorry. I could not make time for it last week,
and a few of us (myself included) are out this week.
On Jun 8, 2015 7:09 AM, "Clayton Coleman"<EMAIL_ADDRESS>wrote:

I don't have any other comments but this is now on v1.0-post.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/6649#issuecomment-110007539
.

Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/pull/6649#issuecomment-110008896

@smarterclayton good idea

@saad-ali would you please build/push this new image like you did for @jsafrane in #7435?

@rootfs needs a rebase.  Also, we need to make sure this PR stays in sync with the patch into OpenShift.

Needs rebase and to be brought up to current conventions wrt Builder/Cleaner

@thockin rebased, refactored, and  squashed. thanks!

@rootfs needs another rebase.  Looks like sed 's|github.com/GoogleCloudPlatform/kubernetes|k8s.io/kubernetes|g' is a large part of it.

@deads2k thanks, on the way

@rootfs do SecretFile and SecretRef interact with each other at all?

@rootfs Disregard above Q.  I think the comments in types.go files and in v1 description tags should specify that SecretRef will override SecretFile if set.

@pmorie updated, thanks

@saad-ali
On Mon, Aug 17, 2015 at 10:42 AM, Kubernetes Bot<EMAIL_ADDRESS>wrote:

GCE e2e build/test passed for commit 184bd94
https://github.com/kubernetes/kubernetes/commit/184bd94ec11cd02b2b074f0c66ccd85aabee0ab3
.

Build Log
https://storage.cloud.google.com/kubernetes-jenkins/pr-logs/184bd94ec11cd02b2b074f0c66ccd85aabee0ab3/kubernetes-pull-build-test-e2e-gce/5322/build-log.txt
Test Artifacts
https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/184bd94ec11cd02b2b074f0c66ccd85aabee0ab3/kubernetes-pull-build-test-e2e-gce/5322/_artifacts/
Internal Jenkins Results
http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//5322

—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/kubernetes/pull/6649#issuecomment-131904102
.

@rootfs Can you please rebase this. I'll take a look at it.

Yes, rebase please. We'd love to get this merged and shipped into k8s ASAP.

Thanks @rootfs
LGTM mod nits

@saad-ali thanks, just updated.

Thanks @rootfs One last file and then please squash your commits.

@saad-ali squashed, wait for green :)

Thanks @rootfs
LGTM
@pmorie @markturansky if you're good, let's get this merged.

@saad-ali I took a look today. I think we're good to go.  We can support it from here.
LGTM.

@rootfs Not worth blocking this PR, but in #12599 Brian commented on your example (fiber channel) and said that YAML is preferred.  Perhaps a follow-up PR to change these examples to YAML?

@markturansky there are other json to yaml conversion in examples, let's get them in next PR(s)

SGTM

Adding LGTM label

@rootfs needs rebase (sorry!)

@brendandburns done, thanks!

Merging since the github api flaked and this was skipped.


Add RISC-V Vector support.

Hello,
This adds support for the RISC-V architecture by using the RISC-V Vector Intrinsics [1]. I've added support for CI similarly to ARM SVE.
Thank you for your review!
[1] https://github.com/riscv-non-isa/rvv-intrinsic-doc

Thanks a lot for your PR, this is huge! I'll take the time to review it in detail over the weekend.

Wow. Thanks a lot for that. 🙇

There is a test failure I can't reproduce locally. One of the difference is the QEMU version so I'll debug that out next week.


Types not highlighted correctly after splitting into multiple lines

In the above example, the part Show details is highlighted in Blue, as if it was a primitive, but not in the second case.

One more case is this:

Both Show and Validate are type classes, so should be in the same color scheme. And the where keyword isn't highlighted.


feat(payment_methods): Added value Field in required Field for Pre-filling

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

Refactored Required Fields for PM List API. It is now a HashMap instead of a vector.
Have added backend logic to segregate required fields into mandate/non-mandate fields and unify them later on.
Also, refactored the Required Fields to include the value field which could be used for pre-filling.
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed submitted code
[ ] I added unit tests for my changes where possible
[ ] I added a CHANGELOG entry if applicable

Please run this command cargo run --features openapi -- generate-openapi-spec to re-generate the openapi spec and commit


Change in bridge/setup_ip_tables.go

With the transition to ipam, bridge ip address stored
in bridgeInterface is guaranteed to be the ip of the
OS bridge by the setupBridgeIPv4 step function.
Therefore the setupIPTables() step function no
longer needs to fetch the address from the OS.

This removes unnecessary syscalls to the OS
and removes the code which may cause confusion.
Signed-off-by: Alessandro Boch<EMAIL_ADDRESS>

Other maintainers believe that given a main re-work of the iptables management is needed (a common API layer, atomic implementation relying on iptables restore) and may come in future, the chain rework proposed in this PR is not providing enough benefit at this time.

LGTM

LGTM


Please invite me to the GitHub Community Organization

Name
johnhoward
Discord Username (if applicable)
No response
Additional Context
Thanks

You are already part of the GitHub organization


Fix Selected Enum Serialization

Fixed serialization of various enums to match documentation.  This resolves issues with specifying label format and download type in CreateLabelFromRate. Fixes #47

#47 is the issue this resolves.

Hi @brprigge, thank you for submitting this fix. I will begin verifying this change on my end shortly and will get back to you.

I thought through that, but opted for a bit more granularity as I wasn't sure if all enums needed to be string converted.

It’s good to be on the safe side here by keeping the changes surgical for
now. I’ve bounced the idea around internally of having all enums serialized
in their string representation, and it’s something we’d have to do more
thorough testing around to be safe, but I imagine that the SDK/client
should be passing enums by their string representation to the API anyways,
as having a reliance on non-canonical, internal numerical values doesn’t
sound reliable (such as if the order of an enum’s values change for
whatever reason, either in the SDK or in the API).
On Wed, Mar 2, 2022 at 4:42 PM Brian Prigge @.***>
wrote:

I thought through that, but opted for a bit more granularity as I wasn't
sure if all enums needed to be string converted.
—
Reply to this email directly, view it on GitHub
https://github.com/ShipEngine/shipengine-dotnet/pull/46#issuecomment-1057467515,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGFIAW2CSQLV7DG2PMKEXY3U57VGZANCNFSM5PSHPOTQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>


City passes in OSDM

Are additional city passes for cities like Zurich and Geneva (SBB) an ancillary or an admission pass?

They are admissions. According to the definition (https://osdm.io/spec/models/) admissions represent a travel right whereas ancillaries don't.

@CGantert345 @schlpbch I am looking into swagger, and we can express desired regional validity in request OfferSeachCriteria, admissionOfferPart contains textual summary but no structured regional validity data, and admission in bookerOffer doesn't contain anything to recognize the regional validity expect maybe textual label in summary or from the product. Is that correct?


Decreasing peak memory usage for beam.TupleCombineFn

Loading and merging accumulators in batches in beam.TupleCombineFn.merge_accumulators instead of loading and merging all at once.
This is a modification of https://github.com/apache/beam/pull/15271/commits/292dc445b654ab50ebe0a156b71fb69946bdc481 with a fix of failing internal tests. The original change was reverted in https://github.com/apache/beam/commit/8c6ade23a95807851e4b3f5ad29217c692a704b4.

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @robertwb

It doesn't look like there's an easy way to compare the old and new versions, but fde2fd763a4bf7e01810821c8c13e754cec32dad does the job

Run Python PreCommit


[BUG] Put more margin in supported format page

Bug Description
Put more margin in supported format page
Bug Reproduction

Bug Impact
No response
Bug Screenshots
No response
Bug References
No response
Bug System Information

OS: [e.g. Windows 10]
Browser: [e.g. Google Chrome, Firefox]

┆Issue is synchronized with this Wrike task by Unito

One more thing, put more space between extensions.
Maybe you can use bulma tag for extension (https://bulma.io/documentation/elements/tag/)

@Thuhaa
You still need to put more margin. It is too narrow space between the edge of header and the title

Closig as it has been solved by #2078