[$500] Details - In details page, instead of mail id, "hidden" is shown for newly created account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch app
Create one new account
Again login into any existing account
Tap fab
Tap send message
Enter and select newly created account as first user and any other contact as second user
Tap create group
Tap header
Note the details of above newly created account in details page

Expected Result:
In details page, "hidden" must not be shown and mail id of newly created account must be shown
Actual Result:
In details page, instead of mail id, "hidden" is shown for newly created account
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] Windows / Chrome
[x] MacOS / Desktop

Version Number: 1.3.74-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/76f4a033-51da-4e00-a252-adb53790a974
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014637fdc103f5f54c
Upwork Job ID:<PHONE_NUMBER>502255104
Last Price Increase: 2023-09-28

Proposal
Please re-state the problem that we are trying to solve in this issue.
The alternate text in the participant list shows as hidden for newly created users.
What is the root cause of that problem?
The text hidden shows up when the user has no login is set yet.
What changes do you think we should make in order to solve the problem?
We can use the displayName value as an alternative text while waiting for the login property to be set, if the display name does not exist we can then fallback to the hidden text.
https://github.com/Expensify/App/blob/cfad43ff96f2a104c51fd475e07f0980c4379fcd/src/pages/ReportParticipantsPage.js#L70C1-L70C1
We can update it to
const userLogin = LocalePhoneNumber.formatPhoneNumber(userPersonalDetail.login || '') || userPersonalDetail.displayName || translate('common.hidden');

What alternative solutions did you explore? (Optional)
N/A

adding external label to review existing proposal

[Please re-state the problem that we are trying to solve in this issue.]
When starting a new group and adding new participants with email address. The participants email address does not appear below the display name, instead hidden is being shown.
[What is the root cause of that problem?]

As it seems, the login id does not appear because the object "userPersonalDetail" does not have the property "login" in it. This is because when the API is called with command "OpenReport" it responds with an altered object which does not include "login" property along with some other properties.
[What changes do you think we should make in order to solve the problem?]
I believe if we can check into the API response and try to respond with same data object, it will solve the issue.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~010ccc708154c23a1c

@robertKozik - bump on proposal review - ty!

hi all @abdel-h66 @saad995 ! I'm having difficulties with reproducing this bug. Could you confirm me if it still exists? As we need the new account for this, do I need to log into this new account beforehand?

Hi @robertKozik, yes you need to log in and then start a group chat with unknown email ids.
I was trying to upload a video here for you but there are some file size limitations.
Let me know if you there's anything else you need

Guys any update on this?

Ok got it! thanks @saad995 . I'll review the proposals then :D

Thank you, @saad995 and @abdel-h66, for your valuable input on this issue. Based on our findings, it appears that this will require some insight or a fix from the internal backend side, as the root cause seems to be the absence of the login property.
@maddylewis, could you please add the internal tag, as we suspect that the root cause lies on the backend side?

@maddylewis bump

sorry for the delay, @robertKozik. i added the internal label. let me know if there's anything else i can do on this issue rn.
@saad995 - we will process payment for the overall analysis you did on this one. it will be less than the standard bounty. i will confirm the payment amount and send you an offer once we've confirmed a fix for this one.

@robertKozik - would love some direction on the best next steps for this issue - ty!
https://github.com/Expensify/App/issues/28202#issuecomment-1762049252

Sorry for the delay here. I believe we need the insight from the internal engineer - the login property is missing as stated in the @saad995 analysis and (if it's not intentional) we can fix this on the backend

it looks like an engineer didn't get assigned to this one last week. @deetergp - when you have a chance, can you take a look a this comment? ty! https://github.com/Expensify/App/issues/28202#issuecomment-1774955740

Apologies gang, I've been very heads down on a time-sensitive project. To confirm @saad995, you're saying the OpenReport command does not return the expected data?

Hi @deetergp,
Yes, it seems OpenReport command responds with inconsistent object structure as mentioned in the screenshots provided above.

Was OOO for a couple days, will try to investigate this one further tomorrow AM.

Hi guys, is there any update on this?

I finally had a chance to dig deeper into this one and from what I can see in the API code, this is very much on purpose and we would have to undo lot of very intentional looking code in order to surface this by default. As each member joins the chat, their details become visible to the rest of the group.
@puneetlath I see your name in the git blame for a lot of this, any thoughts on which is is?

Yes, this is on purpose and not a bug. If you don't "know" someone, then we don't share their login info with you and show "hidden" instead. Closing!

Such a waste of time.....this is the third bug on which I have faced this....please do not post on upwork, i need to report it.


Check if I can texture maya lights.

There is a bug crashing corona render, will be fixed in next release.


Detect when pthread_mutex_t is moved

What I am not sure about this PR is how to support storing the additional mutex data like its address and kind. If I understand correctly the concurrency::sync::Mutex struct is to be used by any mutex implementation. This possibly means that different implementation might want to store different data in the mutex. So any additional data should be implementation defined somehow. Solutions that come to mind:

Store the additional data as Box<dyn Any> and the implementations can downcast their data when they fetch them.
Have each shim implementation define a static mut map between MutexIDs and the additional data.

Let me know
(For why this change is needed see: #3749)

@rustbot ready

Hi!
Just wanted to quickly check if this fell through the cracks. (But no pressure if you are busy!). Thanks!

It's in my list. :) Sorry for the slow reply. Too many things that need to be done...

:umbrella: The latest upstream changes (presumably #3823) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot author

(please write @rustbot ready when this is ready for review again)

Yeah, I wanted to post a comment first with a few things I am not sure are correct. I realized it was late after I pushed the changes so I decided to do that today. sorry if it caused confusion. Here is what I wanted to say:
To check for the static initializers I have to ignore a "header" in the pthread_mutex_t where miri stores the MutexId. The way the code works now, initialization of the additional data happens lazily, after the compare exchange operation. So at that point the mutex id is stored, and doing a bitwise comparison with the static initializers will fail. I could call the closure before checking for initialization in get_or_create_id, but then this would happen every time a mutex is locked/unlocked which could be slow. So i decided to ignore 4 + mutex_id_offset bytes from the contents of a mutex when checking if it is equal to a static initializer.
This also solves another issue. When i was reading the full contents of the mutex, miri thought there was a race condition. I did not spend too much time debugging this. But I believe it is because when trying to lock, for example, a mutex that was initialized with a static initializer, in thread A, all the bytes of pthread_mutex_t (including the id) would be read. Then thread B would try to also lock the mutex, and call get_or_create_id. The previous unsynchronized read then clashed with the atomic read in compare_exchange. I couldn't find the proper way to fix this. I think I might need to somehow use acquire_clock but I couldn't exactly understand how it works. Since I am now ignoring the mutex id part, I think this sidesteps the issue.
Finally, instead of adding a forece_create boolean argument, I opted for defining a new function that creates the mutex eagerly. I thought that adding more logic in get_or_create_id might make it too complex. But I a have no strong feelings about this. The current way also removes the need for mutex_reset_id. Otherwise, I think we need to call it to initialize the mutex id memory, otherwise miri complains that there was a read of uninit data, I am assuming at compare_exchange.
@rustbot ready

To check for the static initializers I have to ignore a "header" in the pthread_mutex_t where miri stores the MutexId. The way the code works now, initialization of the additional data happens lazily, after the compare exchange operation. So at that point the mutex id is stored, and doing a bitwise comparison with the static initializers will fail. I could call the closure before checking for initialization in get_or_create_id, but then this would happen every time a mutex is locked/unlocked which could be slow. So i decided to ignore 4 + mutex_id_offset bytes from the contents of a mutex when checking if it is equal to a static initializer.

Ah yes, this has to be done quite carefully to avoid races.
I'd say for now just scratch this sanity check. Checking just some of the bytes is a bit too ugly IMO, after all we don't have to catch these kinds of bugs anyway. So let's just use the "zero ID" as indicator that this must be initialized and not do a separate check for now; we can explore how to add such a check separately in the future.

@rustbot ready

@rustbot ready

@rustbot ready

Thanks. :-)
@bors r+

:pushpin: Commit aba9bb2ecc2b82b3b9081fe0a0e188daf80edffe has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit aba9bb2ecc2b82b3b9081fe0a0e188daf80edffe with merge 7b422febaced2d92d92cd22a011e227846ed5d80...

I only just noticed that you even suggested this initially. :D

Store the additional data as Box<dyn Any> and the implementations can downcast their data when they fetch them.

If you want to do this in a follow-up PR, let me know. :)

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 7b422febaced2d92d92cd22a011e227846ed5d80 to master...


Authenticated Apps do not seem to be listed properly

The oauth_consumer_set property of the class Persoon does not seem to retrieve authenticated applications/ consumers as they are not properly displayed on the website. Tested authenticated applications, such as Cashflow symposium website and mobile apps, are not properly displayed.

So is there currently a method to see which applications have access to your account from the website and if not, how easy is this to fix? Eventually, we want this to be able to be accessible from the mobile app too, if possible.

This is fixed now in Inter-Actief/amelie-private#97


[BUG]-JSON EvaluateFile failed to read files on VC-4 running SIMPL

Describe the bug
Loading a SIMPL program to VC-4 server the EvaluateFile method used by the JSON Master modules would fail to read the file on a VC-4 server running a SIMPL program.
To Reproduce
Steps to reproduce the behavior:

Load a compatible SIMPL program with JSON modules to VC-4 server
JSON EvalauteFile would not read the file on the VC-4 server

hotfix branch has been created and tested on a VC-4 server running a SIMPL program.  Testing is ongoing with 4-Series and 3-Series appliances.

Completed testing on 3-series appliance, 4-series appliance, and VC-4 server.


SVG tabindex="-1" is keyboard focusable in Internet Explorer

<svg tabindex="-1"> is still keyboard focusable (tabbable) in Internet Explorer and ally/element/disabled does not work around that yet

possibly related to #7


Recurring Payments

Dear Shoppe,
Has there already been an implementation of Shoppe with Recurring Payments? We are looking to have both physical products and subscriptions in a shop for a client. Googling this issue, did not bring us any further.
Niels

Not yet but feel free to create a PR if you build it

I have started working on a shoppe-subscriptions add-on engine. It's using Stripe subscriptions and will support partial payments (hopefully!). Early days for it, but I can share if you want to collaborate?

I had the same question. I'm new to developing, but I'd be happy to help anyway I can.

@dznicol I'm happy to collaborate - would like to see this feature go live.

I have been working on it on and off. It's here: https://github.com/dznicol/shoppe-subscriptions
It uses Stripe subscriptions exclusively, and the implementation keeps the subscription settings in sync with the Stripe account, so no need to add them via the Stripe dashboard.
The Stripe webhook invoice.payment_succeeded isn't fully implemented yet. This is the point where the subscription will trigger the purchase of the associated Shoppe::Product.
In my case it takes 2 rounds of subscription before there is sufficient funds to trigger a product purchase. To cope with that there is a balance field on the new Shoppe::Subscribers model to add up the subscription payments until there is sufficient funds to trigger a purchase of the associated Shoppe::Product.
I'll keep working on it on and off and hopefully get a fully functioning system soon.

Nice work @dznicol. I've not looked at it yet but it's nice to see you're making it a plugin :+1:


feat: Exactly once delivery subscriber sample.

This draft PR demonstrates the exactly once subscriber sample using the new SubscriptionHandler . The library changes are yet not released so the code will not compile and hence tests would fail. Added the do not merge label. This is done so that the code can be reviewed and fixes can be made. Thanks.

csproj file is reverted but is still showing up. I will remove it.


refactor: use pytest fixtures to reduce repetition in tests

Description
Refactored the parameter processing test cases to use pytest fixtures and pytest.mark.parametrize to reduce code duplication and improve test maintainability.
Fixes #4502
Type of change

[x] Code refactor (test improvements to reduce repetition)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

Thanks for your suggestions, @agriyakhetarpal ! I've made the changes based on your feedback. Let me know if anything else needs tweaking

@all-contributors please add @Aswinr24 for tests


rand

@noCharger please add the original PPL command here as context

The rand function seems to work correctly search source=people | eval x=rand()


flake8 library/ceph_crush.py

Split from #5711
Signed-off-by: Wong Hoi Sing Edison<EMAIL_ADDRESS>

closing in favor of #5739


[Question] - How can I make some service providers load only after configs are full loaded?

Great work on the package. I'm trying to extend and implement some features and wanted to load some of the service providers only after the configs are full loaded.
Can you please suggest some ways to achieve it?
Forked repo: https://github.com/sujit-baniya/goravel

Adding a provider here is ok. Do you have any specific problems?

Yes I've a problem doing something like this

With some changes in API, I made it work.

Moved "providers" as separate "Providers()" function
Add "Providers" in foundation.Application and called "Providers()"function on the field
Moved "config.Boot()" above "app.Boot()"

Yes I've a problem doing something like this

Yes, you are right, at this time, facades.Config has not been initialized. You need to use config.Env in config/*.go file. Happy to know that you had resolved this problem. 👍


single precision for obs

closes #16 for observations
yields factor 2 improvement for free

Already implemented now in obs


Switch to Material design.

The current UI of the extension looks outdated. The UI can be replaced by material design

which will attract more users to use this extension and
it should be user-friendly i.e. easy to use.

Any Updates @harsha444 @vaibhavsingh97 ?

I was kinda preoccupied with another work :(  If anyone else is interested
assign it to them
ᐧ
On Wed, Feb 28, 2018 at 11:11 PM, Piyush Raj<EMAIL_ADDRESS>wrote:

Any Updates @harsha444 https://github.com/harsha444 @vaibhavsingh97
https://github.com/vaibhavsingh97 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/Connect-Me/issues/2#issuecomment-369320488,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANBvLUxfoINrmoZZxUAnevJFe5sVP3r5ks5tZY_dgaJpZM4RaTTp
.

--
Mittapalli Sri Harsha
NIT Durgapur | IT
M: +91-9493083847
E<EMAIL_ADDRESS>www.sriharsha.ml
https://www.facebook.com/sriharsha.mittapalli
https://www.linkedin.com/in/harsha444 https://github.com/harsha444/

@vaibhavsingh97 Any updates ?

@0x48piraj @harshit98 If no one is currently working on this, I would like to take this one up...Should I go ahead?

Definitely, go ahead!

Hey can I work on this now? @0x48piraj

@0x48piraj is this still active?


Issue #1386: Remove Acquia example and add docs section pointing to BLT

How's that? BLT has quite a few "extras" so I thought it's still useful to mention what users should be looking for. I've never had the opportunity to test out Acquia Cloud unfortunately so I'm not entirely certain about this PR. Tell me if there's anything I should add/change.
My vote still goes for removing the example and pointing to BLT, partly because I feel examples should be available at http://docs.drupalvm.com/en/latest/.

This works for now—maybe at some point in the future, we could rename that doc to "Emulating Cloud provider environments" and expand it to include defaults suggestions for Pantheon, Platform.sh, Blackmesh, etc. (basically any hosting company that has some emphasis on Drupal).


PyLuxCoreTool unable to merge films

This is on the very latest build of 2.5a compiled and run in a windows environment on both the render server and the netconsole machine.
The scene binary comes from blender with blendluxcore 2.4. The scene binary renders fine in luxcoreui. All scenes from blender have this issue, even the default cube scene with a only matte material applied to the cube.
When the job gets sent off to the server for rendering, it runs as normal.
When it's time to merge the film from the server(s) pyluxcoretool console spits out the following error:
File C:\Users\username\appdata\local\temp_MEI34082\pyluxcoretools.zip\pyluxcoretools\renderfarm\renderfarmfilmmerger.py, line 101, in MergeAllFilms
RuntimeError: unregistered class
The line in question is: 				filmThread = pyluxcore.Film(filmThreadFileName)
It will throw this error in regards to this line no matter what python file is calling it, for instance resuming the job with .flm files ready for merge causes it to have the same issue even without any render nodes connected.
The line itself has not changed since the stable release of 2.4 in which everything runs as expected for any scene. I can provide an flm file with this issue if needed.

I should have fixed this problem.


[CodeCompleiton] Don't hide members for unresolved base types

Don't filter out members if the base type has unresolved types.
Previously, initializers used to be hidden if the type has 'where'
requirements on the generic parameters.
This patch enables initializer completion for SwiftUI.ForEach.
rdar://problem/49480808

@swift-ci Please smoke test


Specify the stack slot the frame pointer points to

Previously it was unspecified where on the stack the fp register pointed to. This change specifies the behavior, which has been the de facto standard.
Resolves #18

not exactly sure how I messed up a simple push, but I clearly need to clean this up

Ah interactive rebase deleted merge commits.

Generally it's LGTM for the structure after adding the level of conformance part, but I am not family with SCS so I might need to spend more time on that part.
I would like invite more eye to take a look on the wording, and wait at least @jrtc27, and RISC-V LLVM maintainers (@asb or @luismarques) has positive response.

LGTM from an LLVM perspective. I don't really have alternate suggestions for the wording.

@ilovepi Thanks for the effort :)


adding dedupe map to track transaction ids we've already seen

Closes #812

Thanks Ben. I added a test and am resolving this with #840


Add reference to public ECR base image repos in respective READMEs

This will also trigger the base image builds and pushes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/hold

/test eks-distro-base-tooling-presubmit

/unhold


Disable undefined eslint warning

https://github.com/babel-plugins/babel-plugin-undefined-to-void - I quite prefer writing undefined than void 0. More idiomatic to me.

Working in JS for 10 years I never had a problem with someone overriding undefined.

Me too, but still ESLint no-undefined is turned on as an error. So I'd rather add this plugin & switch the warning off. If we can have a plugin that will solve some problems for us and make developers more idiomatic, then - let's go for it.

Hmm, makes sense. Ok, send PR.

no activity


chore(deps): update dependency eslint-plugin-prettier to v3.1.4

This PR contains the following updates:

Package
Type
Update
Change

eslint-plugin-prettier
devDependencies
patch
3.1.3 -> 3.1.4

Release Notes

prettier/eslint-plugin-prettier
v3.1.4
Compare Source

Avoid clearing Prettier cache when not using prettierrc (#303) (3c8e2d9)
build(deps-dev): bump eslint-plugin-eslint-plugin from 2.2.1 to 2.2.2 (93f7c8b)
build(deps-dev): bump eslint from 7.1.0 to 7.2.0 (650ac7a)
build(deps-dev): bump eslint-plugin-self from 1.2.0 to 1.2.1 (6449ec1)
build(deps-dev): bump eslint from 7.0.0 to 7.1.0 (fd30022)
Chore: Add CI tests for ESLint 7 (#291) (cc2979b)
build(deps-dev): bump eslint-config-prettier from 6.10.1 to 6.11.0 (35a7ee6)

Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Codecov Report

Merging #58 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           22        22
  Lines          480       480
  Branches        80        80
=========================================
  Hits           480       480

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b7c40...229721e. Read the comment docs.


about kb_helper.py

141 row in kb_helper.py
image
why do you return kb_results before getting results

Just for testing purpose. You can turn on the feature by uncommenting this line.


Add struct visibility

Part of #37

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3600eef) to head (b12a185).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #67   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           58        58
  Lines         2707      2722   +15
=========================================
+ Hits          2707      2722   +15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


map_deinit crash after map_init without add any values

map_init(&m);
map_deinit(&m);  // crash

map_init will set m->nbuckets to 0, how could you step into the while loop without any map_set_ operations?
#define map_init(m)\
  memset(m, 0, sizeof(*(m)))


Setting registry-url doesn't actually work

Description:
When setting registry-url the result of running npm config get registry remains the default instead of the configured value.
Action version:
v3.3.0
Platform:

[x] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[x] Hosted
[ ] Self-hosted

Tools version:
node v16.15.1 (npm v8.11.0)
Repro steps:
name: Test
on: [push]
jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: 16
          registry-url: http://reg.example.com/
      - run: npm config get registry

Expected behavior:
Last step of the action echos http://reg.example.com/.
Actual behavior:
Last step of the action echos https://registry.npmjs.org/ .

Seems like I was missing the scope option, but documentation could certainly be improved for this.

Hello @jonkoops
Thank you for your suggestion, we will try to make our documentation more user-friendly! :)


Deleting inventory in adjustments is not correctly updating inventory quantities

Hello,
When I delete inventory due to an error or just testing it out the on hand information does not update on the dashboard screen.. For instance I deleted all of our inventory to zero and it still indicates we have 330 items on hand. Please advice.

Closing because #262 resolves this.


Graph builder error "no such directory memory:/"

Error:
react-dom.development.js:11865 Uncaught GraphBuildError: Graph building failed with errors:
No such directory memory:/ at
 GraphBuilder.doAddUnresolvedUri:memory:/index.js
    at GraphBuilder.buildGraph (http://localhost:8080/public/148.js:1884:19)

Code sample as follows:
import * as Velcro from "@velcro/runner";
...
    const code = `
      console.log("I am a trivial sample");
    `;
    Velcro.execute(code, {
      readUrl: u => {
        console.log("fetching", u)
        return fetch(u).then(u => u.arrayBuffer())
      },
      external: (x) => {
        return false;
      },
      injectModules: {
      },
      dependencies: {},
      nodeEnv: "production"
    })

As discussed this also fails upon the (sandbox demo)[https://plnkr.co/edit/sDnzv3QEv6wudM9P].
Original findings:
I have had a go at trying to hook all this up, with little avail unfortunately. I keep hitting the same error as seen on the sandbox, after having tried various combinations of the new runner or composing these constructs myself.
I am pretty sure I have narrowed it down to the listEntries first line in memoryStrategy.ts
The offending line:
Uri.ensureTrailingSlash(uri).fsPath
where fsPath seems to be returning a backslash rather than a forward slash, which is then fed into getEntryAtPath, which then resolves a parent as undefined, as no segment/child can be found matching "" obviously!
I cant seem to locate fsPath on Uri or the builtin URL prototype, so perhaps you can help me work out where this is coming from?
I also noticed an inconsistency between Uri.parse('memory:///') and the generated Uri("memory:/directory/path"). Not sure if this is a problem though, i just cant rule it out yet either.

Lemme know if this fixes what you're seeing. I think it should given that there is now automatic testing in different node versions and OS flavours.

Tested and working as intended. Thanks


Base pulumi-gcp on the Google Beta Terraform provider

This PR is another approach to adopting the GCP Beta provider from Terraform, as previously discussed. We can now use gomod-override to depend on the beta provider.
There are still some new resources to map - this PR is initially intended to ensure we pass CI.
Fixes #57.

Closing this in favour of a new updated PR.


ValueError: Could not find path to the "jackhmmer" binary. Make sure it is installed on your system

I installed alphafold2 step by step, but I found an error as the following:
(base) [root@adf alphafold-2.2.0]#  bash run_alphafold.sh -d ./alphafold_data/ -o ./dummy_test/ -f ./example/query.fasta -t 2020-05-14 -g False
which: no jackhmmer in (/root/miniconda3/bin:/root/miniconda3/condabin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin)
Traceback (most recent call last):
  File "/root/alphafold-2.2.0/run_alphafold.py", line 422, in <module>
    app.run(main)
  File "/root/miniconda3/lib/python3.9/site-packages/absl/app.py", line 312, in run
    _run_main(main, args)
  File "/root/miniconda3/lib/python3.9/site-packages/absl/app.py", line 258, in _run_main
    sys.exit(main(argv))
  File "/root/alphafold-2.2.0/run_alphafold.py", line 285, in main
    raise ValueError(f'Could not find path to the "{tool_name}" binary. Make '
ValueError: Could not find path to the "jackhmmer" binary. Make sure it is installed on your system.

How to resolve this problem, I sincerely need u help. Thank u~

Hi @pariskang,
Thanks for the question! We'd strongly recommend using the Docker workflow, as this will ensure jackhmmr is installed correctly within the running container, but if not you can pass --jackhmmer_binary_path=/path/to/jackhmmr to set the location of the jackhmmr binary.
Hope that helps!

Where does one get the jackhmmer binary? I haven't been able to find it.

We recommend using the Docker container which installs it for you. But if you prefer not to, you can install jackhmmer using this command (on a Debian-based Linux distribution):
sudo apt install hmmer


onedb change_body can't update records owned by UID different than 0

Author Name: Anton Todorov (Anton Todorov)
Original Redmine Issue: 5443, https://dev.opennebula.org/issues/5443
Original Date: 2017-10-06

Hi,
How to reproduce:

Create a VM with user different than 'oneadmin' (uid<>0)

Update the VM body. for example change the size of disk 0:
@$ onedb change-body vm --id 54 "/VM/TEMPLATE/DISK[DISK_ID=0]/SIZE" $((25*1024)); echo $?
0@

onedb exits with exit code 0

Result: the VM body element is not updated
Expected behavior: the VM body element should be updated
The cedits for the investigation of the issue should go to Jean-Mark Therond from Iguane Solutions.
Here is a patch that resolves the above example:

--- /usr/lib/one/ruby/onedb/onedb_live.rb.orig	2017-10-06 22:23:30.616440701 +0300
+++ /usr/lib/one/ruby/onedb/onedb_live.rb	2017-10-06 22:23:44.059959332 +0300
@@ -327,7 +327,7 @@
             raise "A value or --delete should specified"
         end

-        object.info
+        object.info_all

         object.each do |o|
             if options[:id]

Best Regards,
Anton Todorov

Original Redmine Comment
Author Name: Anton Todorov (Anton Todorov)
Original Date: 2017-10-06T19:46:48Z

Pull request #522
https://github.com/OpenNebula/one/pull/522
BR,
Anton

Already merge thanks


vela addon list comnond raises error, after adding private addon registry

Describe the bug
vela addon list comnond raises error, after adding private addon registry
To Reproduce
Steps to reproduce the behavior:

follow official doc to install kubevela v1.2.0 and velaux addon
visit velaux webpage and go to the page "Addons"
click button "Addon Registries" to add one more privete catalog
set Registry Type is Github, URL is my github repo, Path is "addons", and click button "submit"
run the commond vela addon list to list all addons, and it raises error

Error: resource name may not be empty

KubeVela Version
➜  KubeVela vela version
Version: v1.2.0
GitRevision: git-6cee468
GolangVersion: go1.16.13
➜  KubeVela

After debugging, my investigation is as below:
Here is the output of "tree" of my private catalog
➜  my-test tree ./oam-catalog
./oam-catalog
├── README.md
└── addons
    ├── README.md
    └── mytest-middleware
        ├── README.md
        ├── definitions
        │   └── middleware-component.yaml
        ├── metadata.yaml
        ├── resources
        ├── schemas
        └── template.yaml

5 directories, 6 files
➜  my-test

Please note that ,there is one "README.md" under the folder "addons", which is the "Path" of my private addon registry.
"mytest-middleware" is a valid addon directory, but "README.md" is not.
When "vela addon list" tries to ListAddonMeta, the g.h.readRepo("") returns both "README.md" and "mytest-middleware" and treats both them as valid addon.
Actually the file "README.md" can not be a valid addon, so vela needs ingore file when list addon meta.


Bug fix/fix limit with count collect

Scope & Purpose
A LIMIT operation before a COUNT WITH COLLECT INTO did consume all input from above, resulting in an unnecessarily large runtime.
There is still a similar open problem with two adjacent top-level LIMIT operations when the query has the fullCount option set. This is more complicated to fix and will be addressed later.

[X] :hankey: Bugfix
[x] :book: CHANGELOG entry made
[X] :muscle: The behavior in this PR was manually tested
[X] :computer: The behavior change can be verified via automatic tests

Backports:

[ ] No backports required
[X] Backports required for: 3.7

Related Information

[X] Jira ticket number: ES-692

Testing & Verification

[X] This change is already covered by existing tests, such as gtest LimitExecutorTests.
[X] This PR adds tests that were used to verify all changes:

[X] Added Regression Tests

Documentation

[x] Added a Changelog Entry (referencing the corresponding public or internal issue number)

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/12033/


Move compilation out of threadsfor

Has a remaining bug in reverse mode, and prints need removal.

@vchuravy
wmoses@beast:~/git/Enzyme.jl (rtest) $ cat thread.jl
using Enzyme
Enzyme.API.printperf!(true)
function foo(y, s, e)
        Base.Threads.threading_run() do
            @inbounds y[s] *= 2
        end
        nothing
end

x = [1.0, 2.0, 3.0]

dx = [1., 1.0, 1.0]
Enzyme.API.printall!(true)
@show Enzyme.autodiff(foo, Duplicated(x, dx), 1, 1)
@show x, dx

Failed for me on 1.7.1 with:
ERROR: LoadError: MethodError: Cannot `convert` an object of type Core.LLVMPtr{UInt8, 0} to an object of type Ptr{Nothing}
Closest candidates are:
  convert(::Type{Ptr{T}}, ::Union{Int64, UInt64}) where T at ~/builds/julia-1.7.1/share/julia/base/pointer.jl:26
  convert(::Type{Ptr{T}}, ::Ptr{T}) where T at ~/builds/julia-1.7.1/share/julia/base/pointer.jl:29
  convert(::Type{Ptr{T}}, ::Ptr) where T at ~/builds/julia-1.7.1/share/julia/base/pointer.jl:30
  ...
Stacktrace:
 [1] Enzyme.Compiler.Tape(thunk::Enzyme.Compiler.AdjointThunk{typeof(Base.Threads.threading_run), Const{Nothing}, Tuple{Duplicated{var"#1#2"{Vector{Float64}, Int64}}}, Val{0x0000000000000001}, Nothing}, internal_tape::Core.LLVMPtr{UInt8, 0}, shadow_return::Nothing, resT::Type)
   @ Enzyme.Compiler ~/src/Enzyme/src/compiler.jl:304
in expression starting at /home/vchuravy/src/Enzyme/thread.jl:18

Replaced by #342


Whenever the Panel is closed while floating or in pinned state, the contentViewController is not aware of being dismissed

First Let me say that I have really enjoyed using this! I love the ability to drag around a popover!
I just wanted to add that I am using version 0.8.2, and this is a kind of simple fix to allow the contentViewController to be aware it will be dismissed!
I can add this in for you, no problem!  I am using PanelKit in one of my projects that is also using obj-c pods so I had to download the master manually include it in my project so my Cocoapods didn't clash, but overall this is great.
`extension PanelManager where Self: UIViewController {
func close(_ panel: PanelViewController) {

    if (panel.contentViewController != nil) {
        panel.contentViewController!.viewWillDisappear(true)
    }

	panel.view.removeFromSuperview()

	panel.contentViewController?.didUpdateFloatingState()

	if panel.isPinned {
		didDragFree(panel)
    }
}

}`

0.8.2 is an old version, can you update to PanelKit 1.0?

I will do that later today, I haven't been back to the page until today and didn't release a newer version was released :)


wm-backend to 0.0.1

Promote wm-backend to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amegas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

promotion-build
b94943fd6631c52451cfc224188226b1590ef150
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Feature/compatible protocol versions

To check compatibility just before sending message via a socket, both outbound and inbound now have node infos with socket.

Update README.md
Restruct outbound and inbound
Get back to data version 1.0.0

PTAL! All addressed!


Do you have any examples? Next.js

Hey there
I had this working with Next.js following this guide https://www.sanity.io/guides/nextjs-live-preview
The issue I was having was that the preview mode wasn't being enabled. It looked like the redirect wasn't being followed, but I can see in the screenshot in the repo that it doesn't update.  If I opened the preview URL in a new tab it works as expected.
Do you have any examples you could share? I really want to use this, as it looks awesome :)
Best
Steve

That guide has been rewritten for Studio v3, and should have some better guidance for you.


The PHP version is not updated to latest release

Describe the bug
The PHP version is not updated to 8.2.15 using update: true
Version

[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
runs-on: ubuntu-latest

PHP versions
8.2
To Reproduce
- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.2'
    coverage: xdebug
  env:
    update: true

Expected behavior
==> Setup PHP
✓ PHP Installed PHP 8.2.15

Screenshots/Logs
==> Setup PHP
✓ PHP Installed PHP 8.2.14

@imahmood Please check now

Thanks.


Bug report: depends error.

It does not work, the example from sentiment-analysis-adapter/examples/adapter-inference-demo.ipynb
After installation of the depends, all of them succeed, here,

Success Message
!pip install git+https://github.com/adapter-hub/adapter-transformers.git
!git clone https://github.com/huggingface/transformers
!pip install mecab-python3==0.996.5
!pip install unidic-lite

Collecting git+https://github.com/adapter-hub/adapter-transformers.git
  Cloning https://github.com/adapter-hub/adapter-transformers.git to /tmp/pip-req-build-sv8ztost
  Running command git clone -q https://github.com/adapter-hub/adapter-transformers.git /tmp/pip-req-build-sv8ztost
  Installing build dependencies ... [?25l[?25hdone
  Getting requirements to build wheel ... [?25l[?25hdone
    Preparing wheel metadata ... [?25l[?25hdone
Requirement already satisfied: filelock in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (3.0.12)
Requirement already satisfied: importlib-metadata; python_version < "3.8" in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (3.10.1)
Collecting tokenizers<0.11,>=0.10.1
[?25l  Downloading https://files.pythonhosted.org/packages/ae/04/5b870f26a858552025a62f1649c20d29d2672c02ff3c3fb4c688ca46467a/tokenizers-0.10.2-cp37-cp37m-manylinux2010_x86_64.whl (3.3MB)
[K     |████████████████████████████████| 3.3MB 6.4MB/s
[?25hRequirement already satisfied: requests in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (2.23.0)
Requirement already satisfied: tqdm>=4.27 in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (4.41.1)
Requirement already satisfied: regex!=2019.12.17 in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (2019.12.20)
Collecting sacremoses
[?25l  Downloading https://files.pythonhosted.org/packages/75/ee/67241dc87f266093c533a2d4d3d69438e57d7a90abb216fa076e7d475d4a/sacremoses-0.0.45-py3-none-any.whl (895kB)
[K     |████████████████████████████████| 901kB 38.3MB/s
[?25hRequirement already satisfied: packaging in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (20.9)
Requirement already satisfied: numpy>=1.17 in /usr/local/lib/python3.7/dist-packages (from adapter-transformers==2.0.0) (1.19.5)
Requirement already satisfied: zipp>=0.5 in /usr/local/lib/python3.7/dist-packages (from importlib-metadata; python_version < "3.8"->adapter-transformers==2.0.0) (3.4.1)
Requirement already satisfied: typing-extensions>=3.6.4; python_version < "3.8" in /usr/local/lib/python3.7/dist-packages (from importlib-metadata; python_version < "3.8"->adapter-transformers==2.0.0) (<IP_ADDRESS>)
Requirement already satisfied: chardet<4,>=3.0.2 in /usr/local/lib/python3.7/dist-packages (from requests->adapter-transformers==2.0.0) (3.0.4)
Requirement already satisfied: urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1 in /usr/local/lib/python3.7/dist-packages (from requests->adapter-transformers==2.0.0) (1.24.3)
Requirement already satisfied: certifi>=2017.4.17 in /usr/local/lib/python3.7/dist-packages (from requests->adapter-transformers==2.0.0) (2020.12.5)
Requirement already satisfied: idna<3,>=2.5 in /usr/local/lib/python3.7/dist-packages (from requests->adapter-transformers==2.0.0) (2.10)
Requirement already satisfied: click in /usr/local/lib/python3.7/dist-packages (from sacremoses->adapter-transformers==2.0.0) (7.1.2)
Requirement already satisfied: joblib in /usr/local/lib/python3.7/dist-packages (from sacremoses->adapter-transformers==2.0.0) (1.0.1)
Requirement already satisfied: six in /usr/local/lib/python3.7/dist-packages (from sacremoses->adapter-transformers==2.0.0) (1.15.0)
Requirement already satisfied: pyparsing>=2.0.2 in /usr/local/lib/python3.7/dist-packages (from packaging->adapter-transformers==2.0.0) (2.4.7)
Building wheels for collected packages: adapter-transformers
  Building wheel for adapter-transformers (PEP 517) ... [?25l[?25hdone
  Created wheel for adapter-transformers: filename=adapter_transformers-2.0.0-cp37-none-any.whl size=2097542 sha256=fd85fda47597c346590a2f23d8e3efb341932f6d582456f6c45eab31337bbef5
  Stored in directory: /tmp/pip-ephem-wheel-cache-7pw2q8li/wheels/22/eb/df/1c86c6a1b0323a74470d6a53db05b3b49ec79bce18d253ec38
Successfully built adapter-transformers
Installing collected packages: tokenizers, sacremoses, adapter-transformers
Successfully installed adapter-transformers-2.0.0 sacremoses-0.0.45 tokenizers-0.10.2
Cloning into 'transformers'...
remote: Enumerating objects: 71643, done.[K
remote: Counting objects: 100% (163/163), done.[K
remote: Compressing objects: 100% (80/80), done.[K
remote: Total 71643 (delta 93), reused 116 (delta 74), pack-reused 71480[K
Receiving objects: 100% (71643/71643), 54.35 MiB | 25.59 MiB/s, done.
Resolving deltas: 100% (50847/50847), done.
Collecting mecab-python3==0.996.5
[?25l  Downloading https://files.pythonhosted.org/packages/47/62/f1e4ffba2f904b8998da8df4372d70cf4dad6301b94f4f9e50e9aea1b82e/mecab_python3-0.996.5-cp37-cp37m-manylinux2010_x86_64.whl (17.1MB)
[K     |████████████████████████████████| 17.1MB 237kB/s
[?25hInstalling collected packages: mecab-python3
Successfully installed mecab-python3-0.996.5
Collecting unidic-lite
[?25l  Downloading https://files.pythonhosted.org/packages/55/2b/8cf7514cb57d028abcef625afa847d60ff1ffbf0049c36b78faa7c35046f/unidic-lite-1.0.8.tar.gz (47.4MB)
[K     |████████████████████████████████| 47.4MB 97kB/s
[?25hBuilding wheels for collected packages: unidic-lite
  Building wheel for unidic-lite (setup.py) ... [?25l[?25hdone
  Created wheel for unidic-lite: filename=unidic_lite-1.0.8-cp37-none-any.whl size=47658825 sha256=94006fb8a1a15f2fab010a6432e638d6a74e03ab3e8a88d08297e2a5b881bb8e
  Stored in directory: /root/.cache/pip/wheels/20/48/8d/b66d8361a27f58f41ec86640e4fd2640de0403a6367511eab7
Successfully built unidic-lite
Installing collected packages: unidic-lite
Successfully installed unidic-lite-1.0.8

But it does not works when loading the PTM.

Error Messages
model = AutoModelForSequenceClassification.from_pretrained("cl-tohoku/bert-base-japanese-whole-word-masking")
tokenizer = AutoTokenizer.from_pretrained("cl-tohoku/bert-base-japanese-whole-word-masking")

Some weights of the model checkpoint at cl-tohoku/bert-base-japanese-whole-word-masking were not used when initializing BertForSequenceClassification: ['cls.predictions.bias', 'cls.predictions.transform.dense.weight', 'cls.predictions.transform.dense.bias', 'cls.predictions.transform.LayerNorm.weight', 'cls.predictions.transform.LayerNorm.bias', 'cls.predictions.decoder.weight', 'cls.seq_relationship.weight', 'cls.seq_relationship.bias']
- This IS expected if you are initializing BertForSequenceClassification from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing BertForSequenceClassification from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
Some weights of BertForSequenceClassification were not initialized from the model checkpoint at cl-tohoku/bert-base-japanese-whole-word-masking and are newly initialized: ['classifier.weight', 'classifier.bias']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.

---------------------------------------------------------------------------

ModuleNotFoundError                       Traceback (most recent call last)

/usr/local/lib/python3.7/dist-packages/transformers/models/bert_japanese/tokenization_bert_japanese.py in __init__(self, do_lower_case, never_split, normalize_text, mecab_dic, mecab_option)
    229         try:
--> 230             import fugashi
    231         except ModuleNotFoundError as error:

ModuleNotFoundError: No module named 'fugashi'

During handling of the above exception, another exception occurred:

ModuleNotFoundError                       Traceback (most recent call last)

<ipython-input-5-0a404df7ebfd> in <module>()
      1 model = AutoModelForSequenceClassification.from_pretrained("cl-tohoku/bert-base-japanese-whole-word-masking")
----> 2 tokenizer = AutoTokenizer.from_pretrained("cl-tohoku/bert-base-japanese-whole-word-masking")

/usr/local/lib/python3.7/dist-packages/transformers/models/auto/tokenization_auto.py in from_pretrained(cls, pretrained_model_name_or_path, *inputs, **kwargs)
    405                     f"Tokenizer class {tokenizer_class_candidate} does not exist or is not currently imported."
    406                 )
--> 407             return tokenizer_class.from_pretrained(pretrained_model_name_or_path, *inputs, **kwargs)
    408
    409         # if model is an encoder decoder, the encoder tokenizer class is used by default

/usr/local/lib/python3.7/dist-packages/transformers/tokenization_utils_base.py in from_pretrained(cls, pretrained_model_name_or_path, *init_inputs, **kwargs)
   1708
   1709         return cls._from_pretrained(
-> 1710             resolved_vocab_files, pretrained_model_name_or_path, init_configuration, *init_inputs, **kwargs
   1711         )
   1712

/usr/local/lib/python3.7/dist-packages/transformers/tokenization_utils_base.py in _from_pretrained(cls, resolved_vocab_files, pretrained_model_name_or_path, init_configuration, *init_inputs, **kwargs)
   1779         # Instantiate tokenizer.
   1780         try:
-> 1781             tokenizer = cls(*init_inputs, **init_kwargs)
   1782         except OSError:
   1783             raise OSError(

/usr/local/lib/python3.7/dist-packages/transformers/models/bert_japanese/tokenization_bert_japanese.py in __init__(self, vocab_file, do_lower_case, do_word_tokenize, do_subword_tokenize, word_tokenizer_type, subword_tokenizer_type, never_split, unk_token, sep_token, pad_token, cls_token, mask_token, mecab_kwargs, **kwargs)
    149             elif word_tokenizer_type == "mecab":
    150                 self.word_tokenizer = MecabTokenizer(
--> 151                     do_lower_case=do_lower_case, never_split=never_split, **(mecab_kwargs or {})
    152                 )
    153             else:

/usr/local/lib/python3.7/dist-packages/transformers/models/bert_japanese/tokenization_bert_japanese.py in __init__(self, do_lower_case, never_split, normalize_text, mecab_dic, mecab_option)
    231         except ModuleNotFoundError as error:
    232             raise error.__class__(
--> 233                 "You need to install fugashi to use MecabTokenizer."
    234                 "See https://pypi.org/project/fugashi/ for installation."
    235             )

ModuleNotFoundError: You need to install fugashi to use MecabTokenizer.See https://pypi.org/project/fugashi/ for installation.

---------------------------------------------------------------------------
NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.

To view examples of installing some common dependencies, click the
"Open Examples" button below.
---------------------------------------------------------------------------

all runs on Colab.

after I install the depends, it works.


fix(2878552430): User routes to the main screen even if not choose an L2 wallet

Description of the Changes
This fix is for a scenario where the user closes the popup window of the wallet connection and goes into the main application screen. the solution is to add another check in the if statement which checks that the address that we receiving from the get-starknet library is something not falsy (in our case is an empty string)
Checklist

[ ] Changes have been done against master branch, and PR does not conflict
[ ] New unit / functional tests have been added (whenever applicable)
[ ] Test are passing in local environment
[ ] Docs have been updated
[ ] PR title is follow the Conventional Commits convention: <type>[optional scope]: <description>, e.g: fix: prevent racing of requests

This change is

@galuzan-starkware

Please Add description to the PR
Please change the title to reflect better the issue

:tada: This PR is included in version 1.7.0-dev.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


replace  "Service Mesh Discussion forum" with 'Discussion Forum'

Signed-off-by: ayush_gitk<EMAIL_ADDRESS>Description
This PR fixes #6510
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 4cfadceb7a88b16ec2bafcf583335c0da01ce1ce at: https://636e51e55a480424dab99dd8--meshery-docs-preview.netlify.app


ros_control: 0.13.5-1 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros_control to 0.13.5-1:

upstream repository: https://github.com/ros-controls/ros_control.git
release repository: https://github.com/ros-gbp/ros_control-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.9.0
previous version for package: 0.13.4-1

combined_robot_hw
* Improve controller and resource filtering for CombinedRobotHW
* Contributors: Toni Oliver, Bence Magyar

combined_robot_hw_tests
* Improve controller and resource filtering for CombinedRobotHW
* Contributors: Toni Oliver, Bence Magyar

controller_interface

No changes

controller_manager

No changes

controller_manager_msgs

No changes

controller_manager_tests

No changes

hardware_interface

No changes

joint_limits_interface

No changes

ros_control

No changes

rqt_controller_manager

No changes

transmission_interface

No changes

Holding for sync


Docker compose failing from the beginning

Expected Behavior
I expected the container to build and the app to start after running docker compose up.
Current Behavior
Upon starting the container, it immediately crashes.
Here are the logs:
[+] Building 0.0s (0/0)
[+] Running 1/0
 ✔ Container lollms-webui-webui-1  Created                                                                         0.0s
Attaching to lollms-webui-webui-1
lollms-webui-webui-1  | Welcome! It seems this is your first use of the new lollms app.
lollms-webui-webui-1  | To make it clear where your data are stored, we now give the user the choice where to put its data.
lollms-webui-webui-1  | This allows you to mutualize models which are heavy, between multiple lollms compatible apps.
lollms-webui-webui-1  | You can change this at any tome using the lollms-update_path script or by simply change the content of the global_paths_cfg.yaml file.
lollms-webui-webui-1  | Please provide a folder to store your configurations files, your models and your personal data (database, custom personalities etc).
lollms-webui-webui-1  | Traceback (most recent call last):
lollms-webui-webui-1  |   File "/srv/app.py", line 1157, in <module>
lollms-webui-webui-1  |     lollms_paths = LollmsPaths.find_paths(force_local=True, custom_default_cfg_path="configs/config.yaml")
lollms-webui-webui-1  |   File "/usr/local/lib/python3.10/site-packages/lollms/paths.py", line 112, in find_paths
lollms-webui-webui-1  |     cfg.lollms_personal_path = input(f"Folder path: ({cfg.lollms_personal_path}):")
lollms-webui-webui-1  | EOFError: EOF when reading a line
lollms-webui-webui-1 exited with code 1

Steps to Reproduce
Please provide detailed steps to reproduce the issue.

Clone the repo
Run docker compose up
It dies

Context
I guess there is no context, it's Docker, the environment should be set in stone and never changing..

It looks like lollms-webui is expecting a global configuration file in lollms-webui/ called global_paths_cfg.yaml. It should contain:

The path to the lollms library
The path to a configuration cache for the LLMs and database stuff

lollms_path: /home/user/.local/lib/python3.11/site-packages/lollms
lollms_personal_path: /home/user/.cache/lollms

The lollms_personal_path will look like this after initialization:
tree
.
├── configs
│   ├── binding_llamacpp_config.yaml
│   └── local_config.yaml
├── data
├── databases
│   └── database.db
└── models
    ├── binding_template
    ├── c_transformers
    │   ├── mpt-7b-storywriter.ggmlv3.q5_1.bin
    │   └── starcoderplus.ggmlv3.q4_1.bin
    ├── gpt_4all
    │   ├── ggml-gpt4all-j-v1.3-groovy.bin
    │   ├── ggml-gpt4all-l13b-snoozy.bin
    │   ├── ggml-mpt-7b-chat.bin
    │   ├── ggml-mpt-7b-instruct.bin
    │   └── ggml-vicuna-13b-1.1-q4_2.bin
    ├── gpt_j_a
    │   ├── ggml-gpt4all-j-v1.3-groovy.bin
    │   ├── ggml-gpt4all-l13b-snoozy.bin
    │   ├── ggml-mpt-7b-chat.bin
    │   ├── ggml-mpt-7b-instruct.bin
    │   └── ggml-vicuna-13b-1.1-q4_2.bin
    ├── gpt_j_m
    ├── gptq
    ├── hugging_face
    ├── llama_cpp_official
    │   ├── airoboros-13b-gpt4.ggmlv3.q4_0.bin
    │   ├── airoboros-33b-gpt4-1.2.ggmlv3.q2_K.bin
    │   ├── Wizard-Vicuna-13B-Uncensored.ggmlv3.q4_0.bin
    │   └── Wizard-Vicuna-30B-Uncensored.ggmlv3.q4_K_S.bin
    ├── open_ai
    └── py_llama_cpp
        ├── Manticore-13B.ggmlv3.q4_0.bin
        └── Wizard-Vicuna-13B-Uncensored.ggmlv3.q4_0.bin

You need to create the models directory manually, and each of the subdirectories, since it doesn't seem to be created automatically:
mkdir models/{py_llama_cpp,c_transformers,llama_cpp_official,binding_template,gpt_j_m,gpt_4all,open_ai,gpt_j_a,gptq,hugging_face}

The file global_paths_cfg.yaml should probably be mentioned in the README.md file...

Hi, this looks cool.
Consider making a pull request if you want to share your work on the main ui. i basically coded the docker with my eyes closed, as I had no access to a docker enabled machine.
Nice job.

I  still had this issue

Can you try the last updates?


[PORT] [LowScoreVariation]For first item with score more than MaxScoreForLow…

Port this change from botbuilder-dotnet/master branch:
https://github.com/microsoft/botbuilder-dotnet/pull/3730

…ScoreVariation return the list with first item
To address issues
https://github.com/microsoft/botbuilder-dotnet/issues/3642
https://github.com/microsoft/botbuilder-dotnet/issues/3705
Changed projects

Microsoft.Bot.Builder.AI.QnA

@mrestorff Thanks for the PR. @tracyboehrer will take a look at this.


Include LICENSE agreement

Hi, please consider adding LICENSE file to your redistributable package for legal reasons.
text copied from wiki https://en.wikipedia.org/wiki/MIT_License

Ah yes, complete oversight on my part, thanks for the contribution!


Removes unused ember-getowner-polyfill dependency

ember-getowner-polyfill is no longer used in ESA and triggers a deprecation warning in latest releases of Ember.

ember-getowner-polyfill is actually still used - you just don't need to import getOwner anymore as it is now a proper polyfill that adds the method to the Ember global. The deprecation was resolved in #1124

Sorry I missed it. Thanks

Thanks for the effort!


Android dependency 'android.arch.lifecycle:runtime' has different version for the compile  and runtime

Execution failed for task ':app:preDebugBuild'.

Android dependency 'android.arch.lifecycle:runtime' has different version for the compile (1.0.0) and runtime (1.0.3) classpath. You should manually set the same version via DependencyResolution

buildfailed ，how should i do？

You have to manually include that dependency to make sure you're getting the right version. See more here: https://stackoverflow.com/a/47066325


Several web apps with offline plugin on the same domain

Hi,
when deploying two (or more !) web apps on the same domain, the installation of the last one deletes the cache of the previously installed web app.
I don't see anything in the configuration that could make a work around. Am I wrong ?
It is a really bing constraint to limit the number of installable web apps on a unique domain.
I'm quiet under pressure on this as I should have already delivered these two applications to my client ...
Let me know if I can help.

Hi @VincentFTS,
Yes, I hear. That's indeed unfortunate to not be able to run multiple apps on the same domain. I'll add that now, but only to v4 branch (which isn't released yet). There is nothing wrong v4, but it's kind of in beta, so potentially, there could be some issues.

Okay, I just added it to v4. You can use it this way:
new OfflinePlugin({
  ServiceWorker: {
    cacheName: 'my-project'
  }
})

Here are more details on how to install v4: https://github.com/NekR/offline-plugin/pull/109
Thanks for reproting this!

Thanks for your very quick replies !
Seems to be quiet a simple patch. Why not applying it to v3 ? It's seems to carry no risk of regression.
If you decide to not do it, it would be interesting to add an explanation about the 'only one app per domain' limitation in the README.

@VincentFTS I don't want to do it because v4 should be released shortly and even now everyone should start using v4. v3 is mostly dead. Not that v4 is a bad release. It's just that there is a lot of time invested in v4 and that is the way to go.
What is the problem of using v4?

You said it is a beta, and I need to go in production. When do you plan to release v4 ?
Envoyé de mon iPad

Le 16 oct. 2016 à 21:25, Arthur Stolyar<EMAIL_ADDRESS>a écrit :
@VincentFTS I don't want to do it because v4 should be released shortly and even now everyone should start using v4. v3 is mostly dead. Not that v4 is a bad release. It's just that there is a lot of time invested in v4 and that is the way to go.
What is the problem of using v4?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

That's right, it's in beta. Though, many people are using beta project: a lot of people using beta TypeScript, gulp, html-webpack-plugin (at a time). Facebook for examples uses React on production directly from master branch, i.e. with all latest changes.
I'm trying to release v4 in this month. Though, that may not happen by any reason. If you don't want to use v4, I suggest you to just fork current version (v3 in master) and just add that small patch in your fork, and then just use that fork until v4 of offline-plugin is released.

OK, I switched to v4.3.0, and I added the cacheName key to my config, but it doesn't seem to be taken into account in the cache name I see in chrome dev tools.
Here is my config :
            new OfflinePlugin({                 ServiceWorker: {                     events: true                 },                 updateStrategy: 'changed',                 cacheName: 'allo'             })

It's
new OfflinePlugin({
  ServiceWorker: {
    cacheName: 'my-project'
  }
})

not
new OfflinePlugin({
  cacheName: 'my-project'
})

as you did.

Thanks !


readme

Type
documentation

Description

Removed the "Installation" section from the README and commented out its content for potential future use.
Updated the "PR-Agent Pro" sections across README and documentation to include GitLab alongside GitHub and BitBucket.
Introduced new features "Improve Component" and "Similar code search" under the "PR-Agent Pro" section in the documentation.
Standardized capitalization in section titles across documentation files for consistency.
Added a note for PR-Agent Pro users in the "Automations and Usage" guide regarding configurations for GitHub App, GitLab webhook, and BitBucket App.

Changes walkthrough
Relevant filesDocumentation

README.mdUpdate README: Remove Installation Section and Update PR-Agent Pro Details

README.md
Removed the "Installation" section and commented out its content.  Updated the "PR-Agent Pro" section to include GitLab in the list of platforms.

+32/-18

index.mdDocumentation Updates: Section Titles and PR-Agent Pro Enhancements

docs/docs/index.md
Changed "Example results" to "Example Results" and "How it works" to "How it Works".  Updated the "PR-Agent Pro" section to include GitLab in the list of platforms.  Added new features to the "PR-Agent Pro" section: "Improve Component" and "Similar code search".  Changed "Data privacy" to "Data Privacy".

+6/-4

index.mdUpdate Installation Documentation for Self-hosted PR-Agent

docs/docs/installation/index.md
Changed "self-hosted PR-Agent" to "Self-hosted PR-Agent".  Updated the section to include GitLab and BitBucket in the list of platforms for acquiring a personal access token.

+1/-1

automations_and_usage.mdAdd Note for PR-Agent Pro Users in Automations and Usage Guide

docs/docs/usage-guide/automations_and_usage.md
Added a note about configurations for PR-Agent Pro users regarding GitHub App, GitLab webhook, and BitBucket App.

+4/-0

mkdocs.ymlUpdate Navigation Title for Mail Notifications in MkDocs Configuration

docs/mkdocs.yml
Changed "Managing email notifications" to "Managing Mail Notifications" in the navigation structure.

+1/-1

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/review auto_approve

/help


JDL generator has wrong regex validation for language(can't pass zh-cn,zh-tw)

The language regex can't contains dash character, we need to support that.
Accoridng to https://tools.ietf.org/html/rfc5646, some language code also
may contain number characters.
=================
676 passing (1s)
$ npm run coverage

<EMAIL_ADDRESS>coverage /home/bohong/workspace/jhipster-core
nyc --reporter=text-summary report

=============================== Coverage summary ===============================
Statements   : 96.75% ( 2500/2584 )
Branches     : 93.05% ( 1125/1209 )
Functions    : 96.41% ( 671/696 )
Lines        : 96.82% ( 2470/2551 )
Done in 7.03s.
Please make sure the below checklist is followed for Pull Requests.

[✔] Travis tests are green
[✔] Tests are added where necessary
[✔] Documentation is added/updated where necessary
[✔] Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed

It should be working.... anyway, thanks for fixing it, I'll have a look at it today


Make JSON icons work with JSON-Lines and NDJSON file extensions

JSON Lines (.jsonl) and NDJSON (.ndjson) are common file formats for large JSON datasets, often used for bulk downloads from APIs or object storage, or bulk loading into databases, search engines, etc. They are very similar (JSONL additionally specifies that the file must be utf-8 encoded).
It would be great to add those file extensions to the existing JSON icons json, json_official, and maybe json2. I understand users can do this themselves by modifying their settings.json like so:
  "vsicons.associations.files": [
    {"icon": "json", "extensions": ["json", "jsonl", "ndjson"]}
  ],

I think it would be great to have this a default in the extension! I'd be happy to send a PR to update the relevant code if it is welcome: https://github.com/vscode-icons/vscode-icons/blob/5628062179754442985d4a4e047501adaaf9491f/src/iconsManifest/supportedExtensions.ts#L2187-L2207
Thanks!

From what I've found, PR's are always welcome (not like I've got 5 PR's open now...), so go ahead and PR it if you like, or I'm happy to as well :)


Figure out what to do with phones in CI for Android

We need to come up with a strategy to manage Lollipop vs Marshmallow. We need to run on both and so we should be testing on both.
First, we should have at least one phone that is running KitKat just to make sure our library properly throws when running on it. We will need to teach the coordination server about the existence of this phone so it doesn't try to hand it out for tests.
Second, in an ideal world we would magically find that two of the phones that don't have the right BLE hardware to be peripherals can in fact run lollipop and Marshmallow and we would keep them around just to test that we fail properly on those phones even though they have the right OS.
Third, of the remaining phones that do have the right BLE hardware we need to split them up between Lollipop and Marshmallow. Looking at the phones list I realize we didn't get enough Nexus phones. We need them because they will run whatever is the bleeding edge. For example, my HTC Is running 6 but my Nexus phones are running 6.0.1. Oh well.
Anyway, can you please propose a plan for this mess?

First, we should have at least one phone that is running KitKat just to make sure our library properly throws when running on it.

I wonder should we instead guard build-time that supported API level is used, i.e., set https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/blob/8d0e7c3fd70d3f0bf350c6ed2534f28b019e7875/BtConnectorLib/btconnectorlib2/build.gradle#L12 to the appropriate value?

we would keep them around just to test that we fail properly on those phones even though they have the right OS

Probably a small amount of code should be added so that devices send the BLE capability to the test server and test server excludes the ones that don't have proper capabilities. Not sure what the failure should look like from end user perspective though (in terms of what kind of error message in the UI and when).

Third, of the remaining phones that do have the right BLE hardware we need to split them up between Lollipop and Marshmallow.

We could include the information about the OS in the test results next to device name so that it is easy to see from the results which device has which OS.

minSDKVersion - Yes, we should. My idea was bad.
phones with new OS but bad BLE hardware - We wouldn't have any UX. And I just realized that we actually already signed up to provide his feature. If you look at the networkChanged event it includes a blueToothLowEnergy entry and one of its values is NOT_HERE which is defined as "We depend on this radio type for this platform type but it doesn't appear to exist on this device." I added a note to #356 pointing out that we need to make sure this works right. Then it's up to the user to make sure they check this. But also note that for methods like startListeningForAdvertisements and startUpdateAdvertisingAndListening we have the 'No Native Non-TCP Support' errors which should cover this. So having devices with the right OS and the wrong hardware is still a good idea for testing.
Marking which OS each device has - Amen.

minSDKVersion - Yes, we should. My idea was bad.

This is now done at https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/commit/f40092288cb700e84d1cff28503352cd151d63ca.

So having devices with the right OS and the wrong hardware is still a good idea for testing.

So, the work we are anyways when implementing the new specification covers this from functional perspective, but I think we have to think how to test this in CI. The challenge is that HW-incompatible devices should be excluded from test runs, because otherwise they ruin, for example, find peers -results (because they can't be discovered). Easy solution would be to exclude HW-incompatible devices from the test runs, but then the Thali behavior would not be tested on such devices in CI.

Marking which OS each device has - Amen.

I created this as a separate issue https://github.com/thaliproject/Thali_CordovaPlugin/issues/443.

In terms of the right OS with the wrong hardware I assume we will have two tests, a negative test and a positive test. The negative test will only run on right OS/wrong hardware and the positive test will run on right OS/right hardware.

Current API level split in CI:
$ grep SDK_INT *
thali01_LGE-LG-H815.md:I/io.jxcore.node.ConnectionHelper( 9610): Build version SDK_INT: 22
thali01_samsung-SM-A500FU.md:,I/io.jxcore.node.ConnectionHelper( 6122): Build version SDK_INT: 21
thali02_LGE-LG-D722.md:I/io.jxcore.node.ConnectionHelper( 6356): Build version SDK_INT: 21
thali02_LGE-Nexus 5.md:I/io.jxcore.node.ConnectionHelper( 3269): Build version SDK_INT: 21
thali03_LGE-LG-D855.md:I/io.jxcore.node.ConnectionHelper( 6130): Build version SDK_INT: 21
thali03_motorola-XT1039.md:I/io.jxcore.node.ConnectionHelper( 4378): Build version SDK_INT: 19
thali03_samsung-SM-G800F.md:,I/io.jxcore.node.ConnectionHelper( 7157): Build version SDK_INT: 19,
thali04_motorola-XT1072.md:I/io.jxcore.node.ConnectionHelper( 6473): Build version SDK_INT: 21
thali04_samsung-SM-G900F.md:I/io.jxcore.node.ConnectionHelper( 7254): Build version SDK_INT: 21
thali04_samsung-SM-N910C.md:,I/io.jxcore.node.ConnectionHelper(11762): Build version SDK_INT: 21
thali06_HTC-HTC One M8s.md:,I/io.jxcore.node.ConnectionHelper( 6915): Build version SDK_INT: 21
thali06_LGE-LG-D802.md:I/io.jxcore.node.ConnectionHelper( 4749): Build version SDK_INT: 19
thali06_samsung-SM-A300FU.md:I/io.jxcore.node.ConnectionHelper( 6136): Build version SDK_INT: 21
thali07_samsung-SM-A500FU.md:,I/io.jxcore.node.ConnectionHelper( 6119): Build version SDK_INT: 21
thali07_samsung-SM-G900F.md:,I/io.jxcore.node.ConnectionHelper( 7465): Build version SDK_INT: 21
thali08_HTC-HTC Desire 820.md:I/io.jxcore.node.ConnectionHelper( 4528): Build version SDK_INT: 19
thali08_samsung-SM-A300FU.md:,I/io.jxcore.node.ConnectionHelper( 5713): Build version SDK_INT: 21
thali09_HTC-HTC Desire 820.md:,I/io.jxcore.node.ConnectionHelper( 4527): Build version SDK_INT: 19
thali09_LGE-Nexus 5.md:I/io.jxcore.node.ConnectionHelper( 2754): Build version SDK_INT: 19

@tompaana, @yaronyg: Perhaps as a short-term action, we request to take out the ones that are lower than 21? I believe some can be updated by OEM-provided firmware upgrade, but not sure about all of them.

The latest version (still in the making) should handle sub-21s gracefully, but they would fails the tests. So they should be either updated or removed IMO.

The latest version (still in the making) should handle sub-21s gracefully, but they would fails the tests. So they should be either updated or removed IMO.

Once the "is BLE advertisement supported"-function starts working again, I need to anyways implement a logic that test server knows which devices don't have the required BLE HW-capabilities. This same logic can be used to exclude devices with too low API level and thus we don't need any short-term "physical actions" to the devices in CI and can manage with code changes on our side.
I'll leave this issue open until I have implemented the logic above.

This is now solved. The app doesn't install on devices with too low API level (which is as wanted) so that case isn't tested with CI. The BLE capabilities are checked in the beginning of the unit test app and only capable devices are included in tests. So CI can safely have also non-capable devices and their behavior is reported correctly.


Change how emit_series tries on reruns. fix #2826

This prevents retries on a lot of series that shouldn't have been retried. Need to figure out a way to test some of the behavior though, as the old unit testing method doesn't work for a couple things though.

@paranoidi Might want to double check your emit_series tasks against this again, I think it's good stuff though.


Exclude pre-commit-ci bot from release notes

Codecov Report
Patch coverage has no change and project coverage change: +0.04% :tada:

Comparison is base (0687fc2) 87.80% compared to head (acb18b4) 87.85%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   87.80%   87.85%   +0.04%
==========================================
  Files          33       33
  Lines        2050     2050
  Branches      305      305
==========================================
+ Hits         1800     1801       +1
  Misses        185      185
+ Partials       65       64       -1

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[stable/nfs-client-provisioner] Add OWNERS file

What this PR does / why we need it:
Just adding an OWNERS file..
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Adds OWNERS
Special notes for your reviewer:

/ok-to-test

/lgtm

@unguiculus @prydonius bump

@lachie83 ping

/assign @prydonius

bump

/lgtm


Add that B2B profiles should switch organization to update B2B registration information.

Hi All,
Could a short extract be added to the "Change the default method from My Profile" section to include details that a B2B user would need to switch organization from their my profile in order to change the security registration information for a 3rd party tenant?
Kind Regards
Donovan

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91ad4424-8d90-7947-2f95-aec67acfec45
Version Independent ID: 0ebfde0e-5597-fed9-f87c-761fd778fb25
Content: Combined registration for SSPR and Azure AD Multi-Factor Authentication - Azure Active Directory
Content Source: articles/active-directory/authentication/concept-registration-mfa-sspr-combined.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@Donovand4 Thank you for pointing this out. We will have this reviewed and update the document accordingly as needed after review.

@Donovand4 Thank you for pointing this out. We will have this reviewed and update the document accordingly as needed after review.

@Donovand4 Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.

@Donovand4 Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.

@Donovand4 Thanks for the suggestion and sorry for delay. This has been added. https://docs.microsoft.com/en-us/azure/active-directory/authentication/concept-registration-mfa-sspr-combined#switch-directory

#please-close


How to implement TemplatedAdorner

Due to this we can't use àdornedElementPlaceHolder as it assumes it is in a TemplatedAdorner which is internal.
This leaves us with a couple of options:
1 Use reflection to new up a TemplatedAdorner.
2 Implement our own TemplatedAdorner and AdornedElementPlaceholder
3 Something clever.
4 An entirely new API.
I wrote 2 to see how it looks:
<Button>
    <adorners:Info.Template>
        <ControlTemplate>
            <Border Margin="-1"
                    BorderBrush="Red"
                    BorderThickness="1">
                <adorners:AdornedElementPlaceholder />
            </Border>
        </ControlTemplate>
    </adorners:Info.Template>
</Button>

I don't like that the caller must know that adorners:AdornedElementPlaceholder  must be used, pit of failure.
Rewrote to use reflection now, not sure if it should be included.

Decided to go with reflection, nicer for caller.


Simple Cipher unit tests do not check for keys with non alphanumeric characters

I've just reviewed a submission for the Simple Cipher exercise where the student only checked for upper case letters and numbers in the key.  This was enough to pass the unit tests, but does not conform to the requirements that state "Let's make your substitution cipher a little more fault tolerant by ... ensuring that the key contains only lowercase letters".
The unit tests for this exercise will need to be updated to test for this scenario.

I realised that after I created this issue and have already opened one:
https://github.com/exercism/problem-specifications/issues/1298


direction vs. readingProgression

CC @jccr @HadrienGardeur
This issue is similar to spine vs. readingOrder.
In publication metadata, direction should be renamed to readingProgression:
https://github.com/readium/r2-shared-js/blob/70f65cb5834fa9f2d3497f532997269dad6a2951/src/models/metadata.ts#L108
( https://github.com/readium/r2-shared-js/blob/develop/src/models/metadata.ts#L108 )
JSON Schema:
https://github.com/readium/webpub-manifest/blob/d0b5694e662faf88262a3dc6a50ca32220fc825a/schema/metadata.schema.json#L120
( https://github.com/readium/webpub-manifest/blob/master/schema/metadata.schema.json#L120 )
Existing client implementations that parse the JSON property name directly (rather than using the in-memory data model) will need to update their code to support both the legacy direction term, as well as readingProgression (as we did when switching from spine to readingOrder).

Developer sticky note: the r2-navigator-js layout/rendering engine uses the already-parsed in-memory data model, does not access the JSON property directly (so no change required):
https://github.com/readium/r2-navigator-js/blob/develop/src/electron/renderer/index.ts

Done: https://github.com/readium/r2-shared-js/blob/b474cfc1c27ac8d280313a8e9357d7bcbf2ba869/src/models/metadata.ts#L205


task prompt function type does not contain previous prompt

I am trying to do a row of prompts and want one prompt to be skipped or of type text. The simplest solution for this is to use an if-statement with a previous prompt's response value, but the ctx does not contain the previous just the current prompt.
      ctx.version = await task.prompt([
        {
          type: 'select',
          name: 'version',
          message: 'New version',
          choices
        },
        {
          // prev contains only current prompt not from select version
          type: (prev) => (prev == 'custom' ? 'text' : null),
          name: 'version',
          message: 'Version',
          validate: validator,
        },
      ])

https://github.com/terkelg/prompts#-prompt-objects

Input module uses enquirer, which you can utilize its own options through seeing examples here, albeit not all the types might be correct for it since I had to rewrote them to utilize it.
If you want to utilize another package you have to utilize the stdout passthrough, although the example is for INK it should be very similar and I have checked that this module also can use { stdout } option to change the stdout which will pass through the internal stream through Listr since log-update takes full control of the process.stdout. You can set task.prompt = true and return any error as task.prompt = new PromptError('some string') to achieve a similar output style to the default.
You can see the inner workings of task.prompt here.
The prompts are intended to be single seperate tasks, since the output data control of them is a bit tricky with the given code-base.

I also noticed that it uses enquirer, thought I read prompts somewhere. Fixed that and split them into separate tasks which worked. No need to utilize another prompt package. Looking forwards for connected multi prompts in the future.

Hmm. I am sorry if i understand your question wrong. But it should in theory support all the functionality of enquirer eventhough the types might be wrong. So if using typescript you might need to add ts-ignore and i can fix the types on an open issue. I can also add this package later on and create a flag to select the prompt package since it also seems cool.
Hope you have fun with your project.


nixos/kubernetes: Update kube-dns and kube-dashbashboard docker image…

… derivations to new pullImage function signature
Motivation for this change
Hi,
I tried to run kubernetes on my nixos/unstable system.  Unfortunately nix refused to build kube-dns and kube-dashboard.  It looks like this is caused by a change in the function signature of pkgs/build-tools/docker/default.nix:pullImage.  This patch tries to fix that.
I tested the module on my local system, but unfortunately the nixos tests for kubernetes are not "working" for other reasons I do not understand quite right.  However, the build failure does not occur anymore with this patch and the problems arise for me at runtime and seem -- as far as I understand -- not related to the thing this patch tries fix.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg test kubernetes

Success on x86_64-linux
Attempted: tests.kubernetes
No partial log is available.

Success on aarch64-linux
Attempted: tests.kubernetes
No partial log is available.

Kubernetes tests are locally passing.
Thanks.


TrackPlayer.seekTo not working while player is paused

Describe the bug
In android, when im' using TrackPlayer.seekTo method, the player position is still in the old position and not the one i wanted to seek to.
To Reproduce
in android use seekTo method and while player is not playing.
Environment (please complete the following information):
Run react-native info in your project and share the content.
System:
OS: macOS 11.0.1
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 129.54 MB / 8.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.13.0 - /usr/local/bin/node
Yarn: 1.22.5 - /usr/local/bin/yarn
npm: 6.14.8 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK: Not Found
IDEs:
Android Studio: 4.1 AI-201.87<IP_ADDRESS>53283
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: 14.0.1 - /usr/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.3 => 0.63.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
What react-native-track-player version are you using? v1.2.6
Both. API 29
Code
  const {position} = useTrackPlayerProgress(500, [
    TrackPlayer.STATE_BUFFERING,
    TrackPlayer.STATE_NONE,
    TrackPlayer.STATE_PLAYING,
    TrackPlayer.STATE_PAUSED,
    TrackPlayer.STATE_READY,
    TrackPlayer.STATE_STOPPED,
  ]);

// run this method with some value
const onPlayerSeek = () => {
     console.log('position before seeking', position);
    TrackPlayer.seekTo(destination).then(() => {
// position is the same and not the destination - so seekTo didn't work
    console.log('position after seeking', position);
    );
}

Did you find any solution to this issue ?

What is solution?

Same issue, Kindly let me know if any solution to the problem. In pause mode, When trying to seekTo player state is getting changed to "Ready"


Rebuild and publish accounts-manager with seeded randomizer.

Artifacts updated: https://github.com/shimkiv/mina-accounts-manager/releases/tag/v0.1.1


Error on resuming training

when run trainer_stats = trainer.train(resume_from_checkpoint = True) get error
NameError                                 Traceback (most recent call last)
Cell In[2], line 1
----> 1 trainer_stats = trainer.train(resume_from_checkpoint = True)
NameError: name 'trainer' is not defined

Hey there did you check out documentation which might help? Especially the last section. https://docs.unsloth.ai/basics/finetuning-from-last-checkpoint

You need to also run the trainer = ... cell!


Near and rawfilters

This PR enables It also enable Geo filters and increases the level of abstraction used to represent the filter section at classes such as MongodbRdd and MongodbReader. Instead of just passing an Array[Filter], not a FilterSection instance is expected. This class might have many implementations which should be able to generate a DBObject representing the filter section through the filtersToDBObject method.
At this moment, three implementations of FilterSection are available:

SourceFilters which is the classic Array[Filter] filter section description
NoFilters which is equivalent to an empty SourceFilters instance.
RawFilter, allowing to provide a filter as you would if you were using the bare mongodb driver.

To complete the geo-near queries should be included nearSphere too.

@danfran They have been both added as well as a way of providing a DBObject as a filter description.

LGTM

:+1:


[hotfix][docs] Adding new sources on overview pages

What is the purpose of the change

Added Pulsar and Hybrid Source to overview page for DataStream API connectors
Reorder the listing on the overview to be in the same order as the connectors are in the left-hand menu

Brief change log

Added Pulsar and Hybrid Source to overview page for DataStream API connectors

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I will fix two issues and merge it:

missing zh version for hybridsource, which causes a build failure
will hide the streaming file sink from the menu in zh (it's done for en already)


New version spam

so much spam, one message is enough.

Can you tell me more about this issue? Like which version of the plugin and server you use, a plugin list, etc.?

V 2.4.2
Paper Version 1556

I don't see anything wrong with v2.4.2. If some plugin(s) trigger PlayerJoinEvent multiple times, I can't do anything.

No other plugins do this, as you can see multiple other plugins also say they have an update without issue.

Ok I found the bug, I'm gonna fix it today. Sorry for the inconvenience. :)


feat: allow login to non-db contracts

Before this commit, each time updateAccount was triggered the VM checked if the selector was connected - i.e. had an access key - to a contract different from SocialDB, and proceed to logout the user if that was the case.
This commit removes this constraint, allowing users to connect to both SocialDB and other contracts.

this PR solves issue #184

Don't remove the change, but make it configurable instead. This is desired behavior for a default gateways that only use it with a single contract

@evgenykuzyakov yes, that makes sense. I reverted my changed and added a check for a config flag.

changed the code based on @charleslavon request, now the initNear takes a allowExternalContract: <contractId>

I mean to update this PR, not dev. Will push another change shortly.

I meant to push to this pr, not merge to dev. I'll push another change shortly.

https://github.com/NearSocial/VM/pull/198


bug: notify dependency error

Did you check docs and existing issues?

[X] I have read all the noice.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0 Build type: Release LuaJIT 2.1.1720049189
Operating system/version
Darwin U-66MWY1J0-0106.local 23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:13:18 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T6030 arm64
Describe the bug
Highlight group 'NotifyBackground' has no background highlight
Please provide an RGB hex value or highlight group with a background value for 'background_colour' option.
This is the colour that will be used for 100% transparency.
require("notify").setup({
  background_colour = "#000000",
})

Defaulting to #000000
Steps To Reproduce
A error report if follows README's way to install with lazynvim
Expected Behavior
No such report
Repro
vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    { "folke/noice.nvim", opts = {} },
    -- add any other plugins here
  },
})

How is this a Noice/LazyVim issue?


Reducing Code Duplication

I noticed some code sections in src/pages/TopHome.jsx seem to be repeated.
I think we could create a separate component to handle this logic.
Could you please assign this issue to me under GSSOC 24.

To be more specific I want to turn the following code into a component

I wanted to kindly request an update on the progress of this issue. Your assistance is greatly appreciated.

hey @Abh-I-seK please assign this issue to me under GSSOC-2024

Hi @Abh-I-seK Thanks for your contributions.


Customization of Air Quality and CO2 Threshold

First of all, thank you for creating the plug-in!
Have been using it for almost a month now and I love it!
I would like to make a suggestion for a new feature.
It will be great if we can customize the air quality standards. for example, exclude humidity and temperature from the air quality score and only use PM2.5 and VOC like the US EPA standards.
Lastly, it will be great if we can customize the threshold for the CO2 sensor.
Thank you!

Custom CO2 threshold would be great.

Another vote for a custom CO2 threshold.  The number of Apple Home warnings we get for elevated CO2 readings from our AirThings is about to force me to remove it.  Thanks so much for a rock-solid plug-in!

I've made the CO2 sensor detection threshold configurable in v1.0.0 and made some improvements to the config screen. Please give it a spin!
Would like to brainstorm a bit how to make the air quality scores customizable. It could be quite simple to opt specific sensors in and out of the air quality scoring, but much more complex to configure custom values for each. Will leave this issue open to gather feedback..

Thanks a lot! Seems to be working wellfor me.
As for customizing the other sensors, do you mean notications for high VOC, PM2.5, etc?

This is a fantastic add to the plugin!  Thanks so much for prioritizing it!

I've made the CO2 sensor detection threshold configurable in v1.0.0 and made some improvements to the config screen. Please give it a spin!
Would like to brainstorm a bit how to make the air quality scores customizable. It could be quite simple to opt specific sensors in and out of the air quality scoring, but much more complex to configure custom values for each. Will leave this issue open to gather feedback..

Thank you so much for the update!
Regarding the air quality, I think the TVOC and PM2.5 value can be fetched and calculated and will result in: EXCELLENT-POOR.
Here's an example from another Homebridge plugin that calculates different scores.
https://github.com/DMBlakeley/homebridge-awair2/blob/fdb7d210a642bd9696f10bb0318ecb9c564aa32b/src/index.ts#LL1641C4-L1641C4

The Air Quality service exposed by the plugin today incorporates Radon, PM2.5, VOC, CO2, and Humidity sensors (depending on which are supported by your device) and generates an Excellent to Poor rating as described in the README (and at https://github.com/michaelahern/homebridge-airthings/blob/main/src/plugin.ts#L331). Is your ask to exclude specific sensors from Air Quality (e.g. Humidity) or configure custom Air Quality thresholds for each sensor (e.g. redefine Poor PM25 as say >= 75 μg/m³ instead of >= 25 μg/m³)?

Thanks for the respond!
Yes, It will be the first one, excluding specific sensors from the Air Quality.


can anyone pls help with this error?

  "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -IC:\Users\llpcx\AppData\Local\Temp\pip-install-nrfen3i0\detectron2_2c20f9532f7d4f15a2d3dfb350083550\detectron2\layers\csrc -IC:\Users\llpcx\anaconda3\Lib\site-packages\torch\include -IC:\Users\llpcx\anaconda3\Lib\site-packages\torch\include\torch\csrc\api\include -IC:\Users\llpcx\anaconda3\Lib\site-packages\torch\include\TH -IC:\Users\llpcx\anaconda3\Lib\site-packages\torch\include\THC -IC:\Users\llpcx\anaconda3\include -IC:\Users\llpcx\anaconda3\Include "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\ATLMFC\include" "-IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /EHsc /TpC:\Users\llpcx\AppData\Local\Temp\pip-install-nrfen3i0\detectron2_2c20f9532f7d4f15a2d3dfb350083550\detectron2\layers\csrc\ROIAlignRotated\ROIAlignRotated_cpu.cpp /Fobuild\temp.win-amd64-cpython-311\Release\Users\llpcx\AppData\Local\Temp\pip-install-nrfen3i0\detectron2_2c20f9532f7d4f15a2d3dfb350083550\detectron2\layers\csrc\ROIAlignRotated\ROIAlignRotated_cpu.obj /MD /wd4819 /wd4251 /wd4244 /wd4267 /wd4275 /wd4018 /wd4190 /wd4624 /wd4067 /wd4068 /EHsc -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=_C -D_GLIBCXX_USE_CXX11_ABI=0 /std:c++17
  ROIAlignRotated_cpu.cpp
  C:\Users\llpcx\AppData\Local\Temp\pip-install-nrfen3i0\detectron2_2c20f9532f7d4f15a2d3dfb350083550\detectron2\layers\csrc\ROIAlignRotated\ROIAlignRotated_cpu.cpp : fatal error C1083: 无法打开编译器生成的文件: “”: Invalid argument
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.38.33130\\bin\\HostX86\\x64\\cl.exe' failed with exit code 1
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for detectron2
Running setup.py clean for detectron2
Successfully built detectron2-densepose
Failed to build detectron2
ERROR: Could not build wheels for detectron2, which is required to install pyproject.toml-based projects

Hello @xiohulp ,
Have you cloned the Detectron repository as it is shown in the third step of the installation process?
Please let me know. Any further details will be highly appreciated to help you solve this issue.