Update sbt-scoverage to 2.0.7

Updates org.scoverage:sbt-scoverage from 1.9.3 to 2.0.7.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scoverage", artifactId = "sbt-scoverage" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-major, commit-count:1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 4 files lost coverage.
Overall coverage increased (+1.4%) to 69.091%

Files with Coverage Reduction
New Missed Lines
%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/AsyncHandlerMap.scala
1
87.5%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/AsyncMap.scala
1
83.33%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentialMap.scala
1
95.65%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyAsync.scala
2
77.78%

Totals

Change from base Build<PHONE_NUMBER>:
1.4%

Covered Lines:
114

Relevant Lines:
165

💛  - Coveralls

Superseded by #128.


Better colour definitions in settings

Right now, colours have to be defined in settings as strings from the current colour scheme.
Allowing hex (or rgb?) would be far superior, but would require the dynamic creation of colour strings.
ColorHighlighter and GutterColor seem to be doing this somehow already.

Done!


Build of Win7 fails because it's unable to build .NET assemblies

Using trial WIn7 image and enabled windows updates.   Initial provisioning runs fine and SSH is enabled. But script compile-dot-net-assemblies.bat fails with the following error
    vmware-iso: Microsoft (R) CLR Native Image Generator - Version 4.0.30319.1
    vmware-iso: Copyright (c) Microsoft Corporation.  All rights reserved.
    vmware-iso: Uninstalling assembly Microsoft.CSharp, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly PresentationCore, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly PresentationFramework, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly PresentationFramework.Aero, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly PresentationFramework.Classic, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly PresentationFramework.Luna, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly PresentationFramework.Royale, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.ComponentModel.Composition, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Data, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Data.Linq, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Drawing, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Dynamic, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Windows.Forms, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly System.Xml, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly WindowsBase, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35 because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly Accessibility, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly c:\Windows\Microsoft.NET\Framework\v4.0.30319\dfsvc.exe because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly c:\Windows\Microsoft.NET\Framework\v4.0.30319\SMSvcHost.exe because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).
    vmware-iso: Uninstalling assembly CustomMarshalers, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a because of an error during compilation: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED)).

```

I am getting same error while building win2008r2 image

Likewise,  I removed that script from the setup and instead opted to add Boxstarter which will install .NET 4.5.  This has the added benefit of allowing for the installation of nuget.commandline which requires 4.5+

and also the same for me

Related to #161

I put in a workaround so at least if the ngen compilation fails the box build continues on. See #199.


[BUG] Y-Values clipped to Y-Max

Describe the bug
I'm playing around with the WASM example. I noticed Y values get clipped to the maximum of the Y-Axis once they exceed it. I would expect the values to just not be visible any more and the line being cut off at some point.

To Reproduce
let backend = CanvasBackend::new("canvas").unwrap();
let root = backend.into_drawing_area();

root.fill(&WHITE).unwrap();

let mut chart = ChartBuilder::on(&root)
    .set_left_and_bottom_label_area_size(30)
    .margin(10)
    .build_ranged(0.0..2.0, 0.0..3.0)
    .unwrap();

chart
    .configure_mesh()
    .x_labels(3)
    .y_labels(2)
    .draw()
    .unwrap();

let data = (0..=20)
    .map(|x| x as f64 / 10.0)
    .map(|x| (x, x.powf(2.0) + 1.0));

chart.draw_series(
    AreaSeries::new(
        data.clone(),
        0.0,
        &RED.mix(0.2),
    )
    .border_style(&RED),
).unwrap();

chart.draw_series(
    data
        .map(|(x, y)| Circle::new((x, y), 3, BLUE.filled())),
).unwrap();

root.present().unwrap();

Version Information
plotters = "0.2"

Hi there, thanks for reporting this. Closing the issue since it seems dup to #120.


About speed of distributed learning with resnet50_trainer.py

Hello. I read a paper about caffe2 distributed learning a few weeks ago.
(Accurate, Large Minibatch SGD: Training ImageNet in 1 Hour)
I tried to run distributed, multi GPU leaning through the resnet50_trainer.py (with 2~3 computers).
But it doesn't faster than single machine, multi GPU learning.
So I just wonder whether resnet50_trainer.py uses exactly same way that the paper "Accurate, Large Minibatch SGD: Training ImageNet in 1 Hour" used or not.
If yes, I would like to know is there a something wrong such as missed flags or wrong installation that reduce learning speed and what is it.

Hello, could you post your hardware specifications and the input parameters you used to run the trainer?

I don't know the exact, detailed hardware specifications since some reason but it is fast enough.
I run with two machines with 4 GTX 1080Ti for each machine.
Training data was CIFAR-10 and single machine 8 GPUs learning processed around (1200images/sec) but 2 machine distributed learning, which has 4 GPUs for each machine, processed around (130images/sec)
**input parameters : **
(1st machine)
resnet50_trainer.py --train_data /PATH/OF/TRAINING/DATA --gpus 0,1,2,3 --batch_size 128 --num_labels 10 --epoch_size 50000 --num_epochs 10 --num_shards 2 --shard_id 0 --run_id 1234 --redis_host REDIS.SERVER.IP.ADDRESS
(2nd machine)
resnet50_trainer.py --train_data** /PATH/OF/TRAINING/DATA --gpus 0,1,2,3 --batch_size 128 --num_labels 10 --epoch_size 50000 --num_epochs 10 --num_shards 2 --shard_id 1 --run_id 1234 --redis_host REDIS.SERVER.IP.ADDRESS

So, with a single 8 GPU machine you were getting 1200 img/s, but with two 4 GPU machines you get 130 img/s (9x worse)? What is the performance running on a single 4 GPU node.
Can you run iperf3 between the two nodes and report the observed bandwidth? Also, default concurrency settings were recently updated, so you may want to pull the latest changes and retry.

@ing907  hello, I want to  use caffe2 distribute train about the example for resnet50_trainer.py,but could run for the reason that  Operator 'RedusStoreHandlerCreate' seems not registered. thank you so much for you help.

I should change network environment in this weekend and then try it again.
I will let you know after all job is finished. Thank you for your attention.

@ing907 hello,can you leave you email for  contacting, I have got some problem in  distributed learning,and you should have been met. thank you so much.

@leye7755<EMAIL_ADDRESS>

@ing907 @leye7755 Have you figured out the reason of the slow performance? I also observed similar behavior. I got ~700 images/sec within 1 node with has 4 GPUs, but with 2 nodes, the speed is only 250 images/sec per node. I noticed all the data went through Ethernet interface although my nodes are connected with 100Gbps Infiniband. I tried to compile Caffe2 with -DUSE_IBVERBS_DEFAULT=ON, but still no success.

@hfutxrg @wesolwsk I tested resnet50_trainer with 2 machines connected with 100Gbps Infiniband. but there was still slow performance. Could you guys solve this problem or does it not use the same method that paper used?

Is the problem identified or solved?

@llhe Unfortunately, No.

I made a test which which can achieve 7+ speedup compared to 1 GPU(M40), here is the result:
1 host, 1 gpu     (batch size = 32):       91 images/sec
1 host, 4 gpu     (batch size = 128):     340 images/sec
2 host, 4*2 gpu  (batch size = 128*2):   330*2 images/sec

Plain 10Gbps eithernet is used and the occupied bandwidth is around 2Gbps.
The binary we use is compiled with redis enabled from souce with commit: b6f29a96a6c7978b00f2c2e09f4bd67e357dee2e

@ing907 @hfutxrg Seems that Caffe2 chooses the network adapter based on the output of Linux's "hostname" command, which could be the management network in a Infiniband-based cluster environment. https://github.com/facebookincubator/gloo/issues/70 added a new function that will allow you to choose network interface. I modified caffe2/caffe2/contrib/gloo/common_world_ops_gpu.cc and common_world_ops.cc by adding "attr.iface="ib0";" after "::gloo::transport::tcp::attr attr;" This will allow Caffe2 to use IPoIB for the communication. (I do a ifconfig to figure out the name of the IB interface I want to use).

@powerreactor @ing907 I have already been able to scale Caffe2 across 4 nodes. With 16 GPUs across 4 nodes, I got 12.5x speedup which is pretty good. But that was still using IPoIB instead of IBverbs library. There is still bug in Caffe2 of using IBverbs library https://github.com/caffe2/caffe2/issues/616. It would be better if that bug is fixed.

Using IB and GPUDirect is possible without having to modify the Gloo bindings since last month.
Also see my comment on #616.
If there is a more specific issue still pending, please feel free to open a new issue.


query points on point clouds

Dear Philip,
Thanks for providing the code for this super interesting paper.
I have read all of the paper and still, one question has remained for me: When using pre-trained models for just inference (mesh reconstruction) out of point clouds, how the query points are defined from the point clouds?
In the paper, it is mentioned that query points are defined by randomly sampling 1000 points on the surface and offset them in the normal direction. However, in the case of using just point clouds for the reconstruction once the model is trained, there would be no surface to sample query points from them, I wonder how these are defined in this case.
Thank you in advance.

Hi @srasoulzadeh,

In the paper, it is mentioned that query points are defined by randomly sampling 1000 points on the surface and offset them in the normal direction. However, in the case of using just point clouds for the reconstruction once the model is trained, there would be no surface to sample query points from them, I wonder how these are defined in this case.

You're right, there is no surface to sample for inference. I don't remember exactly where this is in the paper but it must belong to the training set generation.
For inference, we take all voxels that are within epsilon distance from any point of the point cloud as query points. For "eval_p2s_max.sh" e.g., this parameter is set to 3. This means that areas in scan shadows are ignored and filled it (likely with errors) by the sign propagation. Also, noisy point clouds may require many more network evaluations than noise-free point clouds.
Does this answer your question?

Thank you very much for the quick response.
Of course, now I got the point that how are they defined.
By the way, I am experimenting with some point clouds obtained through sketching in a 3D environment.
In some cases, it works perfectly fine (SAMPLE WALL Num. 1) while in some another it drastically fails (SAMPLE WALL Num. 2). Might it be because of the fact that sketches produce very noisy point clouds? and due to that, might it require some more parameter modifications?
Attached, I provided the screenshots from Blender visualizing the input point cloud and respective reconstructed mesh as output.
SAMPLE WALL 1 IMAGES
SAMPLE WALL #1 POINT CLOUD
SAMPLE WALL #1 RECONSTRUCTED MESH
SAMPLE WALL 2 IMAGES
SAMPLE WALL #2 POINT CLOUD
SAMPLE WALL #2 RECONSTRUCTED MESH

Yes, you the holes in the scans may produce some errors. But the main problem with your examples is that they don't have a thickness (as far as I can see). The underlying geometry representation of P2S is an SDF, which enforces solid objects. P2S is also trained on solid (mostly single) objects. To get more reasonable results, you would need to to "simulate" a solid object. I don't know if this is applicable in your case. Maybe, you could extrude the sketches somehow to get at least a front and back side?

You are right, this is exactly the case.
For instance, the SAMPLE WALL Num. 1 has a small amount of thickness and the output is perfectly acceptable, but in SAMPLE WALL Num. 2 it has no thickness, and also in my other examples that there exist no thickness the algorithm fails.
This was a very important notice. I try the extrusion and see what the results would be.
Thank you very much @ErlerPhilipp for your responses.


Fixes #268

Only fires :long_press action once.

I guess the next question here is... should we fire it once on UIGestureRecognizerStateBegan or UIGestureRecognizerStateEnded?
Currently, the long press won't fire until you press for more than a second and then let go. I've seen plenty of implementations where (and I actually think this makes more sense) the event fires after the long press is detected and you don't have to raise your finger from the screen.
Thoughts, @squidpunch or @twerth? Eh, what the hell... you can chime in too, @GantMan :grin:

Well... i just found an unwanted side effect of using return if @sdk_event_or_recognizer == VIEW_GESTURES[:long_press] && gesture.state == UIGestureRecognizerStateEnded and that is if you start a long press and then move your finger OFF the target, the long press will fire.
I'm going to change it to UIGestureRecognizerStateBegan. Let me know if anyone has any input.

I agree with using began.

sounds good to me, I think if I am implementing something with long press - I'd want it to start after holding it down, not waiting until I lift just my 2 :moneybag:

Merging based on :+1: feedback.


District Name output broken in non-English language

Well, to be honest i don't know if it works in English / French / Japanese, i've only tested in German, but the district name output is definitely broken for German client language. Here's the output for the normal Simple and the Ping styles:

For reference, here's what all the custom tags produce for that sweep:

Interesting - I think I know the cause of this but can't test German right now. I've attached the potential fix here if you'd like to test it (unzip and drop the dll in devPlugins in your XIVLauncher directory).
v<IP_ADDRESS>.zip

I tested the version you posted here and at least in the Goblet (where i tested before), it works now:

I haven't found any open houses in any of the other wards, so i can't tell if it works for the others, or if names with spaces work correctly.

Correction: I did actually find a small house in Mist ("Dorf des Nebels") just now, and district name with and without spaces displays correctly, so there's probably no issues left.

Great, thanks for testing!


Player can access jobs without permission

First of all, sorry for my English.
Hello, I am using your plugin. When I put this plugin in my server. Everything is working fine but the player can access /jobs join. I didn't set any permission to them. Is there any way to not allow it? I would like to let the player register their jobs by sign only. Thank you =>

jobs.command.join (For /jobs join command)
jobs.join.[jobName] (To disable the specified job to join)

Hello, I understand but I didn't give them a permission yet and they can use /jobs join.

Do they have any * permissions, granting them access to everything, or are they perhaps operators?

No, they don't. They have some common permission ex./home /sethome /spawn /pcst. But they don't have any permission about jobs plugin. Another plugins are fine.
The plugin that I am using for permission is  (group manager plugin)


Support for add_tags action in EMR

The "add_tags" method of EmrConnection in boto is not supported in moto, and is desired.

I've added some basic tag logic (and some additional cluster endpoints) with https://github.com/spulec/moto/commit/95b1fa42b27f747f0b25bcc9cebb40ce26e9bbe5. Feel free to reopen if there are additional endpoints you are looking for.

Thanks for the fast turnaround, this works in 0.4.1 version.


[BUG] SED-ML files do not simulate all SBML files

Example: https://github.com/virtualcell/vcdb/blob/main/published/biomodel/omex/sbml/biomodel_12119723.omex
The archive has 6 SBML files, but the SED-ML only simulates 3. The native version, only has one VCML model. Taken together, this seems likely to be a bug.
This may be intentional. I'm raising this in case this isn't intentional.

This is intentional - for now,  On export we do create all SBML translations of the model(s) encoded in VCML but we do not currently create simulations/tasks for simulations that currently do not have saved simulation results in the VCDB database.
This can result in OMEX files with "unused" models.  In the future, we may either remove these models or add simulations based on manual inspection of their use in publication.


Implemented transform-regexp-constructors plugin

Changes RegExp constructors to literals.

Updated. Also, for RegExp constructors with 0 arguments, this would currently throw at const pattern = evals[0].value;. Catching this case at pseudo-compile time is not terrible, but should this behavior be changed/documented?

Yeah, let's definitely add a check for 0 arguments. It should transform to /(?:)/ (empty non-capturing group). Also, I would rename evals to evaluatedArgs for clarity.

Updated to gracefully handle empty RegExp constructions.

Thanks!

@hzoo @loganfsmyth @danez do we want to also update babili preset?

yeah if want to add it now - we'll need the package.json for this package + adding it to the preset package.json if we do

@shinew Let's do it. That way we could also see the impact of this plugin on performance with our benchmark.


Don't manually override filename

Overriding user settings is a very bad idea. If someone prepends the filename with a slash, this is usually with right cause. This causes unpredictable behaviour within Webpack. Especially other plugins depending on the asset list like AppCacheWebpackPlugin will trip on this.
Because of this we had the following bug in our appcache.manifest:
CACHE MANIFEST
# a5ccd581f3cef1493d76

/statics/browser-compatibility.js
/statics/password-strength-utils.js
/statics/site.js
/statics/browser-compatibility.css
/statics/site.css
statics/service-worker.js

NETWORK:
*

Notice the missing slash in front of statics/service-worker.js.

Workaround is adding another slash in front...

Thanks for this PR, I agree, that sounds like a good idea. I'm gonna make some tests, I don't want to introduce any regression.

@guidobouman Thanks


IAM: fix missing prompt, causing code to not be selectable

fixes https://github.com/docker/docker.github.io/issues/14332
This code-block uses the "console" highlighting, which considers lines that do
not start with a prompt to be "output" of the command, and non-selectable.
With this, the blocks are now copy/paste-able:

@jerae-duffin PTAL


convert tabs to spaces

Hey e-andrew, dude thank you so much for bringing this up!
This issue has been eating at me for awhile now!
I would like to do some research around spacing considerations before pulling this in.
Do you happen to know any good articles or best practices you could recommend?

Still have this one on the ole todo list - sorry for the delay

Oh, sorry. A big part of files has spaces instead tabs (in your project), thats why I converted tabs to spaces in all remaining files.
(Sorry for english)

Thanks again e-andrew!


Add the remaining general Cairo.Context bindings

This is a followup to #624 and adds the remaining bindings from https://cairographics.org/manual/cairo-cairo-t.html.
The one exception is cairo_copy_clip_rectangle_list(), which probably needs some special wrapping since cairo_rectangle_list_t isn't very friendly to expose directly in C#

Thank you very much :+1:


3D Tiles Inspector

This will allow us to remove a lot of prototype and duplicate code in Sandcastle examples, and will allow users to embed the inspector in their apps for easily debugging and profiling.
The UI design is open-ended; feel free to make it much better than the collection of buttons in the Sandcastle examples.
Phase one is to just replace the debugging functionality already in the Sandcastle examples; we can do more pull requests as new features are needed.  Do not worry about the current style options in the Sandcastle examples for the first pull request.

[ ] Features based on the debug options in the Sandcastle example: http://localhost:8080/Apps/Sandcastle/index.html?src=3D Tiles.html&label=Showcases

[ ] Show stats and Show pick stats.  These could be shown in the inspector UI instead of the console.  Keep the separation of the inspector and the 3D Tiles rendering clean; the inspector would just pull the fields from Cesium3DTileset.
[ ] Freeze frame
[ ] Colorize
[ ] Show bounding volumes, Show contents, and Show request volume
[ ] Change SSE - have a slider and be able to set an explicit value
[ ] Enable Dynamic SSE

[ ] Change density and factor - similiar to SSE above

[ ] Trim tiles cache
[ ] Enable picking

[ ] New features

[ ] Be able to pragmatically pass a tileset to the inspector
[ ] Be able to click on a tileset (when the inspector is open) to inspect it
[ ] Performance Display - just like the Cesium Inspector (for convenience)
[ ] Show Wireframe
[ ] Ignore batch table - should force a tileset reload
[ ] Show the url of a clicked tile

[ ] Remove similar code in the 3D Tiles Sandcastle examples (in the 3d-tiles branch and branches off of 3d-tiles) and instead add the 3D Tiles Inspector.

For @austinEng when ready.

Show stats and Show pick stats. These could be shown in the inspector UI instead of the console.

Does this mean to entirely remove console logging or to just show the information in the inspector as well? Logging of the stats is implemented within Cesium3DTileset and removing it would involve disabling the debug flags for statistics. We can still pull the statistics from the tileset as you said, but would doing so without debug flags be inconsistent?

I think we can just remove debugShowStatistics and debugShowPickStatistics, expose a @private getter for _statistics, and then basically move the showStats logic to the inspector.
See how it feels.


Updated Requirements.yaml for Helm 3 install

New Releases of each have been updated. Helm installs should now work without complaint.
Note: DefectDojo is now on Python3.5 and Django 2.2.x Please submit your pull requests to the 'dev' branch as the 'legacy-python2.7' branch is only for bug fixes. Any new features submitted to the legacy branch will be ignored and closed.
When submitting a pull request, please make sure you have completed the following checklist:

[ ] Your code is flake8 compliant
[ ] Your code is python 3.5 compliant (specific python >=3.6 syntax is currently not accepted)
[ ] If this is a new feature and not a bug fix, you've included the proper documentation in the ReadTheDocs documentation folder. https://github.com/DefectDojo/Documentation/tree/master/docs or provide feature documentation in the PR.
[ ] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[ ] Add applicable tests to the unit tests.
[ ] Add the proper label to categorize your PR

Current accepted labels for PRs:

Import Scans (for new scanners/importers)
enhancement
feature
bugfix
maintenance (a.k.a chores)
dependencies

@zlmitche Could you make this PR go against dev so we can include it in the RC that goes out this week? Thanks for contributing.


TypeError: Cannot read property 'push' of undefined

Hy
Since 3 days, this error all the time
i can't see from which adapter
is there any hint's?
thanks
pat

Hi. I need more informations: Which version did you install? Operating system? Admin version? JS controller version?

Sorry, i'm new...
Version: 1.4.3
Linux
Admin: 3.6.7
JS: 10.16.3
thanks
pat


UNO: Fix Parameter

this reverted back to the original problem

@Eelektross no it didn't I havent updated the server yet.

Yeah sorry about that lol


Comfyui/auto1111?

Is this available on open source SD UIs?

looks like models are here
https://huggingface.co/zhyever/PatchFusion/tree/main
only for 1.5

but I think one may just use the model itself to get a depth map which is good


Icon in programs panel doesn't show NEM icon in Windows 8.1

I'm using the installer on windows 8.1.  I think I should be able to see the icon in the program menu but instead I get a generic icon.
https://www.dropbox.com/s/rlg3616bjxei2hq/NEM icon.png?dl=0

does this happen with latest installer?


Switch to @memrise/lqip

Fix for https://github.com/cyrilwanner/next-optimized-images/issues/192
Our team was receiving a dependency security advisory for url-regex, required by the dependency chain: lqip-loader → lqip → jimp → url-regex. Although jimp no longer depends on url-regex, lqip was using an older version of jimp which did.
There are two ways I think this issue can be fixed and I've taken steps along both paths.
My preferred route is to upgrade jimp in lqip, then upgrade lqip-loader and we're done. I've made a PR to lqip to upgrade jimp here.
However, since lqip and lqip-loader no longer appear to be supported, I've also forked each of these repos to @memrise (https://github.com/Memrise/lqip-loader and https://github.com/Memrise/lqip) and made this PR to use @memrise/lqip-loader instead of lqip. This is a little more awkward and I'm not 100% confident in my changes but it is a good backup fix.

Codecov Report

Merging #193 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   88.42%   88.42%
=======================================
  Files          13       13
  Lines         190      190
  Branches       46       46
=======================================
  Hits          168      168
  Misses         16       16
  Partials        6        6

Impacted Files
Coverage Δ

lib/resource-queries.js
100.00% <ø> (ø)

lib/loaders/img-loader.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe31e5c...a7dc15e. Read the comment docs.

Closing after response here: https://github.com/cyrilwanner/next-optimized-images/issues/192#issuecomment-677720778


[Kernel] Expand FP8 support to Ampere GPUs using FP8 Marlin

This work expands FP8 support in vLLM from GPUs with hardware FP8 support (Hopper and Ada Lovelace) to GPUs without native support (currently Ampere) by introducing FP8 Marlin - a fast fused dequantization kernel for FP8 to BF16/FP16 conversion.
Key features:

Enables FP8 quantization on a wider range of GPUs (SM 8.0 and 8.7, Ampere)
Improves performance up to 2x in memory-bound scenarios
Maintains accuracy comparable to FP16 baselines
Reduces weight memory usage by 2x, allowing larger batches
Simple to use - just specify quantization="fp8" at runtime or use pre-quantized FP8 checkpoints

Implementation details:

Based on existing 8-bit integer support in GPTQ Marlin kernel
Packs FP8 weights into int32 doublewords (GPTQ format) and then permutes weights into Marlin format
Efficient 4xFP8 to 4xFP16/BF16 dequantization using bit arithmetic and SIMT operations

End-to-end performance and accuracy results:

Individual layer sweeps:

As shown in the graphs, FP8 Marlin can provide significant speedups with minimal accuracy impact. Performance gains are higher on GPUs with less memory bandwidth (A10, RTX 3090) and for larger models.
Notes:

This weight-only approach differs slightly from the existing W8A8 FP8 quantization, offering higher accuracy because the activations have no need to be quantized
Currently expanding scales to be channelwise; future work will revert to per-tensor scales
This does not include support for MoE models.

Testing:

Tested on H100, A100, and A10 GPUs

This enhancement enables more users to benefit from FP8 quantization without hardware restrictions, improving vLLM's performance and efficiency across a broader range of setups!

This is an awesome feature!

@mgoin awesome feature! I suppose that the perf benchmark was run with cuda graph enabled? Out of curiosity, did you run it without cuda graph?
As this kernel has been integrated in TGI as well, it appears having CUDA graph enabled is rather critical so as to get speedups in the decoding (which I don't really explain to myself). In the prefill, as cuda graphs are never used for long enough seqlens, I do get a slight slowdown.

I did not benchmark on vllm, but I suppose the trend is similar.

Glad you're enjoying it @fxmarty. Thanks for sharing your analysis. My end-to-end benchmarks were all done with cuda graphs enabled. I'm curious, have you seen the same difference for marlin int8 or int4? Aside from this, I think there could be additional tuning for A100 problem shapes.

Hello, I noticed that you used the dequant_8bit function to dequantize FP8 data to FP16 data, but I'm not clear on the underlying principle. Could you please also provide the code for quantizing FP16 to FP8? Thanks.

Hello, I noticed that you used the dequant_8bit function to dequantize FP8 data to FP16 data, but I'm not clear on the underlying principle. Could you please also provide the code for quantizing FP16 to FP8? Thanks.

https://github.com/vllm-project/vllm/blob/2b0879bfc273a08d339b952890c4e88e77f0a014/csrc/quantization/fp8/fp8_marlin.cu#L164
https://github.com/IST-DASLab/marlin/blob/1f25790bdd49fba53106164a24666dade68d7c90/marlin/marlin_cuda_kernel.cu#L131
https://github.com/NVIDIA/FasterTransformer/blob/main/src/fastertransformer/cutlass_extensions/include/cutlass_extensions/interleaved_numeric_conversion.h


Support other SQL DB implementations (MySQL)

sutrc currently can use only SQLite as database backend. For some reasons... We want to support more advanced SQL engines.

[ ] Use only standard SQL syntax
[x] Don't rely on non-standard extensions
[x] Build sutserver with MySQL driver
[x] Build/test filedrop with MySQL driver.

filedrop used internally is generally not tied to SQLite that much but it still needs some changes thus:
Depends on https://github.com/foxcpp/filedrop/issues/2.

I guess it should work fine.


[#3401] Modified actor-features.hbs input node for item-detail

Added min, max, inputmode, and pattern attributes that were used on other item-details on the v1 sheets to the input for actor features. It appears that the inputmode="numeric" is used to bind the _onChangeInputDelta event.
Closes #3401

@Fyorl Ah, I did miss that. It looks like we have two _onChangeInputDelta()s one in inventory.mjs that requires inputmode="numeric" and one in sheet-mixin.mjs that requires type="text" and data-dtype="Number". The latter was not complete and would parse the input delta but not apply it. It also looks like we use inventory.mjs version most other places in the v1 sheets and both in the v2 sheets. I pushed a change to revert the changes from actor-features.hbs and add the update to sheet-mixin.mjs _onChangeInputDelta().


Endpoint to populate airtable with data from the FE 'Team Treehouse Licenses' form

Feature
Why is this feature being added?
The FE will be creating a form around Team Treehouse Licenses.  This form will only be accessible to ID.me verified users.  This data needs to ultimately be populated in Airtable in a new airtable.
Associated Issue
https://github.com/OperationCode/operationcode_frontend/issues/890
What should your feature do?

[ ] create a new airtable in Airtable for the data (@hpjaj will take care of this)
[ ] create a POST endpoint that hits Airtables API and populates the new airtable with the passed data
[ ] validation that the passed user is verified
[ ] test coverage
[ ] updates our API docs
[ ] collaboration with the FE team on the endpoint's schema (i.e. what they are sending to the BE)

@kylemh !
Can you please describe:

Precisely what data this FE form will be passing to the BE
If that data will/will not be a 1:1 mapping to columns in an Airtable airtable?
Anything else that I am missing in the description re: acceptance criteria for the FE

Instead of making this just about Tree House licenses, perhaps it could be our scholarship application page? I envision a drop-down representing all the available scholarships/resources one can sign up with.
Regardless, our prior discussion was relating to administrative tools, so this would be slightly different. Luckily, whatever we do here can be used there.
I presume the following data will get sent to the back-end from such a form:
Name (String)
Branch (String or Number - your choice)
Anything else would be up to @AshTemp

Instead of making this just about Tree House licenses, perhaps it could be our scholarship application page? I envision a drop-down representing all the available scholarships/resources one can sign up with.
Regardless, our prior discussion was relating to administrative tools, so this would be slightly different. Luckily, whatever we do here can be used there.
I presume the following data will get sent to the back-end from such a form:
Name (String)
Branch (String or Number - your choice)
Anything else would be up to @AshTemp

Treehouse is the only scholarship we have right now....The idea is good tho.
Sent from my iPad

On Apr 1, 2018, at 12:52 AM, Kyle Holmberg<EMAIL_ADDRESS>wrote:
Instead of making this just about Tree House licenses, perhaps it could be our scholarship application page? I envision a drop-down representing all the available scholarships/resources one can sign up with.
Regardless, our prior discussion was relating to administrative tools, so this would be slightly different. Luckily, whatever we do here can be used there.
I presume the following data will get sent to the back-end from such a form:
Name (String)
Branch (String or Number - your choice)
Anything else would be up to @AshTemp
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@kylemh - You're right, I did use the admin dashboard as the example, but actually I was more broadly thinking exactly this.  Forms & tables, with varied access.  Be that access "admin" access, or "verified user" access, or "board member" access...whatever we choose.  We can create any roles we choose.
But for this example let's say it is for ID.me verified users.

These verified users can access this form on the frontend
When they submit the form, the changes are saved to our db (not Airtable)
The FE has a table that displays the data from the db, that only user's with xyz permissions can see.  And we can set that level of access to whatever we choose.

I think we should go this route for all the benefits I mentioned in my thoughts around forms & tables for software devs.
I also think that since we have this as an option, I would prefer spending our time and resources on investing in and building out our application, versus deepening our dependency on a third party service such as Airtable.
You down?

Whoa, wait a minute. We are using airtable for a multitude of reasons. The big ones being the mentors can publicly see who still needs a mentor. Others include the fact that the bot can not only read the requests but also write to the table to include who is mentoring an individual. So unless you’re going to also include Allen in this discussion to find out what needs to happen so that the bot still works don’t make too many plans to not use airtable. We’ve already automated a huge part of requesting and fulfilling a mentor, let’s not go backwards.
Sent from my iPad

On Apr 1, 2018, at 12:00 PM, Harry Levine<EMAIL_ADDRESS>wrote:
@kylemh - You're right, I did use the admin dashboard as the example, but actually I was more broadly thinking exactly this. Forms & tables, with varied access. Be that access "admin" access, or "verified user" access, or "board member" access...whatever we choose. We can create any roles we choose.
But for this example let's say it is for ID.me verified users.
These verified users can access this form on the frontend
When they submit the form, the changes are saved to our db (not Airtable)
The FE has a table that displays the data from the db, that only user's with xyz permissions can see. And we can set that level of access to whatever we choose.
I think we should go this route for all the benefits I mentioned in my thoughts around forms & tables for software devs.
I also think that since we have this as an option, I would prefer spending our time and resources on investing in and building out our application, versus deepening our dependency on a third party service such as Airtable.
You down?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Right, this is not for mentors or the mentor process.  This is for Team Treehouse (or scholarship applications).

Oh, would still need a quick searchable way to find that and teamtree house is basically going to be a spreadsheet so airtable is perfect for that.
Sent from my iPad

On Apr 1, 2018, at 2:26 PM, Harry Levine<EMAIL_ADDRESS>wrote:
Right, this is not for mentors or the mentor process. This is for Team Treehouse (or scholarship applications).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Airtable is one option.  What I am describing accomplishes the same end goal, with many additional benefits.

Before we make big changes you need to talk with Nell.
Sent from my iPad

On Apr 1, 2018, at 2:35 PM, Harry Levine<EMAIL_ADDRESS>wrote:
Airtable is one option. What I am describing accomplishes the same end goal, with many additional benefits.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Agreed!  @nellshamrell was part of my original discussion on the topic.
I just implemented the concept of "roles" in PR https://github.com/OperationCode/operationcode_backend/pull/290.  This, in conjunction with Pundit, provides varied access to forms, links, tables, etc.
But for sure, @nellshamrell can you pls share your thoughts?

Reading through the backscroll now :)

Here are my thoughts:
I think everyone (including me) is in agreement that the mentorship process should stay in Airtable.
What I'm hearing here, though, is that we'd like to use our own database to track scholarship information (starting with Tree House).  I believe this would not alter any current behavior - this is entirely new behavior.  Is this correct?  Or do we currently track scholarship information in Airtable (I know we did at one point, I don't know if we do now)?
If we do not, then I think we should go forward with the plan to have it in our own database.  The reason is I think this will provide more learning opportunities for new developers to our open source projects - creating forms and views that create, display, and manipulate data is a great beginning coding project.

I am tracking exactly 1 entry in airtable at the moment, the other
scholarship stuff I'm handling in Google forms so nothing will be affected.
On Fri, May 11, 2018 at 10:07 PM Nell Shamrell-Harrington <
<EMAIL_ADDRESS>wrote:

Here are my thoughts:
I think everyone (including me) is in agreement that the mentorship
process should stay in Airtable.
What I'm hearing here, though, is that we'd like to use our own database
to track scholarship information (starting with Tree House). I believe this
would not alter any current behavior - this is entirely new behavior. Is
this correct? Or do we currently track scholarship information in Airtable
(I know we did at one point, I don't know if we do now)?
If we do not, then I think we should go forward with the plan to have it
in our own database. The reason is I think this will provide more learning
opportunities for new developers to our open source projects - creating
forms and views that create, display, and manipulate data is a great
beginning coding project.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OperationCode/operationcode_backend/issues/288#issuecomment-388522870,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS35GO6wGEz2sB2jRkPawUf52b_eBhBIks5txkPigaJpZM4TCnYY
.

@AshTemp @nellshamrell can we revisit the direction we want this to go? Are we still looking to move away from AirTable, and track this ourselves?

@AshTemp @nellshamrell @hollomancer @JennWeideman
We need to have a discussion around this as I think we need a db for a variety of reason not just scholarships, and we will have to update the original issue as well.


Separate commitment prover and verifier to modules

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#482  👈
#481
#480
#479
#478
#463
#477
#476
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 99.60000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.42%. Comparing base (b2ab31d) to head (ee56eb1).

Files
Patch %
Lines

src/core/commitment_scheme/verifier.rs
99.20%
1 Missing :warning:

Additional details and impacted files
@@                    Coverage Diff                     @@
##           spapini/03-15-quotientops     #482   +/-   ##
==========================================================
  Coverage                      95.42%   95.42%
==========================================================
  Files                             61       62    +1
  Lines                           8845     8845
  Branches                        8845     8845
==========================================================
  Hits                            8440     8440
  Misses                           354      354
  Partials                          51       51

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


browser automation studio has problem with pdf documents

so here is the issue
its a great simple tool to automate chrome I agree. But it has series issues with websites that Open pdf files in the browser...
when that happens and I try to for example print the document using a javascript code or simply move the mouse to the print button on the plugin BAS fails and closes the thread...
any solution?

Hi, thanks for report. We will fix it in one of next version. This is no a proper ways to report about issues. In order to submit ticket, please send email to premium email address, which you can find in your personal cabinet.

hello and thank you.


Cannot find the map (E-SP2). Isn't the similarity too high?

The bot doesn't detect map_E-SP2.png in the new event.
How about reducing the similarity setting instead of replacing the asset?
I reduced the similarity to 0.98 in this line and it worked fine. (I tested only with the JP asset.)
https://github.com/Egoistically/ALAuto/blob/16a1bfb08eaf06f9dbbf941ca180bc6b74691f06/modules/combat.py#L261

Had this issue too with the Iris of Light and Dark rerun due to the smoke in the background, reduced the similarity to 0.95 initially then found 0.96 works as well.


CC01 Wireless Driver Missing nxsem_post in case of error

At line 570:
https://github.com/apache/incubator-nuttx/blob/8d66dbc0680cb81f91674ace814b2b8a94c49cd2/drivers/wireless/cc1101.c#L568-L575
dev->devsem  is not released before exiting.

@paolovolpi could you provide a patch?


8.1.0 deleting dags pvc created with 7.15.0

What is the bug?
I'm currently testing migration from chart version 7.15.0 to 8.1.0 and trying to maintain dags pvc created with 7.15.0 . However , when upgrading to 8.1.0 , a new pvc  is created .
I have tested dags.persistence.existingClaim but dags pvc is also deleted cause it not longer exist on rendered yaml files (haven't found any workaround with helm upgrade to prevent it ) .
Would it be possible to add a new variable on pvc-dags.yaml to prevent this  ? or remove "%s-dags" ?
Any other workaround to suggest? Thanks.
What are your Helm values?
On 7.15.0
dags:
  path: /opt/airflow/dags
  persistence:
    enabled: true
    storageClass: sc-ontap-nas-eco
    size: 1Gi
    accessModes:
      - ReadWriteMany

On 8.1.0
dags:
  path: /opt/airflow/dags
  persistence:
    enabled: true
    storageClass: sc-ontap-nas-eco
    existingClaim: airflow
    size: 1Gi

What is your Kubernetes Version?:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.8", GitCommit:"9f2892aab98fe339f3bd70e3c470144299398ace", GitTreeState:"clean", BuildDate:"2020-08-13T16:12:48Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.5", GitCommit:"e0fccafd69541e3750d460ba0f9743b90336f24f", GitTreeState:"clean", BuildDate:"2020-04-16T11:35:47Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

What is your Helm version?:
$ helm version
version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}

@enriqueayala read the Known Issues section of the 8.0.0 upgrade guide:
https://github.com/airflow-helm/charts/blob/main/charts/airflow/UPGRADE.md#v715x--v800

Thanks @thesuperzapper  , I've tested it but dags pvc is marked as "Terminating" after helm upgrade :
$ kubectl get pvc
NAME                        STATUS        VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS       AGE
airflow                     Terminating   pvc-c5d9b1aa-93af-410b-b521-ba5fcc45209c   5Gi        ROX            sc-ontap-nas-eco   2m34s
airflow-logs                Bound         pvc-58af5a67-7c00-47d5-9b32-d09ddbb196ee   10Gi       RWX            sc-ontap-nas-eco   2m34s

As a workaround I've applied the following :

Download of helm chart 7.15.0

helm fetch airflow-stable/airflow --version 7.15.0

Modification of local airflow/templates/pvc.yaml to set "helm.sh/resource-policy": keep . This is to to skip deleting this resource when a helm operation (such as helm uninstall, helm upgrade or helm rollback) would result in its deletion.

{{- if and (.Values.dags.persistence.enabled) (not .Values.dags.persistence.existingClaim) }}
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: {{ include "airflow.fullname" . }}
  ###https://helm.sh/docs/howto/charts_tips_and_tricks/#tell-helm-not-to-uninstall-a-resource
  annotations:
    "helm.sh/resource-policy": keep
  labels:
    app: {{ include "airflow.labels.app" . }}
    chart: {{ include "airflow.labels.chart" . }}
    release: {{ .Release.Name }}
    heritage: {{ .Release.Service }}
spec:
  accessModes:
    - {{ .Values.dags.persistence.accessMode | quote }}
  resources:
    requests:
      storage: {{ .Values.dags.persistence.size | quote }}
  {{- if .Values.dags.persistence.storageClass }}
  {{- if (eq "-" .Values.dags.persistence.storageClass) }}
  storageClassName: ""
  {{- else }}
  storageClassName: "{{ .Values.dags.persistence.storageClass }}"
  {{- end }}
  {{- end }}
{{- end }}

Applied helm upgrade using customized 7.15.0 local chart to set annotation:

helm upgrade  --install airflow airflow-charts/airflow-7.15.0/airflow -f airflow_values.yaml --history-max 3

Executed helm upgrade for 8.1.0 :

#airflow_values_810.yaml
dags:
  path: /opt/airflow/dags
  persistence:
    enabled: true
    existingClaim: airflow
  gitSync:
    enabled: false
```
```console
helm upgrade  --install airflow airflow airflow-stable/airflow -f airflow_values_810.yaml --history-max 3 --version 8.1.0
```
5. After it pvc is retained (no longer controlled by helm )..

@enriqueayala thanks for raising this!
I think we have to leave the PVC called %s-dags at this stage (its a bit late to change back).
The workaround is probably a bit complex for most users, so I will update the docs to explain that users should manually copy DAGs across if they were using dags.persistence in 7.X.X.
I have made an issue about this: https://github.com/airflow-helm/charts/issues/273

I'm going to close this issue, please discuss on https://github.com/airflow-helm/charts/issues/273.


Add fullscreencontainer option

As mentioned in https://github.com/emberjs/ember-qunit/issues/595#issuecomment-714514126, this adds a fullscreencontainer query param that does exactly what devmode does, minus removing the test timeout.
This is useful for tests that depend on exact dimensions of elements (like scrolling an element to a certain position).

Not sure if there's a good way to test this, I don't see any tests for devmode or the other similar options...


Interactive Tutorials depend on tracker domain on adblocker lists

Effectively the title. The interactive tutorials completely fail to operate if trackjs.com is blocked, which it is if the client has any anti-tracking protections running.
This includes EasyList's easyprivacy, which is one of the default lists used as part of uBlock origin.
Trying to run the interactive tutorial therefore fails in the following way:
Uncaught ReferenceError: trackJs is not defined
    at TerminalViewLayout.init.init (terminal-application.js?v=20211119:1:1261)
    at window.onInit (?v=2&embed=true&ui=inline&host=kubernetes.io&url=https%3A%2F%2Fkubernetes.io%2Fdocs%2Ftutorials%2Fkubernetes-basics%2Fcreate-cluster%2Fcluster-interactive%2F&target=inline-terminal-1&nonce=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJlbWJlZCI6dHJ1ZSwiZG9tYWluIjoiaHR0cHM6Ly9rdWJlcm5ldGVzLmlvLyIsImlwIjoiMjYwMDo4ODAyOjUzMDA6MmU4Ojk1NjA6NjhkMTpjYWNhOmRmYzQiLCJpYXQiOjE2NDk0ODg0MDEsImV4cCI6MTY0OTQ4ODQzMX0.HDlp1X8-nTZ9s3e0dJpbc1sj74DHcDYQi9rBhFSncbQ&prompt=Kubernetes Bootcamp Terminal&color=326de6&secondary=273d6d&hideintro=false:302:17)
    at HTMLDocument.<anonymous> (?v=2&embed=true&ui=inline&host=kubernetes.io&url=https%3A%2F%2Fkubernetes.io%2Fdocs%2Ftutorials%2Fkubernetes-basics%2Fcreate-cluster%2Fcluster-interactive%2F&target=inline-terminal-1&nonce=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJlbWJlZCI6dHJ1ZSwiZG9tYWluIjoiaHR0cHM6Ly9rdWJlcm5ldGVzLmlvLyIsImlwIjoiMjYwMDo4ODAyOjUzMDA6MmU4Ojk1NjA6NjhkMTpjYWNhOmRmYzQiLCJpYXQiOjE2NDk0ODg0MDEsImV4cCI6MTY0OTQ4ODQzMX0.HDlp1X8-nTZ9s3e0dJpbc1sj74DHcDYQi9rBhFSncbQ&prompt=Kubernetes Bootcamp Terminal&color=326de6&secondary=273d6d&hideintro=false:287:16)
    at HTMLDocument.dispatch (jquery-3.5.1.min.js:2:43090)
    at HTMLDocument.v.handle (jquery-3.5.1.min.js:2:41074)

Please don't make your webapp hard-depend on trackers.

I should further add, trackjs.com is blocked in a lot of places. If you have DNS-based adblocking, it's generally blocked there too.

https://trackjs.com/ is an error logging tool (code library and web service). To me, error logging is a feature more than a bug. I'm not sure it's reasonable to block that tool on the grounds of it being a “tracker”.
Could you explain your concern @fake-name?
/priority awaiting-more-evidence
We could add an explanation that the uBlock tool considers the error logging within the interactive tutorial unacceptable, and advise people who use that blocker to look for an appropriate work-around.

https://trackjs.com/ is an error logging tool (code library and web service)

The concern here is it's effectively a 3rd party data aggregator that can operate on multiple websites. That sounds like something functionally indistinguishable from a tracker.
In any event, the point is, probably the most used ad-blocker (ublock origin) out there includes it in it's default set of block lists.
Basically, the solution here would be to try loading the error logging tool, and if it doesn't load don't explode and completely fail to operate.

Tangential relevance: https://github.com/kubernetes/website/issues/33936
@fake-name we can't customize how Katacoda works. What we might be able to do instead is provide better diagnostics, so that people who use tools like uBlock can opt to turn the tool off once they decide they are happy with the level of error reporting that doing so implies.

/lifecycle frozen

Just come here to say I had the same problem with NextDNS and indeed tutorial is completely broken unless all blockers are disabled.
I understand that the team does not have much margin here so maybe just give an explicit message about it (more and more people does use ad & tracker blockers). it will save a lot of time debugging it. (If I didn't find this thread, I would have skipped the tutorial completely).

/priority backlog
I don't think I can justify setting important-longterm here.
Feature improvement could be to detect likely blocking and reveal a note message that gives a hint about how to fix it.
/area web-development
/triage accepted

Feature improvement could be to detect likely blocking and reveal a note message that gives a hint about how to fix it.

That would be an acceptable solution to this issue.
IMO and while not something you did or can change in any way, the real issue lies with Katacoda -> not working at all while trackjs.com is blocked is not acceptable nowadays (as mentioned by @fake-name)

I don't think “some third party product doesn't like one of our suppliers' choice of libraries and services” counts as an actual bug.

This is an inaccurate summary.
A more accurate summary would be "A large subset of privacy-focused tools regard one of your dependencies as functionally indistinguishable from creepy ad tracker".
You can argue with the characterization, but the fact is multiple independent tools have apparentlt started blocking trackjs.com due to privacy concerns. This is an indisputable fact.

Also see https://github.com/kubernetes/website/issues/37417

We could add an explanation that the uBlock tool considers the error logging within the interactive tutorial unacceptable, and advise people who use that blocker to look for an appropriate work-around.

This is what I recommend. Separately, and for the longer term, we might feasibly be able to find a team of contributors willing to switch to a different way of providing those tutorials. I think that is a big ask.

I still don't see why simply not failing on the error logging facility not loading isn't the preferred option.

Contributors are welcome to make a new live tutorial service to replace Katacoda, or to migrate our tutorials to a different service.
I think either of those options represents quite a lot of work. A much more achievable step is to warn readers that our tutorial service relies on an error reporting tool that tracks use, and some ad blockers block it. We can provide additional detail about why there isn't any advertising.
All of that is considerably less effort than migrating to a new in-browser Kubernetes environment, and we could deliver that very soon. I think we should do the quick easy thing early, and then decide on next steps.
/remove-priority awaiting-more-evidence
If folks would like to, come to the next Zoom meeting of SIG Docs, and recommend the approach to take. We can then decide if we'd have enough volunteer resources to make that happen.

simply not failing on the error logging facility not loading isn't the preferred option.

It may not be as simple as you think, @fake-name. If you can show otherwise, that'd be really useful to learn.

We're removing Katacoda. As such, we don't plan to fix this bug.
/triage unresolved
/remove-triage accepted

/close
Won't fix because we're removing Katacoda.


Add eslint-plugin-node to linting configuration.

This has a number of really nice features, like:

verifying that imported things from published files are in dependencies vs devDependencies
verifying that we don't use invalid syntax for our supported Node versions.

Checkout https://github.com/mysticatea/eslint-plugin-node#-rules for a complete list.

CI will be fixed by https://github.com/hjdivad/nyx.js/pull/10.

Rebased on top of #10


[6.0] Add freeze and freezeAt helpers

Not sure how willing you are to add helpers to the frameworks Carbon instance, and I fully appreciate that it's something that can be macro'd in, but thought it was worth proposing this in case it's helpful.
In a number of test cases I've got, they're dependent on time and I've used Carbon::setTimeNow() in order to set up the state in order to get the results I expect. However, you have to remember to always restore time by calling the method again without any arguments.
This adds two helper methods to Carbon which make it really easy to perform these sort of tests - or any sort of logic that requires freezing time - a little bit nicer and less prone to mistake.
Carbon::freeze(function ($now) {
    // $now is the current time, frozen in the callback
});

$now = Carbon::subWeek();

Carbon::freezeAt($lastWeek, function ($now) {
    // $now is the same time last week, frozen in the callback
});

This is very useful, however, we should be careful on adding method on extended Carbon class.

test cases…
…However, you have to remember to always restore time by calling the method again without any arguments.

I don't understand, \Illuminate\Foundation\Testing\TestCase::tearDown already takes care of "resetting" Carbon:
        if (class_exists(Carbon::class)) {
            Carbon::setTestNow();
        }

        if (class_exists(CarbonImmutable::class)) {
            CarbonImmutable::setTestNow();
        }

Or are you talking about having to fixate/freeze this for a specific region within your test?
One other thing: if you use setTestNow(…) before that or e.g. in setUp(), using these new methods effectively clears the fixed test before your test then ends, which might be unexpected.
I wonder what use case this is.
One thing I have learned: in all my projects I have Carbon:setTestNow(Carbon::now()) in the setUp method because it happens too easily that seconds can wrap within a test, skewing expected results; e.g. database integration tests, etc.

That's neat - I wasn't aware that Laravel was resetting Carbon in tearDown.
My use case was around freezing time for a test, not a specific region of a test, providing a nice syntax to do so. Perhaps this closure should instead reset time back to what it was previously (if it was previously set) rather than null if that's more expected.

My use case was around freezing time for a test, not a specific region of a test, providing a nice syntax to do so. I suppose the best utility of these methods is when that additional specificity is required.

But given that the reset already happens, it's just a matter of calling Carbon::setTestNow(…) where you need it (setUp, start of test), so what's the benefit of having the closure methods then?

Yeah, fair call. Doesn't seem as necessary now knowing Laravel is resetting time for you automatically.


[question] transition evaluation order

I sometimes want to use if/else branch on guards.
Does the elements of the make_transition_table evaluate top to bottom?
If it does, I can implement if/else branch using no guard branch as follows:
#include <iostream>
#include <boost/sml.hpp>
namespace sml = boost::sml;
struct Prop { int val; };
struct Event1 {};
struct Simple {
    auto operator()() const noexcept {
        using namespace sml;
        return make_transition_table(
            * "State1"_s + event<Event1> [([](Prop& p){ return p.val == 1;})]
            / [](auto const&) { std::cout << "Action1" << std::endl;} = "State1"_s // val == 1
            , "State1"_s + event<Event1>
            / [](auto const&) { std::cout << "Action2" << std::endl;} = "State1"_s // else
            , "State1"_s + on_entry<_> / [](auto const&){ std::cout << "on_entry" << std::endl; }
            , "State1"_s + on_exit<_> / [](auto const&){ std::cout << "on_exit" << std::endl; }
        );
    }
};
int main() {
    Prop p{1};
    sml::sm<Simple> sm{p};
    sm.process_event(Event1{});
    p.val = 2;
    sm.process_event(Event1{});
}

BTW, my friend implemented daily update sml on his online compiling environment named Wandbox.
http://melpon.org/wandbox/permlink/lKfepkCS4tGl6WB0

It's a great question and yea the order is guaranteed to be from top to bottom so the example will work as expected. The order guarantee was required for handling exceptions and generic events but it might be used for else branches as well which, additionally, speeds up things as guard doesn't have to be checked twice (I'm doing it myself and sml is tested against that too).
Yes, I've seen it. Thank you! I love Wandbox, IMHO it's the best online compiler. I'm using it in boost.di and boost.sml online documentation too. This way users can check the functionality easily and experiment with it without downloading the library.

Thank you! It's ideal behavior to implementation for if/else branch. Boost.MSM evaluates bottom to top by some reason. sml is more natural :)


Speech SDK on Azure WebApp (Windows x64)

Hi all,
I try using the speech sdk in a java spring boot project on a azure web app (windows x64).
On my local dev env. everything works fine (Mac OS 10.14.6).
Whenever I try using the deployed version I always receive:
org.springframework.web.util.NestedServletException: Handler dispatch failed; nested exception is java.lang.UnsatisfiedLinkError: com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init()V .....
Caused by: java.lang.UnsatisfiedLinkError: com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init()V
The azure WebApp General Settings look like this:

We also tried it with Java 1.8. No difference at all. Also on my local dev env. it works with both java versions.
Our code follows the given examples in this repo and of course we are using the latest sdk version 1.7.0
Any ideas?

@jnickels
Thanks a lot for reporting the issue. I will look into it and come back to you.

Any updates on this issue?

@jnickels I am looking into it and will get back to you very soon.

@amitkumarshukla any news?

Just wondering whether the C++ redistributable is installed in your target environment?
https://docs.microsoft.com/en-us/azure/cognitive-services/speech-service/ship-application#windows
Not sure what's the best way to get it into web app (copying the DLLs it installs should work, if these are in path).

which DLLs? All of them?! Am I the only one having problems with Speech SDK on azure web app resource?

Hi all,
did several checks now:
It works on Azure Ubuntu VM if you start it via console
It works on Azure Win 10 VM if you run it via Eclipse
It works on Mac OSX local Dev machine if you run it via IntelliJ or console
It works on Win 10 local Dev machine if you run it via IntelliJ/Eclipse
It is NOT working on Azure WebApp (Linux&Win) started via console (triggered by web.config)
It is NOT working on Azure Win 10 VM if you start it via console
It is NOT working on Win 10 local Dev machine if you start it via console.
That’s the exception I receive when a streaming request hits the Service:
org.springframework.web.util.NestedServletException: Handler dispatch failed; nested exception is java.lang.UnsatisfiedLinkError: com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init()V
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1054)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:942)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1005)
at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:908)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:665)
at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:882)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:876)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1623)
…..
Caused by: java.lang.UnsatisfiedLinkError: com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init()V
at com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.swig_module_init(Native Method)
at com.microsoft.cognitiveservices.speech.internal.carbon_javaJNI.(carbon_javaJNI.java:893)
at com.microsoft.cognitiveservices.speech.SpeechConfig.(SpeechConfig.java:70)
at com.bmw.connected.mvs.backend.stt.business.SpeechServicesService.receiveTextFromAudio(SpeechServicesService.java:44)
at com.bmw.connected.mvs.backend.stt.business.SpeechServicesService$$FastClassBySpringCGLIB$$c4bf2594.invoke()
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
For me it looks like there is an problem how the sdk tries to resolve the native library on windows.

If you can please send me your sample code. Also send me the command line you used to run it on "It is NOT working on Win 10 local Dev machine if you start it via console."

If I run it from console I use the following command:
java -Dserver.port=8090 -Dspring.profiles.active=mock-profile -jar myJarFile.jar
Unfortunatelly I can't give you my sample code. But please take a look on your NativeLibraryLoader.java. We decompiled it and it looks like there are some errors loading the DLLs on windows machines.

We know the root cause of the issue and are working on fix, closing the issue from here.


Multiple remote LUCI

Hello,
Im new to LUCI, and i need to add some features to it and im currently trying to find the best way to do it.
To use LUCI right now the user has to log into a particular router's web interface, but if i have 100 routers i dont want to log into each router one by one, i want to log into one router, make changes, then be able to push those changes to all the other routers automatically without manually logging into all 100 routers one by one.
Another feature i need is to be able collect metrics (number of packet errors, signal strength, etc) from all the routers and see them from one router's web interface dashboard, instead of running around logging in and looking at each router individually.
All this has to be done securely.
Anybody has any suggestions on how to do any of these?
Thanks

Another feature i need is to be able collect metrics (number of packet errors, signal strength, etc) from all the routers and see them from one router's web interface dashboard, instead of running around logging in and looking at each router individually.

That is already possible with LuCI statistics, as collectd (the underlying stat engine) supports networking.

@nsmith1024: several openwrt downstreams implented stuff like this, but typically they are "not sharing".  We need a very barebones version of it too, so I've been looking into it.
Once the router is deployed, it is trivial to do using ubus over uhttpd + https, but you will want firewall restrictions if you enable this in the WAN, as well as ensuring proper SSL validation to avoid MITM.  Otherwise, you're toast.
Use a separate user (add it to rpcd) for ubus access, with an extremely strong password (machine-generated).  I recommend using a strong base secret, PBKDF2, and a HKDF or other securely hashed variation of the device MAC as salt for the PBKDF2, obviously also using a secret.  That allows per-device credentials, being accessed from a single centralized location (which holds the other secrets).

Or just create per-device credentials normally with a string password generator, and store them in a safe database inside your centralized control server.  Whatever works best for you.

As @hmh pointed out, using ubus over HTTP(s) would be the way to go. LuCI slowly migrates in that direction, handling more and more things on the client side so that eventually only static assets are left which could theoretically be hosted anywhere and be instructed to connect to any given ubus HTTP endpoint on login.
Right now this is not feasible yet because a number of LuCI apps are still server side rendered and some base LuCI logic (dispatching, header/footer framing etc.) still happens server side.
Closing this as this is not really an actionable bug report.


Replace close button image with xmark SF Symbol in iOS 13

For #362
If cloning the repository using Swift Package Manager, the close button image is not downloaded. This replaces the button's image with the xmark SF Symbol if the device is running iOS 13 or newer.

@zvonicek Can you please merge this?

I'm actually unsure about this, mainly because the SF Symbol asset would work on iOS 13 only and the not presence of the image might not be noticed by some users of the library, leading to shipping a broken behavior on older operating systems.
However, with this year's SPM improvements we should finally be able to bundle resources in a package. I think this is a better way forward.

Support for SPM bundle resources comes in #400.


Discriminator selector dropdown overlaps

When using discriminator its dropdown overlaps by bellow accordion.

Quick fix for me was to add this code:
    [_nghost-c17] {
        overflow: visible !important;
    }

Should be fixed in<EMAIL_ADDRESS>Feel free to open a new issue if it is not fixed
Thanks


Menu bar and right-click not functioning correctly in macOS Ventura

Description
Hello!
I have been noticing a few oddities while running DBeaver on beta versions of the forthcoming macOS Ventura (13.0) release:

Clicking any of the menu bar items (Navigate, Seach, SQL Editor, etc) does not produce a menu as expected.

Secondary (aka "right") click does not work in any part of the DBeaver interface

Log: dbeaver-debug copy.log
DBeaver Version
CE 22.1.4, both Intel and AS versions
Operating System
macOS Ventura (13.0)
Database and driver
Not pertinent (issues are present in a fresh install).
Steps to reproduce

Open DBeaver
Try to select an option in the menu bar
Try a secondary click anywhere within the interface

Additional context
No response

Hello @bendoughty
DBeaver is based on the Eclipse platform, and this is the Eclipse bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=580322
It seems to be fixed already, but this fix will be available in our product only in Autumn with the new Eclipse release.

Duplicate: https://github.com/dbeaver/dbeaver/issues/17204

For anyone trying to install 22.1.0 with homebrew and being annoyed that it isn't as easy as just prepending @22.1.0, heres how I did it according to this stackoverflow post
curl https://raw.githubusercontent.com/Homebrew/homebrew-cask/707f37126777e710d34232ed602c49329907e221/Casks/dbeaver-community.rb > $(find $(brew --repository) -name dbeaver-community.rb)
brew reinstall dbeaver-community

this installs https://github.com/Homebrew/homebrew-cask/commit/707f37126777e710d34232ed602c49329907e221, which restored right-click functionality for me on my m2 air running ventura.


Can HA-bridge reflect status of harmony activity when using remote

I have a Logitech harmony hub with matching remote.
I have made a device in HA-bridge of a harmony activity. With this I can turn the activity on and off. The device state is also reflecting the right state (on or off).
But should it be also possible ((and how) to reflect the right state when starting and stopping the activity from the harmony remote (or app)?
Now the state in HA-bridge stays off when starting the activity from the remote or app.

Yes it could. There is even tricky way to do it in the current version using webhook. This fires an event based on the activity monitor.

Is then de hub it self calling the url which is in the webhook field?
If yes, which url do I have to use to change the status of the corresponding activity in HA-bridge?

No, it is the ha-bridge calls the url with the webhook string. Actually it would have to be another server to decode what you send it an then send another command back to update the state. It would be pretty ugly and I wouldn't recommend it.

ha-bridge was not built to watch it's end points for status changes. It is still not an easy task to find the devices associated with the activity as they are disconnected.


Issue loading neotoma2 through devtools

I am getting the following error when trying to load neotoma2:
Error in makePrototypeFromClassDef(properties, ClassDef, immediate, where) :
in making the prototype for class “publication” elements of the prototype failed to match the corresponding slot class: author (class "contacts" )
Error: unable to load R code in package ‘neotoma2’
Execution halted

I am getting a similar error when running devtools::install_github('NeotomaDB/neotoma2'). Here is the error message:

Error: Failed to install 'unknown package' from GitHub:
HTTP error 404.
No commit found for the ref master

Did you spell the repo owner (NeotomaDB) and repo name (neotoma2) correctly?

If spelling is correct, check that you have the required permissions to access the repo.

Hmmm, I was just able to load it from github, though I had to add “force=T”. Could you try again? Maybe there was a little blip in the GitHub repo?
devtools::install_github('NeotomaDB/neotoma2', force=TRUE)
Best,
Jessica

Associate Professor
School of Natural Sciences
University of California, Merced
Faculty Director
UC Merced Natural Reserve System
Office: SE1 296
Phone:<PHONE_NUMBER>
Email: @.***
Web: http://jessicablois.com
Pronouns: She/Her/Hers
From: Meghan Balk @.>
Reply-To: NeotomaDB/neotoma2 @.>
Date: Wednesday, June 9, 2021 at 10:34 AM
To: NeotomaDB/neotoma2 @.>
Cc: Jessica Blois @.>, Author @.***>
Subject: Re: [NeotomaDB/neotoma2] Issue loading neotoma2 through devtools (#1)
I am getting a similar error when running devtools::install_github('NeotomaDB/neotoma2'). Here is the error message:
Error: Failed to install 'unknown package' from GitHub:
HTTP error 404.
No commit found for the ref master
Did you spell the repo owner (NeotomaDB) and repo name (neotoma2) correctly?

If spelling is correct, check that you have the required permissions to access the repo.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NeotomaDB/neotoma2/issues/1#issuecomment-857895064, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSR7O5LVHDESF4I4OKMIALTR6QYVANCNFSM4YDG2YTA.

I was able to fix it by updating R from 4.0 to 4.1 and re-installing the package devtools.
Oddly, though, @c-tome had no problem and is using R version 3.6.

Hmmm, odd. I’m using R4.0.4. But glad it’s working now! Note that this is still a beta version of the package and so some functionality may not be working appropriately!
Best,
Jessica

Associate Professor
School of Natural Sciences
University of California, Merced
Faculty Director
UC Merced Natural Reserve System
Office: SE1 296
Phone:<PHONE_NUMBER>
Email: @.***
Web: http://jessicablois.com
Pronouns: She/Her/Hers
From: Meghan Balk @.>
Reply-To: NeotomaDB/neotoma2 @.>
Date: Wednesday, June 9, 2021 at 10:48 AM
To: NeotomaDB/neotoma2 @.>
Cc: Jessica Blois @.>, Author @.***>
Subject: Re: [NeotomaDB/neotoma2] Issue loading neotoma2 through devtools (#1)
I was able to fix it by updating R from 4.0 to 4.1 and re-installing the package devtools.
Oddly, though, @c-tomehttps://github.com/c-tome had no problem and is using R version 3.6.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NeotomaDB/neotoma2/issues/1#issuecomment-857907949, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSR7O7MAQZZHQJAITTHMVLTR6SQNANCNFSM4YDG2YTA.

This is all sorted now.  Closing the issue.


feat(dom): export getRectRelativeToOffsetParent function

This PR exports getRectRelativeToOffsetParent() function from @floating-ui/dom.
TL;DR Without it you can't compose getElementRects() in platform:
https://github.com/floating-ui/floating-ui/blob/b8990250568043b876e1c8fe42358fe337847ede/packages/dom/src/platform.ts#L20-L31
Why?
We need this for a hack in https://github.com/microsoft/fluentui/pull/28045 that prevents jumps, see #26579 and https://github.com/microsoft/fluentui/issues/26579#issuecomment-1503562558.

We need to set position: fixed for initial positioning so elements in React portals will not appear off screen
This should be done after getOffsetParent() as getOffsetParent() will always return null when an element has position: fixed
This should be done before getRectRelativeToOffsetParent()
getRectRelativeToOffsetParent() is not exported 💥

We need to set position: fixed for initial positioning so elements in React portals will not appear off screen

Is this only to prevent scroll jumps due to focus? You can use an isPositioned-like value to avoid this problem and stick to absolute. Here is an example: https://floating-ui.com/docs/react#effects

Is this only to prevent scroll jumps due to focus? You can use an isPositioned-like value to avoid this problem and stick to absolute. Here is an example: https://floating-ui.com/docs/react#effects

Nope, check the linked issue it contains an explainer of what is happening 😉

So, is it possible to remove that CSS property on the portal container, to prevent measurements from creating potential scrollbars?

Unfortunately, it's not an option currently 😿

@atomiks is there a chance to get this merged? Or maybe you have some suggestions to a case that I described above?

Well, I'm hesitant to export new APIs if they don't need to be, especially internal ones that I might want to change
I think you can use position: absolute; top: 0; on the wrapper instead

Well, I'm hesitant to export new APIs if they don't need to be, especially internal ones that I might want to change
I think you can use position: absolute; top: 0; left: 0; width: 100%; on the wrapper instead

Thanks for suggestion, haven't considered applying left & top 🤔 TIL 👍
P.S. right: 0 is also required to have a proper width of a container


PHP7 distribtest broken on master (failure to pull docker image)

It's been failing for the past ~ 2days.
Failure link:
https://source.cloud.google.com/results/invocations/9a1eeae4-c3ce-4c50-b0fb-3a33856aaede/targets/github%2Fgrpc/tests;group=tasks;test=distribtest.php7_linux_x64_stretch;row=1
Looks like something is wrong with pulling the php7_stretch_x64 image.
I am able to reproduce locally by running:
docker pull grpctesting/php7_stretch_x64:8ad39eea13c72af84c0ddd1a265edbce260cf363
8ad39eea13c72af84c0ddd1a265edbce260cf363: Pulling from grpctesting/php7_stretch_x64
4f250268ed6a: Pulling fs layer
e19108d243ae: Pulling fs layer
739dcfb11b47: Pulling fs layer
error pulling image configuration: unknown blob

Likely caused by https://github.com/grpc/grpc/pull/24311/files?

Not being able to pull the dockerimage seemed odd, so I  have rebuilt the docker image locally and force-pushed it to dockerhub. Let's see if that fixes the issue.

After I force-pushed the image grpctesting/php7_stretch_x64:8ad39eea13c72af84c0ddd1a265edbce260cf363, the last build is green https://source.cloud.google.com/results/invocations/c9b79568-aa5c-42ba-ad31-6517df9c28a9/targets/github%2Fgrpc/tests
I will wait for a few more green builds before I mark this as fixed.

This is interesting because @stanley-cheung pushed the new image and the build became green since then for a while but somehow it started to miss it.

This is interesting because @stanley-cheung pushed the new image and the build became green since then for a while but somehow it started to miss it.

Yeah I agree it's weird. Somehow the existing image went missing or corrupt.

Yea this is weird. I did run the tools/dockerfile/push_testing_images.sh script to build the image locally and push to docker hub, in fact twice. First time because I forgot to run it and the build failed with this error
+ DOCKER_IMAGE_NAME=grpctesting/php7_stretch_x64:dedbc0925e8bc47d902d700852533731e2c0ce6a
+ docker pull grpctesting/php7_stretch_x64:dedbc0925e8bc47d902d700852533731e2c0ce6a
Error response from daemon: pull access denied for grpctesting/php7_stretch_x64, repository does not exist or may require 'docker login'

Note that it says "repository does not exist", not "error pulling image configuration: unknown blob". It wouldn't even get to these lines
4f250268ed6a: Pulling fs layer
e19108d243ae: Pulling fs layer
739dcfb11b47: Pulling fs layer

After my first run of push_testing_images.sh, I got to another error but it's on the image itself - some prereqs are missing. So I have to change the dockerfile itself. Then I kick off another build, but I forgot to run push_testing_images.sh beforehand. So I got another similar error like this:
+ DOCKER_IMAGE_NAME=grpctesting/php7_stretch_x64:8ad39eea13c72af84c0ddd1a265edbce260cf363
+ docker pull grpctesting/php7_stretch_x64:8ad39eea13c72af84c0ddd1a265edbce260cf363
Error response from daemon: manifest for grpctesting/php7_stretch_x64:8ad39eea13c72af84c0ddd1a265edbce260cf363 not found

Note that the hash checksum 8ad39eea13c7 matches the one Jan currently has trouble with. I did re-run push_testing_images.sh one more time so build and push that 8ad39eea13c7 image and the subsequent run was successful.
It seems that from these lines:
4f250268ed6a: Pulling fs layer
e19108d243ae: Pulling fs layer
739dcfb11b47: Pulling fs layer

it seems to indicate that the docker image 8ad39eea13c7 did exist but is somehow corrupted? This is strange.
But it does look like that Jan's force-push has resolved the issue. I will monitoring.

All the recent builds are passing. Closing as fixed.


Updating the changelog

@bast @rdoursenaud
I've been manually updating docs/changelog.rst every time I make changes or merge a pull request. It would be silly to create a new pull request for this so I've been pushing directly to main. This won't work when there's more than one person working on the code.
How do we handle this from now on? Any ideas?

I'd be inclined to update it manually just before release using the git log.

OK. Could you add it to the release instructions?

I have a checklist somewhere in the docs so I don't forget things.

Found it in the contributing guidelines.
I'll wait for @bast opinion on the matter before editing it.
I was thinking of also adding a word about:

[ ] the difference between issues and discussions and how to choose where to post (And maybe add an issue template to outline that at issue creation time)
[ ] the best practice of using and creating a virtualenv before jumping to installing the dependencies

Good additions.

Sorry for being slow. In other projects I try to adjust them together with the PRs that change the code. But sometimes I forget and then I do it with a separate PR or push.

I tend to better trust the SCM history and find changelogs redundant.
In an ideal world all commits and commit messages would be of high enough quality that generating a changelog could be automated using git log --oneline --no-merges [previous_release_tag].. (Eg. git log --oneline --no-merges 1.2.10.. for the current release cycle).
I understand we live in a messy world though!
A long winded way of saying that either way is fine by me as long as it is documented and (lightly) enforced to keep things consistent.
IMHO it still needs to be proofed against SCM history at release time.

Oh and we're making free software using an asynchronous medium of communication, no need to apologize for delays ;)

I find changelogs really useful for people who use mido as library and don't want to go through commit history and PRs to find out what has changed. Many just want a quick overview to answer the questions:

anything interesting in there that I want to have and should I upgrade?
if I upgrade, will it be painful for me? :-)

So I would like to keep short changelog or release notes.

Yes, release notes with a changes summary are absolutely required for a library. We're on the same page!
What I was trying to convey is that it isn't worth it, IMHO, to maintain this kind of documentation along the way since we already have a single source of truth: the SCM history.
My 2 takeaways:

between releases I believe we should focus on having clean and meaningful commit messages
just before release, do the one time job of compiling the release notes including a summary of the changes

I have drafted the new release using the GitHub Release feature and discovered - to my horror - that it can generate a pretty compelling changelog with proper acknowledgements including the list of new contributors.
It also supports drafting and creating the new tag.
I believe that we should all just use that to generate our changelog and prepare our release.
Just copy the code over to docs/changes.rst & off we go!
If we're all on board, I'll update the documented procedure.

For what it's worth, here's what it would have generated for this release:

## What's Changed
* Fixing misspelling of easiest by @morgankenyon in https://github.com/mido/mido/pull/310
* remove files used by Travis; closes #266 by @bast in https://github.com/mido/mido/pull/283
* in testing and contribution docs, use "main" instead of "master"; closes #272 by @bast in https://github.com/mido/mido/pull/315
* test also Python 3.9 by @bast in https://github.com/mido/mido/pull/316
* Fix for duplicated devices in mido output by @matemaciek in https://github.com/mido/mido/pull/321
* Fixed some style things. Checks should pass again. by @olemb in https://github.com/mido/mido/pull/322
* Fix PortServer disconnect crash in Python 3 by @kyleclaassen in https://github.com/mido/mido/pull/291
* Removed 2.7 support. Now requires 3.7 or higher. by @olemb in https://github.com/mido/mido/pull/408
* add GitHub URL for PyPi by @andriyor in https://github.com/mido/mido/pull/365
* backends: Fix typos in docstrings by @nomadbyte in https://github.com/mido/mido/pull/393
* docs: Fix example code for parsing by @nomadbyte in https://github.com/mido/mido/pull/394
* messages: Fix typos in docstrings by @nomadbyte in https://github.com/mido/mido/pull/397
* Set socket file buffering to 0 by @m-vo in https://github.com/mido/mido/pull/342
* Remove remnants of Python 2 support by @rdoursenaud in https://github.com/mido/mido/pull/409
* Fix PortMidi backend by @rdoursenaud in https://github.com/mido/mido/pull/413
* Drop Python 2 support in packaging by @rdoursenaud in https://github.com/mido/mido/pull/446
* Specify Python version explicitly for running pip by @rdoursenaud in https://github.com/mido/mido/pull/447
* Docs link by @rdoursenaud in https://github.com/mido/mido/pull/448
* Move packaging setup to PEP-518 by @rdoursenaud in https://github.com/mido/mido/pull/449
* Remove even more Python 2 remnants by @rdoursenaud in https://github.com/mido/mido/pull/452
* Update GitHub action runners by @rdoursenaud in https://github.com/mido/mido/pull/453
* Superbock fix unit conversions by @rdoursenaud in https://github.com/mido/mido/pull/454
* Fix BPM <-> MIDI tempo conversions by @superbock in https://github.com/mido/mido/pull/114
* Add MetaMessage.from_bytes() by @rdoursenaud in https://github.com/mido/mido/pull/455
* Added from_bytes() method to MetaMessage class by @gulaki in https://github.com/mido/mido/pull/149
* draft code of conduct by @bast in https://github.com/mido/mido/pull/461
* Cleaned up the logo by @rdoursenaud in https://github.com/mido/mido/pull/451
* Don't use star imports in portmidi_init by @akx in https://github.com/mido/mido/pull/483
* Make the project REUSE compliant by @rdoursenaud in https://github.com/mido/mido/pull/450
* move complex function out of __iter__() first loop by @Frnot in https://github.com/mido/mido/pull/470
* Separate GitHub workflow test steps by @rdoursenaud in https://github.com/mido/mido/pull/488
* Allow custom clock for MIDI playback by @almostimplemented in https://github.com/mido/mido/pull/465
* Documentation overhaul by @rdoursenaud in https://github.com/mido/mido/pull/492
* mention that project follows semantic versioning; closes #493 by @bast in https://github.com/mido/mido/pull/495
* next planned version is 1.3.0 by @bast in https://github.com/mido/mido/pull/496
* Miscellaneous fixes around dependencies by @rdoursenaud in https://github.com/mido/mido/pull/499
* Read the Docs configuration by @rdoursenaud in https://github.com/mido/mido/pull/501
* Release automation prototype by @rdoursenaud in https://github.com/mido/mido/pull/503
* Make `UnknownMetaMessage` robust to faulty MIDIs by @sonovice in https://github.com/mido/mido/pull/286

## New Contributors
* @morgankenyon made their first contribution in https://github.com/mido/mido/pull/310
* @matemaciek made their first contribution in https://github.com/mido/mido/pull/321
* @kyleclaassen made their first contribution in https://github.com/mido/mido/pull/291
* @andriyor made their first contribution in https://github.com/mido/mido/pull/365
* @nomadbyte made their first contribution in https://github.com/mido/mido/pull/393
* @m-vo made their first contribution in https://github.com/mido/mido/pull/342
* @rdoursenaud made their first contribution in https://github.com/mido/mido/pull/409
* @gulaki made their first contribution in https://github.com/mido/mido/pull/149
* @akx made their first contribution in https://github.com/mido/mido/pull/483
* @Frnot made their first contribution in https://github.com/mido/mido/pull/470
* @almostimplemented made their first contribution in https://github.com/mido/mido/pull/465
* @sonovice made their first contribution in https://github.com/mido/mido/pull/286

**Full Changelog**: https://github.com/mido/mido/compare/1.2.10...1.3.0

Not bad compared to my manually edited notes.


Report Test Coverage

Reporting Test Coverage should be done.  Builds should fail if coverage falls below 90%.
Coverage has been done in NeoAgi specific ways, implement a public version using: https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-code-coverage?tabs=windows#code-coverage-tooling

This is actually implemented in the workflow rendering the latest from v1.4.2:
+---------------------------------------------+--------+--------+--------+
| Module                                      | Line   | Branch | Method |
+---------------------------------------------+--------+--------+--------+
| NeoAgi.CommandLine                          | 62.34% | 47.16% | 84.61% |
+---------------------------------------------+--------+--------+--------+
| NeoAgi.CommandLine.Extensions.Configuration | 90.32% | 50%    | 100%   |
+---------------------------------------------+--------+--------+--------+

+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 65.46% | 47.27% | 89.18% |
+---------+--------+--------+--------+
| Average | 76.33% | 48.58% | 92.3%  |
+---------+--------+--------+--------+

Will need to improve the ratio to implement this.


Drops external outputs and updates external data guides

Part of #4513.
This drops external outputs but also makes other changes to the guides about external data:

Reorganizes into a page in data management about importing external data, and another one in pipelines about external deps and outs.
For importing external data, separates it from external dependencies into its own page and highlights how to avoid unnecessary downloads/uploads.
For external deps and outs, drops external cache, focuses on no-cache external outputs, and mentions plans to address lack of caching with cloud versioning.

Edit: closes #520

@efiop I'm hesitant to merge this because it relies on keeping --outs-no-cache, so maybe we should take a look and make sure this makes sense to implement first.

@efiop Still need to update the ref and other areas to drop --external everywhere.


soHighlightSimilarTerms low performance

soHighlightSimilarTerms triggers a GetSelectedText which does a FindAll
The GetSelectedText is currently very slow because it works from the uncollapsed lines, which are rebuilt from scratch each time, so this makes any selection change very slow.
Without rewriting GetSelectedText, a simple fix would be to use the same logic as notepad++ and highlight only when the selection is a whole word, cf.
https://bitbucket.org/egrange/tbceditorxe/commits/04dec1b37c7f484c3282a3bc7926fd057ee16f46
(as a side Issue, while the search is performed, I do not see it highlighted, not sure what other property I have set incorrectly)

Actually, you can delete this code. My bad, there's no need to call FindAll. :)


fix: modified create policy wrapper to use type bool instead of int for 'enabled' field

Removed the int and bool type casts from the enabled field when creating a new policy in the policies.py wrapper.
In response to error when passing type int when creating a new policy:
laceworksdk.exceptions.ApiError: [400] Bad Request - Problem parsing JSON, the value for key enabled is of the wrong type

This appears to also be resolved in #111 - can you confirm/close @iancrichardson?

Yes, confirmed.  Sorry about that!


addSupernetValidator file update

added variable to set durationInDays for supernet validation, and set it to 4.
basically, users had difficulties updating this line:

const endTime: bigint = startTime + BigInt(3600 * 24 * 14 + 30)

And the number of days (14) is higher than the period we are telling are validators to validate the primary network for (5 days).
So I decreased the duration for supernetValidation to 4 so that users who execute the file without checking the specifics will not have errors.
But if they need to make updates, we just point to the durationInDays variable.

Note to self - the I would update the docs here: https://docs.juneo.com/intro/build/create-a-supernet
"We will keep the durationInDays the same (4 days), however you may..."


Secrets

Requires https://github.com/Islandora-Devops/isle-buildkit/pull/80
Adds a docker-compose.secrets.yml file and adapts the make file to merge in secrets config.  It's controlled by a USE_SECRETS variable in the .env file.
The secrets are added as individual files in ./secrets and are named the exact same as the environment variable they intend to replace.

Superseded by https://github.com/Islandora-Devops/isle-dc/pull/130


added Nathan's explanation of engine vs. node labels

Proposed changes
Clarify difference between and use cases for node labels vs. engine labels.
Related issue
https://github.com/docker/docker/issues/26392
Please take a look
@nathanleclaire @thaJeztah
Signed-off-by: Victoria Bialas<EMAIL_ADDRESS>

Deploy preview ready!
Built with commit 67544654bcd59dfdc6cb9cf0288034f26d57c263
https://deploy-preview-779--docker-docs.netlify.com

nice 🏷