When MPVersion is selected and deselected, Servers dropdown remains enabled

Functionality

When no MP version is selected -> All Implementations in the Dropdown of the server.
When Download clicked when only Server selected (no MP version) -> use latest supported version for that Implementation.
When MP Version is selected -> All Implementations in the Dropdown of the server which support this version (current functionality)

For the REST api, it was already supported that only runtime was specified and that latest MP Version with all Specs are used in that case.


Fix different x and y size in t1-t2 agreement figure

This PR proposed one of possible fix for https://github.com/spine-generic/spine-generic/issues/193.
For successful creation of t1-t2 agreement figure, it is necessary to x and y-axis have same size (i.e., same number of subjects). This is not satisfied when:

some subjects are excluded from csa_t1 but not from csa_t2 (or vice versa)
no exclude.yml file is used, but some subjects have in input csa-SC_T1w.csv or csa-SC_T2w.csv files None values

This PR adds:

merging of subjects from csa_t1 and csa_t2 keys. For example, when input exclude.yml file looks like:

csa_t1:
- sub-oxfordFmrib04  # this is only example
- sub-mountSinai03  # this is only example
csa_t2:
- sub-beijingPrisma03  # this is only example

then, after merging inside script, it looks like:
csa_t1:
- sub-oxfordFmrib04  # this is only example
- sub-mountSinai03  # this is only example
- sub-beijingPrisma03  # this is only example
csa_t2:
- sub-oxfordFmrib04  # this is only example
- sub-mountSinai03  # this is only example
- sub-beijingPrisma03  # this is only example

i.e. csa_t1 and csa_t2 are same.

error message when no exclude.yml file is used and some subject has None values

CONS - with this workaround, subjects listed only in csa_t1 (or only in csa_t2) are excluded not only from t1-t2 agreement figure, but also from fig_csa_t1.png and fig_csa_t2.png bars figures. It is not ideal, because when subject has only bad fig_csa_t1.png, it is not necessary to exclude him also from fig_csa_t2.png. But, to ensure this, it would require bigger code refactoring because subjects are excluded for each metric (t1, t2,...) separatelly and grouped by sites (so, sub_ID is lost and only lists of values for sites are further processed).
Fixes: https://github.com/spine-generic/spine-generic/issues/193

CONS - with this workaround, subjects listed only in csa_t1 (or only in csa_t2) are excluded not only from t1-t2 agreement figure, but also from fig_csa_t1.png and fig_csa_t2.png bars figures. It is not ideal, because when subject has only bad fig_csa_t1.png, it is not necessary to exclude him also from fig_csa_t2.png. But, to ensure this, it would require bigger code refactoring because subjects are excluded for each metric (t1, t2,...) separatelly and grouped by sites (so, sub_ID is lost and only lists of values for sites are further processed).

that's a big cons (and unnecessary). Why not simply implement the fix inside generate_figure_t1_t2(), the rest of the code should not be impacted

that's a big cons (and unnecessary). Why not simply implement the fix inside generate_figure_t1_t2(), the rest of the code should not be impacted
e.g., in the loop below, just check if the subject exists for csa2, and if not, do not append:
https://github.com/spine-generic/spine-generic/blob/d05938623957d494cabb75bbb5331a572e06ba43/spinegeneric/cli/generate_figure.py#L541

This loop iterates across sites, not across subjects. At this step, values from individual subjects are grouped into list for each site and it is not apparent which specific subject was removed for given site.
(content of csa_t1 dict in this step is following)

Unfortunately, subjects are grouped by sites (i.e., the information which value is from which subject is removed) at early step of the script in the aggregate_per_site function:
https://github.com/spine-generic/spine-generic/blob/d05938623957d494cabb75bbb5331a572e06ba43/spinegeneric/cli/generate_figure.py#L219
I am continuing to think about appropriate workaround.

So, I have done little bit larger refactoring of generate_figure_t1_t2 function in https://github.com/spine-generic/spine-generic/pull/199/commits/22c2088d24b3126ecdfe98c53206b3564f835dea because I did want to largely modify the whole script.
Now, the script excludes only bad csa_t1 subjects for fig_csa_t1.png , only bad csa_t2 subjects for fig_csa_t2.png  and both bad csa_t1 and csa_t2 subjects for fig_t1_t2_agreement_per_vendor.png
The refactored generate_figure_t1_t2 function now fetch input csa-SC_T1w.csv, csa-SC_T2w.csv and participants.tsv and create pandas DF t1_t2_df as following:

Then, this is easy to exclude subjects and create figures.
TODO: update tests

@valosekj i find this refactoring quite overwhelming (was it necessary?), if you don't mind, i'll have a quick look at how we can do this in a simpler way

@valosekj i find this refactoring quite overwhelming (was it necessary?), if you don't mind, i'll have a quick look at how we can do this in a simpler way

I know. It looks overwhelming. Some simpler solution is probably possible, but it would require changes at the beginning of the script (probably in aggregate_per_site function), which can then influence the rest of the script:
https://github.com/spine-generic/spine-generic/blob/4e04f54d8b9a77a0c97e3e77e8d34d82b5dbda74/spinegeneric/cli/generate_figure.py#L219
Because, in this function, individual subjects values are grouped by sites and information which value is from which subject is lost. It is okay for figure displaying only one metric. But, when we need to work with t1 and t2 and need to exclude subject from t2 based on t1, situation becomes complicated because only values grouped by sites are available.
The current proposed solution looks working (tests passed after last fix commit), so if you do not mind that script has some extra line, you do not have to invest your time into this.

I would really like to keep the code clean. Right now, there is a lot of duplication, e.g.:
re-reading the csv files (note: the code will break if not launched from curdir, which is not a valid assumption because of the flag -path-results):
https://github.com/spine-generic/spine-generic/blob/4e04f54d8b9a77a0c97e3e77e8d34d82b5dbda74/spinegeneric/cli/generate_figure.py#L564
re-fetching values (already fetched before)
https://github.com/spine-generic/spine-generic/blob/4e04f54d8b9a77a0c97e3e77e8d34d82b5dbda74/spinegeneric/cli/generate_figure.py#L548
in general, this should be avoided because a modification of the structure (e.g. output of SCT's csv) will imply working at two different places in the code.
i'm now looking into a way to add an "exclude" vector for the df, which is input/output here:
https://github.com/spine-generic/spine-generic/blob/4e04f54d8b9a77a0c97e3e77e8d34d82b5dbda74/spinegeneric/cli/generate_figure.py#L308
since this is a new DF column, it will not interfere with the current codebase, and we can use it elegantly to exclude subjects (simple 'and' logical assertion-- should be one line of code)

Working on https://github.com/spine-generic/spine-generic/tree/jca/193-t1-t2-figure-fix,
The added field in results_dict now enables to cross-reference values with subjects:
df['subject']['amu']
['sub-amu04', 'sub-amu05', 'sub-amu02', 'sub-amu01', 'sub-amu03']
df['val']['amu']
[0.0005520837445402861, 0.000467393490773328, 0.0005314071125280237, 0.00047408375044293656, 0.00042480097149554327]

@valosekj can you give this a try? https://github.com/spine-generic/spine-generic/pull/201

duplicate of https://github.com/spine-generic/spine-generic/pull/201


test: Fix failing error on upgrade graphql 0.8.2

TODO:

[x] Update CHANGELOG.md with your change (include reference to issue & this PR)
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass

duplication of https://github.com/apollostack/graphql-server/pull/208/files.
greenbot failed because it opened the PR before it was merged.


Organizing team and CFP reviewers

(backend) create api call to add organizing team for an event
(backend) create api call to add CFP reviewers team for an event
(backend) return organizing team and CFP reviewers in the event api
(android) if an organizing team is returned by the backend, add a new tab in the info space to display organizers
(android) if CFP reviewers are returned by the backend, add a new tab in the info space to display CFP reviewers
(ios) if an organizing team is returned by the backend, add a item button in the info space to display organizers
(ios) if CFP reviewers are returned by the backend, add a new item button in the info space to display CFP reviewers

Waiting: https://github.com/HugoGresse/OpenPlanner/issues/151 and https://github.com/HugoGresse/OpenPlanner/issues/152


rename exclude files

@pjbreaux the exclude files are bound (too loosely) to jenkins job/makefile targets.

Can one of the admins verify this patch?


How to change Timezone after Wifi connection?

I cant seem to find a way to change the timezone after the device connects to Wifi.
thanks.
-DM

For now, re install the clockface, it erases all persisted data on ESP32. I'm working on a settings page. I will release soon


Change "addons.mozilla.org" in reviewer email templates to "addons.thunderbird.net"

There's a bunch of email templates in src/olympia/reviewers/templates/reviewers/emails that have the wrong site URL hard coded, this is an easy fix and should cause very few if any conflicts with future patches, so might as well do it.

bonus points for changing the hardcoded host to a variable and also pushing that patch upstream :)

If they'll take the patch I'll definitely do it that way.

This was fixed a long time ago by https://github.com/thundernest/addons-server/commit/da6fdef9f970bdb81f39b51c5de14381d7494418


Increase the Vagrant version to allow 2.0.3

Islandora-vagrant forced 2.0.3 for so we should update too.

@dannylamb Do I need to do anything else to have this commit merged?

@ysuarez You're good. I'll try it out and let you know or merge it.


naive datetimes exported to json not valid with generate json schema

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.7.3
            pydantic compiled: True
                 install path: /home/languitar/src/api-files/.venv/lib/python3.9/site-packages/pydantic
               python version: 3.9.2 (default, Feb 20 2021, 18:40:11)  [GCC 10.2.0]
                     platform: Linux-5.10.19-1-lts-x86_64-with-glibc2.33
     optional deps. installed: ['typing-extensions', 'email-validator']

When constructing a data type with a datetime field, the default JSON Schema generation results in a string field with format date-time, which is reasonable. However, it is possible to generate data when using the json() export method that is not compatible with this schema in case tz-naive datetime is used
In [8]: from datetime import datetime

In [9]: from pydantic import BaseModel

In [10]: class Test(BaseModel):
    ...:     foo: datetime
    ...:

In [11]: Test.schema()
Out[11]:
{'title': 'Test',
 'type': 'object',
 'properties': {'foo': {'title': 'Foo',
   'type': 'string',
   'format': 'date-time'}},
 'required': ['foo']}

In [12]: Test(foo=datetime(2020, 1, 1, 12, 1, 1, 12345)).json()
Out[12]: '{"foo": "2020-01-01T12:01:01.012345"}'

The resulting string representation lacks a timezone indicator to be valid (cf. https://tools.ietf.org/html/rfc3339#section-5.6).
Of course it is not automatically possible to magically come up with a timezone for a datetime without this information. But is is also a bit surprising that still something is generated in the json() method that doesn't follow any valid schema. I can think of multiple solutions to make this at least more predictable for users:

Always fail with an exception for naive datetime instances
assume a default timezone (configurable) such as UTC
Require a default timezone to be provided in case of naive datetime instances

You can now use NaiveDatetime and AwareDatetime. The NaiveDatetime raises validation error when a timezone info is provided, and the AwareDatetime raises error when the timezone info is missing.
from datetime import datetime

from pydantic import BaseModel, AwareDatetime, NaiveDatetime
import pytz

class Test(BaseModel):
    foo: datetime
    bar: AwareDatetime
    por: NaiveDatetime

print(
    Test(
        foo=datetime(2020, 1, 1, 12, 1, 1, 12345),
        bar=datetime(2020, 1, 1, 12, 1, 1, 12345, tzinfo=pytz.utc),  # Remove tzinfo to fail.
        por=datetime(2020, 1, 1, 12, 1, 1, 12345), # Add tzinfo to fail.
    ).json()
)

@Kludex  Which version of Pydantic will these modules be available?  I get an import error with Pydantic 1.10.7.  But I would love to get these types.

@Kludex is using V2 which is currently available as an alpha release.


[BugFix] Fix the failure to refresh when joining the internal and external tables of the materialized view

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #20925
Problem Summary(Required) ：

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


ClassNotFoundException on release mode

Hi there.
The app exits when opening the video call on release mode only.
I have investigated then found where the issue is, I have found the issues, the issue is: No pending exception expected: java.lang.ClassNotFoundException: com.opentok.android.SubscriberKit$SubscriberAudioStats.
I have attached the full error message as a text file, and screenshot as well.
Please advise.

TokBox error.txt

Hi,
I also having the same issue with release build. App is crashing while starting audio or video call. Development build its not crashing. Please suggest the solution for this.

Hi there.
The app exits when opening the video call on release mode only.
I have investigated then found where the issue is, I have found the issues, the issue is: No pending exception expected: java.lang.ClassNotFoundException: com.opentok.android.SubscriberKit$SubscriberAudioStats.
I have attached the full error message as a text file, and screenshot as well.
Please advise.

TokBox error.txt

Hi bilalsammour,
Just add below code to you proguard-rule file of your project. Its fixed crash in my kotlin project.
opentok
-keep class com.opentok.android.v3.** { ; }
-keep class com.opentok.android.v3.$ { ; }
-keep public class * extends com.opentok.android.v3.OpentokException
-keep class com.opentok.android. { ; }
-keep class com.opentok.android.Session { ; }
-keep class com.opentok.client. { ; }
-keep class com.opentok.impl.* { ; }
-keep class com.opentok.otc.* { ; }
-keep class org.webrtc.* { ; }
-keep class org.otwebrtc.* { ; }
-keep class org.otwebrtc.voiceengine.* { ; }
-keep class org.otwebrtc.WebRtcClassLoader {;}
-keep class org.otwebrtc.voiceengine61.** { *; }
-keep class org.otwebrtc.voiceengine.BuildInfo { *; }
-dontwarn com.opentok.**
-keepclassmembers class com.opentok.** { *; }

Hi,
I also having the same issue with release build. App is crashing while starting audio or video call. Development build its not crashing. Please suggest the solution for this.

I found a workaround to fix the issue:

Open app build.gradle.
Under buildTypes then release, add the following at the end:

minifyEnabled false
shrinkResources false

useProguard true
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'

Create proguard-rules.pro file to be in the same folder with build.gradle.
In the created file add the following line:

-keep class androidx.lifecycle.DefaultLifecycleObserver
That is it.

Do you guys consider to have example with the obfuscation rules?
Do you guys consider to ship with obfuscation rules inside aar file?

Hi there.
The app exits when opening the video call on release mode only.
I have investigated then found where the issue is, I have found the issues, the issue is: No pending exception expected: java.lang.ClassNotFoundException: com.opentok.android.SubscriberKit$SubscriberAudioStats.
I have attached the full error message as a text file, and screenshot as well.
Please advise.

TokBox error.txt

Hi bilalsammour, Just add below code to you proguard-rule file of your project. Its fixed crash in my kotlin project.
opentok
-keep class com.opentok.android.v3.** { ; } -keep class com.opentok.android.v3.$ { ; } -keep public class * extends com.opentok.android.v3.OpentokException -keep class com.opentok.android. { ; } -keep class com.opentok.android.Session { ; } -keep class com.opentok.client. { ; } -keep class com.opentok.impl.* { ; } -keep class com.opentok.otc.* { ; } -keep class org.webrtc.* { ; } -keep class org.otwebrtc.* { ; } -keep class org.otwebrtc.voiceengine.* { ; } -keep class org.otwebrtc.WebRtcClassLoader {;} -keep class org.otwebrtc.voiceengine61.** { *; } -keep class org.otwebrtc.voiceengine.BuildInfo { *; }
-dontwarn com.opentok.** -keepclassmembers class com.opentok.** { *; }

i getting error like this

useProguard was removed in gradle 7.0.0. If you're using gradle >7.0.0 just add the following lines under buildTypes :
minifyEnabled false
shrinkResources false


Waits till we receive mesos state.json before rendering Node detail.

Sometimes going to the Node detail page would throw an exception because the request for mesos state took too long and we weren't waiting for it before rendering.

run unit tests

Looks good to me 👍  💯


add link to record in the broker

i.e. for a selected record, a link to view it in the broker
open in new window

link opens in new window, todo: add link to record in broker as well. Might not be possible as we're using the API


update page to reflect defender for endpoint plan 1 and 2

update page to reflect defender for endpoint plan 1 and 2

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf5df26b-9563-4810-f5b8-6997c9baa27c
Version Independent ID: 006f5550-36b6-1de7-d3a5-63b85241df03
Content: Microsoft Defender for Endpoint Device Control Device Installation
Content Source: microsoft-365/security/defender-endpoint/mde-device-control-device-installation.md
Product: m365-security
Technology: mde
GitHub Login: @Lovina-Saldanha
Microsoft Alias: v-lsaldanha

@Lovina-Saldanha and @tewang Please update. Thanks

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


fix: module-duplicate-type

For now, I just added the test failing... Now I need to code the fix.
Description
In one module if you declare a type and extend the type (in another file of the same module), codegen will generate 2 times the same type and will generate an invalid file.
Related https://github.com/dotansimha/graphql-code-generator/issues/6534
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

With a Unit test

Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@dotansimha @kamilkisiela, I added a test for this issue and it's passing (at least locally, let's see the CI now 😉)
I tested also in my project, and it's working too.
So, ready to merge 👨💻

@jycouet no need to wait for Dotan!

Thx @kamilkisiela.
BTW, we can close the issue?
How can we know in what version this fix will fall into? 😁


AOC Slash Command

Converts ?aoc slash command to /aoc. Near the end of the slash command migration.

Broke something, out of time. Fixing later

Solved by #254


Revisit ARG descriptions and calling syntax

We should change the ARG tutorial to say that msprime's record_full_arg is now simply a shorthand for additional_nodes = msprime.NodeType.COMMON_ANCESTOR | msprime.NodeType.RECOMBINANT.
Additionally, in a few places in the tutorials, we don't really make the argument clearly enough that a tree sequence can represent ARGs. E.g.

Note: The genetic genealogy is sometimes referred to as an ancestral recombination graph, or ARG, and there are close similarities between ARGs and tree sequences (see the ARG tutorial)

We should probably say

Note: The genetic genealogy is sometimes referred to as an ancestral recombination graph, or ARG. One way to describe a tree sequence is that it provides a way of storing various different sorts of ARGs (see the ARG tutorial)

I noticed this slight confusion in the SpARG preprint, for example, where they say:

An ARG contains the complete genetic history of a sample of recombining genomes (Griffiths and Marjoram, 1996; Hudson, 1983; Lewanski et al., 2023). It is commonly displayed as 1) a sequence of trees with each tree representing the history of a continuous block of the genome or 2) a single directed acyclic graph with annotated edges corresponding to their genomic intervals (see Fig 5A for an example of each). While the two representations can be interchangeable, tree sequences often lack the recombination events that tie the trees together and are further simplified, removing this equivalency (Wong et al., 2023).

This equates "tree sequence" with "sequence of trees"

Do we want to move to using msprime.sim_ancestry(additional_nodes = msprime.NodeType.COMMON_ANCESTOR | msprime.NodeType.RECOMBINANT) in the arg tutorial, or simply point out that msprime.sim_ancestry(record_full_arg=True) is a shorthand. In other words, are we trying to steer people away from record_full_arg now?

I don't really mind to be honest. I don't think we'll bother formally deprecating record_full_arg though.


Fix issue when version pinning packages that are checked by the configvalidator tool

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[ ] The toolchain has been rebuilt successfully (or no changes were made to it)
[ ] The toolchain/worker package manifests are up-to-date
[ ] Any updated packages successfully build (or no packages were changed)
[ ] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[ ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[ ] All package sources are available
[ ] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[ ] LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
[ ] All source files have up-to-date hashes in the *.signatures.json files
[ ] sudo make go-tidy-all and sudo make go-test-coverage pass
[ ] Documentation has been updated to match any changes to the build system
[ ] Ready to merge

Summary

Several features require specific packages also be installed to function (selinux, fips, etc.). One of these is shadow-utils which is needed for user changes.
We also have an undocumented feature where you can pin packages to specific versions in a package list via "pkg-name = 1.2.3-4". These two features conflict with each other since the validator assumed only basic package names would be used.
Also flesh out the unit tests a bit for the validator and rely less on using the built-in configs and instead use a dedicated test config file.
There is a limitation however, we cannot distinguish between pkg-long-name and pkg-version-release even though tdnf will accept that, so that will still be passed to the check verbatim and will fail. The form pkg = version-release should be used instead.
Change Log

Support version pinning in image configs for validated packages (selinux, fips, shadow-utils).
Fix up the validator unit tests

Does this affect the toolchain?

NO
Associated issues

https://microsoft.visualstudio.com/OS/_queries/edit/55399616/?triage=true

Test Methodology

local testing
pipeline tbd

Changes seem reasonable to me; have you been able to confirm that they do, in fact, now permit the config used by the bug finder?
Also, thanks for taking the time to improve the tests while you were at it. Always love to see us leaving the code better than we found it!

Changes seem reasonable to me; have you been able to confirm that they do, in fact, now permit the config used by the bug finder?
Also, thanks for taking the time to improve the tests while you were at it. Always love to see us leaving the code better than we found it!

The specific branch that broke is gone, but I was able to dig up a similar config. It looks like it should pass fine now.

Queued a delta build to check that all the built-in images build ok: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=695490&view=results


ModelResolver throws an exception if a property name equals "is" or "get"

If the entire name of a property is just "is" or "get", you'll get an exception from line 249 or 253 of ModelResolver because it's trying to parse it as a bean accessor name without length-checking. (Seen on develop_2.0 branch)

Fixed in develop_2.0.


GULNetworkURLSession crashes

Environment

Xcode version: 10.0 (10A255)
Firebase SDK version: 5.10.0
Firebase Component: Utilities (Auth, Core, Database, Firestore, Messaging, Storage, etc)
Component version: 5.3.2

Problem
App crashes in GULNetworkURLSession, line 162. Code:
// Save the session into memory.
NSMapTable *sessionIdentifierToFetcherMap = [[self class] sessionIDToFetcherMap];
[sessionIdentifierToFetcherMap setObject:self forKey:_sessionID];

Log output:
malloc: *** error for object 0x6000014bc080: pointer being freed was not allocated
malloc: *** set a breakpoint in malloc_error_break to debug

Steps to reproduce:
Crash occurs on startup but not every time. It happens very often when running unit tests.
We have 26k crashes affecting 18k users.
It was introduced in version using Firebase v5.8.0 and GoogleUtilities v5.2.0. Preceding version used Firebase v4.13.0 (no GoogleUtilities) and everything worked well.
Crash log:
#14. Crashed: com.apple.root.background-qos
0  libsystem_kernel.dylib         0x20686d104 __pthread_kill + 8
1  libsystem_pthread.dylib        0x2068eca00 pthread_kill$VARIANT$armv81 + 296
2  libsystem_c.dylib              0x2067c4d78 abort + 140
3  libsystem_malloc.dylib         0x2068c1768 _malloc_put + 570
4  libsystem_malloc.dylib         0x2068c1924 malloc_report + 64
5  libsystem_malloc.dylib         0x2068b42d0 free + 376
6  Foundation                     0x20765f2d8 -[NSConcreteMapTable grow] + 740
7  Foundation                     0x207651000 -[NSConcreteMapTable setObject:forKey:] + 168
8  GoogleUtilities                0x1057ed3c4 -[GULNetworkURLSession sessionIDFromAsyncPOSTRequest:completionHandler:] (GULNetworkURLSession.m:160)
9  GoogleUtilities                0x1057eb454 -[GULNetwork postURL:payload:queue:usingBackgroundSession:completionHandler:] (GULNetwork.m:143)
10 SofascoreCommon                0x106141488 -[FIRClearcutLogger sendNextPendingRequestWithCompletionHandler:] + 16248
11 SofascoreCommon                0x1061416f0 __65-[FIRClearcutLogger sendNextPendingRequestWithCompletionHandler:]_block_invoke + 16864
12 libdispatch.dylib              0x20670f6c8 _dispatch_call_block_and_release + 24
13 libdispatch.dylib              0x206710484 _dispatch_client_callout + 16
14 libdispatch.dylib              0x2066f2c24 _dispatch_root_queue_drain + 640
15 libdispatch.dylib              0x2066f335c _dispatch_worker_thread2 + 116
16 libsystem_pthread.dylib        0x2068f2190 _pthread_wqthread + 472
17 libsystem_pthread.dylib        0x2068f4d00 start_wqthread + 4

@domagojstankovic can you set a breakpoint in malloc_error_break and send the stack trace? (Or alternatively share your project + unit tests)

@morganchen12  This is the stack trace when breakpoint in malloc_error_break is hit:
    frame #0: 0x0000000110d880bc libsystem_malloc.dylib`malloc_error_break
    frame #1: 0x0000000110d96678 libsystem_malloc.dylib`malloc_vreport + 437
    frame #2: 0x0000000110d968d5 libsystem_malloc.dylib`malloc_report + 152
    frame #3: 0x0000000109f60d3d Foundation`-[NSConcreteMapTable grow] + 930
    frame #4: 0x0000000109f60f39 Foundation`-[NSConcreteMapTable setObject:forKey:] + 164
    frame #5: 0x000000010a6685a6 GoogleUtilities`-[GULNetworkURLSession sessionIDFromAsyncPOSTRequest:completionHandler:](self=0x0000600000290190, _cmd="sessionIDFromAsyncPOSTRequest:completionHandler:", request=0x00006000021ee680, handler=0x000000010a664e90) at GULNetworkURLSession.m:162
    frame #6: 0x000000010a664c64 GoogleUtilities`-[GULNetwork postURL:payload:queue:usingBackgroundSession:completionHandler:](self=0x0000600003af85c0, _cmd="postURL:payload:queue:usingBackgroundSession:completionHandler:", url=@"https://play.googleapis.com/log", payload=268 bytes, queue=0x0000000110b35c80, usingBackgroundSession=NO, handler=0x000000010e5ba979) at GULNetwork.m:143
    frame #7: 0x000000010e5ba7f6 SofascoreAppIntentsKit`-[FIRClearcutLogger sendNextPendingRequestWithCompletionHandler:] + 540
    frame #8: 0x0000000110ae551d libdispatch.dylib`_dispatch_call_block_and_release + 12
    frame #9: 0x0000000110ae6587 libdispatch.dylib`_dispatch_client_callout + 8
    frame #10: 0x0000000110aed058 libdispatch.dylib`_dispatch_lane_serial_drain + 720
    frame #11: 0x0000000110aedb9b libdispatch.dylib`_dispatch_lane_invoke + 401
    frame #12: 0x0000000110af69c6 libdispatch.dylib`_dispatch_workloop_worker_thread + 645
    frame #13: 0x0000000110ecf61c libsystem_pthread.dylib`_pthread_wqthread + 409
    frame #14: 0x0000000110ecf415 libsystem_pthread.dylib`start_wqthread + 13

Having the same issue here

same issue here

I am sorry I can't provide a sample project right now (I can try to create one next week if I have some spare time).
About the iOS versions, I've seen it in iOS 11 and 12.

@ryanwilson all versions are affected. iOS 10 is the minimum iOS version we support.

@ryanwilson @morganchen12 once memory leak fix applied https://github.com/firebase/firebase-ios-sdk/pull/1933 we only get a crash on iOS12 (so far) on this line
[GULNetworkURLSession setSessionInFetcherMap:forSessionID:]

I suspect a thread safety issue. What happens if two threads call setSessionInFetcherMap at the same time?

This issue is happening again in GoogleUtilities (5.5.0)

@nyeu Please open a new issue with the stack trace.


Opening Blockquotes not showing up

See: http://alistapart.com/article/responsive-web-design

Found it — EE truncated this field's name without mentioning it to us.


Feedback: Home page

First version of the home page: https://eahub.azurewebsites.net/
Currently with dummy icons.
Please leave feedback in the comments, I'll try to implement them

Looks good. This is what I see in Chrome on MacOS 10.14.2 I would suggest just adding a little more space between the logo and drop down menu and the image. It's a bit squashed right now. The drop down menu will need to be opaque I think. I would suggest making it either very very light grey with black text or the lighter purple from the set site colour pallette. Icons plus text are fine for size but obviously will need to be arranged more symmetrically.  Thanks!

The caption is currently grammatically incorrect. It should be 'Join over 1700' rather than 'Join the over'. But actually I think that what would be more conventional and appropriate for a site like this is to say 'Join 1700 + EAs from around the world'. The plus icon makes 'over' unnecessary.

Is that figure accurate Manoj?


Add github link

Added link to the official GitHub repository of Deformable Neural Radiance Fields.

Thank you!


Emmet fails everywhere

Hello team,
I notice problems with emmet.
when I type ul>li, I get (by tab) :
ul><'li><'/li>*
*without " ' " => code is interpreted
when I type nav>section.sth OR  article.sth
it does nothing (a tab)
I thought it were some conflicts with my installed packages, but when I disable it, the bug persists.
Any idea about that problem ?
Thanks.

https://github.com/emmetio/emmet-atom#tab-key

Sorry, OK, I didn't see this.
But it helps me not completely : how can I open "DevTools"?

Sorry, I didn't see this. Thank you very much.


Blacklist gulp-install

Does not follow plugin patterns at all.
https://github.com/slushjs/gulp-install

Closing this because the plugin page has been rewritten and integrated with our main website: https://github.com/gulpjs/gulpjs.github.io
The blacklist isn't currently applied to the new plugin page. It is still used by --verify but that might change soon.


Little bit of cleanup

Here's just a bit of cleanup on the web site.

Thanks for the corrections, but The HTML files have been fully generated from markdown source files using mkdocs, so the source files should be fixed instead of generated ones, and indent or spaces in generated html should not be corrected.
It means that gh-page branch of skale-engine should never receive fixes directly.
I realize also that the sources of the doc site are not available yet in github. Let me publish the source doc project first before submitting fixes, sorry for the annoyance.

No worries.  I thought that might actually be the case.


@name@ and @title@ not set in script.html rendering

Notice the "undefined" title in the toolbar. Seems that the backend is not setting those constants.

repro:  https://pxt.microbit.org/76163-68307-61679-20354

fixed now


python312Packages.textual: 0.53.1 -> 0.65.1

Diff: https://github.com/Textualize/textual/compare/refs/tags/v0.53.1...v0.65.1
Changelog: https://github.com/Textualize/textual/releases/tag/v0.65.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 317678 run on x86_64-linux 1

42 packages built:

browsr
browsr.dist
dooit
dooit.dist
frogmouth
frogmouth.dist
oterm
oterm.dist
python311Packages.manifestoo
python311Packages.manifestoo.dist
python311Packages.pytest-textual-snapshot
python311Packages.pytest-textual-snapshot.dist
python311Packages.rich-pixels
python311Packages.rich-pixels.dist
python311Packages.textual
python311Packages.textual-dev
python311Packages.textual-dev.dist
python311Packages.textual-universal-directorytree
python311Packages.textual-universal-directorytree.dist
python311Packages.textual.dist
python312Packages.manifestoo
python312Packages.manifestoo.dist
python312Packages.pytest-textual-snapshot
python312Packages.pytest-textual-snapshot.dist
python312Packages.rich-pixels
python312Packages.rich-pixels.dist
python312Packages.textual
python312Packages.textual-dev
python312Packages.textual-dev.dist
python312Packages.textual-universal-directorytree
python312Packages.textual-universal-directorytree.dist
python312Packages.textual.dist
rich-cli
rich-cli.dist
smassh
smassh.dist
tftui
tftui.dist
upiano
upiano.dist
wsrepl
wsrepl.dist


Implements ServiceAnsiblePlaybook and spec tests

Implement the logic to order the Ansible playbook service that required by the state machine.
https://www.pivotaltracker.com/story/show/139012105

@mkanoor @tinaafitz Please review

👍


Default setting for Rule

Is the statement "By default, the Repair Automatically option is enabled for this rule" correct? in my farms this is DISABLED by default

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59fa2ba1-01a4-d787-e7d8-7734686c55c8
Version Independent ID: dc2de12e-3433-0f4f-dee3-e42d092d6d66
Content: One of the cache hosts in the cluster is down (SharePoint Server)
Content Source: SharePoint/SharePointServer/technical-reference/one-of-the-cache-hosts-in-the-cluster-is-down.md
Service: unspecified
GitHub Login: @bentoncity
Microsoft Alias: stevhord

It is set as default, so not sure what has turned this off for you. Follow the procedure at end of this topic to turn it back on.

When I go to the Monitoring page, this rule is in the Availability category instead of the Configuration category as documented above.  Which is correct, my 2016 farm, or this documentation?

The Availability category is correct for 2016/2013. I've updated the doc. Repair automatically is enabled by default.

Updated correct Category to show Availability and republished topic.


Use link blocking

http://uxmovement.com/buttons/how-link-blocking-can-increase-your-click-through-rate/

Moved to nicolasmccurdy/nicolasmccurdy.github.io#51.


[documentation] Auto-generate Kagami docs from clap

Description
The documentation for Kagami (in its README) is outdated. It will be even more outdated after the merge of #3475.
Your suggestions
Use clap-markdown or similar tool.

After a discussion with the team, we decided that it doesn't worth to have Kagami Markdown-rendered documentation at all. Since it is a CLI utility app with no stable API (at least for now), it isn't worth effort to keep the documentation up-to-date with manual approach. As for automatic approach, #3510 shown that it doesn't work well: if we focus on Markdown-oriented help message, we have to sacrifice the usability of CLI-oriented help message. We decided that CLI interface has a higher priority.


Spawned single-user Notebook is unable to connect to the Jupyterhub API

Hi,
Thanks for the very nice description on how to setup a jupyterHub using docker, it seems like a perfect middle ground between the Kubernetes and tljh solutions.
Unfortunately I'm unable to get it setup properly because I'm receiving the following error after logging in on the spawned Jupyter notebook
`[... SingleUserNotebookApp singleuser:389] Failed to connect to my Hub at http://jupyterhub:8081/hub/api (attempt 1/5). Is it running?``
Eventually it times out after five tries. I've made minor changes to the docker-compose.yml file namely the traefik.frontend.rule and I've removed the oath2_server as for now I'm going to use the PAM authenticator (eventually using NIS).
Something I've noticed in the logs from running docker-compose up:
Adding default route for Hub: / => http://jupyterhub:8081 jupyterhub       | info: [ConfigProxy] Adding route / -> http://jupyterhub:8081 jupyterhub       | info: [ConfigProxy] 201 POST /api/routes/  jupyterhub       | JupyterHub app:1912] JupyterHub is now running at http://:8000
while the last address is invalid, the hub is working and I can login using a user account I manually add by attaching to the hub process (I'm using portainer for those tasks).
If you have any idea what might cause this or if there is anything I can try to get more information, I would really appreciate this.

Looks like the spawned Jupyter server cannot talk back to the Hub. This line is passing the Hub address to the spawned servers:
https://github.com/defeo/jupyterhub-docker/blob/master/jupyterhub/jupyterhub_config.py#L38
The value of HUB_IP being set here:
https://github.com/defeo/jupyterhub-docker/blob/master/docker-compose.yml#L14
The value must match the name of the container in docker-compose.yml:
https://github.com/defeo/jupyterhub-docker/blob/master/docker-compose.yml#L7
Maybe you changed something? Post your docker-compose.yml here, I'll tell you if I see something.


How to choose when to add depency to lib or project folder?

Can you explain when to use `make abi-add' or just 'make add' @Dr0p42 ?

Can you explain when to use `make abi-add' or just 'make add' @Dr0p42 ?

make abi-add are the lib necessary for abi lib and make add dep  for the integrations/workflows in src/


Error loading discovery document: "Http" - "Error connecting to https://api.xyz.com/.well-known/openid-configuration: Not Found"

The API I am calling using OAuth 2.0 does not have this document and I am wondering if there is a way to make it bypass checking for this document and what needs to be supplied that it might have retrieved from the document if not found.
I have tried various items that seemed to make sense to me such as options.RefreshDiscoveryDocumentForLogin = false; but that didn't help.
Thank you in advance for any assistance.

The API I am calling using OAuth 2.0 does not have this document

Then you are using the wrong library. As the name implies this is about OpenID Connect.
Try the plain IdentityModel library which has support for the OAuth primitives.
https://github.com/IdentityModel/IdentityModel2

Thank you so much for the information, I will give the other library a try. I had read this "OidcClient is an implementation of the OIDC/OAuth 2 for native apps specification for C#." in the description and thought it applied to OAuth 2.0 as well. From my additional reading I see that the two, OIDC and OAuth 2.0, are related and understand the description better.


Build failing on CircleCI from demo circle.yml

Running the example circle.yml in the docs with a fresh repo and CircleCI account keeps failing.
Failing command: cd Stout; godep go build -o ../stout src/*.go
Exit code: 1
Output:
godep: [WARNING]: godep should only be used inside a valid go package directory and
godep: [WARNING]: may not function correctly. You are probably outside of your $GOPATH.
godep: [WARNING]:	Current Directory: /home/ubuntu/landing/Stout
godep: [WARNING]:	$GOPATH: /home/ubuntu/.go_workspace:/usr/local/go_workspace
src/deploy.go:20:2: cannot find package "github.com/cenk/backoff" in any of:
	/usr/local/go/src/github.com/cenk/backoff (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/cenk/backoff (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/cenk/backoff
	/usr/local/go_workspace/src/github.com/cenk/backoff
src/utils.go:12:2: cannot find package "github.com/imdario/mergo" in any of:
	/usr/local/go/src/github.com/imdario/mergo (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/imdario/mergo (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/imdario/mergo
	/usr/local/go_workspace/src/github.com/imdario/mergo
src/utils.go:13:2: cannot find package "github.com/mitchellh/go-homedir" in any of:
	/usr/local/go/src/github.com/mitchellh/go-homedir (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/mitchellh/go-homedir (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/mitchellh/go-homedir
	/usr/local/go_workspace/src/github.com/mitchellh/go-homedir
src/deploy.go:25:2: cannot find package "github.com/wsxiaoys/terminal/color" in any of:
	/usr/local/go/src/github.com/wsxiaoys/terminal/color (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/wsxiaoys/terminal/color (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/wsxiaoys/terminal/color
	/usr/local/go_workspace/src/github.com/wsxiaoys/terminal/color
src/utils.go:14:2: cannot find package "github.com/zackbloom/go-ini" in any of:
	/usr/local/go/src/github.com/zackbloom/go-ini (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/zackbloom/go-ini (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/zackbloom/go-ini
	/usr/local/go_workspace/src/github.com/zackbloom/go-ini
src/utils.go:15:2: cannot find package "github.com/zackbloom/goamz/aws" in any of:
	/usr/local/go/src/github.com/zackbloom/goamz/aws (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/zackbloom/goamz/aws (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/zackbloom/goamz/aws
	/usr/local/go_workspace/src/github.com/zackbloom/goamz/aws
src/admin.go:9:2: cannot find package "github.com/zackbloom/goamz/cloudfront" in any of:
	/usr/local/go/src/github.com/zackbloom/goamz/cloudfront (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/zackbloom/goamz/cloudfront (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/zackbloom/goamz/cloudfront
	/usr/local/go_workspace/src/github.com/zackbloom/goamz/cloudfront
src/admin.go:10:2: cannot find package "github.com/zackbloom/goamz/iam" in any of:
	/usr/local/go/src/github.com/zackbloom/goamz/iam (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/zackbloom/goamz/iam (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/zackbloom/goamz/iam
	/usr/local/go_workspace/src/github.com/zackbloom/goamz/iam
src/admin.go:11:2: cannot find package "github.com/zackbloom/goamz/route53" in any of:
	/usr/local/go/src/github.com/zackbloom/goamz/route53 (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/zackbloom/goamz/route53 (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/zackbloom/goamz/route53
	/usr/local/go_workspace/src/github.com/zackbloom/goamz/route53
src/admin.go:12:2: cannot find package "github.com/zackbloom/goamz/s3" in any of:
	/usr/local/go/src/github.com/zackbloom/goamz/s3 (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/github.com/zackbloom/goamz/s3 (from $GOPATH)
	/home/ubuntu/.go_workspace/src/github.com/zackbloom/goamz/s3
	/usr/local/go_workspace/src/github.com/zackbloom/goamz/s3
src/admin.go:13:2: cannot find package "golang.org/x/crypto/ssh/terminal" in any of:
	/usr/local/go/src/golang.org/x/crypto/ssh/terminal (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/golang.org/x/crypto/ssh/terminal (from $GOPATH)
	/home/ubuntu/.go_workspace/src/golang.org/x/crypto/ssh/terminal
	/usr/local/go_workspace/src/golang.org/x/crypto/ssh/terminal
src/deploy.go:21:2: cannot find package "golang.org/x/net/html" in any of:
	/usr/local/go/src/golang.org/x/net/html (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/golang.org/x/net/html (from $GOPATH)
	/home/ubuntu/.go_workspace/src/golang.org/x/net/html
	/usr/local/go_workspace/src/golang.org/x/net/html
src/admin.go:14:2: cannot find package "golang.org/x/net/publicsuffix" in any of:
	/usr/local/go/src/golang.org/x/net/publicsuffix (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/golang.org/x/net/publicsuffix (from $GOPATH)
	/home/ubuntu/.go_workspace/src/golang.org/x/net/publicsuffix
	/usr/local/go_workspace/src/golang.org/x/net/publicsuffix
src/utils.go:20:2: cannot find package "gopkg.in/yaml.v1" in any of:
	/usr/local/go/src/gopkg.in/yaml.v1 (from $GOROOT)
	/home/ubuntu/landing/Stout/Godeps/_workspace/src/gopkg.in/yaml.v1 (from $GOPATH)
	/home/ubuntu/.go_workspace/src/gopkg.in/yaml.v1
	/usr/local/go_workspace/src/gopkg.in/yaml.v1
godep: go exit status 1

cd Stout; godep go build -o ../stout src/*.go returned exit code 1
Action failed: cd Stout; godep go build -o ../stout src/*.go

@ajoslin I saw you had the same issues here. Did you resolve it?

@tmcpro I "solved" it by just downloading the binary release on CircleCI instead:
    - curl -Ls https://github.com/EagerIO/Stout/releases/download/v1.3.1/stout-linux > stout

Works flawlessly.

@ajoslin worked. Will make a PR tomorrow with updated CI files

@zackbloom no way to always get latest this way to download so will not update the readme.


A stream of a Table's rows should use a buffer, not allocate per-row

this will be handled in the b-table crate: https://github.com/haydnv/b-table/issues/1


Make some things serializable

👍

Codecov Report

Merging #25 into master will decrease coverage by 1.58%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   86.25%   84.67%   -1.59%
==========================================
  Files          13       13
  Lines         262      261       -1
  Branches       12       13       +1
==========================================
- Hits          226      221       -5
- Misses         36       40       +4

Impacted Files
Coverage Δ

core/src/main/scala/com/stripe/dagon/HMap.scala
95.45% <ø> (ø)
:arrow_up:

core/src/main/scala/com/stripe/dagon/Cache.scala
100% <ø> (ø)
:arrow_up:

core/src/main/scala/com/stripe/dagon/HCache.scala
100% <ø> (ø)
:arrow_up:

core/src/main/scala/com/stripe/dagon/Expr.scala
70% <ø> (ø)
:arrow_up:

...re/src/main/scala/com/stripe/dagon/FunctionK.scala
33.33% <ø> (ø)
:arrow_up:

core/src/main/scala/com/stripe/dagon/Dag.scala
90.97% <ø> (ø)
:arrow_up:

core/src/main/scala/com/stripe/dagon/Rule.scala
77.77% <ø> (ø)
:arrow_up:

core/src/main/scala/com/stripe/dagon/Literal.scala
61.9% <100%> (-19.92%)
:arrow_down:

core/src/main/scala/com/stripe/dagon/Id.scala
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac2f36...26f20f7. Read the comment docs.


Save the last opened Amp & IR

When we close nam in the standalone mode, we have to re-select the amp and IR models once we reopen it.
We would like if it stored the last used amp and the IR model automatically reloads once we open nam.
We could also have a default amp and IR model, i.e. you set it as default and it opens that combo when you open nam,

Needs #428


How to get Pod?

How to query pods that are not associated with a replica controller ? who can help me?

One way is to do that might be like that:
	pods, err := clientset.CoreV1().Pods("default").List(metav1.ListOptions{})

	for _, pod := range l.Items {
		isAssociatedWithRS := false
		for _, ref := range pod.ObjectMeta.OwnerReferences {
			isAssociatedWithRS = ref.Kind == "ReplicaSet"
		}

		if !isAssociatedWithRS {
			fmt.Println(pod.Name)
		}
	}

metav1.ListOptions{} Has fields like FieldSelector and LabelSelector, you can list pods for ex. by namespace like:
metav1.ListOptions{
  FieldSelector="metadata.namespace=default",
}

but I don't know how to do that for OwnerReferences.

closed


Create CONTRIBUTING.md

@jehchow Do you see this automatically?

@jehchow Do you see this automatically?

I get an email notification every time a PR is opened in this repo. However, because I'm an admin of several repos, I have emails filtered unless I'm being @ mentioned or someone comments #sign-off.


Modules signing

Motivation
We want to help our users to make sure they run code coming from the Falcosecurity project by enabling
Feature
Make so that the builder uses the kernel module signing facility: https://www.kernel.org/doc/html/v4.10/admin-guide/module-signing.html
Alternatives
Additional context

+1
L.
On Tue, Feb 18, 2020 at 6:08 PM Lorenzo Fontana<EMAIL_ADDRESS>wrote:

Motivation
We want to help our users to make sure they run code coming from the
Falcosecurity project by enabling
Feature
Make so that the builder uses the kernel module signing facility:
https://www.kernel.org/doc/html/v4.10/admin-guide/module-signing.html
Alternatives
Additional context
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/falcosecurity/build-service/issues/1?email_source=notifications&email_token=AAA5J4747HJJIHPWOLOXSHLRDQIYJA5CNFSM4KXIXGZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IOMI2OQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5J433WOYXZ63KV3X5AMDRDQIYJANCNFSM4KXIXGZQ
.

Strong +1 - Go! Let's make it happen.

+1

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Changes to "Edit Publication" pop-up

User testing showed that the link to UC publication management needs to be more prominent. I propose we change from how it currently looks (issue #17) to the design below:

I'm not sure what design ramifications this has for issue #16 yet. TBD.

Change link to pending publications: https://oapolicy.universityofcalifornia.edu/objects.html?as=3&am=false&cid=1&ipr=false&iqf=true


Update dependency

When I trying to run go get github.com/genjidb get this:
cannot find package "github.com/vmihailenco/msgpack/codes" in any of:
        /usr/local/go/src/github.com/vmihailenco/msgpack/codes (from $GOROOT)
        /home/kkudinov/go/src/github.com/vmihailenco/msgpack/codes (from $GOPATH)

github.com/vmihailenco/msgpack updated for v5. Please update genji to use this package.

Hi, thanks for the report! We are already using v5 but we need to update import paths for the latest commit (see https://github.com/vmihailenco/msgpack/commit/481cbe1dac1e13384a8115b41af2d84c3e05224c).
Also note that github.com/vmihailenco/msgpack release model is incompatible with GOPATH-mode (idiomatic way is to create v5 directory for the new release, see Go Modules: v2 and Beyond). That is, we can’t guarantee that this dependency won’t break in the future with GOPATH-mode. I suggest either migrating to Go modules or filing an issue in msgpack repo.

Closing this, don't hesitate to reopen if needed


Running Unit Tests

[x] updated all sample projects used in unit tests to net 7 or 8
[ ] make all unit tests pass

This is my tests results

This is actually how it looks like in my environment:

Yes all is pushed - do you have docker running in the background? Some tests use tye configs that spin up containers.
In any case, you clone locally and use as a control the original tye repo

I have docker, we need to add additional info to readme to have docker installed (add volume to appdata) and install azure function tools, tonight I will investigate it further.

2 tests are still not working. Downloading solution and installing all missing parts (e.g docker) gives 19 failing e2e test at starting point. Tests definitely doesn't provide fast feedback especially those e2e and are difficult to maintain, there are a lot of places to improve.

tests fixed, please check.

I don't see any comments, dapr installed from https://docs.dapr.io/getting-started/install-dapr-cli/ + dapr init.

they are inline in the conversation tab of the PR

I should finish a review

try now

close the issue?

@drakon660 i've merged de PR. thank you for the effort!
I'm working as we speak on #7 to get a working action pipeline that runs the tests.


Mega Support

There is an Open Source official command line tool:
https://github.com/meganz/MEGAcmd
Can u include ir to support Mega?

Sorry, no. That is completely different tool.


Webhook Race Condition with TLS handshake error: tls: bad certificate

Hoping to get some insight on the following issue. Happy to hop on a call or slack huddle in the knative slack to give more info.
Expected Behavior
The webhook should work and not require a non-deterministic amount of container restarts for it to work.
Actual Behavior
Using defaulting and validating webhooks for Karpenter CRDs. When first installing Karpenter, we get the following error in the webhook container logs. Even after receiving a failure, the webhook container stays ready. The issue is resolved sometimes by restarting the container a non-deterministic amount of times.
karpenter-6f84d7c89d-4246h webhook 2022/07/14 17:47:02 http: TLS handshake error from <IP_ADDRESS>:44004: remote error: tls: bad certificate
karpenter-6f84d7c89d-4246h webhook 2022/07/14 17:47:02 http: TLS handshake error from <IP_ADDRESS>:44006: remote error: tls: bad certificate

This webhook is further proven broken when it blocks creation of the CRD because the certificate is signed by an unknown authority.
Error from server (InternalError): error when creating "STDIN": Internal error occurred: failed calling webhook "validation.webhook.karpenter.k8s.aws": Post "[https://karpenter.karpenter.svc:443/?timeout=10s](https://karpenter.karpenter.svc/?timeout=10s)": x509: certificate signed by unknown authority

Here’s where this webhook was created in code that we started to see this issue after.
Steps to Reproduce the Problem

Install Karpenter with the webhook mentioned.
Watch webhook logs.

Additional Info
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.145Z	INFO	webhook.DefaultingWebhook	Starting controller and workers	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.145Z	INFO	webhook.DefaultingWebhook	Started workers	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.145Z	DEBUG	webhook.DefaultingWebhook	Processing from queue defaulting.webhook.karpenter.k8s.aws (depth: 1)	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.145Z	DEBUG	webhook.DefaultingWebhook	Processing from queue karpenter/karpenter-cert (depth: 0)	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.145610       1 leaderelection.go:243] attempting to acquire leader lease karpenter/webhook.validationwebhook.00-of-01...
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.146009       1 leaderelection.go:243] attempting to acquire leader lease karpenter/webhook.webhookcertificates.00-of-01...
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.146311       1 leaderelection.go:243] attempting to acquire leader lease karpenter/webhook.defaultingwebhook.00-of-01...
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.146585       1 leaderelection.go:243] attempting to acquire leader lease karpenter/webhook.validationwebhook.00-of-01...
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.146866       1 leaderelection.go:243] attempting to acquire leader lease karpenter/webhook.configmapwebhook.00-of-01...
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.147154       1 leaderelection.go:243] attempting to acquire leader lease karpenter/webhook.defaultingwebhook.00-of-01...
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.158486       1 leaderelection.go:253] successfully acquired lease karpenter/webhook.defaultingwebhook.00-of-01
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.158Z	INFO	webhook	"karpenter-6f84d7c89d-4246h_7349c3d9-0ba3-4bf1-94b3-0952c56f9be9" has started leading "webhook.defaultingwebhook.00-of-01"	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.158Z	DEBUG	webhook.DefaultingWebhook	Adding to the slow queue defaulting.webhook.provisioners.karpenter.sh (depth(total/slow): 1/1)	{"commit": "2c98771", "knative.dev/key": "/defaulting.webhook.provisioners.karpenter.sh"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.158Z	DEBUG	webhook.DefaultingWebhook	Processing from queue defaulting.webhook.provisioners.karpenter.sh (depth: 0)	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.159316       1 leaderelection.go:253] successfully acquired lease karpenter/webhook.configmapwebhook.00-of-01
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.159Z	INFO	webhook	"karpenter-6f84d7c89d-4246h_3422fdfa-830a-42e1-bfe5-323689e5641e" has started leading "webhook.configmapwebhook.00-of-01"	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.159Z	DEBUG	webhook.ConfigMapWebhook	Adding to the slow queue validation.webhook.config.karpenter.sh (depth(total/slow): 1/1)	{"commit": "2c98771", "knative.dev/key": "/validation.webhook.config.karpenter.sh"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.159Z	DEBUG	webhook.ConfigMapWebhook	Processing from queue validation.webhook.config.karpenter.sh (depth: 0)	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook E0714 17:46:46.159762       1 leaderelection.go:361] Failed to update lock: Operation cannot be fulfilled on leases.coordination.k8s.io "webhook.defaultingwebhook.00-of-01": the object has been modified; please apply your changes to the latest version and try again
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.159844       1 leaderelection.go:253] successfully acquired lease karpenter/webhook.validationwebhook.00-of-01
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.159Z	INFO	webhook	"karpenter-6f84d7c89d-4246h_a0c9c1f8-5016-4ebb-b738-f455dd699c48" has started leading "webhook.validationwebhook.00-of-01"	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.160Z	DEBUG	webhook.ValidationWebhook	Adding to the slow queue validation.webhook.karpenter.k8s.aws (depth(total/slow): 1/1)	{"commit": "2c98771", "knative.dev/key": "/validation.webhook.karpenter.k8s.aws"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.160Z	DEBUG	webhook.ValidationWebhook	Processing from queue validation.webhook.karpenter.k8s.aws (depth: 0)	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook I0714 17:46:46.160306       1 leaderelection.go:253] successfully acquired lease karpenter/webhook.webhookcertificates.00-of-01
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.160Z	INFO	webhook	"karpenter-6f84d7c89d-4246h_dafed312-0c03-4c85-9afc-9ab7842483ed" has started leading "webhook.webhookcertificates.00-of-01"	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.160Z	DEBUG	webhook.WebhookCertificates	Adding to the slow queue karpenter/karpenter-cert (depth(total/slow): 1/1)	{"commit": "2c98771", "knative.dev/key": "karpenter/karpenter-cert"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.160Z	DEBUG	webhook.WebhookCertificates	Processing from queue karpenter/karpenter-cert (depth: 0)	{"commit": "2c98771"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.160Z	INFO	webhook.WebhookCertificates	Reconcile succeeded	{"commit": "2c98771", "knative.dev/traceid": "36a77d14-41da-4ef7-bcaf-585fcbf0e45b", "knative.dev/key": "karpenter/karpenter-cert", "duration": "248.666µs"}
karpenter-6f84d7c89d-4246h webhook E0714 17:46:46.160932       1 leaderelection.go:361] Failed to update lock: Operation cannot be fulfilled on leases.coordination.k8s.io "webhook.validationwebhook.00-of-01": the object has been modified; please apply your changes to the latest version and try again
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.213Z	INFO	webhook.DefaultingWebhook	Updating webhook	{"commit": "2c98771", "knative.dev/traceid": "17354ae1-5148-439f-bde6-2c0bd820c9a8", "knative.dev/key": "defaulting.webhook.provisioners.karpenter.sh"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.218Z	INFO	webhook.ConfigMapWebhook	Webhook is valid	{"commit": "2c98771", "knative.dev/traceid": "54b1e742-648e-4d9e-ba37-dae50fbdf615", "knative.dev/key": "validation.webhook.config.karpenter.sh"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.218Z	INFO	webhook.ConfigMapWebhook	Reconcile succeeded	{"commit": "2c98771", "knative.dev/traceid": "54b1e742-648e-4d9e-ba37-dae50fbdf615", "knative.dev/key": "validation.webhook.config.karpenter.sh", "duration": "58.836021ms"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.310Z	INFO	webhook.ValidationWebhook	Updating webhook	{"commit": "2c98771", "knative.dev/traceid": "41feaed3-40f0-405c-afea-e44d1dc78c3d", "knative.dev/key": "validation.webhook.karpenter.k8s.aws"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.311Z	INFO	webhook.DefaultingWebhook	Reconcile succeeded	{"commit": "2c98771", "knative.dev/traceid": "17354ae1-5148-439f-bde6-2c0bd820c9a8", "knative.dev/key": "defaulting.webhook.provisioners.karpenter.sh", "duration": "152.813399ms"}
karpenter-6f84d7c89d-4246h webhook 2022-07-14T17:46:46.319Z	INFO	webhook.ValidationWebhook	Reconcile succeeded	{"commit": "2c98771", "knative.dev/traceid": "41feaed3-40f0-405c-afea-e44d1dc78c3d", "knative.dev/key": "validation.webhook.karpenter.k8s.aws", "duration": "159.026253ms"}
karpenter-6f84d7c89d-4246h webhook 2022/07/14 17:47:02 http: TLS handshake error from <IP_ADDRESS>:44004: remote error: tls: bad certificate
karpenter-6f84d7c89d-4246h webhook 2022/07/14 17:47:02 http: TLS handshake error from <IP_ADDRESS>:44006: remote error: tls: bad certificate

Typically knative webhooks on startup go through the following steps

Setup the TLS config of the webhook to look up the k8s secret from the informer (the secret name is hard coded as part of the webhook options)
Spin up a controller to reconcile the webhook certificate
Spin up a controller to reconcile the webhook configuration
Each controller tries to acquire a lease to become the leader
Once the lease is acquired perform the mutates (ie. cert controller creates a cert and updates the secret)

For this flow the webhooks need to be constructed with the certificate controller in addition with the default/validating admission controllers
ie. see: https://github.com/knative/serving/blob/c82be271867f137d0923be34acd18b6aca452446/cmd/webhook/main.go#L158-L172
If you're getting bad certificate I'm curious what cert is the webhook presenting and see what's defined in your CA bundle of the configured webhook (ie. ValidatingWebhookConfiguration and MutatingWebhookConfiguration)

The typical misconfiguration we see is if the liveness probe timeout of the webhook deployment is too low - it never gets a change to become the leader and create the certificate. This is because K8s kills the container.
ie. https://github.com/vmware-tanzu/sources-for-knative/issues/356
It's interesting to see bad certificate - that's a new one.

/reopen
/lifecycle frozen

@njtran just following up if this is still an issue. I haven't had time to dig into this but this might be a good-first-issue

Yep. Here are the webhook definitions for what I believe had the issue:

https://github.com/aws/karpenter/blob/v0.19.1/charts/karpenter/templates/webhooks.yaml
https://github.com/aws/karpenter/blob/v0.19.1/charts/karpenter/templates/webhooks-core.yaml

And here are the webhook definitions now, where I haven't seen the issue in a while.

https://github.com/aws/karpenter/blob/v0.27.0/charts/karpenter/templates/webhooks.yaml
https://github.com/aws/karpenter/blob/v0.27.0/charts/karpenter/templates/webhooks-core.yaml

Sometimes the issue has been because of an old unreachable webhook left around due to Argo CR syncing.
Maybe you see something different though?

We think it might be something to do with Argo syncing some old versions of webhooks. Have you heard anything like this?

Kind of having the same issue here.
Karpenter: v0.27.1
EKS: v1.25.6-eks-232056e
ArgoCD: v2.6.7+5bcd846
ERROR	webhook.WebhookCertificates	Reconcile error	{"commit": "7131be2-dirty", "knative.dev/traceid": "ce9f2f51-3ee5-4fdc-a1ce-19caa7807db5", "knative.dev/key": "karpenter/karpenter-cert", "duration": "45.405825ms", "error": "Operation cannot be fulfilled on secrets \"karpenter-cert\": the object has been modified; please apply your changes to the latest version and try again"}

I'm pretty sure I'm seeing this too:
Karpenter: v0.27.6
EKS: v1.25.12-eks-2d98532
ArgoCD: v2.8.3+77556d9
I'm seeing this while building out this cluster -- everything is "new" (no old versions of eks, karpenter, etc):
$ kubectl logs karpenter-provisioners-5cd99796cf-lrnbs -f
{"level":"info","ts":1695796080.7865567,"logger":"fallback","caller":"injection/injection.go:63","msg":"Starting informers..."}
2023/09/27 06:28:03 Registering 2 clients
2023/09/27 06:28:03 Registering 2 informer factories
2023/09/27 06:28:03 Registering 3 informers
2023/09/27 06:28:03 Registering 5 controllers
{"level":"INFO","time":"2023-09-27T06:28:03.864Z","logger":"controller","message":"Starting server","commit":"5a2fe84-dirty","path":"/metrics","kind":"metrics","addr":"[::]:8080"}
{"level":"INFO","time":"2023-09-27T06:28:03.867Z","logger":"controller","message":"Starting server","commit":"5a2fe84-dirty","kind":"health probe","addr":"[::]:8081"}
I0927 06:28:03.970155       1 leaderelection.go:248] attempting to acquire leader lease infra/karpenter-leader-election...
{"level":"INFO","time":"2023-09-27T06:28:04.009Z","logger":"controller","message":"Starting informers...","commit":"5a2fe84-dirty"}
2023/09/27 06:28:05 http: TLS handshake error from <IP_ADDRESS>:50520: remote error: tls: bad certificate
...


Apex Legends - Wine bridge fails to initialize with seemingly no error message

Hello, hope you're doing well.
I've managed to successfully install LatencyFleX for Overwatch 2 but for some reason Apex Legends has been giving me a some trouble.
Troubleshooting steps taken

I have triple checked that I installed everything correctly from the install instructions
I have gone through the troubleshooting step and nothing has been applicable up until "Checking if the Wine bridge successfully initialized"
I see that Loading latencyflex_layer.dll failed with error code: 1114 except unlike the troubleshooting steps guide, the only error code appears to be some unrelated NvAPI_QueryInterface:

Snippet of log file
DXVK_NVAPI_DRIVER_VERSION is set to '49729', reporting driver version 497.29 1326.498:0128:012c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\latencyflex_layer.dll" at<PHONE_NUMBER>850000: builtin 1326.498:0128:012c:trace:loaddll:free_modref Unloaded module L"C:\\windows\\system32\\latencyflex_layer.dll" : builtin Loading latencyflex_layer.dll failed with error code: 1114 NvAPI_Initialize: OK NvAPI_QueryInterface (0x33c7358c): Unknown function ID NvAPI_QueryInterface (0x593e8644): Unknown function ID NvAPI_D3D_SetSleepMode: No implementation
Please note that I have verified that both liblatencyflex_layer.so and latencyflex_layer.so have been installed correctly. Furthermore I haven't used a single symlink, every file has been copied manually to its respective install directory.
Some info that may be of relevance

I am using Proton-GE as opposed to Valve's proton
Proton-GE is installed onto my main drive, while Apex is installed on a separate drive
Proton-GE is up to date, so NVAPI v0.6 is installed

Please let me know if there is anything else I can provide to help out. Full log file is attached bellow.
steam-1172470.log

Hi, can you try finding toolmanifest.vdf in your Proton installation dir and replace it with https://github.com/ValveSoftware/Proton/blob/proton_7.0/toolmanifest_noruntime.vdf? That should disable the Steam container runtime which has been causing loading failures for some.

Worked like a charm, thanks a million for the swift reply and the help!


Keyboard shortcuts localization

Currently in Transifex two keyboard shortcut strings are hard coded, thus not translatable. These shortcuts. Don't mean anything for non English user, and will thus be harder to memorize. It'd be advisable to make them translatable.

String 1:
Del (or D) - Delete\nR - Reply\nA - Reply All\nC - Compose\nF - Forward\nM - Move\nV - Archive\nY - Copy\nZ - Mark (Un)read\nG - Star\nO - Sort type\nI - Sort order\nQ - Return to Folders\nS - Select/deselect\nJ or P - Previous Message\nK or N - Next Message
String 2:
Del (or D) - Delete\nC - Compose\nM - Move\nV - Archive\nY - Copy\nZ - Mark (Un)read\nG - Star\nO - Sort type\nI - Sort order\nQ - Return to Folders\nS - Select/deselect

To be clear, the strings can be translated. It's only the key/functionality mapping that is hardcoded.
Even in English some hotkeys have no relation to the name of the functionality they trigger, e.g. "Z - Mark (Un)read". So this is a very low priority item for me.

Closed as outdated.


add missing unlock

At most two imux_socket will be dial because of the missing unlock

Wow.  Thank you!  This has totally been just for fun and needs tests and cleanup.  How'd you feel about using a defer srtsMux.Unlock() right under the lock instead and removing the unlock at the bottom of the function?  Feels more "go".

@hkparker  Awesome work!  It help me improve the throughout of tunnel between USA server and server in  Mainland of China.
Yeah, It need more tests, I met some problems when using it.
defer is fine. Sorry for my poor english.

I want you to get credit for this, so update this pull request to use defer when you get the chance and I'll merge it.  I'm very glad to hear it has been helpful for you connecting from China, don't worry about the english I'm happy to have you helping out.  If you are having more problems let me know and I will take a look.

I updated this pull request to use defer.
The other proplems i will create issues or pull requests.

Thanks.  I'll merge this in now and follow up with a small change to your missing directory fix.  I think it makes sense to check for the directory and file separately, so if someone deletes the file but does not delete the directory, it will be re-created.

Done here: 222c46568fb46221639334536181164a14ee4375


Missing IPs

We are seeing MS Flow sending email from some IP addresses not listed on this page. Can we get it updated please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 845c4db9-1f3a-26d1-5061-c018cb1fe336
Version Independent ID: c2a03981-a0aa-64a5-2659-e10202e5bb14
Content: Limits and configuration - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-limits-and-config.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Please reach out directly and I will provide you a list of IPs that we are seeing in transport logs; but ideally you can also provide us with a complete list in use.

Hi @jakevis - Thank you for your feedback. IP addresses listed on this documentation are related to Logic Apps only, and not MS Flow.

@Mike-Ubezzi-MSFT  - per https://github.com/MicrosoftDocs/flow-docs/issues/88 (and the fact MS Flow sits ontop of logic apps), MS Flow can also use Logic App IPs. I dont really mind where the IPs are documented... but we need a solid list of them.

@jakevis Of course, we are now proceeding to assign this issue to the author to review further and take the right course of action.

@jakevis: Thanks for raising this issue. I'll investigate with the engineering team to see what we need to do.

@jakevis & @mike-urnun-msft: This issue is still in discussion on the engineering team alias.

@jakevis & @mike-urnun-msft: After investigating, engineering says the IP list is currently correct and will be updated pending future changes.
@mike-urnun-msft: #please-close

For anyone finding this in the future, we were seeing Mail originating from flow out of IP space <IP_ADDRESS>/18. This seems to be related to Flows use of the new graph APIs.
https://docs.microsoft.com/en-us/office365/enterprise/urls-and-ip-address-ranges#microsoft-365-common-and-office-online


Service Clients should use an implicit metric namespace

Right now ServiceClient is using the worker's namespace as its namespace.  It should be using an implicitly provided namespace instead.
Clients already require an implicit parameter, either a WorkerRef or an IOSystem depending on whether you're creating a callback or future-based client.  Having two implicits is starting to make things a bit more complicated, so we should also investigate if there's a way we can easily combine them into a single sort of "client environment" parameter without too much boilerplate or complexity.

@DanSimon @benblack86  Is this still relevant? How much of the info here is still true? I'm looking at ServiceClient here and the only implicit parameter I see passed into its constructor is a TagDecorator. At least at first glance, I'm not sure where else to find a namespace to pass into it.

I believe it is referring to this implicit: https://github.com/tumblr/colossus/blob/master/colossus/src/main/scala/colossus/service/ServiceClient.scala#L192
However, not sure why having it passed by the client would be useful.


metadata generation improvements

metadata generation routine can get the list of src/sig faster now by using just the signal dimension TABLE and not the big complicated VIEW to gather them
add sort_keys=True to json.dumps() to ensure deterministic output
add number of points to metadata for each aggregation since we are in there already...  and maybe avg number of re-issues to metadata if we wanna also hit the full table

https://github.com/cmu-delphi/delphi-epidata/blob/dev/src/acquisition/covidcast/database.py#L494

this should also include adding a "minimum issue" as described in https://github.com/cmu-delphi/delphi-epidata/issues/232


Updating mobile SDK doc to 0.0.2

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Review Error for vishnumad @ 2024-08-15 20:11:02 UTC
User must have write permissions to review


Atelier Rorona Plus ~The Alchemist of Arland~ [PCSE00466]

App summary

App name: ?
App serial: ?
App version: ?

Vita3K summary

Version: v?
Build number: ?
Commit hash: https://github.com/vita3k/vita3k/commit/[commit]
CPU backend:
GPU backend:

Test environment summary

Tested by: ?
OS: Windows/macOS/Linux Distro, Kernel Version?
CPU: AMD/Intel?
GPU: AMD/NVIDIA/Intel?
RAM: ? GB

Issues

Screenshots

Log

Recommended labels

A?
B?
C?

Sorry it just got create when i was exploring the git option on Android


After inita vite import fails

Describe the bug
After the basic setup (npm init slidev), you get a blank page due to an Internal Server Error.
9:15:28 AM [vite] Internal server error: Failed to resolve import "@vueuse/shared" from "node_modules/.vite/@vueuse_motion.js?v=bb77a074". Does the file exist?
  Plugin: vite:import-analysis
  File: .../test/node_modules/.vite/@vueuse_motion.js?v=bb77a074

To Reproduce
Steps to reproduce the behavior:

Execute npm init slidev
Go through the setup
Execute npm install
Execute npm run dev
See the blank page
See the Error in the console

Desktop (please complete the following information):

OS: Linux 5.13.0-7614-generic (Pop!_OS 21.04)
Browser: Firefox 92.0
Slidev version: v0.25.4
Node: v14.15.0
npm: 7.9.0

9:15:28 AM [vite] Internal server error: Failed to resolve import "@vueuse/shared" from "node_modules/.vite/@vueuse_motion.js?v=bb77a074". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/user/Test/test/node_modules/.vite/@vueuse_motion.js?v=bb77a074
  178|
  179|  //<EMAIL_ADDRESS>  180|  import { tryOnUnmounted as tryOnUnmounted2, isFunction as isFunction2 } from "@vueuse/shared";
     |                                                                                ^
  181|
  182|  // node_modules/popmotion/node_modules/tslib/tslib.es6.js
      at formatError (/home/user/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:50163:46)
      at TransformContext.error (/home/user/Documents/Slidev/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:50159:19)
      at normalizeUrl (/home/user/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:75881:26)
      at async TransformContext.transform (/home/user/Documents/Slidev/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:76016:57)
      at async Object.transform (/home/user/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:50373:30)
      at async transformRequest (/home/user/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:65414:29)
      at async viteTransformMiddleware (/home/user/Test/test/node_modules/vite/dist/node/chunks/dep-36bf480c.js:65542:32) (x3)

Could reproduce with the proposed way.

Hey @OddDev, here is a quick Fix I found :
In you package.json replace
 "dependencies": {
    "@slidev/cli": "^0.0.0-alpha.56",
    "@slidev/theme-default": "^0.0.0-alpha.56",
    "@slidev/theme-seriph": "^0.0.0-alpha.56"
  }

with
"dependencies": {
    "@slidev/cli": "0.25.4",
    "@slidev/theme-default": "0.21.0",
    "@slidev/theme-seriph": "0.21.0"
  }

Then run in your project's folder : rm -rf node_modules && npm i

Hey @OddDev, here is a quick Fix I found :
In you package.json replace
 "dependencies": {
    "@slidev/cli": "^0.0.0-alpha.56",
    "@slidev/theme-default": "^0.0.0-alpha.56",
    "@slidev/theme-seriph": "^0.0.0-alpha.56"
  }

with
"dependencies": {
    "@slidev/cli": "0.25.4",
    "@slidev/theme-default": "0.21.0",
    "@slidev/theme-seriph": "0.21.0"
  }

Then run in your project's folder : rm -rf node_modules && npm i

Hey, the right (or at least not the alpha version ones) dependencies are referenced in the npm initializer template. And it's also executed correctly. Meaning my package.json looks like this:
{
  "private": true,
  "scripts": {
    "build": "slidev build",
    "dev": "slidev --open",
    "export": "slidev export"
  },
  "dependencies": {
    "@slidev/cli": "^0.25.4",
    "@slidev/theme-default": "*",
    "@slidev/theme-seriph": "*"
  },
  "name": "test"
}

For the record, after installing @vueuse/shared with npm install @vueuse/shared I'm getting the following error:
[commonjs] Unexpected token (26:363439) in /Users/skarlso/goprojects/kube-cluster-sample/presentation/kube/node_modules/mermaid/dist/mermaid.min.js

Can you try pnpm or yarn? This is really weird to me as I can't actually reproduce it.

Can you try pnpm or yarn? This is really weird to me as I can't actually reproduce it.

Same with pnpm:
🦦pnpm init slidev
Need to install the following packages:
  create-slidev
Ok to proceed? (y)

  ●■▲
  Slidev Creator  v0.25.8

✔ Project name: … slidev
  Scaffolding project in slidev ...
  Done.

✔ Install and start it now? … yes
✔ Choose the agent › npm

added 347 packages, and audited 348 packages in 30s

49 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

> dev
> slidev --open

Could not determine entry point from rollupOptions or html files. Skipping dependency pre-bundling.

  ●■▲
  Slidev  v0.25.8

  theme   @slidev/theme-seriph
  entry   /home/user/Documents/Slidev/Test/slidev/slides.md

  slide show      > http://localhost:3030/
  presenter mode  > http://localhost:3030/presenter
  remote control  > pass --remote to enable

  shortcuts       > restart | open | edit

9:59:50 AM [vite] Internal server error: Failed to resolve import "@vueuse/shared" from "node_modules/.vite/@vueuse_motion.js?v=b04d2081". Does the file exist?
  Plugin: vite:import-analysis
  File: /home/user/Documents/Slidev/Test/slidev/node_modules/.vite/@vueuse_motion.js?v=b04d2081
  187|
  188|  //<EMAIL_ADDRESS>  189|  import { tryOnUnmounted as tryOnUnmounted2, isFunction as isFunction2 } from "@vueuse/shared";
     |                                                                                ^
  190|
  191|  // node_modules/popmotion/node_modules/tslib/tslib.es6.js
      at formatError (/home/user/Documents/Slidev/Test/slidev/node_modules/vite/dist/node/chunks/dep-24231913.js:50383:46)
      at TransformContext.error (/home/user/Documents/Slidev/Test/slidev/node_modules/vite/dist/node/chunks/dep-24231913.js:50379:19)
      at normalizeUrl (/home/user/Documents/Slidev/Test/slidev/node_modules/vite/dist/node/chunks/dep-24231913.js:75377:26)
      at async TransformContext.transform (/home/user/Documents/Slidev/Test/slidev/node_modules/vite/dist/node/chunks/dep-24231913.js:75517:57)
      at async Object.transform (/home/user/Documents/Slidev/Test/slidev/node_modules/vite/dist/node/chunks/dep-24231913.js:50590:30)
      at async doTransform (/home/user/Documents/Slidev/Test/slidev/node_modules/vite/dist/node/chunks/dep-24231913.js:64911:29)

Could anyone confirm if it fixes in v0.27.4? Thanks.


[Bug] -input-file option not working with multiple JSON objects in the file

What are you really trying to do?
Trying to run a new workflow with the input-file flag. It works with one input, but encounters an issue for multiple inputs.
Describe the bug
In the documentation for input-file flag, it says: "Passes optional input for the Workflow from a JSON file. If there are multiple JSON files, concatenate them and separate by space or newline. Input from the command line will overwrite file input."
So our python script creates a file with two JSON objects:
{ "key1" : "value1"} {"key2" : "value2"}
I tried with both space character and newline character. It doesn't work. It only works with one input.
With two inputs, I get this error: "Error: input is not valid JSON: invalid character '{' after top-level value"
Minimal Reproduction

Environment/Versions

OS and processor: Mac OS Ventura 13.4
Temporal Version: Tried with both temporal version 0.10.6, and tctl version next
Are you using Docker or Kubernetes or building Temporal from source? Docker with tctl. Built with the direct source for Temporal

Additional context

Sorry about that!
The docs are unfortunately just wrong about how --input-file works, and it seems we missed handling multiple arguments entirely. :/ I have a fix pending that allows for passing multiple --input-file options to pass distinct arguments (one per file), and clarifies in the help output how this works.


⚠ RPC server - Avalanche has degraded performance

In b6b539f, RPC server - Avalanche ($AVALANCHE_RPC_URL) experienced degraded performance:

HTTP code: 503
Response time: 3483 ms

Resolved: RPC server - Avalanche performance has improved in 965da9c after 19 minutes.


Hello

Hi @nwtgck,
Sorry to open an issue here but I like your work on the various piping servers. I'm trying to get in touch with you to see if there is interest in collaborating on the Icychat app.
You can email me at<EMAIL_ADDRESS>or respond here.
Thanks.
Tim

Hello,
Thank you for your comment!


[Suggestion] Feature Request: Support for Doom Complete iwad (WadSmoosh)

Is your feature request related to a problem? Please describe.
Nope
Describe the solution you'd like
Theres a iwad that people can create using wadsmoosh to merge all the iwads (doom, doom2, final doom etc) into one big iwad. Lexicon should support voting to those mapsets. A check via ACS is required however to determine which iwads are available.
Describe alternatives you've considered
N/A (Was pre discussed on discord)
Additional context
Doom complete is now playable on zandronum due to a few changes i made to the wadsmoosh tool, people may want to host lexicon with doom complete support

List of things todo for this

[x] Check for iwads
[x] Make Title Screens
[ ] Add each iwad/episode to the acs list
[ ] Add screens to map
[ ] Add map names and credits to the language.txt
[ ] Find out how to cosmetically tell users that an iwad screen is unsuable

404 dollar not found

This feature is postponed until a major release is set.


model.save error

I convert the model from  pytroch to keras successfully, but I can't save it, which report the following error
k_model = pytorch_to_keras(trained_model, input_var, [(3, 32, 32,)],change_ordering=True, verbose=False)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/site-packages/pytorch2keras/converter.py", line 341, in pytorch_to_keras
    conf = model.get_config()
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/site-packages/keras/engine/network.py", line 931, in get_config
    return copy.deepcopy(config)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 240, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 215, in _deepcopy_list
    append(deepcopy(a, memo))
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 240, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 240, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 220, in _deepcopy_tuple
    y = [deepcopy(a, memo) for a in x]
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 220, in <listcomp>
    y = [deepcopy(a, memo) for a in x]
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 220, in _deepcopy_tuple
    y = [deepcopy(a, memo) for a in x]
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 220, in <listcomp>
    y = [deepcopy(a, memo) for a in x]
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 180, in deepcopy
    y = _reconstruct(x, memo, *rv)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 280, in _reconstruct
    state = deepcopy(state, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 240, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 180, in deepcopy
    y = _reconstruct(x, memo, *rv)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 280, in _reconstruct
    state = deepcopy(state, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 240, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 180, in deepcopy
    y = _reconstruct(x, memo, *rv)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 280, in _reconstruct
    state = deepcopy(state, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 150, in deepcopy
    y = copier(x, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 240, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/root/anaconda3/envs/python3_lth2/lib/python3.6/copy.py", line 169, in deepcopy
    rv = reductor(4)
TypeError: can't pickle _thread.RLock objects

I have the same / a similar problem with a simple repro for this error (which, for me, occurs in the change_ordering step):
from pytorch2keras.converter import pytorch_to_keras
from torch import nn
import torch

class MyTestNet(nn.Module):
    def forward(self, x):
        return x.view(1, 1, -1)

test_net = MyTestNet()
dummy_input = torch.ones([1, 3, 10])
t_model = pytorch_to_keras(test_net, dummy_input, [(3, 10)], verbose=True)

This converts fine with:
graph(%0 : Float(1, 3, 10)) {
  %2 : Tensor = onnx::Constant[value= 1  1 -1 [ CPULongType{3} ]](), scope: MyTestNet
  %3 : Float(1, 1, 30) = onnx::Reshape(%0, %2), scope: MyTestNet
  return (%3);
}

Graph inputs: ['0']
Graph outputs: ['3']
State dict: []
 ____
graph node: MyTestNet
node id: 2
type: onnx::Constant
inputs: []
outputs: ['MyTestNet']
name in state_dict:
attrs: {'value': tensor([ 1,  1, -1])}
is_terminal: False
Converting constant ...
 ____
graph node: MyTestNet
node id: 3
type: onnx::Reshape
inputs: ['0', '2']
outputs: ['MyTestNet']
name in state_dict: 0.2
attrs: {}
is_terminal: True
Converting reshape ...
Your model was (probably) successfully converted!  This will crash with the same TypeError: can't pickle _thread.RLock objects.
I've traced the reason to the constant layer which, in this case, is an input to the Reshape op (unnecessarily in this case since the actual constants are available, but reshape is marked as untested so I'm not complaining ;)). The "wandering" tf.tensor that's created because of this op is unserializable, as explained here.
In my case altering the converter to use the reshape size array directly rather than converting it to a constant solves the problem.

@ElteHupkes thank you for your research. I replaced tf.reshape operation with native keras alternative (and I actually have to write tests:) )

@nerox8664 Anything I can do to help! You're putting in all the hard work, the least I can do is find out why something goes wrong when it does ;).
By the way, I may be mistaken (just tore down my debug env..), but I think that this line should also reference the _np version, because right now it's just taking the first item of the tf.constant object, so I reckon that check will always be false.


Add option to generate source maps for project files

This PR introduces a new boolean "sourceMap" configuration option under devOptions. Unlike the sourceMaps option under installOptions, which controls source map generation for dependencies, this new option controls source map generation for project files, when the build pipeline is using the default esbuild. I was not able to find an existing way to enable project file source map generation without introducing my own build script to transform files using Babel.
Changes:

Modified the getEsbuildFileBuilder function in build-util.ts to accept an options object parameter. Currently, the only property in this object is the optional sourceMap, whose value can be either "inline" or "external". This is passed through as the "sourcemap" option to the esbuild service's transform call, which tells esbuild to generate a source map for the file being tranformed.
In dev.ts, modified the buildFile function to pass { sourceMap: 'inline' } to getEsbuildFileBuilder so that the builder returned will return transformed files with inline source maps. This only occurs if the sourceMap option under config.devOptions is true.
In build.ts, modified the buildFile function to pass { sourceMap: 'external' } to getEsbuildFileBuilder so that the builder's return includes an additional sourceMap property with the external source map as a string. Also, the source map string is written to disk under <file name.js>.map, and the file itself is appended a source map URL reference comment before being written to disk itself. This also only occurs if the sourceMap option under config.devOptions is true.

Nice! I definitely agree with this in PR in spirit, but timing-wise I think it's still a bit too early to add this. We're still finalizing our plugin interface, and I'd want that to be in a more stable place before tackling this since transforming source-maps across different plugins can be a tough problem.
I'll sit on this one a bit, and then hopefully we can revisit once the official v2.0.0 is released.

Ah, I see. Fair enough. Thanks for considering it!

Thanks again for adding, still not ready to add this yet (we do some wrapping of JS files after build, so these would be broken if we used the esbuild option on its own).
Will close this for now and plan to tackle once the prioritized issue tracker is a little lighter.