Upgrade Eureka

Removes Servo from EurekaHealthIndicator
Removes DataCenterInfo implementation and custom codec
To customize the id of InstanceInfo set eureka.instance.sid

Did you see this comment by @qiangdavidliu? Will that change come in 1.2.5-rc.2?

Yes should be there by rc.2

@qiangdavidliu thanks!

Reopen

I can confirm this works by setting eureka.instance.sid.

Polished and merged via 8f9acab3bdbebfcf5687ec601904ee4f718ae25d.
Most notable EurekaInstanceConfigBean.getSID falls back to EurekaInstanceConfigBean.metadataMap.instanceId for
backwards compatibility.


Crashlytics user metadata - does it work? Where do I see it?

Hello,
I'm using this module successfully to send crashes. I'm now trying to set user metadata like this:
var { Crashlytics } = require('react-native-fabric')

export function addUserContextToCrashlytics(user) {
Crashlytics.setUserIdentifier(user.id)
Crashlytics.setUserName(user.username)
Crashlytics.setUserEmail(user.email)
Crashlytics.setString('phone', user.phone)
Crashlytics.setString('fullName', user.fullName)
}

The code is being reached and execute fine without error.
But I don't see any of this info in Crashlytics. Where would this show up? Should I be able to see this on a crash?

@GeoffreyPlitt just press green "View all sessions" button on right side

I don't see any button that says that, anywhere in Crashlytics/Answers. Can you send a screenshot?

@GeoffreyPlitt

Thanks, I clicked that and I see sessions, sure. I still don't see any metadata, like userIdentifier, username, and other metadata I've been setting. I don't see that in your screenshot either. Where do I see that?
Here's my version of your screenshot: https://www.dropbox.com/s/xv17l42k04o9kml/Screenshot 2016-10-19 13.25.10.png?dl=0

@GeoffreyPlitt
Crashlytics.setString('js bundle version', APP_VERSION[Platform.OS]);

Yup I'm sending the right data and nothing is showing for me in that section.
But I think we can close this, we decided there are too many things not working for Crashlytics+ReactNative so we're moving to BugSnag.

@xxsnakerxx:
I'm seeing the same issue of not seeing the username or email. I do, however, see a custom string or boolean. Maybe the username and email functions are not working.
I just installed everything today with the current version.
@GeoffreyPlitt Any comparison with BugSnag?

I haven't had a chance to look into this, any idea if the Crashlytics API changed? Or have you reached out to Fabric / Crashlytics about this as it seems like it would be on their side.

@justin808 I found all 3 of Crashlytics services (Crash capturing, Beta for deployments, Answers for metrics) were fairly easy to integrate at first, but all 3 had problems I never got past:

Beta - never quite worked for everybody, some people repeatedly tried to get the latest version and just downloaded old versions again.
Crash capturing - UI is very difficult to actually look at the details of a crash. It's like the UI is all pretty shapes and zero UX. Left me wanting to just export crashes in an automated way, which they  do not support (you have to do each one by hand, no webhooks or APIs to setup automated crash integrations, like Slack or Papertrail)
Answers never worked well-- I sometimes saw the values we inserted, but they were not integrated well with the Crashes products, UI again looked pretty but was impossible to really use  in a powerful, useful way.

I left Crashlytics. I'm loving Bugsnag.


master branch fails to compile after multi-threading changes

Godot version
4.0 (809a98216267f3066b9fec2f02b2042bdc9d3e0d)
System information
Windows 10, MSVC 14.2 (VS 2019)
Issue description
Trying to compile the engine fails with
scene/2d/node_2d.h(120): error C2280: 'Node::MTFlag::MTFlag(void)': attempting to reference a deleted function
scene/main/node.h(57): note: compiler has generated 'Node::MTFlag::MTFlag' here
scene/main/node.h(57): note: 'Node::MTFlag::MTFlag(void)': function was implicitly deleted because 'Node::MTFlag' has a variant data
member 'Node::MTFlag::mt' with a non-trivial default constructor
scene/main/node.h(55): note: see declaration of 'Node::MTFlag::mt'

Scons is run as
scons platform=windows -j6 target=editor dev_build=yes

Steps to reproduce
Try to compile the engine from the current master with MSVC 14.2 and the following command (probably irrelevant):
scons platform=windows -j6 target=editor dev_build=yes

Minimal reproduction project
N/A

Possible culprit is https://github.com/godotengine/godot/pull/77145
cc @RandomShaper

Looking into it. I wonder why CI didn't catch it.

For clarity, is it 14.2 or 14.20? I don't see 14.2 in

Our scons prints it as 14.2, but it should be 14.20, yes.
scons: Reading SConscript files ...
Found MSVC version 14.2, arch x86_64

I do have VS 2019, that's for sure :)

MSVC does definitely appear to have weird versioning numbers. From the command line for me it says 14.3, but the folder that holds the compiler has 14.36.32532 soooo maybe they just don't like the second decimal numbers  🙃

@YuriSizov what's in your \Microsoft Visual Studio\2022\Community\VC\Tools\MSVC folder?
At this point it does sound like scons is just grabbing the first digit after the .?

@akien-mga @YuriSizov It should be 14.21.27702, but I suspect the exact 14.2x version is not so relevant.


Remove dependency on geopandas

geopandas is an amazing open-source package, but it brings with it a lot of dependencies that are not useful in all cases. In pvfactors, we need a way to store efficiently shapely geometries in
DataFrames and perform basic geometric operations. So in this case, using the whole geopandas package may be overkill and may complicate the integration of the package in other (open-source) projects.
Here we try to overhaul the registry to remove its dependency on geopandas, while keeping the specific methods essential to pvfactors.
Addresses #2 .

Hey @cedricleroy @veronicaguo @amir-asgharzadeh , any chance that at least one of you guys could do a quick review of this PR please?

Related to discussion in pvlib/pvlib-python#421

Hi @anomam I meant to mention this earlier, so I understand if you ignore completely. IMO I don't see why you need Pandas for the Registry? Can't use just use NumPy record arrays? They would give you all the same functionality with a lot less overhead. I think you will also see improved performance as well. I only use Pandas generally for one-off analysis or for heavy time-series analysis, otherwise, it seems like overkill to me.


Fixed the issue with invalid XYZ intersections.

The XYZ intersections of middle children of Path, Loop, and CurveChainWithDistanceIndex were found which is wrong. Only first and last child intersections should be found. Also fixed issues with intersections when arcs were extended.

Pushed some changes:

Store the correct period-shifted local exterior arc fraction in the childDetail of the chain details returned by CurveCurve intersection methods on an extended CurveChainWithDistanceIndex. Previously, the detail for an extended intersection of a chain with first/last arc might have reported the arc's exterior fraction with the wrong sign.

CurveChainWithDistanceIndex.clonePartialCurve can now take such chain details as input and will correctly extend the chain using the child detail. Without such local detail, this method resorts to approximating the local exterior fraction using the distance index, and this can result in inaccurate extensions of chains starting/ending with an elliptical arc.

AngleSweep: refactor angle -> fraction logic so we can compute period-shifted exterior arc fractions off the specified end of [0,1].
Add StrokeOptions to CurveChainWithDistanceIndex clone methods to customize the distance index.
Clarifications to doc in response to user queries.


Handle launching tests on a remote queue with a personal access token

#38 adds support for replaying previous ABQ test runs with a personal access token, without modifying a remote queue.
One unintentional implication of the present behavior is that a fresh run initialized with a personal access token will also not report test results to a remote queue. This is not the intended behavior.
We have a couple options:

Error out if you're creating a fresh run on a remote queue with a PAT
Fallback to reporting results to the remote queue if a fresh run uses a PAT

Maybe (1) is more preferable as it aligns with the use of PATs in ABQ to replay tests in CI, but maybe that is not the only use case we foresee.

From standup @TAGraves:
if we have a PAT and no run ID, use an ephemeral queue
if we have a PAT and run ID that doesn't exist, error out

Addressed by https://github.com/rwx-research/abq/pull/52


Add a hook to the PendingMail send method to allow developers to access the returned SentMessage object.

Type: Improvement
Summary
As per the docs the send, html, raw, and plain methods on the Illuminate\Mail\Mailer class now return a Illuminate\Mail\SentMessage instance. However, the developer doesn't have access to this returned instance when using method chaining, e.g. Mailer::to('test@somedomain.com')->send($mailable). The to, cc and bcc methods on the Mailer class all return a PendingMail class which doesn't return the SentMessage instance. This PR proposes to add an intermediate public method call so that one may access the returned SentMessage object without going through other complex methods.
Issue
Details
As mentioned above, when using the Mail facade or using a Mailer instance directly, typically one would expect as per the send method signature to have a SentMessage object returned by the call. However, when we chain any of the methods to, cc or bcc available on the Mailer class before sending the mail via send we end up calling the send method on the PendingMail class. The send method on the PendingMail class doesn't return anything. For example `Mail::to($user)->send($mailable) is processed as follows:
The call to Mail::to() is:
   /**
   * Begin the process of mailing a mailable class instance.
   *
   * @param  mixed  $users
   * @return \Illuminate\Mail\PendingMail
   */
   public function to($users)
   {
       return (new PendingMail($this))->to($users);
   }

So a PendingMail class is returned. The next call send is actually called on the PendingMail class which has a send method as follows:
    /**
     * Send a new mailable message instance.
     *
     * @param  \Illuminate\Contracts\Mail\Mailable  $mailable
     * @return void
     */
    public function send(MailableContract $mailable)
    {
       $this->mailer->send($this->fill($mailable));
    }

Therefore the SentMessage object is not accessible in a easy manner. This is true whether we use the Mail facade or use a actual instance of the Mailer class. As soon as a call is made to to(), cc() or bcc this issue will pop up.
Alternate Solution 1: Listen for the MessageSent event via a Listener
Problem with this approach is that we end up listening to all MessageSent event. For example, say we want the X-SES-Message-Id which is returned when using the ses mailer.

This is inefficient as we are listening to all mail sent events, even ones which are sent via different mailers.
Further, we need to check whether the header is present.
A missing header tells us nothing. Was the header missing because there was a problem with SES or did we use a different mailer.

This issue becomes worse for package developers who want to implement their own mailers without changing the core mailers of the framework. The package is listening to all MessageSent events even the ones that weren't sent by it's own mailer.
Alternate Solution 2: Call the send method on Mailer directly
Example: Mail::send($mailable)
Well, the problem with this approach is we can say goodbye to using to(), cc() or bcc since they return PendingMail class. Now these fields can be set on the Mailable class. However, from a package developer's perspective they have to notify the user that their

Mailer is special and can't use these core Laravel methods.
The end-user has to set these fields on the Mailable.

Alternate Solution 3: Re-Implement the functionality manually
Basically extend the PendingMail class through the container and work it out that way. Notice I didn't write the steps since even writing them is going to be long. Not to mention, this is extra work for a simple returned object which the Mailer class is sending by default.
Proposed Solution
Add an intermediate public method call (a hook into the sending mail process) sendHook() which can be called instead of send when the developer needs access to the returned SentMessage object.
Instead of:
    /**
     * Send a new mailable message instance.
     *
     * @param  \Illuminate\Contracts\Mail\Mailable  $mailable
     * @return void
     */
    public function send(MailableContract $mailable)
    {
       $this->mailer->send($this->fill($mailable));
    }

we use this:
    /**
     * Send a new mailable message instance.
     *
     * @param  \Illuminate\Contracts\Mail\Mailable  $mailable
     * @return void
     */
    public function send(MailableContract $mailable)
    {
        $this->sendHook($mailable);
    }

    /**
     * Forward the send call.
     *
     * @param  \Illuminate\Contracts\Mail\Mailable  $mailable
     * @return \Illuminate\Mail\SentMessage|null
     */
    public function sendHook(MailableContract $mailable)
    {
        return $this->mailer->send($this->fill($mailable));
    }

Impact
None. Developers can continue using the Mail facade or Mailer class as they have been. Anyone who needs access to the returned SentMessage object can simply call the sendHook() method.

I don't understand you don't just add a return to send?

@taylorotwell I did in the previous PR #42035.

@driesvints can you chime in on why we can't just add a return?

The change to return the SentMessage was purely done for testing purposes. The contracts all have void in their return type. Ideally, we didn't need to do this. Previously, in Laravel 8.x you also only could intercept the message with the MessageSent event.
We could adjust the return, but if we do we'd also need to adjust the contracts for Mailable and Mailer and the mail fakes imo to go full circle. And given that we're a months into the Laravel 9.x release, I feel that this could be a semi-breaking change (not directly since it's only DocBlocks).
Ideally, I'd get rid of returning the SentMessage all together just like Symfony is doing in their Mailer. However, that way, we couldn't test the Mailer implementation anymore without over-mocking.

The change to return the SentMessage was purely done for testing purposes. The contracts all have void in their return type. Ideally, we didn't need to do this. Previously, in Laravel 8.x you also only could intercept the message with the MessageSent event.
We could adjust the return, but if we do we'd also need to adjust the contracts for Mailable and Mailer and the mail fakes imo to go full circle. And given that we're a months into the Laravel 9.x release, I feel that this could be a semi-breaking change (not directly since it's only DocBlocks).
Ideally, I'd get rid of returning the SentMessage all together just like Symfony is doing in their Mailer. However, that way, we couldn't test the Mailer implementation anymore without over-mocking.

I definitely do not want to go with this current PR. sendHook is just not an elegant thing to expose to users. I don't see a big problem with just returning from send. Seems pretty sensible to me really and I don't really think changing from void to returning is a breaking change that is worth worrying about.

@taylorotwell Sounds good. I will make the necessary changes.

Hi @taylorotwell, so as per @driesvints last comment, here are the new changes:

Reverted back to the simple return statement to send method of PendingMail class and got rid of the sendHook method.
Updated both the Mailer and Mailable Contract send method with the new return types.
Left MailFake return type as it is. The return type for the send method in MailFake seems to be ok to me. Don't think we need to update it to SentMessage|null as one can see below.

    /**
     * Send a new message using a view.
     *
     * @param  \Illuminate\Contracts\Mail\Mailable|string|array  $view
     * @param  array  $data
     * @param  \Closure|string|null  $callback
     * @return void
     */
    public function send($view, array $data = [], $callback = null)
    {
        if (! $view instanceof Mailable) {
            return;
        }

        $view->mailer($this->currentMailer);

        $this->currentMailer = null;

        if ($view instanceof ShouldQueue) {
            return $this->queue($view, $data);
        }

        $this->mailables[] = $view;
    }

I guess that should be all the changes that @driesvints mentioned.

Also update the return type of raw on the contract. All good now.


Deploy Device Role with AWX

add the feature required to integrate centurion with AWX to launch a Job Template/Workflow to deploy the devices assigned role.

marked this issue as related to #61

marked this issue as blocked by #113

marked this issue as blocked by nofusscomputing/projects/ansible/collections/centurion_erp_collection#1

nofusscomputing/projects/ansible/collections/centurion_erp_collection#1 being added as blocking due to the inventory script providing the current state of a machine.

added 30s of time spent


No module named 'taggit'

I installed Django-taggit by pip. My Django version is 2.1. and my Python version is 3.7.
When i try to put "taggit" in installed app in setting.py, I got an error.
ModuleNotFoundError: No module named 'taggit'
please help, Thank you.

did you add that to the installed_apps list?

sorry, i solved by my self. i missed understand that my server was 3.7. my version was 2.7 and i was a little bit confused. now I understand. Thank you for the reply.


XCode path

Is there a way to set the XCode path if it's not in the Applications folder?
The error message tells me how to set it in Visual Studio but I don't have VS installed and don't have enough space for it.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: da0a1dce-0ab0-7d18-8dc9-e37854995ace
Version Independent ID: da0a1dce-0ab0-7d18-8dc9-e37854995ace
Content: Build an iOS app on macOS with .NET CLI - .NET MAUI
Content Source: docs/ios/cli.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @dbullen-uk
It might be that the drop-down at Xcode > Preferences > Locations > Command Line Tools is blank. If so, select the drop-down and then the command line tools that are installed.
If that doesn't help, afraid you'll have to install Visual Studio.


top level .env file

Issue
ideally we would have a top level .env file that can be used across repos - releavent docs from nx
vite has some other env references to be aware of mainly the lack of process.env.
there is a more serious error that can be triggered around external apps and rpc urls - you can trigger this by uncommenting the rpcs and loading @daohaus/daohaus-connect-feature` -
fixing this environment issue is crucial to having external developers build off v3

might be relavent - https://vitejs.dev/config/#environment-variables


Fixing user privilege order in Traffic Portal

When we add a new user to the traffic_portal, there is a Role (privilege level) * field which should have order either from low to high privilege level or high to low. Can we fix it in the future release?

I think the idea is to move away from roles as just names for an integer describing privilege level and toward true capability separation. 'Course you could still order by e.g. number of granted capabilities.

@ocket8888 I believe you're right about that, but in the meantime it would probably make sense to order the Role field in Traffic Portal by privilege level. Right now it's all jumbled and not even sorted alphabetically.

Right. I was trying to figure out if anyway it is sorting it.
I think
traffic_portal/app/src/common/modules/form/user/FormUserController.js and the HTML that calls it is in that same /form/user directory
it does have this roleService.getRoles({ orderby: 'priv_level DESC' })
but that isn't working.

Ah, in that case, I believe the sorting is another case of sorting regressions introduced in the rewrite from Perl to Go. We lost that in a lot of different endpoints, and it appears that the roles endpoint has regressed as well.


Delonghi - Instead of the city, the message "Romania is not a city in Romania" is written

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro/src/delonghi/index.html
Browser: Chrome
Device: Laptop
OS: Windows 11
STEPS TO REPRODUCE:

Open the URL in the browser
Click on the "Run Scraper" button
Check cities for posted jobs
Open https://www.delonghigroup.com/en/people/careers and check the job location/city
EXPECTED RESULTS:
The city of the job is written in accordance with the city on the company website
Filter "Romania ICT Hub":

WEB DEVELOPER (M/F/X), Jucu, judetul Cluj
SENIOR WEB DEVELOPER (M/F/X), Cluj, judetul Cluj
FRONTEND DEVELOPER (M/F/X), Cluj, judetul Cluj
BACKEND DEVELOPER (M/F/X), Cluj, judetul Cluj

Filter "Romania":
TEST ENGINEER (M/F/X), Jucu, judetul Cluj
MES COORDINATOR (M/F/X), Jucu, judetul Cluj
ACADEMY PROGRAM FOR GRADUATES - DE'LONGHI GROUP ROMANIA, JUCU, judeul Cluj
CYBER SECURITY ADMINISTRATOR (M/F/X), Cluj, judetul Cluj
TEST ENGINEER COORDINATOR (M/F/X), Cluj, judetul Cluj
IT INFRASTRUCTURE ADMINISTRATOR (M/F/X), Cluj, Judetul Cluj

ACTUAL RESULTS:
Instead of the city, the message "Romania is not a city in Romania" is written

Fixed!


fix: update currentSession.user when GoTrueClient.update is called

Fixes #39
Addresses PR feedback in #40

Could you please add tests?

Absolutely. Can you approve my account to run checks so I can test my tests?
Not sure how to run them successfully locally yet. https://github.com/supabase-community/gotrue-dart/issues/47

The new stable Dart SDK has new lints that are failing. I can resolve these as well.

Hey just wondering if this can be merged and released? 😀


Single select issue

Hey,
I want to use the component as singleselect
Suppose, I've an array of options where I want to select by given a key of object eg: my key is event = 'event1'
and the code is like
{{ event }}

<multiselect :selected.sync="event" :options="[{key: 'event1', label: 'Event 1'}, {key: 'event2', label: 'Event 2'}]"></multiselect>

Is that possible or do I need to compute the changes every time?

Hey! Sorry for the late reply.
The .sync modifier is deprecated since v1.0.
Your code should look  like this:
<multiselect :selected="event" :options="options" key="key" label="label" @update="updateEvent"></multiselect>

data () {
  return {
    event: {},
    options: [{key: 'event1', label: 'Event 1'}, {key: 'event2', label: 'Event 2'}]
  }
},
methods: {
  updateEvent (newEvent) {
    this.event = newEvent
  }
}

This is exactly as the docs example.

Thanks for the reply @shentao
Actually I was looking if I can set the selected property as key and also return as key instead of the entire object.
No problem :)
I've made a wrapper component for this.
export default {
    template: require('./template.html'),
    props: ['selected', 'options', 'placeholder'],
    data() {
        return {
            default: ''
        }
    },
    methods: {
        updateSelected (value) {
            this.selected = (value && value.key) ? value.key : value;

            this.$emit('update', this.selected)
        }
    },
    computed: {
        default() {
            var tmp = '';
            if (this.selected && this.options) {
                if (typeof this.options[0] === 'object') {
                    var selected = this.selected;
                    this.options.forEach(function(option) {
                        if (option.key == selected) {
                            tmp = option;
                        }
                    });
                } else {
                    if (this.options.indexOf(this.selected) !== -1) {
                        tmp = this.selected;
                    }
                }
            }

            return tmp;
        }
    }
}

Sorry, I must have misunderstood you. Yes, if you just want to work with the keys, you need to derive it from the selected object and the other way around when setting it.

Its okay 👍
Now I've no issue with that wrapper.
BTW, You did really a great component.

Thanks! I guess, I can implement such functionality (preselecting based on just the key) into the 2.0 release.

That will be great. But if you can please do it on 1.0 version too cause there are many legacy apps based on Vue 1.x.x
Or if you want then I can help you.

We’ll see. The priority for this is lower than publishing 2.0 beta though.


Quick Sorting Algorithm in JAVA added

HacktoberFest 21
DSKaKhel: Quick Sort Algorithm
Data Structure Implementation you like to add
Quick Sort
Programming Language for Data Structure Implementation
JAVA
Code file name with extension
quickSort.java
Do you like to code or playing computer games like GTA5
Yes
If Yes, mention your favourite Game (optional)
VALORANT
YOU ARE
a student
GITHUB USERNAME
anshumanlite
We are looking for a cool name for this repository for next hacktober fest please suggest below (optional)
Dabang_in_DSA
Thanks for your contributions !!

Code quality is great and PR is acceptable can you please open this PR in AlgoHeist as its a quick sort algorithm

Code quality is great and PR is acceptable can you please open this PR in AlgoHeist as its a quick sort algorithm

I have made a PR in AlgoHeist21 repository as you asked me to do. Please have a look of it.


can you provide a model weight file to test?

I have no 4 v100 GPUS.

Hi @shoutOutYangJie,
Sorry, we have no plan to release the fine-tuned weight currently.


add handler for hello command

Added a base handler that checks for commands in messages and calls its respective handler.

Small comments. The rest looks good..thanks!!

Small comments. The rest looks good..thanks!!

could you please approve the PR


ReconnectionHandler.error-[ERROR] Cannot initialize channel

ReconnectionHandler.error-[ERROR] Cannot initialize channel.
java.util.concurrent.ExecutionException: java.lang.NullPointerException
        at java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357)
        at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1915)
        at com.lambdaworks.redis.protocol.ReconnectionHandler.reconnect(ReconnectionHandler.java:87)
        at com.lambdaworks.redis.protocol.ConnectionWatchdog.reconnect(ConnectionWatchdog.java:258)
        at com.lambdaworks.redis.protocol.ConnectionWatchdog.run(ConnectionWatchdog.java:243)
        at com.lambdaworks.redis.protocol.ConnectionWatchdog$2.lambda$run$393(ConnectionWatchdog.java:198)
        at io.netty.util.concurrent.PromiseTask.run(PromiseTask.java:73)
        at io.netty.util.concurrent.DefaultEventExecutor.run(DefaultEventExecutor.java:41)
        at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
        at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NullPointerException

After running for a long time, That is too many error message like that, Then netstat redis's port, That is too many connection, About more than 6000, Please take some helper

Please post the complete exception and which version of lettuce you're using.

<dependency>           <groupId>biz.paluch.redis</groupId>           <artifactId>lettuce</artifactId>           <version>4.3.1.Final</version>       </dependency>
That is all of printstack message

I can't proceed without knowing where NullPointerException therefore closing this issue.


(PDB-3993) Add upgrade cmd to upgrade db, queue, and then exit

Test PASSed

CLA signed by all contributors.

Test PASSed

Test PASSed


Multiline parsing issue

I have encountered issue with multiline parsing.
str_getcsv for line ending with single instance of encloser will return as correct content, so if field starts by newline this causes parser to stop assuming it read full correct field
fgetcsv correctly looks for further input in case of following input:
one,"
two
",three

For now I am just checking for edgecase (single instance of encloser preceeded by delimiter) to handle this, but it looks like proper solution will have to stop relying on str_getcsv and do full text parsing instead.

Looked at internal implementation of str_getcsv and it just uses fgetcsv inside - but even if we were to swap it out issue of premature end of stream (as our buffer may not have read it all yet) exists as fgetcsv will not exit with any state encountering unexpected end of stream

Nice work :+1:


Missing log function is the loss?

In the discriminator loss and generator loss, isn't there a log function missing before the mean?
In the SRGAN paper in eq. 2 there is a log function.

@YOCB I changed that in my code, if you want implement the same loss, then you should change it by yourself.


Improve CEL validation on IngressCRD resources

What does this PR do?
Provide validation definition to check expected content: Enum, UniqueItems, Pattern, Minimum or CEL validation expression when appropriate
Comes from #11005
Motivation
Improve User XP when writing and/or submitting Traefik's CRD.
Some IDEs are able to check those rules.
Kubernetes API Server will reject the resources, instead of applying it and forcing user to check error in logs or dashboard.

Hello @mloiseleur,
The changes are an enhancement rather than a bug fix, could you please rebase your branch to master?

@rtribotte the PR has been rebased. I have tried in a new commit to improve this PR following traefik resources update.


long term TODOs

Compat

Alloy Forgery
Tech Reborn
More Tags

Refactors

[maybe] move transfer to use Fabric stuff directly instead of a bridge (it's a pretty invasive change but may be necessary for some potential issues)

i'd like to interject for a moment
what you're referring to as tech reborn is, in fact, tech reborn + quilt.

What kind of compat with tech reborn?(like replacing metal sheets or just recipes for crushing?)

Compat here really just means recipes for everything

This’ll probably be a stretch (and maybe overpowered) but compat for Mi? (Modern Industrialisation) E.g Mechanical press is able to turn copper rods into copper rings, compressing coal dust into coal.

I think it would be better if those mods added compat for create instead

I think it would be better if those mods added compat for create instead

But Create for fabric is still testing and we need to add compat with other mods first to work with other mods instead to let modders to add compat themselves with create.

I'm talking about recipe compat not mod incompat

https://github.com/JieningYu/CreatePlus
My datapack for create fabric compat.


Custom fields don't fully delete when using bulk delete

Environment

Python version: 3.7.13
Nautobot version: 1.3.7b1

Steps to Reproduce

Create a custom field on a Device
Bulk delete the custom field

Expected Behavior
The CustomField object gets removed, but Device._custom_field_data still shows the custom field. It also shows up via GraphQL query.

Observed Behavior
The custom field should be removed from Device.
Analysis
When you delete an individual object in Nautobot, the ObjectDeleteView calls the .delete() method for that object. When you do a bulk delete, however, the BulkDeleteView creates a QuerySet of the items and calls QuerySet.delete().
There is a caveat of QuerySet.delete() from the documentation:

The delete() method does a bulk delete and does not call any delete() methods on your models.

In the case of CustomField there is a custom .delete() method that creates a Celery task to iterate through all of the objects that have that custom field and remove them accordingly. Since the CustomField.delete() method is not getting called, it is not cleaning the custom fields off of the related models. This is evident via the ORM or GraphQL.
In addition to CustomField, DeviceType also has a custom delete method, so they would also be susceptible to this same problem where the custom delete methods will not be called during the bulk delete.
Possible fixes
According to the documentation the QuerySet.delete() still emits a post_delete signal that can be used to run the custom delete actions instead.

@joewesch What's the use case for bulk-deleting custom fields?


Errors when training with CDPN init.

Hi, I encounter an error when training using cdpn init config.
_, R_vector, T_vector = cv2.solvePnP(
IndexError: boolean index did not match indexed array along dimension 1; dimension is 64 but corresponding boolean dimension is 2
The error codes are
_, R_vector, T_vector = cv2.solvePnP(                     x3d_np_[mask_np_], x2d_np_[mask_np_], cam_intrinsic_np, dist_coeffs, flags=cv2.SOLVEPNP_EPNP)
Specifically:
x3d_np_[mask_np_]

Thanks for the feedback! This bug has been fixed now.


Character tweens

Describe your problem here.
I want to add a tween on the gf to make her move to the right on the stage
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

Wdym? Can you be more specific?

I want to make the gf move with tweens but im not sure what tween to use

doTweenX('movegfx', 'gf', POS, duration, 'linear');
doTweenY('movegfy', 'gf', POS, duration, 'linear');
doTweenAlpha('gfalphs', 'gf', opacity, duration, 'linear');

Use either of these


python311Packages.jupyterlab-server: 2.26.0 -> 2.27.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.jupyterlab-server is: A set of server components for JupyterLab and JupyterLab like applications
meta.homepage for python311Packages.jupyterlab-server is: https://github.com/jupyterlab/jupyterlab_server
meta.changelog for python311Packages.jupyterlab-server is: https://github.com/jupyterlab/jupyterlab_server/blob/v2.27.1/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.27.1 with grep in /nix/store/86fx056y881czax2af5pjg7k9h1ik3x7-python3.11-jupyterlab-server-2.27.1
found 2.27.1 in filename of file in /nix/store/86fx056y881czax2af5pjg7k9h1ik3x7-python3.11-jupyterlab-server-2.27.1

Rebuild report (if merged into master) (click to expand)

112 total rebuild path(s)

112 package rebuild(s)

First fifty rebuilds by attrpath

cantor
ihaskell
jupyter
jupyter-all
labplot
libsForQt5.cantor
manim
manim-slides
nbqa
nitrokey-app2
plasma5Packages.cantor
pynitrokey
python311Packages.ansible-kernel
python311Packages.arviz
python311Packages.augmax
python311Packages.bambi
python311Packages.batchspawner
python311Packages.bqplot
python311Packages.bqscales
python311Packages.dalle-mini
python311Packages.distrax
python311Packages.dm-haiku
python311Packages.dockerspawner
python311Packages.einops
python311Packages.elegy
python311Packages.encodec
python311Packages.experiment-utilities
python311Packages.flax
python311Packages.ipytablewidgets
python311Packages.ipyvuetify
python311Packages.jupyter
python311Packages.jupyter-collaboration
python311Packages.jupyter-contrib-core
python311Packages.jupyter-contrib-nbextensions
python311Packages.jupyter-nbextensions-configurator
python311Packages.jupyterhub
python311Packages.jupyterhub-ldapauthenticator
python311Packages.jupyterhub-systemdspawner
python311Packages.jupyterhub-tmpauthenticator
python311Packages.jupyterlab
python311Packages.jupyterlab-git
python311Packages.jupyterlab-lsp
python311Packages.jupyterlab-server
python311Packages.jupytext
python311Packages.k-diffusion
python311Packages.layoutparser
python311Packages.manim-slides
python311Packages.mkdocs-jupyter
python311Packages.nbdev

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/86fx056y881czax2af5pjg7k9h1ik3x7-python3.11-jupyterlab-server-2.27.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.jupyterlab-server https://github.com/r-ryantm/nixpkgs/archive/7d9b6836a2774471de815711a6ab67edd1fcc570.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7d9b6836a2774471de815711a6ab67edd1fcc570#python311Packages.jupyterlab-server

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/86fx056y881czax2af5pjg7k9h1ik3x7-python3.11-jupyterlab-server-2.27.1
ls -la /nix/store/86fx056y881czax2af5pjg7k9h1ik3x7-python3.11-jupyterlab-server-2.27.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 120m and timed out

Maintainer pings
cc @GaetanLepage @natsukium @thomasjm for testing.

nixpkgs-review reveals no new failures, macos 12 x86_64

Already on master.


Add duplicate paper merging feature

env ignoreSources=jmlr npm run test passes ✅
(jmlr.org is currently unreachable)


error compiling sample demo , square. objdump on libm.a fails

user@debian:~/HIP/samples/0_Intro/square$ ls
Makefile  README.md  square.cu  square.hipref.cpp
user@debian:~/HIP/samples/0_Intro/square$ make
/opt/rocm/hip/bin/hipify-perl square.cu > square.cpp
/opt/rocm/hip/bin/hipcc  square.cpp -o square.out
objdump: /usr/lib/x86_64-linux-gnu/libm.a: file format not recognized
user@debian:~/HIP/samples/0_Intro/square$ ls -l /usr/lib/x86_64-linux-gnu/libm.a
-rw-r--r-- 1 root root 132 Oct 29 20:36 /usr/lib/x86_64-linux-gnu/libm.a
user@debian:~/HIP/samples/0_Intro/square$ file /usr/lib/x86_64-linux-gnu/libm.a
/usr/lib/x86_64-linux-gnu/libm.a: ASCII text
user@debian:~/HIP/samples/0_Intro/square$ head /usr/lib/x86_64-linux-gnu/libm.a
/* GNU ld script
*/
OUTPUT_FORMAT(elf64-x86-64)
GROUP ( /usr/lib/x86_64-linux-gnu/libm-2.27.a /usr/lib/x86_64-linux-gnu/libmvec.a )

No idea why the makefile or some of the tools called from makefile call objdump, and why it fails.

Hi @baryluk
I believe this is a warning spit out by part of the the HCC linker when it tries to run objdump internally on the things it is compiling. This is a warning only, and this PR should fix it. That PR should be part of our ROCm 2.0 release. I don't believe this should cause your compilation to fail, however.

Closing this since this is a false error and which has already been fixed in HCC.

Thanks!


test: add e2e test for walletconnect on Sepolia

Description

Test plan

Related issues

Fixes #[issue number here]

Backwards compatibility

Closing this until we find a way to keep a sepolia wallet well funded


libvirt-glib: fix cross

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I think it would be better to do docs ? stdenv.hostPlatform == stdenv.buildPlatform and introspection ? stdenv.hostPlatform == stdenv.buildPlatform and use those, but it doesn't matter too much.

Changed. :)


Clean up the TODO item in build target grpc_base -- part error

This PR requires cherry picking before merging.
This PR fixes the TODO item in the error part of build target grpc_base.

Closing this PR since #31521 should cover the same thing.


This removes the second CacheSM, and related APIs

For some details as to why this is important, see:
https://cwiki.apache.org/confluence/display/TS/Cleanup+of+Cache+URLs

Note that this leaves the stale_while_revalidate plugin in a broken state,
but I rather keep the code there for now, since there's hope someone has a
fix for this plugin, which does not require this now removed API.

[approve ci autest]

Sent an email to the mailing list for discussion / approval as well.

I eliminated the rest of the "state" tracking, since LOCK_URL_ORIGINAL was eliminated long ago, there really is only one state left here, the "FIRST URL".

I've been running with this on Docs / CI for a day now, so far so good.

Cherry-picked to 8.0.x


Dep updates

Codecov Report

Merging #446 (4524d14) into master (6d32319) will increase coverage by 0.00%.
The diff coverage is 26.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   69.42%   69.43%
=======================================
  Files         462      462
  Lines       17222    17223    +1
=======================================
+ Hits        11957    11958    +1
  Misses       5265     5265

Files Changed
Coverage Δ

app/commands/BaseCommand.php
0.00% <ø> (ø)

app/commands/RemoveInactiveUsers.php
65.71% <ø> (ø)

app/helpers/BrokerProxy.php
3.80% <ø> (ø)

app/helpers/Emails/EmailHelper/EmailHelper.php
65.45% <ø> (ø)

...mails/Notifications/Reviews/ReviewsEmailSender.php
2.43% <0.00%> (ø)

...eConfig/Pipeline/Box/Boxes/BisonCompilationBox.php
51.51% <0.00%> (ø)

app/model/entity/Assignment.php
96.20% <ø> (ø)

app/model/entity/Group.php
77.96% <ø> (ø)

app/model/entity/base/ExerciseData.php
92.10% <ø> (ø)

app/router/RouterFactory.php
100.00% <ø> (ø)

... and 3 more

... and 5 files with indirect coverage changes


Catching errors in Ajax, Angular?

Hi Guys
I have installed Sentry successfully for the purpose of tracking errors on the client facing side of the app.
I have currently downloaded the script as such => //cdn.ravenjs.com/1.1.17/angular,console,jquery,native/raven.min.js
And as far as I could make out, the angular plugin has an exception handler which should hook onto the angular app, and send messages to raven. Couldn't understand, though if the ajax wrappers are already built in.
I came across this => https://github.com/getsentry/raven-js/pull/204/files , but can't see this file anymore and I am wondering if I need to write any code in my app to achieve the same?
Thanks in advance

For Angular, you need to provide the RavenConfig variable.  See: https://github.com/getsentry/raven-js/issues/235
If those instructions work for you, I'll add those into our docs.
For everything else, it should get monkey patched and magic will happen.

I like monkey patched!
Slightly confused, so I now have two places where I basically set up the app....One for native javascript, then another for angular so Raven Angular Script can hook onto it?
Yes, lets update the docs....Examples always help

If you're using angular, you'd only need to configure it through the angular hook. You wouldn't need to call Raven.config(...).install() yourself.
If you look at the source, the plugin will do that for you if you just provide RavenConfig: https://github.com/getsentry/raven-js/blob/master/plugins/angular.js#L25
But to be honest, I know very little about angular personally, which is why I'm not 100% sure how this works. :)

@mattrobenolt => Hey Matt and others
If you want to catch ajax errors, you gotta do this as well
$(document).ajaxError(function (event, jqXHR, ajaxSettings, thrownError) {
    Raven.captureMessage(
        thrownError || jqXHR.statusText,
        {
            extra: {
                type: ajaxSettings.type,
                url: ajaxSettings.url,
                data: ajaxSettings.data,
                status: jqXHR.status,
                error: thrownError || jqXHR.statusText,
                response: jqXHR.responseText.substring(0, 100)
            }
        }
    );
});

https://github.com/getsentry/raven-js/pull/204/files
I was just looking around, and in the plugins - jquery file
I see this
``
var _oldAjax = $.ajax;
$.ajax = function ravenAjaxWrapper(url, options) {
...
...
})

Would really have thought that jquery plugin would have done the magic (monkey patching), but it was the pull request which did the job for me.

So some clarification on the difference:
We monkey patch to catch actual exceptions raised from your code. Catching these things from XHR responses aren't exceptions, they're semantic meaning applied to the response code of the http response.
What that response code means to you, is different to others. So to uniformly catch them, I think is incorrect. For example, jQuery reports anything not a 2xx as an error. I don't think every single 400 or 404 or 403 or 503, etc should be reported automatically.
Like I said, in #204, we could absolutely do this, but it'd have to be an opt-in thing.

@mattrobenolt Gotcha, would be a good optional settings though. I think I might take a shot at sending a PR for this. Thanks :-)


A way to manually enable/disable padding for block ciphers

I need a way to turn of padding for DES-CBC, but it seems there's no way to do so in HsOpenSSL.
I really need this and willing to contribute. What's the best way to add this to HsOpenSSL without breaking anything? Should I just add something like cipherBSNoPad? Any suggestions?

I'm new maintainer of HsOpenSSL. Pull request was merged into https://github.com/vshabanov/HsOpenSSL and released on Hackage. I think that this issue is closed. In future please open issues in the new repo.


update packing receipt manager and packing validator

Coverage increased (+0.003%) to 66.12% when pulling 1a46e992b3fab3740e6f53f479db8e0391ea1819 on leslieaula:dev into 9597f6ace6e2d63129ba3e47a0abb8cd0d98861c on danliris:dev.


Master expunge ifdef crazyfly

@dennisss , FYI @LorenzMeier
I need to remove all the CONFIG_ARCH_BOARD_xxxx from the code base. We want to have a more component based approach to share code, but not tie it to one board.
@dennisss Would you please review and test this.

Jenkins please test this

Jenkins test this please.

Tested and working!
I've also looked into removing the alternative rate. This (https://github.com/dennisss/Firmware/commit/ad12b4c7d7198d4501a867da0e5147b6089b5f32) works per your notes. I haven't seen any artifacts arise for the slight delay in rate setup during startup. I believe that it shouldn't be an issue as the stock firmware switches to lower rates initially for audible sound purposes anyway.

@LorenzMeier -
i am having to do this in pieces.
Please review and merge -


HTTP to HTTPS Redirect Issue: Infinite loop issue with Custom Query Param

I am trying to create a HTTP to HTTPS redirect following doc here
Below is the config
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type": "redirect", "RedirectConfig":
      { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301"}}'
    alb.ingress.kubernetes.io/backend-protocol: HTTPS
    alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:us-west-2:xxxxxx:certificate/023f915c-bb63-4eed-b65a-c8b901eb4875
    alb.ingress.kubernetes.io/healthcheck-path: /swagger.json
    alb.ingress.kubernetes.io/healthcheck-protocol: HTTPS
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTPS": 443}, {"HTTP": 80}]'
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/security-groups: sg-0axxxxd2,sg-0axxxxb3d
    alb.ingress.kubernetes.io/ssl-policy: ELBSecurityPolicy-TLS-1-2-2017-01
    alb.ingress.kubernetes.io/subnets: SubnetAz1, SubnetAz2, SubnetAz3
    alb.ingress.kubernetes.io/success-codes: "200"
    kubernetes.io/ingress.class: alb
  labels:
    app: swagger-ingress
  name: swagger-ingress
  namespace: swagger-api-ppd-qal
spec:
  rules:
  - host: swagger-doc.api.devops.int
    http:
      paths:
      - backend:
          serviceName: ssl-redirect
          servicePort: use-annotation
        path: /
      - backend:
          serviceName: swagger-service
          servicePort: 443
        path: /

while applying this kubectl apply -f swagger-ingress.yaml and describing the ingress, I see below error message
Warning  ERROR   34s (x12 over 63m)  ingress-controller  Error instantiating target groups: Unable to find the swagger-api-ppd-qal/ssl-redirect service
I verified in AWS console and does not see redirect rule on HTTP listener. Also, I am not sure why Ingress Controller is trying to find swagger-api-ppd-qal/ssl-redirect service here.
Am I missing something, please suggest.
K8S Version: 1.14.6

Maybe you need to put annotation alb.ingress.kubernetes.io/target-type: instance  if use service-type NodePort or  alb.ingress.kubernetes.io/target-type: ip to use service-type ClusterIP.
The name swagger-api-ppd-qal/ssl-redirect are your namespace and serviceName.

@cesarokuti I noticed another issue with Redirects. If I put a override for Query Param, Ingress Controller goes in infinite loops
'{"Type": "redirect", "RedirectConfig": { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301", "Query": "albRedirect=true&#{query}"}}'

We are adding this additional albRedirect to know if client tried to use a HTTP instead of HTTPS.

@yks0000 I had this same problem too. After tons of searching, I found this setup which works for me: https://github.com/kubernetes-sigs/aws-alb-ingress-controller/issues/487#issuecomment-428262702

@agconti Thanks for sharing. However, Issue I have is when I use custom query parameters and ingress controller goes in Infinite loop ie https://github.com/kubernetes-sigs/aws-alb-ingress-controller/issues/1055#issuecomment-568153587

Issue is not yet resolved for me.

same with me. url isn't redirect to https

I'm having Having SSL redirect issues as well.Followed the documentation below
https://kubernetes-sigs.github.io/aws-alb-ingress-controller/guide/tasks/ssl_redirect/

@shrivastavshubham34 I also found the same issue while the same documentation. Did you resolved it?

@shrivastavshubham34 I also found the same issue while the same documentation. Did you resolved it?

Hey yes I was able to resolve it.
By moving ssl redirect route to last entry in the ingress file.
Shifting its position should fix the problem

@shrivastavshubham34  This was my annotations, as you mentioned i have set ssl-redirect to last still the error is there. Do you find anything wrong with the annotations?
kubernetes.io/ingress.class: alb
alb.ingress.kubernetes.io/target-type: instance
alb.ingress.kubernetes.io/scheme: internet-facing
alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:XXXXX:YYYYY
alb.ingress.kubernetes.io/listen-ports: '[{"HTTP:80"},{"HTTPS":443}]'
alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type": "redirect", "RedirectConfig": { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301"}}'

You need to add couple of other params as well
    kubernetes.io/ingress.class: albcm
    alb.ingress.kubernetes.io/certificate-arn: arn:aws:acm:us-east-1:xxxxxxxxxx:certificate/xxxxxxxxx
    alb.ingress.kubernetes.io/listen-ports: '[{"HTTP": 80}, {"HTTPS":443}]'
    alb.ingress.kubernetes.io/backend-protocol: HTTPS
    alb.ingress.kubernetes.io/actions.ssl-redirect: '{"Type": "redirect", "RedirectConfig": { "Protocol": "HTTPS", "Port": "443", "StatusCode": "HTTP_301"}}'
    alb.ingress.kubernetes.io/healthcheck-protocol: HTTPS
    alb.ingress.kubernetes.io/healthcheck-path: /api/health_check
    alb.ingress.kubernetes.io/scheme: internet-facing
    alb.ingress.kubernetes.io/tags: Environment=dev

In spec rules ssl-redirect should be either last or 2nd last whichever works for you
spec:
  rules:
    - host: example.com
      http:
        paths:
          - path: /agent
            backend:
              serviceName: agent-service
              servicePort: 4453
          - path: /*
            backend:
              serviceName: ssl-redirect
              servicePort: use-annotation


[AMD RADV] Final Fantasy XV low framerate for tessellation enable

Software information
Final Fantasy XV
Resolution: 1280x720
Low settings
System information
https://linux-hardware.org/?probe=0c49463415

GPU: AMD RX480 4Gb
Driver: AMD RADV
Wine version: 3.16 esync
DXVK version: 0.72

Log files

d3d11.log:
ffxv_s_d3d11.log

dxgi.log:
ffxv_s_dxgi.log

Bugs
Enable tessellation - 3.7 FPS
Disable tessellation - 50 FPS
To 3.7 FPS

Load on the cpu - 10%
Load on the gpu - 99%

Previously, when tessellation enable, fps was not changed.
Others
My game directory default is read only mode, except d3d11.log and dxgi.log files.
Does DXVK write anything to the game catalog?

I'm aware, but no idea what causes it.

Seems somewhat on the extreme side, but if I look at some windows complaints seems like a drop of >= 4x is to be expected on AMD GCN3 hardware. On the radv side I guess we could put an option in to limit the max tessellation factors just like the windows drivers have.

# Overrides the maximum allowed tessellation factor. This can be used to
# improve performance in titles which overuse tessellation.
#
# Supported values: Any number between 8 and 64

# d3d11.maxTessFactor = 0

Set d3d11.maxTessFactor = 8 not changes (5 fps)
wine 3.17 staging esync

{
    "CPU": "AMD FX-8320E Eight-Core Processor",
    "GPU": "AMD Radeon (TM) RX 480 Graphics (POLARIS10, DRM 3.23.0, 4.15.0-34-generic, LLVM 7.0.0) (0x67df)",
    "RAM": 16039,
    "Distr": "Ubuntu 18.04",
    "Linux": "Linux 4.15.0-34-generic x86_64",
    "GLIBC": "2.27",
    "Mesa": "18.3.0-devel"
}

Found the reason, it was due to the fact that the folder with the game was available only for reading.
Secondly, it turned out that the dxvk.conf file must be inside the prefix.
Third, the cache folder must also be in the prefix.
After fixing all the problems, the game began to work quickly.


Fix reverse-dep tests

Tests were broken because of variable SOURCE_BRANCH introduced in packit
service.

recheck

Build failed.

pre-commit  : SUCCESS in 3m 32s
packit-tests-rpm  : SUCCESS in 7m 51s
packit-tests-pip-deps  : SUCCESS in 7m 20s
packit-tests-git-master  : SUCCESS in 7m 27s
packit-tests-rpm-sess-rec  : SUCCESS in 2m 31s
packit-tests-pip-deps-sess-rec  : SUCCESS in 3m 00s
packit-tests-git-master-sess-rec  : SUCCESS in 2m 50s
reverse-dep-packit-service-tests  : FAILURE in 2m 53s

required to be fixed in same way also for install-deps not only for install-deps-worker after https://github.com/packit-service/packit-service/pull/757 was merged


How to modify user's login password through api without state?

See: https://door.casdoor.com/swagger/#/Account API/ApiController.SetPassword


Add Gulp

Hey,
This is really strange that there is no awesome list for the greatest automation tool ever :sparkles:

At the moment I think the list looks a little bit too much like a listing of plugins. That's where the plugins site is for.
By the way, opened some issues over at your repo.

I see, thank you. I started working on it.
I was inspired by awesome-angularjs when I created it (I guess I should add this inspiration note). So it would be like short list of useful plugins, because the plugins site is a way to wide.

@alferov Of course, but it may not be limited to plugins (which it at the moment kinda is). It can contain articles, guides, boilerplates, ...

For sure, I'm looking forward to extend it and create truly useful resource.

Cool. Looks ok, but yeah, needs a lot more non-plugin resources. Also be sure to be strict about what plugin to include. There's a LOT of crappy ones out there. A good way to make sure is to check existing/new entries against the blacklist: https://github.com/gulpjs/plugins/blob/master/src/blackList.json

Some more gulp related things you might want to include:
https://github.com/sindresorhus/gulp-debug
https://github.com/sindresorhus/generator-gulp-plugin-boilerplate
https://github.com/sindresorhus/gulp-plugin-boilerplate
https://github.com/sindresorhus/del (the right way to clean files with gulp)
https://github.com/sindresorhus/gulp-app

I've decided to go with the following structure:
Contents
Plugins

Compilation
Transpilation
Concatenation
Minification
Optimization
Injecting assets
Linting
Live reloading
Caching
Flow control
Logging
Testing
Miscellaneous
Deprecated (for legacy support when gulp 4 is released)

Resources

Documentation
Tutorials
Videos
Links
Miscellaneous

Boilerplates

Scaffolding
Yeoman generators

Miscellaneous
What do you think?

Sure, but I would focus more on the Resources, rather than the plugins. Like putting resources at the top.


Method not found

OS: Debian stable
Jellyfin: 10.3.6 via Docker
Gotify: 2.0.6 via Docker
Hello, I'm attempting to set up gotify notifications in Jellyfin and discovered that the test notification button throws an error. I also tested by triggering a notification and it throws the same error. The error content is as follows:
System.MissingMethodException: Method not found: 'Void MediaBrowser.Common.Net.HttpRequestOptions.SetPostData(System.Collections.Generic.IDictionary2<System.String,System.String>)'.
at Jellyfin.Plugins.Gotify.Api.ServerApiEndpoints.PostAsync(TestNotification request)
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at Jellyfin.Plugins.Gotify.Api.ServerApiEndpoints.PostAsync(TestNotification request)
at Jellyfin.Plugins.Gotify.Api.ServerApiEndpoints.Post(TestNotification request)
at Emby.Server.Implementations.Services.ServiceExecGeneral.<>c__DisplayClass5_0.b__0(Object service, Object request)
at Emby.Server.Implementations.Services.ServiceExecGeneral.Execute(Type serviceType, IRequest request, Object instance, Object requestDto, String requestName)
at Emby.Server.Implementations.Services.ServiceController.Execute(HttpListenerHost appHost, Object requestDto, IRequest req)
at Emby.Server.Implementations.Services.ServiceHandler.ProcessRequestAsync(HttpListenerHost appHost, IRequest httpReq, IResponse httpRes, ILogger logger, String operationName, CancellationToken cancellationToken)
at Emby.Server.Implementations.HttpServer.HttpListenerHost.RequestHandler(IHttpRequest httpReq, String urlString, String host, String localPath, CancellationToken cancellationToken)
`
I have verified that the gotify server is responding to two other systems (Curl, external web service) and have attempted using multiple forms of the host without success. (localhost, 127...., public url)
Let me know if there is any other information that can help with troubleshooting.

Thanks for the report. Some things were removed with 10.3.6, so I have a PR that is waiting for a fix on the server so the notification can be properly set

Hello @crobibero , additional information:

First off, I may have messed up. Apparently I need to learn about docker networking; I have both jellyfin and Gotify running as separate instances and it appears they are unable to communicate. (I discovered this when attempting to connect other services...whoops)
Assuming the root of the issue is point 1, a bit better error handling may be in order. The frontend message is fine, however the backend (pasted above) tells me the error isn't really being fully handled and is just throwing.

Apologies for the misguided report, time to go set up a docker network!

Oh, belated update: I fixed the host issue, however connections still fail, so it does appear that there is an issue.

Still waiting for 10.3.7 to be released before I can make sure the PR works

@crobibero Thanks for doing that in #4. We're just looking at one last thing in the 10.3.7 beta, and then we should be good.

Fixed with #4


ZEPPELIN-298 Paragraph progress bar and % complete not working

This PR fixes ZEPPELIN-298 by searching correct "addListener" method which have JobProgressListener as a parameter.

looks good

@felixcheung Thanks for reviewing.
Ready to merge.

Merge if there're no more discussions.


Allow SpatialMaterial Depth in the GLES2 backend

Follow-up to https://github.com/godotengine/godot/pull/50295.
On GLES2, the shader now uses a fixed for loop instead of a dynamic while loop as while loops aren't supported on all platforms in GLES2.
Inspired by three.js: https://github.com/mrdoob/three.js/blob/bb484d616955e2bf1c3329383c3c0cc3543ccf71/examples/jsm/shaders/ParallaxShader.js#L84-L95
Testing project: tp.zip
Preview
Desktop
Fedora 34 - GeForce GTX 1080 - OpenGL 2.1

HTML5
Firefox 90 - GeForce GTX 1080 - WebGL 1.0

Android (high precision not forced, resulting in artifacts)
Android 10 - OnePlus 6

Android (high precision forced)
Android 10 - OnePlus 6

I think this will break on all GLES2-only devices as well. It likely only works because your driver's are not very strict and you have a relatively new GPU.

I think this will break on all GLES2-only devices as well. It likely only works because your driver's are not very strict and you have a relatively new GPU.

I managed to find my way around it :slightly_smiling_face:


The image's URL is incorrect when requesting via proxy

Expected URL
http://localhost:8000/media/cover_photos/2017/11/15/ABC.jpg
Received URL
http://localhost:4200/media/cover_photos/2017/11/15/ABC.jpg
Note that this URL is received from the webserver through the proxy.

Didn't you fix that?

Do you prefer using url like /media/scene_photo/2017/11/20/ABC.png instead?

@JThanat For now it's url.replace('8000', '4200'), which is super hacky.
One of the solutions is, in addition to /api proxying, I will proxy /media/ from 4200 to 8000, too. Is that OK?