x/tools/internal/lsp: gopls does not support emacs lsp client

The origin issue is on here: https://github.com/saibing/bingo/issues/181

@stamblerre

So, I'm setting up the client configuration in lsp in Emacs as documented in the gopls wiki, and I'm getting this error when I try to run lsp:
panic: runtime error: index out of range

goroutine 18 [running]:
golang.org/x/tools/internal/lsp.(*Server).Initialized(0xc0001683f0, 0x14c5b60, 0xc0000a2000, 0x1789490, 0x1789490, 0x0)
	/Users/pdoustdar/src/gopath/src/golang.org/x/tools/internal/lsp/server.go:218 +0x339
golang.org/x/tools/internal/lsp/protocol.serverHandler.func1(0x14c5b60, 0xc0000a2000, 0xc000168460, 0xc0001c8020)
	/Users/pdoustdar/src/gopath/src/golang.org/x/tools/internal/lsp/protocol/server.go:75 +0x6e2
golang.org/x/tools/internal/jsonrpc2.(*Conn).Run.func1(0xc00009e900, 0xc000168460)
	/Users/pdoustdar/src/gopath/src/golang.org/x/tools/internal/jsonrpc2/jsonrpc2.go:276 +0xda
created by golang.org/x/tools/internal/jsonrpc2.(*Conn).Run
	/Users/pdoustdar/src/gopath/src/golang.org/x/tools/internal/jsonrpc2/jsonrpc2.go:270 +0xba

For reference, here is what I'm using to create and store the client in Emacs:
(lsp-register-client
   (make-lsp-client :new-connection (lsp-stdio-connection "gopls")
                    :major-modes '(go-mode)
                    :server-id 'gopls))

Thanks for all your work on gopls, I really appreciate it!

Just filed https://github.com/emacs-lsp/lsp-mode/issues/747, so hopefully we can get this resolved soon.
In the meantime, a work-around is to rebuild gopls with the configurationSupported field of the server hardcoded to false (https://github.com/golang/tools/blob/923d25813098b2ffdf1b4bb7ee4ec425fef796a9/internal/lsp/server.go#L118).

The issue that was causing this in lsp-mode has been fixed, so hopefully this should be resolved now.
Can someone who is using lsp-mode from head confirm?

I tried out the patch and it works now. "no room in queue" still shows up for a period at startup, but after that things work to some degree.

@muirrn: thanks for confirming! Is there anything else specifically that's broken for you? I'm curious to know what you mean by "to some degree"?

I have no idea if these are client or server (or me), or if they are supposed to work or not, but:

i see "cannot find an enclosing function" LSP warning all the time (whenever cursor changes lines)
find all references doesn't work (i get an elisp error, haven't investigated yet)
documentation doesn't seem to show up (i only see the function signature in the documentation popup, but not the function's comments)

I had another issue where flycheck (i.e. gutter) errors weren't disappearing after the code issue was fixed, but that is not happening anymore.

Thanks for the information!

The enclosing function warning sounds like it's coming from the signatureHelp feature. I'm guessing it's lsp-mode trying to call signatureHelp whenever you move your cursor, so if you're not typing the parameters of a function, it's getting an error. I would say the problem here lies with lsp-mode, I don't think it's useful to call signatureHelp every time the user moves the cursor.
Find all references isn't yet supported in gopls, but we're working on it.
gopls don't yet offer documentation for signature help.

Great, thanks. Keep up the good work.

@stamblerre Regarding signature help: the editor might not necessarily know when to ask for signature help. Would it be acceptable to remove the error?

Looks like https://github.com/golang/tools/commit/96f2e7ef861b625ecc256679029cf597531360bc removed the error. Thank you!

Hi,
I'm still getting the error no identifier found when my cursor is on
something that is not an identifier.
I've updated both lsp-mode and golang.org/x/tools/cmd/gopls.
On Wed, Apr 10, 2019 at 2:59 PM Felix Lange<EMAIL_ADDRESS>wrote:

Looks like golang/tools@96f2e7e
https://github.com/golang/tools/commit/96f2e7ef861b625ecc256679029cf597531360bc
removed the error. Thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/31178#issuecomment-481679727, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAVhG6tKwmK8LlBRfYxq4Rz68sfTOqVPks5vfeBLgaJpZM4cU8i1
.

I think a recent change has made auto completion stop working in emacs. The initial list of completions shows up, but when you type a letter to narrow the completions, the completion popup disappears and it displays no object for ident D (or whatever letter you just typed). gopls seems to work fine in other editors, so it is something with lsp-mode (although by the same token, lsp-mode completions work fine with other language servers). Let me know if you think this is a lsp-mode issue and I'll engage with them. Below is the rpc trace of me typing "." to bring up the completion popup, then typing "P" to narrow the completions (after which the completion errors out with no object for ident P):
[Trace - 3:53:49 PM] Sending notification 'textDocument/didChange'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go","version":155},"contentChanges":[{"text":"package scratch\n\nimport \"fmt\"\n\nfunc main() {\n\tfmt.\n}\n"}]}

[Trace - 3:53:49 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/muir/scratch/go/foo.go","diagnostics":[{"range":{"start":{"line":6,"character":0},"end":{"line":6,"character":0}},"severity":1,"source":"LSP","message":"expected selector or type assertion, found '}'"}]}

[Trace - 3:53:49 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/muir/scratch/go/foo_test.go","diagnostics":[]}

[Trace - 3:53:49 PM] Sending request 'textDocument/completion - (1081)'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go"},"position":{"line":5,"character":5}}

[Trace - 3:53:49 PM] Received response 'textDocument/completion - (1081)' in 0ms.

Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go","version":156},"contentChanges":[{"text":"package scratch\n\nimport \"fmt\"\n\nfunc main() {\n\tfmt.P\n}\n"}]}

[Trace - 3:53:50 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/muir/scratch/go/foo.go","diagnostics":[{"range":{"start":{"line":5,"character":5},"end":{"line":5,"character":6}},"severity":1,"source":"LSP","message":"P not declared by package fmt"}]}

[Trace - 3:53:50 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///Users/muir/scratch/go/foo_test.go","diagnostics":[]}

[Trace - 3:53:50 PM] Sending request 'textDocument/completion - (1082)'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go"},"position":{"line":5,"character":6}}

[Trace - 3:53:50 PM] Received response 'textDocument/completion - (1082)' in 0ms.
Params: {"isIncomplete":false,"items":[{"label":"Print(a ...interface{})","kind":3,"detail":"n int, err error","sortText":"00009","filterText":"rint($1)","insertTextFormat":2,"textEdit":{"range":{"start":{"line":5,"character":6},"end":{"line":5,"character":6}},"newText":"rint($1)"}},{"label":"Printf(format string, a ...interface{})","kind":3,"detail":"n int, err error","sortText":"00010","filterText":"rintf($1)","insertTextFormat":2,"textEdit":{"range":{"start":{"line":5,"character":6},"end":{"line":5,"character":6}},"newText":"rintf($1)"}},{"label":"Println(a ...interface{})","kind":3,"detail":"n int, err error","sortText":"00011","filterText":"rintln($1)","insertTextFormat":2,"textEdit":{"range":{"start":{"line":5,"character":6},"end":{"line":5,"character":6}},"newText":"rintln($1)"}}]}

[Trace - 3:53:50 PM] Sending request 'textDocument/completion - (1083)'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go"},"position":{"line":5,"character":6}}

[Trace - 3:53:50 PM] Received response 'textDocument/completion - (1083)' in 0ms.
Params: {"isIncomplete":false,"items":[{"label":"Print(a ...interface{})","kind":3,"detail":"n int, err error","sortText":"00009","filterText":"rint($1)","insertTextFormat":2,"textEdit":{"range":{"start":{"line":5,"character":6},"end":{"line":5,"character":6}},"newText":"rint($1)"}},{"label":"Printf(format string, a ...interface{})","kind":3,"detail":"n int, err error","sortText":"00010","filterText":"rintf($1)","insertTextFormat":2,"textEdit":{"range":{"start":{"line":5,"character":6},"end":{"line":5,"character":6}},"newText":"rintf($1)"}},{"label":"Println(a ...interface{})","kind":3,"detail":"n int, err error","sortText":"00011","filterText":"rintln($1)","insertTextFormat":2,"textEdit":{"range":{"start":{"line":5,"character":6},"end":{"line":5,"character":6}},"newText":"rintln($1)"}}]}

[Trace - 3:53:50 PM] Sending request 'textDocument/documentHighlight - (1084)'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go"},"position":{"line":5,"character":6}}

[Trace - 3:53:50 PM] Received response 'textDocument/documentHighlight - (1084)' in 0ms.
Params: []

[Trace - 3:53:51 PM] Sending request 'textDocument/hover - (1085)'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go"},"position":{"line":5,"character":6}}

[Error - 3:53:51 PM] send textDocument/hover#1085 no object for ident P

[Trace - 3:53:51 PM] Sending request 'textDocument/signatureHelp - (1086)'.
Params: {"textDocument":{"uri":"file:///Users/muir/scratch/go/foo.go"},"position":{"line":5,"character":6}}

[Trace - 3:53:51 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"no signature help for file:///Users/muir/scratch/go/foo.go:5:6"}

[Trace - 3:53:51 PM] Received response 'textDocument/signatureHelp - (1086)' in 0ms.
Params: {"signatures":null,"activeSignature":0,"activeParameter":0}

@muirrn: it seems like the error you are getting from the hover request - if you notice, the completion returns the results for fmt that begin with P in the last 2 completion results. It seems like the interactions between the different requests is what's causing the problem. Would you mind opening this issue in lsp-mode so we can get some input from the folks who maintain it?

Formatting of the hover feature is not usable at all, for such clients as emacs and kak-lsp. Following screenshots are from kak but it's same in emacs. When struct or any other hover element is big, it's just not readable.

In contrast this is how bingo displays same hover:

Is it possible to preserve same formatting as bingo did?

@vbauerster

Formatting of the hover feature is not usable at all, for such clients as emacs

Just for the record, emacs is able to handle markdown, we had a bug which now is going to be fixed. There are at least two several language servers which return the same hover info format: scala metals and ruby language.

@yyoncho The issue is not in markdown handling (I use spacemacs, and there is no triple `), it is that any hover gets it output as one liner, thus making big structures unreadable. Notice a semicolon between struct fields in the first screenshoot, if there were 20 fields they would be all in one line separated by semicolons.

@stamblerre I looked in to the completion issue and the problem is gopls is using the prefix-trimmed insertion text as the filterText, and lsp-mode prefers the filterText if it is set. For example. you have typed fmt.P and you get back a completion with ~{Label: "Print", Insert: "rint", FilterText: "rint"}. lsp-mode says "P doesn't match filterText of rint", so it filters those completion options (and you are left with no options).
I surveyed some other clients/servers:

java/rust lsp don't set filterText
clangd sets it, but does not trim the prefix
vscode seems to match using the label or filterText, so you can mix and match from either (that is why the trimmed prefixes don't break vscode). the lsp spec seems to suggest filterText should supersede label if present, but maybe vscode does this to be more lenient in general.

Fixed as of https://golang.org/cl/176958.


security

Small security tweaks
Fix regex issue by pulling in http-headers
Fix audit issues

Codecov Report
Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.01%. Comparing base (c83b47a) to head (0ce71de).

Files with missing lines
Patch %
Lines

src/staticFile.ts
85.71%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   99.08%   99.01%   -0.07%
==========================================
  Files          16       15       -1
  Lines        1864     1833      -31
  Branches      189      184       -5
==========================================
- Hits         1847     1815      -32
- Misses         17       18       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Investigate numerical differences when using Coupling:Map and Coupling:Ramp

@timysnoturtle found that when using Coupling:Ramp to define a constant input results in longer and larger transient oscillations than when using directly Coupling:Map.

I've reproduced the reported issue, but so far failed to identify its cause. I have excluded the setting of deltanu and thus nu as a possible cause -- verified that they are set correctly in CouplingRamp. Reproduction notes follow.
CouplingRamp - Failure to Produce Result Consistent with Map
A Coupling specified as Ramp with the nus at the breakpoints as all equal should be equivalent to one specified as Map with nu set to the same value as all the nus.
Two .conf files that should be Equivalent
NOTE: these .conf files are written against branch deltanu-indexing on my repo, there is currently (2018-03-06) an open pull request (#157) against that branch.
The files are identical, except for that one uses Map with nu=0 and the other uses Ramp with all nus=0.
test_coupling_ramp_map.conf
Example configuration file for one-population neural field model,
with full space output for propagator.  Using Wave 5-point.
Time: 1.0 Deltat: 0.0001220703125
Nodes: 128

    Connection matrix:
From:  1  2
To 1:  1  2
To 2:  0  0

Population 1: Excitatory
Length: 0.5
Q: 10
Firing: Function: Sigmoid Theta: 0.01292 Sigma: 0.0038 Qmax: 340
 Dendrite 1: alpha: 83 beta: 769
 Dendrite 2: alpha: 83 beta: 769

Population 2: Stimulation
Length: 0.5
 Stimulus: PulseRect - Onset: 0.75625 Node: 128 Amplitude: 0.06125 Width: 0.00390625

Propagator 1: Wave - Tau: 0 Range: 0.2 gamma: 30
Propagator 2: Map -

Coupling 1:  Map - nu: 0
Coupling 2:  Map - nu: 1e-4

Output: Node: All
Population:
Dendrite:
Propagator: 1
Coupling:

test_coupling_ramp_ramp0.conf
Example configuration file for one-population neural field model,
with full space output for propagator.  Using Wave 5-point.
Time: 1.0 Deltat: 0.0001220703125
Nodes: 128

    Connection matrix:
From:  1  2
To 1:  1  2
To 2:  0  0

Population 1: Excitatory
Length: 0.5
Q: 10
Firing: Function: Sigmoid Theta: 0.01292 Sigma: 0.0038 Qmax: 340
 Dendrite 1: alpha: 83 beta: 769
 Dendrite 2: alpha: 83 beta: 769

Population 2: Stimulation
Length: 0.5
 Stimulus: PulseRect - Onset: 0.75625 Node: 128 Amplitude: 0.06125 Width: 0.00390625

Propagator 1: Wave - Tau: 0 Range: 0.2 gamma: 30
Propagator 2: Map -

Coupling 1:  Ramp - nus: 0 0 0 0 timepoints: 0.125 0.25 0.5 0.75
Coupling 2:  Map - nu: 1e-4

Output: Node: All
Population:
Dendrite:
Propagator: 1
Coupling:

Run them and Visual Compare from Matlab.
Place files above into test/numerical/, then run:
%% Run two simulations that should be equivalent.
obj_ramp0 = nf.run('./test/numerical/test_coupling_ramp_ramp0.conf')
obj_map = nf.run('./test/numerical/test_coupling_ramp_map.conf')

%% Extract some time-series data to plot.
[map_data map_time] = nf.extract(obj_map, {'Propagator.1.phi'}, [], [128]);
[ramp0_data ramp0_time] = nf.extract(obj_ramp0, {'Propagator.1.phi'}, [], [128]);

%% Over plot, should be identical.
figure
plot(map_time, map_data, 'k')
hold on
plot(obj_ramp0.time, ramp0_data, 'r')
lgd = legend({'Map' 'Ramp'})
title(lgd, 'Coupling')

%% PLot the difference, should be zero.
figure
plot(obj_map.time, map_data - ramp0_data)
title('Map minus Ramp')

I followed the same procedure but using a simple model with one population and one self-connection:
The file using Map is  test_coupling_map.conf
Test configuration file for issue #101

Time: 0.15 Deltat: 0.0001
Nodes: 900

    Connection matrix:
From:  1
To 1:  1

Population 1: Excitatory
Length: 0.5
Q: 10
Firing: Function: Sigmoid Theta: 0.01292 Sigma: 0.0038 Qmax: 340
 Dendrite 1: alpha: 83 beta: 769

Propagator 1: Wave - Tau: 0 Range: 0.2 gamma: 30

Coupling 1:  Map - nu: 1e-4

Output: Node: 1 Start: 0
Population:
Dendrite:
Propagator: 1
Coupling: 1

and the file using Ramp is test_coupling_ramp.conf
Test configuration file for issue #101

Time: 0.15 Deltat: 0.0001
Nodes: 900

    Connection matrix:
From:  1
To 1:  1

Population 1: Excitatory
Length: 0.5
Q: 10
Firing: Function: Sigmoid Theta: 0.01292 Sigma: 0.0038 Qmax: 340
 Dendrite 1: alpha: 83 beta: 769

Propagator 1: Wave - Tau: 0 Range: 0.2 gamma: 30

Coupling 1:  Ramp - nus: 1e-4 1e-4 timepoints: 0.05 0.1

Output: Node: 1 Start: 0
Population:
Dendrite:
Propagator: 1
Coupling: 1

Execution and comparison of the results in Matlab
%% Run two simulations that should be equivalent.
obj_map = nf.run('./test/numerical/test_coupling_map.conf');
obj_ramp  = nf.run('./test/numerical/test_coupling_ramp.conf');

%% Extract some time-series data to plot.
[map_data, ~] = nf.extract(obj_map, {'Propagator.1.phi'}, [], [1]);
[ramp_data, ~] = nf.extract(obj_ramp, {'Propagator.1.phi'}, [], [1]);

[map_nu, map_time] = nf.extract(obj_map, {'Coupling.1.nu'}, [], [1]);
[ramp_nu, ramp_time] = nf.extract(obj_ramp, {'Coupling.1.nu'}, [], [1]);

%% Over plot, should be identical.
figure
plot(map_time, map_data, 'k')
hold on
plot(obj_ramp.time, ramp_data, 'r')
lgd = legend({'Map', 'Ramp'});
title(lgd, 'Coupling: Propagator')

%% Overplot nus
figure
plot(map_time, map_nu, 'k')
hold on
plot(obj_ramp.time, ramp_nu, 'r')
lgd = legend({'Map', 'Ramp'});
title(lgd, 'Coupling: Propagator')

%% Plot the difference, should be zero.
figure
subplot(2,1,1)
plot(obj_map.time, map_data - ramp_data)
subplot(2,1,2)
plot(obj_map.time, map_nu - ramp_nu)
title('Map minus Ramp')

>> sum(map_nu - ramp_nu)

ans =

     0

These tests were done with master branch at commit 19abe3c55ed2b85c1265df756678827e986a86af


Questions on Approach

Trying to understand what's going on here, obv don't merge this

Is there a better way to do this? I am unsure


Keyring management

This PR contains the keyring management class for near protocol.

Repository changed from near to aurora controller and all the changes have been incorporated in the PR.


Update S3 SSE Docs

Update TF Docs for S3 SS3
Fix Variable issue

@jnonino apologies for not running pre-commit, and also i spotted a variable mistake

@justinsoong no problem. Thanks for your contribution!


Flap damp scoring

This is the first of several PRs to come for flap damping. The first is damp scoring. A member in the membership list will be penalized for every update that is applied. When the damp score exceeds the configured damp suppress limit, an event will be emitted. Later, this event will initiate the damping subprotocol. (That's the next PR to come). The damp scores for all members decay exponentially, its periodicity governed by another configurable parameter.
I left a few cheeky comments and added a few bells/whistles (like the separate Config object) to this PR to accompany the scoring. Don't mind them too much.
The test coverage is fairly reasonable.
Oh, and also... tick-cluster needed a bit of fixing. A member's damp score is now part of the returned stats. The way tick-cluster previously computed checksums for membership was too restrictive.
There's actually no net gain in terms of functionality in this PR. It's simply a mechanism to start scoring members and learning about scoring, in general.
@danielheller @benfleis @CorgiMan

done with this round. only potential bug is the explicit == 0 possibility above. other than that and 'changed', lgtm


Feature/fix errors

Last Fixes
Location
system_architecture.md
Readme.md
ml.py, viz.py
Descroption
Clean files for consistency
Add API Demo to ReadMe.md

 DS will update README for respective repository


feature/add-selectedDrawable-to-controller

https://user-images.githubusercontent.com/11909846/150744781-cb46c18b-7164-4f77-82ab-50c9a2af3f7d.mp4
With selected drawable we have we can remove it under selected mode.

due to the freestyle is not selectable, so the freestyle not support select and delete feature in current moment.

Drawables are non-multable objects, so once you modify the selectedDrawable (e.g. moving), a new copy instance of the drawable is created, and selectedDrawable would become invalid. This is why the index is used in _ObjectWidget instead of the drawable itself.
I also expected the pull request to be on the 1.0.0 branch, but it is on the master branch instead.
I'll work on the feature.


Test helm install on prs

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

/hold

/unhold /kind enchancement

/kind enhancement
/unhold

/lgtm


update(nf-v3-icon-list.lua): v3.1.1 icons

I've updated the list of icons in nf-v3-icon-list.lua to match with nerd-fonts v3.1.1.
The missing icons were mostly due to only including i_md.sh from https://github.com/ryanoasis/nerd-fonts/tree/master/bin/scripts/lib whereas all the icon files should have been included. Now, all the icons from all the files, up to what was in release v3.1.1, are included.
The old nf-v3-icon-list.lua file cut off the md_ prefix. This could be important information for users, so I have opted to leave the full name for every icon, including the set prefix intact.
On the nerd-fonts cheatsheet website, they change the name from snake case (how they appear in the nerd-fonts source) to kebab case, but for simplicity I have left them as snake case.
This fixes #19 and #15.
The script I wrote to generate this list is included in PR #21 so you can decide what you want to merge easier.

Thank you very much for your hard work I've been neglecting this repo and open source in general for quite some time. Seeing your enthusiasm really makes me happy. :smile:

Glad to help! This is a great plugin

Glad to help! This is a great plugin


Remove support for Python 3.4

Was removed via https://github.com/bigchaindb/cryptoconditions/commit/83beecbe6b099ece978a7df5a56137eaf7a081dd


fix: pom.xml & java/java-resteasy-filter/pom.xml to reduce vulnerabil…

…ities
The following vulnerabilities are fixed with an upgrade:

https://snyk.io/vuln/SNYK-JAVA-CHQOSLOGBACK-1726923
https://snyk.io/vuln/SNYK-JAVA-CHQOSLOGBACK-30208
https://snyk.io/vuln/SNYK-JAVA-CHQOSLOGBACK-31407
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1009829
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1047324
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052449
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1052450
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1054588
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056414
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056416
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056417
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056418
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056419
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056420
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056421
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056424
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056425
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056426
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1056427
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-1061931
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-174736
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-31507
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-31519
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-31520
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-31573
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-32043
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-32044
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-32111
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-450207
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-450917
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-455617
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-467014
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-467015
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-467016
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-469674
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-469676
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-471943
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-472980
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-540500
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-548451
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-559094
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-559106
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-560762
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-560766
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-561362
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-561373
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-561585
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-561586
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-561587
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-564887
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-564888
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-570625
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-572300
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-572314
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-572316
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-608664
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72445
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72446
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72447
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72448
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72449
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72450
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72451
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72882
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72883
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72884
https://snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONDATAFORMAT-30242
https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-32236
https://snyk.io/vuln/SNYK-JAVA-COMMONSIO-1277109
https://snyk.io/vuln/SNYK-JAVA-JUNIT-1017047
https://snyk.io/vuln/SNYK-JAVA-ORGAPACHEHTTPCOMPONENTS-1048058
https://snyk.io/vuln/SNYK-JAVA-ORGAPACHEHTTPCOMPONENTS-30646
https://snyk.io/vuln/SNYK-JAVA-ORGAPACHEHTTPCOMPONENTS-31517
https://snyk.io/vuln/SNYK-JAVA-ORGAPACHEHTTPCOMPONENTS-451097
https://snyk.io/vuln/SNYK-JAVA-ORGJBOSSRESTEASY-30119
https://snyk.io/vuln/SNYK-JAVA-ORGJBOSSRESTEASY-31200
https://snyk.io/vuln/SNYK-JAVA-ORGJBOSSRESTEASY-31203
https://snyk.io/vuln/SNYK-JAVA-ORGJBOSSRESTEASY-31206
https://snyk.io/vuln/SNYK-JAVA-ORGJBOSSRESTEASY-542664
https://snyk.io/vuln/SNYK-JAVA-ORGJBOSSRESTEASY-609370
https://snyk.io/vuln/SNYK-JAVA-ORGYAML-537645

test


Performance bottleneck in rendering lots of component elements

Vue.js version
2.2.2
Reproduction Link

https://jsfiddle.net/Kingdaro/1jpsbjz9/
Steps to reproduce
Toggle the list of elements on and off.
What is Expected?
Consistent speed between component list re-renders.
What is actually happening?
With "use component" unchecked: rendering is instantaneous.
With "use component" checked: rendering the components takes longer and longer each time the elements are rendered.
Tested in Firefox, Edge, Chrome and Opera. It seems to be most noticeable with Chrome and Opera.
This does not appear to happen in production mode, but cases like this during testing will mean eventually waiting full seconds for many components to render.

Hi, thanks for filling this issue.
Good rendering speed is way too broad, and without a benchmark comparison between other frameworks we cannot settle on a reasonable definition of Good.
Vue has always been dedicated to improving rendering performance, but unfortunately this issue can't really help us improve anything, since it's more of a complaint rather than constructive ideas on what exactly can be improved, so I'm closing it.

That's fair. I'll clarify, then: the rendering speed should be consistent between renders, fast or slow, but it's taking more and more time each time the list of elements are being rendered. This leads me to believe there's some sort of memory leak somewhere, where extra function calls are being done on data that should have been GC'd already.

Creating 1000 stateful components is obviously slower than creating 1000 spans

That's not the issue.

...it's taking more and more time each time the list of elements are being rendered.

Check the "use component" box, and toggle the components a few times to get a good idea of what I'm talking about here. The rendering of the components gets progressively slower each time.
And I mentioned that this doesn't happen with the production build, but the possibility of a memory leak of some kind is what pushed me to report this.

Ok, sorry for that, the title is so misleading. There's indeed a strange increase of render time that only happens on dev mode. I checked and there's no memory leak.

It's difficult issue to find and describe, so no worries.

This seems to be caused by calls to window.performance.measure. Might have leaking calls somewhere.


Update to latest

@campersau Looks like NuGet put an obsolete attribute on RawSearchResourceV3:
Severity	Code	Description	Project	File	Line	Suppression State
Warning	CS0618	'RawSearchResourceV3' is obsolete: 'Use PackageSearchResource instead (via SourceRepository.GetResourceAsync<PackageSearchResource>'	PackageViewModel	D:\dev\NuGetPackageExplorer\PackageViewModel\PackageChooser\ShowLatestVersionQueryContext.cs	22	Active

I see we already have fallback code to use PackageSearchResource, do you remember why we use the RawSearchResourceV3 first?

@clairernovotny Yes, I know, we use that for the download count per version https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/pull/340
I mentioned it when the API got obsoleted here https://github.com/NuGet/NuGet.Client/pull/3406#issuecomment-637036534
And also submitted a fix https://github.com/NuGet/NuGet.Client/pull/3433


Bug compatible WXCreateChatRoom

see https://github.com/lijiarui/wechaty-puppet-padchat/issues/62

Please test your code and confirm it works as you expected.
I do not believe it does what you want it to.

This PR looks better after you commit your new modifications.
I'd like to suggest that we should write a new pure function helper to implement this function, maybe fixWei() in fix-wei.ts is a good name for it, but it's just a suggestion.
And we need to bundle unit tests with the new function, I think there's already two in your comments:
   // BUG compitable: "\n\u00135907139882@chatroom" -> "5907139882@chatroom"
   // BUG compitable: "\n\u001412558026334@chatroom" -> "12558026334@chatroom"
   str.replace(/^\n[\u0000-\uffff]/g, '')

Good suggestion! I suggest:
filename: compatible-wei.ts
function: pureuserName()

Ok.
I'll merge this PR after you finished it.


CardElement intermittently doesn't appear on Safari

I've had multiple reports (with screenshots) from users of CardElement not rendering (just never appears) on Safari (one of them Version 10.1.1 (11603.2.5)). There were no errors in the console. The problem did not persist after a refresh, and I was not able to reproduce it.
I know this is not a terribly helpful bug report, but I thought you should know that I have seen this happen.

@GabeIsman thanks for the report -- is there a particular integration or webpage that you've seen this on?

Observed here: https://www.themarshallproject.org/support-us.

@GabeIsman Thanks! I'll take a look now.

Interesting -- I could only reproduce this no the first page load. Perhaps it has something to do with a cold cache.

I can now no longer reproduce this at all, even after disabling / clearing caches :(. I'll try again on a different machine tomorrow.

Thanks for looking into this @michelle. It was quite puzzling to me as well.

Hi @GabeIsman have you had any further reports of this? Just poking around and I can't seem to make this happen (tried a couple different things).

@fred-stripe I haven't had any further reports, but I don't think that I would have. (We have a low volume of Safari users.) I wish I had better guidance for you on how to reproduce. It seems to only happen once, if it does at all.

Hi @fred-stripe we have just moved over to the new elements library and are having a similar issue. We are getting the following error being reported sporadically to Sentry:

Please load Stripe.js (https://js.stripe.com/v3/) on this page to use react-stripe-elements.

this is despite the fact that the script tag is at the top of the page before the react app is loaded.
It is only happening on mobile safari on iOS 10.3.3 and 11.0.3. I have been unable to recreate this myself, which I realise is unhelpful, but I have the sentry errors if that is useful.

@Barnyclark are you still facing that issue? If not, since we're unable to reproduce this issue, we might go ahead and close it.

Ho @atty-stripe we are still having this issue, it is not restricted to safari though, we receive the error on a small number of requests across all browsers/devices.

Hmm that's strange -- could you share the Sentry issues please?

Here is an example: https://sentry.io/share/issue/30833e57245a420987aefd880febc927/

Thanks @Barnyclark!
Unfortunately there's little we can deduce from the Sentry issue, since it simply says that Stripe.js didn't load. Are you sure this wasn't a network issue or something else that actually prevented the script from loading? It might be useful to check if window.Stripe exists and report that in your logs, so the next time this error pops up you can be sure if this was simply a network issue that prevented the script from loading.
Otherwise we haven't been able to repro this. If you have any more info you can share, would love to see it!

Over the past 10ish days we have the same problem with 4 different customers -- all fo them were trying to open the payment page on Safari on their iphone.  Granted no idea what the iOS/Safari version is though.  I agree that it probably is an intermitent network delay on their mobile but would be nice if their was a "way to test" for it even if just to give a message to the user - "please refresh,  an error occurred while setting up the payment page"

It appears that this error is always triggered by Stripe.js failing to load over the network or loading in the wrong order. I am inclined to close this issue, since we understand what is causing it, and to use issue #237 as a place to discuss providing some API surface area for applications to be able to catch this error and respond to it in some useful way.

I ran into today as well. This seems to happen now consistently on Opera too. A couple of weeks ago there were no problems and the codebase hasn't been updated since. There are a couple of network requests to js.stripe.com that will never finish.

This has also been occurring in our app that is a NextJS app. It only occurs in Safari and Safari on iOS. It only happens when the user uses the "refresh" button in Safari. If you click in the address bar and click the enter key, it works fine. I notice in the inspector that certain Stripe assets just do not load.

I originally thought it might be an SSR issue, but I ruled that out by testing a statically deployed site.
Could it be something related to how NextJS is bundling the assets or something to do with how Safari caches certain assets? I am at a loss. I appreciate any suggestions.

I’m having the same issue as @kevinswarner.


Sequences: cleanup old code

I'm currently redoing the implementation for sequences but with the old code in place. I'm leaving the previous code untouched because I'd like to run some comparisons between old and new code.
As such, there is going to be a cleanup phase at some point. I'll keep track of items here.

Store only one version of the components, namely the "resolved" ones.

Current parameters for sequences are overwritten by the names of the components. Fix this!

It turns out the two tests for sequences and parameters in ActionsApiTests are broken. The initial sequence action is never installed in the db. I'm ignoring these tests for now and fixing once I have the implementation for sequence all in.

@ioana-blue status?

I believe the cleanup happened a while ago. Closing as this issue is not actionable as is anymore.


docs: Join a Zulip Organization

Added a doc for joining a Zulip organization

Automated message from Dropbox CLA bot
@Jeffthebest1, it looks like you've already signed the Dropbox CLA. Thanks!

I have one wording suggestion, and then I think this is ready to merge.

@showell Fixed! 👍

Here is a screenshot of the working doc:

I don't think the links in the opening paragraph work outside the glossary. :(  We can probably just make them plain text.

@showell Fixed! 👍

Steve Howell says this is good for merge

There are rendering edits that you should PROBABLY fix for best case results. You may ignore my suggestions if @showell agrees that they're unnecessary.

@showell and @trueskawka, can you please take a look?

Thanks @umairwaheed and @synicalsyntax. Fixed! 👍

Oops, I missed that @TomaszKolek. It's now fixed! 👍

Merged, thanks @Jeffthebest1!! :)


Getting started with Data Preprocessing in R

Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
Getting started with Data Preprocessing in R
Your title should be descriptive of the article/tutorial. Be Specific. Use keyword research to gain your article higher ranking.
Introduction paragraph (2-3 paragraphs):Getting started with Data Preprocessing in R.
Data preprocessing is the intial stage in the machine learning model in which data is imported and transformed into a basic form that makes it easy to work with.
Activities that take place at this step include,

Transforming data into a format of tidy data, i.e,
Tidy data is a dataset with characteristics such as,
i) One observation per row
ii)One variable per column
iii) One entry per cell.
Detecting presence of Missing value in the data and how to handle them.
Detecting and handling outliers in the dataset using appropriate methods present in the R software.
Detecting duplicates in the data and rectify if any is present.

In this tutorial, I will explain all steps that are involved in data preparation so as to have the right data for creating reliable models for machine learning.
Please write the Introductory paragraph(s), that would be included in your article. We will use this writing snippet to help us assess overall quality before approval. We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Take your time and write the content as you would intend to get it published.
Key takeaways:
This tutorial will enhance the reader with a complete understanding on how to create clean dataset from messy one that is suitable for creating reliable model.  Reliable model is the one which gives the right prediction.
What are the 3-5 most important things the reader should understand or be able to do after reading this article? Use this area to get your ideas down on the bulk of your article or tutorial.
References:
Please list links to any published content/research that you intend to use to support/guide this article.
N/A
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

good topic @Daniel695  - approved. One important note: please be sure to put your article through a thorough grammar/readability editing review prior to submitting for final approval. This will help increase the likelihood of your article getting published and you receiving a payout :)


Fix snippet in docs/apalache/parameters.md

The module actually goes until line 15: https://github.com/informalsystems/apalache/blob/0795560e3382fc22b5b5ecabc02346bd5b2849d8/test/tla/y2k_instance.tla#L1-L15
Btw, at a quick glance it doesn't appear that the contributing guidelines mention anything about PRs for docs.

Thanks very much for the contribution @BGR360! :pray:

Btw, at a quick glance it doesn't appear that the contributing guidelines mention anything about PRs for docs.

Is there any particular information you think it would be useful for us to add there on the topic?

Codecov Report

Merging #2295 (d171665) into main (0795560) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
- Coverage   78.61%   78.61%   -0.01%
==========================================
  Files         435      435
  Lines       14844    14844
  Branches     2060     2060
==========================================
- Hits        11670    11669       -1
- Misses       3174     3175       +1

Impacted Files
Coverage Δ

...he/io/annotations/parser/CommentPreprocessor.scala
96.70% <0.00%> (-1.10%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Is there any particular information you think it would be useful for us to add there on the topic?

@shonfeder that's your call as the maintainer(s)! If there's nothing in particular you want out of these sorts of contributions, then I'd just explicitly say that. Like "for contributions not relating to the source code (such as changes to documentation), none of the other stuff mentioned here matters."

I’ll review the contributing guidelines with an eye to the docs :)
Thanks again!


'New Notebook' option in 'Notebook' at the top level menu

Should the notebook menu have a 'New Notebook' option?
This could be more consistent as other plugins have the same option

Yep, go for it!

Sounds good!

#552


python3Packages.pot: fix build on darwin

Description of changes
ZHF: #172160
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build python39Packages.pot python310Packages.pot

Result of nixpkgs-review pr 174617 run on aarch64-darwin 1

2 packages marked as broken and skipped:

python310Packages.pot
python39Packages.pot


get ENS address from resolver rather than owner

For #1173
@hboon do we need EthereumAddress and Address?
@JamesSmartCell Please ensure that Android does this correctly.

@hboon do we need EthereumAddress and Address?

@James-Sangalli Unfortunately yes, the former is part of the Web3Swift pod and latter is part of TrustKeyStore; they have be used when interacting with the respective pods.
I was working on a branch a long time ago to introduce a third Address type (the horror!) which will replace web3swift.EthereumAddress/TrustKeyStore.Address for most of the cases so we can be less tightly coupled TrustKeyStore (good clue is to search for how many files include "import TrustKeystore" just to use the Address type). This new Address type will then provide a way to convert to/from EthereumAddress and TrustKeyStore's Address when we really need them. It's a general approach that is useful to be less dependent on third party libraries. Our codebase has changed a lot from implementing multi-chain and TokenScript.. so will have to restart that effort again.
Part of switching to our own Address type should also include converting all String representations of addresses to the new type. But this is all part of another issue/PR.

@hboon the test works properly with the new method

Good job!


Add Base After Base Piano Cover by Symphoniac

Song Name
Base After Base Piano Cover
Artist Name
Symphoniac
Source
Youtube
Youtube Link
g6TMgQnydNI
Direct File Link
No response
Song ID
4
Start Offset [ms]
9300
Extra
Created from Auto Nong.
Created for level: 1368883

accept


Binary Tree Right Side View Leetcode

do remember to add a new line at EOF

Ohk I will do , for now you have accepted my pull request  or not ?


Also find a reference on 'Id' instead of only 'ID'

References are only found on the 'ID' attribute, but my references where on 'Id'.
Not sure if you still maintain this library, but maybe this pull request will help other users with the same problem. Thanks for the great library!

Its been awhile since this has had any changes, so I had to fix the Travis CI build.  Merging in the latest should fix your branch too.

Do we want to handle ID/Id as a special case? Or support some more xpath-like options?


chore(deps): update terraform github.com/terraform-ibm-modules/terraform-ibm-landing-zone to v5.24.7

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/terraform-ibm-landing-zone
module
patch
v5.24.6 -> v5.24.7

Release Notes

terraform-ibm-modules/terraform-ibm-landing-zone (github.com/terraform-ibm-modules/terraform-ibm-landing-zone)
v5.24.7
Compare Source
Bug Fixes

update the default VSI image name to ibm-ubuntu-24-04-minimal-amd64-2 (#819) (8c3eae4)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.4.12 :tada:
The release is available on:

GitHub release
v1.4.12

Your semantic-release bot :package::rocket:


chore(main): release 1.2.1

:robot: I have created a release beep boop
1.2.1 (2024-05-24)
Bug Fixes

README (97cbf7b)
README (7b992a0)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/chiba-ai-med/SBSMTFCV/releases/tag/v1.2.1 :sunflower:


Generate bintray.descriptor in build so we can use latest tag

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     90.12%   90.12%
  Complexity      383      383
=========================================
  Files            23       23
  Lines          1073     1073
  Branches        185      185
=========================================
  Hits            967      967
  Misses           44       44
  Partials         62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc8958...0e492a1. Read the comment docs.


packages/exhibitor: run zkServer.sh stop on system unit exit

High-level description
Make sure that zkServer.sh stop is executed when systemd unit is restarted.
Corresponding DC/OS tickets (required)

DCOS-57231 Exhibitor fails to reestablish quorum after restore

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): n/a
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain: There are no tests for systemd units. This change is potentially fixing a failing test.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review


Change look of references

closes #412
The only thing about this PR that I don't understand is the References.sublime-syntax file.
I just copied the Diagnostics.sublime-syntax and made some adjustments, like deleted some things, renamed some.
The syntax looks ok to me, but I would suggest someone else who knows better to have a look at it, just to check if everything is alright.
If you have any question, concern, let me know.

Coverage decreased (-0.2%) to 28.37% when pulling 3990ec06f179da77eb62d08bd081234efeaad003 on predragnikolic:change-look-of-references into 2ffc5e955cde1aa49d7506994b4f494a90abb6ff on tomv564:master.

Danke @FichteFoll  :)

I wonder if references can share some code (eg syntax) with diagnostics again?

I don't know the answer to this question. :D


add ability to change sort order of file in the file section

Please add the ability to set or change the sort order for the view of file list.

implemented to ensure sorted by name: https://github.com/photobooth-app/photobooth-app/commit/686f7678c2f124881d15b6c0af32e3f5ac6ba6a2


Make user aware that findCharactarPos returns top of the line position

This doesn't need any testing, just documentation changes. I really do think a lot of this confusion may be avoided if we atleast mention this "top of the line" stuff

Made a PR with the wrong branch


Select with dynamic options

You can read this question in stackoverflow.
I'm trying to create a dynamic select with options that are in a state.
I've tried two things:
I've tried to create a custom selector using an stateless function. I pass to the function the prop that has the data that can fill the select with options. Something like this:
const renderFieldSelect = ({ name, label, templateList})  => {
	if(templateList && templateList.entities) {
		return (

					{label}

					<Field
						className="form-control"
						name={name}
						component="select"
                    >
						{
							templateList.result.map((type, index) =>
								return <option value={templateList.entities.template[type].id}>{templateList.entities.template[type].name}</option>
							)
						}
					</Field>

		)
	}else {
		return

}

//... more stuff

class Bla extends Component {

  //... more stuff
    render(){
        return (

                <Field
                    component={renderFieldSelect}
                    name='templateList'
                    label='label'
                    templateList={this.props.templateList}
                />
                <Field
                    component="input"
                    name='addNewOption'
                    type='text'
                />
                <button onClick={addOption}>Add new option</button>

        )
    }
}

But when I update the templateList (using the input and the button), the object doesn't rerender with the new option (Which I find really odd). I know that the addOption function is working because it passes thru its reducer
I tried to create something similar with FieldArray but I don't know how to update the fields parameter. The documentation is not very clear about what does this prop has/could have. Also, I don't know either if you can create a "Field" and return just the or something like that.
Thanks

It was answered in stackoverflow. Thanks :)


[SPARK-44737][SQL][UI] Should not display json format errors on SQL page for non-SparkThrowables on SQL Tab

What changes were proposed in this pull request?

This pull request addresses the issue of inconsistent display for SparkThrowables and others. Currently, SparkThrowables appear as plain text while others are displayed in JSON format on SQL Tab. This fix aims to make the display consistent across all items.
Why are the changes needed?

To fix the inconsistent behavior, and the JSON format is not correctly displayed.
For those non-SparkThrowables thrown by SQLExecution may contain errors either that we are not ready covered by the new error handling framework or some critical path(what I have met is OOM in RDD.getPartitions), we shall supply the stacktraces
Does this PR introduce any user-facing change?

no
How was this patch tested?

add a unit test

@panbingkun
https://github.com/yaooqinn/spark/actions/runs/5805477173/job/15746890453
This is the third time I've witnessed a RocksDB crash. It seems like a risk. Do we need to roll back to the previous version that we were using?
There is already a Jira ticket tracking this issue: https://issues.apache.org/jira/browse/SPARK-44580

@panbingkun https://github.com/yaooqinn/spark/actions/runs/5805477173/job/15736662791

This is the third time I've witnessed the RocksDB crash. It seems like a risk. Do we need to revert to the previous version that we were using?
There is already a Jira ticket tracking this issue: https://issues.apache.org/jira/browse/SPARK-44580

Let me investigate it first.

cc @gengliangwang too

thanks, merged to master and 3.5


cluster: fix panic when tls_client_config is empty

Closes #3403

Note that I assumed that the TLS client configuration isn't required (though in most cases you probably want to provide the CA/cert/key). Feel free to correct me if I'm wrong :)


Repeating messages after 'send-error'

Add this to the protocol:

A client MUST repeat messages after a send-error response from the server at least once but SHOULD send it n times.

Reason: When a handover occurs in some tasks (WebRTC, ORTC) a message may be lost on the signalling channel. After a send-error the message will be repeated at least once over the now established signalling channel the original signalling channel has been handed over to.
We should specify n.

Could there be cases where re-sending is not desired or helpful?

For example on the signalling data channel. Once the data channel closes, the peer will not be reachable any more.

Unless the task switched to yet another signaling channel.
Also, what if the message history buffer contains 10 entries, but 15 messages were sent between the faulty message and the send-error rresponse? Then the client cannot repeat the message even though it MUST.

Well, the channel itself is reliable so that is probably an unrecoverable error? Also, we haven't really talked about this yet but resending leads to unordered messages which could be a problem.

Also, we haven't really talked about this yet but resending leads to unordered messages which could be a problem.

Yes. I think I'd favor an approach where the handshake flow (peer - server and peer - peer) is properly covered by the client library itself (including appropriate re-sending), but where the handling of task-level send errors is left to the implementor of these tasks.

This is how I'd handle the data message errors: https://github.com/saltyrtc/saltyrtc-client-java/pull/9

What happens in case a send-error occurs during the handshake (e.g. before the task take action)?

That should be handled by the core client library (there's still a TODO in the code).

In the client library, I'd say that re-sending a core (e.g. auth, token, etc) message MUST be retried at least once, but SHOULD be retried 3 times. What do you think?

I don't know whether the unordered messages would lead to a problem at particular points of the message flow. I'll need to think about this.

That depends on the implementation. It might reduce parallelism a bit. But in almost all stages of the handshake, the client waits for a certain type of message and won't continue before receiving it.

Repeat up to three times, each time after a send-error message has been received. Only for client-to-client messages.


Fix typo

Fixes #44994

@Potapy4 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Correction confirmed. Thanks.


Switch to gogo and yarpc compilers

What changed?

Why?

How did you test it?

Potential risks

Coverage decreased (-0.03%) to 66.72% when pulling a449c3a784c19a0fb17444090bf3e07e21c41531 on vytautas-karpavicius:protoc-gogo-yarpc into 1e8b738ef54a39ca5aa6ae9a8ecd382a16315fdb on uber:master.


MWPW-157037: Nonprofit handover

Resolves: MWPW-157037
Test URL: https://mwpw-157037-handover--dc--adobecom.hlx.page/drafts/astatescu/nonprofit/

Codecov Report
Attention: Patch coverage is 89.35361% with 28 lines in your changes missing coverage. Please review.

Project coverage is 89.25%. Comparing base (b7fee35) to head (b214eaf).
Report is 18 commits behind head on stage.

Files with missing lines
Patch %
Lines

acrobat/blocks/nonprofit/nonprofit.js
88.39%
26 Missing :warning:

acrobat/blocks/nonprofit/nonprofit-select.js
81.81%
2 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##            stage     #832       +/-   ##
===========================================
+ Coverage   67.71%   89.25%   +21.54%
===========================================
  Files          48       49        +1
  Lines        7604     7762      +158
===========================================
+ Hits         5149     6928     +1779
+ Misses       2455      834     -1621

Flag
Coverage Δ

89.25% <89.35%> (+21.54%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


expectRevert not working as expected

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (b3fe652 2022-04-18T00:12:45.381840+00:00)
What command(s) is the bug in?
forge test
Operating System
macOS (M1)
Describe the bug
See this test:
    function testSetFeeTo() public {
        assertEq(engine.feeTo(), FEE_TO);
        VM.expectRevert();
        engine.setFeeTo(ALICE);
    }

From here:
https://github.com/Alcibiades-Capital/valorem-options-contracts/blob/tabula_rasa/src/test/OptionSettlement.t.sol#L146
Produces the failure output:
[11837] OptionSettlementTest::testSetFeeTo()
    ├─ [2383] OptionSettlementEngine::feeTo() [staticcall]
    │   └─ ← 0x36273803306a3c22bc848f8db761e974697ece0d
    ├─ [0] VM::expectRevert()
    │   └─ ← ()
    ├─ [736] OptionSettlementEngine::setFeeTo(0x000000000000000000000000000000000000000a)
    │   └─ ← "AccessControlViolation(0xb4c79dab8f259c7aee6e5b2aa729821864227e84, 0x36273803306a3c22bc848f8db761e974697ece0d)"
    └─ ← "AccessControlViolation(0xb4c79dab8f259c7aee6e5b2aa729821864227e84, 0x36273803306a3c22bc848f8db761e974697ece0d)"

When the revert should be expected. The same happens when using the bytes4 selector.

Discovered on; https://github.com/Alcibiades-Capital/valorem-options-contracts/pull/32
Reproduced more simply on; https://github.com/Alcibiades-Capital/valorem-options-contracts/pull/33

expectRevert with no parameters expects a revert() (i.e. a revert with no message). You should expect the AccessControlViolation error. See the book for examples and docs, more specifically, you probably want something like the example in the book:
cheats.expectRevert(
    abi.encodeWithSelector(MyContract.CustomError.selector, 1, 2)
);

        assertEq(engine.feeTo(), FEE_TO);
        vm.expectRevert(abi.encodeWithSelector(IOptionSettlementEngine.AccessControlViolation.selector, address(this), FEE_TO));
        engine.setFeeTo(ALICE);
        vm.startPrank(FEE_TO);
        engine.setFeeTo(ALICE);
        vm.stopPrank();
        assertEq(engine.feeTo(), ALICE);
    }``` - yup, that worked.

The bad assumption here was that a blank revert would catch any revert, but it seems like there needs to be an exact match with the memory segment returned.


Adding Container structure test JSON output result reader for publishing the container structure test results

Adding result readers for the container structure test result readers.

This PR will be in 159, no need to port to a older release branch


Tags label not rendering in YAML front matter despite inclusion in template and front matter setting

When importing articles into Obsidian, every element of my Article Template (in settings) is inserted as expected except for the tags label in YAML front matter.
See below image for current settings:

And here is the most recently imported article's YAML front matter:

Steps to Reproduce

Update Article Template to include desired front matter labels and variables, including tags.
Add new highlight to article in Omnivore and add new labels to serve as tags.
Sync with Omnivore in Obsidian
Open imported article

Solved
Had to double-check that tags were included in both settings boxes and labels were assigned to the article.


Calling an Extension Method While Invoking A Method Throws Verify Error: Bad type on operand stack

Description
Using @ExtensionMethod where a parameter to the extended method is the result of invoking a method will result in a Verify Error: Bad operand type on stack. See the example for clarification.
What steps will reproduce the problem?
Run the example code below in a clean Eclipse project that uses lombok.
What is expected output? What do you see instead?
A VerifyError is thrown.
What version of the produce are you using? On what operating system?
Lombok v1.16.6
Eclipse Mars.1 Release (4.5.1) Build id: 20150924-1200
Java version "1.8.0_51"
Java(TM) SE Runtime Environment (build 1.8.0_51-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.51-b03, mixed mode)
Linux
Please provide any additional information below
Exception:
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    VerifyErrorBadOperandLombokExtensionMethodTest.main([Ljava/lang/String;)V @19: checkcast
  Reason:
    Type integer (current frame, stack[1]) is not assignable to 'java/lang/Object'
  Current Frame:
    bci: @19
    flags: { }
    locals: { '[Ljava/lang/String;', 'VerifyErrorBadOperandLombokExtensionMethodTest$CanReturnInt' }
    stack: { 'java/lang/Object', integer }
  Bytecode:
    0x0000000: bb00 1059 b700 124c bb00 0359 b700 082b
    0x0000010: b600 13c0 0017 b800 19b2 001f 1225 b600
    0x0000020: 27b1

    at java.lang.Class.getDeclaredMethods0(Native Method)
    at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
    at java.lang.Class.privateGetMethodRecursive(Class.java:3048)
    at java.lang.Class.getMethod0(Class.java:3018)
    at java.lang.Class.getMethod(Class.java:1784)
    at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:544)
    at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:526)

Minimal example that fails when run in Eclipse, but will pass from the command line:
import lombok.experimental.ExtensionMethod;

@ExtensionMethod(VerifyErrorBadOperandLombokExtensionMethodTest.Extensions.class)
public class VerifyErrorBadOperandLombokExtensionMethodTest {

    public static class Extensions {
        public static void invoke(Object o, int i) {
        }
    }

    public static class CanReturnInt {
        public int returnsInt() {
            return 0;
        }
    }

    public static void main(String[] args) {
        CanReturnInt anIntReturner = new CanReturnInt();
        new Object().invoke( anIntReturner.returnsInt());

        System.out.println("If you are seeing this then things worked.");
    }

}

Updated description. Turns out the default method was a red herring.

Further investigation makes be believe this is an issue with auto-boxing. If the call the extension method is written as below it passes:
new Object().invoke( (int) anIntReturner.returnsInt());

Not the explicit cast to an "int".

Can confirm this issue, very annoying.


Roll dart to 1.25.0-dev.4.0

Picks up some fixes for how pub behaves with no internet connection (https://github.com/flutter/flutter/issues/10138).

@tvolkert @pq, what was the reason we cut short the previous roll to 1.24 final?

Hmmmm.  I'll defer to @tvolkert.  I can't remember what the exact issue was.  Sorry!

We did roll to 1.24.0 stable in #10931, and then it was rolled to 1.24.2 in #10985 to pick up analyzer fixes in the SDK.


docs: remove fntlnz

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind feature

/kind sandbox

/kind incubating

/kind officialsupport

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area deploy

/area examples

/area integrations

/area proposals

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

5be1395 docs: remove fntlnz

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Closed in favor of #155
/close

@leogr: Closed this PR.

In response to this:

Closed in favor of #155
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Rust testing

Add more facilities for testing in rust.

As you noticed, I had a real problem with naming things when I was working on this.
agreed with all, will rework.

https://martinfowler.com/bliki/TwoHardThings.html :(

I gave some alternative naming suggestions :P


Consider focusing the dialog on open

Following a suggestion from @thierryk on Twitter: https://twitter.com/7h1322yk0813n72/status/1366088196207964160?s=20

Done in 7.2.0.


Rework latex particles into new particle engine capable of attaching to models

The current latex drip particles aren't done good at all, and were done in such a way to just get them in. I was considering having bits of small globs of goo that would drip off the surface of the entity's actual model, maybe even strands of goo that would string between nearby parts.
Technical decisions still need to be made on what the particles should look like (Billboard quad? surface aligned quad? a 3d model?).
Do the latex beasts in Changed even drip? I suppose it's like slowly losing your body drip by drip.

Initial issue has been implemented but there is room for improvements (e.g. Pulling drip color from sampled entity texture)


.form-control kills ability to have narrow s

Here's the problem.   I want to make a select box (drop down) that has a maximum width.  I set the maximum width.  On a wide screen, it gets overridden by https://github.com/twbs/bootstrap/blob/a2680e8b6ba628312780b00d8d74d28d28b89a84/less/forms.less#L477 :
width: auto; // Prevent labels from stacking above inputs in `.form-group`

This trumps anything done trying to keep the select box small enough to prevent my labels from stacking.  Specifically, if the screen is small, the size of my select drop down is limited.   Once the size of screen goes past a certain point, the .width attribute down in bootstrap overrides my .width attribute, which makes a very long label blow the select box to very wide, which pushes other components on to another line.

Setting a max-width seems to work fine for me in Chrome: http://jsbin.com/yuhaha/1/edit
Could you explain how or post an example where it's not working for you?

Hi @cvrebert!
You appear to have posted a live example (http://jsbin.com/yuhaha/1/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 43, column 13 thru line 43, column 19: Element style is missing required attribute scoped.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

If you match or exceed the specificity, you shouldn't have a problem. Using max-width should also override any width that's set. Closing as not a bug though for now.


Volunteer Hours: Decimal Readability Update

User Interface: Take off unnecessary decimal points in hour calculations.

Should it be reported in minutes then?  XXX Hours YYY Minutes?
Are all prizes in whole hours? Otherwise it gets weird to determine if a given person is eligible.

XXX Hours YY Minutes
All gifts are in whole hours

Do fractional hours make more sense?  7.5 hours?

Currently it is decimal.

Here is with Hour... Min...

Please excuse the funky minutes remaining that is because of the way test data is generated.

Ideally, there would not be any trailing zeros.
So, we would only see the following (for example, in Actual Hours Column):
X  or X.0
X.25
X.5
X.75
With the minutes being rounded, these are the only outputs that we should see for the calculated hours (and hours remaining).

Ok so no "Hour XX Minute YY" You just want 2 decimal points preferably only on the quarter hours?
I am now confused.

OK, So I think I understand the confusion.
When talking about the total outputs, Hour XX Minute YY is fine.
The decimal readability is referencing the "listing" of hours, such as in your screen shot, the Actual Hours listed and in the Volunteers Page the Total Hours. Since all time will be rounded, the only outputs in the "minutes" section of calculated hours should be X.0, X.25, X.5, and X.75.

In other words, as long as the rounding is functioning correctly, that will be the output, the readability is to eliminate the unnecessary trailing zeros (so X.5 not X.50).

Understood.  Got-it!

Please retest with new release, re-open if failure remains.


relate might insert duplicate rows or cause constraint violations in the join table

I have a many-to-many association between two models. Calling relate populates the join table properly, but if I call it a second time, it will attempt to insert a duplicate row. This might cause a duplicate or a constraint violation, depending on the db setup.
Is this intended behavior and do I need to check if the relationship already exists before calling relate, or is it a bug?

Totally intended for multiple reasons.

Sometimes duplicate rows are actually needed
Checking for duplicates would require a separate query and to make the operation atomic, a transaction would need to be enforced.

The best way to deal with this is a unique constraint and catching the violation error.

Thanks for the prompt reply @koskimas! Happy new year to the Objection team!

@koskimas, just realized one thing regarding this issue. It is quite hard to catch the violation error in a way that is agnostic to the specific database being used. SQLITE will throw an error with error.errno === 19, Postgres something with error.code === 23505, etc.
I wanted to make this code solid enough to work across the different DB engines supported by knex, but without breaking every time something changes on that side..
I guess I will have to check if the relation already exists beforehand, probably opening a transaction for that, exactly what you describe in 2) but just wanted to double check I was not overlooking something...

Just came across objection-db-errors, perhaps it is what I am looking for, will have a look :)


Optimize file handle logic

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Optimize import_files.sh using logic
Which issue(s) this PR fixes:

Special notes for your reviewer:

/lgtm

/lgtm


documentation

This is an awesome library but it is poorly documented and the demo project is not so readable

The updated documentation can be found here.


Pre-release for the null safety migration of this package.

Hi,
I migrated this package to the null safety and therefor would be nice if you could update the package in pub.dev.
Thx in advance for your help.
Cheers,
Pal

@stevenroose @hitecherik any update to get this merged / published? Downstream packages need this package migrated so they can migrate.

Hey -- I'm not a maintainer, so I think only @stevenroose can help :)
On February 11, 2021, GitHub<EMAIL_ADDRESS>wrote:

@stevenroose https://github.com/stevenroose
@hitecherik https://github.com/hitecherik any update to get this
merged / published? Downstream packages need this package migrated so

they can migrate.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stevenroose/dart-hex/pull/3#issuecomment-777811565,
or unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAPYBADFLAQZ2YMRLGOCVN3S6RFO3ANCNFSM4T6HDRRA>.

Notice that now dart 2.12 has officially been released, so it could just be version: 0.2.0 and test: ^1.16.5

If it doesn't need to be a pre-release, feel free to update this to 0.2.0 and I can merge it and release it :)


no OAS-type exists for field.JSON fields

Following along with the blog on an existing schema got me these results:
go generate ./ent/
2021/09/13 09:16:58 running ent codegen: no OAS-type exists for "*[]schema.Source"
exit status 1
ent/generate.go:5: running "go": exit status 1

In my schema Source is defined as
field.JSON("sources", &[]Source{}).Optional(),

Are JSON fields not supported by this plugin? If not what are the chances that they will/could be ?
Latest version of everything (Go, Ent, Elk)

Hey @JamesHovious!
JSON fields are currently not support for the OAS generation but I am already working on it.  My plan is to have this done next week.

Hey @JamesHovious, I have some bad news: Generating a schema for the used type in field.JSON() is not as trivial as I thought.
@a8m Can you be of help here? I currently have no way of getting a reflection of the type given to field.JSON() and therefore cannot get information about the properties of that type. A current (bad) workaround is putting a JSON type as undefined map into the spec.

maybe this helps ? https://github.com/buger/jsonparser

Missing this :(

This issue is for entoas, bu it is already fixed in master through usage of annotations.
field.JSON("meta", &[]Source{}).Annotations(entoas.Annotation{
	Schema: ogen.String(),
})

This issue is for entoas, but it is already fixed in master through usage of annotations.
field.JSON("sources", &[]Source{}).Annotations(entoas.Annotation{
	Schema: ogen.String().AsArray(), // or something else, dunno.
})

You can even go further and create your own schema for the Source:
field.JSON("sources", &[]Source{}).Annotations(entoas.Annotation{
	Schema: ogen.NewSchema().
		AddOptionalProperties(
			ogen.String().ToProperty("string"),
			ogen.Int().ToProperty("int"),
		),
})

This will improve documentation and codegen capabilities of swagger etc.

That's very nice 👌

@masseelch wow that looks like the annotations can describe a json schema at runtime . This means that I can load me schema at runtime. Which then means I can expose it as an API as well as gen my swagger at runtime  ?
this is really sneaky stuff


Fixing attribute name mistake: setguid => setgid

Motivation for this change
Fixing a coding mistake in the changes made to nixos/modules/security/wrappers/default.nix for the setcap wrapper support.
The mistake was related to conditional logic checking if a setuid or setgid attribute was set on an argument set and if so if either were true. The mistake was that setgid was misspelled as setugid which means that if a wrapper program had setuid = false but setgid = true and no permissions attribute in the argset it would use the default mkSetuidProgram configuration.
This is not correct behavior because it means a program's user or group if neither of those attributes were not set in the argset would be defaulted to root and this is dangerous.
The fix is to correct the spelling mistake.
This was caught while investigating #26611.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I have yet to build and test this, I will probably get to that tonight, so don't merge until that has happened.

It seems a safe change to me, but let's wait if you prefer.  Typo introduced in e92b8402b0.

@vcunat okay, I tested the build and I also verified that when services.postfix.enable = true; the sendmail program's uid is nobody and its gid is postdrop with the SGID bit set.
Thanks for the quick review.

Picked to 17.03, too, as the situation in the surrounding code seems very much the same.


whats the difference between r_frame_rate and avg_frame_rate ?

Hi,
I want to know about r_frame_rate and avg_frame_rate significance.
these are the  output parameters.

r_frame_rate is "the lowest framerate with which all timestamps can be represented accurately (it is the least common multiple of all framerates in the stream)."
avg_frame_rate is total duration / total # of frames

r_frame_rate is "the lowest framerate with which all timestamps can be represented accurately (it is the least common multiple of all framerates in the stream)."
avg_frame_rate is total duration / total # of frames

Minor correction. I think the avg_frame_rate is total # of frames / total duration.
The denominator and the numerator is changed. (30 frames in 1 sec = 30 fps)
And I want to know the source about the avg_frame_rate. I was able to find this thread, but I couldn't find the same info from the documentation.

I think it is more accurate to say that avg_frame_rate is (nb_frames / time_base ) "/" duration_ts
Essentially the total duration is calculated based off the time_base (Usually tbn) multiplied by the largest presentation timestep in the file (duration_ts).

Sorry to re-awaken this thread, but...
Since nb_frames is the number of frames in a stream, not the number of frames which are going to be displayed from the stream (because some frames in the stream can be "hidden" by edit lists, and that there can be frames in a track past the end of the duration of a track) and duration_ts is the actual duration that the non-"hidden" frames will be played for - avg_frame_rate can be nonsense for some files.


Add build files for ARM

This PR adds Dockerfiles and Github workflows to automatically build containers for the ARM architecture upon new releases (see #11).
A few notes:

All changes are adjacent to the existing workflows, to prevent any issues or complications with the mainline builds
The container images are tagged with a suffix -arm, for example latest-arm or 0.2.0-arm. While different architecture can coexist under a single tag, it's only possible if all are built under a single workflow run (avoided to preserve the point above)
Since this and the other workflows needed to support the full farmerbot deployment only trigger when a new tag/release is issued, I've waited to include the new docker-compose.yaml file until all are ready. For now, that file is available on my fork and points to the containers built on the set of forks I used for testing
Any suggestions regarding how to organize the new files, in terms of directory structure or naming conventions, are welcome

Alright thanks for the changes. I guess we can merge?


vim airline change it's repository

Change vim-airline repository
Added new vim-airline themes repository

thanks @cassiobotaro :+1:


c8y-remote-access-plugin does not resolved .local addresses

Describe the bug

The c8y.proxy does not seem to support the resolution of domain names with the .local suffix, though other components such as (ping, curl, wget) do support the resolution of .local host names.
Given the main device, rpi5-d83addab8e9f, the c8y-remote-access-plugin is used to try to access a child device rpizero2-d83add42f121.local.
# Fails
$ c8y-remote-access-plugin 530,rpi5-d83addab8e9f,rpizero2-d83add42f121.local,22,dd4afed9-37cc-4d23-a923-34612bf628e4
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:   × Failed to connect to TCP socket
  ╰─▶ failed to lookup address information: Name does not resolve
', crates/core/tedge/src/main.rs:50:58
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

However other linux tools on the same device (such as ping, curl, wget) do support the resolution of the .local names:
$ ping rpizero2-d83add42f121.local
PING rpizero2-d83add42f121.local (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from rpizero2-d83add42f121 (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=11.9 ms
64 bytes from rpizero2-d83add42f121 (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=18.3 ms

To Reproduce

This behaviour can be easily reproduced by calling the c8y-remote-access-plugin command. The command is not expected to successfully connect, however it should show that the name resolution does not work.
Given a main device with thin-edge.io installed on it,

Try to start the c8y remote access plugin from the command line.
sudo c8y-remote-access-plugin "530,rpi5-d83addab8e9f,<child_device>.local,22,dd4afed9-37cc-4d23-a923-34612bf628e4"

Expected behavior

If a device supports name resolution of .local domains, then thin-edge.io should also support it.
Screenshots

Environment (please complete the following information):

Property
Value

OS [incl. version]
Debian GNU/Linux 12 (bookworm)

Hardware [incl. revision]
Raspberry Pi 5 Model B Rev 1.0

System-Architecture
Linux rpi5-d83addab8e9f 6.1.0-rpi7-rpi-2712 #1 SMP PREEMPT Debian 1:6.1.63-1+rpt1 (2023-11-24) aarch64 GNU/Linux

thin-edge.io version
tedge 1.0.1

Additional context

This might be a general problem with the default name resolver used by thin-edge.io, so I wouldn't be surprised if other components also have the same problem.

After some investigation it seems that the musl builds don't support the Name Service Switch:
It can be demonstrated easily using the tedge mqtt sub cli command.
Set the mqtt.client.host to a mdns name which can be resolved in your network:
sudo tedge config set mqtt.client.host rpi5-d83addab8e9f.local

Then using the musl target (e.g. aarch64-unknown-linux-gnu), subscribe to any topic:
# ldd $(which tedge)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
	not a dynamic executable
# tedge mqtt sub 'dummy'
ERROR: I/O: failed to lookup address information: Name does not resolve
ERROR: I/O: failed to lookup address information: Name does not resolve
^C

Then build a libc variant, e.g. aarch64-unknown-linux-gnu, and so the same (this should work as libc uses NSS):
# ldd ./tedge
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
	linux-vdso.so.1 (0x00007fff18cf0000)
	libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x00007fff180d0000)
	libpthread.so.0 => /lib/aarch64-linux-gnu/libpthread.so.0 (0x00007fff180a0000)
	libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x00007fff17ee0000)
	libdl.so.2 => /lib/aarch64-linux-gnu/libdl.so.2 (0x00007fff17eb0000)
	/lib/ld-linux-aarch64.so.1 (0x00007fff18cb8000)
root@rpi5-d83addab8e9f ~ # ./tedge mqtt sub 'dummy'
INFO: Connected

In general the lack of the NSS support is also not just affecting name resolution, but also user/groups. I suspect the usage of a musl build is also the root cause for this ticket as well. https://github.com/thin-edge/thin-edge.io/issues/2042

Using another resolver like (trust-dns/hickory-dns) might also improve the reliability of name resolution in the case of misconfiguration (as seen in this ticket https://github.com/thin-edge/thin-edge.io/issues/2321)

I've got the following working with mDNS:
root@rpi4-d83add9826d7:~/musl-mdns-test# tedge config set mqtt.client.host ubuntu-20.local
root@rpi4-d83add9826d7:~/musl-mdns-test# tedge mqtt sub "#"
INFO: Connected

I found that on my Raspberry Pi 4 with rugpi image, mDNS lookup indeed doesn't work on musl builds of Rust binaries. But mDNS lookup worked on musl builds on my x86 dev machine, even though musl shouldn't support it!
So upon closer inspection, contents of /etc/resolv.conf files were different between the two machines.

on rasberry pi - <IP_ADDRESS>
on my ubuntu dev machine <IP_ADDRESS>

<IP_ADDRESS> is a stub resolver provided by systemd-resolved and is meant to be used by applications that don't use the DBus API for resolving, or don't go through glibc for resolving, but just do a plain DNS lookup.
So systemd-resolved will resolve mDNS hosts, and provide appropriate entries in the stub DNS resolver, which can then be used by musl binaries.
To use systemd-resolved, I had to disable NetworkManager and replace it with systemd-networkd. But apparently systemd-resolved can work with NetworkManager, so I will try it next so we don't have to replace NetworkManager alltogether.

Experienced the same issue when requesting logs, config files.
Hardware: Raspberry pi 3
OS: Debian GNU/Linux 12 (bookworm)
tedge version: tedge 1.1.2~71+g0d49756
C8Y instance: Edge on k8s version 10.18
Temporary solution: edited /etc/hosts
from <IP_ADDRESS>	raspberrypi
to <IP_ADDRESS>	raspberrypi raspberrypi.local

@zhong-ys The recommended way to solve this problem is to use systemd-resolved which can provide the mdns-sd name resolution function.

To show an example of how to install and configure systemd-resolved in a real world scenario, we're extending the rugpi to include a new systemd-resolved recipe which provides a DNS stub which allows other applications (not only thin-edge.io) to resolve hostnames via the .local domain.
The recipe has been added to the upcoming v0.8 image and we'll cut a release once thin-edge.io 1.3.1 is release (due this week).
But since we won't be supporting mdns in the binary itself, I'll consider this ticket closed as "won't do".


Test Go autobuild

We should be testing using autobuild with Go as well as a manual build command, just in case.
Merge / deployment checklist

[x] Confirm this change is backwards compatible with existing workflows.
[x] Confirm the readme has been updated if necessary.

I wanted to make sure the Go tracing was working if you used the autobuild action and thought we may as well add an integration test for it. Turns out it does work.


ros1_bridge: 0.9.5-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository ros1_bridge to 0.9.5-1:

upstream repository: https://github.com/ros2/ros1_bridge.git
release repository: https://github.com/ros2-gbp/ros1_bridge-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.0
previous version for package: 0.9.4-2

ros1_bridge
* Update to use rosidl_parser and .idl files rather than rosidl_adapter and .msg files (#296 <https://github.com/ros2/ros1_bridge/issues/296>)
* Update maintainers (#286 <https://github.com/ros2/ros1_bridge/issues/286>)
* Contributors: Jacob Perron, William Woodall

Closing in favor of #27709


idk how to fork

chadcat i apologize for the disturbance if i accidentally proposed changes dont mind it plas

ok


KAFKA-2604; Remove completeAll and improve timeout passed to Selector.poll from NetworkClient.poll

Tests passed locally.

LGTM. Nice to get rid of those completeAll methods -- I hadn't realized we had removed all uses of them!

Agreed. :)

LGTM

LGTM, thanks!


swupdate: disable systemd service

swupdate is currently configured to use one of the local development
workstation as a server which is not always available.
Moreover, we do not want swupdate to check for any updates on start, as
it is more of a proof of concept than a production ready solution, so
disable the corresponding systemd service by default.
It was once disabled in @73c3163ef5, but was later reenabled in
@6f7e4f29e6.
Signed-off-by: Oleksandr Kravchuk<EMAIL_ADDRESS>

It was once disabled in @73c3163ef5, but was later reenabled in @6f7e4f29e6.

Just an FYI: If you do not add the @ commit hashes will be turned into clickable links on github. (gitk makes the hashes clickable regardless, but nice to be able to click links directly in the browser as well.)


Faster msgpack

Using test echo command {arg: {a: new Array(100000).fill({m: new Map([[1,2]])}), m: new Map()}}
Packing:
Time:
Master: 124ms => PR: 30.6
GCs:
Master: 18 Minor, 2 Major, 23.1ms => PR 12 Minor, 3.1ms
Unpacking:
Time:
Master: 78 ms => PR: 42.3
GCs:
Master: 4 Minor, 13.5ms => PR: 7 Minor, 8.4ms
Pulls in https://github.com/keybase/node-framed-msgpack-rpc/pull/10

[ ] mobile


What could be the problem RPI3+ / [ERROR] Please set machine for armv7l

I get this:
# curl -sL https://raw.githubusercontent.com/home-assistant/hassio-installer/master/hassio_install.sh | bash -s
[ERROR] Please set machine for armv7l

i have raspbian with latest kernel and running docker
Docker version 18.09.0, build 4d60db4
Linux raspberrypi 4.19.57-v7+ #1244 SMP Thu Jul 4 18:45:25 BST 2019 armv7l GNU/Linux

$ cat /etc/debian_version
10.0

Looks like i'm not the only one trying this :-)
Same error on my part

Well, i have just fount out that there is
-m \| --machine |   | On a special platform they need set a machine type use

That helped some install, however, i have some network problems with it now. but the container looks to be running

@nardev
Thanks Man, worked like a charme..

For everyone looking to get it to work.
This worked
curl -sL https://raw.githubusercontent.com/home-assistant/hassio-installer/master/hassio_install.sh | bash -s -- -m raspberrypi3

Glad you guys got it resolved. Closing issue.


Weighted pMDS - Feature/exe-1782

Description
Adds additional arguments to layout_pmds to use edge weights and noise.
The new option use_weights accepts a numpy array with any non-negative edge weights with one element per edge. Alternatively, one can set it to 'prob_dist' which activates the use of edge weights computed from transition probabilities. The default is None, in which case no edge weights are used.
Brief explanation of edge weights
Weights are calculated for edges in the graph from the bidirectional transition probability of a random walker. For an undirected edge $e_{i,j}$, we define the bidirectional transition probability $P(e_{u,v})$ as the probability of transitioning from $u$ to $v$ and back to $u$ in $k$ steps. Note that it doesn't matter what node the random walker starts from since it has to go in both directions. In this computation, we also allow self-loops in the graph to slow the transition of the random walker.
Then, we assume that there is a relationship between the bidirectional transition probability and an exponential function which decays with distance:
$P(e_{u,v}) \propto e^{-d(u, v)}$
If the relationship holds, we can solve for $d(u, v)$ to estimate weights that should be proportional to distance:
$w_{u,v} = -\log(P(e_{u,v}))$
Examples demonstrating this weighting scheme is available in layout_with_weighted_pmds in pixelatorR-internal. The strategy is entirely based on empirical observations but does seem to improve the variance explained when computing pMDS layouts substantially.
Noise
By setting add_noise=True, additional noise is added to the layout coordinates. After the initial layout has been computed, we calculate the layout distances for each edge (distance between end nodes). From these distances, we calculate the standard deviation and use this value to sample offsets along all three axes (x, y, z) from a normal distribution. The effect is that we wiggle the node coordinates a little such that the risk of overlap is reduced. This is useful for pMDS where nodes can have identical layout coordinates.
Fixes: exe-1782
Type of change

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce it when relevant.
PR checklist:

[x] This comment contains a description of changes (with reason).
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked my code and documentation and corrected any misspellings
[ ] I have documented any significant changes to the code in CHANGELOG.md

Check tests not passing.

@ambarrio , now I have added wpmds_3d as the default option in pmds_layout and it should be possible to run it with the pre-compute layout cli option.
A few things to think about here:

I have set the default number of pivot points in pMDS to 200 instead of 50. I think 50 might be a bit low for larger graphs.
It is possible that some graphs might have fewer than 200 pivot points and in that case the layout computation will fail. Maybe we should resort to using all available nodes as pivot points if the total number of nodes is lower than 200.

I can review if it is ready to go.
1- good
2- ok, but I think we run layout as part of the nf-core/pixelator and we never come down to 200 nodes in annotated cells. But as a safeguard when it is run under an API call or from CLI in the unannotated PXL file, makes sense.

For point 2, I'm just not sure where that check should be placed.
There are still some tests failing, and I cannot figure out why. There's a mismatch in the generated figures when running the 2d_plot tests. My suspicion is that it's related to the setup_basic_pixel_dataset.

Probably just here: https://github.com/PixelgenTechnologies/pixelator/blob/482a2c7811de8a4ecc21cca521f9ce20dda3fbb0/src/pixelator/graph/backends/implementations/_networkx.py#L768
where we can write: pivots = len(g.nodes)
and then, it they become very few (i.e. <50), they will raise here: https://github.com/PixelgenTechnologies/pixelator/blob/482a2c7811de8a4ecc21cca521f9ce20dda3fbb0/src/pixelator/graph/backends/implementations/_networkx.py#L779

Perhaps we should throw a warning if this happens?

No it doesn't, but it improves computational speed. I need to fix the tests tomorrow.

I approve. Great work!
One question only, when we run this as default option, will we run it with "prob_dist" as default as weighting strategy?

We have a test in place test_generate_precomputed_layouts_for_components_with_all_components to check that the default option is wpmds_3d which runs pmds_layout with weights='prob_dist'. I just quickly checked that the output makes sense with default settings, but I haven't actually tested the pipeline on real data. The default value when setting --layout-algorithm with the cli is wpmds_3d so it should be fine, but again, I haven't tested it on real data.

Great! We will test this now. And it makes sense with all the internal data you have shown. I think you should go ahead and merge.


Fix static site looking for build directory when skipping build

Refactored a bit to remove nesting as well

Fixes #658


Do you want me to host a public bot for this?

I have servers of my own and can host you this bot publicly for free, while contributing too.

If you do that'd save me (and others) some work, so sure :)

Alright, I'll do that, but before that could you create a prefixed command/context menu or something like that so that it doesn't work on on_message and eat up all resources if voice messages are spammed?

Sure, I'll see what I can do

Context menu functionality has been added, and the bot should now no longer transcribe messages automatically by default

Alright, I'm on the way to school now, will start hosting the bot after I
reach home in about 8ish hours
On Sat, 15 Apr 2023, 23:11 RyanC, @.***> wrote:

Context menu functionality has been added, and the bot should now no
longer transcribe messages automatically by default
—
Reply to this email directly, view it on GitHub
https://github.com/RyanCheddar/discord-voice-message-transcriber/issues/3#issuecomment-1509948553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AURUUGQTY6MVIQVOJIY3II3XBL6FVANCNFSM6AAAAAAW7SMNXI
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

Done, it's being hosted
Could you give me your discord id? I'll add you to the config.ini and send you the invite in DMs

sent friend request


Kotlin version

looks like your lib can be build only with Kotlin 1.0.2, but the actual version of Kotlin is 1.0.3

Should be fixed with #44.

Houston we still have a problem here:
testCompile "com.nhaarman:mockito-kotlin:0.5.1"
Error:Conflict with dependency 'org.jetbrains.kotlin:kotlin-stdlib'. Resolved versions for app (1.0.3) and test app (1.0.2-1) differ. See http://g.co/androidstudio/app-test-app-conflict for details.
Error:Conflict with dependency 'org.jetbrains.kotlin:kotlin-runtime'. Resolved versions for app (1.0.3) and test app (1.0.2-1) differ. See http://g.co/androidstudio/app-test-app-conflict for details.

Yes, as long as mockito-kotlin depends on kotlin 1.0.2-1 you get this dependency conflict.
You have three options for now:

Wait until mockito-kotlin updates to 1.0.3
Downgrade your kotlin version to 1.0.2-1
Create your own fork of mockito-kotlin with kotlin 1.0.3


added extension methods for InteractiveComponentResponse

I think we should use this new functionality to write a unit test for the InterActiveComponentBroker

this has already been implemented in another pr