DRILL-7877 - Streaming REST API Fails to Send Multiple Batches

DRILL-7877: Streaming REST API Fails to Send Multiple Batches
Description
DRILL-7733 introduced the streaming reader for the REST API for Drill.  Unfortunately, a minor bug was introduced as well in that if the user executed a query that produced more than one batch, the schema would be passed in the first batch with no rows, then the rows for future batches would be ignored in the results.
This minor fix corrects this situation.
The behavior can be verified by executing the query below in Postman via the Drill REST API.
SELECT position_title, COUNT(*) as pc
FROM cp.`employee.json`
GROUP BY position_title

Documentation
No user facing changes.
Testing
Added an additional unit test and tested manually.

I hope everyone staying safe in COVID storm.
As it happens, cgivre has been commit  this PR when I work on this issues. thanks


Request for Performance Benchmark Comparison with rust_decimal

I am considering using your library for a project that requires precise decimal calculations, and performance is a critical aspect for us. I noticed that rust_decimal is most popular decimal library in the Rust ecosystem used for decimal arithmetic.
Would it be possible to provide a benchmark comparison between your library and rust_decimal?
Thanks!

You can see https://github.com/cod-technologies/decimal-bench.


Improve display of parent and child jobs

Gets rid of the state column in favor of an icon next to the title, as
has been done in many other places already.
Gets rid of the user and submitted columns, since they are too unlikely to
be different from the current job.
Adds a jobtype column, because that is actually interesting information
in that context.

Looks good.


Adding content (Media Production on the website)

Hello @timmwille , Here is content for the tab, Media Production that should replace the media tab now existing on the website, ## ** Tab 8: Media Production

Media Productions
Welcome to the #ASknet network's Media Productions hub. Here, we proudly present a collection of impactful podcasts and media productions created by our member organizations. These productions showcase a diverse range of stories, experiences, and insights, all with the aim of informing, inspiring, and connecting communities.
Explore the captivating narratives, educational content, and thought-provoking discussions brought to you by our dedicated member organizations. Each production reflects their commitment to making a positive change in the world.
Let's dive into the world of storytelling and discovery through the following productions:

Youth Empowerment Foundation
Refugee Youth Podcast

Description: Welcome to the Refugee Youth Podcast, a platform dedicated to sharing the stories and experiences of refugees living in Uganda. This is a Youth Empowerment Podcast, produced and hosted by young refugees in the Pagirinya refugee settlement sharing their experiences and stories with the aim of educating, inform, and evoke positive change.

Link: Listen on SoundCloud

CC4D
E-waste Awareness Video

Description: This video is produced as a result of the E-waste management through training and awareness on repair, reuse, and upcycling projects in collaboration with _r0g agency and funding from BMZ. It is intended to create awareness about the International Repair Day and the value and importance of repair in Refugee.
Link: Watch on YouTube

GoGirls ICT Initiative
Amplified Gender Voices Podcast

Description: The "Amplified Gender Voices Podcast" by GoGirls ICT Initiative. Every woman's story is a powerful force for change. In this podcast, we bring you inspiring stories, thought-provoking interviews, and impactful conversations that shine a light on the remarkable women of South Sudan. At some point in this podcast, you will be informed, inspired, empowered, and moved by the Amplified Gender Voices Podcast.

Link to the Podcast: Listen on SoundCloud

RSS Feed: RSS Feed

Classroom on Phone Series

Description: #ClassroomOnPhone is a pre-recorded learning program where learners are taught science subjects with the aim of enhancing the love and practice of science in primary and secondary school students.
RSS Feed: RSS Feed
SoundCloud: Listen on SoundCloud
Spotify: Listen on Spotify
Feedback on Classroom on Phones series implementation in schools: Watch on YouTube

#ASKnet
ASKPodcast

Description: "ASKPodcast: where technology meets community, and innovation solves problems. Join us as we delve into the world of open technology and explore the impact it has on communities in South Sudan and Uganda. From local organizations to community leaders, and individuals, we bring you the stories of change-makers who are using technology to create a better future for their communities."
Listen on: Jiosaavn
Listen on: Spotify

Stream Video Conversations

Link: Watch on YouTube

Platform Africa
Refutories

Description: "Refutories" is a word that emanates from Refugee stories, telling refugee stories, with interviews of different refugees on their experiences living in the refugee camp, like sex education, cultural aspects, etc. Listen to the different perspectives of the refugees; this is a brainchild of Platform Africa.
Link: Listen on SoundCloud

thank you @romeoplat I will forward to @yara89 and @MartinSchott
Clarification: is there a planned maintenance approach to keep the content up to date? I think this section will have a lot of incoming new sections right? Maybe we structure it in a way so it is listed as modules similar to the "Resources" on a separate page, or similar to the old "Hubs" popup approach? with a simple "add media product" button that points to an issue template form to be submitted?
@MartinSchott if you have a good idea on how to maintain all these website modules efficiently or even reduce complexity (especially Resources will probably be soon a separate page that is linked to, it is hard to maintain and doubles with training.asknet.community modules and resources) please comment! :)


Maintenance spot-checks for fractions string reference change

For https://github.com/phetsims/rosetta/issues/213, it's desired to have the fractions sims switch to use the common string (that's used in master) since rosetta is checking things in master. fraction-matcher and fractions-equality were published recently enough where this change was applied, but the three other sims in the suite needed changes.
I'd like QA to do brief checks to make sure nothing horrible broke (make sure the strings are working, and if translations are in the RC directories to test a few), and @jbphet if you can ensure that these look good using the vegas string.
@ariel-phet, let me know if for some reason I shouldn't production-release this once confirmed (due to increasing the app download)
build-a-fraction 1.0 (https://github.com/phetsims/rosetta/issues/213)

[ ] build-a-fraction 1.0.11-rc.1

fractions-intro 1.0 (https://github.com/phetsims/rosetta/issues/213)

[ ] fractions-intro 1.0.11-rc.1

fractions-mixed-numbers 1.0 (https://github.com/phetsims/rosetta/issues/213)

[ ] fractions-mixed-numbers 1.0.11-rc.1

@jonathanolson that is fine for app download, we are generally OK with small updates with that, just want to be judicious when it comes to releases affecting every sim.

@jbphet if you can ensure that these look good using the vegas string...

I verified this by adding special-case code to Rosetta (running locally on my machine, never committed) that substituted the RC links above for the live sim URLs from which the English string keys are usually extracted.  This worked, i.e. the "Choose your Level!" string was presented on the translation utility interface, here's a screenshot:

I also tested this using the "Test" function, and it looked good too.  Below is a screenshot - note that since I don't speak Persian, I just pasted the string for "credits" into the "chooseYourLevel" string.

So, from the translation perspective, these changes are good to go.

Discussed with JB last week, I believe the testing we've done is sufficient. I'm going to move forward with deployments for these sims.

Completed, closing!


OCPEDGE-1200: feat: allow dynamic add/remove of devices via pvmove

This is a sample implementation of dynamic device selectors via pvmove and vgreduce. Here is an example of a modified LVMCluster:
apiVersion: v1
count: 1
eventTime: null
firstTimestamp: "2024-08-26T15:29:33Z"
involvedObject:
  apiVersion: lvm.topolvm.io/v1alpha1
  kind: LVMCluster
  name: my-lvmcluster
  namespace: openshift-storage
  uid: 0dc5f864-0404-4a44-a0f7-c47e296d1aea
kind: Event
lastTimestamp: "2024-08-26T15:29:33Z"
message: 'update on node openshift-storage/crc in volume group openshift-storage/vg1:
  moving extents from reduction candidates (/dev/vdc) to left pvs (/dev/vdb) to ensure
  consistent data after path removal'
metadata:
  creationTimestamp: "2024-08-26T15:29:33Z"
  name: my-lvmcluster.17ef50efdc764466
  namespace: openshift-storage
  resourceVersion: "819668"
  uid: 05d96f72-8864-46e2-862a-7d6b8f02a062
reason: ExtentMigrationStarted
reportingComponent: vg-manager
reportingInstance: ""
source:
  component: vg-manager
type: Normal

apiVersion: v1
count: 1
eventTime: null
firstTimestamp: "2024-08-26T15:30:03Z"
involvedObject:
  apiVersion: lvm.topolvm.io/v1alpha1
  kind: LVMCluster
  name: my-lvmcluster
  namespace: openshift-storage
  uid: 0dc5f864-0404-4a44-a0f7-c47e296d1aea
kind: Event
lastTimestamp: "2024-08-26T15:30:03Z"
message: 'update on node openshift-storage/crc in volume group openshift-storage/vg1:
  moved extents from reduction candidates (/dev/vdc) to left pvs (/dev/vdb) to ensure
  consistent data after path removal'
metadata:
  creationTimestamp: "2024-08-26T15:30:03Z"
  name: my-lvmcluster.17ef50f6de83df23
  namespace: openshift-storage
  resourceVersion: "819774"
  uid: e999fcac-52d4-42f9-9bc2-66c0815d3b44
reason: ExtentMigrationFinished
reportingComponent: vg-manager
reportingInstance: ""
source:
  component: vg-manager
type: Normal

apiVersion: lvm.topolvm.io/v1alpha1
kind: LVMCluster
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"lvm.topolvm.io/v1alpha1","kind":"LVMCluster","metadata":{"annotations":{},"name":"my-lvmcluster","namespace":"openshift-storage"},"spec":{"storage":{"deviceClasses":[{"default":true,"deviceSelector":{"paths":["/dev/vdb","/dev/vdc"]},"fstype":"ext4","name":"vg1","thinPoolConfig":{"name":"thin-pool-1","overprovisionRatio":10,"sizePercent":40}}]}}}
  creationTimestamp: "2024-08-26T15:29:16Z"
  finalizers:
  - lvmcluster.topolvm.io
  generation: 2
  name: my-lvmcluster
  namespace: openshift-storage
  resourceVersion: "819780"
  uid: 0dc5f864-0404-4a44-a0f7-c47e296d1aea
spec:
  storage:
    deviceClasses:
    - default: true
      deviceSelector:
        paths:
        - /dev/vdb
      fstype: ext4
      name: vg1
      thinPoolConfig:
        chunkSizeCalculationPolicy: Static
        name: thin-pool-1
        overprovisionRatio: 10
        sizePercent: 40
status:
  conditions:
  - lastTransitionTime: "2024-08-26T15:30:03Z"
    message: Reconciliation is complete and all the resources are available
    reason: ResourcesAvailable
    status: "True"
    type: ResourcesAvailable
  - lastTransitionTime: "2024-08-26T15:30:03Z"
    message: All the VGs are ready
    reason: VGsReady
    status: "True"
    type: VolumeGroupsReady
  deviceClassStatuses:
  - name: vg1
    nodeStatus:
    - deviceDiscoveryPolicy: Preconfigured
      devices:
      - /dev/vdb
      excluded:
      - name: /dev/vda
        reasons:
        - /dev/vda has children block devices and could not be considered
        - /dev/vda is not part of the device selector
      - name: /dev/vda1
        reasons:
        - /dev/vda1 has an invalid partition label "BIOS-BOOT"
        - /dev/vda1 is not part of the device selector
      - name: /dev/vda2
        reasons:
        - /dev/vda2 has an invalid filesystem signature (vfat) and cannot be used
        - /dev/vda2 is not part of the device selector
      - name: /dev/vda3
        reasons:
        - /dev/vda3 has an invalid filesystem signature (ext4) and cannot be used
        - /dev/vda3 has an invalid partition label "boot"
        - /dev/vda3 is not part of the device selector
      - name: /dev/vda4
        reasons:
        - /dev/vda4 has an invalid filesystem signature (xfs) and cannot be used
        - /dev/vda4 is not part of the device selector
      - name: /dev/vdc
        reasons:
        - /dev/vdc is not part of the device selector
      name: vg1
      node: crc
      status: Ready
  ready: true
  state: Ready

Possible Gotchas that need to be considered for a merge:

How do we deal with long pvmoves (even empty thin pools can take upwards of 1 minute on a ssd under bad conditions) => Asynchronous? If not, then how do we properly lock the lvmcluster for modification?
How do we deal with crashing nodes during migration? Pickup again with pvmove without args? How do we test that

/test e2e-aws-hypershift

/test e2e-aws-hypershift

/test e2e-aws-hypershift


function service template annotations

I would like to create an http trigger using azure internal load balancers. In order to do this I need to add the following annotation to the function service:
apiVersion: v1
kind: Service
metadata:
  name: todo-app-service
  annotations:
    **service.beta.kubernetes.io/azure-load-balancer-internal: "true"**
spec:
  type: LoadBalancer
  ports:
  - port: 80
  selector:
    app: todo-app

I did try using yaml files to define the function:
apiVersion: kubeless.io/v1beta1
kind: Function
metadata:
  name: api-endpoint
spec:
  deps: "package.json"
  function: "app.js"
  function-content-type: url
  handler: app.app
  runtime: nodejs8
  service:
    metadata:
      annotations:
        service.beta.kubernetes.io/azure-load-balancer-internal: "true"
    ports:
    - name: http-function-port
      port: 80
      protocol: TCP
      targetPort: 80
    selector:
      created-by: kubeless
      function: api-endpoint
    type: LoadBalancer

but the metadata of the service does not appear when I call describe:
Name:                     api-endpoint
Namespace:                kubeless
Labels:                   created-by=kubeless
                          function=api-endpoint
Annotations:
Selector:                 created-by=kubeless,function=api-endpoint
Type:                     LoadBalancer
IP:                       <local ip>
LoadBalancer Ingress:     <public ip>
Port:                     http-function-port  80/TCP
TargetPort:               80/TCP
NodePort:                 http-function-port  31439/TCP
Endpoints:
Session Affinity:         None
External Traffic Policy:  Cluster
Events:
  Type    Reason                Age    From                Message
  ----    ------                ----   ----                -------
  Normal  EnsuringLoadBalancer  3m16s  service-controller  Ensuring load balancer
  Normal  EnsuredLoadBalancer   91s    service-controller  Ensured load balancer

is there any way to force the service to have metadata ?

Unfortunately the function annotations are not forwarded right now to the Service (only the labels are forwarded).
You can either add support for that in the Kubeless controller (as we do for the Deployments) or create an additional service with the annotations that you need.

yes, that's one option. We are doing that for Deployments:
https://github.com/kubeless/kubeless/blob/master/pkg/utils/kubelessutil.go#L590
So we could do something similar for the services.


Remove duplicate commands from docs

aeae983 added the {build,clean,rebuild}-framework-cache commands to the docs. However, {build,clean}-framework-cache were already documented and are now listed twice. This pull request removes the older duplicates.

I would advise to remove the other ones, not these.

Done in 675e56762ab9ed6c534dac02cc845d07f531548d

Thanks for bringing this up. 👍


Help: Is there a way to get cellsize

Hello,
I am new to this package and have been using R before.
In some calculations of grid cells area weighting, I need to extract the grid area. In the previous R package terra (raster) provides cellsize (area) function. Is it possible to have a similar implementation in the rasters package?

Thanks for your answer.
Yes, output units are necessary. In fact, this could be a very useful function. I'm not particularly familiar with the julia language, and I've currently written a very simple version that just uses the sine function of latitude, which may not be accurate or what you want.
After I get familiar with the Julia language, I may try to write this function and PR, but this may take longer.
I really hope that this feature can be added. Thank you very much for your work.

It can totally be aded, but its always a question of available time. I do a PhD full time and work on many other packages.
In open source things move fastest when the person that needs something the most writes the PR!
And you need this the most and actually know what is required, so youre well ahead of me already.

This functionality has been added in #508


not able to post log

I am not able to use good-http.Being new to it I don't know what I am doing wrong.My configuration is.
const options = {
    ops: {
        interval: 30000 // reporting interval (30 seconds)
    },
    reporters: {
        myConsoleReporter: [{
            name: 'Squeeze',
            args: [{ log: 'debug', error: 'error', response: '*', request: '*', ops: '*' }]
        }, {
            module: 'good-console'
        }, 'stdout'],
        myHTTPReporter: [{
            module: 'good-squeeze',
            name: 'Squeeze',
            args: [{ log: 'debug', error: 'error', response: '*', request: '*', ops: '*' }]
        }, {
            module: 'good-http',
            args: ['http://prod.logs:3001', {
                wreck: {
                    headers: { 'x-api-key': 12345 }
                }
            }]
        }]
      }
};

I get the following error in terminal console as
There was a problem (Error: Client request error: getaddrinfo ENOTFOUND prod.logs prod.logs:3001) in myHTTPReporter and it has been destroyed.

This domain name doesn't exist.


Melaina Valentine - Python Koans HW

Comfort: 3.5/5
Completeness: 5/5
Comments: N/A

I didn't mean to generate a pull request. My apologies.


Could not Parse Prime Config Issue

Could not parse prime config SyntaxError: Unexpected token U in JSON at position 251
at JSON.parse ()
at Module.1101 (settings.ts:15)
at f ((index):1)
at Object.532 (Toolbar.module.css:2)
at f ((index):1)
at a ((index):1)
at Array.e [as push] ((index):1)
at main.529cbcdc.chunk.js:1
What could be the reason? How to solve this?

Most likely invalid JSON in your prime config. Extra comma or something?

Most likely invalid JSON in your prime config. Extra comma or something?

Where I could find this config?

If you don't have this file (.primerc)
We may have to figure this out together!
It usually is in the root of a project

If you don't have this file (.primerc)
We may have to figure this out together!
It usually is in the root of a project
I have the following files
http://my.jetscreenshot.com/14061/20190606-jvf8-9kb.jpg

I believe there's code which parses package.json and it could be the same reason. If you run it through an online json validator it'll tell you what's wrong

I believe there's code which parses package.json and it could be the same reason. If you run it through an online json validator it'll tell you what's wrong

I have checked using validator. it's valid. But it contains the following lines only
{   "name": "prime",   "version": "1.0.0",   "description": "",   "main": "index.js",   "scripts": {     "start": "node index.js",     "test": "echo \"Error: no test specified\" && exit 1"   },   "dependencies": {     "@primecms/core": "0.3.2-beta.3",     "@primecms/ui": "0.3.2-beta.3"   } }

Hello,
I'm also getting this issue, however, I seem to have tracked it down to the fact that the uiDir in the config JSON doesn't have escaped backslashes....
However, I haven't dug deep enough into the code to figure out how to fix/change this yet!


VIP alias/dhcp6 fix

Remove the Interface v6 alias during reconfigure by dhcp6c and re-apply once complete. This commit has a further check that the closed commit I previously issued did not. It now also checks that the alias to be removed and re-added is a v6 address, thus removing the possibility that it could remove a v4 alias on the interface. Whilst the dhcp6c v6 address is being added there should not be an alias on that interface anyway so this makes sure. Ref issue #3310

#3310 should sort this now :)


Issue template addition: Are you using Gitea behind CloudFlare?

As title.
Since more often than not CF appears to serve stale cache and cause troubles (such as here - 14089 and initially also here, although we found out about the CF part in our Discord chat), I'd argue it might be helpful to ask about it in this here issue template, hence this PR.

Codecov Report

Merging #14098 (3c7fa72) into master (addd424) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14098   +/-   ##
=======================================
  Coverage   42.34%   42.34%
=======================================
  Files         726      726
  Lines       77741    77741
=======================================
+ Hits        32918    32923    +5
+ Misses      39421    39416    -5
  Partials     5402     5402

Impacted Files
Coverage Δ

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0.00%> (-1.54%)
:arrow_down:

modules/log/event.go
58.96% <0.00%> (-0.95%)
:arrow_down:

services/pull/pull.go
42.35% <0.00%> (-0.51%)
:arrow_down:

models/error.go
39.47% <0.00%> (+0.48%)
:arrow_up:

modules/git/repo_commit_nogogit.go
65.00% <0.00%> (+1.66%)
:arrow_up:

services/pull/check.go
51.09% <0.00%> (+2.18%)
:arrow_up:

modules/charset/charset.go
73.03% <0.00%> (+4.49%)
:arrow_up:

modules/indexer/stats/db.go
60.00% <0.00%> (+12.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update addd424...3c7fa72. Read the comment docs.

The issues is putting anything in front of Gitea because now there is another layer involved which can modify content generated by Gitea. This is less often related to using a CDN and is an issue with using a proxy in general. Many of the issues (and problems in discord) are because of a nginx/apache/etc.. Misconfiguration and things like that (CloudFlare proxy settings too).
The linked example isn't related to a stale cache or the CDN feature of CloudFlare but rather something that modifies the content Gitea sends before it reaches a  browser. I think a maybe more general <!-- If using a proxy or CDN in front of Gitea, please connect to Gitea directly and confirm the issue still happens without those services -->

The issues is putting anything in front of Gitea because now there is another layer involved which can modify content generated by Gitea. This is less often related to using a CDN and is an issue with using a proxy in general. Many of the issues (and problems in discord) are because of a nginx/apache/etc.. Misconfiguration and things like that (CloudFlare proxy settings too).
The linked example isn't related to a stale cache or the CDN feature of CloudFlare but rather something that modifies the content Gitea sends before it reaches a browser. I think a maybe more general <!-- If using a proxy or CDN in front of Gitea, please connect to Gitea directly and confirm the issue still happens without those services -->

the stale cache part doesn't apply here, you're right.
the first example constitutes the causes troubles part and while you're right the problem is more of a general reverse proxy problem, IMO quite often the issue is directly tied specifically to CF, as it's what many people use apparently, or maybe I just see a CF issue and go kaboom :D.
It's better, to use broader terms in this case, though, I'll update the comment.

I think it might be helpful to add something to the FAQ here.
The referenced issue was specifically due to the AutoMinify option on Cloudfare causing whitespace changes.
This option needs some way to say to say in that in this element whitespace actually matters and although any such marker would be non-standard I would argue it would be useful but until they provide that it simply cannot be used on Gitea - (until that is we move to an AJAX based diff scheme which would nicely resolve this)
I'm not certain if there's any way other way we could mitigate.

I think it might be helpful to add something to the FAQ here.
The referenced issue was specifically due to the AutoMinify option on Cloudfare causing whitespace changes.
This option needs some way to say to say in that in this element whitespace actually matters and although any such marker would be non-standard I would argue it would be useful but until they provide that it simply cannot be used on Gitea - (until that is we move to an AJAX based diff scheme which would nicely resolve this)
I'm not certain if there's any way other way we could mitigate.

What exactly should be added to the FAQ?
Something like this?

Q: I want to use CF, is it ok?
A: Yes - but - make sure AutoMinify (or similar option with other providers) is turned off since it causes trouble.

This option needs some way to say to say in that in this element whitespace actually matters and although any such marker would be non-standard I would argue it would be useful but until they provide that it simply cannot be used on Gitea - (until that is we move to an AJAX based diff scheme which would nicely resolve this)

Nothing special about CF's minifier, it's us that are breaking norms by not putting code in <pre> or <code> (technically we are using <code> block but actual content is then wrapped in <span> elements). This will trip up pretty much any HTML minifier.

Something like this?

Q: I want to use CF, is it ok?
A: Yes - but - make sure AutoMinify (or similar option with other providers) is turned off since it causes trouble.

Please attach FAQ link on how to disable it on CF and specifically mention it's for HTML only, the options for JS and CSS are separate.

Nothing special about CF's minifier, it's us that are breaking norms by not putting code in <pre> or <code> (technically we are using <code> block but actual content is then wrapped in <span> elements). This will trip up pretty much any HTML minifier.

Would sticking the spaces in a <![CDATA[  ]]> help do you think.

I'd say we just replace one of the parent <div> in the code view with <pre> and that should be it to no longer confuse such broken minifiers.
BTW, GitHub would be broken too behind Cloudflare, they also have no <pre> or <code> in the ancestors.

If nobody against, I think this could be merged.

ping


Support nested putCloseable invocations (issues/404)

Hi folks,
This PR fixes #404 by preventing putCloseable from clobbering a key that was present in the MDC before the putCloseable was created. It thereby allows nested putCloseables. The existing behavior surprised us when we were writing some recursive code. Let me know what you think, and thanks for making SLF4j!

Hi @mdpearson!
Is this PR still valid? I see that is no conflicts and this PR could be merged easily.


Automatically trigger build in tracked branch if there is free agent resource

This will help to identify changes failed run-all without investigation.

Already done with Apache contribution


feat: render image and markdown in post stream

Post card now supports content-type image and markdown.
Minore refactoring to PostCard component to use render-props pattern when dealing
with different contents.

Related user stories:

#33
#39


add menu group component

contributes to #124

Pull Request Test Coverage Report for Build ec3d36b75519de2e11c4f0d3f57e7aa44cbb8b42

0 of 4 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.882%

Totals

Change from base Build 24e37ff89e719e8e51a4e451ea7ca51fb64e59ec:
0.0%

Covered Lines:
849

Relevant Lines:
850

💛  - Coveralls


rclone: Cookbook title should capitalize rclone properly as Rclone.

http://rclone.org/ - check the official usage on the website.

This can be closed via https://github.com/minio/cookbook/commit/16d2c44fd6ef103ff586e8b76a4dd4bd15d53e3b


Fix link to Advanced Concepts

Then link to the Advanced Concepts topic is wrong within the Information Extraction docs.

thank you!


Evolvin Problem

Expected Behavior
I'm using default config.json.optimizer.example config file without any change. Now my pokemon bag reached to 245 and started to exchange and evolve.

Pidgeotto shouldn't be evolve, there is pidgey only 12 candies.
In my bag there is 18 Pidgeys and 113 pidgey candies. It should first try to evolve pokemons then exchange.

Actual Behavior

Pidgeotto evolved and used 50 pidgey candies.
Exchanged 17 pidgey and evolved only 1 pidgey, but I have 113 pidgey candies.

"first_evolve_by": ??
"evolve_above_cp": ??

copy paste your config and the release log as well.

Just a comment though since I can see a scenario that would lead to that result:

I see you are not on the very last version so I assume the optimizer might still be trying to evolve Pokemon you have in fort. Do you have Pokemon in fort ? If yes, it might explain the 19 evolution  instead of 20.
Then about the pidgeotto, that is more simple. He is simply the best you have according to one of your criteria (might be ncp). So he is evolved.

The default optimizer config let the best IV and best NCP Pokemons evolved, so at least 2 Pokemons of each family are evolved (when it's possible). The rest of the candies will be used for evolving "crap" Pokemons if evolve_for_xp is set to true (which is also the default too).


How to delate, edit and save an objekt?

Hi !
First of all thank you for this great product! I am using 3DcityDB and still learning a lot!
I wonder how to delete, edit or uppdate an objekt. The Impoter/exporter does´nt show this possibilities..
Is there a tool for editing objects on the fly ? Im am using CityEditor and is great, but still you have to export from 3DcityDB--- import in SketchUp-- edit-export and finally import to the 3DcityDB and then this does´n replace the existing object..
Regards
Abel

Hi Abel,
during my time at virtualcitySYSTEMS I've created plugins for the Importer/Exporter to satisfy these tasks - integrating objects back into the database (e.g. coming from a sketch-up process) and delete objects based on some filter criteria. These are commercial extensions. If you are interested, talk to my former collegues.
Live editing of 3DCityDB features would require a GIS with 3D capabilities and probably additional views on the data. As far as I know Bentley has a solution for this. Not sure about Oracle.
Cheers,
Felix

Closed. Feel free to reopen if you still have any issues.

Reopened for future consideration.


DO NOT MERGE! Fast Forward stable to 96f48a22e872b9d0161e6e3bf24ba3fe39c2919a.

This PR will be merged automatically once checks are successful.

Jenkins job manager/postsubmit passed


Better anti piracy

(Enhancement) My apps are being pirated and I can't even do anything about it. There must be a way to solve this problem.

Dexguard will help you to obfuscate some part of your code hardly http://www.saikoa.com/dexguard

@AlienCreature7 Although your question does not belong to this board or this type

@KaustubhPatange The dashboard already use proguard, dexguard is paid so it's a different story.
@AlienCreature7 Just stop complaining. People who always buy will always buy.

@danimahardhika yeah I know people who buy will buy but still

@danimahardhika yeah I know people who buy will buy but still


Bug: [BwB] Source doesn't appear in Instruments

Describe the bug
Because of relative paths the source doesn't appear in instruments. We need to adjust dSYMs with path remappings or something.

@CognitiveDisson is working on this in https://github.com/buildbuddy-io/rules_xcodeproj/pull/1626.

When this is fixed, we should check to see if https://github.com/buildbuddy-io/rules_xcodeproj/issues/1284 is fixed as well. Not sure if it sees the dSYMs. But if it does, we might have to adjust the dSYM copy script to run on the Launch action as well as the Profile one.


Is BKKCrypt resistant against side-channel attacks?

Good day, folks.
We are now planning to adopt the TypeScript implementation of BKKCrypt into our account subscription system to offer the utmost best of user-credential protection. See, this is a sensitive sub-system, and we need to ensure BKKCrypt does not compromise confidental data through, or as a result of timing attacks, cache attacks etc.
From https://github.com/moszinet/BKKCrypt/blob/master/TypeScript/BkkCrypt.ts#L6
const BkkCrypt = (input: string) => input;

It seems like this huge algorithm accumulates into a O(n) efficiency total, although we are unsure if this could be used as a side-channel attack vector. Could someone shed a little light on this one? Thanks for your time.
Footnote: we couldn't find this documented in this repository, nor any tests and results excerpts, hence why we are asking now.

Hi John,
I understand your concern. This is a new algorithm and not much information exists on the internet so far to support is viability.
What we can say is, that we have a team working on this - who (obviously) have the technical knowledge of the implementation internals - and together with a couple of statisticians they are working on coming up with a successful attack. We know this is going to be the leading question in the upcoming months and the community is going to invest heavily in proving this algorithm worthwhile.
We are really confident in this algorithm. So far our answer is that this algorithm is not susceptible to side-channel attacks. [Until it is proven otherwise :)]

We've done some in-depth research and found that reverse engineering is not possible, when reading the  memory address of the original string, we found the data already encrypted. Safe to use.


[WIP] Optionally use RTC

Now working on https://github.com/Shaunwei/RealChar/pull/294, this PR is closed.


NREL NMC Lifetime Model Validation

Update SAM implementation of the NREL NMC Battery Life Model and perform validation based on V5_GrNMC_Kokam_75Ah model implementation for Kokam 75Ah Gr/NMC cell performance in K. Smith, et al, Life Prediction Model for Grid-Connected Li-ion Battery Energy Storage System, 2017
Changes:

Update cycle counter to track the most recent cycle's range and max DOD
Track the range and max DOD of all the cycles that occur in each day
Update predictive life model results and tests

Interpolate Uneg and Voc from table
If no cycles have yet elapsed, predict range of cycles that will occur and predict average SOC of cycles that will occur in that day; otherwise use DOD range and SOC average of cycles from current day

EstimateCycleDamage using cumulative loss and total number of cycles for average
Rename some cycle and NMC variables for clarity
BatteryStateful INOUT variables

Validation:

TestAgainstKokamData in lib_battery_lifetime_nmc_test tests against reference data and model

Pretty good agreement to original model, differences due primarily to how SAM handles time and SOC profiles
The difference for cell 6 & 7 grows after Qneg overtakes QLi and is primarily due to completed/integer cycles per day  underestimating vs using incomplete/floating pt cycle counting. For instance, a sequence of number of cycles per day of (8, 9, 8, 9, ...) vs (8.5, 8.5, 8.5, 8.5, ...). The difference would probably be less with less aggressive cycling

FYI @nmerket @rchintala13, the TLDR here is this update results in better agreement with original model and data

Wow. This looks like a significant improvement. We will be definitely interested incorporating it in EnergyPlus once it is part of a release.


Adding the new createShader example #6134

for issue #6134
Changes:
Added the new createshader/Julia set example to the EN, ES, zh-Hans folders

hi and ko will both need a copy of the example as well (they are not documented in the contributor docs as that is a bit outdated).

Thanks @thantr for working on it. We'd like to follow up on this PR. Please let us know if you need any support responding to @davepagurek's comments. Thank you.


Why does the number of followed lists displayed at once noticeably decrease in value despite the limit being 20?

For example, I'm testing an output of 160 total followed blogs at 20 shown per request. The offset parameter works at increment of 21 untl i reach 63 and then only 15 blogs are displayed and I'm accessing out of range indexes.
The largest value that's allowed to print 20 blogs is offset 57 and it decreases to 19, 19 18, 17, 16 , 15 (63), etc. How can I workaround this if I just want to be able to just output the total number urls? I haven't seen any reference to this. After just eight easy iterations, this should be over with but I can't even finish 3... Could anyone provide some insight to this? I thought my code was the problem but the API Console displays the same thing. Haven't found any documentation on this so far.

Who would I need to contact about the API now that the google group is closed down?


Disable port security for all Liberty releases

In OpenStack-Ansible, a bug was discovered that prevented networks created prior to the portsecurity extension being enabled from functioning. Neutron currently has no (released) way of cleanly handling networks that were created while the extension wasn't enabled, though a patch merged into master to fix that behavior.
An Openstack-Ansible patch was merged to disable the portsecurity extension in Kilo to Liberty upgrades, since it was made the default. Upgrading from Kilo to Liberty made VMs connected to networks created pre-Liberty break; they would not boot, simply entering an ERROR state.
This behavior from OSA means that greenfield installs would have port security enabled, while upgrades from Kilo would not. Such a split becomes a maintenance and support burden, and thus RPC would like to keep behavior the same regardless of how the environment came to Liberty.

[ ] Master
[ ] liberty-12.0

@BjoernT I will work on a patch for this today.

If the intension is to enable it from Liberty onwards, I would recommend a release note to ensure that it's explicitly clear that this is happening. Some deployments may unwittingly be relying on the lack of port security as a 'feature' and that's only likely to become known after an upgrade is complete and people start yelling.
While I'm not entirely certain of the use-cases which would use it as a 'feature', I suspect that deployments that implement virtual IP's (Microsoft Cluster Services, haproxy implementations with keepalived, etc) are likely to be those that are at the highest risk of not working afterwards.

@claco If this is going to affect QE's testing of r12.0, let's a summary over to them.
cc: @tbyrom138

@odyssey4me The intention is to keep it off in order to keep RPC installs more or less the same; not doing so would mean environments initially installed with a 12.x release would have port security enabled, while environments upgraded to a 12.x release wouldn't have it. To my knowledge the concern wasn't about port security itself breaking anything, but rather the disparity in between installs based on how they got to the 12.x/Liberty series. The upgrade case happens to be the most restrictive and lowest common denominator.
I don't know if the change to Neutron allowing for graceful handling of this will be backported, but I think it's probably better to move to the functionality when it can be safely turned on without breaking existing environments.

I don't believe this will impact QE testing beyond ensuring that the extension is indeed disabled. I included the impacts-qe tag as a way to notify them that it's included, though.

cc @jpmontez @jacobwagner @weezer for awareness

The more I think about this and after having conversations with some security minded folks I think it is a very bad idea to do this for greenfields.  We are sacrificing security for some perceived convenience of not having disparate environments.  I think efforts should be focused on getting our upgraded customers to a state where we can enable the extension and handle the ones that absolutely cannot on a case by case basis.  I've still plus 1'd the PR and won't block it from going in but I think those arguing for disabling the extension should seriously look at the reasoning for doing so.

I definitely understand the value in keeping port security disabled for upgrades. After speaking to @prometheanfire about some of the shenanigans about ports not being populated with port security in the database, that stance is certainly understandable.
However, disabling port security by default on greenfield deployments is a concern. Even on trusted networks, port security provides real benefits for deployers and users.

I am all for dropping this PR. I think there needs to be a conversation with support about it though. @BjoernT @JCallicoat what are your thoughts about Dave and Major's comments?

:-1: I agree that it seems odd to reduce security of greenfield deploys to solve an upgrade bug.

still an issue and what we are trying to avoid, patch hasn't backported to mitaka or liberty

Got it. So in that case, I'm in favor of enabling the port security extension for greenfield environments (kilo or liberty) and not enabling the extension on upgrades until the patch is backported. Worse case, this means that existing deployments that go through an upgrade keep existing functionality. New environments can utilize the port security extension as intended.
Thoughts? Not sure how easy this is to implement. Or, you can simply not enable the port security extension in either case until the patch is backported. No harm, no foul.

So my stand on this was we should either enable/disable for a release no matter if the release has been upgraded or fresh installed. Also not enabling it does not make openstack more unsecure, because the anti spoofing is still there for as long as not doing --port-security-enabled=False per port. I would enable this feature with a 12.x release so we can do installs and upgrades with the same features and then add it once the patch merges as RPC feature

The core of the issue from an OSA/rpc-openstack POV is that neutron doesn't handle turning the extension on post-openstack install gracefully. For example, we were to install a Liberty cluster without it enabled, then try to turn it on, as things stand now the networks/ports created prior would no longer function. The same would apply if this was done in Kilo - install the stack, create networks, enable the plugin, networks break.
I will note, however, that the bug got backport patches all the way to Kilo today, so hopefully they will actually get merged.

Not sure how easy this is to implement.

@busterswt Your recommendation is essentially what existing code (minus PR #933) does. PR #933 disables the plugin regardless of how the install got to Liberty, via greenfield or upgrade.

@tbreeds Would you mind having a look at https://review.openstack.org/#/c/299212/ and https://review.openstack.org/#/c/299204/ for Neutron's stable/liberty branch? These patches will help us move customers from Kilo to Liberty.
https://review.openstack.org/#/c/299218/ and https://review.openstack.org/#/c/299217/ are the backports to Kilo, but I'm not sure they're as important to RPC customers at this point, as all of those customers will keep the port security extension disabled.

I've had a look at those reviews and they're not straightforward (in terms of stable policy)  Ihar is a stable-maint-core so I suspect he's considered the corner cases but right now I'm not in a position to +2 them.
I'll take another run at them when I have cycles

anti spoofing is still there for as long as not doing --port-security-enabled=False per port

@BjoernT as a point of clarification, the crux of the issue is that with port security enabled right now, --port-security-enabled=False is not respected in the current Neutron code. This means that in an upgrade situation where the port security extension was not enabled in Kilo (but it is enabled after the upgrade), all networks which have port security disabled end up being blocked.
Another point of clarification is that there is no ARP spoofing protection by default in Kilo or Liberty. We did try to enable it by default in Liberty initially, but was disabled soon afterwards we we found it caused gate failures a lot of the time.
In Mitaka we now have it enabled as the issues we found have been resolved in upstream code. As I recall the issues had something to do with l2pop, so it's plausible that it might work to enable ARP spoofing protection again in Liberty but I've opted to block that as it's a major change which has far reaching effects and I'd rather not see that done as a default and rather leave it up to the deployer.
Effectively this means that the port security extension is the only form of spoofing protection enabled by default in Liberty.

@tbreeds Thanks for checking in with that, I appreciate it!

Support had a small meeting and prefers that this extension is disabled for all releases until we can make sure that a) Users can upgrade and b) Greenfields work ok

Will we ever be able to ensure a?  customers may be using networking in any number of ways that this security improvement would catch.

So the port security extensions give you only the benefit of disabling the MAC/anti spoofing feature in neutron per network/port bases. The use case was pretty much limited for NFV where you can't have APR spoofing protection enabled, something which we do not care yet. Hence disabling it not more unsecure, the neutron ports are as secure as we used to expect

@palendae can you please comment here? Is the work all done?

I'm not aware of any open issues here

I'm closing this as all of the work seems to be done, re-open if needed.


[Do not merge] test: added db connectivity test

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

@Soaib024 Could you walk through the latest updates to the rest of the team in the next deep dive call please?

This pull request was created for testing purposes only. Here is the link to the actual pull request.


How to get the detection_results.bin?

Hi~Thanks for your great job
And I wondering how to get the waymo detection_results.bin?

We recommand you to use CenterPoint(two-frame model for tracking) detection results for reproducing our results. Please follow https://github.com/tianweiy/CenterPoint or email its author for CenterPoint detection results.

This is the instruction of the official ImmortalTracker repo. I do not have the CenterPoint detection results. I could provide you the result files of the FSD series detectors if you need.

I‘ll appreciate it if you can send me the FSD series detectors results, my email is<EMAIL_ADDRESS>Thanks again~

OK, but I am currently inaccessible to our server, I will send it to you next week.
Feel free to remind me if I forget.
@xiaocongcsu


ListView loadMoreItems event is called continuously

When ListView size is smaller than screen size, it fires loadMoreItems event continuously.
I have this template:
<grid-layout rows="*">
    <ListView [items]="tasks" (loadMoreItems)="loadMore()" class="bordered" row="0">
			<!-- Template is here -->
    </ListView>
    <FAB row="0 icon="res://ic_add_white_24dp" rippleColor="#c0d0e0" class="fab-button"></FAB>
</grid-layout>

When listview content is longer than screen size, there is no problem.
If I scroll to the bottom and there is new content, it is loaded and there is no problem.
If I scroll to the bottom and there is no new content, listview stays scrolled to the bottom and always fires loadMoreItems event.
If listview content is shorter than screen size, loadMoreItems event is always fired.
Right now, I will try to fix this by adding a flag to my code but it would be nice if this is fixed in the repository.

Hi @erkanarslan,
Thank you for reporting this issue.
I tested this case on my side and was able to recreate some odd behavior with not properly firing loadMoreItems event in none angular project, while there are just a few items.
I will log this as a bug and in the meantime, you could review load on demand  functionality provided by RadListView component and to verify if using this component is applicable to your case.
Archive.zip

This issue was moved to NativeScript/NativeScript#5155

@tsonevn RadListView removes the ripple effect from list items. Because of that I don't use it if I don't have to. Now I fixed it like that: I set a flag to true if there is no new content and don't request more content if that flag is set.


Support PaaS Cassandra - TLS with known CAs

Requirement - what kind of business use case are you trying to solve?
Connect to a cloud-provider managed Cassandra to reduce the operational overhead on the databases. SSL has to be provided for the connections. Quite often, the certs used are issued by known CAs such as LetsEncrypt or digicerts.
Additional context is available here #2467
Problem - what in Jaeger blocks you from solving the requirement?

TLS certs need to be provided via files.
The TLS certificates are not mounted to the create schema container image.

Proposal - what do you suggest to solve the problem or improve the existing situation?
For K8s based deployments its not very convenient to create a config map and mount it  to the pod. Therefore, I'd like to discuss whether we should introduce a config flag that would use well-known CAs to be added automatically on demand.
Its a similar situation that RedHat for instances using for Quarkus by running a ca-certificates installation: https://github.com/quarkusio/quarkus-quickstarts/blob/master/security-jwt-quickstart/src/main/docker/Dockerfile.jvm#L26
This would allow an easier installation and operations on K8s.
Any open questions to address
Maybe we can start to discuss the approach.

As far as I can see the base for the Jaeger docker images is Alpine Linux. The Alpine Linux image seems to have a root-ca-bundle at /etc/ssl/certs/ca-certificates.crt

I believe we already have support to provide custom CA.


generate sha256 from .crt

how to generate 2 sha256 pin certificate from file .crt we get from server?
try to run
java -jar generatePins.jar filename.crt sha-256
ang getting error
The generated pinset are base-64 encoded hashes (default SHA-1, but supports SHA-256). Note: only run this on a trusted network.
Usage: "java -jar generatePins.jar [:port] hashAlgorthm" i.e scottyab.com:443 sha-256
Whoops something went wrong: filename.crt
java.net.UnknownHostException: filename.crt
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:589)
at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:666)
at sun.security.ssl.SSLSocketImpl.(SSLSocketImpl.java:426)
at sun.security.ssl.SSLSocketFactoryImpl.createSocket(SSLSocketFactoryImpl.java:88)
at com.scottyab.ssl.util.SSLPinGenerator.fetchAndPrintPinHashs(SSLPinGenerator.java:113)
at com.scottyab.ssl.util.SSLPinGenerator.main(SSLPinGenerator.java:84)
the expected
Generating SSL pins for: scottyab.com
sha256/29pz6zLLFb2xdHtgFZQC8cRNrpLKxxxxxxxxxxxx
sha256/jQJTbIh0grw0/1TkHSumWb+Fs0Gxxxxxxxxxxxxx

Hi, thanks for the question. ssl-pin-generator was built to accept url. it make HTTPS request and generates the SSL pins from the certs it downloads as part of the requst. If you have the .crt file you'll need to use openssl tool to extract the keys. See this SO answer it should help.
openssl x509 -in cert.crt -pubkey -noout | openssl pkey -pubin -outform der | openssl dgst -sha256 -binary | openssl enc -base64 (from the linked SO answer)


Tooltips on settings

Clear and concise description of the problem
Some settings functions aren't clear, eg auto-cleanup - what does this do?
Suggested solution
A small description on hover with more infformation
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Good idea. I'll do that once the new ui is out.

Until then autocleanup means that older episodes than x days are deleted from the filesystem. This prevents the disk being full after some time and potentially crashing the system.

OK, so if I want to use PodFetch as an archiving tool, to keep all my podcasts, I'll need to disable that. Good to know. :)


Document spatial file type conversion tools

Fixes #7933.
Summary of changes:

Add 'Migrate to *' pages for each of:

Shapefile (.shp)

GeoJSON (.json)

OpenStreetmap (.pbf)

GeoPackage (.gpkg)

For each of the above new pages, we document:

How to get the data from original format X to format Y (usually
format Y is something we can slurp in with IMPORT PGDUMP)

Which tool(s) are used for the process

Finally, we try to link everything amongst each other and the various
already existing Spatial pages (glossary, etc.), in addition to
whatever work is needed to weave these changes into the larger docs
site in general (links, TOC updates, etc.)

Hey Oliver, requesting you since (AFAICT?) you are the one most knowledgeable about these tools.  Please let me know if I should ask someone else on the team instead.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/3c263f19bbe9418a8ae5b2752381431b6221b7f5/
Edited pages:

v20.2/migrate-from-geojson.md
v20.2/migrate-from-geopackage.md
v20.2/migrate-from-openstreetmap.md
v20.2/migrate-from-shapefiles.md
v20.2/migration-overview.md
v20.2/spatial-data.md
v20.2/spatial-features.md
v20.2/spatial-glossary.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/092ab01f619aa02d4205dafda6446a76af7f7c07/
Edited pages:

v20.2/migrate-from-geojson.md
v20.2/migrate-from-geopackage.md
v20.2/migrate-from-openstreetmap.md
v20.2/migrate-from-shapefiles.md
v20.2/migration-overview.md
v20.2/spatial-data.md
v20.2/spatial-features.md
v20.2/spatial-glossary.md


[RPC] Introduce a rust RPC framework

We need to choose a rust RPC framework and consider the following requirements.

It can run a standalone server.
It can easily be embedded into another system(MoveOS also is a library).
Javascript SDK friendly, REST or JSON-RPC?

Dependency
#11

In rust language, RPC has more star in github are jsonrpc and jsonrpsee, and jsonrpsee is the successor of the former, and they are both produced by ParirtyTech

jsonrpsee is so new, is it stable enough?

jsonrpsee is so new, is it stable enough?

jsonrpsee used in Subsbtrate, Sui.
Or what better options are available

jsonrpsee is so new, is it stable enough?

jsonrpsee used in Subsbtrate, Sui. Or what better options are available

If jsonsee is stable enough, it's offcause a good choice. I 'm not familiar with RPC Frameworks.

Add another option: tarpc, 25k stars in github,  the Distributed tracing feature is useful:
tarpc differentiates itself from other RPC frameworks by defining the schema in code,
rather than in a separate language such as .proto. This means there's no separate compilation
process, and no context switching between different languages.
Some other features of tarpc:

Pluggable transport: any type implementing Stream<Item = Request> + Sink<Response> can be
used as a transport to connect the client and server.
Send + 'static optional: if the transport doesn't require it, neither does tarpc!
Cascading cancellation: dropping a request will send a cancellation message to the server.
The server will cease any unfinished work on the request, subsequently cancelling any of its
own requests, repeating for the entire chain of transitive dependencies.
Configurable deadlines and deadline propagation: request deadlines default to 10s if
unspecified. The server will automatically cease work when the deadline has passed. Any
requests sent by the server that use the request context will propagate the request deadline.
For example, if a server is handling a request with a 10s deadline, does 2s of work, then
sends a request to another server, that server will see an 8s deadline.
Distributed tracing: tarpc is instrumented with
tracing primitives extended with
OpenTelemetry traces. Using a compatible tracing subscriber like
Jaeger,
each RPC can be traced through the client, server, and other dependencies downstream of the
server. Even for applications not connected to a distributed tracing collector, the
instrumentation can also be ingested by regular loggers like
env_logger.
Serde serialization: enabling the serde1 Cargo feature will make service requests and
responses Serialize + Deserialize. It's entirely optional, though: in-memory transports can
be used, as well, so the price of serialization doesn't have to be paid when it's not needed.


socket.http PORT field does nothing

The socket.http PORT field does nothing.
Instead the default is brought in via https://github.com/diegonehab/luasocket/blob/46d7e75f3e71d75bf07ae83d7df4aa276e484473/src/http.lua#L253
e.g. try this:
local http = require "socket.http"
http.PORT = 1234;
print(http.request("http://httpbin.org/get"))

It goes ahead and makes the request to port 80 anyway.
As this hasn't worked for a while, I suggest just removing PORT from the source code + docs.

This is a bug, right? I think it is a bug in adjustrequest().

This is a bug, right? I think it is a bug in adjustrequest().

Well it's a difference between documented behaviour and actual behaviour.
My preference here is to change the docs rather than the code, as it has been broken for a long time, and I doubt anyone is using the feature.

I agree that modifying the field (if it worked) would be tricky. Perhaps it is really best to remove it from the documentation and keep it as a literal local constant in http.lua. And also fix the code that currently overrides it. :)

Fixed with 5b4b9158799293eeaf8439d40a7845b5b0a5e125

also fix the code that currently overrides it.

Do you know of any code that does?

Was this here:
if nreqt.port == "" then nreqt.port = 80 end
socket.try(nreqt.host and nreqt.host ~= "",
    "invalid host '" .. base.tostring(nreqt.host) .. "'")


sh: 1: Syntax error: "(" unexpected when DiscordRPC.discordInitialize is called with applicationID being null

Hello, I am trying to use this library in my application, but upon calling DiscordRPC.discordInitialize() with a null applicationID the library prints this in the error output stream:
sh: 1: Syntax error: "(" unexpected

Maybe a more meaningful error could be printed?

I um. No idea what this error is. I blame discordapp, but I can research it for you.
What OS are you on?

Ubuntu 18.04 LTS.

Give me a moment, allow me to ask around.

You probably expected this, but this library is relying on the original discord-rpc C++ library. We interact with it through the JNA interface. Due to this, exact arguments need to be passed. The library expects a String for the appId, and JNA is redirecting this, but since it's unable to accept null, it takes care of error handling, which leads to JNA freaking out.
So yeah, technically this is on JNA, and I don't see much use of null-checking a value that should be a static String.
Thanks for reporting though.

@DeJayDevelopment Sure, ask what you need. Other things I thought may be important:

IDE: IntelliJ IDEA 2018.3 EAP
Java: OpenJDK 8u181


Make tweaks

Move filesystem into buildir
Fix false rebuilds
Fix parallel builds (-j)

Depends on #198


Component is using styles from page

The LinkPreview component seems to be inheriting global styles. My understanding is that the shadow dom should be scoped and not inherit any styles from the main page.  Need to investigate.

Ok, it looks like what's happening here is since the slotted elements are in  the "light" DOM, they're subject to the styles of the document. Not really any way to get around that, but I'll be more explicit in the template to prevent weird styling situations.


feat(linting): no floating promises

:tada: This PR is included in version 1.45.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


N41: Pirate Annihilation

Part of #1233

@17cupsofcoffee thanks for for the reviews and merges 😄
I updated by branch so you can edit and I just rebased so it's up-to-date with source should be good for you to merge once the workflow passed.

Thanks for the PR!

Thank you!


setting size.y on a ProgressBar node while show_percentage is true is not respected when the height is less than the font_size but show_percentage is set to false afterwards

Godot version
4.1.3
System information
Windows 10
Issue description
The following GDScript to instantiate a ProgressBar, set it's size.y to 5 and show_percentage to false, and add it to the scene does not work as expected.
node = ProgressBar.new()
node.size.y = 4
node.show_percentage = false
self.add_child(node)

This will show the ProgressBar, but the size.y will be 14 because the font_size is 14, even though show_percentage is false.
Switching the order of setting size.y and show_percentage will work as intended.
node = ProgressBar.new()
node.show_percentage = false
node.size.y = 4
self.add_child(node)

Expected Behavior
There should be some kind of warning when setting a property to a value that's below it's min, or the first code block should work as the second one does.
Steps to reproduce

Create a script attached to a Sprite2D node
add this to the _ready function:

node = ProgressBar.new()
node.size.y = 4
node.show_percentage = false
self.add_child(node)

Run the game, the progress bar should have a height of 14
change the code to this:

node = ProgressBar.new()
node.show_percentage = false
node.size.y = 4
self.add_child(node)

Run the game, the progress bar should have a height of 4

Minimal reproduction project
This seems trivial enough to not include a project, but I will upload one if requested.

Hello,
Hope people don't mind that I try to resolve this issue. Currently working on a school project where I need to contribute to an open source project.

Hello,
The size is being reset to the minimum values of y=14 when attempting to set the size to 5 while show_percentage is on, and this is intended behavior. The logic that resets the size back to the minimum values is shared by all control UI nodes, not just the progress bar.
void Control::set_size(const Size2 &p_size, bool p_keep_offsets) {
	ERR_MAIN_THREAD_GUARD;
	ERR_FAIL_COND(!isfinite(p_size.x) || !isfinite(p_size.y));
	Size2 new_size = p_size;
	Size2 min = get_combined_minimum_size();
	bool is_below_minimum_size = false;
	if (new_size.x < min.x) {
		new_size.x = min.x;
	}
	if (new_size.y < min.y) {
		new_size.y = min.y;
	}

	if (p_keep_offsets) {
		_compute_anchors(Rect2(data.pos_cache, new_size), data.offset, data.anchor);
	} else {
		_compute_offsets(Rect2(data.pos_cache, new_size), data.anchor, data.offset);
	}
	_size_changed();
}

In order to post some kind of warning for setting below the minimum value, this warning would be shared for all control UI nodes, and would also be posted every time the user attempts to set a control UI's values below their minimum. I can implement this warning, but I am unsure if it would be a beneficial change or not.


Doctests for README

This is just a hint you might like. Take it or leave it!
You got this in your code:
https://github.com/Teh-Bobo/unicode-title-case/blob/485af201a55e309a33b667b299e6404211f25d8c/src/lib.rs#L726-L735
I had also run into the issue of wanting to doc test the README, and not duplicate documentation. There's an alternative:
#![doc = include_str!("../README.md")]

at the top of lib.rs will just drop your README.md verbatim into there. Doc tests will work, and documentation on docs.rs will also look identical to your README. Even embedded images will show up correctly on both GitHub and docs.rs. Only downside I've found so far is that Rust doc-specific magic links don't translate to GitHub markdown, of course.

What a great idea! I hadn't considered that. Thanks for sharing. It is now published as version 2.2.1.


How to Convert Interlinked two .class java classes to .avm ?

I am getting this error

ConvertError:System.Exception: new not supported type.com.sample.main.test.CardInfo
at Neo.Compiler.JVM.ModuleConverter._ConvertNew(JavaMethod method, OpCode src, NeoMethod to)
at Neo.Compiler.JVM.ModuleConverter.ConvertCode(JavaMethod method, OpCode src, NeoMethod to)
at Neo.Compiler.JVM.ModuleConverter.ConvertMethod(JavaMethod from, NeoMethod to)
at Neo.Compiler.JVM.ModuleConverter.Convert(JavaModule _in)
at Neo.Compiler.Program.Main(String[] args)

Let your class file without package and try again. Like this.

@SabarishT

@superboyiii I have tried in default package also. Please find Below

Here I am trying to convert ICOTemplate.class to .avm. I am getting same error. TempleToken.java is called(interlinked) in ICOTemplate.java

Kindly need help in this issue.

Hello @SabarishT,
Are you still having problems?

Hello,
I'm closing this due to inactivity.


Feedback: Tutorial 2017

Students needed between half an hour and four hours, the latter due to IDE problems. But not everyone managed to get through the tutorial. Some concerns were raised about too much text to read, in particular the section about fixing the problems. A student requested to add a link to the standard JavaDocs online, because search results unearthed ancient versions of the JavaDocs.
Ideas for 2018 (see also #63):

Move detailed instructions and descriptions to an extra page. Keep the main page structured as it is, but more concise. Link to the extra page where appropriate, for students that need the details.
Reserve some time in week 2 for feedback and questions about the tutorial. Delay the first classroom exercise to week 3. Discuss Message Board functionality in week 2 then (see #57)?
Link to the online version of the standard JavaDocs. In an extra "References" section at the end of the main page?
Mention "create project from JAR" as an IDE operation. That way, information from the manifest should be found by the IDE. If students just unzip the JAR and create the project from that directory, the manifest gets ignored at least by one IDE.
Create issue(s) about setup instructions for different IDEs? Invite students to contribute.

Create Feedback issues in advance.
In the instructions, link to https://github.com/rolandweber/pityoulish/labels/Feedback


Update review-database to 0.18.0

Codecov Report
Patch has no changes to coverable lines.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed
Coverage

src/graphql/cluster.rs
0.00%

src/graphql/model.rs
0.00%

src/graphql/outlier.rs
0.00%

:loudspeaker: Thoughts on this report? Let us know!.


Add commit hooks

for #477

I couldn't get pyflakes to work properly. It doesn't ignore the lines with # noqa.
❯ pyflakes tinygrad/
tinygrad/__init__.py:1:1: 'tinygrad.tensor' imported but unused
tinygrad/__init__.py:1:1: 'tinygrad.nn' imported but unused
tinygrad/lazy.py:139:35: local variable 'ret' is assigned to but never used

mypy gives a lot of errors with the --check-untyped-defs flag. I'll try to fix these.
❯ mypy tinygrad/ --ignore-missing-imports --check-untyped-defs
tinygrad/shape/__init__.py:131: error: Argument 1 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:131: error: Argument 2 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:147: error: Argument 2 to "View" has incompatible type "List[int]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:171: error: Argument 2 to "View" has incompatible type "List[int]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:186: error: Argument 1 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:186: error: Argument 2 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:205: error: Argument 1 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:215: error: Argument 2 to "View" has incompatible type "List[int]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:224: error: Argument 1 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/shape/__init__.py:224: error: Argument 2 to "View" has incompatible type "List[Any]"; expected "Tuple[int, ...]"  [arg-type]
tinygrad/ast.py:122: error: Incompatible types in assignment (expression has type "Union[Literal[False], Any]", variable has type "List[Any]")  [assignment]
tinygrad/llops/ops_cpu.py:35: error: Cannot call function of unknown type  [operator]
tinygrad/llops/ops_cpu.py:36: error: Cannot call function of unknown type  [operator]
tinygrad/llops/ops_cpu.py:37: error: Cannot call function of unknown type  [operator]
tinygrad/llops/ops_cpu.py:38: error: Cannot call function of unknown type  [operator]
tinygrad/llops/ops_llvm.py:107: error: Item "None" of "Optional[Any]" has no attribute "target_data"  [union-attr]
tinygrad/llops/ops_llvm.py:115: error: Item "None" of "Optional[Any]" has no attribute "run"  [union-attr]
tinygrad/llops/ops_llvm.py:121: error: Item "None" of "Optional[Any]" has no attribute "emit_assembly"  [union-attr]
tinygrad/llops/ops_llvm.py:122: error: Item "None" of "Optional[Any]" has no attribute "add_module"  [union-attr]
tinygrad/llops/ops_llvm.py:123: error: Item "None" of "Optional[Any]" has no attribute "finalize_object"  [union-attr]
tinygrad/llops/ops_llvm.py:130: error: Item "None" of "Optional[Any]" has no attribute "get_function_address"  [union-attr]
tinygrad/llops/ops_llvm.py:141: error: Item "None" of "Optional[Any]" has no attribute "remove_module"  [union-attr]
tinygrad/llops/ops_llvm.py:313: error: Cannot call function of unknown type  [operator]
tinygrad/llops/ops_llvm.py:318: error: Cannot call function of unknown type  [operator]
tinygrad/tensor.py:165: error: "Tensor" has no attribute "slice"  [attr-defined]
tinygrad/tensor.py:171: error: Incompatible types in assignment (expression has type "List[Any]", variable has type "Tuple[Any, ...]")  [assignment]
tinygrad/tensor.py:176: error: "Type[Tensor]" has no attribute "__iadd__"  [attr-defined]
tinygrad/tensor.py:183: error: "Tensor" has no attribute "slice"  [attr-defined]
tinygrad/tensor.py:222: error: "Type[Tensor]" has no attribute "_sum"  [attr-defined]
tinygrad/tensor.py:223: error: "Type[Tensor]" has no attribute "_max"  [attr-defined]
tinygrad/tensor.py:247: error: Unsupported left operand type for * ("Tensor")  [operator]
tinygrad/tensor.py:258: error: "Tensor" has no attribute "_conv2d"; maybe "conv2d"?  [attr-defined]
tinygrad/tensor.py:263: error: Unsupported operand types for - ("float" and "Tensor")  [operator]
tinygrad/tensor.py:265: error: Unsupported left operand type for * ("Tensor")  [operator]
tinygrad/tensor.py:267: error: "Tensor" has no attribute "relu"; maybe "relu6" or "elu"?  [attr-defined]
tinygrad/tensor.py:273: error: "Tensor" has no attribute "relu"; maybe "relu6" or "elu"?  [attr-defined]
tinygrad/tensor.py:273: error: "Tensor" has no attribute "exp"  [attr-defined]
tinygrad/tensor.py:276: error: "Tensor" has no attribute "relu"; maybe "relu6" or "elu"?  [attr-defined]
tinygrad/tensor.py:276: error: "int" has no attribute "relu"  [attr-defined]
tinygrad/tensor.py:276: error: Unsupported operand types for - ("Tensor" and "int")  [operator]
tinygrad/tensor.py:277: error: "int" has no attribute "relu6"  [attr-defined]
tinygrad/tensor.py:277: error: Unsupported operand types for + ("Tensor" and "int")  [operator]
tinygrad/tensor.py:278: error: "float" has no attribute "sigmoid"  [attr-defined]
tinygrad/tensor.py:278: error: Unsupported operand types for * ("float" and "Tensor")  [operator]
tinygrad/tensor.py:279: error: Unsupported operand types for * ("float" and "Tensor")  [operator]
tinygrad/tensor.py:279: error: "float" has no attribute "tanh"  [attr-defined]
tinygrad/tensor.py:279: error: Unsupported operand types for * ("Tensor" and "float")  [operator]
tinygrad/tensor.py:280: error: "float" has no attribute "sigmoid"  [attr-defined]
tinygrad/tensor.py:280: error: Unsupported operand types for * ("Tensor" and "float")  [operator]
tinygrad/tensor.py:281: error: "Tensor" has no attribute "relu"; maybe "relu6" or "elu"?  [attr-defined]
tinygrad/tensor.py:296: error: "Type[Tensor]" has no attribute "_add"  [attr-defined]
tinygrad/tensor.py:297: error: "Type[Tensor]" has no attribute "_sub"  [attr-defined]
tinygrad/tensor.py:298: error: "Type[Tensor]" has no attribute "_mul"  [attr-defined]
tinygrad/tensor.py:299: error: "Type[Tensor]" has no attribute "_pow"  [attr-defined]
tinygrad/tensor.py:300: error: "Tensor" has no attribute "reciprocal"  [attr-defined]
tinygrad/tensor.py:305: error: "Tensor" has no attribute "_reshape"; maybe "reshape" or "shape"?  [attr-defined]
tinygrad/tensor.py:306: error: "Tensor" has no attribute "_expand"; maybe "expand"?  [attr-defined]
tinygrad/tensor.py:307: error: "Tensor" has no attribute "_permute"; maybe "permute"?  [attr-defined]
tinygrad/llops/ops_gpu.py:55: error: Need type annotation for "devices"  [var-annotated]
tinygrad/llops/ops_gpu.py:90: error: Item "None" of "Optional[Any]" has no attribute "finish"  [union-attr]
tinygrad/llops/ops_gpu.py:356: error: Invalid index type "Union[UnaryOps, BinaryOps, ReduceOps, MovementOps, ProcessingOps, LoadOps]" for "Dict[ReduceOps, str]"; expected type "ReduceOps"  [index]
tinygrad/llops/ops_gpu.py:376: error: Item "None" of "Optional[LazyOp]" has no attribute "op"  [union-attr]
tinygrad/llops/ops_gpu.py:378: error: Item "None" of "Optional[LazyOp]" has no attribute "op"  [union-attr]
tinygrad/llops/ops_gpu.py:420: error: Incompatible types in assignment (expression has type "Union[CLImage, CLBuffer]", variable has type "Optional[CLBuffer]")  [assignment]
tinygrad/llops/ops_gpu.py:422: error: Item "None" of "Optional[CLBuffer]" has no attribute "cl"  [union-attr]
tinygrad/llops/ops_gpu.py:424: error: Item "None" of "Optional[CLBuffer]" has no attribute "cl"  [union-attr]
Found 66 errors in 6 files (checked 16 source files)

Merged anyway, thanks for the hooks!

Want to bring back #415? It broke stable diffusion on my computer, wonder if there's a way to write a fast test that stable diffusion runs without needing to load or run the model?

Want to bring back #415? It broke stable diffusion on my computer, wonder if there's a way to write a fast test that stable diffusion runs without needing to load or run the model?

I couldn't figure out how to get stable diffusion to work without the "elementwise_affine on channels" hack. But I'll try and bring it back when I'm more familiar with transformers.


Updating dependencies

As I updated my dependencies in my main project the ember-cli-babel versions collided so i am in need for a new version with updated dependencies.

Thanks for contributing however I do not maintain this project anymore :/ I recommend using ember-auto-import to use md5 directly and implement your own helper if needed


build: Add cudf and modin to deps

closes #815

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #
Closes #

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

merging to get ci green again 🥦


Styles: Long item overlows context menu in breadcrumb

This may not be isolated to the breadcrumb, and have to do with the Context Menu in general, but it seems like a long item here overflows the max-width of the Context Menu item. I think we shouldn't have a max-width on the item and allow it to expand to accommodate any content no matter how wide.

Closing with #815


revise 'rare' terms tagged for obsoletion

Paola and I worked on these together

[ ] ask Ana about the justification for 'rare gastroesophageal tumor' grouping class
[ ] need to rehome 'rare epithelial tumor of stomach'
[ ] obsolete 'rare gastroesophageal tumor'


activating or deactivating a debug node turns the deploy button red

Maybe related to #1310 ?

That intended as this change is actually written to file, pre 0.17 behaviour is actually a bug.

Yup - working as designed.
Disabling a debug node is a material change to your flow config and needs a deploy to be saved.
Previously, if you disabled your debug nodes, and didn't deploy, if NR restarted they would all become active again. That had caused problems with users who had disabled their nodes for performance reasons and they unexpectedly reenabled.

interesting - I actually thought it was saving those changes to the state of debug nodes "under the covers"... thanks for clarifying :)


add the script used for the final video ?

Unfortunately I cannot find the script used for the final video

Hi, the script for the final video is located on "cineditorml.program.scenarios/final_cut.space"

https://github.com/montoyadamien/cineditorml/blob/4d259cb89c2a233c25128e697ffd31029b7e9e13/cineditorml.program.scenarios/final_cut.space#L1


In-memory datastore for aleph peers

This adds a Datastore class that's backed by the in-memory MemDOWN backend for LevelUP, the node leveldb library.
I went this route rather than rolling my own in-memory kv store because

this gives us an easy path to a persistent datastore by using the leveldb (or rocksdb) backend
it forced me to use an async put/get interface, which we'll need if we do the above
it was pretty easy

Aleph nodes now supports the /mediachain/data protocol to fetch data, but writing to the datastore needs to happen in-process (no push or merge support yet).  Still, merge should be fairly easy to accomplish, since we've got remote query working already.
I added a simple test between two aleph nodes, but haven't done an integration test yet.

:+1: for having a real datastore.
Basically, in terms of workflow, aleph can be the workspace where you are building your data, and when you are ready to publish you push them to your concat.


Plt 5574

Summary
This adds the ability to traverse the emojis via keyboard shortcuts (up, down, left, right keys) and select via enter key.
This is an update/ rewrite of a lot of the emoji component. Mostly I re-wrote in order to normalize the emoji data and allow for traversing the input via keyboard. I am not sure how it would be possible any other way.
Ticket Link
https://github.com/mattermost/mattermost-server/issues/6283#issuecomment-345337041
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

re: @crspeller

Thanks @stephenkiers for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Looks like there's style check errors - make check-style

I may be confused with that command. I ran it and there were errors, but they seemed to have nothing to do with my PR. Or maybe I am reading it wrong.
I get a couple
can't load package  and "./enterprise/..." matched no packages messages.
Is there documentation on how to use this tool properly? None of the errors mention the files I changed (which all include the word emoji).
thanks

Would love guidance on how to read this, and how to fix.

I also did not see an option to squash commits when creating the PR.

Thanks @stephenkiers!
You should be able to run make check-style in the webapp repository to avoid those other errors.
Your current errors from the build server:
$ eslint --ext ".jsx" --ignore-pattern node_modules --quiet .

/home/jenkins/workspace/mattermost-webapp_PR-315-NATYDXAON7VXNT6R4RMSKDPG6JXU72NZTFCTVP3THXIBCKPCHRPA/mattermost-webapp/components/emoji_picker/components/emoji_picker_item.jsx
  33:20  error  Expected space(s) after "if"  keyword-spacing

/home/jenkins/workspace/mattermost-webapp_PR-315-NATYDXAON7VXNT6R4RMSKDPG6JXU72NZTFCTVP3THXIBCKPCHRPA/mattermost-webapp/components/emoji_picker/emoji_picker.jsx
  21:1  error  Expected line before comment  lines-around-comment

✖ 2 problems (2 errors, 0 warnings)

Also if you could please sign the CLA we can then review this PR.

Ahh. I need to switch directories to run it. That makes sense.
I will do this today and also take care of the paperwork.
Thanks
Stephen Kiers
780.893.4463
Sent from my iPhone

On Nov 19, 2017, at 1:57 AM, Christopher Speller<EMAIL_ADDRESS>wrote:
Thanks @stephenkiers!
You should be able to run make check-style in the webapp repository to avoid those other errors.
Your current errors from the build server:
$ eslint --ext ".jsx" --ignore-pattern node_modules --quiet .
/home/jenkins/workspace/mattermost-webapp_PR-315-NATYDXAON7VXNT6R4RMSKDPG6JXU72NZTFCTVP3THXIBCKPCHRPA/mattermost-webapp/components/emoji_picker/components/emoji_picker_item.jsx
33:20  error  Expected space(s) after "if"  keyword-spacing
/home/jenkins/workspace/mattermost-webapp_PR-315-NATYDXAON7VXNT6R4RMSKDPG6JXU72NZTFCTVP3THXIBCKPCHRPA/mattermost-webapp/components/emoji_picker/emoji_picker.jsx
21:1  error  Expected line before comment  lines-around-comment
✖ 2 problems (2 errors, 0 warnings)
Also if you could please sign the CLA we can then review this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0db8bda6fae7f27bf.spinmint.com
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0db8bda6fae7f27bf

Okay, I also noticed that I had removed the lazy loading feature, so I made sure to re-enable that.
I think that this new emoji picker follows the react paradigm better than the original implementation and the data is more normalized.
I would love feedback and comments though. This is my first PR here.
thanks

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0709ea0f0b4c54135.spinmint.com
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0709ea0f0b4c54135

That simply is a css hover style; both are not actually selected at one. I will change that this evening when I am free.

Is that acceptable? Or what would you expect the UX to be there?
Note: If you

hover your mouse,
change selection with the keyboard
hit enter
the keyboard selected value will be inserted

Also, a separate Issue should probably be created to have a keyboard shortcut to open the emoji dropdown without the mouse as well.

@stephenkiers yes it would be expected that if you moved your mouse after using the arrows that the mouse emoji would show the hover effect, similar to Slack example above ^.
The key is that only one emoji should show the selection effect otherwise the UX is confusing.

Great. Just wanted to confirm ux. This should be a simple update.

So, I rebased and pushed changes and that seems to have put all the changes into this PR. I thought that was required, but I am now thinking that was a mistake. Let me know if that causes any issues

Yeah, that looks like it might've mangled it. If you use git rebase -i master, you can remove commits that don't belong to you to get rid of those

It was a little more complicated than that, but I think I got it back to pre-rebase.

@esethna  changes made.

All changes requests, thusfar, have been responded too.

How do I trigger a remove the "Awaiting Submitter Action" tag? Is there something I have to do?

Thanks @stephenkiers, will take another review now :)

Spinmint test server destroyed

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-0ba689c094df09eb3.spinmint.com
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-0ba689c094df09eb3

The loaded emojis should not re-render every time the emoji picker opens. See below.

I will take a look at this tonight and see how to fix this.

Thanks.

@esethna I am trying to reproduce your emoji filter problem and am unable to. Can you check to see if there are any errors in your console when you are filtering? Or let me know what browser and OS you are testing on so I can reproduce on my side?
thanks

@stephenkiers I can't seem to repro anymore, moving to dev review now, thanks!

Spinmint test server destroyed

@saturninoabril I added the lazy loader approach so that it only loads/shows the emojis when they are within the view of the user. Every re-open DOES cause this to happen again, since there is no global state that is managing the loaded emojis.
I felt the lazy loading was ideal because anyone who has a lot of custom emojis could see performance issues on some devices loading every emoji, every time. Although this is the current way of doing things, so perhaps it is okay...?
Plus, I assume people search for the emoji they want, so loading hundreds of emojis into memory seemed overkill to me. But perhaps I am pre-optimizing for a problem that doesn't exist.
@hmhealey @esethna I will leave this UX decision to you guys. You understand the usage better than I do atm.
1/5 <- did I do that right?

@jwilander should I rebase this PR? Last time I did that, it made my changes hard to detect in the PR. thanks

Also, you will need to rebase again since it's preventing the unit tests from being ran. I don't know what keeps changing that file

The tests ran at least, but something definitely went wrong with the rebase since you've got over 250 commits here now

Going to re-attempt rebase.

bump


User can tag a quest with the "sphere of science"

Users can tag quests to tag science spheres.
See spheres tab in:
https://docs.google.com/spreadsheets/d/1jDq7fswDis3r2oEljzksMsWm4Dr9eG9u2DFl-9TOt9c/edit#gid=812985204

This applies to the old MVP.


Fix demo props and remove iron flex layout

Hello,
I found that px-alert-message had a dep on iron-flex-layout which I found not being used anywhere. As well as the props in the demo were not right. So fixed that too. Now, changing the type prop updates the demo alert message (it wasn't doing so).

Removed iron-flex-layout from bower.json
Changed type prop to lower case from capital case.
bumped version to 0.8.5 (patch).

PS: iron-flex-layout was using version 1.0.x whereas the paper elements we are using required 1.3.x, so this inspired me to fix this.

@runn-vermel Please have a look at this.

Thanks for the PR! available in v0.8.5

@runn-vermel Thanks for merging. But I don't see the new tag v0.8.5. Do we make a release manually ?

ha, i should remove the previous comment - we had it up there for a second, and had to take it down - we are having issues with one of the tests running on Windows 10 and Edge.
We are looking into it, but would love it if you also took a look :)

@runn-vermel  Can you share some details as to what the issue is ?

It's fixed now - I pushed out a change late Friday. With the S3 outage we had some changed backed up, we had to fix issues in a previous PR first. Sorry for the delay.

Nice. Thanks guys.


condition confusion

mapper gets confused between conditions it imposes automatically due to hit points and those manually applied.

Need to correct the wording for the pop-up tooltip for stunned/staggered/disabled and make sure that automatically imposed conditions get popups too.


Add handling minimum_id

Summary
Added handling minimum_id in Assert
New behavior
If a TestScript contains a minimumId in Assert, the engine examines if the response contains at a minimum the fixture specified by minimumId.
The definition of "minimum" is

All the elements with their values in the minimum fixture should exist the same in the response. (order doesn't matter)
The elements with values in the minimum fixture and the response should be in the same hierarchies.

Code changes
Added a Hash function: deep_merge() in assertion.rb. This is a function merging two hashes into one recursively.
The essential logic of judging whether a minimum fixture included in response or not is:

Convert FHIR resources into Hash
Merge minimum fixture and response into one
If the merged Hash is same as the response, minimum fixture is included in response. If there is any unique element/value on the minimum fixture's end, the merged Hash will contain it (difference). Therefore the merged Hash won't be same as the response.

Testing guidance
Use general_testscript.json

The approach looks solid, but some brief changes requested. Also, you should create rspec unit tests for minimumId. You should create an assertions subfolder within the spec directory, and then something like a minimum_id_spec.rb file to test this behavior.

Yes, I will add rspec.

The approach looks solid, but some brief changes requested. Also, you should create rspec unit tests for minimumId. You should create an assertions subfolder within the spec directory, and then something like a minimum_id_spec.rb file to test this behavior.

Does this minimum_id rspec part need to be separate from assertions_spec.rb?

Got it. I will create a separate one. Thanks!

Incorporated all suggestions.


Issue 341 - Warning if HistoricalRecords(inherit=False) in an abstract class

Description
Working on this at a sprint at DjangoCon 2018.
I am issuing a Python Error here with warnings.warn. The other option I see is to try to issue it with Django's System Check Framework, but I'm not 100% sure how to do that, since it would probably require extending the check method, but then at that point I'm not sure how I would go about getting the cls object.
Related Issue
https://github.com/treyhunner/django-simple-history/issues/341
Motivation and Context
If HistoricalRecords is added to an abstract model and inherit=False, the models that are subclassed from this abstract model will not have their histories saved.
How Has This Been Tested?
I ran a sample project on Django 2.1 that tried to create an abstract model with HistoricalRecords(inherit=False) and the warning was successfully raised. I also tried to subclass that abstract model and the warning was raised for that subclassed model as well.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I'm not 100% sure how to run further tests, nor am I sure if raising a Python-based exception is the in code style of this project. Please let me know and I'll change things accordingly!

Looks good but needs style fixes

Happy to help, but I'm new to committing to public repositories. Can you expand a bit on how I should fix the style?

Hi @shlywa sorry I thought I responded this.  Also try rebasing because they may be fixed already

@shlywa want to take this? Or want me to do it? Thanks

@rossmechanic Swamped at work this week. I can probably do it sometime in the next two weeks, but if you'd like to hammer it out sooner, feel free to take it! This was my first PR, so I'm not exactly sure what the etiquette is.

@shlywa no worries. I'll take it over and add you to AUTHORS.rst. Thanks!

Closing this with #472 . Thanks @shlywa


win10 just 0.10.6 sed output in empty just invocation.

Installed just via cargo. Running the version command works fine and doesn't say anything about sed.
# just --version
just 0.10.6
# where just
C:\Users\dhorner\.cargo\bin\just.exe

using the keybase example renamed to justfile.  The default recipe works fine.  With no arguments in a directory with no justfile, I get information about a sed invalid option E and something about "cargo ltest".  I have no idea why I would be getting any output from sed?!
# just
sed: invalid option -- E
Usage: sed [OPTION]... {script-only-if-no-other-script} [input-file]...

  -n, --quiet, --silent
                 suppress automatic printing of pattern space
  -e script, --expression=script
                 add the script to the commands to be executed
  -f script-file, --file=script-file
                 add the contents of script-file to the commands to be executed
  -c  --nocr     turn off \r$ translation; must be first switch on command line
      --help     display this help and exit
  -V, --version  output version information and exit

If no -e, --expression, -f, or --file option is given, then the first
non-option argument is taken as the sed script to interpret.  All
remaining arguments are names of input files; if no input files are
specified, then the standard input is read.

E-mail bug reports to<EMAIL_ADDRESS>.
Be sure to include the word ``sed'' somewhere in the ``Subject:'' field.
cargo ltest
error: no such subcommand: `ltest`

        Did you mean `test`?
error: Recipe `test` failed on line 18 with exit code 101

Are you calling just from a checkout of the just project itself? If so, then you have the project justfile in a parent directory, which calls sed -E.

Thank you, that was what I was running into! :)
I am trying to get system wide recipes via a .user.justfile in my %USERPROFILE% directory.  just is not seeing the recipes in the .user.justfile.

Thank you, that was what I was running into! :)

Nice, glad you got it working.

I am trying to get system wide recipes via a .user.justfile in my %USERPROFILE% directory. just is not seeing the recipes in the .user.justfile.

You'll need to invoke just via an alias to pick up those recipes:
alias .j='just --justfile ~/.user.justfile --working-directory .'

Is there an issue with having just pull in the .user justfile automatically?
alias / doskey / Set-Alias etc work in the shell but not ideal; would expect user profile files to apply to the user.
--justfile .user.justfile is a strange convention if it requires it to be fully specified.

I think this comes closest: #1036
It would allow putting fallback recipes in ~/.justfile.

I'm uncertain at this time how to go about doing that.  I will watch the issue; it's really not a huge deal, I was just interested to see how the profile would work.  thanks for the responses.


fatal: 'no_push' does not appear to be a git repository

Description
When running pp to pull from origin I get this:
git --no-pager -c color.ui=always --no-optional-locks pull no_push master --rebase:
    fatal: 'no_push' does not appear to be a git repository
    fatal: Could not read from remote repository.

    Please make sure you have the correct access rights
    and the repository exists.

    Open the console for details

This is what I see in the popup:

Not sure if this is a misconfiguration of my repo?
Neovim version
0.9.1
Operating system and version
Debian 12 (bookworm)
Steps to reproduce

Expected behavior
No response
Actual behavior

Minimal config
-

So, this isn't a bug. pp doesn't pull from origin - it pulls from the current pushRemote for the branch. Thats often origin, but it's set via the config value branch.<branch name>.pushRemote. In your screenshot, it says "pull into master from: no_push/master. So your branch's pushRemote is no_push`. No idea why 🤷🏼
Fortunately, it's very easy to change :)
You can check what it's currently set to in the branch popup, or the branch config popup (pC):

To pull from origin, use pu. In fact, for many different popups, the p action will use the pushRemote, and the u action will use origin.
I'm going to close this, since it seems like it's working exactly as expected, but feel free to reopen if you disagree, or think it could be handled differently.

Ah interesting. Sorry about that!
And thanks for the tip. I'll figure this out.

No worries - the only reason I know any of this is from engineering the magit source to figure out how to implement it here.