🚀 - Options to get Raw/Original/Unmask value

Which package(s) are relevant/related to the feature request?
No response
Description
for example if i input number: 100000, i will be able to get { value: 100,000,  rawValue: 100000}

That would not be possible for any complex masking case, because original value can be changed tremendously. You get raw values in processors, but after everything is finished — it's gone. Say your postprocessor changes all 'good' into 'bad'. Then you go and add a char in the middle to make it 'bard'. What would be the raw value? If you just want to have the unformated number, there's a utility function maskitoParseNumber mentioned in the docs at the very top:
https://maskito.dev/kit/number

I actually think this would be pretty useful - in some cases I need to format a postal code for user input with a separator, like "12-345" but the API I'm sending this value to expects a clean value, without the "12345". I understand that removing the mask after it is applied is impossible, but it seems feasible to just keep the unformatted value somewhere else.

I gave an example where there is no such thing as "unformatted" value generally speaking. You have a few options:

unmask your values before sending them to the API.
make a plugin to emit raw value for every input — listen to beforeinput event in capture phase to make sure it kicks in before masking
create a wrapper for storing your values that would mask and unmask automatically.

Here's an example using Angular:
https://stackblitz.com/edit/angular-4hcxec?file=src%2Fapp%2Funmask.directive.ts

Update @waterplea Versions 3: The directive version in case anyone interesed:
The Directive
import { Directive, effect, input, OnInit } from '@angular/core';
import type { MaskitoOptions } from '@maskito/core';
import { MaskitoDirective } from '@maskito/angular';
import { DefaultValueAccessor } from '@angular/forms';

export type UnmaskFn = (value: unknown) => unknown;
export interface MaskOptions {
  maskitoOptions: MaskitoOptions;
  unmaskFn?: UnmaskFn;
}

@Directive({
  selector: '[ingMask]',
  standalone: true,
  hostDirectives: [
    {
      directive: MaskitoDirective,
      inputs: ['maskitoElement'],
    },
  ],
})
export class MaskDirective implements OnInit {
  options = input.required<MaskOptions>({ alias: 'ingMask' });

  constructor(
    private maskito: MaskitoDirective,
    private accessor: DefaultValueAccessor,
  ) {
    effect(() => {
      this.maskito.options = this.options().maskitoOptions;
      void this.maskito.ngOnChanges();
    });
  }

  ngOnInit() {
    const unmaskFn = this.options().unmaskFn;

    if (unmaskFn) {
      const original = this.accessor.onChange.bind(this);
      this.accessor.onChange = (value) => original(unmaskFn(value));
    }
  }
}

Usage in TS
  protected readonly control = new FormControl<any>('');
  protected readonly maskitoOptions: MaskOptions = {
    maskitoOptions: { mask: [/\d/, /\d/, ':', /\d/, /\d/] },
    unmaskFn: (value) => {
      return (value as string).substring(0, 2);
    },
  };

Usage in HTML
<input [formControl]="control" [ingMask]="maskitoOptions" />
<button (click)="setValue()">Set 1231</button>

value: {{ control.getRawValue() }}


feat: support mouse button 6&7

For mouse like Logi MX master3, the two side buttons are Mouse button 6 and Mouse button 7.
This PR simply maps the two buttons to BTN_SIDE and BTN_EXTRA, and fix the issue that xwayland would crash when button 6 or 7 is clicked.

I'm curious as to which server is actually sending this, as I've always had the extras mapped back to 4 and 5 instead, and I think they'd actually be dropped by input-leap. Out-of-range buttons should definitely be dropped here as well, but I'll do that in another commit and merge this, as -- while looking a bit weird to repeat the buttons in the default map -- it solves a problem, and can't really create one for anyone else.
Thank you for this and your other recent PR, by the way.

I'm using https://github.com/pwr-Solaar/Solaar for Logi mouse, but I think the key map is default for the side buttons.
Yes, the issue is actually introduced by the out-of-range buttons which were mapped to strange keycodes. So I also wonder whether more mouse buttons should be supported.
Thank you for your wonderful work and passion!


Enhancement: Display inactive-account indicator next to locked accounts at various locations

This PR adds a lock-symbol next to accounts, that have been set to "INACTIVE".
The goal is to help making sense about (deprecated) applications & leaves of users, that have left the company or are deactivated for other reasons,
The symbol will be visible at the following locations:

Person Overview
Person Detail View

Person Base Data Editor
Person Permission Editor

Application Overview

Hey @systemofapwne,
thanks for your PR! I like the idea to visualize that a person is in active. Some thoughts of mine.

The icon should not be in a link
We need to unify the "inactive" icons
A11y should be added and maybe a title or some information what the lock stands for
Lock should be from lucide (and it is or? https://lucide.dev/icon/lock?search=lock)
Dark mode (seems ok)

Unification:
Persons and other places? the eye-off icon is only used here

Hey @systemofapwne,
thanks for your PR! I like the idea to visualize that a person is in active. Some thoughts of mine.

The icon should not be in a link
We need to unify the "inactive" icons
A11y should be added and maybe a title or some information what the lock stands for
Lock should be from lucide (and it is or? https://lucide.dev/icon/lock?search=lock)
Dark mode (seems ok)

Unification: Persons and other places? the eye-off icon is only used here
@bseber what do you think?

Thank you for your reply.
Alright, I will move the icon out of the link. That is a no-brainer.
I will also change the icon from the lock-type to the eye-type to unify the icon-style and add a hover-message to it.
The lock-icon was from lucide.
I did not add the indicator to other locations yet but I agree, this makes sense.
Btw: Right now, I am struggling with the automated tests, that seem to fail on github and also on my pc on a completely unrelated location to my changes:
ERROR] Errors:  [ERROR]   OvertimeCreateIT.ensureOvertimeCreation:138 » Timeout Expected condition faile...
which can be traced back up to here: https://github.com/urlaubsverwaltung/urlaubsverwaltung/blob/886a78ecbd5d299b4dd4a4af107b86def8b70bd8/src/test/java/org/synyx/urlaubsverwaltung/ui/SickNoteIT.java#L144
If you could direct me towards the error, this would be great.
Thanks in advance.

I added the requested changes and fixed the "test" run, that initially failed.
A11y: Can you please elaborate, if the added "title" tag in the span around the SVGs is sufficient?

nice one @systemofapwne 🤩
a11y: I would just add plain text which could be (maybe should be in our case) hidden visually.
Jane Doe <svg ... />(inactive user)

Regarding the icon: Introducing this element in the whole application we should think about whether the crossed eye is ok or not. I think the eye could be useful for other use cases whether something should be visible or hidden. The user state "disabled" / "inactive" could be communicated with:
eye:

ghost:

user-x:

octagon:

I quite like the ghost icon as it is kind of funny and arouses emotions. Second vote goes to user-x.

nice one @systemofapwne star_struck
a11y: I would just add plain text which could be (maybe should be in our case) hidden visually.
Jane Doe <svg ... />(inactive user)

Regarding the icon: Introducing this element in the whole application we should think about whether the crossed eye is ok or not. I think the eye could be useful for other use cases whether something should be visible or hidden. The user state "disabled" / "inactive" could be communicated with:
eye:

ghost:

user-x:

octagon:

I quite like the ghost icon as it is kind of funny and arouses emotions. Second vote goes to user-x.

but if we use a new icon, than we should use it everywhere in the application. :)

nice one @systemofapwne star_struck
a11y: I would just add plain text which could be (maybe should be in our case) hidden visually.
Jane Doe <svg ... />(inactive user)

Regarding the icon: Introducing this element in the whole application we should think about whether the crossed eye is ok or not. I think the eye could be useful for other use cases whether something should be visible or hidden. The user state "disabled" / "inactive" could be communicated with:
eye:
https://user-images.githubusercontent.com/1732200/215038979-86e7b792-1f22-4c85-8cd2-905b6b045b14.png
ghost:
https://user-images.githubusercontent.com/1732200/215038973-1b242436-3d1b-475c-ae12-098fb54e506b.png
user-x:
https://user-images.githubusercontent.com/1732200/215038977-a173bbd8-f132-4d9b-ab21-d100684d6373.png
octagon:
https://user-images.githubusercontent.com/1732200/215038968-5a2b09f7-c48a-43ce-8eac-d8dfb447a8ec.png
I quite like the ghost icon as it is kind of funny and arouses emotions. Second vote goes to user-x.

Thank you. I added your suggestion regarding A11y.
Regarding the icon decision, I am open for everything. Right now, the eye-off next to the name looks a bit out of place.
This is not a big deal for the users list, since the text "active/inactive" is written right next to it.
So a decision has to be made:

We stick to the current symbols and accept, that eye-off standing alone is not so conclusive.
Or we introduce a new icon set of active & inactive, that are conclusive even when standing alone.

nice one @systemofapwne star_struck
a11y: I would just add plain text which could be (maybe should be in our case) hidden visually.
Jane Doe <svg ... />(inactive user)

Regarding the icon: Introducing this element in the whole application we should think about whether the crossed eye is ok or not. I think the eye could be useful for other use cases whether something should be visible or hidden. The user state "disabled" / "inactive" could be communicated with:
eye:
https://user-images.githubusercontent.com/1732200/215038979-86e7b792-1f22-4c85-8cd2-905b6b045b14.png
ghost:
https://user-images.githubusercontent.com/1732200/215038973-1b242436-3d1b-475c-ae12-098fb54e506b.png
user-x:
https://user-images.githubusercontent.com/1732200/215038977-a173bbd8-f132-4d9b-ab21-d100684d6373.png
octagon:
https://user-images.githubusercontent.com/1732200/215038968-5a2b09f7-c48a-43ce-8eac-d8dfb447a8ec.png
I quite like the ghost icon as it is kind of funny and arouses emotions. Second vote goes to user-x.

Thank you. I added your suggestion regarding A11y.
Regarding the icon decision, I am open for everything. Right now, the eye-off next to the name looks a bit out of place. This is not a big deal for the users list, since the text "active/inactive" is written right next to it. So a decision has to be made:
* Either we stick to the current symbols and accept, that eye-off standing alone is not so conclusive.

* Or we introduce a new icon set of active & inactive, that are conclusive even when standing alone.

If we choose a new icon-set, user-x and a complementary icon would be my favorites too.

My first thoughts are.

Replace eye with person
Replace eye-off with person-x

and we should change in all places. What do you mean @bseber ?

I arbitrarily decided on changing the indicator to user and user-x everywhere. Feel free to comment on this decision. I am open for everything.

Thanks @systemofapwne !


I  need help how to set up complete on website for a html NOOB

im rly new to this and this looks awsome i just dont understand how it work or how to set it up.

Hi Ioniop, thanks for the comment! To use this on a website, you will also need to develop a backend to store the comments, files etc. If you don't have anything like that, it might be a bit of a challenging task for a complete beginner, and something we unfortunately can't help with ATM.
Here's a link to a Laravel implementation by one contributor: https://github.com/Viima/jquery-comments/issues/68#issuecomment-248864183
Hope this helps and best of luck with the project!


There is Any Feature for Log Extraction for error.log

Helo friend,
I want to ask about the extraction for error.log in envoy. Is there any possibility to extract the error.log from the envoy?

What is error.log?


🍒 Cherry pick PR #8314 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/8314 to staging 🍒

🚀 Cherry-picked to staging by @OSBotify in version: 1.1.46-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @timszot in version: 1.1.46-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Machine Learning Extension / ModelDB

https://mitdbg.github.io/modeldb

I'll take it for a test !

Ok so no python 3 support and someone maybe needs to dockerize their env to make it testable...


ROS2 package database

It looks like there's three accidentally added files: app.txt, test.txt, and a *.swp file.


[SR-14952] Unable to provide diagnostic for expression

Previous ID
SR-14952

Radar
rdar://problem/81019906

Original Reporter
Brownie (JIRA User)

Type
Bug

Attachment: Download

Environment
Xcode 13.0 beta 3, deploying to iOS 15

Additional Detail from JIRA

Votes
0

Component/s

Labels
Bug, DiagnosticsQoI, TypeChecker

Assignee
None

Priority
Medium

md5: a71041692c370231dc1d0107c1dc9f09

Issue Description:
Getting an error "Failed to produce diagnostic for expression; please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project" in a semi-new project in a SwiftUI view

Looks like this has been fixed. 5.7 compiler would produce two errors:
error: value of type 'Game' has no member 'games'

and
error: cannot convert value of type 'NBA' to expected argument type 'NBAGames'


Drop SciPy from nightly CI

Closes #853.
Is there a reason for which we aren't testing against nightly NumPy?

I don't know of any. It might be a good idea to add nightly numpy.
I know that these daily failures are super annoying, but the scipy nightly test can occasionally be useful (e.g. #811) Maybe we could raise the missing wheel issue upstream and re-add scipy if/when it is fixed.


Center Register button

On the website, there is a register button, it is not exactly centered in the div.  It needs to be fixed.
Pull requests are welcome.
Contributing standards:
Ensure that the  changes you are making are pushed to a patchfix-1 and not made on the main branch

Hello! Can I be assigned this?

Thank you @ToluAdegboyega!
Issue fixed by @ToluAdegboyega (PR #7 ).
Closing issue.


[help request] Chromeless test recorder adapter

Hey guys, I'm the creator of the TypeScript Test-Recorder chrome extension.
Would anyone be interested in creating a template for chromeless so we can also record tests for this? Its a simple matter of extending the ICodeGenerator with the strings that match the chromeless commans.

+1

Just finished a beta version or a recorder in SnapTest - https://twitter.com/SnapTestIO/status/893202213560090624 . It'd be great to have both these generators going so we can compare notes.

Impressive work! Would love to Skype sometime.
Kind regards
Nikos
quantumjs.com

I'm thinking of implementing this myself in my next version of the Chrome extension, If I'm correct then its a simple matter of changing stuff like:
  elementAdded (queryPath: string): MutationEntry {
    return new MutationEntry(`${queryPath}`, `browser.expect.element('${queryPath}').to.be.present`)
  }

  elementRemoved (queryPath: string): MutationEntry {
    return new MutationEntry(`${queryPath}`, `browser.expect.element('${queryPath}').to.not.be.present`)
  }

to
  elementAdded (queryPath: string): MutationEntry {
    return new MutationEntry(`${queryPath}`, `chromeless.wait('${queryPath}')`)
  }

  elementRemoved (queryPath: string): MutationEntry {
    return new MutationEntry(`${queryPath}`, `chromeless.wait('${queryPath}')`)
  }

However, what would I do to change this text assertion?
  characterDataChanged (record: MutationRecord): MutationEntry {
    let el = record.target as HTMLElement
    return new MutationEntry(`#${el.parentElement.id}`, `browser.assert.containsText('#${el.parentElement.id}','${el.nodeValue}')`)
  }

Minor support for chromeless now part of the test recorder


Gradle Wrapper Jar is Missing

When executing a clean checkout any command with the gradle wrapper fails, e.g.
$ ./gradlew clean
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

because the gradle wrapper jar is missing.

I am learly about including binaries. Boon works with maven out of the gate. I guess folks will have to update this one themselves.


Added CV Builder

Description
Added a Python application with GUI that prompts the user with questions and from the answers, builds a CV in the form of a Word or RTF document.
Motivation and Context
Is a fun and useful program, especially for students.
How Has This Been Tested?
N/A
Screenshots (if appropriate):
Screenshot of GUI included within folder.
Types of Changes

[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

LGTM, Thanks @Tess314 for contributing 😄 !


puddletag: fix wrapping

Description of changes
Closes #212738

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I'm not familiar with qt stuff, so I'd appreciate a review from someone who actually knows best practices for that ecosystem.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1826

Hi! I was referring to the comment https://github.com/NixOS/nixpkgs/issues/212738#issuecomment-1410761903.
Do you also observe the crash when checking About? (I think this is unrelated to this PR, but should be fixed).

Yes:
Traceback (most recent call last):
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/mainwin/funcs.py", line 493, in show_about
    win = about.AboutPuddletag(parent)
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/about.py", line 97, in __init__
    ['%s: %s' % (lib, version) for (lib, version) in versions().items()]
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/about.py", line 67, in versions
    'Chromaprint': get_module_version('chromaprint'),
  File "/nix/store/p780knsy1ck1bxamzjlsvfwx19bpd7cn-puddletag-2.2.0/lib/python3.10/site-packages/puddlestuff/about.py", line 50, in get_module_version
    module = import_module(module_name)
  File "/nix/store/abax98471z8fshv4b9p46bkh3lxmpy0z-python3-3.10.9/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/nix/store/hn3l9hgbh202vs0h3mi993zv0k6l1bbh-python3.10-pyacoustid-1.2.2/lib/python3.10/site-packages/chromaprint.py", line 57, in <module>
    raise ImportError("couldn't find libchromaprint")
ImportError: couldn't find libchromaprint
zsh: IOT instruction (core dumped)  ./result/bin/puddletag

I'm not sure how to go about fixing it, though.


DSWx-NI PGE Engineering Release v3.0

Ticket to track creation of Engineering Release v3.0 for the DSWx-NI PGE. This release will incorporate the "beta" delivery of the corresponding SAS.
Creation of the release should consist of the following steps:

[x] Once beta integration branch is merged to main, create the release/4.0.0-er.3.0 branch within working repository off of it
[x] Within the release branch, update the following version numbers:
In src/opera/_package.py update "repository" version to 4.0.0-er.3.0 (dswx_ni_pge.py will inherit this version update by default)
Rename examples/dswx_ni_sample_runconfig-v4.0.0-er.2.0.yaml to examples/dswx_ni_sample_runconfig-v4.0.0-er.3.0.yaml and also update the version referenced in the comment at the top of the file contents.
[x] Push the branch to origin, then execute the integration test for DSWx-NI within Jenkins Int Test pipeline. Inspect the results of the .html product comparison report to ensure test is passing.
[x] Run the Release pipeline in Jenkins to push the container images to Artifactory. For this release, ensure the "Publish Docs" option is selected.
[x] Create a PR for the release branch. If there have been no major changes to the code (aside from version number updates), the branch can be merged immediately without review.
[x] Pull the merged branch back into local main, then tag the latest commit as 4.0.0-er.3.0 and push the tag to origin
[x] Create the github release page using the new tag.
[x] Update the ICS document for the new release, and upload to Artifactory, along with the latest example RunConfig (to be completed by @collinss-jpl)

Release here: https://github.com/nasa/opera-sds-pge/releases/tag/4.0.0-er.3.0


Buffer file-based BIO reads on Windows

This is a follow up to my previous PR and discussion to resolve a performance issue due to openssl disabling buffered reads for file-based BIOs in text mode on Windows. This PR reverts the commit that disabled buffering and modifies the file-based BIO to read PEM files in binary mode, since the PEM parser already handles CRLF correctly.
This resolves the immediate issue I was seeing, but I did have some questions for reviewers:

Should I be special casing OPENSSL_SYS_VMS as is done in https://github.com/openssl/openssl/blob/6bb62ab82682b9e19d594eb8fd52a5a560ba65f3/crypto/conf/conf_def.c#L172-L176
Do these other other call sites need to be modified?

$ git grep BIO_new_file | grep -E '("r"|"w")' | grep -vE '^demos' | grep -vE '^test' | grep -vE '^apps'
crypto/conf/conf_def.c:    in = BIO_new_file(name, "r");
crypto/conf/conf_def.c:                next = BIO_new_file(include_path, "r");
crypto/conf/conf_def.c:    next = BIO_new_file(include, "r");
crypto/conf/conf_def.c:            bio = BIO_new_file(newpath, "r");
crypto/conf/conf_lib.c:    in = BIO_new_file(file, "r");
crypto/engine/eng_openssl.c:    in = BIO_new_file(key_id, "r");
crypto/ts/ts_conf.c:    if ((cert = BIO_new_file(file, "r")) == NULL)
crypto/ts/ts_conf.c:    if ((certs = BIO_new_file(file, "r")) == NULL)
crypto/ts/ts_conf.c:    if ((key = BIO_new_file(file, "r")) == NULL)
crypto/x509/v3_pci.c:            BIO *b = BIO_new_file(valp, "r");
doc/man3/BIO_s_file.pod: out = BIO_new_file("filename.txt", "w");
engines/e_ossltest.c:    in = BIO_new_file(key_id, "r");

I wasn't sure whether tests are needed or where best to add it, though I manually verified Windows now reads cert.pem using a 4k buffer.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

The check-style check fails when running against master and seems unrelated to this PR
$ git rev-parse HEAD
5f3fefe2f3b1103299eda85831908508d8bb2114
$ util/check-format.pl crypto/bio/bss_file.c
crypto/bio/bss_file.c:71:'#if' nesting indent = 0 != 1:#ifdef ENXIO
crypto/bio/bss_file.c:73:'#if' nesting indent = 0 != 1:#endif
crypto/bio/bss_file.c:212:missing space before '!=':# if BIO_FLAGS_UPLINK_INTERNAL!=0
crypto/bio/bss_file.c:212:missing space after '=':# if BIO_FLAGS_UPLINK_INTERNAL!=0
crypto/bio/bss_file.c:217:missing space before '>=':#  if (defined(_MSC_VER) && _MSC_VER>=1900) || defined(__BORLANDC__)
crypto/bio/bss_file.c:217:missing space after '=':#  if (defined(_MSC_VER) && _MSC_VER>=1900) || defined(__BORLANDC__)
crypto/bio/bss_file.c:231:indent = 8 != 12 for hanging stmt/expr:        {
crypto/bio/bss_file.c:233:indent = 12 != 16 for stmt/decl:            int fd = _fileno((FILE *)ptr);
crypto/bio/bss_file.c:234:indent = 12 != 16 for stmt/decl:            if (num & BIO_FP_TEXT)
crypto/bio/bss_file.c:234:missing blank line after local decls:
            int fd = _fileno((FILE *)ptr);
            if (num & BIO_FP_TEXT)
crypto/bio/bss_file.c:235:indent = 16 != 20 for hanging stmt/expr:                _setmode(fd, _O_TEXT);
crypto/bio/bss_file.c:236:indent = 12 != 16 for stmt/decl:            else
crypto/bio/bss_file.c:237:indent = 16 != 20 for hanging stmt/expr:                _setmode(fd, _O_BINARY);
crypto/bio/bss_file.c:241:line length = 136 > 100:             * https://developercommunity.visualstudio.com/content/problem/425878/fseek-ftell-fail-in-text-mode-for-unix-style-text.html
crypto/bio/bss_file.c:245:indent = 12 != 16 for stmt/decl:            if ((num & BIO_FP_TEXT) != 0)
crypto/bio/bss_file.c:246:indent = 16 != 20 for hanging stmt/expr:                setvbuf((FILE *)ptr, NULL, _IONBF, 0);
crypto/bio/bss_file.c:248:indent = 12 != 16 for stmt/decl:            int fd = fileno((FILE *)ptr);
crypto/bio/bss_file.c:250:indent = 12 != 16 for stmt/decl:            if (num & BIO_FP_TEXT)
crypto/bio/bss_file.c:251:indent = 16 != 20 for hanging stmt/expr:                _setmode(fd, _O_TEXT);
crypto/bio/bss_file.c:253:indent = 12 != 16 for stmt/decl:            else {
crypto/bio/bss_file.c:253:missing '}' on same line before 'else ... {':            else {
crypto/bio/bss_file.c:254:indent = 16 != 20 for stmt/decl:                if (fd == STDIN_FILENO || fd == STDOUT_FILENO) {
crypto/bio/bss_file.c:255:indent = 20 != 24 for stmt/decl:                    if (isatty(fd) <= 0)
crypto/bio/bss_file.c:256:indent = 24 != 28 for hanging stmt/expr:                        _setmode(fd, _O_BINARY);
crypto/bio/bss_file.c:257:indent = 16 != 20 for stmt/decl:                } else
crypto/bio/bss_file.c:257:missing '{' on same line after '} else':                } else
crypto/bio/bss_file.c:258:indent = 20 != 24 for hanging stmt/expr:                    _setmode(fd, _O_BINARY);
crypto/bio/bss_file.c:259:indent = 12 != 16 for stmt/decl:            }
crypto/bio/bss_file.c:261:indent = 12 != 16 for stmt/decl:            int fd = fileno((FILE *)ptr);
crypto/bio/bss_file.c:262:indent = 12 != 16 for stmt/decl:            if (!(num & BIO_FP_TEXT))
crypto/bio/bss_file.c:263:indent = 16 != 20 for hanging stmt/expr:                setmode(fd, O_BINARY);
crypto/bio/bss_file.c:265:indent = 8 != 12 for stmt/decl:        }
crypto/bio/bss_file.c:275:missing '{' on same line after '} else':        } else if ((num & BIO_FP_READ) && (num & BIO_FP_WRITE))
crypto/bio/bss_file.c:281:missing '}' on same line before 'else ... {':        else {
crypto/bio/bss_file.c:324:indent = 16 != 12 for hanging stmt/expr:                ? UP_fflush(b->ptr) : fflush((FILE *)b->ptr);
35 (0 indentation, 2 '#if' nesting indent, 0 syntax, 5 whitespace, 1 length, 27 other) issues have been found by util/check-format.pl

crypto/ts/ts_conf.c:    if ((cert = BIO_new_file(file, "r")) == NULL)
crypto/ts/ts_conf.c:    if ((certs = BIO_new_file(file, "r")) == NULL)
crypto/ts/ts_conf.c:    if ((key = BIO_new_file(file, "r")) == NULL)

I believe at least these should be modified as they work with keys and certs.

I believe at least these should be modified as they work with keys and certs.

Updated, and crypto/engine/eng_openssl.c too, since it immediate calls PEM_read_bio_PrivateKey on the BIO.

@levitte Does VMS nowadays support (ignore) the binary flag or does it need special handling to avoid it?

I don't understand why PEM files should be treated as binary, anywhere. Can't the buffering issue be handled separately?

@levitte opening PEM files in binary mode was suggested by @davidben in https://github.com/openssl/openssl/pull/24249#issuecomment-2192025429

The two changes are orthogonal in that treating it as binary mode is not necessary to fix the regression. Simply reverting the fix is fine.
That said, I do think PEM (and indeed most things) should be opened in binary mode. It's weird for the same PEM bytes to be interpreted or serialized in different ways across Windows and non-Windows. Also, practically speaking, the PEM parser already tolerates CRLF, so both will be accepted anyway. (And if they're not, better that the behavior is the same so that there's only one flavor of thing to test.)

On record oriented file systems, like on VMS, using binary mode to read text files (which PEM files are) is often detrimental.
On VMS with the default text file record format, a text file line is a record, starting with a length, followed by the line text itself, and possibly some padding. When treated as a text file, the C library will convert those records to lines as C programs understand them (adding \n at the end). When treated as a binary file, the C library (as I recall it) will simply read file blocks (not records) and leave it to the calling program to deal as they see fit... Usually with no LF or CRLF in sight.
This is my recollection from having had to deal with this, years ago. I haven't verified this lately, but in the end, I still think it's conceptually wrong to treat a text file as binary, no matter what trickery the PEM library has up its sleave to compensate.

Could we just open the files in binary mode on Windows? Or at least not use the binary mode on VMS?

I would accept always treating the files on Windows in binary mode, since the impact is "only" that CRLF<=>LF converstion won't take place.
So an idea is to replace this PR with the following:
diff --git a/crypto/bio/bss_file.c b/crypto/bio/bss_file.c
index 05d87cfe90..65c6276e18 100644
--- a/crypto/bio/bss_file.c
+++ b/crypto/bio/bss_file.c
@@ -231,19 +231,18 @@ static long file_ctrl(BIO *b, int cmd, long num, void *ptr)
         {
 # if defined(OPENSSL_SYS_WINDOWS)
             int fd = _fileno((FILE *)ptr);
-            if (num & BIO_FP_TEXT)
-                _setmode(fd, _O_TEXT);
-            else
-                _setmode(fd, _O_BINARY);
             /*
              * Reports show that ftell() isn't trustable in text mode.
              * This has been confirmed as a bug in the Universal C RTL, see
              * https://developercommunity.visualstudio.com/content/problem/425878/fseek-ftell-fail-in-text-mode-for-unix-style-text.html
              * The suggested work-around from Microsoft engineering is to
-             * turn off buffering until the bug is resolved.
+             * turn off buffering until the bug is resolved.  However, this
+             * has a performance cost, so another option is to always treat
+             * the files in binary mode.  Since the main difference is that
+             * CRLF line endings will be visible, and those are usually
+             * accounted for elsewhere anyway, the impact should be minimal.
              */
-            if ((num & BIO_FP_TEXT) != 0)
-                setvbuf((FILE *)ptr, NULL, _IONBF, 0);
+            _setmode(fd, _O_BINARY);
 # elif defined(OPENSSL_SYS_MSDOS)
             int fd = fileno((FILE *)ptr);
             /* Set correct text/binary mode */

That proposal seems problematic for non-PEM callers that were using BIO_FP_TEXT because they actually wanted the CRLF translation. The observation is that PEM doesn't need the translation, not that no one needs it.

На 5.11.24 г. в 13:49 ч., David Benjamin написа:

That proposal seems problematic for non-PEM callers that were using BIO_FP_TEXT because they actually wanted the CRLF translation. The observation is that PEM doesn't need the translation, not that no one needs it.

Some internet protocols are text based with CRLF as EOL. Some
implementations may refuse communication if only LF is used as EOL.
Instead to implement explicit CRLF as EOL OpenSSL utilities (smime?) use
extra command arguments as work-around.
Because of historic behaviour changes is BIO interface should be
reviewed in details.
Regards,
Roumen

Okie, I hear and acknowledge your points.
Since this is, in the end, a workaround for a workaround of a Windows bug (as shown in the comment), I think that the sanest thing is to go with this proposal (@t8m):

Could we just open the files in binary mode on Windows?

@joshcooper Could you please adjust the PR so the binary flag is used just on Windows?

This can go into the master branch just fine.
However a question for OTC is: Do you agree with backporting this to all stable branches as it fixes a serious performance regression when loading PEM files on Windows?

Typo: cert->certs

Gah, sorry, I've updated both of those.

However a question for OTC is: Do you agree with backporting this to all stable branches as it fixes a serious performance regression when loading PEM files on Windows?

Yes I agree it would be desirable to backport. Do you need me to create pull requests for each stable branch? Or do you have automation to backport?

Yes I agree it would be desirable to backport. Do you need me to create pull requests for each stable branch? Or do you have automation to backport?

I would not call it automation but if the commits cherry-pick cleanly to the older branches, the person who merges the PR will cherry pick it during the merge.

OTC: This is OK to go into the 3.4 branch.

ping @openssl/committers for second review.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago


feat: 🎸 update team headshots

What does this PR do
This PR updates Bolaji and Perrie's headshots on the team page.
What are the relevant issues this PR belongs to
#35

But till then, you can approve this @Princesso as further changes would come in a later PR when @perriefidelis provides the images.

@perriefidelis here:
https://photos.app.goo.gl/13v1pxKFnfCXjS5e7

For records;
Active(https://www.figma.com/file/dDQ0f43gracsqn1LJYk91E/New-OSCA-website?node-id=4370%3A8437&t=hfpDh1Y8rqVBqrEi-1)
Inactive(https://www.figma.com/file/dDQ0f43gracsqn1LJYk91E/New-OSCA-website?node-id=4370%3A8438&t=AfRDTtbr9krBFq0I-1)


[BUG] deepflow-server Database flow_tag doesn't exist and migrate mysql failed

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

DeepFlow Component
Server
What you expected to happen
I just did a new install of deepflow 6.4.0 and deepflow-server is not coming up. Already try to delete delete and recreate de pod, same error.

The deepflow databases were not created

How to reproduce
Install deepflow 6.4.0
DeepFlow version
Defaulted container "deepflow-agent" out of: deepflow-agent, configure-sysctl (init)
9073-b9a9d1faee54524f60b33a5cb231373b4f8fa8e9
Name: deepflow-agent community edition
Branch: v6.4.0
CommitId: b9a9d1faee54524f60b33a5cb231373b4f8fa8e9
RevCount: 9073
Compiler: rustc 1.73.0 (cc66ad468 2023-10-03)
CompileTime: 2023-10-13 02:36:18

DeepFlow agent list
No response
Kubernetes CNI
No response
Operation-System/Kernel version
No response
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://github.com/deepflowio/deepflow/issues/544#issuecomment-1207846716
You can refer to this issue, which is generally caused by the performance problem of mysql. You can first enter the database of mysql drop deepflow, and then increase the number of server failureThreshold

I installed with the setting used on another issue and it installed.
--set server.readinessProbe.failureThreshold=135 --set server.livenessProbe.failureThreshold=135


Last update b7278ff...35c6b94


'basestring' is not defined error for python3

When I tried print png file on terminal with width parameter, error occurs:
NameError: name 'basestring' is not defined
"basestring" not available in python3.
This issue can be fix with <basestring = str> change.
ref: https://stackoverflow.com/questions/34803467/unexpected-exception-name-basestring-is-not-defined-when-invoking-ansible2

I think if you do it that way, support for versions 2.x will be removed

@arielb2 according to my tests it still works with 2.x versions.
Here is my simple code:
# -*- coding: utf-8 -*-
from fabulous import image

print(image.Image("media/steve.png", width=40))

and here is my screenshots with 2.x and 3.x version of python

@arielb2 If you are right, I wonder why doesn't work with 2.x versions, I'm newbie at python.

I believe this was fixed in #19. I'll be pushing a release soon. Thanks everyone!


how to change input to chinese

can you tell me how to change input to chinese ?   thanks a lot

Hi there!
Currently, there's no settings in the UI to change the language but if you're running it locally you can set the language of the speech synthesis and recognition systems here and here. You should be able to set these to zh-CN assuming your browser supports this (you can check by opening up a console and running window.speechSynthesis.getVoices()).
I'm not sure how well gpt-3.5-turbo does on Chinese however, so that may be a different story.


Question regarding BatchNorm1dNoBias

Hi
thanks for your nice job. Can you possibly explain what is the use of adding BatchNorm1dNoBias after the laster linear layer of the projection head (https://github.com/AndrewAtanov/simclr-pytorch/blob/master/models/encoder.py#L40)

Hi Nima,
Thanks for the interest. I cannot recall where the reference for that is, or maybe I'm confused, and there is no such. BN w/o bias term is also used in the official implementation [1], and, I guess, this is where I found this.
My intuition is as follows: in the contrastive NT-Xent loss, the cosine similarity is used, so image embeddings are treated as centered at 0. The bias term will break this assumption and also add the additive term in the embeddings interaction (the dot-product becomes: x^Ty + (x+y)^Tb + b^Tb). I'm not sure, though, how important this detail is for pretraining, it doesn't seem like a hard constraint from the theoretical point of view. If I recall correctly, there were issues when pretraining w/ the bias term in practice.
[1] https://github.com/google-research/simclr/blob/dec99a81a4ceccb0a5a893afecbc2ee18f1d76c3/model_util.py#L141

Andrew, thanks a lot for your reply.  I can understand why to set bias=Flase and your intuition completely make sense for me. but my question is why use a BN as the last layer instead of a linear layer? isn't that the cosine similarity does the centering and makes a uni hypersphere latent space?

Oh, I see. I think this is in part to avoid feature collapsing when all the vectors are pointing almost in the same direction. This effect is studied here [1], for example.
[1] https://generallyintelligent.ai/understanding-self-supervised-contrastive-learning.html

thanks. that was helpful


Circuit Break Hibernate L2 cache, if redis is unreachable.

Expected behavior
Redis server becomes unavailable, usage of L2 cache should be bypassed and the application should continue to run.
Actual behavior
The whole application goes down, Hibernate can't function. Keep getting connection timeouts.
We have to manually turn off L2 in app config and redeploy the application, this could be prevented by using a circuit breaker.
Steps to reproduce
While the application is running, kill the redis server.
Redis version
5.0.5
Redisson version
3.11.1, artifact : redisson-hibernate-53
Redisson configuration
Default Replicated Servers Config

Implemented in https://github.com/redisson/redisson/issues/1800


Work plan

@ejmaginn @drroe
Happy holidays! I think we should make a work plan for when/what/how much each of us is going to contribute. For example, I am going to start working on this manuscript again. Specifically, I am going to bulk up the Green-Kubo and Einstein discussion for viscosity. I will have this completed by the end of the calendar year. After I have finished my changes it would be someone else's turn to look over the document and see what portion they think is lacking. Does that sound reasonable?

Richard,
That sounds like a good plan. I also added Richard as a collaborator. I can take a crack at this when you are finished.
Let me know if you receive this email as I am unsure if this list works.
Ed
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn

On Dec 20, 2017, at 10:37 AM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn @drroe https://github.com/drroe
Happy holidays! I think we should make a work plan for when/what/how much each of us is going to contribute. For example, I am going to start working on this manuscript again. Specifically, I am going to bulk up the Green-Kubo and Einstein discussion for viscosity. I will have this completed by the end of the calendar year. After I have finished my changes it would be someone else's turn to look over the document and see what portion they think is lacking. Does that sound reasonable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXeKzxXLQb6dzsvEIM454i1anydZ5ks5tCSmngaJpZM4RIkIk.

@ejmaginn
I did receive the email. OK, I will let you know when I am satisfied with what I have. I also think it would be good to have a video call to regroup since it has been a while.

Apologies for the delay, I've been traveling. I will look over the update document ASAP.

@drroe
OK, great. I will finish my changes by the end of the day. I think it will be easiest if we are not all making changes simultaneously. Although GitHub can keep track of our changes, I think taking turns will avoid merge conflicts that might be prevalent when making significant changes.
So after I finish today, who wants to be next? @ejmaginn @drroe @jrelliottoh?

@ejmaginn @drroe @jrelliottoh
I have finished my changes. Whoever wants to pick it up next, post a comment here.
Note that I have focused primarily on the content and not as much on the layout. We will probably want to discuss the sectioning and the overall flow of the document once we are satisfied with the content.

I can start in earnest Tuesday of next week - I am traveling and have a proposal I am trying to finish this week. So if someone can step in now that would be great. Otherwise, I will start on this Tuesday Jan 2.
Ed
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn

On Dec 28, 2017, at 3:26 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn @drroe https://github.com/drroe @jrelliottoh https://github.com/jrelliottoh
I have finished my changes. Whoever wants to pick it up next, post a comment here.
Note that I have focused primarily on the content and not as much on the layout. We will probably want to discuss the sectioning and the overall flow of the document once we are satisfied with the content.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/2#issuecomment-354353090, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXWOsz8pFYaXWRPxAyhFtRW8KoS2cks5tE_l6gaJpZM4RIkIk.

@ejmaginn  @drroe @jrelliottoh @dcarls0n
Since the school year should be ending in a few weeks, I thought we should try to pick this back up. I know that one other group is about to submit their best practices to LiveComs, so we should probably try to have something done in a month or so.
We had talked about having a system where we take turns looking at the document. From the best I can tell, @ejmaginn and @jrelliottoh were going to review the article on January 2nd and 4th, respectively. But it doesn't look like any changes were made. Did you have some edits/comments? Who would be willing to look at the document in the coming week or so?

Richard,
Thanks. Please tell me when you are finished and I am happy to take the next crack at it. Just finished my proposal today!
Ed
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 14, 2018, at 5:19 PM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn @dcarls0n https://github.com/dcarls0n
I have created a new LaTex file where I am making significant changes to the document structure. I am trying to improve its readability and usefulness. I should have it ready by Tuesday. @dcarls0n https://github.com/dcarls0n I would still like to hear your review of the original manuscript. I think the format will be the main talking point for our meeting. What day and time this upcoming week could we have a video conference?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/2#issuecomment-381361185, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXfXdopeXQ4v4YWBYIs_UYBJoowwoks5tomfXgaJpZM4RIkIk.

@ejmaginn
Alright, I will let you know when I finish. I do think a brief video call sometime this week would be helpful even if it is before you start working on it. Let me know what you think.

Good idea. I am free Tuesday afternoon from 2-5 pm EDT. I don’t have much other time during business hours the rest of the week (!) but could talk outside business hours if we want. Thursday evening April 19 is best for me.
Ed
Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 16, 2018, at 9:43 AM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
Alright, I will let you know when I finish. I do think a brief video call sometime this week would be helpful even if it is before you start working on it. Let me know what you think.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/2#issuecomment-381602795, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXbJrCjk29yfutdKbVsH-Am1eo_Roks5tpJ_7gaJpZM4RIkIk.

@ejmaginn
Alright, @dcarls0n said that he has a meeting at 3 EDT, and I have a meeting at 4 EDT, so 2 EDT would work best for us tomorrow. I do not think it will take more than 30-45 minutes. Would google hangouts work for you? If so, what email should I send the link to?

OK - I have sometimes had trouble with this but you can try<EMAIL_ADDRESS><EMAIL_ADDRESS>- this should work. If not, try my gmail account<EMAIL_ADDRESS><EMAIL_ADDRESS>Edward Maginn
Dorini Family Professor and Department Chair
Department of Chemical and Biomolecular Engineering
University of Notre Dame
Notre Dame, IN 46556 USA
cbe.nd.edu
<EMAIL_ADDRESS>@ejmaginn
view my papers: https://goo.gl/kgMMBe

On Apr 16, 2018, at 11:58 AM, Richard Messerly<EMAIL_ADDRESS>wrote:
@ejmaginn https://github.com/ejmaginn
Alright, @dcarls0n https://github.com/dcarls0n said that he has a meeting at 3 EDT, and I have a meeting at 4 EDT, so 2 EDT would work best for us tomorrow. I do not think it will take more than 30-45 minutes. Would google hangouts work for you? If so, what email should I send the link to?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ejmaginn/TransportCheckList/issues/2#issuecomment-381656055, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKiXYd2CAmhiWlfrO6rNKXYqT-CRZShks5tpL-ygaJpZM4RIkIk.

@ejmaginn  @dcarls0n
OK, I will send the link a few minutes before our meeting time (tomorrow at 12 MT/2 ET).

@ejmaginn @dcarls0n
Alright, EMD_diffusivity_viscosity_restructured now contains all of my modifications. I think this structure is a lot better, but we should discuss this tomorrow. If you could take a quick glance before tomorrow to compare the old and new manuscript formats that would be helpful.

@ejmaginn @dcarls0n
Here is the link:
https://hangouts.google.com/call/V12I-HqQ1cN7EXJz_stmAAEE


Rus localization fix

One damn letter fix

Found one more xD

Also you can keep adding commits to your branch without closing the PR first

Also you can keep adding commits to your branch without closing the PR first

I know, I decided to close because I realized that I need to test with people it first.


Unable to lock on the pidfile

Everything ran fine on my old MacOS 11.3, but somehow I decided to update to 12.3.1 Monterey... What a terrible mistake. Now when running
Inkscape-figures watch
for the first time as part of my ~/.zprofile, an error occurs: "Unable to lock on the pidfile." Subsequently cmd+s in Inkscape will no longer save properly.
However, when running with the Inkscape-figures watch --no-daemon option, there is no such error.
A temporary solution to this issue appears to be: in a separate terminal, run Inkscape-figures watch --no-daemon every time you need it to work.
Is there a better fix?

I have the similar problem. But in my case,  if  I just input "inkscape-figures watch" in my terminal  , it works well.  When I want to stop the process, if I input "killall inkscape-figures", it will say "No matching processes belonging to you were found".   If I input "killall fswatch"(since my system version is  macos 12.6, main.py uses fswatch. ) , it will stop smoothly.  However, after that if I input "inkscape-figures  watch" again, it will say "Unable to lock on the pidfile."
I don't know why it can't work in this situation.    Is there any help?


Added string SimVars

Added client data area for string SimVars
Added separate StringSimVars list
Register on string SimVars
Assume that a string shall be used when RPN-Code contains "String"

Handling as discussed with @DocMoebiuz
In conjunction with https://github.com/MobiFlight/MobiFlight-WASM-Module/pull/19

First test: works. This is super cool.

I gave this a few tests and I noticed a lot of the modifiers do not really handle strings in a consistent manner, should I file bugs about each issue I found or what would be the best way to coordinate the changes needed?

Thank you very much.
I understand why you did the changes to GetSimVar and RegisterSimVar and how they return a type now and not the value anymore, and you pass in the out-parameters instead.
Tbh, I don't like it so much but it works for now. I will merge the PR and we can test it with people and if you like we can make some code improvements later.

With this approach I tried to keep changes in ExecutionManager.cs minimal, but yes it probably isn't the most beautiful solution. I would be happy about a discussion about possible improvements :)


jsonDecode(data.body) returns Map instead of List for single json object

Background:
For example:
This demo endpoint "https://api.nasa.gov/planetary/apod?api_key=DEMO_KEY" return a SINGLE json object
Limitation:
while parsing above json jsonDecode(data.body) returns a Map (for single json object). I need to check type then encapsulate map to list then proceed ahead.
Desired:
Adding a Map to a List is okay. But a List is desired here by default by jsonDecode()
Question:
Can we get an optional List object for Single Json Object with a single flag to decode method?

I think decoding a Map is one of the most common use cases for jsonDecode. Adding a flag to the method for behavior that can be handled by the caller would add more complexity that it is worth, especially when the vast majority of users expect the current behavior.
jsonDecode will return whichever type is represented by the string you passed. jsonDecode('{}') will return a Map, jsonDecode('[]') a List, jsonDecode('""') a String, and jsonDecode('1') a number.
I'd recommend either doing the type check afterwards, or wrapping the string with [ and ] if you specifically want the jsonDecode call to produce the List.


Remove extra Scenarios from ScenarioSimulator

Scenario's to be removed

EventsWithNoHandler
MalformedEvents
LongRunningEvents

These scenarios are defined in  src/Implementation/Simulator/ScenarioSimulator/SimulationScenarios.cs

Connected to #75


Need more helpful error message in cases when  IMAGE|DIRECTORY or appname is missing.

Server version - acorn version v0.6.0-132-gdc73d55a+dc73d55a
Steps to reproduce the problem:
 acorn run --update
  ✗  ERROR:  resource name may not be empty

% acorn run --replace
  ✗  ERROR:  resource name may not be empty
sangeethahariharan@Sangeethas-MBP example1 %

acorn run works like acorn run . but that is not the case with  acorn run --update and acorn run --replace.  Why?
In the above cases , a more  helpful error message to indicate that user needs to provide  IMAGE|DIRECTORY if wanting to create a new app or "-n= if they want to update existing apps.

@sangee2004  this was resolved somewhat by #1445 in that now acorn run --update defaults to behavior of acorn run so err message should no longer be displayed. moving to QA to confirm this

Tested with acorn version v0.6.0-136-gc2c4989d+c2c4989d
acorn run --update and acorn run --replace results in new app being created.


User should be able to edit the size of text

Hello. I would like to take up this issue. Can you explain how exactly you want the changes to function?

Thanks for reaching out Additya,
you can use this website for reference -> https://imgflip.com/memegenerator.
Don't take it as me asking for a complete replica, but just a base point on how it should function >_<

So do you just want me to add 2 buttons that let you increase/decrease text size?

I have implemented the feature for setting text size in pixels. You can go through it in the following commit :)

Heya. Could you please take a look at my PR? Thanks ^_^

This PR has introduced a new bug where the text is only draggable if the text is selected where it was originally before changing the resizing of text. It is now being tracked here #55


[IOS] This database needs to run with SQLCipher, but that library is not available

Describe the bug
I have setup encrypted drift database with packages below. I cannot go higher version because of web dependency issues with other packages.
 drift: ^2.18.0
  sqlcipher_flutter_libs: ^0.6.0
  # drift_flutter: ^0.2.0
  # TODO: Update below when web is updated
  sqlite3:

I am using below to setup SQL Cipher
Future<void> setupSqlCipher() async {
  try {
    await applyWorkaroundToOpenSqlCipherOnOldAndroidVersions();
  } catch (e) {
    if (kDebugMode) {
      print('Error applying workaround for old Android versions: $e');
    }
    rethrow; // Re-throw to ensure the caller is aware of the error
  }

  try {
    open
      ..overrideFor(OperatingSystem.android, openCipherOnAndroid)
      ..overrideFor(
          OperatingSystem.linux, () => DynamicLibrary.open('libsqlcipher.so'))
      ..overrideFor(
          OperatingSystem.windows, () => DynamicLibrary.open('sqlcipher.dll'));
  } catch (e) {
    if (kDebugMode) {
      print('Error during SQLCipher setup: $e');
    }
    rethrow; // Re-throw to ensure the caller is aware of the error
  }
}

but am continually getting error as below in IOS emulator device. Document mentions no need to setup anything for iOS so am not sure what is missing here. Any help is appreciated. Android does not have this issue.

[ERROR:flutter/runtime/dart_isolate.cc(1315)] Unhandled exception:
Unsupported operation: This database needs to run with SQLCipher, but that library is not available!
#0      openAppDatabase.<anonymous closure>.<anonymous closure> (********/application/database/database.dart:217:15)
database.dart:217
#1      Sqlite3Delegate._initializeDatabase (package:drift/src/sqlite3/database.dart:105:13)
database.dart:105
#2      Sqlite3Delegate.open (package:drift/src/sqlite3/database.dart:82:9)
database.dart:82
#3      DelegatedDatabase.ensureOpen.<anonymous closure> (package:drift/src/runtime/executor/helpers/engines.dart:431:22)

Do you have a dependency on drift_flutter? That depends on sqlite3_flutter_libs, which is incompatible with sqlcipher_flutter_libs :(


Parquet-Avro does not support field removal

Parquet avro does not support removal of fields, when used with the new compatibility layer:
Given a parquet file written with parquet avro at v1 and the following schema:
record FooBar {
  long foo;
  string bar;
}

And the following configuration settings:
job.getConfiguration.setBoolean(AvroReadSupport.AVRO_COMPATIBILITY, false)
AvroParquetInputFormat.setAvroReadSchema(job, avroReaderSchema)

A job fails when trying to read it using schema version v2:
record FooBar {
  string bar;
}

With the error:
org.apache.parquet.io.InvalidRecordException: Parquet/Avro schema mismatch: Avro field 'foo' not found
	at org.apache.parquet.avro.AvroRecordConverter.getAvroField(AvroRecordConverter.java:159)

It looks like because it sees the field in the original version it assumes the new version must expect it, but this case just means that the field was removed. Avro schema resolution dictates that you just ignore this field, since it is not relevant in the new version.
Reporter: Thomas Omans
Note: This issue was originally created as PARQUET-465. Please see the migration documentation for further details.

Ryan Blue / @rdblue:
[~eggsby], thanks for the thoroughness! Have you tried using different schemas for the projection and read?
It looks like the read schema can handle renames, but the projection schema must use the same names as the underlying file (which we should definitely fix). What if you try with v5 for your read schema, but this write schema:
{ "type": "record",
  "name": "com.example.avro.compatibility.v5.CompatibilityTestRecord",
  "fields": [
    { "name": "notId", "type": "string" }
  ] }

Also, what do you think about adding these cases as tests? I'd love to verify this behavior and use your work to ensure that we don't have future regressions! We also need to improve this area and this is a great start for figuring out what to improve. I was just wondering what the cases are where you need different read and projection schemas on my way to work and this answers it.

Thomas Omans:
Ryan,
Thank you for the quick response.
Unfortunately, adding AvroParquetInputFormat.setRequestedProjection(avroReaderSchema) breaks other things.  Specifically you lose the ability to rename fields (lookups silently fail and put null into the field value) and apply default values.
I actually created a series of evolving schemas in order to see what was supported and what was not:
@namespace("com.example.avro.compatibility")
protocol Compatibility {

  // original record, only one field
  @namespace("com.example.avro.compatibility.v1")
  record CompatibilityTestRecord {
    long time;
  }

  // add new field with default value
  @namespace("com.example.avro.compatibility.v2")
  record CompatibilityTestRecord {
    long time;
    string id = "v2";
  }

  // reorder fields
  @namespace("com.example.avro.compatibility.v3")
  record CompatibilityTestRecord {
    string id = "v3";
    long time;
  }

  // alias field
  @namespace("com.example.avro.compatibility.v4")
  record CompatibilityTestRecord {
    string @aliases(["id"]) notId = "v4";
    long @aliases(["time"]) notTime;
  }

  // drop field
  @namespace("com.example.avro.compatibility.v5")
  record CompatibilityTestRecord {
    string @aliases(["notId"]) id = "v5";
  }

}

I wrote 5 parquet files each containing one record written at the specific version, then tried to read them in: v2 reading v1, v3 reading v2 and v1, etc.
Only setting setAvroReadSchema to the latest version of the schema causes all to pass besides the final case of dropping a field, but setting both read and projection causes all to fail due to defaults not being properly applied and aliases not being respected.
Thanks again, what is there is great – I have been reading your commits all day :)

Ryan Blue / @rdblue:
[~eggsby], sorry for the confusion here. Right now, parquet-avro has a strange way of doing things. There are two read-side schemas you should worry about. The one you're setting is the schema you expect records to conform to. So that allows you to set the defaults for missing fields. Then there is also the projection schema, which is used to actually do the column selection. So you could filter out foo with the projection schema and also have a default value for it added to your records using the read schema. I think these should be the same thing and we should derive the projection from the expected schema... I just haven't had time to build it yet (patches welcome!).
So here's what you should do to fix it: set the projection schema to your reader schema using AvroParquetInputFormat.setRequestedProjection. That should prevent the code from expecting foo.


Makefile Issues

make build-scala doesn't rerun if you change a source file. It needs to depend on .scala files.
At this point, the scala implementation should be default, so make build should probably be equivalent to make build-scala (the current make build could become make build-stanza and a new command could do the actual building of stanza)

Fixed 084e7ca9f9ecb76b91e143931d08195d45672ab7


Implement disulfide score term

WIP
Remade this branch from a fresh master because the squash merge of omega made things messy.

Unlike omega, this is an entirely new score term. Is there any additional work that needs to be done to hook this into everything? I did a grep for omega and it seemed like all other code using omega was using the old omega.

@fdimaio Shortening the disulfide params lead to a change of:
E       AssertionError:
E       Not equal to tolerance rtol=1e-05, atol=1e-05
E
E       Mismatched elements: 10 / 10 (100%)
E       Max absolute difference: 0.00015092
E       Max relative difference: 4.633452e-05
E        x: array([[-3.257311, -3.257311, -3.257311, -3.257311, -3.257311, -3.257311,
E               -3.257311, -3.257311, -3.257311, -3.257311]], dtype=float32)
E        y: array([[-3.25716, -3.25716, -3.25716, -3.25716, -3.25716, -3.25716,
E               -3.25716, -3.25716, -3.25716, -3.25716]], dtype=float32)

So pretty minimal. Does this look OK?

Great, I'll wait for the checks to pass and then merge if they check out.

I just changed the interface to the resolve_uaid function in the rama PR (#252) to take UAIDs as a struct instead of as a TensorAccessor. That doesn't affect this PR as far as I can tell. The dislufide_pose_score.impl.hh file does include uaid_util.hh, but doesn't invoke the functions it contains. It most certainly will affect the cart-bonded term, though, so I wanted to give you the head's up, @jflat06

I don't think this actually affects the cart-bonded term. Cart-bonded forgoes the UAID system because it needs access to non-mainline atoms coming from a connection. So part of the implementation was adding a 'paths starting from connection' data structure to each block type.


Create README_WINDOWS.md

Generated new instructions for the readme with docker and manual installation instructions.

Thanks for your work on this @johnsonkuang. Is there any reason why this isn't simply integrated into the main readme.md? IMO, there shouldn't be any reason why the Mac receives more emphasis or priority over Windows.
My suggestion would be to integrate this into the primary readme.md with appropriate sub-headers.

It's not a problem @jonfroehlich, the reason before was that there are quite a lot of differences between the mac and windows commands so we decided that it would be better to just give windows its own set of instructions for clarity purposes. But I can merge it into the main readme anyway.

Please make separate sections using sub-headers. So, for example, you have a header1 that is: "Setup Instructions Mac" and a header1 that is "Setup Instructions Windows" or something similar. Make sense?

Got it I will make the appropriate changes


Improve segmenter code

Maybe just remove the sentence "Smaller ... objects)".
On Mon, May 28, 2018 at 3:48 PM, Hossein Hadian<EMAIL_ADDRESS>wrote:

@hhadian commented on this pull request.
In egs/dsb2018/v1/local/segment.py
https://github.com/waldo-seg/waldo/pull/57#discussion_r191264550:

@@ -29,6 +30,14 @@
'train on (in order to form a fixed minibatch size).'
'These are derived from the input images'
' by padding and then random cropping.')
+parser.add_argument('--object-merge-factor', type=float, default=None,

               help='Scale for object merge scores in the segmentaion '

               'algorithm. Smaller values (factor < 1.0) will lead to fewer '

               'merges (more final objects). If not set, it will be set to '

Oh that's right. What would you suggest I write for its behaviour?
I guess I'll need to update the description for --same-different-bias too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/waldo-seg/waldo/pull/57#discussion_r191264550, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADJVu5qsWp4NbPiXjvSxr11Uwe-EeC5Yks5t3FSbgaJpZM4UQicI
.

@YiwenShaoStephen, how far are we from having a scoring setup for dsb2018 so we can have a metric to optimize?

@danpovey I can finish it by tonight. But I didn't write a scoring script myself. I'm writing the segmentation result in a format as the dsb2018 challenge requires. They haven't released the ground truth yet and we have to submit the result to see the final score. The submission can be done by command line.
Also, to get better intuition on the final results, the segmentation result on each image is stored separately with a visualization image and a run-length encoding result.


Value cannot be null. (Parameter 'path1') when rendering attachments

Both of these render perfectly in AzureDevOps, but the second will crash any attempt to export it to PDF with an error Value cannot be null. (Parameter 'path1') when rendering attachments using a windows-latest pipeline on Azure Dev Ops.
![image.png](/.attachments/image-30a0a101-2c35-474a-bbf4-a355524956a5.png)
![image.png](.attachments/image-30a0a101-2c35-474a-bbf4-a355524956a5.png)
The code throwing up is below. Note that it allows either format URL, but the one without the leading slash crashes. Easy for the wiki user to fix, but easier if you know what it is.
public void CorrectLinksAndImages(MarkdownObject document, FileInfo file, MarkdownFile mf)
        {
            Log("Correcting Links and Images", LogLevel.Information, 2);
            // walk the document node tree and replace relative image links
            // and relative links to markdown pages
...
                    //handle --attachments-path case
                     if (!string.IsNullOrEmpty(this._options.AttachmentsPath) && link.Url.StartsWith("/.attachments")
                       ||  link.Url.StartsWith(".attachments"))
                     {
                     ...
                            absPath = Path.GetFullPath(Path.Combine(this._options.AttachmentsPath, linkUrl));

thanks for reporting it - actually the code to handle this case is in there, but the if clause was not correctly combined...
if (
                            !string.IsNullOrEmpty(this._options.AttachmentsPath) &&
                            (link.Url.StartsWith("/.attachments") || link.Url.StartsWith(".attachments"))
   )

will be fixed in the next release and then both formats work.

I should have spotted that straight off... but then I always parenthesise that stuff ;-)
Thanks for a very handy tool, saved me a ton of work. I only had 2 links with the form which caused this, so by default almost everything worked fine.
Other stuff I noted (it may help someone else:

all headers must have a space after the hash
unclosed mark-up (eg underline) will pollute the rest of the file, so don't do it
tables must be preceded by a blank line to render correctly.

Tested across 269 pages, windows-latest etc.

Nice - thanks for sharing the feedback :)


CRC Composition

Tests CRC composition and adds a static helper class for composing values together.

API change check
API changes are not detected in this pull request.


Test

Signed-off-by: Stephanos Ioannidis<EMAIL_ADDRESS>

The following west manifest projects have been modified in this Pull Request:

Name
Old Revision
New Revision
Diff

hal_nordic
https://github.com/zephyrproject-rtos/hal_nordic/commit/1f9145e8c8359f103b4ac5085c6f5d2e66a2557d
https://github.com/zephyrproject-rtos/hal_nordic/pull/72
zephyrproject-rtos/hal_nordic#72/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.


[WIP] Fix for Tetrahedral Mesh Refinement [conforming-tet-refinement-fix]

Fixed the local refinement for tetrahedral meshes such that no degeneration occurs. I followed @v-dobrev 's suggestion in #512  and used the HashTable<Hashed2> object instead of a DSTable.
I redid the numerical experiments that led me to this issue and now their results are as expected.
For now the way NumOfVertices is updated is somewhat dirty. Maybe we can add another member variable to Mesh that contains the number of vertices of the unrefined mesh and update NumOfVertices as before.

I was doing some testing and the following sample run failed:
mpirun -np 4 ./ex15p -m ../data/escher.mesh -r 2 -tf 0.3 -no-vis

The same run on 1 and 2 processors seems to work fine.
The issue is probably in the way refinements are exchanged between neighbour processors. In particular, the method
https://github.com/mfem/mfem/blob/abd5c313d9d49c8b7894fd9c323430adae7bc4aa/mesh/pmesh.hpp#L67
does not support arbitrary refinements and that is probably causing the failure.
Any ideas about resolving this in a simple way?

Maybe one could not only check the face itself but also the newly generated faces if they are again split and then if they are split and so on. However I I'm not sure if this is really feasible and how to communicate this.
Do we have any upper bound on how often a face can be split?

I don't know if this helps but when I force bisection instead of octasection by changing
marked_elements.Append(Refinement(el));

to
marked_elements.Append(Refinement(el,1));

in mesh_operators.cpp the example works fine again.

I do not know if there is an upper bound on the number of face splittings.

The issue with the sample run
mpirun -np 4 ./ex15p -m ../data/escher.mesh -r 2 -tf 0.3 -no-vis

is fixed now.

I think I fixed the issue. Thanks for catching that - it was a serious bug.

I think I fixed the issue. Thanks for catching that - it was a serious bug.

I think I fixed the issue. Thanks for catching that - it was a serious bug.

@jakubcerveny can you take a look at this PR?

I don't understand the algorithm precisely, but the changes seem OK. I tried ex6p on the Escher mesh. It works and the refinements even look a little more reasonable (fewer refinements in the center of the domain, but it can be a coincidence).

Nice work @aschaf!

Thank you for the contribution @aschaf, very nice work!


Look for references in repositoryPath specified in NuGet.config file

This should fix issue 14 and issue 27.

Thanks for the PR. Is this one ready to merge?

Yes it is ready.

Hi @RSuter - have you had time to look at the PR - any comments?

Looks good. Thank you. My main problem is, that I could not upload a new VSIX version to the VS gallery - somehow it is broken and I havent heard back from Microsoft how to solve this...


Undefined Variable in toSelect()

🐛 Bug Report
When trying to use toSelect(), I am getting the following error:
ReferenceError: page is not defined
To Reproduce

Using version 4.3.0 from npm, install the expect-puppeteer package.
Call expect({instance}).toSelect({selector to a select}, {some value}) and you should get the error.

Expected behavior
The toSelect matcher function should work as described in the documentation.
Link to repl or repo (highly encouraged)
I cloned and built the current repo on my machine, and it looks like the code downloaded from npm differs from the repo in the following way. When I replace my project's package code with the one that I cloned and built then it works.
Left Side: Clone and build
Right Side: From npm

var _utils = require("../utils");
const {
page
} = await (0, _utils.getContext)(instance, () => document);
Run npx envinfo --system --binaries --npmPackages expect-puppeteer,jest-dev-server,jest-environment-puppeteer,jest-puppeteer,spawnd --markdown --clipboard
System:

OS: Windows 10
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 6.76 GB / 15.85 GB

Binaries:

Node: 10.16.3 - C:\Program Files\nodejs\node.EXE
Yarn: 1.19.1 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Program Files\nodejs\npm.CMD

Oh ooops looks like this was fixed after the latest release


Status REFUND on notification call

Hi there,
I'm getting the following output on a notification call:
I, [2015-07-23T11:11:29.347394 #11345]  INFO -- : Started POST "/adyen/notify" for xx.xx.xx.xx at 2015-07-23 11:11:29 +0200
I, [2015-07-23T11:11:29.348954 #11345]  INFO -- : Processing by Spree::AdyenNotificationsController#notify as HTML
I, [2015-07-23T11:11:29.349071 #11345]  INFO -- :   Parameters: {"pspReference"=>"14143712321496", "eventDate"=>"2015-07-23T09:11:28.71Z", "merchantAccountCode"=>"myCustomer", "reason"=>"", "originalReference"=>"", "value"=>"21", "eventCode"=>"AUTHORISATION", "merchantReference"=>"R069063981", "operations"=>"REFUND", "success"=>"true", "paymentMethod"=>"ideal", "currency"=>"EUR", "live"=>"true"}
As you can see i'm getting a REFUND on the operations variable. The notification is not coming through and does not update the order. Also my payment_state remains on 'balance due'.
Can you help us out?

BTW: i have Auto-capture ON in my settings.

Hi @paulhuisman , operations field is the available operations after the current event. Event is "AUTHORISATION" and you have now available the operations "REFUND". More details here: https://docs.adyen.com/display/TD/Notification+fields
I believe this means the auto-capture is working. Otherwise the operations will be "CANCEL,CAPTURE,REFUND".
Not sure why you see 'balance due' though.

Hi @paulo-surfdome ,
Thanks for your swift response and clear answer.
I have another question about the notifications_controller: isn't the system supposed to complete the order even if the user does not click "back to webshop to complete order" on the payment portal?
Right now it does send HTTP_POST to my adyen/notify url, however the order does not get updated to completed (if payment is valid) in the system.
Cheers,
Paul

I am not sure, I do not think the current code does that, but @huoxito can probably help.
We have changed the handle! in the notification model slightly so it does something like
     if success? && capture_available?
        payment.pend
      elsif success?
        payment.complete
      else
        payment.failure
      end

around here https://github.com/spree-contrib/spree-adyen/blob/master/app/models/adyen_notification.rb#L83

hey all, from what I can remember the user needs to come back from adyen payment portal in order to complete the checkout on spree side (I know that probably doesn't help much sorry)


ilvr_sample hangs at the line "model_kwargs = next(data)"

Hi,
I am using the FFHQ pt file to load the checkpoint and do the sampling.
I just placed one example image in the ref_imgs/face/ folder and ran the ilvr_sample file as per the README file. But the script hangs at the line model_kwargs = next(data) .
May I know how to resolve it?
Thanks.

Sorry for late reply.
Did you set PYTHONPATH? or maybe you can try --batch_size 1

I resolved it by setting batch size 1


File whitelist case sensitive?

I may be mistaken, but could it be that this https://github.com/dwilkie/carrierwave_direct/blob/50a7183e3d0cdd61623adc7e168cda930a27725f/lib/carrierwave_direct/validations/active_model.rb#L27 will neither work case insensitively nor will accept regexes in the whitelist that would have allowed such case insensitive values?

Actually, this even looks as if there is an error added, if the file should not have an error?


[STG93] Added ACL response headers

/azp run net - storage - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Storage.Common

/azp run net - storage - ci

/azp run net - storage - ci


Color courses in graph view

Color the courses and the background in the graphical interface to indicate information about the pathway, such as whether it is the first or 2nd/3rd courses, and whether the course is in multiple pathways, as indicated by this image:

If this were to be implemented, we'd have to change the colors of the little buttons for times available, hass inquiry, and communication intensive, as some of those colors are the same as the ones here, which would be confusing.


Blaine's Quiz Show

I know it's not a priority but I'm not that great at advanced stuff so I thought I'd try this. https://github.com/axpendix/tcgone-engine-contrib/commits?author=TTTrainer

That is just a copy paste from the other card (:

It won't work as this requires a new functionality to request a free form message from client in the game engine.


[thor] new port #1319

Thor headers seem to depend on Aurora headers, yet the latter are not installed. When building an example application I'm getting:
fatal error C1083: Cannot open include file: 'Aurora/Config.hpp': No such file or directory

I've noticed Aurora headers are installed along with Thor ones when install target is used. AFAIK no other popular library uses Aurora so maybe there is no need to add independent port?

@codicodi Thanks for your suggestion. Just wondering how you would deal with dll. For example if I use your suggestions I get  DLLs without any exports are likely a bug in the build script.
   if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
       string(REPLACE "defined(SFML_STATIC)" "1" CONFIG_H "${CONFIG_H}")
   else()
       string(REPLACE "defined(SFML_STATIC)" "0" CONFIG_H "${CONFIG_H}")
   endif()

file(WRITE ${CONFIG_FILE} "${CONFIG_H}")

@codicodi Thoughts?

It looks like internal copy of Aurora is still used during build. I added #error to one of it's headers and build instantly failed. Is there a way to use vcpkg provided Aurora instead?

@codicodi Added

Works fine now, thanks!

@ras0219-msft Could you review?

Thanks both of you, looks good to me!


Add more spans for mutation execution flow

Add more spans to mutation execution methods to better track in APM which parts of the flow need optimization. To discuss which parts of the mutation should be wrapped. Ideally, we would like to track particular steps of BaseMutation / ModelMutation:

For BaseMutation wrap mutate and perform_mutation methods
For ModelMutation wrap particular steps of the flow:

get_instance
clean_input
construct_instance
validate_and_update_metadata
clean_instance
save
_save_m2m
post_save_action

Closing as not planned.


Revert "KTL-1313 Add support for explicit backing fields"

Reverts JetBrains/kotlin-compiler-server#711
3 tests failed

closed by https://github.com/JetBrains/kotlin-compiler-server/pull/710/commits/2193940d7c7692b1df04f22f1da3b0674f6237ee