Permit to rename disk snapshot names

Author Name: EOLE Team (EOLE Team)
Original Redmine Issue: 4938, https://dev.opennebula.org/issues/4938
Original Date: 2016-11-23

Hello,
We heavily use the disk snapshots but sometimes the text of the name snapshot has a typo or should be changed to reflect the real state of the disk in that snapshot.
Could it be possible to make this text editable like for example the name of the instantiated VM.
Regards.

Interface Changes
XML-RPC API:

add new one.vm.snapshotrename method with string:<session> i4:<image_id> i4:<snap_id>, string:<new_name> arguments

Sunstone:

Add new button: 🖉 -  for rename snapshots

Cli:

onevm snapshot-rename <vmid> <snapshot_id> <name>


issue with routing order for APIs define with method and uri

Summary
if 2 APIs are defined with an overlapping base path and the same method. kong router won't be able to make the correct route.
Steps To Reproduce

define one API as: name: "base", uris: "/basepath" and methods: "GET"
define another API as name: "subdir", uris: "/basepath/subdir" and methods: "GET"
make a request to GET /basepath/subdir/xyz, which should be routed to the second API subdir, but kong would incorrectly route it to the first API base.

Additional Details & Logs

Kong version 0.10.1
Operating System Ubuntu 16.04

Fixed with #2523, thank you!


adds nil check for cjk linked note field

Closes #464.

Coverage remained the same at 80.203% when pulling b0a75340e9650bf0d667a5354ef0e69572f53f37 on cjk-notes-nil-check into 6b7b9e60d65f313fede5a70e5a2cd6e56d634003 on master.


Describe default port collision resolution for multiple instances.

Same suggestions as https://github.com/turkeylurkey/ci.maven/pull/1


Fix for Windows use

Turns out the uri.with() functionality broke Windows use. I believe this fixes it. Further testing appreciated.

fixes #55


[Bug-9719][Master] fix failover fail because task plugins has not been loaded

Purpose of the pull request
this issue close #9719
Brief change log
install task plugin when master and worker startup.
Verify this pull request

Manually verified the change by testing locally.

Codecov Report

Merging #9720 (7b8d227) into dev (48d526f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #9720      +/-   ##
============================================
- Coverage     40.01%   39.99%   -0.02%
+ Complexity     4475     4471       -4
============================================
  Files           835      835
  Lines         33550    33553       +3
  Branches       3710     3710
============================================
- Hits          13426    13421       -5
- Misses        18876    18884       +8
  Partials       1248     1248

Impacted Files
Coverage Δ

...e/dolphinscheduler/server/master/MasterServer.java
0.00% <0.00%> (ø)

...er/server/master/runner/FailoverExecuteThread.java
0.00% <0.00%> (ø)

...r/server/master/runner/MasterSchedulerService.java
0.00% <ø> (ø)

...lphinscheduler/service/task/TaskPluginManager.java
0.00% <ø> (ø)

...e/dolphinscheduler/server/worker/WorkerServer.java
0.00% <0.00%> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
37.77% <0.00%> (-2.23%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
52.11% <0.00%> (-1.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7382284...7b8d227. Read the comment docs.


Add image-upload analytics

Would be nice to see how often this gets used.

Still feel like we'd want this, @rnystrom?

Should be super quick with Fabric/FB events - no reason not to and gives us better insights!


Improve SEO

Google doesn't seem to be fully indexing the site; fix that as much as possible

Also:

/posts/:id?page=:page should be /posts/:id/page/:page, perhaps? See here for information on how.

Also fix that we block replies/search from being scraped (blocking results is fine, and the page isn't that important, but it is not in fact blockworthy)

Google still seems to not index second pages of threads (at least not well enough you can search for terms in them, whereas you can search for terms on the first pages).
Sitemaps may help: https://support.google.com/webmasters/answer/183668?hl=en&ref_topic=4581190. Related task is picking one of www.glowfic.com / glowfic.com to be our canonical address (I now vote the former since iirc we have weird DNS records on the last), per https://support.google.com/webmasters/answer/139066.
https://github.com/kjvarga/sitemap_generator#adding-links is a gem for it, and it looks like you generate the sitemap on a cronjob on a background worker. Could be useful? We can even pass last modified attributes, which may help with crawlers getting all over the site (but we may need to be careful around layout changes there).


Unable to create database with SDK in CosmosDb testcontainer

Testcontainers version
3.9.0
Using the latest Testcontainers version?
Yes
Host OS
Windows
Host arch
x64
.NET version
8.0.302
Docker version
Docker version 26.1.4, build 5650f9b

Docker info
Client:
 Version:    26.1.4
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.14.1-desktop.1
    Path:     C:\Program Files\Docker\cli-plugins\docker-buildx.exe
  compose: Docker Compose (Docker Inc.)
    Version:  v2.27.1-desktop.1
    Path:     C:\Program Files\Docker\cli-plugins\docker-compose.exe
  debug: Get a shell into any image or container (Docker Inc.)
    Version:  0.0.32
    Path:     C:\Program Files\Docker\cli-plugins\docker-debug.exe
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     C:\Program Files\Docker\cli-plugins\docker-dev.exe
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.24
    Path:     C:\Program Files\Docker\cli-plugins\docker-extension.exe
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.5
    Path:     C:\Program Files\Docker\cli-plugins\docker-feedback.exe
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.2.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-init.exe
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-sbom.exe
  scout: Docker Scout (Docker Inc.)
    Version:  v1.9.3
    Path:     C:\Program Files\Docker\cli-plugins\docker-scout.exe

Server:
 Containers: 1
  Running: 1
  Paused: 0
  Stopped: 0
 Images: 30
 Server Version: 26.1.4
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 Swarm: inactive
 Runtimes: runc io.containerd.runc.v2
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: d2d58213f83a351ca8f528a95fbd145f5654e957
 runc version: v1.1.12-0-g51d5e94
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
 Kernel Version: <IP_ADDRESS>-microsoft-standard-WSL2
 Operating System: Docker Desktop
 OSType: linux
 Architecture: x86_64
 CPUs: 20
 Total Memory: 15.46GiB
 Name: docker-desktop
 ID: f4ed21d2-681e-47f7-a4c1-c52d5637749a
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=npipe://\\.\pipe\docker_cli
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  <IP_ADDRESS>/8
 Live Restore Enabled: false

WARNING: No blkio throttle.read_bps_device support
WARNING: No blkio throttle.write_bps_device support
WARNING: No blkio throttle.read_iops_device support
WARNING: No blkio throttle.write_iops_device support
WARNING: daemon is not using the default seccomp profile

What happened?
Attempts to create a database in the CosmosDb emulator running as a Testcontainer aren't successful due to hanging indefinitely.
No error or exception.
The container spins up correctly with random ports, and it returns the connection string (e.g: AccountEndpoint=https://<IP_ADDRESS>:50676/;AccountKey=C2y6yDjf5/R+ob0N8A7Cgv30VRDJIWEHLM+4QDU5DE2nQ9nDuVTqobD4b8mGGyPMbIZnqyMsEcaGQy67XIw/Jw==).
When using the cosmos client with SSL validation, it throws the expected HttpRequestException (see reproducible repository).
When using the cosmos client without SSL validation, it hangs trying to create database.
This is the container I use. Please see more details below in the additional information along with the repository to reproduce the problem and to compare it with Ductus Fluent Docker (which works well for the same scenario).
_cosmosDbContainer =
    new CosmosDbBuilder()
        .WithEnvironment("AZURE_COSMOS_EMULATOR_IP_ADDRESS_OVERRIDE","<IP_ADDRESS>")
        .Build();
await _cosmosDbContainer.StartAsync();

Relevant log output
No response
Additional information
I have reproduced the error in this simple solution
https://github.com/diegosasw/cosmosdb-sample/tree/21ecf563f0329fbb60a7fb67d9ffc14009237e27
To reproduce, simply clone the repository provided there is .NET 8 and Docker daemon available.
Compile with
dotnet build

and run tests with
dotnet test

3 out of 4 tests will pass.
Basically I have configured two xUnit fixtures to demonstrate it.

FluentDockerFixture - which spins up a CosmosDb emulator using FluentDocker, and stops it and deletes it when the tests end
TestContainerFixture - which spins up the testcontainer CosmosDb emulator.

Then there are two test classes (i.e: two IClassFixture), each one using its cosmos db fixture. The same scenarios
Each test class tests two things:

Secure_Client_Should_Fail which attempts to create a database validating the untrusted SSL and expects to fail. It works well for both CosmosDb containers.
Insecure_Client_Should_Succeed which attempts to create a database without validating the untrusted SSL and expects to succeed. This one works fine for the CosmosDb container created with Fluent Docker, but fails with Testcontainer because it never ends, it hangs indefinitely (I suppose it eventually times out).

This is the code which can be found in the public repository.
The fixture
public class TestContainerFixture
    : IAsyncLifetime
{
    private CosmosDbContainer _cosmosDbContainer = null!;
    public string CosmosDbConnectionString { get; private set; } = null!;

    public async Task InitializeAsync()
    {
        _cosmosDbContainer =
            new CosmosDbBuilder()
                //.WithExposedPort(8081)
                .WithEnvironment("AZURE_COSMOS_EMULATOR_IP_ADDRESS_OVERRIDE","<IP_ADDRESS>")
                .Build();
        await _cosmosDbContainer.StartAsync();
        CosmosDbConnectionString = _cosmosDbContainer.GetConnectionString();
    }

    public Task DisposeAsync() => _cosmosDbContainer.StopAsync();
}

The tests
public class DatabaseCreatorTestContainerTests(TestContainerFixture testContainerFixture, ITestOutputHelper testOutputHelper)
    : IClassFixture<TestContainerFixture>
{
    [Fact]
    public async Task Secure_Client_Should_Fail()
    {
        // Given
        var cosmosClientOptions =
            new CosmosClientOptions
            {
                ConnectionMode = ConnectionMode.Gateway
            };

        var cosmosClient = new CosmosClient(testContainerFixture.CosmosDbConnectionString, cosmosClientOptions);
        var databaseName = Guid.NewGuid().ToString();

        var sut = new DatabaseCreatorTestContainer(cosmosClient);

        // When
        testOutputHelper.WriteLine(
            $"Attempting to create {databaseName} " +
            $"with connection string {testContainerFixture.CosmosDbConnectionString}");
        var exception = await Assert.ThrowsAsync<HttpRequestException>(() => sut.Create(databaseName));
        testOutputHelper.WriteLine("Attempt finished");

        // Then
        Assert.Contains("The SSL connection could not be established", exception.Message, StringComparison.OrdinalIgnoreCase);
    }

    [Fact]
    public async Task Insecure_Client_Should_Succeed() // THIS NEVER SUCCEEDS
    {
        // Given
        var cosmosClientOptions =
            new CosmosClientOptions
            {
                ConnectionMode = ConnectionMode.Gateway,
                HttpClientFactory = () =>
                {
                    var httpMessageHandler =
                        new HttpClientHandler
                        {
                            ServerCertificateCustomValidationCallback =
                                HttpClientHandler.DangerousAcceptAnyServerCertificateValidator
                        };

                    return new HttpClient(httpMessageHandler);
                },
            };

        var cosmosClient = new CosmosClient(testContainerFixture.CosmosDbConnectionString, cosmosClientOptions);
        var databaseName = Guid.NewGuid().ToString();
        var sut = new DatabaseCreatorTestContainer(cosmosClient);

        // When
        testOutputHelper.WriteLine(
            $"Attempting to create {databaseName} " +
            $"with connection string {testContainerFixture.CosmosDbConnectionString}");
        var result = await sut.Create(databaseName);
        testOutputHelper.WriteLine("Attempt finished");

        // Then
        Assert.True(result.IsSuccessful);
    }
}

PS: The tests run sequentially (see xunit.runner.json because if they run in parallel the 4 tests will succeed (probably due to the problematic test reaching the other Fluent Docker CosmosDb container, but not sure).
I tried to debug with "maxParallelThreads": 0 and "maxParallelThreads": 1 to see why it was succeeding when running in parallel and whether the test was creating the database in the other container in 8081, but when debugging the tests run sequentially, so I couldn't reveal this mystery. In any case, the original problem remains.

This is not a bug. Use the provided and preconfigured HTTP client:
https://github.com/testcontainers/testcontainers-dotnet/blob/a0f1f7694b4602aa2ba7da6f167ddc4a56670ecc/tests/Testcontainers.CosmosDb.Tests/CosmosDbContainerTest.cs#L26
There are plenty of similar issues. Please double-check the search results. They should contain further explanations.

Thank you, yes you're right. That works well.
https://github.com/diegosasw/cosmosdb-sample/commit/7c53b29a7bc506936932aa6fc329392e51f4abb0


channel fails to load randomly when navigating directly to it from another page

See https://open.lbry.com/vokoscreen-2019-10-23_11-25-17:9a5e6f1e869551a373beb645e654ca166a535034 - thanks to @eggplantbren
It does happen a bit randomly. Usually it's when your on a channel page already, and then navigate to another channel using your follow sidebar. The channel page will show "no content available" but it does have content. Claim search on the channel being navigated to is not run in that case.
Ctrl-R fixes it. @seanyesmunt thinks it's related to pagination somewhere.

Possibly related, but I've also noticed that occasionally when you click onto a channel page, the page numbers at the bottom are absent.

Other users are noticing this as well. I've run into it a few times myself. Don't have a clean repro, but does happen most often when navigating to a channel from your subscriptions sidebar. @seanyesmunt thinks it's related to pagination.

As a frequent user of the app, I think this is the most annoying bug at the moment.

@tzarebczan we didn't discuss this one today - is this workable or does it need better repro first?

Sean pushed up a fix to lbry.tv and we haven't seen it there since. But @eggplantbren and I still run into https://github.com/lbryio/lbry-desktop/issues/3188 randomly. Closing this for now, please re-open if you see it on lbry.tv again (or after next release)


Style: && and || in return and if() cascades

We should be consistent about how we do && and || cascades. A couple of recent patches are the first times we've done it with the || or && at the start of the line. They do look better in "return" cascades than what we normally do, though. Maybe we should say the rule is "in a return expression, if you have a sequence of subexpressions are delimited by && or ||, then put the logical operator under the return; in all other cases, when you line break at a logical operator, put it at the end of the line".

Closing. I'll deal with style issues separately.


Language selection function

Good afternoon
Please add a manual language shift function in the settings. This applies to mobile application and web app.

I thought this was gonna be easy, but apparently it is not, because updateConfiguration is deprecated: https://stackoverflow.com/questions/64400939/android-set-app-language-according-the-device-language
There is a way around it, but I don't really want to put this much effort into something that isn't in high demand.
If you like this feature, please :+1: the initial post.

I think it will be enough to add such a feature to the web application.
Many security browsers do not convey information about the language packs installed in the system. Most web applications have the ability to choose a language.

The web app has a language selection drop-down already. It'll be in the next release.

the dropdown selector lacks some of the already available languages. Browser, in web app interface, automatically selects my language (gl), but galician is not in the drop down list.
in android app  language is not correctly loaded. Android language component is also translated to galician, but it is not loaded. I don't know if this language is actually pulled in to the app from weblate.
thank you


Query: SelectMany subquery from a GroupJoin'ed subquery fails to compile

Example test:
        [ConditionalFact]
        public virtual void GroupJoin_Subquery_with_Take_Then_SelectMany_Where()
        {
            AssertQuery<Customer, Order>(
                (cs, os) => from c in cs
                            join o in os.Take(100) on c.CustomerID equals o.CustomerID into lo
                            from o in lo.Where(x => x.CustomerID.StartsWith("A"))
                            select new { c.CustomerID, o.OrderID });
        }

It blows up when SqlTranslatingExpressionVisitor attempts to translate the WhereClause in the subquery of the AdditionalFromClause, because it can't find a matching table in the SelectExpression for the MainFromClause of the subquery.

The issue here is incorrect association of additional from clause with select expression. There is no defaultIfEmpty operator so we need to do groupjoin on client (even after joining queries using LOJ). When we visit the additional where clause which iterating the grouping, we associate the previous select expression with it. This further worsen the situation. Even though we have group join done on client, we still try to translate the where predicate to server (which is not possible). Even in the case of client eval of predicate, we still get the previous select expression and try to bind property to it causing error that the table is not found in select. The reason for table not found in select expression is wrong select expression associated with the query source.
Assigning to @maumar since this is in the area of groupjoin translation.


v1.4.2

Changes in v1.4.2:

Add a mask to task-com-equality
Fix bug in Contact6d::setRegularizationTaskWeightVector
CMake: fix configure without tests

Please don't merge :)

This release was asked for by @Rascof & @skleff1994


load_scales fail to handle int64s

The provided demo code crashes, because the loaded scales contains int64 dtype columns, which your code can't handle.
The code crashes during CPP, the int64s are created in load_scales. If you convert the int64 to python ints (which should be able to fit the int64) it works. I'd recommend to either include this fix in your codebase, or  handle int64s. Thanks
aa.options["verbose"] = False
df_scales = aa.load_scales()
df_scales = df_scales.astype({col: int for col in df_scales.select_dtypes(include='int64').columns})
non_numeric_columns = df_scales.select_dtypes(exclude=[np.number]).columns.tolist()
dict_dtype = dict(df_scales.dtypes)
non_numeric_columns2 =  [(col, dict_dtype[col]) for col in dict_dtype if dict_dtype[col] not in [np.number, int, float]]
df_seq = aa.load_dataset(name="DOM_GSEC", n=50)

Thank you for highlighting this issue. We have corrected it in the latest GitHub version. A new pip release (0.1.3) incorporating this fix is scheduled for early January.

Solved with new release (1.3 or greater)


add the data dynamiclly to the screen

in this issue we need to show the items to the users

finished adding logic where the you can select item or search items


Add docstring to map_parts.

Hi @fredrikekre thanks for opening this!
Could you instead document the generic method
https://github.com/fverdugo/PartitionedArrays.jl/blob/b3eaa2ac84baccb791765d80a2f1fbc4be0d810e/src/Interfaces.jl#L86
with a similar docstring?
Once the generic function is documented, perhaps it is not needed to document each one of the particular implementations.

Sure. I was moving this docstring back and forth between those places, but in the end wasn't sure it was generic enough. I will move it.

Updated, but kept the examples using the MPI backend to make it more concrete.

Updated, but kept the examples using the MPI backend to make it more concrete.

Sure, the example needs to consider a concrete implementation. That's fine.

Feel free to add more docstrings. The package is functional but still mostly undocumented.

Codecov Report

Merging #58 (00ce98a) into master (b3eaa2a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   91.23%   91.23%
=======================================
  Files           7        7
  Lines        2190     2190
=======================================
  Hits         1998     1998
  Misses        192      192

Impacted Files
Coverage Δ

src/Interfaces.jl
90.60% <ø> (ø)

src/MPIBackend.jl
92.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3eaa2a...00ce98a. Read the comment docs.

I am sure I will find other things to document as I discover the functionality. Slightly off topic, but where would be a good place to ask questions about the package?

Slightly off topic, but where would be a good place to ask questions about the package?

We can try:
https://github.com/fverdugo/PartitionedArrays.jl/discussions


Expose a function to check if a hyper::Error is due to a BodyWrite

Is your feature request related to a problem? Please describe.
Originally reported in https://github.com/apache/arrow-rs/issues/5545, where they pointed me to ask some questions here. The gist of the problem is:
When using object_store, we've occasionally hit errors that point to this hyper error:
error writing a body to connection: Broken pipe (os error 32)

We would like to retry this specific error as it seems like something that should be retryable in our use case, but BodyWrite (and Body I suppose) both don't seem to expose any public functions to determine this at a glance.
Describe the solution you'd like
Add a is_body_write() (and maybe a is_body for feature parity with reads) function.
Describe alternatives you've considered
The current workaround we're doing is checking the Display output and checking if it matches the error message associated with BodyWrite - this works but it feels like a terrible workaround and is outright pointed out in the docs to not depend on this behaviour.
Additional context
If there's a better method or a reason this error reason isn't exposed, please let me know!

It's a fair thing to want! The most relevant idea is probably #2845.
Though I also suddenly am reminded of WriteException in Finagle...

👋 So just to be clear, would it make sense to (at least for now) expose is_body/is_body_write until #2845 has more progress made on it? I imagine the latter will take a while, and the former I can submit a PR pretty quickly.


Fix assignment_list, active_poll and operator subscription

Current behaviour:
If you are in several meetings (and are currently in Metting A) and you are in one election-detail-view then you still get the autoupdates from your other meetings for the assignment_list, active_poll and operator subscriptions
Reproduction:

create a user Ann who is in two meetings (both as delegate)
Meetings A : as Ann navigate into one election and open the console
Meetings B: as (super)admin create a new election and assignment
Meetings B: as (super)admin set A to present/not present
While the superadmin changes stuff in Meeting B, Ann gets the autoupdates while only having Meeting A open

Wanted behaviour:
Meeting specific subscriptions should only be triggered while in side the meeting of question.
The three found subscriptions should be prevented to bled into other meetings

This is not a bug. It is intended that the is_present_in_meeting_ids changes when your presence status changes.
The other subscriptions get notified because they were merged together with the operator subscription. However this does not trigger any repos and therefore also does not cause any performance issues.


Put @required on "child" argument of Widgets that need it

An argument X of type Widget in a subclass W of Widget is not required if:

W is a RenderObjectWidget
W's build function does not use X when X is null.
W's build function uses X as an argument to a constructor of another Widget subclass, and that argument is itself not required.

In all other cases, an argument of type Widget in a subclass Widget should be required.

I did all of Widgets. Still need to do material/.

https://github.com/flutter/flutter/pull/7730 https://github.com/flutter/flutter/pull/7732

I just notice this issue and reviewing the 2 PR I see @required added but no assert(xxx !=null). I make a quick test with one of the Widget modified (Title) and it looks like null is not accepted (new Title(child: null) in my test throw an exception).
Should an assert(xxx != null) be added where the @required had been added ?

In general yes but it's not a hard and fast rule. For example, onPressed is often @required but is allowed to be null.

I was mainly thinking about child parameter.


Fix: Refactoring MobX tutorial code resolves #133

Fix #133

Troubleshooting the counter changing simultaneously on MobX example

Changes

Code refactoring

How Verified
(Automated Tests)

N/A

(Manual Tests)

Notes

N/A

References

N/A

@ilikeu7246 Review & approve plz


Disable source switcher during walkthrough

Closes #4401 -- fixed as proposed in the issue's comments

Perfect, thanks @pwelby! 💪


Handle SVG nodes

Some of the recent commits to https://github.com/abinayasudhir/html-parser add some SVG node parsing.
https://github.com/abinayasudhir/html-parser/commit/c866a3f7b6a02d29027d785500a13c0bc8f21ea4
https://github.com/abinayasudhir/html-parser/commit/f34fbbceaf9a8469d3f9447270dd2de2e345b3da
https://github.com/abinayasudhir/html-parser/commit/95a496bafe935929932d8c80a54390be80e84b4d
https://github.com/abinayasudhir/html-parser/commit/07aaaf738a9c3d80eaf97361255f5521499ca225
Is this library stable and a good alternative fork? I wasn't sure which library to use. But the Tailwind docs use SVGs pretty often, so it would be nice to support this.

It turns out the above fork didn't address the problem, but I was able to make a fork of the original library with a fix: https://github.com/dillonkearns/html-parser/commit/0e90d844c2b31465023d1d1f7b3db3f8c35281f9.
I opened an issue in case the author wants to merge it upstream: https://github.com/hecrj/html-parser/issues/17.
For now, this is working for the needs of this tool with the local fork 👍


Log start and end times for each CPI call

Call started at  YYYY-MM-dd HH:mm:ss UTC
Call finished at YYYY-MM-dd HH:mm:ss UTC

#119500397
Signed-off-by: Karen Huddleston<EMAIL_ADDRESS>

@cppforlife @tylerschultz don't merge this one, please close out in favor of https://github.com/cloudfoundry/bosh/pull/1533

Closing based on @ljfranklin's comment.


MLX 0.4.0 benchmarks

Added M1 Pro results with the faster scatter introduced in MLX 0.4.0 + move benchs into separate folders with the mlx version. We need to find a way to also integrate mlx-graphs version (maybe as a prefix in the file name).

@TristanBilot you may want to upgrade torch and pyg as well.

Nice results on the M3 Pro


Not compiling with devkitPPC GCC 11.2.0

So, I'm trying to compile sol2 for a Wii homebrew project I'm working on (I redacted its name from the following error log because it's unreleased). However, when I try to compile it, I get a lot of strange errors that no one else seems to have gotten.
The compiler devkitPPC uses is GCC 11.2.0, and as far as I know, it doesn't seem to have any weird quirks compared to normal GCC. According to the __cplusplus variable from a compiled program, it is also using C++ 17. I tried the latest stable release, 3.2.2, along with the latest stable tag, 3.2.3, and even the latest commit, and nothing's working. I'm totally lost as to why this is happening, and I'm hoping this is just a configuration issue on my end.
Here is the full, very long, error log with sol's latest commit. It seems to have some GRRLIB errors mixed in which weren't there before I added sol2 to my project, so I'm wondering if something's wrong with the global namespace after adding sol2: errorlog.zip

After a lot of testing, it turns out that sol2 and GRRLIB seem to be conflicting with each other, which explains why the myriad of errors included GRRLIB. One compiles if the other one isn't present.
I have no idea why they're conflicting with each other. I noticed a lot of references to an "R" macro, maybe that's it?

TIL that the include order of libraries can matter A LOT. Including sol2 before GRRLIB fixed the issue for both libraries :grin:
But now one issue remains, sol2 compiles but throws a strange error when attempting to use sol::state:
error: use of deleted function 'sol::state::state(const sol::state&)'

Not too familiar with the error, but are you perhaps trying to pass sol::state as a value to functions?
Could be copy construction is triggered when passing by value causing the error even if you don't actually copy construct explicitly in your code. Just a hunch, given there is no code to inspect.

I do have a function in a different script that takes a sol::state as an argument, could that be it?

Thanks for helping him figure it out, @Rochet2!
I feel bad for not getting to a lot of these questions faster, but I have way too much to do. I should really clean up this library and the docs and make it easier for people to contribute fixes 😭


A11y_AzureDataStudio_Selectthedeploymentoption_ScreenReader:NVDA does not announce Column header name  with header reference.

GitHubTags: #SQL Azure Data Studio;#A11y_AzureDataStudio;#A11yMAS;#A11yTCS;#WCAG1.3.1;#DesktopApp;#NVDA#Win32;
Environment Details:
Application Name: Azure Data Studio
Version: 1.12.0-insider (user setup)
Commit: 32df727ff9fe68421b004bf270cd509e4c5de165
Date: 2019-10-08T19:18:43.743Z
VS Code: 1.38.0
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362
Additional Details:
NVDA 2019.2
Steps to Reproduce :
1.Install /Launch the application Azure data studio.
2.Navigate to connections and click on more action button.
3.Select “Deploy SQL Server big data cluster” from more action drop down.
4.Click on “Deploy SQL Server big data cluster” .
5.Start NVDA and Observe the announcement.
Actual:
NVDA does not announce Column header name  with header reference.
Expected:
NVDA should announce the  column header name with the header reference.
User Impact:
Screen reader User will not able to understand if there are normal content of the table or  header of the table.
Attachment for Reference:
A11y_AsureDataStudio_Selectthedeploymentoption_Screenreader3.pptx
Does this issue occur when all extensions are disabled?: Yes

this should have been fixed now, i am able to have narrator read the column name.


Bump version

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Please also include any acceptance criteria if you have any.

Change A
Change B

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.

[ ] Test A
[ ] Test B

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation and versioning
[ ] I have updated the architecture diagrams as per Contribute.md OR added an architectural decision record entry

@adamdavies1 did you mean to open this PR against this repo?

@adamdavies1 did you mean to open this PR against this repo?
Nope, sorry jen


Delegate to .expand_by when possible in distribution.expand

Mostly addresses #1180, except for another perf issue (relatively lower priority) that I discovered and mentioned in #1180.
Changes:

.expand calls .expand_by if we are merely appending batch dims to the left.

Implements ReshapedDistribution.expand. Multiple calls to this should be much faster especially if the base distribution has scalar parameters as this merely readjusts the sample shape. Without this implementation, multiple expands would otherwise call the more restrictive TorchDistributionMixin.expand and fail. e.g.
d = dist.Normal(0., 1.)
d.expand([2, 1, 1])  # Returns ReshapedDistribution
d.expand([2, 1, 2])  # Calls TorchDistributionMixin.expand which
                     # is more restrictive and fails.

Our non reparameterized distributions were accidentally getting their has_rsample attribute reset when expanded. This adds a fix for the issue, and increases the number of particles for the failing tests.

Perf impact (pasted from #1180):
test_enum.py::test_elbo_iarange_iarange (set of 81 total tests) on my local mac notebook:

Without any fixes - 46 seconds.
Deferring to .expand - 35 seconds.
Using iarange as rightmost - 30 seconds.

This is ready for any further review.

Do you think anyone's code will break, i.e. is anyone using .expand(N) for integer N?

:+1: for making .expand() more restrictive, requiring an iterable of sizes.

Thanks for reviewing, @fritzo!


Create Database / Migrations workflow broken for developers

The AllReadyContext is create the database from the snapshot in the constructor of the context.
This is bad because it means developers are unable to run migrations or create new migrations.

This was fixed in #168, but was not closed at that time.


[ADAM-1915] Bump to Hadoop-BAM 7.9.2.

Resolves #1915. @heuermh @akmorrow13 need to do any validation on your side?

I don't have a good way to test for leaking IO resources.

Coverage remained the same at 82.465% when pulling 6c4e11f41040bfee99e88430b394e55c829b566b on fnothaft:issues/1915-hadoop-bam-7.9.2 into fbc7218d8fe41b168b75b3323ece40d5bacace1c on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2695/
Test PASSed.

Thank you, @fnothaft


Adding low pass filter to imu measurement

Adding a low pass filter to the IMU measurement

interesting note: adding the low pass filter changes the realtime rate from ~0.8 to ~0.6.
this improves the stability of the tuned walking controller (tested in cassie_experimental branch)

This change is

The slowdown might come from the fact that the filter is in continuous time (https://github.com/RobotLocomotion/drake/blob/8592c35bd05810323f9b7f46b42542cd53349168/systems/primitives/first_order_low_pass_filter.cc#L27)
I think having a realtime simulation is valuable. Maybe we can implement a discrete version? For example, using DeclareDiscreteState and DeclarePeriodicEvent

Closing PR because the drake system uses continuous variables and we no longer need this feature.


Sauce Labs enhancements (created by other FINRA users) + FindBugs Fixes

@mibrahim do you want to sign off on this?

Also fixes #111

Should also fix #124


Activate kodi media player progress bar

Description:
Add necessary method calls for activating progress bar.
Related issue (if applicable): NA
Pull request in home-assistant.io with documentation (if applicable): NA
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @vetegrodd,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Thanks for the contribution! 🌟

Thanks for a great product!


Need support

Much appreciation for your sharing this coding. it's useful.
Here i am looking forward for your help

As you see the orignal pic, all the apriltags can be checked using pupli_apritags. but aprilgrid can't ,even using the undistored pic.(see the below pic.). meanwhile, very curiously, as your demo shown, the aprilgride board for calibration can be detected well by your code, inversely, pupil_apriltags failed everytime expect the example i show here. So can you help me to anaysize what's reason? meanwhile, in the last pic, this is generated by kablir: tagsize:5m, and ratio is 0.25，it‘s not detected by aprilgrid, can you help debug this?
orignal:
pupil_apriltags check result:
aprilgrid check using undistorted pic :
aprilgrid coding can't detect this pic:

Because aprilgrid follows kalibr and uses 2bit black as the margin for each marker. Whereas apriltag3 uses 1bit black as the margin.

I added the support for 1-bit black border tags. Please upgrade aprilgrid to 0.3.0 and try with
detector = Detector('t36h11b1').
I tested detecting your image using a fisheye camera and it worked.

Feel free to let me know if you need any help.

Much appreciated for your feedback. I have trial on ver.0.3.0, it works.
From my trial run, I found some phenomna：

As your seen, there is degradation at the below image.

the apriltag detection is sensitive with the orignal resolution of image. i noticed the image scaling in your code. i am confused by pupil-apriltags code detection result which is extremely not stable. but your code is vert stable.
Can you share me with the keypoint?
Should we chat by skype for convenience？：https://join.skype.com/invite/u1M14SpZ2On7

The Python version is not exactly the same as the original version. The tag needs to be detected and then decoded, but one bit black makes the tag harder to detect as a square I guess. Since your original issue is solved I'll close this issue. I'm not comfortable using Skype to chat so sorry for that.
If you can help improve the detection I'm very welcome to any pull request! thanks!

OK，thanks a lot


New code on ecm_redefine is too complex

Class to hold on to HealthVariable objects has is too complex. How can we rewrite it such that the following requirements are met

[ ] It contains an unspecified number of HealthVariable objects, determined by the end application (such as multiple RC components)
[ ] It knows which HealthVariable objects can be updatable
[ ] It can update specified objects from arrays, similarly to what HealthVariable does
[ ] For a hypothetical end user, it can be treated as a HealthVariable object, seeing as these are conceptually equivalent

The questions that I have are:

Can we simply implement all of this functionality inside of HealthVariable, like on commit b1c53bc?
If not, can we have attributes be HealthVariables or lists/tuples of HealthVariables? This way, we could clean up a lot of the dynamic allocation code
(in the not-so-distant future, can we make sure we can have collections of collections of HealthVariables in order to implement efficient operations with numpy.ndarrays?)

Additional comments:

Part of the reason why I did it dynamically was the following hypothetical situation: imagine that, in the future, we still want to use the ECM, but with some physics included, say, we want to incorporate loss of lithium inventory and loss of active material. We could simple '+=' those HealthVariables into the ECMASOH without needing to rewrite another whole class to deal with this. However, perhaps it would be best if these were all completely separate classes as well.
A perhaps not good benefit is that, for example, the RC components can be stored in a HVCollection composed of individual RC components, each also being its own HVCollection composed of a Resistor and a Capacitor

@WardLT What other things am I missing from this?

Should we also have the ability to mark which variables are "updatable" vs which are not?

That's requirement 2 above, no?

Yep🤦

Adding here a simple code snippet of how it currently works for reference.
Code (Note: ignoring warnings because I chose to warn when model fields are reset, but that adds clutter here):
from asoh.models.base import HealthVariableCollection as HVCol
from asoh.models.base import HealthVariable as HV
import warnings
warnings.filterwarnings('ignore')

class DumHV(HV):
    name: str

class DumHVCol(HVCol):
    name: str

r0 = DumHV(base_values=[1,2], name='r0')
c0 = DumHV(base_values=3, name='c0', updatable=False)
r1 = DumHV(base_values=[4,5], name='r1')
c1 = DumHV(base_values=6, name='c1')
r2 = DumHV(base_values=[7,8], name='r2')
c2 = DumHV(base_values=[9,10], name='c2', updatable=False)
rc1 = DumHVCol(name='rc1')
rc1 += [r1, c1]
rc2 = DumHVCol(name='rc2')
rc2 += [r2, c2]
asoh = DumHVCol(name='asoh')
asoh += [r0, c0, rc1, rc2]
print('Updatable: ', asoh.updatable)
print('ASOH len: ', len(asoh))
print('Updatable values: ', asoh.get_updatable_parameter_values())
print('Changing values!')
asoh.update(new_values=[10,20,30,40,50,60,70])
print('New values: ', asoh.get_updatable_parameter_values())
for param_name in asoh.updatable:
    print('-----------------')
    print('Parameter ', param_name)
    param = getattr(asoh, param_name)
    if isinstance(param, DumHVCol):
        print('Sub-parameters: ', param.updatable)
    print('Updatable vals: ', param.get_updatable_parameter_values())

Output:
Updatable:  ('r0', 'rc1', 'rc2')
ASOH len:  7
Updatable values:  [1, 2, 4, 5, 6.0, 7, 8]
Changing values!
New values:  [10, 20, 30, 40, 50, 60, 70]
-----------------
Parameter  r0
Updatable vals:  [10, 20]
-----------------
Parameter  rc1
Sub-parameters:  ('r1', 'c1')
Updatable vals:  [30, 40, 50]
-----------------
Parameter  rc2
Sub-parameters:  ('r2',)
Updatable vals:  [60, 70]

Going to try to summarize my thoughts here for a more streamline discussion over Teams:
It seems like, no matter what we do, we cannot escape the dynamic addition of more information for the HealthVariableCollection class. After all, we need to accommodate any natural number of RC components. If the need for dynamic allocation is not real, then we need to consider more than just these two options I am about to discuss below. Note: I will abbreviate HealthVariable to HV below
Option 1: employ python's inherent dynamic allocation capabilities in Tuples and List ('+=') for the task
Pros:

we can define field names pre-instantiation and enforce them
no need to build our own dynamic allocation
peace-of-mind of knowing that no matter what, it will work

Cons:

most of the inheritance from HealthVariable will need to be re-written (__len__, get_updatable_parameter_values, _update_single_param, update), to the point that maybe it shouldn't even inherit from it, or we should change how HV is defined.
if in the future we decide to add more metrics to a collection (such as incorporating physics-informed loss of lithium inventory, loss of active material, electrode potential degradation, etc.), we will need to create a brand new class for that.

My thoughts:

the Pros are very strong
in my simple mind, a collection of HVs is conceptually indistinguishable from a multivariate HV (similar to how HV has base_values, the concept of resistance is conceptually equivalent to the concept of resistance at 50% SOC). This makes it hard for me to overlook Con#1

Option 2: trim down clutter in current implementation
Pros:

most of the functionality already implemented
conceptually more sound: an HVCollection is a collection of HV and HVCollection objects
more easily adaptable to other models
can (nearly) be treated as a sequence of HV-like objects

Cons:

no control over field names, have to hope for the best out of the user (==me), who more often than not, has a knack for dumbfounding the programmer with overcomplicated "solutions" (xkcd 530)
will have to properly test and maintain our dynamic allocation capabilities
will have to de-clutter the code

My thoughts:

conceptually, this is pleasing to me, but, as you can tell, the code feels like forcing a square peg through a round hole (insert another xkcd comic relief here)
I believe that, as long as we provide good templates for what these collections should look like, we can mostly wash our hands of Con#1

Final remarks:

I will start this by saying I am positively biased towards Option 2
I believe the code can be decluttered in the following manner: change the GenericContainer to have some of the basic functionality, such as update, get_updatable_parameter_values, __len__, and force others (such as _update_single_param) to be abstractmethods, and make most things that will be updated a child of this
If we want to make dynamic allocation easier, we can, instead of adding new fields to pydantic's BaseModel children, use the extra option, and then update the appropriate methods and properties to check model_fields.keys() and model_extra.keys(), though I am not sure what impact that would have on subsequent serialization
Consider adding/overwriting __setitem__ and __getitem__ methods for looping through and setting attributes


Refactor README file

The README file is rather untidy right now. We could consider the following steps to a cleaner description and introduction for users:

Remove the changelog and move it to another file (see #33).
Move the tutorial part to the (currently empty) Wiki (https://github.com/msg-systems/ui5-testrecorder/wiki). This way, we would be more adaptive to changes, such that changes in the Wiki are independent of the actual development of the project.
We need a small developer guide (checkout source code, download UI5 development kit, ...).

The points listed above mean to be the starting point of a discussion. Please feel free to add further ideas or criticize the points listed above.

Move the tutorial part to the (currently empty) Wiki (https://github.com/msg-systems/ui5-testrecorder/wiki). This way, we would be more adaptive to changes, such that changes in the Wiki are independent of the actual development of the project.

Alternatively, we may re-use the website at https://msg-systems.github.io/ui5-testrecorder/ (on branch gh-pages).


Accidentally send USDT to BCH address

Please recover my USDT
Accidentally send USDT to BCH address
Txid: 6d359f570bcaa724dc75b311e90efa4cce13f70b777046489b9a93f246e09be8
Send to BCH address- 3HzcLfUjfRZyijVGJbEcpiVyzg5oUWDzXd
My USDT address- 1G1kyqeprmNRD1vjLNxCkTWx6v2VUQ8KF1
Please recover my USDT as soon as possible....help us..
Thanking you

Hi there,
please note, there is no way for us to recover any tokens.
However, if you have the private key of the destination you sent the tokens to, you can import it into www.omniwallet.org. If this is a service, you need to contact their support, which may help you with sending the tokens somewhere else.

I added a wiki page about this topic. Please let me know, if there is still anything unclear:

FAQ: I sent tokens to an incompatible wallet such as Coinbase or GDAX. Can you reverse the transaction?

Please also feel free to reopen this issue, if there is any progress. We'd also love to hear, if you were able to retrieve the tokens!


Fix Argument Passing

This ended up being a bit simpler than I thought.
What this PR does:
1 - Switches the way Execve and Execv interact, with execve now parsing new environment variables and then passing to execv instead of vice versa.
2 - Appends "NACLENV_" to new incoming args in Execve so that they pass through the environment cleanser, and sends those args to the cleanser correctly.
This way Execv keeps the old args, but Execve replaces them with new args, even if that's NULL.

Yeah, well the NACLENV_ thing is just extending what already exists from the original NACL implementation, not anything new so I think it's worth sticking with instead of reinventing this.
@jesings I made your changes, think it's good now.


[SPARK-9430][SQL] Rename IntervalType to CalendarIntervalType.

We want to introduce a new IntervalType in 1.6 that is based on only the number of microseoncds,
so interval can be compared.
Renaming the existing IntervalType to CalendarIntervalType so we can do that in the future.

Merged build triggered.

Merged build started.

Test build #38816 has started for   PR 7745 at commit e20f24e.

hive name them year-month interval and day-time interval, should we follow that?

It is a little bit confusing since YearMonth also includes microseconds.

Test build #38816 has finished for   PR 7745 at commit e20f24e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38863 has started for   PR 7745 at commit 13466c8.

Merged build triggered.

Merged build started.

Test build #38864 has started for   PR 7745 at commit 99f64e8.

Test build #38863 has finished for   PR 7745 at commit 13466c8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #38864 has finished for   PR 7745 at commit 99f64e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.


Inconsistent RMSD values with PDB2SQL

Expected Behavior:
The RMSD values checked to be correct
Current Behavior:
Checking some random cases they have different RMSDs (backbone L-RMSD) than expected
PDB: 1KLG

with PDB2SQL

'top_molpdf_BB_lRMSD_BM': 3.809,
'best_BB_lRMSD_BM': 3.179,

with PROFIT

'top_molpdf_BB_lRMSD_BM': 1.346,
'best_BB_lRMSD_BM': 1.234,

Hi @FarzanehParizi thanks for reporting it.
Would you have the pdb2sql script you used or is it done deep inside pandora ?

Maybe Farzaneh can confirm, but the function in PANDORA that takes care of it (by using pdb2sql) is this one.

@DarioMarzella  Thanks ! @FarzanehParizi  is it possible to share the pdbs you are using ?

Hi @NicoRenaud, Many thanks for taking care of the issue. Here are the PDBs for the 1KLG case.
top_molpdf:          1KLG.BL00050001.pdb
best_BB_lRMSD: 1KLG.BL00070001.pdb
https://drive.google.com/file/d/1FGRmohC0rI_SxR_FwfJCThw_6LM40rMp/view?usp=sharing
https://drive.google.com/file/d/1AzirU0O46zEIl18CiPwEzNt9UVLQVs_D/view?usp=sharing
Here is the target structure from IMGT:
https://www.imgt.org/3Dstructure-DB/IMGT-FILE/IMGT-1KLG.pdb.gz
As @DarioMarzella  mentioned PANDORA codes are used for the RMSD calculations.

Another case: 1L05

with PDB2SQL

'top_molpdf_BB_lRMSD_BM': 1.87,

'best_BB_lRMSD_BM': 1.864,

with PROFIT
'top_molpdf_BB_lRMSD_BM': 0.829,
'best_BB_lRMSD_BM': 0.729,

top_molpdf:                1LO5.BL00160001.pdb
best_rmsd (profit):      1LO5.BL00130001.pdb
best_rmsd (pdb2sql): 1LO5.BL00070001.pdb
https://drive.google.com/file/d/1Wu6Nem3r_AINbdDLrXuTIrIktgR5ufsE/view?usp=sharing
https://drive.google.com/file/d/1dU_vpVEbb25pxr3Q2Yt0Wopdb6TY1dXi/view?usp=sharing
https://drive.google.com/file/d/1UDBLD8GBMnAJLqckEfW4zVNA0df3-exw/view?usp=sharing
target_structure:
https://www.imgt.org/3Dstructure-DB/IMGT-FILE/IMGT-1LO5.pdb.gz

Thanks @FarzanehParizi ! I ll try to take a look at it this week but it is a busy week. When we started pdb2sql we had a benchmark set to compare irmsd values with profit. I think we should use and further extend  that benchmark so that we can periodically check irmsd values. I ll try to dig that up and upload it on a separate repo

Realted to issue #99 (single PDBs are not reported there though)

@FarzanehParizi it seems that there are 3 chains in the pdbs. At the moment pdb2sql can't handle that (we have a PR in progress to fix that). Which chains are you using to compute the irmsd and lrsmd ?

The two chains get cut and merged here using biopythonn and they are printed to a "_decoy" and "_ref" file. @FarzanehParizi can you please provide those two files and compare them with the chopped ones provided to PROFIT?
We use them to calculate the L-RMSD only, no i-RMSD.

The folder to the files ("_ref" and "_decoy") Dario mentioned are as follows
1LO5: https://drive.google.com/drive/folders/1260d2NnC-EPaxnsZIDauM_6_9dtXDC0e?usp=sharing
1KLG: https://drive.google.com/drive/folders/1s9RSMvHFHbgaq33-Q1KnCdZYaHYrw5fv?usp=sharing

great thanks ! I'll take a look at it this week

I've uploaded the use cases here  and there . You should be able to pull pdb2sql_benchmark and execute the scripts in these directories.
I'm unable to replicate the large values of the l-RMSD that you are reporting at the start of this issue. The value of the l-RMSD obtained for BL00130001 is actually identical to the one you obtained with PROFIT (0.729). The other values are slightly different but not that much either.
Could you try to run the script and see if you are still seeing large differences between PROFIT and pdb2sql ?

Thanks @NicoRenaud, for checking the cases. I need to clarify that these are the Ligand-RMSD values (Superimposing chain M and calculating chain P RMSD), not Interface-RMSD. Is the value you reported which is similar to PROFIT an L-RMSD or I-RMSD value?

oh I see the unclarity with the capitalization of L and i :)
it is the L-rmsd that I checked. Now I didn't specify which chain to superimpose and I actually don't know how pdb2sql decided to do that ... I'll double check and try to make sure that I superimpose the M chains.

@NicoRenaud Would it help if we give you a full output folder, including the Pandora objects, so you can directly use the calc_LRMSD function so you don't have to superpose, renumber etc? Or do you prefer testing it separately in pdb2sql only?

@DarioMarzella Thanks that would help I think :) I didn't do any renumbering or anything fancy in pdb2sql atm. So it might be that this also changes the result. So yes please :)
If you can directly upload all the files in the pdb2sql_benchmark repo in the corresponding use cases that's great :)

@NicoRenaud  I have git added the files to the pdb2sql_benchmark repo but seems I do not have access rights to the repository for my push request.

I thought you would have access to it as a member of DeepRank ... apparently not. I just sent you an invite so once you accept it you should be able to push :)

@NicoRenaud I have added a python script (rmsd_calc_pandora.py) so that you can replicate the results we get with PANDORA functions.
The usage of the script is written in the file.
(Sorry for the messy code as I just copied some part of our previously written code)

Thansk ! I'll take a look asap

I just noticed that you are using compute_lrmsd_pdb2sql in PANDORA and I was testing compute_lrsmd_fast. I would advise to use compute_lrsmd_fast as its faster and I tested it more. Plus with all the check in place now it should be ok.
However the two methods give different results on your test case and I don't know why. I'll investigate, but in the mean time if you could try swapping the method and see if that helps that would be great

The reason why we used compute_lrmsd_pdb2sql had to do with the lzone file. I cannot remember now if it was because pdb2sql would not take the type of lzone file we were giving it or something similar. We even have a function to calculate the lzone (get_Gdomain_lzone) but in the end we opted for just removing the extra domain (with remove_C_like_domain) so compute_lrmsd_pdb2sql could not get the lzone file wrong.

@NicoRenaud By cloning the fix_lrmsd branch, still I get the same RMSD values as before with compute_lrsmd_pdb2sql

hmmm  that's strange. Are you sure you are using the local install of pdb2sql ?

With the new fix_lrmsd in pdb2sql now there is the error message that ref and decoy do not have the same residues. Previously this has been passed and we thought the two files have identical numbering and residues. We retrieved an RMSD value which was considered to be right.
I have found where our models have inconsistency, this happens after we remove a C-like domain and merge the two chains. I am currently working to fix that in PANDORA to trim models for the inconsistencies (usually only one residue invokes this problem).


fix(uiSelectMultipleDirective): add $isEmpty handler

Fixes #850

@kmccullough Thanks, this will land in the next release!

Using single select and it's not working yet.. I'm Using version 0.19.0

@tmanoel I'm not sure what you are expecting. This fix is for ng-required not working on multiple selection. It should already work for single.

Thanks for the attention, kmccullough. But I'm using it into a directive. I've tried use required and ng-requeired, still not working for single select.

Take a look, it doesnt work on single neither multiple..
http://plnkr.co/edit/5Zt0OfEFh18tlcKP1Yen?p=preview

Can you give us a better idea of exactly what you are expecting in that plunkr @tmanoel ? It appears you are using version 0.11.2 of ui-select, which you have copied to an actual file included with the page, but it does not include my fix from this commit. Please try the latest version via CDN, update your sources with the latest, or apply my fix from src/uiSelectMultipleDirective.js to your own sources.


Triggerred is not a word

Triggered is what you're looking for...
Just a typo that shows up in Log (Sync) if not in other places.
E.g. [2020-03-25 21:29:04.202] [userDataSync] [info] Sync: Triggerred.
https://code.visualstudio.com/docs/editor/settings-sync

We no longer use this. Its now Auto Sync: Started


Generalize task cache to also be aware of task source or version for some specific tasks

closes #345

Coverage says that
fractal/cmd/_aux_task_caching.py

88.57% of new lines are covered (91.91% of the complete file).
Missing lines: 146, 153, 154, 155

but lines 153, 154, 155 are actually covered.


Temporal score

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #9  (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update
[x] Documentation

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Alright, nice job @jackson541. I've just tested your implementation with a few other vectors and they work as intended. Thank you very much!

thank you! it will be a pleasure to continue contributing.


[Bug report] Gomodule doesn't reconigze package

What version of Go are you using (go version)?
go 1.12.17
Does this issue reproduce with the latest release?
not tried yet
What operating system and processor architecture are you using (go env)?
win 64
GO111MODULE=on
GOPROXY=https://goproxy.io

What did you do?
master branch
git clone https://github.com/fwhezfwhez/model_convert.git

cd model_convert
go test -run ^TestGenerateWhere$

bad branch
git clone https://github.com/fwhezfwhez/model_convert.git

cd model_convert

git fetch origin/bad
git checkout origin/bad

go test -run ^TestGenerateWhere$

What did you expect to see?
bad branch should be as same as master branch
<just runable>

What did you see instead?
bad branch
model_convert.go:13:2: unknown import path "github.com/go-sql-driver/mysql": cannot find package
model_convert.go:11:2: unknown import path "github.com/jinzhu/gorm": cannot find package
model_convert.go:15:2: unknown import path "github.com/jinzhu/gorm/dialects/postgres": cannot find package
model_convert.go:16:2: unknown import path "github.com/lib/pq": cannot find package

Here is the exact difference between them.
https://github.com/fwhezfwhez/model_convert/pull/3/files

1.12.17 is out of support, please try 1.16.2

Duplicate of #35726


Ratking force powers bug + rat organs not healing

Ratking rummage ability has no proper range and ratking can't heal from miasma
Video bellow showcasing it.
https://medal.tv/tr/games/space-station-14/clips/1y6gAVTShw8Rzj/d1337LpLZmCd?invite=cr-MSxNS2YsMjAyMDUyNjA0LA
I accidently pressed enter so I had to edit it!!

can confirm


Create NetKAN for Strategia

New NetKAN for Strategia (released version to be created shortly, meanwhile everything in GitHub is a pre-release).

Looks fine to me. Merging with thanks!


Handling empty input

Should empty input be ignored or handled in some other way? Currently only CTRL+C will exit.
To reproduce:
echo -ne "" | pick

@mattix Great question! Sadly, I don't have a good answer for you. Do you have any ideas on how to best handle this?

Sure thing!
Maybe simplest solution which comes to mind would be adding:
if (!SLIST_EMPTY(choices)) {
	io_print_choice(
		ui_selected_choice(choices, query, use_alternate_screen),
		output_description);
}

to https://github.com/thoughtbot/pick/blob/master/src/main.c#L60
This way pick will do nothing and return nothing if input is empty.

This way:
https://github.com/mattix/pick/blob/master/src/main.c

That's a nice solution!
I wonder, though, if we should exit with an exit code indicating failure since we weren't able to produce any meaningful output? Maybe we could even print an error message on stderr saying pick requires input?
I guess it depends on the use case.
Do you have a specific use case for this behavior, @mattix?
@rosshadden, do you have any thoughts on this?
I think #58, might be sort of related. If we exit immediately unless we get input, the user won't be able to use the new feature in #61.

I think it's best to maintain consistent behavior. If the list is empty, it's still a list, it just has zero items. While I understand the motivation, I do not consider zero choices an "error", especially not one worthy of a nonzero exit code.
Just my two cents.

I wouldn't print any error either. The only choice for empty list would be empty I guess.

@rosshadden, @mattix All good points.
@mattix, what would the use-case for this be? I have personally not run into this issue before.

@mattix do you have any ideas on what use-case this would support?

I'm going to close this due to inactivity.


Fix invert method

There is currently a method called invert that lives in /lib/invert.js.
It is incomplete and needs to be fixed!
Acceptance Criteria:

Running yarn test invert results in tests passing.
You have written a skeleton method for someone else to work on.
You have written tests surrounding your skeleton method.
Running yarn lint does not print any errors to the console!

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!

This looks fun, can I take it?

Absolutely! I'll apply the 'in progress' label. Thanks @millerm !!

Donezo. Thanks @millerm !


Don't remove openshift-operators namespace on make uninstall

What does this PR do?
Make it so that make uninstall doesn't remove openshift-operators accidentally (a problem I keep running into when trying to uninstall the operator :wink:)
What issues does this PR fix or reference?
Is it tested? How?

PR Checklist

[ ] E2E tests pass (when PR is ready, comment /test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path to trigger)

[ ] v7-devworkspaces-operator-e2e: DevWorkspace e2e test
[ ] v7-devworkspace-happy-path: DevWorkspace e2e test

/test v7-devworkspaces-operator-e2e, v7-devworkspace-happy-path


Main panel intercepts click events

Refering to #264 , I have the same problem.
I am using the SlidingUpPanel in a fragment and since the main layer is only used to create the shadow effect there is no need it to handle click events. However there is no way I can prevent this so the parent view cant get the touch events.
I have tried to extend and override the main class as is describe in #264, however some methods doesnt exist and some variables are declared private and cant be inherited.
Any guess how to solve this?
Thank you.

Marking a dupe of https://github.com/umano/AndroidSlidingUpPanel/issues/264. Will be fixed in the next release.


Fix inconsistencies in display of sub-items. (Issue #7701, PR #7790)

ISO6 specific pr
closes https://github.com/inmanta/inmanta-core/issues/7701
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry - [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Description

Short description here *

closes Add ticket reference here
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[ ] Attached issue to pull request
[ ] Changelog entry
[ ] Type annotations are present
[ ] Code is clear and sufficiently documented
[ ] No (preventable) type errors (check using make mypy or make mypy-diff)
[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Correct, in line with design
[ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
[ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see test-fixes for more info)

Processing this pull request

Merged into branches iso6 in c70d30f07b686a83171cdc21876854df45eac969


ebay  'web xSql' not result

url:https://www.ebay.com/itm/155607414510

Please paste the X-SQL in text format.

select
dom_base_uri(dom) as url,
dom_first_text(dom, '.main-container #mainContent [class~='x-item-title'] .x-item-title__mainTitle') as title,
dom_first_text(dom, '.main-container #mainContent [class~='x-price-section'] .x-price-primary') as defaultPrice
from        load_and_select('URL' , ':root');

Please paste the X-SQL in text format.

select
dom_base_uri(dom) as url,
dom_first_text(dom, '.main-container #mainContent [class~='x-item-title'] .x-item-title__mainTitle') as title,
dom_first_text(dom, '.main-container #mainContent [class~='x-price-section'] .x-price-primary') as defaultPrice
from load_and_select('URL' , ':root');

The SQL looks correct. But I need more information to find out what happened. You can check your log for more information, if you can not resolve the problem yourself, please upload the log file.


flat_hash_map: Visual Studio never uses SSE2

The use of SSE2 / SSSE3 in the hash tables is controlled by the SWISSTABLE_HAVE_SSE2 and SWISSTABLE_HAVE_SSSE3 macros. If they are not explicitly defined by the user, there is some autodetection in place that will enable them if __SSE2__ is set:
#ifndef SWISSTABLE_HAVE_SSE2
#ifdef __SSE2__
#define SWISSTABLE_HAVE_SSE2 1
#else
#define SWISSTABLE_HAVE_SSE2 0
#endif
#endif

However, Visual Studio has no concept of __SSE2__, and as such SSE2 will never be autodetected. Furthermore, even if one sets this flag manually it will still fail, seeing that
#if SWISSTABLE_HAVE_SSE2
#include <x86intrin.h>
#endif

is a GCC-specific header. I solved this with a simple patch that adds MSVC's own predefined macros (there are none specific to SSSE3):
-#ifdef __SSE2__
+#if defined(__SSE2__) || defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86) && _M_IX86_FP >= 2)

and includes the instruction set specific headers necessary:
 #if SWISSTABLE_HAVE_SSE2
-#include <x86intrin.h>
+#include <emmintrin.h>
+#endif
+
+#if SWISSTABLE_HAVE_SSSE3
+#include <tmmintrin.h>
 #endif

This is done in 7990fd459e9339467814ddb95000c87cb1e4d945.


Formatting is not left-aligned for group headings in Enketo Express

New Enketo Express on zebra.ona.io has some formatting issues.  Group headings are now centered instead of left-aligned:

Replaces https://github.com/onaio/core/issues/566

This works for me locally but doesn't when I deploy. I tried deploying without copying node_modules from the previous deploy as well as change the different enketo themes but none fix the bug.

It seems both the kobo and formhub css theme files have the headers aligned in the centre as seen in the screenshots below:
As it is

When centre alignment is removed


Lagging Tooltip

Reported on behalf of users in Slack.
When using Tooltips inside large tables we have recorded some use-cases where the opening would lag and open after the user has hovered over the an icon.

This bug gave me deja vu 🤔

This was fixed by better handling of setTimeout in Tooltip. Notes: https://overreacted.io/making-setinterval-declarative-with-react-hooks/


Squarified treemap algorithm visualization

Step visualization do not display already placed nodes.

It will be easier to follow, if it displays also already placed nodes.

In the following view, we also see previously placed nodes.


note : quotes needed

Closes #3

Doesn't look like this project is being maintained unfortunately? @remojansen


Pipeline Catalog Integration story

Now that we have tektoncd/catalog, that store re-usable task for now (and maybe more in the future), we may want to think of a way to use/integrate those in a pipeline flow.

That said we could provide functionality on Tekton side that help CI system is realizing this.
Something that might help is the ability for a task/pipelineRun to reference a task/pipeline by some kind of URI (instead of name only) e.g. git://repo/path/to/pipeline@gitref. A task/pipeline defined that way would be pulled from git and expanded in the task/pipelineRun definition. That would allow combining the power of embedding with the reuse of pipelines.

As @afrittoli said here, being able to refer directly to a catalog (there might be more than one, see openshift/pipelines-catalog for openshift's specific ones) would make easier for user to adopt pipelines.
This is also related to our Dogfooding effort and the follow pull-requests : https://github.com/tektoncd/catalog/pull/43 vs https://github.com/tektoncd/pipeline/pull/949 and https://github.com/tektoncd/pipeline/pull/954. As of today, we either need to have some script that apply the task from the catalog (kubectl apply -f https://…) or doing it manually prior to the pipelines/tasks executions.
Raw ideas

Being able to use an url or a reference (à-la-container-image) in the TaskRef
Using images to get the task definition, and thus being able to use image reference in the TaskRef. This would be a bit similar to what mattmoor/kontext does, or in a more "standard" way what docker/app and CNAB are doing too

Next steps

[ ] Updating this issue based on comments and feedback
[ ] Preparing a Design doc on this

Could we leverage GUI (dashboard) or CLI to do this?
I think the import thing of Catalog is how to let user know there is stuff in catalog could be reused, no need another wheel.
So, if CLI or GUI could list all stuff in catalog and allow user apply some of them, this could help.

@vincent-pli I think having the ability of importing Tasks / Pipelines via CLI / GUI is a nice feature to have for sure; however it doesn't really solve the issues outlined in https://github.com/tektoncd/pipeline/issues/859 (see also my comment).

Apart from the CI use case, a large organization could use this feature to give teams with tailored tasks and pipelines which are maintained in a central repo by a dedicated team. The CLI/GUI approach could be used for this use case as well, however teams would have to regularly check for changes in the central repo and orchestrate pulling in a new version of Tasks / Pipelines when available.

@afrittoli

Being able to point to a Task / Pipeline by a URL of some kind would allow CI system to run pre-merge Task/Pipelines without polluting the namespace with copies.

Support URI or something similar in the Pipelinerun means we will not  actually create related crd (tasks, pipeline, resource) in the k8s cluster, am I right?
But I guess there is challenge how to describe this to user, since we have Tasks, Pipeline, resource cannot to be a truly crd which could be trace or monitor by user 😄

I may have duplicated this in https://github.com/tektoncd/catalog/issues/45

Design doc is https://docs.google.com/document/d/1O8VHZ-7tNuuRjPNjPfdo8bD--WDrkcz-lbtJ3P8Wugs/edit#
But I will close this one as a duplicate of tektoncd/catalog#45 :wink:
/close


Build failure when SWIFT_TREAT_WARNINGS_AS_ERRORS set to YES

I can't seem to figure out a way to ignore deprecation warnings of the SnowPlow library.
Steps to reproduce:

Create an empty Swift project
Add SnowplowTracker as a Cocoapod
Set SWIFT_TREAT_WARNINGS_AS_ERRORS to YES
Import SnowplowTracker
Build the app

Describe the solution you'd like
It seems that -Wn-error=deprecated is not available on Swift and this has caused issues for others as well.
For the reference see: Treat warnings as errors except for deprecations and Swift should allow for suppression of warnings
I see a few options:

Force deprecation and removal of the DEPRECATED_ATTRIBUTE
Soft deprecation by using @deprecated in the documentation comment
Setting SWIFT_TREAT_WARNINGS_AS_ERRORS to NO in the client app. But we would like to avoid that if possible.

I don't think that any of these options is very neat and it's difficult to justify them. Would be more than happy if there are other solutions available.
Describe alternatives you've considered
Unfortunatelly inhibit_all_warnings! in Podfile doesn't do the trick, so I tried the following with no luck:
post_install hook
post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['GCC_WARN_INHIBIT_ALL_WARNINGS'] = "YES"
            config.build_settings['SWIFT_SUPPRESS_WARNINGS'] = "YES"
            config.build_settings['GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS'] = "NO"
            config.build_settings['CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS'] = "NO"
        end
    end
end

Thanks @okalentiev for the heads up.
With the release of the version 2.0 we deprecated a lot of methods of the API related to v1.
We wanted to keep the old API available (even if deprecated) in order to reduce the breaking changes, providing a smooth migration from v1 to v2.
The drawback is that now we have quite a lot of warnings which makes difficult to identify real warnings in the noise. As you stated the problem is even bigger with Swift.
Honestly, I don't have a solution to the problem. I'm happy to receive suggestions for improvement.
I think the issue will be mitigated once we release the v3 that should remove all the v1 API (all the deprecated methods) without introducing changes to the v2 API.
At the moment, we don't have an ETA for the v3, so I can't say if it's something we will release later this year or next year.

How big is the impact if we continue to use 1.7.1 until v3 is released?
I don't have a good solution either. Since on one hand, we want to keep using SWIFT_TREAT_WARNINGS_AS_ERRORS and on another hand, I totally understand the need for a framework to have a deprecation mechanism.
I thought that maybe it is possible to exclude deprecated classes from the umbrella header, but then it defeats the purpose of having deprecation warnings. The other option would be to maintain the Swift interface and use the @available attribute. That way XCode only produces a warning if the deprecated method/class is used. We could also maintain the fork and disable the deprecation warnings.

v2 has been updated with some minor fixes not available on v1.7, also there are new features.
I see that SWIFT_TREAT_WARNINGS_AS_ERRORS raises warnings even if those methods are not used.
Changing the build settings manually seems to work. I've been able to remove the pod warnings enabling GCC_WARN_INHIBIT_ALL_WARNINGS in the SnowplowTracker pods.

Unfortunatelly inhibit_all_warnings! in Podfile doesn't do the trick, so I tried the following with no luck: post_install hook

Have you tried something like this?
target 'SnowplowSwiftDemo' do
    platform :ios, '9.0'
    pod 'SnowplowTracker', :inhibit_warnings => true
end

It seems to work during the build phase.
Perhaps :inhibit_warnings sets the build settings differently from the manual settings with post_install hook.

Thanks for the clarification!
Yes, I tried ignoring warnings and setting inhibit_warnings => true , however, it doesn't work in my case. I still see the errors. I tried clean build, reinstalling SnowplowTracker.
For me, warnings disappear if I have SWIFT_TREAT_WARNINGS_AS_ERRORS set to NO. But with Yes, GCC_WARN_INHIBIT_ALL_WARNINGS has no effect and the build fails.
Can you share an example project I can replicate the settings from?

This is our demo app with Cocoapods: https://github.com/snowplow-incubator/snowplow-objc-tracker-examples/tree/personal/tracker-inhibit-warnings/demo/SnowplowSwiftCocoapodsDemo
Be sure you checkout from the branch personal/tracker-inhibit-warnings.
There I set SWIFT_TREAT_WARNINGS_AS_ERRORS to yes, and GCC_TREAT_WARNINGS_AS_ERRORS to yes.
Instead the Podfile uses inhibit_warnings => true.
When I build the app on my Xcode (Version 13.0) I don't see errors on the SnowplowTracker deprecated methods.
These settings are tricky to set. Maybe there is something else that interact with them?!

A note about the release of v3.

I think the issue will be mitigated once we release the v3 that should remove all the v1 API (all the deprecated methods) without introducing changes to the v2 API.

The release of the v3 of the native mobile trackers has been planned for Q4. So, it will be ready before the end of the year.

Closing as the problem should be solved with the release of v3 (https://github.com/snowplow/snowplow-objc-tracker/releases/tag/3.0.0) where we have removed large part of the deprecated methods.


Switch to requesting available terms for queryable variables from linked API(s)

Now that https://github.com/neurobagel/federation-api/issues/12 is done, the f-API has an endpoint to get available terms from all available n-APIs.
We should now

[ ] Fetch the available terms for diagnosis and assessment tool from the new f-API endpoint
[ ] Decide at what stage of the lifecycle we should make the request
[ ] Remove the old hardcoded diagnosis and assessment options.
[ ] Provide a nice error message (e.g. https://bootstrap-vue.org/docs/components/toast) if either or both of these requests fail and we get zero terms back from the f-API

comes after https://github.com/neurobagel/federation-api/issues/12

@rmanaem mind taking a look and seeing if there is anything else to be added

Looks good to go. https://github.com/neurobagel/api/issues/211

Blocked by #305


Require Jenkins 2.479 or newer

Require Jenkins 2.479 or newer
JGit 7.0.0 requires Java 17 or newer.  Jenkins 2.475 requires Java 17 or newer and includes Jetty 12 and Jakarta EE 9.  Jenkins 2.479 includes a security fix and is the baseline for the next LTS.
Require the Jenkins weekly is the baseline for the next LTS.
Would be nice to wait on this release until the plugin BOM is available for 2.479.x so that it can depend on the 2.479.x plugin BOM.  That should happen in the plugin BOM release 15 Oct 2024.
Testing done
Interactive testing looks good and automated tests all pass.
Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[x] Link to relevant issues in GitHub or Jira
[x] Link to relevant pull requests, esp. upstream and downstream changes
[x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Should also migrate to EE 9:
src/main/java/hudson/plugins/git/GitTool.java
30:import org.kohsuke.stapler.StaplerRequest;
156:        public boolean configure(StaplerRequest req, JSONObject json) {


Gracefully handle SIGPIPE

Earlier versions of journald would send a SIGPIPE to any systemd processes when journald was restarted. So far we have bypassed this issue by redirecting STDOUT and STDERR to the traditional log paths, however in case users opt to use journald it would make sense to handle SIGPIPEs in a graceful manner to ensure the service doesn't crash when journald is restarted.
A similar fix was applied to Docker here: jwhonce/docker@b7f60f7

As per the linked patch, it looks like we just need to register a handler to ignore the SIGPIPE and that's it. Correct?

I have been reading up on this bug, here is my synposis and my conclusions
systemd version 218 or earlier has a bug where restarting journald causes SIGPIPE to be sent to the process since it can no longer write to STDOUT/STDERR. This means that the process has lost the ability to write logs to journald. In short, for these old versions of systemd restarting journald would cause the process to loose the ability to write anything to STDOUT/STDERR.
Release notes for Go 1.6

On Unix-like systems, when a write to os.Stdout or os.Stderr (more precisely, an os.File opened for file descriptor 1 or 2) fails due to a broken pipe error, the program will raise a SIGPIPE signal. By default this will cause the program to exit; this may be changed by calling the os/signal Notify function for syscall.SIGPIPE. A write to a broken pipe on a file descriptor other 1 or 2 will simply return syscall.EPIPE (possibly wrapped in os.PathError and/or os.SyscallError) to the caller. The old behavior of raising an uncatchable SIGPIPE signal after 10 consecutive writes to a broken pipe no longer occurs.

Now with Go 1.6 (the version Kapacitor uses), SIGPIPE is only sent to the process if a failure occurs on fd 1 or 2, (aka STDOUT and STDERR). This means that if Kapacitor receives a SIGPIPE its because it can no longer write to STDERR or STDOUT. In that case Kapacitor has lost the ability to log anything, and should shutdown.
If you are not using STDOUT/STDERR for Kapacitor logs you will not get SIGPIPE and this issue is irrelevant.
So we could setup a signal handler to safely shutdown Kapacitor, instead of letting it get terminated directly. Also we need to set an non zero exit code to indicate that the process failed, aka was forced to shutdown.

Nothing to do, closing.


Fix failing spec after 5:30 pm

Description of change
Fix failing specs after 5:30 pm

It would be good to understand why these specs are failing. I can see a few possibilities:

using DateTime columns when the data should be only a Date
date arithmetic is converting a Date to a DateTime
using the "next business day" calculation unnecessarily — when I converted some columns to Dates I wasn't sure about this, I think in some places it'll round it to the next day when now we might no longer need it to do so

If we can address the underlying cause we might not need to use travel_to at all. I'd be cautious of fixing tests simply by setting the time within working hours — yes, most people will only be working within working hours, but what if someone works late for some reason?


Upgrading Mutex to RWLock and wait becomes block

Description
Bringing in the RWLock to allow us to have decorated ready operations that block start, stop, destroy.
Issues Fixed

Fixes #4

Tasks

[x] Upgrade RWLock with acquire and release API
[x] Apply the block parameter instead of wait parameter
[x] Test all decorators and decide whether it is block true or false by default

Final checklist

[ ] Domain specific tests
[ ] Full tests
[ ] Updated inline-comment documentation
[ ] Lint fixed
[ ] Squash and rebased
[ ] Sanity check the final build

Decided to leave block by default false.
So this works.
Tested on all decorators.

Symbols are exported from utils, use it from there.
Can use block now in ready decorators


Delivery README

Also cleanup and a script to calculate majority votes for benchmarks.

Oh, a newly written Python 2 script? Perhaps this is a good time to point out the Python 2 countdown ...

To achieve a more advanced life-form just installed python3 about 10 mins ago!

Wooohooo!


[PE-D][Tester C] Broken feature

Alex is not removed after running the command shown

Labels: severity.High type.FunctionalityBug
original: Jonyxzx/ped#9

Unable to replicate


local_auth - TouchID Bypass (iOS)

Use case
We have noticed that it is not possible to set the accessControl parameter on iOS for the  LocalAuthentication.authenticateWithBiometrics method in the local_auth package. This would allow attackers with physical device acces to bypass the biometrics auth using objection (https://github.com/sensepost/objection).
More info on the vulnerability can be found here: https://github.com/sensepost/objection/wiki/Understanding-the-iOS-Biometrics-Bypass
Proposal
Add a parameter to the authenticateWithBiometrics method of LocalAuthentication class in the local_auth pacakge that allows us to set the accessControl parameter of the evaluateAccessControl method in LAContext method.
func evaluateAccessControl(_ accessControl: SecAccessControl,
                 operation: LAAccessControlOperation,
           localizedReason: String,
                     reply: @escaping (Bool, Error?) -> Void)

We have noticed that it is not possible to set the accessControl parameter on iOS for the LocalAuthentication.authenticateWithBiometrics method in the local_auth package. This would allow attackers with physical device acces to bypass the biometrics auth using objection (https://github.com/sensepost/objection).

Unless I'm misunderstanding the docs there, an "attacker" could create a new copy of the application that bypasses biometrics checks, and sideload it. It's not clear to me how that constitutes an attack.

More info on the vulnerability can be found here: https://github.com/sensepost/objection/wiki/Understanding-the-iOS-Biometrics-Bypass

That doesn't seem to be describing a vulnerability. The prerequisite for this working is that the person changing the behavior has the ability to patch the binary. If someone can patch a binary, they can change its behavior in arbitrary ways.

Add a parameter to the authenticateWithBiometrics method of LocalAuthentication class in the local_auth pacakge that allows us to set the accessControl parameter of the evaluateAccessControl method in LAContext method.

The plugin doesn't use that method, so I'm not sure what you are proposing adding it to. It's also not clear to me how this proposal relates to the above; someone with the ability to patch arbitrary ObjC calls can simply call the reply callback with true and get the same behavior.
Closing, as this doesn't appear to be describing a security issue, or an effective mitigation even if it were. If I'm misunderstanding, please provide a link to a discussion of how this constitutes an actual security issue and how your proposed change would prevent it.


Added empty to check if a sequence is empty, and now len_greater, len…

…_smaller, and len_equals can get a generator

lgtm


about the dependency url

Today's afternoon, I tried to integrate the Redis to vapor 4 (my swift version is 5.4)
according to this doc , I copied the url ( .package(url: "https://gitlab.com/mordil/RediStack.git", .branch("master"))) to my Package.swift
but the complier reported an unwanted problem, it indicated  :" https://gitlab.com/Mordil/RediStack: An unknown error occurred. unexpected return value from ssl handshake -9806 (-1)"
Meanwhile, I found another reference on vapor's doc (https://docs.vapor.codes/4.0/redis/overview/). Unfortunately, it was also unable to be fixed.
Finally, I attempted to substitute the "gitlab" by "github", then the dependency package can be install on my app
To be honesty, I had spent more to an hour to address this issue. so , would you mind to change the url into the right way ?

@micezhao The RediStack package is hosted on Gitlab as that's where the development is done - this repo is just a mirror. Can you clone the package directly from Gitlab?

@micezhao The RediStack package is hosted on Gitlab as that's where the development is done - this repo is just a mirror. Can you clone the package directly from Gitlab?

No! I have tried several times by fetching this dependency directly.Whereas, The complier did not resolved the package info correctly.
Actually , even if  the dependency can be fetched with url in GitHub and resolved normally in Xcode.However , I still have no idea of how use this in vapor ,  not like in Java with Spring-Framework.

This looks like standard SSL errors.
Are you able to vie the GitLab repo in a browser?
also, what does your Package.swift look like?

ok~ the following picture is my content

Ok, 2 problems:

The product and package names are case sensitive so it should be RediStack for both
the latest Master has breaking changes that are incompatible with Vapor right now unless you intend to do all the glue code yourself.

it is recommended to use the Vapor/Redis v4 package to gain Vapor+Redis features

@Mordil
OK, I have addressed this problem according to your method !
thanks 😊


floats: use asm version of AddConst when available

Signed-off-by: Francesc Campoy<EMAIL_ADDRESS>

Please correct the commit message format in a squash.

Fixed

Thank you @campoy!


Fix build error due to base image

apt update fails with this base image.
 Done
E: The repository 'http://security.debian.org/debian-security stretch/updates Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: The repository 'http://deb.debian.org/debian stretch Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
E: The repository 'http://deb.debian.org/debian stretch-updates Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
root@39368575de11:/# echo $?
100

So the build fails at apt update

Thank you @remi-sap for the PR. I wonder why you had to add the mbt tool, because the build and execution will work with an adapted base image URL only.

Thank you @remi-sap for the PR. I wonder why you had to add the mbt tool, because the build and execution will work with an adapted base image URL only.

The popular scenario is to build an mbt from source files then publish it in XSA. Adding MBT simplifies this scenario.  Maybe this should be split into another change?

Thank you @remi-sap for the PR. I wonder why you had to add the mbt tool, because the build and execution will work with an adapted base image URL only.

The popular scenario is to build an mbt from source files then publish it in XSA. Adding MBT simplifies this scenario. Maybe this should be split into another change?

Due to the fact that the image build description is intended to be used with one particular Piper scenario, the mbt part is not the focus of the image itself and shouldn't be added at all.

Fixed by PR #14


Identify conventions or logic for common needs

PSDepend would benefit from conventions and logic for common needs.  Need to identify and implement these.
For example:

Perhaps dependency scripts could offer:

An -Import parameter to import specified dependencies
A -GetDependencies parameter that reads one dependency, and parses subdependencies as appropriate for that dependency type.  e.g. a PowerShell module might have RequiredModules listed in it's module manifest
A -Test parameter that validates a dependency has been installed

All spots an author should attend to should be indicated - for example:

Dependency Script comment based help .DESCRIPTION blocks should identify how Dependency properties like Target, Source, etc. are used.
Dependency Scripts should include parameters and help for any Dependency 'Parameters' they allow
Prerequisites for dependency scripts should be listed in their comment-based help, and in the about_PSDeploy help file

Implemented PSDependAction parameter for dependency scripts.  At the moment, Test, Install, and Import, or a subset of these, are specified per dependency script.  Test-Dependency, Install-Dependency, and Import-Dependency call their respective PSDependAction.  Need to document this...


proposal: cmd/go: doc -http should start a pkgsite instance and open a browser

The go doc command displays documentation to stdout, which is handy for quick forays for a single package or symbol, but for extended reading a browser is more convenient, as it has better typography and linked cross-references. We propose that go doc -http should start a pkgsite instance in the background (if one is not running already)  and open a web browser to the correct URL for the package or symbol.
The pkgsite program is currently rather large and slow to start as it was designed as a long-lived server for a large corpus on Google Cloud. Issue #61399 tracks the work to slim it down and reduce dependencies.
Open questions:

How should successive go doc processes communicate the port or pid of the running instance, and deal with server crashes?
The server would necessarily outlive the go command. Is an explicit "stop" operation necessary?
Should the -http flag be a boolean, or an integer port? I think boolean (picking any unused port) would be more friendly.

@rsc @matloob

Similar Issues

proposal: x/tools/cmd/godoc: un-deprecate (or make pkgsite more compatible) #50229
x/pkgsite: improve pkgsite command  #47780
Feature request for godoc -http #509
x/pkgsite: run locally to view documentation of a pending CL #40159

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

I would like know to run go doc -http, which starts a pkgsite process and opens a browser, then waits for the syscall.SIGINT signal, and when it receives the signal, first close the pkgsite process and then exit itself ,how？

We could certainly make go doc -http block until interrupted before terminating the server. And perhaps that's the least surprising interface, as many Go commands that take an -http flag block indefinitely.

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

go doc -http should open the browser (we have other go tools that do that).
and it should print the URL and block until you get a ^C.
it would be slick if the browser integration could track reliably whether the last page was closed and have go doc -http exit at that point.

Have all remaining concerns about this proposal been addressed?
The proposal is to add go doc -http, which will start a server and attempt to open a browser window on the docs for a given package. If a browser successfully navigates there and then all the open browser windows close, go doc -http will exit. Otherwise it can be ^C-ed early, of course.

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group
The proposal is to add go doc -http, which will start a server and attempt to open a browser window on the docs for a given package. If a browser successfully navigates there and then all the open browser windows close, go doc -http will exit. Otherwise it can be ^C-ed early, of course.

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group
The proposal is to add go doc -http, which will start a server and attempt to open a browser window on the docs for a given package. If a browser successfully navigates there and then all the open browser windows close, go doc -http will exit. Otherwise it can be ^C-ed early, of course.