Lag in the data (1st of December)

Hi team!
I just realised that the data has not been updated since the 1st of December.
Has there been a change in the update frequency or a problem in the automation scripts? Let me know if you need help.
This is the file that we use: https://github.com/crondonm/TrackingR/blob/main/Estimates-Database/database_7.csv
Thanks!

Hi @lucasrodes
The repository is updated again.
Please let us know if you foresee needing daily updates or whether you think bimonthly updates will be fine.
Thanks a lot,
Carlos


Stop interaction when hiding roi tools dock widget

This PR improves ROI sample code when hiding the roi tools dock widget
closes #2033

Maybe it could be integrated inside the tool itself.
Here is a code i unsed on pyFAI which is supposed to catch visibility change. It could be checked?
    def eventFilter(self, widget, event):
        result = super(AbstractCalibrationTask, self).eventFilter(widget, event)
        if event.type() == qt.QEvent.Show:
            self.widgetShow.emit()
        elif event.type() == qt.QEvent.Hide:
            self.widgetHide.emit()
        return result

Yes it works, not sure it is simpler though


CI: Test coverage in monorepos

Separate files => separate badges

https://github.com/intuit/istanbul-cobertura-badger

Merge multiple files to one => one badge for all packages together

https://github.com/achingbrain/coveralls-lerna

Setup "Separate files => separate badges"
Missing step here is to integrate the docs build step into CI only

Closed as implemented


num (max-records) not working without a query

when trying to set the num option on getRows, it fails if there is no query.
It's an issue with the function args and trying to be clever about letting users use the function in different ways.

New releases fix for this ?

should be fixed now in 0.3.0!
Options and parameters changed a bit though, so check the docs!


Vhost status v2

Add statuscodes and statuscodesblacklist to gobuster vhost command.

cc @OJ rebased on 3.1

Great, thank you!


To test the code, coverage must be created for NHibernate 5

There is currently no test coverage for the NHibernate 5 integration. This needs to be created.

Duplicate of #24


「SecurityError: The operation is insecure」 when executing createOrder on mobile.

Component
API
Have you ensured that all of these are up to date?

[X] seaport-js
[X] Node (minimum v16)

What version of seaport-js are you on?
2.0.8
What function is the bug in?
createOrder
Operating System
None
Describe the bug
When I run the following code on iOS, I get the error SecurityError: The operation is insecure, but on MacOS, the error does not occur and it works fine.
using libraries
"@opensea/seaport-js": "^2.0.8",
"ethers": "5.6.9",
"viem": "^1.15.4",
 "wagmi": "^1.4.3",

Full error message
SecurityError: The operation is insecure.
missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (data="0x", transaction={"to":"0x8D2C372317524a8Af5313883434411fd3DAE55d9","data":"0xf07ec373000000000000000000000000359c9df909e5928b53bf9fcd0371db828e94251f","accessList":null}, error={}, code=CALL_EXCEPTION, version=providers/5.6.8)

my code
import { Seaport } from '@opensea/seaport-js'
import { ItemType } from '@opensea/seaport-js/lib/constants'
import { parseEther } from 'viem'
import { useAccount } from 'wagmi'

const Index = () => {
  const { address } = useAccount()

  const handleClick = async () => {
    try {
      if (!signer) return
      const seaport = new Seaport(signer)
      const fulfiller = address
      const { executeAllActions } = await seaport.createOrder(
        {
          offer: [
            {
              amount: parseEther('0.1').toString(),
              token: '0x0000000000000000000000000000000000000000', // MATIC
            },
          ],
          consideration: [
            {
              itemType: ItemType.ERC721,
              token: '0x0000000000000000000000000000000000000000', // MATIC
              identifier: '1',
              recipient: address,
            },
          ],
        },
        address,
      )
      const order = await executeAllActions()
      const fulfillOrder = await seaport.fulfillOrder({
        order,
        accountAddress: fulfiller,
      })
      const transaction = fulfillOrder.executeAllActions()
      return transaction
    } catch (error) {
      console.log({ error })
    }

    return (
        <button onClick={handleClick}>create order</button>
    )
}

the token for your consideration item needs to be the token address


Feature: Add gRPC related packages

What this PR does:
Add pkg/util/grpc* from Cortex as grpcclient, grpcencoding and grpcutil. Also rename kv/kvtls to crypto/tls since it's used from more places.
Which issue(s) this PR fixes:
Checklist

[ ] Tests updated
[x] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Thanks @pstibrany - will look into your feedback.


P4CP configuration file generator

Command-line utility to generate cmake configuration files for building P4 Control Plane.
This is a convenient alternative to environment variables and helper scripts. which become rather tedious when you find yourself typing the same command-line flags every you run (and even more so when you find yourself switching between the same two or three configurations).
cmake -B build -C es2k-setup.cmake
cmake --build build -j6 --target install

The utility can also save default parameters to a file that it loads on subsequent runs, and it can generate files to define common environment variables.
It does not yet support cross-compilation.

I'm think of dropping the .py suffix and making the command just p4cpconfig. Any opinions?


Why is there no Hbase plugin support?

Which module is your feature request related to?
Plugin/Hbase
Is your feature request related to a problem?
A clear and concise description of what the problem is.
Describe the solution you'd like
Hbase GET/PUT/DELETE/SCAN etc
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hello, @VictorZeng
We hope that we can provide all the features. But unfortunately, it's not easy due to lack of time.
It would be GREAT for Pinpoint Community if you can make Hbase-plugin and share with us:)

@RoySRose I will make the Hbase-plugin

@VictorZeng
Oh! Perfect~! We are really looking forward to it~!


Potential memory leak in proxy_getMetadata

There is a potential memory leak while accessing metadata is 1.3.
Caller does not free it because the API does not require it,
something else needs to
getRequestDestinationPort(int * ) --> proxy_getMetadata()  --> copyToPointerSize --> alloc
If I passed in the address of a stack variable to getRequestDestinationPort
someone else needs to free it. may be proxy_getMetadata() ?

This code is gone in master of envoy-wasm. It's using the generic getProperty. Does it have the same problem?

I will check, but we can do code inspection first. Is the latest istio/proxyv2 using the tip of envoy?

I think so.

I think this can be closed since the ABI changed and these methods are no longer present.

We may need to fix this in 1.3


NPE with ... something?

https://gist.github.com/amoooooo/9d1dda2c73c8f19c1b18fd487fc46e97 ct log
https://gist.github.com/amoooooo/c81d0f6c6c572d65eeba7031789feadd script
ct chat error is just null.

does the code inside the function works with the crafting table?

yep, it works in the crafting table.


add penfold to CI

this will add penfold app and its backing mongodb

Can one of the admins verify this patch?

[test]


Split click callbacks in click and on change

From my understanding most of the callbacks are being triggered by clicks instead of item changes. This would mean that programmatically if you change an item no callback is necessarily triggered. I think we have to discuss separating callbacks where the click callbacks would only change the row for example in a widget which then triggers another callback actually changing anything that is displayed. For example:

coordinate_system widget on click on another coordinate system change the current coordinate system.
on coordinate system change update layer visibility.

What do you think? I think this is also easier maintainable when writing tests as right now I believe we have to simulate mouseclicks every time.

I also think that on-change would be better than on-click, for instance this would allow to use the arrow keys (haven't tried but by reading this I understand that they won't work).


[BugFix] percentile_cont in force_streaming mode cause be's crash

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
https://github.com/StarRocks/starrocks/issues/11262
Problem Summary(Required) ：

PercentileContAggregateFunction's method convert_to_serialize_format is implemented incorrectly, this functions is called and causes BE's crash when streaming_preaggregation_mode = 'force_streaming'.  There are two errors as follows:

Forget to update offsets of BinaryColumn when append an to BinaryColumn;
In convert_to_serialize_format function, we must serialize row-by-row instead of sequeeze many rows into a row, since the columns in Chunk must be equal-size.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.2


Problems concerning the calculation of lyapunov dimension of delay differential equations

Hello! Your code is very clear, but I have a problem when using your project to calculate the Lyapunov dimension of Mackey-glass system, because the state of Mackey-glass system depends on the state before the delay, meanwhile, Lorenz system has 3 degrees of freedom, The Mackey-glass system has only one variable describing its evolution. How can I use your code to calculate the Lyapunov dimension of the Mackey-glass system? Your code is very clear, but I have a problem when using your project to calculate the Lyapunov dimension of Mackey-glass system, because the state of Mackey-glass system depends on the state before the delay, meanwhile, Lorenz system has 3 degrees of freedom, The Mackey-glass system has only one variable describing its evolution. How can I use your code to calculate the Lyapunov dimension of the Mackey-glass system?

Hi! I have no direct experience with time delayed systems, but, if the Lyapunov exponents are defined in the same way of ordinary differntial equations,  you need to to swap the integrator and system functions with a solver of the Mackey-glass system. I.e., something that advances the equations in time.
You would need also to change the number of dimensions of the system and the number of Lyapunov exponents that you want to compute accordingly.

Thank you for your reply, maybe my understanding of Lyapunov exponent is not quite complete, I also looked up relevant literature about how to calculate the Lyapunov exponent of delayed differential equation is very little, even if there is, it only gives a simple concept. I think it is really a little difficult for me to use code to implement, thank you again for your reply.


remove gaps between left sidebar list items

closes #12508

GIFs or Screenshots:
previous stream list (shown when all items are hovered upon):

updated stream list:
shown when all items are hovered upon

shown with highlighted element and hover

the positions of all elements of the left sidebar remain same, except the list items

hello @rishig @timabbott, could i get some feedback?
Now every point inside the streams sidebar will be treated as a clickable object.

This looks great; thanks @ryanreh99! Tim will do the final pass/merge.

This is great!  Squashed and merged as 8d0800210e2dadd0489d8b8fe9eee0ae7a24b8b4 with proper commit style; I also added 5ffbb33a92212b5e74d152460834db05138c7d75 on top to fix a related glitch I noticed.
Sorry for the slow review; we've been prioritizing PRs that follow our guidelines since they are faster to review.
Check out the Zulip commit guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html


[Feature] VelaUX support adding env prefix to application applied resources

Is your feature request related to a problem? Please describe.

In VelaUX, one application template can be deployed into multiple environments. Each environment usually corresponds to a set of targets (cluster+namespace). The delivered resources by default use the same name.
In the case that administrators need to manage resources across different environments directly, these resources with the same name across different clusters could potentially be unclear and might lead to incorrect operators.
For example, an application nginx is deployed to the default environment and the production environment. The deployment nginx is delivered to both the default namespace and prod namespace. If the administrator want to make temporary changes to the nginx in the default namespace (for testing), he might incorrectly make changes to the production nginx if the namespace is not clearly specified and recognized.
Describe the solution you'd like

We could potentially support adding prefix to the resources to different environment with a featuregate and let users choose whether to use this function.
Describe alternatives you've considered

We could support policy in the application spec and let prefix to be added to all its resources if the policy configures that.
Additional context

@Somefive hi can you tell me what exactly is prefix here

@Somefive hi can you tell me what exactly is prefix here

For example, when we deploy a Deployment object in the test and production environment, by default, they may use the same name my-deploy. Some users might want to use test-my-deploy and prod-my-deploy to make clear distinction between two environments, even though they are in the different namespace.
This issue is for discussion now, not determined to be solved.


Staging works in CDP DEV

Do not merge
The only changes with respect to develop are the config files.
Staging works, mapping fails.
Insert detailed bullet points about your changes here!
Insert any instructions to help the reviewer, e.g. "install new requirements from requirements.txt"
*Let the reviewer know what data files are needed (and if applicable, where they are to be found)
Closes or fixes

Detail the ticket(s) you are closing with this PR
Closes #

Code

[ ] Code runs The code runs on my machine and/or CDSW
[ ] Conflicts resolved There are no conflicts (I have performed a rebase if necessary)
[ ] Requirements My/our code functions according to the requirements of the ticket
[ ] Dependencies I have updated the environment yaml so it includes any new libraries I have used
[ ] Configuration file updated any high level parameters that the user may interact with have been put into the config file (and imported to the script)
[ ] Clean Code

[ ] Code is as PEP 8 compliant as I can humanly make it
[ ] Code passess flake8 linting check
[ ] Code adheres to DRY

[ ] Type hints All new functions have type hints

Documentation
Any new code includes all the following forms of documentation:

[ ] Function Documentation Docstrings within the function(s')/methods have been created

[ ] Includes Args and returns for all major functions
[ ] The docstring details data types

[ ] Updated Documentation: User and/or developer working doc has been updated

Data

[ ] All data needed to run this script is available in Dev/Test
[ ] All data is excluded from this pull request
[ ] Secrets checker pre-commit passes

Testing

[ ] Unit tests Unit tests have been created and are passing or a new ticket to create tests has been created

Peer Review Section

[ ] All requirements install from (updated) requirements.txt
[ ] Documentation has been created and is clear - check the working document
[ ] Doctrings (Google format) have been created and accurately describe the function's functionality
[ ] Unit tests pass, or if not present a new ticket to create tests has been created
[ ] Code runs The code runs on reviewer's machine and/or CDSW

Final approval (post-review)
The author has responded to my review and made changes to my satisfaction.

[ ] I recommend merging this request.

Review comments
Insert detailed comments here!
These might include, but not exclusively:

bugs that need fixing (does it work as expected? and does it work with other code
that it is likely to interact with?)
alternative methods (could it be written more efficiently or with more clarity?)
documentation improvements (does the documentation reflect how the code actually works?)
additional tests that should be implemented (do the tests effectively assure that it
works correctly?)
code style improvements (could the code be written more clearly?)
Do the changes represent a change in functionality so the version number should increase? Start a discussion if so.
As a review you can generates the same outputs from running the code

Your suggestions should be tailored to the code that you are reviewing.
Be critical and clear, but not mean. Ask questions and set actions.

It does not need merging. All features are in develop now.


Properly trigger suggest (textDocument/complete) and parameterHints (textDocument/) in suitable timings

Describe the bug
The python lsps are exemplary.

I need an approach to invoke editor.action.triggerSuggest and editor.action.triggerParameterHints at the same time, after a field completion, but I don't find a way other than letting client provide an extra commands, https://github.com/Myriad-Dreamin/tinymist/blob/f167ad152449c631e5946187efd2ba1772612f02/editors/vscode/src/extension.ts#L161. This is because https://github.com/microsoft/language-server-protocol/issues/1117.
I looked at rust-analyzer, and find that the parameter hints (signature help) keeps until exiting a function autocompletion. That is, if tinymist does same thing as ra, when I type text, tinymist will complete text(${content-arg}, fill: ${fill-arg}, stroke: ${stroke-arg}, ..), and I will continue finishing my function call for tabs and go to ${content-arg}, ${fill-arg}, and so on. however it is probably not what we would like to have, as we usually write text(fill: blue) and then add a content arguments by []. I may look at python lsps then.

Package/Software version:
tinymist extension version: v0.11.8.

link https://github.com/Myriad-Dreamin/tinymist/issues/257


Switch to jUnit5 for libs/dex & libs/pgwire

tests: Switch to Junit5 for libs/dex and libs/pgwire
tests: Remove public as jUnit 5 opts for package private

Haven't switched sql-parser as it requires junit-quickcheck-generators and we need to find a nice alternative for junit5.


fix(#1999): Improve accessibility in DocSearch results

Update to #2016 to improve accessibility in DocSearch results so that they better implement the WAI-ARIA ComboBox design pattern.

Fixes a few other docs issues identified with aXe DevTools.
Fixes a couple console error messages with themeSwitcherButton and hamburgerButton.

Relates to #1999 and #2016
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue 1999.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[x] Updated documentation (if it already exists for this component).
[x] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

yarn start:docs
Open http://localhost:1234/
Start screen reader, like VoiceOver.
Navigate to Search combobox.
Enter some text to search.
Use arrow down/up to navigate through search terms in dropdown.
Verify that option items announce without double voicing redundant content when subcategory matches suggestion title.

🧢 Your Project:
Adobe/Accessibility

Issue filed with Algolia: https://github.com/algolia/docsearch/issues/1014


As the CMS Editor I can design custom fields in the user profile for front-end users to answer when registering.

When users create accounts, they can be asked to complete a series of custom fields. Only user name and password are mandatory.

@ChrisMarsh82 this is done, you can close it.


Add support for encrypting records using web5.dwn.records.create()

This PR adds support for encrypting records using the encryption feature in DWN SDK.
The syntax for encrypting a record such that only the local active DID's keys can decrypt:
const { record } = await web5.dwn.records.create({
  data: 'Hello',
  encrypt: true,
  message: {
    'schema': 'http://schemas.xyz/message'
  }
});

The syntax for encrypting a record such that only bobDid's keys can decrypt:
const { record } = await web5.dwn.records.create({
  data: 'Hello',
  encrypt: { for: bobDid },
  message: {
    'schema': 'http://schemas.xyz/message'
  }
});

Will submit a new PR that includes encryption and decryption.


createJS movieclip gotoAndStop('frameNumber') is not stoping

Hello all,
Have issue with got and stop.  as i have stop the movieclip using gotoand stop but its not stooping at all.
i added the code part as well even the gotoplay also not working
canvas = document.getElementById("canvas");
exportRoot = new lib.TextStack19THModel();
//exportRoot.gotoAndPlay(10);
stage = new createjs.Stage(canvas);
stage.addChild(exportRoot);
stage.update();
createjs.Ticker.addEventListener("tick", stage);
exportRoot.gotoAndStop(exportRoot.currentFrame + 100);

Hi @karunakaran090,
I am currently looking into this issue however, I am unable to replicate your described symptom. On the surface, everything looks fine and from my created sample (tested: createjs-2015.11.26.min.js and latest version 1.0) it is working as expected.
Follow up questions:

What version of CJS libs are you using?

Are you getting console errors?

Are you loading assets, if so are they loaded and ready for use?

When does your code fire? (handleComplete)

Thanks!


ifconfig only grabs 4 attributes

Hi, on my system (kali / debian), ifconfig only gets 5 attributes:

interface
broadcast
multicast
running
up

I'd like to submit a pull request to fix them, but I wanted to know if you would consider it and if you're looking for help.  For example, on your match for ipv4_address, you use inet addr.  For this release and ifconfig, it uses simply inet for ipv4 and inet6 for ipv6.
For MAC address, it uses ether (I know it kind of seems unrelated) instead of HWaddr.  Right now in my app I'm using other modules and joining the objects together, but I'd like to simplify.  Plus Kali linux is a great use for your module, the control would be great!
If you're looking for help, I could probably either modify the regexp or throw a couple 'or's in there
Forgot to mention, AWESOME module!

This would be a great addition. Also, in the current package the ifconfig.up command throws error if netmask and broadcast address is kept empty.
There is no any option to run just ifconfg eth0 up or ifconfig wlan0 up.
@bakerface It would be great if you can add this feature or ask anyone who is interested to work on this feature.

This is an issue for me as well. Going to try and follow @dkran 's info so I can get the ip addresses. But if there are better regex expressions I should be using, then that would be great too.

This would be a great addition. Also, in the current package the ifconfig.up command throws error if netmask and broadcast address is kept empty.
There is no any option to run just ifconfg eth0 up or ifconfig wlan0 up.
@bakerface It would be great if you can add this feature or ask anyone who is interested to work on this feature.

I know this is an old thread, but i just created https://github.com/bakerface/wireless-tools/pull/56 which allows for a simple ifconfig wlan0 up etc.


Aki.Launcher.exe refuse to run EscapeFromTarkov.exe if *.bak file in user\mods dir.

SPT-AKI 3.7.5 Release.

Copy order.json to order.bak
Try to run Tarkov.

Originally written by Barlog_M

this seems unintentional, I'm looking into it.

Originally written by waffle.lord

so from what I can tell, we've made the decision to restore all .bak files before starting the game to ensure any patches that need to be applied are done to the original files.
the error above was due to not catching an exception from a .bak file resolving to a directory or non-existing file.

"something.bak" resolves to directory "something" which isn't valid
"something.json.bak" resolves to a non-existent file "something.json"

These exceptions are now logged and should be fixed in a future release.
Be aware that if you are creating any .bak files in your game directory, they may be restored at launch if they resolve to a valid file

Originally written by waffle.lord


Path character count limitations

Trying to migrate K13 site. Hotfix v13.0.130. Target is XbyK 29.3.3.
When the migration script finishes and I open the XbyK solution in Visual Studio, it fails to load due to character limitations. Is there an elegant way to resolve this?
C:\Users\hello\source\repos\XbyK_TestProject01\XbyK_TestProject01.csproj : error  : Cannot expand metadata in expression "$([MSBuild]::ValueOrDefault('%(FullPath)', '').StartsWith($([MSBuild]::EnsureTrailingSlash($(MSBuildProjectDirectory)))))". The item metadata "%(FullPath)" cannot be applied to the path "<path>". Path: <path> exceeds the OS max path limit. The fully qualified file name must be less than 260 characters.  C:\Program Files\dotnet\sdk\8.0.401\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.DefaultItems.targets

I think long paths are a more common issue with Xperience by Kentico projects - particularly in the CI and CD repositories because of the long file and folder names.
To fix this issue, enable long path support in Windows with Git configuration, or with Group Policy or a registry key change.

Thank you @seangwright . This has fixed the issue!


Heap Sort added

HEAP SORT
It is a sorting technique based on the heap data structure.
Heap is a complete binary tree, in which every level except the last, is filled
completely with its nodes, and nodes are far left.
We implement this sorting in an array using Max Heap, in which the parent node
value is greater than it child node values.
fixes #835

changes done @noviicee


hello 0.1.0-34612694+autotest_by_mosteo@kukumo

Created via alr publish with alr 2.0.2

Closed using alr 2.0.2 with reason: 'automated testing'


Complete Cellpose API

Where can I find the complete Cellpose API? I have been using the Cellpose API Guide at the following link:
https://cellpose.readthedocs.io/en/v1.0.2/api.html
But, seems to me that it is not complete, e.g. there is no mention of the io.save_masks() method at the above page. Would be nice to see all available methods.
Thank you,
Ved

good point this is added now

Thanks!

Thanks!


Extra blank lines in website

Description

When building the site locally, there are some extra blank lines below commands, when the only change being made is adding a channel.yaml file for the specific command in docs/_data/mesheryctlcommands/lifecycle/subcommands.
This page of the official site too shows the same issue below the verbose command.

Expected Behavior
The blank lines between commands should not be present.
Screenshots

When built locally(below channel and completion):

From the website:

Enviroment:

OS: MacOS
Browser: Chrome
Version: latest
Device: laptop

Thank you for opening this up, @metonymic-smokey. Is this an issue that you would like to address (take assignment of)?

@leecalcote I think we now know the root cause of this issue(thanks to @alonsolopezr!) so this can be closed?
Maybe let's add a line to the Documentation Contribution section stating files must be checked for newlines when adding new commands?
Thanks!

Very good. 🙂 yes, that sounds about right. 👍


[sw] mmio_region_set_bit32 requires readable registers.

Right now we don't really have a good way of setting a single bit on a write-only, W1C register; it may be a good idea to add such a variant?
I ran into this not being available in my SPI DIF, at any rate.

How about:
  mmio_region_write32(base_addr, offset, 1 << bit);

How about:
mmio_region_write32(base_addr, offset, 1 << bit);

How about:
mmio_region_write32(base_addr, offset, 1 << bit);

I think as we have dedicated library for MMIO operations, we might as well add a function there - will be more verbose than using mmio_region_write32. It is a good option though, thank you @sriyerg .

I agree. It also makes the semantics of expectations easier to read.


Replacing object reference before exporting causing problems

Hi,
If I have the following typescript code:
var obj = {
    someKey: 6
};

// For some reason I want to change the object
obj = {
    someKey: 7
};

export {obj};

it compiles to:
var obj = {
    someKey: 6
};
exports.obj = obj;
obj = {
    someKey: 7
};

So if I importing the object I get:
import {obj} from './some-file';
console.log(obj.someKey === 6); // true

But I was expecting 7. I.e. I was expecting the following JS code:
var obj = {
    someKey: 6
};
obj = {
    someKey: 7
};
exports.obj = obj;

Is this a bug or expected behavior?
I am using version 1.6.0-dev.20150731 but it has the same behavior in 1.5.3.

A maybe more realistic example:
import {configInterface} from './config-interface';
import {defaultConfig} from './default';
import {localConfig} from './local';
import {productionConfig} from './production';
import {defaultsDeep} from 'lodash';

var config: configInterface;

if (process.env.NODE_ENV === 'production') {
    config = defaultsDeep<Object, configInterface>(productionConfig, defaultConfig);
} else {
    config = defaultsDeep<Object, configInterface>(localConfig, defaultConfig);
}

export {config};

If I import config after compiling, it will be undefined.
If I try to create the variable inside the if statement (which I don't want) I get the following code:
typescript:
if (true) {
    var k = {};
} else {
    var k = {};
}
export {k};

compiles to:
if (true) {
    var k = {};
}
else {
    var k = {};
}

The current behavior is by design. we assume that the variable initialization happens at declaration site. We have talked about this before, and there is not a foolproof way of doing it. but i think a better approch is to emit the export declaration where it was in the input code relative to other statements, this way you at least have control over how it works.

As I mentioned in the comments on #4259, emitting the export assignment at the location of the export declaration will break the following code:
export { foo };
var foo = 1;

Export declarations will quite often appear before the entity they're exporting.
I don't know that there is a solution that doesn't have some problem, and I still think our current scheme is the best compromise. Another alternative is to put the assignment at the very end of the module, but emitting it at the place of the export declaration isn't a viable solution in my opinion.

Just so we have all the data in one place, here are the possible solutions and their issues:

Emit export assignment at variable declaration site. Only works when declaration has an initializer.
Emit export assignment at export declaration site. Doesn't work when export declaration precedes variable declaration and/or assignments. Also not clear what happens when there are multiple export declarations for the same variable.
Emit export assignment at end of module. Doesn't work when module initialization code makes calls to functions in other modules and those functions access the exported variable.
Rewrite variable references to export property references. Doesn't work when variable is exported by multiple names.

Probably the best alternative to our current scheme is to emit all the export assignments at the end of the module. But, really, we're just trading one set of issues for another.

@ahejlsberg if we can not, or would not, emulate the ES6 semantics correctly by rewriting references, emitting the export declaration in the place it is authored is easier for users to understand.
I would argue that the case reported in this issue is more common than an export declaration before the variable is assigned. also see related report in #4162.
Moreover, with allowing the export declaration to be emitted at the user specified location, the user has a chance to workaround it, by moving the export declaration to the end of the file, where as the current scheme, there is no way to solve it unless you declare a new variable, and export that instead, which is not intuitive.

Yes, emitting the export assignment at the location of the export declaration allows the user to work around the problem. But it doesn't really solve the problem. If we're going to change this, wouldn't we solve more problems by emitting the export assignments at the end of the module? Surely this would make even more real world code work correctly. I think there are far more cases of export declarations preceding the variable declaration (which would become broken) than there are cases of the module initialization code making calls to functions in other modules that access exported variables of the calling module.

Rewrite variable references to export property references. Doesn't work when variable is exported by multiple names.

Can you rewrite all variable assignments to also assign to the export?  No need for getters.  The local variable and all exports are kept in sync every time the exported variable is assigned.
export {foo as one, foo as two}
var foo = "hello";
foo = "world";

...generates:
var foo = exports.one = exports.two = "hello";
foo = exports.one = exports.two = "world";

Sorry to bump an old issue.

This should be working as intended in latest.


Android position elements

Hi guys.
I found 2 issues.

When i have container with flexDirection: column and i want to position one child elements as 'absolute' it disappears totally.
The same situation. I use flex: 4 for first child element, and flex: 1 for second, then i use negative margin for second element, and it disappears totally as well.
How to solve it?

We're cutting down on the number of outstanding issues, in order to allow us to focus. I'm closing this issue because it has been open for over 60 days with no activity. If you think it should still be opened let us know why. PRs are always welcome.


Does this support Minecraft servers?

I have a minecraft server hosted using Aternos and i want a custom domain, but I don't know if this supports it.
It does support NS which Aternos needs for custom domains, so I want to cornfim.

Nevermind, i see it does
Sorry!


issues with More Culling and first person model

issue with more culling:
MC version: 1.20.1
Fabric APi: 0.84.0
SMYS: 1.6.6
More culling: 0.81.1
How to recreate: install SMYS and more culling and set armor to be transparent. all parts of your skin covered by the transparent part don't render except for upper torso and what's under your boots.
without more culling:

with more culling:

issue with first person model:
MC version: 1.20.1
Fabric APi: 0.84.0
SMYS: 1.6.6
First Person Model: 2.2.3 (reffered to as fpm)
How to recreate: install SMYS and fpm and set armor to be transparent. While looking down with fpm enabled and transparent armor on, all parts of your skin covered by the transparent part don't render except for upper torso.

in third person it looks okay

I'm aware of a similar issue with Iris (see #19). It's most likely a result of some specific optimizations these mods make, and so far as I'm aware, isn't really something I can solve. I'll roll this issue into #19, as they seem to be different variants of the same problem.


Add a new method "getPresignedUrl"

https://docs.aws.amazon.com/aws-sdk-php/v3/guide/service/s3-presigned-url.html#creating-a-presigned-url

This would be useful for me. It would be great if you could add it?

Ping @frankdejonge

This doesn't really belong in Flysystem. It's only applicable to S3. There's a case to be made to have a DX layer for the AWS PHP SDK, but Flysystem is not the place for it. I'd recommend opening up an issue on the SDK repo for this and use the SDK directly.

Indeed. @neilcrookespm You can just extend League\Flysystem\AwsS3v3\AwsS3Adapter and add this tiny method by yourself. This is what I did in my project.

@grizzlylab that's one option. Alternatively you can use the Plugin mechanism to expose this on the Filesystem level, so no need to use the adapter directly (which is also advised not to do).

Ok


Added multi-channel devices and get/set power state

Hey @NickDub
Thanks for the PR, looks great.
Did a few small fixes, but i don't have a multichannel device to test; can you do a final test?
Thanks.-

Hey @NickDub
Thanks for the PR, looks great.
Did a few small fixes, but i don't have a multichannel device to test; can you do a final test?
Thanks.-

Hi @skydiver ,
Thanks for your quick feedback :wink:
Sorry, but I don't have a multichannel device to test, but for the code, I was inspired by these 2 projects:

http://pgeorgiev.com/how-do-sonoff-devices-work/
https://github.com/howanghk/homebridge-ewelink

I also added the following features:

Authentication error handling.
Automatic region changing, if it is not good (I'm in the 'eu' :yum:).
Channels number controlling, according to the UIID.

Bluesky (I'm skydiver too)

@NickDub
new additions looks great, love the login/region error retry 👏 👏
i did a very small changes, mostly related to linting
what do you think about merge this one?
thanks!

@skydiver
Nice job 👍
It's ok for me to merge!
Thanks

Thanks for the contribution @NickDub
Version 1.2.0 was published to npm!


[Bug]: ObsidianGit: Base path does not exist

Describe the bug
ObsidianGit: Base path does not exist
Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)
ObsidianGit: Base path does not exist

Steps to reproduce
ObsidianGit: Base path does not exist
Expected Behavior
ObsidianGit: Base path does not exist
Addition context
ObsidianGit: Base path does not exist
Operating system
Windows
Installation Method
None
Plugin version
2.25

Please show how you set up the plugin settings. Especially the "Advanced" section. Just pasting "Base path does not exist" everywhere is not helpful.
Are you sure ObsidianGit: Base path does not exist is the exact message from the console? I guess it's obsidian-git at the start instead.


Tests fail to compile: /usr/local/include/gtest/internal/gtest-port.h:270:2: error: C++ versions less than C++14 are not supported, etc

Description
Failure message:
In file included from /usr/ports/misc/lightgbm/work/LightGBM-4.0.0/tests/cpp_tests/test_main.cpp:5:
In file included from /usr/local/include/gtest/gtest.h:64:
In file included from /usr/local/include/gtest/gtest-assertion-result.h:46:
In file included from /usr/local/include/gtest/gtest-message.h:57:
/usr/local/include/gtest/internal/gtest-port.h:270:2: error: C++ versions less than C++14 are not supported.
#error C++ versions less than C++14 are not supported.
 ^
In file included from /usr/ports/misc/lightgbm/work/LightGBM-4.0.0/tests/cpp_tests/test_main.cpp:5:
In file included from /usr/local/include/gtest/gtest.h:65:
In file included from /usr/local/include/gtest/gtest-death-test.h:43:
In file included from /usr/local/include/gtest/internal/gtest-death-test-internal.h:47:
In file included from /usr/local/include/gtest/gtest-matchers.h:48:
In file included from /usr/local/include/gtest/gtest-printers.h:115:
/usr/local/include/gtest/internal/gtest-internal.h:636:54: error: too few template arguments for class template 'less'
  typedef ::std::map<std::string, CodeLocation, std::less<>> RegisteredTestsMap;
                                                     ^
/usr/include/c++/v1/__functional/operations.h:366:29: note: template is declared here
struct _LIBCPP_TEMPLATE_VIS less
                            ^
In file included from /usr/ports/misc/lightgbm/work/LightGBM-4.0.0/tests/cpp_tests/test_main.cpp:5:
In file included from /usr/local/include/gtest/gtest.h:65:
In file included from /usr/local/include/gtest/gtest-death-test.h:43:
In file included from /usr/local/include/gtest/internal/gtest-death-test-internal.h:47:
In file included from /usr/local/include/gtest/gtest-matchers.h:48:
In file included from /usr/local/include/gtest/gtest-printers.h:115:
/usr/local/include/gtest/internal/gtest-internal.h:613:22: error: member reference base type 'testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'int') is not a structure or union
    registered_tests_.insert(
    ~~~~~~~~~~~~~~~~~^~~~~~~
/usr/local/include/gtest/internal/gtest-internal.h:619:29: error: member reference base type 'const testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'const int') is not a structure or union
    return registered_tests_.count(test_name) > 0;
           ~~~~~~~~~~~~~~~~~^~~~~~
/usr/local/include/gtest/internal/gtest-internal.h:623:5: error: 'testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'int') is not a class, namespace, or enumeration
    RegisteredTestsMap::const_iterator it = registered_tests_.find(test_name);
    ^
/usr/local/include/gtest/internal/gtest-internal.h:623:62: error: member reference base type 'const testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'const int') is not a structure or union
    RegisteredTestsMap::const_iterator it = registered_tests_.find(test_name);
                                            ~~~~~~~~~~~~~~~~~^~~~~
/usr/local/include/gtest/internal/gtest-internal.h:624:41: error: member reference base type 'const testing::internal::TypedTestSuitePState::RegisteredTestsMap' (aka 'const int') is not a structure or union
    GTEST_CHECK_(it != registered_tests_.end());
                       ~~~~~~~~~~~~~~~~~^~~~
/usr/local/include/gtest/internal/gtest-port.h:1027:35: note: expanded from macro 'GTEST_CHECK_'
  if (::testing::internal::IsTrue(condition)) \
                                  ^~~~~~~~~
7 errors generated.

Environment info
LightGBM version or commit hash: 4.0.0
clang-15
pytest-7.3.1
FreeBSD 13.2

Thanks for using LightGBM.
Please provide the exact commands you ran which produced this error message. With just an error message, it's difficult for us to help you.

Complete log is here.

Can you explain the context of what this build is? It looks quite complicated.
For example, what are these patches?
===>  Patching for lightgbm-4.0.0
===>  Applying FreeBSD patches for lightgbm-4.0.0 from /usr/ports/misc/lightgbm/files

We'd very much appreciate if you could reduce this report to a minimal one that reproduces the problem you're facing.

This is a FreeBSD port build.
The patch applied is:
--- CMakeLists.txt.orig 2022-12-29 04:59:34 UTC
+++ CMakeLists.txt
@@ -507,7 +507,7 @@ endif(__BUILD_FOR_R)

 #-- Google C++ tests
 if(BUILD_CPP_TEST)
-  find_package(GTest CONFIG)
+  find_package(GTest)
   if(NOT GTEST_FOUND)
     message(STATUS "Did not find Google Test in the system root. Fetching Google Test now...")
     include(FetchContent)

It shouldn't matter for this issue.
The core problem is that googletest no longer supports c++11, and the project uses c++11. You should change that to c++20, for example.

Interesting! I guess we haven't experienced that in this project's CI because we don't preinstall googletest, and instead rely on CMake to pull in a specific, fairly-old version.
https://github.com/microsoft/LightGBM/blob/d73c6b530b39a18a3cacaafc4e42550be853c036/CMakeLists.txt#L607-L617
That version of googletest still supported C++11. That support was dropped in v1.12.1 (June 30, 2022.

You should change that to c++20, for example.

I absolutely don't support dropping C++11, C++14, and C++17 support yet in LightGBM. That would impact a lot of the project's users, and so far we haven't found that maintaining such compatibility has been a major issue. There is some discussion in #5691 if you're curious.
However... I'd definitely support upgrading to the latest release of googletest and using the C++20 standard when running those tests. That'd give us some minimal test coverage on C++20 (we currently have none) and make it easier for repackagers like you.
I'll put up a PR for that shortly, thanks for the report and sorry for the inconvenience.


Corrector: Add check that range given has the right buffer.

This checks that range given to Corrector have the right buffer.
Two instances in the code where ranges have source buffers that are not even source buffers are also fixed.
This superceedes #5093.

The changes look good to me, but the build is failing.

Before I waste time on this, could I have a final verdict between you and @pocke ?

Ah, sorry. Yesterday evening I was very tired and missed his remark. Let's go with the other fix.


fix bluetooth connection

🤦♂

Cherrypicked onto other branch, see https://github.com/LucidVR/opengloves-driver/pull/128


Catch TODO in autogenerated README

When we use chef generate cookbook, we get an autogenerated README.md containing this line:
TODO: Enter the cookbook description here.

Could we make a rule to catch this? Like there are rules to catch autogenerated lines in metadata.rb.

That would certainly be a useful check


add sort

Hi @Call-Me-G-Now, thanks for the PR! Have you tested all of it? If so, I'll merge it right away.

I'll close this as it's inactive. The functionality will soon be implemented.


lib/AST/RequirementMachine/Symbol.cpp:81: Assertion `!type->hasUnboundGenericType()' failed

Describe the bug
the following (invalid) test program crashes the compiler:
enum Selection<Element>
{
    case one(Element)
    case many([Element])
}
extension Selection?
{
}

$ ~/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-08-30-a/usr/bin/swiftc test.swift
error: compile command failed due to signal 6 (use -v to see invocation)
swift-frontend: /home/build-user/swift/lib/AST/RequirementMachine/Symbol.cpp:81: swift::rewriting::Symbol::Storage::Storage(Symbol::Kind, swift::CanType, ArrayRef<swift::rewriting::Term>): Assertion `!type->hasUnboundGenericType()' failed.
Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the project and the crash backtrace.
Stack dump:
0.      Program arguments: /home/ec2-user/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-08-30-a/usr/bin/swift-frontend -frontend -c -primary-file test.swift -target x86_64-unknown-linux-gnu -disable-objc-interop -color-diagnostics -new-driver-path /home/ec2-user/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-08-30-a/usr/bin/swift-driver -empty-abi-descriptor -resource-dir /home/ec2-user/.swiftenv/versions/DEVELOPMENT-SNAPSHOT-2022-08-30-a/usr/lib/swift -module-name test -o /tmp/TemporaryDirectory.GFWOdM/test-1.o
1.      Swift version 5.8-dev (LLVM 57827dcce6fa0fb, Swift 04f1cde82e1d1f3)
2.      Compiling with the current language version
3.      While evaluating request TypeCheckSourceFileRequest(source_file "test.swift")
4.      While type-checking extension of Selection? (at test.swift:6:1)
5.      While evaluating request GenericSignatureRequest(extension of Selection?)
6.      While evaluating request InferredGenericSignatureRequest(<Wrapped>, (null), extension of Selection?, {Wrapped == Selection}, {}, 1)

Steps To Reproduce
Steps to reproduce the behavior:

swiftc the given test program, on a recent nightly (i reproduced the crash on DEVELOPMENT-SNAPSHOT-2022-08-18-a and DEVELOPMENT-SNAPSHOT-2022-08-30-a.)

Expected behavior
the compiler should not crash
Environment (please fill out the following information)

OS: amazon linux 2
swift: DEVELOPMENT-SNAPSHOT-2022-08-30-a

cc @slavapestov

Nice catch! We shouldn't get as far as building the signature here; type resolution needs to reject a type. Should be an easy fix.

@slavapestov I can also look at this. Are you currently working on it, or could I attempt to fix it?

@simanerush You're welcome to take a look! I would start with changing the handling of UnboundGenericType in type resolution when the type resolution context is TypeResolutionContext::ExtensionBinding to match type aliases. We also reject
typealias Foo = Optional<Array>

but allow
typealias Foo = Array


No longer emit a FutureWarning when run with flake8<5; add a CI job to run with flake8<5

See discussion in:

https://github.com/PyCQA/flake8-pyi/pull/259#issuecomment-1268595970 (and following comments)
https://github.com/python/importlib_metadata/issues/409

Thank you! 👍


Test that img links are good

Img links are breaking: I think files are being re-uploaded but names are being changed. This should be caught by tests. (Not that it would stop someone from changing names, but we'd catch it after the fact.)

this falls into the realm of checking the integrity of our production Solr index, and to me, it does not seem to belong in the scope of the rspec test suite. Plus I wouldn't want something like this to block PR merges and deployments by slowing down Travis builds.
I like the idea of something like a SolrAuditor module that could run some reports for us. This could live outside of the web app altogether. Ideally, we could cron it, or trigger it from other events.
thoughts @mccalluc?

Chuck tells me this ticket is actually about validating image URLs in the cmless markdown, which would be appropriate for our rspec test suite I think.

@mccalluc i started in on this, but I'm missing a good way to extract all links from a given Cmless page.


python310Packages.qgrid: fix build

Description of changes
Probably due to some update, qgrid now fails to build because of a failed test.
I added it to disabledTests.
The test is very probably failing upstream too as the project is unmaintained.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 248350 run on x86_64-linux 1

8 packages built:

python310Packages.experiment-utilities
python310Packages.experiment-utilities.dist
python310Packages.qgrid
python310Packages.qgrid.dist
python311Packages.experiment-utilities
python311Packages.experiment-utilities.dist
python311Packages.qgrid
python311Packages.qgrid.dist

Result of nixpkgs-review pr 248350 run on x86_64-linux 1

8 packages built:

python310Packages.experiment-utilities
python310Packages.experiment-utilities.dist
python310Packages.qgrid
python310Packages.qgrid.dist
python311Packages.experiment-utilities
python311Packages.experiment-utilities.dist
python311Packages.qgrid
python311Packages.qgrid.dist


Parameter with a slash renders page when loaded client-side but not server-side

Versions

nuxt: 2.15.2
node: 15.5.1

Reproduction
https://codesandbox.io/s/blue-tdd-iwi0s?file=/nuxt.config.js
But hosted here it does not seem to have the issue
Steps to reproduce
When deployed on my computer, the setup above will load the URL http://<IP_ADDRESS>:3000/papers/saf%2Fsadf/authors client-side (using nuxt-link) but if I reload the page, the SSR will give me a page not found error. It's related to the %2F (slash) in the parameter that I want to work as ID.
What is Expected?
Server-side should render the same as client-side.
What is actually happening?
I get a page not found.
I have stripped my project right back and cannot see any differences in the code locally to what is in the reproduction link. Does anyone have any clues as to what could be causing this? It happens whether I run it from within a Docker container or not so I can't imagine it's any environment variables. This issue is really confusing me right now as to why it behaves differently in the codepen.

Indeed I download that codepen and run on my machine and the issue happens. I'm using yarn 1.22.5 and node 15.5.1
It's possible that it's related to the node version? I see the container config for codepen uses 14.

It looks to me as though the ufo package is being used to normalise the URL, but I'm not sure why. Client-side the URL would not render if I used unencoded slashes. So this could cause an inconsistency in route matching.

Furthermore, I've discovered in the latest version, in middleware I get the route option in the context and the matched array is empty if the parameter has slashes in it, even though the correct route loads.

So while I don't know why the SSR is not matching the front-end in some cases - in this one I am using an object to link in front-end router links, and the SSR side will just try and use the URL. Encoded or not, just using the URL seems to fail. Perhaps this is a Vue Router bug... but I see in the routes I could adapt a path to allow or slashes. e.g. /_cwa/users/:iri(.*) (adding the regex after the parameter)
Does Nuxt have an in-built way to do this for a route without having to use the router.extendRoutes method in the nuxt config?

I have same problem. When Nuxt do ssr it treats %2F as /. It means all websites using dynamic routers have bug in them if slug contains /. Escaping characters in standard way doesn't work. Anyone?

This is a really big issue for me - it's been open without a reply since 3rd March, sorry to be a pain and ping @pi0

I currently cannot use any version of Nuxt after 2.15.3 because of this issue.

Same issue, for now it is hard for me to switch nuxt version before 2.15.3. I will discover possible solutions and hope it will be fixed soon. In my case it appears when I'm navigating to route like /some-route/121%2F10401, where %2F automatically transforms to / and I get /some-route/121/10401 which is not found.

I found the temporary solution, but it is a weird. For my case using _.vue file with params.pathMatch works right, but if you have more than one nested level – it is bad idea.
Now my code looks like:
async asyncData({ params }) {
  const parameter = params.pathMatch

  // some code
}


docs: 📚 update gatsby-theme-antv version

Description

add document for interacting
update gatsby-theme-antv verison to 1.0.1-beta11
Update website

Motivation and Context

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Enhancement (changes that improvement of current feature or performance)
[ ] Refactoring (changes that neither fixes a bug nor adds a feature)
[ ] Test Case (changes that add missing tests or correct existing tests)
[ ] Code style optimization (changes that do not affect the meaning of the code)
[ ] Docs (changes that only update documentation)
[ ] Chore (changes that don't modify src or test files)

Self Check before Merge

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Pull Request Test Coverage Report for Build 341724868

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 340058236:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Use Hamcrest assertions instead of JUnit in  examples/employee-app (#1749)

Part of #1749
I've already signed OCA. It's an automation problem.
Backport 2.x

/oca-checked

/trigger


Not generating a web worker script

I have a setup with cra 3.4.3 with webpack 4.42.0 and storybook. I need the cra build to use comlink-loader and the storybook static build to ignore it (because when i run storyshots, the web worker loading fails with the following
Failed to construct Worker. Cannot be accessed from Origin null , logical since the page gets loaded using file:///
I changed my setup as follows to use singleton mode since i figured it would be easier to use different webpack configs for cra and storybook
the module that will become a worker
/* /src/workers/fuseSearch.worker.ts */

import Fuse from "fuse.js";
import { TRow } from "../types/Objects";

export async function fuseSearch(data: TRow[], options: any): Promise<TRow[]> {
    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
    //@ts-ignore
    // eslint-disable-next-line
    if (typeof self === "object" && self.document !== undefined && self.document === document) {
        console.log("running on main thread");
    } else {
        //were this a web worker, self would be instanceof DedicatedWorkerGlobalScope and self.document undefined
        console.log("running in web worker");
    }
    const { field, term } = options;
    const fuse = new Fuse(data, {
        keys: ["data", field],
        useExtendedSearch: true,
    });
    const searchTerm = term
        .trim()
        .split(" ")
        .join(" '");
    return fuse.search(`'${searchTerm}`).map(({ item }) => item);
}

I then call my worker as outlined in the documentation, with await
import { fuseSearch } from "../workers/fuseSearch.worker";
...
useEffect(() => {
    async function runSearch() {
        const result = await fuseSearch(available, { field, term });
        setFilterResult(result);
    }
    runSearch();
}, [...]);

my cra webpack config (using react-app-rewired)
//config-overrides.js
module.exports = function override(config) {
    // fails when i append to the rules array, prepending seems to go through
    config.module.rules.shift({
        test: /\.worker\.(js|ts)$/i,
        use: [
            {
                loader: "comlink-loader",
                options: {
                    singleton: true,
                },
            },
        ],
    });
    return config;
};

and my storybook webpack config simply doesn't declare a comlink-loader therefore skipping the web worker wrapping altogether.
problem 1
I see no webworker in my sources tab, and fuseSearch runs on the main thread! comlink-loader does not generate a script for the worker.
Is the config i outlined above valid? why is not generating a web worker script?
problem 2
When i changed the config override to have cofing.modules.rules.push instead of cofing.modules.rules.shift I got the following error message

Uncaught Error: Module parse failed: Unexpected token (5:36)
File was processed with these loaders:
* ./node_modules/comlink-loader/dist/comlink-worker-loader.js
* ./node_modules/eslint-loader/dist/cjs.js
* ./node_modules/eslint-loader/dist/cjs.js
You may need an additional loader to handle the result of these loaders.
| import { TRow } from "../types/Objects";
|
> export async function runWorker(data: TRow[], options: any): Promise<TRow[]> {
| 	const { field, term } = options;
| 	const fuse = new Fuse(data, {
at Object../node_modules/comlink-loader/dist/comlink-worker-loader.js!./node_modules/eslint->
loader/dist/cjs.js?!./node_modules/eslint-loader/dist/cjs.js?!./src/workers/fuseWorkerImpl.worker.ts (bootstrap:83)

which i assume is logical? because the comlink-loader needs to run first?
Edit: specified webpack and react-scripts versions

solved it. it was more of a webpack config problem, once i added a babel-loader entry it worked
config.module.rules.push({
		test: /\.worker\.(js|ts)$/i,
		use: [
			{
				loader: "comlink-loader",
				options: {
					singleton: true,
				},
			},
			/* below loader options section copied from<EMAIL_ADDRESS>*/
			{
				loader: require.resolve("babel-loader"),
				options: {
					customize: require.resolve("babel-preset-react-app/webpack-overrides"),
					babelrc: false,
					configFile: false,
					presets: [require.resolve("babel-preset-react-app")],
					cacheIdentifier: getCacheIdentifier(isEnvProduction ? "production" : isEnvDevelopment && "development", [
						"babel-plugin-named-asset-import",
						"babel-preset-react-app",
						"react-dev-utils",
						"react-scripts",
					]),
					cacheDirectory: true,
					cacheCompression: false,
					compact: isEnvProduction,
				},
			},
		],
	});
	```

solved it. it was more of a webpack config problem, once i added a babel-loader entry it worked
config.module.rules.push({
		test: /\.worker\.(js|ts)$/i,
		use: [
			{
				loader: "comlink-loader",
				options: {
					singleton: true,
				},
			},
			/* below loader options section copied from<EMAIL_ADDRESS>*/
			{
				loader: require.resolve("babel-loader"),
				options: {
					customize: require.resolve("babel-preset-react-app/webpack-overrides"),
					babelrc: false,
					configFile: false,
					presets: [require.resolve("babel-preset-react-app")],
					cacheIdentifier: getCacheIdentifier(isEnvProduction ? "production" : isEnvDevelopment && "development", [
						"babel-plugin-named-asset-import",
						"babel-preset-react-app",
						"react-dev-utils",
						"react-scripts",
					]),
					cacheDirectory: true,
					cacheCompression: false,
					compact: isEnvProduction,
				},
			},
		],
	});
	```

Just a comment, the original problem might have been that shift was used instead of unshift,
config.module.rules.shift({...})

shift removes the first element (pop-beginning), unshift adds a first element (push-beginning).


FIX - Vector sort now sorts nil at the beginning

Resolves #39.
So this fixes the issue but I'm not sure it's the best solution.  The problem is that if the user wanted to write their own sorter (by passing a block to sort), they'd still have to deal with the nil issue.  An alternative to the solution in this commit might be to add refinements to many of the core classes (NilClass, Fixnum, Float, etc) that allowed them to be sortable when nils are involved.
class NilClass
  include Comparable
  def <=>(other)
    return 0 if other.nil?
    -1
  end
end

That, of course, comes with its own set of issues.  Any thought on this?

Also, it looks like my editor is removing trailing whitespace (which is good according to https://github.com/bbatsov/ruby-style-guide#no-trailing-whitespace).

Good fix. My only concern is speed. Will this slow things down significantly? The problem is that rewriting sorting in Ruby is slow as it is. The if conditions should not slow it down further.

This commit should slightly reduce the number of evaluations that need to happen when your data doesn't have many nils.  Not sure if we can do much better.

This will work for now. Thanks. Merging.


RDF based Mapping Generation

Instead of use templates you can generate a RDF representation of the spreadsheets and easily transform the RDF data into YARRRML, RML or R2RML.
This can be done manually reading the data and generating the graph with rdflib or you can create a mapping for the "csv" files  (each sheet of the spreadsheets) and generate the rdf with tools like RDFizer or RMLmapper.
I can help too.

I mean this templates not the spreadsheet template.

Let's close this issue as we are not planning to do these changes


Kexec arm issue on hetzner cloud

Just creating a github issue to track what is being discussed on Matrix.
Trying to run nixos-anywhere against a hetzner cloud arm instance gets to kexec but isnt able to successfully come up afterwords and is unreachable until rebooted from console (where it boots back into original system).
Original Matrix message from nrv:
https://matrix.to/#/!NfgJ0qKGIQeNakJs:thalheim.io/$pO8CfIT0ubjIvT8kQYUUX_Owgf115LtZQ7BXa3GCir0?via=thalheim.io&via=matrix.org&via=beeper.com

Update from @Mic92 on matrix:

So I figured out that if you use Fedora and Debian instead of ubuntu than kexec works fine.
For ubuntu it works if you kexec is run without --kexec-syscall-auto, this currently is hardcoded in the kexec installer script

Will close this then

This one also makes it work now with older kernel. Tested on hetzner cloud (arm): https://github.com/nix-community/nixos-images/pull/155


WIP: Add Latin locale

@emagnier, @pejulian, so far, I have localised all (I presume) the keys from general.ts and some of the others I have found on the Internet.
Note that I have marked this PR as WIP because:

I’d like to localise all the keys from en.js;
I have left all my comments in la.ts that need to be tended (I have also commented out all the untranslated keys);
I used the key names based on PR #202, i.e. this PR should be merged after #202 is merged;
I still need to fix #196 in order to make the l10n work.

Just a quick status update: I am halfway through the Latin localisation. :smiley: I must confess, currently I skip some of the keys if I fairly quickly don’t find the Latin translation on the Internet. Most keys can be quite easily found on the Internet (either at vatican.va or Wikipedia or some old Latin documents/books like some biographies/vitæ.
Just for the info: this is how I check the progress: first I get the list of all keys (and just them) in en.ts, then I do the same in la.ts, compare them, count the keys in both and calculate the percentage of the coverage. The code below might be easier to understand. :smiley:
# Get the list of `la.ts` keys
grep -hPo "^\s+'*\K[^}': ]+(?='*:)" "src/locales/la.ts" | \
  sed '/^advent$\|^season$\|^$\|^feria$\|^sunday$\|^christmastide$\|^day$\|^octave$\|^epiphany$\|^before$\|^after$\|^ordinaryTime$\|^lent$\|^dayAfterAshWed$\|^holyWeek$\|^eastertide$\|^liturgicalColors$\|^GOLD$\|^GREEN$\|^PURPLE$\|^RED$\|^ROSE$\|^WHITE$\|^celebrations$\|^sanctoral$/d' | \
  sort > la_keys

# Get the list of `en.ts` keys
grep -hPo "^\s+'*\K[^}': ]+(?='*:)" "src/locales/en.ts" | \
  sed '/^advent$\|^season$\|^$\|^feria$\|^sunday$\|^christmastide$\|^day$\|^octave$\|^epiphany$\|^before$\|^after$\|^ordinaryTime$\|^lent$\|^dayAfterAshWed$\|^holyWeek$\|^eastertide$\|^liturgicalColors$\|^GOLD$\|^GREEN$\|^PURPLE$\|^RED$\|^ROSE$\|^WHITE$\|^celebrations$\|^sanctoral$/d' | \
  sort > en_keys

# Create some variables
missing=$(diff -y --suppress-common-lines la_keys en_keys | wc -l)
total=$(cat en_keys | wc -l)
done_percent=$((($total - $missing) * 100 / $total))

# Output the info
echo -e "\n$missing missing of $total ($done_percent % done)"

# Remove the auxiliary files
rm en_keys la_keys

# Example output
357 missing of 714 (50 % done)

I have gone through all the keys, but I have skipped the keys of the most of the blesseds and some of the not easily localisable (and verifiable by Google search). Also, I have left there many comments, many of which are TODOs and some of which mark some duplicates.

I have finished the Latin localisation. Note that I am not 100 % sure that every key translation is absolutely correct (but that said, this version is good enough for our initial version of the Latin locale). I am sure that most of them are correct, as I have sourced them from official documents (Holy See decrees, AAS or Notitiæ), some were sourced from some old biographies (Vitæ in Latin) or old liturgical calendars (pre-Vatican II or just after it, when all the Directories/Ordos were written in Latin). There might be some l10n issues, for which I’ll create (probably tomorrow) a separate issue and place into %backlog in order to solve the potential issues some time in the future [probably when I get a copy of the MR2004 and one or more Latin Ordo(s)].
I have intentionally skipped the localisation of Shrove Monday and Shrove Tuesday, as AFAIK there is no such season as Shrovetide in cal1969. The closest season to it is the pre-Vatican II season called Pre-Lenten Time (Septuagesima in Latin; see esp Catholic usage after 1969 heading). I think we can safely remove them from all locales, as these keys are not used at all.
I have just removed nearly all my comments from la.ts. The only comments that left, are notes that some keys are duplicates (I want to remove them while I deal with #175) and a string that I have not yet localised: christmastide.day, which in en.ts has the value {{day}} of Christmastide). When is this key used?
I’d like to ask you, @emagnier and @pejulian, to review and merge this PR as soon as possible (of course, I need to localise the chirstmastide.day key before that), because I’d to tend to the locales from the English language and English-speaking countries perspective (i.e. fix the #175 issue; see this comment). I believe that fixing #175 issue should be done before the new release @emagnier plans doing this month. And even la.ts will be modified by these changes.

Anyway, I still have not finished the Latin locale in dayjs, as I am not a good programmer and I wanted to finish the Latin locale in romcal first. The Latin locale in dayjs should be finished, but I need to create some tests and actually test it if its output is correct (I couldn’t somehow make it work). For more info on this matter see iamkun/dayjs#961 issue and iamkun/dayjs#966 PR.
As the dayjs Latin locale is not yet finished, I suggest to use en-GB locale for Latin for now. Also I’d like to note that even when the dayjs Latin locale is implemented, the week number within season will need to be converted into Roman numerals (see the romanise() in the dayjs locale, which I have found here).

While building romcal to test the Latin locale, I receive the following errors in the browser console:
la is not supported in romcal's date management library, trying to use la instead Locales.ts:191:14
Failed to load locale data for la. romcal will default to "en" locale data Locales.ts:202:14

Uncaught (in promise) ReferenceError: count is not defined
    anonymous Lodash
    b Locales.ts:262
    s tslib.es6.js:100
    s tslib.es6.js:81
    a tslib.es6.js:74
    a tslib.es6.js:70
    b romcal.bundle.es5.js:1
    n Seasons.ts:707
    s tslib.es6.js:100
    s tslib.es6.js:81
    a tslib.es6.js:74
    a tslib.es6.js:70
    n Seasons.ts:696
    B Seasons.ts:696
    s tslib.es6.js:100
    s tslib.es6.js:81
    a tslib.es6.js:74
    a tslib.es6.js:70
    B Seasons.ts:692
    A Calendar.ts:83
    s tslib.es6.js:100
    s tslib.es6.js:81
    o tslib.es6.js:71
    promise callback*u tslib.es6.js:73
    o tslib.es6.js:71
    promise callback*u tslib.es6.js:73
    o tslib.es6.js:71
    promise callback*u tslib.es6.js:73
    a tslib.es6.js:74
    a tslib.es6.js:70
    A Calendar.ts:73
    fetch Calendar.ts:73
    s tslib.es6.js:100
    s tslib.es6.js:81
    a tslib.es6.js:74
    a tslib.es6.js:70
    fetch romcal.bundle.es5.js:1
    calendarFor index.ts:259
    s tslib.es6.js:100
    s tslib.es6.js:81
    o tslib.es6.js:71
    promise callback*u tslib.es6.js:73
    o tslib.es6.js:71
    promise callback*u tslib.es6.js:73
    a tslib.es6.js:74
    a tslib.es6.js:70
    calendarFor romcal.bundle.es5.js:1
    <anonymous> index.html:50
    promise callback* index.html:39
    EventListener.handleEvent* index.html:27

I can’t deal with it.

Where is christmastide.day ({{day}} of Christmastide) used? That might need to be localised, but I have no idea when it is used (if ever).

I’d like to note that epiphany.before is in Latin set to {{day}} post octavam Nativitatis (English: {{day}} after the octave of the Nativity [of the Lord]), because AFAIK in Latin (and in Slovak) it something like {{day}} before Epiphany is not used. I suspect that it used to, but not anymore. And I think the same is true in all locales (in the Ordo 2018 for the US, they just simply have Christmas Weekday on 6 Jan, but that call all ferias weekdays).

@emagnier, could you double-check the date format in the Latin Missal (ed. typ. tertia)? Are the day of month numbers written as Roman numerals? If so, are they uppercase (XX) or lowercase (xx)? Are the month names written with uppercase firet letter (Ianuarius) or in all lowercase (ianuarius)?
Anyway, is there any other issue with this PR? Or you just simply want to remove the season of Epiphany first and then merge this PR

Day of month are in arabic format everywhere, except in the table index. Month is lowercase.
Let's merge it! Everything looks good, and also: good work for all this translation! 💪 🎉 🚀

[@tukusejssirs]
Where is christmastide.day ({{day}} of Christmastide) used? That might need to be localised, but I have no idea when it is used (if ever).

@emagnier, you haven’t answered me yet the above question. Is christmastide.day even used in the romcal codebase? A quick grep in the src/ folder did not match christmastide.day. Anyway, that key is the only one not localised in la.ts.


Invalid ISO time from wikidataTimeToISOString

Please consider the following date:
> wdk.wikidataTimeToISOString('-34000-00-00T00:00:00Z')
'+033999-12-31T22:00:00.000Z'

The return value is in the future instead of the past.
This Wikidata time return from the item "dog":
https://www.wikidata.org/wiki/Special:EntityData/Q144.json

vanilla JS and big dates are a bad matches, maybe we need this kind of work around https://stackoverflow.com/a/34897918/3324977

I disagree.
The output for this value should be: "-034000-01-01T00:00:00Z"
> new Date('-034000-01-01T00:00:00Z')
-034000-01-01T00:00:00.000Z

just published v5.9.5 with a patch (f5a2f9a) that should fix it: the issue is that years with more than 4 digits need different 0-padding. Can you confirm that it works for you?

Fixed. Thanks!


Rebuild for python39: rebase

Closes #9

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Migration should be done by the bot.


How does it compare to another library

I found this library but I previously used https://github.com/solidjs/solid-styled-components
And curious how this library compares. API seems very similar. Is the difference only in the API?
Thanks.

This is a library I modified for myself based on the mentioned library. The theme's reactivity etc. have been fixed.

Makes sense. :)
I would maybe PR that library too as its under official solid github handle and will have more reach.


KIM:add mechanism to prevent incompatible migration of Shoot-Spec

Description
To block critical changes in already published Shoot-CRs, KIM was to be extended to detect critical changes it would apply in the Shoot-CR  during the migration.
KIM is only allowed to migrate an existing SKR Shoot-CR if its generated Shoot-CR looks not different compared to the existing Shoot-Spec.
Incompatible changes will be detected and reported via either Metrics to the operational team or/and written to KIM logs.

AC:

[ ] KIM is able to detect incompatible changes in the Shoot-Spec before it's updating the Shoot-Spec on Gardener's Seed. cluster.

Reasons
Prevent incompatible Shoot-Spec changes to prevent service interruptions by KIM.
Attachments

Observation #1
Runtime CR contain the following labels:

kyma-project.io/broker-plan-id
kyma-project.io/broker-plan-name
kyma-project.io/controlled-by-provisioner
kyma-project.io/global-account-id
kyma-project.io/instance-id
kyma-project.io/region
kyma-project.io/runtime-id
kyma-project.io/shoot-name
kyma-project.io/subaccount-id
operator.kyma-project.io/kyma-name

Shoot generated from the runtime contains only those labels:- account

subaccount
account

It seems the migrator doesn't need to set the labels as they are not set on the shoot generated by KIM.

First run for the migration tool (AWS) with the matchers included:
spec/extensions: Expected
    <[]v1beta1.Extension | len:3, cap:4>: [
        {
            Type: "shoot-dns-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.dns.extensions.gardener.cloud/v1alpha1\",\"dnsProviderReplication\":{\"enabled\":true},\"kind\":\"DNSConfig\"}",
                Object: nil,
            },
            Disabled: nil,
        },
        {
            Type: "shoot-networking-filter",
            ProviderConfig: nil,
            Disabled: true,
        },
        {
            Type: "shoot-cert-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.cert.extensions.gardener.cloud/v1alpha1\",\"shootIssuers\":{\"enabled\":true},\"kind\":\"CertConfig\"}",
                Object: nil,
            },
            Disabled: nil,
        },
    ]
to match elements: [[shoot-dns-service].ProviderConfig:
	Expected object to be comparable, diff:   &runtime.RawExtension{
	  	Raw: bytes.Join({
	  		`{"apiVersion":"service.dns.extensions.gardener.cloud/v1alpha1","`,
	  		`dnsProviderReplication":{"enabled":true},"kind":"DNSConfig"`,
	+ 		`,"providers":[{"domains":{"include":["c-76a80a6.dev.kyma.ondeman`,
	+ 		`d.com"]},"secretName":"shoot-dns-service-aws-route53-secret-dev"`,
	+ 		`,"type":"aws-route53"}],"syncProvidersFromShootSpecDNS":true`,
	  		"}",
	  	}, ""),
	  	Object: nil,
	  }
	, [shoot-networking-filter].Disabled:
	Expected object to be comparable, diff:   &bool(
	- 	true,
	+ 	false,
	  )
	]
spec/kubernetes: Expected
    <string>: Kubernetes
to match fields: {
.KubeAPIServer:
	Expected
	    <string>: KubeAPIServerConfig
	to match fields: {
	.StructuredAuthentication:
		unexpected field StructuredAuthentication: {KubernetesConfig:{FeatureGates:map[]} AdmissionPlugins:[] APIAudiences:[] AuditConfig:nil OIDCConfig:&OIDCConfig{CABundle:nil,ClientAuthentication:nil,ClientID:*9bd05ed7-a930-44e6-8c79-e6defeb7dec9,GroupsClaim:*groups,GroupsPrefix:nil,IssuerURL:*https://kymatest.accounts400.ondemand.com,RequiredClaims:map[string]string{},SigningAlgs:[RS256],UsernameClaim:*sub,UsernamePrefix:*-,} RuntimeConfig:map[] ServiceAccountConfig:nil WatchCacheSizes:nil Requests:nil EnableAnonymousAuthentication:<nil> EventTTL:nil Logging:nil DefaultNotReadyTolerationSeconds:<nil> DefaultUnreachableTolerationSeconds:<nil> EncryptionConfig:nil StructuredAuthentication:nil}
	}

}

spec/cloudProfile: Expected object to be comparable, diff:   (*v1beta1.CloudProfileReference)(
- 	nil,
+ 	s"&CloudProfileReference{Kind:CloudProfile,Name:aws,}",
  )

spec/provider: spec/provider/controlPlaneConfig: expected should equal actual
metadata/labels: Expected
    <map[string]string | len:2>: {
        "account": "8cd57dc2-edb2-45e0-af8b-7d881006e516",
        "subaccount": "1b23b45b-7d90-401f-850a-42f873736160",
    }
to have {key: value}
    <map[interface {}]interface {} | len:1>: {
        <string>"extensions.extensions.gardener.cloud/shoot-oidc-service": <string>"true",
    }
metadata/annotations: Expected
    <map[string]string | len:5>: {
        "kcp.provisioner.kyma-project.io/operation-id": "40de55bb-8ec9-4e9c-92f7-c8fd5460d0c3",
        "kcp.provisioner.kyma-project.io/runtime-id": "096bdb3d-1f30-4d7c-b41f-c04cfa04871a",
        "compass.provisioner.kyma-project.io/operation-id": "40de55bb-8ec9-4e9c-92f7-c8fd5460d0c3",
        "compass.provisioner.kyma-project.io/runtime-id": "096bdb3d-1f30-4d7c-b41f-c04cfa04871a",
        "gardener.cloud/created-by": "system:serviceaccount:garden-kyma-dev:compass-provisioner",
    }
to have {key: value}
    <map[interface {}]interface {} | len:1>: {
        <string>"infrastructuremanager.kyma-project.io/runtime-id": <string>"096bdb3d-1f30-4d7c-b41f-c04cfa04871a",
    }%

The following problems were identified:

[ ] Matchers:

[ ]  We expect that labels generated by the converter will contain some labels which are not here ( e.g. extensions.extensions.gardener.cloud/shoot-dns-service)
[ ] We expect that shoot from gardener contains infrastructuremanager.kyma-project.io/runtime-generation which is not true
[ ] cloudProfile field should not be compared

[ ] Extenders

[ ] DNS extender generates extension yaml that is different from the one on Gardener so it can cause unwanted shoot reconciliation.

The following differences needs to be investigated:

[ ] unexpected field StructuredAuthentication

AWS after fixes:
spec/extensions: Expected
    <[]v1beta1.Extension | len:3, cap:4>: [
        {
            Type: "shoot-dns-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.dns.extensions.gardener.cloud/v1alpha1\",\"kind\":\"DNSConfig\",\"dnsProviderReplication\":{\"enabled\":true},\"providers\":[{\"domains\":{\"include\":[\"c081b56.dev.kyma.ondemand.com\"]},\"secretName\":\"aws-route53-secret-dev\",\"type\":\"aws-route53\"}],\"syncProvidersFromShootSpecDNS\":true}",
                Object: nil,
            },
            Disabled: nil,
        },
        {
            Type: "shoot-networking-filter",
            ProviderConfig: nil,
            Disabled: false,
        },
        {
            Type: "shoot-cert-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.cert.extensions.gardener.cloud/v1alpha1\",\"shootIssuers\":{\"enabled\":true},\"kind\":\"CertConfig\"}",
                Object: nil,
            },
            Disabled: nil,
        },
    ]
to match elements: [shoot-dns-service].ProviderConfig:
	expected should equal actual
spec/provider: spec/provider/controlPlaneConfig: expected should equal actual

GCP after fixes:
spec/extensions: Expected
    <[]v1beta1.Extension | len:3, cap:4>: [
        {
            Type: "shoot-dns-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.dns.extensions.gardener.cloud/v1alpha1\",\"kind\":\"DNSConfig\",\"dnsProviderReplication\":{\"enabled\":true},\"providers\":[{\"domains\":{\"include\":[\"d0c89ca.dev.kyma.ondemand.com\"]},\"secretName\":\"aws-route53-secret-dev\",\"type\":\"aws-route53\"}],\"syncProvidersFromShootSpecDNS\":true}",
                Object: nil,
            },
            Disabled: nil,
        },
        {
            Type: "shoot-networking-filter",
            ProviderConfig: nil,
            Disabled: false,
        },
        {
            Type: "shoot-cert-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.cert.extensions.gardener.cloud/v1alpha1\",\"shootIssuers\":{\"enabled\":true},\"kind\":\"CertConfig\"}",
                Object: nil,
            },
            Disabled: nil,
        },
    ]
to match elements: [shoot-dns-service].ProviderConfig:
	expected should equal actua

Remaining differences in Azure (changes in KIM required):
spec/extensions: Expected
    <[]v1beta1.Extension | len:3, cap:4>: [
        {
[
            Type: "shoot-dns-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.dns.extensions.gardener.cloud/v1alpha1\",\"kind\":\"DNSConfig\",\"dnsProviderReplication\":{\"enabled\":true},\"providers\":[{\"domains\":{\"include\":[\"a50de45.dev.kyma.ondemand.com\"]},\"secretName\":\"aws-route53-secret-dev\",\"type\":\"aws-route53\"}],\"syncProvidersFromShootSpecDNS\":true}",
                Object: nil,
            },
            Disabled: nil,
        },
        {
            Type: "shoot-networking-filter",
            ProviderConfig: nil,
            Disabled: false,
        },
        {
            Type: "shoot-cert-service",
            ProviderConfig: {
                Raw: "{\"apiVersion\":\"service.cert.extensions.gardener.cloud/v1alpha1\",\"shootIssuers\":{\"enabled\":true},\"kind\":\"CertConfig\"}",
                Object: nil,
            },
            Disabled: nil,
        },
    ]
to match elements: [shoot-dns-service].ProviderConfig:
	expected should equal actual

Observation number 2: Migrator app needs some adjustments to be more user friendly.
Problems:

Error handling: On Error Resume Next approach makes a lot of confusion. The current implementation doesn't stop processing a runtime when error occurs, even more it continues even it doesn't make sense to do so.
Going through all the runtimes on Gardener. It is very confusing: I want to migrate one runtime but see dozens of those on output.

Observation number 3
Runtime migrated by the migrator contains exactly labels that are defined in the (PR). GardenerCluster CR has a bit more labels:

operator.kyma-project.io/managed-by
operator.kyma-project.io/internal
kyma-project.io/provider
kyma-project.io/platform-region

The set of labels on GardenerCluster is the same as on Kyma resource. It seems the difference is insignificant due to the following:

it could be handy to search by provider but  broker-plan-name will be sufficient.
platformRegion is a property on the CR
managed-by has no real value (all CRs are managed by KIM)
internal has no real value


Adding snippets

In regards to #2 , here a some snippets to add to the package.
I've included 4 for Eloquent (taken from @adamwahan) (haso,hasm,belo,belt) and 2 for string translation (trans,transchoice) thinking this package could contain a little more then stuff for blade, but if you think it's not a good idea, feel free to delete them ;-)
Other then that, I've included snippets for blade, including:

{{-- Comments --}} with trigger: blcomment
{!! $foo or 'bar' !!} with trigger: blecho!
{{ $foo or 'bar' }} with trigger: blecho
@choice with trigger: blchoice
@each with trigger: bleach
@extends with trigger: blextends
@for with trigger: blfor
@foreach with trigger: blforeach
@forelse with trigger: blforelse
@if with trigger: blif
@include with trigger: blinclude
@lang with trigger: bllang
@php with trigger: blphp
@section with trigger: blsection
@inject with trigger: blinject
@unless with trigger: blunless
@unset with trigger: blunset
@while with trigger: blwhile
@yield with trigger: blyield

Let me know when this is done and I'll check through them :)

I think it is now. Those are all the one I could find :-) (I don't seem to be able to find a up to date, complete list of all the directives available for blade so at this point, I think I got them all! :)
That being said, if you do want to add non blade snippets, I think I can manage to find some more!

I'm going to merge this then rename the snippets directory to Snippets.


fix($parse): allow most latin letters as identifiers

Angular will today throw an execption if binding using an expression with extended latin letters as JSON object properties. Eg if $scope.a = {"hellö": world"}, you cannot bind to {{a.hellö}} although this is valid JSON.
This fix allows most extended latin letters by adding three ranges of latin letters in the isIdent(ch) check.
It's a compromise:

The division and multiplication sign split above ranges and are not allowed
Some more latin letters exist, but they are spread out and hunting them one by one might be too costly
Two tests supporting above statements are included.

Closes #2174

For anyone landing on this page, Unicode characters in identifiers are now supported inside AngularJS expressions (based on the identifier naming convention described in the ES2015 spec) by including the ngParseExt module.


Add kustomize manifest to deploy on cluster git server for GitOps demos

To support use cases that utilize a GitOps workflow, we need to be able to deploy a minimal git server on a demo cluster to stories the GitOps repos required for our Edge use cases.  Gitea is an open source "Lightweight DevOps Platform" that should cover our basic needs:

Host git code repositories
Provide a UI and automation to allow for code updates using code reviews and pull requests
Basic admin & user authentication to mimic real world workflows

This would not be a supported component of ODH but added to the list of infrastructure requirements for the AI at the Edge workflow
Acceptance Criteria:

[ ] Add a kustomize manifest that can deploy Gitea in a cluster
[ ] Document how to create users accounts and any non-standard requirements for deployment in an OpenShift cluster

This work may need to be put on hold to until we migrated to ACM with ArgoCD to support install phases.  This will allow us wait for the installation of the gitea operator before attempting to deploying a gitea server

Also, about Gitea -- I currently see https://github.com/opendatahub-io/ai-edge/issues/91 in the part of the PoC where a PR with new image SHA should be filed. Is that supposed to work somehow with Gitea, or do we need to stick with repositories in GitHub for now for that to work?


Fix textual summary links to arrays

We clearly lack relevant "does the page render?" specs that would've caught these problems... but solving that seems a bit beyond the scope of this fix. :confused:

@matthewd Yes, I've been trying to get folks to add those basic kinds of tests as they touch things . . . I will be more vigilante.

@matthewd does this fix https://github.com/ManageIQ/manageiq/issues/3982

@h-kataria thanks for the reminder.. I knew I'd forgotten something in the description. :sweat_smile:
Updated.


Avoid unnecessary calls to .toString in ViewData.checkAggregation

Please answer these questions before submitting a bug report.
What version of OpenCensus are you using?
0.12.2, but present up to current version
What JVM are you using (java -version)?
java version "1.8.0_111"
Java(TM) SE Runtime Environment (build 1.8.0_111-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode)
I ran into this randomly running a CPU profiler on a live instance running OpenCensus 0.12.2.  We use a custom exporter to export OpenCensus metrics into our own system.  I noticed that a lot of CPU time was spent in ViewData.checkAggregation (https://github.com/census-instrumentation/opencensus-java/blob/master/api/src/main/java/io/opencensus/stats/ViewData.java#L252).  Specific to our use case, we create Distribution objects with ~10,000 buckets to get high precision on our percentile calculations.   createErrorMessageForAggregation is called for each View instance, regardless if the error message will be used or not.  This then calls .toString on the Distribution instance, which calls toString on the bucket boundaries, which in my case was very large.

I agree that we shouldn't generate the error message if it isn't needed.  We should add a checkArgument method that takes an object that generates the message String lazily.

Thanks for investigating and reporting this issue. I'll send a PR to fix this soon.

Thank you!


add group ids and user ids in events yaml file

Description
Please provide a summary of the pull request and the issue it fixes. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.
Fixes #(add issue number here and remove parentheses)
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[ ] Within a week
[x] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[ ] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

It looks like Minu has already approved this earlier.
@bingzhang, please go ahead and merge this PR. It's also needed for #1024. Thanks.

Or maybe I will merge this time as I'm in the middle of reviewing the other PR. Thanks.


feat(deisctl): extend SSH to allow exec and docker

This feature extends 'deis ssh' to allow for an arbitrary command.
If specified, the command will be run as an SSH Exec call, instead
of opening a new shell.
Further, this adds 'deis dock', which is a convenience wrapper
for 'deis ssh THING docker exec -it THING COMMAND'. This now
becomes 'deis dock THING COMMAND'.
Testing:
After installation, you should be able to run all of the following commands:

deis ssh deis-builder: Works as normal.
deis ssh deis-builder ls -la: Runs ls -la on the host that is running builder.
deis dock deis-builder sh: Starts a shell on the deis-builder container.

s/deis/deisctl/ in description. :smiley:

Code LGTM. Looks like we have an added test for this, too. :+1:

I think I will fix it to run 'sh' by default when someone does deisctl dock CONTAINER with no command. It won't work on all Docker containers, but it will give a decent base experience. And it's consistent with @Joshua-Anderson 's deisctl ssh behavior.

I haven't looked at the code yet.  I am just working off the description in the OP... for consistency with other deisctl commands, should components be called out, for instance, as builder instead of deis-builder?

@krancour I believe that both builder and deis-builder should work, as deisctl matches units that contain the target string .

@technosophos This is a really useful feature, you might want to document it with alongside the segment on deisctl ssh.

The last commit makes sh the default command

+1. Most of the controller components are on alpine linux and may or may not have bash installed.

And, at @Joshua-Anderson 's suggestion, I added some documentation alongside the normal deisctl ssh docs in the troubleshooting guide.
I think I'm done with this now. Anything else, or can we LGTM and merge?

Code LGTM.

code LGTM


CONTROLLER service - multiple datasets - AlgotrithmExecutor

there is currently a bug in the AlgorithmExecutor, where if a request for an algorithm is to run on more than one datasets, it only runs for one of these datasets. To fix taht a change is needed to the node catalog.nodes_per_dataset return object

Moved to jira.


removes karobardaily dot com ads

@sulavaaa This commit deletes the filter for Kathmandukhabar

Sorry about that, I see it now didn't notice. Let me close this one and attempt again.


Support more than one instance in parallel per suite

🚀 Feature Proposal
Support more than one instance at a time per suite to achieve fully parallel executions as in a local machine.
Motivation
We are able to execute more than one suite with the concurrency argument but spec files inside every suite are running in serial mode and there is no way to run them in parallel mode.

Which framework? Cypress, Playwright or TestCafe?

Hi @alexplischke sorry for the late response, we are using playwright

Ah! You can configure that one in the saucectl suite instead:
suites:
  - name: "Chromium Mac13"
    platformName: "macOS 13"
    testMatch: [".*.js"]
    params:
      workers: 2
      browserName: "chromium"
      project: "chromium"


Karimh

Added a background and made my self-driving car!

Made changes for the function calls as pointed out by Dr. Heggen.


[1.12] Server crash

This happened when running a server and trying to create a new world.
Does not happen in single player.
https://gist.github.com/Aeron216/3ea7598d2705fac95ba31313d0310ead

Fixed in 1.1.1, thank you.

Thanks!


XFCE issues

Hi. Setting the wallpaper in XFCE does not work, instead of
xfconf-query --channel xfce4-desktop --property /backdrop/screen0/monitor0/image-path
I have to use
xfconf-query --channel xfce4-desktop --property /backdrop/screen0/monitor0/workspace0/last-image.
Another problem is, let's say I'm in the ~/Pictures directory and I do
wal -t -i image.jpg
the xfce configuration will receive only image.jpg which is not an absolute path therefore it's not going to work.
Can you please fix?

Can you run both of these commands and let me know the output?
# Change `/path/to/img.jpg` to a valid image.
xfconf-query --channel xfce4-desktop --property /backdrop/screen0/monitor0/image-path --set "/path/to/img.jpg"
echo "$?"

Basically, I want to know if the incorrect wallpaper command exits on an error or not.

I just pushed a fix for both issues to master.
wal now works all relative/absolute paths.
# Absolute path.
wal -i ~/Pictures/Wallpapers/10.jpg
wal -i ~/Pictures/Wallpapers/

# Relative path.
cd Pictures
wal -i Wallpapers/10.jpg
wal -i Wallpapers/

# File or current dir
cd Wallpapers
wal -i 10.jpg
wal -i .

# Backwards Dir or file
wal -i ../Avatars/1.png
wal -i ../Avatars/

I haven't tested the XFCE fix (I don't have xfce set up) but the basic idea is that if the first xfconf-query command fails we try a second xfconf-query command. Can you test this out and let me know if it works?

Sorry for the late response, I ran those commands you asked me for, here is the output.
`b1 ~/Pictures > ls
2Mzgepn.jpg       GoeuH3F.jpg  matterhorn_mountain_at_sunset-wallpaper-3840x2160.jpg  Screenshots
bbxvr1dnmg9y.jpg  HeMBCvx.jpg  oolHO8O.jpg
b1 ~/Pictures > xfconf-query --channel xfce4-desktop --property /backdrop/screen0/monitor0/image-path --set "/home/b1/Pictures/2Mzgepn.jpg"
Property "/backdrop/screen0/monitor0/image-path" does not exist on channel "xfce4-desktop". If a new property should be created, use the --create option.
b1 ~/Pictures > echo "$?"
1`
Nothing happened to my wallpaper.

Thanks for running those commands.
Try out the latest wal version and let me know if everything works, the output of echo $? tells me that the fix I implemented this morning should work. :)

I'll gladly do it when I get back from school.

Okay, now it works as a charm. Thank you for your work, this can be closed.
Have a nice day.