[Fix #9128] Fix an incorrect auto-correct for Style/ClassAndModuleChildren

Fixes #9128.
This PR fixes an incorrect auto-correct for Style/ClassAndModuleChildren when namespace is defined as a class in the same file.
It is still undetectable when class definition exists in the different file, but it can be detected in the same file. This PR solves the latter.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice fix! 🙇

Why does this autocorrect in cases where correctness cannot be verified?

@lopopolo there may be more context in https://github.com/rubocop-hq/rubocop/pull/4900, but while the cop is enabled, the autocorrection for the cop is marked as unsafe (https://github.com/rubocop-hq/rubocop/blob/afcbb6a077c82fbf6ddd62889fdbf671312e73f8/config/default.yml#L2812-L2840). My understanding is that without any config change, that does not autocorrect unless someone passes --auto-correct-all. I think this rules falls into the third bucket (

Some automatic corrections might change (slightly) the semantics of the code, meaning they’d produce code that’s mostly equivalent to the original code, but not 100% equivalent. We call such auto-correct behaviour "unsafe".

) of https://docs.rubocop.org/rubocop/usage/auto_correct.html. Hope that answers it, but let me know if I misunderstood!

What @siegfault said :-)
I would add that in this case, the code is never truly equivalent as it changes constant lookup.
X = 1
module Foo
  X = 2
  module Bar
    def self.info
      X
     end
  end
end
module Foo::Bar
  def self.info2
    X
  end
end
Foo::Bar.info # => 2
Foo::Bar.info2 # => 1


NodeJS SDK link points to deprecated version on NPM ...

it seems the link should point to the current NPM package, rather than the deprecated one. the deprecation message does show which one is the more current one.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9e6115e-3f3f-6ab2-446c-37edc567ecd3
Version Independent ID: 8bcf5f59-1412-abb3-275d-300b2c6929e0
Content: Develop with v3 APIs - Azure Media Services
Content Source: articles/media-services/latest/media-services-apis-overview.md
Service: media-services
Sub-service: rest-v3
GitHub Login: @IngridAtMicrosoft
Microsoft Alias: inhenkel

Thanks @phwecker I will take a look.

@phwecker Thanks for bringing this to our attention. Your feedback has been shared with the content owner for update.

This has been resolved. #please-close


The Offer must NOT include an explicit target attribute

The Offer must NOT include an explicit target attribute

https://github.com/International-Data-Spaces-Association/ids-specification/blob/eadbaa04bbed499eb76207e92e140535a5c367bc/model/model.md?plain=1#L70
but examples do contain the target, e.g. here:
https://github.com/International-Data-Spaces-Association/ids-specification/blob/ca29dbf6e720bf2a1304d6d4fd3dc963a49fcb10/negotiation/message/contract-request-message.json#L7
and also diagrams do contain the target as for example here:
https://github.com/International-Data-Spaces-Association/ids-specification/blob/main/negotiation/contract.negotiation.protocol.md#1-contractrequestmessage
--
Matthias Binzer

can someone tag this with v1 pre release, please?

Maybe we should distinguish the offers in the catalog from the offers within negotiation messages. The latter do have a target attribute.

Yes, I agree. That was exactly also my conclusion :-)

See #193

I think we should not add this redundancy. There is also examples in Dcat explaining the situation as we have it right now, meaning the target is given by the enclosing context:
https://www.w3.org/TR/vocab-dcat-3/#ex-odrl-policy
The above example does not explicitly define the ODRL Asset, so assumes the enclosing identified entity is the subject of the policy

Update from the meeting today:
Catalog -> Dataset -> hasPolicy (Offer) MUST NOT or SHOULD NOT (still discussing...) contain the target but rather use the enclosing datasetId.
The contractRequestMessage -> dspace:Offer (Offer) MUST contain the target (as there is no enclosing context).
The datasetId from the contractRquestMessage will be removed.
@sebbader @jimmarino

Update from the meeting today:

Catalog -> Dataset -> hasPolicy (Offer) MUST NOT or SHOULD NOT (still discussing...) contain the target but rather use the enclosing datasetId.

We agreed for "MUST NOT"


Fix balance update

Changelog to fix #375:-
Instead of calling processUpdatedBalances when the recipient is a managedAccount, calling it for all the transactions irrespective of the recipient on the confirmation of block notification.
So ,the managed Account Balance gets updated now irrespective of whether recipient was a managed account or a managed friend.
But when recipient is managed friend, the balance of that friend doesn't get updated until you leave that page (this was happening earlier also but not part of the issue). I have left a comment for that logic to be built.

managedFriend doesn't have balance in the redux store, but it should. I'm going to make a seaprate issue for that and work on it


dita -install does not work on Windows

org.dita.dost.invoker.Main assumes that the dita.dir property is defined (in processArgs). The dita.bat file does not define this, which causes an NPE and a silent failure. Since the dita shell script sets this property when calling java, should dita.bat do it as well?

This was reported in August, meaning it would have been on 2.0 or 2.1, but the related issue linked above showed that this error in 2.1 was resolved in 2.2. I think this issue is most likely obsolete as well, and can be fixed by upgrading to 2.2.

Double checked with 2.2.4 and I'm about to run dita -install on Windows without any errors - I'm assuming that this was resolved in 2.2 as with #2182. Marking this closed.


feat: WDS elevation borders

Hey team! Please add your planning poker estimate with Zenhub @KelvinOm @tbrizitsky


Update LiveTV for delete

Add method to delete anything to existing LiveTV delete feature. This allows the user to delte anything.

We already have delete for all content now, right?

Luke, sorry mate. Forgot to include the required changes to the videospringboard to support this functionality. The official app does not have ability to delete any item without these changes. It will only delete livetv recordings.
Feel free to adapt this to how you feel is best. But these are the entire changes required now.


Multiconnect Added to Connect-Maester

Fix to #196 to address providing a framework for beginning to add additional APIs as part of the connection process. Ref option 2 in #184. For ref option 1, I will build off this.

Instead of a flag for each service what do you think of an array of services. This will let us expand to include support for other modules (Exchange, Teams, etc..)

I am 50/50 on this one. I like the switch approach as it lets us set distinct parameter relationships, like $AzureEnvironment vs $Environment, but it makes it really bulky. I think the array could provide a simpler experience for most scenarios though, and things like environments, device code, etc... may just need an abstraction layer that references the approved cmdlet parameters.
Will update and push shortly. All great feedback, thank you.


Deploy iRODS disaster recovery solution on AWS

Deploy iRODS disaster recovery solution on AWS.  @cbcunc has created an AWS instance with iRODS installed for this purpose in the HydroShare AWS account at RENCI and will work with @phuongdm to deploy.  Here is the plan:

[ ] Make a backup copy of the hydroshareZone iCAT
[ ] Schedule 1 hour of HydroShare downtime
[ ] Create an iRODS UFS (unix filesystem, i.e. not S3) resource server on AWS called hydroAWSResc
[ ] Add hydroAWSResc as a child of hydroshareReplResc in  hydroshareZone
[ ] Trigger an iRODS rebalance operation of hydroshareReplResc that will ensure that hydroshareReplResc has two replicas: one under mdcRRResource and one under the hydroAWSResc
[ ] Verify the hydroAWSResc resource is operational and stable as the new HydroShare disastery recovery solution
[ ] Conclude downtime
[ ] Make a backup copy of the hydroshareZone iCAT
[ ] Find and unregister all data-at-rest on mdcRRResource from the hydroshareZone iCAT
[ ] Schedule 1 hour of HydroShare downtime
[ ] Set the iRODS status of mdcRRResource and its two leaf nodes to down
[ ] Permanently remove the mdcRRResource resource from hydroshareZone
[ ] Test and verify that powering down the Dell 730xd boxes does not bring the HydroShare website down
[ ] Conclude downtime

Two separate downtimes are scheduled to make sure the AWS solution is working satisfactorily and contains a full valid replication of hydroshareZone before taking the former mdcRRResource replication server offline.

In process of revising this to reflect plan previously sent to Mark, @phuongdm, @dtarb, @martinseul, and @rayi113 on 7/25/18 as well as additional details supplied by the iRODS team concerning itrimming the existing replicas at https://docs.irods.org/4.2.4/system_overview/tips_and_tricks/#decommissioning-a-storage-resource.


Use Title when presenting

In Datapoint, the Project and Subsystem names are used. Change to use "Title"

Currently it works in a way that project name and subsystem name are passed in url, eg:
/a/sensetif-app?tab=edit_datapoint&project=l2w-test-app&subsystem=room3&datapoint=battery
We have an endpoint get_datapoint which takes project_name and subsystem_name.
In order to render title of project and subsystem I would need to either:

Extend get_datapoint endpoint so it also returns that data (project/subsystem title)
Make 2 additional API calls to fetch project & subtitle

Closing this for now. I am entering a TODO in the source code for changes when Caching is done (maybe never).


Configure multiple node pools in Karpenter

Purpose

This pull request enhances the scalability, availability, and customizability of SPS Airflow by introducing multiple Karpenter node pool configurations for Kubernetes Pod Operator tasks, Airflow Celery workers, and core Airflow components such as schedulers and webservers. The revisions optimize resource distribution by aligning node characteristics with the demands of different tasks. Additionally, it improves scalability and reliability through Karpenter's autoscaling capabilities, which adjust node counts based on load, and enhances fault tolerance with topology spread constraints that ensure nodes/pods are distributed across multiple availability zones. The node pool settings are designed such that Kubernetes Pod Operator tasks and Airflow Celery workers leverage spot instances to enhance cost efficiency, while the core Airflow components like schedulers and webservers are hosted on on-demand instances for reliable operation. Furthermore, instance type configuration can be customized at deployment time to meet specific operational needs.

Proposed Changes

[ADD] New node selectors and affinity configurations tailored to the specific requirements of Kubernetes pod operator tasks, Airflow Celery workers, and core components like the scheduler and webserver.
[ADD] Integrated topology constraints within Karpenter to ensure nodes are strategically spread across multiple availability zones, enhancing the resilience and stability of our deployments.
[CHANGE] Updated Karpenter configurations in values.tmpl.yaml and karpenter_test.py to specify more precise selection criteria for instance types and families, such as c5, c6i, m5, m6i, r5, and r6i.
[FIX] Removed outdated and unused Terraform provider configurations.

Issues

#76

Testing

I deployed SPS into unity-venue-dev and manually verified that the karpenter_test DAG triggered the correct instances types to be provisioned and added as nodes to the EKS cluster. I also verified that the Airflow components were provisioned on the instance types specified in the Airflow Helm chart's values.

Hi Drew, I created a new EKS cluster (ok) and tried to deploy SPS on it, but I incurred in this error:
Plan: 71 to add, 0 to change, 0 to destroy. ╷ │ Error: Failed to determine GroupVersionResource for manifest │ │ with module.unity-sps-airflow.kubernetes_manifest.karpenter_node_class, │ on modules/terraform-unity-sps-airflow/main.tf line 780, in resource "kubernetes_manifest" "karpenter_node_class": │ 780: resource "kubernetes_manifest" "karpenter_node_class" { │ │ no matches for kind "EC2NodeClass" in group "karpenter.k8s.aws" ╵

Thanks for trying it out, @LucaCinquini! I found the same thing when I attempted a deployment on a fresh EKS cluster as well, which is why I converted this PR back to a draft but you were too quick for me :). I think the cause of the issue is that kubernetes manifest for the node class and node pools depend on a Karpenter-specific CRD in Kubernetes. How I plan to get around this issue is rolling the Karpenter installation into the SPS terraform-eks-cluster module. That way the CRD will be installed prior to the deployment of the terraform-unity-sps-airflow module. This should fix the dependency issue.


Add overflow-checking variants of arithmetic scalar dyn kernels

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Similar to arithmetic scalar kernels, we are going to add overflow-checking variants of arithmetic scalar dyn kernels.
Describe the solution you'd like

Describe alternatives you've considered

Additional context

Automatically added labels {'arrow'} from #2713


HDFS-14839: Use Java Concurrent BlockingQueue instead of Internal Blo…

1422

 Quality gate: Passed
 Everything looks good
Details

 Quality gate: Passed
 Everything looks good
Details


Inquiry Regarding Dataset Construction

I have some questions about the dataset construction in our code repository, and I would greatly appreciate your insights. Here are my inquiries:
1. Current Data Set Construction:
As of now, my dataset construction process is as follows:
I have used the leela_s program from spec2017 as an example. Initially, I executed the program with the three default inputs provided by spec2017, namely train, ref, and test, resulting in three traces.
Subsequently, I proceeded to partition the dataset.

However, as per the original research paper's recommendation, I attempted to select "hard-to-predict branches" from the validation set and encountered situations where these branches were not retrievable from the training set. Could you please offer guidance on how to address this issue?
2. Regarding Alberta Inputs:
I've reviewed the scenario where Alberta inputs are used for training. Alberta provides a wide range of inputs. Do I need to generate traces for all of these inputs to use them as part of the training set?
3.About the weight Parameter in benchmark.yaml:
I've noticed that the benchmark.yaml file includes a weight parameter within the simpoint section. I am curious about the significance of this parameter and how one should obtain it.
Thank you in advance for your assistance. Your expertise will be invaluable in resolving these dataset construction queries.

Sorry for the late reply.
1: do you mean that the branches that were deemed hard-to-predict in your validation set were not available in your training set? It seems like you need to expand your inputs to the programs to have higher coverage to generate better datasets.
2: The more inputs you have the better. The paper shows that the training accuracy improves with higher coverage in the training set. (although there is a point of diminishing return). For example, for the benchmark leela, training on 2 or 3 of Alberta inputs was enough to hit close to the same accuracy as training on all of Alberta inputs.
3: The weights would be provided by SimPoints. You can read about what those weights mean by reading the simpoints paper:
https://cseweb.ucsd.edu/~calder/papers/ASPLOS-02-SimPoint.pdf
If your methodology for getting sample traces for your simulation does not involve weights (e.g., if you're using random time-based sampling), then you can simply assign equal weights to all your traces.

 I appreciate your reply very much!
For Q1: I have already resolved this issue through static compilation.
For Q2: I am trying to incorporate Alberta inputs to generate sufficient data for training. I used train input in SPEC2017 leela_r program, but just reach 92% accuracy with Big-Branch. Is this result normal?
For Q3:  I have learned about SimPoint, it requires a  .bb (Basic Block ) file for clustering. How did you obtain this file? It seems there are no scripts related to this in the repository.
Q4: After obtaining SimPoint weights, how should Pin Tool be used for tracing?
I'm sorry, I have quite a few questions. In the future, maybe when my research results are written into a paper and published, I will mention you in the acknowledgments. . Once again, I sincerely appreciate your answers.

My e-mail is<EMAIL_ADDRESS>

Yes, static linking and turning off ASLR is needed to get stable PCs for offline training. In theory, the same could be achieving with additional metadata attached to the binaries to support dynamic linking & ASLR but I haven't done any work on that.
Q2: I don't remember the exact number. But from what I recall, the combination of 64KB TAGE-SC-L + Big-BranchNet for leela_r was higher. The MPKI reduction numbers are in the paper.
Q3: Yes, I do not have the copyright to redistribute the simpoint scripts so I left them out of right repo. There are many other sources for generating simpoints online if you search.  What I did specially was to use Intel pinplay
https://www.intel.com/content/www/us/en/developer/articles/tool/program-recordreplay-toolkit.html
It comes (or came) with a wrapper script for getting pinballs for simpoints for the programs. Then I had scripts (available in this repo), that ran those pinballs and produced branch traces.
Q4: refer to pintool tutorials online. I don't have time to support tools and scripts but I'm happy to answer questions about the research.

Thanks to your guidance, I have successfully used simpoint to get the results of the cluster and collect the data set.
I replicated your work on leela_r benchmark, but the result of tage_sc_l_64 obtained by using run_tage.py is very accurate, and the result of top10 hard branch on ref workload is as follows:

(This result seem unusually high? In your paper, tage_sc_l_64 is probably 70%~80% accurate for many hard branches in leela_s)

Then I used ref workload for training and testing, and selected the Big-BranchNet model to see whether the model could be overfitted, but it seemed that the model only reached about 90% accuracy, and the prediction result of hard branch top1 was as follows.

The training setting:

Could you tell me where I might have gone wrong? (I am collecting the data set of leela_s)
Best wishes!

I got the result of tage_sc_l_64 on leela_s of ref workload, it seems the same as the result on leela_r


README.icons

also - these icons should also have their own license file - the MIT-style licenses specifically cover "software and associated documentation files" but not art assets - i suggest that the CC-BY is the best fit with the license of this project
https://creativecommons.org/licenses/by/4.0/legalcode


Show comments in GUI?

Hi,
this is a nice project. Just one question came to my mind: Is there some way to also show comments from the YAML file for example?
Best

Hi,
thank you so much for showing interest to the project. I really appreciate it.
Can you tell me exactly what is your use case so I can help you better.
If what you want to do is show some Text like paragraphs or Headers inside the editor to organize or for documentation reasons currently we don't have this feature. but its a very good Idea and we can implement it

You can just add comments to the file like
# my additional comment
setting=true

It would be nice if those will be displayed also in the GUI :-)

ok .. I get it now.
Can you specify the exact location in the editor where you expect that comment to be positioned?

you want that comment to be related to the setting boolean property?

I just thought to place comments placed inside the YAML/TOML etc. placed above an property also above the property in the graphical gui

ok .. so its going to be something similar to when programmers add comments to functions, methods or a properties in order to show some extra information about it
similar to this:

you can add any simple comments or even markdown and its going to be rendered like this when you hover your mouse on that function:

so we can add a feature to add a comment to every property that exists in the guifier editor
and when you hover your mouse on the field it will look like this:

wdyt?

Looks amazing :-)

I really like the idea. thank you for sharing your ideas. I really appreciate it
I will work on it as soon as possible 👍🏽

just to keep you informed. I finished creating the description field param that enables the user to add description (comments) to the fields
you can use it in the Guifier easily this way
{
  "name": {
    "_value": "Alice",
    "_params": {
      "description": "the age of the game's main character"
    }
  },
}

now I am going to start in the parsing step. this step will involve taking the comments that resides on top of the property and add it to the description param of that field automatically

This proposal is very good and I am looking forward to it. When will it be officially launched? Will file comments in toml format also be supported?


Snapshot Timer

Configure the timer service when the configure-snapshot endpoint is called.
Signed-off-by: johnsonw<EMAIL_ADDRESS>

This change is

This is failing a few checks and needs a rebase on latest master due to conflicts.

Looks like Python format check failed

I am able to create and destroy an interval using graphql. Once the interval is created, a corresponding service will be running that will create the snapshot when the interval is reached. Here is a short video showing that the interval is created and is listed in the systemd timers. It also shows that a new snapshot is created within the first minute.

I will be following up shortly with images from the docker testing

Docker teting:

[root@iml-timer /]# systemctl list-timers
NEXT                         LEFT     LAST                         PASSED       UNIT                         ACTIVAT
ES
Wed 2020-09-23 14:21:32 UTC  11s left n/a                          n/a          iml-snapshot-11.timer        iml-sna
pshot-11.service
Thu 2020-09-24 14:17:06 UTC  23h left Wed 2020-09-23 14:17:06 UTC  4min 14s ago systemd-tmpfiles-clean.timer systemd
-tmpfiles-clean.service

[root@iml-timer /]# systemctl cat iml-snapshot-11.timer
# /etc/systemd/system/iml-snapshot-11.timer
# Automatically created by IML

[Unit]
Description=Create snapshot on filesystem zfsmo

[Timer]
OnActiveSec=60
OnUnitActiveSec=60
AccuracySec=1us
Persistent=true

[Install]
WantedBy=timers.target

[root@iml-timer /]# systemctl cat iml-snapshot-11.service
# /etc/systemd/system/iml-snapshot-11.service
# Automatically created by IML

[Unit]
Description=Create snapshot on filesystem zfsmo

[Service]
Type=oneshot
EnvironmentFile=/var/lib/chroma/iml-settings.conf
ExecStart=/bin/bash -c "/usr/bin/date +\"%%Y-%%m-%%dT%%TZ\" | xargs -I %% /usr/bin/iml snapshot create -b -c 'automa
tically created by IML' zfsmo 11-zfsmo-%%"

chroma=# select * from snapshot_interval;
 id | filesystem_name | use_barrier | last_run | interval
----+-----------------+-------------+----------+----------
 11 | zfsmo           | t           |          | 00:01:00

New snapshot at the top of the list:

Removing the snapshot interval:

[root@iml-timer system]# ls
default.target        getty.target.wants  multi-user.target.wants
default.target.wants  iml-timer.service   system-update.target.wants

[root@iml-timer system]# systemctl list-timers
NEXT                         LEFT     LAST                         PASSED    UNIT                         ACTIVATES
Thu 2020-09-24 14:17:06 UTC  23h left Wed 2020-09-23 14:17:06 UTC  16min ago systemd-tmpfiles-clean.timer systemd-tm
pfiles-clean.service

1 timers listed.

Testing ldiskfs with an rpm and docker install both yield the following:
[root@iml-timer /]# iml snapshot interval list
+----+------------+----------+-------------+----------+
| Id | Filesystem | Interval | Use Barrier | Last Run |
+====+============+==========+=============+==========+
| 3  | fs         | 1 minute | true        | --       |
+----+------------+----------+-------------+----------+

[root@iml-timer /]# systemctl list-timers
NEXT                         LEFT     LAST                         PASSED    UNIT                         ACTIVATES
Wed 2020-09-23 19:26:09 UTC  54s left Wed 2020-09-23 19:25:09 UTC  5s ago    iml-snapshot-3.timer         iml-snaps
hot-3.service
Thu 2020-09-24 18:54:51 UTC  23h left Wed 2020-09-23 18:54:51 UTC  30min ago systemd-tmpfiles-clean.timer systemd-t
mpfiles-clean.service

[root@iml-timer /]# systemctl cat iml-snapshot-3.service
# /etc/systemd/system/iml-snapshot-3.service
# Automatically created by IML

[Unit]
Description=Create snapshot on filesystem fs

[Service]
Type=oneshot
EnvironmentFile=/var/lib/chroma/iml-settings.conf
ExecStart=/bin/bash -c "/usr/bin/date +\"%%Y-%%m-%%dT%%TZ\" | xargs -I %% /usr/bin/iml snapshot create -b -c 'autom
atically created by IML' fs 3-fs-%%"

[root@iml-timer /]# iml snapshot list fs
+------------+---------------------------+---------------------------------+-----------+------------------------------+
| fs         | 3-fs-2020-09-23T19:24:09Z | Wed, 23 Sep 2020 19:24:10 +0000 | unmounted | automatically created by IML |
+------------+---------------------------+---------------------------------+-----------+------------------------------+
| fs         | 3-fs-2020-09-23T19:25:09Z | Wed, 23 Sep 2020 19:25:10 +0000 | unmounted | automatically created by IML |
+------------+---------------------------+---------------------------------+-----------+------------------------------+
| fs         | 3-fs-2020-09-23T19:26:09Z | Wed, 23 Sep 2020 19:26:10 +0000 | unmounted | automatically created by IML |
+------------+---------------------------+---------------------------------+-----------+------------------------------+


Volt support

Just wondering if it would be possible to configure the package to support Volt, do you think that would be possible?

@dcblogdev I tried that before. But, I couldn't find an option to register the Volt component with a module alias.
Also, this is works -
For Blog module -
BlogServiceProvider:

\Livewire\Volt\Volt::mount([
    \Module::getModulePath('Blog').'resources/views/livewire',
    \Module::getModulePath('Blog').'resources/views/pages',
]);

Volt Component: Blog/resources/views/pages/list.blade.php

Volt::route('blogs', 'list');

But, with the alias is not working -
Volt::route('blogs', 'blog::list');
Also, I am trying to find another way. Do you have any suggestions, please?

yes same for me. I can load a view but not with a module:: prefix.
So a work around to avoid conflicts would be to create a folder with the same name as the module.
So in the service provider:
Volt::mount(Module::getModulePath($this->moduleName).'resources/views/livewire');

then have a path like Modules/Base/resources/livewire/base/contact.php
Then a route like:
Volt::route('/contact', 'base.contact');

so doesn't look like anything you can do at the package level, I'll close this.


[Enhancement] V9: Group entities on Express Dashboard pages

So far, Express objects are just shown as fetche from the database.
There is no grouping by package or 'Custom Entry Locations'.
If you have more than 10+ Express objects - there is chaos.
We have some projects that rely on Express objects as the primary data holder, so our users can edit them by themselves.
My ideas would be:

Group them by the package that added them in a collapsable view (like the tree view?)
AND / OR
Group them by the  'Custom Entry Location' and maybe add the package handle as a default custom location so it's grouped there by default (I think this is the proper solution)

Additionally:

The files concrete\single_pages\dashboard\system\express\entities.php and concrete\single_pages\dashboard\express\entries.php are identical. They should share the same code after this change, maybe bie View::element() call

@KevinBLT
There is a related issue that I recommend commenting on.
https://github.com/concrete5/concrete5/issues/5573
The thread proposes "Object Groups" and the ability to reorder objects in the main list of objects and within groups. The proposed feature could be expanded to allow packages to create an object group and install Express objects into that group - which would address your issue.

IMO we should close this issue and get #5573 tied to a milestone. The original idea by @MrKarlDilkington was proposed June 2017, over 3 years ago.


turn counters on in release builds

What does this PR do?:
Sets counters unconditionally.
Motivation:
Always be able to make deductions about profiler internal state from the profiles it produces
Additional Notes:

How to test the change?:
Benchmark and reliability environments
For Datadog employees:

[ ] If this PR touches code that signs or publishes builds or packages, or handles
credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
[x] This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

This change has no real effect on overhead
benchmark-results.zip


incorporating non default signature into tf.estimator

A few questions around combining tensorflow_hub and tf.estimator. I am using a non default signature to embed words with ELMO. Is this the best practice for doing so?
elmo is instantiated in the model function:
def model_fn(features, labels, mode, params):
    #tf.logging.set_verbosity(tf.logging.ERROR)
    elmo = hub.Module("https://tfhub.dev/google/elmo/1", trainable=False)

    with tf.variable_scope("elmo"+ str(np.random.rand())):

    #Elmo requires padded raw text
    words = tf.string_split(features['text'])
    dense_words = tf.sparse_to_dense(sparse_indices=words.indices,
                                     sparse_values=words.values,
                                     default_value="",
                                     output_shape=[params.batch_size,
                                                   params.max_seq_len])
    #(B x W_t, 1024)
    elmo_embeddings = elmo(
        inputs={
            "tokens": dense_words,
            "sequence_len": tf.cast(tf.reshape(features['word_pad'],
                                  shape=[BATCH_SIZE,]), tf.int32)
        },
        signature="tokens",
        as_dict=True)["elmo"]

This does not use hub.text_embedding_column.
This also breaks viewing the graph in tensorboard.
Is this the best way to use hub in estimator?
Is there a way to view the graph in tensorboard?

The feature column api is high level and does not allows one to easily create arbitrary features, as so we followed the same pattern on hub.text_embedding_column and only designed it to give access to simple and clear features from a module (i.e. the default signature with default output).
However the fact that hub.text_embedding_column accepts a module_spec allows one to wrap more advanced logic in a feature column than was previously possible, so you could create a new module spec that wraps the specific case of elmo you are interested. E.g.:
def elmo_embedding():
  text_feature = tf.placeholder(tf.string)
  words = tf.string_split(text_feature)
  dense_words = ...
  elmo = hub.Module("https://tfhub.dev/google/elmo/1", trainable=False)
  elmo_embeddings = elmo(dense_words, signature=..., as_dict=True)["elmo"]
  hub.add_signature(inputs=text_feature, outputs=elmo_embeddings)

...
elmo_spec = hub.create_module_spec(elmo_embedding)
hub.text_embedding_column("text", elmo_spec)

PS 0: Your example using np.random.rand() looks very suspicious.
PS 1: Please open a specific bug about the tensorboard viewing.
PS 2: I have not tried the above snippet but it should document the overall idea.

Thanks -- This approach looks promising, reading through the source for hub.text_embedding_column helped me see what was going on.
Also confirmed the hub is not instantiated on every call of model_fn.
Re: PS0
Thanks --Just a slight hack to quickly evaluate in a notebook and avoid name collisions.


Crash in pcs due to gperf modifying environ variable

My application is using both gperf and pcs. gperf gets activated on these below environment variables. As per gperf behavior, gperf modifies 1st character of HEAPPROFILE (current ascii value + 128 ) in order to identify parent-child relationship amonst processes. HEAPPROFILE gets modified to ¯opt/pw/runtime/users/debug/hng_heap_profile from /opt/pw/runtime/users/debug/hng_heap_profile
This is causing crash in external.py as it tries to log all the environment variables and crashes due to non-ascii character found in HEAPPROFILE.
Can gperf manage parent-child relationship without modifying the the HEAPPROFILE env variable.
export HEAPPROFILE=/opt/pw/runtime/users/debug/hng_heap_profile
export HEAP_PROFILE_ALLOCATION_INTERVAL=0
export HEAP_PROFILE_INUSE_INTERVAL=0
Refer gperf--
https://github.com/gperftools/gperftools/blob/f47a52ce85c3d8d559aaae7b7a426c359fbca225/src/base/sysinfo.cc
Function: GetUniquePathFromEnv
Refer pcsd external.py --
Crash in function run of class CommandRunner.
https://github.com/ClusterLabs/pcs/blob/master/pcs/lib/external.py
Backtrace:
2018-09-12T05:51:57.473302+01:00 rohit-hng1 UniTaskC: ........Traceback (most recent call last):
2018-09-12T05:51:57.473716+01:00 rohit-hng1 UniTaskC: File "/sbin/pcs", line 9, in
2018-09-12T05:51:57.474022+01:00 rohit-hng1 UniTaskC: load_entry_point('pcs==0.9.158', 'console_scripts', 'pcs')()
2018-09-12T05:51:57.474187+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/app.py", line 191, in main
2018-09-12T05:51:57.475963+01:00 rohit-hng1 UniTaskC: cmd_mapcommand
2018-09-12T05:51:57.476214+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/cluster.py", line 89, in cluster_cmd
2018-09-12T05:51:57.477303+01:00 rohit-hng1 UniTaskC: cluster_setup([utils.pcs_options["--name"]] + argv)
2018-09-12T05:51:57.477559+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/cluster.py", line 312, in cluster_setup
2018-09-12T05:51:57.477749+01:00 rohit-hng1 UniTaskC: is_rhel6 = utils.is_rhel6()
2018-09-12T05:51:57.477940+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/utils.py", line 2191, in is_rhel6
2018-09-12T05:51:57.479232+01:00 rohit-hng1 UniTaskC: return is_cman_cluster()
2018-09-12T05:51:57.479467+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/common/tools.py", line 20, in wrapper
2018-09-12T05:51:57.495395+01:00 rohit-hng1 UniTaskC: cache["value"] = func()
2018-09-12T05:51:57.495677+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/utils.py", line 2195, in is_cman_cluster
2018-09-12T05:51:57.495861+01:00 rohit-hng1 UniTaskC: return lib_is_cman_cluster(cmd_runner())
2018-09-12T05:51:57.496012+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/lib/external.py", line 336, in is_cman_cluster
2018-09-12T05:51:57.496158+01:00 rohit-hng1 UniTaskC: "-v"
2018-09-12T05:51:57.496305+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/lib/external.py", line 395, in run
2018-09-12T05:51:57.496536+01:00 rohit-hng1 UniTaskC: for key, val in sorted(env_vars.items())
2018-09-12T05:51:57.496722+01:00 rohit-hng1 UniTaskC: UnicodeDecodeError: 'ascii' codec can't decode byte 0xaf in position 0: ordinal not in range(128)
2018-09-12T05:51:57.894707+01:00 rohit-hng1 UniTaskC: ....Starting Cluster...
2018-09-12T05:51:57.895124+01:00 rohit-hng1 UniTaskC: Traceback (most recent call last):
2018-09-12T05:51:57.895423+01:00 rohit-hng1 UniTaskC: File "/sbin/pcs", line 9, in
2018-09-12T05:51:57.895693+01:00 rohit-hng1 UniTaskC: load_entry_point('pcs==0.9.158', 'console_scripts', 'pcs')()
2018-09-12T05:51:57.895988+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/app.py", line 191, in main
2018-09-12T05:51:57.896235+01:00 rohit-hng1 UniTaskC: cmd_mapcommand
2018-09-12T05:51:57.896499+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/cluster.py", line 114, in cluster_cmd
2018-09-12T05:51:57.896756+01:00 rohit-hng1 UniTaskC: start_cluster(argv)
2018-09-12T05:51:57.897001+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/cluster.py", line 1000, in start_cluster
2018-09-12T05:51:57.897885+01:00 rohit-hng1 UniTaskC: if utils.is_cman_cluster():
2018-09-12T05:51:57.898186+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/common/tools.py", line 20, in wrapper
2018-09-12T05:51:57.898463+01:00 rohit-hng1 UniTaskC: cache["value"] = func()
2018-09-12T05:51:57.898712+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/utils.py", line 2195, in is_cman_cluster
2018-09-12T05:51:57.898954+01:00 rohit-hng1 UniTaskC: return lib_is_cman_cluster(cmd_runner())
2018-09-12T05:51:57.899213+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/lib/external.py", line 336, in is_cman_cluster
2018-09-12T05:51:57.899480+01:00 rohit-hng1 UniTaskC: "-v"
2018-09-12T05:51:57.899729+01:00 rohit-hng1 UniTaskC: File "/usr/lib/python2.7/site-packages/pcs/lib/external.py", line 395, in run
2018-09-12T05:51:57.899976+01:00 rohit-hng1 UniTaskC: for key, val in sorted(env_vars.items())
2018-09-12T05:51:57.900252+01:00 rohit-hng1 UniTaskC: UnicodeDecodeError: 'ascii' codec can't decode byte 0xaf in position 0: ordinal not in range(128)
2018-09-12T05:51:59.773509+01:00 rohit-hng1 UniTaskC: Waiting for pacemaker to start1...cpuset.sh: moved 146 tasks among 343

Thanks for filing this issue. Yes ideally we'd do something about this. But note that anybody can set non-ascii environment variable values. So it is your code that gets confused by non-ascii values that needs to be fixed regardless.

I think it is time for us to stop doing this "set bit 7" thingy. But your python stuff failing on arbitrary ascii bytes trying to dump environment variable is the problem that needs fixing anyways.


NFCGATE on WearOS  NFC(HCE) SUPPORT

WearOS smartwatches with NFC only support NFC payment (Card emulation mode), not NFC tag reading (Reader/Writer mode) . Is this true?
I've heard this is an WearOS issue that Google need to allow Reader/Writer mode from OS level before I can develop a smartwatch NFC tag app. Is this true? I see Android smartphones all support NFC tag reading/writing (Reader/Writer mode), either natively or via app and Android OS open to NFC app development through API and device.
This will be a real roadblock if it is true that WearOS smartwatch can't read/write NFC tags due to WearOS restriction.
PS. I managed to open nfcgate but with nfc closed. When I toggle on nfc , nfcgate crash. I heard manifest is incorrect for WearOS???? Strange thing smart card emulator https://frankmorgner.github.io/vsmartcard/ACardEmulator/README.html  works with nfc toggled on. ( did not test actual functionality) . Last thing is possible root on samsung galaxy watch 4? Any help will be much appreciated.  🙌

@kleest @malexmave @DanielAW  @UweM
ANY SUPPORT ON THIS ISSUE??
KEEP UP THE GOOD WORK BLESSINGS

NFCGate depends on the NFC capabilities and APIs that are provided by the operating system. So, using wearOS as a reader device might not be possible due to hardware limitations (cf. https://issuetracker.google.com/issues/213599626). If HCE APIs are available for "regular" apps (not only the system-provided payment apps), using NFCGate on a wearOS device as tag in relay or replay mode should be possible. However, for emulation of static tag data, root access and an Xposed-compatible hooking framework is required, which is not that common on wearOS devices.

Too bad they limit the device 😪,  thanks for clarification.

Hi @kleest , THIS GUY USES GW4 AND GW6 TO EMULATE A TESLA KEYFOB.
https://github.com/pccr10001/TeslaWearKey
I think issue have been fix under the radar and if you have the right AndroidManifest.xml( check out above link) apps should now work.???
Is this correct ? I try now 2.4.2 on gw4 and it only opens when nfc is turned off but after it opens you can toggle nfc on again and app show green except xposed with is normal as it is not rooted yet ( https://xdaforums.com/t/rooting-galaxy-watch4.4452343/page-3 ),when i try to relay app crash and also clone mode dont detect nfc card this is expected as wearos limitation for reading. Is this to do with  or android:name="android.hardware.nfc.hce" . Thanks

@Flipo82 HCE was never an issue, not all wearOS devices can read tags. NFCGate needs changes to support such devices.


Added a service to list packages

This will list out packages with the name, number and GUID.
I have another service coming that will build the package for the number you specify

I'm not sure if this (and #96) would fit as part of the core of Chauffeur for v7 or it'd be better as a plugin (either part of ExternalPackages or just a stand alone completely).
I've nearly completed the migration of Chauffeur to v8 and the packaging engine is quite changed so I'm rather hesitant about adding something that is so heavily tied to it into the core only to have to migrate it shortly.

I'm not sure if this (and #96) would fit as part of the core of Chauffeur for v7 or it'd be better as a plugin (either part of ExternalPackages or just a stand alone completely).
I've nearly completed the migration of Chauffeur to v8 and the packaging engine is quite changed so I'm rather hesitant about adding something that is so heavily tied to it into the core only to have to migrate it shortly.

In that case I'm out. I have no idea how to code in f# and its too large a task to take on although I had hoped to share what I'd done with the community
I'll still use what I've learned, but I dont think I can make this a sharable product?

You can create your own NuGet package which contains the code (and has the dependency of Chauffeur) because Chauffeur just picks up everything in the bin folder to load, so there's no need to discard it.


Use utf-8 if UNICODE is defined

See bitcoin/bitcoin#13426
Enable unicode support is UNICODE is defined.

This won't cause any issues when down/upgrading from 0.16 to 0.17 while keeping the datadir?

@MarcoFalke The user must change their config file to be utf-8 encoded if the file contains any non-ascii characters in it. Before 0.16, they are read as ansi-encoded characters on Windows.

I'll added the caution in the description of bitcoin/bitcoin#13426

@MarcoFalke Do you mean applying this change to 0.16?

This no longer checks for UNICODE, so @MarcoFalke 's question should be re-answered (and the PR description updated)

@luke-jr If we don't backport this change into older version of Bitcoin Core. Then there would have no problem because it's using utf-8 facet to imbue path on current master.

Why is it a problem to backport now?

Because it use MBCS encoding on boost::filesystem::path on Bitcoin Core <= 0.17. It changed to utf-8 by bitcoin/bitcoin#13877


Question about fieldPaths (feature request?)

Clarification on fieldPaths, if a document with structure something like:
//
{
  name: 'test',
  relationships: [
    { type: 'person', age: 32 },
    { type: 'asset', value: 15 }
  ],
}

was queried with a typeMap of
'typeMap' => [
  'root' => 'MyProject\MyClass',
  'array' => 'array',
  'document' => 'array',
  'fieldPaths' => [
    'relationships' => 'MyProject\MyRelationship'
  ],
],

That all works as expected. But, what if you wanted to use a different class depending on the type value? I understand if I had control of the schema, I could potentially use __pclass property... but in the scenario where the schema is fixed, could a different method be used? It doesn't seems like the fieldPaths option has any more verbose logic to use a field name to interpret the class... but perhaps there would be the ability to have the __pclass property able to be specified at query type? So something like
'typeMap' => [
  'root' => 'MyProject\MyClass',
  'array' => 'array',
  'document' => 'array',
  'fieldPaths' => [
    'relationships' => '$type' //this says to use the field "type" instead of "__pclass"
  ],
],

I suppose this example means that the field $type still has to be the fully qualified php class name, so I'm not sure it is really that helpful anyway...
Just wanted to know if you guys have come across this feature request?

The functionality you're requesting is roughly how discriminator fields are used in Doctrine ODM to support single collection inheritance. By default, a class name would be stored, but discriminator maps can also be defined in the PHP model in order to store shorter strings in the database field.

I suppose this example means that the field $type still has to be the fully qualified php class name, so I'm not sure it is really that helpful anyway...

In your example, the type field would effectively be treated like __pclass with two notable differences:

type would presumably be a string instead of a BSON binary type used for __pclass
During BSON decoding, the driver would leave the type class in place, in contrast to how __pclass gets omitted from the data passed to the bsonUnserialize() method.

I'd encourage you to look into BSON codecs, which are implemented in the PHP library. The __pclass and fieldPaths functionality will likely stick around for backwards compatibility, but we don't have plans to improve upon them further. The codec API allows for more control over BSON encoding and decoding since the logic can be implemented in PHP userland code.


Gitter badge.

Gitter badge.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0f5193a) 0.00% compared to head (4c59954) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #10   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files          6       6
  Lines        145     145
  Branches      15      15
=====================================
  Misses       145     145

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Doesn't work if multiple popovers on page

Haven't dug into it, but I assume it's because of const target = document.querySelector('[data-selectable]') etc.
My use case is that I have a bunch of table rows representing back-end data (e.g., each one has an ID) so I'd like to have a separate popup for each row. The popup may change based on row data (e.g., a flag) or the column I'm selecting text in.
FWIW, what I've ended up doing for now is putting the <SelectionPopover> at the end of my table, getting the selection manually, and using the Selection object to walk back up the DOM tree to find info in the containing elements (e.g., I have data-id and data-type etc. in the right places). From there I use state to determine what to render in the popover.

Eesh yes that's not ideal. I'm no longer using this lib but would be happy to review PRs. Sorry for the long time delayed response.


runtime/race: say where the memory block was allocated

C++ ThreadSanitizer describes where the memory involved in report was allocated:
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/lit_tests/malloc_stack.cc?revision=187875&;view=markup

It would be useful to do the same for Go.

C++ ThreadSanitizer can also pronounce the name of the global (if the race in on
global). Look if it's possible in Go.

Current state: https://golang.org/cl/19958 is too complex, we need to prototype an approach with threading of PC through allocation functions. It may lead to much simpler code.


Fix merge conflict from branch-24.02

Fixes the merge conflict flagged in #10543.  Only conflicts were pom.xml files where we take the 24.04 version.
NOTE: This needs to be merged with a merge commit, not squashed!

build


Windiow无法启动项目

Affected version
0.15.1
Flutter versions
3.13.9
No same issues found.

[X] Yes, I search all issues but not found.

Steps to Reproduce

创建一个空项目
根据文档，添加了依赖，并拉取了依赖
根据文档，修改了main.dart的代码
flutter run // ❌ 失败了

Code example
import 'package:flutter/material.dart';
import 'package:webf/webf.dart';
import 'package:webf/devtools.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    final MediaQueryData queryData = MediaQuery.of(context);
    final Size viewportSize = queryData.size;

    return Scaffold(
        body: Center(
      child: Column(
        children: [
          WebF(
            devToolsService:
                ChromeDevToolsService(), // Enable Chrome DevTools Services
            viewportWidth: viewportSize.width -
                queryData.padding.horizontal, // Adjust the viewportWidth
            viewportHeight: viewportSize.height -
                queryData.padding.vertical, // Adjust the viewportHeight
            bundle: WebFBundle.fromUrl(
                'http://<IP_ADDRESS>:8080/'), // The page entry point
          ),
        ],
      ),
    ));
  }
}

Expected results
Flutter assets will be downloaded from https://mirror.sjtu.edu.cn/. Make sure you trust this source!
Connected devices:
Windows (desktop) • windows • windows-x64    • Microsoft Windows [版本 10.0.23575.1001]
Chrome (web)      • chrome  • web-javascript • Google Chrome 118.0.5993.118
Edge (web)        • edge    • web-javascript • Microsoft Edge 119.0.2151.32
[1]: Windows (windows)
[2]: Chrome (chrome)
[3]: Edge (edge)
Please choose one (or "q" to quit): 1
Launching lib\main.dart on Windows in debug mode...
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/line_break.dart(10,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderLineBreak' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/values/length.dart(192,44): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/values/length.dart(195,87): error GC2F972A8: The argument type 'AbstractNode' can't be assigned to the parameter type 'RenderBoxModel'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/values/length.dart(198,52): error G4127D1E8: The getter 'isScrollingContentBox' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/values/length.dart(200,38): error G4127D1E8: The getter 'renderStyle' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/svg/rendering/empty.dart(9,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderSVGEmpty' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/svg/rendering/container.dart(10,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderSVGContainer' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/svg/rendering/text.dart(9,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderSVGText' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/svg/rendering/root.dart(11,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderSVGRoot' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/position.dart(109,46): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/position.dart(111,16): error GE5CFE876: The method 'markChildrenNeedsSort' isn't defined for the class 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/position.dart(125,48): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/position.dart(127,18): error GE5CFE876: The method 'markNeedsLayout' isn't defined for the class 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/position.dart(144,48): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/position.dart(146,18): error GE5CFE876: The method 'markNeedsPaint' isn't defined for the class 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/positioned.dart(18,34): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/positioned.dart(21,19): error G4127D1E8: The getter 'clipX' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/positioned.dart(21,36): error G4127D1E8: The getter 'clipY' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/positioned.dart(22,31): error G4127D1E8: The getter 'scrollLeft' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/css/positioned.dart(22,51): error G4127D1E8: The getter 'scrollTop' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(22,9): error G4699A223: Type argument 'TextParentData' doesn't conform to the bound 'ContainerBoxParentData<ChildType>' of the type variable 'ParentDataType' on 'RenderBoxContainerDefaultsMixin'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(260,31): error G7C168647: Property 'dx' cannot be accessed on 'Offset?' because it is potentially null. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(261,31): error G7C168647: Property 'dy' cannot be accessed on 'Offset?' because it is potentially null. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(264,26): error G4127D1E8: The getter 'scale' isn't defined for the class 'TextParentData'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(265,26): error G4127D1E8: The getter 'scale' isn't defined for the class 'TextParentData'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(266,26): error G4127D1E8: The getter 'scale' isn't defined for the class 'TextParentData'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(273,70): error G44692867: A value of type 'Offset?' can't be assigned to a variable of type 'Offset' because 'Offset?' is nullable and 'Offset' isn't. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/paragraph.dart(273,95): error G4127D1E8: The getter 'scale' isn't defined for the class 'TextParentData'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/widget.dart(12,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderWidget' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/event.dart(18,23): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/event.dart(21,18): error G4127D1E8: The getter 'gestureDispatcher' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/event.dart(24,18): error G4127D1E8: The getter 'gestureDispatcher' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/sliver_list.dart(14,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderSliverListLayout' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/replaced.dart(15,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderReplaced' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/replaced.dart(166,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderRepaintBoundaryReplaced' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(868,28): error G4906CC7E: The parameter 'child' of the method 'RenderBoxModel.dropChild' has type 'RenderBox', which does not match the corresponding type, 'RenderObject', in the overridden method, 'RenderObject.dropChild'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(180,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderLayoutBox' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(835,33): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(837,14): error G4121A47C: The setter 'needsRelayout' isn't defined for the class 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(1101,33): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(1104,18): error G4127D1E8: The getter 'isScrollingContentBox' isn't defined for the class 'AbstractNode'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(1456,32): error G44692867: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(1458,25): error G4127D1E8: The getter 'scrollTop' isn't defined for the class 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(1459,26): error G4127D1E8: The getter 'scrollLeft' isn't defined for the class 'AbstractNode?'. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/box_model.dart(1461,31): error G7C168647: Property 'parent' cannot be accessed on 'AbstractNode?' because it is potentially null. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/flow.dart(48,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderFlowLayout' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/flow.dart(1069,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderRepaintBoundaryFlowLayout' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/flex.dart(141,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderFlexLayout' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
/C:/Users/Gaubee/AppData/Local/Pub/Cache/hosted/mirror.sjtu.edu.cn%2547dart-pub%2547/webf-0.15.1/lib/src/rendering/flex.dart(2367,7): error G870B58C2: The implementation of 'dropChild' in the non-abstract class 'RenderRepaintBoundaryFlexLayout' does not conform to its interface. [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
D:\Program Files\Microsoft Visual Studio\2022\Professional\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(242,5): error MSB8066: ��D:\dev\tmp\webf\build\windows\CMakeFiles\018fdcff4aeb7c2c5d10e5b861c02446\flutter_windows.dll.rule;D:\dev\tmp\webf\build\windows\CMakeFiles\57b62b9155ac3693beb96652be35bbad\flutter_assemble.rule�����Զ����������˳�������Ϊ 1�� [D:\dev\tmp\webf\build\windows\flutter\flutter_assemble.vcxproj]
Building Windows application...                                     9.1s
Exception: Build process failed.

Actual results
至少应该启动起来以一个windows窗口

Please read the README.md.


history_stats error

Hi
Iam using 0.80 Hassio
I would like to calculate the runing time of my boiler, for the last 24 hour starting at 12 PM.
I found out 2 errors.

The statistics is resetting at 12 AM amd 12 pm
After 12AM if my switch is turning on getting strage data (negativ data ex: -10).

platform: history_stats
name: Boiler On Duration
entity_id: switch.boiler
state: ‘on’
type: time
start: ‘{{ now().replace(hour=12).replace(minute=0).replace(second=0) }}’
duration:
hours: 24
Here is my config
Thx for your help.

Been having a similar situation but in my case the value of the stats sensor remain 0 even when the reference entity is on for the given period of time


HTTPS certificate for gitxiv.com is for a different domain

The HTTPS certificate for gitxiv.com is actually a wildcard for the domains:
*.onmodulus.net

This causes Firefox to give a warning page, which may prevent people clicking through to the site unless they are familiar with the meaning of the message.

Indeed, SSL/HTTPS are currently not addressed, http only. Same goes for www.gitxiv.com, which does not work. We will look into solving this.

Until this is fixed, it may be useful to change the URL on the README.md file to be http://gitxiv.com instead of https://gitxiv.com, as that is how I browsed to it and others may do the same.


RFC: Use TypeScript

Issue Report
Would you be in favor of rewriting this library using TypeScript?

To me it would be nice to convert everything to TS, we should at least have a d.ts

I would appreciate having the library with TS would improve our development experience in the library and our clients as well. 👍

It would be nice!

Anyone volunteering for this?

Yes, I will finish up my other PR and start this.

Hey guys! What's the status on this? I would love to contribute and can start working on this if you want. I can start refactoring stuff to .ts or just create the .d.tss. What do you think?

@stephan-noel have you been working on it?

No, I haven't been, @filipesmedeiros you're more than welcome to take this up!

Hey @filipesmedeiros, thank you for the ping on this. We will benefit from a d.ts and that should be enough for TS compability.
In the future we will discuss internally if the project should be refactored to TS or just stay as it is.


Not able to build on node v0.10.33

Because node v0.10.33 lacks promise, npm run build will show:
> next build

[ReferenceError: Promise is not defined]

npm ERR<EMAIL_ADDRESS>build: `next build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is most likely a problem with the bill-progress-report package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     next build
npm ERR! You can get their info via:
npm ERR!     npm owner ls bill-progress-report
npm ERR! There is likely additional logging output above.
npm ERR! System Darwin 16.0.0
npm ERR! command "/usr/local/opt/nvm/v0.10.33/bin/node" "/usr/local/opt/nvm/v0.10.33/bin/npm" "run" "build"
npm ERR! cwd /projectdir
npm ERR! node -v v0.10.33
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /projectdir/npm-debug.log
npm ERR! not ok code 0

It seems that it is because webpack translates async/await feature into some code still using Promise, which is not polyfilled:
code in next-dev.bundle.js, starting from line 32707
	  // Within the body of any async function, `await x` is transformed to
	  // `yield regeneratorRuntime.awrap(x)`, so that the runtime can test
	  // `value instanceof AwaitArgument` to determine if the yielded value is
	  // meant to be awaited. Some may consider the name of this method too
	  // cutesy, but they are curmudgeons.
	  runtime.awrap = function(arg) {
	    return new AwaitArgument(arg);
	  };

	  function AwaitArgument(arg) {
	    this.arg = arg;
	  }

	  function AsyncIterator(generator) {
	    function invoke(method, arg, resolve, reject) {
	      var record = tryCatch(generator[method], generator, arg);
	      if (record.type === "throw") {
	        reject(record.arg);
	      } else {
	        var result = record.arg;
	        var value = result.value;
	        if (value instanceof AwaitArgument) {
	          return Promise.resolve(value.arg).then(function(value) {
	            invoke("next", value, resolve, reject);
	          }, function(err) {
	            invoke("throw", err, resolve, reject);
	          });
	        }

Node 0.10 is EOL in 3 days, you might want to upgrade

Closing this issue because

there is another issue on "supporting different node versions"
@benjick comment on node 0.10 support being dropped

Feel free to reopen if you really think makes sense to support 0.10

Not able to find related issue by title.
All other Promise object are polyfilled except for Promise used in async/await polyfill. I think there is at least some inconsistencies in building process.

@jo32 you're right with 1) reopening

Adding to this -
npm test fails on Node 4 as well
Here's a pull request that integrates travis - https://github.com/zeit/next.js/pull/205

does https://github.com/zeit/next.js/issues/168#issuecomment-258126627 answer the question? Might be worth switching to fast-async which doesn't convert async to generators.

We wouldn't support 0.10.


docs: add distro packages section to README.md

Hello! 🐻
I packaged heh for Arch / Alpine Linux and this PR simply adds a section to README.md for installation instructions.
P.S. The Alpine Linux package is waiting for review at https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/51015
Thanks for creating this kick-ass tool.
Cheers!

Wow, this is super great I really appreciate you doing this :D I really wish I had more time to actively work on this project but I'm glad you think it's a kick-ass tool as is.
I actually have no experience adding a distro package, but now that I've seen this done in some package managers, I was curious where I could get started learning how to do this for various package managers (maybe documentation/PRs)? If another version of heh is released, is there extra work I should do for the Arch/Alpine packages you graciously added?
I wanna make sure that I can support the work for these packages in the future, and maybe add it for other linux distros too :)
Thanks so, so, much again! Gonna merge in spite of a failed clippy job because nothing's changed except for maybe the job's rust version got upgraded..

Every distro has its own package manager and repositories so it differs based on the distro. For Arch Linux, you can maintain a package in the AUR as a regular user but you need to apply for the "package maintainer" role if you want to add a package to the official repositories (e.g. extra). For Alpine, you can simply use their GitLab to submit/update a package. I don't have any other packaging experience outside of that 🐻
For the package updates, I will be taking care of that so don't worry about doing anything. If it is stalled, just mark the package as out-of-date and feel free to reach out to me!


Module Names dont support dots

I am wanting to use version 3.5 in my url. Currently I have a module named v3 and now want one named v3.5, but the dot in the module name is messing up the router.

just tried dotted notation in route path without issues
*       /v3.5                module:apptest
*       /v3.6/apptest                AppTest.Index
``

The issue is module name. module:3.5 in this case

Any updates on this?

Initial testing I couldn't reproduce, I am adding to the examples a deeper
test... Working on other bugs ATM though
On Mon, Dec 4, 2017, 4:34 PM Nick Wallace<EMAIL_ADDRESS>wrote:

Any updates on this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/revel/revel/issues/1264#issuecomment-349155092, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABUsBnB7-wZDQwxSQt0k-a81dqu0cfP-ks5s9I-agaJpZM4QYdx_
.

Did you see my comment above? Your test did not cover the bug at all. It is the module NAME that does not support the dot, not the route


zrange limit

hey, how can I do this: ZRANGEBYSCORE your_sorted_set -inf max_score LIMIT 0 10
not found the limit from ZRangeCommandOptions

You should use offset and count
For example to get only first two:
{
        offset: 0,
        count: 2,
},

Oh, thank you so much


ci: fixing api_compat post-job cache issue

Commit Message: ci: fixing api_compat post-job cache issue
Additional Description:
Fixing the api_compat CI post-job cache failure (example: https://dev.azure.com/cncf/envoy/_build/results?buildId=89129&view=logs&j=34589ac8-7a1a-5ab1-7ee8-e202f4bf08f2&t=ac8660cc-f6a7-43c2-8464-358529887f90&l=65)
Risk Level: Low - CI only.
Testing: None.
Docs Changes: None.
Release Notes: None.
Platform Specific Features: None.
Partially fixes: #18211
Signed-off-by: Adi Suissa-Peleg<EMAIL_ADDRESS>

@alyssawilk I think this solves the api_compat cache issue (related to issues described in #18211).


PR #253 introduces a regression in 1.6

Looks like this is another unfortunate regression caused by #253. 😞
Details:
https://travis-ci.org/guzzle/guzzle/jobs/558517697#L599
https://github.com/guzzle/guzzle/blob/2297b43/src/RedirectMiddleware.php#L189

I think i have a PR about it...
https://github.com/guzzle/psr7/pull/284
Isn't this a fix for it?

I guess we can close this...


Remove deprecated findDOMNode

Similar to https://github.com/reactjs/react-transition-group/releases/tag/v4.4.0
This has a breaking change for functional components as they will need to use forwardRef

Thank you for the contribution. I have published version 5.0.0-beta.0. Once the readme has been updated I'll do a full release.


Do not reference v1 topic config anymore

This PR was successfully deployed to production by CircleCI build 164 at 2017-02-15 15:29 GMT.


community add a tool to pick pr from one branch to another #29764

cherry pick from #29764

run buildall


Disable bitcode while using Swift 2.3

Dobby links against XCTest which in Swift 2.3 was not built with bitcode
support.
For the 0.6.x release, bitcode should be disabled at the target level
so that when the setting is passed in by carthage it will be ignored
and a build will be successful
Closes #34, thanks @mdarnall!

Are you using Swift 2.3 or 3.0, @bckr? Everything should be fine, but as trivago probably has the largest codebase using Dobby, it might be worth checking that everything works as expected. If you are already using 3.0, I would simply move on without further confirmation.

@felixjendrusch We are already on Swift 3.0, so I can't give you any further insights. Can be merged from my side 👍


Maistra 0.11 Updates

Maistra 0.11 updates. Note that this includes Rob's cr updates.

lgtm

@brian-avery please, while on that, update the uninstall section to list/remove the ServiceMeshControlPlane CRD.
oc get controlplanes -n istio-system → oc get ServiceMeshControlPlane -n istio-system
and
oc delete -n istio-system -f <name_of_cr> → oc delete -n istio-system <name_of_cr>


binutils 2.35.1 -> 2.36.1

This needs to be rebased onto staging.

Also, past binutils bumps have been pretty breaking right? Should this have a hydra job?

Also, past binutils bumps have been pretty breaking right? Should this have a hydra job?

Yeah, past binutils bumps were an intense uphill battle requiring multiple people to collaborate over weeks to get them in shape. I speak from experience :P
This needs a hydra job, and I'll be (positively!) surprised if it doesn't need significant work to fix all the breakages.

/rebase staging
and the commit message should be binutils: 2.35.1 -> 2.36.1.

The user doesn't seem super active, I suggest we close this and I can re-open it.

The user doesn't seem super active, I suggest we close this and I can re-open it.

Sure, go ahead.

118945


[SPARK-36895][SQL] Add Create Index syntax support

What changes were proposed in this pull request?
This is the 2nd PR for DSv2 index support.
This PR adds the following:

create index syntax support in parser and analyzer
CreateIndex logic node
CreateIndexExec physical node

CreateIndex is not implemented yet in this PR. Calling CreateIndex will throw SQLFeatureNotSupportedException, and the parsed index information such as IndexName indexType columns and index properties will be included in the error message for now for testing purpose.
Why are the changes needed?
To support index in DSv2
Does this PR introduce any user-facing change?
Yes, the create table syntax as the following:
CREATE [index_type] INDEX [index_name] ON [TABLE] table_name (column_index_property_list)[OPTIONS indexPropertyList]

    column_index_property_list: column_name [OPTIONS(indexPropertyList)]  [ ,  . . . ]
    indexPropertyList: index_property_name = index_property_value [ ,  . . . ]

How was this patch tested?
add a UT

Test build #143737 has started for PR 34148 at commit f2d7e76.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48248/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48248/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48248/

@cloud-fan @viirya
Could you please take a look?
SQLKeywordSuite failed because the new keywords BLOOM_FILTER_INDEX, BTREE_INDEX and Z_ORDERING_INDEX  for index type are not in the documentation yet.

Test build #143737 has finished for PR 34148 at commit f2d7e76.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143737/

I removed these specific index types BLOOM_FILTER_INDEX, BTREE_INDEX and Z_ORDERING_INDEX for now to pass the SQLKeywordSuite. We can discuss what index types to support and document in next PR after Wenchen comes back from the holiday break.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48282/

@dongjoon-hyun @sunchao @viirya
This PR is ready for review. The failed test MariaDBKrbIntegrationSuite is not relevant.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48282/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48282/

Test build #143771 has finished for PR 34148 at commit 0024096.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143771/

@huaxingao just a quick question. do you have an implementation of the index support in DSv2? I am asking this because pandas API on Spark already implemented this actually. I would like to investigate the feasibility of migration in the future more just for curiosity .. If you don't have it now, it should be good to have one in test or documentation.

@HyukjinKwon Thanks for taking a look! I am implementing this in JDBC right now, so I can test out the new code in index support.

Test build #143808 has started for PR 34148 at commit 8248e60.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48320/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48320/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48320/

Test build #143808 has finished for PR 34148 at commit 8248e60.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143808/

Test build #143810 has started for PR 34148 at commit bc71de3.

Test build #143810 has finished for PR 34148 at commit bc71de3.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143810/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48322/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48322/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48322/

Test build #143858 has started for PR 34148 at commit c314c6d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48371/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48371/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48371/

Test build #143860 has started for PR 34148 at commit cf1e821.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48373/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48418/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48418/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48418/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48475/

Test build #144057 has started for PR 34148 at commit e32a053.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48535/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48535/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48536/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48536/

Test build #144057 has finished for PR 34148 at commit e32a053.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144057/

Test build #144058 has finished for PR 34148 at commit 9557c49.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144058/

Test build #144220 has started for PR 34148 at commit 20fac1c.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48699/

Test build #144220 has finished for PR 34148 at commit 20fac1c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@cloud-fan I have changed CREATE [index_type] INDEX ... to CREATE INDEX index_name ON [TABLE] table_name [USING index_type]. Please take a look again when you have time. Thanks a lot!

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48746/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48749/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144274/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144267/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48753/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48755/

Test build #144276 has finished for PR 34148 at commit b96bb2c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144276/

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48807/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48807/

Test build #144328 has finished for PR 34148 at commit ed8985c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144328/

Test build #144334 has finished for PR 34148 at commit ed862ed.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144334/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48813/

Test build #144335 has started for PR 34148 at commit 748157e.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48814/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48813/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48814/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48814/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48817/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48817/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48817/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48849/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48853/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48853/

Test build #144381 has finished for PR 34148 at commit 5b5880c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144381/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48869/


Fixed response passing to ensure valid response lookups based on Valu…

…es rather than Booleans or Strings. Also fixed loop for actOnMsg in Coordinator.
Closes #15, Closes #16

@lifanzhang @fobofindia09 Please review and merge when you get a chance. This resolves the issues we were seeing last night and also fixes the tests to fail when they should.

Looks good


docs: Update IBM ChatWatsonx documentation

Thank you for contributing to LangChain!
We would like update IBM ChatWatsonx documentation in LangChain documentation

howdy! Saw you added some checkmarks for model features. Could you add the standard tests to langchain-ibm to confirm these features are working as expected? Here's an example of how to add the unit tests and integration tests. You can xfail any tests that fail, and we can remove the xfails as things get fixed / features get added.

@efriis Hi, thanks for very fast response. I had removed "checks" from the PR and i would like add it in another PR. I would like to update the documentation quickly in this PR.


Ensure IGVM output is compatible with QEMU and calculate launch measurement

This PR introduces a new tool igvmmeasure that parses an IGVM file and calculates the launch digest which should match the launch measurement included as part of the attestation report from the platform.
By introducing this tool, it created the opportunity to verify that the directives within the IGVM file produced by the build process are properly sent as initial guest state, exactly as described and in the correct order. It was found that there were some discrepancies between the current IGVM file and the QEMU loader/KVM launch process that resulted in a mismatch between the expected and actual digest.
The first two commits in this PR fix these issues which both relate to the VMSA then proceed to introduce the measurement tool and introduce it into the build. An option has also been added to the tool to catch these inconsistencies in future changes to the IGVM file, causing the build to abort if detected.
Note that in order to obtain a matching measurement, fixes are required on top of the existing coconut/qemu. I will be raising a new PR with these changes shortly.

@msft-jlange Please can you check if the changes I've made here affect Hyper-V: https://github.com/coconut-svsm/svsm/pull/294/commits/43ebc3b4d9370664ae14a897e31997c355d8e6d2
I can make these hypervisor specific if necessary.

@osteffenrh - I heard on the OC3 talk yesterday that you are planning to update https://github.com/virtee/sev-snp-measure to work with IGVM. You might want to take a look at this PR to see if it meets your needs.

@osteffenrh - I heard on the OC3 talk yesterday that you are planning to update https://github.com/virtee/sev-snp-measure to work with IGVM. You might want to take a look at this PR to see if it meets your needs.

@roy-hopkins, Maybe that is no longer needed, now that you are contributing this PR here. :-D
We pre-recoded the talk a while back...

@msft-jlange Please can you check if the changes I've made here affect Hyper-V: 43ebc3b

We have test environments in which we need to be able to boot Coconut without executing any guest requests, and your changes to obtain an attestation report break that environment.  Can you please add some IGVM parameter (ideally triggered from the command line) which can be used to suppress the guest request?
I'm aware of other future use cases for Coconut where boot-time guest requests will prove problematic, so I think we want to avoid establishing a pattern where guest requests are invoked unless we know that the execution environment is one that demands their use.  Encoding this in the IGVM parameters would serve to capture that.
Also, I'm not entirely clear on why you want to capture the VMPL 0 measurement via attestation.  If you generate an SNP_ID_BLOCK as part of the IGVM builder, then you can prevent the VM from even launching if its measurement is incorrect.  At some point, it would be helpful to understand what problem you're trying to solve by performing this early attestation and we can see if there is an equivalent way to solve the problem that doesn't require capturing an attestation report.

Also, I'm not entirely clear on why you want to capture the VMPL 0 measurement via attestation. If you generate an SNP_ID_BLOCK as part of the IGVM builder, then you can prevent the VM from even launching if its measurement is incorrect. At some point, it would be helpful to understand what problem you're trying to solve by performing this early attestation and we can see if there is an equivalent way to solve the problem that doesn't require capturing an attestation report.

The generation of the attestation report at this stage is purely informational and was added after discussions around making progress towards generating SNP_ID_BLOCKs. It serves as a rehearsal for possible future functionality where the SVSM will use the attestation report to request access to keys via the host.
At this stage I don't think there is any need to complicate this by making it conditional and I'd be happy to drop this commit from the PR.

@roy-hopkins: how about adding a igvmmeasure/.cargo/config.toml:
[build]
target = "x86_64-unknown-linux-gnu"

so that cargo build can be directly executed from the igvmmeasure directory?

There seems to be something off here.
I just wrote my own tool that should perform the same job. So far, I was only able to successfully extract the ld value from the id block:
https://github.com/microsoft/igvm/blob/ac37f5e5658262f3e377f3f6019c9e631a32f644/igvm/src/lib.rs#L706
I have an IGVM file I can boot, that has a different value for the launch measurement in the id block than what igvmmeasure returns.
After launching the VM, reports I get from the VM also show the measurement value from the id block.
I think this tool is measuring something incorrectly.
This is an IGVM file I got from an Azure AKS node for testing purposes:

Would it be a good idea to print a warning (or even return with a non-zero exit code) if the ld value does not match with the result of measuring the actual pages?
It feels to me like this might catch other issues at some point.

By chance at the same time as @jepio's observation about zero pages above, I managed to get the output of igvmmeasure to match the ID block LD value by experimenting with measuring a page of zeros instead of using PAGE_TYPE_ZERO.
As far as I am concerned, the QEMU behaviour is correct and we shouldn't be populating a page of zeros into guest memory when we encounter empty page data in the IGVM file, but should instead use the SNP page type of PAGE_TYPE_ZERO. However, in order to support the virtualisation stack you are using I can add an option to the measure tool to change the behaviour when measuring these pages.

Would it be a good idea to print a warning (or even return with a non-zero exit code) if the ld value does not match with the result of measuring the actual pages? It feels to me like this might catch other issues at some point.

Yes, that does make sense. The COCONUT IGVM builder does not generate an ID block yet but it will at some point, so I'll add a check that it matches if it is present.

However, in order to support the virtualisation stack you are using I can add an option to the measure tool to change the behaviour when measuring these pages.

I would appreciate that! I personally can’t comment on ABI compliance (just a user of the platform). @jepio is probably in a better position to comment on that.
The virtualization stack is cloud-hypervisor with the hyperv backend on Azure with nested virt (the Azure AKS CoCo offering)

Changes in the latest push:

Dropped the commit that obtains an attestation report in SVSM kernel startup and logs it to the console.
Added igvmmeasure/.cargo/config.toml as per @jepio's suggestion.
Added native-zero option to determine how to handle pages that contain only zeros.
Added check for matching measurement in ID block if present in the IGVM file, and an option to disable the check if required.

This hopefully resolves all the current comments on the PR.
I see a rebase on main is required so I'll push this shortly.