[Bug] [Stetho] Fix bug in stetho module

Description
This PR attempts to fix but in Stetho module, where it only works on the first request but not on the subsequent request.

Type of change
The reason behind this is the StethoURLConnectionManager is designed to be used only once and throw away according to the documentation. Since our Stetho hook is being created once, the current implementation retains the same StethoURLConnectionManager instance which means that it makes the subsequent requests unable to inspect because StethoURLConnectionManager became unusable at the point.
Implementation
After I carefully think about a good way to do this, it is clear that we need some sort of "in-memory" to cache the pair of Request => StethoURLConnectionManager so that it could be created/used/disposed according to the correct request. Since the current Request class is lagging some sort of "tagging" system, it could prove to be challenging to find the correct StethoURLConnectionManager according to the Request.
This PR has 2 main goals.

Adding the tagging mechanism into Request class
Improve the Stetho hook implementation

New features
In this PR, I have added tagging feature for Request object;
fun tag(t: Any): Request

fun <T : Any> getTag(clazz: KClass<T>): T?

The top interface is to allow a user to be able to add arbitrarily object into the internal hashMap. The second one is to allow a user to be able to retrieve a previously tagged object by using KClass<T> as key.
Bug fix
With abovementioned implementation, StethoHook uses the randomUUID to attach to the request. Given that the same request should call in all of the hook functions, the correct UUID can be retrieved and call at the appropriate timing.
Check all that apply

[x] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (a change which changes the current internal or external interface)
[ ] This change requires a documentation update

How Has This Been Tested?
In case you did not include tests describe why you and how you have verified the
changes, with instructions so we can reproduce. If you have added comprehensive
tests for your changes, you may omit this section.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation, if necessary
[ ] My changes generate no new compiler warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Inspect the bytecode viewer, including reasoning why

PS. Thanks from report from @worker8

Yes, I think the Request object cannot be used as it will be wrapped and changed. I think it will be future-proof if we have something that is more static and easily used as a map key.

And to that question: what happens if it redirects? Shouldn't UUID be forwarded?  I don't think this would work ....

I think that if you copy over the tag in the RedirectionInteractor, this can be merged @kittinunf

@SleeplessByte
It looks like this code
Fuel.get("/redirect-to", listOf("url" to "/get"))
                .responseString { _, _, result -> update(result) }

Produces this

I guess it looks fine as it is @SleeplessByte WDYT?

@kittinunf yeah, in reality they ARE two requests, so as long as everything else works it's fine with me. Feel free to merge :)

Thanks both of you for your reviews :)


[skip ci] PR engagement rules

I write up this to purpose some guidelines for how PR should be composed and when will we begin reviewing PR. Please let know your thought.
This is just a draft as of now.

@mayurid


[pinmux/dif] Implement most pinmux DIFs

Add DIFs for input and output muxes, sleep states, and wakeup detectors.
Signed-off-by: Alexander Williams<EMAIL_ADDRESS>

Also, if this implements all DIFs, could you update the checklist / milestone to indicate this is at the appropriate milestone (S0, 1, or 2)? Thanks!

Also, if this implements all DIFs, could you update the checklist / milestone to indicate this is at the appropriate milestone (S0, 1, or 2)? Thanks! (A follow up PR is acceptable too :) )

Yeah, a follow-up that makes the rest of the test code use the DIF will include a checklist update.

Just a quick note RE the checklist update: we should make sure that the change is in a separate commit (i.e., don't lump the design stage update together with other changes for clarity).


Installation Documentation is Wrong

The installation page on the wiki says to run the follow command to install on Mac OS X:
brew install thefuck

But this is response when the command is run:
Error: No available formula for thefuck
Searching formulae...
Searching taps...

When did you last run brew update? What's the output of brew doctor?

Oops.

No, I think Homebrew could be better about reminding people to update regularly!


Do not specify -compat when running go mod tidy

What does this PR do?
Do not specify -compat=1.17 when running go mod tidy and re-run the command.
Motivation
Dependabot doesn't pass -compat, so the CI would fail on PRs open by Dependabot because of go.sum differences.
This seems an easier solution that trying to fix go.sum automatically on dependabot PRs, see #11264

Will this mean that we're potentially stuck with older versions of modules, since the default for go mod tidy keeps modules compatible with the version one behind what we declare in go.mod?

I'll be honest, I don't remember why I had to add this flag, but something went wrong when I didn't and the error message suggested this flag.
So, let's try it and see what happens!

Alternative to this PR: https://github.com/DataDog/datadog-agent/pull/11334

Looks like that alternative was selected :)


DateTimeField received a naive datetime while time zone support is active.

The above warning occurs when running manage.py runcrons on Django 1.4. The complete traceback is:
Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 443, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 196, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 232, in execute
    output = self.handle(*args, **options)
  File "/home/joel/.virtualenvs/ecomarket/local/lib/python2.7/site-packages/django_cron/management/commands/runcrons.py", line 57, in handle
    silent=options['silent'])
  File "/home/joel/.virtualenvs/ecomarket/local/lib/python2.7/site-packages/django_cron/management/commands/runcrons.py", line 74, in run_cron_with_cache_check
    CronJobManager.run(instance, force)
  File "/home/joel/.virtualenvs/ecomarket/local/lib/python2.7/site-packages/django_cron/__init__.py", line 91, in run
    if CronJobManager.__should_run_now(cron_job, force):
  File "/home/joel/.virtualenvs/ecomarket/local/lib/python2.7/site-packages/django_cron/__init__.py", line 78, in __should_run_now
    qset = CronJobLog.objects.filter(code=cron_job.code, start_time__gt=datetime.today().date(), ran_at_time=time_data)
  File "/usr/lib/python2.7/dist-packages/django/db/models/manager.py", line 143, in filter
    return self.get_query_set().filter(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/django/db/models/query.py", line 624, in filter
    return self._filter_or_exclude(False, *args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/django/db/models/query.py", line 642, in _filter_or_exclude
    clone.query.add_q(Q(*args, **kwargs))
  File "/usr/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1250, in add_q
    can_reuse=used_aliases, force_having=force_having)
  File "/usr/lib/python2.7/dist-packages/django/db/models/sql/query.py", line 1185, in add_filter
    connector)
  File "/usr/lib/python2.7/dist-packages/django/db/models/sql/where.py", line 69, in add
    value = obj.prepare(lookup_type, value)
  File "/usr/lib/python2.7/dist-packages/django/db/models/sql/where.py", line 320, in prepare
    return self.field.get_prep_lookup(lookup_type, value)
  File "/usr/lib/python2.7/dist-packages/django/db/models/fields/__init__.py", line 709, in get_prep_lookup
    return super(DateField, self).get_prep_lookup(lookup_type, value)
  File "/usr/lib/python2.7/dist-packages/django/db/models/fields/__init__.py", line 310, in get_prep_lookup
    return self.get_prep_value(value)
  File "/usr/lib/python2.7/dist-packages/django/db/models/fields/__init__.py", line 801, in get_prep_value
    value = self.to_python(value)
  File "/usr/lib/python2.7/dist-packages/django/db/models/fields/__init__.py", line 761, in to_python
    RuntimeWarning)
RuntimeWarning: DateTimeField received a naive datetime (2013-08-22 00:00:00) while time zone support is active.

This comes from the fact that you are passing a datetime.date object to a DateTimeField, which is unsupported. A workaround is to use a timezone-aware datetime object (eg. by using django.utils.timezone.now) and setting the time to midnight.
Although this is only a warning, it is causing a large amount of email for us as we have runcrons set up to run every five minutes and email us any output from stderr.

Fixed in #48


Hide at login

I added nvALT to Login Items and checked the Hide checkbox but nvALT doesn't hide at startup. Notational Velocity does hide.
Screenshot: http://skit.ch/bwmg

Yes please.


[📊] Collecting statistics for Juice Shop

OWASP ZAP published https://www.zaproxy.org/blog/2021-04-19-collecting-statistics-for-open-source-projects explaining their way to collect some stats about usage and downloads of the project. It would be nice to have something similar (or near-identical, even) for Juice Shop.
Download stats interesting for Juice Shop would definitely include:

Docker image pulls (main app and CTF extension)
GitHub downloads (main app only)
NPM downloads (CTF extension only)
SoureForge downloads (main app only)

Additional stats will be added to this issue description over time based on proposals in the issue comments.

Could we rewrite a similar thing using nodeJs and may be use it to create a user interface using the google charts. We would only need to store the github downloads and docker pulls as the rest are available to filter for time intervals.

With "rewrite" you mean the Python scripts? That would be as good approach as it's closer to our developer community... 👍
The storage and everything would make sense on the OWASP AWS or I could create a private GH repo and we dump the data there. Should also be fine.

Yeah I mean rewrite the python scripts. But is it going to be a part of this repository or a standalone one

I'd make a separate repo for this, but ideation of what stats to collect and how implemention might look like should happen here first.

I think exposing out some APIs from the server and displaying the data on an html page or a server side rendered page would be a nice way to implement it. Also we cannot show the data for github downloads and docker pulls immediately as it was not recorded previously. It would require the app to store the data for some days to be able to display it in a weekly or monthly fashion

I think Juice Shop may differ from ZAP in that Juice Shop is more like a website than a tool. So I guess many people will just visit http://demo.owasp-juice.shop in browser to use it without bothering downloading source code, pulling docker image or registering extra accounts. How can we collect PV statistics of our demo website? It seems our demo is also deployed in Heroku.

I would say juice shop is meant to use locally where people can change its configuration according to their needs instead of like a website

The Public Heroku instance can already be monitored pretty nicely by pointing a prometheus against it to regularly collect metrics 🙃
As seen on twitter 😄 https://twitter.com/owasp_juiceshop/status/1306504380817051649

I created a small rough version of the app. This is what it looks like currently: https://ancient-springs-56508.herokuapp.com/
I havent added the github and docker stats as they arent recorded yet. I am also confused a bit about how to show stats for different releases

The public heroku instance can already be monitored pretty nicely by pointing a prometheus against it to regularly collect metrics 🙃
As seen on twitter 😄 https://twitter.com/owasp_juiceshop/status/1306504380817051649

I actually have a RasPi 3 running non-stop pulling Prometheus metrics from the demo instance, but I don't really monitor anything there. Usage of that instance is not really saying much about anything, because it's not supposed to be used for hacking but it's the default data source for the CTF tool ... so it's seeing some traffic, but it's not really telling us how well the project is doing.

I created a small rough version of the app. This is what it looks like currently: https://ancient-springs-56508.herokuapp.com/
I havent added the github and docker stats as they arent recorded yet. I am also confused a bit about how to show stats for different releases

So the source forge and npm stats you pulled live out of their APIs, not from some data store, right?
I can create a repo for Juice Shop stats collection/monitoring already, if that helps already in the "playing around"-phase of this idea... 😁

Also, this stats-collector repo is a good test balloon for https://github.com/juice-shop ... This might become the entire ecosystem's new home, if I get everything transfered from my account without breaking stuff or sending people into 404's ...

https://github.com/juice-shop/juicy-statistics 👈

I created a small rough version of the app. This is what it looks like currently: https://ancient-springs-56508.herokuapp.com/
I havent added the github and docker stats as they arent recorded yet. I am also confused a bit about how to show stats for different releases

So the source forge and npm stats you pulled live out of their APIs, not from some data store, right?
I can create a repo for Juice Shop stats collection/monitoring already, if that helps already in the "playing around"-phase of this idea... grin

Yes sir they are live from the API. I only added the data for the past month.

I reserved https://juicy-statistics.herokuapp.com, so we could add auto deployment there via GH action.
Also we could keep the data in the repo for now and let @JuiceShopBot commit it automatically, similar to the lint fixing. No need for separate data repo or S3 bucket at the beginning, or is there?

Above URL is now available and development is in progress, so I'm closing this ticket here. Dedicated requirements for stats to collect and show can be put into issues on the https://github.com/juice-shop/juicy-statistics repo.


netlist_cmp fixes

Remove netlist cleanup from netlist cmp, passes without it
Accessing dictionary values in get_pin function using .get() to avoid KeyErrors
Ignore CASCADEIN pins in net equivalence step, they cause problems

@reillymck thoughts?

We can't ignore CASCADEIN pins. We need to make sure they aren't part of the design. Fasm2bels doesn't support cascading brams but they will still give some output. So when equivalence fails because CASCADE pins exist we need to know that's the reason and it's not because the tool isn't working right.

And we do need to make sure that both designs have zero/ground on the cascade pins. Also I'm not sure we can just ignore net equivalency because it's possible the ground signal connecting to them is generated by a LUT

@reillymck

We can't ignore CASCADEIN pins. We need to make sure they aren't part of the design. Fasm2bels doesn't support cascading brams but they will still give some output. So when equivalence fails because CASCADE pins exist we need to know that's the reason and it's not because the tool isn't working right.

What do you mean by "We need to make sure they aren't part of the design"?
"So when equivalence fails because CASCADE pins exist we need to know that's the reason and it's not because the tool isn't working right." So do we want the designs with the CASCADE pins to fail? Should I not worry about these designs?

Sorry. They can be part of the design but we need to make sure the value on the pin is zero or ground.

I have no idea why pylint is mad but this should be ready to merge otherwise

@jgoeders Thanks. This is ready for merge now.


End to End Testing - Part 3 - Write Project Test Suites

Overview
In part 3 of writing the end to end test suites, Waleed will write test suites to make sure that projects, project lanes and project tasks have E2E test coverage and function as expected.
For example, Waleed will make sure that if the user creates a new project in the UI, the user can see the three lanes: To Do, Doing and Done.
To Do

[x] Projects
[x] Project Lanes
[ ] Project Tasks

The work on this issue is complete for now, however, it must be noted that the delete functionality could not be tested for projects, lanes and tasks simply because it is broken right now... Once delete functionality works for all components then more tests will be added to test the delete functionality of projects, lanes and tasks.


Using a stable package

I'm trying to add a specific stable package to the config but I'm a bit confused as to how to fix the structure to make it available for home-manager.
I think I need something like:
 #flake.nix inputs = {     nixpkgs-stable.url = "github:nixos/nixpkgs/nixos-23.11"; }; outputs = {     nixpkgs-stable, };
And then importing in misc/default.nix with:
home.packages = with pkgs; [  ... ] ++ [     pkgs-stable.lutris ]
But I'm not sure how to generate pkgs-stable from nixpkgs-stable, from what I could grasp this is being done to the base nixpkgs in:
pkgs = nixpkgsFor.${system};

I'll take a look at this, this is actually a pretty good question. I apologize for taking this long to reply, please let me know if you found something :+1:

I managed to install a specific package from stable by doing this:
1- Add nixpkgs-stable to your inputs and outputs.
nixpkgs-stable.url = "github:nixos/nixpkgs/nixos-24.05";

2- Create a variable for importing nixpkgs-stable, I placed it below nixpkgsFor but it's up to you.
# Stable Nixpkgs instantiated for supported system types.
nixpkgsStableFor = forAllSystems (system: import nixpkgs-stable {inherit system;});

3- Add nixpkgs-stable to extraSpecialArgs in your home-manager modules:
          modules = [
            ./hosts/redyf/configuration.nix
            home-manager.nixosModules.home-manager
            {
              home-manager = {
                useUserPackages = true;
                useGlobalPkgs = false;
                extraSpecialArgs = {inherit inputs disko nixpkgs-stable;};
                users.redyf = ./home/redyf/home.nix;
                backupFileExtension = "backup";
              };
            }

4- Create a nix module to install the package you want (you can do it within your flake but I'm going with the module).
{nixpkgs-stable,...}: {
    home.packages = [
      nixpkgs-stable.legacyPackages.x86_64-linux.cargo
    ];
}

As you can see, the version matches the stable branch.


Version issue

I tried to run the code on py2.7 but it keeps giving me an error -
../models/models.py", line 68, in forward
input = GradReverse.grad_reverse(input, constant)
TypeError: unbound method grad_reverse() must be called with GradReverse instance as first argument (got Variable instance instead)
I tried with some more combinations of versions (py-3.5, torch 0.4.1, etc.), all gave some or the other error.
I suspect it is due to some version issue of some package. It will be very much helpful if you can upload environment.yml file or version details in a req.txt file.

@amarpazad I add the requirements.txt. You can try to run the code again.


Update local.py

@houqp do we need to change the other ones for local, too?

yes, we should change the others.


Create a new migration video - V2 to V3

Summary
Create a video to support people in the migration process
Why do we need this ?
Promote & support people with migrating devices & applications
What is already there? What do you see now?
Documentation and an outdated video

Goal: show during The Things Stack conference on May 28


move all text to language files

we need that to make full translations possible
the basic way is:

create a new key in the language file

add english content

use  in the tsx file to reference it

[x] home

[x] contributing

[x] sponsors

[x] not-found

[x] quick-start

[X] faq

[x] support

[x] usage

[x] autowiring
[x] logging
[x] middlewares
[x] results
[x] routes
[x] storage

solved with #611


tailscale: 1.14.1 -> 1.14.2

Description of changes
https://github.com/tailscale/tailscale/releases/tag/v1.24.2
Also removes some dev cruft that slipped into the previous change, as noticed in #170727 .
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Duplicate #170872

Duplicate of #170872


fix: rustls causing openssl to be built

This commit fixes rustls feature being dependant on native-tls and binding to libcrypto.
fixes: #369

working on this feature made me realize the structure of this crate is not rust 2021 and also uses some strange tactics like a compile feature to toggle ssl verify. Perhaps we could create a feature branch and get a 1.0 version fixing these mistakes. I do not mind putting in the work to fix and refactor them.

I am particularly referring to using feature flags to change interface. How rust feature flags work is if any dependency in the compile tree enables the flag the feature is enabled for all users of the dep. Meaning if I use a dep which uses rust-s3 sync and I use rust-s3 with Tokio it won't work. Fortunately this has not happened but ideally we should have a better mechanism for handling this.

@TroyKomodo very nice, thank you!
I hear you on the design choices, this is a pretty old codebase and it shows, if you'd like to come up with a set of changes you'd like to see for 1.0, I'd be happy to look them through, figure out timelines...

Hi @durch
This issue with openssl being compiled when using the rustls backend is breaking cross compilation upstream. Do you have plans to release a 0.34 point release including this fix or should we wait for 0.35?
Thanks!


feat: support 304 for webhooks

Problem Statement
Webhook provider can return cached data. This means that data is not returned by it, but no error should happen in this case, but we should just stop reconciling the secret at that point.
Without modifying the entire interface for fetching data to include a needs update parameter when returning, I'm falling back to use a sentinel error instead.
This update also contains a small refactoring around marking a reconciliation as done or failed and removes some code duplication.
Related Issue
Fixes https://github.com/external-secrets/external-secrets/issues/2824.
Proposed Changes
How do you like to solve the issue and why?
Checklist

[ ] I have read the contribution guidelines
[ ] All commits are signed with git commit --signoff
[ ] My changes have reasonable test coverage
[ ] All tests pass with make test
[ ] I ensured my PR is ready for review with make reviewable

TODO: Adding unit tests around this.

This PR is closed because it turns out implementing this scenario for a single provider would disrupt the other provider code with a lot of change from the main interface umbrella.
We will opt out of doing that work here to preserve the current structure.

TODO: adding push secret controller cleanup too.

/ok-to-test sha=75e5b82


FIXED SOCIAL ICONS

Title and Issue number

Title : NOT DISPLAY
Issue No. : 449
Close #449
SCREEN SHORT

Checklist:

[X ] I have mentioned the issue number in my Pull Request.
[ X] I have commented my code, particularly in hard-to-understand areas
[ X] I have created a helpful and easy to understand README.md if its a new page/tech stack
[ X] I have gone through the  contributing.md file before contributing

Are you contributing under any Open-source programme?

[X ] I'm a GSSOC-EXT contributor
[X ] I'm a HACKTOBERFEST contributor

@GAVINESHWAR Please Review PR..


Please bring back Torus

Hi @philips ,
While working on a kubernetes cluster running scientific programs I stumbled upon a small problem.
I was using NFS to share temporary files between the nodes and noticed that the NFS server was a single point of failure.
So, there I go, trying to find a solution to this small bump on my happy kubernetes road.
But the more I look, the more I read, the more I understand that the distributed, redundant storage problem was never adressed correctly.
The systems are old, big, hard to deploy and hard to maintain.
As it was pinpoint in the origin torus blog, they were not designed for the cloud era.
Torus seemed like a real clean solution and I hope it will be back someday ...
Thank you for taking the time to read this and have a nice day!

Have you checked out github.com/rook/rook?

@SkinyMonkey If you are in a single cloud provider, why are you not simply using the provided storage services?  Azure offers both NFS-like storage and volume-like storage.  AKS already has storage classes for azure-disk (volume) types out of the box.
Torus' use cases (in my opinion) are for multi-cloud architectures and baremetal clusters, where you are not already provided an economical storage infrastructure.  Rook is serving those needs well, and since it is just Ceph under the hood, it is pretty easily debuggable.  By and large, the Go codebase of Rook's operators and wrappers is pretty comprehensible and well-architected.

Sadly the NFS like storage, AzureFile, is extremely slow, to the point of not being usable in a realistic environment. This has been reported multiple times since 2017 and still hasn't been adressed.
About the volume like storage, as far as I know you cannot attach the same azure disk to multiple pods, making it useless in a shared file system context.
If it does that would be a good temporary solution, but ..
the product I'm working on aims at being deployable on premise anyway. We need an abstract solution to this problem.
Rook is nice, and maybe i'm looking at it from the wrong angle, but again, it's an overkill solution for a simple temporary shared file system.
It also has prerequisites that makes it difficult to use in my case, as I described earlier (kernel updates etc)
I might use Rook in the end, it's just that torus seemed like a really good project that could benefit a lot of people.
Right now I'm stuck between overkill solutions that need more and more infrastructure/maintenance/development to support it and simple ones that wont survive a node crash.

There exist other storage solutions for baremetal clusters, but among them, I would only use Rook/Ceph.     Kubernetes does support NFS natively, though I think only a madman would actually use NFS in production (though I understand there are many people who will vehemently disagree).
Personally, I would stay away from any shared-filesystem type approach.  You will either trade speed or reliability, and there is almost always a better way to achieve the actual requirements than sharing POSIX-like filesystems amongst disparate machines.
If you really must have a shared filesystem, GlusterFS is another option. If offers a native shared filesystem as well as an NFS compatibility later.  It is supported by Kubernetes out-of-the-box.  Since it is simpler than Ceph and concentrates just on a shared filesystem, that is probably the most appropriate answer to your needs.  Keep in mind that, like any distributed storage system, you must install n+1 (i.e. minimum 3 nodes) for redundancy, and it is easy to overlook this fact in the GlusterFS documentation.

I've checked/considered a lot. Rook/Ceph is in the top 5 with Glusterfs.
I agree That NFS offers no guarantee of reliability.
The product I'm working on demands that I share files between the pods i'm executing. Big files too, hundred of gigs.
Another solution would be to execute all the pods on the same node .. but it would be losing the real plus of kubernetes: distribute the computing charge over several machines.
Glusterfs was considered but I met the same problem as I met with rook : kernel updates or modules are needed.
Any distributed system needs at least 3 nodes to run yes, Mongodb, Rabbitmq, Etcd, any clustered program needs 3 nodes fo redundancy. K8s is another example.
I'll recheck Glusterfs, maybe i'll have two separate clusters : one for the file system, one for the computation. That way the filesystem will be less subjects to autoscaling needs.

Separate clusters would be precisely my advice, in that case, yes.
Also to note, though, since your ultimate goal is to deploy to baremetal, you might as well be using bare VM instances running your own kernel, rather than the cloud provider's prefabricated kubernetes, which would give you exactly the same freedom of deployment, kernel-wise, as you would have with baremetal.  You can easily also easily follow a progressive build-out, to reduce the size of each hurdle:

Deploy to AKS using offered (however slow) shared filesystem there.
Deploy to Azure bare VMs and construct your storage layer.
Deploy to baremetal.

The storage interfaces for Kubernetes are nicely abstracted, so you don't need to change your applications just because you change your underlying storage infrastructure.  Your YAML files may change, but your application interfaces will be the same throughout that progression.
I know I keep harping, but I would have very serious reservations about an architecture which calls for shared filesystems, much less with individual files of that size.  In my opinion, you are just asking for trouble.  I'm not about to dive into an architectural analysis, but I would strongly urge you to take a step back and really analyze your storage parameter needs.

Thank you for your time and analysis, we work on both hosted and on premise solutions.
I'm not sure to understood the problems tied to a shared file system. Maybe because I never worked with one in production?
In a case where a chain of interdependant programs producing heavy files, I would be curious to see what solution would allow the system to work in a reasonably fast way.

The core problem is always locking, and POSIX-oriented filesystem semantics just don't provide sufficient locking guarantees or semantics to facilitate safe operation.  Various tricks are used to work around this limitation, and the trade-off is always either speed or safety.
If a 'per job' azure disk is something you are considering, consider using an object store instead.   Every major cloud provider supplies one, and there are a few options for self-hosted object stores (including Rook/Ceph).  You can have any number of readers, and they handle locking automatically.  For extremely large chunks of data, too, most object store APIs (the de facto standard is S3) allow for server-side seeking, to efficiently process smaller chunks at a time.  In general, the APIs are very simple, so it is nearly as easy to use as a filesystem.

https://github.com/tiglabs/containerfs
https://github.com/tiglabs/containerfs-csi-driver

@Ulexus Ok! That makes sense. I did see some wait happening on read operation with NFS. 'Could have been caused by the locking.
I'm going to check object stores on Azure and the on premise solutions.
Thanks again :)
@zhengxiaochuan-3 , I did found this repo but the lack of documentation or orientation made me consider other solutions. Thank you


feat!: Update GraphQL span name convention

Fixes #1361
Changes
Due to concerns about high cardinality with the current span name format, use only the graphql.operation.type attribute for the span name. The higher cardinality attribute, graphql.operation.name can still be used in queries, as it is an attribute on the span. The original fallback span name, GraphQL Operation, is preserved.
Merge requirement checklist

[X] CONTRIBUTING.md guidelines followed.
[X] Change log entry added, according to the guidelines in When to add a changelog entry.

If your PR does not need a change log, start the PR title with [chore]

[X] schema-next.yaml updated with changes to existing conventions. (I don't think this needs to be updated because it's a span name and not an attribute)

It seems like the wayback machine is down at the moment, causing the markdown-link-check job to fail: https://github.com/open-telemetry/semantic-conventions/actions/runs/11263374842/job/31321102055?pr=1389#step:4:10


Avoid empty mmap files by using .tmp files to write headers

Fixes https://github.com/prometheus/prometheus/issues/7469

It would be great to get thin into the 2.20 release. I've requested reviews from a few people that might be qualified. I'll also give it a try myself once I have reached that point in my review queue.

I don't get what this gives us. The process of writing headers is probably quite fast, so unlikely that this is causing empty files no? so I don't think we solve anything here  In the same time process might be finished etc at line 256 ?

Prometheus is so widespread now that even things that happen once in a million time happen every day.

If write fails, you would have an empty dir.

I don't get what this gives us. The process of writing headers is probably quite fast, so unlikely that this is causing empty files no? so I don't think we solve anything here thinking In the same time process might be finished etc at line 256 ?

If you look at the linked issue, it has been experienced by >1 person not long after the release, so it's not that rare. And disk writes/syncs are OS dependant and might not be flushed immediately?
Btw, if it happens (empty files), Prometheus will fail to start. So, it fixes that.

Looks like this has now been comprehensively reviewed. (o:
Merging now to get this into the RC.


More sorts on leaderboard

What I did:

Add plays and playtime sorts on leaderboard when api request

thanks!


does not work with typescript

Strange but when I use some of the snippets with typescript, it always returns the result of the first param. For example
import {matches} from 'z';

const person = { name: 'Maria' }
matches(person)(
  (x = { name: 'John' }) => console.log('John you are not welcome!'),
  (x)                    => console.log(`Hey ${x.name}, you are welcome!`)
)

returns John you are not welcome.

this is what typescript compiles down to:
$ mkdir ztypescripttest && cd ztypescripttest
$ yarn init -y
$ yarn add z typescript
$ vim index.ts # paste the example from above
$ ./node_modules/.bin/tsc index.ts
$ cat index.js

"use strict";
exports.__esModule = true;
var z_1 = require("z");
var person = { name: 'Maria' };
z_1.matches(person)(function (x) {
    if (x === void 0) { x = { name: 'John' }; }
    return console.log('John you are not welcome!');
}, function (x) { return console.log("Hey " + x.name + ", you are welcome!"); });

Z uses a module to get meta data about functions specifically the ability about default params. If any code is transpiled to es5 the es6 code default assignement are removed from the function signature thus resulting in broken code. The above code needs to transpile to es6 or higher to work properly. This probably also means pattern matching will break on babel transpiled code to es5.

Hi, i release a babel plugin to preserve the toString of  transpiled arrow function, i tested in a project with z and it seems work babel-plugin-preserve-arrow-function-to-string.


Fix certifi TLS issue

I'm seeing a bunch of this all of a sudden:
OSError: Could not find a suitable TLS CA certificate bundle, invalid path:
/home/runner/work/recap/recap/venv/lib/python3.10/site-packages/certifi/cacert.pem

I'm pretty sure it's because certifi pushed a new release yesterday:
https://pypi.org/project/certifi/2023.7.22/
I'm trying to peg certifi to the previous version for all packages that use it (transitively via requests).

Closing in favor of #329


cls documentation

Description
Changes proposed in this pull request:

Add some documentation for cls
Related issue(s)

I suggest adding links between the two .md documents, because the user who reads one of them is probably interested in the other one, too.


W = tanh(Wˆ ) * σ(Mˆ )

https://github.com/bharathgs/NALU/blob/16a4c9965ad371b48d086bfd780f0479ce311d98/nalu/core/nalu_cell.py#L22
Shouldn't W be implemented as below according to the paper ?:
W = tanh(Wˆ )  * σ(Mˆ )

@pushkarparanjpe thanks for pointing that, fixed it :slightly_smiling_face:

Sure :)


"too many certificates already issued for "

Hi,
I was installing an SSL certificate using letsencrypt and I ran into the error: "too many certificates already issued for ".  Is there a way to bypass this or to pay for more certs?
Thanks.

Have a read there. You must be hitting a limit.
https://community.letsencrypt.org/t/rate-limits-for-lets-encrypt/6769
https://letsencrypt.org/docs/rate-limits/
We also have a Duplicate Certificate limit of 5 certificates per week.
The changes were:
20 certificates per registered domain per week (up from 5).
Added an exception to this limit for renewing certificates (issuing a new certificate with same names as a previous one).
Added a new limit on issuing certificates with the exact same set of names: 5 certificates per FQDN set per week.

The best way to avoid it is by using the --test switch for testing. If you need to request a lot of them in production then you should consider using manual mode to get the .pfx file and then script the deployment to all of your servers. There is no way to bypass the limit though, sorry.

because of nullreferenceexception and issue in old version of winacme i'm now blocked and can't renew with newer version after too many attempts. oh boy


Dockerized zipstreamer

Hi scosman,
Not sure if you're planning to keep maintaining this or not, but I felt it was a useful idea, and hosting it privately inside Kubernetes or Docker Swarm has some value for various use cases. So I've contribued a Dockerfile. It builds on Docker Hub, and can be used from there.
Thanks!

Would be great to see this merged. It will also be useful for local development environments.

Thanks for the patch! Used this as a guide and learned docker in the process.
I've added a docker file as requested. Made some optimizations of my own (slim package saved about 90% of the size, one click deploy to Google Cloud Run), so this PR no longer needed, but big big thank you!


Added Oracle Object Storage adapter

Added Oracle Object Storage Adapter
Solving Issue #6415

I am facing problem in phpunit test. It is showing could not read phpunit.xml when using phpunit --configuration phpunit.xml and when running vendor/bin/phpunit --configuration phpunit.xml I get the error zsh: no such file or directory: vendor/bin/phpunit.

@stnguyen90 take a peek at the comment here

Discord thread: https://discord.com/channels/564160730845151244/1162704045937541140

Hey,
Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.
When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.
Thanks for helping us improve Appwrite!

Unfortunately, I'm going to need to remove the hacktoberfest-accepted label as what's done so far doesn't actually implement anything.

No worries! It was great working with you all!

Well, kind of sad. Are there any plans to support it afterall? Oracle Cloud is undervalued for sure.

@iSuslov We'd still love a valid implementation of the Oracle Object Storage adapter. I just think the existing PR wasn't quite ready for merge.
We could also see a generic S3 adapter in the future, which would also solve the same issue.
TL;DR: We'd love to support it, this PR just wasn't ready for merge :)


Releases aren't sequential: 1.0.4 is made after 1.1.1

Also git describe shows that 1.1 was the last release.

Hi Yuri, can you please provide more info? 1.0.4 and 1.1.1 are bugfix releases to the 1.0 and 1.1 release branches respectively. They are not expected to be made in any particular order.

git describe information does not reflect the order of releases for this project. Here's the branching scheme that we use:

master is used for ongoing development for stable major version (v1 now). No releases are done from the master.
mnt-vX is for support of previous major version (v0 now). No releases are done from mnt-vX branches either.
rls-vX.Y branch is created for each minor release at code freeze. The release candidate, vX.Y release, and vX.Y.Z patch releases are done from this branch.

With that git describe HEAD points to the latest release candidate, instead of the latest release.
Hope this helps. Feel free to reopen or create new question if you have further question about releases and branches.


How to change settings.xml

Hello!
How to change setting "autoHyphenation" to set auto text wrap in parapgraphs like this:
(text in table cell):
"""
this is a simple text, do not try to un-
derstand  what is written here
"""
insted of
"""
this is a simple text, do not try to
understand  what is written here
"""
How to change this setting by lxml Element parsing? Don't understand by docs and sources, please help.

Hi, I just want to +1 this issue. The docs currently don't explain how to change document settings. For example, it shows a schema excerpt for the above setting:
<xsd:elementname="autoHyphenation"            type="CT_OnOff"˓→minOccurs="0"/>
but no examples are shown for how to set this on or off.
In scouring the net I could only find one example, here: https://stackoverflow.com/questions/45819839/when-using-python-docx-how-to-enable-spelling-in-output-document
but this format does not work for the setting I'm trying to change.


CST816 touchscreen  +ST7735 display

Feature Request or Enhancement
Please describe what you would like to see GUIslice do: ???
we are using CST816 as touchscreen driver , its a capacitive touch screen , i am using arduino board , which example can i follow to Test the same . display used is ST7735
Additional context
Add any other context or screenshots about the feature request here.
Display is tested with ST7735  driver .

@Ash8356 @ImpulseAdventure GUIslice doesn't supply drivers.  It's a feature rich set of additional API's built on top of other drivers with a Low Code Builder that allows you to create User Interfaces with a drag and drop interface.
I don't believe GUIslice currently supports the CTS816S chip so this needs to be an enhancement request first.
If you already have your hardware working with say Adafruit libraries you will need to wait for Calvin's response about software support.  You can test your display without touch using GUIslice config file ard-adagfx-st7735-notouch.h if you are using Adafruit GFX library.
The Adafruit drivers I found are:
An Arduino library for the CST816S capacitive touch screen IC
Adafruit-ST7735-Library
If you have examples with these or other drivers working then it would help Calvin (@ImpulseAdventure)  out to know what drivers you are using, version numbers and the exact Arduino board you are using, Arduino Mega? Other?
Paul--

@Ash8356 @ImpulseAdventure I should also mention that you can write your own interface to GUIslice for the CTS816S chip by following example ex16_ard_touch_hnd.  I have done that myself and its not that hard.
Paul--

Hello . I write a driver for that touch module. Look at PR. Tested . Worked perfect.


[dep] update semantic release

Describe the bug
Semantic release is out of beta. Two deps that semantic release rely on have security vulnerabilities. I'd rather update semantic release than update the deps under the hood, so I've closed #1378, #1379 in favor of this issue to update semantic release itself.
Semantic release v16 changelog has a list of breaking changes, we should validate if they'll impact us. We can probably update to --latest, v17.x - the only breaking change there was requiring a slightly higher version of Node 10, but we're using Node 12.

Plan of action here:

Create a next branch to do all this work on
Upgrade semantic-release on the next branch

can/should we mark these releases on next as prerelease?
can/should we configure the version name itself to have a different structure: v2.100.1-next-1 or something?

Configure travis to run on the next branch
Approve/merge PR
Validate the next build happens in travis and publishes a new version to next, not latest
Change repo settings - all new PRs should be automatically directed into next ( I think this is the "main branch" feature in settings?)
Change target branch from master to next on all open PRs
Open PR to merge next into master and test that the version numbers update appropriately.

:tada: This issue has been resolved in version 2.139.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update ITAdmin-readiness.md

Adding a new interactive guide for Android devices to the page, at the bottom of the table.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Make the Directory structure more intuitive.

Currently, there are scripts which do not lie in the script folder. We need to look for useful conventions to use.

I think you fixed this already


Collection level media_folder needs to be entry level for file collections

Is your feature request related to a problem? Please describe.

File collections can contain groups of entries that work quite differently from one another. Some entries may source their media from dedicated folders, Eg., a file with a list of authors and their bio pics.
Describe the solution you'd like

media_folder for individual entries (file type collections only).
the {{media_folder}} variable in this case would inherit the combined value of the global and collection level media_folder, if either are present.
should be accompanied by same level public_folder for absolute paths

Does bullet number 2 means we should join the two?
e.g.
media_folder: 'global'

collections:
  - name: posts
    media_folder: 'posts'
    files:
      - file: src/posts/post1.md
        media_folder: '{{media_folder}}/post1'

Should return in global/posts/post1 ? Or does it mean collection level overrides global one?

@erezrokah yep, we should join the two, sort of a cascade.
Sent with GitHawk

Oh wait... no, don’t join. Not sure what I was thinking, global will already be included in collection level if desired.
Sent with GitHawk

If collection level media folder is not defined at all, though, then it should resolve to global.
Sent with GitHawk

Cool, that should be covered in #3208


Cannot ask a question in stack overflow using tag aws-rails-provisioner (1500 reputation needed)

There are no questions in stack overflow with the TAG aws-rails-provisioner, maybe because to create a new tag, you need a 1500 reputation, which I do not have, so I can not generate the question with this tag. I like the concept of this tool, but it looks like it has been abandoned due to the difficulty of sharing solutions. Can anyone with such reputation create the TAG in stack overflow, please!

I do not have the necessary reputation either.. 😄 . Do you have any specific questions related to this tool? It's certainly been on life support because of other competing priorities.

@jlneto I'm late to the party but have just created the tag by attaching it to this post.


Export ZipkinSpanCollector and SpanProcessingThread metrics

Some examples:

spanQueue size of threadPool
number of active threads
number of log entries per thread
EVENT: number of rejected span submissions due to full queue
EVENT: number of successful span submissions to the thread pool
EVENT: span submission time to the thread pool
EVENT: number of bytes sent per emission of log entries to the collector/scribe
EVENT: span batch emission time to the collector/scribe
EVENT: number of emission errors to the collector/scribe
EVENT: number of successful emissions to the collector/scribe
EVENT: number of lost connections to the collector/scribe

I would suggest having them available via JMX for simplicity (event-based metrics could use max of a sliding window or alternatively send the events to opentsdb or graphite each time the event occurs).

Thanks! this definitely is a valuable proposal. Instead of JMX I would be inclined to use the Metrics library that I'm already using in flume-zipkin-metrics-sink.  This probably won't be on my priority list for the next months but if you feel like submitting a pull request, more then welcome!

metrics would be also cool :)

This is added to wanted/requested features in contributing.md.


Cannot delete Database resource that fails on creation

Hi
We tried creating a Database resource with a name that didn't match some criteria.
We are running operator v0.2.0 on k8s 1.22.
When we try to remove the resource, it doesn't seem to get deleted.
403: {"errors":[{"message":"Service database 'aiven-pg-test-220421a' cannot be deleted, reserved name pattern","status":403}],"message":"Service database 'aiven-pg-test-220421a' cannot be deleted, reserved name pattern"} -

So it seems that the same error that prevents creation does also prevent deletion.
Any idea on how to remove the resource?
Thanks

Hey. It seems like it's been fixed on the backend. Not a case anymore.


problems with auth

I followed the install instructions, installed curl, set up a new application, and entered the code to the .cfg file
I can navigate to the link and see the new application in my microsoft account permission page.
However the auth script returns an error message:
~/bash-onedrive-upload$ ./onedrive-authorize
Please open the following URL in your browser and follow the steps until you see a blank page:
https://login.live.com/oauth20_authorize.srf?client_id=00000000XXXX&scope=wl.offline_access%20onedrive.readwrite&response_type=code&redirect_uri=https://login.live.com/oauth20_desktop.srf

When ready, please enter the value of the code parameter (from the URL of the blank page) and press return

Something went wrong, here is the API response:
{"error":"invalid_request","error_description":"The provided request must include a 'code' input parameter."}

Did you enter the value of the code parameter (from the URL of the blank page)?
When you see the blank page you have to copy a part of the URL and enter it in the script.
The error_description suggests that the entered code was empty.
You can see the new application in your account permission page because the permission was granted, but the script does not (yet) know about that without the code (which is required to acquire an access_token).

Reading helps.


Module for generating an SSH public key file

@AMyachev thank you so much for taking the time to do this. Much appreciated!


Added favicons, opensearch, and manifest files for chrome

Deployed to: http://staging.quran.com:32977

Deployed to: http://staging.quran.com:32978

hmm why can't i merge this...

Deployed to: http://staging.quran.com:32980

Merging with banner PR

@mmahalwy merged this with https://github.com/quran/quran.com-frontend/pull/508 as I need manifest files to test the native banner.


Fix warnings generated by purescript-0.8.0

Thank you very much!
Would you mind holding this pr until prelude 0.8 update?
import Foo (class Bar) syntax doesn't work with psc < 0.8.0 and with old prelude user gets more then 600 warnings :disappointed:

@cryogenian Absolutely. Would you prefer that I close this one and resubmit/reopen later? I'm aware that the 0.8-without-warnings changes are breaking, just trying to help get things along so switching is easier.

@telser Yes, please. Thanks again!


Add environment variable to workflow

OK, I really hope this works this time. @harsimrat99 can you add the URI_MONGO environment variable as a repository secret called TEST_URI_MONGO?

@matt8100 I have added the requested variables. Please let me know if I should change anything else.

@harsimrat99 All that's left is to see if it works after merging

@matt8100 can we re-run the workflow before merging?

I do see that in the logs it is requesting for the URI_MONGO variable.

@harsimrat99 Unfortunately GitHub doesn't have an easy way to test workflows without just making more PRs. This PR contains a commit to add the environment variable, so it needs to be merged to see if it works.

Hmm. I understand and I see that this a but inconvenient. I did merge the branch, but I did not run the workflow again. I will try with the GitHub CLI and see if that works. I also saw the latest run, but that seemed to have failed albeit due to a different issue.


Typo in 0.4.0-beta.2 Release Notes

In the second bullet of the Update Guide, node_modules/bs-react-native/update_scripts/styles_v1_to_v2 should be changed to node_modules/bs-react-native/upgrade_scripts/styles_v1_to_v2. The former path is invalid.

Thanks for reporting! Fixed.

@MoOx also worth noting that I wasn't able to run the styles_v1_to_v2.exe executable at first and received this error:
/bin/sh: refmt: command not found
Fatal error: exception End_of_file

but installing reason-cli globally fixed it.

@gbau sorry, I assumed that you had it. Out of curiosity, what's the reason you didn't have global refmt?

@wokalski I hadn't needed to install it before. I've been using `bs-platform' to compile reason to JS and never ran into any issues.

so I installed refmt globally only, but still doesn't work.

@Tav0 are you on Windows? What’s the name of the global refmt executable ?

@wokalski I'm OSX. So I installed refmt by doing npm install -g refmt, I'm assuming that's the right one, right? I went to /usr/local/lib/node_modules/refmt/ and couldn't really find an exec in there. So then, I tried downloading reason-cli (that's another problem) and when I tried to installed it by npm, it would just throw me an error cb() never called. I can install other modules just fine, so I'm guessing reason-cli is also acting up. I downloaded the darwin binaries of reason-cli and in there I found the exec for refmt and refmttype(not sure if I need this one) I put these two inside the npm global path insiderefmt, but still same error when trying to exec styles_v1_to_v2.exe`

https://github.com/reasonml-old/refmt-js
These are pretty much all the files npm install -g refmt gives, but then again this repo is deprecated so I'm not sure how you guys assume refmt is installed globally. Is there another repo?

@tav0 @gbau the reason I’m surprised is that global refmt is among the tools needed for editor integration.
Most people install them via a global reason-cli install.

@wokalski What can I do in this case? ._.

@tav0 could you report this issue on the discord channel ?

Will do @wokalski thanks for the replies!

@Tav0 I mean the issue when installing reason-cli. There's something wrong happening, i.e. a bug :)


SVG Badge is not showing in GitHub notifications emails

The link is alright but the button image is missing.
Perhaps it's trivial.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog :^)

Thank you for the report, @drunkwcodes 🙏
I would say this is somewhat expected since our badge is a SVG image. Gmail doesn't support them.
Tackling this is quite complex 🤔 The solution is see right now would be to check for the User-Agent and try to detect if the request comes from Gmail. If so, we could return a fallback PNG image instead of the SVG badge.

For the record, here is the user-agent I catched from Gmail client: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko Firefox/11.0 (via ggpht.com GoogleImageProxy)

Closing as we probably won't dedicate time for this, lot of other focuses right now 😄


Fixing bug in issuer cache when updating idm type of a tenant.

Codecov Report

Merging #23 (c059a20) into master (bd1683f) will increase coverage by 5.12%.
The diff coverage is 81.59%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   73.43%   78.56%   +5.12%
==========================================
  Files           3        8       +5
  Lines         256      639     +383
==========================================
+ Hits          188      502     +314
- Misses         58      102      +44
- Partials       10       35      +25

Impacted Files
Coverage Δ

user.go
22.91% <0.00%> (ø)

token.go
75.00% <75.00%> (ø)

issuercache.go
79.33% <79.33%> (ø)

dex.go
83.05% <83.33%> (+0.29%)
:arrow_up:

tokenheader.go
89.47% <89.47%> (ø)

genericOidc.go
91.54% <91.54%> (ø)

mac.go
88.04% <100.00%> (ø)

usergetterproxy.go
100.00% <100.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea18f5...c059a20. Read the comment docs.


Documentation for Nuget packages with multiple frameworks lacks any valuable examples

The article is not clear enough, it's really missing some examples of how to create these Nuget packages from scratch. Some real, working code, with example of dependencies, is mandatory.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1482e18-5f1f-3a8a-3321-66af52879ec5
Version Independent ID: d70bd2f5-c04b-9207-62a0-4ecb6e8e5ca6
Content: Multi-targeting for NuGet Packages
Content Source: docs/create-packages/Supporting-Multiple-Target-Frameworks.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

Thanks for the feedback.
Are you more interested in a walkthrough type of documentation then? There are enough examples in this doc, they just don't really help walkthrough authoring a package from the ground up.
https://docs.microsoft.com/en-us/nuget/create-packages/supporting-multiple-target-frameworks#declaring-dependencies-advanced
One of the better resources for authoring is GitHub & seeing popular open source packages & how they create their nuspec:
https://github.com/Humanizr/Humanizer/blob/master/NuSpecs/Humanizer.nuspec
or downloading the package from NuGet.org & viewing a .nuspec directly.
https://www.nuget.org/api/v2/package/Microsoft.EntityFrameworkCore/5.0.1

Thanks for the feedback.
Are you more interested in a walkthrough type of documentation then? There are enough examples in this doc, they just don't really help walkthrough authoring a package from the ground up.
https://docs.microsoft.com/en-us/nuget/create-packages/supporting-multiple-target-frameworks#declaring-dependencies-advanced
One of the better resources for authoring is GitHub & seeing popular open source packages & how they create their nuspec:
https://github.com/Humanizr/Humanizer/blob/master/NuSpecs/Humanizer.nuspec
or downloading the package from NuGet.org & viewing a .nuspec directly.
https://www.nuget.org/api/v2/package/Microsoft.EntityFrameworkCore/5.0.1


Update historyRestructureID.R

ATL teamID should be 63 not 62
SEA teamID should be 62 not 63

Already done in commit in main.


relative path to root .env file fixed

Hello, sorry for getting back to you that late.
We do currently use solar-simulator with existing config and it seems to work properly. We're also using this file for 3 or 4 pilots. That's why I'd like to ask, if you could explain more on the context of this change, and, ideally if you could provide some tests if you think something's not working.
On my side I can provide some scenarios that should be working (which seem to work now):

ENV file should be correctly read by running solar-simulator server and consumer process
ENV file should be correctly run by mockreadings command (both top-level file, and also sub-level mockReadingsWorker)
ENV file should be correctly read when running yarn start in solar-simulator
ENV file should be correctly read when installing @energyweb/solar-simulator as separate package and running its executable (example command that runs it like that is: npx @energyweb/solar-simulator -e ../../../../../../.env -c ../../../../../../config/solar-simulator/config.json -d ../../../../../../config/solar-simulator/data.csv)

I know it's a lot of cases, but that's why I'm also hesitant on accepting the change without (ideally automated) tests.
Thank you for your contribution!

Hi @Kuzirashi. Thanks for your message. I'm also sorry for my late reply. Was sick in bed all week.
All your scenarios seems to run directly from the command line. If that's the case, they will work fine because they will all go through the following code:
if (require.main === module) {
    dotenv.config({
        path: '../../.env'
    });
   ...
}

In my case, I'm just running npm run 'run:origin' script from the app root dir. Which will include the solar-simulator as a module and avoid the above thread of code.
To replicate the issue:

Set the SOLAR_SIMULATOR_DEPLOY_PAST_READINGS variable in your root .env file to true.
From the app root dir run: npm run 'run:origin'
If the issue appears, past readings will not be loaded.

Regards,

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Clarify datex2 relationship

Hi @np00, as of this commit
you added a datex2 RDF version to this repository. I can not see any direct usage of mobivoc in this version and thus I'm not clear what its significance in regard to Mobivoc is.
We should clarify this with some discussion and optimally add some additional mapping. As long as this datex2 vocabulary only describes datex2 in RDF and does not relate to mobivoc, I don't think we should maintain it in this repository.
For now, I removed it from the develop branch and created https://github.com/vocol/mobivoc/tree/feature/datex2mapping where we can sole this issue and develop the relationship between both vocabularies.
In general, please refrain from pushing directly for develop. Please create feature branches for new features and handled the merge with develop using pull requests. This guarantees we have an orderly, agreed-upon process for extension of the vocabulary.

Hi @der-bruemmer - as the maintainer of the PoC mapping of Datex2 I’m eager to help out to find a future-proof solution for this mapping!

hey @pietercolpaert, that's great. I'm aware datex2 is a standard we have to consider in our work on mobivoc. However, I'm not sure this repository is the right place to work on the mapping. Shouldn't it have its own repository and release cycle?
What I would see relevant in the mobivoc repository is a mapping that maps datex2 to semantically equivalent mobivoc constructs or otherwise clarifies the relationship between the standards.
This could happen via owl:equivalentClass properties or other constructs that describe semantic similarity between constructs. This could also happen with a mapping specification describing how to transform mobility data described in datex2 to mobivoc representations or vice-versa.

It does have its own repository. No idea why it just got copied in here :-)
See: https://github.com/OpenTransport/linked-datex2
Would be happy to add owl:equivalentClass or even deprecate vocab.datex.org URIs in favour of URIs of mobivoc, if this one is going to be better maintained. Also the Transport Disruption Ontology has some equivalent classes (already added).
I’m going to present the vocab.datex.org initiative at the datex2 user group in The Netherlands next year. Hope these URIs are just going to be published by CEN themselves after that :-)

Thanks @np00! Looks interesting!

Datex2 road construction sites are now part of develop branch: https://github.com/vocol/mobivoc/commit/567dc138e2df58dffd02c7345b4246a4a8dd8a8b
They will be properly documented (ReadMe, schema.mobivoc.org) in the next release.

If you want to dct:conformsTo datex2.eu you should at least use their base URIs, no? Does it make sense to use http://vocab.datex.org/terms#?

If for some reason http://vocab.datex.org/terms does not address your use cases, we should ask the CEN group a formal question to make sure it is addressed

Hi @pietercolpaert,
I forgot to mention that I also added links to your vocabulary via owl:equivalentClass or owl:equivalentProperty.
I wanted to keep a reference to both: to your vocabulary hosted on your domain datex.org but also to the "official" datex homepage datex.eu. Or did I miss something, is datex.org part of the official datex2 community? :)
Example:
mv:SituationRecord owl:equivalentClass datex:SituationRecord;
                                dct:conformsTo "https://datex2.eu/" ;
    .

Example class description: https://github.com/vocol/mobivoc/blob/develop/schema/RoadConstruction.ttl#L32

Aha, right! I didn’t find it in the pull request but this does indeed make me happy!


Engage Page

Page and component redesign. Implement the data points

Pages are rearranged as Octo-Engage consists of Octo Stats Pages


Having trouble reading manhwa/hua in Longstrip.

Steps to reproduce
I updated my mihon to 0.17.1 but I can't still see any images.
Expected behavior
This should've been fix after the patch.
Actual behavior
It still not loading images after the patch.
Crash logs
No response
Mihon version
0.17.1
Android version
Android 8
Device
Vivo
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.17.1.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

It's not fully fixed for all the old devices having the blank page issue.
For now, try adjusting the bitmap threshold setting in Mihon Settings > Advanced, lower it until it shows (if it shows).
Otherwise:

Devices experiencing blank/black pages:

For some older devices, they are unable to handle the really large/long pages sources use:

Go to Mihon Settings > Downloads, enable "Split tall images"
This setting is not retroactive, redownload the chapter if it's already downloaded
Download the chapter & try reading it again
Otherwise, change the reading mode to Paged (if the above doesn't work/you don't want to download)

Easy download management

Go to Mihon Settings > Downloads, and enable "Download ahead" paired with "Delete automatically after read"
This makes it so you only download as you read, reducing unnecessary requests & to easily manage your storage usage

I can confirm this bug is back on my Samsung S7 Android 8.
Tested on Beta r7031.

Have you tried the steps lined out above? As you have a Samsung Galaxy device running Android 8, the setting mentioned may not be available for you.

Have you tried the steps lined out above? As you have a Samsung Galaxy device running Android 8, the setting mentioned may not be available for you.

Yeah, the settings for adjusting the Bitmap threshold are indeed hidden from the advanced settings.

Have the same probelm, the mentioned step already done but still not displayed properly

Fixed with https://github.com/mihonapp/mihon/commit/c5655e8803bc32d0931657f0b7bc6afeab70feaf


zookeeper protocol is not included at owner-extras jar

protocol classes are not included at assembled jar. Can it be because of

org.apache.felix
maven-bundle-plugin
1.4.0
true

org.aeonbits.owner.*

configuration

Looks like a valid issue.

duplicate of #114


Handle all aggregate exceptions

I've addressed highlighted issues and rebased.

Changes are great! +1 to merge


itest: simple taproot channel activation test

Ensures that https://github.com/lightningnetwork/lnd/issues/8065 is fixed.
This PR adds an integration test that ensures that a channel appears active if the initiating peer is disconnected from the channel peer during channel confirmation and reconnected after the channel confirmed.
Depends on,

#8078

Thanks @yyforyongyu and @Crypt-iQ for the review and fix, I addressed suggestions and nits and the test now repros the error reliably. I also ran the test on top of https://github.com/lightningnetwork/lnd/pull/8078 which makes the test succeed.

Closing in favor of #8078


Remove duplicates from JarList

Purpose
Remove duplicates from JarList for building and testing
Fixes #34357
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

We tested the fix at 2 states in GRPC : at the latest commit and as well as the commit where the issue was first found (95de4d)
For the latest commit, the netty changes were reverted (https://github.com/BuddhiWathsala/module-ballerina-grpc/commit/124c0e54bad05e76853e970b8eedec00ecbed0ed) and the fix was tested with on the latest stage branch. It should be noted that the ballerina-parser version 2.0.0-beta.6 was to be used to make sure the tests ran.
For the commit (95de4d), the HTTP module was using an old tcnative-boringssl jar which had to be updated for the tests to run.


Allow delay done

What changes do you make in this PR?

Please describe why you create this PR

We now support agent to be static for a little while after it is done. This will create nature static obstacles during the way and increase the difficulty of the scene!
Checklist

[ ] Add one config to MAEnv!! Default to delay_done=0

[ ] I have merged the latest main branch into current branch.

[ ] I have run bash scripts/format.sh before merging.

Please use "squash and merge" mode.

I have finished this, and please directly run marl_inout_roundabout.py and try to drive a little while!! Hope this is working!!
BTW, don't merge yet, the config is not added!


fix typo in raygui.h

Documentation in raygui.h mentions method GuiLoadStyleDefaulf which likely should have been GuiLoadStyleDefault.

@Gidan Thanks for the review!


add fromTimestamp

Hello! @robinvdvleuten
I'd like to have an API generating ULID from timestamp exposed.
I have to create ULID for past timestamp.

@tkrtmy thanks a lot for this feature! Really appreciate your effort!


Compatibility with PHPUnit 7.4

Running zend-ldap test suite
Fatal error:  Declaration of phpmock\phpunit\MockObjectProxy::__phpunit_verify() must be compatible with PHPUnit_Framework_MockObject_MockObject::__phpunit_verify(bool $unsetInvocationMocker = true) in ...

That is why one should not depend on private implementation details.

My first thought was that this might be similar to when this project failed to work against the minor update to PHPUnit 6.5 https://github.com/sebastianbergmann/phpunit-mock-objects/issues/390 . In that case however, the underlying phpunit-mock-objects had a major version increase to v5.0.0 and the fix was not so simple: https://github.com/php-mock/php-mock-phpunit/pull/20
This time a public method on the MockObject interface has changed its signature in a minor version of PHPUnit, which does seem like a BC break as any implementation of this method will no longer be compatible.
Fortunately updating the method signature in this project will work with PHPUnit 7.3 and 7.4 as the extra parameter in the implementation does not affect compatibility with the lack of the parameter in PHPUnit 7.3:
interface A {
    public function foo();
}
class B {
    public function foo(bool $newParam = true) {
        echo 'bar';
    }
}
(new B())->foo();

Fixed in #30 and released in version 2.1.2.


Trigger CI/CD checks in PRs

CD/CD checks should happen prior to merging branches into the develop branch.
Create triggers/actions that check that a PR will pass our build pipeline when a PR is opened.

@Necromos I think it comes down to same steps that happends in CI, except:

deploying to bucket/cdn.

It looks like all this PRs check we lunch thrue CI-pipeline.yml, should we merge it somehow with azure-pipelines.yml... what's your thoughts about it ?
The one gotcha is that we are updating algolia indexes while lunching build for PRODUCTION stage...


Cannot run latest version - connection

Has this script been shut-down/ no longer working?
When running the demo script and identical search I get the following error.
ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))

Having a similar issue:
raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Having a similar issue:
raise RemoteDisconnected("Remote end closed connection without" urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

This happened to me too! From the requirements file (requests>=2.27.1) the requests package was downloaded with v2.31 on my machine but there seems to be a conflict with that version (I haven't tried any other between those two). Setting the version to 2.27.1 fixed it.


medication dispense medical_program error validation added

https://github.com/edenlabllc/ehealth.api/issues/3077

Coverage remained the same at 91.297% when pulling dc2c2d9eba1d989d3ed5b3c8d29e32100ec64616 on medication_dispense_incorrect_error#3077 into 8c9ae86c43f8d0069999fc439317be541911a905 on develop.


SWE: spin phase

Change Summary
closes #886
Overview
Setup L2 processing function and calculate spin phase in it.
Updated Files

imap_processing/swe/l2/swe_l2.py

calculate spin phase using existing utils function from geometry.py

Testing

imap_processing/tests/swe/test_swe_l2.py

pre-commit.ci autofix

Approving so that you can sort this out however you want. Merging and writing a ticket for follow-up is appropriate.

Thank you Tim. I created issue to address some of feedback from this and last PR. I will revisit in January. https://github.com/IMAP-Science-Operations-Center/imap_processing/issues/1232


Update plugin reference version to latest available

This will fix the build with the plugin linter so that tests will pass.

@pzeballos This will probably require a new release (🤡 2.0.0 🎉)

Awesome! LGTM!
If you want we can do it together tomorrow :)


Followup Zulip API client get_subscribers()

In Zulip API client, there is a function named get_subscribers(). This function has just been modified by a new commit that replace all stream_name with stream_id https://github.com/zulip/zulip/commit/d3ee53bdef75eb1fe6b71fb008c754b005a29ce2
And there is a exception, that's not handled correctly and hard to read.
-        stream = urllib.parse.quote(request['stream'], safe='')
-        url = 'streams/%s/members' % (stream,)
+        request_stream_id = self.get_stream_id(request['stream'])
+        try:
+            stream_id = request_stream_id['stream_id']
+        except KeyError:
+            return request_stream_id
+        url = 'streams/%d/members' % (stream_id,)

Look at the except KeyError:, many developer will confused with that. Probably we need to raise a exception there or something better..

Working on this..


Re-structure and simplify the main loop

Definitely going to try this tomorrow...

@lennysh  Did it work?

Just merged this request into my music-patch-1 branch as it seems to work perfectly!  Thanks @KonstantinSchubert for the work, and @dliloch for reminding me about it, lol.


getting error 'React/RCTBridgeModule.h' file not found

I am getting this error while installing this package.

What React and React Native version are you on?

I am using React-15.4.1 and React-native 0.39.2

Kay, can you replace that line with the following and tell me if it works?
#if __has_include("RCTBridgeModule.h")
#import "RCTBridgeModule.h"
#else
#import <React/RCTBridgeModule.h>
#endif

perfect it worked! I think you should update this in your library so that there should not be any conflict in the syntax for new and old versions of react-native.
here is the screenshot:

Thanks for your help!

You bet I will. That was originally the plan - see #17 -  but the PR got closed and was never fixed again.
Thanks for bringing this up again.

Done! 👍


Can we list pyarrows as a dependency?

I frequently run into this issue:
ModuleNotFoundError: pa.array requires 'pyarrow' module to be installed

Thank you!

It is from:
sdata = prepare_sdata(bigwigs, sample_names, out, peaks_df, fasta)
  File "/tscc/nfs/home/hsher/projects/RBPNet//prep_data.py", line 60, in prepare_sdata
    sdata = sd.from_region_files(
  File "/opt/conda/lib/python3.9/site-packages/seqdata/xarray/seqdata.py", line 373, in from_region_files
    pl.from_pandas(_bed),
  File "/opt/conda/lib/python3.9/site-packages/polars/convert.py", line 719, in from_pandas
    return pl.DataFrame._from_pandas(
  File "/opt/conda/lib/python3.9/site-packages/polars/dataframe/frame.py", line 641, in _from_pandas
    pandas_to_pydf(
  File "/opt/conda/lib/python3.9/site-packages/polars/utils/_construction.py", line 1547, in pandas_to_pydf

Sorry I found I have reported it already


python packaging

get running with pip, as at https://github.com/dunnlab/phylopytho

https://pypi.org/project/countland/


2 Disc Games

How do we utilize 2 disc games like MGS? If I have both images in the same folder, the plugin will no longer load any games?

I still need to implement that. For now, it won't work but I'll try to make
it work later. It's a known issue that if one of the images in the GameCube
folder doesn't work, none of them are recognized so I'm assuming that's why
it hasn't shown up. I'll try to fix it soon!
On Thu, Sep 5, 2019 at 12:26 PM Mobeeuz<EMAIL_ADDRESS>wrote:

How do we utilize 2 disc games like MGS? If I have both images in the same
folder, the plugin will no longer load any games?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/JTNDev/galaxy-integration-gc/issues/3?email_source=notifications&email_token=AJ5LEJ6PLRROEDAQBIL36CLQIEXKZA5CNFSM4IT75QCKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HJS2RRA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ5LEJ45J74FE2G3RBRBRC3QIEXKZANCNFSM4IT75QCA
.

Has there been any progress with this issue?

No progress yet, but I plan on implementing a method where the import
process won't depend on the ROM file name which should enable two disc
support to exist. It should be coming out in the  next week or so
On Sat, Nov 23, 2019 at 10:08 AM Mobeeuz<EMAIL_ADDRESS>wrote:

Has there been any progress with this issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JTNDev/galaxy-integration-gc/issues/3?email_source=notifications&email_token=AJ5LEJ2SG4FEGAWVJ24A4KLQVFBODA5CNFSM4IT75QCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE7W7JQ#issuecomment-557805478,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ5LEJ46IY6FPE562MUT3ZTQVFBODANCNFSM4IT75QCA
.

Unfortunately, I don't think this is possible.
Whenever I try to implement a way to make the game show up twice in GOG Galaxy, the second one will not show up.
I can't also make it have a slightly different name like "Baten Kaitos (Disc 2)" for example, because then GOG Galaxy fails to get metadata for it and will say "Sorry, we couldn't load the data".
Until GOG Galaxy adds a way to make alternate launch parameters as described here, the only feasible way to implement it would be making the user switch the discs outside of GOG Galaxy 2.0 maybe using a settings menu that I haven't implemented yet or the user config file.

It will still launch the game though but it won't have any metadata at all other than a custom title, date, tag, cover, background, and icon

Having any unrecognized ISO in the ROMS folder will cause the plugin to show Install instead of Play. How about the plugin adds the unrecognized file to the list of games using the filename, even without metadata. Users could then add info themselves.

Unfortunately, I don't think this is possible.
Whenever I try to implement a way to make the game show up twice in GOG Galaxy, the second one will not show up.
I can't also make it have a slightly different name like "Baten Kaitos (Disc 2)" for example, because then GOG Galaxy fails to get metadata for it and will say "Sorry, we couldn't load the data".
Until GOG Galaxy adds a way to make alternate launch parameters as described here, the only feasible way to implement it would be making the user switch the discs outside of GOG Galaxy 2.0 maybe using a settings menu that I haven't implemented yet or the user config file.

Can you just enable disc switching? I don't need the two disc version to appear twice but just ensuring the disc switching feature from dolphin works through GOG would be great. I  posted about that on the wii page when i meant gc


Use Hiscore Sprites For Kill Count Notifier

Checklist

[X] I've searched the issues and pull requests for similar looking suggestions.
[X] I've checked the Unreleased section of the changelog for newly added features that sound like my suggestion.

Describe your Suggestion
Instead of using the default Slayer Gem icon, use the boss's hiscore icon.
From the little bit of research I did it looks like all the new icons are in the cache and I was able to locate all the sprites from melkypie/sprite-exporter.
Edit: If this does seem like something the Dink team wanted; I'd love to help out creating this feature 🙂
Example

Reasoning
It would give a bit more spice to each embed. It would also be a bit easier identifying what the notification is about at a glance with an icon of that boss.

while certain images may be in the cache, we don't want to have to upload those images from the client for notifications - so we limit ourselves to static images from the osrs wiki cdn
it'd be easy to include an image of the npc for the thumbnail, but the heterogeneous sizing (and large images) may make it look weird

the wiki doesn't appear to have a consistent file nomenclature for those boss hiscore images, so closing as not planned for now.


Provide documentation on how to integrate addons

See also https://docs.google.com/document/d/1jJ4kkALCUPWIlz_Ldu6jpeelMNxyY_SZDMaZmeSpfkM

fyi @istio/wg-docs-maintainers

All of the components are closed now, except Kiali which needs minor changes to the doc. Dropping to p1 as a result

Closing as all associated issues are closed


[Map] Show job cards at bottom of map

Each card represents one LOI.
Cards show: Job name, LOI name and ID (if present), Completion status, "START" affordance to collect data
If identical LOIs (e.g., same coordinates) exist in multiple jobs, one card is shown for each
Swiping through cards sets focus to LOI
List updates after map settles after panning/zooming

@ngosue Please paste mocks once ready

I've started working on this feature. I'm planning to implement this in multiple phases rather than a very big PR:
1. Basic implementation of cards for each LOI.

Adding a recycler view to the MapContainerFragment
Showing a card item for all LOIs in the active survey.
On switching the survey, the cards should also get updated.
Only basic information (jobName, loiCaption, etc.) would be shown

2. Filtering cards based on map viewport

Filter the cards based on current LatLng bounds
List should auto-update on panning/zooming in addition to switching survey

3. Add focus to LOI map pin when swiping the card list

Add a focus property to view holder and update UX of selected card
Get LOI id from the viewholder and update the UX of drawn geometry

4. Integrate with data collection flow

Add listener to "Start" button
Change button text to "complete" if the target is complete
Add completion status to each card

Confirmed UX behaviours (@ngosue):

Cards should get auto-selected on swiping. In addition to that, clicking should also select the card.
Highlight the selected card (for prototyping, add some border color)
Also focus the LOI when selecting a card
GPS button should be anchored to the card list (so drop it to the bottom when empty)
Map type should be on top right corner, below search bar (similar to gmaps)

Cards are current added directly to the MapContainerFragment. This prevents unit testing of the UI since it expects GoogleMapFragment which isn't available in unit tests. Therefore, in order to improve test coverage, we might have to either create a custom ui or remove dependency on GoogleMapFragment in unit tests

I was referring to creating a view container which will only contain the recycler view.


Adding websockets to the core script

Ft Add Websockets to Core Script
Changes

Added websocket publishing of events to the core script. By default websockets are not enabled
Added 3 additional optional args to the __main__.py file

websocket-host, default="localhost"
websocket-port, default=8675
enable-event-websockets, default=False

QA

Run the updated section in the README to verify the above changes
Run other sections to ensure nothing broke and that the server will function without the websockets being enabled

CC @synesthesiam

what are you using the websocket for?


Changes to kll

This, unfortunately, is a massive PR, and will be difficult to review.  Nevertheless, the main goals of this PR:

Fix the getQuantile(), getRank(), getPMF(), getCDF() for the REQ and KLL sketches so that they properly handle both INCLUSIVE and NON_INCLUSIVE queries.  ( I haven't done this for classic quantiles, but this is already so big I decided to get this PR done and do another PR for classic.
This also involved fixing some bugs in the InequalitySearch and GenericInequalitySearch classes.  These bugs only involved sketches with only a single item.
This also involved streamlining the Sorted View classes. By leveraging the SV classes for getRank, getCDF, and getPMF, I was able to eliminate over 300 lines of code.  I haven't done this for REQ, as the savings was not quite as large, but may still decide to do this in REQ before we finally push to master.
Change all references to "item" to "value" for numeric valued quantile sketches. We decided to use "item" only for the generic sketches.  This was huge as there were hundreds of uses of "item" in almost every class.
i did extensive rewrite of javadocs and code comments where I found them confusing or incomplete.

This is now FROZEN and ready for review.  No more changes!


SDCSRM-185 Fix Dependabot test failures in rh-service

Motivation and Context

[ ] Context Index has been kept up to date
TEST PR

What has changed

How to test?

Links

Screenshots (if appropriate):

https://jira.ons.gov.uk/browse/SDCSRM-185


Summary chain with chat 3.5 turbo

Hello Guys,
I am currently trying to make chain summary of long document with langchain (before that I did my own tools) but the summaries dont seem to work with get3.5 wich can only be made using the chatversion. Do someone has an exemple of implementation on that matter?

Thanks @hanguofeng I just did the same on my own after a lot of tries. Right now I am trying to add a SystemMessage at the beggining.

Ok i just made in, not that hard at the end :
template = "You are a financial analyst make summary of presentation and meetings."
system_message_prompt = SystemMessagePromptTemplate.from_template(template)
human_template="{text}"
human_message_prompt = HumanMessagePromptTemplate.from_template(human_template)
prompt = ChatPromptTemplate.from_messages(
    [system_message_prompt, human_message_prompt],
)
chain = load_summarize_chain(llm, chain_type="map_reduce", return_intermediate_steps=True, map_prompt=prompt, combine_prompt=prompt)
chain({"input_documents": docs}, return_only_outputs=True)


More intuitive names for objects

eg, ElectricalSource|Sink|Link -> VoltageSource|Sink|Link
TODO: find the other ones

Resolved by #32


Move Pip Installation to requirements.txt

what

Move all python requirements to requirements.txt
Use multi-stage build pattern as described here: https://blog.realkinetic.com/building-minimal-docker-containers-for-python-applications-37d0272c52f3

FROM python:3.6-alpine as base
FROM base as builder
RUN mkdir /install
WORKDIR /install
COPY requirements.txt /requirements.txt
RUN pip install --install-option="--prefix=/install" -r /requirements.txt
FROM base
COPY --from=builder /install /usr/local

why

Rely on python package management
Automatic package updates by Dependabot

Did you mean all pip packages in dockerfile?

Fixed in https://github.com/cloudposse/geodesic/pull/253/commits/7d9c8ec351f7cfc4447e8010c2ba537b9947ef9d


Changes for Issue #8

First pass at implementing issue #8.
I'm fairly new to some of this and it may not be the direction you want to take the project in, but I thought I'd offer up what seems to work well for me.

Thanks @rgauss
This is a great feature.
Let me do some testing before merging it in. I will post my feedback as I test the code.

I am seeing the following error when using the commands back to back ... i.e have everything powered off and then ask it to turn on different channels
Starting to watch kqed!
Starting Activity Watch Tivo id:13612333
Watch Tivo is not the current activity yet, waiting another 3000ms ...
Watch Tivo is not the current activity yet, waiting another 3000ms ...
Watch Tivo is not the current activity yet, waiting another 3000ms ...
Watch Tivo is now the current activity
events.js:85
throw er; // Unhandled 'error' event
^
Error: MAX_CLIENTS=6
at Connection.onStanza (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/node-xmpp-client/node_modules/node-xmpp-core/lib/Connection.js:355:17)
at StreamParser. (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/node-xmpp-client/node_modules/node-xmpp-core/lib/Connection.js:226:10)
at StreamParser.emit (events.js:107:17)
at SaxLtx. (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/node-xmpp-client/node_modules/node-xmpp-core/lib/StreamParser.js:58:14)
at SaxLtx.emit (events.js:107:17)
at SaxLtx._handleTagOpening (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/ltx/lib/parsers/ltx.js:31:18)
at SaxLtx.write (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/ltx/lib/parsers/ltx.js:105:26)
at StreamParser.write (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/node-xmpp-client/node_modules/node-xmpp-core/lib/StreamParser.js:123:17)
at Connection.onData (/home/sushil/work/test/alexaHarmonyApp/node_modules/harmony-hub-util/node_modules/harmonyhubjs-client/node_modules/node-xmpp-client/node_modules/node-xmpp-core/lib/Connection.js:305:17)
at Socket.emit (events.js:129:20)
at readableAddChunk (_stream_readable.js:163:16)
at Socket.Readable.push (_stream_readable.js:126:10)
at TCP.onread (net.js:538:20)

I am going to merge it as it worked well on my setup I did few iteration of testing on it.
The one problem I noticed seems to be only showing up when I do operations quickly.
If it's observed by others I will address it at a later time.


add tenant label to offerings and plans

Tenant label is required for offerings and plans in addition to the current setup in which broker labels only has it.

@evyaffe can we close this one? we can keep the branch around if we think we might need it at some point


@PathVariable is not getting interpolated if the variable is null

@RequestMapping(value = "/items/{id}", method = RequestMethod.PUT)
  ItemResponse updateItem(@PathVariable("id") final Integer id, ItemRequest request);

FeignClient is not throwing any Null pointer exception or Errors when id is null while invoking the above feign client method; it simply send a string {id} to the service, instead of trying to interpolate and fail. This is very misleading IMHO.
My server side was a spring boot app and it had the similar configuration for the PUT endpoint and it went to a http500 with the following exception.
java.lang.NumberFormatException: For input string: "{id}"

I am not sure it is valid to have an "optional" @PathVariable.  I believe the correct thing to do is to have to @RequestMappings.
@RequestMapping(value = "/items", method = RequestMethod.PUT)
 ItemResponse updateItem(ItemRequest request);

@RequestMapping(value = "/items/{id}", method = RequestMethod.PUT)
 ItemResponse updateItem(@PathVariable("id") final Integer id, ItemRequest request);

Exactly, it is not optional, it is mandatory. So, what Feignclient should have done differently is , instead of concealing the fact that id came as null, it could just throw a null pointer exception. If feignclient just keep sending non-interpolated string "{id}", I will not be able to understand where is the problem.

I suppose that is something we could do.

@ryanjbaxter I want to help. But, I am new to spring cloud codebase. Any pointers to where to start will be really helpful?

I just tried to reproduce this and in my test it never made it to the server.  The client through a URISyntaxException because of the {.  You are not seeing that exception being thrown?

@ryanjbaxter Thanks for looking into this. Here is a repo where issue is reproducible. This is pretty much vanilla implementation. https://github.com/jaisonpjohn/feignclient-issue
Apologies for not submitting a repo before.

Could you provide the "ItemService" as well to make the sample work?

@ryanjbaxter Sorry for the late reply. https://github.com/jaisonpjohn/feignclient-issue-api This is the API which my feign-client was trying to hit.

I am still not seeing it actually make it to the service.  Feign is throwing the following exception in my environment (using your samples)
Caused by: feign.FeignException: status 400 reading ItemRestClient#updateItem(Object,String); content:
{"timestamp":1507150701220,"status":400,"error":"Bad Request","exception":"org.springframework.web.method.annotation.MethodArgumentTypeMismatchException","message":"Failed to convert value of type 'java.lang.String' to required type 'java.lang.Integer'; nested exception is java.lang.NumberFormatException: For input string: \"{id}\"","path":"/items/{id}"}
	at feign.FeignException.errorStatus(FeignException.java:62) ~[feign-core-9.5.0.jar:na]
	at feign.codec.ErrorDecoder$Default.decode(ErrorDecoder.java:91) ~[feign-core-9.5.0.jar:na]
	at feign.SynchronousMethodHandler.executeAndDecode(SynchronousMethodHandler.java:138) ~[feign-core-9.5.0.jar:na]
	at feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:76) ~[feign-core-9.5.0.jar:na]
	at feign.ReflectiveFeign$FeignInvocationHandler.invoke(ReflectiveFeign.java:103) ~[feign-core-9.5.0.jar:na]
	at com.sun.proxy.$Proxy58.updateItem(Unknown Source) ~[na:na]
	at com.jaison.feignclientdemo.Runner.run(Runner.java:15) ~[main/:na]
	at org.springframework.boot.SpringApplication.callRunner(SpringApplication.java:732) [spring-boot-1.5.7.RELEASE.jar:1.5.7.RELEASE]
	... 6 common frames omitted

@ryanjbaxter I believe the error message {"timestamp":1507150701220,"status":400,.... is coming from the service. Otherwise why would it end up in this error java.lang.NumberFormatException: For input string: \{id}\"","path":"/items/{id}" (if you scroll all the way to right in the stacktrace you can see this)

@ryanjbaxter even if it is not hitting the service (I still don't think that's the case) error For input string: \{id}\"","path":"/items/{id}" appears cryptic to me. I think, if we gave back a nullpointer exception saying path variable came as null, that would be more straight forward.

@jaisonpjohn the reason I don't think it is hitting the service is because I don't see the log message in your sample app being printed when I execute the request.

@ryanjbaxter That is because spring MVC couldn't map the request to that method (it failed during mapping) I think that log statement is a bit misleading in that respect, sorry about that.
Updated the api project, added a webfilter which will log the request URL much before spring-mvc filter chain kicks in. That webfilter is printing Request Received. URL is: /items/{id}


th07 stores stage splits for end-of-stage, everything else is the start of the stage

so you mean that the scores are end of stage while everything else is start of stage?

the game literally uses the previous stage score for the start score, theres no other way


Reflect nightly changes

Just a simple touchup. :)

Thanks!   I'll push a package update this weekend.