Release Checklist 1.54

Issues in Release

[x] #2806 @devincowan
[x] #4473 @hyi
[x] #4535 @pkdash
[x] #4524 @pkdash
[x] #3526 @devincowan
[x] #4140 @devincowan
[x] #4374 @devincowan
[ ] #2313 @pkdash
[x] #2275 @devincowan
[x] #4531 @pkdash
[x] #3073 @pkdash
[x] #4520 @sblack-usu
[ ] #4406 @pkdash
[x] #3053 @devincowan
[x] #4090 @devincowan
[x] #3451 @devincowan
[x] #2793 @devincowan
[ ] #4541 @pkdash
[x] #3534 @devincowan
[x] #4530 @pkdash

Beta Deployment

[x] Diff RC to master to identify and manually make changes in the following files:

hsctl
config/hydroshare-config.yaml
nginx/config-files/hydroshare-ssl-nginx.conf.template
scripts/templates/docker-compose.template

[x] Deployed to Beta
[x] Review the search and discovery pages
[x] Create a new user and update profile
[x] Create iROD account, test connection and delete iROD account
[x] Create a new resource, check sharing/permission settings, delete new resource
[ ] Developers test around issues
[ ] QA testing around issues
[ ] Stakeholders approval

Production Deployment

[ ] Deployed to Production

Make manual changes to files identified in Beta Deployment

[ ] Maps API key is correct and maps are displaying correctly
[ ] Review the search and discovery pages
[ ] Create a new user and update profile
[ ] Create iROD account, test connection and delete iROD account
[ ] Create a new resource, check sharing/permission settings, delete new resource
[ ] Developers test around issue

Notes relevant to deployment

The db needs to be migrated.
No configuration files need to be manually updated.
Need to run management command migrate_script_resources

@sblack-usu Checklist item 4390 file based json api should not be me to verify.

@pkdash that was my bad, I thought it was your issue not one of @sblack-usu

That one shouldn't even be in the release checklist, it was part of an earlier release.  It got picked up because the branch name in https://github.com/hydroshare/hydroshare/pull/4529 had a typo #4406->#4066
It is removed, sorry for the confusion.

https://github.com/hydroshare/hydroshare/issues/4561
https://github.com/hydroshare/hydroshare/issues/4560

@sblack-usu Verified and closed #4524 and #4541.


Allow disabling low-processor mode on headless platforms

This can be used when you want processing to happen as fast as possible (at the cost of high CPU usage). This is generally not what you want for a dedicated game server, so low processor-mode is still enabled by default on headless platforms.

Enable low-processor mode by default on headless platforms (mimics the previous behavior).
Use a 60 FPS limit on headless mode by default (down from 144 FPS). This can be overridden by changing the Server override for application/run/low_processor_mode_sleep_usec. This allows effectively changing the server's _process() tick rate, balancing CPU usage and network bandwidth usage with latency.

This closes https://github.com/godotengine/godot/issues/32404.
Question: Can someone check if feature tags are actually case-sensitive? The documentation claims they are, but I noticed the Windows pen driver code uses .windows instead of .Windows to override the default setting. cc @bruvzg

You have some changes that I already checked in in master, needs a rebase.

You have some changes that I already checked in in master, needs a rebase.

Fixed.
Also, remember that in the master branch, this pull request won't have any effect since the server platform hasn't been reimplemented yet. When we get around to making the headless DisplayServer, it should have the Server feature tag applied to it (or server if we settle on making all feature tags lowercase).

Question: Can someone check if feature tags are actually case-sensitive? The documentation claims they are, but I noticed the Windows pen driver code uses .windows instead of .Windows to override the default setting. cc @bruvzg

https://github.com/godotengine/godot/blob/07f076fa4f2896415993bb8e3fb42128423de0d2/core/os/os.cpp#L364-L370
It seems to be case-sensitive, the pen driver override should be changed to .Windows.

@bruvzg Thanks, I opened a pull request to fix this: ttps://github.com/godotengine/godot/pull/47255

I've been wondering, would it make sense to have the !p_can_draw sleep time independent from the low_processor_mode one?
Normally, the engine is expected to run at a fixed iteration per second. This is usually handled by vsync. But as I understand it, when the window is minimized vsync won't happen, and we would end up doing millions of iterations per second. To avoid this we add the low_processor_usage_mode_sleep_usec delay (even if we are not in low_processor_mode).
But what we really want to do in that case, is trying to keep the FPS constant, so if we are not in low_processor_usage_mode what we should do is keep the FPS value consistent with the previous one, i.e. the vsync-ed one.
When vsync is unknown (headless) or disabled, either target_fps must be specified, or a default can be used (e.g. 60).
I'm also unsure if we should keep low_processor_usage_mode_sleep_usec at all. It's confusing, and if you are creating an app, you can set the target_fps if you really want the loop to sleep more and have almost the same result (keeping low_processor_usage_mode = true).
Thoughts? ( @reduz )

@Faless See also https://github.com/godotengine/godot-proposals/issues/2001, where I suggested capping the FPS to 20 in unfocused and minimized windows by default.

So, maybe with hindsight from your proposal, we could change low_processor_mode_sleep_usec to be low_processor_mode_max_fps and have a low_processor_when_incative (unfocused/minimized) boolean option,

@Faless Sounds good to me :slightly_smiling_face:
However, I want to stress that even with low-processor mode, the default FPS limit is quite high. Being able to use a lower FPS limit selectively can help a lot with decreasing power consumption.

This can be used when you want processing to happen as fast as possible (at the cost of high CPU usage). This is generally not what you want for a dedicated game server, so low processor-mode is still enabled by default on headless platforms.

Why this is not something you generally want?
What type of games with a dedicated game server is better suited with low-process enabled and what with it disabled?
If it is a session based competitive 5v5 fps game it is better with low-process disabled right?

Why this is not something you generally want?

Simulating _process as fast as possible wastes CPU cycles, which is problematic for server environments where you're hosting multiple servers on the same machine.


Using a named view no longer works

It seems the views for this were removed here: https://github.com/aljosa/django-tinymce/commit/1535f5c33544c4ac49d397ec14e2ec88e177587d#diff-99f82678a1ffa0a31e0576ec938419c9
But it's still documented here: http://django-tinymce.readthedocs.io/en/latest/usage.html#using-the-view

They are used in 3rd party libs like zinnia-wysiwyg-tinymce, this change broke everything, a workaround on this?

I copied the view and urls entries that were removed into my own code, but it's a bit nasty!


Fixed link to ws2 viewer

This was fixed in 642f4a6350aba0c55c1fc4ef6200b1ad8a210495 but hasn't ended up in the live docs site yet as there hasn't been a release since

That commit is now in a release so the docs have updated: https://docs.s2cell.aliddell.com/en/stable/useful_s2_links.html. Thanks


SB2 exports needed to understand new power fields

The cloud server provides additional solarbank fields in the scene info response which are not understood.
It is assumed they have been introduced for coming support of SB2 AC and support of SB1 in combination with a SB2 (maybe in same system?)
Solarbank fields:
    "other_input_power": "0",  => Unknown? Maybe DC input for battery charging when grid to battery is AC?
    "micro_inverter_power": "0",   => AC Output power for SB2? Should be lower than other output power values, if those are DC?
    "micro_inverter_power_limit": "0",   => Inverter output limit? Used for all SB2 models?
    "micro_inverter_low_power_limit": "0",  => Unknown
    "grid_to_battery_power": "0",   => DC or AC charging power?
    "pei_heating_power": "0"   => Total heating power for the batteries?

Site fields:
    "scene_mode": 0,   => ??? Probably used only for display mode in App
    "is_downgrade": false,  => ??? Upgrade indicator for some new App feature
    "priority_discharge_switch": 0,   => new SB1 dischage prio switch setting, 0 = OFF, 1 = ON
    "display_priority_discharge_tips": 1,   => Indicator for App to show switch tips automatically when enabliing new switch the first time. Will be set 0 if displayed once for the account in the App
    "is_show_priority_discharge": 0, => Indicator whether new switch to be presented. All SB1 in system must be on FW 2.0.9 or higher to enable the switch feature and set this to 1
    "priority_discharge_upgrade_devices": "SB E1600",  => Shows which SB1 devices must be updated to enable the feature
    "style_id": 0,  => ??? Unknown

@thomluther what system exports are needed now?
SB2 or /and SB1 or only SB AC?

i have a SB2 Pro, and the heating feature should be on board, but so far i did not see the heating turn on, based on the api, rather see any markers in the app which would/could indicate there is a heating, i can only see the battery temperature, which is something i think is yet not inside the api or i did not find it.
not sure when the heating kicks in, temps outside so far are 0-5 degree celcius here, the battery charging is 99% slowed down by the outside temps, during high noon it sometimes kicks lots of energy to the grid instead of charging, i think it is a battery temp issue, i expected the heating to kick in somewhere at this point,
will keep an eye on the heating and if it comes up do an export

This new fields may be used only after required firmware changes on SB2? Maybe it is an enhancement that was prepared only in the cloud so far, but the SB2 also needs to send those data to the cloud.
And some of the new features may also require an App update to make them visible, but I think the App is up to date since it stated AC support already for recent release.
However, maybe the SB2 firmware still needs enhancements to provide additional information to the Cloud/App for the heating power....

BTW, it would be helpful to get an export when there are updates pending for SB2 or batteries.
I haven't seen a prove yet, whether the ota_batch query returns the latest available versions per component and if the library interprets the fields correctly.

i just checked 2h ago there is no app or any device firmware update here so far.
the SB2 Pro is at v<IP_ADDRESS>
if there is a firmware update in the pipe, i get you an export :)

export_2024-12-20_1235.zip
Heres my export file from my SB2AC, some backup and active routines included in the app.

metrics_sites.json
metrics_energy_details.json
metrics_device_details.json
I can See a pending Update for my solix 2 pro
From <IP_ADDRESS>
To <IP_ADDRESS>
I have removed the an of devices. Let me know If this helps or more information Is required

Thanks for the exports, will Look at them in 2 weeks after vacation.

@kantmn, the metrics are from a shared account only and show only what is known by the library.
To get all Data from known Api requests, an export from the Owner account is required.
For New features you may even have to explore New Api request parameters on your own.
For example I don't know if the new AC schedule is provided with the known get_device_parm request parameters.

For the pending firmware updates I validated meanwhile that this new method seems to work reliable with SB1. So when any update is Flagged in the App it should also be Flagged in the Api Cache and HA Integration.

For the pending firmware updates I validated meanwhile that this new method seems to work reliable with SB1. So when any update is Flagged in the App it should also be Flagged in the Api Cache and HA Integration. Test


Optional boolean prop gives type Ref<boolean | undefined> which should be Ref<boolean> in vue

SFC Playground: https://sfc.vuejs.org/#eNp9kN1qwzAMhV9F+KYbNDa7DW7H2AvsAXyTpkqTEv8gOy0j+N0npz9sHfTO50j6ZJ1ZfIQgTxOKWujY0hASRExT2Bo32OApwQyEHWToyFtYcevqXvr0Nlx9qYooJC5rdUExhEVCG8YmISsAvcwofmt1L4i1uBAr2wR5jN7xd+bSbq6FaEQNi1M83lK0EX1KIdZKxa4tq49RejoofkmaXBosSoy22pE/RyQGG7H+xVBsnpAqQrdHQnrGfGj9xy3YbFzmU25BPEYKY+MOGyPKMXx/611MEMiHCBvYYzc4/CpKL3fG3p/fa9h5P2LDMebty+vzZPu37Twvc5AzVMAifQf03c3Tilv+Bp9/APuhswM=
Here, we get show type as Ref<boolean> however in VS Code it is Ref<boolean | undefined> 🤔

props are not typed to Ref

This is correct behavior if you have strictNullChecks on in typescript. Any optional property should be type | undefined.

Type definition for defineProps is in https://github.com/vuejs/core/blob/1fa3d9573051f549e6d381a5e88ec8d5d855e4c9/packages/runtime-core/src/apiSetupHelpers.ts#L61
Please create an issue in vuejs/core


Makefile install need fix

to properly create the lib and include directory and copy the files over, the Makefile needs to be fixed
PREFIX needs to be in brackets and directory need to be made if non existing.
here is the fix:
install: all
@mkdir -p $(PREFIX)
@mkdir -p $(PREFIX)/lib
@mkdir -p $(PREFIX)/include
install src/libpcg_random.a $(PREFIX)/lib/.
install -m 0644 include/pcg_variants.h $(PREFIX)/include/.

I agree about the parens, but I don't think it's unreasonable to assume that the library directory should exist. I'm reluctant to run mkdir for the library directory because it's not clear what the right permissions for it would be.


[NLP] parser result contains non-standard chars

I traced the issue to the ontology which is loaded from Notion and contains non-standard chars, such as '➕\xa0endorses'

used https://medium.com/@glasshost/how-to-remove-xa0-from-a-string-in-python-e852cb3e1e82


The bot does not stay connected

After compiling and running the MinecraftProtocolTest example, the bot is able to connect to the server but right after it disconnects.
I am doing something wrong? or would that be his behavior?
IMG: https://i.imgur.com/8DDxriV.png

The example code is meant to disconnect quickly, yes. If you don't want it to, you should remove the call to disconnect.


Split autoconfiguration of websocket in separate class

Separated GraphQLWebsocketAutoConfiguration which is only loaded if property graphql.servlet.websocket.enabled=true. It matches by default to retain the current behavior (fix #113).

I'm still experiencing this problem in v8.0.0


Does this work for Universal Apps (Windows 10)?

Hi.
I installed the nuget packaged to my UWP application just fine, however it won't build. VisualStudio won't recognize the LightBuzz namespace.
I get this error:
 error CS0246: The type or namespace name 'LightBuzz' could not be found (are you missing a using directive or an assembly reference?)

Even though I have
using LightBuzz.SMTP;

in my source, with the nuget package installed:
{
   "dependencies": {
    "Humanizer": "2.0.0-beta0001",
    "lightbuzz-smtp": "1.2.0",
    "Microsoft.NETCore.UniversalWindowsPlatform": "5.0.0",
    "MvvmLightLibs": "5.2.0",
    "Newtonsoft.Json": "8.0.1-beta3",
    "Template10": "1.0.8",
    "Unity": "4.0.1",
    "valueinjecter": "<IP_ADDRESS>",
    "Win2D.uwp": "1.10.0"
  },
  "frameworks": {
    "uap10.0": {}
  },

}
Any ideas?

Hi Amit. The library is not available for Windows Universal. We'll update it soon and upload on NuGet.

As of Pull Request #6, this should now work in Windows Universal Apps.  Be sure to set the 'internetClient' capability in the appxmanifest.
Also, @Vangos don't forget to update the Nuget package.  (Or create a new one and keep the existing package just for Windows 8.  I don't know what good Nuget package management is when updating to a newer framework without backwards compatibility.)

Hey! Package has been submitted to NuGet. Let me know if that works for you:
https://www.nuget.org/packages/lightbuzz-smtp/1.5.0
Thank you.

I updated the package to version 1.5 using nuget, but I'm getting the same problem as before.
Downloading the source from here and including it as a project in your solution works fine.

You are right. I am going to update the packages by tomorrow.

The NuGet package has been updated:
Install-Package lightbuzz-smtp -Version 1.5.3
Please confirm and let me know if that worked for you.

It's working perfectly now. Thank you


mark_duplicates command - error relating to a lack of bam indexes being generated for intermediary bam

Hi
I am trying to run some amplicon data through your pipeline but setting the mark_duplicates to false seems to throw an error relating to the absence of a bam index file being generated for one of the bam intermediary files ending reorder-firgs-gatkfilter.bam. Not sure if I am setting this correctly but if I remove the setting it seems to run fine.
My yaml file looks like:
upload:
  dir: final
details:
- algorithm:
    merge_bamprep: true
    mark_duplicates: false
    realign: false
    recalibrate: false
    variantcaller: [gatk-haplotype, samtools, platypus]
    validate: ../input/regions.vcf
    ensemble:
      numpass: 2
  analysis: variant2
  description: NGSfiletest
  files: [/home/file1_L001_001_1.fastq.gz, /home/file2_L001_001_2.fastq.gz]
  genome_build: GRCh37
fc_date: '2015-10-09'
fc_name: qxtindel1

Sorry about the issues. I'm trying to reproduce this and can't based on your input configuration. A couple of thoughts/questions:

What version of bcbio are you running? There were some recent fixes in the latest release around correctly creating BAM indices.
Is the minimal YAML posted representative of the full run? The gatkfilter.bam files normally come from pre-aligned inputs being cleaned up with aligner: false and bam_clean: picard. It might be possible I'm missing something trying to replicate.

Hope this helps some and happy to try and debug more with additional information.

I am running v0.9.3 so I upgraded to v0.9.4 sudo bcbio_nextgen.py upgrade -u stable. This got me over the indexing issue but generated an input/output error. So i then upgraded the third party tools bcbio_nextgen.py upgrade -u stable --tools and this seems to have got over the I/O error. It is running at the moment so will get back to you if I experience any further problems. Thanks for the help.

closing this since it seems it worked at the end, great!
thanks so much


docs: add install instructions with grafana-cli

It's more convenient and straight forward to use grafana-cli than git clone (especially on prod servers ;-) )

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Feature] Contact Page

Description
The current contact page, as I can guess from the Code didn't send the responses of the user to the website owner.
(If it sends and Please close the Issue). I have one Method of sending the user responses directly to the owner's mail.
That is by the use of SMTPJs. Every response will be sent to Mail registered and entered in the Code.
For the functionality to work, I need a Elastic Email account setup on the mail id on which we want to receive the mails of the responses. By implementation of this in the Website, We can collect the feedback data of the user experiencing our website for first time and can improve the Website according to it.
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[X] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Mails are being received by me as Netlify manages the form responses @Yuvraj960


Fix incorrect line number in warning messages.

Fix incorrect line number in warning messages.
9e70f55403e9ce3e8836cdafe8db66a43af265e1 is not the right change.
It doesn't work if files have headers. My fault.

@yyamano  thanks! I created this fix instead. Does this change work?: #305

It works well, and better than mine:-) Thank you!

:+1:


gns3-server: pin pytest to pytest_7 to avoid test failures

Fixes #299447
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build gns3-server

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3715

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/gns3-build-failed/42256/4

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3748


abstract admin application into view files

fixes #86

Coverage remained the same at 100.0% when pulling 9b1b5d32c40d8c3f5b2cbf85e758e88fd0c4dd09 on fixes-#86 into 86a29802b23e4cf50bfaf9f7112fa4ca692f2a5d on master.


Reordered pages not logged properly

Issue Summary
Reordering a page shows up in Wagtail's Site History report as having been performed by the 'system' user, instead of the user that has actually performed the action.
The description of the reordering action could also be improved upon. 'Moved from [parent page] to [parent page].', is not very clear to the end user. '[reordered page] was reordered.' or something like that would seem clearer to me (suggestions welcome).
Screenshot of the issue:

Steps to Reproduce

Install Wagtail Bakerydemo and update it to Wagtail 2.12 (The bakerydemo is still on 2.11 as of writing).
Go to 'Breads' page in the Wagtail admin.
Click the 'Sort' link (screenshot included).
Try dragging a page to new position. Move the Bagel page the top for example :).
Now go to the Site History report (Reports -> Site History in the menu bar).

The report should show your action as having been performed by the 'system' user. It should also show the confusing description as stated in the issue summary.
Expectation: the report should show the actual user who has performed the action, not 'system'.

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: yes

Technical details

Python version: 3.9.1.
Django version: 3.1.6.
Wagtail version: 2.12 final
Browser version: Chrome 88 on Fedora Linux.

The offending code is in wagtail/admin/views/pages/ordering.py.
set_page_position() should pass the current user to the page_to_move.move().

Nice find @Stormheg
Thank you in advance for the PR. I think pos left and right can count as re-order rather than move and I wonder if the log message should reflect that.

Merged in https://github.com/wagtail/wagtail/commit/520fa23ced80f3c4eb3b71842923848a2812a1fd and https://github.com/wagtail/wagtail/commit/1ff679f861b21d93dd8061561666b0984249dfcc :tada:


🌟 [EPIC] QR-Code

🌟 EPIC

This is basically the definition of a user/community identity(URL) and its translation into a QR-Code

We will do this in a different way.
the qr code will be used for the first time with the sending of transactions. i am closing this issues because this kind of technology will be used at a later stage with different requirements. for this it needs new instructions and tasks.


Windows: Move to latest OCI spec

Signed-off-by: John Howard<EMAIL_ADDRESS>@mlaventure @tonistiigi @thaJeztah
This PR refreshes the contents of the hacked OCI spec used on Windows to exactly what would be in the opencontainers runtime spec once https://github.com/opencontainers/runtime-spec/pull/567 and https://github.com/opencontainers/runtime-spec/pull/573 are merged. The other changes are purely compile fixups. No functional changes in this PR.
This is the final stage of the Windows OCI manipulation (I hope!) before the file can be removed entirely and Windows uses the actual spec.

Shouldn't we wait until those 2 PRs get merged in the specs and vendor opencontainer/runtime-spec it instead?

@mlaventure That's the next stage after this PR. There will be Linux fix ups. I'd rather get Windows in sync first.

Not sure I understand, sorry :sweat_smile:
Most of the code being added to the windows files by this PR will go away once we'll vendor in the updated runtime-spec, or am I understanding it incorrectly?
In which case, we  may as well wait until runtime-spec gets updated, especially since those PRs technically could still change before they get merged.

It's the compile fixups mostly. There's been other PRs which have done similar refreshes. Only on phone so cant easily link to them

Closing. Replaced by https://github.com/docker/docker/pull/26961


Adding support for auto generating cloudformation resources

Redone based on current changes let me know!

@kornypoet can I have a second set of eyes please?

@elmobp The code looks pretty good altogether. I've made some comments on a few pieces I have questions on. @gergnz do we want this in the main branch or in 1.0.0?

@kornypoet I'm happy for this to go into a pre-1.0 release. The reason I say this is while it adds functionality it doesn't potentially break the core cfndsl and/or deprecate/remove features.

Can we fix the last couple of issues so checks pass?

Done but what do we want to do about the external gem dep?

Thanks @elmobp
Personally, I've really clung to the "cleanliness" of a zero-outside-dependency gem. However, if we follow the precedent set in external parameters and again in stevenjack/cfndsl#328 then we are bloating the code with outside dependencies anyways, by copy-pasting. If it was possible to lift only the essential functions and keep the code import minimal (one module, 20 lines-ish) I'd say let's stick with that. But if we are importing 100's of lines across more than one file, we are really doing a disservice to the open source community by not using what others have created.

Let me see if there is a nice way to compact it in eg remove things from it we dont need

This last commit should do the trick

@kornypoet let me know when you happy with it all and I will squash it

Awesome. I've requested one final change and then I think this is good to merge.

Awesome. I've requested one final change and then I think this is good to merge.

@kornypoet metadata be gone not sure how that slipped in :(

Ill squash it down now gimme 10

Squashed to 5 any more than that the rebase gets very upset!


Dupe bug (Tanks)

I right clicked on an ender tank with a stack of low pressure tanks to get some liquid oxygen out of it and now I have an entire stack of low pressure tanks with 1k liquid oxygen in each at the cost of only 1k liquid oxygen from the ender tank.

Right clicking on an ender tank invokes the handler from EnderStorage, so chances are it's not checking for stack size, what I can do is disallow stacks of pressure tanks

what build are you using?   Using the 1.7.10 build of AR 1.0.13, EnderStorage-1.7.10-<IP_ADDRESS>-universal,  and CodeChickenCore-1.7.10-<IP_ADDRESS> I am unable to fill the low pressure tank from an enderstorage tank full of liquid oxygen at all

I'm using EnderTanks version 1.10.0-1.4.11

alright, will take a peek

Does this help? https://www.twitch.tv/videos/132884657

I've been able to replicate it now

From shetiphian.endertanks.common.block.class:
shetiphian.endertanks.common.block(line 213)
if (FluidContainerRegistry.isEmptyContainer(heldItem))
      {
        FluidStack tankLiquid = tankTile.getTankInfo().fluid;
        if (tankLiquid != null)
        {
          ItemStack filledItem = FluidContainerRegistry.fillFluidContainer(tankLiquid, heldItem);
          if ((filledItem != null) &&
            (!player.capabilities.isCreativeMode))
          {
            if (heldItem.stackSize > 1)
            {
              if (!player.inventory.addItemStackToInventory(filledItem)) {
                return false;
              }
              player.inventory.setInventorySlotContents(player.inventory.currentItem, consumeItem(heldItem));
            }
            else
            {
              player.inventory.setInventorySlotContents(player.inventory.currentItem, consumeItem(heldItem));
              player.inventory.setInventorySlotContents(player.inventory.currentItem, filledItem);
            }
            tankTile.drain(tankFacing, 1000, true);
            return true;
          }
        }
      }
shetiphian.endertanks.common.block(line 348)
  private ItemStack consumeItem(ItemStack stack)
  {
    if (stack.stackSize == 1)
    {
      if (stack.getItem().hasContainerItem(stack)) {
        return stack.getItem().getContainerItem(stack);
      }
      return null;
    }
    stack.splitStack(1);
    return stack;
  }

It looks like the endertank mod takes the stack you're holding, then sets it to be full of the fluid and stores it in "filledItem", then it takes the stack your currently holding, decrements it by 1, but then overwrites it with "filledItem" which is the original stack size, resulting in filling the entire stack instead of creating a new stack with only one item filled and leaving the rest empty.
But yeah, looks like short of limiting stack size of the pressurized tanks to one, there's not much I can do as the filling code is not in AR.


To give @Daniel-Mietchen full access to this repository

@teodorgeorgiev could you give @Daniel-Mietchen full access to this repository

done


 This file is important to help ensure that contributions are consistent and meet the project's standards. By adding a CONTRIBUTING.md file, we can:
Clarify the Contribution Process: Provide clear steps for submitting issues and pull requests.
Code Style Guidelines: Set standards for coding style, formatting, and documentation.
Branching and Commit Message Conventions: Outline the rules for branch naming, commit messages, and PR creation.
Code of Conduct: Optionally include or link to the project's code of conduct.
Testing and Reviewing: Explain any required tests, CI pipelines, or review processes.
Tasks:
Draft the CONTRIBUTING.md file.
Include information on how to clone, test, and submit a PR.
Define coding standards and practices (e.g., language-specific guidelines).
Add sections for reporting issues and feature requests.
Optionally include guidelines on how to document changes and testing requirements.
Create a PR with the CONTRIBUTING.md file in the root of the repository.
Expected Outcome: Having this file will make it easier for new contributors to understand the process of contributing to the project and improve the quality and consistency of contributions.

You can assign me this task under gsssoc and hacktoberfest level 3 label.

This task is already completed @SaanyaGarg5


titles / labels for image sequence?

Is there a simple way to have titles or labels for images in a tilesource sequence?
For example, if viewing book pages, one might want to display the page number somewhere that was always visible regardless of zoom level.
Thanks for any help,
Wes

We don't have a mechanism for that. It's probably better done in your own code; you can put it outside the viewer or even have it hover on top. Keep an array of titles that matches the array of images, and watch the "page" event:
viewer.addHandler('page', function(event) {
    $('.my-title-div').text(myTitleArray[event.page]);
});

Hi, this seems to work for the actual picture, is there also a way for all shown images in the reference strip?
regards
Meex


HAPI Integration Refactor

This is a significant refactor of the HAPI integration to make the plugins more flexible and idiomatic.  This should resolve the outstanding issues related to the HAPI integration.  Specifically ( #97 and #123 )
WARNING: This refactor does result in breaking changes to the API.
TODO:

[x] Update CHANGELOG.md with your change (include reference to issue & this PR)
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass

@helfer The reason for a drop in code coverage is because I resolved one of the todo items which is to handle JSON parse errors in variables.  As a result there isn't a test for that case.  I have a set of changes that includes a test and fixes in all other integrations that increases the code coverage.  Do you want me to include the changes in the PR or create a new one?

Does options still accept a Promise?

@dahjelle no it doesn't.  I just realized that my example in the readme is wrong.  If you look at the integration test you can get an idea of how it is used but now options include { path, route, apolloOptions }  where apolloOptions can still be a promise.  I will fix the example now.

I can confirm that it appears to address the issue in #123. Hooray! :-D

I like the use of the route prerequisites, it looks really clean.
Still I have a question, why using HAPI (uppercase) everywhere? It is not an acronym. On the project's website they always use lowercase.

@SimonDegraeve as I was using the all uppercase version I wondered which one was right.  I agree I will lowercase hapi in my next commit.

This is awesome! As far as I'm concerned, we can merge this as soon as we have a corresponding PR on the docs, which shouldn't take more than 10 minutes of work.
:tada:

@SimonDegraeve @helfer I have decided to handle the renaming of Hapi #129 and code coverage in separate pull requests.  There are a couple of other changes that are tagged for the 0.3 release that I will be working on today as well.  I will update the docs once all the 0.3 are complete.


Update next peerDependency to include 14.0.0

Since<EMAIL_ADDRESS>is out, and seems to be working fine with this package, I've updated the package's peerDependencies to reflect that.
I've also updated the examples to use the newer version

I'm so sorry I actually missed this!
By now, I've done the same, and it has been released in the 0.5.x version range.
Thank you again for the PR, I would have loved to merge this in instead, but I really didn't see it before.


HYC-190 Remove LFS

URL to Jira task (this should explain the task)
https://hackachain.atlassian.net/jira/software/projects/HYC/boards/11?selectedIssue=HYC-190
Explain what the code alterations do
Applies filter-branch through complete repo's history to remove all large files once stored with LFS.
This rewrites the entire commit history
What has to be tested? How to test it?
Perform all tests and verify that nothing was broken by the rewrite.
It will be necessary to force push this to main

/deploy


Android Studio 3.0

It doesn't seem like this plugin works in AS 3.0
When I run a gradle task like :app:compileDevDebugAspectJ I get
Skipping task ':app:compileDevDebugAspectJ' as it has no source files and no previous output files.
:app:compileDevDebugAspectJ NO-SOURCE
and my aspects don't affect the code.
Is there a known bug with AS 3.0 and if so, any timeline for when it will be supported? Would you recommend any other plugin/solution in the meanwhile?

Compiler doesn't demand on AS version.
Skipping task ':app:compileDevDebugAspectJ' means you have no .aj files to compile. You may look for transformDevDebugClassesWithAspectJ task for more details. It should generate ajc-transform.log file in /app/build directory.

Thanks, the log output seems fine!
However, whenever I use your plugin and then does a clean, I get a lot of the following output:
Could not resolve all files for configuration ':flic:prodDebugCompileClasspath'.

Failed to transform file '....jar' to match attributes {artifactType=android-classes} using transform JarTransform
Transform output file ....jar does not exist.

any idea?

Dunno :( Could you provide full gradle log running build with --stacktrace --info keys?

Can I email you? I rather not publish all logs publicly here

Sure. @gmail.com or @yandex.ru with my gh nickname.

I dropped you an email :)

Same problem here. Nothing happens with AS 3.0.1. I can't event see any tasks with AspectJ names.
@Archinamon  Request you to please look into it. Thank you so much for the great plugin btw! 👍

Error:Could not resolve all files for configuration ':app:debugAndroidTestRuntimeClasspath'.

Failed to transform file 'core.jar' to match attributes {artifactType=android-classes} using transform JarTransform
Transform output file C:\Users\APOORV\AndroidStudioProjects\FoodDelieveryApp\app\libs\core.jar does not exist.
can youn please tell me what can i do to solved this issue....

Is there any workaround like blocking Java 8 if it has compatibility issues with this plugin?


Redux Epic

Since we now have a Redux Saga icon, maybe we could complete the Redux icon with an Epic icon …
Either based on Redux ones, with another color (pink ?), or based on the official logo of Redux Observable :  https://redux-observable.js.org/
If a file ends with \.epics?\.[tj]s
Thanks !

done


How does whatsapp does localization and support 40 languages?

How does whatsapp does localization and support 40 languages?

Hello,
Would you like to integrate StringPacks in to your app? I can help you with that.


Non-Existant Documentation

Hi,
Does actual docuementation of the package exist?
The current link to the docs is not documentation for this package, but for something else.
I might be missing something, but I can figure out how to use this package by just the keycloak rest api docs.
Thanks,
Pat

There is no documentation of this package beyond the README.md. Since this was something I worked on during my sparse free time, I chose to devote my time to implementing features instead of writing documentation. I welcome a pull request to add documentation, though.


Establish or provide instructions (in help) for users to recover, change or reset iRODS password

I just created these instructions here: https://pages.hydroshare.org/creating-and-managing-resources/how-can-i-reset-or-change-my-irods-password/

Closing this issue; needs #2003 as next step.


Missing some node types ... //but thx for the great work :)

Hi ...
I have installed everything as written ... but got this message:
When loading the graph, the following node types were not found:
ConvertAny2Int
ConvertAny2String
CeilNode

Nodes that have failed to load will show as red on the graph.
Thx in advance for a solution.

you need to delete them and add again
it worked for me

Sorry, but how to add them please?
When I'm searching them, i've got nothing.

I also have the same situation, I can't search for the node, thank you guys

me2

Hi ...
I have installed everything as written ... but got this message:
When loading the graph, the following node types were not found:
ConvertAny2Int
ConvertAny2String
CeilNode

Nodes that have failed to load will show as red on the graph.
Thx in advance for a solution.

https://github.com/MrForExample/ComfyUI-AnimateAnyone-Evolved/issues/35#issuecomment-1994665534

https://github.com/MrForExample/ComfyUI-AnimateAnyone-Evolved/issues/35#issuecomment-1994665534

how i fix this problem?

Just install ComfyUI-LogicUtils


Require "as const"?

Suggestion
I have a factory function that takes a specification in the form of an object literal and returns a class. If the description passed in is a literal and annotated with as const, then the static properties it takes from the specification retain their exact types (like strings for instance), vs. the more generic "string" type:
type Specification = { readonly type: string; };

function SourceNode<T extends Specification>(props: T) {
    return { ...props }; // simplified to show a reduction.
};

export const Statment = SourceNode({
    type: "Statement"
} as const);

// This statically knows it will never enter this if
if (Statement.type === "pizza") {
}

However, if you forget as const, all of this of course falls apart. I'd like a way to immediately surface an error if you don't pass an as const object literal:
// Would be nice if this yelled at you, or maybe could somehow infer that it's const since it's never used again?
export const Statement = SourceNode({
    type: "Statement"
});

I've tried every manner of annotation but haven't been able to accomplish this, but would love to know if there is a way to do this currently:
function SourceNode<T extends Readonly<Specification>>(props: T)  { readonly [key in keyof T]: T[key] } {
    return { ...props } as const;
};

🔍 Search Terms
as const, required, const annotation
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

A workaround from https://github.com/microsoft/TypeScript/issues/30680#issuecomment-752725353

Is the underlying use case here the same as #30680?  I would think you'd rather see SourceCode({type: "Statement"}) have "Statement" be inferred as a string literal type.  Or would you really prefer an error like:
type Specification = { readonly type: string; };

function SourceNode<T extends (string extends T["type"] ?
  { readonly type: "OH NOES YOU FORGOT as const" } : Specification)>(props: T) {
  return { ...props }; // simplified to show a reduction.
};

export const BadStatement = SourceNode({
  type: "Statement" // error, Type '"Statement"' is not assignable to type '"OH NOES YOU FORGOT as const"'.
});

export const Statement = SourceNode({
  type: "Statement" // okay
} as const);

I suppose if someone writes SourceNode(somethingCreatedEarlier) then any chance of inferring something narrower is gone, at which point you'd maybe still want an error.  If so you can probably do something like this yourself, at least as a workaround until and unless this feature is implemented:
// I don't know, something like this
type Const<T> = T extends object ? { readonly [K in keyof T]: Const<T[K]> } :
  T extends number ? number extends T ? 0 : T :
  T extends string ? string extends T ? "" : T : T;

function foo<T>(x: Const<T>) { }

const oops = [123]
foo(oops) // error, number[] not assignable to readonly 0[]

const okay = [123] as const;
foo(okay) // okay

Playground link

I'm not 100% clear on what the thing being asked for is - if you wrote
let s = "ok".
SourceNode({ type: s } as const);

then the implicit contract is violated while the syntactic one is met. Conversely you could write
const s: { type: "statement } = { type : "statement" };
SourceNode(s);

and the implicit contract is met while the syntactic one is violated.
Programming languages generally don't create constructs that forbid indirection - I don't think we'd ever add something that says that the syntactic form you pass to a function has to be a particular thing. Framework-specific linters do exist (e.g. React's hooks lint) and might be more appropriate.

Programming languages generally don't create constructs that forbid indirection

In some sense, I am kind of trying to write a syntax construct, and thus the lack of indirection would be fine, "the same way" you can't do import pathVariable, and are instead forced to use a string literal with import statements. I am attempting to make a class factory, so I wish I could just do SourceNode Statement { }...

I'm not 100% clear on what the thing being asked for is - if you wrote

The responses above have actually been super helpful and given me plenty to experiment with. To get to the heart of the matter as to why I wouldn't just use a generic for this for example, is because it seems like any information I want to access both at runtime and type-check time needs to be expressed twice. I wish I could just treat exact strings kind of like in C++ templates:
type SourceNode<Name extends exact string> = class
{
    static type: Name = Name;
    type: Name = Name;
};

However, I can't (to my knowledge) assign a value to the value of an exact string (nor can I assign types to static members of course). But if the above was possible, I could avoid having to do something like:
class Statement extends SourceNode<"Statement">
{
    static type = "Statement"; // Ugh.
    type = "Statement";
}

My workaround is to have a class factory that piggy-backs off of this sort of literal type inference to have my cake and eat it too:
interface SourceNodeSpecification
{
  type: string;
};

const SourceNode = (specification: SourceNodeSpecification) =>
  class
  {
      static type = specification.type;
      type = specification.type;
  };

That way I can now do:
const Statement = SourceNode
({
    type: "Statement";
} as const);

function doStuff(node: Statement | Declaration)
{
    if (statement.type === "Statement")
    {
       // whatever.
    }
    else
    {
         // Must be a Declaration here...
    }
}

And then have all my nodes I instantiate have the correct type without having to pass in a string anywhere else in the program.


Windows: How to set up the development environment

This section is empty. :scream_cat:

I recommend GNU ARM Embedded Toolchain using by zinc.rs. It provides arm-none-eabi-gcc arm-none-eabi-nm and more . Also, linux-like CLI is an important part, which allow you to use nm file ld, ect. For most version of Window, we can use Babun to setup easily. It contains out-of-the-box Cygwin oh-my-zsh bash and git, but if this book uses any tool that have not been transplanted to windows, it can not help. For the user using win10, here is a better choice. Microsoft released a beta win10 in June, 2016, with Bash on Ubuntu on Windows. It runs a virtual machine for linux and sets up the environment. Its advantage is that we can run apt-get on real linux., but the disadvantage is that user must swith their win10 into beta version. Installing a virtual box is a bad idea, while Bash on Ubuntu on Windows embedded the linux command into window's native CLI, the virtual box can't even touch win's filesystem.

This book may help [RustyGecko - Developing Rust on Bare-Metal]

@goandylok
Awesome tips. I think the instructions will include installing some sort of shell like MinGW (is that what's called?) or Babun like you mention. IMO, the main instructions shouldn't require Bash-On-Ubuntu/Windows 10 but they should mention that as an option. I also agree that the instructions shouldn't say install a VM with Linux.

This book may help [RustyGecko - Developing Rust on Bare-Metal]

That's a great resource; lots of good stuff in it. Are you one of the authors or do you know if the authors will be okay with me adding a link to that document to the Copper book Resources section?

Thx (●´ω｀●)
Neither do I. I just found it on Google.

Neither do I. I just found it on Google.

Ha, OK. I just added RustyGecko to the resources. I'm sure they won't mind :wink:.


[Feature Request] YML config options

Describe the feature

Hello!
This is a great server and it works wonderfully during WFH when I need to perform some troubleshooting for family members, and I was wondering whether it would be possible to include configuration options in the YML for additional things such as:

Enable or Disable Encryption option
Enable or Disable File Sharing
Enable or Disable Automatic Camera Start
Enable or Disable a 'default' room
Enable or Disable creation of rooms
Enable or Disable showing of debug info (client version, network type, 'connected' info in the top right hand side etc)

All of these could reside within the YML as booleans that could be set to true or false at startup.
Thank you in advance for your considerations!

Hi @Sidefix, I suppose something like this could be implemented, but I currently don't have the time for this.
I'd be happy to provide guidance if you wish to try to implement it yourself and submit a pull request.

Sure @jeremija I would give it a shot. Just let me know where the modifications need to be done and what tools I might need. I think I can manage from there.

A few things would need to be updated. First we'd need to be able to read these values from yaml or environment variables.
I recommend adding the disabled prefix to the boolean values so that the default behavior stays the same.
For example:
ui:
  disable_insertable_streams: true # env var UI_DISABLE_INSERTABLE_STREAMS=true
  disable_file_sharing: true       # env var UI_DISABLE_FILE_SHARING
  rooms:                           # env var UI_ROOMS=room1,room2
    - room1
    - room2
  disable_console:                 # env var UI_DISABLE_CONSOLE=true
  default_room:   'default-room'   # env var UI_DEFAULT_ROOM=default-room

Could you clarify by the meaning of the default room setting? Do I understand correctly that predefined rooms would only allow certain rooms to be joined, and no other ones?
Then you'd need to modify the types and functions in configtypes.go and configread.go so these config values can be properly parsed. Then update the mux.go to actually render these values.
Nex you'd need to update the window.ts file to parse these new config values. I have actually been thinking about updating the logic in window.ts to read a single JSON value containing all config entries from a single instead of so many hidden input boxes.
Finally you'd need to update the UI to show/hide the desired functionality.
Note that the Enable or Disable Automatic Camera Start will probably be resolved by #122.

Also I just realized that if the ui.rooms property would only allow a few predefined rooms to be joined, and the IDs should be hidden from the public then perhaps exposing it to the client side is not a good idea and the implementation of the /call/:call_id handler would need to be changed.


Skip updateBridge if there is no federation in BtcToRskClient

pipeline:run

pipeline:run

pipeline:run

pipeline:run


Updated chapter 1 with notes on MRTK pop up

clarifying Screenshots forthcoming. This is in response to feedback from issue #1079

Docs Build status updates of commit 30a46ff:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Rancher Pipeline starts on all branches

I have configured Rancher Pipeline on my project. It should trigger build and deploy when there is a new commit to master branch. But it starts pipeline process if I commit any branch in the repo. It should only make build and deploy on master branch.

Rancher Version: 2.3.1
With Github repo

This is expected. It is not a common practice to trigger builds only on the master branch. You can configure it according to your need, see: https://rancher.com/docs/rancher/v2.x/en/k8s-in-rancher/pipelines/#trigger-rules

@gitlawr thanks man, i got your point.


SIGINT seems to be suppressed

When work is run by sh, I can't interrupt/kill the script without using ctrl-Z and then forcibly sending a kill to the script.

Re-open with a simple script to reproduce the issue please.


Recommended approach to multiple node parsing

My parsing starts at menus, then categories, and then items. Each one having its own View Controller. The problem is the delay that comes with parsing a flatten out data. Is it recommended to structure my data as such? If yes, then what is the recommended approach to pre-parse for subsequent View Controllers?

This is covered pretty clearly in our documentation. If you're experiencing performance bottlenecks when downloading and parsing your JSON, you're likely downloading far too much at once.
Please don't use our issue tracker as your personal app dev help center.


Refer to column in update queries

Is your feature request related to a problem? Please describe.
I want to update a column base on its value:
update t set points = points + 1 where id = '321";

Describe the solution you'd like
Maybe something like Sequelize literals?
https://github.com/sequelize/sequelize/issues/7268#issuecomment-280904532
Describe alternatives you've considered

Use knex directly.
write a raw query
find + update

Additional context
N/A

And you would like to do this via query builder, right?
I can imagine something like this:
const qb = orm.em.createQueryBuilder(Book2);
qb.update({ price: qb.raw('price + 1') }).where({ uuid: '123' });

// update `book2` set `price` = price + 1 where `uuid_pk` = ?

Thanks!

But we can't do this in MikroORM because now the entity manager doesn't know about this change, isn't it?
I imagine something like this:

orm.em.getRepository(Entity).update({ id: 'dsa' }, { price: 'price + 1' });

Don't expect this to work with entity manager (or identity map) - if you want that, you need to load the entity first.
We are talking about update query without the need to load the entity.

We are talking about update query without the need to load the entity.

So from identity map POV it's ok to not "update" it right? it won't cause a "hole" in the identity map?

I am not going to add em.update(), MikroORM is based on change set tracking, this would just cause a lot of confusion. You can design such method yourself in a custom repository, if you need it.
And I still don't understand why you are concerned with identity map. You wanted a way to update entity without loading it, that means it is not in the identity map. Even if it would be present there, it does not really matter if you do updates directly to the database - it won't have any side effects. Of course if the entity would be already loaded, it would still have the old value, but there is no way to solve this easily, not without reloading the entity - maybe in postgres via returning statement, but nothing that would work across all drivers, therefore nothing I want to have implemented in the ORM.
If you want the MikroORM way, load the entity first, use version field to make sure there are no concurrent updates and make the increment in your code rather than in SQL. If you want increment on db level, without loading the entity first, we can have the API with qb.raw() for sure, that's easy to add (will do it anyway).

Thanks!!

load the entity first, use version field to make sure there are no concurrent updates

What about select for update? is it possible in MikroORM?

Yes, LockMode.PESSIMISTIC_WRITE will result in select for update query.
https://mikro-orm.io/docs/transactions/#pessimistic-locking

Another thing that came into my mind.. what about update it in raw query for example AND delete it from the identity map manually? is it possible? do you recommend consumers to "mass with" the identity map?

You can remove entity from identity map via UoW.unsetIdentity(), but to do that, you first need to have the entity. So you would first need to try UoW.getById() to see if its there.
By removing something from identity map you could potentially loose some updates that were already made on that entity (if you remove it from there, you can't expect any updates for it, flush will simply ignore it).

Ok, thanks!


Compat with Better Combat.

latest.log
Currently I can't load my world due to this. Would really enjoy playing with this addon.

Can't reproduce this


objective=binary:logistic with num_class=2 throws error

On the latest master (XGBoost-0.9 SNAPSHOT), I get a error when using objective=binary:logistic with num_class=2. In this case I am using the Spark API, but I think it might be caused by something independent of the xgboost4j.
The error dose not occur if no num_class is specified.
Example:
import ml.dmlc.xgboost4j.scala.spark.XGBoostClassifier

val dataPath = "SPARK_HOME/data/mllib/sample_binary_classification_data.txt"

val data = spark.read.format("libsvm").option("vectorType", "dense").load(dataPath)
val dataSplit = data.randomSplit(Array(0.8, 0.2), seed = 1000)
val dataTrain = dataSplit(0)
val dataTest = dataSplit(1)

val paramMap = Map(
    "eta" -> 0.1f,
    "max_depth" -> 2,
    "objective" -> "binary:logistic",
    "num_class" -> 2,
    "num_round" -> 5,
    "num_workers" -> 2
)
val xgbClassifier = new XGBoostClassifier(paramMap)
    .setFeaturesCol("features")
    .setLabelCol("label")

val xgboostModel = xgbClassifier.fit(dataTrain)

Executor stack trace:
ml.dmlc.xgboost4j.java.XGBoostError: [17:12:54] /xgboost/src/objective/regression_obj.cu:55: Check failed: preds.Size() == info.labels_.Size() (78 vs. 39) : labels are not correctly providedpreds.size=78, label.size=39
Stack trace:
  [bt] (0) /data/disk9/yarn/container-logs/usercache/XXXXXXX/appcache/application_1557180119926_286753/container_e149_1557180119926_286753_01_000002/tmp/libxgboost4j3559256344967066582.so(dmlc::LogMessageFatal::~LogMessageFatal()+0x35) [0x7f1dbb7a07f5]
  [bt] (1) /data/disk9/yarn/container-logs/usercache/XXXXXXX/appcache/application_1557180119926_286753/container_e149_1557180119926_286753_01_000002/tmp/libxgboost4j3559256344967066582.so(xgboost::obj::RegLossObj<xgboost::obj::LogisticClassification>::GetGradient(xgboost::HostDeviceVector<float> const&, xgboost::MetaInfo const&, int, xgboost::HostDeviceVector<xgboost::detail::GradientPairInternal<float> >*)+0x202) [0x7f1dbb8c39a2]
  [bt] (2) /data/disk9/yarn/container-logs/usercache/XXXXXXX/appcache/application_1557180119926_286753/container_e149_1557180119926_286753_01_000002/tmp/libxgboost4j3559256344967066582.so(xgboost::LearnerImpl::UpdateOneIter(int, xgboost::DMatrix*)+0x293) [0x7f1dbb8492a3]
  [bt] (3) /data/disk9/yarn/container-logs/usercache/XXXXXXX/appcache/application_1557180119926_286753/container_e149_1557180119926_286753_01_000002/tmp/libxgboost4j3559256344967066582.so(XGBoosterUpdateOneIter+0x35) [0x7f1dbb7a52e5]
  [bt] (4) [0x7f1df9017a34]

I also have this problem

I don't see this on Python side.

This is a tricky one, I don't think num_class should generally be set for binary classification. The reason is that the internal implementation for binary classification is specialised compared to the multiclass implementation. After setting the num_class parameter the internal implementation thinks you want to output predictions for each of your class labels, which is redundant in the binary case. For user experience I think we should log that this parameter should not be set with the binary classification objective.

@RAMitchell Num class is quite difficult to handle, it ties to num_output_group, also objective.  Do you think it's a good idea to remove all these auto configuration then just emit an error to tell users to set correct parameters?
This way all these "heuristics" can be  removed.

The error dose not occur if no num_class is specified.

I meet same error。
it works good! if I dont set num_class param.
Thanks

@thesuperzapper

Meet the same problem. Either change to multi class ,or remove num_classes can work around. Agree with @RAMitchell ,the document should mention about this.


Why doesn't Flask-RESTful use custom error handlers

As you know, Flask provides the ability to create custom errors and handlers for them.
But as I can see, I can't use this feature in Flask-RESTful. Could anyone please explain why?
If you have working web app with it's own exceptions it would be easier to create RESTful API then.
This thing with custom error messages doesn't seem to be that flexible. For example, if I validate data and then raise exception with message that describes what is wrong, I can't pass it to the errors dict. Correct me if I'm wrong, please.

oh gush

oh, gush.
can we just have something like
abort(409, 'my custom error message')
without extra sublcassing?

Workaround:
handle_exceptions = app.handle_exception
handle_user_exception = app.handle_user_exception
api = Api(app)
app.handle_user_exception = handle_exceptions
app.handle_user_exception = handle_user_exception

@billmccord you might to fix your snippet but it did the job for me 👍
`   handle_exception = app.handle_exception
handle_user_exception = app.handle_user_exception
api = Api(app)
app.handle_exception = handle_exception
app.handle_user_exception = handle_user_exception
app.register_error_handler(404, custom_404_handler_here_we_go)
`

I've used the Blueprint to work with the flask-restful, and I've found that the solution @billmccord and @cedmt provided not worked for this case, because the Blueprint don't have the handle_exception and handle_user_exception functions.
My workaround is that enhance the function handle_error of the Api, if the "error handler" of the "Exception" have been registered, just raise it, the "error handler" registered on app will deal with that Exception, or the Exception will be passed to the "flask-restful" controlled "custom error handler".
class ImprovedApi(Api):
    def handle_error(self, e):
        for val in current_app.error_handler_spec.values():
            for handler in val.values():
                registered_error_handlers = list(filter(lambda x: isinstance(e, x), handler.keys()))
                if len(registered_error_handlers) > 0:
                    raise e
        return super().handle_error(e)

api_entry = ImprovedApi(api_entry_bp)

BTW, seems this repository had been deprecated...

For those coming from the internet, a quick way to "fix" this behavior is to set:
app.config['PROPAGATE_EXCEPTIONS'] = True

So the exceptions will be reraised and handled by flask.
ref: https://github.com/flask-restful/flask-restful/issues/578#issuecomment-373308124

Hello all, after using this library for several projects I've found it easier to just use flask's built in MethodView https://flask.palletsprojects.com/en/1.1.x/api/#flask.views.MethodView rather than monkey patching error handling.
import flask
from flask.views import MethodView

blueprint = flask.Blueprint('api', __name__, url_prefix='/api')

class MyClass(MethodView):

    def get(self):
        return flask.make_response(flask.jsonify({}), 200)

    def post(self):
        return flask.make_response(flask.jsonify({}), 200)

blueprint.add_url_rule('/my-url', view_func=MyClass.as_view('my_url'))

More info here: https://pythonise.com/feed/flask/flask-api-methodview

@iteratelance this is what I moved to doing as well

I did something similar to @Stark-X, error_router seems to work with error_handler
class ErrorPropagatingApi(Api):
    """Flask-Restful has its own error handling facilities, this propagates errors to flask"""

    def error_router(self, original_handler, e):
        return original_handler(e)

For those coming from the internet, a quick way to "fix" this behavior is to set:
app.config['PROPAGATE_EXCEPTIONS'] = True

So the exceptions will be reraised and handled by flask.
ref: #578 (comment)

In addition to this, I ended up making sure that none of my application exceptions were using HTTPException class as a base. Now the errors could easily be handled by the error handlers registered with the Flask app or Blueprints.


Proxmox widget showing no information

I created user/group/api token according to the docs and put into my services.yaml
    - Proxmox - Home:
        href: https://xxx:8006
        icon: proxmox.png
        widget:
          type: proxmox
          url: https://<IP_ADDRESS>:8006
          username: homepage@pam!hp
          password: xxx

I don't see any error or information in the ui/logs.

{"data":[{"id":"node/pve","level":"","node":"pve","cgroup-mode":2,"type":"node","status":"online"}]}

One thing I wonder:
When clicking the Permissions button in Proxmox for the API key it shows nothing. Could that be the issue? I thought it would have the same permissions as the user

Running latest version of homepage.
Happy to provide more info if requried.

Have a look at https://github.com/benphelps/homepage-docs/pull/82
In general, maintaining docs for these is annoying because the 'definitive' answer seems elusive...


DOCS-13078: on windows, it's mule.bat, instead of mule

on windows, it's mule.bat, instead of mule

Thank you for your contribution!! :)


Can't deploy downstream rke2 cluster with multiple nodes

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

deploy a downstream cluster with the following configuration (using DO or equivalent)
specify 3 pools for the cluster:

etcd with 3 nodes
controlplane with 1 node
worker with 2 nodes

use k8s version 1.20.6

Result:

cluster does not come to active state

Other details that may be helpful:
these resources are not active yet in the cluster

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): msater-head 91a6f51
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): RKE2 on Digital Ocean
Machine type (cloud/VM/metal) and specifications (CPU/memory): 2vCPU each
Kubernetes version (use kubectl version): 1.20.6+rke2r1

Closing it and tracking this here - https://github.com/rancher/rancher/issues/32610

Reopening this as on master-head - commit id: 909237a, this doesnt work

DO RKE2 node driver clusters.
Cluster1 - 1 node all roles + 1 worker node --> Only all roles node comes up in the cluster. Worker node is stuck and cluster is stuck in Provisioning state
Cluster 2 - 1 etcd, 1 cp, 1 worker nodes --> Cluster doesnt come up Active. Stuckin Reconciling state
The nodes are however created in the backed.

Issue on master-head - commit id: 909237a is seen for custom clusters as well:

Custom cluster - 1 node all roles and 1 worker node :  worker node is stuck in Waitingfornoderef  and the cluster is stuck in provisioning state in the dashboard but the cluster is shown active on ember UI.
Custom cluster - 1 node etcd + cp, 1 worker node : all nodes are stuck in Waitingfornoderef  and the cluster is stuck in Provisioning

on master-head (d7ef41e) I am able to provision a downstream a downstream cluster with dedicated nodes per role using Digital Ocean, which appears to be working as expected. Also tested deploying multi-node clusters with shared roles (i.e.  node with etcd+CP, 2 worker nodes)
related issues: https://github.com/rancher/rancher/issues/32739 ,  https://github.com/rancher/rancher/issues/32741

Rancher version: v2.6 master-head 55f0bb2
Can't provision on EC2 with multi-node roles
Single node all roles work but multi node isn't


CSFloat Market Checker

I had to reinstall the new one, and when i go to install it it just buffers forever

You're going to have to be much more specific about what you're seeing.
What error? What does "buffers forever" mean? What browser?

https://gyazo.com/fa47354be7742f86a7dd1d3e100496e0
Im using updated chrome, when i go to install the extension it never installs

This looks like a bug in Chrome Web Store -- trying to add any extension at the moment infinitely loads.
You'll need to wait for Google to resolve it.


infinite loading

Hi there, ive been using this list for a few years. However its stuck on an infinite loading screen at the moment does anyone know a fix?

Getting this too, any update

Nah ive tried loads of stuff to fix it but havnt been able to.
On Sat, 4 Feb 2023, 18:43 Giacomo Lawrance, @.***>
wrote:

Getting this too, any update
—
Reply to this email directly, view it on GitHub
https://github.com/richi3f-zz/pokemon-trading-spreadsheet/issues/22#issuecomment-1416822849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDKLOGY3JZA7NOCISSG4U3WV2PNJANCNFSM5EXL2YGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Same, tried changing the defined url entirely but doesn't work. Found any decent alts? Thanks


additonal payers to support

Hi, possible for you to include additional payers?
such as:

NFTHive : nft.hive - boost

What sites is have this payers? For add new i should know site and example transaction.

NFTHive marketplace (nfthive.io) when buy a drop.
example transaction:
https://wax.bloks.io/transaction/d3471a168c2985dff9efe1cabba66a4a8b6bfc8cd8cf92fc1fd6bb0eb80ee9da?tab=traces

NFTHive does not pay for transactions
To pay in the first action signer it must be NFTHive, but in this example in all actions signer it is nblig.wam

You can see an example of a transaction that was actually paid:
neftyblock - https://wax.bloks.io/transaction/b97bef9b990111e8a36bd223760247a6e0f55177881d0c40eb742857aba6bf80
There is an action here that was signed by the neftybrespay account and that is where the transaction was paid from.


requested feature: would be interesting to display the file/directory name in the bottom of the lumina-fm screen

when we select "icon view" in lumina-fm, most of the time the filename (or directory name) is too long.
So we see the begining of the name.
Would be nice to display the fullname in the tooltips area when the user goes over (or click 1x) the file

This is no longer an issue with the new file-manager overhaul for 0.8.7


Fix typos in documentation

Just a few minor fixes to the documentation:

fix naming of stories_route
add extra line indicating that this gem itself should be installed
add missing Storybook JS dependency
fix layout syntax

I'm going to close this PR. Symbol view args work in general and are supported by Rails. There must be some other factor at play here but I don't think it much to do with this gem or worth adjusting the docs for.


D455 only works on some smartphones

Required Info

Camera Model
D455

Firmware Version
<IP_ADDRESS>

Operating System & Version
Android

Kernel Version (Linux Only)

Platform
Smartphone

SDK Version
2.41.0

Language
Java/C++

Segment
Robot

Issue Description
I'm trying to use D455 with Android smartphones. I used RS-camera App, compiled from the repository or downloaded from app store to test whether the camera works properly.
However I noticed that the camera only works properly for some phones (e.g. Samsung S10 plus), while can not even be detected for other phones.
I thought it could be due to the power supply problem. It might be that for cheaper phones they cut off some functionalities of the type-C interface, and can not supply enough power for the camera.
Has anyone encountered similar problems ? How it it resolved ?
And if it's indeed caused by the power supply problem, What's the power requirement of D455 ? Thanks in advance !

Hi @zc08  The chipset used in a particular Android phone model may be an issue.  So phones from the same manufacturer may or may not work depending on the chipset that a model has.  A member of staff of Samsung's developer program made the following comment in 2020:
"Tab A and Active Tab 2 use different AP chipset, so there may be differences in whether USB Video Class devices are supported or not.  However, it is difficult to check the association between UVC support and invalid value in the internal data structure of librealsense from the Samsung side".
You may also encounter issues if the phone model has Android 10 instead of 9 or 11:
https://github.com/IntelRealSense/librealsense/issues/8235#issuecomment-783291401
On Android 10 devices, a workaround that has worked consistently is to set targetSdkVersion to a value of '27', though this has become impractical for Android developers in recent time as newer Android SDK versions have been released that they need to target in their application.

Hi @zc08  Do you require further assistance with this case, please?  Thanks!


Improving the interactive mode

Description
The GUI that is used in the interactive mode can be improved in various ways. The purpose of this issue is to suggest and discuss future functionalities and improvements.
Here are a few suggestions:

[ ] Adding the ability to zoom using mouse scroll
[ ] Adding a color bar
[x] Adding a user input window that enables configuring parameters such as thresholds, the overlay/surface to load, lighting intensities, colors, etc.
[ ] Adding the ability to capture a snapshot and save it

All these are really nice to have, but not necessary for the main purpose of generating screenshots in QC, testing pipelines and for publications. So I would put them on medium to low priority. The highest priority of these would be the ability to adjust thresholds in interactive mode, in order to know what to set in the screenshot mode.

Update
A simple user input application was implemented in https://github.com/m-reuter/WhipperSnapper/pull/7.
At the moment, this only allows adjusting thresholds during runtime.
Further extensions to this application and the other suggested improvements may be added later on, but are not currently prioritized.


Snap on release

Hey @onebone, would it be possible to snap the header to its nearest edge when a scroll is released?

I wrote something but not sure if it's efficient enough:
@Composable
fun rememberSnappingFlingBehavior(scaffoldState: CollapsingToolbarScaffoldState): FlingBehavior {
  val defaultFlingBehavior = ScrollableDefaults.flingBehavior()
  return remember {
    object : FlingBehavior {
      override suspend fun ScrollScope.performFling(initialVelocity: Float): Float {
        val remainingVelocity = defaultFlingBehavior.run { performFling(initialVelocity) }
        if (scaffoldState.toolbarState.progress <= 0.3f) {
          scaffoldState.toolbarState.collapse()
        } else {
          scaffoldState.toolbarState.expand()
        }
        return remainingVelocity
      }
    }
  }
}

Personally, I have not found such a feature in the lib. I also need it and I want to implement it this week.
@onebone are there any specific guidelines for contributors?

No I do not have wrote such guidelines, but it would be fine if the code is consistent with the original code base; such as indenting and continuation by tabs and something like that.

For now I implemented basics of snapping feature. Snapping is configured by the SnapStrategy instance (almost like the ScrollStrategy) to match the library code style. I have successfully implemented snapping for ExitUntilCollapsed scroll strategy, but with others there is some problems...
I can easily animate the toolbar because I have access to its state object. But in the case when the toolbar moves outside the screen (EnterAlways EnterAlwaysCollapsed), this is of little use - I need to animate the offsetY of CollapsingToolbarScaffoldState, not the CollapsingToolbarState. Now this gives me some architectural difficulties. @onebone, I would be glad to hear your opinion on how best to do this. And feel free to review draft PR

Okay, the snap is working as it should. However, there are a few things that bother me:

Suspicious jump in toolbar animation speed
I think it's worth implementing a snap animation canceling if the onPreScroll was called during the animation
Choreographer "Frame time is X ms in the future" issue

@RareScrap Thank you for sharing, I will review your PR within this week!

Hi, I have already created PR for this: https://github.com/onebone/compose-collapsing-toolbar/pull/83
By the way, if you want to use this feature, I created a separated remote dependency, while this PR is under review:
Add it in your root build.gradle at the end of repositories:
all projects {
	repositories {
		...
		maven { url 'https://jitpack.io' }
	}
}

Step 2. Add the dependency
dependencies {
        implementation 'com.github.GIGAMOLE:ComposeCollapsingToolbar:latest-version'
}

Or you can simply download it from there:
https://github.com/GIGAMOLE/ComposeCollapsingToolbar/releases

Is this implemented into the library?


Microsoft.Extensions.Logging.ApplicationInsights adds trace IDs a 2nd time to trace telemetry

List of NuGet packages and version that you are using:

Microsoft.Extensions.Logging.ApplicationInsights 2.22.0

Runtime version (e.g. net461, net48, netcoreapp2.1, netcoreapp3.1, etc. You can find this information from the *.csproj file): netstandard2.0
Hosting environment (e.g. Azure Web App, App Service on Linux, Windows, Ubuntu, etc.): Azure App Container, Linux, Windows, Ubuntu

Describe the bug
The trace IDs (span, parent, trace) are included in all telemetry by default, but they’re also included in all log messages. So when we send log messages to app insights as traces, they’re on the trace telemetry twice. Both as custom properties, and system properties.

They're also on Exception telemetry emitted by the same library.
To Reproduce
Use the Microsoft.Extensions.Logging.ApplicationInsights package and log a warning and an exception.
Activity.Current= new Activity("test");
logger.LogWarning("test trace telemetry");
logger.LogWarning(new Exception("test"), "test Exception telemetry");

have you enabled scopes feature? it is likely that traceid and other duplicate info is coming from scopes.

Yes, I have scopes enabled because I want my log scopes added to the telemetry.

Thanks for confirming!
Very good chance that the the duplicate TraceId,SpanId are coming from scopes!
Are you enabling it yourself using this doc? Or it is coming automatically?
https://learn.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-7.0#automatically-log-scope-with-spanid-traceid-parentid-baggage-and-tags
Not much we can do about it in this repo now. I have seen similar issues reported in OpenTelemetry as well. There are some PRs in asp.net core where it is removing these things from scopes, so it won't end up being duplicated.

@cijothomas I'm using the default options, which includes the activity tracing info in logger scope. I was hesitant to remove them via the startup options because maybe they're helpful for looking through the console logs if my telemetry isn't working. But that seems like a weak reason, so I think I will just disable those.

Not much we can do about it in this repo now.

Why is that? I figured the telemetry processor that adds the logger scopes to the telemetry could filter out the telemetry properties because those are clearly duplicate information. Or is that handled by something lower level in asp.net core?

Not much we can do about it in this repo now.
Why is that?

I meant to say this repo won't offer a new feature to selectively disable certain scope fields. It is mainly because of OpenTelemetry quickly becoming the instrumentation choice, and not much feature additions are occurring in this repo.
Probably possible to remove the duplicates yourself with a custom telemetry processor, if you can identify then reliably. (in your case, it looks like it should be possible, as you are looking to remove certain fields like traceid,spanid)


ChDB_TPCH_SF10_Queries

Hi Team,
I have removed comment for Query 21.
Thanks
Reema Jain

@all-contributors please add reema93jain for tests


🚧Handle premature EBO unbinding

I have done the items below . . .

[X] I have updated the title by replacing the '<title>' section.

Description
When working with OpenGL, it is not ideal to unbind an EBO(Element Buffer Object) before unbinding the associated VAO(Vertex Array Object).  This is due to the non-ideal that OpenGL state is put into which can lead to hard to find bugs and issues.  It is best practice, (not required) in OpenGL to unbind the VAO first before unbinding the EBO.
🛑STOP!! DO THIS FIRST🛑

[ ] Make sure that issue #105 has been implemented first

[ ] Add code in the GLInvokerExtensions.UnbindEBO() method to check and see if any VAO objects are currently bound and if so, unbind the VAO first before unbinding the EBO.
[ ] Testing application full checked to verify that everything is working correctly.

Acceptance Criteria
This issue is finished when:

[ ] Code documentation added if required
[ ] Unit tests added
[ ] All unit tests pass

ToDo Items

[ ] Draft pull request created and linked to this issue
[X] Priority label added to issue (low priority, medium priority, or high priority)
[X] Issue linked to the proper project
[X] Issue linked to proper milestone
[ ] Unit tests have been written and/or adjusted for code additions or changes
[ ] All unit tests pass

Issue Dependencies

#105

Related Work
No response

Groomed


Use the new resume table syntax

This patch should be merged in once, we have updated wasmtime to use the latest wasm-tools release, which includes the new resume table syntax.

https://github.com/wasmfx/wasmfxtime/pull/212 includes the new resume table syntax.


Replace slashes with colons in image tag

Fixes #232

🤦♂ I made the same mistake in the gnomAD deploy script too (ab780cee2c8262731c945f02b1c49afd701e5377)


mysql:8.0 - "mysql_native_password' is deprecated and will be removed in a future release"

ddev start with mysql:8.0 shows this output in ddev logs -s db:
2024-08-27T17:20:08.116145Z 17 [Warning] [MY-013360] [Server] Plugin mysql_native_password reported: ''mysql_native_password' is deprecated and will be removed in a future release. Please use caching_sha2_password instead'
It would be good to use the newer approach, if it doesn't break things.
This is in the initial setup, in create_db.sh:
https://github.com/ddev/ddev/blob/8900d5cdaa079244f962a00f990773e27fb878a5/containers/ddev-dbserver/files/create_base_db.sh#L76-L82

The caching_sha2_password plugin is fully supported as of PHP 7.4.4.

https://www.php.net/manual/en/mysqli.requirements.php

Other complaints:

[ ]  The syntax 'expire-logs-days' is deprecated and will be removed in a future release. Please use binlog_expire_logs_seconds instead
[ ]  Disabling symbolic links using --skip-symbolic-links (or equivalent) is the default. Consider not using this option as it' is deprecated and will be removed in a future release
[ ]  Insecure configuration for --secure-file-priv: Location is accessible to all OS users. Consider choosing a different directory.

Turn off binlogs? https://github.com/ddev/ddev/issues/6244#issuecomment-2478500169


Exclude ASCII escape character from binary data detection

extend tests with one which confirms fix: ls --color=always
extend tests with negative tests (xxd, hexdump)
closes: #574

Looks great!  Merging.


When using subscription, TotalCountPaginationExtension module makes error.

Hello! Thank you for your great work.
When using "TotalCountPaginationExtension" module,
setup subscription using  this docs. ( https://strawberry-graphql.github.io/strawberry-django/guide/subscriptions/#subscriptions )
Then, strawberry_django_extras.decorators.is_async returns False.
But, it need return True.
Eventually, "You cannot call this from an async context - use a thread or sync_to_async." exception occur.
Please, check this. Thank you. Have a good day.

Hello @fingul.
strawberry_django_extras.decorators.is_async simply checks if you are running within an event loop.
def is_async() -> bool:
    try:
        asyncio.get_running_loop()
    except RuntimeError:
        return False
    else:
        return True

If you aren't running within an event loop it's likely because at some point in the execution chain your code has already been wrapped with @sync_to_async either because you wrapped it or some other extension you are using did. Keep in mind extension order matters.
Please provide some snippets on how you are using the extension , your complete traceback and some more information on how you are running your app ( fe unicorn , daphne ? ) so I can replicate the issue because I cannot seem to get a replication of the issue.
Thanks for reporting this.


Asynchronous Sink Wrapper

Should close #102.

Option
Type
Description

/sink
object
The wrapped sink.

/factor
uint
Queue capacity factor as a power of 2. Value of 12 means queue capacity 2¹² = 4096.

/overflow
string
Overflow policy. Possible values: drop, wait (sleep until event dequeued).

/underflow
string
Not yet implemented. Underflow policy. Possible values: sleep, wait.

Sample config:
- type: asynchronous
  sink:
    type: file
    path: /var/log/blackhole.log
  overflow: drop
  underflow: wait

[Current coverage][cc-pull] is 67.32%

Merging [#118][cc-pull] into [develop][cc-base-branch] will increase coverage by -15.32%

@@           develop       #118   diff @@
=========================================
  Files           62         66      +4
  Lines         1360       2494   +1134
  Methods        153          0    -153
  Branches         0          0
=========================================
+ Hits          1124       1679    +555
- Misses         236        815    +579
  Partials         0          0

File src/attribute.cpp was modified. more

Misses -4
Partials 0
Hits +4

File src/format.cpp (not in diff) was created. more
File ...xtensions/format.hpp (not in diff) was created. more

Powered by Codecov. Last updated by [9c57ef4...b3255ed][cc-compare]
[cc-base-branch]: https://codecov.io/gh/3Hren/blackhole/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/3Hren/blackhole/compare/9c57ef424f097546c8a13558c659c299b07510fa...b3255ed93ea9930d841e73aa9ccf1debc12c4ce6
[cc-pull]: https://codecov.io/gh/3Hren/blackhole/pull/118?src=pr

Merged manually in develop branch.


bethany-chuem

profile update for bethany cheum

Docs Build status updates of commit bf5c686:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

advocates/bethany-cheum.yml
:x:Error

Details

advocates/bethany-cheum.yml

Line 1, Column 1: [Error: schema-not-found] Unknown schema ''.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Genuine question

Is this project now dead?
Asking as I am wondering whether or not to remove this from servers.
NOTE: I do not want to but currently there is a few issues.

As I'm sure you're aware, the author of this project @Prajithp replied to an issue only 11 days ago, 9 days ago from the posting of this issue. I'd just like to point out that this type of "issue" doesn't particularly encourage authors to help assist with problems and in my opinion is one more reason as to why any author might feel like abandoning a project.

@BeZazz, I don't want to abandon this project as it is installed on 100+ servers and they are actively using it. The reason why I'm not active on this is, I got a new project from my office and therefore i have to work around 13 hours a day to complete it before the deadline.
Could you please point out all issues you are facing? so that I can look into it when I get much free time.

Hi @Prajithp the main issue I have is
https://github.com/Prajithp/letsencrypt-cpanel/issues/87
I will go and donate $20 to you now as a thank you for the time you have put into this.

Sorry I tired but received the message.

Currently PayPal accounts in India are only able to send payments. This recipient is not eligible to receive funds.

#87 would fix this issue


CB-10072 Basic CRN resource type validation

this commit ensures that resources can be created with predefined resourcetype/servictype pair, also some parts of CRN should not be configurable (like partition, region).
checking for resourcetype/servicetype pair has been added to ValidCrn annotation to avoid situations like calling environment related endpoint with datalake crn.
introduced new ValidCrnCollection annotation for crn collections in APIs
adding more restrictive ValidCrn/ValidCrncollection to some environment APIs calls and freeipa request objects

See detailed description in the commit message.

@doktoric please add someone from your team to check environment related code if you cannot check this
@keyki i would like to ask you for the same regarding freeipa code

Can you add a simple mock test which has at least 2 CRN's that are invalid and assert the error message return on the API?

Can you add a simple mock test which has at least 2 CRN's that are invalid and assert the error message return on the API?
Just to make sure no one breaks the nice error message functionality.

sure
also will enhance error message as discussed


Updates component to new theme structure

A theme component needs to be set to "component": true in order to show up on the components list in the admin interface.

Thanks for this @hnb-ku. I completely missed this PR, sorry about that 🙁
(adding you as a collaborator...)


New version: Hellofont.Hellofont version 3.0.5

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.2 schema?

Microsoft Reviewers: Open in CodeFlow

@msftbot blocking issue
2022-11-09 19:07:38.194 [CLI ] Caught std::exception: No mapping for the Unicode character exists in the target multi-byte code page.

This will need to be rechecked once changes from

https://github.com/microsoft/winget-cli/issues/2057

find their way into the validation pipeline.

@wingetbot run

/AzurePipelines run


object: add get storage limits api

Codecov Report
Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (50f41ae) 55.23% compared to head (5d86508) 55.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   55.23%   55.18%   -0.05%
==========================================
  Files         142      142
  Lines       34114    34256     +142
==========================================
+ Hits        18842    18904      +62
- Misses      13266    13351      +85
+ Partials     2006     2001       -5

Impacted Files
Coverage Δ

pkg/object/bos.go
1.11% <0.00%> (-0.06%)
:arrow_down:

pkg/object/cos.go
1.00% <0.00%> (-0.05%)
:arrow_down:

pkg/object/eos.go
4.00% <0.00%> (-0.77%)
:arrow_down:

pkg/object/ibmcos.go
0.98% <0.00%> (+0.02%)
:arrow_up:

pkg/object/interface.go
80.00% <ø> (ø)

pkg/object/ks3.go
0.82% <0.00%> (-0.03%)
:arrow_down:

pkg/object/minio.go
55.93% <0.00%> (-8.78%)
:arrow_down:

pkg/object/object_storage.go
76.19% <0.00%> (-2.50%)
:arrow_down:

pkg/object/obs.go
0.66% <0.00%> (-0.02%)
:arrow_down:

pkg/object/oos.go
3.70% <0.00%> (-0.38%)
:arrow_down:

... and 10 more

... and 8 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Wrong ip in logs when using multiple balancers (cloudflare+traefik)

Which version are you using?
v1.5.1
Which operating system are you using?

[ ] Linux amd64 standard
[x] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
The wrong ip (cloudflare's) shows up in the logs when using an endpoint that's behind cloudflare which points to traefik.
Describe how to replicate the issue

start the server
have an endpoint in behind cloudflare pointing to a traefik instance
have that entrypoint based on some rule point to the mediamtx docker
just access a hls/webrtc or whatever, no need to publish anything
logs show cloudflare ip instead of the original ip from the list.

Did you attach the server logs?
2024/02/28 15:11:58 INF [HLS] [muxer dji] created (requested by <IP_ADDRESS>)
2024/02/28 15:11:58 DEB [path dji] created
2024/02/28 15:11:58 INF [HLS] [muxer dji] destroyed: no one is publishing to path 'dji'
2024/02/28 15:11:58 DEB [path dji] destroyed: not in use
2024/02/28 15:11:58 DEB [HLS] [conn <IP_ADDRESS>:49994] [s->c] HTTP/1.1 404 Not Found
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: dji.d3x.ro
Content-Type: text/plain
Server: mediamtx
(body of 18 bytes)
2024/02/28 15:12:00 DEB [HLS] [conn <IP_ADDRESS>:49994] GET /dji/index.m3u8
2024/02/28 15:12:00 DEB [HLS] [conn <IP_ADDRESS>:49994] [c->s] GET /dji/index.m3u8 HTTP/1.1
Host: dji.d3x.ro
Accept: /
Accept-Encoding: gzip
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8,ro-RO;q=0.7,ro;q=0.6
Cdn-Loop: cloudflare
Cf-Connecting-Ip: <IP_ADDRESS>
Cf-Ipcountry: RO
Cf-Ray: 85c99a751c6e6afe-OTP
Cf-Visitor: {"scheme":"https"}
Cookie: cf_clearance=yqV7LfMB_u94CeZgLSuPspw6XJW5RXhpVB29_1OgMNE-1709133116-1.0-AU4bHbG/GtmyUsKWSSHBdD3vHE32h48lF49MPtmwUod49odwBaKWyQ0yRRcFNOhAeohc5XzIi0s+sUKHJmvWANU=
Dnt: 1
Referer: https://dji.d3x.ro/hls/
Sec-Ch-Ua: "Not A(Brand";v="99", "Google Chrome";v="121", "Chromium";v="121"
Sec-Ch-Ua-Mobile: ?0
Sec-Ch-Ua-Platform: "Windows"
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: same-origin
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
X-Forwarded-For: <IP_ADDRESS>, <IP_ADDRESS>
X-Forwarded-Host: dji.d3x.ro
X-Forwarded-Port: 443
X-Forwarded-Proto: https
X-Forwarded-Server: d99ae4dca9d4
X-Is-Trusted: yes
X-Real-Ip: <IP_ADDRESS>
X-Replaced-Path: /hls/index.m3u8
Did you attach a network dump?
no

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For says the first IP in the list should be used...
X-Forwarded-For: <client>, <proxy1>, <proxy2>

Are you setting this property in config correctly?
# List of IPs or CIDRs of proxies placed before the HLS server.
# If the server receives a request from one of these entries, IP in logs
# will be taken from the X-Forwarded-For header.
hlsTrustedProxies: []


avoid swallowing exception when device-plugin exit, it should be thrown

What type of PR is this?
/kind bug
What this PR does / why we need it:
At present, the device-plugin code will be swallowed if there is an exception when exiting and will not return. This should be fixed.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/auto-cc


MelGAN can not outperform griffin lim

Hello and thank you for this easy to use tool. I have actually applied MelGAN as vocoder but it does not perform better than griffin-lim algorithm. What could be the possibly reason, should I increase the number of data available? I am using around 30 hours of data.
At first I have trained setting sampling rate fs=16000 it gave weird voices. (my training data has 16000 sampling rate)
Then I converted the training data to 22050 and set fs=22050 and trained with that. Then results become nearly as good as the griffin lim algorithm.

Amount of the training data seems enough.
Please consider trying with the other config (e.g. full_band_melgan).

Amount of the training data seems enough.
Please consider trying with the other config (e.g. full_band_melgan).

Thank you very much. I have tried full_band_melgan and it works better


🐛 Bug: incorrect design link on Get Involved page

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected
Expected to be taken to issues marked design
Actual
Was instead taken to issues marked data gathering
Additional Info
I'd like to fix this issue.

.take


[feat]: validate icon size when packing s9pk

The size of an icon should be limited for performance reasons, especially given that we would like to cache them in memory.

Validate only or shrink?

Maybe validate for P1, shrink for P2, unless shrinking is trivial?

I suspect that any code needed to validate pixel dimensions of an image is going to be in a library capable of shrinking them. But if not, I agree. Validation is MVP.