[google_maps]: onCameraMoveStarted stops working after tap outside map view

Hello! Here's an example:
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

class TestRoute extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Stack(
      children: <Widget>[
        GoogleMap(
          initialCameraPosition: CameraPosition(
            target: LatLng(36.536123, -86.671607),
            zoom: 16
          ),
          onCameraMoveStarted: () {
            print('start moving');
          },
        ),
        Positioned(
          top: 0,
          left: 0,
          right: 0,
          child: Container(
            height: 100,
            color: Colors.white,
          ),
        )
      ],
    );
  }
}

onCameraMoveStarted callback works until I tap on the white container, after I do it it's called only once and not called anymore. The same problem with onCameraIdle, but onCameraMove works fine.
I tried only iOS, not sure if problem exists on Android too.

flutter doctor -v
[✓] Flutter (Channel unknown, v1.7.12-pre.40, on Mac OS X 10.14.5 18F132, locale
    en-UA)
    • Flutter version 1.7.12-pre.40 at /Users/eugenepisotsky/Development/flutter
    • Framework revision 3badcf51a4 (12 hours ago), 2019-06-28 15:14:03 -0700
    • Engine revision e96900df2f
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/eugenepisotsky/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2, Build version 10E125
    • CocoaPods version 1.7.2

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1343-b01)

[✓] IntelliJ IDEA Community Edition (version 2019.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 35.3.3
    • Dart plugin version 191.7221

[✓] Connected device (3 available)
    • iPhone (Eugene) • 1f7899e1777a61e4f950a866195f88b96e420b85 • ios
      • iOS 12.3.1
    • macOS           • macOS                                    • darwin-x64
      • Mac OS X 10.14.5 18F132
    • Chrome          • chrome                                   •
      web-javascript • Google Chrome 75.0.3770.80

• No issues found!

I have a same problem.

@EugenePisotsky Is it the same while using current flutter stable and google_maps_flutter 0.5.21+7?

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@EugenePisotsky Is it the same while using current flutter stable and google_maps_flutter 0.5.21+7?

@BondarenkoStas I tried 0.5.21+9, still the same. more information:

on android it works as expected
on iOS, when I click on button, everything is fine (I think it works fine with all gesture detector widgets), but when I click on simple view, it stops working

Hi @EugenePisotsky
can you please provide your updated  flutter doctor -v
and your flutter run --verbose?
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so its always better to open new issues and reference related issues.

I had the same problem.
Call to moveCamera or animateCamera when tapping anything other than the map, seemed to get workaround the issue for me.
final level = await controller.getZoomLevel();
await controller.moveCamera(CameraUpdate.zoomTo(level));

@bluelet13 I have a complex UI on top of the map, not easy to implement this workaround for me

I have a button in a stack on top of the map that is supposed to display off itself on tap, then I want to display the button back when the camera starts moving but I'm facing the same issue. Only OnCameraMove works but I'm not sure if it's very good to use it for that feature, it fires so many times.

Hi @EugenePisotsky
Using the code sample I can't reproduce the issue on the latest google_maps_flutter
https://user-images.githubusercontent.com/48603081/115714540-e4384880-a37f-11eb-96c4-20a8839da37f.mov

complete code sample
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: TestRoute(),
    );
  }
}

class TestRoute extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Stack(
      children: <Widget>[
        GoogleMap(
          initialCameraPosition:
              CameraPosition(target: LatLng(36.536123, -86.671607), zoom: 16),
          onCameraMoveStarted: () {
            print('start moving');
          },
        ),
        Positioned(
          top: 0,
          left: 0,
          right: 0,
          child: Container(
            height: 100,
            color: Colors.red,
          ),
        )
      ],
    );
  }
}

dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^0.1.3
  google_maps_flutter: ^2.0.3
  google_maps_flutter_web: ^0.3.0

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.5, on macOS 11.2.3 20D91 darwin-x64, locale
    en-GB)
    • Flutter version 2.0.5 at /Users/tahatesser/Code/flutter_stable
    • Framework revision adc687823a (6 days ago), 2021-04-16 09:40:20 -0700
    • Engine revision b09f014e96
    • Dart version 2.12.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (3 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios            • iOS
      14.4.2
    • macOS (desktop)        • macos                     • darwin-x64     •
      macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)           • chrome                    • web-javascript •
      Google Chrome 90.0.4430.85

• No issues found!

[✓] Flutter (Channel master, 2.2.0-11.0.pre.215, on macOS 11.2.3 20D91
    darwin-x64, locale en-GB)
    • Flutter version 2.2.0-11.0.pre.215 at
      /Users/tahatesser/Code/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5865c14d67 (7 hours ago), 2021-04-22 06:44:03 +0200
    • Engine revision 7e69744ede
    • Dart version 2.14.0 (build 2.14.0-18.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[!] IntelliJ IDEA Community Edition (version unknown)
    ✗ Invalid IntelliJ version number.

[✓] VS Code (version 1.55.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (3 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E • ios            • iOS
      14.4.2
    • macOS (desktop)        • macos                     • darwin-x64     •
      macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)           • chrome                    • web-javascript •
      Google Chrome 90.0.4430.85

! Doctor found issues in 1 category.

Closing, as this isn't an issue with google_maps_flutter  itself. If you disagree, please write in the comments and I will reopen it.
Thank you


fix: Remove EliminateExceptions lowering pass

Description

Torch-TensorRT has evaluator support for exception elimination and this particular lowering pass causes certain models to halt compilation indefinitely
Remove this lowering pass temporarily while a more robust and safer long-term solution is in development

The torch::jit::EliminateExceptions lowering pass is listed as "risky" in the documentation, and as per #1823, can also cause compilation to halt on certain graphs. We should remove this pass while awaiting a more robust solution through the implementation of #1842 (giving the user the option to eliminate exceptions more effectively in the graph via a compile-time flag). Torch-TRT already has an evaluator for prim::RaiseException, and can thus handle these operators:
https://github.com/pytorch/TensorRT/blob/09e15b25e3eee0110bfc51db287dfc7e167a6b17/core/conversion/evaluators/prim.cpp#L337-L343
Note: This PR does not remove the existing EliminateExceptionOrPassPattern lowering pass, as that pass is intended for a more specialized exception case.
Fixes #1823
Relevant to #1842
Type of change
Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x] I have performed a self-review of my own code
[ x ]  I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ - ] I have added tests to verify my fix or my feature

See test_aten_evaluators

[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

That seems to help in certain cases in which the compilation was hanging, however, I am also now seeing some

"Expected Tensor but got Uninitialized"

error. Looking at #1282 , it seems that adding torch::jit::EliminateExceptions was the solution to such errors...
My understanding of the interactions of these different pieces is limited, but I am wondering whether removing the call to torch::jit::EliminateExceptions is not just fixing one thing and breaking (again) another one.

@gcuendet - Thank you for the follow-up. We are looking into the Expected Tensor but got Uninitialized error simultaneously with this change, as it seems the usage of torch::jit::EliminateExceptions is more of a temporary fix for that problem (see: https://github.com/pytorch/TensorRT/pull/1785#pullrequestreview-1365562514).
Do you have any examples of models you are willing to share which fail with the Uninitialized error, when the torch::jit::EliminateExceptions pass is removed?

Thanks for the answer @gs-olive . I am trying to simplify our failing model to something minimal that I can share, but I am not sure I'll be able to 😞 . If I do I'll share, of course!

Hi @gcuendet - I found the issue in torch::jit::EliminateExceptions originates from the calls to replaceAllUsesWith, and I've addressed this by replacing it with the safer alternative replaceAllUsesDominatedByNodeWith. This resolves the issue on the nn.Upsample case on my machine. Please let me know if it resolves that case while still retaining the benefits of the original EliminateExceptions on your models.

Thank you for the detailed response! I agree with your statement and assessment that a proper solution for #1842 would address this issue. Another alternative is to support nodes such as %60 : Tensor = prim::Uninitialized(), since these can also show up in other contexts and should not fail. @bowang007 is working on something similar now, and that fix, in conjunction with this PR should help to resolve the issues relating to exceptions and uninitialized tensors, while the other PR is pending.

Do you plan to open a PR in pytorch with that fix?

I intend to open an issue with PyTorch first to assess whether the proposed fix is a viable solution to the issue and whether the intended behavior of that function is retained, then I will open a PR for it.

Hi @gcuendet - I've made some updates to this lowering pass and added a few test cases. I have also verified that for the case in #1823, the model no longer halts mid-compilation (and compiled successfully on my machine, using this PR). Could you please verify on the model with the new updates as well?

Hi @bowang007 - thanks for the comment, this makes sense.

I agree that the pass can be risky in the sense that it removes exceptions. The main rationale for removing these exceptions would be that our converters already handle the edge cases which these exceptions are checking for, so we shouldn't need the extra logic and conditionals they bring with them. For instance, the conditional shown in the comment above could cause unnecessary fallback which can affect performance. TRT and our converters already apply a large number of input validation checks to address these cases.
Removing the torch::jit::EliminateExceptions pass entirely could also be a viable solution to resolve the compilation halting here, I agree.
This is a good point, thanks for bringing this up. I've updated the implementation to just directly modify the prim::If node's input, to address the case you mentioned.

Have we done testing on what happens if we just remove the pass? iirc, we treat exceptions as compile time errors though the evaluator, the original purpose was to have less nops in the graph and remove unnecessary conditionals

I haven't done specific testing (aside from CI) on removing the pass, but I would expect a performance degradation on models which have conditional exception logic, since the prim::If would cause fallback in the graph, increasing graph segmentation.


In mixed content, whitespace is not being preserved after word split

Example

  ARE WE
GOOD?

https://codepen.io/shshaw/pen/b97ceab839601bf0a1ac395c41488ca8
The space next to ARE should be preserved but is not

Fixed in https://github.com/shshaw/Splitting/commit/971c9405bc390025598cd84d0ede49976e54b963
I added a test for this case and modified utils/split-text.js to preserve up to one space on either size of a phrase

Awesome work! Looks good from here.
On Tue, Aug 7, 2018 at 7:04 AM Christopher Wallis<EMAIL_ADDRESS>wrote:

Fixed in 971c940
https://github.com/shshaw/Splitting/commit/971c9405bc390025598cd84d0ede49976e54b963
I added a test for this case and modified utils/split-text.js to preserve
up to one space on either size of a phrase
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/shshaw/Splitting/issues/13#issuecomment-411032900,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvbw1KtECdaDKPmWWhelWWCToe4Ga-hks5uOYJUgaJpZM4Vw1Yd
.

Cool. I'll close this out.


added hint about math fonts with serif

I was not sure, if the poster.tex would benefit from this addition too.
Closes #5

I think it might. Would you be up for adding the hint to the poster as well please?

No problem, see https://github.com/Helmholtz-AI-Energy/beamer-template-2024/pull/6/commits/3961ac1e99f017d7bbd463ac03d79520956d1079

Thanks a lot for the contribution


Using nn.Sequential with nn.HSM throws error

Is it meant to be used with nn.Sequential? It calls HSM.updateOutput(input, target) without a target argument at https://github.com/torch/nn/blob/master/Sequential.lua#L29.
I receive this error with CUDA (fbcunn):
HSM.lua:197: attempt to index local 'target' (a nil value)
It fails here without CUDA (fbnn):
https://github.com/facebook/fbnn/blob/master/fbnn/HSM.lua#L182

HSM is a criterion. it takes an input, target like the Criterion interface, and derives from nn.Criterion. So it cant be used as a module.

Tried to run test_HSM.lua, still got an (unrelated) error:
/home/ubuntu/torch/install/bin/luajit: /home/ubuntu/torch/install/share/lua/5.1/fbnn/HSM.lua:187: attempt to call field 'HSM_updateOutputWithTarget' (a nil value)
stack traceback:
/home/ubuntu/torch/install/share/lua/5.1/fbnn/HSM.lua:187: in function 'updateOutput'

the test is for the CPU version of HSM, which requires MKL. So I disabled the compilation of the CPU parts in the open source branch. If you run the test after converting the nn.HSM modules to CUDA, it'll work.


How to delete large numbers / all from Custom object?

I did not see this, and wanted to share with others. You can delete 10,000 at a time using Tooling. This beats 200 at a time and is simpler.
const destroyAllBulk = (conn: jsforce.Connection) =>
  new Promise((resolve, reject) => {
    const apexBody =
      'delete [SELECT Id from Object__c LIMIT 10000];';
    conn.tooling.executeAnonymous(apexBody, (err, res) => {
      if (err) {
        console.log(err);
        return reject(err);
      }
      console.log(res);
      return resolve(res);
    });
  });

triaging old issues...
thanks for the example!
for reference, jsforce also supports the bulk v2 API which can be used for big delete operations too:
https://jsforce.github.io/document/#bulk-v2-api


[ci] skip package_info tests on firebase test lab

Skipping the package_info from firebase test lab command.
See also: https://github.com/flutter/flutter/issues/74944

Fixed in https://github.com/flutter/plugins/pull/3478

Fixed in https://github.com/flutter/plugins/pull/3478


Upgrade Bootstrap to latest version (v3.3.x)

100 ... 114 commits and 120 123 changed files later...
This upgrades Bootstrap to the latest version – but wait! There's more! It also includes:

A new, sexy navbar
Tweaked color scheme
Hundreds of style tweaks
Refactored layout
Updated select2
Updated jQuery.dataTables
Updated simple_form
Updated jQuery.dotdotdot
Removed jQuery.sticky (replaced with Bootstrap.affix)
Tons of other stuff I don't remember anymore

Some notes:

So much about the views is just really brittle and hacky (in styling, structure, and content). Fixing that stuff was out of scope.
Our Sass has gotten messy. We need to refactor and reorganize (ie. there are variable and mixin definitions defined in random files instead of in _variables.css.scss and _mixins.css.scss)
I removed some unused CSS, but that's a job for another PR
I commented out rack-mini-profiler in the Gemfile because it's too distracting during code review. Once review is done I'll uncomment it. I uncommented to push a commit to force Travis to build.
MOBILE VIEWS ARE BROKEN AS HELL. The app's responsive design is acceptable down to tablet widths, but once you get to phone widths Reservations becomes comically unusable. (also a job for another PR)
We need to move vendor assets out of app/assets and into vendor/assets (also a job for another PR)

We need a better way of managing vendor assets. Because we already have a few (jQuery.dotdotdot for example) that we just downloaded, unzipped, and stuck in the folder, which is a terrible way to manage dependencies. We should switch vendor asset management over to Bower and/or Rails Assets

We need to post an updated screenshot to the site once this lands – Reservations looks a bit different now :smile:

Yeah, I think that's it for now. Have fun :wink:
(Fixes #245)

Ah there we go, I knew something would have to fail. I'll fix the rubocop stuff first.

wow this looks slickkk
a couple minor things:

do we want to change the navbar highlight animation? the blue glow doesn't match the new brown as well, plus it doesn't really mesh well with the new boostrap's super-flat style
If there's an announcement or other flash message, or more than 1 or 2 items in the cart, I can't get to the checkout buttons on the cart unless I scroll all the way to the bottom of the catalog. This behavior is actually present in the old version still so idk if it's worth fixing now :P

Yeah I was thinking that too even though I changed the style of gradient for the nav links. I think I'm going to leave the "glow" effect on the Reservations brand component though – it's just too fun to give up. :stuck_out_tongue_closed_eyes: I did forget to change the blue color though now that I've changed the hue of brown, so I'll work on a better blue. It will still be some kind of light blue though – I think that color combination works well. But I'll probably change the hover effect for nav links to fit in better with the new flat style.
Yeah, that is an issue but I don't think I'm gonna touch it in this PR. But it's definitely worth opening an issue for.

Also I think I'm gonna need some help with these failing tests – are the failing tests just brittle (and I should update them) or should I actually try to make them pass?  That's an integration test; if you made any changes to the CSS selectors it could easily break the spec and require that we update it.
From a quick look-over, it seems like you reworked how the flash messages are displayed? That would explain those tests failing. I'm hoping to dig into this over the weekend, I'll have more detailed feedback then. Hope that helps!

@squidgetx New navbar hover effect now!

damn that new navbar animation looks so good.
Other things:

Sign in email/password fields are really long?
Alignment on the signin page is kinda weird

Random notes as I click around:

The navbar is the full width, not limited to the container max width. This makes the "Sign In" button lie outside of the nominal view, so it took me a second to find it.
I agree w/ @squidgetx, the login form fields are way too long, we should shrink the width of that form. Also, the buttons don't line up with the form labels.
After adding an item to the cart from the catalog, the "Add to Cart" button loses its button styling and just becomes a link. This must have something to do with the JS we're running on cart updates.
The late fee cell in the equipment model show view (/equipment_models/:id) is kinda narrow given the font size used in the "Details" table (/equipment_models/:id#details). Since we're including the units in the cell (i.e. "$xxx.xx / day"), the "/ day" tends to run into a second line. Maybe we want to include the units in the heading (i.e. "Late Fee / day")?
It actually looks like all of the forms are wider than they used to be (I checked out the new equipment object form, for reference). Are we missing a CSS override for form_horizontal?

As a side note, the "Back to List" link under the form is pretty easy to miss (/equipment_models/:id/equipment_objects/new)

It also takes you to the nested equipment object index (/equipment_models/:id/equipment_objects), not to your original location (/equipment_models/:id).

Some of the links at the bottom of the equipment model show view nested equipment object index are no longer buttons, namely the "New [Category Name]" and "View All Equipment Items" links.
Why is there a "Show Deactivated Items" link at the bottom of the equipment model show view nested equipment object index linking to the equipment object index? Did our partials get mixed up (i.e. the _table.html.erb partial in particular)?
The application settings form is a bit messed up, mostly the boolean fields (checkout permissions and renewals). It's possible that they were just structurally different and we didn't notice until now.
The report start and end date field labels are a bit small, we might want to kick the font size up a bit.
The reservation edit form (/reservations/:id/edit) is pretty messed up, maybe it thinks it should be a form_horizontal?
The markdown syntax guide modal is misaligned - on the reservations edit form it ends up being off the left side of the page.
The TOS field on the user profile edit form (/users/:id/edit) is messed up... maybe it's a boolean field thing?
The checkout (and checkin) receipt pages (/reservations/checkout/:id) are wayyy too narrow - we should definitely widen them (this was an issue before the upgrade, but while we're messing w/ views... :-P).
The fixed position cart issue that @squidgetx mentioned is really annoying - I'll open up a new issue for that and hopefully we can get it in v5.2.0.

Overall it looks great, I really like the new flat-ness :-). I haven't looked at all through the code itself yet, I'll hopefully get to that in the next few days. Great work!

So I agree with most of your feedback, but some of it is out of scope for this (already monstrous) PR. We should be careful not to let this turn into a master-UI-redesign PR, because that was never the intent. There happens to have been a minor UI-redesign as a result of completing the Bootstrap upgrade (and I did redesign a few things), but I'm not going to do redesign anything else in this PR.

The navbar is the full width, not limited to the container max width. This makes the "Sign In" button lie outside of the nominal view, so it took me a second to find it.

That was an intentional design choice – the navbar was too cramped at fixed width. It'll just take some getting used to. :smile:

Some of the links at the bottom of the equipment model show view nested equipment object index are no longer buttons, namely the "New [Category Name]" and "View All Equipment Items" links.

Done! (But they were never buttons.)

After adding an item to the cart from the catalog, the "Add to Cart" button loses its button styling and just becomes a link. This must have something to do with the JS we're running on cart updates.

Done! (It was hard to write a comprehensive enough regex to catch all of these :confused:)

The late fee cell in the equipment model show view (/equipment_models/:id) is kinda narrow given the font size used in the "Details" table (/equipment_models/:id#details). Since we're including the units in the cell (i.e. "$xxx.xx / day"), the "/ day" tends to run into a second line. Maybe we want to include the units in the heading (i.e. "Late Fee / day")?

Done!

I agree w/ @squidgetx, the login form fields are way too long, we should shrink the width of that form. Also, the buttons don't line up with the form labels.
Hmm, yeah the button alignment isn't right. I'll take a look at that.

It actually looks like all of the forms are wider than they used to be (I checked out the new equipment object form, for reference). Are we missing a CSS override for form_horizontal?

They are – it's actually a fundamental change in how Bootstrap's forms work. Form inputs for everything but inline forms are width: 100%; by default, and you control their width with the grid. I can make them less wide, but they will all be equal width still.

As a side note, the "Back to List" link under the form is pretty easy to miss (/equipment_models/:id/equipment_objects/new)
It also takes you to the nested equipment object index (/equipment_models/:id/equipment_objects), not to your original location (/equipment_models/:id).

I agree, but definitely out of scope.

Why is there a "Show Deactivated Items" link at the bottom of the equipment model show view nested equipment object index linking to the equipment object index? Did our partials get mixed up (i.e. the _table.html.erb partial in particular)?

Huh, I'm not sure what's going on here. I'll take a look.

The application settings form is a bit messed up, mostly the boolean fields (checkout permissions and renewals). It's possible that they were just structurally different and we didn't notice until now.
...
The TOS field on the user profile edit form (/users/:id/edit) is messed up... maybe it's a boolean field thing?

Yeah, it is some kind of boolean input thing, but interestingly, only in Firefox (which is why I didn't catch it oops :sheep:). I'll take a look.

The report start and end date field labels are a bit small, we might want to kick the font size up a bit.

Eh, out of scope I think.

The reservation edit form (/reservations/:id/edit) is pretty messed up, maybe it thinks it should be a form_horizontal?

Hahaha wow, there's always one – totally missed this view. I'm on it.

The checkout (and checkin) receipt pages (/reservations/checkout/:id) are wayyy too narrow - we should definitely widen them (this was an issue before the upgrade, but while we're messing w/ views... :-P).

Definitely out of scope.

The markdown syntax guide modal is misaligned - on the reservations edit form it ends up being off the left side of the page.

Yeah... this was a really annoying bug. Apparently modals don't like the new grid system, so we'd have to restructure the whole thing.

The fixed position cart issue that @squidgetx mentioned is really annoying - I'll open up a new issue for that and hopefully we can get it in v5.2.0.

Hmmm I might be able to do something about it in here. We'll see.

Quick work! I'll review the changes locally tonight. I didn't mean for you to deal with all of my comments, btw, it was more of a brain dump as I traversed the views of the site looking for issues for the first time in a while. I'll spin out the out-of-scope comments into new issues later.
In terms of form width, I'd consider adding another column worth of padding to either side to shrink them a bit; they're just a little awkwardly wide at full size. Mobile-optimizing this whole app would be a mess.
In terms of the modal issues, is that something you're still working on? I think it's in-scope for this PR since it's a regression due to the upgrade.
Let me know when it's ready to be re-reviewed, but again, great work!

Hmmm, so I'm considering replacing Bootstrap's Affix plugin which I introduced in this PR with jQuery.sticky, the original library we were using. Even though Affix has a cleaner API and emits more events, it has introduced some display bugs I can't fix easily. If there are any flashes displayed, the cart becomes fixed offset from the top by the height of the flashes:

It also sort of freaks out when it hits the bottom offset value (aka the footer). None of these were issues with jQuery.sticky, even though I'd rather not use a library with that little support when we could use Affix. Affix also required a lot more styling and config to work, uh, even this poorly. So I'm not sure – maybe this is just user error. :grin:

What if we made the flashes narrower so they only fit in the catalog space? Then the cart wouldn't be pushed down by the flashes (I assume it has something to do with the original position of the element?).

I should be able to finish this this weekend.

@orenyk @squidgetx This is ready for review again. :astonished:
The only thing I haven't done is swap out Bootstrap.Affix for jQuery.Sticky – I'm still not sure.

App settings ; most of the checkboxes are fixed except for the last one (force users to accept TOS again?)
I still think the login form fieds are too wide =/

Ditto to @squidgetx's first and last comments, but I'm actually ok with the login form width. It's not ideal but given how the view is structured it's fine (and consistent with the rest of the forms on the site). Other comments:

The new announcements form (/announcements/new) is messed up, forgot to check it last time.
The blackout edit form (/blackouts/:id/edit) is also messed up, but not the new blackout form (/blackouts/new), strangely
The checkboxes for recurring blackouts (/blackouts/new_recurring) are block elements - any chance we can make them inline?
Sidenote The print styling of reservations is pretty horrific (e.g. if you click the "Print this page" button) - should we fix this?
The hover effect for the checkout and checkin procedures is kinda iffy, the pointy part looks a little pixel-y to me:

This seems to break checkout / checkin procedures

Steps to replicate: 1) create reservation for model with checkout procedures, 2) check out item (and check off all procedures), and 3) reservation notes indicate that procedures were not performed
Sidernote The notes for checking in an item after checking it out with missed procedures appears to be missing a leading "\n" as the header appears inside the bulleted list of missed procedures.

I'm out of time for tonight, I'll continue walking through it and then will look at the code, hopefully tomorrow.

Note: the last point is broken on master, I'll open up a new issue.

Some more notes:

The contact form is broken (and not on master):

The import users (/import_users/import) and import equipment (/import_equipment/import) forms don't match the styling of the other forms in the app.

I think I've gone through all the views at this point, it's finally time to look at the code changes :-P.

Another comment, the padding at the top of the "Cart" part of the sidebar seems little much:

I tested out moving the flash partial to the content and content_with_sidebar partials to deal with our sticky / affix issue (so the flash only spans the width of the content div) and it seems acceptable to me, what do you think?

Found another issue - search results. First of all (not in scope for this PR), we're still getting duplicate results for equipment models (#933). Second, if you have minimal or no search results, and you click on the search field two times, the footer freaks out and jumps up on the page:

Also, category results are kinda ugly, particularly the padding in that box.

The new user modal form is a bit messed up as well:

I'm not sure if this is a regression or I just wasn't paying attention before, but the "Create Reservation" page buttons are messed up:

Ok, after hours of code review I think I've gone over everything. There are/were a bunch of inline comments (as well as a few general comments for issues I found while reviewing), but I think that once everything's been discussed / addressed this will be good to go. Whew.

GO GO GO!

:+1:

:shipit:

@squidgetx @orenyk I'm running into weird stuff trying to squash this. If there were ever a PR to not squash this might be it, if only because there may actually be subcommits we want to revert since this thing is so big. Can I just merge it?

Ha, how the mighty have fallen :stuck_out_tongue:. I think it's fine in this case, @squidgetx any objections?

nah lets go


ISDK-2169, ISDK-2653: Simulate incoming CallKit calls in the background

This PR makes simulation of incoming calls in VideoCallKitQuickstart more powerful by adopting the UserNotifications framework. This allows the following inbound scenarios to be tested:

Application is active.
Application is inactive and foregrounded.
Application is background.

An accept/decline UI is presented. The accept action does not require foregrounding the app, allowing it to be delivered in the background. The default action foregrounds the app.
Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Ready for review, but needs to be tested on iOS 10.0 before merging.

Here is the notification UI. You can:

Tap to accept. Reports an outbound Call and connects to the Room.
Swipe and "Simulate VoIP Push". Raises an inbound invite to join the Room.
Decline. Dismisses the notification.

When the application is active, the app automatically presents the invite by reporting it as an incoming Call to CallKit.

@piyushtank I have addressed feedback, and fixed iOS 10 support so this is ready for final review. Thank you!

Minor comment regarding the notification UI, it seems like we could also add a labelled "Accept" action, since the default tap to accept isn't as obvious once you've swiped down.


Assembly-CSharp.dll crashes my server

Hey,
I installed Smod2.dll and Assembly-CSharp.dll on my server and started it. I noticed that since the installation the server crashes at startup. I tried it and noticed that it is due to the CSharp.dll assembly. So I reinstalled the original file on the server and then it worked again. The files are installed correctly. So it is due to the assembly CSharp.dll that my server keeps crashing. Why is this file crashing my server? I have my server on a Linux Ubuntu 18.04 system.
Console:
https://i.ibb.co/HTvbXZf/Inked2021-02-05-15-39-14-Termius-STRATO-LI.jpg
Logs:
https://pastebin.com/XMtK8C9v - 2021-02-05_15_39_09_SCP_log_7777.txt
https://pastebin.com/yVAy4F3p - 2021-02-05_15_39_09_MA_log_7777.txt
Thank you.

Smod is not currently updated for the current game versions.


Pyright unable to find venv/pythonPath with WSL2

Hello,
I am using SublimeText 4, installed on windows, to open a WSL2 project.
All my venvs are in the proj root dir, in the folder .venv (this means that python is at .venv/bin/python).
My pyright settings are the following:
{
    "settings": {
        "python.venvPath": "./.venv",
        "python.pythonPath": "./.venv/bin/python",
    }
}

When I open the log panel, what I see is this:
LSP-pyright: Pyright language server 1.1.222 starting
LSP-pyright: Server root directory: C:\Users\davide.melli\AppData\Local\Sublime Text\Package Storage\LSP-pyright\14.17.6\language-server\node_modules\pyright/dist/
LSP-pyright: No configuration file found.
LSP-pyright: No pyproject.toml file found.
LSP-pyright: Setting pythonPath for service "leaf-radio": "\Ubuntu-20.04\home\didi\leaf\leaf-radio\.venv\bin\python"
LSP-pyright: venvPath \Ubuntu-20.04\home\didi\leaf\leaf-radio\.venv is not a valid directory.
LSP-pyright: stubPath \Ubuntu-20.04\home\didi\leaf\leaf-radio\typings is not a valid directory.
LSP-pyright: Unable to get Python version from interpreter
LSP-pyright: Assuming Python platform Windows
LSP-pyright: Searching for source files
LSP-pyright: File or directory "\Ubuntu-20.04\home\didi\leaf\leaf-radio" does not exist.
LSP-pyright: No source files found.

Is there any way to make Pyright aware of the WSL mount and resolve the paths correctly?

Yep, to open it i do /mnt/c/Program\ Files/Sublime\ Text/subl.exe .
About the console output, i get nothing:

Yep, to open it i do /mnt/c/Program\ Files/Sublime\ Text/subl.exe .
About the console output, i get nothing:

What if you open a py file?

Oh, sorry, so silly of me. Here the output with a .py file:

I guess WSL2 path handling is broken (did that ever work?). I would suggest you open the folder from ST4 started in a regular Windows environment.

If i open ST4, then menu->file->Open Folder->search a WSL folder from the explorer I get the same exact behaviour.

I can reproduce this but I didn't work under WSL2.

Fwiw, I tried this with VSCode and Pyright/Pylance emits the same error. Something like
LSP-pyright: venvPath \Ubuntu-20.04\home\didi\leaf\leaf-radio\.venv is not a valid directory.
LSP-pyright: stubPath \Ubuntu-20.04\home\didi\leaf\leaf-radio\typings is not a valid directory.

VSCode has this extension https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-wsl which allows you to seamlessy use the linux filesystem.
Here some logs from the LSP:
[Info  - 11:56:02 AM] (12839) Pylance language server 2022.4.0 (pyright 67ee16be) starting
[Info  - 11:56:02 AM] (12839) Server root directory: /home/didi/.vscode-server/extensions/ms-python.vscode-pylance-2022.4.0/dist
[Info  - 11:56:02 AM] (12839) No configuration file found.
[Info  - 11:56:02 AM] (12839) pyproject.toml file found at /home/didi/leaf/leaf-radio.
[Info  - 11:56:02 AM] (12839) Setting pythonPath for service "leaf-radio": "/home/didi/leaf/leaf-radio/.venv/bin/python"
[Info  - 11:56:02 AM] (12839) Loading pyproject.toml file at /home/didi/leaf/leaf-radio/pyproject.toml
[Error - 11:56:02 AM] (12839) Pyproject file "/home/didi/leaf/leaf-radio/pyproject.toml" is missing "[tool.pyright]" section.
[Warn  - 11:56:02 AM] (12839) stubPath /home/didi/leaf/leaf-radio/typings is not a valid directory.
[Info  - 11:56:02 AM] (12839) Assuming Python version 3.8
[Info  - 11:56:02 AM] (12839) Assuming Python platform Linux
[Info  - 11:56:02 AM] (12839) Search paths for /home/didi/leaf/leaf-radio
[Info  - 11:56:02 AM] (12839)   /home/didi/.vscode-server/extensions/ms-python.vscode-pylance-2022.4.0/dist/typeshed-fallback/stdlib
[Info  - 11:56:02 AM] (12839)   /home/didi/leaf/leaf-radio
[Info  - 11:56:02 AM] (12839)   /home/didi/leaf/leaf-radio/typings
[Info  - 11:56:02 AM] (12839)   /home/didi/.vscode-server/extensions/ms-python.vscode-pylance-2022.4.0/dist/typeshed-fallback/stubs/...
[Info  - 11:56:02 AM] (12839)   /home/didi/.vscode-server/extensions/ms-python.vscode-pylance-2022.4.0/dist/bundled/stubs
[Info  - 11:56:02 AM] (12839)   /home/didi/.pyenv/versions/3.8.12/lib/python3.8
[Info  - 11:56:02 AM] (12839)   /home/didi/.pyenv/versions/3.8.12/lib/python3.8/lib-dynload
[Info  - 11:56:02 AM] (12839)   /home/didi/leaf/leaf-radio/.venv/lib/python3.8/site-packages
[Info  - 11:56:02 AM] (12839) Adding fs watcher for library directories:
 /home/didi/.pyenv/versions/3.8.12/lib/python3.8
/home/didi/.pyenv/versions/3.8.12/lib/python3.8/lib-dynload
/home/didi/leaf/leaf-radio/.venv/lib/python3.8/site-packages
[Info  - 11:56:02 AM] (12839) Adding fs watcher for directories:
 /home/didi/leaf/leaf-radio

VSCode has this extension marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-wsl which allows you to seamlessy use the linux filesystem.

Not open sourced so we have no idea what it does.

as the docs says:

With VS Code and the Remote - WSL extension combined, VS Code’s UI runs on Windows, and all your commands, extensions, and even the terminal, run on Linux. You get the full VS Code experience, including autocomplete and debugging, powered by the tools and compilers installed on Linux.

I think this should happen in every non-VSCode editors. Maybe there is already a solution in them (neovim, etc...).

I am quite sure that the Intellij suite has a similar solution, but unfortunately not open source!

\\wsl.localhost\<distro>\... is the path windows applications can use to access WSL2 filesystem. It doesn't matter whether they are executed directly from Windows or from within WSL2.
A path translation algorithm just needs to be aware of all possible combinations of running [ Linux | Windows ] App in [ WSL | Windows ] accessing [ Linux | Windows ] paths.
Some inspiration may be taken from https://github.com/SublimeText/WslBuild/blob/ebf26d251d5aeab99f515fca3c5947314c5841aa/plugin.py#L260-L276. Those lines have also found their way into GitGutter, to enable it to use Git for Windows to diff files located within WSL2 filesystem.


Fixed Dynamo mocking STS bug

Fixes #1095
Also removed some older STS related logic from Dynamo that wasn't relevant.

Coverage increased (+0.02%) to 93.493% when pulling b9ae73c63712ae01565c69c2761bbf07fac246d0 on mikegrima:fixStsDynamo into f052757259d5dec48cdfdaa34a6a7a20f22a186e on spulec:master.

Great fix, @mikegrima! Thanks for figuring this out and fixing it.


Flag for booshers

Just like the flags for BLOPS and CYNO, I would like to see a flag for Booshers, triggered if the pilot is known to fly command destroyers. This would be useful for Rorqual pilots, for example.

This would be nice to have. It requires some work in the backend but once that is done we easily could add Flags for all ship types.
But before that we would like to implement the asynchronous fetching for the frontend (#15 ) and that will probably still take a while since me and @Crypta-Eve are pretty busy atm.


Compilation fails when using latest versions of Visual Studio VS : 16.6.1 or VS 16.6.2

Compile command:
cmake --build. --config RelWithDebInfo
Error messages:

...\source\repos\clickhouse-odbc\driver\utils\type_parser.cpp: fatal error C1001: Internal compiler error. [C:\Users\admin\source\repos\clickhouse-odbc\build\driver\test\clickhouse-odbc-
ut.vcxproj]
LINK: fatal error LNK1000: Internal error during IMAGE :: BuildImage [C:\Users\admin\source\repos\clickhouse-odbc\build\driver\test\clickhouse-odbc-ut.vcxproj]

...\source\repos\clickhouse-odbc\driver\utils\type_parser.cpp: fatal error C1001: Internal compiler error. [C:\Users\admin\source\repos\clickhouse-odbc\build\driver\test\clickhouse-odbcw-ut.vcxproj]
LINK: fatal error LNK1000: Internal error during IMAGE :: BuildImage [C:\Users\admin\source\repos\clickhouse-odbc\build\driver\test\clickhouse-odbcw-ut.vcxproj]

See the attached file for more details.
In order to avoid getting bored, I reported the problem to MS support:
https://developercommunity.visualstudio.com/content/problem/1077431/fatal-error-c1001-internal-compiler-error-xxxxvcxp.html
Unfortunately, they ask me in return more information that I cannot produce.
(see url above)
LOG.txt

I wasn't able to reproduce it using VS 16.6.2.
You could try repairing your Visual Studio installation, just to make sure nothing got broken during recent upgrade: https://docs.microsoft.com/en-us/visualstudio/install/repair-visual-studio?view=vs-2019
After that, please try clean checkout, cmake configure, build.

We are responsible for the problem.
After repairing our VS version 16.6.2 and having re-extracted the application from github,
its compilation has been successfully executed.
It therefore appears that we are the culprits.
Indeed, in order to trace the transformation of the requests we added a logger, by depositing two files (SimpleLog.h, SimpleLog.cpp) in the directory :
.. \ source \ repos \ clickhouse-odbc \ driver \ escaping
The escape_sequences.cpp file has been modified accordingly.
This being done, the problem resurfaced.
In the case of the version of VS 16.5.4, this practice was not a problem.
It is likely that the filing of the files is no longer sufficient and that the new files should be declared
in the application CMakeList.txt.
We need to improve our knowledge of Visual Studio and its compilation environment.
Sorry for bothering you


Question: How can I disable Admin-Authentification

My application runs in an private network and all users are authentificated with Gitlab-Authentification.
I would like to use the existing authentification also for Admin. Is it possible?

Yes, it's possible.
First you need to define a user provider according to adding-custom-user-providers,  then change the auth config:
// config/admin.php

    'auth' => [
        'guards' => [
            'admin' => [
                'driver' => 'session',
                'provider' => 'admin',
            ]
        ],

        'providers' => [
            'admin' => [
                'driver' => 'custom', // specify the custom provider you defined
            ]
        ],
    ],

Added a document custom-authentication


Prettierrc File & Re-minifcation

I added a new .prettierrc file to ensure that the styles will get styled the same across different user's. This means there were a few minor styling changes, but I tried to mimic the styles you had already. Happy to help as needed.

Just rebased to remove commits for PR 18


🐛 The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.

What were you trying to do?
react-native run-android
Reproduceable Code
No response
What happened instead?
The Android Gradle plugin supports only kotlin-android-extensions Gradle plugin version 1.6.20 and higher.
The following dependencies do not satisfy the required version:
project ':react-native-vision-camera' -> org.jetbrains.kotlin:kotlin-gradle-plugin:1.5.30
Relevant log output
No response
Device
emulator
VisionCamera Version
^2.15.3
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

same issue here

"react-native": "0.71.1",

same issue here

I have the same issue using
"react-native-vision-camera": "^2.15.4"
"react-native": "0.71.1"
any idea how to solve it?

I managed to make it work with @dcangulo solution, on path
node_modules/react-native-vision-camera/android/gradle.properties
change VisionCamera_kotlinVersion=1.5.30 to VisionCamera_kotlinVersion=1.6.20
but I don't know why this change was not included on version 2.15.4, probably need to test this solution on previous versions of react-native?

This works for me.

The solution described here avoids changing lib files. Both work for me. Thanks!

Yes its worked for me after updating node_modules/react-native-vision-camera/android/gradle.properties
change VisionCamera_kotlinVersion=1.5.30 to VisionCamera_kotlinVersion=1.6.20 and after that I got  a dialouge of install Android  SDK build-tools 33 after installing them its worked

Hey! I've rewritten the entire Android codebase of VisionCamera from CameraX to Camera2 in the efforts of ✨ VisionCamera V3.
I just now completed the Camera2 rewrite and I believe the core structure is running, but there might be some edge cases to iron out. Can you try and test the PR #1674 for me to see if you can still reproduce this issue here?
Here's an instruction on how you can test that: https://github.com/mrousavy/react-native-vision-camera/pull/1674#issuecomment-1684104217
If the issue cannot be reproduced with that version/PR anymore, then hoorayy, I fixed it! 🎉
Otherwise please let me know and I'll keep this issue open to keep track of it.
Thank you!

@mrousavy, thanks for the PR! Very impressive work with Camera2. I'll try it again shortly, but, having recently tried v3 on our app, it seems that as long as kotlin-android-extensions is present, the project won't compile with kotlinVersion set to 1.8 or higher. I'll try with the lib pointing to the PR though and post here what I find 👍

Ah sorry maybe I can remove that dependency? Not sure if I need it 🤔


Question about LSTM?

I tried the code with '--rnn_type lstm', and the training with model S2VTModel is nomal, but when I try to eval the results, I got the following error:
('vocab size is ', 16860)
('number of train videos: ', 6513)
('number of val videos: ', 497)
('number of test videos: ', 2990)
load feats from [u'data/feats/resnet152']
('max sequence length in data is', 28)
/usr/local/lib/python2.7/dist-packages/torch/nn/modules/rnn.py:38: UserWarning: dropout option adds dropout after all but last recurrent layer, so non-zero dropout expects num_layers greater than 1, but got dropout=0.5 and num_layers=1
"num_layers={}".format(dropout, num_layers))
Traceback (most recent call last):
File "eval.py", line 148, in
main(opt, i)
File "eval.py", line 75, in main
dataset = VideoDataset(opt, "val")
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 721, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for S2VTAttModel:
While copying the parameter named "encoder.rnn.weight_hh_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "encoder.rnn.weight_ih_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "encoder.rnn.bias_ih_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "encoder.rnn.bias_hh_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "decoder.rnn.weight_hh_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "decoder.rnn.weight_ih_l0", whose dimensions in the model are torch.Size([1536, 1024]) and whose dimensions in the checkpoint are torch.Size([2048, 1024]).
While copying the parameter named "decoder.rnn.bias_ih_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "decoder.rnn.bias_hh_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
I would like to find out why it happens, and could you help me? Thanks.

I tried the code with '--rnn_type lstm', and the training with model S2VTModel is nomal, but when I try to eval the results, I got the following error:
('vocab size is ', 16860)
('number of train videos: ', 6513)
('number of val videos: ', 497)
('number of test videos: ', 2990)
load feats from [u'data/feats/resnet152']
('max sequence length in data is', 28)
/usr/local/lib/python2.7/dist-packages/torch/nn/modules/rnn.py:38: UserWarning: dropout option adds dropout after all but last recurrent layer, so non-zero dropout expects num_layers greater than 1, but got dropout=0.5 and num_layers=1
"num_layers={}".format(dropout, num_layers))
Traceback (most recent call last):
File "eval.py", line 148, in
main(opt, i)
File "eval.py", line 75, in main
dataset = VideoDataset(opt, "val")
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 721, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for S2VTAttModel:
While copying the parameter named "encoder.rnn.weight_hh_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "encoder.rnn.weight_ih_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "encoder.rnn.bias_ih_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "encoder.rnn.bias_hh_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "decoder.rnn.weight_hh_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "decoder.rnn.weight_ih_l0", whose dimensions in the model are torch.Size([1536, 1024]) and whose dimensions in the checkpoint are torch.Size([2048, 1024]).
While copying the parameter named "decoder.rnn.bias_ih_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "decoder.rnn.bias_hh_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
I would like to find out why it happens, and could you help me? Thanks.

Sorry for my mistake...the error information should be:
('vocab size is ', 16860)
('number of train videos: ', 6513)
('number of val videos: ', 497)
('number of test videos: ', 2990)
load feats from [u'data/feats/resnet152']
('max sequence length in data is', 28)
/usr/local/lib/python2.7/dist-packages/torch/nn/modules/rnn.py:38: UserWarning: dropout option adds dropout after all but last recurrent layer, so non-zero dropout expects num_layers greater than 1, but got dropout=0.5 and num_layers=1
"num_layers={}".format(dropout, num_layers))
Traceback (most recent call last):
File "eval.py", line 148, in
main(opt, i)
File "eval.py", line 75, in main
dataset = VideoDataset(opt, "val")
File "/usr/local/lib/python2.7/dist-packages/torch/nn/modules/module.py", line 721, in load_state_dict
self.class.name, "\n\t".join(error_msgs)))
RuntimeError: Error(s) in loading state_dict for S2VTModel:
While copying the parameter named "rnn1.weight_hh_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "rnn1.weight_ih_l0", whose dimensions in the model are torch.Size([1536, 4096]) and whose dimensions in the checkpoint are torch.Size([2048, 4096]).
While copying the parameter named "rnn1.bias_ih_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "rnn1.bias_hh_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "rnn2.weight_hh_l0", whose dimensions in the model are torch.Size([1536, 512]) and whose dimensions in the checkpoint are torch.Size([2048, 512]).
While copying the parameter named "rnn2.weight_ih_l0", whose dimensions in the model are torch.Size([1536, 1024]) and whose dimensions in the checkpoint are torch.Size([2048, 1024]).
While copying the parameter named "rnn2.bias_ih_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).
While copying the parameter named "rnn2.bias_hh_l0", whose dimensions in the model are torch.Size([1536]) and whose dimensions in the checkpoint are torch.Size([2048]).

I met the same problem, how can I solve it, can you help me, thank you.

I also encountered the same problem. How can I solve it


Agr wordpress integration

Wordpress - AGR portal integration

@sibyl229, I have committed the suggested changes - Also added the /eslint-disable no-unused-vars/ comment to disable the error generated from not using nextState variable in componentWillUpdate(nextProps, nextState).
Thanks

@LucyHut looks good!


Add Notificaton Section

Describe the bug
Add the notification fragment.
Endpoint: https://open-event-api.herokuapp.com/#notifications
Would you like to work on the issue?

Yes

@iamareebjamal  Can I work on it?

This issue is resolved. Please close this


Change ownership for Catalog and Permission framework

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

Note to posterity: team membership are now updated to reflect these as well.


error when loading a model

I fixed main.rs to refer to &args.model_path, but now I get a new error:
Could not load model: invalid utf-8 sequence of 1 bytes from index 0

I created these models using the tools in llama.cpp, but they don't seem to be compatible?

Can you show the sequence of commands you ran? I was able to get it working with my 4-bit quantized 7B.

Same for me. I've been able to load all the f16 and q4 versions (those that fit in my RAM, at least), the same ones I was using with llama.cpp.
A quick thing to try, beyond sharing the commands you executed, would be to check if the same model loads well under llama.cpp. Then we could confirm a bug here.

I am having the same problem,  the error seems to happen on https://github.com/setzer22/llama-rs/blob/266be12476c8a64ee98188761db6248137655201/llama-rs/src/llama.rs#L175 during iteration 132 out of 32000 for me...
I'm running cargo run --release -- -m ../llama.cpp/models/7B/ggml-model-q4_0.bin -p "They tell me" and the model works perfectly with the cpp implementation.
The previous tokens being loaded are the lowercase alphabet, {, |, }, ~, \u{7f}, and then the crash

Thanks for the more detailed report @mwbryant!
I guess it makes sense, C++ doesn't really care about invalid UTF-8, on the C++ side a string is just a byte array. So the code is probably silently ignoring the issue. So first, we should fix it, because this is not an irrecoverable error. What needs to be done there, is the following:

Make read-string return a recognizable error on invalid UTF-8.
When parsing words (and only there), use a match statement to capture that error, and replace the word with something like "�".
When that happens, also print a warning. It shouldn't happen. I'm able to load that same model just fine.

Then, it would be good to figure out how that invalid utf8 got in there in the first place. Can you run a sha256sum on your model file (the same one you used in your example, 7B/q4, and share it here, to ensure the file is not somehow slightly corrupt?
Then, some platform information might also help diagnose this. What OS / version / whatever(?) are you on? :smile:

I opened a PR with that solution and the program now works perfectly on my machine!  Warning appears on all tokens from 131-258, any one with a working model should be able to print those out and see what the tokens parse to on working machines and that might also solve the mystery.
I'm on Ubuntu 20.04 LTS
sha256sum ../../llama.cpp/models/7B/ggml-model-q4_0.bin  f495fa02a0b5ef265e1864d9680eede7fd23a60b0a2f93edba8091e2a4ca68b9  ../../llama.cpp/models/7B/ggml-model-q4_0.bin
Rust version: rustc 1.67.0 (fc594f156 2023-01-24)
Anything else you want to know?

Ok, that's odd. All those tokens print to me as �. I tried printing the bytes as hex and they're all exactly EF BF BD, which is exactly the replacement character, i.e. �, not something else https://apps.timwhitlock.info/unicode/inspect?s=�.
It's likely that the script I used to convert the model into ggml weights (from llama.cpp) already replaced those unprintable characters, but it didn't for you for some reason.
The hash for my model is not the same: 558a38f1d9ae25859f52df134d1103c8a2ff337afd64e8b1b8e5c06d7081daff
Anyway, thanks a lot for the PR, I'll have a look! :smile:

Ah so maybe a minor different in the python package version or something impossible to detect.  Well the hotfix then should never effect the end user behavior so I think it's safe to forget it for now then :)


Categorizing tests and refactor

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
153

Relevant Lines:
153

💛  - Coveralls


Remove usage of int method within SQLite interface TimestampType

int(...) is used several times within the convert method of TimestampType. This, however, leads to the unintended consequence of trimming off leading 0s from any string segment. All usages of int(...) should be replaced with alternative solutions.

By way of example, notice the milliseconds in the original (057350) and the converted (573500)
'original': '2020-03-25T19:34:05.057350Z
'converted': datetime.datetime(2020, 3, 25, 19, 34, 5, 573500)

This was the only discussion I could find even remotely about this problem: python: subtraction of timestamps fails due to omitted leading zeros in microsec
And it lead me to the discovery that the timedelta class has a milliseconds argument I could use, which allowed me to break up the microseconds into two chunks of 3 and then add them to the timestamp to keep the correct value from the parsed string datetime.
search:

python datetime leading zeros microseconds
python datetime leading zeros microseconds site:stackoverflow.com
values of right of decimal
python datetime microseconds with leading zeros


E-book versions

It would be good to have somewhat better releases for the next version. E.g.:

make a PDF version and tag that as "the" release DOI
attach other e-book versions and the source tree as dependent DOIs (you can do this in zenodo)

This way the DOI actually links to something useful for readers rather than the zipped repository, and we are in control of the PDF and e-book versions (rather than have these be dispersed by 3rd parties), so we can track downloads and such.

I can only agree.

This is how the americans did it: calibre 3.10.0 [https://calibre-ebook.com]


print --help to stdout

I would like to be able to use the command
$ butane --help | grep files-dir

instead of
$ butane --help 2>&1 | grep files-dir
  -d, --files-dir string   allow embedding local files from this directory
$

I think  that most Linux command-line tools  print --help to stdout.
Currently butane prints --helpto stderr.

We're using the default behavior of clap, our argument parser.  To stay consistent with the rest of the ecosystem, I expect we'll continue to do so.  If you'd like, you could file a clap bug.

I found this example from clap-rs where they have an assert that --help should give a non-empty output on stdout:
https://github.com/clap-rs/clap/blob/286fda0b4a243e19d73a254d2dc17c794f4320e5/tests/examples.rs#L47
Then  I found
https://github.com/coreos/butane/blob/339c96e5808144e4c081631134195726eb3c1c0e/internal/main.go#L70
and this
https://github.com/coreos/butane/blob/339c96e5808144e4c081631134195726eb3c1c0e/internal/main.go#L56
It seems the stderr is set in the Butane code.
(Disclaimer: I don't know rust, so it's a bit of guessing)

Blah, I had my projects confused.  This isn't Rust and we don't use clap here.

Thanks for reporting this.  Fix in https://github.com/coreos/butane/pull/268.


Comment here for issues you want me to mention during ur analysis

@pigriver123 @brianqiu @changsiyao @boyinggong
So far I have analysis issues with run time and identifying regions to look at

closing


iFrame content when created Via GWT, is not resizing until clicked.

In an application designed in Liferay, we have an embedded iFrame with the source from other domain. The iFrame  is not resizing itself for content for the first page, where few elements are added by GWT. The iFrame surely resized when clicked on it. For all the inner pages (pages following the first page), it's working perfectly.
To solve it, I tried calling parentIFrame.size(), after the last component in GWT is added, the problem was not solved.
Any suggestions to solve the issue, will be of great help. Thanks.

This was first written to work with an old Cisco product based on LifeRay.
I would suggest wrapping the call to size in a setTimeout set to zero.
Their is an example in the troubleshooting section of the docs. In that
case to work around an issue with FireFox. But it is also the first thing I
would try here.
On Tuesday, 9 August 2016, Deepesh-Shavik<EMAIL_ADDRESS>wrote:

In an application designed in Liferay, we have an embedded iFrame with the
source from other domain. The iFrame is not resizing itself for content for
the first page, where few elements are added by GWT. The iFrame surely
resized when clicked on it. For all the inner pages (pages following the
first page), it's working perfectly.
To solve it, I tried calling parentIFrame.size(), after the last component
in GWT is added, the problem was not solved.
Any suggestions to solve the issue, will be of great help. Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davidjbradshaw/iframe-resizer/issues/392, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAkHEinoBgzlZOpW-lvsym1PBLEdTp27ks5qeAXAgaJpZM4JftjY
.

--
Sent from my iPhone.


how to convert 9:16 vertical image to 16:9 with blur background

I have an Image with aspect ratio of 9:16, I want resize it to an 16:9 image. But instead of a plain color letterboxing, I want the original image to be the letterboxing.
example of what I am trying to achieve:

Please see #632

Please see #632

thanks, but it seems that overlayWith function is remove from latest version ?. I can't find docs for it.

You can use the composite operation for this (note that it accepts an array of images).

import path from 'path'
import sharp from 'sharp'

const resize = async (imageInput, width, height, overlayWidth, overlayHeight, quality, fit, outputDir, outputFname) => {

    const image = sharp(imageInput).resize()
    const overylayImage = sharp(imageInput).resize()

    const resize = image.resize(width, height, { fit, background: {r:1,g:0,b:0,alpha:0.5} })

    const blurOverlayResize = overylayImage.resize(overlayWidth, overlayHeight, {fit: 'cover'}).blur(5)

    try {
        resize
            .png({quality, progressive: true})
            .toBuffer((err, buffer) => {
                if (err) throw new Error(err)

                blurOverlayResize
                    .jpeg({quality, progressive: true})
                    .composite([{input: buffer}])
                    .toFile(path.join(outputDir, outputFname + '.jpg'))
            })
    } catch (error) {
        throw new Error('Error resizing image \n' + error)
    }
}

resize('1.jpg', 204, 340, 500, 340, 80, 'cover', 'C:\\Users\\Jer\\Desktop', 'ss')