fix subheaders in README

My OCD kicked in and I just had to.

The very first header in the README still needs a space between the # and the text.


users can choose optimizers used in GP inference methods

The GP module for now uses lbfgs (first-order method) and newton method (second method).
Indeed, many nonlinear optimizers  (eg, Conjugate Gradient ) can be used in the module.
Make the GP inference framework more flexible so that users can choose a specific optimizer.

@karlnapf
I will work on it at the end of this year.

this issue  https://github.com/shogun-toolbox/shogun/issues/2853 has addressed this issue.
I close this


Request for assistance: Tests on AuxPoW branch

For anyone who wants to jump in on Dogecoin, I would love assistance resolving the test failures on this branch: https://github.com/dogecoin/dogecoin/pull/1974

Is there an appropriate label that could be given to this issue? It would help to stand out more amongst all the new issues today.

@tuckbick  I agree, but it seems this is fast paced and that’s old news. next major issue will come within 1 hour of this post. But the real fud is, we are all On it ! And all over it

For anyone who wants to jump in on Dogecoin, I would love assistance resolving the test failures on this branch: #1974

I would love to jump into this...let me know how

I want to help, explain what I need to do

If there is anything a normal everyday random person can help with.... I'm your girl.

I am an army service veteran and I want in on
The dogecoin project

^^^ with these people as well. how can I help.

I’m not sure if this is a true original developer of the project he is not listed.

Just FYI, if you want to help with this specific task, you're going to need at least SOME experience with coding and/or software testing.

🖐🏻would like to help also 😊

I am a software engineer, having good coding experience. I would like to help, if you provide bit insight on this.

how do we branch out AuxPoW branch from the remote ?

We can fetch, and then create a local copy of it.
On Wed, 26 May 2021, 14:52 Hean-Loong, @.***> wrote:

how do we branch out AuxPoW branch from the remote ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dogecoin/dogecoin/issues/2010#issuecomment-848613829,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLAS4BTCYYA2CTGT23KLFDTPS4U3ANCNFSM45N4D6GA
.

Okay I get it. It is already in the 1.21-dev branch

So are you developer of Dogecoin?
On Wed, 26 May 2021, 15:37 Hean-Loong, @.***> wrote:

Okay I get it. It is already in the 1.21-dev branch
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dogecoin/dogecoin/issues/2010#issuecomment-848643980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADLAS4FJSJJEAGEHYNZ63RTTPTB63ANCNFSM45N4D6GA
.

I will love to help if you provide little bit of information

So are you developer of Dogecoin?
…
On Wed, 26 May 2021, 15:37 Hean-Loong, @.***> wrote: Okay I get it. It is already in the 1.21-dev branch — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2010 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLAS4FJSJJEAGEHYNZ63RTTPTB63ANCNFSM45N4D6GA .

No I am yet to help out

I have good coding skills and have 7 years of working experience as a software engineer.
Want to contribute my skill in the Doge development as well

@rnicoll https://github.com/rnicoll/dogecoin/pull/18

I'm down here, how can we help, I can setup testnet nodes for you, I can run it multiple OS as your request. and allow you to see through them for your test purpose.

Sorry I get too many GitHub notifications to follow, so don't manage to track individual posts. With @mmicael1 's help all of the tests now pass, thank you.
Also apologies, I had intended to give enough detail for people to jump in on the code. It sounds like there was confusion on how to identify specific problems? For future reference, if you check out PR 1974 (there's a guide to this at https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally), and run ci/test_run_all.sh it runs the full suite of tests that Travis runs.
I think all of those now pass (I'm just re-checking the full suite as I type this), but obviously if anyone does find a failure and can raise a pull request to fix it, that would very much be appreciated. Certainly the test suite covers a number of operating systems and I'm only really testing on Ubuntu and CentOS right now, so verifying it works on others would be great.

If anyone wants a good place to learn, I've basically sketched out the steps needed for https://github.com/dogecoin/dogecoin/issues/2246 in the ticket (I hope), and hopefully that's enough for someone to complete that ticket.


Sparse interpolation optimizations

Two changes here.
The first adds a single housekeep to the compute_interp_weights function, which reduces some in-process memory usage.
The second replaces a cartesian product using itertools, with one based solely on numpy. On my sample data, this took 3.27ms instead of 846ms, and used ~13.5MiB ram instead of ~126.5MiB.
Limitations of the new function are that all the points must be of the same datatype, which I think is irrelevant in our usage? (Correct me if I'm wrong...)

:+1: if you fix the pep8 problems.

Tests passed, rebasing.

Don't merge this, please. I've got some more results on time use and memory use that I'd like to analyse.

Don't merge this, please. I've got some more results on time use and memory use that I'd like to analyse.

Shame. I could happily have merged this, and then merged another PR....

Nudge!

I've got some more results on time use and memory use that I'd like to analyse.

Is this change sometimes detrimental? Or is just that it doesn't always help?

I've got some more results on time use and memory use that I'd like to analyse.

Is this change sometimes detrimental? Or is just that it doesn't always help?

@mo-g - it'd be really useful to understand how this approach doesn't help (or if it does!)

From internal note.. 09/Jul/15 15:49

Used Tehuti to look at three branches of Iris from a perspective of memory and processing time:

https://github.com/mo-g/iris/tree/master-pre-sparse-interpolation
https://github.com/mo-g/iris/tree/sparse-unoptimized
https://github.com/mo-g/iris/tree/sparse-interpolation-optimizations

The branch 'sparse-interpolation-optimizations' is a set of two changes I added based on profiling-
by-hand with psutil to analyse different lines of code for memory usage and speed. The first change
removes the assignment of a variable that is only used once. The second replaces an iterative
cartesian product with one based on meshing. It was intended that these would mitigate some of the
memory costs of the sparse interpolation; however they are not a consistent improvement - as was
shown when using Tehuti to profile them. As such, the pull request has been held for now.

Ran some Tehuti tests that @dkillick wrote a while back.
* regrid (tiny, to rotated)
* regrid from limited area (large - tiny)
* regrid (tiny, from rotated)
* rotated regrid (tiny)
* rotated regrid (tiny - large)
* regrid from limited area to rotated (large, to rotated)
* simple regrid (tiny)
* rotated regrid (large)
* vertical levels regrid (large, from rotated)
* regrid from rotated limited area (large, from rotated)
* regrid to limited area (tiny - large)
* regrid from limited area (tiny - large)
* vertical levels rotated regrid (large)
* regrid from limited area (large, nan extrap)
* simple regrid (large)
* regrid (large, to rotated)
* vertical levels regrid (tiny - tiny)
* vertical levels regrid to limited area (large)
* regrid from limited area (large - large)
* regrid to limited area (large - large)
* regrid (large, from rotated)
* regrid to limited area (tiny, from rotated)
* regrid from limited area (tiny - tiny)
* rotated regrid to limited area (tiny - tiny)
* vertical levels regrid from limited area (large)
* regrid to limited area (tiny - tiny)
* regrid to limited area (tiny, to rotated)
* vertical levels regrid (large - large)
* vertical levels regrid (large, to rotated)
* regrid to limited area (large - tiny)
* regrid from limited area (large, mask extrap)
* rotated regrid from limited area (large)

Attached image shows the percentage change (multiplied by the actual size of the optimized output, to give some weighting) in peak memory usage against time for each of the above; plus counts of how many are in each of the four 'bins'.
I think this encourages merging?
@rhattersley @pelson?

@mo-g - thanks for the graph. :+1:
So... mostly small <5% time changes, but a few more significant changes. It'd be great it you could list these 3 or 4 tests.
Similarly, for the memory use, is there a pattern to which tests result in a non-trivial increase?

Here are the absolute values (I had the script printing these before I got funky with MPL.)
Tim Increase: regrid from limited area (large - tiny) 0.67% 0.00s
Tim Increase: regrid from limited area to rotated (large, to rotated) 0.28% 0.00s
Mem Increase: simple regrid (tiny) 0.07% 0.33MB
Tim Increase: simple regrid (tiny) 2.87% 0.00s
Mem Increase: vertical levels regrid (large, from rotated) 0.74% 13.93MB
Tim Increase: regrid to limited area (tiny - large) 1.28% 0.00s
Tim Increase: regrid from limited area (tiny - large) 0.20% 0.00s
Mem Increase: vertical levels rotated regrid (large) 0.74% 13.93MB
Mem Increase: vertical levels regrid to limited area (large) 0.74% 13.93MB
Tim Increase: vertical levels regrid to limited area (large) 9.91% 0.12s
Tim Increase: regrid from limited area (large - large) 0.25% 0.00s
Tim Increase: regrid to limited area (tiny, from rotated) 0.24% 0.00s
Tim Increase: rotated regrid to limited area (tiny - tiny) 4.60% 0.01s
Mem Increase: vertical levels regrid from limited area (large) 0.74% 13.93MB
Mem Increase: vertical levels regrid (large - large) 0.74% 13.93MB
Mem Increase: vertical levels regrid (large, to rotated) 0.74% 13.93MB

Here are all the >5% changes:
Tim Increase: regrid (tiny, to rotated) -36.% -0.00s
Tim Increase: rotated regrid (tiny) -7.8% -0.00s
Tim Increase: rotated regrid (tiny - large) -21.% -0.32s
Tim Increase: rotated regrid (large) -5.5% -0.03s
Tim Increase: vertical levels regrid (large, from rotated) -7.0% -0.15s
Tim Increase: vertical levels regrid to limited area (large) 9.91% 0.12s
Tim Increase: vertical levels regrid from limited area (large) -5.7% -0.06s

Tim Increase: vertical levels regrid to limited area (large) 9.91% 0.12s

Shame, I was hoping this would be from a small regrid, not a non-trivial "global @ (2000, 1800) -> regional (900, 600)". :unamused:

Looks like this would benefit from a better understanding of what the memory & runtime trends are with respect to source & destination resolutions. @mo-g - since you're not in a position to do that investigation right now I don't mind if you want to close this PR. @pelson - any preference on what to do next?

Think we need to close this one as has been on pause quite some time.


Node Header and Footer

How do you suggest altering the NodeHeader?
Also, it would be great if we could add a NodeFooter.

When you say how do you alter it, are you asking how we should alter it through the config file? Or where in the code it should be edited?

Is there a way as a user of the library?  I can find the code location
I want to add some affordances for activity/state (I’m doing a task runner). Maybe a spinner in the header or a progress bar in the footer. I think you are planning other things for the header now that I think of it, so I may add an option for a footer.
Then I need to signal the node from node data somehow. Will look into that today.

Ah interesting, so as the user of the library, you'd like the ability to customize the NodeHeader component?

I've seen this slot strategy used before. Would something along these lines meet your needs?

Yeah, having slots would be great.

The problem with a custom node is that you can't just tweak it. You can't use the input or output or inputGroups, as all of that is private inside node-types.tsx

Oh, and maybe a good use for nodeKind (more than a theme now!)

I'll get to work on a design for slots.
Yeah, that was an intentional design decision though. For the example color picker that's in the storybook, I needed to customize where and how the handle for the color picker worked. I also created a Monaco editor component in another private project and have the flexibility to design the entire thing is quite nice.
One option we could look at is a reverse slots mechanism. Where the built in components are provided via slots to the props of the custom component which you can then use, or ignore. We could have slots for

Inputs
OutputHandles
NodeHeader
NodeFooter

and then you could just use whichever slots you want. I'm not really sure how styling would work between them. But it's something we could experiment with.

Sounds good!

See https://github.com/clarkmcc/ngraph/pull/35


internal(pkg): Consolidate babel/runtime and rc-utils

rc-utils duplicates breaks antd due to context singleton mismatches.

Codecov Report

Merging #2093 (ca843ae) into master (e281ab2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2093   +/-   ##
=======================================
  Coverage   98.48%   98.48%
=======================================
  Files         102      102
  Lines        1918     1918
  Branches      404      404
=======================================
  Hits         1889     1889
  Misses         13       13
  Partials       16       16

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


[WIP] types/swarm: move network attachments to TaskSpec

Networks are a propery of the Task, not the service. Without this
change, it will make it harder to do pluggable orchestrators in the
future that aren't bound to a service.
Please see https://github.com/docker/swarmkit/pull/1205 for details.
cc @thaJeztah @aluzzardi
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

LGTM

This is WIP - we have to merge the corresponding changes in engine API first

@aluzzardi this is the engine-API repo, so, ready to merge?

LGTM 🐹
@stevvooe @aaronlehmann @aluzzardi feel free to merge when time is best 👼

We are not going through with this.

Re-opening to go along with work in docker/swarmkit#1205.
DO NOT MERGE THIS. We'll have to make a few changes to deal with backwards compatibility.

@stevvooe docker/swarkit#1205 is closed, what is the status for this one 👼 ?

@vdemeester I'm not sure. We definitely went away from that approach earlier but have resurrected it. This will need more work to reflect the compatibility changes.
@mrjana Are you working from this patch or do you have another one?

This can be close as it already taken care here: #375


No need to send ForceUnlock() in sendRelease()

We rely on lock maintainence loop to ensure
removal of stale locks.

Codecov Report

Merging #47 into master will increase coverage by 1.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   85.65%   86.78%   +1.13%
==========================================
  Files           3        3
  Lines         230      227       -3
==========================================
  Hits          197      197
+ Misses         27       25       -2
+ Partials        6        5       -1

Impacted Files
Coverage Δ

drwmutex.go
86.5% <100%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a9c59c...7c75f7b. Read the comment docs.


Pin error when call transferCNB()

In "Example" page, click "Run" button.
other func works fine, but for transferCNB(), pop up error:
Transfer 1 CNB to someone...
Error: IncorrectPin
Ended
I believe i put right  pin code (6 digits number)  below:
api.payment.transfer(assetID: cnb, opponentID: opponent, amount: "1", memo: "Hello", pin: pin, traceID: traceID)
Could you please kindly advise what's wrong?

This project is still under construction. Try the latest demo to see if that happens again.
The issue will be closed for now since I can't reproduce it. Feel free to reopen it if similar problem still exists, or access our developers group of Mixin ID<PHONE_NUMBER> for support.


InsertItem method not working

I have this problem locally but it turns out it is a problem on the demo website as well:
https://quill-mention.com/
Programmatically inserting mentions does not work. However, first using openMenu() or just first typing '@' does seem to trigger something that makes insertItem() work after the fact.

See issue #403 for fix


Android - HybridApp - Ecard -  Impossible to issue first card on a new account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.54-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/3272217
Issue reported by: Applause - Internal Team
Action Performed:
Precondition: new expensifail account. WS added (USD currency). Expensify card is enabled. VBA is added on Expensify card tab via ND application

Go to WS > Expensify card
Tap 'Issue card' > choose any card type
Proceed the flow to the end > tap 'Issue card'

Expected Result:
Card is added for the WS admin
Actual Result:
An error appears 'Oops... something went wrong and your request could not be completed. Please try again later.'
NOTE: admin can add Ecard via ND app (web. desk) first, delete it and then add via Hybrid app
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[x] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/5cbb6dfa-86f7-4f5b-813d-e04bc17600cc
View all open jobs on GitHub

@muttmuure  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 2

Looking tomorrow

Asking about this here: https://expensify.slack.com/archives/C05LX9D6E07/p1730725586749509?thread_ts=1728966082.429659&cid=C05LX9D6E07

Asked QA for more details here

@mountiny: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:("8d9b4061db4eca30-KBP")+AND+timestamp:[2024-10-28T12:25:23.029Z+TO+2024-10-28T14:25:23.029Z]&index=logs_expensify-030924
and right before that: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:("8d9b3ff5581bca30-KBP")+AND+timestamp:[2024-10-28T12:25:07.108Z+TO+2024-10-28T14:25:07.108Z]&index=logs_expensify-030924
[ExpensifyCard] User_Utils - Failed to provision Expensify Card Company Expensify\Libs\Error\ExpError - e4d2bfc0-4573-4720-8062-6ac15323b185 ~~ domain: 'expensify-policy7a208df74deb1151.exfy' bankAccountID: '6348868' domainName: 'expensify-policy7a208df74deb1151.exfy' jsonCode: '401' message: '401 Missing balance verification' exceptionJsonCode: '666' exceptionUserMessage: 'Failed to provision domain' exceptionMessage: 'Failed to provision domain' exceptionFile: '/git/releases/expensify.com/15e3807/lib/BankAccountAPI.php' exceptionLine: '1712' exceptionCode: '666'

Given the below, I'm dropping the HybridApp distinction from the title. It's not exclusively a HybridApp bug, so the title is confusing.

If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y

@koko57 we have been working on awaiting for a successful domain provisioning before we can issue a card. Those changes are not deployed yet, right? It should fix this case too as we would not let the user attempt issuing card without successfully provisioning

yep, it was deployed to staging in 9.0.56-0 https://github.com/Expensify/App/pull/51407#issuecomment-2449649825 and here we have 9.0.54-2 in the description. So it needs to be retested

Asked for a retest here

Now bug is not reproducible , but with a new account it is impossible to issue card without relogin. The flow leads  to Concierge chat. card issued after relogin to account.
https://github.com/user-attachments/assets/eb074270-69d5-4a14-b3ea-5c096f858a32
https://github.com/user-attachments/assets/6678ae41-b62a-47da-84d6-7e1590eb083c

Nice yeah that looks expected because the account got flagged so we had to manually review it.
Although I am not sure if its expected it would start working after simply re-logging in

I think we can close this one then because the verification page is expected


Updated to react 0.9.0 with source map support

The modified JSXTransformer-0.9.0.js is now required, as it exposes the transformCode method which helps with source mapping...

If you want 1:1 source mapping, have a look at this repository: https://github.com/podio/requirejs-react-jsx
When compiling with r.js, it will use node with react-tools, and in development it will inline the source maps (https://github.com/podio/requirejs-react-jsx/commit/aacd926ce955a75ca22499552e104b311ec70acf)


Apple acceptance

We're looking at shaka-player-embedded as a potential solution to providing a single set of transcodings/renditions under a single drm umbrella (i.e. dash with fmp4, and widevine for drm).   One hurdle is clearly IOS/apple, and the requirement to use hls/fairplay for streaming video (shaka-player-embedded would clearly solve this from a technical perspective, when combined with the widevine CDM).
Before embarking on a journey that turns out to be frivolous and potentially damaging (i.e. our app gets banned from apple's app store due to non-compliance with the hls/fairplay requirement), has anyone run this solution past the folks at apple?  Do we know if their requirement for hls/fairplay is purely of a technical nature, or if they are happy to allow transmux on the device from dash to hls (with a subsequent custom CDM stage for widevine drm).   Or is their requirement based on non-technical motives that are likely to get implementations using shaka-player-embedded banned?
We'd absolutely love to adopt a solution like this but are clearly concerned about the potential for negative consequences.
Any feedback would be greatly appreciated.
Thanks for your time and great work.

I am not a lawyer, nor can I speak for Apple.  But to quote their public App Store Review Guidelines doc as of 2019-02-05:

2.5.7 Video streaming content over a cellular network longer than 10 minutes must use HTTP Live Streaming and include a baseline 192 kbps HTTP Live stream.

I don't see anything about Fairplay at all.  And I know firsthand that Widevine partners have shipped embedded Widevine CDMs in iOS apps before.
The requirement for streaming HLS only seems to apply to a cell connection, so hypothetically you could still use DASH over WiFi.  And you can definitely choose to stream HLS with Shaka Player Embedded, both over cell and WiFi, either in the clear or with Widevine.
Widevine support for Shaka Player Embedded is not available yet, pending Widevine's release of an updated iOS CDM.  When that is available (separately, under contract with Widevine), we will remove the "beta" label and tag a v1.0 release of Shaka Player Embedded.  The Widevine iOS CDM will come with instructions for integration with Shaka Player Embedded, which we aim to make completely painless.
Does this help?

Absolutely - thanks for the quick reply Joey.   It's probably wise for us to persist with our current "dual packaging approach" (i.e. HLS/Fairplay for the Apple eco-system and Dash/Widevine for everything else).   Single transcode/encryption/manifest/drm etc. is our ultimate goal (I'm sure there are plenty of other folks with similar hopes)........ so we're excited to see where this goes.
We'll integrate for testing purposes at the appropriate time and try to provide constructive feedback!
Again, thanks for the great work.

Happy to help.  When Widevine support is available, we'll send out announcements both here on github and on our mailing list.  Thanks!


Play sound new notif

var audio = new Audio();
audio.preload = 'auto';
audio.src = '/path';
audio.play();
const notification = new Notification(...
I used this one https://freesound.org/people/Thoribass/sounds/253595/
Convert to mp3

Nice one @alexey13 and good idea.. what happens if you receive a lot of messages at once? Do you debounce this call or something?

You mean user send to another user messages one by one? No, not debounce. Interesting scenario, need to test it in real life. When I use chat on a desktop and hear the sound (whatsup desktop using sound) I focus on the chat window, if I do not want to hear the sound I just turn it off in that window of a browser.

But I think debounce nice idea. For example 1 sound in 3 seconds

Nice.. well maybe with a slightly shorter sound and checking to see if we are already playing a sound we could make this work.


TableClient.submitTransaction does not use custom httpClient

Package Name: @azure/data-tables
Package Version: 13.0.0
Operating system: all
[x] nodejs

version:  14

[ ] browser

name/version:

[x] typescript

version: 4

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
When calling TableClient.submitTransaction, if the TableClient was constructed with a custom httpClient (passed in as part of CommonClientOptions), that custom httpClient is not used.
It looks like the problem comes down to this:

In submitTransaction an InternalTableTransaction is constructed with a new TableClient which does not inherit any of the options, including a custom httpClient, that this was constructed with.
To Reproduce
Steps to reproduce the behavior:

Create a TableClient with a custom httpClient
Try to submit a transaction

Expected behavior
The custom httpClient is used.
Screenshots
See above.
Additional context
N/A

Closing due to duplication of bug.


Code not in docker image

Hi @tzutalin ,
First, really awsome job!
And I think maybe you didn't put your code in to the docker image, what you did with dockerfile is just downloaded corresponding python packages, and constructed for your own enviroment, and you have your code on your computer, together with the code on your PC and the docker image, you make it works. Am I right?
I am working on a PC that I have no right to download python and construct the develop environment, what I can do is build the envrionment in docker image, the image includes OS and software.


Unable to Show local image file:///tmp/someimage.jpg

First, sorry about to post a question.
The issue is that I'm not able to show local images via <img src="file:///path/to/someimage.jpg ....
I posted the question on Stack Overflow 9 days ago:

https://stackoverflow.com/questions/62741325/show-local-image-file-tmp-someimage-jpg (+50 bounty)

Is someone so kind to give me instructions about how can I show on electron window picture files from local storage.
Thanks!!

I'm having the same problem. I was able to use your workaround (converting image to base64), but a big problem for me is when trying to load a video file.
If the video file is big (~500mb) then converting to a base64 string will just take too long.
When loading a video/image (like: src="file:///path/to/video.mp4") the chrome console shows this error:

For blazor atleast, putting the video inside the wwwroot folder will allow it to load normally, but that isn't a real possibility for me.

Anything happening with this?

@ctrl-alt-d @GregorBiswanger I think this is a bug


Placement of LLR changed - can we change it back?

Hi,
The placement of the Resource title of a LLR has changed to the middle column above the abstract field. See screenshot below and link:

Link: http://landportal.info/library/resources/urban-land-markets-east-africa
Can we change that back to on the left side (taking full width of the screen) below the resource type (which is in a lighter font) and above the thumbnail image? You can see an example in the web structure document (basically the same as it was before).
The subtitle (not there in this example) should be below the title, in a slightly smaller font and similar to LLR type, in a 'light' format.
Thanks!

Oh, and the subtitle should have the same color, just plain black :)

Today is working properly on production


date-profile-field-#19936

https://github.com/zulip/zulip/issues/19936
I have managed to prevent the saving of a wrong manually input date.

@timabbott I have tried squashing but I do not know how to run the rebase while within nano. As I keep researching, I will give a comment for my thought process

Can you clean up the commit history for this pull request?  Thanks!
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Yes I will. Thank you
On Mon, 8 Nov 2021, 23:36 Tim Abbott, @.***> wrote:

Can you clean up the commit history for this pull request? Thanks!
Check out the Zulip commit message guidelines for more details:
https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/19956#issuecomment-963551753, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AS4KQNUO6UYEXQDUKMD6OSLULAYDZANCNFSM5F4MHRFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hello @timabbott  I have tried to rebase the commits and I am still facing a few difficulties.


[Feature] Additional Node Red node that connects to the Azure IoT Hub and can receive all messages sent to it

It's great that this project has modernised the use of Azure IoT devices in NodeRed but it would be great if a new node was available that can receive all messages sent to the Azure IoT Hub.
There is a similar capability here https://flows.nodered.org/node/node-red-contrib-azure-iot-hub (see the Azure IoT Hub Receiver node) but it's become quite outdated now.
Thanks!

It's great that this project has modernised the use of Azure IoT devices in NodeRed but it would be great if a new node was available that can receive all messages sent to the Azure IoT Hub.
There is a similar capability here https://flows.nodered.org/node/node-red-contrib-azure-iot-hub (see the Azure IoT Hub Receiver node) but it's become quite outdated now.
Thanks!

@DavidDeeds I have no intention to build that Node Red node. The approach your refer to is a server side node and requires server side authentication. This node is intended as a device node only. Don't want to mix up sever side and device side nodes into one.


Add Policy to STSAssumeRoleOptions

Allow the policy to be specified when invoking the STS AssumeRole API.
Note that the STS AssumeRole implementation in minio already supports assigning a policy.  This change simply provide a way in which to invoke it.  Also note this has been tested locally and works as expected with different types of policies.

@harshavardhana , anything else I need to do here?


Update Dependencies to Move DeepSpeed to CUDA Extras

Moving DeepSpeed requirement into CUDA extras, and making sure package installation is not required OOTB.

Tested that pip install instructlab-training -> pip install instructlab-training[cuda] path still works as expected, and that when DeepSpeed is not installed, default FSDP training path still works as expected.

NOTE: Also capping Accelerate for now, as the recently released 1.1.x includes breaking changes that need to be resolved before it can be updated.


Anchor Links

PR for Anchor Links components.
This drops a hidden div with a heading where an anchor link component has been placed. The rest of the renderring is picked up javascript (https://github.com/Manifesto-Digital/hee-prototypes/pull/27).

Hi @Raq-HEE - Great work 👍
Could you take a look at the following and let me know what you think ?

Both AnchorLink Id and Text seem to include text from tags containing nhsuk-u-visually-hidden class. Could we exclude them if possible ?
The following heading snippet:  Non-urgent advice:
  test title2

creates the following AnchorLink currently:Non-urgent advice:
test title2

Also, could we avoid
 tag on the text if possible ?
AnchorLinks currently seem to be created for Right Hand Content Blocks as well and not sure if this may confuse the visitor as the jumped position would show both Main and Right Hand Content Blocks.
I think the AnchorLink for the title of the Related Content section might just be enough and AnchorLinks for each of Related Content Cards may not be required.

Thank you!

* Both AnchorLink Id and Text seem to include text from tags containing `nhsuk-u-visually-hidden` class. Could we exclude them if possible ?

Added fix in main.js

* Also, could we avoid `<br>` tag on the text if possible ?

Added fix in main.js

* AnchorLinks currently seem to be created for Right Hand Content Blocks as well and not sure if this may confuse the visitor as the jumped position would show both Main and Right Hand Content Blocks.

Added fix in main.js. As a quick fix, I'm checking if the heading appears in right hand side by checking the class on it's ancestors. Let me know if we need to be more elegant, e.g. adding a more relevant class, or id.

* I think the AnchorLink for the title of the Related Content section might just be enough and AnchorLinks for each of Related Content Cards may not be required.

Added fix in main.js

* The following heading snippet:
  ```
    <span class="nhsuk-u-visually-hidden">Non-urgent advice:</span>
    test title2
  ```

  creates the following AnchorLink currently:
  ```
  <a href="#non-urgenttest title23">Non-urgent advice:<br>test title2</a>
  ```

I wasn't sure about how to recreate this one. Would excluding nhsuk-u-visually-hidden also resolve this?

* Both AnchorLink Id and Text seem to include text from tags containing `nhsuk-u-visually-hidden` class. Could we exclude them if possible ?

Added fix in main.js

Thanks @Raq-HEE - Could still see tags with nhsuk-u-visually-hidden classes are being picked up (though they are not displaying due to the nhsuk-u-visually-hidden class, so may be it's Okay ?)

* The following heading snippet:

Non-urgent advice:
test title2

creates the following AnchorLink currently:
Non-urgent advice:
test title2

I wasn't sure about how to recreate this one. Would excluding nhsuk-u-visually-hidden also resolve this?

An example of this could be found on http://localhost:8080/site/patient-and-public-information/introduction page on the local instance (test title2 StatementBlock). Thanks!

@Raq-HEE - Observed that the anchor links seem to include tags around the titles (e.g. CLA Licence Plus). Is it possible to strip them off ? (e.g. CLA Licence Plus & Copyright Act & ‘Library Privilege’ anchor links on  http://localhost:8080/site/patient-and-public-information/introduction on the local instance). Thanks!

Could still see tags with nhsuk-u-visually-hidden classes are being picked up

Were these in the console log? The log was printing the array of all headings before I did the filter. Have removed the console logging.

An example of this could be found on http://localhost:8080/site/patient-and-public-information/introduction page on the local instance (test title2 StatementBlock). Thanks!

Thanks, have added a fix in main.js

@Raq-HEE - Observed that the anchor links seem to include tags around the titles (e.g. CLA Licence Plus). Is it possible to strip them off ? (e.g. CLA Licence Plus & Copyright Act & ‘Library Privilege’ anchor links on http://localhost:8080/site/patient-and-public-information/introduction on the local instance). Thanks!

Thanks, Fixed in main.js


Test of creating issue

[x] To create first issue
[x] To see how it looks like
[ ] And just to understand how it looks like for others.

For example adding @carolynshin

Done


fix: crude allow interaction endpoint, domain verification request ping

Note: I am very novice with rust so this is very likely to be the non optimal way of fixing this issue.
Currently the application crashes if a domain verification request is sent to it (the interactions URL being added in the discord developer portal).
This fix crudely handles the error and attempts to de-serialize with a verification request before outright failing the JSON parse.

hey @yoroshikun, thanks a lot! Fortunately there is an easier fix by making the guild_id and application_id fields on Interaction optional the parsing is not failing any more. That's my bad I added them last minute and didn't check if they broke the verification ping. Should be fixed with 3f82705002269f72d9b39aa51ee2fa649061b33e


Question

Could you add:  Integrity, DEP, ASLR, CF Guard
Please ^^

Working on an improved version, first release coming soon :)

Working on an improved version, first release coming soon :)

any update :)


Fix logo render on some terminal backgrounds

Is your feature request related to a problem? Please describe.

The logo on many terminal backgrounds gets lost and looks broken. The gradient is too wide.
Describe the solution you'd like
Narrow the gradient range or remove it.

/bounty $20


FIX: add __color = 0xFFFFFF; to Stage new function

Because __color is initialized as 0 (because its not set) but __colorSplit and __colorString are both initialized as '0xFFFFFF',
setting  a stageColor to 0x0 in window tag or using stage.color will fail because in set_color (__color != value) will eval to true.
So __color will still be 0 but __colorSplit and __colorString will be 0xFF . You will end up having a white background.
Using any other color will work , but just not black.
This has probably just been an accidental line delete ;)

Perfect, thanks!


Update jsoniter-scala-core, ... to 2.2.2

Updates

com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-macros

from 2.2.1 to 2.2.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.plokhotnyuk.jsoniter-scala" } ]

labels: library-update, semver-patch

Superseded by https://github.com/coursier/coursier/pull/1709.


Designed and Added A New "Logo" and A New "Favicon"

Description
Hey @aditya-bhaumik @sk66641

issue fixes #561

I have

Design a new logo for the website
Design a new favicon and integrate across all pages of the website
Made it responsive

I have also added a "disco light" effect for the border of the image

@keyframes disco-border defines the animation, changing the border color at different stages.
animation: disco-border 1.5s linear infinite; applies the animation to the border, making it loop infinitely.

New Logo

Old logo vs New logo

Snapshots

Screen Record
https://github.com/user-attachments/assets/5e73b927-6692-49dd-81d6-150e989a966c
Responsive

New Favicon

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@sk66641 can the level increase? as I have designed two different logos and updated favicon in each page for consistency additionally adding a disco light effect to the website's logo ensuring it is responsive. However if not we can go with this too! Thank You. Pls Do let me know if you like the design of the logo and the favicon!

@MastanSayyad
liked it


Make document highlight mark whole className. Fix Microsoft/vscode#56354

Wow, that's a surprisingly easy fix. Thanks @octref !


Better documentation with docstrings

Closes https://github.com/Microsoft/knack/issues/8

I do call out the kwargs available in https://github.com/Microsoft/knack/blob/master/docs/arguments.md but I'll include them in code for intellisense for VS/IDE users.

What about pointing users to the doc page from the docstring instead of repeatedly calling out the kwargs everywhere?

@derekbekoe the main purpose of the docstrings (in my head when I created the issue) was for intellisense. Pointing someone to the docs is okay (assuming the docs are correct) but as a command author I think I would much rather see it in the intellisense.  I know I personally found it maddening when resource_id switched to kwargs and I had to have the code (or docs) open side-by-side to know what to put. It was made much less annoying when the kwargs were listed in the Intellisense.

@tjprescott How does my latest commit change look?

@derekbekoe looks good to me :)


Update: Adobe.CreativeCloud version <IP_ADDRESS>

Created by 🥟 Dumplings in workflow run #7339.

Log
Submitting WinGet manifests
Found existing pull requests:
Update: Adobe.CreativeCloud version <IP_ADDRESS> - https://github.com/microsoft/winget-pkgs/pull/167725
Update: Adobe.CreativeCloud version <IP_ADDRESS> - https://github.com/microsoft/winget-pkgs/pull/167718
Update: Adobe.CreativeCloud version <IP_ADDRESS> - https://github.com/microsoft/winget-pkgs/pull/167698
This task is configured to ignore existing pull requests
Creating manifests
Uploading manifests and making commits
Creating a pull request

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

(Automated response - build 887.)


MirrorMaker2 knowledgebase updates

What changed, and why it matters
Includes information on MirrorMaker 2 to be included in the documentation.
Topics include: Replication, Disaster Recovery, Knowledge base, migration, etc.

Hi @harshini-rangaswamy , could you please review this and check how the content is fitting the devportal framework?
Thanks!

@ftisiot thanks for your review and feedback, I've tried to address all of the feedback and made adjustments.

Hi @harshini-rangaswamy , could you please review this and check how the content is fitting the devportal framework?
Thanks!

@ftisiot - I have reviewed the content and it appears to be fitting well within the dev portal framework.

Please merge :D


Suggestion: add safeCSS for partials?

Hello,
I inline CSS in the head of my template like this:
<style>
  {{ partial "css-default.html" . }}

  {{ if not (eq .Section "") }}
    {{ partial "css-post.html" . }}
  {{ else }}
    {{ partial "css-page.html" . }}
  {{ end }}

  {{ partial "css-responsive.html" . }}
</style>

This triggers the ZgotmplZ value in the HTML code, caused by unsafe CSS content reached (docs). Using safeCSS, however, generates an error:
{{ partial "css-default.html" | safeCSS . }}

executing "theme/partials/head.html" at <safeCSS>: wrong num
ber of args for safeCSS: want 1 got 1 in theme/partials/head.html

Is it perhaps an idea to also allow safeCSS to work with partials?

You could try it would the correct syntax. The types are slightly incompatible, so you need to convert the partial result to a string, I guess:
{{ printf "%v" (partial "css-default.html" . ) | safeCSS  }}

Thanks Bep, that's insightful. With that code, it works.
<style>
  {{ printf "%v" (partial "css-default.html" . ) | safeCSS  }}

  {{ if not (eq .Section "") }}
    {{ printf "%v" (partial "css-post.html" . ) | safeCSS }}
  {{ else }}
    {{ printf "%v" (partial "css-page.html" . ) | safeCSS}}
  {{ end }}

  {{ printf "%v" (partial "css-responsive.html" . ) | safeCSS }}
</style>

As far as I'm concerned, this Github issue can be closed since it's already possible.


Misterious RangeError: Invalid count value: -1 error

On step 89 and 90 of the Pyramid generator there is this misterious error that appear, it can be confusing for campers.
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-introductory-javascript-by-building-a-pyramid-generator/step-90

Yep. I think reworking the lessons so we never leave the learner with broken code (or at least never unexplained broken code) is the way to go.

I'm not sure if it was even intended to have broken code, description is suggesting everything is working fine. Step 91 asks for two changes, one of which specifically makes this error appear (second change fixes the issue).

Yeah, it's a bit confusing. Probably not intentional, though. On 91 there's this:

When you do this, you may see a Range Error, because we've created another off-by-one error.

...but the only time I don't see the error is when I've followed all the instructions on step 91.

Yeah, it's a bit confusing. Probably not intentional, though. On 91 there's this:

When you do this, you may see a Range Error, because we've created another off-by-one error.

...but the only time I don't see the error is when I've followed all the instructions on step 91.

Is this not enough to clear up any doubts? Cuz after following the instructions in step 91, there's nothing mysterious about the error anymore.

I don't think so.
Step 89, where error is introduced, doesn't mention it. Neither does 90. It's only when you reach 91 that the error is mentioned and the text is

So you'll need to replace done here with rows.length + 1. When you do this, you may see a Range Error, because we've created another off-by-one error.

which is incorrect. Changing done to rows.length + 1 has no effect on the error. It's only the combination of that and adjusting the conditional that finally removes the error.
The main issue with this is that it breaks the feedback loop between learner's actions and the code's behaviour. Speaking for myself, everything gets harder when the results of my actions are essentially invisible. I know we run tests to check you re doing it right, but that's not really a substitute for them seeing how your actions impact the program.

So we should mention the error on Step 90 then?

Just for posterity, the steps got shifted.

Error is introduced by completing step 95
Error is resolved by completing step 96

What should be changed here:

Step 95 should:

Introduce and explain the error
Ask the campers to change the <= comparison to <

Step 96 should:

No longer ask campers to change the <= to <
Not mention that rows.length + 1 creates a RangeError ||it doesn't||


Skip congrats bot action on [ci] format commits

What kind of changes does this PR include?

Something else!

Description
#1199 added a CI task to automatically format our source code with Prettier after each commit merges into main. This PR adds a check to our congrats bot action so that when a [ci] format commit lands, we don’t congratulate the bot on Discord.

Aww... just when we were leaning into Fred K Bot, Official Mascot... 😂  LGTM!

😂 I was afraid everyone’s PRs IMMEDIATELY followed by a format commits could be a little passive aggressive.
congratsbot: WELL DONE 🎉
fredkbot: format 🤖


Registered js files is not cleared in error view.

What steps will reproduce the problem?
Register js in a view and throw Exception
<?php
/**
 * @var $this View
 */

$this->registerJsFile('/some.js');

throw new \Exception('I failed');
?>

Hallo

What is the expected result?
An error page without the registered js file - when using fx. Webpack the css is packed with the js in development mode and breaks the error page css with stacktrace when Yii is in development mode.
What do you get instead?
The js file is fetched when error page is loaded and css breaks the stacktrace view.
Additional info

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.1

Operating system
Debian

Would you like to submit a pull request fixing it?

Sure just give me some days :)


Format async closure

This PR

adds edition config option to specify which edition to use.
handles async closure by using syntax_pos::hygiene::set_default_edition (cc https://github.com/rust-lang/rust/issues/51888).

Close #2813.

Looks good, thanks!
We should add some documentation about the edition flag.


Text outline should not go over the text itself

We noticed some of our text was getting cutoff when we increased the outline.
The outline has been amazing, but for certain fonts, a large outline results in the outline being drawn over the text itself:

I'm not really sure how one would go about fixing this.
If I create "two text" objects, one that has no outline, the other with only outline, you can create the desired effect that the outline doesn't overwrite the text itself.

I added a "double shot" parameter to https://github.com/pygfx/pygfx/pull/774
so you can play with it.
python examples/feature_demo/text_align.py  --ref-glyph-size 48 --outline-thickness 0.3 --double-shot True


fix version number for safe_rcm

previously we had:
In [1]: import safe_rcm
In [2]: safe_rcm.__version__
Out[2]: '999'

thanks to this PR we have:
In [1]: import safe_rcm
In [2]: safe_rcm.__version__
Out[2]: '2024.2.1.dev6+g115d62a'

how are you able to install this with python<3.8? I thought this library was restricted to python>=3.10?
In general, though, any new version of xarray will only support >=3.9, which will soon be dropped as well. So in the near future, the scientific ecosystem (including numpy!) will require at least python=3.10.
If possible, I'd suggest to upgrade to at least 3.9 (or, better yet, 3.12).


Fix about 7 very minor typos in docs/

Thank you for your contribution!
But please read the CONTRIBUTING to have correct commit messages next time:
Sometimes it makes sense to prefix the commit message with the packagename (or docs folder) all lowercased ending with a colon. That is fine, but the rest of the rules above apply. So it is "tpl: Add emojify template func", not "tpl: add emojify template func.", and "docs: Document emoji", not "doc: document emoji."


Failing test case: ''|array{foo: int} if superfluous key exists

Found an issue where valinor does not appear to interpret a union with an empty string and array when the array being mapped contains a superfluous key. I was also able to reproduce this bug using string|array{foo:int}.

Thanks for the report! You're definitely lucky, people have been complaining for this kind of errors for a long time and I just decided to fix it with #493. 😊

Thanks for the report! You're definitely lucky, people have been complaining for this kind of errors for a long time and I just decided to fix it with #493. 😊

Very cool! 😎


Disable undefined behavior checks in transformValues()

This is failing the ubsan checks in Clang 17.

Use the macro in Platform.h to solve the windows issues, lgtm

Thanks, that fixed it!


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/22320

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/25383

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27756

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/27756

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29605

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/33003

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/35017

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/45518

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/48644

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82252

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/86876

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/89549

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/93703

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/110546

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114989

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/118351

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/119871

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120569


Use pug template inheritance

Additionally move the javascript code blocks to
the end of the html body, instead of the header.
This is generally good practice, but it also fixes
an issue with the cookie consent overlay due to
a html element not existing on the page at the time
of script execution.
Fixes remaining issue in #1569

hmm I think this broke IE support again maybe

nevermind, just a bit temperamental


allow bot for all changed files and update label regex

This PR makes bot (label and format) get all changed files when the number of files is larger than 100, and update label regex.
if the regex use some special character like \., |, or $, I will put the quote.
Also, add .github match into reg:ci-cd
The log of this bot:
https://github.com/yhmtsai/ginkgo/pull/4/checks?check_run_id=1646511807
The result:
https://github.com/yhmtsai/ginkgo/pull/4
The file used in that repo:
https://github.com/yhmtsai/ginkgo/blob/a0d711041c159483025e66b0e1ee83186f0e653e/.github/label.sh#L5

@upsj I move the helper function into bot-pr-base because it is related to pr.

@upsj I move the helper function into bot-pr-base because it is related to pr.

@yhmtsai Thanks! For some reason, I had thought that label doesn't use the base-pr script, but that is definitely the most appropriate place to put it.

@yhmtsai Thanks! For some reason, I had thought that label doesn't use the base-pr script, but that is definitely the most appropriate place to put it.


Retry on failure of ledger-deletion and avoid running callback in executor

Motivation

Right now, when cursor ledger deletion fails then broker doesn't retry
and if it is successfully deleted then broker should log it as info to help debugging into leak cursor ledger.
also delete-ledger callback doesn't process much so, it should not be run on executor to avoid context switch.
add ml-name into info log

Recently, we have seen large number of cursor ledger leaks with below behavior
eg:
Leaked Orphan-ledger: `5868811882`

00:00:12.215 [bookkeeper-ml-workers-49-1] INFO  o.a.b.mledger.impl.ManagedCursorImpl - [prop/cluster/ns/persistent/topic] Updated cursor cms.repl.prod2-gq1 with ledger id<PHONE_NUMBER> md-position=5867470268:0 rd-position=5867470268:1
:
00:28:23.221 [bookkeeper-ml-workers-47-1] INFO  o.a.b.mledger.impl.ManagedCursorImpl - [prop/cluster/ns/persistent/topic] Updated cursor cms.repl.prod2-gq1 with ledger id<PHONE_NUMBER> md-position=5868513467:0 rd-position=5868513467:1
:
00:52:31.135 [bookkeeper-ml-workers-48-1] INFO  o.a.b.mledger.impl.ManagedCursorImpl - [prop/cluster/ns/persistent/topic] Updated cursor cms.repl.prod2-gq1 with ledger id<PHONE_NUMBER> md-position=5869588859:1 rd-position=5869588859:2

[We don't see any logs after this, but this thread should have deleted previous cursor-ledger :<PHONE_NUMBER> but still it was leaking
So, with this PR, we can see info log once ledger is successfully deleted and can learn more about broker/BK behavior]
Result

it retries if cursor-ledger deletion fails and logs it on successful deletion.

retest this please

retest this please


Java: Move samples outside of the gapic artifact

Works together with: https://github.com/googleapis/artman/pull/624

Previous to this PR, generated gapics are put in [artman-output-path]/src/main/java/..., where [artman-output-path] is determined by artman, and looks like for example artman-output/java/gapic-google-cloud-language-v1. Since the entry point of gapic-generator is already within the gapic directory, generated samples have been entangled with gapics.

The companion PR changes [artman-output-path] to just artman-output/java, and in this PR, gapic-generator will figure out the correct name for the gapic directory. Therefore it's possible to put gapics in gapic-google-cloud-language-v1, and samples in sample-google-cloud-language-v1.

The change will make testing and shipping Java samples easier and less error-prone.

For More details see: https://docs.google.com/document/d/1XfuXoLQ8tePFtf77sDFxVUrq84m7b1JXXUQpbTXqYE0/edit
Note the Java tests will unavoidably fail due to changes in artman not committed.

PTAL @andreamlin @vam-google
FYI @googleapis/samplegen

Also @michaelbausor, do you think this change would by any chance break Ads packaging?

@hzyi-google I don't have access to the linked doc

Also - why is there such a massive change in the Java baseline?

The massive baseline change is caused by reordering of files. Because this PR changed the output path of a lot of files and baseline puts files in alphabetic order. For example,
gapic files: src/main/java/... -> gapic-google-cloud-library-v1/src/main/java...
sample files: samples/src/main/java/... -> sample-google-cloud-library-v1/src/main/java...
So all the samples will be moved up and precede the gapics.

Re Ads - I don't think so, but it will need to be tested for sure before we release a new g3artman that uses this update.

@hzyi-google Do you think we'll need anything similar in the other languages?

@vchudnov-g I don't think so. This should be specific to Java.

Updated both PRs as per https://github.com/googleapis/artman/pull/624#issuecomment-495818562.
PTAL

Friendly ping. @andreamlin @vam-google

Talked offline: this PR is no longer needed.


Method for removing runs from an Annotation Queue

Feature request
it would be extremely helpful for the SDK to have a method for deleting runs from an annotation queue. Something like "delete_run_from_annotation_queue(annotation_queue_id, run_id)"
Motivation
I need a way to be able to clear all runs in an annotation queue if I want to start fresh with providing feedback on a set of runs added automatically to the queue. I found the way to do it via REST api but via the sdk would be a lot more convenient

This doesn't look too hard, I'll submit a PR

Submitted, someone please take a look 🙂


Add auto github release workflow

Is your feature request related to a problem?
As part of OpenSearch releases, opensearch-build pushes a tag for the release commit.
But publishing a github release based on the tag is manual.
What solution would you like?
We've added this workflow[1] in OpenSearch which publishes github releases automatically when a tag is pushed.
Add this workflow to all repos releasing software in the project.
See example: https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/auto-release.yml
Example Release: https://github.com/opensearch-project/OpenSearch/releases/tag/2.5.0
[1] https://github.com/opensearch-project/opensearch-plugins/blob/main/WORKFLOWS.md#auto-github-releases

The feature is added in https://github.com/opensearch-project/observability/pull/1436

Looks like the workflow is failing: The notes are not in the right format.
https://github.com/opensearch-project/observability/actions/runs/4318116929/jobs/7536017277
Run ncipollo/release-action@v1
Error: Error undefined: ENOENT: no such file or directory, open 'release-notes/opensearch-observability.release-notes-test-release-automation.md'

i think it's expected, the failed action was triggered by tag test-release-automation, which is not a release tag. there's no clear pattern (e.g. v* like in ODFE) to match a release tag so currently all tags would trigger the workflow
cc: @Swiddis


Use official HTTP 401 Unauthorized message name

I personally appreciate the kicks and giggles that arise from the odd usage of this language, but it feels a bit weird to have this kind of message in what would potentially be production code.
In other words ... Rewording this can only be in the best of your project's interests ;)

Yeah, this class shouldn't be there at all. I guess it must have gotten in with the lambda re-write last year. It's removed now though.


Fix cascading deletion race condition in some tests

Fix a race condition in some tests. We delete a VM, which should cause k8s to delete a VMI and DV associated with this VM. In an abundance of caution, we also delete that same VMI and DV--only we didn't account for the fact that k8s could beat us to it.
Release note:
NONE

/cherry-pick release-0.30

/approve
/retest

Test failures are unrelated. Merging to improve test stability.


src/external/stb_image_resize2.h:2422:22: error: implicit declaration of function 'vld1q_f16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

Hi,
I am maintainer on FreeBSD and you have some problem on arm7
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279369

Please, before submitting a new issue verify and check:

[x ] I tested it on latest raylib version from master branch
[ x] I checked there is no similar issue already reported
[ x] I checked the documentation on the wiki
[ x] My code has no errors or misuse of raylib

Issue description
hi,
raylib on arm7 marked as broken
In file included from /wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/rtextures.c:216:
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2422:22: error: implicit declaration of function 'vld1q_f16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    float16x8_t in = vld1q_f16(input);
                     ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2422:17: error: initializing 'float16x8_t' (vector of 8 'float16_t' values) with an expression of incompatible type 'int'
    float16x8_t in = vld1q_f16(input);
                ^    ~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2423:27: error: implicit declaration of function 'vcvt_f32_f16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    vst1q_f32(output + 0, vcvt_f32_f16(vget_low_f16(in)));
                          ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2423:5: error: initializing 'float32x4_t' (vector of 4 'float32_t' values) with an expression of incompatible type 'int'
    vst1q_f32(output + 0, vcvt_f32_f16(vget_low_f16(in)));
    ^                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
7/usr/lib/clang/14.0.5/include/arm_neon.h:26839:15: note: expanded from macro 'vst1q_f32'
  float32x4_t __s1 = __p1; \
              ^      ~~~~
In file included from /wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/rtextures.c:216:
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2424:27: error: implicit declaration of function 'vcvt_f32_f16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    vst1q_f32(output + 4, vcvt_f32_f16(vget_high_f16(in)));
                          ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2424:5: error: initializing 'float32x4_t' (vector of 4 'float32_t' values) with an expression of incompatible type 'int'
    vst1q_f32(output + 4, vcvt_f32_f16(vget_high_f16(in)));
    ^                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/clang/14.0.5/include/arm_neon.h:26839:15: note: expanded from macro 'vst1q_f32'
  float32x4_t __s1 = __p1; \
              ^      ~~~~
In file included from /wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/rtextures.c:216:
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2429:24: error: implicit declaration of function 'vcvt_f16_f32' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    float16x4_t out0 = vcvt_f16_f32(vld1q_f32(input + 0));
                       ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2429:17: error: initializing 'float16x4_t' (vector of 4 'float16_t' values) with an expression of incompatible type 'int'
    float16x4_t out0 = vcvt_f16_f32(vld1q_f32(input + 0));
                ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2430:17: error: initializing 'float16x4_t' (vector of 4 'float16_t' values) with an expression of incompatible type 'int'
    float16x4_t out1 = vcvt_f16_f32(vld1q_f32(input + 4));
                ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2431:5: error: implicit declaration of function 'vst1q_f16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    vst1q_f16(output, vcombine_f16(out0, out1));
    ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2436:27: error: implicit declaration of function 'vcvt_f32_f16' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    return vgetq_lane_f32(vcvt_f32_f16(vdup_n_f16(h)), 0);
                          ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2436:12: error: initializing 'float32x4_t' (vector of 4 'float32_t' values) with an expression of incompatible type 'int'
    return vgetq_lane_f32(vcvt_f32_f16(vdup_n_f16(h)), 0);
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/clang/14.0.5/include/arm_neon.h:7788:15: note: expanded from macro 'vgetq_lane_f32'
  float32x4_t __s0 = __p0; \
              ^      ~~~~
In file included from /wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/rtextures.c:216:
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2441:26: error: implicit declaration of function 'vcvt_f16_f32' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    return vget_lane_f16(vcvt_f16_f32(vdupq_n_f32(f)), 0);
                         ^
/wrkdirs/usr/ports/devel/raylib/work/raylib-5.0/src/external/stb_image_resize2.h:2441:12: error: initializing 'float16x4_t' (vector of 4 'float16_t' values) with an expression of incompatible type 'int'
    return vget_lane_f16(vcvt_f16_f32(vdupq_n_f32(f)), 0);
           ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/clang/14.0.5/include/arm_neon.h:67449:15: note: expanded from macro 'vget_lane_f16'
  float16x4_t __s0_851 = __p0_851; \
              ^          ~~~~~~~~

Environment
Provide your Platform, Operating System, OpenGL version, GPU details where you experienced the issue.
https://pkg-status.freebsd.org/ampere1/data/132releng-armv7-quarterly/11fb4c5672a6/logs/raylib-5.0.log
Issue Screenshot
If possible, provide a screenshot that illustrates the issue. Usually an image is better than a thousand words.
Code Example

@Martinfx I'm afraid this issue belongs to an external library and it should be reported to the external library repo, not raylib one.


account deletion support

make an option for wiping everything associated with feels

include a feels export function

progress:

feels backup, which writes a tar.gz file with all entries
feels purging, which deletes all feels (and unpublishes public posts) but maintains account

also preparing for:

backup importing
deleting individual feels

done, to be pushed soon!


Convert ceph monitors to a statefulset

The ceph monitors require reliable IP addressing, they should be converted to a statefulset.

@intlabs Pete, since you may have been playing with this chart, we want to change the monitors over to a statefulset, and also, the ceph osd containers do not restart properly, on restart they crash with an auth error.  Have you hit or overcome this? I know you are working with Sebestian on an upstream chart as well but likely this is forthcoming some time in the future?

@alanmeadows, as we discussed yesterday I've moved the monitors over to statefulset in the work I've been doing to address this exact issue. My initial tests have not shown the same results as you from simply killing the container running the OSD, however, I'll test properly today and report my findings back.

Resolved with https://github.com/att-comdev/openstack-helm/pull/83


SearchableDiscreteColorLegend does not implement onMouseEnter and onMouseLeave

I would like to have an on hover interaction with the items of a SearchableDiscreteColorLegend however it does not seem to expose the onMouseEnter and onMouseLeave properties of the DiscreteColorLegend that it wraps. Would it be possible to expose these properties, or is there some limiting factor?

I would support a PR to add these properties!

May I take a stab at this?


Key for reducers

It would be nice to have some sort of keyed reducer functionality, either through a new ak.minby etc. or maybe an optional ak.min(..., key=None) argument. Right now, as far as I can tell, the canonical workaround for ak.min(array, key=condition, axis=1) is ak.firsts(array[ak.argmin(condition, axis=1, keepdims=True)]), although I haven't worked through if that is general for all axes arguments.

This is a duplicate of #203.
To avoid complicating the interface of ak.min and ak.max (which are supposed to follow NumPy's, anyway), I think a new name is better: ak.minby and ak.maxby. (Also avoids the complication that all reducers go through the same code path and none of the other reducers would have an equivalent of this condition.)
The good news is that I think #203 can be implemented entirely in Python. The ak.singletons and ak.firsts were created to do minby/maxby—the only problem is that it's cumbersome. I encountered this difficulty while writing
https://github.com/jpivarski-talks/2020-04-08-eic-jlab/blob/master/2020-04-08-eic-jlab-EVALUATED.ipynb


page.render() callback provides no error information on failure

I tried running page.render() to save a page to a .pdf document, and all is fine and good if it succeeds. However, I tried writing to a read-only directory (just to test my error handling), and there was no hint of a failure within the code. The callback passed to render() was called with no arguments, exactly as it would have been called if the file write had been successful. Here's what the code looks like:
page.render(".../some/file.pdf", function(arg){
	if(!arg){
		console.log("File was successfully saved as a PDF");
		// ...
	}
}

Regardless of whether or not the file is created, I always see "File was successfully saved as a PDF" in the console.
For now, I can check to make sure that the file is written after render() finishes, but is there any way to get a "status" argument (like page.open() has) for the page.render() method?
Node v0.12.1
phantomjs-node 0.7.2
Thanks in advance for your help and great work on this fantastic tool!

+1
On example case to produce this, is specifying a output render path with a filename extension ot her than .pdf. Simply omitting the extension will even crash it.

I have changed this behavior to make it more clear. You can do catch() from promise.


Locale hot reload

This PR fixes issue https://github.com/oVirt/ovirt-web-ui/issues/1392
Provide translations via context
Before, translations were provided by importing a static global object.
In the new approach this object(named msg) is provided via context.
Strategies used for migration:

functional components - via useContext() hook
class components:
a)  connected to Redux store - via withMsg() HOC
b)  simple components - by directly setting context property

Areas not migrated:

placed outside of the React component tree (refactorings required)
enumMsg
EDIT: the areas mentioned above were migrated in subsequent commits

Hot-reload of user locales
After a locale change, regenerate the translation structures
and push them to all components in the React component tree.
Components will hot-reload translations as part of standard React
reload cycle.
Remove the code required for changing the locales via page reload.

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

ci add to whitelist

@rszwajko please fix conflicts.

LGTM


New Features

Please add this features :
Sensors:
WAN IP address:
Internet connection time:
Up time:
Switches:
Internet Access switch per wireless device

Change The AX3 quad core Support to Confirmed (Yes) on Readme File

@sklavosit Thanks for the feedback!
I will add sensors in the near future, but I will have to think about internet access switches.
Creating a separate switch for each client device looks a little cumbersome (especially if there are several dozen devices on the network). I need to think about it and experiment.

@sklavosit sensors are available in pre-release 0.8.1-rc1.
Could you check if the new sensors are suitable for your use cases?
p.s. switches still in progress

Thank you my
friend !!!!

You are welcome :)


Only 3 entities showing-up

Since last update, only 3 entities(temp, heating, re-circulation) are showing-up. Rest all shows unavailable. Uninstalled and re-configured the integration without any success.
2023-01-05 21:27:55.962 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up rinnai platform for sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 289, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/rinnai/sensor.py", line 38, in async_setup_entry
RinnaiOutletTemperatureSensor(device, config_entry.options),
File "/config/custom_components/rinnai/sensor.py", line 60, in init
self.options = options
AttributeError: can't set attribute 'options'

Are you running 2023.1?

Yes. 2023.1.1Sent from my iPhoneOn Jan 6, 2023, at 5:11 PM, explosivo22 @.***> wrote:
Are you running 2023.1?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I just upgraded my dev environment and I will test this out.


Why does BrowserConsoleHandler always use console.log?

Hi!
I was just wondering if there is any reason to use console.log method for all log levels, instead of also using debug, info, warn and error methods depending on the log level. This makes filtering output easier in the browser console and clearly highlights error level messages.
The following image shows an example output from Laravel using Monolog and a custom implementation of BrowserConsoleHandler:

I can make a PR if you find it useful.
Kind regards,

Yeah that sounds good, I think it's mostly because this was done when browser consoles were still pretty basic :)


Untangle complexity around TUNNEL_MODE macro

There's some hidden complexity in the way bpf/init.sh handles the TUNNEL_MODE parameter, as contrary to what it would be reasonable to expect, it will not pass always pass that value to the datapath.
This ticket is about untangling some of that complexity to make it easier to follow which values are going to be set in the datapath for that macro.

I believe 0aa9e946c856d0ca6d8754d40acc9cc896c483bf and 84a5a2403dca0c6308eac4f5bc0fdbbc507e677f cleaned this up sufficiently :tada: .


Make VoiceProtocol/VoiceClient generic on client.

Link
https://github.com/Rapptz/discord.py/pull/7459

https://github.com/Rapptz/discord.py/pull/7459#issuecomment-903579041


Allow selection of quote category

The quotes.rest API offers alternative categories, the default is inspire but we have the following options. Could also randomise the category on our end.
  "inspire": "Inspiring Quote of the day",
  "management": "Management Quote of the day",
  "sports": "Sports Quote of the day",
  "life": "Quote of the day about life",
  "funny": "Funny Quote of the day",
  "love": "Quote of the day about Love",
  "art": "Art quote of the day ",
  "students": "Quote of the day for students"

Would love to see this implemented as an Environment Variable, so that those of us who are new to coding (and to Balena deployments) could switch categories without having to dig into the code.


Add ability to fix some data quality issues.

Add the ability to "fix" some data quality issues and return a fixed dataframe. Example, removing duplicates or removing whitespace etc.

Sounds like a great idea!
How should this be implemented? For example as a get_fixed_data method with flags to indicate which fixes to apply. Or as a method for each type of fix?

@tsterbak interesting question, makes me wonder if the default_checks should really all be wrapped up into a single method, or if we should just provide direct access to the individual methods, with a flag in those methods for if you want the fixed dataframe back?

Is "fixing" the DataFrame within the scope of this package? If this is a package around running validations, actually editing the source data seems a little like scope creep. Not to mention that the logic for how you do that might be really complicated, and Tiny Timmy might not necessarily want to own that beyond exposing some functionality for common imputations, or dropping nulls with some of the common methods. Maybe consider allowing users to run cleaning methods by leveraging the underlying compute platform. i.e. if there's a "Tiny Timmy frame", and it inherits from a Polars Lazy Frame but just defines new methods or a new namespace on it, then users can call whatever Polars methods they want while also having access to validation methods from Tiny Timmy. Great expectations does this too - you have a great expectations frame, which is a wrapper around a pandas dataframe, except it also defines "expect_this", "expect_that" on those frames. This sounds like a larger architectural question, so I defer to @danielbeach on where to take it.


Redirect vLLM runtime guide to Hugging Face runtime overview

Community users have ran into issues following this guide. Let's redirect it to the updated HF runtime guide.

/lgtm
/approve


Does the SchedulerManager support distributed and cluster-friendly scheduling?

Does the SchedulerManager natively support distributed task scheduling across multiple nodes?
Any guidance or documentation links would be greatly appreciated.

Hello @yangxuhui
Yes, the SchedulerManager in PGQueuer supports distributed and cluster-friendly scheduling out of the box. It is designed to work seamlessly across multiple nodes, ensuring that scheduled tasks are managed and executed reliably in a distributed environment.
Key Features for Distributed Scheduling

Centralized Schedule Management:

Shared PostgreSQL Backend: All instances of SchedulerManager connect to the same PostgreSQL database, which serves as the central hub for managing schedules. This ensures that every node has consistent access to the scheduling information, preventing conflicts and duplications.

Concurrency Control:

Robust Locking Mechanisms: PostgreSQL’s transaction and locking capabilities are leveraged to ensure that each scheduled job is executed only once, even when multiple SchedulerManager instances are running concurrently. This guarantees that jobs are not duplicated across different nodes.

Best Practices: Offload Heavy Work to Queued Jobs
While the SchedulerManager is adept at handling the scheduling of tasks, it's recommended not to perform heavy processing directly within scheduled tasks. Instead, use scheduled tasks to enqueue jobs to the queue for processing. This approach offers several benefits:

Improved Scalability: By delegating intensive tasks to the queue, you allow your scheduling system to remain lightweight and responsive, even under heavy load.
Enhanced Reliability: Queued jobs can be managed, retried, and monitored independently, ensuring that failures in processing do not affect the scheduling mechanism.
Better Resource Management: Offloading work to the queue allows for more efficient use of system resources, as workers can scale independently based on the processing demands.

If you have specific requirements or need further assistance tailored to your use case, feel free to share more details, and we’d be happy to help!
Best regards,
JB

Hi @janbjorge
Thank you for the detailed explanation of how SchedulerManager handles distributed and cluster-friendly scheduling. I appreciate the thoughtfulness behind leveraging PostgreSQL for centralized schedule management and robust locking mechanisms.
However, I have a question regarding the current implementation:
From my understanding, SchedulerManager executes all tasks that meet the scheduling criteria on the node that acquires the lock. This approach could lead to uneven load distribution in a distributed environment, especially when there is a high volume of tasks scheduled simultaneously. In such cases, tasks might end up being dispatched primarily to the node that happens to acquire the lock, creating potential hotspots.
Since the best practice you recommend is to offload heavy work to queued jobs, wouldn't it make sense to unify SchedulerManager and QueueManager? For example:

SchedulerManager could focus solely on simple scheduling tasks, such as enqueuing jobs into the queue for processing.
The queue (via QueueManager) could handle task dispatching, execution, and load balancing across nodes, similar to what frameworks like rq and rq-scheduler do.

With this approach, SchedulerManager would primarily add job scheduling capabilities to pgqueuer, allowing the queue to take full responsibility for task execution. This design might make pgqueuer a more complete distributed scheduler system and improve scalability, as well as resource utilization in distributed environments.
I’m curious to hear your thoughts on this suggestion. Is there a specific reason for keeping SchedulerManager and QueueManager separate, or are there plans to integrate them more closely in the future?
Looking forward to your insights!
Best regards!

Hi @yangxuhui,
Thank you for your thoughtful feedback and suggestions!
Current Role of SchedulerManager
The SchedulerManager is primarily responsible for cron-like scheduling. Its design intentionally avoids handling any time-consuming or heavy workloads directly. Instead, the heavy lifting is offloaded to the QueueManager via the job queue, ensuring the scheduling mechanism remains lightweight and responsive.
On Load Distribution
You’re right that this approach doesn’t guarantee perfectly even distribution of work across nodes. While I’ve considered adding round-robin or other load-balancing logic to job-picking, it hasn’t been a significant issue in most use cases so far. However, I’m always open to revisiting this if it becomes a pain point for users like you.
Combined Interface: PGQueuer
If you’re looking for a unified interface that combines the functionality of QueueManager and SchedulerManager, the PGQueuer class is exactly what you need. It simplifies interactions and provides a cohesive API for both scheduling and queuing:
Documentation: [PGQueuer Class](https://pgqueuer.readthedocs.io/en/latest/pgqueuer.html)
Code Reference: [PGQueuer Implementation](https://github.com/janbjorge/pgqueuer/blob/ce3e38d425e3d39e63909b0dec905fa1faec12d5/pgqueuer/applications.py#L32)

Future Plans
At this point, I don’t have additional plans for further integrating or evolving the two classes. My goal is to keep the complexity of PGQueuer low while maintaining a frictionless user experience. That said, I’d love to hear about any pain points you’re encountering. Feedback like yours is invaluable for refining the library.
Regarding Redis/RQ Approaches
My experience with Redis and RQ is fairly limited, and part of the motivation behind PGQueuer was to avoid the dependencies and limitations they introduced. While I can’t speak to their approaches in detail, I believe PGQueuer offers a simpler, PostgreSQL-native solution that meets many distributed scheduling and queuing needs.
Best regards,
JB

Hi, @janbjorge ,
Thank you for  your time and the detailed clarifications! I now better understand the design philosophy behind pgqueuer.  I’ll go ahead and close this issue now!
Best regards


In_app_purchase 1.0.6 Apple payment was interrupted, and the user consent agreement did not receive a successful push

Under the local real machine debugging in sandboxed environment, if users want to enter the logic of monitoring successful payment after agreeing, they need to cut the app to the background and then open it again, and then it will take effect. However, this is too troublesome, and there is no active trigger to monitor the successful payment.I look forward to your reply, thank you

Hi @victorykong
Can you please explain the issue in detail and provide reproducible steps and situations we can reproduce this issue?
if the payment was interrupted, products won't be purchased tho. Please explain.
Thank you


Adapt gardener/gardener HA jobs

/kind enhancement
What this PR does / why we need it:
This PR adapts the gardener/gardener HA test jobs due to the changed introduced by

[x] https://github.com/gardener/gardener/pull/6910

Special notes for your reviewer:
CC: @rfranzke

Please rebase

/unhold


Branch coverage not returning correct value for branch coverage

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (3d6bfdd 2023-12-16T00:20:53.761034000Z)
What command(s) is the bug in?
forge coverage
Operating System
macOS (Apple Silicon)
Describe the bug
I tested this contract :
// SPDX-License-Identifier: BSD-3-Clause-Clear

pragma solidity 0.8.22;

contract Branch {

    function branch(bool lhs, bool rhs) external returns (bool){
        bool result;
        if (lhs || rhs){
            result = true;
        }
        return result;
    }
}

With this simple test:
// SPDX-License-Identifier: UNLICENSED
pragma solidity 0.8.22;

import {Test, console2} from "forge-std/Test.sol";
import {Branch} from "../src/Branch.sol";

contract BranchTest is Test {
    Branch public branch;

    function setUp() public {
        branch = new Branch();
    }

    function test_branch() public {
        branch.branch(true,false);
    }
}

forge coverage (latest forge version, with default params) returns 100% coverage for % Branches, which is obviously incorrect. On the other hand, the saùe test returns 50% coverage with hardhat coverage which seems more correct.

Related: https://github.com/foundry-rs/foundry/issues/4314
I think there is a logical error in your test setup as you run the test once
if (lhs || rhs){
    result = true;
}

Rewriting the test as
contract Branch {
   function branch(bool foo) external returns (bool){
       bool result;
       if (foo) {
           result = true;
       } else {
           result = false;
       }
       return result;
   }
}

contract BranchTest is Test {
   Branch public branch;

   function setUp() public {
       branch = new Branch();
   }

   function test_branch() public {
       branch.branch(true);
   }
}

Correctly yields:

File
% Lines
% Statements
% Branches
% Funcs

src/Branch.sol
80.00% (4/5)
75.00% (3/4)
50.00% (1/2)
100.00% (1/1)

Total
80.00% (4/5)
75.00% (3/4)
50.00% (1/2)
100.00% (1/1)

Marking as resolved, https://github.com/foundry-rs/foundry/issues/4314 is still an issue.


fix: added tuple support

_resize_short accepts only tuple. Fixes jina-ai/examples#235

The PR title is missleading because it also adds a new parameter.
I honestly do not see why would someone would use a scale by different than 255. It is an ImageNormalizer not an arrayNormalizer ... I personally would not apply this change.
On the other hand, u must bump manifest version to run the tests.

I am looking to have the flexibility to scale or not scale. I can also keep scale: bool = True instead of scale_by but scale_by seemed more flexible. I felt forced scaling can be a problem if I am using normalisation many times in the flow. Currently for object example, torchobject again scales up by 255 and so its not a problem if I apply normalisation on object images.
Ahh I keep forgetting the version bump.

I am looking to have the flexibility to scale or not scale. I can also keep scale: bool = True instead of scale_by but scale_by seemed more flexible. I felt forced scaling can be a problem if I am using normalisation many times in the flow. Currently for object example, torchobject again scales up by 255 and so its not a problem if I apply normalisation on object images.
Ahh I keep forgetting the version bump.

Can u describe in detail a Flow where u are seeing the need for this change? If needed, I would go for scale_by, but lets have a detail description of a case where it is needed.

I think it will become more clear when I push the object example. It doesn't require the argument for now. So let me remove it and push this.

Can you add a couple of tests where tuple input is accepted?


Yunet quantized model is slower

Hello ! Thanks for the great work.
I have been using the Yunet model and tried the quantized version to speed up inference but I got slower results, both in my own code and trying your demo. I checked the benchmarks and the quantized model is announced to be slower too : is this an expected behavior ?
For context I use default backend and I have a Intel(R) Core(TM) i5-10300H CPU. To be clear, I loaded the int8 onnx file from the github and did not use the quantization script.

is this an expected behavior ?

Yes for now. Optimization on the int8 inference on default backend is still in progress https://github.com/opencv/opencv/pull/23689.


Build OSX (Pt. 2)

Trying a tweak to see if we can build on OS X with this. I based this off of your PR ( https://github.com/conda-forge/texlive-core-feedstock/pull/2 ), @ocefpaf. Hope that is ok.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

So, this worked for me locally. Let's see if it passes on Travis CI. Also, please share your thoughts on this.

Appears it passes on Travis CI too. 😄

Could you please look at this when you have a chance, @ocefpaf?

LGTM

Thanks @ocefpaf.


chore(deps): update rust crate time to 0.3.13

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Pass sound into Windows VM and from it

Hello, I really don't know if this is correct place for my problem, but I really think that you guys can help me.
My situation:
I want to switch to Linux (I use Linux as server for long time), only problem is for some gaming but I made GPU Passthrough for it and I use Looking Glass too, only problem is that how to pass effectively sound from Windows VM back to Linux host as some source and pass from Linux host some sound source like microphone to Windows VM.
I have 2 sound cards, one internal on the motherboard and second is external where I have my headphones with microphone plugged. Second sound card (external) I want for Linux, but I don't use internal one, so that internal can be used for VM, if there is any use case for it.
I don't know if scream can help me, if yes, then I have some additional questions:

What is latency?
What is performance hit? For example CPU.
What is quality of it?

Thank you very much

Scream's advantage compared to using two sound cards is that you can mix the sound on the host computer in software, without fidelity loss due to resampling or unneccessary conversions between analog and digital realms.

Latency is negligible, I use it to play CS ...
Performance hit is negligible.
Quality is unimpaired (as explained above).

Scream cannot reverse-map microphone input however, you should use your second sound card for that (USB passthrough).

So great, if I understand it correctly then:
I use Scream to pass VM sound into host machine (so I can mix it), and for microphone I split audio cable and one end goes to my external usb sound card (primary for host, because that external soundcard has better quality than integrated) and second end goes to my integrated sound card (mic in) and that integrated sound card I somehow pass into VM, so everything what I say, can be heard in host and VM, right?


Some questions for the KL_loss and KL_loss_r and model behaviors

Hello MaxMax2016,
Thank you for sharing your code on the improved VITS, I hope to check with you about the model behaviors when adding the bi-directional KL divergence. In this repo I found that you use 1.0 * kl_loss + 1.0 * kl_loss_r during training, and when I do training on my own dataset I saw this greatly increased the mel-spectrogram loss, comparing to the original VITS, and when I add kl_loss_r to finetune a well trained VITS model, it gives bad voice quality.
Can you share your experiences or findings when trying to add this specific term? In the loss curve you shared, it seems that the mel-spec loss is still low (below 20), which is very interesting.
Thanks

you can freeze post encoder and hifigan decoder，maybe also text encoder, then use add kl_loss_r finetune a well trained VITS model.

关注下，这个loss 加上有效果不，有过对比吗

with this loss, less sound error than raw model.

@MaxMax2016 加上这个loss后，有比较高add_blank和不加add_blank以及是不是用sdp duration的差异么

you can freeze post encoder and hifigan decoder，maybe also text encoder, then use add kl_loss_r finetune a well trained VITS model (train flow).

Does your kl_loss_r term increase the mel_spectrogram loss during training (training from scratch)? If you also observed this (as I did), does it affect the voice quality after convergence?

i have not meet this problem, because baker is high precision labeled. I wonder, if the data is labeled incorrectly, kl_loss_r will propagate error to subsequent modules(post encoder and hifigan decoder), so the best way is :you can freeze post encoder and hifigan decoder，maybe also text encoder, then use add kl_loss_r finetune a well trained VITS model (train flow). @feng-yufei

@feng-yufei https://github.com/PlayVoice/vits_chinese/issues/36#issuecomment-1463298450  YES it increases mel loss.

@feng-yufei Hi, I met the same issues using my datasets, what's your conclusions now?

@feng-yufei Yeah, and did you use loss_kl_r now and set the coefficient to 0.01 for your training or just remove  loss_kl_r?

@MaxMax2016 加上这个loss后，有比较高add_blank和不加add_blank以及是不是用sdp duration的差异么

请问加add_blank和不加add_blank有啥差异么？


Use patch to update the extension data in the ShootState

How to categorize this PR?

/area control-plane-migration
/kind enhancement
/priority normal
What this PR does / why we need it:
This PR changes the way the extension states and their related resources (if any) are added to the ShootState. Patch is used to persist the changes and it is only called if there are differences between the extensions' states in the Shoot's control plane and the corresponding states in the ShootState
Which issue(s) this PR fixes:
Part of #1631 #2689
Special notes for your reviewer:
Release note:

Use PATCH to update the extensions' state and relevant resource data to the ShootState.

/assign

/rebase