Improve test coverage for errors

Signed-off-by: Svetoslav Blyahov<EMAIL_ADDRESS>Improve configtxgen test coverage (for error messages) as @wlahti advised in my previous PR.
Type of change

Test update

Description
Start expecting exact error messages.

Pushed some changes I think (as far as I understood your points) are addressing the concerns. Please, let me know if I missed something or something else needs improvement.

Sorry, maybe should've been clearer in the OS-specific nature of the test that fails locally. The temp directory is different depending on the developer's OS, so we need to generalize the regular expression to not care about the beginning of the path. For reference, here's the output when running that test on my mac:
`
=== RUN   TestUnsuccessfulChannelTxFileCreation
2020-04-14 16:30:43.549 EDT [common.tools.configtxgen.localconfig] Load -> INFO 01b Loaded configuration: /Users/wlahti/gopath/src/github.com/hyperledger/fabric/sampleconfig/configtx.yaml
2020-04-14 16:30:43.549 EDT [common.tools.configtxgen] doOutputChannelCreateTx -> INFO 01c Generating new channel configtx
2020-04-14 16:30:43.551 EDT [common.tools.configtxgen] doOutputChannelCreateTx -> INFO 01d Writing new channel tx
2020-04-14 16:30:43.551 EDT [common.tools.configtxgen] doOutputChannelCreateTx -> INFO 01e Generating new channel configtx
2020-04-14 16:30:43.553 EDT [common.tools.configtxgen] doOutputChannelCreateTx -> INFO 01f Writing new channel tx
TestUnsuccessfulChannelTxFileCreation: main_test.go:92:
Error Trace:	main_test.go:92
Error:      	Expect "Error writing channel create tx: open /var/folders/gy/jb454xb90513cqzgvv7111hr0000gn/T/configtxgen143477252/configtx: permission denied" to match "Error writing channel create tx: open /tmp/configtxgen.+/configtx: permission denied"
Test:       	TestUnsuccessfulChannelTxFileCreation
--- FAIL: TestUnsuccessfulChannelTxFileCreation (0.03s)
`

Yes, sorry, I didn't really understand your point but it totally makes sense. I should have thought of that. Pushed an update.

/azp run

Can you rebase this on master and we'll see if we can get a maintainer to merge as-is? I think the capitalization of the error messages can be done in a follow-up PR considering they've had that capitalization for years.

Looks like there aren't any conflicts with master, merging as is


Bug fix 3.6/fix remove arangosearch link test

Fix for QA ticket https://github.com/arangodb/release-3.6/issues/43
Reviewed code for mmfiles collection. Currently looks like this failure is test-related.
https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/7746/

wrong enterprise branch was used.
PR restarted
https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/7754/

Tests blue except unrelated failures.


Class does not support Compressed Timestamp Headers

If anyone receives:

phpFITFileAnalysis->readDataRecords(): this class can only handle normal headers!

Please share an example FIT file and I'll use this for testing the handling of these timestamps. I'd be flying blind without a file to work so I'm not developing this until someone experiences the Exception above being thrown!
Adrian.

@undertrained is currently trying to convert the current FIT parser of Runalyze, which is using mrihtar/Garmin-FIT (a perl module), to this one. Although there's a lot of other stuff to do in that branch, I already can see that message in our unit tests, thrown by FR70-intervals.fit. Feel free to use that for your testing and developing ;)

Thanks @laufhannes  I'll take a look when I get chance, but very busy right now. Very useful to have a FIT file with a compressed timestamp header 👍

As far as I can tell there's nothing more to compressed TS than to calculate the record's timestamp with the most recent full TS and the record's offset using the formula given in the FIT documentation.  I just did a pull request with code that I think implements this feature, please have a look.
BTW, thanks for the library, it's really useful.

@rafaelnajera Hey, thanks for the PR! I will get round to reviewing this properly soon. At first glance it looks good. I didn't think it was overly complex, just haven't had much free-time lately and up until recently no FIT files with compressed timestamps to test with!

Closing this issue following merging PR from Rafael. Will probably add a test or two for the new code and include a FIT file with a compressed timestamp. Thanks all


💡 [Feature]: Extra tasks to update Patch, Minor and Major version of SPFx project

🎯 Aim of the feature
Add extra tasks so that you can update the patch, minor or major version of an SPFx project (package-solution.json) in one click.
Extra nice would be if it would also update the package.json version as well.
📷 Images (if possible) with expected result

Thanks @martinlingstuyl for adding an idea 👍.
A couple of things I would like to clarify:

why do you usually update the version? Is it something you do just before the package publish to update it on the app catalog? Or is it something you just do regularly on adding every new feature and you just want to add this to the commit?
do you always have aligned the package.json and package-solution.json? And if not what you would expect to happen on this task? Should one be overwritten to align with pacakge-solution.json? Or both should be increased?
what number should be increased? Major? Minor? Or patch? Or should the extension ask for this option?

Do my answers clarify it a bit for you? I'd wish to be able to be more specific on the impact of version numbers. maybe we should ask Vesa :-)

Do my answers clarify it a bit for you? I'd wish to be able to be more specific on the impact of version numbers. maybe we should ask Vesa :-)

Yes that helped a lot. Thanks for the additional info.
@VesaJuvonen is usually very busy (totally understandable), but if you have anything worth adding regarding versioning of apfx package please do 👍

@martinlingstuyl I will set this feature for v3
In your answer I noticed

We use a gulp task to sync both numbers, so they are the same.

So you use a custom defined gulp task for it, right? I think in there is no OOTB gupl task for it delivered with @microsoft/sp-build-core-tasks package 🤔? Viva Toolkit base on those tasks as then we assume in every project they exist. We don't deliver any custom gulp tasks for every project.

I think in there is no OOTB gupl task for it delivered with @microsoft/sp-build-core-tasks package

No that's correct, we've copied it from internet somewhere. It's picking up on an npm event I believe.

I think in there is no OOTB gupl task for it delivered with @microsoft/sp-build-core-tasks package

No that's correct, we've copied it from internet somewhere. It's picking up on an npm event I believe.

hmmm.. not possible path for this extension. but we may for sure prototype a different approach

found an awesome inspiration coming from the good old pnp spfx generator
https://n8d.at/use-npm-version-to-upgrade-version-of-your-spfx-solution/

The idea I have is to create similar functionality with a dedicated action like 'increase version'.
When clicked it would present 3 options which version we want to increase, major, minor, patch
It would always align the versions between package.json and package-solution.json without asking
we could add a dedicated setting in the VS Code settings for SPFx toolkit 'update version when deploying solution'. This should be true/false check box. When set to true during the deploy action SPFx toolkit should now also ask which version should be updated: major, minor, patch and should perform this change before running deploy.

things to consider:

should we also run git tag command to create a dedicated tag for the version update changes commit 🤔. That is what pnp spfx generator did
our scaffolded CI/CD workflows for GitHub and AzureDevOps do not update this version on deploy. Maybe this should be also an option 🤔

@martinlingstuyl any feed? how do you like the above prototype 👆

Hi @Adam-it,
I certainly love the idea!
In terms of git tagging the commit: absolutely! Or maybe use a setting to toggle this on/off. Default should be true though, I think.
As far as the CI/CD workflow is concerned: I don't think this applies there. The CI/CD workflows simply pick the last commit, and build and deploy based on that. Which is what we would want.

ok sounds like a plan.
to sum up the idea:

Create a dedicated action 'increase version'.
When clicked it would present 3 options which version we want to increase, major, minor, patch
It would always align the versions between package.json and package-solution.json without asking
we could add a dedicated setting in the VS Code settings for SPFx toolkit 'update version when deploying solution'. This should be true/false check box. When set to true during the deploy action SPFx toolkit should now also ask which version should be updated: major, minor, patch and should perform this change before running deploy.

let's drop the idea for git tag for now and we may always get back to this idea later


[BUG] - 8.1.1-pre fails for NodeToClient protocols

External
Area
NodeToClient miniprotocols
Summary
Between 1.35.7 and 8.1.1, the serialization format for some of the NodeToClient protocols has been altered. Serialization formats should not be changed unless the NodeToClient version is also incremented. The result is downstream tools breaking and unable to communicate with the nodes without code changes or externally knowing what version of the node they are communicating with. In 8.0.0, this was noticed for the protocolParameters query which was then fixed in 8.1.1. There are 3 additional queries that also need to be fixed in order for 8.1.1 and beyond to be properly compatible with the NodeToClient standards.
Steps to reproduce
Steps to reproduce the behavior:
From Kogmios/Ogmios 5.6.0, query an 8.1.1 node. Notice that the wire formats are changed for:
query delegationsAndRewards
query utxo
query stakeDistribution
Query 8.1.1 Node

Query 1.35.7 Node

Expected behavior
Within a NodeToClient protocol version, the wire formats should not change between cardano-node releases.
System info (please complete the following information):

OS Name: Ubuntu
OS Version: 22.04
Node version: 8.1.1-pre
CLI version: 8.1.1-pre

Screenshots and attachments
See:
https://github.com/CardanoSolutions/ogmios/issues/313
https://github.com/CardanoSolutions/ogmios/issues/315
https://github.com/CardanoSolutions/ogmios/issues/316
Additional context
This breaks Ogmios, Phyrhose, probably TxPipe, cncli, SundaeSwap Scoopers, and any tools and downstream utilities that use these miniprotocols. Tools should be free to stay on their same NodeToClient version without worrying about breaking changes to the API. They should then be free to upgrade to newer versions of NodeToClient on their own timelines.

+1 , This not only breaks downstream solutions delaying further ability to properly expire 1.35.x nodes, but also introduces unnecessary interim versions that cannot be used in different scenarios

Within a NodeToClient protocol version, the wire formats should not change between cardano-node releases.

:100:

I've ran this by the ledger team. This is a problem with the deserialization of indefinte vs definite length lists. After being deserialized the format is the same, so this does not need a new NodeToClient version. Our assumption is people are trying to run a version of ogmios that hasn't been updated to work with 8.0.0.
It also looks like Ogmios uses Cardano.Binary instread of Cardano.Ledger.Binary for serialization/deserialization. Cardano.Ledger.Binary is safer. Some of the toCBOR instances in Cardano.Binary are bad because they have to break CBOR rules for legacy byron. Cardano.Ledger.Binary basically only uses Cardano.Binary when it has to (usually byron related). Cardano.Ledger.Binary also is versioned now as of 8.0.0.

I also ran into a similar error when trying to connect a 8.x.x client (written using cardano-testnet) to a 1.35.x server (written using ouroboros-network).
DecoderFailure (ChainSync (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (TPraos StandardCrypto) (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AllegraEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (MaryEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AlonzoEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (BabbageEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (ConwayEra StandardCrypto)) ('[] *))))))))) (Tip HardForkBlock (': * ByronBlock (': * (ShelleyBlock (TPraos StandardCrypto) (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AllegraEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (MaryEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AlonzoEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (BabbageEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (ConwayEra StandardCrypto)) ('[] *)))))))))) ServerAgency TokIntersect) (DeserialiseFailure 3 "expected list of length 2")

The "expected list of length 2" part makes me think this is the same issue. But as far as I know this doesn't involve any custom serialization or deserialization code for our side (the plutus-tools team).

@KtorZ According to the SPO call yesterday, it was made clear that Ogmios would need to be updated to fix the remaining format issues here.

Closing as downstream tools will change to adjust to this bug.


Support devcontainer (local and GH Codespaces)

As an alternative to locally installing the toolset, you can also use a devcontainer. This PR adds the required files and documentation how to use it.

@waldo1001 @JeremyVyska as discussed today :)

@tfenster  / @ajkauffmann
Might be an idea to add a warning about that.
{{% alert title="Warning" color="warning" %}}
Blah Blah Blah
{{% /alert %}}

If you can add a message about to not be concerned if / when you get that.

@TheDoubleH  I added something, see https://github.com/microsoft/alguidelines/pull/143/commits/cda4104e6189611866a03e0ab0c31d751712e411. Does that make sense and helps to avoid the concerns? Or is it too much?

@waldo1001 as discussed: https://github.com/microsoft/alguidelines/pull/143/commits/408368b3de51e324d78c874d51761f606e33a6e2


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (47cf44a) to head (2a33ccc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #627   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           71        71
  Lines         1915      1915
  Branches       235       235
=========================================
  Hits          1915      1915

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HIVE-27571: Backport of HIVE-18702 to branch-3

What changes were proposed in this pull request?
Backport of HIVE-18702: INSERT OVERWRITE TABLE doesn't clean the table directory before overwriting
Jira link - https://issues.apache.org/jira/browse/HIVE-27571

@vihangk1 @sankarh Can you please review and merge this?


PHP Proxy does not proxy Content-Type 'text/xml' requests

I'm using PHP Version 5.5.34.
Request:
POST /PHP/proxy.php?http%3A%2F%2Fsuite.opengeo.org%2Fgeoserver%2Fwfs= HTTP/1.1
Pragma: no-cache
Origin: http://quicksilver.esri.com
Accept-Encoding: gzip, deflate
Host: quicksilver.esri.com
Accept-Language: en-US,en;q=0.8
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36
Content-Type: text/xml
Accept: */*
Cache-Control: no-cache
X-Requested-With: XMLHttpRequest
Cookie: __utma=39465783.1702136191.1446065835.1446065835.1449088386.2; WT_FPC=id=277f886dab32e00d4011449088385181:lv=1449088416334:ss=1449088385181; __unam=b1ba6c-15164660495-3c3d8963-2; s_vnum=1495300342950%26vn%3D1; _ga=GA1.2.1702136191.1446065835; _ceg.s=o7hkyq; _ceg.u=o7hkyq; _ceir=1; s_fid=080762D3DDC74C02-0D9A896E9D205BD8; s_nr=1463765860424-New; PHPSESSID=7d72852cead1c32cae4e5284ddf2e6b4
Connection: keep-alive
Referer: http://quicksilver.esri.com/js-api/test-apps/3.17/webmap.html
Content-Length: 440

<?xml version='1.0' encoding='utf-8'?>
<GetFeature
xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'
xmlns:gml='http://www.opengis.net/gml'
xmlns:ogc='http://www.opengis.net/ogc'
xmlns:wfs='http://www.opengis.net/wfs'
xmlns='http://www.opengis.net/wfs'
xmlns:opengeo='http://opengeo.org'
version='1.1.0' service='WFS' maxFeatures='3000'>
<wfs:Query typeName='opengeo:countries' srsName='EPSG:4326'>
</wfs:Query>
</GetFeature>

Response:
<ows:ExceptionReport xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:ows="http://www.opengis.net/ows/1.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="2.0.0" xsi:schemaLocation="http://www.opengis.net/ows/1.1 http://suite.opengeo.org/geoserver/schemas/ows/1.1.0/owsAll.xsd">
<ows:Exception exceptionCode="MissingParameterValue" locator="request">
<ows:ExceptionText>Could not determine geoserver request from http request org.geoserver.platform.AdvancedDispatchFilter$AdvancedDispatchHttpRequest@50728dd</ows:ExceptionText>
</ows:Exception>
</ows:ExceptionReport>

Here's a .har file:
wfs-php-proxy.har.zip

It looks like PR #323 was for a similar issue. Hopefully the fix could be more generic than this:
https://github.com/Yall1963/resource-proxy/commit/e0d9a7df0fe96241455ad2cff9434debb5f27e1c#diff-4d91edb8990afeef04888edc8d4be957

Any news on getting this fixed? We are trying to display a WFS service in a ESRI JS 3.20 map. We have tried to get this to work on the PHP proxy, without any success. This is however working fine on the .net proxy.

Update
The php proxy is failing because it's using PHP's built-in $_POST to determine if it's a POST.  According to the user comment at http://php.net/manual/en/reserved.variables.post.php#114598, this is only true for standard forms with Content-Type: application/x-www-form-urlencoded.
$_POST is NOT set for: Content-Type:text/xml.
This is why the logic in the setupClassProperties function is failing. And the PHP proxy isn't working for application/xml or text/xml etc.

@tgirgin23 - If your WFS is public, could you share it for testing?

@bsvensson Thanks for the quick reply. The WFS layer is the one found in the current JS API sample WFS page.

@tgirgin23 - no problem. BTW, that's just a test service with some test data. I assume you'll be using something else later on (unless this is just a test/prototype app). Since different WFS can be set up quite differently, don't forget to test on the actual service.

@bsvensson We have tried on multiple different services and we are having the same issue every single time with the PHP proxy

I have the same problem when I use a WFS layer in a JavaScript ESRI API
I get the following error:
No query information to decode. QUERY_STRING is set, but empty.
This is the request:
Request URL:http://aplicaciones.icv.gva.es/visor_gva/proxy/PHP/proxy.php?http://mapas.valencia.es/wms/opendata_wfs?
Request Method:POST
Status Code:200 OK
Remote Address:<IP_ADDRESS>:80
Referrer Policy:no-referrer-when-downgrade
Response Headers
view source
Access-Control-Allow-Headers:*
Access-Control-Allow-Origin:*
Cache-Control:max-age=1
Connection:close
Content-Encoding:gzip
Content-Length:84
Content-Type:text/html; charset=UTF-8
Date:Mon, 16 Oct 2017 08:46:47 GMT
Expires:Thu, 19 Nov 1981 08:52:00 GMT
Expires:Mon, 16 Oct 2017 08:46:50 GMT
Server:Apache/2.2.29 (Unix) mod_ssl/2.2.29 OpenSSL/1.0.1e-fips DAV/2 PHP/5.5.23
Vary:Accept-Encoding
Request Headers
view source
Accept:*/*
Accept-Encoding:gzip, deflate
Accept-Language:es-ES,es;q=0.8,en;q=0.6,ca;q=0.4,fr;q=0.2
Cache-Control:no-cache
Connection:keep-alive
Content-Length:763
Content-Type:text/xml
Cookie:PHPSESSID=j1m2pgbtpr05ljk4phektgggp7; SESS3bf9382ecbe8ca0f95636584e4e9a0b3=k57u9dc3ttt6pn3d0b8avfo9e6
Host:aplicaciones.icv.gva.es
Origin:http://aplicaciones.icv.gva.es
Pragma:no-cache
Referer:http://aplicaciones.icv.gva.es/visor_gva/visor/index.html?modo=intranet
User-Agent:Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36
X-Requested-With:XMLHttpRequest
Query String Parameters
view source
view URL encoded
http://mapas.valencia.es/wms/opendata_wfs?:
Request Payload
<?xml version='1.0' encoding='utf-8'?>
<GetFeature
 xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'
 xmlns:gml='http://www.opengis.net/gml'
 xmlns:ogc='http://www.opengis.net/ogc'
 xmlns:wfs='http://www.opengis.net/wfs'
 xmlns='http://www.opengis.net/wfs'
 xmlns:='http://www.opengis.net/wfs'
 version='1.1.0' service='WFS' maxFeatures='1000'>
 <wfs:Query typeName=':TRA_RECARGA_ELECTRICA' srsName='EPSG:3857'>
  <ogc:Filter xmlns:ogc='http://www.opengis.net/ogc'>
   <ogc:BBOX>
    <ogc:PropertyName>:msGeometry</ogc:PropertyName>
    <gml:Box srsName='EPSG:3857'>
      <gml:coordinates>-436357.58482010243,4692951.475488542<PHONE_NUMBER>2010243,4951614.379205579</gml:coordinates>
    </gml:Box>
   </ogc:BBOX>
  </ogc:Filter>
 </wfs:Query>
</GetFeature>

Thanks!

Had the same problem with @paupepui . I could find a workaround valid for us. I forked the repository and added the changes there. It probably needs serious revision, but could be used as a patch meanwhile.  Here is a comparison showing what I added:
https://github.com/Esri/resource-proxy/compare/master...wanderlux:master
TL;DR

Added a new check for Content-Type:text/xml in setupClassProperties following @bsvensson hint.
Added a new option so this function would be called, using a proxyMethod I named XML
Added a new function  proxyXml: copied proxyPost and changed the values I needed, passing the raw xml data into the request body.


Paying to a lightning address fails when base64 encoded image data length is over 136536 bytes

When paying to a lightning address, if metadata object contains a image/jpeg;base64 or image/png;base64 value length over 136,536 bytes, a Java exception is raised.

That is according to the spec, see https://github.com/fiatjaf/lnurl-rfc/blob/luds/06.md#wallet-to-service-interaction-flow
Here's a screenshot because it is hard to find:


Installation on OpenShift 4.x fails with "Privileged containers are not allowed"

Trying to deploy SonarQube to OpenShift 4.6 via this helm chart.
I changed the following fields in values.yaml:
OpenShift:
  enabled: true

  securityContext:
    # For standard Kubernetes deployment, set enabled=true
    # If using OpenShift, enabled=false for restricted SCC and enabled=true for anyuid/nonroot SCC
    enabled: false

  volumePermissions:
    # For standard Kubernetes deployment, set enabled=false
    # For OpenShift, set enabled=true and ensure to set volumepermissions.securitycontext.runAsUser below.
    enabled: true
    # if using restricted SCC set runAsUser: "auto" and if running under anyuid/nonroot SCC - runAsUser needs to match runAsUser above
    securityContext:
      runAsUser: "auto"

Helm chart installs but sonarqube pod fails with the following message:
create Pod sonarqube-sonarqube-0 in StatefulSet sonarqube-sonarqube failed error: pods "sonarqube-sonarqube-0"
 is forbidden: unable to validate against any security context constraint: [spec.initContainers[1].securityContext.privileged: Invalid
 value: true: Privileged containers are not allowed spec.initContainers[2].securityContext.runAsUser: Invalid value: 0: must
 be in the ranges: [1000800000,<PHONE_NUMBER>] spec.containers[0].securityContext.runAsUser: Invalid value: 1000: must
 be in the ranges: [1000800000,<PHONE_NUMBER>]]

So either these settings are incorrect or helm is not installing correctly.
Regards
Gas

Hi @gasgithub ,
this is a current limitation as documented here

And just to not leave you hanging with this very unsatisfying answer; you could try to tinker around with the security contexts that are defined in the values.yaml. if the your environment is designed to handle none root only, this might lead to a working deployment.

Well I solved this.
The missing piece was setting
serviceAccount:
  create: true

Then service account is correctly created and associated with custom sonarqube-privileged-scc security context.


SASS conditionals. replaced stub with guide

Pr has 1 syntax example, 1 problem, and 1 solution.

[ x] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[ x] None of my changes are plagiarized from another source without proper attribution.
[ x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[ x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

I'm closing this PR since a solution was added by a previours PR #34792 .
Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding. ✈


Custom function not working on cellRenderer

const deactivateStudentAccount = () => {
console.log('deactivateStudentAccount');
};
The button @click does not call the deactivateStudentAccount function.
@bhaveshpatel200 any tip?

HI,
Can you please check Slot demo.
https://vue3-datatable-document.vercel.app/actions
you can easily display button conditions wise or can do anything in slot.

Hi,
For cellrenderer, it will be supports functions or string (cellRenderer?: [Function, string]).
Seems you are trying to add vue @click event in cellrenderer which is not working here its only support html. so alternative you can use slot which is best for you to add custom button or whatever you want in that.

This works @bhaveshpatel200 , thanks!


Fix catalog clone issue

https://github.com/rancher/rancher/issues/14629

This build seems failed and we still encounter the displayName not defined issue with catalog, thanks.


Azure Active Directory Graph would be deprecated soon. When do you plan to upgrade az ad to use Microsoft Graph endpoint?

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa048db2-b924-889c-c105-2a676714b0ee
Version Independent ID: 5774d883-1b16-d4b9-8d61-4694af8d9341
Content: az ad
Content Source: latest/docs-ref-autogen/ad.yml
Service: active-directory
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Azure Active Directory Graph would be deprecated soon. When do you plan to upgrade az ad to use Microsoft Graph endpoint

@jiasli for awareness

The migration to Microsoft Graph is being tracked at https://github.com/Azure/azure-cli/issues/12946.


Move and refactor upgrade notification JS

Part of #5252. This PR moves the upgrade notification JS to wagtail-client. I've re-written it for the most part, given it's simplicity including, removing its jQuery dependance.
Probably look at #5254 first because it raises some related questions.
Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing) Yes.
Does the code comply with the style guide? (Run make lint from the Wagtail root) Yes.
For Python changes: Have you added tests to cover the new/fixed behaviour? N/A
For front-end changes: Did you test on all of Wagtail’s supported browsers?
Chrome 73 MacOS
Safari 12.0 MacOS
Firefox 66.0 MacOS
For new features: Has the documentation been updated accordingly? N/A

This is good to go, I have merged it in with some resolved conflicts all sorted.
@jonnyscholes  - merged in via https://github.com/wagtail/wagtail/commit/c0af26b076b4561cdbdca2eb81de90a930813421
I think there were two outstanding items, not blockers though.

components folder housing both React and 'DOM / template style' components - maybe when more refactoring is done a good pattern will emerge and we can move things around then.
slightly easier future customisation of putting the releases URL in the template, so it can be accessed by its data attribute. I think that the original code did not have this so all good, plus there are other ways to override what renders in the settings bar.


Add Sonoff button SNZB-01P variant

Proposed change
This adds an alternative signature for the Sonoff button SNZB-01P. The quirk is used to add the device triggers.
The new quirk inherits from the previous SonoffSmartButtonSNZB01P quirk to add the device triggers.
Compared to the existing quirk, the PollControl and Sonoff manufacturer specific clusters are missing as input clusters.
Output clusters also do not contain Identify and Ota.
Additional information
Addresses https://github.com/home-assistant/core/issues/104548
Checklist

[ ] The changes are tested and work correctly
[x] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

Why not convert these to v2 and forget the sig stuff?

Right, perfect candidate for that. I'll convert this tomorrow.

Codecov/project coverage decrease is expected, as a lot of code is removed.
This should be good as-is now. Merging to get it in the next quirks release for HA beta.


Added registry-secrets input to authenticate with private registries

This input works like so:
      - uses: balena-io/balena-ci@add-registry-auth
        name: 'Deploy to miguel/${{ matrix.fleet }}'
        id: build
        with:
          balena_token: ${{ secrets.BALENA_STAGING_TOKEN }}
          environment: balena-staging.com
          fleet: 'miguel/${{ matrix.fleet }}'
          registry_secrets: |
            {
              "ghcr.io": {
                "username": "${{ secrets.REGISTRY_USER }}",
                "password": "${{ secrets.REGISTRY_PASS }}"
              }
            }

I have seen some people add a step to remove secrets after they are needed...I wonder if that should be done here as well...I think it would be trivial...just rm -r $HOME/.balena after executing the node script.

With jq parsing the registry-secrets string which was a great idea actually returns the following:
parse error: ':' not as part of an object at line 1, column 17

and without jq we get :
Error: Error validating registry secrets file "/github/home/.balena/secrets.json":
Unexpected token : in JSON at position 16

So I think not using jq provides better logging from the CLI

@balena-ci I self-certify!


User unable to create/send gifts

User: "Hi guys still not able to create a gift (see screenshot) and just can’t get one recipient set up (see screenshot and when scanning his QR get an error)"

Version History:

Abhilash's comment: Based on the screenshot below, the gift seems to have been created but obviously didn't go.

User: "The other user is on Android, one version below me (on iOS)"
User: Greg
Platform: Twitter DMs

HW: Two questions:

Had you accepted a gift and added the sats to the account after the upgrade?
Had you sent out a gift that remained unclaimed and came back to your wallet?

User's answers:

No, sats were added after the upgrade and via banxa. I have never accepted a gift. 2) I have also never been able to create a gift (as far as I recall) and have certainly not had a gift returned. Hope that helps.

User unable to send sats regularly also. He's unable to send to someone who he was able to send earlier.

Issue resolved.


Remove invisible datapoints without derpy animation

I have a graph displaying real-time data. Over time the number of data points grows impractical to manage, so I have tried to "shave off" the invisible ones. Unfortunately, the animation isn't working right.
Desired outcome:

Actual outcome ("notice how the library thinks that the new data is unrelated to the old one, resulting in the points moving vertically, not horizontally):

This is the code that removes the old data:
const truncate = (data, length) => {
    if (data.length > length) {
        while (data.length >= length) {
            data.shift();
        }
    }

    return data;
}

Is there a way to get rid of the derpiness?

@KaappoRaivio Do you have a sharable reproduction of this?
I understand why this would happen, (which is nicely described in this blog), however in my own tests I am seeing a nice horizontal scrolling.

Here is the code that I used to generate that gif.
import React, {useState, useRef, useEffect} from 'react';
import {XYPlot, LineSeries, YAxis, XAxis, Borders} from 'react-vis';

import {AutoSizer} from 'react-virtualized';

const POINT_COUNT = 100;
const FREQUENCY = 200;

export const ScrollingDataChart = () => {
  const {current: iterator} = useRef(points());

  const [data, setData] = useState(() => {
    let data = [];
    for (let i = 0; i < POINT_COUNT; i++) {
      data.push(iterator.next().value);
    }
    return data;
  });

  useEffect(() => {
    const handle = setInterval(() => {
      setData(data => {
        const {value: point} = iterator.next();
        data.push(point);
        while (data.length > POINT_COUNT) {
          data.shift();
        }
        return [...data];
      });
    }, FREQUENCY);
    return () => clearInterval(handle);
  }, []);

  const xDomain = [data[1].x, data[data.length - 2].x];

  return (
    <AutoSizer>
      {({width, height}) => (
        <XYPlot
          height={height}
          width={width}
          yDomain={[-1.2, 1.2]}
          xDomain={xDomain}
          animation
        >
          <LineSeries data={data} />
          <Borders style={{all: {fill: 'white'}}} />
          <YAxis />
          <XAxis />
        </XYPlot>
      )}
    </AutoSizer>
  );
};

function* points() {
  let x = 0;

  while (true) {
    yield {x: x++, y: Math.random() * 2 - 1};
  }
}


Translation on selection

Added optional support of translation on selection.
To achieve this little refactoring was needed. Main logic moved from setInterval to processWord

Thank you for your participation. I will gonna request update for chrome web store


[CR-18] Fix the socket option error on Windows

Fix the following error while starting the server on Windows.

Should consider moving this flag option to the configration.xml file for manually enable/disable if needed.

Also allows configuration of server address.


For a 0.19.4 release

#720 #719
Note this PR drops support for julia < 1.6

Codecov Report

Merging #721 (34555c0) into master (eeb26df) will decrease coverage by 1.72%.
The diff coverage is 38.88%.

:exclamation: Current head 34555c0 differs from pull request most recent head 51c486b. Consider uploading reports for the commit 51c486b to get more accurate results

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   86.60%   84.87%   -1.73%
==========================================
  Files          36       36
  Lines        3404     3352      -52
==========================================
- Hits         2948     2845     -103
- Misses        456      507      +51

Impacted Files
Coverage Δ

src/measures/finite.jl
98.20% <ø> (-0.02%)
:arrow_down:

src/measures/measure_search.jl
50.00% <ø> (-6.25%)
:arrow_down:

src/measures/measures.jl
70.87% <ø> (ø)

src/measures/meta_utilities.jl
20.40% <0.00%> (-76.26%)
:arrow_down:

src/measures/probabilistic.jl
61.33% <ø> (-1.83%)
:arrow_down:

src/MLJBase.jl
60.00% <100.00%> (-32.86%)
:arrow_down:

src/measures/loss_functions_interface.jl
73.21% <100.00%> (-17.46%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb26df...51c486b. Read the comment docs.


spdm communication between requester and responder

Hi,
I was looking through the code where responder exactly pickup the message from the platform -
bool platform_server(IN SOCKET socket)
{
bool result;
return_status status;
uint8_t response[PCI_DOE_MAX_NON_SPDM_MESSAGE_SIZE];
uintn response_size;
while (true) {
    **status = libspdm_responder_dispatch_message(m_spdm_context);**
    if (status == RETURN_SUCCESS) {
        /* success dispatch SPDM message*/
    }

libspdm_responder_dispatch_message() calls below to get the message from platform
spdm_context->receive_message(spdm_context, &request_size,
request, 0);
The problem I see here is there seems no synchronization here when receiving the message (i.e responder may run faster and try to recv the message but requester might not have posted the message still, causing responder to fail/exit) and it's possible that responder may get same message again which it read before already (as it's blindly trying to receive message from the platform in a while loop above).  How this is syned actually ?
Thanks,
Manish

Emu is just a simple component for us to run test for libspdm. Emu itself is not a production.
If you find an issue, feel free to submit P-R to fix it.


Error occurred when executing AnimateDiffLoaderV1:

Error occurred when executing AnimateDiffLoaderV1:
index 10 is out of range
File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 151, in recursive_execute
File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 81, in get_output_data
uis = []
File "D:\ComfyUI_windows_portable\ComfyUI\execution.py", line 74, in map_node_over_list
nodes.before_node_execution()
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\nodes.py", line 390, in inject_motion_modules
injectors[self.version](unet, motion_module, injection_params)
File "D:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\nodes.py", line 193, in inject_motion_module_to_unet
unet.input_blocks[unet_idx].append(
File "D:\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\container.py", line 295, in getitem
return self._modules[self._get_abs_string_index(idx)]
File "D:\ComfyUI_windows_portable\python_embeded\lib\site-packages\torch\nn\modules\container.py", line 285, in _get_abs_string_index
raise IndexError('index {} is out of range'.format(idx))

You are likely attempting to load a checkpoint that is not SD1.5 based - try again with an SD1.5-based checkpoint.

As this is a common issue, I will soon add code to check if the SD checkpoint is SD1.5 base, and throw an more informative error.

Yep I was using SXDL, will you be updating to function with SDXL models in the future?

The motion module of AnimateDiff is built around injecting an SD1.5 model, so SDXL-compatible AnimateDiff would require a whole new type of motion module. And to work the same way it does now with SD1.5, where 16 frames is the sweetspot, you'd need to be able to use batch_size = 16. AnimateDiff basically works by diffusing all those latents at once.
To see if a hypothetical SDXL AnimateDiff is viable, try to generate an image with SDXL as you normally would, but set the batch_size to ~16. That is how much VRAM (and GPU power) it would take.

But hypothetically, you could create an SDXL-compatible motion module that has a sweet spot/works well with less latents at a time, and then use a sliding window (which I'm going to be pushing to main branch later today), and that could potentially work.

All of that was way over my head , lol!
Thanks for now I'll use 1.5 maybe some else sees this and knows what they are doing.

Np, I will keep this issue open until I add the SD1.5 model check with a helpful error message.

Added SD1.5-based model check in commit to develop: https://github.com/Kosinkadink/ComfyUI-AnimateDiff-Evolved/commit/1bf6cdfb2c44203a45936a77eb3d618a6c41c327

Merged into main now, closing.


Require prooph/service-bus v6

resolves https://github.com/prooph/psb-http-producer/issues/2

Coverage remained the same at 89.362% when pulling cb042b937fcc046051c63272282d963e9938d39a on service-bus-v6 into 95503d96214d3a61aa0c9252e4d21d089604b6b1 on master.


Improve test coverage

66%

Coverage report: 72%

Coverage report: 74%

Amazing, thanks.
From 63% to 74%!


https://github.com/WasmEdge/WasmEdge/pull/2425

Hello, I am a serverless review bot on flows.network. Here are my reviews of changed source code files in this PR.

plugins/wasmedge_httpsreq/httpsreqfunc.cpp
The code appears functional but has some potential issues that can be improved.

Error handling
While error handling is done in some cases, such as checking for null pointers and handling failed SSL functions, there are other parts where error handling can be improved. For instance, when calling socket(), connect(), SSL_write(), and SSL_read(), the return values should be checked for errors and appropriate messages should be logged or propagated.

Resource leaks
In cases of unhandled errors, resources allocated to 'Addr' may not be freed, leading to memory leaks. The code should ensure freeaddrinfo(Addrs) is called in all cases, including on error conditions.

Missing include files
Some functions such as spdlog::error(), getaddrinfo(), and ERR_print_errors_fp() may not have been declared or included in the provided code snippet. Ensure you have the required include files for these functions.

Buffer size
Currently, the buffer size for SSL_read() is hardcoded to 1024. It would be better to declare this as a constant or allow the user to provide a buffer size.

Namespace
It would be useful to add comments about the purpose of the WasmEdge and Host namespaces.

Function naming
Function naming can be inconsistent. For example, WasmEdgeHttpsReqGetRcvLen is using camel case, while other functions like WasmEdgeHttpsReqSendData are not. Consider adhering to a consistent naming convention.

Overall, the code appears functional but can benefit from improved error handling, cleanup, and consistency.
The patch introduces the following key changes:

Addition of an include statement for the openssl/tls1.h header file.
#include <openssl/tls1.h>

Addition of a call to SSL_set_tlsext_host_name() function before the SSL_connect() call.
SSL_set_tlsext_host_name(Ssl, Host);

Improved error reporting when SSL_connect() fails by introducing a variable 'Code' to store the returned error code from SSL_get_error() function, and changing the logging message to log the error code.
const int Code = SSL_get_error(Ssl, Status);
ERR_print_errors_fp(stderr);
spdlog::error("[WasmEdge Httpsreq] SSL_get_error code {}", Code);

cc https://github.com/WasmEdge/WasmEdge/pull/2425

Flows summarize


[question] How to detect tag update completed and element displayed?

For the example, I should set the timeout 200 ms and focus input
http://jsfiddle.net/7b1qymd9/

Use the updated event.
https://github.com/muut/riotjs/blob/master/doc/api/tags.md#events

@AndreasHeintze
Thanks for the reply, but still unable:
http://jsfiddle.net/7b1qymd9/1/

You missed the letter d in "updated".
http://jsfiddle.net/7b1qymd9/2/

@AndreasHeintze
oops my bad, but update is useful, thanks for the answer :)


[Feature request] Seperate section for folder

We have a section for file and workspace anchors.

But having a folder anchor will help too, where we can get the list of all the anchors from the active root folder.
In the current scenario, showing all the folders in the workspace section is kinda confusing.

Similar to #37?
How would the "folder anchor" behave?

@lonix1 It's not similar to issue #37.


Have test:browser running on Github Actions

We need to allow for browser smoke tests to be carried out.
For this to happen, we need a tweaked self-runner instance that can run a headless chrome.

This might not longer be needed due to the software already included in the ubuntu-latest public runner: https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md
Keeping this open until confirmation can be made


Epic Roadmap (beta) appears when Epics are disabled.

I have the Feature Timeline and Epic Roadmap extension (previously just the Feature Timeline) installed.  Today I notice a new "Epic Readmap (beta)" button.  We have Epic work items disabled and the backlog configured to only show backlog items and features (not the epic level).  Given that epics are off (more precisely the epic backlog level is off), the Epic Roadmap should not appear.
Browser
Choose a browser
[ ] IE11
[x] Chrome - Version 67.0.3396.99 (Official Build) (64-bit)
[ ] FireFox
[ ] Safari
Version
[x] VSTS
[ ] TFS 2017 Update 2/3
[ ] TFS 2018

Thanks for reporting the concern. At this point there is no good way to hide the tab when Epics are disabled. I can show a message when user switches to the tab, but I am not sure if that will help.
Please let me know.

Another way to address the issue would be to put the new tab only on the Epic backlog.  At the same time, you could put the Feature Timeline only on the feature backlog.  That way, when I'm looking at the feature backlog, I can switch to the timeline.  When I'm looking at the Epic backlog (which requires it to be enabled), then I can switch to the Epic Roadmap.
It always seemed strange to me that that when I'm looking at the requirements level, the tab for Feature Timeline shows up.  I'm not at the feature level, so why is the tab there?
Having each tab show only at the appropriate level would address this issue.

If you can't hide the tab, can you at least hide the dropdown?

I just pushed an update which will not show the dropdown when team do not have any epics.
Sorry for late response, I am little busy these days.


Add a Swagger schema

It would be nice to have a Swagger schema for the Jolokia protocol, which could help in documenting it and trying it out.
You should look at the examples since the official documentation seems to be a bit outdated.
More Links

Product Paget: http://developers.helloreverb.com/swagger/
Demo: http://petstore.swagger.wordnik.com/

This would be a great feature to have. Besides being able to generate clients in all languages that swagger supports, it also provides a convenient web-gui to execute the rest calls. So you get an out of the box JMX web GUI for your application.
On a slightly separate note, is there some simple light-weight HTML gui for jolokia you'd recommend that I can host along side it which gives me an html interface to jolokia. I see you've recommended hawtio somewhere - I haven't looked at it in detail yet but seems too heavyweight, whereas I'm looking for something very cheap probably a single/few html/js files that understand the jolokia interface. That's really what I'm after atm.
Thanks,
Abhi

Unfortunately, there is none yet. There was one planned called Aji, but it never took off.
sorry.

Any progress on this?

@DebbautSara sorry, there are no plans yet to implement that but would be happy to support any Pull Request for this feature.


Make a gateway for actuators

Simple gateway that sends a CAN message to control clamps

Will only be controlling "actuator" / "servo" boards, with a possibility to send an angle target for one servo of one board, or to set to 1  or  a pin of a board (for pump/valve control).

Closed with #65


Push missing TEI doc updates through the pipeline

TEI documents have not been updated since October.
I have since resolved the problem that stopped updates working, but now I need to help the documents that were edited during the outage, through the pipeline.

The first step was to hide tei_tree.json, so that it the adapter would not ignore changes. This has worked.

A log entry:
14:55:45.899 [main-actor-system-akka.actor.default-dispatcher-7] INFO w.p.transformer.TransformerWorker - TransformerWorker: from Version(Egyptian_MS_1,3) transformed work with id Work[tei-manuscript-id/Egyptian_MS_1]; already in pipeline so not re-sending

It looks like the dedupe stuff in TransformerWorker has filtered them out.

A good example is https://wellcomecollection.org/works/xa8fe4ux - MS Japanese 17.
The description on the site starts "Manuscript concerning acupuncture..."
The description in TEI starts "A manuscript concerning acupuncture..." (in this change)
works-source-2023-06-01/_doc/Work%5Btei-manuscript-id%2FMS_Japanese_17%5D has the "A" at the start.
works-identified-2023-06-01/_doc/xa8fe4ux does not.
So it is evident (from log and pipeline indices) that this has been stopped at the end of transformer.

related slack: https://wellcome.slack.com/archives/C02ANCYL90E/p1685972741355309

In the slack thread, I guessed that it might be to do with a timing clash between creating the new pipeline/reindexing everything, with me fixing the fault at the adapter end.
This is not the case,  I fixed it on the 2nd, the index is from the 1st.

Since it has made it through the transformer, perhaps I could try emulating the message sending part at the end of the transformer.

Or deleting the TEI documents from works-source and reindexing?

Actually, since the New Way of Defining Indices is about to go on main, I could just create a new pipeline and run a full reindex.


curl: (60) SSL certificate problem: self-signed certificate

Hi Shahana,
when I use clnrest with rest_protocol=http, everything works fine.
But when I use the default https protocol, I can't do POST requests with curl (I also tried with Python and the library requests) without ignoring the self-signed certificate.
You can check this by running the following (assuming we have lightning and clnrest repository cloned locally in the current directory):
$ source lightning/contrib/startup_regtest.sh
$ start_ln
$ l1-cli plugin start $(pwd)/clnrest/clnrest.py
$ curl -X  'POST' 'https://<IP_ADDRESS>:3010/v1/getinfo' -H 'accept: application/json' -H 'Rune: xxx' -H 'Nodeid: xxx' -H 'Content-Type: application/json' -d '{}'
curl: (60) SSL certificate problem: self-signed certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
$ curl --insecure -X  'POST' 'https://<IP_ADDRESS>:3010/v1/getinfo' -H 'accept: application/json' -H 'Rune: xxx' -H 'Nodeid: xxx' -H 'Content-Type: application/json' -d '{}'
{"id": "03fb4ef67aa659e39a812ac15cc15d7387ff4625dcaf416fd50216eefb5b7f848e", "alias": "GREENSET", "color": "03fb4e", "num_peers": 0, "num_pending_channels": 0, "num_active_channels": 0, "num_inactive_channels": 0, "address": [], "binding": [{"type": "ipv4", "address": "<IP_ADDRESS>", "port": 7171}], "version": "v23.05.1", "blockheight": 2, "network": "regtest", "fees_collected_msat": "0msat", "lightning-dir": "/tmp/l1-regtest/regtest", "our_features": {"init": "08a0000a0269a2", "node": "88a0000a0269a2", "channel": "", "invoice": "02000002024100"}}

I have no idea why is this.

@tonyaldon Thank you for testing.
It is expected behaviour from curl as, by default, it expects certificates to be signed by a trusted certificate authority.
Currently clnrest follows below steps to use/generate certificates:
1 - If the rest-certs path is set in config, search for the certificates at the location.
2 - Else, search at the default location (current working directory), where cln-grpc's generated certificates reside.
3 - If certificates are missing at the configured/default location, create self signed certificate and use them.
Certificates generated by either cln-grpc/clnrest are self signed and will not be recognised by curl. Some possible options are:

Use trusted certificates: Configure rest-certs path with trusted certificate location.
Trust the certificate: Instruct curl to ignore the certificate verification with the -k or --insecure, which you already did.
Add the certificate to the trusted list: Use the --cacert option to specify the trusted certificate. For example
curl --cacert /path/to/client.pem -X POST 'https://<IP_ADDRESS>:3010/v1/getinfo' -H 'accept: application/json' -H 'Rune: xxx' -H 'Nodeid: xxx' -H 'Content-Type: application/json' -d '{}'

Closing this issue now.

Thanks for the explanation. I'll try to use a trusted certificate with rest-certs option.


Would like to explore setting up caddy-auth-portal using PortalGuard IdP Product

Hi @greenpau!
I was excited to see this module available for Caddy v2 when I was looking through the list of modules on the download page over the past weekend, specifically because I'd like to explore using it to help create "intranet" type sites (protected by authentication before being able to access the page) using Caddy's built-in file_server / templates directives.
I know the examples in the README specifically seem to cover some more advanced use cases (e.g. using caddy-auth-portal to protect Prometheus for example), but I'm not sure if there's an example that covers the scenario above (I'm sure it's probably not too complicated and I can figure it out, but might be helpful to have an example of that use case if it's possible).
Additionally, my organization uses the PortalGuard IdP product which supports multiple protocol options (CAS, SAML, and OpenID Connect). At the moment it seems like OpenID Connect might be the simplest one to use with caddy-auth-portal, but I'm happy to try out SAML as well (I don't think CAS is a current option from what I saw).
I'm not sure if you have any extra starting tips aside from what's in the README (I only have time to read through it at the moment but won't get to get in depth and run some tests until later today or over the weekend), but if you do please let me know and perhaps once I have a working solution I can share any tips I learn back to have notes for that specific IdP if it's of interest to include in the README.
If you do have a quick yes/no answer related to whether I can use caddy-auth-portal to secure a simple Caddy-powered static site using the file_server / templates directives though that would be helpful just to make sure I don't work through this and then find out that use case isn't supported.
Thank you!

@orware , the examples are here https://github.com/greenpau/caddy-auth-portal#usage-examples


Archive Alumnis

Clean up but still store somewhere (archive) alumni profile and hours. This way the admin view would be cleaner since there are little uses for them. But it is still imo important to have backups.

let's move it to a separate table


HasRoleDirective and Refactoring

HasRoleDirective improved
AuthGuard  renamed to HasRoleGuard
SimpleAuthGuard renamed to AuthGuard
moved guards and services into own directories

I'm fine with this, so feel free to merge :)

Hey thanks for your contribution, the im happy to see the improved HasRole directive!
But I also noticed that you have renamed public API Members (the auth guards) which will break all existing code and thus I am hesitant of merging this. For now I would prefer that you rollback the renaming in this PR so that we can discuss it first and handle it in another PR separately.
The renaming would have to be made in a way that does not break existing code, instead we would just mark some selectors as deprecated.
Btw, the moving of the services / guards in other directories is fine as it has no effect on the public API.

Mh, I was thinking of the public api aspect as well, but since configuration has already changed a lot and the version is going to be bumped to `2.0, I figured "what's the harm?" But alright, if you prefer to stick with previous names...

You are right, especially because this is a beta version.
The problem is that at least we use the beta version internally in a number of projects already, so it would really break stuff for us, and I would like to avoid this for now. 😄
But we can certainly discuss better names and come up with a migration.

reverted renaming of SimpleAuthGuard (from AuthGuard)
added deprecated AuthGuard as copy of HasRoleGuard

In my point of view AuthGuard should be called HasRoleGuard to be consistent with HasRoleDirective.

Ok, fine with me now.

Added inversions:

added HasNotRoleGuard and HasNotRoleDirective
added HasNoRolesGuard and HasNoRolesDirective
adjusted PrincipalService and AuthService accordingly


invalid index to scalar variable

i tried running it and got the following error.
╰─$ py opencv_dnn_infer.py --img-path /home/<name>/Pictures/Webcam/2021-11-12-101657.jpg
Traceback (most recent call last):
  File "opencv_dnn_infer.py", line 117, in <module>
    run_on_video(Net, video_path, conf_thresh=0.5)
  File "opencv_dnn_infer.py", line 89, in run_on_video
    img_raw = inference(Net, img_raw, target_shape=(260, 260), conf_thresh=conf_thresh)
  File "opencv_dnn_infer.py", line 47, in inference
    y_bboxes_output, y_cls_output = net.forward(getOutputsNames(net))
  File "opencv_dnn_infer.py", line 41, in getOutputsNames
    return [layersNames[i[0] - 1] for i in net.getUnconnectedOutLayers()]
  File "opencv_dnn_infer.py", line 41, in <listcomp>
    return [layersNames[i[0] - 1] for i in net.getUnconnectedOutLayers()]
IndexError: invalid index to scalar variable.

help plz.

nvm somehow i is a scalar now so just remove the [0]

Why I need to remove [0] in windows 10, but in Jetson TX2 some devices need to remove some don't need remove.


Website with Creation

Added forms as well as posting files for each form to connect to MySql Database.

Can you remake the branch/PR?  Instead of copy pasting my code into your branch, we can do one of two things:

Accept my PR into the main branch.  Then, remaking your branch will place all of my changes into your branch
Make a new branch but have it be based off of my branch.

The reason for this is that I am still making changes to my code and the copy pasting of code into your branch will make merging the branches more challenging than it needs to be.  Let me know if you need help doing this.


Version bump

Changes since release 0.38.0:

fix "persistent_cookie_path': undefined method tmpdir' for Dir:Class (NoMethodError)" for client.rb (#7179)

Going to merge this without review since it's a holiday weekend


Add np.polyadd numpy function

Part of #70
I'll add tests once I'm confident my current approach is correct. The PR implements np.polyadd for two one dimensional arrays or np.poly1d objects.

@jakevdp Thanks for the review! Quick question: Why do some functions in jnp use np.asarray, thus making them incompatible with @jit? Example: https://github.com/google/jax/blob/master/jax/numpy/lax_numpy.py#L2585
Should all these be replaced with jnp.asarray and other corresponding functions?

Why do some functions in jnp use np.asarray, thus making them incompatible with @jit?

I suppose jit wasn't a priority when those functions were implemented (or perhaps it wasn't clear that jnp.array(poly_1d) returned the right thing)

Actually, now that I think about it more, the isinstance check is fine, because it only comes into play when the input is a poly1d object, which is not compatible with jit anyway.
So I think either the old version or the new version is fine here.

I suppose jit wasn't a priority when those functions were implemented (or perhaps it wasn't clear that jnp.array(poly_1d) returned the right thing)

Ah, I see. I suppose we'd ideally prefer to replace all these calls then. Let me know if you'd like a seperate PR for that.

So I think either the old version or the new version is fine here.

Great, would love another review.

Done!

@jakevdp Added it to autosummary. Thanks for the reviews!

Looks good, thanks. Testing now...

Thanks for the contribution!

@jakevdp Thanks! Regarding our conversation on the usage of np functions in lax_numpy.py, should I open an issue/PR to replace them with corresponding jnp functions?

Unless you know of a specific issue where an existing function doesn’t compile, that’s not necessary: most functions have compilation tests in the test suite. To be clear, there is no issue with calling numpy functions per se, unless those functions are called on an input that will be traced by the jit compiler.


Javascript error occured in the main Process

While executing last sample url, got the error.
Attaching the screenshot of an error.

Steps performed: 1)npm install 2) electron app.js
OS: Windows
npm -v -  3.10.10
Node -v  v6.11.5

You need to pass the url as the parameter for url example


Support Structural Variants

For example, this VCF gives varcode trouble due to the non-sequence things in the ALT column:
#CHROM  POS     ID      REF     ALT ...
1       959526  xxx     T       <DEL> ...
1       4932289 yyy     A       <DUP:TANDEM> ...
1       8411313 zzz     A       <DUP:TANDEM> ...
...

Duplicate of https://github.com/hammerlab/varcode/issues/123


⚠ Bofrost.si has degraded performance

In 67222fc, Bofrost.si (https://www.bofrost.si) experienced degraded performance:

HTTP code: 200
Response time: 3273 ms

Resolved: Bofrost.si performance has improved in 7ddcc46 after 5 minutes.


Add translator hints & location comments to gettext catalogs

These new settings allow for adding string locations and custom comments into
translation catalogs, as hints for translators.
Resolves #1249

going to fix the options on the gettext-rails side...

gettext_i18n_rails fix here: https://github.com/grosser/gettext_i18n_rails/pull/145


Shouldn't relations in OSM be mapped to MultilineStrings in geojson instead of separate LineStrings?

I'm trying to covert a response from overpass to geojson and I want to know the bounding box of a relation. In current conversion I need to iterate on all features and group them by relation before I can do it... :-/

toGeoJSON converts from KML or GPX, not from OSM data - this is not the correct issue tracker for this question.

Sorry, my bad.


fix: quick openapi 3 parsing link fix (#1119)

fixes #1119.
To stop the bleeding.

Does not work, but #1120


Logo

Summary
New logo and link to docs in each package

https://github.com/godaddy/radpack/issues/9


Please make Embeds easier to use.

Title.
I have tried using embes to no avail.
{Embed}TypeLink;https://the-betweenlands.fandom.com/wiki/The_Betweenlands_Wiki{Embed}, TypeLink;https://the-betweenlands.fandom.com/wiki/The_Betweenlands_Wiki{Embed}, etc all do and display nothing.
Allow pressing a 'Embed' button that pastes the correct stuff with the link in the correct area.

You are missing the width/height/text fields ex;
{Embed}TypeLink;;;;{Embed}
so in your case;
{Embed}TypeLink;https://the-betweenlands.fandom.com/wiki/The_Betweenlands_Wiki;64;16;The Betweenlands Wiki{Embed}
I have no current plans on updating BQTweaker outside of critical bugs as I no longer have dev environments setup for 1.12.2

Give the older versions to someone else.
Would be nice if embeds weren't as annoying to use.


JS call from Python doesn't respect .toString() when coercing, can't call static member variables

Doing a JS call from python does not call to string:
class Vec3 {
 x = 0; y = 1; z = 2;
 toString() { return `${x},${y},${z}` }
}

prints as if no toString is present

Also:
class SomeClass {
  static hello() { return "world!" }
}

cannot be called in python as
SomeClass.hello()

this likely is because of https://github.com/extremeheat/JSPyBridge/blob/master/src/JSPyBridge/proxy.py#L158 -- what we could do is extend Proxy in here so normal property access continues to work, or add a isClass parameter to Proxy

For #1, I had second thoughts, I think it's best to require .toString(). Otherwise, we break print() statements where we actually want the inspect data.


Adding support for Demucs V2

Remove flags not longer supported (i.e. --dl which is now implied).
Use demucs_quantized model (only 150 MB for the same performance).
Trigger model download during image build, as location for pretrained models is no longer stored under the folder passed to --models, but inside PyTorch Hub cache.
Remove dependency on Anaconda image, as now only Python3 should be sufficient.

This is a fix for https://github.com/xserrat/docker-facebook-demucs/issues/1

I'll merge with https://github.com/xserrat/docker-facebook-demucs/pull/3
when we find a fix for the libsndfile issue :)

I've just replied in the PR #3 that it's not needed. Maybe we could add the git clone flags to only clone the main branch but feel free. Anyway, I would like to thank you and congratulations for your work that I think it's amazing (I love all the machine learning stuff but I'm a completely beginner 😅 ).
You can merge this pull request or I'll merge it in a few time!!!

Thanks @xserrat :)
I added the git flags from the other PR.


As a student planning for my modules, I want to be able to select from a various number of timetable slots for each of my modules. It would be even better if the software is able to suggest an optimum schedule for me.

Since we need to refrain from user clicking rather that user input, I think we need to brainstorm about how we can do this.

Maybe, since tutorial and lecture slots are number we can get them to select the slots they want by indicating the lecture/ tutorial slot.


webpack config recordPath is mandatory

Documentation Is:

[x] Missing
[ ] Needed
[ ] Confusing
[ ] Not Sure?

Please Explain in Detail...
Please mention in documentation that webpack config recordPath is mandatory to enable HMR in some cases.
I use HMR together with mini-css-extract-plugin and css-loader.
Took me a while to figure it out...
Your Proposal for Changes
Mention in Installation & Usage that webpack config recordPath might be mandatory when using together with other loaders

This isn’t something i’ve ever run into, and i’ve never set that config param.
If you can narrow down the scenario and why it’s needed, a PR would be accepted.

Here is my webpack config:
  const config = {
    mode: 'development',
    target: 'web',
    devtool: 'eval',
    entry: {
      app: [
        'webpack-hot-middleware/client?reload=true&timeout=60000',
        './src/client/index.tsx'
      ],
    },
    resolve: {
      modules: ['./src', './node_modules'],
      extensions: ['.js', '.ts', '.tsx'],
    },
    output: {
      path: '/static/',
      filename: '[name].js',
    },
    module: {
      rules: [
        {
          test: /\.tsx?$/,
          use: [
            {
              loader: 'thread-loader',
              options: {
                workers: cpus - 1,
                poolTimeout: Infinity,
              },
            },
            {
              loader: 'cache-loader',
            },
            {
              loader: 'babel-loader',
              options: {
                plugins: ['react-hot-loader/babel'],
              },
            },
            'webpack-module-hot-accept',
            { loader: 'ts-loader', options: { happyPackMode: true } },
          ],
          include: './src',
        },
        {
          test: /\.scss$/,
          use: [
            'css-hot-loader',
            MiniCssExtractPlugin.loader,
            {
              loader: 'css-loader',
              options: { sourceMap: false },
            },
            {
              loader: 'postcss-loader',
              options: {
                sourceMap: false,
                plugins: [
                  autoprefixer({
                    browsers: ['last 2 versions', 'ie >= 10'],
                    cascade: false,
                  }),
                ],
              },
            },
            {
              loader: 'sass-loader',
              options: { sourceMap: CSS_SOURCEMAPS },
            },
          ],
        },
        {
          test: /\.(ttf|eot|svg|jpg|gif|png|woff(2)?)(\?[a-z0-9]+)?$/,
          loader: 'file-loader',
        },
      ],
    },
    plugins: [
      new webpack.HotModuleReplacementPlugin(),
      new MiniCssExtractPlugin({
        allChunks: true,
        filename: '[name].css',
      }),
    ],
    optimization: {
      noEmitOnErrors: true,
      splitChunks: {
        name: true,
        cacheGroups: {
          vendor: {
            test: /[\\/]node_modules[\\/]/,
            chunks: 'all',
            name: 'vendor',
            enforce: true,
            reuseExistingChunk: true,
          },
        },
      }
    },
    performance: {
      maxEntrypointSize: 5000000,
      maxAssetSize: 3000000,
    },
  }

According to the note on https://github.com/webpack/docs/wiki/configuration#recordspath-recordsinputpath-recordsoutputpath this is something to do with the compiler being run multiple times, which is unusual.

Exactly, that's the case, I use my own file watchers with compiler.run and webpack-hot-middleware without webpack-dev-server in isomorphic app.
Also webpack-hot-middleware doesn't work together with memory-fs (as in official webpack example).

I'm going to close this issue as it doesn't seem to be related to hot-middleware specifically, and is a general webpack configuration issue in complex custom setups.


SSZ summary/expansion definition should reference signing_root

In cases where full objects contain signatures (currently only BeaconBlocks), the signing_root is used as a summary instead of the hash_tree_root. The definition of a summary should be expanded (lol) to include this edge case.
eg:
a block header:
{
  slot: Slot,
  parent_root: Summary(BeaconBlock), // signing_root
  state_root: Summary(BeaconState), // hash_tree_root
  ...
}

Yes, and we have a similar issue for partials; a root may represent the signing root of a Block; and although the two are compatible sometimes (sibling nodes don't tell anything about the field being ignored or not), the depth of the merkleization, along with convertability between the two roots are affected.

Closing this, we won't have a signing-root anymore to worry about :). See #1491


Bump version for azure rulesets 0.42.1

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/898/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/898/


Some refactor and clean up with KeyBinding and EntryListWidget$Entry

Signed-off-by: shedaniel<EMAIL_ADDRESS>

updated to 20w20a

Fyi the build fails because of a network connection issue to jcenter. Mind restart that build for java 11 to fix it.


Bgm

BGM for load, tutorial island, and lumbridge
Settings button opens audio page
Volume can be adjusted and saves
Inventory button closes audio settings and opens inventory

How much work would it be to get an older sound settings image that doesn't have the bond image in the lower right corner?

How much work would it be to get an older sound settings image that doesn't have the bond image in the lower right corner?

What used to be there? If it was nothing I could edit it out

I can't find a picture of it, so I guess we will leave it as is.


can't connect to localhost:8443

I run  ./code-server . and it returns like

then I try to connect to  localhost:8443 .

it is really hard for me to figure out what's wrong here..please help!

Are you running code-server on your own computer or on a separate device?

@oonqt I am running code-server on a remote server, which I have to ssh to a jumper server(I don't have root) and then ssh to the remote server.

That's your problem. Localhost refers to your local machine, you cannot use it to access external machines. If you want to access code-server on your remote server, you need the IP address of your remote server.

你要輸入 remote server 的IP地址如
http://<IP_ADDRESS>:8443
防火墻也記得開啟 TCP 8443端口

Closing since the question was answered.


Increase release quota in large tiers

Increase from 1024 to 4096 and generate the tiers for both staging and production.
KFLUXSPRT-1038

This change is big because of generated files, the changes to review are in components/sandbox/tiers/src folder

/lgtm


Video retire and redirect only

@pebaum The retire and redirect only portion of ADO task 5627155.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

please do not merge this pr - we're waiting on other changes before this should go live


Keystone build failure (static/mixed/dynamic CRT/CMake).

Host Environment

OS: Windows
Compiler: MSVC/MSBuild

Failure logs
-- Performing post-build validation
Invalid crt linkage. Expected Debug,Dynamic, but the following libs had:

    C:\Sources\vcpkg\packages\keystone_x64-mixed\debug\lib\keystone.lib: Debug,Static

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Invalid crt linkage. Expected Release,Dynamic, but the following libs had:

    C:\Sources\vcpkg\packages\keystone_x64-mixed\lib\keystone.lib: Release,Static

Additional context
I'm using a custom triplet file like so:
# x64-mixed.cmake
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)

if(UNIX)
    set(VCPKG_CMAKE_SYSTEM_NAME Linux)
endif()

if(${PORT} MATCHES "mimalloc")
    set(VCPKG_LIBRARY_LINKAGE dynamic)
endif()

Inside my project's CMake file:
# Use the custom triplet for Vcpkg.
set(VCPKG_OVERLAY_TRIPLETS "${CMAKE_SOURCE_DIR}/triplets")
set(VCPKG_TARGET_TRIPLET "x64-mixed")

And for building:
// From build directory:
cmake .. -G "Visual Studio 16 2019" -T host=x64 -A x64 -DCMAKE_BUILD_TYPE="Release"
cmake --build . --config "Release"

This issue also exists on x64-windows-static-md. I will fix this soon.


BPMSPL-234: Add Russian locale, BPMSPL-256: Add Traditional Chinese locale

BPMSPL-234: Add Russian locale
BPMSPL-256: Add Traditional Chinese locale

+1 to merge... I wonder who I could ask to review my PRs... ;)

master: ca7ba9a5a29a47d52fe9a47770dbbe7769e7c33d


Empty chunks

What version of Remix are you using?
1.7.5
Are all your remix dependencies & dev-dependencies using the same version?

[X] Yes

Steps to Reproduce
We seem to be getting "empty" chunks in our build like this:
import{b as o}from"/build/_shared/chunk-2LOM2E4Y.js";var p=o((r,e)=>{e.exports={}});export{p as a};

I think this is happening when we have server only files, who's types are being referenced in our client.  In this case its api.queries.server.ts, generated by pg-typed, and used in our loaders to pull data from the db, and then the return types show up in the loader types when consumed by the client.
Expected Behavior
I expected no chunks to be produced when the chunks are empty
Actual Behavior
Many effectively empty chunks, reducing web performance, causing the browser to make many many requests for tiny unnecessary files

We already have a proposal to address this in https://github.com/remix-run/remix/discussions/5195


bug with readOnly and vendor extensions in properties

issue:
https://github.com/swagger-api/swagger-parser/issues/301

readOnly added in #364, the vendor extensions support you added isn't legal in the spec :(


Upgrade modernisation-platform-terraform-s3-bucket to remove deprecated configuration

User Story
As a modernisation platform engineer
I want to refactor a deprecated configuration option
So that this module stays compliant with the current AWS provider
Value
From v4.3.0 onward, the prefix block of the s3_bucket_lifecycle_configuration has been deprecated. By refactoring our code to accommodate this change now we can avoid any detrimental changes in future when this configuration option is removed.
Questions / Assumptions

This change will not take a significant amount of time to action.
This change can be conducted without user impact
Make sure the lifecycle config for versioning is still there

Definition of done

[ ] modernisation-platform-terraform-s3-bucket module updated
[ ] modernisation-platform-terraform-s3-bucket module has new tag release
[ ] downstream references to this module are updated
[ ] tests are green

Reference
How to write good user stories
AWS Provider v4.3.0 Changelog

This was solved here: https://github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket/pull/24


Bump python version from 3.7 to 3.8

This PR bump python to version 3.8.
The procedure to migrate locally is available in the Wiki.

You're welcome :)


TestClient: how to test overwrites in the Config of an input (pydantic) model?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
###### fastapi_extra.py
import fastapi
from pydantic import BaseModel

class MyModel(BaseModel):
    i: int

    class Config:
        extra = "ignore"

def create_app():

    app = fastapi.FastAPI()

    @app.post("/")
    def test(m: MyModel):
        return [m.i, MyModel.Config.extra]

    return app

########### test_fastapi_extra.py
import pytest
from fastapi.testclient import TestClient

import fastapi_extra

# overwrite from "ignore" to "forbid"
fastapi_extra.MyModel.Config.extra = "forbid"

@pytest.fixture
def test_app():
    yield TestClient(fastapi_extra.create_app())

def test_root(test_app):
    # send a message with an additional attribute
    r = test_app.post("/", json={"i": 2, "foo": "bar"})
    assert r.json() == [2, "forbid"]
    assert r.status_code == 200  # this should be 422 then!

Description
I would like to ensure that the models/queries used in my pytests are up to date with the code. Hence, the goal was to set the Config.extra parameter to "forbid" in the pytests.
Note that the original application requires "ignore" to not break production. So "forbid" should only be used within the tests.
pytest test_fastapi_extra.py
should raise an error but does not... so weirdly enough the model config is set to "forbid" but the extra fields do not cause an unprocessable entity error.
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.74.1
Python Version
3.9.7
Additional Context
pydantic 1.9.0
pytest 7.0.1

If every someone comes accross this problem. The solution was to use the values provided by pydantic.Extra instead of the strings for "forbid" and "ignore". This works as expected.
Unfortunately the documentation in pydantic mentions that you could use either the string or the enum but apparently they are not working the same way.
###### fastapi_extra.py
import fastapi
from pydantic import BaseModel, Extra

class MyModel(BaseModel):
    i: int

    class Config:
        extra = Extra.ignore # use the enum provided by pydantic here instead of "ignore" string

def create_app():

    app = fastapi.FastAPI()

    @app.post("/")
    def test(m: MyModel):
        return [m.i, MyModel.Config.extra]

    return app

########### test_fastapi_extra.py
import pytest
from fastapi.testclient import TestClient
from pydantic import Extra

import fastapi_extra

# overwrite from Extra.ignore to Extra.forbid using the enums again!
fastapi_extra.MyModel.Config.extra = Extra.forbid

@pytest.fixture
def test_app():
    yield TestClient(fastapi_extra.create_app())

def test_root(test_app):
    # send a message with an additional attribute
    r = test_app.post("/", json={"i": 2, "foo": "bar"})
    assert r.status_code == 422
    assert r.json() == {
        "detail": [
            {
                "loc": ["body", "foo"],
                "msg": "extra fields not permitted",
                "type": "value_error.extra",
            }
        ],
    }

Thanks for reporting back and closing the issue 👍


Improve compatibility with Apache Superset by showing CrateDB table metadata in the SQL Lab editor

Hi,
this patch is a refresh of 0212487e, 8dfcf807, efe8bfb contributed by @Aymaru on behalf of #395.
According to the description of the original pull request, it aims to improve compatibility with Apache Superset by returning a list instead of a set from get_pk_constraint(). Otherwise, Apache Superset would not show CrateDB table metadata in the SQL Lab editor.
With kind regards,
Andreas.
P.S.: The patch has not been verified together with Apache Superset yet. Maybe you can have a look, @rafaelasantana, @hammerhead or @proddata?
Installing the code from the corresponding development branch conveniently would work like this:
pip install --upgrade "git+https://github.com/crate/crate-python@amo/fix-apache-superset-metadata#egg=crate[sqlalchemy]"

With this patch, we are observing a regression. Where the primary key information was able to be inspected beforehand, with the patch it does not.
You can see this on those screenshots.
Before

After

Hm. @proddata pointed out that the documentation of get_pk_constraint clearly states:

Given a Connection, a string table_name, and an optional string schema, return primary key information as a dictionary with these keys:

constrained_columns: a list of column names that make up the primary key.
name: optional name of the primary key constraint.

So, I figure that returning constrained_columns as a list should cause no troubles. Instead, it should be compliant with the specification even better.
Why would it stop working with Apache Superset then?

Dear @Aymaru,
can I humbly ask you to have a look at this patch again? I am wondering if I correctly captured the gist of that part of your patch, which was originally submitted at #395.
Maybe you can observe a flaw here, or maybe you have another explanation for the behavior of Apache Superset on this matter. Any help or support will be greatly appreciated.
With kind regards,
Andreas.

I've probed this once more to make sure it is the correct outcome.
Before
Without this patch, table metadata is displayed.

After
When running with this patch, table metadata stops being displayed.

Dear @Aymaru,
based on my findings above, we will not bring in this part of the patch #395 you submitted the other day.

Right now, we are actually observing the opposite behavior with this patch: It works without, but doesn't when applied.
Maybe Apache Superset has advanced in this area in the meanwhile?

I will have a look at the other parts of your PR on behalf of a different patch.
With kind regards,
Andreas.


Help for Cross Reference

The help menu shows a new window that explains how to use cross-reference. There might be some typos in it since it is not consistent.

Getting started
Add labels to figures by creating a link with url '#figur_name' (replace 'name' with your chosen name). Add references as links with url '#fig_name'. Goto 'Help → Learn More' for complete instructions (HIGHLY RECOMMENDED)

I guess it supposed to be this way. I thought there were some typos in #figur_name vs #fig_name.


NIFI-1697 Ensuring FlowController appropriately wraps code with NarClosable

From debugging this issue it was noticed that the problem only occurred while a PutHDFS processor was enabled (running/stopepd), but if it was disabled the problem went away. This led to realizing that when the processor is running or stopped, validation is being called and was not being wrapped with NarCloseable to ensure the validation uses the same classpath as the component uses when executing.
This PR ensures that the FlowController wraps validation with NarCloseable, and also when calling OnPrimaryNodeStateChanged which needed to be wrapped as well.

Revieiwng....

+1 Looks good. Merged to master and the support/0.6.x branch. Thanks!


dscal is not a function

Description
Encountered an error when calling chi2gof with a unity probability array.
Related Issues
No response
Questions
No.
Demo
No response
Reproduction
chi2gof([135017, 1533, 13450], [0.9, 0.01, 0.09]);

Expected Results
No error.

Actual Results
dscal is not a function
TypeError: dscal is not a function

### Version

0.0.7

### Environments

Node.js

### Browser Version

_No response_

### Node.js / npm Version

_No response_

### Platform

_No response_

### Checklist

- [X] Read and understood the [Code of Conduct](https://github.com/stdlib-js/stdlib/blob/develop/CODE_OF_CONDUCT.md).
- [X] Searched for existing issues and pull requests.

When passing simulate: true it gives another error:
dsumpw is not a function

Hey there,
To allow us to reproduce the issue, could you please let us know how you are consuming the chi2gof package?
Are you loading one of the pre-built bundles, have you installed the entire library ( npm install @stdlib/stdlib) or just the package (npm install @stdlib/stats-chi2gof) from npm, or something else?

@Planeshifter, I took a look more in-depth, and it seems to have something wrong here:

Notice that the blas-ext-base-dsumpw imports addon.node that doesn't exist in the distribution. The same happens for the daxpy, dscal e dsumpw:

Investigating even further, it seems a generalized issue with all @stdlib/blas-* packages.

Thanks for investigating!
I can reproduce the issue using ts-jest. We will discuss internally how to resolve it in due time and post any updates to this thread.
In the meantime, a temporary solution for you would be to add the following to your Jest configuration
  moduleNameMapper: {
    '^@stdlib/blas(.*)$'<EMAIL_ADDRESS>  }

This would ensure that Jest doesn't try to load the missing native add-ons for the blas packages but defaults to the JavaScript implementations (I have created a test repository here.)

@marcospassos Able to track down the issue, which was due to realms and failing instanceof checks. Fix committed to main branch. Should be available to individual packages once we do another standalone package release.

Thank you, @kgryte!

Patches have meanwhile been released for the affected blas packages. The problem should now be resolved when installing @stdlib/stats-chi2gof anew.


JetPack -> Modifiers -> Actions: 	 Modifier.triStateToggleable(     state: ToggleableState,     enabled: Boolean,     role: Role?,     onClick: () -> Unit )

Doc: https://developer.android.com/reference/kotlin/androidx/compose/ui/Modifier#(androidx.compose.ui.Modifier).triStateToggleable(androidx.compose.ui.state.ToggleableState,kotlin.Boolean,androidx.compose.ui.semantics.Role,kotlin.Function0)
Configure component to make it toggleable via input and accessibility events with three states: On, Off and Indeterminate.

How to handle ToggleableState (it's just three values: On, Off, Indeterminate)


Termgram doesn't recognize mi international phone number

Hi Enrico.
Termgram doesn't recognize mi USA phone number. It says:
"Hey, this is not an international phone number!"
If I put a '+' char before number, it says:
phoneNumber: +1XXXXXXXXX
sendCode result: { id: "d951edef", typeName: "api.type.auth.SentCode", phone_registered: { id: "b5757299", typeName: "api.type.BoolTrue" }, phone_code_hash: "b489376c298d1e463f", send_call_timeout: 120, is_password: { id: "379779bc", typeName: "api.type.BoolFalse" } }
nothing to do, now...
Which format must have an international phone number?

Ouch. I see: https://github.com/enricostara/termgram/issues/4
Thanks


Uncaught Error: tunneling socket could not be established, cause=write ECONNRESET

[Enter steps to reproduce:]

... Open settings
... Click on "Packages"

(I wouldn't call these "steps to reproduce" since it only happened once and I can't get it to happen again)
Atom: 1.15.0 ia32
Electron: 1.3.13
OS: Microsoft Windows 7 Enterprise
Thrown From: Atom Core
Stack Trace
Uncaught Error: tunneling socket could not be established, cause=write ECONNRESET
At stream.js:74

Error: tunneling socket could not be established, cause=write ECONNRESET
    at ClientRequest.onError (/app.asar/node_modules/tunnel-agent/index.js:176:17)
    at ClientRequest.g (events.js:286:16)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:308:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at onwriteError (_stream_writable.js:319:10)
    at onwrite (_stream_writable.js:337:5)
    at WritableState.onwrite (_stream_writable.js:89:5)
    at fireErrorCallbacks (net.js:463:13)
    at Socket._destroy (net.js:504:3)
    at Socket._writeGeneric (net.js:706:17)
    at Socket.<anonymous> (net.js:663:12)
    at Socket.g (events.js:286:16)
    at emitNone (events.js:91:20)
    at Socket.emit (events.js:185:7)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1068:10)

Commands

Non-Core Packages
ide-purescript 0.15.3
language-purescript 0.8.2
linter 1.11.23

Thanks for the report!

(I wouldn't call these "steps to reproduce" since it only happened once and I can't get it to happen again)

Since it's not reproducible, I wonder if this was just a temporary network issue?  I'll go ahead and close for now but if it ends up being a repeatable error for you, please let us know.


SetRequestProcessingLimits support?

Is there a way to limit the max number of actual processing requests w/o accepting new requests from the listener? The similar thing what was implemented in Katana by calling "SetRequestProcessingLimits" ?

No, there is no matching setting.

@shirhatti at some point we're going to need to consider some form of back pressure here to keep from completely flooding the thread pool queue and memory.


Moved smartbridge label icon to the front

I liked the addition of the smartbridge label by dated (#250), but the placement results in the labels swerving around a bit due to the difference in space a transaction ID takes up:

Therefore a proposed change: move the label to the front to keep it more consistent:

It also adds an empty div to fill up the space of the icon if there is no smartbridge text to keep the transactions in line:

Open to discussion 😄

I thought about this as well, the problem i saw is that when there are no transaction with smartbridge then there is a karger nargin on the legt van on the right. Does this take care of that case?

At the moment it doesn't check for that, but I think it should be easy enough to add. First thing that comes to mind is to simply go over the list of transactions that we have for a given page (as it's 25 max) and check if any contain a smartbridge message. If so; do the current magic with the label, if not: remove the empty div to ensure that we don't have the extra empty space :)

My thoughts exactly, if you have time you can take care of it, i'm on the road for the next few hours :)

I can take a look later today, but if you have the time to fix it before that; just go ahead

I don't think you need another prop for it. Should be possible to use your show-smartbridge-icon prop for this purpose too

yep, i stand corrected. got a solution, but then there's this problem:

What's the problem :p

ID and address are not aligned :D

Id and icon are :P
Personally I find that better looking than the swerving of the label when you put it after the transaction id
Or try increasing margin when one of the transactions contain a smartbridge text, to align it with the number again


Path params doesn't work for ports

From<EMAIL_ADDRESS>on November 26, 2013 10:04:35
E.g.
get("http://localhost:{port}/sns/{resource}/size 8765, resource);
It work in releases prior to 1.9.0
Original issue: http://code.google.com/p/rest-assured/issues/detail?id=275

From<EMAIL_ADDRESS>on December 31, 2013 09:04:11
Status: Fixed


LaTeX Packages and Custom Environments/Commands

Is your feature request related to a problem? Please describe.
Certain LaTeX environments aren't available by default. Normal I would use \usepackage{} but that doesn't seem to be possible in markdown files (for blog posts). I would like to have access to the 'theorem' environment and \newtheorem command found in the 'amsthm' package, for example (among others, of course).
Describe the solution you'd like
Some sort of Mathjax header file where I could call all the packages I need and define any custom environments/commands globally.
Describe alternatives you've considered
The ability to call packages in markdown files would be sufficient too. Worst case, I could copy paste the would-be header in each post.
Additional context
It's possible to define macros in markdown files with $$\newcommand{[macro]}{[command]}$$ but it does not seem possible to call packages.

@taxminion, MathJax does not support arbitrary latex, it only supports equations. Are you asking for arbitrary latex support?
FYI, I've experimented with arbitrary latex support previously. LaTeX.js provides such support. You can see a demo example. Let me know if such latex support is something you are looking for.

I've not come across LaTeX.js before, looks interesting. Might have to play with this at some point. Thanks for letting me know about it! Unfortunately no TikZ support tho :(

Btw, Pandoc might be relevant here. Convert latex to MD and then include the MD. Probably easiest to do the conversion outside of the jekyll build, but maybe it could be interesting to run pandoc on files in a directory before the jekyll build.


feat(PlaylistManager): add .setName() and .setDescription() functions for editing playlists

Nice work. Thanks!


[Question] How do we update following the newest master branch?

Hello there!
I used the new tool to setup, and the setup was mostly smooth (need to rerun when I did some typos).
My question is that, do we need to update it, and how? For example, do we just git pull, or is there a script that does this?

I did not updated yet in my production servers... but I will do so and I will update this issue to keep it here for reference.

Here it goes!!! Just updated my first production server and it was smoothly done!
Please follow:
https://github.com/evertramos/nginx-proxy-automation/blob/master/docs/upgrade-guide.md


[first cut/WIP] Left overs + cleaning up carmen-cache

Worked on cleaning carmen-cache this weekend:
We no longer use normalization-cache in carmen. Opening this PR to remove normalization cache along with simplifying carmen-cache that would involve:

[ ] using the write to disc pattern that we used for fuzzy-phrase, so as to be able to remove duplicative code in memory.cpp and rocksdb.cpp
[ ] (stretch goal) split NAN_METHOD() from the C++ code in order to be able to easily get C++ to talk to rust through C

cc @apendleton, @aaaandrea (since both of you have worked extensively on carmen-cache)

Stale; work on this proceeded instead in https://github.com/mapbox/carmen-cache/pull/135


createHome attempts to create home directories before local filesystems are mounted

If a user has createHome = true set -- which is the default for normal users and some services, like gitolite -- whatever process tries to create missing home directories runs after / is mounted but before local-fs.target is reached. This seems to work ok if all mounts are explicit in hardware-configuration.nix (although I haven't tested this thoroughly), but breaks if, e.g., you have ZFS datasets that are mounted by the zfs-mount unit as part of reaching local-fs.target; either services like gitolite-init.service fail because the home directory they expected to exist hasn't been properly created, or zfs-mount.service fails because a bunch of home directories have been created in what it expected to be empty mountpoints.
On my system local-fs.target is reached relatively late (it has a bunch of disks to spin up and zpools to import), so anything that needs local filesystems mounted but doesn't explicitly place itself after local-fs.target tends to go wrong.
This seems like it should be an easy fix (make whatever service creates the home directories after = ["local-fs.target"]), but I can't figure out which service does the deed.
Technical details

System: NixOS 16.09
Nix version: 1.11.4
Nixpkgs version: 16.09.1465.fd1dbe5

Mounting zfs datasets via zfs native mounting infrastructure is broken in many places on Linux.
For example if one create a bind mount on top of zfs, it is likely the systemd mount target is faster then zfs, when mounting. Also zfs does not align well with udev. These days we have support for hotplugging, but zfs assumes all hardware is present at boot. I think the only sane solution would be to have a systemd generator, from which systemd can learn what mounts will be created by zfs itself. Until such a generator is written I think we should stick back to zfs's legacy mount feature and specify mountpoints manually.

Thanks for the pointers -- that sheds a lot more light on it for me!
It looks like the correct behaviour here is that individual units list the specific mount points that they depend on, and systemd makes sure they don't start until those filesystems are mounted; they don't need to be ordered after local-fs.target, which isn't reached until all local filesystems are mounted. So, e.g., something that depends on /srv but not /home can start up as soon as /srv is mounted even if /home isn't available yet.
ZFS breaks that assumption because systemd doesn't know where the zfs mount points are unless you set mountpoint=legacy and manage the mounts by hand (which I haven't been doing for most mounts because I have 30+ datasets).
This explains why I'm seeing these problems but things work in general even without an after=local-fs.target ordering, and it also explains why making sure that zfs mount -a runs before local-fs.target is reached doesn't actually fix things.
zfs#4943 looks promising as a "proper" fix for this.
In the meantime, making sure that zfs datasets get mounted before sysinit.target seems to be a functioning workaround:
systemd.targets.zfs = {
  wantedBy = ["local-fs.target" "multi-user.target"];
  wants = ["zfs-mount.service"];
  before = ["local-fs.target" "multi-user.target" "sysinit.target"];
};
systemd.services.zfs-mount.requires = ["zfs-import.target"];

Duplicates https://github.com/NixOS/nixpkgs/issues/6481


Allow usage on stable rust via --no-default-features

I'd like to be able to use the unification stuff on stable, although I don't know how you feel about loosing the cc module. I didn't try going in and converting it.

Seems ok, as long as you are aware this library is fairly unstable.  =)

@BurntPizza I can't remember if I ever published a new version of this to crates.io -- sorry about that! I will do so now. I've also just removed the use of impl Trait, so no features are required.


Maintain consistency on how args and kwargs are handled

Currently in eager mode, an int passed as a positional argument is treated as a tensor and one as a keyword argument is considered a raw scalar. This behavior can create confusion for users.
There is also a potential for making programmatic calls trickier because the tensors cannot by supplied by name.

Duplicate of #305