Fibrous breaks options.sync check

The issue is that fibrous adds a sync function to Object.prototype so when glob creates an empty object for its options, sync is truthy on that new options object.
> var obj = {};
> console.log(obj.sync);
// undefined
> var fibrous = require('fibrous');
> var obj = {};
> console.log(obj.sync);
// { that: {} }
> var obj = Object.create(null)
> console.log(obj.sync);
// undefined

This is really more fibrous's issue than glob's, but there is a simple fix in glob, so I wanted to see if you would be willing to accept a PR for it. e.g. we could change:
if (typeof options === 'function') cb = options, options = {}

to:
if (typeof options === 'function') cb = options, options = Object.create(null)

Happy to submit a PR if you would consider it...
Also see issue https://github.com/goodeggs/fibrous/issues/41 in fibrous.

No longer relevant in v9.


fix(add-inst-to-dict): add more instrumentations to getNodeAutoInstru…

Which problem is this PR solving?
The function getNodeAutoInstrumentations() does not return all the instrumentations, only part of them
Short description of the changes
Add the missing instrumentations to the function getNodeAutoInstrumentations()
Checklist

[ ] Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

Hi @haddasbronfman ,
Thanks for the PR.
Can you please fix the conflicts and make sure your CLA works?
You can convert this PR to draft until it's ready for review.
Regarding the PR name - if you want to use a scope, please use something like the package name auto-instrumentations-node instead of add-inst-to-dict.
link:

A scope MAY be provided after a type. A scope MUST consist of a noun describing a section of the codebase surrounded by parenthesis, e.g., fix(parser):

Close and reopen a new one


Note missed mutants into GitHub PR annotations

https://github.com/crate-ci/typos/ seems to do this nicely and might be a good example to follow: if there are typos, it flags them like in https://github.com/sourcefrog/cargo-mutants/pull/250/files#annotation_17006893398
This would be complementary to a ready-to-go cargo-mutants action (#141), or maybe it depends on it.
https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md seems to be a way to match regexes in output and create annotations.
But perhaps we can write it out directly:

In the example above, the special ::error::, ::warning::, and ::notice:: syntax is used. The format is:
::level file=path/to/file,line=line_number,col=column_number::message

level: Can be error, warning, or notice.
file: The file path relative to the repository root.
line (optional): The line number in the file.
col (optional): The column number in the line.
message: The annotation text.

I think writing it out directly is prolly fine! I was looking at how to do this for my stuff


Search with inherit model

Code:
ModelA(models.Model):
    text_for_search=models.CharField()
    objects = ModelAManager(
        fields=('text_for_search'),
        search_field='search_index',
        auto_update_search_field=True
    )

ModelB(ModelA)
    pass

ModelB.objects is QuerySet, not SearchQuerySet... How i can fix it?
ps. I don't wont to make ModelA abstract.

As workaround (for add searh() to query set):
class AddSearchQSManager(models.Manager):
    def get_queryset(self):
        return SearchQuerySet(model=ModelA, using=self._db)

ModelB(ModelA)
    objects = AddSearchQSManager()


alarms is listed in ASC or out-of-order?

TODO: Switch view to Kbn Datatable for displaying results w/ filtering and ordering

This isssue is pretty annoying :(

Could you pull latest and re-test this should be fixed

Unfortunately, it's still out of order

Finally fixed in latest build, required double escaping due to the @ character in the way ;P
Please reopen in case you notice any odd behaviour - we will replace this table with the Kibana one as soon as time allows for proper sorting and filtering.


Return API error when cancelling a finalized order.

If an order gets cancelled after it has already been previously cancelled, or already completely filled, the orderbook API should return an HTTP error (400?).
There might be some funny edge cases that require extra attention (cancelled and then filled because tx with settlement was already getting mined).

Great first couple of Rust PRs 🎉 !!!


-Wodr warnings when compiling minimp3 with LTO (regression from #78271)

Godot version
4.1.beta (a83eb16fba5bb3da086b41cbd79e6f95b09eb8ee)
System information
Windows & Linux, GCC
Issue description
After merging #78271 I noticed new -Wodr warnings when building with GCC's LTO for official builds on Linux and Windows:
thirdparty/minimp3/minimp3_ex.h:88:3: warning: type 'struct mp3dec_ex_t' violates the C++ One Definition Rule [-Wodr]
   88 | } mp3dec_ex_t;
      |   ^
thirdparty/minimp3/minimp3_ex.h:88:3: note: a different type is defined in another translation unit
   88 | } mp3dec_ex_t;
      |   ^
thirdparty/minimp3/minimp3_ex.h:82:19: note: the first difference of corresponding definitions is field 'buffer'
   82 |     mp3d_sample_t buffer[MINIMP3_MAX_SAMPLES_PER_FRAME];
      |                   ^
thirdparty/minimp3/minimp3_ex.h:82:19: note: a field of same name but different type is defined in another translation unit
   82 |     mp3d_sample_t buffer[MINIMP3_MAX_SAMPLES_PER_FRAME];
      |                   ^
thirdparty/minimp3/minimp3_ex.h:88:3: note: type 'mp3d_sample_t' should match type 'mp3d_sample_t'
   88 | } mp3dec_ex_t;
      |   ^
thirdparty/minimp3/minimp3_ex.h:111:8: warning: 'mp3dec_ex_read_frame' violates the C++ One Definition Rule [-Wodr]
  111 | size_t mp3dec_ex_read_frame(mp3dec_ex_t *dec, mp3d_sample_t **buf, mp3dec_frame_info_t *frame_info, size_t max_samples);
      |        ^
thirdparty/minimp3/minimp3_ex.h:858:8: note: 'mp3dec_ex_read_frame' was previously declared here
  858 | size_t mp3dec_ex_read_frame(mp3dec_ex_t *dec, mp3d_sample_t **buf, mp3dec_frame_info_t *frame_info, size_t max_samples)
      |        ^
thirdparty/minimp3/minimp3_ex.h:858:8: note: code may be misoptimized unless '-fno-strict-aliasing' is used

I'll have to look at this again, seems like the header guards don't work, or we're compiling the header and the .cpp with different conditionals.
Steps to reproduce

scons production=yes with GCC

Minimal reproduction project
n/a

Hi
I am compiling editor 4.1 under linux debian , well, I noticed that recent builds hang, I discovered that the editor crashes when loading or importing resources from mp3 files

I can reproduce the crash too with 7188ed5f9140f6e2a38a24ac3364bba741b45135, and not with 4.1 beta 2, so it's very likely caused by my change. Somehow even gdb doesn't manage to get a stacktrace for this crash.
I'll revert #78271 as it wasn't tested properly and introduced bugs.

Fixed by c79183817df84faaa7a67a32c00c5a2bd46dc632.


Province ID irregularities

I tried to translate some of the Polish names for provinces. To verify in-game placement of each province I used debug_mode and hovered the pointer over provinces I wanted to check. Simultaneously I had that whole list of translations imported to R so that I could sort them and filter interesting rows.
However, in-game IDs were different to those I found in the files in this repository. Now, the question is – which ones are the correct ones? For example: Tesinsko province. In-game its ID is 4742, map/positions.txt has comment with 3606, history/provinces/ folder has file 3606 - Tesinsko.txt with first-line comment #4742 - Tesinsko and common/province_names/polish.txt has 3606 = "Cieszyn". What's more, if I assimilate this (4742) province as Poland, it correctly changes its name to "Cieszyn". On the other hand, province 3606 doesn't even exist.
Yes, I use the latest Steam version of this mod and 1.29.6 version of EU4 in English with dynamic province names turned on.
What's going on here and what should I edit and with which IDs to translate more province names?

Hello @MatiFilozof
Sorry for answering late, I don't understand github well and thought it was a contribution/fork or something, not an issue/question.
The reason there's these province ID irregularities is because prior to 1.30 (like in the Steam 1.29.6 version) Tesinsko was 4742, but after 1.30 4742 was in use by a vanilla province, in this case 4742 - Goslar. So what I did was move Tesinsko to another ID not conflicting with vanilla (3606 in this case), and use 4742 for the proper vanilla equivalent.
The correct IDs are the ones currently in use in the Github master version, which is properly adapted for 1.30 IDs.
Cheers

Thanks, that explains everything, I think. No worries about answering late, I really didn't need immediate reply, why would I even?


The Average bar comme before the Pagination

This pull request change the position of the Average bar and put it before Pagination
Screenshots (optional)

closed #122


Git: Use system_command instead of Open3.capture3

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

In a past discussion, it was preferred that we use system_command in livecheck's Git strategy instead of Open3.capture3 but it wasn't feasible at the time because we couldn't prevent #system_command from printing certain output. I resolved the SystemCommand shortcoming long ago in Homebrew/brew#10066, so this finally migrates the Git strategy to system_command.
I did comparative runs without/with these changes across formulae/casks using the Git strategy and didn't observe any issues (i.e., everything works the same as before). I tested known error conditions (e.g., a missing repository, a repository with no tags) and the behavior remains the same.

This should be the last bit of Git rework before the forthcoming PR to expand support of cached content in strategies (similar to what PageMatch has). [The actual caching logic will be added in a later PR but the content changes should be the last of the underlying foundation.]

Review period will end on 2022-06-07 at 16:48:57 UTC.

Review period ended.


parse error in noop loop from "seen" event from server

Pretty easy to reproduce:
    let mailbox = imap_session.examine("[Gmail]/All Mail")?;
    loop {
        println!("tick");
        if let Ok(response) = imap_session.unsolicited_responses.try_recv() {
            println!("response: {:?}", response);
            match response {
                UnsolicitedResponse::Recent(id) | UnsolicitedResponse::Exists(id) => {
                    print_email(&mut imap_session, id)?;
                }
                other => {
                    println!("Other {:?}", other);
                }
            }
        }
        std::thread::sleep(std::time::Duration::from_secs(1));
        imap_session.noop()?;
    }

While in this loop, read an email and notice that the process exits with the following error:
Error: Imap(Parse(Unexpected("Fetch(31724, [Uid(85608), Flags([\"\\\\Seen\"])])")))
It seems like this is a bug in not adding it to the unsolicited events. This is with a Gmail server.

Ah, interesting. I believe this is fixed by #114 by @Emm54321, specifically the changes to handle_unilateral around here. That adds a part that handles fetch replies as unilateral responses, which I believe should fix your issue. That PR isn't too far from landing I think, though if you are in a rush to get this fixed, you could just lift the changes related to unsolicited responses from that PR and file it as a separate PR :)

I'm also interested in the results of that PR since that is the smarter alternative to a noop loop when the server has IDLE. I believe that if I did take that part of the PR out, then I could use IDLE and still iterate over the unsolicited responses after IDLE ends, right? In that case, then I think that the iterator is merely a nice facade over a loop + IDLE + try_recv(). I'll try to implement that PR, then.

Yes indeed!

PR up. Testing locally looks good so far.


Add with-writer-to-string

I think it would be nice to have the macro with-writer-to-string (similar to the one in com.inuoe.jzon-tests) included and exported from com.inuoe.jzon. The same is probably also the case for a with-writer-to-string* macro.
Or is there a specific reason why you didn't include it @Zulu-Inuoe ?

No specific reason, but I don't think it's super valuable to add since it'd only save people 1 line of code and have us have to support a new interface
In the tests I define that macro because I am repeatedly calling the writer fns with a fresh writer, but in a normal use-case, people will likely have 1 or 2 calls to with-writer in which case they can simply
(with-output-to-string (s)
  (jzon:with-writer (writer :stream s)
    ...))

I'll leave this open in case anyone feels strongly about it.

Somebody brought up today that with-writer could take :stream nil to mean "return a string", which I like better than this since it means one less function, and nil doesn't mean anything else there anyways

+1


"Project Root" is not sufficiently clear

Step 4 of "Configure the ASP.NET Core app" could be clearer. Because the user has created other items at the dir above SignalRWebPack, they may consider that to be the root, but it would be more idiomatic in C# for the root in question to be the SignalRWebPack directory. This is probably what was meant by "project root". I would suggest changing the text to
Create a new directory, called Hubs, in the SignalRWebPack directory. Its purpose is to store the SignalR hub, which is created in the next step.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47557f89-3a14-1139-0074-38d931b35faf
Version Independent ID: 1cee43b4-b672-e480-3e26-72e08a6c2d77
Content: Use ASP.NET Core SignalR with TypeScript and Webpack
Content Source: aspnetcore/tutorials/signalr-typescript-webpack.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @ssougnez
Microsoft Alias: bradyg

Update to this, I was just confused where "project root" was. It might be better to have an explicit step to cd into the SignalRWebPack dir. I realize now what my mistake is by looking at the sample code, but from following the directions, I created this structure where SignalRWebPack is a subdirectory of the root.

In VS2019 Package Manager Console commands have a bug that cause them default to the solution root instead of the project root.  This causes commands like npm init to create the package.json file in the wrong directory.  It's important that instructions explicitely state to check pwd and direct the user to cd to the correct folder.

In addition:
For VS Code users there should have been an added command  code -r SignalRWebPack after creating the new project.  That way the project opens up in VS Code and you automatically get a cd  to the new project directory that was created.

Fixed with PR #16835


Column resize

Isn't it possible to resize the columns?

Did you get an answer back on this? It looks like some related column width issues have been closed but I'm struggling to find how to actually set the column width

I am in the same boat, it doesn't seem to be in any of their documentation. I wish someone would respond to this post....

+1

Do you mean like draggable resizing columns or through styling / CSS?

I am interested in draggable resizing column headers, is this supported? Or indeed possible through customization?

+1

@ryanlanciaux I'm interested in setting a fixed width for a certain column through styling (as props), is this currently possible on any way?

I'm interested in setting a fixed width for a certain column through styling (as props), is this currently possible on any way?

You can specify width on any <ColumnDefinition />.

Doh, didn't see that one 😓😕
Thanks @dahlbyk! 🙂


Add flag to make HTTP timeout configurable

Fixes #48

@dkerwin Would you have a look, when you find time, please?

@dkerwin Any objections to creating a new release including this change?


Fix phrasing in what-is-azure-devops.md

The current phrasing looks like either a typo or wrong phrasing. Specifically, "support teams" aren't the main target audience of Azure DevOps as far as I can tell.

@johananl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@johananl : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


State transition input interface

EOS-25550: No input interface for DTM state machine exists
Solution

Implement wirefrme classes, functions and types that the DTM state
transitions will use
Implement a sample use case of state transition (UNKOWN -> ONLINE) to
outline the general ideas and intentions of this interface.

I am not sure so asking.
@knekrasov and @mssawant ,
The DTM changes should go to kubernetes branch or dtm-0 branch?

@suvratjoshi, @knekrasov, we can have a dtm feature branch based on kubernetes, as not all the changes go in together. Else we need to make sure whatever changes we land in kubernetes, they do not break it.

Closing in favor of #1906


STORM-1129: Update ui to use topology name

@priyank5485 I see that you have the changed the logviewer urls in the topology page to use topology name but there are no changes in logviewer.clj. I think logviewer links should just point to topology id since log links are anyway tied to a specific instance of topology run.

@abhishekagarwal87 Thanks for the catch. I have updated the PR. Can you please review?

Thanks @priyank5485 - Though I am still not sure how logviewer links will work. topologyId variable is not assigned any value. Original code -
https://github.com/apache/storm/blob/master/storm-core/src/ui/public/component.html#L136

@abhishekagarwal87 Please look at the $.getJson method. Line 190 in component.html. Now, instead of topologyId being assigned on onReady i do it in $.getJson. Its a side effect of squashing commits that makes it hard to look at the commits that addressed review comments. Sorry about that. Do you guys usually keep separate commits and squash in the end? I will do that next time.

I think either way is fine. My only concern was logviewer links which I think you have addressed.

@priyank5485 sorry for the delay on this. Can you up merge this patch.


AzCopy v10 many warnings in Event Viewer when uploading big files

When trying to upload a file of 100 MB or bigger using AzCopy v10 to a BLOB Container in a Storage Account, the file gets uploaded but there are many warnings in Event Viewer with the following message:
The description for Event ID 0 from source ...\azcopy.exe cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer.
If the event originated on another computer, the display information had to be saved with the event.
The following information was included with the event:
==> REQUEST/RESPONSE (Try=1/51.1780689s[SLOW >3s], OpTime=51.1780689s) -- RESPONSE SUCCESSFULLY RECEIVED
...
Could you please fix this?
Thank you.

Hi,
Can you provide detailed steps on how to reproduce this issue? We don't own AzCopy, but we can help you open an issue at their repo to see if it can be fixed.
Thank you.

Just send a file of more than 100 MB to a BLOB container in an storage account using AzCopy v10 and take a look at the Application logs in Event Viewer. I'm using a SAS Token to connect to the BLOB. The command I'm using would be something like this: cmd.exe /c .\AZCopy\azcopy cp "C:\Temp_000003_MyTest100MBFileV6.bak" "https://gesxxxxxxxx.blob.core.windows.net/gesxxxxxxx/Core/100MBV6.bak?sv=2018-03-28&sig=Cc3Zxxxxxxxx%3D&spr=https&se=2019-06-26T13%3A14%3A59Z&srt=o&ss=bf&sp=rwl" --log-level ERROR

Hi,
Thank you for the additional information. We have opened an issue for the AzCopy team to investigate and address your concern. You can refer to that issue at https://github.com/Azure/azure-storage-azcopy/issues/469.

AzCopy has fixed the problem. Closed.

Hello.
Sorry, but this is not fixed.

Hey @AlexG7796 , I see that you replied to issue we opened in the AzCopy repo. Thank you for doing that. I'll make sure the AzCopy devs are aware of your continued problems. Once they fix it on their end, we'll take the newer version as soon as we can.

I'm facing this issue

@ImranNaqvi85 the error said azcopy_windows_amd64.exe can not be found or corrupted in the directory specified.  Have you tried to navigate to that directory to see if the file was there? or try to reinstall Storage Explorer if it's corrupted?  Let use know your findings. Thanks.

@jinglouMSFT, the error says the description from the AzCopy executable cannot be found, not the executable file.
@ImranNaqvi85 , since your issue is different from the original one, could you please open another issue so we can investigate and track it? Other than the information in the bug template, it would be great if you can share the full info of the error in your event viewer. Your screenshot is truncated at the bottom.

@jinglouMSFT I'm getting similar errors in my customer's environment.
When trying to run "C:\tool\azcopy.exe  sync  .. .." command using AzCopy v10.10.0.  the command was successfully executed. but every time the command is executed, the following error is logged in the event log.
The description for Event ID:0 in Source:'C:\tool\azcopy.exe' cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer. If the event originated on another computer, the display information had to be saved with the event. The following information was included with the event: ==> REQUEST/RESPONSE (Try=1/272.0018ms, OpTime=272.0018ms) -- REQUEST ERROR HEAD https://stsuzuyoazurefiles001.file.core.windows.net/suzuyo-azurefiles001/pre/urigen/order/log/app-2021-09-09.54.log?se=2050-12-31t12%3A50%3A28z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A50%3A28z&sv=2020-02-10&timeout=901 User-Agent: [AzCopy/10.10.0 Azure-Storage/0.8.0 (go1.15; Windows_NT)] X-Ms-Client-Request-Id: [439bb0f4-ea4f-4820-56c8-4d334b2499b7] X-Ms-Version: [2020-02-10]
In addition, the following information is recorded in the Azcopy log.
2021/09/02 05:01:54 AzcopyVersion  10.10.0
2021/09/02 05:01:54 OS-Environment  windows
2021/09/02 05:01:54 OS-Architecture  amd64
2021/09/02 05:01:54 Log times are in UTC. Local time is 2 Sep 2021 14:01:54
2021/09/02 05:01:54 Job-Command sync https://stsuzuyoazurefiles001.file.core.windows.net/suzuyo-azurefiles001/?se=2050-12-31t12%3A50%3A28z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A50%3A28z&sv=2020-02-10 https://stsuzuyoazurefiles001dr.file.core.windows.net/suzuyo-azurefiles001dr/?se=2050-12-31t12%3A53%3A11z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A53%3A11z&sv=2020-02-10 --recursive=true --delete-destination=true --log-level WARNING
2021/09/02 05:01:54 Number of CPUs: 4
2021/09/02 05:01:54 Max file buffer RAM 2.000 GB
2021/09/02 05:01:54 Max concurrent network operations: 32 (Based on number of CPUs. Set AZCOPY_CONCURRENCY_VALUE environment variable to override)
2021/09/02 05:01:54 Check CPU usage when dynamically tuning concurrency: true (Based on hard-coded default. Set AZCOPY_TUNE_TO_CPU environment variable to true or false override)
2021/09/02 05:01:54 Max concurrent transfer initiation routines: 64 (Based on hard-coded default. Set AZCOPY_CONCURRENT_FILES environment variable to override)
2021/09/02 05:01:54 Max enumeration routines: 16 (Based on hard-coded default. Set AZCOPY_CONCURRENT_SCAN environment variable to override)
2021/09/02 05:01:54 Parallelize getting file properties (file.Stat): false (Based on AZCOPY_PARALLEL_STAT_FILES environment variable)
2021/09/02 05:01:54 Max open files when downloading:<PHONE_NUMBER> (auto-computed)
2021/09/02 05:01:54 ISO 8601 START TIME: to copy files that changed before or after this job started, use the parameter --include-before=2021-09-02T05:00:51Z or --include-after=2021-09-02T05:00:51Z
2021/09/02 05:01:54 Any empty folders will be processed, because source and destination both support folders
2021/09/02 05:01:54 WARN: [P#0-T#0] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2021/09/02 05:01:54 WARN: [P#0-T#1] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
… …
… …
2021/09/02 05:01:54 WARN: [P#0-T#63] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2021/09/02 05:01:54 WARN: [P#0-T#46] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2021/09/02 05:01:55 ==> REQUEST/RESPONSE (Try=1/493.4986ms, OpTime=493.4986ms) -- REQUEST ERROR
GET https://stsuzuyoazurefiles001dr.file.core.windows.net/suzuyo-azurefiles001dr/pre/master?restype=directory&se=2050-12-31t12%3A53%3A11z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A53%3A11z&sv=2020-02-10&timeout=901
User-Agent: [AzCopy/10.10.0 Azure-Storage/0.8.0 (go1.15; Windows_NT)]
X-Ms-Client-Request-Id: [5164a769-b19b-45c5-4a85-4d5f9aeecda5]
X-Ms-Version: [2020-02-10]
ERROR:
-> github.com/Azure/azure-pipeline-go/pipeline.NewError, /home/vsts/go/pkg/mod/github.com/!azure/azure-pipeline-go@v0.2.3/pipeline/error.go:157
HTTP request failed
Get "https://stsuzuyoazurefiles001dr.file.core.windows.net/suzuyo-azurefiles001dr/pre/master?restype=directory&se=2050-12-31T12%3A53%3A11Z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16T04%3A53%3A11Z&sv=2020-02-10&timeout=901": dial tcp <IP_ADDRESS>:443: connectex: Only one usage of each socket address (protocol/network address/port) is normally permitted.
goroutine 108 [running]:
github.com/Azure/azure-storage-azcopy/v10/ste.stack(0xc00f3d9620, 0xc01f5b6100, 0x0)
/home/vsts/work/1/s/ste/xferLogPolicy.go:237 +0xa5
github.com/Azure/azure-storage-azcopy/v10/ste.NewRequestLogPolicyFactory.func1.1(0x184a2a0, 0xc006352d20, 0xc005555c00, 0x10, 0x0, 0x0, 0xc00641b340)
/home/vsts/work/1/s/ste/xferLogPolicy.go:151 +0x7a5
What is the cause of this log? Can we ignore it?

@JasonYeMSFT I'm getting similar errors in my customer's environment.
When trying to run "C:\tool\azcopy.exe  sync  .. .." command using AzCopy v10.10.0.  the command was successfully executed. but every time the command is executed, the following error is logged in the event log.
The description for Event ID:0 in Source:'C:\tool\azcopy.exe' cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer. If the event originated on another computer, the display information had to be saved with the event. The following information was included with the event: ==> REQUEST/RESPONSE (Try=1/272.0018ms, OpTime=272.0018ms) -- REQUEST ERROR HEAD https://xxxxxxxxxxxxxxx.file.core.windows.net/xxxxxxxxxxxxxxxxxxxx/pre/urigen/order/log/app-2021-09-09.54.log?se=2050-12-31t12%3A50%3A28z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A50%3A28z&sv=2020-02-10&timeout=901 User-Agent: [AzCopy/10.10.0 Azure-Storage/0.8.0 (go1.15; Windows_NT)] X-Ms-Client-Request-Id: [xxxxxxxxxxxxxxx] X-Ms-Version: [2020-02-10]
In addition, the following information is recorded in the Azcopy log.
2021/09/02 05:01:54 AzcopyVersion  10.10.0
2021/09/02 05:01:54 OS-Environment  windows
2021/09/02 05:01:54 OS-Architecture  amd64
2021/09/02 05:01:54 Log times are in UTC. Local time is 2 Sep 2021 14:01:54
2021/09/02 05:01:54 Job-Command sync https://xxxxxxxxxx.file.core.windows.net/xxxxxxxxxxxxx/?se=2050-12-31t12%3A50%3A28z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A50%3A28z&sv=2020-02-10 https://xxxxxxxxxxx.file.core.windows.net/xxxxxxxxxxx/?xxxxxxxxxxxxxx --recursive=true --delete-destination=true --log-level WARNING
2021/09/02 05:01:54 Number of CPUs: 4
2021/09/02 05:01:54 Max file buffer RAM 2.000 GB
2021/09/02 05:01:54 Max concurrent network operations: 32 (Based on number of CPUs. Set AZCOPY_CONCURRENCY_VALUE environment variable to override)
2021/09/02 05:01:54 Check CPU usage when dynamically tuning concurrency: true (Based on hard-coded default. Set AZCOPY_TUNE_TO_CPU environment variable to true or false override)
2021/09/02 05:01:54 Max concurrent transfer initiation routines: 64 (Based on hard-coded default. Set AZCOPY_CONCURRENT_FILES environment variable to override)
2021/09/02 05:01:54 Max enumeration routines: 16 (Based on hard-coded default. Set AZCOPY_CONCURRENT_SCAN environment variable to override)
2021/09/02 05:01:54 Parallelize getting file properties (file.Stat): false (Based on AZCOPY_PARALLEL_STAT_FILES environment variable)
2021/09/02 05:01:54 Max open files when downloading:<PHONE_NUMBER> (auto-computed)
2021/09/02 05:01:54 ISO 8601 START TIME: to copy files that changed before or after this job started, use the parameter --include-before=2021-09-02T05:00:51Z or --include-after=2021-09-02T05:00:51Z
2021/09/02 05:01:54 Any empty folders will be processed, because source and destination both support folders
2021/09/02 05:01:54 WARN: [P#0-T#0] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2021/09/02 05:01:54 WARN: [P#0-T#1] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
… …
… …
2021/09/02 05:01:54 WARN: [P#0-T#63] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2021/09/02 05:01:54 WARN: [P#0-T#46] Block size 8388608 larger than maximum file chunk size, 4 MB chunk size used
2021/09/02 05:01:55 ==> REQUEST/RESPONSE (Try=1/493.4986ms, OpTime=493.4986ms) -- REQUEST ERROR
GET https://xxxxxxxxxxxxxxx.file.core.windows.net/xxxxxxxxxxxx/pre/master?restype=directory&se=2050-12-31t12%3A53%3A11z&sig=-REDACTED-&sp=rwdlc&spr=https&srt=sco&ss=f&st=2021-06-16t04%3A53%3A11z&sv=2020-02-10&timeout=901
User-Agent: [AzCopy/10.10.0 Azure-Storage/0.8.0 (go1.15; Windows_NT)]
X-Ms-Client-Request-Id: [xxxxxxxxxxxxxxxxxxx]
X-Ms-Version: [2020-02-10]
ERROR:
-> github.com/Azure/azure-pipeline-go/pipeline.NewError, /home/vsts/go/pkg/mod/github.com/!azure/azure-pipeline-go@v0.2.3/pipeline/error.go:157
HTTP request failed
Get "https://xxxxxxxxxxxxxx.file.core.windows.net/xxxxxxxxxxxxxxxxxx/pre/master?xxxxxxxxxxxxxxxxxxxxxxxxxxx&timeout=901": dial tcp <IP_ADDRESS>:443: connectex: Only one usage of each socket address (protocol/network address/port) is normally permitted.
goroutine 108 [running]:
github.com/Azure/azure-storage-azcopy/v10/ste.stack(0xc00f3d9620, 0xc01f5b6100, 0x0)
/home/vsts/work/1/s/ste/xferLogPolicy.go:237 +0xa5
github.com/Azure/azure-storage-azcopy/v10/ste.NewRequestLogPolicyFactory.func1.1(0x184a2a0, 0xc006352d20, 0xc005555c00, 0x10, 0x0, 0x0, 0xc00641b340)
/home/vsts/work/1/s/ste/xferLogPolicy.go:151 +0x7a5
What is the cause of this log? Can we ignore it?


char literals are not transpiled correctly (using charCodeAt instead of charAt)

C# code:
                char c = line[i];
                if (c == '\"')
                {
                    if (inDoubleQuote)
                    {
                        inDoubleQuote = false;
                        dataFields.Add('\"' + field);
                        field = string.Empty;
                    }
                    else
                    {
                        inDoubleQuote = true;
                    }
                }

Is transpiled to:
                    var c: number = line.charCodeAt(i);
                    if (c === 34/*'"'*/)
                    {
                        if (flag)
                        {
                            flag = false;
                            list.Add(34 + /*'"'*/text);
                            text = NString.Empty;
                        }
                        else
                        {
                            flag = true;
                        }
                    }

Obviously, this breaks string + char addition where the char came from a string (see the 'list.Add' line). Is there a way to prefer using charAt instead of charCodeAt?

Ouch. I will need to think about this. I did have a reason to prefer charCode, but I don't recall what it was. I'll look into it.


add angular2 http client support

Right now you support as external transport jquery, request, superagent, fetch.
Is there any plan to add angular2 http client support?

It's not in the plan.  What benefit would it be?

Let  angular2 projects dont rely on external dependencies (just feathers client).

@harangue wrote the Angular 2 guide but it uses the Superagent client. If you want to avoid external dependencies why not go with websockets all the way? They're faster than using a REST client anyway.

@daffl Has there been any talk of separating the .jquery, .fetch, .etc from the feathers-rest library?
I think people are going to cling pretty tightly to REST for the most part since websockets are unfamiliar.

You can implement your own client as a custom service any time. Most of the existing adapters are only a couple of lines of code (see e.g. https://github.com/feathersjs/feathers-rest/blob/master/src/client/fetch.js).
But yes, I think we will potentially separate those out when making Feathers backend framework independent (see https://github.com/feathersjs/feathers/issues/258).
I still think there are many good points to be made for going websockets all the way, especially in application that already uses Feathers as the client:

Usage through the Feathers client is exactly the same
You get real-time events (if you want to use them)
It is faster
Everything is still RESTful (as an architectural design pattern REST does not prescribe what protocol to use even though it has become synonymous with HTTP)
Authentication support via feathers-authentication
In most browsers with decent webtools Websockets can now also be debugged the same way as network request.

thanks @daffl, I have changed my app to use websockets. Also I have found this feathers example with angular2 , websockets and observables.

use websocket is a good solution regardless of http client, but any perf issue if i maintain a stream traffic in websocket connection?

@elaijuh pretty loaded question as it depends on how many connections you have and the number of servers you have. But you can throw more servers at the problem and use feathers-sync to scale easily with websockets.

I'm going to close this. From what I understand the Angular HTTP client should work with Feathers anyway (especially combined with RxJS and feathers-reactive). If someone is interested in making a feathers-rest client connector for it we're happy to help but it is not going to be a part of the official roadmap.


All in one Docker Compose ?

Hi
Perhaps a long shot, but seeing as my paperless-ngx docker compose already has a number of additional applications - like Tika, Gothenburg, etc. is there any chance a single ‘all in one’ docker compose could be made available that adds all the  doclytics, ollama etc. elements altogether too?

HI @nodecentral, is your idea to have a docker-compose for everything including paperless-ngx and tika/gotenburg or just for doclytics and ollama together ?

Hi @B-urb, yes absolutely, it would be amazing to have an all in one application/solution compose.yml.
And in addition to that recommendations on the specification of machine to run it all on (based on the amount of docs etc.) to get the best possible experience. That would be the icing on the cake.. 🤩

I'm not great at docker, but to bring everything together, I'm thinking it would be something like this (untested)..

version: '3.8'
services:
  ollama:
    volumes:
      - /share/Container/ollama:/root/.ollama
    container_name: ollama
    ports:
       - "11434:11434"
    pull_policy: always
    tty: true
    restart: unless-stopped
    image: ollama/ollama:latest

  open-webui:
    image: ghcr.io/open-webui/open-webui:latest
    container_name: open-webui
    volumes:
      - /share/Container/ollama/webui:/app/backend/data
    depends_on:
      - ollama
    ports:
      - "8282:8080"
    environment:
      - 'OLLAMA_BASE_URL=http://ollama:11434'
      - 'WEBUI_SECRET_KEY='
    extra_hosts:
      - host.docker.internal:host-gateway
    restart: unless-stopped

  redis:
    image: redis:7
    container_name: paperless-redis
    restart: unless-stopped
    volumes:
      - /share/Container/paperlessredis:/data

  db:
    image: postgres:14
    container_name: paperless-db
    restart: unless-stopped
    volumes:
      - /share/Container/paperlessdb:/var/lib/postgresql/data
    environment:
      POSTGRES_DB: paperless
      POSTGRES_USER: paperless
      POSTGRES_PASSWORD: paperless

  webserver:
    image: ghcr.io/paperless-ngx/paperless-ngx:latest
    container_name: paperlessngx
    restart: unless-stopped
    privileged: true
    depends_on:
      - db
      - redis
      - gotenberg
      - tika
    ports:
      - 8777:8000
    healthcheck:
      test: ["CMD", "curl", "-fs", "-S", "--max-time", "2", "http://localhost:8000"]
      interval: 30s
      timeout: 10s
      retries: 5
    volumes:
      - /share/Container/paperless/data:/usr/src/paperless/data
      - /share/Container/paperless/media:/usr/src/paperless/media
      - /share/Container/paperless/export:/usr/src/paperless/export
      - /share/Container/paperless/consume:/usr/src/paperless/consume
      - /share/Container/paperless/scripts:/usr/src/paperless/scripts
      - /share/Container/paperless/trash:/usr/src/paperless/trash
    environment:
      PAPERLESS_REDIS: redis://redis:6379
      PAPERLESS_DBHOST: db
      USERMAP_UID: 1000
      USERMAP_GID: 1000
      PAPERLESS_TIME_ZONE: Europe/London
      PAPERLESS_ADMIN_USER: username
      PAPERLESS_ADMIN_PASSWORD: password
      PAPERLESS_CONSUMER_RECURSIVE: true
      PAPERLESS_CONSUMER_SUBDIRS_AS_TAGS: true
      # PAPERLESS_CONSUMER_POLLING: 5
      PAPERLESS_OCR_LANGUAGE: eng
      PAPERLESS_TIKA_ENABLED: 1
      PAPERLESS_TIKA_GOTENBERG_ENDPOINT: http://gotenberg:3000
      PAPERLESS_TIKA_ENDPOINT: http://tika:9998
      PAPERLESS_TRASH_DIR: /usr/src/paperless/trash/
      PAPERLESS_CONSUMER_DELETE_DUPLICATES: true
      PAPERLESS_CONSUMER_ENABLE_BARCODES: true
      PAPERLESS_CONSUMER_IGNORE_PATTERNS: '[".DS_STORE/*", "._*", ".stfolder/*", ".stversions/*", ".localized/*", ".@__thumb/*", "desktop.ini"]'

  gotenberg:
    image: docker.io/gotenberg/gotenberg:7.8
    restart: unless-stopped
    container_name: gotenberg
    ports:
       - 3000:3000
    command:
      - "gotenberg"
      - "--chromium-disable-routes=true"

  tika:
    image: ghcr.io/paperless-ngx/tika
    container_name: tika
    ports:
      - 9998:9998
    restart: always


PyPi xclim page does not render the README's restructured text

xclim version:
Python version:
Operating System:

Description

see https://pypi.org/project/xclim/
Possibly an unsupported directive ?

Or a relative link to the logo ?
See https://pypi.org/project/restructuredtext-lint/


[Feat] API_KEY env

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR is related to #7.
I've created API_KEY env and implemented it on module options.
Scope of work

add API_KEY env and implement on module.ts
update docs and README

Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

Hey @runyasak
Thanks for the PR however the idea was this feature was different.
There is nothing wrong with passing options as module configuration. What Pooya meant with this bug is that the API Key that is passed as configuration option is later added to the runtime config. In your PR it will still be added there.
So how it should be implemented is to find a way to not add apiKey to the runtime config but pass these options in a different way so that they are not accessible from the public runtime config.

@Baroshem  Sorry, for my misunderstanding.
I should ask you for more detail first. I get your point now.
I will submit another PR to solve this issue.
By the way, thank you so much for accepting my PR. 😂

I will close this PR as it is outdated and there is another PR live :)


Critical vulnerabilities in dependency immer v8.0.1

FOSSA scan reports two critical security vulnerability in package immer <= v8.0.1 .
Context
CVE-2021-23436
CVE-2021-3757
Possible Solution(s)
Vulnerability is fixed in >=v9.0.6.

The latest version should no longer be vulnerable.


Disable reviewer functionality temporarily - Package

As the complete reviewer workflow has to be re-evaluated, this functionality should be disabled temporarily. Where you can choose a reviewer and enter a reviewing note, this should not be shown any more. Review buttons that finish an operation like Create Package should be changed to OK Buttons or Akzeptieren Buttons and not rely on the selection of a reviewer (as it is in the concept by selecting Akzeptieren (ohne Review) shown on p. 60)
This applies to:

Create/Edit package (Concept 8.1, pp. 41f.; 8.2, p. 48)

Okay, removed from Package and Title, Provider not implemented so far.

Associated issues:

Title: https://github.com/openlibraryenvironment/gokb-ui/issues/16
Provider: https://github.com/openlibraryenvironment/gokb-ui/issues/17


accelerator.save_model(): NotImplementedError: Cannot copy out of meta tensor; no data!

System Info
Hi,
I just tried to save a model with "safe_serialization=True" and I got this error ("safe_serialization=False" works):
Like: accelerator.save_model(model, save_dir, safe_serialization=True)
File "/home/blap/AutoGPTQ-env/lib/python3.10/site-packages/safetensors/torch.py", line 404, in _tobytes
tensor = tensor.to("cpu")
NotImplementedError: Cannot copy out of meta tensor; no data!
Maybe the docs lack something or I don't know...

Accelerate version: 0.25.0.dev0
Platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.37
Python version: 3.10.13
Numpy version: 1.26.1
PyTorch version (GPU?): 2.2.0.dev20231106+cu118 (True)
PyTorch XPU available: False
PyTorch NPU available: False
System RAM: 5.71 GB
GPU type: NVIDIA GeForce MX330
Accelerate default config:
- compute_environment: LOCAL_MACHINE
- distributed_type: NO
- mixed_precision: fp16
- use_cpu: True
- debug: False
- num_processes: 1
- machine_rank: 0
- num_machines: 1
- rdzv_backend: static
- same_network: True
- main_training_function: main
- ipex_config: {'ipex': True}
- downcast_bf16: no
- tpu_use_cluster: False
- tpu_use_sudo: False
- tpu_env: []
- dynamo_config: {'dynamo_backend': 'INDUCTOR', 'dynamo_mode': 'reduce-overhead', 'dynamo_use_dynamic': True, 'dynamo_use_fullgraph': False}

Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
from huggingface_hub import login
import torch

login(token="hf_****", add_to_git_credential=True)

from transformers import LlamaTokenizer, AutoModelForCausalLM

folder_offload="long_llama_3b_instruct_offload"
model_name="syzymon/long_llama_3b_instruct"
tokenizer = LlamaTokenizer.from_pretrained(model_name)
model = AutoModelForCausalLM.from_pretrained(model_name, offload_folder=folder_offload, offload_state_dict=True, torch_dtype=torch.float16, device_map="auto", trust_remote_code=True, low_cpu_mem_usage = True)
model = torch.compile(model)

from accelerate import Accelerator

save_dir="long_llama_3b_instruct"
accelerator = Accelerator()
model = accelerator.prepare(model)
unwrapped_model = accelerator.unwrap_model(model)
# Errors too: unwrapped_model.save_pretrained(save_directory=save_dir, is_main_process=True, save_function=accelerator.save, safe_serialization=True)

accelerator.save_model(model, save_dir, safe_serialization=True)

del model

Expected behavior
Save model with safe_serialization.

Hi @blap ,thanks for reporting ! You can't save a model that has been offloaded to the cpu/disk as some of the tensors are on the meta device. Furthermore, you shouldn't have to save the model since it is not possible to train de model when some of the parameters are offloaded. In the case of safe_serialization=False, the offloaded weights are not actually saved .

I've merged a PR that should better explain what is going on ! Closing this issue.

I've merged a PR that should better explain what is going on ! Closing this issue.

Thank you!


Missing isin method of DataFrame

isin is relevant function to filter the rows values

Is this completed I don't see a way to filter data frame with a list of values like pandas isin

yes.
and what boolean mask we can use to simulate pandas's isin?

ping


Use f-strings and made variable naming better, also added else.

Since you're not making your area1, area2, and area3 globals, you won't get an error if you name all of them area. Who doesn't know f-strings look and are better. Also if I entered 4, the program would be exited abruptly. To avoid this, I added else :>

Thanks! Highly Appreciated!


docs: improve readability of code block

Ah, nice, that looks way better! Merging, thank you.

Happy to help.


Unknown charset iso-8859-1

aerc tells me to report this.

[fetch.c:118] Unknown charset iso-8859-1. Please report this.

Some mails in my inbox composed on (older?) Windows systems are using iso-8859-1.

Thanks!


MacOS Powershell not supported

1. Provide a general summary of the issue in the Title above
2. Describe Your Environment
Operating System and PowerShell version:
MacOS 10.13.3, PowerShell 6.0.1
3. Expected Behavior
[comment] If you're describing a bug, tell us what should happen
[comment] If you're suggesting a change/improvement, tell us how it should work
MacOS should be supported when running Save-GitlabApiConfiguration
4.Current Behavior
[comment] If describing a bug, tell us what happens instead of the expected behavior
[comment] If suggesting a change/improvement, explain the difference from current behavior
Currently checks for $IsLinux and $IsWindows, but not $IsMacOS. Gives unknown platform error for MacOS.
5. Possible Solution
[comment] Have a solution in mind?
6. Context
[Comment] How has this issue affected you? What are you trying to accomplish?
Trying to use PowerShell for MacOS for all my gitlab management.

I'll have to steal my wife's Macbook Air for the night and see what I can fix.

Look forward to being able to use this on mac :)


UI Freeze on repositories that have a very large number of pom.xml files

For the repository: https://github.com/apache/incubator-dubbo
There are a very large number of pom.xml files present, in these cases the UI freezes up and you are not able to switch tabs.
/cc @sara-02

How it looks, the actual recommendation tab is the little white space you see at the bottom of the screen, since the pom ist s huge, the stack report is pushed down, and there is no way to expand and roll it up.

i tried on mac couldn't reproduce i.e was able to scroll and UI was not frozen, could be an issue in fedora.
Request other folks as well to give a try.

@invincibleJai  @sara-02  I tried with
vscode [ 1.25.1 ]

LSB Version:	:core-4.1-amd64:core-4.1-noarch
Distributor ID:	Fedora
Description:	Fedora release 28 (Twenty Eight)
Release:	28
Codename:	TwentyEight

Not facing any UI freeze issue

To me it's more like an enhancement, as it's happening for few, may be we need to think about the way we are loading the stack-report-ui in web-view or in case of several manifest file should pull data using some sort of lazy loading. Even UXD is bad in such a scenario may need to revisit.
cc @samuzzal-choudhury

@invincibleJai yes, I will also keep a tab on of this and try with some other repos as well. If it does not happen we can close the issue.

Closing it, as didn't observed.


Tutorial: tracing code

Running edit 1 n/アリス ユー with breakpoint set to logic.execute(commandText)

Error is thrown when ParserUtil.parseName(argMultimap.getValue(PREFIX_NAME).get())

Upon further investigation, the name is not valid, hence, a ParseException is thrown.

Running edit 1 t/one t/two t/three t/one with breakpoint set to logic.execute(commandText)

Step into the switch statement

edit arguments is successfully captured.

Hello friends :D here is my attempt at the code tracing..

^ Input at MainWindow (before going into the LogicManager class) after entering edit 1 n/アリス ユー

^ in AddressBookParser class, still no exception being thrown and UserInput is successfully captured still

^ parsing the (seemingly problematic) 1 n/アリス ユー, edit is successfully separated from this term.

^ index 1 captured by the index = ParserUtil.parseIndex(argMultimap.getPreamble()); command.

^ Scanning the n/アリス ユー with this line...
editPersonDescriptor.setName(ParserUtil.parseName(argMultimap.getValue(PREFIX_NAME).get())); is being invoked, since argMultimap.getValue(PREFIX_NAME).isPresent() conditional is being satisfied.

^ just when the method above has been invoked, invalid command spotted! ParseException thrown.
This is the overview for a single case, when edit 1 n/アリス ユー is being entered.


Added navigations to project-details #1132

Regarding the issue https://github.com/aboutcode-org/scancode.io/issues/1132  I have added Navigations to project details.
screenshots attached below
This is when I hovered on Packages similarly on other elements as well.

Signed-off-by: Varsha U N<EMAIL_ADDRESS>

@AyanSinhaMahapatra please review this. Thank you

@tdruez please suggest me on how can I improve this.
Thank you

@VarshaUN please suggest me on how can I improve this.

Well, you handle the "link" part of https://github.com/aboutcode-org/scancode.io/issues/1132 but I don't think you entirely addressed this issue:

visually these names are in small caps and it would be better to make these in the same style and font as other UI elements from the page like the Inputs, Codebase and related block in white-on-blue below. These are the most important things and they are relatively rather small compared to other parts.

@tdruez  I have added the same font as inputs now. So is there any other conditions that I need to look at??

@tdruez I have added all the parts now.  Please review it . Thank you


UI: Contrast between the dataset selection ribbon and the drop down area

Currently, the clickable ribbon that selects a particular dataset and the drop-down area have the same color. This is fine when a single dataset is loaded. However, when multiple datasets are loaded it takes a second to decide where I want to click. Working fast, I do lots of wrong clicks.
Making the drop-down area with a darkish grey could help.

You have a left border that highlight the inside of a drop-down/dataset.
Regarding the gray part, if we do that we'll have to support when the UI is used with dark mode.
But we can certainly think of a way to make it more obvious.

I totally missed the left border. Maybe just making it thicker would suffice.

I like subtle things, maybe it was too subtle. ;-)
I'll see to make it thicker...
Thx!

Other options while keeping the border width could be

border on the right instead (which makes the border close to the click area)
border on both sides
a different color (like red from the glance logo)

The border have a different color for each dataset. So you can ~easily~ find the data you want to tweak and prevent edits on other datasets

It is a very easy change but we need to find a path that remain clean while serving its purpose.
Also, we can envision some settings that could be user specific in the global settings which could use persistent storage to keep the user preference. (number of borders: [1-2], border width: [4-20])

+1


Bug: Typescript compiler is confused between Tuple literal and Array Literal

Expected behavior:
No error
Actual behavior:
Type error.
Playground Link:
http://www.typescriptlang.org/play/#src=interface OK<T> {
    kind%3A "OK"%3B
    value%3A T%3B
}
export function ok<T>(value%3A T)%3A OK<T> {
    return {
        kind%3A "OK"%2C
        value%3A value
    }%3B
}

let result%3A OK<[string%2C number]> %3D ok(["hello"%2C 12])%3B
Related Issues:

Duplicate of  #11152 -- the problem is that annotating the result as OK<[string, number]> has no effect in the inferred type argument. let result = ok<[string, number]> (["hello", 12]); would work though.


Fix for #480.

This PR fixes the issue raised as #480.

Docs Build status updates of commit a305e77:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/language/statements.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/language/statements.md
71
48
137
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit 06e7632:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/language/statements.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Acrolinx Scorecards
A minimum Acrolinx score of 80 is required.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
AcrolinxScore
LowestCategoryScore
Issues
Scorecard
Processed

articles/language/statements.md
71
48
137
link
:white_check_mark:

More info about Acrolinx

Install Acrolinx locally for VSCode
False positives or issues

Docs Build status updates of commit 8a44851:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/language/statements.md
:white_check_mark:Succeeded
View (qsharp-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


SOLR-15392 Tracing span operation name and tags

https://issues.apache.org/jira/browse/SOLR-15392

I think this is ready for review/merge.  I'll may wait for more internal use where I work before merging.  The V2 API doesn't result in ideal span operation names (looks like post:/c/collection1 instead of create:/c/{collection}, however, and I think that should come in a separate PR that follows some of the work in #81 which will likely affect the approach on how to solve it.

I separated out https://issues.apache.org/jira/browse/SOLR-15418 #115 for the ContentStream stuff that is unrelated (but tickled by immature V2 codepaths).

Synced with main thus incorporating #134 .  Any final thoughts @noblepaul ?

Are we good here @noblepaul ?  You set "change requested" review status.

LGTM @dsmiley


Micro: Add the missing TF_LITE_STATIC_MEMORY-macro to mbed_app.json.tpl.

Compiling Tensorflow Lite Micro with Arm Mbed OS fails due to a missing compile flag. This PR adds that compile flag to the mbed_app.json template file.

Thanks Jens.
We have an internal change under review that will enable building without the TF_LITE_STATIC_MEMORY macro. I will update this conversation once that lands.

With commit 55446fa the macro should no longer be needed. I am closing this PR, please let us know if you run into any issues.

Great, thanks for the quick response! I'll let you know if we see any problems.


explain how to find ssh fingerprints on local computer

https://doc.cocalc.com/account/ssh.html - add hint to use ssh-keygen -l  -E md5 -f  foo.pub locally to match fingerprint in Account ... SSH Keys

Section on showing fingerprints locally added as https://doc.cocalc.com/account/ssh.html#display-local-public-key-fingerprints
Also, much of the ssh keys page and related pages were updated.


Add incremental updating of open streams count and closed_streams state

This fixes https://github.com/python-hyper/hyper-h2/issues/1184

On the old code, here is how test_concurrent_stream_open_performance runs:
============================================================= FAILURES =============================================================
___________________________ TestConcurrentStreamOpenPerformance.test_concurrent_stream_open_performance ____________________________

self = <test_concurrent_stream_open.TestConcurrentStreamOpenPerformance object at 0x107d86a50>
frame_factory = <helpers.FrameFactory object at 0x107d86cd0>

    def test_concurrent_stream_open_performance(self, frame_factory):
        """
            Opening many concurrent streams is constant time operation
            """
        num_concurrent_streams = 10000
        c = h2.connection.H2Connection()
        c.initiate_connection()
        start = time.time()
        for i in xrange(num_concurrent_streams):
            c.send_headers(1 + (2 * i), self.example_request_headers, end_stream=False)
            c.clear_outbound_data_buffer()
        end = time.time()

        run_time = end - start
>       assert run_time < 3
E       assert 36.598387002944946 < 3

test/test_concurrent_stream_open.py:51: AssertionError
==================================================== 1 failed in 36.66 seconds =====================================================

New code:
============================================================================================================ test session starts =============================================================================================================
platform darwin -- Python 2.7.15, pytest-3.4.2, py-1.7.0, pluggy-0.6.0
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/Users/andrew/workspace/hyper-h2/.hypothesis/examples')
rootdir: /Users/andrew/workspace/hyper-h2, inifile:
plugins: xdist-1.22.2, profiling-1.6.0, forked-1.0.2, cov-2.5.1, hypothesis-4.5.11
collected 1 item

test/test_concurrent_stream_open.py .                                                                                [100%]

========================================================================================================== 1 passed in 1.06 seconds ==========================================================================================================

Note that for this example, I commented out the second "test" in the test_concurrent_stream_open_performance function since the old code fails the first "test".
As you can see, this is a 36X perf improvement

So the lints I can clean up (I assume I can just run autopep8 or something similar?), but the code coverage tests are failing for some versions of python for these lines:
h2/stream.py           479      0    106      1    99%   809->814
Pasting the code here for reference:
def sync_state_change(func):
    def wrapper(self, *args, **kwargs):
        # Collect state at the beginning.
        start_state = self.state_machine.state
        started_open = self.open
        started_closed = not started_open

        # Do the state change (if any).
        result = func(self, *args, **kwargs)

        # Collect state at the end.
        end_state = self.state_machine.state
        ended_open = self.open
        ended_closed = not ended_open

        # If at any point we've tranwsitioned to the CLOSED state
        # from any other state, close our stream.
        if end_state == StreamState.CLOSED and start_state != end_state:
            if self._close_stream_callback:
                self._close_stream_callback(self.stream_id)
                # Clear callback so we only call this once per stream
                self._close_stream_callback = None

        # If we were open, but are now closed, decrement
        # the open stream count, and call the close callback.
        if started_open and ended_closed:
            if self._decrement_open_stream_count_callback:
                self._decrement_open_stream_count_callback(self.stream_id,
                                                           -1,)
                # Clear callback so we only call this once per stream
                self._decrement_open_stream_count_callback = None

        # If we were closed, but are now open, increment
        # the open stream count.
        elif started_closed and ended_open:
>          if self._increment_open_stream_count_callback:
>              self._increment_open_stream_count_callback(self.stream_id,
>                                                          1,)
>              # Clear callback so we only call this once per stream
>              self._increment_open_stream_count_callback = None
        return result
    return wrapper

Which is odd, since I can insert a print statement there and verify that the code is getting called, not to mention the counts of open outbound/inbound streams would be completely wrong if that code wasn't getting called.
Is this a quirk with the code coverage tool?

Oh I see, it's because the if() never evaluates to False. If I remove the conditional the coverage tests pass
The reason that conditional is there is for defensive reasons. A function wrapped by sync_state_change can call another function that is also wrapped by sync_state_change, and we don't want to update state twice.
I can write a specific test to exercise this behavior for that conditional

@Lukasa @pgjones This is ready for review (picking these names based on recent merge commits)

Thanks, I've managed to find time to understand the problem - but I'm not sure about the solution. It would be helpful if @Lukasa could comment on the general solution and how it fits in with the codebase. I'd then be happy to comment on the details.

Any updates on this @pgjones @Lukasa ?

I'm very glad someone already thought that this open stream count may be a problem 😍
However the  @sync_state_change annotation on every method in H2Stream here seems invasive and possibly error-prone. Its flip-side, callbacks, don't seem very Pythonic 🤔
The open stream count is essentially a cache; could it be implemented in some other way?
For example, could it be something akin to a weakset/dict?
Or, perhaps the count could be recalculated on demand (i.e. on new stream or stream end mark cache dirty; next time recalculate)?
Or, perhaps stream state machine could have an output STREAM_CLOSED that the connection receives after pumping stream's events to the state machine, at which point stream can be removed from .streams as opposed to removal during counting?
Or, maybe, .streams could be simply split into .inbound_streams/.outbound_streams/.promises so that only specific set is ever evaluated (against own or peer's MAX_CONCURRENT_STREAMS)?


Fix __stack_chk_guard undefined error on Buster ARM64

Per raspberrypi-kernel-headers' arch/arm64/Kconfig and Makefile, CC_HAVE_STACKPROTECTOR_SYSREG and therefore also STACKPROTECTOR_PER_TASK are set on the distributed kernel as that one is built with GCC 9. In contrast, only GCC 8 is available on Buster systems, so these options are unavailable when the piVCCU modules are compiled. Therefore two functions are undefined and the build fails.
Fix this by providing standard implementations on ARM64, but only if the compiler doesn't support the relevant options.
With these changes applied, compilation works on a Raspberry Pi 4B with Raspberry Pi OS 64-bit. Didn't have a chance yet to test the kernel modules, though :(
As this is my first contact with Linux kernel sources, kbuild, DKMS, and also piVCCU, and I'm not well versed in Makefiles either, the proposed changes can disobey a lot of conventions and guidelines -- sorry for this! Feel free to change, ignore, or simply close this PR if this is way off.

Fixes #307
Affects #289

I really like the idea, but right now I'm not sure, if it will work that way on all other supported platforms. I will test it on that platforms, too.

As the change is pretty targeted, it should not have negative effects on other platforms; At least I hope it doesn't. Could be the case that this isn't sufficient to address the problem everywhere, though.
Thanks for considering to merge this and for taking the time to test on all other supported platforms.

I took a deeper look at your PR. Right now it is not mergeable:

In case the original kernel was built using GCC 8, the __stack_chk_guard_setup must not be included, as the CONFIG_CC_HAVE_STACKPROTECTOR_SYSREG config flag is not set. The Raspberry Pi Kernel Maintainers allready stated, that new kernel releases will be built using GCC 8 until an updated GCC is available in Raspbian.
The PR adresses not all source files resulting in a invalid build at all

If it is fine for you, I will update the PR to adress that issues.

I've pushed an update to read the canary value from the running kernel instead of using a predefined hard-coded value. The error message now also matches the one found in mainline Linux kernel. Feeling way better now ;)
Please go ahead and make the proposed changes, you're the maintainer after all. Oh BTW, I've noticed the obligatory license header is still missing in buster_gcc_canary_workaround.h.
Many thanks!

PR wurde mit Commit 146c5a32 angepasst hinzugefügt.

 War mir eine Ehre und auch eine Freude, hier helfen zu können.


update confluent's dependencies to common, supported version

Description
Update io.confluent.* dependencies to common, updated version 6.2.12
currently used versions are EOL
This PR has:

[x ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

@xvrl
Could you give it a seal of approval?

version 7.5.1 leads to OOM in avro tests:
[INFO] Running org.apache.druid.data.input.AvroHadoopInputRowParserTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.820 s -- in org.apache.druid.data.input.AvroHadoopInputRowParserTest [INFO] Running org.apache.druid.data.input.avro.InlineSchemaAvroBytesDecoderTest [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.145 s -- in org.apache.druid.data.input.avro.InlineSchemaAvroBytesDecoderTest [INFO] Running org.apache.druid.data.input.avro.AvroOCFInputFormatTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.027 s -- in org.apache.druid.data.input.avro.AvroOCFInputFormatTest [INFO] Running org.apache.druid.data.input.avro.SchemaRegistryBasedAvroBytesDecoderTest java.lang.OutOfMemoryError: Java heap space Dumping heap to java_pid13052.hprof ... Heap dump file created [1628054318 bytes in 2.063 secs]
Trying more modern, still an older version (7.3.5) before reverting to 6.2.x

version 6.2.x should be supported until June 8, 2024,
in the meantime hopefully one can figure out while tests are failing with OOM


Duplicate JSON key in manifest causes build failure with no output

see comments thread for the actual bug
Describe the bug
I noticed that I can craft a manifest file that is clearly invalid JSON. Usually vcpkg will output a red message with the exact json error, but if I put certain $comments into the JSON file, vcpkg fails with no output at all.
Environment

OS: win10 19042
Compiler: vs2019 community

To Reproduce
This manifest file contains two comments, and causes the behavior for me.
{
    "name":"name",
    "$comment:":"hi",
    "version":"1.0.0",
    "$comment:":"hi",
    "builtin-baseline":"eefee7408133f3a0fef711ef9c6a3677b7e06fd7",
    "dependencies":[
        {"name":"zlib"}
    ],
    "overrides": [
        {"name":"zlib", "version-string":"1.2.11", "port-version":10},
    ]
}

vcpkg crashes without any output when I give it this file using this exact command:
E:/new_libs/scripts/vcpkg/vcpkg.exe install --feature-flags="manifests,versions" --triplet="x64-windows" --downloads-root="E:/new_libs/scripts/vcpkg-downloads-init" --overlay-ports="overlay" --x-install-root="e:/new_libsrelease/output//vs-2019_x64/vcpkg-libs/vcpkg-libs-5-12-21/"
If I  remove either comment from that and use a single comment,  I get this error:
- Failed to parse manifest at E:\new_libs\libs\vcpkg-libs\windows-x64\vcpkg.json:
- E:\new_libs\libs\vcpkg-libs\windows-x64\vcpkg.json:10:78: error: Trailing comma in array
-   on expression:               {"name":"zlib", "version-string":"1.2.11", "port-version":10},
-                                                                                ^
- Note: Updating vcpkg by rerunning bootstrap-vcpkg may resolve this failure.
- which has nothing to do with the comment

Expected behavior
An error every time regardless of the comments
note
The json has CRLF line endings and no tabs (just spaces)

Should be:
{
    "name": "name",
    "$comment:": "hi",
    "version": "1.0.0",
    "builtin-baseline": "eefee7408133f3a0fef711ef9c6a3677b7e06fd7",
    "dependencies": [
        {
            "name": "zlib"
        }
    ],
    "overrides": [
        {
            "name": "zlib",
            "version-string": "1.2.11",
            "port-version": 10
        }
    ]
}

?

Jack: Yes, that would be the correct manifest file that causes vcpkg to execute correctly.
The issue here is that if the manifest has invalid JSON, and it contains "certain comments" (in my case, it seemed to only happen if there was more than 1 comment) then vcpkg outputs nothing
If it were to output the red error message in my original post, It would be obvious that the comment needed to be removed from the manifest file to correct it. But I spent like an hour looking for a log file or something to explain why vcpkg was producing no output at all. I then found out that it normally outputs a JSON error message that is very helpful. But if there are "certain comments" that are themselves valid JSON,  then the JSON error does not get printed. I believe this is a bug.

it contains "certain comments"

I think the problem isn't certain comments (error in handling comments) but duplicate keys (invalid JSON).

If duplicate keys makes an invalid json file (doh! yeah that makes sense) then the fix is pretty simple, it should output a red error message similar to "error: duplicate key on line xxxx"

I can reproduce by duplicating any of the JSON keys

OTOH it is perhaps more important to improve vcpkg behaviour for valid data then to improve behaviour for invalid data. I suppose there are there tools for syntactical validation. (Typing jsonlint + <TAB> on my command prompt suggests jsonlint-php.)


HEA-572 Add field-level checks to xxx_valid_instances

@girumb please can you check this and then if you agree, merge it and release it to dev and rerun all xxx_instances and xxx_valid_instances. Then @h-kiros can review the output and start adding corrections to the GSheet for any BSS where we have negative kcals_consumed.

@h-kiros for the BSSs where we have negative kcals_consumed and percentage_kcals you will need to adjust the quantity_other_uses so that quantity_other_uses = quantity_produced - quantity_sold


AuhorizationPolicy with non istio-system workload selector doesn't support paths

Bug Description
I would like to build an application such that the /api path is secured with JWT by RequestAuthentication and AuthorizationPolicy that are matching the app: nginx deployment like so:
apiVersion: v1
kind: Service
metadata:
  name: httpbin
  labels:
    app: httpbin
spec:
  selector:
    app: httpbin
  ports:
  - name: http
    port: 8000
    targetPort: 80
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: httpbin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: httpbin
  template:
    metadata:
      labels:
        app: httpbin
    spec:
      containers:
      - image: docker.io/kennethreitz/httpbin
        imagePullPolicy: IfNotPresent
        name: httpbin
        ports:
        - containerPort: 80
---
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: api-gateway
spec:
  selector:
    istio: ingressgateway
  servers:
    - port:
        number: 80
        name: http
        protocol: HTTP
      hosts:
        - api.example.com
      # tls:
      #   httpsRedirect: true # need to disable until cert is issued
    - port:
        number: 443
        name: https
        protocol: HTTPS
      tls:
        mode: SIMPLE
        credentialName: api-example-com-tls
      hosts:
        - api.example.com
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: api-vs
spec:
  hosts:
    - example.com
  gateways:
    - api-gateway
  http:
    - match:
      - uri:
          exact: /api/jwks # This will override general /api/* endpoints
      rewrite:
        uri: /headers
      route:
      - destination:
          host: httpbin.istio-weekly.svc.cluster.local
          port:
            number: 8000
    - match:
      - uri:
          prefix: /api
      rewrite:
        uri: /status # test rewrite to status page
      route:
      - destination:
          host: httpbin.istio-weekly.svc.cluster.local
          port:
            number: 8000
---
apiVersion: security.istio.io/v1beta1
kind: RequestAuthentication
metadata:
  name: api-ra
spec:
  selector:
    matchLabels:
      app: httpbin
  jwtRules:
  - issuer: "me"
    jwks: "my_jwks_json"
---
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: api-ap
spec:
  selector:
    matchLabels:
      app: httpbin
  action: ALLOW
  rules:
  - from:
    - source:
        requestPrincipals:
        - example/*
    to:
    - operation:
        hosts:
        - example.com
        methods:
        - GET
        - POST
        paths:
        - "/api/*" # api requires jwt token
  - to:
    - operation:
        hosts:
        - example.com
        methods:
        - GET
        paths:
        - "/api/jwks" # want to make this publicly accessible

When I attempt to define these in the istio-weekly namespace, I find that the the paths values do not get applied.  When I create these in the istio-system namespace these DO work.
However, I require having a different CUSTOM authorization policy that uses an OAuth2 proxy configured in mesh extensionProviders for other paths on the same domain, and when these co-exist in the istio-system namespace they clash.
It seems that this is a bug that the AuthorizationPolicy can not be applied at the application workload level as the docs have an example for this: https://istio.io/latest/docs/reference/config/security/request_authentication/
When I make a curl request the endpoint with the path filter, I get back the following which includes a X-Envoy-Original-Path parameter, nto sure if this is somehow obfuscating the real path for the AuthorizationPolicy check.
curl https://api.example.com/api/jwks
{
  "headers": {
    "Accept": "*/*",
    "Host": "api.example.com",
    "User-Agent": "curl/7.79.1",
    "X-B3-Parentspanid": "3b36a8ad2a2fb46b",
    "X-B3-Sampled": "0",
    "X-B3-Spanid": "a80a318321f77dde",
    "X-B3-Traceid": "2142e66b0e5048bb3b36a8ad2a2fb46b",
    "X-Envoy-Attempt-Count": "1",
    "X-Envoy-Internal": "true",
    "X-Envoy-Original-Path": "/api/jwks",
    "X-Forwarded-Client-Cert": "By=spiffe://cluster.local/ns/istio-weekly/sa/default;Hash=78d36b3112029c2405b5b7509a0244eaa0cd234d48eee078e7733c6cc093d22a;Subject=\"\";URI=spiffe://cluster.local/ns/istio-system/sa/istio-ingressgateway-service-account"
  }
}

But when I added the path filter I get the following:
curl https://api.example.com/api/jwks
RBAC: access denied

Version
$ istioctl version
client version: 1.15.0
control plane version: 1.15.0
data plane version: 1.15.0 (4 proxies)
$ kubectl version --short
Client Version: v1.24.1
Kustomize Version: v4.5.4
Server Version: v1.22.13-eks-15b7512

Additional Information
$istioctl bug-report

Target cluster context: arn:aws:eks:us-east-1:474375891613:cluster/xxxxxxxx

Running with the following config:

istio-namespace: istio-system
full-secrets: false
timeout (mins): 30
include: {  }
exclude: { Namespaces: kube-node-lease,kube-public,kube-system,local-path-storage }
end-time: 2022-10-24 14:44:28.290588 +1100 AEDT

Cluster endpoint: https://00931F6A192C87C80B6CFB840D1C3608.gr7.us-east-1.eks.amazonaws.com
CLI version:
version.BuildInfo{Version:"1.15.0", GitRevision:"e3364ab424b70ca8ee1ca76cb0b3afb73476aaac-dirty", GolangVersion:"go1.18.5", BuildStatus:"Clean", GitTag:"1.15.0"}

The following Istio control plane revisions/versions were found in the cluster:
Revision default:
&version.MeshInfo{
    {
        Component: "pilot",
        Info:      version.BuildInfo{Version:"1.15.0", GitRevision:"e3364ab424b70ca8ee1ca76cb0b3afb73476aaac", GolangVersion:"", BuildStatus:"Clean", GitTag:"1.15.0"},
    },
}

The following proxy revisions/versions were found in the cluster:
Revision default: Versions {1.15.0}

Fetching proxy logs for the following containers:

cert-manager/cert-manager-cainjector/cert-manager-cainjector-6cd8d7f84b-8t78f/cert-manager
cert-manager/cert-manager-webhook/cert-manager-webhook-64d76db6c-2qlgn/cert-manager
cert-manager/cert-manager/cert-manager-7b8d75c477-pw8dh/cert-manager
istio-system/istio-ingressgateway/istio-ingressgateway-57486bb7b-6rc8h/istio-proxy
istio-system/istiod/istiod-795dbdd8d6-z4xw2/discovery
istio-weekly/httpbin/httpbin-7c5f796f9c-6g9ph/httpbin
istio-weekly/httpbin/httpbin-7c5f796f9c-6g9ph/istio-proxy
istio-weekly/nginx/nginx-7848d4b86f-trr6x/istio-proxy
istio-weekly/nginx/nginx-7848d4b86f-trr6x/nginx
oauth2-proxy/oauth2-proxy/oauth2-proxy-6867987d4d-jbqzh/istio-proxy
oauth2-proxy/oauth2-proxy/oauth2-proxy-6867987d4d-jbqzh/oauth2-proxy

Fetching Istio control plane information from cluster.

The following fetches are still running:
  kubectl get --all-namespaces authorizationpolicies.security.istio.io,certificaterequests.cert-manager.io,certificates.cert-manager.io,challenges.acme.cert-manager.io,clusterissuers.cert-manager.io,destinationrules.networking.istio.io,eniconfigs.crd.k8s.amazonaws.com,envoyfilters.networking.istio.io,gateways.networking.istio.io,grafanaagents.monitoring.grafana.com,issuers.cert-manager.io,istiooperators.install.istio.io,logsinstances.monitoring.grafana.com,metricsinstances.monitoring.grafana.com,orders.acme.cert-manager.io,peerauthentications.security.istio.io,podlogs.monitoring.grafana.com,podmonitors.monitoring.coreos.com,probes.monitoring.coreos.com,proxyconfigs.networking.istio.io,rayclusters.ray.io,rayservices.ray.io,requestauthentications.security.istio.io,securitygrouppolicies.vpcresources.k8s.aws,serviceentries.networking.istio.io,servicemonitors.monitoring.coreos.com,sidecars.networking.istio.io,telemetries.telemetry.istio.io,virtualservices.networking.istio.io,wasmplugins.extensions.istio.io,workloadentries.networking.istio.io,workloadgroups.networking.istio.io -o yaml
  PodExec istio-system/istiod-795dbdd8d6-z4xw2/discovery:pilot-discovery request GET debug/networkz
  ProxyGet istio-system/istio-ingressgateway-57486bb7b-6rc8h:runtime
  ProxyGet oauth2-proxy/oauth2-proxy-6867987d4d-jbqzh:runtime

Running istio analyze on all namespaces and report as below:
Analysis Report:
Info [IST0102] (Namespace cert-manager) The namespace is not enabled for Istio injection. Run 'kubectl label namespace cert-manager istio-injection=enabled' to enable it, or 'kubectl label namespace cert-manager istio-injection=disabled' to explicitly mark it as not needing injection.
Info [IST0102] (Namespace default) The namespace is not enabled for Istio injection. Run 'kubectl label namespace default istio-injection=enabled' to enable it, or 'kubectl label namespace default istio-injection=disabled' to explicitly mark it as not needing injection.

Your httpbin is deployed in default namespace, it is expected with a AuthorizationPolict defined in istio-weekliy namespace do not apply to httpbin. For istio-system, it has the implicit meaning it will apply to all ns

Your httpbin is deployed in default namespace, it is expected with a AuthorizationPolict defined in istio-weekliy namespace do not apply to httpbin. For istio-system, it has the implicit meaning it will apply to all ns

I should have set my default namespace to Istio-weekly when applying these changes so that is not the issue.

Reopening this, as it may not have been clear with my last edit (I believe this is still an issue)

I should have said - I set my default namespace to istio-weekly when applying these changes so that is not the issue.


[research] file upload support for rmb-peer

Related to #103
Introduction
RMB (relay) and messages can totally support file upload without changes. While it's a message protocol a message payload can be anything (for example chunk of a file) hence 2 peers implementing the protocols can perfectly agree to upload a file over multiple chunks and communicate ahead of the upload.
Things get a little bit more complicated when the rmb-peer implementation comes in between. the rmb-peer job is to implement a "gateway" that can run locally and then send and receive messages on behalf on multiple apps that can be running next to each other on the same local machine. It receive a request from a local machine, send it to remote peer, wait for answer and then send it back to the original caller.
For file upload the requirements state that, the local app send a request to the local peer, that peer then take care of communicating the file upload with the remote rmb-peer, then implement the upload (over chunks) or communicate errors back to the caller.
This sounds easier than in reality duo to async nature of the protocol. The rmb-peer then need to be changed a little bit to add more layers where we can inject application behavior (like extensions) inside peer itself.
Anyway this is about the research needed to be done to implement the right architecture to support this

Implementation in progress. research phase is complete


Make output great again

This sorts the tactiles by id so that the keys don't randomly jump around on the output list with the gauges.
Also it adds the ids to the output for debugging and stuff.

via GIPHY

@Metaa did the guy merge your pr to the clui repo? If so update the version in the package.json so we pull it in unless i did already? ill check

He did not
https://github.com/nathanpeck/clui/pull/11

update package.json to be a reference to your fork then.

nvm lgtm


Renko Strategy

Adding the Renko Strategy, based on Tradingview's "[LAVA] Renko Mod"

Related: GH-1809


Put cling pragma for loading fftw3 in headers

As in https://github.com/QuantStack/xtensor-io/blob/a57e3b90ca1025a180c5813c56b8a344ec2d8165/include/xtensor-io/xaudio.hpp#L20-L21, we can put the library loading step in the headers themselves, which saves cling/notebook users from doing it.

Also put this in CMakeLists.txt and in xtensor-fftw_config.hpp:
https://github.com/QuantStack/xtensor-io/blob/a57e3b90ca1025a180c5813c56b8a344ec2d8165/CMakeLists.txt#L18
This makes sure the library paths get properly added. Right now, the notebooks are already working, because I'm loading xtensor-io, which also sets all this stuff. Without xtensor-io and without the cling pragma, fftw calls would fail.


3024 encoding url path for file and folder

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4852

@pkdash nice use of parse.quote.
I do see issues when attempting to unzip as David mentioned:

As an additional test case, here is a zip file provided by a user a while back that was a problem. Filenames.zip It contains several files with unicode character names. If I attempt to unzip in hydroShare today I get a folder with only one file, i.e. several of the files are not extracted.
Will the solution suggested resolve this.

But maybe we plan to address this with PR https://github.com/hydroshare/hydroshare/pull/4797 to fix issue https://github.com/hydroshare/hydroshare/issues/2538?

@devincowan Thanks for testing for unzip. I will be looking into the unzip issue using the sample zip file.

@devincowan and @dtarb Did some testing with the sample zip file (Filenames.zip). This zip contains files that have English language characters only in the filename. Still the irods 'ibun' command  only extracts one file and doesn't report any error. I created another zip file containing a file that has non-english characters in its filename. The ibun command fails to unzip this zip file and throws an exception. The exception message is not that helpful. Since we can upload and download files with non-english character, irods seems to be fine handling unicode.  So it seems for some reason the 'ibun' command doesn't like unicode filename.
This is the error the ibun command generates when the zip file has files with non-english characters:
"Error processing IRODS request: 3. stderr follows:\n\nb'remote addresses: <IP_ADDRESS> ERROR: bunUtil: opr error for /hydroshareZone/home/wwwHydroProxy/d2c579b1301e4796aecce9d0dfdb25a6/data/contents/0ec90d514492491badb702bce5af40a8, status = -806000 status = -806000 CAT_SQL_ERR\\n'")
I am not sure how to proceed with this PR. I would suggest that we should create a separate issue for the ibun command and discuss the issue with someone from irods.

@hyi may have some thoughts.  She worked with ibun quite a lot.

@pkdash I'm in favor of making a separate issue for the ibun issues...


added a program file that uses heap sort

hi sir ,,,
i have wrote a solution of heap sort ..if you find my solution valid then please push it and mark label it as hacktoberfest ..
with regards
Amritpal singh

follow contribution guidelines, update documentations too


fix typo in comment

fix // Create arrays with ech character types
to // Create arrays with each character types

addressed


without format file

..

I think It's done if not, close this issue.

This PR:

Has no appropriate title
No issue linked in the PR Description
No screenshots/clip of the change
No explanation of the work

Hence does not meet the guidelines for contribution


Retry mechanism looks broken

When using retry on a flaky test suite, I expect to have the test (or test suite) to be re-run on this device until it's OK or it reaches the max retry attempt. If the retry is OK, then the build on Bitrise should be green too.
What I observed is that if 1 device fails to run my tests, it will be asked to rerun it but doesn't take into account the result, so it will re-run until the max retry attempt, and the result is build failed.

Previous discussion on the retry mechanism:
https://github.com/bitrise-steplib/steps-virtual-device-testing-for-android/issues/39
https://discuss.bitrise.io/t/retry-mechanism-on-tasks/8456

Seeing the same issue, any update on this?

Hi @glureau-betclic @JoeMaher
The Number of times a test execution is reattempted input of the step sets the --num-flaky-test-attempts flag of the test run, based on the docs: https://cloud.google.com/sdk/gcloud/reference/firebase/test/android/run .
Specifies the number of times a test execution should be reattempted if one or more of its test cases fail for any reason. An execution that initially fails but succeeds on any reattempt is reported as FLAKY. The maximum number of reruns allowed is 10. (Default: 0, which implies no reruns.) All additional attempts are executed in parallel.
So this flag is not like a retry (which re-runs the step in case of failure and after the first successful run marks it as successful), it supposed to prove that the test case is flaky (this can be done by re-running the test case as many times as defined via the flag so that you can see: 5 run failed out of 10 runs, so this case if flaky).
Please don't hesitate to follow-up if you have any other questions.
Kind regards,
Luna

Can the wording be altered then? It is very misleading.

Specifies the number of times a test execution should be reattempted if one or more of its test cases fail for any reason. An execution that initially fails but succeeds on any reattempt is reported as FLAKY.

Where does it get marked as flaky?

@JoeMaher This is Google's documentation not ours. Please read through their documentation for more information. Thanks!

I agree that the documentation should be improved on the workflow step. Currently it says:

Specifies the number of times a test execution should be reattempted if one or more of its test cases fail for any reason. An execution that initially fails but succeeds on any reattempt is reported as FLAKY.
The maximum number of reruns allowed is 10. (Default: 0, which implies no reruns.)

This should include the All additional attempts are executed in parallel.
But, for me, the most important change we can make here is that I was expecting the stage to pass if the test passed on any of the retries. It seems incorrect to me to fail the step if a test is flaky. Flaky means that it passed at least once, so I think that it should not mark the step as failed.


Node Drag by Icon or Similar

Hello,
I am creating flow items with title and detail as per the image.  I want the user to be able to edit them by clicking on them. This is clashing when clicking the node, as the node then becomes draggable or the text is selected and treated as a new node.  Is it possible to add say a small box or icon in the bottom right hand corner that can be used to drag the node around instead and not make the whole node selectable?

Thanks

You could reverse the solution of this comment. Or adapt-it with some kind of css class.

https://github.com/jerosoler/Drawflow/issues/423#issuecomment-1134886506

Thank you as ever, I can do something with that.


add metadata field to flag classifications for already seen subjects

Closes https://github.com/zooniverse/Panoptes-Front-End/issues/359 based of discussion in #843
This adds an optional metadata#seen_before boolean attribute that can be submitted if a volunteer (logged in & anonymous) has classified this subject before. @brian-c you ok with this solution if the subject has been seen before?
Happy to make changes, thought I'd get this into code for discussion.

This looks fine to me. I'm a bit wary of relying on clients to be well-behaved, but it should only affect when retirement is triggered.

There's already an already_seen property on subjects, right? Is this different?
A subject's metadata is a direct dump from the manifest, so can we either rename that property or find another place for internal metadata?

Yeah this enables the classification to store the seen_before state and not have to reference a user's seen set to understand the timing of the duplicate classifications. Also it allows anonymous users to mark that they've seen a subject in a session already.

@edpaget, yeah it's totally client dependent. This is just another attribute that the aggregation engine / research teams can use to detect possible duplicate classifications for a user on a subject.

I'm good to merge if this idea seem all right to you @brian-c

No problem. When a back-end change requires front-end changes, would one of you open an issue there and provide the details so I make sure I'm doing things right? Thanks.

@brian-c i'll do it now


Feature/open media file

Removed unnecessary boiler plate code regarding ipcrenderer.on
Connected import UI to renderer function and main listener.
Linked media import to new project action.

Irmy and I paired on this, so will wait on approval from someone else


Pin to version 0.3.1 of Open SDG

Pin to a certain version of Open SDG so that unexpected changes won't happen.

thanks @brockfanning

@brockfanning I merged the PR, try to re-run the nightly build from last night, but it failed.  I'll check tomorrow evening to see if PR work, thanks!

@dawncomer Ok, yeah that's because when you "re-run" a particular build, it uses the same snapshot of code that it used originally. So, if you re-run a build that failed originally, it's probably going to fail again.
But FYI, there's no need to manually re-run a build after every merge - when you click "Merge" that actually kicks off a build. See build #130 here, which is the build that got kicked off when you merged the PR.
In a nutshell, there are 2 ways to do a new build:

Merge a PR
Wait for the nightly build

got it! thank @brockfanning


Update to winit 0.18.0 + release glutin 0.19.0

This also updates any dependencies that were updated in winit.

Anything blocking on that ??

Ah, sorry! I forgot to merge this.


Struct not declared by package wire

Hello everyone
I using wire for DI in my project, my code is following:
func NewContainer() (*services.Container, error) {
	containerSet := wire.NewSet(
		wire.Struct(new(services.Container), "Country"),
	)
	wire.Build(containerSet)
	return &services.Container{}, nil
}

But, when I run command:
$ wire

It output this error:
... Struct not declared by package wire

Maybe this line: "wire.Struct(new(services.Container), "Country"),"
Anyone can help me slove this issue ? It seem like wire v0.2.2 does not support Struct method ?
my go.mod
module mprof

go 1.12

require (
	github.com/Masterminds/squirrel v1.1.0
	github.com/go-sql-driver/mysql v1.4.1
	github.com/google/go-cmp v0.3.0 // indirect
	github.com/google/wire v0.2.2
	github.com/jinzhu/gorm v1.9.4
	github.com/spf13/cobra v0.0.3
	github.com/spf13/viper v1.3.2
	go.uber.org/atomic v1.3.2 // indirect
	go.uber.org/multierr v1.1.0 // indirect
	go.uber.org/zap v1.10.0
	golang.org/x/crypto v0.0.0-20190513172903-22d7a77e9e5f // indirect
	golang.org/x/net v0.0.0-20190509222800-a4d6f7feada5 // indirect
	golang.org/x/sys v0.0.0-20190509141414-a5b02f93d862 // indirect
	golang.org/x/text v0.3.2 // indirect
	golang.org/x/tools v0.0.0-20190513233021-7d589f28aaf4 // indirect
)

The same example : https://github.com/google/wire/blob/master/docs/guide.md#struct-providers also output similar error !

Hi, Struct is a new feature that is not included in v0.2.2. It will be in the next release. You would need to use master for now if you want to use it.

@euclid1990 -- you can wait until the next release (should be in the next week or two), or until then you can update your go.mod file to request a pseudo-version. For example, something like go get github.com/google/wire@d76a979 should do it.

@shantuo Ok, thank you for your answer!
@vangent Thank you for your solution, I will try it 👍 ro


Alignment with new ETSI NFV descriptors in YANG format (SOL006)

Align 5GTANGO's terminology to ETSI terminology as far as possible (e.g., rename/restructure fields).
Identify gaps between the two information models.
Aim for high standardization impact.
This probably requires quite some effort, to check all relevant ETSI documentation and compare it with ours. Any help is appreciated.

SOL006 has been submitted to NFV TSC for final approval. The final version of the GS is going to be available once it has been published. The correct location to access the latest YANG files can be found here.
https://forge.etsi.org/rep/nfv/SOL006/blob/v2.6.1/src/yang/
Rapporteur for SOL006.


Offline not working and error caught (in promise) non-precached-url: non-precached-url :: [{"url":"/"}]

Hello, when installing @vite-pwa/astro im having this issue. It seems like it isnt working offline and im getting this error: caught (in promise) non-precached-url: non-precached-url :: [{"url":"/"}].
here is a minimal example of the issue. https://github.com/ttijl/astro-pwa-issue

@ttijl check https://docs.astro.build/en/guides/server-side-rendering/#hybrid-rendering

Thank you, that works.
One other question, how can i make the PWA network-first. So only using cache if network isnt working

@ttijl the problem is precaching, check this issue, you'll need to add a custom sw: https://github.com/GoogleChrome/workbox/issues/1767
You can also check this PR patching workbox-preload module to make the update quicker, you should check how to apply the patch using yarn: https://github.com/vite-pwa/docs/pull/41

Custom SW is only possible with InjectManifest right? And that does not work with Astro? I also tried this: https://vite-pwa-org.netlify.app/workbox/inject-manifest.html#network-first-strategy

Custom SW is only possible with InjectManifest right?
yes

And that does not work with Astro?

why not? it should work

I also tried this: https://vite-pwa-org.netlify.app/workbox/inject-manifest.html#network-first-strategy

and?