AttributeError: 'NullTypeNode' object has no attribute 'find_end_of_stream'

Hi,
When attempting to parse an evtx file as gathered by a collector on a Win server 2012 R2 box ; I get the following errors:
 ./evtx_dump.py Archive-ForwardedEvents-2017-07-19-09-54-122.evtx

<?xml version="1.1" encoding="utf-8" standalone="yes" ?>

<Events>
Traceback (most recent call last):
  File "./evtx_dump.py", line 46, in <module>
    main()
  File "./evtx_dump.py", line 41, in main
    print(record.xml())
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Evtx.py", line 481, in xml
    return e_views.evtx_record_xml_view(self)
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Views.py", line 204, in evtx_record_xml_view
    return render_root_node(record.root())
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Views.py", line 182, in render_root_node
    for sub in root_node.substitutions():
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/BinaryParser.py", line 64, in __call__
    cache[key] = self.func(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 1001, in substitutions
    ofs = self.tag_and_children_length()
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 962, in tag_and_children_length
    for child in self.children():
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/BinaryParser.py", line 64, in __call__
    cache[key] = self.func(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 952, in children
    return self._children(end_tokens=[SYSTEM_TOKENS.EndOfStreamToken])
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 159, in _children
    ofs += child.length()
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/BinaryParser.py", line 64, in __call__
    cache[key] = self.func(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 177, in length
    for child in self.children():
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/BinaryParser.py", line 64, in __call__
    cache[key] = self.func(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 334, in children
    SYSTEM_TOKENS.CloseEmptyElementToken])
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 162, in _children
    if child.find_end_of_stream():
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/BinaryParser.py", line 64, in __call__
    cache[key] = self.func(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/python_evtx-0.6.0-py2.7.egg/Evtx/Nodes.py", line 186, in find_end_of_stream
    ret = child.find_end_of_stream()
AttributeError: 'NullTypeNode' object has no attribute 'find_end_of_stream'

running Python 2.7.9 on Debian 8.  I installed the current version of python-evtx using the setup.py utility from the github download.  Please let me know if you need any more details.

Hi @linedash
Thanks for taking the time to report this issue!
Are you able to share an evtx file that demonstrates this issue? I've learned that its critical to add unit and regression tests as we find issues to 1) demonstrate bugs, and 2) ensure they don't creep back in. I can always try to blindly fix a bug, but I strongly prefer not to do this.

Hi @williballenthin
Would it be possible to get an email address or somewhere I could send one a link to one?  I wouldn't be comfortable releasing it into the wild due to the nature of the data.
I'll see if I can get someone to sign off on me releasing the data in the meantime.

Hey @linedash,
No problem. At least seeing the source data will allow me to triage the
issue. You can email me at<EMAIL_ADDRESS>On Fri, Jul 21, 2017 at 4:08 AM linedash<EMAIL_ADDRESS>wrote:

Hi @williballenthin https://github.com/williballenthin
Would it be possible to get an email address or somewhere I could send one
a link to one? I wouldn't be comfortable releasing it into the wild due to
the nature of the data.
I'll see if I can get someone to sign off on me releasing the data in the
meantime.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/williballenthin/python-evtx/issues/40#issuecomment-316934795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJjkBkIl41okONiTKYnkFRSaCMFOAL9ks5sQFx-gaJpZM4Oc1H7
.

Hello,
After checking couple of document. It looks like for this error there are some new specifications. Is it possible to let me know which file I have to change to handle this exception.
In the new RPC document published by microsoft.
https://msdn.microsoft.com/en-us/library/cc231282.aspx
I am seeing a section which could possibly fix this issue.
Before emitting anything, the tool SHOULD verify that the attribute data, as specified by the
AttributeCharData rule in 2.2.12, is not empty. If the attribute data is empty, the tool SHOULD NOT
emit anything. If the attribute data is not empty, emit the space character " " and the text, as
specified by the Name rule in 2.2.12, the character "=", the character "'", the text, as specified by the
AttributeCharData rule in 2.2.12, and, finally, the character "'".
Any help to fix this would be wonderful.
Thank you in advance for taking a looking into this.

Hi @williballenthin,
I have been trying to convert the .evtx logs to XML. With the help of your code, I am able to convert a set of logs and few logs I'm not able to convert. I'm getting this error :
Traceback (most recent call last):
File "<pyshell#19>", line 1, in
EvtxToElk.evtx_to_elk("C:\Users\517214\Downloads\Archive-ForwardedEvents-2018-01-09.evtx",'http://localhost:9200')
File "C:\Python36\lib\site-packages\evtxtoelk_init_.py", line 34, in evtx_to_elk
for xml, record in evtx_file_xml_view(fh):
File "C:\Python36\lib\site-packages\Evtx\Views.py", line 240, in evtx_file_xml_view
record_str = evtx_record_xml_view(record)
File "C:\Python36\lib\site-packages\Evtx\Views.py", line 204, in evtx_record_xml_view
return render_root_node(record.root())
File "C:\Python36\lib\site-packages\Evtx\Views.py", line 182, in render_root_node
for sub in root_node.substitutions():
File "C:\Python36\lib\site-packages\Evtx\BinaryParser.py", line 64, in call
cache[key] = self.func(*args, **kw)
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 1001, in substitutions
ofs = self.tag_and_children_length()
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 962, in tag_and_children_length
for child in self.children():
File "C:\Python36\lib\site-packages\Evtx\BinaryParser.py", line 64, in call
cache[key] = self.func(*args, **kw)
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 952, in children
return self._children(end_tokens=[SYSTEM_TOKENS.EndOfStreamToken])
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 159, in _children
ofs += child.length()
File "C:\Python36\lib\site-packages\Evtx\BinaryParser.py", line 64, in call
cache[key] = self.func(*args, **kw)
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 177, in length
for child in self.children():
File "C:\Python36\lib\site-packages\Evtx\BinaryParser.py", line 64, in call
cache[key] = self.func(*args, **kw)
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 334, in children
SYSTEM_TOKENS.CloseEmptyElementToken])
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 162, in _children
if child.find_end_of_stream():
File "C:\Python36\lib\site-packages\Evtx\BinaryParser.py", line 64, in call
cache[key] = self.func(*args, **kw)
File "C:\Python36\lib\site-packages\Evtx\Nodes.py", line 186, in find_end_of_stream
ret = child.find_end_of_stream()
AttributeError: 'NullTypeNode' object has no attribute 'find_end_of_stream'
Please help me in resolving the issue...

I just triggered this same issue on a file from a memory sample.

Hi @williballenthin
I've been trying to parse some .evtx aswell and experienced the same behaviour. From what I've tried and what I see in the comments above (the names of the test files of @sanju1323 and @linedash ), it seems to be an issue with the ForwardedEvents type. I looked at the structure of the BinXML of this type of events and it seems to be quite different, but I'm unable to adapt the library so far.
On an Application .evtx I don't trigger the error :
evtx_structure.py Application.evtx  | head -50
File header
  magic: ElfFile
  oldest_chunk: 0x0
  current_chunk_number: 0x7e
  next_record_number: 0x4ecf
  header_size: 0x80
  minor_version: 0x1
  major_version: 0x3
  header_chunk_size: 0x1000
  chunk_count: 0x7f
  flags: 0x1
  checksum: 0x87589e25
  verify: True
  dirty: True
  full: False
  Chunk
    offset: 0x1000
    magic: ElfChnk
    file_first_record_number: 0x1
    file_last_record_number: 0x74
    log_first_record_number: 0x1
    log_last_record_number: 0x74
    header_size: 0x80
    last_record_offset: 0xfdf8
    next_record_offset: 0xfec8
    data_checksum: 0xe8788113
    header_checksum: 0x51b42232
    verify: True
    templates: 0
    Record
      offset: 0x1200
      magic: 0x2a2a
      size: 0x7b8
      number: 0x1
      timestamp: 2012-07-09 07:02:00
      verify: True
      RootNode(offset=0x18)
        StreamStartNode(offset=0x18)
        TemplateInstanceNode(offset=0x1c, resident=True, length=0x575)
          TemplateNode(offset=0x26)
            StreamStartNode(offset=0x3e)
            OpenStartElementNode(offset=0x42) --> Event
              AttributeNode(offset=0x65) --> xmlns
                ValueNode(offset=0x7e)
                  WstringTypeNode(offset=0x80) --> http://schemas.microsoft.com/win/2004/08/events/event
              CloseStartElementNode(offset=0xec)
              OpenStartElementNode(offset=0xed) --> System
                CloseStartElementNode(offset=0x10e)
                OpenStartElementNode(offset=0x10f) --> Provider
                  AttributeNode(offset=0x138) --> Name
[...]

On a ForwardedEvent I trigger errors :
evtx_structure.py Forward.evtx  | head -50
File header
  magic: ElfFile
  oldest_chunk: 0x0
  current_chunk_number: 0x10
  next_record_number: 0xf0
  header_size: 0x80
  minor_version: 0x1
  major_version: 0x3
  header_chunk_size: 0x1000
  chunk_count: 0x11
  flags: 0x0
  checksum: 0xf278fc1e
  verify: True
  dirty: False
  full: False
  Chunk
    offset: 0x1000
    magic: ElfChnk
    file_first_record_number: 0x1
    file_last_record_number: 0xa
    log_first_record_number: 0x1
    log_last_record_number: 0xa
    header_size: 0x80
    last_record_offset: 0xc628
    next_record_offset: 0xea10
    data_checksum: 0xea19cd0c
    header_checksum: 0x5e0c09b8
    verify: True
    templates: 0
    Record
      offset: 0x1200
      magic: 0x2a2a
      size: 0x1400
      number: 0x1
      timestamp: 2019-04-10 10:42:26.529150
      verify: True
      RootNode(offset=0x18)
ERROR: 'NullTypeNode' object has no attribute 'find_end_of_stream'
    Record
      offset: 0x2600
      magic: 0x2a2a
      size: 0x1148
      number: 0x2
      timestamp: 2019-04-10 10:42:26.529150
      verify: True
      RootNode(offset=0x18)
ERROR: Tried to parse beyond the end of the file (read: 0x731006, buffer length: 0x111000)
    Record
      offset: 0x3748
      magic: 0x2a2a
      size: 0x1148
      number: 0x3
      timestamp: 2019-04-10 10:42:26.529150
      verify: True
      RootNode(offset=0x18)
ERROR: Tried to parse beyond the end of the file (read: 0x731006, buffer length: 0x111000)
    Record
      offset: 0x4890
      magic: 0x2a2a
      size: 0x1148
      number: 0x4
      timestamp: 2019-04-10 10:42:26.529150
      verify: True
      RootNode(offset=0x18)
ERROR: Tried to parse beyond the end of the file (read: 0x731006, buffer length: 0x111000)
    Record
      offset: 0x59d8
      magic: 0x2a2a
      size: 0x1148
      number: 0x5

[...]

Hope it helps resolving this issue


updated drop down to handle slots

The problem is in the select tag (HTML)  the entire string from the rasa server was not identified properly. That has been handled in js.

updated the drop down button to handle the slot values


other types support

Expect to support vector2, vector3, and vector4 types, expect to support image preview and image upload.Thanks♪(･ω･)ﾉ

Hi, there are no plans to add additional controllers or custom controllers. See https://github.com/georgealways/lil-gui/issues/12#issuecomment-1491911960.
Tweakpane has great support for this as well.


Startup

Hi Cratery team,
I have started to deploy it using docker/docker-compose and v1.8.0.
The first 2 issues I have solve by myself are:

the data was not in read/write mode, created by root by default (by docker-compose), using a local directory it works
the websocket privatekey was too short, I have generate more longer. It may be very cool to have in the error the minimal length. The errror was: called Result::unwrap() on an Err value: TooShort(30)

And now I'm face to git repository configuration.
I got:
[2024-08-12 07:38:27]	INFO	cratery commit=0556d1e20180614586b4ad1359bd8c59b39e51bb tag=v1.8.0
[2024-08-12 07:38:27]	INFO	Database schema version = 1.5.0
[2024-08-12 07:38:27]	INFO	precaching crates.io index
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
[2024-08-12 07:38:27]	ERROR	The operation failed in the backend. ()
[2024-08-12 07:38:27]	ERROR	disabled backtrace

If I'm looking well, the git index repository configuration seems optional (https://github.com/cenotelie/cratery/tree/0556d1e20180614586b4ad1359bd8c59b39e51bb?tab=readme-ov-file#index)
Is it true ? I have tried to configured a repo, but it does not works
[2024-08-12 08:22:19]	INFO	index: pulling changes from origin
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
thread 'main' panicked at src/main.rs:164:71:
called `Result::unwrap()` on an `Err` value: ApiError { http: 500, message: "The operation failed in the backend.", details: Some(""), backtrace: Some(Backtrace [{ fn: "cratery::utils::apierror::ApiError::new" }, { fn: "cratery::services::index::execute_git::{{closure}}" }, { fn: "cratery::application::Application::launch::{{closure}}" }, { fn: "tokio::runtime::park::CachedParkThread::block_on" }, { fn: "tokio::runtime::runtime::Runtime::block_on" }, { fn: "cratery::main" }, { fn: "std::sys_common::backtrace::__rust_begin_short_backtrace" }, { fn: "std::rt::lang_start::{{closure}}" }, { fn: "std::rt::lang_start_internal" }, { fn: "main" }, { fn: "__libc_start_main" }, { fn: "_start" }]) }
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::result::unwrap_failed
   3: tokio::runtime::park::CachedParkThread::block_on
   4: tokio::runtime::runtime::Runtime::block_on
   5: cratery::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

After remove a created folder crates.io in the data folder, it works.


Poetry install did not work on mac with m1/m2 because the z3-solver version used doesn't have an arm package

I don't know much about poetry but the quick fix was to make the following changes to poetry.lock:
Comment out the old version, add the new version:
[[package]]
name = "z3-solver"
#version = "<IP_ADDRESS>"
version = "<IP_ADDRESS>"
description = "an efficient SMT solver library"
category = "main"
optional = false
python-versions = "*"

Then add the last line to the z3-solver metadata section:
z3-solver = [
...,
    {file = "z3_solver-<IP_ADDRESS>-py2.py3-none-macosx_11_0_arm64.whl", hash = "sha256:5686cb33148db4a3dc7bbe3faec0fdb631c86512c69c6c4971c5d805f764c713"},
]

Hey @sethsec-bf, thanks for raising along with the solution :) I've pushed up a new lock file to arm-z3 branch, do you mind checking it out and making sure it installs on mac?

Worked like a charm!

Cool that's been merged in


Docs: Use branch name substitution for all links

Using branch name substitutions now for every link.
For details see https://github.com/ros-controls/control.ros.org/pull/98

@mergifyio backport humble


[WIP] Set max message length in network

:white_check_mark: Build AElf <IP_ADDRESS>7 completed (commit https://github.com/AElfProject/AElf/commit/098c53d1d7 by @zhxymh)


Ionic - Capacitor | Tailwind breaks build on Xcode

Describe the Bug
Hi team,
Thank you for this awesome library.
I am facing an issue:
I cannot build on Xcode for any IOS device with Capacitor using react-email/tailwind.
Which package is affected (leave empty if unsure)
@react-email/tailwind
Link to the code that reproduces this issue

To Reproduce
Steps to reproduce:

Import and use in Tailwind

import { Tailwind } from '@react-email/tailwind';
...
const RenderEmail: any = () => {
return (
    <Html>
      <Tailwind>
        <Body>
        </Body>
      </Tailwind>
    </Html>
  );
};

Sync Capacitor
capacitor sync ios

On Xcode, run on any device

See error in logs

------ STARTUP JS ERROR ------

⚡  SyntaxError: Invalid regular expression: invalid group specifier name
⚡  URL: http://<IP_ADDRESS>:8101/static/js/bundle.js
⚡  [error] - {"line":444536,"sourceURL":"http://<IP_ADDRESS>:8101/static/js/bundle.js"}
⚡  bundle.js:444536:0

The line 444536 in bundle shows:
let e = /*#__PURE__*/(0,____node_modules_babel_runtime_helpers_esm_wrapRegExp_js__WEBPACK_IMPORTED_MODULE_0__["default"])(/(?<=\.)[^{]+\s*\{([^{}]*(?:(?<=;)\s*\n\r?[^{}]*)*)\s*\}/gm, {

If I don't import Tailwind, the error is gone.
Expected Behavior
No error on build
What's your node version? (if relevant)
0.0.8

That is probably due to the look-behind regex expressions on the tailwind component and on one of its dependencies, there is a PR underway that doesn't use these anymore, but for now this is a workaround for it.


error installing cryptography module

Informations

Qiskit version 0.10.1
Python version 3.5.2
Operating system Ubuntu 16.04 LTS

What is the current behavior?
pip install qiskit-ibmq-provider fails to install with a compiler error during building cryptography module
  Failed building wheel for cryptography
  Running setup.py clean for cryptography
Failed to build cryptography
Installing collected packages: ntlm-auth, asn1crypto, six, pycparser, cffi, cryptography, urllib3, idna, chardet, certifi, requests, requests-ntlm, ply, marshmallow, marshmallow-polyfield, mpmath, sympy, psutil, numpy, scipy, decorator, networkx, pylatexenc, jsonschema, pillow, qiskit-terra, websockets, qiskit-ibmq-provider
  Running setup.py install for cryptography ... error
    Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-dy7d10o4/cryptography/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-9vewcth6-record/install-record.txt --single-version-externally-managed --compile --user --prefix=:
    /usr/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'python_requires'
      warnings.warn(msg)
    running install
    running build
    running build_py

...

    reading manifest file 'src/cryptography.egg-info/SOURCES.txt'
    reading manifest template 'MANIFEST.in'
    no previously-included directories found matching 'docs/_build'
    warning: no previously-included files matching '*' found under directory 'vectors'
    writing manifest file 'src/cryptography.egg-info/SOURCES.txt'
    running build_ext
    generating cffi module 'build/temp.linux-x86_64-3.5/_padding.c'
    creating build/temp.linux-x86_64-3.5
    generating cffi module 'build/temp.linux-x86_64-3.5/_constant_time.c'
    generating cffi module 'build/temp.linux-x86_64-3.5/_openssl.c'
    building '_openssl' extension
    creating build/temp.linux-x86_64-3.5/build
    creating build/temp.linux-x86_64-3.5/build/temp.linux-x86_64-3.5
    x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.5m -c build/temp.linux-x86_64-3.5/_openssl.c -o build/temp.linux-x86_64-3.5/build/temp.linux-x86_64-3.5/_openssl.o -Wconversion -Wno-error=sign-conversion
    build/temp.linux-x86_64-3.5/_openssl.c:498:30: fatal error: openssl/opensslv.h: No such file or directory
    compilation terminated.
    error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

    ----------------------------------------
Command "/usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-dy7d10o4/cryptography/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-9vewcth6-record/install-record.txt --single-version-externally-managed --compile --user --prefix=" failed with error code 1 in /tmp/pip-build-dy7d10o4/cryptography/

Steps to reproduce the problem
pip install qiskit-ibmq-provider
What is the expected behavior?
correct installation of the library
Suggested solutions
pre-req installation of libssl-dev
sudo apt-get install libssl-dev
Maybe this should be added to the documentation?

@diego-plan9 could you look at this and update as needed.

Sure - as a general guideline and reference for similar issues, failures that involve compilation tend to be due to some of the Qiskit dependencies (in this case, the cryptography package) not providing a binary wheel for the system where the package is being installed (ie. a combination of python version/architecture). In those cases, pip will try to install it using the source package - which in turn, ends up requiring some extra development headers that might be missing in the host system, and cannot be installed from pip itself - their exact installation tends to vary between distributions and platforms.
I'll issue a PR trying to find the right place in the docs for this information - in the meantime, for this particular issue, the cryptography installation section seems indeed to recommend:
$ sudo apt-get install build-essential libssl-dev libffi-dev python3-dev

thank you :)


*: Use Rust-style naming for all protobuf messages and fields

PTAL @BusyJay @breeswish
What have you changed? (mandatory)
This relies on a fork of rust-protobuf. It means that Prost and rust-protobuf will generate protobuf code which mostly use the same names. Mostly this is just changing to use snake case or camel case.
What are the type of the changes? (mandatory)

Engineering (engineering change which doesn't change any feature or fix any issue)

How has this PR been tested? (mandatory)
Existing unit tests
Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No

Can you also open an issue to the rust-protobuf repository? I think the whole community can benefit from this if it's fixed inside rust-protobuf.

rebased. @breeswish @BusyJay PTAL

rebased. @breeswish @BusyJay PTAL

/run-all-tests

/run-all-tests

/merge

/run-all-tests

/run-all-tests

/merge

/merge


#[derive(Clone)]

Perhaps add #[derive(Clone)] to top-level structs and enums.  This would simplify my own code in several places.

Publised as version 0.1.7


remote php.validate.executablePath

Today everyone is using virtual environments. In my case, i need to maintain a mass of microservices which got diffrent configurations. Espacialy the php version in combination with diffrent extensions.
Therefore i would like to execute the php, which is located on the virtual machine! To make that happen i need the ability to configurate that.

@chrisdias @egamma FYI.

i think this extention usefull

Thanks for the advice. I'am already using that extension. But that doesn't solve the reported feature request.
Actually i'am forced to install PHP with every extension including the configs on my local machine, to use the benefits which are provided by php.validate.executablePath. But it shouldn't be necessary because the needed PHP with every extension including the configs are already installed and configured on the virtual machine. That way i have to maintain two environments for one. And if you got multiple environments things get really complicated.

I'm not sure how we could use PHP on the remote machine (which has its own environment and may be a different OS, etc). Do you know if this is done for any other languages?

It would be great if you can support this feature to setup a PHP executable running in a Docker container

And also in Vagrant.

The builtin PHP support is very simple, I recommend using a PHP extension and requesting this support there. Unless anyone has a simple idea of how this could work.


not strict type of step's action for extended action

we should not strict the action of step due to extended action may have different step action type

@netweng PTAL

LGTM


parameters dont have comment about valid values in several properties or have link that has valid values

parameters dont have comment about valid values in several properties or have link that has valid values
don't provide syntax for all values
az vm create does not have valid values for:
size,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 152b549b-d4b3-13e5-081c-c604b6e4d89e
Version Independent ID: 3f79be78-ce75-ad31-304b-bad7d475ec9e
Content: az vm
Content Source: src/azure-cli/azure/cli/command_modules/vm/_help.py
Service: virtual-machines
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

You can use az vm list-sizes  to list all available sizes in your location.
Run az vm create -h
or visit
https://docs.microsoft.com/en-us/cli/azure/vm?view=azure-cli-latest#az-vm-create
You can see help
--size

The VM size to be created. See https://azure.microsoft.com/en-us/pricing/details/virtual-machines/ for size info.
default value: Standard_DS1_v2

It is hard to provide valid size values because they depend on location.
We will revise the help message to include how to get valid value list.


flow: 0.154.0 -> 0.155.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/facebook/flow/releases.
meta.description for flow is: "A static type checker for JavaScript"
meta.homepage for flow is: "https://flow.org/"
meta.changelog for flow is: "https://github.com/facebook/flow/raw/v0.155.0/Changelog.md"
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/kzdcx3aw8y649fl6a167adqfsg318gzf-flow-0.155.0/bin/flow passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 0.155.0 with grep in /nix/store/kzdcx3aw8y649fl6a167adqfsg318gzf-flow-0.155.0

found 0.155.0 in filename of file in /nix/store/kzdcx3aw8y649fl6a167adqfsg318gzf-flow-0.155.0

directory tree listing: https://gist.github.com/8a1375b7a24a61b59fb3bc6b950281c4

du listing: https://gist.github.com/125624011c50bfdd117c2540aac534bd

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
flow

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kzdcx3aw8y649fl6a167adqfsg318gzf-flow-0.155.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flow https://github.com/r-ryantm/nixpkgs/archive/36308698b3acba1079d4330c4ce92e915894b04f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kzdcx3aw8y649fl6a167adqfsg318gzf-flow-0.155.0
ls -la /nix/store/kzdcx3aw8y649fl6a167adqfsg318gzf-flow-0.155.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

flow

Maintainer pings
cc @marsam @puffnfresh for testing.

Result of nixpkgs-review pr 129725 at 36308698 run on x86_64-linux 1

1 package built successfully:

flow

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/tools/analysis/flow/default.nix:14:3:
   |
14 |   installPhase = ''
   |   ^


[feature] Use autocomplete field for organization relation #333

Closes https://github.com/openwisp/openwisp-users/issues/333
Blockers

[ ] https://github.com/openwisp/openwisp-utils/pull/330

Coverage decreased (-0.2%) to 97.642% when pulling f1259052d930338bd64e4ba21210962f9a6d8348 on issues/333-org-autocomplete-field into 7664bec369b2a43faa14289b86b4602f7b896d89 on master.

@nemesisdesign the RadiusCheckAdmin has a bug unrelated to this PR. I was able to replicate that bug on the master branch of openwisp-radius https://github.com/openwisp/openwisp-radius/issues/464


There is a button in the game screen which shows a chat menu and can also close it again.

Couldn't be completed since we lost a group member in the beginning.
Please find further explanation in the group report.


Better support for custom Redpanda config

Is there another potential method for custom config aside from using a JSON dictionary?
https://docs.redpanda.com/current/deploy/deployment-option/self-hosted/manual/production/production-deployment-automation/#custom-configuration
I understand JSON/YAML are effectively the same thing, but it seems counterintuitive to use JSON when the rest of our deployment configs are yml along with the actual redpanda config files which are on the various servers. In my case I’ve embedded an escaped json in a central vars file I’m using for the install:
# json dict for custom configuration #
redpanda: "{\"cluster\":{\"kafka_enable_authorization\":\"true\",\"enable_sasl\":\"true\",\"superusers\":\"['admin,console,kfk-connect001']\",\"sasl_kerberos_keytab\":\"/var/lib/redpanda/kfk-rnd-rp.keytab\",\"sasl_mechanisms\":\"['SCRAM,GSSAPI']\",\"sasl_kerberos_principal\":\"redpanda\"}}"

JSON is used because the YAML merging is broken under Ansible. Gene looked at this a fair amount and determined this is a limitation in core Ansible. There's not much we can do about it short of ripping out the entire config management system and finding a different way to do it.
It's unlikely we're going to change this.
cc @gene-redpanda

Well... you say that but I'd actually like to rip it out entirely and replace it with rpk, go templates and a lot of flags. I'm not quite sure how yet but I have it as something in the back of my head for next year.
I'm also considering ripping out most of the advanced config and dumping it in yet another template and then using a light base template that handles node specific config and can merge with either our templates OR a user provided template.
Bottom line I actually kind of agree with this one 😅
That said you're absolutely right about the issue here. Python's yaml interpreter wasn't willing to support conditional statements in yaml maps which was a non starter as a lot of our optional elements needed to be exactly that!

Added support for per host overrides and various other fixes. Still need to use JSON but the issue is improved


Creating slide decks - ideas for more content

@GokceOGUZ @shrutikhare-git had some nice ideas for stuff that would be useful in the Creating Slide Decks tutorial

How to reference on slides (does this only appear at the end, so we can't credit individual figures, for example in a footnote?)
How to code in formulas (currently using screenshots instead!)

assuming you are referencing this PR? https://github.com/galaxyproject/training-material/pull/4620 agreed, the math needs to be documented. it should be the same as tutorials, but people don't necessarily look there for what syntax is allowed


Update Language for Server-Side Validation

The language is currently not able to be validated on the server due to a hidden dependency on the HTML. Anytime the jQuery operator is used $(...), the client references the HTML in a way that the server cannot effectively replicate. The language will need to change to be validatable on the server. I suggest changing jQuery selectors to refer to elements by the name attribute. This will give the client and server some common ground on what the core data is.
Instead of:
$("#myValueId") {
    valid: ...;
}

It should be:
myValueName {
    valid: ...;
}

Removing jQuery means that there will be no way to refer to multiple selectors, so I suggest making an array syntax within the actual Uniform code.
Instead of:
$(".myValuesClass") {
    // Rule applies to every element in array
    valid: this matches /"."/;
}

@myValuesValid: all $(".myValuesClass") is valid;

It should be:
@myValues: [ myValueName1, myValueName2 ];

@myValues {
    // Rule applies to every element in array
    valid: this matches /"."/;
}

@myValuesValid: all @myValues is valid; // Existing array syntax can still be used

This allows the server to know from the Uniform file what each array is and how validity is defined for it, rather than leaving that information hidden in an unseen HTML class.
Other changes may be necessary as well.

Is this a duplicate/ already completed?

Fixed by #31


Remove data plane config map from artifacts and create it if not found

If users apply the release artifact, they will create the data plane ConfigMap with no data in it. After creating objects (Brokers and Triggers) re-applying the release artifact will lead to a data loss because the ConfigMap will be re-created with no data in it. This PR fixes this behavior by using the control plane for creating such ConfigMap if it is not there.
Proposed Changes

Create data plane config map if it's not found

/lgtm

/retest

/retest


This lib crashes on iPhone 6 in production builds

As in the topic: on iPhone 6 the lib crashes apps in production. Same code works in debug versions, on devices and in simulators. I'm only tweaking a copy pasted code from your examples, didn't add anything fancy of mine. It's when using PNLineChart. Here's the cryptic line from Crashlytics:
Fatal Exception: NSInvalidArgumentException
-[__NSDictionaryI set]: unrecognized selector sent to instance 0x15de967e0

And some more info:
Thread : Fatal Exception: NSInvalidArgumentException
0  CoreFoundation<PHONE_NUMBER> __exceptionPreprocess
1  libobjc.A.dylib<PHONE_NUMBER> objc_exception_throw
2  CoreFoundation<PHONE_NUMBER> __methodDescriptionForSelector
3  CoreFoundation<PHONE_NUMBER> ___forwarding___
4  CoreFoundation<PHONE_NUMBER> _CF_forwarding_prep_0
5  UIFoundation<PHONE_NUMBER> __NSStringDrawingEngine
6  UIFoundation<PHONE_NUMBER> -[NSString(NSExtendedStringDrawing) drawWithRect:options:attributes:context:]
7  UIKit<PHONE_NUMBER> -[UILabel _drawTextInRect:baselineCalculationOnly:]
8  UIKit<PHONE_NUMBER> -[UILabel drawTextInRect:]
9  UIKit<PHONE_NUMBER> -[UIView(CALayerDelegate) drawLayer:inContext:]
10 QuartzCore<PHONE_NUMBER> -[CALayer drawInContext:]
11 QuartzCore<PHONE_NUMBER> CABackingStoreUpdate_
12 QuartzCore<PHONE_NUMBER> CA::Layer::display_()
13 QuartzCore<PHONE_NUMBER> CA::Layer::display_if_needed(CA::Transaction*)
14 QuartzCore<PHONE_NUMBER> CA::Layer::layout_and_display_if_needed(CA::Transaction*)
15 QuartzCore<PHONE_NUMBER> CA::Context::commit_transaction(CA::Transaction*)
16 QuartzCore<PHONE_NUMBER> CA::Transaction::commit()
17 UIKit<PHONE_NUMBER> _UIApplicationHandleEventQueue
18 CoreFoundation<PHONE_NUMBER> __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
19 CoreFoundation<PHONE_NUMBER> __CFRunLoopDoSources0
20 CoreFoundation<PHONE_NUMBER> __CFRunLoopRun
21 CoreFoundation<PHONE_NUMBER> CFRunLoopRunSpecific
22 GraphicsServices<PHONE_NUMBER> GSEventRunModal
23 UIKit<PHONE_NUMBER> UIApplicationMain
24 iSlowCarb<PHONE_NUMBER> main (main.m:13)
25 libdyld.dylib<PHONE_NUMBER> start

Hope this helps.

Hey,
I am facing the same issue. Please share solution if you solved it.

@pawelkata : I was getting same issue. And now i have solved this issue.
Still if you are facing this issue then just change one thing in PNChart class.
Go to PNGenericChart class ->
Into it there is a property:
@property (assign, nonatomic) UIColor *legendFontColor;
Just change it to:
@property (strong, nonatomic) UIColor *legendFontColor;
By changing this much my problem has been solved. Try it out once.
I hope your problem will also be solved.

I was getting same issue.  By changing debug to release mode to run,
crash in this line:
label.textColor = self.legendFontColor ? self.legendFontColor : [UIColor blackColor];.
Both legendFontColor and legendFont  should change assign to strong to fix it.
@kevinzhow


use class retention, make sure we use the right annotation attribute

Just the one question; otherwise ship it.

Uh... yeah.... I guess I was tired.  I spent a long time looking for the "right" annotation to use too.  Glad to know I'm in good company.


multi-arch: set ARCHITECTURE equal to BUILD_ARCH

Make bazel build for correct Architecture, when there is only one parameter in BUILD_ARCH
As we set BUILD_ARCH=crossbuild-aarch64 in the build process, and the parameter does not pass to bazel build which lead to cross build not works at the moment.
https://github.com/kubevirt/project-infra/blob/39e4c9854a682d00f762868f58ec0b9a4bf6e013/github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml#L322-L323
Special notes for your reviewer:
This is a fix to https://github.com/kubevirt/kubevirt/issues/3558#issuecomment-1533261386
NONE

cc: @rmohr @rthallisey

/lgtm

The change looks fine, but isn't BUILD_ARCH being used inconsistently?
The prow job sets
BUILD_ARCH="crossbuild-aarch64"
DOCKER_TAG="<timestamp>-arm64"

but my reading of the script is that it expects, for multi-arch builds, something like
BUILD_ARCH="amd64,arm64"
DOCKER_TAG="<timestamp>"

instead.
So I think we might need something like
diff --git a/hack/multi-arch.sh b/hack/multi-arch.sh
index 7ede30961..e5bd47d20 100755
--- a/hack/multi-arch.sh
+++ b/hack/multi-arch.sh
@@ -19,13 +19,24 @@

 COMMAND=$1

+arch2tag() {
+    case "$1" in
+    *aarch64)
+        echo "arm64"
+        ;;
+    *x86_64)
+        echo "amd64"
+        ;;
+    esac
+}
+
 build_count=$(echo ${BUILD_ARCH//,/ } | wc -w)

 # Only add the tailing $arch when doing a multi-arch build
 if [ "$build_count" -gt 1 ]; then
     for arch in ${BUILD_ARCH//,/ }; do
         echo "[INFO] -- working on $arch --"
-        DOCKER_TAG=$DOCKER_TAG-$arch ARCHITECTURE=$arch hack/bazel-${COMMAND}.sh
+        DOCKER_TAG=$DOCKER_TAG-$(arch2tag ${arch}) ARCHITECTURE=$arch hack/bazel-${COMMAND}.sh
     done
 else
     ARCHITECTURE=${BUILD_ARCH} hack/bazel-${COMMAND}.sh

(completely untested) to make it possible to actually perform multi-arch builds by setting
BUILD_ARCH="x86_64,crossbuild-aarch64"
DOCKER_TAG="<timestamp>"

Am I missing something?

/retest

Hi, @andreabolognani
When we do crossbuild, we need to set the BUILD_ARCH="crossbuild-aarch64". So if we build multi-arch image on a x86_64, we need to set BUILD_ARCH="x86_64,crossbuild-aarch64"
I have verified it, as you can see in the following comment: https://github.com/kubevirt/kubevirt/pull/8989#issuecomment-1371884282

So if we want to do both native build and cross build when setting BUILD_ARCH="amd64,arm64", we may need another function to detect if the current CPU arch march with BUILD_ARCH, if not we set the ARCHITECTURE to crossbuild-${BUILD_ARCH}
However, the current work flow should be works fine without the previous amend. And we do not publish multi-arch image for now as Arm64 release is still experimental.

/retest

Hi @andreabolognani
I have updated the PR. Now, it is supposed to work when we set BUILD_ARCH="amd64,arm64". I am not sure if I miss understand your idea.
BTW, as you can see in hack/push-container-manifest.sh, when creating a multi-arch manifest, digests are used instead of tags. As a result, the specific tag assigned to the multi-arch images is not significant.

/retest

BTW, as you can see in hack/push-container-manifest.sh, when creating a multi-arch manifest, digests are used instead of tags. As a result, the specific tag assigned to the multi-arch images is not significant.

Good point, I hadn't realized that was the case.

However, the current work flow should be works fine without the previous amend. And we do not publish multi-arch image for now as Arm64 release is still experimental.

Fair enough.

I have updated the PR. Now, it is supposed to work when we set BUILD_ARCH="amd64,arm64". I am not sure if I miss understand your idea.

Sort of! I actually didn't mind the fact that you had to specify "crossbuild-aarch64" as opposed to "aarch64", but your new version dealing with that automatically is an improvement over the status quo of course.
I was mostly calling out the inconsistency in tag names, which for a multi-arch build will be
${DOCKER_TAG}-x86_64
${DOCKER_TAG}-crossbuild-aarch64

while the current aarch64 CI job publishes the result as
${DOCKER_TAG}-arm64

and generally I would expect this latter convention to be used for container images, as docker/podman use Go-style architecture names everywhere.

generally I would expect this latter convention to be used for container images, as docker/podman use Go-style architecture names everywhere.

I have updated the PR, and use GO-style architecture names in image tags

/lgtm

/retest

/retest

/test pull-kubevirt-e2e-arm64

/retest

@rthallisey Any future comments on the PR?

/retest

/retest

/approve

Thanks Roman


Enum properties are not supported in CommandExtensions.GenerateParameter

If entity class has property of some Enum type (e.g. MyNamesapce.MyEnumType) ORM raises the error:
System.Collections.Generic.KeyNotFoundException: The given key 'System.Nullable1[MyNamesapce.MyEnumType]' was not present in the dictionary.
at System.Collections.Generic.Dictionary2.get_Item(TKey key)    at SecurityDriven.TinyORM.Extensions.CommandExtensions.GenerateParameter(String parameterName, Object parameterValue, Type parameterType)    at SecurityDriven.TinyORM.Extensions.CommandExtensions.ProcessParameter(SqlCommand& command, SqlParameterCollection& sqlParameterCollection, String& name, Object& value, Type& type)    at SecurityDriven.TinyORM.DbContext.CommitQueryBatchAsync(QueryBatch queryBatch, Int32 batchSize, CancellationToken cancellationToken, String callerMemberName, String callerFilePath, Int32 callerLineNumber)

Should there be some options for DbContext to set something like below?
var db = DbContext.Create(_connectionString); db.MapEnumsAsInt = true; // should support nullable properties of course

@dmitry-pavlov Can you please share the actual TinyORM code that raises the error? I'd like to understand whether you get it when you try to pass POCO with Enum-typed property in (ie. on the way into db), or you get a db-result and are trying to convert it into a POCO (ie. on the way out from db)..
Ex. given the following c# definitions, what would be a repro code for you?
public enum Stage
{
	StageOne = 1,
	StageTwo = 2
}
public class Entity
{
	public string Name {get; set;}
	public Stage Progress { get; set;}
}

I am trying to do bulk insert via TinyORM for performance (compared to EF Core).
Note: DbContext is TinyORM thing, XyzDbContext is my EF Core DB context (used here only for helper methods - I just store there some constants needed)
Here some code to show how I use it:
        private static void InsertViaTinyOrm<TEntity>(Settings settings, ICollection<TEntity> entities)
            where TEntity : class
        {
            var chunks = ChunkBy(entities, settings.Database.BulkInsertChunkSize);

            var sql = GetBulkInsertQueryForEntityType(typeof(TEntity));

            var tasks = new List<Task>();

            foreach (var chunk in chunks)
            {
                var db = DbContext.Create(settings.Database.ConnectionString);

                var batch = QueryBatch.Create();

                foreach (var entity in chunk)
                {
                    batch.AddQuery(sql, entity);
                }

                tasks.Add(db.CommitQueryBatchAsync(batch));
            }

            Task.WaitAll(tasks.ToArray());
        }

Some helper methods to build SQL insert command based on my entity type:
        private static List<List<T>> ChunkBy<T>(IEnumerable<T> source, int chunkSize)
        {
            return source?
                .Select((x, i) => new {Index = i, Value = x})
                .GroupBy(x => x.Index / chunkSize)
                .Select(x => x.Select(v => v.Value).ToList())
                .ToList();
        }

        private static string GetBulkInsertQueryForEntityType(Type type)
        {
            if (!XyzDbContext.TypeToTableMap.ContainsKey(type))
            {
                throw new NotSupportedException($"Define bulk insert query for {type.Name} entity.");
            }

            var tableName = XyzDbContext.TypeToTableMap[type];

            var propertyNames = type.GetProperties()
                .Select(property => property.Name)
                .Where(name => name != "Id")
                .ToArray();

            var columnNames = string.Join(",", propertyNames);

            var parameterNames = string.Join(",", propertyNames.Select(propertyName => $"@{propertyName}"));

            return $"insert into {XyzDbContext.Schema}.{tableName}({columnNames}) values({parameterNames});";
        }

TypeToTableMap is just a map for my EF  Core entity type to table name
        public static Dictionary<Type, string> TypeToTableMap = new Dictionary<Type, string>
        {
            {typeof(Product), nameof(Products)},
            ...
        };

Hope that helps

I think I have a repro for your error:
async Task Main()
{
	var db = DbContext.Create(connString);

	var sql = @$"SELECT [Name] = @name, [Stage] = @stage";
	var parameters = new  { @name = "Stan", @stage = default(Stage)};

	var result = await db.QueryAsync(sql,parameters).ConfigureAwait(false);
	result.Dump();
}

public enum Stage
{
	StageOne = 1,
	StageTwo = 2
}

The above works fine, but if you change it to default(Stage?), it throws what I think you're getting.

Can you please try the following new TinyORM build:
TinyORM.1.3.3.zip

Yeap, v1.3.3 works fine with enums. When are you going to publish it to NuGet?
P.S. I have also added one additional not critical improvement request here #9

Please feel free to close the issue once you publish v1.3.3 to NuGet. Thanks!


[Bug] Users unable to drag a column outside of viewport of a property pane to rearrange column order

Issue reported by a user. They have a table with many columns(over 25+ at least). There's a bug that makes it difficult to reorder columns.

If you drag the column header in the table, it's a bit awkward to get it scrolling but it does work. This needs some improvement. See video:

Reordering inside the property pane is not possible. Ideal solution is to detect that the user is trying to scroll upwards and automatically scroll the property page downwards. See gifs and screenshots by the user below.

How it works inside Google Appsheet:

Another possible approach from a user input on Discord:

Regarding the draggin/reordering/scrolling a long list of columns, in other apps I've found that I can click and drag and then use the scrollwheel on mouse, or click-drag and hit PGUP PGDOWN keys. (I haven't tested this yet with Appsmith)

@somangshu @vicky-primathon Could we get to this issue? I ran into this today and was quite difficult to deal with.

@areyabhishek apologies for completely missing this. We will prfioritize this.
The UX below sound like the right solution.

Regarding the draggin/reordering/scrolling a long list of columns, in other apps I've found that I can click and drag and then use the scrollwheel on mouse, or click-drag and hit PGUP PGDOWN keys. (I haven't tested this yet with Appsmith)

Note:
| Requirement | Priority | Comments |
| The user can select a column tile by clicking on the drag icon, the user can then use PGUP and PGDOWN to move/reorder the time | High | - |
| The user can click and drag a tile, The scroll should be automatic when the tile touches the top/bottom of the section, The scroll should stop when the tile is not touching the top/bottom of the section. | High | - |
Please suggest any changes required.
@riodeuno why is this issue in the icebox, Any reasoning behind this?

@somangshu  Should we assign this to Li? Or this too much for him right now?

Li can work on this, But might take some time to get a hold of it. Its better to get somebody who is aware of the table widget and the tile drag control.

We are only fixing the the issue here. The enhancement i.e.
The user can select a column tile by clicking on the drag icon, the user can then use PGUP and PGDOWN to move/reorder the time
will be worked upon as an enhancement in table/tabs widget.

Is the implementation based on the above PRD complete @vicky-primathon, I am confused with the above comment

@somangshu  2nd part of the requirement mentioned is completed
The user can click and drag a tile, The scroll should be automatic when the tile touches the top/bottom of the section, The scroll should stop when the tile is not touching the top/bottom of the section.
But since 1st requirement mentioned was an enhancement we skipped it as of now after discussing with Nikhil.  As discussed with Nikhil this requirement can be taken up as an enhancement and not immediately required to fix the issue.

@vicky-primathon this dosent seem to function on release / prod, re opening this issue, Please link it to #10046 is we are fixing it there


Order of glob depends on environment

The way that pip-licenses finds license objects in a repo, is by globbing LICENSE*, LICENCE* and COPYING*. However, the output of glob.glob in Python seems to be dependant on the environment.
https://github.com/raimon49/pip-licenses/blob/9c8325920eb3c3e77e0c7e9304c48b7ea9f91c56/piplicenses.py#L131-L151
This becomes an issue in repositories like cryptography, where you have 3 different license files: LICENSE.APACHE, LICENSE.BSD and LICENSE.PSF. Therefore, depending on the environment, pip-licenses will choose one or another.
Suggested solution
One way to fix this would be to sort the output of glob.glob(), so that it's consistent regardless of the environment.

@adamchainz Thanks for the report and suggestions.
I will be using the glob.glob() results sorted in the next release to provide consistent output.

This issue is addressed in version 2.2.1.
https://pypi.org/project/pip-licenses/2.2.1/
If your problem is resolved, please close this issue.

@raimon49 thanks for the fix! That was really quick!!
I can confirm that the issue is now resolved in 2.2.1.


docs: add multiple new metrics (EN + ZH)

Description
Fixed typo in Bus Factor, updated dependencies to latest & added new metrics (both EN & ZH), for the following, mentioned below (includes updates from 20/04/2024) :

Activity Details
Activity Dates and Times
Inactive Contributors
Issue Resolution Duration
Issue Response Time

🦄 Tested on local, build running successfully!

Ref : Slack Discussion  /  cc: @Peng99999, @frank-zsy
○ Partially resolves #24

Before submitting the PR, please take the following into consideration

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
[x] Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
[x] The description should clearly illustrate what problems it solves.
[x] Ensure that the commit messages follow our guidelines.
[x] Resolve merge conflicts (if any).
[x] Make sure that the current branch is upto date with the main branch.

Thanks for the docs. I will update the Chinese version.
I think you should start with CHAOSS statistical metrics since they are quite easy and have CHAOSS documentations as reference.
Metrics from X-lab are almost complex metrics involves calculation or even graph data structure, so we can add them at last.

Actually time period related metrics like resolution duration and response time are also tricky. So these metrics will involve deep collaboration with me.

Thanks for the docs. I will update the Chinese version.

Sounds good, thank you! 😄

I think you should start with CHAOSS statistical metrics since they are quite easy and have CHAOSS documentations as reference.

I see, thanks for the heads up! Alright, I'll prioritize CHAOSS metrics first, and once those are completed, I'll start digging into the X-lab metrics with your guidance.

Metrics from X-lab are almost complex metrics involves calculation or even graph data structure, so we can add them at last.

Got it!

/preview

@Neilblaze I add LaTeX support and modify the docs, could you modify the English version due to my modification? Especially activity metrics. And activity and activity details are both included in the activity part now.
And I think we can remove the English name of each metrics in the Chinese doc titles and we do not need to translate Issue and PR.

Yessir, I'll do that :)

/preview

/preview

This PR LGTM now. Thanks for the great work!
I will merge this PR now and further more:

I think change request response time and resolution duration could be merged with issue corresponding metrics.
Pls feel free to raise PR and discuss on GitHub, since Slack is not quite stable in China, I can only receive the notification but can not retrieve the messages smoothly. Sorry for that.

@frank-zsy Thanks for merging the PR! 😃

I think change request response time and resolution duration could be merged with issue corresponding metrics.

Sure thing! In the next PR, I'll make sure to do this.

Pls feel free to raise PR and discuss on GitHub, since Slack is not quite stable in China, I can only receive the notification but can not retrieve the messages smoothly. Sorry for that.

Thanks for the heads up! I understand that Slack isn't that accessible in China, so I do recommend enabling GitHub Discussions in this repo, which will be very helpful for everyone.
Thanks :)

@frank-zsy Also, for this:

Change requests (Open PR)
Change requests reviews
Change request response time
Change request resolution duration
Change request age

Should I create separate metrics page (individual pages / each) for each OR create one separate metrics section and under that keep these nested, which will look something like this:

Change Requests

Open PR
Reviews
Response Time
Resolution Duration
Age

Thanks for the heads up! I understand that Slack isn't that accessible in China, so I do recommend enabling GitHub Discussions in this repo, which will be very helpful for everyone.

Of course we can enable discussion for this repo, however I don't really fond of this function because discussion events can not be collected by GitHub events API.

Should I create separate metrics page (individual pages / each) for each OR create one separate metrics section and under that keep these nested, which will look something like this:

I think group change request and issue metrics to a category is cool and helps to organize the catalog and make it much clearer.

@frank-zsy UPDATE:
For this, I tried to keep the "Issues" section standalone and then keep two inter-sections "new" and "closed", but I feel that is making the entire table ugly 😅

So, I'm keeping it as it is, plus I feel it makes things easier for people to perform individual search on different topics. Rest aside, if anyone wants something specific, they can use the search-bar. ^_^
Thoughts?

So for now, I'll start shipping out PRs for the rest of the metrics, keeping the priority on CHAOSS first, then once those are done, I can move into x-lab ones, where I'll hopefully require some help :)


Added Miso Soup assets

credit to hrihof/apotato and implemented in talksprites

I didn't mean to dismiss the review, but then i noticed the conflict resolving had some issues so its good i went back to fix it


Mock server clean up

As a small step to start contributing to this repo i tried make the mock server somewhat cleaner.
I used the editorconfig defined in the GP2040-CErepo, not sure if that is correct.

Added logger middleware for easier debug
Removed button config osfrd, could not find any reference to it.
Keyboard mapping now in their own file, maybe it should have been in Buttons.json instead? Can normalize it so that the react part also uses it in the future.
Fix some warning when navigating

Thanks for adding these, we'll probably be doing a code clean-up on the next release/revision. For right now we'll be holding off on changing global function/params/includes until we're stable on the release.

@arntsonl Nice! Should be good to go, I noticed the duplicate key of SliderSOCDInputEnabled in getAddonsOptions
Removed it in the merge!

Nice, thank you for cleaning all that code!!


Escape release_notes

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:abbb9f9207de448a100a56ba3d59ea04c0811825

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:5b03f21ddce35509b65174dd3e9fd3b28d106ea5

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=dev:5b03f21ddce35509b65174dd3e9fd3b28d106ea5

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/nnsnodnb/firebase-app-distribution?version=0.0.5


Renewal docs of [Accordion]

Description
I try to renew documentation of [Accordion].
it was arranged with 2 main categories and 5 sub categories.
check point

added an example for dark theme.

implemented an interactive example for Animation settings.

it was separated to emphasize useful customizations(styles, render function and toggleElement).

styles

render function

toggleElement

Test Plan
None
Related Issues
#179
Tests
I added the following tests:
None
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] Run yarn test:all and make sure nothing fails. You can run yarn test -u to update snapshots if needed.
[x] I am willing to follow-up on review comments in a timely manner.

@luke-hanwook Hello there. Could you contact me via slack? If you are not sure which slack, try react-native-seoul.

@hyochan
I have an error on component in docs directories after reinstall yarn packages. (due to CI error)
'View' cannot be used as a JSX component.
  Its instance type 'View' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'import("/Users/luke/example/dooboo-test/node_modules/@types/react/index").ReactNode' is not assignable to type 'React.ReactNode'.
        Type '{}' is not assignable to type 'ReactNode'.ts(2786)

I think it's a problem of type version..
Could you advice me how to resolve this issue?

@hyochan I have an error on component in docs directories after reinstall yarn packages. (due to CI error)
'View' cannot be used as a JSX component.
  Its instance type 'View' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'import("/Users/luke/example/dooboo-test/node_modules/@types/react/index").ReactNode' is not assignable to type 'React.ReactNode'.
        Type '{}' is not assignable to type 'ReactNode'.ts(2786)

I think it's a problem of type version.. Could you advice me how to resolve this issue?

I added resolutions in docs/package.json and resolved this issue. but i don't know it's right. (I am searching and studying resolutions)
"resolutions": {
    "@types/react": "17.0.40",
    "@types/react-native": "^0.67.7"
  },

if you want i will push this code for share.

@hyochan I have an error on component in docs directories after reinstall yarn packages. (due to CI error)
'View' cannot be used as a JSX component.
  Its instance type 'View' is not a valid JSX element.
    The types returned by 'render()' are incompatible between these types.
      Type 'import("/Users/luke/example/dooboo-test/node_modules/@types/react/index").ReactNode' is not assignable to type 'React.ReactNode'.
        Type '{}' is not assignable to type 'ReactNode'.ts(2786)

I think it's a problem of type version.. Could you advice me how to resolve this issue?

I added resolutions in docs/package.json and resolved this issue. but i don't know it's right. (I am searching and studying resolutions)
"resolutions": {
    "@types/react": "17.0.40"
},

if you want i will push this code for share.

You've done it right.

Thank you as always.


cmake optimizations, and remove -mcx16 and -march=native by default

This should fix #125, #126, and #127.

In addition, this reduces the size of the executable binary by an order of magnitude.

-mcx16 and -march=native present in src/common/wflign/deps/wflambdav2/CMakeLists.txt also need to be removed.
This would solve my immediate issue of compiling wfmash for RISC-V. But, it sacrifices platform-specific optimizations, and may frustrate wfmash users. wfmash should probably detect and use CPU-specific features at runtime, rather than at compile-time.

@arunisaac, I have also removed these options, but we still chat about how to properly handle platform-specific optimisations. The current slowdown is already frustrating


Provide a fix for RubyTime conversion

Fix #77 by adding some decoration/conversion when need.

@talevy happy if you can give me your thoughts on this.

nice!

Code LGTM; haven't tested. Nice refactoring along with the fix! :)

@purbon curious if there is a performance hit of this? going through every field and checking if its a time value?
Also, on a related note, sequel exposes this option :convert_types:

If set to false, does not attempt to convert some Java types to ruby types. Setting to false roughly doubles performance when selecting large numbers of rows. Note that you can't provide this option inside the connection string (as that is passed directly to JDBC), you have to pass it as a separate option.

See http://sequel.jeremyevans.net/rdoc/files/doc/opening_databases_rdoc.html#label-jdbc+
Should we explore this?

@suyograo no doubt we should explore performance on this.
re: not changing previous looping behaviour to check for time, just adding a conversion when need ( I expect not a lot of impact as it was done before just to convert keys to strings).

+1, I'll open a new issue for using :convert_types

curious if there is a performance hit of this?

We could also take a similar approach to Elasticsearch's dynamic mapping - cache previously-unknown column/field names by type. Should be faster than checking each column/field every event, but i'm open to having it be explicit (even if just for a little while) to start with.

+1 on merging this for a first iteration. We can always make it faster :)

@jordansissel PR has build check, no need to test!
LGTM


Hooks are called with wrong arguments

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.0.4
Electron version
23.1.3
Operating system
Windows 10
Last known working Electron Forge version
No response
Expected behavior
packageAfterCopy, packageAfterPrune, packageAfterExtract hooks shall be called with the following arguments: (buildPath: string, electronVersion: string, platform: string, arch: string).
Actual behavior
The buildPath argument seems to have the contents of forge.config.js and electronVersion argument is the buildPath.
Steps to reproduce
In forge.config.js, add below hooks
module.exports = {
hooks: {
packageAfterExtract: async (buildPath, electronVersion, platform, arch) => {
console.log('Here are the arguments: ', buildPath, electronVersion, platform, arch)
},
packageAfterPrune: async (buildPath, electronVersion, platform, arch) => {
console.log('Here are the arguments: ', buildPath, electronVersion, platform, arch)
},
packageAfterExtract : async (buildPath, electronVersion, platform, arch) => {
console.log('Here are the arguments: ', buildPath, electronVersion, platform, arch)
},
}
Additional information
No response

Because the first argument is config,you can check again.
packageafterextract
packageafterprune
packageafterextract

Ah yeah, the docs were not clear about that before but I updated this in https://github.com/electron-forge/electron-forge-docs/commit/b5de9a367229573d7604718323ca366e6ec615e0


Make storage\cache mount points configurable

It would be very helpful to for Job build storage\cache to have a configurable path, rather than the hard-coded private settings as current.

cp -a from storage\cache to build dir will usually be slow (depends on your PVC config)
ln -s won't work for a docker build (docker context doesn't follow symlinks)
ln -s (in my specific case) is 'detected' by php compose install and therefore all vendoring library paths are hard-coded to the storage\cache directory

I am imagining that we could do this on the Job objects pretty easily.

💯 Awesome work!!
Thanks!!


Fix patsy naming issue

Columns named with awkward names including restricted characters such as "-" (dashes) will get evaluated to minus signs through patsy which requires their wrapping using the Q builtin.
http://patsy.readthedocs.io/en/latest/builtins-reference.html#patsy.builtins.Q
Minimum broken example:
import pandas as pd
import category_encoders as ce
X = pd.DataFrame([1, 2, 3, 4], columns=['test-broken'])
X_trans = ce.HelmertEncoder(cols=['test-broken']).fit_transform(X)

Raises the error:

patsy.PatsyError: Error evaluating factor: NameError: name 'col_test' is not defined
C(col_test-broken, Helmert)

Oh great catch, we should add some test cases for this as well. Thanks for the PR


Migrate to Go 1.12, Go modules, update pipelines

Also removes Godep since modules replaces it. The pipelines now tear
down the director during teardown-infrastructure. Upgrades various
dependencies to accommodate the Go 1.12 upgrade.

@tysen you’re OK to sign the CLA
On Thu, Mar 21, 2019 at 5:29 PM cfdreddbot<EMAIL_ADDRESS>wrote:

❌ Hey tysen!
All pull request submitters and commit authors must have a Contributor
License Agreement (CLA). Click here https://www.cloudfoundry.org/cla
for details on the CLA process.
The following github user @tysen https://github.com/tysen is not
covered by a CLA.
After the CLA process is complete, this pull request will need to be
closed & reopened. DreddBot will then validate the CLA(s).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/bosh-google-cpi-release/pull/311#issuecomment-475452374,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoGLTAYgpNhUogvLUpBXRJzdGBXXZi8ks5vZCP_gaJpZM4cCnxb
.


Setting onAny with severity("ignore") supersedes any finer-grain configurations set in the same block

Build scan link
https://scans.gradle.com/s/ltknlvd7vutuu
Plugin version
1.0.0-RC05
Gradle version
7.3.3, 7.4.2
(Optional) Android Gradle Plugin (AGP) version
7.1.2, 7.2.0-beta04
Describe the bug
Setting onAny with severity("ignore") supersedes any finer-grain configurations set in the same block.
dependencyAnalysis {
    issues {
        all {
            // setting this supersedes any finer-grain configurations that set a higher severity
            onAny {
                severity("ignore")
            }

            // these don't do anything
            onUnusedDependencies {
                severity("fail")
            }
            onUnusedAnnotationProcessors {
                severity("fail")
            }
            onRedundantPlugins {
                severity("fail")
            }
        }
    }
}

To Reproduce
Steps to reproduce the behavior:
Run buildHealth on sample project
Expected behavior
build should fail for unused kapt and unused dependencies.
Additional context
Build succeeds and build-health-report.txt is empty.

Thanks for the issue. When you say "on sample project", can you clarify what that means?

I could have swore I included a link to a sample project but I seemed to have lost my mind. Added it to original issue to make your question look crazy but here it is as well https://github.com/kyhule/dep-analysis-onany-union-issue 🙃

I have decided this is indeed annoying and it should be possible to specify looser rules in a subproject.

Ah, looks like this duplicates https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/409.

@kyhule at the moment, I'm thinking I don't want to resolve this. I think that, if you want to have specific handling for issue types, you should not use onAny. Also, upon further inspection, this isn't actually a duplicate of https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/issues/409, which is about the ability to change behavior in subprojects vs the root severity setting.


the code for slam location

Hello, thank you very much for sharing this excellent work; but in the public code, I did not see the code for processing the slam positioning part. I see that you performed the underwater positioning of the ARACATI data set in the paper. This part of the code Where is the reference?

Thank you for your interest in my work. I'm sorry that our slam code is not public. But you can use the reference as this link (https://github.com/gisbi-kim/PyICP-SLAM). His work shows the minisam that leverages the slam positioning part.

OK, thank you very much


"error: shared_ptr is not a member of std" when build with g++ on ubuntu 16.04

I find out that shared_ptr is defined in  under my environment:

os:ubuntu16.04.4 4.13.0-31-generic
compiler: gcc 5.4.0, default configuration

So I add

#include <memory>

in the file include/URT.hpp. The problem is solved.

I have same error too. thanks your solve solution


Error tracing feature

Listing exceptions (including enable to monitor their exception class)

Exception Collector & monitor page

TODO: 상세한 예외 및 알림


[Guide] Snapshot API

What is the bug?
Create guides/snapshot.md similar to the Ruby guide
What is the expected outcome?
The guide 'snapshot.md' need to have example codes for different snapshot operations.
All code-blocks, when run from start to finish in order they appear in the guide, do not throw any errors. If you want to demonstrate that certain statements will throw errors, they must be wrapped in a try/catch and print out the expected error. All code-blocks are properly marked with the language it's written in (i.e. ```python)
For additional references on how to format guide, please refer existing guides in opensearch-py repo.

Please feel free to take up this issue and raise a PR with your proposed solution.

Can I please take up this issue?


Ensure Zarf image manifests are pulled as blobs

Description
When pulling from GHCR we noticed that Zarf image manifests were coming from the /manifests/ path when they should actually be coming from /blobs/. Even though they are technically image manifests, Zarf stores in them OCI as blobs, so this PR changes the MediaType on the image manifest to be a Zarf blob

Confirmed that I can now deploy bundles containing packages from GHCR


Created sample test suite to learn about LISA

Wrote a sample test suite to learn about LISA test cases and how to write and run them.

Nice work! Closing this task


Signing and notarization might hang if a runner cache exists

Summary
Not really sure why this happens, but from explorations in #88 it seems like the gon step of goreleaser for notarizations will hang indefinitely if a previous cache exists for a failed run? There might be more nuance.
Workaround
Clear caches and retry a run - https://github.com/zimeg/emporia-time/actions/caches

Closing for now since it seems like the workaround as alright. If it continues to happen we will revisit 🙏

This might be useful in the release workflow https://stackoverflow.com/a/64819132/7147271
$ gh cache list
$ gh cache delete

v1.0.2 and #110 seemed to work alright - even with multiple retries happening in the PR. Closing once more 🚀


'modulecmd python show' fails

For some strange reason, while this runs fine 🟢

reframe ... -p PrgEnv-cray --system dom:login -M cce:cce/11.0.4

the same with atp fails: 🔥

reframe ... -p PrgEnv-cray --system dom:login -M atp:atp/3.7.4

where the available modulefiles are:
-- /opt/cray/pe/modulefiles ---------------------------------------------------------
cce/10.0.2          cce/11.0.0(default) cce/11.0.2          cce/11.0.4
atp/3.7.4          atp/3.8.1(default) atp/3.11.7

and the code is:
import os, sys
import reframe as rfm
import reframe.utility.sanity as sn

@rfm.simple_test
class ExampleRunOnlyTest(rfm.RunOnlyRegressionTest):
    def __init__(self):
        self.descr = ('RunOnlyRegressionTest')
        self.valid_systems = ['dom:login']
        self.valid_prog_environs = ['PrgEnv-cray']
        # self.modules = ['cce']
        self.modules = ['atp']
        self.sourcesdir = None
        self.executable = 'echo 9'
        self.sanity_patterns = sn.assert_found('9', self.stdout)

  * Reason: environ error: could not execute module operation: command 'modulecmd python show atp' failed with exit code 0:
--- stdout ---
--- stdout ---
--- stderr ---

I suspect https://github.com/eth-cscs/reframe/blob/master/reframe/core/modules.py#L671 but not sure why...

@jg I have found the problem. It is a bug and it's triggered because the module has some environment variables containing ERROR. I will fix it.


Inline syntax highlighting is broken in the latest version(s)

It looks like recent changes to reduce the final package size have omitted whatever code/files were necessary for the inline Markdown syntax highlighting. I recently updated the version of Ink that I use and pointed at<EMAIL_ADDRESS>and just noticed that the inline Markdown styles no longer work. I had to go back a few versions to find one that jsdelivr would serve (other recent versions run into the issue where they exceed 100MB); it looks like<EMAIL_ADDRESS>is the most recent working version that is also small enough for jsdelivr to serve up.

Can you share a minimal reproduction for this?

@voracious Sure; I'm including Ink in a Rails application using their importmap map feature, but I don't think I'm doing anything super out of the ordinary.
Thankfully, I was able to reproduce this in a bare Rails application with minimal configuration of Ink. Here's a repository: https://github.com/davidcelis/ink-demo
Please let me know if the README isn't enough to get set up; not sure what your experience or comfort level is like with Ruby and Rails, but I'll be happy to help as much as needed!

@davidcelis I started looking into this, and it looks like multiple things are broken. It looks like some things are also broken in 0.18.1, and I'm thinking this has something to do with either import maps or jsdelivr. If you get a chance, could you try to create a reproduction using the jsdelivr CDN on something like CodeSandbox or CodePen? Otherwise, I'll try to do that when I can get back to this.

Oh Codepen was a much better idea 😅 Here's one that reproduces the issue using jsdelivr absent of Rails: https://codepen.io/davidcelis/pen/YzOqdoQ
I have three import statements in there; the first one is what I've been using, which is jsdeliver's suggested ESM import link. The commented out import statements just target /dist/index.js since that's the file that ink's package.json declares as the main file. Both the jsdelivr and unpkg imports fail with this error:
Uncaught TypeError: Failed to resolve module specifier "solid-js/web". Relative references must start with either "/", "./", or "../".

This is definitely an odd issue. Things seem to work fine when Ink is installed via a bundler (e.g. Vite), so I'm still thinking this has something to do with how jsdelivr is serving it.
https://stackblitz.com/edit/vitejs-vite-qzye6e?file=src%2Fmain.ts,src%2Fstyle.css,index.html&terminal=dev

Does that mean the only current way to install/include Ink is by including it in a bundle/package? I've been successful so far in avoiding having to add a javascript transpiler or webpacker or node runtime to my Rails app; I know Ink is fairly big but I'm hoping to keep a lighter weight way to include it 😅

I would love for it to work correctly over a CDN, so I'm still looking into it. As far as I can tell, this is an upstream issue with CodeMirror and it might have to do with the automatic dependency resolution. Here is an example that shows CodeMirror itself is not tokenizing the Markdown when loaded over the CDN but is working correctly when loaded via a bundler.
https://stackblitz.com/edit/vitejs-vite-ne8f1e?file=src%2Fmain.ts&terminal=dev
I've opened a discussion about it though, so we'll see where it goes.
https://discuss.codemirror.net/t/the-markdown-parser-does-not-seem-to-work-when-codemirror-is-loaded-via-a-cdn/5824

The maintainer's response didn't give me high hopes, but I actually have a bit of good news; I did a lot more digging and found one of the maintainer's Twitter posts from last year where he's lamenting basically this problem: https://twitter.com/MarijnJH/status/1542098023282515968
In that thread someone mentioned a CDN I hadn't used or heard of before; I swapped out my import to use https://esm.sh/ instead:
import { ink, defineOptions} from 'https://esm.sh/ink-mde@0.20.1?bundle'

// …

and it just works! It took several seconds to build the bundled file, but my understanding is that it's cached even on their end, so this ended up very quickly getting me a single file for Ink.
I think that I definitely had just run into a limitation in the average javascript CDN, so I'm not sure how worthwhile it will be for you to keep this issue open. It's clear there's no problem with Ink itself, and since it seems to work correctly with esm.sh, I think recommending them as a CDN for users who want to use a CDN would make sense to me

Oh, that is fantastic to hear! I will leave this issue open for a little bit longer. I'd like to add CDN instructions to the readme with that link.


Removed extra 'the'

Corrected typo

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@saiyedzaidi : Thanks for your contribution to the Azure documentation! The author, @PanosPeriorellis, has been notified to review your proposed change.

@saiyedzaidi Thank you for the catch. Apologies the author missed your proposed correction sooner! Looks like there is a merge conflict now. I am going to close your pr. Would you please submit again? You don't have to of course, but if you do, I can accept your change and you will get the credit for your effort!

#please-close


Add simplecov

not tested but copied from manageiq

update:

moved gemfile dependencies
fixed simplecov require
added minimum version for simplecov
added secret

update

fixed gemspec type


Support private repositories for Rancher Catalog

Currently Rancher Catalog only supports public GitHub repositories for the catalog. For organizations attempting to limit the access to Rancher having the ability to support private GitHub repositories would be beneficial to have.

It does not need to be GitHub or hosted on the internet or public or anything in particular.  The catalog service basically just runs git clone ${url you provided}.
If authentication is required to clone that URL, that needs to be provided.  For basic auth you can do https://user:pass@host/path.  For SSH (e.g. git@github.com:org/repo) the private key needs to be put into the rancher/server container.  But it appears we don't package SSH so that's a problem..

Providing the OAuth token for the repository ended up working for us. It might be nice if the catalog did something similar to Drone with the .netrc file so it would just work.

oh and I would need that, too ... maybe in 0.52?
especially with that meetup getting closer ...  :grin:

After thinking about it the issue is more about usability. It would be nice if you had GitHub OAuth setup if the UI could search for repositories on GitHub for the catalog repository. In general terms it would be nice if the UI gave you an error message saying that it could not pull the catalog instead of having to go to the logs to figure out it couldn't grab the catalog. It would suggest that either it doesn't exist so you should check the repository url or if it couldn't authenticate suggest a URL which contains the username password or OAuth token.

AFAIR setting up github oauth requires a callback from github to rancher - which is currently running in our AWS VPC and can't be reached from the outside world. That would be a problem, cause I had to enable access to rancher from "the internet", which I kinda don't want to do. (but please correct me if I'm wrong)

This would be very nice to have, we wouldnt create a private catalog if it ends up on a public space. Being able to use a private repo would be nice.

Hi, @vincent99 i try ti add a private catalog with a http://user:pass@host/path but it won't work.
Whe i use the same url on my computer for test it works fine.
Can you help me?

For those using GitLab:
You can pull from a private repo by using a URL in this format:
<EMAIL_ADDRESS>You can find the CI token for the project when editing a project as the "Runners token" (you probably have to enable builds and set up a runner).

I can't get catalog to work with an internally hosted gitlab server. To be clear: when you say:

For those using GitLab:
You can pull from a private repo by using a URL...
Do you mean more specifically a repository in gitlab that is NOT set to public?
My catalog repo is PUBLIC on my PRIVATE gitlab server, but I can't get it to work.
I am able to git clone https://my.private.gitlab.server/group/catalog.git from the rancher management hosts, with no auth just fine. Which leads me to believe I don't need a CI token.
Wondering if anyone else has gotten this to work, and what I am missing.

+1

@rb1980 I have exactly the same issue as you, but using a private Bitbucket instance with a repo that I made public (i.e. no username and password required).  Catalog service doesn't like that.  I tried using http rather than https, but that didn't help.  What do you mean by 'turning https off'?

@dj-hedgehog You can no longer do that ;( Gitlab-CI now generates unique tokens for each CI run.
You could generate your own personal access key, but that is global r/w for your account meaning if someone got that key, you're screwed ;(
I'm probably going to have to do my own image where ssh is installed and I copy in a private key. In that case, I can merely do a deploy key for the specific repo containing my catalog.

With github we found that we could use x-oauth-cloning  based cloning for private github repos:
example<EMAIL_ADDRESS>and it worked perfectly fine. Hope this helps

For bitbucket it is possible to generate an API key for teams under the API key in the manage team page.
This will allow you to access the repo with https via<EMAIL_ADDRESS>

The way I'm doing it is using the following script to run Rancher, https://github.com/flaccid/rightscripts/blob/master/install_and_run_rancher.bash. Set RANCHER_CONTAINER_SSH_PRIV_KEY with the git repo's SSH priv key needed and if required set RANCHER_CONTAINER_POST_CMDS to something like sh -c 'ssh-keyscan -p 7999 my.git.host.com >> /root/.ssh/known_hosts so the host key is accepted when checkout is attempted by server. A solution for git+ssh until native support.

It would be really nice to see this added as soon as possible. Adding the ability to store credentials or ssh key when adding a custom catalog.

Surprised no one has mentioned this but you can use Personal Access Tokens for this. Granted, they are tied to a user and not an organization or repo or anything, but they get the job done and at least prevent you from having to make your repo public.
Go to your account (or if your team has a bot Github account) and make a personal access token. The token just needs the "repo" permission to access private repos. Then your git clone URL looks something like<EMAIL_ADDRESS>

"For SSH (e.g. git@github.com:org/repo) the private key needs to be put into the rancher/server container. But it appears we don't package SSH so that's a problem.."
This would be great if this can happen soon :)

+1 for usuablity, we need a way support managing private ssh keys.. in order to be able to pull private catalogs. with the introduction of secrets, that would be a good combo

The suggested workarounds with private access tokens do not work with rancher 2.x. It fails with the following error:

"transitioningMessage": "parse git clone<EMAIL_ADDRESS>first path segment in URL cannot contain colon",

Hello, SSH functionality would be great, but I don't hate using https and tokens for this. However, GitLab is apparently formatting their API URLs differently these days and not allowing basic auth at the beginning of the URL. Instead, you have to insert a token at the end. The following URLs work in a browser:
https://gitlab.com/<mycompany>/<myrepo>/raw/index.yml?private_token=0000000000
https://gitlab.com/api/v4/projects/<projectID>/repository/files/index%2Eyml/raw?ref=master&private_token=0000000000
...but for RancherOS I obviously need to remove index.yml first. You're probably seeing the issue already, the end result is this:
https://gitlab.com/<mycompany>/<myrepo>/raw?private_token=0000000000/index.yml
...and the same result for the other URL.
So it seems like this would work fine if either GitLab didn't change to this insane formatting, or if RancherOS could support sending a simple header so I can add a private_token variable.

Close in favor of https://github.com/rancher/rancher/issues/13371 which will be released in 2.2.
Please raise a new issue if you have other questions.

@pdschandler A workaround would be to use a URL such as:
https://gitlab.com/<mycompany>/<myrepo>/raw/index.yml?private_token=00000000&bullshit=

Which ends in an URL like:
https://gitlab.com/<mycompany>/<myrepo>/raw/index.yml?private_token=00000000&bullshit=/index.yaml

Anyway, it seems this issue is fixed with the next 2.2 release

Thanks @akkie but I don't think that will work for my main use-case. Changing the fake ignore variable will not traverse the folder structure at all. RancherOS expects to find an index.yml file on it's own within a root folder path, and then uses that information to find folders in the same location that have docker-compose files in them. Thanks though, good idea in terms of one-off links.

Thanks to https://github.com/rancher/rancher/issues/3248#issuecomment-265512324. The following steps worked for me to configure a private repo in github as a catalog in Rancher (tried on v2.2.8)
I generated a personal access token on github (Settings > Developer Settings > Personal Access Token) with "repo" access.
In the catalog page:
Username:
Password: x-oauth-basic


Removing oracle driver and associated tests

Removing oracle jdbc driver from kogito_test_utils because of legal issues
Merge with https://github.com/apache/incubator-kie-kogito-apps/pull/1971

@porcelli but these references are not linked to the actual driver jar. We can't even mention oracle?

@porcelli Which else do you propose to remove?. Can you please point the place for the scripts? I was not aware of its existance, I just change the minimal to get rid of the driver (there are not specific test for Oracle in runtimes)

@porcelli About the enum, it might be useful to keep it for people that actually use Oracle with out stuff. Same rationale probably apply to the scripts, but I want to take a look to them first.

@porcelli I agree that we shouldn't left anything behind, but I would approve and merge this PR regardless, at least to resolve this emergency. We could address any other leftover with another follow up PR, but at least this wouldn't be blocker for the release anymore.

@mariofusco if this was the only remaining blocker for release; I'd agree with you. But since we still have time due other issues being worked.. I think we could have an adicional cycle to get this properly cleaned up.

@porcelli I do not understand why we need to remove a script that works, but since I do not want to discuss any longer, I will remove it

thank you @fjtirado for the changes!


email dev fails when running dev on Node >= 20

Discussed in https://github.com/resend/react-email/discussions/1151

Originally posted by neverlose-lv January 18, 2024
Hi there. I have a problem to run the react.email.
I have tried both methods (automated/manual).
But I ran into the same problem.
If I use node version 21.6 or 20.x, I get this error:
><EMAIL_ADDRESS>dev
> email dev

node:internal/errors:541
      throw error;
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "code" argument must be of type number. Received an instance of TypeError
    at process.set [as exitCode] (node:internal/bootstrap/node:123:9)
    at Object.exit (node:internal/process/per_thread:187:24)
    at process.<anonymous> (/Users/apower/Desktop/next-app/node_modules/react-email/dist/source/utils/start-server-command.js:43:27)
    at process.emit (node:events:519:28)
    at process._fatalException (node:internal/process/execution:178:25) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v21.6.0

If I use Node version 16.x or 18.x
the script just shows the first two lines and exists, without serving.

Closing as not planned as this seems to be an issue with an a version < 2.0.0


Backfill php error

I am getting a PHP error A void function must not return a value on your backfill method. I can see the method has a return statement, is the void annotation correct?

@djjavo Can you make the changes and open pull request?

@ajithv11 You need to store $tokenCredentials and userId in your database and retrieve it anytime to request your activity summary

@djjavo You can use version 1.6 while i fix the errors

@djjavo I have created new release and fixed the void errors and added example


fix usage: jira issue comment add

Describe the bug
The COMMENT_BODY is documented as a mandatory positional argument even though it's not.
Please provide following details

JiraCLI Version:

$ go install github.com/ankitpokhrel/jira-cli/cmd/jira@e229260dcdf04b855555feac7ba063bac3795257 && jira version
(Version="dev", GitCommit="", GoVersion="go1.17.5", BuildDate="", Compiler="gc", Platform="linux/amd64")

Are you using Jira cloud or on-premise jira server? Also mention the version for on-premise installation.

cloud

What operating system are you using? Also mention version.

$ cat -n /etc/os-release
     1	NAME="Ubuntu"
     2	VERSION="20.04.3 LTS (Focal Fossa)"
     3	ID=ubuntu
     4	ID_LIKE=debian
     5	PRETTY_NAME="Ubuntu 20.04.3 LTS"
     6	VERSION_ID="20.04"
     7	HOME_URL="https://www.ubuntu.com/"
     8	SUPPORT_URL="https://help.ubuntu.com/"
     9	BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
    10	PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
    11	VERSION_CODENAME=focal
    12	UBUNTU_CODENAME=focal

What terminal are you using? Also mention version.

$ gnome-terminal --version
# GNOME Terminal 3.36.2 using VTE 0.60.3 +BIDI +GNUTLS +ICU +SYSTEMD

To Reproduce
Steps to reproduce the behavior:
$ jira issue comment add FOOBAR-42 --no-input --template - <<'EOF'
This is a comment.
EOF

Expected behavior
If the COMMENT_BODY were really necessary, then one might expect to see an error message like this:
Error:
  - comment: Comment body can not be empty!

Since COMMENT_BODY is not actually necessary, the jira issue comment add --help message should be changed from this...
$ jira issue comment add --help | head -n4
Add adds comment to an issue.

USAGE
  jira issue comment add ISSUE-KEY COMMENT_BODY [flags]

...to this:
$ jira issue comment add --help | head -n4
Add adds comment to an issue.

USAGE
  jira issue comment add ISSUE-KEY [COMMENT_BODY] [flags]

Screenshots
not applicable
Additional context
not applicable

Addendum:
jira issue comment add tolerates the following undocumented orderings of options and positional arguments:
jira issue comment add FOOBAR-42 --no-input "comment body"
jira issue comment add --no-input FOOBAR-42 "comment body"

The usage should be changed to reflect these supported orderings or the implementation should be changed to reject them.

Steps to reproduce the behavior:

$ jira issue comment add FOOBAR-42 --no-input --template - <<'EOF'
This is a comment.
EOF

@realtime-neil you are still passing COMMENT_BODY here as a template. Jira API doesn't allow you to add a comment without body (it won't make any sense to add a comment without body right?). The README mentions few different ways to get comment body for the command.
# Normal usage
$ jira issue comment add ISSUE-1 "My comment body"

# Load comment body from a template file
$ jira issue comment add ISSUE-1 --template /path/to/template.tmpl

# Get comment body from standard input
$ jira issue comment add ISSUE-1 --template -

# Or, use pipe to read input directly from standard input
$ echo "Comment from stdin" | jira issue comment add ISSUE-1

Regarding your query about undocumented orderings, the flags are POSIX-complaint and AFAIK the flag could be in any order. From the docs:

Options may be supplied in any order, or appear multiple times. The interpretation is left up to the particular application program.

I don't think this is a problem here. If it is helpful we can add more example in command help jira issue comment add -h.

@ankitpokhrel

The README mentions few different ways to get comment body for the command.

Yes, the README does mention the various ways to effect an issue comment. The jira issue comment add usage does not. In conventional usage verbiage
my-tool [OPTION]... ARGUMENT

connotes a command that takes some arbitrary options (or none at all) and exactly one positional argument, customarily given after all (any) OPTARGs. Compare/contrast this with
my-tool [OPTION]... [ARGUMENT]

which connotes exactly one optional positional argument. It would be nice if this were enforced by the implementation of jira issue comment add. Failing that, it should at least be mentioned in the command usage, if only to avoid surprising the user.
While we're on the subject of user surprises, consider the following:
ira issue comment add FOOBAR-42 "comment body positional" --template - <<'EOF'
> comment body template

In this example, the "comment body positional" wins over "comment body template". This should probably be documented in the usage, as well.

@ankitpokhrel

the flags are POSIX-complaint and AFAIK the flag could be in any order

This remark deserves some qualification. The presentation and ordering of the OPTARGs and positional arguments can be arbitrary, but only after the complete sub-sub-sub-command. That is,
jira issue comment add --no-input FOOBAR-42 'hello comment!'

is valid, but
jira issue comment --no-input add FOOBAR-42 'hello comment!'

is not --- even though add is the only sub-sub-sub-command under the jira issue comment sub-sub-command.

@realtime-neil I updated the docs to reflect our discussion in #235. I hope that's clear enough 🙃

@ankitpokhrel we never had any discussion in #235 . This is unclear and I'm confused.
I'm happy to see that you're maintaining the documentation, but this issue wasn't about documenting anything. It was (and is) about changing the jira issue comment add usage (and/or implementation) such that the --help message more accurately shows how to invoke the (sub-sub-sub-) command and how arguments thereto are parsed.

@realtime-neil I just re-read entire thread and realized that COMMENT_BODY is not optional in help 🤦🏻. Sorry for the confusion.
jira issue comment add ISSUE-KEY [COMMENT_BODY] [flags]

And since this is a really small change, a PR would've been nice :)

And since this is a really small change, a PR would've been nice :)

I'm happy to oblige. :grin:


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_dcmqmer4k5/clone/recipe/meta.yaml:22: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_dcmqmer4k5/clone/recipe/meta.yaml:28: missing_pip_check: For pypi packages, pip check should be present in the test commands
WARNING: /tmp/abs_dcmqmer4k5/clone/recipe/meta.yaml:34: missing_description: The recipe is missing a description
ERROR: /tmp/abs_dcmqmer4k5/clone/recipe/meta.yaml:34: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_dcmqmer4k5/clone/recipe/meta.yaml:34: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_dcmqmer4k5/clone/recipe/meta.yaml:34: missing_dev_url: The recipe is missing a dev_url
Errors were found