calling stateClient.BotState.GetUserDataAsync generates "Unable to deserialize the response."

Calling stateClient.BotState.{GetUserDataAsync | GetPrivateConversationDataAsync} triggers an exception "exceptionMessage": "Unable to deserialize the response.",  "exceptionType": "Microsoft.Rest.SerializationException"

I am using the MS Bot Framework Channel Emulator

PS: I have looked at other closed issues related to the same issue and I couldn't figure out why it didn't work
Thank you in advance for your help
line that is crashing
BotData userData = await stateClient.BotState.GetUserDataAsync(activity.ChannelId, activity.From.Id);

Post from the Emulator to the Server
{
    "type": "conversationUpdate",
    "id": "99999999999999999999999999",
    "timestamp": "2016-09-19T08:49:00.0605362Z",
    "serviceUrl": "https://ciafsb.ngrok.io/",
    "channelId": "emulator",
    "from": {
        "id": "2c1c7fa3",
        "name": "User1"
    },
    "conversation": {
        "isGroup": false,
        "id": "8a724db8",
        "name": "Conv16"
    },
    "recipient": {
        "id": "56800324",
        "name": "Bot1"
    },
    "membersAdded": [
        {
            "id": "2c1c7fa3",
            "name": "User1"
        },
        {
            "id": "56800324",
            "name": "Bot1"
        }
    ],
    "membersRemoved": [],
    "text": "[conversationUpdate] Added: User1 Bot1 ",
    "attachments": [],
    "entities": []
}

Piece of code I am trying to run
         case ActivityTypes.ConversationUpdate:

            // Handle conversation state changes, like members being added and removed
            // Use Activity.MembersAdded and Activity.MembersRemoved and Activity.Action for info
            // Not available in all channels

            telemetry.TrackEvent("ReplyActivityTypes.ConversationUpdate");

            //sample taken from https://github.com/MarySam/WaitTime/blob/7889f9ee700c29b8b27df3489d8bb10736f56c8c/BotWait/CSharp/Samples/EchoBot/Controllers/MessagesController.cs
            IConversationUpdateActivity update = activity;

            StateClient stateClient = activity.GetStateClient();

            try
            {
              using (var scope = DialogModule.BeginLifetimeScope(Conversation.Container, activity))
              {
                var client = scope.Resolve<IConnectorClient>();
                if (update.MembersAdded.Any())
                {
                  replyToConversation = activity.CreateReply($"ConversationUpdate");
                  replyToConversation.Type = ActivityTypes.ConversationUpdate;
                  foreach (var newMember in update.MembersAdded)
                  {

                    // display the amount of times the user came back
                    BotData userConversationData = await stateClient.BotState.GetUserDataAsync(activity.ChannelId, activity.Conversation.Id); // trigger exception GetPrivateConversationDataAsync
                    var counter = userConversationData.GetProperty<int>("counter");

                    // display info about the new member
                    if (newMember.Id != activity.Recipient.Id)
                    {
                      replyToConversation.Text = $"Welcome {newMember.Name}! for the [{++counter}] time";
                    }
                    else
                    {
                      replyToConversation.Text = $"Welcome {activity.From.Name} for the [{++counter}] time";
                    }

                    // save our new counter by adding it to the outgoing message
                    userConversationData.SetProperty<int>("counter", counter);
                    await stateClient.BotState.SetPrivateConversationDataAsync(activity.ChannelId, activity.Conversation.Id, activity.From.Id, userConversationData);

                    // return our reply to the user
                    await client.Conversations.ReplyToActivityAsync(replyToConversation);
                  }
                }
              }
              response = Request.CreateResponse(HttpStatusCode.OK);
            }
            catch (Exception e)
            {
              Activity reply = activity.CreateReply($"Yikes, hit the exception [{e.Message}], sorry!");
              await connector.Conversations.ReplyToActivityAsync(reply);
              throw e;
            }
            break;

packages.config
<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="Autofac" version="4.1.0" targetFramework="net46" />
  <package id="Chronic.Signed" version="0.3.2" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights" version="2.1.0" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.Agent.Intercept" version="2.0.1" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.DependencyCollector" version="2.1.0" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.JavaScript" version="0.22.19-build00125" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.PerfCounterCollector" version="2.1.0" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.Web" version="2.1.0" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.WindowsServer" version="2.1.0" targetFramework="net46" />
  <package id="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" version="2.1.0" targetFramework="net46" />
  <package id="Microsoft.AspNet.WebApi" version="5.2.3" targetFramework="net46" />
  <package id="Microsoft.AspNet.WebApi.Client" version="5.2.3" targetFramework="net46" />
  <package id="Microsoft.AspNet.WebApi.Core" version="5.2.3" targetFramework="net46" />
  <package id="Microsoft.AspNet.WebApi.WebHost" version="5.2.3" targetFramework="net46" />
  <package id="Microsoft.Bot.Builder" version="3.2.1" targetFramework="net46" />
  <package id="Microsoft.IdentityModel.Logging" version="1.0.0" targetFramework="net46" />
  <package id="Microsoft.IdentityModel.Protocol.Extensions" version="<IP_ADDRESS>8261200" targetFramework="net46" />
  <package id="Microsoft.IdentityModel.Tokens" version="5.0.0" targetFramework="net46" />
  <package id="Microsoft.Rest.ClientRuntime" version="2.3.2" targetFramework="net46" />
  <package id="Microsoft.WindowsAzure.ConfigurationManager" version="3.2.1" targetFramework="net46" />
  <package id="Newtonsoft.Json" version="9.0.1" targetFramework="net46" />
  <package id="System.IdentityModel.Tokens.Jwt" version="<IP_ADDRESS>8261200" targetFramework="net46" />
</packages>

Exception got on ngrok http://localhost:4040
{
    "message": "An error has occurred.",
    "exceptionMessage": "Unable to deserialize the response.",
    "exceptionType": "Microsoft.Rest.SerializationException",
    "stackTrace": "   at Microsoft.Bot.Connector.Conversations.<ReplyToActivityWithHttpMessagesAsync>d__7.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Bot.Connector.ConversationsExtensions.<ReplyToActivityAsync>d__15.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()\r\n   at MyBotFormFlow.MessagesController.<Post>d__1.MoveNext() in C:\\aProject\\Controllers\\MessagesController.cs:line 205\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Threading.Tasks.TaskHelpersExtensions.<CastToObject>d__3`1.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Controllers.ActionFilterResult.<ExecuteAsync>d__2.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext()",
    "innerException": {
        "message": "An error has occurred.",
        "exceptionMessage": "Unexpected character encountered while parsing value: <. Path '', line 0, position 0.",
        "exceptionType": "Newtonsoft.Json.JsonReaderException",
        "stackTrace": "   at Newtonsoft.Json.JsonTextReader.ParseValue()\r\n   at Newtonsoft.Json.JsonTextReader.Read()\r\n   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.ReadForType(JsonReader reader, JsonContract contract, Boolean hasConverter)\r\n   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)\r\n   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)\r\n   at Microsoft.Rest.Serialization.SafeJsonConvert.DeserializeObject[T](String json, JsonSerializerSettings settings)\r\n   at Microsoft.Bot.Connector.Conversations.<ReplyToActivityWithHttpMessagesAsync>d__7.MoveNext()"
    }
}

Why do you set the replyToConversation.Type to ActivityTypes.ConversationUpdate when sending a reply back to the conversation?  I assume you would prefer to send a message type back to the user.

Dear @willportnoy your comment is correct, nevertheless the following triggers the same exception where

ChannelID = "emulator"
ConversationID = "8a684dba"

BotData userConversationData = await stateClient.BotState.GetUserDataAsync(activity.ChannelId, activity.Conversation.Id);

PS: thanks for mentioning the fact that I made a mistake with the replyToConversation

We have released a new emulator so hopefully your issue is fixed.  If not, please let us know.

I'm going to close this issue for now, but feel free to open a new issue for further discussion.


Fix release test run

How to categorize this PR?

/area dev-productivity
/kind bug
/priority normal
What this PR does / why we need it:
In the test-e2e step during the release job the release tag will not exist on GitHub (yet), so we need to inject the current HEAD commit sha, so that the test-machinery can retrieve the current TestDefinitions from the repo.
Though, for the terraformer we still want to inject the docker image tag of the release, which should be tested.
This PR adapts the test run config and so on accordingly.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

/test

/test

/ready

/invite @gardener/test-infra-maintainers


Add app navigation context & app data context + add skeleton components for store list & flow picker

Summary of changes 🔍
Adding a bunch of boiler plate for new screens and app navigation
Contexts

Adding AppNavigationContext for transitioning between pages (Wizard is a page now)
Adding AppDataContext for managing app level state like which page we are on, loc, theme, etc.
Rename DataManagementContext to WizardDatamanagementContext to avoid confusion with the app data context

Pages

Adding StoreListPage page for picking a data store or creating a new one
Adding FlowPickerPage page for picking which action to take "Discover", "Modify", "View"
Adding WizardPage page for hosting the wizard component. The wizard related contexts are initialized here.

Components

Adding StoreList component for showing the list of existing stores - to be wired to adapters later
Adding FlowPicker component for picking which action to take "Discover", "Modify", "View"

Testing 🧪

[ Add any special instructions needed to test or view your changes such as environment URLs or other config details. ]

Checklist ✔

[ ] Linked associated issue (if present)
[ ] Added relevant labels
[ ] Requested developer reviews
[ ] Request UI review from design / PM
[ ] Verify all code checks are passing

I dont see the existing DataPusher under Components anymore? Where did it go, don't see it in diff either?


drep-state is making --drep-verification mandatory

The help, suggests that * Get the DRep state. If no DRep credentials are provided, return states for all
of them.*, however using any of the --drep- flags is mandatory.

If the query can return all drep when no flag is provided, then the flag should not be mandatory <- most desired!!

If the query can only return state for individual dreps, then we need to amend the help

cardano-cli conway governance query drep-state --testnet-magic 4
Missing:
  ( --drep-verification-key STRING
  | --drep-verification-key-file FILE
  | --drep-key-hash HASH
  )

Usage: cardano-cli conway governance query drep-state
                                                        [--socket-path SOCKET_PATH]
                                                        [ --shelley-mode
                                                        | --byron-mode
                                                          [--epoch-slots SLOTS]
                                                        | --cardano-mode
                                                          [--epoch-slots SLOTS]
                                                        ]
                                                        ( --mainnet
                                                        | --testnet-magic NATURAL
                                                        )
                                                        ( --drep-verification-key STRING
                                                        | --drep-verification-key-file FILE
                                                        | --drep-key-hash HASH
                                                        )
                                                        [--out-file FILE]

  Get the DRep state. If no DRep credentials are provided, return states for all
  of them.

@CarlosLopezDeLara It seems that the same issue was also holds for cardano-cli conway governance query drep-stake-distribution. I fix both issues in #348.

Asewome!! Il give it a test drive shortly


Update GitHub Action

@kasper I got the GitHub Action to work here:

Nice! I just copied from https://github.com/bullet-train-co/showcase/blob/fd9bd359326facc003fa5dfb2587f4427522d308/.github/workflows/ci.yml and looks like I missed some stuff 😄

No problem :smiley:


Document remote-pry usage with Invoker

Fixed with https://github.com/code-mancers/invoker/commit/e1a0f3ff3ff079c0e293de0a7090955efac06ed5

This no longer works with newer ruby/rails/invoker
One work around is to run rails separately and then use invoker add_http appname port
It'd be nice to have an option to somehow do this from the invoker config, but I'm not sure


[share_plus] [iOS] Instagram story does not show up in iOS while sharing image file

Very similar to #380. Can't share image to instagram stories on iOS, I can only see one Instagram icon and it is for sharing the video as a standard Instagram Post.
On the other hand, in Android sharing a video file shows up all 3 options:

Instagram Feed
Instagram Direct
Instagram Story

Hi, @raulmabe.
Do you still encounter the issue?
I can't reproduce it as well as the #380.
https://user-images.githubusercontent.com/20175372/135515693-f5597891-2f01-4225-bd24-f298b6c48a48.mov

You are right, I no longer encounter this issue! I honestly don't know what fixed it


svnsync all allegiance related repos to SF

Try to add a svnsync to the sourceforge cron for the root of svn.alleg.net (all 3 repos excluding ms_original and artwork)
Imported from trac ticket #204,  created by Imago on 08-04-2010 at 07:18, last modified: 04-29-2012 at 17:13

obsolete stuff.


Line Control Measures have issues w/ Scale

Summary of Issue Encountered:
Brief summary of issue encountered:
Describe the product and version used:
10.5 Portal
Include the military symbology standard and version/change set (ex. -2525D):
Reproduction Steps and/or Where to Obtain Test Data:
https://nationalsecurity.esri.com/portal/home/item.html?id=9b94ddf19dab424aa490f68153798747
Step-by-step description of how to reproduce the issue and the expected results:

Screenshot(s) of issue (ex: obtained result vs. expected result):

Additional information or sample data:

This should be a known issue with the DictionaryRenderer in Pro & Runtime.
The only way to do this (not have the line styles scale) currently, is to set the Reference Scale on the Map.

Agreed, I had to run before I completely filled it out, but I did want to capture it as an issue.


Add basic Identity

If I start app and I click button "Add new employee" than I get pop "failed to insert employee" and I don't know why?

Are you logged in? Or you lunch it on empty database

ok, now everything works with web assembly. I handle communication in better way and use build in toast message service

If I login and then logout I got pop "logout succesful" but I still see on main page button logout

Yeah, I still have to figure out, how to recognize user session is on.

If I login and then logout I got pop "logout succesful" but I still see on main page button logout

fixed

Let's check newest version. Everything should works

button register doesn't work after fill in not correct email and/or password (or without filling). I don't know why I can't register. I don't see any message error. For example, I set wrong password "1234" and I don't get any information "Passwords must be at least 6 characters." In swagger this work correctly and I see validation:-). I can only register correctly within api and swagger

fixed, but not completely. I add TODO for the future. It is not critical (UI respond what exactly is wrong).

If I start app and I'm not logged and than I click button "Add new employee" than I get pop "failed to insert employee" and I don't know why? I think better is add message "Try to login or register". After login this button works properly.

I think more toast message can be write better :) we will check it later

If I click the login button without filling in email and password I get error "System.NullReferenceException". Also I get error if I set f.e wrong password. Still not working properly, after clicking login without filling txtboxes the app is crashed.

fixed


MINIFICPP-1158 - Event driven processors can starve each other

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Created Jira for the unstable http tests:
https://issues.apache.org/jira/browse/MINIFICPP-1172


getting a error on 'dashing start'

$ dashing start
config.ru:1:in require': /Library/Ruby/Gems/1.8/gems/dashing-1.0/lib/dashing.rb:20: syntax error, unexpected ':', expecting $end (SyntaxError) set server: 'thin', connections: [], history: {}            ^ 	from config.ru:1 	from /Library/Ruby/Gems/1.8/gems/rack-1.4.1/lib/rack/builder.rb:51:in instance_eval'
from /Library/Ruby/Gems/1.8/gems/rack-1.4.1/lib/rack/builder.rb:51:in initialize' 	from config.ru:1:in new'
from config.ru:1

I am getting this error with ruby 1.9.3. Any suggestions?

It can not be the same error on ruby 1.9.3, if so, probably  you are using 1.8 without know about.
Guess you use RVM on your user profile, and are having troubles starting dash by a script placed on rc.d or other similar unattended script runner engine.


chore(prow/jobs/pingcap/tidb): enable job check2, mysql-test, unit-test

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:

/merge


isCancelled is not true in finally handler

I have this fiddle to demonstrate (https://jsfiddle.net/4hf6wcxL/1/) but the gist is that this:
// Bluebird 3.3.0
Promise.config({
	cancellation: true
})

var anyed = Promise.all([
    new Promise((res, rej, can) => {
        setTimeout(res, 1000);
        can(() => console.log("woo"));
    }),
    new Promise((res, rej, can) => {
        setTimeout(res, 2000);
        can(() => console.log("boo"));
    })
])
.then(() => console.log("done"))
.finally(() => console.log(anyed.isCancelled()));

Promise.delay(500).then(_ => anyed.cancel())

prints
woo
boo
false

but according to the docs it should print true in the last instance.

anyed refers to the promise returned by .finally() which is not cancelled because If you were to throw inside the finally handler, it would be rejected.
Did you mean to do this?

var anyed = Promise.all([
    new Promise((res, rej, can) => {
        setTimeout(res, 1000);
        can(() => console.log("woo"));
    }),
    new Promise((res, rej, can) => {
        setTimeout(res, 2000);
        can(() => console.log("boo"));
    })
])
.then(() => console.log("done"));

anyed.finally(() => console.log(anyed.isCancelled()));

Promise.delay(500).then(_ => anyed.cancel())

Ahh okay, thanks for the clarification!


Add support for Log Rotation configuration

Is your feature request related to a problem? Please describe.
Currently it's not possible to configure the Log Rotation through this terraform provider (UI: "Administration" -> "Clean Up" -> "Log Rotation", REST-Endpoint: "/system/purgeaudit/schedule").
Describe the solution you'd like
I'd like to be able to configure the Log Rotation through this provider. Values you would want to set are analogous to the ones from the related API-Request.
{"parameters":{"audit_retention_hour":integer,"dry_run":boolean, "include_operations":"create,delete,pull"},"schedule":{"type":"Hourly","cron":"0 0 * * * *"}}
Additional context

hi,
thanks for the feature request, it's available with v3.9.3


Segfault in JDK 21 processing tests

We've been seeing a high degree of segfaults recently in the processing unit tests under JDK 21. Here's an example: https://github.com/apache/druid/actions/runs/11528594002/job/32166241444?pr=17414. The common thread is an error like this:
Current CompileTask:
C2:1780380 144967       4       org.apache.druid.query.filter.InDimFilter::optimizeLookup (744 bytes)

Stack: [0x00007f9c045fb000,0x00007f9c046fb000],  sp=0x00007f9c046f6660,  free space=1005k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
V  [libjvm.so+0xf15629]  BoolNode::Ideal(PhaseGVN*, bool)+0x19
V  [libjvm.so+0xd6258e]  PhaseIterGVN::transform_old(Node*)+0x9e
V  [libjvm.so+0x6ba360]  Conv2BNode::Ideal(PhaseGVN*, bool)+0x180
V  [libjvm.so+0xd6258e]  PhaseIterGVN::transform_old(Node*)+0x9e
V  [libjvm.so+0xd5e4a9]  PhaseIterGVN::optimize()+0xf9
V  [libjvm.so+0x6712cf]  Compile::Optimize()+0xf9f
V  [libjvm.so+0x672a06]  Compile::Compile(ciEnv*, ciMethod*, int, Options, DirectiveSet*)+0xf26
V  [libjvm.so+0x598acb]  C2Compiler::compile_method(ciEnv*, ciMethod*, int, bool, DirectiveSet*)+0x18b
V  [libjvm.so+0x678ee4]  CompileBroker::invoke_compiler_on_method(CompileTask*)+0xca4
V  [libjvm.so+0x67c0d8]  CompileBroker::compiler_thread_loop()+0x6a8
V  [libjvm.so+0x931f40]  JavaThread::thread_main_inner()+0x1e0
V  [libjvm.so+0xf86b88]  Thread::call_run()+0xa8
V  [libjvm.so+0xd103ba]  thread_native_entry(Thread*)+0xda

Things that did not help include:

Using Corretto instead of Zulu (#17426)
Switching off jfr_profiler (#17418).
Updating various test/build dependencies (#17414).

Since this is in the C2 compiler, and only happens on JDK 21, it seems likely to be a JDK bug rather than something we're doing wrong.
@pranavbhole has raised a support case with Azul at https://support.azul.com/hc/en-us/requests/65354. We don't have any special support contract with them, so hopefully they respond out of the goodness of their hearts. Since this issue happens on Corretto too, it's possibly a broader OpenJDK issue, so we could also consider raising a bug with OpenJDK.

Hi @gianm , it appears that a similar issue has already been reported and resolved in JDK-8323190. You may want to confirm this by checking the details in the issue report :smile:

I received a response from Azul regarding the Zulu JDK crash. I informed them that the issue is consistently reproducible (still occurring with the latest master commit). Azul has requested a core dump as well as list of shared libraries to analyze the crash.
There is
# Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /home/runner/work/druid/druid/processing/core.3533)
and
rlimit (soft/hard): STACK 16384k/infinity , CORE 0k/infinity , NPROC 63899/63899 , NOFILE 65536/65536 , AS infinity/infinity , CPU infinity/infinity , DATA infinity/infinity , FSIZE infinity/infinity , MEMLOCK 8192k/8192k
in hs_err file, that tells there might be a core dump in the system generated after crash happened.
In case you manage to locate core file please collect the shared libs as well.
You can use this command
grep '/.*\.so' hs_err_pid1913.log | awk '{ print $NF }' | uniq > libs.txt
Then run the following command on the resulting libs.txt file from above
tar -czf libs.tgz -T libs.txt

Upload core and libs.tgz to the file sharing resource and your convenience and share the link to download.

Looks like we have setting in place to check if core.pid file dumped but unfortunately core dumps are not being generated and aborted due to memory limitations.

this issue was blocking me for a few days now - so I was forced to take a look ;)
so far my observations are:

the issue did happened even earlier with different GHA ubuntu images
its nondeterministic; I've seen it happen with 2-3 tests; the most common victim is AndFilterTest ; but it could be SelectorFilterTest as well - so its not related to just one testclass
I've blind-tuned the jit to be more agressive...right now I'm not sure if that even mattered
I was able to repro it locally after I've switched to OpenJDK Runtime Environment Zulu21.38+21-CA (build 21.0.5+11-LTS)

I was running 21.0.4 earlier which was unaffected with several attempts
switching to 21.0.5 right away showed the issue; so it must be introduced in 21.0.5

the issue consistently happens with org.apache.druid.query.filter.InDimFilter::optimizeLookup
my attempts to get a disassembly so far was unsuccessfull; I was bumping into that I'm not prepared for it as hsdis-amd64.so  is missing
all tests run in a single jvm -> jvm retains method invocation counts from earlier tests
surefire test execution order is unspecified - which makes surefire run them in filesystem order (which becomes essentially a random in CI runs)
right now the shortest running command which is still able to repro the issue is:

time mvn install -pl processing/ -Dtest=AndFilterTest,SuperSorterTest*,InFilterTests,*FilterTest -Pskip-static-checks

even thru the test execution order is the same I've seen crashes in 3 different tests (NotFilterTest ; AndFilterTest ; SelectorFilterTest)

I think right now we have the following options:

debug it further

even if we uncover the underlying issue - a new jdk release will be needed to get rid of the problem ; which might take some time...so we will need an alternate fix until that will happen

disable the affected tests: not really an option since the C2 optimization of InDimFilter::optimizeLookup may trigger the issue
from the call stack it seem like its connected to the C2 compiler - so disabling C2 optimization for tests on 21 might also be a possible way out
possibly force 21.0.4 to be used
try to not reuse the jvm for subsequent test runs (reuseforks)
other options?

@kgyrtkirk shared a core dump and libs archive with me offline. I've attached them to the Azul support case.

disabling C2 optimization for tests on 21 might also be a possible way out

This seems like the best temporary approach. I raised #17456 to attempt it.

Now a quidem test is failing with:
*** java.lang.instrument ASSERTION FAILED ***: "!errorOutstanding" with message transform method call failed at src/java.instrument/share/native/libinstrument/JPLISAgent.c line: 884

Maybe JDK 21 is too buggy and we should switch off its unit tests for now 😛

Switching the JDK distribution to temurin in #17449 seems to not have the segfaults seen in the JDK 21 tests, at least in the four repeated CI runs. Any thoughts on switching the distribution from zulu to temurin? This is similar to #17426, but the temurin build appears to help.
cc: @gianm @kgyrtkirk

Switching the JDK distribution to temurin in #17449 seems to not have the segfaults seen in the JDK 21 tests, at least in the four repeated CI runs. Any thoughts on switching the distribution from zulu to temurin?

The logs in #17449 say the JDK version is 21.0.4+7. Given we only started seeing this problem with Zulu in 21.0.5 (21.0.4 was fine), it's probably just working because the temurin JDK happens to be older right now. But that might change. I guess it will work for some time though, until the temurin build upgrades.

Trying to pin to JDK 21.0.4: #17458

Ah got it, I didn't notice the difference in JDK update version with temurin. Pinning the version to JDK 21.0.4 makes sense.

fyi: I've run locally temurin 21.0.5 - and it did produced the issue; so we won't be out of the water with it...I should have closed the PR around that time....
but I've encountered a 21.0.5 which did passed these tests: using the openjdk-21-jdk package shipped with debian/trixie I was not able to reproduce the issue (this doesn't necessary mean its not there; but there is a possibility that it was patched)
I think we should go to 21.0.4 until it gets fixed

"Fixed" for now in #17458. It's not really fixed for good, this is just a workaround. Hopefully the Azul folks come through for us. If not, it sounds like we'd be able to raise this issue with various other JDK suppliers, as we've seen it in others too.


Stage dragging messes up positions of child elements

I have a canvas on which I display some nodes which are connected by lines. I save the position of my nodes in a Redux store. To determine how I should draw my line from 1 node to another one I just check the position of the parent- and childnodes and draw the line by using the x and y values of its parent and child node.
so my node object looks like this:
{id: 'node1', x:0, y:100}
And my line object looks like this:
{childNode: 'node1', parentNode: 'someOtherNode' }
I connected my Line and Node to the redux store and only update them when they change in my redux store. This worked perfect until I tried to add draggable to my stage. The nodes do still update properly but the position of the line does not match the positions of the parent- and childnode.

@Bobvantpadje can you make a demo?

Thanks for the reply. I already fixed it by saving the x and y movement of the Stage in my redux store and then subtracting this from the x and y value of my nodes. This works fine.


fix(checkbox,radio): fixed layout when there is multiple lines of tex…

…t in the label
Issue:

After:

Solving issue
In case of GitHub issue add # plus the number of the issue (for example #123) OR if it is Azure then AB# and number of ticket
Fixes: #DTS-1601, #DTS-1602
Additional context
Issue found by Gökberk in support channel.

I'm not getting any wrap?


serde(with = "SerHex::") NodeId

Without adding this if you tried to
        let mut responses: HashMap<NodeId, u16> = Default::default();
        responses.insert(discv5::enr::NodeId::random(), 1);
        let hi = json!(responses);

json!(...) will fail with "key must be a string"

@divagant-martian @AgeManning ping for review

I see a couple issues with this suggestion, and with the PR itself
Regarding the PR, pleasecheck this compiles first. Right now it doesn't.
Regarding the suggestion itself, NodeId derives Serialize and Deserialize already, and there is a explicit test for json serialization. From what I can tell, you want to serialize the RawNodeId as a hex string unconditionally. Although this is a breaking change, it's one I find reasonable. To be clear, this would make it so that anyone using the NodeId serialization with a different serializer to the one you propose would now get a different output without option to configure it, so we need to decide if this is acceptable. I think it is
Now, even if we do this change, as it is right now, I suspect this won't solve your issue. Changing the serialization of the inner type won't make the outer type a string (which is the error you want to solve) it will still be serialized as a json object. That being said, if you want to get this change working so that we can discuss accepting the breaking change, you probably want/need to:

leverage serde(transparent)
a test

I see a couple issues with this suggestion, and with the PR itself
Regarding the PR, please check this compiles first. Right now it doesn't.
Regarding the suggestion itself, NodeId derives Serialize and Deserialize already, and there is a explicit test for json serialization. From what I can tell, you want to serialize the RawNodeId as a hex string unconditionally. Although this is a breaking change, it's one I find reasonable. To be clear, this would make it so that anyone using the NodeId serialization with a different serializer to the one you propose would now get a different output without option to configure it, so we need to decide if this is acceptable. I think it is
Now, even if we do this change, as it is right now, I suspect this won't solve your issue. Changing the serialization of the inner type won't make the outer type a string (which is the error you want to solve) it will still be serialized as a json object. That being said, if you want to get this change working so that we can discuss accepting the breaking change, you probably want/need to:

leverage serde(transparent)
a test

Ok I did some testing
https://github.com/sigp/enr/pull/35
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
/// The `NodeId` of an ENR (a 32 byte identifier).
pub struct NodeId {
    raw: RawNodeId,
}

#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
/// The `NodeIdSerde` of an ENR (a 32 byte identifier).
pub struct NodeIdSerde(RawNodeIdSerde);

#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
/// The `NodeIdSerde3` of an ENR (a 32 byte identifier).
pub struct NodeIdSerde3 {
    #[serde(with = "SerHex::<StrictPfx>")] raw: RawNodeIdSerde3,
}

The three above all fail
but
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[derive(Clone, Copy, PartialEq, Eq, Hash)]
/// The `NodeIdSerde2` of an ENR (a 32 byte identifier).
pub struct NodeIdSerde2(#[serde(with = "SerHex::<StrictPfx>")] RawNodeIdSerde2);

^ this will pass
When I get some time I will try and debug this and see what the root of the issue is. Thank you for your time and pointing a few things out to me :+1:

To give you a hand here, this code works
diff --git a/Cargo.toml b/Cargo.toml
index 2ac529d..8f20730 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -14,7 +14,7 @@ exclude = [".gitignore", ".github/*"]
 [dependencies]
 base64 = "0.21.0"
 bytes = "1"
-hex = "0.4.2"
+hex = {version = "0.4.2", features = ["serde"]}
 log = "0.4.8"
 rand = "0.8"
 rlp = "0.5"
diff --git a/src/node_id.rs b/src/node_id.rs
index 6713b7f..4970b82 100644
--- a/src/node_id.rs
+++ b/src/node_id.rs
@@ -10,8 +10,10 @@ type RawNodeId = [u8; 32];
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 #[derive(Clone, Copy, PartialEq, Eq, Hash)]
 /// The `NodeId` of an ENR (a 32 byte identifier).
+#[serde(transparent)]
 pub struct NodeId {
-    #[cfg_attr(feature = "serde", serde(with = "SerHex::<StrictPfx>"))] raw: RawNodeId,
+    #[cfg_attr(feature = "serde", serde(with = "hex::serde"))]
+    raw: RawNodeId,
 }

 impl NodeId {

but it needs a bit more love

@divagant-martian thank you so much for the help :D. I added a testcase to this PR and it works!!!! I am not exactly sure what you meant by a bit more love, but I one lined the cfg_attr
Let me know if anything else is needed :)
Thank you very much for all the help!

So this uses the hex::serde turning on the serde feature, a couple of points to note on this

feature should be turned on conditionally, not all the time
this does not do hex encoding prefix, we need to decide whether we want it to be 0x.. or not
as my suggestion was, it was missing a test

That's the love it was (still partially) missing

So this uses the hex::serde turning on the serde feature, a couple of points to note on this

feature should be turned on conditionally, not all the time

I think it is like that right now, but I could be wrong. Would I also need to add a cfg in the Config.toml for features=serde?

this does not do hex encoding prefix, we need to decide whether we want it to be 0x.. or not

0x since it is a universal identifier, but I am not picky as long as NodeId can be used as a hashmap key :)

as my suggestion was, it was missing a test

I just added a test, let me know if you would want another :+1:

That's the love it was (still partially) missing

Ah :+1:

Clippy seems to be failing at the moment.

it's unrelated, fix here https://github.com/sigp/enr/pull/36

it's unrelated, fix here #36

it is unrelated to this PR, but I think we need to add all-targets or something to the clippy command since clippy locally is complaining about a lot of other things not being picked up by CI, which makes it unusable locally for me on this project. Could be a issue on my end don't know

I can run cargo clippy without all features on the master branch without issue. Not sure what errors you are getting.
If you can merge in the latest master, CI should hopefully run fine now.

rebased

On second thought, the all-targets just makes clippy run over the tests. Not sure if we are concerned about whether tests are formatted with clippy lints or not.
Others have an opinion here? @divagant-martian ?

On second thought, the all-targets just makes clippy run over the tests. Not sure if we are concerned about whether tests are formatted with clippy lints or not.
Others have an opinion here? @divagant-martian ?

Yeah I am not sure what would resolve it, but I will send a snippet of what mine prints
error: unneeded sub `cfg` when there is only one condition
  --> src/keys/mod.rs:12:7
   |
12 | #[cfg(any(feature = "k256"))]
   |       ^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "k256"`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

error: unneeded sub `cfg` when there is only one condition
  --> src/keys/mod.rs:21:7
   |
21 | #[cfg(any(feature = "k256"))]
   |       ^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "k256"`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg

What version of rust are you using. You might need to do a rustup update.
There are no errors locally for me.

rustc 1.72.0-nightly (e6d4725c7 2023-06-05)f
Oh maybe this is why xD.

Thank you for the help Age :+1:


Voice: support other languages than english

Currently we only support english as language for speech to text recognition. We should allow a user to pick another language that we then download and add to the extension somehow.

I got the following error trying to select French (Canada)
Failed to install extension 'vscode-speech-language-pack-fr-ca': Error: Extension 'vscode-speech-language-pack-fr-ca' introuvable.

It can't find a vscode-speech-language-pack-fr-ca extension.

I also saw what @rzhao271 pointed out.
That said, when I manually installed the extension via the marketplace then everything worked.

I'll leave this feature request open because I believe the current flow would confuse users.
I also noticed while checking the pipelines that a bunch of the extensions did not publish due to hitting a 12 hour rate limit, though I'm not sure where that rate limit comes from.

Verification Steps:

install https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-speech
configure accessibility.voice.speechLanguage to a non-default language
open a text editor and dictate (Ctrl+Alt+V or Cmd+Alt+V)
you should get prompted to install the necessary language pack
wait for that to complete
verify the extension appears as installed
start editor dictate again and verify your language is recognised


Update process for promoting a chart from incubator to stable

What this PR does / why we need it:
It updates the documentation about how to promote a chart from incubator to stable.
Special notes for your reviewer:
I think that once a chart has been promoting from incubator to stable. The deprecated chart in the incubator repository should be removed to not have duplicates charts in the repo.

cc/ @scottrigby @viglesiasce

/hold
IIRC this was an explicit decision because it prevents someone from re-creating a chart that was deprecating and accidentally overriding a previous version (e.g. if the chart got deprecated at 0.4.0, and a new chart started at 0.1.0, 0.4.0 would still be the latest).
Even if we did remove the chart from the incubator folder, it would still be in the chart repository (just marked as deprecated), so I'm not sure removing it here actually solves the duplication concern.

@prydonius I see the issue if you are just deprecating a chart from incubator. But if you are promoting from incubator to stable, I don't like to have the same chart in both folders.
For example, the kubewatch chart has charts in incubator and stable. I don't expect that anyone will create a new chart for kubewatch in incubator if there is already one in stable no?

@tompizmor okay, I see your point that it's a special case when moving from incubator to stable. That said, I still think removing it from the folder doesn't necessarily reduce the confusion since the chart will still be in both Helm repos. What do other maintainers think @kubernetes/charts-maintainers?


Ability to hide runs in the UI

When converting from a list of Futures to a Future list of Futures, we automatically add a _make_list func to the pipeline, which shows up in the Graph representation of the pipeline in the UI. This has created confusion among users, as they have not explicitly specified them in their pipelines.
Provide the ability to hide some funcs' runs from the UI, such as _make_list, _make_tuple, the upcoming logging funcs (#363), etc.
Adding a parameter to the func to mark these runs would unnecessarily bloat its API, so for now we will go for a UI-only solution by instating a list of calculators for which to hide the runs in the UI itself. This list will initially contain _make_list and _make_tuple. Whenever a new func will need to be hidden, it will be added to that list. This does not prevent us from moving to a more configurable solution in the future.
Because the input and output edges would still need to be connected, just removing the run element from the diagram would introduce other observability issues. So instead, the "hidden" runs be represented in alternative manner, with a simple gear icon or a circle instead of a rectangle with the name label.
This icon will still be clickable, and clicking on it will take you to the run panel view. But the hidden run will not show up in the list of runs on the left of the screen.

Fixed by #454.


Change Diskcached class to public

Bugfix about travis
https://github.com/hirohisa/ImageLoaderSwift/pull/70


Documentation Errors

Describe the bug
The documentation is very poor for GUIX, for example, a typo with gx_progress_bar_pielmap_set   clearly this should be gx_progress_bar_pixelmap_set
Generally, there also other holes in the documentation.

Thanks for your feedback! We'll improve it.

Another one here:
https://learn.microsoft.com/en-us/azure/rtos/guix/chapter-4
GX_BRSUH my_brush;
GX_FONT *font;
GX_COLOR fill_color;
GX_COLOR line_color;

Thanks for your feedback! We will improve the documentation.

GUIX online documentation has been updated with the above typo fixes.


First go, copy of bob finance

@diderikvw I think this work is outdated now and this PR can be removed right?


Add check if all the packages are listed in the aea-config.yaml

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
#254
Types of changes
What types of changes does your code introduce to agents-aea?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
[x] Lint and unit tests pass locally with my changes and CI passes too
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have checked that code coverage does not decrease.
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

LGTM

Codecov Report

Merging #261 (134945c) into main (0e6f3b9) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

:exclamation: Current head 134945c differs from pull request most recent head 0a07e5c. Consider uploading reports for the commit 0a07e5c to get more accurate results

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   94.66%   94.45%   -0.21%
==========================================
  Files         312      312
  Lines       25247    25257      +10
==========================================
- Hits        23900    23857      -43
- Misses       1347     1400      +53

Flag
Coverage Δ

unittests
94.45% <100.00%> (-0.21%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aea/aea_builder.py
98.65% <100.00%> (-1.35%)
:arrow_down:

aea/cli/list.py
65.51% <0.00%> (-34.49%)
:arrow_down:

aea/cli/install.py
84.21% <0.00%> (-15.79%)
:arrow_down:

aea/components/base.py
88.48% <0.00%> (-11.52%)
:arrow_down:

aea/cli/config.py
96.15% <0.00%> (-3.85%)
:arrow_down:

aea/test_tools/test_cases.py
98.38% <0.00%> (-0.24%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


change sorting

allow better sorting. pages that have an order command are now always first, not last.
this will fix #1

I am no javascript specialist. hope the code change is fine. i am aware that maybe the syntax can be made easier, but I don't know how this can be done. I have tested everything on my local environment and it looks fine and do what it needs.

@zachleat Can you please merge?

@zachleat, can you please merge this one? I heavily depend upon this one :)

@zachleat, can you please merge? I heavily depend on this PR and the upcoming release :)

Here's a filter to sort by name if anyone needs it. It ignores order, if you need that look at @mstenz code in the MR.
eleventyConfig.addFilter("sortByName", function (obj) {
    return obj.slice().sort(function (n, o) {
      return n < o;
    });
  });

usage: {{ collections.all | eleventyNavigation | sortByName }}

Here's a filter to sort by name if anyone needs it. It ignores order, if you need that look at @mstenz code in the MR.
  eleventyConfig.addFilter("sortByName", function (obj) {
    return obj.slice().sort(function (n, o) {
      return n.title > o.title;
    });
  });

usage: {{ collections.all | eleventyNavigation | sortByName }}

@mrtnmgs That was a really useful snipped, thank you, given that there is no response to this PR for a couple of years. May I ask, how did you work on it? Just dump the output of eleventyNavigation, or did you dive into  the source code?

@zachleat @binyamin Please!

I don't have write access to this repository. Sorry.


Docs for SequenceDataset

Docstrings is needed to explain the SequenceDataset.

Hey, Can you please explain this issue to me as I want to work on it?


Which codemirror version are you using?

I am trying to integrate simplemde with another codemirror based product: https://github.com/Rovak/InlineAttachment/ which use codemirror v3.24.0, however it looks like the version is not compatible with simplemde and I got this error:

Here is the jsfiddle to reproduce the issue: https://jsfiddle.net/afrbct50/

SimpleMDE uses the very latest version of CodeMirror at build-time. It'll be version 5+.


Merge baseMapStyle to live

Docs Build status updates of commit 41e13d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingMaps/styling/map-style-sheet-entries.md
:white_check_mark:Succeeded
View

BingMaps/styling/map-style-sheet-entry-properties.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Depth shader

Changed depth shader to use techniques described here. Exposed controls to change depth power (allows for higher sampling closer to the camera, 1.0 is a linear distribution) and depth camera's far clipping plane through Unity Editor UI. Updated readme.md changelog.

@StevenBorkman This solution saves the depth data as a 2-dimensional array of RGB integer values, right? (That's how you see the depth as an image.) Do you know how to convert the RGB integer values back into floating point depth values?
We need to return via our python interface a 2-dimensional array of floats for the depth at each pixel, ideally that correspond to actual distances within Unity (so a depth of 1 is 1 unit of distance in Unity). This is what @rartiss55 is doing in her corresponding PR in the MCS repo. Thanks.

@ThomasSchellenbergNextCentury So we would have to reverse the mathematics that converts from the depth value to the RGB value (hopefully thats a one to one function) then we could take the value that should come back and multiply it against the distance between the near and far clip planes, add it to the near clip plane and get the actual distance. I haven't looked at the math yet to reverse it

This has dropped in priority and we haven't heard anything about it from TA1, so closing this PR.


Highlight new or modified directories and files

When a lot of people use droppy, find a file or directory which you weren't seen is a big problem

Good suggestion. I plan on highlighting files during and after a upload has finished.

I guess infinite feed with all files sorted by timestamp would be better.
idk do we need it?


[HUDI-4871] Upgrade to spark 3.3.1 & 3.2.3

Change Logs

Make spark3.3 profile to upgrade from Spark 3.3.0 to 3.3.1 (HUDI-4871)
Make spark3.2 profile to upgrade from Spark 3.2.1 to 3.2.3 (HUDI-4411)

Impact

hudi-spark3-bundle
hudi-spark3.2-bundle
hudi-spark3.3-bundle

Risk level
Low. Minor version upgrade.
Documentation Update

[x] Instructions in README.md are updated.
[ ] Link a separate PR is to update the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Thanks for making this change, was wondering if this is targeted for Hudi 0.12.2?

@hudi-bot run azure

Build failed due to Azure's Ubuntu 18.04 brown-out. All Spark 3.x builds have succeeded.


[release-1.4] Cherry-picking of istio.io framework enhancements

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-istioio-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold
the mirror test is flaking...

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-new-install-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-mixer-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-mixer-k8s-tests_istio_release-1.4

integ-new-install-k8s-tests_istio_release-1.4
c85ec981ec9610a9a7f03eac17e66277adb30229
link
/test integ-new-install-k8s-tests_istio_release-1.4

e2e-simpleTests-distroless_istio_release-1.4
2a94286e8cacbec905760d42ab4caae6431fa06a
link
/test e2e-simpleTests-distroless_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-simpleTests-distroless_istio_release-1.4
2a94286e8cacbec905760d42ab4caae6431fa06a
link
/test e2e-simpleTests-distroless_istio_release-1.4

integ-new-install-k8s-tests_istio_release-1.4
2a94286e8cacbec905760d42ab4caae6431fa06a
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for picking all of this up :+1:

/retest

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
2a94286e8cacbec905760d42ab4caae6431fa06a
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
eaeb65d24f74d14f11fc6bc16debb41e425c1ecd
link
/test integ-new-install-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-istioio-k8s-tests_istio_release-1.4

We may need these as well: f84039647 242880fa8 82a839967 669427a8c

We may need these as well: f840396 242880f 82a8399 669427a

Thanks, will add those as well.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.4
eaeb65d24f74d14f11fc6bc16debb41e425c1ecd
link
/test integ-new-install-k8s-tests_istio_release-1.4

integ-istioio-k8s-tests_istio_release-1.4
bbb6a24ef784c9b1fe1df07723df9761919ce4a1
link
/test integ-istioio-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio_release-1.4
bbb6a24ef784c9b1fe1df07723df9761919ce4a1
link
/test integ-istioio-k8s-tests_istio_release-1.4

integ-security-k8s-tests_istio_release-1.4
bbb6a24ef784c9b1fe1df07723df9761919ce4a1
link
/test integ-security-k8s-tests_istio_release-1.4

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Format DOCS.md

:sparkles:

Hi @sprt, thanks for your contribution! Would it be possible to rebase this PR on the develop branch please? Thanks in advance.

This looks good?

Yep, perfect otherwise 👍


RS + Dank Null (1.12.2)

Issue description:
I have an importer under a dank null docking station. I have ores set to extract all except 1. When the importer has 4 speed upgrades the behaviour is correct. When you replace 1 speed upgrade with a stack upgrade  the importer removed ALL items that have less than 1 stack in it.
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>47
Refined Storage: 1.6.15

Dank Null issue. RS just uses the normal IItemHandler interface.

No worries


build: upgrade ember-cli-typescript to v5.1.0

Build
Upgrade ember-cli-typescript to v5.1.0 (#195)
Also

fix some new type errors
add some @ts-ignore around getOwner code, see https://github.com/typed-ember/ember-cli-typescript/issues/1471

Chore
Run ember-cli-typescript blueprint (#195)
To be up to date with ember-cli-typescript config and recommandations in tsconfig.json
Running blueprints also add back @types/ember* packages in devDependencies, which solves a side effect introduced by https://github.com/peopledoc/ember-cli-embedded/pull/157/.

If we remove some @types/ember* packages from our devDependencies, they will still be included by other packages but they will resolve to a version sometimes incompatible with other @types/ember__* packages, resulting of type errors in build
Keeping us sync with ember-cli-typescript ensure we don't face this issue again in this future

Example of build failing when we remove some @types/ember__x packages that we don't use (like routing, engine, array... ; even after a yarn-deduplicate && yarn):

Run yarn-deduplicate && yarn (#195)
Fix build and test by resolving @types/ember* packages to one single version in the yarn.lock (otherwise we would have sometimes two different versions for some @types/ember* packages, which would leads to type conflicts when building app

I wanted to take a look yesterday sorry, I will try this evening.


emulator reset is broken.

Not sure what all was changed around this, but emulator reset no longer works properly.
If you run this example:
https://raw.githubusercontent.com/daid/gameboy-assembly-by-example/master/graphics/sprites.asm
The first run is fine, and the 2nd run after a reset has corrupted sprites. Indicating that something went wrong with VRAM access, which is odd that it only happens the 2nd time.

it's problem with low part of rom
add
SECTION "blank", ROM0[$0]
  jp start
  ds $10-@, 0

Wait, that would mean the emulator starts at PC=0 when reset, instead of PC=$100? That's a problem.

it's seems to be problem with binjgb - what i belive it happens that emulator "hides" lower addresses to long (if I understand it correctly on real hardware program starts from address 0 but not from rom but som internal bootrom)

Yes, the console starts at 0 and runs a boot ROM that yields back control at $100, but that can be mostly papered over as if the console started at $100 in a post-boot ROM state directly.
The bug would be that the emulator starts at $100 the first time, but then at 0 when reset?

hmm it is not bootrom ... this emulator doesn't even have bootrom ....
this is offensive line
wrapper.c: emulator_new_simple - lets observe rom_data passes from javascript
emulator.c: emulator_new - rom_data  is passed as init.rom.data(which is pointer)
set_rom_file_data init.rom is set to Emulator->file_data
then when you call emulator_delete it calls file_data_delete(&e->file_data)
and it calls xfree(file_data->data);
and if messing with input buffer which should not be freed but binjgb library

eventually patching this file (common.c in binjgb library) to delete offensive line could help

it's problem with low part of rom add
SECTION "blank", ROM0[$0]
  jp start
  ds $10-@, 0

hehe, before I posted this I was testing something and put jp start which is irrevelant here
The point was that you need to fill at least $8-$10 bytes of rom to linker not put the stuff there
in OP's example SECTION "graphics", ROM0 goes to address 0 and it is get frack but xfree error

hmmm second option is to remove
free call from javascript code here

Er, that sounds like a much deeper issue. What I find puzzling is that binjgb makes a copy of the ROM on load, so there should only be a single pointer to that ROM. (Put differently, we should always be freeing the ROM after calling emulator_new_simple.)

this is not a copy but pointer assigment

No:
static Result set_rom_file_data(Emulator* e, const FileData* file_data) {
  CHECK_MSG(file_data->size > 0, "File is empty.\n");
  CHECK_MSG((file_data->size & (MINIMUM_ROM_SIZE - 1)) == 0,
            "File size (%ld) should be a multiple of minimum rom size (%ld).\n",
            (long)file_data->size, (long)MINIMUM_ROM_SIZE);
  e->file_data = *file_data;
  return OK;
  ON_ERROR_RETURN;
}

* in *file_data does dereference the pointer.

sure ... but structure holds pointer

Nope, it holds a FileData.

I think this is solution https://github.com/gbdev/rgbds-live/issues/28#issuecomment-2359610482

Yes, that would be correct. (I would add a comment right above emulator_new_simple that it takes ownership of the allocation, and will free it on its own when destroyed.)

Yes, that would be correct. (I would add a comment right above emulator_new_simple that it takes ownership of the allocation, and will free it on its own when destroyed.)

yeah, one year from now someone will add free again :D

I cannot reproduce the error in the OP anymore. Why was the issue reopened?

Looks fixed for this specific case, didn't check if is luck or if the timing is 100% the same now for both runs.


Publish in Maven repo

It is necessary to find a way to use development using a Maven repo.

https://jitpack.io/#jabrena/ev3dev-lang-java/006b2a0558

http://cemerick.com/2010/08/24/hosting-maven-repos-on-github/

https://jitpack.io/#jabrena/ev3dev-lang-java/v0.1.0


Fixing result grid plans not opening execution plan editor.

This PR fixes #20964
It seems it had nothing to do with the merge. Whenever the new execution plan editor tab was opened, the disposed was called and the editor input was disposed causing the new tab to close.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.002%) to 41.94%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/query/browser/gridPanel.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/common/processService.ts
2
81.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
28870

Relevant Lines:
63938

💛  - Coveralls


Update To Add java.time Immutable Classes To JdkConfiguration.

No response, I think not having a quoted class name is fine. Shall find out if I'm wrong.

@bharatbhasin thank you for your contribution, I appreciate it.


TACLSMining 1.0.4 override

Can you throw in an x_netkan_epoch of "1"? The most recent version of the mod on Kerbal Stuff is 1 but the version previous is 1.0, so that version will be treated as the latest because 1 < 1.0.

Good catch. As an aside: any idea why CKAN-meta doesn't have the 1.0 version?

They were released on the same day and I'm willing to be pretty close together in time, so due to KSP-CKAN/NetKAN#236 the bot probably didn't catch it.


lost a file during building sgx_detect.Dockerfile ?

Step 15/20 : ADD prebuilt/ra-test/app .
ADD failed: file not found in build context or excluded by .dockerignore: stat prebuilt/ra-test/app: file does not exist

You have to build from source https://github.com/Phala-Network/ra-test, because we use IAS so the SGX binary required private key signing that we can not public, I think I should rename the dockerfile to prebuilt_sgx_detect.Dockerfile


Added prerelease and release workflow to deploy sandbox environments

Closes #DNE
What's Changed

Draft pending token creation
Screenshots

TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example App Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

We probably need to add an extra step using https://github.com/marketplace/actions/github-app-token to generate a token from a GitHub app that has access to the sandboxes repo.


Use window.location.href for current URL

Replaces react-router logic for tracking the current URL
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/217505
Tests

Log into a new OldDot account with no policies
Use the "Get started with our free plan" inbox task to create a Workspace
Verify the workspace is successfully created in NewDot
Sign out of NewDot
Log back in and verify another workspace is NOT created
Sign out again and leave the tab open
Return to OldDot and navigate to Settings > Policies > Group
Create another free plan policy
Verify only 1 additional workspace (2 in total) is created in the second NewDot tab.

[x] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
Same as Tests

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/6833644/186241301-4196a09b-7fbc-4d57-b1f2-87e7e431fed2.mov
Mobile Web

Desktop

iOS

Android

@marcaaron friendly bump

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @marcaaron in version: 1.1.97-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@arosiclair Do we have to login to mWeb / chrome browser or OldDot app for step 1 "Log into a new OldDot account with no policies" ?

@arosiclair Do we have to login to mWeb / chrome browser or OldDot app for step 1 "Log into a new OldDot account with no policies" ?

desktop chrome browser

@arosiclair  Web environment was tested already.  How to test in iOS , Android  and Desktop?

@arosiclair Web environment was tested already. How to test in iOS , Android and Desktop?

This feature is not supported on these platforms so No QA for them

Just mentioning here that this PR was a suspect for this fireroom. It would be great for anyone with context to take a look at this issue. Thanks!


"Cannot call vkSetEvent() on event that is already in use by a CB" error reported despite a vkDeviceWaitIdle() call

Consider the following use case:
(all commands below operate on the same event, three unique command buffers are pre-recorded and submitted in a round-robin manner per each frame)

Host-side vkSetEvent() call is made.
A command buffer, holding vkCmdWaitEvents() and vkCmdResetEvent() invocations, is executed GPU-side
[frame presentation]
A vkDeviceWaitIdle() call is executed.
Go to step 1.

Starting with the second iteration, the following debug call-back is incorrectly reported at step 1:
"Cannot call vkSetEvent() on event X that is already in use by a command buffer":
I had a brief look and it seems that vkDeviceWaitIdle() handler in core_validation does not reset the "in_use" counter for the event:

The in_use counter is increased by 2 at the first submission, but never reset back to 0.

I have one more related issue. Consider these steps:
// recording a CB
vkCmdWaitEvents(cb, 1u, &event, VK_PIPELINE_STAGE_HOST_BIT, VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, 0u, NULL, 0u, NULL, 0u, NULL);

// some time later
vkQueueSubmit(queue, 1u, &submitInfo, NULL);

vkSetEvent(device, event);

In other words, inside a command buffer I'm waiting for an event that is signaled on the host. Note source flags are specified correctly, i.e. have VK_PIPELINE_STAGE_HOST_BIT. Still, I'm getting this error:

DS(ERROR): object: 0 type: 0 location: 8532 msgCode: 17: Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x4000 which must be the bitwise OR of the stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.

If I use vkSetEvent before vkQueueSubmit, all is good and no errors appear. If I use wrong flags, I'm getting an error as expected. So I think some internal state is being updated in vkSetEvent is fine, but the checks are done upfront in vkQueueSubmit before it happens.

We're hoping this is handled by PR #400.  Dominik, can you check after it's pushed and close if things look OK?

Will do

No longer repros. Well done!

Sweet!  Thanks Dominik.


Add image support for text extraction

This pull request adds support for extracting text from images. It also updates the PDF library to the non-deprecated version (PyPDF2 -> pypdf).
Specifically, these changes will:

Update the services/file.py script to handle image MIME types and use the pytesseract library for OCR text extraction.
Replace the deprecated PyPDF2 library to pypdf (same library, different name).
Update poetry to include the new library dependencies.
Add tests for both image and pdf extraction methods, including test pdf files

Please check it out and let me know if you have any feedback.

Awesome work! I just wanna process my data from an image. By the way, does it works for .jpg or .png?

@wangxuqi It should work for any image that tesseract supports, I've confirmed it works on png jpg and tiff.


Large data

If we are aiming at support large data in the future, we can take advantage of the memory mapping mechanism in Julia which allows reading files that do not fit in the memory. For example, the 3D AMR data reading test above for fsgrid variables will crash the Julia session on the second attempt --- this can be solved with the mapping/paging technique that is more commonly used in big data processing.

Now we use Mmap from Julia Base to do memory-mapped I/O.

Be careful about the usage of mmap. Since we have to aligned with the memory page, reinterpret is required. However, ReinterpretArray may not work well with intrinsic functions like findfirst:
using Vlasiator
using Vlasiator: getObjInfo, readvector
using Mmap
using BenchmarkTools

function foo1(meta, var, ids)

   cellid = readvector(meta.fid, meta.footer, "CellID", "VARIABLE")

   T, offset, arraysize, _, vectorsize = getObjInfo(meta.fid, meta.footer, var, "VARIABLE", "name")

   v = Array{T}(undef, vectorsize, length(ids))

   a = Mmap.mmap(meta.fid, Vector{UInt8}, sizeof(T)*vectorsize*arraysize, offset)

   w = reshape(reinterpret(T, a), vectorsize, arraysize)

   r = [findfirst(==(i), cellid) for i in ids]

   for i in eachindex(r)
      for iv = 1:vectorsize
         @inbounds v[iv,i] = w[iv,r[i]]
      end
   end
   v
end

function foo2(meta, var, ids)

   cellid = readvector(meta.fid, meta.footer, "CellID", "VARIABLE")

   T, offset, _, datasize, vectorsize = getObjInfo(meta.fid, meta.footer, var, "VARIABLE", "name")

   rOffsets = [(findfirst(==(i), cellid)-1)*datasize*vectorsize for i in ids]

   v = Array{T}(undef, vectorsize, length(ids))

   for i in eachindex(rOffsets)
      seek(meta.fid, offset + rOffsets[i])
      @inbounds read!(meta.fid, @view v[:,i])
   end
   v
end

function foo3(meta, var, ids)

   cellid = readvector(meta.fid, meta.footer, "CellID", "VARIABLE")

   T, offset, arraysize, _, vectorsize = getObjInfo(meta.fid, meta.footer, var, "VARIABLE", "name")

   v = Array{T}(undef, vectorsize, length(ids))
   w = Array{T,2}(undef, vectorsize, arraysize)
   seek(meta.fid, offset)
   read!(meta.fid, w)

   r = [findfirst(==(i), cellid) for i in ids]

   for i in eachindex(r)
      for iv = 1:vectorsize
         @inbounds v[iv,i] = w[iv,r[i]]
      end
   end
   v
end

function foo4(meta, var, ids)

   cellid = readvector(meta.fid, meta.footer, "CellID", "VARIABLE")

   T, offset, arraysize, _, vectorsize = getObjInfo(meta.fid, meta.footer, var, "VARIABLE", "name")

   v = Array{T}(undef, vectorsize, length(ids))

   a = Mmap.mmap(meta.fid, Vector{UInt8}, sizeof(T)*vectorsize*arraysize, offset)

   GC.@preserve a begin
      w = unsafe_wrap(Array, pointer(reinterpret(T, a)), (vectorsize, arraysize))

      r = [findfirst(==(i), cellid) for i in ids]

      for i in eachindex(r)
         for iv = 1:vectorsize
            @inbounds v[iv,i] = w[iv,r[i]]
         end
      end
   end
   v
end

function foo_read(meta, ids)
   T, offset, arraysize, datasize, vectorsize = getObjInfo(meta.fid, meta.footer, "CellID", "VARIABLE", "name")
   w = vectorsize == 1 ?
      Vector{T}(undef, arraysize) :
      Array{T,2}(undef, vectorsize, arraysize)
   seek(meta.fid, offset)
   read!(meta.fid, w)
   r = [findfirst(==(i), w) for i in ids]
end

function foo_mmap(meta, ids)
   T, offset, arraysize, datasize, vectorsize = getObjInfo(meta.fid, meta.footer, "CellID", "VARIABLE", "name")
   a = Mmap.mmap(meta.fid, Vector{UInt8}, sizeof(T)*vectorsize*arraysize, offset)
   w = vectorsize == 1 ?
      reinterpret(T, a) :
      reshape(reinterpret(T, a), vectorsize, arraysize)
   r = [findfirst(==(i), w) for i in ids]
end

filename = "test/data/bulk.2d.vlsv"
var = "proton/vg_rho"
ids = 3000:6300

meta = load(filename);

@btime foo1($meta, $var, $ids);
@btime foo2($meta, $var, $ids);
@btime foo3($meta, $var, $ids);
@btime foo4($meta, $var, $ids);

@btime foo_read($meta, $ids);
@btime foo_mmap($meta, $ids);

With read used in readvector:
  7.748 ms (12238 allocations: 293.47 KiB)
  12.770 ms (25945 allocations: 765.42 KiB)
  7.944 ms (12235 allocations: 342.59 KiB)
  7.931 ms (12241 allocations: 293.58 KiB)
  7.545 ms (23 allocations: 75.91 KiB)
  56.274 ms (25 allocations: 26.78 KiB)

With mmap used in readvector:
  56.153 ms (12241 allocations: 244.36 KiB)
  63.204 ms (25948 allocations: 716.30 KiB)
  56.801 ms (12238 allocations: 293.48 KiB)
  56.863 ms (12244 allocations: 244.47 KiB)
  7.536 ms (23 allocations: 75.91 KiB)
  56.585 ms (25 allocations: 26.78 KiB)

As such, we can improve a little bit on the selected DCCRG cell reading by reducing the number of read calls, but in general it is not a good idea now to switch everything to mmap.


bicep-azure-static-web-apps-azure-devops -> error "Cannot change the RepositoryUrl"

I ran into alike problem which was described by Shane Neff :
I got this error:
Starting template validation.
Deployment name is main-20211216-190201-a25c
There were errors in your deployment. Error code: InvalidTemplateDeployment.
##[error]The template deployment 'main-20211216-190201-a25c' is not valid according to the validation procedure. The tracking id is '0dc2b50a-78bf-4b07-b8ea-e4a87dc8104f'. See inner errors for details.
##[error]Details:
##[error]BadRequest: RepositoryUrl is invalid.  Cannot change the RepositoryUrl. Please detach your static site first if you wish to attach to another repository.
##[warning]Validation errors were found in the Azure Resource Manager template. This can potentially cause template deployment to fail. Task failed while creating or updating the template deployment.. Please follow https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax

And this is also solved with disconnecting the static website.
Maybe you can also add my problem to your blog?

What sort of update would you suggest?

@johnnyreilly
That besides the error "Provider is invalid workaround 2", a new workaround can be added like "RepositoryUrl is invalid workaround".
The solution would be the same as suggested by Shane Neff.

Would you like to send a pr?

I will do.


Update appledoc22 to version 2.2.1

Thanks for the contribution! However, this should continue to build from source rather than install the prebuilt binary.

Is building from source always the preferred method? Because the current implementation broke - probably with some system change.
Also, the way this formula is setup, it would pull down a pre-set source code version and just build that.
I don't see any real benefit in that but instead just unnecessary complexity and fragility but am happy to hear other opinions :smiley:

Updated the PR, should be mergable now. Thanks again.

Building from source is always the preferred method, yes. Homebrew's a source-based package manager that also distributes binaries that we build, using the source recipes; all of the packages in this repository need to be built from source.

Also, the way this formula is setup, it would pull down a pre-set source code version and just build that.

This is the standard for Homebrew! Formulae are set up to use specific versions.

Thanks for updating the PR so promply!

@BrewTestBot test this please

@mistydemeo Any objections to this being merged? Had the bot regenerate the bottles this morning so they're available on Bintray rather than SF, so one of us can pull it if you're happy :)

Merged! Thanks for your contribution to Homebrew, We appreciate it!


Added elaborations for parent or child access.

Fixes #35738
I got a chance to play around with this, couple of conclusions:

The phrasing of the messages definitely needs a bit of work and I am open to suggestions
I excluded from these elaboration cases where the target type might be compatible with too many other types. What is excluded are: Object, Function, weak types, any, empty object types, object types with only index signatures. These are of course up for debate but form the messages I saw while running the tests these seem like a good set to exclude.
I only trigger child access elaborations for identifiers, property access or calls, things like literals (object or array in particular) seem like a bad place to elaborate in such a way. If someone creates an object it is not likely they meant to access a property of it.
I also excluded properties coming from Function and Object, although toString still appears as a suggestion in some places (still looking into that)
The error span for assignment errors  has moved from the target of the assignment to the source of the assignment (only when this elaboration is triggered). While this was not necessarily intentional, the result might be appropriate.  Since the suggested action relates to the source this might be a good fit. Thoughts ?

I still need to add explicit tests for the new feature, I will probably get a chance to do so soon enough (this week).
cc: @DanielRosenwasser

Would appreciate some ideas from @RyanCavanaugh and @weswigham too

I made the following changes to the suggestions:

I only trigger the suggestions for dotted names
Improved error messages, both in phrasing and context (I now use the actual dotted name not the type)
Removed suggestions from Object and Function, these usually seem unhelpful
If multiple properties would be valid list them all up to a maximum of 5 then do not trigger this suggestion at all (To suggest one property:  prescient!. To suggest 3-4: maybe useful. To suggest more then 5: just dumb)

I am reasonably pleased with the suggestion this makes now. If any of @DanielRosenwasser @RyanCavanaugh @weswigham have more suggestions I will of course implement them, but I think it is pretty much ready.

To help with PR housekeeping, I'm going to close this draft PR. It's pretty old.


fix(incremental): dont delete old entity from LMDB if we clear it already

Summary

fix this case failure:  FAIL spec/02-integration/09-hybrid_mode/01-sync_spec.lua:146: CP/DP communication #postgres inc_sync=on sync works proxy on DP follows CP config.
DP receive full sync deltas, but one of this operation needs it to delete a key from the lmdb, but this key does not exist in lmdb if the detals has wipe flag, so it trigger error: 2024/10/15 14:53:05 [error] 31827#0: *8 [lua] rpc.lua:329: unable to create worker mutex and sync: MDB_NOTFOUND: No matching key/data pair found
Checklist

[ ] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5551

Please refer to this commit: https://github.com/Kong/kong/pull/13746/commits/3e25a8028fc500707efc5c30c3998652a42bffeb

Please refer to this commit: 3e25a80

wait a mine

already fixed in original pr.


Pass linker flags(LDFLAGS) to compiler

Signed-off-by: Amarnath Valluri<EMAIL_ADDRESS>

It generally looks good to me. It would be great if you could explain what kind of extra linker flag was needed on your system.
In general, I have plans to add multithreaded benchmarks too. And supporting pthreads is a pain with a plain makefile, because the exact compiler options differ on different systems. So changing to CMake might be the best choice.